Bug - Nora does not respect song order/index metadata

Describe the bug
Nora does not respect the order in which a song is to be played when metadata includes a track number regardless of the indexing option being turned on or off.
This has been tested in both .mp3 files and .flac, indexing enabled in Nora.
To Reproduce

(optional) Go to settings and enabling indexing
Play an album of your choice or add a album from a folder to the queue
Go to the queue and compare the song order to the song order in your file explorer
Song order will not match

Expected behavior
Albums played or folders added to the queue should respect the play order/index metadata unless shuffle is enabled.
Bellow is a screenshot comparing song order in Nora and song order in file explorer with the metadata showing its respective order.
Screenshots

Log File
N/A - Not applicable
System Information:

OS: Windows 11 Pro - 22621.1635
Affected App Version: 2.0.0 Stable

Additional context
As stated above this issue affects most if not all file formats, I have only tested it with .mp3 and .flac, I suspect if this is not implemented yet or intended behavior it is likely being caused by the song ordering being overridden by the sorting order.
Also not related to the issue at all, I wanted to add my appreciation for your work on this music player, I'm very impressed by the visuals of Nora and overall performance. I've been looking for a new music player for quite a while now and the initial impressions are very good, I see lots of untapped potential! Only thing else I'd like to add is its unfortunate there is no way to change the accent color from just light blue, hopefully you can find a way around the problem so this could be a possibility in the future.

@Neptune-mk2
Thanks for your honest opinion of Nora.
I think you are correct to assume that I didn't implement this feature for Nora. I didn't know there should be functionality like this for the disc number.
To verify this functionality, the song order should be followed only in albums, right?

To verify this functionality, the song order should be followed only in albums, right?

Yes, at least in its usual use case Albums is where you would want a song to play in a specific order because some songs may include specific tracks like a "intro/outro" or are meant by the album artist to tell a "story", without the track order the album may not play as intended by the album artist.
In other occasions though you might want to keep song order outside of albums, as an example if you want to make a playlist with different albums but want them to play in their original order.
I'm not very technical when it comes to programming, but I imagine doing this would also require figuring out problem like "How would it handle multiple songs with the same track number"
To that I did have a rough idea on how that could be resolved not sure if this is how it works but, maybe you can check the metadata for album name first then track number to derive the play order.
This way even if you have multiple songs with track number 1, but it would first prioritize the album name first then the track number.
So album sorting would retain the A-Z order then track number order unless shuffle is specified or any other sorting method is selected.

@Neptune-mk2
Maybe I can add a new sorting option for albums as the default sorting option which sorts the songs in an album according to their track number.
But since I currently don't save the track number for each song, for this feature to take effect you should reset the app.

@Neptune-mk2
Maybe I can add a new sorting option for albums as the default sorting option which sorts the songs in an album according to their track number.
But since I currently don't save the track number for each song, for this feature to take effect you should reset the app.

That sounds like a great idea, much simpler than the way I though of.
Looking forward to it 😄

But there's another problem.
Then the user has to go to the Album Info Page, select the Track Number as the sorting option, and then select Play All for this to work. This won't work when you right-click on an album and select play.

Oh I see, I'm not quite sure what would be the best way to handle that.
The way other music players handle it by default they sort by track number when inside the album, VLC also seems to do this.
Maybe the sorting option might have to be a option default that can be changed in settings, if that doesn't work I'm afraid I'm out of ideas.

For the time being I will implement the feature as I mentioned before.
If it's not working as expected, you can mention me again about it.

hi - can you add this sorting option to folders too?


Fix/enable parity

What
Added commits from master which were not in develop and fixed merge conflicts.
How to review
LGTM.
Who can review
Anyone.

Aren't these different commits to the ones in master? Could we merge master instead so that both develop and master are aligned?

Aren't these different commits to the ones in master? Could we merge master instead so that both develop and master are aligned?

These are cherry picked from master. Would it not yield the same result?
Saves me discarding all the different changes between master and develop as well as well as trying to fix the numerous merge conflicts.

Well kind of, the code will match but we will have duplicated commits with half of them not present in develop which is not right. It seems like a simple change so the conflicts should be quite easy to fix?

Well kind of, the code will match but we will have duplicated commits with half of them not present in develop which is not right. It seems like a simple change so the conflicts should be quite easy to fix?

https://github.com/ONSdigital/florence/pull/891


fix: derive_param_tte() fails for dplyr 1.1.0

Closes https://github.com/pharmaverse/admiral/issues/1962
Linked PR: #1962
What happened?
If dlpyr 1.1.0 is used, some tests for derive_param_tte() fail. They pass for dplyr 1.0.5 (minimum version required by admiraldev) and also for dplyr 1.1.1.
In derive_param_tte()
full_join(
  mutate(by_groups, temp_dummy = 1),
  mutate(source_datasets[[i]], temp_dummy = 1),
  by = "temp_dummy",
  relationship = "many-to-many"
) %>%
select(-temp_dummy)

should be replaced by
crossing(
  by_groups,
  source_datasets[[i]]
)

We fisnished this one in #1997.  Thanks again for trying to fix this - I still recommend running through the Onboarding issue to get some more experience on how we operate.  - #1839
This test issue might be a good one to jump on - https://github.com/pharmaverse/admiral/issues/1466


migrate bignumber to use builtin controls

CATEGORY
Choose one

[ ] Bug Fix
[ ] Enhancement (new features, refinement)
[x] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

The BigNumber plugin has been updated to handle its own controls registration. This updates the plugin to the new version and removes the controls from incubator-superset.
TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@rusackas @kristw @ktmud

I installed @babel/compat-data to fix errors that popped up when running dev-server, but I'm not sure why it's required. Might be a peer dependency somewhere. Anyway, it started working again once I installed it.

Codecov Report

Merging #9707 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9707      +/-   ##
==========================================
- Coverage   65.90%   65.79%   -0.12%
==========================================
  Files         586      584       -2
  Lines       30383    30376       -7
  Branches     3110     3109       -1
==========================================
- Hits        20025    19986      -39
- Misses      10174    10206      +32
  Partials      184      184

Flag
Coverage Δ

#javascript
58.89% <ø> (+0.03%)
:arrow_up:

#python
70.66% <ø> (-0.22%)
:arrow_down:

Impacted Files
Coverage Δ

superset-frontend/src/setup/setupPlugins.ts
0.00% <ø> (ø)

superset/views/database/mixins.py
58.92% <0.00%> (-21.43%)
:arrow_down:

superset/utils/cache.py
45.83% <0.00%> (-20.84%)
:arrow_down:

superset/db_engine_specs/mysql.py
78.26% <0.00%> (-13.05%)
:arrow_down:

superset/views/database/api.py
83.90% <0.00%> (-3.45%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.29% <0.00%> (-2.71%)
:arrow_down:

superset/models/core.py
84.47% <0.00%> (-2.39%)
:arrow_down:

superset/views/core.py
74.88% <0.00%> (-0.23%)
:arrow_down:

superset/connectors/sqla/models.py
88.41% <0.00%> (-0.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad8209...f38ae67. Read the comment docs.


Transfer Ownership

Not sure if this is a domain config issue or something with gdrive, but I am trying to use gdrive to change ownership of a file or folder, but I am receiving the following error.
Failed to share file: googleapi: Error 403: The transferOwnership parameter must be enabled when the permission role is 'owner'., forbidden
Ultimately I would like to be able to recursively change ownership of a folder, but that seems to be a very complicated task with Google Drive.

Relevant code is in drive/share.go, need to set the TransferOwnership flag on the PermissionsCall for 'owner' to work. Was trying to do the same thing myself (transfer ownership recursively)

func (self *Drive) Share(args ShareArgs) error {
    permission := &drive.Permission{
        AllowFileDiscovery: args.Discoverable,
        Role:               args.Role,
        Type:               args.Type,
        EmailAddress:       args.Email,
    }

    call := self.service.Permissions.Create(args.FileId, permission)
    if permission.Role == "owner" {
        call.TransferOwnership(true)
    }

    _, err := call.Do()
    if err != nil {
        return fmt.Errorf("Failed to share file: %s", err)
    }

    fmt.Fprintf(args.Out, "Granted %s permission to %s\n", args.Role, args.Type)
    return nil
}

Please merge this request to fix this issue: https://github.com/gdrive-org/gdrive/pull/331


Add itemExtent

Add itemExtent to AnimatedSliverChildBuilderDelegate and elsewhere, where it's applicable, if there are such places.

I'm currently working the a new version of this package, and this feature has already been included.
Please, stay tuned! It will be released shortly.

Please, try the itemExtent attribute present in the new version (0.1.0) of this library.


Add heading links example

@trevorsaint  - The developers needed an example of this for the internal interface. I thought I'd take the opportunity to try out the styleguide. I've based the code on the GOV.UK category pages, but feel free to change if you want.

Thanks for this Tim.


Ampersands in callback URL query strings should be percent-encoded.

In Manager.swift, in the Manager.sendRequest(_:) method, the x-success, x-failure and x-cancel parameters to the outgoing URL include their own query strings that include responseType and requestID parameters as well as any response parameters for a given action.
The ampersand characters (&) that delimit these embedded query strings should be percent-encoded; otherwise, they get parsed as query parameters of the outgoing URL, instead of the response URLs.
A typical URL that is built by this method looks like this, just before calling Manager.openURL(URL) (in line 228):
otherapp://x-callback-url/actionName?x-source=MyAppName&
  x-error=myapp://x-callback-url/response?responseType=error&requestID=9CE4D406-EB4E-4242-8ACD-14851A81A588&
  x-cancel=myapp://x-callback-url/response?responseType=cancel&requestID=9CE4D406-EB4E-4242-8ACD-14851A81A588&
  x-success=myapp://x-callback-url/response?responseType=success&requestID=9CE4D406-EB4E-4242-8ACD-14851A81A588

The problem is that the requestID parameter gets stripped from the response URLs, thus the Manager.handleOpenURL(_:) method fails to match up the response to its request (on line 77) and does not call the response handler closures.

I will add something like that on String to do the job
   var urlQueryEncoded: String? {
       return self.stringByAddingPercentEncodingWithAllowedCharacters(NSCharacterSet.URLQueryAllowedCharacterSet())
   }

That won't work, because the ampersand character is in the URLQueryAllowedCharacterSet.
You'll need to do something like:
var ampersandEncoded: String? {
    let nonAmpersandCharacters = NSCharacterSet(charactersInString:"&").invertedSet
    return self.stringByAddingPercentEncodingWithAllowedCharacters(nonAmpersandCharacters)
}

...then apply that to each of the callback URL query strings.

ok I misunderstood the problem and copy wrong code from another project.
when I have access to a mac computer and xcode I will fix this

fixed by encoding the query parameters with:
    var queryEncodeRFC3986: String {
        let generalDelimitersToEncode = ":#[]@" // does not include "?" or "/" due to RFC 3986 - Section 3.4
        let subDelimitersToEncode = "!$&'()*+,;="

        let allowedCharacterSet = NSCharacterSet.URLQueryAllowedCharacterSet().mutableCopy() as! NSMutableCharacterSet
        allowedCharacterSet.removeCharactersInString(generalDelimitersToEncode + subDelimitersToEncode)

        return self.stringByAddingPercentEncodingWithAllowedCharacters(allowedCharacterSet) ?? self
    }

and don't let NSURLComponents encode again (or incorrectly) the query by using percentEncodedQueryproperty


Lots of issues

To be honest I could barely get this plugin to work. I tried multiple folder structures, and finally got it to accept the folder. I made sure the path was correct with / and everything.
None of my contacts are showing up on the side pane, two did for a split second then they disappeared. Although they were just empty boxes with no info showing up.
Sorry I can't describe it more, it is just nothing is working like it should. Maybe it is cause I have too big of an index? 5000 entries, but that shouldn't be the case I don't think for this plugin.

Thank you for the feedback! Hope this fix will help. Please let me know if it doesn't


Change the display order of ideas

Use:

hack-day
hack-ideas
collaborative-ideas

Done but in a horrible hacky way.


Add ability to specify validation context

In some cases, users want to run API-specific validations. This commit allows
to pass a validation context to the JSONAPI::Resource#_super method.

@lessless Thanks! I'm a little concerned that this is going to break existing code that uses POROs, but it does make it more consistent with ActiveRecord so that's probably worth it. We just need to call it out in the release notes.

Thank you for the help, Larry! Unfortunately, my english not good enough to write documentation and I'm afraid developers will get wrong impression about the project if they see my wording in the README.


Add static website generator

Is there a reason why Jekyll and Pelican are missing from this awesome page ?

Please add and create PR

Eager to accept PRs over at https://github.com/b-long/awesome-static-hosting-and-cms .  Of course, I'll defer to @agarrharr

It because this isn’t a list about all things around static websites. It just about services that you can use on a static site.

So @agarrharr ... would you consider approving a PR with static site generators?

Eager to accept PRs over at https://github.com/b-long/awesome-static-hosting-and-cms . Of course, I'll defer to @agarrharr

@b-long, we can also explore them in your repo. Actually, you gave me the idea to google:
jekyll pelican site:github.com inurl:awesome -inurl:jekyll -inurl:pelican

So, is not a bad idea to consolidate them somewhere.

awesome-static-hosting-and-cms is probably a better fit.


Allow developers/testers to stand up their own database and Keycloak realm

Description
Allow developers/testers to stand up their own database and Keycloak realm
Remove dependencies on existing infrastructure.

Types of changes

New feature (non-breaking change which adds functionality)
Documentation (non-breaking change with enhancements to documentation)

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Further comments

SonarQube Analysis: https://sonarqube-vmvfjv-tools.pathfinder.gov.bc.ca/dashboard?id=common-forms-toolkit-pr-109


Update prediction.py

Corrected the help description for the project_id argument of argparse

I signed it!

Please conform to these guidelines in your commit message - in particular, "Update prediction.py" isn't a very informative subject line (there's probably space in fifty characters to mention that you are correcting a defect) and your non-subject-line text may be too long and is missing a period at the end.
Thank you for the fix!

Thanks for the feedback. I'll close and start a new pull request with the proper commit message.

Thanks for

There was no need to close this. :-(


[5.6] Fix bugs in builds done on request from command plugins

This is the 5.6 cherry-pick of https://github.com/apple/swift-package-manager/pull/4039.

@swift-ci please test


Cannot read property of uuid

I am using the docker installation, did the whole config, have 2 cards for testing but no reaction on my Sonos system.
The docker log is showing the following, can anyone help me please?

magic-cards       | [1] Read Card ID:<PHONE_NUMBER>
magic-cards       | [1] Finding card...
magic-cards       | [1] Found card: Spotify album xyz. Processing...
magic-cards       | [1] Processing action: Sonos
magic-cards       | [1] Calling: http://<IP_ADDRESS>:5005/Kitchen/repeat/all
magic-cards       | [1] Calling: http://<IP_ADDRESS>:5005/zones
magic-cards       | [1] (node:72) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'uuid' of undefined
magic-cards       | [1]     at SonosAction.forcePlaylistPlayback (/usr/src/app/scanner/actions/SonosAction.js:59:70)
magic-cards       | [1]     at
magic-cards       | [1]     at process._tickCallback (internal/process/next_tick.js:182:7)
magic-cards       | [1] (node:72) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
magic-cards       | [1] (node:72) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.`

Thanks for your help,
Regards derMick

Ok, problem found. I had to translate the Sonos room names into the my selected language of the Sonos system...


Add flag to enable/disable network checks

The flag was added for enterprise-2.2 branch and we are porting it to master, so we can stay in sync (https://github.com/travis-ci/travis-build/commit/491197656370cf77a1fe709aa6e4480efd1aabe5)

I just decided to follow the patterns that exist in the files, adding the configuration below network and respecting the naming conventions, besides that everything would be the same, except for a problem that is what I mention on my comment before.
The TRAVIS_WAIT_FOR_NETWORK_CHECK variable actually skips the network check instead of waiting for it, so I tried to resolve the confusion. Since we are bumping a major version on Enterprise, I think we should communicate the changes and remove the old one to avoid confusion.

Note also that all the config names start with TRAVIS_BUILD_

I also think we should wait and also I want to test this somehow because it doesn't contain any tests

@ggcampinho-travis If you check out this comment from Danish in the issue surrounding this in the travis-enterprise repo it sounds like maybe this commit is actually not required. We could accomplish the same thing by setting an existing env var to an empty string.
Whether we want to actually make this available for configuration for customers is, to me, a moot point for this PR. All we wanted to accomplish is to say "we can use the master version of travis-build in enterprise" and this seems to say to me that the answer is "Yes".
What do you think?


Hard-to-debug error behavior with static VMs

I wrote a static VMs file, but accidentally left the public key path blank. I had a config file like this:
static_vms:
  - &vm_1
    ssh_private_key:
    ip_address: ...

This lead to PKB looping on "waiting for boot completion" but never erroring out. Here is what I think happened: YAML parsing returned a dict with "ssh_private_key": None as a member. This got passed around until the None propagated to vm_util.IssueCommand, which constructed an ssh command string that included "-i None". This, predictably, failed to SSH, and so IssueCommand returned an error. However, the retry loop at linux_virtual_machine.py:390 didn't realize that the error was unrecoverable and kept retrying, resulting in an apparent PKB hang.
Ideally, PKB would detect that the SSH private key was not specified and error much earlier in the process.

Thanks for the bug catch and write-up. I'll add this to my backlog.


Using datetime parameter in custom connector on Power BI service

Hello,
I've compiled the connector for SQL direct queries that is placed here.
All works good and I'm able to change the parameters.
Say, if I add the third parameter:
shared DirectSQL.Database = (server as text, database as text, p as text) as table =>
and then I change TestConnection function like:
TestConnection = (dataSourcePath) =>          let             json = Json.Document(dataSourcePath),             server = json[server],             database = json[database],             p = json[p]         in             { "DirectSQL.Database", server, database, p},
then it works well in Power BI Desktop and Power BI service both.
What I want to do is to pass a parameter of datetime type. But once I change the type of third parameter Power BI service can't find my connector through gateway. So, I can't setup a data source using this connector and as a consequence can't refresh a data. At the time it works well in Power BI Desktop.
Is there some way to pass parameter of datetime type to TestConnection function?
Thanks in advance,
Alex.

Did you ever find a solution to this @alex-v-ivanov ?

Hi @Tealons,
Sorry, but it was so far...
Actually, I forgot what the issue was, where I was trying to implement this and for why.
I don't remember, sorry


Refactor tox.ini

Fix #317

r? @geier

r as in meRge? Sure and thank you very much!

r? as in review. It's used heavily in rust-lang/rust, might as well use it outside! :O

lgtm :) does what it's supposed to do and looks cleaner than before.


Tuya cloud support

Hi,
the last days I was looking into the topic using the roborock app with homebridge. The roborock app uses the Tuya cloud and It seems that the tuya token can be extracted like it is described here: https://github.com/redphx/roborock-tuya-token
The owner of this repository told me that the Token in Roborock app is for Tuya protocol and the Token in Mi Home app is for Miio protocol. So there is a difference in the used protocols. The tuya api can be found here: https://codetheweb.github.io/tuyapi/
Is it possible that you also implement the Tuya protocol into this homebridge plugin?
Thanks!

there are plans to do so, yes! thanks for creating the issue.
Adding a link to the Roborock App issue #104

Any news on the tuya integration?

sorry, not on my end... I recently had a baby and time is really limited to work on any side-projects 😅
However, PRs are welcome :)

Hey @afharo, how is the implementation going? :-)

Hi guys any news about the implementation?


CONTRIBUTING.md doesn't explain redis appropriately

As a potential contributor,
When I read instructions to set-up my environment,
It says I don't need to use Redis unless I'm working on ActiveJob things
It should say that you need to run it
I have a #657 open with a slight change in wording.

This was fixed in #657


Jupyter kernel keeps dying

Hi
I was trying to run this project on jupyter notebook that I set up on ec2 t2.small instance, but the kernel keeps dying after model.fit_generator is supposed to run.
The message I get in command line is
KernelRestarter: restarting kernel (1/5), keep random ports
Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 FMA
While I know it is just a warning and it should run just fine, I have no clue why the kernel keeps dying.
Any help is appreciated.

Hello,
The issue maybe with the memory availability. Try to change the batch size and step size. Play with the batch size and step size till you find right values for your machines configuration.

Hello
I tried to change this, but kernel still eventually dies.
Can you please specify which versions of python and tensorflow to use? For the very first time I believe I used the latest, but then I learned that from tensorflow 2.2.0 fit_generator was deprecated. For this reasons I changes tensorflow to 1.15 and python to 3.7
Now I get new message as follows

I tensorflow/core/platform/cpu_feature_guard.cc:145] This TensorFlow binary is optimized with Intel(R) MKL-DNN to use the following CPU instructions in performance critical operations:  SSE4.1 SSE4.2 AVX AVX2 FMA
To enable them in non-MKL-DNN operations, rebuild TensorFlow with the appropriate compiler flags.
2020-07-02 12:36:44.855418: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2020-07-02 12:36:44.855638: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x55abac90d1e0 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-07-02 12:36:44.855660: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
OMP: Info #154: KMP_AFFINITY: Initial OS proc set respected: 0
OMP: Info #214: KMP_AFFINITY: decoding x2APIC ids.
OMP: Info #156: KMP_AFFINITY: 1 available OS procs
OMP: Info #157: KMP_AFFINITY: Uniform topology
OMP: Info #285: KMP_AFFINITY: topology layer "LL cache" is equivalent to "socket".
OMP: Info #285: KMP_AFFINITY: topology layer "L3 cache" is equivalent to "socket".
OMP: Info #285: KMP_AFFINITY: topology layer "L2 cache" is equivalent to "socket".
OMP: Info #285: KMP_AFFINITY: topology layer "L1 cache" is equivalent to "socket".
OMP: Info #285: KMP_AFFINITY: topology layer "core" is equivalent to "socket".
OMP: Info #285: KMP_AFFINITY: topology layer "thread" is equivalent to "socket".
OMP: Info #191: KMP_AFFINITY: 1 socket x 1 core/socket x 1 thread/core (1 total cores)
OMP: Info #216: KMP_AFFINITY: OS proc to physical thread map:
OMP: Info #171: KMP_AFFINITY: OS proc 0 maps to socket 0
OMP: Info #252: KMP_AFFINITY: pid 27132 tid 27132 thread 0 bound to OS proc set 0
2020-07-02 12:36:44.857412: I tensorflow/core/common_runtime/process_util.cc:115] Creating new thread pool with default inter op setting: 2. Tune using inter_op_parallelism_threads for best performance.


sbt-scala-native 0.3.3 and sbt 1.0

I'm trying to get my code working with Scala Native and followed sbt-crossproject's README:
I rewrote my build.sbt file and added the sbt-crossproject and sbt-scala-native plugins to project/plugins.sbt:
addSbtPlugin("org.scala-native" % "sbt-crossproject" % "0.2.2")
addSbtPlugin("org.scala-native" % "sbt-scala-native" % "0.3.3")

I also set sbt.version=1.0.1 in project/build.properties.
Running sbt I get:
[warn] 	module not found: org.scala-native#sbt-scala-native;0.3.3
[warn] ==== typesafe-ivy-releases: tried
[warn]   https://repo.typesafe.com/typesafe/ivy-releases/org.scala-native/sbt-scala-native/scala_2.12/sbt_1.0//0.3.3/ivys/ivy.xml
[warn] ==== sbt-plugin-releases: tried
[warn]   https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scala-native/sbt-scala-native/scala_2.12/sbt_1.0//0.3.3/ivys/ivy.xml
[warn] ==== local: tried
[warn]   /Users/bastian/.ivy2/local/org.scala-native/sbt-scala-native/scala_2.12/sbt_1.0//0.3.3/ivys/ivy.xml
[warn] ==== public: tried
[warn]   https://repo1.maven.org/maven2/org/scala-native/sbt-scala-native_2.12_1.0/0.3.3/sbt-scala-native-0.3.3.pom
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.scala-native#sbt-scala-native;0.3.3: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn] 	Note: Some unresolved dependencies have extra attributes.  Check that these dependencies exist with the requested attributes.
[warn] 		org.scala-native:sbt-scala-native:0.3.3 (scalaVersion=2.12, sbtVersion=1.0)
[warn]
[warn] 	Note: Unresolved dependencies path:
[warn] 		org.scala-native:sbt-scala-native:0.3.3 (scalaVersion=2.12, sbtVersion=1.0) (/Users/bastian/projects/question-parser/project/plugins.sbt#L3-4)
[warn] 		  +- default:question-parser-build:0.1-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[error] sbt.librarymanagement.ResolveException: unresolved dependency: org.scala-native#sbt-scala-native;0.3.3: not found

It looks like sbt-crossproject is published for Scala 2.12 and sbt 1.0,
but sbt-scala-native is not.

That's right. See https://github.com/scala-native/scala-native/issues/915 which tracks sbt 1.x support for sbt-scala-native. sbt-crossproject already supports it.


Add healthchecks

Thoroughly tested and working just fine.

@nvdk come to think of it.... I think we introduced useless complexity by handling this environment variable. Okay I can fix it easily for the virtuoso.sh but then the healthcheck now needs to get the port from the INI file. It's not impossible but it makes things overall more complicated and it's contradicting the reason of using containers: helping us simplifying things.
In the end I think: simpler is better. Would it be okay for you if I remove the handling of the env variable for the port? I can add documentation to specify that the port must be 8890.

@cecton I agree the healthcheck adds complexity and I'm not happy with it either. Since we are adding complexity, I think checking the ini file is not a big extra when using crudini.
BTW: I've noticed the current healthcheck results in an unhealthy docker when loading large files, which seems counterproductive. Imo the healthcheck needs a large grace period or at the very least documentation on how to set it up with a large grace period.

Imo the healthcheck needs a large grace period or at the very least documentation on how to set it up with a large grace period.

You can change the start period when creating or running a container with docker, but the feature is not implemented in Docker Compose. I can make a PR for it.
I will just increase the start period to 60s for now.

merged, I'll update the readme and merge the other pr's. I'll release 1.3.0 with this and the other pr's.


constexpr for UUID.h

Many of the member functions in UUID.h can be marked as constexpr.
Would a pull request to do this be welcome?
On a more generic subject, what are the project policies about :

default keyword for constructors.
noexcept keyword for functions
providing default values in-line with class member declarations
constexpr for functions and variables where it doesn't require large changes
c++17 features. I assume currently this project only wants to use c++14 for compatibility with popular compilers
A bsf::StringView class (similar to std::string_view). It can significantly reduce accidental creation of temporary std::string objects

Hey, sorry for the late response, I forgot to put the repository on my watch and didn't notice the issue until now.
Most of those would be very welcome, constexpr, default keyword and inline value initializes especially. I tend to make these updates myself as I come across older code as well.
I don't think we need noexcept as we don't throw exceptions. String is generally only used in non-performance critical bits of code, and even then I'm pretty sure I avoid copying them around, but if you can find a good place for it, it wouldn't hurt.
C++17 I think we should wait for a bit. I tried switching to nested namespaces in a few places and was getting warnings on macOS, but maybe I just need to update something.

Thanks for the feedback!
I'm really happy to hear that you're open to constexpr, default keyword, and inline value initializers. So many projects out there straight up refuse to accept pull requests for those.
I'd actually argue that the noexcept keyword has value specifically because BSF doesn't use exceptions much. (Unless you're disabling exceptions at compile time?). The noexcept keyword, for functions that aren't inline in the header file, allow the compiler to assume that no exceptions will be thrown, and drop any exception handling code that may be generated as a result of the function call.
It's mostly useful for low level library code that gets called everywhere. At my day job we started using it and found a small drop in binary sizes as a result. Mileage may vary, though.
As for the StringView thing, I implemented a similar feature at my day job and saw a pretty nice reduction in temporary object creation... That being said, we have some 200+ developers all hacking away, so mistakes are significantly more likely there.
If I get bored sometime, I'll implement a StringView like class and demonstrate how it would be integrated, but I wouldn't say to hold your breath :-).
As for C++17, I'd be all for adopting it fully, but I'm not too worried about it. Feel free to switch as you see fit based on the other platforms.

Exceptions are fully disabled at compile time. I do wish to move everything to C++17 eventually, at the moment backwards compatibility is not a concern. When they are more mature, I want to do a full refactor with C++ modules as well.

Modules weren't approved for the c++17 version of the standard, were they?
So for exceptions, is the plan for those to stay disabled? If so, then yea, noexcept doesn't do any good. Though, if there's uncertainty on if they'll be enabled in the future, we might want to add them where appropriate for sake of not killing performance if someone enables exceptions.

Sadly no :(
I don't have plans on enabling exceptions. The code isn't written for handling exceptions so enabling them probably wouldn't have much benefit, so I really doubt someone would do so.


tests: bluetooth: tester: Add nrf54l15dk and remove nrf54l15pdk and add it to build only test targets

Adding the target nrf54ldk and removing the target nrf54lpdk.
Rename the config files according to nrf54l15dk.
Adding nrf54l15dk to build only test targets.

Commit message does not match the content of the commit. This only adds a new platform, and does not change any existing entry of the nRF54l15

May be two commits? one for rename of files and other to add the target for CI coverage.
FYI, open source Controller implementation does not support entropy, crypto and encryption features yet.

Commit message does not match the content of the commit. This only adds a new platform, and does not change any existing entry of the nRF54l15

I split the commit to make it more clear, and updated the commit message to clarify the changes.

Commit message does not match the content of the commit. This only adds a new platform, and does not change any existing entry of the nRF54l15

May be two commits? one for rename of files and other to add the target for CI coverage.
FYI, open source Controller implementation does not support entropy, crypto and encryption features yet. I see CI passing in this PR, not sure if the added target is being covered here for build failures?

I might need insight on that a bit more; I though it would be better to have at least build test since the board is added here even though it has not complete support yet.

Commit message does not match the content of the commit. This only adds a new platform, and does not change any existing entry of the nRF54l15

May be two commits? one for rename of files and other to add the target for CI coverage.
FYI, open source Controller implementation does not support entropy, crypto and encryption features yet. I see CI passing in this PR, not sure if the added target is being covered here for build failures?

I might need insight on that a bit more; I though it would be better to have at least build test since the board is added here even though it has not complete support yet.

the target is added to testcase.yaml.... is this build in this PR CI? is there a easy way to look here in this PR?

Commit message does not match the content of the commit. This only adds a new platform, and does not change any existing entry of the nRF54l15

May be two commits? one for rename of files and other to add the target for CI coverage.
FYI, open source Controller implementation does not support entropy, crypto and encryption features yet. I see CI passing in this PR, not sure if the added target is being covered here for build failures?

I might need insight on that a bit more; I though it would be better to have at least build test since the board is added here even though it has not complete support yet.

the target is added to testcase.yaml.... is this build in this PR CI? is there a easy way to look here in this PR?

Apparently twister test coverage does not include build for real target; I am removing the commit for adding nrf54l15 to test.yml for now.


fix measure terminology

RCLL is an overall predictive accuracy measure and not a calibration measure

Use https://doi.org/10.1186/S12874-017-0336-2 this paper for reference and Raphael's thesis

solved!

@zhizuio thanks George for fixing this!


Execution failed for task ':app:compileDebugKotlin'.

Description
Getting the below error I upgraded the project from 0.68.7 to 0.73.2
Execution failed for task ':app:compileDebugKotlin'.

A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
Compilation error. See log for more details

Steps to reproduce
react-native run-android
React Native Version
0.73.2
Affected Platforms
Runtime - Android
Output of npx react-native info
System:
  OS: macOS 14.2.1
  CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Memory: 38.38 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 21.7.3
    path: /usr/local/bin/node
  Yarn: Not Found
  npm:
    version: 10.5.0
    path: /usr/local/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /usr/local/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/gopi/.rvm/gems/ruby-2.7.6/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - watchOS 10.2
  Android SDK:
    API Levels:
      - "23"
      - "24"
      - "25"
      - "26"
      - "27"
      - "28"
      - "29"
      - "30"
      - "31"
      - "32"
      - "33"
      - "34"
    Build Tools:
      - 29.0.2
      - 30.0.3
      - 33.0.1
      - 34.0.0
    System Images:
      - android-29 | Google APIs Intel x86 Atom
      - android-29 | Google Play Intel x86 Atom
      - android-30 | Google APIs Intel x86 Atom
      - android-32 | Google APIs Intel x86 Atom_64
      - android-32 | Google Play Intel x86 Atom_64
      - android-33 | Google APIs Intel x86 Atom_64
      - android-33 | Google Play Intel x86 Atom_64
    Android NDK: Not Found
IDEs:
  Android Studio: 2021.2 AI-212.5712.43.2112.8609683
  Xcode:
    version: 15.1/15C65
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 18.0.2
    path: /usr/bin/javac
  Ruby:
    version: 2.7.6
    path: /Users/gopi/.rvm/rubies/ruby-2.7.6/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.2
    wanted: 0.73.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: false

Stacktrace or Logs
Getting the below error I upgraded the project from 0.68.7 to 0.73.2

rebuild the project in Android studio

Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

Reproducer
No Git url
Screenshots and Videos
No response

We recently upgraded my project to 0.73.2.
iOS builds successfully and issues with Android.

Your Android code is not compiling.
We need to full build log to see what happened here.

@cortinico - Thanks for the reply.The issue with namespace in build.gradle.
Now i am getting this error.I am using distributionUrl=https://services.gradle.org/distributions/gradle-8.3-all.zip.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
For more on this, please refer to https://docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
For more on this, please refer to docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

This is a warning, not an error, you can ignore it (also is caused by the Android/Google toolchain). Closing as this is solved

@gkasireddy202 I have the same issue and I am using Gradle 8.8. My react native app works fine in Expo GO. But when I build it  and run it on an android device it goes blank.
Running npm run android fails with this output:
`> Task :app:compileDebugKotlin FAILED
<<
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:compileDebugKotlin'.

A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
Compilation error. See log for more detailsHere is my package.json:{
"name": "Médicaments",
"version": "1.0.0",
"scripts": {
"start": "expo start --dev-client",
"android": "expo run:android",
"ios": "expo run:ios",
"web": "expo start --web"
},
"dependencies": {
"@expo-google-fonts/lato": "^0.2.3",
"@react-navigation/bottom-tabs": "^6.5.20",
"@react-navigation/native": "^6.1.17",
"@react-navigation/stack": "^6.3.29",
"expo": "~51.0.9",
"expo-camera": "^15.0.10",
"expo-font": "~12.0.6",
"expo-status-bar": "~1.12.1",
"expo-system-ui": "^3.0.4",
"expo-updates": "~0.25.15",
"react": "18.2.0",
"react-native": "0.74.1",
"react-native-gesture-handler": "^2.16.2",
"react-native-picker-select": "^9.1.3",
"react-native-safe-area-context": "4.10.1",
"react-native-screens": "3.31.1",
"react-native-svg": "15.2.0",
"react-native-webview": "13.8.6",
"react-navigation": "^5.0.0"
},
"devDependencies": {
"@babel/core": "^7.20.0",
"@types/react": "~18.2.45",
"@types/react-navigation": "^3.4.0",
"typescript": "~5.3.3"
},
"private": true
}
`

@AbdessamadAe - I upgraded the expo manually instead of auto-linking.

@gkasireddy202 Expo version is updated. I initiated a new blank project and tried to build, it had same issue. Any suggestions on how to fix that?

Can you please try to run the app in debug mode then you will know the exact error.
I found my issue like that only.

Did you ever resolve this issue?

Check it out
app/build.gradle
namespace

I have same issue

I built a new express project and copied my code. That resolved it.

I am using expo (managed workflow). After deleting the android folder and then running the app fixed the issue for me.

Check it out app/build.gradle namespace

That resolved my issue. The name space in android/app/build.grade must be the same as in the app.json


Source for 1.1.9

Version 1.1.9 has been available on the Play Store for months, yet the source code is still 1.1.8.
Any plans to push the latest code to the repo?

Sorry for the delays on pushing the source code


SubViewport & TileMap doesn't respect Visibility Layer / Canvas Cull Mask when Y Sort is enabled.

Godot version
4.0.1-stable_win64
System information
Windows 11
Issue description
Enabling Y-Sort for a TileMap node causes it to show up in a SubViewport even when the visibility_layer and canvas_cull_mask don't match.
Should look like this:

Get this with Y Sort toggled on:

I've had a look at tile_map.cpp and it doesn't look like the visibility_layer is passed to the canvas_items it creates. tile_map overrides set_light_mask and passes this along, seems it would be appropriate to pass along the visibility_layer as well?
I've patched this locally and seems to work but it involved making set_visibility_layer and set_visibility_layer_bit methods overridable in canvas_item.h.
The tile_map.cpp changes:
void TileMap::_update_visibility_layer_for_canvas_items() {
	for (unsigned int layer = 0; layer < layers.size(); layer++) {
		for (KeyValue<Vector2i, TileMapQuadrant> &E : layers[layer].quadrant_map) {
			TileMapQuadrant &q = E.value;
			for (const RID &ci : q.canvas_items) {
				RS::get_singleton()->canvas_item_set_visibility_layer(ci, get_visibility_layer());
			}
		}
		_rendering_update_layer(layer);
	}
}

void TileMap::set_visibility_layer(uint32_t p_visibility_layer) {
	// Set material for the whole tilemap.
	CanvasItem::set_visibility_layer(p_visibility_layer);

	TileMap::_update_visibility_layer_for_canvas_items();
}

void TileMap::set_visibility_layer_bit(uint32_t p_visibility_layer, bool p_enable) {
	CanvasItem::set_visibility_layer_bit(p_visibility_layer, p_enable);

	TileMap::_update_visibility_layer_for_canvas_items();
}

Not really confident with engine or c++ dev and contributing but happy to make a PR.
Steps to reproduce
Given this scene tree:

and these settings:
Viewport (SubViewportCullMaskSetTo2):

TileMap (TileMapSetToVisibleOnLayer1):

Parent Nodes (Node2D_VisibleSetToLayer1And2 and VisibleSetToLayer1And2):

The tilemap will still be present in the viewport texture of ViewportTextureShowsTileMapAndSprite
Minimal reproduction project
Tile Map Visibility Layer For Canvas Items.zip

I've had a look at tile_map.cpp and it doesn't look like the visibility_layer is passed to the canvas_items it creates. tile_map overrides set_light_mask and passes this along, seems it would be appropriate to pass along the visibility_layer as well?
I've patched this locally and seems to work but it involved making set_visibility_layer and set_visibility_layer_bit methods overridable in canvas_item.h.
The tile_map.cpp changes:
void TileMap::_update_visibility_layer_for_canvas_items() {
	for (unsigned int layer = 0; layer < layers.size(); layer++) {
		for (KeyValue<Vector2i, TileMapQuadrant> &E : layers[layer].quadrant_map) {
			TileMapQuadrant &q = E.value;
			for (const RID &ci : q.canvas_items) {
				RS::get_singleton()->canvas_item_set_visibility_layer(ci, get_visibility_layer());
			}
		}
		_rendering_update_layer(layer);
	}
}

void TileMap::set_visibility_layer(uint32_t p_visibility_layer) {
	// Set material for the whole tilemap.
	CanvasItem::set_visibility_layer(p_visibility_layer);

	TileMap::_update_visibility_layer_for_canvas_items();
}

void TileMap::set_visibility_layer_bit(uint32_t p_visibility_layer, bool p_enable) {
	CanvasItem::set_visibility_layer_bit(p_visibility_layer, p_enable);

	TileMap::_update_visibility_layer_for_canvas_items();
}

The thing is the TileMap's canvas item is parent to the layers' canvas items which are parent to quadrants' canvas items (within the rendering server) so the TileMap's visibility layer should automatically be taken into account, there should be no need to manually propagate the visibility layers to each quadrant. So the issue seems to be not related to the TileMap specifically, I'd guess it's rather something about how y-sorted canvas items are handled within the rendering server.
Meaning the suggested code changes would maybe fix the symptom, but likely not the actual issue.
For confirmation: tile_map_is_not_the_problem.zip

Disabling Y-sorting for either Node2D or PseudoTileMap makes the PseudoQuadrant be properly not rendered.

Thank you for the explanation and example, think I understand how that's working a little better now. I looked into the rendering server and how canvas items are culled when y sorted.
There's _cull_canvas_item and it checks if the item is visible and then if the visibility_layer / canvas_cull_mask match. Y sorted nodes are dealt with in _collect_ysort_children which makes a visible check before adding them to the flattened array, I think this should also check for visibility_layer / canvas_cull_mask?
I tried adding that check (and calling _mark_ysort_dirty() when calling canvas_item_set_visibility_layer ) and it works for the example scene in tile_map_is_not_the_problem.zip but not for the one I originally posted. Think this is because the ysort_children_count that's reset to -1 by _mark_ysort_dirty() is reused for each viewport even though they'd be different lengths for different viewports if visibility_layer is taken into account when culling Y sorted items.

Hopefully this gets fixed in the tilemap rework in 4.3.


fix: Change device os header name

Links
SDKCF-1361
Checklist

[x] I have read the contributing guidelines.
[x] I wrote/updated tests for new/changed code
[x] I ran ./gradlew check without errors

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   73.46%   73.46%
=======================================
  Files          15       15
  Lines         309      309
  Branches       17       17
=======================================
  Hits          227      227
  Misses         78       78
  Partials        4        4

Impacted Files
Coverage Δ

...tech/mobile/remoteconfig/api/HeadersInterceptor.kt
95.45% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbaf53d...8ad0c6a. Read the comment docs.

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   73.46%   73.46%
=======================================
  Files          15       15
  Lines         309      309
  Branches       17       17
=======================================
  Hits          227      227
  Misses         78       78
  Partials        4        4

Impacted Files
Coverage Δ

...tech/mobile/remoteconfig/api/HeadersInterceptor.kt
95.45% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbaf53d...8ad0c6a. Read the comment docs.


Package stack_trace has now support for parsing WASM frames

Description
The stack_trace package was updated to support parsing WASM frames, see https://pub.dev/packages/stack_trace/changelog
However, it then requires Dart 3.4
This is more of a FYI, than an actual issue :D

I added comment here
thx for bringing this up


chore(deps): update dependency @microsoft/api-documenter to v7.24.1

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@microsoft/api-documenter (source)
7.24.0 -> 7.24.1

[!WARNING]
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

microsoft/rushstack (@microsoft/api-documenter)
v7.24.1
Compare Source
Tue, 19 Mar 2024 15:10:18 GMT
Version update only

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "after 8am and before 4pm on tuesday" in timezone Etc/UTC.
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: yarn.lock
➤ YN0000: · Yarn 4.1.0
➤ YN0000: ┌ Resolution step
➤ YN0085: │ + @microsoft/api-documenter@npm:7.24.1
➤ YN0085: │ - @microsoft/api-documenter@npm:7.24.0
➤ YN0000: └ Completed in 0s 668ms
➤ YN0000: ┌ Post-resolution validation
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming [6d01c] doesn't provide react-dom (p6ea56), requested by @testing-library/react.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming [a7905] doesn't provide react-dom (p8d8b3), requested by @testing-library/react.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming [ff90e] doesn't provide react-dom (p6a157), requested by @testing-library/react.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming doesn't provide react-dom (p8b348), requested by @testing-library/react.
➤ YN0002: │ @apollo/experimental-nextjs-app-support@workspace:packages/experimental-nextjs-app-support [57d1f] doesn't provide react-dom (p14a9a), requested by @testing-library/react.
➤ YN0002: │ @apollo/experimental-nextjs-app-support@workspace:packages/experimental-nextjs-app-support [689d7] doesn't provide react-dom (p8f77d), requested by @testing-library/react.
➤ YN0002: │ @apollo/experimental-nextjs-app-support@workspace:packages/experimental-nextjs-app-support doesn't provide react-dom (p102c3), requested by @testing-library/react.
➤ YN0002: │ @apollo/experimental-nextjs-app-support@workspace:packages/experimental-nextjs-app-support doesn't provide react-dom (p6ec33), requested by next.
➤ YN0002: │ monorepo@workspace:. doesn't provide webpack (pef089), requested by @size-limit/webpack-why.
➤ YN0086: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step


Fixed a few things

Fixed sorting by ID
Allows leaving download_pattern blank, defaulting to the default pattern

Last commit might have an issue... Don't know why onsubmit not being called

I think antd v4 caused some of these issues: https://ant.design/components/form/v3

Has partial functionality with transmission for new torrent client features

Going to split up into individual pull requests


Java Certificate Exception while opening WSO2 analytics login screen, shows blue screen

Description:
I have hosted the instances of wso2 api manager as well as wso2 analytics in the same parent directory. wso2 api manager is working great, but I cannot access even the login screen of wso2 analytics after the configuration. When I inspected in the network tab of the browser, I can see the Exception occurred :java.security.cert.CertificateException: No subject alternative names matching IP address <IP_ADDRESS> found executing GET https://<IP_ADDRESS>:9443/api/am/admin/v1/custom-urls/carbon.super error. I am using version 3.2.0 for both apim and analytics. I have configured both of them to point to the same apim db. Also, I have enabled the ssoEnabled to true in auth.configs section in deployment.yaml file. How can this error be resolved?

Not an issue at all, answered by Wasura in this stackoverflow link https://stackoverflow.com/questions/66979846/java-certificate-error-while-opening-wso2-analytics-login-screen-shows-blue-scr/66980310#66980310


Smart Object setting not work ( 1.3.0 )

In the new version 1.3.0, when the checkbox is unchecked, the image continues to be created as a smart object.

Python 3.10.6 (tags/v3.10.6:9c7b4bd, Aug  1 2022, 21:53:49) [MSC v.1932 64 bit (AMD64)]
Version: v1.4.1
Commit hash: f865d3e11647dfd6c7b2cdf90dde24680e58acd8
Launching Web UI with arguments: --xformers --api
P.S: Thanks a lot for 1.3.0, many great changes.

In the new version 1.3.0, when the checkbox is unchecked, the image continues to be created as a smart object.

Yes, that's a bug will fix it soon in v1.3.1
Can you help me reproduce this bug in your image? We had to remove some features to fix it, so I’m surprised to see the shrinking/misalignment issue in your screenshot. Some helpful information would be the width and height sliders, as well as the selection area’s width and height. If you can reproduce it consistently, could you send me a small PDF file? Thanks!

I didn’t have any problems with the shrinking/misalignment.
I probably tried to generate in different modes (txt2img, img2img), randomly highlighting with a frame.
I didn't have this problem.


This is not bug but a question

i was working on custom sizes but editor forces from base code font size names is any way to override

Bug or what ??

That's plugin is not released yet, so yep, it can be buggy ^^'

Can you retry with the new released 2.10.0 please?


Develop

Can this be closed? Without a clear description of what this change does, I will close it.


Update Default Configs

This PR does the following:

Updates the default Ordering config. It now defaults to Private (renamed to "Most Active" so as to differentiate it from Tags that are similarly named)
Changes the default filtering system name to All. The Private filter is changed to only include repos marked as private.
Fixes the bug in #145 where the app would default to the first filter found, not to the filter marked as Default.
The name "All" is made a reserved filter name.
Filters named "Default" will overwrite the "All" setting.
_queryDictionary was, in fact, a List. No more :)
Eliminates redundant List<T>.Contains() checks.
Fixes the fork display problem ( #170 )
Fixes the pin crash ( #169 ) (and possibly #87 ?)
Partially fixes the default installation issue ( #156 , and brought up in #151 ). Still think it would be ideal to set them at install or at least at startup so that the app doesn't waste any time whatsoever unnecessarily checking if they're installed every time.
Updates Logger and YAML parser
Other code simplifications.
Improves the overall UI and adds icons

Later Edit: Some quick updates so that the fix to #170 is not limited just to GitHub

Tests seem be failing due to the name changes of fields in the Action Menu, but not entirely sure why.

Update: Fixed an error related to #177 .
Recommending that #178 is merged before this PR.

Hi, Thanks for your PR and for all the time you put into RepoM. I appreciate it.
However, it's hard for me to review your PR as you are solving quite a number of issues. I prefer smaller PR trying to solve one issue at the time.
Because you put in so much effort, I'm going to write my feedback in different files right now.

You did a lot, and again, thanks for that. I hope you don't take this the wrong way but most of the changes are not necessary and take a lot time to review.
I thinks it better to discuss solutions, fixes or style changes upfront. Also make separate PRs if you address multiple issues.
Again, thanks for all the effort. I really hope you take the comments not personal.

Sure, no worries. I'll break it down in more PRs in the future.
Sorry for the long delay. All should be fixed now.


Add skip flag

Hello,
In the docs it states that you can add a --skip flag on the cli command but there is no way of being able to pass that on to the chromatic command.
Why?
Dependabot has a high risk of abusing the snapshots so for our use cause we wish to be able to ignore it so it only tests our features.
Suggestion:
uses: chromaui/action@v1
with:
  token: ${{ secrets.GHP_TOKEN }}
  projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
  skip: "dependabot/**"

May even be better to be just an options property.

This is also a blocker for us using this action, please add this!

Here is a workaround I used to prevent chromatic from running on Dependabot commits until this is implemented as a top-level action parameter:
name: 'Chromatic'
on: push

jobs:
  chromatic:
    if: github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]' # ignore the pull request which comes from user depbot.
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          # Required to retrieve git history
          fetch-depth: 0
          # needed so we can pull other private npm dependencies, secrets.GITHUB_TOKEN is scoped to this repo only
          token: ${{ secrets.GitHubPAT }}
      - name: install dependencies
        run: npm ci
      - uses: chromaui/action@v1
        with:
          projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
          # needed so we can pull other private npm dependencies, secrets.GITHUB_TOKEN is scoped to this repo only
          token: ${{ secrets.GitHubPAT }}

It's added, since today


RFC1918 addresses should not be used as example IP addresses, use example ranges in RFC5737

This article shows RFC1918 private, non-routable IP addresses as the Trusted IPs (172.16.x.x in this diagram). By definition, these addresses will NEVER be routed over the internet, they are for private, internal use only.
Please use RFC 5737 https://tools.ietf.org/html/rfc5737 address ranges instead.
The blocks <IP_ADDRESS>/24 (TEST-NET-1), <IP_ADDRESS>/24 (TEST-NET-2),
and <IP_ADDRESS>/24 (TEST-NET-3) are provided for use in
documentation.
This will help eliminate confusion as people see the RFC1918 ranges of <IP_ADDRESS> to <IP_ADDRESS>, <IP_ADDRESS> to <IP_ADDRESS>, and <IP_ADDRESS> to <IP_ADDRESS> and understand those to mean private, internal addresses and not example external addresses.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dbab466f-88f8-302a-7cda-d53bc743e831
Version Independent ID: b5634fb3-6627-3fcd-101c-0ebc419d7b19
Content: Direct Routing Local Media Optimization - Microsoft Teams
Content Source: Teams/direct-routing-media-optimization.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@TorrenManson Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@TorrenManson thank you for reaching out and helping improve MS Docs.  I work on the editing/writing side of the articles. Please can you clarify which part of the article needs to be updated.

I will follow up with the PM about the IP addresses.

@CarolynRowe Hi Carolyn, any update on this issue? Thanks!

Will be fixed within a week

Hi - are the fixes going to be published anytime soon?

@CarolynRowe @FilippSe

@CarolynRowe @FilippSe Following up on this, thank you!

@TorrenManson - it looks like the updated article no longer includes the private IP addresses, so I'm closing this issue.
If the issue still exists, please open a new issue.
Thank you!

Reopened at #7804 as the updated article does not address the issue.

Looping in @FilippSe.


New UI

This update adds QoL things and reworks the entire UI interface to be cleaner for the user (and in code)
Some changes

New UI

Console output for detailed user interaction

New font

Custom Themes

Image export as JPG / PNG / EXR

Start / Pause / Target Sample count for renderer

Render Stats (Rays per second, total rays, samples per second, time elapsed)

Fixed bug with compute shader not loading

Increased compute shader performace by over 10x

Fixed bug where pressing A made you go faster in a single direction, pressing left shift makes you more 5x faster in all directions

Fixed issue with preview code being messed up due to refactor

Amount of time render took now is displayed once render is done

Very cool!


Game seems to crash, and im running out of ideas.

First of all thanks for you work, i appreciate it. Now, im currently making a modpack for me and my friends but since im upgrading my pc and waiting for a replacement mobo i cant use my main pc so im using my laptop so don't cry when you see awfull specs. (Not meant rude)
When i im creating a new world and when i enable the CubicChunks mod with the setting "Default" i can't get into the world because it always crashed as the end. Here are the Logs
Grash Log 1 Password:<PHONE_NUMBER>
Crash Log 2

I see several issues even before getting to the crash just by looking at the log:
| LCHIJA | otgcore                     | 1.12.2 - v8.3              | minecraft.jar                                             | None                                     |
| LCHIJA | openterraingenerator        | v8.3                       | OpenTerrainGenerator-1.12.2+-+v8.3.jar                    | None                                     |

OTG is generally known to not work well with cubic chunks.
| LCHIJA | chunkpregenerator           | 2.1                        | Chunk+Pregenerator+V1.12-2.2.jar                          | None                                     |

useless with cubic chunks
| LCHIJA | dsurround                   | <IP_ADDRESS>                    | DynamicSurroundings-1.12.2-<IP_ADDRESS>.jar                    |

DynamicSurroundings is knownt o have some issues. There is a configuration that works but I'm not fully up to date on what exactly it is.
| LCHIJA | farseek                     | 2.5                        | Farseek-1.12-2.5.jar                                      | None                                     |

CubicChunks breaks some of this
| LCHIJA | streams                     | 0.4.8                      | Streams-1.12-0.4.8.jar                                    | None                                     |

this is not going to work.
The actual error you are getting is caused by some modded generator doing something unexpected in early chunk generation stage and cubic chunks optimization breaks it. It can be disabled  Just disable optimizedCompatibilityGenerator in cubic chunks config.


Performance & Memory Issue with DynamoDB Object Model

We started to see an issue with our services that use the DynamoDB SDK using the object model. The services are fine under low load, but when the load starts to increase (~1000 requests per minute across four instances) we see significant issues. These services are running in Docker containers using .Net Core 2.1.3 (we've seen the issue with .Net Core 1.1 as well).
Expected Behavior
Calls to DynamoDB perform at a much higher scale.
Current Behavior
The calls to DynamoDB start to slow and the service eventually begins to timeout, causing the instance to fail and be replaced.
Steps to Reproduce (for bugs)
We were able to reproduce this with a pretty simple service. The API was a simple GET endpoint that did a DynamoDB query on a hash key and returned the results. The record count was, on average, about 15 records, with a max of about 30. Records are not particularly big, well under 1k each. The key is using the object model. We were able to switch to the basic DynamoDB request model and see no issues. We were able to sustain loads of over 6000 requests per minute with just two instances and saw no performance issues at all.
Context
The primary issue is that we end up with a significant number of failed requests. We have been able to mitigate this in one service by not using the object model, but have concerns that other services will start to see this same behavior as load increases.
Your Environment
Docker container running an ASP .Net Core service. We've used different base Docker images with the same result.
One thing that is possibly worth mentioning is that we use the TablePrefix option on all of our calls.
.NET Core Info
Both 1.1 and 2.1.3 for sure, likely an issue on any version.

Can you let us know which version of AWSSDK.DynamoDbv2 you are using and also check in your projects deps.json file to see which version of AWSSDK.Core gets pulled in due to your AWS service dependencies.
Do you only notice this problem in Docker? What I'm trying to eliminate is if this is a problem specific to Linux or all platforms.

AWSSDK.DynamoDBv2 version 3.3.8
AWSSDK.Core version <IP_ADDRESS>
We are only running in Docker, so I don't know if the issue happens in Windows.
There is one other piece of information that may be helpful. We ran the Docker container with only a soft memory setting of 256MB, no hard limit. At times the memory would go through the roof, consuming upwards of 600% of the allocated memory. The container would become unresponsive at some point and the container would be replaced. Naturally the memory dropped at that point, but I was suspicious about garbage collection in that scenario. The memory didn't always spike like that before becoming unresponsive but it's possible the times when it didn't the container was on a host with less available memory.

This may have been fixed in DynamoDBv2 <IP_ADDRESS> & AWSSDK.Core <IP_ADDRESS>, see here.
There was an issue an issue with the async DocumentModel APIs, this looks pretty similar.

I can test it with that version. I'm a little bit doubtful given that we have a service running, with similar to higher volume, that uses the DocumentModel and doesn't have any issues. I'll test it out with the newest version of the SDK and let you know if the problem persists.

I'm having the same issue. We are using DynamoDBv2 <IP_ADDRESS> and ASP.NET Core 2.1.2 running on latest elastic beanstalk win platform as per (https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/concepts.platforms.html#concepts.platforms.net)
We are running on .NET 4.7.2 full framework. With minor load of 6 hits per second the CPU on the machine will spike to 99%. No errors in the event log or any .NET errors. The odd thing is that the spike will occur say 4 or 5 minutes into the load test. All will be fine and all of a sudden you go from 2% CPU usage to 99%.
We are using the document model.
We've trying switching to Oracle RDS (just to rule out DynamoDB) and indeed no issues.
We'll do the update to the latest SDK and see if the issues go away.

I have confirmed that the issue is still present with the latest SDK.
AWSSDK.Core - <IP_ADDRESS>
AWSSDK.DynamoDBv2 - 3.3.14
This does feel a lot like thread starvation, which could be an async problem. The API will not even respond to a request on a controller that just returns a 204 when it gets to the unstable state.

Same here. Upgraded to latest and greatest.
AWSSDK.Core - <IP_ADDRESS>
AWSSDK.DynamoDBv2 - 3.3.14
One things to note: we are using document model, async, and we are using a single instance of AmazonDynamoDBClient. We are not creating and disposing the client on per-request basic b/c underneath we are assuming HttpClient is used and as per MS one should either use a singleton or the new HttpClientFactory.
I'll try disposing in per request basis to see if that helps ...

Found the issue in our case -- may not be related. But don't await GetNextSetAsync if you are in a loop. So no
do {  var items = await query.GetNextSetAsync(); } while (blah)
this will eventually, under load, cause CPU to spike and perf to degrade. In this case, just do query.GetNextSet(); ....

@clearwaterstream that's an interesting observation. I'm using the object model and the QueryAsync<T> method returns AsyncSearch<T>, which does not have a GetNextSet, only GetNextSetAsync and GetRemainingAsync. I'd be concerned that using GetNextSet would cause the thread to be blocked whilst reading the stream, which is not ideal.

@jasonwadsworth
yeah, some AWS C# examples have you use GetNextSet() in a loop until query.IsDone. So what I do is
var table = Table.LoadTable(...);

var query = table.Query(new QueryOperationConfig(...));

var bucket = new List<item>(20); // 20 is our bucket or page size. After we fill it, we are good...

var i = 0;
do{
    i++;

    var items = query.GetNextSet();
    bucket.AddRange(items);

    if(query.PaginationToken == "{}")
        break; // there are no more records
} while (!query.IsDone || bucket.Count >= 20);

Since pagination is involved, we cannot simply do query.GetRemaining();
Here is what I found interesting. To fill a bucket that can contains 20 items, sometimes GetNextSet() gets called 17 times in that loop! Often GetNextSet() will return no items and yet the query.IsDone is false. On the next call to GetNextSet() in the loop iteration, there may be items returned. Very odd. With IDataReader, for example, you call Read() until there is nothing to read but each Read() call will yield an item. Not the case with GetNextSet(). Looks like it just returns chunks that may or may not have data.
So imagine if that loop called GetNextSet() 17 times using async. I think that would create a lot of context switching.

If GetNextSet() or GetNextSetAsync() is returning empty sets but has another page that seems like a poor implementation. However, I'll take 17 context switches over a blocked thread making 17 HTTP requests.

Well that's where IIS + ASP.NET Core interaction comes into play. IIS has a certain queue depth, and once ASP.NET Core app switches into "i'm free to take work" state b/c it's awaiting something then IIS may start sending more requests into the app. Then the app switches out of the awaiting, only to find another request just landed. This could cause a high number of ungated requests being sent into the app.
The issue in the loop is that every time that loop runs, IIS will send multiple requests into the app as a result of a single request signaling that's it's free. Consider this flow: IIS lets in one request, that request starts the loop, switches context to "free" several times, IIS sends multiple other requests into the app, those requests in turn start signaling they are free from "the loop", and so the problem worsens until you are at 99% CPU.
This problem would not occur if your app handled different workflows but in our case our app pretty much does one thing and all flows go into "the loop".
Removing await allowed IIS to "hold back" requests in its queue prior to sending them into the app. Tricky business. But maybe unique to us as typically web apps handle multiple flows / scenarios at any given moment and async/await shines in that case ....

@normj is this something that's being looked into? I need to understand how we need to move forward. If this is being looked into we can continue down our current path and hope for a fix. If it's not we need to have our teams use basic DynamoDB requests instead of the object model.

Facing similar issue. We have lambda functions querying results from dynamodb that needs to be returned in a specific JSON format. Lambda functions are exposed through API Gateway endpoint so we have total 30 seconds to finish the work and provide result back to API Gateway.
What would be the best efficient way to load the query results with pagination? I suspect .NET Object and Document model is slower than the low level APIs. If I use low level API, I still need to convert it the required JSON model.
Just wondering if any one's been there, done that?

We are facing the same issue, is there already a workaround available at this moment ? The issue is still open...

@robvanpamel As far as I know, this is still an issue.  We ended up using the Low-Level Interfaces for interacting with DynamoDB, because 1) we were using it in a couple of other places already for specific features and 2) it's reliable.

Hi @tmschlot : As the issue seems to be related to ThirdParty.Json.LitJson , isnt this happening at the lower levels as well ?

That is a good point, @robvanpamel.  Your issue appears to happen when reading the stream to calculate the CRC.  That seems way more generic than just the DynamoDB package's Object Persistence Model code.  That makes me wonder whether what you're running into is the same problem as what was originally reported.  Maybe this is something new.

I have been attempting to reproduce the issue with no success and would appreciate help creating a simple repo case that I can diagnose.
Here is the code I have been running in a Fargate container with the smallest settings and haven't seen memory increases or errors.
https://gist.github.com/normj/8c492950fc8e289a6a757760f91f89da
The code basically continually does a table scan and also uses a lot of tasks to do individual reads for each item in the table.
Any suggestions on how I can alter the code to reproduce a memory leak would be greatly appreciated.

@normj I've had this issue happen when using GetNextSetAsync() (as opposided to GetNextSet()) in a loop, when pagination is involved. Let me do a quick app where I'll seed a table, then we'll attempt to read it and hopefully see the CPU pegged at 99% when running a simple query with minimal load.

To be clear in my case, I cranked up the number of tasks till the CPU was maxed out since there were comments earlier that this only happened when at high load.

@normj I just created a test app and a mock DynamoDB table with 1k ZipCode entries. I then run pagination queries against it, hoping to get "blank" sets when calling GetNextSet() and I did not encounter any blanks! I cannot repro the issue. I do not have access to the old source code (where I've encountered the issue) but it was definitely running against an older AWS SDK.

@normj Update: while organically I was not able to repro the issue, I was able to get a couple of blank sets by switching to Scan vs Query (same column and condition) and Limiting to 5 records. Since some of the sets were blank (or had 1 or 2 records), it caused more calls to GetNextSetAsync() until query.IsDone was true . I could not consistently repro this (even with Limit of 5). While reading https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_Scan.html it made me think the reason why I was encountering this issue before was the record size. Under the "Limit" section it mentions that if the " if the processed dataset size exceeds 1 MB before DynamoDB reaches this limit, it stops the operation and returns the matching values up to the limit...".

@clearwaterstream GetNextSetAync is expected to sometimes return no data but still not be done with the query causing you to have to call it again. I recognize coming from other data clients this is not intuitive but a major difference here is the calls are going of HTTP calls versus a dedicated socket connection like most database drivers. Eventually HTTP calls will timeout so when a query/scan call is made it will return after a certain of items in DDB have been read to see if they meet the criteria not how many items has it found that match the criteria.
@robvanpamel Your problem seems different because it is not a memory issue but an exhausted thread pool. Make sure you are using the at least version <IP_ADDRESS> as that includes work @slang25 contributes to reduce the amount of tasks used by the SDK when using async operations. If you are using a version 3.3.9 or later then we need more information about how you are calling the SDK, like async versus sync and are you using anything else that consumes threads. I would recommend opening a separate issue for Task starvation because this issue is created to look at the memory consumption issues of the SDK and that is what I'm looking into.
For those that are seeing an OutOfMemoryException, is it only happening when load reaches some high point? Is anybody seeing the issue when the load is at some medium load and overtime the memory creeps up and then throws OutOfMemoryException? I'm trying to distinguish if there is a memory leak or inefficient usage of memory causing OutOfMemoryException when too much memory is request to handle the current incoming level of requests.

I have a container I have been running for quite awhile that exposes an HTTP endpoint to trigger a DynamoDB query like I have seen others here talk about. When I use my perf tool to push the CPU to about 85% the memory has stayed consistent.

When I push the CPU to 9X% percent then I have seen the garbage collector in the container not be able to keep up and throw an out of memory exception. This appears to match what others have been saying that when CPU is maxed out things fall apart if they they are moderately high or below things are fine.
This leads me to conclude we don't have a memory leak because if we did it would still crash at lower CPU just take longer. I believe the DDB high level library is inefficient with their memory usages but I don't think there is a quick solution to that other then rewrite the high level libraries. Most likely the inefficiency come from the layers Object Model uses. By that I mean a request going from the Object Model -> Document Model -> Service Client -> Document Model -> Object Model.
Does this match with what others are seeing?
.NET Core 3.0 coming out later this month has some new interesting settings that can be used to control the garbage collector to make it more aware of it's constraint container environment. That is also worth some investigation. https://devblogs.microsoft.com/dotnet/using-net-and-docker-together-dockercon-2019-update/. Has anybody tried these yet?

Closing due to inactivity.  Please feel free to continue commenting.  We may reopen this at a later time.


Unable to change Virtual Presence device

I have a virtual presence device, and I can watch the message that get sent when I trigger it from the ST app. But when I send the same messages to the topic nothing happens.
I have confirmed that other devices (like my light) work like a charm.

OK, I see the issue. No action associated with the device type.
I've never done smartapps before, so I don't feel real comfortable just giving it a go.
But it looks fairly simple; listen for "present" or "not present" on the topic and set the state of the device accordingly.
Anyone care to help please?

Meh, took a crack at it. This appears to work:
https://github.com/stjohnjohnson/smartthings-mqtt-bridge/pull/87

OK, got it. this works!

Thanks for the contribution!


docs: clarify Captures::len includes non-matching captures

This caught me out: mentally I map "captured groups" to the successful captures; capture groups that didn't capture anything weren't "captured." I understand why the function returns what it does in retrospect, but hopefully this can help someone else.

Nevermind, I'll make the change and include it in a rollup.


Reduce usages of DefaultEdgeFilter(encoder, true, false)

We often do something like
graph.createEdgeExplorer(new DefaultEdgeFilter(encoder, false, true));

(about 35 times in the current master). I've done this myself quite a few times and everytime I need to check if I got the flags right. Therefore I would suggest to add two or three static factory methods to DefaultEdgeFilter: DefaultEdgeFilter.inEdges(FlagEncoder), DefaultEdgeFilter.outEdges(FlagEncoder) and optionally DefaultEdgeFilter.allEdges(FlagEncoder). The last one is what the default constructor does, but would be more readable in my opinion.

Yes, please - this is a good idea. This would also solve the ugliness in #1112 where I swapped the booleans (as fwd,bwd is more intuitive) but this would brake all usages without being noticed.


Add readonly mode for editor

Description
At this moment editor works only in edit mode, which means that we can't prevent user from making changes, if he is not allowed to make changes.
Proposal
Add readonly property to MarkdownEditorView

@ponyr1der We have a demo mode in the demo folder. But this issue concerns disabling editing mode.
Is the preview from the demo suitable?
Or do you need to disable the mode? For what purpose? Can you provide use cases?

I tried Preview using YfmStaticView, but it's not exactly what i need. I need a mode, where user can't change content of the markup, can only view, scroll, copy, and do other things, that do not mutate markup.
As an example - secure mode in Excel. If u download some xlsx file - it opens in secure (view only) mode, where you can view content, but can't make changes. To be able to change contect - you have to press button "Allow editing", and then Excel changes it's mode and you are able to make changes.
There is a lot of use cases for this feature, exactly mine one is that i need to prevent some users from making changes, but need to let them view content.


Added cache for openai models.

Fixes Issue 414 by adding a diskcache to the openai backend.

I can't test this one so it will wait for Nathan to come back - however, you'll also need to add diskcache to our requirements, and I'm not sure we want to expand them so much

Thanks for the solutions ! I will be reviewing this tomorrow :)


Bug in getPatientBook() triggering NullPointerException

getPatientBook() has a bug that triggers a NullPointerException when the system tests run.

The tests still fail even after the bug gets resolved

The issue is with the storage of the PatientBook. The ModelManager has an incorrect implementation of the PatientBook storage

Issue has been resolved


Foot routing ignores a seemingly valid track

To reproduce, open this map.
Both start point and end point are on way 317632042

This way is not connected to the rest of the road network. E.g. see this node which has only one way

Let me clarify, I'm looking for a route within the way, not between this way and any other way.

If a way or a set of ways is completely disconnected from the rest of the network like in this case it is removed. The threshold for such mini islands is about ~200 junctions at the moment and therefor this way is removed.

To fix it: just connect this way to the already 'visually connected' ways in the north.


Rearranging code and some small formatting changes

Description

From index file send the source of our json data currently supporting twitter|github and render template based on that source - so some code has been moved around
Images getting cut in the pdf has been fixed - but flex needed to be disabled and some of it is broken I think - puru said he is going to fix that.

Attach Screenshot

Note 2 code reviewer approval needed. Approach in twitter group & discord channel.

Things to do:

Format the Question and Answer - have understood partials much better and will try to use that to reformat the hbs template
Testing framework with help from puru


tower-fallback: add implementation.

We'll need this in order to pinpoint errors in batch verification.  Another version of the same idea exists in the linkerd source tree somewhere, and it might be better to upstream that one rather than this one.  But this one will work for now.  It has a manually implemented future that avoids having to add an extra layer of boxing for every request.
Trying to use this for Redjubjub or Ed25519 (not included in this PR) reveals some gaps in the upstream APIs: the batch::Items need to be Clone (this is a real blocker) and there should be an Item::verify_alone() that does individual verification (rather than forcing the caller to create a batch of size 1).

@yaahc I used Either as the error type here to avoid having to write any bounds on error types and also to avoid having to allocate. But I guess this makes the error type bigger. Maybe we could fix it to be a different type in a later PR if you have a better idea?

@yaahc Okay, I'll just rewrite it to require Into<Box<dyn Error + ...>>.


add gather to deps

@moshez explained elsewhere that this is for local testing because the Travis build already passes.
This PR isn't necessary, though.  Same with https://github.com/ncolony/ncolony/commit/25bf89b095e2ca09a0e9ba8f04164c47e25a5a8e, https://github.com/ncolony/ncolony/commit/6280b576d3f6f4bfa5f546fec4dbfa91e73bed58, and https://github.com/ncolony/ncolony/commit/f3473c30bbe95918eb53cd5cc02cc2fe8e316f07.  Local tox runs fail iff their virtual environments predate the introduction of gather to install_requirements, because tox attempts to speed up installation by reinstalling the code under test into an existing test environment with nodeps:
docs inst-nodeps: /home/mrw/src/python/ncolony/build/.tox/dist/ncolony-17.9.0.zip

This is documented in passing in the introduction to tox's documentation:

When you run tox a second time you'll note that it runs much faster because it keeps track of virtualenv details and will not recreate or re-install dependencies. You also might want to checkout :doc:examples to get some more ideas.

(Emphasis added).   So the fix for local testing is to delete your build directory.


Ability to display only one side bar view at a time

Hello, I was wondering if a setting can be implemented where only one side bar view is displayed at a time. For example, let's say I only have the file explorer and the outline views in the side bar [open editors options is set to 0 in settings.json]. The file explorer view is fully expanded by default and the outline view is closed. However, when I click to fully expand the outline view, the file explorer view closes automatically. The same can be done vice versa and with more than two views in the side bar. I would love to hear from others about this idea, as I would personally find this useful. If such a feature exists through an extension, do let me know. Thanks!

Duplicate of #34136


Feature/replace ipl image

PR adjusts darknet_ros interface for the removal of IplImage and the C Macros.

PR depends on https://github.com/ntnu-arl/darknet/pull/1

PR depends on https://github.com/ntnu-arl/darknet/pull/1

@timonh fyi

@timonh fyi

looks good to me

looks good to me


Clarify current directory in userData

In your tutorials, such as https://www.pulumi.com/docs/tutorials/aws/ec2-webserver/, please clarify that userData is running in the root directory so files being written end up there (instead of the home directory). It took me a long time to figure this out :)

Addressed via 3e8d46cbb5df94b3b95bf74332b646b76db8a175