[Question] How can I set the pszText into NMLVDISPINFO correctly when handling lvn_get_disp_info event?

I have no idea how I can do that..

Because of Rust's strict lifetime checks, you must store the strings in an external place whose lifetime extends beyond the event closure. The ovbious place is the window object itself. From the docs example, we could have:
#[derive(Clone)]
pub struct WndMain {
    lv:   gui::ListView,
    strs: Vec<WString>,
}

This would allow us to have something like this:
let self2 = self.clone();
lv.on().lvn_get_disp_info(|di| {
    let item_idx = di.item.iItem as usize;
    di.item.set_pszText(self2.ee.get_mut(item_idx));
    Ok(())
});

Just keep in mind that LVN_GETDISPINFO is tricky notification, because it's wildly unsafe. It may be hard to get it right.

Umm..
I need to share the Vec between each event handler, but if I use Rc or Arc, the timelife will not meet.

but if I use Rc or Arc, the lifetime will not meet

If will if you clone it into the closure.

Nope

This question is tricker than I thought. The root cause is that, in C++, you pass a pointer to a string allocated somewhere else, and Rust's borrow checker goes crazy with such things.
The best I could come up with is to use an unsafe block to bypass the borrow checker:
let self2 = self.clone();
self.lv.on().lvn_get_disp_info(move |di| {
	let item_idx = di.item.iItem as usize;
	let mut strs = self2.strs.borrow_mut();
	let str_mut = strs.get_mut(item_idx).unwrap();
	let str_ptr = str_mut as *mut w::WString;
	di.item.set_pszText(Some(unsafe { &mut *str_ptr }));
	Ok(())
});

I can't test this right now, there's a risk of invalid memory access somehow (just like in C++). Please let me know if this approach works for you.

It does work but umm...
If I enable LTO in the build, the code won't work.

Can you post your code here, so I can try to reproduce this?

main.rs
use std::{cell::RefCell, rc::Rc};

use winsafe::{
    co,
    gui::{self, Horz, Vert},
    msg,
    prelude::*,
    AnyResult, WString,
};

#[derive(Clone)]
struct DemoWindow {
    window: gui::WindowMain,
    list: gui::ListView,
    insert_button: gui::Button,
    items: Rc<RefCell<Vec<WString>>>,
}

impl DemoWindow {
    fn new() -> Self {
        let window = gui::WindowMain::new(gui::WindowMainOpts {
            title: "Demo Window".to_owned(),
            size: (1024, 768),
            ..Default::default()
        });
        let list = gui::ListView::new(
            &window,
            gui::ListViewOpts {
                position: (0, 68),
                size: (1024, 700),
                list_view_style: co::LVS::REPORT
                    | co::LVS::NOSORTHEADER
                    | co::LVS::SHOWSELALWAYS
                    | co::LVS::SHAREIMAGELISTS
                    | co::LVS::OWNERDATA,
                columns: vec![("Column 1".to_owned(), 600)],
                resize_behavior: (Horz::Resize, Vert::Resize),
                ..Default::default()
            },
        );
        let insert_button = gui::Button::new(
            &window,
            gui::ButtonOpts {
                text: "Insert new item".to_owned(),
                position: (0, 0),
                width: 100,
                ..Default::default()
            },
        );
        let demo_window = DemoWindow {
            window,
            list,
            insert_button,
            items: Rc::new(RefCell::new(Vec::new())),
        };

        demo_window.handle_events();

        demo_window
    }

    fn handle_events(&self) {
        let self_cloned = self.clone();
        self.insert_button.on().bn_clicked(move || {
            let count = self_cloned.list.items().count();
            self_cloned
                .items
                .borrow_mut()
                .push(WString::from_str(count.to_string()));
            self_cloned
                .list
                .hwnd()
                .SendMessage(msg::lvm::SetItemCount {
                    count: count + 1,
                    behavior: co::LVSICF::NoValue,
                })?;
            Ok(())
        });

        let self_cloned = self.clone();
        self.list.on().lvn_get_disp_info(move |info| {
            let index = info.item.iItem as usize;
            let mut strs = self_cloned.items.borrow_mut();
            let str_mut = strs.get_mut(index).unwrap();
            let ptr = str_mut as *mut WString;
            info.item.set_pszText(Some(unsafe { &mut *ptr }));
            Ok(())
        });
    }

    fn run(&self) -> AnyResult<i32> {
        self.window.run_main(None)
    }
}

fn main() {
    let app = DemoWindow::new();
    let _ = app.run();
}

Cargo.toml
[package]
name = "virtual-list-demo"
version = "0.1.0"
edition = "2021"

[dependencies]
winsafe = { git = "https://github.com/rodrigocfd/winsafe", features = [ "gui" ] }

[profile.release]
opt-level = 3
lto = true

According to this article, we must copy the characters to the buffer pointed by LVITEM, instead of setting the pointer. Until now this was not possible, because the pointer was protected.
So I implemented a new method, raw_pszText, which returns the raw pointer. With it, we can write the following:
let self_cloned = self.clone();
self.list.on().lvn_get_disp_info(move |info| {
	if info.item.mask.has(co::LVIF::TEXT) { // is this a text request?
		let index = info.item.iItem as usize;
		let strs = self_cloned.items.borrow();
		let str_ref = strs.get(index).unwrap(); // string for the requested item

		let (ptr, cch) = info.item.raw_pszText(); // retrieve raw pointer
		let out_slice = unsafe { std::slice::from_raw_parts_mut(ptr, cch as _) };
		out_slice.iter_mut()
			.zip(str_ref.as_slice())
			.for_each(|(dest, src)| *dest = *src); // copy from our string to their buffer
	}
	Ok(())
});

Let me know if this works for you.

Yes, it works, thank you!

I made a small improvement for the LVM_SETITEMCOUNT message, which now can be sent straight from the control itself.
Instead of:
self_cloned
	.list
	.hwnd()
	.SendMessage(msg::lvm::SetItemCount {
		count: count + 1,
		behavior: co::LVSICF::NoValue,
	})?;

you can do just:
self_cloned.list.items()
	.set_item_count(count + 1, None);

Neat!

But if WString is much larger than cchTextMax, it may overflow...

In my example it won't, because I'm copying with zip.

Won't there be something other than \0 in the last element of out_slice if str_ref is too long?

Minor nitpick: the method is called set_count, not set_item_count.
Anyway,

Won't there be something other than \0 in the last element of out_slice if str_ref is too long?

yes, indeed. I've ran into this in the past, so I forgot I already implemented a safe way to do this, the WString::copy_to_slice method, which takes care of the terminating null.
So, instead of
out_slice.iter_mut()
	.zip(str_ref.as_slice())
	.for_each(|(dest, src)| *dest = *src); // copy from our string to their buffer

just use
str_ref.copy_to_slice(out_slice); // copy from our string to their buffer

okay...

Umm..Will there be a safer method to set text?

Even if I write a wrapper to set the text, we don't own that pointer (Windows does), so it could still trigger UB, so it would have to be unsafe as well.
The only way I see to provide a safe wrapper would be to add another level of wrappers over all events. That would be very time-consuming and potentially slower, so I don't really think it's a good idea for now.


Seemingly too many checkouts

Current
Commit : a88de041c59b96bea6fff0f4ec64b1464f782a1b
File : https://github.com/autodrive/utils3/blob/develop/git_update_all.py
https://github.com/autodrive/utils3/blob/a88de041c59b96bea6fff0f4ec64b1464f782a1b/git_update_all.py
from branch d -> master -> fetch -all -> git rebase @{u} -> d
-> master -> git update upstream/master -> d
Possible plan
from branch d -> master -> fetch -all -> git rebase @{u} -> git update upstream/master -> d

c990078a7bb3b45b4400a52e91a42099aea1947c seems to resolve the issue


The dataset preprocess method not publish

In the Hyper_dataset class has used many data file, which the author does not provide the process code or example one item.
Please provide above it?

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thank for your sharing!
But it make me a little confused that the SOTA experiment result did not achieve in which the input was CAVE x8 downsample HSI and the used network was spenet.
Could you give me guidance which tell me how to train correctly?

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thank for your sharing!
But it make me a little confused that the SOTA experiment result did not achieve in which the input was CAVE x8 downsample HSI and the used network was spenet.
Could you give me guidance which tell me how to train correctly?

Do you correctly divide the traing/testing dataset according to our paper? Different data division method may affect the performance.

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thank for your sharing!
But it make me a little confused that the SOTA experiment result did not achieve in which the input was CAVE x8 downsample HSI and the used network was spenet.
Could you give me guidance which tell me how to train correctly?

Did you correctly divide the traing/testing dataset according to our paper? Different data division method may affect the performance.

Thank for your reply~
I chose the first twelve image as train set, and the other as test set.
In the paper, I noticed that the data is randomly divided into train and test set. Could you tell me how to select the train and test set then the result being SOTA?

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thank for your sharing!
But it make me a little confused that the SOTA experiment result did not achieve in which the input was CAVE x8 downsample HSI and the used network was spenet.
Could you give me guidance which tell me how to train correctly?

Did you correctly divide the traing/testing dataset according to our paper? Different data division method may affect the performance.

Thank for your replying~
I chose the first twelve image as train set, and the other as test set.
In the paper, I noticed that the data is randomly divided into train and test set. Could you tell me how to select the train and test set then the result being SOTA?

Please refer to our paper for data division. We give the detialed images used for training and testing. Moreover, we will also provide correspoding code soonly.

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thank for your sharing!
But it make me a little confused that the SOTA experiment result did not achieve in which the input was CAVE x8 downsample HSI and the used network was spenet.
Could you give me guidance which tell me how to train correctly?

Did you correctly divide the traing/testing dataset according to our paper? Different data division method may affect the performance.

Thank for your replying~
I chose the first twelve image as train set, and the other as test set.
In the paper, I noticed that the data is randomly divided into train and test set. Could you tell me how to select the train and test set then the result being SOTA?

Please refer to our paper for data division. We give the detialed images used for training and testing. Moreover, we will also provide correspoding code soonly.

I splitted the training and testing  test carefully according to reference in the paper(MHF-Net). After 1000 epoch training, I didn't get the SOTA result on testing set. I wished I got the SOTA result if the authors told the correct way  to me.

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thank for your sharing!
But it make me a little confused that the SOTA experiment result did not achieve in which the input was CAVE x8 downsample HSI and the used network was spenet.
Could you give me guidance which tell me how to train correctly?

Did you correctly divide the traing/testing dataset according to our paper? Different data division method may affect the performance.

Thank for your replying~
I chose the first twelve image as train set, and the other as test set.
In the paper, I noticed that the data is randomly divided into train and test set. Could you tell me how to select the train and test set then the result being SOTA?

Please refer to our paper for data division. We give the detialed images used for training and testing. Moreover, we will also provide correspoding code soonly.

I splitted the training and testing test carefully according to reference in the paper(MHF-Net). After 1000 epoch training, I didn't get the SOTA result on testing set. I wished I got the SOTA result if the authors told the correct way to me.

In our paper, we give the detailed training and testing samples in Figure.4. Plase train our network with illustration of Figure.4.

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thank for your sharing!
But it make me a little confused that the SOTA experiment result did not achieve in which the input was CAVE x8 downsample HSI and the used network was spenet.
Could you give me guidance which tell me how to train correctly?

Did you correctly divide the traing/testing dataset according to our paper? Different data division method may affect the performance.

Thank for your replying~
I chose the first twelve image as train set, and the other as test set.
In the paper, I noticed that the data is randomly divided into train and test set. Could you tell me how to select the train and test set then the result being SOTA?

Please refer to our paper for data division. We give the detialed images used for training and testing. Moreover, we will also provide correspoding code soonly.

I splitted the training and testing test carefully according to reference in the paper(MHF-Net). After 1000 epoch training, I didn't get the SOTA result on testing set. I wished I got the SOTA result if the authors told the correct way to me.

In our paper, we give the detailed training and testing samples in Figure.4. Plase train our network with illustration of Figure.4. Thanks.

After comparing the training samples, I strictly followed the paper guidance. Though the result has got the significant improvement, I still did not get the result as well as the paper? It's hopeful that I can get the more precisely method about the training network from you, please~
Test's PSNR during the training:

Data division:

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thank for your sharing!
But it make me a little confused that the SOTA experiment result did not achieve in which the input was CAVE x8 downsample HSI and the used network was spenet.
Could you give me guidance which tell me how to train correctly?

Did you correctly divide the traing/testing dataset according to our paper? Different data division method may affect the performance.

Thank for your replying~
I chose the first twelve image as train set, and the other as test set.
In the paper, I noticed that the data is randomly divided into train and test set. Could you tell me how to select the train and test set then the result being SOTA?

Please refer to our paper for data division. We give the detialed images used for training and testing. Moreover, we will also provide correspoding code soonly.

I splitted the training and testing test carefully according to reference in the paper(MHF-Net). After 1000 epoch training, I didn't get the SOTA result on testing set. I wished I got the SOTA result if the authors told the correct way to me.

In our paper, we give the detailed training and testing samples in Figure.4. Plase train our network with illustration of Figure.4. Thanks.

After comparing the training samples, I strictly followed the paper guidance. Though the result has got the significant improvement, I still did not get the result as well as the paper? It's hopeful that I can get the more precisely method about the training network from you, please~
Test's PSNR during the training:

Data division:

Thanks very much for your interests on our project. I have corrected the code, where I have commented out the ensential component, zero-norm. You can try agin. If any questions, feel free to ask.

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thank for your sharing!
But it make me a little confused that the SOTA experiment result did not achieve in which the input was CAVE x8 downsample HSI and the used network was spenet.
Could you give me guidance which tell me how to train correctly?

Did you correctly divide the traing/testing dataset according to our paper? Different data division method may affect the performance.

Thank for your replying~
I chose the first twelve image as train set, and the other as test set.
In the paper, I noticed that the data is randomly divided into train and test set. Could you tell me how to select the train and test set then the result being SOTA?

Please refer to our paper for data division. We give the detialed images used for training and testing. Moreover, we will also provide correspoding code soonly.

I splitted the training and testing test carefully according to reference in the paper(MHF-Net). After 1000 epoch training, I didn't get the SOTA result on testing set. I wished I got the SOTA result if the authors told the correct way to me.

In our paper, we give the detailed training and testing samples in Figure.4. Plase train our network with illustration of Figure.4. Thanks.

After comparing the training samples, I strictly followed the paper guidance. Though the result has got the significant improvement, I still did not get the result as well as the paper? It's hopeful that I can get the more precisely method about the training network from you, please~
Test's PSNR during the training:

Data division:

Thanks very much for your interests on our project. I have corrected the code, where I have commented out the ensential component, zero-norm. You can try agin. If any questions, feel free to ask.

Thanks for the question :), the source data of CAVE dataset is aviliable in https://drive.google.com/drive/folders/1rjvP9d0tmM_zkbXWfIMK4fDP6HVSMVI9?usp=sharing . We will provide source code on the other datasets soonly, after finishing some projects.

Thank for your sharing!
But it make me a little confused that the SOTA experiment result did not achieve in which the input was CAVE x8 downsample HSI and the used network was spenet.
Could you give me guidance which tell me how to train correctly?

Did you correctly divide the traing/testing dataset according to our paper? Different data division method may affect the performance.

Thank for your replying~
I chose the first twelve image as train set, and the other as test set.
In the paper, I noticed that the data is randomly divided into train and test set. Could you tell me how to select the train and test set then the result being SOTA?

Please refer to our paper for data division. We give the detialed images used for training and testing. Moreover, we will also provide correspoding code soonly.

I splitted the training and testing test carefully according to reference in the paper(MHF-Net). After 1000 epoch training, I didn't get the SOTA result on testing set. I wished I got the SOTA result if the authors told the correct way to me.

In our paper, we give the detailed training and testing samples in Figure.4. Plase train our network with illustration of Figure.4. Thanks.

After comparing the training samples, I strictly followed the paper guidance. Though the result has got the significant improvement, I still did not get the result as well as the paper? It's hopeful that I can get the more precisely method about the training network from you, please~
Test's PSNR during the training:

Data division:

Thanks very much for your interests on our project. I have corrected the code, where I have commented out the ensential component, zero-norm. You can try agin. If any questions, feel free to ask.

Thank for your replying!
There is possible that you provide me with the trained model so that I can compare with the local model parameters.

There is possible that you provide me with the trained model so that I can compare with the local model parameters.

OK, here are the pretrained model with code. it can achieve SOTA performance: https://drive.google.com/drive/folders/12EF862NiA7enYze7HYazSioeIUVl51__?usp=sharing


Remove ContentSizeChangeEvent from core

Summary:
This class is not referenced anywhere. It used to be part of webview, which has been removed from RN's core.
Since we still have external users of this class, let's deprecate it first.
Changelog: [Android][Removed] Deprecated internal ContentSizeChangeEvent
Reviewed By: NickGerleman
Differential Revision: D50325736

Closed by https://github.com/facebook/react-native/commit/2018a82a531c5d297b346a70f6cc629262f7108b


Snowflake support

Adapter added for Snowflake: https://github.com/ontop/ontop/commit/1f3832e5a555ad9d076fc36878a94a85001eebe5

Lightweight tests added: https://github.com/ontop/ontop/commit/7902c44db815bf61bf7b2d4ab0ec71ccc3ece126


kep updates for toc

What type of PR is this?
/kind documentation

What this PR does / why we need it
KEP updates have not been run in a while.
I ran hack/update-toc.sh and it updated a few of the jobs.
Which issue(s) this PR fixes

Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?

NONE

/close


rao_analysis | Add a program to trim the SSRAOs grid for a structure being installed with defined tolerance.

Current solution is below:

Convert vessel .dat file with Seastate RAOs to .yml file
Run the digitalmodel program and provide the CoG and the structures dimensiosn relative to .yml. Coordinates should be the model coordinates of the vessel.
Run the program with the .yml file and the digitalmodel output file.
Copy digitalmodel output file into suitable format with a key and the output as value.
Copy this into the main file to get the reduced seastate RAO file for further analysis.

relocated to https://github.com/vamseeachanta/digitalmodel/issues/18


bug: sound list icons are broken on smaller viewports

How to Reproduce

Open DevTool.
Switch to smaller viewport.
Icons will look wonky.

Expected
Icons remain same size regardless of viewport.

Please add screenshot

Standard Viewport

Smaller Viewport

When you resize your window, the time icon shrink and eventually disappear.


Cant start any existing projects

Bug report
Describe the bug
Running on macOS 18.06, I can't start any projects.
End up getting this:
http://ss.lfgame.rs/f5ed26f978c3
http://ss.lfgame.rs/c6c000b55401

Oy. somehow i submitted this in the wrong repo.... entirely.


QT WordPress Page

A new QT page is currently being drafted and with Charlotte Evans who will get final approval.
Once approved a web page needs to be created on the Word Press site as teams will sign post to this and shorten the email or instructions and help they currently send out.
Warren - This should show on the QT platform for tests as a sort of help link.
Jeremy - I gave you early drafts and I have not seen many changes

@JeremykJAC is this still an active ticket with anything to do?

@warrensearle I'm not sure on the status at the moment. I have just emailed Charlotte Evans and put you on copy. The last message I can see was in May saying she will be in touch. I have asked for a call to ensure we can capture any outstanding work. Please leave this here or in blocked until I can verify next week.

https://www.figma.com/proto/IrpMkEyf8ZLCZGFfCEZPLS/Webpage---Guide-on-JAC-Selection-Process?node-id=25-2286&starting-point-node-id=25%3A2286


Modify file saving so writes are atomic

This is done by writing to a temporary file and moving the temporary file to the location of the original file once writing is complete (an atomic operation on many common filesystems).
Look at PEX's implementation for reference -- https://github.com/PEXPlugins/PermissionsEx/blob/a0821374f35d4effaf4d21f940f538b0af8f6eac/src/main/java/ru/tehkode/permissions/backends/file/FileConfig.java#L43

Ok, this is probably best implemented as a wrapper around FileOutputStream and a custom (Byte|Char)Sink


Unable to initiate scan

Version 2.2
Command:
python3 osmedeus.py --client -t domain.name
Error
[*] Loading config file from: /root/.osmedeus/client.conf
Traceback (most recent call last):
  File "osmedeus.py", line 161, in <module>
    main()
  File "osmedeus.py", line 157, in main
    parsing_argument(args)
  File "osmedeus.py", line 46, in parsing_argument
    options = auth.login(options)
  File "/root/.tools/Osmedeus/lib/sender/auth.py", line 16, in login
    if r.json().get('access'):
AttributeError: 'NoneType' object has no attribute 'json'

Your command should be like this python3 osmedeus.py -t domain.name without --client option.

Hi @j3ssie!
I got to this issue with the same problem, I just setup everything "out of the box" to give Osmedeus a try (that looks amazing) and I just get this same error.
The command I run is:
python3 osmedeus.py -t example.com

and I get:
Traceback (most recent call last):
  File "./osmedeus.py", line 161, in <module>
    main()
  File "./osmedeus.py", line 157, in main
    parsing_argument(args)
  File "./osmedeus.py", line 46, in parsing_argument
    options = auth.login(options)
  File "/home/Osmedeus/lib/sender/auth.py", line 16, in login
    if r.json().get('access'):
AttributeError: 'NoneType' object has no attribute 'json'

I'm probably missing something... thanks in advance!

i have the same problem please help me
thanks in advance

Hello,
I have the same issue:
Command:
sudo python3 osmedeus.py -t example.com
Output:
 File "/home/kali/Downloads/Osmedeus/lib/sender/auth.py", line 16, in login
      if r.json().get('access'):
 AttributeError: 'NoneType' object has no attribute 'json'

Thank you!

Use the update feature of osmedeus itself and try again. That solved it for
me :)
On Sun, 3 May 2020 at 14:34, huynhdobaoduy<EMAIL_ADDRESS>wrote:

Hello,
I have the same issue:
Command:
sudo python3 osmedeus.py -t example.com
Output:
File "/home/kali/Downloads/Osmedeus/lib/sender/auth.py", line 16, in login
if r.json().get('access'):
AttributeError: 'NoneType' object has no attribute 'json'
Thank you!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/j3ssie/Osmedeus/issues/134#issuecomment-623103305,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA5HDXV6PCLB7ILGNXECBQTRPVQERANCNFSM4KZMHMJA
.

--
┌─┐ └─Sent from your mobile phone. Sorry for any typo or the brevity.

The issue is no longer exist due to the repo having been upgraded to Osmedeus Next Generation v4.0

The issue is no longer exist due to the repo having been upgraded to Osmedeus Next Generation v4.0


Project site appears behind on version

Describe the problem
Project and documentation site is showing version 3.4.2, but Github shows 3.4.7.  Seems like an update is needed there.  :)
https://sound.balenalabs.io/

@iamsolankiamit can you help us out here? Looks like landrbot is producing the preview websites fine but the production one is not being updated on merge.

Fixed!


decimal: fix bug in do_sub

Hi，
It seems a bug exist according to tidb's implementation: https://github.com/pingcap/tidb/blob/master/types/mydecimal.go#L1519
And the corresponding case is data with lots of suffix 0:
3.10000000000-2.00
3.00-2.00000000000

@BusyJay @coocood

LGTM

/run-integration-tests


Target framework drop down behaves inconsistently

New asp.net web application
Edit the project file and add net452 as a 2nd framework
Open startup.cs. On my machine it defaults to net452 even though it is 2nd in the  property. Change to 1.1
Open program.cs.  It opens as net452.
Switch back to startup.cs. It flips to net452.  Change it to 1.1
Switch back to program.cs. It remains as net452.
Close all documents. Open startup.cs - it is net452, change it to 1.1 and close it.
Reopen startup.cs. it is at net452.

This is completely inconsistent and varies depending on how much you play with it. Sometimes the framework appears project wide and sometimes per document.
Do the same test with Shared projects. Changing the framework changes it for all documents in the project. It is remembered after closing all documents and even closing and reopening the solution.

I think these issues are likely due to the 3 issues mentioned here: https://github.com/dotnet/roslyn-project-system/issues/1013#issuecomment-282153150

Is this now fixed with your changes @mavasani ?

Verified that this is now fixed.


Change default benchmark mode to upstream PyTorch

Current state (https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/10950264922 vs https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/10949253321):

Softmax: triton geomean diff: 13%, xetla geomean diff: 8%, ratio geomean diff: 5%

The performance deteriorates most on small data. For example, for N=256, the average value of milliseconds, from which teraflops are calculated, changes as follows: 0.0055 vs 0.0116. The difference is about 5-6 microseconds. This is approximately the time spent on the host to run the kernel and cannot be avoided. An option may be to increase the data volume, which will reduce the impact of associated time losses.

FA advanced: ~triton geomean diff: 2%, xetla geomean diff: 3%, ratio geomean diff: 2%.~ Correct numbers are: triton geomean diff: -2.3%, xetla geomean diff: -4%, ratio (triton/xetla) geomean diff: 1.7%

This change shouldn't be a problem, part of it is definitely fluctuations in measurements.
To check the correctness it seems we can use the cpu version: https://github.com/intel/intel-xpu-backend-for-triton/pull/2300

GEMM advanced: ~triton geomean diff: 2%, xetla geomean diff: 2%, ratio geomean diff: 4%~. Correct numbers are: triton geomean diff: -4.1%, xetla geomean diff: -2.7%, ratio (triton/xetla) geomean diff: -1.4%
Float conversion microbenchmark: BF16 geomean diff: << 1%, FP16 geomean diff: << 1%

Should the ratio diff be recalculated for FA as well? FA advanced: triton geomean diff: 2%, xetla geomean diff: 3%, ratio geomean diff: 2%.
Do you know why the degradation of Triton is much higher than XeTLA for Softmax?

Do you know why the degradation of Triton is much higher than XeTLA for Softmax?

Most likely due to different time spent on the host, in the case of Triton there is more Python code, which is slower than C++.
@whitneywhtsang since GEMM on Triton it became worse than planned, I suppose it is worth rolling back this change? Or is this an acceptable change?

Do you know why the degradation of Triton is much higher than XeTLA for Softmax?

Most likely due to different time spent on the host, in the case of Triton there is more Python code, which is slower than C++.
@whitneywhtsang since GEMM on Triton it became worse than planned, I suppose it is worth rolling back this change? Or is this an acceptable change?
UPD: about overhead in Triton: triton-lang/triton#3166

We should report the performance number with IPEX on by default because without IPEX the timing taken by upstream PyTorch is not precise (not just the kernel time).  IMHO we should revert this change.


Fix android camera Already in use error

Hello!
I'm Dan Lee, a lead developer from South Korea.
While using your library, I encountered an error in the Android environment stating that the camera was already in use when trying to load the camera preview on a different screen. This issue was not present in the iOS environment.
Upon investigation, I discovered that even after cancelling the event subscription with cancel(), the camera remained open at the native level, preventing its use on other screens.
To resolve this error, I added a method to manually unbind the camera in the Android environment within the library source code and called it during dispose(). Other way, Adding this into cancel() method might be good also.
Thank you for developing such an excellent library.

Hi @Danik420 !
Thanks for the


Block browser shortcut

Is there a way to block browser capturing the keys, like ctrl+o or ctrl+s?
Try example in chrome and use ctrl+o.
Thanks.

In fact, it is fairly simple...
Simply use the e.preventDefault() in the onKeyEvent callback function.
       const handleKeyboard = (key, e) => {     e.preventDefault();     if (key === 'ctrl-s') {       onSave();     } ... <KeyboardEventHandler         isDisabled={!isDirty}         handleKeys={['ctrl+s']}         handleFocusableElements         onKeyEvent={handleKeyboard}       />


[api-docs] Add return types to slash command permission endpoints

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/32098e9acaa3131508225b79ee490ff168b7af18

Done


Readme update

Updating readme to correct path in creating CRD
removed "$" from code blocks.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.229%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1891

Relevant Lines:
2357

💛  - Coveralls

LGTM


2499 clearly render proposal contents

issue #85

Please adjust the account_update

if it is a proposed operation (fromComponent: "proposed_operation",):

[ ] if the operation changes any of the active owner or memo keys, then add a red string at the end of the operation description "Dangerous operation!"
To recognize if the keys are changed you need to check the operation payload if active owner or memo is present and changed (see screenshot) as compared to the the currently set permission of the account

[ ] if keys are changed, add those keys in the operation description with "+<public_key>" and "-<public_key" added at the end of the operation description
[ ] if votes are changed within the account options, display what votes are changed

I

Please adjust the account_update

if it is a proposed operation (fromComponent: "proposed_operation",):

[x]  if the operation changes any of the active owner or memo keys, then add a red string at the end of the operation description "Dangerous operation!"
To recognize if the keys are changed you need to check the operation payload if active owner or memo is present and changed (see screenshot) as compared to the the currently set permission of the account

[x]  if keys are changed, add those keys in the operation description with "+<public_key>" and "-<public_key" added at the end of the operation description
[x]  if votes are changed within the account options, display what votes are changed

I`ve implemented this feature, please review it

Please also resolve worker proposal names

I had to adjust the component because it didnt work with key changes. Please investigate my changes. Did it render on your end?

I`ve added worker proposal names. I found that we have a problem with render Activity tab on the first launch. That caused because we receive null in response  ChainStore.getObjectsByVoteIds(). I tried to receive a response in promise but had the same result. There are no problems on render Proposed operations tab. Maybe you have any idea why it happens?

I found the rendering issue reason. I fixed it, please review.

Is this based on develop or https://github.com/blockchainprojects/bitshares-ui/pull/66 ?

it is based on develop

This will be annoying, but necessary ...
Please rebase against latest develop, and add the new HTLC operations. They have been added in the old format in develop and need to be translated into the new format.

I`ve merged the latest changes from develop and add HTLC operations into the new format

Accepted


[travis] cache opam and ocaml dependencies

saves about 5 min (50%) on the linux builds. caching on open source mac builds isn't supported yet, so we'll have to do our own upload to S3 if we want to cache that.

@facebook-github-bot shipit


setTimeout, setInterval, clearTimeout, clearInterval functions does not work with JavaScriptCore framework in iPhone

I have integrated Jasmine with iPhone project. I am running Jasmine using JavaScriptCore framework for iPhone. But JavaScriptCore is unable to interpret setTimeout and all that  function.
I have statically defined those as below
this.setTimeout    = function() {};
this.clearTimeout  = function() {};
this.setInterval   = function() {};
this.clearInterval = function() {};
I found that these functions are not part of JavaScriptCore. What could be solution to this...?? Is there any other alternative to these function??

usually you can do this way:
timeoutID = window.setTimeout(function(){}, 1000);
window.clearTimeout(timeoutID);
timeintervalID = window.setInterval(function(){}, 1000);
window.clearInterval(timeintervalID);

Thanks filipposarzana for your reply. But window is not defined in JavaScriptCore. so unable to get window object and hence the functions of it.. can you guide me some alternate way with JavaScriptCore..
thanks again...

Is the suggested fix that Jasmine not assume these functions are present? I believe we have to depend on setTimeout working in some situations.


Make camera controls script play nice with XR

Disable script update when XR session is active
Restore camera pos/rot when exiting XR

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott - good to merge or other plans with this?

@willeastcott - good to merge or other plans with this?

Needs testing - I'll do that today.


integration: Use cmpopts.IgnoreUnexported for cmp.Diff

Ignore unexported fields when doing cmp.Diff to avoid panic during test runs. Currently, I see only containercollection.Container{} has unexported events.
Testing done
Break the test with:
Patch

diff --git a/integration/ig/non-k8s/list_containers_test.go b/integration/ig/non-k8s/list_containers_test.go
index fb68774a..10d56f8b 100644
--- a/integration/ig/non-k8s/list_containers_test.go
+++ b/integration/ig/non-k8s/list_containers_test.go
@@ -37,7 +37,7 @@ func TestFilterByContainerName(t *testing.T) {

                        normalize := func(c *containercollection.Container) {
                                c.ID = ""
-                               c.Pid = 0
+                               //c.Pid = 0
                                c.OciConfig = nil
                                c.Bundle = ""
                                c.Mntns = 0

before the PR
Diff

...
--- FAIL: TestFilterByContainerName (14.89s)
panic: cannot handle unexported field at {*containercollection.Container}.ownerReference:
        "github.com/inspektor-gadget/inspektor-gadget/pkg/container-collection".Container
consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported [recovered]
        panic: cannot handle unexported field at {*containercollection.Container}.ownerReference:
        "github.com/inspektor-gadget/inspektor-gadget/pkg/container-collection".Container
consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported

goroutine 8 [running]:
testing.tRunner.func1.2({0x16cf0e0, 0xc0003059d0})
        /home/qasim/go/go1.19.4/src/testing/testing.go:1396 +0x24e
testing.tRunner.func1()
        /home/qasim/go/go1.19.4/src/testing/testing.go:1399 +0x39f
panic({0x16cf0e0, 0xc0003059d0})
        /home/qasim/go/go1.19.4/src/runtime/panic.go:884 +0x212
github.com/google/go-cmp/cmp.validator.apply({{}}, 0xc000282000, {0x189e300?, 0xc00028e0d8?, 0xc000305900?}, {0x189e300?, 0xc00028e1c8?, 0xc00028e0d8?})
        /home/qasim/go/pkg/mod/github.com/google/go-cmp@v0.5.9/cmp/options.go:246 +0x3bd
github.com/google/go-cmp/cmp.(*state).tryOptions(0xc000282000, {0x1bda748, 0x189e300}, {0x189e300?, 0xc00028e0d8?, 0x7f0af0450a38?}, {0x189e300?, 0xc00028e1c8?, 0x40f69f?})
        /home/qasim/go/pkg/mod/github.com/google/go-cmp@v0.5.9/cmp/compare.go:304 +0x11a
github.com/google/go-cmp/cmp.(*state).compareAny(0xc000282000, {0x1bca7c8, 0xc0000b6000?})
        /home/qasim/go/pkg/mod/github.com/google/go-cmp@v0.5.9/cmp/compare.go:259 +0x451
...
...

after the PR
Diff

...
          &containercollection.Container{
                Runtime:   "docker",
                ID:        "",
        -       Pid:       0,
        +       Pid:       369045,
                OciConfig: nil,
                Bundle:    "",
                ... // 2 ignored and 12 identical fields
          }

--- FAIL: TestFilterByContainerName (15.93s)
FAIL
...

However, I think a definitive solution would be to use https://pkg.go.dev/github.com/stretchr/testify/ that doesn't seem to have this issue.

Nice! I will merge this now and we can clean this once we switch to testify!


Wishlist: http://www.grocerycrud.com/

Can you please add the http://www.grocerycrud.com/ so the CRUD could be more easy?

I've never used it, but as soon as I have time I'll take a look


WiP : Create gradio demo on huggingface

This is the Gradio Demo version for collabora/whisperspeech library

it's slightly different than the hosted version
it's in a folder : collabora/whisperspeech/whisperspeech/gradiodemo.py

requires

decisions regarding how to organize it in the repository + correctly

Refs
issue : https://github.com/collabora/WhisperSpeech/issues/39
huggingface demo : https://huggingface.co/spaces/Tonic/whisperspeech

@jpc idea : make a notebook that launches the gradio with gradio.demo(share=True) , normally that will produce a gradio url as a result which is actually the gradio demo but basically it's running out of the notebook
this could help with keeping the notebook-flavor around here. thoughts?


[Feature Request] A guide for creating custom DeepDream models

The current DeepDream guide located here, uses the inception5h model. From what I can tell, it does not appear very straightforward in terms of how to fine tune the model in order to create different DeepDream hallucinations from a custom data set. It also does not appear to be relatively easy to change the model that the guide uses.
I think that an additional guide which shows individuals how to fine tune a model for the purposes of DeepDream would be useful for those trying to explore the artistic and visual aspects of TensorFlow models. I haven't been able to find any guide for creating custom DeepDream models in Tensorflow, so I am not sure where to start.

Thank you for the feedback. Generally speaking, tutorials are meant to cover a breadth of topics. Our goal is to show users what's possible and help them get the ball rolling.
Since the DeepDream notebook is very popular, it might be worth going more in depth. I'm not sure if it's something we have time to work on. But I think it's worth asking @znah what he thinks.

@jart At the moment, I've found it extremely confusing as to how to use other pre-trained models with the tutorial's code. I've tried using the model from: http://download.tensorflow.org/models/image/imagenet/inception-2015-12-05.tgz, but I couldn't figure out how to get it working with the code. The stripped Android model (inception5h) seems to be really different from other models, and I haven't yet figured out how to use a different model with the DeepDream tutorial code, let alone a model that I finetuned myself.

Same issue as @ProGamerGov , the input tensors are not recognised for either of inception v3 or any subsequent models (model zoo, tensorflow).

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Move models and responses into their own sub-packages

In an effort to reduce the number of symbols in the root package namespace, we could move the response and model types into their own sub-packages.

Response/result types would move to the responses package.
Constants and models would move to the types package.

A complete prototype can be found here.

We have decided to not do this.


[CRITICAL] Migrate the BaseAutoCompleteSuggestions to Flashlist

Part of https://github.com/Expensify/App/issues/28902
Let's migrate BaseAutoCompleteSuggestions to use Flashlist component instead of FlatList
Callstack is working on the migration right now.
Lets use this issue for daily updates on this migration

Hi, I'm Adam from Callstack. I'd like to work on this :)

I will await a PR. Do you expect to make daily progress on this issue?

Not really, imo this could be set to weekly. Linking an android issue that I'd have to work around for reference (with nesting gesture scopes): https://github.com/software-mansion/react-native-gesture-handler/issues/2582

@adhorodyski if there is anything you need to help with the gesture handler, we can bring it up in slack and hook in SWM people to work on the issue

Oh sure, let me open up a PR which works I think everywhere except for Android.

thread is here https://expensify.slack.com/archives/C05LX9D6E07/p1699460749625439

Now awaiting a C+ review in https://github.com/Expensify/App/pull/31057 :)

I'm going ooo until Monday Nov 27th so going to assign another BZ teammate to monitor this until I'm back. Thanks!
Status: reviewing PR

@robertKozik was C+ so will invoice us separately. Same  for @adhorodyski
So we can close this


Update [...15]misc-conveniences.md

Typo.
Let's see if this branch works with CI.

good catch... cheers!


Fix hangup in validation plugin

Hello :smile:
currently alamid has a small bug, which leads to a hangup with the following sample code
var AlamidSchema = require("alamid-schema");
AlamidSchema.use(require("alamid-schema/plugins/validation"));

var mySchema = new AlamidSchema("MySchema", {
	var: {}
});

mySchema.validate({}, function () {
	console.log("Should call back"); // Actually it didn't!
});

This PR should fix the issue.
Regards,
Benjamin

Thanks @benurb for finding and fixing!
One thing should be changed: The callback should be called wrapped in a setTimeout(0) to be consistent with async behavior. See line 43ff. Thanks man!

Done. Though personally I would use setImmediate() instead.

I would prefer setImmediate too, but it won't work on the client then ;)

True :smile:

Thanks again!

No problem, thanks for your work.
May I kindly ask when the next (npm) release is scheduled? :grinning:

Right after my Breakfast.

Am 03.02.2015 um 09:30 schrieb Benjamin Urban<EMAIL_ADDRESS>No problem, thanks for your work.
May I kindly ask when the next (npm) release is scheduled?
—
Reply to this email directly or view it on GitHub.

<EMAIL_ADDRESS>

:+1: thank you!

Thank you for the fix :+1:

We could use setImmediate. Webpack supports it, it's mentioned at MDN, IE 10 supports it :+1: and there is a robust polyfill.


add: ignore discord bot request in view count

This commit adds a view count whitelist: a txt file containing IP addresses which may not decrement remaining views counter.
When using the bin, it is annoying to burn views because of the discord preview system (see #91).
That's why I implemented a list of whitelisted IP addresses, containing only Discord bot IPs for the moment.
Because it may contain more IPs in the future, I implemented a basic txt parser, allowing to add comments starting with #.
I also added a unit test with it, because I don't want it to be broken.
Please note that this list is not official and is subject to changes.
It is therefore not fully reliable, but this is largely better than matching on the user-agent, which is something not reliable at all.
Maybe we can combine both technique: like logging the user-agents containing Discordbot/2.0;, and counting views on whitelisted IPs that do not contain this in their user-agent.
That's an idea for later, but for now, I don't think this is useful and therefore, we can make use of this new system, for other things later maybe.

Je garde le test unitaire, il ne vérifie pas l'ouverture du fichier mais que le "parser" ignore bien les commentaires dans l'output.
Avant de squash merge cette PR, il faudra bien entendu détailler cette nouvelle fonctionnalité dans le README

Tâches restantes à faire avant de merge

[ ] Détailler cette nouvelle fonctionnalité (ainsi que la variable d'environnement associée : RTDBIN_WHITELIST) dans le README
[ ] Réécrire le message de commit puisqu'il s'agit désormais d'une feature plus générique que simplement vérifier si la requête vient du bot discord de preview


Getting Internal Server Error

Hi ,
thanks for the wonderful implementation on Azure B2C.
I am actually getting the below error when I try to click on on Sigin though I have updated the policy and other b2c related details:

Best Regards
Rohit

x2


interfaces: put an end to /var/run/booting side effect

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
From ancient times on /var/run/booting file flag was used to indicate a special code path during interface configuration that attempts to serialise code and shrink reload hooks. Over the years, however, nobody really thought this through and more and more code was added that didn't match the original design principles making up the half-working/half-irrelevant implementation.
To my surprise the amount of reliance on this flag has shrunken considerably in the past couple of years (for comparison it used to be 121 lines of code in OPNsense 15.7) and we are almost at the point of removing it completely in part thanks to #5540 proving that boot is not much different than subsequent interface configuration.
To Reproduce
N/A
Expected behavior
Expecting boot to work as normal device operation would work.
Describe alternatives you considered
N/A
Screenshots
N/A
Relevant log files
% git grep var.run.booting
src/etc/inc/interfaces.inc:        if (!file_exists("/var/run/booting")) {
src/etc/inc/interfaces.inc:        if (!file_exists("/var/run/booting")) {
src/etc/rc:touch /var/run/booting
src/etc/rc:rm /var/run/booting
src/etc/rc.bootup: * because these events are blocked by /var/run/booting
src/etc/rc.filter_configure:if (file_exists('/var/run/booting')) {
src/etc/rc.filter_synchronize:if (file_exists('/var/run/booting')) {
src/etc/rc.linkup:if (file_exists('/var/run/booting')) {
src/etc/rc.newwanip:if (file_exists('/var/run/booting')) {
src/etc/rc.newwanipv6:if (file_exists('/var/run/booting')) {

Additional context
N/A
Environment
Any version.

The ARP boot speedup is the only one that is still missing and this can't really be solved in a nice way at all. Need to think about it more.
The rc-based lines of code will be the subject of later work, maybe through some sort of "lock" that can be detected for when the rc bootup ends prematurely to not leave /var/run/booting in the system which makes it act weird.


#14640 Support lowercase yyyy in to_char

Added lowercase 'yyyy' to Token enum, added lowercase 'yyyy' case to getElement, and added four test cases for supporting lowercase 'yyyy' in to_char tests. These changes support issue https://github.com/crate/crate/issues/14640 (Support lowercase yyyy in to_char).

Can one of the admins verify this patch?

ok to test

Thx again for this contribution @rebdiaz !
I'd like to kindly ask you for any next contributions that you create a branch in your fork, and not use master, thx!


haskellPackages.streamly: fix darwin override

fixes
error: querying available packages failed
caused by: nix-env failed with error: nix-env failed with exit code 1:
error: attribute 'streamly_0_8_1_1' missing

       at /nix/store/lw6gp8rrhd7lpi81dk9wr1l09a7za523-source/pkgs/development/haskell-modules/configuration-darwin.nix:259:6:

          258|     ] ++ (drv.libraryFrameworkDepends or []);
          259|   }) super.streamly_0_8_1_1;
             |      ^
          260|

https://github.com/Mic92/nix-index-database/runs/6244309208?check_suite_focus=true
PR #160733 didn't catch this it seems.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg build streamly streamly_0_8_2


ROX-20399: Add mutable feature flag for policy criteria modal

Description
Pre-work for ROX-19032, "Policy Criteria, change from drag-and-drop"
This flag will allow for testing this feature on release builds.
It will also allow us to turn it off and go back to the old drag and drop criteria if needed.
Checklist

[ ] Investigated and inspected CI test results

Testing Performed
Here I tell how I validated my change
Because this change only adds the feature flag, I plan to deploy the PR build image, and point a UI at it.
Manual tests:

With flag off by default and no environmental variable set, observe the response from the /featureflags API call and see that this flag is false.
With flag off by default but an environmental variable setting it to true, observe the response from the /featureflags API call and see that this flag is true.

Response with env off

Response with env ON

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/test ci/prow/ocp-4-10-ui-e2e-tests

/test ocp-4-13-ui-e2e-tests

/test ocp-4-13-ebpf-qa-e2e-tests

/test ocp-4-10-ui-e2e-tests

As a separate pull request, can you add conditional skip in policyWizardStep3.test.js file, and then plan to add an alternative test file with the opposite conditional skip.


PageTransition: Clicking on another link while animating will report an error

Environment

Operating System: Linux
Node Version:     v16.20.0
Nuxt Version:     3.6.2
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      devtools, app
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-z3ajsx?file=pages%2Ffoo%2Findex.vue,pages%2Fbar%2Findex.vue,nuxt.config.ts,app.vue
Describe the bug
When we turn on page transition, if we click on another link in the middle of the transition, we get an error and the page doesn't show anything.
Additional context
No response
Logs
chunk-VWWL2I6E.js:9134  Uncaught DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
    at insert (http://localhost:3001/_nuxt/node_modules/.cache/vite/client/deps/chunk-VWWL2I6E.js?v=67f0dc20:9134:12)
    at move (http://localhost:3001/_nuxt/node_modules/.cache/vite/client/deps/chunk-VWWL2I6E.js?v=67f0dc20:7547:9)
    at move (http://localhost:3001/_nuxt/node_modules/.cache/vite/client/deps/chunk-VWWL2I6E.js?v=67f0dc20:7520:7)
    at move (http://localhost:3001/_nuxt/node_modules/.cache/vite/client/deps/chunk-VWWL2I6E.js?v=67f0dc20:7520:7)
    at activeBranch.transition.afterLeave (http://localhost:3001/_nuxt/node_modules/.cache/vite/client/deps/chunk-VWWL2I6E.js?v=67f0dc20:2779:15)
    at performRemove (http://localhost:3001/_nuxt/node_modules/.cache/vite/client/deps/chunk-VWWL2I6E.js?v=67f0dc20:7657:20)
    at el._leaveCb (http://localhost:3001/_nuxt/node_modules/.cache/vite/client/deps/chunk-VWWL2I6E.js?v=67f0dc20:3587:9)
    at finishLeave (http://localhost:3001/_nuxt/node_modules/.cache/vite/client/deps/chunk-VWWL2I6E.js?v=67f0dc20:9847:13)
    at resolve2 (http://localhost:3001/_nuxt/node_modules/.cache/vite/client/deps/chunk-VWWL2I6E.js?v=67f0dc20:9878:30)
    at whenTransitionEnds (http://localhost:3001/_nuxt/node_modules/.cache/vite/client/deps/chunk-VWWL2I6E.js?v=67f0dc20:9957:12)

This is an upstream Vue issue. We're tracking it in Nuxt in https://github.com/nuxt/nuxt/issues/13350.


Add class to page content to unify top margin

Previously pages would individually set this margin but some didn't so content would stick to the header without any space. Resolve this by adding a new class that is added on all pages. The only place where we remove this margin again is on the pages with menu or wrapper in the header.
Before:

After:

it's a shame to have to change so many files. Is there really no way to use CSS selectors to do this?

Not really, the pages use various classes for the root content element which makes them hard to consistently target for things like this.

I do believe it's possible with CSS selectors but I also think such a class is generally useful to have and might come in handy for the future.

🚀


Websocket console support

Initial support for websocket based console. A helper script for testing can be found in net-tools https://github.com/zephyrproject-rtos/net-tools/pull/73
This PR was created in order to test and experiment with http-server/websocket support.

Just FYI at this point cc: @rlubos, @cfriedt

wouldn't it make sense to have a separate sample sample for this feature?

I was thinking about that, and in 1.13 we had a separate app for it. The issue with it is that the app then does nothing useful because there is nothing "else" in the app. That is why I placed the support in one of our already existing app. I considered HTTP server sample app, but then did it for echo-server so that we can test the code even if there is no other HTTP server users in the application. I had hoped we could make this console support a library so that user could enable it by a Kconfig option but that is not easy because of TLS support which needs to be enabled by application.

This still needs TLS support enabled and tested, I will do it next.
If you want to test the current functionality you can do this:

Enable zeth, by executing cd tools/net-tools; ./net-setup.sh
Compile the echo-server sample

west build -p -b native_sim -d ~/zephyrproject/build/ws-console ~/zephyrproject/zephyr/samples/net/sockets/echo_server/ -- \
-DCONFIG_NATIVE_UART_0_ON_STDINOUT=n \
-DCONFIG_LOG_BACKEND_UART=y \
-DCONFIG_SHELL_LOG_BACKEND=n \
-DCONFIG_NATIVE_UART_AUTOATTACH_DEFAULT_CMD="\"gnome-terminal -- screen %s\"" \
-DCONFIG_OBJ_CORE=y -DCONFIG_NET_SOCKETS_OBJ_CORE=y \
-DCONFIG_NET_SHELL=y -DCONFIG_NET_LOG=y \
-DCONFIG_NET_SOCKETS_LOG_LEVEL_DBG=n \
-DCONFIG_NET_HTTP_SERVER_LOG_LEVEL_DBG=n \
-DCONFIG_NET_WEBSOCKET_LOG_LEVEL_DBG=n \
-DCONFIG_SHELL_WEBSOCKET_INIT_LOG_LEVEL_DBG=n \
-DOVERLAY_CONFIG="overlay-ws-console.conf" \
-DCONFIG_SHELL_WEBSOCKET_BACKEND_COUNT=2

if [ $? -eq 0 ]; then
   ~/zephyrproject/build/ws-console/zephyr/zephyr.exe -attach_uart
fi

And then point your browser to http://<IP_ADDRESS>/console

Added actual console support that uses the websocket shell transport for console output. I was not really able to test this. I am seeing that the websocket console driver init is called but I am not seeing the output function to be called. Any help what options to set/unset in Kconfig would be appreciated.

I'll take a look today.

How can I resolve console access authorization?

Console access should be protected from unauthorized access.
How do you propose to solve this?

That is easy to answer, as this is just a demo I do not plan to provide anything for this :see_no_evil:
Currently one needs to create an application for this with http-server enabled. For access control, something would be needed to be created in the http server side.
Lets figure out how to solve this if I manage to finish this.

Console access should be protected from unauthorized access.
How do you propose to solve this?
That is easy to answer, as this is just a demo I do not plan to provide anything for this 🙈 Currently one needs to create an application for this with http-server enabled.
A complete demo will definitely be of greater value to everyone. :-)

For access control, something would be needed to be created in the http server side. Lets figure out how to solve this if I manage to finish this.
How about basing authorization on a password that is stored in the settings subsystem?
Basic authorization in HTTP should be enough.

I'm not entirely convinced that password-based security is needed (or very useful) here. There are certainly many other samples in Zephyr that enable console access with zero "protection" amd even less of a hurdle to jump through (e.g. a USB port is sufficient).
My 2¢ - we should (eventually) have a more fully featured sample for the web server where an SSL key is generated after the first power-on, and the first user to visit a page is required to create the admin password.
That also begs the question, about how / where the password is stored. Is it encrypted? Is the encryption key stored in a secure location, etc.
Personally, I think there is room for simple samples (used to convey a key subset of concepts) and more "production ready" samples with security in mind.

Personally, I think there is room for simple samples (used to convey a key subset of concepts) and more "production ready" samples with security in mind.

Yes, this :)
Related: https://github.com/zephyrproject-rtos/zephyr/issues/67021

Changed according to comments
Rebased to latest upstream

This now supports also logging output. So I ditched the console driver and implemented websocket logging backend. Works fine now. The "console" output is also seen in websocket console together with shell output.
To try this with native-sim, you can do this:
west build -p -b native_sim -d ../build/ws-console samples/net/sockets/echo_server/ -- \
-DCONFIG_NATIVE_UART_AUTOATTACH_DEFAULT_CMD="\"gnome-terminal -- screen %s\""  \
-DCONFIG_NET_SHELL=y -DCONFIG_NET_LOG=y -DOVERLAY_CONFIG="overlay-ws-console.conf"

and then connect to the console using your host browser http://<IP_ADDRESS>

I'm ready to approve, but could give it a spin if needed.

It would indeed be great if someone else tries this too. The web page is ugly as hell, but hey, I am not a web designer so this is what I could do :sunglasses:  Patches are certainly welcome to make the console page look nice.

Is this just about mergeable?
Maybe we should just get it in - the html / CSS can always be beautified later.

This should be ready to go in. The web page is usable but would need some TLC in the future. I will rebase this against latest upstream to make sure this still compiles ok.


Re-run last Runnable

Hello,
First thing I want to say, very nice plugin! It unifies the whole dev experience.
It would be cool if there were a way to re-run the last ran Runnable (and maybe debuggable). It would be helpful when running tests. Is there a way to do this already (baked in)?
I guess I could pipe in rt.runnables.runnables() into telescope myself and save the choice into a var.
Thanks!
Edit:
Managed to patch up something ugly to do this:
    local rt = require('rust-tools')

    local last_runnable = nil

    local executor = require("rust-tools/executors").termopen;
    local execute_command = executor.execute_command;
    executor.execute_command = function (command, args, cwd)
      last_runnable = {
        command = command,
        args = args,
        cwd = cwd,
      }
      return execute_command(command, args, cwd)
    end

    local run_last = function (...)
      if last_runnable == nil then
        rt.runnables.runnables(...)
      else
        executor.execute_command(
          last_runnable.command,
          last_runnable.args,
          last_runnable.cwd
        )
      end
    end

and on_attach:
        on_attach = function(client, bufnr)
          -- ...
          vim.keymap.set('n', '<leader>cd', rt.debuggables.debuggables, { buffer = bufnr })
          vim.keymap.set('n', '<leader>cr', rt.runnables.runnables, { buffer = bufnr })
          vim.keymap.set('n', '<leader>cR', run_last, { buffer = bufnr })
         -- ...
        end

Work has been made on #252


Setting crontab for another user

I was wondering if we can have an option to tell capistrano to set the crontab entry for another user.
I want to set a particular crontab entry to be run as apache user, but the deployment user is different and has sudo privileges.
Setting :user option did not set the crontab of apache user.
every 1.day do
  rake "my_task", :user => "apache"
end

You can't do this per-task, but you can globally with the command: whenever --user apache

Thanks Javan. set :whenever_command, "sudo bundle exec whenever --user apache" worked.

Cool, you're welcome.


Refactor using ts-pattern

Replace switch stmt with ts-pattern (when possible because generators may be problematic sometimes).

Hi @fraxken
Should the codebase be migrated to TypeScript in first place to be allow to use ts-pattern ?
Or is this a AIO issue ?


fix EndpointId logWarning

Describe what this PR does / why we need it

spring cloud alibaba 2.2.3
spring boot 2.3.4
When the service starts, the above waring prompt will be thrown。
This is because the name contains illegal characters (-) when defining the name
Does this pull request fix one issue?
NO
Describe how you did it
The modified name does not contain illegal characters，
Don't use camel case naming,because the official style
Describe how to verify it
Only need to output log at startup
Special notes for reviews

Thanks for your suggestion.
The pattern of endpoint is different in each Spring Boot version.
So i think it is no need to change the endpoint id 😄

spring-cloud-common   has been fixed this problem  ，this problem has been fixed, it is a BUG from Hoxton.M1
https://github.com/spring-cloud/spring-cloud-commons/issues/458
https://github.com/spring-cloud/spring-cloud-commons/commit/333779070f5b8665b6f355caebf7c7390dc2e232#diff-fb1ecc6a8824d66c496ca03ad40426cc5f9cc0e9cc04f308027a82eb7b98bff4

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.1-Release-Notes#endpoint-id-names
If you have developed your own actuator @Endpoint beans you should ensure that they following the tighter naming rules introduced in Spring Boot 2.1. Specifically, IDs should be alpha-numeric only and must start with a letter (see the EndpointId class documentation for full details).

If you use - or . characters Spring Boot 2.1 will log a warning and ask you to migrate to the correct format.

spring-cloud-common has been fixed this problem , it is a BUG from Hoxton.M1
spring-cloud/spring-cloud-commons#458
spring-cloud/spring-cloud-commons@3337790#diff-fb1ecc6a8824d66c496ca03ad40426cc5f9cc0e9cc04f308027a82eb7b98bff4
@fangjian0423

Thanks for your remind.


correcting sphinx format in general/logging.rst

Continuing text must be aligned after the bullet and whitespace.

Better description & good to see the securely signed commit :)

I set the GPG key yesterday. :-)

commit -s -m '...'

@mixinix Yes, I do a "commit" like that

Is there any different with -s and -S ?

Make sure you will be seeing
Signed-off-by: yourname <yourmail>

when you commit.

@mixinix "commit -s " adds the "signed off by" message. It can be spoofed, eg  I can signoff as "mixinix". OhOh.
"commit -S" requires that a GPG key be setup for your account, and it binds the commit to your account ... not so easily spoofed :) This is the one we are looking for.
See https://bcit-ci.github.io/CodeIgniter4/contributing/signing.html


Better Solution for Position:fixed Test

There is a better Solution for the Position:fixed testing here:
https://github.com/dimsemenov/Magnific-Popup/blob/4063d85fe0a80f83102e5dca16906f59e67a7e04/dist/jquery.magnific-popup.js#L134
This guy is creating a Modernizr Test. But the same should also work for you without the Modernizr part.
https://gist.github.com/PhilippSoehnlein/1336369
Greetings
Florian

have you see this? https://github.com/filamentgroup/fixed-fixed
apart from devices it knows specifically work/dont, it does a fixed test by seeting what happens when the user actually scrolls. if the div hasn't moved it then knows it must be fixed and adds a "fixed-supported" class to the body. seems like quite a good solution


Is there any equivlent to text_generation special tokens in Hugginface-hub InterfaceClient

In text_generation, while using the generate_stream method, there is an option to separate special tokens from the response.
Example:
async for response in self.client.generate_stream(prompt=input_prompt, max_new_tokens=max_new_tokens):
    if not response.token.special:
        text_response += response.token.text

Is there any alternative to this in the InferenceClient.text_generation(prompt="Sample Prompt", stream=True) method?
If not, are there any plans to implement its equivalent for handling special tokens in InferenceClient.text_generation?

Hi @hariv0 , yes this is possible. You must pass details=True to get a iterable of TextGenerationStreamOutput items:
from huggingface_hub import InferenceClient

client = InferenceClient()

text_response = ""
for response in client.text_generation(prompt="The capital of France is", max_new_tokens=10, stream=True, details=True):
    if not response.token.special:
        text_response += response.token.text

print(text_response)
# a city that is full of life, culture,

Hope this solves your problem :)

@Wauplin Thanks for the reply 😄😄


shell: Use .profile unless .bash_profile exists

WIP

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Ubuntu uses ~/.profile by default, and not ~/.bash_profile. Creating a ~/.bash_profile from scratch disables any configuration that the user has in ~/.profile, including the system defaults, which can lead to unexpected behaviour.

I have had a real-world bug report where the user already had ~/.profile, and Homebrew (on Linux) suggested creating ~/.bash_profile, and that broke their system, and they were confused.

Of the top twenty most popular Linux distributions, 13 are Ubuntu, 1 is Linux Mint based on Ubuntu, 1 is Debian, 4 are Amazon Linux, and 1 is Pop! OS. Of these, 15 use ~/.profile (Debian), 4 use ~/.bash_profile (Amazon). I have no idea what Pop! OS uses.

somehow, I am under impression that ~/.bash_profile is favored over ~/.profile. But if it does broke the linux side, I am OK with the change.

Missing references to .bash_profile in docs/Gems,-Eggs-and-Perl-Modules.md, docs/Shell-Completion.md, Library/Homebrew/manpages/brew-cask.1.md

Fixed. Thanks, Mike.


raise ValueError(f"Expected {name} for bbox {bbox} to be in the range [0.0, 1.0], got {value}.") ValueError: Expected x_min for bbox (tensor(1.0102), tensor(0.5781), tensor(1.), tensor(0.7539), tensor(4)) to be in the range [0.0, 1.0], got 1.010156273841858.

raise ValueError(f"Expected {name} for bbox {bbox} to be in the range [0.0, 1.0], got {value}.")
ValueError: Expected x_min for bbox (tensor(1.0102), tensor(0.5781), tensor(1.), tensor(0.7539), tensor(4)) to be in the range [0.0, 1.0], got 1.010156273841858.

If someone encounters this error, analyze all bounding box coordinates programmatically. The error may be the bounding box coordinates are not within the bounds of the provided image.


Touch skipped files and handle them idempotantly on reruns

Should have skipped files represented by empty files to make it easy to see what was skipped. But should always retry and delete the skipped file if it is found on retry.

implemented in 4046fad


New sample script: Check all users in a tenant for haveibeenpwned breaches

Depends on implementation of #2476

Docs

Author
N/a

Original Post
Inspired by https://twitter.com/wesleyneelen/status/1381880141970866176?s=20

Description
Quickly get an overview of all breached accounts in your tenant

Keywords
Azure Active Directory Microsoft 365

Duplicate of #2957


fix(StructuredList): title as defaultProps (il8n)

Related to #107

:+1:

Bluemix toolchain: Delivery Pipeline deployed carbon-components-react to Bluemix Design System, including commit 874d765399cad67f9b89fbe4041ad0c107c31a3c


Some problems encountered while running the GPU version

Dear author,
I am a graduate student from suzhou, China. Thank you for your contributions.I was able to successfully implement your work on the CPU, but there was a problem running on the GPU that I couldn't solve.Based on the error, I guess there is something wrong with the versions of tensorflow and keras.
Could you tell me What versions of tensorflow/tensorflow-gpu/keras/cuda/cudnn/ is supported/expected? Sincerely looking forward to hearing from you soon.
My settings :python36,tensorflow=1.13.1,tensorflow-gpu=1.4.0,cuda=10.0,cudnn=7.4.1,keras=2.3.1, NVIDIA F=GeFroce RTX 2080 Ti，but it is faild.
ERRORS:

Try to uninstall tensorflow 1.13.1 and tensorflow-gpu, and then reinstall tensorflow-gpu 1.4. Not sure whether the existence of a higher version of "tensorflow" causes the problem.

Thank you very much for your reply. I finally upgraded the tensorflow-gpu from 1.4.0 to 1.13.0, and finally succeeded.I hope this method can help others with the same problem.


Need Step by Step examples of Client and Server creation.

Create a step by step example of creating a gRPC server in LabVIEW.  We should match the step by step examples used in other languages:
Quick start | Python | gRPC
We should use the same greeter proto file so that our LabVIEW server can easily be called by the clients in other languages in their tutorials.

Docs have been updated.


io_ops.py docstrings for serialize_tensor method generates different output on s390x architecture

Click to expand!
Issue Type
Bug
Source
source
Tensorflow Version
tf 2.9.1
Custom Code
No
OS Platform and Distribution
Ubuntu 20.04
Mobile device
No response
Python version
3.8.10
Bazel version
5.1.1
GCC/Compiler version
7.5.0
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Currently [//tensorflow/tools/docs:tf_doctest](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/docs/tf_doctest.py) triggers `doctests` in [io_ops.py](https://github.com/tensorflow/tensorflow/blob/21830d8dc775334fa86b2eb1227ff9a96b5e5c8b/tensorflow/python/ops/io_ops.py#L176) which fails on `s390x`
arch due to values returned during `serialize_tensor` ops. This is primarily due to endianess of the underlying system. I think the current behavior of both `ParseTensor` and `SerializeTensor` ops are correct on `s390x` but the docstrings only account for little-endian results.

x86:
>>> import tensorflow as tf
>>> t = tf.constant(1)
2022-07-28 10:43:31.641256: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  SSE3 SSE4.1 SSE4.2 AVX AVX2 AVX512F FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
>>> tf.io.serialize_tensor(t)
<tf.Tensor: shape=(), dtype=string, numpy=b'\x08\x03\x12\x00"\x04\x01\x00\x00\x00'>

s390x:
>>> import tensorflow as tf
>>> t = tf.constant(1)
>>> tf.io.serialize_tensor(t)
<tf.Tensor: shape=(), dtype=string, numpy=b'\x08\x03\x12\x00"\x04\x00\x00\x00\x01'>

Should a little blurb be added to serialize_tensor def to indicate that example docstring results will depend on system architecture on which testcase is executed?
Thanks!

### Standalone code to reproduce the issue

```shell
x86:
>>> import tensorflow as tf
>>> t = tf.constant(1)
2022-07-28 10:43:31.641256: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  SSE3 SSE4.1 SSE4.2 AVX AVX2 AVX512F FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
>>> tf.io.serialize_tensor(t)
<tf.Tensor: shape=(), dtype=string, numpy=b'\x08\x03\x12\x00"\x04\x01\x00\x00\x00'>

s390x:
>>> import tensorflow as tf
>>> t = tf.constant(1)
>>> tf.io.serialize_tensor(t)
<tf.Tensor: shape=(), dtype=string, numpy=b'\x08\x03\x12\x00"\x04\x00\x00\x00\x01'>

### Relevant log output

```shell
Note that the numpy results are endian specific:
on x86:

<tf.Tensor: shape=(), dtype=string, numpy=b'\x08\x03\x12\x00"\x04\x01\x00\x00\x00'>

on s390x:
<tf.Tensor: shape=(), dtype=string, numpy=b'\x08\x03\x12\x00"\x04\x00\x00\x00\x01'>

</details>

@rposts,
I was able to execute the provided code without any issues and the output also as expected. Kindly find the gist of it here.

Hi @tilakrayal - behavior is diffened on s390x arch (big-endian) where bytes are reversed - see output from this arch (notice the presence of x01 at the end vs x00 on x86 arch:
<tf.Tensor: shape=(), dtype=string, numpy=b'\x08\x03\x12\x00"\x04\x00\x00\x00\x01'>

Hi @gowthamkpr - any insights appreciated - tx!

Closing - no response.


About require('debug')('MyFile');

Hi, thank you for this loader!
Using the webpack's IgnorePlugin, debug’s inits like:
var debug = require('debug')('MyFile’);

cause a Cannot find module “debug” webpack error.
I solved with the NormalModuleReplacementPlugin, however I wonder if there's a better way for it. Thanks!
new webpack.NormalModuleReplacementPlugin(/debug/, process.cwd() + '/emptyDebug.js'),

Hey @gpbl, you're right.
I started work in a branch on trying to use the loader to potentially strip out the debug declaration as well, but that is turning out to be more difficult than I thought. I haven't had time but I want to play around with recast to see if that would help in finding and stripping the declarations.

For now tough, feel free to do a docs PR for the README.

Indeed recast looks like the right way :+1:


Disable flaky PSR tests

Signed-off-by: Krasi Georgiev<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 355617075

0 of 0   changed or added relevant lines in 0 files are covered.
12 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.3%) to 36.793%

Files with Coverage Reduction
New Missed Lines
%

pkg/tracker/index.go
6
80.7%

pkg/tracker/psrs.go
6
87.59%

Totals

Change from base Build 354512602:
-0.3%

Covered Lines:
1606

Relevant Lines:
4365

💛  - Coveralls


Add a 'Dead' capture type

This will allow creating pcap save files without needing to capture from an actual interface.
It was a pretty straightforward implementation but there were two things I wasn't sure how you wanted to handle.
I named the function to create them "dead" because I couldn't think of anything better since it's not really "from_" anything.
I wanted to have a sane default for the snaplen parameter but I didn't want to end up with a bunch of functions to create the struct, so I defaulted it to 65535.  I figured if anyone wants to change it they can use snaplen().
Let me know if you want me to change any of this! I think this will work for me as I was able to successfully create a new capture file with the code.  I'm not sure I'll get my "write directly to a Vec" because of how pcap writes the packets but I can always throw it in a temp file.

Excellent. The only thing I would like to see is a test added, since this shouldn't (hopefully) require privileges to execute, since it's not attaching to a network interface.

Ah, sure. I'll work on adding that.

It looks like the Ubuntu that travis is running (12.04LTS) has a super-old version of libpcap on it (1.1.1) that doesn't have the precision version of pcap_open_dead(). Which version of libpcap are you targeting?  Should I just remove that function?

I would just remove the function, yeah. Is there not another way to configure the precision manually anyway?

Not that I saw in the header file of the 1.1 branch.  I just removed it completely for now.

Great job! I believe this interface is available on Windows so we hopefully won't have any trouble there.

This is now included in the latest version published on crates.io.


getAdjustedHitStat return max for all stats if ATTACKS_CANT_MISS

Move ATTACKS_CANT_MISS check before getHitStatType switch so that it applies for any hit stat (muscle, mysticality, or moxie)

I'm approving because it does what it says it will do.  But I am not merging since I just don't know that it is the right thing.  So someone who is more certain than I am that the modifier applies to non-Muscle attacks can merge.

Let's merge it and see if anyone complains :)


boot/zephyr: Improve badly written comment

The comment on why first parameter to bootutil_img_validate is allowed
to be NULL, in boot_image_validation of single_loader.c, has been
rewritten.
Signed-off-by: Dominik Ermel<EMAIL_ADDRESS>

@nvlsianpu @utzig Sorry for bothering you guys, can you look at this?


Does not detect file shebangs with extra whitespace

File-format's shebang based checks (e.g. #!/usr/bin/env bash) do not match against shebangs with extra whitespace. For example the following is a valid shebang #!  /usr/bin/env     bash but will not match as file-format looks only for static strings.
Any number of spaces or tabs may be present after the #! and between each argument
One solution could be to do what the libmagic library does, use a whitespace flag that treats any whitespace in a pattern as 0 or more whitespaces.

Hello and thank you for the issue.
I already knew about this problem, but given the way file-format is constructed, it implies that this type of format should no longer be handled by signature, but rather with text parsing.
I'll think about what I can do for the next release.

For the time being, parsing text requires a bit of work within file-format, as the crate isn't really built for it. It's something I've always had in the back of my mind, but for the moment I'm going to keep it simple.
I'll see if I get around to it in the future, as I'll have to change the way almost all text-based file formats are handled to improve it.
Thanks again for the suggestion and don't hesitate to make others!


Run e2e inline

Run end-to-end tests inline for connector builds
Pros:

Test reports for e2e tests run on PRs are associated with the PR build
test reports for connector master builds are associated with the master build

Cons:

I can't think of any

Is this worth putting into the jenkins library so it is easier to reuse?

@whpearson I'd rather prove it works reliably before abstracting it

thanks!


feat(ci): add code coverage report

Closes https://github.com/eigerco/beerus/issues/684
Closes https://github.com/eigerco/beerus/pull/719

Both tarpaulin and llvm-cov turn out to be to heavy to run in a shared GitHub Actions worker - it fails with exit code 143. At this time I don't think it makes a lot of sense to migrate to a dedicated worker just for the sake of test coverage, as it can run locally.
For local run I personally prefer tarpaulin as it provides better branch coverage and generates a single-file HTML report:
export STARKNET_MAINNET_URL: https://starknet-mainnet.g.alchemy.com/starknet/version/rpc/v0_7/${ALCHEMY_KEY}
export STARKNET_SEPOLIA_URL: https://starknet-sepolia.g.alchemy.com/starknet/version/rpc/v0_7/${ALCHEMY_KEY}
BEERUS_TEST_RUN=1 cargo tarpaulin --out html
## Result: tarpaulin-report.html

Closing all relevant issues and PRs for now.


refactor: merge finalizeSize()s, remove now unused code

Merging the two reduces bugs by having common code do both.

This appears to have been broken by https://github.com/D-Programming-Language/dmd/pull/5014

boy the former code was awkward

Auto-merge toggled on


DNXC Banquest logo

Both a favicon and a full sized DNXC banner would be nice. That way the dnxc account can have a profile picture, our website can have an favicon on the tab, and perhaps we can replace the "DEL NORTE BANQUEST" with a nicer looking banner.

No banner was made, but I did make a favicon and discord icon.

The discord icon is supposed to be more solid and splashy while the favicon is meant to be simple and easy to look at but with a splash of personality.

Ended up ditching the color scheme because it doesn't look very good. Rounded the shield out and implemented new favicon in commit 3eb876b.
https://github.com/dnxc/dnxc.github.io/blob/master/img/favicon.png

Also here's the banquest discord logo. A little more detail added since the discord icon is bigger


Implement index and time index updates on Table Accessor

Once semantic tag updates are allowed, we want to allow both set_index and @ setter's that facilitate changing the index and resetting it to None
The DataFrame will change when an index is set so we should consider if we want this to happen in place or not.

Should stay open until time index updates are implemented!


Is this still recommended?

Is it advisable to use custom master pages considering that SPO needs to push out updates every now and then? If not, shouldn't the README.md contain a note about this?

Wow, just realised that this repo is a megarepo containing all samples. Well, I'm talking about PnP/Samples/Branding.AlternateCSSAndSiteLogo/Branding.AlternateCSSAndSiteLogoWeb .

I see that the code skips over site collection groups.  I need to create a group that has IsSiteCollectionGroup set to true.  Is this even possible with CSOM?

Hello,
You are correct, custom masterpages are no longer the preferred method - and we are in the process of reviewing all samples as things change. We will add this one to the list for review, thanks.
Cheers,
Patrick


Supply-chain-app - Build failed

Describe the bug
Supply chain app is not starting and failing during the build process.
To Reproduce
Clone the latest cacti repo. commit ([66f65a8]
Run below command s:

npm run enable-corepack
npm run configure
yarn start:example-supply-chain

After the final command, it gives the build error
Expected behavior
Supply chain app should start and load the front-end in the browser
Logs/Stack traces
Getting below errors :
lerna-lite ERR! yarn run build:dev:frontend exited 1 in '@hyperledger/cactus-example-supply-chain-frontend'
lerna-lite ERR! yarn run build:dev:frontend stderr:
../../packages/cactus-api-client/dist/cactus-api-client.web.umd.js - Warning: Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map: 'webpack://cactus-api-client/cactus-common/index.ts' URL is not supported
../../packages/cactus-api-client/dist/cactus-api-client.web.umd.js - Warning: Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map: 'webpack://cactus-api-client/cactus-common/key-encoder.ts' URL is not supported
../../packages/cactus-api-client/dist/cactus-api-client.web.umd.js - Warning: Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map: 'webpack://cactus-api-client/cactus-common/webpack/after-startup' URL is not supported
Screenshots

Operating system name, version, build:
Linux 5.15.0-88-generic x86_64
NAME="Ubuntu"
VERSION="20.04.5 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.5 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
Hyperledger Cactus release version or commit (git rev-parse --short HEAD):
https://github.com/hyperledger/cacti/commit/66f65a80e60c1c8142bdc9108c5bf6bca9069876
Hyperledger Cactus Plugins/Connectors Used

DLT connectors used : Fabric, Quorum, Besu for supply-chain-app

Additional context
@petermetz
@VRamakrishna

@ak1334 Sorry, there is an on-going bug-fix [1] for the supply chain example right now.
With that said, it doesn't look the like errors you are showing on the screenshots are the real errors. Could you please save the full log output to a text file and attach that? With that I could at least confirm if you are having the same issue as #2721 or a different one.
[1] https://github.com/hyperledger/cacti/issues/2721

Hi @petermetz , sharing the complete error-log file as requested.
error-log.txt

As i have cloned the latest repo., now getting below error, Im not getting the above mentioned error anymore :
error : Unknown Syntax Error: Unsupported option name ("--no-lockfile")

@ak1334 Progress update: I'm in the process of migrating the supply chain app's fabric contract onto Fabric 2.5.x (current LTS) which should implicitly take care of the problems experienced in this issue as well! I'll keep this issue posted, please bear with me!

@ak1334 Sorry for the slow response! The supply chain example should be working now!


Enable avoiding using podman

Summary
Allow using the CreateKindClusters.sh script without  podman, even though podman is installed on the system (for example on linux boxes where you have both docker and podman)

don't care much about this little chance. Overall, IMO this does not really belong into the repository.

/lgtm
/approve

/retest


IA-2454 iaso landing page

Providing a default home page for IASO
Related JIRA tickets : IA-2454
Self proofreading checklist

[x] Did I use eslint and black formatters
[x] Is my code clear enough and well documented
[x] Are my typescript files well typed
[x] New translations have been added or updated if new strings have been introduced in the frontend
[ ] My migrations file are included
[ ] Are there enough tests
[ ] Documentation has been included (for new feature)

Changes

make a view "home_iaso" available while not connected
create a new home domain with a default page to display (using custom logo and App label"
default page displays burger menu or login button if the user is authenticated or not
allow to override home page in the plugin config
redirect to the user home url if the user have one in his profile (only on first load)
add a link to home on the sidebar menu
add infot tooltip on home page input while editing a profile

How to test

make sure your profile doesn't have a home page
visit "http://localhost:8081/" while connected, you should see the home page with the sidebar menu
visit it not connected again, you should see the home page with a login button
eventually change logo and label of the app with ENV variables:

APP_TITLE="Coda 2"
FAVICON_PATH="images/coda/favicon.png"
LOGO_PATH="images/coda/logo.svg"

uncomment line 540 in plugins/polio/js/config.js, revisit "http://localhost:8081/", you should see a single text saying "HOME POLIO"
add "forms/list" has home page in your profile, revisit "http://localhost:8081/", you should not see home page at all and be redirect to the list of forms. Home page should be accessible if you click on the iaso logo in the sidebar menu

Print screen / video

PR update:

Split home into home offline and home online
In order to see Online home you need to set the correct feature flag on the account
By default it will use Iaso Landing page, you can overwrite it in a plugin config using homeOnline
to see Offline page set homeOnline in a plugin config
by default it will display login page if not connected and no offline page
if connected and no account landing is setup page
if connected and no homeUrl is set in a plugin config, it will display forms list as landing
if connected and homeUrl is set in a plugin config, it will display the homeUrl as landing
if connected and homeUrl is set in a plugin config but user sets a custom home url in his profile, it will display the custom home as landing


Add CBB state

Love everything except the inclusion of CDD on the home screen. I think I have a better place for that kind of info - check out the StatsScreen in the latest commit instead.

Merged, but will revert changes to HomeScreen


meson setup error on Windows mingw

HI,
When I run meson setup build ., I got this error:

Executing subproject ppm
subprojects/ppm/meson.build:1:0: ERROR: In subproject ppm: Unknown options: "ppm:arch_tuple, ppm:data_dir"

I found these 2 options in subprojects\packagefiles\ppm\meson_options.txt, but not sure how to fix it.

Which meson version are you using? Also, how did you setup your build environment, is there a way to reproduce?


can you share the pretrained model?

Can share the weight of your pretrained model?

It's been updated.