1.0.4 - missing includes OSX Lion

Compiling ocio-1.0.4 on OSX Lion 10.7.3 using the Command Line Tools from XCode-4.3
and the compiler llvm-gcc-4.2.1.   I have the following include directory available:
/usr/include/c++/4.2.1
/usr/include/c++/4.2.1/backward
/usr/include/c++/4.2.1/bits
/usr/include/c++/4.2.1/debug
/usr/include/c++/4.2.1/ext
/usr/include/c++/4.2.1/tr1

In /usr/include/c++/4.2.1 I have a few files that make couldn't find.
They were included in export/OpenColorIO.h for instance:
#include <exception>
#include <iosfwd>
#include <string>
#include <cstddef>

Here is a gist of the exact error.
Do I need to customize my cmake command with some CPPFLAGS ?
I'm not sure if my dev tools are behaving differently now with the new
versions they just released.
Ok thanks.

Strange.
I can confirm it works on my laptop, which is 10.7.2 and gcc-4.2.1
Maybe 10.7.3 vs 10.7.2 is the issue? I'm also on xcode 4.1.
What command-line are you doing to do the build?  I'm using this (for a
system install).
#!/usr/bin/env tcsh
mkdir -p build
cd build
cmake
-D OCIO_BUILD_TESTS=NO
-D OCIO_BUILD_PYGLUE=YES
-D OCIO_BUILD_APPS=NO
../
make -j2
sudo make install
If you want to install to a local directory, you can skip sudo make
install, and then also specify a CMAKE_INSTALL_PREFIX
-- Jeremy
On Tue, Feb 21, 2012 at 5:48 PM, 2bits <
<EMAIL_ADDRESS>
wrote:

Compiling ocio-1.0.4 on OSX Lion 10.7.3 using the Command Line Tools from
XCode-4.3
and the compiler llvm-gcc-4.2.1.   I have the following include directory
available:
/usr/include/c++/4.2.1
/usr/include/c++/4.2.1/backward
/usr/include/c++/4.2.1/bits
/usr/include/c++/4.2.1/debug
/usr/include/c++/4.2.1/ext
/usr/include/c++/4.2.1/tr1
In /usr/include/c++/4.2.1 I have a few files that make couldn't find.
They were included in export/OpenColorIO.h for instance:
#include
#include
#include
#include
Here is a gist of the exact error.
Do I need to customize my cmake command with some CPPFLAGS ?
I'm not sure if my dev tools are behaving differently now with the new
versions they just released.
Ok thanks.

Reply to this email directly or view it on GitHub:
https://github.com/imageworks/OpenColorIO/issues/224

Also, if you've previously built OCIO in that directory maybe rm the build
dir (with cmake files) and try again?
I'll update to 10.7.3 tonight and see how things go.
-_ Jeremy
On Tue, Feb 21, 2012 at 5:54 PM, Jeremy Selan<EMAIL_ADDRESS>
Strange.
I can confirm it works on my laptop, which is 10.7.2 and gcc-4.2.1
Maybe 10.7.3 vs 10.7.2 is the issue? I'm also on xcode 4.1.
What command-line are you doing to do the build?  I'm using this (for a
system install).
#!/usr/bin/env tcsh
mkdir -p build
cd build
cmake
-D OCIO_BUILD_TESTS=NO
-D OCIO_BUILD_PYGLUE=YES
-D OCIO_BUILD_APPS=NO
../
make -j2
sudo make install
If you want to install to a local directory, you can skip sudo make
install, and then also specify a CMAKE_INSTALL_PREFIX
-- Jeremy
On Tue, Feb 21, 2012 at 5:48 PM, 2bits <
<EMAIL_ADDRESS>
wrote:

Compiling ocio-1.0.4 on OSX Lion 10.7.3 using the Command Line Tools from
XCode-4.3
and the compiler llvm-gcc-4.2.1.   I have the following include directory
available:
/usr/include/c++/4.2.1
/usr/include/c++/4.2.1/backward
/usr/include/c++/4.2.1/bits
/usr/include/c++/4.2.1/debug
/usr/include/c++/4.2.1/ext
/usr/include/c++/4.2.1/tr1
In /usr/include/c++/4.2.1 I have a few files that make couldn't find.
They were included in export/OpenColorIO.h for instance:
#include
#include
#include
#include
Here is a gist of the exact error.
Do I need to customize my cmake command with some CPPFLAGS ?
I'm not sure if my dev tools are behaving differently now with the new
versions they just released.
Ok thanks.

Reply to this email directly or view it on GitHub:
https://github.com/imageworks/OpenColorIO/issues/224

My llvm-gcc is 4.2.1 (build 5658) (LLVM build 2336.9.00) and it came from the 170MB Command Line Tools For XCode-4.3 from Apple's developer website, which is all that is required to build things or so they say.
I fixed my gist.  I pasted in the whole output so you can see my cmake line.

I havent been able to replicate this on 10.7.3.  Perhaps it's related to the xcode version?
Is it possible your cmake isnt configured properly?  The specified includes, such as  should be part of all C++ header installations (as far as I know).
For example, on my OSX box exception appears to be located here: /usr/include/c++/4.2.1   can you confirm?

Good questions.  The cmake config is proven, though CMake has upstream issues, e.g. it finds the right python libs but wrong includes when building your software, if using non-system python.  Other than that we may be on the leading edge.
This could be XCode related if it works with XCode-4.2
Here is a gist of /usr/include/c++/4.2.1

I found it.
It exists nowhere else.

Cool!  Glad you found it.   FYI there is some code in our build system which looks similar, though it shouldnt be used:
share/cmake/iPhone*
(See how they specify IPHONE_SDK_ROOT)
I'll try to update xcode and see if the include issue is fixed.  You're still having that problem, right?

Yes I am still failing with llvm, success with clang.

I've updated to the latest XCode, and am still not able to recreate this.    But looking at your original command-line, how are you able to get cmake to use llvm instead of gcc?
I have to specify
-D CMAKE_CXX_COMPILER=/usr/bin/llvm-gcc
-D CMAKE_C_COMPILER=/usr/bin/llvm-gcc
but it appears you are not.
Also, when I compare your log output with mine, yours has the following text:
-- Detecting CXX compiler ABI info
xcode-select: Error: No Xcode folder is set. Run xcode-select -switch <xcode_folder_path> to set the path to the Xcode folder.
Whereas mine is:
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
This looks suspicious, I'd recommend looking into it

In the past, we had to get the full XCode-4.2 or 4.0.2 on Snow Lep, and we had to add Unix tools in a checkbox during install.  The total install was like 5GB.
Today on Lion, we have two choices:

Get the full XCode-4.3 app from the app store, then add Command Line Tools For XCode (CLT) after install in Preferences -> Downloads.  Total size 2GB.
Or Apple now gives us the option to only download the CLT from the dev site. Total size 170 MB.

The only difference is that with the CLT only, there is no path named /Developer/SDKs/* or /Applications/XCode.app/Developer/* to point the now useless xcodebuild or xcode-select to.  Everything just lives in /usr or /System like it always has been symlinked.
So what happens to a clean install of Lion plus CLT only is that xcode-select -print-path has no path ever set by any installer because there is no full XCode to point it to.  So you get the above error you pointed out to me.  My thing is unset.  And by thing, I mean xcode-select is a shell script that reads /usr/share/xcode-select/xcode_dir_path once a path has been set.  No path means no file means unset means that error you saw means cmake chooses /SDKs/blah which is the leftover cruft if you used to have the dir path set to /Developer I guess.
So I closed it because it's not your fault, it's CMake, and it's me and my tiny CLT.  heh

To answer your question about my environment, I had the same questions also for the Homebrew people.  What they do is set the release type to none, and that propogates CC and CXX and CFLAGS and whatnot from my environment into the build.  If I had left it set to the default which is Release I think, it would have picked up who knows what.
Also Homebrew has a command line flag like this: brew -v install --use-clang opencolorio
or I could tell it to --use-llvm instead.

I see, thanks for the great explanation!  Once it's all in there, I may setup a clean osx partition and try homebrew to see how it all works.

Should I close this?

Yes, I think we've got this one sorted.  The issue would like occur with any new OSX Lion user who has XCode-4.3 + the CLT or just the CLT because their xcode-select -print-path is unset or incorrectly set.  Manually setting it with an argument to cmake has fixed it for me, and the issue is being discussed upstream with cmake.  I am including the workaround in my formula for Homebrew which I will post once we have the last Java lib issue sorted.  Many thanks.


Fix the workaround given for local/dist table joins

Fixes #978

Thanks for merging @jonels-msft :)


How works scripting with parallel testing?

I am interested to canopy 2.0. Can use surely the with parallel testing F# Interactive? Can give simple example of parallel testing with F# Interactive?

I do not have any examples using the parallel testing in interactive.
You should be able to, but only if you are able to run unit tests in parallel in interactive.  canopy 1.x used a global mutable instance of a browser which inhibited having multiple browsers and tests going at the same time.  Two new apis are introduced in 2.0 which fix this.  Running tests in parallel has not been added to the runner, you will need to use a test runner like Expecto or nUnit for that.

I will look into this tonight.  I never use interactive with testing, so I am very rusty.

@kikkoi You can use https://github.com/haf/canopy/blob/parallel/tests/ParallelUsage/Explore.fsx as an example, if you want an fsx example that works. I haven't released a separate nuget with these changes yet though.


$this->id is the incorrect ID

So a problem has recently popped up for me when I have logging to the DB enabled. If I do a ActiveRecord save() and then reference the $id for that record afterwards, it has the wrong id. For instance with the following code:
public function saveStudent($first_name, $last_name, $gender)
{
    $student = new Student();
    $student->first_name = $first_name;
    $student->last_name = $last_name;
    $student->gender = $gender;

    Yii::info("Saving student: {$student->first_name} {$student->last_name}");
    $student->save();

    return $student->id;
}

Uses the following class:
class Student extends \yii\db\ActiveRecord
{

    /* NORMAL CODE HERE */

    public class afterSave($insert, $changedAttributes)
    {
        parent::afterSave($insert, $changedAttributes);

        Class::assignClass($this->id);
    }

}

The ID that is passed into Class::assignClass() is not the ID for the student record, but rather the ID for the record for the log entry that was written to the log table in the DB for the line Yii::info("Saving student: {$student->first_name} {$student->last_name}");. This doesn't always happen, but it is happening and it's very annoying. To be clear, the Student record is being saved into the DB, as I checked to make sure that the record was there. Here is my config for the writing of the logs to the DB.
               [
                'class' => 'yii\log\DbTarget',
                'exportInterval' => 10,
                'levels' => ['error', 'warning', 'info'],
                'logVars' => ['_COOKIE',],
                'categories' => [
                    'sync',
                    'treb',
                    'sync_cleanup',
                    'application'
                ],

I've written the following code into my afterSave() of one of my classes, only to have it happen elsewhere. I don't want to have to write this code all over. Ignore this, the code doesn't work as intended.
public function afterSave($insert, $changedAttributes)
{
    parent::afterSave($insert, $changedAttributes);
    $this->refresh();

    $lastID = $this->db->getLastInsertID();
    if ($lastID != $this->id) {
        Yii::warning("ERROR: Record ID ({$this->id}) is not equal to last inserted ID ($lastID), reassigning");
        $this->id = $lastID;
    }
}

Please note that the $this->refresh() is not fixing the issue.

which version of yii are you using?

2.0.4

This issue happens because insert SQL statement is logged via DbTarget, which performs own insert SQL statement, so when it comes to call of getLastInsertID() it returns last inserted ID for the log table instead of one used in ActiveRecord.
I can't see any way to fix this. You should either don't apply DbTarget for database operations logging or setup exportInterval in the way logs will be written at the application end.
Also note that databases, which uses insert...returning statement, like Postgres or Oracle, are not affected by such behavior.


Raw Generator in LazyCollection::make() is not lazy

Laravel Version: 7.15.0
PHP Version: 7.4.0

Description:
When using Lazy Collections, one can use the following to read a large file without loading it all in memory:
use Illuminate\Support\LazyCollection;

LazyCollection::make(function () {
    $handle = fopen('file.txt', 'r');
    while ($line = fgets($handle)) yield $line;
})->map(...);

However, if you have a raw Generator (the result of calling a Generator function), then the LazyCollection will not handle it lazy anymore. The following will crash on out of memory when the file is too large:
use Illuminate\Support\LazyCollection;

class FileReader
{
    public function read($file)
    {
        $handle = fopen($file, 'r');
        while ($line = fgets($handle)) yield $line;
    }
}

$reader = new FileReader();

LazyCollection::make($reader->read('file.txt'))->map(...);

The solution is to change it to the following:
LazyCollection::make(fn() => yield from $reader->read('file.txt'))->map(...);

It cost me some time to figure out this bug, and it surprised me: I think Laravel can handle this for me?
How it works
LazyCollection::make() calls the constructor, which calls getArrayableItems() from the EnumeratesValues trait.
https://github.com/laravel/framework/blob/a00484aec9fc2f66645c49e40ddc7ef9f13f0ecd/src/Illuminate/Support/LazyCollection.php#L29-39
The generator falls into the case that checks for Traversable, which makes that Laravel calls iterator_to_array() on it. This will run the full generator, and thus in my example load the full file in memory.
https://github.com/laravel/framework/blob/a00484aec9fc2f66645c49e40ddc7ef9f13f0ecd/src/Illuminate/Support/Traits/EnumeratesValues.php#L870-887
A solution could be to change the constructor of LazyCollection to the following:
    public function __construct($source = null)
    {
        if ($source instanceof Closure || $source instanceof self) {
            $this->source = $source;
        } elseif ($source instanceof Generator) {
            $this->source = function () use ($source) {
                yield from $source;
            };
        } elseif (is_null($source)) {
            $this->source = static::empty();
        } else {
            $this->source = $this->getArrayableItems($source);
        }
    }

Heya. This sounds like something more for discussions so I'm moving it there.


[Feature] Limit number of updates shown for users.

What is the problem?
When showing changes logs in the website, there is a possibility that a user might login after a really long time when he will he fed with too many changes making it difficult for the user to go through all the changes.
Your solution
We can limit the number of logs shown to an appropriate count(n). Also, we can't just choose the last n updates as the user might miss some major updates that happened earlier. For this purpose, we can add a field called isMajorUpdate in change_log table, which will be set if we think it's a major update and users should definitely know about it.
So, the condition will be, fetch latest n number of updates along with major ones since he last visited the site. We could also improve to have the final logs match the count(n) by fetching less of minor updates.
Additional context
If feasible, we could make carousal for such updates to have GIFs which explains the usage of that update.

Love this!


Update the database to reflect 1::N relationship between project::dataset

The original data model in the high level architecture modeled the relationship between Projects and Datasets to be N::M. This causes complications with our decision that authentication/authorization should be controlled at a project-level (i.e. if a project is private, then all datasets associated with the project is also private). The database needs to be updated such that the relationship is 1::N, that is, one project may have multiple datasets but each dataset can belong to at most one project.
The ProjectDataset join table will need to be deleted, the relationships for the Project and Dataset will need to be updated, and any tests updated.

Changes to the database UML are out for approval: https://docs.google.com/document/d/1d8tv2Ub5b3E7Il85adOAUcG8P05N6UBZJ3XbhJSRrFs/edit#heading=h.8k9t6sz0fbtc.


Add ci_minimal to nightly docker rebuild

@driazati

Cleared your review @leandron so we could get this merged since ci-minimal's tag isn't up to date with all the other images since it needs to need to get it running in a nightly build

Cleared your review @leandron so we could get this merged since ci-minimal's tag isn't up to date with all the other images since it needs to need to get it running in a nightly build

Sure, thanks for clarifying


How to execute multiple tasks with a single runner ?

Hello,
We use Whenever on a large project with lots of scheduled tasks on different hours. For example at 9am :
every :day, at: '09:00am' do
  runner 'MyClass1.task1'
  runner 'MyClass2.task2'
  ...
  runner 'MyClass10.task10'
end

The problem is that this creates 10 cron tasks at 9am, and lots of processes are spawned simultaneously and uses a lot of RAM.
So instead we would like to run a single cron task with 10 chained tasks.
I thought we could use the following syntax (untested) :
every :day, at: '09:00am' do
  runner 'MyClass1.task1; MyClass2.task2'; ...; MyClass10.task10'
end

But this would make long lines and the code would hardly be readable.
We could also create a Ruby class, say "SchedulerTask" and create a static method , say "SchedulerTask.9am", and then use it the scheduler, but I find this not very elegant.
Is there any good practice to do that ? (I've search the issues,  but couldn't find...)
Thank you for your help :)
Mathieu.

Iv'e ended up doing this :
every :day, at: '09:00am' do
  runner [
    'MyClass1.task1',
    'MyClass2.task2',
    ...
    'MyClass10.task10',
  ].join(';')
end

I don’t think the gem supports that internally. What you suggest works well. You can create a class or rake task that has a sequence of operations to run that would execute sequentially.
Remember that these are cron jobs as well instead of other types of architecture. You can also create your own cron tab command through the gem and chain them by manually setting it as defined in the wiki.


rarefaction analyses and sampling depth

hello
thank you for all these great tools.
would it be possible to generate rarefaction curve to assess sampling depth  (e.g.  by subsampling data without replacement at XXX sequence increments, and determining the number of clusters represented by these sequences as in Galson et al 2016)?
can it be done with the repDiversity function?
any suggestions?
thank you

Hello Antoine,
Thank you for using immunarch. Could you please send a direct link for the Galson et al 2016 article?
Best,
Vasily


union: column named 'TableName' already exists - Workspace Usage Report

The workbook use to work but now comes up with this error:
union: column named 'TableName' already exists
Click to Retry.
Some parts of the workbook are still populating with data but 90% of the work book is broken. Same issue on both the Workspace Usage Report v1.3 and Workspace Usage Report v1.4

Hi, Apologies,  I missed this!  There is a clash with the SQL solution: "  SQL Data Discovery & Classification”.  I'll change the name in the next release to fix this.  As a workaround, edit the JSON to find & replace of 'withsource=TableName' to 'withsource=TableName1'  (or any new name that is unique)


sct_deepseg_sc empty result on data after motion correction

Description
Dear SCT experts,
I found out issue with sct_deepseg_sc function when I run it on our data. We have T2 axial DCM patient data which were measured with interleaved sequence. Unfortunately, some of patients moved during examination, so data are corrupted by slice-by-slice motion artifacts.
We created in-house slice-by-slice motion correction script for suppressing this motion artifact (bellow are screenshots of images before and after motion correction).
When I apply sct_deepseg_sc on both images, in case of motion interrupted data segmentation finish well with satisfactory result, but in case of motion corrected data function finish with error (see below) and segmentation result is empty.
So it looks that our motion correction causes the issue. However, we don´t change image resolution nor
brightness histogram (see below) of image.
State of spinalcordtoolbox
Reorienting the segmentation to the original image orientation...
Remove temporary files...
QC: test with Axial slice
Traceback (most recent call last):
File "/usr/local/lib/sct_3.1.1/python/lib/python2.7/logging/init.py", line 861, in emit
msg = self.format(record)
File "/usr/local/lib/sct_3.1.1/python/lib/python2.7/logging/init.py", line 734, in format
return fmt.format(record)
File "/usr/local/lib/sct_3.1.1/python/lib/python2.7/logging/init.py", line 465, in format
record.message = record.getMessage()
File "/usr/local/lib/sct_3.1.1/python/lib/python2.7/logging/init.py", line 329, in getMessage
msg = msg % self.args
TypeError: not all arguments converted during string formatting
Logged from file slice.py, line 228
Additional Information

Does your motion correction code output an image with a different output type? I feel that we are back to this issue. If that's the case, could you try the "x1000" trick and let us know how it goes?
Note: the error you are seeing (TypeError: not all arguments converted during string formatting) is generated by the QC module (because there is no visible segmentation).

Our motion correction code has on output image with same data type (float32).
In this case we are working with original data before normalization. You can see at histogram that we have values of brightness between 0 and approx. 750 (histogram curves for both images look almost same).
And I am attaching a screenshot which illustrates that segmentation works fine on image before motion correction (picture below).

I am really puzzled. @valosekj would you mind sending me the motion corrected data in private message? We'll investigate. Thanks!

This issue is related to the presence of NaN in the slice=0 of the motion-corrected image:

An issue has been opened to inform user when that happens (#1774).
Since the NaNs are only in slice=0, a workaround for this image is to remove the NaN-slice and run sct_deepseg_sc:
sct_crop_image -i 2060B_03s_t2_me2d_tra_p2_slice_corrected.nii.gz -dim 2 -start 1 -end -1 -o 2060B_03s_t2_me2d_tra_p2_slice_corrected_crop.nii.gz
sct_deepseg_sc -i 2060B_03s_t2_me2d_tra_p2_slice_corrected_crop.nii.gz -c t2

Thank you very much for your help Julien and sorry for our inattention about the first missing slice (this was caused by issue in our slice correction function). We fixed our slice correction function and now segmentation works properly.


switch to JS API

Hi! Nice work!
What do you think about add an entry in the .gitignore for the file ".vscode/settings.json"??


TestPrgm: add missing -p option to help text

Signed-off-by: Gary Bisson<EMAIL_ADDRESS>

Sorry I pushed another patch to my master branch which isn't related to TestPrgm and it still appears here.
However note that this second patch is also necessary and I think it should end up in the upstream repo.
Regards,
Gary


feat: create new subdomain flow (DB resolver)

Feature Request
Describe the Feature Request
Create the modal user-flow for registering a subdomain (with records).
Figma designs and prototype is available here.

Must:
This modal user-flow should only be reachable when a domain uses our new ENSIP for Off-Chain resolvers, meaning that subdomains should not be created through SubGraph.
Definition of Done:
This issue will be considered as done when:

[x] All the subdomain registration steps inside the modal, are accessible and have clear rules for accessing (e.g. we cannot let a user access the blockchain call step if the user has put an invalid Ethereum Address)
[x] Records data are being validated before subdomain registration (please reuse the validations we do in Edit Records Modal, here)

Other info

2 transactions will be made. One for registry and another one for text records

a single transaction has been used to register a subdomain thanks to the EIP-5559 v2


[CS2103T-W16-1] Recretary

Recretary is a tool that helps Executive Personal Secretaries manage their day-to-day tasks and take care of their executive's busy meeting schedule. The aim is to reduce the burden and the workload of the Executive Personal Secretaries.

Codecov Report

Merging #66 into master will increase coverage by 0.66%.
The diff coverage is 75.89%.

@@             Coverage Diff              @@
##             master      #66      +/-   ##
============================================
+ Coverage     72.31%   72.97%   +0.66%
- Complexity      400      498      +98
============================================
  Files            70       82      +12
  Lines          1228     1484     +256
  Branches        124      165      +41
============================================
+ Hits            888     1083     +195
- Misses          308      348      +40
- Partials         32       53      +21

Impacted Files
Coverage Δ
Complexity Δ

...ss/logic/commands/exceptions/CommandException.java
100.00% <ø> (ø)
2.00 <0.00> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
40.00% <45.45%> (+20.00%)
3.00 <2.00> (+2.00)

...in/java/seedu/address/logic/parser/ParserUtil.java
82.69% <50.00%> (-14.53%)
17.00 <3.00> (+3.00)
:arrow_down:

...ain/java/seedu/address/model/meeting/Duration.java
53.84% <53.84%> (ø)
5.00 <5.00> (?)

...ain/java/seedu/address/model/meeting/DateTime.java
58.33% <58.33%> (ø)
5.00 <5.00> (?)

...main/java/seedu/address/model/meeting/Meeting.java
59.18% <59.18%> (ø)
18.00 <18.00> (?)

...ain/java/seedu/address/model/meeting/Location.java
60.00% <60.00%> (ø)
4.00 <4.00> (?)

...c/main/java/seedu/address/model/meeting/Title.java
60.00% <60.00%> (ø)
4.00 <4.00> (?)

...address/logic/parser/EditContactCommandParser.java
86.11% <73.33%> (ø)
14.00 <3.00> (?)

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6389d85...d9510fb. Read the comment docs.

Codecov Report

Merging #66 into master will decrease coverage by 5.92%.
The diff coverage is 57.72%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6389d85...076d632. Read the comment docs.


Misplaced arrows in the MODS tab

Self explanatory.
Mod list is as follows, should it matter:

400% speed fear music
UI Fixes
State Icons
Chicken Respawn
Controller UI Overhaul
Save Drag and Drop
Enable Debugger
Fast COFFEE
Hero Buff
Mewocharm
Omori Fight Plus
OneLoader
Photo Album Extended
Portable Picnic Basket
Playtest maker
Run in Background
Improved Save & Load
Save Saver
Shiba Hoodie Kel
Smile More
Tag VA

Mod compat bug, narrowed down to Controller UI Overhaul, planned fix for Preview 3


Can't install on Mac OSX 10.11 El Capitan

When I pip install pew on the system Python on my Mac I see an error because it tries to upgrade the system version of setuptools. There is an error uninstalling the current version of setuptools (1.1.6) because there is a later version noted as a dependency in the pew setup.py. I'm glad that it fails because I don't want to break the system Python install. I'm sad that it fails though because I can't seem to install pew.
Does anyone know of a way of installing pew on Mac OSX that avoids this problem? Fair notice for any proposed answers - I won't run homebrew on my machines.

I note that this has come up before on #71 and #83 but I'm either not picking up those fixes or there is another problem introduced by the update to OSX 10.11.3 that I'm running.

I'm still struggling with this. On #71 it's stated that this install problem is fixed on OSX and other tickets refer to that one. I still can't install on OSX because the requirements.txt still states setuptools>=17.1 but my system Python has setuptools 1.1.6 and that can't be updated.

For the time being I 'fixed' my system by installing version 0.1.16 of pew. That version doesn't try to upgrade setuptools and works on my Mac running OSX 10.11.3

Sorry for not replying earlier, I'm trying to go back and clean a few issues now.
Unfortunately, I don't use Macos and when I wrote this I'm afraid I might've confused the general problem with the Mac-specific issue (since a few people mentioned that they sorted it out, I thought there might've been a way to update setuptools).
I'm afraid that the only true solution is to be able to upgrade Setuptools, and Macos' System Integrity Protection makes it impossible/impractical to upgrade Setuptoos system-wide.
Usually I try to install as much stuff as possible via Nix (which works also on Macos, and there's an old nix package for pew, but unfortunately I haven't kept it up-to-date)... for graphical Python software instead (unless I'm on a pure Nixos system) I rely on pipsi, as suggested in this other comment.
I'll now push an updated README in which I suggest people to use pipsi, rather than plain pip. I'm afraid that I cannot do much else besides that.


Wikimedia Commons Wikibase not detecting Odia-script characters

I've been trying to upload a batch of files that have names containing both Latin and Odia characters. Commons allows filenames with Odia characters, for instance, this file. See the screenshot of the error I see below. cc @wetneb

Duplicate of #5656


Always try to load an extension required by a custom part type

We had an error in an extension required by a custom part type, so the editor disabled the extension. However, once the extension was fixed, it wasn't turned on again until I made an edit to the question.
When an extension fails, it should be turned off client-side in the editor, but the question should still say it uses the extension when it's saved.

This seems not to happen any more.


Another batch of AVX2 intrinsics

I've commented out the two functions that fail in debug mode with a note about it.

@jackmott Thanks! Can you please start rebasing and squashing your changes against current master? For example, the first commit in this PR is the same first commit from your first PR. I squashed your previous PR for you, but the list of commits is getting out of control. :-/

(This otherwise looks good to go!)

do you happen to know the git incantations i need to do? if not I'll figure it out eventually

@jackmott OK, I just did this one for you to make it simpler.  Basically, the idea is to make each PR contain only the commits relevant to that PR. To do that, you'll need to base new PRs off master where master contains all of your previously merged PRs.
Note that in the commands above, I used origin to refer to BurntSushi/stdsimd, but you might have that setup to track your fork. To see the truth, run git remote -v.

thank you


Document the use of PLATFORM built-in in Fluent

In https://bugzilla.mozilla.org/show_bug.cgi?id=1426063 we're adding a new built-in into Fluent for Gecko called "PLATFORM".
We'll want localizer docs for it.

Fixed in #105


Sum a value to @index variable

Hi Team.
Im trying to sum a value to the @index variable in this wonderful plugin. Especially sum 1 to the variable to show an order.
Example

to show this (Just starting the table)

I would like, instead shows Lot 0, Lot 1,... that starts from Lot 1, Lot 2,... to not create confusion to the cliente.
Is there any way to do that? (I tried but give me errors like is not permited)
Thanks so much again and in advance

You can use handlebar helper functions and pass the @index as parameter to it and do any operation on it.
Handlebar helper function approach is in the documentation of dynamic text

@samant-rags Thank you for the help.
@Yoslandy Here is how it looks like:
Content:
{{#each data}}
Index {{inc @index}}<br/>
{{/each}}

JavaScript:
handlebars.registerHelper("inc", (value) => parseInt(value)+1);


Localtunnel with subdomain not working after several restarts

Steps to reproduce :
Start localtunnel with subdomain parameter and cancel with Ctrl-Z several times and then it will start with a random subdomain or failing with error that something wrong with firewall.
Usually it takes about three times, I need to restart my server during development and have no opportunity to stick to random subdomains

Why are you using CTRL-Z? It's not a cancel command; it's "put the app into background" command. So my guess it doesn't close the connection, thus server holds onto that sub-domain. Next time you start localtunnel it cannot use the same sub-domain because server thinks it's taken.

I've tried it several times with Ctrl-C, indeed it just is working. Thank you.
With Ctrl-Z I used to manually kill the process and started it again.


Find a way to bind Web UI to all interfaces

Currently the Web UI only binds to the main interface in host networking mode. Would be nice if this worked for all interfaces so we could view the dashboard over tailscale, for example.

I think we fiddled with this a couple of years ago and ran into a conflict - The conversation is buried in a closed issue somewhere.


Specifications overview page

https://microprofile.io/specifications/

https://github.com/eclipse/microprofile-marketing/issues/795#issuecomment-1654654296


scons use CPPFLAGS as well as CCFLAGS to compile c code?

Operating system or device:
Linux 4.5.1-1-ARCH
Issue description (what happened, and what was expected):
Added a "-std=c++14" CPPFLAGS into env, and compile godot.
It seems CPPFLAGS also be used to compile c code?
Which is ok for gcc toolchain, but for clang it has some trouble with this flag
error: invalid argument '-std=c++14' not allowed with 'C/ObjC'
How to compile c code without CPPFLAGS?

need use CXXFLAGS instead.


Crash when opening cmake files

warning: Section `.reg-xstate/59344' in core file too small.
#0  0x00007ffff7dce830 in __GI___regexec (preg=0xbf6898, string=string@entry=0xbf6890 "#", nmatch=nmatch@entry=1, pmatch=pmatch@entry=0x7fffffffb2d0,
    eflags=eflags@entry=2) at /usr/src/debug/glibc-2.37-4.fc38.x86_64/posix/regexec.c:214
214       lock_lock (dfa->lock);
[Current thread is 1 (Thread 0x7ffff7cd7740 (LWP 59344))]
(gdb) bt
#0  0x00007ffff7dce830 in __GI___regexec (preg=0xbf6898, string=string@entry=0xbf6890 "#", nmatch=nmatch@entry=1, pmatch=pmatch@entry=0x7fffffffb2d0,
    eflags=eflags@entry=2) at /usr/src/debug/glibc-2.37-4.fc38.x86_64/posix/regexec.c:214
#1  0x00007ffff7e344ce in advance (string=0xbf6890 "#", expbuf=<optimized out>) at regexp.c:78
#2  0x00007ffff6d5b674 in scan () from /home/user/.local/share/nvim/lazy/nvim-treesitter/parser/cmake.so
#3  0x00000000006f2098 in ts_parser__lex (parse_state=1, version=<optimized out>, self=0xbf6890)

Experienced crash when opening cmake file in neovim. Is it because of the glibc version that I am using?

is this still a problem?


Use concrete fitsfile object

Instead of storing a raw pointer which is constant, we cannot manage mutability of this struct. To allow more control, store a concrete struct and refer mutably to it

After discussion on the rust users forum I will instead:

make FitsFile.fptr private
make any methods that change file data take self as &mut self indicating that mutation will occur


Error while downloading results from ASReview LAB

Describe the bug
When using the covid-19 plugin, I tried to download my results. However the following error popped up: "ValueError: The state file does not correspond to the given data file, please use another state file or dataset." Meaning that I was not able to download the results 😢
To Reproduce
I used the 'CORD-19 2020 (v2021 03-29) plug in, but I was not patient enough, so I clicked it twice or more (cancelled the upload and tried again). Then I screened about 5 articles and then wanted to download the results. Which I also tried a few times, before I realized it was working on the download, but it was so big, it just took a while.
Screenshots

Version information

Microsoft Windows [Version 10.0.19041.867]
ASReview version 0.16

Additional context
I also posted the same question on the discussion board #544, where the solution was to clean the project files

The issue has been resolved in https://github.com/asreview/asreview/discussions/544


Ability to abort clang-tidy is missing

Hi,
thanks for your work on the clang-power-tools. I am having a lot of fun checking our projects with Clang and Clang-tidy directly in VS.
I made the mistake of calling clang-tidy on a bigger project (200+ source files). I could not find a way to cancel the execution of the script. Ideally I would be abort the current tidy call or at least before the next clang-tidy run. I also cannot kill VS with the task manager, as I will loose all my settings that I have made.
Thanks

That's a very good suggestion.
We'll definitely have to add an option to abort a long running operation.
Thanks.

Work in progress...

Implemented in version 2.1
Give it a try.

This issue was fixed in the new version 2.1.0 just released : www.clangpowertools.com


Address deprecated concepts for release 13.0.0

This issue spells out changes that need to be made regarding deprecated items in preparation for the next major release: 13.0.0

PR https://github.com/semanticarts/gist/pull/941, Deprecated properties related to occupying a location

Remove the two deprecated properties

occupiesGeographically
occupiesGeographicallyPermanently

Change the restriction on Landmark to use hasPhysicalLocation rather than occupiesGeographicallyPermanently. Also, use subClassOf instead of equivalentClass.

gist:Landmark
	a owl:Class ;
	rdfs:subClassOf
		gist:PhysicalIdentifiableItem ,
		gist:Place ,
		[
			a owl:Restriction ;
			owl:onProperty gist:hasPhysicalLocation ;
			owl:someValuesFrom [
				a owl:Class ;
				owl:unionOf (
					gist:GeoRegion
					gist:GeoVolume
				) ;
			] ;
		]
		;
	skos:definition "Something permanently attached to the Earth."^^xsd:string ;
	skos:prefLabel "Landmark"^^xsd:string ;
	.

PR https://github.com/semanticarts/gist/pull/951 Remove isCharacterizedAs
Remove the deprecated property, isCharacterizedAs
Remove the restriction on Event that uses isCharacterizedAs
The new version of Event will look like this:
gist:Event
	a owl:Class ;
	skos:definition "Something that occurs over a period of time, often characterized as an activity being carried out by some person, organization, or software application or brought about by natural forces."^^xsd:string ;
	skos:example "A transaction, conference, baseball game, earthquake."^^xsd:string ;
	skos:prefLabel "Event"^^xsd:string ;
	skos:scopeNote "An event does not necessarily have either planned or actual start or end datetimes. For example, a conference can be in the planning phase without any dates selected, but is nevertheless an (unscheduled) event. The subclasses of Event state particular restrictions on planned and actual start and end dates."^^xsd:string ;
	.

Consider whether anything else is needed/desired for Event.

PR https://github.com/semanticarts/gist/pull/951 Remove tagText

Tag: change restriction

to use containedText instead of tagText
to use subClass rather than equivalentClass

Make  uniqueText a subproperty of containedText
Broaden range of containedText include anyURI

New version of Tag:
gist:Tag
	a owl:Class ;
	rdfs:subClassOf
		gist:Category ,
		[
			a owl:Restriction ;
			owl:onProperty gist:containedText ;
			owl:someValuesFrom xsd:string ;
		]
		;
	skos:definition "This is for folksonomy type terms, which can be made up on the fly by users."^^xsd:string ;
	skos:prefLabel "Tag"^^xsd:string ;
	.

New version of containedText:
gist:containedText
	a owl:DatatypeProperty ;
	rdfs:range [
		a owl:Class ;
		owl:unionOf (
			xsd:string
			xsd:anyURI
		) ;
	] ;
	skos:definition "A string that is closely associated with an individual."^^xsd:string ;
	skos:example
		"The string associated with a tag."^^xsd:string ,
		"The string associated with text content."^^xsd:string
		;
	skos:prefLabel "contained text"^^xsd:string ;
	gist:domainIncludes
		gist:Tag ,
		gist:Text
		;
	.

PR https://github.com/semanticarts/gist/pull/997 Extend symbol predicates

Remove predicates: gist:unitSymbol, gist:unitSymbolHtml and gist:unitSymbolUnicode
Remove all triples using the predicate gist:unitSymbol

Will be assigned to 13.0.0 release manager.

Assigning to @dylan-sa as 13.0.0 release manager.


feat: add gesture plugin

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] commit message follows commit guidelines

Description of change

👍


no such function: json_extract

My SQLite DB has a custom view which requires JSON_EXTRACT. It works fine in DB Browser for SQLite but throws the above error in grafana.
My Query for reference
select datetime(ge.worldtime, 'unixepoch') as LocalHostTime, ge.eventType as EventType, ' X: ' || ge.x || ' Y: ' || ge.y || ' Z: ' || ge.z as IncidentArea, ge.ownerId as VictimPlayerId, ge.ownerName as VictimPlayerName, ge.ownerGuildId as VictimGuildID, guilds.name as VictimGuildName, ge.causerId as AttackingPlayerID, ge.causerName as AttackingPlayerName, ge.causerGuildId as AttackingGuildID, ge.causerGuildName as AttackingGuildName, json_extract(ge.argsMap, '$.itemTemplateId') as ItemID, cust_item_xref.name as ItemName, ge.stack as StackedAmount from game_events as ge INNER JOIN cust_item_xref ON cust_item_xref.template_id = ItemID INNER JOIN guilds ON guilds.guildId = VictimGuildID where ItemID != '' order by LocalHostTime DESC

This was my misunderstanding. json_extract cannot be used from a query alone it needs to be able to use an in member table which is why it works in db browser. I've corrected this by created an automated task to create a table with same values and have grafana pull data from that.

Seems like the issue is fine now. I know that there appears to be some JSON functionality, that needs to be compiled into SQLite, where I am not sure if the plugin does it correctly now.
So some JSON features might indeed be missing. But it looks like that is not your case...

@fr-ser do you plan on releasing a version with support for JSON functionality? It looks like it can be enabled by default at compile time using a Go build tag.
go build -tags json1 github.com/mattn/go-sqlite3


Feature  ✨ : Add scroll to top button

🎮 feature Request
feature logic and basic description:
Currently, there is no scroll to top button present on the website, which makes navigation a bit cumbersome, especially when users need to return to the top of a lengthy page.
Though it may seem minor, the absence of this feature can impact the overall usability and performance of the website.
Point down the features
feature points:
Visibility Toggle: The button appears only when the user scrolls down a certain distance from the top of the page. This ensures that it doesn't obstruct the view unnecessarily but is readily available when needed.
Smooth Scrolling: Clicking on the button triggers a smooth scroll animation, ensuring a seamless transition back to the top of the page, rather than a sudden jump.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Please assign me this issue
I'm working under GSSOC'24

please assign this issue to me


Request for auto suggest words feature and option to save custom strings that can be used later using auto suggestion

Codeboard is an excellent app for editing code and even for usual social media chatting scenarios. If this app has auto suggest and auto complete feature, the app become usable for all purposes as a daily driver app. What I meant was,  when we type a word or function name like strlen or strncmp, if there is an option to save this to a database and when the word is typed again auto suggest feature shows that word it will be helpful.
I know there is not enough space on the top bar or row in codeboard. If that the reason I suggest adding an extra key to switch or toggle top row b/w desired mode that are, auto suggestions and ESC TAB arrow key row.
This is a suggestion because such a great open source project like this should be enriched with more features. Hope you will consider this suggestion. Thanks in advance.

This sounds like a great feature to have! Sounds like code completion support baked directly into the keyboard. I like the idea of having a key for this instead of using up a whole row. A row is a lot of space and we need to make sure we put the space to the best possible use.
https://github.com/gazlaws-dev/codeboard/issues/40 is related. I'd like to see the existing code snippets use this same system.

Look, that's the only one feature this awesome project lack. You developers should look in to it. Once did that, the same app can be used for coding as well as normal texting.


Switch with number in strings as value -> Error: Arguments must either all be numbers or strings

When using a switch statement on a string (coming from Api JSon payload as string) that contains numbers;

It throws an error:

When just adding a letter after the 23 like 23A it works ok.
Somewhere the 23 does get converted into a number although I specifically set the Value Type to string.
Am currently using this as a workaround:

Version
858ef680

Not sure if this is an issue with expressions or with adaptive itself I suspect the later but @boydc2014  can you investigate and comment?

We expect a string in the case https://github.com/microsoft/botbuilder-dotnet/blob/54bad3490e0167ae5cfa08be58a3100787014fc2/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/Case.cs#L25 and parse it to number if it is https://github.com/microsoft/botbuilder-dotnet/blob/54bad3490e0167ae5cfa08be58a3100787014fc2/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/SwitchCondition.cs#L122. Then when the case is a string of number, it will be type of number. I think we should update schema of Case to correct this.

We will address this as a bug in the next release.


Server Release 0.29.1

see https://github.com/mercedes-benz/sechub/projects/1

Duplicate of #1113


Need help with deepquery selector

Here is the jspath :(Not able to click on the link )
document.querySelector("body > portal-web").shadowRoot.querySelector("#sink > details-web").shadowRoot.querySelector("div > history-page > div > ink-container > ink-card > div:nth-child(2) > div.historypage-items > mat-table > mat-row:nth-child(2) > mat-cell.ods-text__body--normal.component-width-insight.mat-cell.cdk-column-InSight.mat-column-InSight.ng-star-inserted > a")
I tried doing the below :
const viewRelease = (await this.page.waitForFunction(() => {
const viewRelease = querySelectorShadowDom.querySelectorDeep("div > history-page > div > ink-container > ink-card > div:nth-child(2) > div.historypage-items > mat-table > mat-row:nth-child(2) > mat-cell.ods-text__body--normal.component-width-insight.mat-cell.cdk-column-InSight.mat-column-InSight.ng-star-inserted > a")
return viewRelease;
})).asElement();
await viewRelease.click();
OR
const viewRelease = (await this.page.waitForFunction(() => {
const viewRelease = querySelectorShadowDom.querySelectorDeep("div:nth-child(2) .ng-star-inserted > a")
return viewRelease;
})).asElement();
await viewRelease.click();
Both did not work

Hi i'm sorry to hear you're having issues, i will struggle to debug these scenarios to see if there are bugs in the library without reproduction code. I've not seen these issues raised before so it's possible that the css selector your using are not correct. I'm sorry i can't be of more help, all i can advise is to keep your selectors as simple as possible.


[AutoPR storage/resource-manager] typo: storage/resource-manager/Microsoft.Storage/blob

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4551

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/3371


Make CastableObjectSupport constructor eager

This was breaking Test.CoreLib since we don't have a class constructor runner there.
In the longer term, we'll probably want the compiler to detect if a class constructor runner is available in the classlib and make everything eager if it isn't.
In general this is a bigger feature because at that point we also need to topologically sort the constructors based on their dependencies. (We might already have a problem there...)

👍


No customer events released error ASP.NET Core 3

I tried to follow the instructions for an ASP.NET Core 3.0 App, and I get the following error

fail: ServiceProfiler.EventPipe.Client.ServiceProfilerProvider[0]
Expected trace validation error.
ServiceProfiler.EventPipe.Client.TraceValidators.ValidateFailedException: [ActivityListValidator] No sample activity matches the trace.
at ServiceProfiler.EventPipe.Client.TraceValidators.ActivityListValidator.ValidateImp(IEnumerable1 samples)   at ServiceProfiler.EventPipe.Client.TraceValidators.TraceValidatorBase.Validate(IEnumerable1 samples)
at ServiceProfiler.EventPipe.Client.TraceValidators.TraceValidatorBase.Validate(IEnumerable`1 samples)
at ServiceProfiler.EventPipe.Client.ServiceProfilerProvider.OnTraceStopped(Object sender, TraceStopEventArgs e)
warn: ServiceProfiler.EventPipe.Client.ServiceProfilerProvider[0]
Trace validation failed. No customer events released.

Is there an additional step other than turn off the compat test?

@isaac2004, thanks for filing the issue. I can repro what you mentioned on the .NET Core 3.0.100 and I have some direction to look into. It will take sometime. I'll get back to you once there progress.

@isaac2004, please try this again with 1.1.7-beta2.

Cross reference #48 , this issue has been fixed. Close this one.


Visualizations to be agnostic to Makie backend

GLMakie may be preferred when creating visualizations locally, but allows WGLMakie to be installed instead for web/browser-based plots.
By default, figures will appear in the VS Code plot pane:

To switch backends, either:
] remove GLMakie
] add WGLMakie

or have both installed and activate the desired backend:
using WGLMakie
WGLMakie.activate!()

# or

using GLMakie
GLMakie.activate!()

https://docs.makie.org/stable/explanations/backends/

Should we also update the parts of the doc that say using GLMakie?

Done.


error when migrating dev using two schema instances

Hi Prisma Team! The following command just crashed.
Was testing out using two schemas. The old database didn't have any schema, so I added a new one and mapped the old tables to the original schema, and only one testing module using the new @@schema decorated. I have enums in the old schema, got an error saying that enums aren't mapped to schemas, so removes $$schema from the enums. Awesome work on Prisma btw, big fan.
Command
migrate dev
Versions

Name
Version

Platform
darwin-arm64

Node
v18.6.0

Prisma CLI
4.4.0

Engine
f352a33b70356f46311da8b00d83386dd9f145d6

Error
Error: Error in migration engine.
Reason: [migration-engine/connectors/sql-migration-connector/src/sql_renderer.rs:110:9] internal error: entered unreachable code

Please create an issue with your `schema.prisma` at
https://github.com/prisma/prisma/issues/new

@RhinoSoftware Hi! Thanks for the bug report.
We did some work on multiSchema recently, and I recommend you to try if you can reproduce this in version 4.5.0 and let us know if it still happens.
I guess you are using the multiSchema preview feature on PostgreSQL?
If you could provide us the schema to reproduce, it would help a lot 💚

@RhinoSoftware Hi! Thanks for the bug report. We did some work on multiSchema recently, and I recommend you to try if you can reproduce this in version 4.5.0 and let us know if it still happens.
I guess you are using the multiSchema preview feature on PostgreSQL?
If you could provide us the schema to reproduce, it would help a lot 💚

Thank you for your swift reply!
I have opened a new project and bumped Prisma to 4.5.0. Using mysql 8.0.29, however error persists.
This is the schema.prisma file:
`
generator client {
provider = "prisma-client-js"
previewFeatures = ["multiSchema"]
}
datasource db {
provider = "mysql"
url      = "mysql://user:password@localhost:3306/test"
schemas = ["test1", "test2"]
}
model User {
id    Int    @id @default(autoincrement())
name  String?
@@schema("test1")
}
model Post {
id    Int    @id @default(autoincrement())
name  String?
@@schema("test2")
}`
When I tried applying this to our main codebase, it took a while to fail, and apparently it happens at the last step during generation of migration files. When attempting it with the above code, I am promoted to enter a name for the migration, and after that the error is returned, but happens faster of course. I fear there is something wrong with my configuration, although it's straightforward as per the docs. Here is the CLI output.

I appreciate all your help and efforts, and if there's anything I can do to help, please let me know, thanks again for everything. This is not a complaint either, and would love to keep seeing Prisma excel in the future. We have adopted it around 10 months ago with NestJs, and are really happy with where Prisma is now compared to where we started. Cheers!

Appreciate your help @Jolg42 and the whole team, have a great day guys!


StringLengthToEmptyFixer - introduction

closes https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5005
[11:03 AM]-[possum@aquarium]-[~/work/PHP-CS-Fixer]-[git master_StringLengthToEmptyFixer]
$ php php-cs-fixer describe string_length_to_empty
Description of string_length_to_empty rule.
String tests for empty must be done against `''`, not with `strlen`.

Fixer applying this rule is risky.
Risky when `strlen` is overridden, when called using a `stringable` object, also no longer triggers warning when called using non-string(able).

Fixing examples:

--- Original
+++ New
@@ -1,1 +1,1 @@
-<?php $a = 0 === strlen($b) || \STRLEN($c) < 1;
+<?php $a = '' === $b || $c === '';

Coverage increased (+0.01%) to 92.791% when pulling 296fa51205c5836b0cc3320a33cfb8ae72fa41f4 on SpacePossum:master_StringLengthToEmptyFixer into eb717fe86c222c7d1be2be900f059510d700dafb on FriendsOfPHP:master.

Thank you @SpacePossum.


Handle multiple input locations of illum files.

This situation occurs for workflow cpd_analysis_pipeline when parameter illum_directory_gsurl is used when the illum files are stored separately from the images.

Thanks for fixing the bug!


python xy spyder not launching

I've installed python xy 2.7.10 and when starting Spyder, the console appears for a split second and then disappears and Spyder never opens.dont know what to do ......need help:-(

Python Version:python xy 2.7.10
Operating system:windows xp

Please run in a terminal (i.e. cmd.exe) this command
spyder --reset

and post its results.

I can tell you some things from your screenshot:

Windows XP is not supported anymore, sorry.
You're using Anaconda and not Python XY
You don't need to start Spyder from its installation directory. You should be able to start Spyder from your user directory.

In any case, problem 1. is unfixable for you, sorry :-/

I got this. Any advancements, please?


Create the Discord.js topic

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

This topic must be created due to the immense amount of projects built on this module

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@gatomo-oficial this is getting closer, but there are still issues surfaced in the CI build failure. Feel free to fix those and re-request a review

Feel free to reopen when ready. Thanks!


[LIBCLOUD-1001] Update Cloudflare DNS driver to API v4

Update Cloudflare DNS driver to API v4
Description
As discussed in LIBCLOUD-1001, Cloudflare turned off the old JSON API and replaced it with the new v4 API. This pull request updates the Cloudflare DNS driver to use the new API.
Note that in order to keep the implementation of the v4 driver streamlined, none of the existing ex_ methods were migrated to the new API.
Note that LIBCLOUD-994 is also fixed by the new driver implementation.
Status

done, ready for review
CI passed

Checklist (tick everything that applies)

[x] Code linting
[x] Documentation
[x] Tests
[x] ICLA

Codecov Report

Merging #1292 into trunk will decrease coverage by 0.02%.
The diff coverage is 86.43%.

@@            Coverage Diff             @@
##            trunk    #1292      +/-   ##
==========================================
- Coverage   85.95%   85.93%   -0.03%
==========================================
  Files         359      359
  Lines       73911    73796     -115
  Branches     6705     6724      +19
==========================================
- Hits        63530    63414     -116
+ Misses       7698     7688      -10
- Partials     2683     2694      +11

Impacted Files
Coverage Δ

libcloud/test/dns/test_cloudflare.py
100% <100%> (+1.42%)
:arrow_up:

libcloud/dns/drivers/cloudflare.py
85.07% <81.63%> (-4.36%)
:arrow_down:

libcloud/test/compute/test_upcloud.py
91.39% <0%> (+1.32%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51fe8e7...bdd551e. Read the comment docs.

Tagging @Kami as the original author of the Cloudflare DNS driver.

@c-w Thanks for the contribution.
Since it's a bigger change, signed ICLA is required (http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes).

Thanks for the patience @Kami. The ICLA is now signed.

I think it would be good to release v2.6.0 in the near future once this PR and a couple of other ones are merged.
Do you want to try the release process for v2.6.0?

Thanks for the review @Kami and yes, I'd be happy to go through the release flow for v2.6.0.


define interface to access underlying graph data

this is an example for #58. Not meant for merging right now.

Looks good!

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev-0.5@95d7a79). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             dev-0.5      #59   +/-   ##
==========================================
  Coverage           ?   63.12%
==========================================
  Files              ?        7
  Lines              ?      377
  Branches           ?        0
==========================================
  Hits               ?      238
  Misses             ?      139
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d7a79...d743164. Read the comment docs.

Yes, PD uses StaticEdgeFunction, so we have to either rewrite that part of PD or get rid of the allocations again: https://github.com/JuliaEnergy/PowerDynamics.jl/search?q=StaticEdgeFunction.
Btw, it looks like it was allocating before, since it returns a tuple. Did allocations increase?

Tuples are of known length and size and can be stack allocated. Before it was returning a tuple containing of two pointers to heap allocatet Arrays e_s_v and e_s_d which have been allocated before therefore non allocating function call.
Now it is composing a tuple (non allocating) of to pointers but the pointers refer to arrays which will be created in the function call through these iterators (allocating). But the PD packages doesn't seem to be interested in the full arrays anyway (see my comment)

Should not be merged jet. I'll try to decouple the GraphStructure from the rest of the package. As discussed earlier it would be nice to change the module (for example switching to the GraphDataBuffer-design) without having to touch a lot of code outside of NetworkStructures.jl.

Nice to see tests for the modules and for allocations. Did you do the benchmarks yet?
Also I think GetGD and GetGS are abusing multiple dispatch and could be functions instead of types. For what reason were they chosen to be types @FHell ?

Yes, no perfomance hit compared to master (i think everything boils down to the same machine code anyway due to inlining).

Also I think GetGD and GetGS are abusing multiple dispatch and could be functions instead of types. For what reason were they chosen to be types @FHell ?

I guess because of the type of nd
nd = network_dynamics(nd_diffusion_vertex, nd_diffusion_edge, g)
typeof(nd) ## isa ODEFunction
typeof(nd.f) ## isa nd_ODE_Static

The ODEFunction forwards all function calls to its .f field. In order to put in in a function one would have to define a new method on the ODEFunction object.
function getGD(nd::ODEFunction{true, T}) where T<:nd_ODE_Static
    nd.f.graph_data
end

(in case you are wondering, the first type parameter true for ODEFunctions is whether it is in place.)
I think this not high priority but certainly something to think about (#35).


adds shared builder workflows and scripts

Summary

The scripts and most of the workflows used by builders are shared across builders. Now they're defined in the builders/ directory. Corresponding PRs will be opened against builder repos to sync the shared files.
Use Cases

Now, updating the shared builder workflows can happen in one place, not three.
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have added an integration test, if necessary.

Note that this uses the updated interface for the update-builder workflows that results from: https://github.com/paketo-buildpacks/github-config/pull/225


Add option to switch backend

I've added a new --database-backend option to py.test, so we can run the whole suite of tests on different backends. This is just a proposal and it should work. IMO we can integrate it soon because we need the backend key anyway.

Are we able to access the pytest options elsewhere in the tests (e.g. for skipping test modules)?

Yes! We can skip tests based on a condition. We can work on this when we start integrating MongoDB.


[tool_crash] StateError: Bad state: No context with the running Dart application.

Command
flutter run -d chrome

Steps to Reproduce

...
...
...

Logs
StateError: Bad state: No context with the running Dart application.
#0      RemoteDebuggerExecutionContext.id (package:dwds/src/debugging/execution_context.dart:47:7)
<asynchronous suspension>
#1      AppInspector._getExtensionRpcs (package:dwds/src/debugging/inspector.dart:486:20)
<asynchronous suspension>
#2      AppInspector._initialize (package:dwds/src/debugging/inspector.dart:93:34)
<asynchronous suspension>
#3      AppInspector.initialize (package:dwds/src/debugging/inspector.dart:156:5)
<asynchronous suspension>
#4      ChromeProxyService.createIsolate (package:dwds/src/services/chrome_proxy_service.dart:188:18)
<asynchronous suspension>

[✓] Flutter (Channel beta, 1.26.0-17.5.pre, on macOS 11.2.1 20D74 darwin-x64, locale
    en-US)
    • Flutter version 1.26.0-17.5.pre at /Users/Melch/Developer/flutter
    • Framework revision 1fe38dcb5f (2 days ago), 2021-02-10 16:25:47 -0800
    • Engine revision d4453f6018
    • Dart version 2.12.0 (build 2.12.0-259.9.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/Melch/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.53.2)
    • VS Code at /Users/Melch/Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (2 available)
    • iPhone 12 Pro Max (mobile) • A589186A-F5AE-449D-94E3-064EFF3F56CF • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)
    • Chrome (web)               • chrome                               • web-javascript •
      Google Chrome 88.0.4324.150
    ! Error: IBA ’s iPhone is not connected. Xcode will continue when IBA ’s iPhone is
      connected. (code -13)

• No issues found!

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: beta
Creation framework version: 5d36f2e7f5387b6c751449258ade8e4e6edf99be
Plugins
integration_test

duplicate of https://github.com/flutter/flutter/issues/60495
see there's an open issue addressing the case you described.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you

@TahaTesser Thank you, thank you for your respond


Issue with two arrays of different type

Hi, I'm using hybernate-types-43 and running into an issue with having an array of type UUID and and array of type varchar.
If I just have the varchar array it works fine, but if I add the uuid array I get an error about trying to convert the varchar array in PG to uuid array.
@TypeDef(name = "list-array", typeClass = ListArrayType.class)
public class CustomerList extends GeneratedIDResource {
    ...
    @Type(type = "list-array")
    @Column(name = "tags", columnDefinition = "uuid[]")
    private List<UUID> tags;

    @Type(type = "list-array")
    @Column(name = "statuses", columnDefinition = "varchar[]")
    private List<String> statuses;

With just the statuses array it works fine, but adding the tags array breaks statuses.
Is this supported?

It can surely be supported. There are two ways to do it:

You can do it yourself and provide a Pull Request with the fix, and I will review it when I have some time.
I could do it via consulting and integrate it as soon as I fix it.

Okay, so just to confirm, it is not currently supported right?  Also if I were to do that myself, any tips on what class to look at?
Thanks

Try debugging the ListArrayType and see why it's working for String and not for the UUID.

Closed as no analysis was provided.


chore: update to forc 0.63.1

Type of change

Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes
The following changes have been made:

All standards built with forc v0.63.1
All examples built with forc v0.63.1
SRC14: target storage variable pinned to standardized slot.
CI: updated to latest Rust, Forc and Fuel core versions

Related Issues

Closes #132
Checklist

[x] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation where relevant (API docs, the reference, and the Sway book).

[x] If my change requires substantial documentation changes, I have requested support from the DevRel team

[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.
[x] I have updated the changelog to reflect the changes on this PR.

Blocked by https://github.com/FuelLabs/sway/issues/6447


Remove unencrypted email from users

I don't plan to merge this until everything is in production and is clearly working.  I don't expect any problems, but the whole point of delaying removing this column is to prevent data loss.

@jdossett wants to wait until 2018-06-14 or later (2 weeks) before putting this change into production, just in case there's a really rare problem.  That's longer than I originally planned, but I don't have any strong reason to do it sooner. I certainly don't want to merge this until we're confident everything is okay... so I plan to go with his advice.
If anyone objects, please comment!

There are still no reported problems. I intend to merge this soon. If there is a suspected issue, please post asap.

LGTM

Whenever you are ready, I think this can be merged now.


remove http so https arangos will work

as @pluma  found out, this is the cure for https://github.com/arangodb/arangodb/issues/7320

Fixes #7320.


Release Request for Preprocess Code for Hypersim Dataset

Hi, I come from geowizard, the author says that the Hypersim dataset they used is sourced from your server. So could you please release the preprocess code for Hypersim? Thank you very much.

I hope this file shall work for Hypersim. Dataloaders for other datasets lie in the same folder.


Added scheduled_time_gtfs_ride_id

Currently not deleting anything, this PR only adds a query that sets scheduled_time_gtfs_ride_id correctly.
After adding it, I'll wait to the ETL to run in prod, validate it, and then create another PR in which I'll change gtfs_ride_id to point to scheduled_time_gtfs_ride_id.

@ShayAdler there was an error after the merge, so I reverted it: https://github.com/hasadna/open-bus-stride-etl/issues/14


业务系统服务下线后，如何在skywalking服务中下线该服务的实例

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
业务系统服务下线后，如何在skywalking服务中下线该服务的实例

Bug

Which version of SkyWalking, OS, and JRE?

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

Requirement or improvement

Please describe your requirements or improvement suggestions.

We only accept English on GitHub.


Treat credential errors as retryable

Most credentials need to periodically fetch an access token, often via some HTTP or gRPC request. These requests can fail. These failures are always retryable, even for non-idempotent operations, because the request never left the application.
At this time there is no way to distinguish credential failures from RPC failures.  But with the recent work to populate ErrorInfo for local failures we could start telling this failures apparent.  For example, we could add a gcloud-cpp/auth: true metadata entry to the error info.
We would need to change all the retry loops to treat these errors as transient failures.

Revisit for 2023/Q4

Revisit for 2024/Q2

Revisit for 2024/Q4


job console

confirmed, got the same issue

if you add/remove on any id card access it lost his job icon, for recover it, you need use selector


report error

[Window Title]
devenv.exe
[Main Instruction]
An unexpected error occurred
[Content]
Please press Ctrl+C to copy the contents of this dialog and report this error to our issue tracker.
[V] Show details  [Close]
[Expanded Information]
Build: 17.0.23262.1

System.ObjectDisposedException: Cannot access a disposed object.
   at Microsoft.VisualStudioTools.Project.ProjectNode.GetMsBuildProperty(String propertyName, Boolean resetCache)
   at Microsoft.VisualStudioTools.Project.ProjectNode.GetProjectProperty(String propertyName, Boolean resetCache)
   at Microsoft.PythonTools.Project.CondaEnvCreateProjectInfoBar.<CheckAsync>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PythonTools.Infrastructure.VSTaskExtensions.<HandleAllExceptions>d__5.MoveNext()

Describe the bug
[A clear and concise description of the bug]
Steps to Reproduce
1.
2.
3.
Expected behavior
[A clear and concise description of your expectation]
Additional context and screenshots
[Add any other information such as screenshots, error message, or stack trace]
Sample Code
XXX

Configuration information (If you are providing a diagnostics file (see below), skip this section)
VS Version: [Can be found under "Help->About Microsoft Visual Studio"]
PTVS version: [Can be found under "Help->About Microsoft Visual Studio->Installed products->Python with Pylance"]
Python version:
Debugger Type (if applicable): [New debugger or legacy debugger?]
Diagnostics file
The diagnostics file contains information such as the Python version, environments, loaded assemblies, configuration options, etc. This file makes it easier for us to reproduce and fix bugs, so we would really appreciate it if you could provide it to us. To locate the logs, you can can follow these steps:

Open the File Explorer on your computer.
In the address bar at the top of the window, type %TEMP% and press Enter.
The %TEMP% folder should open, look for file named PythonToolsDiagnostics_*.log, where * represents a series of numbers.

This file contain the diagnostic information that can help us diagnose and resolve the issue you're experiencing.
Please note that the %TEMP% folder is a hidden system folder, so you may need to enable the display of hidden files and folders in File Explorer to see it. To do this, click on the "View" tab in File Explorer, then check the "Hidden items" box in the "Show/hide" section.
You can attach the file to this issue or email it to us at<EMAIL_ADDRESS>If you email it, please add a link to this issue.
XXX

closing at a dupe of https://github.com/microsoft/PTVS/issues/7772. Would you please provide sample code and repro steps so that we can further investigate? Thanks!


Missing npm dependencies on first run

I believe the full list is here but I wasn't able to get the app started (which I'll describe in a separate issue):
karma
karma
karma-webpack
karma-mocha
karma-firefox-launcher
karma-chrome-launcher
karma-chai
angular
angular-mocks
sinon-chai

Let's move this discussion to the other issue.


Service unavailable

Describe the bug
Integration not working any more, remove and readding account gives service unavailable.
To Reproduce
Adding an account gives you Service unavailable

Additional context
I deleted my entries but I believe this behaviour started on 13/09

Hi Jelle, possible to activate debug on the integration and provide me with the logs? At my side it is still working fine

Hi Jelle, possible to activate debug on the integration and provide me with the logs? At my side it is still working fine

Just enabled debug and guess what... I could login...

Anyway I'll let debug on in case it happens again.
PS: I used bitwarden to fill in the password because it seems giving an incorrect password also gives the "service unavailable" message.
Thanks for taking the time trying to help me.

I'll indeed add the  badcredentials exception :-) sorry for the confusion


fix: handle packet error

Processing is cancelled when an unhandled evt is received.
Return ErrHCIHandlePacket when a Cancel event is received in the process of sending to HCI.

@zakkie
I responded your review!
Thanks.


WIP, Fix race condition between LoginToFedora and cloud init (arranged and testing)

Duplicate of https://github.com/kubevirt/kubevirt/pull/5072
None

/uncc @jean-edouard @rnetser

/retest

/retest

this was a test PR for https://github.com/kubevirt/kubevirt/pull/5072


couchdb3: 3.1.0 -> 3.1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/couchdb/versions.
meta.description for couchdb3 is: "A database that uses JSON for documents, JavaScript for MapReduce queries, and regular HTTP for an API"
meta.homepage for couchdb3 is: "http://couchdb.apache.org"
meta.changelog for couchdb3 is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.1.1 with grep in /nix/store/q6dzkj0yz9sgxkqfnjyg7x0nwag7k04f-couchdb-3.1.1

directory tree listing: https://gist.github.com/9a6dc642d960747b8094208d562374c1

du listing: https://gist.github.com/f8989210a3c33a80d88c56ee2d27a08d

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
couchdb3

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/q6dzkj0yz9sgxkqfnjyg7x0nwag7k04f-couchdb-3.1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A couchdb3 https://github.com/r-ryantm/nixpkgs/archive/ae76a7658d79170271ab55adba8324cae494edaa.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/q6dzkj0yz9sgxkqfnjyg7x0nwag7k04f-couchdb-3.1.1
ls -la /nix/store/q6dzkj0yz9sgxkqfnjyg7x0nwag7k04f-couchdb-3.1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

couchdb3

Maintainer pings
cc @lostnet for testing.

I've run nixos/tests/couchdb.nix on linux x86_64 and it looks good to me. The other platforms are awaiting resolutions on spidermonkey support and shouldn't block this update.


Configurable PriorityOrdered implementation to the VaultPropertySourc…

This PR adds PriorityOrdered interface to the VaultPropertySourceLocator class.
This allows to choose the order in which overriden properties are managed. In our use case, we were looking for a way to Vault property to have higher priority than Consul.
@mp911de As requested, here is the feature pull request. Should be useful for others.

@spencergibb @mp911de  Updated the PR based on your recommendation. Let me know if there is anything else

Thanks for your PR. That's merged and polished with bfb0854.


How do i handle promise rejections?

Is there a way to handle network request errors?
The lib is good, but when testing worst-case scenario with no internet connection my RN Debugger goes yellow and I can`t find a way to handle it.
Would be great if the lib had some render prop for showing the error state.

@arf1e this is a good idea. A really good one. I will try to add that this weekend. Thank you


Programming exercises: Add feedback discussion feature to feedback analysis table

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
[x] I strictly followed the principle of data economy for all database calls.
[x] I strictly followed the server coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[x] I documented the Java code using JavaDoc style.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
[x] I strictly followed the principle of data economy for all client-server REST calls.
[x] I strictly followed the client coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context

This is a follow-up to the feature I’m working on: #9728. The goal is to provide instructors with clearer insights into the feedback given to students. In this PR, a “Feedback Discussion” modal has been introduced. This feature allows instructors to select specific feedback and open a communication channel for it, provided the course has one. For example, during an exam review, instructors can use this functionality to send messages that clarify certain mistakes, offering students a better understanding and clearer insights.
Description

A new server-side query has been implemented, which takes a feedbackDetailText input and creates a channel based on it, automatically adding all students who encountered the corresponding error. On the client side, instructors can now create these channels via a modal accessible on the far-right side of each feedback entry. This modal provides two options: instructors can either navigate directly to the newly created channel or remain on the feedback analysis page. Additionally, the modal allows instructors to specify the channel type, name, and description.
Steps for Testing

Prerequisites:

1 Instructor
Student Sumbissions
1 Programming Exercise

Log in to Artemis
Navigate to a Course with Instructor rights
Create a Programming Exercise or use an existing one
Solve the Programming Exercise as Students, ideally with different kinds of Progress (You can use artemis test users for this)
Navigate as Instructor to the Grading of an Exercise
Navigate to the Feedback Analysis section
Verify that the table displays data correctly, and press the icon in a feedback table entry on the far right side to see the feedback-channel modal
Verify that the channel is created as specified and both creation methods work as intended. Also make sure that all affected students are added to the corresponding channel when creating it.

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

[x] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
[x] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

[x] Code Review 1
[ ] Code Review 2

Manual Tests

[x] Test 1
[x] Test 2

Performance Tests

[x] Test 1
[x] Test 2

Test Coverage

Class/File
Line Coverage
Confirmation (expect)

feedback-analysis.component.ts
98%
✅

feedback-analysis.service.ts
100%
✅

feedback-affected-students-modal.component.ts
93.54%
✅

Methods in ResultService
100%
✅

Methods in ResultResource
100%
✅

Screenshots

Before:

After:

Summary by CodeRabbit
Release Notes

New Features

Introduced functionality to count students affected by specific feedback details.
Added endpoints for creating feedback-specific channels and managing feedback discussions.
New modals for confirming feedback channel creation and managing feedback details.

Enhancements

Improved user interface with new labels and messages for feedback channels.
Enhanced feedback analysis component to support communication features.

Bug Fixes

Various improvements to ensure robust error handling and user notifications.

Documentation

Updated translations and user guidance for new features.

There can also be test cases that are hidden to students (visibility NEVER or AFTER_DUE_DATE). From the screenshots it looks like the channel name and description are empty by default and completely up to the instructor. Can the channel metadata itself leak information otherwise? Should there be a warning note that this is secret test case in the confirmation dialogue to remind instructors to not accidentally reveal stuff in the channel name/description when creating the channel?
(We don’t use the communication feature, so I’m not familiar what potential revealing metadata a channel could have besides name and description.)

@b-fein That is a good question, but I made sure to consider this by not adding too much default information to the channel itself and therefore forcing the instructors to fully decide on channel name and description. This only real information which is shown is which students are encountering a similar feedback error but not which testcase or taks its related to keeping the data anonymous.

@b-fein And for the concern to leak testcases which are marked with visibility NEVER or AFTER_DUE_DATE. These testcases will not be part of the feedback analysis table in the first place as the students do not receive any feedback for such tests. The table only summarizes active feedback which was provided to the students and for that to happen, test cases must have ran over sumbissions and graded them. As this is not the case for after due date test cases thus no feedback for students is really generated and will not be part of the table till the test case eventually runs after the due date. Thus instructors can not leak any informations really.

for the concern to leak testcases which are marked with visibility NEVER or AFTER_DUE_DATE.  These testcases will not be part of the feedback analysis table in the first place as the students do not receive any feedback for such tests.

@az108 This might only be true for Java tests where Ares does not execute them in the fist place. However, we still execute the tests but use the Artemis mechanism to hide the feedback from the students. The feedback then still is available to the tutor/instructors.
Minimal screenshots from our production instance. First one shows the test on the grading page, the second one the same test on the feedback analysis page with the feedback one column to the left not being shown.

@b-fein Hm alright i guess i can add a label or so in the follow up. Will discuss this with my advisors, thanks for mentioning it. Leaking any information should still not be an issue tho 👍


Failure to warn of possible numeric comparison with an optional function parameter

TypeScript Version:  2.1.4
I had an issue with Flow that it warned for no reason because I had an "if" to guard against undefined (https://github.com/facebook/flow/issues/2984) - so I tried TypeScript. TypeScript didn't warn - but it also didn't warn when I removed the if-guards!
Here is the code I used to check with TypeScript 2.1.4. Strict null checks are "true", see tsconfig.json below. I only get a warning about the unused const test.
Just to cover those cases I added a test at the top of the function to be outside the inner promise callback function - same result.
Code
'use strict';

const imap: {search(criteria: string[], cb: Function): void} = {
    search: (criteria, cb) => {}
};

const search = (from?: number, to?: number): Promise<number[]> => {
    // 1) NOT SAFE, "from" could be undefined:
    const test: boolean = from >= 4;

    return new Promise((resolve, reject) => {
        imap.search(
            ['ALL'],
            (err: Error, uids: number[]) => {

                // 2) NONE of this is safe, "from" could be undefined:
                const test: boolean = uids[0] >= from;
                uids = uids.filter((uid: number) => uid >= from);
                uids = uids.filter(function (uid: number) {
                    return uid >= from;
                });

            }
        )
    });
};

tsconfig.json:
{
    "compilerOptions": {
        "strictNullChecks": true,
        "alwaysStrict": true,
        "module": "commonjs",
        "noImplicitAny": true,
        "noImplicitReturns": true,
        "noImplicitThis": true,
        "newLine": "lf",
        "noLib": false,
        "noUnusedLocals": true,
        "removeComments": true,
        "preserveConstEnums": true,
        "sourceMap": true,
        "lib": ["ES2017"],
        "target": "ESNext"
    },
    "include": [
        "lib/*"
    ],
    "exclude": [
        "node_modules",
        "**/*.spec.ts"
    ]
}

Expected behavior:
Error: from, used in a numeric comparison, could be undefined.
Actual behavior:
No warnings or errors other than the one about the unused variable test.

The reason Flow correctly complains (although it over-complains) is that comparisons of a number against something that is not a number is useless. If you end up with an undefined on one side and your type system didn't warn you of that potential problem it didn't do its job as far as I'm concerned (and boy am I glad to be able to point to the Flow guys to show that I'm not alone). An undefined is an error should it occur in that position. If the code simply runs through, because the Javascript sure won't tell you about it, you may be in some trouble. Likely much later in the code, hard to debug.
So no (or yes), simply avoiding the problem by including an additional check for undefined but not doing anything about it is probably useless because it's just another way to turn off the alarm bell.
In the case of the above code example there should probably be an Error thrown, because comparing against something that isn't there should not have a legitimate result.
So the purpose of the type system warning the developer here would not be so that the developer then goes ahead and promptly ignores the warning actively, but is forced to raise the alarm if it happens during runtime - which the type system cannot do for him/her.

You get the expected errors with the current nightly drop. We tightened up checking of null and undefined in expression operators in #13483. It will be in the TypeScript 2.2 release.

Duplicate of #12795.

Perfect, thanks!


sublime package manager

When is this going to be available in Sublime? Why is it taking so long to get it into the manager? Is there another way to install it in Sublime without using the package manager?

sorry for the delay, you can track the status here

it is now :) https://packagecontrol.io/packages/GoGuru

Thanks for the info. And yes, it's available, and I love it. Good work!

From: Alvaro<EMAIL_ADDRESS>Sent: Monday, May 09, 2016 11:54
To: alvarolm/GoGuru
Cc<EMAIL_ADDRESS>Author
Subject: Re: [alvarolm/GoGuru] sublime package manager (#8)
it is now :) https://packagecontrol.io/packages/GoGuru
�
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com/alvarolm/GoGuru/issues/8#issuecomment-217905905


Por DOCs

I am using this project, I need to know how to use this with Django 2 and Python 3.7?

@Burnsedia You can take a look at the Demo project here: https://github.com/inoks/django-classified-demo


Make an official composer Docker container

Would be nice to have this as one of the "official" repositories available in Docker....

[ ] Create a new repository
[x] Update the documentation (similar to Backdrop's)
[ ] Add a PR to the official Docker library (similar to Backdrop's)
[x] Add container docs to the Docker Library (similar to Backdrop's)

This would be really awesome as part of the official library.
Could we also do PHP 7 versions before we add it to the official library?

I am rather surprised you dare call any of this "official", considering you did not even reach out to us and blatantly registered our name as your organization and use our logo for it.

@alcohol I've spoken with Seldaek about this, he found it best to keep the Docker container off the GitHub /composer org. By "official", what I mean have the repository live in the /docker-library org so that you use it as composer rather then composer/composer.

This is your project, so I'm not going to ask you to move it to our Github organization. I know Seldaek prefers not to endorse third party tools/components when he is not involved with them himself. I personally am quite fond of Docker though, and would like to contribute or be involved, if possible.
I am simply a bit baffled by the fact that you registered the composer organization on the docker hub, rather than simply asking us to proxy it for you.
I can imagine that releasing it under the composer namespace is a lot more attractive than releasing it under your personal namespace, but it is a somewhat questionable move.

I am simply a bit baffled by the fact that you registered the composer organization on the docker hub, rather than simply asking us to proxy it for you.

I added the Composer maintainers of who I found had Docker Hub accounts. There was lots of transparency behind it, across both IRC, and the issue queue. The project is almost two years old at this point, and its has been growing. Contributions from others like alpine support and supporting both PHP 5/7 helped keep it alive. I'd like for it to grow even further, if you have any ideas on a direction, feel free to propose them.
I've added you to both the GitHub and the Hub org. Feel free to help out in making this meet your expectations.

Cheers for the invitation. I do not recognize any of the other "owners" of the docker organization though, so I'm not sure who you added.
I'll have a closer look at my earliest convenience. The only possible addition/improvement I can think of from the top of my mind right now, is to create images based on Git tags, to provide a containerized counterpart for each version that is also offered at https://getcomposer.org/download/

For the alpine base Dockerfile you could consider using --no-cache instead of --update (read more).

I have some (possibly radical) changes to suggest and various other things I would like to discuss. Can I reach you on a medium that is a bit more direct than the Github issue tracker? E.g. Twitter DM, IRC, or some Slack channel?

Some slack channel would be great so other collaborators who use this and / or extend from this image can also be in the loop.

We could also use Gitter to keep it simple.


Magiclink explanation button hidden by toolbar on iphone 7

On iphone 7
And there's no option to scroll down.

see also #838
Need solution to take into account the iphone toolbar

I tested this issue locally, on gooddev and ewallet. Tested on IPhone 7 simulator and on real device. Cannot reproduce this issue. Woking well - as expected.
Screenshot:

Checked on the QA and eWallet environment
Used devices:
iPhone 7 // iOS 12.1.2 (physical)
iPhone 7 // iOS 11.4 (AWS device)
Work as expected. The button is fully visible.


Timer is slower than real time

I had the impression the timer was running slow.
Then I tried measuring this page, https://www.timer-tab.com/ on another tab and my phone timer for 1 hour. I got these times:

timer-tab and phone: 1:00:00
texthooker-ui: 44:53

It seems the timer runs slow. Is it possible to fix it?

just to confirm - you started the texthooker and then switched to the other tabs?
in that case you may encountered background throtteling/timer drifting. most browser stop or throttel interval executions when a page is not visible for the user for a specific time period (e. g. 5 minutes). The timer was a one by one incrementer which means if ticks are skipped the value can get wrong.. did not considered such cases as important tbh
If you say the timer is also wrong when the page is focused i probably need some more details of how your environment looks like (e. g. # of stored lines, settings etc.) as i don't see any difference between the page and a separate timer when checking
i also pushed a change to the timer to change how the value is caluclated.. maybe that will already be sufficient for your case.. let me know

Based, thank you


Mail transport support for Swiftmailer

Found that in some cases Sendmail method in Swiftmailer doesn't work but native Mail transport still does. Jobby could support this method as quick helper for that kind of situations.

Thanks! Should be in next release.