Add picture addition test

1.add picture_addition_kernel{m}x{n}_{sse,sse2}_intrin test
2.add picture_addition_kernel{m}x{n}_av1_sse2_intrin test
3.add picture_addition_kernel16bit_sse2_intrin test

dry_run_test @./Bin/Release/SvtAv1UnitTests --gtest_filter=PictureAddition

Add Picture addition test
Comments
warnings in Local build

linux:  ok
windows:  ok

warnings on remote ci servers

jenkins:
a. clang-format
b.
travis
a.  linux: ok
appvedor
a. no warnings

Test Plan:
Run the unit test with ./SvtAv1UnitTest --gtest_filter="*PictureAddition*", and check the result
dry run output
$ ./SvtAv1UnitTests.exe --gtest_filter="*PictureAddition*"
Running main() from C:\Users\Ryan\addPic\SVT-AV1\third_party\googletest\src\gtest_main.cc
Note: Google Test filter = *PictureAddition*
[==========] Running 30 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 30 tests from PictureAddition/PictureAdditionTest
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2 (2 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8 (2 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14 (1 ms)
[----------] 30 tests from PictureAddition/PictureAdditionTest (44 ms total)

[----------] Global test environment tear-down
[==========] 30 tests from 1 test case ran. (53 ms total)
[  PASSED  ] 30 tests.

dry_run_test @./Bin/Release/SvtAv1UnitTests --gtest_filter=PictureAddition

          1 Message

:book:
Running main() from /home/jenkins/workspace/SVTAV1-Linux-GCC-Dry-Run-Test/third_party/googletest/src/gtest_main.cc
Note: Google Test filter = PictureAddition
[==========] Running 30 tests from 1 test case.
[———-] Global test environment set-up.
[———-] 30 tests from PictureAddition/PictureAdditionTest
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14 (0 ms)
[———-] 30 tests from PictureAddition/PictureAdditionTest (2 ms total)
[———-] Global test environment tear-down
[==========] 30 tests from 1 test case ran. (2 ms total)
[  PASSED  ] 30 tests.

  Generated by :no_entry_sign: Danger

dry_run_test @./Bin/Release/SvtAv1UnitTests --gtest_filter=PictureAddition

          1 Message

:book:
Running main() from /home/jenkins/workspace/SVTAV1-Linux-GCC-Dry-Run-Test/third_party/googletest/src/gtest_main.cc
Note: Google Test filter = PictureAddition
[==========] Running 30 tests from 1 test case.
[———-] Global test environment set-up.
[———-] 30 tests from PictureAddition/PictureAdditionTest
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14 (0 ms)
[———-] 30 tests from PictureAddition/PictureAdditionTest (2 ms total)
[———-] Global test environment tear-down
[==========] 30 tests from 1 test case ran. (2 ms total)
[  PASSED  ] 30 tests.

  Generated by :no_entry_sign: Danger

Can one of the admins verify this patch?

dry_run_test @./Bin/Release/SvtAv1UnitTests --gtest_filter=PictureAddition

Danger has errored
[!] Invalid Dangerfile file: undefined method nodes for nil:NilClass
 #  from Dangerfile:1
 #  -------------------------------------------
 >  junit.parse "dryruntest-report.xml"
 #  junit.report
 #  -------------------------------------------

  Generated by :no_entry_sign: Danger

          1 Message

:book:

  Generated by :no_entry_sign: Danger

dry_run_test @./Bin/Release/SvtAv1UnitTests --gtest_filter=PictureAddition

Danger has errored
[!] Invalid Dangerfile file: undefined method nodes for nil:NilClass
 #  from Dangerfile:1
 #  -------------------------------------------
 >  junit.parse "dryruntest-report.xml"
 #  junit.report
 #  -------------------------------------------

  Generated by :no_entry_sign: Danger

dry_run_test @./Bin/Release/SvtAv1UnitTests --gtest_filter=PictureAddition

          1 Message

:book:
Running main() from /home/jenkins/workspace/SVTAV1-Linux-GCC-Dry-Run-Test/third_party/googletest/src/gtest_main.cc
Note: Google Test filter = PictureAddition
[==========] Running 30 tests from 1 test case.
[———-] Global test environment set-up.
[———-] 30 tests from PictureAddition/PictureAdditionTest
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14 (1 ms)
[———-] 30 tests from PictureAddition/PictureAdditionTest (2 ms total)
[———-] Global test environment tear-down
[==========] 30 tests from 1 test case ran. (2 ms total)
[  PASSED  ] 30 tests.

  Generated by :no_entry_sign: Danger

dry_run_test @./Bin/Release/SvtAv1UnitTests --gtest_filter=PictureAddition

          1 Error

:no_entry_sign:
Code style violations detected.

Code Style Check

Code style violations detected in the following files:

test/PictureAdditionTest.cc

Execute one of the following actions and commit again:

Run clang-format on the offending files
Apply the suggested patches with git apply patch.

test/PictureAdditionTest.cc
--- test/PictureAdditionTest.cc
+++ test/PictureAdditionTest.cc
@@ -191,7 +191,7 @@
         case ALL_RANDOM: {
             for (uint32_t i = 0; i < test_size_; i++) {
                 pred_[i] = rnd_uint8.random();
-				residual_[i] = residual_int32_[i] = rnd_int16.random();
+                residual_[i] = residual_int32_[i] = rnd_int16.random();
             }
             break;
         }
@@ -279,7 +279,7 @@
                        area_width_,
                        area_height_,
                        2);
-
+
         printf("width: %d, height: %d,pattern: %d   \n",
                area_width_,
                area_height_,

  Generated by :no_entry_sign: Danger

dry_run_test @./Bin/Release/SvtAv1UnitTests --gtest_filter=PictureAddition

          1 Message

:book:
Running main() from /home/jenkins/workspace/SVTAV1-Linux-GCC-Dry-Run-Test/third_party/googletest/src/gtest_main.cc
Note: Google Test filter = PictureAddition
[==========] Running 50 tests from 1 test case.
[———-] Global test environment set-up.
[———-] 50 tests from PictureAddition/PictureAdditionTest
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0
width: 4, height: 4,pattern: 0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1
width: 4, height: 4,pattern: 1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2
width: 4, height: 4,pattern: 2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3
width: 4, height: 4,pattern: 3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4
width: 4, height: 4,pattern: 4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5
width: 8, height: 8,pattern: 0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6
width: 8, height: 8,pattern: 1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7
width: 8, height: 8,pattern: 2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8
width: 8, height: 8,pattern: 3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9
width: 8, height: 8,pattern: 4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10
width: 16, height: 16,pattern: 0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11
width: 16, height: 16,pattern: 1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12
width: 16, height: 16,pattern: 2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13
width: 16, height: 16,pattern: 3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14
width: 16, height: 16,pattern: 4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/15
width: 32, height: 32,pattern: 0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/15 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/16
width: 32, height: 32,pattern: 1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/16 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/17
width: 32, height: 32,pattern: 2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/17 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/18
width: 32, height: 32,pattern: 3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/18 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/19
width: 32, height: 32,pattern: 4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/19 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/20
width: 64, height: 64,pattern: 0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/20 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/21
width: 64, height: 64,pattern: 1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/21 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/22
width: 64, height: 64,pattern: 2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/22 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/23
width: 64, height: 64,pattern: 3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/23 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/24
width: 64, height: 64,pattern: 4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/24 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/15
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/15 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/16
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/16 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/17
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/17 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/18
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/18 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/19
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/19 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/20
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/20 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/21
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/21 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/22
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/22 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/23
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/23 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/24
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/24 (0 ms)
[———-] 50 tests from PictureAddition/PictureAdditionTest (3 ms total)
[———-] Global test environment tear-down
[==========] 50 tests from 1 test case ran. (3 ms total)
[  PASSED  ] 50 tests.

  Generated by :no_entry_sign: Danger

          1 Message

:book:

  Generated by :no_entry_sign: Danger

          1 Message

:book:

  Generated by :no_entry_sign: Danger

          1 Message

:book:
Running main() from /home/jenkins/workspace/SVTAV1-Linux-GCC-Dry-Run-Test/third_party/googletest/src/gtest_main.cc
Note: Google Test filter = PictureAddition
[==========] Running 50 tests from 1 test case.
[———-] Global test environment set-up.
[———-] 50 tests from PictureAddition/PictureAdditionTest
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/15
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/15 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/16
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/16 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/17
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/17 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/18
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/18 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/19
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/19 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/20
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/20 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/21
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/21 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/22
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/22 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/23
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/23 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/24
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/24 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/15
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/15 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/16
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/16 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/17
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/17 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/18
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/18 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/19
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/19 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/20
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/20 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/21
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/21 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/22
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/22 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/23
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/23 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/24
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/24 (0 ms)
[———-] 50 tests from PictureAddition/PictureAdditionTest (3 ms total)
[———-] Global test environment tear-down
[==========] 50 tests from 1 test case ran. (3 ms total)
[  PASSED  ] 50 tests.

  Generated by :no_entry_sign: Danger

          1 Message

:book:

  Generated by :no_entry_sign: Danger

          1 Message

:book:

  Generated by :no_entry_sign: Danger

          1 Message

:book:

  Generated by :no_entry_sign: Danger

dry_run_test @./Bin/Release/SvtAv1UnitTests --gtest_filter=PictureAddition

          1 Message

:book:
Running main() from /home/jenkins/workspace/SVTAV1-Linux-GCC-Dry-Run-Test/third_party/googletest/src/gtest_main.cc
Note: Google Test filter = PictureAddition
[==========] Running 50 tests from 1 test case.
[———-] Global test environment set-up.
[———-] 50 tests from PictureAddition/PictureAdditionTest
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/15
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/15 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/16
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/16 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/17
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/17 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/18
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/18 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/19
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/19 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/20
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/20 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/21
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/21 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/22
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/22 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/23
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/23 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/24
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/24 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/15
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/15 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/16
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/16 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/17
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/17 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/18
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/18 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/19
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/19 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/20
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/20 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/21
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/21 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/22
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/22 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/23
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/23 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/24
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/24 (0 ms)
[———-] 50 tests from PictureAddition/PictureAdditionTest (3 ms total)
[———-] Global test environment tear-down
[==========] 50 tests from 1 test case ran. (4 ms total)
[  PASSED  ] 50 tests.

  Generated by :no_entry_sign: Danger

          1 Message

:book:

  Generated by :no_entry_sign: Danger

dry_run_test @./Bin/Release/SvtAv1UnitTests --gtest_filter=PictureAddition

          1 Message

:book:
PASS

  Generated by :no_entry_sign: Danger

          1 Message

:book:
PASS

  Generated by :no_entry_sign: Danger

          1 Message

:book:
Running main() from /home/jenkins/workspace/SVTAV1-Linux-GCC-Dry-Run-Test/third_party/googletest/src/gtest_main.cc
Note: Google Test filter = PictureAddition
[==========] Running 50 tests from 1 test case.
[———-] Global test environment set-up.
[———-] 50 tests from PictureAddition/PictureAdditionTest
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/6 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/14 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/15
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/15 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/16
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/16 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/17
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/17 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/18
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/18 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/19
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/19 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/20
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/20 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/21
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/21 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/22
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/22 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/23
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/23 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAdditionTest/24
[       OK ] PictureAddition/PictureAdditionTest.PictureAdditionTest/24 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/0 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/1 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/2 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/3 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/4 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/5 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/6 (1 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/7 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/8 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/9 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/10 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/11 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/12 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/13 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/14 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/15
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/15 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/16
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/16 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/17
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/17 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/18
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/18 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/19
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/19 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/20
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/20 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/21
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/21 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/22
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/22 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/23
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/23 (0 ms)
[ RUN      ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/24
[       OK ] PictureAddition/PictureAdditionTest.PictureAddition16bitTest/24 (1 ms)
[———-] 50 tests from PictureAddition/PictureAdditionTest (3 ms total)
[———-] Global test environment tear-down
[==========] 50 tests from 1 test case ran. (4 ms total)
[  PASSED  ] 50 tests.

  Generated by :no_entry_sign: Danger

merged, close it.


External Service Task handling with Camel

My current customer, could have used a way to let Camel behave as an external task worker, i.e. fetch tasks from Camunda and report back on them once they are completed or when errors occurred.

Hi Falko,
I not sure what your issue is about. Maybe this could help you: https://github.com/RasPelikan/camunda-bpm-camel/tree/ExternalTasksConsumer?files=1
I extended the Camel extension right in that way. It is already reviewed by Bernd Rücker. At the moment I'm doing the last refactoring based on this review. Afterwards it can be merged and released. I can do that within the next week.
Stephan

Hi Stephan,
that's exactly what I have been looking for. I would be happy to see
that merged.
Cheers,
Falko

I have it on my radar - I hope to get to it soon after the roadshow!

The feature is part of release 0.5.0, in the meantime available since end of february. There is also a blog post about it and detailed documentation in the current README.MD.


CDPS-176 - completed active punishments page

Thanks for the feedback @davidmiddletonmoj - ready for another review / approval


Adds ReviewKit to list of projects!

Project URL

https://github.com/simonmitchell/ReviewKit
Category

Utility
Description

ReviewKit allows you to prompt users for review at the ideal time, based on whether they are having a good experience in your app.
Why it should be included to awesome-ios (mandatory)
ReviewKit seems to be the only (If not, at least the most extensive) framework out there that tries to achieve gatekeeping review prompts in this way. It is versatile, customisable, and supports heavy customisation (Is very generic). Whilst it is simple in nature, it is very powerful tool.
Checklist

[ ] Has 50 GitHub stargazers or more
[x] Only one project/change is in this pull request
[x] Isn't an archived project
[ ] Has more than one contributor
[x] Has unit tests, integration tests or UI tests
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

I'm aware this is a controversial topic even amongst the developer community, however I created this library as a lesser of two evils: We have a lot of clients who REQUIRE us to prompt users for reviews, and at least if we make sure they're having a good time, then they're not asked for an annoying review when they are already having a bad experience with the app!

Hey @simonmitchell, thanks for contributing! I loved the score system!

Cheers! It's recently gone out in a release of one of my apps, so hoping it'll make a difference to my average review! :D

@simonmitchell Thanks for contributing!

@vsouza no worries, thanks for adding it in! :D


License?

I noticed that a license text in a file / README / source code is missing. Can you also clarify that?

I'm researching a little as for which license to use on the repo, I want it to be MIT, but I need to check the licenses of some of the dependencies.
A proper license file will be up before or at the time of releasing the demo/alpha/pre-alpha (I'm not sure how to call it yet :D) in the following days.

License file has been created. It's MIT.

Don't forget to change the headers of the source code, which contain references to other licenses (GPL, MIT, etc..)

Sure, will do, thanks!

I put a license for the project that I think will not conflict with licenses of dependencies, I'm closing this issue now.
Thanks!


Creating image grid card home pages for User Guides and DEA Notebooks

[x] I have spellchecked my content using Microsoft Word, Grammarly, or otherwise.
[ ] If required, update the DEA Tech Alerts and Changelog and the DEA Sandbox Updates banner.

@robbibt You may want to view this PR
https://pr-263-preview.khpreview.dea.ga.gov.au/guides/
https://pr-263-preview.khpreview.dea.ga.gov.au/dea-notebooks/


Support co annotation analysis

fixes #7
I'm not clear about how to choose the predicates mentioned in the ticket;

set(X) cluster_overlaps set(Y)
set(X) cluster_matches set(Y)
set(x) subcluster_of set(y)

I've added the table without the predicates.

@dosumis @hkir-dev
Can I merge this now with the recent changes?


[Quickdraw] I am here to learn how to open and close issues on Github! 🤠

I am here to learn how to open and close issues on Github! 🤠
I will close it in 10 seconds 🤞

Review it

Following the neccessary steps


HEAD method needs to be added to 2.0 templates route

@codenrhoden discovered this issue.
Centos install fails because wget —spideruses the HEAD method on the templates route which is not currently supported in the 2.0 API.
http: HEAD 405 19.695 - /api/current/templates/renasar-ansible.pub

Error: Path [/templates/{name}] defined in Swagger, but HEAD operation is not

Thanks @brianparry
And just for clarification, I found this when using Graph.InstallCoreOS, so CoreOS, not CentOS. I just brought up CentOS since it uses the same wget command, and so I think it would fail as well.

Closing as PR (https://github.com/RackHD/on-http/pull/437) has been merged.


Gateway::Status::Addresses has a new unique type []GatewayStatusAddress

/kind cleanup
/area api
What type of PR is this?

What this PR does / why we need it:

This allows the status.addresses type to evolve separately from the spec type (eg. to support GEP-1651)
This came up a bunch of times in meetings/PR reviews
Notable changes from the GatewayAddress (used in spec)

Type field is required to be set (dropped +optional)

Does this PR introduce a user-facing change?:

v1beta1.Gateway Spec.Addresses is now a new Go type []GatewayStatusAddress

I'd like some input from the maintainers that  dropping +optional on the Type field is what we want when listing addresses in the Status

I'd like some input from the maintainers that dropping +optional on the Type field is what we want when listing addresses in the Status

This is a bit of a strange detail in CRDs. For defaulting to work properly, a field has to be marked as optional. So although the type is technically optional, the end result should never be empty since a default will be applied:
https://github.com/kubernetes-sigs/gateway-api/blob/f13c905b462733d4c629fe53c736fd40581a73d5/apis/v1beta1/gateway_types.go#L462-L464

For defaulting to work properly, a field has to be marked as optional.

Good point. I guess the question is when implementors update the status block with addresses do we want to require this field to be explicit - or like on GET default to 'IPAddress'?

the question is when implementors update the status block with addresses do we want to require this field to be explicit - or like on GET default to 'IPAddress' if empty?

Unfortunately we can only loosen validation, we can't go in the other direction. So in this case, even if we wanted to make this require input from implementations, we can't in a backwards compatible way.
Potentially useful - k8s defaulting happens on writes, so it should be a bit more persistent/reliable than a read-based system.

Thanks @dprotaso! This PR makes sense to me, but I want to make sure more meaningful related changes make it in before merging this one. IE we should probably only split this out in the same release as we're introducing new fields to GatewayStatusAddress. Adding a temporary hold until we can get that lined up as well.
/hold

rebased

Thanks @dprotaso! Looks like the other pieces are coming together, will leave hold in place until everything is ready.
/approve

Thanks @dprotaso! Everything for this GEP looks to be lined up well. All the other PRs LGTM and have other approvals or LGTMs, will merge in sequence.
/hold cancel
/lgtm


[Question] Inquiry about estimation of training memory size for mixed precision training

Hello Accelerate team,
I am exploring the memory estimation logic for mixed precision training implemented in estimate.py
and I have a question regarding the assignment of memory sizes.
In the code, the memory sizes are set as follows:
memory_sizes["model"] = fp32_size
memory_sizes["gradients"] = fp32_size + fp16_size
memory_sizes["optimizer"] = fp32_size * 2
However, according to the paper "ZeRO-Offload: Democratizing Billion-Scale Model Training", the memory requirements for different types of data (parameters, gradients, momentums, variances) in a mixed precision setting are different:
parameter16
gradient16
parameter32
momentum32
variance32
Based on this paper figure 2, if model parameters are assumed to be $\alpha$ GB, then the memory requirement should be 16* $\alpha$ (2+2+4+4+4=16)GB.
However, in the paper "ZeRO-Infinity: Breaking the GPU Memory Wall for Extreme Scale Deep Learning", section 3 specifies that each parameter requires 20 bytes of memory.
I am quite confused about this.
Could you please clarify the calculation of each memory_sizes entry in your code?
Thank you for your time and assistance.
https://github.com/huggingface/accelerate/blob/c0a37015e3e4f2ab78a35efd6462e5b5140cf46e/src/accelerate/commands/estimate.py#L215-L247
Reference:
ZeRO-Offload: Democratizing Billion-Scale Model Training
ZeRO-Infinity: Breaking the GPU Memory Wall for Extreme Scale Deep Learning
https://github.com/microsoft/DeepSpeed/issues/1137
Who can help?
@muellerzr
@SunMarc

Need to be addressed.

hi, this confued me too. And do you figure it out now?   @callanwu

hi, this confued me too. And do you figure it out now? @callanwu

@bbruceyuan Hi, I think it depends on the type of gradient used by the optimizer, such as torch.float32, torch.float16, and torch.bfloat16.
Perhaps you can refer to the official PyTorch documentation on _fused_doc for more details.


(1062) Make postcode region check more forgiving

Also tweak some of the copy to make it clearer what we're asking for. @selina-dxw / @beth-dixxon  - would be good to get some feedback from a content/design POV too
Screenshots

 Post code snag

Can we try the following hint text: "Please provide the postcode area only. To get the postcode from the full postcode remove the last 3 characters. For example, the postcode area for SW1A 0AA is SW1A."
To replace 'For example, SW1' in the first screenshot, and 'Please provide...' in the second.


Support minimal error type

os.Open should return  an error on error, and callers should catch it.

Done


Expose tig in Prior Art section of README

As this is essentially a simpler version of https://github.com/jonas/tig, it would be for glorious benefit of all perhaps to have a Prior Art section, and tell people about this tool, too.

The function of the README is to give a new user an introduction the to program and
give instructions on how to build, run and participate. It's a place to showcase this program, not other, unrelated but similar programs.
While I also find tig to be a useful tool, I don't think the README should be used for anything but to showcase this particular project.

In communities where it's common, I find projects that list other similar projects (perhaps with a note on differences) are usually better quality, and I look for that when evaluating projects.


Mirror socrates repository

keyword_TIWG resolution_fixed   |    by<EMAIL_ADDRESS>
The UM radiance has been moved to a new repository on code.metoffice.gov.uk
http://collab.metoffice.gov.uk/twiki/bin/viewfile/Static/News/met-office/um-collab/um/general/msg00422.html
This needs to be added to the mirror & FCM configuration

Issue migrated from trac:185 at 2024-01-31 17:43:14 +1100

<EMAIL_ADDRESS>commented

Branch: [/log/puppet?rev=saw562/socrates saw562/socrates]

<EMAIL_ADDRESS>commented

This is now working on Accessdev-test. I've redone the FCM configuration file so that new repositories can now be added by editing hieradata/project.yaml.
Some keywords are automatically set up by fcm (e.g. fcm:um_tr and fcm:um_br) so they've not been added to the config file. I've also not specified version keywords since FCM can get those from the repository properties.
The extract stage of rose stem works fine both for the Socrates branch in um:#464 and trunk.
Martin, can you please take a look before I apply this to accessdev?
Thanks, Scott

<EMAIL_ADDRESS>changed owner from saw562 to mrd599

<EMAIL_ADDRESS>changed status from new to assigned

<EMAIL_ADDRESS>commented

fcm working ok for me.

<EMAIL_ADDRESS>changed status from assigned to accepted

Scott Wales<EMAIL_ADDRESS>changed status from accepted to closed

<EMAIL_ADDRESS>changed owner from mrd599 to saw562

<EMAIL_ADDRESS>commented

Ok, I'll send out a notice to the mail list and install it.

Scott Wales<EMAIL_ADDRESS>changed resolution from `` to fixed

Scott Wales<EMAIL_ADDRESS>committed [0]

In [changeset:"0c2ad1ca1ca492308d15cad820d4e244581e9545/puppet"]:
#CommitTicketReference repository="puppet" revision="0c2ad1ca1ca492308d15cad820d4e244581e9545"
Fix #185: Simplify FCM config, add Socrates

Merge branch 'saw562/socrates'


Cannot show citeBy with the tutorial example

Cannot show citeBy with the tutorial example:
search_query = scholarly.search_pubs_query('Perception of physical stability and center of mass of 3D objects')
print(next(search_query))
output:
{'_filled': False,
'bib': {'abstract': 'Humans can judge from vision alone whether an object is '
'physically stable or not. Such judgments allow observers '
'to predict the physical behavior of objects, and hence '
'to guide their motor actions. We investigated the visual '
'estimation of physical stability of 3-D objects (shown '
'in stereoscopically viewed rendered scenes) and how it '
'relates to visual estimates of their center of mass '
'(COM). In Experiment 1, observers viewed an object near '
'the edge of a table and adjusted its tilt to the '
'perceived critical angle, ie, the tilt angle at which '
'the object …',
'author': 'SA Cholewiak and RW Fleming and M Singh',
'eprint': 'https://jov.arvojournals.org/article.aspx?articleID=2213254',
'title': 'Perception of physical stability and center of mass of 3-D '
'objects',
'url': 'https://jov.arvojournals.org/article.aspx?articleID=2213254'},
'source': 'scholar'}

The search results are probably displayed in a different language than English for you, so the data is not found as the link text is expected to be in English.
Extending the query string for _PUBSEARCH with "hl=en" worked for me. See:
https://github.com/OrganicIrradiation/scholarly/pull/45

I set _PUBSEARCH = '/scholar?q={0}&hl=en', but still cannot show citeBy

Hi All,
I solved with _KEYWORDSEARCH = '/citations?view_op=search_authors**&hl=en**&mauthors=label:{0}'

All the different search URL options in scholarly.py need the hl=en; e.g.:
_CITATIONAUTH = '/citations?user={0}&hl=en'
_CITATIONPUB = '/citations?hl=en&view_op=view_citation&citation_for_view={0}'
_KEYWORDSEARCH = '/citations?view_op=search_authors&hl=en&mauthors=label:{0}'
_PUBSEARCH = '/scholar?hl=en&q={0}'
_SCHOLARPUB = '/scholar?oi=bibs&hl=en&cites={0}


withRouter(withTracker(... not working in 5.2

Version
5.2
Test Case
none
Steps to reproduce

Have a Meteor app that is using the withRouter(withTracker(... syntax and working properly with ReactRouter 4.3.1 or 5.1
Routes defined like this:

  <BrowserRouter>
    <Switch>
          <Authenticated exact name="index" path="/" component={App} {...props} />
          <Authorized exact allowedRoles={['admin']} path="/admin" pathAfterFailure="/" component={AdminHome} setAfterLoginPath={setAfterLoginPath} {...props} {...state} />

Where Authorized looks like this:
class Authorized extends React.Component {
. . .
  render() {
    const {
      component, path, exact, ...rest
    } = this.props;

    return (this.state.authorized ? (
      <Route
        path={path}
        exact={exact}
        render={props => (React.createElement(component, { ...rest, ...props }))}
      />
    ) : <div />);
  }
}
. . .
export default withRouter(withTracker(({ allowedRoles, allowedGroup }) => { // eslint-disable-line
  return Meteor.isClient ? {
    loading: Meteor.isClient ? !Roles.subscription.ready() : true,
    userId: Meteor.userId(),
    userRoles: Roles.getRolesForUser(Meteor.userId()),
    userIsInRoles: Roles.userIsInRole(Meteor.userId(), allowedRoles, allowedGroup),
  } : {};
})(Authorized));

Update with npm i<EMAIL_ADDRESS><EMAIL_ADDRESS>
Expected Behavior
It still works.
Actual Behavior
This error: You should not use <Route> outside a <Router>
and in the devtools console, the stack says that it's doing things with "withRouter(undefined)"

I think I'm reporting a bug that 5.2 doesn't work when 4.3.1 and 5.1 do work, regarding withRouter(withTracker(...

Looks like an error with withTracker() and not with RR

You think? It works fine in RR 4.3.1 and 5.1, but updating to 5.2 breaks it w/o changing any code?


Raspberry PI 4 only showing 1gb memory

Hi
I may have misunderstood something and i know the rpi4 image is alpha/beta. But here goes.
I have a 2gb rpi4. But both /proc/meminfo and top only shows total 923mb memory. I checked with noobs and it shows almost 2gb there.
dmesg:
[    0.000000] Booting Linux on physical CPU 0x0
[    0.000000] Linux version 4.19.58-v7l (builder@92b316513952) (gcc version 7.4
.0 (Buildroot 2019.02.3-ge5734a90)) #1 SMP Tue Jul 16 20:31:47 UTC 2019
[    0.000000] CPU: ARMv7 Processor [410fd083] revision 3 (ARMv7), cr=30c5383d
[    0.000000] CPU: div instructions available: patching division code
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, PIPT instruction cache
[    0.000000] OF: fdt: Machine model: Raspberry Pi 4 Model B Rev 1.1
[    0.000000] Memory policy: Data cache writealloc
[    0.000000] cma: Reserved 64 MiB at 0x0000000037400000
[    0.000000] On node 0 totalpages: 242688
[    0.000000]   DMA zone: 1728 pages used for memmap
[    0.000000]   DMA zone: 0 pages reserved
[    0.000000]   DMA zone: 196608 pages, LIFO batch:63
[    0.000000]   HighMem zone: 46080 pages, LIFO batch:15
[    0.000000] random: get_random_bytes called from start_kernel+0xc0/0x4e4 with
 crng_init=0
[    0.000000] percpu: Embedded 18 pages/cpu s41036 r8192 d24500 u73728
[    0.000000] pcpu-alloc: s41036 r8192 d24500 u73728 alloc=18*4096
[    0.000000] pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3
[    0.000000] Built 1 zonelists, mobility grouping on.  Total pages: 240960
[    0.000000] Kernel command line: zram.enabled=1 zram.num_devices=3 apparmor=1
 security=apparmor rootwait cgroup_enable=memory coherent_pool=1M 8250.nr_uarts=
0 cma=64M bcm2708_fb.fbwidth=0 bcm2708_fb.fbheight=0 bcm2708_fb.fbswap=1 smsc95x
x.macaddr=DC:A6:32:01:F5:39 vc_mem.mem_base=0x3ec00000 vc_mem.mem_size=0x4000000
0  dwc_otg.lpm_enable=0 console=tty1 root=PARTUUID=8d3d53e3-6d49-4c38-8349-aff68
59e82fd rootfstype=squashfs ro rauc.slot=A
[    0.000000] Dentry cache hash table entries: 131072 (order: 7, 524288 bytes)
[    0.000000] Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)
[    0.000000] Memory: 877452K/970752K available (10240K kernel code, 722K rwdat
a, 2580K rodata, 2048K init, 863K bss, 27764K reserved, 65536K cma-reserved, 118
784K highmem)
[    0.000000] Virtual kernel memory layout:
[    0.000000]     vector  : 0xffff0000 - 0xffff1000   (   4 kB)
[    0.000000]     fixmap  : 0xffc00000 - 0xfff00000   (3072 kB)
[    0.000000]     vmalloc : 0xf0800000 - 0xff800000   ( 240 MB)
[    0.000000]     lowmem  : 0xc0000000 - 0xf0000000   ( 768 MB)
[    0.000000]     pkmap   : 0xbfe00000 - 0xc0000000   (   2 MB)
[    0.000000]     modules : 0xbf000000 - 0xbfe00000   (  14 MB)
[    0.000000]       .text : 0x(ptrval) - 0x(ptrval)   (12256 kB)
[    0.000000]       .init : 0x(ptrval) - 0x(ptrval)   (2048 kB)
[    0.000000]       .data : 0x(ptrval) - 0x(ptrval)   ( 723 kB)
[    0.000000]        .bss : 0x(ptrval) - 0x(ptrval)   ( 864 kB)
[    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1
[    0.000000] ftrace: allocating 31797 entries in 94 pages

meminfo:
MemTotal:         945036 kB
MemFree:           27316 kB
MemAvailable:     288636 kB
Buffers:           33496 kB
Cached:           182256 kB
SwapCached:         1312 kB
Active:           367512 kB
Inactive:         329552 kB
Active(anon):     228620 kB
Inactive(anon):   245916 kB
Active(file):     138892 kB
Inactive(file):    83636 kB
Unevictable:           0 kB
Mlocked:               0 kB
HighTotal:        184320 kB
HighFree:            260 kB
LowTotal:         760716 kB
LowFree:           27056 kB
SwapTotal:        236256 kB
SwapFree:          71404 kB
Dirty:               448 kB
Writeback:             0 kB
AnonPages:        480364 kB
Mapped:           131848 kB
Shmem:               104 kB
Slab:             123332 kB
SReclaimable:      54232 kB
SUnreclaim:        69100 kB
KernelStack:        5248 kB
PageTables:         8504 kB
NFS_Unstable:          0 kB
Bounce:                0 kB
WritebackTmp:          0 kB
CommitLimit:      708772 kB
Committed_AS:    3548144 kB
VmallocTotal:     245760 kB
VmallocUsed:           0 kB
VmallocChunk:          0 kB
Percpu:             1296 kB
CmaTotal:          65536 kB
CmaFree:               0 kB

I guess it has something to do with vc_mem.mem_size=0x40000000

Just to make sure i tried with the 64bit image. No change.
I also tried updating the firmware files (bcm2711-rpi-4-b.dtb, start4.elf and fixup4.bin). Also no change.
The vc_mem.* cmdline options comes from start4.elf and is related to how much memory VideoCore gets AFAIK. But I can't for the life of me find any way to override it. I was pretty sure it had something to do with gpu_mem in config.txt but changing that only seems to make even less system memory available.

Yeah, it's strange because we use the same kernel and firmware as raspbian... Maybe there is a systemd script they change the available memory after boot

@pvizeli That would be my guess. That or a kernel param. Given the memory varrieties (1, 2, 4GB) They have to do something to detect what is being run and update the available memory sometime at boot.

Could it have something to do with dtb overlays?
https://github.com/raspberrypi/linux/blob/618fb8f1d333fbde5695a8086ca9db15d0e72af2/arch/arm/boot/dts/bcm2711-rpi-4-b.dts#L11
https://android.googlesource.com/kernel/msm/+/android-msm-hammerhead-3.4-kk-r1/Documentation/devicetree/bindings/memory.txt

Since we use the device tree from first stage boot loader aka firmware and also they kernel parameters, we handle the startup exact like raspbian. I think it should be deeper on init system maybe?

I found this: https://github.com/raspberrypi/linux/issues/3032

Anyone found a fix for this? I also have only 932MB out of 2GB and MemSwap is running at 100%. Would be great to use all the RAM.
The RPi 4 is otherwise massively better/faster than the RPi 3B+

Perhaps we can post this issue in the main Raspberry Pi dev? Shouldn't it be something simple as a setting?

Will try later this week an firmware update. Maybe it's fix now

Where is available new FW ?

In buildroot-patch folder

Please give me link....

https://github.com/home-assistant/hassos/tree/dev/buildroot-patches

But option to download file and upload it ?

I check and also on RPI4 with 4GB RAM in Hassio show me only 1GB.

Hi guys!
I just bought an RP4 with 4 GB and I notice that the same thing happens to me (64-bit version of hass.io).
Did anyone manage to solve the problem?
Thank you!

Woohoo looks like it got fixed in the latest pull request. When do you think it will be pushed live :)

Fix with: https://github.com/home-assistant/hassos/pull/459


Unable to add middleware to any PAGE request

Is your feature request related to a problem? Please describe.
I installed the lib to add a threadLocal like behavior to any of my pages : storing request scoped variables to use throughout the request processing. I needed the lib to init the variables at page request and clean them after the page is processed. I cannot find any way to use the lib for any page (like a app.all() in expressjs)
Describe the solution you'd like
I would like to apply the middleware to any page rendering
Describe alternatives you've considered
I can use nextjs middleware rewrites
Additional context
Also, note it is not easy from the docs to understand you only handle API requests, I lost some time before I realized it

Hi @ziedHamdi – next-api-middleware is a library specifically written for use with Next.js API routes. It is not configured for use with Next.js pages.
Since the time that this library was created, the Next.js team has created a different kind of Middleware solution that could be used with pages. I would suggest taking a look at that to see if it can meet your needs!
Per your comment about the docs:

Also, note it is not easy from the docs to understand you only handle API requests, I lost some time before I realized it.

Do you have any suggestions on how I could make it clearer that this library is only for API routes?

Ok thanks for the link Hunter


Update quotas copies

https://github.com/CartoDB/cartodb/pull/14927#issuecomment-499002972

Public maps quota error / Duplicating a public map
New copy proposal:
Your map couldn't be created or updated
You have reached the limit of public maps for your plan
Make some of your maps private or upgrade your account to get unlimited public maps


syz-ci/jobs: improve log message

Display kernel repo's URL and branch if a commit cannot be found
in getCommitInfo().
Signed-off-by: Alexander Egorenkov<EMAIL_ADDRESS>
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md

@googlebot I signed it!

odd, i'm not recognized anymore :(

Your other commits come from Alexander.Egorenkov@, but this comes from egorenar@linux. At least that's what CLA bot thinks.

Your other commits come from Alexander.Egorenkov@, but this comes from egorenar@linux. At least that's what CLA bot thinks.

Thanks, fixed. Too many repos, sigh.


ROI Issue

Hi team, I need help
Thank you for an amazing job, can you please help, how to limit ROI in certain border values, for example I want my ROI in output to be in range that I think it should be even if model is not that good considering DECOMP.RSSD и NRMSE, for example Robyn shows ROI to be 0.5 with R2 0.95, I want ROI to be 2 with R2 that might be less
Environment & Robyn version
Robyn version: ‘3.8.2’
R version 4.2.2 (2022-10-31)

Hi @ElijahHoff
The best way would be to provide experimental results measuring incrementality for that specific media channel, that way Robyn will also minimize the MAPE via the multi-objective optimization and get rid of (~90%) models that are further away from the measured true incrementality for a time period. If the ROI is truly close to 2, then that's the output you'll get.
Do check calibration section in our features documentation to read more about this feature and methodology.

Robyn can't just "give you" the ROI you want. If the media is a straight line (same spend every day), it's impossible to get any effect, not even with calibration. It's a regression model and can't guarantee effect sizes. But calibration is definitely the right way to go if you have strong believe about a certain effect size for a certain channel/period (e.g. from causal experiments).

Hi @gufengzhou, @gufengzhou , can you help with an example of calibration? Where do I get following data from - # Provided value must be tested on same campaign level in model and same metric as dep_var_type
liftAbs = c(400000, 300000, 200000),
This liftAbs is just something that I have no Idea about? How to get/calculate this data?

Sure. Let's say you have FB as a media variable in Robyn. Calibration means you can use result from other methods/tools to "guide" Robyn. Usually we recommend running an experiment. For FB, for example, there's conversion lift study that you can run, which is a randomised controlled experiment. We generally believe that randomised studies are the only way to approach causal effect, thus it's a good idea to use study result to calibrate MMM. If your study has the same spend in the same period than in Robyn, then you can just use the study result as liftAbs. For more details see here

Please reopen if necessary


Update document

Hi,
first: This is a great tool! Thank you so much.
While developing an application new translation units will be created.
Those translation units should be translated too, but the translater won't want to re-enter all the translations he did before.
Is there a way to update a project with a new translation file without loosing the changes made before?

Unfortunately there is no direct way to do this in the moment.
In my workflow I always use it in combination with xliffmerge, which is done for the merge process.
So I export my translation, put it into the project, rerun the extraction process and import the merged file into tiny-translator again (as a new project).

ok thanks did not see that package yet.
But if it does the job, wouldn't it be possible to integrate it into tiny-translator? Just a fix idea without any knowledge of your code.

It would be possible definitely.
And I already thought about doing it.
It is not very difficult to do it.
But up to now there was no real neccessity, so the priority is not very high.


tests: fork logic for e2e tests

Closes: #XXX
What is the purpose of the change
Adds ability to test forks instead of only vanilla upgrades. @p0mvn and I agreed that for now we will hardcode a height gate of 60, and later find a better way to change this value based on state (number of validators present)
Brief Changelog

adds isFork bool
changes testing logic when isFork is set to true

Testing and Verifying
This change is already covered by existing tests
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? not yet
How is the feature or change documented? not applicable

Now that the genesis fix is merged to our sdk fork I was able to complete the fork upgrade logic. At this point however I need to refactor it again in order to catch up with the spike you did @p0mvn. After that I will be good for review!

I know this is a draft but I thought of a few suggestions when replying to an earlier discussion. Hope you don't mind

No problem, thank you! I first need to get past these permission issues (I think I just need to modify the fork height directly from the init function instead of after. Really annoying how it will pass locally but then will fail on GitHub 😢 ), then I will address your comments

Once this gets merged, going to follow this up with already completed PR for switching to v10 upgrade to v11 logic instead of v8 to v10 which we are doing now (also fixes a couple of upgrade logic bugs that got introduced from this PR)


Better support for replaying proxyAlways proxies

Right now when you use proxyAlways, it's up to you to remove the proxy in front of the saved responses before replaying.  I'd like a way for the user to have mountebank do that for them.  I think the following makes sense:
Add ?removeProxies=true to GET /imposters and GET /imposters/3000, which works in conjunction with ?replayable=true.  This would remove all proxy responses from the responses array from the returned representation.

completed as of a2606f1


Websocket get all clients

how can I get all connected users via ws for later changing the data of these users?

Hi, hyper-express is an unopinionated webserver library hence it does not track the connections internally. However, you can easily implement your own tracking like below:
import crypto from 'crypto';

// We will store connections in this
const connections = new Map();

// Listen for ws connections
server.ws('/connect', (ws) => {
    // Generate a random ID for this connection
    const id = crypto.randomUUID();

    // Track this connection
    connections.set(id, ws);

    // Clean up the connection once disconnected
    ws.once('close', () => {
        // Delete the connection
        connections.delete(id);
    });
});

Thanks


Filter: opened today?

Similar to setting a filter for minimum veg-type (vegan / vegetarian and so on) I want to filter for restaurant that are open today.
It should show only restaurants that are open now or in the future today, but not today closed restaurants or already closed ones.

Good idea :+1:

I'm working on it.

BTW please check my latest colors update: https://github.com/bluszcz/VeggieSailor/commit/f962988480eca179449c8a0b94b53c95b1d03ec1

Yes noticed that one ;-) Currently merging. Opening hours is little bit harder as the object from api is not very cool to parse. Will do that later. Now preparing this small refactor + city page improvements pullrequest for now.

I think it would be good to have date parsing made in model - python part done

Makes sense :+1:
Would be good to have a easy to parse date model in qml/js.
Something like: Array of 7 days (Starting day monday?) with array of timeareas in 24h time.
[ [{from:1000, to:1400}, {from:1600, to:2100}],  \that's monday
[{from:1000, to:1400}, {from:1600, to:2100}], \thuesday and so on
[] // Wednesday closed --> empty array of timeareas
..
]

Ok, I ill look into it.

hours_parsed is available now.

Working on the frontend filter part.

hours_parsed for a entry just contains: {"objectName":"","count":7,"dynamicRoles":false}
instead of the array.

hours_parsed seems to be an QQmlListModel and not a simple plain javascript array. JSON.stringify resolves it just to: {"objectName":"","count":7,"dynamicRoles":false}

Hm, checking.

Not sure if pyotherside makes good translation nested lists from python to javascript...
On python side it looks as correct result, not sure what is wrong:
$ python3 listmodel.py
[{'days': 'Daily', 'hours': ['8pm - 12:30pm']}]

gives

 [[{'to': '2430', 'from': '2000'}], [{'to': '2430', 'from': '2000'}], [{'to': '2430', 'from': '2000'}], [{'to': '2430', 'from': '2000'}], [{'to': '2430', 'from': '2000'}], [{'to': '2430', 'from': '2000'}], [{'to': '2430', 'from': '2000'}]]

Actually I have just debug it and JSON.stringify  says:
hours_parsed":[[{"from":"1100","to":"2400"}],[{"from":"1100","to":"2400"}],[{"from":"1100","to":"2400"}],[{"from":"1100","to":"2400"}],[{"from":"1100","to":"2400"}],
[{"from":"1100","to":"2400"}],[{"from":"1100","to":"2400"}]]

I put in Entries.qml:
    function showEntries(entries) {
        loadingData = false;
        listModel.clear();
        for (var i=0; i<entries.length; i++) {
            if(entries[i].veg_level >= minimumVegLevel) {
                listModel.append(entries[i]);
                console.log(JSON.stringify((entries[i])));
            }

        }

So I think it is working and ready to frontend implementation.

Cool, will look into this these days! :+1:


Comparison of text_sort_key inconsistent

Just scanning through the code I'm highly doubtful about this: https://github.com/tzlaine/text/blob/091143ea3502a0955148bb95ac22e364753aebec/include/boost/text/collate.hpp#L93-L123
E.g. Why is operator>= using compare which none of the others do and why is operator<= using boost::text::v1::compare? It seems those 2 are the same, but one is fully qualified?
Also compares docu says Returns 0 if the given sort keys are equal, a value < 0 if lhsis         less thanrhs, and a value > 0 otherwise. so why is only <0 (or >0) checked in <= and >=?

Sloppiness!  Looks like I have copy/paste error in the difference between op<= and op>=.  They respectively should just use !(rhs <lhs) and !(lhs <rhs).


Support Privacy Enhanced Mode

Motivation
It seems that YouTube has an option for "privacy enhanced" embedded videos:
https://support.google.com/youtube/answer/171780?hl=en#zippy=%2Cturn-on-privacy-enhanced-mode
Please consider supporting privacy enhanced embedded videos as a configuration option.
(I haven't investigated whether this is an easy change or not.)

Hi @jackpal
The "privacy enhanced" mode is currently not a configuration parameter of the YouTube Player iFrame API (https://developers.google.com/youtube/player_parameters)
The "privacy enhanced" mode is making use of the Same-Origin-Policy (https://developer.mozilla.org/en-US/docs/Web/Security/Same-origin_policy) which prevents the sharing of Cookies inside the embedded YouTubePlayer iFrame as the host is different.
As every iOS App is living in a sandbox the WKWebView has no direct access to the Cookies stored in the Safari or any other Browser which is one reason why SFSafariViewController exists.
Meaning there is no way that Cookies stored in the Safari Browser can be accessed from an WKWebView which a developer of an app controls which results in an always "privacy enhanced" mode as no Cookies will be shared.

Sounds good, thanks!


[SPARK-41905][CONNECT] Support name as strings in slice

What changes were proposed in this pull request?
This PR proposes to slice in Spark Connect to strings as column names as the regular PySpark does.
Why are the changes needed?
For feature parity.
Does this PR introduce any user-facing change?
No, Spark Connect has not been released out yet.
How was this patch tested?
Ran the enabled tests it via IDE

cc @zhengruifeng

Merged to master.


(GH-2226) Do not set module version to latest when migrating

This prevents a module's version requirement in bolt-project.yaml from
being set to the string :latest when migrating a project. Previously,
if a Puppetfile had a module specification with either a version
:latest or no version at all, the module's version requirement would
be set to :latest, which is not valid. Now, in these instances the
module will not have a version requirement in the bolt-project.yaml.
!no-release-note

:+1:


Resize and drag circle is not working in IE11 browser

I tried the resize and drag functionality of circle but these is not working as expected. Is there any possible to give support on IE11 browser ?

Closing this as there's no hints as to how it could be reproduced.


Given package 'vins_client_server' is not in the workspace

Hi LXY!
how can i get the package 'vins_client_server' , i i didn't find it

This package is in coxgraph_ssh.rosinstall, please see here. If you could install this code following this readme.md step by step, this package usually would be installed automatically. Please install this code again!

Thank you for your help sincerely!!

Thank you for your help Sincerely!


Release 0.7.0

Weird. I don't get the linter error locally:
~/d/matchbox (release-0.7.0|✔) taplo check "**/Cargo.toml"
 INFO taplo:lint_files:collect_files: found files total=12 excluded=0 cwd="/home/johan/dev/matchbox"


icmp host blacklisting

When specifying an host in HostBlackList, ICMP traffic to that host is not ignored.
Is this done deliberately or should be considered a bug?

This is a bug. ICMP is processed before (and to the exclusion of) any blacklist processing. I made an attempt at fixing this during my refactor but had to leave it for another day. If you can share the git hash or release version you observed this on, that might be useful information for later.


NACs documentation review

As a DevOps engineer I want to ensure that all documentation is up to date so that I can work more efficiently  and document processes for others.


Enable dependabot

Enable Dependabot dependency updates.

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Seems already active.


Only shows the parent navigation

I am testing your navigation script (love how easy it was to implement). When I publish it though it ignores the current site's navigation and grabs the navigation of the parent.
Should I change the queryUrl variable to ensure i get the current site?

Thank you for the feedback. I haven't tested it just yet but you should be able to have it read from the current site navigation by changing line 13
from:
config.siteUrl = _spPageContextInfo.siteAbsoluteUrl;
to:
config.siteUrl = _spPageContextInfo.webAbsoluteUrl;

UM YES! It works!!
I actually tried that earlier, but I was verifying that it was in fact pulling the parent no matter what, and had all the navigation off. :|
One more question, is this script supposed to add the "home" link to the top nav? It currently doesn't show anything unless I explicitly tell it to. So when there is nothing under Global not even the home link.
Is there way to add that?

It adds only what is returned from this call. Basically only what you have defined and no home node unless you specify it.
{YOURSITE}/_api/navigation/menustate?mapprovidername=%27GlobalNavigationSwitchableProvider%27
you could just always add a home node. after line 59.. before the $.each statement you could put pop this in there.
nodeGroup.append("
Home
");
or if you want that home node to be the site url you could use
nodeGroup.append("
Home
");

Tom,
Thank you. This is great. Also, it's refreshing to ask a question and not be talked down to in order to get an answer. I appreciate you helping us make SharePoint better for our users and for being a good teacher.