Add Project ID as the first column to BOTH CSV exports.

Business Reason
There is currently no unique column to cross reference the 2 csv exports on.
Suggested Fix
Put the project ID as the first column on both CSV exports. ALlows very easy cross referencing.

Uh. Interesting it didn't get caught by the tests.
I guess we weren't using the CSV last year, really

Ya I had a script pulling a more coplete CSV last year


Make chores fork from develop unless hotfix label

Chores are very similar to features (except they don't face end-user), unless they're a severe job that needs to be done right now and in master, so I would propose to also take a look if chore has a hotfix tag on it, otherwise fork from develop branch.
Thanks!

@donaldpiret sorry for annoyance, but I wanted to ping you on this one. Thanks!


Unable to connect to the server: x509: certificate signed by unknown authority

Hi,
trying to find an explanation to this.
i am running kubectl on macOS 10.15.3 (19D76)
~ ❯❯❯ kubectl version --certificate-authority haproxy-cert/config-dir/live/pks.uat.lnd.xxx.com/cert.pem
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-13T18:08:14Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:07:57Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

i have an haproxy setup fronting my kuberentes master api-server, configured to offload TLS them establish another https connection to the backend
 frontend fe-https-all-pks-uat-lnd-xxx-com
        bind <IP_ADDRESS>:8443 ssl crt /etc/ssl/certs/pks.uat.lnd.xxx.com.pem
        bind <IP_ADDRESS>:9021 ssl crt /etc/ssl/certs/pks.uat.lnd.xxx.com.pem

        # Cluster 1 Kubernetes Master node
        acl is-cluster-1-master hdr_dom(host) -i cluster-1.pks.uat.lnd.xxx.com
        use_backend be-cluster-1-pks-uat-lnd-xxx-com if is-cluster-1-master

backend be-cluster-1-pks-uat-lnd-xxx-com
        mode http
        http-request set-header X-Forwarded-Port %[dst_port]
        http-request add-header X-Forwarded-Proto https if { ssl_fc }
        server server2 x.x.x.x:8443 ssl verify none

I'm using a wildcard *.pks.uat.lnd.xxx.com certificate generated from let's encrypt, the root CA for that is Digital Signature Trust Co. - DST Root CA X3 which i can see found in Keychain Access on my macOS machine, i also marked it as "Always Trust"
if i use curl or chrome, the handshake seems to go ok with any issues. if I use kubectl !!!
kubectl was not the only client with this problem, i have another cli which has a similar problem. again curl and chrome had no problem with the communication.
as part of my investigation, i ran "$(go env GOPATH)/bin/macos-roots-test" from https://github.com/golang/go/issues/24652#issuecomment-411069915 , as I had a doubt that it could be a golang issue, at this moment I'm not certain whether it is or not.
my observation was the following, even though I have it trusted under Keychain Access
.
.
crypto/x509: DST Root CA X3 returned 1
crypto/x509: Let's Encrypt Authority X3 returned 2
.
.
crypto/x509: verify-cert rejected CN=DST Root CA X3,O=Digital Signature Trust Co.: "Cert Verify Result: CSSMERR_TP_CERT_SUSPENDED"
crypto/x509: verify-cert approved CN=Let's Encrypt Authority X3,O=Let's Encrypt,C=US
crypto/x509: ran security verify-cert 26 times
    cgo sys roots: 177.446013ms
non-cgo sys roots: 394.296229ms
The test passed, no need to report the output. Thank you.

I also had this thread on letsencrypt with no conclusion!
https://community.letsencrypt.org/t/macos-catalina-10-15-cn-dst-root-ca-x3/113308
i can have kubectl working if kubectl cluster-info --insecure-skip-tls-verify
also if any of the following !!!
~ ❯❯❯ kubectl cluster-info --certificate-authority haproxy-cert/config-dir/live/pks.uat.lnd.xxx.com/cert.pem

~ ❯❯❯ kubectl cluster-info --certificate-authority haproxy-cert/config-dir/live/pks.uat.lnd.xxx.com/chain.pem

~ ❯❯❯ kubectl cluster-info --certificate-authority haproxy-cert/config-dir/live/pks.uat.lnd.xxx.com/fullchain.pem

also if kubectl cluster-info --insecure-skip-tls-verif
Thanks to any points 🙏

you have to change the certificate-authority-data in kube config with your proxy cert
(typically located in ~/.kube/config)
Example)
apiVersion: v1
clusters:
- cluster:
    certificate-authority-data: ** changethispart with base64 decoded cert
    server: https://<IP_ADDRESS>:6443
  name: kubernetes

thanks a million, @onesolpark ... your suggestion is correct, I figured this out a couple of weeks ago and it helped me solve my problem. in my case, i was using a let's encrypt cert, as I commented away the certificate-authority-data in ~/.kube/config , all worked as desired.
thanks,

@mshahat  how did you change authority-data in ~/.kube/config

/open

@onesolpark certificate-authority-data: ** changethispart with base64 decoded cert
The decoded certificate looks very bizzare.
To decode a certificate I used openssl x509 -in ca.cert.pem -text
I could see multiple headings, like:  Signature Algorithm, Data, Version , Validity, Modulus, X509v3 Subject Key Identifie, X509v3 Authority Key Identifier which among these should be used?
When I tried to paste the entire decoded text I get error.
Please suggest.
Thanks

thanks a million, @onesolpark ... your suggestion is correct, I figured this out a couple of weeks ago and it helped me solve my problem. in my case, i was using a let's encrypt cert, as I commented away the certificate-authority-data in ~/.kube/config , all worked as desired.
thanks,

Comment it worked!

I'll share my case here since error was the same but cause was different.
For those running kubectl via gcloud utility: you may get this error if something on the cluster changed. Simply re-generate the credentials with
gcloud container clusters get-credentials --region=<your_region> <your_cluster_name>
run
gcloud container clusters list
to find out name of the cluster

Was getting this error using the gcloud cli and @jakubpartyka suggestion solved the issue. Thanks a lot!!

Hi,
I am having a OIDC setup similar to @mshahat with few differences. I have instead of haproxy, kube-oidc-proxy in front of my GKE cluster, which I use as reverse proxy to have group based authentication.
For OIDC provider, I am using dex with GOOGLE as IDP and dex-authenticator (inplace of gangway.)
I'm using a wildcard certificate issued for "*.xyz.in". using this wildcard, I have created a DNS record named dex.xyz.in for https request.
Everything works fine initially. i am able to access dex service (dex.xyz.in) using dex-authenticator, it generates suitable kubeconfig file with server flag pointing to kube-oidc-proxy service of LB type, in certificate-authority-data, I use ca.crt value of *.xyz.in as i will be using this same TLS everywhere. i have used this TLS in dex configmap as well and have applied trusted_ca_root config in dex-authenticator with value same as that in kubeconfig.
When i run kubectl commands untill id-token gets expiry, everything works fine. But as soon as id-token get expired, kubect get pods (one example) gives:
Unable to connect to the server: Get "https://dex.xyz.in:32000/.well-known/openid-configuration": x509: certificate signed by unknown authority
This is happening only when refresh-token must be used to get new id-token. Not able to understand why this is happening as i am able to access this URL over chrome and also curl request
curl --request POST --data ‘client_id=dex-auth&client_secret=<abc>&refresh_token=<pqr>&grant_type=refresh_token’ https://dex.xyz.in:32000/token works propely and returns appropriate results but kubectl is not able to work with this.
I encountered similar error with dex-authenticator when I was not giving trusted_root_ca field in its configurations. But once I entered that filed, dex-authenticator worked fine.
My kubectl version:
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.2", GitCommit:"092fbfbf53427de67cac1e9fa54aaa09a28371d7", GitTreeState:"clean", BuildDate:"2021-06-16T12:59:11Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"darwin/arm64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.10-gke.2000", GitCommit:"0823380786b063c3f71d5e7c76826a972e30550d", GitTreeState:"clean", BuildDate:"2022-03-17T09:22:22Z", GoVersion:"go1.16.14b7", Compiler:"gc", Platform:"linux/amd64"}

Was getting this error using the gcloud cli and @jakubpartyka suggestion solved the issue. Thanks a lot!!

which was the solution? I cannot find it

Hello, I am getting this same error on a freshly Docker desktop environment afte enabling kubernetes i tried the command to see if installed but got error

Hello, I am getting this same error on a freshly Docker desktop environment afte enabling kubernetes i tried the command to see if installed but got error

I found the answer to this on stack overflow https://stackoverflow.com/questions/71376833/kubectl-giving-error-unable-to-connect-to-the-server-x509-certificate-signed
If you are using Mac OS and newly installed Dicker Desktop the .Kube directory will have to be deleted especially if you already used rancher on the Same Mac OS. so delete .Kube directory then reinit the Kubernetes on Docker Desktop. I added the link where I found answers

you have to change the certificate-authority-data in kube config with your proxy cert (typically located in ~/.kube/config)
Example)
apiVersion: v1
clusters:
- cluster:
    certificate-authority-data: ** changethispart with base64 decoded cert
    server: https://<IP_ADDRESS>:6443
  name: kubernetes

@onesolpark. thank for  you suggestion. it worked


When installing, "Critical environment variable DATABASE_URL missing" thrown

Description

When freshly installing Shopware 6, during database import at step 154/436, it pops an error about a missing environment variable.
This is odd, as I've tried several solutions to this problem:
I went into vendor/shopware/core/Kernel.php and added both
$_ENV['DATABASE_URL'] = "root@localhost:3306"

and
putenv("DATABASE_URL='root@localhost:3306'");

, as well as changing
            $url = $_ENV['DATABASE_URL']
                ?? $_SERVER['DATABASE_URL']
                ?? getenv('DATABASE_URL');

to read
            $url = "root@localhost:3306"
            	?? $_ENV['DATABASE_URL']
                ?? $_SERVER['DATABASE_URL']
                ?? getenv('DATABASE_URL');

.
In vendor/shopware/recovery/install/index.php I've also inserted on the second line
$_ENV['DATABASE_URL'] = "root@localhost:3306";

Additional context
The error thrown:
"Critical environment variable 'DATABASE_URL' missing!\n"
This provides no stack trace, I'm sorry.
The options I've provided to the installer:
Server: localhost
User: root (this may be a security vulnerability, but this is a test shop that can't be accessed outside of localhost so I'm not too worried about it)
Database name: shopware6
Shopware6 database is freshly created; the mysql credentials work.
I'm very new to PHP and shopware in general, so I'm sorry if I'm wasting your time with stupid noobish mistakes - I've searched for solutions but can't find any.

This issue seems very old. Check your PHP session settings and try it with an newer release


DBT ingestion does not delete all tags

We believe we found a unexpected behaviour caused by this line, where if an update has no tags it does not update tags.
We have replicated the issue on our datahub instances.

Hi there! This behavior is intentional, if not misleading. The reason for the defensive check on this code is to prevent overwriting tag changes that were made by users on the DataHub UI inadvertently.
What is the impact for your organization?

Hi,
I think there may be some unintended behaviour happening too though as there are scenarios where the state of datahub will not match the state of a dbt project.
e.g.
If you have a dbt model with one or more tags and run the ingestion the entity is ingested and the tags are created and associated with that entity.
If you then remove all these tags from your model in your dbt project, the manifest.json file will have an empty list for tags for the model but any ingestion will fail to remove the tags
This is impacting us because we have a lot of entities that had a single tag that has now been removed but we cannot remove it via the dbt source ingestion.
As a workaround we are tagging every entity with an arbitrary tag so we can ensure the state of tags in datahub reflects the sate in our dbt project

This makes sense. We are internally tracking this as a feature request for "owners" of tags based on the platform where the tag originates. Will update here with any planned work to address this more wholistically.
Thanks


C SSHNPD binary used with NPT

Describe the bug
I am trying to use NPT with the FreeBSD SSHNPD binary on my OPNsense firewall. Normally I set a timeout value on the CLI of the NPT but I get an error when I use the following command to connect to the OPNsense firewall. The --timeout within the command line to a Linux system running SSHNPD works fine. Should NPT using the "--timeout" variable be supported in the FreeBSD SSHNPD binary?
/Users//.local/bin/npt --from @intense56 --to @55commercial --srvd @rv_am --device opnsense --timeout 90s --remote-port 22 --local-port 65221
--Error message output from the connection process---
Error : This device daemon does not support the 'timeout' value in npt session requests
Steps to reproduce

First I installed the FreeBSD binary on my OPNsense firewall runnversion 24.7.1
Then I used the command "npt --from @intense56 --to @55commercial --srvd @rv_am --device opnsense --timeout 90s --remote-port 22 --local-port 65221"  to connect a NPT session the my OPNsense firewall.
And then I saw the message "Error : This device daemon does not support the 'timeout' value in npt session requests" in the terminal window.

Expected behavior
I expected the npt session to connect as it does when connecting to a Linux running NoPorts 5.5.0 SSHNPD.

@kdimick raised this with me in chat, and I asked him to open this issue.
I think the problem here is that the FreeBSD binary is C sshnpd, which doesn't yet implement the --timeout feature

Yep that's correct, Chris

See #1110 for the dart implementation of this feature.

Closing as there's no actionable work here that isn't covered by another issue


Trying to import a CSV, doesn't do anything (just outputs a single comma)

I think something is broken with pgfutter on OSX. I had to install from source before I could run it at all (issue #48). Now when I try to import a CSV, all I get is a single comma:
$ ~/go/bin/pgfutter csv ./test.csv
,
$ ~/go/bin/pgfutter csv ./foo.csv
,
test.csv is a real CSV file. foo.csv doesn't exist. Either way, it just prints a comma to the console and exits.
pgfutter is a really cool concept, and looks very helpful. Hope this is easy to fix.

I'm getting the same thing on Linux. Installed with go get and when trying to import using pgfutter csv, I just get a comma as well. JSON import is working fine though! This is a very cool project, definitely looking forward to seeing how it grows

Should be fixed in https://github.com/lukasmartinelli/pgfutter/releases/tag/v1.2 in master.

I don't get any output at all. It's just a new line. Is this really fixed?

Using v1.2, I get just a new line.  No table is created in the database and no data is imported.
➜  ~/ pgfutter csv friends.csv
➜  ~/
No table is created in the postgres database.  Also tried specifying options, same result:
➜  ~/ pgfutter --db postgis_import --table fl_tallahassee_taxroll csv friends.csv

I suspect that #67 might fix the silent error here


Environment

can we add a "copy to clipboard" grey button to a paneFooter on this page?

to do that you would need to use flash,

meh, its not important. (thus the low priority label)

We're gonna close this out til 5.5.1.


stubs for twin functionality along with some impl.

This has function stubs, object definitions, and some minor implementation for twin.  I'm looking for feedback on the client API surface.  I also have some open issues that I'd like help resolving, all marked with # OPEN ISSUE text.
Some background:

twins have 3 operations:

get a twin.  This is a query that is sent from the device/module to iothub.  iothub returns a complete twin object with desired and, I think,  reported properties.  It uses the request/response pattern, where a request id  (rid) is included in the topic we send, and that same request id is included in the response.
patch reported properties.  This is a push from the device/module to iothub where the device/module updates a partial or full set of the reported properties.  This uses the same request/response pattern.
wait for desired property patch.  This is like waiting for c2d or method calls.  There is no request (except for subscribing).  The iothub service sends a desired property patch to the client whenever the desired properties are updated on the service.

To get the twin, the client publishes to $iothub/twin/GET/?$rid=<guid> with an empty request body.  The service responds by sending a message to $iothub/twin/res/<status>/?$rid=<guid> with the JSON for the twin in the body.
To patch the reported properties, the client publishes to $iothub/twin/patch/properties/reported/?rid=<guid> with the JSON for the desired properties in the body.  The service responds on $iothub/twin/res/<status>/?$rid=<guid> with an empty body.
To wait for desired properties patches, the client subscribes to $iothub/twin/PATCH/properties/desired/# and any messages on this topic contains the desired properties in the body of the message
Pipeline flow (for GET):

PipelineAdapter/MQTTTransport creates a GetTwin operation and runs it on the pipeline.

the HandleTwinOperations stage receives the GetTwin operation.  It converts it into a IotRequestAndResponse object and sends it down.

the CoordinateRequestAndResponse converts the IotRequestAndResponse operation into a SendIotRequest operation and sends it down.

the IotHubMQTTConverter stage converts the SendIotRequest op into a Publish op and sends it down for publishing.

later on, the response arrives back from the service as an MQTT message inside a IncomingMessage event.

The IotHubMQTTConverter stage converts the message into a IotResponseEvent event and passes it up

The CoordinateRequestAndResponse takes the IotResponseEvent event, matches the RID back to the IotRequestAndResponse operation from step 2 and completes that operation.

The callback from the IotResponseEvent, which is inside the HandleTwinOperations stage, completes the GetTwin operation and the result is returned back to the caller inside PipelineAdapter/MQTTTransport

The path was done this way to remove as much of the MQTT-ness as possible, and make it so the twin code is completely transport-agnostic, except for the code inside the IotHubMQTTConverter, which is the minimal set of code to convert generic operations into mqtt operations.

class MethodRequest(PipelineEvent):

This is unrelated to this review. But i see every word ending with event except this one.

Refers to: azure-iot-device/azure/iot/device/iothub/transport/pipeline_events_iothub.py:43 in 623fc25. [](commit_id = 623fc252c2ca3951adf0fb6c2db8bf03ac430684, deletion_comment = False)

    }

Need to add twin in here

Refers to: azure-iot-device/azure/iot/device/iothub/pipeline/pipeline_adapter.py:35 in ef5e278. [](commit_id = ef5e278533866478ab644c563eeb1ec3689b3d5e, deletion_comment = False)


Review bundle show deprecation

What was the end-user problem that led to this PR?
The problem was there was some work to do regarding the deprecation of bundle show and the bundle list introduction.
What was your diagnosis of the problem?

The command should error out in bundler 3 and was still there.
The command would print erroneous deprecation messages for the --verbose and --outdated flags. These flags to bundle show are undocumented and will be removed in bundler 3.
The bundle list help would show the help for the new list command that lists groups of (or all) gems in the Gemfile, but its implementation would just be an alias to bundle show.

What is your fix for the problem, implemented in this PR?
My fix is to remove the command in bundler 3, to show a different deprecation message when --outdated or --verbose are used to inform about their removal without replacement, and the inconditionally introduce the new list command without any feature flag.
Why did you choose this fix out of the possible options?
I chose this fix because:

The --outdated and --verbse options are undocumented, so nobody should be using them. Still, I give a correct deprecation message for any users they might have used them.
The list command was super confusing because it was an alias to show but that was not documented anywhere. So, I consider find to introduce the new bundle list now to match the documentation.

I still want to add a few things to this PR so I marked it as "status: working", not sure if it's the right way to mark a PR as WIP.

Ok, this should be ready now, let me know any thoughts about this.

If I'm remembering our deprecation plan correctly, we should keep show and make it print a warning in Bundler 2.1 before removing it in Bundler 3, right? Or maybe I am remembering wrong.

No, that's exactly right :+1:. This PR keeps that, but it actually removes the command unles Bundler.feature_flag.bundler_3_mode?. The deprecation was already there, but the removal was only a TODO note but not actually done.
The diff is a bit confusing in this regard, I'll simplify it while I fixed the typo you found!

I ended up leaving the diff as it was, I think it's fine.

Actually ended up changing the diff a bit, although I'm not sure it makes it more clear. Anyways, it should be ready now.

@bundlerbot r+


Quick Access Google

🛠 Fixes Issue
#168
👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📷 Screenshots

@ridsuteri recently i  checked its working

Well, this is how it looks on my system :(

@ridsuteri its working on chrome but not in edge i think some google compatibility issue is there

@ridsuteri its working on my chrome but not in edge i think some google compatibility issue is there

Try looking out for fixes and do connect with me via discord DM incase you are unable to fix this one

@ridsuteri tried a lot and finally, I got ans that Edge and other browser is based on Chromium, so it can run most chrome extensions. When we run this extension in Edge or another, it shows a blank, because Edge doesn't have a chrome app
It works only in the chrome browser

@ridsuteri thank you


Can Sage 9 be used only on Linux and with the Bedrock wordpress structure?

Submit a feature request or bug report

[x] I've read the guidelines for Contributing to Roots Projects
[ ] This is a feature request
[x] This is a bug report
[ ] This request isn't a duplicate of an existing issue
[x ] I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
[x ] This is not a personal support request that should be posted on the Roots Discourse forums

What is the current behavior?
Because , using the documentation, I tried to get Sage 9 on Windows 10 and with the Themosis framework and I got following errors during yarn and then during yarn build:production and then when activating the theme.
when running yarn

when running yarn build:production

when activating the theme

What is the expected or desired behavior?
I believe things should work fine becase on the Sage documentation it does not say things are not working on Windows.

Bug report

Please provide steps to reproduce, including full log output:
X
Please describe your local environment:
WordPress version: 5.0.2
OS: Windows 10
NPM/Node version: X
Yarn 1.12.3
Nodejs v11.6.0
Where did the bug happen? Development or remote servers?
X
Is there a related Discourse thread or were any utilized (please link them)?
X

Feature Request

Please provide use cases for changing the current behavior:
X
Other relevant information:
X

Hello, thank you for your help.
When using the official documentation and errors get generated it is difficult to say if it is a bug or it is a user error (support).
I believe this command npm install -g windows-build-tools
should go straight to the documentation (windows paragraph).


authorized_keys are added, not replacing

Hi,
I noticed today that when changing a key in authorized_keys, the role adds the new key to the existing user but does not remove the older one.
step 1
users:
  - username: my_user
    home_create: yes
    groups:
      - docker
    append: yes
    authorized_keys:
      - public_key_A
    shell: /bin/bash

step 2

users:
  - username: my_user
    home_create: yes
    groups:
      - docker
    append: yes
    authorized_keys:
      - public_key_B
    shell: /bin/bash

# /users/my_user/.ssh/authorized_keys
public_key_A
public_key_B

I took for granted until now that replaced authorized keys were removed and it's potentially dangerous to think so.
Did you implement it like this on purpose?

Hi, it's not exactly on purpose... you can switch on users_authorized_keys_exclusive or item.authorized_keys_exclusive if you only use one key per user.
To remove keys, the default way would be to specify your public_key_A key state as absent and run the role again, but this feature isn't implemented yet as this would need to be added.
PRs always welcome

Managing accounts has the same "problem" I think. State cannot be supplied. I can make a PR.
Btw, love your role. 🎉 Thanks for publishing it!

@till Pleasure! Thanks for the feedback 👍


OPTIONS HTTP method now returns all HTTP methods available for current URI

RESTful web services should provide a header that shows all methods available for current URI. This sends the header as well as adds two helper methods to Router class that may prove useful for more purposes.

This needs to be against the new code in the develop branch.
Also, would the additional code in run() be better off in Middleware?

@vlakarados any updates on this?

Closed to do lack of response. Please reopen if required.

Codeguy, any word on where you're at with this?

I haven't touched this at all yet.


AVRO-3646: integration tests for (de)serializing of enum with mixed variants

What is the purpose of the change
This pull request adds two integration tests to assess the changes of #1921:

(De)serialization of an enum with mixed variants (Null, new type, tuple and struct): serde_enum.
(De)serialization of an enum with mixed and duplicate variants: serde_enum_with_duplicates.

Verifying this change
The two integration tests do not pass for multiple reasons:

The serialized values do not validate the defined schema.
The type value for the tuple variant is serialized as an Array of Union instead as an Union of Array.
With duplicate variants, the index in the type union is not valid (because there is no duplicate in the union defined by the schema).

Documentation

Does this pull request introduce a new feature? no

I'm going to merge this PR and do the cleanup in #1921


CsvAgent 'use field' option seems to have no effect

Test details

tested on everything up to 0d4695ddf499c3639099394676803689e9da22ea

Description
IS

for the CsvAgent the 'use field' option values seem to have no effect: all fields are always parsed and converted to JSON.

SHOULD

CsvAgent should extract data only from the columns configured for the 'use fields' option

Steps to reproduce

set up CsvAgent in parse mode configuring 'use field' for 2 columns
trigger scenario by providing a CSV file with more than 3 columns

Can you provide a sample configuration with the used CSV data? When I specify statecode, county in use fields the event(s) only include the specified keys.

closing as fixed


Misleading to see oauth flow presented for tools unrelated to the query.

Electron build -  090c16f8
Steps to reproduce the problem:
Scenario1:

Start a chat with Tildy
Add 2  tools ( outlook mail and outlook calendar) (Make sure you dont have credentials relating to mail/calendar before this)
Chat with the assistant and ask about some information about  calendar
I am presented with 2 oauth flows relating to outlook

Scenario 2:

Create an assistant with any tool (outlook email tool in my case)
Chat with this tool.
Add slack tool.( (Make sure you dont have credentials relating to slack before this)
Ask any email related question

I am presented with oauth flows relating to slack

Expected Behavior:
User should not be presented with oauth flow for tools unrelated to the query.

Both of these scenarios happen because the tools are dynamically added. The Outlook and Slack tools are tool sets that are shared as context tools, each of which has a Share Credential line in them. If you were to include these in an assistant ahead of time (instead of dynamically adding them), you would be prompted of all of the credentials before sending your first message. When dynamically adding them, you don't get prompted until after you send a message, at which point it looks through the context tools it needs to run and then executes them.
If the logic for dynamic tool adding has been implemented in core GPTScript, then this is something I could adjust to take care of either immediate (as soon at the tools are added) or only as needed. However, if the dynamic tool adding is still implemented either in only the SDK or only the UI, then this isn't really possible.
cc @cjellick


Allow Lan with Exit Node

I've got a properly configured exit node which by default when I bring tailscale0 up on a node and pass the arg flag of --exit-node=exit-node-ip will of course route <IP_ADDRESS>/::0 through the exit as it should.
I was looking into the proper use   --exit-node-allow-lan-access, --exit-node-allow-lan-access=false
When trying this on the client node I would execute:
sudo tailscale up --login-server https://steering.mydomain.com --authkey <my auth key> --exit-node=exit-node-ip --exit-node-allow-lan-access=true --reset --force-reauth
The expected behavior based on what i know is that it will exit all traffic except for lan traffic but the actual behavior prevents me from ssh'ng to the machine via the lan which I do have a direct route to on my VLAN.
I'm hoping I'm misinterpreting the way this works but was also hoping someone could shed some light on this.

Afaik, thats not how the —-exit-node-allow-lan-access flag works.
You dont set that on your clients, but on the exit node itself when you advertise it as an exit node. The intention is here, that your exit node can control, if your clients can also access the LAN that your exit node is a part of, or if the clients are only allowed to access the internet through it.


Conflict: an artifact with this name already exists on the workflow run

CI bug, caused by this upgrade: https://github.com/simonw/shot-scraper/commit/55d2852aaf4556c58bf8cd3d1065b35f2ca86d8e
Specifically this change:
     - name: Archive examples
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: examples
         path: examples/*

Listed as a breaking change here: https://github.com/actions/upload-artifact/blob/main/README.md#breaking-changes

Uploading to the same named Artifact multiple times.
Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

That fixed it: https://github.com/simonw/shot-scraper/actions/runs/7791982657


[4.0] [iOS] Support multiple plist types in plugin

Same as https://github.com/godotengine/godot/pull/49802 for master branch.

Extends current iOS Plugin system and allows to set a specific type for Info.plist key-value pairs.
Implements https://github.com/godotengine/godot-ios-plugins/issues/5
Doesn't break compatibility.
Currently supported types:

string - used as a default if no type is specified
integer
boolean
raw - allows to use arrays or dictionaries
string_input - allows to set string value for a key when exporting.

Example

gdip config
[plist]
plist_default="string_value"
plist_string:string="string_value"
plist_integer:integer=101
plist_boolean:boolean=true
plist_raw:raw="
<array>
    <string>UIInterfaceOrientationPortrait</string>
</array>
"
plist_input:string_input="default_input"

Editor Export screen:

Exported Info.plist:

Thanks!


Plugin was not found

First of all thanks for this service, however I am getting an error upon Gradle sync
* What went wrong:
Plugin [id: 'com.guardsquare.appsweep', version: 'v.1.0.0'] was not found in any of the following sources:

- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Plugin Repositories (could not resolve plugin artifact 'com.guardsquare.appsweep:com.guardsquare.appsweep.gradle.plugin:v.1.0.0')
  Searched in the following repositories:
    Gradle Central Plugin Repository

This is how the app lever build.gradle looks like

plugins {
    id 'com.android.application'
    id 'org.jetbrains.kotlin.android' version "${kotlin_version}" // This should be put before any Kotlin dependent plugin
    id 'com.guardsquare.appsweep' version "v.1.0.0"
}

appsweep {
    apiKey APPSWEEP_API_KEY
}

dependencies { ... }

Do we still need to add classpath to this? Thanks

Sorry silly me, it should be 1.0.0 not v.1.0.0


Fix running tests

fix deprecation warnings
rename files so that they are actually executed when running python -m unittest discover -s tests/

I think the removal was retracted, but it's gone from Python 3.12. Same for assert_equals, which is used in some tests, too.


Testing: Discrepancy in PyNutil /Nutil results (discrepancies in atlasmaps from QN/VN?).

@PolarBean Recording the results of testing, we can discuss more in person.
I've found discrepancies in "region_area" results from PyNutil and Nutil for nonlinear datasets, which I think originate from the atlasmaps (possibly a bug or methodological difference in QuickNII/VisuAlign... this needs more investigation).

PyNutil has an in-build method for calculating "region_area" using the alignment.json.
Nutil calculates the "region_area" using atlasmaps from QuickNII (linear) or VisuAlign (with nonlinear deformations).
PyNutil and Nutil give identical "region_area" results for linear datasets.
PyNutil and Nutil give different "region_area" results for nonlinear datasets.
PyNutil results for nonlinear datasets do not match equivalent results for linear dataset (some deformation is happening).
My testing suggests the atlasmaps from QuickNII and VisuAlign differ even with no nonlinear deformations applied. Nutil gives different results depending on the source of the atlasmaps. Is a different deformation method used in PyNutil and VisuAlign? This needs further investigation, I'm not sure if it's a bug in PyNutil or in VisuAlign (or something else).
Conclusion: can use Nutil to validate PyNutil results for linear but not nonlinear datasets.

@Tevemadar any idea why atlasmaps might differ from QuickNII vs VisuAlign when no markers are applied?

A reminder to provide more info here @Tevemadar

Differences presumably originate from rounding, limited numerical precision:

VisuAlign always triangulates, even when there's the original, linear alignment present, that's a rectangle and it gets cut into two triangles. That's one forward-backward transformation (into the Barycentric coordinate space of each triangle, and then back to image coordinates), that can introduce small differences, which then can be enough to round the result to a neighboring number compared to the original (say, original number was 1.49972, and then it somehow becomes 1.5001, the difference is 0.03%, yet the first number is rounded to 1, the second one is rounded to 2)
There's the playground around the section, VisuAlign overlay has 10% extra space around the section which accepts control points for the deformation field, and when it's cut away, that's also a place where minor numerical differences are introduced.

@PolarBean @Tevemadar Recording the results of PyNutil testing.
I tested PyNutil for a nonlinear dataset using flat files. The results were identical to results achieved with Nutil using flat files. The discrepancy in "region_area" results from PyNutil (without flat files) and Nutil (with flat files) is likely related to the PyNutil calculations that replace reading from the flat files.

Recording the results of PyNutil testing
@PolarBean.  I tested PyNutil by quantifying the background of the segmentations (instead of the objects) to test the "area_fraction" calculations. PyNutil counted 1 object and assigned it to one region only (despite it overlaying all of the regions in the section). This means it replicates Nutil with object_splitting switched "off". Have we implemented a method that replicates Nutil object_splitting switched "on"? This is where there is correct calculation of "area_fraction" for objects that overlap many regions (object pixels assigned to precise region for correct "area_fraction" calculation). This is a priority to implement as it is one of the most commonly used features in Nutil. Let's discuss tomorrow.


Location elevation

Show elevation of location(s) on website (presenters Location and Locations). There is free public OpenElevation API, which can be used. Links:

https://open-elevation.com/
https://github.com/Jorl17/open-elevation
https://api.open-elevation.com/api/v1/lookup?locations=50.087451,14.420671
https://api.open-elevation.com/api/v1/lookup?locations=50.087451,14.420671|50.7359,15.73966 (multiple locations)

Done in commits between https://github.com/DJTommek/better-location/commit/c5fed7090457e82c29fe2f2170b8c1c0ef6f7719 and https://github.com/DJTommek/better-location/commit/d10ba8e31a7ace605468ff02ee06031cd6fe541e


Need to run make twice on macOS 10.15.7

This is not so much an issue as it is a workaround if anyone sees this, but running make the first time always seems to fail, but running it a second time builds successfully on my system. I'm on macOS 10.15.7
Love this tool!

Thanks, that's a good PSA. I'm honestly surprised that it mostly works fine on MacOS without any tweaking. I'm happy you like the tool!

I found one issue that can be improved by the way. Going to try and solve it myself, but in the makefile, line 151 uses the hardcoded lsdj.s filename, but if the ROM supplied has a different name it will fail as the output is romname.s. I am guessing this is important as it states it can be supplied multiple ROMs as a space separated list.

Looking a bit more into it, lsdpack will export all songs into a single romname.s file, with the first ROM's filename.
I'm sure there's some string manipulation that can be done to sort through this, I am just not strong with makefiles.

Here's how I can get the makefile to parse through multiple ROMs, but this still causes and issue with regards to the covers.asm iterating through the number of songs.
LIST_ROM = $(foreach LSDJ_ROMS, $(LSDJ_ROMS), src/res/$(LSDJ_ROMS).gb)

res/lsdj.song: lsdpack/lsdpack${EXE} $(LIST_ROM)
	@$(MKDIR_P) $(@D)
	$^
	$(MV) $(word 1, $(LSDJ_ROMS)).s $@


Fix omero metadata

Closes #21

@m-albert This may also solve the coverage action issue. I changed permissions of the CI action to hopefully avoid the issue we currently see in main. Let's see if that works when merged.
I'm merging & releasing now to enable Nicole to process her data before the conference :)

Well spotted with the CI permissions :)


Chrom from_documents not making embedding to remote chromadb server

System Info
I am runing Django, and chromadb in docker
Django port 8001
chromadb port 8002
bellow snippet is inside django application on running it, it create a directory named chroma and there is a chroma.sqlite3 file and a dir named with randomly.
it didn't make any call to chromadb's service chroma at 8002
docs = loader.load()
        emb = OpenAIEmbeddings()
        chroma_settings = Settings()
        chroma_settings.is_persistent = True
        chroma_settings.chroma_server_host = "chroma"
        chroma_settings.chroma_server_http_port = "8002"
        # chroma_settings.persist_directory = "chroma/"

        Chroma.from_documents(
            client_settings=chroma_settings,
            collection_name="chroma_db",
            documents=docs,
            embedding=emb,
            # persist_directory=os.path.join(settings.BASE_DIR, "chroma_db")
        )

on running
HttpClient(host="chroma", port="8002").list_collections() return []
running http://localhost:8002/api/v1/heartbeat from browser shows {"nanosecond heartbeat":1694261199976223880}
versions info
langchain==0.0.285
openai==0.27.8
django-jazzmin==2.6.0
tiktoken==0.4.0
jq==1.4.1
chromadb==0.4.*
lark

docker-compose
version: "3.4"

x-common: &common
  stdin_open: true
  tty: true
  restart: unless-stopped
  networks:
    - pharmogene

x-django-build: &django-build
  build:
    context: .
    dockerfile: ./Dockerfile.dev

services:
  django:
    container_name: pharmogene-dc01
    command:
      - bash
      - -c
      - |
        python manage.py collectstatic --no-input
        python manage.py runserver <IP_ADDRESS>:8000
    ports:
      - 8000:8000
    env_file:
      - config/env/dev/.django
    volumes:
      - ./:/code
      - pharmogene_static_volume:/code/static
      - pharmogene_media_volume:/code/media
    depends_on:
      - postgres
      - redis
    <<: [*common,*django-build]

  chroma:
    container_name: pharmogene-cdbc-01
#    image: ghcr.io/chroma-core/chroma:latest
    image: chromadb/chroma:0.4.10.dev2
    command: uvicorn chromadb.app:app --reload --workers 1 --host <IP_ADDRESS> --port 8002 --log-config log_config.yml
    volumes:
      - ./:/code
      # Default configuration for persist_directory in chromadb/config.py
      # Currently it's located in "/chroma/chroma/"
    environment:
      - IS_PERSISTENT=TRUE
      - PERSIST_DIRECTORY=${PERSIST_DIRECTORY:-/chroma/chroma}
    ports:
      - "8002:8002"
    depends_on:
      - redis
      - postgres
      - django
      - celery
      - celery_beat
    <<: *common

networks:
  pharmogene:
    driver: bridge

volumes:
 ....

Who can help?
No response
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction

install latest version of chromadb and langchain in separate container
run chroma in docker using docker hub image
try to create embeddings

Expected behavior
expected behaviour is Httpclient().list_collections() should return list of collections from chroma running inside other container.

The issue is resoled by passing HttpClient to from_document


Run A/B tests for py3.11 vs py3.10

Distributed now / soon supports py3.11. We should run a A/B test to see how the py3.11 perf improvements impact dask.
Blocked by

[x] https://github.com/dask/distributed/pull/7249
[x] https://github.com/dask/dask/issues/9691

There is no measurable difference between 3.10 and 3.11.


fix: Error: Cannot find module 'braces'

Hi, thanks for the contribution! Can you provide a bit of a description about what this is fixing? Where do you see the error? Under what circumstances?

Hi, thanks for the contribution! Can you provide a bit of a description about what this is fixing? Where do you see the error? Under what circumstances?

Yesterday during one of our internal project builds, we faced an issue with the braces dependency. When I looked into the repo, I see that it's no longer maintained and it led me to this repo.
Here I see that the dependency for braces was marked as a devDependencies. I've moved this to the dependencies as it's being used utils/fs-helpers.js.
Hope this makes it clear.
18:11:18  Error: Cannot find module 'braces'
18:11:18  Require stack:
18:11:18  - /var/lib/jenkins/.../common/temp/node_modules/.pnpm/@biesbjerg+ngx-translate-extract<EMAIL_ADDRESS>18:11:18  - /var/lib/jenkins/.../common/temp/node_modules/.pnpm/@biesbjerg+ngx-translate-

Thanks for the explanation!


Commands/Events

Exposing single-shot events with miniconf currently looks like:

expose a miniconf boolean flag struct member
set it true
in the application recognize the single false->true change, act on it, records that it has acted on it
set it false before making any other miniconf change

This has a couple of downsides:

No support for long-running/expensive commands/changes
No support for returning results/responses
Fragile sequencing

The potential enhancement is to implement a specific miniconf endpoint that supports request-response patterns.
A hot incoming request would be stored by miniconf until executed and cleared by the application, at which point the corresponding hot response is stored by the application, and serialized/sent/cleared by miniconf.
The data structure looks like a pair of single-entry queues, one for request, the other for responses. There is likely an implementation already. It would be useful to be able to split it into miniconf and application halves to make it lock-free.
Open questions:

Constraints on request/response payload
Location and correlation for response publication
Ignoring/skipping during re-publication
Namespace separation from settings

Closing this issue. Generic request/response handling is now being completed in https://github.com/quartiq/minireq.


fix binary decomposition of 0

Description

Fixes # (852)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)

How has this been tested?

[ ] Added test cases for api.AssertIsLessEq

How has this been benchmarked?

[ ] Benchmark A, on Macbook pro M1, 32GB RAM
[ ] Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I did not modify files generated from templates
[ ] golangci-lint does not output errors locally
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Suggested edit:
diff --git a/internal/regression_tests/issue_836_test.go b/internal/regression_tests/issue_836_test.go
index 99c27f3a..0830c291 100644
--- a/internal/regression_tests/issue_836_test.go
+++ b/internal/regression_tests/issue_836_test.go
@@ -79,12 +79,17 @@ func TestIssue836Cmp(t *testing.T) {
 		Right:     5,
 		ExpCmpRes: -1,
 	}
+	assignmentHintBad2 := CmpCircuit{
+		Left:      10,
+		Right:     0,
+		ExpCmpRes: -1,
+	}
 	toReplaceHint, err := getNBitsHint()
 	if err != nil {
 		t.Fatalf("couldn't find hint to replace: %v", err)
 	}
 	assert.CheckCircuit(&CmpCircuit{}, test.WithValidAssignment(&assignmentNoHintGood), test.WithInvalidAssignment(&assignmentNoHintBad))
-	assert.CheckCircuit(&CmpCircuit{}, test.WithInvalidAssignment(&assignmentHintBad), test.NoTestEngine(), test.WithSolverOpts(solver.OverrideHint(toReplaceHint, maliciousNbitsHint)))
+	assert.CheckCircuit(&CmpCircuit{}, test.WithInvalidAssignment(&assignmentHintBad), test.WithInvalidAssignment(&assignmentHintBad2), test.NoTestEngine(), test.WithSolverOpts(solver.OverrideHint(toReplaceHint, maliciousNbitsHint)))
 }

 func TestIssue836AssertIsLess(t *testing.T) {
@@ -110,8 +115,7 @@ func TestIssue836AssertIsLess(t *testing.T) {
 		t.Fatalf("couldn't find hint to replace: %v", err)
 	}
 	assert.CheckCircuit(&AssertIsLessOrEqCircuit{}, test.WithValidAssignment(&assignmentNoHintGood), test.WithInvalidAssignment(&assignmentNoHintBad))
-	assert.CheckCircuit(&AssertIsLessOrEqCircuit{}, test.WithInvalidAssignment(&assignmentHintBad), test.NoTestEngine(), test.WithSolverOpts(solver.OverrideHint(toReplaceHint, maliciousNbitsHint)))
-	assert.CheckCircuit(&AssertIsLessOrEqCircuit{}, test.WithInvalidAssignment(&assignmentHintBad2), test.NoTestEngine(), test.WithSolverOpts(solver.OverrideHint(toReplaceHint, maliciousNbitsHint)))
+	assert.CheckCircuit(&AssertIsLessOrEqCircuit{}, test.WithInvalidAssignment(&assignmentHintBad), test.WithInvalidAssignment(&assignmentHintBad2), test.NoTestEngine(), test.WithSolverOpts(solver.OverrideHint(toReplaceHint, maliciousNbitsHint)))
 }

 func TestIssue836MathCmpAssertIsLessEqBounded(t *testing.T) {
@@ -128,15 +132,19 @@ func TestIssue836MathCmpAssertIsLessEqBounded(t *testing.T) {
 		Left:  10,
 		Right: 5,
 	}
+	assignmentHintBad2 := MathCmpAssertIsLessOrEqCircuitBounded{
+		Left:  10,
+		Right: 0,
+	}
 	toReplaceHint, err := getNBitsHint()
 	if err != nil {
 		t.Fatalf("couldn't find hint to replace: %v", err)
 	}
 	assert.CheckCircuit(&MathCmpAssertIsLessOrEqCircuitBounded{}, test.WithValidAssignment(&assignmentNoHintGood), test.WithInvalidAssignment(&assignmentNoHintBad))
-	assert.CheckCircuit(&MathCmpAssertIsLessOrEqCircuitBounded{}, test.WithInvalidAssignment(&assignmentHintBad), test.NoTestEngine(), test.WithSolverOpts(solver.OverrideHint(toReplaceHint, maliciousNbitsHint)))
+	assert.CheckCircuit(&MathCmpAssertIsLessOrEqCircuitBounded{}, test.WithInvalidAssignment(&assignmentHintBad), test.WithInvalidAssignment(&assignmentHintBad2), test.NoTestEngine(), test.WithSolverOpts(solver.OverrideHint(toReplaceHint, maliciousNbitsHint)))
 }

-func TestIssueXXXMathCmpAssertIsLessEqFull(t *testing.T) {
+func TestIssue836MathCmpAssertIsLessEqFull(t *testing.T) {
 	assert := test.NewAssert(t)
 	assignmentNoHintGood := MathCmpAssertIsLessOrEqCircuitFull{
 		Left:  5,
@@ -150,12 +158,16 @@ func TestIssueXXXMathCmpAssertIsLessEqFull(t *testing.T) {
 		Left:  10,
 		Right: 5,
 	}
+	assignmentHintBad2 := MathCmpAssertIsLessOrEqCircuitFull{
+		Left:  10,
+		Right: 0,
+	}
 	toReplaceHint, err := getNBitsHint()
 	if err != nil {
 		t.Fatalf("couldn't find hint to replace: %v", err)
 	}
 	assert.CheckCircuit(&MathCmpAssertIsLessOrEqCircuitFull{}, test.WithValidAssignment(&assignmentNoHintGood), test.WithInvalidAssignment(&assignmentNoHintBad))
-	assert.CheckCircuit(&MathCmpAssertIsLessOrEqCircuitFull{}, test.WithInvalidAssignment(&assignmentHintBad), test.NoTestEngine(), test.WithSolverOpts(solver.OverrideHint(toReplaceHint, maliciousNbitsHint)))
+	assert.CheckCircuit(&MathCmpAssertIsLessOrEqCircuitFull{}, test.WithInvalidAssignment(&assignmentHintBad), test.WithInvalidAssignment(&assignmentHintBad2), test.NoTestEngine(), test.WithSolverOpts(solver.OverrideHint(toReplaceHint, maliciousNbitsHint)))
 }

 func maliciousNbitsHint(mod *big.Int, inputs []*big.Int, results []*big.Int) error {

Thanks! It was a good catch. Welcome as a gnark contributor!

It seems we need to update the circuit statistics.
 Thanks.

It seems we need to update the circuit statistics.
 Thanks.

done~

Merging with failed tests - it seems that CI doesn't have access to some secrets when PRs are based on external forks.


chore(merge-back): 1.106.1

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
Commit ID: 221dbd98ac234745e0a284c1d90d2a49b13f317c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Integrate google sheets with particle console

I want to verify I am taking the write steps @SUPScientist
I added a new integration using the google cloud platform because we agreed to send it to google sheets.

Noted. This is lower priority than getting the UART comms working again, so we'll focus on UART (flood/no flood) and then come back to this.

@SUPScientist With Uart comms fixed I believe I am ready to integrate! Whoot whoot

Unsure, sorry, but I'll try.  (Off-topic, but please continue to clean up the overall organization, including the homepage which has several repository descriptions that make them sound identical even though I think they're not. If you're stalled in coding work, there's plenty of documentation work (and thesis writing!) to be done as well so don't let me hold you up on general progress.)

@SUPScientist @ebgoldstein I am struggling to find where to edit the "About" page to update and better detail the descriptions. I looked up how even though I have done it before. It says use the settings gear in the upper right to edit but I do not have one.
Am I missing something? :)

See https://github.com/TinyCamML/.github/issues/1

Currently building the webhook to execute the publishing of data from Boron to Particle cloud to google sheets. Relies on an eventName which is currently eventName = "FloodorNo":
https://github.com/TinyCamML/Boron-and-OpenMV/blob/a73a2d89ecc041749dbf780870dfa5da932aa2f8/Firmware/PublishBoronCode/src/TinyCamPublish.ino#L26
Do not change eventName or else integration will fail. More progress to come...

Read-only access to google sheet here: https://docs.google.com/spreadsheets/d/11ocVnjbdwYJO1UnGhrpfUw7a2iHKmkT3kHaA8BR1ntw/edit?usp=sharing

Following docs linked in https://github.com/COAST-Lab/Open-Water-Level/issues/24

Integration created and ready for testing. See https://github.com/COAST-Lab/Open-Water-Level/tree/main/Particle_Integration for documentation (which we ought to copy and paste here, too, including .js and .json files).
IMPORTANT: let's test this together in person to ensure correct functionality and non abuse of cellular connection. We'll set PUBLISHING to 1 here: https://github.com/TinyCamML/Boron-and-OpenMV/blob/a73a2d89ecc041749dbf780870dfa5da932aa2f8/Firmware/PublishBoronCode/src/TinyCamPublish.ino#L14
and SECONDS_BETWEEN_MEASUREMENTS to 360 here: https://github.com/TinyCamML/Boron-and-OpenMV/blob/a73a2d89ecc041749dbf780870dfa5da932aa2f8/Firmware/PublishBoronCode/src/TinyCamPublish.ino#L33
Then recompile/flash, then watch to see if the integration works. Leaving issue open till we can confirm functionality.

This works! Made recommended changes of setting publishing to 1 and measurements every 360 seconds.
Here is the google sheets which shows successful integration and collection: https://docs.google.com/spreadsheets/d/11ocVnjbdwYJO1UnGhrpfUw7a2iHKmkT3kHaA8BR1ntw/edit#gid=0


Fix infinite redirect loop

I'm not entirely sure why, but sometimes the X-Forwarded-Uri header is not set. This allows it to fall back to the Request's URL when it is not set.

Oh cool, not sure why the X-Forwarded-Uri would be empty, why would the actual request URI be of any use though? Isn't throwing an error the correct behaviour?

I'm not convinced that throwing an error is the correct behavior. I don't know why traefik isn't setting that header, but all the other x-forwarded-* headers are there. I'm referring to the request after the redirect back from Google.
Without this change, there is a redirect loop of forward-auth => Google => forward-auth that ends in a "too many redirects". With this change, authentication proceeds as normal.
I don't want the missing header to throw an error unless we can figure out why it isn't being set, because that would make this project unusable.

Can you post your traefik and traefik-forward-auth configs and also confirm what version of traefik you're using?
Here's the code in traefik: https://github.com/containous/traefik/blob/v1.7/middlewares/auth/forward.go#L151-L157

I'm closing this as I'm not clear on why the url parsing would fail, if we can get a reproducible example of this happening I'd be happy to get a fix in!


⚠ Turnos 24x7 has degraded performance

In bb8e871, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1143 ms

Resolved: Turnos 24x7 performance has improved in 70a54d0.


Add files via upload

@ron2111 please review my PR

Go through the updated readme and raise another pr


[Code Addition Request]:  adding 2048 game project to game development

Have you completed your first issue?

[X] I have completed my first issue

Guidelines

[X] I have read the guidelines
[X] I have the link to my latest merged PR

Latest Merged PR Link
N/A (first issue)
Project Description
The 2048 game is a single-player sliding puzzle where the objective is to combine numbered tiles on a 4x4 grid to create a tile with the number 2048. Players move tiles up, down, left, or right, and when two tiles with the same number collide, they merge into one with their values summed. The game ends when no more moves are possible, either by winning with a 2048 tile or losing when the grid is full and no merges are available.
Using the tkinter module of ptyhon the UI of game has been designed and put together.
Full Name
Riya Chauhan
Participant Role
Contributor

@Riyachauhan11 have our checked that this game is not already been in the repo and no issues and pr are there?

oh my bad i didnt check the PRs its there in reviews, ill close this issue and keep in mind checking both issues and PRs section next time. Thank you for the guidance


upgrade commons codec from 1.13.0 to 1.16.0

Currently, we depend upon a pre-COVID version of commons-codec (like several other dependencies, I am working the issues).
Upgrade to 1.16.0.
NOTE: I'm unable to upgrade to 1.16.1: it causes test failures.
   $ ./gradlew -p lucene/analysis/phonetic test
   ...
   >     java.lang.ExceptionInInitializerError
   >         at org.apache.commons.codec@1.16.1/org.apache.commons.codec.language.bm.Lang.<clinit>(Lang.java:108)
   >         at org.apache.commons.codec@1.16.1/org.apache.commons.codec.language.bm.PhoneticEngine.<init>(PhoneticEngine.java:300)
   >         at org.apache.commons.codec@1.16.1/org.apache.commons.codec.language.bm.PhoneticEngine.<init>(PhoneticEngine.java:276)
             ...
   >
   >         Caused by:
   >         java.lang.IllegalArgumentException: Unable to resolve required resource: org/apache/commons/codec/language/bm/ash_languages.txt
   >             at org.apache.commons.codec@1.16.1/org.apache.commons.codec.Resources.getInputStream(Resources.java:38)
   >             at org.apache.commons.codec@1.16.1/org.apache.commons.codec.language.bm.Languages.getInstance(Languages.java:254)
   >             at org.apache.commons.codec@1.16.1/org.apache.commons.codec.language.bm.Languages.<clinit>(Languages.java:243)

Seems some resources are missing from the jar or similar.
I tried to investigate a bit, by looking at their source code changes from 1.16.0 to 1.16.1, it is overwhelming, not exactly what I'd call a "patch" release :)
https://github.com/apache/commons-codec/compare/rel/commons-codec-1.16.0...rel/commons-codec-1.16.1
Either way, that isn't to be fixed here, so let's at least move from a 2019 version to a 2023 version. We can separately debug the 1.16.1 issue / report it to them / file a PR /etc.

I think i understand the 1.16.1 issue. Looks like there is a bit of jar/maven-hell going on among the commons dependencies. I hit it when I tried to upgrade commons-compress...
Bumping both of them to the latest version is not the solution, it seems to then just cause "module-hell" and still fails the build. But for now we can get them on less ancient versions.

I will open a separate issue for the commons-compress as there is more trouble there...

I figured out what broke in commons-codec 1.16.1 and reported an issue over there: https://issues.apache.org/jira/projects/CODEC/issues/CODEC-324

Note that the current version of Commons Codec is 1.17.1.


[5.4] Simplify method

This PR just removes unnecessary call to tap() function.
I find it simpler to not use the tap() helper, as there is only one action performed.

This removes a require call.

Sorry @taylorotwell, what does it remove?

See the require $path call in the original code.

The require call is still there, isn't it? @taylorotwell


Expression only field allow the user to disable EX button

Description
When we have an expression only field, previously the EX option was enabled by default and cannot be disabled by clicking on it. However with the new expression support, the EX option can be disabled.
Steps to Reproduce
Use a switch mediator and check the Expression field.
Version
v1.1.624121618 - Pre-alpha
Environment Details (with versions)
No response

Closing the issue as this is fixed.


input method issue

Why did I download the Chinese input method, when I switched to the Chinese input method, it was still English when I made the input

What are u using? Athena Nix or Athena Arch? Which locale settings did u set during the installation? Do you keep English keyboard layout after the installation?

Athena Arch,locale: zh_CN.UTF-8 ,I have two keyboard layouts, Chinese and English, and whatever type of input I use, it's all English

though I changed it ,It's still  in English when i input

It seems you are installing an old ISO... Did you try to download Athena Nyx prerelease?

I install the ISO  called athena-2023.06.23-x86_64.iso yesterday ,I don't konw how to install the lastest Athena ,Because there are very few tutorials on this in China.

Click on "Get It" button. You will get the ISO u need

I can copy and paste to input Chinese, so the problem of the input method is not a big problem for me,and Arsenal Os is So cool, I like this UI very much, thank you for helping me answer it

what i mean is i don't konw how to  configurate The lastest Athena  os when I  install

I dont know what is Arsenal OS O_o

haha , sorry ,It'is Athena Os . I made a mistake

this problem persists, I'll record a video later

Uploading Athena OS - VMware Workstation 2024-07-18 00-27-33_compressed.mp4…

Uploading Athena OS - VMware Workstation 2024-07-18 00-27-33_compressed.mp4…

This video was from the old ISO or new one you just downloaded?

the old ISO : athena-2023.06.23-x86_64.iso

Okay, I just downloaded the latest ISO:athena-rolling-x86_64.iso I'll wait to install it and try it.

This is the latest ISO but it doesn't seem to have been installed properly

Since you are from China, I suspect that the Great Firewall blocks some connections. Can you use a VPN for the installation?

I also think so, but I don't know where the VPN is

Just now I see that I didn't install VPN plugins on Network Manager, sorry. Thank you very much for reporting this issue.
I just added them and I regenerated the ISO. Could you please download the ISO again?
Once you are in the Live Environment, click on:

and then you can choose the VPN type you need:

and finally click on "Create..." to configure it according to your VPN.

I thought the same thing yesterday, but this button on my computer is invalid, it is grayed out and I click on it and there is no response.I'll download the new ISO later.

Thank you very much for this improvement

I'm currently using the openvpn service for installing the lastest Athena OS, and it seems like I'll be able to use Athena OS right away! If successful, I will make a pdf of my installation process for other people to use as a reference. Finally, thank you again for your hard work on Athena OS!

Excellent! Let me know. It is important to make Athena OS installation inclusive also for China region and I appreciate users from China. If you decide to write a doc about this, please tell me, we can integrate it in official Athena OS docs.

perfect!

Some people have the same problem

It is worth to describe the procedure on Athena OS docs website then.

The input method still cannot input Chinese,I'm going to get ready to rest, and I'll process the remain Problem tomorrow.


controller: Add SSE firehose

Add a single endpoint that supports server sent events and streams changes to all objects. This will things like the dashboard always showing the most recent information.

This was implemented in #1636


Disable OTEL expirer and hide it from docs

Provides a workaround for https://github.com/grafana/beyla/issues/1065 until we manage to fix the OTEL code.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.91%. Comparing base (1f8435d) to head (dc05e01).

:exclamation:  There is a different number of reports uploaded between BASE (1f8435d) and HEAD (dc05e01). Click for more details.
HEAD has 1 upload less than BASE

Flag
BASE (1f8435d)
HEAD (dc05e01)

k8s-integration-test
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1066       +/-   ##
===========================================
- Coverage   79.20%   67.91%   -11.30%
===========================================
  Files         139      139
  Lines       11328    11328
===========================================
- Hits         8972     7693     -1279
- Misses       1812     3122     +1310
+ Partials      544      513       -31

Flag
Coverage Δ

k8s-integration-test
?

oats-test
36.92% <ø> (+<0.01%)
:arrow_up:

unittests
52.02% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Automatic 1111 WebUI Extension is missing after latest update

As the title suggests, the Automatic 1111 WebUI Extension for Infinite Zoom is missing after I updated it. I used it yesterday for many hours. No problems. The update has caused some sort of issue. I still see Infinite Zoom in my extensions folder and it is active but the tab is nowhere to be found.  I reinstalled Infinite Zoom and restarted "webui-user.bat". It did not make a difference. Any solutions or a way to rollback to the previous version?

OS: Windows 10
Version 22H2
Automatic 1111 running in Google Chrome browser

Just double checked. As a matter of fact there is! I'm just not sure how to fix it.

I downloaded the extention about 3 hours ago and had the same error, but updating the Automatic1111 WebUI fixed it for me.

but updating the Automatic1111 WebUI fixed it for me.

@FunkyPhilVR looks like updating webui will fix the issue.

I did a fresh install and it's working now. thanks!


HubSpot CRM: Updated some scopes that this connector uses (edit contacts, list and edit deals)

I have modified the scopes which this platform connector requests from HubSpot.
I noticed that some of the actions do not work due to missing scopes:
https://learn.microsoft.com/en-us/connectors/hubspotcrm/#list-deals
https://learn.microsoft.com/en-us/connectors/hubspotcrm/#update-a-contact
https://learn.microsoft.com/en-us/connectors/hubspotcrm/#update-a-deal
It could be possible that others are also not working anymore, maybe due to api changes from HubSpot.
@troystaylor since this is your connector, you might want to look more into it, at least these three should be fixed for now.

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[ ] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[ ] I attest that the connector works and I verified by deploying and testing all the operations.
[ ] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[ ] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[ ] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[ ] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Thanks, @Cammeritz for the update. Please know that it is my plan to fully update the HubSpot connectors now that I am receiving significant requests for a HubSpot Copilot plugin. These efforts are not exclusive, as plugin certification is still TBD, but I can give no estimate for when that would be completed.

Hello @troystaylor,
Thank you very much for your reply.  @Cammeritz can close this PR? please advise.

Hello @troystaylor,
Thank you very much for your reply.  @Cammeritz can close this PR? please advise.

In my opinion you should merge the change into the codebase. We need this feature and found out it's broken. I am just waiting for this fix to be applied so our MS Bookings <-> HubSpot integration is going to work.

@troystaylor
Can you please confirm for @vmanoharas that this change can be merged into the codebase?

Yes, this change can be merged.

[[certify-connector]]

[[certify-connector]]

Hello Partner,
I hope you are doing well.
Congratulations, the deployment of your connector and documentation page was already completed, We have a short survey on the connector certification process that we would like for you to complete. Your feedback is appreciated and will help us improve the program.
Thank you very much for working with us.


Publish action example fails to invalid argument for "-t, --tag" flag: invalid reference format

Hi,
I'm trying to publish my add-on docker images with github actions. I'm using the same code from the Publish action example.
The only difference is the publish step:
      - name: Publish
        uses: home-assistant/builder@master
        with:
          args: |
            --all \
            --target emhass \
            --docker-hub davidusb

This fails to build for each arch throwing these errors:
[22:35:50] INFO: Image ghcr.io/home-assistant/armhf-base-debian:bullseye is trusted
[22:35:50] INFO: Run build for ***/:0.1.29 with platform linux/arm/v6
invalid argument "***/:0.1.29" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.
Error: Process completed with exit code 125.

Thank you for your help

Solved adding these args:
      - name: Publish
        uses: home-assistant/builder@master
        with:
          args: |
            --all \
            --target emhass \
            --docker-hub davidusb
            -d davidusb \
            --docker-user davidusb \
            --docker-password ${{ secrets.DOCKERHUB_TOKEN }}

And I was missing the following line in config.yaml:
image: "davidusb/image-{arch}-emhass"


Adding breaking NLI dataset as benchmark

Hello,
Let me congratulate to you on great research efforts. I've tried to use the code against breaking NLI ( https://github.com/BIU-NLP/Breaking_NLI ). I modified preprocess_data.py file and use build_sequence  and CoreNLP methods to prepare data to feed into the model. I manually checked files like *_token.txt and '*_lemma.txt' and they look OK to me.
To evaluate a model on the new dataset, I changed gen.py file adding new TextIterator object and calling pred_acc function.
These are the results I get:
kim_accuracies_test          0.886
kim_accuracies_train         0.931
kim_accuracies_valid         0.887
kim_accuracies_breaking  0.109
Do you have any ideas why the number is so low?
Thanks

Hi, I don't know why you get the low number. Actually, I tested KIM model on breaking NLI data, and I got a good number of 83.5%. You can find the detail experiment on our ACL paper: http://www.aclweb.org/anthology/P18-1224

Hi @tomwesolowski , could you kindly share the model with me. I am unable to run the GPU code because of some cuda driver incompatibilities. I also cannot update the drivers because of some other constraints.

I've had similar issues. Installing Vonda helped. I needed to change a couple of cuda/theano files to be able to run it. I haven't changed anything in the code.

If you have the model with you, perhaps you can upload it somewhere? Or, if you can point me to the exact fixes, that should also work.

The model is identical as in the repository. I just followed various pieces
of advice on Theano blogs/websites to make it work. I don't remember what
was it exactly, unfortunately.
Best of luck
On Thu, 29 Nov 2018, 09:51 Swarnadeep Saha<EMAIL_ADDRESS>wrote:

If you have the model with you, perhaps you can upload it somewhere? Or,
if you can point me to the exact fixes, that should also work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lukecq1231/kim/issues/1#issuecomment-442753921, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAWjYH0u39z5iuqz5ZMJl8_apkpUspn9ks5uz6AqgaJpZM4VK9Ri
.

@swarnaHub I made it work after doing the following:

Create a conda environment, install theano, pygpu, and numpy==1.12:
$ conda create -n kim python=2.7.13
$ conda activate kim
(kim) $ conda install theano pygpu
(kim) $ pip install numpy==1.12

This will install Theano 1.0.3 (Kim runs with this newer version).
I also made sure that the version of numpy being imported by the python in my PATH was 1.12.0
(kim) $ python -c "import numpy; print(numpy.version.version)"
1.12.0

I removed the Theano cache directory as suggested in https://github.com/Theano/Theano/issues/3762#issuecomment-189982441
(kim) $ rm -rf ~/.theano

I  followed the steps recommended here: https://github.com/Theano/Theano/issues/5943#issuecomment-383757444

I exported the THEANO_FLAGS environment variable specified in https://github.com/lukecq1231/kim/blob/master/scripts/kim/train.sh, but changed device=gpu0 to device=cuda1 and removed lib.cnmem=0.9. Note that I used cuda1 but you could also use cuda0 in case you have only one gpu:
(kim) $ export THEANO_FLAGS='mode=FAST_RUN,device=cuda1,floatX=float32,optimizer_including=cudnn,warn_float64=warn'

Finally I get:
(kim) $ python -c "import theano"
WARNING (theano.tensor.blas): Using NumPy C-API based implementation for BLAS functions.
Using cuDNN version 7103 on context None
Mapped name None to device cuda1: TITAN Xp (0000:02:00.0)

Some more info for further reference:

~/.theanorc
(kim) $ cat ~/.theanorc
[cuda]
# Set to where the cuda drivers are installed.
# You might have to change this depending where your cuda driver/what version is installed.
root=/usr/local/cuda/bin

[dnn]
include_path=/usr/local/cuda/include
library_path=/usr/local/cuda/lib64

LD_LIBRARY_PATH
(kim) $ echo $LD_LIBRARY_PATH
/usr/local/cuda/lib64:/usr/local/cuda/lib:/usr/local/cuda/extras/CUPTI/lib64

cuda:
(kim) $ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2017 NVIDIA Corporation
Built on Fri_Nov__3_21:07:56_CDT_2017
Cuda compilation tools, release 9.1, V9.1.85

pip
(kim) $ pip list
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.


Drop the 'day' and 'time' only ISO 8601 and RFC 2822 regex and replace with usDateRE, intlDateRE, and timeOfDayRE

Work for this issue will begin begin on branch work-liquid-labs/regex-repo/53.


Fix URL's for images in README.md

Thanks @dcRUSTy for not only fixing a bug I introduced but also improving the links! Merged.


A little idea and suggestion, hope to adopt!

Recommendation one: It is recommended to add an owner to the data source in the data source center so that it is easy to manage

Recommendation 2: Add a loop to the definition flow judgment.
Recommendation 3: Support Parameter passing in dependent task flows, such as multiple task flows operating on the same temporary table

Recommendation one is easy to implement, is there anybody who want to implement it?

Recommendation one is easy to implement, is there anybody who want to implement it?

Recommendation 2 :  the task self can set retry and retry time , Is it necessary to retry the upstream task ?

Recommendation 2 :  the task self can set retry and retry time , Is it necessary to retry the upstream task ?

Recommendation 3: please referer:  https://github.com/apache/incubator-dolphinscheduler/issues/3805

Recommendation 3: please referer:  https://github.com/apache/incubator-dolphinscheduler/issues/3805

Recommendation one is easy to implement, is there anybody who want to implement it?

Please re-submit a new issue for Recommendation one, then I will lable it "easy to implement" for first-time contributor

Recommendation one is easy to implement, is there anybody who want to implement it?

Please re-submit a new issue for Recommendation one, then I will lable it "easy to implement" for first-time contributor

@dailidong On the first proposal, in addition to the data source center and Resource Center, if possible, it is better to add associated users, if possible, this I can make a single!
For recommendation # 2, here's what I need:

@dailidong On the first proposal, in addition to the data source center and Resource Center, if possible, it is better to add associated users, if possible, this I can make a single!
For recommendation # 2, here's what I need:

Recommendation one is easy to implement, is there anybody who want to implement it?

anybody who want to implement it, please leave a message, https://github.com/apache/incubator-dolphinscheduler/issues/4428

Recommendation one is easy to implement, is there anybody who want to implement it?

anybody who want to implement it, please leave a message, https://github.com/apache/incubator-dolphinscheduler/issues/4428

@dailidong On the first proposal, in addition to the data source center and Resource Center, if possible, it is better to add associated users, if possible, this I can make a single!
For recommendation # 2, here's what I need:

does this idea could solve your issue? #3805
by the way, please contact me(wechat:510570367 or mail<EMAIL_ADDRESS>

@dailidong On the first proposal, in addition to the data source center and Resource Center, if possible, it is better to add associated users, if possible, this I can make a single!
For recommendation # 2, here's what I need:

does this idea could solve your issue? #3805
by the way, please contact me(wechat:510570367 or mail<EMAIL_ADDRESS>

is there still any suggestion?

is there still any suggestion?

good suggestions.
I will close this issue.  if you have any more suggestions , please submit an new issue, one issue for one topic is much better, thx

good suggestions.
I will close this issue.  if you have any more suggestions , please submit an new issue, one issue for one topic is much better, thx


Room clicking behavior

If in no rooms, clicking on room goes there.
If "in" room, make it visible.
Otherwise, regular click opens popup presenting two options

Go to that room, leaving current room [SHIFT hotkey?]
Open that room in the background [CTRL or META hotkey? also add middle-click]

Oops, wrong repo!


Option to deny or ignore symlinks for extra security

It seems that express.static follows symlinks by default, which may become dangerous depending on how the static folder gets populated. If I understand things right, an attacker may read a sensitive file such as as a private SSH key in some situations because of this.
I can imagine a couple of scenarios:

An app user is given an option to upload an archive with their static files and this archive contains symlinks to something like /home/ubuntu/.ssh/id_rsa.

A static folder served by express contains a build artifact from the CI/CD pipeline that has been just hacked. An attacker cannot access the we server, but can modify new artifacts as get build and this allows them to access sensitive files on the web server.

It'd be great if serving symlinks could be disabled as simple as this is done for dotfiles, e.g.:
var serve = serveStatic('public/ftp', { dotfiles: 'ignore', symlinks: 'ignore' });

My current workaround:
const notASymlink = async (pathname) => {
  try {
    const stat = await fs.lstat(pathname);
    return !stat.isSymbolicLink();
  } catch (e) {
    return false;
  }
};

// this simulates { symlinks: "ignore" }
const statics = express.static(staticRootDir, { dotfiles: "ignore" });
server.get("*", async (req, res, next) => {
  if (await notASymlink(path.resolve(staticRootDir, req.path.substring(1)))) {
    return statics(req, res, next);
  }
  return next();
});

It may also be possible to memoize the results of notASymlink function, but such caching needs to be done with caution because a regular file can become a harmful symlink at any time.
const { memoize } = require('lodash');

const staticFolderLastUpdated = new Date().getTime();
const notASymlinkUsingCache = memoize(
  notASymlink,
  (path) => `${staticFolderLastUpdated}|${path}`,
);

I'm not sure if this trick gives enough performance gain though – I did not run any benchmarks.

I may be too paranoic, but I believe that symlinks could be set to ignore or deny is some future major version to protect people from a risk they may not be aware of.

To clarify: are you reporting this as a vulnerability or as a feature request?

Not sure. As both :–)

Please do not report security issues in the public, as this has now just become a zero-day. Please email me to continue discussion so we don't reveal more to the public while a fix is being created here.


Release 1 3 3

Issue :https://jag.gov.bc.ca/jirarsi/browse/RIDE-386
Adding prometheus instrumentation

closing to change the branch name


Uncaught TypeError: Cannot read property 'split' of undefined

Uncaught TypeError: Cannot read property 'split' of undefined
/home/master/.atom/packages/git-control/lib/git-control-view.coffee:76
Hide Stack Trace
TypeError: Cannot read property 'split' of undefined
at GitControlView.module.exports.GitControlView.initialize (/home/master/.atom/packages/git-control/lib/git-control-view.coffee:76:50)
at GitControlView.View [as constructor] (/home/master/.atom/packages/git-control/node_modules/space-pen/lib/space-pen.js:184:25)
at new GitControlView (/home/master/.atom/packages/git-control/lib/git-control-view.coffee:36:7)
at Object.toggleView (/home/master/.atom/packages/git-control/lib/git-control.coffee:31:18)
at HTMLElement. (/home/master/.atom/packages/git-control/lib/git-control.coffee:18:57)
at CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app/src/command-registry.js:381:36)
at CommandRegistry.dispatch (/usr/share/atom/resources/app/src/command-registry.js:266:23)
at AtomEnvironment.module.exports.AtomEnvironment.dispatchApplicationMenuCommand (/usr/share/atom/resources/app/src/atom-environment.js:1382:34)
at EventEmitter.outerCallback (/usr/share/atom/resources/app/src/application-delegate.js:335:31)
at emitThree (events.js:116:13)
at EventEmitter.emit (events.js:194:7)
The error was thrown from the git-control package. This issue has already been reported.

Same issue here.

+1

+1

1

+1

Alternative https://atom.io/packages/git-controlhub

+1

+1

+1

+1

+1

It's worked !
https://github.com/jacogr/atom-git-control/pull/247

+1

same issue for me.

same issue for me. how to fix it ?

+1
Atom 1.22.1 x64
Ubuntu 17.10

+1

Please stop the +1's
You can thumb up the issue itself... Anyway, it is already fixed here as @mission802 said.

And what's the problem to correct the github repository to update the package through the Atom Updater ???

Well, the problem is @jacogr seems to be MIA. I'd suggest someone forks and maintains this if they don't surface soon.

@jacogr / @MarcelMue would you be willing to let me help with this project so that we can get this issue resolved and let people continue to use your great addition to atom?

+1

+1

+1

+1

ubuntu 17.10 Atom 1.24.0 x64
+

+1

same in windows 10

+1

+1

+1

+1


Go to bracket stopped working after update to 1.16

Go to Bracket "Ctrl + Shift + \ " stopped working after 1.16 update is installed. The cursor goes to the  matching bracket but the screen does not scroll to it.

VSCode Version: 1.16
OS Version: Windows 10

Steps to Reproduce:

Reproduces without extensions: Yes/No

Fixed in Insiders now. https://github.com/Microsoft/vscode/issues/32597


Googledrive rather than baidu because of non-accesibility

@jamycheung
Thanks for outsourcing datasets.
Baidu is not accesible in our country. Requesting you kindly upload to googledrive and do the needful

Hi @ChidanandKumarKS
We have limited space on google drive. Otherwise, you can also follow the original EventGAN to generate the event data. You only need the anchor and its previous frames, which are available on the respective public datasets.


HTTP path regex matching not working as expected for path with trailing slash

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: One line description
HTTP path regex matching not working for paths with trailing slash
Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

I am trying use the regex /status/200(/.*)?$ that should behave as follows:
should match: /status/200, status/200/ (note trailing slash), /status/200/foo
should not match: /status/200foo
I see that the following route configuration in envoy is rejecting requests whose :path equals /status/200/ (includes trailing slash). Per the regex /status/200(/.*)?$, this request should be a match, but Envoy rejects it with a 404.
Route:
"routes": [
         {
          "match": {
           "headers": [
            {
             "name": ":method",
             "safe_regex_match": {
              "google_re2": {},
              "regex": ".*"
             }
            }
           ],
           "safe_regex": {
            "google_re2": {},
            "regex": "/status/200(/.*)?$"
           }

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

See above route configuration to repro.
Envoy version: envoyproxy/envoy-alpine:v1.17.1
I used Golang's regexp lib to verify the expected regex behavior: https://play.golang.org/p/GGppRHeEoW8

Note: The Envoy_collect tool
gathers a tarball with debug logs, config and the following admin
endpoints: /stats, /clusters and /server_info. Please note if there are
privacy concerns, sanitize the data prior to sharing the tarball/pasting.

Admin and Stats Output:

Include the admin output for the following endpoints: /stats,
/clusters, /routes, /server_info. For more information, refer to the
admin endpoint documentation.

I see downstream_rq_4xx in the inbound RDS configuration increment for requests with :path /status/200/.

Upon reading the docs further, I came across a note regarding how trailing slashes are handled in prefix matches:
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto
Pay careful attention to the use of trailing slashes in the route’s match prefix value. Stripping a prefix from a path requires multiple Routes to handle all cases. For example, rewriting /prefix to / and /prefix/etc to /etc cannot be done in a single Route, as shown by the below config entries:

- match:
    prefix: "/prefix/"
  route:
    prefix_rewrite: "/"
- match:
    prefix: "/prefix"
  route:
    prefix_rewrite: "/"

I would expect this to be explicitly stated for the prefix field in the RouteMatch proto doc: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#config-route-v3-routematch

cc @alyssawilk

Hey @alyssawilk, is this expected?
Thanks!

I think that rule should match the URIs you list: https://github.com/envoyproxy/envoy/pull/15931
Do you perhaps have some other filter transforming your incoming requests?

I think that rule should match the URIs you list: #15931
Do you perhaps have some other filter transforming your incoming requests?

The configuration I have is simple and as follows:

An inbound listener that accepts connections
A filter chain that allows all traffic
An HTTP filter on the filter chain that references an RDS configuration
An RBAC filter on the filter chain with principal == permission == ANY
A single virtual host and route in RDS that wildcards the hostname and matches on the regex /status/200(/.*)?$, with an RBAC per route filter with principal == permission == ANY

    {
     "version_info": "7",
     "route_config": {
      "@type": "type.googleapis.com/envoy.config.route.v3.RouteConfiguration",
      "name": "rds-ingress",
      "virtual_hosts": [
       {
        "name": "ingress_virtual-host|httpbin.httpbin|*",
        "domains": [
         "*"
        ],
        "routes": [
         {
          "match": {
           "headers": [
            {
             "name": ":method",
             "safe_regex_match": {
              "google_re2": {},
              "regex": ".*"
             }
            }
           ],
           "safe_regex": {
            "google_re2": {},
            "regex": "/status/200(/.*)?$"
           }
          },
          "route": {
           "weighted_clusters": {
            "clusters": [
             {
              "name": "httpbin/httpbin-local",
              "weight": 100
             }
            ],
            "total_weight": 100
           }
          }
          "typed_per_filter_config": {
           "envoy.filters.http.rbac": {
            "@type": "type.googleapis.com/envoy.extensions.filters.http.rbac.v3.RBACPerRoute",
            "rbac": {
             "rules": {
              "policies": {
               "rbac-for-route": {
                "permissions": [
                 {
                  "any": true
                 }
                ],
                "principals": [
                 {
                  "any": true
                 }
                ]
               }
...

/status/200 returns a 200:
{"authority":"x.x.x.x","bytes_sent":0,"bytes_received":0,"x_forwarded_for":"<IP_ADDRESS>","path":"/status/200","upstream_host":"<IP_ADDRESS>:80","user_agent":"curl/7.68.0","method":"HEAD","response_code_details":"via_upstream","upstream_service_time":"1","protocol":"HTTP/1.1","duration":1,"time_to_first_byte":1,"upstream_cluster":"httpbin/httpbin-local","requested_server_name":null,"response_flags":"-","response_code":200,"start_time":"2021-04-13T18:22:54.456Z","request_id":"d99d10d4d5dea1100bbe7f9031440253"}

/status/200/ returns a 404:
{"time_to_first_byte":1,"x_forwarded_for":"<IP_ADDRESS>","duration":1,"start_time":"2021-04-13T18:23:03.730Z","user_agent":"curl/7.68.0","upstream_cluster":"httpbin/httpbin-local","response_code":404,"method":"HEAD","request_id":"581af1be07e339b32cd7e3960c3eee18","path":"/status/200/","protocol":"HTTP/1.1","response_code_details":"via_upstream","response_flags":"-","upstream_service_time":"1","requested_server_name":null,"bytes_sent":0,"bytes_received":0,"authority":"x.x.x.x","upstream_host":"<IP_ADDRESS>:80"}

I see stats related to the HTTP connection manager for the RDS increment when /status/200/ returns 404:
http.mesh-http-conn-manager.rds-ingress.downstream_rq_4xx: 5
listener.<IP_ADDRESS>_15003.http.mesh-http-conn-manager.rds-ingress.downstream_rq_4xx: 5

I figured the trailing slash doesn't work with the httpbin app that I am using even without Envoy, so it does not seem to be an issue here.
The http server I am using for my testing is the httpbin app from kennethreitz/httpbin image on Dockerhub.
$ curl -I http://httpbin.org/status/200/
HTTP/1.1 404 NOT FOUND
Date: Tue, 13 Apr 2021 20:42:22 GMT
Content-Type: text/html
Content-Length: 233
Connection: keep-alive
Server: gunicorn/19.9.0
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true

$ curl -I http://httpbin.org/status/200/
HTTP/1.1 404 NOT FOUND
Date: Tue, 13 Apr 2021 20:42:34 GMT
Content-Type: text/html
Content-Length: 233
Connection: keep-alive
Server: gunicorn/19.9.0
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true

Sorry @alyssawilk for the trouble, I somehow never suspected the httpbin app to fail requests whose :path have a trailing slash.


Make sure directories created before files copied

I was running into an issue where the system is attempting to create a file before the respective directories are created when up-zipping the jar - maybe because it was iterating through the files in a weird order. This makes sure that all files are created regardless of the order.

Perfect thank you! Will be in a release soon once I get time away from work!

@rmtmckenzie it's available in version 1.3.6. Thank you 😄


[docs] Fix a few typos

Found a few typos while searching for some info in the docs this morning, so ran the IDE linter searching for other typos. Let me know if there's any change that is unnecessary or incorrect, and I will edit it :+1:
Thanks
-Bruno

Hi Bruno, thank you very much for the corrections. All of them is absolutely fine except the one in  understanding_includes.rst, this change should be reverted.

Hi Bruno, thank you very much for the corrections. All of them is absolutely fine except the one in understanding_includes.rst, this change should be reverted.

Thank you for reviewing it, @sandorkertesz . Gah, I think that was me doing a CTRL+F and accidentally hitting a CTRL+V or some IDE button. Change undone, and commit updated. Thanks!


Can you pelase add a license?

Hi,
Thanks for putting this together! Any chance you could add a license? There's an overview of how to do that here:
https://docs.github.com/en/free-pro-team@latest/github/building-a-strong-community/adding-a-license-to-a-repository
Thanks!

Hi, sure I just added MIT license


It's straight away not working for me!!

Hello, i did all the configurations correctly on my vps on aws, it's gets me the uslr after the ssl setup but when i copy and use the link , it keeps on loading and the page doesn't load at all , please let me know the possible  solution!
@kgretzky
thanks

I am doing it for outlook!

Hello, i did all the configurations correctly on my vps on aws, it's gets me the uslr after the ssl setup but when i copy and use the link , it keeps on loading and the page doesn't load at all , please let me know the possible solution!
@kgretzky
thanks

i can help you with the<EMAIL_ADDRESS>

Hello, i did all the configurations correctly on my vps on aws, it's gets me the uslr after the ssl setup but when i copy and use the link , it keeps on loading and the page doesn't load at all , please let me know the possible solution!
@kgretzky
thanks

if you are on aws, its because you have not open the ports to the public, you have to open some port to allow the connections


Time Series Analysis using ARIMA for stock prediction

Hey @UppuluriKalyani ,
I would like to contribute by adding a time series analysis model for stock prediction as most the models found on internet use LSTM or other regression models and do not take the day of exchange into account . This model by taking date and dividing it into day, month and  year along with lags. A dataset found on internet was upgraded to support time series analysis and a ARIMA model is trained on it.

Time series analysis is part of advanced deep learning and just training in usual datasets dont work in time series analysis . please update to level2 atleast as this task took a lot of time in comparison to level 1 tasks

@DarshAgrawal14 show me the implementation then will see.


Split editor -- vertical -- does not work

Type: Bug
Here is the settings:
{
"workbench.editor.splitInGroupLayout": "vertical",
}
Try command workbench.action.toggleSplitEditorInGroup
REPRO:
The split happens horizontally.
Expected: vertical split
VS Code version: Code - Insiders 1.72.0-insider (c4722f1bb292284e0437eb7547808a5788fe6430, 2022-09-02T05:20:22.688Z)
OS version: Darwin x64 21.6.0
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
6, 6, 6

Memory (System)
16.00GB (0.12GB free)

Process Argv

Screen Reader
no

VM
0%

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vsdfh931:30280409
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30557515
vsaa593cf:30376535
pythonvs932:30404738
cppdebug:30492333
pylanb8912:30522163
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pylantcb52cf:30558419

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!