[Bug]: "apply_gptq_marlin_linear" Error When TP > 1

Your current environment
PyTorch version: 2.3.1+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.3 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.30.1
Libc version: glibc-2.35

Python version: 3.10.14 (main, May  6 2024, 19:42:50) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.16.20-3.el7.bzl.x86_64-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.1.105
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA L40
GPU 1: NVIDIA L40
GPU 2: NVIDIA L40
GPU 3: NVIDIA L40
GPU 4: NVIDIA L40
GPU 5: NVIDIA L40
GPU 6: NVIDIA L40
GPU 7: NVIDIA L40

Nvidia driver version: 535.104.12
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.9.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.9.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Address sizes:                   46 bits physical, 57 bits virtual
Byte Order:                      Little Endian
CPU(s):                          128
On-line CPU(s) list:             0-127
Vendor ID:                       GenuineIntel
Model name:                      Intel(R) Xeon(R) Platinum 8358P CPU @ 2.60GHz
CPU family:                      6
Model:                           106
Thread(s) per core:              2
Core(s) per socket:              32
Socket(s):                       2
Stepping:                        6
CPU max MHz:                     3400.0000
CPU min MHz:                     800.0000
BogoMIPS:                        5200.00
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 invpcid_single intel_ppin ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local split_lock_detect wbnoinvd dtherm ida arat pln pts avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq rdpid fsrm md_clear pconfig flush_l1d arch_capabilities
Virtualization:                  VT-x
L1d cache:                       3 MiB (64 instances)
L1i cache:                       2 MiB (64 instances)
L2 cache:                        80 MiB (64 instances)
L3 cache:                        96 MiB (2 instances)
NUMA node(s):                    2
NUMA node0 CPU(s):               0-31,64-95
NUMA node1 CPU(s):               32-63,96-127
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Vulnerable: eIBRS with unprivileged eBPF
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] optree==0.11.0
[pip3] sentence-transformers==2.2.2
[pip3] torch==2.3.1
[pip3] torchaudio==2.3.1
[pip3] torchelastic==0.2.2
[pip3] torchvision==0.18.1
[pip3] transformers==4.43.1
[pip3] triton==2.3.1
[conda] blas                      1.0                         mkl
[conda] ffmpeg                    4.3                  hf484d3e_0    pytorch
[conda] libjpeg-turbo             2.0.0                h9bf148f_0    pytorch
[conda] mkl                       2023.1.0         h213fc3f_46344
[conda] mkl-service               2.4.0           py310h5eee18b_1
[conda] mkl_fft                   1.3.8           py310h5eee18b_0
[conda] mkl_random                1.2.4           py310hdb19cb5_0
[conda] numpy                     1.26.4          py310h5f9d8c6_0
[conda] numpy-base                1.26.4          py310hb5e798b_0
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] optree                    0.11.0                   pypi_0    pypi
[conda] pytorch-cuda              12.1                 ha16c6d3_5    pytorch
[conda] pytorch-mutex             1.0                        cuda    pytorch
[conda] sentence-transformers     2.2.2                    pypi_0    pypi
[conda] torch                     2.3.1                    pypi_0    pypi
[conda] torchaudio                2.3.1               py310_cu121    pytorch
[conda] torchelastic              0.2.2                    pypi_0    pypi
[conda] torchvision               0.18.1                   pypi_0    pypi
[conda] transformers              4.43.1                   pypi_0    pypi
[conda] triton                    2.3.1                    pypi_0    pypi
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.5.3.post1
vLLM Build Flags:
CUDA Archs: 7.0 7.5 8.0 8.6 8.9 9.0; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    GPU1    GPU2    GPU3    GPU4    GPU5    GPU6    GPU7    NIC0    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      PIX     PXB     PXB     SYS     SYS     SYS     SYS     PXB     0-31,64-95      0               N/A
GPU1    PIX      X      PXB     PXB     SYS     SYS     SYS     SYS     PXB     0-31,64-95      0               N/A
GPU2    PXB     PXB      X      PXB     SYS     SYS     SYS     SYS     PXB     0-31,64-95      0               N/A
GPU3    PXB     PXB     PXB      X      SYS     SYS     SYS     SYS     PIX     0-31,64-95      0               N/A
GPU4    SYS     SYS     SYS     SYS      X      PIX     PXB     PXB     SYS     32-63,96-127    1               N/A
GPU5    SYS     SYS     SYS     SYS     PIX      X      PXB     PXB     SYS     32-63,96-127    1               N/A
GPU6    SYS     SYS     SYS     SYS     PXB     PXB      X      PXB     SYS     32-63,96-127    1               N/A
GPU7    SYS     SYS     SYS     SYS     PXB     PXB     PXB      X      SYS     32-63,96-127    1               N/A
NIC0    PXB     PXB     PXB     PIX     SYS     SYS     SYS     SYS      X

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

NIC Legend:

  NIC0: mlx5_bond_0

🐛 Describe the bug
The Code
from vllm.entrypoints.llm import LLM
from vllm.sampling_params import SamplingParams
model_path = '/models/Llama-3-8B_w8a16_packed_quantize'

tokenizer = AutoTokenizer.from_pretrained(model_path, trust_remote_code=True)
prompts = [
    "The president of the United States is",
    "The capital of France is",
    "The future of AI is",
]
# Create a sampling params object.
sampling_params = SamplingParams(temperature=0.0,
                                 max_tokens=256,
                                 stop=['<|end_of_text|>'],
                                 skip_special_tokens=False)

# Create an LLM.
llm = LLM(model=model_path,
                  tensor_parallel_size=2,
                  disable_custom_all_reduce=True,
                  trust_remote_code=True,
                  worker_use_ray=True,
                  quantization='compressed-tensors',
                  enable_chunked_prefill=False,
                  dtype='bfloat16'
                 )

The Mode Config with Compressed tensors
  "architectures": [
    "LlamaForCausalLM"
  ],
  "attention_bias": false,
  "attention_dropout": 0.0,
  "bos_token_id": 128000,
  "compression_config": {
    "config_groups": {
      "group_1": {
        "input_activations": null,
        "output_activations": null,
        "targets": [
          "Linear"
        ],
        "weights": {
          "block_structure": null,
          "dynamic": false,
          "group_size": null,
          "num_bits": 8,
          "observer": "minmax",
          "observer_kwargs": {},
          "strategy": "channel",
          "symmetric": true,
          "type": "int"
        }
      }
    },
    "format": "pack-quantized",
    "global_compression_ratio": null,
    "ignore": [
      "lm_head"
    ],
    "quant_method": "compressed-tensors",
    "quantization_status": "calibration"
  },
  "eos_token_id": 128001,
  "hidden_act": "silu",
  "hidden_size": 4096,
  "initializer_range": 0.02,
  "intermediate_size": 14336,
  "max_position_embeddings": 8192,
  "mlp_bias": false,
  "model_type": "llama",
  "num_attention_heads": 32,
  "num_hidden_layers": 32,
  "num_key_value_heads": 8,
  "pretraining_tp": 1,
  "rms_norm_eps": 1e-05,
  "rope_scaling": null,
  "rope_theta": 500000.0,
  "tie_word_embeddings": false,
  "torch_dtype": "bfloat16",
  "transformers_version": "4.42.3",
  "use_cache": true,
  "vocab_size": 128256

When tp=1, it is working fine， But When tp = 2 or tp = 4, NCCL ERROR occurs
The Model is Normal load, ERROR occurs when profile_run,
But when I use vllm0.5.1, I don't have this problem。
Hopefully this will help to see what's wrong and how I should fix it，Thanks!

The error message
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

Exception raised from c10_cuda_check_implementation at ../c10/cuda/CUDAException.cpp:43 (most recent call first):
frame #0: c10::Error::Error(c10::SourceLocation, std::string) + 0x57 (0x7f97fe0cf897 in /opt/conda/lib/python3.10/site-packages/torch/lib/libc10.so)
frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::string const&) + 0x64 (0x7f97fe07fb25 in /opt/conda/lib/python3.10/site-packages/torch/lib/libc10.so)
frame #2: c10::cuda::c10_cuda_check_implementation(int, char const*, char const*, int, bool) + 0x118 (0x7f97fe1a7718 in /opt/conda/lib/python3.10/site-packages/torch/lib/libc10_cuda.so)
frame #3: c10d::ProcessGroupNCCL::WorkNCCL::finishedGPUExecutionInternal() const + 0x56 (0x7f97b20738e6 in /opt/conda/lib/python3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #4: c10d::ProcessGroupNCCL::WorkNCCL::isCompleted() + 0x58 (0x7f97b20779e8 in /opt/conda/lib/python3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #5: c10d::ProcessGroupNCCL::watchdogHandler() + 0x77c (0x7f97b207d05c in /opt/conda/lib/python3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #6: c10d::ProcessGroupNCCL::ncclCommWatchdog() + 0x10c (0x7f97b207ddcc in /opt/conda/lib/python3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #7: <unknown function> + 0xdbbf4 (0x7f980e87fbf4 in /opt/conda/lib/python3.10/site-packages/../../libstdc++.so.6)
frame #8: <unknown function> + 0x94ac3 (0x7f980f9f6ac3 in /usr/lib/x86_64-linux-gnu/libc.so.6)
frame #9: clone + 0x44 (0x7f980fa87bf4 in /usr/lib/x86_64-linux-gnu/libc.so.6)

[rank1]:[E ProcessGroupNCCL.cpp:1414] [PG 2 Rank 1] Process group watchdog thread terminated with exception: CUDA error: an illegal memory access was encountered
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

Exception raised from c10_cuda_check_implementation at ../c10/cuda/CUDAException.cpp:43 (most recent call first):
frame #0: c10::Error::Error(c10::SourceLocation, std::string) + 0x57 (0x7f97fe0cf897 in /opt/conda/lib/python3.10/site-packages/torch/lib/libc10.so)
frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::string const&) + 0x64 (0x7f97fe07fb25 in /opt/conda/lib/python3.10/site-packages/torch/lib/libc10.so)
frame #2: c10::cuda::c10_cuda_check_implementation(int, char const*, char const*, int, bool) + 0x118 (0x7f97fe1a7718 in /opt/conda/lib/python3.10/site-packages/torch/lib/libc10_cuda.so)
frame #3: c10d::ProcessGroupNCCL::WorkNCCL::finishedGPUExecutionInternal() const + 0x56 (0x7f97b20738e6 in /opt/conda/lib/python3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #4: c10d::ProcessGroupNCCL::WorkNCCL::isCompleted() + 0x58 (0x7f97b20779e8 in /opt/conda/lib/python3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #5: c10d::ProcessGroupNCCL::watchdogHandler() + 0x77c (0x7f97b207d05c in /opt/conda/lib/python3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #6: c10d::ProcessGroupNCCL::ncclCommWatchdog() + 0x10c (0x7f97b207ddcc in /opt/conda/lib/python3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #7: <unknown function> + 0xdbbf4 (0x7f980e87fbf4 in /opt/conda/lib/python3.10/site-packages/../../libstdc++.so.6)
frame #8: <unknown function> + 0x94ac3 (0x7f980f9f6ac3 in /usr/lib/x86_64-linux-gnu/libc.so.6)
frame #9: clone + 0x44 (0x7f980fa87bf4 in /usr/lib/x86_64-linux-gnu/libc.so.6)

Thanks for the detailed report. I introduced an bug loading channelwise weights on TP>1 for compressed-tensors
The following PR should resolve your issue:

https://github.com/vllm-project/vllm/pull/6798

It will be in the next release. Do you need any help building vllm from source?

Also, thanks for using llm-compressor.
If you have any feedback on the UX or anything else, please don't hesitate to raise an issue in the llm-compressor repo so that we can continue to improve the experience.

Also, thanks for using llm-compressor.
If you have any feedback on the UX or anything else, please don't hesitate to raise an issue in the llm-compressor repo so that we can continue to improve the experience.

Thanks !


PR #561

Hi ,
I have raised a PR #561 to merge MATLAB templates . since no reviewers has been assigned yet i was wondering if i need to do anything else other than just PR to get these templates merged. Usually how much time should i expect PR to be merged in main .
Thanks and Regards
Nikhil

Thanks @DaniilShmelev for your response.

Hi @DaniilShmelev  any updates on this PR ?

@DaniilShmelev any updates on this PR ?


Examples for Yolo v3 (preferably tiny v3) in Detect objects using ONNX in ML.NET docs?

Please could the docs be updated for more modern yolo versions like v3? Preferably v3/v3 -tiny?
Yolo v3 tiny has 2 outputs rather than 1, the structure of the model is quite different so this tutorial doesn't work!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c2f95783-f8d3-b884-a67e-131eba39f59c
Version Independent ID: 622956b7-6556-7d5b-a6d1-436ceb9e68e6
Content: Tutorial: Detect objects using an ONNX deep learning model - ML.NET
Content Source: docs/machine-learning/tutorials/object-detection-onnx.md
Product: dotnet-ml
GitHub Login: @luisquintanilla
Microsoft Alias: luquinta

Hi @ROBYER1,
Thanks for your feedback. We'll take that into consideration into future updates made to this article.

Hi @ROBYER1,
Thanks for your feedback. We'll take that into consideration into future updates made to this article.


Adressing issue: Rename apps/Llama2App.py to follow snake case conven…

…tion #665
Description
The issue:
Rename apps/Llama2App.py to follow snake case convention #665
has been addressed.
Fixes (issue)
The relevant file, class and variable names have been renamed to snake case and references to these names in other files have also been modified.

[ ] Refactor (does not change functionality, e.g. code style improvements, linting)

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My changes generate no new warnings
[ ] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #665

@Ayesha-Imr can you please fix the test? I think you have to make the change here: https://github.com/embedchain/embedchain/blob/main/embedchain/init.py#L7

@Ayesha-Imr Can you please check the above conversations and resolve the conflict so we can review and merge?

Thanks for your contribution @Ayesha-Imr .
Will have to close this PR as there are so many merge conflicts and the code is not relevant now.


tensorflow.experimental.numpy.lcm giving inconsistent results

Click to expand!
Issue Type
Bug
Source
source
Tensorflow Version
tf 2.9.1
Custom Code
Yes
OS Platform and Distribution
Linux ubuntu 18.04
Mobile device
No response
Python version
3.8
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
I am trying to use the function `tf.experimental.numpy.lcm` but getting unusual results after doing a manual calculation.

Here is an example:
x = tf.constant([6], dtype=tf.int8)
y = tf.constant([22], dtype=tf.int8)

The expected lcm of the above two tensors should be a tensor `tf.Tensor([66], shape=(1,), dtype=int8)`

Standalone code to reproduce the issue
Using Tensorflow

import tensorflow as tf

x = tf.constant([6], dtype=tf.int8)
y = tf.constant([22], dtype=tf.int8)
print(tf.experimental.numpy.lcm(x, y)) # Current output: tf.Tensor([62], shape=(1,), dtype=int8)

Using numpy
import numpy as np

x = np.array([6], dtype=np.int8)
y = np.array([22], dtype=np.int8)
z = np.lcm(x, y)
print(repr(z)) # Output: array([66], dtype=int8)

### Relevant log output

_No response_</details>

@SuryanarayanaY
I was able to reproduce the issue on Colab using TF v2.11. Please find the gist here for reference.
Thank you!

Hi @hirwa-nshuti ,
Thanks for reporting. We have observed the behaviour of this API recently in #58619 and reported the same to Developer Team for action.
Thankyou!

Hi @hirwa-nshuti ,
The issue has been fixed in tf-nightly.Please refer to the attached gist.
Could you please crosscheck and confirm from your side? Please feel free to close if resolved. Thanks!

I am running the gist from my end but getting a runtime error🧐
RuntimeError                              Traceback (most recent call last)
RuntimeError: module compiled against API version 0xf but this version of numpy is 0xe

@hirwa-nshuti ,
The error is related to numpy version mismatch in Colab environment which appears some times. Could you please try upgrading numpy version to 1.22.4 using pip and then restart runtime in colab and check whether numpy version upgraded to 1.22.4. Once done you can test the code.
Please find the gist where I followed the above steps and able to resolve the reported runtime error and also the main reported issue addressed with latest nightly_version(tf_nightly-2.13.0.dev20230220).
Please check and close the issue if resolved. Thanks again for reporting the issue .

Hi @SuryanarayanaY
Thanks for fixing the issue I tested the code from my end and it works as expected🙂


First child of input group segmented buttons are off by $input-btn-border-width

http://v4-alpha.getbootstrap.com/components/input-group/#segmented-buttons
Input group with input-group-btn as first child that have multiple buttons inside are off by $input-btn-border-width.

Is this in reference to a known issue? Your code change doesn't do anything since the left margin is already 0. Also, I'm not sure what you're trying to solve.
PR's have a better chance of getting through if you can create an issue requesting the PR first.

Hey @oktalk,
I don't think this is a reference to a known issue. It's just something I stumbled across while using v4. It's hard to see on the docs page because the segmented button component isn't working. If you add flex-direction: row; to .input-group you can see it a bit better. Here is a gif of what I'm seeing.

It's not that noticeable because the borders are only 1px, but it becomes more apparent if you increase $input-btn-boder-width to something like 5px. This is what it looks like with this fix.

Thanks for the GIF. I see it now. That would be hard to explain without visuals.

Looks good, and added another fix for a related issue.


add files for package distribution

Based on https://packaging.python.org/en/latest/distributing/#initial-files, should have

[x] setup.py
[ ] setup.cfg
[x] README (.rst instead of markdown?)
[ ] MANIFEST.in
[x] pyJac package

9f5c4b5


Analyze all platform logs with severity warn and error

Currently our monitoring dashboard tells that Cloud Controller component constantly generates a few error and warn messages. I don't have access to all logs, but I suspect that other components do the same.
What we can do is the following:

Classify all error and warn messages generated by the platform. This will split all error messages by classes, where all similar errors will belong to the same class.
For each error message class we should provide a resolution by either making some configuration change, or making PR to the upstream, or adding this error class to the list of know errors.
We should generate pager duty alert, in case if an error occurred, that don't belong to the list of known error.

I agree.  We should look for and address warnings and errors for all platform components.

/cc @sharms

We should make sure bosh and its components are included, in addition to all other services provided (k8s, logsearch, etc.)
Related: https://github.com/18F/cg-atlas/issues/106


Add support for SimpleMerkleProof

Simple go proof format from tendermint.
Likely will be implemented in proofs-iavl as well. Need to add more testvectors here. Show the format is generic enough to capture this, before continuing on to #5

Closed by #18


HDDS-7748. Rename OMFileRequest.addToOpenFileTable() to avoid misuse.

What changes were proposed in this pull request?
Rename addToOpenFileTable() to addToOpenFileTableForMultipart.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7748
How was this patch tested?
No new test needed.

Thanks @szetszwo ! Merged.


Clarify categories (primary/secondary) of group contacts

https://github.com/Libera-Chat/libera-chat.github.io/blob/95be40b21d2ef8008bacb7b2d83abcc183bf2ec1/chanreg.md#L198-L199
I think this relates to "primary/secondary". I was asking on #libera and got the (inofficial) response that there's no real formal distinction between primary and secondary. Anyway, I think it would be helpful to document what primary and secondary contacts are instead of just telling people to reach out.
Also: Should be document what a valid set of contacts look like: Can there be more than one primary? Is "5 primary, 0 secondary" valid? Is "0 primary, 5 secondary" valid?  etc

I believe there's even been some internal confusion about this, but the clarification I put forward is:
secondary GCs cannot appoint or remove primary GCs, but can appoint secondary GCs.

I believe there's even been some internal confusion about this, but the clarification I put forward is:
secondary GCs cannot appoint or remove primary GCs, but can appoint secondary GCs.

I believe this should imply a rule that there must be at least one primary GC. Is this true?
I can open a PR to the chanreg page if you want.

@real-or-random that's why "your NickServ account name" is a separate question form additional group contacts, unless otherwise specified the requestor will be a primary GC

I see.

i wonder if the secondary GC thing is something we should advertise at all. it seems to serve mainly to confuse people. it may make some sense for huge projects with complex requirements, but in general authority to manage one's project registration is derived from demonstrable control of the project itself--a GC hierarchy shouldn't be necessary.

I think it makes sense to mention that it is an option so that those larger projects are aware, but the default should be private, primary if not specified, and we could move the question out of the form and have it in the additional text below. I think that was the original purpose, but it was too vauge and therefor caused more questions than it answered

I think it makes sense to mention that it is an option so that those larger projects are aware, but the default should be private, primary if not specified, and we could move the question out of the form and have it in the additional text below. I think that was the original purpose, but it was too vauge and therefor caused more questions than it answered

From my user perspective, I agree. It's probably a useful option to mention, and I don't think it causes confusion per se. What causes confusion is simply that there's no explanation in the form.

Should be closed by #107 . We've removed secondary GCs from the public docs for the time being, PAC intend to engage projects on an as-needed basis about them. Secondary contacts still have a place, but they don't need to be a thing most people worry about.
Reopen if you're wanting more changes.


upgraded to node20

Upgraded to node20 to get rid of following warning:
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, cloudflare/pages-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

I see there is already #118 open for this. Closing this duplicate.


Feature Request: allow parameter to ask for pseudo tty allocation for SSH PSSession

Summary of the new feature/enhancement

I am finding the SSH remoting feature very useful but it is lacking a featrure that the raw ssh command has. Raw SSH allocates a pseudo-TTY automatically for interactive sessions and of given the parameter -t it will also do that for a batch session. Can there be a similar option for New-PSSession and Enter-PSSession? Pseudo-TTYs are a must to run sudo in a remote interactive shell. The workaround of using <password> | sudo -s <command> violates a commonly held tenet of not typing passwords where command history may save them.  It maybe acceptable to do so in a batch script but not in an interactive setting where the user is there to type teh password when prompted.
Proposed technical implementation details (optional)
I propose a new parameter -AllocateTTY that would force allocate a pseudo-TTY. According to forums I have looked at the commonly used Renci.SSHNet library used for SSH in .NET applications surfaces this option in its APIs.

I expect that I can run sudo normally like when I use the normal ssh command whenever I create and enter a remote SSH based PSSession.

For reference #11343

Dup #1527


Add support for gpt-4-turbo

**Is your feature request related to a problem? I guess gpt-4-turbo would be faster ?
Describe the solution you'd like
Simply add options for using gpt-4-turbo in memgpt configure, i suppose that to tokenlimit need to be adjust too ?
Additional Context
maybe wait after gpt-4-turbo is fully released yet ?

#349


Grafana is unable to show the graph for bookinfo app

Bug description
Deployed the bookinfo app and expose the "productpage service" and generated traffic using the productpage svc route , but in Grafana dashboard nothing is showing up.
Expected behavior
Grafana should show the traffic in out of the box workload dashboard.
Steps to reproduce the bug
Deploy bookinfo On Openshift 3.11 (on IBM Cloud) and access the app using productpage svc (by exposing it securely)
Version (include the output of istioctl version --remote and kubectl version)
bash-4.2$ istioctl version --remote
client version: 1.3.2
citadel version: 1.3.2
egressgateway version: 1.3.2
galley version: 1.3.2
ingressgateway version: 1.3.2
pilot version: 1.3.2
policy version: 1.3.2
sidecar-injector version: 1.3.2
telemetry version: 1.3.2

kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-06T01:44:30Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2019-09-12T23:41:09Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"

How was Istio installed?
Using Helm (demo profile)
Environment where bug was observed (cloud vendor, OS, etc)
IBM Cloud

have you verified if Prometheus is set for Grafana ?

Your kubectl version is not compatible with your version of K8s. They need to be no more than one minor version apart. 1.11 works with 1.12 or 1.10.

We have dashboard tests that verify the underlying queries for the dashboards that run on all commits. We have not seen any issues with the dashboard. Are you sure that you have proxies injected, etc.?
You may be interested in the troubleshooting entries:

https://istio.io/docs/ops/common-problems/observability-issues/#missing-grafana-output
https://istio.io/docs/ops/common-problems/observability-issues/#verify-mixer-is-sending-metric-instances-to-the-prometheus-adapter

Closing for now, as this doesn't seem to be a general problem. Please reach out on the forums for related questions.


Enforce a dot before .devN release suffix

A fix similar to https://github.com/scrapy/scrapy/pull/2470.

Current coverage is 93.80% (diff: 100%)

Merging #42 into master will not change coverage

@@             master        #42   diff @@
==========================================
  Files            14         14
  Lines          1178       1178
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1105       1105
  Misses           73         73
  Partials          0          0

Powered by Codecov. Last update 85de25b...ae8e576


[Frontend] Add API call to frontend API for search

Details
After the searchbar has been added we need to add functionality to frontend/api/Api.ts
Tasks
[ ] - Create Get methods in the Api.ts that match https://github.com/R-Sandor/FindFirst/blob/main/server/src/main/java/dev/findfirst/core/controller/SearchController.java#L22

i would like to help u , pls assigne me

@vthuan-dev Sounds good! Thank you!

hi , did you set up backend for this issue ?
On Fri, Oct 25, 2024 at 7:44 PM Raphael J. Sandor @.***>
wrote:

Assigned #263 https://github.com/R-Sandor/FindFirst/issues/263 to
@vthuan-dev https://github.com/vthuan-dev.
—
Reply to this email directly, view it on GitHub
https://github.com/R-Sandor/FindFirst/issues/263#event-14873286041, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BHSIWE6NBERO3TXJXJHJ5BLZ5I4LNAVCNFSM6AAAAABQQ3L7VSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUHA3TGMRYGYYDIMI
.
You are receiving this because you were assigned.Message ID:
@.***>

Hi, I'm gravitate toward this issue. I have some idea since I've worked on this a couple times and can open a PR to discuss further. Thanks for considering me.

Maybe I can participate in solving this issue then #264. Can you assign me?

@vthuan-dev Hey sorry for the late reply here. Been busy week with a new born. The end points are there but they don't return anything yet.
I still the frontend to have the HTTP.GET though to mirror the uri.

I am new here and still working on it. Please excuse me if i am slow.

Do you have any questions?
The API endpoints that you're adding are in this file:
https://github.com/R-Sandor/FindFirst/blob/main/server/src/main/java/dev/findfirst/core/controller/SearchController.java#L22
You'll need to look at that signature at the top of the Get Mapping then add a similar path to the api.ts
https://github.com/R-Sandor/FindFirst/blob/main/server/src/main/java/dev/findfirst/core/controller/SearchController.java#L22
So yours might look something like
searchBookmarksByTitle(title: string) {
  return instance.get("PATH",  searchBkmkByTitleReq) // copy the same params located in Java
}

RequestBody fields:
https://github.com/R-Sandor/FindFirst/blob/main/server/src/main/java/dev/findfirst/core/model/SearchBkmkByTitleReq.java
Example of the request body  json object:
{
  title: "the search title here"
}

@AchuthRKumar, Yeah that's a little bit of a hurdle because we don't have it connect to the search bar yet #262

Hey I am closing the ticket. I started working on it because of that hurdle we talked about above.

@AchuthRKumar thank you for your help!


Info about sandboxes in readme

 $ cd <path to mylibrary>
 $ cabal sandbox init
 $ cabal sandbox add-source <path to IHaskell source>
 $ cabal install myLibrary IHaskell
 ...
 $ cabal exec -- IHaskell notebook

...and the sandbox package db will be in scope in the IHaskell notebooks.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/4236442-info-about-sandboxes-in-readme?utm_campaign=plugin&utm_content=tracker%2F332399&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F332399&utm_medium=issues&utm_source=github).

Consolidating into #410.


Add a bunch of new modifiers and compatibilities with mod Ars Elemental

Hi there, I'm a big fan of tinkers construct and your project. I've known about Chinese community shows great interest of adding RF modifiers so i worked a lot these days to add some of them to the game.

i took much time getting around with tc's modifier system, and it finally seems to be working well though

i'm also adding the compatibilities with ars elemental (a popular ars nouveau addon) to the mod.

(with 4 elements)
this shall be an upgrade (but consumes an ability slot) of archmage modifier.
zh_cn.json also upgraded

Hey, appreciate the PR. I will need to spend some time and review this. There are many issues with this PR, including changes to the build file that are essential for my uses that absolutely need to not be removed. I can probably extract the working code from this and test, but it will take some time. This isn't usable as-is, but I will comment once I can extract working code and test a bit.
In the future, please do not delete things out of the build file, as it is essential for publishing and testing.
One other issue is that the updated translation file will need to be verified by another native speaker. I have a couple folks who have done translations for our mods if you don't know anyone. https://github.com/wendall911/TCIntegrations/pull/65/commits/f4dfa4c145fdab0f4207c63f432ad24b787fe9e6

thanks a lot. the build file changes as i failed to load maven repo from githubpakages and to prevent accidentally publishing or misclicking. sorry for that!

Ok, after looking this over, I can't accept it as-is, but I can extract the code and give credit to you for the contribution. There are too many things that need to be changed to ask for a simple edit and resubmission. I might be able to use some of the commits, but will need to edit most things.

There are too many issues with this PR to accept it. Needs a lot of cleanup. I see there is a sound file that is registered, but no licensing information about the file.
Given I have to maintain the features, it would need a lot of changes and match coding styles and naming to be useful for me to maintain.
For me to be able to accept Pull Requests, they need to be smaller and at minimum match the existing coding style. Making build file changes, adding unlicensed sound files and language translations is not something I can work around until it gets resolved.
Maybe if I have some time later I will clean this up and use some of it. But for now I need to close this. I do appreciate the effort though. I"m sure it works for you. Just not something I can justify working on.

that's no problem. thanks for suggestions :)


Version bump

Codecov Report

Merging #97 (46405bc) into main (77e171b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines          184       184
=========================================
  Hits           184       184

Impacted Files
Coverage Δ

sas7bdat_converter/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e171b...46405bc. Read the comment docs.


Update Gitignore

$subject

Codecov Report

Merging #361 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #361   +/-   ##
=========================================
  Coverage     79.22%   79.22%
  Complexity      726      726
=========================================
  Files            66       66
  Lines          3129     3129
  Branches        299      299
=========================================
  Hits           2479     2479
  Misses          509      509
  Partials        141      141

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a225593...ab89332. Read the comment docs.


chore(refactor): Search for .conda packages to upload too

Part of issue: https://github.com/rapidsai/build-planning/issues/98
Uses find's -o option to search for .conda or .tar.bz2 files to upload
Once collected the anaconda upload command later should take care of the rest

Hey @jakirkham I change the titled of this to start with chore(refactor). This repo uses https://github.com/semantic-release/semantic-release to automatically do a version bump + release on new commits, based on their title.
From that project's docs:

Commits starting with chore don't lead to a new release (see the history at https://github.com/rapidsai/dependency-file-generator/commits/main/). Since this change is only modifying a CI script, I don't think we want it to trigger a new release of rapids-dependency-file-generator.

Ok sounds good. Thanks James! 🙏
Appreciate the help reviewing these and the detailed explanation

:tada: This PR is included in version 1.15.0 :tada:
The release is available on:

GitHub release
PyPI release
Conda release - rapidsai
Conda release - rapidsai-nightly

Your semantic-release bot :package::rocket:


Expose hot restart in Flutter Driver

Use case

Proposal

I opened on accident, without having filled out the template.


[SPONGE] Where is the version for API 7?

My server's version is 1.12.2 and the sponge API version is 7.1.0. But the latest version in Jenkins is for sponge API 8, and the old versions are for sponge API 6, where is the version for sponge API 7?
If LuckPerms doesn't support API 7, then I didn't say anything.
(I really don't know where it is, or my eyes broken?)
I need some help, thank you!
If you think my English is weird, that's absolutely right.

The LuckPerms-Sponge jar works on all API releases from 5 to 8.

Thank you very much.
But my server said

Sponge The mod luckperms was designed for spongeapi 8.0.0-SNAPSHOT but spongeapi 7.1.0-SNAPSHOT-d453c3e is in use. It may not work properly.

Should I ignore it?

Yep :)


Copy Notebooks Automatically

Copy over all notebooks in the notebooks directory so we do not need to update the Dockerfile for each new notebook.

@ilumsden Is there any specific reason the notebooks were originally copied one-by-one instead of the whole directory like the data directory?

Mainly because copying directories is very finicky in Dockerfiles. If you do it right, it's fine. But, if you don't, you can cause a ton of issues.

@ilumsden Does the way the notebooks directory is copied avoid the Docker issues?


DuckDuckGo logo

how about DuckDuckGo search engine logo?
https://duckduckgo.com/assets/logo_homepage.normal.v107.svg

Added fc2976afab04ad40f1db4ba37b2b1217301f9595
Thanks!


Error types in connection status: Wallet cannot connect to node(s)

Wallet cannot connect to 1 node https://zpl.io/2jzdEqQ

wallet status "connection to BITCOIN CASH node lost: <IP_ADDRESS>" and button "Change settings"
"Change settings" leads to settings screen and required node (here: Bitcoin cash) settings open.

Wallet cannot connect to 2 nodes or more https://zpl.io/aw8M9EK

wallet status "lost connection to nodes: BTC, LTC" and button "Change settings"
"Change settings" leads to settings screen and open first in order node settings.

Wallet cannot connect to BEAM node and another nodes (BTC, LTC etc) please display info about BEAM first in the status
https://zpl.io/2pp0DvM

need to be discussed

implemented as part of #188

@Roberrtt
please make text similar for all error types:
1 node lost connection: "connection to BITCOIN CASH node lost: <IP_ADDRESS>"
2+ nodes lost connection: "connection to BTC, LTC nodes lost"
current implementation is a bit different "lost connection to nodes: BTC, LTC"

1.If the wallet is connected to electrum , the node settings are displayed in error

2."Change settings" leads to settings screen and open first in order node settings.- Not done
3 -Change to full name of the node if wallet cannot connect to 1 node

4.When all nodes were connected with errors, then after disconnecting them, the error remains on them

Connect all nodes to the network not working
Make a discount and delete all data except 1 node
Connect the node to a non-working network

5 When the wallet was connected to 2 nodes and make changes in 1 node, there is no error about another connection

if at least one node has lost connection, the public offline address isn't available

2.when one of the nodes has lost the connection, and the second node is connection at this time, the indicator displays the online status of the integrated node. during the connection of the second node, the indicator should show that it cannot connect to the first node

checked


Api for timestamp

Student, group:  Остапчук Андрей, 3530901/90203
URL: https://github.com/Br0mm/SoftwareEngineeringLabs
Git approach: git-flow

`+


improve pre-commit workflow

Add default permissions, and also prevent it from running in forks, same as other workflows.

/cc @Rozzii
/assign @lentzi90

Failure pre-exists in source, going to be fixed in #357 .

/lgtm


fix: enhance constuctor

ref to discussion at https://github.com/node-casbin/prisma-adapter/pull/25#discussion_r616556606
In TypeScript, constuctor didn't support overload. I didn't find an elegant way to implement this.
Any suggestion? @Sefriol @hsluoyz

@Zxilly ok, I'm not aware of it before. Then let's go with 1st option.
BTW, did refactor: keyword generate a semantic-release? If not, please use fix: instead.

@hsluoyz I have no idea about that. Maybe we can use fix to trigger a patch version.

@Zxilly why there's no release for this PR?

And also I want a bot like this one: https://github.com/casbin/node-casbin/pull/251#issuecomment-813295349

Can you fix these two issues?


Access from Teleport script to other game scripts

Hello, I need to know when the user teleport to save some data. To do that I need to tell my GameController when the user is teleporting but I can't access my GameController script from the Teleport script. I was looking for some info and I see that is because of the compilation order. Is there any way to solve this?
Thanks!

If you need to modify the teleport script our recommendation would be to make a copy of it and rename it so it doesn't get overwritten in the future. You can remove the namespace line too.

If you need to modify the teleport script our recommendation would be to make a copy of it and rename it so it doesn't get overwritten in the future. You can remove the namespace line too.

I have tried to duplicate "Teleport", "TeleportArea", "TeleportArc" and "TeleportURPHelper" (as my project is an URP one)and I have removed the namespaces but  I am having the following error:
"Material 'URPTeleportAreaVisible' with Shader 'Universal Render Pipeline/Particles/Unlit' doesn't have a color property '_TintColor'"
I think this is comming from this line of code:
#if UNITY_URP 		tintColorId = Shader.PropertyToID( "_BaseColor" ); #else 		tintColorId = Shader.PropertyToID("_TintColor"); #endif
The else part of the code is beeing executed but I am using URP so the first part of the if should be executed. This does not happen with the Teleport prefab that is provided. Also, in my code, the first part of the if is like commented (gray color)


[Adaptive] [LG] Create tooling to auto generate LG Template constants from LG files

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
4.6.0-Daily-2019-07-17-01
Describe the bug
While using LG template in legacy dialogs like waterfall dialogs, incorrect/missing template name
could only be found in runtime which is a little bit suffer.
Except:
Have an indicator generator in VS Extension/VSCode Extension to generate all available template name list like this:

With this indicator, developers can easily refer the template name instead of hardcoded strings to reduce runtime error.
To Reproduce
Currently this is how we call LG in waterfall:
var result = await lgMultiLangEngine.Generate(turnContext, "[CancellingMessage]", null);
The [CancellingMessage] is a hardcoded string and can be easily misspelled. The code style with so many hardcoded strings is bad and when the template name is changed, it is easy to generate runtime error everywhere.
Expected behavior
Have a generator to help generate an indicator for a target LG file. And use LG like this:
var result = await lgMultiLangEngine.Generate(turnContext, SendEmailResponses.CancellingMessage , null);

@boydc2014 - in a spirit similar to LUISGen, we should consider adding this capability to the MSLG CLI - ability to generate a C#/ TS/ JS variants.


Option to set log level

I'm using FMI.jl (and therefore FMIImport.jl) to simulate OpenModelica FMUs.
When running fmu = FMI.fmiLoad(fmuPath) I'm getting a bunch of info messages about empty files.
julia> fmu = FMI.fmiLoad(fmuPath)
[ Info: fmi2Unzip(...): Written file `binaries/linux64/simpleLoop_FMU.libs`, but file is empty.
[ Info: fmi2Unzip(...): Written file `sources/simpleLoop_11mix.h`, but file is empty.
[ Info: fmi2Unzip(...): Written file `sources/simpleLoop_includes.h`, but file is empty.
[ Info: fmi2Unzip(...): Written file `sources/simpleLoop_FMU.libs`, but file is empty.
[ Info: fmi2Unzip(...): Written file `sources/isfmi2`, but file is empty.
[ Info: fmi2Unzip(...): Successfully unzipped 229 files at `/tmp/fmijl_HTprAI/simpleLoop.interface`.
[ Info: fmi2Load(...): FMU resources location is `file:////tmp/fmijl_HTprAI/simpleLoop.interface/resources`

It would be nice to get the option to disable info prints from all and/or specific parts of FMImport.jl with some setting in FMI.jl.
My workaround for the moment is to use Suppressor.jl
local fmu
Suppressor.@suppress begin
  fmu = FMI.fmiLoad(fmuPath)
end

Hi,
does this solve your issue: https://thummeto.github.io/FMI.jl/dev/features/#Printing-internal-FMU-messages ?
So myFMU.executionConfig.logStatusOK=false ?
Best regards!

This will be part of FMI.jl v0.10.1 / FMIImport 0.12.0:
function fmi2Load(...; logLevel::FMULogLevel=FMULogLevelWarn) as default so no info messages are printed anymore, available options are FMULogLevelInfo (print the old info messages, FMULogLevelWarn print warnings and errors (default) and FMULogLevelError print errors only.

Sounds perfekt.

Implemented in v0.12.0!


Bugfix

We compare the sets and not the ordered lists. Very important fix
How to test:

[x] see below

Expected test outcome:

[x] Take a screenshot and attach or copy/paste the output.

Review:

[x] code approved by @mayabrandi
[ ] tests executed by
[ ] "Merge and deploy" approved by
Thanks for filling in who performed the code review and the test!

This is patch version bump because it's a fix

Has been tested through cg on stage and the data was properly generated and loaded into the trending database.
The command witch was run on hasta was:
cg -c /home/proj/stage/servers/config/hasta.scilifelab.se/cg-stage.yaml upload vogue genotype -d 3000
The output lookes like this:

Nice done!

Output from  genotype export-sample-analysis -d 100
Highlighted an exaple rs number for a sample where the internal analysis (sequence key) reported TC and the MAF analysis(genotype key) reported CT. The comparison should be true, which it is. Before the bugfix it was false.

deployed on hasta


Cannot cmd+click video links (on lbrytv)

Bug
Cannot cmd+click on video links to open them in a new browser tab.
Additional context
cmd+click works on tags and menu items as expected.

This is now fixed


ExperimentData method to extract multiple samples by index.

Request to add a method to the ExperimentData object to extract multiple ExperimentSample objects by given a iterable of indices.
          Expected method to extract sample by index.

Please check the review comments on the code.
I suggest enriching this method to extract multiple samples (e.g., tuple[ExperimentSample]) from an iterable of indexes or create a new method (e.g., get_experiment_samples(...)) for this purpose. This is a simple improvement that avoids burdening the user with the task of implementing an explicit cycle to extract multiple samples.
Originally posted by @BernardoFerreira in https://github.com/bessagroup/f3dasm/pull/199#pullrequestreview-1701761605

The method  ExperimentData.get_experiment_samples has been implemented. Closing this issue


Jg importbgen

Hi, Is there a plan to merge this branch in soon? We are testing out HAIL for some of our in-house pipelines and an ability to import bgens would be really handy.

Hi @WaqAli, I've fallen behind reviewing branches, but I plan to get back to this soon.  I will keep you posted.

@WaqAli BGEN import/export and PLINK import has now been merged into the master here: https://github.com/broadinstitute/hail/pull/573.  Let us know if you run into any problems!


Question about compatibility

Hi~  , I didn't get it , why the code can not support IE9 .
I didn't get the point.
Thank you.

Most of them should support IE9, but not fully tested, so use them on your own risk.
Some of the features you need to notice:

classList started at  IE10
requestAnimationFrame started at IE10, but can be easily poll-filled.

I get it , cool~
Thank you~


101-azure-virtual-desktop-anf - remove unused outputs

The error message indicates that it needs the existing vnet and aad user but they don't exist in Azure. So it's not related with this PR. I think we can fix the output error first.

Sure. I will close this PR.


feat: Map Chart Reskinning

Description
This PR fixes UI inconsistencies in the Map Chart widget.

Use font Family from the theme
Fix caption styles
Fix legend styles
Fix chart spacing

Another PR, #16922, has been raised which adds the changes required to inherit font family from system themes. #16922 should be merged before this PR to enable testing on DPs.
Fixes #10981
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually (a fresh local backend build was used to test theming).
Tested migrations by creating an app on release, then importing that app on local and testing the font family.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Do we need migration for this PR that will add font family to the existing app's map chart? @dilippitchika

Yes for existing themes we should handle it

@jsartisan @dilippitchika, have added migrations.

/ok-to-test sha=fc93433

/ok-to-test sha=fc93433
There are lot of negatives in the perf test, re running again.

Tested and verified.


Feature request for RemBackground

Describe the problem
Your Rem background node is less precise than others more accurate version like BRIA and BiRefNet

Cons >Your version in some images create hole inside the image it don't detect the border accurately
Pro > I like that it let user change the background color :: useful for 3DTech like Comfy3DPack, TripoSR etc...

Describe the solution you'd like
Implement others Rem-Background model like in the screenshot so we have more option with the ability to change Back. color

Alternatives considered

Additional context
No response

BiRefNet do a great job in separate the subject from the background no hole, the same from RemBG from LayerStyle node.
By the way thanks a lot for you node pack really useful great job.

Hi,
BiRefNet is planned but I don't think I will implement other methods.
I did not know about LayerStyle but their implementation looks good and they already bundle multiple variants (rembg, briar etc..)
The node in mtb is a simple implementation of the original RemBg that seem to have since received a few nice updates, I will also fetch those.
TLDR, yes for BiRefNet and updating rembg's update but for other methods I suggest dedicated extensions like LayerStyle and VideoMatting


tests: fix tests that use Chat Input

This pull request addresses visibility issues with the Chat Input in the test suite. The fit view action has been commented out to prevent it from hiding the Chat Input during tests. Additionally, the tests have been updated to use Text Input instead of Chat Input, as the latter starts minimized, ensuring that the tests run smoothly without UI interruptions.

FYI, @lucaseduoli, @Cristhianzl

@ogabrielluiz #5421


Research Spike: Deployment Guides

The current state of lightwalletd deployment is fairly polished but somewhat unclear as multiple parties and teams have worked on it. The intent of this research spike is to consolidate all of that information and should result in a list of PRs from any remaining deployment work that should be merged to lightwalletd master and a ticket to update the README with the current recommended method of deploying lightwalletd.
Timebox: 4 hours
Outcomes:

[x] List of PRs or commits that should be merged back to lightwalletd master
[ ] A ticket outlining the README changes that need to be merged.

PRs to be merged:

https://github.com/zcash/lightwalletd/pull/172 (Add http endpoint and prometheus metrics framework)
https://github.com/zcash/lightwalletd/pull/175 (Use cobra and viper for configuration)

Also, CI for docker image builds (no ticket yet, Ben is writing one).
I don't think we should update README.md using a separate ticket; those PRs should include appropriate updates to that file. I made comments in those PRs asking that they include README.md updates.

@benzcash just created this, a third and I think final PR for this research spike:
#215 (Add docker image build and upload to CI)

Linda is coordinating with Ben to get this done.


[Priority] Document Release versioning

We need to document draft releases and the process associated with it. Maybe along with the draft release, we can have a documentation page for the releases section itself. Explaining the different fields. We can discuss further what the page can look like and what will it contain.
At the moment, we only have documentation in balena-cli: https://www.balena.io/docs/reference/balena-cli/#release-finalize-commitorid which is not enough.
Edit: It seems you can finalize draft releases using the UI. But the process is pretty sneaky. So we should definitely write something about it. Maybe a new page in deploy section called Draft releases.

FD thread: https://www.flowdock.com/app/rulemotion/r-beginners/messages/416900

Also somewhat related: https://jel.ly.fish/5ba33da8-671a-45de-aa29-67b36a6d8426


Autoplay

Hello, I just wanted to share my AutoPlay solution in case someone can profit it...
class AutoPlay extends React.Component<any, any> {
static contextTypes = {
carouselStore: PropTypes.object.isRequired
}
constructor (props: any) {
super(props)
}
componentDidMount () {
const { carouselStore }: any = this.context

setInterval(() => {
  const { currentSlide, step }: any = carouselStore.getStoreState()

  const maxSlide = this.props.totalSlides - this.props.visibleSlides
  let newCurrentSlide = Math.min(
    (currentSlide + step),
    maxSlide
  )

  carouselStore.setStoreState({
    currentSlide: newCurrentSlide === maxSlide ? 0 : newCurrentSlide
  })
}, 2000)

}
render () {
return null

}
}
I don't know if this is the right place, thanks for reading.

Autoplay is now a feature in v1.12.0

Great, thanks


APIError(code=-2010): Account has insufficient balance for requested action.

For some reason I don't understand yet - it could not sell the 2563 CKBUSDT it bought...  through the binance interface i could only sell 2560 (but in the history it did buy 2563)  ... does that make any sense?
CKBUSDT has gained 5.143% in the last 5 minutes, calculating volume in USDT
 preparing to buy 2563 CKBUSDT
TP or SL reached, selling 2563 CKBUSDT...
APIError(code=-2010): Account has insufficient balance for requested action.

Any news on this issue? Guess we have to implement an auto-buy bnb feature? What do you think?

The approach with SELL_AMOUNT = 99.25 should do the trick, but fee is 1.5%, 0.75% is only when using BNB.

Better to receive current fee percent from binance with API https://python-binance.readthedocs.io/en/latest/binance.html#binance.client.Client.get_trade_fee
And just calculate it including that fee

Same issue after updating the current code..
Any ideas how we can overcome this error from happening?
TP or SL reached, selling 39.82 UTKUSDT...
APIError(code=-2010): Account has insufficient balance for requested action.
not enough time has passed yet...
^C

can we sell on different exchange? also..what about triangular arbitrage for profits

How we can solve this error？
APIError(code=-2010): Account has insufficient balance for requested action.

I was just able to resolve it and sell a coin. It seems as though the Capped_Sell and Sell_Amount have been removed from the current code. Look at @Eugnis comment from 3 days ago: https://github.com/CyberPunkMetalHead/Binance-volatility-trading-bot/issues/24#issuecomment-836887498 and replace the green code in yours. Lines 252-257 and 260-263 should be replaced.

I was just able to resolve it and sell a coin. It seems as though the Capped_Sell and Sell_Amount have been removed from the current code. Look at @Eugnis comment from 3 days ago: #24 (comment) and replace the green code in yours. Lines 252-257 and 260-263 should be replaced.

How we can solve this error？
APIError(code=-2010): Account has insufficient balance for requested action.

I was just able to resolve it and sell a coin. It seems as though the Capped_Sell and Sell_Amount have been removed from the current code. Look at @Eugnis comment from 3 days ago: https://github.com/CyberPunkMetalHead/Binance-volatility-trading-bot/issues/24#issuecomment-836887498 and replace the green code in yours. Lines 252-257 and 260-263 should be replaced.

How we can solve this error？
APIError(code=-2010): Account has insufficient balance for requested action.

I was just able to resolve it and sell a coin. It seems as though the Capped_Sell and Sell_Amount have been removed from the current code. Look at @Eugnis comment from 3 days ago: #24 (comment) and replace the green code in yours. Lines 252-257 and 260-263 should be replaced.

"pay fees in BNB "  enabled or disabled?

How we can solve this error？
APIError(code=-2010): Account has insufficient balance for requested action.

I was just able to resolve it and sell a coin. It seems as though the Capped_Sell and Sell_Amount have been removed from the current code. Look at @Eugnis comment from 3 days ago: #24 (comment) and replace the green code in yours. Lines 252-257 and 260-263 should be replaced.

"pay fees in BNB " enabled or disabled?

enabled with bnb funds in account.

I've got bnb funds in account and this flag enabled - still get the error
I've also turned off "pay fees in bnb" and I still get the error

ok so. I had to add the CAPPED_SELL code back and it seems to work better. not 100% tho - am still getting Filter failure: LOT_SIZE

This is annoying, I cant figure it out :/

Fixed, you just need to have some BNB

This is still happening, I have plenty of BNB in my account.

This is still happening, I have plenty of BNB in my account.

@iamraffe, do you have USDT in your account too?

Yep. I added back the code from one of the comments above and was able to sell some of the coins, not having a LOT_SIZE error and looking into it.


LXC Wild VM

Description
Allow importing running LXC instances, not managed by OpenNebula, on OpenNebula nodes. The instances should support almost every feature available for regular instances, except the ones involving storage operations.
Use case
Manage containers running prior to an OpenNebula deployment.
Interface Changes
none

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

wontfix


Revert "Fix client subnet mask"

This commit accidentally breaks IPv6 when several clients are connected at the same time, and it is more correct to use /24 and /64 subnets as it is used in WireGuard examples (for example,  Basic Usage).

I explained that commit poorly. In an IPv4 scenario the following applies: (source)

Node is a client that only routes traffic for itself
Address = ${CLIENT_WG_IPV4}/32
Node is a public bounce server that can relay traffic to other peers
When the node is acting as the public bounce server, it should set this to be the entire subnet that it can route traffic, not just a single IP for itself.
Address = ${CLIENT_WG_IPV4}/24

Based on the issue you raised, I'm not sure at this point why it wouldn't work the same for IPv6. And it doesn't make sense to me the fact that you changed the Address to /24 and /64 when you don't update the AllowedIPs too for that to properly work. Did I miss somehting here, I'd like to know?

I can't explain myself because of my poor language skills, but I can give a link to Reddit, where it has already been discussed.

The post you linked shows that the user took the code samples from the Arch Wiki but it looks like that page was updated because the client addresses are /32 now (I don't have an account to see the history). At the same time the suggestion to use /24 remains in the Talk section.
If you are certain the problem is with /32 then we can revert back to use /24 for the client network too, it is used in a multi-peer network anyway as you said.
Thank you for reporting this.

I can't 100% guarantee that it's true, but in my case it helped me to fix the following things:

IPv6 is now working;
Now the devices are guaranteed to connect to the server (previously some device might not connect, which is very strange, perhaps somehow there was a conflict of IP addresses, which is impossible);

Anyway, I have already replaced subnets a few weeks ago and still have no problems.

I will close this for now, I don't think we received similar reports about this kind of issue.


Docker API

Closes #181
Instead of working with the CLI, I am invoking the Docker API via the Dockerode library. I also cleaned up AutoTest.ts: renamed invokeContainer() to handleTick() and handle much of the record keeping that was originally done there instead in GradingJob. Removed more unused files.

Pull Request Test Coverage Report for Build 852

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.082%

Totals

Change from base Build 849:
0.0%

Covered Lines:
3292

Relevant Lines:
4823

💛  - Coveralls


Download ICS test failing

The event that is getting produced for a fall quarter course has the winter quarter start date for some reason, and this started after we updated the term list to include winter.

My guess is that this test might call getDefaultTerm() and will create a winter quarter event

This is incorrect. The custom event has the wrong start date. Custom events are assigned the current default term, which has changed. The course still has the correct data because its terms are assigned directly in the object.


Shouldn't headers be visible even if there are now rows?

Currently we show nothing if there are now rows e.g. no allocations.

Won't it make more sense to show empty table instead?

What do you think?

Yeah, it's probably more indicative that there really are no allocations and not some random error happening.

OK


partners: add hybrid to PineconeVectorStore

Description:

Add hybrid functionality to partners pinecone vectorstore
Enable use of PineconeVectorStore with SelfQueryRetriever
Add unit tests
Update integration tests
Add to example documentation of vectorstore usage
Add to example documentation of selfquery usage

Issue: #19418
Dependencies: pinecone_text
Twitter handle:  @json_dmp

Hey there! I don't think this change is desirable because it introduces other dependencies to the pinecone package and is causing errors, so I will close it.
If you work at pinecone or are working with someone at pinecone, could you tag them in or contact us over slack?


Added Hashing Algorithm

📥 Pull Request
Description
added Hashing Algorithm Introduction, Characteristics, working, Complexity analysis, example.
Fixes #1005
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Hi @ajay-dhangar can u review the pr


addcolumn with user name

Hello
This might be a very small question, but i can't seem find it. So don't start laughing :)
I have a table/model with a user id column that corresponds to the user id from the built-in users table
I want to display the user name in a column in another crud.
I figured i'd use a addColumn of type "select" in the crud controller.
But i'm unsure as to what the model reference should be.
    $this->crud->addColumn([ // n-n relationship (with pivot table)
        'label'     => "User", // Table column heading
        'type'      => 'select',
        'name'      => 'orders_user_id', // the method that defines the relationship in your Model
        'entity'    => 'users', // the method that defines the relationship in your Model
        'attribute' => 'name', // foreign key attribute that is shown to user
        **'model'     => 'backpack.permissionmanager.user_model' // foreign key model**
    ]);

Or is this not the correct way to do it ?

Hi,
Sure, no problem, the model should me the path to your users model. If you have a relationship with the stock Laravel user model, it should be:
'App\User'
Hope it helps. Cheers!

Thanks, that helped.
Using 'App\Model' and a $this->hasOne relation in the model did what i was looking for.
thnx!


async_web_server_cpp: 0.0.3-0 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository async_web_server_cpp to 0.0.3-0:

upstream repository: https://github.com/GT-RAIL/async_web_server_cpp.git
release repository: https://github.com/gt-rail-release/async_web_server_cpp-release.git
distro file: melodic/distribution.yaml
bloom version: 0.6.6
previous version for package: null

async_web_server_cpp
* Merge pull request #6 from mitchellwills/develop
  Added some tests
* Added filesystem tests
* Added some more tests (including websocket tests)
* Added some more http tests
* Added an echo test and enabled tests on travis
* Began working on some tests
* Fixed missing boost dep
* Merge pull request #5 from mitchellwills/develop
  Some more improvements
* Added filesystem request handler
  This serves both files from a given root and directory listings (if requested)
* Modified request handler signature so that it can reject requests (causing them to be pushed to the next handler in a handler group)
* Now load a file to be served each time it is requested
* Fix HTTP Server stop to allow it to be safe to call multiple times
* Merge pull request #4 from mitchellwills/develop
  A few small improvements
* Allow for a server to be created even if the system has no non-local IP
  See http://stackoverflow.com/questions/5971242/how-does-boost-asios-hostname-resolution-work-on-linux-is-it-possible-to-use-n
* Changed write resource to be a const shared ptr
* Contributors: Mitchell Wills, Russell Toris

Holding for melodic sync


HTML output is in a .js file

[X] I am interested in helping provide a fix!

Scope

[X] This only impacts specific generators/outputs (please list them here):

Describe the bug
The html output target lands in a file with .js extension.
To Reproduce
yarn
yarn ci:build

Then look at packages/e2e-app/output/html/src/components/my-component.js
Expected behavior
HTML output in a .html file, or perhaps consider some other extension indicating it is meant to be included in other HTML? (.inc?), But not .js.

@PatrickJS Do you have any thoughts on this from your work on the HTML generator?
It might be as simple as adding the right extension here for mitosis build
https://github.com/BuilderIO/mitosis/blob/ab0708fd2c07a06a7a52ab7490cd8e716759a48a/packages/cli/src/build/helpers/extensions.ts#L3

Ive been focusing on webcomponent only. Html output needs some work. It's a little bit confusing what html output should be. Become It's not webcomponent it does make sense to keep them .html files but they're not exactly components

Sure, my bug report was only at a initial, highly surface level. That the contents of the file should match the extension.
For the real question of what the output should be, does anyone know what the output looks like for existing, already popular component sets packaged as web components? I'm just catching up on email on the weekend as I write this, otherwise I would go research right now...

@samijaber @steve8708 what is the expected html output? Is it the same thing as webcomponent just with no custom elements?

yeah exactly, the initial thinking was this is useful for very simple things. so can support basic HTML output, event listeners, data bindings. so is useful for codegen for things like Builder. not necessarily sure how it could or ever would child components tho, that is the main known constraint right now


Cleanup of links in HttpException derived classes

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
https://github.com/yiisoft/yii2/issues/14469

Merged. Thanks!


UEFI serving, per #46

Added the relevant arch specific UEFI files.
Option 93 is already included in tlvParse, so we just check it and serve the relevant files.
If -i is specified, we use that rather than arch specific files.
This needs testing, I don't have all UEFI flavors.
(#46)

Looks good to me if you wanna merge to dev for testing :+1:


gorm delete all records if ID is 0

When the ID of the structure is 0 Gorm delete ll the records of the table
What version of Go are you using (go version)?
go 1.9
Which database and its version are you using?
mysql
Please provide a complete runnable program to reproduce your issue. IMPORTANT
Need to runnable with GORM's docker compose config or please provides your config.
package main

import (
	"github.com/jinzhu/gorm"
	_ "github.com/jinzhu/gorm/dialects/mssql"
	_ "github.com/jinzhu/gorm/dialects/mysql"
	_ "github.com/jinzhu/gorm/dialects/postgres"
	_ "github.com/jinzhu/gorm/dialects/sqlite"
)

var db *gorm.DB

func init() {
	var err error
	db, err = gorm.Open("sqlite3", "test.db")
	// db, err = gorm.Open("postgres", "user=gorm password=gorm DB.name=gorm port=9920 sslmode=disable")
	// db, err = gorm.Open("mysql", "gorm:gorm@tcp(localhost:9910)/gorm?charset=utf8&parseTime=True")
	// db, err = gorm.Open("mssql", "sqlserver://gorm:LoremIpsum86@localhost:9930?database=gorm")
	if err != nil {
		panic(err)
	}
	db.LogMode(true)
}
struct Truck type{
Model
}

func main() {
        db.AutoMigrate(&Truck{})
	db.LogMode(true)
	truck := data.Truck{}
	db.Delete(truck)
	truck.ID = 1
	db.Delete(truck)
}

Here are gorm queries logged
UPDATE "trucks" SET "deleted_at"='2018-07-04 18:28:38'  WHERE "trucks"."deleted_at" IS NULL
UPDATE "trucks" SET "deleted_at"='2018-07-04 18:28:38'  WHERE "trucks"."deleted_at" IS NULL AND "trucks"."id" = '1'
The first query should be
UPDATE "trucks" SET "deleted_at"='2018-07-04 18:28:38'  WHERE "trucks"."deleted_at" IS NULL AND "trucks"."id" = '0'

Storing a 0 in your surrogate key can lead to confusion, since 0 can be read as NULL in some circumstances. In database design this is not a recommended practice and I suspect that's why this package is mishandling this use case. Is your sequential surrogate key (in the DB itself) configured to start at 0 or are you just inserting 0 as the value for the first row? (You see, again, "first" usually means "1 place", not "0 place".)

So the query should be
Where ID=0
or
Where ID is null
or gorm should throw an error ID can't be 0

The explication is here ID=0 is considered as blank
https://github.com/jinzhu/gorm/blob/0fd395ab37aefd2d50854f0556a4311dccc6f45a/scope.go#L721

Yea, I really hope that @jinzhu will address this, since it needs to be either supported or needs to fail loudly.

So closing in favour of #2025 (another dupe). Even I been stung by this!


Add the ability to add a Private IP to a Linode

@alioso The position of the AddNewLink buttons needs some styling.

Coverage decreased (-0.03%) to 28.873% when pulling 9fced29566d1a2e03701f82c9c386e9627e7c58c on asauber:M3-628-add-private-ip into<PHONE_NUMBER>94ab52277708654369c9f593d98dfb on linode:develop.

Styled and ready for review

@rjstires added the disabled state with tooltip


Add example for how to listen for network updates

While this is technically a system_registry thing, It feels really helpful to anyone using the library. Here's an example:
https://github.com/fhunleth/nerves_init_gadget/blob/v0.1.0/lib/nerves_init_zero/network_manager.ex#L16
https://github.com/fhunleth/nerves_init_gadget/blob/v0.1.0/lib/nerves_init_zero/network_manager.ex#L20-L29

here are some docs


[Issue]: build is with libc++ fails with fatal error: 'experimental/filesystem' file not found

Problem Description
Hi,
The following code fails when libc++ is used as a replacement of libstdc++:
https://github.com/ROCm/hipSPARSE/blob/54071d80f509fb62d05d371cfaefa05079451e7f/clients/common/utility.cpp#L37-L40
The problem is on hipSPARSE side. Libc++ defines __cpp_lib_filesystem only if -std=c++17 or later compiler flag is specified following https://en.cppreference.com/w/cpp/feature_test and does not implement experimental/filesystem (it implements normal filesystem). Please, consider setting set(CMAKE_CXX_STANDARD 17) in https://github.com/ROCm/hipSPARSE/blob/b1e2366a99e75e4ee2eee855732fdb2d5d934a39/CMakeLists.txt#L70
and
https://github.com/ROCm/hipSPARSE/blob/b1e2366a99e75e4ee2eee855732fdb2d5d934a39/clients/CMakeLists.txt#L59
Operating System
Gentoo
CPU

GPU

ROCm Version
ROCm 6.3.0
ROCm Component
No response
Steps to Reproduce
No response
(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
No response
Additional Information
No response

Hi @AngryLoki. Internal ticket has been created to investigate your issue. Thanks!

Just a small update: setting CMAKE_CXX_STANDARD 17 is not enough, as build fails with libstdc++ too:
https://github.com/ROCm/hipSPARSE/blob/b1e2366a99e75e4ee2eee855732fdb2d5d934a39/clients/common/utility.cpp#L37-L46

to use __cpp_lib_filesystem you need to #include <version> (or hope that it is included transitively, which is not for libstdc++)
when it falls back to experimental::filesystem (due to incorrect use of __cpp_lib_filesystem), adding filesystem to std namespace conflicts with namespace of  - see https://godbolt.org/z/qqEodn4xP for minimal reproducer.

Overall, additionally to CMAKE_CXX_STANDARD 17 fix looks like this:
--- a/clients/common/utility.cpp
+++ b/clients/common/utility.cpp
@@ -34,16 +34,22 @@
 #define strSUITEcmp(A, B) _stricmp(A, B)
 #endif

+#ifdef __has_include
+#if __has_include(<version>)
+#include <version>
+#endif
+#endif
+
 #ifdef __cpp_lib_filesystem
 #include <filesystem>
+
+namespace fs = std::filesystem;
 #else
 #include <experimental/filesystem>

-namespace std
-{
-    namespace filesystem = experimental::filesystem;
-}
+namespace fs = std::experimental::filesystem;
 #endif
+
 #if 0
 #ifdef WIN32
 #include <windows.h>
@@ -91,7 +97,7 @@ std::string hipsparse_exepath()
         result.resize(result.size() * 2);
     }

-    std::filesystem::path exepath(result.begin(), result.end());
+    fs::path exepath(result.begin(), result.end());
     exepath = exepath.remove_filename();
     exepath += exepath.empty() ? "" : "/";
     return exepath.string();

@AngryLoki, Thanks for reaching out! Unfortunately, we do not currently have plans to bump to C++ 17 standard, and likely will not unless the decision is made for all math libraries. However, we really appreciate your workaround for supporting libc++. Thanks for sharing this!
Since there is not much we can do at the moment, I will be closing this issue for now, but please feel free to ask more questions below. Thanks!

@tcgu-amd, most of the math libraries are using C++17. While libraries shouldn't upgrade their standards version needlessly, it would be appropriate for hipSPARSE given that they are using C++17 features like std::filesystem.
Either way, the issue should be reopened as this code is not correct even for C++14. Until C++20, __cpp_lib_filesystem was defined within <filesystem>, so it cannot be used for checking if <filesystem> is available. It's also undefined behaviour to add an alias to the std namespace.
I would recommend taking a look at what rocSOLVER does for this:
#if __has_include(<filesystem>)
#include <filesystem>
namespace fs = std::filesystem;
#else
#include <experimental/filesystem>
namespace fs = std::experimental::filesystem;
#endif


Create new Risk Analysis Document for ID2

Please edit the repo wiki with a Risk Analysis Document for ID2

Uploaded updated document


[BEAM-9722] added SnowflakeIO with Read operation

This PR is adding SnowflakeIO with Read operation as part of BEAM-9722
Snowflake is an analytic data warehouse provided as Software-as-a-Service (SaaS). It uses a new SQL database engine with a unique architecture designed for the cloud. To read more details please check here and here.
The SnowflakeIO.Read uses Snowflake's JDBC driver to run COPY INTO  statement to move data on GCS as CSV files that are then read via FileIO.
The SnowflakeIO allows to use three authentication methods against Snowflake:

username and password
key-pair
pre-obtained OAuth token

This PR is first of series, once merged, subsequent PRs will come - with Write, integration tests etc. We're also working on cross-language to support Python SDK.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @aromanenko-dev
on dev-list you were interested in reviewing PRs related to SnowflakeIO - could you please take a look or point other reviewer? thanks!

@DariuszAniszewski Thank you for contribution! I'm a bit busy for now but I'll try to take a look on this asap.

@aromanenko-dev I don't want to push you but do you have any ETA on the review? I'm OK with waiting but it would be nice to roughly know how long it may take ;)
I also have a generic question - as mentioned in description of this very PR, it's first from a series. We have more pieces of SnowflakeIO done, but we wanted to make as small and atomic PRs as possible to ease the review process and merge them one by one. But maybe this approach is misfired and it's better to put all pieces of the IO (in atomic commits of course) into this one PR?
WDYT?

@iemejia Would you have some time to take a look as well?

Thanks @aromanenko-dev and @lukecwik for review.
I rebased onto (current) master and applied simplest changes already - I'll be back in a few days with rest of them.

I'm dealing with some private issues this week and I'll be unavailable.
@kkucharc and @purbanow will continue working on this PR

@aromanenko-dev @lukecwik thanks again for the review. We've applied the changes and all your comments/questions are addressed: either changed or answered.
Can you please re-review? :)

retest this please

retest this please

retest this please

@chamikaramj Thanks for review. We've applied some of them already and answered/commented to rest of them - can you please have another look on this PR?

retest this please

retest this please

@chamikaramj All done, PTAL ;)

LGTM. Thanks.

Retest tthis please

Retest this please

I can "squash and merge" after tests pass.
Feel free to squash/fixup commits if you need more than one commit.

Retest this please

Thanks!
I'm OK with squash-and-merge - it was intended to go as single commit

Retest this please

Retest this please

Having trouble re-triggering tests.
Can someone else try ?

Retest this please

Run Python PreCommit

Run Python PreCommit

Run Python2_PVR_Flink PreCommit

Run Python2_PVR_Flink PreCommit

Run Python2_PVR_Flink PreCommit

Run Python2_PVR_Flink PreCommit

Just a small comment about the force-push from above - it was mistakenly done, then reverted. HEAD of this branch is still on 3ba192a and comment is a leftover.

I retested failing test - probably the previous one was timeouting.

Seems like this was not included in Beam 2.22.0 cut. So I'll remove it from CHANGES.md entry for Beam 2.22.0.


New version for latest version

Any way we could get a new version for jupyterlab 0.18? Hopefully there shouldn't be much in the way of actual changes necessary, but as it is it's not possible to, say, run this and also jupyterlab/git or jupyterlab/latex thanks to mutually exclusive version requirements.
Thanks!

Hmm that's weird, the requirements is quite lax already, https://github.com/ryantam626/jupyterlab_sublime/blob/58a8e5190bdb6e6c73d18b305f1f6bd9c8d66a15/package.json#L33-L34
Can you post any errors that you are seeing please?

Hm, I seem to have somehow gotten an older version. Updating solved the problem. Thanks!

Good to hear! :+1: Closing this issue for now :grinning:


Mangler

@tylerp96
Hi glad to hear back from you!
The head branch was super outdated so I just deleted it. Anyway, I checked out your mangler code and it's looking really good, except for some small bugs in your Reverse() and UniqueLeet() functions which don't take 'self' as arguments. Other than that, I'm excited to add it into hacklib!
If you don't mind, fork the current master branch and add your Mangler class and redo the pull request. We can definitely make it compatible with the topPasswords() function for more variety in password generation.

Also, having password generation with the mangler in the UI may be a good idea if someone just wants to generate passwords.

Opps! Must have missed that! Ill fix that and fork the master, and add it! Very excited for this!

Finally he gets something done :P JK...slow progress on our end...might be incorporating hacklib in our new recon tool LHF will make some ideas we have a tad bit easier.
@leonli96 we are in a super busy part of the year so we are slow af atm.
@tylerp96 good work man!

@blindfuzzy I took a look at your LHF and it looks great! As of now it seems like hacklib might just be redundant since you already have nmap going. But hopefully one day hacklib will carve out its own niche in the LHF module set!
On a side note, I had a lot of fun with hacklib the other day at a coffee shop. Found an HP Laserjet printer in their network with port 9100 open and used hacklib to print out some mildly offensive text ;)

@leonli96 ASCii penis's? :D 👍
Yea but we can use the exploit class in there and add more exploits to hacklib for better use in LHF :) Ideas are brewing :D

@blindfuzzy Haha may as well make an ascii penis generator class since it's so crucial.


Remove dependency of global cidr.

Global cidr now only used in ipam, we can get from hub peer, so do't set it again.

fixed: https://github.com/nauti-io/nauti/pull/60


Updated pycharm to 5.0.2

Thank you for the contribution. It was merged directly as 3934d05dc77299da3d171e9434241fb7e482fd70 to keep commit history cleaner. Your contribution is still credited to you.


Possible to set  writeroom-bottom-divider-width to "0" when these is only 1 window?

I am trying to minimize all the extra bits, wondering if it's possible to set
 writeroom-bottom-divider-width to 0 when there is only one window. Thanks :)
This package made me so happy !

You cannot set the width to 0 (Emacs requires a positive integer for the window divider) but you can disable the window bottom divider altogether by customising the option writeroom-global-effects. If you use the Customize interface, you can simply uncheck it in "Writeroom Global Effects".

one more question :)
I have global-writeroom-mode on, it's helping me a lot when working on a large monitor.
Right now if you have a split windows, say 2 side by side. If then open a "new" file it will kill the other window and make it only one. Is it possible to disable that? Thanks

Yes, you can set the option writeroom-maximize-window to nil (or unset it through Customize).


Storage Picker for create should prevent Blob only accounts from being chosen

Storage Picker for create should prevent Blob only accounts from being chosen

@christopheranderson  we tried this but there is no way form ARM to figure out if a storage account is hot/cold or general purpose. We need a flag or something we can filter on.

Waiting on an API for this...

We have now found the API and @Tuesdaysgreen has fixed the bug. Hurray!!


Repositioning tab also scrolls the tab bar... (1.8.7/330)

...regardless of whether it's near the egde of the screen or not
https://youtu.be/3QG52RFpN94

Seems to be working fine for me. Can you please tell your android version and device manufacturer.


Set geo_field to a geo_field from a linked model

Given the following models, is there a way to serialize MainModel as Geojson by specifying the geo_field attribute from the linked GeoModel ?
class GeoModel(models.Model):
    point = models.PointField()
    objects = models.GeoManager()

class MainModel(models.Model):
    geo_model = models.ForeignKey(GeoModel)

Willing to help contributing if some insight about implementation could be shared. Thanks

Hi @achraibi,
I think you could try to create a property on MainModel.
Something like:
class MainModel(models.Model):
    geo_model = models.ForeignKey(GeoModel)

    @property
    def point(self):
        return self.geo_model.point

Try this and let us know if it works.

Hi @nemesisdesign , well this returns empty geometry

I see, the serializer most probably needs a real field to work.
You might need to patch drf-gis to achieve what you want.
If you find a solution that is simple enough we can think about merging it.

Hi @nemesisdesign ,current restframework API combined with django-rest-framework-gis actually allows that use case by using a @property and explicitly adding the correspondant GeometryField to the serializer:
#models.py
from django.contrib.gis.db import models

class GeoModel(models.Model):
    point = models.PointField()
    objects = models.GeoManager()

class MainModel(models.Model):
    geo_model = models.ForeignKey(GeoModel)

    @property
    def point(self):
        return self.geo_model.point

#serializers.py
from rest_framework_gis.fields import GeometryField
from rest_framework_gis.serializers import GeoFeatureModelSerializer

class MainModelSerializer(GeoFeatureModelSerializer):
    point = GeometryField()

    class Meta:
        model = Lot
        geo_field = 'point'

The issue is thus not an issue :)

@achraibi that was exactly what I meant in my first answer. Very glad that you figured it out!

Hi, sorry to keep this going, but this doesn't seem to be working for me, or is it maybe because I am using ManyToManyField. Here's my code.
#models.py
class Location(models.Model):
    city = models.CharField(max_length=200)
    point = models.PointField(srid=4326)
    objects = models.GeoManager()

class Article(models.Model):
    locations = models.ManyToManyField(Location)
    article_title = models.CharField(max_length=200)

    @property
    def point(self):
    return self.locations.point

#serializers.py
class ArticleSerializer(GeoFeatureModelSerializer):
point = GeometryField()

class Meta:
    model = Article
    geo_field = "point"
    id_field = False
    fields = ('pub_date', 'point',)

And the error:
Got AttributeError when attempting to get a value for field `point` on serializer `ArticleSerializer`.
The serializer field might be named incorrectly and not match any attribute or key on the `Article`     instance.
Original exception text was: 'ManyRelatedManager' object has no attribute 'point'.

Thanks in advance for any help!

Hi @sammy88888888, the error is in the point property. Article has many Locations and each of the locations has a point. If you want to serialize an Article with one point, the property should pick the relevant Location object for the current article, and return its geometry field. There might be something unclear in your design, at least this is what the property tells at first sight.

Possibly, although I'm struggling to see where it is. When I write my serializer like this:
class ArticleSerializer(GeoFeatureModelSerializer):
    locations = serializers.StringRelatedField(many=True)

    class Meta:
        model = Article
        geo_field = "locations"
        id_field = False
        fields = ('pub_date', 'locations',)

I get:
{
    "type":"FeatureCollection",
    "features":[
        {
            "type":"Feature",
            "geometry":[
                "SRID=4326;POINT (-2.2003379561186454 53.4831642374137104)"
            ],
            "properties":{
                "pub_date":"2015-04-06T20:38:59Z"
            }
        }
    ]
}

I've been grappling with this for ages now. Close but still not quite there...


Add functionality to specify schema

Instead of relying on pyarrow.dataset, we would like to be able to specify a schema in the repo file. This will help solve type problems in large files, because pyarrow.dataset only inspects the first 1MB of data to infer types of columns.

We might need to go a little deeper than that for fields with options, e.g. unit/timezone for timestamps and precision/scale for decimal. Maybe just optional kwargs that can be passed through like

{
"id": {"type_name": "string"},
"click_ts": {"type_name": "timestamp", "type_args": {"unit": "ms"}},
"some_value": {"type_name": "decimal128", "type_args": {"precision": 7, "index": 3}},
...
}
Or flat or otherwise—I don't really care about arrangement, just that it's flexible enough when we need it

This code has the basic functionality and is able to convert the fanniemae dataset. It can't handle datatypes with parameters yet.

Out of curiosity, are there files/datasets where 1MB has not been enough to resolve its schema? I ask because this can be an improvement that Arrow will benefit as well.

Out of curiosity, are there files/datasets where 1MB has not been enough to resolve its schema? I ask because this can be an improvement that Arrow will benefit as well.

They definitely exist, and there's no magic number here; at some point you just have to specify a schema. An example is an export from a database table sorted by timestamp where a nullable field was added at some point—values may be entirely null for millions+ of observations even though there's useful data at the end of the dataset.
Especially for interactive work, being able to specify a partial schema just for columns you know are screwy can be handy; readr::cols() takes this approach with a default of inferring types for unspecified columns. Obviously specifying a complete schema is better, but forcing users to do so can lead to other antipatterns. What we have is good, just maybe a little idealistic.

@alistaire47 Thank you for the explanation. A possible solution for file format standardization is to include metadata with a value per column identifying where the first non-null value appears, this way tools can fetch the value directly for schema resolution.

A possible solution for file format standardization is to include metadata with a value per column identifying where the first non-null value appears, this way tools can fetch the value directly for schema resolution.

@edponce Ooh that would be great, and handle a lot of problem cases! The remaining issues I've run into have all been in regards to schema params of fields that are difficult to infer from data, e.g. unit/timezone for timestamps. I think at least timestamp unit handling may be improved (i.e. they roundtrip file <-> memory correctly with defaults) in more recent parquet versions, though?

@edponce thanks for contributing to the discussion! Suppose you go through the trouble of storing the row number where the first value is encountered, wouldn't it be just as much work to simply store the datatype of the column?

(Related JIRA BTW: https://issues.apache.org/jira/browse/ARROW-8221)

@joosthooz yeah, you are right. There are many variations data details can be provided to help with schema resolution. In an ideal world, most data formats in file/memory would have metadata (min, max, null count, nrows, ncols, types, etc) and consistent across formats.
Another issue which seems more related to this PR's work, revolves on how to handle data updates? Viewing data as a data structure that can be modified directly creates many issues. If datasets would only be allowed to be modified via some sort of API, then metadata could be updated accordingly during data updates.
BTW, this is just me thinking out loud. Thanks for the discussion!

Is it possible to have this PR be based on main instead of the validation branch? I know they might be inter-related in a way that's hard to tease them apart, but it would make reviewing much easier if I could see what the changes are here for schemas and not the validation bits

@jonkeane I changed the target branch to the validation branch, so now you only see the additional changes specific to this task. That should help. Once we merge #34 we can change the target branch back to main.

It seems I need to rebase this, I thought retargeting to the main branch after merging #34 would fix it but it didn't.
Thanks for all the comments, especially for all the ideas for tests :+1:

Ok things should be up to date again, I'll get started on the recommendations


ImpliesAtom

When working on the constraint validation at https://github.com/medplum/medplum/issues/2064, there are several key features in FHIRPath logic that hasn't been implemented. One of them includes Implies which is needed for several rule constraints
http://hl7.org/fhirpath/N1/#implies

coverage: 94.305% (+0.009%) from 94.296% when pulling e2c0c69b9c230003ec21bf2682237da838f78027 on james-add-implies into e8d2a24d5945ddbe973923ed4de16bd4209f766f on main.

(duplication warning is ok with me -- it would be a gross refactor for minimal gain)


Mark isLTRLanguage with @objc

isLTRLanguage property was not accessible from Objective-C

Brilliant @behdad-keynejad! Can you please add an entry in CHANGELOG.md under the master section?

@k0nserv I updated CHANGELOG.md according to previous entries.

Released in 3.5.0 just now. Sorry about the delay


asynchronous requests

need for a PUT method to send a request, get some id back, and poll if its done (or webhook in backend)

Complete


Add property based testing (by stealing some of what is in Quasar)

The build is failing because type inference was apparently not as "good" in Scala 2.10. This one is probably easy enough to fix by adding some type annotations, but just out curiosity, how important is it that we support Scala 2.10?


Model Scale Stretching Issue

Description
When scaling my model upwards, at certain scale values, suddenly this long texture / model stretch happens that overlaps my model. For example it'll work just fine on a scale value of 20, but will break on a scale value of 28. Screenshots and obj and texture attached.
Screenshots

Reproduction
Follow normal setup instructions.
Environment:

Microsoft Windows 11 Version 23H2 (OS Version 22631.3007)
Vanilla 1.21.3 Java Edition
NVIDIA GeForce RTX 3050 4GB Laptop GPU / 13th Gen Intel Core i7-1355U

Model File and Texture
Files.zip

Notes:
This also happens when I scale the model in blender as opposed to OBJMC.
After my testing it appears any scale value for this model larger than 24 will cause this stretching.

Sorry for the late reply, The model is attached in the original issue :D

objmc max size is 256^3 blocks. if a vertex is more than 128 units away from center it will overflow.
for very large block models, its a good idea to split it up into subchunk (16^3) sized pieces, since minecraft chunk culling also happens by the subchunk