Back out "Migrate flag enablePropIteratorSetter to new system"

Summary:
Original commit changeset: d6fd1e819abb
Original Phabricator Diff: D52810065
Changelog: [Internal]
Reviewed By: lunaleaps, mdvacca
Differential Revision: D53736651

This was merged.


Change stats window when there is no data

Fix #169

Codecov Report

Merging #189 (58c98c8) into master (2f73447) will decrease coverage by 0.45%.
The diff coverage is 5.55%.

@@             Coverage Diff              @@
##             master     #189      +/-   ##
============================================
- Coverage     66.68%   66.23%   -0.46%
+ Complexity      528      527       -1
============================================
  Files            89       89
  Lines          1912     1919       +7
  Branches        209      211       +2
============================================
- Hits           1275     1271       -4
- Misses          569      580      +11
  Partials         68       68

Impacted Files
Coverage Δ

...ava/seedu/anilist/logic/commands/StatsCommand.java
0.00% <ø> (ø)

...c/main/java/seedu/anilist/model/anime/Episode.java
77.77% <ø> (-2.23%)
:arrow_down:

src/main/java/seedu/anilist/model/stats/Stats.java
55.17% <ø> (+0.33%)
:arrow_up:

src/main/java/seedu/anilist/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/anilist/ui/StatsDisplay.java
0.00% <0.00%> (ø)

src/main/java/seedu/anilist/model/AnimeList.java
80.95% <100.00%> (-0.87%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f73447...58c98c8. Read the comment docs.


Backend api

Introduces a backend api based on FastAPI.
The API has the following features:

Hosts the frontend at the root path
Has an endpoint for retrieving a new set of tiles

Circular tiles are not supported yet.

Whoops.


check ssiexprparserAlloc() result with force assert

In case allocation fails, pParser will be Null & it is derefrenced below.

Applied in 5c5f67a5c7bbeca6a4b8eb92e43752499efea53a - thanks!


Talk about whether to (partially) unify the namespace

In a recent Discord conversation, the point came up that we look fragmented in part because our projects are under many different namespaces.
This is a placeholder ticket to hold the conversation: do we care, and if so, how much?  Unifying projects under, eg, a common typelevel namespace would make it a little more obvious that these projects are "official" -- that's nice, but is it worth the disruption?  Also, given that many of the projects live under their own "brand" (eg, Davenverse), we aren't likely to want to try to shoehorn everything into a common namespace; is it worth doing so for some of them?
My current gut instinct is to not do this -- I'd prefer to just publicly own that TL is a community and ecosystem of cooperative systems that work together, and not try to claim that there is some sort of master plan or grand ruling body here.  But we should talk about it, and consciously decide one way or another.

I like the two levels we have now.  I trust that someone is going to step up and maintain a project under the Typelevel org.  I also expect that an affiliate project under a personal brand is probably going to be of decent quality and interoperability, but also carries a much greater risk of abandonment.  My inner open source hippie likes the affiliates and my inner staff engineer strongly prefers the Typelevel brand.  I think there's room for both, so long as we're honest about what both are.
Projects like http4s sit in a weird place: they've proven durable over the years, independent of one person, but don't carry the full Typelevel brand.  I wouldn't be strictly opposed to folding http4s into the organization, but we're already struggling with CI quotas, so there's a strong technical reason not to.
The easiest thing to sell to the CTO would be if http4s and skunk were not only in the org, but called cats-http and cats-postgresql and had those Maven coordinates and those top-level packages.  But that would be a jarring change.  I'm not in favor.

I'm in favor of status quo plus better marketing for all the reasons Ross stated. I'm also not totally convinced it's a hard sell at the C level. If anything, it demonstrates a bigger tent, which correlates well with better resiliency long term.

I think taking a stab at better explanations and marketing to see where it gets us is a sound idea.  I've personally not had any issues with selling Typelevel as an ecosystem under "works with" circumstances for each library.


Tutorial encourages exposing keys that are supposedly sensitive data

The tutorial Search nearby points of interest using Azure Maps encourages the reader to make the Azure Maps authentication key public, but this is discouraged by the reference documentation. It's not clear whether keys are meant to be exposed in a client-side application or not.
The tutorial says:

Add the following JavaScript code to the GetMap function of the HTML file. Replace the string <Your Azure Maps Subscription Key> with the subscription key that you copied from your Azure Maps account.

The linked tutorial page for retrieving subscription keys says:

Open your Maps account in the portal.
In the settings section, select Authentication.
Copy the Primary Key and save it locally to use later in this tutorial.

But, the Authentication with Azure Maps page explicitly says:

Primary and Secondary keys should be treated as sensitive data. The shared key is used to authenticate all Azure Maps REST API. Users who use a shared key should abstract the API key away, either through environment variables or secure secret storage, where it can be managed centrally.

So, the tutorial is guiding new developers to make their primary key public, something discouraged by the reference documentation.
Is the tutorial correct (keys are okay to expose publicly) or is the reference documentation correct?
If keys are sensitive, then the tutorial should either be changed or have a clear, unmistakable warning about not exposing the keys in a real application.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fbc23125-006f-d643-9548-ea6d7bc2de60
Version Independent ID: 77704958-c3b6-d6aa-4f2b-d3794ae6df9c
Content: Tutorial: Search for nearby locations on a map - Microsoft Azure Maps
Content Source: articles/azure-maps/tutorial-search-location.md
Service: azure-maps
GitHub Login: @sinnypan
Microsoft Alias: sipa

@jennings
Thanks for your feedback! We will investigate and update as appropriate.


Backport 561, BZ 1756328:

Backport of: #561
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1756328
Depends on: #565

Pull Request Test Coverage Report for Build 2403

6 of 19 (31.58%)  changed or added relevant lines in 4 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 82.533%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/Wizard/CreateVmWizard/providers/VMwareImportProvider/VMWareImportProvider.js
0
1
0.0%

src/k8s/requests/v2v/startV2VvmwareController.js
0
1
0.0%

src/k8s/requests/v2v/importVmware.js
5
16
31.25%

Files with Coverage Reduction
New Missed Lines
%

src/components/Wizard/CreateVmWizard/stateUpdate/providers/prefillVmStateUpdate.js
1
8.57%

src/k8s/requests/v2v/importVmware.js
2
10.71%

Totals

Change from base Build 2399:
-0.2%

Covered Lines:
4206

Relevant Lines:
4873

💛  - Coveralls


RuntimeError：storage has wrong size when load model

@tensorboy hi, i have finish the train with your code ,but when i test the model i get RuntimeError：storage has wrong size:expected 0 got 589824, do u know the reason

@tensorboy ,it seems the problem of distributetrain,how do u test model_last.pth,i test this and get the above error

@tensorboy 请问一下，我跑你的model可以跑通，但是在测试自己训练的model_last.pth的时候会出现上面的错误，请问你有什么设置嘛


Image burn

If I just add the texture attached below to a box in the default test scene provided in the master branch, the image starts burning after a few seconds and the burn spreads through all the materials. This happens every time. I am running nvidia RTX with a stable driver version 335 on Ubuntu 18.
Here is the video displaying the issue :
https://www.youtube.com/watch?v=209AtbejLHA&feature=youtu.be
Here is my main.js file :
main.zip
Here is the image to be put in the test folder :

Thanks for all your support guys!

Hi @ManishJu , thanks for describing the issue. I've run into the same bug before but it only happened rarely and inconsistently. Thankfully you figured out how to consistently reproduce it.
I loaded the scene on my computer, but the bug isn't appearing. It is probably hardware and scene dependent. But fortunately we might have a solution. I think this happens because of a division by zero in the reproject shader.
https://github.com/hoverinc/ray-tracing-renderer/blob/master/src/renderer/glsl/reproject.frag
If you replace both instances of sum > 0.0 with sum > 0.0001 (or some other small number), does that fix the issue?

No it does not solve the issue. I changed the 2 instances as you mentioned (even in different combinations) in that file and it did not work. The burn still starts after zooming in and out.

I think I have found a way to reproduce it more elegantly .
In the test scene, try to get inside and out of  any of the geometries (spheres or cuboids your choice).  No need of new texture or changes that I posted.  Make sure only to zoom out. If you move the orbital camera a little along the horizontal axis the burn will stop . Is this because there is no light inside the geometries and the intersection test goes wrong when we come out of those geometries  ?


Crop Area incorrectly sized for objectFit='cover'

Hey, first of all thanks for making this! You guys really saved me a lot of time.
My issue comes up if you go to the Basic example with hooks, then perform the following steps:

Change the image prop inside the Cropper component to "https://placehold.co/400x20" (Line 16) - this isn't required, but it makes the bug a lot more visible.
Add objectFit='cover' somewhere in the props of the Cropper component
Refresh the Codesandbox previewer (NOT your own browser page, just the thing on the right of the Codesandbox editor)

This is the result when I do this:

The problem seems to be that the Crop area is incorrectly sized and unable to cover the entire image, even on least (x1) zoom. I'm encountering this error in my own project right now, but it just happens when the component that has a Cropper component is rendered visible.
However, I have found that updating Cropper by doing something like resizing the page a little bit (Ctrl + Scroll, etc.) seems to fix it, although obviously it would be best if it worked on load.
Thanks for reading and thanks again for maintaining this project!

Edit - I've been experimenting a little bit in my own project, and I think it may just be a visual bug - generating the cropped image using croppedAreaPixels and that stuff seems to produce the full-size, expected result.

Thanks for reporting this issue. I think I understand why, you can see the fix in #483.
I'm waiting for the codesandbox package to be published to ensure it does fix the issue.

Here's the fixed sandbox: https://codesandbox.io/s/react-easy-crop-xwncyw?file=/src/index.js


Location.get_rise_set_transit

pvlib python pull request guidelines
Thank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.
You may submit a pull request with your code at any stage of completion.
The following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:

[x] Closes #114
[x] I am familiar with the contributing guidelines.
[x] Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
[x] Updates entries to docs/sphinx/source/api.rst for API changes.
[x] Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
[x] Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
[x] New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
[x] Pull request is nearly complete and ready for detailed review.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):
Location method wrapping sun_rise_set_transit_xxx functions.

Help me understand this test failure: test_location is importing a Location object golden from test_solarposition but does not bring in the new Location method get_sun_rise_set_transit.  Do I need to redeclare golden in test_location?

Ready for review

Test failure is on py2.7-min, because functions being tested require pyephem.

pvlib.SPA error when testing in py36

pvlib.SPA error when testing in py36

Strange. The base python is 3.6 but tests run in a conda env with 3.7. I suspect it's related to conda packaging issues that will resolve themselves. That configuration passed on master 8 days ago, but failed on master when I reran it a few minutes ago. So that confirms this PR is not doing something unexpected.

@cwhanse the test failure is unrelated. You can merge this if you're ready.


Migrate Azure Blob Storage test to Go.

Signed-off-by: Vighnesh Shenoy<EMAIL_ADDRESS>
Provide a description of what has been changed
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Tests have been added

Fixes #3229

Relates to #2737

/run-e2e azure_blob


Make defer/drain logic transparent

Is your feature request related to a problem? Please describe.
Currently if a page view triggers some events before the code that listens to the event is loaded, clients need to declare the event using the defer mechanism, which captures the events and queues them until the logic to consume these events is loaded.
When the logic to consume the event is loaded it has to be registered using the drain function.  Which will register the event consumer, and invoke it with the events that were queued.
The defer/drain mechanism works great, but has a problem: we need to declare in advance in the sampleRUM code which type of events need to be deferred. RUM extensions or customer projects wanting to declare their own events, would need to modify sampleRUM to add their custom events in the defer list.
Describe the solution you'd like
Using a Proxy object in RUM we could add to the defer list all events that are triggered before it's consuming function is ready.
And when the consumer logic is ready, we could automatically invoke it for the queued events, without having to call explicitly the drain function.

on-hold for the moment. May be implemented in a different manner


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.11.35 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


STPopup.framework Use of

Need adapter IOS7,Cannot use ‘Carthage’，Can send me a alone ‘STPopup.framework’, My mailbox is<EMAIL_ADDRESS>

@AlanZhaos If you want to use framework with iOS 7, you need to clone the project and do it yourself. Can refer to https://www.raywenderlich.com/65964/create-a-framework-for-ios


Create project structure

This repository is still empty and needs to be initialized with the initial structure. Templates can be copied from other repos like devon4j-sonar-plugin.
Acceptance-criteria:
The following files are properly present:

[x] .gitignore
[x] pom.xml (needs to be adopted to new GAV, no parent, dependency for archUnit, etc.)
[x] .github/workflows/build.yml
[x] .github/workflows/build-pr.yml
[x] README.adoc (already present but needs to be extended with CI badge and additional doc)

[16.1]Jörg will do a minimal job. Afterwards the task will be assigned to one team member.

I will close this issue that is IMHO already completed.


Make affiliate links easier to change

Make it more easy for people to change affiliate links without having to change the code, and/or rebuild the solution.

This is fixed with your PR #55


tpl: Extend Jsonify to support optional indent parameter

Fixes #5040

I don't remember what we discussed in #5040 but thinking about it now I think I would prefer to use a dict option, e.g. $foo  |  (dict "indent" "    ")
Esp. if we should get more options in the future.

PTAL

@moorereason  Thank you very much for this addition!! Is there any way you might update the Hugo Docs page as well to include the new options? https://gohugo.io/functions/jsonify/

I would suggest you checkout the Hugo Docs repo and add it yourself.
That would take some load off the Hugo developers, and it's an open
source project to enable / encourage collaboration...
On 2020-04-10 08:48, Zach Bayoff wrote:

@moorereason https://github.com/moorereason Thank you very much for
this addition!! Is there any way you might update the Hugo Docs page
as well to include the new options? https://gohugo.io/functions/jsonify/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gohugoio/hugo/pull/7082#issuecomment-612014381,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE6GOSUS4RQKZXO6Q5GPAU3RL4IR5ANCNFSM4LQ6I5EQ.


Refactoring VR selector

Preview here: https://pr-430.lba2remake.net

Tested on mobile works as expected now.
Also tried VR on mobile and it works as well, touch works but with no controllers for now.


Removed dependency on cloud-diagnostics-common

Removed all dependencies on cloud-diagnostics-common, replacing with equivalent functionality in cloud-common.

Addressed inconsistencies in log levels here: https://github.com/GoogleCloudPlatform/google-cloud-node/pull/1900

Appveyor test failures seem to be unrelated to these changes.


Large regression in android raster times on roll to 7f12e3497428

I suspect the culprit is https://github.com/flutter/engine/pull/42528/files#diff-dff260fd920e7b018971e37036d11916295c2c9614370942f6493f46ec5616d8 , because a change in the raster cache behavior would explain the android only regression.

https://github.com/flutter/engine/compare/f9f72388a4da...7f12e3497428

The benchmark recovered after https://github.com/flutter/engine/pull/42592 rolled into the framework.


PAPP-24382: Initial release

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[ ] Testing of all the changes has been performed (for bug fixes / features)
[ ] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[ ] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[ ] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[ ] Verify all checks are passing.
[ ] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[ ] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[x] New App
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Release Notes (REQUIRED)

Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

@ebhoir-crest remove all the .DS_Store files

There seems to be references to the word "phantom" in almost every file. I think we should probably switch to "soar" instead but probably worth to open the discussion to rest of the team here.

There seems to be references to the word "phantom" in almost every file. I think we should probably switch to "soar" instead but probably worth to open the discussion to rest of the team here.

@ricardo-phantom Agree and Sounds good to me.
@mattsayar-splunk @brian-phantom @pzhou-splunk Can you share your thought on this?

There seems to be references to the word "phantom" in almost every file. I think we should probably switch to "soar" instead but probably worth to open the discussion to rest of the team here.

@ricardo-phantom Agree and Sounds good to me. @mattsayar-splunk @brian-phantom @pzhou-splunk Can you share your thought on this?

I think that's what we should be doing at this point replace Phantom with SOAR.


Create feature branch in private repo for new RP

DevSpaces repository needs to be created in private repo.

branch is created with appropriate permissions


Can't share videos

When i share a video it always tries to share the thumbs_big.jpg and doenst share the video itself.

<IP_ADDRESS>:3000/media/thumbnails_big/b1a169b3f87dfe80d48a6744923e57b71.jpg
It tries to share it like that, but when i change /media/thumbnails_big/ to /media/videos/ and the extension to .mp4 the link itself works fine.

When i share the video, it converts it to a jpg


Pulumi CLI panics on preview when trying to create a new aws.Provider for a new aws.organizations.Account

What happened?
When trying to create a new aws.organizations.Account, and assign a new aws.Provider to that account with an assumed role, the CLI exits with panic: runtime error: invalid memory address or nil pointer dereference.
This prevents creating new organizations accounts and immediately deploying resources into that account.
If the account has been created previously, a provider will be created as expected.
Example
A minimal repro can be found here: https://github.com/tom-fletcher/pulumi-awsprovider-repro
The infrastructure code in this repro is:
import * as pulumi from '@pulumi/pulumi'
import * as aws from '@pulumi/aws'

const account = new aws.organizations.Account(
    'account',
    {
        email<EMAIL_ADDRESS>        closeOnDeletion: true,
    }
);

const provider = new aws.Provider(
    'provider',
    {
        region: 'us-east-1',
        assumeRole: {
            roleArn: pulumi.interpolate`arn:aws:iam::${account.id}:role/OrganizationAccountAccessRole`,
        },
    }
);

// This will not be created because `pulumi preview` panics when trying to create the provider
new aws.s3.Bucket('bucket', {}, { provider })

The CLI panic output on pulumi up is:
  pulumi:pulumi:Stack (awsprovider-repro-repro):
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x130e43b]
    goroutine 53 [running]:
    github.com/hashicorp/terraform-provider-aws/internal/framework/types.durationType.Validate(0x0?, {0x1a1a3240?, 0x0?}, {{0x0, 0x0}, {0x0, 0x0}}, {{0xc00ae873c0, 0x3, 0x4}})
        /home/runner/work/pulumi-aws/pulumi-aws/upstream/internal/framework/types/duration.go:106 +0x7b
    github.com/hashicorp/terraform-plugin-framework/internal/fwschemadata.Data.ValueAtPath({{0xe1937c2, 0xd}, {0xf6f9eb8, 0xc001b63e80}, {{0xf6ec4b8, 0xc0034dfbf0}, {0xc671640, 0xc0034deb70}}}, {0xf6dc250, 0xc0036342a0}, ...)
        /home/runner/go/pkg/mod/github.com/hashicorp/terraform-plugin-framework@v1.4.0/internal/fwschemadata/data_value.go:82 +0x675
    github.com/hashicorp/terraform-plugin-framework/internal/fwserver.AttributeValidate({0xf6dc250, 0xc003467c80}, {0xf6f2d00, 0xc001b799e0}, {{{0xc00ae873c0, 0x3, 0x4}}, {0x1, {0xc00ae87400, 0x3, ...}}, ...}, ...)
        /home/runner/go/pkg/mod/github.com/hashicorp/terraform-plugin-framework@v1.4.0/internal/fwserver/attribute_validation.go:74 +0x275
    github.com/hashicorp/terraform-plugin-framework/internal/fwserver.NestedBlockObjectValidate({0xf6dc250, 0xc003467c80}, {0xf6e4d40, 0xc00ae86c80}, {{{0xc00adb1c20, 0x2, 0x2}}, {0x1, {0xc00adb1c40, 0x2, ...}}, ...}, ...)
        /home/runner/go/pkg/mod/github.com/hashicorp/terraform-plugin-framework@v1.4.0/internal/fwserver/block_validation.go:439 +0x985
    github.com/hashicorp/terraform-plugin-framework/internal/fwserver.BlockValidate({0xf6dc250, 0xc003467c80}, {0xf6eccc8, 0xc001bc07e0}, {{{0xc00ae81ac0, 0x1, 0x1}}, {0x1, {0xc00ae81ae0, 0x1, ...}}, ...}, ...)
        /home/runner/go/pkg/mod/github.com/hashicorp/terraform-plugin-framework@v1.4.0/internal/fwserver/block_validation.go:83 +0xf45
    github.com/hashicorp/terraform-plugin-framework/internal/fwserver.SchemaValidate({0xf6dc250, 0xc003467c80}, {0xf6f9eb8, 0xc001b63e80}, {{{{0xf6ec4b8, 0xc0034dfbf0}, {0xc671640, 0xc0034deb70}}, {0xf6f9eb8, 0xc001b63e80}}}, ...)
        /home/runner/go/pkg/mod/github.com/hashicorp/terraform-plugin-framework@v1.4.0/internal/fwserver/schema_validation.go:66 +0x485
    github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).ValidateProviderConfig(0xc0008fcf20, {0xf6dc250, 0xc003467c80}, 0xc0020085c0, 0xc001bcfa10)
        /home/runner/go/pkg/mod/github.com/hashicorp/terraform-plugin-framework@v1.4.0/internal/fwserver/server_validateproviderconfig.go:87 +0x390
    github.com/hashicorp/terraform-plugin-framework/internal/proto6server.(*Server).ValidateProviderConfig(0xc0008fcf20, {0xf6dc250?, 0xc003404750?}, 0x0?)
        /home/runner/go/pkg/mod/github.com/hashicorp/terraform-plugin-framework@v1.4.0/internal/proto6server/server_validateproviderconfig.go:39 +0x1dc
    github.com/pulumi/pulumi-terraform-bridge/pf/tfbridge.(*provider).validateProviderConfig(0xc0009e4100, {0xf6dc250, 0xc003404750}, {0xc00aaa4c80, 0x43}, 0x0?)
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/pf@v0.16.1/tfbridge/provider_checkconfig.go:111 +0x197
    github.com/pulumi/pulumi-terraform-bridge/pf/tfbridge.(*provider).CheckConfigWithContext(0xc0009e4100, {0xf6dc250?, 0xc0034042a0?}, {0xc00aaa4c80, 0x43}, 0xc9fc2e0?, 0xc003404540, 0x0?)
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/pf@v0.16.1/tfbridge/provider_checkconfig.go:86 +0x413
    github.com/pulumi/pulumi-terraform-bridge/pf/internal/plugin.(*providerServer).CheckConfig(0xc0033ca600, {0xf6dc250, 0xc0034042a0}, 0xc00abe53e0)
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/pf@v0.16.1/internal/plugin/provider_server.go:198 +0x1ad
    github.com/pulumi/pulumi-terraform-bridge/x/muxer.(*muxer).CheckConfig.func1()
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/x/muxer@v0.0.7-0.20230801203955-5d215c892096/muxer.go:115 +0x6f
    github.com/pulumi/pulumi-terraform-bridge/x/muxer.asyncJoin[...].func1()
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/x/muxer@v0.0.7-0.20230801203955-5d215c892096/muxer.go:562 +0x42
    created by github.com/pulumi/pulumi-terraform-bridge/x/muxer.asyncJoin[...] in goroutine 51
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/x/muxer@v0.0.7-0.20230801203955-5d215c892096/muxer.go:561 +0x6c

  pulumi:providers:aws (provider):
    error: rpc error: code = Unavailable desc = error reading from server: EOF

Output of pulumi about
CLI
Version      3.83.0
Go Version   go1.21.1
Go Compiler  gc

Plugins
NAME    VERSION
aws     6.2.0
nodejs  unknown

Host
OS       ubuntu
Version  22.04
Arch     x86_64

Additional context
A downgrade to "@pulumi/aws": "5.42.0" deploys the resources as expected. This issue appears limited to 6.x.x.
Possibly, pulumi preview is trying to validate the arn exists, which it cannot as the account has not yet been created?
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

A note as well to assist with triage - what makes this a bit nasty is that since the stack deploys normally if the aws.organizations.Account resource already exists in the stack, the bug remains hidden up and until you try to create a new account.
So if you have upgraded your stack from v5.x to v6.x, and you are using Pulumi to auto-create accounts (say developer accounts, or customer accounts) then everything looks like it is working exactly as it should be, and you get on with integrating the new v6.x resources. At some point, maybe  a few months later, you go to onboard a new developer/customer/etc - and it is at this point the CLI blows up on you.

Thank you for the issue and a full repro @tom-fletcher! So much appreciated.
I can reproduce the error locally. Looks like a TFPF integration error, @t0yv0 could you please take a look?

Same issue is happening to me here, upgrading from 5.42.0 to 6.2.0 and I got panic errors too.
It seems that pulumi preview is using a lot of memory, reaching my 7.5 GB memory limit (3 GB used when idle).
After 2 reboots I managed to get the pulumi preview step to succeed but when following the memory usage with htop, it seems I barely avoided an OOM panic because my memory almost reached its maximum usage right before the process ended.
My previous panic errors were likely caused by OOM too, I followed the process execution with htop too and the error happened when the memory was full.

@eneiss could you open a separate issue with the panics you're getting and increased memory usage? I'm assuming that the example program listed in this ticket does not trigger the OOM or does it? Thank you.

@t0yv0 @eneiss I am not seeing any memory issues in the repro docker container with htop or top, so I suspect the OOM is a seperate issue.

Appreciate patience here while we decide on a fix here.
It appears to be a bug in plugin terraform framework fixable with this https://github.com/hashicorp/terraform-plugin-framework/compare/main...t0yv0:terraform-plugin-framework:t0yv0/fix-value-at-path-panic ; quite possibly this is not activated when using the TF provider under Terraform CLI due to a difference in how the unknown values are encoded and passed in.
Our options so far are:

build against the above patch

disable provider unknown validation for PF, possibly as an option for AWS provider only; since our current architecture mixes SDKv2 and PF based providers and broadcasts configuration calls, that's not as bad as otherwise since the SDK2 provider will still perform validations on the values

possibly investigate deeper to the discrepancy between how the provider is invoked under TF and Pulumi

We'll aim to have something available by EOW to unblock here.

@tom-fletcher we believe v6.2.1 should fix the issue but please reopen if you are still having problems with it! Thank you.


Make an issue for practice

Description
연습을 위한 이슈 생성
Tasks (Processes)

[ ] Task 1
[ ] Task 2
[ ] Task 3

References

[link text] (link address)

Issue for practice


Upgrade to React@16

Upgrade to React@16

[ ] react
[ ] react-dom
[x] react-test-renderer
[ ] react-addons-css-transition-group (???)
[x] Enzyme
[ ] enzyme-adapter-react-16

Update test setup to use enzyme adapter

Good call, will try and bump this up in priority.
I have work for updating the test suite for enzyme@3, just am waiting for reviews for #258 and #265 and then will create that PR.

Just an update, #258 and #265 are merged and am now making the PR for the enzyme updates.

PR for update to enzyme #282

Do you think this effort will be completed by 4Q?

@sppatel for sure! Right now the biggest blocker has been enzyme not supporting React 16 portals, so we need to find a solution in the meantime to get over this hurdle.


Add a Playable piano Extension

Describe the solution you'd like
I will Add a Playable piano Extension
https://github.com/Sulagna-Dutta-Roy/GGExtensions/assets/118350936/809f10b1-e5c6-4baf-8981-efa92fdc8252

Added added to my repository #89. Closing it


414 inadequate session termination

Trello https://trello.com/c/NStzgIbd/414-inadequate-session-termination
The recent pen test highlighted that our sessions are not invalidated properly on logout.
This possible solution sets the session cookie's expiry to the Unix epoch (which one would hope is in the past).
I'm not 100% sure this will be sufficient! It's also hard to test in-browser as a new session cookie is immediately set for the logged out user.
Thoughts/alternative suggestions welcome.

Yeah... as discussed just now, I don't think we store the sessions server side (at least not anywhere I know about). Flask-Session allows you to configure a DB table or Redis cache to store things. But it feels a bit nuts introducing a way of storing sessions just so we can delete them.

Yeah it's not actually possible to do an ad-hoc invalidation of this type of signed session cookie - one of the reasons I don't like them. You only have that ability if you use server-side sessions. A malicious user would just ignore the cookie in this response.
Introducing server-side sessions would probably involve adding another moving part for us because of the wonderful way our existing stuff is designed with our database hidden behind an "api"...


Support loading PTX in cupy.RawModule

Part of #2779.
This PR is simply to demonstrate that it is very easy to support PTX in cupy.RawModule. It's basically a one-line change.
While I do not have any opinion in whether to support this or not, I did have this possibility in mind when adding cupy.RawModule in #2389, and recently I heard there exists people writing PTX directly instead of in CUDA C/C++, despite it is a quite unusual and inefficient approach IMHO.
I'll let the core devs make the decision for the PTX support.

pfnCI, test this please.

Jenkins CI test (for commit 0fe8b6d7177c9b73581867c1ddeec5c16f381cfd, target branch master) succeeded!

I think supporting PTX files is fine. Ones may have their optimized PTX code base that can be hand-written or translated from another language as Numba's CUDA JIT does.

Please wait for #2784 and rebase

LGTM! I've also checked PTX files can be loaded to RawModule on my local.

@emcastillo I merged the change to master at the same time with your comment, sorry 😢

No worries, well fix it 😄

Thank you, @takagi! Sou you think #2779 can be closed?

Yes. I've closed it just now!


Scheduled Task Initiation on Remote Endpoint - Update Analytics

One of the current filters: Processes.process=*/s* creates false positives because it matches on the /sc switch/argument for the schtasks.exe binary.
Recommend adding a space character like so: Processes.process=*/s *

Thank you @Badoodish : We have fixed this SPL and will ship an updated version shortly! appreciate the details in here.

shipped in 4.37.0! Thank you!


Release uts 224

Dear Team,
This pull request is focused on jodd-log module.
Code coverage is measured using JaCoCo. This pull request increases code
coverage of the whole project by 96%.

Metric
Before
After

Coverage%    |37%     |96%
Lines Covered|354      |918
Total Lines      |354     |918
Please let me know if you have any questions.
Vijay
DevFactory - Code Quality Team.

Just started reviewing :):rocket:

Awesome!!! Just uploaded the coverage here as well: https://coveralls.io/github/oblac/jodd
Just few notes:

don't need to squash commits, we are ok with many :)
i've just re-enabled the testAll for all modules, but didn't delete the javaTestModules - please keep using it so at the end we can use it in the testAll task, as you have planned!

:+1: :+1: :+1:  Thank you!

Also feel free to add reference to DevFactory  in the CODE_COVERAGE file, i think its fair :)

Thanks a lot @igorspasic for your prompt action in reviewing our PR and accepting it. It gives us a lot of motivation and confidence of doing such contributions.
Thank again
Farid

Thank you @mfarid for the contribution!
I was so happy today seeing total code coverage goes up :)))


AI Using Template Suggestion

I used my fabric_get_instructions template to get instructions from a video.
Worked OK with this procedure;

Press Alt N to choose template.
Choose my Template (basd on a fabric template) for getting instructions from a YouTube Video.
Went to youtube and copied the transcript
Pasted in at end of template
Pressed Alt L (The Hotkey I had set for "SystemSculpt AI: Toggle general generation" )

Result ; I now have a Note File With the required result at the end but still have the template at start.
SUGGESTION:
Would prefer to somehow do something more like this:
Put the YouTube transcript in a Note and enter its File Name (This could also be some other prompt for AI)
Enter somewhere what Template to use
Then Just Hit a Hotkey and the AI would generate a new file based on the Transcript and the Template, with an automaticly generated title.
I suspect you maybe working on something like this but I feel current procedure is improvable..
Template Used:
fabric_get_instructions.md
Result:
Setting Up SystemSculpt AI with BRAT on Obsidian A Step-by-Step Tutorial.md

Yep, I have YouTube video transcription in the works as part of the upcoming new Data module, will have that + Omnivore + Readwise + Reader integration to start with, maybe Twitter too if I have time to add that before I release the initial version of it :)

I think that is great and there is just one request I have just thought of…..
If you could figure out how to answer a question about your plug in using AI from within Obsidian.. “How do I …”, “I want to ….. but instead … how do I fix” etc.  You could build in an attempt at this and ask users to tell you if they don’t get a good answer so then make it self improve.    Its an important step towards the totally intuitive AI where learning how to set up a plug in is totally painless!!  (Would be a great help for my decaying 74 year old brain!!)
By the way I got the local LLM working really well yesterday, I was using Llama 3 and it was really fast.  My only difficulty was issues with context windows and long questions getting short answers.   When using OpenAI you have a context window setting.  In LM Studio I used to be able to mess with that and some Models had big windows – you have done a lot of testing so at some point some sort of write up – or a remake of some of your old videos – looking at how to tackle your Plug in plus LM Studio – which Models best for what etc would be great (and how to tweak) .   – A future wish though you need to get the functionality going first.
Regards
David Torrens
Grayerbeard
Shropshire UK
From: SystemSculpt @.>
Sent: Sunday, April 28, 2024 2:02 AM
To: SystemSculpt/obsidian-systemsculpt-ai @.>
Cc: David Torrens @.>; Author @.>
Subject: Re: [SystemSculpt/obsidian-systemsculpt-ai] AI Using Template Suggestion (Issue #4)
Yep, I have YouTube video transcription in the works as part of the upcoming new Data module, will have that + Omnivore + Readwise + Reader integration to start with, maybe Twitter too if I have time to add that before I release the initial version of it :)
—
Reply to this email directly, view it on GitHub https://github.com/SystemSculpt/obsidian-systemsculpt-ai/issues/4#issuecomment-2081271424 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUCWEMQV6BARLTRWAT2Q2DY7RDBHAVCNFSM6AAAAABGW7TSS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGI3TCNBSGQ .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/ADUCWEMTCYE5MHUPCYSCD3DY7RDBHA5CNFSM6AAAAABGW7TSS6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT4BWXIA.gif Message ID: @.*** @.***> >


render tex errors in red instead of throwing

https://github.com/Khan/KaTeX/issues/237
disable the throwOnError option then KaTeX will render the unsupported source command in red. See https://github.com/Khan/KaTeX#rendering-options for details.

looks like we need this: https://github.com/Khan/KaTeX/issues/425

until then, we should just copy and fix this function on our own.

ended up reverting: https://github.com/twosigma/beaker-notebook/pull/4696
new plan:

forget vendorizing and altering auto-render.
for TeX cells do it like the PR above did, show it as a red error, not with a popup.  throwOnError: false seems to work here, so keep using it.
for text cells, if there is a math error then show the bad math source in red and put the error in a tooltip (appears on hover).


Not Allowed access - Laravel 5.2

It works when I accessed from <IP_ADDRESS> without port 8100,
but how can make that work on port 8100?
I haven't any problem on L5.1, but now I use L5.2 and I got this problem T_T

Hi,
Change
'Barryvdh\Cors\ServiceProvider' to Barryvdh\Cors\ServiceProvider::class on config/app.php

already bro T_T

Same issue here on  lumen   "version": "v5.1.6", cors: "version": "v0.8.0",
Worked before.

I just missing cors middleware


Rviz Visualization Config

The coverage demo currently doesn't have proper visualization in RVIZ. This adds that.

Please fix the linting errors:
 /usr/bin/bash -c source /opt/ros/iron/setup.sh && ament_flake8 $(colcon list --packages-select opennav_coverage opennav_coverage_bt opennav_coverage_demo opennav_coverage_msgs opennav_coverage_navigator -p)
    rviz_config_file = os.path.join(coverage_demo_dir, "rviz_config.rviz")
                                                       ^
Error:         launch_arguments={'namespace': '','rviz_config': rviz_config_file}.items())
                                         ^
1     E231 missing whitespace after ','
1     Q000 Double quotes found but single quotes preferred

Error: opennav_coverage_demo/launch/coverage_demo_launch.py:28:56: Q000 Double quotes found but single quotes preferred

Error: opennav_coverage_demo/launch/coverage_demo_launch.py:70:42: E231 missing whitespace after ','

Ok I've fixed the issues and added the image.


[Docker Desktop] Showing both docker images and docker containers in Docker Desktop

Tell us about your request
I have been an early user of Kitematic. As much as it's nice to manage Docker containers directly from the new dashboard, it would be also good to have a section to list out and manage docker images created locally.
Which service(s) is this request for?
Desktop
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
As of now, we can directly manage docker containers via the dashboard. Can we also have a section to show docker images created locally so we would not need to use the CLI. This way we will not need to manage containers via the UI and images via CLI.
Are you currently working around the issue?
Not at the moment. but I have the bandwidth to discuss and work on the issue if we could come to a conclusion.
Additional context
N/A

@pavan168 Is this the same as #9 or is there something additional that you feel #9 doesn't cover?

@stephen-turner issue #9 pretty much sums it up but in addition to that, we would like to see the docker prune functionality. We often don't check dangling images and unused images in our machines. It would be best to slowly bring this feature up or show the estimated total storage used by unused images.

Thanks, @pavan168. I agree that prune would be very useful in the images UI, but it's already called out in #9, so I think that issue covers everything. So I'm going to close this one as a dupe.


[FR] [ws-bulk-report-generator] Global Org Vuln Report

I would like to pull a Global org report for vulnerabilities.
This can be accomplished right now by running vulnerability reports for each org and combining them.
Command:  ws_bulk_report_generator.exe -a https://app.whitesourcesoftware.com -u user_token -k org_token -y globalOrganization -o output_folder -r vulnerability -t unified_xlsx

Hi @jbnable, check out the latest version which adds the organization name for each record, so you can distinguish which organization it came from.
Thanks,
WhiteSource PS team

Works great, thanks!


Making decorator for text retrieval configurable

Some time ago, each term used to be decorated with ~ at the end for fuzzy matches. This got lost at some point, which leads to a query for JAMES to not match AMES in an OCR column. To fix this, this PR adds configurable decorators for all text-retrieval classes. Default behavior stays the same.
Additionally, it adds the option to configure entity-names for text retrieval classes and fixes rare edge-cases where batch-import would cause problems.

I've made changes to all features which were using a specific type of map in their constructor and did not need it.


healthcheck parameter

Do you want to request a feature or report a bug?
Bug
What did you do?
A healthcheck on my container with

 traefik.backend.healthcheck.path: '/primus?access_token=healthcheck&transport=polling'

1')
- "traefik.backend.healthcheck.path='/primus?access_token=healthcheck&transport=polling'"

and

 - "traefik.backend.healthcheck.path=/primus?access_token=healthcheck&transport=polling"

What did you expect to see?
Healthcheck pinging /primus?access_token=healthcheck&transport=polling
What did you see instead?
Case 2) was pinging /primus without parameters
Case 1) and 1') converted ? and &, result in /primus%3Faccess_token=healthcheck&transport=polling
Output of traefik version: (What version of Traefik are you using?)

Version:      v1.7.4
Codename:     maroilles
Go version:   go1.11.1
Built:        2018-10-30_10

What is your environment & configuration (arguments, toml, provider, platform, ...)?
debug = false

logLevel = "ERROR"
defaultEntryPoints = ["https","http"]

[entryPoints]
  [entryPoints.http]
  address = ":80"
    [entryPoints.http.redirect]
    entryPoint = "https"
  [entryPoints.https]
  address = ":443"
  [entryPoints.https.tls]

[retry]

[docker]
endpoint = "tcp://<IP_ADDRESS>:2376"
domain = "my.domain"
watch = true
exposedByDefault = false
swarmMode = true

[acme]
email =<EMAIL_ADDRESS>storage = "acme.json"
entryPoint = "https"
onHostRule = true
[acme.httpChallenge]
entryPoint = "http"

If applicable, please paste the log output in DEBUG level (--logLevel=DEBUG switch)
version: '3'
services:
  primus:
    image: ${REGISTRY_URL}primus-${SUBDOMAIN}:${GIT_HASH:-latest}
    networks:
      traefik-net:
        aliases:
        - primus-${SUBDOMAIN}
    env_file: env_${SUBDOMAIN}/primus.env
    command: npm start
    deploy:
      labels:
      traefik.docker.network: "traefik-net"
      traefik.frontend.rule=Host:primus.${SUBDOMAIN}.${DOMAIN}"
      traefik.backend=primus-${SUBDOMAIN}"
      - "traefik.backend.loadbalancer.swarm=true"
      - "traefik.backend.loadbalancer.stickiness=true"
      - "traefik.backend.healthcheck.path='/primus?access_token=healthcheck&transport=polling'"
      - "traefik.backend.healthcheck.interval=10s"
      - "traefik.backend.healthcheck.timeout=2s"
      - "traefik.port=2333"
      - "traefik.protocol=http"
      - "traefik.enable=true"
    ports:
    - "2333"

Closed by #4188.


[MM-45269] Remove typing from insights time dropdown

Summary
Remove typing from insights time dropdown
Ticket Link
https://mattermost.atlassian.net/browse/MM-45277
Related Pull Requests

Has server changes (please link here)
Has mobile changes (please link here)

Screenshots

Release Note

NONE

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/213372


raise error on extra args/kwargs

Fixes https://github.com/AgnostiqHQ/covalent/issues/1584

[x] I have added the tests to cover my changes.
[x] I have updated the documentation and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

It might be worthwhile to try a more robust check with inspect.signature and let user know specifically which arguments or kwargs are missing or extra in the error as well.

So, I already tried getfullargspec stuff. There are two issues:
1. It doesn't preserve the original function signature, probably because decorators change the metadata...
Eg, if you try:
import covalent as ct

@ct.lattice
@ct.electron
def job(val1, val2):
    return val1 + val2

and do a getfullargspec on func inside the get_named_params function, we get:
FullArgSpec(args=[], varargs='args', varkw='kwargs', defaults=None, kwonlyargs=[],
kwonlydefaults=None, annotations={})

Clearly, the information about val1 and val2 is lost... while func still refers to <function job at 0x106ae8b80>
2. It interferes with postprocessing...
Specifically, build_graph calls pp.add_exhaustive_postprocess_node at some point which further uses the _postprocess function which has the signature def _postprocess(self, *ordered_node_outputs: List[Any]) -> Any:
Doing a getfullargspec on this gives us:
FullArgSpec(args=['self'], varargs='ordered_node_outputs', varkw=None, defaults=None, kwonlyargs=[],
kwonlydefaults=None, annotations={'return': typing.Any, 'ordered_node_outputs': typing.List[typing.Any]})

As one can see, we cannot use this information to count our varargs in some sense. Plus, it also includes self as one of the arguments (and will probably include cls too for class methods, if any).
Thus, even without using getfullargspec and directly counting with
ordered_params_dict = inspect.signature(func).parameters also leads to issues i.e. a simple comparison such as
if len(args) + len(kwargs) > len(ordered_params_dict) aka my first commit here: https://github.com/AgnostiqHQ/covalent/pull/1593/commits/79610c283c6b7e3fa81dbcbf6cace234d9e27752 will lead to errors...

In fact, the current approach of iterating and figuring out the named_args and named_kwargs is much better and hence, I resorted to using that itself...
My suggestion would be to tackle this "extended" functionality as a separate issue / PR owing to the above problems + the original issue also had a limited scope anyway...

Hey @madhur-tandon thanks for the PR 😄 ! I agree with the points you mentioned and that the current method of determining named args and kwargs is better, but I think what @santoshkumarradha mentioned:

let user know specifically which arguments or kwargs are missing or extra in the error as well.

is quite achievable by only a few minor changes to the modifications you already made in the PR. For example, in the case of positional arguments we can tell the user how many extra args they have passed vs how many were expected. And for the keyword arguments we can tell them what were the keys that they passed which were not expected in the raised ValueError. Basically instead of comparing the length of all parameters, we split that into 2 if conditions one for args and one for kwargs.
Again, I realize the scope of the original issue did not include improvement in the error description, but the changes required to add that description shouldn't be a lot.
PS:

You can use set for the key comparison: set(kwargs.keys()) - set(named_kwargs.keys())
Bonus points if you can also handle the case where fewer arguments are passed than required. Something like this should help:

        if param.default is param.empty and param_name not in kwargs and ind >= len(args):
            raise ValueError(f"Parameter {param_name} is required, but not supplied.")

@kessler-frost Sure, I TOO think that some improvements can be made with the current mechanism of figuring out the named_args and named_kwargs, I wrote the above text to:

specifically highlight the issues with getfullargspec and that I had already tried it
suggest that we could do the extended functionality in another PR

But, now that I think of it again, probably adding the same in this PR makes sense as well.
So, thanks for your comments, I will probably make some changes, add tests, and push again in some time...

Sounds good 🤘

I suggest not to figure out the case where fewer arguments are present and the associated check of:
if param.default is param.empty and param_name not in kwargs and ind >= len(args):
    raise ValueError(f"Parameter {param_name} is required, but not supplied.")

Instead, since we call the function anyway at some point i.e. inside build_graph:
try:
    retval = workflow_function(*new_args, **new_kwargs)

The above call is enough to determine missing arguments and will throw an error on it's own i.e. it won't be thrown by us, but the purpose is served anyway.
I say because, considering the below snippet for example:
@ct.electron
def task(x, y, *z):
    return x + y + sum(z)

@ct.lattice
def workflow(x, y, *z):
    return task(x, y, *z)

workflow.build_graph(x=7, y=8)

There are no issues with this but then, the snippet for calculating fewer arguments would check for z here as well.
Thus, it is better to outsource this to the call of the function instead.

Sure, we can figure out the resolution for that in a separate issue then.

@kessler-frost seems like there's an issue with CI and resolving the environment and dependencies, can you have a look and re-trigger the CI?


BOM Maint freeze upon clicking operation

The BOM UI freezes during on-click event of operation in tree view.   Entire UI freezes and must be stopped with task manager.

method event to retrieve operation info double dipping on connection call.  This is a bug in the calling method.

code correction added with Patch 6.7.12.  Closing.


Modal navigation

As a user, I want the ability to navigate between options in a modal by tabbing around or using the arrows, wrapping around as it goes, and then exiting out of there by pressing the escape key.

Fixed by #34


Fix go fmt with 1.19

What type of PR is this?
/kind failing-test
What does this PR do / why we need it:
Fixes go fmt errors with golang 1.19.z currently occurring in CI.
Have you updated the necessary documentation?
N/A
Which issue(s) this PR fixes:
How to test changes / Special notes to the reviewer:
The Validate PRs / Build (pull_request) github action should now pass.

Codecov Report
Base: 58.58% // Head: 58.58% // No change to project coverage :thumbsup:

Coverage data is based on head (822af62) compared to base (92954ca).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   58.58%   58.58%
=======================================
  Files          57       57
  Lines        2888     2888
=======================================
  Hits         1692     1692
  Misses       1030     1030
  Partials      166      166

Flag
Coverage Δ

unittests
58.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/pipelines/accesstoken/accesstoken.go
56.25% <ø> (ø)

pkg/pipelines/config/config.go
55.55% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/lgtm
/approve

/ok-to-test

/retest-required

/retest-required

/retest-required


What is the difference between Locality and Priority?

What is the difference between Locality and Priority?
When should I use one or another (or both)?
Thanks.

Locality is more about location.  Perhaps you want to send more traffic to locations closer to your Envoy instance.  Priority is more about failover.  "Ideally I'd like to send my traffic to A/B in my top priority but if they're overloaded/unhealthy spill over to C/D"

@alyssawilk thanks for your reply. So locality is more like automatic, location-based priority?


Add support for ariaControls and fix ariaLabelledby not working

My slider controls a value shown in a form elsewhere on my page. I want to use aria-controls to indicate which element the slider affects.
This pull request adds support for "aria-controls", that gets passed down to the <a> slider handle, in addition I noticed that aria-labelledby did not actually do anything, so I fixed that and added testcases for both.

http://oaa-accessibility.org/example/32/ has an example of role="slider" used in conjunction with aria-controls.

@esseb thanks for doing this!


"Allow negative marking" statement for marking algorithms

At the moment, Numbas applies a hard lower limit of zero credit to parts after submission has finished.
Some marking schemes, such as confidence based marking, require negative marking. The idea is that submitting a wrong answer is worse than saying nothing at all.
There could be an "allow negative marking" statement in a marking algorithm (it could just be a note called something like allow_negative_marking, taking a boolean value) to stop this limit being applied.
If this was a generic part option in the editor, it would both clutter the interface and make it hard to implement a reusable custom part type which always does negative marking.

Now that there are a few special notes in marking algorithms, I'm not keen on adding more. This should really be a straightforward checkbox option. Custom part types could have the same checkbox; I don't know why I thought that was an obstacle!

The next question is: where should this option be, and when should it be available?
It might make sense for "allow negative marking" to always be visible in a MCQ part, because you can easily set negative marks for the options. But in a number entry part, you'd have to make a custom marking algorithm for it to be possible to award negative marks.


Select Region and AZ in CLI

Nicer menu to select region and AZ rather than typing it in.
Perhaps moving available regions and AZs from the GUI into lib for consumption in CLI and GUI

in dev


clipsToBounds not working

Seems like clipsToBounds not working anymore since the latest release.

Can you provide more information? For example, provide a small demo app using Cocaopods. With the latest version 2.7 , it should show the issue, with older version, it works fine. Thanks.

Closing this issue now, let us know if you have any questions.

Hi,
Sorry i was quite busy last week. Please refer to attached code as requested.
AnimtableTest.zip

@SMFakhir Can you provide some details? I can see the first one is OK and the second one has the problem. But can you provide more details on what's the difference between them? What's your requirement?

Actually my requirement is more related to first one but i thought it would be good if i provide a variation, well, i kind of requires clipsToBounds to work with corner radius too but as you can see in the second case, it even fails without it, so in both cases the inner view should be cut off. this is exactly happening in 2.6 but latest version doesn't comply anymore.
I don't quite have time to look into the code right now but i would certainly do that when i find some time and make a PR.
On the other hand it would be best if IBAnimatable also provides corner radius to one or more sides.
Thanks.

@SMFakhir sorry, I still can't what causes this issue. A PR will be appreciated, thanks.

@SMFakhir I have submitted a PR #343  to address this issue, please have a look when you have time, thanks.

Hi @JakeLin
Can you add this fix to version 2.8.1 ?

Yes, @retsohuang  but I am busy on a talk for Yow Connected tomorrow, I need to do it after. If OK, can I ask you a favor to create a PR to swift2 branch? The change is https://github.com/IBAnimatable/IBAnimatable/pull/343/files#diff-31a58763e1e26ac0a8bd2adf82b0bd4bR72 thanks.


Only run in octokit org

Resolves #232

Before the change?

Error: Input required and not supplied: github-token

After the change?

silence

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[x] No

Hey @jsoref,
Thanks for the change.  Given that this action is propagated by the repository at the root of our org (no manual changes allowed in this file per repo and that this change would exclude other repos that we own (i.e. Terraform) we will not be merging this in.


Allow opts to flow to the backend snapshotter during snapshot creation.

Allow opts to flow to the backend snapshotter during snapshot creation. For example, this would allow the underlying snapshotter to make decisions based on pass through labels.

/cc @dmcgowan
Signed-off-by: Eric Hotinger<EMAIL_ADDRESS>

Codecov Report

Merging #3055 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3055   +/-   ##
=======================================
  Coverage   43.87%   43.87%
=======================================
  Files         102      102
  Lines       10903    10903
=======================================
  Hits         4784     4784
+ Misses       5384     5383    -1
- Partials      735      736    +1

Flag
Coverage Δ

#linux
47.48% <100%> (ø)
:arrow_up:

#windows
41.08% <66.66%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

metadata/snapshot.go
45.8% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24a743...472619c. Read the comment docs.

The options need to be filtered. The pass through should be done based on whether the metadata sees labels that should apply to the backend and not just to the namespace. In the design issue I mentioned doing this based on prefixing, such as containerd.io/snapshot/*. The backend snapshotter is considered a shared resource across namespaces, we need to prevent namespace specific data leaking into that layer.

Makes sense. I didn't see https://github.com/containerd/containerd/issues/2907 before this, looks like I just hit the same problem. I'll rework it a bit to make it upstream-friendly.

@dmcgowan was busy doing other things recently, but I'll get back to this now. Just to clarify, you just want a simple filter func that does a strings.HasPrefix for containerd.io/snapshot/ for all keys and creates a new map and passed that in?

@ehotinger yes, I believe you are on the right track; @dmcgowan can confirm. We also need to document these prefixes somewhere so this design is clear to implementers/users.

Yeah just let me know what you guys want and I can add in the filter + rebase.

@ehotinger - Took me a minute to capture @dmcgowan's ask here. I believe to satisfy what @estesp said about documentation and to satisfy only forwarding containerd.io/snapshot/ labels to a snapshots.Snapshotter we make the following changes:
Update: https://github.com/containerd/containerd/blob/master/snapshots/snapshotter.go#L92
To say something like
        // Labels for a snapshot
        //
        // Note: that only labels prefixed with `containerd.io/snapshot/` will be forwarded to the
        // snapshotter's `Prepare`, `View`, or `Commit` calls.
	Labels  map[string]string `json:",omitempty"`

And then in:
https://github.com/containerd/containerd/blob/master/metadata/snapshot.go#L344
https://github.com/containerd/containerd/blob/master/metadata/snapshot.go#L346
https://github.com/containerd/containerd/blob/master/metadata/snapshot.go#L450
We only forward snapshots.WithLabels(toSnapshotterLabels(base.Labels)) based on the following:
func toSnapshotterLabels(labels map[string]string) map[string]string {
    m := make(map[string]string)
    for k, v := range labels {
        if strings.HasPrefix(k, "containerd.io/snapshot/") {
            m[k] = v
        }
    }
    return m
}

So basically, persist all labels, forward only prefix containerd.io/snapshot/ to a snapshotter impl and document on the snapshotter interface which prefix is forwarded.

@jterry75 yeah so it's a slice of snapshot opts not labels being passed.
I need to know whether or not we should include all opts that have at least one label matching the prefix, or if we need to fundamentally change it from opts into labels only, or if we only want to include opts that have all labels containing the prefix, etc. To keep the PR small and flexible I think passing along all opts that have at least one label with the prefix makes sense to me.

@jterry75 yeah I'm not sure still. The opts are being passed along with Parent, Labels, Created, Updated, all of these are useful to consume. And maybe more stuff in the future. So... maybe if an opt contains at least one label that has the magic prefix then include the opt it in a new slice and pass that through?

@jterry75 yeah I'm not sure still. The opts are being passed along with Parent, Labels, Created, Updated, all of these are useful to consume. And maybe more stuff in the future. So... maybe if an opt contains at least one label that has the magic prefix then include the opt it in a new slice and pass that through?
/cc @estesp + @dmcgowan

The interface does not allow passing the full spec. I think the way to do that would be to add the additional opts With* to snapshotter.go or you could add one WithInfo and pass a blob through in total.

@ehotinger - Did you forget to add your changes? This is the same commit force-pushed ?

@jterry75 I force-pushed just to do a rebase initially. :smiley:
I force-pushed again now with the changes.

@estesp - PTAL

Test failure seems unrelated/flaky

Test failure seems unrelated/flaky

Error is for sure not related to this change. It failed in cri test

@crosbymichael - How do you feel about this one as well?

Code looks good, the only thing I would change is the terminology.  fowarded/passthrought to just inherit because that is what is actually happening.

@crosbymichael I changed the terminology to "inherited" across the board, PTAL - let me know if anything can be improved.

LGTM


Binary data to display as string escaped in ssdb-cli

hi, all response data translated by string_escaped function.
So, you can copy it from the terminal, and import the data by import tool.

Hi, it is wrong to escape any data in a SDK, because SSDB is binary compatible. It is the user's responsible to choose any way he want to display any data.
You should never think of this totally WRONG thing! Man, you should inspect your own mind.

If you want to escape binary data with ssdb-cli, see the help message:
ssdb <IP_ADDRESS>:8888> help

# display ssdb-server status
	info
# escape/do not escape response data
	: escape yes|no
# export/import
	export [-i] out_file
		-i	interactive mode
	import in_file

see http://ssdb.io/docs/php/ for commands details

press 'q' and Enter to quit.

hi, I know what you mean.
I've tried to set escape option on ./ssdb-cli. But it doesn't work. Binary data cannot string escaped yet. Was my command wrong?
ssdb <IP_ADDRESS>:8888> :escape yes
  Escape response
ssdb <IP_ADDRESS>:8888>

Hi, it is a bug in ssdb-cli.cpy, I just fixed it. Thank you.
close this PR.


Update samesite.md

Fixes #17033

@blowdart  do we want to add
Starting in Canary version 80.0.3975.0, the Lax+POST temporary mitigation can be disabled for testing purposes using the new flag --enable-features=SameSiteDefaultChecksMethodRigorously to allow testing of sites and services

That'd be great


image-fetaure-view-point-v2

#35
#3

There is an unused space if there are no images in payload.

Fixed!!!
Please review @generall


Server returns ERROR  on PUSH  when certain UNICODE characters are in the request contents.

You can reproduce the error response, inserting some extended UNICODE characters in the values of the attributes ,  and calling to the Databox.prototype.push() method  .
I could consider this limitation a big issue for non english speakeing communites.
In my case, as a Spanish speaker, and considering that almost the 20% of our words  have an accent (á é í ó ú) , this makes it unusable.
Proposed test characters:

焦 (chinese)
ñ (spanish)
ö (french)
ç (catalan)

Test code:
databoxClient.push({
        key     :'test',
        value   : 1,
        attributes : {
            crash : 'á',
        }
    }, response => console.log(response) );

Server Response:
Object {type: "invalid_json", message: "Invalid request body - JSON parse error"}

I fixed this issue, and opened a PULL request : #6

Thanks for reporting the issue and providing the fix @colxi 👍
I need to validate it against the server and confirm that it's only sdk issue.


New-PCOrder - Creation of order fails

unable to create order. Undefined OrderLineItem.
https://msdn.microsoft.com/en-us/library/partnercenter/mt634667.aspx
i guess the class OrderLineItem is not getting resolved properly
https://github.com/Microsoft/PartnerCenterPowerShellModule/blob/fb5edd81c2ceae0dd2461424f208e45cbe261460/PartnerCenterModule/PartnerCenterModule.psm1

Had the same problem. To get the class OrderLineItem to be exported I had to run
using module PartnerCenterModule


Website says something about MultiplayerAPI, but in Godot, it won't work.

Godot version:
v.3.0.1
OS/device including version:
Windows 8.1
Issue description:
I tried to use MultiplayerAPI class for Godot, and I wrote some code like this:
get_tree().multiplayer.connect("network_peer_packet", self, "_network_peer_packet")
But when I try to run the code, it says "invalid get index 'multiplayer' (on base: 'SceneTree')."
I also tried MultiplayerAPI instead of "multiplayer" and it doesn't recognize the class.
Steps to reproduce:
Write get_tree().multiplayer.connect("network_peer_packet", self, "_network_peer_packet"),
Run,
Reproduce!

There is no mention to the MultiplayerAPI class in 3.0 docs, because the MultiplayerAPI class was implemented in 3.1.
You probably read the 3.1 docs and got confused.
Try that code with 3.1-alpha1 and it will work.
Closing.


Exordium

CurseForge link
https://www.curseforge.com/minecraft/mc-mods/exordium
CurseForge Mod Distribution
Not allowed
Modrinth link
https://modrinth.com/mod/exordium
Source/other link
No response
Mod file size
130.18 KB
License
(any other license)
What it does
It essentially Renders GUI at a lower framerate, to allow for more CPU/GPU room for rendering the world.
Why should it be in the modpack
I would consider Exordium to be a great candidate to add to FO, and adds to the main goal of the modpack, on the surface, it doesn't add much, yet the performance is boosted even further. Plus, it has compatibility with a lot of the mods already in FO. I've been using this mod with FO for the past half-month, and a bunch of other (not performance based) mods, yet it's remained stable.
Why shouldn't it be in the modpack
However, that said, the compatibility doesn't stretch everywhere, many developers may have designed things with that GUI FPS in mind, therefore with certain mods (a good example being Xaero's World Map) or just in general, there can be quite a few visual and/or compatibility issues in GUI, whether it be blinking, failing to render, or failing function properly at all.
Also, this mod has no plans of backports, due to limitations in the game's engine.
That said, keep in mind that if there is a compatibility issue, you can always report it on their GitHub, so if there's any problems with mods in FO, there is a possibility of the problem being solved.
Additional details
Quite frankly, I am slightly surprised noone has noticed this mod yet, it seems to check all the boxes for a good mod for FO, while I admit, distribution not being allowed is a problem, there is always potential to collaborate with tr9zw (The developer of the mod) in the future.

Duplicate of #398


targets when SIZE_DIVISIBILITY > 1

❓ Questions and Help
When SIZE_DIVISIBILITY is set larger than 1 some padding is applied to the input image. Shouldn't targets be shifted as well to match the padding?

Hi,
Great question!
Note that the images are padded on the right / bottom. Given that the bounding boxes are referenced starting from the top/right corner, padding the images do not change the coordinates of the boxes.
Let me know if you have further questions.

Thanks! :)


Enhance account key update logic to batch transactions instead of loading all with sleep

:tada: This issue has been resolved in version 0.22.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


embedded: add swift_dynamicCastClass runtime function

Explanation: Fixes a linker error when doing a dynamic class down cast. The swift_dynamicCastClass runtime function was missing.
Scope: Only affects embedded swift.
Risk: very low. There is no change in existing code. Just the new runtime function is added.
Testing: Tested by a test case
Issue: rdar://129672994
Reviewer:  @kubamracek
Main branch PR: https://github.com/apple/swift/pull/74332

@swift-ci test


fix issue in field missing :req token

 var header = req.headers[field.toLowerCase()]
                                 ^
TypeError: Cannot read properties of undefined (reading 'toLowerCase')

Node.js v18.7.0

Missing field of req token causes the app to crash in this PR I fixed this issues with the following solution:

In case user doesn't define a specific field of the response the code will log the whole header response
If user defines its field the code will log just the value responding to the field itself.

I believe the code become more generic and it behaves correctly with various response headers.
All tests pass:
><EMAIL_ADDRESS>test
> mocha --check-leaks --reporter spec --bail

  morgan()
    arguments
      ✓ should use default format
      format
        ✓ should accept format as format name
        ✓ should accept format as format string
        ✓ should accept format as function
        ✓ should reject format as bool
        back-compat
          ✓ should accept options object
          ✓ should accept format in options for back-compat
          ✓ should accept format function in options for back-compat
      stream
        ✓ should default to process.stdout
        ✓ should set stream to write logs to
    tokens
      :date
        ✓ should get current date in "web" format by default
        ✓ should get current date in "clf" format
        ✓ should get current date in "iso" format
        ✓ should get current date in "web" format
        ✓ should be blank for unknown format
      :http-version
        ✓ should be 1.0 or 1.1
      :req
        ✓ should get request properties
        ✓ should display all values of array headers
      :res
        ✓ should get response properties
        ✓ should display all values of array headers
      :remote-addr
        ✓ should get remote address
        ✓ should use req.ip if there
        ✓ should work on https server
        ✓ should work when connection: close
        ✓ should work when connection: keep-alive
        ✓ should work when req.ip is a getter
        ✓ should not fail if req.connection missing
      :remote-user
        ✓ should be empty if none present
        ✓ should support Basic authorization
        ✓ should be empty for empty Basic authorization user
      :response-time
        ✓ should be in milliseconds
        ✓ should have three digits by default
        ✓ should have five digits with argument "5"
        ✓ should have no digits with argument "0"
        ✓ should not include response write time (51ms)
        ✓ should be empty without hidden property
        ✓ should be empty before response
        ✓ should be empty if morgan invoked after response sent
      :status
        ✓ should get response status
        ✓ should not exist before response sent
        ✓ should not exist for aborted request
      :total-time
        ✓ should be in milliseconds
        ✓ should have three digits by default
        ✓ should have five digits with argument "5"
        ✓ should have no digits with argument "0"
        ✓ should include response write time (52ms)
        ✓ should be empty without hidden property
        ✓ should be empty before response
        ✓ should be empty if morgan invoked after response sent
      :url
        ✓ should get request URL
        ✓ should use req.originalUrl if exists
        ✓ should not exist for aborted request
    formats
      a function
        ✓ should log result of function
        ✓ should not log for undefined return
        ✓ should not log for null return
      a string
        ✓ should accept format as format string of tokens
        ✓ should accept text mixed with tokens
        ✓ should accept special characters
      combined
        ✓ should match expectations
      common
        ✓ should match expectations
      default
        ✓ should match expectations
      dev
        ✓ should not color 1xx
        ✓ should color 2xx green
        ✓ should color 3xx cyan
        ✓ should color 4xx yelow
        ✓ should color 5xx red
        with "immediate: true" option
          ✓ should not have color or response values
      short
        ✓ should match expectations
      tiny
        ✓ should match expectations
    with buffer option
      ✓ should flush log periodically (1003ms)
      ✓ should accept custom interval (206ms)
    with immediate option
      ✓ should not have value for :res
      ✓ should not have value for :response-time
      ✓ should not have value for :status
      ✓ should log before response
    with skip option
      ✓ should be able to skip based on request
      ✓ should be able to skip based on response

  morgan.compile(format)
    arguments
      format
        ✓ should be required
        ✓ should reject functions
        ✓ should reject numbers
        ✓ should compile a string into a function

  81 passing (1s)

Hello, and thank you for your PR. The crash is expected, as the :req token requires a header name. The error mesaage is not great, however. I think we can improve the error message that the argument is missing.

Thank you for your review. I did fix the issue by throwing an error says 'req is missing an argument'.
:req may take the following arguments :
host, 'accept-encoding', 'user-agent','set-cookie', connection

any updates?

@dougwilson, thank you for your suggestions. I did try to write a unit test but I wasn't able to figure it out.
can you help me figuring it out?

@dougwilson, I think I am not able to add tests if you point me to a resource to figure out how could I write a proper tests I'll be thankful.


Solidity images are broken

See Aloxaf/silicon#199

I've filed upstream Aloxaf/silicon#200 which fixes this.
I manually built and deployed a patched silicon which fixes this for the currently live bot, but I haven't included it in the automated build process.
I expect this will be fixed without changes to colorcodebot if/when silicon 0.4.4 lands.
If that doesn't happen, I'll have to set up recurring builds of silicon or otherwise integrate it into the overall build process.

Incidentally, the running bot now features ligatures, thanks to an unreleased change in upstream silicon.

The custom build is integrated into the build process now. After the next upstream silicon release, if it ever happens, I'll remove the custom build.


CUDA error: an illegal memory access was encountered while using PyG and torch_sparse

🐛 Bug

Hi, I'm struggling with a CUDA error 😥
Following arises the error CUDA error: an illegal memory access was encountered.
model = Model(**input_args)

trainer = trainer = Trainer(
    num_sanity_val_steps=0,
    gpus=1, auto_select_gpus=True,
    strategy='dp',
    max_time=timedelta(hours=1),
    logger=TensorBoardLogger(
        default_hp_metric=False,
        save_dir='/workspace/logs_v2.0',
        name=f'hood_glift'),
    callbacks=[
        LearningRateMonitor(logging_interval='epoch'),
    ]
)

trainer.fit(model, loader)

Specifically while using spspmm in my model. My model is composed of a few torch_geometric layers. I'm afraid that it's too complex to describe the whole architecture in here. But the error occurred at C = matmul(A, B) in spspmm
I've tried (1) no strategy, (2) strategy='dp' and (3) strategy=DDPPlugin() for the Trainer's argument.
Also, my model is working when I use it on CPU and GPU manually, as
model = Model(**input_args)
model.to('cuda:0')
data = next(iter(loader)).to('cuda:0')
out = model(data)

In this case, both .to('cuda:0') and .cuda(0) work fine.
Environment

PyTorch Lightning Version : 1.5.6
PyTorch Version : 1.10
Python version : 3.7
OS : Ubuntu 18.04.6
CUDA/cuDNN version : 11.3
GPU models and configuration : NVIDIA GeForce RTX 3090
How you installed PyTorch : using docker image pytorch/pytorch:1.10.0-cuda11.3-cudnn8-runtime

Hey @minsikseo-cdl,
Would it be possible for you to create a reproducible script using a simple model from PyG using Lightning as the trainer?
cc @rusty1s

@tchaton
uh... moment, please. dataset itself is confidential, so I'm afraid I can't provide it because it's an industry-academic project.
But here is the part of my code which the problem was occurred:
import torch
from torch import nn
from torch_geometric import nn as gnn
from torch_geometric.utils import remove_self_loops, add_self_loops, sort_edge_index
from torch_geometric.nn.pool.topk_pool import topk, filter_adj
from torch_scatter import scatter
from torch_sparse import spspmm

def augment_adj(edge_index, edge_weight, num_nodes):
    edge_index, edge_weight = remove_self_loops(edge_index, edge_weight)
    edge_index, edge_weight = add_self_loops(edge_index, edge_weight,
                                                num_nodes=num_nodes)
    edge_index, edge_weight = sort_edge_index(edge_index, edge_weight,
                                                num_nodes)
    edge_index, edge_weight = spspmm(edge_index, edge_weight, edge_index,
                                        edge_weight, num_nodes, num_nodes,
                                        num_nodes)
    edge_index, edge_weight = remove_self_loops(edge_index, edge_weight)
    return edge_index, edge_weight

class TopKPooling(nn.Module):
    def __init__(self, in_channels, ratio=0.5, act='Tanh', param={}, **kwargs):
        super().__init__()
        self.in_channels = in_channels
        self.ratio = ratio
        self.act = getattr(nn, act)(**param)

        self.p = nn.Parameter(torch.Tensor(in_channels))

        self.reset_parameters()

    def reset_parameters(self):
        size = self.in_channels
        gnn.inits.uniform(size, self.p)

    def forward(self, x, edge_index, edge_attr=None, batch=None):
        if batch is None:
            batch = edge_index.new_zeros(x.size(0))

        y = torch.matmul(x, self.p) / self.p.norm(p=2, dim=-1)

        perm = topk(y, self.ratio, batch)
        x = x[perm] * self.act(y[perm].view(-1, 1))

        batch = batch[perm]
        edge_index, edge_attr = filter_adj(
            edge_index, edge_attr, perm, num_nodes=y.size(0))

        return x, edge_index, edge_attr, batch, perm, y[perm]

class GCNBlock(nn.Module):
    def __init__(self,
                 in_channels, out_channels, norm=True, GNN='GCNConv',
                 act='LeakyReLU', param={'negative_slope': 0.2, 'inplace': True},
                 **kwargs):
        super().__init__()
        self.norm = norm
        self.conv = getattr(gnn, GNN)(in_channels, out_channels, bias=not norm, **kwargs)
        if norm:
            self.bn = nn.BatchNorm1d(out_channels)
        self.act = getattr(nn, act)(**param)

    def forward(self, x, edge_index, edge_weight=None):
        x = self.conv(x, edge_index, edge_weight)
        if self.norm:
            x = self.bn(x)
        return self.act(x)

class PoolNet(nn.Module):
    def __init__(self,
                 in_channels, out_channels,
                 num_layers=3, GNN_param={},
                 ratio=0.5, pool_param={},
                 **kwargs):
        super().__init__()

        self.num_layers = num_layers

        # Top K Pooling (Gao & Ji, 2019)
        self.pool = TopKPooling(
            in_channels, ratio, **pool_param)

        # define GNN before pooling
        self.conv = nn.ModuleList()
        self.conv.append(GCNBlock(
            in_channels, out_channels, **GNN_param))
        for _ in range(num_layers - 1):
            self.conv.append(GCNBlock(
                out_channels, out_channels,
                **GNN_param))

    def forward(self, x, edge_index, batch=None):
        if batch is None:
            batch = edge_attr.new_zeros(x.size(0))
        edge_weight = x.new_ones(edge_index.size(1))

        # Augmentation
        edge_index, _ = augment_adj(edge_index, edge_weight, x.size(0))

        # Pooling
        out, edge_index, _, batch, _, _ = \
            self.pool(x, edge_index, None, batch=batch)

        # Convolution
        for layer in self.conv:
            out = layer(out, edge_index)

        return out, edge_index, batch

The error was occurred in augment_adj in PoolNet.forward'. My LightningModuleis consisted ofPoolNet` and the rest parts are as usual.
Sorry about that I cannot provide any detail, again 😥

Dear @minsikseo-cdl,
Would you mind mocking the data to ensure the code is reproducible ?

@tchaton
I just synthesized a dataset and script as you requested, but it worked... (it's weird)
I think this issue arises at a certain case in the middle of the process (e.g., OOM but pytorch_lightning may not catch or something else)
In fact, I found another issue related to torch_sparse #191 for a specific data or batch combination.
I think it might cause CUDAError mentioned above.
btw, I attached the code and data I made (but it does not reproduce the CUDAError
issue.zip
)
I sincerely appreciate your contribution to develop and maintain this package.

I think this issue is more related to pytorch_sparse rather than pytorch_lightning. I suggest to close this issue and continue our discussion in https://github.com/rusty1s/pytorch_sparse/issues/191.

@rusty1s @tchaton
I think so.
Or it might related to OOM just in my case only.
Thanks :)