Bug: I can't update metadata of a user using the API but I can on products, orders, etc.

What are you trying to achieve?
I try to update the metadata of a user from a Next.js app. I have all permissions and can update order metadata etc. When trying to update a user I get error Apps are not allowed to perform this mutation. Any ideas why this happens?
Steps to reproduce the problem

Use the metadata mutation query on a user:export const UPDATE_METADATA_QUERY = gql` mutation updateMetadata($id: ID!, $input: [MetadataInput!]!) {  updateMetadata(id: $id, input: $input) {    metadataErrors {      field      code    }    item {      metadata {        key        value      }    }  } } `;
Get permission denied error with message Apps are not allowed to perform this mutation

What did you expect to happen?
I expected to get a metafield on the user
Logs
No response
Environment
Saleor version: 3.18.15

Somehow this only happened for one customer..


Update NLTK model downloads

The latest version of NTLK introduced a few breaking changes in regards to the model downloading procedure. The build and examples should be updated to fix these.

nltk 3.8.2 was deleted from PyPI given these breaking changes.

nltk 3.8.2 was deleted from PyPI given these breaking changes. So it looks like this change needs to be reverted until the next stable nltk release.

A change will be put in to download both the old and new models. This will support both the current (3.8.1) and future versions that require the new models.
txtai can be updated a later time to require the new version of NLTK and only use the new models, once NLTK finalizes the path forward.


URL missing

URL for AD Azure Connect is missing from the website: https://docs.microsoft.com/pl-pl/azure/active-directory/hybrid/tshoot-connect-connectivity#troubleshoot-connectivity-issues-in-the-installation-wizard

.www.d-trust.net
.root-c3-ca2-2009.ocsp.d-trust.net
.oneocsp.microsoft.com

URLs on the website https://docs.microsoft.com/pl-pl/azure/active-directory/hybrid/tshoot-connect-connectivity#troubleshoot-connectivity-issues-in-the-installation-wizard have a wildcard and on this site is given without a wildcard.

Szczegóły dokumentu
⚠ Nie edytuj tej sekcji. Jest ona wymagana dla docs.microsoft.com ➟ Dołączanie problemu w usłudze GitHub.

ID: 66bd8666-3566-a901-b25b-eb6baba6264a
Version Independent ID: e9f6310f-2207-8c81-d31a-3d5a80beb26b
Content: Office 365 URLs and IP address ranges - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/urls-and-ip-address-ranges.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@JoeDavies-MSFT  Please add your comment and help us in resolving this issue. Thanks.

@JoeDavies-MSFT  Please add your comment and help us in resolving this issue. Thanks.

@Michal-Witwicki The Office 365 URLs and IP address ranges - Microsoft 365 Enterprise article is for Microsoft 365 for enterprise endpoints and does not include Azure-specific endpoints. Thanks for letting us know.

@Michal-Witwicki The Office 365 URLs and IP address ranges - Microsoft 365 Enterprise article is for Microsoft 365 for enterprise endpoints and does not include Azure-specific endpoints. Thanks for letting us know.


Open files in bytes mode when reading or writing bytes.

@somexpert @ldko This PR addresses #32. Here, I opened those files in bytes mode which are reading from and writing to files in bytes.

Looks good :thumbsup:

A tip @madhulika95b:
When writing your description comment when opening a PR, if you use certain language, the issue you are addressing will be automatically closed for you. For example, if instead of saying "addresses #32" you say "fixes #32", issue #32 would be closed automatically when merging the PR. This helps prevent us from accidentally leaving issues open after they have been resolved.

Thank you for letting me know!! Will use the same from now on.


Content Security Policy / SAML Keycloak

Description
SAML authentication with keycloak was working with build 3114 but after upgrade to latest version,
I can see following error in browser console after clicking on 'sign-in' button:
Refused to execute inline event handler because it violates the following Content Security Policy directive: "script-src 'self' 'nonce-MDNkMzRiNzctNTQyMS00MjJjLTlkN2YtMmI1NDk4YjM1ZTlm'". Either the 'unsafe-inline' keyword, a hash ('sha256-...'), or a nonce ('nonce-...') is required to enable inline execution. Note that hashes do not apply to event handlers, style attributes and javascript: navigations unless the 'unsafe-hashes' keyword is present.
Steps to reproduce

configure saml/keycloak
open structurizr onpremise home page
click sign-in button

Screenshot
No response
Code sample
No response
Configuration
No response
Severity
Minor
Priority
I have no budget and there's no rush, please fix this for free
More information
No response

Hello @simonbrowndotje ,
any update on this bug? I have the same issue with keycloak integration.
Thanks in advance

We don't have any paying customers who use Keycloak, so it's not very high on the todo list I'm afraid ... the code is open source, so I was hoping somebody in the community would resolve this.
Just FYI though, the on-premises installation is being upgraded to Spring 6/Tomcat 10 (branch), which completely changes the SAML integration ... so it might not be worth anybody resolving this now.

@simonbrowndotje , Many thanks Simon! I think I can wait for it. Anyway, thanks for the great project!

If you'd like to try it, a preview of the new Spring 6/Tomcat 10 build is available via Docker at the structurizr/onpremises:preview image. The SAML configuration is different; see https://docs.structurizr.com/onpremises/authentication/aml#preview-build-spring-6tomcat-10 for some basic instructions.

@simonbrowndotje
Thanks a lot Simon! appreciate this!
Unfortunately, now it gives me another error when redirects to /saml2/authenticate/default:

Logs:
[DEBUG] 2023-12-21 16:33:03.848 [http-nio-8080-exec-4] FilterChainProxy - Securing GET /dashboard
[DEBUG] 2023-12-21 16:33:03.850 [http-nio-8080-exec-4] FilterChainProxy - Secured GET /dashboard
[DEBUG] 2023-12-21 16:33:03.856 [http-nio-8080-exec-4] AnonymousAuthenticationFilter - Set SecurityContextHolder to anonymous SecurityContext
[DEBUG] 2023-12-21 16:33:03.869 [http-nio-8080-exec-4] MethodSecurityInterceptor - Failed to authorize ReflectiveMethodInvocation: public java.lang.String com.structurizr.onpremises.web.home.HomePageController.showAuthenticatedDashboard(java.lang.String,int,int,org.springframework.ui.ModelMap); target is of class [com.structurizr.onpremises.web.home.HomePageController] with attributes [[authorize: 'isAuthenticated()', filter: 'null', filterTarget: 'null']]
[DEBUG] 2023-12-21 16:33:03.876 [http-nio-8080-exec-4] HttpSessionRequestCache - Saved request https://structurizr.mydomain.com/dashboard?continue to session
[DEBUG] 2023-12-21 16:33:03.877 [http-nio-8080-exec-4] DelegatingAuthenticationEntryPoint - Trying to match using And [Not [RequestHeaderRequestMatcher [expectedHeaderName=X-Requested-With, expectedHeaderValue=XMLHttpRequest]], Not [And [Or [Ant [pattern='/login'], Ant [pattern='/favicon.ico']], And [Not [RequestHeaderRequestMatcher [expectedHeaderName=X-Requested-With, expectedHeaderValue=XMLHttpRequest]], MediaTypeRequestMatcher [contentNegotiationStrategy=org.springframework.web.accept.HeaderContentNegotiationStrategy@67f9f5b3, matchingMediaTypes=[application/xhtml+xml, image/*, text/html, text/plain], useEquals=false, ignoredMediaTypes=[*/*]]]]]]
[DEBUG] 2023-12-21 16:33:03.884 [http-nio-8080-exec-4] DelegatingAuthenticationEntryPoint - Match found! Executing org.springframework.security.web.authentication.LoginUrlAuthenticationEntryPoint@2377b5b
[DEBUG] 2023-12-21 16:33:03.886 [http-nio-8080-exec-4] DefaultRedirectStrategy - Redirecting to https://structurizr.mydomain.com/saml2/authenticate/default

structurizr.properties:
structurizr.feature.ui.dslEditor=true
structurizr.url=https://structurizr.mydomain.com
structurizr.admin=structurizr
structurizr.data=aws-s3
structurizr.authentication=saml
structurizr.saml.metadata=https://keycloak.mydomain.com/auth/realms/services/protocol/saml/descriptor
structurizr.saml.entityId=structurizr
structurizr.saml.signing.certificate=mydomain.com.cer
structirizr.saml.signing.privateKey=mydomain.com.key
aws-s3.accessKeyId=***********
aws-s3.secretAccessKey=*****************
aws-s3.bucketName=structurizr
aws-s3.endpoint=https://blobstorage.mydomain.com:9000
aws-s3.pathStyleAccess=true

Everything is configured according to the instruction. Although, maybe I've missed something...

I have the same problem using Okta.
Refused to execute inline event handler because it violates the following Content Security Policy directive: "script-src 'self' 'nonce-MDNkMzRiNzctNTQyMS00MjJjLTlkN2YtMmI1NDk4YjM1ZTlm'". Either the 'unsafe-inline' keyword, a hash ('sha256-...'), or a nonce ('nonce-...') is required to enable inline execution. Note that hashes do not apply to event handlers, style attributes and javascript: navigations unless the 'unsafe-hashes' keyword is present.

I have the same problem using Okta.

The current Spring 5/Tomcat 9 build will be superseded in a week or so - I'd recommend trying the new version (structurizr/onpremises:preview) with Okta ... there's an example SAML configuration at https://docs.structurizr.com/onpremises/authentication/saml#preview-build-spring-6tomcat-10 (this is taken from the Spring Security samples):
# Okta<EMAIL_ADDRESS>structurizr.authentication=saml
structurizr.saml.registrationId=one
structurizr.saml.metadata=https://dev-05937739.okta.com/app/exk46xofd8NZvFCpS5d7/sso/saml/metadata
structurizr.saml.attribute.username=email

Everything is configured according to the instruction. Although, maybe I've missed something...

You will just need to debug the SAML handshakes, etc I'm afraid; see https://docs.structurizr.com/onpremises/authentication/saml#troubleshooting for some pointers.

The Jakarta EE/Spring 6 version of the on-premises installation has now been released, which provides a new SAML integration mechanism ... closing as stale.


Existentially quantified types are defined in outer scope

type Foo {
  Bar[T]()
}

type Baz {
  Bam[T]()
}

should type check, but reports:
Type T already defined in the current scope

The scope of T is probably not delimited correctly in Namer and hence it introduces a file-global type T.

Here is gpt4o:
In the build.sbt, ensure that type parameters are handled correctly.
class Namer {
  def defineTypeParameters(params: List[TypeParameter], scope: Scope): Unit = {
    params.foreach { param =>
      scope.define(param)
    }
  }

  def enterScope[T](scope: Scope)(block: => T): T = {
    val previousScope = currentScope
    currentScope = scope
    try {
      block
    } finally {
      currentScope = previousScope
    }
  }
}

Create tests to ensure type parameters are scoped correctly.
test("Type parameters are scoped locally") {
  val fooScope = new Scope()
  val bazScope = new Scope()

  enterScope(fooScope) {
    defineTypeParameters(List("T"), fooScope)
    assert(fooScope.lookup("T").isDefined)
  }

  enterScope(bazScope) {
    defineTypeParameters(List("T"), bazScope)
    assert(bazScope.lookup("T").isDefined)
  }
}

Sorry @unnir, not even close :)


Shadowrun Sixth World v.49

Changes / Comments
Added ability to import characters created using the Genesis Chargen tool into the roll20 sheet.
Roll20 Requests

[ Y ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ N ] Is this a bug fix?
[ Y ] Does this add functional enhancements (new features or extending existing features) ?
[ N ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ NA ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ NA ] If this is a new sheet, did you follow Building Character Sheets standards ?

Character Sheet Info Roll20 Internal Use only.

Please note the Sigil Shadow changes in the first commit were required before I could do ANYTHING due to the crlf issues git has.  The last change reverts those changes so this should not modify any Sigil Shadow files.


Whether to consider supporting escape characters？

If I want to use | in the table，I can use \| to escape. but your plugin doesn't recognize it, causing formatting errors.

name
type
required
description

id
string | array
yes

Thank you! I was not aware it was possible to escape the pipe character like this. I will make it so that escaped pipe characters are respected and do not break the table layout.

Thank you! I need this feature, you have worked hard!


feat(deps): bump deps

Codecov Report

Merging #196 (718893f) into master (5f3f820) will decrease coverage by 1.49%.
Report is 47 commits behind head on master.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   93.01%   91.53%   -1.49%
==========================================
  Files          13        8       -5
  Lines         358      248     -110
==========================================
- Hits          333      227     -106
+ Misses         18       14       -4
  Partials        7        7


feat(config): set defaults with env vars

Allows you to set hard defaults via env vars. These are last in priority after defaults specified in the config YAML. Formatting for these vars is ARGUS_ followed by the YAML tag format in uppercase with _ delimeters. e.g.
ARGUS_SERVICE_LATEST_VERSION_ACCESS_TOKEN for a default on defaults.service.latest_version.access_token in the YAML

Hi @JosephKav,
I am unable to get this to work.  Can you explain how I should set the env variable in the config? (docker build from master)
I know it doesn't work this way but this how I was thinking about it.  You should be able to set any env variable name in the container, set the config file to use the same env variable, and argus would on load, do a find/replace in the config.  This is how other services I use work.
Example:
  extraSecretEnvironmentVars:
    - name: GITHUB_ACCESS_TOKEN
      valueFrom:
        secretKeyRef:
          name: argus-secrets
          key: GITHUB_ACCESS_TOKEN

    service:
      argus:
        latest_version:
          type: github
          access_token: $GITHUB_ACCESS_TOKEN
          url: release-argus/argus

The error from the pod logs:
ERROR: argus, github access token is invalid

When I do:
  extraSecretEnvironmentVars:
    - name: ARGUS_SERVICE_LATEST_VERSION_ACCESS_TOKEN
      valueFrom:
        secretKeyRef:
          name: argus-secrets
          key: GITHUB_ACCESS_TOKEN

    service:
      argus:
        latest_version:
          type: github
          url: release-argus/argus

Error, its not passing the auth information in the header:
ERROR: argus, Get "https://api.github.com/repos/release-argus/argus/releases": net/http: invalid header field value for "Authorization"

Doing this in the config doesn't work either:
    service:
      argus:
        latest_version:
          type: github
          access_token: $ARGUS_SERVICE_LATEST_VERSION_ACCESS_TOKEN
          url: release-argus/argus

It isn't clear what I should put in the config.
Thanks

That is what I thought I was doing:
From http://localhost:8000/api/v1/version
{"version":"development","buildDate":"2023-05-23T18:33:27Z","goVersion":"go1.20.4"}

My config:
  config: |
    settings:
      log:
        level: DEBUG
    service:
      argus:
        latest_version:
          type: github
          url: release-argus/argus
        deployed_version:
          url: http://localhost:8080/api/v1/version
          json: version
        dashboard:
          icon: https://github.com/release-argus/Argus/raw/master/web/ui/static/favicon.svg
          web_url: https://github.com/release-argus/Argus/blob/master/CHANGELOG.md

Logs:
Switching user UID:GID to 911:911
Applying perms to config.yml and argus.db
Starting...
DEBUG: 1/1 argus Init
INFO: Found 1 services to monitor:
  - argus
VERBOSE: argus, Tracking argus at https://github.com/release-argus/argus every 10m
ERROR: argus, Get "https://api.github.com/repos/release-argus/argus/releases": net/http: invalid header field value for "Authorization"
INFO: Listening on <IP_ADDRESS>:8080/
VERBOSE: httpVersion (<IP_ADDRESS>), -
ERROR: argus, failed converting "development" to a semantic version. If all versions are in this style, consider adding json/regex to get the version into the style of 'MAJOR.MINOR.PATCH' (https://semver.org/), or disabling semantic versioning (globally with defaults.service.semantic_versioning or just for this service with the semantic_versioning var)
VERBOSE: httpVersion (<IP_ADDRESS>), -
VERBOSE: httpVersion (<IP_ADDRESS>), -

My environment variables:
# env | grep ARGUS
ARGUS_SERVICE_HOST=<REDACTED>
ARGUS_SERVICE_LATEST_VERSION_ACCESS_TOKEN=ghp_<REDACTED>
ARGUS_SERVICE_PORT=80
ARGUS_PORT=tcp://<REDACTED>:80
ARGUS_PORT_80_TCP_ADDR=1<REDACTED>
ARGUS_PORT_80_TCP_PORT=80
ARGUS_PORT_80_TCP_PROTO=tcp
ARGUS_PORT_80_TCP=tcp://<REDACTED>:80
ARGUS_SERVICE_PORT_HTTP=80

I can try outside of k8s tomorrow.

@JosephKav
Unfortunately, this approach seems not helpful for all cases.
In my current case a header with the following name is needed.
HTTP Header X-Rundeck-Auth-Token
However, the character "-" is not a valid character for a linux environment variable.
Am I missing something?
Is there a way to work with variables here?
deployed_version:
      url: https://rundeck.xxxxxx.xxx/api/14/system/info
      headers:
        - key: X-Rundeck-Auth-Token
          value: <access_token>
      regex: <build>(.*)<\/build>

@w00dst0ck, I haven't added support for lists, e.g. deployed_version.headers from env vars


Create VBA-Web

@timhall You can report @jimjim16 for abuse to prevent similar spam in the future.


S3 File Uploads don't work with AWS SDK v3.

Support plan

which support plan is this issue covered by? (e.g. Community, Sponsor, or
Enterprise): Community
is this issue currently blocking your project? (yes/no): No
is this issue affecting a production system? (yes/no): No

Context

node version: 14.17.1
module (formidable) version: v2
environment (e.g. node, browser, native, OS): Node.js
used with (i.e. popular names of modules): @aws-sdk/client-s3
any other relevant information:

What are you trying to achieve or the steps to reproduce?
The S3 file upload example worked perfectly when using aws-sdk v2. In version 3, AWS has split SDKs for individual services so we're only importing what's required. I tried using the @aws-sdk/client-s3 package in Node.js along with Formidable.

const uploadStream = (file) => {
	const passThrough = new stream.PassThrough();

	const params = {
		ACL: 'public-read',
		Body: passThrough,
		Bucket: <BUCKET_NAME>,
		Key: file.originalFilename
	};

        // This works
	s3Client.upload(params, (error, data) => {
		if (error) {
			console.log('Error: ', error);
		}

		console.log('Data: ', data);
	});

        // This does not work. This is the method to upload to S3 in aws-sdk v3.
	s3Client.send(new PutObjectCommand(params))
		.then(response => {
			console.log('Response: ', response);
		})
		.catch(error => {
			console.log('Error: ', error);
		});

	return passThrough;
}

const upload = async (req, res) => {
	try {
		const form = formidable({
			fileWriteStreamHandler: uploadStream
		});
		form.parse(req, (error, fields, files) => {
			if (error) {
				res.status(400).json({ code: 'upload_failed', error: error.message });
				return;
			}

			res.status(200).json({ code: 'upload_success', fields, files });
		});
	} catch (error) {
		res.status(400).json({ code: 'upload_fail', error });
	}
}

What was the result you got?
Got an error in the console. I tried searching for this error thinking this might be an issue with the SDK but from what I could find, this is the error the AWS SDK sends whenever filename or content is empty. I'm confused as to why it would work in v2 but not in v3.
NotImplemented: A header you provided implies functionality that is not implemented
    at deserializeAws_restXmlPutObjectCommandError (~/app/node_modules/@aws-sdk/client-s3/dist/cjs/protocols/Aws_restXml.js:8254:41)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async ~/app/node_modules/@aws-sdk/middleware-serde/dist/cjs/deserializerMiddleware.js:6:20
    at async ~/app/node_modules/@aws-sdk/middleware-signing/dist/cjs/middleware.js:12:24
    at async StandardRetryStrategy.retry (~/app/node_modules/@aws-sdk/middleware-retry/dist/cjs/StandardRetryStrategy.js:51:46)
    at async ~/app/node_modules/@aws-sdk/middleware-logger/dist/cjs/loggerMiddleware.js:6:22 {
  Code: 'NotImplemented',
  Header: 'Transfer-Encoding',
  RequestId: '0741R14HV6YK6WQY',
  HostId: 'uNMoIDhpb3v7cswhj1WgQUxMfKQkDZGaocIPbe0yTxAnxENHKrK4SZghiAneJWPoeNXOBkUKaj8=',
  '$fault': 'client',
  '$metadata': {
    httpStatusCode: 501,
    requestId: undefined,
    extendedRequestId: 'uNMoIDhpb3v7cswhj1WgQUxMfKQkDZGaocIPbe0yTxAnxENHKrK4SZghiAneJWPoeNXOBkUKaj8=',
    cfId: undefined,
    attempts: 1,
    totalRetryDelay: 0
  }
}

What result did you expect?
Expected upload to work

it seems Transfer-Encoding was sent but not expected,
but the bug does not come from formidable
try to open an issue here https://github.com/aws/aws-sdk-js-v3

@AustinGil I'll take a look at Formidable specifically, but I was able to achieve streaming with busboy. The above example is a little strange because they never actually use file in uploadStream which I suspect was at least one of the issues.

Actually, looks like Discourse is doing something like what you want and also using the new AWS lib-storage API. https://sourcegraph.com/github.com/Discours/discoursio-webapp/-/blob/api/upload.mjs?subtree=true

@addy thanks for resplying. I'll take a look at that library, but I'm not sure if the example will work. As far as I can tell, the fileConsumer would store all the data in a memory Buffer (https://sourcegraph.com/github.com/Discours/discoursio-webapp/-/blob/api/upload.mjs?L57) which wouldn't work well for large files. I tried using a custom fileWriteStreamHandler to pipe the stream directly to an S3 upload request, but S3 complains about not knowing the content length.
Closest I've come is getting an upload working, but the data never arrives, so I end up with a 0 byte object in my bucket.
I'll take a look at lib-storage though. Maybe that'll do. Thanks for the advice :)

Got this working without writing to disk. lib-storage was the key along with the custom fileWriteStreamHandler
import stream from 'node:stream';
import formidable from 'formidable';
import { S3Client } from '@aws-sdk/client-s3';
import { Upload } from '@aws-sdk/lib-storage';

const s3Client = new S3Client({
  endpoint: process.env.S3_URL,
  credentials: {
    accessKeyId: process.env.S3_ACCESS_KEY,
    secretAccessKey: process.env.S3_SECRET_KEY,
  },
  region: process.env.S3_REGION,
});

/**
 * @param {import('http').IncomingMessage} req
 */
function parseMultipartNodeRequest(req) {
  const s3Uploads = []
  return new Promise((resolve, reject) => {
    const form = formidable({
      fileWriteStreamHandler: function (file) {
        const ws = new stream.PassThrough();
        const upload = new Upload({
          client: s3Client,
          params: {
            Bucket: 'bucket',
            Key: file.newFilename,
            Body: ws,
          },
        });
        const uploadRequest = upload.done().then((response) => {
          file.location = response.Location;
          return file;
        });
        s3Uploads.push(uploadRequest);
        return ws;
      };,
    })
    form.parse(req, (error, fields, files) => {
      if (error) {
        reject(error);
        return;
      }
      resolve({ ...fields, ...files });
    });
  })
}

I had to change a few things from my working code, but hopefully this sends folks in the right direction. Thanks again for the tip @addy


Just a few things

Commits say it all.
https://github.com/tommyettinger/gdx-liftoff/issues/22
Completed 7, and 11.
Tried 13, but couldn't get it to look good...
Also changed the URL to point to the new website.

Looks like a solid set of changes! Thanks especially for remembering that the site needed to be changed.

Yeah, another thing I had in mind was that since gdx-video might be coming back, it will have to be added eventually.
Moreover, I think gdx-controllers is about to officially be taken over by another library.

We already have gdx-controller-utils by MrStahlfelge in third-party extensions, it won't be hard to move. No idea about what gdx-video will need, but we'll want it in gdx-liftoff as soon as it's ready.


Add ADAL Python to the list of client libraries

@navyasric,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@navyasric : Thanks for your contribution to the Azure documentation! The author, @bryanla, has been notified to review your proposed change.

#sign-off


Remove options from empty layers' contextual menu

Related to: https://github.com/CartoDB/cartodb/issues/13451
Acceptance
Create a map with an empty layer and click in the layer contextual menu (the three dots)

[x] Check that the Export data option is not there
[x] Check that the Center map in layer option is not there

Add a geometry to that layer

[x] Check that the Export data option is there
[x] Check that the Center map in layer option is there

LGTM!


Update requirements.txt

When I ran pip3 install aerosandbox it didn't include pytest

Thank you, much appreciated! :)

Thank you, much appreciated! :)


UserGuide.adoc

Update the User Guide to include the 3 newly implemented features (searchall, searchfb, and searchtwitter).

Pull Request Test Coverage Report for Build 147

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.749%

Totals

Change from base Build 145:
0.0%

Covered Lines:
1830

Relevant Lines:
2062

💛  - Coveralls


Update to copy

updating AWS description:
Updating product description:
Link to original source:

Closes #

Hello @SendBord,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


[FE] Makka / #1992 pay with bank transfer FE changes

Description
This PR adds the ability to Retire via bank transfer, more detailed descriptions are available in the main ticket - #1992
Related Ticket
Closes #1992
Also related to & relies on #2024
Notes For QA
QA is required as this PR adds a new feature to pay with bank transfer on retirement pools.

[ ] Allow a user to choose Bank transfer from the Pay with list.
[ ] How many tonnes of carbon would you like to retire? is the only required field at this stage - the "Retire Carbon" button should be disabled if nothing is entered in this field. The other fields are optional. If nothing is entered into the Beneficiary wallet address field, the connected users wallet address will be used.
[ ] After entering a quantity and clicking "Retire Carbon", the user should be presented with a modal popup according to the figma designs where they can "Continue" or "Go back".
- Upon clicking "Go back" the modal should be closed.
- Upon clicking "Continue", the user should be brought to the "Pay with Bank Transfer" form where they are presented with a more detailed form with both required and optional fields. Any details entered on the previous "Retire Carbon" form should be carried over and filled in on this form.
[ ] On the "Pay with Bank Transfer" form the "Submit" button should be disabled if the required fields aren't filled out (denoted with an * on the label). As the user types in the input fields, error messages should be shown if the data is incorrect on a required field.
[ ] Upon submitting the form, a POST request is made to the carbonmark api at the following endpoint /retire/bank-transfer with the form data in the body of the request. The api then makes a call to the hubspot form api with the form data.

If the request is successful, a 200 response will be returned and the user will be shown the "Form complete" screen with the previously entered data filled out.
If the request is unsuccessful, a 400 response will be returned and an error message will be displayed above the "Submit" button.

Specific pages, components or journeys that might be affected:

Pool Retirements Page

@0xtapi i will be reviewing this one as well
designs are here: https://www.figma.com/file/5GewbdVaM1Q06CwHmF7d3F/Projects?type=design&node-id=2013-22744&mode=design&t=S61kzPdFZAf3aXPd-4
can you please focus on mobile and form field error checking
not sure you have access to hubspot?

can you please focus on mobile and form field error checking

Will do!

not sure you have access to hubspot?

I do not.

On mobile (but probably same on desktop):

While filling out the personal details form, app doesn't check whether the email address is valid. Any value (like "abc123") will be accepted.
"First name" and "Last name" allow numbers in the names, so user could enter something like "Max123" and it would be accepted by the app. Are there any regions where numbers are part of the name...? If not, this should probably check whether it's a "clean" name without numbers.

is there a maximum total price for bank transfers? I've currently set this to the same as credit card - 2,000.

In the "How would would you like to retire?" field, the app currently states it must be at least one tonne. This should be changed to whatever the minimum value is (once we know this value). Minor nitpick: we should maybe change this question to "How many tonnes would you like to retire?" to make it clear we're asking for tonnes and not for dollar values or so.
Btw, this whole process looks very good on mobile. No page breakers, bad layout, wrong font sizes or anything of that sort. Sweet stuff!

n the "How much would you like to retire?" field, the app currently states it must be at least one tonne. This should be changed to whatever the minimum value is (once we know this value). Minor nitpick: we should maybe change this question to "How many tonnes would you like to retire?" to make it clear we're asking for tonnes and not for dollar values or so.

@0xMakka @0xtapi hmmm...I did not see this enforced on the CM form but I tried to do quantity of 5000 and nothing happens, I just click RETIRE CARBON and nothing (and no error messages)
That being said, for Bank Transfer there would be no maximum quantity so if that is being enforced it should be removed.
I can ask the sales guys if they want a minimum value, stay tuned.

Almost there, but the check for emails still isn't quite working. It seems to check whether an "@" is there, but nothing else. So I can enter something like "tapioka@hello" or really wild stuff like "hi@-" and it goes through. Need a more strict check here (something like "Is this string@string.tld?" if not -> error).
All the other points I raised have been fixed though!

Almost there, but the check for emails still isn't quite working. It seems to check whether an "@" is there, but nothing else. So I can enter something like "tapioka@hello" or really wild stuff like "hi@-" and it goes through. Need a more strict check here (something like "Is this string@string.tld?" if not -> error).
All the other points I raised have been fixed though!

@0xtapi yeah you are right, I initially only went with the "@" to not make it too strict. However, I've just updated to be a little bit stricter regex which requires both an "@" a "." to be present in the string. So it should catch the cases you mentioned above.

@0xtapi yeah you are right, I initially only went with the "@" to not make it too strict. However, I've just updated to be a little bit stricter regex which requires both an "@" a "." to be present in the string. So it should catch the cases you mentioned above.

Lookss good now!

I don't want this in the public API docs confusing application developers since it's just form data specific to our frontend.

This would be better served from carbonmark/pages/api-- should be able to copy paste the core logic over directly (see nextjs docs), minus the fastify/schema and test boilerplate.
We don't have a test runner for carbonmark yet but a simple unit test would be nice (im not sure if the one you wrote can be reused)

@Atmosfearful Hmm, sorry about this. I didn't run the public api docs page to see this. Yeah, that makes sense - will move this logic over to a next api route instead.

@Atmosfearful moved the logic out of the api into a nextjs api route instead. I didn't write a unit test for this yet, but will look to see what if I can get this done tomorrow.

@0xMakka did another QA pass, everything is still working as expected on the front end


Enforce Named Exports Only

We current use a lot of wildcard exports from our packages. This leads us to over exporting things we don't need, as frequently we need something across file within a package, so it need to be exported at it definition, but isn't needed outside but due to the wildcard export it's automatically exported.
Ideally there is an es-lint rule we could enable to block wildcard exports. If we had something like that, we could write a script to convert all existing exports to named exports using something like ts-morph. this would prevent the unintentionally expansion of our api

fyi @tylerbutler and @curtisman

This lint rule will disallow export * from ___ statements:
"no-restricted-syntax": [
    "error",
    {
        "selector": "ExportAllDeclaration",
        "message": "Exporting * is not permitted. You should export only named items you intend to export."
    },
]

And it could be limited to only index.ts files using an override in the lint config. Might make sense to enable for some packages individually.


add travis CI

ambiguous issue is ambiguous. I'll have to figure out Travis.

Travis has been added https://github.com/vijayee/js-ipfs-merkle-dag/commit/c6f0d8e5fe200bff3125a0920938aad8d5645bc0

sweet! :D


Proptypes from React package is deprecated. Use the prop-types package from npm instead.

Fixed with #30


Parse Snapshot#timestamp with fromtimestamp

Since we know what this is supposed to be, we don't need to use the "best
guess" version from parse_date. Some values I was getting from the Pocket
API produced weird/inconsistent results.
Summary
I got some weird results with some timestamps from the Pocket API, which
could just be issues in Pocket's data, but as I was trying to solve them, I
realized we had this "best guess" approach for parsing a date, while we
know for sure this is a timestamp and could be parsed as one.
Related issues
N/A but wondering if maybe bookmarked should be reified into the DB?
Would be helpful for the REST API, so we could sort by bookmarked.
Changes these areas

[X] Bugfixes
[ ] Feature behavior
[ ] Command line interface
[ ] Configuration options
[ ] Internal architecture
[ ] Snapshot data layout on disk

Why do we know for sure that self.timestamp is a valid timestamp? It's not normalized on import and often it's taken as whatever the import source provides verbatim.
This is why we maintain self.added and self.updated separately which are guaranteed to be valid timestamps (with tzinfo) produced and consumed by django. bookmarked is the name for the attempted parsed version of self.timestamp, but it doesn't always succeed and the timestamp parsing logic changes over time as we improve it, so it's important to always keep the original string version and any attempted parsed version separate.

It's not normalized on import

After looking through the parsers, it is in all of them. They mostly do datetime.fromtimestamp before setting it to Link#timestamp (with other cases like generic_json doing a whole set of attempts to get a timestamp). But ultimately, it ends up being a timestamp (which is probably something I should fix in the the Pocket API PR).

it's important to always keep the original string version and any attempted parsed version separate.

FWIW, I'd be in favor of splitting these into two different columns in the db. timestamp is doing double-duty as both the time when the item was added/bookmarked/whatever-the-source-wants as well as the folder in data/archive. If we moved this into an actual bookmarked date field in the db, timestamp would just be the one thing.
Then maybe we could move data/archive to use sha and kill timestamp completely, and make it much clearer what those properties actually mean. I had mentioned this in the REST API thread, because then we could more easily query bookmarked by date rather than than timestamp without needing to do a bunch of translation either in the API or (yuck) the client.

After looking through the parsers, there is normalization in all of them

This is a relatively new addition, in the past we did not normalize these and there are users with thousands of links with invalid timestamps. For backward compatibility reasons we can never assume timestamps are always valid datetimes.

Then maybe we could move data/archive to use sha and kill timestamp completely

This is already planned and in-progress. We're using a truncated base32 hash of the URL for the v0.7 migration from timestamps to sha folders.
Backwards compatibility is being handled by the Django server accepting either the timestamp or base32 hash to retrieve a given snapshot, so only the on-disk layout will break.

@pirate Ah well. Good to know the history.
What's your feeling on adding bookmarked (or maybe a different field name like saved?) to the db as a datetime that the API could use?

I'm still hesitant to put bookmarked in the database, as so many of the timestamps can be incorrect and misleading for some users. I fear that if we add it as a queryable field people will start writing code that uses it, and those features will be built on a foundation of bad data. It's especially insidious because in pristine dev environments with test data everything looks fine, the problem is only apparent when working with large historical archives that have been imported over years or from particularly misbehaved browsers. It's easy for contributors to think it's a stable datetime source and not realize that it has a complicated history.
I'd rather we usher people towards using only added/updated for DB queries. I could maybe still be convinced to add it depending on the reason, is there a particular feature you had in mind that you wanted to use bookmarked for?

I'd rather we usher people towards using only added/updated for DB queries, but I could maybe be convinced to add it depending on the reason, is there a particular feature you had in mind that you wanted to use bookmarked for?

Yeah, the import from Pocket uses the archived timestamp from the Pocket API to populate the timestamp in ArchiveBox, which conveniently maps to the time I finished reading the piece, which is how I want to organize my link display. Using added / updated makes it look like I read 27k articles within the same 10s in 2020 :D. So I need something that maps from the archive source into ArchiveBox, which I can then query off of in the REST API for my site.

Open question here about reifying bookmarked into the db but obvs this PR is not gonna work.

Open question here about reifying bookmarked into the db but obvs this PR is not gonna work.


feat(cli): expose a function to kill dev child

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[x] I have added a convincing reason for adding this feature, if necessary

Other information
Sometimes while using the cli.js API from a JS script, a zombie process is left after killing the JS script using ctrl+c. I can't reproduce it reliably but having an API to kill the dev app process, the script could execute it upon exit:
process.on('SIGTERM', () => killDevApp());
process.on('exit', () => killDevApp());

I think we should try to do it on our end instead. Or maybe the JS script could just listen to ctrl+c and kill the CLI process manually?

I think we should try to do it on our end instead.

We could do that in cli.js but we'd still need to expose the function through NAPI

Or maybe the JS script could just listen to ctrl+c and kill the CLI process manually?

Again, we still need to expose a function to kill the process or at least the PID.

I still couldn't reproduce the issue :( I actually wanted to listen to the signal on the Rust code and let it handle it instead.

Yeah I can't really reproduce it reliably but I think it happens only after you triggered the CLI hot-reload at least once or twice.


Add Zero Artworks Screen for Collections

Adds a view for when filters in collections returns zero artworks + enables clearing filters and resetting collections to default state.
https://artsyproduct.atlassian.net/browse/FX-1794

Fails

:no_entry_sign:
Missing Test Files:

src/lib/Scenes/Collection/Screens/__tests__/CollectionZeroState-tests.tsx

If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

  Generated by :no_entry_sign: dangerJS

Fails

:no_entry_sign:
Missing Test Files:

src/lib/Scenes/Collection/Screens/__tests__/CollectionZeroState-tests.tsx

If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

  Generated by :no_entry_sign: dangerJS


Edited color in gutter and scrollbar mismatch

VSCode Version: 1.10
OS Version: MacOs Sierra

Steps to Reproduce:

Open VSCode project with a git repo
Edit a file and add some new lines
Side gutter on left shows green line for changes made.
Same section on scrollbar shows blue color.

Expected:
Color on scrollbar should be green too

This is as designed. Gutter will show green, blue and red. Scrollbar, due to being more compact, only shows blue in order to avoid color clutter.


[BUG] No values are received but devices are.

Checklist

[X] I'm using the latest Zabbix Server Release. => 6.4.12
[X] I'm using a local UniFi Account with at least RO permission on Zabbix. => A controller VM
[X] I have configured the template following README.md instruction.

Describe the Bug
I configured the settings and the devices are discovered. But the devices and also the "dummy host" for the Network Manager do not have any values.
Two questions that may be an issue but I want to verify:

Is only port 8443 (where the website runs) required from the Zabbix Server to the UniFi Network Server or are other connections required (i.e. other ports or connections to the devices itself)?
Is it possible that the ~half year old Network Server is the problem?

MACROS

Context

Zabbix Template Release: main
Zabbix Server Release: 6.4.12
UniFi Network Release: 7.5.187 (Ubiquiti Network Server VM)
UniFi Network Type: VM

Hi @Hunv,

Yes, the template it only use Unifi Network API.
It could be, the template it was tested with le latest Unifi Network Version.

Can you provide me more information like errors received from empty items?

Closed by inactivity


Better error handling for network timeouts on asset library called through lambda-invoke

Aws Connected Device Framework Affected Module(s):

assetlibrary
I'm submitting a ...

[x] bug report
[ ] feature request

Description:

When asset library is invoked using lambda-invoke, if there is a network connection issue or other problem, lambda-invoke will wait for the default amount of time before retrying (120 seconds, according to this). This will show misleading errors in the calling lambda, as default API Gateway/Lambda timeouts are 30 seconds.
Current behavior:

Facade function using lambda-invoke will respond with a 504 Gateway Timeout
Expected behavior:

Lambda-invoke retries before default lambda timeout expires. Either lambda-invoke fails after retry and proper error message is returned to calling function, or lambda-invoke succeeds and calling lambda is only slowed down slightly.
Steps to reproduce:

Use Lambda-invoke to perform an asset library call (like a search or get group)
Network (or other) issue causes request to timeout and not make it to asset library
Calling lambda times out before lambda-invoke has opportunity to retry

Additional Information:

Here's a timeout that occurred. This is a log message of a facade lambda invoking asset library (using lambda). It shows it waited for about 30 seconds until the lambda hit it's timeout.

The corresponding asset library logs don't even show any invocation at that time.

I'd like the team's thoughts on this.
If we think this is a true problem, my suggestion would be to shorten the timeout for the lambda-invoke in the AWS.Config used when creating the AWS.Lambda in assetlibrary-client/src/di/inversify.config.ts
const lambda = new AWS.Lambda({region:config.get('aws.region')});

to
const lambda = new AWS.Lambda({
  region:config.get('aws.region'),
  maxRetries: 2,
  httpOptions: {
    timeout: 5000,
    connectTimeout: 1000,
  }});

@boardthatpowder @hassankhokhar Want to get your input when you have a chance. What do you think about the following options?

Increase the Lambda Function's timeout so that it provides enough time for the labmda.invoke() SDK call to timeout gracefully.
Implement a timeout mechanism in the Lambda Function layer so that it gives up on a hanging lambda.invoke() SDK call, retrying it. Essentially moving the timeout & retry mechanism built-in with the SDK up to the calling application's layer.

Any timeout mechanism will need to be part of the calling function (e.g. facade) rather than the CDF client libraries due to the fact that a calling function my make multiple lambda invocations within the same APIGW execution context., therefore closing this.


Credo.Check.Refactor.ModuleDependencies breaks analysis

With Credo.Check.Refactor.ModuleDependencies enabled and a file that triggers this check, no issues show up on VSCode since the parsing fails on parser.tsx#L22 with trigger.replace is not a function.
This happens because the trigger for this check is an array, ie:
{
  category: "refactor",
  check: "Credo.Check.Refactor.ModuleDependencies",
  column: null,
  column_end: null,
  filename: "stdin",
  line_no: 1,
  message: "Module has too many dependencies: 13 (max is 10)",
  priority: 3,
  scope: "MyService.TooManyDeps",
  trigger: [
    "OK",
    "DateTime",
    "Atom",
    "Float",
    "Timex",
    "MyService.Dep1",
    "Enum",
    "Map",
    "MyService.Dep2",
    "MyService.Dep3",
    "MyService.Dep4",
    "MyService.Dep5",
    "List",
  ],
}

A quick fix would be to change the check on L19 to if (!trigger || typeof trigger !== 'string') return null; but maybe there's a better way to go about this.

Thanks for picking that up! Your solution is probably the best here because in such cases (at least for this check) it makes sense to highlight the entire module definition (in your example, line 1) instead of all module dependencies.


[AutoPR managedservices/resource-manager] [Hub Generated] Review request for Microsoft.ManagedServices to add version preview/2019-04-01-preview

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5947

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/5751


Grpc with Helidon's Netty

Investigate possibility of running Grpc on top of Helidon's event loop

This issue will not be fixed. We are introducing grpc on top of Níma in version 4


Removes redundant re-running of kani process

Description of changes:
The extension's process for running Kani runs Kani twice (for cases where there's a failure). Once for getting the overall verification result, and then for getting the output of Kani. Now, the process does not re-run for failed cases and simply returns the output and the result at the same time.
Resolved issues:
Resolves #43
Checklist

[ ] Each commit message has a non-empty body, explaining why the change was made
[ ] Methods or procedures are documented
[ ] Regression or unit tests are included, or existing tests cover the modified code
[ ] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Closing this draft PR. While some refactoring is required, this is not the way go about it.


Catalog design iteration

[x] Update Sterling to AI Apps for sponsor team
[x] Add community maintained sponsor team
[x] Fix sponsor circle background color so it's white
[x] Replace sponsor text with library name (and version too?)
[ ] Collapse assets by framework (both for components and assets) and remove React as the default filter
[ ] Create data viz catalog
[ ] Persist filter, search, and pagination to local storage like sort and view
[ ] Page header header needs bigger font size on xlg?

Draft

[ ] Add thumbnail production guidelines to schema documentation and provide design kit to generate thumbnails @jeanservaas
[ ] Component sub-types
[ ] Consider sub-type thumbnail images as fallback thumbnails if the asset doesn't have a thumbnail

Navigation
Structural navigation
Contextual navigation
Input
Data input and control
Forms
Information display
Data display and list
FYI
Progress and validation
Content organization
Content element
Container
Panel
Structure


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=400628416
https://github.com/Azure/azure-cli-extensions/commit/86720dc12c21ad9bedb27c9f8381a06c154c76a1

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Feature]: Retain data cache for parts widgets

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
After switching pages, all the data from the previous page will be reloaded. Can we keep the data of all components in the page, similar to react routing caching?
Do you support this feature or help point out where you need to modify it to achieve this effect? I really need this feature, and I would appreciate it if you can provide you with any help
Why should this be worked on?
I developed my application secondary based on appsmith, and I really needed this function

@rennzhang what type of data are you looking to cache? You can use the storeValue function to save data in the local storage.

Simply put, I hope that the page switch will not re-render the component. I tried some react-route caching solutions, but it didn't work
For example,  page a has a table component. I enter some query conditions and search for data. Then I jump to page b and return to page a. I hope that page a will not be refreshed, that the data will not be retrieved, and that I will keep the query conditions I entered before.

@rennzhang that is currently not possible

@Nikhil-Nandagopal Thank you for your answer. I spent a few days understanding the component rendering mechanism of this project, which is indeed very complex. However, I am not familiar with React enough, so I would like to ask about the general reason

The general reason is that each page is garbage collected after it's navigated away from to ensure that it doesn't consume memory. Appsmith is generally used for live dashboards where data changes and so it makes sense to fetch the data again.

I fully understand that it makes sense to have him rerender. Too much caching will cause a lot of memory to consume, and maybe the data state of the component is incorrect... But I still want to ask, if I only make modifications to a few components, such as table and list components, so that it retains data when switching pages, or recovers data from cache, is there any feasible way?
I tried to store cached widgetStaticProps here. Judging from the print log, it will initially be applied to the component, but will eventually be overwritten by the original props.
https://github.com/appsmithorg/appsmith/blob/62ffaf80a6b912fceccddcd97aa2049f97f64348/app/client/src/utils/widgetRenderUtils.tsx#L46

@rennzhang I'm not exactly sure of that and you may have better luck asking the team on discord. I don't think there is a simple holistic solution for this and the best way would be for the user to write the logic to cache the state of the widget using storeValue


Update pac4j to 5.6.1 and logback to 1.3.4

Description
Pac4j update pulls in slf4j API 2.0. Which breaks logging as logback 1.2 used by Play framework by default is not compatible with slf4j 2.0. Updating logback to 1.3 seems to just work. I tried it few months ago and there were still some issues. But not it looks ok. Things I tested:

Deployed civiform with updated logback and pac4j dependencies.
Logged in as admin to make sure that upated AdfsProfileAdapter works.
Ensured that logs are emitted and available in AWS console.

Release notes:
Update pac4j to 5.6.1 and logback to 1.3.4
Checklist

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[x] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
Fixes #3260

Codecov Report

Merging #3716 (ddb20ca) into main (042ae8f) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #3716   +/-   ##
=========================================
  Coverage     80.53%   80.53%
  Complexity     2431     2431
=========================================
  Files           295      295
  Lines          9619     9619
  Branches        658      657    -1
=========================================
  Hits           7747     7747
  Misses         1619     1619
  Partials        253      253

Impacted Files
Coverage Δ

server/app/auth/oidc/admin/AdfsProfileAdapter.java
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thank you for deploying and ensuring it works on AWS


Integrate 'organism'

OBI:0100026 organism was never in OBI scope but was required for various tasks. It's defined as equivalent to Viruses or Bacteria or Archaea or Eukaryota.
I think NCBITaxon:131567 cellular organism is more recent. Its three subclasses are Bacteria, Archaea, and Eukaryota -- Viruses are not included.
I know that @bpeters42 has some thoughts on this.

Definition is a bit circular but I think this does the trick: http://purl.obolibrary.org/obo/CARO_0001010
Note you need one more axiom to make things link up:
https://github.com/obophenotype/caro/issues/15

Yes, I would use the OBI term and change the logical definition to refer to
cellular organism +virus + viroid rather than the three subtypes (bacteria,
eukaryote, archae), exactly like in the CARO term Chris points to.
Question will be what the label should be. I am very much in favor of
keeping it as 'organism'. If this will upset too many people, We can switch
to something like 'generalized organism'.

Bjoern

On Fri, Sep 21, 2018 at 11:44 AM Chris Mungall<EMAIL_ADDRESS>wrote:

Definition is a bit circular but I think this does the trick:
http://purl.obolibrary.org/obo/CARO_0001010
Note you need one more axiom to make things link up:
obophenotype/caro#15 https://github.com/obophenotype/caro/issues/15
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-423635108,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANN9IvZv23WukRX5sPyUHqN73whVrfjAks5udTOOgaJpZM4W0ZAe
.

--
Bjoern Peters
Professor
La Jolla Institute for Allergy and Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters

+1 Bjoern

isn't OBI an odd place for this to live?
I'm 50-50 on name. On the one hand, we tend to err on the side of ugliness to prevent confusion. On the other, I especially don't like long union clauses. If the consensus is for short name then let's change it in CARO -- then would it make sense to import from CARO?

Note: need 'organism' to use in domain/range for biotic interaction relations in https://github.com/oborel/obo-relations/pull/261

No criticism intended, just looking for the best long term home.
NCBITaxon is a good choice, except thus far we have treated this as a direct syntactic transform. See the docs on http://obofoundry.org/ontology/ncbitaxon.html
On the one hand I'd like to do some additional processing, e.g. depluralizing terms, but that would be a big break from our process so far (maybe it's time). We have also strictly adhered to the numeric part of the URI corresponding to a numeric identifier in the source ncbi taxonomy database. It gets a bit odd if we start minting our own URIs with the NCBITaxon prefix. First we have to choose a number that is guaranteed not to clash ('0'? Random 10 digit number?). Even then it's a recipe for sowing confusion...

We could just ask ncbi to add a taxon node for organism, they are our chosen authority here.
The foreseeable objection is that this may seen as a commitment about phylogenetic relationship of viruses in relationship to cellular organisms

I would strongly prefer not to mint new ID using someone else's prefix - if we really need new terms and NCBI taxonomy doesn't want to add them then the only compromise I can think of is adding them in the NCBITaxon file but with another prefix (something like OBOTaxon or else) so they'd be available but clearly not created/supported by NCBI.
I like the idea of asking NCBI to add an organism that includes cellular organisms + virus + viroid - should we try that and advise if they're reluctant? @cmungall do you know the right person to ask?

Perhaps NCBITaxon:1 ("root") would somewhat fit for the ID? True, the ontology does include non-organism things outside the scope of what we're looking for (such as plasmids), but since that's already the case maybe we can let it slide? Or, if additional processing is going to happen anyway, such terms can be removed.

@mcourtot "I like the idea of asking NCBI to add an organism that includes cellular organisms + virus + viroid".
I like this idea too. One more question, in this case, shall we deprecated OBI: organism?

Can we please stick to one task at a time? I don't want the core work to
depend on getting NCBI taxonomy folks to create something (they have not
been responsive in the past). We have a perfectly fine term in OBI that is
in wide use. We should request an equivalent term from the NCBI taxonomy,
and make an editor note on the OBI term. If that gets made, yes, we should
obsolete the OBI term, but we should not wait on any of this to happen
right now.
On Wed, Sep 26, 2018 at 10:49 AM jie zheng<EMAIL_ADDRESS>wrote:

@mcourtot https://github.com/mcourtot "I like the idea of asking NCBI
to add an organism that includes cellular organisms + virus + viroid".
I like this idea too. One more question, in this case, shall we deprecated
OBI: organism?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-424743778,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANN9ImSqdZ7yRN-yalgoMPTr_Q7A6npLks5ue5P3gaJpZM4W0ZAe
.

--
Bjoern Peters
Professor
La Jolla Institute for Allergy and Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters

Proposal is

use the OBI term and change the logical definition to refer to cellular organism +virus + viroid. Add editor note on OBI term with details of the request in 2. We will keep 'organism' label for now.
request new organism term from NCBI - when/if created advise about deprecating the OBI term

+1
From: Melanie Courtot<EMAIL_ADDRESS>Reply-To: OBOFoundry/Experimental-OBO-Core<EMAIL_ADDRESS>Date: Thursday, September 27, 2018 at 11:42 AM
To: OBOFoundry/Experimental-OBO-Core<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [OBOFoundry/Experimental-OBO-Core] Integrate 'organism' (#6)
Proposal is

use the OBI term and change the logical definition to refer to cellular organism +virus + viroid. Add editor note on OBI term with details of the request in 2. We will keep 'organism' label for now.
request new organism term from NCBI - when/if created advise about deprecating the OBI term

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-425140577, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIt7LcdlFgR9qnEDHYY3Dv4G29NuBqrMks5ufPEkgaJpZM4W0ZAe.

+1 Melanie's proposal

Alternate proposal

use the CARO class but relabel to 'organism'
request new organism term from NCBI - when/if created advise about deprecating the CARO term

This just seems to make sense. organisms are anatomical entities, CARO is an upper-level anatomical entity ontology with root class 'anatomical entity'. OBI is an ontology of biomedical investigations, organisms exist independent of biomedical investigations. Full credit to OBI for providing the term since 2009 but we need to move forwards with a more sensible modularization strategy.
Another issue is that the OBI class explicitly makes no commitment to start/end, and explicitly says this is out of scope; the editor note says "10/21/09: This is a placeholder term, that should ideally be imported from the NCBI taxonomy, but the high level hierarchy there does not suit our needs (includes plasmids and 'other organisms'), 13-02-2009: OBI doesn't take position as to when an organism starts or ends being an organism - e.g. sperm, foetus. This issue is outside the scope of OBI." - for anatomy ontology use cases there needs to be ontological commitment.

 And I strongly doubt
that there is consensus that organisms are a kind of anatomical entities.
Try to propose it as a parent to ncbi... but i will once again say ok to
this so that we can move on.
On Thu, Sep 27, 2018, 5:32 PM Chris Mungall<EMAIL_ADDRESS>wrote:

Alternate proposal

use the CARO class but relabel to 'organism'
request new organism term from NCBI - when/if created advise about
deprecating the CARO term

This just seems to make sense. organisms are anatomical entities, CARO is
an upper-level anatomical entity ontology with root class 'anatomical
entity'. OBI is an ontology of biomedical investigations, organisms exist
independent of biomedical investigations. Full credit to OBI for providing
the term since 2009 but we need to move forwards with a more sensible
modularization strategy.
Another issue is that the OBI class explicitly makes no commitment to
start/end, and explicitly says this is out of scope; the editor note says "10/21/09:
This is a placeholder term, that should ideally be imported from the NCBI
taxonomy, but the high level hierarchy there does not suit our needs
(includes plasmids and 'other organisms'), 13-02-2009: OBI doesn't take
position as to when an organism starts or ends being an organism - e.g.
sperm, foetus. This issue is outside the scope of OBI." - for anatomy
ontology use cases there needs to be ontological commitment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-425250101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANN9Igkp2WLIdh5U4evdbEsSt7OkaqTlks5ufUP0gaJpZM4W0ZAe
.

It looks like the next RO release is pushing for the CARO class to be the new 'organism'. As I said, I will no longer object to it. But then I would very much want to change that class to make it not less embarrassing
Currently:
label: "organism or virus or viroid".
definition: "Material anatomical entity that is a member of an individual species or is a viral or viroid particle."
Problems:

Label refers to 'organism or' without organism being defined anywhere. Minimally it should be "cellular organism or virus or viroid". Better yet: "generalized organism" Best: "organism"

Definition is inconsistent, which is just not apparent because there is a lack of logical constraints in CARO. 'material anatomical entity' is defined as being a kind of 'anatomical entity' which is part of a 'multicellular organism'. So clearly this class which covers non-multicellular organisms cannot be a kind of 'anatomical entity'. Parent should be 'material entity' entity instead.

reference to 'member of species' when species isn't defined buys us anything. And there species for viruses just as well as for cellular organism, so that doesn't help either.

Suggestion: Replace with the imperfect elucidation in OBI, dropping the 'living' part to stop the virus haters: "A material entity such as an animal, plant, bacteria or virus or viroid, that is capable of replicating or reproducing, growth and maintenance in the right environment."

Most definitions of organism do not include viruses and viroids. There is of course a whole body of literature arguing about how to define organism. I don't think we should spend a lot more time on this - an enormous effort was spent during the creation of these terms in CARO and other ontologies already and many decades more generally ;-).
I don't think this presence of this class/class label is a matter of being a virus hater. We do need a union class, and this is reason it was created, quite the opposite of being a virus hater.
I don't think 'organism' by itself as a label works as most organismal biologists use this term in exclusion of viruses and viroids and are very likely to use it incorrectly. I don't love 'generalized organism' but would be ok with that given that it is at least a flag that it might mean something more than simply 'organism'.  I am also fine with keeping the union label.
Agree we should have definitions for organism, species.
Agree the text definition of 'anatomical entity' is not consistent with the intent, we can readily fix this. An 'anatomical entity' should be part of a 'cellular organism'. Most anatomists would likely argue that viral parts are not anatomical entities, though this poses less of an issue for misuse than the organism one above. Will make a ticket.
There are many 'organism' classes in the obo library, we should indeed clean them up, they all mean slightly different things in different ontologies: http://www.ontobee.org/search?ontology=&keywords=organism&submit=Search+terms
What is the current QA/clean up process for potential duplicate entities across OBO? We will be happy to help reconcile but would like to do so using standard process or otherwise help make a standard process.

Just to add general noise and confusion, my position is at odds with everyone... but I have extreme confidence we are converging.
I like names used by scientists. I may be in the minority but I favor using "organism" in the broad sense to include viruses.
I am against both boolean names and adjectives like "generalized" or the elsewhere proposed extended organism. I slightly prefer the boolean name (though I really dislike boolean names or disjunctive OWL definitions) as a non-ontologist can intuit the meaning, whereas "generalized" is too much like ontologese (and doesn't really work on the instance level).
Using organism inclusively is simple, intuitive, and reflects a general conceptual unity amongst its subclasses. I don't see a major risk in curator misuse, there is some risk in that scientists who use the term more restrictedly might attack us for this... but show me an area where this isn't the case. I don't think there is an upper level term in any ontology I work on that isn't controversial. We can of course include obo foundry unique labels, usage notes, logical axioms, and synonyms as well of course.
Both OBI and CARO terms are the product of excellent yet poorly rewarded work by multiple expert people volunteering time. Nevertheless we have to test this work against other communities and be open to revisiting things. On the CARO side, I know we started with a very FMA/BFO philosophy mandate and have gradually moved more towards a more humane ontology, and we should be open to further evolution in that direction.
I think there will also be some shuffling of classes around as part of COREification, and we should have modularity in mind rather than ownership.
Re: definition. I am happy to go with either CARO's clade-based definitions or with OBI's direct definition. However, for the clade-based definitions, there need to be some PURLs for the clade individuals themselves. And then we still have to define those PURLs. On balance it seems simpler to define directly.
I like Bjoern's definition. I mildly prefer moving "such as" clauses to definition gloss (and making it stronger: explicitly stating membership). But currently there is nothing in it that firmly excludes either transposons and possibly even somatic cells. I would like to see "genome" in the definition (although this puts us at risk of circularity (and will need exception clauses for chimeras etc)).

FWIW:
  is_a GO:0051704 ! multi-organism process
   is_a GO:0044419 ! interspecies interaction between organisms
    is_a GO:0044403 ! symbiosis, encompassing mutualism through parasitism
     is_a GO:0016032 ! viral process ***

Ok, lots to think about!
Please everyone, we all have put in a lot of volunteer time and it is exactly the goal of OBO to bring together diverse perspectives into a unified view of biology. No one "owns" content, and it is a basic premise of OBO that one is open to evolution of content to support conceptual alignment. I do think the community is not well tracking all of this hard work though, if one is not attending the RO meeting its a bit opaque - just as an aside it would be good to write an update soon to obo-discuss. You might get more helpers that way too (for example I would be happy to compare and contrast any of the organism/anatomy related duplicates to try to come up with consensus and best placement).
Regarding the above.
I too like the names used by scientists. That is why I don't like the use of 'organism' to mean things that most biologists don't consider organisms ;-). TBH the fact that biologists have not really converged on a label for the union class is very likely why NCBI taxon never had it either. We CAN change this now, but how to do so without confusing or offending? Sometimes labels do need to evolve. What we think of now as a gene is not the same as when that term was originally coined. I don't love 'generalized organism' either but at least is is a flag that it means something different the generally assumed definition of organism. I guess I am willing to be overridden, but lets please better understand consequences if we do want to do that as we are just one small community and we will not change a large community of biologists' mind about such things with one OBO label. Perhaps a poll? Would be good to ask NCBI, EOL and other phylogenetic groups what sorts of requests and suggestions they have gotten.
I like Bjoern's definition too, edits in response to Chris' comments:
"A material entity that is prokaryote (e.g. bacteria, archaea), eukaroyte (e.g. animal, plant, fungus), virus, or viroid and is capable of replicating or reproducing in the right environment, and that includes genetic information encoded in nucleic acids to do so."
Not sure about how to include genome.
I would disagree with the GO hierarchy.... In my mind not all viral processes are 'interspecies interaction between organisms' nor 'symbiosis, encompassing mutualism through parasitism'.

I like Melissa's edited definition. I think 'genetic information encoded in
nucleic acids to do so' captures what 'genome' would entail without
becoming circular.
Regarding label I also had as my first choice 'organism' which in my part
of biological (immunology, virology) would be accepted by most to include
viruses.  I am fine with the two other labels as well ('generalized
organism' or 'cellular organism, virus or viroid'). We can totally do a
vote, and include the other two as alternative labels.
On Sun, Oct 21, 2018 at 12:34 PM Melissa Haendel<EMAIL_ADDRESS>wrote:

Ok, lots to think about!
Please everyone, we all have put in a lot of volunteer time and it is
exactly the goal of OBO to bring together diverse perspectives into a
unified view of biology. No one "owns" content, and it is a basic premise
of OBO that one is open to evolution of content to support conceptual
alignment. I do think the community is not well tracking all of this hard
work though, if one is not attending the RO meeting its a bit opaque - just
as an aside it would be good to write an update soon to obo-discuss. You
might get more helpers that way too (for example I would be happy to
compare and contrast any of the organism/anatomy related duplicates to try
to come up with consensus and best placement).
Regarding the above.
I too like the names used by scientists. That is why I don't like the use
of 'organism' to mean things that most biologists don't consider organisms
;-). TBH the fact that biologists have not really converged on a label for
the union class is very likely why NCBI taxon never had it either. We CAN
change this now, but how to do so without confusing or offending? Sometimes
labels do need to evolve. What we think of now as a gene is not the same as
when that term was originally coined. I don't love 'generalized organism'
either but at least is is a flag that it means something different the
generally assumed definition of organism. I guess I am willing to be
overridden, but lets please better understand consequences if we do want to
do that as we are just one small community and we will not change a large
community of biologists' mind about such things with one OBO label. Perhaps
a poll? Would be good to ask NCBI, EOL and other phylogenetic groups what
sorts of requests and suggestions they have gotten.
I like Bjoern's definition too, edits in response to Chris' comments:
"A material entity that is prokaryote (e.g. bacteria, archaea), eukaroyte
(e.g. animal, plant, fungus), virus, or viroid and is capable of
replicating or reproducing in the right environment, and that includes
genetic information encoded in nucleic acids to do so."
Not sure about how to include genome.
I would disagree with the GO hierarchy.... In my mind not all viral
processes are 'interspecies interaction between organisms' nor 'symbiosis,
encompassing mutualism through parasitism'.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-431697226,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANN9Ih7KI-AMT9ur6Sw6PcbwM1Co7TFbks5unMw2gaJpZM4W0ZAe
.

--
Bjoern Peters
Professor
La Jolla Institute for Allergy and Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters

Also, (cellular) organism is viewed by anatomists as the root of the anatomical partonomy, so is by definition an anatomical entity (though most anatomists don't use the word entity, thats more of an ontological term).

I would think anatomists restrict themselves to multi-cellular organisms?
On Sun, Oct 21, 2018 at 1:45 PM Melissa Haendel<EMAIL_ADDRESS>wrote:

Also, (cellular) organism is viewed by anatomists as the root of the
anatomical partonomy, so is by definition an anatomical entity (though most
anatomists don't use the word entity, thats more of an ontological term).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-431702530,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANN9Ik9T8tTsz_aZBX3IeYm5Pfs25jzfks5unNz0gaJpZM4W0ZAe
.

--
Bjoern Peters
Professor
La Jolla Institute for Allergy and Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters

There are cellular anatomists, though they largely fall into studies of single-cell or multi-cellular eukaryotes (and not prokaryotes). GO Cellular Component is considered anatomy and therefore has an equivalency axiom in CARO, for example.

'Anatomy' is used in all kinds of contexts, including the 'anatomy of a
relationship' and the like. There is plenty of 'viral anatomy' out there. I
thought you were using 'anatomy' here as shorthand for the type of stuff
that would be covered in a class taught in medical school, or what is part
of the anatomy ontologies in the OBO foundry. All of which is
multi-cellular organisms.
Our goal is to have an intuitive upper level hierarchy. If I am looking for
where to find e.g. MHC molecules, I would look under molecules / molecular
complexes or the like, not under 'anatomical entity'.

Bjoern

On Sun, Oct 21, 2018 at 1:55 PM Melissa Haendel<EMAIL_ADDRESS>wrote:

There are cellular anatomists, though they largely fall into studies of
single-cell or multi-cellular eukaryotes (and not prokaryotes). GO Cellular
Component is considered anatomy and therefore has an equivalency axiom in
CARO, for example.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-431703124,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANN9IkhR_AmVYRDd9KH2cTb7B3LSymQ4ks5unN8kgaJpZM4W0ZAe
.

--
Bjoern Peters
Professor
La Jolla Institute for Allergy and Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters

@bpeters42 was just thinking of cellular anatomy - cellular structure and physiology. Things like mitochondria and lysosomes are in GO and are considered cellular anatomy, taught in med school anatomy classes, etc. I don't think most anatomists would consider proteins as anatomy, though obviously there are anatomical structures such as gap junctions that are largely protein complexes and there is a fuzzy line there. We do have the 'gross anatomical part' class to address this issue that was requested by OBI, we can revisit this class too. CARO as an anatomical reference ontology does intend to provide upper level axioms for cellular anatomy of any cell.

if GO:cellular component is anatomy, then NFKB is anatomy.
This whole discussion was started by me objecting to 'organism or virus
or viroid' being defined as a type of anatomical entity. I am not clear if
your point is that you want to add 'anatomical entity' back into the
definition of the organism class? I believe / hope that you were just
making general points? If so, let's take them of this tracker item, so that
we can hopefully close it soon.

On Mon, Oct 22, 2018 at 8:38 AM Melissa Haendel<EMAIL_ADDRESS>wrote:

@bpeters42 https://github.com/bpeters42 was just thinking of cellular
anatomy - cellular structure and physiology. Things like mitochondria and
lysosomes are in GO and are considered cellular anatomy, taught in med
school anatomy classes, etc. I don't think most anatomists would consider
proteins as anatomy, though obviously there are anatomical structures such
as gap junctions that are largely protein complexes and there is a fuzzy
line there. We do have the 'gross anatomical part' class to address this
issue that was requested by OBI, we can revisit this class too. CARO as an
anatomical reference ontology does intend to provide upper level axioms for
cellular anatomy of any cell.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-431871935,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANN9IjNEX59-qobyQxgv1_4MOWDXtqcMks5uneZvgaJpZM4W0ZAe
.

--
Bjoern Peters
Professor
La Jolla Institute for Allergy and Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters

PR to relabel organism in CARO: https://github.com/obophenotype/caro/pull/17

Some discussion on organism in OBI, not sure how relevant: https://github.com/obi-ontology/obi/issues/994

The  : obi-ontology/obi#994
https://github.com/obi-ontology/obi/issues/994 discussion
ended up being more about reasoning / display issues rather than modeling
issues.
Thanks for the CARO pull request to relabel organism (obophenotype/caro#17
https://github.com/obophenotype/caro/pull/17). Beyond the relabeling,
were you also planning to update the definition to what was discussed in
this thread? The last iteration from Melissa, for which there were no
specific objections was: "A material entity that is prokaryote (e.g.
bacteria, archaea), eukaroyte (e.g. animal, plant, fungus), virus, or
viroid and is capable of replicating or reproducing in the right
environment, and that includes genetic information encoded in nucleic acids
to do so."
If all that is in, I am fine with retiring the OBI term in favor of the
CARO term, but of course this is not just up to me. The other alternative
being if we migrate it to a common OBO-Core namespace (did we settle on a
replacement for 'core'?)
Talk to you tomorrow
On Mon, Feb 11, 2019 at 5:21 PM Chris Mungall<EMAIL_ADDRESS>wrote:

Some discussion on organism in OBI, not sure how relevant:
obi-ontology/obi#994 https://github.com/obi-ontology/obi/issues/994
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-462571454,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANN9Ijy6c5uugQHMbLqTCRbqiqeLVB4yks5vMhb_gaJpZM4W0ZAe
.

--
Bjoern Peters
Professor
La Jolla Institute for Allergy and Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters

Yep, I will update the definition in the PR
On Mon, Feb 11, 2019 at 9:58 PM bpeters42<EMAIL_ADDRESS>wrote:

The : obi-ontology/obi#994
https://github.com/obi-ontology/obi/issues/994 discussion
ended up being more about reasoning / display issues rather than modeling
issues.
Thanks for the CARO pull request to relabel organism (obophenotype/caro#17
https://github.com/obophenotype/caro/pull/17). Beyond the relabeling,
were you also planning to update the definition to what was discussed in
this thread? The last iteration from Melissa, for which there were no
specific objections was: "A material entity that is prokaryote (e.g.
bacteria, archaea), eukaroyte (e.g. animal, plant, fungus), virus, or
viroid and is capable of replicating or reproducing in the right
environment, and that includes genetic information encoded in nucleic acids
to do so."
If all that is in, I am fine with retiring the OBI term in favor of the
CARO term, but of course this is not just up to me. The other alternative
being if we migrate it to a common OBO-Core namespace (did we settle on a
replacement for 'core'?)
Talk to you tomorrow
On Mon, Feb 11, 2019 at 5:21 PM Chris Mungall<EMAIL_ADDRESS>wrote:

Some discussion on organism in OBI, not sure how relevant:
obi-ontology/obi#994 https://github.com/obi-ontology/obi/issues/994
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-462571454
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ANN9Ijy6c5uugQHMbLqTCRbqiqeLVB4yks5vMhb_gaJpZM4W0ZAe
.

--
Bjoern Peters
Professor
La Jolla Institute for Allergy and Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OBOFoundry/Experimental-OBO-Core/issues/6#issuecomment-462627234,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADGOVmKHJDDSiiEFOeUQOT-1MJF6t7kks5vMlf3gaJpZM4W0ZAe
.

We have created an 'organism' term with a unique ID, but we are discussing mapping equivalent external terms in #23.


this proxy app can be used as a http proxy?

hi.
this proxy app can be used as a http proxy?
tks

Hey, it was not designed to be an navigation proxy.


WPF: Grid.Worksheets.Insert does not update tab control with changes

Perhaps I am simply not understanding how the control should work, but I assume that inserting a new worksheet into the workbook would result in the adding of the sheet at a particular index. However, what it actually does is overwrite the contents of the existing worksheet at the specified index position.
Example:
myGrid = new ReoGridControl();
myGrid.Worksheets[0].SetCellData(0, 0, "Sheet1");
myGrid.NewWorkSheet();
myGrid.Worksheets[1].SetCellData(0, 0, "Sheet2");
myGrid.NewWorkSheet();
myGrid.Worksheets[2].SetCellData(0, 0, "Sheet3");
var insertSheet = myGrid.CreateWorksheet("Insert1");
insertSheet.SetCellData(0, 0, "Insert1");
myGrid.Worksheets.Insert(0, insertSheet);
When you run the application, "Sheet3" has been overwritten by sheet "Insert1":

Note. I had to use four sheets to demonstrate because of a bug that I will report separately. If you use three sheets or less, the tabs do not show all sheets.

May related #171


Making content of about page to look good in mobile view

Contents of the about us page is not looking good in mobile view and it should look same as the home page.

/assign


Can't seem to get it to work

I followed the "zinit without zinit-annex-bin-gem-node" instructions and the script runs by itself but I can't seem to get it actually process a file correctly:
zsweep --auto zsh/get-icon-for-command.zsh
[ZSweep][zs::get-prj-dir:46]: Warning: didn't find any main poject dir uptree, was looking for: ·.git, ·TAGS, ·tags, ·CMakeLists.txt, ·configure

[ZSweep][zsweep:65]: Notice: scanning file: •ZSH/GET-ICON-FOR-COMMAND.ZSH•…

[ZSweep][zs::get-prj-dir:46]: Warning: didn't find any main poject dir uptree, was looking for: ·.git, ·TAGS, ·tags, ·CMakeLists.txt, ·configure
[ZSweep][zs::read-file:20]: Error: no input file given
[ZSweep][zsweep:75]: Warning: returning non-zero exit code
[ZSweep][zsweep:76]: Warning: the 1/1 failed files are:
·zsh/get-icon-for-command.zsh

I'm running that script from ~/dotfiles which is a git repo. I traced through that problem and the if at functions/util/zs::get-prj-dir:32 evaluates as true but I don't understand why. This is what set -x shows for that comparison:
[[ /Users/cam/dotfiles/.git == ([[:cntrl:][:space:][:INCOMPLETE:][:INVALID:]]#|*[[:INCOMPLETE:][:INVALID:]]*|[[:cntrl:]]#|0#|[^[:print:][:alnum:]]#) ]]

None of that explains the [ZSweep][zs::read-file:20]: Error: no input file given error.
Any idea what might be going on?
I'm interested to see if it would be possible to get zsweep set up as a zsh linter in nvim via nvim-lint / mason. But I have to get it working first :) Any help much appreciated!

Did a little more digging and this is the comparison in zs::read-file that's evaluating as true even thought it doesn't seem like it should (line numbers off by one from GH src because i added a set -x line):
+util/zs::read-file:20> [[ /Users/cam/dotfiles/zsh/get-icon-for-command.zsh == ([[:cntrl:][:space:][:INCOMPLETE:][:INVALID:]]#|*[[:INCOMPLETE:][:INVALID:]]*|[[:cntrl:]]#|0#|[^[:print:][:alnum:]]#) ]]
+util/zs::read-file:21> zsmsg_ zs::read-file:21 -h '{err}Error:{txt}' no input file given


Connecting donate button #417

I have connected the donate button which was earlier not working with Doantion.html page

Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


yaml: Rename StarterKit-based machines

Rename h3ulcb-kf-4x2g to h3ulcb-4x2g-kf.
Rename h3ulcb-ab-4x2g to h3ulcb-4x2g-ab.
This is done to comply with already used naming and to reflect
that -kf and -ab are based on h3ulcb-4x2g machine.
Signed-off-by: Ruslan Shymkevych<EMAIL_ADDRESS>

Tested by
 moulin ~/projects/meta-xt-prod-devel-rcar/prod-devel-rcar.yaml --MACHINE h3ulcb-4x2g-kf

with the following build of domd

Reviewer is added.
PR is ready to be merged.


Can this skip caching the header

Can this module skip caching specific components like the header which loads the user?

I think you can use  Nuxt components for this trick :)
Just wrap header in client-only components and it renders on client side.


Add fragmentation feature

Linked PR: #1

I have rebase the main merged with missing manuscript feature branch into fragmentation. Hence, the branch is open to a complete review.


Assume unresolved packaging variables in a POM mean jar

Maven ignores the declared packaging and assumes jar unless told otherwise.
Gradle attempts to resolve a dependency's artifact based on its packaging.
In the past, we would have attempted to resolve an artifact with the extension ${packaging.type} and, failing that, tried jar.
Now, when we detect that the packaging isn't something valid, we immediately default to jar in our internal representation of the POM.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


Why don't you remove popup's max-height?

https://github.com/Heroor/md-reader/blob/764de06f9d08440ea5f66797a31436b4dc69224d/src/popup/components/app.svelte#L143

In 中文,
It looks good to me.

But in the other languages sidebar still appear.

So, why don't you remove popup's max-height?

Oh, I didn't find this problem, It works fine on my computer:

In the past, the content of the pop-up window was very small, only when the warning message was displayed, it would be too long. I hope it can be simple, so I add the max-height. Now it has too much content and can be removed
But the pop-up window still has a default maximum height:

I got it, I think this issue is due to the display environment.
Or It might be because our operating system is different.
How about using rem unit?
when I had max-height set 33rem, It show better

The default maximum height of the window is 600px, but if I set 600px, two scroll bars will appear. I set 599px to work, so that can keep the border design and fit as much content as possible.

Okay! Thank you for help!


Super Admin proposed change

Hello, I'd like to propose a change in the purple note section where it says "A global administrator or super admin (an admin for all authorization system types)"
Instead of "super admin", would it be possible to remove it as there is no "super admin" concept in Azure and it might confuse customers to understand where the "super admin" come from.
Hope this makes sense and please reach out to MSFT alias "veraviriya" if you have any questions related to this change.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7760b63d-e8bd-bdc1-4411-f2febe387f66
Version Independent ID: 4c9549d3-791e-a563-8ef3-fa2f3487622c
Content: Onboard a Microsoft Azure subscription in Permissions Management - Microsoft Entra
Content Source: articles/active-directory/cloud-infrastructure-entitlement-management/onboard-azure.md
Service: active-directory
Sub-service: ciem
GitHub Login: @jenniferf-skc
Microsoft Alias: jfields

@vrviriya
Thanks for your feedback! We will investigate and update as appropriate.

@vrviriya
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Add patch for WebmMuxer

@see #253
@see  https://codereview.chromium.org/2617143003
Thanks.

The patch provided does not appear to apply cleanly to Chrome 53.0.2785.143
The error when running script/update on this branch:
source file is different - media/muxers/webm_muxer.cc
webm_muxer_fix.patch failed to apply

How is that possible? I specifically checked out that tag and applied patch with git apply and worked fine.
MacRamboPro:chromium-53 demian$ git log
commit 12ae4ebf489873fc4aad9efc231b9151b330a938
Author: chrome-cron<EMAIL_ADDRESS>Date:   Sun Sep 25 01:36:29 2016 +0000

    Publish DEPS for Chromium 53.0.2785.143
MacRamboPro:chromium-53 demian$ git tag -l
53.0.2785.143

What should I do? Is that commit the correct one?

How is that possible? I specifically checked out that tag and applied patch with git apply and worked fine.
I think the patch library uses to apply them in libchromiumcontent has stricter SHA checks.
So if you apply the patch to a 53.0.2785.143 checkout using git apply and then run git diff, you'll see the updated patch.
Here is it for:
diff --git a/media/muxers/webm_muxer.cc b/media/muxers/webm_muxer.cc
index 0633baf..c134f77 100644
--- a/media/muxers/webm_muxer.cc
+++ b/media/muxers/webm_muxer.cc
@@ -234,8 +234,6 @@ void WebmMuxer::AddVideoTrack(const gfx::Size& frame_size, double frame_rate) {
   DCHECK_EQ(0ull, video_track->crop_bottom());
   DCHECK_EQ(0.0f, video_track->frame_rate());

-  video_track->set_default_duration(base::Time::kNanosecondsPerSecond /
-                                    frame_rate);
   // Segment's timestamps should be in milliseconds, DCHECK it. See
   // http://www.webmproject.org/docs/container/#muxer-guidelines
   DCHECK_EQ(1000000ull, segment_.GetSegmentInfo()->timecode_scale());

So, updated patch. Does it work now?

Thanks for this 👍

@demian85 this was released in Electron 1.4.15


Add supplier/license info for cargo and pip

Requires #476 to be merged for it's changes in ServiceCollectionExtensions as well as v4.0.12 of component-detection to be released
Edit: all requirements have been met.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b89529d) 59.73% compared to head (cc8a2c3) 59.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
+ Coverage   59.73%   59.77%   +0.03%
==========================================
  Files         248      248
  Lines        7572     7579       +7
  Branches      901      902       +1
==========================================
+ Hits         4523     4530       +7
  Misses       2637     2637
  Partials      412      412

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[biobiotv] Add new extractor

Adds a new extractor for BioBioTV.

@GiedriusS Thanks for the suggestion!
I've made the changes that you suggest and the tests are passing. It's been some time, though, and now there seems to be a conflict in __init__.py. I can rebase and submit a new pull request if that helps.

Is there any other reason this has not / will not be merged?
I see that this branch now has conflicts. Should I rebase and issue a new PR?

Does not work with http://tv.biobiochile.cl/notas/2016/03/18/natalia-valdebenito-repasa-a-diputado-hasbun-paso-a-la-categoria-de-hablar-brutalidades.shtml.

Oh, I actually just pushed my own changes to fix this, but it's good to see it merged.
Thanks!

Cherry-picked in e36f4aa72b01b3f6a322edc094cdf1c20b071367, thanks.


Can't find X360 controller

I compiled it and installed the udev rules and I have 01-switch-pro.cfg, 11-ds3-standard.cfg, 11-sony-standard.cfg, 11-xpad.cfg, 14-mayflash-ps2.cfg in .config/moltengamepad/gendevices.
It works for my DS4 (Edit: and DS3 after putting in the correct cfg) but not my Xbox 360 controller. Am I missing something?
Here's my log:
/moltengamepad --mimic-xpad --rumble
No moltengamepad.cfg found.
driver: wiimote driver initialized.
driver: switch-pro driver initialized.
driver: dualshock3 driver initialized.
driver: sony driver initialized.
driver: xpad driver initialized.
driver: mayflash-ps2 driver initialized.
device grab: changing permissions of /dev/input/event5
device hiding: changing permissions of /dev/input/js0
plug: ds3_1 added
open subdevice:: Permission denied
open subdevice:: Permission denied
stdin: ready to read commands from standard input. Try "help" for more info.
slot: ds3_1 assigned to slot virtpad1
open subdevice:: Permission denied
open subdevice:: Permission denied
device grab: changing permissions of /dev/input/event23
device hiding: changing permissions of /dev/input/js5
plug: ps_1 added
slot: ps_1 assigned to slot virtpad2

specs (copied from neofetch):
OS: Ubuntu 20.04.1 LTS x86_64
Host: XPS 8300
Kernel: 5.4.0-45-generic
Uptime: 1 hour, 54 mins
Packages: 2114 (dpkg)
Shell: bash 5.0.17
Resolution: 1920x1080
DE: Xfce
WM: Xfwm4
WM Theme: Default
Theme: Greybird [GTK2/3]
Icons: elementary-xfce-darker [GTK2/3]
Terminal: xfce4-terminal
Terminal Font: Monospace 12
CPU: Intel i7-2600 (8) @ 3.800GHz
GPU: AMD ATI Radeon HD 5770
Memory: 1590MiB / 7943MiB

could you share your .cfg files? I too have

pro controllers
dual shock 3
xbox sx
and like to compare how you've set them up