Kodi Library cleanup triggering GetMatchingSource: no matching source when using library integration

Kodi & OS

Kodi version: 16.1
OS version: Ubuntu 14.04.1 LTS - KODIbuntu

Addon / Wtyczka

[ ] Filmy online - Mrknow
[ ] MrknowTV
[X] Specto
[ ] FanFILM
Version / Wersja: 2<IP_ADDRESS>

Issue / Zgłoszenie

[X] Bug report / Błąd
[ ] Site request / Prośba o nową stronę
[ ] Feature request / Prośba o nową funkcję
[ ] Question / Pytanie
[ ] Other / Inne

Descryption / Opis
Before everything else I'm very grateful that you are developping this addon. It is by far the most superior streaming addon for kodi right now.
As for my problem, I'm now using the library integration feature. I've configured the TvShow folder for scanning with the TVDB feature and as a test I decided to add the Vikings series. My Kodi system however is configured to perform regular library updates and cleanups. No issue with the updating but when I perform a library cleanup Kodi doesn't seem to recognize specto streaming sources and asks me everytime if I want to remove the source from the library.
Here's the relevant log excerpt:
[...]
18:33:34 T:140472207759360   DEBUG: CUtil::GetMatchingSource: no matching source found for [special://userdata/addon_data/plugin.video.specto/TVShows/Vikings (2013)/Season 4/Vikings (2013) S04E16.strm]
18:33:34 T:140472207759360   DEBUG: CUtil::GetMatchingSource: no matching source found for [special://userdata/addon_data/plugin.video.specto/TVShows/Vikings (2013)/Season 4/Vikings (2013) S04E17.strm]
18:33:34 T:140472207759360   DEBUG: CUtil::GetMatchingSource: no matching source found for [special://userdata/addon_data/plugin.video.specto/TVShows/Vikings (2013)/Season 4/Vikings (2013) S04E18.strm]
18:33:34 T:140472207759360   DEBUG: CUtil::GetMatchingSource: no matching source found for [special://userdata/addon_data/plugin.video.specto/TVShows/]
[...]
Is this a bug? Is there any way I can make Kodi ignore Specto's sources? Is there a patch I can make in the addon?
I've included the full log for the entire cleanup operation.
Thank you very much for your attention on this issue and keep up the good work!
kodi-log.txt

I forgot to mention, that this wouldn't be a problem per se, but because of this Kodi asks if the Specto library folder is to be removed from the library or kept each time the library is cleaned.

You can "whitelist" the strm file extension.
This can be done through advancedsettings.xml
<videoextensions>   <add>.strm</add> </videoextensions>
Or you can use a plugin "Easy advanced settings" to create (if not present) or edit your advancedsettings.xml in kodi itself


Update jarvis.py

Added location support
Added birthday support

This is a good addition; thanks for the contribution @krishnathakar1! :sparkles:

Thank you so much!
https://github.com/marwahmanbir/JARVIS/pull/2#issuecomment-712137619
On Mon, 19 Oct 2020 at 18:06, Manbir Singh Marwah<EMAIL_ADDRESS>wrote:

This is a good addition; thanks for the contribution @krishnathakar1
https://github.com/krishnathakar1! ✨
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/marwahmanbir/JARVIS/pull/1#issuecomment-712126708,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP4TEMEUWO4JCOZGNOAK4EDSLQXETANCNFSM4SVXQ3QQ
.


Fix the copy constructor

As credentialsId is @DataBoundSetter, it isn't part of the constructor, so it must be copied separately.
@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

:bee:

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

:bee

@reviewbybees done

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.


LiveServer not opening on Mac

I'm submitting a...Bug

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Other: <!-- Please describe: -->

.html opens when not in a folder and only opens when in the root folder. ## Current behavior
LiveServer is not opening if filename has spaces on Mac
For file to open when using LiveServer## Expected behavior
For .html to open in from a folder that has spaces.
Environment
Browser:

- [ x] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:

v5.6.1 - Live Server: <!-- Check which version is installed -->
Mac OS Big Sur V: 11.4 - Platform:  <!-- Mac, Linux, Windows -->
Version: 1.59.0 - Visual Studio Code: <!-- `code --version` -->

Others

Open up your Terminal and run the following command: sudo spctl --reset-default and then restart your Mac.


fix(create-injection-token): better decide when to use factory or provided value (#161)

This PR fixes #161

@all-contributors please add @diegovilar for code


 This helped in my case.
For reviewers: I would appreciate if you could test Build.ps1 at least.

Good to hear! When we finish this, we should then finish that CI-fix (I try to do it when I have time) so we can actually release new versions. :D


Release on PyPI

Distribution for users would be easier if they could pip install intensio or similar.
An example package using setuptools to package for PyPI can be viewed here: https://github.com/johnthagen/python-blueprint#packaging

hi,
Thank you for your suggestion, I will study this.

Some more information here as well: https://packaging.python.org/tutorials/packaging-projects/

Hi, I see this issue is set suggestion, when would you upload this project to PyPI? It's very easier way to use.

hi,
I upload this project to PyPI platform.


feat: uses can overwrite def-0 logic

Supersedes #4
Refs:

https://github.com/fastify/fastify-swagger/issues/337
https://github.com/fastify/fastify-swagger/issues/286
https://github.com/fastify/fastify-swagger/issues/225
https://github.com/fastify/fastify-swagger/pull/432

TODO

[x] Testing withing fastify-swagger

@Eomm why don't you use the $id property if exists?

Because the $id is not an id as in relational database. It is a uri that must be resolved against other $ids.
So what the use need is a simple map id - value, but the spec doesn't define it like this


Updated List of Restricted Entities

I have raised this Microsoft online Support (Dynamics 365 Team).
They have confirmed that the Restricted Entities above have been updated as per the latest release notes. Although the notice at the top of the page, stating that the document is out of date has not been removed yet in error.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5ecf0cd5-9a4c-780a-7cc9-c189d399efa5
Version Independent ID: 32aeab29-70b5-97b3-1a6b-96c6bfcecc3c
Content: Restricted entities requiring Dynamics 365 licenses - Power Apps
Content Source: powerapps-docs/maker/common-data-service/data-platform-restricted-entities.md
Service: powerapps
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

Closing as this has been addressed.


Silver sponsor logo disappeared after editing tiers

I just edited the description of my tiers. After which the Silver Sponsor disappeared from the right tiers card. This sponsor was previously manually set to the silver tier due to manually selecting an amount instead of clicking a tier.

see: https://opencollective.com/tenancy#contributors

@xdamman this is also referenced in #808 The sponsor is marked as silver sponsor in the card but it's not showing up in the side tiers.
Setting this as a priority bug to look at on Friday.

It's because the TierId was not referenced in the Order. We fixed it in the Members table but not in the Orders one. Fixed now.


Add line break after first row and make header in bold font

I am able to get row appended next to filter Criteria array line. I want to add one empty row after first two rows and add reportRows array data. and make header in bold text for reportRows data.
var filterCriteria=[{filter1:valueA,filter2:ValueB,filter3:ValueC}];
var reportRows=[{Header1: 123,Header2:abc,Header3:456},{Header1: 789,Header2:rds,Header3:098}];

  var wb = XLSX.utils.book_new();
  wb.SheetNames.push("Sample Sheet");
  const ws = XLSX.utils.json_to_sheet(filterCriteria);
  XLSX.utils.sheet_add_json(ws, reportRows, { origin: -1});
  wb.Sheets["Sample Sheet"] = ws;
  var wbout = XLSX.write(wb, { bookType: 'xlsx', type: 'binary' });
  function s2ab(s) {
     var buf = new ArrayBuffer(s.length);
     var view = new Uint8Array(buf);
     for (var i = 0; i < s.length; i++) view[i] = s.charCodeAt(i) & 0xFF;
     return buf;
    }
   saveAs(new Blob([s2ab(wbout)], { type: "application/octet-stream" }), 'SampleReport.xlsx');

Style related features like bolding are supported in our Pro offering

Hi,
Please let me know how to add empty row after 2 rows.
I mean while performing below action, I want to add one empty line on the top before adding json .
  XLSX.utils.sheet_add_json(ws, reportRows, { origin: -1});

How to make the header bold ?


Expose X-Ratelimit-* headers on ChatCompletion API requests

Describe the feature or improvement you're requesting
If you make a call to POST /v1/chat/completions manually, you get a few very helpful headers that estimate time to rate-limiting
x-ratelimit-limit-requests: 3500
x-ratelimit-remaining-requests: 3499
x-ratelimit-reset-requests: 17ms

However, if you call openai.ChatCompletion.create(...) or openai.ChatCompletion.acreate(...), these helpful rate limit values are not returned by the function.
It would be nice if we could get access to these headers, or have them returned in a helpful format along with the response
Additional context
No response

+1 for this, preventing a rate limit error is better for everyone!

what would be the preferred format  here?

Just forwarding the response headers in a nice way

requests supports response hooks
Perhaps openai.api_requestor could allow the calling app to define a session_hook which could then be used in-turn to create a response hook.

what would be the preferred format here?

@shyamal-anadkat Maybe get the response headers from requests as is: https://requests.readthedocs.io/en/latest/user/quickstart/#response-headers
The completion response is currently a generator, so maybe you can add a flag response_headers to the create calls, and if it is set, return a tuple: (headers, response-generator)?

+1

+1, this feature would be really helpful

Ok I have found a solution (at least for those using acreate) :
Bellow is an exemple :
import aiohttp
import asyncio

async def log_response_headers(session, trace_config_ctx, params: aiohttp.TraceRequestEndParams):
    print(f"Received response headers from {params.url}: {params.response.headers}")

trace_config = aiohttp.TraceConfig()
trace_config.on_request_end.append(log_response_headers)

async def generate_chatgpt_response():
     async with aiohttp.ClientSession(trace_configs=[trace_config]) as session:
            openai.aiosession.set(session)
            response = await openai.ChatCompletion.acreate(...)
    return response
asyncio.run(generate_chatgpt_response())

So I found the solution like this :
in __init__.py (line 67):
aiosession: ContextVar[Optional["ClientSession"]] = ContextVar(
    "aiohttp-session", default=None
)  # Acts as a global aiohttp ClientSession that reuses connections.
# This is user-supplied; otherwise, a session is remade for each request.

And in api_requestor.py (line 769):
@asynccontextmanager
async def aiohttp_session() -> AsyncIterator[aiohttp.ClientSession]:
    user_set_session = openai.aiosession.get()
    if user_set_session:
        yield user_set_session
    else:
        async with aiohttp.ClientSession() as session:
            yield session

+1, headers field in response would be very helpful

For synchronous invocation this will store headers.
import requests

headers = {}

def capture_and_filter_headers(response, *args, **kwargs):
    nonlocal headers
    headers = response.headers

s = requests.Session()
s.hooks = {'response': capture_and_filter_headers}

openai.requestssession = s

This is supported in v1 which was just released!
You can access the rate limit information like so:
from openai import OpenAI

client = OpenAI()

response = client.chat.completions.with_raw_response.create(
    model="gpt-4",
    messages=[
        {
            "role": "user",
            "content": "Say hi!",
        }
    ],
)
print(response.headers.get("x-ratelimit-reset-requests"))

completion = response.parse()
print(completion.model_dump_json(indent=2))

does it work for AzureOpenAI client too? I tried it and it does not return any ratelimit information

That sounds like an Azure OpenAI API issue – I recommend requesting the feature from them.

@rattrayalex @RobertCraigie is there any tradeoff to switching
from chat.completions.create
to chat.completions.with_raw_response.create
I found mentions of legacy_response in the code base, but what's the diff between the two ?

@ishaan-jaff the main difference is that .with_raw_response will return a response object that uses async methods in the next major release, see this docstring: https://github.com/openai/openai-python/blob/0c1e58d511bd60c4dd47ea8a8c0820dc2d013d1d/src/openai/_legacy_response.py#L32

okay and just confirming - there is absolutely no way to access the response headers if I use chat.completions.with_raw_response.create ?

do you mean chat.completions.create()?
no there isn't a direct way but you could use httpx event hooks https://www.python-httpx.org/advanced/#event-hooks

okay thanks for the help @RobertCraigie , will look into this

@RobertCraigie Are headers accessible via with_raw_response?

@PSU3D0 yes it's the exact same setup


Rename frequency domain and time domain submodules

Currently they are called mono and time, which is inconsistent.
Possible options:

frequency + time
fd + td
f + t

Another option, which is currently used in the equation references on http://sfstoolbox.org/, is to use capital letters to denote the frequency domain.
Any other ideas?

Additionally, there are some functions, that are categorized in either, but are actually valid for both domains.
E.g. sfs.mono.drivingfunction.source_selection_... comes to my mind.

I would vote for fd for frequency-domain and td for time-domain functions. However at some point we might also have to distinguish between temporal and spatial frequency domain. For instance when implementing the spectral divison method (SDM).

at some point we might also have to distinguish between temporal and spatial frequency domain

Maybe we could consistently use "modal domain" for the various spatial frequency domains.

I'm also in favor of "time domain", "frequency domain", and "modal domain", but I'm not completely sure if it is sufficient to use td, fd, md, or if those names should be more self-explanatory to the user.

There are two things I like about the current (time, mono) solution:
1.) They are short and have equal length.
2.) You can pronounce them.
As @spors has pointed out frequency would have a problem. It might be that the usage of time and mono is not completely consistent, but they are not as problematic.
modal as a third option would be fine with me.

I think, that modal is too general. In the future, we might need a namespace for each of the spatial frequency domains, e.g. cht, sht, kx or pwd.

I do not see a problem with using freq for the time-frequency domain, since we do not have the (one) space-frequency. Most likely, we will refer to the specific geometry-dependent domains cht, sht, kx or pwd, instead. Right now, I do not see any functionality we can implement without knowing the specific space-frequency domain. Hence, modal is too general, imho.
We should also consider, that modal (or the specific domain) has to be likely combined with both, time and  freq. I think, that an additional level of hierarchy e.g. time.cht and freq.cht might be better suited for that.

It would be very helpful if we could agree on one (at least temporary) solution until end of February as I will adjust the links to the functions in the theory section accordingly. Alternatively, I could stay with what I have there at the moment and we will change it later when this is solved.
I'm especially interested in the question if I should go with:

time, mono
time, frequency
time, freq
td, fd
t, f

In order of preference: 3, 4, 5, 1, 2

We should also consider, that modal (or the specific domain) has to be combined with both, time and freq. I think, that an additional level of hierarchy e.g. time.cht and freq.cht might be better suited for that.

I agree with @fietew.
I also prefer 3.

Thanks for the input, 3. (time and freq) seams also reasonable to me.

My choice in order: 3, 4, 5, 2. Don't like 1.
Go ahead for time and freq. The modal issues should be checked after this change within the driving function files.

I would vote for 3, 4 and not for the other variants.

So it looks like freq/time is the favorite, followed by fd/td.
I don't really like the name freq, because it feels like an unnatural abbreviation and it is very hard to pronounce. I would argue that it is not Pythonic to have such abbreviations, but we should rather have either acronyms (like sfs) or full names (like tapering). But I have to contradict myself immediately, because we also have sfs.util, which is the same kind of abbreviation (but probably easier to pronounce). OTOH, this is really the only exception we currently have.
The second problem that I have with both freq and time is that (even if you imagine the full name frequency) they are still abbreviations at another level, because they actually stand for "frequency domain" and "time domain". The words "frequency" and "time" on their own don't contain the necessary information that's needed for the situation we are using them in.
The choice fd/td has none of these problems.
But it has another problem, it's a bit hard to see what those letters mean.
I think we should look at it in context. @hagenw has already shown in #119 how freq/time would look like. I've just created #135 to show how fd/td would look like.
I've also created a variation #136, which is based on my suggestion #130.
I'm still unsure which of the options is really the best. Probably someone can come up with an even better option that we haven't discussed before?
Please look at the different suggestions, look at how the example scripts would look like, and create the Sphinx docs and look how those would look like.
If everyone still prefers freq/time, we can use that, but I just wanted to give you the opportunity to look at it in context, especially since the whole module structure has changed quite significantly since we started this discussion.

My choice in order: 3, 4, 5, 2. Don't like 1.
Go ahead for time and freq. The modal issues should be checked after this change within the driving function files.

My initial favorite choice changed with the new structure. Now I can perfectly follow the argumentation of fd/td, my second choice. It looks very nice in the API and is of all solutions the most consistent, so I'd vote to take this road.
For me, introducing the fancy part is a cool add-on, however I wouldn't mind not to have this for the td/fd, since the naming is short enough by itself.

I think freq is not hard to pronounce and freq/time look more intuitive than fd/td. In addition, I think the d is redundant information. I would still vote for freq/time.

Since we have the possibility of using the fancy import #130,
what about just naming time/frequency?

I think freq is not hard to pronounce

freak

I think I would prefer frequency over freq because of my first point above (https://github.com/sfstoolbox/sfs-python/issues/25#issuecomment-472806617).
But it would still not help with my second point ...
Based on the availability of #130 I also thought about using other long names, e.g. monochromatic/broadband, but I'm not really liking it. But I guess it would just be a matter of getting used to it.
@hagenw

In addition, I think the d is redundant information.

It seems non-redundant to me, but probably you have another view.
How would you interpret something like sfs.time.source.point()?
Something for timing point sources?

I've created another variation using monochromatic/broadband: #141.
This kinda requires #130, otherwise it can be annoyingly verbose.
This may not sound convincing when reading about it here, but you should check out the code examples and the generated Sphinx docs, it actually looks quite good IMHO!

Thanks for this effort! Looks good to me, but I'm not at all convinced of the
term broadband, since this can be easily misunderstood in terms of spatial bandwidth.
IMO something indicating time and frequency as already proposed seems much more
accessible and consistent. With the here suggested solution
you'll probably need to distinguish between broadband
and fullband, because broadband is a very blurry term for indicating
frequency domain.

On 14. Mar 2019, at 7:12 PM, Matthias Geier<EMAIL_ADDRESS>wrote:
I've created another variation using monochromatic/broadband: #141.
This kinda requires #130, otherwise it can be annoyingly verbose.
This may not sound convincing when reading about it here, but you should check out the code examples and the generated Sphinx docs, it actually looks quite good IMHO!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Well, a better counterpart of monochromatic would be polychromatic,
which only makes me like time / frequency even more.

We didn't have an example for frequency/time yet, now we have it: #144.

Nice, thank you very much!
My priority list (highest to lowest)

td/fd (short, most consistent with other abbreviations we already use, sfs, wfs etc.) , can include fancy import
time/frequency, include fancy import should be a must have

I don't like
3. time/freq
4. broadband/monchromatic
due to discussed flaws and inconsistencies.

I would be fine with both 1. and 2.

Also has the advantage that equation links in the documentation would be short
It's still a little bit more obvious, but @mgeier is most probably right that sfs.time.source.point() cannot be interpreted by new users that easily.

I still like time/frequency slightly more than time/freq or td/fd.
I want to draw your attention to the following point.
If time/frequency is used, the spatial frequency should be also spelled out. Since those can be either in the time- or frequency domain (as @fietew mentioned in https://github.com/sfstoolbox/sfs-python/issues/25#issuecomment-465188900), the combination would be like
sfs.time.spherical_harmonics.wfs.point()
sfs.frequency.circular_harmonics.nfchoa.plane()
which are too long.
If we use td/fd, the spatial frequency domain should be something like shd and chd (for spherical harmonics domain and circular harmonics domain).
sfs.td.shd.wfs.point()
sfs.fd.chd.source.plane()
'sfs.fd.kx.sdm.plane().
Maybe too many abbreviations?
IMHO, they should be more self-explanatory.

td/fd and time/frequency are both fine for me.

@narahahn
What about using these two right now:
sfs.fd
sfs.td

... and introducing those later, when needed:
sfs.td_shd
sfs.fd_chd
sfs.fd_kx

I don't think it's necessary to introduce a whole other level of submodules.
And if we would do that, we would need additional names for the current modules:
sfs.td.???.wfs.point()
sfs.fd.???.source.plane()

If you do know appropriate names, we could change the current module names to
sfs.fd_???
sfs.td_???

What about using these two right now:
sfs.fd
sfs.td

... and introducing those later, when needed:
sfs.td_shd
sfs.fd_chd
sfs.fd_kx

I'd vote for this. I am slightly against submodules, however I currently have no idea, what driving functions/filters we have to expect within the different spatial domains. For those I can imagine of the cited proposal is perfectly fine for me.

I don't think it's necessary to introduce a whole other level of submodules.

Yes, you're right. It doesn't make much sense to have those submodules.
At the end, the driving functions need to be transformed into the space-domain anyway.
Unlike time and frequency domain, it is unlikely to work exclusively in one domain,
either space or spatial frequency domain.
This should be a topic for future discussion.

What about using these two right now:
sfs.fd
sfs.td

My final vote for both time/frequency and td/fd.

I looks like #135 is the winner.


Email Notifications with Nodemailer:  Integrate nodemailer for email notifications related to bookings, confirmations, and reminders (utils/auth.js and other files related to user notifications).

Developer 3 (secondary task): Work with utils/auth.js file, any files related to user notifications. Refer to your previous work, developer 3, to integrate nodemailer for email notifications related to user actions.
Collaborate with other developers to ensure email notifications align with different features.


Deletions in metadata dicts not propagated to database

If you load in a bundle.yaml file with :
requirements:
    a: a
    b: b

and then change the bundle.yaml file to:
requirements:
    a: a
    c: c

The database will have a,b and c, but it should have only a and c.

What steps should I do to repeat exactly that case?

The test case should edit the bundle.yaml to be the first example, run Bundle.sync_in(), edit to get the second case, run Bundle.sync_in(),  then load the bundle.yaml file directly as YAML and check the result.

Done. Tests - https://github.com/CivicKnowledge/ambry/blob/ambry1.0/test/test_metadata/regression/test_ambry_93.py .


github: produce better curl error messages.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

If we don't know why curl has failed then ensure that the error messages that it produced are included as part of the user output.
Prompted by Homebrew/homebrew-core#2410. CC @ilovezfs

@MikeMcQuaid Since the problem in Homebrew/homebrew-core#2410 seems not to go away when the firewall is up, I wonder if there's a solution to recommend so that user isn't always looking at these error messages. For instance, do we know what port the GitHub API requires so the appropriate exception can be added to the firewall rules if desired?

We could also recommend setting HOMEBREW_NO_GITHUB_API=1 but that feels like a sledgehammer solution since the problem may only be transient (e.g., you're using a restaurant's WiFi, which has a firewall on the relevant port, but no such problem at home) but setting a profile variable is unlikely to be unwound spontaneously by the user at some later date.

The GitHub API uses HTTPS, so I guess we're talking about port 443. I don't think there's much we can do if this port happens to be blocked, but in this case the user typically will have quite a problematic web experience in general …

@ilovezfs yeh, if they cannot access the GitHub API they are going to have to just disable all usage.

Should the output say that explicitly as well as possible cause or just wait for them to file the issues and respond each time?

@ilovezfs Sorry, you've lost me: what output/what cause?

@MikeMcQuaid Oh, I'm only asking if you think the curl error messages will need any brew customization to make them more clear or if they're good enough all by themselves.

@ilovezfs Good point. I think the curl error messages would be an improvement on what we have now but may need further tweaks eventually, yeh.

Other than the bug I found (and you already acknowledged) it behaved as I expected in local testing (e.g. when switching off WiFi or using Ruby 1.8.7).
:+1: as soon as the bug is squashed.


How to get errors back with w3 api?

How can I get error back with this interface/api? for example say I want to do this
var latestBlockNumber big.Int
eth.BlockNumber().Returns(&latestBlockNumber)

what happens if this network call fails? would the block number be -1 or something? I can eth.BlockNumber().Returns(&latestBlockNumber).createRequest() but then I am batch BatchElem and ethClient API which is not great. The w3 API looks really good and would be nice if it can also returns errors

eth.BlockNumber()... will just generate the RPC call. You also need a client to send the call to some endpoint and that client returns the error (see https://github.com/lmittmann/w3#batch-requests). If you send multiple calls in a single request and one is failing you can use https://pkg.go.dev/github.com/lmittmann/w3#CallErrors to get the error per RPC call.


Add OR clause

Refactor interpret() to not mutate and leverage separate component builder for query

Completed in PR#5


League Card.

Ahhhhh, TSOA hates trying to sort.

Wait what happened to the sort changes? :sob:

This also needs a lot of tests, which is why I'm guessing this is still a draft. But otherwise looks reasonable

Okay this stinks, because Match["picture"] can either be undefined | null | string and it's failing the tests AAAAAAAAAAH.

Okay, my solution to this is very ugly: you must include null as the default value for Match["picture"] -- this got ugly very quickly, sorry.

@WilfSilver whenever you have time, can you pls review :point_right: :point_left: ?

@WilfSilver The commits should be slightly more tidied up now, so if you don't have any more concerns this can be merged.


Subpixel Font Rendering

This has been merged into the opengl branch. Closing in favor of that one.


First click on iOS Universal Link goes to /home instead of destination

Steps to reproduce:

Close the Artsy iOS app
Click on a link that should get redirected to the App
Opens app, but goes to home
Click on link again and see that it goes to the destination url

Kana which link?

I’m going to assume that @kanaabe was testing this because of the gender equality editorial content.

Yep it was. https://artsy.net/gender-equality. We don't want that link to redirect to the app at all, but I noticed this behavior in testing it out.

I've been wondering if this is something that changed in iOS 11

Looks likely: https://stackoverflow.com/questions/39548010/openurl-deprecated-in-ios-10/39548060

Should be fixed in the next Eigen beta

Dope 👌


Usage seconds is negative integer

Version
0.1.0
Problem
> ./gha-usage phpstan/phpstan-src 2022-10-17 2022-10-19
phpstan/phpstan-src (2022-10-17 ~ 2022-10-19) usage
Linux: -2561813h31m9s (-9222528669s)
Windows: 165h59m59s (597599s)
Mac: 0s (0s)

Expected
positive integer

> ./gha-usage phpstan/phpstan-src 2022-10-17 2022-10-17
hpstan/phpstan-src (2022-10-17 ~ 2022-10-17) usage
Linux: 107h21m1s (386461s)
Windows: 83h44m2s (301442s)
Mac: 0s (0s)

> ./gha-usage phpstan/phpstan-src 2022-10-17 2022-10-17
phpstan/phpstan-src (2022-10-18 ~ 2022-10-18) usage
Linux: 64h54m22s (233662s)
Windows: 40h32m35s (145955s)
Mac: 0s (0s)


rewrite void-returning statements in constructors that capture result of super call

fixes #11846

ported to release-2.1 in 467f252583d7b1fce01b3f5213e6e9b27fe98db3


Run tests on iOS 17 exclusively

Almost all of our devicelab devices are on iOS 17 now, so let's use them exclusively so we can verify that tests pass consistently on iOS 17.
Fixes https://github.com/flutter/flutter/issues/144020.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thanks a lot for trying out the actions bot!
By the way was there a real merge conflict that prevented the auto cherry pick ( i.e. you also resolved a conflict when manually doing the cherry pick ), or is it a false positive from the actions bot? Thank you!

Thanks a lot for trying out the actions bot!
By the way was there a real merge conflict that prevented the auto cherry pick ( i.e. you also resolved a conflict when manually doing the cherry pick ), or is it a false positive from the actions bot? Thank you!

It did have an actual merge conflict I had to manually resolve.


TextFormField regains focus after DropdownButtonFormField menu item selected

If a DropdownButtonFormField menu item is selected after selecting a text field, the focus returns to the text field. This is similar to https://github.com/flutter/flutter/issues/47128, which was closed and marked as fixed after https://github.com/flutter/flutter/pull/93716, but the issue is still appearing with DropdownButtonFormField.
Steps to Reproduce

Execute flutter run on the code sample
Tap on the text field
Tap on the dropdown menu and select something from it

Expected results:
Focus should stay on the DropdownButtonFormField.
Actual results:
Focus returned to the TextFormField, popping up the keyboard (and, in a larger application, scrolling the screen back up or down to the TextFormField).

Code sample

// ignore_for_file: prefer_const_constructors

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Dropdown Form Field Focus Example',
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        // This is the theme of your application.
        //
        // Try running your application with "flutter run". You'll see the
        // application has a blue toolbar. Then, without quitting the app, try
        // changing the primarySwatch below to Colors.green and then invoke
        // "hot reload" (press "r" in the console where you ran "flutter run",
        // or simply save your changes to "hot reload" in a Flutter IDE).
        // Notice that the counter didn't reset back to zero; the application
        // is not restarted.
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Dropdown Form Field Focus Example'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  String dropdownValue = "Select";

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center (
        child: Padding(
          padding: EdgeInsets.all(10),
            child: Column(
              children: <Widget>[
                TextFormField(
                  decoration: InputDecoration(
                    border: OutlineInputBorder(
                    ),
                  ),
                ),
                DropdownButtonFormField<String>(
                value: dropdownValue,
                items: const [
                  DropdownMenuItem(
                    child: Text("Select"),
                    value: "Select"
                  ),
                  DropdownMenuItem(
                    child: Text("One"),
                    value: "One"
                  ),
                  DropdownMenuItem(
                    child: Text("Two"),
                    value: "Two"
                  ),
                ],
                onChanged: (newValue){
                  setState(() {
                    dropdownValue = newValue!;
                  });
                }
              ),
              ],
            ),
        ),
      ),
    );
  }
}

Logs

Flutter Doctor Output
[√] Flutter (Channel stable, 2.8.1, on Microsoft Windows [Version 10.0.19042.1415], locale en-US)
    • Flutter version 2.8.1 at C:\Users\blivingston\Documents\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (5 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\blivingston\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[X] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[√] Android Studio (version 2020.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] VS Code (version 1.63.2)
    • VS Code at C:\Users\blivingston\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.32.0

[√] Connected device (2 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Edge (web)              • edge          • web-javascript • Microsoft Edge 97.0.1072.55

! Doctor found issues in 1 category.

This change hasn't landed in the Stable channel yet, it is available from 2.9+


[FLINK-12127][network,config] Move network related options form TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions

What is the purpose of the change
The introduced NetworkEnvironmentOptions could be used for different shuffle services in future, not only for current task manager. So it is better to extract network related parameters as independent options.
Brief change log

Extract network related options from TaskManagerOptions into `NetworkEnvironmentOptions
Migrate network related options from NettyConfig into NetworkEnvironmentOptions
Modify the config.md for generating new network_configuration.html
Adjust the related tests

Verifying this change
This change is a trivial rework without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@flinkbot attention @azagrebin

04:15:52.982 [INFO] There are 3 errors reported by Checkstyle 8.12 with /tools/maven/checkstyle.xml ruleset.
04:15:52.984 [ERROR] src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java:[31] (imports) ImportOrder: Import org.apache.flink.configuration.NetworkEnvironmentOptions appears after other imports that it should precede
04:15:52.986 [ERROR] src/test/java/org/apache/flink/test/cancelling/CancelingTestBase.java:[32] (imports) ImportOrder: Import org.apache.flink.configuration.NetworkEnvironmentOptions appears after other imports that it should precede
04:15:52.987 [ERROR] src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java:[35] (imports) ImportOrder: Import org.apache.flink.configuration.NetworkEnvironmentOptions appears after other imports that it should precede

Thanks for the notification @zentol !
I already updated the codes for the checkstyle issue.

@flinkbot approve all

Thanks for the reviews @azagrebin !
I agree with your suggestion of metric naming for ShuffleService future. We could do that then.

FYI, I reverted the first hotfix commit and removed the unused LOCATIONS. @azagrebin

@zentol  I have updated the codes for addressing the issues. :)

Thanks for the further review @zentol . It is green. :)


[EdgeTPU] Create new panel for EdgeTPU config file

EdgeTPUCfgEditorPanel.ts is created in this PR.

EdgeTPUCfgEditorPanel.ts : We will make a new file extension name, .edgetpucfg and this is a panel for edgetpucfg.
extension.ts : add a register command to regist this new panel
package.json : mapping *.edgetpucfg and the new view type, one.editor.edgetpucfg

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee<EMAIL_ADDRESS>Co-authored-by: Bumsoo Ko<EMAIL_ADDRESS>Co-authored-by: Hyeon-Uk<EMAIL_ADDRESS>related : https://github.com/Samsung/ONE-vscode/issues/1621

To see if the editor works well, I merged #1671 to this PR, but it still doesn't work when I right-click any.edgetpucfg file and "Open With" : "Edgetpu Cfg Editor". Am I missing something?

To see if the editor works well, I merged #1671 to this PR, but it still doesn't work when I right-click any.edgetpucfg file and "Open With" : "Edgetpu Cfg Editor". Am I missing something?

I find the reason why it causes a warning. It was a typing error.
So I make a new commit now.
Sorry for not checking this typo :(

I have a question.
In this PR, are we only making a view excluding the logic of the panel?
If there is a value in the setting file, it does not seem to be applied in editor:(

I have a question. In this PR, are we only making a view excluding the logic of the panel? If there is a value in the setting file, it does not seem to be applied in editor :(

I mapped a wrong file to _oneConfigMap so it didn't work. Sorry for it!
I committed a fixed version of it now. Plz check it again :)

it works on my device! thanks

Could you rebase this PR on the latest ssafy branch?


Change starter template to make frontend external endpoints

Fixes #3495 to make the frontend web app in aspire-starter template to use the WithExternalHttpEndpoints
Microsoft Reviewers: Open in CodeFlow

Assume we want to merge/backport this?

yes

yes

make it so all powerful one. 😜

/backport to release/8.0


General improvements

Just some improvements that came to mind while I was working on opaque-ke:

Rename util to common, as instead of utility functions this now contains a lot of common functionality between the OPRF modes.
Relax bounds of hash_to_scalar and hash_to_group to only what's needed, now that we don't pass in Mode anymore.
The public key generated by DeriveKeyPair is thrown away in the OPRF mode, so I split the function up to not unnecessary generate a public key, improving the performance a bit.
Simplify some Ristretto255 implementations.

I only left it in draft mode because I planned to add more stuff until I finish novifinancial/opaque-ke#268. I can take it out if you prefer, feel free to merge it if you want it out of the way too.

It should be fine to leave this in draft for now, then. Thanks for the clarification!

(@daxpedda: Update from my previous comment: I will be happy to push out the next version once this PR is landed, so feel free to take it out of draft mode if you think it is ready for re-review + merge)


Auestion about Athena

Hi, sorry for opening an issue, but there are no discussions enabled, nor a comment section on the solutions page.
I'm trying to understand the value Athena provides in this solution given that the data coming from AMC is not truly queryable, and most likely has already been crunched at the AMC side.
Is it purely for the Glue catalogue capability?
In our solution, we went direct S3 -> QuickSight ingestion, and am wondering if maybe I am missing a key step here.
Thanks.

We apologize for the late response on this.
You are right that Athena is not a requisite component for using the Solution and running S3 directly into QuickSight is completely valid. There are a few reasons an organization may want to use Athena. One would be restricting data access for certain groups through Lake Formation, where individuals in these groups would use Athena as their means of viewing the data in S3 before building out any reporting. In addition, since the data lake is open and allows for adding new data sources outside of just AMC, it is not always the case that the data residing in S3 will be crunched ahead of time. New data sources may need additional querying before being pulled downstream.
These are just a couple examples of where Athena may be used.
Best,
Andrew

Adding to this:
I found it very helpful to work with Athena Views instead of direct query to S3 before visualizing data.
Adding an example below.
With this approach, the Athena view will always select the latest file in case there are multiple files for the same date range (or "time_window_start + time_window_end combination").
Furthermore, it removes results filtered due to the aggregation threshold from the result (assuming you named this column aggthr_filtered).
CREATE OR REPLACE VIEW "select_latest_data_from_workflowtable" AS

With
--identify only the latest file for identical dates
select_latest_file as (
    SELECT time_window_start, time_window_end, file_last_modified
    FROM (
        SELECT time_window_start, time_window_end, file_last_modified,
               ROW_NUMBER() OVER (PARTITION BY time_window_start, time_window_end ORDER BY file_last_modified DESC) AS rn
        FROM workflowtable_adhoc
    ) ranked
    WHERE rn = 1)

SELECT desired_table.*
FROM workflowtable_adhoc desired_table
    INNER JOIN select_latest_file slf
        on desired_table.file_last_modified = slf.file_last_modified
    WHERE (aggthr_filtered = false)

Thinking about this a little bit more, I am wondering whether the provided Athena query could be improved by converting the timestamp to date. With this setup, it should also catch scenarios when a workflow ran multiple times for the same date range, but the users selected different time zones.
The function below assumes that the workflow you are running is taking advantage of adding parameters BUILT_IN_PARAMETER('TIME_WINDOW_START') as time_window_start and BUILT_IN_PARAMETER('TIME_WINDOW_END') as time_window_end as part of the final SELECT. Furthermore, this function assumes that you add "filteredMetricsDiscriminatorColumn": "aggthr_filtered" to your workflow.
The AMC Insights on AWS solution will automatically add the file_last_modified info.
CREATE OR REPLACE VIEW "select_latest_data_from_workflowtable" AS

With
--identify only the latest file for identical dates
select_latest_file as (
    SELECT time_window_start, time_window_end, file_last_modified
    FROM (
        SELECT
        DATE(time_window_start) as time_window_start
       , DATE(time_window_end) as time_window_end
       , file_last_modified
       , ROW_NUMBER() OVER (PARTITION BY time_window_start, time_window_end ORDER BY file_last_modified DESC) AS rn
        FROM workflowtable_adhoc
    ) ranked
    WHERE rn = 1)

-- select only the latest files and remove information which was filtered
SELECT desired_table.*
FROM workflowtable_adhoc desired_table
    INNER JOIN select_latest_file slf
        on desired_table.file_last_modified = slf.file_last_modified
    WHERE (aggthr_filtered = false)


LG content update doesn't accept empty string for existing template

When updating an existing template, the updater replaces passed empty string body with the current body of the template leading to not being able to update the body to an empty string.
in:
packages/lib/indexers/src/utils/lgUtil.ts#L101
the following line replaces the empty string value:
body: body || originTemplate?.body || '',

@lei9444 can you help me with this? Is this something intentional?

@zhixzhan can you review the intention and see if it still works

@boydc2014 @hatpick I checked again, this line is originally added to all do partial update on a template,
for example,if call this method with parameter { name }, will do update template with name and origin body.
but it should be more precisely like：
body: typeof body === undefined ? originTemplate?.body || '' : body,


chore(editor): remove duplicate UID check

The WIP PR removed all of the duplicate UID code and checks
Manual Tests:
I hereby swear that:

[ ] I opened a hydrogen project and it loaded
[ ] I could navigate to various routes in Preview mode

Fixes #5654

Temporarily closing as Spike


net: fix typo in unexported variable name

Noticed while reading through this file. I also ran "git grep emporarly"
to see if a similar typo occurred anywhere else, but this was the only
occurrence.

@odeke-em can this PR be merged now? Thanks.


delete role throw error

When deleting role record, an error occurred.
FatalThrowableError in NtrustRoleTrait.php line 95:
Using $this when not in object context

After I check the line 95 of NtrustRoleTrait.php, seems you are calling $this within the static method.
Any solution for that?

@riseno  Thank you for found issue.
Can you please verify in your local vendor code with that self::roleProfile ?
Let me know if that working fine then I will update code and release new version with bug free.

Please ignore my last comment. Let me check other solution.
Are you using softDelete?

I have fixed on new release.
Can you please try now with below changes.
It's might be bad coding practice but it will work for now.
Take v1.0.4
Please add following line in your three model files (Users, Role, Permission)
protected static $staticRoleProfile = 'user or [Your Profile]';

Let me know if you have more issues.

Thanks for your reply and fixes, but, there is still error on it.
By calling the class static property, it should be called like this
self::$staticRoleProfile

Otherwise, below error will be thrown.
Undefined class constant 'staticRoleProfile'

Thanks for finding bug.
Fixed.
Can you please try now?

Cool! all good now. thx a lot


Added Foundry Points Overlay

Fixes #7. Did some testing and all seems to work. Keeps track of when you finish a sword, open the shop window and tracks between sessions.
I am not sure if the regex is the best but seems to work... Anyway here is an example of the text that I used.

Looks pretty good, regex is fine too. I'll merge it tomorrow and make some minor changes.

Looks pretty good, regex should be fine too if it is always like that. Curious what it would say on someone's first sword when they don't have a best time. Could make the regex based on the first line only if that changes.
I'll merge it tomorrow and make some minor changes.

Sounds good, glad I could help. 👍


Fix visit python modules install

Description
Fixes problems with installation of visit's python modules.
Instead of installing the individual modules with 'pip install', install the build/lib/site-packages dir directly.
Draft mode for comments and testing on Mac.
Type of change

[ ] Bug fix~~
[ ] New feature~~
[ ] Documentation update~~
[ ] Other~~

How Has This Been Tested?

Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

[ ] I have commented my code where applicable.~~
[ ] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.~~
[ ] I have added debugging support to my changes.~~
[ ] I have added tests that prove my fix is effective or that my feature works.~~
[ ] I have confirmed new and existing unit tests pass locally with my changes.~~
[ ] I have added new baselines for any new tests to the repo.~~
[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

Hello,
I am wondering if I encountered the same issue or is it a new one ?
My error shows up in packaging too
My build command is this:
/nfs/gce/projects/sigma/visit2/src/tools/dev/scripts/build_visit --parallel --hdf5 --netcdf --moab --makeflags -j24 --qt6 --vtk9

CPack: Install projects
CPack: - Run preinstall target for: VISIT
CPack: - Install project: VISIT []
Symlinking current to 3.4.0
CMake Error: failed to create symbolic link '/usr/local/current': Permission denied
CMake Error at /scratch/iulian/build_visit/visit/build/visitpy/cmake_install.cmake:95 (file):
  file INSTALL cannot find
  "/scratch/iulian/build_visit/visit/build/lib/site-packages/visit/visitmodule.so":
  No such file or directory.
Call Stack (most recent call first):
  /scratch/iulian/build_visit/visit/build/cmake_install.cmake:1656 (include)

make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
Traceback (most recent call last):
  File "/scratch/iulian/build_visit/third_party/python/3.9.18/linux-x86_64_gcc-11.1/bin/sphinx-build", line 5, in <module>
    from sphinx.cmd.build import main
  File "/scratch/iulian/build_visit/third_party/python/3.9.18/linux-x86_64_gcc-11.1/lib/python3.9/site-packages/sphinx/cmd/build.py",

I am wondering if I encountered the same issue or is it a new one ?
Most likely. Are you building from 3.4RC?

I am building from current develop branch
commit 3def16076dfbd6e8b9456a78b7d5cf98a059525b

@iulian787 Since you are using -j24 this sounds l like the same issue. We had a missing cmake dependency relationship that could cause the visitmodule to disappear.
@biagas thanks for working on this, I suspected it might be a cmake dependency issue, but didn't have time this week to look into it.


Is Host Header Specified

AWS ElasticSearch requires that the Host: [host] HTTP header be specified as stated in the documentation. I was wondering if this is set for us or if we need to manually specify this for ES clients.

Given that we’re using the official AWA SDK for Go, I assume they’re handling this correctly. I didn’t dig into the details of that SDK. Also, the Host header is required as of HTTP/1.1 (see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Host), so I’m pretty sure that works fine because it’s done by the standard library on the protocol level.
Let me know if you find otherwise.


Hello, the output.pkl file cannot be opened or is garbled. How to solve it? Thank you.

Checklist

[ ] I've searched the project's [issues]

❓ Question

How can I [...]?
Is it possible to [...]?
📎 Additional context

Please try the following script and verify that the output matches the image.

import pickle

import cv2

from common.viz import display_matches

with open("output.pkl", "rb") as f:
    pred = pickle.load(f)
print(pred.keys())

ransac_images, _ = display_matches(
    pred, titles="", tag="KPTS_RANSAC"
)

cv2.imwrite(
    str("ransac_images.jpg"), ransac_images[:, :, ::-1].copy()
)  # RGB -> BGR

If there are no further questions, please close the issue.


enhancement: Policy variables in the REPL

Adds support for correctly handling variables declared in the policy file.
Variables are re-evaluated each time any of the inputs change.
Signed-off-by: Charith Ellawala<EMAIL_ADDRESS>

Codecov Report

Merging #853 (017bc57) into main (811bb34) will increase coverage by 0.40%.
The diff coverage is 83.92%.

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   53.97%   54.37%   +0.40%
==========================================
  Files         101      101
  Lines       10969    10983      +14
==========================================
+ Hits         5920     5972      +52
+ Misses       4538     4505      -33
+ Partials      511      506       -5

Impacted Files
Coverage Δ

cmd/cerbos/repl/internal/repl.go
44.86% <83.92%> (+5.85%)
:arrow_up:

internal/engine/engine.go
69.97% <0.00%> (+0.80%)
:arrow_up:

internal/storage/index/builder.go
84.35% <0.00%> (+5.02%)
:arrow_up:

internal/compile/errors.go
55.55% <0.00%> (+15.87%)
:arrow_up:


Update spinnaker-gradle-project to 3.15.0 for rpm support

We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:

Follow the commit message conventions found here.
Provide a descriptive summary for your changes.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Add inline code comments to changes that might not be obvious.
Squash your commits as you keep adding changes.
Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

@jtk54

Out of date -- dependency version already was bumped past 3.15.0, closing.


gating Error: Cannot negate a statement, How to solve this

Error: Optimization error [main.59b656942b7d23accece.js]: Error: Cannot negate a statement
at AST_ClassExpression. (/media/nalin/Work/WOrk/ANGULAR_ANR_PROJECT/hwChecklist/node_modules/terser/dist/bundle.min.js:13712:15)
at AST_ClassExpression.negate (/media/nalin/Work/WOrk/ANGULAR_ANR_PROJECT/hwChecklist/node_modules/terser/dist/bundle.min.js:13769:21)
at AST_Sequence. (/media/nalin/Work/WOrk/ANGULAR_ANR_PROJECT/hwChecklist/node_modules/terser/dist/bundle.min.js:13727:44)
at AST_Sequence.negate (/media/nalin/Work/WOrk/ANGULAR_ANR_PROJECT/hwChecklist/node_modules/terser/dist/bundle.min.js:13769:21)
at /media/nalin/Work/WOrk/ANGULAR_ANR_PROJECT/hwChecklist/node_modules/terser/dist/bundle.min.js:15272:34
at AST_If.optimize (/media/nalin/Work/WOrk/ANGULAR_ANR_PROJECT/hwChecklist/node_modules/terser/dist/bundle.min.js:10899:19)
at Compressor.before (/media/nalin/Work/WOrk/ANGULAR_ANR_PROJECT/hwChecklist/node_modules/terser/dist/bundle.min.js:10884:24)
at AST_If.transform (/media/nalin/Work/WOrk/ANGULAR_ANR_PROJECT/hwChecklist/node_modules/terser/dist/bundle.min.js:5389:41)
at /media/nalin/Work/WOrk/ANGULAR_ANR_PROJECT/hwChecklist/node_modules/terser/dist/bundle.min.js:5405:21
at doit (/media/nalin/Work/WOrk/ANGULAR_ANR_PROJECT/hwChecklist/node_modules/terser/dist/bundle.min.js:110:23)

Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out our submission guidelines to understand why we can't act on issues that are lacking important information.
If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.


Can't store LockPC command

Thanks for creating such an awesome application!
I have tried repeatedly to add the "LockCommand".  Each time it appears to create, but when  "Store and activate commands" and then go back in to the Commands section, it is empty.  I did check on HA for the entity and it did not appear either.

Yep, bug. Will fix for next version. Nice catch, thanks

Fixed!

Thanks!  Works great!


Fix/response headers

Pull Request Test Coverage Report for Build 477979789

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 93.662%

Totals

Change from base Build 477619594:
0.02%

Covered Lines:
203

Relevant Lines:
213

💛  - Coveralls

Pull Request Test Coverage Report for Build 477979789

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 93.662%

Totals

Change from base Build 477619594:
0.02%

Covered Lines:
203

Relevant Lines:
213

💛  - Coveralls

Pull Request Test Coverage Report for Build 477979789

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 93.662%

Totals

Change from base Build 477619594:
0.02%

Covered Lines:
203

Relevant Lines:
213

💛  - Coveralls

Pull Request Test Coverage Report for Build 477979789

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 93.662%

Totals

Change from base Build 477619594:
0.02%

Covered Lines:
203

Relevant Lines:
213

💛  - Coveralls


Wait until the slave pods deletion finished

In current version, when calling remove GPU service, it return without waiting for the deletion of slave pods.
It is unreasonable, because kubelet think the GPU resource is still being occupied by slave pod until the slave pod deletion finshed.

Fixed in 8e8076e1348988cd14da81ed7eb6825234b92e19

Fixed in 8e8076e1348988cd14da81ed7eb6825234b92e19


Limited number of Connections with firebase

Can we host whatever you hosted on "https://webrtc-experiment.firebaseio.com/" in our own server to get rid of the limitation. I am new to Git and novice in WebRTC. Please help!

Sir, we can use your firebase for all connection? I would like to implement in my project but I do not sure if it is possible.
Thank you

I am using RTCMulticonnection for audio video broadcasting and created custom account with xirsys and used own credentials for stun and turn connection and firebase.io for signalling. However, Xirsys states that it provides signalling server for webrtc so my concern is that how could we eliminate firebase io and use xirsys signalling.


Fast Window Resize option so it doesn't slow down when resizing it.

If what's slowing it down is just the autosizing on the columns, I can have it turn off when resizing then turn back on a short time after. Otherwise if it's the entire package list, I'll have to hide it during resize operations.
Doesn't seem to be slow at all when the package list isn't loaded.

Based on testing, hiding the datagridview seems to give the best performance while resizing, and we can use the aaformMainWindow.ResizeStart and aaformMainWindow.ResizeEnd events to hide and show it. This needs to be an option that can be turned on and off since it's a little unexpected to have the package list suddenly disappear. Maybe replacing it with a picturebox that contains a screenshot of the package list kinda like KDE's fast resize would work.

Something based on this SO answer may work for the KDE-style fast resize with a screenshot:
https://stackoverflow.com/a/23805004


Adskipper detected (August 2024)

ERRORS: ReferenceError: removePageAds is not defined at stopYoutubeAd (chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:205:5) at chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:331:13 at Array.forEach () at MutationObserver.observerCallback (chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:327:15)
PROBLEMATIC EXAMPLE VIDEO: https://www.youtube.com/watch?v=lxJsesuG4IQ
POSSIBLE SOLUTION: Revert back to replacing the base player with the embed from previous version.

are you using opera browser?
maybe disable the built-in adblock

are you using opera browser? maybe disable the built-in adblock

I'm using Opera GX, but the built-in adblocker is turned off (AdBlock Plus clone, I assume?). I instead have uBlock Origin, but had it disabled for the time.

or, maybe you're in ssap ads experiment which inject ads to the stream (server side ads)

I don't recall ever joining the experiments, as the ads do indeed skip before showing this popup message.

I am aware of the issue and it is fixed in version 3.5. It is live on Firefox and will be soon live on Chrome (when they review it) so make sure you update it as soon as possible.
I will close this for now, but feel free to open new issue if it happens again. Thanks

@M1ck0 I'm currently running into this problem too. The version of my extension is 3.7.


Allow to stop execution of a resolver from a plugin

Thanks for raising the placeholder.
To summarise the minimum requirement is to arbitrarily force a resolver to return a given value and terminate, or better avoid, executing the original resolver function.
This would be something similar to setResultAndStopExecution available as part of onExecute.
Another way to achieve the same result is to replace the original resolver function with a custom function that can just return an arbitrary value and since it replaces the original it prevents that from being executed.
This would be something similar to setExecuteFn available as part of onExecute.

@santino few thoughts:

We can do skipResolverExecution and skip the resolver code itself, but keep the rest of the plugins running.
We can do stopResolver that stops and skip the rest of the "before" plugins calls.
We can do stopResolver that stops and skip the rest of the "before" and "after" plugin calls.

Which one do you think we should start with? Because we have 3 different flows here: Before plugins, the resolver itself and then After plugins.

Thanks for your thoughts, I was also having a look at the code which helps with the thinking.
I think we still want to keep the plugins tracking the resolver, so we want to skip the resolver code itself only; but not prevent the resolver from being hit.
In the code you have
const originalFn: GraphQLFieldResolver<any, any> = field.resolve || defaultFieldResolver;
Maybe we can pass a function that takes precedence over the original field.resolve in there.
Alternatively, a flag like preventResolverFunction can also work, and when you have this flag you can set result value to null maybe, turning this let result = await originalFn(root, args, context, info); into this let result = preventResolverFunction ? null : await originalFn(root, args, context, info);.
Then later on you can still continue to replace result like its already happening with setResult: newResult => { result = newResult; },
Does it makes sense?

Thanks for your thoughts, I was also having a look at the code which helps with the thinking.
I think we still want to keep the plugins tracking the resolver, so we want to skip the resolver code itself only; but not prevent the resolver from being hit.
In the code you have
const originalFn: GraphQLFieldResolver<any, any> = field.resolve || defaultFieldResolver;
Maybe we can pass a function that takes precedence over the original field.resolve in there.
Alternatively, a flag like preventResolverFunction can also work, and when you have this flag you can set result value to null maybe, turning this let result = await originalFn(root, args, context, info); into this let result = preventResolverFunction ? null : await originalFn(root, args, context, info);.
Then later on you can still continue to replace result like its already happening with setResult: newResult => { result = newResult; },
Does it makes sense?

I guess it depends if you want to do in your plugin:
replaceResolverFunction(myFunc)

and then everything will continue the same way, just with the modified resolver.
Or, you want to do:
stopAndReplaceResolverResult(resolverFakeReturnValue)

Feels like option #1 is more robust because it will allow you to do #2 as well, and it can play nicely with the rest of the plugins you are adding.

yes, option 1 is enough for my personal usecase.
I will be ok with that only, but maybe you want to add both anyway, and again this would be similar to setExecuteFn and setResultAndStopExecution as you have for Execute

yes, option 1 is enough for my personal usecase.

Cool, done in: https://github.com/dotansimha/envelop/pull/400

I will be ok with that only, but maybe you want to add both anyway, and again this would be similar to setExecuteFn and setResultAndStopExecution as you have for Execute

Keeping that on-hold, I want to think about short-circuit in general (see https://github.com/dotansimha/envelop/issues/359)

Available in<EMAIL_ADDRESS>

Great stuff, thanks Dotan!!!


Fireman Burns Meme

Input
{
  "template_id": "fireman-burns-meme",
  "lady_says": "I HATE OSS",
  "font_size": 30
}

Template

Please wait, we started cooking your meme 👨🍳. *Click the 'Actions' tab to see the kitchen 🍳 *

lol this is cool


Manually installing a release APK, then opening, closing, and re-opening the app causes the root component to be mounted multiple times

[x] I have reviewed the documentation
[x] I have searched existing issues
[x] I am using the latest React Native version

Manually installing an APK for the first time ( by copying to the device and then installing the APK), then pressing home, and then reopening the app causes a new root component to be mounted while leaving the old root component still mounted in the background.
Environment
Environment:
OS: Windows 10
Node: 8.1.2
Yarn: 1.5.1
npm: 5.7.1
Watchman: Not Found
Xcode: N/A
Android Studio: Version  <IP_ADDRESS> AI-173.4670197
Packages: (wanted => installed)
react: 16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: ^0.55.1 => 0.55.1 (I've also reproduced the bug on RN 0.50)
Steps to Reproduce
Uninstall any previous version of the app from your android device (installing over the top will cause the bug to not happen).
Build a signed release APK in Android Studio.
Copy the APK to a device. (This bug won't happen if the app is auto installed when copying it across, so  rename the apk file from *.apk to *.ap to get it onto the device and then rename it back to *.apk on the device)
Open the APK using a file manager and install it.
Press "Open" when the install is complete (pressing "Done" will cause the bug to not happen).
Press the Android home button once the app has loaded.
Reopen the app from the launcher.
What appears to happen is that it will mount a new root component while leaving the old one mounted in the backgound. Repeatedly opening and closing the app causes new root components to be mounted without unmounting old ones.
The bug can be fixed by pressing the Android menu button and closing the app from the list of open apps, or by force stopping the app.
The following example highlights the problem:
Run create-react-native-app then replace app.js with.
import React from 'react';
import { StyleSheet, Text, View, findNodeHandle } from 'react-native';

export default class App extends React.Component {

  interval;

  constructor(props) {
    super(props);
    this.state = {nodeHandle: ''};
  }

  consoleOutput = () => {
    console.debug('RemountTest: I should appear every 2 seconds with the same handle. Handle = ' + findNodeHandle(this) );
  }

  componentDidMount() {
    console.debug('RemountTest: App Did Mount');
    this.interval = setInterval(this.consoleOutput, 2000);
    this.setState({nodeHandle: findNodeHandle(this) })
  }

  componentWillUnmount() {
    console.debug('RemountTest: App Will Unmount');
    clearInterval(this.interval);
  }

  render() {
    return (
      <View style={styles.container}>
        <Text>{'Remount Test. Node Handle: ' + this.state.nodeHandle}</Text>
      </View>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: '#fff',
    alignItems: 'center',
    justifyContent: 'center',
  },
});

To see the debug output in Logcat add
android:debuggable="true"

to the application tag in AndroidMainfest.xml and add
android {
    lintOptions {
        checkReleaseBuilds false
    }
}

to app\build.gradle
Expected Behavior
When the app is closed and reopened, the app state should be saved.
Therefore, after reopening the app, the timer should still get called once every 2 seconds with the same App node handle that was shown before closing it, and the App node handle shown in the render should not change.
Actual Behavior
A new timer is created every time the app is reopened and each new timer has a different node handle in the debug message. The old timers still remain active. The App node handle displayed in the render also changes every time the app is reopened.
It appears that a new App component is mounted every time the app reopens, while leaving the old ones still mounted in the background.
The following is a screengrab of Logcat. The first four lines are from when I first opened the app. The node handle for the App component is initially shown in the render as 4. Then I pressed home and reopened the app. On the screen it went from showing "Node Handle: 4" to "Node Handle: 9". It also creates a new timer with "Handle = 9" in the debug message, but the timer with the previous message of "Handle = 4" is still active, so there are two messages every two seconds.

Screenshot before reopening the app

Screenshot after reopening the app

+1.same problem , version 0.55.3.
when I remove the SplashActivity, use MainActivity(ReactActivity) as the LAUNCHER activity, this only happened once if I open the app from the system install complete page , then click Home button, and then reopen the app from desktop.  (Manually installing a RELEASE app)
so maybe  add a SplashActivity can reproduce it easily?I haven't  tried yet.

Are you sure this is a React Native related bug and not an Android one? The series of steps you need to make to recreate this conditions seems to tell me that is something related to the Android OS (and prob device) you are testing on.
Could you:

test with a different version of Android
test with a different device
test with a 'fully native' Android test app

And report back?

wow ,I just fixed this issue by set the MainActivity( launcher activity and my ReactActivity) 's launchMode to singleTask in my situation.
then I did some more test and now I think it maybe a Android Bug or just the behavior !?
steps I did:
1 .create a simple  android native app the have a Bottom Navigation Activity.
2. "./gradlew assembleDebug",generate an apk and upload to the mobile's sdcard.
3.install it and open it from the install success page.
4. change the tab to tab 3 (as a indicator).
5. click Home button  and open it from desktop.
you will see the tab is at first position(default),then click Back button, you will see the tab  is at the  third position(step 4). so it must be that launch from the install success page and desktop started different  TaskStack.
and this also exist when installing via the Play Store too.


key error ['data-date']

Hey,
I know that it's been a while since the repo was updated for the last time but I am working on something similar now and wanted to base on your code.
When copying the GITHub activity code I get the error:
`Traceback (most recent call last):
  File "C:/Users/jakub.wabinski/OneDrive - Wojskowa Akademia Techniczna/Pulpit/Doktorat/Zatrudnienie/EPOS 2/Wizualizacja_kalendarz/Pycharm_GITHub.py", line 104, in <module>
    calmap(ax, year + i, github_contrib("rougier", year + i), origin="upper")
  File "C:/Users/jakub.wabinski/OneDrive - Wojskowa Akademia Techniczna/Pulpit/Doktorat/Zatrudnienie/EPOS 2/Wizualizacja_kalendarz/Pycharm_GITHub.py", line 43, in github_contrib
    parser.feed(contents)
  File "C:\Users\jakub.wabinski\anaconda3\lib\html\parser.py", line 111, in feed
    self.goahead(0)
  File "C:\Users\jakub.wabinski\anaconda3\lib\html\parser.py", line 171, in goahead
    k = self.parse_starttag(i)
  File "C:\Users\jakub.wabinski\anaconda3\lib\html\parser.py", line 345, in parse_starttag
    self.handle_starttag(tag, attrs)
  File "C:/Users/jakub.wabinski/OneDrive - Wojskowa Akademia Techniczna/Pulpit/Doktorat/Zatrudnienie/EPOS 2/Wizualizacja_kalendarz/Pycharm_GITHub.py", line 36, in handle_starttag
    date = dateutil.parser.parse(data["data-date"])
KeyError: 'data-date'`

When looking up the HTML file, this key actually exists in the data. Is the issue within a parser? I am not a programming expert so this might sound trivial to you...
Thanks in advance,
Jakub

For the GitHub activity, I'm parsing the HTML file and if GitHub changed their format, this might be the problem. If the key is still here then the problem might be with the parser. Best would be to play with github_contrib(user, year): or to find a new way to get the same info.


Generate and Add all code's link [OPEN FOR ALL]

In all the .md files where there is a whole code, Copy that code, Paste it in GFG IDE, Run and Generate URL, Add a new section in that .md file naming 'Run Code' and paste the link in that section.
Do this for all the code that are fully written.

I'd like to work on this

Hey, what should i do with files that don't have the main function and the structures set up (e.g. this)

Hey, what should i do with files that don't have the main function and the structures set up (e.g. this)

Leave the Hackerrank section as Hackerrank provides all the functions in it's IDE!
But do it for codeforces folder.


ConvertToMultiChannelBasedOnBratsClassesd might be wrong

Describe the bug
This Class ConvertToMultiChannelBasedOnBratsClassesd is used in brats_training_ddp.py and brats_segmentation_3d.ipynb. It may map the label data to wrong classes. According to its docstring,  it describes that label 2 is the GD-enhancing tumor, and label 3 is the non-enhancing tumor core.

However, the json file in this downloaded dataset describes that label 2 is the non-enhancing tumor and label 3 is the GD-enhancing tumor.
To Reproduce
Download the dataset by from the official website or call monai.apps.DecathlonDataset(task="Task01_BrainTumour"). Find the dataset.json.

Expected behavior
N/A
Screenshots
I also visually verified labels. It seems like json file is right. label 2 should be the non-enhancing tumor and label 3 should be the GD-enhancing tumor.

Environment (please complete the following information):

OS
Python version
MONAI version [e.g. git commit hash]
CUDA/cuDNN version
GPU models and configuration

Additional context
Add any other context about the problem here.

agreed, it seems this version of the transform is correct https://github.com/Project-MONAI/MONAI/blob/a1c437111a511d17dcd0e04d491747f6677f4def/monai/transforms/utility/array.py#L1078-L1086 which is not needed for the dataset used in the tutorials. however we can still use this as an example of customized transforms, with revised docstrings cc @Nic-Ma @myron

If this is true, it seems like quite a significant problem. Not sure how it was written wrong in the monai transforms.

Should be fixed in https://github.com/Project-MONAI/MONAI/pull/8246.
@guopengf, please help confirm, thanks!


Add option to disable font override (#556)

I agree with https://github.com/sindresorhus/refined-github/issues/556 cause I prefer the new default SF Mono than Fira Code (which was the one I had with the extension)

@busches the current css rule would still be there as the default. If the user unchecks that option, it would just override them with the class default-fonts.
I'm not sure what you mean by the font order from the current rule, I didn't change it.

Ok, I think I misunderstood the implemention. You're allowing the override
and then essentially undoing it? Wouldn't it be easier to only apply the
font override when the option is checked? Right now if GitHub changes the
default font options we'd have to make code changes too.
On Jul 4, 2017 4:28 PM, "Pablo Varela"<EMAIL_ADDRESS>wrote:

@busches https://github.com/busches the current css rule would still be
there as the default. If the user unchecks that option, it would just
override them with the class default-fonts.
I'm not sure what you mean by the font order from the current rule, I
didn't change it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sindresorhus/refined-github/pull/569#issuecomment-312957540,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0WZNbfcEiMekuZO_jnk8uSy8UGwOvXks5sKq5hgaJpZM4ONqTt
.

Yeah, I guess that makes more sense. I'll just add a .override-fonts class that would only be added when the option is selected.

Note my comment in #556

Either we drop it altogether or we disable it by default and add a font and font size option.

I'd like to have the option to use Fira Code as font.

@sindresorhus if it's disabled by default and we leave the choice to the user, should it be part of Refined GitHub at all? How would that be different from just leaving it to a stylesheet?

@bfred-it I think it would make more sense as a separate extension that works on code blocks on any website, not just GitHub.

Perfect, then:

I guess we should close this then?


added encode_json support plus test

Codecov Report

Merging #60 (a2b7d06) into main (ada5811) will increase coverage by 0.92%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   52.23%   53.15%   +0.92%
==========================================
  Files          26       27       +1
  Lines        1411     1426      +15
==========================================
+ Hits          737      758      +21
+ Misses        641      634       -7
- Partials       33       34       +1

Flag
Coverage Δ

unittests
53.15% <80.00%> (+0.92%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/pipeline/encode/encode_json.go
80.00% <80.00%> (ø)

pkg/pipeline/encode/encode.go
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada5811...a2b7d06. Read the comment docs.

I changed the name of the files to encode_json_to_string. The input is json (configMap), but the difference is that it outputs a string for each configMap. There is no API detail needed since there are no parameters that the user needs to provide.

In light of our discussion, I changed the name back to encode_json.go.
I also added a few sentences in the README to document the json encoder.


Undefined define constants error when --pool=forks

Describe the bug
I attempted to set --pool='forks' to debug some hanging tests that I've been having intermittently, and started to get a few test failures about global constants not being defined.  I'm guessing it's a consequence of running the tests using child_process, but it surprised me a bit nonetheless.
I'm not sure if anything can be done to address this from vitest, but it might be worth at the very least adding a note in the documentation to clarify that define values should not be undefined?
Reproduction
https://github.com/IanVS/reproduction-vitest-define-pool-forks
System Info
System:
    OS: macOS 14.0
    CPU: (12) arm64 Apple M2 Max
    Memory: 1.81 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/Library/Caches/fnm_multishells/35181_1708624240853/bin/node
    Yarn: 1.22.19 - ~/Library/Caches/fnm_multishells/35181_1708624240853/bin/yarn
    npm: 9.5.1 - ~/Library/Caches/fnm_multishells/35181_1708624240853/bin/npm
    pnpm: 8.8.0 - ~/Library/Caches/fnm_multishells/35181_1708624240853/bin/pnpm
  Browsers:
    Safari: 17.0
  npmPackages:
    vite: ^5.1.4 => 5.1.4
    vitest: ^1.3.1 => 1.3.1

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

The difference between these two pools is that child_process uses node:v8.deserialize when it's passing the configuration to worker. It seems to lose objects with undefined values - similar as JSON.stringify does. If you change the configuration to define: { __GLOBAL__: 123 } you can see that it is passed.
We already have some work-arounds when passing regexps to test runners through node:v8.deserialize. I think similar approach could be used here.


Slow dropdown with hundreds of options

The dropdown becomes slow in interactions when there are hundreds of options.
How can i solve this issue?

Option 1 (easy):
You can use "limit: 30" the number of entries to 30, then use "searchable: true" to enable searching, filter out results from local array with the "@search-change" event
Option 2 (hard):
Create virtual scrolling with DOM manipulation within dropdown menu

Hi,
thanks for your reply.
How can I perform Option 2?
Il giorno ven 19 nov 2021 alle ore 15:45 Zeeex @.***>
ha scritto:

Option 1 (easy):
You can use "limit: 30" the number of entries to 30, then use "searchable:
true" to enable searching, filter out results from local array with the
@.***" event
Option 2 (hard):
Create virtual scrolling with DOM manipulation within dropdown menu
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vueform/multiselect/issues/165#issuecomment-974132520,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMQA4VGNUS7AR5TKXDNP6TUMZPI3ANCNFSM5IKBET3Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Duplicate #76.

Added infinite scroll in 2.4.0. Here's an example:
https://github.com/vueform/multiselect#load-async-options-from-api-on-open-with-infinite-scroll


Update license dates

Coverage remained the same at 83.486% when pulling eea373a6d6e33cc9bbae14ad4daa07d24de61c66 on update-license-dates into a5ed6641ca2ceb2544d41f73e78d4dbfe791c55b on master.


Chrome issue with jumpy navbar-text.

Go to http://output.jsbin.com/vukoxa/2/ (or http://jsbin.com/vukoxa/2/edit?html,output to be able to edit)
Decrease width until menu collapses into hamburger.
Increase width again.
The navbar has now a second row with the nav-bar text (description) being there instead of its old position.

Reproducible under newest stable Chrome but not Firefox or IE under Windows.
HTML5 validation and bootlint passed.

Image illustrating the issue:

I've looked into it, and it seems that there are different width's calculated ->

min-width: 170px; helps for the beginning.

@fokusferit It's because, when collapsed, the .navbar-heading becomes display: table.
@Herst You have some options, as explained in #11539:

Change the grid float breakpoint so that the navbar stays collapsed until the screen is wide enough for your .navbar-text.
Use the responsive utility classes to hide some parts of the navbar at narrower screen widths so that it fits at those widths
Rework your content's width
You can also override the .navbar-text to float the text, though, depending on the width of your text, you will need to explore the above options, as well.

Closing per @zacechola's suggestions. Not much we can do here otherwise I think.

Thank you, adding "float: left" really solved it from me and from what I can see even setting an absurdly long description (in my case the user can set it) leads to an acceptable result.


UI: responsive hero banner

I keep banner height full-screen  for all screens:
--bannerHeight: calc(100vh - var(--headerHeight) - var(--marginBottom));

I see in the original UI it takes around 50vh from $tablet-width to $desktop-width

I decided to fit it to screen, because I don't know what height to take. I think it should depends on some tablet dimensions to look good. To keep it stretched much easier and looks good.


[FEATURE] Allow to reset response value when status!=submitted

Is your feature request related to a problem? Please describe.
Right now it's not possible to remove a response (when updating the responses values using PUT /api/v1/responses/{response_id}) for certain question and record. It would be useful to have this feature, as the user may want to clean up the responses of a record with draft status to get the suggestions back.
If the question doesn't have any value in the form (after clearing the responses for example), the frontend could send "value": null, so the backend would be able to remove the response for a question. This way, if the page is refreshed in the frontend, it will receive no responses and it would be able to show the suggestions again.
Describe the solution you'd like
The input payload of the PUT /api/v1/responses/{response_id} endpoint can be (if status!=submitted):
{
    "values": {
        "my-question": {
            "value": null
        }
    },
    "status": "draft"
}

Additional context
This case was reported by @keithCuniah :)

Why we need to do that?

We don't need it @damianpumar . The clear does not reload the suggestion.


Snowflakes don't have raindrop sound [Missing Feature/Bug]

Hello! The raindrop/snowflake sound is /playsound random.levelup @a 0 0 0 1 1.5 1, please add in the plugin.

It is in the plugin. Can you try /toggle sounds, make sure it is on, and try again?

Make sure you are using the most recent version of Cardinal.


Combined Chart - Position of line chart in the middle of bar chart

Hi,
I have the combined chart with one bar and line chart.
The line chart value is displayed on the next to the each bar. I want to display in middle of the bar. Attached is the screenshot am looking,
Thanks for your support

any update on it ?


Unresolved import for dotnet assembly references in Python Project.

Repro step:
1.Create a C#  file named ClassLibrary.cs and typing code:
namespace ClassLibrary1
{
public class Class1
{
public string X
{
get { return null; }
}
    public static void Fob() {
    }
}

}
2.Compile ClassLibrary.cs as ClassLibrary.dll in C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework.NETFramework\v4.0
3.Open VS and Create a python application project named PythonApplication1
4.Right-click References and select Add reference...->Assemblies
5.Check the ClassLibrary is selected and then click OK.

6.Open PythonApplication1.py and typing code like below:
from ClassLibrary1 import Class1
Except result: we can import ClassLibrary without no warning and errors
Actual result: unresolved import 'ClassLibrary1'

Version:

We don't have completions anymore on .NET types, as in https://github.com/Microsoft/PTVS/issues/5027

We don't have completions anymore on .NET types, as in #5027

@huguesv Does it mean you no longer support autocomplete on .NET?  Or it is going to be fixed?

@ccc159 we haven't excluded the possibility of fixing it, but the language server team have more common scenarios that have priority right now.


Draft for server side validation of option values

It would be good to have server side validation of options the same way we do server side validation of required.
Unfortunately it was harder than expected, so I'll just leave it here if anyone want to have a starting point.

Were not keeping PR open as a starting point


RAINCATCH-451: Update to use new simple store module

What
Update group and membership router to use with the new simple store module. Added missing id field in the post route needed by the new simple store module.
JIRA Ticket
https://issues.jboss.org/browse/RAINCATCH-451

LGTM

@JameelB, @nialldonnellyfh think do we need some unit tests for this?


DoctorsNow Iowa - Onboarding

Standard Tasks / Onboarding Steps:
Kickoff Meetings/Follow Up:
Solution Planning:
- Mapping
- Brainstorming/Grooming
- Complete RS Solution Feature Request (if needed)
Solution Development:
- RS Schema
- Other Dev (VBScript, etc)
Solution Testing:
- Staging
- Prod/Test
- RS Feature Request (if needed)
- Sender Acceptance w/ Client Signoff
Solution Implementation:
- Plan & Schedule Go Live
- GO LIVE and Post LIVE Review

Per Ming, Iowa is currently ON HOLD. She has requested that we please hold in reaching out to the DoctorsNow contact.


Investigate moving to a new web framework

Iron is no longer actively maintained. Now is when we can see if our architecture separation pays off or not...
How can I help?
In order of difficulty from easy to hard...

👍 or 👎 a comment for a framework that you like or dislike for any reason.
Let us know of a web framework that's worth investigating that we don't have listed.
Add a comment if you research one or more of the requirements for a framework.
Attempt porting the playground to a framework and push up a branch.

What are you looking at?

Actix web
Gotham
Thruster
Tide
Tower Web
Warp
Axum

Requirements

Caching

Aggressive caching
Fine-grained caching (index.html vs assets)

Static file serving

Modification time checking
No path traversal
Side-by-side pre-compressed files
Automatic content-type assignment

Redirection of HTTP to HTTPS (optional)
Basic off-request access logging (url, ip, status, start, duration)
Routing

With path variables

URL rewriting
CORS
JSON body parsing / response

Caching
The playground serves up index.html and a few other similar files that never change name. These should ideally use something like ETags with a short-ish expiry. We currently use a 1 hour expiry, but not ETags.
The assets are all in a path called /assets. These all have a digest hash appended to them, so they can be cached "forever". In practice, this is 1 year.
There's a few other pieces of information that could use caching (e.g. the playground crates, channel versions) but these are all generated data and so we could pre-compute an ETags identifier to check against.
Access statistics

Roughly 2 requests per second

Gotham

Static file serving not present/complete https://github.com/gotham-rs/gotham/issues/55
CORS not present/complete https://github.com/gotham-rs/gotham/issues/119

did you consider actix ?

@fafhrd91 I have not really considered it. Speaking plainly, your incessant advertising of actix in almost every place I read about Rust (Gitter, Reddit, Hacker News, etc.) makes me less inclined to try it. I, so far, have no technical opinions about it and haven't ruled it in or out.

fair point. in that case Gotham is better choice I guess.

Tower Web
To be determined...

Warp
To be determined...

Actix web
To be determined...

Thruster
To be determined...

Tide
To be determined...

Axum
To be determined...

I've merged in an implementation using Axum. As of a few hours ago, I've enabled the Axum feature flag on play.rust-lang.org. Assuming nothing drastic happens that cannot be fixed, I'll eventually move completely over.

Closed in #799


Issues with toolbar

I've found some issues with the toolbar.
Search is buggy
Test link: https://liascript.github.io/course/?https://raw.githubusercontent.com/liaScript/docs/master/README.md#1
Just type in Tools (it's the second header after the start page). It can't be found. It seems that the search only goes through the paragraphs and not the headings?
Delete search terms with an X
If I'm searching for stuff the navigation reduces itself to the pages that may contain my search terms. This is okay but it leads to the problem that when I want to get back to the normal navigation overview I have to delete my search term. A simple X at the end of the search bar could be added to instantly delete the current search terms and to get back to the normal view.
Buttons
The buttons for burger menu, index, previous and next page and also mode are very small. They are barely 'readable'. Also this is a problem on mobile devices but I'll discuss this in another issue.
Despite the small size their width seems to be variable. They don't have a static ratio like quadratic or 16:9 or whatever. Instead their width differs a lot an so the click area does. See here for reference:

Index
I was confused about the home button. I thought it would bring me to the first page but I got to my own Index page (UX problem). I tried to get back but the back button is not working there (UX). Maybe another symbol could be used for the Index page? Or it could be moved down - left side of the user settings button. This would make it more clear that this button has nothing to do with the current course.

Yes, this was definitely a bug, and the X button was a good point ... at the next version, I hope, I will integrate a better inbrowser search such as lunr.js...


Invalid unknown type XXX error when there are cycle via record field

Description:
public type Bdd Node|boolean;

public type Node readonly & record {|
    *R; // When this type-reference is removed, this works fine.
    int atom;
    Bdd left; // unknown type 'Bdd'(BCE2069)
    Bdd middle; // unknown type 'Bdd'(BCE2069)
    Bdd right; // unknown type 'Bdd'(BCE2069)
|};

type R record { };

Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

This is already fixed