Fix dropping persistent damage links on character and NPC Sheets

Closes #7223
Intercepts the drop at the creature level so both characters and NPCs benefit from the fix.

We already have handling for this somewhere, but I don't see this deleting any code. What happened to it?

The only handling I saw was a hook for dropping PersistentDamage on tokens, where I cribbed most of the code from.

Someone can correct me but this seems more like a enhancement than a bugfix. It seems like this never worked before. I thought I made this work at one point but I guess not.

Looking at the issue, they're expecting damage-roll links to be droppable. I have some doubts about this since a damage roll can have persistent damage along with anything else. These aren't content links but roll links.

They are already droppable on tokens (not sheets), but if we don't already, mixed damage stuff should be ignored. Its more of a feature that is expected to exist, rather than a break of existing functionality.
This has kinda become more complicated than expected. I can take this off your hands.

I don't see the benefit of this at all.


Validate control tech in DE API

Definition of Ready

[ ] Does this meet the INVEST criteria?
[ ] Does this have a clearly defined user?
[ ] Does this have an estimate?
[ ] Does this have acceptance criteria?
[ ] Does this have sufficient context (wireframes, business rules, etc.)?
[ ] Is this traceable to a feature, epic, or PI?

User Story
As a CAMPD user I want enter valid filter criteria control technologies so that I can see results for my specified control technologies
Acceptance Criteria
Given that a user has entered one or more control technologies in an upper-case or lower case format
When the API endpoint is executed
Then the system displays the records that match the criteria (containing data elements below)
Given that a user has entered one or more control technologies without white space(s) before or after the delimiter
When the API endpoint is executed
Then the system displays the records that match the criteria (containing data elements below)
Given that a user has entered one or more  control technologies with white space(s) before or after the delimiter
When the API endpoint is executed
Then the system displays the records that match the criteria (containing data elements below)
Given a user has entered an invalid parameter for control technology
When the error message is displayed
Then the error messages contain a url to the end point to find the correct data
fv-3 One or more control technologies are not valid. Refer to the list of available control technologies for valid values [placeholder for link to endpoint]"
Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
Send valid and invalid values
Validate the values
If ANY invalid value, give error message for each invalid value and query stops
If ALL values are valid, return results
Data Elements
Results:
When the system identifies at least one record that matches the criteria, then for each record the system will display:
STATE
FACILITY_NAME
ORISPL_CODE
UNITID
ASSOC_STACKS
OP_DATE
SUM_OP_TIME
COUNT_OP_TIME
GLOAD
SLOAD
SO2_MASS
SO2_RATE
NOX_MASS
NOX_RATE
CO2_MASS
CO2_RATE
HEAT_INPUT
PRIMARY_FUEL_INFO
SECONDARY_FUEL_INFO
UNIT_TYPE_INFO
SO2_CONTROL_INFO
PART_CONTROL_INFO
NOX_CONTROL_INFO
HG_CONTROL_INFO
PRG_CODE_INFO
Testing
Test Case:
Tester:
Definition of Done

[ ] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[ ] Has the code been unit tested and peer reviewed?
[ ] Have the functional tests been executed?
[ ] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Has the user story been accepted by the Product Owner?
[ ] Is the user story ready to be deployed to the test/staging environments?

During sprint planning on 3/17, the team decided to complete the DE API by creating tickets #967, #968, #969, #970


Documentation

Codecov Report

Merging #72 (f9e5327) into master (03630d8) will not change coverage.
The diff coverage is 40.00%.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   19.73%   19.73%
=======================================
  Files          29       29
  Lines        1566     1566
  Branches      176      176
=======================================
  Hits          309      309
  Misses       1196     1196
  Partials       61       61

Impacted Files
Coverage Δ

...a/com/gio/calendar/database/ConnectionManager.java
46.15% <ø> (ø)

src/main/java/com/gio/calendar/models/Person.java
78.94% <0.00%> (ø)

...rc/main/java/com/gio/calendar/models/Reminder.java
29.62% <ø> (ø)

src/main/java/com/gio/calendar/models/Tag.java
68.42% <0.00%> (ø)

.../calendar/persistance/CalendarEventRepository.java
15.62% <ø> (ø)

...o/calendar/persistance/CalendarNoteRepository.java
0.00% <0.00%> (ø)

...m/gio/calendar/persistance/ReminderRepository.java
0.00% <ø> (ø)

.../calendar/scheduling/EarliestPossibleHeuristc.java
64.00% <ø> (ø)

...io/calendar/scheduling/LatestPossibleHeuristc.java
64.00% <ø> (ø)

...endar/scheduling/LeastNumberOfEventsHeuristic.java
73.07% <ø> (ø)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03630d8...f9e5327. Read the comment docs.


fix: Update sync script to sync missing fields.

The frontend team noticed some data missing from the v2 api. I wrote a script to check for empty db columns, and updated the sync script to make sure we're copying over the missing data.

Thanks!


The final "end" is not separated from the code with a space

As mentioned in the title.
For example if you execute x=1, which is independently valid Lua code, the resulting code will contain e.g. 1end which is invalid.

Thank you for the report.

I don't see how the final end would not be separated. There is an explicit ~ between \l_tmpa_tl and end:
https://github.com/Witiko/lt3luabridge/blob/afcb9ed531de7f142f6181ec890e1abcc7861400/lt3luabridge.dtx#L508-L512
Closing the report as invalid.

Common TeX trap, in \l_tmpa_tl~ the ~ despite what it looks like will be absorbed by the control sequence name.
Just try executing x=1 with the package.

Ok, let's test this.

@user202729 Should be fixed by #14. Thanks again for the report and sorry for incorrectly dismissing it.


Unique visitors not working (Remix)

Just trying out the community edition and running into an issue where unique visitors are always 1. I'm running Remix and using this guide: https://rogerstringer.com/blog/proxying-plausible-in-remix
This was working properly when using the hosted version. I'm also running a Next.js site on the same install, and it's working properly.
Any ideas why unique visitors are stuck? Other events like page views update correctly.

👋 @zamson
Would you be able to share your docker-compose.yml and plausible-conf.env files, with secrets redacted? Do you use any reverse-proxies or services like Cloudflare?

// docker-compose.yml
services:
  plausible_db:
    # Plausible v2.1.1 was tested against PostgreSQL versions 15 and 16
    # https://github.com/plausible/analytics/blob/v2.1.1/.github/workflows/elixir.yml#L21-L32
    image: postgres:16-alpine
    restart: always
    volumes:
      - db-data:/var/lib/postgresql/data
    environment:
      - POSTGRES_PASSWORD=postgres

  plausible_events_db:
    image: clickhouse/clickhouse-server:<IP_ADDRESS>-alpine
    restart: always
    volumes:
      - event-data:/var/lib/clickhouse
      - event-logs:/var/log/clickhouse-server
      - ./clickhouse/clickhouse-config.xml:/etc/clickhouse-server/config.d/logging.xml:ro
      - ./clickhouse/clickhouse-user-config.xml:/etc/clickhouse-server/users.d/logging.xml:ro
    ulimits:
      nofile:
        soft: 262144
        hard: 262144

  plausible:
    image: ghcr.io/plausible/community-edition:v2.1.1
    restart: always
    command: sh -c "sleep 10 && /entrypoint.sh db createdb && /entrypoint.sh db migrate && /entrypoint.sh run"
    depends_on:
      - plausible_db
      - plausible_events_db
    ports:
      - <IP_ADDRESS>:8000:8000
    env_file:
      - plausible-conf.env

volumes:
  db-data:
    driver: local
  event-data:
    driver: local
  event-logs:
    driver: local

// plausible-conf.env
BASE_URL=https://plausible.mydomain.com
SECRET_KEY_BASE=3y5pfCKeHxxjl769RTAAclU+5CCsGNTygCfmPetymgdoFmVNcB7rLiIJEzB3qsil
TOTP_VAULT_KEY=Q0GMYRl3W0RBWfXo0fPllquklTppA7WE99MSdGCDCE0=
# Email
<EMAIL_ADDRESS>SMTP_HOST_ADDR=email-smtp.eu-north-1.amazonaws.com
SMTP_HOST_PORT=587
SMTP_USER_NAME=x
SMTP_USER_PWD=x
SMTP_HOST_SSL_ENABLED=false
# Security
DISABLE_REGISTRATION=true

// nginx site config
proxy_cache_path /var/cache/nginx/data/jscache levels=1:2 keys_zone=jscache:100m inactive=30d use_temp_path=off max_size=100m;
server {
    server_name  plausible.mydomain.com;

    access_log  /var/log/nginx/plausible.access.log;
    error_log   /var/log/nginx/plausible.error.log;

    location / {
      proxy_pass http://localhost:8000;
      proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
      proxy_http_version 1.1;
      proxy_set_header Upgrade $http_upgrade;
      proxy_set_header Connection "Upgrade";
  }

  location = /api/event {
        proxy_pass http://localhost:8000/api/event;
        proxy_set_header Host plausible.mydomain.com;
        proxy_ssl_server_name on;
        proxy_ssl_session_reuse off;
        proxy_buffering on;
        proxy_http_version 1.1;
        proxy_set_header X-Forwarded-For   $proxy_add_x_forwarded_for;
        proxy_set_header X-Forwarded-Proto $scheme;
        proxy_set_header X-Forwarded-Host  $host;
    }

    listen [::]:443 ssl ipv6only=on; # managed by Certbot
    listen 443 ssl; # managed by Certbot
    ssl_certificate /etc/letsencrypt/live/plausible.mydomain.com/fullchain.pem; # managed by Certbot
    ssl_certificate_key /etc/letsencrypt/live/plausible.mydomain.com/privkey.pem; # managed by Certbot
    include /etc/letsencrypt/options-ssl-nginx.conf; # managed by Certbot
    ssl_dhparam /etc/letsencrypt/ssl-dhparams.pem; # managed by Certbot

}
server {
    if ($host = plausible.mydomain.com) {
        return 301 https://$host$request_uri;
    } # managed by Certbot

    listen       80;
    listen       [::]:80;
    server_name  plausible.mydomain.com;
    return 404; # managed by Certbot
}

I don't use Cloudflare's proxy; it's set to DNS-only mode. The site in question is a Shopify store hosted on Oxygen, built with Shopify Hydrogen (which is based on Remix). What's strange is that "current visitors" and page views are being recorded correctly, but unique visitors aren't, and sometimes UTM tags are also not being tracked.
My other site, which is running Next.js on the same Plausible account (using next-plausible), is working as expected. This makes me think the issue might be related to the implementation in Remix. However, the same approach was working properly in Remix when using the hosted version of Plausible.

Removing the script proxy and adding the script normally solved the issue


Enhancing Ascend 910A Training Efficiency in LlamaFactory with NPU

What does this PR do?
The training efficiency of the Ascend 910A has been significantly enhanced by leveraging the full computational power of the NPU and the capabilities of torch_npu. This enhancement has led to a remarkable tenfold increase in training efficiency.

We should first check if the torch_npu package available, such as
https://github.com/hiyouga/LLaMA-Factory/blob/d6ca7853faf083a7ff5c60feb940983d2577326d/src/llmtuner/chat/vllm_engine.py#L11-L14

We should first check if the torch_npu package is available, such as
https://github.com/hiyouga/LLaMA-Factory/blob/d6ca7853faf083a7ff5c60feb940983d2577326d/src/llmtuner/chat/vllm_engine.py#L11-L14

Alright, so it looks like VLLM doesn't support Ascend. No worries, I'll just tweak the code a bit and see if I can get it working.

We should first check if the torch_npu package is available, such as
https://github.com/hiyouga/LLaMA-Factory/blob/d6ca7853faf083a7ff5c60feb940983d2577326d/src/llmtuner/chat/vllm_engine.py#L11-L14

Yeah, I think updating the docs for now and letting the devs figure out how to handle it could be a good way to go. Just make it clear in the documentation that VLLM and Ascend aren't playing nicely together at the moment. That way, the developers can see the issue straight away and decide for themselves how they want to tackle it, based on what works best for their specific project.

It now works, LGTM


Cannot find case folder or case folder is not loading properly.

Typically this can happen if you have multiple folders that you have your images stored in.
Problem:

Case folder is not loading.
Case folder is not present.

Solutions:

More than likely the folder is loaded. If you get the message "Case loaded successfully". If not, then the folder might be corrupt and will need to create a new one.
You can create a new folder by clicking on the "create case folder" button.


Add support mono reference assemblies folder.

Add support mono reference assemblies folder passed through /p:TargetFrameworkRootPath parameter in .NET Core MSBuild. Now it doesn't work because of TargetFrameworkDirectory XML element under IsMono flag.

@rainersigwald @radical Ready to review.

Mono supports the RedistList/FrameworkList.xml files having a TargetFrameworkDirectory attribute which can specify a different directory where the assemblies can be found.

IIUC, this patch is trying to make that a msbuild proper feature. Is that correct?

I'm not sure what you mean by Add support mono reference assemblies folder passed through /p:TargetFrameworkRootPath. Setting TargetFrameworkRootPath would allow you to set the path where it should be looking for the frameworks (and thus the FrameworkList.xml files). So, setting that shouldn't be related to the TargetFrameworkDirectory. Please correct me if I missed something or am wrong.

Could you please share details of the use case that you are trying to solve?

Just in case this might be helpful, msbuild allows fallback paths for looking up target frameworks also. https://github.com/microsoft/msbuild/commit/f4dd0c94608633ffa6bf000b9ab3ae6741fd8e00
Add $(TargetFrameworkFallbackSearchPaths) for looking up target

.. frameworks. This contains ';' separated list of paths. When
`GetReferenceAssemblyPaths` task will look for assemblies corresponding to a
target framework, then it will try to find it in multiple locations:

	1. $(TargetFrameworkRootPath) or the default path if
	$(TargetFrameworkRootPath) is ''

	2. Each path in $(TargetFrameworkFallbackSearchPaths)

You can setup these extra paths with /p:TargetFrameworkFallbackSearchPaths=... or set them in a project file.

@radical  The main goal of this patch: allows building full-framework project with mono reference assemblies. Before it was logic to pass through TargetFrameworkDirectory hidden behind condition IsMono and not working on .NET Core. In this patch, I drop IsMono condition and we have the same logic on all platforms. Also, it fixed test marked as failed on Mono. Logic with "TargetFrameworkFallbackSearchPaths"  not applicable in this case because not contains correctly selection based on the target framework name.

Ah, ok. So, you want to build a full framework project against mono's framework assemblies, using .netcore msbuild. I'm not sure what the thinking is on supporting this kinda scenario. And if it is, then whether it should be supported like this.
@rainersigwald @marek-safar @akoeplinger ^

@livarcocc @kathleendollard should also weigh in on the building using-mono-framework-assemblies using netcore MSBuild scenario.

@radical Yes, it's not the default behaviour. It's work only with parameter: TargetFrameworkRootPath same as on the full framework. And also it reduces a difference in code between mono or non-Mono.

Any news?

Thank you for the PR. Neither we nor the Mono team currently have plans to support targeting Mono from .NET Core or .NET Framework MSBuild. We are not planning to take this change, since it's likely just the first in a list of things that would need to change to fully support that scenario.


⚠ Bofrost.fr has degraded performance

In bf1ff01, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1156 ms

Resolved: Bofrost.fr performance has improved in 3f8d2ba after 8 minutes.


Error in documentation for SpinWeightedSpheroidalHarmonicS for s=0

In SpinWeightedSpheroidalHarmonicS.md, the line
"For s=0, SpinWeightedSpheroidalHarmonicS[0, l, m, [Gamma], [Theta], [Phi]] is equivalent to Sqrt[(2 l + 1)/(4 [Pi])] Sqrt[(l - m)!/(l + m)!] SpheroidalPS[l, m, I [Gamma], Cos[[Theta]]]."
should also state that the condition phi=0 is needed as well.

This has now been fixed, thanks for the report.


Editor.renameOnType: true

This works only on html but not on jsx, I dunno about vue though since I never used it.

VSCode Version: 1.44
OS Version: windows

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No

/duplicate of https://github.com/microsoft/vscode/issues/94316
It's implemented only for HTML at this point.
JSX requires additional work as described in linked issue. Vue extension would need to implement support when API is finalized.


Missing textures in z_ao_sa

Kubilus1:
With AO 0.6.1 working correctly, I have been getting texture errors in the simulator. The LOG.TXT generates the following:
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/162736_79472_BI18.dds.
1:02:25.453 E/SYS: MACIBM_alert: Some scenery textures could not be loaded.
1:02:25.453 E/SYS: MACIBM_alert: This may be an installation problem or you may have a damaged add-on scenery package.
1:02:25.453 E/SYS: MACIBM_alert: Please see the Log.txt file for a detailed list of missing files.
1:02:25.453 E/SYS: MACIBM_alert:
1:02:25.453 E/SYS: MACIBM_alert: C:/GitLab-Runner/builds/2dtum6M9/0/x-plane/design/source_code/core/ui/alrt.cpp:30
1:02:25.453 E/SYS: +-------------------------------------------------------------------------------
1:02:25.453 E/SYS: | Some scenery textures could not be loaded.
1:02:25.453 E/SYS: | This may be an installation problem or you may have a damaged add-on scenery package.
1:02:25.453 E/SYS: | Please see the Log.txt file for a detailed list of missing files.
1:02:25.453 E/SYS: |
1:02:25.453 E/SYS: | (alrt.cpp:30)
1:02:25.453 E/SYS: +-------------------------------------------------------------------------------
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40816_19920_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40720_19840_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40560_19872_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40672_19936_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40624_19856_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40672_20000_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40656_19856_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40768_19760_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40560_19856_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40736_19744_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40800_19792_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40560_19888_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40624_19888_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40576_19936_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40624_19984_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40816_19824_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40672_19856_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/162736_79456_BI18.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40656_19888_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40672_19904_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40752_19904_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40784_19776_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40560_19840_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40640_19920_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40560_19904_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40704_19888_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40752_19840_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40816_19904_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40624_19840_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40672_19888_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40720_19808_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40816_19840_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/162752_79472_BI18.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40624_19904_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40656_20000_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40736_19920_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40704_19856_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40816_19888_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40720_19888_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40800_19936_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40816_19856_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40560_19920_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40736_19824_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40720_19856_BI16.dds.
WARNING: we are missing the texture: Custom Scenery/z_ao_sa/textures/40752_19888_BI16.dds.
Where can I find or recover these textures? Do I have to reinstall all of South America again? Can I download the files that contain this information manually?
The error occurs north of position -50-080
Best Regards
carlos

This anomaly produces a square hole in an area north of the Chapelco airport (SAZY). Specifically, you can see the disaster at the Pucón airport (SCPC). Now there are the images with AO and without AO.
The small Pucón airport looks good in the version where AO is not running.

Now with AO running:

I attach a log.txt of the AO made exclusively for this report.
autoortho.log

It looks like there may be a problem with the South America downloaded setup files (the zips). I do not have SA installed but I might install it later on when I have some time to validate your problem and see what's what.
Your log shows you are using AO v0.6.1. You might give v0.5.1-3 a go since it doesn't have the misplaced tile issue. How does it look in other areas besides SAZY? I really like the diagnostics at the end of startup on that version though.

Jeff2122:
Chapelco (SAZY), the airport in San Martín de los Andes, Argentina, looks perfect. The problem occurs to the north, where a rectangular hole with water forms, as if it were a large rectangular lake, flattening everything. Specifically, the earth is removed.

Others Screenshots:

Verified. I loaded it up and sure enough, I get a huge problem with where water meets the land. I think I have read that this is a known issue with Ortho in XP12 in places. I have never seen it before but it sure is fugly. I am not at all sure how to handle it.
I will fly with default if there is no immediate fix.  I do not but am planning to tour South America soon in my Twotter.
Sorry I am of no help to you. Maybe @kubilus1 or another kind soul who knows a lot about ortho can look into this.

Jeff2122:
Thank you for your answers and your sincere collaboration regarding my problem. Surely this will allow Kubilus1 to improve the South American sector.
For me it is not a big problem because it allows me to fly the usual routes without inconvenience.
REgards
carlos

This is tracked here: https://github.com/kubilus1/autoortho-scenery/issues/20 - it has been a temporary problem during generation of that tile set and a regeneration will likely not have that problem. Until then you can download the .zip I posted there and place it higher than z_ao_sa.


Implement log rotation in docker-compose file

See https://github.com/input-output-hk/cardano-graphql/pull/197 for context

@rvl Good call, my assessment was based on my own config, so am now running the stack against NETWORK=mainnet for a few hours to determine a more suitable default.

cardano-node emits ~ 3.75MB per epoch on the mainnet, so the resulting mainnet sync from genesis emits around 750MB of logs within the first few hours. What's your preference here? Dedicating that chunk of disk seems unreasonable when all we're doing is fast-forwarding through time, with the relevance of old epochs having the same meaning. I expect critical errors in the sync should be on disk if it's needing to be debugged. To ensure the current and previous epochs, plus their transitions are included, I propose:
  max-size: "400k"
  max-file: "20"

The base for cardano-wallet is the clock check, 5mins apart:
cardano-wallet_1  | [cardano-wallet.ntp-client:Info:14] [2020-06-29 01:41:17.78 UTC] query to ntp client invoked
cardano-wallet_1  | [cardano-wallet.ntp-client:Info:14] [2020-06-29 01:41:18.93 UTC] local clock is drifting by -27088μs
cardano-wallet_1  | [cardano-wallet.ntp-client:Info:14] [2020-06-29 01:46:18.96 UTC] query to ntp client invoked
cardano-wallet_1  | [cardano-wallet.ntp-client:Info:14] [2020-06-29 01:46:20.17 UTC] local clock is drifting by -20103μs

Do you have a simulation that can provide some insight into the cardano-wallet logging behaviour, or is what I've submitted here satisfactory?

Can we just say that 500MB of logs is too much. Anything less than 500MB of logs is OK. This is 1/10th of the mainnet chain db size.
So make it 10 rotations of 50MB each. And also there is a log compression flag which may help reduce impact of logs: https://docs.docker.com/config/containers/logging/json-file/#options


Common usability questions

Hi, yes it is. Thanks, by writing this package. But i need help:
Why app get input appleID & passwd always?
How change production mode? ( CrossInAppBilling.Current.InTestingMode = false? )
Should i delete testing account by appstoreconnect when i real pay needed?
Thanks.

You should test things in a sandbox account on a real device. Please checkout the testing guidance I have outlined in the docs.


CI: fix sccache

remove unneeded scripts;
fix github deprecations;
fix sccache installation

It fails later it seems:
Compiling sccache v0.2.15
error[E0658]: use of unstable library feature 'matches_macro'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/sccache-0.2.15/src/compiler/compiler.rs:198:24
    |
198 |         let may_dist = matches!(dist_client, Ok(Some(_)));
    |                        ^^^^^^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/65721

error[E0658]: use of unstable library feature 'matches_macro'
    --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/sccache-0.2.15/src/compiler/rust.rs:1846:30
     |
1846 |         let can_trim_rlibs = matches!(
     |                              ^^^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/65721

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0658`.
error: failed to compile `sccache v0.2.15`, intermediate artifacts can be found at `/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cargo-installtQskuq`

Caused by:
  could not compile `sccache`.

To learn more, run the command again with --verbose.
Error: Process completed with exit code 101.

It fails later it seems:
Compiling sccache v0.2.15
error[E0658]: use of unstable library feature 'matches_macro'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/sccache-0.2.15/src/compiler/compiler.rs:198:24
    |
198 |         let may_dist = matches!(dist_client, Ok(Some(_)));
    |                        ^^^^^^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/65721

error[E0658]: use of unstable library feature 'matches_macro'
    --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/sccache-0.2.15/src/compiler/rust.rs:1846:30
     |
1846 |         let can_trim_rlibs = matches!(
     |                              ^^^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/65721

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0658`.
error: failed to compile `sccache v0.2.15`, intermediate artifacts can be found at `/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cargo-installtQskuq`

Caused by:
  could not compile `sccache`.

To learn more, run the command again with --verbose.
Error: Process completed with exit code 101.


Adds availability_type and crash_safe_replication variables.

At a glance, user_labels also needs to be added, but I'm not sure what form terraform expects the "set of key/value" in.


Link check READMEs into main README

Now that a few README.md files have been merged, add links from the master README to the individual check README files. Also move the BUILDING instructions to it's own BUILDING.md file to not clutter the master README with developer type information.

Resolved with PR #57


Get Started buttons are redirecting to a wrong link

The Get Started links redirecting to: https://docs.litmuschaos.io/docs/getstarted/
instead of https://docs.litmuschaos.io/docs/getting-started/installation/

Assigned the issue to appropriate people. Thanks @eran-levy for pointing it out.

Thank you for reporting the issue @eran-levy but updates to the current litmuschaos.io are mapped to this repository now.
We will archive this repository to avoid further confusion.


Support for updating the extension component in vue page

New Feature Proposal
For more information, see the CONTRIBUTING guide.
Description
When the count in the react component increases, the react extension will be updated. But in the vue component increases, the extension will not be updated.
Background
See the Repo.

Setup: yarn && cd src/samples/sample-piral-core && yarn start
Go to: http://localhost:1234/react and http://localhost:1234/vue

Discussion
piral-vue/src/extension.ts
    ...
    render(createElement) {
      return createElement(rootName);
    },
    watch: {
      params(oldValue, value){
        // Compare logic and update
      }
    },
    mounted() {
      this.piral.renderHtmlExtension(this.$el, {
        empty: this.empty,
        params: this.params,
        render: this.render,
        name: this.name,
      });
    },
    ...

Update extension by watching params property changes here?

Yeah sounds good to me. Mind doing a PR?

I'm happy to, but I encountered two problems:

I haven't thought about the logic of comparing the params property;
Don't understand the converters of other frameworks, such as piral-ng.

Well, for (1) shouldn't that be done by vue? Yes, if vue actually compares it "literally" (i.e., objects that change even though their content remains the same are considered changed) that may be inefficient, but for a first PR not a problem.
Regarding (2) there is no need. Just implement vue - other converters solve that issue (or don't solve that issue) already. The PR should be for vue alone to make that happen.
I think you've already suggested a way forward in the issue. Is there more needed for a first / simple solution?

Regarding (2) there is no need. Just implement vue - other converters solve that issue (or don't solve that issue) already. The PR should be for vue alone to make that happen.
Okey~

Well, for (1) shouldn't that be done by vue? Yes, if vue actually compares it "literally" (i.e., objects that change even though their content remains the same are considered changed) that may be inefficient, but for a first PR not a problem.
I think you've already suggested a way forward in the issue. Is there more needed for a first / simple solution?
Currently, data can only be transferred through the params attribute, so when multiple data needs to be transferred, it is necessary to compare the second-level properties of the params object. For example:

...
watch: {
  params: (oldValue, value) => {
    if(Object.keys(oldValue).length !== Object.keys(value).length){
        console.log('has changed');
        return;
    }
    for (let property in value) {
      if (value[property] !== oldValue[property]) {
        console.log('has changed');
        return;
      }
    }
    console.log('not changed');
    return;
  }
}
...

<extension-component name="ext-component-example" :params="counter" /> (counter = { count }) Changing the counter property does not trigger the watch.


Added the updated select/deselect mechanism

Fixes #131
Description
Updated the mechanism and texts for the given changes
Checklist:

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[x] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@DantrazTrev Since you have not added any tests, please uncheck the fourth checkbox under the PR checklist.


Why is VSCODE heavy, and consumes memory resources?

We have written the needed data into your clipboard because it was too large to send. Please paste.

/needsMoreInfo
Just in case - VSCode is build on top of Electron which brings Chromium and Node with their runtimes and memory consumption pattern.
If you have concrete concerns see https://github.com/microsoft/vscode/wiki/Performance-Issues


MacOS: headless UX improvements

Don't show the application in the dock or task switcher unless one of the following is true:

we create a non-headless display driver or
an alert must be shown

Superseded by https://github.com/godotengine/godot/pull/91149.


Don't show line number in 'help' files

vim or neovim?

[ ] vim
[x] neovim

Output of vim --version or nvim --version:

NVIM v0.4.3
Build type: Release
LuaJIT 2.0.5
Compilation: /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/tmp/neovim-20191107-85913-1wbgqz6/neovim-0.4.3/build/config -I/tmp/neovim-20191107-85913-1wbgqz6/neovim-0.4.3/src -I/usr/local/include -I/tmp/neovim-20191107-85913-1wbgqz6/neovim-0.4.3/deps-build/include -I/usr/local/opt/gettext/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include -I/tmp/neovim-20191107-85913-1wbgqz6/neovim-0.4.3/build/src/nvim/auto -I/tmp/neovim-20191107-85913-1wbgqz6/neovim-0.4.3/build/include
编译者<EMAIL_ADDRESS>
Features: +acl +iconv +tui
See ":help feature-compile"

     系统 vimrc 文件: "$VIM/sysinit.vim"
         $VIM 预设值: "/usr/local/Cellar/neovim/0.4.3/share/nvim"

Run :checkhealth for more info

Output of :echo has("python"):

0

Output of :echo has("python3"):

1

Output of :py3 print(sys.version):

3.7.4 (default, Sep 24 2019, 17:13:17)
[Clang 10.0.1 (clang-1<IP_ADDRESS>)]

Operating system:

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Configurations related to LeaderF in vimrc:

set number
call plug#begin('~/.vim/plug')
Plug 'Yggdroot/LeaderF', {'do': './install.sh', 'on': 'Leaderf'}
call plug#end()

Describe your question, feature request, or bug.
Normally the 'help' file should be open without line number,
But the line number appears if it is open by Leaderf help
Steps to reproduce

Open neovim
:Leaderf help
search any keyword and open it

Actual behaviour
The help file will be open with line number
Expected behaviour
The help file will be open without line number

This issue is due to a bug of nvim(https://github.com/neovim/neovim/issues/11525) and my workaround(https://github.com/Yggdroot/LeaderF/commit/0534ddd138f5f8f6850948f6f20eb8224cb18fe3) for it. Can only be fixed until https://github.com/neovim/neovim/issues/11525 is fixed.


Tournament.get_final_ranking() appears to not work

  File "/home/luci/Purah-Cogs/tournaments/tournaments.py", line 889, in end_to
urnament
    ranking = await tournament.get_final_ranking()  # type: dict
  File "/home/luci/purahenv/lib/python3.7/site-packages/challonge/tournament.p
y", line 783, in get_final_ranking
    return OrderedDict(sorted(ranking.items(), key=lambda t: t[0]))
TypeError: '<' not supported between instances of 'NoneType' and 'int'

No clue what I'm doing wrong. This is after I called Tournament.finalize(), and it worked (and I ignored the challonge.APIException, see #5 for details on that), and I made sure it worked by checking on Challonge.

Does it happen every time? It seems to run fine on my tests so far...


Follow up on handling dependency interface in provider

With the new external providers work, all providers need to implement dependency interface functions even though they don't have the capability. Maybe we dont care, maybe we want to change how that's done, let's get back to it later.

I think the current contracts are fine. Closing this, not really an issue.


python36Packages.xdot: 0.9 -> 1.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.6-xdot/versions.
meta.description for python36Packages.xdot is: '"xdot.py is an interactive viewer for graphs written in Graphviz's dot"'.

Checks done (click to expand)

built on NixOS
/nix/store/w9zic272hvyc4x2z5hwl5ai4z29jfj3p-python3.6-xdot-1.0/bin/xdot passed the binary check.
Warning: no invocation of /nix/store/w9zic272hvyc4x2z5hwl5ai4z29jfj3p-python3.6-xdot-1.0/bin/..xdot-wrapped-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/w9zic272hvyc4x2z5hwl5ai4z29jfj3p-python3.6-xdot-1.0/bin/.xdot-wrapped had a zero exit code or showed the expected version
1 of 3 passed binary check by having a zero exit code.
0 of 3 passed binary check by having the new version present in output.
found 1.0 with grep in /nix/store/w9zic272hvyc4x2z5hwl5ai4z29jfj3p-python3.6-xdot-1.0
directory tree listing: https://gist.github.com/88ba4eda516bbac727fc5047a6b774c0
du listing: https://gist.github.com/e079ec55b21c6cb4ed445a802af80be3

Outpath report (click to expand)

Outpath difference report
4 total rebuild paths
1 package rebuilds
1 x86_64-linux rebuilds
1 i686-linux rebuidls
1 x86_64-darwin rebuilds
1 aarch64-linux rebuilds
First ten rebuilds by attrpath
python36Packages.xdot

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/w9zic272hvyc4x2z5hwl5ai4z29jfj3p-python3.6-xdot-1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python36Packages.xdot https://github.com/r-ryantm/nixpkgs/archive/4e2ffda6f1ee318d2ec7b19606e81f8a269a6e0d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/w9zic272hvyc4x2z5hwl5ai4z29jfj3p-python3.6-xdot-1.0
ls -la /nix/store/w9zic272hvyc4x2z5hwl5ai4z29jfj3p-python3.6-xdot-1.0/bin

Success on aarch64-linux (full log)
Attempted: python36Packages.xdot
Partial log (click to expand)
writing top-level names to xdot.egg-info/top_level.txt
reading manifest file 'xdot.egg-info/SOURCES.txt'
writing manifest file 'xdot.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/j8zbc0gihgc4kl1c4r3frjsfwlchdw95-python3.6-xdot-1.0

Success on x86_64-linux (full log)
Attempted: python36Packages.xdot
Partial log (click to expand)
writing top-level names to xdot.egg-info/top_level.txt
reading manifest file 'xdot.egg-info/SOURCES.txt'
writing manifest file 'xdot.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/w9zic272hvyc4x2z5hwl5ai4z29jfj3p-python3.6-xdot-1.0

Timed out, unknown build status on x86_64-darwin (full log)
Attempted: python36Packages.xdot
Partial log (click to expand)
[ 38%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/RegionInfo.cpp.o
[ 38%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/RegionPass.cpp.o
[ 38%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/RegionPrinter.cpp.o
[ 38%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ScalarEvolution.cpp.o
building of '/nix/store/ndiac27h0k88cb5f6ms1511dqqd9x8rs-rustc-1.29.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/3vw7d8l20cjdvarfs38c4ky8l5zp72hg-cargo-1.29.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/aabzk4n3lplz1y86alp7wbnnhj465dxr-librsvg-2.42.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4s30k2c6506hf279cdcsixhf0f49d1y1-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pq9hcdlcbpcycskzcam0sa2pb1rwjp20-python3.6-xdot-1.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pq9hcdlcbpcycskzcam0sa2pb1rwjp20-python3.6-xdot-1.0.drv' failed


Respect ShouldSerialize*

I have serval classes that serialize depending on these ShouldSerialize* functions.
Since my classes all have a default which let all ShouldSerialize functions return false, the UI does not respect them. All classes will generate full JSON with not respecting ShouldSerialize functions

Swashbuckle generates API descriptions according to the static constructs within your code - attributes, type definitions etc. Your asking for it to go a step further and somehow execute runtime logic (i.e. the code within ShouldSerialize), and incorporate the result of that into the descriptions it generates.
This is a step to far for Swashbuckle as it introduces all kinds of complexities in implementation, not to mention the security implications of executing your runtime logic.
Furthermore, the purpose of ShouldSerialize is to serialize based on some conditional logic for any given instance of a model. So, how exactly should it encode the behavior for the general case - i.e. in your API docs?


Correct small typo

Current coverage is 78.26% (diff: 100%)

Merging #487 into master will not change coverage

@@             master       #487   diff @@
==========================================
  Files            31         31
  Lines          7213       7213
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           5645       5645
  Misses         1568       1568
  Partials          0          0

Powered by Codecov. Last update cc85135...9299438

Thanks


limit supported platforms to ESP32C3, nRF52840DK, nRF9160DK and QEMU_x86

There were more and more "officially" supported platforms over time.
This was great, as it proved that implementation is platform agnostic
and it was possible to use any of the supported boards to try out this
project. There was however more and more maintenance effort needed in
order to test all of those platforms, as all the testing is done
manually so far.
Remove support of the following platforms:

circuitdojo_feather_nrf9160_ns - it is easier to use
nrf9160dk_nrf9160_ns for development purposes, due to built-in
SWD probe,
esp32c3_devkitm - it has similar feature set as 'esp32' platform
(most importantly built-in WiFi); support was added just as a proof
of concept and there is no allocated resources to keep maintaining
it,
qemu_cortex_m3 - feature set is on par with qemu_x86,
thingy91_nrf9160_ns - see circuitdojo_feather_nrf9160_ns above.

It is still possible to use removed platforms, but configurationn and
most importantly testing of them for each sample/application is now out
of scope of this repository.
Remove overlay configuration files with following command:
  $ git ls-files | grep \
      -e circuitdojo_feather_nrf9160_ns\.conf \
      -e esp32c3_devkitm\.conf \
      -e thingy91_nrf9160_ns\.conf \
      -e qemu_cortex_m3\.conf \
      | xargs rm

Remove same set of platforms from device matrix and GitLab CI tests.
Update README files of all samples, so that removed platforms are no
longer referenced there.

This looks good for now, especially as we figure out testing methodologies. Longer term, I think we should potentially have a second tier of testing, even if community contributed. I would favor speed and staying sync'd with Zephyr/NCS over super broad support.
We can work with frontend team to possibly push alternative discussions/notes in the docs for platforms that have oddities that require further documentation (ie. if the thingy91 requires additional overlay to work with the base nrf9160 files, etc)

Changed esp32c3 back to esp32.


Dynamic heatmap legend in Natural Ventilation tab

In the current version, colors and the legend for the Heatmap graph in the Natural Ventilation tab are dynamically adjusted to the temperature and time filters at the top of the section. This creates a problem if the users wants to compare charts with different active filters, because the legend adjusts automatically.
Should we enforce that the colorbar range is fixed to the max and min temperature for that location (including all the data)?
This issue was created based on an inital discussion topic broad up by @FedericoTartarini and was turned into an issue

Examples from previous discussion:


Setting yAxis tick min/max very close to other ticks overlaps tick labels

https://jsfiddle.net/e8n4xd4z/715/
My summary feels worded incorrectly, basically I would expect that if the max and the second highest tick (and inverse for minimum) would overlap that it would just show the max/min tick.
Almost more preferable IMO would be if it dropped the max/min tick label altogether (leaving the tick mark for the guideline drawn on the graph)

Yes, I agree that dropping the min/max tick may be preferable behavior. Trying to always draw the min/max tick leads also to issues like https://github.com/chartjs/Chart.js/issues/4729

Closing as a duplicate of #1968


When the region in Thailand, the date calculate incorrect

For example, if their date is "2022-02-27T16:00:00.000Z", after will covert to "1479-02-27 16:00:00.000". It's should not be reduced with 543 years, It's should be plus with 543years. Can you help to check this? Thx

You're using Buddhist calendar on the iPhone. Here is the detail about this
https://forums.swift.org/t/checking-the-local-season/40796/3


fix: optimize pip

Examples built:

https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12428474494/agora_rtc_engine_android_6.3.2-sp.43211.b.2_20241220091014.zip
https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12428474494/agora_rtc_engine_ios_6.3.2-sp.43211.b.2_20241220090156.zip
https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12428474494/agora_rtc_engine_macos_6.3.2-sp.43211.b.2_20241220090530.zip
https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12428474494/agora_rtc_engine_windows_6.3.2-sp.43211.b.2_20241220090227.zip
https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12428474494/agora_rtc_engine_web_6.3.2-sp.43211.b.2_20241220085839.zip

This comment is commented by bot, do not edit it directly

Examples built:

https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12462398668/agora_rtc_engine_android_6.3.2-sp.43211_20241223065231.zip
https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12462398668/agora_rtc_engine_ios_6.3.2-sp.43211_20241223064454.zip
https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12462398668/agora_rtc_engine_macos_6.3.2-sp.43211_20241223064850.zip
https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12462398668/agora_rtc_engine_windows_6.3.2-sp.43211_20241223063450.zip
https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12462398668/agora_rtc_engine_web_6.3.2-sp.43211_20241223063055.zip

This comment is commented by bot, do not edit it directly

Examples built:

https://nightly.link/AgoraIO-Extensions/agora_flutter_sdks_build/actions/runs/12464017123/agora_rtc_engine_web_6.3.2-sp.43211_20241223085159.zip

This comment is commented by bot, do not edit it directly


bug: ion-select component of Ionic 3 not working in IOS

Type: bug
Ionic Version: 2.x
Platform: ios 9 webview
We have developed one application using Ionic 3. We have used ion-select component at multiple places. In android & IOS version > 10, everything is working fine as expected.
But In IOS 9, ion-select component breaks. It shows blank options when tapping on ion-select.
<ion-item>
   <ion-label>Gender</ion-label>
   <ion-select>
     <ion-option value="f">Female</ion-option>
     <ion-option value="m">Male</ion-option>
   </ion-select>
</ion-item>

Environment Details:
Specific IOS version in which issue is reproducible: 9.3.5
global packages:
ionic/cli-utils : 1.5.0
Cordova CLI      : 6.5.0
Ionic CLI        : 3.5.0
local packages:
ionic/app-scripts              : 1.3.7
ionic/cli-plugin-cordova       : 1.4.1
ionic/cli-plugin-ionic-angular : 1.3.2
Cordova Platforms               : android 6.1.2 ios 4.2.1
Ionic Framework                 : ionic-angular 3.7.1-201710060319
System:
Node       : v7.8.0
OS         : OS X El Capitan
Xcode      : Xcode 8.2.1 Build version 8C1002
ios-deploy : 1.9.1
ios-sim    : 5.0.13
npm        : 4.2.0

Hello! Thank you for opening an issue with us!
I tried applying your sample code to a freshly created blank project and it worked just fine, including when doing a --prod build and running it on an iOS 9.x device in a simulator (I don't have an actual device running older versions).
Then I noticed that your versions of stuff are all over the board. Probably the biggest issue is that you are using a nightly 3.7.1 release with app-scripts 1.3.7 when the changelog states for 3.7.0 (and above) that you should be at app-scripts 3.0.0.
The cordova and ionic CLIs are also out of date as is cordova-ios in your project. I doubt those are contributing to your issue, but they may be.
For reference, here is what I have on the machine I used for testing:
cli packages: (/usr/local/lib/node_modules)

    @ionic/cli-utils  : 1.13.1
    ionic (Ionic CLI) : 3.13.1

global packages:

    cordova (Cordova CLI) : 7.1.0

local packages:

    @ionic/app-scripts : 3.0.0
    Cordova Platforms  : ios 4.5.2
    Ionic Framework    : ionic-angular 3.7.1

System:

    Android SDK Tools : 26.0.2
    ios-deploy        : 1.9.2
    ios-sim           : 6.1.2
    Node              : v8.7.0
    npm               : 5.5.1
    OS                : macOS Sierra
    Xcode             : Xcode 9.0 Build version 9A235

Misc:

    backend : pro

I am going to close this as something that cannot be duplicated.
If, after upgrading at least @ionic/app-scripts to 3.0.0 you still have the issue, please provide a GitHub repo with code that duplicates the problem and I will have another look.
Thank you for using Ionic

I am also facing issue. I am not able to select drop down value in iOS . My system info is as following
cli packages: (/usr/local/lib/node_modules)
@ionic/cli-utils  : 1.19.0
ionic (Ionic CLI) : 3.19.0

global packages:
cordova (Cordova CLI) : not installed

local packages:
@ionic/app-scripts : 3.1.2
Cordova Platforms  : none
Ionic Framework    : ionic-angular 3.9.2

System:
ios-deploy : 1.9.2
Node       : v8.9.1
npm        : 5.2.0
OS         : macOS Sierra
Xcode      : Xcode 9.1 Build version 9B55

Environment Variables:
ANDROID_HOME : not set

Misc:
backend : pro


How to display the log info in Qt widget (like QTextBrowser)?

Hello ,thank you for the nice code.
In my software, I don't have the console. How to display the log info using easylogingpp?
Regards,

@Micalson Well if I'm not mistaken easylogging++ outputs text either to a file or the standard output (that you see in your console). You need to redirect the std::cout output to your QTextBrowser. This is however not a topic for here.


[REFAPP-54] Refactor pages into their own components

Refactors pages in the apps/media app into components inside packages/react to prepare them for the SaaS version of StreamTV

Any HTTP calls to Skylark are made in the Next.js page, and the data is then passed into the component Page - this will make it easier to test + make a GraphQL version
An added benefit is we can view them in Storybook now

Modifies the way the DataFetcher component works by passing it into the page. While this adds complexity into the code, it will allow us to pass in a GraphQL DataFetcher for the SaaS pages.
Moves all React components in the packages/react project into a components directory to tidy up the files.

[x] Refactoring (no functional changes, no API changes)

Jira

https://ostmodern.atlassian.net/browse/REFAPP-54

Codecov Report

Merging #73 (e1742d6) into main (dd81507) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   87.33%   87.39%   +0.05%
==========================================
  Files          67       67
  Lines        1484     1483       -1
  Branches      457      456       -1
==========================================
  Hits         1296     1296
+ Misses        177      176       -1
  Partials       11       11

Impacted Files
Coverage Δ

apps/media/hooks/useBrandWithSeasonBySlug.tsx
85.00% <ø> (+4.04%)
:arrow_up:

...und-gradient/app-background-gradient.component.tsx
100.00% <ø> (ø)

...src/components/app-header/app-header.component.tsx
100.00% <ø> (ø)

...s/react/src/components/button/button.component.tsx
100.00% <ø> (ø)

...onents/call-to-action/call-to-action.component.tsx
90.00% <ø> (ø)

.../components/carousel/carousel-button.component.tsx
100.00% <ø> (ø)

...act/src/components/carousel/carousel.component.tsx
86.95% <ø> (ø)

...react/src/components/carousel/carousel.fixtures.ts
100.00% <ø> (ø)

.../dimension-content/dimension-content.component.tsx
100.00% <ø> (ø)

...-radio-button/dimension-radio-button.component.tsx
100.00% <ø> (ø)

... and 28 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix Alec's Username II

@kratman sorry, I should've reviewed more closely.

Sorry about that. I copied it from the other PR

Sorry about that. I copied it from the other PR

Yeah, after I looked at the other PR I guessed you might've done that and checked more closely to make sure.


ARROW-10682: [Rust] Improve sort kernel performance by enabling inlining of is_valid calls

Benchmark results on an aws t3 instance (cascadelake):
$ cargo bench --bench sort_kernel
sort 2^10               time:   [168.90 us 168.98 us 169.08 us]
                        change: [-59.182% -59.041% -58.824%] (p = 0.00 < 0.05)
                        Performance has improved.

sort 2^12               time:   [839.88 us 840.15 us 840.46 us]
                        change: [-57.095% -57.040% -56.947%] (p = 0.00 < 0.05)
                        Performance has improved.

sort nulls 2^10         time:   [148.69 us 148.75 us 148.82 us]
                        change: [-66.823% -66.727% -66.633%] (p = 0.00 < 0.05)
                        Performance has improved.

sort nulls 2^12         time:   [721.79 us 721.95 us 722.12 us]
                        change: [-65.966% -65.920% -65.845%] (p = 0.00 < 0.05)
                        Performance has improved.

@jorgecarleitao I see you're currently also working on sorting, this might be of interest to you.

👍  thank you @jhorstmann  and @jorgecarleitao


Bug in the logging of SecurityTokenExpiredException?

In the logs (using Serilog), when I get an exception, I get this statement where the dates are the types instead of the actual values.
Bug or feature?
Microsoft.IdentityModel.Tokens.SecurityTokenExpiredException: IDX10223: Lifetime validation failed. The token is expired. ValidTo: 'System.DateTime', Current time: 'System.DateTime'.
A more complete stack trace:
[21:46:22 Information] Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler
Failed to validate the token.
Microsoft.IdentityModel.Tokens.SecurityTokenExpiredException: IDX10223: Lifetime validation failed. The token is expired. ValidTo: 'System.DateTime', Current time: 'System.DateTime'.
   at Microsoft.IdentityModel.Tokens.Validators.ValidateLifetime(Nullable`1 notBefore, Nullable`1 expires, SecurityToken securityToken, TokenValidationParameters validationParameters)
   at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.ValidateLifetime(Nullable`1 notBefore, Nullable`1 expires, JwtSecurityToken jwtToken, TokenValidationParameters validationParameters)
   at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.ValidateTokenPayload(JwtSecurityToken jwtToken, TokenValidationParameters validationParameters)
   at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.ValidateToken(String token, TokenValidationParameters validationParameters, SecurityToken& validatedToken)
   at Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler.HandleAuthenticateAsync()

[21:46:22 Information] Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler
Bearer was not authenticated. Failure message: IDX10223: Lifetime validation failed. The token is expired. ValidTo: 'System.DateTime', Current time: 'System.DateTime'.

[21:46:22 Information] Serilog.AspNetCore.RequestLoggingMiddleware
HTTP GET /weatherforecast/auth responded 404 in 6997.9761 ms

@JoeMarkov this is a result of filtering of message parameters.
Have a look at: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/wiki/PII to understand how to turn this on.

@JoeMarkov this is a result of filtering of message parameters.
Have a look at: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/wiki/PII to understand how to turn this on.

Aha, thanks! I thought that when PII was activated that sensitive information would be replaced with ********* instead of the typename that is shown below. Displaying the typename just looks like a ToString() bug in the logging code like below:
The token is expired. ValidTo: 'System.DateTime', Current time: 'System.DateTime'.

Aha, thanks! I thought that when PII was activated that sensitive information would be replaced with ********* instead of the typename that is shown below. Displaying the typename just looks like a ToString() bug in the logging code like below:
The token is expired. ValidTo: 'System.DateTime', Current time: 'System.DateTime'.

@JoeMarkov we used to replace with ******, but we thought that showing the type might help in some cases.

@JoeMarkov we used to replace with ******, but we thought that showing the type might help in some cases.


modify max_vit model to be trainable

Signed-off-by: xujinling<EMAIL_ADDRESS>

Codecov Report

Merging #1565 (144365d) into main (e564130) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1565   +/-   ##
=======================================
  Coverage   70.08%   70.09%
=======================================
  Files         357      359    +2
  Lines       20694    20738   +44
  Branches     3325     3332    +7
=======================================
+ Hits        14504    14536   +32
- Misses       5268     5278   +10
- Partials      922      924    +2

Impacted Files
Coverage Δ

towhee/models/max_vit/max_vit.py
69.64% <100.00%> (+0.55%)
:arrow_up:

towhee/engine/operator_loader.py
76.92% <0.00%> (-3.08%)
:arrow_down:

towhee/engine/operator_context.py
82.60% <0.00%> (ø)

towhee/functional/mixins/__init__.py
100.00% <0.00%> (ø)

towhee/functional/mixins/remote.py
54.54% <0.00%> (ø)

towhee/utils/tritonclient_utils.py
25.00% <0.00%> (ø)

towhee/serve/triton/client.py
57.06% <0.00%> (+0.07%)
:arrow_up:

towhee/engine/graph_context.py
90.76% <0.00%> (+4.61%)
:arrow_up:

towhee/engine/task_scheduler.py
72.83% <0.00%> (+12.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e564130...144365d. Read the comment docs.


Updated readme to add examples for xNetworkTeam and xHostsFile

Hi @rchaganti, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

LGTM. :+1:


"Decorate" the robot rectangle

Is your feature request related to a problem? Please describe.
When drawing paths I'd like to visualize different simple things about my robot (intake region, shot path). I can imagine/eyeball/straight-edge these, but decorating my robot rectangle would offload a lot of this effort.
Describe the solution you'd like
Some way in the overall config to apply decorations to the robot rectangle on a given side (for simplicity, I think these could be rectangles centered with a given width/depth from the center of one of the robot sides).
Additional context
(Bad) Artist rendition of my idea here (colors/thicknesses not to scale)

I am totally down to do the work for this in a PR, but I poked around for a short time and couldn't figure out where/how the robot rectangle gets drawn

Personally I would do some of this using mechanisms in the glass simulations. I could see this getting kinda messy.

Depends on #902 as this can be an addition to that configurator


User wants better docs on NTP synchronization

See: https://app.frontapp.com/open/cnv_2zf8edf

[thgreasi] This issue has attached support thread https://jel.ly.fish/#/support-thread~79d7ca75-69ea-49dd-b0c3-94d2bca334a6

Related to #1155


XFA - By default a text ui has only one line when in a field element

it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1716809.

The reftest is not useful for the issue this patch aims to fix but I added it to have a good corpus.

/botio unittest

/botio makeref


Broken manual and position control of Rover

Describe the bug
Commit 53b3dfa64ea85876014c5743004b47173bb88007 makes rover lost the ability of manual control, as well as position setpoint.
To Reproduce

Checkout to that commit by git checkout 53b3dfa64ea85876014c5743004b47173bb88007
Execute make px4_sitl gazebo_rover
Open QGC and enable virtual sticks.
Arm the vehicle in manual mode, then move around sticks. Nothing happened.
Switch to Hold mode. Click on the map and slide the "GO TO" bar. Nothing happened either.

Checkout to the previous commit. Everything works well.
@dagar

Thanks for reporting, I'll take a look.

https://github.com/PX4/Firmware/pull/15664


Custom mouse trigger

Solving #32

It would be nice to have this info about where the thing was dropped, not just where it was picked up.

@crazymykl Couldn't this be done with a VirtualDom.onWithOptions "mouseup" handler on the element?
I agree that this does not take into account a click without a drag, and that it might be useful to pass a decoder to onDragEnd. However, I don't know how that could be done, since onDragEnd uses Mouse.ups sub, which only provides a Position, does not have a custom form with a decoder.

That's basically what I'm doing now; I'd like a more elegant interface, having multiple types of handlers operating through different mechanisms is not ideal.

@crazymykl I've opened #35, I'll think of an API for that, if you have any idea, please add a comment to that issue.

published as 2.1.0


Add validation of domain objects

The current domain validation is a bit lacking. Let's discuss some alternatives in this issue:
The simplest way would be to go all stdlib and just extract the validation into its own function:
func Validate(c Cargo) error
It could be interesting to take a closer look at validator: https://github.com/go-playground/validator

Hey, I watched your Golang UK talk on youtube, it was great 👍
Validation is an interesting topic... I'm running into some issues applying ddd concepts to my own little Go DDD experiment and validation is one of them.
I'm curious if you have any thoughts about the whole "always-valid" domain entity debate. Personally I'm in the always valid camp, however the more I try putting this into practice in Go, the more resistance I seem to run into.
I initially had code very similar to what you have here, where domain entities are allowed to be in some invalid state and you have to manually run Validate() on them in order to verify validity. This directly related to issue #12 where the domain model is directly exposed to presentation logic (json tags) because of the lack of DTOs. Adding validation tags to the domain model will further exacerbate this problem since if we do that, the domain model will also be exposed to validation logic that belongs in the application service layer.
If we forsake the use of DTOs and unmarshal json directly into domain models, then we've already instantiated a domain object that fails to enforce its own invariants.... which I think is very bad, but Go seems to encourage this. On the other hand, introducing DTOs will lead to a lot of code duplication and copying of DTO fields to and from domain objects making the code very brittle and (for large objects) slow.
It's an interesting discussion...

Thank you for watching my talk, I'm glad you liked it!
I would also put myself in the same camp as you. Ideally, domain objects should not be able to exist in a state where their invariants are violated. There's nothing in Go, to the best of my knowledge, that can completely prevent you from putting your domain object in an inconsistent state*.
While you could go to great lengths to achieve this - building small packages with interfaces for your domain objects to limit access to internal state - it would most likely not be very idiomatic. For goddd, I've tried to be pragmatic rather than clinging to DDD ideals that wouldn't make sense, i.e. when in Rome, do as the Romans do.

Adding validation tags to the domain model will further exacerbate this problem since if we do that, the domain model will also be exposed to validation logic that belongs in the application service layer.

Not sure I understand what you mean here. What validation logic are you referring to?
I'm leaning more towards the Validate(...) approach rather than validation tags mainly because tags provide relatively limited ways of validating your objects, e.g. no "inter-field" constraints. Validate(...) would also not depend on any third-party packages. At the moment, it feels like the most idiomatic solution.
It's indeed an interesting discussion, and I'm still not sure what the optimal solution would be. If you have any suggestions, I'd love to hear them out.
* Really looking forward seeing how dependently typed languages like Idris  could let you catch violated invariants at compile-time.

While you could go to great lengths to achieve this - building small packages with interfaces for your domain objects to limit access to internal state - it would most likely not be very idiomatic. For goddd, I've tried to be pragmatic rather than clinging to DDD ideals that wouldn't make sense, i.e. when in Rome, do as the Romans do.

It’s a very good point. It’s always a struggle striking the right balance between pragmatism and idealism.

Not sure I understand what you mean here. What validation logic are you referring to?

What I mean is checking that some data complies with some structural rules (i.e - min, max string length, utf-8 encoding, alphanumeric only… all of the things which the go-playground/validator package seem to do) is not a domain concern thus should be enforced at a lower level of abstraction. Whether an Itinerary Leg’s LoadTime is represented as an int64 timestamp or an ISO8061 string should not matter to the domain, but it does matter to the application logic interpreting and converting it into a domain value object.
Once again this is from an idealist’s perspective, but I think that in addition to domain validation, there needs to be validation logic embedded in other layers also.  Checking that incoming data is syntactically valid should be an application service concern and should be executed before enforcing invariants at the domain level. As another example, where would you validate a collection query with pagination parameters? It's most likely not an application service concern and most definitely not a domain concern. So you'd probably need presentation level validation to take care of that since pagination is really just another way of presenting domain data.
As for domain validation, the only problem I see with extracting all behavioural validation into a Validate(c Cargo) is that you don’t capture the context in which you are performing the validation. It may be valid to assign a Cargo to a route, but it might not make sense to specify a new route for that same Cargo -perhaps it is already in transit, or has already been delivered. It would make more sense to validate each action on a case by case basis, maybe using decorators or the specification pattern to keep it DRY. Validate(c Cargo) would make sense if your aim is to perform syntactic validation on Cargo, but I don’t think it would work well for semantic validation.
Idris looks fascinating, thanks for the link.

Checking that incoming data is syntactically valid should be an application service concern and should be executed before enforcing invariants at the domain level.

Excellent observation that I don't think is communicated clearly enough in the current state. Currently some syntactical validation is currently done in the application services, but there's few examples of domain validation.
I think you might be right about Validate(c Cargo). I'm thinking that this issue could be closed with some additional documentation or even a blog post to highlight the points you're making.

While you could go to great lengths to achieve this - building small packages with interfaces for your domain objects to limit access to internal state - it would most likely not be very idiomatic. For goddd, I've tried to be pragmatic rather than clinging to DDD ideals that wouldn't make sense, i.e. when in Rome, do as the Romans do.

Using interface for entities and vo's isn't necessary. Using getters and setters, you can achieve fairly robust object encapsulation for your domain objects, without straying too far from idiomatic go. A simple VO might look like this:
type Name struct {
	name string
}

func NewName(s string) (Name, error) {
	if s == "" {
		return Name{s}, errors.New("name cannot be blank")
	}
	return Name{s}, err
}

func (n Name) String() string {
	return n.name
}

Just for clarity, I'm not endorsing using interfaces for this purpose. I think using accessor methods is a good compromise that prevents other packages from mucking up your invariants. Still, it won't protect you from doing that from within your package. One thing I like about it though is that it at least communicates immutability. I'd be open to review a PR if anyone's interested in making the change.

This is a very interesting topic.
Currently I'm working on a set of microservices using the DDD approach and I've been dealing with some of the troubles commented here. My services are gRPC based, so the transport layer is a protobuf auto-generated code that I treat like a DTO, and I'm using MongoDB as storage.
I went by the non-pragmatic way when started the project, now I have a transport layer with gRPC DTOs, my domain objects with all fields unexported, with exported constructors and getters/idiomatic setters with business logic which is really good. But the really really painful part: a lot of DTOs with exported fields and bson tags to be able to store all this information to the database.
The Domain layer is pretty well, but I have a lot of transformations between gRPC and MongoDB DTOs and is really really painful, tbh I think it's better to export all fields on the domain objects, add the needed tags to them and use the Validation method you are using. Much more pragmatic approach. The only problem is that when someone is developing around your domain objects should be warned to use the exported methods instead of accessing fields directly and run Validation manually.
But 100% sure it's much better this than having 400 lines of DTOs and transformers I think. The transport layer DTOs are fine, but every time I'm writing a repository implementation I feel stupid, really, and I don't know how to manage this with unexported fields.

@hectorgimenez We used to have a lot of internal debate about this very topic, so I feel your pain. In our case, we decided to use unexported fields and fully encapsulate the domain model in its own package (infrastructure, app, and ui code in other packages), and accept the fact that we'd have to explicitly write code to map from our domain model to our persistence model, and to view models. If your models (domain, persistence, view) are closely aligned, the mappings shouldn't be too painful. In our case, however, our domain model and persistence model don't align well, and the mapping code is significant. Tbh this is still a point of contention for us.
Our domain model is complex, so having a correctly encapsulated model is worth the extra trouble. If your microservice is mainly CRUD, and you have few/no domain invariants to enforce, I would definitely skip DDD, and design your app as database centric.

@eriklott thanks, at least I'm not alone on this 😂
Our domain is also complex, and we are triggering domain events on some actions that are dispatched and stored also on database (we are using protobuf for the events in order to deal with the serialization).
The main problem is not the time investment on writing the code to map the domain model to our persistence model and transport one. For me the main problem is that each transformation is a big point of failure (forgot to add a field or wrongly mapped...), we have to test the transformations (or at least trying to cover in an acceptance test that pass through all the layers). And I'm not totally sure if adding this extra complexity worth in any way.
But the most noticeable thing for me is that I feel fighting against the language, seems that I'm forcing it to do things that the language is not designed for, or at least is not giving me facilities. We have like 20 services and are working fine and pretty fast, but everyone on the team feels the same, and seems that the Go community is focused on other kind of things, it's difficult to see good software enterprise architectures on Golang.

@hectorgimenez, 100%. This pretty much summarizes our experience as well.


Prepare CLI for v1.0.0 release

This issue is meant for the AsyncAPI mentorship program.

This is an extension of https://github.com/asyncapi/cli/issues/251, as we are done with most of the work needed for v1. This project has smaller chunks of tasks instead of one big feature and most work is related to documentation and writing tests.
Scope of the project
We are going to release our first stable version of CLI as v1 and we need some help with it like

reach 90% test coverage
enable cross-platform installation- (only windows chocolatey)
Documentation update - (update usage docs for all the commands with examples)
Simple Integration tests to prove the binary works

Technologies Required

Typescript
nodejs
oclif
jest

Documentation update - (update usage docs for all the commands with examples)

fyi this will be automated with https://github.com/asyncapi/cli/pull/556
also join https://github.com/asyncapi/cli/issues/573 as we need to decide on how we release. Majors can be more often and might be that before someone completes mentorship v1 or even v2 will be there already. So rethink title, maybe not prepare for v1 but maybe call it "hardening" or whatever name is not related to v1 😄

Hi @Souvikns @derberg ,
Iwould like to work on this proposal idea. Can you please give me some guidelines for writing the proposal for this project?
Thanks,

Hello @derberg @Souvikns! I am interested in being a part for v1.0.0 release of cli. I would be very happy to work on this and team up with other mentees as a part of the Mentorship program. It seems the major task remaining is the integration of cupid in cli. Could you give some hints on any specifics required in in the proposal?

Hey Folks,
To clarify how to submit a proposal, you should contact the project Mentor/s on Slack and send them your submission in the form of a document or ask them how best they'd prefer you submit your proposals.

Hi @Souvikns @derberg . I am interested in working on this issue. Can you please guide me on how to start ?

Hi @Souvikns @derberg . I am interested in working on this issue. Can you please guide me on how to start ?

+++

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.
There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.
Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.
Thank you for your patience ❤

Still Relevant

closing this as we have released v1 for CLI


fix: respect new port when change the config file

Description
Fixes https://github.com/vitejs/vite/issues/6074
What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

@CHOYSEN did you test what happens when you have two dev servers running (port 3000 and 3001) and change the port?

It works as expect, i try to change the first dev server from 3000 to 3001. @patak-dev
test@C02FV5VTMD6M vite-config-issue 2 % pnpm dev

><EMAIL_ADDRESS>dev /Users/test/Desktop/vite-config-issue 2
> vite

  vite v2.7.1 dev server running at:

  > Local: http://localhost:3000/
  > Network: use `--host` to expose

  ready in 403ms.

下午5:03:26 [vite] vite.config.ts changed, restarting server...
Port 3001 is in use, trying another one...
下午5:03:26 [vite] server restarted.

  > Local: http://localhost:3002/
  > Network: use `--host` to expose

For strictPort, we print the error and waiting for user to change the port again.
import { defineConfig } from "vite";

export default defineConfig({
  server: {
    port: 3000,
    strictPort: true
  }
});

Change to port 3001:
test@C02FV5VTMD6M vite-config-issue 2 % yarn dev
yarn run v1.22.10
warning package.json: No license field
$ vite

  vite v2.7.1 dev server running at:

  > Local: http://localhost:3000/
  > Network: use `--host` to expose

  ready in 380ms.

上午11:30:31 [vite] vite.config.ts changed, restarting server...
Error: Port 3001 is already in use

Change to port 3002:
上午11:31:07 [vite] vite.config.ts changed, restarting server...
上午11:31:07 [vite] server restarted.

  > Local: http://localhost:3002/
  > Network: use `--host` to expose

It would be nice to handle host as well so we can close #5996.

It would be nice to handle host as well so we can close #5996.

Hi @btea, would you like to agree this?

It would be nice to handle host as well so we can close #5996.

Hi @btea, would you like to agree this?

Yes.

It would be nice to handle host as well so we can close #5996.

Hi @btea, would you like to agree this?

Yes.

Thanks!

I re-run the jobs, CI is a bit moody lately. We need to move away from Jest, we are working on it 😉


Adding hovering effect to all the order buttons in food website

Describe the bug

Adding hovering effect to all the order buttons in food website
Expected behavior

Screenshots (Mandatory)

Additional context (Mandatory )
Are you contributing under any open-source program ?

I am contributing under GSSoC'24

@apu52 Please assign me this issue under GSSoC'24

@SuhainaFathimaM Thanks for raising the issue .I have assigned you this time . But from next time please provide some SS


feat: update to eye v9.11.0

feat: update to eye v9.11.0

:tada: This PR is included in version 12.10.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v12.10.0

Your semantic-release bot :package::rocket:


equals and hashcode invokes super even if superclass has no fields

I can see in the previous pull requests that it was fixed to invoke super equals and hashcode due to older versions not doing the same. This is working all right except for the case (as ours) where top most class in the hierarchy has no fields hence no equals and hashcode implementation generated for the same and the immediate childs of this class ends up calling Objects equals and hashcode which in effect nullifies everything if not comparing same instances.
Due to this issue we are not able to use the latest version of the library. Can this be looked into as soon as possible?
Many thanks and let me know if there are any questions with regard to the same.

Sounds like we need to not call super if the superclass is Object. Happy to accept a PR for this.

That sounds all right. Let me know once we have fix for this available.

Something is strange here as the implementation already checks whether the current type extends Object:
https://github.com/joelittlejohn/jsonschema2pojo/blob/master/jsonschema2pojo-core/src/main/java/org/jsonschema2pojo/rules/ObjectRule.java#L403
https://github.com/joelittlejohn/jsonschema2pojo/blob/master/jsonschema2pojo-core/src/main/java/org/jsonschema2pojo/rules/ObjectRule.java#L531
When I generate some types on http://www.jsonschema2pojo.org/ I see no call to super() in the topmost class. Could you provide an example of your input and show the output? What version are you using?

Sorry, I may not have been clear in my explanation earlier. The issue arises when topmost class in the hierarchy is empty (i.e. it has no fields) and the immediate children of this class invokes super in their equals and hashcode implementation. This call to super gets propagated to Object since topmost empty class do not have equals and hashcode in it. Following are examples for your reference:
The Schema is as follows:
Child
{
	"title": "Child",
	"javaType": "com.some.package.Child",
	"type": "object",
	"extends": {
		"$ref": "empty-parent.json"
	},
	"required": true,
	"additionalProperties": true,
	"default": {}
}

Parent
{
	"title": "Parent",
	"type": "object",
	"required": true,
	"javaType": "com.some.parent.package.Parent",
	"additionalProperties": false
}

The generated classes for above will look something like:
Child

@JsonInclude(JsonInclude.Include.NON_NULL)
@Generated("org.jsonschema2pojo")
@JsonPropertyOrder({

})
public class Child
    extends Parent
{

    @JsonIgnore
    private Map<String, Object> additionalProperties = new HashMap<String, Object>();

    @Override
    public String toString() {
        return ToStringBuilder.reflectionToString(this);
    }

    @JsonAnyGetter
    public Map<String, Object> getAdditionalProperties() {
        return this.additionalProperties;
    }

    @JsonAnySetter
    public void setAdditionalProperty(String name, Object value) {
        this.additionalProperties.put(name, value);
    }

    @Override
    public int hashCode() {
        return new HashCodeBuilder().appendSuper(super.hashCode()).append(additionalProperties).toHashCode();
    }

    @Override
    public boolean equals(Object other) {
        if (other == this) {
            return true;
        }
        if ((other instanceof Child) == false) {
            return false;
        }
        Child rhs = ((Child) other);
        return new EqualsBuilder().appendSuper(super.equals(other)).append(additionalProperties, rhs.additionalProperties).isEquals();
    }
}

Parent:
@JsonInclude(JsonInclude.Include.NON_NULL)
@Generated("org.jsonschema2pojo")
@JsonPropertyOrder({

})
public class Parent {

    @Override
    public String toString() {
        return ToStringBuilder.reflectionToString(this);
    }

}

As you can see in Child class above we have appendSuper but Parent class has no equals and hashcode, so this call gets propagated to Object.
We have a special case where we need to have empty parent class.
Let me know if there is any doubt.

ObjectRule does check for Object superclasses.
Object.equals will be used if the root class does not have any fields (e.g. includeAdditionalProperties set to false) and does not override equals. We can fix this by checking if equals is overridden at any ancestor of a class before using super.equals. We can follow JClass._extends all the way up to Object.
That leaves one edge case: what should the library do if any generated class inherits from an existing non-Object class (because of javaType)?

Sounds fine to me. Checking for overridden equals in the ancestor should take care of this edge case.

Generated classes are represented in the code model as JDefinedClass. Classes referenced by javaType properties will appear as JReferencedClass, which is private.
@joelittlejohn you can get at it with reflections to check for overridden equals, but do we want to rely on non-public API?

The issue I see with reflecting on the parent class (to see if it extends equals) is that this can change. The parent class can be modified to extend equals later, even if it didn't when the types were generated. I prefer to avoid generating different output based on the current context if at all possible as this is often a source of confusion.
I think we should try to stick the following rules, that are based on the content of the input only:

If the type extends Object, don't call super.

If the type does not extend Object, call super.

Always generate hashCode and equals when generating a type. In practice this means we remove this check:
 if (fields.isEmpty()) {
         return;
 }

The problem reported here tells me that overriding hashCode and equals is important, even if the type has no fields.


Not Able to Install Realm using Pod install

I am not able to install Realm using Pod install.
Tried both Pod install and Pod Update calls.. I have added the entire verbose output generated below for reference.
pod update --verbose
Update all pods
Preparing
Updating local specs repositories
Updating spec repo master
$ /usr/local/bin/git -C /Users/deepaksinha/.cocoapods/repos/master fetch origin --progress
$ /usr/local/bin/git -C /Users/deepaksinha/.cocoapods/repos/master rev-parse --abbrev-ref HEAD
master
$ /usr/local/bin/git -C /Users/deepaksinha/.cocoapods/repos/master reset --hard origin/master
HEAD is now at a2c7828c919 [Add] Clappr 0.7.3
CocoaPods 1.4.0.rc.1 is available.
To update use: sudo gem install cocoapods --pre
[!] This is a test version we'd love you to try.
For more information, see https://blog.cocoapods.org and the CHANGELOG for this version at https://github.com/CocoaPods/CocoaPods/releases/tag/1.4.0.rc.1
Analyzing dependencies
Inspecting targets to integrate
Using ARCHS setting to build architectures of target Pods-WooCommerceLib: ()   Using `ARCHS` setting to build architectures of target `Pods-WooCommerceLibTests`: ()
Finding Podfile changes
A RealmSwift

Alamofire
LNRSimpleNotifications
SwiftyJSON
TDOAuth

Resolving dependencies of Podfile
Comparing resolved specification to the sandbox manifest
A Realm
A RealmSwift
M Alamofire

LNRSimpleNotifications
OMGHTTPURLRQ
SwiftyJSON
TDOAuth

Downloading dependencies
-> Installing Alamofire 4.6.0 (was 4.5.1)

Copying Alamofire from /Users/deepaksinha/Library/Caches/CocoaPods/Pods/Release/Alamofire/4.6.0-f41a5 to Pods/Alamofire

-> Using LNRSimpleNotifications (0.8.0)
-> Using OMGHTTPURLRQ (3.2.2)
-> Installing Realm (3.0.2)

Git download
Git download
$ /usr/local/bin/git clone https://github.com/realm/realm-cocoa.git /var/folders/7k/l0sxhd016q965h80z7gtnlr80000gn/T/d20171221-14618-1nt7mwi --template= --single-branch --depth 1 --branch v3.0.2
Cloning into '/var/folders/7k/l0sxhd016q965h80z7gtnlr80000gn/T/d20171221-14618-1nt7mwi'...
Note: checking out '13a3cb44c10436d4fb575bfcddc879698ae956e3'.

 You are in 'detached HEAD' state. You can look around, make experimental
 changes and commit them, and you can discard any commits you make in this
 state without impacting any branches by performing another checkout.

 If you want to create a new branch to retain commits you create, you may
 do so (now or later) by using -b with the checkout command again. Example:

   git checkout -b <new-branch-name>

 $ /usr/local/bin/git -C /var/folders/7k/l0sxhd016q965h80z7gtnlr80000gn/T/d20171221-14618-1nt7mwi submodule update --init --recursive
 Submodule 'Realm/ObjectStore' (https://github.com/realm/realm-object-store.git) registered for path 'Realm/ObjectStore'
 Cloning into '/private/var/folders/7k/l0sxhd016q965h80z7gtnlr80000gn/T/d20171221-14618-1nt7mwi/Realm/ObjectStore'...
 Submodule path 'Realm/ObjectStore': checked out '136b3a32a218f50275f1183ed078b31945a9e29f'
 Submodule 'external/catch' (https://github.com/philsquared/Catch) registered for path 'Realm/ObjectStore/external/catch'
 Submodule 'external/pegtl' (https://github.com/ColinH/PEGTL) registered for path 'Realm/ObjectStore/external/pegtl'
 Cloning into '/private/var/folders/7k/l0sxhd016q965h80z7gtnlr80000gn/T/d20171221-14618-1nt7mwi/Realm/ObjectStore/external/catch'...
 Cloning into '/private/var/folders/7k/l0sxhd016q965h80z7gtnlr80000gn/T/d20171221-14618-1nt7mwi/Realm/ObjectStore/external/pegtl'...
 Submodule path 'Realm/ObjectStore/external/catch': checked out 'ee67ac6b7c3595251342671485c65cf81d725896'
 Submodule path 'Realm/ObjectStore/external/pegtl': checked out '3c4128a7e7e1288eb746418ea60c41477358f26a'

Running prepare command
$ /bin/bash -c  set -e sh build.sh cocoapods-setup
core is not a symlink. Deleting...
Downloading dependency: sync 2.1.1
tar (child): xz: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
[!] /bin/bash -c
set -e
sh build.sh cocoapods-setup

core is not a symlink. Deleting...
Downloading dependency: sync 2.1.1
tar (child): xz: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/executable.rb:69:in execute_command' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/executable.rb:27:in block in executable'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer/pod_source_preparer.rb:66:in block (2 levels) in run_prepare_command' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer/pod_source_preparer.rb:60:in chdir'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer/pod_source_preparer.rb:60:in block in run_prepare_command' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/user_interface.rb:64:in section'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer/pod_source_preparer.rb:59:in run_prepare_command' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer/pod_source_preparer.rb:37:in prepare!'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/downloader/cache.rb:202:in copy_and_clean' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/downloader/cache.rb:159:in block (2 levels) in uncached_pod'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/downloader/cache.rb:157:in each' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/downloader/cache.rb:157:in block in uncached_pod'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/downloader/cache.rb:181:in call' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/downloader/cache.rb:181:in in_tmpdir'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/downloader/cache.rb:153:in uncached_pod' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/downloader/cache.rb:33:in download_pod'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/downloader.rb:42:in download' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer/pod_source_installer.rb:120:in download_source'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer/pod_source_installer.rb:60:in install!' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer.rb:364:in install_source_of_pod'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer.rb:329:in block (2 levels) in install_pod_sources' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/user_interface.rb:85:in titled_section'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer.rb:328:in block in install_pod_sources' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer.rb:320:in each'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer.rb:320:in install_pod_sources' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer.rb:163:in block in download_dependencies'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/user_interface.rb:64:in section' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer.rb:161:in download_dependencies'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/installer.rb:117:in install!' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/command/update.rb:81:in run'
/Library/Ruby/Gems/2.0.0/gems/claide-1.0.2/lib/claide/command.rb:334:in run' /Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/lib/cocoapods/command.rb:52:in run'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-1.3.1/bin/pod:55:in <top (required)>' /usr/local/bin/pod:23:in load'
/usr/local/bin/pod:23:in `'

This is probably a problem with your installation of cocoapods or ruby or both.  I have:
$ pod --version
1.3.1
$ which ruby
/usr/local/bin/ruby
$ ruby --version
ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-darwin17]

Closing this issue due to no response. Feel free to reopen if additional information can be provided.