8.0 BlazorWebAppOidc IDX21323: RequireNonce is 'False'

Describe the issue
When running this blazor sample initially the authentication works well, but if you idle on the page (I'm assuming until the auth token needs to be refreshed) then you get this nonce error.
Since the error is pointing to the CookieOidcRefresher file I was wondering if I can get some direction on how to implement a fix for this.
To Reproduce

Set up the sample project with proper Microsoft Entra
Run the project
Authenticate to the weather page
Wait for the token to need to be refreshed
Open the counter page
See error

Expected behavior
I expect for the token to be refreshed in the background if it has expired.
Screenshots

Additional context
Instead of setting global render mode, I've implemented a per component render mode. However, I don't think that's part of the problem here.
.NET Version
Output of dotnet --info.
.NET SDK:
Version:           8.0.200-preview.23624.5
Commit:            8065b9770c
Workload version:  8.0.200-manifests.ba313bcd
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19045
OS Platform: Windows
RID:         win-x64
Base Path:   C:\Program Files\dotnet\sdk\8.0.200-preview.23624.5\
.NET workloads installed:
Workload version: 8.0.200-manifests.ba313bcd
[aspire]
Installation Source: SDK 8.0.200-preview.23624, VS 17.9.34511.98
Manifest Version:    8.0.0-preview.2.23619.3/8.0.100
Manifest Path:       C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.aspire\8.0.0-preview.2.23619.3\WorkloadManifest.json
Install Type:              Msi
[wasm-tools]
Installation Source: VS 17.8.34511.84, VS 17.9.34511.98
Manifest Version:    8.0.1/8.0.100
Manifest Path:       C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.workload.mono.toolchain.current\8.0.1\WorkloadManifest.json
Install Type:              Msi
Host:
Version:      8.0.1
Architecture: x64
Commit:       bf5e279d92
.NET SDKs installed:
6.0.418 [C:\Program Files\dotnet\sdk]
7.0.102 [C:\Program Files\dotnet\sdk]
8.0.101 [C:\Program Files\dotnet\sdk]
8.0.200-preview.23624.5 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.26 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 7.0.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 7.0.15 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.26 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 7.0.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 7.0.15 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 6.0.26 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 7.0.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 7.0.15 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Other architectures found:
x86   [C:\Program Files (x86)\dotnet]
registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Issue Details
⚠ Do not edit this section. It is required for issue processing.

Content Source: dotnet/blazor-samples
GitHub Login: @guardrex

Hello @travaille-dev ... Please open this for the product unit at ...
https://github.com/dotnet/aspnetcore/issues
Please add ...
cc: @guardrex https://github.com/dotnet/blazor-samples/issues/173

... to the bottom of your opening comment to cross-link the issues. We'll leave this one open to work on the sample.

Almost same thing.

When looking online I get some reference to rechallenge the authentication. However, the code samples reference unrelated packages.
https://stackoverflow.com/a/54020017
https://learn.microsoft.com/en-us/answers/questions/1255930/idx21323-requirenonce-is-true-openidconnectprotoco

Ok ... thanks for trying that just to see what would happen.
I'll be 👂 on the PU issue to see what they say. Hopefully, they'll have a fix for both of us ... to get your app running and for the publication of the companion article that I'm writing for the sample apps at https://github.com/dotnet/AspNetCore.Docs/pull/31555.

Note that Stephen Halter is OOF until February 1. If they think he should work that issue because he's the one who built this sample app, then it will need to wait until he gets back on the 1st.

Thanks for your help! I don't mind pivoting to utilize the oidc example without aspire + yarp as I know aspire is still early access.

There probably will be some additional updates, too. It turns out that if the user is on an authenticated page and logs out that it then redirects back to same page, which triggers another sign-in redirect. I hacked up an approach to deal with it using reflection, but it's probably not elegant (I'll note it on the issue and ping you over there). Another concern is that when the user is returned to app after log in that the Weather component can try to render server-side and :boom: when the IWeatherForecaster service isn't available there. I'll see if I can fix that tomorrow. Anyway, these sorts of things will be worked out on the PR. This particular PU issue can just focus on the nonce situation.

I am having both the problems described here. Nonce and IWeatherForecaster. You can reproduce the IWeatherForecaster by bookmarking it and clicking the bookmark.

@Krangth This must be dealt with by the product unit on the issue that @travaille-dev opened on their repo. They won't look at this one. This is only to track the fix, whatever it turns out to be.
Can you thumb UP 👍 the product unit issue's opening comment?
https://github.com/dotnet/aspnetcore/issues/53585
Halter will be back from OOF today. Idk how long he will need to dig out of email, etc. He'll be working the PU issue soon tho. I suspect that if he doesn't work on it today/tomorrow that he'll get to it next week.

@guardrex I don't mean to go off-topic in this thread but I am confused about this sample app and I don't know where to post this.
With this issue present in the sample app, I can't use and trust its code in a Blazor 8.0 application that I want to deploy to production. And I'd argue this isn't a minor bug. I also encountered another issue, the details of which escape me at the moment. I understand the responsibility to secure my app and what I deploy is on me. However, in comparison to implementing auth in an MVC app, in Blazor it's far more complicated the moment we use InteractiveAuto mode. In MVC I can trust the methods provided by Microsoft without much question even though they are black boxes to me.
Since authentication is so critical to implement correctly and this sample app from Microsoft has a bug in it, I'm even more reluctant to implement a solution proposed by an authority outside of Microsoft. Figuring out the details of auth code independently also seems time-consuming (which I know is my problem) and also risky (also my problem).
So what is the purpose of this sample-app? Is this something that is still in-progress and developers shouldn't trust the code yet and use it without understanding it fully? Does Microsoft not have palatable production-ready way yet for developers to add auth? If the answer is yes to these questions, that's totally fine. I know auth is complicated. But coming from my great familiarity of implementing the simple and working auth code for the well-established MVC framework, I don't have the appropriate reference point/context to interpret what's going on here for this new framework release.

This (and a few other security-related 8.0 issues) must be addressed by the product unit. My next contact with management is on Friday, and I'll be providing a list of everything that requires attention.
For this particular issue, keep en 👁 on that PU issue that was opened :point_up:, and you can 👍 the issue's opening comment if you wish.
There are several items to address ...

Roles for the WASM+Identity sample app.
Cross-domain same-site settings for the WASM+Identity sample app.
NSwag to replace Swashbuckle that was removed from the WASM+Identity sample app.
Companion article to go with the Blazor Web App+OIDC sample app.
PU review of our passing tokens guidance for Blazor Web Apps.
Additional or alternative bearer token coverage.
This nonce issue.

I'll go over these with them on Friday to see if we can get them resolved ASAP 🏃♂.
They can all be tracked via the 8.0 tracking issue at https://github.com/dotnet/AspNetCore.Docs/issues/28161.

I did just notice that they marked that for .NET 9 ... i.e., a November resolution. Idk why it has the priority that it does.

Thanks, guardrex. This is a bottleneck for me because the apps we work on require authentication and authorization. We've been using MVC and ajax to create highly interactive apps and Blazor server+client would make the whole process easier. Considering Microsoft has expressed we shouldn't be writing custom [Authorize] attributes, I take it also that we shouldn't mess around with custom code for auth in general.
I appreciate your responses. I'm hoping fixes won't take until November.

I'm sending an email to management now to try and unblock a lot of security issues and PRs. I hope within a week or two that they will all be resolved. WRT this pesky nonce situation :smiling_imp:, I'll at least remark on it here if I hear back verbally on it and nothing is added on the PU issue about it.

Actually ... some good news on the nonce item 😈 ... they scheduled it for Preview 3, so that should be around April to hear what the fix will be. I assume that we'll try to present a workaround for 8.0 apps after I find out what they figured out to do about it. Therefore, I'm going to list it in my email but note to them that I understand it will be looked at reasonably soon.

I first want to say thank you @guardrex and your team for providing the Blazor Sample projects. I was wracking my brain trying to get a .NET 8 Blazor Web App to work gracefully with the Entra ID authentication flow and couldn't have done it without you and your team's work on putting the the samples out there.
Secondly, I have run into this snag as well which manifests as our site (deployed to an on prem server but using hosted Azure Entra ID for auth) being unavailable if left idle past the token refresh period (1 hour?). The end user sees an HTTP 500 error and we see the detailed exception that @travaille-dev posted in the submission (IDX21323).
In digging into the CookieOidcRefresher class provided in the 8.0/BlazorWebAppOidc project, I see that when the OpenIdConnectProtocolValidator is constructed it is done so with the property RequireNonce being set to false. When the method in OpenIdConnectProtocolValidator is called to validate the refresh response (starting at line 80 of the CookieOidcRefresher class) it fails on a null nonce value. It appears that the OpenIdConnectProtocolValidator is not honoring the RequireNonce = false setting.
OpenIdConnectProtocolValidator.ValidateTokenResponse() calls ValidateNonce() which checks the RequireNonce property and also checks the Nonce value of the ValidationContext being passed in as well as the ValidatedIdToken.Payload.Nonce value of the ValidationContext being passed in. What's more, once the Nonce values are validated there is a further check to see if it is expired. ValidateNonce() compares the timestamp of the ValidatedIdToken.Payload.Nonce value to the current UTC DateTime and if the nonce timestamp plus the NonceLifetime (set on the OpenIdConnectProtocolValidator) is less than UTC Now it throws OpenIdConnectProtocolInvalidNonceException (IDX21324).
TL;DR Even if RequireNonce is set to false a Nonce value still needs to be passed to the OpenIdConnectProtocolValidator and the Validator's NonceLifetime needs to be accounted for.
My proposed workaround for this is to set the Nonce value when creating the OpenIdConnectProtocolValidationContext model that is passed into OpenIdConnectProtocolValidator.ValidateTokenResponse. If it is set to the validated token's Payload.Nonce value then it should pass all of the checks in the RequireNonce method of OpenIdConnectProtocolValidator.
var validatedIdToken = JwtSecurityTokenConverter.Convert(validationResult.SecurityToken as JsonWebToken);

_oidcTokenValidator.ValidateTokenResponse(new()
{
    ProtocolMessage = message,
    Nonce = validatedIdToken.Payload.Nonce,
    ClientId = oidcOptions.ClientId,
    ValidatedIdToken = validatedIdToken,
});

Additionally,  when constructing the OpenIdConnectProtocolValidator the NonceLifetime property should be set to an extended TimeSpan (I am setting it to TimeSpan.MaxValue):
private readonly OpenIdConnectProtocolValidator _oidcTokenValidator = new()
{
    // Refresh requests do not use the nonce parameter. Otherwise, we'd use oidcOptions.ProtocolValidator.
    RequireNonce = false,
    NonceLifetime = TimeSpan.MaxValue
};

The security implication for this is that we are essentially bypassing the Nonce check in the token refresh validation. I don't believe this is making CookieOidcRefresher any less secure than it already is since the RequireNonce property was already being set to false in order, presumably, to bypass the nonce check anyway. I am by no means an expert in any of this so please take my proposed workaround with a large grain of salt and I would appreciate those with more knowledge on the subject to offer their guidance if possible.

thank you @guardrex and your team

I'm glad you find the sample(s) helpful. Stephen Halter and Jeremy Likness are due full credit for the sample apps. I'm mostly just handling writing up the companion articles, one of which we have for WASM+Identity and one that's under construction on https://github.com/dotnet/AspNetCore.Docs/pull/31555.
I recommend that you copy all of those remarks into a comment on the PU's issue. That's where they'll probably work it. I'm going to keep this issue open in case they resolve and close the PU issue before I/we get the sample app updated over here.
Place a copy of that here ...
https://github.com/dotnet/aspnetcore/issues/53585

Just checking back in here ... the PU still has it scheduled for Preview 3, which will be for April's release. I'll continue to keep an 👁 on the PU issue.

I just want to note here that one source of this is ...
Stale cookies are the devils playground! 😈😆
I just hit this while working another issue. I already have guidance in the article on using an InPrivate/incognito browser for testing, but I'm going to strengthen the remarks on doing that tomorrow when I issue a new PR to address some updates to the sample app that just merged over here.

My bad on one point ..... the guidance is in the WASM-focused articles at this time.
Tomorrow, I'll surface that guidance in the BWA+OIDC article. For now, you can see it here ...
https://learn.microsoft.com/en-us/aspnet/core/blazor/security/webassembly/standalone-with-identity?view=aspnetcore-8.0#cookies-and-site-data

I'm placing the troubleshooting guidance (updated from what the WASM articles show) on https://github.com/dotnet/AspNetCore.Docs/pull/31937.
I'm going to let this nonce situation play out on the PU issue that was opened. They've marked it for Preview 3 investigation. If we need to make changes to the sample app, I'll either re-open this or open a new issue.
Anyone finding this issue should make sure that they're looking at the current (latest) version of the sample app and update their app(s) to match the latest sample/article because multiple updates have been made. There will be one more set of article updates soon ... perhaps even by tomorrow (Friday, 3/1).
Everyone PLEASE use an InPrivate/incognito browser for ALL testing ... no matter how insignificant the changes to the app, configuration, or test user account(s). Stale cookies have been horrible TIME SINKS 😈😡 as the dev spends hours or even days trying to figure out what's wrong with an app. It turns out in some cases that it's just stale cookies that are breaking the authn/z.


Use the rule name as default scope if the scopes map is "null"

A common use case is the definition of one rule per scope.
In this case the user always has to write in the configuration of the rule that it uses the corresponding scope.
We should add a default behaviour that if the scopes map is null, the agent will use a scope with the same name as the rule if such a scope exists.
Note that we should not use this behaviour when the scopes map is specified as an empty map "{}".
We then should assume that the user wants no scopes by default. This will be most commonly used in the default configuration, for example for the "method_duration" rule.

This ticket will not be done because rules and scopes will have different names due to naming conventions of rules and scpes (r_my_rule, s_my_scope, ...), now.
Furthermore, this can lead to a lot of confusion if suddenly scopes are used or not used anymore if something is renamed.


changed HouseStyles to BasemapStyles

L.Mapzen.HouseStyles will be compatible until mapzen.js reaches to 1.0
closes #163

👍


Automate the training page generation

This should be done using templatetags as well, just like we do for the session list.
For trainings we additionally need to get access to the talk abstract and a picture URL.

We won't have time for this for EuroPython 2017, but should have it for EuroPython 2018.


ui-sref directive breaks silently with Google's new reCaptcha

When the reCaptcha is ticked the ui-sref directive does no longer switch states. I get no errors at all so it's hard to tell what is actually causing this issue. I have noticed though that I can get it to work by commenting out $timeout.cancel(transition) within the click binder in the ui-sref source, hence I suspect something might be canceling the timeout that triggers $state.go, which would explain why no errors are thrown. [See this plunker] (http://plnkr.co/edit/JKXnt6vV5uaNYfYyoRRB?p=preview)

Seems to work fine for me. I did the reCaptcha and clicked on the "Link with ui-sref" link, and it showed the text "another state" below the reCaptcha. Was something different supposed to happen?
Is this on a particular browser?

If i first click the reCaptcha, nothing happens when I click the ui-sref link. I've tested with:

IE 11
Firefox 28
Firefox 35
Chrome 40
Chrome 41
Chromium 39
All fail. Seems to work in Safari on iPad 4 though..

That's really bizarre. I'm on Chrome 41 on OSX. I can click all over the reCaptcha, reload it, verify it, etc., and the state link still works fine for me.
Can anyone else confirm/deny?

Just tried FF 36 and Chrome 41 PC, can confirm doesn't work.

Okay, so, in FF and Safari (where I can reproduce the issue), the reCaptcha is just a checkbox, but in Chrome you have to enter text. Not sure what difference that makes. As you correctly identified, the issue seems to be around ignorePreventDefaultCount here: https://github.com/angular-ui/ui-router/blob/master/src/stateDirectives.js#L142, which was introduced at 656b5aab906e5749db9b5a080c6a83b95f50fd91.
@christopherthielen Do you remember what exactly that was introduced? Something with <a />'s that already had links that Angular core was messing with or something?

It doesn't really matter whether you have to write text or not in the reCaptcha. I've tested it so many times that I now have to identify wine bottles and sushi, but the ui-sref link still doesn't work :)

@nateabele Here is what I remember:
The built-in AngularJS a directive (https://github.com/angular/angular.js/blob/v1.3.15/src/ng/directive/a.js#L28) calls preventDefault if the anchor tag does not have an href.
The ui-sref directive replaces the preventDefault function on the click event with one that simply stops the transition.  If the ui-sref directive is on an <a> tag with no href, it waits for two calls to preventDefault before cancelling the transition such that when the a directive invokes preventDefault(), it is ignored.

I wonder if this has to do with directive priority... if the a click handler is invoked first, then preventDefault() will already have been called, and the uiSref click handler will wait forever for it to be called again.


Support namespacing groups ingested via the GithubOrgReaderProcessor

Feature Suggestion
The current functionality for importing GitHub org data allows for targeting a specific GitHub org and ingesting all users/team as Users/Groups under the default namespace.
Under our use-case, we have a GHE instance that supports having multiple GitHub orgs (usually created per dept. or domain). If we import multiple orgs that contain the same team names then they will both merge under the same Group in the default namespace (I assume, haven't tested). It would be helpful if we could namespace the imported Group that indicates the GitHub org they reference
For example, I have the following GitHub orgs and teams:
FooOrg: team-abc, team-efg
BarOrg: team-abc, team-xyz
After importing from both orgs, I would expect the following entities:
Group:FooOrg/team-abc, Group:FooOrg/team-efg, Group:BarOrg/team-abc, Group:BarOrg/team-xyz
This would allow components to specify their owner fields to correctly reflect team ownership.
Another thing I would like to note is that users in our GHE may have multi-org memberships so in our use-case it wouldn't make sense to namespace Users since there will only be one unique set of usernames.
Possible Implementation

Context
There might be related to discussions in https://github.com/backstage/backstage/issues/4089 and I'm not sure how exactly this would fit in with the proposal described there.

#4977 is relevant to this as well.

If someone can provide me with some guidance, I'm willing to take a stab at implementing this since its a key blocker for us.
I thinking the implementation would be similar to how the LDAP processor works by doing the following:

Extend the githubOrg config to expose a groups.set option similar to the LDAP config (we can probably also support a users.set option while we're at it):
https://github.com/backstage/backstage/blob/0c26a45ea8c4c4ce85e4047ec43b4c5c3eb79b35/plugins/catalog-backend/src/ingestion/processors/ldap/config.ts#L97

Refactor the following function to read in the new config options: https://github.com/backstage/backstage/blob/0c26a45ea8c4c4ce85e4047ec43b4c5c3eb79b35/plugins/catalog-backend/src/ingestion/processors/github/config.ts#L46
by extracting out and reusing logic from the LDAP config reader:
https://github.com/backstage/backstage/blob/0c26a45ea8c4c4ce85e4047ec43b4c5c3eb79b35/plugins/catalog-backend/src/ingestion/processors/ldap/config.ts#L191-L201

Apply the same processing from LDAP:
https://github.com/backstage/backstage/blob/0c26a45ea8c4c4ce85e4047ec43b4c5c3eb79b35/plugins/catalog-backend/src/ingestion/processors/ldap/read.ts#L74-L78
in this function for GitHub:
https://github.com/backstage/backstage/blob/0c26a45ea8c4c4ce85e4047ec43b4c5c3eb79b35/plugins/catalog-backend/src/ingestion/processors/github/github.ts#L127

Check if groups.set is defined and contains metadata.namespace and prefix the group names when setting user.spec.memberOf in the following (to support the use-case where users and groups are set with different namespaces):
https://github.com/backstage/backstage/blob/0c26a45ea8c4c4ce85e4047ec43b4c5c3eb79b35/plugins/catalog-backend/src/ingestion/processors/GithubOrgReaderProcessor.ts#L93-L103

I also want to confirm that the following function would still work correctly without adding namespace prefixes because according to the specification, these relations will default to using the same namespace as the current entity (ie. all groups in the current provider ingestion will have the same namespace):
https://github.com/backstage/backstage/blob/0c26a45ea8c4c4ce85e4047ec43b4c5c3eb79b35/plugins/catalog-backend/src/ingestion/processors/util/org.ts#L19-L35
Let me know if my proposed implementation makes sense or if there's anything I missed.
(side note: if my understanding of how namespacing and entity relation identifying is correct, I'm not sure if the LDAP processor correctly handles the scenario where users and groups are under different namespaces)

I also want to note here that it looks like if you namespace teams to handle the multi-org use-case, the CodeOwnersProcessor will not work correctly since it looks like it strips out the org prefix when setting owner:
https://github.com/backstage/backstage/blob/dcb5d5e373f8b300389a248b18d2beb831660d21/plugins/catalog-backend/src/ingestion/processors/codeowners/resolve.ts#L37-L44
You would probably need to write a custom code owners processor and replace the default one in order to handle this correctly. (also note that according to https://github.com/backstage/backstage/issues/4977#issuecomment-800652564 there's currently no way to just replace one processor)

Another thing I just realized (and I'm not sure what the best way to handle it is), the scenario where users have multi-org memberships which extends to having cross org team memberships.
The following code only updates memberships for users found in the current org but that user might already exist from a previously processed org so it needs to somehow merge its membership list instead of overwriting it:
https://github.com/backstage/backstage/blob/0c26a45ea8c4c4ce85e4047ec43b4c5c3eb79b35/plugins/catalog-backend/src/ingestion/processors/GithubOrgReaderProcessor.ts#L93-L103
This seems to require the processor to somehow receive the current "in-flight" user entities in order to update existing users or somehow merging any duplicate entities at the end of the processor chain. Either way this looks like it will really complicate the current ingestion workflow and potentially cause breaking side effects.
An alternative solution here may be to create a new dedicated GHE processor that fetches all orgs/teams/users within your enterprise instance and emits group entities for all teams namespaced according to their origin org and a single set of unique user entities with group memberships set that correctly handles cross org team memberships. I'm happy to implement and contribute this new processor if it makes sense as a viable offering
cc: @freben for your thoughts here

You would probably need to write a custom code owners processor and replace the default one in order to handle this correctly. (also note that according to #4977 (comment) there's currently no way to just replace one processor)

The CodeOwnersProcessor should be updated to handle this naively. For instance:

Compare the org from the location target and the codeowner team and if they don't match use the fully qualified some-other-org:some-team form of the entity relation. Likely would need to be configurable as this may not be desired behaviour by default.
Provide a configurable org to namespace mapping then normalize function can use

I've also been debating a proposal to Introduce a new ownerr-managed-by-codeowners (name may change) annotation that could both be used to indicate the owner was derived from the codeowners. In this can it could also indicate a strategy, etc. used to resolve the owner. However, it may make sense to separate these 2 concerns.

Apply the same processing from LDAP

let me just note quickly that this code actually is not working right - the input schema says it should be an object [key: string]: JsonValue } but the code acts as if it's { key: string, value: JsonValue }[] (hope I got that right)
Just so nobody falls into a copy-paste trap :)
see discussion here https://github.com/backstage/backstage/pull/4871

Update on my end: I created a custom processor for my use-case.
It extends the functionality current GithubOrgReaderProcessor with the following changes:

Support GitHub app auth via GithubCredentialsProvider
Grab all orgs to be ingested by getting all org installations of the GitHub app (only supports the first github app defined in the config)
Loop through all orgs, creating groups from teams namespaced according to its org
Merge all users from each org and updates memberOf relations to account for cross org team memberships

I'm happy to contribute this back to the project/update the current GithubOrgReaderProcessor if people are interested. It could potentially also take in a list of orgs via the config and default to the above if not defined eg. GithubMultiOrgReaderProcessor as a separate processor

That's cool! Glad that you found the processors useful to extend.
The first is definitely wanted - it's an oversight that it doesn't support that yet I think.
The second one - yeah that's a sensible thing to do isn't it - the token issued by the app won't let you access other repos with it right? If so, then it's equally useful to contribute I think.
The last two are trickier. The org-to-namespace mapping and the user-merge logic may be more appropriate to handle in code, eg by initializing the processor using its constructor and  giving it callbacks. If you have ideas there, let me know!

Posted the implementation of our custom processor here for community feedback: https://github.com/backstage/backstage/pull/5173

PR is in progress, @kuangp just hasn't had time to fix up the work yet. Removing the stale label :)


Rediscover suggestion

Present look of the dialog:

TODO:

[x] Redicover schedule
[x] Do not ask again until the project (/IDE) reopening

the dialog will show up again after project reopening if declined

[ ] Dialog does not when the machete tab is opened on the project opening

WONT FIX: there is no simple way to subscribe for tool window opening :disappointed: anyway IMHO depending on the git machete tab opening is enough

[x] Hmmm.... would it be easily possible to show the branch layout before while the rediscover dialog is shown? As for now, when the rediscover dialog is showing, there's nothing in the graph table thinking

TESTING:
https://askubuntu.com/questions/62492/how-can-i-change-the-date-modified-created-of-a-file
touch -d "20 days ago" .git/machete

@mkondratek hmmm still getting the following:

so the graph table shows Loading... instead of the current layout when the dialog is shown... is it the same for you?
Maybe the dialog could be instead in the same non-modal way as the below Install Dependencies prompt?

Hmmm the dialog doesn't seem to be opening for me at all, even on some ancient projects I haven't opened in months... I can't spend any extra time on this today, lemme revisit this PR tmrw...

Actually... given that this functionality is rarely used (and hence won't be naturally dogfooded over time like e.g. push or rebase), maybe extending the existing com.virtuslab.gitmachete.uitest.UITestSuite#discoverBranchLayout with a call to java.io.File#setLastModified + then clicking the button on the dialog (as in Project.discoverBranchLayout in uiTests/src/test/resources/project.rhino.js) would be a good idea :thinking:

I'm afraid for some users this dialog can be annoying (e.g. when they don't need to use our plugin for some period of time in selected project). So maybe checkbox Don't show again can be a good idea?

Hmm @mkondratek now (as of 0.8.1-42-SNAPSHOT+git.21ea602) it seems that sometimes the dialog opens even if the tab isn't opened... not sure if intended, can be surprising for the user, esp. if they can't see what's the current branch layout:

If you can't reproduce locally, I can send some logs from my machine

And the other problem... after clicking No, sometimes the dialog re-opens...
Generally... maybe the better approach instead of a dialog on the center of the screen would be to open a more subtle dialog somewhere in the right-bottom corner of the IDE? As it's with IIRC whether to add file to Git index :thinking:


About the optimizer?

I found that the optimizer only load data at the beginning, will it reload new play data in the training progress?
2.Hope more log can be available, such as loss with step

better divide log into different file, haha

Hi @wjllance

I found that the optimizer only load data at the beginning, will it reload new play data in the training progress?

The optimizer reloads new play data at here.

2.Hope more log can be available, such as loss with step
better divide log into different file,

Surely. I think so too :)

So when the trainer pick a batch, it will pick from all  the old data, without ignoring the very begging play data, right?
If we can produce more self play data, maybe it's a better way to select from most recent data, does it make sense?

So when the trainer pick a batch, it will pick from all the old data, without ignoring the very begging play data, right?

Right.
Trainer picks up all data.

If we can produce more self play data, maybe it's a better way to select from most recent data, does it make sense?

The old data will be removed by self-play at here.
config.play_data.max_file_num decides how many old data are remained.

oh thx, you're so nice~


URGENT: Need to figure out the licensing

As others have discussed, the license that users will be uploading under needs to be figured out before launch.
If the goal is open-source, then it needs to be decided (or a range of options offered) which license(s) uploads apply to.
Creative Commons? MIT? GNU GPL? ....
Creative Commons makes the most sense to be because of the flexibility: attribution, commercial vs. non-commercial.
https://creativecommons.org/licenses/

Perhaps asking uploaders a few questions and assigning a license accordingly (requiring confirmation first).
Here's an example: https://chooser-beta.creativecommons.org/


Image distribution

Reading from the scope of the project seems like distribution is in scope. I would like to start a discussion about what tools and libraries contianerd could use to achieve that.
containers/image seems like a good fit for a decoupled image service built into containerd. It supports all major image formats and it's able to convert from/to them pretty easily. It could be easily extended to provide more functionalities as needed by containerd if you wish also.
We could move some of the missing (if any) docker functionalities in there in order to have something fully decoupled and reusable so other projects can benefit as well.
Taking a look at https://github.com/docker/containerd/blob/master/design/snapshots.md#importing-a-layer containers/image seems a good fit as it's able to just copy layers around to be later imported.
Containers/image is also being used by other projects already like skopeo and pivotal's grootfs without any issue at this point.
I would love to collaborate on this, given this distribution side of containerd will be fully decoupled to its own project.
@shykes @stevvooe @vbatts WDYT?

having a generic place for common logic is a great idea

The goal with https://github.com/containers/image and https://github.com/containers/storage it so allow other tools, like https://github.com/projectatomic/skopeo,  to be able to interact with the system simultaneously while larger daemon based systems like https://github.com/docker/docker, containerd, https://github.com/kubernetes-incubator/cri-o can also share the same libraries/infrastructure.

From https://github.com/docker/containerd/issues/378#issuecomment-267461438 it makes clear that the fetching mechanism can be totally built outside of containerd, I would love to join the effort in tools like skopeo instead of bundling something in here.

When starting out on this project, we took a deep look into both containers/image and containers/storage for possibly seeding the distribution components with these projects. We also attempted to spin out the components of the docker daemon, landing roughly in the same place as these other projects.
While containers/image and containers/storage does break out some core logic, it has adopted a verticalized model that is antithetical to the goals of this project and flexible container distribution as a whole.
In particular, the deep link between storage of image artifacts and their expanded counterparts forces a level of denormalization that has proved inflexible in the past. Providing a more concrete example, we can see from the width of the interfaces in https://github.com/containers/image/blob/master/types/types.go that there is more room for a proper abstraction. Taking ImageReference, as an example, we can see that naming, transport, policy, creation and deletion are tightly coupled. If we were to adopt this model as it stands, we'd hamstring the goals of this project and not address the valid criticisms of the community.
More formally, we need to cut these interfaces down to something that can be more readily stabilized. Smaller, well-behaved components do a much better job of supporting this goal. After deep analysis, we can see that the complex use cases of today can be supported by much thinner, simpler abstractions, ensuring the scope remains accurate and well-defined. Hopefully, we can make sure to meet your requirements within this project by ensuring that the correct components are broken out.
Specifically, the low-level docker components that we'll be taking in here are likely the following (this is by no means a complete list):

pkg/archive: this package needs to be cut down and reduce to layer application. Compression needs to be ripped out.
cut down graphdrivers refactored into snapshot drivers
the reference package will be merged back into distribution/reference and be usable (maybe not a part of containerd)
low-level key calculation and data types (chain ids, image config identifiers, etc.)

All of this work is part of drawing the correct line for a "boring container runtime" that has been somewhat elusive for the past few years. I hope it is very clear that this is quite incomplete and as we cut this line, we may want to add to this list of break out other components into containerd, based on need.
We should also see positive on OCI due to the high-level of integration with the image format and runtime specification.
The data-flow.md enshrines these concepts. It should provide a little more context than the snapshot.md design document.
Also, in the next few days, I'll be pushing some POC code that will validate the data flow design and help to define common metadata storage, image storage, bundle unpacking and content storage.

@stevvooe clear, I'm indeed keen to help and refactor containers/image as needed as proposed in my first comment. I fully agree with what you said and simplicity and simplification would be a great thing. The data-flow doc is crystal clear also. I would love to see these components entirely out of containerd so people can use them in their own project (pkg/ not being an option I guess as it moves at the pace of the project in which it lives). I would love to work together towards a set of projects that will help people achieve that.

If we are going to redesign the way containers are stored and images move back and forth to a the container registries, it should be done in independent repositories, not part of a large container runtime.  Lets work in containers/storage and containers/image and put the parts in place there.  Perhaps create containers/snapshot.  This needs to be independing of containerd, in order for lowlevel tools and other container runtimes to use them.

Also, in the next few days, I'll be pushing some POC code that will validate the data flow design and help to define common metadata storage, image storage, bundle unpacking and content storage.

I'll look forward for a pull request to chime in there also.

@stevvooe

pkg/archive: this package needs to be cut down and reduce to layer application. Compression needs to be ripped out.

Should we do split github.com/docker/docker/pkg/archive in the upstream github.com/docker/docker repo?
Or should we fork github.com/docker/docker/pkg/archive to github.com/docker/containerd/pkg/archive (or somewhere else)?

@AkihiroSuda I'm not sure what the right approach is there. pkg/archive has a lot of nice optimizations for unpacking but it, unfortunately, handles compression in a problematic manner, by treating tar and tar.gz as equivalent. There are also some functions in there that are very weird, seeming to be oriented towards making copies with tar files. I could not tell what is docker-specific and what is generally applicable.
I have some branches locally that experiment with separating out the compression.
I'd like to see package github.com/docker/containerd/archive that deals explicitly with tar unpacking. https://github.com/docker/containerd/pull/427 shapes the unpacking/apply side of those requirements. We'll need to look more into push to see what else is needed there.

Is this issue closable?
containerd itself seems not going to adopt containers/image, but higher-level engines can integrate containers/image to containerd, by just specifying rootfs string. (or implement a "glue" snapshotter plugin)

yes, I think so. Thanks for the ping @AkihiroSuda
We are interested in consuming a devicemapper implementation for snapshotter that is located other places because we don't want to have it in tree as we cannot support it.


Display Home devices keep old alarms thus "next alarm" is always the same old alarm in the sensor state

Describe the bug
The Google home devices with screen at least save all old alarms even after dismissed. Because of this the first alarm in the sensor state is the first one I ever set and can be weeks/months old and of no interest. It is only future alarms that are of interest in most usecases. The sensor should show the next upcoming alarm instead.

Version of the integration 1.4.2
If you are unsure about the version check the github release here.

Logs

Add your logs here.

Can you show how Alarms screen looks like on that device?


Release

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.26 :tada:
The release is available on:

GitHub release
v1.0.0-beta.26

Your semantic-release bot :package::rocket:


Add parquet catalog in Alluxio catalog service

Is your feature request related to a problem? Please describe.
no
Describe the solution you'd like
Alluxio add presto under catalog type that make parquet file which stored in Alluxio as a table just like Spark
Urgency
There is a big demand that users want to do some ad-hoc on presto with data produced by spark.
Now they need  create table in hive first and sync metastore in Alluxio. This mode is complex and not useful, because there are thousands of "tables" and some of them are temporary. It make a big sense users can simply use presto reading parquet data stored in alluxio.

@gpang can you take a look at this? thanks

@gpang can you take a look at this? thanks

Thx:）

catalog service is deprecated


Improve image creation to respect files with holes

Description
Currently the downloader.sh takes care of executing the specific downloader which prints the image in STDOUT. The image is then read and passed through different pipes to perform different actions.
The act of printing the images and the following pipes remove the holes making a larger file, this have an impact in the performance. It will help to improve the performance to make sure that those holes are not removed, specially for large empty images.
Additional Context
In order to fix this 3 main parts needs to be reworked:

The specific downloaders should pass the image in a different way (not printing them)
Pipes must be removed from the downloader.sh
Usage of scp in transfer/drivers should be replaced by rsync

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Is backward compatibility considered?
Looking forward to seeing how it will be implemented for ceph, for example :)

Hi @atodorov-storpool, there's nothing decided yet, but probably the idea is to change this in the creation process so it will only affect newly created images.

PRs to merge into master:

https://github.com/OpenNebula/one-ee/pull/240
https://github.com/OpenNebula/docs/pull/1359


Release beta-datastax-ops 2.1.1-6.1.2-beta (automated commit)

Release beta-datastax-ops 2.1.1-6.1.2-beta (automated commit)
Description:
Source URL: https://infinity-artifacts.s3.amazonaws.com/autodelete7d/datastax-ops/20171222-105614-3xlPK0uHzTvBCxqt/stub-universe-datastax-ops.json
Changes since revision 0:
0 files added: []
0 files removed: []
4 files changed:
--- 0/config.json
+++ 1/config.json
@@ -67,7 +67,10 @@
           "title": "OpsCenter placement constraint",
           "description": "Placement constraints for the OpsCenter node. Example: hostname:UNIQUE",
           "type": "string",
-          "default": ""
+          "default": "",
+          "media": {
+            "type": "application/x-zone-constraints+json"
+          }
         },
         "virtual_network": {
           "description": "Name of virtual network for Opscenter pod(s)",
--- 0/marathon.json.mustache
+++ 1/marathon.json.mustache
@@ -22,9 +22,9 @@
   {{/service.service_secret_name}}
   "env": {
     "PACKAGE_NAME": "beta-datastax-ops",
-    "PACKAGE_VERSION": "2.1.0-6.1.2-beta",
-    "PACKAGE_BUILD_TIME_EPOCH_MS": "1513388807267",
-    "PACKAGE_BUILD_TIME_STR": "Sat Dec 16 2017 01:46:47 +0000",
+    "PACKAGE_VERSION": "2.1.1-6.1.2-beta",
+    "PACKAGE_BUILD_TIME_EPOCH_MS": "1513968976933",
+    "PACKAGE_BUILD_TIME_STR": "Fri Dec 22 2017 18:56:16 +0000",
     "MESOS_API_VERSION": "{{service.mesos_api_version}}",
     "TASKCFG_ALL_DS_LICENSE": "accept",
     "FRAMEWORK_NAME": "{{service.name}}",
--- 0/package.json
+++ 1/package.json
@@ -1,9 +1,13 @@
 {
     "packagingVersion": "4.0",
     "name": "beta-datastax-ops",
-    "version": "2.1.0-6.1.2-beta",
-    "upgradesFrom": [ ],
-    "downgradesTo": [ ],
+    "version": "2.1.1-6.1.2-beta",
+    "upgradesFrom": [
+        "2.0.5-6.1.2"
+    ],
+    "downgradesTo": [
+        "2.0.5-6.1.2"
+    ],
     "maintainer"<EMAIL_ADDRESS>     "minDcosReleaseVersion": "1.9",
     "description": "Datastax Enterprise OpsCenter",
@@ -18,7 +22,7 @@
         "nosql",
         "database"
     ],
-    "preInstallNotes":  "This DC/OS Service is maintained by DataStax and available to mutual DataStax and Mesosphere customers (eval and production) and prospects (eval) .\n\nFunctionality supported in Opscenter includes Repair, Monitoring, Backup & Restore, as well as some basic admin tools including cleanup, restart, and drain. No other OpsCenter functionality is tested or supported within the DC/OS Integration. Please make any feature requests to<EMAIL_ADDRESS>configuration requires 1 agent node with: 2.5 CPU | 4100 MB MEM | 10240 MB Disk\n\nContact Mesosphere and DataStax before deploying this service to ensure proper support channels are made available. Contact your rep at either company or<EMAIL_ADDRESS>By using this service you agree to the license terms here: https://gist.github.com/012345/d1df9d43a0dfaa49e628c7bfbc9ffb52\n\nVersions: DataStax Enterprise 5.1.2 (Standard and Max) & OpsCenter 6.1.2",
+    "preInstallNotes": "This DC/OS Service is maintained by DataStax and available to mutual DataStax and Mesosphere customers (eval and production) and prospects (eval) .\n\nFunctionality supported in Opscenter includes Repair, Monitoring, Backup & Restore, as well as some basic admin tools including cleanup, restart, and drain. No other OpsCenter functionality is tested or supported within the DC/OS Integration. Please make any feature requests to<EMAIL_ADDRESS>configuration requires 1 agent node with: 2.5 CPU | 4100 MB MEM | 10240 MB Disk\n\nContact Mesosphere and DataStax before deploying this service to ensure proper support channels are made available. Contact your rep at either company or<EMAIL_ADDRESS>By using this service you agree to the license terms here: https://gist.github.com/012345/d1df9d43a0dfaa49e628c7bfbc9ffb52\n\nVersions: DataStax Enterprise 5.1.2 (Standard and Max) & OpsCenter 6.1.2",
     "postInstallNotes": "DC/OS Datastax Enterprise OpsCenter is being installed!\n\n\tDocumentation: https://docs.datastax.com\n\tIssues: https://www.datastax.com/contactus",
     "postUninstallNotes": "DC/OS Datastax Enterprise OpsCenter is being uninstalled.\n\nFor DC/OS versions from 1.10 no further action is required. For older DC/OS versions follow the instructions at https://docs.mesosphere.com/service-docs/dse/v2.0.0-5.1.2/uninstall/ to remove any persistent state if required."
 }
--- 0/resource.json
+++ 1/resource.json
@@ -8,9 +8,9 @@
     "uris": {
       "jre-tar-gz": "https://downloads.mesosphere.com/java/jre-8u152-linux-x64.tar.gz",
       "libmesos-bundle-tar-gz": "https://downloads.mesosphere.io/libmesos-bundle/libmesos-bundle-1.10-1.4-63e0814.tar.gz",
-      "opscenter-init-zip": "https://downloads.mesosphere.com/datastax-ops/assets/2.1.0-6.1.2-beta/opscenter-init.zip",
+      "opscenter-init-zip": "https://downloads.mesosphere.com/datastax-ops/assets/2.1.1-6.1.2-beta/opscenter-init.zip",
       "bootstrap-zip": "https://downloads.mesosphere.com/dcos-commons/artifacts/0.31.1/bootstrap.zip",
-      "scheduler-zip": "https://downloads.mesosphere.com/datastax-ops/assets/2.1.0-6.1.2-beta/datastax-ops-scheduler.zip",
+      "scheduler-zip": "https://downloads.mesosphere.com/datastax-ops/assets/2.1.1-6.1.2-beta/datastax-ops-scheduler.zip",
       "executor-zip": "https://downloads.mesosphere.com/dcos-commons/artifacts/0.31.1/executor.zip"
     }
   },
@@ -26,11 +26,11 @@
           "contentHash": [
             {
               "algo": "sha256",
-              "value": "54f3f7ebb5e50b66a3670ce21b4b6efee7f69d3c2e4495117c1e103b47216390"
+              "value": "7ea914f76fd5f33e18ca07703c17fea6d94bda0011565c1c4682c3fcaa42ebce"
             }
           ],
           "kind": "executable",
-          "url": "https://downloads.mesosphere.com/datastax-ops/assets/2.1.0-6.1.2-beta/dcos-service-cli-darwin"
+          "url": "https://downloads.mesosphere.com/datastax-ops/assets/2.1.1-6.1.2-beta/dcos-service-cli-darwin"
         }
       },
       "linux": {
@@ -38,11 +38,11 @@
           "contentHash": [
             {
               "algo": "sha256",
-              "value": "7fc7934726ba189794826312070b36765823fc8fc685ea288f26df821db96072"
+              "value": "c5609774288cbc406d16e9ba91191abf343dd5f047bdbd8be45bb09ca7e013af"
             }
           ],
           "kind": "executable",
-          "url": "https://downloads.mesosphere.com/datastax-ops/assets/2.1.0-6.1.2-beta/dcos-service-cli-linux"
+          "url": "https://downloads.mesosphere.com/datastax-ops/assets/2.1.1-6.1.2-beta/dcos-service-cli-linux"
         }
       },
       "windows": {
@@ -50,11 +50,11 @@
           "contentHash": [
             {
               "algo": "sha256",
-              "value": "145672a9192dd9735e50ec720086af8d7388f2ab9f5603cc2813afdbec8e94be"
+              "value": "83d54e988a558a8ac5acfae7331983aaf197d5eeccc53a502c562f7d9f2b42d3"
             }
           ],
           "kind": "executable",
-          "url": "https://downloads.mesosphere.com/datastax-ops/assets/2.1.0-6.1.2-beta/dcos-service-cli.exe"
+          "url": "https://downloads.mesosphere.com/datastax-ops/assets/2.1.1-6.1.2-beta/dcos-service-cli.exe"
         }
       }
     }

Updated the upgradesFrom and downgradesTo fields manually. See the files not the diff.


Wrong frames in profile

Not sure if this is an issue only happening to the dwarf-based unwinder. It used to work fine (https://github.com/parca-dev/parca-agent/commit/0abd8e737e1f931ea3990953643577ef4208096a) but now it's broken.
This might be an issue in the unwinder, profile generation, or backend. Needs more investigation

cc @kakkoyun

I think this is a Parca issue because that same revision shows the broken stacks now

Which version of parca was this using?

Unfortunately, I don't remember, but I think it was a bit old. Tried on this revision and it was all good, so closing this issue :)
commit 6dfde342f6a489f34c91c92130ee6ed414bd0bb6 (HEAD -> main)
Author: renovate[bot]<EMAIL_ADDRESS>Date:   Sun Nov 13 20:00:47 2022 +0000

    chore(deps): update quay.io/containers/podman docker tag to v4.3.0 (#2098)

    Co-authored-by: renovate[bot]<EMAIL_ADDRESS>


replace postcss-nesting to postcss-nested

Replace postcss-nesting with postcss-nested because of the second one is more powerful.

Not following the specs. So nope.


Allow custom system message / conversation restart

(Future) idea: Store system message in cookie / localstorage
Also add current date to system message - could conflict with storing system message in cookie

Current state allows deletion of individual messages, so user can delete system message


Calendar: month names are not translated

https://www.boonex.com/forums/topic/Calendar-language-problem.htm
BxDolCalendar.php:185

return $this->sMonthName . ', ' . $this->iYear;

return t(''.$this->sMonthName) . ', ' . $this->iYear;

Month name should be translated, because it is generated using strftime php function with the current locale

That doesn't work on demo.boonex.com (set lang to russian).
Server locale and chosen language in dolphin can differ.

other suggestion:
BxDolCalendar.php:59

$this->sMonthName = strftime('%B', mktime(0, 0, 0, $this->iMonth+1, $iDay, $this->iYear));

$this->sMonthName = t($this->iMonth+1);

…and make new lang keys for months

We'll check what is the problem...


How can I visualize(output) the results

I want to get visualized results after training and creating model. How can I do it?

???


add user guide onboarding [skip-ci]

Add the documentation on user & organization onboarding

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Precompile plugin.css

Hello and thanks for the gem.
Today I deployed my application on Heroku and all the css files that are under the plugins folder are not found. I imported them with @import "tabler.plugins". They are working fine if I set config.assets.compile = true, although it is not advised on production.

@fibice3 Thanks for reporting this. I suppose the solution here is to provide a precompiled version of all the plugins while still maintaining the ability to import specific plugins if needed. Does that sound right?

+1 for this. I am importing the plugins via
@import "tabler";
@import "tabler.plugins";

And getting the following error for all plugins. This is just one of them
/assets/tabler/plugins/maps-google/plugin.css 404 (Not Found)

This is being addressed by #8 (in progress).

This has been fixed in the latest release https://github.com/lightyrs/tabler-rubygem/releases/tag/0.1.3


mark Set2List as functional

It is definitely defined, though. This is a common problem: we don't have a separate total attribute, just functional = function + total.


Minor logic fixes

the f174929 is the most important. the count_hits was not counting 6s as hits.
More explanation:
https://doc.rust-lang.org/rust-by-example/flow_control/for.html

One of the easiest ways to create an iterator is to use the range notation a..b. This yields values from a (inclusive) to b (exclusive) in steps of one.

In f174929, the for loop should count only 5 and 6, so the range should read as 5..=6 I will fix this myself after the merge


Error using Lambda Layers

SUMMARY

ISSUE TYPE
Following error while using Lambda layers
2020-11-17T19:31:59.463+00:00Copy2020-11-17T19:31:59.463Z	8628727c-35b3-4963-a660-aa82557d5217	ERROR	Error during Cleanup - Error: Error Deleting Bucket: [smec244-smec-s3-contract-lifecycle-bucket] - Error Listing Objects in Bucket: [smec244-smec-s3-contract-lifecycle-bucket] - s3.listObjectsV2 is not a function | 2020-11-17T19:31:59.463Z 8628727c-35b3-4963-a660-aa82557d5217 ERROR Error during Cleanup - Error: Error Deleting Bucket: [smec244-smec-s3-contract-lifecycle-bucket] - Error Listing Objects in Bucket: [smec244-smec-s3-contract-lifecycle-bucket] - s3.listObjectsV2 is not a function

-- | --
VERSIONS

All versions using lambda layers

CONFIGURATION

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

@mfarrow701 something to look at. I'll roll back the lambda layers for the moment.

Upon further investigation, it appears that https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/welcome.html#using_v3_commands needs to be used for this to work.


Request for transfer: power-assert-js organization

Hi, I'm the author of power-assert and created an organization power-assert-js to help users finding related products easily.
Today I want you to join us and transfer this project to power-assert-js organization.
If you agree with me, first I invite you to our organization, then request you to transfer this repo. Please see about repository transfers for details. If you do not want to transfer, it's no problem at all ;)
Thanks!

Hiya, OFC I'd love to transfer this repo to the org since the code is stable already, and it makes maintenance easier. Could I have the invitation?

Plus, I will give you a permission to publish the module on the npm registry :)

@watilde Thanks & Invited!

It's shipped as v1.0.0, and you are in the list of the publisher team on the registry;
$ npm info karma-power-assert versions
[ '0.0.1', '0.0.2', '0.0.3', '0.0.4', '0.0.5', '1.0.0' ]

The team: https://www.npmjs.com/package/karma-power-assert/access
Thanks! Closing as resolved.

Great 🎉


tech tags for search

first was pass just js libraries which doesn't seem to interesting. i think second pass should be techniques/experience or something (eg. scrollytelling, audio)


add ignore_list to config

Short Description:
I just want to add ignore_lis to config, when some body don't want to catch a list of pokemons, they can ignore.
Please teach me if any wrong.
Thansk.

master is feature frozen until we have a stable version of the dev


send message to non-contact

Folks,
I did not find in the documentation how we do to send messages to people that I never had any conversation on whats.
when i try to send it to someone tell me the message on the console * not a contact *.
is there how to do this?
@joaomirandasa

Migrate to https://chat-api.io


Write failed: Broken pipe

Hi.
I'm facing an issue with vagrant-vcloud fails due to the mentioned above error.
After some research, i found that it occurs during vagrant copying files (files which in the vagrant project folder) to the VM.
Later on i opened the VM by using VMWare Remote console plugin and i saw that during the process of copying files, the VM auto reboot and this is why i get Broken pipe (While copying a file, the VM reboot).
I asked some IT personal and they told me that auto reboot for VMs in vCloud always happen due to configuring hardware (the VM auto reboot after 3-4 minutes from the first time its powered on).
To verify it, i created a windows VM and powered it on.
After 3-4 minutes it was automatically reboot (just once from the first time it powered on).
Any ideas on how to solve this?
UPDATE: It is more accurate to say that it happens in the phase of sync folder /vagrant
Thanks in advance,
Dor

@dorheini I had the same issue with a second reboot. The first reboot is for guest customization and the packer-windows templates I use open the WinRM port after renaming the guest VM. But then there was a second reboot while rsyncing or provisioning the VM. After a couple of retries I found my problem. The VMware Tools in my guest VM's were too old and it seems that these tools are automatically updated.
So try to update the VMware tools in your VM's to the latest (version 9.9.3 AFAIK).
If you use the packer templates from the packer-windows repo, the PR joefitzgerald/packer-windows#162 should be applied.

Hi Stefan.
Thanks for the quick replay.
The VMware tools version depends on the ESX version.
after running the following: vmware-toolbox-cmd -v
i got: 9.0.10
How can i update it from the guest VM? is it possible at all?
BTW, my VM's OS is Fedora 20 (terminal only, no GUI) and the vCloud director version is 5.1
I Managed to install the VMware tools but as i said before the version is 9.0.10:

After installing the VMware tools version above, i;m still experiencing the problem of broken pipe due to second reboot while vagrant executes resync action

@dorheini I do not have experience with Fedora. But a look at boxcutter/fedora shows me this provision script https://github.com/boxcutter/fedora/blob/master/script/vmtool.sh that uses VMware Tools 9.2.2 or 9.6.0. You might have a look at it.
The boxcutter repos are a good starting point to create Vagrant boxes with packer. We have some of the boxcutter/ubuntu boxes in our vCloud.


Client removes columns from output if they are not aliased

Hello,
I'm encountering a weird behavior of the client.
Consider this alias - less query:
connection = ...
with connection.cursor(cursor_type="dict") as cur:
    cure.execute("SELECT ('hello'), (33) FROM (select 1 as foo) bar")
    actual = list(cur.iterate())
assert (actual) == 2 # fails - getting [OrderedDict([('?column?', 33)])]

And consider this alternative:
connection = ...
with connection.cursor(cursor_type="dict") as cur:
    cure.execute("SELECT ('hello') as a, (33) as b FROM (select 1 as foo) bar")
    actual = list(cur.iterate())
assert (actual) == 2 # pass - getting [OrderedDict([('a', 'hello'), ('b', 33)])]

Expected:
As query states I'd like to receive 2 result sets: one for the string value and the second for the int value.
something like: [OrderedDict([('?column?', 'hello')]), OrderedDict([('?column?', 33)])]
Current result:
Getting only 1 result set of the query although it should return 2.
Additional info:
vetica_python version is 1.3.1
sys.version is 3.8.13 (default, Apr  7 2022, 19:59:24) \n[Clang 13.1.6 (clang-13<IP_ADDRESS>)]'
uname -a is Darwin Foo-MacBook-Pro.local 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar  6 21:00:17 PST 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64
I also ran the problematic query over verica directly. There the expected result is returned:

Would be more than happy to assist any way I can to fix this!

Actually, it's perfect!  Did not think about it, Thanks :)


Patch SM gate out channel reversal

In working with oopsy, I noticed that the gate_out_1 and gate_out_2 channels seemed reversed. I double checked all the schematics and the gen setup, but there wasn't a reversal error anywhere. It looks like this might be a similar problem to #268.
I'm not sure if anyone else is experiencing this issue, but if so please comment!

Not related to the channel swapping, just a schematic nuance from pin-swapping and stuff. Similar thing happened with some of the ADC channels.
the gateoutN net connected to the MCU have the opposite name as the net going to the pins. So they are swapped, but can be fixed by updating the GPIO assignment.


Update doc

Requirements -> Prerequisites

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Format without saving

Is there a way to format a file without automatically saving it? I read the docs, but didn't find anything about it there. If not, is it possible to implement this feature as an option? Thanks!

Hi @nikolvs
Hi @nikolvs,
Thanks for raising this question. Prettier async always saves the file, but if you run the synchronous version it should'nt save it.
:Prettier
One common problem is when you setup your .vimrc to use async by default with:
let g:prettier#exec_cmd_async = 1

The above will cause :Prettier to run as an alias for :PrettierAsync.

Please try the above and let me know if that solve your problem (removing the flag that forces async formatting from your .vimrc)

I also wonder how could we solve this problem differently, Im not sure if adding yet another configuration option is the right solution since that would make thing even harder to configure

Hey @mitermayer, that solved my problem! Thanks!!

Is there any chance async would work without saving the buffer?

@AngeloMateus  feel free to submit this as a separate issue and I can look into it, should not be a problem.


updgrade to jcifs 1.3.17

An upgrade from a very old jcifs to almost the new one
(The newest one is 1.3.18, but is not in the maven repository).

Thanks! :+1:


Passing along cookies in requests

I website which uses its session cookie features to keep a very basic 'login' (I don't require security features).
I'm trying to implement iodocs documentation. The "/login" works fine, and I also see the response with the cookie being sent, but I can't figure out how to tell iodocs to keep that cookie for the next API calls.
Any help (that wouldn't require my site to change to OAuth) would be highly appreciated.

:+1:


Autoloader include

Description
This issue arose with the Autoloader. I don't understand all the nuances of the difference but I thought I'd at least run it through the tests and see if anyone else here with more Autoloader experience had ideas.
See: https://github.com/phpstan/phpstan/issues/3907
Checklist:

[X] Securely signed commits
[X] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
n/a User guide updated
[X] Conforms to style guide

Good solution but i think you forgot renaming requireFile method to includeFile also editing DocBlock.

Both good suggestions! But I need to make sure this is even theoretically viable first.


Is it possible/recommended to do open generation?

Thanks for sharing the great work!
I'm curious if it is appropriate to do open generation. E.g. put only [gMASK] at the beginning and then complete the text.
Thank you again!

Hello @LorrinWWW. GLM-130B can still generate fluent sentences in this scenario, you can generate different sentences by changing the seed. However, we are also not sure if it is appropriate, it maybe depends on what you want to do.

Thanks for your answer! Another question is do you have any suggestion on performing batch generation?

Currently we don't support batch generation, but I'm guessing it's not too hard to modify the autoregressive generation logic and its corresponding strategy in SAT to support batch generation with a fixed context length (or no context).

Thank you very much!


Cleanup the fdb version features from primary crate

There was no decent way to select FDB versions from the primary crate.
this disables all features in the sys crate from the fdb crate,
and clones all the feature names to make it possible to enable
each as necessary.

@yjh0502 any concerns with me merging this?

Oh, sorry for confusion. I understood your point, and the solution looks fine!


Small print.hpp documentation update

According to https://stackoverflow.com/questions/20944784/why-is-conversion-from-string-constant-to-char-valid-in-c-but-invalid-in-c. As I don't write a lot of cpp myself I'm not 100% sure why this is, but at least the code compiles with that.

Yep, const is correct there, but we use const char * rather than char const * -- please switch those around.


Benchmark app frame time improvements

Refactored benchmark app to use headless frontend for an accurate measurement of the frame time.
Make sure to set the Benchmark app on Release, without Debug executable set and disable Metal API validation:

Could you share some more details about why these changes were needed here, as well as your test results?

Old implementation was rendering directly to the MTKView or on screen. Because of that, frame measurement was affected by waiting for new drawable to be available in the MTKView. Because the display is set to 60 fps, new drawable is available one time at 16.666 ms. Even though the encoding of the gpu commands would have taken less than 16.666 ms, the frame time would measure 16.66 ms because it was waiting for the new drawable.
In order have an accurate measurement and not being affected by this waiting time (when new drawable is available) I had to render the map to an offscreen texture, using the headless frontend. In this way I can render frame after frame without being limited by vsync of 60 fps and measure correctly the encoding time of the gpu command.
Latest results using refactored Benchmark app:

s.


subsys: settings: Invalidate entry with the same key in FCB

Without this PR, entries with the same key name are present in FCB setting partition as many time as they have been written.
All these duplicated keys are loaded at the initialisation of the settings subsystem. The consumer of these settings will be notified for each of these key.
It could lead to issues in the caller logic.
See my comment to see how it affects Zephyr bluetooth stack: https://github.com/zephyrproject-rtos/zephyr/issues/11409#issuecomment-440630063
With this change, support for deleting settings should be easier to implement properly. Today, to delete a key, users use settings_save_one("mykey", NULL). Rather than deleting the key it creates a new key with the NULL value.
Signed-off-by: Olivier Martin<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@53982b7). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11574   +/-   ##
=========================================
  Coverage          ?   48.33%
=========================================
  Files             ?      270
  Lines             ?    42113
  Branches          ?    10138
=========================================
  Hits              ?    20355
  Misses            ?    17673
  Partials          ?     4085

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53982b7...a56b6f5. Read the comment docs.

I will add this patch to my PR https://github.com/zephyrproject-rtos/zephyr/pull/9521.
So coding style improvement not required there.
Please DNM this before #9521 (will try to finish mine PR today).

Without this PR, entries with the same key name are present in FCB setting partition as many time as they have been written.
All these duplicated keys are loaded at the initialisation of the settings subsystem. The consumer of these settings will be notified for each of these key.

It could lead to issues in the caller logic.

This is the reason for implementing  keep h_commit handler. When loading of settings is done this handler is called for informing the application that most recently configuration was loaded.
I reviewed the algorithm. As now I see it is using read-modify-write for making any name-value pair invalid.
Such operation is forbidden for many of Flash devices -some of them have ECC feutre, others has appropriate obstacle described in their manuals.
So if you want to introduce something like this you should align size of the new field you introduced to the smallest write block for the flash device (this can be fetched form the flash driver API).
I also recommend to put changes onto https://github.com/zephyrproject-rtos/zephyr/pull/9521 because   it changes a lot entire implementation of the settings subsystem.
Feature you introduced should has appropriate kconfig key, at last to inform application at compile time that such feature is enabled (probably shouldn't be enabled for FS). I can stand something like SETTINGS_AVOID_MULTIPLE _LOADS or so.

Is this one still valid? Should it be rebased or just closed without merging?

As wrote before:

I reviewed the algorithm. As now I see it is using read-modify-write for making any name-value pair invalid.
Such operation is forbidden for many of Flash devices -some of them have ECC feutre, others has appropriate obstacle described in their manuals.

So if you want to introduce something like this you should align size of the new field you introduced to the smallest write block for the flash device (this can be fetched form the flash driver API).

So rebase is not enough - this is technical issue.

@Olivier-ProGlove Do you still want to work on this PR? I believe the objective behind this PR was fulfilled by #19541.

no response, closing


how to let notifier in appDelegate work in all viewController by a label indicate internet status

I want to create label in all viewControllers And I want the labels always indicate a connection status in any viewController I open.
thanx.

The simplest thing you could do is create a static variable in your app delegate (or preferably another location where you can get hold of the variable) and then access the value wherever you need it:
e.g. create the variable:
var connectivityStatus: Connectivity.Status?

ensuring you set its value somewhere in the app delegate:
let connectivity = Connectivity()
connectivity.checkConnectivity { [weak self] connectivity in
    self?.connectivityStatus = connectivity.status
}

and then in your view controller:
if let appDelegate = UIApplication.shared.delegate as? MyAppDelegate,
    let status = appDelegate.connectivityStatus {
    myLabel.text = status.description
}

Hope this helps 👍🏻


Add more Bodies to the bodies module

🐞 Problem
Currently, the bodies module only has 2 bodies. The list can be extended.
🎯 Goal
A better plotting experience

💡 Possible solutions

📋  Steps to solve the problem

Comment below about what you've started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Addresses #<put issue number here>
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

I will work on it. I have created classes for moon, 7 other planets of solar system and Pluto. I will be adding mass and radius details. I have already done for Moon.

@shreyasbapat I would like to work on this issue .
Also, could you give details of what changes should I do to achieve this


🥹

Hi Authors,
This paper is really beautiful, thank you.
I'm thinking of using some of the old 78s with the restoration technique you displayed in the paper. In your testing, did the vocals maintain quality with this method?
Thank you.

Hi,
Thanks you for your intererest!
We don't have a working model for singing voice yet. So far, we have only published trained models for piano, strings, woodwind and brass instruments.

Hi Eloi!
Any progress on this? I'm also very keen on testing this to restore old 78s and rare LPs in bad condition. Those would be full bands in almost all cases.
Thanks!

Hi!  I'm writing a paper about that at the moment.  The paper will be out in a couple of weeks (hopefully).  It now works much better for the restoration of 78s. For simplicity reasons, I've only focused on solo piano recordings and separated  vocal recordings. However, it may be possible to apply the method to different kinds of content if you fine-tune a diffusion model with a small reference set (a couple of high quality recordings similar to the old one).
I'll try to prepare a cleaner repository that is easier to use and fine-tune.

Oh, cool that you noticed that. The pre-print will appear on arxiv later this week :)

Hi! The pre-print is on archive already
https://arxiv.org/abs/2403.18636


Add topology.ReplaceNode() for efficiency

In some places AddNode() was called after adding to an existing node, in which case the Merge() is just a waste of time.
Spotted in a memory profile of the probe: about 14% of all memory allocated is in Merge():
----------------------------------------------------------+-------------
      flat  flat%   sum%        cum   cum%   calls calls% + context
----------------------------------------------------------+-------------
                                        16356.22MB 41.27% |   github.com/weaveworks/scope/probe.topologyTagger.Tag.func1 /go/src/github.com/weaveworks/scope/probe/topology_tagger.go
                                        12215.04MB 30.82% |   github.com/weaveworks/scope/probe/host.Tagger.Tag /go/src/github.com/weaveworks/scope/probe/host/tagger.go
                                         4821.62MB 12.17% |   github.com/weaveworks/scope/probe/endpoint.(*connectionTracker).addConnection /go/src/github.com/weaveworks/scope/probe/endpoint/connection_tracker.go
                                         2768.72MB  6.99% |   github.com/weaveworks/scope/probe/docker.(*Tagger).tag /go/src/github.com/weaveworks/scope/probe/docker/tagger.go
                                         1511.73MB  3.81% |   github.com/weaveworks/scope/probe/process.(*Reporter).processTopology.func1 /go/src/github.com/weaveworks/scope/probe/process/reporter.go
                                          557.68MB  1.41% |   github.com/weaveworks/scope/probe/endpoint.natMapper.applyNAT.func1 /go/src/github.com/weaveworks/scope/probe/endpoint/nat.go
                                          400.83MB  1.01% |   github.com/weaveworks/scope/probe/docker.(*Reporter).containerTopology /go/src/github.com/weaveworks/scope/probe/docker/reporter.go
                                          375.10MB  0.95% |   github.com/weaveworks/scope/probe/docker.(*Reporter).containerImageTopology.func1 /go/src/github.com/weaveworks/scope/probe/docker/reporter.go
...
         0     0%     0% 39630.96MB 17.84%                | github.com/weaveworks/scope/report.Topology.AddNode /go/src/github.com/weaveworks/scope/report/topology.go
                                        34675.80MB 87.50% |   github.com/weaveworks/scope/report.Node.Merge /go/src/github.com/weaveworks/scope/report/node.go
                                         4955.16MB 12.50% |   runtime.mapassign /usr/local/go/src/runtime/hashmap.go
----------------------------------------------------------+-------------

The three call sites in this PR are number 1, 2 ~and 4~ in the above profile; number 3 is not directly replacing an existing node so left as-is.

In some places AddNode() was called after adding to an existing node, in which case the Merge() is just a waste of time.

That is only correct if all information in the existing node that needs preserving is also present in the new node. It is not at all obvious whether that is the case for the call sites changed in this PR.

I changed back one case where there is a curious variable shadowing to confuse the unwary.

Pls squash before merging.


AllocGadget inconsistencies for curve points

AllocGadget implementation for twisted Edwards curve points always performs on-curve checks, but offers subgroup checks only for auxiliary inputs. So to do the subgroup check for a public input point one has to allocate a new point and check the equality that costs, say, 5 extra constraints. At the same time there's no way to allocate an input point without any checks, while there is "alloc_without_check" for aux inputs. And for short Weierstrass "alloc_input" doesn't do any checks.
Also there's no way to "inputize" (like in bellman) a point allocated by a gadget.

This is now fixed in master, by default allocating both public and private inputs performs a subgroup check, with explicit opt-outs available as separate methods on the GroupVar trait.


Chrome doesn't display social links

Author's twitter, facebook, email, etc. are not displayed in Chrome.
In Firefox everything works as it should.

Chances are you have an ad blocking plugin installed. They often remove social links and you need to whitelist them or change some settings.

Yeap, that was AdBlock.
Any clues why is it blocking those links by default?

Not sure. All I know is a lot of ad blockers are overly aggressive and
remove anything faintly associated with ad networks or social networking.
They're trying to block privacy intrusive social scripts (which the theme
doesn't use) and by consequence the Fint Awesome icons and links get
stripped.
Check the closed issues. Pretty sure this has come up a bunch before.
On Thursday, December 3, 2015, ddd-workshop<EMAIL_ADDRESS>wrote:

Yeap, that was AdBlock.
Any clues why is it blocking those links by default?
—
Reply to this email directly or view it on GitHub
https://github.com/mmistakes/minimal-mistakes/issues/203#issuecomment-161792115
.

Yup - https://github.com/mmistakes/minimal-mistakes/issues/78#issuecomment-54005612

I am encountering the same issue in MinimalMistakes v 4.16.4, but this time is in Firefox x64 v67.0.4 + uBlock Origin 1.20.0. Everything works fine on Chrome x64 v75.0.3770.100 and the same uBlock Origin version. The problem can be reproduced on the official demo site.


add vendor to gitignore for local bundle deployments

👍
NOTE: I'll merge this with CI build failure which cause of installing rainbow gem failed.


Markers does not represent the correct location

None of the coordinates are plotting the correct location. I have tried many locations and verified the coordinates with google maps, it always plots in a different location.
You can verify this issue from this example from your official site - https://www.react-simple-maps.io/examples/basic-markers/
If you crosscheck the coordinates from the example in google maps, its very different for the mentioned location.
@Team,
I am relying on this fix. I really liked your library, it serves all my requirements except the markers. Kindly requesting you to fix this issue.

I swapped longitude with latitude and vice versa, marker is plotting correct location.


Billing plan change page bug

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[ ] This issue affects my Ory Cloud project.
[ ] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Describe the bug
At console.ory.sh, when I change my plan from "Startup" to "Developer" in "Usage & Billing", this occurs:

After refreshing the page, plan remains "Startup"
Reproducing the bug

Create a profile on console.ory,sh
Use "FIRST900" code for startup account
Try to change billing plan from "Startup" to "Developer"

Relevant log output
No response
Relevant configuration
No response
Version
cloud
On which operating system are you observing this issue?
No response
In which environment are you deploying?
No response
Additional Context
I'm aware of monthly bills, while I'm not using cloud version of kratos.

Thank you very much for the report! @zepatrik can you PTAL?

I tried a few times but could not reproduce it. I think this was only a temporary issue. Can you try again? I get the expected result:

Can we move to Slack #cloud channel? I try to change it like every 2 or 3 days and the same thing occurs. I’ve checked all elements and responses and found this error coming from server:
{"error":{"code":500,"status":"Internal Server Error","request":"f6cc64b5-47bb-9d0e-a914-e32d30efdb3a","message":"{"status":400,"message":"You cannot update a subscription schedule that is currently in the released status. It must be in not_started, active status to be updated.","request_id":"req_nVWE6sHtYiE5Mn","type":"invalid_request_error"}"}}

On 22 Jun 2022, at 14:05, Patrik @.***> wrote:

I tried a few times but could not reproduce it. I think this was only a temporary issue. Can you try again? I get the expected result:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

I see, with the response I now know that the issue is. We have it tracked already (https://github.com/ory-corp/cloud/issues/2410).

@zepatrik can we fix the subscription @Marsredskies is referencing to hotfix this issue?

I've canceled your subscription now - sorry for the poor experience!
If I may ask - What stopped you from adopting Ory Cloud and what were you missing? Thanks a lot!

And yeah, thank you for your support

On 22 Jun 2022, at 18:55, Klaus Herrmann @.***> wrote:

I've canceled your subscription now - sorry for the poor experience!
If I may ask - What stopped you from adopting Ory Cloud and what were you missing? Thanks a lot!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

Thanks! :)

This should be fixed now for new  subscriptions, and should be fixed for all others probably today.


In Dark mode text is not visible properly.

Description
"Write a caption is not visible in dark mode."
@narayan954 Please assign this issue to me under gssoc23
Steps to reproduce
We can change the color of the text to white.
Screenshots
In dark mode:

In light mode:

Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response

Description
"Write a caption is not visible in dark mode."
@narayan954 Please assign this issue to me under gssoc23
Steps to reproduce
We can change the color of the text to white.
Screenshots
In dark mode:
In light mode:
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response

yes we need to use variables instead of direct color for this purpose. But perhaps this'd be a one line change and I've been asked to not allow single line issues. So can you please add atleast one simple issue to this ? I'd suggest working on this issue only but for other components of the app as well such as the post content is not visible as well due to this same reason. Can you please fix all of these similar issues?


Missing rollup function

Hello,
I'm using GraphiteMergeTree with rollup function 'quantile' (https://clickhouse-docs.readthedocs.io/en/latest/agg_functions/#quantile-level-x). It seems that graphite-clcikhouse does not support this function.
2020/01/14 10:48:19 unknown function "quantile(0.95)"

It probably should be here: https://github.com/lomik/graphite-clickhouse/blob/a6fed39d02064bf520d2201dfdfafd341a66d051/helper/rollup/aggr.go
Is it possible to add it ? :)
Regads,
Mateusz

Hey @matiza5, it's a little bit complex to implement.
Although it's possible. And, I guess, after the recently implemented ClickHouse internal aggregation feature it makes sense.
The idea is to use whatever function is defined in the rollup config with the fallback to avg, but if the rollup is done in graphite-clickhouse itself, log the warning. It will work for the case when internal-aggregation=true and carbonlink isn't used.


Merge pull request #1 from aspnet/dev

Update latest from aspnet/blazor

I think this PR must be a mistake - it doesn't appear to contain any content. I'll close it.
Hope that's OK - let me know if I'm misunderstanding and this was meant to be submitted!

Yes, sorry got the updates requests wrong


Add Apache 2.0 license

Aikaterna has already agreed to us licensing it under an OSI-approved license, but we will also ask her to explicitly state it on this PR before merging to be extra safe here.

I approve applying the Apache 2.0 license to these files, retroactively for all existing binaries and files, and for binaries and files added to this repository in the future.

https://web.archive.org/web/20210630175829/https://github.com/Cog-Creators/Lavalink-Jars/pull/7


Change imageset details limit from 20 to 10

Description
Change image-set details limit from 20 to 10 to fix an error when trying to return more then 10 images in an image-set
Fixes # (issue)
Type of change
What is it?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I run npm run lint:js:fix to check that my code is properly formatted

Codecov Report

Merging #501 (9f3e629) into master (f82351f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #501   +/-   ##
=======================================
  Coverage   32.10%   32.10%
=======================================
  Files         123      123
  Lines        2595     2595
  Branches      793      793
=======================================
  Hits          833      833
  Misses       1615     1615
  Partials      147      147

Impacted Files
Coverage Δ

src/api/images/index.js
24.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82351f...9f3e629. Read the comment docs.


changed return type for get_indexes to match the rest API

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
Currently get_indexes returns a dictionary of str and list of Index objects. The docstring and the REST API however return a dictionary of str and a list of dicts of str and str.

e.g. the python client returns
{'results': [<marqo.index.Index object at 0x103f65090>]}

Where the REST API returns
{'results': [{"index-name", "my-first-index"}]}

What is the new behavior (if this is a feature change)?
The new behaviour is to have get_indexes() return the same structure as the REST API

>>> mq.get_indexes()
{'results': [{"index-name", "my-first-index"}]}

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
This PR does break the use case where users use the Index objects returned from get_indexes().

e.g.
>>> indexes = mq.get_indexes()['results']
>>> for index in indexes:
...    print(index.get_stats())
>>>

However this usage pattern is never documented anywhere or used in any examples as far as I can see. It only appears in one of the tests for the get_indexes() method.

Other information:
This changes means that you can print the results as dictionaries have __repr__.

An alternative would be to add __getitem__ and __repr__ to the index object to retain both the existing functionality and let users treat it like a dict. e.g.
>>> indexes = mq.get_indexes()['results']
>>> for index in indexes:
...    print(index.get_stats())
>>> print(indexes)
[Index(config=<marqo.config.Config object at 0x10382f610>, http=<marqo._httprequests.HttpRequests object at 0x102682b10>, index_name='my-first-index', created_at=None, updated_at=None)]
>>> indexes[0]['index_name']
'my-first-index'

@pandu-k what are your thoughts on this? I think we discussed it about 2 months ago but I never got around to taking in further.


[Bug] Cannot start TUN device

Verify steps

[X] I have read the documentation and understand the meaning of all configuration items I have written, avoiding a large number of seemingly useful options or default values.
[X] I have not reviewed the documentation and resolve this issue.
[X] I have not searched the Issue Tracker  for the problem I am going to raise.
[X] I have tested with the latest Alpha branch version, and the issue still persists.
[X] I have provided server and client configuration files and processes that can reproduce the issue locally, rather than a desensitized complex client configuration file.
[X] I have provided the simplest configuration that can reproduce the error I reported, rather than relying on remote servers, TUN, graphical client interfaces, or other closed-source software.
[X] I have provided complete configuration files and logs, rather than providing only parts that I believe are useful due to confidence in my own intelligence.

Operating System
Linux
System Version
Linux 3.10.0-1160.80.1.el7.x86_64 SMP x86_64 x86_64 x86_64 GNU/Linux
Mihomo Version
Mihomo Meta v1.18.7 linux amd64 with go1.22.5 Sun Jul 28 05:46:59 UTC 2024
Use tags: with_gvisor
Configuration File
mixed-port: 7890
allow-lan: true
bind-address: '*'
mode: rule
log-level: debug

dns:
  enable: true
  ipv6: false
  listen: :23453
  default-nameserver:
    - <IP_ADDRESS>
    - <IP_ADDRESS>
  enhanced-mode: redir-host
  nameserver:
    - https://<IP_ADDRESS>/dns-query
    - tls://<IP_ADDRESS>:853
    - https://<IP_ADDRESS>/dns-query
  fallback:
    - https://doh.dns.sb/dns-query
    - tcp://<IP_ADDRESS>:443
    - tls://dns.google

tun:
  enable: true
  stack: mixed
  auto-route: true
  auto-redirect: true
  auto-detect-interface: true
  device: utun0
  strict-route: true
  udp-timeout: 300
  endpoint-independent-nat: false
  include-uid:
  - 1999

rule-providers:
  reject:
    type: http
    behavior: domain
    url<EMAIL_ADDRESS>    path: ./ruleset/reject.yaml
    interval: 86400

  icloud:
    type: http
    behavior: domain
    url<EMAIL_ADDRESS>    path: ./ruleset/icloud.yaml
    interval: 86400

  apple:
    type: http
    behavior: domain
    url<EMAIL_ADDRESS>    path: ./ruleset/apple.yaml
    interval: 86400

  google:
    type: http
    behavior: domain
    url<EMAIL_ADDRESS>    path: ./ruleset/google.yaml
    interval: 86400

  proxy:
    type: http
    behavior: domain
    url<EMAIL_ADDRESS>    path: ./ruleset/proxy.yaml
    interval: 86400

  direct:
    type: http
    behavior: domain
    url<EMAIL_ADDRESS>    path: ./ruleset/direct.yaml
    interval: 86400

  private:
    type: http
    behavior: domain
    url<EMAIL_ADDRESS>    path: ./ruleset/private.yaml
    interval: 86400

  gfw:
    type: http
    behavior: domain
    url<EMAIL_ADDRESS>    path: ./ruleset/gfw.yaml
    interval: 86400

  tld-not-cn:
    type: http
    behavior: domain
    url<EMAIL_ADDRESS>    path: ./ruleset/tld-not-cn.yaml
    interval: 86400

  telegramcidr:
    type: http
    behavior: ipcidr
    url<EMAIL_ADDRESS>    path: ./ruleset/telegramcidr.yaml
    interval: 86400

  cncidr:
    type: http
    behavior: ipcidr
    url<EMAIL_ADDRESS>    path: ./ruleset/cncidr.yaml
    interval: 86400

  lancidr:
    type: http
    behavior: ipcidr
    url<EMAIL_ADDRESS>    path: ./ruleset/lancidr.yaml
    interval: 86400

  applications:
    type: http
    behavior: classical
    url<EMAIL_ADDRESS>    path: ./ruleset/applications.yaml
    interval: 86400

proxies:
  - {name: X}

proxy-groups:
  - name: PROXY
    type: select
    proxies:
      - X
  - name: Others
    type: select
    proxies:
      - PROXY
      - DIRECT

rules:
  - RULE-SET,private,DIRECT
  - RULE-SET,reject,REJECT
  - RULE-SET,google,PROXY
  - RULE-SET,proxy,PROXY
  - RULE-SET,direct,DIRECT
  - RULE-SET,lancidr,DIRECT
  - RULE-SET,cncidr,DIRECT
  - RULE-SET,telegramcidr,PROXY
  - GEOIP,LAN,DIRECT
  - GEOIP,CN,DIRECT
  - MATCH,Others

Description
Start clash, logs:
INFO[2024-08-18T23:30:59.223947331+08:00] Start initial configuration in progress
INFO[2024-08-18T23:30:59.22504096+08:00] Geodata Loader mode: memconservative
INFO[2024-08-18T23:30:59.22509622+08:00] Geosite Matcher implementation: succinct
INFO[2024-08-18T23:30:59.243977362+08:00] Initial configuration complete, total time: 19ms
INFO[2024-08-18T23:30:59.265714988+08:00] Sniffer is closed
INFO[2024-08-18T23:30:59.266016806+08:00] DNS server listening at: [::]:23453
INFO[2024-08-18T23:30:59.266438688+08:00] Mixed(http+socks) proxy listening at: [::]:7890
WARN[2024-08-18T23:30:59.273849578+08:00] [TUN] default interface changed by monitor,  => bond0
ERRO[2024-08-18T23:30:59.411318004+08:00] Start TUN listening error: configure tun interface: add rule 1/11: file exists

If I comment out the tun > include-uid
tun:
  enable: true
  stack: mixed
  auto-route: true
  auto-redirect: true
  auto-detect-interface: true
  device: utun0
  strict-route: true
  udp-timeout: 300
  endpoint-independent-nat: false
  # include-uid:   <- here
  # - 1999         <- here

The startup logs become:
INFO[2024-08-18T23:34:51.857996404+08:00] Start initial configuration in progress
INFO[2024-08-18T23:34:51.858976601+08:00] Geodata Loader mode: memconservative
INFO[2024-08-18T23:34:51.859010061+08:00] Geosite Matcher implementation: succinct
INFO[2024-08-18T23:34:51.878533427+08:00] Initial configuration complete, total time: 20ms
INFO[2024-08-18T23:34:51.906691955+08:00] Sniffer is closed
INFO[2024-08-18T23:34:51.907066065+08:00] DNS server listening at: [::]:23453
INFO[2024-08-18T23:34:51.907652817+08:00] Mixed(http+socks) proxy listening at: [::]:7890
WARN[2024-08-18T23:34:51.918405556+08:00] [TUN] default interface changed by monitor,  => bond0
ERRO[2024-08-18T23:34:52.193525199+08:00] Start TUN listening error: auto redirect: conn.Receive: netlink receive: numerical result out of range | netlink receive: no such file or directory

If I comment out the tun > auto-redirect
tun:
  enable: true
  stack: mixed
  auto-route: true
  # auto-redirect: true  <- here
  auto-detect-interface: true
  device: utun0
  strict-route: true
  udp-timeout: 300
  endpoint-independent-nat: false
  # include-uid:   <- here
  # - 1999         <- here

The startup logs become (successfully startup):
INFO[2024-08-19T10:39:41.383316663+08:00] Start initial configuration in progress
INFO[2024-08-19T10:39:41.384345913+08:00] Geodata Loader mode: memconservative
INFO[2024-08-19T10:39:41.384489977+08:00] Geosite Matcher implementation: succinct
INFO[2024-08-19T10:39:41.410392222+08:00] Initial configuration complete, total time: 26ms
INFO[2024-08-19T10:39:41.439234076+08:00] Sniffer is closed
INFO[2024-08-19T10:39:41.439537963+08:00] DNS server listening at: [::]:23453
INFO[2024-08-19T10:39:41.439902044+08:00] Mixed(http+socks) proxy listening at: [::]:7890
WARN[2024-08-19T10:39:41.444352072+08:00] [TUN] default interface changed by monitor,  => bond0
INFO[2024-08-19T10:39:41.465841208+08:00] [TUN] Tun adapter listening at: utun0([<IP_ADDRESS>/30],[]), mtu: 9000, auto route: true, auto redir: false, ip stack: Mixed

Reproduction Steps
run clash as normal: ./clash -d /etc/clash
Logs
No response

Your kernel is too outdated, which might cause issues with iptables and other features being incompatible with new updates. Please consider upgrading your kernel.

@FlightGitHub [BUG] 开启tun模式，虚拟网卡没有出现 https://github.com/clash-verge-rev/clash-verge-rev/issues/1589
WIN10下即使没开 tun 模式——error：PrepareUIPath error: ExternalUI configure incomplete
是近期2-3个礼拜的内核 verge-mihomo-alpha 的问题，改用正式版即可正常。

Problem solved by upgrade kernel to Linux 5.4.278-1.el7.elrepo.x86_64 x86_64