CNCF Onboarding Checklist

Copied from https://github.com/cncf/sandbox/issues/131. Dropped items that CNCF staff is responsible for.
Welcome to CNCF Project Onboarding!
This is an issue created to help onboard your project into the CNCF after the TOC has voted to accept your project into the Sandbox.
We would like your project to complete onboarding within one month of acceptance.
Please track your progress by using "Quote reply" to create your own copy of this checklist in an issue, so that you can update the status as you finish items.
Review and understand

[x]  The project proposal process and requirements.
[x]  The services available for your project at the CNCF.
[x]  The CNCF IP Policy.
[x]  The trademark guidelines.
[x]  The license allowlist.
[x]  The online program guidelines.
[x]  Optional: Book time with CNCF staff for any onboarding questions.

Contribute and transfer

[x]  Move your project to its own separate neutral GitHub organization. This will make it transferable to the CNCF's GitHub Enterprise account. If it's already in a GHE account, you will need to remove it from that first.
[x]  Accept the invite to join the CNCF GitHub Enterprise account. We'll then add thelinuxfoundation as an organization owner to ensure neutral hosting of your project.
[x]  Migrate your Slack channels (if any) to the Kubernetes or CNCF Slack workspace. CNCF staff can help.
[x]  Submit a pull request to add your project as a Sandbox project to the Cloud Native Landscape by updating landscape.yml following these instructions. https://github.com/cncf/landscape/pull/4035
[x]  Transfer your domain to the CNCF. The "LF Stakeholder email" is<EMAIL_ADDRESS>[x]  Transfer any trademark and logo assets to the Linux Foundation.
[x] Submit a pull request with your artwork. https://github.com/cncf/artwork/pull/507
[ ]  Transfer website analytics to<EMAIL_ADDRESS>CNCF staff can help.

Update and document

[x]  Ensure that DCO (preferred) or CLA are enabled for all GitHub repositories of the project.
[x]  Ensure that that the CNCF Code of Conduct (or your adopted version of it) are explicitly referenced at the project's README on GitHub. https://github.com/shipwright-io/.github/pull/5
[x]  Ensure LF footer is on your website and guidelines are followed (if your project doesn't have a dedicated website, please adopt those guidelines for the README file). https://github.com/shipwright-io/website/pull/131
[x]  Create a maintainer list and add it to the aggregated CNCF maintainer list via pull request. https://github.com/shipwright-io/community/pull/242 and https://github.com/cncf/foundation/pull/860
[x]  Provide emails for the maintainers to get access to the maintainers mailing list and Service Desk. Email them to<EMAIL_ADDRESS>Email sent.
[x]  Start working on written, open governance. https://github.com/shipwright-io/community/issues/243
[x]  Start on an OpenSSF Best Practices Badge.

Some updates:

Website PR for including CNCF trademark,etc https://github.com/shipwright-io/website/pull/130
PR for updating our entry in the CNCF landscape https://github.com/cncf/landscape/pull/4035
DOC is enabled now in all repositories of the Shipwright github org
Meeting with CNCF staff is already scheduled

[ ] Transfer any trademark and logo assets to the Linux Foundation.

We should check with Michelle Martineau or Todd Moore - I _think _ this already "done" no actual paperwork needs to be filled out.

Per Red Hat OSPO - the shipwright.io domain registration was already transferred to the Linux Foundation when the project was donated to the CDF. Domain transfer to the CNCF will either be a no-op or a matter of updating records on the LF side of things.

@qu1queee I think we can call this "Done" - we do have follow ups for the following:

Governance #243
CNCF access to our Netlify account (we should probably create a community issue for this, assigned to me)
Bake off of Snyk vs. FOSSA for licence compliance checks - do we have an issue here?

Any other follow ups I'm missing?


[Feature Request] Ability to display sensitives values

Would it be possible to allow displaying sensitive values for a given object ?
This could be allowed via a keystroke within the interface.
Thanks !

The terraform state show command doesn't expose sensitive values. However, it seems that terraform show -json does expose them. Although there's no single-resource version for this command, meaning it will take some time to process, I think that would be acceptable.
I'll test it out and implement it if possible. Stay tuned :)

Done, I just released v0.13.2.
Hit x in the resource screen to expose the sensitive values. Enjoy 😄

Hello :) I just tested, it does not work :)
Pressing X on the resource screen does not change value displayed ( "sensitive value")

It works on my machine 😉
I just noticed that it doesn't work with an uppercase 'X', could it be that your CAPS LOCK is on?

Found the problem. It didn't work on root resources, only inside modules.
Fixed in v0.13.3

It works perfectly. Thanks.


Add support for the delayed upgrade

Implement #20
Added apis:
- up_storage_prefix();
- up_get_delay_status(&self) -> UpgradableDurationStatus;
- up_init_staging_duration(staging_duration: near_sdk::Duration);
- up_stage_update_staging_duration(staging_duration: near_sdk::Duration);
- up_apply_update_staging_duration();

Added storage keys:
- "StagingDuration":  to save the delay duration of deploying staged code.
- "UpdateStagingDuration": to save the staged delay duration update.
- "StagingTimestamp": to save the allowed timestamp to apply the staged duration or code.

How about introducing helper functions for storage writes too? It’s a nit, but I think it would improve readability.
#[inline]
fn up_set_duration(key: __UpgradableStorageKey, duration: &near_sdk::Duration) {
  near_sdk::env::storage_write(self.up_storage_key(key).as_ref(), duration.to_be_bytes());
}

// Same for `fn up_set_timestamp`.

These functions would be the counterparts of up_get_{duration, timestamp}.
Please remember to update the Upgradable section in the root README.

fixed in :
6489041834e6f7040f583b6795f15eebfc4cee30
3a1f09ae8c752f110adc5a8e3db688cc63a18781

How about using the term delay instead of staging duration in the code? I think that could make things clearer, for instance:
fn up_stage_new_delay(&self, delay: Option<near_sdk::Duration>);

// instead of

fn up_stage_update_staging_duration(&self, staging_duration: Option<near_sdk::Duration>);

There are events for StageCode and DeployCode.
https://github.com/aurora-is-near/near-plugins/blob/6489041834e6f7040f583b6795f15eebfc4cee30/near-plugins/src/upgradable.rs#L90-L95
https://github.com/aurora-is-near/near-plugins/blob/6489041834e6f7040f583b6795f15eebfc4cee30/near-plugins/src/upgradable.rs#L110-L115
I think it would make sense to also have events like StageDelay and SetDelay

The term staging duration is already used in the NEP UPGRADE, so I am skeptical about adding new terminology


Arrays with length larger than 196603 cause Malformed JS Call error

Description
Imagine a native module with one function test that has one parameter -> array.
When you call it with an array that has more than 196603 items in it the array disappears.
And RN Bridge throws this error:
Error: Exception in HostFunction: Malformed calls from JS: field sizes are different.

[[42,81],[7,0],[[142,100,1673548954018,false]],354]

The array is an array of bytes in our case.
Question
Is this a bridge limitation?
On Android, with the New Architecture it works. (On iOS I got the same error.)
Files libraries are solving this by using strings
But we are concerned about the encoding overhead.

https://github.com/itinance/react-native-fs/blob/master/FS.common.js?rgh-link-date=2023-03-02T09%3A54%3A24Z#L396

React Native Version
0.71.3
Output of npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 13.2
CPU: (10) arm64 Apple M1 Pro
Memory: 148.30 MB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.19.0 - ~/.volta/tools/image/node/16.19.0/bin/node
Yarn: 1.22.19 - ~/.volta/tools/image/yarn/1.22.19/bin/yarn
npm: 8.19.3 - ~/.volta/tools/image/node/16.19.0/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.3 - /Users/krystofwoldrich/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
Android SDK:
API Levels: 28, 29, 30, 31, 32, 33
Build Tools: 28.0.3, 29.0.2, 30.0.2, 30.0.3, 31.0.0, 33.0.0, 33.0.1
System Images: android-33 | Google APIs ARM 64 v8a
Android NDK: 22.1.7171670
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9123335
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
Languages:
Java: 17.0.5 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.2.0 => 18.2.0
react-native: 0.71.3 => 0.71.3
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce

https://github.com/krystofwoldrich/repro-large-array

Create a native module with a function test(array)
Call this function with an array that has more than 196603 items.

I've tested this with numbers and objects and got the same error.
Also tried to enclose the array into an object and got the same error.
Snack, code example, screenshot, or link to a repository
Original issue at @sentry/react-native:

https://github.com/getsentry/sentry-react-native/issues/2744

I've tried this with JSC and it works. The problem seems to be only with Hermes.

Was anyone tracked down what causes the issue?


Twitter Social Login

Hi,
Do you have any plans to provide Twitter Social Login in the near future? We'd really appreciate this feature.
Thanks,
Matti

Unfortunately we don't have that in the Stormpath REST API at this time, but we plan to add Twitter support in the future.  I've created an issue that you can follow on our new feature tracker, please follow here:
http://ideas.stormpath.com/ideas/IAM-I-35

I'd love to see support for Twitter too. I guess for now I need to make my own directory to act as a mirror for Twitter.


Fix disappearance of players in the team list

Closes #2678
It happens when the player leaves #aeolus channel

damn it...

Wouldn't this potentially lead to a memory leak as players are only added and never removed from the map?

Probably. I need to find another solution. My change is not suitable as it breaks a notification that a friend has logged into the client.


Change to reset replace when nothing is selected

Change to set guid from asset reference when nothing is selected for replace.

Create branch from main
issue-76-change-to-reset-replace-when-nothing-is-selected


Add link to the roles documentation

Good article but two remarks.

Tell why the option "User assignment required" needs to be checked because you can also assign people without it. But this limits the not assigned people to login.
If admins or developers come here the want some kind of RBAC in their application. A logical step is to add roles when they assign people to an application. Add a link to the roles documentation so people understand what kind of thing you could do instead of the standard default role.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: be62a693-4dfd-ad56-cce2-b4dbc794f34b
Version Independent ID: bd8bc1b2-925f-a0c3-4286-37eb2f7189f5
Content: How to restrict your Azure Active Directory-registered app to a set of users
Content Source: articles/active-directory/develop/howto-restrict-your-app-to-a-set-of-users.md
Service: active-directory
Sub-service: develop
GitHub Login: @kalyankrishna1
Microsoft Alias: kkrishna

@LockTar Thanks for your feedback! We will investigate and update as appropriate.

@locktar

Yes you can assign users, but the check box is there to ensure that AAD won't sign-in or issue tokens unless a user (or a group) is expressly assigned to this app.
There is no need for roles if all the developer/admin wants is to assign users an groups who are only allowed to sign-into that app. This is a very common scenario and thus we cover it separately in our docs targeted for IT admins..

AppRoles and Groups are a different story and thus explained separately in developer docs..

I had to dig into this again...

@LockTar

Yes you can assign users, but the check box is there to ensure that AAD won't sign-in or issue tokens unless a user (or a group) is expressly assigned to this app.

True, but that is(was) not really clear in the text. So this issue is about feedback of the documentation.

There is no need for roles if all the developer/admin wants is to assign users an groups who are only allowed to sign-into that app. This is a very common scenario and thus we cover it separately in our docs targeted for IT admins..

AppRoles and Groups are a different story and thus explained separately in developer docs..

I understand, but that topic about AppRoles and Groups is difficult to find on the internet if you don't know were to search for. You need to know that the keyword is AppRoles. Adding a reference to that topic would help the users a bit more how they can create roles for users/groups in an app registration. I think adding a link to this https://docs.microsoft.com/en-us/azure/active-directory/develop/howto-add-app-roles-in-azure-ad-apps with the text

Added a link
#please-close

#please-close


reset_git_repo action deletes Pods folder

fastlane 1.97.2
> cat .gitignore
.DS_Store
.idea
Pods
xcuserdata
*.xccheckout
*.xcscmblueprint
build
Acknowledgements.plist
.clang-format
Carthage
Preview.html
iOSInjectionProject
test_output
report.xml

related contents of Fastfile:
    after_all do
        reset_git_repo
    end

After lane is executed Pods directory is missing.

Oh well, looking through the code I've discovered disregard_gitignore option which is true by default.


Create Contributing.md Template

For future contributions, having a contribution guideline file would make it easier for open source newbies(like me 😅) to get started. @CrazyMarvin, If you would let me, I can be assigned to this.

Sure, that is a great idea. 👍
I already created a CONTRIBUTING.md file in the .github folder 8 months ago but I was too lazy to add something unfortunately. 😅

Alright I'll get to it😊

Hi @CrazyMarvin, I have submitted a PR for this issue. See here: Contributing.md PR

Thank you very much for your contribution, @LuluNwenyi! 🙏


Add --future-incompat-report support to cargo test

This was missed in the original PR

r? @alexcrichton
(rust-highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit 63ed725fd8fcbc3af261240fd1102e43783145c8 has been approved by alexcrichton

:hourglass: Testing commit 63ed725fd8fcbc3af261240fd1102e43783145c8 with merge bbda175da6b2787f92e7ccdb4eb4b84d0e40b57d...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing bbda175da6b2787f92e7ccdb4eb4b84d0e40b57d to master...


X1079 add flag to labware table details

@sabrine33 Can you fix the merge conflicts in this pr please?

Closing this and and opening a new one, as for some reason the tests are not triggered to run


Move contextual data to Problem

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test RFN

I've triggered the following builds for you. Click here to see all build failures.

ReadyForNightly build

@lkasso This is still under heavy development. I don't know why it was not a draft PR.

Oh, this is the old one; closing.


ADD favicon ico.

Please Assign me this for hacktoberfest.

I added the Favicon Icon. Check the PR if its correct then merge it.


GPU error on colab

I tried training a model on google colab. But it gave me this error.
2021-01-12 18:31:27,775	ERROR worker.py:980 -- Possible unhandled error from worker: ray::Trainer.init() (pid=67833, ip=<IP_ADDRESS>)
File "python/ray/_raylet.pyx", line 463, in ray._raylet.execute_task
File "python/ray/_raylet.pyx", line 415, in ray._raylet.execute_task.function_executor
File "/content/drive/My Drive/muzero-general-master/trainer.py", line 28, in init
self.model.to(torch.device("cuda" if self.config.train_on_gpu else "cpu"))
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 612, in to
return self._apply(convert)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 359, in _apply
module._apply(fn)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 359, in _apply
module._apply(fn)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 359, in _apply
module._apply(fn)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 381, in _apply
param_applied = fn(param)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 610, in convert
return t.to(device, dtype if t.is_floating_point() else None, non_blocking)
File "/usr/local/lib/python3.6/dist-packages/torch/cuda/init.py", line 172, in _lazy_init
torch._C._cuda_init()
RuntimeError: No CUDA GPUs are available

Hi @SwiftGodDev,
I didn't have any issue training muzero with the notebook of the repository. Could you give more details about the configuration you used so I can try to reproduce the error ?

Hi @SwiftGodDev,
I didn't have any issue training muzero with the notebook of the repository. Could you give more details about the configuration you used so I can try to reproduce the error ?

Hi ahainaut,
Apparently there is no error in your code. I wanted to train a model for chess so I used this repo.
https://github.com/goshawk22/muzero-general
There is some error in his muzero.py file or chess.py file, I guess.
Please check those.

Hi ahainaut,
Apparently there is no error in your code. I wanted to train a model for chess so I used this repo.
https://github.com/goshawk22/muzero-general
There is some error in his muzero.py file or chess.py file, I guess.
Please check those.

Did you make sure to enable GPU in the notebook. By default there is only CPU and no GPU acceleration.
It all worked on my GPU but I didn't test it on Colab.

Did you make sure to enable GPU in the notebook. By default there is only CPU and no GPU acceleration.
It all worked on my GPU but I didn't test it on Colab.

I dont have a GPU so I ran it on colab and yes my runtime was GPU enabled.

I dont have a GPU so I ran it on colab and yes my runtime was GPU enabled.

That version is not functional yet - I never got round to finishing it.
Sorry I thought you were using the open_spiel wrapper I made. That is fully working and I made a PR.

That version is not functional yet - I never got round to finishing it.
Sorry I thought you were using the open_spiel wrapper I made. That is fully working and I made a PR.

How do I use it?

How do I use it?

There is information in the spiel.py game file.

There is information in the spiel.py game file.

where is it located?

where is it located?

Got it.

Got it.

But there is no file named spiel.py in games folder

But there is no file named spiel.py in games folder

Look at the spiel branch.
On Thu, 14 Jan 2021, 12:54 SwiftGodDev<EMAIL_ADDRESS>wrote:

But there is no file named spiel.py in games folder
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/werner-duvaud/muzero-general/issues/112#issuecomment-760178510,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ4PZR7SIPY3XIZEPW2HUL3SZ3SPJANCNFSM4V7T6TUQ
.

Look at the spiel branch.
On Thu, 14 Jan 2021, 12:54 SwiftGodDev<EMAIL_ADDRESS>wrote:

But there is no file named spiel.py in games folder
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/werner-duvaud/muzero-general/issues/112#issuecomment-760178510,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ4PZR7SIPY3XIZEPW2HUL3SZ3SPJANCNFSM4V7T6TUQ
.

Got it. Thank you

Got it. Thank you

I am not able to install open_spiel on colab.
Building wheel for open-spiel (setup.py) ... error
ERROR: Failed building wheel for open-spiel
Running setup.py clean for open-spiel
Failed to build open-spiel
Installing collected packages: open-spiel
Running setup.py install for open-spiel ... error
ERROR: Command errored out with exit status 1: /usr/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-uankco1j/open-spiel_9e590da322794498aba0b8db392d3601/setup.py'"'"'; file='"'"'/tmp/pip-install-uankco1j/open-spiel_9e590da322794498aba0b8db392d3601/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /tmp/pip-record-41vf_m7t/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/include/python3.6/open-spiel Check the logs for full command output.

I am not able to install open_spiel on colab.
Building wheel for open-spiel (setup.py) ... error
ERROR: Failed building wheel for open-spiel
Running setup.py clean for open-spiel
Failed to build open-spiel
Installing collected packages: open-spiel
Running setup.py install for open-spiel ... error
ERROR: Command errored out with exit status 1: /usr/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-uankco1j/open-spiel_9e590da322794498aba0b8db392d3601/setup.py'"'"'; file='"'"'/tmp/pip-install-uankco1j/open-spiel_9e590da322794498aba0b8db392d3601/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /tmp/pip-record-41vf_m7t/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/include/python3.6/open-spiel Check the logs for full command output.

I used the file you said but it still gives the same error.

I used the file you said but it still gives the same error.

Error solved guys, finally.

Error solved guys, finally.


[rm nixpkgs] use path-from-hash-part command when updating lock file

Summary
Motivation
With Remove Nixpkgs feature on, installing<EMAIL_ADDRESS>was failing with:
[3/7]<EMAIL_ADDRESS>        don't know how to build these paths:
          /nix/store/0xyi7w3cm3g7gzwfpwqzx0n7xks2sdc6-curl-8.0.1
        asked 'https://cache.nixos.org/' for '/nix/store/0xyi7w3cm3g7gzwfpwqzx0n7xks2sdc6-curl-8.0.1' but got '/nix/store/0xyi7w3cm3g7gzwfpwqzx0n7xks2sdc6-curl-8.0.1-bin'
        error: path '/nix/store/0xyi7w3cm3g7gzwfpwqzx0n7xks2sdc6-curl-8.0.1' is required, but there is no substituter that can build it

Explanation
Thanks to @gcurtis.
curl’s first (and therefore default) output is bin, not out, so Nix is appending -bin to the path.
From man nix-build:

If a derivation has multiple outputs, nix-build will build the default (first) output. You can also build all outputs:
$ nix-build '' --attr openssl.all
This will create a symlink for each output named result-outputname. The suffix is omitted if the output name is out. So if openssl has outputs out, bin and man, nix-build will create symlinks result, result-bin and result-man.

Fix
Observe:
> nix store path-from-hash-part --store https://cache.nixos.org/ bbkz21vmx16wl0h3xk36g7gxpbymnm6d --extra-experimental-features "nix-command flakes"
/nix/store/bbkz21vmx16wl0h3xk36g7gxpbymnm6d-curl-8.0.1-bin

So:

During devbox update, we derive the store-path from the search API and write to devbox.lock
Previously, we would manually construct store-path from hash-name-version from search API response
Now, we invoke nix store path-from-hash-part <hash> and write the response store-path in the devbox.lock.

if this fails (it shouldn't!), we skip writing the store-path to the devbox.lock, and print a warning. Maybe we should track it in sentry?

How was it tested?
> cat devbox.json
{
  "packages": [
<EMAIL_ADDRESS>  ]
}

> devbox update
Info: Updated system information for<EMAIL_ADDRESS>Ensuring packages are installed.

Installing package<EMAIL_ADDRESS>
[1/1]<EMAIL_ADDRESS>[1/1]<EMAIL_ADDRESS>Success
Info: Running "nix flake update"

> cat devbox.lock
{
  "lockfile_version": "1",
  "packages": {
<EMAIL_ADDRESS>{
      "last_modified": "2023-05-31T02:09:55Z",
      "resolved": "github:NixOS/nixpkgs/9cfaa8a1a00830d17487cb60a19bb86f96f09b27#curl",
      "source": "devbox-search",
      "version": "8.0.1",
      "systems": {
        "aarch64-darwin": {
          "store_path": "/nix/store/7qwsslwdrjyg8hs654nsqpq7lly6dhq5-curl-8.0.1-bin"
        },
        "aarch64-linux": {
          "store_path": "/nix/store/g9g1p4l9146kclnx4lv0hfbzhr9hk7n7-curl-8.0.1-bin"
        }
      }
    }
  }
}

Current dependencies on/for this PR:

main

PR #1442   👈

This comment was auto-generated by Graphite.

@gcurtis instead of running this logic in the CLI, I'm now thinking it may make sense for the search indexer to run it. WDYT?

This is something we should add to the API, but feel free to keep it as a workaround until the API is updated.
I plan on adding a new outputs field to the JSON alongside the current store_hash/name/version fields. The new response will look like:
{
  "store_hash": "00263n102bi1r6qihvdghxb3jx6n3k1d",
  "store_name": "libcxxabi",
  "store_version": "16.0.6",
  "outputs": [
    {
      "path": "/nix/store/00263n102bi1r6qihvdghxb3jx6n3k1d-libcxxabi-16.0.6",
      "name": "out",
      "hash": "00263n102bi1r6qihvdghxb3jx6n3k1d",
      "default": true
    },
    {
      "path": "/nix/store/04r1bxcai0bzb2z01n5r47j8r2387s2r-libcxxabi-16.0.6-dev",
      "name": "dev",
      "hash": "04r1bxcai0bzb2z01n5r47j8r2387s2r",
      "default": false
    }
  ]
}

The store_hash field will be kept for compatibility, but new code will use the outputs array instead. Would this new format get you what you're looking for?

@gcurtis That would be neat. A few questions:

I understand that default would refer to the first output, as per nix build docs. Does that always necessarily imply its also the output cached by cache.nixos.org? Will you confirm that server-side, or do I need to keep a check similar to the one in this PR in the CLI?

For packages with multiple outputs (ref. #1431 where prometheus has cli output as well), your proposal would be really helpful. However, I'm guessing the cache.nixos.org will not have a prebuilt binary for the cli output, since its not the default output. Let me know if I'm incorrect. I'm thinking we may need the user to specify outputs they'd like. Something like:

devbox add prometheus --outputs default,cli

which are set as:
// devbox.json
{
    "prometheus: {
        "version": "latest",
        "outputs": [default, cli],
    },
}

And unfortunately then we'd need to install this cli using the nixpkgs-full path.
Does that sounds good, directionally at least?

Lets land this PR then so we can start dogfooding internally!

I understand that default would refer to the first output, as per nix build docs. Does that always necessarily imply its also the output cached by cache.nixos.org? Will you confirm that server-side, or do I need to keep a check similar to the one in this PR in the CLI?

Default isn't always just the first output. Some packages define multiple outputs to install by default. That's a good point about the cache check. I think the best approach would be to add a cached field to each output in the response.

However, I'm guessing the cache.nixos.org will not have a prebuilt binary for the cli output, since its not the default output.

I had to look this one up to double check. It looks like all of the prometheus outputs are cached, including cli. I'm not sure what the best way is for installing non-default outputs. Off the top of my head, we could either:

Do your suggestion - add an outputs field to devbox.json. I'm not a huge fan of adding yet another field though.

Alternatively, we just work it into the name like prometheus-cli@latest or curl-lib@latest.

Install all outputs by default (nixpkgs#prometheus.all). Downside is this will probably really bloat installs.
Special-case outputs to always install. In other words, always install out, bin, man, and cli.


Feature Request - Add more Tld

I have been doing a comparison of the data extracted from your platform and DNSTwist. Although your platform has a lot more domains returned there are some that DNSTwist pick up which you do not. This mainly falls under the WrongTLD Algorithm if i apply a .co.uk domain to DNSTwist it will give me back .com, .biz .net etc domains. However, your platform only strips out the .uk section to change the domain instead of stripping out the .co.uk.
Would it be possible to request such a feature?

Hi @TiiTcHY,
Thanks you for your report, and we work on it actually to change all algorithms that are affected by this.
Nice catch, Thanks again.
I'll close this issue when the push will be done.

Hi @TiiTcHY,
The public instance is up to date now and running with some update. The TLD problem is normally fix.
Thanks again for the report you did and don't hesitate to give us a feedback or to report other issues.

Hi @TiiTcHY,
The issue was due to Faup library that need to be run under linux os, but I changed it to use tldextract now.
You can check this commit https://github.com/ail-project/ail-typo-squatting/commit/43cefbf2666b42db6fc6a586ed92ea3ae3a142c3 to see changes.
In the future, if you have any question or report about the library please open issue on the other repo.
Hope you'll enjoy the code with those modifications.


[BUG] Null pointer exception due to null finish_reason while testing local LLMS

I'm in the process of evaluating a number of local LLMS.  I'm levering a project called LiteLLM (https://litellm.ai/) as a proxy, which essentially adds OpenAI API compliance for a large number of LLMs and services.  In my case, I am testing out LiteLLM with Ollama .
This setup has no issues, and works with a number of chat clients and direct with Curl requests.  E.g.
curl --location 'http://<IP_ADDRESS>:8000/chat/completions'     --header 'Content-Type: application/json'     --data ' {
"model": "ollama-custom",
"messages": [
{
"role": "user",
"content": "what llm are you"
}
]
}' | jq .
I noticed that by default, it seems that the value for finish_reason is null.  I'm not certain if there are cases where this is legit, but it is causing a null pointer exception.
Here is another example with the request/response:

Given the following code:
ChatLanguageModel chatLanguageModel =OpenAiChatModel.builder()
.apiKey("na")
.modelName("ollama-custom")
.baseUrl("http://localhost:8000/")
.timeout(ofSeconds(60))
.proxy(new Proxy(Proxy.Type.HTTP, new InetSocketAddress("<IP_ADDRESS>", 8888)))
.logRequests(true)
.logResponses((true))
.build();
    Assistant assistant = AiServices.create(Assistant.class, chatLanguageModel);

    String answer = assistant.chat("What is the capital of France?");
    System.out.println(answer);

I'm getting the following exception:

Is there an issue with the code here (e.g. some missing option and not streaming?) or should this case be handled?  Essentially, in OpenAIChatModel
return Response.from(
aiMessageFrom(response),
tokenUsageFrom(response.usage()),
finishReasonFrom(response.choices().get(0).finishReason())
);
finishReasonFrom is null and causing the exception.

this was a litellm bug that's now fixed @ericblue let me know if the issue persists for you.

Thanks @krrishdholakia!  I just checked out the latest litellm code and verified that the issue is now resolved.


present all missing config fields at once

instead of requiring the user to repeatedly restart the bot to find out what config fields are missing, ideally all missing fields should be presented in a single list and then adding all of those should mean no more config fields need to be fixed (assuming they've been entered correctly)

resolved by 5b29ebeb79f1ec0d9b6ce729fc0f0e500053a239


Allow morph key type other than 'int' or 'uuid' in Schema/Builder

Laravel Version: 8.38.0
PHP Version: 8.0.1
Database Driver & Version: MySQL 8.0.23

Description:
Pull request https://github.com/laravel/framework/pull/34145 added a new $defaultMorphKeyType property to the Schema Builder:
https://github.com/laravel/framework/blob/277c2fbd0cebd2cb194807654d870f4040e288c0/src/Illuminate/Database/Schema/Builder.php#L42-L47
This is nice, but restricts its usage to int or uuid only:
https://github.com/laravel/framework/blob/277c2fbd0cebd2cb194807654d870f4040e288c0/src/Illuminate/Database/Schema/Builder.php#L72-L85
I am using the UID Symfony Component to generate 26 characters ULIDs,
and would like to have the option to use char or binary column types too.
Is it possible not to throw an exception when setting other column types? Thanks.

As a workaround, Blueprint class is macroable, so you can define new methods without extending it.
For example, add this to your AppServiceProvider's boot method:
// don't forget to import it
// use Illuminate\Database\Schema\Blueprint;

Blueprint::macro('morphsUlid', function ($name, $indexName = null) {
    // $this inside this closure will refer to the Blueprint instance
    $this->string("{$name}_type");

    $this->char("{$name}_id", 26);

    $this->index(["{$name}_type", "{$name}_id"], $indexName);
});

Then you can use it in your migrations, like this:
$table->morphsUlid('model');

@rodrigopedra Thanks, that's exactly the macro I wrote!
If the morph column type is not used in other parts of the framework then it's not a bug, but if it is used for example when creating tests databases or in Eloquent itself, then it might be.
I'm just not sure where this column definition is being used by the framework.

This is a feature request and not a bug.


iOS real device. Can't handle iOS prompt for Flutter tools - question

Good day,
I'm experiencing issue when I try to establish Appium session. First I thought that I can handle this pop-up in code by changing Context, but while debugging I have found out that appium session is not created at this part of code: const driver = await wdio.remote(opts);
Any suggestions on how you run tests on the real iOS devices? I have tried to search closed/open issues here but seems I can't find anything and I'm really stuck with this currently.

adding to the capabilities:
'appium:autoAcceptAlerts': true,
solved my issue.
Closing the ticket.


add customizing for the certain components

done with https://github.com/abap-observability-tools/abap-trace-tender/pull/17


Backport: Cluster & node agents are still running after HA install upgraded to addLocal=false

Backport for https://github.com/rancher/rancher/issues/16571

available in v2.1.2-rc12

rancher/rancher:v2.1.2-rc12
rancher/server-chart:master

Deployed Rancher in HA via helm, with addLocal=auto
Confirmed local cluster is present in UI
Confirmed the cluster & node agent pods were running
Confirmed cattle-node-agent daemonset is present
Confirmed cattle-cluster-agent deployment & replicaset are present
--
Upgraded to same version w/ addLocal=false
Confirmed local cluster is not present in UI
Confirmed cluster & node agent pods removed
Confirmed cattle-node-agent daemonset removed
Confirmed cattle-cluster-agent deployment and replicaset removed
--
Upgraded to same version w/ addLocal=auto
Confirmed local cluster is present in UI
Confirmed all cluster & node agent pods, deployments, and replicasets were present


Use kryo for serialization

Nice! But tests are failing.

Passing now

Nice! Merge?
Did you release the artifactory with the binary embeddings?

This uses the kryo version of glove, which is deployed.  The text version is no longer included as a dependency.


Implementation of encryption keys features, Issue #10

What does this PR do?
This PR implements feature #10 by passing key parameter from client to the methods which need keys. Keys are asked from the user in the client and passed to the methods that need them. If method requires keys and user doesn't give them, error will be thrown.
Where should the reviewer start?
Looking at the changes to the client and to the API.
How should this be manually tested?
Using the client and not giving a key to a method which requires key will result in error message. Leaving the key empty for a method which doesn't require key causes no error.
What are the relevant tickets?
Closes issue #10

Good! 👍 Now just there are some merge conflicts to fix before merging.

Hey, can you merge this? :)


🐛 Bug Report: Resolving dependencies on device_info_plus

👟 Reproduction steps
When I launching project with pub spec:
appwrite: ^9.0.0
flutter_quill: ^7.2.0
👍 Expected behavior
Upgrade dependencies with latest versions
👎 Actual Behavior
Resolving dependencies...
Because flutter_quill >=7.1.17+1 depends on device_info_plus ^9.0.0 and appwrite 9.0.0 depends on device_info_plus ^8.1.0, flutter_quill >=7.1.17+1 is incompatible with appwrite 9.0.0.
And because no versions of appwrite match >9.0.0 <10.0.0, flutter_quill >=7.1.17+1 is incompatible with appwrite ^9.0.0.
So, because stomhelp depends on both appwrite ^9.0.0 and flutter_quill ^7.2.0, version solving failed.
exit code 1
🎲 Appwrite version
Version 1.3.x
💻 Operating system
MacOS
🧱 Your Environment
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

@MrFantuk this is simply an issue with dependency conflict. One way to resolve this issue is to add a dependency_overrides as the following
dependency_overrides:
	device_info_plus: 9.0.0

Or another way to use the version of flutter_quill that uses the same version of device_info_plus as appwrite. Or the wait for Appwrite SDK to update with newer version of device_info_plus as we will be publishing updates soon.
Please let us know if this solves your issue, or not.
Thank you

As a temporary fix, that's work, but it could occur bugs on using overrides. Any way, waiting for updates. Thank you)

@MrFantuk the new Appwrite SDK version 9.0.1 should no longer have this issue. Feel free to re-open the issue if you still have problems.


Large table creation - how to detect page break within tables ?

Hello!
I'm currently creating a huge table (up to 100,000 rows) in a Word document. Therefore, the performance is actually terrible. I used the caching method in issue #174 . However, it is still slow - it is pretty fast at first, however when the table gets bigger and bigger, it is still really slow in time (I have merged cells in the table too).
So I wanted to try the plan B mentioned in that issue. Bad news is, I cannot find out a way to detect page breaks within a single table.
My goal is that once I could detect the page breaks, I will split the table into small pieces - one table per page. And I'm hoping that will solve the performance problem.
The reason I can't just split the tables in to random sized tables is that I need to add table headers for each table. Most importantly, I need to insert some certain values in the tables.
Can anyone can tell me how to detect page breaks within tables? Thanks in advance!
PS: If there is another method that is better than splitting tables, PLEASE tell me! Many thanks!!

Have you solved this problem?

Have you solved this problem?

@d1mpi I didn't solve the problem using the orignal methods, I splitted the table into small pieces but not according to the page breaks. And that REALLY speeds stuff up a lot. Originally I need to run the program for 5h and now I only need to run for 2 minutes.
But still, I don't know how to detect page breaks with the table.

We'll have to do the same, thank you

Hi folks, I've submitted a PR of adding a cache for table cells: #1051 .

Do you have solutions? I also need detect page break of table

I would be interested too, but assume that it's not present (yet). Is there a way to access the rendered file?


added new services IP Geo Loaction and CurrencyFreaks

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Thanks for the contribution @ihsaanofficial!
Can you please resolve the conflict and squash all your commits?

resolve conflicts and added  whoisfreaks

@ihsaanofficial
Please squash the commits into a single one or make a new PR and reference this.

This PR is inactive, so the API was added in another PR/commit.
More information at: #2002


az image copy - fails on "Creating snapshot in target region from the copied blob"

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az snapshot create
Errors:
BadRequestError: (InvalidParameter) The value of parameter snapshot.name is invalid.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az snapshot create --resource-group {} --name {} --location {} --source {} --source-storage-account-id {} --output {} --tags {}

Expected Behavior
Environment Summary
macOS-10.16-x86_64-i386-64bit
Python 3.8.7
Installer: HOMEBREW

azure-cli 2.18.0 *

Extensions:
image-copy-extension 0.2.8

Additional Context

Looks like the issue was that the image name was too long.

image copy

Please upgrade to latest version of azure cli 2.39.0


Insufficient and inappropriate guidance on vulnerability disclosure

See https://github.com/timb-machine/nhsx-contact-tracing-app/blob/3acf0a13dd3c4d663aa6fe0928339bf7d1d9283d/advocacy/nhsx-briefing/EXSEZNMXgAY0xVY%3Fformat%3Djpg.

See https://github.com/nhsx/COVID-19-app-iOS-BETA/blob/master/SECURITY.md.


[SPARK-47705][INFRA][FOLLOWUP] Sort LogKey alphabetically and build a test to ensure it

What changes were proposed in this pull request?
The pr aims to fix bug about https://github.com/apache/spark/pull/45857
Why are the changes needed?
In fact, LogKey.values.toSeq.sorted did not sort alphabetically as expected.
Does this PR introduce any user-facing change?
No.
How was this patch tested?

Pass GA.
Manually test.

Was this patch authored or co-authored using generative AI tooling?
No.

cc @dtenedor @gengliangwang

This UT did not achieve the goal we wanted to achieve,
I will add an automated tool that developers can use to automatically format it, just like:
https://github.com/apache/spark/blob/7dec5eb14644aee6c0562bad1d14421d9fa07f17/core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala#L46-L57

Thanks, merging to master


Data processing

Hello authors, may I ask for the workflow to process the data from raw data (java methods pairs) into the mode input (data.pkl)? Thanks so much for your time.

My email address is<EMAIL_ADDRESS>

You can use the following code to process data https://disk.pku.edu.cn:443/link/37FED995C8031D4DB8212BC517ECC3A1
available time：2024-01-24 23:59

I got it, thank you so much for your reply! Best regards.

You can use this file "https://github.com/pkuzqh/Recoder/blob/master/repair.py"

Hi @pkuzqh , I'm trying to generate the data.pkl with runsolvereplaceYES2.py, but I can't retrieve the similar result as data.pkl format.
Can you give me a guide on how to reproduce the data generation part?
I need it to run Recoder on a new dataset, but I can't generate the required data for the replication..
Thank you and have a nice day! :)

You can use the following code to process data https://disk.pku.edu.cn:443/link/37FED995C8031D4DB8212BC517ECC3A1 available time：2024-01-24 23:59

Unfortunately, I only saw this link now, but it has expired. Could you please resend it？


Locale dao authorize on update

two issues:
If adding this authorizeOn then this model should implement Authorizable, and you should also implement authorizeOnCreate and Delete
Or as @kgrgreer mentioned, just add an authorizer in easyDAO
.setAuthorizer(new foam.nanos.auth.GlobalReadAuthorizer("locale"))

yes,
.setAuthorizer(new foam.nanos.auth.GlobalReadAuthorizer("locale"))
solve the issue.
https://github.com/foam-framework/foam2/blob/3a5cb639d8e01dfabe04c50f2266b54b4511854b/src/foam/i18n/services.jrl#L31


Remote attestation sample modified with reduced scope

As pointed out in #1707 , the remote attestation sample does not implement a secure channel. This PR modifies remote attestation to remove claims of having a secure channel and removing the additional session exchange routines after mutual attestation has been completed.
In short, this implements the reduced scope of the remote attestation sample.

Bors r+

Bors r+

Bors r+


Save game context

Save game status, copy or dump all memory. We want this feature to create a game mode but we want to return back to the game status before entering the mode. So dumping and loading can help to develope this feature.
If any other sugguestion appears during the development, comment it.

Deadline 2023-11-27 (YYYY-MM-DD) 21:30:00 (HH-MM-SS) @Sankeyr3


Add cosmovisor docker file

Closes: #XXX
What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documentation of area A by adding ....)
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added unit test that validates ...
Added integration tests for end-to-end deployment with ...
Extended integration test for ...
Manually verified the change by ...

Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Allora documentation site docs.allora.network source code at: https://github.com/allora-network/docs
[ ] Code comments?
[ ] N/A

cosmovisor env vars look good to me


Runtime tests using examples from docstrings

This PR is a proposal to add unit tests using docstrings. Currently the examples from docstrings have tests for compilation only.

bsc emits the Js and passes the code to node using the --eval|-e argument.

TODO:

[x] Fix examples
[x] Remove examples with infinite loop, setIntervalFloat
[x] Update CHANGELOG

Changes

Added assert_eq function
Runtime errors captured
Removed some examples with infinite loop at src/Core__Global.resi
Removed Array from the test suite and moved it to docstrings.

DocTest script

Added argument --ignore-runtime-tests

--ignore-runtime-tests 'RescriptCore.Array.toReversed,RescriptCore.Promise.withResolvers'. Array.toReversed and Promise.withResolvers are not supported by Node

Ready for review

I made a small improvement in two examples in the Null and Nullable module

@zth what do you think?


Data model

Data model
In this branch, I implemented the following;

Created a new app. Give it a meaningful name with Postgres database
Built the project schema using the provided ERD diagram
Created and ran the necessary migration files.
Ensured all columns that are foreign keys have a corresponding index.

@Alfredbis29 Please carefully go through the migration files. You will see I have implemented most of the changes you highlighted. They were implemented in a series of migrations. Also, confirm the tables form the cshema.rb file. Thank you

@Alfredbis29 Please always go through the files while reviewing.  You just made me waste a submission attempt because of a wrong review. Everything you highlighted in your review was already there.

@amejid the migration file for comments table was wrongly deleted. If I try to create it again. I get an error while trying to regenerate schema.rb (rails db:migrate)

@prius2055 Migrations will run in the order they were created. I think it would be easier to remove the migrations and create fresh ones in the correct order.

@prius2055 Migrations will run in the order they were created. I think it would be easier to remove the migrations and create fresh ones in the correct order.

This did not work. the schema file keeps throwing the error that the tables already exit. I deleted all the migrations and created a new one but still got the same error.

@prius2055 Try using rails db:migrate:reset

@prius2055 Try using rails db:migrate:reset

Thanks, I guess this is the only solution

@prius2055 Try using rails db:migrate:reset

Done. Thanks al lot

Hello dear @prius2055 , I sincerely apologize for any confusion or inconvenience caused by my previous review , I didn't see this notification. I want to assure you that I did review every single file, including the migration files, before providing my feedback. :thinking: , I would like to Thank @amejid  for his quick feedback :pray:
However, it seems there was a miscommunication or discrepancy between the expected table structures and the actual results after running the migrations. I apologize for any oversight on my part in identifying the incomplete tables during my review ,that was the reason I gave review and I focus more for what I had.
I genuinely appreciate your patience and understanding throughout this process. I apologize for being late in addressing the issue and any frustration it may have caused, But I review what have seen missing according to the project requirement.  I will appreciate hear from you if there still some questions or inconvenient.


[RFC] Kill slide on binders and function adaptors

I think we should no longer teach this slide:

Lambdas are a better replacement.

We discussed this in the jour fix today and agreed to drop the slide.


bootstrap-buttons - form doesn't submit in Chrome/Safari

When button state is set to loading, and the button is disabled, all events associated are halted including the form submission.
Happens only in Chrome/Safari (Win). Works fine in Firefox/IE.

Yep, i believe that is the intended behavior. An action has already began. It's meant to prevent people from invoking multiple actions in the case of a ajax submission.

if you just add a data-attribute for loading, and don't use any js at all - it doesn't just work?

Sorry, having a brain fart at the end of a long day... you mean something like this?
<button type="submit" value="Login" class="btn primary" data-loading="loading" data-loading-text="Logging you in...">Login

fixed with this commit - https://github.com/twitter/bootstrap/commit/e5fb1da164171a62612df8bded8ed3b2af8fed56
i'll push the new files to the cdn after i finish up going through tickets tonight :)


(BUG) unwanted video autoplay on mobile browser

upon accessing the website through a mobile browser, a video from the header section starts playing automatically (same for TEH and EGA)
video screen:
https://github.com/ecommerceberlin/ecommerceberlin.com/assets/80756258/d92b18a4-4fa4-4d2f-9da0-758d9b39a79f

seems like react/nextjs (outside) problem.... i encourage to disable video on EBE/EGA
how to disable? just comment //videoSrc in here section in settings

it was mobile-specific feature... "picture in picture" ... now disabled


Generator 1.9.1 doesn't support '--component-type library'

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
It should be able to use --component-type library as argument of the generator.
Observed Behavior
When the generator gets executed with the following command option:
yo @microsoft/sharepoint --component-type library --framework react

The result is  the following:

Steps to Reproduce
Execute the following command line with the<EMAIL_ADDRESS>installed.
yo @microsoft/sharepoint --component-type library --framework react

@StfBauer That command doesn't work since there is no framework prompt for library component.
yo @microsoft/sharepoint --component-type webpart --framework react  works since there is a component type of webpart and a prompt for framework. This is working by design.


Need a Group analog for New-AzureADUserAppRoleAssignment

New-AzureADUserAppRoleAssignment returns error when providing a group objectID to the -ObjectId and -PrincipalId parameters.
Code: Request_ResourceNotFound
Message: Resource 'guid' does not exist or one of its queried reference-property objects are not present.
Need a cmdlet to do the same work for assigning a group.

New-AzureADGroupAppRoleAssignment


Add camel-snmp wrapper

Used wrap protocol with a jar version 3.7.8 because of the latest SMX bundle is of 3.7.7_1

start review


Update to new memory ordering enum

The memory ordering moved from std::sync::atomic into the
std::sync::atomic::Ordering enum. This commit fixes the unresolve-issues.
rustc 0.13.0-nightly (ad9e75938 2015-01-05 00:26:28 +0000)

Hey there. Thanks for the PR. I think this has already been handled by #94.

Greetings. That #94 PR was my second try at not messing up with git/GitHub. ;-)
I closed it because of the unnecessary merge I created. This one does the same thing, it's just couple of commits smaller.


REST exception and HTTP status code handling

I adapted the following aspects of the current REST implementation:

Logging
Use plural (e.g. applications instead of application) for the REST web interface as this is the most common way
Return more meaningful HTTP status codes (see below)

I added a loadById method to the DAO and service, which is nice to have, e.g. to load (a proxy) of an object when deleting by id. This is more performant than using findById, which immediately accesses the database.

Path
HTTP method
HTTP Status Code(s)

rest/{entity}
GET
200 OK (with filled or empty array)

rest/{entity}/{id}
GET
200 OK404 NOT FOUND, if entity not found or access is denied

rest/{entity}
POST
200 OK400 BAD REQUEST in case of exception

rest/{entity}/{id}
PUT
200 OK404 NOT FOUND in case of exception (e.g. if object with {id} does not exist)400 BAD REQUEST, if {id} does not match the ID in the payload

rest/{entity}/{id}
DELETE
204 NO CONTENT (i.e. empty response) in case of successful deletion404 NOT FOUND in case of exception (e.g. if object with {id} does not exist)

Maybe i will push some more tests if you wait with merging ;-)

What do we return on POST or PUT, when e.g. required fields are not present? E.g. fields that cannot be null are missing in the payload.

I have added some minor comments but really like this. If you agree, and it isn't too much work, you can probably adress them. Either with comments or with actual commits.
Thanks anyhow and feel free to merge this once you are sure this is ready for primetime.

Answer to your question regarding POST/PUT with missing/wrong fields:

If Jackson cannot deserialize, it will (automagically) return a 400 BAD REQUEST (and we do not even come into our method)
If we are violating a database constraint (or the user has no ACL-right for update), we will return a 404 NOT FOUND (but developers can inspect the LOG for detailed information). Regarding a DB constraint violation, this may be a point for another enhancement! Thx for pointing this out...

Ahhh and btw: tests would be extra 🍨🍦🍰🍫

For some reason the coverage decreased more than 40 % !?!?!??? I hope that my last commit will fix this. But i dont understand why this did not happen before...

My suggestion is: The jacoco config was not correct before 7f3a432 but the system was working on cached resources as nothing has changed in the model module since the introduction of jacoco...

With regard to the massive coverage decrease: Just compare these three coverages and the files that make up the 100%

changed by -2.7 % for commit 3422c9f

302 of 462 relevant lines covered (36 files)

changed by -46.6 % for commit f382c2e
305 of 1423 relevant lines covered (67 files)
changed by -2.9 % for commit 7f3a432b66c137811afe8aa7a687b7c27c1237d0

305 of 468 relevant lines covered  (37 files)

So whatever has increased the number of files / lines (restructuring of dependencies, s.th. else?!?) was the reason for the decrease.
Anyhow, excluding the models is fine for me. Thanks for the continued work on this.
Please merge at will.

Enough tests :smile: LGTM, please merge


VS FSI does not work

Ctrl+F5 current master.
Open FSI window in the experimental VS instance.

Microsoft (R) F# Interactive version 4.1
Copyright (c) Microsoft Corporation. All Rights Reserved.
For help type #help;;

unknown(1,1): error FS1225: File 'C:\USERS\VASKI\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\15.0_D2A776E5FSHARPDEV\EXTENSIONS\MICROSOFT.VISUALFSHARPTOOLS\VISUAL F# TOOLS\<IP_ADDRESS>55\FSharp.Core.optdata' not found alongside FSharp.Core. File expected in C:\USERS\VASKI\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\15.0_D2A776E5FSHARPDEV\EXTENSIONS\MICROSOFT.VISUALFSHARPTOOLS\VISUAL F# TOOLS\<IP_ADDRESS>55\FSharp.Core.optdata.
unknown(1,1): error FS0229: Error opening binary file 'C:\USERS\VASKI\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\15.0_D2A776E5FSHARPDEV\EXTENSIONS\MICROSOFT.VISUALFSHARPTOOLS\VISUAL F# TOOLS\<IP_ADDRESS>55\FSharp.Core.dll': Exception of type 'Microsoft.FSharp.Compiler.ErrorLogger+StopProcessingExn' was thrown.
unknown(1,1): error FS3160: Problem reading assembly 'C:\USERS\VASKI\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\15.0_D2A776E5FSHARPDEV\EXTENSIONS\MICROSOFT.VISUALFSHARPTOOLS\VISUAL F# TOOLS\<IP_ADDRESS>55\FSharp.Core.dll': Exception of type 'Microsoft.FSharp.Compiler.ErrorLogger+StopProcessingExn' was thrown.
Session termination detected. Press Enter to restart.

It may be related to https://github.com/Microsoft/visualfsharp/issues/2098

sigh at those optdata/sigdata files.. Wasn't it decided they should be baked in? Can't seem to find that discussion now.

I do have #2098 on core projects but FSI seems to work fine both in exp instance and with VisualFSharpOpenSource.vsix installed.

@majocha have you ever run build.cmd vs to the end successfully?

@vasily-kirichenko yes, with some warnings. I just did a git pull, build.cmd, build.cmd vs and installed the vsix.

It still does not work in the exp instance. .optdata and .sigdata are missed:

Yes, if I copy those two files manually to ^^^, it works.

I tried deleting the experimental instance folder from appdata\local just now and FSI still starts fine on a fresh instance.

@KevinRansom @brettfo We should take a look at this and get it fixed for release.

It's still reproduced on current master.

@vasily-kirichenko Is this now working for you?

Given the original bug report was about optdata/sigdata, I will close this.


Fuel has no effect on motor

Minetest 5.8.0 (Minetest Game)
Fuel seems to have no effect on the boat.
When placing a boat for the first time, the boat seems to run infinitely without adding fuel.
After adding fuel, the fuel gauge will indicate the added fuel but seems to stand still even when running engine at full speed.

fixed!


OLE DB or ODBC error: Exception from HRESULT: 0x80040E4E.

I've followed the install instructions but I've recived the following error:

I am also seeing this issue, is there a resolution? - I dont see any other data sources aside from the Management address (that I have set to Org permission stratus as per docs)

Please check the privacy settings: https://github.com/Azure/CCOInsights/blob/main/dashboards/CCODashboard-Governance/GovernanceDeploymentGuide.md#modify-privacy-settings
This is a known issue: https://github.com/Azure/CCOInsights/issues/105#issuecomment-676399216


PR: Use Mac 12 to run tests on CIs

See: https://github.com/actions/virtual-environments/issues/5583

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/maininterpreter/tests/test_confpage.py:

Line 37:5: E128 continuation line under-indented for visual indent


[Lyft] Fix kafka consumer

why?

Currently, Kafka consumer is explicitly setting the offset as latest it might not be a good fit for certain scenario. It should be flexible and provide consumer options to set the offset accordingly based on the configuration.

Here are the properties that can be used:
auto.offset.reset

This isn't how the start offset in the Flink consumer is configured. Closing for now.


How to clear the validation errors after a dirty state ?

Hi @rfink. First of all congratulations for the nice directive.
I have a doubt, and i kindly ask for your help.
How can i clear any error when the directive has no content?
The scenario is the next:
1.- The user entry an invalid value in the textbox,
2.- The user clear the data.
3.- The form still has error because the directive is expecting a valid VIN, but the field is optional.

Thanks for bringing this to my attention.  I'll check into it as soon as I am able.

Thank you very much @rfink. This is the only bug i have found, apart from that i think your directive is great and very easy to use :)

My apologies, I haven't gotten to this yet.  I still plan on getting to this error, but my new gig has a release coming up and I've been slammed :P

I would really appreciate your help my friend when you have time. The directive is so flexible and this is the only error i had found

Juan, would it work for you if I remove the empty check altogether and let that be handle by "required" or "ng-required"?

Hi @rfink.... Yes it will work for me :)

This is done.  The version has been bumped to 0.1.0, and some documentation on building and testing has been added.  Thanks for the feedback.

This is Great !! Thank you very much @rfink  for the support. I will test it and let you know the results :)


"-nic: invalid option" when run QEMU image on ubuntu 18.04

[  -nic user,hostfwd=tcp::10022-:22,mac=00:11:22:33:44:55  ](https://github.com/vectorgrp/sil-kit-adapters-qemu/blob/210e2d187b81fda646805bc328f13012a50336ce/tools/run-silkit-qemu-demos-guest.sh#L8)
need to be replaced by
-netdev user,id=net0,hostfwd=tcp::10022-:22 \ -device e1000,netdev=net0,mac=00:11:22:33:44:55  to make it work on my ubuntu 18.04

@mingguangZhou: Thanks a lot for the hint. Since version 18.04 of Ubuntu is EOL for more than 1.5 years, we ask for your understanding that we will not take any further action on this issue.

Ubuntu 18.04 is EOL (see comment above)


linting off by one line

Errors are always displayed one line above the actual error.

Minimal pack for reproducing the issue:
DebugPack.zip

Can you provide the entire server log output too please? Need to see if theres some differences in line number reporting for different GPU/driver versions that wouldn't be unheard of

Assuming that you mean this:
Apr 24 18:04:50.970 INFO OpenGL device, renderer: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2, version: 4.6.0 NVIDIA 510.60.02, vendor: NVIDIA Corporation
Apr 24 18:04:50.970 INFO starting server..., trace: fe087f4c
Apr 24 18:04:50.970 INFO generating graph for current root, root: /home/niemand/Downloads/DebugPack, trace: fe087f4c
Apr 24 18:04:50.971 INFO finished building project include graph, trace: fe087f4c
Apr 24 18:04:50.972 INFO got updated configuration, config: {"logLevel":"info","skipBootstrap":false}, trace: febe9e4a
Apr 24 18:04:54.024 INFO top-level file ancestors found, ancestors: [], uri: /home/niemand/Downloads/DebugPack/shaders/world0/deferred.fsh, trace: 470d4694
Apr 24 18:04:54.041 INFO compilation errors reported, tree_root: /home/niemand/Downloads/DebugPack/shaders/world0/deferred.fsh, errors: `1(15) : error C1503: undefined variable "AMBIENT_LIGHT_STRENGTH"\n0(28) : error C0000: syntax error, unexpected reserved word "void", expecting ',' or ';' at token "void"\n`, trace: 470d4694
Apr 24 18:04:55.560 INFO top-level file ancestors found, ancestors: [], uri: /home/niemand/Downloads/DebugPack/shaders/world0/deferred.vsh, trace: b3d33585
Apr 24 18:04:55.561 INFO compilation errors reported, tree_root: /home/niemand/Downloads/DebugPack/shaders/world0/deferred.vsh, errors: `1(15) : error C1503: undefined variable "AMBIENT_LIGHT_STRENGTH"\n0(7) : error C1503: undefined variable "vec5"\n`, trace: b3d33585
Apr 24 18:04:56.810 INFO top-level file ancestors found, ancestors: [], uri: /home/niemand/Downloads/DebugPack/shaders/world0/deferred.fsh, trace: b356c7eb
Apr 24 18:04:56.811 INFO compilation errors reported, tree_root: /home/niemand/Downloads/DebugPack/shaders/world0/deferred.fsh, errors: `1(15) : error C1503: undefined variable "AMBIENT_LIGHT_STRENGTH"\n0(28) : error C0000: syntax error, unexpected reserved word "void", expecting ',' or ';' at token "void"\n`, trace: b356c7eb

Should be addressed by https://github.com/Strum355/mcshader-lsp/commit/27d1d7b34eba9e5e0142e2789ce35b267a29b02a, if not... :slightly_smiling_face: :slightly_smiling_face: :slightly_smiling_face: :slightly_smiling_face:


ScrollView stickyHeaderIndices problem

If a layer of ScrollView is wrapped outside, then the ScrollableTabView child element cannot be rolled.

@skv-headless

What react-native-scrollable-tab-view version do you use?

"react-native-scrollable-tab-view": "^0.7.0",

same issue here~~

Can you provide example project so I will be able to take a look?

@xclion 在吗大兄弟 怎么解决的

@xclion 在吗大兄弟 怎么解决的 被这个问题困扰一个星期了

Please can you give information on why this was closed without an answer?

Because there is no example repo for me to reproduce

Roger that. Let me knock one up...

Here is a repo to demonstrate the problems: https://github.com/alexpchin/react-native-scrollable-tab-view-sticky-header-indicies

same issue. when ScrollableTabView inside ScrollView. inside ScrollableTabView is a flatlist with dynamic data. so its height is dynamic. then i got problem:     problem 1: when set stickyHeaderIndices, the ScrollableTabView cant scroll, but it should can;
problem 2: not set stickyHeaderIndices, it can scroll, but flatList onEndReached auto trigger;
i try a lot, but still can`t fix it. so anyone can fix it?
`<ScrollView
style={{ flex: 1 }}
ref={(scrollView) => this.scrollView = scrollView}
showsVerticalScrollIndicator={false}
stickyHeaderIndices={[3]}

<View style={{ height: 200 }}><Text>1</Text></View>
<View style={{ height: 200 }}><Text>2</Text></View>
<View style={{ height: 200 }}><Text>3</Text></View>
<View style={{ flex: 1 }}>
    <ScrollableTabView
        initialPage={0}
        renderTabBar={() => <ScrollableTabBar style={{ borderBottomWidth: 0 }} />}
        tabBarInactiveTextColor='#666666'
        tabBarActiveTextColor='#333333'
    >
        <View tabLabel='page1'><FlatList /></View>
        <View tabLabel='page2'><FlatList /></View>
        <View tabLabel='page3'><FlatList /></View>
    </ScrollableTabView>

`


Implement metric for rejected ProcessProposal

Resolves https://github.com/celestiaorg/celestia-core/issues/803
TODO

[ ] unit tests
[ ] manually verify metric is emitted

do you know how much heavier it would be to also record proposer address?

oof I changed the base in Github UI from v0.35.x-celestia to v0.34.x-celestia which now shows a bunch of unnecessary commits. Will close and open a new PR that targets v0.34.x-celestia after rebasing locally.


Small improvements

I've made a number of changes here and there. accept the ones you approve of.

Why did you remove package.json?

Why did you remove package.json?

I didn't.


Addition of Tree Algoritms

Different Tree Algorithms has been done such as

Binary Tree
AVL Tree
Splay Tree
And their operations such as
-Insertion
-Traversal
Searching
Deletion

The file "commited" contains all the mentioned code . Please look for it

Do not make PR until I assign

but you assigned it to me

For more reference -

If some confusion or mistake from my end please clarify


[2.14.12] query params incorrectly decoded

Versions

nuxt: 2.14.12

Reproduction

After this fix #8494 urls are incorectly decoded.

Steps to reproduce
https://1csq9.sse.codesandbox.io/?email=some%2Bv1%40email.com&token=DvtiwbIzry319e6KWimopA%3D%3D
What is Expected?
Output:
DvtiwbIzry319e6KWimopA==
<EMAIL_ADDRESS>
What is actually happening?
Output:
DvtiwbIzry319e6KWimopA
some<EMAIL_ADDRESS>

one more broader example:
"%20!%22%23%24%25%26'()*%2B%2C-.%2F0123456789%3A%3B%3C%3D%3E%3F%40ABCDEFGHIJKLMNOPQRSTUVWXYZ%5B%5C%5D%5E_%60abcdefghijklmnopqrstuvwxyz%7B%7C%7D~"

Should be decoded to:
" !"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`abcdefghijklmnopqrstuvwxyz{|}~"

It is quite interesting: A%2B%3DB is decoded to A insted of A+=B.
It truncates the parameter.

@pi0 not ony + sign. Other signs are decoded incorectly too, like =#$%& and many many more.

Hi @awronski thanks for reproduction. I can confirm the bug but still investigating where double encoding is happening.
Also FYI  logic behind + behavior is in vue-router-next: https://github.com/vuejs/vue-router-next/blob/master/src/encoding.ts (ufo backported it but i currently disabled + behavior to be compatible with whatwg spec)
Updates

Tests with current version of ufo seem normalizing correctly for both cases: https://runkit.com/pi0/5fe4bb12df778f001a656d2d
Disabling patch in createRouter still reproduces same bug
fresh installation of nuxt < 2.14 throws warning Error decoding "%%23%24%%26%2B,%2F%3A%3B%3D%3F%40". Leaving it intact and not decoding

@pi0 Thanks for you help.
Before 2.14.12 the + and = were working correct.
I did not test other characters, only did it now when investigating the problem. I just checked all ascii characters.

@pi0 I created a test case for ufo. If I did everything correctly it fails for dozen characters:
https://runkit.com/awronski/5fe709480d6579001d2be3e6

@awronski normalizeURL actually does encoding and seems normal :) (results should be compared to whatwg fetch using new URL(..).href)

@pi0 I dont get it :)
normalizeURL - Ensures URL is properly encoded
So why it doesn't encode for example this?
normalizeURL('test?query=A=B#hash')
Result: "test?query=A#hash"

@pi0 I don't see why encodeQueryValue should be implemented as anything other than encodeURIComponent, which is used elsewhere in ufo. You say "results should be compared to whatwg fetch using new URL(..).href" which is what ufo's normalize.test.ts does, so here's a patch which demonstrates the behaviour failing. Having encodeQueryValue simply return encodeURIComponent(text); causes this test to pass.
diff --git a/test/normalize.test.ts b/test/normalize.test.ts
index 128e5d5..99cd264 100644
--- a/test/normalize.test.ts
+++ b/test/normalize.test.ts
@@ -1,6 +1,8 @@
 // @ts-nocheck
 import { normalizeURL, withoutTrailingSlash } from '../src'

+const charactersBelow7F = Array.from(new Array(127)).map((_, i) => String.fromCharCode(i)).join('')
+
 describe('normalizeURL', () => {
   const tests = {
     'http://foo.com': 'http://foo.com',
@@ -62,7 +64,9 @@ describe('normalizeURL', () => {
     // 'http://-.~_!$&\'() * +,;=:% 40: 80 % 2f:::::: @example.com',
     'http://1337.net',
     'http://a.b-c.de',
-    'http://<IP_ADDRESS>'
+    'http://<IP_ADDRESS>',
+    'http://foo.com/foo?u=https%3A%2F%2Fexample.com%2Fpath%3Fq%3Dstring',
+    'http://foo.com/foo?x=' + encodeURIComponent(charactersBelow7F)
   ]

   for (const input in tests) {

@pi0 I don't see why encodeQueryValue should be implemented as anything other than encodeURIComponent, which is used elsewhere in ufo. You say "results should be compared to whatwg fetch using new URL(..).href" which is what ufo's normalize.test.ts does, so here's a patch which demonstrates the behaviour failing. Having encodeQueryValue simply return encodeURIComponent(text); causes this test to pass.
diff --git a/test/normalize.test.ts b/test/normalize.test.ts
index 128e5d5..99cd264 100644
--- a/test/normalize.test.ts
+++ b/test/normalize.test.ts
@@ -1,6 +1,8 @@
 // @ts-nocheck
 import { normalizeURL, withoutTrailingSlash } from '../src'

+const charactersBelow7F = Array.from(new Array(127)).map((_, i) => String.fromCharCode(i)).join('')
+
 describe('normalizeURL', () => {
   const tests = {
     'http://foo.com': 'http://foo.com',
@@ -62,7 +64,9 @@ describe('normalizeURL', () => {
     // 'http://-.~_!$&\'() * +,;=:% 40: 80 % 2f:::::: @example.com',
     'http://1337.net',
     'http://a.b-c.de',
-    'http://<IP_ADDRESS>'
+    'http://<IP_ADDRESS>',
+    'http://foo.com/foo?u=https%3A%2F%2Fexample.com%2Fpath%3Fq%3Dstring',
+    'http://foo.com/foo?x=' + encodeURIComponent(charactersBelow7F)
   ]

   for (const input in tests) {

Some query strings are also removed: https://runkit.com/gabrielrobert/5ff5e3e629a0c2001334ae6a
In this example, 1234 should be preserved.

Some query strings are also removed: https://runkit.com/gabrielrobert/5ff5e3e629a0c2001334ae6a
In this example, 1234 should be preserved.

@gabrielrobert Thanks for reproduction. Issue with query parsing (when value contains = char) resolved in 0.5.3 (/cc @awronski i believe this also solves your question re 'test?query=A=B#hash' case)
@pdl Percent encoding set for query value is different than encodeURIComponent (see spec)
Update: token fixed (sandbox) trying to figure out issue with + to space...

@gabrielrobert Thanks for reproduction. Issue with query parsing (when value contains = char) resolved in 0.5.3 (/cc @awronski i believe this also solves your question re 'test?query=A=B#hash' case)
@pdl Percent encoding set for query value is different than encodeURIComponent (see spec)
Update: token fixed (sandbox) trying to figure out issue with + to space...

@pi0 I don't believe you are correctly interpreting the spec. The query percent-encode set is the set of things which must be encoded in the query string as a whole, i.e. from the ? to the end of the url or the fragment (indicated with #). It does not include &?=, all of which for web browsers have special meaning within the query string. In particular, your implementation will still break for a parameter with a value containing & .

@pi0 I don't believe you are correctly interpreting the spec. The query percent-encode set is the set of things which must be encoded in the query string as a whole, i.e. from the ? to the end of the url or the fragment (indicated with #). It does not include &?=, all of which for web browsers have special meaning within the query string. In particular, your implementation will still break for a parameter with a value containing & .

@pi0 In version  0.5.3 the plus sign is not encoded
console.log(normalizeURL('test?query=A+B')) returns "test?query=A+B"
Shouldn't it be test?query=A%2BB

@pi0 In version  0.5.3 the plus sign is not encoded
console.log(normalizeURL('test?query=A+B')) returns "test?query=A+B"
Shouldn't it be test?query=A%2BB

i can repro this on 2.14.6, when fetching on client my plus signs are decoded properly, however on the server somewhere down the line they become spaces.

i can repro this on 2.14.6, when fetching on client my plus signs are decoded properly, however on the server somewhere down the line they become spaces.

@awronski Actually having plus (+) in query value is valid by both whatwg/rfc3986 and that's why ufo is doing so. But since vue-router uses plus as a shorthand for space (src), it makes problems.
I've enabled plus encoding back in 0.5.4 (https://github.com/nuxt-contrib/ufo/commit/82ab3f17de0088529bb25f1b0ed31ab09443ed26) to resolve this conflict with vue-router...
Updated sandbox: https://7yf7h.sse.codesandbox.io/?email=some%2Bv1%40email.com&token=DvtiwbIzry319e6KWimopA%3D%3D
Please use yarn upgrade nuxt | npm up nuxt to get the fix and if still other problems exist, use a new issue with reproduction to track.

@awronski Actually having plus (+) in query value is valid by both whatwg/rfc3986 and that's why ufo is doing so. But since vue-router uses plus as a shorthand for space (src), it makes problems.
I've enabled plus encoding back in 0.5.4 (https://github.com/nuxt-contrib/ufo/commit/82ab3f17de0088529bb25f1b0ed31ab09443ed26) to resolve this conflict with vue-router...
Updated sandbox: https://7yf7h.sse.codesandbox.io/?email=some%2Bv1%40email.com&token=DvtiwbIzry319e6KWimopA%3D%3D
Please use yarn upgrade nuxt | npm up nuxt to get the fix and if still other problems exist, use a new issue with reproduction to track.

@pi0 Hi! I'm currently having issues related to the "%20" caractere in the URL, the  " " is automatically turning into "+". I've just tested it on your sandbox(https://7yf7h.sse.codesandbox.io/?email=some aemail.com&token=DvtiwbIzry319e6KWimopA%3D%3D) and is also happening, so thats probably not a problem with my nuxt config. Can you help me?

@pi0 Hi! I'm currently having issues related to the "%20" caractere in the URL, the  " " is automatically turning into "+". I've just tested it on your sandbox(https://7yf7h.sse.codesandbox.io/?email=some aemail.com&token=DvtiwbIzry319e6KWimopA%3D%3D) and is also happening, so thats probably not a problem with my nuxt config. Can you help me?

Issue to track: https://github.com/nuxt/nuxt.js/issues/8692

Issue to track: https://github.com/nuxt/nuxt.js/issues/8692


⚠ Spryr has degraded performance

In fdf3d16, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 6979 ms

Resolved: Spryr performance has improved in c911686 after 7 minutes.


init.pp should have 'staging' set as the default as specified

The README specifies that staging is the default deploy module but archive is still specified within init.pp as default.
This PR corrects that.

This should also help to avoid issues such as: #173

Hi @sacres, thanks for the PR. I'm not sure if it is a good idea to include staging. We are trying to get rid of it. The better solution is probably to fix the archive implementation in this module and not to include staging.

Thanks for the info @bastelfreak . I'm following your suggestion re: archive and closing this in favor of new PR #183 .


Added support for RDS files

i added support for RDS files for base R objects
also datacubes can be exported as .rds but they are currently just turned into a JSON-Object

What are your main use cases for saving in RDS??

What are your main use cases for saving in RDS??

The main use case is exporting trained machine learning models as RDS. As the models are trained in R, this is currently the best option to provide access to users of the backend.
This is needed for a process we will integrate into the backend soon.

The main use case is exporting trained machine learning models as RDS. As the models are trained in R, this is currently the best option to provide access to users of the backend.
This is needed for a process we will integrate into the backend soon.

Cool, for saving and loading ml models I recommend implementing APIs closer to the ones in this openEO-processes (https://github.com/Open-EO/openeo-processes/pull/441)[pull request]


Add 'diffoscope' for MacOS in pkgcheck.yml

Add missing brew package on MacOS for 'diffoscope'.
Disable ABI check for MacOS as the runner doesn't contain abigail.

Seems like we should disable abicheck for MacOS as there is no abigail for MacOS...

I'm ok with just testing it on just one platform. @dankegel thoughts?

Well, this is kind of an argument for splitting it out into its own yml; you could also skip abicheck on mac with a conditional.
It would make me uncomfortable to not run pkgcheck.sh on mac...

I'm not sure if we should or shouldn't make another pull request to fix the issue with abicheck. I already did split this to two pull requests just for pkgcheck.

Add if statement to yaml to check for macOS.
- name: Check ABI
   # macOS does not contain abigail
   if: runner.os != 'macOS'
...
- name: Check ABI (compat)
   # macOS does not contain abigail
   if: runner.os != 'macOS'

@nmoinvaz Done...

Perhaps in the future we can change ABI check to use this project: https://github.com/lvc/abi-compliance-checker which supports macOS, Windows, and Linux. @dankegel

Why would you want to switch away from libabigail?
Looks like gnutls switched to libabigail recently:
https://gitlab.com/gnutls/gnutls/-/merge_requests/972

@dankegel obviously because the MacOS runner in GitHub doesn't have abigail.

Guess I wasn't paying attention.  Sure, should be easy to switch (or maybe use the other tool on the other platforms).

@dankegel I guess I can leave that for another pull request, now pkgcheck at least works on MacOS.

codecov seems stuck, but I think this is ready for merging when @dead2 has time...


[Fix] no-invalid-html-attribute: allow 'shortcut' on link

Closes #3172
Description
For historical reasons, the icon keyword may be preceded by the keyword "shortcut".
https://html.spec.whatwg.org/multipage/links.html#rel-icon (last sentence before the next paragraph about license)
Intentions

First of all I'm checking if there are pairs registered for the given attribute name after all.
Now I'm splitting the attribute value(s) into overlapping pairs. If you want to check on the funky regex: https://regex101.com/r/aJXAEz/1
now I'm iterating pair by pair
on each pair I check what are the possible siblings for my current item - currently there is only 1:1 but potentially there could be a pair where foo can go with bar OR baz but NEVER qux
now I check if my pair is separated by a single space or multiple in between
Check if the first value has a corresponding pairing
Get the last value as this is the "real" second one
Check if this is not one of the anticipated siblings
set message and message id based on, if the second value is truthy

if it is the attribute was not paired with the right one
if its not it stands alone which makes it invalid.

report the issue
check if there is only one option what the sibling could be, if there is only one anyways let's autofix it for the user! 🎉

Demo
This introduces two new messages:
<link rel="shortcut"></link>

Reports: “shortcut” must be directly followed by “icon”.
Fixes to:
<link rel="shortcut icon"></link>

<link rel="shortcut manifest"></link>

Reports: “shortcut” can not be directly followed by “manifest” without “icon”.
Fixes to:
<link rel="shortcut icon manifest"></link>

Let's add some tests that show that shortcut by itself is invalid.

Yes that should be already in:
    {
      code: '<link rel="shortcut"></link>',
      output: '<link rel="shortcut icon"></link>',
      errors: [
        {
          messageId: 'notAlone',
          data: {
            reportingValue: 'shortcut',
            missingValue: 'icon',
          },
        },
      ],
    },

Just shortcut can not be alone and will be auto-fixed to shortcut icon.
Now next I need to look into some spacing that is still added:

Hope to be able to solve this soon 🤞🏻
When everything is ready I will mark the PR as ... "not draft" 😅 and will write up some description what I did and what my intentions were.

OK I see that I can't actually do two things in one go, so even
      code: '',
      output: '',

doesn't turn directly into only noopener but it is expected that there is an (invalid) leading space, so then I changed the expectations on my newly added code to also expect a trailing space that I just couldn't manage to get rid of in one go (will be picked up by spaceDelimited rule in the next cycle).
I added my intentions kind of line by line so that you can understand the code better for making suggestions.
Happy / Ready for round two 😄 👍🏻

Ohh and there was an issue on the white-space part - before we always removed everything that is not exactly one space character - but that means that two spaces between two words will just be removed, instead we should replace all white-space that is not in the beginning or the end to exactly one space character. For security this should also include non-breaking-spaces (e.g. when copied from somewhere else) - so I added another test case that covers that.

We should not autofix shortcut to shortcut icon; that's not a safe autofix because it will change runtime behavior. It should be a warning that requires the user to manually fix it.

Thanks for the feedback! Will work on it! 👍🏻

Codecov Report

Merging #3174 (0d89462) into master (151bb2b) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 0d89462 differs from pull request most recent head 4de38ef. Consider uploading reports for the commit 4de38ef to get more accurate results

@@           Coverage Diff           @@
##           master    #3174   +/-   ##
=======================================
  Coverage   97.54%   97.54%
=======================================
  Files         120      120
  Lines        8265     8265
  Branches     2975     2975
=======================================
  Hits         8062     8062
  Misses        203      203

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151bb2b...4de38ef. Read the comment docs.

Yay 🎉 Thanks for your support - in the end it was a lot of fun, even when it was a bit scary first 🚀

Heads up that I did need to land https://github.com/yannickcr/eslint-plugin-react/commit/5f49f51dd237dd4c6758bc0c3e5b300a28770966, due to array destructuring and spread syntax not working on node 4 and 5.

I also filed #3180 to track updating the implementation - I think now that we have "pairs", and good test cases, it'd be worth rewriting it from scratch.


Update values.py

Request to add HR-V fingerprints to /honda/values.py
Generated from /fingerprint_helper.py

These 3 (so far) pull requests should all be in one car port pull request.
Also, the fingerprint which you have is the "V1" fingerprint. We are only merging "V2" fingerprinting which is based off of ECU firmware versions. See https://github.com/commaai/openpilot/blob/master/selfdrive/car/fw_versions.py


missing run_dependency

In debs, cob_omni_drive_controller is not installed...thus adding it as run_depend

We should review the debs in cob_bringup and cob_bringup_sim...and sort them!

Seems like this tool could help
See here for announcment and discussion
@ipa-fmw, @ipa-nhg, @ipa-mdl, @ipa-mig FYI

This tool cannot help here, since the dependency is hidden in a configuration file.
In addition the "type" param is quite common and we would need a very specialized tool that checks where the param is loaded to.
I would suggest to sort dependencies alphabetically, perhaps grouped by the XML tags, but not by stacks/repos. We move packages occasionally..

Ok, well for me this PR was already a reminder to carefully review our package.xml's in general.
I will test this tool and see whether it can help detect missing or obsolete dependencies...
Of course it doesn't help with the type dependencies...we'll need to take care of that manually.
Also, sorting alphatecially is fine for me, then....

Will be resolved in #319...closing!


segfaults with xdebug and PHP 7.3

Describe the bug
I get segfaults using DDev with xdebug and PHP 7.3: [16-Apr-2019 15:26:58] WARNING: [pool www] child 2323 exited on signal 11 (SIGSEGV - core dumped) after 394.607491 seconds from start
If I switch back to PHP 7.2, it all works fine.
To Reproduce

Create a Drupal 8 project
Enabled xdebug (I used ddev exec enable_xdebug
Visit any page - segfault

Expected behavior
Pages should load properly and you should be able to use PHPStorm to step through.
Version and configuration information (please complete the following information):

Ubuntu 18.04.2 LTS
Docker version information:

Client:
 Version:           18.09.4
 API version:       1.39
 Go version:        go1.10.8
 Git commit:        d14af54266
 Built:             Wed Mar 27 18:35:44 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          18.09.4
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.8
  Git commit:       d14af54
  Built:            Wed Mar 27 18:01:48 2019
  OS/Arch:          linux/amd64
  Experimental:     false

ddev version information:

bgsync          drud/ddev-bgsync:v1.7.0
cli             v1.7.1
commit          v1.7.1
db              drud/ddev-dbserver:v1.7.0-10.2
dba             drud/phpmyadmin:v1.7.0
ddev-ssh-agent  drud/ddev-ssh-agent:v1.7.0
docker          18.09.4
docker-compose  1.23.1
domain          ddev.local
router          drud/ddev-router:v1.7.0
web             drud/ddev-webserver:v1.7.0

config.yaml contents for the misbehaving project

APIVersion: v1.7.1
name: drupal
type: drupal8
docroot: web
php_version: "7.2"
webserver_type: nginx-fpm
router_http_port: "80"
router_https_port: "443"
xdebug_enabled: false
additional_hostnames: []
additional_fqdns: []
mariadb_version: "10.2"
webcache_enabled: false
nfs_mount_enabled: false
provider: default

# This config.yaml was created with ddev version v1.7.1
# webimage: drud/ddev-webserver:v1.7.0
# dbimage: drud/ddev-dbserver:v1.7.0-10.2
# dbaimage: drud/phpmyadmin:v1.7.0
# bgsyncimage: drud/ddev-bgsync:v1.7.0
# However we do not recommend explicitly wiring these images into the
# config.yaml as they may break future versions of ddev.
# You can update this config.yaml using 'ddev config'.

# Key features of ddev's config.yaml:

# name: <projectname> # Name of the project, automatically provides
#   http://projectname.ddev.local and https://projectname.ddev.local

# type: <projecttype>  # drupal6/7/8, backdrop, typo3, wordpress, php

# docroot: <relative_path> # Relative path to the directory containing index.php.

# php_version: "7.1"  # PHP version to use, "5.6", "7.0", "7.1", "7.2", "7.3"

# You can explicitly specify the webimage, dbimage, dbaimage lines but this
# is not recommended, as the images are often closely tied to ddev's' behavior,
# so this can break upgrades.

# webimage: <docker_image>  # nginx/php docker image.
# dbimage: <docker_image>  # mariadb docker image.
# dbaimage: <docker_image>
# bgsyncimage: <docker_image>

# router_http_port: <port>  # Port to be used for http (defaults to port 80)
# router_https_port: <port> # Port for https (defaults to 443)

# xdebug_enabled: false  # Set to true to enable xdebug and "ddev start" or "ddev restart"

# webserver_type: nginx-fpm  # Can be set to apache-fpm or apache-cgi as well

# additional_hostnames:
#  - somename
#  - someothername
# would provide http and https URLs for "somename.ddev.local"
# and "someothername.ddev.local".

# additional_fqdns:
#  - example.com
#  - sub1.example.com
# would provide http and https URLs for "example.com" and "sub1.example.com"
# Please take care with this because it can cause great confusion.

# upload_dir: custom/upload/dir
# would set the destination path for ddev import-files to custom/upload/dir.

# working_dir:
#   web: /var/www/html
#   db: /home
# would set the default working directory for the web and db services.
# These values specify the destination directory for ddev ssh and the
# directory in which commands passed into ddev exec are run.

# omit_containers: ["dba", "ddev-ssh-agent"]
# would omit the dba (phpMyAdmin) and ddev-ssh-agent containers. Currently
# only those two containers can be omitted here.
# Note that these containers can also be omitted globally in the
# ~/.ddev/global_config.yaml or with the "ddev config global" command.

# host_webserver_port: "59001"
# The host port binding for the ddev-webserver can be explicitly specified. It is
# dynamic unless otherwise specified.
# This is not used by most people, most people use the *router* instead
# of the localhost port.

# host_db_port: "59002"
# The host port binding for the ddev-dbserver can be explicitly specified. It is dynamic
# unless explicitly specified.

# provider: default # Currently either "default" or "pantheon"
#
# Many ddev commands can be extended to run tasks after the ddev command is
# executed.
# See https://ddev.readthedocs.io/en/stable/users/extending-commands/ for more
# information on the commands that can be extended and the tasks you can define
# for them. Example:
#hooks:
# post-import-db:
#   - exec: drush cr
#   - exec: drush updb

Do you have any custom configuration (nginx, php, mysql) in the .ddev folder? If so, have you tried without them? Nothing custom

Is this possibly https://bugs.xdebug.org/view.php?id=1583 ?  I don't think xdebug has fully stabilized with php73, in fact it didn't even work when php7.3 came out.

I'm going to close this in favor of updated php7.3 and xdebug in the next release of ddev in a week or so. Please continue the conversation with your results at that point, we can easily reopen. There's not much ddev can do about the ongoing php73/xdebug drama though.

Also, if you have a particular code segment or example we can use to demonstrate, would love to have it. However, the conversation should probably be in the xdebug queue.

Just a note that ddev v1.8.0 (next week) will have xdebug 2.7.1 and php7.3.5.  Would love to hear specifics if there is any continuing trouble.

ddev v1.8.0 is out, and includes xdebug 2.7.1; I did only a trivial debugging exercise, but had no trouble. Will look forward to further reports @andrewbelcher


[feature] Rename attestation.intoto.jsonl to provenance.intoto.jsonl

Shall we rename the default provenance filename for the generic workflows?
Maybe slsa3-provenance.intoto.jsonl or simply provenance.intoto.jsonl?
@ianlewis wdut?

Yeah, maybe that makes more sense.

BTW, the in-toto attestation doc states:

Bundles that concern a single artifact SHOULD name the bundle file <artifact filename>.intoto.jsonl.
Bundles that concern multiple artifacts SHOULD name the bundle file multiple.intoto.jsonl.

So maybe we should be adhering to this as the default file names.

LGTM.


Network automation testing

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@9e579b6). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 5d33d4b differs from pull request most recent head 41b1960. Consider uploading reports for the commit 41b1960 to get more accurate results

@@          Coverage Diff           @@
##             dev    #1559   +/-   ##
======================================
  Coverage       ?   13.29%
  Complexity     ?      298
======================================
  Files          ?      165
  Lines          ?     7471
  Branches       ?      703
======================================
  Hits           ?      993
  Misses         ?     6336
  Partials       ?      142

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e579b6...41b1960. Read the comment docs.


⚠ Spryr has degraded performance

In b445d2c, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 6196 ms

Resolved: Spryr performance has improved in 6ce78ad after 7 minutes.


[New term] Abstraction for French

Please describe why this term needs to be added
What this term is about? (briefly)

In the context of computing, an abstraction is a representation that hides specifics from a consumer of services (a consumer being a computer program or human), making a system more generic and thus easily understood.

Why this term needs to be added? (briefly)

Localizing this term in French will help French-speaking folks learn about this term in their native language.

Link here - https://glossary.cncf.io/abstraction/

Hello, I would like to work on this issue. Anyone can review it and can assign it to me? :)

Hi @HenokB,
You can contact the french localization team theough the channel #glossary-localization-french on CNCF Slack. The people mentioned here are responsible for Hindi localization.

@HenokB are you a french native speaker?

@HenokB are you a french native speaker?

No, I'm not a native speaker.

I admire your enthusiasm, but this is not how it works. You have to be a native speaker in order to localize a term. This should be obvious. Please make sure you read the contribution guide: https://glossary.cncf.io/contribute/

I would like to work on this issue . Please assign it to me.


Making the app version more available

Description
This PR is in response to #522 .  Essentially, it makes the app version more clear and visible to the user.  And it gives a clear place for an app developer to define the version of their application.

Checklist

[X] The code is understandable and maintainable to people beyond the author.
[X] Tests have been added/updated to verify that the new or changed code works.
[X] There is no commented out code in this PR.
[X] The commit message follows good practices.
[X] All docstrings are still up-to-date with these changes.

@drewj-usnctech  I don't know if you had seen this yet.
Just curious what you think.  Essentially, this provides a new property App.version that can be over-ridden by your App subclass, and when you do that, you will get the desired functionality on the command line:

$ MyApp -v
MyApp 1.2.3


Don't erase previous sampling results in ModelBuilder

Closes #410
Still need to test some other changes

:books: Documentation preview :books:: https://pymc-marketing--414.org.readthedocs.build/en/414/

I will pick this up sometime soon!

Closing after #741 merge. Let's address the data_groups in a different PR if that is needed


[refactor] Add relation_spec

This moves the remaining test cases in redis_record_spec to a separate relation_spec file.

Codecov Report

:exclamation: No coverage uploaded for pull request base (02003ba62750bfa48a57b34c4f1a4efacdf0aa4e@02003ba). Click here to learn what that means.
The diff coverage is n/a.

@@                             Coverage Diff                             @@
##             02003ba62750bfa48a57b34c4f1a4efacdf0aa4e      #49   +/-   ##
===========================================================================
  Coverage                                            ?   96.09%
===========================================================================
  Files                                               ?       24
  Lines                                               ?      871
  Branches                                            ?        0
===========================================================================
  Hits                                                ?      837
  Misses                                              ?       34
  Partials                                            ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02003ba...bbeb8f3. Read the comment docs.