relative image url's

Thanks again for creating this awesome package!
all url's right now are absolute (see example) when using MUP (even though I set the enviroment variable ROOT_URL to myDomainName):
{
name: 'SCqsTggwxkf8tPfuB_bali.jpg',
path: '/SCqsTggwxkf8tPfuB_bali.jpg',
size: 300587,
type: 'image/jpeg',
error: null,
url: 'http://localhost:3000/upload/SCqsTggwxkf8tPfuB_bali.jpg',
bigPictureUrl: 'http://localhost:3000/upload/bigPicture/SCqsTggwxkf8tPfuB_bali.jpg',
thumbnailBigUrl: 'http://localhost:3000/upload/thumbnailBig/SCqsTggwxkf8tPfuB_bali.jpg',
thumbnailSmallUrl: 'http://localhost:3000/upload/thumbnailSmall/SCqsTggwxkf8tPfuB_bali.jpg'
}
Is it possible to have relative url's instead? Right now i'm simply splitting them and overwriting the key values in the object.

My pleasure. "Path" contains a relative path to your upload url.

On 12 Jul 2015, at 8:36 pm, lowen<EMAIL_ADDRESS>wrote:
Thanks again for creating this awesome package!
all url's right now are absolute (see example) when using MUP (even though I set the enviroment variable ROOT_URL to myDomainName):
{
name: 'SCqsTggwxkf8tPfuB_bali.jpg',
path: '/SCqsTggwxkf8tPfuB_bali.jpg',
size: 300587,
type: 'image/jpeg',
error: null,
url: 'http://localhost:3000/upload/SCqsTggwxkf8tPfuB_bali.jpg',
bigPictureUrl: 'http://localhost:3000/upload/bigPicture/SCqsTggwxkf8tPfuB_bali.jpg',
thumbnailBigUrl: 'http://localhost:3000/upload/thumbnailBig/SCqsTggwxkf8tPfuB_bali.jpg',
thumbnailSmallUrl: 'http://localhost:3000/upload/thumbnailSmall/SCqsTggwxkf8tPfuB_bali.jpg'
}
Is it possible to have relative url's instead? Right now i'm simply splitting them and overwriting the key values in the object.
—
Reply to this email directly or view it on GitHub.

I meant the path's to all the converted images.
or you mean you would include a different path in HTML? Like so:

you can see your package in action @ dateanomad.net (my new project). I still want to include a loader for the images. The image conversion seems to take quite a long time.

What you do seems fine to me. Server does not return paths to thumbnails unfortunatelly. This you shall be able to solve easily, just like you did.


Calibrating and Labeling Data with a Fisheye Lens Camera

Hello! I am generating the intrinsic parameters of the cameras using the MATLAB Camera Calibrator app. One camera I am using has a fisheye lens. I noticed that the camera with a fisheye lens has different intrinsic parameters than a camera without a fisheye lens. Cameras without a fisheye lens have the intrinsic matrix, radial distortion, and tangential distortion. Cameras with a fisheye lens do not have any of these categories, but instead have the following:

Cameras with and without a fisheye lens have a rotation matrix and a translation vector.
Is there a way for me to generate the camera extrinsics for a camera with a fisheye lens? Thank you.

Hi! The fisheye camera model is different than the pinhole camera model (we use the latter). The only way to to integrate a fisheye lens would be to introduce new projection and distortion functions in DANNCE. Can you use a different lens? =)


disableIPSecReplayProtection flag for VPN gateway

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. : around November
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. : around November
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[x] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[x] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@misbamomin, the PR that merge may-release branch to main branch is already created. Could you work with @MikhailTryakhov to check whether this PR could be part of that effort? Otherwise, you may put it into the next major release.


ClusterSample.Tx doesn't seem to work if outer radius is a quantity not a string

For instance:
ce_tx = srcs.Tx('r500', inner_radius=0.15*srcs.r500)
Works fine when retrieving the core excised temperatures of the LoCuSS sample, but using:
ce_tx = srcs.Tx(srcs.r500, inner_radius=0.15*srcs.r500), doesn't seem to work.
Functionally they should be identical, but obviously aren't

It seems like its some sort of conversion problem, which makes sense I suppose. Its specifically happening for Abell0209 in the LoCuSS sample, when I pass 'r500' as the outer radius, these are the numbers for inner and outer radius:
Abell0209 0.018669749228317035 deg 0.12446499485544689 deg
However, if srcs.r500 is passed then we get:
Abell0209 0.018669749228317035 deg 0.12446499485544692 deg
I'm going to have a look at the region setup function to see why

Something odd is going on, possibly some sort of floating point error. When the radius of A209 (1513kpc) is stored, its first converted to degrees (0.12446499485544689 deg), but when that number is converted back to kpc it goes to 1513.0000000000002 kpc.
When I use the convert_radius function 0.12446499485544689 deg is what actually converts back to 1513kpc.
So honestly I don't really know what is going on.
The trouble is I need the radius to match exactly to locate the spectrum, and seems like 99% of the time it does, so I don't know why its rearing its head now, perhaps because I passed the quantities in in Mpc?

Pandas is reading in the values from file wrong, so 1.513 is being read in as 1.513000000000001 or something like that. Saying that, I don't get why it isn't consistent throughout the analysis because if thats what is being fed into the source it should stay like that

So its because it gets converted from Mpc to kpc it goes from 1.5130000000000001 Mpc to 1513.0000000000002 kpc, and thats where this stems from I think?
Again I don't know why this isn't consistent throughout the entire analysis, and its Friday so right now I don't care

So the general issue here is that somehow the 'r500' and srcs.r500 results aren't necessarily exactly the same, though I'm not sure why.


Allow 'enqueue' in list of articles

Resolves https://github.com/newsboat/newsboat/issues/2023.

Coverage decreased (-0.02%) to 59.269% when pulling 2b0cc29cd4df586e3bf0e4dfb659c54af955ab7b on dennisschagt:enhance/issue-2023 into c769f32bce9c4ff1610c43a876b8e2022caa8e18 on newsboat:master.


Errors as of 7/30. Was working great until this time

We have been using this script for a year now, its great love it. As of 7/30 it stopped working and we cant figure out why. Here is the errors when we run the script. Were running Exchange 2016 with Windows 2012 R2
WARNING: The file C:\pfscripts\ignorelist.txt could not be found. No servers, DAGs or databases will be ignored.
Cannot bind argument to parameter 'Server' because it is null.
+ CategoryInfo          : InvalidData: (:) [Get-PowerShellVirtualDirectory], ParameterBindingValidationException
+ FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Get-PowerShellVirtualDirectory
+ PSComputerName        : M1.1.com
WARNING: Cannot bind parameter 'ConnectionUri'. Cannot convert value "http:///powershell" to type "System.Uri". Error:
"Invalid URI: The hostname could not be parsed."
WARNING: Cannot validate argument on parameter 'Session'. The argument is null or empty. Provide an argument that is
not null or empty, and then try the command again.
Remove-PSSession : Cannot validate argument on parameter 'Id'. The argument is null. Provide a valid value for the
argument, and then try running the command again.
At C:\pfscripts\Get-DAGHealth.ps1:233 char:19

Remove-PSSession $session.Id

                 ~~~~~~~~~~~

CategoryInfo          : InvalidData: (:) [Remove-PSSession], ParameterBindingValidationException
FullyQualifiedErrorId : ParameterArgumentValidationError,Microsoft.PowerShell.Commands.RemovePSSessionCommand

never mind I figured it out, just modified this with my server name Get-PowerShellVirtualDirectory -Server


Basic recorder implementation

Basic recorder for Android client
Includes

Record activity's java file
Record activity's XML layout and template

Expectations

Android client can now preview camera upon reaching Record state
Android client can now record by pressing on the center record button
Android client can now stop recording by pressing on the center record button if recording

Code can be factorised further in the future.
There are some nitty-gritty stuff which you can take care of in later sprints like the format of log messages and comments, whitespaces and variable name casing, 80 column wrapping
But a really great job on the sprint! good to merge.


When adding type in definition, the Value.Default() function returns false instead of true

What version of CUE are you using (cue version)?

$ cue version devel windows/amd64

Does this issue reproduce with the latest release?
yes
What did you do?

my cue file is as following
{
	graphTooltip: int >=0 <=2 | *0
}

when I read with API cue.Value.Default() on the field graphTooltip, it returns (int >=0 <=2 | *0, false)
I need to change the cue file to
{
	graphTooltip: >=0 <=2 | *0
}

to make the return (0, true). It seems I should remove the field type to make the Default function behave correctly.
What did you expect to see?
I would expect the default value return correctly (0, true) even I specify the int type
What did you see instead?
As described before, when I specify int for graphTooltip, the Default() returns false which is wrong

You probably intended to write graphTooltip: int & >=0 & <=2 | *0 and graphTooltip: >=0 & <=2 | *0.
Unfortunately, both are valid parses, but will result in unresolvable "incomplete" errors that will throw off Default and Err . Issue #405 requests to make this a more persistent failure.

This issue has been migrated to https://github.com/cue-lang/cue/issues/742.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


[python] handle RandomState object in Scikit-learn Api

I am using LightGBM with its scikit-learn API in a wrapper model called Boruta.
Boruta is using multiple cloned LGBM models in sequence.
In every iteration, it is cloning and setting parameters, including the random_state used in random number generation.
LGBM is not able to handle a RandomState object from Numpys random module which is the standard in scikit-learn models.
Because of that, many wrappers just pass down the RandomState in their inner models.
This was already discussed in #730.
LGBM is using an integer to seed its number generators and expects an integer, which makes it unusable in this context.
In this PR I added a random_state property with a setter method to handle RandomState objects.
If an RS object is passed, It derives an integer based on its state.
The advantage of the property is, that it handles both use cases:

normal initialisation
cloning and setting parameters via set_params

This change is quite minimal in my opinion and still allows the passing of integers as before.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: lpfann sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

The tests should all pass.
The only error is caused by an unrelated URL check which is apparently rate limited by Google (youtube video in docs)?!

@lpfann Thanks for your PR! I think this is useful feature.
However, I believe that the following recently added to XGBoost implementation is a little bit clearer: https://github.com/dmlc/xgboost/pull/5049.
It requires less code, doesn't create additional properties and the most important follows scikit-learn dev guide. You can replace RandomState object with int value somewhere here:
https://github.com/microsoft/LightGBM/blob/0d878b17fe696e6656606f2072053cc7327300c5/python-package/lightgbm/sklearn.py#L498-L518

The only error is caused by an unrelated URL check which is apparently rate limited by Google (youtube video in docs)?!

Please never mind! This test is flaky.

@lpfann Thanks for your PR! I think this is useful feature.

Thanks for your feedback!

However, I believe that the following recently added to XGBoost implementation is a little bit clearer: dmlc/xgboost#5049.
It requires less code, doesn't create additional properties and the most important follows scikit-learn dev guide. You can replace RandomState object with int value somewhere here:
https://github.com/microsoft/LightGBM/blob/0d878b17fe696e6656606f2072053cc7327300c5/python-package/lightgbm/sklearn.py#L498-L518

I adapted it now according to your hint.
Its simpler and also preserves the original RandomState object.
It only derives the integer when actually fitting and passing the parameters down to the low level library.

I'd like to get one more review from @henry0312, @guolinke or @jameslamb before merging

I think we should combine two test cases: first that that same RandomState results in the same models, second that re-fitting model results in different predictions as new seed is sampled at each fit stage.

I think we should combine two test cases: first that the same RandomState results in the same models, second that re-fitting model results in different predictions as new seed is sampled at each fit stage.

I now added such a test in https://github.com/microsoft/LightGBM/pull/2904/commits/26eb6e6ef628983df1490d902243d8def39b9f38


Use with Chromatic

Simple description about the feature
Chromatic has a very simple integration with Playwright: https://www.chromatic.com/docs/playwright/
Replace:
import { test, expect } from "@playwright/test";

with:
import { test, expect } from "@chromatic-com/playwright";

Any pointers for where to look in this gem to allow or make this change?
(I think there might be another way using the JS module resolution stuff, but I'm still new to all that...)
Usecase / Motivation
Allows you to use this gem and Chromatic.

Hi, thank you for your suggestion.
playwright-ruby-client is browser-automation tool,
and visual regression testing feature would be provided by a plugin for testing library (rspec-xxxx, minitest-xxxx).

Yes, Chromatic provides visual regression testing, and does so as a plugin/testing library, by replacing the "@playwright/test" with "@chromatic-com/playwright". Reading Chromatic's docs, it does this because it uses the browser automation to capture HTML as the visual test, rather than a screenshot image.
Let me try a different question: Where does "@playwright/test" get used by this gem? :)

@rangerscience @playwright/test is just a test runner (test framework) like mocha, jest and not a browser-automation library.
This playwright-ruby-client gem provides feature for browser-automation and assertion, however no test runner (framework) features are provided.


chore(main): release 0.4.1

:robot: I have created a release beep boop
0.4.1 (2023-06-26)
Bug Fixes

attempt reconnecting to mqtt after failure (c273c2a)
deps: update rust crate serde_json to 1.0.99 (78ed9be)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/FruitieX/lifx-mqtt/releases/tag/v0.4.1 :sunflower:


Missing requirement?

Recently switched from moto 3.1.14 to 3.1.15.
Now when using the @mock_ssm decorator, I get a ModuleNotFoundError for openapi_spec_validator. Minimum code example :
from moto import mock_ssm

@mock_ssm
def test_ssm():
   client = boto3.client('ssm')

Traceback (most recent call last):
File "", line 4, in
def test_ssm():
File "...\lib\site-packages\moto_init_.py", line 30, in f
module = importlib.import_module(module_name, "moto")
File "C:\Python310\lib\importlib_init_.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1050, in gcd_import
File "", line 1027, in find_and_load
File "", line 1006, in find_and_load_unlocked
File "", line 688, in load_unlocked
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "...\lib\site-packages\moto\ssm_init.py", line 1, in
from .models import ssm_backends
File "...\lib\site-packages\moto\ssm\models.py", line 10, in
from moto.ec2 import ec2_backends
File "...\lib\site-packages\moto\ec2_init.py", line 1, in
from .models import ec2_backends
File "...\lib\site-packages\moto\ec2\models_init.py", line 14, in
from .elastic_block_store import EBSBackend
File "...\lib\site-packages\moto\ec2\models\elastic_block_store.py", line 2, in
from moto.kms import kms_backends
File "...\lib\site-packages\moto\kms_init.py", line 1, in
from .models import kms_backends
File "...\lib\site-packages\moto\kms\models.py", line 9, in
from moto.apigateway.exceptions import ValidationException
File "C:\dev\python-venvs\testing-cfct\lib\site-packages\moto\apigateway_init.py", line 1, in
from .models import apigateway_backends
File "...\lib\site-packages\moto\apigateway\models.py", line 9, in
from openapi_spec_validator import validate_spec
ModuleNotFoundError: No module named 'openapi_spec_validator'

Hi @tcmnal, that should be fixed in 3.1.16 - can you confirm that the latest release no longer throws an error?

@bblommers Yes, 3.1.16 is no longer throwing that error. For some reason my build container this morning was pulling 3.1.15 as the latest. Thanks

I am still seeing this when I use @mock_apigateway in 3.1.18
@mock_apigateway
def test_example():
    pass

Traceback:
/usr/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test/test_io_utils.py:65: in <module>
    def test_get_aws_api_key(aws_credentials):
.venv2/lib/python3.9/site-packages/moto/__init__.py:30: in f
    module = importlib.import_module(module_name, "moto")
/usr/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
.venv2/lib/python3.9/site-packages/moto/apigateway/__init__.py:1: in <module>
    from .models import apigateway_backends
.venv2/lib/python3.9/site-packages/moto/apigateway/models.py:9: in <module>
    from openapi_spec_validator import validate_spec
E   ModuleNotFoundError: No module named 'openapi_spec_validator'

Are you specifying the correct services when installing Moto, @prosaicpudding?
I.e.: pip install moto[apigateway]
See http://docs.getmoto.org/en/latest/docs/getting_started.html


Add support for soft signals, e.g. calc

And find them during convert

@coretl @gilesknap do you think we should include all calc records in convert? I think some of them might just be for internal database logic and shouldn't be shown on the UI. Similarly, I think calcouts will mainly be for database logic, but possibly some would be useful on the UI.
Any thoughts on some heuristics we could use to decide what to include? Or, should we stick to having to manually add calc and calcout to the yaml manually?

I think we should use a manual list, but did we talk about capturing all the pvi convert in a yaml file somewhere so @gilesknap can run pvi convert with the same options many times until the yaml becomes a source file?

OK well I have just opened #126 to allow reconvert. So, if there are device.yamls with manually added calc records, reconvert can be run on them to add new PVs without losing the manually added ones.


[Relays] Remove Payload Types Replace with []byte

Summary
Human Summary

Remove all payload types
Use payload []byte in place
Avoid unmarshalling payloads

AI Summary

Summary generated by Reviewpad on 18 Nov 23 22:47 UTC
This pull request includes the following changes:

Changes to the relay_verifier.go file: The VerifyRelayRequest function now checks if the relayRequest.Meta is nil and returns an error with the appropriate message and payload. This ensures that the relay request signature is properly verified.

Addition of a new file called partial.go in the pkg/partials package: This file adds import statements for "encoding/json" and "log". It defines two functions, GetErrorReply and partiallyUnmarshalRequest. The GetErrorReply function generates an error reply in the correct format required by the request type. The partiallyUnmarshalRequest function unmarshals the payload into a partial request that contains only the fields necessary to generate an error response and handle accounting for the request's method.

Modifications to the errors.go file in the pkg/relayer/proxy package: The import statements have been added for cosmossdk.io/errors. The error definitions have been reorganized and formatted.

Addition of a new file called partials_test.go in the pkg/partials package: This file contains test cases for the TestPartials_GetErrorReply function. The test cases cover scenarios for generating an error reply with properly formatted JSON payloads and handling unrecognized payloads.

Addition of new struct implementations in an unspecified file: The struct implementations for partialJSONPayload and partialRESTPayload provide partial representations of different types of request payloads. Both structs include methods to generate an error payload and retrieve the weight of the request's method. These implementations have pending TODOs indicating incomplete implementation.

Dependency changes in an unspecified file: The dependencies on github.com/cosmos/cosmos-proto v1.0.0-beta.2 and google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 have been modified. The specific changes include adding and removing dependencies as direct and indirect dependencies.

Changes to the error_reply.go file in the pkg/relayer/proxy package: The import statement for github.com/pokt-network/poktroll/pkg/partials has been added. The replyWithError function has been modified to accept a byte slice payload and write a JSONRPCResponseError to the writer. The implementation of the replyWithError function has been refactored to use the partials.GetErrorReply function for getting the response byte slice. The relayResponse object now uses the new response byte slice.

Modifications to the openapi.yml file: The title for the service property has been modified in various lines. The purpose of these modifications is to update the description of the service property from "configured for" to "configured" for both the application and the supplier within different paths and definitions.

Removal of code block and logic in an unspecified file: The code block for extracting the supplier's signature from the appGateServer.verifyResponse() function has been removed. The logic for marshaling the relay response payload to bytes has also been removed. Instead, an error is directly returned for an empty relay response signature.

Changes to the relay_builders.go file: The newRelayResponse function now initializes relayResponse.Payload with responseBz directly, instead of unmarshaling it. The function also signs the relay response and adds the signature to the relay response metadata.

Modifications to the server.go file: Import statements, error handling, and logging code have been added or modified. The changes appear to be focused on error handling and logging.

Addition of a new file called errors.go in the pkg/partials package: This file defines a package called partials and imports the cosmossdk.io/errors package. It declares a variable codespace with the value "partial" and defines an error called ErrPartialUnrecognisedRequestFormat using sdkerrors.Register. The error has a codespace value of "partial", error code of 1, and an error message of "unrecognised request format".

Addition of a new file called error_reply.go: This file is added to the package appgateserver. It contains a method called replyWithError which is used to reply with an internal error response related to the appgateserver itself, not the relay request. It takes in a payload, a writer, and an error as parameters. Inside the method, it generates an error reply using the payload and the error, and writes it to the writer. If there is an error in getting the error reply or writing the relay response, error messages are logged.

Modifications to the proto/pocket/service/relay.proto file: The changes include moving the go_package option, adding comments and TODOs for documentation and future improvements, reorganizing the structure of messages and fields, and adding a new field payload in the RelayRequest and RelayResponse messages.

Modifications to the jsonrpc.go file: The changes involve replacing the payload parameter with payloadBz parameter in the handleJSONRPCRelay function signature, removing code that reads the request body bytes and creates the relay request payload, modifying the Payload field of the relayRequest struct to use payloadBz directly, removing the unmarshaling of relayResponse payload to bytes, and modifying the code that writes the relay response payload to use relayResponse.Payload directly.

Changes to an unspecified file: The changes include the addition of code to extract the relay request from the request body, handle any errors, and log debug messages. There are also modifications to the serveHTTP function to accept a relayRequest parameter and pass it to the VerifyRelayRequest function for validation. Additionally, changes are made to retrieve the payload from the relayRequest and use it to build the request sent to the native service. The sendRelayResponse function is also updated to handle the marshaling of the relay response and sending it to the client.

Addition of a new file called interface.go in

Issue

Fixes N/A

Explanation Document
Type of change
Select one or more:

[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

[x] Run all unit tests: make go_develop_and_test
[x] Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

[x] I have tested my changes using the available tooling
[x] I have performed a self-review of my own code
[x] I have commented my code, updated documentation and left TODOs throughout the codebase

@Olshansk @red-0ne I have addressed the comments regarding error reply. This PR is going to have a followup PR that does the following:

Change the naming of the jsonrpc files and structures and references to JSON-RPC specific code to SymmetricProtocol related stuff (as it is now generalised)
Introduce documentation related to the AppGateServer, payloads and rings

And another follow-up PR will include:

REST payload interim unmarshaling
Unit tests for REST payload interim unmarshaling


Do we need to keep the library file in a folder?

Online sources (such as https://packaging.python.org/en/latest/tutorials/packaging-projects/) tell me that when creating a python library, you need to create a folder with the python files you wish to include and an init.py file. However, for a single file this leads to the slightly redundant behavior I noted in this issue https://github.com/ubsuny/23-Homework6G1/issues/17.
My point is, do we need to do the whole folder setup, or are we able to just use a single file in this case?

I don't think it is the necessity but if you want to you can.

What did you choose to do @WildJimmy


The old way of handing paths in settings editor was better, possible to revert?

In 3.0.6 the settings editor offers one line edit to type in a path in addition to a small folder icon on the right which allows you to use the file dialog.
In 3.1 dev this has been replaced with a single button. It does not offer the convenience of editing the path straight into a line edit.
Example: in settings editor File System -> Directories, Text Editor -> External -> exec_path and so on.
The new way is less convenient since there's no easy way to copy paste paths or, as is my case, write them very quickly on the keyboard instead of spending time scrolling through endless number of files.
Unless there's a very good reason for denying the user to type in a path straight up in a line editor, is it possible to revert this?

Actually found an issue with this new path setting widget which is worse than not being able to type in paths manually: you can no longer clear a path once it has been set.
So if I set a custom export template, I can no longer unset it.


update to new last name on contribution list

First Time Specifics

[x] if its your first pull request to Dendron, watch out for the CLA bot that will ask you to agree to Dendron's CLA
[ ] if its your first pull request and you're on our Discord, add your discord handle so that we can award you the horticulturalist role when the PR is merged

Commit

[x] make sure your branch names adhere to our branch style
[ ] make sure the commit message follows Dendron's commit style
[ ] if this pull request is addressing an existing issue, make sure to link this PR to the issue that it is resolving.

NOTE: make sure to read Addressing open issues

Code

[x] code should follow Code Conventions
[x] sticking to existing conventions instead of creating new ones

Tests

[ ] Write Tests
[ ] Confirm existing tests pass
[ ] Confirm manual testing
[ ] Common cases tested
[ ] 1-2 Edge cases tested
[ ] If your tests changes an existing snapshot

[ ] Update the Snapshot

Docs

[ ] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR (NOTE: submit the PR against the dev branch of the dendron-site repo)

[ ] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

This is just a very simple PR to update my name on the contributions list.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @Harshita-mindfire , yes I do. My assumption was, that the README would get automatically updated. Should I do another commit for the README as well? Or should I keep it like that for now?

Hi @Harshita-mindfire , yes I do. My assumption was, that the README would get automatically updated. Should I do another commit for the README as well? Or should I keep it like that for now?

You can update the README in this PR. the allcontributor bot will only push changes when we trigger them with a command.

Thanks for clearing it up, @hikchoi . The PR is finished now, I added an additional commit for the README.


HBASE-27268 In trace log mode, the client does not print callId/startTime and the server does not print receiveTime

HBASE-27268 In trace log mode, the client does not print callId/startTime and the server does not print receiveTime, so fix it.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s
master passed

+1 :green_heart:
compile
3m 22s
master passed

+1 :green_heart:
checkstyle
0m 46s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 23s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
3m  1s
the patch passed

+1 :green_heart:
javac
3m  1s
the patch passed

-0 :warning:
checkstyle
0m 34s
hbase-server: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
8m 57s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

-1 :x:
spotless
0m 18s
patch has 25 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

36m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4710

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 64de71c86615 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 116458ab04

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 54s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 49s
master passed

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
shadedjars
3m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
shadedjars
3m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 20s
hbase-client in the patch passed.

+1 :green_heart:
unit
205m 37s
hbase-server in the patch passed.

231m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4710

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 594c40265102 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 116458ab04

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/1/testReport/

Max. process+thread count
2500 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m  9s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 23s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
shadedjars
3m 46s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 13s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
3m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  0s
hbase-client in the patch passed.

+1 :green_heart:
unit
209m 27s
hbase-server in the patch passed.

234m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4710

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7303b266afca 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 116458ab04

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/1/testReport/

Max. process+thread count
2566 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 23s
master passed

+1 :green_heart:
compile
2m 47s
master passed

+1 :green_heart:
checkstyle
0m 40s
master passed

+1 :green_heart:
spotless
0m 38s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
2m 46s
the patch passed

+1 :green_heart:
javac
2m 46s
the patch passed

+1 :green_heart:
checkstyle
0m 40s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
8m 11s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 36s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  2s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

31m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4710

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux d963c43ffeef 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 116458ab04

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 31s
master passed

+1 :green_heart:
compile
1m  7s
master passed

+1 :green_heart:
shadedjars
3m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
shadedjars
3m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 18s
hbase-client in the patch passed.

+1 :green_heart:
unit
204m 40s
hbase-server in the patch passed.

225m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4710

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b74940b5b206 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 116458ab04

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/testReport/

Max. process+thread count
2355 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 35s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 20s
master passed

+1 :green_heart:
compile
0m 51s
master passed

+1 :green_heart:
shadedjars
4m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 10s
the patch passed

+1 :green_heart:
compile
0m 53s
the patch passed

+1 :green_heart:
javac
0m 53s
the patch passed

+1 :green_heart:
shadedjars
4m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  9s
hbase-client in the patch passed.

-1 :x:
unit
228m 46s
hbase-server in the patch failed.

249m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4710

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 163150b38fd3 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 116458ab04

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/testReport/

Max. process+thread count
3010 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Updating LOIO analysis to include all features spaces

I also add shuffled data to this analysis. Dependent on merging #40 first. After merging #40, I will update visualization

Thanks for the review @MattsonCam - I will go ahead and merge!


Added code examples about showing a pikaday

For now I think a simple source code in readme will do, but I think it is better to have a demo page in long run.

Thank you!


Toggle darkmode

Dark Mode Toggle

[ ] Add dark mode to enable the user to change the theme of the page.

Please, pull down changes from the upstream and fix merge conflicts.

Conflicts resolved


Can we use uuid::Uuid?

Is there any particular reason we have a custom Uuid type instead of just using the one from the uuid crate?

I think we could add uuid as a optional dependency, as postgres does.
https://github.com/sfackler/rust-postgres/blob/master/postgres-shared/Cargo.toml

Making it optional makes it possible to support alternative implementations in future in a backwards compatible way, if such a need ever arises. Also some people prefer libraries with as few dependencies as possible. Making external dependencies like that optional, makes it possible for them to turn them off when they don't need them. Considering that it's trivial to implement it as optional, I don't really see any reason not to. We can activate it by default.


Add style guide

There should be a guide for coding style on the wiki. This style should preferably be enforced in the build, but since that requires a lot of changes in the code, the first step should be to report style violations.

I have added a style guide. Consider it as a work in progress. Please discuss and enhance it.
https://github.com/iipc/openwayback/wiki/Style-guide

I'm OK with the current draft. The only point I'd question is

All classes and methods should have Javadoc comments.

That is a bit on the optimistic side. Perhaps a slightly less ambitious clause would be warranted

All classes must have a Javadoc comment. All public and protected methods should have a Javadoc comment. The use of Javadoc comments for other methods is encouraged, especially if they are more than 5 lines long.

I think these are sensible conventions in the current draft. I also think the more specific clause about Javadoc comments would be helpful to include.

I agree. Document is updated. I also added a line about avoiding the @author tag. I think git blame is a better alternative.


product->entity relation not saved

I've created an extension with one entity and a relation to a product.

When saving the product with a newly assigned entity the relation doesn't show up on the entity edit page under "Associated Products".
When saving the entity with an "Associated Product" the relation show up on the product detail page in the corresponding attribute dropdown.

Anything I'm missing here?

@arosenhagen Please send me the generated extension file at<EMAIL_ADDRESS>THe file should be in var/modulecreator/package and it should be named as your module  Namespace_Module.xml.
This will help me recreate your extension on my side and see what's wrong.
And sorry for the late response. I'm overbooked for now. Will try to answer as fast as I can.

no problem :-) I found the issue by myself.
The thing is, that the generation with UMC doesn't include the logic that properly saves the relationship between product and product-attribute (and vice versa).
Especially public function save{{Entity}}Relation(${{entity}}, $data)was problematic in that the product attribute wasn't set when saving the entity. I solved it by manually call Mage::getSingleton('catalog/product_action')->updateAttributes(...)in this function.


Log warning whenever the cultures are invalid in Request Culture Providers

Address issue #372

@Eilon is it enough to include the CookieCultureProvider only or shall I add the QueryStringCultureProvider?
The current implementation should support both of them, but RouteDataCultureProvider not included because it has it's own assembly
I will finish this by adding some tests, let me know if there's any further comments

This is strange little bit I tried many times in my laptop the test is passed, now why it pass in AppVeyor and not in Travis?!!
@ryanbrandenburg any idea

@ryanbrandenburg @pranavkm could you please review this, and let me why it partially fails, is it fixed after the commit https://github.com/aspnet/Localization/commit/f2b1e355b397d2a33431f8727e95ba492e59f636?!!

@hishamco we're close to completion on our 2.0.0 work. The work item's been triaged for the next milestone. I'll have a look at it and merge it in once our dev branch is open for 2.1.0 work.

Thanks

@ryanbrandenburg can you also take a look?

Doesn't look like CultureInfo.GetCultureInfo throws on xplat. I don't think we can use this that to determine if a culture is valid.

@pranavkm I tried two different ways with no luck, but finally the test is passed with my third attempt 😄

https://github.com/aspnet/Localization/commit/41ae20525f4aa22490ffb435db2c86e2906a39b0 was merged to address the issue. Thanks for your PR @hishamco

@pranavkm  Can I push my unit tests?

Sure, could you redo them on top of dev?


Possible bug when selecting monorepo directory.

I have a monorepo with two packages, lets say package-a and package-b under ./packages.
When connecting the repository in the Amplify console I check the monorepo checkbox and specify packages/package-b as the app directory. However, package-a is connected!
I have an amplify.yml file in the root of my monorepo.
Here it is:
version: 1
applications:
  - appRoot: ./packages/package-a
    env:
    variables:
      key: value
    backend:
      phases:
        build:
          commands:
            - '# Execute Amplify CLI with the helper script'
            - amplifyPush --simple
    frontend:
      phases:
        preBuild:
          commands:
            - yarn install
        build:
          commands:
            - yarn run build
      artifacts:
        baseDirectory: build
        files:
          - '**/*'
      cache:
        paths:
          - node_modules/**/*
      customHeaders:
           - pattern: '**/*'
             headers:
             - key: 'Cache-Control'
               value: 'max-age=86400'
  - appRoot: ./packages/package-b
    env:
    variables:
      key: value
    backend:
      phases:
        build:
          commands:
            - '# Execute Amplify CLI with the helper script'
            - amplifyPush --simple
    frontend:
      phases:
        preBuild:
          commands:
            - yarn install
        build:
          commands:
            - yarn run build
      artifacts:
        baseDirectory: build
        files:
          - '**/*'
      cache:
        paths:
          - node_modules/**/*
      customHeaders:
        - pattern: '**/*'
          headers:
            - key: 'Cache-Control'
              value: 'max-age=86400'

Thanks for the report! We will investigate the issue.

@ernestostifano please refer to https://github.com/aws-amplify/amplify-console/issues/827#issuecomment-707386423. Closing this issue as it is the same as that one. Please respond there.

FYI, we followed these steps and it still doesn't work. Both issues are closed now


Can not get client used for request

Hi
I have implemented a ClientResponseFilter interface to handle a 302(redirection) response and registered it in to RestClientBuilder. I can't get the client, it returns always null.
public class FollowRedirectInterceptor implements ClientResponseFilter
{
@Override
public void filter(ClientRequestContext clientRequestContext, ClientResponseContext clientResponseContext) throws IOException
{
    if (clientResponseContext.getStatusInfo().getFamily().equals(Response.Status.Family.REDIRECTION))
	{
        Client client = clientRequestContext.getClient();
        WebTarget target = client.target(clientResponseContext.getLocation());
        Response response = target.request(clientRequestContext.getMediaType()).method(clientRequestContext.getMethod());

        clientResponseContext.setEntityStream((InputStream) response.getEntity());
        clientResponseContext.setStatusInfo(response.getStatusInfo());
        clientResponseContext.setStatus(response.getStatus());
    }
}

}

thanks for opening the issue here. Can you please provide more information about your project setup and how you MP RestClient looks like?
As this is not 100% related to the post on my blog, I can't guarantee to find time in the next days, so posting it in parallel on StackOverflow might make sense.

closed due to inactivity.

ok

Hey @lulseged, I never heard back from you so that's why I closed the issue. Could you solve this in the meantime?

Hi
I could not solve it. The problem lies on the RestClientBuilder from microprofile. It is my guess. The 1. RestClientBuilder uses a client to call a REST API.
2. REST API respondes with 302 and a location is in the response as the standard says.
3. My filter catches the 302 response and need to use the location in the response to make a new request.
But at this time the RestClient have lost the client that was used in the first request(1).
Client client = clientRequestContext.getClient(); (here client is null).
FollowRedirectInterceptor.java.txt
RestClientBuilder restClientBuilder = RestClientBuilder.newBuilder();
restClientBuilder.register(FollowRedirectInterceptor.class);
I will submit a ticket to MP.


why my request do not return error when no net state.

When no net. Java ports can return error but PHP ports can not return.

Github 不是技术支持论坛，issues 只负责 AFNetworking 本身有关的问题，如果需要使用帮助，请去 StackOverflow 提问。
Github is not a technical support forum. Issues should only be about AFNetworking itself. If you need help about using this library, you can ask a question on StackOverflow.


get a person list in a certain user but not belong to a colletion

I want get a personlist  who belong to a user but are not part of a certain collection.
input parameter should be userid and colletionid
output should be a person list

Taking in Yi's two togehter, we need "getColllectionsByPerson"...
we also need "complement" methods, "getCollectionsPersonNotIn" and "getPersonsNotInCollection". These two
are needed when user is adding/removing people to/from collections or

I'm working on this issue

Done


Title

Changed title on landing page. Updated Package.json to reflect our project name

accidental, sorry


space-age: update cases_test.go

Planet is not defined as a type. Change it to be string.

type Planet string could get defined inside of space-age.go, however it's not immediately clear that we have to do that. Maybe, adding type Planet string to space-age.go, from the beginning? instead?

type Planet string could get defined inside of space-age.go, however it's not immediately clear that we have to do that. Maybe, adding type Planet string to space-age.go, from the beginning? instead?


Type, Architecture and Libraries

Any plan to use LlamaIndex and LLAMA or LangChain with OpenAI api. I prefer open source model. Would be nice to design the architecture. Web app or Desktop app?

my personal preference -- using all open source.
i think people will prefer web app, as downloading something in desktop still feels uncomfortable to a lot of people i guess. But I don't about the cost associated with keeping a web app.

Web App would be the most user-friendly solution. Our goal is to give people a convenient way to access Bangladesh's history. A web app will probably provide the least friction in terms of data access.

There will be some cost to this nonetheless. Hosting on major cloud platforms like AWS, Azure or GCP would be the easiest solution but probably the most expensive as well. We can use hosting services like Netlify or Vercel as well but I am not sure how conveniently or robustly they scale. We'll have to do some options analysis on these stuff.
Let's get together on a meeting and discuss the plan, our team and our technical strengths.

we can call a online meeting. may be on google meeting. I think we should announce it on face book, as not everyone is yet active here.

Sounds good. I guess you can do another call-for-action either through your Facebook post that garnered interests from the community or make a new post. Ask those who are truly interested to spend some time and effort to join this repo. Then we can schedule a Google meet at a time that would be convenient for everyone. Feel free to tag me (Shamir Alavi) in your comment or post. I'll also chime in.
I want to do this seriously as an end-to-end project because I believe it's relevant, timely, and will have a real impact. But if we want to do this seriously, we need to understand how many of us are willing to work on this and what our strengths.and weaknesses are. Usually, everyone will have more interest in doing the interesting parts like RAG, OCR etc. but the tedious and boring parts are the ones that would help us glue it all together as a product. So, we need to build a proper team that can develop, test and deploy your idea as a product.
Let's get people together and start working on it.

I agree with most of the words here. I believe this is so relevant with the current realm in tech field. I can bring a lot of tools to help people out here with opensource models :)


update http to https

update http to https - all doc references and geocode service url
update bintray references
little code refactor in PlacesActivity
update Release.md

The changes in source look good to me. I've made one suggestion to the RELEASE doc, I have one general request and have one general question.
Because this work can be encapsulated into a patch release, would you please update the app version to go along with the release, 1.0.8?

Good catch. Updated App version to 1.0.8

Why does the project configure the GEOCODE_URL in two places? Is there a single configuration file that could house this static URL?

Generally the place for that is in Strings.xml file. But in order to get the values for string resources you would require Context . This project is following MVP pattern and it is not recommended for having Context in the Presenter .
This would required some refactoring of the App to be able to retrieve the String values in the Presenters. Maybe use a repository object ?

Maybe use a repository object ?

I've never head of this technique, what is it? If the level of effort is larger than extra small, I think we should leave the project as-is.


go linter version upgrade 1.42

Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #670
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@mukundansundar please review the change, Thanks!

@tanvigour is there an eta on this?

closing because of #849


Chore upgrade micromatch

Micromatch 4 has been released with a massive reduction in dependencies:
https://github.com/micromatch/micromatch/issues/137
This PR upgrades micromatch as a dependency in fork-ts-checker-webpack-plugin

Cool - looks like the tests fail though?

I'm going to close this PR and create a new one on beta. However, beta has added Node 6 to the testing matrix and micromatch 4 is no longer compatible with node 6.
Per https://github.com/nodejs/release#end-of-life-releases, Node 6, and Node 8 are end-of-life'd.
Could dropping Node 6 (and 8) be a part of the breaking 4.x release ?

I'd be fine with that - very little supports node 6 these days. @piotr-oles would that be fine with you?

My idea for deciding whether we should support given Node.js version is to follow webpack's and TypeScript's support for Node. Currently, the beta branch supports webpack 4 which supports Node.js 6. It's just a plugin for the webpack, so I think it should obey webpack's decision. 😄

Okay - I guess we stay with micromatch as is for now. Sorry @lPadier

would have like to seen a update to use newer micromatch@4 😞
our dep. tree is massive... something i'm trying to reduce/speed up

Feel free to open a PR, things changed in 2 years, and I think we can upgrade to newer version :)

hmm, lol, you don't even depend on micromatch anymore
i'm using a old version of fork-ts-checker-webpack-plugin ^^


Could not load file or assembly 'Azure.Security.KeyVault.Keys, Version=<IP_ADDRESS>'

Issue Description
We are getting this kind of exceptions ""Could not load file or assembly 'Azure.Security.KeyVault.Keys, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=927421***e12e44c8'. Could not find or load a specific file. (0x80131621)" while executing the command "Invoke-Sqlcmd -ConnectionString $connectionString -InputFile $sqlScriptPath"
This issue is happening after the latest version upgrade from version 22.2.0 to 22.3.0
Workaround
As a workaround it was performed the downgrade of the version from 22.3.0 to 22.2.0 everything started to work, the command used was Install-PSResource SqlServer -Version 22.2.0 -TrustRepository -Scope CurrentUser
This was also reported and suggested on here https://github.com/actions/runner-images/issues/10216 and in different issues on this repository.
Additionally
Current library found while installing/importing SqlServer module was this "C:\Modules\az_11.3.1\Az.KeyVault*5.2.0*\Azure.Security.KeyVault.Keys.dll" so it isn't clear about this library version on the exception Version=<IP_ADDRESS>
Would you please help to take a look on this?

I'm seeing the same issue here now.

So are we


[Bug] Neko and MangaDex Read Sync

Device information

Tachiyomi version: <IP_ADDRESS>
Android phone & version: Pocophone F1 (Latest MIUI 11 Stable)

Steps to reproduce

Read any manga, manhua, manhwa

Expected behavior
The things you have read on Neko should sync on MangaDex wherein if you visit your MangaDex account. It will show that the read icon is marked.
Actual behavior
The read icon on MangaDex website doesn't show "read" and you have to manually click the Read icons to ensure to update your reading progress.
Other details
None.

How many reading/rereading follows do you have?

All in all, I have about 100+ on my read list.

oh i read this wrong.  Yea this isnt a bug.  Marking read on dex is not supported at this time


[FLINK-6615][core] simplify FileUtils

What is the purpose of the change
simplify FileUtils
Brief change log
simplify FileUtils
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
none
Documentation
no

Is there any problem with the current implementation?
The current implementation was carefully done to gracefully handle concurrent removals and allow to pick whether to clean directories with or without files.

I was looking into FLINK-6615, and I think 6615 is not a problem due to files may be created concurrently. But I found the current impl of deleteDirectory() to be cumbersome.
The new code also handles concurrent removals well, and I can add back cleanDirectory() though it's not used anywhere yet. I'm happy to keep the original impl if you prefer it. Which version do you like better?

Fair enough. Seems there are tests for the behavior already, so +1 to merge this
Merging...

Actually, going back here. I would like to not merge this after all. The reason being that in my test run, I found that this does not handle concurrent deletes correctly after all:
https://travis-ci.org/StephanEwen/incubator-flink/jobs/287502995

I think here is an interesting example of why I am often hesitant with cleanup refactorings, unless there is a pressing need to clean up.
It is very hard to judge if the cleaned up version is really as robust as the original code. This change looked correct at a first glance, but the concurrency tests caught a subtle difference in some runs.

@StephanEwen Thanks for letting me know. I'll close this PR

@bowenli86 I hope you don't mind that I pushed back a bit. It's my job to be careful about such things...


Problem with uploading application when inputs/outputs are connected

What is the best way to program this board while everything is connected?
Some Reset/boot button procedure? I've tested some stuff, but don't have success

@balouken
Please specifically describe the problem you encountered (serial port output or programming upload error log).


Conda badges

It would be neat to have badges (version, downloads, platforms) for packages available through the conda channels, e.g. bioconda or conda-forge.

Thanks! Seems to be closed via #1001. If there's more to do, please open a new issue.

@paulmelnikow Yes, it's fixed. Thanks!
Do I need to open issue for fixes/updates, or does a PR suffice? (May want to add 2-3 logos for the major channels to be displayed optionally to make platform/downloads badges more informative without becoming a mile wide)

Sometimes it's helpful to open an issue first, since once something is implemented it can be hard to discuss unemotionally. 😁  In general though, there's no need to open an issue first.
In terms of logos, we don't have a great way to optionally display them, though I'm hoping to add a better way in addressing #983. If you want to tackle that I'd be all for it, though I'd want to do that in a way that's global, rather than specific to a badge.


Failed to ensure load balancer - failed to ensure host in pool

Is this a request for help?:
YES
Is this an ISSUE or FEATURE REQUEST? (choose one):
ISSUE
What version of acs-engine?:

Kubernetes v1.8.2
What happened:
A number of services had been deployed (via Helm charts) annotated to provision services as internal load balancers
We then hit a limit of 10 ips - this was increased as a result of azure service request
some time later subsequent deployments are failing to provision with the following error from the service controller  - this is the same for new services and for existing services being re-deployed
Error creating load balancer (will retry): Failed to ensure load balancer for service development/dev-telco-acquisition-telco-acquisition: ensure(development/dev-telco-acquisition-telco-acquisition): lb(dev-kube-sse) - failed to ensure host in pool: "compute.VirtualMachinesClient#Get: Failure responding to request: StatusCode=200 -- Original Error: Error occurred unmarshalling JSON - Error = 'json: cannot unmarshal string into Go struct field VirtualMachineExtensionProperties.settings of type map[string]interface {}' JSON = '{\r\n \"properties\": {\r\n \"vmId\": \"<redacted>,.\",\r\n \"availabilitySet\": {\r\n \"id\": \"/subscriptions/<redacted>/resourceGroups/kube-dev-rg/providers/Microsoft.Compute/availabilitySets/AGENTPRIVATE-AVAILABILITYSET-<redacted>\"\r\n },\r\n \"hardwareProfile\": {\r\n \"vmSize\": \"Standard_D2_v2\"\r\n },\r\n \"storageProfile\": {\r\n \"imageReference\": {\r\n \"publisher\": \"Canonical\",\r\n \"offer\": \"UbuntuServer\",\r\n \"sku\": \"16.04-LTS\",\r\n \"version\": \"16.04.201711072\"\r\n },\r\n \"osDisk\": {\r\n \"osType\": \"Linux\",\r\n \"name\": \"k8s-agentprivate-redacted-2_OsDisk_1_redacted\",\r\n \"createOption\": \"FromImage\",\r\n \"caching\": \"ReadWrite\",\r\n \"managedDisk\": {\r\n \"storageAccountType\": \"Standard_LRS\",\r\n \"id\": \"/subscriptions/<redacted>/resourceGroups/KUBE-DEV-RG/providers/Microsoft.Compute/disks/k8s-agentprivate-27262139-2_OsDisk_1_<redacted>\"\r\n },\r\n \"diskSizeGB\": 30\r\n },\r\n \"dataDisks\": []\r\n },\r\n \"osProfile\": {\r\n \"computerName\": \"k8s-agentprivate-27262139-2\",\r\n \"adminUsername\": \"apiadmin\",\r\n \"customData\": \"I2Nsb3VkLWNvbmZpZwoK - etc etc

What I expected to happen:
An additional front end ip is added to the internal lb
How can I diagnose what is going wrong? - and any ideas on how to resolve?

this turned out to be as a result of an OMS agent vm extension being in a failed state on one of the agent nodes - once this extension was removed the services and internal load balancer configurations were completed successfully


##[error]No ref found for: refs/pull/67/merge

Hello, thanks for this action!  I am trying to use your action to call a build/test workflow on pull requests.  I have workflow A which runs on pull requests and calls your action to trigger workflow B which runs the build and test.  I have tested workflow B using the built in GitHub UI from the actions page.  When I attempt to trigger workflow B using your action in workflow A I get the error:
Workflow id is: 1965986
##[error]No ref found for: refs/pull/67/merge
##[debug]Node Action run completed with exit code 1

I have tried passing in ref: ${{ github.sha }}, ref: ${{ github.ref }}, and omitting ref as arguments to your action. I get the same result in all cases. Any ideas what is happening?
As a final question, I would like to gate my pull request on whether or not the triggered workflow B completes successfully, is that possible?

I found a thread on this here: https://github.com/actions/checkout/issues/61
From that I discovered the secret is to use ${{ github.event.pull_request.head.ref }} as the ref input, I've tested this and it seems to work.
For your second point, I don't think that's going to be possible, the workflow dispatch is asynchronous so there's no way for the calling workflow to know if the target completed successfully or not.
I suggest combining them into a single workflow and using conditions like if: github.event_name == 'push' or other logic, to only run certain steps if the PR completes (and merges into master), for example https://github.com/benc-uk/dapr-store/blob/master/.github/workflows/ci-build.yml

Thanks for the reply.  One the second approach I was thinking something like:

Call the workflow_dispatch to start the new workflow, get back some sort of handle to the new workflow
Create a new status check on the pr that watches for the new workflow to complete using the handle

@dmacusb2
One possibility is to pass the commit sha to your dispatch. Then you can have the action run on the commit.
There are other actions that wait on Commit status. Check out
uses<EMAIL_ADDRESS>So your next step can use that action to wait for the dispatch status to finish.

@dmacusb2 https://github.com/lewagon/wait-on-check-action should work for what you're wanting to do.


feat: support pagination options for listUsers() method

What kind of change does this PR introduce?
Allows you to pass in a params object to listUsers(); to determine paginated results.
What is the current behavior?
listUsers() will only return the first 50 results.
What is the new behavior?
Introduces an options object to listUsers(). The two options are page and per_page. They can be used together or individually. These option names are consistent with the api code found here.
page - which page of paginated results to return
per_page - how many results to return for the page
Example:
const { data, error } = await client.auth.admin.listUsers({ page: '2', per_page: '100' })

Additional context
params option name was based on existing usage like this code.
PageParams type name was based on this code.
Closes https://github.com/supabase/gotrue-js/issues/538.

After some additional digging, I realized that _request has a query option, so we just need to pass params that way.

@j4w8n thanks for taking the time to add this to listUsers!

You're welcome @kangmingtay. The only piece I'm concerned about after your changes is the params definition on line 159 of GoTrueClient.ts. It still states using per_page and strings.
I'm also not familiar with the process of updating the docs since today's launch. I can dig into, but I have zero React experience. Wouldn't need that in place until the gotrue-js version is bumped in supabase-js, but wanted to mention it.

@j4w8n ah yes i missed this, will fix in a FLUP PR. I can handle the update on the docs side as well!


2nd garage door doesn't add correctly

I can't get the 2nd garage door to add as a door, it adds as a switch.
config example:
"garageDoors": [
{
"address": "19 5D E5 1",
"name": "Garage Door",
"timeToOpen": 12000
},
{
"address": "42 07 41",
"Name": "Shed Garage Status",
"timeToOpen": 12000
}
],

I don’t think this plugin is officially supported anymore.   With that said I still use it and mine works.
A quick glance check the address of the second door.  I think you need to have one more digit since the garage door has both a relay and a sensor.
Jeff
Sent from my iPhone
On Feb 4, 2022, at 9:59 AM, lordquazi @.***> wrote:

I can't get the 2nd garage door to add as a door, it adds as a switch.
config example:
"garageDoors": [
{
"address": "19 5D E5 1",
"name": "Garage Door",
"timeToOpen": 12000
},
{
"address": "42 07 41",
"Name": "Shed Garage Status",
"timeToOpen": 12000
}
],
—
Reply to this email directly, view it on GitHubhttps://github.com/rodtoll/homebridge-isy-js/issues/63, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE3OB7VZF6KX3Z3N6SKB3ZTUZPSUHANCNFSM5NSACTGA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Thanks for replying Jeff — and for the idea.  I had a 1 there before and tried removing it.  I’ve put it back and still have the same issue.
Are you running two garage doors successfully?  It seems in the logs that it just ignores this door. The only difference between my doors is the IO Link is a newer version on the one that doesn’t work.
I’ll double check my ISY994i config for it, but I’m sure they are the same.
Have a nice weekend,
Derek.

On Feb 4, 2022, at 10:12:54, macjeff @.***> wrote:
I don’t think this plugin is officially supported anymore. With that said I still use it and mine works.
A quick glance check the address of the second door. I think you need to have one more digit since the garage door has both a relay and a sensor.
Jeff
Sent from my iPhone
On Feb 4, 2022, at 9:59 AM, lordquazi @.***> wrote:

I can't get the 2nd garage door to add as a door, it adds as a switch.
config example:
"garageDoors": [
{
"address": "19 5D E5 1",
"name": "Garage Door",
"timeToOpen": 12000
},
{
"address": "42 07 41",
"Name": "Shed Garage Status",
"timeToOpen": 12000
}
],
—
Reply to this email directly, view it on GitHubhttps://github.com/rodtoll/homebridge-isy-js/issues/63, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE3OB7VZF6KX3Z3N6SKB3ZTUZPSUHANCNFSM5NSACTGA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
—
Reply to this email directly, view it on GitHub https://github.com/rodtoll/homebridge-isy-js/issues/63#issuecomment-1030077378, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQPXTT4VLO2HUHT3PR64CTUZPUHNANCNFSM5NSACTGA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

My two garage doors work fine. Here is a snip of my config file:
"garageDoors": [
{
"address": "4D 88 8F 1",
"name": "Garage Door One",
"timeToOpen": 12000
},
{
"address": "48 8B 99 1",
"name": "Garage Door Two",
"timeToOpen": 12000
}
],
I also ignore the relay of these doors:
"ignoreDevices": [
{
"description": "Garage Door #1 Relay",
"nameContains": "",
"lastAddressDigit": "",
"address": "4D 88 8F 2"
},
{
"description": "Garage Door #2 Relay",
"nameContains": "",
"lastAddressDigit": "",
"address": "48 8B 99 2"
},
],

Here is my config.   Also I am running Node JS 16.3.2   NPM 8.4   Homebridge 1.4.0  ISY plugin 0.1.9
I have had corruption and had to delete the cached file and setup homekit again.
"garageDoors": [
{
"address": "39 A3 D5 1",
"name": "Garage Door 1",
"timeToOpen": 12000
},
{
"address": "15 16 A5 1",
"name": "Casey's Garage",
"timeToOpen": 12000
},
{
"address": "52 DF 85 1",
"name": "Jeff's Garage",
"timeToOpen": 12000
}

Thanks to both of you for responding — I still can’t get this to work.  I’m chalking it up to the fact that the address has a single digit 7 vs another digit — and the code doesn’t like it.  OR the version of IO Linc that I have.

On Feb 5, 2022, at 10:41:10, Dwight Stanley @.***> wrote:
My two garage doors work fine. Here is a snip of my config file:
"garageDoors": [
{
"address": "4D 88 8F 1",
"name": "Garage Door One",
"timeToOpen": 12000
},
{
"address": "48 8B 99 1",
"name": "Garage Door Two",
"timeToOpen": 12000
}
],
I also ignore the relay of these doors:
"ignoreDevices": [
{
"description": "Garage Door #1 https://github.com/rodtoll/homebridge-isy-js/issues/1 Relay",
"nameContains": "",
"lastAddressDigit": "",
"address": "4D 88 8F 2"
},
{
"description": "Garage Door #2 https://github.com/rodtoll/homebridge-isy-js/issues/2 Relay",
"nameContains": "",
"lastAddressDigit": "",
"address": "48 8B 99 2"
},
],
—
Reply to this email directly, view it on GitHub https://github.com/rodtoll/homebridge-isy-js/issues/63#issuecomment-1030646691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQPXTUCADEAQF4GFH3UN53UZVAJNANCNFSM5NSACTGA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

I am curious what the specs are on your new IOLinc - perhaps the file isydevicetypes.json could be modified to support it?
This is what is in the file right now for IOLinc devices:
{ "type": "<IP_ADDRESS>", "address": "1", "name": "(2450) IOLinc v.36", "deviceType": "DoorWindowSensor", "connectionType": "Insteon Wired", "batteryOperate$
{ "type": "<IP_ADDRESS>", "address": "1", "name": "(2450) IOLinc v.41", "deviceType": "DoorWindowSensor", "connectionType": "Insteon Wired", "batteryOperate$

Ok!!  I have it working.  All I did differently was removing the config for the shed door and adding it back in.  This time I used the name of the sensor vs. The door.  I didn’t think that would work as I didn’t use the same name for my other garage door.
The IO Linc is a 4.1 version, so it should be fine.
Last questions, have you had luck converting devices to switches vs fans?  I have several switches that aren’t dimmers that show up as fans.
Thanks for your ideas, config examples and support.
Derek.

On Feb 6, 2022, at 18:52:41, Dwight Stanley @.***> wrote:
I am curious what the specs are on your new IOLinc - perhaps the file isydevicetypes.json could be modified to support it?
This is what is in the file right now for IOLinc devices:
{ "type": "<IP_ADDRESS>", "address": "1", "name": "(2450) IOLinc v.36", "deviceType": "DoorWindowSensor", "connectionType": "Insteon Wired", "batteryOperate$
{ "type": "<IP_ADDRESS>", "address": "1", "name": "(2450) IOLinc v.41", "deviceType": "DoorWindowSensor", "connectionType": "Insteon Wired", "batteryOperate$
—
Reply to this email directly, view it on GitHub https://github.com/rodtoll/homebridge-isy-js/issues/63#issuecomment-1030943868, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQPXTXDSONEYAX7FXR4JOLUZ4CUTANCNFSM5NSACTGA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

This had happened to me too - I have an older ICON switch that is defined wrong.
There is an error in the isydevicetypes.json file that lists this device as a Fan instead of Light.
In Homebridge - enter the terminal using the upper right dots.
Then enter (or copy paste) the following to get the file open for editing:
nano node_modules/homebridge-isy-js/node_modules/isy-js/isydevicetypes.json
Use arrow keys to find and edit the appropriate line - for me it was this:
{ "type": "<IP_ADDRESS>", "address": "", "name": "(28763B) Icon Relay Switch v.39", "deviceType": "Fan", "connectionType": "Insteon Wired", "batteryOperated": false },
Change "Fan," to "Light,"
CONTROL-O to write out
CONTROL-X to exit
Restart the Homebridge container for the change to take effect. The change will stay in place unless the plugin is reinstaled.
Hope this helps!
Dwight

very helpful Dwight, thank you.  That worked like a charm.

On Feb 7, 2022, at 10:06:08, Dwight Stanley @.***> wrote:
This had happened to me too - I have an older ICON switch that is defined wrong.
There is an error in the isydevicetypes.json file that lists this device as a Fan instead of Light.
In Homebridge - enter the terminal using the upper right dots.
Then enter (or copy paste) the following to get the file open for editing:
nano node_modules/homebridge-isy-js/node_modules/isy-js/isydevicetypes.json
Use arrow keys to find and edit the appropriate line - for me it was this:
{ "type": "<IP_ADDRESS>", "address": "", "name": "(28763B) Icon Relay Switch v.39", "deviceType": "Fan", "connectionType": "Insteon Wired", "batteryOperated": false },
Change "Fan," to "Light,"
CONTROL-O to write out
CONTROL-X to exit
Restart the Homebridge container for the change to take effect. The change will stay in place unless the plugin is reinstaled.
Hope this helps!
Dwight
—
Reply to this email directly, view it on GitHub https://github.com/rodtoll/homebridge-isy-js/issues/63#issuecomment-1031566664, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQPXTXI2PJAK45WB6XFCTDUZ7NWBANCNFSM5NSACTGA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.


The docs do not describe basic commands

The docs are frustrating because they don't mention basic commands like install, etc. They go through:

Installation/uninstallation (fine)
Project info (I don't really care right now, I want to use it)
Coming from rtx (I didn't come from rtx)
Configuration (why would I want to configure it when I barely know what it does?)
CI (I definitely don't want it on CI before first use)
Demo (this has two commands, but in a frustrating unseekable video format)

After installation, I want to know:

How do I search the repositories for a package?
How do I install something globally?
How do I add something to a project?
How do I create a .mise.toml from the cli so I can keep the versions I installed?
How can I install the latest of something but have its version persisted in the .mise.toml?

Please write something up that addresses those use cases, something like "Using Mise". I'd do it myself but I don't know enough, because I always struggle to find the commands.

Valid point.
The "Getting Started" section is mostly about installation. I would probably try to keep it minimal, explaining the basic first steps to use mise addressing most of the questions you mention. The Demo video could also be part of "Getting Started" but is mostly a visual gimmick.
The whole "(Alternative) Installation" section should be split out into its own page which can be referred to from "Getting Started".

I agree, that would be a good way to structure it. From a "getting started" page I expect to see:

The most common installation method (I guess curl | bash, these days), with a link to "other installation options" (which can be to an "Installation" page that can include uninstallation).
Very common use cases (use global, use local, searching for packages, installing uninstalling, basic mise.toml usage, with links to more advanced topics.

Basically, if I haven't used a software for more than a few days, I expect the "getting started" page to be my quick references for the overwhelmingly most common actions. I'm OK to go hunt in the config page for something obscure, but there should be a page with the everyday usage stuff.

@roele if you're up for it, it might be good to walk through the docs together over zoom or something since there's a ton of complications that probably won't seem obvious.
For example, one struggle I've had is whether the docs should use ~/.local/bin/mise or just mise. Depending on how you install the CLI one of those is probably correct and the other won't work. I believe this is explained, but it's a gotcha people run into.

FWIW, just to give a different data point: I've found everything I needed, and more, in the docs.
I think that the main difference is that I come from asdf and rtx, so I already knew the main concepts and the migration docs where super useful and valuable to me.
It may be that now that the tool has matured and you have new comers that are not migrating from asdf (or rtx) the docs need to be restructured a little.
I'd like to take the chance to thank @jdx for a great tool (life improvement over 9000 from asdf) and dedicating a lot of effort to the docs, having personally written docs for some projects I know that it is not an easy task, and having docs in an opensource project it not to take for granted.

I didn't come from rtx and i definitely had trouble grasping what to do. I had some basic ide aof what I could do, since I was already using tools like volta and direnv.  I think what I needed was more of a "cookbook" set of examples for doing common things using a subset of popular plugins. I may not use those plugins, but I could infer a lot from context.

the cli reference should have examples for every command: https://mise.jdx.dev/cli/


Update AutoRest C# version

Update AutoRest C# version

Can one of the admins verify this patch?

This update prevents premature disposal of request content.


hover issue in call to action button #177

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!

Sumarise what this PR fixes: <On hover of the call to action text was shaking so I fixed it by adding the border to the button. On hover, the border was there on the button which was causing the text to move.>
Fixes #: < https://github.com/zero-to-mastery/Keiko-Corp/issues/177 >
Checklist:
(Add an x between the brackets to check the items)

[ x] I have sumarised what this PR fixes above
[x ] I have provided the issue ID/URL above
[x] This PR fixes only the issue mentioned above (create seperate PRs for seperate issues)
[x ] I was the first one to claim the issue or I created the issue

Hey @karkranikhil
This PR has a conflict I am unsure on how to resolve. Any chance you can take a look at this for me please 🙂


prevent reading directories as files when building fs cache #16417

fixes #16417
check to see if path passed into FileSystemInfo._readFileHash is actually a file
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing

Further investigation leads me to conclude that this is not a webpack bug. This is a NodeJS bug, introduced in v23.0.0 & fixed in v23.2.0.
Introduced here:
https://github.com/nodejs/node/pull/54160
Fixed here:
https://github.com/nodejs/node/pull/55527
When calling fs.readFile on a path with a trailing slash("/path/"), it would throw an error & not call the provided callback.
fs.readFile(path[, options], callback)

I probably should have tried LTS node before reporting this bug.

@jeremybobbin yes, known issue, reported by me :smile: Anyway thank you, let's close


UX

Adding more user experience, bu implementing JavaScript.

I assigned you here also Deidre, just to not confused UX (user experience).
here you just continue what you are doing in about, contact and home page as you think it is good.
(Obs! under read me issue it is just about the readme file inside GitHub under the master branch,
which you open it just by click on it than up on the corner you have a small icon like a pen you edit it and
you work with it as HTML file.)
Thank you see you Monday at one o'clock.


Correct for attribute to match id of input

... futhermore add title tooltip with value of property alias like in
Umbraco core.
Fixes issue #313
Archetype is re-using the core property editors and it seems the label doesn't set focus for some properties like numeric, decimal, datepicker and maybe others because of mismatch between value of for-attribute and id-attribute. Furthermore it is important they include the property alias in those values so it set focus on the right input field: http://issues.umbraco.org/issue/U4-7648

Thank you! :+1:


gh/workflows: tune LVH VM params

Successful run - https://github.com/cilium/cilium/actions/runs/3580705455.

Conflicts/regressions prevented automatic backport of this PR. @brb , if you wish this to land in v1.13 please provide the backport.

Never mind, this landed already in RC4. I don't know why the labels indicated it wasn't backported yet. I've updated them.


feat(odap): odap first pr

The first pull request for odap

@jscode017 If you need help with conflict resolution just let me know!

@petermetz thanks for your detailed review. The variables can be camelCase. The standard does not enforce it at this level.
@jscode017 let me know when you will be able to make the requested changes on the docs!

@petermetz thanks for your detailed review. The variables can be camelCase. The standard does not enforce it at this level.
@jscode017 let me know when you will be able to make the requested changes on the docs!

@RafaelAPB No worries!
@jscode017 If you need help with conflict resolution just let me know, happy to help! Either here or via the usual channels including the daily pair programming sessions.

@petermetz thanks for your detailed review. The variables can be camelCase. The standard does not enforce it at this level.
@jscode017 let me know when you will be able to make the requested changes on the docs!

@RafaelAPB I would first try to resolve some code reviews and rebase. Then starts with redrawing the flow chart of odap(I would want to add it in the doc). Then I would do the docs.

@petermetz @RafaelAPB Its weird, the situation remains the same. I would fail at one machine but pass other twos

@RafaelAPB I made a small change to readme
Are there some specific things or directions you would want me to do?

Looks good to me! @jscode017 @petermetz

@petermetz @RafaelAPB Its weird, the situation remains the same. I would fail at one machine but pass other twos

@jscode017 The CI is in a bit of a pickle right now, we are trying to stabilize it as we speak, please hang tight with regards that.

@jscode017 Jason, i've noticed some things: https://github.com/jscode017/cactus/blob/fabric-receipt/packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/common/get-transaction-receipt-by-tx-id.ts#L12 --> this function should be called getTransactionReceiptByTxID because it is generic. On the other hand, https://github.com/jscode017/cactus/blob/fabric-receipt/packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/plugin-ledger-connector-fabric.ts#L1078 this function should be called getTransactionReceiptForLockContractByTxID because it is meant specifically for the functionality of ODAP.
Also, it should be generic enough because there might be different types of receipts.
@petermetz  does this makes sense?

@jscode017 Jason, i've noticed some things: https://github.com/jscode017/cactus/blob/fabric-receipt/packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/common/get-transaction-receipt-by-tx-id.ts#L12 --> this function should be called getTransactionReceiptByTxID because it is generic. On the other hand, https://github.com/jscode017/cactus/blob/fabric-receipt/packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/plugin-ledger-connector-fabric.ts#L1078 this function should be called getTransactionReceiptForLockContractByTxID because it is meant specifically for the functionality of ODAP.
Also, it should be generic enough because there might be different types of receipts.
@petermetz does this makes sense?

@RafaelAPB , I am thinking that is that a way that the function getTransactionReceiptForLockContractByTxID(options)https://github.com/jscode017/cactus/blob/08e7001826d1218827aba3590dc2a3ca29f8bacd/packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/plugin-ledger-connector-fabric.ts#L1087
could be parameterized?
e.g we call a interface here, and pass in the implementation function when we construct fabric connector

@petermetz does this makes sense?

@RafaelAPB Yup, makes sense.

e.g we call a interface here, and pass in the implementation function when we construct fabric connector

@jscode017 When you say "pass in the implementation function" do you literally mean passing in a variable that contains a reference to a function?

@jscode017 Do you need any help completing the PR?

@jscode017 Do you need any help completing the PR?

@RafaelAPB , I think I would first need to complete the dependency: https://github.com/hyperledger/cactus/pull/1302
Could you take a look at my fabric-transact-receipt?
I may need to formalize the receipt as peter suggested.
https://github.com/hyperledger/cactus/pull/1302#discussion_r707644069

@jscode017 Do you need any help completing the PR?

@RafaelAPB , I think I would first need to complete the dependency: #1302
Could you take a look at my fabric-transact-receipt?
I may need to formalize the receipt as peter suggested.
#1302 (comment)

Already commented :)

@CatarinaPedreira The merge conflicts need to be fixed first otherwise it won't give me the option at all unfortunately.

@jscode017 1.0.0-rc.2 just went out so you'll also need to update everything in your package from 1.0.0-rc.1 to 1.0.0-rc.2 accordingly.

sure, I have updated it

@jscode017 1.0.0-rc.2 just went out so you'll also need to update everything in your package from 1.0.0-rc.1 to 1.0.0-rc.2 accordingly.

sure, I have updated it

@jscode017 Thank you! Ping me with the "re-request review" button once all the other stuff is addressed as well (or if you have questions about any of those other comments I made)

@jscode017 1.0.0-rc.2 just went out so you'll also need to update everything in your package from 1.0.0-rc.1 to 1.0.0-rc.2 accordingly.

sure, I have updated it

@jscode017 Thank you! Ping me with the "re-request review" button once all the other stuff is addressed as well (or if you have questions about any of those other comments I made)

@petermetz , Sure. I believe have pushed the re-request review button, thanks.

@CatarinaPedreira Almost ready! :)