runtime/race: update syso files

We need to update syso race files to HEAD.
It will fix #20139.
There is also outstanding netbsd support (https://github.com/golang/go/pull/24322) which requires regeneration of syso files. And PPC support (#23731), not yet ready, but it would be good repair ability to update syso files.
And generally just to have fresh supported code.
Probably also need to add netbsd support to racebuild here:
https://github.com/golang/build/blob/master/cmd/racebuild/racebuild.go
(mostly copy-paste from freebsd I guess).
The last time I checked racebuild it was broken with some error, but now it fails earlier asking for some auth token which I don't have.
@bradfitz @josharian @krytarowski

I'm using a prebuilt toolchain stored in:
http://cdn.netbsd.org/pub/NetBSD/misc/kamil/llvm-clang-compilerrt-lldb-7.0.0beta_2018-02-28.tar.bz2
Generated on NetBSD/8.9.12. It contains the pristine sources from HEAD of Clang, LLVM, LLDB, compiler-rt patched with around 1500 lines of local diffs that is still not cleaned up and upstreamed.
We will need to redo the same for Memory Sanitizer in Go on NetBSD/amd64, as it's already stable enough and works for C and C++ programs.

@ceseo needs to push a change upstream for LLVM on ppc64le for Go. We have some internal users testing it.

@laboger done. It's in revision 330122.

Is there need for changes in NetBSD Go files?

@krytarowski changes are needed in multiple places (e.g. adding support for netbsd to buildgo.sh in llvm repo, to go tool to accept -race flag on netbsd, to racebuild.go to build runtime on netbsd). They probably will be mostly "doing the same as freebsd", but still somebody needs to do them and then do testing.

@dvyukov I'm not sure of the order in which I submit my changes to add support for ppc64le. The code in x/build/cmd/racebuild/racebuild.go expects that the golang race support is there with the -race flag enabled, but it won't build if it doesn't have the syso file.

And I don't know how to run something with gomote to test the change to build the syso file.

@laboger I think it would be a good start to prepare all required changes in a single change (except for racebuild.go because you can't test it and because it's in a different repository).  Then we can figure out how to split them. It will be easier when we can see all required changes.

Last time I was told that someone internal shall add the files, generate -race files etc. I can help to configure a NetBSD VM and instruct to build compiler-rt, is this enough?

We have NetBSD VMs. We just need instructions.
Here are the instructions in x/build/cmd/racebuild for all the other OSes:
https://github.com/golang/build/blob/master/cmd/racebuild/racebuild.go#L62

var platforms = []*Platform{
	&Platform{
		OS:   "netbsd",
		Arch: "amd64",
		Type: "netbsd-amd64-race",
		Script: `#!/usr/bin/env bash
set -e
git clone https://go.googlesource.com/go
git clone http://llvm.org/git/compiler-rt.git
(cd compiler-rt && git checkout $REV)
(cd compiler-rt/lib/tsan/go && CC=clang ./buildgo.sh)
cp compiler-rt/lib/tsan/go/race_netbsd_amd64.syso go/src/runtime/race
(cd go/src && ./race.bash)
			`,

You need to get git, bash and mozilla-rootcerts from pkgsrc/pkgin/pkg_add. For mozilla-rootcerts follow post-installation notes.

Manual build:

feetch pkgsrc into /usr/pkgsrc
cd /usr/pkgsrc/shells/bash && make install
cd /usr/pkgsrc/devel/git-base && make install
cd /usr/pkgsrc/security/mozilla-rootcerts && make install

pkgin

Setup it accordingly to http://pkgin.net/
pkgin install git-base mozilla-rootcerts bash

pkg_add

setup PKG_PATH (environment variable)
pkg_add git-base mozilla-rootcerts bash

In general you need clang to build compiler-rt, it's in pkgsrc under name 'clang'.

A general note, for (ASan/)TSan/MSan there is need to disable ASLR:
sysctl -w security.pax.aslr.enabled=0

@bcmills @FiloSottile, one of you want to work on this?
/cc @andybons

CC @bsiegert

Assigning to @bcmills. Bryan let us know if you have any issue with this :)

@bcmills, note that this bug is about several things:

refresh existing race-enabled ports' syso files from upstream llvm
add linux/ppc64le (https://go-review.googlesource.com/c/go/+/107935)
add netbsd/amd64

Regarding NetBSD, we just tagged 8.0RC1.. please use this version.
http://www.nerv.org/netbsd/?q=id:20180419T155522Z.e759b7514ca9f1cf6bcf3bbc27ea04e91d2ceab9
ISO images are still not published, but images with a little bit older snapshot are already available on:
http://nycdn.netbsd.org/pub/NetBSD-daily/netbsd-8/201804161630Z/images/

MSan has been ported to NetBSD too, but I've not been fiddling with a go variation so far.

@krytarowski, we don't have time to do much NetBSD-specific stuff here. At best we'll run the commands you gave us on our existing NetBSD 8 VM image and if it produces a usable & fully passing object file, we can ship it. But once we hit any problems, we'll need to punt until the next release.

I'll send a CL to update the builders once the binaries for 8.0_RC1 land.

@bsiegert could you install there the mentioned programs as well? bash, clang, git-base ...

It has most of these. See https://github.com/golang/build/blob/master/env/netbsd-amd64/mkvm.py:

bash
curl
git
mozilla-rootcerts
go14
emacs25-nox11
vim
screen

So you would like clang in addition?

Yes.

Just in case, please add cmake too.

@krytarowski Do you have a Gerrit account? Then you could directly comment on the CL.

I was under the impression that someone was going to help with the build of the syso file on ppc64le. I could provide an update to the racebuild.go file to try to make this work, but I have no idea how I would test it.

@laboger, yes, @bcmills will be doing it.

@bsiegert no, I'm not registered.

@laboger

@ceseo needs to push a change upstream for LLVM on ppc64le for Go.

Has this been done? If so, at what LLVM revision?

Yes this has been done. @ceseo noted above:

It's in revision 330122.

I've got everything except for Windows building. Windows appears to be broken since https://reviews.llvm.org/D28596 (12 Jan. 2017).

I hope that NetBSD/amd64 is included in everything!

@krytarowski, well, we're not going to ship anything that we didn't build from source in an automated way. That means no slurping down random pre-built binaries. Is the NetBSD stuff ready to be built from source from a script?

I think it's ready.

syso files are updated. The Windows LLVM is a bit old because that part of the LLVM build is broken on Windows.


[4.0 xpt] Create UI for reservations page

Create the user interface page for displaying reservations with status data
-   To reserve an appointment, the user has to select a date and city (username and selected item are auto-filled).
     Use the design based on the "Book a Vespa test-ride" and add all necessary inputs.
     The user can also access the "Reserve" page from the navigation panel. In that case, only the username is auto-filled.
     When the user clicks the "My reservations" link in the navigation panel they can see a list of their reservations (with information about
     item name, date, and city).
     When the user makes a reservation we should direct them to the reservation page.


Bluescreen: UNEXPECTED_KERNEL_MODE_TRAP

Trying to dump Pillars Of Eternity included in Windows 10 Game Pass always results in a bluescreen UNEXPECTED_KERNEL_MODE_TRAP.
The console window last entry is the expected dump directory (i.e. the console is showing up to this point: https://github.com/Wunkolo/UWPDumper/blob/9fb0a040e674521c1413276bcea6e4e708f34d19/UWPDumper/main.cpp#L87). It is not even listening any file to dump.
If you have the Windows 10 Game Pass subscription for $1 you have access to the game and should be able to repro.

I have attempted to dump this game but have not encountered any similar issues. Do you have another machine you could try to replicate this on?

No, but this is the only game/app where this happens and it happens constantly on this game. So I am able to repro this and provide information is necessary.

have you tried the latest version?


how do i use this for multiple files

Hi,
How can i use this amazing lib to download multiple files at once with multiple progress bars
Thanks

All this does it give you a callback to track progress of an ajax request. So just make multiple ajax requests and show their progress based on the callback you pass in.


Training Brain

Hello.
I am using the brain to perform some data classifications and a doubt arose during the training.
I am performing the data insertion in this way below (as an example), with a loop inserting and each position of the vector a new value.
array.push([{input: { r: 0.03, g: 0.7 }, output: { black: 1 }}]);

Already in the Brain training part, I'm passing the array declared above, according to the code below. Is there a problem with that?
net.train(array, {
                            // Defaults values --> expected validation
      iterations: 20000,    // the maximum times to iterate the training data --> number greater than 0
      errorThresh: 0.005,   // the acceptable error percentage from training data --> number between 0 and 1
      log: false,           // true to use console.log, when a function is supplied it is used --> Either true or a function
      logPeriod: 10,        // iterations between logging out --> number greater than 0
      learningRate: 0.3,    // scales with delta to effect training rate --> number between 0 and 1
      momentum: 0.1,        // scales with next layer's change value --> number between 0 and 1
      callback: null,       // a periodic call back that can be triggered while training --> null or function
      callbackPeriod: 10,   // the number of iterations through the training data between callback calls --> number greater than 0
      timeout: Infinity     // the max number of milliseconds to train for --> number greater than 0
});

If we pass the training values, variable by variable, will we have different results in the neural network?
What does Brain actually do with the training data, when I perform the training using an array with the data or instead of values separately?

At first glance it looks like you are doubling up on arrays from this line:
array.push([{input: { r: 0.03, g: 0.7 }, output: { black: 1 }}]);
Change it to:
array.push({input: { r: 0.03, g: 0.7 }, output: { black: 1 }});


Variables in frontend/.env are not being used for the page title and dashboard logo

Describe the bug
The ODH_LOGO and ODH_PRODUCT_NAME variables defined in frontend/.env are not being used for the webpage title and logo graphic
Steps To Reproduce
Steps to reproduce the behavior:

Modify frontend/.env to use custom values for ODH_LOGO and ODH_PRODUCT_NAME

ODH_LOGO=../images/spark.svg
ODH_PRODUCT_NAME=FOO Product Name

Build a dashboard image and deploy it on OCP
Navigate to the Dashboard route and confirm that the page title and logo have not changed
See error

Expected behavior
The page tile and logo graphic reflect the custom values
Workaround (if any)
Any manual steps that allow you to resolve the issue
Open Data Hub Version
ODH 1.2.0
Dashboard Version
As of commit e4ed515 on main
OpenShift Version
Version #: 4.10
Provider (OpenStack
Additional context
The web page title appears to be defined in frontend/src/index.html

It looks like there are multiple references to ${ODH_PRODUCT_NAME} OpenShift Data Science in files under frontend/src/pages


Bug fixing for Google Commands

Added a refresh command (to speed up ls timings)
Fixed duplication errors in uploading

Pull Request Test Coverage Report for Build 368

0 of 65 (0.0%)  changed or added relevant lines in 5 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.2%) to 62.577%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/parser/GoogleCommandParser.java
0
1
0.0%

src/main/java/seedu/address/logic/commands/google/GoogleCommand.java
0
3
0.0%

src/main/java/seedu/address/logic/commands/google/GoogleRefreshCommand.java
0
11
0.0%

src/main/java/seedu/address/logic/commands/google/GoogleUploadCommand.java
0
14
0.0%

src/main/java/seedu/address/model/google/PhotoHandler.java
0
36
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/model/google/PhotoHandler.java
5
0.0%

Totals

Change from base Build 367:
-1.2%

Covered Lines:
1515

Relevant Lines:
2421

💛  - Coveralls


Unable to predict with bfloat16 model

Can train a bfloat16 model but prediction on either GPU or CPU gives missing kernel op for bfloat16 for 'Rsqrt'. Have you been able to predict using bfloat16 models?
Also, would it be possible to do batch gradient averaging to simulate larger batch size on TPU without requiring more memory?

Yes I've run into that problem with blfoat16 as well. I haven't yet found a satisfying solution, but I think setting the model to float32 during prediction might work. I'll look into it more when I have time.
I'm not sure how tricky that would be to do on TPUs, and currently have no intentions on implementing it I'm afraid.

Thanks. some fantastic work you have done here.


Textfields to customize values in Example project

Created a static UITableView to customize values in example project. @lfarah, please take a look to see if you agree with the implementation. Thanks.

Done.


External SolidJS JSX not transformed

Describe the bug
I've bundled two Solid packages with rollup-preset-solid, with package bar depending on package foo. This allows the packages to specify an exports["."].solid field in the package.json that points to raw JSX that will be imported by SolidJS libraries, resolving a bunch of issues related to SSR and hydration.
Testing foo components within foo works fine with Vitest and Testing Library. However, testing bar components that depend on foo components causes a SyntaxError: Unexpected token '<' which suggests untransformed JSX from foo being passed to the test in bar.
I've inlined the foo dependency in bar's Vitest config, however it does not resolve the JSX transformation issue.
Reproduction
https://github.com/bryanmylee/solid-bundle-vitest
System Info
System:
  OS: macOS 12.6
  CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Memory: 98.11 MB / 16.00 GB
  Shell: 5.8.1 - /bin/zsh
Binaries:
  Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
  Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.0/bin/yarn
  npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm
  Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Browsers:
  Chrome: 105.0.5195.125
  Firefox: 104.0.2
  Safari: 16.0
npmPackages:
  vitest: ^0.23.4 => 0.23.4

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Resolved by https://github.com/bryanmylee/solid-bundle-vitest/pull/1.


Show error when importing cupy.array_api with Python 3.7

This is to avoid this on Py37:
>>> import cupy.array_api
__main__:1: UserWarning: The numpy.array_api submodule is still experimental. See NEP 47.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/maehashi/Development/cupy/cupy/array_api/__init__.py", line 133, in <module>
    from ._creation_functions import (
  File "/home/maehashi/Development/cupy/cupy/array_api/_creation_functions.py", line 43
    /,
    ^
SyntaxError: invalid syntax

Jenkins, test this please.


Help users to make daemon run on startup

The documentation says how to start the daemon but it should also say how to make it actually a daemon/service that runs automatically or give pointers.

Obsolete


Issue 15695: wrong error message in failed conversion from string to int

Link: https://issues.dlang.org/show_bug.cgi?id=15695
The problem is that the parsing code advances the incoming range too eagerly, so that by the time the error message is constructed, the range has already advanced past the invalid character. Rewrote the code to only advance the range after it's sure that the character is valid.
Also, took the opportunity to fix some misleading comments and minor code issues leftover from who knows when.

This looks fine.
However, I ran into problems while testing this, which may or may not be related to the bug and the fix.

With dmd -g -m32 on Windows, this produces a wrong line number for me:
import std.conv;
void main () {auto d = to !(int) ("@");}

The error:
std.conv.ConvException@C:\Tools\dmd\windows\bin\..\..\src\phobos\std\conv.d(2002): Unexpected '@' when converting from type string to type int
----------------
0x004026F1 in pure @safe int std.conv.parse!(int, immutable(char)[]).parse(ref immutable(char)[]) at C:\Tools\dmd\windows\bin\..\..\src\phobos\std\conv.d(2004)
0x004050A4 in pure @safe int std.conv.toImpl!(int, immutable(char)[]).toImpl(immutable(char)[]) at C:\Tools\dmd\windows\bin\..\..\src\phobos\std\conv.d(1723)
0x0040203A in pure @safe int std.conv.to!(int).to!(immutable(char)[]).to(immutable(char)[]) at C:\Tools\dmd\windows\bin\..\..\src\phobos\std\conv.d(299)
0x00402025 in _Dmain
0x00408DCB in D2rt6dmain211_d_run_mainUiPPaPUAAaZiZ6runAllMFZ9__lambda1MFZv
0x00408D8F in void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).runAll()
0x00408C90 in _d_run_main
0x00408A80 in main at C:\programs\stuff\dlang\phobos-4008\test2.d(7)
0x00422331 in mainCRTStartup
0x751833CA in BaseThreadInitThunk
0x77479ED2 in RtlInitializeExceptionChain
0x77479EA5 in RtlInitializeExceptionChain

The test2.d(7) line is obviously wrong, since the file has only two lines.
The reported line is 8 when compiling with -O -g instead of just -g.

With dmd -m64 on Windows, it just refuses to link:
test2.obj : error LNK2019: unresolved external symbol _D3std3utf12UTFException6__ctorMFNaNbNfAyamAyamC6object9ThrowableZC3std3utf12UTFException referenced in function _D3std3utf103__T10decodeImplVbi1VE3std8typecons55__T4FlagVAyaa19_7573655265706c6163656d656e744463686172Z4Flagi0TAyaZ10decodeImplFKAyaKmZ18__T9exceptionTAyaZ9exceptionFNaNbNfAyaAyaZC3std3utf12UTFException
test2.obj : error LNK2019: unresolved external symbol _D3std3utf12UTFException6__ctorMFNaNbNiNfAyaAyamC6object9ThrowableZC3std3utf12UTFException referenced in function _D3std3utf98__T13_utfExceptionVE3std8typecons55__T4FlagVAyaa19_7573655265706c6163656d656e744463686172Z4Flagi0Z13_utfExceptionFNaNfAyawZw
test2.exe : fatal error LNK1120: 2 unresolved externals
--- errorlevel 1120

I'm almost certain the errors you found aren't (directly) related to this PR, but nevertheless, there's a remote possibility that there is a problem somewhere, and the compiler/linker just got confused and delivered seemingly-unrelated error messages.
Unfortunately I don't have a Windows dev box, so I can't debug this... could you try to narrow things down, if possible?

Hmm, looking at the stacktrace again... I'm pretty sure this is an artifact of inaccurate resolution of line numbers in the exception handler. Maybe try something else (unrelated to std.conv) that throws an exception from Phobos, and see if similar problems occur?

Ideally, though, parse should take __FILE__ and __LINE__ as default parameters so that the line number in the exception itself is correctly pointing at the user code, rather than relying on the potentially inaccurate exception handler to figure this out. But I'm a bit afraid to change the function signature here, in case it interacts badly with the insanely huge number of overloads of parse in std.conv.

Ideally, though, parse should take FILE and LINE as default parameters so that the line number in the exception itself is correctly pointing at the user code, rather than relying on the potentially inaccurate exception handler to figure this out. But I'm a bit afraid to change the function signature here, in case it interacts badly with the insanely huge number of overloads of parse in std.conv.

If we went that route, we'd basically be talking about giving every function that isn't nothrow taking the file and line number as default arguments that they  then pass on to anything they call. There's nothing special about parse and line numbers. As nice as it might be for the user to see the line that they called in the exception's message, we need to be  able to rely on stacktraces for the line numbers. It doesn't scale otherwise.

Investigated a bit more.
The first issue (wrong line number with dmd -g -m32) is present both on vanilla 2.070.0 and on master, so at least this isn't related to the fix.
However, with dmd -g -m64, I don't get linker errors on master, and the line number is right there.

The Windows 64-bit linking issue is most likely caused by some other PR (the errors look similar to https://issues.dlang.org/show_bug.cgi?id=15021 in 2.068.1 release which was quickly patched into 2.068.2 because of linking issues).
Can I instruct Digger to bisect over other PRs with this PR added unconditionally?
At least it isn't obvious from the comments in bisect.ini.

In that case, the problem is with wrong line numbers with stacktraces, which is unrelated to this PR. (Of course, there are other issues with stacktraces, such as missing line numbers with inlined functions, etc., but that belongs in another discussion.)

@GassaFM Sorry, I haven't used digger extensively enough to know how to do it.

@quickfur I've managed to crudely utilize Digger by placing std/conv.d from this PR locally along with the test program. That means overwriting all changes from previous PRs to conv.d though.
With such setup, I didn't find a version which compiles with -m64: the most recent ones get the same linking errors, and older ones just randomly break, perhaps because of the method's shortcomings.
I don't see a clear path forward with this. It may depend on my specific setup (VS version, etc.) to be reproduced. Trying to reproduce such an error in e.g. autotester clearly requires a standalone test, not a unittest - otherwise, the required function will likely be instantiated in other places. I see only few standalone tests in druntime, none in dmd or phobos.

Actually, one thought occurs to me: are you doing your Win64 test with phobos from this PR recompiled, or are you just doing git pull and recompiling a test program?
I ask because sometimes during local testing I run dmd -unittest -main std/conv.d -of/tmp/test && /tmp/test as a quick way to check that unittests passed, without needing to run through the entire Phobos test suite which is very slow. Sometimes, there will be linker errors because other parts of std/conv.d may require another Phobos module in order to work, so I have to add that (e.g., std/utf.d) to the compile command to make it work.  Just wondering if you might by chance be having an issue related to this.
Also, what does dmd -v show? Is it picking up the phobos library from the right place, or maybe it's picking up the wrong version of some library and thereby causing linker errors?

Another way, if all else fails, is to copy the Phobos sources (probably just std/conv.d itself is good enough) and running dustmite to minimize the code and figure out what went wrong.

@quickfur Yay, right you are! I didn't issue the proper command to build 64-bit version, so the subsequent process used the older one from PATH. No wonder I was getting linker errors. Sorry! Silly me.
What I do is digger build "master + phobos#4008" or such to access PRs. Now with added --model=64 to Digger, my test program compiles fine with -m64 to dmd. For 64-bit build, the reported line number is correct.
Thank you for the help!

Good to know.
So is this PR good to merge? @jmdavis

LGTM

Auto-merge toggled on

Thanks!

Created a separate issue for wrong line number with 32-bit dmd: https://issues.dlang.org/show_bug.cgi?id=15706
The linking error is not a general issue, but a human error on my side.


Add a performance profile template to define queries

This is used for standard templates such as resource optimization.
Add a resource_optimization_openshift profile

Signed-off-by: Dinakar Guniguntala<EMAIL_ADDRESS>

Merging this into mvp_demo as this has already been discussed


Default for time_precision differs from InfluxDB docs

The InfluxDB 0.9 docs mention that the default for time_precision is nanoseconds, unless specified otherwise. The ruby client defaults to a precision of seconds unless specified explicitly.
The difference in the behavior has caused me quite a headache debugging why my metrics were not showing up when sending nanoseconds without explicitly defining time_precision: 'n' when connecting to influxdb.
Was there a specific reason to choose a different default in the ruby client?

I think the most probable answer is that Ruby time classes are second-based. Plugging a timestamp into Time.at(i) will work without any further modification of the timestamp value.
As far as I can tell, the current default value was introduced in 5bbe96b, maybe @toddboom can shed some light on this?
For now, I'll close this ticket. (FWIW, influxdata/influxdb#6041 will change the default of the server to "an intelligent guess", soon)


migrate views from suggest.js to react

Description
What this PR does. If needed, explain choices you made, complex parts, architectural changes, etc.
Why
Why this PR is needed. Feature, step to something bigger, bug, etc.
Screenshots
For PRs with visual impacts. It's sometimes useful to provide before/after images.

As a general comment, it would be great to decouple the suggest component and item rendering from the code producing the suggestions. Things would be more cleaner and also easier to test in isolation.
I realize now (sorry, a bit late in the refacto…) it should have been the first step, even before diving in the react-ification.

closing this in favor of https://github.com/QwantResearch/erdapfel/pull/583


refactor: update almost all development deps

I only didn't update codeclimate-test-reporter as the gem is
deprecated altogether and I haven't looked into CI pipeline and
understood what's going on.
See: https://github.com/codeclimate/ruby-test-reporter
What was the reason to lift the version constraint on the development
dependencies? Well, there was no version constraint on the runtime
dependencies. I think, a version constraint on the runtime dependencies
would make more sense than on the development dependencies. So I decided
to remove them for the sake of consistency.

By the way, at least webmock must be updated in order to fix one of the Public key pinning tests.


Add the support of RequestStack in the route voter

This adds support of the RequestStack in the RouteVoter. The goal is to get rid of the custom event listener injecting the request in voters in the bundle and to stop accessing the Request as a service in Silex (not done by default though as we don't register the RouteVoter by default currently).
This has a potential to break BC: it means we are always matching against the current request. The bundle current uses the master request when voting.
It also means that you cannot force matching against a custom Request instance rather than the stacked ones (no idea why someone would want this though).
I want to get some feedback about the BC break potential before merging this, which is why it is still marked as WIP. Matching is now done on the master request.

@dbu @lsmith77 are you rendering menus in subrequests in the CMF ? If yes, are you using the RouteVoter to identify the current item ?
Note that I'm not talking about ESI requests here (they are not subrequests but separate master requests)

in the CMF we don't tell people how to do this, the recommended way is just to use knp_menu_render. but people might do sub requests for that, one can never know.
but the current stable release of cmf menu is based on knp menu 1.x. we are working on the cmf menu 2.0 which will use knp menu 2.1 (we need some fixes that are not in 2.0). so now would be a good time to change things.
@WouterJ was mainly working on the upgrade. i would say we just change our voters to use the master request of the stack, which would make more sense anyways. does that make sense to you wouter?
we should add a changelog entry in this PR to warn that setRequest is deprecated and you should inject the RequestStack. will the knp menu bundle get a BC layer for symfony 2.3 to inject the request in the constructor? or do we drop symfony 2.3 support? (imho a viable option, people who don't upgrade their symfony probably don't upgrade the bundle either anyways)

@dbu the bundle already does not use the constructor. It uses a custom listener injecting the request through the setter.
The goal of allowing null in the setter is to allow to rely on the synchronized service feature for Symfony 2.3 (and drop support for 2.1 and 2.2) instead of the custom listener injecting the request.
So I would trigger deprecations in the constructor but not in setRequest (or maybe in setRequest in case the RequestStack class exists, which means a case where they can upgrade).
If we decide to use the master request only, I will need to make a few changes to the setRequest method for that though (and it would still break BC for people injecting the request themselves to do custom things).
Regarding the BC break, I'm thinking that the best solution could be to let the existing Voter untouched (but deprecated) and to create a new voter with the RequestStack (+ Symfony 2.3 BC) behavior. Given that the voter should be moved to the Integration namespace (see #183), it might be a good solution. I will work on it this evening (I have to live in a few minutes and so I cannot do it right now)

okay, that makes sense. i would suggest we build the new voter without BC and without support for symfony 2.3 even and fall back to the old one in sf 2.3.
enjoy your live this afternoon, @stof !

@stof @dbu https://github.com/KnpLabs/KnpMenu/pull/230

i prefer #230 over this PR.

The difference between the new code path and the deprecated one is minimal:

the constructor boilerplate (most of it being related to triggering meaningful deprecation warnings)
a single-statement if/else to initialize the $request variable at the beginning of matchItem. So I'm in favor of using this PR rather than #230 creating a new class duplicating all the logic.


Fix broken link

Fix broken link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65d6412704d0dce6f4bf1a70--harness-developer.netlify.app


Replace or remove the "slave" terminology used in a test data

Is your feature request related to a problem? Please describe.
Replace or remove the non-inclusive terminology from the code base.
Describe the solution you'd like
There is only 1 usage in the code base that can be replaced or removed, which is a test data:
https://github.com/opensearch-project/OpenSearch/blob/15e9f137622d878b79103df8f82d78d782b686a1/modules/mapper-extras/src/test/resources/org/opensearch/index/mapper/metricbeat-6.0.template.json#L4601
Describe alternatives you've considered
None.
Additional context
Related issue #472

I will look into this.

Change merged, backport pending. Leaving this issue open until that is complete.


FEATURE REQUEST : Position of the Search Icon

The ability to position the search icon when visible.  Leading or trailing.

The ability to position the search icon when visible. Leading or trailing.

The package has been updated. You can set the location of the search icon as shown below.
OutlineSearchBar(
  searchButtonPosition: SearchButtonPosition.leading,
  onSearchButtonPressed: (String keyword) {

  },
),


Markdown doesn't handle nested [] inside link dispaly text

Release
Renderer status
Tasks status

Not scheduled
✔ .NET (#2653)✔ Android (#2654)✔ iOS (#2655)✔ TS (#2656)✔ UWP (#2657)
🔄 Shared (#2651)✔ Designer (#2652)

Reported by

Teamwork on 4/9/2019

With markdown links, you're supposed to be able to have a nested [] inside the display text of the link, like seen below
Markdown
[Bug [021356]](https://msn.com): Markdown link parsing

Correct rendering (commonmark renders like this too)

However, on some of our platforms, this doesn't work correctly and is just displayed as raw text...
Incorrect rendering

Card repro payload
{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "TextBlock",
            "text": "Markdown link with [] in display text"
        },
        {
            "type": "TextBlock",
            "text": "[Bug [021356]](https://msn.com): Markdown link parsing"
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.0"
}

(I'll create the sub-issues once ZenHub service is back up... this bug definitely exists in Android, but not TS, but maybe other renderers?)

Auto-generated task status

[ ] Shared
[x] Designer
[x] .NET
[x] Android
[x] iOS
[x] TS
[x] UWP

@RebeccaAnne assigning to you since you are already looking into this..

N/m checked the status of #2651 and noticed @nesalang you have it.. This broader one goes to you as well for tracking.


use defaultChannelSlug in queries and mutations

I want to merge this change because...

Store the channel slug in the storefront
Update queries that require channel slug and pass the value to these queries to get channel’s data.
Update featured products - use products from channel with featured-products slug

Screenshots

Pull Request Checklist

[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[x] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: SALEOR-458 Use Channel SLUG in storefront

⚠ This PR uses temporary non-released SDK version that should not be merged into master - commit 1fb1a01

Waiting for stage server update, then tests should pass

Task linked: SALEOR-1645 Drop deprecated navigation field from shop query


Support for ecs log format

It would be useful if hl had support for logs following the ECS standard:
https://www.elastic.co/guide/en/ecs/8.10/ecs-reference.html
Especially the general log related fields:
https://www.elastic.co/guide/en/ecs/8.10/ecs-log.html
As an example here is log line from a python application using the ecs_logging library (filtered through jq for readability):
{
  "@timestamp": "2023-11-02T08:09:10.423Z",
  "log.level": "info",
  "message": "backup for database bar in foo is already done today",
  "application": "backup-rds",
  "ecs": {
    "version": "1.6.0"
  },
  "language": "python",
  "log": {
    "logger": "__main__",
    "origin": {
      "file": {
        "line": 107,
        "name": "app.py"
      },
      "function": "is_backup_done"
    },
    "original": "backup for database bar in foo is already done today"
  },
  "process": {
    "name": "MainProcess",
    "pid": 1,
    "thread": {
      "id":<PHONE_NUMBER>42144,
      "name": "MainThread"
    }
  }
}

Adding support for log.level is just a matter of adding the field name log.level to fileds.predefined.logger.names in config.yaml. But I have also tried to add caller information, but as far as I can see it is not possible to specify nested fields as predefined fields.
I'm using version 0.20.0-beta.14.9 of hl.

Thank you!


Update ammonite to 2.3.8-54-a1dec1cf

Updates com.lihaoyi:ammonite from 2.3.8-46-37b110d0 to 2.3.8-54-a1dec1cf.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "ammonite" } ]

labels: library-update, semver-pre-release

Superseded by #1232.


Give up on sails-hook-dev

It's been months waiting for a release to include the fix for https://github.com/balderdashy/sails-hook-dev/issues/6.  It's time to give up and move on.

yup :100: %

It's a handy module... I've noticed that there are a lot of these kinds of latent npm publish problems out of the Sails team.

Yeah it's a shame.  If anyone wants to use it of course they can still npm install from github master, but it was the source of a lot of issues within SANE.  If they ever publish a new version, we can put it back in.


Visit pages using PhantomJS directly when writing specs with TeaSpoon - Jasmine

I'm trying to write a Javascript spec for my Rails 3.2 application using Teaspoon (the Jasmine version). I'm trying to write a spec that does something like this
describe("Fun", function() {
    var page = require('webpage').create() //ERROR

    it("should be so much fun", function() {
        page.open('/pageToTest/')
        expect($('#HereIsTheParty')).not.toBe( undefined );
    });
});

However, require('webpage') doesn't run (Error: Module name "system" has not been loaded yet for context) even though the Requirejs gem has been installed and can be accessed from the Chrome console.
My question is, can I easily get require('webpage') to run using Rails or should I be using something else? Is it maybe easier to just use Capybara since so far I've been using
describe "Fun", :type => :feature do
    it "should be so much fun" do
        visit '/pageToTest/'
        expect(page).to have_content 'Success'
    end
end

without any problems. I would however prefer using pure Javascript since in this case it's more convenient. What do you guys think? Thanks!
(Copied my question from stackoverflow.com (http://stackoverflow.com/questions/28968231/visit-pages-using-phantomjs-directly-when-writing-specs-with-teaspoon-jasmine)

Answered on stack overflow. Something like cucumber or capybara+rspec works better for these sorts of things.

so, secretly, you can do this by making an ajax request to your endpoint and inserting that into the fixture element, but this is not advisable.

Sorry for late reply. Thanks for this mate! Didnt really understand what
was going on. I think Ill just stick with Capybara for feature tests.
Best, Ingo
On Wed, Mar 11, 2015 at 4:45 PM, Jeremy Jackson<EMAIL_ADDRESS>wrote:

so, secretly, you can do this by making an ajax request to your endpoint
and inserting that into the fixture element, but this is not advisable.
—
Reply to this email directly or view it on GitHub
https://github.com/modeset/teaspoon/issues/331#issuecomment-78303244.

Yup, no worries.. teaspoon is primarily for unit testing javascript -- with some integration level things by the nature of what javascript usually does and how that intersects with what we typically consider integration tests. It's advisable to do unit tests for javascript, in a scenario that you can run against various browsers potentially (using selenium-webdriver you can accomplish this).
Anyway, javascript unit specs are blazingly fast in comparison to capybara/cucumber/etc and allow you to cover more cases without having to have a unique integration feature for each one, and is just another layer for you to utilize for good coverage and good speed.


Improve performance of native vectorization provider

Optimize I/O by copying into backing buffer of MemorySegment and fixing endianness in place.
Refactor reranking to take array of nodes to rerank, and rerank in native code for dot product/square distance.
Use native code dot product/Euclidean for longer vectors, based on JMH benchmarking.

This PR further exposes the need for a FloatSequence type so that we can use the type system to highlight cases where we're looking at a float vector compared to any in-memory sequence of floats (which may, for example, be composed of floats representing multiple vectors).
This PR does not show any noticeable regressions in native vectorization performance. Performance for in-memory graphs/building PQ is marginally improved in some cases. The major improvement is in on-disk PQ searches that require reranking.
Baseline results prior to the PR
Build M=32 ef=100 in 23.19s with avg degree 32.00 and 0.45 short edges
Uncompressed vectors
  Query (memory) top 100/1 recall 0.9693 in 3.85s after 25,097,256 nodes visited
  Query (disk) top 100/1 recall 0.9693 in 7.74s after 25,097,256 nodes visited
  Query (memory) top 100/2 recall 0.9885 in 7.04s after 42,628,406 nodes visited
  Query (disk) top 100/2 recall 0.9885 in 13.96s after 42,628,406 nodes visited
ProductQuantization(384,256) build in 75.96s,
ProductQuantization(384,256) encoded 99744 vectors [38.03 MB] in 4.59s
  Query top 100/1 recall 0.9123 in 7.01s after 25,284,668 nodes visited
  Query top 100/2 recall 0.9882 in 12.51s after 42,942,174 nodes visited

Results post-PR
Build M=32 ef=100 in 23.71s with avg degree 32.00 and 0.45 short edges
Uncompressed vectors
  Query (memory) top 100/1 recall 0.9692 in 3.81s after 24,601,258 nodes visited
  Query (disk) top 100/1 recall 0.9692 in 7.69s after 24,601,258 nodes visited
  Query (memory) top 100/2 recall 0.9884 in 6.73s after 41,906,890 nodes visited
  Query (disk) top 100/2 recall 0.9884 in 13.53s after 41,906,890 nodes visited
ProductQuantization(384,256) build in 85.57s,
ProductQuantization(384,256) encoded 99744 vectors [38.03 MB] in 3.92s
  Query top 100/1 recall 0.9118 in 4.52s after 24,763,122 nodes visited
  Query top 100/2 recall 0.9883 in 6.69s after 42,198,490 nodes visited

Why is cosine the odd one out?

[end of comments]


there will be makeover of  wallet?

Hi.
Have you planned to update the graphical interface of the wallet?, On the home page has some very nice presentation designs for both desktop and Android but it looks nothing like the current wallet. The current android gui is very seedy I think it would be interesting that they could include TOR in the app and not download an external app.

A new interface is certainly on the list, many more important things are simple ahead of it.
(Multi-Algo Patch, RingCT, any current bugs, ...)

I understand, I suppose that after implementing and fix everything that is missing in the code, they will worry about adapting the interface.
thanks for answering.
I close this :)

Thank you.
I think it would be interesting to implement an official wiki, to know more about the characteristics of the project (how it works) and how to use the qt wallet (private address and public address), this is something new for many people.


unc0ver 3.0.0~b34 failed to extract bootstrap - libssl1.0 conflicts with openssl (<< 1.0.2q)

iOS 12.1, iPhone 6s, unc0ver 3.0.0~b34
Jailbreak fails at "Exploiting 27/38"
The message box says:
Errno: 2
Test: installDebs(debsToInstall, true)
Filename: JailbreakViewController.m
Line: 1650
Function: jailbreak
Description: Failed to extract bootstrap
Log:
[*] STATUS: Exploiting (27/38)
[*] Extracting bootstrap...
[*] runCommandv(374) command: /bin/sh "-c" "/usr/bin/dpkg -s "lzma" 2>/dev/null | grep -i ^Maintainer: | grep -qi "CoolStar""
[*] runCommandv(374) completed with exit status 1
[*] Deb: "lzma" is not by CoolStar
[*] runCommandv(378) command: /bin/sh "-c" "/usr/bin/dpkg -s "dpkg" 2>/dev/null | grep -i ^Status: | grep -q "install ok installed""
[*] runCommandv(378) completed with exit status 0
[*] Deb: "dpkg" is installed
[*] runCommandv(382) command: /bin/sh "-c" "/usr/bin/dpkg -s "dpkg" 2>/dev/null | grep -i ^Maintainer: | grep -qi "CoolStar""
[*] runCommandv(382) completed with exit status 1
[*] Deb: "dpkg" is not by CoolStar
[*] Extracting Cydia...
[*] runCommandv(386) command: /bin/sh "-c" "/usr/bin/dpkg -s "cydia" 2>/dev/null | grep -i ^Status: | grep -q "install ok installed""
[*] runCommandv(386) completed with exit status 0
[*] Deb: "cydia" is installed
[*] runCommandv(390) command: /bin/sh "-c" "/usr/bin/dpkg -s "science.xnu.undecimus.resources" 2>/dev/null | grep -i ^Status: | grep -q "install ok""
[*] runCommandv(390) completed with exit status 1
[*] Deb: "science.xnu.undecimus.resources" is not installed
[*] runCommandv(394) command: /bin/sh "-c" "/usr/bin/dpkg -s "apt7" 2>/dev/null | grep -i ^Status: | grep -q "install ok""
[*] runCommandv(394) completed with exit status 0
[*] Deb: "apt7" is installed
[*] runCommandv(398) command: /bin/sh "-c" "/usr/bin/dpkg --compare-versions $(dpkg-query --showformat='${Version}' --show "apt7") "lt" "1:0""
[*] runCommandv(398) completed with exit status 1
[*] Deb apt7 is not lt 1:0
[*] runCommandv(401) command: /bin/sh "-c" "/usr/bin/dpkg -s "apt7-lib" 2>/dev/null | grep -i ^Status: | grep -q "install ok""
[*] runCommandv(401) completed with exit status 0
[*] Deb: "apt7-lib" is installed
[*] runCommandv(405) command: /bin/sh "-c" "/usr/bin/dpkg --compare-versions $(dpkg-query --showformat='${Version}' --show "apt7-lib") "lt" "1:0""
[*] runCommandv(405) completed with exit status 1
[*] Deb apt7-lib is not lt 1:0
[*] runCommandv(408) command: /bin/sh "-c" "/usr/bin/dpkg -s "apt7-key" 2>/dev/null | grep -i ^Status: | grep -q "install ok""
[*] runCommandv(408) completed with exit status 0
[*] Deb: "apt7-key" is installed
[*] runCommandv(412) command: /bin/sh "-c" "/usr/bin/dpkg --compare-versions $(dpkg-query --showformat='${Version}' --show "apt7-key") "lt" "1:0""
[*] runCommandv(412) completed with exit status 1
[*] Deb apt7-key is not lt 1:0
[*] Installing manually exctracted debs...
[*] runCommandv(415) command: /usr/bin/dpkg "--force-bad-path" "--force-configure-any" "--no-triggers" "--force-depends" "--force-remove-essential" "-i" "/var/containers/Bundle/Application/D34B82E8-19BA-48D1-9395-27968F3170B7/Undecimus.app/apt/mobilesubstrate_0.9.7031_iphoneos-arm.deb" "/var/containers/Bundle/Application/D34B82E8-19BA-48D1-9395-27968F3170B7/Undecimus.app/apt/libssl1.0_1.0.2q-1_iphoneos-arm.deb"
[*] runCommandv(415): (Reading database ... 5108 files and directories currently installed.)
[*] runCommandv(415): Preparing to unpack .../mobilesubstrate_0.9.7031_iphoneos-arm.deb ...
[*] runCommandv(415): Unpacking mobilesubstrate (0.9.7031) over (0.9.7031) ...
[*] runCommandv(415): dpkg: regarding .../libssl1.0_1.0.2q-1_iphoneos-arm.deb containing libssl1.0:
[*] runCommandv(415):  libssl1.0 conflicts with openssl (<< 1.0.2q)
[*] runCommandv(415):   openssl (version 0.9.8zg-13) is present and installed.
[*] runCommandv(415):
[*] runCommandv(415): dpkg: error processing archive /var/containers/Bundle/Application/D34B82E8-19BA-48D1-9395-27968F3170B7/Undecimus.app/apt/libssl1.0_1.0.2q-1_iphoneos-arm.deb (--install):
[*] runCommandv(415):  conflicting packages - not installing libssl1.0
[*] runCommandv(415): Setting up mobilesubstrate (0.9.7031) ...
[*] runCommandv(415): Errors were encountered while processing:
[*] runCommandv(415):  /var/containers/Bundle/Application/D34B82E8-19BA-48D1-9395-27968F3170B7/Undecimus.app/apt/libssl1.0_1.0.2q-1_iphoneos-arm.deb
[*] runCommandv(415) completed with exit status 1
[*] __assert(2:installDebs(debsToInstall, true))@JailbreakViewController.m:1650[jailbreak]

Tried with/without airplane mode, with/without 'Reload System Daemons', makes no difference.
The problem seems to be:

libssl1.0 conflicts with openssl (<< 1.0.2q)
openssl (version 0.9.8zg-13) is present and installed.

https://github.com/pwn20wndstuff/Undecimus/issues/530

I had the same proble on iPhone 6s+ running 12.1.1 b3... I ran restore rootFS got a couple reboots after running Uncover then I reinstalled Cydia..

Duplicate of #530 , so closing.


Flag unused parameters as being unused to silence strict warnings

Turning on strict warnings causes complaints about unused parameters.  Flag those parameters as unused to eliminate those warnings.

Thanks @hughescr.
It looks like Travis is failing, but it's not related to this change. I see a lot of other projects failing on Travis builds due to:
pod setup --silent

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

...always fun times when your build server takes >10 minutes to change directories :)


Connection String for Another Computer

Hi. I currently connect to my Microsoft SQL Server on the local computer that runs the server with a connection string as follows:
(SQLCHAR*)(DSN=JoelDB;UID=myID2;PWD=myPW2;WSID=JE-ACCOUNTS;DATABASE=myDB;)
I'm trying to connect to the server from ANOTHER computer and I already did the instructions above. I can telnet to the IP and port of the server using the other computer. However, I can't access it using that connection string. Can you give any insight on how I can do this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 24e49fc4-1101-0d6f-e16a-52242616287b
Version Independent ID: df5e0042-2137-3309-a957-de5f556f5c84
Content: Lesson 2: Connecting from Another Computer - SQL Server
Content Source: docs/relational-databases/lesson-2-connecting-from-another-computer.md
Product: sql
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@jvorata96  Thank you for the feedback.
What are the setup details you are trying to connect with?
The tutorial referenced is using a SSMS client with the tcp:<computer_name>,49172 connection format.

Hi @jvorata96 ,Thanks for contacting Microsoft!  From my understanding, the issue you're describing seems to be an issue with the product, is that correct? If so, unfortunately, this form of contact is intended explicitly for reporting issues with the documentation, and not for the product. To get further assistance with your issue, we'd recommend engaging the community, or opening a ticket with Microsoft Support. More information can be found here: https://docs.microsoft.com/en-us/sql/sql-server/sql-server-get-help?view=sql-server-2017.
The connection string you're using is a DSN, which means you're using an ODBC connection.
Our apologies that the SQL Docs team was unable to assist you further with your issue, but we appreciate you reaching out. Please let us know if there's anything more we can do for you.
Thanks again and hope you have a wonderful rest of your day!
Masha from SQL Docs team


I can build without error in xcode, but can't build in terminal(occur error)

** BUILD FAILED **
The following build commands failed:
CompileC /Users/~my_project~/ios/build/Build/Intermediates/RCTSettings.build/Debug-iphonesimulator/RCTSettings.build/Objects-normal/x86_64/RCTSettingsManager.o RCTSettingsManager.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
CompileC /Users/~my_project~/ios/build/Build/Intermediates/RCTAnimation.build/Debug-iphonesimulator/RCTAnimation.build/Objects-normal/x86_64/RCTFrameAnimation.o Drivers/RCTFrameAnimation.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
Thanks

@starcraft0429 I have the same error. Are you solved it?

@adrianotadao I didn't fix it.
and never need to fix it.
I think, It must include xcworkspace file so it can be compiled without error.
I am build by using .xcworkspace file
Regards

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.

I am getting a similar error.
ios/build/Build/Intermediates/RCTAnimation.build/Debug-iphonesimulator/RCTAnimation.build/Objects-normal/x86_64/RCTNativeAnimatedModule.o RCTNativeAnimatedModule.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
Any ideas on how to get past this?
"dependencies": {
"@remobile/react-native-splashscreen": "^1.0.7",
"@remobile/react-native-toast": "^1.0.6",
"axios": "^0.16.2",
"babel-preset-es2015": "^6.24.1",
"babel-preset-react": "^6.24.1",
"babel-preset-stage-0": "^6.24.1",
"eslint-config-rallycoding": "^3.2.0",
"firebase": "^4.2.0",
"lodash": "^4.17.4",
"react": "16.0.0-alpha.6",
"react-native": "^0.44.0",
"react-native-swipeable": "^0.6.0",
"react-redux": "^5.0.5",
"react-throttle": "^0.3.0",
"redux": "^3.7.2",
"redux-devtools-extension": "^2.13.2",
"redux-logger": "^3.0.6",
"redux-thunk": "^2.2.0",
"throttle-debounce": "^1.0.1"
},
"devDependencies": {
"babel-preset-react-native": "^2.1.0",
"babel-preset-stage-2": "^6.24.1"
}
}


CLOUDP-244156: Fix the concurrent writes for the ResourceWatcher

All Submissions:
Fix the concurrent writes for the ResourceWatcher

[ ] Have you signed our CLA?
[ ] Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
[ ] Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@igor-karpukhin please let's make sure that the event handlers that also maintain maps are synchronized or guaranteed to be used within the same goroutine only.

I just checked. This map is used to be passed to the Watcher interface. It is used to generate reconciliation requests.


World position coords of an Entity

Thanks for your great work Kevin! Ive enjoyed playing with the lib!
Im struggling to find how to get World coords as shown in  the Debug info.
Ive looked for hours but just can seem to work out where Phoria.Debug get this value from?

The debug information gets the position from
var p = entity.worldposition
ctx.fillText("{x:" + p[0].toFixed(2) + ", y:" + p[1].toFixed(2) + ", z:" + p[2].toFixed(2) + "}", x, textPos); //Thats how it renders them


Use SecureRandom as the Random of SesssionId manager

Describe the feature
While running tests quickly that require a lot of session generation(near a normal use case), we occasionally found that tests failed for no reason. When we looked into it, we found that the reason is that we ran out of entropy for generating session Ids, as we create a quite a few javalin instances. We found that using security.SecureRandom instead of util.Random remedies this, as it uses a wider entropy pool and better hashing and generation policies.
this fix would not effect any APIs, but makes the DX better.
Additional context
More than happy to handle this if we wanna do it

Go ahead :)


Use teensy CLI loader for upload of .hex files on OSX

At present platformIO uses the teensy GUI for the final upload of .hex files.
A more streamlined solution might be the command line loader available at:
https://www.pjrc.com/teensy/loader_cli.html

We use CLI for Linux. Could you provide binaries for Mac OS X? I have discussion with @PaulStoffregen a few month before, he told me that there no support for Mac OS X yet.

Mac support was recently contributed.
https://github.com/PaulStoffregen/teensy_loader_cli/pull/12
You still have the compile the code to get a Mac executable.

I made a binary. I'm afraid I don't have my teensy nearby, but the program seems to work fine.
https://www.dropbox.com/s/l5850ic5umcb862/teensy_loader_cli?dl=0

Thanks @heyer2! tool-teensy package has been updated. Try it:
platformio update

P.S: I retested it with my Teensy 3.1/Mac OS X and it works! :+1:

@PaulStoffregen could we ask you to add link to http://platformio.org on these pages:

https://www.pjrc.com/teensy/gcc.html
https://www.pjrc.com/teensy/loader_cli.html

Thanks a lot!

I can confirm it works on my end too.

@ivankravets
I've added a "PlatformIO Integration" section.
https://www.pjrc.com/teensy/loader_cli.html
Can you recommend text to replace the "TODO" line?

PlatformIO is a cross-platform code builder and the missing library manager (Ready for embedded development, IDE and Continuous Integration).

Install PlatformIO
Print supported Teensy boards

platformio boards teensy

Initialise new project with pre-configured settings for the specified board (for example, Teensy 3.1)

platformio init --board teensy31

Put source code files to newly created src directory, build firmware and upload it

platformio run --target upload

Also, see examples of pre-configured Teensy projects:

HID USB Mouse
Chat Server with built-in library
MBED Blink

Dear @PaulStoffregen,
See my post above https://github.com/platformio/platformio/issues/306#issuecomment-148033650
You can modify it if you want.
Thanks in advance! :+1:  :beers:


Multiple issues when project name includes special symbolds s.a. ":".

Weights and Biases version: 0.8.7
Python version: 3.6.9
Operating System: Ubuntu 18.04

Problem
During my wandb.init(project=<project_name>,...)-call with a project name that includes special characters s.a. ":", I get a wandb.apis.CommError: <Response [400]> error or requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.wandb.ai/graphql without any information on the problem source. In addition, this results in me not being able to delete these projects from my online wandb page. If I try to do that, I get an invalid project id-error, and the project remains.
Temporary Fix
From my side, the fix was very simple: I simply did not use any special characters.
However, I now have multiple dead projects that spam my Project page which I assume can't be removed due to the special character issue.

Hey @Confusezius this is definitely a bug, thanks for reporting.  We'll get a fix out on the server and client in the next week or so.  In the meantime, would you like me to remove the dead projects manually?

Hey @vanpelt thanks for the quick response! Good to hear that it's going to get fixed :). I don't mind the dead projects too much as long as I'll be able to remove them in the near future.
Anyway, keep up the great work! I really enjoy using wandb!

Hey @vanpelt
I think this issue is not yet resolved

CC: @cvphelps

This issue is resolved. We inform the user that there are invalid characters in the names of the project. So i'm closing as done!


[web] Flutter web using WebAssembly (WASM)

Proposal
I spotted several articles about WASM being faster then JS [1, 2]
I see the topic has been touched in this old (closed) issues [3, 4],
these open issues on with the dart team [5, 6, 7]
and this seemingly abandoned discussion on google groups [8];
the question and the implicit proposal is:
why flutter web doesn't use WASM instead of dart2js ?
thank you for your time
(asked also on stack)

Hmm there is some misconception that wasm is a replacement for javascript. As of the time of this comment Wasm does not have the ability to interact with the dom or any other web api's. So wasm is used to do heavy complex computation "on the side" and then return the results to js so it can draw to the canvas etc..
If this were to be implement, the flutter compiler would have split logic and browser api calls. Which for flutter applications there is likely to be more web api calls than complex knowledge. What I could possibly see happening is compiling the recent dart:ffi api to the wasm js api or something like that. But yeah I am unsure of it. It would be nice to see something like this to happen similar to C# Blazor...
But I think wasm isn't really meant for building performant ui's. It's really made for doing heavy computation for canvas rendering and such. So for a flutter project I don't think the performance impacts would pay of...

Hmm there is some misconception that wasm is a replacement for javascript. As of the time of this comment Wasm does not have the ability to interact with the dom or any other web api's. So wasm is used to do heavy complex computation "on the side" and then return the results to js so it can draw to the canvas etc..
If this were to be implement, the flutter compiler would have split logic and browser api calls. Which for flutter applications there is likely to be more web api calls than complex knowledge. What I could possibly see happening is compiling the recent dart:ffi api to the wasm js api or something like that. But yeah I am unsure of it. It would be nice to see something like this to happen similar to C# Blazor...
But I think wasm isn't really meant for building performant ui's. It's really made for doing heavy computation for canvas rendering and such. So for a flutter project I don't think the performance impacts would pay of...
@kaleidawave
thank you for the explanation, if I can use your expertise for one more question:
what about running the flutter rendering with wasm, wouldn't be more preformant?
(the link [5] of the initial post seams to suggest that also running
dart in wasm would give an advantage to sass/css, if I've understood correctly)

Hmm, I am not sure as I don't really use flutter. I guess flutter web basically compiles a flutter app to pwa. If the flutter RenderBox object transpiles to a CanvasRenderingContext2D from the canvas api then any dart logic code used to decide how things are rendered on the RenderObject could be converted to web assembly code for potentially more performance. But the bindings for the RenderBox would still have to be implemented in js. Would have to get ask a maintainer of the Flutter web compile step for clarification on that though.
As for css/styling, wasm has nothing to do that and would not affect it in any way, so I am unsure what they are talking about. I don't know if Flutter web generates css or just implements styles through javascript but wasm wouldn't help as it cannot access web api's (yet?)
If there is considerable demand for Flutter's RenderBox  on the web then I could see a appeal for a wasm build step in the flutter web compiler/transpiler but as of now implementing it would be nonessential.

Relative to this... Emscipten's emcc can compile c to wasm. Emcc has a file system api that adapts many of c's stdlib calls to webassembly, please see https://emscripten.org/docs/api_reference/Filesystem-API.html for use in browser. Example, obscuring filesystem calls as IndexedDB. Is there any chance that a subset of dart-lang c code can be compiled to wasm? ...What I would like to produce is an dart:io library that can be used in the browser. Does anyone think this is possible? I tried looking at it the other day but I am unfamiliar with ninja and how to incorporate emcc. thank

Assuming dart-lang could be compiled to LLVM's bitcode (not AOT or JS) and exported as wasm ... and because SKIA has a wasm implementation (https://skia.org/user/modules/canvaskit) ...couldn't Flutter web exist with only a handful of web API calls?

While we do not yet have a dart2wasm compiler, we have a super-experimental CanvasKit-based compositor (it uses WebGL and WebAssembly). If you like living dangerously, you can enable it by setting the FLUTTER_WEB_USE_SKIA environment variable to true and recompile the app (more info).
@hterkelsen can tell us more about what it can and cannot do today.

This would also work well with this project too. WebAssembly can help in more areas too. With a dart2wa tool we could even use it on the server with wasi.
This would also help make the applications safer and faster.

I'm sure binaryen has been considered during this discussion, but just incase it hasn't and can prove useful for dart2wasm, here's a link

I set the FLUTTER_WEB_USE_SKIA env to true, but nothing changed. @yjbanov
$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel dev, v1.13.0, on Mac OS X 10.14.6 18G95, locale en-NZ)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.5)
[✓] VS Code (version 1.40.2)
[✓] Connected device (3 available)

• No issues found!

compile command
$FLUTTER_WEB_USE_SKIA=true flutter build web --release

FYI @yjbanov I would strongly recommend that FLUTTER_WEB_USE_SKIA is referred to as a dart-define and not referred to as an environment variable in documentation

We don't have any documentation for this. I updated my comment above with the latest info.

I have read that Flutter in iOS emit llvm ir which is then optimized by xcode's compiler. Is it possible to use the llvm ir functionality? Where should I look at if I want to see the llvm ir output component of Flutter SDK? Or is it still based on the dartino version here? https://github.com/dartino/sdk/tree/llvm

Check out Microsoft's .NET to WASM project, Blazor. Will Flutter web move on similar lines one day?

Please note that even though a WASM based rendererer can have performance benefits for various scenarios (such as implementing performant table/tree components etc), it'd also mean Flutter web cannot use any of the existing DOM based js libraries.
At the moment, it is possible to create, modify and pass DOM nodes to existing js libraries from Flutter Web. D3 is one such library. There is a whole category of applications that would benefit enormously from the existing javascript ecosystem such as D3 or browser based code editors such as Ace or Monaco.
Reimplementing these with a WASM based canvas is not realistic.  So as much as I'd like to see Flutter Web support a WASM/WebGL renderer, I think it would be good to keep in mind the cons of this option. Having WASM and DOM both would be great. Mixing these together in the same Flutter Web application would be awesome.

So there's no way of rendering textures in flutter web without WASM? I wanted to play videos from an RTSP camera

@lucaszanella So there's no way of rendering textures in flutter web without WASM?
I'm working on web sport for https://github.com/woodemi/quick-scan-flutter. It works on HtmlElementView with <video> tag.
These repos are quite inspiring as well:

https://github.com/tekartik/app_camera.dart/tree/master/camera_web
https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_web

@secretshardul  Check out Microsoft's .NET to WASM project, Blazor. Will Flutter web move on similar lines one day?

Do you mean CanvasKit? https://medium.com/flutter/flutter-web-support-updates-8b14bfe6a908

compiling dart to js holds back dart-lang features

Official blog post about Dart and WASM: https://medium.com/dartlang/experimenting-with-dart-and-wasm-ef7f1c065577

That article is a good read. It still sounds like a long way to go (years).

This Gentleman is doing something interesting https://dev.to/sunshine-chain/dart-meets-rust-a-match-made-in-heaven-9f5

We also plan to expand Dart's compilation toolchain to support compiling to Wasm, contingent on the timely standardisation of WasmGC.

from 2022 roadmap

Would this implementation make running Python possible in a flutter web app?

@caniko I would assume that it's possible for wasm to interop with each other and for flutter to call wasm functions just like the js bindings toda

The issue is that flutter is compiled so the web-specific bindings have to be in Dart-lang, which is really annoying.

Nice to hear that Flutter will be going the WASM route. Are there any technical deep dive articles indicating the Flutter team's intended approach on this? I meant how is WASM going to be implemented in Flutter web? Like having only the flutter dart code compiled to WebAssembly like JS or having the whole Dart VM compiled to WASM and then execute Flutter's code in an interpreter or JIT (not sure if it is possible to do JIT in WASM), and most importantly how will the transition to WebAssembly affect Flutter web's hot reload capability? It is well understood that it is extremely hard to achieve hot reload in dart compiled to JS since you cannot really get Dart VM's hot reload capability into the JS environment, and JS hot reload need to be done by injecting JS code incrementally transpiled by Dart VM into the browser, so it is hard to achieve, but how will the WebAssembly route affect this landscape? I mean I liked Flutter a lot but considering its rendering architecture and lack of hot reload in web I won't really consider Flutter web for developing gemeral websites currently, it is too far from both the developer experience and user experience of more general frameworks like React and Angular. Using Flutter web in some highly client-sided applications that already had an Flutter mobile application, like games, would be the only use cases I consider Flutter web currently, but the lack of hot reload is still making the development experience difficult. I think if Flutter managed to support hot reload in web then more usecases in web can be considered, for now Flutter web is merely just a way to export an existing mobile app to run in the web.

[...] most importantly how will the transition to WebAssembly affect Flutter web's hot reload capability? It is well understood that it is extremely hard to achieve hot reload in dart compiled to JS since you cannot really get Dart VM's hot reload capability into the JS environment, and JS hot reload need to be done by injecting JS code incrementally transpiled by Dart VM into the browser, so it is hard to achieve, but how will the WebAssembly route affect this landscape? I mean I liked Flutter a lot but considering its rendering architecture and lack of hot reload in web I won't really consider Flutter web for developing gemeral websites currently [...]

I'd go into the hot-reload rabbit hole in this issue, maybe is better to address this in the issue linked below

https://github.com/flutter/flutter/issues/53041

We now have compilation to wasm via flutter build web --wasm in the flutter tool in the master branch. I'm going to go head and close this issue.


[Security] Aspire deployments use a single user assigned managed identity for everything

I'm sure this will come up in the threat model, but we need to change how this works so that the resources only have access to what they need by default. The user will be able to manually provision and managed identities as an override but by default, we'll want identities per containerApp and one for the keyvault.
We also need to review role assignments to make sure they are good usable defaults that are secure.
We also need to document this in detail so that users doing their own security reviews can evaluate the defaults (outside of calling infra synth 😄).

Feedback from security review with Barry/Levi

GA might not be able to use managed identities in a best practices / granular fashion. Create docs detailing any steps users must take if they want to follow best practices re: minimal permissions.

The deployment doc updates are happening as part of https://github.com/dotnet/docs-aspire/issues/548


introDidFinish not called on 2.9.0

Hello,
I think there is an issue with the 2.9.0 version, The delegate method "introDidFinish" is not called anymore.
I worked fine on the 2.8.3 version, it start failing after I upgrade to the 2.9.0 version.
For now I fall back to the 2.8.3 version.
Could you investigate and tell me if I'am wrong.
Thanks !

Hey! In 2.9.0 introDidFinish:wasSkipped: was introduced to provide additional info to delegate: EAIntroView.h#L28

Ok my bad, Thanks for reply so quick !

No problem. First place to look into in similar cases - CHANGELOG.md :)
Looks like we have the same issue in example project. I'll keep this issue open until I update it.

Ok Thank for advices !


Possible issue on windows with wrong environment content

Hi @juftin, thanks for your cool work on hatch-pip-compile.
I just started to migrate some of my hatch projects to hatch + hatch-pip-compile but on Github CI Windows systems I am running into the problem that hatch seems to build different venvs compared to Linux/Macos, most pkgs are missing. Find the details here, especially hatch run pip list command in the Run tests and track coverage step.
I tried already many things like installing hatch with pipx and installing hatch with pip, which leads on Windows to an error
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'c:\\hostedtoolcache\\windows\\python\\3.11.9\\x64\\scripts\\hatch.exe' -> 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pip-uninstall-zc7cmf0j\\hatch.exe'

Find the details here.
Do you have any idea what the problem might be and where to look into? Everything is fine on Linux and MacOS and I am running out of ideas here. Thank you :-)

Dang, that's a tricky one. I will dig into this and see if I can't figure it out (I'll jump into this as soon as I can). The missing dependencies is certainly strange to me. I don't have access to a Windows machine personally, so I'll probably begin by increasing the hatch and hatch-pip-compile verbosity to see if I can't detect an obvious error.

Your project wouldn't be affected since it's not using constraint environments, but I have seen some regression issues on hatch >= 1.10.x. I also wonder what happens if you try to use hatch~=1.9.7.
I'm trying to resolve these issues as fast as I can and get testing for 1.10 and 1.11 (both less than 3 weeks old at this point), but if that resolves your issue it would certainly make a fix more urgent.

Thanks for your quick response. I set hatch to hatch~=1.9.7 but still the same problem occurs. Since @ofek develops on Windows, as far as I know, I would be quite surprised if there are any problems with hatch itself. My guess would be that pip-tools is doing something strange here, why is it trying to uninstall hatch anyway? My interpretation is that somehow it breaks out of the virtualenv created by hatch on Windows, which would at least explain what we are seeing.

Any idea why those errors are shown?

Yes! I do actually know this one, it's related to this: https://github.com/juftin/hatch-pip-compile/issues/46 (it's a non-issue but annoying nonetheless)
Basically the hatch workflow is to install the package first and then the dependencies. This is a little tricky with hatch-pip-compile because when you pip install ultimate-notion it tells pip that pandas~=2.0 is an acceptable requirement so maybe it installs pandas==2.3.0 (let's pretend this is the latest version). Then it moves onto your lockfile which actually says that pandas==2.2.2 should be installed - so it would install pandas twice (and maybe leave behind some undesired dependencies). So instead of doing that I tell hatch-pip-compile to run pip install ultimate-notion --no-deps which results in pip complaining with your attached message, and then follow up with pip install -r lockfile which resolves pip's previous concerns.

Yes! I do actually know this one, it's related to this: https://github.com/juftin/hatch-pip-compile/issues/46 (it's a non-issue but annoying nonetheless)

Thanks, got it. So this is completely intended and you could suppress it by setting stderr to subprocess.DEVNULL?


Update yauzl to latest version

See https://github.com/roblourens/vscode-ripgrep/issues/3#issuecomment-316615610

Fixed in https://github.com/Microsoft/vscode/commit/05fc36e1701d68d2fb50c107aa200428f38a883e


Implementing sending timetout

For some applications sending emails should be done in a timely manner, for instance when sending a validation code by email.
If for some reasons the  sending process is not running mails will remain in the queue until the process() function is called. Which may happen a day later for instance. It would not be practical to send   1 day delayed validation code emails in our case.
I propose, as an  enhancement, to add a public attribute to the class to define a timeout. The sending process shall then  ignore all pending emails where the sentTime is less than now() - timeout

Had added this locally by extending the MailQueue class  :
class MailQueue extends \nterms\mailqueue\MailQueue {

    public $timeout = 86400; // two days

    /**
     * Sends out the messages in email queue and update the database.
     *
     * @return boolean true if all messages are successfully sent out
     */
    public function process() {
        if (Yii::$app->db->getTableSchema($this->table) == null) {
            throw new \yii\base\InvalidConfigException('"' . $this->table . '" not found in database. Make sure the db migration is properly done and the table is created.');
        }

        $success = true;

        $items = Queue::find()->where(
            ['and', ['sent_time' => NULL],
                    ['<', 'attempts', $this->maxAttempts],
                    ['<=', 'time_to_send', date('Y-m-d H:i:s')],
                    ['>', 'time_to_send', date('Y-m-d H:i:s', time()-$this->timeout)],
            ])->orderBy(['created_at' => SORT_ASC])->limit($this->mailsPerRound);
        ...


Deem type-use annotations to be recognized on record-component types.

They are automatically copied everywhere that we'd hope
for.
I can't seem to find any issue discussions of this, but we cover it in
the
Javadoc.

Do you know what the most official place we've said that we're covering only up to Java 11 is? I know it's come up, but if we're just talking about a conflict between the spec and, say, some comments on issues, then that's probably a lesser evil than not mentioning records at all.
I'm also not sure how much else we would need to cover, especially to get only to Java 16 for records (14 if you count previews).
And I guess we've sort of crossed that line already by mentioning annotations inside the instanceof type, which weren't permitted in Java 11.
I think we're both OK with merging this, but if you have thoughts on any of that, we may be able to come up with a better story. Or the story might just remain "We're trying to be pragmatic" :)


injected-ts Constructor in camelcase

I've troubles with injected-ts in my proyecto when I want to deploy on ubuntu server cause you have a an import in ServiceProvider with Camelcase but the file is in lowercase:

tsc show an error when I run the build method
Could u help me with that?

Hi,
I just publish a corrective version for this. (Use at least version 1.1.1)
Tell me if it work for you now.

It works, thank you 😺


Improve loading speed

Not sure how & where, but I hope on a local machine it should be possible to speed it up.
Specifically loading the iFrames faster would be great.

Note that the iframe has to load a ton of code, while in theory it should only be React, the component and its dependencies.
It is probably possible to lazily create a new webpack entry per component?

It is probably possible to lazily create a new webpack entry per component?

Maybe? Haven't even thought about that to be honest, sounds reasonable though…

@jantimon what's your take on this?

We should probably move the iframe component out into a more general one which contains only the essential parts.


OCM-1013 | fix: remove dial issuer url when creating operator roles by prefix

Related issue: https://issues.redhat.com/browse/OCM-1013
What
Removes dial call, trusting OCM registered configuration

/lgtm


update folder to generate arm subscription to subscriptionManagement2 for node.js

Automation for azure-sdk-for-python

Automation for azure-sdk-for-js

Automation for azure-sdk-for-go

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

Automation for azure-sdk-for-node

Can one of the admins verify this patch?

closing in favor of https://github.com/Azure/azure-rest-api-specs/pull/4431


Testing all-contributors bot

@all-contributors please add @adeepak7  for code.

@all-cobtributors bot!

@all-contributors please add @adeepak7 for code.

@all-contributors bot!
@all-contributors please add @adeepak7 for ideas, maintenance and review.
@all-contributors please add @AnujSande for design.

@all-contributors bot!
@all-contributors please add @adeepak7 for ideas, maintenance and review.


Change deactivated notice

This admin notice better reflects what has occurred: some plugins had to be deactivated because their dependencies are now unmet.
The reason being that their dependencies were deleted, which WordPress lists as separate admin notices below.

But it's not necessarily true that the dependency was deleted. What is true is that the dependencies are unmet and the plugin was deactivated.
This might also be more than one plugin from a bulk activation. Also, if using WP-CLI it's likely possible to activate and then the next page load would deactivate. I haven't tested that, but I can visualize it.

But it's not necessarily true that the dependency was deleted. What is true is that the dependencies are unmet and the plugin was deactivated.

Understood. It's currently not possible to attempt to activate a plugin that has unmet dependencies, which is what the current message states:

My suggestion is to simply state that plugins were deactivated:

I thought the wording works for multiple plugins, but also open to suggestions.
I also realise this is quite a minor thing. I'm new around here so do let me know if  PRs are not the right format for this :)

Fixed in https://github.com/WordPress/wp-plugin-dependencies/commit/48ab82f109b63b4b561e2a96243008b5003bd5f3


Topic required on KafkaProducerMessage duplicated in CanProduceMessages

Hi Guys,
From the documentation (here https://github.com/mateusjunges/laravel-kafka#configure-the-message-body) I constructed the following code:
<?php

use Junges\Kafka\Facades\Kafka;
use Junges\Kafka\Message\Message;

$topic = 'testtopic';
$headers = ['example' => 'header'];
$body = ['example' => 'body'];

Kafka::publishOn(config('kafka.brokers'), $topic)
    ->withMessage(new Message(headers: $headers, body: $body))
    ->send();

This errors with TypeError: Junges/Kafka/AbstractMessage::__construct(): Argument #1 ($topicName) not passed as $topicName is a required constructor parameter on \Junges\Kafka\AbstractMessage
I can just add the topicName constructor parameter but it seems a little weird given that the topic is defined in the publishOn method in the previous line. Looking at the implementation of the \Junges\Kafka\Contracts\CanProduceMessages it does not seem to actually use the topicName on the Message interface (for the producers anyway).
Can you clarify:

If I am misunderstanding this library entirely
If the documentation is incorrect
What should be happening here.

Happy to assist with PRs but wanted to ensure I understood the situation.

Hello @thetomcake, first of all, thanks for your feedback on this library.
The topic name on the message is used only if you are using the Kafka::fake() method, to assert the a message was published specifically on the given topic. I agree with you and already fixed it to be passed to the message automatically, so you don't need to repeat the argument just to use it on tests.
About the documentation, i checked it and in fact is is incorrect. Will be fixed as soon as i release the next version (later today or maximun tomorrow morning). Also, the broker parameter on publishOn will be optional, since we can use config files for that.

Hello @thetomcake, first of all, thanks for your feedback on this library. The topic name on the message is used only if you are using the Kafka::fake() method, to assert the a message was published specifically on the given topic. I agree with you and already fixed it to be passed to the message automatically, so you don't need to repeat the argument just to use it on tests. About the documentation, i checked it and in fact is is incorrect. Will be fixed as soon as i release the next version (later today or maximun tomorrow morning). Also, the broker parameter on publishOn will be optional, since we can use config files for that.

No problem @mateusjunges, we're fairly new to Kafka over here, so wanted to make sure I didn't get the complete wrong end of the stick. Glad we could help, we will be using the library in some fairly large apps in the next few weeks so might throw some more PRs your way.
You've answered my issue above, thanks a lot.

Hello @thetomcake, i just released v1.3.0 of this package. Here's the changelog: https://github.com/mateusjunges/laravel-kafka/blob/v1.3.0/CHANGELOG.md


docs(config): Notify that the "coverage" preprocessor uses a deprecat…

…ed version of the coverage tool (Istanbul) and add link to a package with the new version (IstanbulJS)
The current config uses "karma-config" which uses a two years old deprecated version of Istanbul.
This may lead to incorrect coverage and other bugs.
Since there are many ways to configure code coverage, but most of them uses the old Istanbul, this causes confusion.
In order to reduce the confusion, a notice has been added and link to the package which comes in Angular. This package uses the the new & maintained version of IstanbulJS (vs. Istanbul, which is deprecated).
Closes #3204
Check that your description matches the automatic change-log format:
http://karma-runner.github.io/latest/dev/git-commit-msg.html
then delete this reminder.

I have signed

Send a PR to fix the problem.

The negative tone of the description caused me to close it without reading the content, sorry.


Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

:+1:


Page Unresponsive

While copy pasting data of 500 rows and column of 10 , page get unresponsive from chrome browser.

Take a look at your events, do you trigger events?