expected:'"', actual:' ', at offset:61: UnexpectedElasticsearchClientException

NEST/Elasticsearch.Net version:
7.6.1
Elasticsearch version:
7.1
Description of the problem including expected versus actual behavior:
Getting UnexpectedElasticsearchClientException on sequantial requests match_all rests.
expected:'"', actual:'
', at offset:61: UnexpectedElasticsearchClientException
at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters)    at Nest.ElasticClient.SearchAsync[TDocument](ISearchRequest request, CancellationToken ct)    at Nest.ElasticClient.SearchAsync[TDocument](Func2 selector, CancellationToken ct)
at GlobalSearch.Infrastructure.Helpers.DefaultNestSearchExecutor.Search[T](ValueTuple`8 searchParams) in C:_agents\r\r001_work\7\s\src\globalsearch\Infrastructure\Helpers\DefaultNestSearchExecutor.cs:line 49
at GlobalSearch.Services.SearchProcessor.SearchObjectDetails(SearchRequestDto request) in C:_agents\r\r001_work\7\s\src\globalsearch\Services\SearchProcessor.cs:line 46
at GlobalSearch.Handlers.SearchProxyHandler(SearchRequestDto request, ILambdaContext context) in C:_agents\r\r001_work\7\s\src\globalsearch\Handlers.cs:line 26
at lambda_method(Closure , Stream , Stream , LambdaContextInternal )
at Elasticsearch.Net.Utf8Json.JsonReader.ReadStringSegmentRaw()
at Deserialize(Object[] , JsonReader& , IJsonFormatterResolver )
at Elasticsearch.Net.Utf8Json.Resolvers.DynamicMethodAnonymousFormatter1.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver)    at Elasticsearch.Net.Utf8Json.JsonSerializer.Deserialize[T](Byte[] bytes, Int32 offset, IJsonFormatterResolver resolver)    at Elasticsearch.Net.Utf8Json.JsonSerializer.DeserializeAsync[T](Stream stream, IJsonFormatterResolver resolver)    at Elasticsearch.Net.ResponseBuilder.SetBodyAsync[TResponse](ApiCallDetails details, RequestData requestData, Stream responseStream, String mimeType, CancellationToken cancellationToken)    at Elasticsearch.Net.ResponseBuilder.ToResponseAsync[TResponse](RequestData requestData, Exception ex, Nullable1 statusCode, IEnumerable1 warnings, Stream responseStream, String mimeType, CancellationToken cancellationToken)    at Elasticsearch.Net.HttpConnection.RequestAsync[TResponse](RequestData requestData, CancellationToken cancellationToken)    at Elasticsearch.Net.RequestPipeline.CallElasticsearchAsync[TResponse](RequestData requestData, CancellationToken cancellationToken)    at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters)
on match_all request after a sequential set of same requests.
Steps to reproduce:

Start to execute the same heavy requests.
After some time app starts to fire UnexpectedElasticsearchClientException.

Expected behavior
A clear and concise description of what you expected to happen.
Expected not to receive UnexpectedElasticsearchClientException.
Provide ConnectionSettings (if relevant):
Provide DebugInformation (if relevant):

@kabzit13 can you capture the response JSON when this exception is thrown, and add here too please?

@russcam , we are trying to reproduce with debug information. Is that what you need?

Yes please, would like to see the response JSON

@kabzit13 in addition to @russcam's request if you run with:
new ConnectionSettings(...)
	.MemoryStreamFactory(new MemoryStreamFactory())
	...

Can you still reproduce this behaviour?

I have finally was able to reproduce it.
I have to start indexing all lot of data in same time firing request to old indexes.
There is only small set of additional info.
Debug info: # FailureReason: Unrecoverable/Unexpected BadResponse while attempting POST on https://vpc-*****.us-east-1.es.amazonaws.com/lot-index/_search?pretty=true&typed_keys=true
I also noticed that master node not available sometime.

I have 2 nodes in setup and not a dedicated master node.
All this is running on AWS Elasticsearch service, maybe It was worth mentioning from the beginning.

Thanks for the update, @kabzit13.  Do you have the captured response bytes/text/json too?

@russcam
I am getting exception at this moment.
try
{
return await client.SearchAsync(func);
}
catch (UnexpectedElasticsearchClientException e)
{
Console.WriteLine($"[ERROR]. Unexpected error: {e}");
Console.WriteLine($"[ERROR]. Debug info: {e.DebugInformation}");
throw;
}
And from this I have only this log.
[ERROR]. Unexpected error: Elasticsearch.Net.UnexpectedElasticsearchClientException: expected:'"', actual:'
', at offset:61
---> Elasticsearch.Net.Utf8Json.JsonParsingException: expected:'"', actual:'
', at offset:61
at Elasticsearch.Net.Utf8Json.JsonReader.ReadStringSegmentRaw()
at Deserialize(Object[] , JsonReader& , IJsonFormatterResolver )
at Elasticsearch.Net.Utf8Json.Resolvers.DynamicMethodAnonymousFormatter1.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver) at Elasticsearch.Net.Utf8Json.JsonSerializer.Deserialize[T](Byte[] bytes, Int32 offset, IJsonFormatterResolver resolver) at Elasticsearch.Net.Utf8Json.JsonSerializer.DeserializeAsync[T](Stream stream, IJsonFormatterResolver resolver) at Elasticsearch.Net.ResponseBuilder.SetBodyAsync[TResponse](ApiCallDetails details, RequestData requestData, Stream responseStream, String mimeType, CancellationToken cancellationToken) at Elasticsearch.Net.ResponseBuilder.ToResponseAsync[TResponse](RequestData requestData, Exception ex, Nullable1 statusCode, IEnumerable1 warnings, Stream responseStream, String mimeType, CancellationToken cancellationToken) at Elasticsearch.Net.HttpConnection.RequestAsync[TResponse](RequestData requestData, CancellationToken cancellationToken) at Elasticsearch.Net.RequestPipeline.CallElasticsearchAsync[TResponse](RequestData requestData, CancellationToken cancellationToken) at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters)
--- End of inner exception stack trace ---
at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters) at Nest.ElasticClient.SearchAsync[TDocument](ISearchRequest request, CancellationToken ct) at Nest.ElasticClient.SearchAsync[TDocument](Func2 selector, CancellationToken ct)
at GlobalSearch.Infrastructure.Helpers.DefaultNestSearchExecutor.Search[T](ValueTuple`8 searchParams) in C:_agents\r\r001_work\7\s\src\globalsearch\Infrastructure\Helpers\DefaultNestSearchExecutor.cs:line 52
[ERROR]. Debug info: # FailureReason: Unrecoverable/Unexpected BadResponse while attempting POST on https://vpc-****.us-east-1.es.amazonaws.com/lot-index/_search?pretty=true&typed_keys=true

[1] BadResponse: Node: https://vpc-****.us-east-1.es.amazonaws.com/ Exception: JsonParsingException Took: 00:00:04.0384831

Audit exception in step 1 BadResponse:
Elasticsearch.Net.Utf8Json.JsonParsingException: expected:'"', actual:'
', at offset:61
at Elasticsearch.Net.Utf8Json.JsonReader.ReadStringSegmentRaw()
at Deserialize(Object[] , JsonReader& , IJsonFormatterResolver )
at Elasticsearch.Net.Utf8Json.Resolvers.DynamicMethodAnonymousFormatter1.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver) at Elasticsearch.Net.Utf8Json.JsonSerializer.Deserialize[T](Byte[] bytes, Int32 offset, IJsonFormatterResolver resolver) at Elasticsearch.Net.Utf8Json.JsonSerializer.DeserializeAsync[T](Stream stream, IJsonFormatterResolver resolver) at Elasticsearch.Net.ResponseBuilder.SetBodyAsync[TResponse](ApiCallDetails details, RequestData requestData, Stream responseStream, String mimeType, CancellationToken cancellationToken) at Elasticsearch.Net.ResponseBuilder.ToResponseAsync[TResponse](RequestData requestData, Exception ex, Nullable1 statusCode, IEnumerable1 warnings, Stream responseStream, String mimeType, CancellationToken cancellationToken) at Elasticsearch.Net.HttpConnection.RequestAsync[TResponse](RequestData requestData, CancellationToken cancellationToken) at Elasticsearch.Net.RequestPipeline.CallElasticsearchAsync[TResponse](RequestData requestData, CancellationToken cancellationToken) at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters)
Inner Exception: expected:'"', actual:'
', at offset:61
Elasticsearch.Net.Utf8Json.JsonParsingException: expected:'"', actual:'
', at offset:61
at Elasticsearch.Net.Utf8Json.JsonReader.ReadStringSegmentRaw()
at Deserialize(Object[] , JsonReader& , IJsonFormatterResolver )
at Elasticsearch.Net.Utf8Json.Resolvers.DynamicMethodAnonymousFormatter1.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver) at Elasticsearch.Net.Utf8Json.JsonSerializer.Deserialize[T](Byte[] bytes, Int32 offset, IJsonFormatterResolver resolver) at Elasticsearch.Net.Utf8Json.JsonSerializer.DeserializeAsync[T](Stream stream, IJsonFormatterResolver resolver) at Elasticsearch.Net.ResponseBuilder.SetBodyAsync[TResponse](ApiCallDetails details, RequestData requestData, Stream responseStream, String mimeType, CancellationToken cancellationToken) at Elasticsearch.Net.ResponseBuilder.ToResponseAsync[TResponse](RequestData requestData, Exception ex, Nullable1 statusCode, IEnumerable1 warnings, Stream responseStream, String mimeType, CancellationToken cancellationToken) at Elasticsearch.Net.HttpConnection.RequestAsync[TResponse](RequestData requestData, CancellationToken cancellationToken) at Elasticsearch.Net.RequestPipeline.CallElasticsearchAsync[TResponse](RequestData requestData, CancellationToken cancellationToken) at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters)
Exception:
Elasticsearch.Net.UnexpectedElasticsearchClientException: expected:'"', actual:'
', at offset:61
---> Elasticsearch.Net.Utf8Json.JsonParsingException: expected:'"', actual:'
', at offset:61
at Elasticsearch.Net.Utf8Json.JsonReader.ReadStringSegmentRaw()
at Deserialize(Object[] , JsonReader& , IJsonFormatterResolver )
at Elasticsearch.Net.Utf8Json.Resolvers.DynamicMethodAnonymousFormatter1.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver) at Elasticsearch.Net.Utf8Json.JsonSerializer.Deserialize[T](Byte[] bytes, Int32 offset, IJsonFormatterResolver resolver) at Elasticsearch.Net.Utf8Json.JsonSerializer.DeserializeAsync[T](Stream stream, IJsonFormatterResolver resolver) at Elasticsearch.Net.ResponseBuilder.SetBodyAsync[TResponse](ApiCallDetails details, RequestData requestData, Stream responseStream, String mimeType, CancellationToken cancellationToken) at Elasticsearch.Net.ResponseBuilder.ToResponseAsync[TResponse](RequestData requestData, Exception ex, Nullable1 statusCode, IEnumerable1 warnings, Stream responseStream, String mimeType, CancellationToken cancellationToken) at Elasticsearch.Net.HttpConnection.RequestAsync[TResponse](RequestData requestData, CancellationToken cancellationToken) at Elasticsearch.Net.RequestPipeline.CallElasticsearchAsync[TResponse](RequestData requestData, CancellationToken cancellationToken) at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters)
--- End of inner exception stack trace ---
at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters) at Nest.ElasticClient.SearchAsync[TDocument](ISearchRequest request, CancellationToken ct) at Nest.ElasticClient.SearchAsync[TDocument](Func2 selector, CancellationToken ct)
at GlobalSearch.Infrastructure.Helpers.DefaultNestSearchExecutor.Search[T](ValueTuple8 searchParams) in C:\_agents\r\r001\_work\7\s\src\globalsearch\Infrastructure\Helpers\DefaultNestSearchExecutor.cs:line 52 expected:'"', actual:' ', at offset:61: UnexpectedElasticsearchClientException    at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters)
at Nest.ElasticClient.SearchAsync[TDocument](ISearchRequest request, CancellationToken ct)
at Nest.ElasticClient.SearchAsync[TDocument](Func2 selector, CancellationToken ct)    at GlobalSearch.Infrastructure.Helpers.DefaultNestSearchExecutor.Search[T](ValueTuple8 searchParams) in C:_agents\r\r001_work\7\s\src\globalsearch\Infrastructure\Helpers\DefaultNestSearchExecutor.cs:line 52
at GlobalSearch.Services.SearchProcessor.SearchLots(LotSearchRequestDto request) in C:_agents\r\r001_work\7\s\src\globalsearch\Services\SearchProcessor.cs:line 75
at GlobalSearch.Handlers.LotSearchProxyHandler(LotSearchRequestDto request, ILambdaContext context) in C:_agents\r\r001_work\7\s\src\globalsearch\Handlers.cs:line 35
at lambda_method(Closure , Stream , Stream , LambdaContextInternal )
at Elasticsearch.Net.Utf8Json.JsonReader.ReadStringSegmentRaw()
at Deserialize(Object[] , JsonReader& , IJsonFormatterResolver )
at Elasticsearch.Net.Utf8Json.Resolvers.DynamicMethodAnonymousFormatter1.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver)    at Elasticsearch.Net.Utf8Json.JsonSerializer.Deserialize[T](Byte[] bytes, Int32 offset, IJsonFormatterResolver resolver)    at Elasticsearch.Net.Utf8Json.JsonSerializer.DeserializeAsync[T](Stream stream, IJsonFormatterResolver resolver)    at Elasticsearch.Net.ResponseBuilder.SetBodyAsync[TResponse](ApiCallDetails details, RequestData requestData, Stream responseStream, String mimeType, CancellationToken cancellationToken)    at Elasticsearch.Net.ResponseBuilder.ToResponseAsync[TResponse](RequestData requestData, Exception ex, Nullable1 statusCode, IEnumerable1 warnings, Stream responseStream, String mimeType, CancellationToken cancellationToken)    at Elasticsearch.Net.HttpConnection.RequestAsync[TResponse](RequestData requestData, CancellationToken cancellationToken)    at Elasticsearch.Net.RequestPipeline.CallElasticsearchAsync[TResponse](RequestData requestData, CancellationToken cancellationToken)    at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters)
END RequestId: b41630f6-1196-48d6-b9ba-eb65c4d8852c
is there any exact property of exception that you would like to see?
Or maybe you can point me to someplace where I can find how to get this info when I am getting an exception?

is there any exact property of exception that you would like to see?

We really need to be able to see the response bytes/JSON, to understand whether the deserialization is failing due to invalid JSON returned or if it is a legitimate bug in DynamicMethodAnonymousFormatter<T>.Deserialize().
The response bytes/JSON can be captured with a proxy in between the client and Elasticsearch e.g. using something like Fiddler, or should be able to capture them by setting DisableDirectStreaming(), which should then include them in .DebugInformation.

@russcam I have disabled direct streaming,  and all debug info was included in my message before. Unfortunately I am not able to use Fidler, as my code executes on AWS Lambda. But I have found that after I have switched from SearchAsync to sync call this issue stop appearing. And also timeouts starting to appear less often. I will try to get more data, but for now, that is all I got.

All this is running on AWS Elasticsearch service, maybe It was worth mentioning from the beginning.

You are probably getting Elasticsearch engine exception in response body. You should check AWS ES "Error logs" to see what's going on.

I have encountered the same error with NEST and AWS Elasticsearch in application logs.
expected:'"', actual:' ', at offset:61: UnexpectedElasticsearchClientException
Error logs in my case
org.elasticsearch.action.search.SearchPhaseExecutionException: all shards failed 	at org.elasticsearch.action.search.AbstractSearchAsyncAction.onPhaseFailure(AbstractSearchAsyncAction.java:314) [elasticsearch-7.4.2.jar:7.4.2] 	at org.elasticsearch.action.search.AbstractSearchAsyncAction.executeNextPhase(AbstractSearchAsyncAction.java:139) [elasticsearch-7.4.2.jar:7.4.2]
.......
Caused by: org.elasticsearch.ElasticsearchException: Trying to create too many scroll contexts. Must be less than or equal to: [500]. This limit can be set by changing the [search.max_open_scroll_context] setting.

@kabzit13 is this issue happening with AWS Elasticsearch?

Yes, It is.

We have seen issues with AWS Elasticsearch with other official clients (https://github.com/elastic/elasticsearch-js/issues/1088) whereby it appears, under certain conditions, that the response sent back from AWS Elasticsearch is malformed JSON.
My current suspicion is that you're seeing the same issue, but with the .NET client. If you are able to capture the response bytes/JSON, it would be possible to confirm this.

Hi @kabzit13, I wondered if you have had a chance to look at this further? If you're able to capture the response bytes/JSON and share, we'd be able to investigate further.

We were having this issue as well when our cluster health was red. I was not able to get the response from registering to OnRequestCompleted (died before getting there) but the cluster was only returning 5XXs based on the AWS logs. Our problem appears our cluster size being too small. I captured a request via postman and this is the 503 with application/json body (The problem is extremely likely to be the trailing comma). So it's AWS fault but it might be nice to return a more user friendly exception.
{   "message": "No server available to handle the request", }

We were having this issue as well when our cluster health was red. I was not able to get the response from registering to OnRequestCompleted (died before getting there) but the cluster was only returning 5XXs based on the AWS logs. Our problem appears our cluster size being too small. I captured a request via postman and this is the 503 with application/json body (The problem is extremely likely to be the trailing comma). So it's AWS fault but it might be nice to return a more user friendly exception.
{   "message": "No server available to handle the request", }

Hi Everyone,
Faced with the same issue, and unfortunately it's very critical. I'm using client against AWS elastic, so in theory I can collect data you may need for that issue.
Can you please list what data you need, as I can try to reproduce issue locally?

Hi Everyone,
Faced with the same issue, and unfortunately it's very critical. I'm using client against AWS elastic, so in theory I can collect data you may need for that issue.
Can you please list what data you need, as I can try to reproduce issue locally?

Hi @IhnatKlimchuk. Apologies for the delay. This slipped past me. We need to see a full example of the response bytes being returned from the server so that we can identify the root cause. If you're able to capture that, it would be much appreciated.

Hi @IhnatKlimchuk. Apologies for the delay. This slipped past me. We need to see a full example of the response bytes being returned from the server so that we can identify the root cause. If you're able to capture that, it would be much appreciated.

Closing due to age/inactivity. Please let us know if this issue is still a relevant priority for your usage?

Exception:
Elasticsearch.Net.UnexpectedElasticsearchClientException: expected:',', actual:'"application/pdf; version=1.7"', at offset:369

The Response JSON:
{
"took": 3,
"timed_out": false,
"_shards": {
"total": 6,
"successful": 6,
"skipped": 0,
"failed": 0
},
"hits": {
"total": {
"value": 1,
"relation": "eq"
},
"max_score": 1,
"hits": [
{
"_index": "ontall_documents",
"_id": "080cf75e-a269-ab98-9d1b-3a027eae3507",
"_score": 1,
"_source": {
"highlight": [ ],
"attachment": {
"date": "2022-03-08T08:00:18Z",
"content_type": "application/pdf",
"author": "u1",
"format": "application/pdf; version=1.7",
"modified": "2022-03-08T08:00:18Z",
"language": "lt",
"creator_tool": "WPS 文字",
"content": "参考已实施项目工作机制： 1. 双方沟通机制 （1）建立微信或 QQ 群，双方所有参与人员加入。日常沟通、文件资料等在群里共享。 双方主要人员不定期以线上会议方式交流问题和解决方案，并在会后编写会议纪要。会议纪 要上传到群文件。",
"content_length": 129
},
"id": "080cf75e-a269-ab98-9d1b-3a027eae3507",
"title": "测试文档",
"content": "JVBERi0x..."
}
}
]
}
}

We encounter similar issue after we upgrade to ES7, the same request works fine with ES 6
Elasticsearch.Net.UnexpectedElasticsearchClientException: expected:'Number Token', actual:'"-Infinity"', at offset:400
---> Elasticsearch.Net.Utf8Json.JsonParsingException: expected:'Number Token', actual:'"-Infinity"', at offset:400
at Elasticsearch.Net.Utf8Json.JsonReader.ReadDouble()
at Elasticsearch.Net.Utf8Json.Formatters.NullableDoubleFormatter.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver)


feat: Don't request github account email and allow unlinking it on account

Describe the feature you'd like to request
I don't want you to have my github email and I want to unlink my github email from the account.
Describe the solution you'd like to see
Don't ask for user email auth scope for github.
Or allow it to be removed by the user then just ask for an email to use.
Additional information
I use a custom email with all services.
👨👧👦 Contributing

[ ] 🙋♂ Yes, I'd be down to file a PR implementing this feature!

Will be looking into how we can support this. Currently does not appear possible with our auth provider, however we are working with them on a number of email-related behaviors that this could be considered part of.

Still an issue.


Switch back to rsession

[WIP] Better commit message

@ryanlovett ah, it got lost in a rebase. Fixed now!


Gotcha: CloudTrail logging of S3

Object level logging is not on by default.
Need old bucket level logging in, or new (2016-11) policy to log access.

You going to submit a PR on this, @jlevy?


help migrating old style easy_table sort to whatever there is now for Davi

Hello. I have an older code base that used easy_table and there are several custom sorters defined on the columns, which are similar to this:
 sort: (a, b) {
	String v1 = "${(a as Map)["LastName"]}, ${a["FirstName"]}";
	String v2 = "${(b as Map)["LastName"]}, ${b["FirstName"]}";
	if (v1.isEmpty || v2.isEmpty) {
		return 0;
	}
	if (v1.isEmpty) {
		return 0;
	}
	if (v2.isEmpty) {
		return 1;
	}
	return v1.compareTo(v2);
}

What is the equivalent in Davi?

Hi @UNIcodeX !
You can override the dataComparator.
Changing the example:
    _model = DaviModel<Person>(
        rows: rows,
        columns: [
          DaviColumn(name: 'Name', stringValue: (data) => data.name),
          DaviColumn(
              name: 'Age',
              intValue: (data) => data.age,
              dataComparator: (a, b, column) => -1
          )
        ],
        alwaysSorted: true);

This a and b are instance of Person (your data).
A default comparator is created according to the data type you mapped (intValue, stringValue,...)

awesome! thanks.


ignore bots or at least github's official bots

https://github.com/webpack-contrib/json5-loader/pull/41#issuecomment-531198155

@kborchers - is this project still active? If not, I"d like to move moment.js off of it.

@marwahaha My understanding was that a new solution was implemented and projects were being moved over a while ago. @jorydotcom and/or @brianwarner should be able to help provide more info

@PatrickJS - we're working with Tobias to get webpack set up on a new tool, EasyCLA.
@marwahaha - we can get Moment moved over. there's a test repo set up for easycla at https://github.com/openjs-foundation/EasyCLA if you want to check it out. Note that it will require re-signatures but we can get your core contributors onboarded before we turn it on, so they don't have any disruptions.

Jory (@jorydotcom) - jburson at linuxfoundation.org or jorydotcom in the OpenJS slack channel

@marwahaha Can you please find me on the OpenJS Slack and we'll get this taken care of? I'm @Brian Warner.


Primary site: release v0.0.46

Changelog

Added: support for downloading quarantined pending imports. This feature will be enabled through the UI in the near future.

Note: For this to work, deployers will need to double-check permissions on their inbox bucket to make sure that their stream service has access to read from them.

Added: support for retrying quarantined pending imports. This feature will be enabled through the UI in the near future.
Fixed: if the garbage collector cannot delete a temp file, it will log an error instead of aborting.
Fixed: the request ID tag in inbox listener logs now matches the request ID in the foxglove API for pending imports.
Fixed: various corrupt BAG and MCAP errors will now result in the file being quarantined immediately rather than retrying 3 times.

Docs
Description

BeforeAfter

This helm chart doesn't control IAM grants, that's done by the deployer (with terraform or with a mouse and keyboard).
So far we don't plan to make this functionality permanently optional, if we did I'd prefer to make it optional at the control plane level and leave the functionality running in the stream service either way.

I'm going to release this now to get the bug fixes now, and delay documenting these details in release notes until we're aligned.


Bug in the Code

By setting the first and last points in the extremum array to the start and end of the bound, the minimax polynomial will only be produced in cases where the maximum error in this region is the start and end of the bound:

In cases like the one below, the minimax polynomial will not be generated.

Interesting, I will look at this on the weekend. Thank you for bringing this to my attention.


angular2-sematic-ui controls throwing error on angularcli prod build

trying to prod build using ng build --prod command and the build was success. The page was not loaded when i running the application and i got the error"No value accessor for form control with unspecified name attribute".
When i comment out the angular2-sematic-ui controls and the prod build application running and working properly.
If i am using ngDefaultControl option in angular2-sematic-ui controls, the prod build application running and working properly but the  angular2-sematic-ui controls not displayed on UI.
Please help me asap.

Using ng serve is normally? Can you check which control caused this？

ng serve and ng build is working fine.  but not working using ng build --prod.
The controls are lsu-dropdown, lsu-modal, lsu-checkbox, lsu-accordian

Which form are you using? formBuilder or ng model?

ng model.

I'm not sure what's going on with prod build. Can you using formBuilder instead ngModel? I will check this issus.

ok thanks. I will try with formBuilder.

@sudhakar-cloudiq , I have tested it. I found that the error caused by AOT . So you can run ng build -prod --aot=false. It's will working fine. But this also an issue. I will fix it asap.
#12 Support AOT

It works. Thanks a lot @lon-yang.


Addition of PEL message method for dump delete/offload

Addition of PEL message method for dump delete/offload
Adding a createPEL method which will log PEL messages.
This method has PEL severity as Informational by default
unless mentioned otherwise
Change-Id: b4e1622407fa9aa372fe0f20f73509cb376f90c5
Signed-off-by: Swarnendu Roy Chowdhury<EMAIL_ADDRESS>

Can one of the admins verify this patch?

add to approvelist


[Linkwarden] SSO Configuration invalid due to the Schema requiring an array with items of type string

Name and Version
fmjstudios/linkwarden 0.2.0
What architecture are you using?
amd64
What steps will reproduce the bug?

Setup SSO as recommended

linkwarden.auth.sso:
  - provider: "authentik"
    customName: "SSO"
    issuer: "authentik"
    existingSecret: "linkwarden-sso-secret"

Run ´helm template`
Doesn't work due to values.schema.json

Are you using any custom parameters or values?
No response
What is the expected behavior?
No response
What do you see instead?
Unable to create application: application spec for linkwarden is invalid: InvalidSpecError: Unable to generate manifests in linkwarden: rpc error: code = Unknown desc = Manifest generation error (cached): `kustomize build <path to cached source>/linkwarden --enable-helm` failed exit status 1: Error: Error: values don't meet the specifications of the schema(s) in the following chart(s):
linkwarden:
- linkwarden.auth.sso.0: Invalid type. Expected: string, given: object

: unable to run: 'helm template linkwarden <path to cached source>/linkwarden/charts/linkwarden-0.2.0/linkwarden --namespace linkwarden -f /tmp/kustomize-helm-123460339/linkwarden-kustomize-values.yaml' with env=[HELM_CONFIG_HOME=/tmp/kustomize-helm-123460339/helm HELM_CACHE_HOME=/tmp/kustomize-helm-123460339/helm/.cache HELM_DATA_HOME=/tmp/kustomize-helm-123460339/helm/.data] (is 'helm' installed?): exit status 1

Additional information
No response

same issue here

@FMJdev i am having the same issue if this pr help i would be glad that you can employ it

When will Version 0.2.1 release?


firejail: <IP_ADDRESS> -> 0.9.60

Motivation for this change
https://firejail.wordpress.com/download-2/release-notes/
(link not specific to this version, sorry!)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@mmahut Unfortunately, firejail needs setuid-root for multiple things it wants to do, and it doesn't provide rootless mode (which is a bit unfortunate). So I think what you observe isn't a regression.

Will consider, but mostly a fly-by. Will adopt if find myself using it even a little! :)


⚠ ClamAV has degraded performance

In ea2c8e2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 185 ms

Resolved: ClamAV performance has improved in 2ce1d8f.


[View Campaign]User is able to post comment without entering any value into the textbox.

Title:
User is able to post comment without entering any value into the textbox.
Platform / OS:
Windows, Mac
Browser:
Firefox (45.0, 47.0), Chrome (51.0, 53.0), IE (10, 11), Safari 10
Description:
User is able to post comment without write any comment into the textbox.
Steps to Reproduce

Open Url.
Login with valid credentials.
Create a Campaign if there is no active campaign
Click on "View Campaign" link.
Click on "Post comment" button without writing anything on the textbox.

Expected Behavior
User should get validation message while trying to post comment without entering any value into the textbox.
Additional Info
Branch: 0b650b07369f1e40f3df170a90fc2b82e13df2d4
dev Build: https://circleci.com/gh/sleepbusorg/sleepbus.org/125

Related error user can enter XSS values


workout-tracker: init at 0.10.5

Description of changes
Add https://github.com/jovandeginste/workout-tracker as package.
A rudimentary NixOS module is also included.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/1016/111

@leona-ya thanks a lot for the review! I've tried to address everything with proposed changes, please take a look whenever possible.

Hi @leona-ya , @SuperSandro2000 . I've added a module test and reworked some options. Looks like WorkingDirectory does not work with DynamicUser. Its still preferable to have the dynamic user, but if you think user-customizable user and group values are better, we can go with that.

As discussed with @ElvishJerricco on matrix, DynamicUser is preferable to explicit one, and since the StateDirectory for dynamic user is always under /var/lib/ it doesn't make sense to keep it configurable. The module test now works with on-disk db, so this PR is now again ready for review.

Hi @leona-ya , @SuperSandro2000 , anything more left to do in this PR? Can this be merged?

Thanks @leona-ya !
@SuperSandro2000 if nothing else, can we merge this?


NPM warning of using deprecated package

npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained. Please, upgrade to core-js@3
I am hitting deprecated warning against core-js v1.2.7, which is used by<EMAIL_ADDRESS>[ as illustrated in the below screen-grab
└─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>Strangely, when I looked at react-popper package.json, I found no reference of ><EMAIL_ADDRESS>Not sure what is causing this deprecation warning

I need to cut a new release with https://github.com/FezVrasta/react-popper/pull/281 to fix this

bump


Add integration with Notion

Feature request to add support for tracking time on Notion.
Notion is a great Knowledge Base software. I'm starting to use it for documentation in most of my projects. And it's user base is growing rapidly.

Agree. Currently Notion is not offering any time tracker integrations:

Ashley From Notion<EMAIL_ADDRESS>on 24th May 2018 wrote:
Hi Bartek! We don't currently integrate with any time tracker apps, but I'll add your vote for it

Toggl may be the first time tracker for Notion! 😉

Upvoting on behalf of user that reached out via case/723231 :)

+1

@Jinivus any updates on your efforts? :)

@Stvad I tried out @Jinivus' branch and it didn't appear to be working, so I created a PR of my own (#1203).

@karlhorky Awesome, thanks!

Which areas of notion would people like to see a timer integration in, specifically? The open PR from @karlhorky adds a button to Task items in database blocks, for example, which is one useful case.

Oh, did you want something else @tcrammond ? Didn't think about any other use cases.
I had a bug yesterday that was causing the other items to also get Toggl buttons on them, and I "fixed" that bug. But maybe that was what you wanted?

Woo nicely done! Can I suggest switching to the greyscale logo and removing the text? That should work better for both style and dark/light mode switching.

Other usecases I forsee are just basic todos, something like this (mockup):

And then within lists and tables? Not sure the best way to do this to make it discoverable, but I usually don't click into my tasks when I start them.

The later would mean looking a column called toggl so that it doesn't appear on EVERY table, but yeah just some ideas where i'd find them useful 👍

switching to the greyscale logo and removing the text

I would be fine with the first one, but with the second I would like to keep the text (just in the modal view, in the other locations there's not enough space). I'll see what I can do to make the link text inherit the surrounding styles.
I'm new to Notion, so I didn't actually know there was a dark mode. I'll make sure that whatever changes I make work with that.
For lists, I'll base my implementation off of the Basecamp one:
https://github.com/toggl/toggl-button/blob/a5c7b8144098788e0bd99a7cae47baab54597159/src/scripts/content/basecamp.js#L74-L96
For the minimal buttons for the other views, I'll use the buttonType: 'minimal' option as in Asana:
https://github.com/toggl/toggl-button/blob/a5c7b8144098788e0bd99a7cae47baab54597159/src/scripts/content/asana.js#L187
I've found the table view, but can't seem to find the Daily Todos view that you have.
I've added these as todos in the pull request. Help welcome :)

You can add multiple views to any table, in the top left next to the title of the table 😃. my daily todos is a "list".

So the first PR for the task modal was merged in #1203. The remaining open tasks mentioned by @lewcart are (help welcome!):

[ ] Minimal button for (unchecked) todos (like Basecamp)
[ ] Minimal button for (incomplete) tasks in list view (like Basecamp)
[ ] Add column minimal button for (incomplete) tasks in table view - how??
[ ] Use the grayscale logo (may need to change style.css - maybe difficult?)

I enabed this and doesn't seem to work or add anything to Notion.

@xmarkclx Did you take a look at the screenshot in #1203? Does this not show up for you? Did you refresh?

@karlhorky nope. i even quit(cmd q) and reloaded chrome and reopened notion with a hard refresh.
here's a screenshot.

Can't remember whether I made it work on the full pages as well - try on a popup task. If you have further comments lets continue in the other closed PR: https://github.com/toggl/toggl-button/pull/1203.

Hi @karlhorky, is this a popup task? Because there is no button there as well.

As mentioned above, I'm continuing the discussion in the PR: #1203


Constant migration prompt during update

Thanks for reporting, this should (hopefully) be resolved now. It was an issue on the foundry vtt package manager


Use Hamcrest assertions instead of JUnit in examples/metrics/filtering/se (#1749)

Part of #1749
Backport 2.x

/trigger


ADBDEV-6257: Fix pg_dump incorrect cleanup for external tables

Fix pg_dump incorrect cleanup for external tables
Fixes issue #1025. DROP EXTERNAL TABLE in pg_dump output had incorrect syntax,
this patch fixes the typo.
Co-authored-by: eshkinkot<EMAIL_ADDRESS>

Allure report https://allure.adsw.io/launch/79870

Allure report https://allure.adsw.io/launch/79931

Allure report https://allure.adsw.io/launch/80041


Include Relations on Table per Hierarchy (TPH)

Feature Request
Add the ability to Include the relationships of properties on a collection where the collection type is of a Table per Hierarchy design and the relationships are defined on the derived types with lazy loading disabled.
The OfType extension could be used to specify the derived type so the relations on that type could be specified.
There is a similar request already for Entity Framework Core - 3910.
Example:
var materialized = dbContext.ParentDbSet.Where(x => optionalCondition)
  .Include(x => x.AbstractTypeEntitRelations.OfType<DerivedType>().Select(y => y.RelationsOnDerivedType))
  .SingleOrDefault();

This is currently not possible.
Use Case
This should avoid having to declare the relationships on the base type or having to execute multiple DB calls to retrieve the relationships.
Complete MCVE
Structure

A school in a University has Persons
A Person is either Student or Teacher
Student has zero or more course books on loan
Teacher can be assigned as the care taker / guardian for one or more campus buildings

Code
SchoolService.cs
public sealed class SchoolService
{
    private readonly UniversityDbContext _dbContext;
    public SchoolService(UniversityDbContext dbContext)
    {
        _dbContext = dbContext;
    }

     // This is the code of interest for the feature request
    public School GetSchoolAndPeopleWithDetails(int schoolId)
    {
        return _dbContext.Schools.Where(x => x.SchoolId == schoolId)
            .Include(x => x.EntitiesOfSchool.OfType<Teacher>().Select(y => y.Buildings))
            .Include(x => x.EntitiesOfSchool.OfType<Student>().Select(y => y.BooksOnLoan))
            .SingleOrDefault();
    }
}

Entities.cs
public sealed class School
{
    public int SchoolId { get; set; }
    public string Name { get; set; }
    public List<Person> EntitiesOfSchool { get; set; }
}

public abstract class Person
{
    public int PersonId { get; set; }
    public string Name { get; set; }
    public School PrimarySchool { get; set; }
    public int SchoolId { get; set; }
}

public sealed class Teacher : Person
{
    public ICollection<Building> Buildings { get; set; }
}

public sealed class Student : Person
{
    public ICollection<CourseBook> BooksOnLoan { get; set; }
}

public sealed class Building
{
    public int BuildingId { get; set; }
    public string Name { get; set; }
    public Teacher AssignedGuardian { get; set; }
    public int GuardianId { get; set; }
}

public sealed class CourseBook
{
    public int CourseBookId { get; set; }
    public int BookNumber { get; set; }
    public Student AssignedTo { get; set; }
    public int? AssignedToId { get; set; }
}

EntityMappings.cs does not include Building or CourseBook mapping types as they are not relevant
public sealed class SchoolMap : EntityTypeConfiguration<School>
{
    public SchoolMap()
    {
        ToTable("Schools");
        HasKey(x => x.SchoolId);
        Property(x => x.SchoolId).HasDatabaseGeneratedOption(DatabaseGeneratedOption.Identity);
        Property(x => x.Name).IsRequired().IsUnicode(true).HasMaxLength(200);
        HasMany(x => x.EntitiesOfSchool).WithRequired(x => x.PrimarySchool).HasForeignKey(person => person.SchoolId);
    }
}

public sealed class PersonMap : EntityTypeConfiguration<Person>
{
    public PersonMap()
    {
        ToTable("Persons");
        HasKey(x => x.PersonId);
        Property(x => x.PersonId).HasDatabaseGeneratedOption(DatabaseGeneratedOption.Identity);
        Property(x => x.Name).IsRequired().IsUnicode(true).HasMaxLength(256);
        Map<Teacher>(configuration => configuration.Requires("PersonType").HasValue(1));
        Map<Student>(configuration => configuration.Requires("PersonType").HasValue(2));
    }
}

public sealed class TeacherMap : EntityTypeConfiguration<Teacher>
{
    public TeacherMap()
    {
        HasMany(x => x.Buildings).WithRequired(x => x.AssignedGuardian).HasForeignKey(x => x.GuardianId);
    }
}
public sealed class StudentMap : EntityTypeConfiguration<Student>
{
    public StudentMap()
    {
        HasMany(x => x.BooksOnLoan).WithOptional(x => x.AssignedTo).HasForeignKey(x => x.AssignedToId);
    }
}

UniversityDbContext.cs
public sealed class UniversityDbContext : DbContext
{
    public UniversityDbContext() : base("Name=default")
    {
        this.Configuration.LazyLoadingEnabled = false; // disable lazy loading
    }

    protected override void OnModelCreating(DbModelBuilder modelBuilder)
    {
        modelBuilder.Configurations.Add(new SchoolMap());
        modelBuilder.Configurations.Add(new PersonMap());
        modelBuilder.Configurations.Add(new TeacherMap());
        modelBuilder.Configurations.Add(new StudentMap());
    }

    public DbSet<School> Schools { get; set; }
}

Sql code for table DDE and seed of  data.sql
CREATE TABLE [dbo].[Schools](
	[SchoolId] [int] IDENTITY(1,1) NOT NULL,
	[Name] Nvarchar (200) not null
CONSTRAINT [PK_Schools] PRIMARY KEY CLUSTERED
(
	[SchoolId] ASC
)) ON [PRIMARY]
GO

CREATE TABLE [dbo].[Persons](
	[PersonId] [int] IDENTITY(1,1) NOT NULL,
	[SchoolId] [int] not null,
	[PersonType] [int] not null,
	[Name] nvarchar(256) not null
CONSTRAINT [PK_Persons] PRIMARY KEY CLUSTERED
(
	[PersonId] ASC
)) ON [PRIMARY]
GO

CREATE TABLE [dbo].[Buildings](
	[BuildingId] [int] IDENTITY(1,1) NOT NULL,
	[Name] nvarchar(200) not null,
	[GuardianId] [int] not null,
CONSTRAINT [PK_Buildings] PRIMARY KEY CLUSTERED
(
	[BuildingId] ASC
)) ON [PRIMARY]
GO

CREATE TABLE [dbo].[CourseBooks](
	[CourseBookId] [int] IDENTITY(1,1) NOT NULL,
	[BookNumber] varchar(200) not null,
	[AssignedToId] [int] null,
CONSTRAINT [PK_CourseBooks] PRIMARY KEY CLUSTERED
(
	[CourseBookId] ASC
)) ON [PRIMARY]
GO

ALTER TABLE [dbo].[Persons] WITH CHECK ADD CONSTRAINT [FK_Schools_Persons] FOREIGN KEY([SchoolId])
REFERENCES [dbo].[Schools] ([SchoolId])

ALTER TABLE [dbo].[Buildings] WITH CHECK ADD CONSTRAINT [FK_Persons_Buildings] FOREIGN KEY([GuardianId])
REFERENCES [dbo].[Persons] ([PersonId])

ALTER TABLE [dbo].[CourseBooks] WITH CHECK ADD CONSTRAINT [FK_Persons_CourseBooks] FOREIGN KEY([AssignedToId])
REFERENCES [dbo].[Persons] ([PersonId])

INSERT INTO Schools (Name) values (N'Business'), (N'Education')
INSERT INTO Persons (Name, PersonType, SchoolId) values ('Eddy',1, 1), ('Fran',1, 1), ('Joe',2, 1), ('Kim',2, 1)
INSERT INTO Buildings (Name, GuardianId) values (N'Offsite staff', 1), (N'Main Business Building', 1)
INSERT INTO CourseBooks(AssignedToId, BookNumber) values (3, 'Course A book 1'),(3, 'Course C book 31')

EF Team Triage: This issue is not something that our team is planning to address in the EF6.x code base.  This does not mean that we would not consider a community contribution to address this issue.
Moving forwards, our team will be fixing bugs, implementing small improvements, and accepting community contributions to the EF6.x code base. Larger feature work and innovation will happen in the EF Core code base (https://github.com/aspnet/EntityFramework).
Closing an issue in the EF6.x project does not exclude us addressing it in EF Core. In fact, a number of popular feature requests for EF have already been implemented in EF Core (alternate keys, batching in SaveChanges, etc.).
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Expose types for the overarching Call, Error, Event types

Currently, using these with e.g. https://github.com/paritytech/scale-value requires doing manual decoding of the first byte, hunting down the pallet index in RuntimeMetadataV14::pallets, and then decoding the remainder of the payload with the types exposed in PalletMetadata. The RuntimeMetadataV14 should expose all of these overarching types.

I can think of two ways to approach this:

Add those type definitions as fields at the top level in the metadata itself: requires initializing them here. Pros it is guaranteed to describe the exact shape of those generated types. Cons are that it would introduce some redundant information (although arguably a small amount).

Expose some methods in frame-metadata to dynamically construct those type definitions based on the information already available. Pros are that it will not require a change to substrate so you can start using it immediately.  Cons are that there is no absolute guarantee the types would be exactly the same as the macro generated types in substrate, and also depends on the ability to dynamically construct "portable" type definitions (ongoing but incomplete work: https://github.com/paritytech/scale-info/pull/164)

Possibly you could start with 2. and add the methods, and while waiting for 1 to propogate throrugh to node implementations. Then the methods could just be changed to access the fields once available.

We deal with this in Subxt at the moment by generating the relevant root Call, Event and Error types and then having them implement a trait that ends up looking like:
impl ::subxt::events::RootEvent for Event {
    fn root_event(
        pallet_bytes: &[u8],
        pallet_name: &str,
        pallet_ty: u32,
        metadata: &::subxt::Metadata,
    ) -> Result<Self, ::subxt::Error> {
        use subxt::metadata::DecodeWithMetadata;
        if pallet_name == "System" {
            return Ok(Event::System(system::Event::decode_with_metadata(
                &mut &*pallet_bytes,
                pallet_ty,
                metadata,
            )?));
        }
        if pallet_name == "Scheduler" {
            return Ok(Event::Scheduler(scheduler::Event::decode_with_metadata(
                &mut &*pallet_bytes,
                pallet_ty,
                metadata,
            )?));
        }
        if pallet_name == "Preimage" {
            return Ok(Event::Preimage(preimage::Event::decode_with_metadata(
                &mut &*pallet_bytes,
                pallet_ty,
                metadata,
            )?));
        }
        // ...
    }
}

This exists to work around the fact that the type Id for the generated type isn't in the type info, and lets us instead use the pallet name to, in the above case, encode arbitrary events.
All that to say, I think exposing the call_ty, error_ty and event_ty at the top level of the metadata would be very useful for us and save a bunch of codegen and boilerplate, so I'm all for it! We'll endeavour to add this to V15 metadata.

This issue has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/stablising-v15-metadata/2819/1

The https://github.com/paritytech/substrate/pull/14143 PR closes this


add a slider plugin

Hi, I added a Vue slider plug-in called iv-slider(https://github.com/lycHub/v-slider).
I hope to join you.

Sorry, I did not pay attention to see CONTRIBUTING.md and have updated it now.  thanks.

@kazupon can we merge it now?


:feet: Error when vddk init image is empty

Ref: https://github.com/kubev2v/forklift-console-plugin/issues/1206
Issue:
When creating and editing a vmware provider it's easy to leave the vddk container image empty
Fix:
Add a checkbox for users to confirm they want an empty image

[x] Error field and form if image is empty, edit and create provider
[x] Allow to override empty image error using a checkbox, edit and create provider
[x] In details page, make empty image a warning

Screenshots:

@yaacov  I am having trouble with invalidvddkimage , is there any specific file I should be using? I am running forklift version 2.7.0 - (target) kubevirt cluster 1.0 / k8s version 1.25.10 - vsphere 7.x (source) ---
can I use images from kubevirt quay.io repo? if so , vddk-init or vddk-test...If from broadcom which version specifically - I am lost , raised issue https://github.com/kubev2v/forklift/issues/971
Do i have to clear all old plans if I am changing provider vddk ? or what is the clean way to reinstall provider with vddk changes or understand errors from controller logs better.


Merge master into Structured Data branch, fix conflicts

Clone this repository somewhere on your computer: https://github.com/VitalyVPinchuk/apps-android-commons/tree/upload_caption_depict
Switch to the upload_caption_depict branch
Test it: Browse by items, see parent and child items
Test it more: Upload a picture via Nearby and post below the URL of the uploaded picture
Merge the latest master of git@github.com:commons-app/apps-android-commons.git
Fix the conflicts
Test again (steps 3 and 4)
Let us know when you are done by posting a comment below

Clone this repository somewhere on your computer: https://github.com/VitalyVPinchuk/apps-android-commons/tree/upload_caption_depict
Switch to the upload_caption_depict branch
Test it: Browse by items, see parent and child items
Test it more: Upload a picture via Nearby and post below the URL of the uploaded picture
Merge the latest master of git@github.com:commons-app/apps-android-commons.git
Fix the conflicts
Test again (steps 3 and 4)
Send pull request to git@github.com:commons-app/apps-android-commons.git

Can I work on this issue?

@GearGit : Yes, thanks! Please let us know about your progress at least once per day :-)

@GearGit : Yes, thanks! Please let us know about your progress at least once per day :-)

I will surely update my progress daily, as a matter of fact, I have already started working on it.

@nicolas-raoul Can I use Travis CI for merging conflicts?

Not sure how it might help, but feel free to try.
On Tue, 26 Nov 2019, 13:33 Somanshu<EMAIL_ADDRESS>wrote:

@nicolas-raoul https://github.com/nicolas-raoul Can I use Travis CI for
merging conflicts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3222?email_source=notifications&email_token=AAAYKBWCFV22ZHXRTFHWZ7DQVSRIVA5CNFSM4JRCNLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEVTHI#issuecomment-558455197,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYKBTMX7JTJTGNSRYYZNTQVSRIVANCNFSM4JRCNLAA
.

I am not sure if its a beginner-friendly issue. Apart from resolving the merge conflicts, this task would also require fixing the Wikidata API calls. None of the authenticated API were working earlier.

Vivek, thanks for the insight!
I think the merging is newcomer-friendly.
Then URLs can be replaced by an expert 🙂
On Tue, 26 Nov 2019, 13:51 Vivek Maskara<EMAIL_ADDRESS>wrote:

I am not sure if its a beginner-friendly issue. Apart from resolving the
merge conflicts, this task would also require fixing the Wikidata API
calls. None of the authenticated API were working earlier.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3222?email_source=notifications&email_token=AAAYKBX36CAOCRRSKSAERDLQVSTONA5CNFSM4JRCNLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEWQ6A#issuecomment-558459000,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYKBWQFXJNZHBRSCNV4JDQVSTONANCNFSM4JRCNLAA
.

I think the merging is newcomer-friendly.

Are we talking about merging master into the structured-data branch? If yes, then it should be fine that anyone picks it. :)
Else, if we are talking about merging structured-data into master then everything will need to work perfectly before it can be merged.

Then URLs can be replaced by an expert 🙂

Also, the URLs are correct AFAIK, but some changes need to be done in how the edit token is fetched. Also, some of the APIs need to be modified to send multipart request params instead of application/x-www-form-urlencoded.

Are we talking about merging master into the structured-data branch?

Yes, that is an important task to ensure it stays up-to-date.

Else, if we are talking about merging structured-data into master then everything will need to work perfectly before it can be merged.
Also, the URLs are correct AFAIK, but some changes need to be done in how the edit token is fetched. Also, some of the APIs need to be modified to send multipart request params instead of application/x-www-form-urlencoded.

Is there an issue about this? If not it would be great to create one, so that we don't forget some todo or tips :-)

Yes, that is an important task to ensure it stays up-to-date.

Do you mind updating the task title and description?

Is there an issue about this? If not it would be great to create one, so that we don't forget some todo or tips :-)

Sure, will do. :)

Fixed, thanks! :-)

Do I have to still merge the https://github.com/VitalyVPinchuk/apps-android-commons/tree/upload_caption_depict
Branch with the master merge?
If yes,then who will be handling the URLs.

@GearGit Yes please clone https://github.com/VitalyVPinchuk/apps-android-commons/tree/upload_caption_depict then merge the main repo's master into it.
The URLs/etc will be handled by someone else (or even you if you understand everything and are motivated) in the issue Vivek will create.

@nicolas-raoul I have cloned the branch into my local machine and tried merging it with the master branch, but there are several conflicts which I have to manually correct.
Should I simply just allow the new changes to overwrite the old ones or do I also have to check how is it affecting the master branch?

Test it: Browse by items, see parent and child items

Also, I didnt quite get this part, therefore it would be very helpful if you can provide a screenshot or some information.

Should I simply just allow the new changes to overwrite the old ones or do I also have to check how is it affecting the master branch?

That is the difficulty or merging conflicts: You have to understand the code, and keep the features and improvements of both sides. Good luck! :-)

Test it: Browse by items, see parent and child items

Before merging, run the app and go to the "Explore" section then use the search bar and tap everything that talks about items. Also make sure to try and understand how this page works (when uploading a picture):

@nicolas-raoul @maskaravivek I found this bug when I was searching for a bow in the explore section, don't know the exact reason for this bug.

Whenever I am searching for some caption under items -> media tab, "No images found" message is displayed for any caption that I enter, but if I enter same caption under the media tag then it works fine.
Furthermore, when I am checking the parent and child classes, then I am sometimes encountering the following leak:

Due to this error, the app sometimes crashes, and in the leaks app, there are multiple leaks displayed like ReportFragment leaked, WikidataItem-DetailsActivity leaked and many more.
How should I go about fixing this?

@GearGit thanks for reporting this. Please create a separate issue for this and any other issues that you encounter on this branch.

@GearGit Great work! As Vivek said, please create issues for each problem (be sure to mention what repo+branch in each issue), and then for each issue we can guide you on how to fix it :-)

@nicolas-raoul @maskaravivek Take another example, when I type flowers.
,

But in the play store version of app I am able to fetch the data without any issue.
Maybe I should open seperate issue for this.

Yes please! Don’t hesitate in creating new issues even if you are not sure that it deserves a separate issue or not :)

Should I create a new issue here or in the repository https://github.com/VitalyVPinchuk/apps-android-commons/tree/upload_caption_depict

Here. Thanks 🙂
On Sat, 30 Nov 2019, 14:47 Somanshu<EMAIL_ADDRESS>wrote:

Should I create a new issue here or in the repository
https://github.com/VitalyVPinchuk/apps-android-commons/tree/upload_caption_depict
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3222?email_source=notifications&email_token=AAAYKBVCBCRFQPKM4IXUUELQWH463A5CNFSM4JRCNLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFP2ABI#issuecomment-559915013,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYKBQPQKDCEXJEXUZSUCLQWH463ANCNFSM4JRCNLAA
.

@nicolas-raoul @maskaravivek i have made some changes in the categories and media section of explore in #3254
Please verify so that I can create a pull request and merge upload_caption_depict branch with master branch.

Sorry I have no time to check this month, anyone please check and let us
know, thanks 🙂
On Fri, 6 Dec 2019, 19:29 Somanshu<EMAIL_ADDRESS>wrote:

@nicolas-raoul https://github.com/nicolas-raoul @maskaravivek
https://github.com/maskaravivek i have made some changes in the
categories and media section of explore in #3254
https://github.com/commons-app/apps-android-commons/issues/3254
Please verify so that I can create a pull request and merge
upload_caption_depict branch with master branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3222?email_source=notifications&email_token=AAAYKBXGVJF3TXXQQ4DXWITQXMKDPA5CNFSM4JRCNLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGF4U4Q#issuecomment-562809458,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYKBUIF55BWY35WB2BSCTQXMKDPANCNFSM4JRCNLAA
.

@GearGit Does your branch https://github.com/GearGit/apps-android-commons/tree/upload_caption_depict compile and run correctly? Could you please post a screenshot of its "Explore" activity? Thanks :-)

Sorry for the delay in responding, but the https://github.com/GearGit/apps-android-commons/tree/upload_caption_depict branch does compile. I will upload a screenshot of the explore activity.

@GearGit Does your branch https://github.com/GearGit/apps-android-commons/tree/upload_caption_depict compile and run correctly? Could you please post a screenshot of its "Explore" activity? Thanks :-)

Looks like there is some issue with the upload_caption_depict branch, the "Explore" section of the app, as well as the "Uploaded via Mobile" both display the message "No images found!".
I will look into it and make a pull request.
@nicolas-raoul my previous pull request hasn't been yet merged by the collaborators. Is it maybe because I pulled the request on upload_caption_depict branch of https://github.com/VitalyVPinchuk/apps-android-commons

@misaochan what would be the acceptance criteria for this ticket?

After merging the latest master into upload_caption_depict branch, some testing is needed, to make sure that at least pictures can be uploaded with crash

I can verify you can upload a picture without crashing, tested on betaDebug. I did however get 2 items shown in the list, subsequently a crash when clicking the 2nd item but that bug was introduced in #3133.
To what extent must I verify this is working?

first task would be getting Vanshika's work master-ready to create a foundation for him to work on

The change is clocking in +7,253 −213 so I may need a definition of master ready or I could be doing this for a week or two.

@nicolas-raoul do you have any guidance on the acceptance criteria of this ticket?

Wow, sorry, I didn't get notified of this ping for some reason! Could you please link me to the image on Commons that you uploaded with this branch? The caption and depicts fields should be appropriately filled in the Commons file page.
Aside from that, here are the issues with the branch that I can see so far.
From @maskaravivek :

Also, the URLs are correct AFAIK, but some changes need to be done in how the edit token is fetched. Also, some of the APIs need to be modified to send multipart request params instead of application/x-www-form-urlencoded.

From @nicolas-raoul :

Test it: Browse (Explore) by items, see parent and child items
Test it more: Upload a picture via Nearby and post below the URL of the uploaded picture
Merge the latest master of git@github.com:commons-app/apps-android-commons.git
Fix the conflicts
Test again (steps 3 and 4)
Let us know when you are done by posting a comment below

From @GearGit :

Whenever I am searching for some caption under items -> media tab, "No images found" message is displayed for any caption that I enter, but if I enter same caption under the media tag then it works fine.
Furthermore, when I am checking the parent and child classes, then I am sometimes encountering the following leak:

Thank you for the reply @misaochan , I will contact you promptly in the future.

How did #3133 introduce a new crash?

While the intentions were noble the result the code does not do the same thing, if the context is not CategoryImagesCallback then there is a ClassCast, code
I have uploaded a picture on beta but beta performs poorly with this branch so I have switched to using prod which functions better. I have however not been uploading to prod because I thought that would get me flagged, I believe someone mentioned that there is a list of images that an be safely uploaded to prod? If there is could I be linked to them?
You can use Explore and see items but the navigation has some errors in it when navigating deeply.
There will need to be a fair bit of rewriting I would think, Room should definitely be introduced and converting chunks to kotlin would certainly have great benefit.
As a plan for work where I am not silo-ed off I think we should revive this suggestion from @maskaravivek

I think we should make a copy of the upload_caption_depict branch to our repo and continue working on that

With the aim of me making tickets that can get reviewed as I merge them to the branch.
I would merge to master but the downside of most of these features being unusable on beta would add too much confusion to the project I think.

I have uploaded a picture on beta but beta performs poorly with this branch so I have switched to using prod which functions better.

Absolutely, I would recommend using prod as far as possible, unless you need to upload a lot of test photos.

I believe someone mentioned that there is a list of images that an be safely uploaded to prod? If there is could I be linked to them?

The easiest way is to spend 5 min outdoors just taking pictures of stuff - Commons needs all sorts of pictures, even if it's just a park or street or tree. :) But if this is a problem, I can email you some of my pictures if you like.

There will need to be a fair bit of rewriting I would think, Room should definitely be introduced and converting chunks to kotlin would certainly have great benefit.

I agree.

As a plan for work where I am not silo-ed off I think we should revive this suggestion from @maskaravivek : I think we should make a copy of the upload_caption_depict branch to our repo and continue working on that. With the aim of me making tickets that can get reviewed as I merge them to the branch.

This sounds like a good idea to me.

I would merge to master but the downside of most of these features being unusable on beta would add too much confusion to the project I think.

Yes, don't merge to master until these issues are fixed. A development branch would be perfect as you mentioned above.

Btw, just leaving a note here in case I forget later: It would be great if you could also make sure that the unit test coverage is up to par before we merge into master. It's possible to add the unit tests later, but it's easier to keep track of it if we just have them when the dev branch is merged.

Also, I guess #3484 would have to be taken care of so that on retrying failed uploads captions and depicts are not lost.

@macgills I have thousands of pictures to upload, here are some just for you, after you upload them all please please ask and I will add a hundred more :-)

Hi @nicolas-raoul , @ashishkumar468 was encountering difficulty with using your images due to not knowing the title and description that he should use to upload them. Could you add a brief one please? :)

@macgills @ashishkumar0207 When uploading my images, please use the title "Shibuya cityscape" or "Food in Shibuya restaurant" (feel free to adapt if obvious), and select the category Shibuya. Also, please tell me your Commons accounts by email or chat, so that I can see the pictures you uploaded and add a description and more precise categories. Thanks!

on prod I am macgills2

Thanks @nicolas-raoul , I my username is Ashishkumar468

@misaochan

I would merge to master but the downside of most of these features being unusable on beta would add too much confusion to the project I think.

Yes, don't merge to master until these issues are fixed. A development branch would be perfect as you mentioned above.

So the issue with this is the beta environment, not necessarily the app (though a little bit the app).
Merging is becoming more crucial to stop divergences from arising so if we can live with it I would aim to get structured data merged sooner rather than later and live with the consequences.

Yes, exactly. Due to the nature of how the beta cluster works, there are many features of the app that do not work on it. This is perfectly fine and intended (on our side) - if we restricted ourselves to an app that works perfectly on beta, we would have no Nearby uploads, no category suggestions, so on and so forth.
We should aim for it to work on production, and that is sufficient. Beta is solely to be used as a convenience tool (wherever possible), not as a target.

Okay, then I will open a PR to close this ticket

Great! Please ping for testing when it's ready. :)

@misaochan ping


Placeholders in the commit template

Hi, this plugin is very useful, thank you for sharing it with us.
Although it will be nice if we had the opportunity to define placeholders in the template, that will be automatically filled when you press CTRL+K to commit.  One placeholder very useful is the git branch name. Where i work we need to write the branch name for every commit.
Ex: In the template i write " [#branch_name] " and when i commit the plugin will automatically replace #branch_name with the current git branch name.
Thanks

I'll look into it.

Even better (and without getting greedy), be able to apply a regex on the branch name to get the actual string we want. Let me know if you feel like getting help on this.
Toda Matan!

@gkohen It'll be great if you can lend a hand. I have no idea when I'll be able to get it.

@gorenm , I started working on it but I'm stuck on trying to resolve the branch name from the project object.
I've opened a SO object here:
https://stackoverflow.com/questions/44411970/in-a-intellij-plugin-how-to-resolve-the-current-projects-branch-name
Like mentioned, any pointers would be appreciated.

@gkohen I think that the getCurrentBranchName function from com.intellij.dvcs.repo.Repository might work.
Haven't tried it out yet though.

can you just run command git rev-parse --abbrev-ref HEAD in current directory maybe?

Any progress on this one?


Upgrade ZIO and interop-cats

Any chances of another release so ZIO users can get this change? Thanks!


Logsignature example

This PR adds a simple logsignature example that broadly follows the spiral example but tests over a large step size for logsignature depths 1, 2, 3. The model achieves top performance using the depth 2 logsignature and thus gives an indication into the potential usefulness.
This example computes logsignatures upfront as a preprocessing step and as such provides a very basic usage whereby one cannot easily query for values in between logsignature endpoints. My preferred usage is to build a dataset class that when queried with an interval returns a logsignature, the signatory.Path class is initialised in the dataset so we get fast retrieval of the logsignatures. In the training loop one can then provide a custom sampler with a collection of intervals that can be iterated over. What is nice about this is we can at any point query with a different interval (or collection thereof) to evaluate over different logsignatures. The code would look something like this
dataset = LogSignatureDataset(data, depth=3)
sampler = IntervalSampler(step=10, method='fixed_length_intervals')    # We can then also define a sampler where intervals are randomised in the training loop
dataloader = Dataloader(dataset, sampler=sampler)
model = NCDE(...)
for batch in dataloader:
    # Train model
# Evaluate over a new interval
new_intervals = [[0, 3], [3, 7], [7, 11]]
outputs = model(dataset[new_intervals])    # We now have the results over different times

I think this is a more natural method for this approach, although it seems a little complex. I'm not sure it would fit in the main code base, but would you be interested in having such an example given?

I think a general sampler is probably a step too complicated to include as a pre-built example, unless it really demonstrably improves performance.


Whether it is possible to provide compiled files (.dll)

Whether it is possible to provide compiled files (.dll)
for example:  net4.0/ACadSharp.dll, new6.0/ACadSharp.dll , etc.

Hi @xiuweihan
In a repo you usually don't upload the compiled files, only the code, if you want them you can extract them form the Nuget Package https://www.nuget.org/packages/ACadSharp/2.1.0-beta or just use the package.
Hope this helps.


Feature Request: Database of all Rematch Teams and Pet Battle Scripts from wow-petguide (Xufu's)

It would be the most amazing thing ever if you all had a database that auto looked at your available pets and auto imported associated teams and pet battle scripts that exist on Xufu. I know this would be a huge undertaking, I would be highly motivated to help you dump these, I would also be willing to donate a large sum to get a feature like this made as it would be a very useful thing for the wowaddon world.

Currently in discussion with Xufus and Gello (Rematch author) to talk about how this would work and the best way forward. I am concerned that doing this may have a negative traffic impact on the site. Another problem is that scripts are constantly evolving and being updated (especially for newer content) which means anything bundled with the addon is at risk of always being out of date. Saying that, its always nice to have some prewritten scripts bundled as a starting point 🙂

Please keep in mind that even if it is "just" strategies, the creators still have some form of ownership/copyright and freely distributing them without their permission is questionable.

But an option to import team and script together would be sweet.. especially when you import multiple teams in one go.


Discord Linux thingy

What is your username and discriminator?
LOV3LL#9999
Why did you join Discord Linux?
I need help with Linux
Where did you hear about Discord Linux?
I used google to find this server
What is the passphrase that was assigned to you by the bot?
sudo -i lamentable-cascade-possible-switch

From Vix#0011 :
Issue closed, you entered the passphrase


SmartLeds buffering

Can I hack smartleds to work with given stating position in buffer to rotate display?

After some experimenting, it turns out it doesn't really make sense to do this, the for cycle used is fast enough...


MongoDB - JSON view

Hi,
If I double click on my collection, then I can change result view to Grid, Text, Json. But Json view is not available when I execute my custom script like:
db.getCollection('log').find().limit(5);

or
db.getCollection('log').find().limit(5).toArray();

Is there any way to view as JSON without executing SQL?
Regards

Thanks for report


Fix a couple of issues with player.py

Hi
Thanks, I've had fun playing with this. I noticed a couple of things with the player class that I've tried to fix:

I ran into the issue reported here:

https://github.com/dwillis/python-espncricinfo/issues/27
The issue seems to be that players who have a profile but haven't played games of a sufficient standard, only have a single table of data whereas the methods assumed four. I've put in a simple check and returned none where bowling averages etc don't exist.

I found that the existing methods to pull batting and bowling averages are dropping the last format. I've amended the logic to fix this.

Sorry about the noise from the rolled back commit, I was just toying with the match class as well but thought I'd try to separate out just the stuff relevant to the player class in this PR.
Let me know what you think and thanks!
Alex

@scrambldchannel Thanks!


Working with 2.0

I'm trying to use version 2.0.0, but it doesn't have a "dist" folder and is therefore giving the error (Cannot find module 'geofirestore')
I don't think I can use 1.2.0 right now because it looks like it doesn't support adding additional fields to the collection (which I need)
anyway to build and publish 2.0?

What's the exact version of v2.0 are you using?? (From your package.json). Cause I know other ppl have used it just fine, so I wanna make sure this is isolated, and can be resolved.
(P.S., just to clarify some bits, you can build v2 with the npm run build command, you can also install a version 2 beta with npm i geofirestore@next)

thanks, had the wrong version installed


Wechaty has web service api?

I want to send a http request which is  sending a message to a chatroom.
Does Wechaty have  this function?

We have a projects for for doing that.
Please read OSSChat source code if you are interested:
https://github.com/kaiyuanshe/osschat


Needs updating to work on current Leaflet

As far as I can tell, this plugin doesn't work with current Leaflet (I'm testing on 1.2.0)

@ann26  please look into this and consider updating it to work with 1.2 (and either making it backwards compatible or tagging separate versions to match Leaflet major versions. Then look at updating the Leaflet version and getting this to work properly in the Cape Town Marathon site.
and @boney-bun are you using this for the GeoSAFE legend?

For me it works with Leaflet 1.0.3. I did change the next function by adding map parameter to it:
L.wmsLegend = function (uri, map) {
    var wmsLegendControl = new L.Control.WMSLegend;
    wmsLegendControl.options.uri = uri;
    map.addControl(wmsLegendControl);
    return wmsLegendControl;
};

and then initializing it by:
L.wmsLegend(uri, map);


Update Talao wallet images on wallet stores Apple and Google

https://www.figma.com/file/tKVQz7SeEYUm60vNXNPK4S/Talao-store?node-id=0%3A1

not seen on apple store


Clickable links inside items

What is the best way to support links inside sortable items?
Here's a JSFiddle showing the issue: https://jsfiddle.net/lambdazen/6r7r2cva/7/  -- you can try clicking the links once the page has loaded. It doesn't work. However, a right-click followed by "Open in a new tab" works as expected.
My current workaround is to attach onMouseDown to a call to window.open. Is there a better way?
Thanks in advance! Love your library.

Hey @lambdazen, thanks for the kind words and for providing a fiddle :)
To answer your question, there is a better way. As of 0.0.8, you can pass in a shouldCancelStart function to your enhanced SortableContainer to programatically cancel sorting from triggering based on the event. The default implementation prevent's sorting from being triggered on input, textearea and select elements. Here's an example to prevent links from triggering sorting:
function shouldCancelStart(e) {
	// Cancel sorting if the event target is an anchor tag (`a`)
	if (e.target.tagName.toLowerCase() === 'a') {
		return true; // Return true to cancel sorting
	}
}

You can extend this function any way you see fit to match your use-case :)

Thanks!

A bit late, but i solved the click swallowing by doing this:
`class Something extends Component {
click = false;
onSortEnd = ({oldIndex, newIndex}) => {
if(this.click){
console.log('CLICK')
}else{
console.log('NO CLICK')
}
this.click = false;
};
onSortStart = ({node, index, collection}, event) => {
    this.click = true;
};

onSortMove = (event) => {
    this.click = false;
};

} `


fix: Wheel paths for builds

Proposed Changes:

This was preventing imports of the package.
Checklist

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
I documented my code
I ran pre-commit hooks and fixed any issue

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.764%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
612

Relevant Lines:
626

💛  - Coveralls


I want to add 25 C++ pattern Questions+Solution

Hello, Can you please assign this issue to me?
I know all the pattern problems and answers in C++.
Thanks in advance :)

Hello, Can you please assign this issue to me?

please assign me  I will do a very good pattern solution


Checkbox simple example do not work as expected

This code don't work as expected with me (GUI start, but no Checkboxes icon showed and obviously no clickable area):
kv file
#:kivy 1.9.0

<bbox@CheckBox>
	allow_no_selection: False
	group: "test"

BoxLayout:
	bbox:
	bbox:

python file
""" Application GUI module. """
#Kivy version 1.9.0 x64

# Activate config modules
from kivy.config import Config
Config.set('modules', 'monitor', '')
Config.set('input', 'mouse', 'mouse, disable_multitouch') #disable redcircle when left mouse button is clicked

from kivy.app import App
from kivy.uix.accordion import Accordion, AccordionItem
from kivy.uix.widget import Widget
from kivy.uix.boxlayout import BoxLayout
from kivy.uix.screenmanager import ScreenManager, Screen
from kivy.uix.button import Button
from kivy.uix.checkbox import CheckBox

class testApp(App):
    pass

if __name__ == '__main__':
    testApp().run()

Instead if i change bbox widget instance with the CheckBox basic Widget it works as expected.
Why?
Thanks
p.s.: if i add
	bbox:
		id: tear

It give me an error SynstaxError: invalid syntax on id colon.

PEP8 must be followed for class names in kv https://www.python.org/dev/peps/pep-0008/#class-names.
BBox or Bbox will work.


Add support for Power and Z to image

Description
This PR omits the bundle/manifests/metadata portion (#866) of the changes necessary to support Power and Z on OpenShift, in favor of getting the code/build script changes merged first. This is to allow for multi-arch image infrastructure (registry / image hosting) changes to come online prior to merging any operator bundle/manifest updates.
Change Summary:

Added support for Power and Z architectures to the newly refactored pod mutator webhook
Created a new build script ./hack/build/deploy_rhel.sh which is a RHEL-specific version of the older deploy_local.sh script (this is necessary as building/linking via CGO to alpine musl-libc does not work for Power or Z)
Minor edit to push_image.sh to allow the use of other registries or quay namespaces
Added workaround code (admittedly a hack) specifically for Z/s390x OneAgent installation:

Gracefully handle the condition where ruxitagentproc.conf is missing from the OneAgent zip installer archive
Generate the static contents of ruxitagentproc.conf as they should be reflected for Z/s390x.
Inject tenant-specific connection info (UUID, token, communication site list) into the in-memory process module config to be merged with the statically generated "on disk" config file.

The motivation for this is of joint concern to Dynatrace, Red Hat and IBM to target existing customers running OpenShift on these IBM hardware platforms.
How can this be tested?
Build Requirements
To build this yourself, you'd need the following:

A RHEL 8 VM running natively on Power or Z in order to build the operator (native container-based builds are now possible but not provided with this PR) with the following installed

Go 1.18 installed from go.dev
The following additional RHEL packages: git gcc gcc-c++ make device-mapper-devel golang podman podman-docker gpgme-devel libassuan-devel
Operator SDK v1.16.0+

Build Steps:
With the above installed and running on the local RHEL 8 VM, the deploy_rhel.sh script is called as follows:
$ GOARCH=<s390x|ppc64le> LOCALBUILD=1 \
 IMG=quay.io/orgname/dynatrace-operator TAG=v0.7.0-<arch> \
./hack/build/deploy_rhel.sh

You should now have the operator image built and pushed to the quay repository specified, with the tag that was specified.
Checklist

[ ] Unit tests have been updated/added
[ ] PR is labeled accordingly
[ ] I have read and understood the contribution guidelines

Fixed an error with remnant go:build directives for s390x in ./src/standalone/run.go and rebased against main branch.


Fix custom error types not being visible in records

Purpose
$title
Fixes #21347
Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #21428 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21428   +/-   ##
=======================================
  Coverage   14.64%   14.64%
=======================================
  Files          51       51
  Lines        1400     1400
  Branches      214      214
=======================================
  Hits          205      205
  Misses       1179     1179
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe5d1eb...cef0fc6. Read the comment docs.

This is not just for record fields.
Even the following fails,
public const FOO_REASON = "FooError";

public type FooError error<FOO_REASON>;

public function main() {
    typedesc<error> te = FooError;
}

Shall we update the PR description (and the issue too), and add tests?

Yes, basically custom error typedescs were not working because of this.  The code snippet you mentioned should work with this PR.
I will update the description/issue and add some tests.

@irshadnilam shall we also update the commit message?

@irshadnilam shall we also update the commit message?

Updated the commit message.


Full support of no_std in ibc crate

Part of #1158
Description
~This PR currently uses the branch at informalsystems/tendermint-rs#988 to get rid of the dependency to std::time::SystemTime. Once that is merged, we can merge this for no_std support on the ibc itself.~
~Note that as mentioned in #1158, even though the ibc crate itself now supports no_std, some of its dependencies including tendermint-rs still depend on std.~
Update: The PR now fully supports no_std in the ibc crate.

For contributor use:

[ ] Added a changelog entry, using unclog.
[ ] If applicable: Unit tests written, added test to CI.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

We will wait for the other 2 PRs to be merged first, since changes are still being made there.

This PR now also merges from #1395.

The no-std-check scripts on this branch is finally passing. With this we should have finally managed to remove every single use of std from the ibc crate and all its transitive dependencies.
@DaviRain-Su can you check if this is indeed the case by building it on Substrate?
This is quite a substantial PR, with many pending sub-PRs to be merged first. I cannot guarantee when we will merge this to master and publish the changes, as I also have other high priority tasks to work on. Until then @DaviRain-Su is it fine if you do your development based on this branch?

FIND QUESTION
I ran into some problems testing this branch, just testing that it hadn't been merged with my code.
This is cargo check -p some-crate to test support std

Test case: cargo check -p ibc-relayer

error[E0277]: the trait bound `DecodeError: StdError` is not satisfied
   --> modules/src/ics26_routing/error.rs:9:1
    |
9   | / define_error! {
10  | |     #[derive(Debug, PartialEq, Eq)]
11  | |     Error {
12  | |         Ics02Client
...   |
35  | |     }
36  | | }
    | |_^ the trait `StdError` is not implemented for `DecodeError`
    |
    = note: required because of the requirements on the impl of `ErrorTracer<DecodeError>` for `eyre::Report`
    = note: required because of the requirements on the impl of `ErrorSource<eyre::Report>` for `TraceError<DecodeError>`
note: required because it appears within the type `ics02_client::error::ErrorDetail`
   --> modules/src/ics02_client/error.rs:14:1
    |
14  | / define_error! {
15  | |     #[derive(Debug, PartialEq, Eq)]
16  | |     Error {
17  | |         UnknownClientType
...   |
212 | |     }
213 | | }
    | |_^
note: required because it appears within the type `ics26_routing::error::ErrorDetail`
   --> modules/src/ics26_routing/error.rs:9:1
    |
9   | / define_error! {
10  | |     #[derive(Debug, PartialEq, Eq)]
11  | |     Error {
12  | |         Ics02Client
...   |
35  | |     }
36  | | }
    | |_^
    = note: only the last element of a tuple may have a dynamically sized type
    = note: this error originates in the macro `$crate::define_main_error` (in Nightly builds, run with -Z macro-backtrace for more info)

Test Case: cargo check -p ibc-relayer

error[E0432]: unresolved import `crossbeam_channel::Sender`
 --> relayer/src/config/reload.rs:6:5
  |
6 | use crossbeam_channel::Sender;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^ no `Sender` in the root

error[E0432]: unresolved import `crossbeam_channel::TryRecvError`
 --> relayer/src/rest.rs:1:5
  |
1 | use crossbeam_channel::TryRecvError;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `TryRecvError` in the root

error[E0432]: unresolved imports `crossbeam_channel::Receiver`, `crossbeam_channel::Sender`
 --> relayer/src/supervisor.rs:7:25
  |
7 | use crossbeam_channel::{Receiver, Sender};
  |                         ^^^^^^^^  ^^^^^^ no `Sender` in the root
  |                         |
  |                         no `Receiver` in the root

error[E0432]: unresolved import `crossbeam_channel::Sender`
 --> relayer/src/supervisor/cmd.rs:1:5
  |
1 | use crossbeam_channel::Sender;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^ no `Sender` in the root

error[E0432]: unresolved imports `crossbeam_channel::Receiver`, `crossbeam_channel::Select`
 --> relayer/src/util/recv_multiple.rs:1:25
  |
1 | use crossbeam_channel::{Receiver, Select};
  |                         ^^^^^^^^  ^^^^^^ no `Select` in the root
  |                         |
  |                         no `Receiver` in the root

Test Case: cargo check -p ibc-telemetry

error[E0277]: the trait bound `DecodeError: StdError` is not satisfied
   --> modules/src/ics26_routing/error.rs:9:1
    |
9   | / define_error! {
10  | |     #[derive(Debug, PartialEq, Eq)]
11  | |     Error {
12  | |         Ics02Client
...   |
35  | |     }
36  | | }
    | |_^ the trait `StdError` is not implemented for `DecodeError`
    |
    = note: required because of the requirements on the impl of `ErrorTracer<DecodeError>` for `eyre::Report`
    = note: required because of the requirements on the impl of `ErrorSource<eyre::Report>` for `TraceError<DecodeError>`
note: required because it appears within the type `ics02_client::error::ErrorDetail`
   --> modules/src/ics02_client/error.rs:14:1
    |
14  | / define_error! {
15  | |     #[derive(Debug, PartialEq, Eq)]
16  | |     Error {
17  | |         UnknownClientType
...   |
212 | |     }
213 | | }
    | |_^
note: required because it appears within the type `ics26_routing::error::ErrorDetail`
   --> modules/src/ics26_routing/error.rs:9:1
    |
9   | / define_error! {
10  | |     #[derive(Debug, PartialEq, Eq)]
11  | |     Error {
12  | |         Ics02Client
...   |
35  | |     }
36  | | }
    | |_^
    = note: only the last element of a tuple may have a dynamically sized type
    = note: this error originates in the macro `$crate::define_main_error` (in Nightly builds, run with -Z macro-backtrace for more info)

Test Case: cargo check -p ibc-relayer-cli
SUCCESS
Test Case: cargo check -p ibc-relayer-rest
SUCCESS
Test Case: cargo check -p ibc-proto
SUCCESS

This is cargo check -p some-crate --no-default-featurtes to test support no_std

Test Case: cargo check -p ibc --no-default-features
SUCCESS
Test Case: cargo check -p ibc-relayer --no-default-features

error[E0432]: unresolved import `crossbeam_channel::Sender`
 --> relayer/src/config/reload.rs:6:5
  |
6 | use crossbeam_channel::Sender;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^ no `Sender` in the root

error[E0432]: unresolved import `crossbeam_channel::TryRecvError`
 --> relayer/src/rest.rs:1:5
  |
1 | use crossbeam_channel::TryRecvError;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `TryRecvError` in the root

error[E0432]: unresolved imports `crossbeam_channel::Receiver`, `crossbeam_channel::Sender`
 --> relayer/src/supervisor.rs:7:25
  |
7 | use crossbeam_channel::{Receiver, Sender};
  |                         ^^^^^^^^  ^^^^^^ no `Sender` in the root
  |                         |
  |                         no `Receiver` in the root

error[E0432]: unresolved import `crossbeam_channel::Sender`
 --> relayer/src/supervisor/cmd.rs:1:5
  |
1 | use crossbeam_channel::Sender;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^ no `Sender` in the root

error[E0432]: unresolved imports `crossbeam_channel::Receiver`, `crossbeam_channel::Select`
 --> relayer/src/util/recv_multiple.rs:1:25
  |
1 | use crossbeam_channel::{Receiver, Select};
  |                         ^^^^^^^^  ^^^^^^ no `Select` in the root
  |                         |
  |                         no `Receiver` in the root

Test Case: cargo check -p ibc-relayer-cli --no-default-features
SUCCESS
Test Case: cargo check -p ibc-relayer-rest --no-default-features
SUCCESS
Test Case: cargo check -p ibc-telemetry --no-default-features

error[E0277]: the trait bound `DecodeError: StdError` is not satisfied
   --> modules/src/ics26_routing/error.rs:9:1
    |
9   | / define_error! {
10  | |     #[derive(Debug, PartialEq, Eq)]
11  | |     Error {
12  | |         Ics02Client
...   |
35  | |     }
36  | | }
    | |_^ the trait `StdError` is not implemented for `DecodeError`
    |
    = note: required because of the requirements on the impl of `ErrorTracer<DecodeError>` for `eyre::Report`
    = note: required because of the requirements on the impl of `ErrorSource<eyre::Report>` for `TraceError<DecodeError>`
note: required because it appears within the type `ics02_client::error::ErrorDetail`
   --> modules/src/ics02_client/error.rs:14:1
    |
14  | / define_error! {
15  | |     #[derive(Debug, PartialEq, Eq)]
16  | |     Error {
17  | |         UnknownClientType
...   |
212 | |     }
213 | | }
    | |_^
note: required because it appears within the type `ics26_routing::error::ErrorDetail`
   --> modules/src/ics26_routing/error.rs:9:1
    |
9   | / define_error! {
10  | |     #[derive(Debug, PartialEq, Eq)]
11  | |     Error {
12  | |         Ics02Client
...   |
35  | |     }
36  | | }
    | |_^
    = note: only the last element of a tuple may have a dynamically sized type
    = note: this error originates in the macro `$crate::define_main_error` (in Nightly builds, run with -Z macro-backtrace for more info)

Test Case: cargo check -p ibc-proto --no-default-features
SUCCESS

SUMMARY
Some of my conclusions, when modifying the features that support no_std, should also keep the original std features is no problem.

@soareschen Hi, I'm having some problems integrating ibc-rs to substrate-ibc, can you help take a look at it?
This is occur error:
error[E0512]: cannot transmute between types of different sizes, or dependently-sized types
  --> primitives/runtime-interface/src/impls.rs:44:1
   |
44 | assert_eq_size!(usize, u32);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: source type: `usize` (64 bits)
   = note: target type: `u32` (32 bits)
   = note: this error originates in the macro `assert_eq_size` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0512]: cannot transmute between types of different sizes, or dependently-sized types
  --> primitives/runtime-interface/src/impls.rs:46:1
   |
46 | assert_eq_size!(*const u8, u32);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: source type: `*const u8` (64 bits)
   = note: target type: `u32` (32 bits)
   = note: this error originates in the macro `assert_eq_size` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0512`.
error: could not compile `sp-runtime-interface` due to 2 previous errors

Some other issues are that some libraries don't seem to support no-std, but you also added the default-features = false switch. For example: tendermint-rs introduces some carate: async-trait, serde_repr, zeroize, num-derive, etc., and one is not to write pallet like in substrate to support no-std in ibc-rs and tendermint-rs. std, here is an article you can look at: https://justjjy.com/Rust-no-std

The error seems to come from sp-runtime-interface, which is not used by ibc-rs or tendermint-rs. I probably ran into similar issue before, and you might want to check if you are using the latest nightly version of Rust. Otherwise you could try nightly-2021-09-01 which should compile successfully.

Related issue: https://github.com/paritytech/substrate/issues/10111

Now, for substrate-ibc can  run this command test pass no-std support: cargo check -p pallet-ibc --no-default-features  --target wasm32-unknown-unknown

Superceded by #1846.