chore: support for turning off auto heal

Fixes #235
Modifications
This PR supports to turn off auto heal if it is configured so.
Verification
Tested in a local cluster with autoHealTimeIntervalMs not set.  Auto heal is off so the syncing is skipped if no new changes.

So, I'm good if it's a separate issue, but as we discussed offline, what do you think about our changing this:
	SyncTimeIntervalMs     int    `json:"syncTimeIntervalMs" mapstructure:"syncTimeIntervalMs"`
	AutoHealTimeIntervalMs int    `json:"autoHealTimeIntervalMs" mapstructure:"autoHealTimeIntervalMs"`

to:
	SyncTimeIntervalMs     int    `json:"syncTimeIntervalMs" mapstructure:"syncTimeIntervalMs"`
        AutoHealEnabled bool  `json:"autoHealEnabled" mapstructure:"autoHealEnabled"`

(I know originally, the bool was in there and I asked to remove it, but I think both of the other fields were as well, and it seems like we are really only using one time interval, right?)

So, I'm good if it's a separate issue, but as we discussed offline, what do you think about our changing this:
	SyncTimeIntervalMs     int    `json:"syncTimeIntervalMs" mapstructure:"syncTimeIntervalMs"`
	AutoHealTimeIntervalMs int    `json:"autoHealTimeIntervalMs" mapstructure:"autoHealTimeIntervalMs"`

to:
	SyncTimeIntervalMs     int    `json:"syncTimeIntervalMs" mapstructure:"syncTimeIntervalMs"`
        AutoHealEnabled bool  `json:"autoHealEnabled" mapstructure:"autoHealEnabled"`

(I know originally, the bool was in there and I asked to remove it, but I think both of the other fields were as well, and it seems like we are really only using one time interval, right?)

Sounds good, let me do it in another PR. Thanks!

So, I'm good if it's a separate issue, but as we discussed offline, what do you think about our changing this:
	SyncTimeIntervalMs     int    `json:"syncTimeIntervalMs" mapstructure:"syncTimeIntervalMs"`
	AutoHealTimeIntervalMs int    `json:"autoHealTimeIntervalMs" mapstructure:"autoHealTimeIntervalMs"`

to:
	SyncTimeIntervalMs     int    `json:"syncTimeIntervalMs" mapstructure:"syncTimeIntervalMs"`
        AutoHealEnabled bool  `json:"autoHealEnabled" mapstructure:"autoHealEnabled"`

(I know originally, the bool was in there and I asked to remove it, but I think both of the other fields were as well, and it seems like we are really only using one time interval, right?)

Sounds good, let me do it in another PR. Thanks!

thanks!


Add 2end Copy from boomerang.js with the Name inspectit.js

Close #748

This change is

Thanks for the contribution @mc-chaos
But we think that providing multiple boomerang files with different names is not the best solution for this problem. Because we have the same file(s) multiple time and we are again bound to the specified name.
We would rather do it the way you already suggested in the ticket - providing a configuration option to set an alias for the file.

We will go an other way


Convolution algorithm

I understand your algorithm and implementation for 2d convolution using shift register based concept. Do you think this concept can be applied for 3d convolution ?

The concepts explained in this tutorial (stride, padding, ..) are not specific to 2D convolutions and can be directly applied to higher dimensional convolutions. Similarly, the code could in principle be extended to cover 3D convolutions. This goes beyond the scope of this guide though, as it would make it much more complicated without adding much information.


Converting SDXL based models locally failed with "no attribute 'text_encoder_2'

I tried to convert SDXL based model, ex: "DreamShaperXL_10_alpha2XL10", "sdvn6Realxl_detailface", using below command:
python -m python_coreml_stable_diffusion.torch2coreml --convert-text-encoder --model-version dreamshaperXL10_alpha2Xl10_diffusers -o dreamshaperXL10_alpha2Xl10_split_einsum --xl-version

I have already converted text_encoder, unet, vae_encoder, vae_decoder, so I only use --convert-text-encoder and want to convert the text_encoder_2 only.
INFO:__main__:Converting text_encoder_2
Traceback (most recent call last):
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/Users/kyd620acer/Downloads/ml-stable-diffusion-main/python_coreml_stable_diffusion/torch2coreml.py", line 1441, in <module>
    main(args)
  File "/Users/kyd620acer/Downloads/ml-stable-diffusion-main/python_coreml_stable_diffusion/torch2coreml.py", line 1286, in main
    convert_text_encoder(pipe.text_encoder_2, pipe.tokenizer_2, "text_encoder_2", args)
  File "/Users/kyd620acer/Downloads/ml-stable-diffusion-main/coreml/lib/python3.9/site-packages/diffusers/configuration_utils.py", line 137, in __getattr__
    raise AttributeError(f"'{type(self).__name__}' object has no attribute '{name}'")
AttributeError: 'StableDiffusionPipeline' object has no attribute 'text_encoder_2'

BTW, if no "text_encoder_2" the image generating seems also working, right? So what is text_encoder_2 for?

Hello @TimYao18, is --model-version dreamshaperXL10_alpha2Xl10_diffusers supposed to point to https://huggingface.co/jayparmr/DreamShaper_XL1_0_Alpha2/tree/main or is it a local custom model that you have made?
If the former, It looks like this model only has a UNet checkpoint and nothing else. I assume that the authors would like you to use the text_encoder and text_encoder_2 from the base SDXL model and only replace the Unet model with their custom version but please confirm with the model owner.

text_encoder_2 is required for SDXL pipelines in the current implementation (in addition to text_encoder)

Hello @TimYao18, is --model-version dreamshaperXL10_alpha2Xl10_diffusers supposed to point to https://huggingface.co/jayparmr/DreamShaper_XL1_0_Alpha2/tree/main or is it a local custom model that you have made?

It is a local custom model in diffuser format converted from checkpoint.

Got it! Same comments apply

OK. I tried another XL model (sdvn6) seems OK. So I close this issue.

OK. I tried another XL model (sdvn6) seems OK. So I close this issue.
@TimYao18 May I ask if you have solved this problem？ i got same error , i have tested sdvn6 is ok. But other XL base  fine tune model will report an error .

OK. I tried another XL model (sdvn6) seems OK. So I close this issue.
@TimYao18 Have you solved this problem？ i got same error , i have tested sdvn6 is ok. But other XL base  fine tune model will report an error .

Hi @jiangdi0924
I tried dreamshaperXL and did not work.
Today the project is updated and works fine. Maybe you can try it.

Since the upgrade to version 1.1 many SDXL models can be converted. Recently I found that there are still some SDXL models that cannot be converted. For example: https://civitai.com/models/125703/protovision-xl-high-fidelity-3d-photorealism-anime-hyperrealism-no-refiner-needed
ERROR：
 File "/Users/Norton/MyTestProject/ml-stable-diffsuion-main-20230912/python_coreml_stable_diffusion/torch2coreml.py", line 1524, in <module>     main(args)   File "/Users/Norton/MyTestProject/ml-stable-diffsuion-main-20230912/python_coreml_stable_diffusion/torch2coreml.py", line 1319, in main     convert_vae_decoder(pipe, args)   File "/Users/Norton/MyTestProject/ml-stable-diffsuion-main-20230912/python_coreml_stable_diffusion/torch2coreml.py", line 519, in convert_vae_decoder     coreml_vae_decoder, out_path = _convert_to_coreml(                                    ^^^^^^^^^^^^^^^^^^^   File "/Users/Norton/MyTestProject/ml-stable-diffsuion-main-20230912/python_coreml_stable_diffusion/torch2coreml.py", line 124, in _convert_to_coreml     coreml_model = ct.convert(                    ^^^^^^^^^^^   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/_converters_entry.py", line 551, in convert     mlmodel = mil_convert(               ^^^^^^^^^^^^   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/converter.py", line 188, in mil_convert     return _mil_convert(model, convert_from, convert_to, ConverterRegistry, MLModel, compute_units, **kwargs)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/converter.py", line 212, in _mil_convert     proto, mil_program = mil_convert_to_proto(                          ^^^^^^^^^^^^^^^^^^^^^   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/converter.py", line 286, in mil_convert_to_proto     prog = frontend_converter(model, **kwargs)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/converter.py", line 108, in __call__     return load(*args, **kwargs)            ^^^^^^^^^^^^^^^^^^^^^   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/load.py", line 75, in load     return _perform_torch_convert(converter, debug)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/load.py", line 114, in _perform_torch_convert     prog = converter.convert()            ^^^^^^^^^^^^^^^^^^^   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/converter.py", line 484, in convert     convert_nodes(self.context, self.graph)   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/ops.py", line 93, in convert_nodes     add_op(context, node)   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/ops.py", line 6219, in scaled_dot_product_attention     q, k, v, attn_mask, dropout, is_causal = _get_inputs(context, node, expected=6)                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/ops.py", line 204, in _get_inputs     raise ValueError( ValueError: node hidden_states.11 (scaled_dot_product_attention) got 7 input(s), expected [6]

Since the upgrade to version 1.1 many SDXL models can be converted. Recently I found that there are still some SDXL models that cannot be converted. For example: https://civitai.com/models/125703/protovision-xl-high-fidelity-3d-photorealism-anime-hyperrealism-no-refiner-needed
ERROR：  File "/Users/Norton/MyTestProject/ml-stable-diffsuion-main-20230912/python_coreml_stable_diffusion/torch2coreml.py", line 1524, in <module> main(args) File "/Users/Norton/MyTestProject/ml-stable-diffsuion-main-20230912/python_coreml_stable_diffusion/torch2coreml.py", line 1319, in main convert_vae_decoder(pipe, args) File "/Users/Norton/MyTestProject/ml-stable-diffsuion-main-20230912/python_coreml_stable_diffusion/torch2coreml.py", line 519, in convert_vae_decoder coreml_vae_decoder, out_path = _convert_to_coreml( ^^^^^^^^^^^^^^^^^^^ File "/Users/Norton/MyTestProject/ml-stable-diffsuion-main-20230912/python_coreml_stable_diffusion/torch2coreml.py", line 124, in _convert_to_coreml coreml_model = ct.convert( ^^^^^^^^^^^ File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/_converters_entry.py", line 551, in convert mlmodel = mil_convert( ^^^^^^^^^^^^ File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/converter.py", line 188, in mil_convert return _mil_convert(model, convert_from, convert_to, ConverterRegistry, MLModel, compute_units, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/converter.py", line 212, in _mil_convert proto, mil_program = mil_convert_to_proto( ^^^^^^^^^^^^^^^^^^^^^ File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/converter.py", line 286, in mil_convert_to_proto prog = frontend_converter(model, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/converter.py", line 108, in __call__ return load(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/load.py", line 75, in load return _perform_torch_convert(converter, debug) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/load.py", line 114, in _perform_torch_convert prog = converter.convert() ^^^^^^^^^^^^^^^^^^^ File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/converter.py", line 484, in convert convert_nodes(self.context, self.graph) File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/ops.py", line 93, in convert_nodes add_op(context, node) File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/ops.py", line 6219, in scaled_dot_product_attention q, k, v, attn_mask, dropout, is_causal = _get_inputs(context, node, expected=6) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/Norton/miniforge3/envs/ml-stable-diffusion-main20230912/lib/python3.11/site-packages/coremltools/converters/mil/frontend/torch/ops.py", line 204, in _get_inputs raise ValueError( ValueError: node hidden_states.11 (scaled_dot_product_attention) got 7 input(s), expected [6]

pip install torch==2.0.1 torchvision   fixed


get reward method optimization

tzkt has a new api endpoint - https://api.tzkt.io/v1/rewards/delegators/{address}?cycle
integration will be more efficient and lower code quantity

endpint ends up returning data about the baker and does not give data for actual received rewards for the delgator. Original get rewards is optimal. One adjustment made for weird payload values where a subset of the reward payout values are scaled down by 10,000 units.


Fix right-edge padding on code blocks

Fixes #169
Before:

After:

I already see them alright https://gatsby-theme-iterative-example.herokuapp.com/doc/start/experiments.

Seems to be a Firefox-only issue, prod works for me in chrome but has the bug on firefox

The current implementation is breaking that instead.

I pushed this up before signing off for the night, I forgot a commit that fixes that. My apologies!


🐛 明细表 SheetComponent 的 onDataCellClick 事件响应错误

🏷 Version

Package
Version

@antv/s2
1.3.0

@antv/s2-react
1.3.0

🖋 Description

明细表 SheetComponent 的 onDataCellHover 无法触发,

alpha 分支 的 组件层已经重构, 需要检查是否也有这个问题 ref: https://github.com/antvis/S2/pull/869
⌨ Code Snapshots

🔗 Reproduce Link
🤔 Steps to Reproduce

😊 Expected Behavior
😅 Current Behavior
💻 System information

:tada: This issue has been resolved in version @antv/s2-react-v1.4.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version @antv/s2-react-v1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Started getting failures in build pipeline.

I've recently started getting the following errors in my build commands from this library on my local dev environment.
Apple M1 Max
Ventura 13.4.1
~Works fine in my gitlab actions though. Any suggestions ?~
Now started failing in my gitlab runners also
error[E0412]: cannot find type `RawFd` in `std::os::fd`
 --> /Users/dstorey/.cargo/registry/src/github.com-1ecc6299db9ec823/jobserver-0.1.27/src/error.rs:2:27
  |
2 | type RawFd = std::os::fd::RawFd;
  |                           ^^^^^ not found in `std::os::fd`
  |
help: consider importing this type alias
  |
1 | use std::os::unix::prelude::RawFd;
  |
help: if you import `RawFd`, refer to it directly
  |
2 - type RawFd = std::os::fd::RawFd;
2 + type RawFd = RawFd;
  |

error[E0603]: module `fd` is private
 --> /Users/dstorey/.cargo/registry/src/github.com-1ecc6299db9ec823/jobserver-0.1.27/src/error.rs:2:23
  |
2 | type RawFd = std::os::fd::RawFd;
  |                       ^^ private module
  |
note: the module `fd` is defined here

See https://github.com/rust-lang/jobserver-rs/pull/59. You might want to upgrade your Rust toolchain.

That worked, thank you.


[feature request ]time convert

What's the Problem?
some times need to convert Unix time  from second or millisecond to calendar time (YYYY-MM-DD hh:mm:ss)
Solution/Idea
just add one component for time convert (optinonal format)
Alternatives

Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

DevToys Version
version <IP_ADDRESS> | X64 | RELEASE | 232b783 | 232b783
Comments
this dev toys help new coders a lot. Thank you author

Duplicate with #106


Config options to blacklist blocks from harvest tool enforcement rule

Twigs and Pebbles from the Mod Twigs cannot be picked up, it would be nice to have a config option to blacklist certain blocks from the harvest tool rules

you can disable some blocks from the harvest tool rules by datapacks.
just put the block you want to disable in the "IGNORED_WOOD_BLOCKS" or "IGNORED_STONE_BLOCKS" file


maybe my code is wrong but possible to provide some suggestions why this is so?

attached issues. if long running processes will get this "error", which uses a lot of memory and doesnt really free up.
with cpu thrashing in the background

it's other issues.

attached issues. if long running processes will get this "error", which uses a lot of memory and doesnt really free up. with cpu thrashing in the background

I suggest exporting a flame graph of the heap for analysis.


Add timer to PIN & logout after 25 attempts.

25 attempts seems a bit high. Why not 5 or 10 instead?

As it is made in the native Android:

After every 5 attempts, it will be blocked for 30 seconds.
After a total 25 attempts app will be forced to log out.


Load correctly the delegated Targets objects hierarchy

Fixes issue #: #1045
Description of the changes being introduced by the pull request:

Update load_repository() function to load the delegations metadata starting from 'targets' and traversing downwards the delegated roles in order to load correctly the delegations hierarchy.
Improve readability by extracting the loading of metadata_directory files in a separate function get_delegations_filenames() in a similar way in which top level metadata files are loaded by get_metadata_filenames().
Update test_load_repository.

Please verify and check that the pull request fulfills the following
requirements:

[ ] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

💯, 🎉, 🥳, @sechkova!!

I have just one concern: how does this handle the possibility that Alice and Bob may delegate to Charlie using different sets and thresholds of keys from each other?

@trishankatdatadog, the current reference implementation already does not support such "promiscuous" delegations (see #589 and for a more general description of the issue #660).
Supporting that behavior is way out of the scope of #1045.

"promiscuous" delegations

Got it. Gods, I hate that term, let's find another name, please...

"promiscuous" delegations

Got it. Gods, I hate that term, let's find another name, please...

Agreed. Promiscuous has negative connotations.
In theupdateframework/specification#96 Marina used the term multi-role delegations

In theupdateframework/specification#96 Marina used the term multi-role delegations

Thanks, Josh. I don't think the problem is specific to multi-role delegations. I believe the idea is that Alice and Bob, on entirely different parts of the graph, can delegate to Charlie using entirely different thresholds and keys. I don't know what's a good, succinct word for this, except to say something like "delegator-dependent keys for a delegatee" (rolls off the tongue, I know).

Yes, multi-role delegations as described in TAP 3 are something else. It's a one-to-many delegation where the delegated-to roles need to agree on a target.
Promiscuous delegations are many-to-many delegations.

This looks good to me. There's some nice clean-ups of the modified code in here too, thanks @sechkova

Teodora is very good!

f1a6676 : Amended with an extended comment about the deque usage and a warning in case of a cycle in the graph
97eff9e : Discard the dictionary used for temporary storing new_targets_objects and reference them by the parent_targets_object instead
6ae3ea6 : cherry-picked 7100dc3


[Update] Existing Visualization and Improvements.

Descriptions
Improve the current visualization with more eye-catching details and improvements. Feel free to experiment with more visualizations.

I would like to work on this issue. Please assign this task to me

I will assign the task after program launch which is 7pm IST tomorrow.

I'm interested in tackling this issue. Kindly assign the task to me.

I am interested in this issue please assign it to me.

Kindly assign the task to me.

Please assign to me under GSSoC'24

all of you can work and assign the pull request to me.  I have added the labels.

please assign this issue to me for GSSoc'24

As a newcomer to open-source, I'm uncertain about whether we should use sample data or obtain real data from Stack Overflow. Could you please provide some guidance on the best approach?

I am passionate to work on visualizations , would be glad to get this assigned to me.

Hi @sanjay-kv , I want to work on this issue for GSSOC'24. Kindly allow me to work on this as well .

hi @sanjay-kv , I want to work for the issue . Kindly assign me this issue

I can only assign upto 10 people at the moment, you can create a new issue which you feel like to add. I will add the label and you can work on it

@sanjay-kv Sir, I have created a pull request. Please review it.

@sanjay-kv  , I have created the pull request , please review it and consider me tp solve this issue

Hi @sanjay-kv sir i would like to work upon this ,please assign me this issue

@sanjay-kv , I have created the pull request , please review it and consider me tp solve this issue

Just make sure don't work on issue until its assigned to you. Issue will be assigned to Only 1 person ...FCFS basis. Others get a chance if the issue gets stale & the assignee is inactive for 5+ days
Also if you would like to work on more issue create a new issue and I will create label and assign you.

pls assign me the issue,i have prior experience with the model.


Error Connection errored out.

Reminder

[X] I have read the README and searched the existing issues.

Reproduction
After running webui.py, I enter the web page, but all modules are reporting errors. After I randomly adjusted a language, the modules on the page returned to normal. However, when I clicked "Start" or other modules, such as "Preview Command", etc., an error was still reported and could not be started. The pop-up window displayed "Error Connection errored out. ". I checked that it was not a problem of insufficient GPU, and I tried. My Alibaba Cloud server is in Singapore. I don’t know if it is a problem here. In short, the entire page reports an error and fine-tuning cannot be started.

Expected behavior
I hope I can start fine-tuning smoothly without reporting connection errors.
System Info
No response
Others
No response

When I click start, the terminal prompts: /bin/sh: 1: llamafactory-cli: not found

please refer https://github.com/hiyouga/LLaMA-Factory?tab=readme-ov-file#fine-tuning-with-llama-board-gui-powered-by-gradio , alibaba special config is included.
And refer https://github.com/hiyouga/LLaMA-Factory?tab=readme-ov-file#fine-tuning-with-llama-board-gui-powered-by-gradio to install this pakcage to get llamafactory-cli installed

Install llama factory with these commands: https://github.com/hiyouga/LLaMA-Factory?tab=readme-ov-file#installation


Display color in preview differs from terminal

Hi, the display color in preview and editor somehow differs from terminal.

In the screen shot, green 32 is somehow more brighter in editor/preview than in the terminal. Is there some setting I can make the editor color same as terminal?
Thanks!

Hey @haozhouamzn,
is the option "vt100.use-native-theme": false, present in your configuration file?
By default it should be set to true and synchronize the colors with the terminal.
Best Regards,
Tobias Faller

@TobiasFaller Tried both true and false, no difference.
It seems the issue is with light themes. I'm using "workbench.colorTheme": "Quiet Light".
If I switch to dark themes, the colors are the same in terminal & editor.


[stable/fluent-bit] output configmap when using extraEntries.output is malformed

Is this a request for help?: No

Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug Report

Version of Helm and Kubernetes: Helm v2.11.0, Kubernetes v1.9.11
Which chart: stable/fluent-bit
What happened:
Adding output configuration to values.yaml extraEntries.output, and then running helm template produces a malformed fluentbit output configuration:
Input in values.yaml:
extraEntries:
    output: |-
        [OUTPUT]
          Name        azure
          Match       *
          Customer_ID workspaceid
          Shared_Key  secretkey

Output in fluent-bit configmap from helm template
  fluent-bit-output.conf: |-

    [OUTPUT]
        Name          forward
        Match         *
        Host          fluentd
        Port          24284
        Retry_Limit False

        [OUTPUT]
          Name        azure
          Match       *
          Customer_ID workspaceid
          Shared_Key  secretkey

As seen above, the azure plugin configuration is indented too much, causing fluent-bit containers to crash on start due to the malformed configuration:
Fluent Bit v1.0.4
Copyright (C) Treasure Data

[2019/02/11 19:09:41] [  Error] File fluent-bit-output.conf
[2019/02/11 19:09:41] [  Error] Error in line 9: Each key must have a value

What you expected to happen:
The configmap output by helm template should contain the correct indentation, and thus a correct config:
  fluent-bit-output.conf: |-

    [OUTPUT]
        Name          forward
        Match         *
        Host          fluentd
        Port          24284
        Retry_Limit False

    [OUTPUT]
        Name        azure
        Match       *
        Customer_ID workspaceid
        Shared_Key  secretkey

How to reproduce it (as minimally and precisely as possible):

Fetch the stable/fluent-bit chart
Modify the values.yaml file to include an extra output entry:

extraEntries:
  output: |-
    [OUTPUT]
      Name        azure
      Match       *
      Customer_ID workspaceid
      Shared_Key  secretkey

Run helm template . > test.yaml and observe the malformed configuration
Run kubectl apply -f test.yaml to apply helm template
Run kubectl logs -lapp=fluent-bit to view logs from fluent bit containers:

Fluent Bit v1.0.4
Copyright (C) Treasure Data

[2019/02/11 19:09:41] [  Error] File fluent-bit-output.conf
[2019/02/11 19:09:41] [  Error] Error in line 9: Each key must have a value

Anything else we need to know:

We had a big discussion/reimplementation about this a while ago. We finally settled on:
extraEntries is for adding additional lines to the existing things.
rawConfig is for adding as many additional sections as you want.
So it is working as intended.

I've confirmed that using rawConfig does work, so I'll close this issue out. Thanks for the pointer.


Restore previous timeout after server started

@iler you should configure credentials in Travis CI so the tests can be run

@Jalle19 as this is a PR outside of the organization it does not allow the use of secret environment variables in the tests as explained here https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions. So those are configured there but can not be used in this PR.

@iler ah, didn't know about that restriction!


[ Wait for #2468 ] [ rename/neon ] Fix neon-related functions name

Every neon function resides in nntrainer::neon namespace, no need to be differentiated
's' in BLAS functions indicates the function works with single-precision (fp32). Incase of half-precision functions we should use 'h' instead of 's'
In case of previous functions like : 'scopy_fp32_to_fp16', the function name itself shows the dataType it gets, so no need to add neither 's' nor 'h'
There are more rooms for this, but still WIP

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2470. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Although we can check the description on header file it would be nice to know the function meaning by its name so how about we name as like el_vec_add? Or how about we remove prefix "elementwise"? overall LGTM

Think it would be better to do it while fixing function names in blas_interface.h. This requires some trivial code fixes in tensor.cpp as well, so will do it in the next PR


when i tried downloading it, the scan is telling that it had detected a virus

the scan in chrome in particular

Same for Windows defender, quite weird

See #7


Evidence.py/ElementTree.py error

When running a file with the following code:
import PyOpenWorm as P
P.connect()
ev = P.Evidence(pmid='21177967')
print(ev)

I mostly get this:
Traceback (most recent call last):
  File "mytest.py", line 4, in <module>
    ev = P.Evidence(pmid='21177967')
  File "/Users/claus/workspace/OpenWorm/PyOpenWorm/PyOpenWorm/evidence.py", line 263, in __init__
    self._pubmed_extract()
  File "/Users/claus/workspace/OpenWorm/PyOpenWorm/PyOpenWorm/evidence.py", line 363, in _pubmed_extract
    tree = pmRequest(pmid)
  File "/Users/claus/workspace/OpenWorm/PyOpenWorm/PyOpenWorm/evidence.py", line 356, in pmRequest
    return ET.parse(_url_request(url))
  File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1182, in parse
    tree.parse(source, parser)
  File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 647, in parse
    source = open(source, "rb")
IOError: [Errno 2] No such file or directory: ''

I'm not sure if it's a problem on my side, but the thing is, the error doesn't always appear. The whole thing just decides to occasionally pass once in a (very long) while (no changes whatsoever to the code being run).

Related to #210

Closing this as a duplicate of #210 .

Considering the errors in this one and #210 are different, was it a duplicate?

@mwatts15 So should PR #250 fix this as well?

Hmm, looking again, it was premature to mark as a duplicate.
@signija can you try #250? Also, have you tried with other PMIDs? If this only happens periodically, it probably has to do with the call to Pubmed for the authors list. If that's failing, the solution is probably better error reporting.

@mwatts15 Yeah, it does that with all PMIDs. This is what happens most of the time, it's very rarely that it didn't show me this error and I could actually debug it for the issue in #210 . When it works, it's always temporary, for a couple of runs only, and then it goes back to this error.

It's almost definitely an Internet connection issue. When I cut off my wifi, I get the same thing. PyOpenWorm/evidence.py:273: in init
self._pubmed_extract()
PyOpenWorm/evidence.py:374: in _pubmed_extract
data, tree = pmRequest(pmid)
PyOpenWorm/evidence.py:367: in pmRequest
return s, ET.parse(s)
/usr/lib/python2.7/xml/etree/ElementTree.py:1182: in parse
tree.parse(source, parser)
self = <xml.etree.ElementTree.ElementTree object at 0x7fe12ccdbd90>, source = '', parser = None
def parse(self, source, parser=None):
    close_source = False
    if not hasattr(source, "read"):

      source = open(source, "rb")

E           IOError: [Errno 2] No such file or directory: ''
/usr/lib/python2.7/xml/etree/ElementTree.py:647: IOError

We can close this with a clear warning-level log message to the effect of "Could not retrieve data from PubMed". As for moving the retrieval of to another method, this work can be done independently and either this ticket or #280 can merge without much trouble.


docs: update version in pre-commit hook

Ciao! Didn't open an issue for this as it seemed straightforward. I know you suggest the users to update the hook version, but I figured it wouldn't be bad to update from time to time.
This pull request consists of an update to the documentation to reflect the latest version of zizmor in the suggested pre-commit-config file.

docs/usage.md: Updated the version of the zizmor repository from v0.1.6 to v0.3.0 in the .pre-commit-config.yaml file.

Longer-term, we should keep this example updated like we do with zizmor --help, via a snippet: https://github.com/woodruffw/zizmor/blob/ec24c60280bad9d3ff78212da805c6f4e247acf0/docs/quickstart.md?plain=1#L7-L9
But that's a separate concern 🙂

Thanks @baggiponte!

Longer-term, we should keep this example updated like we do with zizmor --help, via a snippet:
https://github.com/woodruffw/zizmor/blob/ec24c60280bad9d3ff78212da805c6f4e247acf0/docs/quickstart.md?plain=1#L7-L9
But that's a separate concern 🙂

I did not know about this trick!

Thanks @baggiponte!

De nada, always a pleasure. Amazing work with the tool - I don't really remember how I found out about it, but since I know so frighteningly little about GHA (despite running a bunch of them) it immediately ended up in my precommit config 🤣


AR doesn't workion chrome for iOS

Description
The title says it all, AR doesn't work as it should on chrome for iOS.  For android, all is as usual. And in Safari AR works for iOS too, but not on chrome, quick-look is started after a few minutes if it is started all.
On Firefox, quick-look is opening quite slow too.
Live Demo
link of the webpage: https://viewarly.com/arplacement?slug=beckholmen-briefcase-2
Version

model-viewer: v1.7.2

Browser Affected

[x] Chrome, version: 90.0.4430.216
[ ] Edge
[x] Firefox version: 33.1 (4629)
[ ] IE
[ ] Safari

OS

[ ] Android
[x] iOS  14.5.1
[ ] Linux
[ ] MacOS
[ ] Windows

AR

[ ] WebXR
[ ] SceneViewer
[x] QuickLook

@romanexceed we are having same problem too and also when we try on modelviewer.dev nothing happen after tapping ar-button. It just reload model-viewer.
Chrome version 90.0.4430.216
model-viewer 1.7.2

Closing the issue as it has already been reported here: https://github.com/google/model-viewer/issues/2263

Reopening since #2263 doesn't have a functional repro link anymore.

Any updates on this? (with much shyness)

I filed a bug on iOS Chrome a while back: https://bugs.chromium.org/p/chromium/issues/detail?id=1197345
Please ping them there to help get it prioritized.

Has the Chrome iOS bug been resolved since July?

This is still a serious bug. After recommending users to use Chrome on iOS for best experience, I'm now having to send them to Safari again. It's seems to be a Chrome issue, but one best fixed with collaboration with the model-viewer team.

Same problem. Any update with chrome ios?
Thanks!

We have noticed that we are able to enter an AR experience on Chrome on iOS, but upon returning to the browser, all scrolling is broken - even after a hard refresh. The only thing that works is opening a new tab.

@nobleach Hmm, that sounds like a new and different iOS Chrome problem. Would you mind filing a Chromium bug and linking it here?

@elalish I certainly can. Thank you.

I think this has been fixed by the Chrome team now.


integrate this with labelstudio

If possible then please integrate this repo with labelstudio because there are lots of other things  that they have got it right.

There exist many such tools (CVAT is the tool of choice in my lab). Understanding their large codebase and integrating it with their UI elements and flow is a lot of work.
I made this tool in a couple days for my weekly lab meeting. :) This code is MIT licensed, so feel free to borrow elements for labelstudio if you are a core developer.


Hot key Conflict of V 7.0's Peek  with windows system hotkey

Microsoft PowerToys version
0.70.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
Peek
Steps to reproduce
The peek function registered  a hotkey is ctrl+space ,I think it's a very important hotkey of system level that be used to swtich input method of chinese and other languages.
And ,its be opend default? After I update the power toys to 7.0 I found that the hotkey is useless , after hours trouble shooting of windows setting, input method software, I found it's he reason.
I think the devoplover should change this hotkey or setting the default state is off like others new funciton.
✔ Expected Behavior
Hot key ctrl+space is switching the input method on/off
❌ Actual Behavior
Nothing happer after update 7.0
Other Software
some chinese input methond like office input

After searching through my Windows language settings and the web for times, trying to figure out what was wrong with my IME, I finally discovered that Peek was using Ctrl+Space as the default shortcut.
Chinese/English Mode Switching: Ctrl+Space

/dup https://github.com/microsoft/PowerToys/issues/26150. A fix will be out next week.


Added spaceFromHandle method, new route to space

Now the route to a space is: /[handle]/[app] instead of /space/[handle]
I.e.
http://localhost:3000/embrace/home or http://localhost:3000/embrace/discussion
At this stage the app can be any string.  From the index.tsx page the link to the space is to the 'home' app which will be the default app.
I have also added a new method to the EmbraceSpaces.sol getSpaceFromHandle(_handle) which will return the space directly from the handle instead of getting the spaceId and then the space from the Id.  Currently neither the getSpaceFromHandle(_handle) or getSpace(_index) methods are working - an error is being returned....

@Caruso33 The build is currently failing on TypeScript types related to the Web3.Storage methods.  For now I will merge but let's look at the issue tomorrow at some point


Support error object formatting

When registering the middleware, allow the user to pass a function that will format the error. This allows for more verbose errors in staging environments vs. production.

This is published in v0.2.0.
cc: @mirchow


RunDistributedTests fails with UnExpected error

Hi
I'm trying to run a distributed test on currently one virtual machine.
The tests I want to run are UI Tests that are created with TestStack.White and are declared as "normal" unit tests. Locally they run without a problem.
When I'm running them as part of the TFS build it fails with the following exception:
DistributedTests: Test run is aborted. Logging details of the run logs.
DistributedTests: New test run created.
Test Run queued for Project Build Service.
DistributedTests: Test discovery started.
DistributedTests: UnExpected error occured during test execution. Try again.
DistributedTests: Error : Some tests could not run because all test agents of this testrun were unreachable for long time. Ensure that all testagents are able to communicate with the server and retry again.
DistributedTests: Test run aborted. Test run id: 288
The test run was aborted, failing the task.
I cannot see why it fails and i did not find any meaningful log messages...
What is strange is that in the beginning it recognizes 6 tests (which is the amount i actually have):
DistributedTests: Test run '288' is in 'InProgress' state.
DistributedTests: Total Tests : 6, Passed Tests : 0
But after time they seem to increase:
DistributedTests: Total Tests : 12, Passed Tests : 0
...
DistributedTests: Test run '288' is in 'InProgress' state.
DistributedTests: Total Tests : 18, Passed Tests : 0
...
DistributedTests: Test run '288' is in 'Aborted' state.
DistributedTests: Total Tests : 24, Passed Tests : 0
After this, the task fails...
It would be nice if you could give me some assistance in finding the error
Regards and thanks for your help

Can you please post the Build Log along with DTAExecutionHost log from the test agent machine. It will be under C:\Dta folder.

Hi
I have attached the DTAExecutionHostLog and the "distributed test" part of the build log.
Hope it helps, thanks for your help anyway.
distributedTestBuildLog.txt
DTAExecutionHost.exe .log.txt

Hi
I just saw that the DTAExecutionHost contains a lot of logs from all my build attempts. I created a fresh log with only one build log which might be easier to analyzer.
DTAExecutionHost.exe.log.txt

Sorry to ask again. Can you please do the fresh build and share the DTA log specific to this build [cleanup the log in Test Agent machine before queuing the build].
The logs in build and dta are pointing to different runs.

Hi
the second dta execution host is already a cleaned one.
Find here the build log for the same build attached.
Hope this helps
7_Run Tests on Test Machines.txt

Hi,
From the error it looks like the Request Object is incompatible.
Can you give this info?

TFS Version
Test Agent Version
OS Version

Hi
the TFS Version is 14.0.23128.0 (TFS 2015 RTM)
The test agent is actually donwloaded from the web and installed as part of the Deploy TestAgent task.
See the attached image with a screenshot of the installed program.
This test agent runs on a Windows 7 SP1 machine.

I now uninstalled this TestAgent and tried to let it be installed from the "DeployTestAgent" task again.
Now this task already fails with the following message:
Failed to update TFS Team Project Collection http://tfs:8080/tfs/xyz as the service account could not be granted required permission. To fix this error, run this tool with an account that has "Project Collection Administrator" rights and try again.
Which service account is meant here? The one that is running the build on the build agent? or something on the test machine?

can you drop a mail to devops_tools at microsoft.com

Hi
I cannot drop you any mails there cause I'm not authorized for the group...

Hi, Please do send a mail, we will receive it.
I am expecting that your Build Agent and Test Agent are different machines and not single machine.

Ping

Hi
I'm sorry I was not available last week.
I did send 2 mails, but I guess you did not receive it?
Shall I try again?

yes. please do send

Ok I sent a mail with the problem description + logs.

Hi
did you have any time to look into it?
I suspect that it is a problem with the access rights on TFS? Do you know what permissions the user I declare in "Agent Configuration" must have on the TFS?

sent mail to you. please do respond. will close this issue once we identify the problem.

Can you update result of this issue ? I am having similar problem

It boiled down to the problem that we don't have TFS 2015 Update 2 installed yet. We want to run the tests on virtual machines which are not in our domain (where the TFS is) and apparently that does not work in versions before Update 2.

Closing this thread. If there's any other problem, please do open new issue.

@nigurr I am having similar issue, cld you plz share the solution. Thank you.
DTAExecutionHostExeLog.txt

Hi @nigurr , I am also having similar issue. Can I send you the logs?

@gusdewa can you please send the logs to devops_tools at microsoft.com
Please include your VSTS build url along with it.

hi @nigurr , i have sent the email. However, turns out that the sender should be from the same organisation.
Please see this screenshot:

We did receive your mail.
From the logs:

##vso[task.logissue type=warning]DistributedTests: Error : No tests were discovered from the specified test sources

Are you using any custom adapters for your Tests? if yes, did you copy them to Test machines?

Hi @nigurr, sorry for the late response. What do you mean by custom adapter?
We use selenium C# wrapper with chrome, IE, and firefox driver.
We run it one the Azure VM by deploying the standard test agent to run the provided test.dll.

@gusdewa Can you please attach

DTAExecutionHost.log from C:\DTALogs (Test Agent machine)

W can quickly troubleshoot by logging to Test Agent machine and run the "vstest.console.exe with your test dlls" and see if they are running.

hi @nigurr , thanks. Just sent the file through email.

@gusdewa @nigurr We will have only one thread to discuss this issue: https://github.com/Microsoft/vsts-tasks/issues/4076.


Improve secrets and confimaps templating

I've removed the copyright from generated files, even the kci one, because it's updated on each code generation. So if I remove it from the boilerplate file, it's going to affect all the generated code. Copyrighting something that is generated doesn't make sense to me at all. So I hope KCI will be fine with that.
Issue: https://github.com/db-operator/db-operator/issues/47

What's left:

[ ] Webhook validations for the new templates
[ ] There is a bug that when the templates are not empty, the default one still wants to be added

@db-operator/admins It's kind of ready, only docs left, but I guess it make sense that someone has a look already

I've added an ability to execute query in templates to address this issue: https://github.com/kloeckner-i/db-operator/issues/173
It was not a lot of code after all.

@db-operator/admins Also, I'm not sure if templates is a good name for this CRD field. Because we have postgres.templates and it might be confusing, but I can't come up with something better.
I was thinking about
spec:
  secret:
    name: $SECRET_NAME
    templates: $TEMPLATES

But we're also configuring configmaps with it (both templates and name), so maybe renaming secret to something else and then following this structure would be better, but I don't know what this 'something else' could be? (not on this iteration, because it must be the next API versions with all the mutation webhooks prepared)

I think that it makes sense to have a structure like that
spec:
  credentials:
    secretName: $SECRET_NAME
    templates:
      - ...

But putting the secretName under another entry will be a breaking change, that's why I've added only templates there. I would change the secretName in the next API version alongside this: https://github.com/db-operator/db-operator/issues/17

Hey @khusseini
I'm not sure if it's still relevant, but I remember you've had a request for showing the db version in secrets: https://github.com/kloeckner-i/db-operator/issues/173
Once v.1.15.0 is release as a helm chart, it should be possible:
spec:
  credentials:
    templates:
      - name: POSTGRES_VERSION
        secret: false
        template: "{{ .Query \"SHOW server_version;\" }}"


How to resize video without changing it's aspect ratio?

Current behavior
  constructor(props) {
    super(props);
    this.state = {
        screenWidth: Dimensions.get('window').width,
        heightScaled: null,
    };
  }

<View style={styles.videoView}>
       <Video
          source={video}
          ref={(ref) => { this.player = ref }}
          repeat={true}
          resizeMode={"contain"}
          style={{
              width: this.state.screenWidth,
              height: this.state.heightScaled,
           }}
          onLoad={response => {
                const { width, height } = response.naturalSize;
                const heightScaled = height * (this.state.screenWidth / width);

                response.naturalSize.orientation = "horizontal";
                this.setState({ heightScaled: heightScaled });
          }}
       />
</View>

styles
videoView: {
  flex: 1,
  width: Dimensions.get('window').width,
  height: 100
}

I'm fetching video from api and then using it in a video component using react-native-video. I don't know how I can resize my video to fit in a view without stretching the video.
Expected behavior
Here is the result of the above code.
output
Platform
Which player are you experiencing the problem on:

Android MediaPlayer

Came across this while looking for an answer.
I solved this by just doing the following
videoView: {
  flex: 1,
  width: Dimensions.get('window').width,
  height: Dimensions.get('window').width
}

And then just use  resizeMode={Video.RESIZE_MODE_CONTAIN} as a prop to the Video component

Cover and contain both have weird aspect ratio, whereas they are both resize mode that don't temper the aspect ratio.
Stretched (which actively changes the aspect ratio) will display properly on android.
So I think the problem is the video source itself in android has the wrong aspect ratio.


cli::spend_utils: Remove allow(clippy::arithmetic_side_effects)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.8%. Comparing base (6aacbf3) to head (06f2a22).

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #937     +/-   ##
=========================================
- Coverage    81.9%    81.8%   -0.1%
=========================================
  Files         853      853
  Lines      231812   231812
=========================================
- Hits       189867   189839     -28
- Misses      41945    41973     +28


remove legacy exclude

Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Removing the exclude doesn't seem to cause the inclusion at this point. I'll let @howardjohn determine if this seems to have finally been fixed or might be transiently good.


WIP: IDatabaseTransaction taking self by move during commit

This PR attempts to fix https://github.com/fedimint/fedimint/issues/1635
Right now additional allocations need to be taken because commit_tx takes self by move and not by &mut like the other functions in the trait. This PR introduces a new trait that contains an Option of the database transaction and consumes it during commit, and panics if the transaction is None. Additional wrapper was also introduced to accomodate the new trait.
This will directly conflict with https://github.com/fedimint/fedimint/pull/1197

I need to squash commits and add documentation for the new trait

Codecov Report
Base: 64.77% // Head: 64.52% // Decreases project coverage by -0.26% :warning:

Coverage data is based on head (0e3c367) compared to base (88cf6fa).
Patch coverage: 78.57% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
- Coverage   64.77%   64.52%   -0.26%
==========================================
  Files         131      132       +1
  Lines       23976    24177     +201
==========================================
+ Hits        15531    15599      +68
- Misses       8445     8578     +133

Impacted Files
Coverage Δ

fedimint-dbtool/src/dump.rs
0.00% <0.00%> (ø)

fedimint-rocksdb/src/lib.rs
71.49% <75.00%> (+0.12%)
:arrow_up:

fedimint-core/src/db/mod.rs
86.37% <80.28%> (-0.53%)
:arrow_down:

fedimint-core/src/db/mem_impl.rs
89.38% <100.00%> (+0.09%)
:arrow_up:

fedimint-sqlite/src/lib.rs
95.33% <100.00%> (+0.03%)
:arrow_up:

crypto/tbs/src/serde_impl/mod.rs
75.00% <0.00%> (-4.17%)
:arrow_down:

fedimint-server/src/consensus/mod.rs
81.41% <0.00%> (-0.90%)
:arrow_down:

gateway/ln-gateway/src/gatewayd/lnrpc_client.rs
1.78% <0.00%> (-0.14%)
:arrow_down:

modules/fedimint-mint/src/lib.rs
77.58% <0.00%> (-0.12%)
:arrow_down:

gateway/ln-gateway/src/bin/cln_extension.rs
0.27% <0.00%> (-0.09%)
:arrow_down:

... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


net: tcp: Fix two ways the FIN1 state is not properly handled

When an ACK is acknowledged in the FIN1 state for the FIN flag, properly increment the ACK counter.
When retransmitting the FIN packet from the FIN1 state, reduce the sequence counter by 1 to avoid sending a "second" FIN flag.

@AndreyDodonov-EH: Could you review this PR?

@AndreyDodonov-EH: Could you review this PR?

@ssharks
As far as I understand, this results in keeping ACK-ing the last actually processed sequence number, instead of ACK-ing new sequence numbers?

@AndreyDodonov-EH: Could you review this PR?

@ssharks As far as I understand, this results in keeping ACK-ing the last actually processed sequence number, instead of ACK-ing new sequence numbers?
I couldn't find in https://www.rfc-editor.org/rfc/rfc9293 what is the expected behavior in case of half-closed connection. I interepreted it that yes, we ACK only old sequence number, but also RST

This PR only fixes the wrong sequence number in retransmission. I'm working on a testcase for the last trace you send in. The reset behavior is a little harder, so I think we should seperate them in 2 PRs at least.

Superseeded by https://github.com/zephyrproject-rtos/zephyr/pull/61353


Exporting tables of non-org users always result in public.ext name

How to reproduce:

browse a public table of a non-org user. E.g: https://observatory.cartodb.com/tables/whosonfirst_region/public
click on download
choose a format. E.g: CSV

Expected: the name of the downloaded file is set to whosonfirst_region.csv or sth related to the exported table.
Actual: the downloaded file is set to public.csv.
The thing is that the Content-Disposition header sets the filename to public.csv:
$ curl -vv -X HEAD "https://observatory.cartodb.com/api/v2/sql?filename="public.whosonfirst_region"&q=SELECT+*+FROM+(select+*+from+public.whosonfirst_region)+as+subq+&format=csv&bounds=&api_key=&skipfields=the_geom_webmercator"
...
> HEAD /api/v2/sql?filename=public.whosonfirst_region&q=SELECT+*+FROM+(select+*+from+public.whosonfirst_region)+as+subq+&format=csv&bounds=&api_key=&skipfields=the_geom_webmercator HTTP/1.1
> User-Agent: curl/7.35.0
> Host: observatory.cartodb.com
> Accept: */*
>
< HTTP/1.1 200 OK
* Server openresty is not blacklisted
< Server: openresty
< Date: Thu, 18 Feb 2016 12:11:26 GMT
< Content-Type: text/csv; charset=utf-8; header=present
< Content-Length: 63677977
< Connection: keep-alive
< Vary: Accept-Encoding
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Headers: X-Requested-With, X-Prototype-Version, X-CSRF-Token
< Content-Disposition: attachment; filename=public.csv; modification-date="Thu, 18 Feb 2016 12:01:07 GMT";
< Cache-Control: no-cache,max-age=31536000,must-revalidate,public
< Last-Modified: Mon, 01 Feb 2016 22:13:32 GMT
< X-SQLAPI-Profiler: {"queryExplain":5,"generate":493,"beforeSink":1,"total":499}
< X-Varnish:<PHONE_NUMBER><PHONE_NUMBER>
< Age: 619
< X-Cache: HIT

Related to https://github.com/CartoDB/cartodb/issues/6609

I rechecked the HEAD request to the URL and saw that the underscore is coming directly with the tablename in the Content-Disposition:

We can improve the name formatting for filenames but providing a different filename param with the desired name should do the trick, and that's something the client is controlling on this case.


Turn off Software Compression from Storage Policy

Hello  Team,
I was trying to create a Storage Policy (without Software Compression and without Encrypt Data) for a Disk Library.
I have noticed that by default Encrypt Data is Turned Off and Software Compression is Turned On.
So, I want to know how to Turn Off Software Compression from the Storage Policy?
Below is the Setup and Steps Details :
My CV Test MAchine Setup is CV11SP10
My CV Python SDK is version : CV11SP11
Steps Executed :

commcell.disk_libraries.add(library_name="nfsdev2sp10", media_agent="rhel74-cv11sp10", mount_path="/mnt/ddr_cv11sp10auto")
DiskLibrary class instance for library: "nfsdev2sp10" of Commcell: "sup-cv11sp10"

commcell.disk_libraries.add(library_name="nfsdev2sp10", media_agent="rhel74-cv11sp10", mount_path="/mnt/ddr_cv11sp10auto")
DiskLibrary class instance for library: "nfsdev2sp10" of Commcell: "sup-cv11sp10"

When i checked in Commcell Console : above created policy has Software Compression Turned On (On clients)

Hi @cssupratik ,
We'll check this shortly and get back to you.

Hi Jatin,
Any update on this Storage Policy issue?

Hi @cssupratik
Apologies for the delay.
We are working on adding an argument to the Storage Policy add method, to disable Software Compression.
We'll update you once we've committed the code on the SP11 tree.

@shailymehta,
Can you please share an update on this.

Please open Commvault support ticket.


feat: allowStdin option for flags

Add option for flags: allowStdin
If a value of '-' is provided, then read from stdin
Based on solution provided in https://github.com/oclif/core/issues/761
Does not solve for the situation in which a developer creates multiple flags with the allowStdin property

Based on above chatter, this should be up to the developer to provide a good experience

@k-capehart what if you add a warning somewhere during compilation step to warn developers not use allowStdin more than once?

@k-capehart what if you add a warning somewhere during "compilation" (I forgot the proper word) step to warn developers not use allowStdin more than once?

I'm open to this, and can start looking into it. It could also be a follow up PR while we just update documentation for now.

@AllanOricil @k-capehart I don't think this provides enough value to warrant the complexity. We can always add it later if it's actually needed

@k-capehart Thanks for doing this work 🏆
I'm going to merge this into a separate feature branch so that all our integration tests (which don't run on forks) can run. Once that passes, I'll merge into main

@k-capehart Thanks for doing this work 🏆
I'm going to merge this into a separate feature branch so that all our integration tests (which don't run on forks) can run. Once that passes, I'll merge into main

No problem! And thank you for helping. I had fun working on this and learned a lot, so looking forward to being able to use it.


[Feature] load detected planes on mount

If ARKit is unmounted and remounted, it does not lose information about planes detected internally. But if you are using onPlaneDetected and onPlaneUpdate to visualize the planes detected, you won't get notified anymore.
We therefore should call onPlaneDetected on component mount for any plane that has been detected in the past (already merged with all updates).

@macrozone is there a way to reset detected planes, so you can detect them again?

@Bickson have to look into that. It was not an issue so far for me. On which occasions do you need to reset detected planes?

Would love this also.


RuntimeError: Unable to find any PlaidML devices

Could someone help me?
I'm following tutorial
https://www.ngraph.ai/tutorials/onnx-tutorial
Everything works great, but when I set
runtime = ng.runtime(backend_name='PlaidML')
I got error "RuntimeError: Unable to find any PlaidML devices"
that`s interesting because when following instructions on plaidml github
https://github.com/plaidml/plaidml
plaidml-setup
is able to see this devices

Default Config Devices:
No devices.
Experimental Config Devices:
llvm_cpu.0 : CPU (LLVM)
opencl_intel_gen9_hd_graphics_neo.0 : Intel(R) Corporation Intel(R) Gen9 HD Graphics NEO
(OpenCL)

Do you know the reason why there are no devices?

Can you try you can setting the following environment variables to select the proper configurations for your device? This is the command-line equivalent to running plaidml-setup and selecting these settings when prompted.
PLAIDML_EXPERIMENTAL - int (0 or 1) which determines whether to enable experimental mode in PlaidML
PLAIDML_DEVICE_IDS - string which contains the name of the device to use with PlaidML (to see a list of devices, run plaidml-setup)
In your case, it would look somewhat like this:
export PLAIDML_EXPERIMENTAL=1
export PLAIDML_DEVICE_IDS=opencl_intel_gen9_hd_graphics_neo.0
Let me know if this works.

@dgkutnic yes it worked! Thank you!
I was expecting something like this reading.
It looked like there was no default device.
But I would add this to documentation. It's not obvious

Thanks for verifying @YuriyPryyma!
It's in the PlaidML documentation here, but I don't see it mentioned in the ONNX tutorial you linked. @indie can we add this to nGraph's documentation as well?


On-Behalf Flow

Hello, we are trying to understand if there is a timeline for the On-Behalf-Of or Web Chaining Flow? We have a scenario where we have 4 different APIs. Each API has its scopes. We have built a Client with a combination of scopes across multiple APIs. The authenticating user will require one or more of these scopes to be authorized and embedded in the Access Tokens.
It appears that calling multiple APIs using the same Access Token is not possible? This scenario is so common. Identity Server supports this out of the box. Do we know if there is an ETA on this scenario?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 836ec1be-7675-d0f1-c861-0520dc3ea01e
Version Independent ID: c6a2a6f6-57fd-20ae-36f7-b6db1987ebe5
Content: Request an access token - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/access-tokens.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@hypertrends Thank you for your feedback . We will investigate and update the thread.

@hypertrends Thank you for reaching out. Please post roadmap related questions at our feedback portal which is monitored by the product team and they can share the timeline.


fix: osx deployment target

this fixes https://github.com/jtmuller5/flutter_fast_cli/issues/8

@jtmuller5


necessary changes in deconvolution with regularization, and other stuff

I changed the spectrum division function with regularization to allow the user to pass a list of [freq_min, freq_max] as in Ita toolbox. The way it was, the function was taking the inputSignal.freqMin and inputSignal.freqMax, which are the values where the sweep is just starting to fade in or had already faded out. This is incorrect and noise prone.
I also added another deconvolution method that still need some review (mainly to correct a bias in the level of the h(t).
I am migrating deconvolution methods to functions inside the ImpulseResponse class - easier to mantain.

Necessary changes to deconvolution.


Update requirements. Added license

@felixge Build tools complain. And license is something you're using for other projects.

thx


Decide whether to use libzypp for listing packages

As described in #6, PackageKit does not show installed packages. So, either some hack is needed or we should switch to libzypp. From description by @mentaljam, seems like libzypp would allow us to filter packages by repo, maybe by vendor. Should we switch?

Does anyone know good pointers to libzypp API. https://doc.opensuse.org/projects/libzypp/HEAD/index.html is a touch overwhelming, but if needed to be can be used probably. Looked a bit into zypper code as well, can continue there. I guess we don't need much, so most of libzypp is not needed in our case. In principle, we need to get list of packages and their metadata.
Install/removal would be via PackageKit, I presume.

I have been experimenting with libzypp for Storeman. I can try to implement package listing this weekend

Excellent! Then we will work on other aspects with piggz. maybe prepare some kind of framework where you could replace with libzypp implementation. Let's see how far we will get taking into account that the weekend is just few days away

I can write a wrapper class for libzypp and packagekit like OrnPm which then can be used in list models

@mentaljam: just to let you know that I am working on restructuring the code a bit and Chum class in particular. This is to make easier to support the crawlers and list data better. So, if you work on libzypp and integration to Chum class we may clash. But I am sure we will find the way to merge it all

I find it kind of strange that PackageKit can't show installed packages since other packagekit UIs do show installed packages.

You can filter to only search for installed packages like this:
https://www.freedesktop.org/software/PackageKit/gtk-doc/Transaction.html#Transaction.SearchNames
Using libzypp has the side effect of blocking Jolla store possibly.

The installed package can be retrieved by using Transaction.SearchNames as show above:
https://www.freedesktop.org/software/PackageKit/gtk-doc/Transaction.html#Transaction.SearchNames
Then get use  PackageKit::Daemon::packageVersion() with the packageId retrieved.
For example see Discover here:
https://github.com/KDE/discover/blob/0cd9956adb0086c3587569ece14a1384c1ee23fd/libdiscover/backends/PackageKitBackend/PackageKitResource.cpp#L113

A side note regarding Jolla Store is something I have never thought about - not sure it is realistic, but I never looked into requirements that are needed for such application (PackageKit, installing of packages).
In short, there should be a way to use PackageKit. It is just requires processing of all installed packages and querying them for the source. When we list all packages, we get packageId that is a string with fields delimited by ;. One of them is the name of a repo from which package is available. For installed packages, repo name is replaced by installed. Examples:
harbour-advanced-camera;0.9.5+metadata.20211207214553.9.gfab468d-1.5.1.jolla;aarch64;sailfishos-chum-testing

this is for not installed (yet) and below for the installed one:
timed-qt5;3.6.13-1.7.1.jolla;aarch64;installed

However, there is a packagekit function whatProvides which should actually allow us to learn the source.
I will look into it.

I have fixed issue with listing installed packages in 162cb0f29d17d888fa07b26e1e8f22f51aec7726. I guess, we don't need libzypp for it anymore and can stay on PackageKit

As package listing seems to be working with PackageKit now, let's stay on the working solution. It may have some other advantages, as pointed out by @Thaodan above.
Closing for now, feel free to reopen or continue in discussion in closed form if needed.


Convert Duration tests to table-driven style

Convert each test to table-driven style:

TestDuration_IsEqual
TestDuration_IsGreater
TestDuration_IsLesser

TestNumber_IsEqual/basic can be used as a reference for table-driven style.

Thanks for PR!
One minor issue: when there is only a single subtest, we can remove subtest (like in other Duration tests). Could you please do it?


Running release Windows app from console doesn't stay attached

Steps to Reproduce

Logs
flutter analyze
PS C:\Users\Merritt\Dev\myapp> flutter analyze
Analyzing myapp...
No issues found! (ran in 4.0s)
PS C:\Users\Merritt\Dev\myapp>

PS C:\Users\Merritt\Dev\myapp> flutter doctor -v
[✓] Flutter (Channel dev, 1.27.0-4.0.pre, on Microsoft Windows [Version 10.0.19042.804], locale en-US)
    • Flutter version 1.27.0-4.0.pre at C:\tools\flutter
    • Framework revision f8cd24de95 (13 days ago), 2021-02-16 11:24:17 -0800
    • Engine revision 1d537824d6
    • Dart version 2.13.0 (build 2.13.0-30.0.dev)

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.8.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.8.31019.35
    • Windows 10 SDK version 10.0.18362.0

[✓] VS Code (version 1.53.2)
    • VS Code at C:\Users\Merritt\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.19.0

[✓] Connected device (1 available)
    • Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.19042.804]

• No issues found!
PS C:\Users\Merritt\Dev\myapp>

When running a Flutter for Windows Desktop app from cmd the running app does not stay attached to the console and output print statements (This is exactly what it does do in Linux).
Working in Linux:
void main() {
  print('Hello Linux!');
  runApp(MyApp());
}

flutter build linux
myapp/build/linux/release/bundle/myapp

Output as expected:
Hello Linux!
Terminal session stays attached to the running program to output further messages. :thumbsup:
Not working in Windows:
void main() {
  print('Hello Windows!');
  runApp(MyApp());
}

flutter build windows
.\build\windows\runner\Release\myapp.exe

Expected output:
Hello Windows
Actual output:
None, and console does not attach to running program and immediately goes to a new cmd line awaiting input.
I have been trying to debug an issue that only appears in release and not debug build, and doing so without access to a debugger or being able to follow print statements has been very troublesome. I do expect it should work the same way as it does on Linux.

I understand why this is the behavior you want in this scenario, but it is not actually the expected behavior for launching a Windows GUI application from cmd.

I see, real shame it can't work that way. Thank you for clearing that up!

I would recommend modifying the code I linked above in your runner to make the console unconditionally for debugging purposes. It'll be a separate window, not inline, but you'll have access to it.

Moving CreateAndAttachConsole(); directly out of the if statement and a few other attempted tweaks don't seem to accomplish this, but I am very much not familiar with C++ & win32 so I will play around with it. (or try to get a logger that logs to a file going).
Thanks very much for your insight - much appreciated!


linkage: correctly detect missing kegs.

manually raise Errno::ENOENT to ensure that a keg that doesn't exist isn't flagged as a system dependency.
remove the inconsistent and incorrect summary messaging.

Fixes https://github.com/Homebrew/brew/issues/9321

Review period skipped due to critical label.


gradio interface for mistral chatbot

What does this PR do?
Adds a gradio interface for mistral instruct 7b chatbot
@cbalioglu  minor observation is that the nucleus param change doesnt influence the output as much as I would expect. Worth checking this further.

Example:


feat: SyncList now supports any IList implementation

Now SyncList can use any IList implementation.   For example:
class MySyncList : SyncList<int>
{
    public MySyncList() : base(new MyIntList())  {}
}

:tada: This PR is included in version 3.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Auto close curly brackets for placeholders in template literals JS/TS

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.56.2
OS Version: Ubuntu 20.04

let str = `a$|b`;

Type { where the cursor is.
No closing bracket

A similar one was mentionned as fixed in #47244
Auto-close works for a${ b or ${ but not when in between an existing string with no space..

/closedBy bc0e91755337f14260fe5604c271b0e8f0f0aa20


custom filters

change the default filters that show in iD and/or add a new filter.
see relevant iD feature request here

Done.  (https://github.com/openstreetmap/iD/issues/2580)


Create an intro

Add an intro about yourself: who are you, what is your strengths, why are you here.

Intro created and looks amazing


Spurious unused variable when used via extends

This gives an unused variable warning for Parent:
let Parent = class {};
class Child extends Parent {}

Thanks for the report @ef4! I believe this is primarily caused by a TypeScript issue (see the issue referenced above) so as soon as it gets fixed in TS we'll be able to resolve it here.

@ef4 This should actually be fixed if you use the next version of TSLint. Try it and see if the problem persists?

I can confirm that this is fixed in tslint@next. Thanks!


fix: Remove failing iedriverserver

When generating an app of type 'Web Application' on a Windows system the build fails to load with the error:
Could not find method iedriverserver() for arguments [3.141.59] on extension 'webdriverBinaries' of type com.github.erdi.gradle.webdriver.WebDriverBinariesPluginExtension.
This commit removes iedriverserver from the webdriverBinaries block.
Closes #348

This is exactly how I handled this in a 6.2 project since iedriverserver is no longer even mentioned in the documentation.  RIP Internet Explorer.


1.0.1 tag but no corresponding release

Question
Why is there a 1.0.1 tag but no corresponding release?

cc @dekkagaijin
The changes were only to the internal pkg structure, designed to make the code a little easier to use as a library. The tag was to make it so go would import this version, but there should be no functional difference to the binary. We should probably just release binaries again anyway though for consistency.

Cool, that answers my question :+1:

Yup, just wanted go mod to pick up the PRs which pruned the surface of pkg ASAP. Functionality of the binaries weren't modified


incorrrect font on init window with stack builder

img
step to reproduce:

open wordpress stack
press start

my browser:
Chromium Version 91.0.4472.114 (Official Build) Arch Linux (64-bit)
resolution: 3840x2160

Seems to work ok here. Debian buster.
Maybe some font configuration on your system?


Add to the documentation that doctype is required

Please add to the documentation that <!DOCTYPE HTML> is required. Without doctype $(window).height() returns same than $(document).height() and infinite scroll does not work. Tested with chrome and FF. See http://viralpatel.net/blogs/jquery-window-height-incorrect/

Was this documented? Because I didn't see it and this is what caused #197 for me.


Add Unity to list of analytics options

@caseypugh : Thanks for your contribution! The author(s) have been notified to review your proposed change. @blparr


hk.stateful.remat generates excess un-pruneable HLO

jax.remat wraps all of its inputs with _foil_cse.
When we do the state-threading in hk.stateful.remat, the threaded-out state now is the output of _foil_cse. Any downstream uses of this state now access the foil-cse'd param/state, rather than the original.
Example:
def f(x, ctxt):
  return jnp.sin(x + ctxt[0]), ctxt

@jax.jit
def g(x):
  ctxt = [x + i for i in range(2)]
  x, ctxt = jax.remat(f)(x, ctxt)
  return jnp.sin(x + ctxt[1])

g(1.).block_until_ready()

This results in HLO that looks like:
HloModule jit_g__1.46, is_scheduled=true

ENTRY jit_g__1.46 {
  constant.2 = f32[]{:T(256)} constant(2)
  constant = f32[]{:T(256)} constant(0)
  constant.5 = f32[]{:T(256)} constant(1)
  rng.2 = f32[]{:T(256)} rng(constant, constant.5), distribution=rng_uniform
  compare.2 = pred[]{:T(256)E(32)} compare(rng.2, constant.2), direction=LT
  rng.1 = f32[]{:T(256)} rng(constant, constant.5), distribution=rng_uniform
  compare.1 = pred[]{:T(256)E(32)} compare(rng.1, constant.2), direction=LT
  rng = f32[]{:T(256)} rng(constant, constant.5), distribution=rng_uniform
  compare = pred[]{:T(256)E(32)} compare(rng, constant.2), direction=LT
  parameter.1 = f32[]{:T(256)} parameter(0), parameter_replication={false}
  select = f32[]{:T(256)} select(compare, parameter.1, constant)
  select.1 = f32[]{:T(256)} select(compare.1, parameter.1, constant)
  add = f32[]{:T(256)} add(select, select.1)
  sine = f32[]{:T(256)} sine(add)
  add.6 = f32[]{:T(256)} add(parameter.1, constant.5)
  select.2 = f32[]{:T(256)} select(compare.2, add.6, constant)
  add.43 = f32[]{:T(256)} add(sine, select.2)
  sine.44 = f32[]{:T(256)} sine(add.43)
  ROOT tuple.45 = (f32[]{:T(256)}) tuple(sine.44)
}

Possible solutions:

Reduce the amount of state-motion in & out of stateful_fun, especially during apply.

Params are immutable during apply, don't thread them in/out.
Pre-split the RNG and populate a new hk.PRNGSequence inside stateful_fun so that RNG doesn't get threaded in/out.
state is only updated in-place for state that's actually been changed. JAX referential transparency makes this challenging for the case in which Haiku is not jitted but internal functions are via hk.jit.

Rebuild hk.remat on top of hk._src.lift.

I like 1, we can definitely be smarter wrt params and state.
I think a general solution would be to return only updated values for both params/state and then merge into the parent frame. I think we can do this by stashing the intial values (we only care about identity) that are inputs to the stateful_fun and only returning ones that have a different identity.
def only_new_values(original, updated):
  output = defaultdict(dict)
  for mod_name, mod_state in updated.items():
    for name, value in updated.items():
      if name in original[mod_name] and original[mod_name][name] is not value:
        output[mod_name][name] = value
  return output

def stateful_fun(*a, **k):
  hk_state = k.pop(..)
  orig_params, orig_state = copy_params_state(hk_state)

  with use_and_update(hk_state):
    out = f(*a, **k)

  # Only return updated values.
  params = only_new_values(orig_params, hk_state.params)
  state = only_new_values(orig_state, hk_state.state)
  return out, (params, state)

I think I agree re PRNG keys too, but would want to triple check the details.

I was thinking the same thing; we can view the returned value as an overlay over the original values.
There are a couple of annoying things here to be aware of:

For state, updated states will still modify the original state member of StatePair to be the _foil_cse'd one. This is pretty annoying, though not the worst thing ever.
The _foil_cse HLO does not get pruned when not used - we're left with a huge number of vestigial constant and rng HLO ops. Blake from XLA team speculates that this is because the ops could be side-effecting.

As a side note, it's not clear to me whether _foil_cse-ing params (which don't need to be _foil_cse'd, as they're constant!) is even a good idea. This is sufficiently murky that I think Haiku shouldn't take a stance on this.

My changes in google/jax#2391 to the XLA CSE mechanism change the semantics of this bug.
Now, we're incurring unnecessary serialization (because parameters are now an output of the remat layer), rather than unnecessary layers of _foil_cse.
The underlying cause remains the same (unnecessarily updating the Haiku state).

I'll take a stab at not updating state if it doesn't change.

As a result of google/jax#2391, it looks like the problems get optimized away; we're not even incurring unnecessary serialization right now.
These changes may still be good to make defensively.


Add rule 169

We can't actually check the format but we can use a should rule to provide examples of the format so consumers are supported better.
Was do you think?
We could even check the content of the example filed for the RFC 3339, but we would need to get a good regex or use a library. Should we do this?

I like the idea of requiring an example and we could actually lint it (but I would only do it if it is not too hard).

Thx, let's go with the example first and check linting for example later.


Bounding box parameter for placemarkFromAddress() method

🚀 Feature Requests
Hello!
What I want to achieve is to geocode addresses into geographic coordinates ONLY within a specific city.
I'm not sure what's the base idea of this library and what does it use internally, but, for example, Android's Geocoder library supports a bounding box for the search results. Read more about this here.
Platforms affected (mark all that apply)

[x] :iphone: iOS
[x] :robot: Android

Submitted a PR: https://github.com/Baseflow/flutter-geolocator/pull/367

Since version 6.0.0 the geocoding features are no longer part of the geolocator plugin and moved to their own plugin which can be found here.


Allow fail=false in audit and scan commands

[x] All tests passed. If this feature is not already covered by the tests, I added new tests.
[x] This pull request is on the dev branch.
[x] I used gofmt for formatting the code before submitting the pull request.

Depends on https://github.com/jfrog/jfrog-cli-core/pull/286.
Allow avoiding failing a build if an audit or scan command should fail it.
Usages:
jf audit-go --fail=false
jf audit-gradle --fail=false
jf audit-mvn --fail=false
jf audit-npm --fail=false
jf audit-pip --fail=false
jf scan --fail=false
jf docker-scan --fail=false

jf audit-go --fail=false
jf audit-gradle --fail=false
jf audit-mvn --fail=false
jf audit-npm --fail=false
jf audit-pip --fail=false
jf scan --fail=false
jf docker-scan --fail=false

jf audit --fail=false is missing and jf docker-scan is not yet released


TravisCI reborn

Very much improved in every sense.
From https://github.com/szepeviktor/debian-server-tools/blob/master/.travis.yml

This change is

@voku Please ask for free open-source credits from TravisCI.
TravisCI is great! ☺
See it in action: https://travis-ci.com/github/szepeviktor/Stringy/builds/219987421
(my TravisCI account has a lot of free credits)

Big FAILURE 💥 TravisCI has all 3 extensions compiled in.
See php -n -m output: https://travis-ci.com/github/szepeviktor/Stringy/jobs/490710311#L226-L285
😢

Success 🍏
https://travis-ci.com/github/szepeviktor/Stringy/builds/219990510

StringyTest::testItCanUseNewEncoding
UTF8::encode() without mbstring cannot handle "ASCII" encoding

Only 1 test fails.
Please help me.

TravisCI isn't working for me, because of the limits they provided. I try to port my repos to GitHub Actions step-by-step. :-/

All right. You have to know I'm a Travis fan. They give you open-source hours for free.


fix(vitest): only include src and test folder in test files

Current dependencies on/for this PR:

main

PR #113

PR #114   👈

This comment was auto-generated by Graphite.


Add openssl as optional feature

re-run CI.  Mac VM is very slow which cause issue in timing related tests

Let's hold off on merging until I test changes in fluvio


[core modules] Change transaction fee distribution method

Transaction fees are no longer distributed to each validator, but instead paid to the association.
This is done by adding the collected fees to a preburn resource for transaction fees, the association then needs to send a transaction to burn these coins and can then extract the underlying fiat.

:umbrella: The latest upstream changes (presumably 6344c36ac91794fba322e3c1d60c4beedb28944f) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably ad690756e8ee2cee830116e000cbb96975cfe7bc) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably 0489a63e4223332aca4f80c42c6124f938723a43) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably 5c9c438f573b17ca9cfd039f08f21adb59589509) made this pull request unmergeable. Please resolve the merge conflicts.

:pushpin: Commit 5127328 has been approved by sblackshear

:hourglass: Testing commit 5127328ebd2d8d3dcc7761387edc6aeb46c5c5ff with merge 28d08ef6526f21734f5c4189397a4a25e5fef10e...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

:hourglass: Testing commit 5127328ebd2d8d3dcc7761387edc6aeb46c5c5ff with merge f1ec07fff2ae540cdc76a0f0beb4048e1198d163...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sblackshear
Pushing f1ec07fff2ae540cdc76a0f0beb4048e1198d163 to master...


Live code editing isn't tuned as well as before, displays too many warnings while you are typing

Fixed in commit: https://github.com/pmgl/microstudio/commit/7929f4c8ce72a5d7879356a361117ab50704bb55


sensor: sensing: unified api

Implement the sensing subsystem.
This includes the following features:

Unified API - Use sensor_driver_api instead of sensing_sensor_api to fix Duplicates APIs issue raised in https://github.com/zephyrproject-rtos/zephyr/issues/62223
Implement the sensing subsystem base on unified API.
Implement phy_3d_sensor driver as the reference code of physical sensor.
Implement hinge_angle driver as the reference code of virtual sensor.

The sensing subsystem working process is as below.
    sequenceDiagram
    title Sensing runtime process

    participant Sensing as Sensing Subsys
    participant Sensing_dispatch as Sensing Dispatch Thread
    participant phy_3d_sensor
    participant hinge_angle_sensor
    participant Application

    Application-->>Sensing: call sensing_open_sensor to get hinge_angle_sensor's handle
and registe sensing_callback_list
    activate Application
    Application-->>Sensing: call sensing_set_config to set hinge_angle_sensor's sampling freq.
    activate hinge_angle_sensor
    Sensing-->>hinge_angle_sensor: call .attr_set to set sampling freq.
    hinge_angle_sensor-->>Sensing: call sensing_set_config to config its reporters.
    Sensing-->>phy_3d_sensor: call .attr_set to set sampling freq.
    deactivate hinge_angle_sensor
    deactivate Application

    rect rgb(191, 223, 255)
    loop
        Sensing-->>hinge_angle_sensor: Call its .submit callback to submit SQE periodically.
        Sensing-->>phy_3d_sensor: Call its .submit callback  to submit SQE periodically.
        phy_3d_sensor-->>Sensing_dispatch: Produce the CQE.
        Sensing_dispatch-->>hinge_angle_sensor: Consume CQE produced by phy_3d_sensor
and dispatch data to it's clients by calling sensing_callback_list.on_data_event()
        hinge_angle_sensor-->>Sensing_dispatch: Produce the CQE.
        Sensing_dispatch-->>Application: Consume CQE produced by hinge_angle_sensor
and dispatch data to it's clients by calling sensing_callback_list.on_data_event()
    end
    end

Depends: https://github.com/zephyrproject-rtos/zephyr/pull/60063
Links

Presentation sensing_unify_api_proposal.pdf

I think more broadly though that each sensing_sensor needs to connect a sensor to multiple lists of callbacks rather than a single list of callbacks. The assumption that I believe should be made here is that a sensor or algorithm may be a source of multiple data streams (e.g. the muxed FIFO issue noted in #60063) and that for each channel (accel xyz could be a channel) a set of callbacks are associated.

Thanks for the review, on above requirement, we have a little different concept. In our view, the sensors in sensing subsystem should be a standard part instead of multi-function tools. A standard part means that it has standard input/output defined, no matter it is built by whom. A standard part can help people easily assembly them together into a sensor tree and create a functional sensing subsystem, like playing LEGO blocks.
So for the case that one sensor may be a source of multiple data streams, the preference is to split it into multiple standard sensors, each to serve one type of usages.

I really like that we're not adding a new API, that it appears to mostly avoid copying the data around, and that there is a simple callback list involved.

Thanks for your comments. I'll update it later.

there is an issue with llvm:
zephyr/subsys/sensing/CMakeFiles/subsys__sensing.dir/sensor/hinge_angle/hinge_angle.c.obj -c /__w/zephyr/zephyr/subsys/sensing/sensor/hinge_angle/hinge_angle.c
/__w/zephyr/zephyr/subsys/sensing/sensor/hinge_angle/hinge_angle.c:167:29: error: initializer element is not a compile-time constant
DT_INST_FOREACH_STATUS_OKAY(SENSING_HINGE_ANGLE_DT_DEFINE);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/zephyr/include/zephyr/devicetree.h:4153:25: note: expanded from macro 'DT_INST_FOREACH_STATUS_OKAY'
                              DT_DRV_COMPAT)(fn)),              \
                              ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
/__w/zephyr/zephyr/twister-out/native_posix/samples/subsys/sensing/simple/sample.subsys.sensing.simple/zephyr/include/generated/devicetree_generated.h:3862:61: note: expanded from macro 'DT_FOREACH_OKAY_INST_zephyr_sensing_hinge_angle'
#define DT_FOREACH_OKAY_INST_zephyr_sensing_hinge_angle(fn) fn(0)
                                                            ^
/__w/zephyr/zephyr/subsys/sensing/sensor/hinge_angle/hinge_angle.c:160:2: note: expanded from macro 'SENSING_HINGE_ANGLE_DT_DEFINE'
        SENSING_SENSOR_DT_INST_DEFINE(_inst, &hinge_reg,                        \
        ^
note: (skipping 11 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
/__w/zephyr/zephyr/include/zephyr/sys/util_internal.h:64:39: note: expanded from macro '__COND_CODE'
        __GET_ARG2_DEBRACKET(one_or_two_args _if_code, _else_code)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/zephyr/include/zephyr/sys/util_internal.h:69:65: note: expanded from macro '__GET_ARG2_DEBRACKET'
#define __GET_ARG2_DEBRACKET(ignore_this, val, ...) __DEBRACKET val
                                                    ~~~~~~~~~~~~^~~
/__w/zephyr/zephyr/include/zephyr/sys/util_internal.h:72:26: note: expanded from macro '__DEBRACKET'
#define __DEBRACKET(...) __VA_ARGS__
                         ^~~~~~~~~~~
1 error generated.

there is an issue with llvm:
zephyr/subsys/sensing/CMakeFiles/subsys__sensing.dir/sensor/hinge_angle/hinge_angle.c.obj -c /__w/zephyr/zephyr/subsys/sensing/sensor/hinge_angle/hinge_angle.c
/__w/zephyr/zephyr/subsys/sensing/sensor/hinge_angle/hinge_angle.c:167:29: error: initializer element is not a compile-time constant
DT_INST_FOREACH_STATUS_OKAY(SENSING_HINGE_ANGLE_DT_DEFINE);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/zephyr/include/zephyr/devicetree.h:4153:25: note: expanded from macro 'DT_INST_FOREACH_STATUS_OKAY'
                              DT_DRV_COMPAT)(fn)),              \
                              ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
/__w/zephyr/zephyr/twister-out/native_posix/samples/subsys/sensing/simple/sample.subsys.sensing.simple/zephyr/include/generated/devicetree_generated.h:3862:61: note: expanded from macro 'DT_FOREACH_OKAY_INST_zephyr_sensing_hinge_angle'
#define DT_FOREACH_OKAY_INST_zephyr_sensing_hinge_angle(fn) fn(0)
                                                            ^
/__w/zephyr/zephyr/subsys/sensing/sensor/hinge_angle/hinge_angle.c:160:2: note: expanded from macro 'SENSING_HINGE_ANGLE_DT_DEFINE'
        SENSING_SENSOR_DT_INST_DEFINE(_inst, &hinge_reg,                        \
        ^
note: (skipping 11 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
/__w/zephyr/zephyr/include/zephyr/sys/util_internal.h:64:39: note: expanded from macro '__COND_CODE'
        __GET_ARG2_DEBRACKET(one_or_two_args _if_code, _else_code)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/zephyr/include/zephyr/sys/util_internal.h:69:65: note: expanded from macro '__GET_ARG2_DEBRACKET'
#define __GET_ARG2_DEBRACKET(ignore_this, val, ...) __DEBRACKET val
                                                    ~~~~~~~~~~~~^~~
/__w/zephyr/zephyr/include/zephyr/sys/util_internal.h:72:26: note: expanded from macro '__DEBRACKET'
#define __DEBRACKET(...) __VA_ARGS__
                         ^~~~~~~~~~~
1 error generated.

I'll check it, thanks.

So I went ahead and changed sensing_connector to store a pointer in the patch I added, but that may not be what you want @lixuzha if you want to copy the struct data rather than using a pointer here. If that's the case then passing the identifier (not the address of it!) through the various define/initializer macros would probably work as well I believe.

Thanks, it's really helpful to me, I like this solution.

Looks like some minor lint issues on the commits and some code lines are preventing CI from being green, please fix this as usually people won't review without a green CI pass

Looks like some minor lint issues on the commits and some code lines are preventing CI from being green, please fix this as usually people won't review without a green CI pass

Fixed.


Deployer broken: create_kolla_playbooks fails installing OpenStack

Since at least today playbook configure_instances.yml is broken. Last working deployment for me was on Friday / two days ago with the same procedure (scripted deployment).
[root@controller-1 contrail-ansible-deployer]# ansible --version
ansible <IP_ADDRESS>
  config file = /root/contrail-ansible-deployer/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Apr 11 2018, 07:36:10) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

[root@controller-1 contrail-ansible-deployer]# ansible-playbook -i inventory/ playbooks/provision_instances.yml

...

PLAY RECAP *******************************************************************************************************************************************************************************************************************************************************
localhost                  : ok=0    changed=0    unreachable=0    failed=0

[root@controller-1 contrail-ansible-deployer]# ansible-playbook -e orchestrator=openstack  -i inventory/ playbooks/configure_instances.yml

...

TASK [create_kolla_playbooks : Clone openstack git repo] *********************************************************************************************************************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "'no' is not a valid boolean.  Valid booleans include: 0, 'on', 'f', 'false', 1, 'no', 'n', '1', '0', 't', 'y', 'off', 'yes', 'true'"}
...ignoring

...

PLAY RECAP *******************************************************************************************************************************************************************************************************************************************************
<IP_ADDRESS>                : ok=38   changed=26   unreachable=0    failed=0
<IP_ADDRESS>                : ok=40   changed=28   unreachable=0    failed=0
<IP_ADDRESS>                : ok=40   changed=28   unreachable=0    failed=0
localhost                  : ok=12   changed=7    unreachable=0    failed=0

[root@controller-1 contrail-ansible-deployer]# ansible-playbook -i inventory/ playbooks/install_openstack.yml
 [WARNING]: Found both group and host with same name: localhost

[DEPRECATION WARNING]: The use of 'include' for tasks has been deprecated. Use 'import_tasks' for static inclusions or 'include_tasks' for dynamic inclusions. This feature will be removed in a future release. Deprecation warnings can be disabled by setting
deprecation_warnings=False in ansible.cfg.
[DEPRECATION WARNING]: include is kept for backwards compatibility but usage is discouraged. The module documentation details page may explain more about this rationale.. This feature will be removed in a future release. Deprecation warnings can be disabled
 by setting deprecation_warnings=False in ansible.cfg.
[DEPRECATION WARNING]: 'include' for playbook includes. You should use 'import_playbook' instead. This feature will be removed in version 2.8. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
ERROR! Unable to retrieve file contents
Could not find or access '/root/contrail-kolla-ansible/ansible/site.yml'
``

bugs should be filed at https://bugs.launchpad.net/juniperopenstack/?orderby=-id&start=0

the issue is related to the deployer not contrail and filling bugs at https://bugs.launchpad.net/juniperopenstack is waste of time

bugs here are not processed

anyway, for this bug instances.yaml and ansible logs are needed.
My run a hour ago was successful with my configs.
And please specify commit ID of your copy ansible-deployer.

https://bugs.launchpad.net/juniperopenstack/+bug/1778457

fixed

@Andrey-mp thanks for the effort