Revision not incrementing if updating build number through build.updatebuildnumber

In order to distinguish between official releases (from our master branch) and private releases from feature branches, I'm trying to update a build number depending on the source branch of the build. To achieve this, I have the build number configured as $(Date:yy).$(Date:MMdd).[BuildType]$(Rev:rrr). Inside a task in the build definition I then replace [BuildType] with either 1 or 2 depending on whether the source branch is 'refs/heads/master', by using the following powershell command:
Write-Host "##vso[build.updatebuildnumber]$BuildNumber"
The problem is that the revision $(Rev:rrr) doesn't seem to get incremented build-over-build. I assume this is because this should only update if nothing else in the build number has changed.
Am I taking the wrong approach to achieve my goal of having a different build number format depending on the source branch? Or is there anything else I could do to ensure the revision gets updated?

please create an issue in the vsts-agent repro.  not an issue with one of the tasks in this repo ..


[BUG] Doesn't work on Nest 6.7

What is the current behavior?
Nest framework logs are not in JSON format:

However, injecting PinoLogger into services and using that, those logs are in JSON just fine.
Please provide the steps to reproduce.
Simply install following readme instructions into the root module:
@Module({
  imports: [
    LoggerModule.forRoot(),
    UsersModule,
  ],
  controllers: [AppController],
})
export class AppModule {}

What is the expected behavior?
Nest framework logs should be in JSON.
Please mention other relevant information such as Node.js version and Operating System.
Node version v12.13.0, OS is Ubuntu latest LTR.
According to the Nest docs:
https://docs.nestjs.com/techniques/logger#logger
You can only replace the logger in NestFactory.create(...);, which happens in src/main.ts in my application.

Found a partial workaround, following the Nest docs.
Changed main.ts from:
(async () => {
  const app = await NestFactory.create(AppModule);
  const config = app.get(ConfigService);
  await app.listen(config.port);
})();

To:
(async () => {
  const app = await NestFactory.create(AppModule);
  app.useLogger(app.get(Logger));  // <-- added this line
  const config = app.get(ConfigService);
  await app.listen(config.port);
})();

And now more of the system logs are JSON:

Looks like it happens asynchronously though and those first logs won't be able to be JSON :thinking:

Hello, all this is described in docs already:
https://github.com/iamolegga/nestjs-pino/blob/master/README.md#usage-as-nestjs-app-logger

@iamolegga Hi, I have the same issue. I understand that it's necessary to add { logger: false } but is there any possibility to log [InstanceLoader] and [NestFactory] with Pino?
In official documentation is a possibility to create a new instance of custom logger directly in NestFactory.create params.

I have another problem - the Nest logger logs all RouteExplorer, RoutesResolver and NestApplication logs but the Pino logs only the first 2 controllers of any module.
Default logger

PinoLogger with Default logger

PinoLogger without Default logger

I am using LoggerModule.forRoot() in app.module.ts.
Thanks for help.

@iamolegga Hi, I have the same issue. I understand that it's necessary to add { logger: false } but is there any possibility to log [InstanceLoader] and [NestFactory] with Pino?
In official documentation is a possibility to create a new instance of custom logger directly in NestFactory.create params.
There is a problem if any error happens due NestFactory creation so there is no error log with the stacktrace.

yep, this is known bug, but as this logger is a little bit complex due to it's functionality and is made in it's own way, that's not matched with official docs. tl;dr there is not such possibility to log [InstanceLoader] and [NestFactory] from the very start so far, but this can be made in future, see discussion in #353

I have another problem - the Nest logger logs all RouteExplorer, RoutesResolver and NestApplication logs but the Pino logs only the first 2 controllers of any module.
Default logger

PinoLogger with Default logger

PinoLogger without Default logger

I am using LoggerModule.forRoot() in app.module.ts.
Note: Ignore the 44 in the console screenshots. It's my custom console.log("44").
Thanks for your help.

that could be a bug related to things discussed before, feel free to open new issue with minimal represented example, but it's not critical for most usages, so I'm not sure if I could find time in near future to fix that, sorry, that's open source, that's how it works 😅

sorry, that's open source, that's how it works 😅

lol 😄


[Improvement] Same tag highlight in edit and reading view

Hi, I love your theme. Thanks a lot for creating it! 🤩
I have one question, though: Is there a reason why tags aren't visualized the same in the edit and reading view?
Example:

Left: Edit view,  Right: Reading view
I really like the "taggish" styling in the reading view so I updated the CSS in the edit view -> Same look:

Code:
/* ----------------------------------------------------------------------------------- */
/* STYLING OF TAGS */

span.cm-hashtag {
  color: var(--text-tag) !important;
  background-color: var(--background-secondary-alt);
  text-decoration: none !important;
  padding: 2px 0px 2px 0px;
}

span.cm-formatting-hashtag {
  padding: 3px 0px 2px 4px;
  border-radius: 4px 0px 0px 4px;  /* left radiuses */
}

span.cm-hashtag-end {
    padding: 2px 4px 2px 0px;
    border-radius: 0px 4px 4px 0px; /* right radiuses */
}

/* ----------------------------------------------------------------------------------- */
/*  Special styling for certain tag words (optional). Suffix the tag name, e.g. "todo" */

span.cm-tag-todo {
  color: #080808 !important;
  background: #d6ae5e;
}

Remarks for others interested:

Tags constists out of several segments, so padding has to be done in multiple elements
Due to multiple segments border radiuses have to be applied only in start and end element
Special tags can be styled quite easily with own css classes (here the #todo example)
The hashtag is somehow rendered 1 pixel too low -> Hashtag color box has an offset (see image below). Solution: Either use a mathematically correct top-padding distance or use a perfect screen-padding. In above example the 3px in the formatting-hashtag for screen-perfect (instead of 2px like other top-paddings).

Offset bug:

This was a good idea and I've implemented it. :-)


Refactor Test Database

Chore
refactor https://github.com/supabase/postgres/blob/develop/.github/workflows/test.yml to accept major version of of postgres and any other needed changes.

This was actually completed by me here https://github.com/supabase/postgres/commit/cb95314be360173d305b9a20b2da3ee252fafca4


rustfmt-nightly not building on latest nightly

On the nightly version rustc 1.24.0-nightly (5165ee9e2 2017-12-22), I get the following error while building rustfmt:
error[E0063]: missing field `recovered` in initializer of `syntax::ast::Block`
   --> /Users/vignesh/.cargo/registry/src/github.com-1ecc6299db9ec823/rustfmt-nightly-0.3.3/src/closures.rs:127:17
    |
127 |     let block = ast::Block {
    |                 ^^^^^^^^^^ missing `recovered`

Caused by https://github.com/rust-lang/rust/pull/46732.

What can we do to fix it? Or do we have to wait for a fix upstream?

I am currently working on it. The new version will be published within an hour.

Published 0.3.4.


RNShapeImageViewPackage.java: error: method does not override or implement a method from a supertype

it shows error while running on android

by removing
 @Override     public List<Class<? extends JavaScriptModule>> createJSModules() {         return Collections.emptyList();     }
from
RNShapeImageViewPackage.java
it should be work

thanks @h4m3d66  , it works for android.
But it also contain issue for IOS as well "RnshapeImageView not exist".

@tusharmutreja Same problem with iOS. I can't make it work. Anyone has any idea?


[RFC] Always create sandbox init process and knobs for joining

In hyperstart, the pod_init process has its own net/pid/uts/ipc ns.
And in kata, these namespaces are also essential.
Net ns for the sandbox should be always created since the container's
network should be isolated from the vm's initial network to
avoid messing.
Pid ns for the sandbox should be always created since the containers
always join this ns. We can use new pid ns for each container,
but in most cases, they are shared the same sandbox init pid ns.
Uts ns for the sandbox should be always created since the hostname
is set in it without mess it up with the vm's initial UTS.
Ipc ns for the sandbox should be always created since the containers
always join this ns. We can use new ipc ns for each container,
but in most cases, they are shared the same sandbox init ipc ns.
So sandbox init process should be always created
in its own net/pid/uts/ipc ns and let the later containers
join in. A pr is required for it
In above info, we know that container should always join the net/uts ns.
And container should NOT use the guest's initial pid/ipc ns.
But container can use the shared or private pid/ipc ns.
We have knob for pid ns. Should we add a knob for the ipc ns?
Or we can make it always to be one of shared or private.

I agree that new namespaces should always be created and we let runtime specify what is shared/private via the OCI spec. The agent should check to make sure no containers join the agent's namespace (except for the user ns?).


[DS-4257] (One Webapp Phase 2) Rename "dspace-spring-rest" to "dspace-server-webapp"

https://jira.duraspace.org/browse/DS-4257
This is Phase 2 of the DSpace Backend as One Webapp code refactor.  It simply does the following:

Rename [src]/dspace-spring-rest module/directory to [src]/dspace-server-webapp
Rename [src]/dspace/modules/spring-rest overlay module/directory to [src]/dspace/modules/server
Update POM description of dspace-rest module to make it clear it is the deprecated REST API
Change all other mentions of "spring-rest" into "server"

NOTE: In a few instances I added reference to a new dspace.server.url configuration that does NOT yet exist. That will come in Phase 3 (see below).

The end result is that this DSpace backend webapp now deploys to http://localhost:8080/server/ by default.
I've tried to keep this PR to ONLY renaming this webapp/module.  This helps make it easy to review (as most of the changes here are file renames), and also attempts to avoid larger scale code conflicts with other PRs.
After this Phase 2 PR is merged, there will be a Phase 3 PR.
In Phase 3, I'll do the following:

Create the new dspace.server.url configuration in dspace.cfg
Replace all usages of dspace.url, dspace.baseUrl and dspace.restURL (in the codebase & tests) with dspace.server.url

This has now been rebased & @AlexanderS's comments were resolved.  Ready again for final review & testing.

After this is merged, we will need to modify the following line.

https://github.com/DSpace-Labs/DSpace-Docker-Images/blob/master/add-ons/angular-tools/environment.dev.js#L7

As agreed in today's DSpace 7 meeting, this is ready to merge.  Merging


daikin-cloud not working anymore after daikin maintenance

Hello,
yesterday I got a message from Daikin that they will do some maintenance on their cloud system.
The daikin app in working again after the maintenance.
Unfortunately the homebridge connect using the daikin-cloud plugin is not working anymore.
I can "activate" the AC in the home app, but nothing happens.

@AboveNBeyondCode no issues after the maintenance here. Could you maybe restart your homebridge instance?

I have the same problem with cloud from yeasterday on my Daikin Altherma 3. I restarted the wifi gateway, the unit connected to the wifi but not to the cloud, the onecta app asks me to add the unit to the cloud but even though I waited for long minutes, it didn't add it.

If the unit does not connect to the cloud this plugin won't work. We connect to Daikin Cloud and not via local network. If you can post the debug logs that might help confirm this is the problem.

I confirm your answer. This morning I managed to connect the unit to the cloud and everything is working. So I think it was some kind of failure on Daikin's side after maintenance.


Building cargo in msys2 on Win64 failing with default instructions

The .travis.install.deps.sh script has various checks for a BITS variable.  It appears that .travis.yml was setting this and calling it appropriately in the CI environment.  However, running .travis.install.deps.sh without BITS set causes everything to default to i686-pc-windows-gnu.
I worked around this by executing BITS=64 ./.travis.install.deps.sh
I don't normally build on Windows, this was my first shot, so I may be doing something wrong.

The instructions now mention running .travis.install.deps.sh, so I believe this is fixed now.


@broskoski => Resolve artist page CTA AB test in favor of new full-screen CTA

Woo!
Closes https://github.com/artsy/collector-experience/issues/149

closing + reopening for Circle

cmon circle

Ok now Circle should pick this up for reals!!

🥗


Avoid serializing the first global label twice

A tiny bug, without actual effect besides the size of the serialized metadata

:green_heart: Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #1414 opened]

Start Time: 2020-09-22T14:06:03.118+0000

Duration: 48 min 37 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
1560

Skipped
12

Total
1572

Steps errors
Expand to view the steps failures

Name: Download Codecov

Description: #!/bin/bash          set -x          curl -sSLo codecov.sh https://codecov.io/bash

Duration: 2 min 22 sec

Start Time: 2020-09-22T14:34:24.453+0000

log


fix: update yarn.lock

fix #104

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Use updated method to lookup extension by unique id

Description
Change method to lookup extension based on unique id after change to access modifiers in ExtensionsManager: https://github.com/opensearch-project/OpenSearch/pull/7374

Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Strange to see the CI failures, the new build artifacts have been pushed to maven?

Not yet for 3.0.0-SNAPSHOT, there hasn't been a successful build since the PR in core was merged.

Codecov Report

Merging #2741 (78cd585) into main (1ff823f) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #2741      +/-   ##
============================================
- Coverage     61.61%   61.36%   -0.26%
- Complexity     3409     3412       +3
============================================
  Files           272      272
  Lines         18751    18850      +99
  Branches       3288     3296       +8
============================================
+ Hits          11554    11567      +13
- Misses         5599     5684      +85
- Partials       1598     1599       +1

Impacted Files
Coverage Δ

...rch/security/transport/SecurityRequestHandler.java
63.70% <0.00%> (ø)

... and 3 files with indirect coverage changes


xfreerdp crashed when copy files that bigger than about 8MB from usb disk to server via gateway connection.

bug reproduce:

Ubuntu14.04 as a client while server2012 or server2016 as a gateway.
extend the usb disk as file system to redirect to server.
copy a big file, which about 8MB or bigger, from usb disk to server.
the xfreerdp crashed immediately.

some personal opinions:

xfreerdp has no send flow control acknowledges mechanism implement when sending data to server
the current xfreerdp gateway implement should be re-designed?

Which version did you use? Nightly/self compiled/...

Yes, this seems like a serious issue.
Still, the info about the client requested in the issue template would be highly appreciated as it cuts down time for analysis/fix/test etc.

thank for you reply, I really appreciate you can fix the bug as soon as possible.

it there any update of this issue?

any updates？

@VizXu Please stop spamming this thread, the issue will be fixed when there is time.

@akallabeth  I added usleep and send_flow_control acknowledge in this thread and it seems work, but when I copy big file, for example 3GB，it also will be cut off. Besides, the mouse and keyboard input event will be delay and the windows seems to be frozen. So this maybe not a resolution but just a work-around.
Maybe your people have a well understand about rdp protocol and could give a resolution.
Thanks.

works with 3.x (although could be faster)


CALLib Problem - Dynamic Constructor

Hi guys, i get stuck at callib:

I have cal/client.py ,define method def Client, that will return 1 instance of resource-side-client class cal/v1/network/client.py. For ex:

   from cal import client
   client = client.Client('1.0.0', 'network', 'OpenStack') # will return instance of Network client class.

cal/v1/<resource>/client.py have class Client - an interface of provider driver(for ex, ...network/driver/openstack.py, class OpenStack must be implement that Client). So, you can use callib like:

   client = client.Client('1.0.0', 'network', 'OpenStack')
   client.create_network(*args)

---> Problem: this line client.create_network(*args) will call exactly create_network method in Client interface, not OpenStackDriver, so it won't return or do anything. I asked @hieulq, and he told me about dynamic constructor.
For test, i have dynamic module:
     dynamic/
    ├── a1.py
    ├── a2.py
    ├── a.py
    └── __init__.py

In a.py:

    class A:
        a_class = a1.A1 # must import a1
        x = a_class()

In a1.py:

    class A1(a.A): # must import a
        pass

--> I get circular dependent imports.

@ntk148v sorry for wrong statement, A1 and A2 must inherit from interface provider and A is test class.
 :))  Then i will close this issue.


1.0 Roadmap

Small roadmap to get to 1.0 for the framework.

[x] #4

[x] Chrome
[x] Firefox
[x] Edge
[x] #58

[x] #3

[x] Click
[x] Type
[x] #55
[x] Load URLs
[x] #32
[x] #54
[x] #33

[x] #17
[x] #27

[x] #16
[x] #28

[x] Execution engine

[x] #15
[x] Compare actual -> expected
[x] #44

[x] Data model

[x] #2
[x] #48

[x] Documentation

[x] #5
[x] #31
[x] #12
[x] #13
[x] #83

[x] Dev environment

[x] #6
[x] Project organization (folder structure)
[x] #7

[x] Packaging

[x] #49
[x] #50
[x] #113

[x] Tools

[x] #63
[x] Excel to POM file
[x] #96

[ ] Reporting

[x] #78
[x] #120
[ ] #136
[ ] #137

[x] User Feedback and Testing

[x] #101

[ ] Excel Test Report

[ ] JSON report to Excel converter

[ ] Install Script
[ ] Tass Orchestration

[ ] new config file
[ ] python module and sub-module organization (tass vs tass-orch)
[ ] refactor existing code

@ty-desj @Pswenne I've added the high priority items to this ticket. Please add additional comments/feedback as needed.


Fix time formatting bug for 12:00 AM

Description
This issue follows from #41 where the same bug is present in a number of the 'en' locales. Any of the en locales which should be formatting time according to the h hour pattern will cause the same bug.
To Reproduce
package main

import (
	"fmt"
	"time"
         en "github.com/go-playground/locales/en_AE"
)

func main() {
	datetime := time.Date(2016, 02, 03, 0, 0, 1, 0, time.Local)
	l := en.New()
	fmt.Println(l.FmtTimeShort(datetime))
}

That code should print 12:00 am but instead it prints 0:00 am.
Changes Required
#44 addresses this fix for the en locale. The same fix needs to be applied to the set of en locales below:

en-001
en-AE
en-AG
en-AS
en-AU
en-BB
en-BM
en-BS
en-CA
en-CY
en-DM
en-ER
en-FJ
en-FM
en-GD
en-GH
en-GM
en-GU
en-GY
en-HK
en-IN
en-JM
en-KI
en-KN
en-KY
en-LC
en-LR
en-LS
en-MH
en-MO
en-MP
en-MW
en-MY
en-NA
en-NZ
en-PG
en-PH
en-PK
en-PR
en-PW
en-SB
en-SD
en-SG
en-SL
en-SS
en-SZ
en-TC
en-TO
en-TT
en-UM
en-VC
en-VG
en-VI
en-VU
en-WS
en-ZM

@deankarn I had a go at fixing this issue.
Can you please take a look and let me know what you think?


Http Response Headers for Error Codes

At present, in case of query failures, Pinot broker returns a 200 HTTP Status Code and the message of the body contains a JSON with the exception and the error-code.
I was wondering if we can also return the error-code in a response header. Say: X-Pinot-Error-Code.
That way callers don't need to un-marshal the JSON blob to check if a given request failed or not.
This would also be helpful for Pinot query proxies where we want to avoid parsing Pinot's response as much as possible.

I think error code 422 make sense here. Thoughts?

I think I can explain better with an example.
The existing API returns responses like this:
< HTTP/1.1 200 OK
< Content-Type: application/json
< Content-Length: 1009
<
* Connection #0 to host localhost left intact
{
  "exceptions": [
    {
      "errorCode": 190,
      "message": "TableDoesNotExistError"
    }
  ],
  "numServersQueried": 0,
  ...

HTTP Status Code is 200, and the error details are in the JSON Blob.
What we were proposing is that we can add a header in the response, X-Pinot-Error-Code, which will be set to the corresponding Pinot Error Code (190 in this case).
We can't change the existing HTTP Status Code because that would be backwards incompatible, so adding a header is a way to hint the caller that there was a error. The goal is that the caller shouldn't have to parse the JSON to determine if a query failed or not.

Thanks for explanation.
Question, in-case of successful response, header value would be 200(I am not sure about Pinot code incase of successful result)?

I think we can set it to -1, but open to suggestions.

Please assign it to me, I will work on it. Thanks

hey @ankitsultana, question:
We have some of the places in the code where we throw exceptions as a HTTP response, for example here or here. For such scenario, in my understanding, we don't set any particular Error Code.
Do you think using some general Error Code in such scenarios is a good idea? We can leverage UNKNOWN_ERROR_CODE or can introduce a new one say FAILED_EXECUTION_ERROR_CODE?

Good catch. I think the broader issue is that we have two kinds of errors:

Ones where a non-200 status code is returned.
Ones where a 200 Status Code is returned.

I think it should be okay to say that this new http response header only tackles Case-2, since case-1 can be detected by simply checking the HTTP Status Code.


php artisan notifynder:push:category

Can you please provide an example about this artisan command?
php artisan notifynder:push:category

I couldn't make it work.
What I have done:
php artisan notifynder:create:group foo.messages
php artisan notifynder:create:category foo.messages.new "You have a new message from {extra.username}"

Then I run
php artisan notifynder:push:category foo.messages --categories=foo.messages.new

..but I get
[ErrorException]
Undefined offset: 1

I don't know if what I've tried make sense, I couldn't find any example in the wiki.
I would like to associate one ore more categories to one group.
Thank you very much.

@fenos Is there any example? Sorry to bother you, I need to use this package in a project that's to be released in a production environment as soon as possible. Thanks for your support!

@eleftrik Sorry that you met this bug, I verified it and fixed. Try to update Notifynder to the next version with a composer update. The command should then work.
Let me know if we can close it

Thank you @fenos. I tried to update, but I can't make it work, my fault.
If I run
php artisan notifynder:push:category foo.messages --categories=foo.messages.new

...I got
[ErrorException]
explode() expects parameter 2 to be string, array given

Can you please provide an example?
Thanks

In fenos\notifynder\src\Notifynder\Artisan\PushCategoryToGroup.php
if I change
    $categoryGroup = array_shift($arguments);
    $categories = explode(',',$arguments);

to
    $categoryGroup = array_shift($arguments);
    $arguments = $arguments[0];
    $categories = explode(',',$arguments);

then it works.

How groups can be used? I couldn't find any reference in the Wiki.

@eleftrik Ops, i think i forgot to add the [0] index, to $arguments how you mentioned.
The groups in Notifynder allows you to send many notifications to a target/s.
So for instance if you want to send 2 or more notifications at the same time to one user you would do:
Notifynder::category('user.following')
            ->from($from_user_id)
            ->to($to_user_id)
            ->url('http://www.yourwebsite.com/page')
             ->sendGroup('Your-group-name');

I never found a use case in my application yet, where I have to send multiple notifications to the same user, but the functionality is there if you need to :) I'm going to re-fix my typo into the artisan command sorry again for the distraction i had

@fenos Thank you so much for your support.
I've another question (a little off-topic), how can I use translations?
I've setup the 'translations' array in config/notifynder.php, but I can't figure out how to use it, which method to call while inserting/sending a notification, etc.
Thanks

Oh, I figured it out:
$n = $user->getNotificationsNotRead()->translate('it');


How to Dynamic adding and removing nodes.

Is your feature request related to a problem? Please describe.
How to Dynamic adding and removing nodes.
Describe the solution you'd like
Dynamically add and delete nodes when I open and collapse them

a ha,I had fix this bug. onTreeNodeClick callback ,treenode.add()

a ha,I had fix this bug. onTreeNodeClick callback ,treenode.add()

Yes, think of it as normal recycler view :D


Problems in Firefox

Using Firefox 38.8.0
I cannot move forward or back more than one month when selecting a date. (June <- July -> August)
When I select date one month forward or back (as far as I can go either way), when I click the day, it scrolls like would if returning to the original month. However, it does change the month and select the correct day.
Summary: Selecting dates in Firefox, I can only select on month forward or back, and have to "scoot" from month to month to get anywhere. Working in Chrome just fine in same App. Recreated using provided component page.

I can confirm this. Plus, if you move month, and then resize the window, the month slides back to the previous month. This is a pretty big show-stopper for this otherwise great component!

I think this is a duplicate of #91, which is already fixed. The problem is there's still no release with this fix.

Sorry for all the delay, this should be included in 1.1.5.


Targeted Frameworks

What frameworks would be best to support?
Apparently dnx451 == dotnet5.4 which changed a while ago, so that should be fixed.
And dnxcore50 falls under dotnet from what I understand.

They are still working on the NET Standard TFM, till then, we can just use net45 to target desktop

On Dec 16, 2015, at 08:17, Eric Tuvesson<EMAIL_ADDRESS>wrote:
What frameworks would be best to support?
Apparently dnx451 == dotnet5.4 which changed a while ago, so that should be fixed.
And dnxcore50 falls under dotnet from what I understand.
—
Reply to this email directly or view it on GitHub.

I switched the project to .NET Standard 1.6.
I didn't fix the appveyor build so it will fail.


Minimum dependencies to removed packages and minimum pre-release packages.

I don't know which Nuget-repository is correct for this bug, but at least this one has the issues tab.
I own a package called Owin.Comperession. It has a following dependency:
Owin (>= 1.0.0-prerelease && <= 1.0.0)
And everything worked fine and everyone was happy. Until one day, the Owin-team unlisted the prerelease-version of the package from NuGet. Now my users started to get build errors.
1.0 is still there. Do you consider all pre-release versions are better than release versions?
A repository to reproduce the issue is here:
https://github.com/jomonson/OwinCompressionDependencyIssue

Thanks for reporting this issue @Thorium. The available versions on nuget.org are 0.5.0, 0.7.0, 0.11.0, 0.12.0, 0.14.0, and 1.0.0. The 1.0.0 version of Owin is the only version that satisfies the version range in your Owin.Compression package. I am not familiar with a 1.0.0-prerelease version of the Owin package. Perhaps it was on some CI or secondary source like MyGet?
Concerning the build failure, I was only able to reproduce a build warning in Visual Studio 2017:
warning NU1603: Owin.Compression 1.0.16 depends on Owin (>= 1.0.0-prerelease && <= 1.0.0) but Owin 1.0.0-prerelease was not found. An approximate best match of Owin 1.0.0 was resolved.

This warning is just saying that 1.0.0-prerelease was not found so 1.0.0 was used instead. NuGet prefers the lowest version in the dependency version range. Is it possible you have warnings as errors enabled?
As a side note, you can test version range compatibility using this tool:
http://nugettoolsdev.azurewebsites.net/4.3.0-preview4/version-satisfies?versionRange=[1.0.0-prerelease%2C1.0.0]&version=1.0.0

My customer says Owin.Compression 1.0.16 gives warning but 1.0.15 error, and it's the same dependency.
I have not used CI or MyGet or any other sources than NuGet.org
Why the warning? So should I release a new package for every removed minimum dependency, saying "no changes" in the release notes?

My customer says Owin.Compression 1.0.16 gives warning but 1.0.15 error, and it's the same dependency.

I am not sure why this is happening and have been unable to reproduce the error. Do you have steps?

So should I release a new package for every removed minimum dependency, saying "no changes" in the release notes?

Yes, that's quite reasonable.

So should I release a new package for every removed minimum dependency, saying "no changes" in the release notes?

Yes, that's quite reasonable

Ok... How do people get notifications of minimum dependency packages not being available anymore?

We do not have a notification mechanism for package deletion since package deletions are a very rare case. Our package deletion policy is here:
https://docs.microsoft.com/en-us/nuget/policies/deleting-packages
Given that 1.0.0 was published in 2012, I don't have any records of whether 1.0.0-prerelease ever existed at all on NuGet.org.

1.0.0 prerelease probably never existed but that's not the question here.
The range is >= 1.0.0-prerelease && <= 1.0.0 and there is a 1.0 of owin. 1.0 is clearly higher than any prerelease and definitely smaller or equal to 1.0. So this version clearly matches this range. Why is it even showing a warning (or crashes)?

All great questions! Let's move this issue over to the NuGet client repository (https://github.com/NuGet/Home/issues) so that the client guys can give all the details. Thanks for all the helpful information!

Issue moved to NuGet/Home #5882 via ZenHub

Please feel free to re-open if you feel this is an issue with NuGet.org itself 👍.

Yes it's probably more a client issue. Thanks
Am 13.09.2017 05:37 schrieb "Joel Verhagen"<EMAIL_ADDRESS>
Please feel free to re-open if you feel this is an issue with NuGet.org
itself 👍.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NuGet/NuGetGallery/issues/4663#issuecomment-329049783,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNK0c5Rf14X8sXPJTAXTFuV9TFvSfks5sh04MgaJpZM4PUP_c
.

That is better repository for this issue, thanks!


Add support for supply chain object module to Sharethrough bid adapter

Type of change

[x] Feature
[x] Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Sharethrough's bid adapter has been updated to support the supply chain object module.
<EMAIL_ADDRESS>- TODO: A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

@maphe - @madma and I DID discuss with Anna.  The prebid.js adapter uses a GET request, so the idea was to attempt a stringification of the schain at first.  The supply chain object should actually be short, probably just one node.

Ok, there was this example of schain object on prebid.org that made me think it can be long
{
  "schain": {
    "validation": "strict",
    "config": {
      "ver":"1.0",
      "complete": 1,
      "nodes": [
        {
          "asi":"indirectseller.com",
          "sid":"00001",
          "hp":1
        }
      ]
    }
  }
}

but if you're confident we'll just get a single node that's fine.
Ref: http://prebid.org/dev-docs/modules/schain.html

Ok, there was this example of schain object on prebid.org that made me think it can be long
{
  "schain": {
    "validation": "strict",
    "config": {
      "ver":"1.0",
      "complete": 1,
      "nodes": [
        {
          "asi":"indirectseller.com",
          "sid":"00001",
          "hp":1
        }
      ]
    }
  }
}

but if you're confident we'll just get a single node that's fine.
Ref: http://prebid.org/dev-docs/modules/schain.html

I agree that we should keep an eye on this, especially since the implementation of the spec in industry is still just getting started. We might see that the nodes list gets really long or that maybe it's not really updated by supply partners along the way.
Should we create a story to revisit this at a later date? I'm tempted to think that the spec and its implementation will come up again in the near future as we and other supply partners adopt, so a story might not be necessary.

@madma - please create a followup story to revisit the effectiveness of this and maybe a crossteam STX/PGE opportunity to observe results and refine the implementation.  We initially pursued this strategy to avoid the larger change surface area of switching to a POST request from the current GET request.


Refactor baremetal machine manager tests

to use ginkgo and gomega

/cc @kashifest
/cc @Jaakko-Os
/cc @Xenwar

/lgtm


Make JSON package manifests more human-readable and generic

NOTE: this is not ready for review.  It is mostly being presented here as a (very clumsy) PoC.  It needs a whole lot of polish, especially on the starlark side.
It's mostly being posted for curiosity, and to make sure there aren't any CI-related surprises later on.
--
This is a change that demonstrates (most of) what's needed to transition to a more verbose and extensible JSON manifest type like the one specified in https://github.com/bazelbuild/rules_pkg/issues/385#issuecomment-974709601.  The rule-facing Starlark APIs have changed little.  I'll probably make the tracing capability more like what's currently in pkg_rpm when pkg_rpm transitions to this functionality in a follow-on change.
Fixes #385.

Nice. I won't be able to take a good look until January.
On Sun, Dec 19, 2021 at 9:27 PM Andrew Psaltis @.***>
wrote:

NOTE: this is not ready for review. It is mostly being presented here as a
(very clumsy) PoC. It needs a whole lot of polish, especially on the
starlark side.
This is a change that demonstrates (most of) what's needed to transition
to a more verbose and extensible JSON manifest type like the one specified
in #385 (comment)
https://github.com/bazelbuild/rules_pkg/issues/385#issuecomment-974709601.
The rule-facing Starlark APIs have changed little. I'll probably make the
tracing capability more like what's currently in pkg_rpm when pkg_rpm
transitions to this functionality in a follow-on change.
Fixes #385 https://github.com/bazelbuild/rules_pkg/issues/385.
You can view, comment on, or merge this pull request online at:
https://github.com/bazelbuild/rules_pkg/pull/493
Commit Summary

6bbec05
https://github.com/bazelbuild/rules_pkg/pull/493/commits/6bbec0527dba58f443cfddde975d57976ff15c2a
Copy the pkg_files module to the new location (for history tracking and
ease-of-diffing)
9b49661
https://github.com/bazelbuild/rules_pkg/pull/493/commits/9b4966129418d652b18369478f8311acec340254
Implement (most) manifest changes.
00ae5bf
https://github.com/bazelbuild/rules_pkg/pull/493/commits/00ae5bf5aea3bfba57771a7b5f36415314a262d5
Fix doc generation
97204c0
https://github.com/bazelbuild/rules_pkg/pull/493/commits/97204c04aa11ab3f5d6d21f1d733e6bc8b59534b
Port pkg_zip
3f1358c
https://github.com/bazelbuild/rules_pkg/pull/493/commits/3f1358c83ed9bacfdd5c0baa2ce23b6fed0ede46
Add tar-with-pfg tests, since there weren't any before.
4467238
https://github.com/bazelbuild/rules_pkg/pull/493/commits/44672386eef9704f34b914b362268ddbdf2a08a4
Aaaand port pkg_tar

File Changes
(8 files https://github.com/bazelbuild/rules_pkg/pull/493/files)

M doc_build/BUILD
https://github.com/bazelbuild/rules_pkg/pull/493/files#diff-851a2e1571e8043c94f9926d2e6184f41caacfe74c461e6ad18e945edbb8d0ce
(2)
M pkg/pkg.bzl
https://github.com/bazelbuild/rules_pkg/pull/493/files#diff-1d225dd31fb922ca2305d466e947f665d472444a8478ccd784f38c987220c369
(2)
M pkg/private/build_tar.py
https://github.com/bazelbuild/rules_pkg/pull/493/files#diff-e23efba1246b39ddcb5f6160a0954ad0d89fec6484a6ecb0c9621ebb99fbe094
(37)
A pkg/private/pkg_files_new.bzl
https://github.com/bazelbuild/rules_pkg/pull/493/files#diff-6ad0d79670be5c078457bba121652754b4c074b2f8a76bb48f717ae9cf3d85d8
(405)
M pkg/private/zip/build_zip.py
https://github.com/bazelbuild/rules_pkg/pull/493/files#diff-3e1f1eb3314e7e04c7d126e1677f616080b61f206acbac459d0208873ec1a400
(16)
M pkg/private/zip/zip.bzl
https://github.com/bazelbuild/rules_pkg/pull/493/files#diff-503b7d9f089eaf09f844907327efbd84f2ad449ea7d7e579fcc0a336c7d483fc
(2)
M tests/tar/BUILD
https://github.com/bazelbuild/rules_pkg/pull/493/files#diff-d7e3db8217e0cd2b3c3791f60aa45026ea6441759d3418f73de895f0fbea4bbb
(50)
M tests/tar/pkg_tar_test.py
https://github.com/bazelbuild/rules_pkg/pull/493/files#diff-018eec6e38daa089b48c603ec5f5d75242037c73cd445db71b29194f3ca9221b
(11)

Patch Links:

https://github.com/bazelbuild/rules_pkg/pull/493.patch
https://github.com/bazelbuild/rules_pkg/pull/493.diff

—
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_pkg/pull/493, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXHHHHMLLE2WE736X2LPW3UR2H7VANCNFSM5KMTXJAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Why the rename to pkg_files_new?


Update resource-group-authoring-templates.md

One-word typo fix

Hi @seanfisher, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@seanfisher : Thanks for your contribution to the Azure documentation! The author, @tfitzmac, has been notified to review your proposed change.

@seanfisher - thanks for making this fix.
@tysonn - this PR can be merged.


Background

Description
Having different backgrounds for the model viewer css property for devices
Samsung Note 20
Samsung s20 FE
For the above two devices the background is white which is not intended

for all the other devices the background is correct which is like Grey radial gradient color as you can see in the image below

Live Demo
https://thecela.com/configurator/b0praVlKQWlvVDkxcHYxM0xLeGdxVEltcU49PQ%3D%3D/QVF0PQ%3D%3D/cDJBdW90PT0%3D/0/QXdWMw%3D%3D
Version
Latest
Browser Affected

[ x] Chrome, version: xx.x.xxxx.xx
[x ] Edge
[x ] Firefox
[x ] IE
[x ] Safari

OS

[x ] Android
[ ] iOS
[ ] Linux
[ ] MacOS
[ ] Windows

Your screenshots appear to be from completely different sites; can you show two that are more comparable? This seems unlikely to be a model-viewer issue, so I'm moving this to a discussion.


3269 describe index endpoint

@Kartones @juanignaciosl CR this please
(I corrected the reference to the ticket)

Frontend tests were OK :+1: (details)

:+1:

:+1:


Support phoenix_html v3.0.0

@danhper Would you be able to review this? If the library is no longer maintained I would be able to provide some support for it.

Can we have a new release?

I totally forget to release the new version ... I'm really sorry, I was focus on company project ...
This new version DO NOT ensure to work with heex. It SHOULD works but nothing was tested and/or validated.


Figure out how to collect metrics

Figure out how to collect metrics.

Notes from Elena:
Look into
ServiceOptions.setClientLibToken
and ServiceOptions.setHeaderProvider
As possible hooks to add user agent strings.

I learned that the JVM Code in the ApiClientHeaderProvider can't be used.
One must check the setting: System.getProperty("org.graalvm.nativeimage.imagecode") == "runtime" to determine if the code is running as GraalVM image at runtime.
I think the best way is to come up with a very simple substitution which checks this property and modifies one of the headers.
Ideally, we modify code in https://github.com/googleapis/gax-java/blob/master/gax/src/main/java/com/google/api/gax/core/GaxProperties.java#L83
Override Java Version maybe?

Sure, we can try the version. Is that field going to be easily accessible for us in the reports?

Completed in https://github.com/GoogleCloudPlatform/google-cloud-graalvm-support/pull/50


Cobra implementation doubt: continuously alternating between 2 audio sources

I have 2 separate mono mics that are placed in different locations. In every iteration of an infinite loop, I collect samples from the mics separately, run VAD on mic1 data first, and then run VAD on mic2 data.
For this use case, do I need to have 2 separate instances of cobra, or will one instance effectively perform VAD on alternating mic1 and mic2 samples?

Yes you will need two instances of cobra, one for each mic source.


Group composition page: join by code

In the "composition" tab of the group page (on a route ".../<group_id>/members"):

title "Current Composition"
add the section "Other ways to add new members to this group" (as done on #/design), only display this section if `group.current_user_can_manage is "memberships" or "memberships_and_group". In this section, only add the "Invitation code" part.
replace the on-off toggle by a way to expand/hide the panel. Collapsed by default if code is null.
for every button below, while processing, put a spinner in the button and disable all the other button of this join-by-code "component"
"code"

case 1: there is no code (code attribute in the group info)

the current code+refresh field are replace by a (same size) "Generate" blue button.
pressing it call  groupCodeCreate (with a spinner), the new code is returned by the service. Display the toast with success/failure.

case 2: there is a code

the current code is displayed (not editable) with 2 icons/buttons:

a blue "refresh" button, calls groupCodeCreate, the new code is returned by the service. Display the toast with success/failure.
a red "X" button, calls https://france-ioi.github.io/algorea-devdoc/api/#operation/groupCodeRemove. Display the toast with success/failure.  Once done (with success), back to "case 1".

when a new code is set or removed, you can assume the code_lifetime is not changed and code_expires_at is set to null (no need to refetch)

validity:

code_lifetime  attribute of groups
the validation button (blue "V" on the right of the input) is only enabled when the value is different from the "backend" value
pressing the validation button (when its value has been changed) calls the groupUpdate service (just providing the code_lifetime in the format "838:59:59").

When updated, fetch the group for getting the new code_lifetime and code_expires_at.
When updated, display the toast with success/failure.

If code_expires_at is not null, display:

if > now(): "This code was first used at dd/mm/yy hh:mm and is now disabled", where dd/mm/yy hh:mm  is code_expires_at - code_lifetime.
otherwise "This code was first used at dd/mm/yy hh:mm and is valid until dd/mm/yy hh:mm",

make sure to handle correctly timezone in the input date/time (display time in the browser TZ)
no "security", no "Automatically create user account"

Completed a while ago.


Feature Request: Publish Wheel

Would it be possible to upload a wheel to pypi? I am attempting to make a nix package depending on Tkinterweb, and am having the usual issues with source-based distributions. Wheels do not appear to be as problematic with nix.

Hi! I just added wheels to pypi. Please let me know if you encounter any issues with them!

Many thanks. I will loop back over the course of the week. The distribution files look good in the meantime.


Problem: BigchainDB 2.0 crashes on the test network.

Description
Tendermint version: 0.12.0
BigchainDB version: 2.0.0a2
On the BigchainDB test network i.e.

test.bigchaindb.com
test2.bigchaindb.com
test3.bigchaindb.com
test4.bigchaindb.com

The BigchainDB process crashes which results in the unavailability of BigchainDB i.e. the HTTP API is accessible but  it is not functional.
The reason for that is, when BigchainDB crashes the connection between Tendermint and the proxy app(BigchainDB) is broken. Kubernetes restarts the crashed BigchainDB instance but Tendermint never initiates the connection towards the proxy app. Which is an expected behavior of Tendermint as discussed here
Solution

The solution to this problem is two fold:

Since BigchainDB and Tendermint are so tightly couple we need to introduce a process supervisor to make the act like a single microservice, so that if BigchainDB crashes, Tendermint does as well and both are restarted and Tendermint requests a connection towards the proxy app.

In Kubernetes, they can be exposed as part of a one POD.
For BigchainDB as a system service/process, we need to introduce a process supervisor such as systemd.

The second resolution is to figure out why BigchainDB is crashing. I have provided some logs that might provide some insight.

2018-04-23T08:16:03.185023163Z [2018-04-23 08:16:03] [DEBUG] (bigchaindb.tendermint.lib) {'jsonrpc': '2.0', 'id': '5b31d30e-29b5-41ef-82c9-7724b373a31d', 'error': {'code': -32603, 'message': 'Internal error', 'data': 'Error broadcasting transaction: read tcp <IP_ADDRESS>:53982-><IP_ADDRESS>:46658: read: connection reset by peer'}} (webapi     - pid: 22)\n
2018-04-23T08:15:26.547564024Z [2018-04-23 08:15:26] [DEBUG] (gunicorn.error) GET / (webapi     - pid: 22)\n
2018-04-23T08:15:30.762913195Z [2018-04-23 08:15:30] [DEBUG] (gunicorn.error) GET / (webapi     - pid: 22)\n
2018-04-23T08:15:31.54679635Z [2018-04-23 08:15:31] [DEBUG] (gunicorn.error) GET / (webapi     - pid: 22)\n
2018-04-23T08:16:16.891529836Z [2018-04-23 08:16:16] [DEBUG] (gunicorn.error) POST /api/v1/transactions (webapi     - pid: 22)\n
2018-04-23T08:16:16.982143203Z [2018-04-23 08:16:16] [DEBUG] (urllib3.connectionpool) Starting new HTTP connection (1): tm-instance-1 (webapi     - pid: 22)\n
2018-04-23T08:16:27.839106752Z \e[32mINFO    \e[0m \e[37mShutting down server\e[0m\n
2018-04-23T08:16:27.839868967Z \e[32mINFO    \e[0m \e[37mShutting down server\e[0m\n
2018-04-23T08:16:27.839890268Z [2018-04-23 08:16:27] [INFO] (abci.app) Shutting down server (MainProcess - pid: 1)\n
2018-04-23T08:16:03.185041164Z [2018-04-23 08:16:03] [ERROR] (bigchaindb.web.views.base) HTTP API error: 500 - POST:/api/v1/transactions - Internal error (webapi     - pid: 22)\n
2018-04-23T08:16:11.37999765Z [2018-04-23 08:16:11] [WARNING] (bigchaindb.tendermint.event_stream) WebSocket connection failed with exception the JSON object must be str, bytes or bytearray, not 'EofStream' (ws_to_tendermint - pid: 17)\n
2018-04-23T08:16:11.54641188Z [2018-04-23 08:16:11] [DEBUG] (gunicorn.error) GET / (webapi     - pid: 22)\n
2018-04-23T08:16:11.546933591Z [2018-04-23 08:16:11] [DEBUG] (gunicorn.error) GET / (webapi     - pid: 22)\n

I collected logs from two separate instances and these exit logs seem to be a commonality between them. I can provide more logs if needed.
I haven't really found particular steps to reproduce, so that is slightly unfortunate.

Myself for part one of the resolution. @vrde and @kansi for the second part.


Performance improvements in kytheuri.Parse. [phab:D1522]

Created by fromberger at 2017-04-14 00:59:47:
Add a simple parsing benchmark and use it to hammer on the performance of
parsing a bit. This change picks up some low-hanging fruit; there is probably
more we can squeeze if we want.

Simplify scheme parsing (shortcut empty; don't loop).
Separate Parse (with unescaping) from ParseRaw (structure).
Split on strings.IndexByte rather than strings.Index.
Streamline the unescaping code (drop bytes.Buffer).

With these changes, the runtime on a trivial benchmark drops by ~57%.

Replace another strings.Index by strings.IndexByte.
Reuse a buffer for unescaping.

fromberger wrote at 2017-04-14 06:48:19:
Another hit from profiling:

Use a custom splitter for attributes.

schroederc commented inline (context lost during migration) at 2017-04-14 16:15:19:
It might be worth separating the return type since the URI cannot have String called on it normally.

fromberger wrote at 2017-04-14 17:23:31:

Make a separate type for raw (escaped) Kythe URIs.

schroederc accepted this revision at 2017-04-14 17:44:20

fromberger commented inline (context lost during migration) at 2017-04-14 17:47:20:
Good idea. I did that. I also added methods to go back and forth between the two representations, and pushed the string-encoding up a level.

fromberger wrote at 2017-04-14 17:47:21:

kytheuri: Add an Encode method to the *URI type.

schroederc wrote at 2017-04-14 17:59:43:
LGTM

fromberger wrote at 2017-04-14 19:12:53:

Export the URI wrapped in a *Raw value.

fromberger closed via commit 4bf509757e0ccf50d719f98e4a2b616be5efff3c at 2017-04-17 12:08:19


Remove two more hardcoded master references

Follows up on https://github.com/dependabot/dependabot-core/pull/6149 by removing two more hardcoded references to master that I discovered.
Originally I assumed we'd need to flip these to HEAD, but in https://github.com/dependabot/dependabot-core/pull/6149 we were able to get away with simply removing the hardcoded reference altogether in the bundler ecosystem and we haven't seen any ill effects the past 6 months...
So let's try removing this and see if it works as smoothly in these ecosystems as it did in the bundler ecosystem.
Fix https://github.com/dependabot/dependabot-core/issues/6202

And two code failures... since these are two separate ecosystems, I'll likely break this into two separate PR's...
I suspect this indicates we'll need to still hardcode some value, but perhaps we can get away with HEAD, otherwise we'll have to have the master vs main conversation... 😩


CI should trigger on PR

https://docs.github.com/en/actions

... and prevent the PR from being merged if the pipeline fails.

Fixed by PR #16


Fix Postgres usage & lineage query

In postgres usage we are filtering the same queries as in lineage. This won't work. Usage should not filter (or only filter creating users, etc)
Revisit how we are getting the timestamp information, as looks like we are joining by database ID and losing the query start time

Once this is done, let's prepare a preview ingestino package

from support https://openmetadata.slack.com/archives/C02B6955S4S/p1662959959461029?thread_ts=1662910860.110539&cid=C02B6955S4S


Parameter completion for arrow/anonymous functions

Auto complete the parameters of anonymous functions. JavaScript and most other languages already name the parameters when the function is defined and you can see these names while you are writing the function, but why not complete the whole statement, or at least complete the names when in the parentheses.
JavaScript already knows the param names

How IntelliJ handles it

Current it seems like the parameter information is received upon completion resolution and not in the completion list.
I wonder if actually pulling up information (or even just the bare minimum to determine whether it is a type that we will be able to query for a snippet later) about all the variables in the completion list will be a performance hit.

So there's not enough upfront information to commit to making the menu item a snippet, but you also can't change it later.

@llllvvuu , if we talk about the language service plugins, there is enough information when you request a completions list. This became possible since TS 5.0, where you can get a type of any completion, so you can resolve all method signature snippets in the list, you can look at the real implementation: https://github.com/zardoy/typescript-vscode-plugins#method-snippets . However, the main issue here is that TypeScript doesn't fully support partial completion resolving eg getCompletionEntryDetails doesn't support a way of resolving insertText of the requesting completion, so you can't compute this method snippet at a later stage, which is a big performance hit. On the other hand, this enables method signature preview in every completion, which is just super handy!


what's the right approach for the root monorepo package and updateInternalDependencies with pnpm ?

our monorepo package.json depends on some of the packages in the monorepo (a jest config preset), so yesterday when i made some changes to the jest config preset package, it didn't update our root package.json. and as a result all our apps triggered a failed CodeBuild deployment due to pnpm install failing (due to the root package jest preset dep version not being bumped).
I've found that if i update our pnpm-workspace.yaml to describe the root package as a monorepo package, then changesets now updates the root package.
Without pnpm-workspace.yaml change
repo/
  package.json
    name: @reckon-web/repo
    deps:
      @reckon-web/jest-preset: 0.0.2

  apps/
    something:
      package.json
        name: @reckon-web/something-app
        deps:
          @reckon-web/jest-preset: 0.0.2

  packages/config/
    jest-preset/
      package.json
        name: @reckon-web/jest-preset
        version: 0.0.2

If i do a changeset like :
---
"@reckon-web/jest-preset": "patch"
---

something something something darkside

then i end up with:
repo/
  package.json
    name: @reckon-web/repo
    deps:
      @reckon-web/jest-preset: 0.0.2

  apps/
    something:
      package.json
        name: @reckon-web/something-app
        deps:
          @reckon-web/jest-preset: 0.0.3

  packages/config/
    jest-preset/
      package.json
        name: @reckon-web/jest-preset
        version: 0.0.3

if i change pnpm-workspace.yaml from :
packages:
  - 'packages/**'
  - 'design-system/packages/*'
  - 'design-system/storybook'
  - 'design-system/website'
  - 'apps/*'
  - 'services/*'
  - 'runbooks'
  - 'infrastructure'

to
packages:
  - '.'
  - 'packages/**'
  - 'design-system/packages/*'
  - 'design-system/storybook'
  - 'design-system/website'
  - 'apps/*'
  - 'services/*'
  - 'runbooks'
  - 'infrastructure'

then the above changeset resuts in :
repo/
  package.json
    name: @reckon-web/repo
    deps:
      @reckon-web/jest-preset: 0.0.3

  apps/
    something:
      package.json
        name: @reckon-web/something-app
        deps:
          @reckon-web/jest-preset: 0.0.3

  packages/config/
    jest-preset/
      package.json
        name: @reckon-web/jest-preset
        version: 0.0.3

Is this the right approach? or should we talk about supporting this via changesets configuration ?

Do you ever use this jest preset directly from the root?

@Andarist we have a jest.config.js in the root of the repo that points at @reckon-web/jest-preset to support debugging anything with vscode. I seem to remember this is the only reason the root package.json has this dependency.

another scenario that comes to mind would be mono repo packages that are in fact cli tools with a bin field in the package.json, unless such a package is a dep of the root package.json then it wouldn't be in the root node_modules/.bin dir

Ok, so to sum up - the proposed change is to just update dependency ranges in <root>/package.json regardless of the list of workspace packages. Would this change alone fix your problem? Do you want to work on a fix?

Ok, so to sum up - the proposed change is to just update dependency ranges in <root>/package.json regardless of the list of workspace packages. Would this change alone fix your problem?

I think so yeah.

Do you want to work on a fix?

I can get started with an anlysis and start from there with a PR ?

Under the hood we are using @manypkg/get-packages to get the list of, well, packages. Luckily the returned value also contains the information about the "root":
https://github.com/Thinkmill/manypkg/blob/b8b914441995ad267a490251d443665fb999e32b/packages/get-packages/src/index.ts#L151-L154
So we only~ need to use this information at the correct time. The dependency ranges are updated within versionPackage  call here:
https://github.com/changesets/changesets/blob/980721dab5df7938a783306a6368f83f1a94c18d/packages/apply-release-plan/src/index.ts#L113-L122
and more specifically in this loop here:
https://github.com/changesets/changesets/blob/980721dab5df7938a783306a6368f83f1a94c18d/packages/apply-release-plan/src/version-package.ts#L41
It's probably quite easy to just "piggy back" on this function and just reuse it entirely. You could create a fake "none" release for the root and just call versionPackage with it.
Note that this might have to be a separate call and that we might not want to just push this fake release to finalisedRelease as this fake release won't have any CHANGELOG associated with it. But maybe it wouldn't hurt anything - you would have to analyze further what happens with this array cause it depends on the current implementation.
And also note that we might have to handle this fake release conditionally as there is a chance that the root is already treated like a package (you have worked around your issue initially exactly like that after all) and we don't want this fake "update" to clash with the one created beforehand.
I think that this is the gist of the work that would have to be done here (+ tests of course). Some additional, minor, issues/questions might araise during the implementation but hopefully not many and not anything that would be blocking.

This would be really helpful for me as well, this is my scenario:

I have a devtools repository where I am hosting my prettier, eslint, etc configs.
My devtools repository has a prettier config.
I am referencing that config in my root's package.json
My monorepo root depends on the workspace containing the config.
I have a Husky hook that runs manypkg check before push

So, after running changeset version, everything works fine, except for the push part, since my config package bumped its version and it didn't get updated in the root package.json, it throws an error.
A workaround I am doing is to run manypkg fix after changeset version and then removing the generated yarn.lock (since I'm using NPM), but that feels hacky.

A workaround I am doing is to run manypkg fix after changeset version and then removing the generated yarn.lock (since I'm using NPM),

This sounds like a bug in manypkg - a yarn lock shouldn't be generated if you are using NPM.

I've described above how one could try to implement this. If you care about this feature I encourage you to work on it and prepare a PR that I could review and merge

A workaround I am doing is to run manypkg fix after changeset version and then removing the generated yarn.lock (since I'm using NPM),

This sounds like a bug in manypkg - a yarn lock shouldn't be generated if you are using NPM.
I've described above how one could try to implement this. If you care about this feature I encourage you to work on it and prepare a PR that I could review and merge

Sure! I will be happy to collaborate. As soon as I have some free time I will try to send a PR!


Relation between JMS Connection / Session / Consumer  and MQ connections

Please include the following information in your ticket.

ibmmq-jms-spring version: 2.2.0
Java version:  AdoptOpenJDK 11.0.9+11.1 (Linux x64)

We are seeing lot more tcp connections between our application and the IBM MQ queue manager
than we expect. The queue manager has a set limit of 250 connections and we are hitting it
even when we think that we have configure our application to use jms connection pooling and
setting the pool to max 1 connection. Relevant config is stated below
The application is listening to more than 50 different queues.
What is the relation between the JMS Connection, Session, Consumer and the tcp connections
that are created?
We have an application with the following configuration set:
ibm.mq.pool.enabled = true
ibm.mq.pool.maxConnections = 1 (default)
ibm.mq.pool.maxSessionsPerConnection = 500 (default)

spring.jms.listener.concurrency = 1
spring.jms.listener.max-concurrency = 50

Each JMS connection and session is effectively a separate MQ connection. So a simple JMS app with a connection+session will usually show up as 2 MQCONN handles. MQCONNs then use the channel SHRCONV value to determine how many connections are established on the same TCP socket. Though the best value for SHRCONV is usually 1, so each MQCONN = 1 socket.

That explains the behavor we see.

closing as answered

Each JMS connection and session is effectively a separate MQ connection. So a simple JMS app with a connection+session will usually show up as 2 MQCONN handles. MQCONNs then use the channel SHRCONV value to determine how many connections are established on the same TCP socket. Though the best value for SHRCONV is usually 1, so each MQCONN = 1 socket.

Which kind of data pass through each connection, because I have this situation as well and 1 connection I always see 4 messages received and another one I able to see the messages my app is sending


Ability to add custom text to generated docs.

Feature Request
Motivation Behind Feature

I need to add some more install and setup instructions to the docs. But it's not possible right now.
Feature Description

It should be possible to add docs from the Fastfile.
Alternatives or Workarounds

Only alternative is create an empty lane with a description. This shows the instructions under available actions title which is not good.

What do you refer to by "generated docs" exactly?

README.md. It's generated from Fastfile after running a lane or running fastlane docs

Some research:
https://github.com/fastlane/fastlane/blob/b2dffaf886dcd6061a88e872eca548a492ca92cc/fastlane/lib/fastlane/lane_manager.rb#L73
https://github.com/fastlane/fastlane/blob/b2dffaf886dcd6061a88e872eca548a492ca92cc/fastlane/lib/fastlane/documentation/docs_generator.rb#L3-L59
Currently not customization possible it seems.


Correction of wrong code at ds/Inorder.c

🐛 Bug Report
Correction of wrong code at Inorder.c
Have you read the Contributing Guidelines on Pull Requests?
Yep !
Description
Inorder Traversal for a binary tree in C language

/assign


Poetry lock: no poetry recursion

Need to pin sentry due to a breaking change, and we can't update without updating AGNOS. See the version in #29263


Meson-python 0.11.0?

Any idea why this isn't being updated by the bot? It's been 9 days.

No idea - I'll open a PR.

Ah, do have an idea - the repo moved.


version check should check >= the latest release

system version checks against the latest release number currently == it should be >=

fixed svn:2328

resolved FW: 20160510_2353


Tests for Reactify login failure

Short Description

I completely forgot to push the tests I already wrote for #465

Changes

Add functional tests

Feedback

Probably none, as you maybe didn't even want them in the other PR? :D (I thought, I'd just push them anyway as I already wrote them^^)

How to review this Pull Request
Link to Confluence (internal)

They are in webapp/client/cypress/integration/loginFailure.spec.js - I'm so confused...why is GitHub displaying the other stuff as changes?! They should already be on main..

Aha..apparently I had to merge main again. 👍 Thanks for the hint.


Assuming Assembly reference when using System.Web.Mvc <IP_ADDRESS> - <IP_ADDRESS>

After upgrading to a newer version of System.Web.Mvc a green squiggly shows under HTML helper methods such as the following when  System.Web.Mvc.Expressions is referenced :
    @using (Html.BeginForm()
    {
    }

On investigation it says that it is assuming reference <IP_ADDRESS> and has found <IP_ADDRESS>
By no means a major bug but it is annoying.

I've just submitted PR #22 to help address this. I hope the maintainer is interested and will publish an updated NuGet package :)

Will this be fixed soon?


[SYCL] Optimise fused batch norm

I created a specialisation for SYCL just to make it more acceptable upstream. I think my change would also make the CPUDevice faster.
The main idea is that the temporary buffers were not needed since for the training they were copied to an output Tensor and for the inference they are already provided as an input.
Another small thing is that we don't want to call eval since it will create a temporary buffer just for storing a difference.
Unfortunately some code is copy pasted, we would need C++14 features to create functions that deduce the return type. That would be great for all functions that return Eigen tensors.
If we accept this here, we will also want to push it to dev/eigen_mehdi

Already accepted on dev/eigen_mehdi, closing here.


include before feature test macro

The __cpp_lib_expected feature testing macro is defined in the  header, so the header is first required.

Ah, thanks for this fix. I had changed the code because I keep getting annoyed by MSVC warnings for the header.


Archiving this feedstock?

Recently the contents of this plugin were upstreamed to OpenMM in PR ( https://github.com/openmm/openmm/pull/4110 ), which has been included in the OpenMM 8.1.0 release ( recently published on conda-forge: https://github.com/conda-forge/openmm-feedstock/pull/120 )
Given this, would it make sense to archive this feedstock?

Yes, it makes sense to archive the openmm-atmmetaforce-plugin feedstock. Its functionality is reproduced by OpenMM 8.1.0's ATMForce().

Thanks Emilio! 🙏
Submitted an archive request with PR: https://github.com/conda-forge/admin-requests/pull/868


Grouping Error in query despite proper grouping in PSQL

Elixir version
1.17.2
Database and Version
PostgreSQL 16.4
Ecto Versions
3.12.3
Database Adapter and Versions (postgrex, myxql, etc)
ecto_ltree 0.3.0, postgrex 0.19.1
Current behavior
I have a table containing lowest level values from a tree structure using an LTREE. The query should return the sum of these values for the direct child nodes of the top node.
I'm encountering a grouping error when executing the following query using Ecto and EctoLtree. This issue does not occur when running the same query directly in SQL:
level = 2
from(t in "table",
  group_by: subpath(t.path, 0, ^level),
  select: %{
    value: fragment("SUM(?)", t.value),
    path: subpath(t.path, 0, ^level)
  }
)
|> Repo.all()

( I also tried using the subpath part inside a fragment, which leads to the same error fragment("subpath("?, ?, ?"), t.path, 0, ^level))
This results in the error:
** (Postgrex.Error) ERROR 42803 (grouping_error) column "t.path" must appear in the GROUP BY clause or be used in an aggregate function
The same query in plain PSQL will not lead to a grouping error:
SELECT
  SUM(t.value),
  subpath(t.path, 0, 2)
FROM table AS t
GROUP BY subpath(t.path, 0, 2);

It seems the problem arises from how Ecto interprets the query, leading to the following SQL being generated:
SELECT
  SUM(t0."value"),
  SUBPATH(t0."path", 0, $1)
FROM table AS t
GROUP BY SUBPATH(t.path, 0, $2);

Here, Ecto uses different parameters ($1 in the SELECT clause and $2 in the GROUP BY clause), causing PostgreSQL to treat them as different expressions and triggering the grouping error.
Expected behavior
There should be no grouping error. Is there a way to resolve this in Ecto, or are there underlying reasons why this behavior occurs?
Thanks

Hi @liambastlhotse ,
Thank you for the report. The way to resolve this in Ecto is to use selected_as. For example you could do
from(t in "table",
  group_by: selected_as(:something),
  select: %{
    value: fragment("SUM(?)", t.value),
    path: selected_as(subpath(t.path, 0, ^level), :something)
  }

HI @greg-rychlewski,
thanks for the fast response. Yes that solves the issue. Thanks.


specifying X509 in the connection string

I am trying to connect downstream device with X.509 CA-signed authentication, but the following exception has been occured:

Should specify either SharedAccessKey or SharedAccessSignature if X.509 certificate is not used

Looking at the SDK code and changed the flag in connection string from x509=true to X509CertPropertyName=true, then the problem was solved. I think the example of connection string in the document should be corrected as follows:
incorrect:
HostName=myiothub.azure-devices.net;DeviceId=myDownstreamDevice;x509=true;GatewayHostName=myGatewayDevice
correct:
HostName=myiothub.azure-devices.net;DeviceId=myDownstreamDevice;X509CertPropertyName=true;GatewayHostName=myGatewayDevice
Thanks,
Yasuhiro

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3512ec24-1146-0dc8-4529-80d4770e1ec2
Version Independent ID: 8abd57ee-a785-4d47-c0e5-6ac713367279
Content: Authenticate downstream devices - Azure IoT Edge
Content Source: articles/iot-edge/how-to-authenticate-downstream-device.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

Thank you for your feedback! We will review and update as appropriate.

Hello @yahanda this is interesting. In the IotHubConnectionStringBuilder.cs file you mention we can see that the last commit was on March 6th and no changes were done regarding "X509CertPropertyName" .

Is the same hapenning when using another language on your IoT Downstream Device?

Please allow me some time to research on this issue and try to repro myself.
Thanks!

Hello @yahanda can you please confirm if the same happens when using another language?
Thanks!

Hello @yahanda ,
I noticed that IoT Edge Repo provides a sample to connect a downstream device using DotNet Core SDK using X509 Authentication: https://github.com/Azure/iotedge/tree/master/samples/dotnet/EdgeX509AuthDownstreamDevice
In that sample we do not need to set the connection string with the flag x509=true
We would rather provide the X509 certificates in PEM format and leave the function DeviceClient.Create take care of the creation of our deviceClient:

            X509Certificate2 trustedCACert = GetTrustedCACertFromFile(TrustedCACertPath);
            InstallCACert(trustedCACert);

            Console.WriteLine("Creating device client using identity certificate...\n");

            var (cert, certChain) = GetClientCertificateAndChainFromFile(DeviceIdentityCertPath, DeviceIdentityPrivateKeyPath);
            InstallChainCertificates(certChain);

            ITransportSettings[] transportSettings = GetTransport(ClientTransportType);
            var auth = new DeviceAuthenticationWithX509Certificate(DownstreamDeviceId, cert);
            DeviceClient deviceClient = DeviceClient.Create(IothubHostname, IotEdgeGatewayHostname, auth, transportSettings);

Can you point us to the sample or code you are using to connect your Downstream device to IoTEdge using csharp SDK?
I believe not all languages work the same. For example in node-sdk you will need to use the flag x509=true indeed: https://github.com/Azure/azure-iot-sdk-node/blob/master/device/samples/simple_sample_device_x509.js .

fyi @kgremban if I am missing any detail.
Thank you!

Hi @asergaz
I'm sorry it takes a long time to reply and I have made some mistakes.
I have accidentally used the sample of EdgeDownstreamDevice instead of EdgeX509AuthDownstreamDevice.
As you pointed out, the EdgeX509AuthDownstreamDevice sample code can be run without specifying x509=true
When using EdgeDownstreamDevice, the following error occurred with x509=true, and when I changed it to X509Cert=true, the error has gone and changed another error, so I misunderstood that it was a document bug. I understand that using EdgeDownstreamDevice sample was a mistake in the first place.
error when specifying x509=true:
Creating device client from connection string

Unhandled exception. System.ArgumentException: Should specify either SharedAccessKey or SharedAccessSignature if X.509 certificate is not used

error when specifying X509Cert=true:
Creating device client from connection string

Edge downstream device attempting to send 10 messages to Edge Hub...

        11/5/2020 11:03:01 PM> Sending message: 0, Data: [{MyFirstDownstreamDevice "messageId":0,"temperature":31,"humidity":72}]
Unhandled exception. System.AggregateException: One or more errors occurred. (Object reference not set to an instance of an object.)

However, when do we use the flag x509=true in the connection string? If it's no longer in use, I think it's a good idea to remove it from the document to avoid confusion.
Thanks!

Thanks @yahanda ,
Like I mentioned, not all SDK lamnguages behave the same. For Node you explicitly need to add x509=true in the connection string.
See: https://github.com/Azure/azure-iot-sdk-node/blob/master/device/samples/simple_sample_device_x509.js
@kgremban do we want to enhance this doc to mention that?
Thanks!

I have assigned the issue to the content author to evaluate and update as appropriate.

@asergaz
I'm pretty sure all Azure IoT SDKs allow one to connect with a SAS token or a certificate. The sample listed above for node references initializing a client with a cert is real, but there are other samples in node that show that not being required (e.g. https://github.com/Azure/azure-iot-sdk-node/blob/master/device/samples/simple_sample_device_with_sas.js)

Documentation does get out of date sometimes.  However, it is very surprising to me that some SDKs that are using x509 don't use the x509=true.
This was NEVER supposed to be a node thing at all.

Here are an example from our tests that use x509:

https://github.com/Azure/azure-iot-sdk-csharp/blob/master/iothub/device/tests/ConnectionString/DeviceClientConnectionStringTests.cs#L95

I've triple checked for .NET. The correct connection string segment is X509Cert=true;

Hello,
I have been trying to follow the same documentation, on how to provision an iot edge transparent gateway and afterwards how to connect a downstream device to the gateway.
The device is provisioned using x509 certificates, and I am working with python SDK.
My problem is; when I want to use this script: send_message_downstream.py with the provided connection string example for a x509 provisioned device from this documentation Authenticate a downstream device to Azure IoT Hub.
I get the following error

ValueError: Invalid Connection String - Invalid Key

After some research I found the following file within the python sdk repo connection_string.py which indicates that the flag "x509=true" is not supported anymore by the python sdk.
Does anyone have any idea what is the alternative, thank you.

From what I understand, the Java and Node.js SDKs use x509=true while C# and C use x509cert=true. I've not gotten a specific answer about Python, but I believe it's based on the C SDK so it stands to reason that Python would also use x509cert=true.
@stevebus @cartertinney @olivakar @elhorton You're all listed as co-authors of the python downstream device sample that @habhachicha referenced. Do you recall what connection string formatting you used when testing the sample?

hello @kgremban, thank you for responding.
I tried it with your suggestion and I still get the same error message.
I think from the connection_string.py script, it won't accept it, because it's not declared as a valid key.
I hope I'll get any clarification of how the x509 is used with the python SDK.
thanks.

Hi all,
Sorry for the slow response - was OOF last week...   The sample at here was not meant to use x509 certificates for authentication...  That sample is only valid with a SAS-Token based connection string.   The sample exists to show how to incorporate the IoT Edge TLS certificate into your python code as a trusted certificate.
This sample ->  https://github.com/Azure/azure-iot-sdk-python/blob/master/azure-iot-device/samples/async-hub-scenarios/send_message_x509.py shows how to authenticate a python client with an x509 certificate, specifically these lines of code...
x509 = X509(
    cert_file=os.getenv("X509_CERT_FILE"),
    key_file=os.getenv("X509_KEY_FILE"),
    pass_phrase=os.getenv("PASS_PHRASE"),
)

# The client object is used to interact with your Azure IoT hub.
device_client = IoTHubDeviceClient.create_from_x509_certificate(
    hostname=hostname, device_id=device_id, x509=x509
)

Unfortunately we don't have a sample that combines both x509 leaf device authentication and IoT Edge.
You might be able to add the parameter 'server_verification_cert=root_ca_cert' (making sure root_ca_cert variable contains your certificate, as in the first sample) to the call to IoTHubDeviceClient.create_from_x509_certificate call above and have it work.  In other words, combine the two samples.   But I don't have an environment set up to test at the moment.
@habhachicha - is that something you can try?
As an aside, one small correction @kgremban - this python SDK was rewritten and is no longer based on the C SDK.  It's native python now.

Closing this issue as resolved.
#please-close


Add support for Tune in Radio

Add support please! ;)

I will try to work on this. :)

I have fired out an email to Tunein about sharing their broadcasts or enabling support for SLS some how.
Hopefully they add support in their next release. :)

duplicate #15

@HumbleBeeBumbleBee  so did they?

Hi @samosfator.
I have sent an email to Tune In<EMAIL_ADDRESS>When I receive a response I will display it in #15.
As of now, no, tunein has not yet been supported.
The discussion regarding 'Tune In' has been moved to #15
Thanks.


Using pip install does not add the kernel to Jupyter

Using pip install does not add the kernel to jupyter, but using python3 ./setup.py install does.
Maybe this is b/c of an outdated package on pypi?

Using pip3 install git+https://github.com/capital-G/sc_kernel.git worked - so this is probably caused indeed by an outdated package


Solution of PD issue 2202

What problem does this PR solve?
UCP https://github.com/pingcap/pd/issues/2202
This PR solves the problem of setting store label forcely and setting multple key/value.
What is changed and how it works?
The pd/server/tools/pd-ctl/command/store_command.go is changed, so that the new store label command can be added. In this file I change the behavior of labelStoreCommandFunc() to accept multiply key/value. The pd/server/api/router.go is changed, and I add a new url pattern to solve the situation of setting labels forcely. The pd/server/api/store.go and pd/server/cluster.go are changed, they now can support setting labels forcely. Finally I modify the pd/tests/pdctl/store/store_test.go to test the new commands.
Check List
Tests

Unit test
In the pd/tests/pdctl/store/store_test.go.
Integration test
None.
Manual test (add detailed scripts or steps below)
No code

Code changes

Has configuration change
None.
Has HTTP API interfaces change (Don't forget to update API document)
Add a handlefunc in pd/server/api/router.go.
Has persistent data change
None.

Side effects

Possible performance regression
None.
Increased code complexity
None.
Breaking backward compatibility
None.

Related changes

Need to cherry-pick to the release branch
No.
Need to update the documentation
Yes.
Need to update the tidb-ansible repository
Maybe.
Need to be included in the release notes
Maybe.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.TaoWei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @Sullivan12138  thanks.
Please sign the CLA firstly and then check the failed test.

Hi @Sullivan12138 , please remove redundant .zip file and sign the CLA and choose a better PR title (for example: support xxx)

Hi @Sullivan12138, Could you fix the ci problem?

Hi @Sullivan12138, Could you fix the ci problem?

ok

Hi @Sullivan12138 , please remove redundant .zip file and sign the CLA and choose a better PR title (for example: support xxx)

OK, I've already deleted it.

Codecov Report

Merging #2248 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2248   +/-   ##
=======================================
  Coverage   76.47%   76.47%
=======================================
  Files         199      199
  Lines       21571    21571
=======================================
  Hits        16497    16497
  Misses       3839     3839
  Partials     1235     1235

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7076f...8f7076f. Read the comment docs.

/merge


Add schedule, remove talks

I assume we don't need the "Talk proposals" section anymore, replaced by this "Schedule" section. Please advise if we need it back. This could be merged once the schedule is finalized for production.
This change looks like this:

Notes:

Spreadsheet is from http://gsx2json.com/api?id=1DsQpdJxF2N0zAR6UM1ornsI5p4dYTU3n6f3vAtQC1BU&sheet=1&columns=false
All avatars now point to @choonkeat because spreadsheet will need to be updated with speaker avatar images.
Schedule is fetched via the gsx2json service, with a cache-first strategy (get from localStorage and render first, while an AJAX call is done to fetch the latest one), to ensure schedule always load even when offline (or slow network) and the latest schedule will always load later if there are changes.
The arrows and talk descriptions will appear conditionally based on the talkdescription and speakername keys.

Wait for @silverframe to finalise the schedule

@silverframe has given the greenlight. Any other blockers?

ok let me remove the tag


Easier maintenance with doc2dash?

There's a great plugin called doc2dash that converts Sphinx-generated HTML docs to Docsets. I think you generate this doctest from the generated HTML pushed to the PEP website which causes #1, but I think it makes a lot more sense to just generate the documentation using Sphinx (so then Sphinx can also resolve all the links to local files) and then generate a Docset from this.
Steps to create a doctest:

Clone the PEPs repo
I also had to remove the initial / in this line so that Sphinx correctly links to other local pages
Optionally: download an image to use as the Docset icon. I called this pep.png
Use doc2dash to generate a Docset: doc2dash build/ -A -I index.html --icon pep.png --online-redirect-url https://peps.python.org

I think this is much easier to maintain than your sync.sh and pepdash.py scripts.

I've submitted a PR for this: https://github.com/Kapeli/Dash-User-Contributions/pull/4131

cool!


fix(libpman): fix fclose

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug
/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
fix one missing fclose
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Great catch Melissa!
/milestone 0.11.0
(might be backported to 0.10.4? /cc @alacuku )

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 3a1e1b43d23f278b5da1161dfb5cbdccc5ca8349

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, incertum, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,LucaGuerra,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

(might be backported to 0.10.4? /cc @alacuku )

Yes, I think so.

/milestone 0.10.4

@alacuku: You must be a member of the falcosecurity/libs-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your maintainers of falcosecurity/libs and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 0.10.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/milestone 0.10.4


grub2: patch CVE-2022-2601 in 2.0

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Patches CVE-2022-2601
Change Log

Patched CVE-2022-2601

Does this affect the toolchain?

NO
Associated issues

#xxxx

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2022-2601

Test Methodology

Pipeline build id: 283832

One thing to notice is that the patch was taking from commits made 5 months ago, but the latest version release and the one we use is 19 months old. One of the file the patch changes has been heavily changed in those 14 months gap. The package builds successfully with check too both locally and on buddy build. But I am curious if we need to take caution into seeing if the 14 months difference in code would either cause issues, bugs or even not fix the CVE.


Failed parsing Firefox header

I tried to parse my browsers header and ran into the invalid media type error indicating that the header is syntactically invalid.
Does that mean that Firefox does not implement the header format correctly or is it an error in this project?
I added a test case for the header (text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8).
Result:
=== RUN   TestGetMediaType/Firefox_header
    contenttype_test.go:221: Unexpected error "invalid media type" for text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8
--- FAIL: TestGetMediaType (0.00s)

Ah nvm, I did not realize there is GetAcceptableMediaTypeFromHeader.


Change VS 2015 mention to VS 2017.

Opening Nancy solution no longer works correctly with VS 2015.

Thanks, and welcome as a Nancy contributor, @RhinoDevel! ❤


Flush can be trigger when rows=0 and size=0

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiFlash version? (Required)

It is probably due to time-period persistence requirements. The whole logic is changed after passive persistence improvement of KVStore. So we'd better close this issue.


how to get boundingbox.txt and keypoints.txt?

Can you tell me the concrete way to get boundingbox.txt and keypoints.txt?

Please see README.


[ConstraintSystem] Add the notion of disjunction partitioning.

Update DisjunctionChoiceProducer so that it creates a sorted ordering
of the choices in the disjunction as well as a partitioning of those
choices.
If we hit the end of a partition and have found a solution, we'll stop
attempting choices from this disjunction.
For now we'll default to keeping the same order that the disjunctions
initially have, and will put them all into the same partition. A
future commit will implement logic to implement more interesting
partitions of the choices.

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@xedin What do you think of this approach to trying groups of disjunctions and stopping as soon as we find a group that successfully solves the system?

@rudkx I think that approach makes sense, if there is a criteria which would be used to partition them!

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@swift-ci Please smoke test OS X platform

@swift-ci Please test source compatibility

Stepping through this I'm realizing that I don't want to use shouldStopAfter(), which only appears to get called on failures, but rather shouldStopAt(), which is called before the attempt, so I'll take a look at that.

Just FYI, the difference between shouldStopAfter and shouldStopAt is that the latter would cause at least one binding from the next partition to be produced, where former is going to stop exactly at the end of the partition.

@swift-ci Please smoke test

@swift-ci Please test source compatibility


Make It Responsive

Page needs to be responsive to size changes

Page is now responsive, aside was a pain in the butt as it was not growing when the work was wrapped down, issue solved though


start page with music loaded

i have a player and i need the set a music from page load.
and when the User click play he already play this music that I set , and if he chooses another song change

I am trying to find out how to do this as well. Any suggestions? How can music be automatically played?

I made "playlist starting on page load". You can use like this:
PS: If yu don't want to play the playlist automatically remove "angularPlayer.play();".
`$scope.homesongs = [{"id":"48","title":"Gülşen - Bir Fırt Çek (Catwork Club Versiyon)","url":"http://www.mixboxx.com/depos/electro-house/gulsen/201702/gulsen-bir-firt-cek-catwork-club-versiyon.mp3","art":"http://www.mixboxx.com/uploads/parca/201702/ctwrk-18022017-001953.jpg","artist":"Gülşen","dj":"Catwork Remix Engineers","durationt":"4:10"},{"id":"3","title":"Desiigner - Panda (Kiko Franco & Kubski Remix)","url":"http://www.mixboxx.com/depos/brazilian-bass/desiigner/201702/desiigner-panda-kiko-franco-kubski-remix.mp3","art":"http://www.mixboxx.com/uploads/parca/201702/panda-05022017-014045.jpg","artist":"Desiigner","dj":"Kiko Franco & Kubski","durationt":"4:35"},{"id":"15","title":"KVSH - Potter (Original Mix)","url":"http://www.mixboxx.com/depos/brazilian-bass/www-mixboxx-com/201702/kvsh-potter-original-mix.mp3","art":"http://www.mixboxx.com/uploads/parca/201702/potter-06022017-160453.jpg","artist":"www.mixboxx.com","dj":"KVSH","durationt":"5:37"}];
angular.forEach($scope.homesongs, function (value) {
angularPlayer.addTrack(value);
});
angularPlayer.play();`


Linkwarden fails to update

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
I'm trying to update Linkwarden to 2.8.4. From inside LXC I'm running
bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/linkwarden.sh)"
which gives me:
cat: /opt/Linkwarden_version.txt: No such file or directory
 ✓ Stopped Linkwarden
 /mv: cannot stat '/opt/linkwarden/.env': No such file or directory

[ERROR] in line 68: exit code 0: while executing command mv /opt/linkwarden/.env /opt/.env

root@linkwarden:~#

What settings are you currently utilizing?

[ ] Default Settings
[X] Advanced Settings

Which Linux distribution are you employing?
Debian 12
If relevant, including screenshots or a code block can be helpful in clarifying the issue.
No response
Please provide detailed steps to reproduce the issue.
Install Linkwarden. Try to run update via script.

wtf? :D check your issue :smile:

Oh, sorry. Wrong copy-paste in my previous message. Now it's edited correctly and problem is still the same.

if you have created the file? :-O

Have you installed linkwarden with the Helper-Script or by hand?
I just tested it with the Script and it works fine.


Alpha version of workbox 5.0.0 has released

Since workbox 5.0.0 alpha 1 and workbox alpha 2 is released, we should bump package.json to v5.0.0-alpha.0, then v5.0.0-alpha.1 , then v5.0.0-alpha.2  to get update with it.
I am thinking about list published version from npm everyday & drop a new version for workbox-cdn if workbox has released a new version.

Master is now pointing to 5.x :)


Source code related to boostrap examples

Hi,
I am a developer and use the jsonForm library.
I am able to download below examples and source code.
https://github.com/jsonform/jsonform/tree/gh-pages/playground
but , i can not find the following example (which is under boostrap3 folder). could you please suggest where I can download these examples from.
http://ulion.github.io/jsonform/playground/bootstrap3/?example=fields-checkbox#
The  dependencies code is not working for 1st url but it works for examples mentioned under boostrap3 folder but i can not see these folder on code download. could you please suggest.
"dependencies": {
"flag": ["adultOnlyInfo"]
}

You are looking at the fork of @ulion so you need to search in the fork to find the example you're looking for: https://github.com/ulion/jsonform

Thank you. my bad....
On Tue, Mar 16, 2021 at 8:47 AM tchap @.***> wrote:

You are looking at the fork of @ulion https://github.com/ulion so you
need to search in the fork to find the example you're looking for:
https://github.com/ulion/jsonform
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jsonform/jsonform/issues/325#issuecomment-800071921,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIYYDZ4ZQVYH46THE2M4RU3TD4LJ7ANCNFSM4ZD3R6UQ
.