Expand to_torchscript to support also TorchScript's trace method

🚀 Feature

Allow for the user to easily choose between TorchScript's script or trace method to create a module.
Motivation

While TorchScript's script method will work for simple models, it will not always work out of the box when models rely on Python variables to be set. This requires the user to manually annotate the model to not run into issues with script().
TorchScript's trace method on the other hand creates a traced module that is determined by running a Tensor through the network and tracks what happens during this process.
This always works, but loses design choices if present in the model.
Both script and trace have their use cases, and with a minimal extension of this function, both methods can be used.
Pitch

Add a method argument that can be set to either script or trace (default to script, which results in the current behaviour).
Add a example_inputs argument that defaults to None and can be set to any Tensor. If None is provided, this function will automatically try to use self.example_input_array. The example input is automatically send to the correct device.
Note: example_inputs's name cannot be changed as this is the name of the argument trace() expects. If named otherwise, there can be a conflict with kwargs.

This change should not break any older scripts, as it by defaults uses script.
Alternatives
Make no change and require the user to overwrite this function to use trace.
Additional context

Please assign me for this request.

There is a problem with your PR regarding the inputs. The example inputs passed to the trace function is not the same as the LightningModule.example_input_array.
From the documentation of trace:

@awaelchli I addressed this in your comment on the pull request revies: https://github.com/PyTorchLightning/pytorch-lightning/pull/4142#discussion_r505113016

To move the discussion from https://github.com/PyTorchLightning/pytorch-lightning/pull/4142#discussion_r511233965 to here @ananthsub 's

IDK how much future support there will be for tracing vs scripting (scripting is strongly recommended).

Could you elaborate on why scripting is strongly recommended? From the TorchScript documentation, scripting and tracing just focuses on different use cases, without a preference for either one. Scripting is positioned as useful when you need control-flow, while trace is simpler to use (no code changes).

Rather than adding more trace support at the top-level of the PL module, why not override to_torchscript in your lightning module to determine how you want to export? then you have way more flexibility with tracing

What flexibility would tracing need? Unlike scripting where you build in some logic, tracing is just throwing in an example batch, and get the resulting TorchScript module.
About "determine how you want to export?", could you elaborate? The to_torchscript() function supports file_path: Optional[str] argument, so you can choose where you save the module. Also the function returns Union[ScriptModule, Dict[str, ScriptModule]], which can be used however you like.

I would like to ask why to_torchscript should NOT implement tracing, and instead ask every user to implement this piece of engineering?

Lightning is also designed for the fast inference AI researchers and production teams need to scale up things like BERT and self-supervised learning. Lightning can automatically export to ONNX or TorchScript for those cases.

Imagine a team with a data scientist good at training a model (Python), but knowing little of engineering (in this example C++), and an engineer good at C++, but has no idea what the model does internally. The engineer just wants to TorchScript model and the Data Scientist has never brought a model to production, but heard that TorchScript is useful to transfer this model to production.
In case of scripting, likely the data scientist is the one who needs to figure out how TorchScript works and how to decorate his/her model to do proper scripting. Tracing on the other hand requires no extra knowledge, just call to_torchscript(method='trace', file_path="some_where", example_inputs=batch). The data scientist now has a model that can be given to the engineer by just calling 1 function.

@suo is there guidance that PyTorch/JIT can share for tracing vs scripting? My understanding is that more use cases should adopt scripting, but maybe that's too naive on my part

With the PR: https://github.com/PyTorchLightning/pytorch-lightning/pull/4360 being merged, example_inputs can now handle torch.Tensor and Tuple[torch.Tensor]:
https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/core/lightning.py#L1599
While according to the [TorchScript docs (under Automatic Trace Checking)], example_inputs does not support a dict, @rohitgr7 has found out that TorchScript actually does support a dict.
However, if you try a dict now, you would get the error:

AttributeError                            Traceback (most recent call last)

<ipython-input-11-1f9f6fbe4f6c> in <module>()
----> 1 test_x(tmpdir)

10 frames

/usr/local/lib/python3.6/dist-packages/torch/nn/functional.py in linear(input, weight, bias)
   1670         if any([type(t) is not Tensor for t in tens_ops]) and has_torch_function(tens_ops):
   1671             return handle_torch_function(linear, tens_ops, input, weight, bias=bias)
-> 1672     if input.dim() == 2 and bias is not None:
   1673         # fused op is marginally faster
   1674         ret = torch.addmm(bias, input, weight.t())

AttributeError: 'dict' object has no attribute 'dim'

Who (Lighting/PyTorch/TorchScript) is the cause for this error still needs to be determined. Therefore, it's better to keep this issue open until Dicts are supported (or determined that Dicts cannot be used).
Related issue: https://github.com/PyTorchLightning/pytorch-lightning/pull/4378

The forward function above doesn't accept dict that's why that error is coming up.
if the forward function is something like:
def forward(self, batch):
    x = batch['x']
    return self.model(x)

and you would run torch.jit.trace() on this with dict example_inputs it won't throw an error and will give you a torchscript module. The reason I think that PyTorch specifies that it should be a Tensor or tuple of Tensors is because it is acceptable in other environments like C++ with no python dependency where there is no such thing like dict. Not sure if this is the correct reason since I haven't worked with torchscripts before, so need to check the reason whether it's a bug/documentation error or something else.

@ananthsub Scripting is generally recommended. Since the tracer can only record observed tensor operations, there are a number of corner cases where the resulting graph may not generalize in surprising ways. Common pitfalls include: control flow, device-specific code, different sizes, etc.
That said, if tracing works (and tracing generally works well for a large class of models that don't have any control flow), then it is perfectly fine to use.


How to Use Compiler In Android app

🙋🏻♂Can You Help Sir,

I am Create Gta Sa Cleo Editor app For Android
i need compiler for this
How i Can Use?
Can you make Compiler in Java and You Give me Source Code
Please Help me Sir,
Thank You
MyYouTube Channel

Sir,
Please Tell

How to Work Compiler
how Encrypt Code Of scm Lang

Encrypt Key or encryption Lavel
I am Create Compiler Java
Please Help me sir


Stepping context stream shows raw events rather context sub-stream in source pane

In the above example the context data is XML.  It is showing the data child stream.  The input/output panes or the subsequent elements are ok though.

Fixed in >7.0.1


Only combine match if its condition expression fits in a single line

This improves the formatting and reading of code avoiding the
condition expression to be rewrite, if it goes multi line.
Fixes: #3029.
Signed-off-by: Otavio Salvador<EMAIL_ADDRESS>

I can certainly try. Let dig into it...


[e2e]: container-based schedule main gcp-workload-identity slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/5792342114
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container-based.schedule.main.gcp-workload-identity.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container-based.schedule.main.gcp-workload-identity.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Aug  8 03:23:33 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/5804468702
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container-based.schedule.main.gcp-workload-identity.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container-based.schedule.main.gcp-workload-identity.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Aug  9 03:20:53 UTC 2023
Tests are passing now. Closing this issue.


Sourcemaps are off for vue files with script setup

Describe the bug
Sourcemap being generated is off by a few lines.  The problem is occuring when I have both the quasar plugin and the vue 3 plugin added to the vite config.
While narrowing down to a minimal reproduction of this issue I noticed that this issue seems to be specifically related to using script setup  and quasar automatically importing components that are used if it is not already imported.  As removing setup from the script tag or manually importing the used quasar component resolves the issue.
Not completely sure if the issue is vite specific or one of the two plugins in my reproduction.
Reproduction
https://github.com/kalvenschraut/vite-sourcemaps-repro
System Info
System:
  OS: Linux 5.10 Ubuntu 20.04.3 LTS (Focal Fossa)
  CPU: (24) x64 AMD Ryzen Threadripper 2920X 12-Core Processor
  Memory: 47.60 GB / 50.11 GB
  Container: Yes
  Shell: 5.0.17 - /bin/bash
Binaries:
  Node: 16.13.1 - /usr/bin/node
  npm: 8.3.0 - /usr/bin/npm

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Problem had to due with the new lines being added by the quasar plugin for each auto import it was doing. Not sure if it is expected behavior or if vite should be able to account for any new lines added and update the sourcemaps.
Going close this since the merged PR fixes my specific issue.

@sodatea  Do you know if the above behavior is correct in vitejs? Or am I working around a vitejs issue with my PR for quasar's plugin.


Add a service for mev-boost

Currently, running a mev-boost instance requires some configuration we can take care of by implementing a service.

Hi, is this still available? Would love to take it up. :)

@ameya-deshmukh Please go ahead!

We had since then one PR bringing support to mev-boost by @RichardWarfield . I adapted his work on this PR .

Closed by #280


[FEATURE-REQUEST] Port to Tailwind CSS

The dashboard looks nice, but probably tailwindcss will provide a higher level of customization.
Additionally I found that SB-Admin is not very nice on mobile, I know there is a small audience using backend on mobile, nevertheless if we could tackle this early rather than later it would be awesome
[https://www.creative-tim.com/learning-lab/tailwind-starter-kit/dashboard]

Above Create-Tim is providing a skel for Dashboard which is MIT licensed. It might be a good fit, although it would be worth doing more research.

I know there is a small audience using backend on mobile

I actually got more comments than expected from people "complaining" that it doesn't render nicely on mobile. So your point is valid.

I am hesitant a little bit about this suggestion. Looking into the tailwind ecosystem, although it's nice and very promising, it hugely lacks the size and support that other popular frameworks have, like bootstrap and foundation for example. This might make it a little bit harder or inconvenient to contribute to kaffy or create some extensions.

It's a very valid, point... I was also a bit concerned about it to be frank.
Maybe one we need it's to find a good replacement to sb-admin which work better on mobile.
There is coreui for instance.
Here a list https://dev.to/sm0ke/admin-dashboards-open-source-and-free-4aep
It might be to do some research if we find a better fit that is MIT licensed.

I'm leaning towards CoreUI and Material Dashboard.
I feel that Material Dashboard is much cleaner, yet CoreUI has a lot of extra components that could be used currently and in the future. Personally, I'd go with cleaner.
One missing point with Material Dashboard is the menu subitems. However I feel that could easy be added.

A pity we could not talk/debate more before moving ahead, I see you implemented https://github.com/BlackrockDigital/startbootstrap-sb-admin
To my opinion this feels like a step back in terms of design (personal taste of course), I would agree that the left menu is better but the rest feel like a downgrade.
I was doing some research yesterday to find a good replacement.
The main points to tick might be:
MIT license, based on Bootstrap4, nice default form, good render on mobile devices, modern look&feel (although this is very subjective)
Here some options:

Start-Admin & Purple: https://www.bootstrapdash.com/bootstrap-free-admin-templates/
Overall good, nice on mobile and the default theme for form and table are good enough
Adminator - https://github.com/puikinsh/Adminator-admin-dashboard
Although a bit to white for my taste, it ticks a lot of box

Now looking at https://github.com/BlackrockDigital/startbootstrap-sb-admin-2 in the original template there is a top bar, I understand it was tempting to remove it.

That small menu icon allow you to hide the menu:

There is an issue that explain how to hide the left menu by default:
https://github.com/BlackrockDigital/startbootstrap-sb-admin-2/issues/335
So probably if the motivation to move to an other template is only the mobile rendering, I would advice we consider hacking the left menu to improve it and try to mimic the behaviour, for instance opening down the menu:

Rest assured, this is not the design I want for kaffy. I will not take UI decisions without pinging you first 😄. I actually was waiting for your opinion on this. This is why it's still open. I don't trust my design choices and, as mentioned before, this is my weak point. I did it to see how long it would take to port to a new design and for you to try it out and provide feedback.
I don't like the overall design either and liked the light colors of the previous design better. The port took about 1 hour or so. I checked both designs (star-admin and adminator) before getting sb-admin and I liked them both (leaning more towards adminator).

There can be nice alternatives indeed.
Unfortunately Adminator behave weirdly on vertically on some mobile size:

Fonts are super small, when you turn the device in horizontally the problem goes away.
star-admin-free is very nice, but they don't have icon in the menu and it's not hideable on big screen, a feature I personally like
Purple tick a lot of boxes: https://www.bootstrapdash.com/demo/purple-admin-free/pages/forms/basic_elements.html | https://github.com/BootstrapDash/PurpleAdmin-Free-Admin-Template
Although it's too white and also the gradient is something out of horror movie that should be fixable.
Hard to find the perfect one under MIT license.

I'm not too familiar with using licenses with open source projects. Is there an option to get a paid template (with a license other than MIT) and include it in kaffy? If so, do you recommend any templates?

Including code in a project that is freely distributed is tricky, you need the license of the code that you will include to be permissive enough. That will not be an option for something that you can purchase as they will not want to let you distribute it freely.
https://tldrlegal.com/ most of the one we looked at are MIT https://tldrlegal.com/license/mit-license
Which will be perfect to include into Kaffy

the gradient is something out of horror movie that should be fixable.

😂
I find it nice, although yes it's a bit too white.
We could always tweak it.

Whatever we chose, it will probably be modified to some extent. I'm very interested in closing this as soon as possible because I feel other issues will depend on it to some degree. I trust your judgement in this regard, so I'll go with whatever template you feel fits Kaffy the most.
This is what I think of the designs:

CoreUI: I like the professional look of it. It has TONS of components that could be very beneficial and give Kaffy an edge with customizations and options. I like it a lot. Thinking loudly here, but it might be the easiest to work with when Kaffy has support for telemetry and LiveView.
Purple: Clean, simple, although the colors of it can potentially be very "off" when integrated with other websites. I wish CoreUI had Purple's feel and simplicity. But between them, I'd choose CoreUI.
Star Admin: It might be the closest to the original design of Kaffy in terms of color/layout combination. The lack of a built-in way to hide the side-menu on desktop might mean this is a "no" by default. But I like the collection of components (second to CoreUI) and the amount of icons it supports. I would definitely change the main color though since it feels a little bit too "saturated"? (if that's actually the meaning I'm trying to think of).
Adminator: I like its simplicity very much. It has a nice combination of widgets/components. The fact that it doesn't render nicely on some non-typical screen sizes might not be a deal-breaker. I tried it on a few iOS simulators (iPad and iPhone X) and it displays correctly. I agree that fonts are smaller than normal, but personally I like smaller fonts in general, specially if I can control it to my taste.

Eventually, I'd like to go with something else other than (sb-admin) to something more complete and cleaner. I vote for (1) CoreUI and (2) Adminator.
What do you think?

I could not agree more with more of your comments, thanks for sharing.
CoreUI has a lot of components but in reality they are just showing what bootstrap4 can do, they just spend more time copying all the bootstrap components.
I really like the icons in the menu staying when closing the menu on desktop view, I found this style giving a very neat and professional feeling, the way you had it originally with Kaffy.
I've been working the last hours on Purple, I think it has potential, so I tried to fix few things in the style to match the original style of Kaffy.
https://github.com/areski/PurpleAdmin-Free-Admin-Template
That's how it looks:

Menu closed:

I was just working on a nice palette:

On Mobile when opening the menu:

I'm not a designer... so everything is really subjective to my taste :smile:
I still want to import the shadow on the card element as you had before:

Comments will be welcome, you can fork https://github.com/areski/PurpleAdmin-Free-Admin-Template and play with it too if you think we are in the right direction.

and Voila!
Just added the shadow & also the left/bottom colored border which looked awesome on the first kaffy dashboard:

added also a shadow on the navbar and copied the same color background, the previous one was too grey.

The icon is the one of Purple template, we could use that for now and replace it by a future icon.
See what you think and let me know

Amazing work Areski! It's hard to believe you're not a designer. That settles it. We will use this template. I'll replace the current design with yours. The next 24 hours will be interesting for Kaffy. Thanks a lot 👍🏼.

Glad to help, I will leave that with you then!

This is just amazing, great accomplishment in such a short time!
Can't wait to see how Kaffy will look in the coming weeks :smile:
Thanks!


New implementation of init command using our templating engine

New implementation of init command using our templating engine

@spericas Is this ready to review ?

@romain-grecourt Yes, and also take another look at https://github.com/oracle/helidon/pull/1797

@romain-grecourt Since you don't have any strong objections, I'll go ahead with the merge. If you feel strongly about the missing test, we can bring it back.

@spericas This is fine, we can revisit a usage test if/when we break it.


Modernize the packaging standards and support Windows

There's a problem with uv's locking, so there are basically three options:

Drop support for Python < 3.7
Run uv venv -p3.$i && uv pip install -e .[tests] && .venv/bin/pytest -vv instead of uv run -p3.$i --extra=tests pytest -vv
Subject the pyproject.toml to this monstrosity:

[project.optional-dependencies]
tests = [
    "pytest>=2.8.0,<6.2.0; python_version == '3.5'",
    "pytest>=3.0.7,<7.1.0; python_version == '3.6'",
    "pytest>=3.4.1,<8.0.0; python_version == '3.7'",
    "pytest>=4.6.10; python_version == '3.8'",
    "pytest>=5.4.2; python_version == '3.9'",
    "pytest>=6.2.5; python_version == '3.10'",
    "pytest>=7.2.1; python_version == '3.11'",
    "pytest>=7.3.2; python_version == '3.12'",
    "pytest>=8.2.1; python_version >= '3.13'",
]

Which is your favorite?

Drop support for Python < 3.7

We can gladly drop support for 3.6, 3.7 and 3.8 (https://devguide.python.org/versions/), if it's up to me.

Thank you!


Appended table of documents to the Collection letter note

Hi,
The appended table to the Collection letter notes only includes past due open transactions.
Is there a way to change this to include all open transactions (overdue and not overdue)?
Thanks.
Best regards, Rui

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

 Unfortunately, we're unable to handle Support requests for the product here. To contact Support, consider one of the options described here: Support contact options. In particular, you might want to go to the Dynamics 365 community page to get help with your questions from the Dynamics community.


Add MetricPipeline API

Description
The PR adds a MetricPipeline API with the related controller.
Changes proposed in this pull request:

Add MetricPipeline CRD
Add controller for MetricPipeline

Related issue(s)

https://github.com/kyma-project/kyma/issues/16996

/retest pull-telemetry-manager-integration-test

/test pull-telemetry-manager-integration-test


Missing information about the kind of charging point

For the usage of the SimBEV data in grid friendly charging strategies it's neseccary that it is known if the charging process takes place at a public or private charging spot. At the moment this information is missing.

Update from meeting:
Continue discussion in the next meeting (05.08.) and after #28 is solved: Define beforehand using stats VS define when siting the LIS


Codeunit 740 VAT Report Mediator

Could you change the code as follows
local procedure GetVATReportConfiguration(var VATReportsConfiguration: Record "VAT Reports Configuration"; VATReportHeader: Record "VAT Report Header")
    begin
        //OLD
        case VATReportHeader."VAT Report Config. Code" of
            VATReportHeader."VAT Report Config. Code"::"VAT Return":
                VATReportsConfiguration.SetRange("VAT Report Type", VATReportsConfiguration."VAT Report Type"::"VAT Return");
            VATReportHeader."VAT Report Config. Code"::"EC Sales List":
                VATReportsConfiguration.SetRange("VAT Report Type", VATReportsConfiguration."VAT Report Type"::"EC Sales List");
        end;
        //OLD
        //NEW
         VATReportsConfiguration.SetRange("VAT Report Type", VATReportHeader."VAT Report Config. Code");
        //NEW
        if VATReportHeader."VAT Report Version" <> '' then
            VATReportsConfiguration.SetRange("VAT Report Version", VATReportHeader."VAT Report Version");
        VATReportsConfiguration.FindFirst();
    end;

Both fields are currently of type Enum VAT Reports Configuration.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Upgrade to Ops Agent fails

I'd like to upgrade to the ops agent to get GPU metrics.
Image family: slurm-gcp-5-10-ubuntu-2004-lts
Machine type: a3-highgpu-8g
Upgrade command given to me from the monitoring page in the google cloud console and run in cloudshell:
:> agents_to_install.csv && \
echo '"projects/$PROJECT/zones/europe-west4-b/instances/$INSTANCE","[{""type"":""ops-agent""}]"' >> agents_to_install.csv && \
curl -sSO https://dl.google.com/cloudagents/mass-provision-google-cloud-ops-agents.py && \
python3 mass-provision-google-cloud-ops-agents.py --file agents_to_install.csv

Error:
W: Conflicting distribution: https://packages.cloud.google.com/apt google-cloud-logging-focal-all InRelease (expected google-cloud-logging-focal-all but got google-cloud-logging-stretch-all)
E: Repository 'https://packages.cloud.google.com/apt google-cloud-logging-focal-all InRelease' changed its 'Codename' value from 'google-cloud-logging-focal-all' to 'google-cloud-logging-stretch-all'

Can you confirm what Ops agent is installed currently ?
dpkg -l | grep google-cloud-ops-agent

Nothing shows up with that command. I solved the issue by editing /etc/apt/sources.list.d/google-cloud-logging.list
# Old entry
#deb https://packages.cloud.google.com/apt google-cloud-logging-focal-all main
# New entry
deb https://packages.cloud.google.com/apt google-cloud-logging-stretch-all main

I am able to reproduce myself and believe it is a bug in the mass-provision-google-cloud-ops-agents.py you reference. I have raised with the team responsible for that script.

Thanks for flagging this -- this is definitely an issue on the agent side, and we're actively working on a fix. For now the workaround you're tried should suffice, but once we fix it from our end you might have to change it back to focal. (It was unintentional from our end to serve stretch in the first place, and the fix will involve setting it back to focal.)
Another workaround would be to pass --allow-releaseinfo-change-codename to apt update.

Thanks for the report @Tristan-Kosciuch and for the response @jefferbrecht. I am going to close this issue as it is not directly related to the HPC Toolkit.

We've resolved the issue on our end and are currently rolling it out. @Tristan-Kosciuch, you might see the same error again once this rolls out -- to fix it, you should be able to switch back to google-cloud-logging-focal-all in your /etc/apt/sources.list.d/google-cloud-logging.list (or try apt update --allow-releaseinfo-change-codename).


Cannot install cloudflare/cloudflare provider via normal method, download works

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.6.4
on linux_amd64
Affected resource(s)
Installing the provider.
Terraform configuration files
terraform {
  required_version = ">= 0.14.0"

  required_providers {
    cloudflare = {
      source  = "registry.terraform.io/cloudflare/cloudflare"
      version = ">= 4.19.0"
    }
  }
}

provider "cloudflare" {
  # Configuration options
}

Link to debug output
https://gist.github.com/moritonal/99c709ab127c9fe9b879d1d03c8c9478
Panic output
No response
Expected output
Initializing the backend...
2023-11-20T23:02:43.703Z [DEBUG] New state was assigned lineage "22cc9353-bac6-3802-98d3-ae3dafb17bf7"
2023-11-20T23:02:43.703Z [DEBUG] checking for provisioner in "."
2023-11-20T23:02:43.705Z [DEBUG] checking for provisioner in "/usr/bin"
2023-11-20T23:02:43.705Z [DEBUG] checking for provisioner in "/home/node/.terraform.d/plugins"

Initializing provider plugins...
- Reusing previous version of cloudflare/cloudflare from the dependency lock file
- Installing cloudflare/cloudflare v4.19.0...
- Installed cloudflare/cloudflare v4.19.0 (unauthenticated)

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

Actual output
Initializing the backend...
2023-11-20T23:01:03.524Z [DEBUG] New state was assigned lineage "7d188476-98db-373b-b17d-c83f8c225df3"
2023-11-20T23:01:03.524Z [DEBUG] checking for provisioner in "."
2023-11-20T23:01:03.526Z [DEBUG] checking for provisioner in "/usr/bin"

Initializing provider plugins...
- Reusing previous version of cloudflare/cloudflare from the dependency lock file
2023-11-20T23:01:03.526Z [DEBUG] Service discovery for registry.terraform.io at https://registry.terraform.io/.well-known/terraform.json
2023-11-20T23:01:03.694Z [DEBUG] GET https://registry.terraform.io/v1/providers/cloudflare/cloudflare/versions
2023-11-20T23:01:03.747Z [DEBUG] GET https://registry.terraform.io/v1/providers/cloudflare/cloudflare/4.19.0/download/linux/amd64
2023-11-20T23:01:03.801Z [DEBUG] GET https://github.com/cloudflare/terraform-provider-cloudflare/releases/download/v4.19.0/terraform-provider-cloudflare_4.19.0_SHA256SUMS
2023-11-20T23:01:13.803Z [ERROR] GET https://github.com/cloudflare/terraform-provider-cloudflare/releases/download/v4.19.0/terraform-provider-cloudflare_4.19.0_SHA256SUMS request failed: Get "https://objects.githubusercontent.com/github-production-release-asset-2e65be/93446113/84bfe2a0-93f0-479c-b9fe-9751ed7cf660?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20231120%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20231120T225940Z&X-Amz-Expires=300&X-Amz-Signature=5554acdc36b86a838b608c9c844ff1624018f28e807dea9f83e73bdb711d3ee6&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=93446113&response-content-disposition=attachment%3B%20filename%3Dterraform-provider-cloudflare_4.19.0_SHA256SUMS&response-content-type=application%2Foctet-stream": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
2023-11-20T23:01:13.803Z [DEBUG] GET https://github.com/cloudflare/terraform-provider-cloudflare/releases/download/v4.19.0/terraform-provider-cloudflare_4.19.0_SHA256SUMS: retrying in 1s (1 left)
2023-11-20T23:01:14.803Z [INFO]  Previous request to the remote registry failed, attempting retry.
2023-11-20T23:01:24.804Z [ERROR] GET https://github.com/cloudflare/terraform-provider-cloudflare/releases/download/v4.19.0/terraform-provider-cloudflare_4.19.0_SHA256SUMS request failed: Get "https://objects.githubusercontent.com/github-production-release-asset-2e65be/93446113/84bfe2a0-93f0-479c-b9fe-9751ed7cf660?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20231120%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20231120T225959Z&X-Amz-Expires=300&X-Amz-Signature=f737ec5543032d8694ca61450ea132dfb21914ee3afe00559782f060e19b6a99&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=93446113&response-content-disposition=attachment%3B%20filename%3Dterraform-provider-cloudflare_4.19.0_SHA256SUMS&response-content-type=application%2Foctet-stream": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
╷
│ Error: Failed to install provider

Steps to reproduce
My setup is a Windows VSCode DevContainer running the following:
devcontainer.json
{
	"name": "Node.js & TypeScript",
	"build": {
		"dockerfile": "Dockerfile"
	},
	"customizations": {
		"vscode": {
			"extensions": [
				"dbaeumer.vscode-eslint"
			]
		}
	},
	"remoteUser": "node"
}

Dockerfile
FROM mcr.microsoft.com/devcontainers/javascript-node:18

RUN npm config set script-shell /bin/bash
RUN npm install -g wrangler

RUN sudo apt-get update && sudo apt-get install -y gnupg software-properties-common

RUN wget -O- https://apt.releases.hashicorp.com/gpg | gpg --dearmor | sudo tee /usr/share/keyrings/hashicorp-archive-keyring.gpg

RUN echo "deb [signed-by=/usr/share/keyrings/hashicorp-archive-keyring.gpg] \
https://apt.releases.hashicorp.com $(lsb_release -cs) main" | \
sudo tee /etc/apt/sources.list.d/hashicorp.list

RUN sudo apt-get update
RUN sudo apt-get -y install terraform

Additional factoids
I have a consumer internet, without any odd DNS or firewall. Adding the following lines to the Dockerfile causes the provider to install locally fine, which means that WGET can download the provider fine.
RUN mkdir -p /home/node/.terraform.d/plugins/registry.terraform.io/cloudflare/cloudflare
RUN wget "https://github.com/cloudflare/terraform-provider-cloudflare/releases/download/v4.19.0/terraform-provider-cloudflare_4.19.0_linux_amd64.zip" -O /home/node/.terraform.d/plugins/registry.terraform.io/cloudflare/cloudflare/terraform-provider-cloudflare_4.19.0_linux_amd64.zip

I've recreated this issue both in Windows, WSL and a devcontainer. Thought I should flag it for someone.
References
No response

this looks to be an issue on the hashicorp registry side and unfortunately, not anything we can do in the provider itself.
request failed: Get "https://objects.githubusercontent.com/github-production-release-asset-2e65be/93446113/84bfe2a0-93f0-479c-b9fe-9751ed7cf660?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20231120%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20231120T225940Z&X-Amz-Expires=300&X-Amz-Signature=5554acdc36b86a838b608c9c844ff1624018f28e807dea9f83e73bdb711d3ee6&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=93446113&response-content-disposition=attachment%3B%20filename%3Dterraform-provider-cloudflare_4.19.0_SHA256SUMS&response-content-type=application%2Foctet-stream": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

i would recommend getting in touch with the hashicorp folks to address this.

Isn't it a bit strange that this seemed to only occur on this provider? AWS installed fine?

the artifact works fine for me.
$ cat terraform.tf
terraform {
  required_providers {
    cloudflare = {
      source = "cloudflare/cloudflare"
    }
  }
}

provider "cloudflare" {}

$ terraform init

Initializing the backend...

Initializing provider plugins...
- Finding latest version of cloudflare/cloudflare...
- Installing cloudflare/cloudflare v4.19.0...
- Installed cloudflare/cloudflare v4.19.0 (self-signed, key ID C76001609EE3B136)

Partner and community providers are signed by their developers.
If you'd like to know more about provider signing, you can read about it here:
https://www.terraform.io/docs/cli/plugins/signing.html

Terraform has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

Hi,
I've encountered similar issues when trying to install version 4.49.0. It worked yesterday with same setup and crashes today.

│ Error: Failed to install provider
│
│ Error while installing cloudflare/cloudflare v4.49.0: checksum list has unexpected SHA-256 hash 10db92d7a62b593c38522250a5f4e56c7d87d17804d3ab8cc253fe2b31454c01
│ (expected 289fb0d94285346a6d41c4e5d93d0b3c40e36d775195596c515dbcc8b87b7a59)
╵

Hi,
I've encountered similar issues when trying to install version 4.49.0. It worked yesterday with same setup and crashes today.

│ Error: Failed to install provider
│
│ Error while installing cloudflare/cloudflare v4.49.0: checksum list has unexpected SHA-256 hash 10db92d7a62b593c38522250a5f4e56c7d87d17804d3ab8cc253fe2b31454c01
│ (expected 289fb0d94285346a6d41c4e5d93d0b3c40e36d775195596c515dbcc8b87b7a59)
╵

Seems like an issue on their side. I'm having this problem too even though it was working yesterday

I "fixed" that by downgrading to 4.48.0. I'm relatively new to terraform, but it doesn't make any sense for terraform to resolve version 4.49.0 released 6 hours ago which crashes on invalid checksum.


cri: fix issues caused by converting the image reference

fix: https://github.com/containerd/containerd/issues/8848
As https://github.com/containerd/containerd/issues/8848#issuecomment-1649211628, the cri plugin's conversion of containerd image references causes a lot of issues.
After thinking about multiple implementations, I want the cri plugin to ignore images whose references are converted, and these images do not set the io.cri-containerd.image=managed label.

/test pull-containerd-node-e2e

hi, the failure in pull-containerd-node-e2e is being fixed in #8862

@fuweid @thaJeztah PTAL, Thanks

I want the cri plugin to ignore images whose references are converted, and these images do not set the io.cri-containerd.image=managed label.

Does this mean , if I tag an image without the domain, i.e
ctr -n k8s.io images tag docker.io/library/busybox:1.36 busybox:fixed

the image busybox:fixed will not have the io.cri-containerd.image=managed label

I want the cri plugin to ignore images whose references are converted, and these images do not set the io.cri-containerd.image=managed label.

Does this mean , if I tag an image without the domain, i.e
ctr -n k8s.io images tag docker.io/library/busybox:1.36 busybox:fixed

the image busybox:fixed will not have the io.cri-containerd.image=managed label

Yes, since the cri plugin can't manage such images, they won't be labeled

Not sure that it breaks air gapped usage. Changes look good. But I think it needs more reviewers on this.


  It would likely be wise to have the top level <Router /> component pass whatever instance of history it's using to its children via getChildContext().

Completed in the latest version.


Input values should not be passed in as an IQueryable.

For example Repository.Issues has IQueryable<IssueState?> states - this should be e.g. IEnumerable<IssueState>.

In addition, if one passes an array serialized as a string into as input value, it does not get serialized correctly into the GraphQL query:
var query = new Query()
                .Repository("github", "VisualStudio")
                .Issues(30, labels: new string[] { "bug" }.AsQueryable())
                .Nodes
                .Select(x => x.Title);

{"query":"{repository(owner:\"github\",name:\"VisualStudio\"){issues(first:30,labels:System.String[]){nodes{title}}}}"}


bug with sass and special char ""

Hi,
I have problem with writing special char \ in sass. I need write to mixin something like this syntax:
$prefix + :\ + $tags

to this
v:\article

But in need this syntax use in $each to: (this is ideal case and this doesn't work)
	@each $vmlTags in
	rect, roundrect, line, polyline, oval, image, curve,
	arc, shapetype, vmlframe, callout, extrusion, fill, formulas,
	handles, imagedata, locks, path, shadow, skew, stroke, textbox, textpath {
		#{$prefix}:\#{$vmlTags} { behavior:url(#default#vml); }
	}

and there is problem:
I will write
#{$prefix}:\#{$vmlTags} error: error sass/screen.scss (Line 16: Invalid CSS after "...ix}:#{$vmlTags": expected ":", was "} { behavior:ur...") overwrite stylesheets/screen.css
I will write
#{$prefix}:\\#{$vmlTags} to compiled document \\ <-- two times!
I will write
#{$prefix}#{":\\"}#{$vmlTags} error: error sass/screen.scss (Line 16: Invalid CSS after "...ix}:#{$vmlTags": expected ":", was "} { behavior:ur...") overwrite stylesheets/screen.css
I will write
#{$prefix}#{":\"}#{$vmlTags} <-- error
#{$prefix}#{":\\"}#{$vmlTags} <-- error
I will use hecadecimal chars and it doesn't compile it to special char ...
THANK YOU!
s.

Closing due to unresponsiveness.


Add ayush-1506

Signed-off-by: ayush-1506<EMAIL_ADDRESS>

looks like i screwed up. can you rebase and redo? sorry.

Squashed and rebased. I believe this can be merged now @lepisma


vcs validate breaks when git remote prints message with empty lines

Hi,
I'm using vcstool to manage repos from a Gitlab server that prints a large warning message (keystrokes logged etc etc) with each git push/pull/fetch, and several empty lines in the message break the vcs validate tool at line 616 of git.py, when hash_and_ref[0] is accessed but is empty.
An easy fix that restored function was to add the lines:
                if len(hash_and_ref) < 2:
                    continue

between lines 616 and 617 of git.py such that any empty or single element lines are ignored.
A follow up question while I'm typing this... was vcs validate ever intended to validate the state of the repo structure, rather than just the format of a repo file? When I first used it I assumed that's what it was doing, until I deleted one of the repos in the structure and vcs validate still reported that all was fine. This is more of a feature request, but wouldn't it make more sense for vcs validate to both check the format of the yaml file, and check that the existing structure matches that file?
Thanks,
Joseph

Thanks for the report. It seems the validate command needs the same fix / logic as was added in #154 for the import command. Please see #159 for a proposed fix.

was vcs validate ever intended to validate the state of the repo structure, rather than just the format of a repo file?

No, the intention was to only check that the input file is formatted correctly. See its help message:
https://github.com/dirk-thomas/vcstool/blob/ce80335a68fecc694f41e17c18294229348b563b/vcstool/commands/validate.py#L20

wouldn't it make more sense for vcs validate to both check the format of the yaml file, and check that the existing structure matches that file?

I would argue no since you want to be able to use validate without even having a working copy. I would suggest to run export and then compare the result with the existing repo file to check for differences.

Aaah okay, I checked to see if there was an existing issue for this on validate but didn't think to check for import or otherwise.
Fair point on validate, that does make more literal sense given the name. Yes, I currently run "vcs export" then visually compare that to my config file, but am considering writing a script to diff the current structure against a repo file, as that seems to be my most common use case recently. Would you have any interest in me submitting a PR if I added a verb for that? Named "vcs check" or similar, perhaps.

Would you have any interest in me submitting a PR if I added a verb for that? Named "vcs check" or similar, perhaps.

That would be great. I would suggest naming it "compare" instead. "check" doesn't have a any context what is being checked imo.


model not found！(fuzzy_cm_5s_ekf.json)

Hello lago，
parser.add_argument(
"--model_dir",
required=True,
type=str,
help="Directory where the model is saved",
)
parser.add_argument(
	"--result_dir",
	required=True,
	type=str,
	help="Directory where the model is saved",
)

How is the model file obtained？
Thanks and regards,
he

Hello!
what  .py file are you trying to run?

Hello!
what .py file are you trying to run?

fuzzy_c_means.py
def process(data:np.ndarray,
			obs_len:int,
			filter_name:str,
			model_dir:str,
			result_dir:str,
			mode:str)->NoReturn:

	model_file=f'fuzzy_cm_{obs_len}s_{filter_name}.json'
	assert os.path.exists(os.path.join(model_dir, model_file)),\
		f'[Fuzzy C-Means][{mode}][ERROR] model not found! ({model_file})'

I'm sorry, I just noticed that there isn't a proper usage description in the README.
In your case, you first need to run the code in train mode (--mode train). It will save the adjusted clustering model to a file, which can then be used for validation and testing.
I will update the README later this week, I believe by Friday. Both for clustering models and Fuzzy.
But, if you have any questions or suggestions, just get in touch.
Sincerely,
Iago

It works. Thank you so much. Looking forward about the new README.
Thanks and regards,
he

I think it's a great piece of work, and I'm eager for it to be updated soon
Thanks and regards,
he

Thank you very much!
We are working on new updates to the approach. I hope we can release soon!
If you have any questions or suggestions, just let me know!
Sincerely,
Iago


What's the purpose of making an App class a subclass of a Component

First of all thank you for the great bootstrap example!
Have few questions:

What's the purpose of making an App class a subclass of a Component i.e. class App extends Component?
And also why do you assign new App(); to a const const app = new App();?

1)React.Component is an abstraction of all app components, Component is a parent of methods and properties like render, componentWillMount etc... Learn OOP.  It is a too long story to tell it in 2 words.
2)Looks like it is app bootstraping process.

@rvpyrv I know OOP, and I know what Component does. I'll rephrase my question:
IMO making App a class is an overkill, why not just make it an object App = { init(){ /* init code */} }; without making it a class, because it does not utilise any of Components methods or render a component.
Then in index.whatever.js  you can bootstrap with App.init(). In my app I bootstrap like this without any issues.

@grundmanise Agreed. I don't see why you would need to make App a component. The old example does not do it - indeed it has a comment that it is not a component.

It's to have access to the React lifecycle methods, in this case constructor. While not needed it was most likely done to make the app more "React like".

Also constructor is React lifecycle method, it is also "generic" lifecycle method of any class in JS (if this class can produce objects of course).
Making App subclass of React.Component simple mistake, because App is not conform to interface of React.Component. Next sentence from https://reactjs.org/docs/react-component.html

React.Component is an abstract base class, so it rarely makes sense to refer to React.Component directly. Instead, you will typically subclass it, and define at least a render() method.

So to be React.Component, class should implement render() method, without which it is not component, because it can't produce react elements by standard way. App is not React.Component also because it can't be passed to any function that expect React.Component.


Add Bake Support

Add the ability to bake transformers. Transforms all fields in the table by default. This will save the user a lot of hassle having to figure out which fields are available.

Thank you for your contributions @amayer5125 !


Inconsistent processing logic for matchMethod and matchHeaders in mux.ServeHTTP.

Describe the bug
When I was looking at the code of mux.ServeHTTP, I found that the logic regarding the processing of matchMethod is not consistent with the logic of matchHeaders, the specific code range is https://github.com/megaease/easegress/blob/36480f34946b464820360ea1a535880fd7e7751f/pkg/object/httpserver/mux.go#L385-L426,
The execution flow here is as follows:

From the figure, we can see that in the case of matchMethod=false, the request will be responded directly, and in the case of matchHeaders=false, the next cycle will be performed, and the processing behavior of these two is inconsistent.
Expected behavior
I think the logic should be the same when matchMethod and matchHeader processing result is false, either it will go to the next round of loop or respond directly to the failed request.
I think it's better to go to the next round of the cycle, so that the following configuration can be achieved
rules:
  - paths:
    - pathPrefix: /pipeline
      method: GET
      backend: get-demo

    - pathPrefix: /pipeline
      method: POST
      backend: post-demo

Version
master
Configuration

Easegress Configuration

HTTP server configuration

Pipeline Configuration

Logs
Easegress logs, if applicable.

OS and Hardware

OS: [e.g. Ubuntu 20.04]
CPU:[e.g. Intel(R) Core(TM) i5-8265U]
Memory: [e.g. 16GB]

Additional context
Add any other context about the problem here.

Thanks for contributing 🎉!

This ain't a bug, because the behavior is expected. But I agree with your judgment about consistency. The failure of supporting different methods for the same pipeline was designed in considering the core role of path in RESTful API style. But as a general gateway, I think your choice is right, we should support the config you wrote.
As for why headers not matched leads to next loop is the requirement driven, EaseMesh use headers to route to different services.
Anyway, we will fix it, thx for the report.


Pushing PnP PowerShell cmdlet changes to live

Updating the PnP PowerShell cmdlet documentation to live.

Docs Build status updates of commit 371d4f7:
:clock10: Full build: the average full build time is 12 min(s) 52 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 371d4f7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPAlert.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPApp.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPApplicationCustomizer.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSidePage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSidePageSection.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSideText.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSideWebPart.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPContentType.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPContentTypeToDocumentSet.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPContentTypeToList.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPCustomAction.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPDataRowsToProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPDocumentSet.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPEventReceiver.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPField.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFieldFromXml.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFieldToContentType.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFile.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFileToProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFolder.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPHtmlPublishingPageLayout.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPHubSiteAssociation.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPIndexedProperty.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPJavaScriptBlock.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPJavaScriptLink.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPListFoldersToProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPListItem.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPMasterPage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPNavigationNode.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPOffice365GroupToSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPOrgAssetsLibrary.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPOrgNewsSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPPublishingImageRendition.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPPublishingPage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPPublishingPageLayout.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPRoleDefinition.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteClassification.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteCollectionAdmin.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteCollectionAppCatalog.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteDesign.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteDesignTask.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteScript.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPStoredCredential.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTaxonomyField.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTeamsTeam.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantCdnOrigin.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantSequence.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantSequenceSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Drop mounting flexvolume plugins into the openstack CCM / fix openstack CCM on Flatcar

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1208
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Drop mounting flexvolume plugins into the openstack CCM / fix openstack CCM on Flatcar

/retest

/retest


Type hints of aliased modules is wrong.

The completion is ok.

Same issue when install from template npx create-rescript-app
module B = Belt.Array

Hover: Unable to resolve module reference Belt_Array
version: latest-master


Missing Support for Integrity Check

Tracking issue for:

[ ] https://github.com/Egekinhwkns/juice-shop/security/code-scanning/40

https://github.com/Egekinhwkns/juice-shop/blob/master/frontend/src/index.html


Sql editor stretch

This adds two significant usability improvements to the JupyterLab OmniSci SQL editor.

It previously didn't work very well with longer SQL queries, as they would run off the edge of the editor, to the point where the user couldn't see them. This makes the editor properly scrollable, and the size of the toolbar can be expanded and collapsed using a split panel. As a result of this change, I have made the "execute" keyboard shortcut Shift+Enter, so that the user can more easily enter line breaks. This is also more consistent with users' notebook muscle memory.
The upstream datagrid package now supports selections and copy/paste (as of this morning!). I have updated to use that, and now the user can copy/paste out of the grid results. Currently, the paste buffer gets TSV, but we could customize the selection model to get CSV or HTML tables (cc. @randyzwitch). So this PR more-or-less fixes #20.

@ian-r-rose I'm fine with TSV, my original request of "HTML" was really meant as "not a picture"


abnormal first sternocostal joint morphology

Add new term:
abnormal first sternocostal joint morphology
DEF: any structural anomaly of the synchondrosis type of cartilaginous joint in which hyaline cartilage unites the first rib to the manubrium of the sternum.; it forms an immobile joint (synarthrosis); the rest of the sternocostal joints are synovial plane joints
SYN: abnormal first sterno-costal joint morphology
SYN: abnormal fist rib-sternum attachment
SOURCE: http://oerpub.github.io/epubjs-demo-book/content/m46381.xhtml,
https://courses.lumenlearning.com/boundless-ap/chapter/cartilaginous-joints/

Added new term:
abnormal first sternocostal joint morphology MP:0030898


linux-51 is dead.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
linux-51 is dead.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Network port connection turned itself off, re-seated network cable to restore connection.


Prevent risk acknowledgment from flashing at input changes

Closes FRO-839

@krzkaczor Other dialogs that display liquidation risk acknowledgment don't have debouncing, so the problem is not present.


RFE: dim draft PRs in the PR list

Description
I usually go to the PR list to see what needs to be reviewed (or what's already reviewed and needs to be merged). In that context, Draft PRs are a bit of a 'noise'.
It would be nice if they could appear as dimmed, to remove some visual clutter, similarly to what dim-bot does.
I realize this could probably be a UserScript instead (didn't find one that does this already) - but I think most people would like this feature?
Example URLs
https://github.com/refined-github/refined-github/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc  (or any PR list of any repo that has draft PRs).

We tried this and it was too much because draft PRs are not "noise" like bot PRs are. We ended up going for a dimmer icon instead: emphasize-draft-pr-label


Consul related changes: hosts dns settings are used as consul's recursor  Consul updated to 0.5.2 (recursor cli needs it) turned back to official gliderlabs/consul-server (sequenceiq/consul started as 0.5.0 wasnt released)

@akanto please review

@akanto ping


Coding Standards Compliance (Inconsistent variable naming)

The naming is inconsistent. You’re mixing snake_case with camelCase, which breaks uniformity.
Variables like log_entry_url, leaf_hash, etc., follow standard conventions, but terms like entryUUID don’t follow consistent naming styles.
Potential fix: Stick to one naming convention, preferably snake_case in Python.
https://github.com/XichengTong/SoftwareSupplyChainSecurity_HW1/blob/e32bee2352c30a83d3f281323abb1bd64c0ea378/main.py#L114

Changing all variables to snake_case


Increased scroll performance

In my implementation, this doubled the FPS I got when scrolling (it all depends on how large your layoutSubviews is I guess).

That's excellent, thank you! Sort of embarrassing we hadn't done that already.
Thanks again for helping out!

No problem :)
Again, the KKGridView have a lot of great work behind it, has a good license and is well designed. It just feels good making it better ^^
Ah, pull request #100 btw :D


Separate 2.2.x examples from 2.3 examples

Version 2.3 introduces examples that are not compatible with Elyra 2.2.x. We do want to preserve the legacy examples for users who are running one of the 2.2.x legacy versions.

[x] Create new v2.2.x branch
[ ] Update README with information how v2.2.x examples can be accessed

Created https://github.com/elyra-ai/examples/tree/v2.2.x


Edits for clarity and linked to default parameters

Removed future tense.

@codyjtclark
The links to other docs pages in here could also benefit from using {{root_url}} tags.


Trouble compiling 0.91.

When trying to compile 0.91, I get this:
The Meson build system
Version: 0.44.0
Source dir: /home/arichter/dxvk/dxvk-0.91
Build dir: /home/arichter/dxvk/duff/dxvk-master/build.64
Build type: cross build
Project name: dxvk
Native C compiler: ccache cc (gcc 5.5.0)
Cross C compiler: x86_64-w64-mingw32-gcc (gcc 6.1.0)
Native C++ compiler: ccache c++ (gcc 5.5.0)
Cross C++ compiler: x86_64-w64-mingw32-g++ (gcc 6.1.0)
Host machine cpu family: x86_64
Host machine cpu: x86_64
Target machine cpu family: x86_64
Target machine cpu: x86_64
Build machine cpu family: x86_64
Build machine cpu: x86_64
Checking if "winelib check" compiles: NO
Library vulkan-1 found: YES
Library d3d11 found: YES
Library dxgi found: YES
Library d3dcompiler_43 found: YES
Library d3dcompiler_47 found: YES
Program glslangValidator found: YES (/bin/glslangValidator)
Dependency threads found: YES
How do get the "winelib check" working?
0.90 builds fine.

I got the same output on that line but it still built and ran fine. Are you sure it didn't build and there aren't any other issues? Only thing I can say is to update gcc and mingw.

I'm afraid not, the build stopped rather promptly:
Meson encountered an error in file src/dxvk/meson.build, line 103, column 0:
Argument is of an unacceptable type 'Dependency'.
Must be either an external dependency (returned by find_library() or dependency()) or an internal dependency (returned by declare_dependency()).

After digging a bit, the testprog.cpp needs this:
#define WINE
which is something very new to me.

See 5a1b37b77078d902168e8b8ac2c0c3c23398edfe. Either use that, or use a newer Meson version.


rebasing armdev against main

This branch is 116 commits ahead of, 327 commits behind main. with 72 files changed, 3,705 additions and 1,190 deletions

I think now we have a semi-functional aarch64 port (thanks folks).  Before it's too late, let's set up a plan to merge the armdev into main. Be ready for conflicts. Please see this to get an idea.
Let's first

[ ] complete the open PRs on armdev.
[ ] test and make sure aarch64 is working to some degrees

As for merging, there are maybe 2 or 3 options:

directly merge armdev into main, resolve conflicts (yikes) and do testing at the end.
rebase armdev first (there are some dirty commits, do you want to redeem yourself?), then do the same.

My head hurts so hard just by looking at the diffs.... ehhhhh . Please help!
@CharlyYu @abel-von @chl337 @QuarkContainer @SchwarzStein  Hark! I beseech thee, summon forth all ye folk of myriad realms! A quest of wisdom doth beckon. Gather 'round, o beings of light and shadow, for the hour is nigh to seek the paths untrodden and the secrets veiled in the mists of time.

rebase armdev_rebase  against the diverging point

Noob question: to what do you refer by 'diverging point'?

382472b4 seems to be the diverging point, against which we should rebase our armdev branch first.

checklists tracked in #1231.


Update process from v0.5.x to v0.11.x

npm CLI >= v3.0.0 tries to dedupe the dependencies by default, and keeping dependencies up-to-date helps better deduplication.

@Raynos @Matt-Esch What do you think?

@Raynos @shinnn @Matt-Esch please update this branch and merge in if applicable.

@Raynos The old process version is missing a full license text and thus depending on it is problematic with most company lawyers. The newer version does not suffer the problem anymore, so it would be awesome if you updated the version and released a new version of global, which could propagate the change up to all dependents.
Things like Storybook are depending on this library, so it would be nice to sort it out.

Friendly ping @Raynos.

Published 4.4.0

@Raynos Thanks. I appreciate you maintain this project over 6 years.

Correction, I maintained this project in 2014 and 2019 ...
In 2017 & 2018 I was bad at open source :disappointed:


Bug in breach arbiter

It seems like when the balance of one party in breached commitment is 0, breach arbiter is unable to create justice tx, because it assumes that there are always two outputs to parties.
Example test
https://github.com/BitfuryLightning/lnd/commit/b7f8e5bf9058c5f780894e44092fa455b76ae565
Should I:

Create are distinct test for it?
Fix it?

@BitfuryLightning thanks for documenting this! I am currently working on improvements to the breach arbiter in these PR's #241 and #264. I have talked with @Roasbeef about a potential solution and will see that it is resolved in the latter update.


Sonarcloud test code coverage missing

This likely has to do with needing more tests and consuming a .sarif or other run-file.

Yes, we never got around to connecting the test coverage (which we knew was low anyways). I believe with the splitting out of the API, Ian got test coverage to run (via a special package.json script), we need to use that in the github action when we run the tests (or update the package.json script that CI uses to run tests), and then ensure the coverage file gets published to SonarCloud.

SonarCloud is set up the same as the Greenfield and should be ready to consume lcov.info and/or cobertura-coverage.xml file when tests are included.

I'd say this issue is still outstanding then until we connect up the test coverage, not sure why it was closed as completed.


Include endpoint in permalinks

This issue affects portainer installations with multiple endpoints configured.
All URLs have the form http://portainer/#/containers/d08e0fd172d83a4cc1ce31fcfb88221393c39c654b563c301257424c62a63711, which does not include the endpoint in question. If I want to send a link to the details of a container or any other page, the link doesn't work because portainer doesn't know in which endpoint to look.
Could you include the endpoint in the URLs schema? Thanks a lot!

Duplicate of #454


Move as much functionality into classes as possible

For the prototype we kind of just wrote global functions and put them wherever we thought was convenient.  🏪  That made sense, but if this app is going to grow much larger, I think we should make sure we're doing our best to stick to object-oriented principles and whatnot.  🎒  I'd say it's fine to have a global function or two in the app's initialization code.  🌱  Or if there are other conventions in web development where we do things outside of objects, it's fine to conform to them.  ✌  But aside from that, I'd definitely vote to move as much code as possible into classes with clearly-defined responsibilities.  🚀

I'm with you on this, @aab29
I've tried to move a lot of routing and controller logic out of the main server file into their own classes. I've tried to use that file, /index.js, only for configuring the express server.
I also agree that 1.2 seems the most practical. I've been creating classes as object literals, approach 2, but if I'm reading the article you linked correctly, this practice "makes no sense" 😂


Future-proof against potential Prelude.foldl'

See https://github.com/haskell/core-libraries-committee/issues/167
This is, of course, a bit speculative at the moment, but given that the change does not involve CPP, it should not hurt to merge it early to simplify further impact assessment.

I remember. I just got a bit stuck on making sure that CI actually test everything it should test

@Bodigrim finally done


Improve VSCode syntax highlighting

Fixes #145

Allows rules without a terminating semicolon
Improves the syntax highlighting inside of a function or nested group (parentheses, lists, arrays, etc.)
Adds support for ReScript

OCaml
Reason
ReScript

There are still some edge cases like the strings inside the Reason switch body, but most other things seem to work.

Publishing is failing since it's a fork, will merge it and release a new version of the vscode extension.


iOS feature not working: No "Open app" nag in tweet header

Hi there.
I just bought the app on iOS app store. The extension works great except one feature: hide "open app" header. Could you have a look at this issue? Thanks!
I am on iOS 16.6.1 safari.

Do you have a screenshot of what you're seeing?
If it sits above Twitter and looks like the one in this issue, the only way to remove it is to uninstall the official Twitter app. That's a Safari feature we have no control over.
If the buttons inside Twitter itself have returned (they used to be on the top-right when viewing a Tweet, but I think they've removed them now) then we can do something about it.

Yes I installed the X app. Uninstall the app fixed this issue, though not perfect fix.
anyway, thank you.

Added an FAQ for this to the website:
https://jbscript.dev/control-panel-for-twitter#safari-faq-ios-app-banner


[HUDI-6443] Support delete_partition, insert_overwrite/table with record-level index

Change Logs
Support delete_partition, insert_overwrite and insert_overwrite_table with record-level index. The metadata records should be updated accordingly.

all records in the deleted partition(s) should be deleted from RLI (for delete_partition operation)
newly inserted records should be present in RLI
old records in the affected partitions should be removed from RLI
old records that happen to have the same record key as the new inserts won't be removed from RLI; their entries will be updated

Impact
RLI data integrity
Risk level
Medium

[ ] UT, FT and e2e testing.

Documentation Update
NA
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

last commit was separated to https://github.com/apache/hudi/pull/9155, which should be landed first


Facet search is not working when the string has ( and ) present. For example Albany (N.Y.) in Place facet.

Replaced '(' and ')' with UTF-8 encoded values. Also, space in the search term is replaced with + to as it was in the old version of application.

Thanks


Cherry-pick main and set version to 1.1.4

Cherry picks all changes to Steel since the last release of Steel. Updates all versions to 1.1.4, including Steel.
This PR marks the 1.0 release of Steel

The CI / examples job failed on the last test, which was deprecated but covered in other jobs.
https://github.com/risc0/risc0-ethereum/actions/runs/11218972638/job/31183902249?pr=284


[Feature Request] Add Ubuntu 20.04 support

Right now there are only old versions of ubuntu present in the metadata.json.
Does this module work with Ubuntu 20.04? If so, could you add that to the metadata, please?

We're about to archive this repo unfortunately.
Here at GOV.UK we've only ever used this with Ubuntu 14.04(!) so YMMV. Appreciate you taking the time to raise the issue and sorry I can't help on this occasion.


Reimplement (text/terminal) cursor control through an interface

Previously, abstracting and negotiating cursor position between multiple cursor placers. This will make that possible.
Its important for when multiple string fields are on the screen in an editor, for instance.

With the plan of tackling #53 soon, I am semi-happy to merge this, as WIPpy as it is.


net/url: Trailing question marks in query string appears to be misparsed

Commit  9f26170 from issue #13488 appears to improperly parse URLs if the query string ends in ?, such as http://host/?q=?.  I noticed through code inspection, so I don't have a way to verify and so this issue might be invalid.  The current playground seems to behave correctly: http://play.golang.org/p/khxLopsBd0

I noticed this in some test logs as well. A test made a request with a URL ending in "?" to assert the service dealt with some unexpected query value. Following 9f26170a0, http.NewRequest fails to create the http.Request due to the url.Parse change.
_, err := http.NewRequest("GET", "http://a.io?mac=?", nil)
fmt.Println(err)

Output
&url.Error{Op:"parse", URL:"http://a.io?mac=?", Err:"?"}

I expected url.Parse to parse the URL ending in "?".


Small refactor for getting size

Currently, map is being called to extract sizes then reduce is called on that; so 2 iterations through the array. It is possible to solve this with only reduce: 1 iteration. reallyUsedModules probably won't ever be big enough for this to matter, so it comes down to readability.
I think doing a once-and-done reduce could be an improvement here. What do you guys think?

Sounds good

Thanks


Questions about the PSNR result of the project

I want to know how can I get the result like the picture in the project. I notice that some of them can exceed 40dB, but i can just only get a 30dB result. Of course it will increase the bpp, but that's fine.
Just increase/decrease the value of LAMBDA is OK? It seems that the bpp is out of control. Can I arbitrarily choose the bpp?

Depends on the image contents and image resolution.
The RD curves uses the average over 24 images of size 768x512 from the Kodak dataset.

Depends on the image contents and image resolution.
A single point on the RD curve represents a single model at a particular quality. The point is generated by taking the average over 24 images of size 768x512 from the Kodak dataset.

Thanks for your answer.
I have another question. For a certain point on the RD curve, my bpp value is much larger at the same PSNR value. I hardly changed the parameters of the model, just changed lambda, and I used the CLIC training set.
Maybe I didn't have enough epochs? I selected 13,000 images from CLIC and trained for 500 epochs.


evcc detect on defined subnet

when using a large unseparated network the auto-detection will take quite long (e.g. <IP_ADDRESS>/8).
I would like to scan only a subnet (relevant devices are located in subnet <IP_ADDRESS>/23)
use of another optional parameter (e.g. "-n <IP_ADDRESS>/23" or "-n <IP_ADDRESS> -n <IP_ADDRESS>") would be great.

Just do it ;)
https://github.com/andig/evcc/blob/master/cmd/detect.go#L19

wow, didn't get that! thanks, everything fine. thanks a lot!!!
regards!


prototype lies + chromium

open chromium, no extensions

load TZP
chrome: zero prototype lies
click the global rerun - now we have two lies: Date.toString, Function.toString
click the global rerun again - now we have 182 lies

this is not normal. does not happen in Firefox
@abrahamjuliot

That is my error. We just need to delete the test's fake property "" in getDefinePropertiesLie. If it remains, then it pollutes the native function on the next run.

seems legit now, thanks :)


IP missing in article for - Office 365 URLs and IP address ranges

Hi Team,
I have a customer who is service provider and provide teams service to there customer.  They have whitelisted all o365 IP's for Teams mentioned in given article but when their user is making teams to team call the user are being charged as one of the IP address is not listed in article , They he tracked to know what IP was sent to their DPI system and it was <IP_ADDRESS>. Could you pls update the article with all other new IP's added recently.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077406d8-bff1-496e-3ea2-b38558fd9355
Version Independent ID: 57db3dec-2250-2dee-fd1a-ec6656911798
Content: Office 365 URLs and IP address ranges
Content Source: Enterprise/urls-and-ip-address-ranges.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@rktiwari14 Not all IP addresses are listed for Default category endpoints. Please see https://techcommunity.microsoft.com/t5/Office-365-Networking/Why-are-some-Office-365-network-endpoints-provided-as-URLs-only/m-p/310490#M97 for more information. Thanks for your question.


GPSLatitude, GPSLongitude, GPSTimeStamp truncated.

Hi, it seems to be there a problem with data from tags GPSLatitude, GPSLongitude and GPSTimeStamp.
Image attached show the exif object submitted to insert method of library and how is it read by load method.

By specifics GPSLatitude (2), GPSLongitude (4) and GPSTimeStamp (7) fields expect 3 values.
When i try to read them field are truncated: only 2 values of 3 are present.
Thanks!

http://piexifjs.readthedocs.io/en/latest/appendices.html#exif-data-in-piexifjs

https://github.com/hMatoba/piexifjs/issues/1

Thanks @hMatoba, through the posted examples now GPSLatitude and GPSLongitude works as expected.
However, i still have problems with GPSTimeStamp.
I tried to insert timestamp as rational value like [1529070323601, 1] (i have tried also with 60 and 3600 for denominator) but piexif return Possible Unhandled Promise Rejection (id: 0): "\'pack\' error.
I think this is due to size of timestamp value is too big for a LONG of 32 bit.
I did not find anything about it on documentation.
How can i find a solution? It is possible have some examples, please.
Thanks for all.

http://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf
See "GPSTimeStamp" section.

[[12, 1], [59, 1], [10101, 1000]]
12:59:10.101

Thanks @hMatoba, everything works now!


Compute entry hash when necessary

This apply the changes from https://github.com/tezedge/tezedge/pull/527 into https://github.com/tezedge/tezedge/pull/529.
There is no difference except that it uses Rc instead of Arc.
Note that the signature of ProtocolContextApi::get and ProtocolContextApi::dirmem can be changed to:
fn get(&self, key: &ContextKey) -> ContextValue;
fn dirmem(&self, key: &ContextKey) -> bool;

But I am not sure how to return those types to ocaml here:
https://github.com/tezedge/tezedge/blob/protocol-runner-storage/tezos/new_context/src/ffi.rs#L178

@sebastiencs for this API we want to get rid of Result whenever possible, because the OCaml-side API assumes no errors happen. Please add comments about Result not being required in any place in the API where you find it to be the case and we will take care of those later.

@sebastiencs just made a few changes to the base branch that caused conflicts here (because I changed get to return None when the entry is not found to match the OCaml-side API).

One more thing, I updated some method names to match the new OCaml API:

set -> add
get -> find
dirmem -> mem_tree

Not sure why, but when running with the address sanitizer enabled, this assert failed: https://github.com/tezedge/tezedge/blob/b6dcc1d8ab061ab2542eb756a7dce26f7476a9f4/tezos/new_context/src/gc/mark_move_gced.rs#L568-L574

Comments addressed.
The failed assertion seems to be resolved without any changes related to it 🤔


abseil-cpp\CMake\AbseilDll.cmake

Describe the bug
When I use Abseil as a third-party library with source code integration, I want to compile a dynamic library under Windows. At this time, the problem arises. The target in abseil will also be compiled as dll_dep, and I have set BUILD_SHARED_LIBS=ON. Through debugging, I found that it turned out to be the reason for the setting of _NAME. When abseil is used as a third-party library, NAME will be set to "absl${ABSL_CC_LIB_NAME}", which is judged to be not part of the dll in the subsequent absl_internal_dll_contains function. These targets are thus identified as dll_dep, and then compiled with the ABSL_CONSUME_DLL macro definition attached, resulting in compilation errors.

log
The following is the log when compiled as a third-party library
==========================================
targetName: absl_atomic_hook
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_errno_saver
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_log_severity
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_raw_logging_internal
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_spinlock_wait
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_config
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_dynamic_annotations
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_core_headers
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_malloc_internal
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_base_internal
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_base
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_throw_delegate
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_pretty_function
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_endian
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_bits
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_exponential_biased
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_periodic_sampler
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_scoped_set_env
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_strerror
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_fast_type_id
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_algorithm
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_algorithm_container
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_container
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_btree
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_compressed_tuple
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_fixed_array
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_inlined_vector_internal
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_inlined_vector
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_counting_allocator
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_flat_hash_map
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_flat_hash_set
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_node_hash_map
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_node_hash_set
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_container_memory
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_hash_function_defaults
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_hash_policy_traits
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_hashtablez_sampler
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_hashtable_debug
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_hashtable_debug_hooks
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_have_sse
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_node_hash_policy
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_raw_hash_map
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_container_common
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_raw_hash_set
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_layout
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_stacktrace
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_symbolize
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_examine_stack
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: absl_failure_signal_handler
_ind_ll is 0
_build_type is dll_dep
==========================================

The following is the log when abseil is compiled as the main project
==========================================
targetName: atomic_hook
_ind_ll is 1
_build_type is dll
==========================================
targetName: errno_saver
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: log_severity
_ind_ll is 1
_build_type is dll
==========================================
targetName: raw_logging_internal
_ind_ll is 1
_build_type is dll
==========================================
targetName: spinlock_wait
_ind_ll is 1
_build_type is dll
==========================================
targetName: config
_ind_ll is 1
_build_type is dll
==========================================
targetName: dynamic_annotations
_ind_ll is 1
_build_type is dll
==========================================
targetName: core_headers
_ind_ll is 1
_build_type is dll
==========================================
targetName: malloc_internal
_ind_ll is 1
_build_type is dll
==========================================
targetName: base_internal
_ind_ll is 1
_build_type is dll
==========================================
targetName: base
_ind_ll is 1
_build_type is dll
==========================================
targetName: throw_delegate
_ind_ll is 1
_build_type is dll
==========================================
targetName: pretty_function
_ind_ll is 1
_build_type is dll
==========================================
targetName: endian
_ind_ll is 1
_build_type is dll
==========================================
targetName: bits
_ind_ll is 1
_build_type is dll
==========================================
targetName: exponential_biased
_ind_ll is 1
_build_type is dll
==========================================
targetName: periodic_sampler
_ind_ll is 1
_build_type is dll
==========================================
targetName: scoped_set_env
_ind_ll is 1
_build_type is dll
==========================================
targetName: strerror
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: fast_type_id
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: algorithm
_ind_ll is 1
_build_type is dll
==========================================
targetName: algorithm_container
_ind_ll is 1
_build_type is dll
==========================================
targetName: container
_ind_ll is 1
_build_type is dll
==========================================
targetName: btree
_ind_ll is 1
_build_type is dll
==========================================
targetName: compressed_tuple
_ind_ll is 1
_build_type is dll
==========================================
targetName: fixed_array
_ind_ll is 1
_build_type is dll
==========================================
targetName: inlined_vector_internal
_ind_ll is 1
_build_type is dll
==========================================
targetName: inlined_vector
_ind_ll is 1
_build_type is dll
==========================================
targetName: counting_allocator
_ind_ll is 1
_build_type is dll
==========================================
targetName: flat_hash_map
_ind_ll is 1
_build_type is dll
==========================================
targetName: flat_hash_set
_ind_ll is 1
_build_type is dll
==========================================
targetName: node_hash_map
_ind_ll is 1
_build_type is dll
==========================================
targetName: node_hash_set
_ind_ll is 1
_build_type is dll
==========================================
targetName: container_memory
_ind_ll is 1
_build_type is dll
==========================================
targetName: hash_function_defaults
_ind_ll is 1
_build_type is dll
==========================================
targetName: hash_policy_traits
_ind_ll is 1
_build_type is dll
==========================================
targetName: hashtablez_sampler
_ind_ll is 1
_build_type is dll
==========================================
targetName: hashtable_debug
_ind_ll is 1
_build_type is dll
==========================================
targetName: hashtable_debug_hooks
_ind_ll is 1
_build_type is dll
==========================================
targetName: have_sse
_ind_ll is 1
_build_type is dll
==========================================
targetName: node_hash_policy
_ind_ll is 1
_build_type is dll
==========================================
targetName: raw_hash_map
_ind_ll is 1
_build_type is dll
==========================================
targetName: container_common
_ind_ll is 1
_build_type is dll
==========================================
targetName: raw_hash_set
_ind_ll is 1
_build_type is dll
==========================================
targetName: layout
_ind_ll is 1
_build_type is dll
==========================================
targetName: stacktrace
_ind_ll is 1
_build_type is dll
==========================================
targetName: symbolize
_ind_ll is 1
_build_type is dll
==========================================
targetName: examine_stack
_ind_ll is 1
_build_type is dll
==========================================
targetName: failure_signal_handler
_ind_ll is 1
_build_type is dll
==========================================
targetName: debugging_internal
_ind_ll is 1
_build_type is dll
==========================================
targetName: demangle_internal
_ind_ll is 1
_build_type is dll
==========================================
targetName: leak_check
_ind_ll is 1
_build_type is dll
==========================================
targetName: leak_check_disable
_ind_ll is 1
_build_type is dll
==========================================
targetName: debugging
_ind_ll is 1
_build_type is dll
==========================================
targetName: flags_path_util
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_program_name
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_config
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_marshalling
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_commandlineflag_internal
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_commandlineflag
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_private_handle_accessor
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_reflection
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_internal
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_usage_internal
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_usage
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: flags_parse
_ind_ll is 0
_build_type is dll_dep
==========================================
targetName: bind_front
_ind_ll is 1
_build_type is dll
==========================================
targetName: function_ref
_ind_ll is 1
_build_type is dll
==========================================
targetName: hash
_ind_ll is 1
_build_type is dll
==========================================
targetName: city
_ind_ll is 1
_build_type is dll
==========================================
targetName: memory
_ind_ll is 1
_build_type is dll
==========================================
targetName: type_traits
_ind_ll is 1
_build_type is dll
==========================================
targetName: meta
_ind_ll is 1
_build_type is dll

#797


prettify-bundle.js coming back malformed

Updating with npm i, the file from https://developers.google.com/_static/js/prettify-bundle.js is coming back binary.

I noticed this a couple days back. I'm having the same issue as well.

Something must have happened on the devsite end. Can't repro this anymore.

I think this might have something to do with being on Google's corp network. When I npm start at home, the bundle is foo bar'd. When I did it earlier today in the office, everything was gravy.
I'll try to check again tomorrow.

I'm getting this, too. On a public network. Tried turning off proxy, didn't appear to do anything.

Confirmed. It only works when on the corp network.


Update SplitButton border to render like Button border

Description

The root cause of the border of SplitButton not looking like the Button border is the fact that the border was rendered on top of the semi-light gray background of the control instead of being rendered against the background of the control surrounding the SplitButton. This caused the border to look differently in dark theme compared to the Button border.
Motivation and Context

Closes #6638
How Has This Been Tested?

Tested manually.
Screenshots (if appropriate):

Before:

After:

The 'CheckedTouchPressed' state in the after screenshot has square corners

There is a little issue with how the corners look. How about applying the border to both PrimaryBackgroundGrid and SecondaryBackgroundGrid? I think that will need converters, so that it keeps working with the border thickness api.

I wanted to avoid using converters but it seems that the border radius clipping does not work as expected. I'll dig into this.

I think the border should be fixed now without control parts sticking out.

Doesn't this make the border always have the same color? I think it's still supposed to be different for each button depending on the state.

I was able to separate them now with the use of converters, there is still a bug with clicking it and the border not updating correctly, however I am not sure if it is a bug with the template or UWP XAML since the visual states on its own all seem fine(ish).

Some states don't seem to update the border, and then a lot of brushes are identical.
There is one small issue with the divider. I think it should be contained within the border visually, rather than overlapping it:

Also, why does BackgroundSizing change for some states?

Some states don't seem to update the border, and then a lot of brushes are identical.
Is this present with the latest changes and if so, can you elaborate on that?

There is one small issue with the divider. I think it should be contained within the border visually, rather than overlapping it:
Fixed now.

Also, why does BackgroundSizing change for some states?
This is how the AccentButton style and ToggleButton are implementing the border rendering with accent colored background. Current state does not use it anymore though.

Did the implementation with BackgroundSizing not work well? I think it was ok, and it was also simpler.
Regarding the borders: PointerOver should stay the same, Pressed should update one of them, and then Disabled and FlyoutOpen should update both borders.
When checked, all borders should be updated in all states, otherwise it will use some unchecked brushes.
Then there is a problem in the theme resources: SplitButtonBorderBrushPressed is the same as the normal and pointer over brushes, but it should have the value of ControlStrokeColorDefaultBrush.

It's a bit strange. With the previous implementation, when going from unchecked to checked, BackgroundSizing will not update unless you press the button. Simply hovering won't change it.
Everything else about the states does change.
It could be a bug with BackgroundSizing, but maybe something happens with the Pressed state which doesn't happen with others.

I'm inclined to say that this is a bug with the BackgroundSizing property. There were different things I tried with it (e.g. use it on a Border or a Grid) but all of them did not really work as expected.

I found the issue - #6885. I'm not sure if it can be fixed without WinUI 3, so this might be the best way to do it.
Interestingly enough, ToggleButton does not have this issue.

There could be a workaround but I don't think that there is a fix before WinUI 3. Maybe though, we are using Backgroundsizing completely wrong here.

Do you think the thickness filter could be added in a separate pr until this one is approved?
There are a lot of controls that would benefit from it, and it's kinda needed to fix some CommandBarFlyout issues.

Do you think the thickness filter could be added in a separate pr until this one is approved?
There are a lot of controls that would benefit from it, and it's kinda needed to fix some CommandBarFlyout issues.

We could try that but I am not sure if it would speed up the process much. In theory, first the filter would need to have the feature proposal process kicked off since it is a public API (@MikeHillberg FYI).

Thank you for submitting this PR, the current focus of the team is to assist our users in moving from WinUI 2 to WinUI 3. We are closing this PR as it does not address resolving a critical issue for WinUI 2 or WinUI 3.