Support for 'trusty' build environment

Coverage remained the same at 86.623% when pulling 13178bd7a9a4875e16151be23dddf5565f6a665f on bugfix/support-for-trusty-environment into ba2134e10990e68ba4728e48bf356959aafe6a12 on master.


Implemented all required proposal subcommands

The code is currently not DRY and I have not integrated tests yet. Hopefully we can take some time afterwards to reduce the duplication and to make it really rocksolid with tests.

the default table output for ./bin/crowbar proposal show provisioner default is still screwed. I think it is because of the ssh key which spans very long. values over 80 characters should be split to new rows somehow.

question is do we even need or want a table representation of the proposals

@MaximilianMeister there is the --format jsonas well.

Ready for review and merge...

LGTM

:+1: LGTM too


Respond to casual issue mentions

Added a configuration option to make the bot listen to any mentions of the JIRA issues and respond with summary.

Coverage decreased (-2.54%) to 97.46% when pulling af40df5cf5cef2efddd2be1a0856f442f7b6173c on romanbsd:master into ddbd0d71852c1f85b6eac71cebfb3aa64fed5b3d on esigler:master.

@romanbsd Thanks for this PR!  Instead of defining an issue pattern twice, would you be OK with a config item "scan_all_messages" that would apply the existing issue pattern regex?  (If the current issue pattern regex isn't catching your JIRA issue, we can adjust it too.)

Addressed in #8 , closing this one out.


[FEATURE] export-from-volume backing image support stored as sparse file

Is your feature request related to a problem? Please describe
When creating backing image from an exist volume which size is 150GB and actual size is 4.27GB, the backing image will be 150GB, ignore the export type is raw or qcow2.
Is it possible to store the backing image as a sparse file that will only use space equal to the actual size of the volume?

volume details, the  actualSize:<PHONE_NUMBER>, aka 4.27GB

root@k8s3-master:/mnt# k get -n longhorn-system volumes.longhorn.io/pvc-11a6ff0b-3b19-4f20-8fdd-a3ff3d3a0f95 -o yaml
apiVersion: longhorn.io/v1beta2
kind: Volume
metadata:
  creationTimestamp: "2024-11-08T08:19:49Z"
  finalizers:
  - longhorn.io
  generation: 17
  labels:
    longhornvolume: pvc-11a6ff0b-3b19-4f20-8fdd-a3ff3d3a0f95
    recurring-job-group.longhorn.io/default: enabled
    setting.longhorn.io/remove-snapshots-during-filesystem-trim: ignored
    setting.longhorn.io/replica-auto-balance: ignored
    setting.longhorn.io/snapshot-data-integrity: ignored
  name: pvc-11a6ff0b-3b19-4f20-8fdd-a3ff3d3a0f95
  namespace: longhorn-system
  resourceVersion: "92566742"
  uid: 89d0ff81-977f-40ea-8978-d10e109994e3
spec:
  Standby: false
  accessMode: rwx
  backendStoreDriver: ""
  backingImage: ubuntu-2404
  backupCompressionMethod: lz4
  dataEngine: v1
  dataLocality: disabled
  dataSource: ""
  disableFrontend: false
  diskSelector: []
  encrypted: false
  engineImage: ""
  freezeFilesystemForSnapshot: ignored
  fromBackup: ""
  frontend: blockdev
  image: longhornio/longhorn-engine:v1.7.0
  lastAttachedBy: ""
  migratable: true
  migrationNodeID: ""
  nodeID: k8s3-node33.renderg.com
  nodeSelector: []
  numberOfReplicas: 1
  replicaAutoBalance: ignored
  replicaDiskSoftAntiAffinity: ignored
  replicaSoftAntiAffinity: ignored
  replicaZoneSoftAntiAffinity: ignored
  restoreVolumeRecurringJob: ignored
  revisionCounterDisabled: true
  size: "161061273600"
  snapshotDataIntegrity: ignored
  snapshotMaxCount: 250
  snapshotMaxSize: "0"
  staleReplicaTimeout: 30
  unmapMarkSnapChainRemoved: ignored
status:
  actualSize:<PHONE_NUMBER>
  cloneStatus:
    attemptCount: 0
    nextAllowedAttemptAt: ""
    snapshot: ""
    sourceVolume: ""
    state: ""
  conditions:
  - lastProbeTime: ""
    lastTransitionTime: "2024-11-08T08:19:49Z"
    message: ""
    reason: ""
    status: "False"
    type: WaitForBackingImage
  - lastProbeTime: ""
    lastTransitionTime: "2024-11-08T08:19:49Z"
    message: ""
    reason: ""
    status: "False"
    type: TooManySnapshots
  - lastProbeTime: ""
    lastTransitionTime: "2024-11-08T08:19:49Z"
    message: ""
    reason: ""
    status: "True"
    type: Scheduled
  - lastProbeTime: ""
    lastTransitionTime: "2024-11-08T08:19:50Z"
    message: ""
    reason: ""
    status: "False"
    type: Restore
  currentImage: longhornio/longhorn-engine:v1.7.0
  currentMigrationNodeID: ""
  currentNodeID: k8s3-node33.renderg.com
  expansionRequired: false
  frontendDisabled: false
  isStandby: false
  kubernetesStatus:
    lastPVCRefAt: ""
    lastPodRefAt: "2024-11-12T00:35:40Z"
    namespace: orbit-system
    pvName: pvc-11a6ff0b-3b19-4f20-8fdd-a3ff3d3a0f95
    pvStatus: Bound
    pvcName: ovm-p3azlfa33p9es-disk
    workloadsStatus:
    - podName: virt-launcher-ovm-p3azlfa33p9es-xtf54
      podStatus: Failed
      workloadName: ovm-p3azlfa33p9es
      workloadType: VirtualMachineInstance
  lastBackup: ""
  lastBackupAt: ""
  lastDegradedAt: ""
  ownerID: k8s3-node33.renderg.com
  pendingNodeID: ""
  remountRequestedAt: ""
  restoreInitiated: false
  restoreRequired: false
  robustness: healthy
  shareEndpoint: ""
  shareState: ""
  state: attached

test backing image details, volume-name: pvc-11a6ff0b-3b19-4f20-8fdd-a3ff3d3a0f95

root@k8s3-master:/mnt# k -n longhorn-system get backingimage/test-1112 -o yaml
apiVersion: longhorn.io/v1beta2
kind: BackingImage
metadata:
  creationTimestamp: "2024-11-12T06:50:23Z"
  finalizers:
  - longhorn.io
  generation: 2
  labels:
    longhorn.io/component: backing-image
    longhorn.io/managed-by: longhorn-manager
  name: test-1112
  namespace: longhorn-system
  resourceVersion: "92563648"
  uid: 9ff188e4-2e25-44c2-a49c-0a58e62828a8
spec:
  checksum: ""
  diskFileSpecMap:
    12baaeb8-7841-43b1-919d-4453cee02f7c:
      evictionRequested: false
  diskSelector: []
  disks: {}
  minNumberOfCopies: 1
  nodeSelector: []
  secret: ""
  secretNamespace: ""
  sourceParameters:
    export-type: raw
    volume-name: pvc-11a6ff0b-3b19-4f20-8fdd-a3ff3d3a0f95
  sourceType: export-from-volume
status:
  checksum: edf920af54234e84011bfaef544cea6ae22c79961213ff2695968a098bea6ea10f120b9c4e3d0fe63b3db2ae17a93709d8fd58bb481dd0e20d4e0d7b3c6d034c
  diskFileStatusMap:
    12baaeb8-7841-43b1-919d-4453cee02f7c:
      lastStateTransitionTime: "2024-11-12T07:06:59Z"
      message: ""
      progress: 100
      state: ready
  diskLastRefAtMap:
    12baaeb8-7841-43b1-919d-4453cee02f7c: "2024-11-12T06:50:23Z"
  ownerID: k8s3-node173.renderg.com
  size:<PHONE_NUMBER>00
  uuid: 848f375d

backing image file, 150GB

root@k8s3-node173:/mnt/nvme-new/backing-images/test-1112-848f375d# cat backing.cfg | jq
{
  "name": "/data/backing-images/test-1112-848f375d/backing",
  "uuid": "848f375d",
  "size":<PHONE_NUMBER>00,
  "virtualSize":<PHONE_NUMBER>00,
  "expectedChecksum": "edf920af54234e84011bfaef544cea6ae22c79961213ff2695968a098bea6ea10f120b9c4e3d0fe63b3db2ae17a93709d8fd58bb481dd0e20d4e0d7b3c6d034c",
  "currentChecksum": "edf920af54234e84011bfaef544cea6ae22c79961213ff2695968a098bea6ea10f120b9c4e3d0fe63b3db2ae17a93709d8fd58bb481dd0e20d4e0d7b3c6d034c",
  "modificationTime": "2024-11-12 06:59:50.923277882 +0000 UTC"
}
root@k8s3-node173:/mnt/nvme-new/backing-images/test-1112-848f375d# ls -alh
total 151G
drw-r--r--  2 root root 4.0K Nov 12 15:06 .
drw-r--r-- 50 root root 4.0K Nov 12 15:06 ..
-rw-r--r--  1 root root 150G Nov 12 14:59 backing
-rw-r--r--  1 root root  483 Nov 12 15:06 backing.cfg
root@k8s3-node173:/mnt/nvme-new/backing-images/test-1112-848f375d# du -h ./
151G	./

Describe the solution you'd like
Is it possible to store the backing image as a sparse file that will only use space equal to the actual size of the volume?
Describe alternatives you've considered

Additional context
longhorn version v1.7.0

cc @ChanYiLin


[Coverity CID :187824] Integer handling issues in /lib/cmsis_rtos_v1/cmsis_thread.c

Static code scan issues seen in File: /lib/cmsis_rtos_v1/cmsis_thread.c
Category: Integer handling issues
Function: osThreadCreate
Component: Other
CID: 187824
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

Fixed in #9655.


Set closure discriminators via a request.

Rather than set closure discriminators in both the parser (for explicit
closures) and then later as part of contextualizing closures (for
autoclosures), do so via a request that sets all of the discriminators
for a given context.
This eliminates some parser state and is a necessary refactor for
code generation facilities like macros.

@swift-ci please smoke test


sam build --use-container doesn't remove the container

Description
sam build --use-container doesn't remove the container after building is complete.
Steps to reproduce
sam build --use-container # on a Python project
docker ps -a | grep build-python

Observed result
A container still exists:
980cc68b3f5a        lambci/lambda:python3.6                                                  "/var/lang/bin/pytho…"    2 minutes ago       Exited (0) 2 minutes ago                            eloquent_carson

Expected result
No additional containers in docker ps -a. (Equivalent to docker run --rm.)
Additional environment details

OS: macOS 10.14.1
sam --version: SAM CLI, version 0.9.0

@mojodna Thanks for the report. Looks like we never call self._container_manager.stop(container) when .run(container) finishes here.

Released in v0.11.0
Closing


[WIP/Proposal] feat: add working first draft

This PR aims to add custom symbols as part of the symbol finder
This is a step to improve upon Nx development and usage, but done in a more generalized way.
The idea is to detect if a given node ends up defining a function (in the LSP sense) inside it through macro calls.
Given this proposal is accepted, I plan to provide a user configuration for a list of custom names (which solves imported macros as is usual with Nx's defns) and I also plan to add an option to load the "locals_without_parens" list from the formatter configuration (this should reduce even further the use cases in which a user would have to provide their custom symbol)
I've added the Symbols struct mostly so I didn't have to carry tuples around, but I'm not too set on the implementation details yet.

There has been discussions about using compilation tracers. With compilation tracers, you will always know if a macro expands to def, so you can track all definitions. But it requires the code to be compiled.

There has been discussions about using compilation tracers. With compilation tracers, you will always know if a macro expands to def, so you can track all definitions. But it requires the code to be compiled.

This seems interesting. Perhaps it could be done as sort of a partial implementation where some symbols are done "as is" and others are added through said tracers?
Is this a functionality which is already present in Elixir?

General note here: it seems that I've used an outdated version of main, so if the proposal is accepted I'll resolve conflicts properly.

There has been discussions about using compilation tracers. With compilation tracers, you will always know if a macro expands to def, so you can track all definitions. But it requires the code to be compiled.

This seems interesting. Perhaps it could be done as sort of a partial implementation where some symbols are done "as is" and others are added through said tracers?
Is this a functionality which is already present in Elixir?

It is, I have a local PoC of switching document symbols provider to a tracer. It has other problems besides compilation though. Only a limited amount of code level info is available to a tracer.


Database upgrade script

At some point PostgreSQL image was changed from 9.5.2 to 9.6.11 making upgrade not that simple for people that directly use those example files. This has already been queried.
The script is supposed to make upgrade for such cases easier, dumping all database contents with the old image and importing them to new database.

Thanks @raspy for the contribution! Can I ask that you also add a note about this in the README?
This should explain the case and usage of this script.


change the makefile in windows to main.exe in readme.md

./main.exe examples/double_aritmetica.class


Store in global state user vaults

This hook https://github.com/chelofinance/Xion-hackton/blob/main/frontend/hooks/useMyNFTVaults/index.ts
will load the user vaults. To work the user must be logged in.
Now, when its used in different components it fetches the same vaults. I want the vaults to be stored in state and used across the app. Notice that vaults are different from the initial nft table that loads the whole collection, this last componetn should not be affected.
Also, a vault might or might not have any nft on a proposal, so it can raise funds and have 0 nfts to buy.

can I do this later? I am designing like to see all in Portfolio page (/raising-vault) so probably it will not be reused in other components for demo.

can I do this later? I am designing like to see all in Portfolio page (/raising-vault) so probably it will not be reused in other components for demo.

Sure, just make sure to not use hardcoded values


Make the validation script more easy to use

validate that a file was provided and provide a default schema. Document how to use it. Make the script more chatty to facilitate keeping track of its progress (with \r so it only modifies the current terminal line)

@ckongEbi I had another go and made a validator that behaves like a unix filter (as a part of a larger project of being more sure of the data we give to Open Targets and new development)
I can use it in pipelines
cat file | ~/dev/json_schema/scripts/json_schema_validator.pl ~/dev/json_schema

(typing too slowly!) I'm not sure if anyone else will use it and if you want to merge it in - feel free to do if it seems useful!

@ckongEbi Not only the current script is like, state of the art in submission validation, it will also be super convenient if you merge it in :) Following a recent brainwave I'll have a go at adding this repository as a dependency into our dataprod pipeline, so that it refreshes when we deploy, and refer to this validator - so that if we miss a schema update we'll know sooner.


Add car detailer

Since there are several car places that only detail cars, one way to distinguish them would be to add a Car Detailer preset with shop=car_repair with service:vehicle:detailing=yes.

Unfortunately it looks like service:vehicle:detailing only has 34 uses and isn't documented on a wiki page, so we can't really support it yet…


Update Metanorma logo and design

According to Ricardo's latest site design.
The Metanorma logo is now uploaded here: https://github.com/riboseinc/open-design

I believe the symbol and the logo is the only design change at the time. Updated with 4c8e3b10ff04e732aada672f51d22a0ecac5c3cb, f5886a4bd5fbfed96229022bee0db8365095497f, 816e1774b12ac40ae2b40d86d954ea57718ec834, will close when changes are confirmed on live site.

Yup it's updated. Thanks @strogonoff !


[move-prover] parsing unary and binary ops

Finishing up the initial parser for the Move IR specification language.

Motivation
Working toward integrating the Move prover prototype with the IR language.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
New E2E tests.

@bors-libra r=DavidLDill

:pushpin: Commit c321a01 has been approved by DavidLDill

:hourglass: Testing commit c321a01781f83469290ca3954197adbc11712a78 with merge 2f2f0f20af70b57fd336915857c09e914846b4e2...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: DavidLDill
Pushing 2f2f0f20af70b57fd336915857c09e914846b4e2 to master...


Merge 040wip into master.

There will be a follow up PR to cleanup some of the docs and prepare to cut v0.4.0.

/lgtm

I've signed CLA already, and confirm that I'm okay with my commits being contributed to this project.

Manually verified the CLA agreements, sorry for the confusion. Gave feedback to the CLA team.

https://github.com/GoogleCloudPlatform/open-match/issues/136 is the bug tracking this.


Set private false

It can be set  set private to false to register package in the bower registry?
Thanks!

thanks, but we're no longer using bower in sage 9 and we're not really accepting PR's for sage 8 anymore


Adding a constraint for the setuptools version.

At one point, tensorflow imports were failing because of a specific setuptools release.
We applied this patch as an emergency fix.
I do not think we were able to fully investigate the problem.


to solve differential equations

Hi! I would like to add steps to solve different types of differential equations

Go ahead!
Deadline 30 March,2021 (11:59 PM IST)


Ignore the website in CI

Don't build the website in CI or install any of its dependencies. This was suggested by both @timdorr in https://github.com/ReactTraining/react-router/pull/5527#issuecomment-329872051 and @pshrmn in https://github.com/ReactTraining/react-router/issues/4362#issuecomment-328163751. But @ryanflorence seems opposed to the idea (see https://github.com/ReactTraining/react-router/pull/5527#issuecomment-329874880).
Anyway, just wanted to put up this PR real quick so we have a place to discuss. I personally don't think it's a huge deal either way. It doesn't take a terrible amount of time to build the website in CI, but it is annoying. I also don't think building the site is a very valuable test of what's working and what's not. ¯_(ツ)_/¯

Continuing this here as requested:

@ryanflorence
The website uses the current react router code on master, its a great way to gut-check changes in addition to the automated tests.

I'm not sure I understand. It only runs the webpack build. There is no further testing or usage of the build artifacts. It's a wasted effort as far as I can tell.


Fix CHANGELOG.md typo

Before this change, the rest of the change log displayed completely incorrectly.

@mmhansen can you merge this? It's really trivial and really bugs me

:heart:

Hey @strugee, I just noticed you are at the recurse center and got super hyped. I've thought that was a super cool place for a long time. :D I'm so jealous!!

@mmhansen yes, it's amazing!! Hopefully you find some time to apply! I'd highly recommend it.

(Feel free to reach out to me personally too. https://strugee.net/contact)


feature/FE-22 | last minute changes

Last minute changes before the deployments. Discover page has been made dynamic and some css improvements.

Updated Discover page to be fetching the data dynamically. I was there when it was written. LGTM.


Clarify --registry-insecure flag description

Changes

:broom: Clarify --registry-insecure flag description

/kind documentation
Related to #2335, where we discovered that the description of registry-insecure flag was not really accurate/clear.
After investigation, I've found that enabling this flag just means "skip TLS certificate verification when communicating to the registry", not "allow plain HTTP registries", as the current description ("Disable HTTPS when communicating to the registry") can let users think.

Today, the RegistryInsecure boolean in the config (filled from the flag) is used at two places:

In the build command: https://github.com/knative/func/blob/1e7dd33/cmd/build.go#L389

The value is simply forwarded to the Pusher, and is used to configure InsecureSkipVerify: https://github.com/knative/func/blob/1e7dd33/pkg/oci/pusher.go#L129-L135:
        if p.Insecure {
		t := remote.DefaultTransport.(*http.Transport).Clone()
		t.TLSClientConfig = &tls.Config{
			InsecureSkipVerify: true,
		}
		oo = append(oo, remote.WithTransport(t))
	}

In the deploy command: https://github.com/knative/func/blob/1e7dd33/cmd/deploy.go#L282

The value is simply forwarded to the fn.Client (through NewClient): https://github.com/knative/func/blob/1e7dd33/cmd/client.go#L58, and then used to create the transport with InsecureSkipVerify:
https://github.com/knative/func/blob/1e7dd33/cmd/client.go#L96-L98
func newTransport(insecureSkipVerify bool) fnhttp.RoundTripCloser {
	return fnhttp.NewRoundTripper(fnhttp.WithInsecureSkipVerify(insecureSkipVerify), fnhttp.WithOpenShiftServiceCA())
}

I'm pretty confident it's not used elsewhere, but I'm not familiar with the codebase, so tell me if I've missed something.

Note: To me, a better solution would be to completely rename this flag, to something like --insecure-skip-verify or --registry-insecure-skip-verify, as it's effectively only used to configure the InsecureSkipVerify booleans in HTTP transport-related parts of the code.
However, since renaming is a breaking change, I'm not sure if it can be done easily. Another approach, if we want to rename, would be to just 1) add a new flag --insecure-skip-verify, 2) deprecate the existing --registry-insecure, and 3) eventually sunset --registry-insecure.
Internally changing the variable name from RegistryInsecure to InsecureSkipVerify, without touching the flag name, is also possible though. Tell me what you think of this.
In the meantime, changing the description is a good first step IMO to help users figuring out what this flag really means.
Release Note
/
Docs
/

I can't really understand why the integration test is failing (logs seems ok to me, but I have trouble reading the logs).
I'm assuming the test is just flaky and will work after a few retries :wrench:

@norbjd for some reason tests run out of space in the GH action.

@dsimansk would you please override the test?

/override "Integration Test (ubuntu-latest)"

/approve


Removed option for external bitcoin node

Hey @schulterklopfer, can you rebase on current dev branch?  Thanks!

Done! :D


[Tabs/InkBar] InkBar Styles

Added styles prop for InkBar styles on Tabs component @hai-cea

@hai-cea Ok, renamed prop to InkBarStyle and added to Docs site.

Thanks @Zadielerick


bump consul version to 1.0.0

update consul version in example code to 1.0.0

Thanks for the PR!
How did you test this change?

Tested by building the images form the example, successfully:
==> ubuntu16-ami: Creating the AMI: consul-ubuntu-2017-11-14T11-52-04Z
==> amazon-linux-ami: Creating the AMI: consul-amazon-linux-2017-11-14T11-52-04Z

Did you try running the new images in the root example in this repo to see if they still work correctly?

Yep. Fresh proof from the helper script:
2017-11-14 15:16:59 [INFO] [consul-examples-helper.sh] All 3 Consul servers have registered in the cluster!

Wonderful, thank you!

https://github.com/hashicorp/terraform-aws-consul/releases/tag/v0.1.0


V0.12.0.x recognize comments in masternode.conf / write initial file

Recognize "#" as a comment line in masternode config file instead of throwing error. Also write initial file contents (some simple format instructions and an example) if no masternode config file was found.

Nice!


Uncomment first DAMIP request

Not yet, but I guess now is the time to implement a retry with other ESGF nodes hahaha. What is the best way to find these logs in the future?


impl TopHitsAggregation

closes #291
Hello,
i use a simple solution and use the SearchResult.class for reading the source from the topHits. I hope it's useful and a good way to solve this issue.
Thanks
Marcel
TermsBuilder testAgg = AggregationBuilders.terms("test").field("testField").size(10000);
TopHitsBuilder topHitAgg = AggregationBuilders.topHits("top_hits").setSize(100).setFetchSource(true);
configAgg.subAggregation(topHitAgg);

searchQuery.addAggregations(configAgg);

try {
   result = client.execute(searchQuery.build());
} catch (IOException e) {
  // TODO Auto-generated catch block
  e.printStackTrace();
}

MetricAggregation aggs = result.getAggregations();

TermsAggregation configAggs = aggs.getTermsAggregation("test");

if (null != configAggs) {
  for (Entry bucket : configAggs.getBuckets()) {
    String configSku = bucket.getKey();

    TopHitsAggregation topHitResults = bucket.getTopHitsAggregation("top_hits");

    List<Hit< class, Void>> articles = topHitResults.getHits(<class>.class);

    ....
  }
}

Coverage increased (+2.5%) to 51.905% when pulling 7ef8172f91964bc8fcb79618b9744a6c539ce99c on marcelalburg:master into 01b63de2cf577e09a8b7b7e8744644d15fac2ea0 on searchbox-io:master.

Thank you for your contribution @marcelalburg !


Selenium 3 node will not start when Grid Extras running as node only

I have noticed that when Grid Extras is started from scratch to generate a clean config for a node, answering the following questions other than default will result in a configuration that will not create a bat file to start the node.
Run Firefox = 1
Run InternetExplorer = 1
Run Chrome = 1
Restart = 0
Auto Login = 0
Would you like WebDriver etc to auto update? = 0
Webdriver Version = 3.0.1
IEDriver = 3.0.0
Gecko Driver = 0.11.1
Chrome Driver = 2.24
Chrome Driver = 32 Bit
IE Driver = 32 Bit
Store Configs in Central Location = 0
node_5555.txt
selenium_grid_extras_config.txt
I am running Java 1.8.0_66-b18.  If you need more info then please let me know.
Any help or workaround appreciated.

The txt files are the generated config files.  It wouldn't let me attach them in JSON format.

I'll look at this. What version of Grid Extras are you using? @nvonop
I see it gets created here https://github.com/groupon/Selenium-Grid-Extras/blob/master/SeleniumGridExtras/src/main/java/com/groupon/seleniumgridextras/grid/GridStarter.java#L173
I can try your exact first time run config options to see if I can reproduce.

I reproduced this with 1.12.7 . My guess is that https://github.com/groupon/Selenium-Grid-Extras/blob/master/SeleniumGridExtras/src/main/java/com/groupon/seleniumgridextras/grid/GridStarter.java#L125 is returning 0 config files. I will have to do some debugging tho

@nvonop I actually see node_5555.bat is getting created. Are you seeing something else ?

Sorry for the slow response. I was running 1.2.4 on Windows 7 64.

Also, to confirm, I was not even getting a bat file created following the initial configuration questions.

@nvonop can you try 1.12.7 ?

Sure. Will try today and confirm.

This seems to be resolved in 1.12.7.  Thanks for taking a look.  Will close the issue.


Made 'pyuff' dependency optional

Much of Mosqito can be used without the 'pyuff' package. 'pyuff' is released under the GPL license, and being a required dependecy of Mosqito, prevents Mosqito from being used in other software that must be under a more permissive license. Therefore proposing to make 'pyuff' optional such that Mosqito can be used without too much trouble in dependency resolving.
Mosqito can now be installed with pip install mosqito for the basic package, or variants like pip install mosqito[uff] for also having the 'pyuff' dependency or pip install mosqito[all] to have also the testing dependencies.

Thanks for the contribution


Unusual dictionary usages

Added assignment through dictionary and function calling through dictionary.

Hey @sgs00,
your examples are already shown here.

Sorry!

No need to apologize :)


empty array: [] on prediction (CMLE)

I have implemented a custom tfx example after working trough the tfx taxi example.
The model that is trained in the tfx pipeline is a canned estimator estimator: DNNRegressor.
inside model_fn of custom estimator
tags = tf.feature_column.numeric_column(
        key=_transformed_name(_FEATURE_KEY), shape=[500], dtype=tf.int64)

    return tf.estimator.DNNRegressor(
        config=config,
        feature_columns=[tags],
        hidden_units=[25],
        activation_fn=tf.nn.relu
    )

definition of serving receiver
def _example_serving_receiver_fn(transform_output, schema):
    """Build the serving in inputs.
    Args:
        transform_output: directory in which the tf-transform model was written
        during the preprocessing step.
        schema: the schema of the input data.
    Returns:
        Tensorflow graph which parses examples, applying tf-transform to them.
    """

    raw_feature_spec = _get_raw_feature_spec(schema)
    raw_feature_spec.pop(_LABEL_KEY)

  # if only this function wasn't 100% black-box
    raw_input_fn = tf.estimator.export.build_parsing_serving_input_receiver_fn(
        raw_feature_spec, default_batch_size=None)

    serving_input_receiver = raw_input_fn()

    _, transformed_features = (
        saved_transform_io.partially_apply_saved_transform(
            os.path.join(transform_output, transform_fn_io.TRANSFORM_FN_DIR),
            serving_input_receiver.features))

    return tf.estimator.export.ServingInputReceiver(
        transformed_features, serving_input_receiver.receiver_tensors)

actually calling serving receiver
    def serving_receiver_fn(): return _example_serving_receiver_fn(  # pylint: disable=g-long-lambda
            hparams.transform_output, schema)

    exporter = tf.estimator.FinalExporter(
        'stackoverflow-tfx', serving_receiver_fn)
    eval_spec = tf.estimator.EvalSpec(
        eval_input_fn,
        steps=hparams.eval_steps,
        exporters=[exporter],
        name='stackoverflow-tfx-eval')

The custom implementation of the tfx pipeline runs without problems all the way.
The ml engine model & version exist, the saved model.pb exists.
But when I try to make a prediction to the ml engine model it returns an empty array.
like: {'predictions': []}
I used to make predictions via code but found that the UI also works the same

Where do I start debugging or does anyone know what could be going on?
Training on ml engine with python version 2.7
ml engine runtimeVersion 1.12 for both training and serving (assuming that means tensrflow 1.12)

Looks like it is related to TFX. We can open an issue on this repository for better help on the same. Thanks!

@achandraa someone in TFX asked me to post the issue here.
Original issue

Please provide details about what platform you are using (operating system, architecture). Also include your TensorFlow version. If possible can you provide the code snippet so that we can replicate the issue. Thanks!

Okay, so I turns out that even with a canned DNNRegressor estimator the exact same issue happens.
This is where I expect things are going wrong:
def _example_serving_receiver_fn(transform_output, schema):
    """Build the serving in inputs.
    Args:
        transform_output: directory in which the tf-transform model was written
        during the preprocessing step.
        schema: the schema of the input data.
    Returns:
        Tensorflow graph which parses examples, applying tf-transform to them.
    """

    raw_feature_spec = _get_raw_feature_spec(schema)
    raw_feature_spec.pop(_LABEL_KEY)

    raw_input_fn = tf.estimator.export.build_parsing_serving_input_receiver_fn(
        raw_feature_spec, default_batch_size=None)

    serving_input_receiver = raw_input_fn()

    transformed_features = transform_output.transform_raw_features(
        serving_input_receiver.features)

    return tf.estimator.export.ServingInputReceiver(
        transformed_features, serving_input_receiver.receiver_tensors)

This code is supposed to build a serving input receiver that takes in raw data (before tf transform is applied), transforms that data accordingly and finally passes that data to the estimator
My tf transform uses compute_and_apply_vocabulary so I am stuck using this implementation instead of one with tf.placeholders.
estimator looks like this
tags = tf.feature_column.numeric_column(
        key=_transformed_name(_FEATURE_KEY), shape=[500], dtype=tf.int64)

    return tf.estimator.DNNRegressor(
        config=config,
        feature_columns=[tags],
        hidden_units=[25],
        activation_fn=tf.nn.relu
    )

input to the model is a multi one hot encoded array of size 500 each representing one categorical feature that has 500 options, output is a single number
When I open the ml engine logs where the serving graph is exported it logs this:
Signatures INCLUDED in export for Regress: ['serving_default', 'regression']

'regression' is probably created by the estimator but why are there 2 signatureDefs there?
does that mean there are 2 ways of predicting against the model and i'm using the wrong one?
Also I am continuously trying to fix this bug so the error's and logs may not be from the exact same trials. Stopping and waiting 24h is not an option.

I enabled logging for both the example model and my model and both log status 200 on prediction. Which is technically true, since it does return something.
I expect that the estimator is not correctly receiving the inputs from the prediction request.
What is weird is that it returns like {'predictions': []} instead of {'predictions': {'some_key': []}}
Is there a way to log values in the serving_receiver_fn()? I'm currently implementing the exact same situation in a notebook to try and reproduce the empty array output.
If you need any additional logs please ask

I'm sorry for spreading all this information in many comments but this issue involves way too much code that could be incorrect.
Here is my preprocessing function used by tf transoform (supposed to be applied during training AND inference)
def preprocessing_fn(inputs):
    """tf.transform's callback function for preprocessing inputs.
    Args:
        inputs: map from feature keys to raw not-yet-transformed features.
    Returns:
        Map from string feature key to transformed feature operations.
    """
    outputs = {}

    dense_features = tf.reshape(
        tf.sparse_tensor_to_dense(
            inputs[_FEATURE_KEY],
            default_value=''
        ),
        [-1]
    )

    dense_labels = tf.reshape(
        tf.sparse_tensor_to_dense(
            inputs[_LABEL_KEY],
            default_value=-1
        ),
        [-1]
    )

    sparse_split = tf.string_split(dense_features, delimiter='|')

    sparse_indexes = tft.compute_and_apply_vocabulary(
        sparse_split,
        default_value=-1,  # -1 will cause the one_hot_encoding to return all 0 array
        top_k=500
    )

    dense_indexes = tf.sparse_tensor_to_dense(
        sparse_indexes,
        default_value=-1
    )

    single_max_index = tf.reduce_max(
        dense_indexes
    )

    one_hot = tf.one_hot(
        indices=dense_indexes,
        depth=500,
        on_value=1,
        off_value=0)

    multi_one_hot = tf.reduce_sum(
        one_hot,
        1
    )

    int64_multi_one_hot = tf.cast(
        multi_one_hot,
        dtype=tf.int64
    )

    outputs[_transformed_name(_FEATURE_KEY)] = int64_multi_one_hot
    outputs[_transformed_name(_LABEL_KEY)] = dense_labels

    return outputs

The problem could also be that I am calling the prediction incorrectly.
In the taxi example they use a function called _fill_in_missing to replace all empty tensors during serving with zeros or empty strings. What is the correct json format to call my model?
def _fill_in_missing(x):
  """Replace missing values in a SparseTensor.
  Fills in missing values of `x` with '' or 0, and converts to a dense tensor.
  Args:
    x: A `SparseTensor` of rank 2.  Its dense shape should have size at most 1
      in the second dimension.
  Returns:
    A rank 1 tensor where missing values of `x` have been filled in.
  """
  default_value = '' if x.dtype == tf.string else 0
  return tf.squeeze(
      tf.sparse.to_dense(
          tf.SparseTensor(x.indices, x.values, [x.dense_shape[0], 1]),
          default_value),
      axis=1)

def preprocessing_fn(inputs):
  """tf.transform's callback function for preprocessing inputs.
  Args:
    inputs: map from feature keys to raw not-yet-transformed features.
  Returns:
    Map from string feature key to transformed feature operations.
  """
  outputs = {}
  for key in _DENSE_FLOAT_FEATURE_KEYS:
    # Preserve this feature as a dense float, setting nan's to the mean.
    outputs[_transformed_name(key)] = tft.scale_to_z_score(
        _fill_in_missing(inputs[key]))

  for key in _VOCAB_FEATURE_KEYS:
    # Build a vocabulary for this feature.
    outputs[_transformed_name(key)] = tft.compute_and_apply_vocabulary(
        _fill_in_missing(inputs[key]),
        top_k=_VOCAB_SIZE,
        num_oov_buckets=_OOV_SIZE)

  for key in _BUCKET_FEATURE_KEYS:
    outputs[_transformed_name(key)] = tft.bucketize(
        _fill_in_missing(inputs[key]), _FEATURE_BUCKET_COUNT)

  for key in _CATEGORICAL_FEATURE_KEYS:
    outputs[_transformed_name(key)] = _fill_in_missing(inputs[key])

  # Was this passenger a big tipper?
  taxi_fare = _fill_in_missing(inputs[_FARE_KEY])
  tips = _fill_in_missing(inputs[_LABEL_KEY])
  outputs[_transformed_name(_LABEL_KEY)] = tf.where(
      tf.is_nan(taxi_fare),
      tf.cast(tf.zeros_like(taxi_fare), tf.int64),
      # Test if the tip was > 20% of the fare.
      tf.cast(
          tf.greater(tips, tf.multiply(taxi_fare, tf.constant(0.2))), tf.int64))

  return outputs

I found the critical code that was causing the empty return. It was the serving receiver function that is responsible for the signatureDef in the exported model.
def _example_serving_receiver_fn(transform_output, schema):
    """Build the serving in inputs.
    Args:
        transform_output: directory in which the tf-transform model was written
        during the preprocessing step.
        schema: the schema of the input data.
    Returns:
        Tensorflow graph which parses examples, applying tf-transform to them.
    """

    raw_feature_spec = _get_raw_feature_spec(schema)
    raw_feature_spec.pop(_LABEL_KEY)

    raw_input_fn = tf.estimator.export.build_parsing_serving_input_receiver_fn(
        raw_feature_spec, default_batch_size=None)

    serving_input_receiver = raw_input_fn()

    _, transformed_features = (
        saved_transform_io.partially_apply_saved_transform(
            os.path.join(transform_output, transform_fn_io.TRANSFORM_FN_DIR),
            serving_input_receiver.features))

    return tf.estimator.export.ServingInputReceiver(
        transformed_features, serving_input_receiver.receiver_tensors)

To get around this I implemented a serving receiver the regular way, without using tf transform.
I still don't know which one of the functions in this snippet is the cause.
I replaced it with:
def _example_serving_receiver_fn():
    feature_placeholders = {_FEATURE_KEY:
                            tf.placeholder(tf.int64, shape=(None, 5))}

    one_hot = tf.one_hot(
        indices=feature_placeholders[_FEATURE_KEY],
        depth=500,
        on_value=1,
        off_value=0)

    multi_one_hot = tf.reduce_sum(
        one_hot,
        1
    )

    int64_multi_one_hot = tf.cast(
        multi_one_hot,
        dtype=tf.int64
    )

    reshaped_multi_hot = tf.reshape(
        int64_multi_one_hot,
        [-1, 500]
    )

    features = {
        _transformed_name(_FEATURE_KEY): reshaped_multi_hot
    }

    return tf.estimator.export.ServingInputReceiver(features, feature_placeholders)

In theory the first snippet is supposed to result in the same as the second by reusing the saved transform function. My main problem was that every function in the first snippet was a black-box and I have no idea whats happening or where its going wrong.

I am having same issue what was the solution to above problem?


Extend ring.Buffer capabilities

fixes #1069

Codecov Report

Merging #1073 (4ec547e) into master (828364b) will decrease coverage by 1.56%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##           master    #1073      +/-   ##
==========================================
- Coverage   50.51%   48.95%   -1.57%
==========================================
  Files         145      154       +9
  Lines        7544     8108     +564
==========================================
+ Hits         3811     3969     +158
- Misses       3066     3441     +375
- Partials      667      698      +31

Impacted Files
Coverage Δ

pkg/config/consts.go
0.00% <ø> (ø)

pkg/config/genesis/config.go
0.00% <0.00%> (ø)

pkg/config/genesis/presets.go
50.00% <ø> (ø)

pkg/core/candidate/validator.go
57.14% <ø> (ø)

pkg/core/chain/legacy.go
26.08% <0.00%> (-2.49%)
:arrow_down:

pkg/core/chain/mock.go
8.33% <ø> (ø)

pkg/core/consensus/agreement/accumulator.go
83.01% <ø> (ø)

pkg/core/consensus/agreement/handler.go
56.14% <ø> (ø)

pkg/core/consensus/agreement/store.go
62.12% <ø> (ø)

pkg/core/consensus/agreement/testutil.go
100.00% <ø> (ø)

... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d9302...4ec547e. Read the comment docs.

This PR has been reworked and comments addressed into #1086 PR


"Done" message was shown when running dotnet ef migrations script

I'm working on ef migrations in web tool side. I use dotnet ef migrations script to generate T-SQL file of migrations. When this command is done, it will show a "Done" on screen, whose the code is from src/dotnet-ef/MigrationsScriptCommand.cs  (line 74 Reporter.Error.WriteLine("Done");) . This "Done" should not be handled by "Reporter.Error".
When I run the whole thing by msbuild tasks, the "Done" will be captured by msbuild.exe and it was recognized an error message. This makes people think this command has a problem and actually it is not.
Is there an option not showing "Done" on screen or some other approach to skip "Done" ?

Fixed via #5020. More work on how we log needs to be done. See #4771

I am using Entity Framework .NET Core CLI Commands 1.0.0-rc3-20747 and still hitting this issue.
dotnet : Done. To undo this action, use 'ef migrations remove'
At line:1 char:1
+ dotnet ef migrations add Init
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (Done. To undo t...rations remove':String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

not just for done for any other message also same error
dotnet : An operation was scaffolded that may result in the loss of data. Please review the migration for accuracy.
At line:1 char:1
+ dotnet ef migrations add StringLength
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (An operation wa...n for accuracy.:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

Done. To undo this action, use 'ef migrations remove'

Reopening for now based on @smitpatel's findings.

Possible duplicate of #4771

I was using powershell.

I've proposed 2 changes in #5542 that will help with this and related scripting errors:

dotnet ef will only use stderr for actual error messages.
Commands with json output --json will now also have --json-delimited. This will additionally spit out '//BEGIN' and '//END' for those so those building scripting on top of ef commands and who need to ensure they get only JSON as they parse its output.

cc @mlorbetske


5pm 3 - Fix spacing of "Submit" & "Download CSV" buttons on Home

This pull request closes issue #111  by removing the vertical gap between the "Submit" and "Download CSV" buttons on the home page.
This image shows the changes on the home page.

Also, don't forget to have a team mate re-review your code after you make a new change. Previous approvals don't carry over.


Expert mode

Added Expert Mode as a hidden application setting. This will deactivate some user guidance in the UI, e.g. not activate preceding products in the creation of a new colmap product. This is for pure experts who know what they are doing.
Even though the commit history requires the merge of the cmake build system, this addition is not dependent on CMAKE and could be cherry picked into the master branch.

This PR has been cherry picked into the expert branch for some minor adjustments.


NoSuperfluousPhpdocTagsFixer - Causing error during fix run

The PHP version you are using ($ php -v):
7.2.8
PHP CS Fixer version you are using ($ php-cs-fixer -V):
2.12.2 (have also tested against dev-master)
The command you use to run PHP CS Fixer:
./vendor/bin/php-cs-fixer fix config.php
The configuration file you are using, if any:
<?php

return PhpCsFixer\Config::create()
    ->setRules([
        'no_superfluous_phpdoc_tags' => true,
    ]);

If applicable, please provide minimum samples of PHP code (as plain text, not screenshots):

before running PHP CS Fixer (no changes):

<?php
/**
 * Configuration for "min", the default application built with the Minify
 * library
 *
 * @package Minify
 */

/**
 * Enable the static serving feature
 */
$min_enableStatic = false;

/**
 * Allow use of the Minify URI Builder app. Only set this to true while you need it.
 */
$min_enableBuilder = false;

/**
 * Concatenate but do not minify the files. This can be used for testing.
 */
$min_concatOnly = false;

/**
 * If non-empty, the Builder will be protected with HTTP Digest auth.
 * The username is "admin".
 */
$min_builderPassword = 'admin';

/**
 * Set to true to log messages to FirePHP (Firefox Firebug addon) and PHP's error_log
 * Set to false for no error logging (Minify may be slightly faster).
 */
$min_errorLogger = false;

/**
 * To allow debug mode output, you must set this option to true.
 *
 * Once true, you can send the cookie minDebug to request debug mode output. The
 * cookie value should match the URIs you'd like to debug. E.g. to debug
 * /min/f=file1.js send the cookie minDebug=file1.js
 * You can manually enable debugging by appending "&debug" to a URI.
 * E.g. /min/?f=script1.js,script2.js&debug
 *
 * In 'debug' mode, Minify combines files with no minification and adds comments
 * to indicate line #s of the original files.
 */
$min_allowDebugFlag = false;

/**
 * For best performance, specify your temp directory here. Otherwise Minify
 * will have to load extra code to guess. Some examples below:
 */
//$min_cachePath = 'c:\\WINDOWS\\Temp';
$min_cachePath = '/tmp';
//$min_cachePath = preg_replace('/^\\d+;/', '', session_save_path());

/**
 * To use APC/Memcache/ZendPlatform for cache storage, require the class and
 * set $min_cachePath to an instance. Example below:
 */
$min_cachePath = new Minify_Cache_APC();

/**
 * Leave an empty string to use PHP's $_SERVER['DOCUMENT_ROOT'].
 *
 * On some servers, this value may be misconfigured or missing. If so, set this
 * to your full document root path with no trailing slash.
 * E.g. '/home/accountname/public_html' or 'c:\\xampp\\htdocs'
 *
 * If /min/ is directly inside your document root, just uncomment the
 * second line. The third line might work on some Apache servers.
 */
$min_documentRoot = '';
//$min_documentRoot = dirname(dirname(__DIR__));
//$min_documentRoot = substr(__FILE__, 0, -15);
//$min_documentRoot = $_SERVER['SUBDOMAIN_DOCUMENT_ROOT'];

/**
 * Cache file locking. Set to false if filesystem is NFS. On at least one
 * NFS system flock-ing attempts stalled PHP for 30 seconds!
 */
$min_cacheFileLocking = true;

/**
 * Combining multiple CSS files can place @import declarations after rules, which
 * is invalid. Minify will attempt to detect when this happens and place a
 * warning comment at the top of the CSS output. To resolve this you can either
 * move the @imports within your CSS files, or enable this option, which will
 * move all @imports to the top of the output. Note that moving @imports could
 * affect CSS values (which is why this option is disabled by default).
 */
$min_serveOptions['bubbleCssImports'] = false;

/**
 * Cache-Control: max-age value sent to browser (in seconds). After this period,
 * the browser will send another conditional GET. Use a longer period for lower
 * traffic but you may want to shorten this before making changes if it's crucial
 * those changes are seen immediately.
 *
 * Note: Despite this setting, if you include a number at the end of the
 * querystring, maxAge will be set to one year. E.g. /min/f=hello.css&123456
 */
$min_serveOptions['maxAge'] = 1800;

/**
 * To use the CSS compressor that shipped with 2.x, uncomment the following line:
 */
//$min_serveOptions['minifiers'][Minify::TYPE_CSS] = array('Minify_CSS', 'minify');

/**
 * To use Google's Closure Compiler API to minify Javascript (falling back to JSMin
 * on failure), uncomment the following line:
 */
//$min_serveOptions['minifiers']['application/x-javascript'] = array('Minify_JS_ClosureCompiler', 'minify');

/**
 * If you'd like to restrict the "f" option to files within/below
 * particular directories below DOCUMENT_ROOT, set this here.
 * You will still need to include the directory in the
 * f or b GET parameters.
 *
 * // = shortcut for DOCUMENT_ROOT
 */
//$min_serveOptions['minApp']['allowDirs'] = array('//js', '//css');

/**
 * Set to true to disable the "f" GET parameter for specifying files.
 * Only the "g" parameter will be considered.
 */
$min_serveOptions['minApp']['groupsOnly'] = false;

/**
 * By default, Minify will not minify files with names containing .min or -min
 * before the extension. E.g. myFile.min.js will not be processed by JSMin
 *
 * To minify all files, set this option to null. You could also specify your
 * own pattern that is matched against the filename.
 */
//$min_serveOptions['minApp']['noMinPattern'] = '@[-\\.]min\\.(?:js|css)$@i';

/**
 * If you minify CSS files stored in symlink-ed directories, the URI rewriting
 * algorithm can fail. To prevent this, provide an array of link paths to
 * target paths, where the link paths are within the document root.
 *
 * Because paths need to be normalized for this to work, use "//" to substitute
 * the doc root in the link paths (the array keys). E.g.:
 * <code>
 * array('//symlink' => '/real/target/path') // unix
 * array('//static' => 'D:\\staticStorage')  // Windows
 * </code>
 */
$min_symlinks = [];

/**
 * If you upload files from Windows to a non-Windows server, Windows may report
 * incorrect mtimes for the files. This may cause Minify to keep serving stale
 * cache files when source file changes are made too frequently (e.g. more than
 * once an hour).
 *
 * Immediately after modifying and uploading a file, use the touch command to
 * update the mtime on the server. If the mtime jumps ahead by a number of hours,
 * set this variable to that number. If the mtime moves back, this should not be
 * needed.
 *
 * In the Windows SFTP client WinSCP, there's an option that may fix this
 * issue without changing the variable below. Under login > environment,
 * select the option "Adjust remote timestamp with DST".
 * @link http://winscp.net/eng/docs/ui_login_environment#daylight_saving_time
 */
$min_uploaderHoursBehind = 0;

/**
 * Advanced: you can replace some of the PHP classes Minify uses to serve requests.
 * To do this, assign a callable to one of the elements of the $min_factories array.
 *
 * You can see the default implementations (and what gets passed in) in index.php.
 */
//$min_factories['minify'] = ... a callable accepting a Minify\App object
//$min_factories['controller'] = ... a callable accepting a Minify\App object

That file is config.php that I'm telling the fixer to run against. It comes from this project: https://github.com/mrclay/minify/blob/master/config.php but with minor modifications for our environment.
PHP-CS-Fixer emits this message when processing this file with this fixer:
Files that were not fixed due to errors reported during fixing:
   1) config.php

With -vvv, I get this message:
Files that were not fixed due to errors reported during fixing:
   1) config.php

        [RuntimeException]
        Index invalid or out of range

      PhpCsFixer\Fixer\Phpdoc\NoSuperfluousPhpdocTagsFixer->findDocumentedFunction()
        in vendor/friendsofphp/php-cs-fixer/src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php at line 94
      PhpCsFixer\Fixer\Phpdoc\NoSuperfluousPhpdocTagsFixer->applyFix()
        in vendor/friendsofphp/php-cs-fixer/src/AbstractFixer.php at line 75
      PhpCsFixer\AbstractFixer->fix()
        in vendor/friendsofphp/php-cs-fixer/src/Runner/Runner.php at line 190
      PhpCsFixer\Runner\Runner->fixFile()
        in vendor/friendsofphp/php-cs-fixer/src/Runner/Runner.php at line 132
      PhpCsFixer\Runner\Runner->fix()
        in vendor/friendsofphp/php-cs-fixer/src/Console/Command/FixCommand.php at line 220
      PhpCsFixer\Console\Command\FixCommand->execute()
        in vendor/symfony/console/Command/Command.php at line 251
      [ ... ]

PHP doesn't complain about this file (with php -l config.php) and if I remove that particular fixer all is good.

Thanks for reporting @jaydiablo :+1:
@kubawerlos put together a fix which will be part of the next release for this bug in the fixer


why is that the generated poetry doesn't contain the keywords？

why is that the generated poem doesn't contain the keywords？
Input Text:	春天桃花开了
Keywords:	桃花开 相宜 春天 江边
Poem Generated:
梅花香满绿荫时，石木无春午六滨。
江水东归灯下望，江南车径与谁槟。
In the paper “ChinesePoetryGenerationwithPlanningbasedNeuralNetwork”，it seems that the generated poem contains the keywords.

Sorry for the delay. I didn't follow the original paper completely. That maybe the cause of this problem.
Thx.


Read the docs - Link returns 404

Environment
RTD https://nautobot.readthedocs.io/en/stable/administration/nautobot-server/#dumpdata

Steps to Reproduce

https://nautobot.readthedocs.io/en/stable/administration/nautobot-server/#dumpdata

url returned https://nautobot.readthedocs.io/en/stable/latest/installation/migrating-from-postgresql/#export-data-from-postgresql

Expected Behavior
200 response & proper link

Observed Behavior
404 and dead link

This was resolved in #2303.

Confirmed, this was fixed in #2303.


Git prompt performance

Decided to try out this theme, was very impressed by a number of things. However, a deal breaker is the performance of the git segment. Even in a pretty small git repo, there is noticeable lag after each time I hit enter until it is repainted (not present outside of git repos). On the other hand, sorin theme from prezto (which I use a very small fork of) is 100% instant. I'd suggest adopting some of the implementation from here:  https://github.com/sorin-ionescu/prezto/blob/master/modules/prompt/functions/prompt_sorin_setup.

@quicknir - Thanks so much for the feedback! Yes, the vcs segment has been a weak point of P9k for a while, now. It sounds like you have done some really great work, though!
Would you mind sharing what you've done? Feel free to either just post a git diff here, or even file a PR so I can see a changeset that you have tested and verified is working.
I would actually like to get this integrated as soon as possible - if we have a clear path to improving the vcs segment, I'd like to get it done.

@bhilburn Okay, I'll give this a shot, it may take a few days before I can look at it. You're giving me too much credit, I didn't really do anything but notice that another person (sorin) had done good work :-) I also want to think about customizability for git; traditionally with these things, they only show e.g. * to indicate that there are modified files, but I much prefer e.g. *2 to indicate there are two modified files. I can send a screenshot of my setup if you like, but probably best would be to make it easy to customize (also, being able to customize color especially is rather crucial).

Okay, so I sat down to look at the code today. There are two non-trivial complications. The first is that the approach used by the sorin theme in the prezto package, uses a fair bit of code from another prezto module (prezto has a dedicated module for retrieving git info, it's pretty nice. However, that code might be very similar to the code you already have for extracting various bits of information, so I don't know to what extend you'll want to duplicate that in this repo (or even how that works in terms of license, etc). The thing that really drives the performance in sorin is being async. So in principle that can be fused with some of the existing functions.
The second is that the current approach supports both git and mercurial, whereas again, the sorin stuff only supports git.
Basically, while getting a nice git segment up and running for me personally as a prezto user is trivial, getting git+mercurial segment that works in powerlevel9k independently of prezto is quite a bit less trivial. At its most hacky, you could basically copy in all the code you need from prezto and just bifurcate the git and and mercurial implementations, but I doubt this is what you would want.
Anyway, I'm curious to hear your thoughts generally. I may, to be honest, not be the guy for the PR if it is something non-trivial: I love zsh for interactive stuff but actually really dislike writing scripts in it (I'm one of those just do it in python guys), and my skills are not very sophisticated, so in the past whenever I've done things to get my setup working it's been very time consuming (e.g. I was skimming your code just now and saw (( ahead )) && gitstatus+=( " $(print_icon 'VCS_OUTGOING_CHANGES_ICON')${ahead// /}" ), I really have trouble understanding exactly what's going on even in this relatively simple code).
Alright, let me know your thoughts!

I use the git prompt for over a year now. I never had any performance issues.

I'm in the camp of having experienced performance issues. If I cd into a particular git repository, the shell appears to hang. If I use Ctrl-c, then type a command, I eventually get response but if I do not Ctrl-c then nothing is output from the shell even if I wait, say, 15 minutes (literal terms; I was trying to troubleshoot from another ssh connection to the host to hopefully find what was hanging the shell).
If I disable the vcs portion of the prompt, responses are close enough to instant.
I wish I knew how to provide more useful information for this, but given the history so far in this issue it may not be necessary.

I do see a performance decrease while under a git versioned directory.

So, there's a bit of a long history here. I'll try to explain where we currently are and what needs to get done. The fact of the matter is that the vcs segment is arguably the most important segment in P9k, and it is also the poorest performing.
The issue, fundamentally, is that querying the local git repository is expensive. There are two types of git code in P9k. Some is provided by ZSH's VCS_INFO module, and some is stuff we have coded. In both cases, the issue is that some git commands can take a very long time to return results - especially if the repo is large or has a long history. If you take the git commands that P9k and VCS_INFO are using and run them yourself, you'll see similar results.
What many other themes have resorted to doing is forking these git commands off into another process, drawing the prompt before it's ready, and then updating the prompt when the information shows up.
We've known that this needs to get done for a while now. In fact, @ayyjayess and @Tritlo first started working on P9k async stuff in 2016, in #263. @ayyjayess pointed out that the zsh-async library exists, and we even had some discussion with its creator, @mafredri, about integrating it with P9k. This work continued in #331.
Around this time, @dritter began a massive update effort in which he was converting all existing segments to be asynchronous using a self-built async functionality - you can see this work in #344. This was a massive undertaking, and @dritter poured tons of time into it through mid 2017. But, life happens, everyone was busy, and things slowed.
In April of last year, @onaforeignshore also started hacking on the zsh-async integration, picking up #331 and continuing it in #504. He got it to the point that it worked with experimental stability, and asked for my help. To be honest, I just haven't gotten to it.
Your findings, @quicknir, that the Sorin theme performs better using an async capability totally lines up with what we would expect.
We very much need to move the vcs segment, at the very least, to some sort of async library. One of the top goals of P9k is to keep things speedy, and right now the vcs segment absolutely kills that. The major issue, as you probably surmised from the above, is simply manpower. I'm insanely busy, and it's difficult for me to find time to sit down and just do something like this. @dritter is in a similar boat. Both @dritter and @onaforeignshore have done a ton of work on async, but it's quite likely that their work has bitrotted to the point, now, where it would need some time to stand it back up again.
I think in the near-term, our best solution is to go back to the zsh-async library and implement it for the vcs segment. It doesn't need to be for every segment - just vcs. And we need to not include a ton of other work in that PR. Just the port of vcs to zsh-async. Getting that done would have a tremendously beneficial impact for P9k.
Back to the issue of time, realistically, I just need help getting this done. Right now I simply don't have the time to do it. If anyone is up for taking this on, I am happy to help as I can, and I'm sure plenty of others here will volunteer to help solve difficult hurdles and provide reviews - but the bulk of the development will need to be done by you.
So, anyone up for it? =)

Can I request an interim patch?
Just add a 10-second timeout to the git prompt and after that just draw it with timeout as the text?
I've been sitting at this blank prompt for long enough to search through this repos issues and post this comment :/

(RPROMPT shown because I tried to ctrl-c, but to no avail. )

@quicknir @robobenklein which git version do you use? The VCS segment relies heavily on git, and old git versions seem to be quite slow on some queries.
Btw. Did you know, you could disable some of the checks to see if one of them is causing significant lag? I mean, the segment as a whole is slow -> this should be fixed with async help some day. But, for instance, having a lot of untracked files slows down the prompt significantly:

The single callbacks for git are defined via POWERLEVEL9K_VCS_GIT_HOOKS=(vcs-detect-changes git-untracked git-aheadbehind git-stash git-remotebranch git-tagname).
Regarding the untracked files:
It might be worth a shot to pick up @tupton 's suggestion from https://github.com/bhilburn/powerlevel9k/issues/60#issuecomment-368130608

The specific case that I had hit was on a 4.6GB repo of binary files with all files tracked and unmodified. The real slowdown was reading that 4.6GB from the disk at usb-drive speeds. Once it was in memory disk cache, there wasn't a problem.

@bhilburn I'm interested in volunteering to take a look at this one.
I had a colleague comment on the slowness of p9k and would like to help with addressing this issue, plus learning how to create a sync prompt features sounds really useful.
https://github.com/mafredri/zsh-async
This tutorial explains how to apply it to another prompt, which could be used as a starting point to add it to P9k. https://medium.com/@henrebotha/how-to-write-an-asynchronous-zsh-prompt- b53e81720d32

Hey @yeganer - Sorry, I somehow missed the notification when you posted here.... four months ago =(
@ryanwhocodes @yeganer - I super appreciate you guys offering to dig into this. So, we are working on making the v0.6.6 release ASAP. This release will be the final release using the existing codebase.
Once that release is done, we will migrate to what we are calling the v0.7.0 codebase, for lack of a better name. It is heavily refactored & reorganized, and has a lot of new features. One of these features is the concept of "generators", which @onaforeignshore came up with, which will basically allow us to ship different backends in p9k to use for rendering the segments. The default one in that branch, currently, is the same as the current codebase. But, the next one should be async. In fact, if you check out the branch onaforeignshore-code_separation, you can see I've already pulled the zsh-async library into p9k as a subtree.
So, the next thing that needs to happen is that we need to actually use zsh-async (there is a "generator" for it in that branch, but it's the same as the default generator right now). If you're up for it, making a new generator using zsh-async is the next critical step.
This would be a really significant contribution to p9k, if you're up for taking it on. Me, @dritter, and @onaforeignshore are here to help and guide you along the way, but we're spending most of our time right now trying to push v0.6.6 out the door and then start to prepare v0.7.0, and simply don't have the manpower to also take that on ourselves at the moment. Let us know if you're up for it, and if you can, be sure to join the Gitter and chat with us =)
Tell your co-worker to hang in there just a little bit longer - we're almost there =)

@bhilburn Correction. 070-registerSegment already contains a working zsh-async generator. It just needs testing and tweaking.

@bhilburn Great to hear there's so much progress with P9k in terms of structure and improving performance.
This is a little off topic of adding callbacks to Powerlevel9k, but I've ported a basic version of Powerlevel9k using Rust at https://github.com/ryanwhocodes/rustlevel9k.
So far it includes the path and git branch info. The git section changes colors of depending on the git status.
It should be able to be extended to integrate with other shell scripted prompt segments if that's something of interest.
Also, I'm interested to see if you can implement a callback system to update the prompt text using Rust, it's already pretty fast for most uses, but that might make it even faster!

Hello, this is a great goal, just to want to check how is it going, I would be glad to help testing it. Thanks!

@phcerdan - We're still making progress, here! The v0.7.0 codebase now exists on the next branch! If you wouldn't mind checking out next and letting us know how it works for you, that would be SUPER helpful.
The next major step is that @onaforeignshore is implementing the zsh-async based segment generator, which will allow for asynchronous segment processing. We also expect this to have a significant impact.

@bhilburn I've been experiencing the same exact slowness on all the VCS code, and while the next branch is a bit better, it's still super slow.
I can confirm that @phcerdan change in VSC Git Hooks actually fixes the issues (but misses some features, I'm kind of fine with that.)
Like, it went from 1 second to load the prompt to almost instant. It's a huuuuge gain of time (Imagine each time you hit enter, you have to wait 1 second to see the prompt properly. So annoying.)

@phcerdan @Erowlin - Wow, really? It had that much of a difference?
That's interesting, because those changes don't have anything to do with P9k -- those are specific to OMZ. That's super helpful information.
I would be curious to know if you see similar delays with those OMZ turned on with other P9k themes that also invoke ZSH's VCS_INFO?

@bhilburn Those hooks are actually ours. We enhance VCS_INFO here to get the infos we need.
@Erowlin Could you just remove git-untracked from the list of POWERLEVEL9K_VCS_GIT_HOOKS hooks and post the performance difference here? I suspect this to be the biggest bottleneck, because we call git status here, which is really slow especially if the repo is big, or you have a lot of untracked files.
Btw. I just made some changes to the VCS code in #1045 that speeds the VCS segment a bit up. Unfortunately it was not possible to get rid of the biggest painpoints here..

@dritter @phcerdan @Erowlin - OH! Man, sorry, I don't know what I was thinking, hah. I saw that list of vcs plugins and just assumed it was OMZ for some reason. I need to pour more coffee.
Anyway, the experiment @dritter just suggested is a good one.

Wow, really? It had that much of a difference?

Yup.

Could you just remove git-untracked

Sure, will try that tomorrow.
Do you have any way to benchmark the TTY? So we have some actual data instead of just a feeling :). (Really bad at bash stuff, and unsure we can actually bench the TTY display?)

@Erowlin You could do
time ( repeat 10; do; prompt_vcs "left" 1 false > /dev/null; done;)

That renders the VCS segement 10 times.
Btw. I just opened #1046 which hopefully brings relief to this topic. Could you measure the current speed and the one of the PR? That would be super helpful.
And could you quantify your repo? Like how many untracked files you got, how many submodules? Any deep nesting of submodules?

Sorry for the delay, I'm back from vacations 🍹. I will experiment today and let you know :).

Here are my experimentations:

As you can see, I've been removing one by one the git modules and did the benchmark each time. The thing that seems to have the most impact is git stash.
Let me know if I can be of any help.
The repository is huge: More than 300 MB, and some 6200 tracked files in the repository.

Thanks for that numbers @Erowlin ! So the biggest impacts here are checking for untracked files and stashes.
Btw. just to be sure: I recently made some speed improvements to the VCS segment - especially when checking untracked files - You checked 5200a1ba2274e5383f2207caecc5d8b3c0e9c242 right? And how does this compare to the version before I did the speed improvements (next@ fa4e336dcdcea8764ac76179a4d431e421f15836) ?
And I prepared a PR with better performance when checking stashes. Can you give #1058 a shot?

@dritter I wasn't actually, just checked out, I will redo the benchmarks :). Just by feelings, it seems to be way faster. Let me run some benchmarks :)

Looks like vcs-detect-changes is the bottleneck

@onaforeignshore I've updated the screenshots to use the big repository instead of powerlevel 9K.
Very weird: The changes to the P9K_VCS_GIT_HOOKS seems to be ignored, as all the timing are similar. Any idea?

All timings are similar except for vcs-detect-changes

Last commit on master in powerlevel9k repository:

78df520 (HEAD -> master, origin/master, origin/HEAD) Merge pull request #1055 from dritter/speedup_vcs_master2

(Nothing)

Git stash is actually a bottleneck here.
With git-stash : 1.71s (user)
Without git-stash: 1.04s (user)

True

Thanks @Erowlin . Btw. 1.76 is system. User is 1.50s.
So you are down from 1.50 secs (old master) to 1.35 (78df520772135b7924d6fc84f2bdbde0f1c650b2).
Could you try #1058 as well? There I optimised git stash.

I just merged #1058 into next. Didn't want to wait longer as this contained a Bugfix..
@Erowlin could you update and redo the tests?

I am experiencing slow prompt reload times when I am in a git repository. Is there any work still being done on this?

@anuj-modi well, you will never reach the same prompt reload times as with zsh, because of a lot additional checks for stashes, etc... powerlevel9k staff can just work on making it more efficient. (in before: writing backend in C, rust oder golang :D )

I've come to realize that git information is too much work to be done in between prompt redraws, it's far too dependent on disk read or access time that it's inconsistent and sometimes (like in your cases) awfully slow.
I think the only true solution is to have it async or have the info made available in a different way. Personally I've had success moving everything heavy (requiring disk, network, binary calls, etc) into a worker using zsh-async.
You can see it's a common theme for development:
https://github.com/bhilburn/powerlevel9k/pull/344
https://github.com/bhilburn/powerlevel9k/issues/504
https://github.com/bhilburn/powerlevel9k/issues/331
I've gotten zsh-async prompt segment generation working, but I don't believe there's much hope for getting it to work on Windows such as Msys or MinGW. ( https://github.com/mafredri/zsh-async/issues/26 )
I don't know if Powerlevel9k intends to support that or not... (I'm not an active dev here - I just pop in once in a while), but I will answer any questions about how I got zsh-async working.

I don't know if Powerlevel9k intends to support that or not... (I'm not an active dev here - I just pop in once in a while), but I will answer any questions about how I got zsh-async working.

Yes, we would love to have async capabilities in P9K. In the past we tried to change the whole prompt into async rendering, but I am not sure if this is a good idea for every segment..
Regarding Windows, we could try to detected that and use process substitution combined with a callback handler to work around this as agkozak/agkozak-zsh-prompt does.
@anuj-modi Same questionnaire for you:
On which version of P9K are you? Was the prompt faster before you updated P9K?  Could you quantify "slow" (time ( repeat 10; do; prompt_vcs "left" 1 false > /dev/null; done;))? Do you use a lot of git submodules? Do you have a lot of untracked files?

In my current env:
P9k version: dcd7718
Repo size:
> git-sizer
Processing blobs: 4126
Processing trees: 2821
Processing commits: 990
Matching commits to trees: 990
Processing annotated tags: 25
Processing references: 99
| Name                         | Value     | Level of concern               |
| ---------------------------- | --------- | ------------------------------ |
| Biggest checkouts            |           |                                |
| * Maximum path depth     [1] |    10     | *                              |
| * Maximum path length    [1] |   109 B   | *                              |

[1]  767cb1ccd9f0a077062a9d0931c26744ab86bb0d (ce7882b16282ce38e8d219cb79946b3599416316^{tree})

"time": 0.36s user 0.31s system 103% cpu 0.644 total

If anyone is using the master (stable) version of Powerlevel9k and seeing slow prompt rendering, give https://github.com/bhilburn/powerlevel9k/issues/1170#issuecomment-467977064 a try. There are instructions at the end of the comment for how to try it in your current shell without any permanent changes. Just copy-paste the command and see if your prompt becomes more responsive.

I think the only true solution is to have it async or have the info made available in a different way. Personally I've had success moving everything heavy (requiring disk, network, binary calls, etc) into a worker using zsh-async.

Do you have any resources for how to do this? I'd love to try it on WSL. :)

@mcfiredrill there is already #1176 for that. It is based on the next branch, so it might be quite different, if you are coming from master. At the moment it is in beta, so don't expect everything to work. Besides migrating your config to the new format, you have to do two things:

Install the git submodules, so that zsh-async gets installed at the right location (not yet configurable).
Flag the segment you want as async, by suffixing it with ::async.

And, if you are on next and don't want to try #1176 , you could get rid of the vcs segment and replace it with gitstatus. That segment makes way less IO work, and is deeply optimised for performance. As the name suggests, that works for git only.

With the latest improvements in gitstatus performance there is no practical difference between sync and async mode but only if you are using Linux (and maybe MacOS and BSD; I haven't benchmarked them in a while).  WSL masquerades as Linux, so it triggers linux-specific code path in gitstatusd. This code path is optimized to the brim based on the timing of system calls in Linux kernel. WSL has the same system calls but with very different performance characteristics (obviously, because it doesn't have Linux kernel). So when I booted Windows yesterday and fired up WSL, I was appalled to realize gitstatusd is now as slow as plain git status. Ironic, given that I started hacking on zsh and git because I couldn't stand how slow things were on WSL. Oh well.
This means that as of right now there is no fast ZSH theme for WSL. There are only tolerably slow and kill-me-now slow. And you absolutely have to use an async git prompt to maintain semblance of sanity. The most popular theme with async git prompt is definitely Pure. It's the one that has pioneered async workers and it's truly a marvel to study. The most practical theme at this point is IMO Powerlevel10k, but I'm obviously biased.

With the latest improvements in gitstatus performance there is no practical difference between sync and async mode but only if you are using Linux (and maybe MacOS and BSD; I haven't benchmarked them in a while).  WSL masquerades as Linux, so it triggers linux-specific code path in gitstatusd. This code path is optimized to the brim based on the timing of system calls in Linux kernel. WSL has the same system calls but with very different performance characteristics (obviously, because it doesn't have Linux kernel). So when I booted Windows yesterday and fired up WSL, I was appalled to realize gitstatusd is now as slow as plain git status. Ironic, given that I started hacking on zsh and git because I couldn't stand how slow things were on WSL. Oh well.
This means that as of right now there is no fast ZSH theme for WSL. There are only tolerably slow and kill-me-now slow. And you absolutely have to use an async git prompt to maintain semblance of sanity. The most popular theme with async git prompt is definitely Pure. It's the one that has pioneered async workers and it's truly a marvel to study. The most practical theme at this point is IMO Powerlevel10k, but I'm obviously biased.

OMG. I wasn't aware of PowerLevel10K, thank you for your work. Just switched to it, 💥 , lightning fast in a sec.

@Erowlin Are you trying to get me banned here? Jesus...

I guess I'm lucky that I never have to deal with WSL, so I have no idea if my zsh-async stuff works there at all or not.
I wonder if it's possible to get the same zsh-async API on WSL without using zpty? (Which is still the root cause, right?)
The pty issue seems to have been closed though: https://github.com/Microsoft/WSL/issues/323 (I don't own Windows so I can't test it...)

@robobenklein zpty works fine on WSL. In fact almost all Linux software just works.
There are three sources of prompt slowness on WSL. The first is that some people insist on using ridiculously slow terminal emulators. Stuff like ConEmu or Hyper. These terminals have typing latency in the order of tens of milliseconds when your screen is full of text. Absolutely hideous. The only terminal with decent performance on Windows is Command Prompt -- the default one. It's ugly as sin and has no configuration options to speak of but it's the only thing you can use without having an urge to murder someone.
The second reason is that forking has 10x the cost it has on Linux. You know how you can make your prompt really slow if you use stuff like $(echo | grep | wc) in it? 10 times so on WSL.
The first two reasons don't affect me personally. My terminal is Command Prompt, and Powerlevel10k has no forks in the generic code or the prompt segments I use. This brings us to the third reason -- git is incredibly slow. Git makes a lot of stat() calls, which are cheap on Linux but very expensive on WSL (some people say it's IO but it isn't; this is all CPU in kernel code). They are expensive on WSL because rootfs -- the filesystem WSL uses -- is built on NTFS, and NTFS has all those advanced features no one cares about that make stat() slow. So it's not really the fault of WSL. If you install "Git for Windows", it'll be slow too. Or you can mount an NTFS partition on Linux and enjoy the slowness without owning a copy of Windows. How convenient!
It is possible to make git (or gitstatusd) faster on Windows but this requires dedicated effort and decent setup with a low-level profiler that doesn't lie too much. The set of people who can do it is rather small. If you intersect it with the people who care, it becomes empty.

P.S.
You can totally do async without zpty. Powerlevel10k has async git prompt without zpty. It's faster this way.

In fact almost all Linux software just works.

If you don't want to use some network features or gpu or usb...

@Erowlin Are you trying to get me banned here? Jesus...

I am sure people in here are not censoring nor dictators 😄.

I am on a issue-cleaning spree. This issue hasn't had motion in quite some time, and so I am closing it out due to inactivity. If anyone would like to re-open it because they feel it is un-resolved and is something they care about, please feel free to re-raise the discussion!


Create a landing page for FDS

FDS should have a landing page with https://dagshub.com theme similar to any typical documentation site (eg: gitless)

http://fastds.io


Initial upload

The contains the template changes, changes from sphinx-bootstrap-theme to jupyter-sphinx-theme, and a few other tweaks.  It's missing some essential content from the ipywidgets conf.py which will take a little more planning to move over correctly.  @willingc

Thanks!!! @jdfreder


Incomplete instructions to install io tracer and octf on brand new RHEL 7.6

started with brand new RHEL 7.6 buld (server with gui), system registered with RHEL
download latest GIT for standalone tracer
following the README.md, I ran the setup dependencies.sh for standalone iotracer (log attached), failure
downloaded latest GIT for octf, ran the setup dependencies.sh (log attached)
I am unable to build the tools.
Are there different readmes?
error-octf.log
error-iotrace.log
error-octf.log
error-iotrace.log

As for standalone-linux-io-tracer:  we have provided a fix in #102 . Please update repository to fix this.
As for OCTF: It seems to be a particular machine's environment problem - proxy address seems to be wrong. Please try to set proxies with 'export http(s)_proxy="address:port"'.
Also please use newest OCTF, as we have recently updated the setup script.
The only READMEs are:

standalone-linux-io-tracer README
open-cas-telemetry-framework [README](https://github.com/Open-CAS/open-cas-telemetry-framework/blob/master/README.md

For installing iotrace the first one is sufficent.

Tomasz
I did set the proxies using export and it appeared all of the dependencies were installed
I captured the errors from both installs
Regards
Jeff

On Oct 28, 2019, at 2:38 AM, Tomasz Rybicki<EMAIL_ADDRESS>wrote:
As for standalone-linux-io-tracer: we have provided a fix in #102 . Please update repository to fix this.
As for OCTF: It seems to be a particular machine's environment problem - proxy address seems to be wrong. Please try to set proxies with 'export http(s)_proxy="address:port"'.
Also please use newest OCTF, as we have recently updated the setup script.
The only READMEs are:
standalone-linux-io-tracer README
open-cas-telemetry-framework [README](https://github.com/Open-CAS/open-cas-telemetry-framework/blob/master/README.md
For installing iotrace the first one is sufficent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

The instructions are still not working and not clear.
Here is what I tried

fresh rhel 7.6 installation, system registered, proxies set
pulled octf and standalone zip files
In octf folder, ran the ./setup-dependencies .. it completed no errors
moved to standalone folder, ran the ./setup-dependencies command
error.txt

Can I get some clean instructions so we can simplify the process?


Make offences benchmark runnable

The pallet_offences benchmarks currently panic. Fixes #10027 until #10781 is done.
The outputs of the benchmarks are currently unused. I will call the benchbot and revert to make sure that they do not panic anymore.

/bench_bot_is_the_best! runtime pallet pallet_offences

bot merge

Thanks, guys!


Fix stdin on run_interop_tests

Fixes #4164

Aha, nice catch, thanks!
LGTM but restarted interop tests to make sure everything still works alright.


[feature] bitcoin price

would be nice to have the current bitcoin price in the prompt 🚀💸

Thanks for the suggestion! This definitely must be a custom section.


PRs are failing checks - possibly because of secrets not available in the action or some other reason. Need spike to investigate and fix.

PR's do not have access to secrets - and there were some items in the PR check that really didn't need to be there.


Downloading

Issue Type: Feature Request
Downloading any extension in vs code like paython language server in vs code . I am not stop/cancel it
Extension version: 2020.8.103604
VS Code version: Code 1.48.1 (3dd905126b34dcd4de81fa624eb3a8cbe7485f13, 2020-08-19T17:12:13.244Z)
OS version: Windows_NT x64 10.0.19041

If you're talking about downloading MPLS, we are working towards replacing it with Pylance, so this shouldn't be a concern once that switch happens (hopefully soon). If you're talking about downloading extensions in general, then unfortunately that is a general VS Code issue and should be filed against https://github.com/microsoft/vscode.


update timefarm

Thanks for this big project
I have a question..
Can timefarm bot solve the new quizzes (new update in timefarm bot)?

Hi,
Thanks for the suggestion. The bot performs best with repetitive and predictable sequences of mouse movements and clicks. It can read and respond to written information in the game, such as comparing the cost of making an upgrade to the player's available balance. However, for this specific task, it's probably not ideally suited.
Today's question was:

When did LaborX, the blockchain-based freelancer platform, officially launch?

I had to find the answer via an internet search, which returned the date in the US format (11/15/2018). Then, I needed to convert it to the UK format (15/11/2018) to enter it into the Timefarm bot.
While it might be possible to get the bot to perform internet searches, interpret the results, and enter the date, the limited benefit doesn't justify the effort required to implement this functionality. So, for now, we'll leave answering the question to the user. 😊


move message logic up to module

Wow, subtle difference on this one. These specs were passing locally, but because of the time zone difference it changes the regex. Locally, it has -0800, which is just characters in a regex, but on TravisCI it has +0000, where the + is a special character.

Fixed!

renamed to fill_in_message


Restore should start the VM if VMI was poweroff voluntarily

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
Restoring snapshot to the (existing) VM, it will stuck in Restoring state if the VM was stopped by shell command
Solution:
Restore should start the VM if VMI was power off voluntarily
Related Issue:
#4307
Test plan:

Install Harvester with any nodes
Create an Image for VM creation
Create VM vm1 and write some data
Take snapshot vm1-s for vm1
Stop vm1 by executing command sudo shutdown now
Restore snapshot vm1-s to existing

@mergifyio backport v1.2


Migrate Twitch badges to Helix

Pull request checklist:
Closes #4492

[x]  CHANGELOG.md was updated, if applicable

Description
The legacy badges endpoint will be closed for the first time on May 4 and permanently on June 1, so it is necessary to migrate this endpoint to the Helix API.
Official announcement: https://discuss.dev.twitch.tv/t/legacy-badges-endpoint-shutdown-details-and-timeline-june-2023/44621

Did you forget to commit HelixGlobalBadges/HelixChannelBadges ?

Be sure to define virtual functions in IHelix for getGlobalBadges/getChannelBadges

Be sure to define virtual functions in IHelix for getGlobalBadges/getChannelBadges

That's right, I was missing the definition of virtual variables in IHelix.  Recently added in cd0c55d

https://twitter.com/TwitchDev/status/1647017279123513344
Looks like the endpoint has been updated with some more info, not sure if anything in this PR needs to change. Perhaps the new info should parsed into our badge structs? Unclear if we would even use it.

Looks like the endpoint has been updated with some more info, not sure if anything in this PR needs to change. Perhaps the new info should parsed into our badge structs? Unclear if we would even use it.

I believe that at the time of starting this PR those data were already available since they were released together with the official announcement. I guess it was only now that it was made public on Twitter 🤔

I believe that at the time of starting this PR those data were already available since they were released together with the official announcement. I guess it was only now that it was made public on Twitter 🤔

This is correct, @iProdigy confirmed all the data available from the legacy endpoint was also available in the Helix response the day after the deprecation announcement.


WriteSourceRepoProperties fails with extra directories in .git/modules/src

First seen after we starting ignore source-build-reference-packages for uberclone.  Old directory still existed on dev machines but since it's ignored by Darc it never gets new commits fetched.  WriteSourceRepoProperties properly ignores missing directories but assumes all present directories have been fetched.  CI/new clones/completely clean builds unaffected.

[Scrub] Recommend closing - lot of effort for minimal gain and problem will go away with VMR.


Add change of (i18n) language on click on buttons (e.g. small buttons on header or footer)

Completed with commit


fix(sec): upgrade future to 0.18.3

What happened？
There are 1 security vulnerabilities found in future 0.18.2

CVE-2022-40899

What did I do？
Upgrade future from 0.18.2 to 0.18.3 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
How can we automate the detection of these types of issues?
By using the GitHub Actions configurations provided by murphysec, we can conduct automatic code security checks in our CI pipeline.
The specification of the pull request
PR Specification from OSCS

Updating, thank you!


move multicast tests to truth

Please see our contributing guidelines (contributing.md) primarily make sure to sign our cla as we cannot accept code externally without a signed cla
https://opensource.dropbox.com/cla/

issue ##21

this pr is contained within #32

i can abort this, didn't realize it was done, i just thought it was missed.


nginx configuration file

the nginx configuration file is inside the dashboard image. Changing the configuration requires an image rebuild now. Maybe it's possible to get the nginx config from outside?

duplicate


Refactor regression framework

Work on #1680

Codecov Report

Merging #1690 (c36dc62) into master (fbdd008) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head c36dc62 differs from pull request most recent head 62bf50d. Consider uploading reports for the commit 62bf50d to get more accurate results

@@            Coverage Diff            @@
##             master    #1690   +/-   ##
=========================================
  Coverage     57.31%   57.31%
  Complexity     1032     1032
=========================================
  Files           173      173
  Lines          9721     9721
  Branches       1344     1344
=========================================
  Hits           5572     5572
  Misses         3675     3675
  Partials        474      474

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbdd008...62bf50d. Read the comment docs.

@MXueguang this is ready for review. It's a huge patch, but I've verified regressions, so a quick sanity check will be sufficient, I think.


WorldEnvironment complains about missing camera when one is present in the scene

Godot version:
master / 59710880cd21d79ae1329f04eb35ea48e646acb3
OS/device including version:
Manjaro KDE 17.1
Issue description:
As shown in the attached screenshot, a warning icon is displayed beside a WorldEnvironment node, complaining about missing camera node, but there is a camera node presents in the same scene named 'Player Camera':

The problem occurred when I updated Godot to 59710880cd21d79ae1329f04eb35ea48e646acb3 from dad47d8876de45132226985dbbd079e060f6facc, and it doesn't seem to cause any real trouble other than displaying the warning message.

I can reproduce this issue in Godot Sponza on the same commit mentioned by OP.

For the reference, the issue was caused by @poke1024's #17555 (but #18376 shows that it might be simply exposing an underlying issue).

I fixed this, just removed the check as it was unnecesary