cuelang.org: CI workflow sometimes fails while handling tip

What page were you looking at?
https://cuelang.org/
What version of the site were you looking at?
https://github.com/cue-lang/cuelang.org/commit/f414e389cb4880b575e1c7754a32166017fe3ce2
Problem
The tip.cuelang.org: Deploy the site step failed recently, after two cue-lang/cue CLs were submitted in rapid succession. The failing step's output is as follows, emitted by the  _scripts/tipDeploy.bash script:
add 'content/docs/concept/how-cue-works-with-json/en.md'
[ ... 221 lines elided ... ]
add 'content/examples/cue/preprocessor/gen_cache.cue'
[master c97d0927] tip.cuelang.org: cache files for 3a55072f
 223 files changed, 663 insertions(+), 696 deletions(-)
Pushing to https://github.com/cue-lang/cuelang.org
POST git-receive-pack (167938 bytes)
To https://github.com/cue-lang/cuelang.org
 ! [remote rejected]   HEAD -> tip (cannot lock ref 'refs/heads/tip': is at 650e09d1866c95b4cab162c7fc939906ab09918f but expected f9e86c07e3c7343ad467a8a067d6743ad0ff0ed8)
error: failed to push some refs to 'https://github.com/cue-lang/cuelang.org'

It's believed that both cue-lang/cue CLs being submitted triggered the cue-lang/cuelang.org trybot on master twice, and by the time one of them reached the git-push-to-tip stage, the other had already pushed to tip- causing some kind of remote GitHub failure.
It's not clear why this caused a problem, given that the script uses git push --force. It's not even certain that this was the proximate cause of the failure, or that the failing workflow was the second one to reach that point in the trybot workflow.

One possible fix we've discussed would also solve the lack of sequencing inherent in our current tip handling:

move the tip-related steps into a separate workflow
trigger that workflow on pushes to the master branch of cue-lang/cue and cue-lang/cuelang.org
configure that workflow to have a concurrency of 1 to (attempt to) enforce sequencing.

We could also set cancel-in-progress: true on the workflow to not waste processing effort, as the only state that's important is the pass/fail status of the current tip of master of both repos combined.

Believed fixed by https://cuelang.org/cl/1204960. /cc @myitcv

Yes, agreed.


Improve example schemas in tests to make examples consistent with spec

identified in https://github.com/asyncapi/avro-schema-parser/pull/96#discussion_r749167969
Some of the schemas in the tests folder have int data types but string examples. This doesn't break anything, but it would be good to tidy this up and update examples so that they are correctly typed.

improved this bit with https://github.com/asyncapi/avro-schema-parser/pull/99

I think this was fixed in #99 so happy to close this now


What about a Hugging Face Spaces demo so we can test this?

Hi Gertie01, we don't currently provide an HF Spaces demo. There is a Google Colab notebook available for testing here.


Python API fixes for AlignmentRecordRDD

Coverage decreased (-0.4%) to 82.957% when pulling 6f968c27fcdce2c2c04f68b7600e2d3aed0d8b42 on akmorrow13:python into b46b58342190de2c5d5a36e5c1c63b8f57778357 on bigdatagenomics:master.

Coverage decreased (-0.4%) to 82.957% when pulling 6f968c27fcdce2c2c04f68b7600e2d3aed0d8b42 on akmorrow13:python into b46b58342190de2c5d5a36e5c1c63b8f57778357 on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2321/
Test PASSed.

Merged! Thanks @akmorrow13!


Extensions resources state sync controller

What this PR does / why we need it:
Adds controller to the gardenlet responsible of syncing the extensions' states into the Shoot's ShootState.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

An Extension Sync Controller used for replicating the Gardener extensions states, added to Gardenlet.

/assign


Add broot

[X] I have checked that this app does not already have a pending request and has not previously been declined.
App Name: broot
Download URL: https://packages.azlux.fr/debian/pool/main/b/broot/
Website URL: https://dystroy.org/broot/
App Summary: A better way to navigate directories

Upstream does not publish .deb packages.


Fix settings hid null issue

 Code Climate has analyzed this pull request.

Travis is having issues as of this comment.  Merging anyway.


[CARBONDATA-2925]Wrong data displayed for spark file format if carbon…

Issue:- if Carbon file has multiple  blocklet ,in select query wrong data displayed.
Root Cause :- it is showing records of only for 1st  Blocklet and other blocklet in that block is getting skipped. This is because default blocklet is 0 and CarbonFileformat create blockletInfo with default configuration (not changed blockletID).
Solution :- Set default blockletID to -1  so that all blocklets are considered.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?
NA

[ ] Any backward compatibility impacted?
NA

[ ] Document update required?
NA

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
Manually and Testcase also added

Is it a performance related change? Please attach the performance test report.

Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/207/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/210/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.3/8449/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/230/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/399/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/234/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.3/8473/

LGTM

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/260/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/429/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.3/8499/


Fail the build when there are lint warnings

Both eslint and sass-lint now take a --max-warnings flag, so use that
to cause the build to fail if there are any warnings.
Fixes #56

👍


feature: alert event refactor

feature:

add more infos to analyzer-alert metric.
add new metric to statistic the alert-notify processing jobs.
add more infos to support the new alert-event.

/cherry-pick release/1.6-alpha.3


Use LSQ to determine UPDATE Queries

The SPARQLProtocolWorker should be able to execute UPDATE queries seperately on the given updateEndpoint. For that it needs to know if a query that it's about to execute is an UPDATE query.

Linked to this issue: #182


fix word2vec

参考Paddle 1.8 与 Paddle 2.0 API映射表修复因为API升级参数变化导致word2vec benchmark无法正常运行的问题

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Just can’t turn on audio on iphone

Great project indeed. Streaming successful with video and audio on a pc.  But I just wouldn’t turn on sound on iphone.  I know there is unlock function, I tried but no success.  If there is an example code for ios audio support it will be great.

same issue here. audio plays just fine on Android devices though (tested on Samsung Galaxy S6 with Android 7.0)

Finally, works like a charm. Thank you :)

so cool,but why?,I see you code,but I don not know why it work.

very good

player.audioOut.unlock make video playback speed up😂

var player = new JSMpeg.Player(url)
function onUnlocked () {
	// console.log('unlock video audio: ' + url)
	player.volume = 1
	document.removeEventListener('touchstart', onTouchStart)
}
function onTouchStart () {
	player.audioOut.unlock(onUnlocked)
	document.removeEventListener('touchstart', onTouchStart)
}
// try to unlock immediately
player.audioOut.unlock(onUnlocked)
// try to unlock by touchstart event
document.addEventListener('touchstart', onTouchStart, false)

above code is extracted from my code and work great on both Android and iOS.

player.audioOut.unlock make video playback speed up😂


Selector objects shared across instances and class

When check_on_set is set to False, objects is updated in place and the change is seen at both the instance and class level.

import param

class P(param.Parameterized):
    s = param.Selector(objects=[1, 2], check_on_set=False)

p = P()

p.s = 3
p.param.s.objects

P.param.s.objects

P.s = 4
P.param.s.objects

p.param.s.objects

While the original post focuses on check_on_set, it's just an outcome of the _objects attribute (objects being now a property using `_objects) being shared across instances and classes:
import param

class P(param.Parameterized):
    s = param.Selector(objects=[1, 2])

p1 = P()
p2 = P()

assert p1.param.s._objects is p2.param.s._objects is P.param.s._objects

I was a bit surprised by that when I started to think about per_instance being True by default for Selectors. Except that the Parameter copy each instance holds is merely a shallow copy of the class Parameter, this is by design (https://github.com/holoviz/param/pull/306), and it explains they all just hold a reference to the same list/dict.

I suggest we push this to post Param 2.0 given the breadth of implications "fixing" that could have. cc @jbednar

Seems like you're suggesting the same approach as I just proposed over in #793, i.e. shallow copying Parameter slots, which I think can be done in general (not just for Selectors) unless Selectors truly are the only Parameters with mutable slot values.  I think we should at least try that to see if it raise any unexpected problems, because this is a subtle change to the semantics that I think will be a bugfix, but which is one to make in 2.0 if possible if it has implications.

I started to look into that and had a hackish implementation I ran across Panel's test suite. Ignoring some horrible failures that might be due to the hackish implementation, I found one failure that is relevant to that issue as it's caused by a test that assumed objects could be updated on a class Parameter in order to affect already created instances (comment is mine):
def test_switch_param_subobject(document, comm):
    class Test(param.Parameterized):
        a = param.ObjectSelector()

    o1 = Test(name='Subobject 1')
    o2 = Test(name='Subobject 2')
    # class Parameter 'a' modified and expected to affect the instance Parameter 'a' on o1 and o2
    Test.param['a'].objects = [o1, o2, 3]
    test = Test(a=o1, name='Nested')
    test_pane = Param(test)
    model = test_pane.get_root(document, comm=comm)

Preview:

My question to @jbednar and @philippjfr, is Panel leveraging a Param bug or a Param feature in this test?

I believe https://github.com/holoviz/param/pull/826 addresses the issues above:
import param

class P(param.Parameterized):
    s = param.Selector(objects=[1, 2], check_on_set=False)

p = P()

p.s = 3
print(P.param.s.objects, p.param.s.objects)
# [1, 2] [1, 2, 3]

P.s = 4
print(P.param.s.objects, p.param.s.objects)
# [1, 2, 4] [1, 2, 3]

(i.e., the class and instance objects lists are now independent)
class Test(param.Parameterized):
    a = param.ObjectSelector()

o1 = Test(name='Subobject 1')
o2 = Test(name='Subobject 2')
# class Parameter 'a' modified and expected to affect the instance Parameter 'a' on o1 and o2
Test.param['a'].objects = [o1, o2, 3]
test = Test(a=o1, name='Nested')

print(o1.param.a.objects)
# [Test(a=None, name='Subobject 1'), Test(a=None, name='Subobject 2'), 3]
print(o2.param.a.objects)
# [Test(a=None, name='Subobject 1'), Test(a=None, name='Subobject 2'), 3]
print(test.param.a.objects)
# [Test(a=None, name='Subobject 1'), Test(a=None, name='Subobject 2'), 3]

(I.e., changes to objects at the class level still apply to the instances, because per_instance copying is lazy and a has not been changed on the instances)
So I think #826 fixes #746.


WIP: Convert to Rust

Having fun messing around with https://github.com/immunant/c2rust

Need to incorporate the following PRs:

https://github.com/Limit-Theory-Redux/ltheory/pull/39
https://github.com/Limit-Theory-Redux/ltheory/pull/43
https://github.com/Limit-Theory-Redux/ltheory/pull/58


Please add this note to the configuration sections

Hello,
I literally spend a whole day trying to get this to work, I finally solved it. I don't want others to waste their time with it also. I wanted to do a pull request to add this line in the README.md, but since I'm a noob to JS frameworks and Github, I don't know how to do that.
Can someone please add this to the configurations sections?

Depending on how the tsconfig.json is configured, the location of modelPaths may be different. If the outDir location was defined in the tsconfig.json, make sure that modelPaths is pointed somewhere in that location. For example, if the outDir was set to ./dist, the modelPaths should be set to [ ${appRoot}/dist/models ] , appRoot being the root of your application. Also, if you are using wildcards for the modelPaths, make note that the files will not have ts extensions, but rather js extensions, e.g. ${appRoot}/dist/**/*.model.js

Hey @rationalthinker1, thanks for sharing this with us. You could create a PR if you like. A new section in the README like Common pitfalls  would make sense. What do you think?


ca-on-ottawa.json - Not coming up on map - Incomplete coverage?

Hi,
http://data.openaddresses.io says the ca-on-ottawa source has incomplete coverage but when I look for my own address in the file it comes up, as well as other addresses. I'm not exactly sure how I could fix it so that it maps.. I've noticed the same thing for others like ca-on-toronto and ca-qc-montreal.
My end goal is to be able to search in OSMand+ by address instead of address range but it hasn't updated yet and it's been over 3 weeks.
Any ideas how to fix this?
Thanks,
Marc

Hey @MAL315
It looks like Ottawa address points are being rendered at openaddresses.io.  If you're talking about the extent map at data.openaddresses.io, it's required that 1 of 3 tags is present in the coverage object in order for the extent to be rendered.  See the requirements here which also has examples.
In terms of age of the data, the source data are not frequently recached and processed.  I would say 3 weeks is not terribly old as the source data are not expected to change that often.  @iandees might be able to say more.

1 - I guess US Census wouldn't work since it's in Canada.
2 - The ISO-3166-2 seems to be for countries and states but I'd like to get a city to map, can I still use ISO-3166-2? Something like: "ISO 3166": {"alpha2": "CA-ON", "state": "Ontario", "country": "Canada"} and it'll pick up the city under the coverage section?
3 - "Geometry with Polygon or MultiPolygon type unprojected" depends entirely on how the city/province is providing the mapping info (not something I can control - unless they provide different files)?
(https://github.com/openaddresses/openaddresses/blob/master/sources/ca-on-ottawa.json)
Thanks again,
Marc

@MAL315 Yeah, the system in place for rendering sources on that map is not really optimized for many non-US geographies.  I think that option #3 was meant to be a workaround because of that.
The GeoJSON doesn't necessarily have to be provided by the city. If you care that much, it shouldn't be too difficult to find shapefiles of these cities and convert to GeoJSON using ogr2ogr or even some desktop GIS programs.

I'm not too too worried about it but I was just wondering if that was affecting the data from coming up in OpenStreetMap. If it's purely just mapping at data.openaddresses.io (for visual appeal) then I'll let it go :) and I'll just wait for OSM to update eventually.
Thanks for your help.

@MAL315 Oh, now I'm confused.  Were you under the impression that Openaddresses data is being funneled into OSM?  I was wondering why you mentioned OSMand+. My understanding is that OA was created at least partially because there are license restrictions preventing importing many data into OSM.  There's not currently any relationship between OA and OSM, but it is possible that there could be a pathway for some of this data to make it into OSM in the future.  Hope that clears it up.

Hmm well maybe a year ago I had gone into the OSM irc channel and they said the best way to contribute address data (bulk) was through OA, oh well :P. Maybe some day I'll see it in there. It certainly would make sense.
On May 11, 2015 5:01:23 PM EDT, Brandon Knight<EMAIL_ADDRESS>wrote:

@MAL315 Oh, now I'm confused.  Were you under the impression that
Openaddresses data is being funneled into OSM?  I was wondering why you
mentioned OSMand+. My understanding is that OA was created at least
partially because there are license restrictions preventing importing
many data into OSM.  There's not currently any relationship between OA
and OSM, but it is possible that there could be a pathway for some of
this data to make it into OSM in the future.  Hope that clears it up.

Reply to this email directly or view it on GitHub:
https://github.com/openaddresses/openaddresses/issues/1003#issuecomment-101045488


Any way to obtain the Chart object without importing Chart.js?

Here is my code:
import { Component, OnInit } from '@angular/core';
import 'chartjs-plugin-streaming';
import { ActivatedRoute } from '../../../node_modules/@angular/router';

@Component({
  selector: 'app-resource-monitor',
  templateUrl: './resource-monitor.component.html',
  styleUrls: ['./resource-monitor.component.css']
})
export class ResourceMonitorComponent implements OnInit {

  datasets: any[] = [{
    data: [],
    label: 'line1'
  }, {
    data: [],
    label: 'line2'
  }];
  options: any = {
    scales: {
      xAxes: [{
        type: 'realtime'
      }]
    },
    plugins: {
      streaming: {
        onRefresh: function (chart: any) {
          chart.data.datasets.forEach(function (dataset: any) {
            dataset.data.push({
              x: Date.now(),
              y: Math.random()
            });
          });
        },
        duration: 20000,    // data in the past 20000 ms will be displayed
        refresh: 1000,      // onRefresh callback will be called every 1000 ms
        delay: 1000,        // delay of 1000 ms, so upcoming values are known before plotting a line
        frameRate: 30,      // chart is drawn 30 times every second
        pause: false,       // chart is not paused
      }
    },
    animation: {
      duration: 0                    // general animation time
    },
    hover: {
      animationDuration: 0           // duration of animations when hovering an item
    },
  };

  constructor(private route: ActivatedRoute) { }

  ngOnInit(): void {
    this.route.params.subscribe(params => {
      const id = params['id'];
    });
  }

  pause() {
    this.options.plugins.streaming.pause = !this.options.plugins.streaming.pause;
  }
}

I want to start/pause the chart.
It seems like I need to update the chart after setting this.options.plugins.streaming.pause as true.
So I wonder if there is any way to obtain the chart object and call chart.update().
Thanks a lot!!!

Did you try this?
https://stackoverflow.com/questions/51078798/pause-horizontal-scrolling-in-chart-js-for-real-time-data

Yes, that's what I did. Thanks!


kits23 tutorial imaging.nii.gz file not found

I am running kits23 tutorial as it written in the manual page, however it couldn't find file kits23/dataset/imaging.nii.gz  since it doesn't exist in the orginal repository.
Where can I find these files?

Ok I haven't seen that there has to be an installation in kits23 repo.


Support GK Mutation Webhook External Provider

Implement a new endpoint for mutation of tag to digest

Design document: https://hackmd.io/@akashsinghal/HyC7y-2ws


add device id check when use hw wallet

What does this implement/fix? Explain your changes.
add device id check when use hw wallet
Does this close any currently open issues?
OneKeyHQ/TaskHub#747,
OneKeyHQ/TaskHub#773,
Pull request type

Put an x in the boxes that apply

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Where has this been tested?
local
Any other comments?
none

need rebase @liyanhrxy


How to setup and running

Hi guys
Before any thing i like to appreciate your work. it's cool, use OOP and good documentation.
I read couple time instruction and explore example
But i can not find a way to running your delicious library.
I have HTTPS domain (check bot with official telegram example, no problem with that)
I have some questions about setup and running.
Questions

What is next after 'require composer' and put set.php and hook.php?
I need run this url? What should I do?
https://api.telegram.org/bot<token>/setWebhook?url=https://mydomain.com/hook.php
How telegram communicate with your library?
Your script find automatically new custom command?

And at the end i ask you for put operational example with all features

Hi @devlifeX
Thanks for the kind words! 🙏

What is next after 'require composer' and put set.php and hook.php?

After composer has downloaded all the necessary components and you have put the set.php and hook.php in the root folder, go to answer 2.
(Be sure to insert your bot API key and name to both files, and the correct Webhook URL to set.php)

I need run this url? What should I do?
https://api.telegram.org/bot/setWebhook?url=https://mydomain.com/hook.php

Not quite. All you need to do now, is open https://mydomain.com/set.php in your browser. This should give you the message Webhook was set. That's it!
(To unset the Webhook, just get the unset.php example file and run that!)

How telegram communicate with your library?

This is where the magic of the Webhook happens. When your bot gets a message, Telegram sends an update to the hook.php file (defined in set.php), which then handles it.

Your script find automatically new custom command?

Yes, you just need to tell the library where the custom commands can be found.

And at the end i ask you for put operational example with all features

The bot already has a bunch of commands included. When you have it up and running, just send the /help command to see which ones are available.
Good luck and have fun! 👍

hey noplanman,
how to use this library?
when i took some example code on example folder and run it,
it is become error
"mydomain.com is currently unable to handle this request.
HTTP ERROR 500"

@frengkys Have you followed the readme exactly?
If yes, I need more info to find out what's going wrong.
When you directly call the URL to your https://example.com/hook.php file, do you get any output?

@frengkys i had issue with runing this library, but this library is OK, probably your server has problem like (php configuration issue, web server configuration issue or even HTTPS issue)
you can track your error and access log on your server (do not forget in this case check SSL log)
in my case i was missing install php-mbstring ( i explained it here)

hook.php is blank,
i think there is something wrong with my server configuration

In the catch block of your hook.php, uncomment (or add) the following line to output the error message:
} catch (Longman\TelegramBot\Exception\TelegramLogException $e) {
    echo $e;
}

Then try to figure out the problem or post the error here.

closing there


functionality: add ability to find the power (exponent)

Hello Henry, mind if I give this issue a try?

no issues from me - but, because the design of the calculator right now is already at full capacity (i'd like the equals sign to take up two buttons' worth of space), i haven't made a design decision on where to put the power button yet. happy for you to give it a go and i review.
in a previous iteration of this calculator, i removed the "backspace" button (users would just have to all clear if they typed something wrong) in favour of a exponent button, but i'm not sure if that's the best UX. Again, open to hearing your thoughts and discuss.
I'll assign this issue to you for the time being, but I may take it back on. Thanks!

Hmm I get your point, my design involves placing the power button adjacent to the equals sign, cutting it's size by half, but that may not be to your liking as you've said above. Let me think if there is a way to fit the exponent button somewhere.
Current design:

thanks for sharing that @Karthik-315 - I think, design-wise, better to have the equals sign as double the size of the remainder of the buttons. How do you feel about removing the +/- key used to toggle positive and negative numbers in the display, replacing that with the exponent, and then using the minus sign as a way to toggle plus/minus? Would that be overly complex?

We can give that a try, may be have the minus button to toggle positive and negative on long press and function normally (subtract) on click. What do you think?

We can give that a try, may be have the minus button to toggle positive and negative on long press and function normally (subtract) on click. What do you think?

i like it - let's see it in action!

Cool, let me send a PR.


masker handling

There are some inconsistencies in masker handling across estimator classes that I think we need to resolve. Currently, only some estimators set a .masker property (e.g., the IBMAEstimator hierarchy). I think this is problematic, as it requires various checks in different places (I would like to avoid things like hasattr(self, 'masker'). I see no reason why there shouldn't always be a .masker attribute in every estimator class, which can be left to None if the user wants to use the masker defined in the Dataset instance. Any objection to my setting it up this way?

I think that's reasonable to have for all Estimators.

Would this be solved by just making the IBMAEstimator base class into a general MetaEstimator base class? The steps in IBMAEstimator seem pretty straightforward, and only minor changes would need to happen in the CBMA estimators' __init__s.
https://github.com/neurostuff/NiMARE/blob/96bec086c862dd6f3fefbc38dce22e3b2d4dc528/nimare/meta/ibma.py#L25-L40


replace aws-sdk v2 with v3

v2 is approaching end-of-life, time to move on.

aws-sdk v2 is now pinned because upgrading it breaks aws-sdk-mock. Which breaks a whole lot of tests.

Resolved!


Document the release steps

Currently I run
pip_clean
python setup.py build sdist bdist_wheel
twine upload/*

Where pip_clean is a custom alias that removes all of the build files, *.pyc, etc. I'm not even sure if twine is still necessary with the new version of PyPI.

This has been added here:
https://github.com/michael-lazar/rtv/blob/master/RELEASE_CHECKLIST.md


Invisible events in week view

Hi,
The week view does not display all events when I have a multi-day event.
Under the purple event, we can see a cropped yellow event and there are more events that are not visible.
Thanks!

Noted
This should be fixed in next release
Feel free to reopen if it sill has issues

Looks better, but still one event is missing (a purple one).

Hmm
Can you copy your events array here to try it? Remove all fields, just keep the start and end dates

Sure, thanks!
{
  "events": [
    {
      "startDate": "2023-09-26T00:00:00.000Z",
      "endDate": "2023-09-26T00:00:00.000Z",
    },
    {
      "startDate": "2023-09-27T00:00:00.000Z",
      "endDate": "2023-09-27T00:00:00.000Z",
    },
    {
      "startDate": "2023-09-24T00:00:00.000Z",
      "endDate": "2023-09-24T00:00:00.000Z",
    },
    {
      "startDate": "2023-09-29T00:00:00.000Z",
      "endDate": "2023-09-29T00:00:00.000Z",
    },
    {
      "startDate": "2023-09-24T09:30:00.000Z",
      "endDate": "2023-09-24T16:00:00.000Z",
    },
    {
      "startDate": "2023-09-24T09:00:00.000Z",
      "endDate": "2023-09-24T16:00:00.000Z",
    },
    {
      "startDate": "2023-09-24T08:00:00.000Z",
      "endDate": "2023-09-28T16:30:00.000Z",
    },
    {
      "startDate": "2023-09-26T08:00:00.000Z",
      "endDate": "2023-09-26T16:30:00.000Z",
    },
    {
      "startDate": "2023-09-26T08:00:00.000Z",
      "endDate": "2023-09-26T16:30:00.000Z",
    },
    {
      "startDate": "2023-09-26T08:00:00.000Z",
      "endDate": "2023-09-26T16:30:00.000Z",
    }
  ]
}

In this list, there is only 1 event that is > 1 day.
I guess you have other events that has the allDay prop?
I still can't replicate the issue. Please share an example to replicate it here or in a code sandbox

Sure.
Please see it here:
https://codesandbox.io/s/react-scheduler-zjzxwn?file=/src/App.js


Implement a mechanism to save the sending emails to the database

Definition of done
There is a table in the database the administrators can check as an email log that contains all of the automatic and custom emails sent through the platform
Addition information
In addition to the common data attributes of the email,

The program id
The program state in which the email was sent
The time it was sent out

Should also be recorded

@Piumal1999 Hey, have you started working on this yet?

@Piumal1999 Hey, have you started working on this yet?

Not yet. Would you like to work on this?

@Piumal1999 Hey, have you started working on this yet?

Not yet. Would you like to work on this?

Yeah, I would like to give it a shot

@Piumal1999 Hey, have you started working on this yet?

Not yet. Would you like to work on this?

Yeah, I would like to give it a shot

Awesome


Downloadpath incorrect

The link to x86_64: http://goofy.zamia.org/repo-ai/centos/7/x86_64/ gives me an error.

where did you find that URL?

https://github.com/gooofy/zamia-ai direct under "Getting started"

ah, missed that one. Thanks for letting me know - I have removed the outdated installation instructions now.


Fix issues on solo server with Execute-As-User changes(#818)

Users are seeing issues with the execute.as.user change(#809) on solo server without installing plugins.
Actually there is no need to change user on solo server and jobs can be executed by Azkaban itself.
So I added the new plugin folder to put configuration file for solo server and set execute.as.user to false there. Verified locally on solo server and it should fix the issue (#818).

LGTM


Let's understand OSPRay

This came from a conversation with Eric. There are some things we don't really understand about OSPRay, so let's fill these knowledge gaps.

What are all of the options, and how can we control them through VTK?
Where is the image plane? It doesn't seem to be documented, so how do we determine the size of an object?
Other stuff...

The current OSPRay in VisIt is version 1.6.1. The latest release is 2.0.1. The alpha version of 2.0 was released back in September, and the stable version was released just under a month ago. There are a number of significant (and API breaking) changes in this release, which are documented here:
https://github.com/ospray/ospray/releases
A couple of the more interesting changes that I've seen are a generalized mesh structure, which is easier to work with, and better volume rendering support. It looks like there are also some bug fixes for both renderers.

Unstructured volumes have been added to the tutorials. I've added examples for both interfaces (C and CPP). In VisIt, it looks like the C interface was used, so I was planning on continuing to build off of that. Apparently, you can mix the two interfaces, though, so we can try using the CPP at some point if desired.

avtOSPRayCommon is where most of the meat of OSPRay lives within VisIt. This module defines multiple structs that inherit from common OSPRay classes. These structs serve as wrappers around their base OSPRay implementations and handle all of the OSPRay specific calls needed setup and run the rendering.

It looks like volumes are the only types of renderings that are explicitly handled through the OSPRay interface within VisIt. Other types of renderings are accomplished through vtk classes that handle all of the OSPRay conversion in the background.
Within visWinRendering, there is a vtkViewNodeFactory which appears to map standard mappers and actors to their OSPRay equivalents.

There does appear to be a vtk interface for volumes as well, so it's not clear why this wasn't used within VisIt. It's also not clear why unstructured volumes aren't supported in either the vtk interface or in VisIt's implementation. Both are using an older version of OSPRay, which might have something to do with this.

I've added a couple of demos using the older 1.x version of OSPRay, and I've also included some examples using vtk.

I've added some examples that show how to enable OSPRay within VTK. In general, the pattern looks like this:
// This is a very simple method that will make more sense later. It just returns an
//  OSPRay mapper "node".
vtkViewNode *
getPolyDataMapperNode(void)
{
    vtkOSPRayPolyDataMapperNode *ospMapperNode = vtkOSPRayPolyDataMapperNode::New();
    return ospMapperNode;
};

int main()
{
    // Set up all your usual suspects (camera, lights, renderer, etc.).
    // Let's assume that I created a vtkRenderer and named it renderer.

    // Now we set up our mapper. I'll just use the vtkPolyDataMapper.
    vtkPolyDataMapper *mapper = vtkPolyDataMapper::New();
    mapper->SetInputData(inputData);

    // This is where we tell VTK to use OSPRay. An OSPRay pass allows you to configure
    // what is used as a backend. This is how non-volume cases are handled within VisIt.
    vtkOSPRayPass *osprayPass = vtkOSPRayPass::New();
    vtkViewNodeFactory *factory = osprayPass->GetViewNodeFactory();
    // Here is the key piece. I'm telling VTK to replace vtkPolyDataMapper with the
    // mapper that's returned from getPolyDataMapperNode.
    factory->RegisterOverride("vtkPolyDataMapper",
        getPolyDataMapperNode);

    // Set the rendering pass to OSPRay.
    renderer->SetPass(osprayPass);

   // Continue with the usual rendering stuff.
};

The full examples can be found here: https://github.com/aowen87/ospray_demos/tree/master/version-1.x/vtk

As mentioned earlier, OSPRay is handled in two different ways within VisIt. Here is some more information about how this is split up.

General Case:
This is largely contained within the VisWinRendering class. In the constructor, you'll find a vtkViewNodeFactory being created, and several mappers and actors are being registered to use OSPRay. The vtkVisItViewNodeFactory is also at play here. This defines simple methods that return OSPRay mappers and actors in the way that my "getPolyDataMapperNode" does above.

Volume Case:
Like other volume rendering pathways in VisIt, there exist the expected classes—avtOSPRayRayTracer, avtOSPRaySamplePointExtractor, etc. Instead of interfacing with VTK like the general case, though, this path interfaces directly with OSPRay through various structs defined in avtOSPRayCommon. Within these structs, you'll find all of the necessary OSPRay objects being created, and all of the OSPRay settings being accessed. The actual image is generated when RenderPatch is called from avtOSPRayVoxelExtractor. This calls on OSPRay's internal framebuffer rendering method, the result of which is copied over into a float array that acts as the final image for a single patch.

Paths Forward
There are several pathways forward, all of which have their own pros, cons, and other considerations. Here is what comes to mind:

Maintain the current infrastructure

Pros:

Very little refactoring needed.

Cons:

Interfacing with both VTK and OSPray directly isn't very clean.
VTK is currently using OSPRay version 1.x. If/When they decide to upgrade to version 2.x, we would need to extensively refactor our OSPRay interfacing code, as this version has many interface breaking changes.

Other considerations:

Using VTK means that we are reliant on them for which version of OSPRay we can use.

Interface directly with OSPRay for all rendering

Pros:

Complete control over OSPRay version, features, etc.

Cons:

This may require an extensive refactoring of existing code. How extensive isn't clear at this moment.

Other considerations:

If we were to update to the latest OSPRay version, we would also need to extensively refactor the volume rendering code, as it is using version 1.6.

Interface with VTK for all rendering

Pros:

VTK handles all of the OSPRay interfacing work.
We should be able to access most (all?) of OSPRay's features through VTK.
OSPRay version updates would likely require less refactoring on our end.

Cons:

We would be dependent on VTK regarding OSPRay versions and how many features they expose.
This would require extensive refactoring of the OSPRay volume renderer.

I had a conversation with Eric about next steps, and here's what we came up with:
VTK has incorporated the latest OPSRay in their latest release (8.2.0). We'd like to leverage this, but we also would like to avoid updating all of VisIt to VTK 8.2 if possible, as there are likely some interface breaking changes. As a first step forward, we'd like to see if we can copy all of the new VTK/OSPRay wrappers from 8.2, add them to 8.0, and see if this compiles. If so, I'll experiment withe the OSPRay interface to make sure it works properly.

I've been looking at the VTK 8.2 release, and, as far as I can tell, it's still using OSPRay 1.x. We might be mistaken about the upgraded OSPRay being in 8.2.

I don’t think 8.2.0 is new enough. Take a look at the 9.0.0 release candidate.

I only see up to 8.2 on git/gitlab. Are you seeing a 9.0 somewhere?

I see there is mention of 9.0 rc on their downloads page, but it's currently empty, with a "coming soon" message. I thought master might have these changes, but I'm not seeing evidence of the new OSPRay there either. I'll look a little closer.

At the top of the page https://vtk.org/download/

Yeah, that link takes you to an empty download box. They don't yet have anything available.

Ok, I see the coming soon as well.

How about looking at the latest paraview (probably on master or a very recent RC)?

They have surprisingly few branches, which makes me think that they might have an unusual workflow. They do have a "release" branch, which I'm looking into now. At first glance, it appears to still be using ospray 1.x, but I'll keep looking.

Found it. It's actually not expected to be available until release 9.1, which should be sometime around June. Here is a link to more information, including an active merge request that seems to be treated like a development branch (I guess this is their workflow...):
https://discourse.vtk.org/t/ospray-2-0-vtk-9-0/2789

@brugger1 Since VTK won't have a fully functional version of OSPRay 2.0 wrapping until around June, should we put a hold on this?

It sounded like it was complete, perhaps it just won’t be released until June, since that’s when 9.1 will be released. It is probably useful to take a look at it. Can you file an issue asking if it is ready or what state it is in?

Sure thing.

Notes on VisIt's VTK/OSPray patches:

vtkOSPRayPass: we expose the vtkViewNodeFactory which contains the "RegisterOverride" method. This method tells VTK to replace specific objects in the pipeline with others. For instance, calling RegisterOverride("vtkAMRVolumeMapper", myAMRVolumeMapperCreator) will replace vtkAMRVolumeMapper with whatever mapper the function myAMRVolumeMapperCreator returns. By default, the vtkOSPRayViewNodeFactory already overrides several objects in VTK's pipeline. By exposing this factory, we are able to extend the overrides to include things like the axis actors and mesh plot mapper.
vtkOSPRayFollowerNode: this is an entirely new module that inherits from vtkOSPRayActorNode. It's meant to use OSPRay to act as a vtkFollower object.
vtkOSPRayViewNodeFactory: we've added in a call to RegisterOverride("vtkFollower", fol_maker) and defined fol_maker as a method returning an instance of vtkOSPRayActorNode. This just replaces the standard vtkFollower with our OSPRay version.
vtkOSPRayRendererNode: Setting the samples per pixel and ambient samples.
vtkOSPRayPolyDataMapperNode: we've added a vtkDataSetSurfaceFilter to extract geometry.

I've been able to successfully build and link against two version of vtk:

VTK 9.0 / master branch (uses OSPRay 1.8)
VTK 8.9 / WIP OSPRay branch (uses OSPRay 2.0)

VTK 9.0 works fine, and I'm able to run some simple examples.
The OSPRay branch is a different story, though. I can compile examples using this build, but the rendering screen is always blank (this is without using OSPRay). If I try to run an example using OSPRay, the rendering screen remains blank, and I see several OSPRay errors reported to the terminal.
I've posted a question to their discord site asking whether or not this volatility is expected on this branch.

@aowen87 If you want to investigate any of the issues you have seen I am building OSPRay 2.5 via superbuild and linking that against VTK master. There are some examples (TestRendererType) on the VTK side that I have been using to debug issues. That is understand if they are on the VisIt or VTK/OSPRay side.

Thanks @ARSanderson. That seems like a good approach here.

I am closing this issue as the new OSPRAY/VTK infrastructure is part of PR: https://github.com/visit-dav/visit/pull/17159/


Standardize routing keys. Distribute messages and detect types doesn't have to uncompress and deserialize.

Update libproto/src/protos/create_protobuf.sh: when run this script, lots traits or functions will be generated automatically.
Split libproto/src/lib.rs into 2 files. Most codes in autoimpl.rs will be generated after running libproto/src/protos/create_protobuf.sh. You do NOT need to update this file for most scenes.
Standardize routing keys (Use the format as PublisherSubModule.ClassType).
Set or get Origin and OperateType without uncompress and deserialize them (Use fixed-length format messages for communication). So, distribute messages and detect types doesn't have to uncompress and deserialize.
Update util/src/snappy.rs, compress / decompress use references, don't need ownership.
Update start_pubsub, change keys to Vec<K> where K: Into<String>.
Add a lot of unit tests.

Close for a while, because I want to update it.


Fix relaxations for FAENet and add EquiformerV2 model

Two new features were added here because they were simultaneously being tested:

Possibility to run relaxations on any FAENet S2EF model
EquiformerV2 model is now available from the original ocp repository, and it is also possible to run relaxations on the model

A continue_from_dir.sh script was added to the scripts folder to run these relaxations, here is how we can for example run relaxations on FAENet:
./scripts/continue_from_dir.sh $S2EF_JOBID run-relaxations faenet-is2re-all

Update the branch to add:

Ewald summation on three models: FAENet, SchNet and DimeNet++
Merge with parts of the untrained cano updates
Fine-tuning and transfer learning of models

Tests pass (except for qm7x which were not working on main branch as well) and canonicalization is also compatible with old frame_averaging arguments


UserGuide.adoc: Formatting

Coverage remained the same at 78.484% when pulling 0de90276e3a30f6af226f03ae440f662ba5de0a2 on iMarbles:docs-UG into 486c029f9957216d9e33c04770727507737b0a91 on CS2103-AY1819S1-W16-2:master.


Missing HTTP PATCH request method Zuul

when using Zuul for proxying http PATCH request to backend service, request's body content is not sent. i think there is a missing switch case for PATCH request:
case "PATCH":
			HttpPatch httpPatch = new HttpPatch(uri + getQueryString());
			httpRequest = httpPatch;
			httpPatch.setEntity(new InputStreamEntity(requestEntity, request
					.getContentLength()));
			break;
		default:
			httpRequest = new BasicHttpRequest(verb, uri + getQueryString());
			log.debug(uri + getQueryString());
		}

https://github.com/spring-cloud/spring-cloud-netflix/blob/master/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/route/SimpleHostRoutingFilter.java

Note: this will only work for SimpleHostRoutingFilter as RibbonRoutingFilter uses an enum from Ribbon :-(


hyprbars - Controlling the opacity?

First, I Love the different plug-ins make with Hyprland. hyprbars are a nice touch to my rice, however I was inquiring about the possibility to control the opacity? They tend to come off way too transparent for my rice, by default.
Any in-sight on how I could fix that, or help out with this anyhow?

the colors have an alpha value?


parser breaks when square brackets in default value

def foo(bar=[0, 0]):
    return bar

results in
    """[summary]

    [description]
    :param 0]: [description]
    :type 0]: [type]
    :param bar: [description], defaults to [0
    :type bar: list, optional
    :returns: [description]
    :rtype: {[type]}
    ""

the expected result is
    """[summary]

    [description]
    :param bar: [description], defaults to [0, 0]
    :type bar: list, optional
    :returns: [description]
    :rtype: {[type]}
    """

I agree, this should have been supported as it is something the language allows. Thanks for pointing it out.
As a side note for python, I recommend against using lists/dicts as default values in this manner as it can cause bugs if you ever mutate the variable.
>>> def test(a=[0]):
...   a.append(0)
...   print(a)
...
>>> test()
[0, 0]
>>> test()
[0, 0, 0]
>>> test()
[0, 0, 0, 0]

or even
>>> def test(a=[0]):
...   return a
...
>>> b = test()
>>> b.append(0)
>>> print(b)
[0, 0]
>>> c = test()
>>> print(c)
[0, 0]
>>> c.append(0)
>>> print(c)
[0, 0, 0]
>>> print(b)
[0, 0, 0]

At it's simplest, this is because of passing by reference. The list is instantiated at runtime, and its reference is used in every function call, rather than making a brand new object as necessary.
A preferable way to handle this is to set the value to a safe, immutable value, like None and check inside the function to set it to whatever you wanted your default value to be.
>>> def test(a=None):
...   if a is None:
...     a = [0]
...   return a
...
>>> b = test()
>>> print(b)
[0]
>>> b.append(0)
>>> print(b)
[0, 0]
>>> c = test()
>>> print(c)
[0]
>>> print(b)
[0, 0]

Ah, thanks for pointing it out. Wasn't aware of that.


[README] Add Accio to badge of package managers

This documents support for the new SwiftPM based dependency manager Accio.
Please note that this project is part of Accio's official integration tests within the Demo project.

I also need a test group that verifies that Accio support still works or I will need to revert this. I do not like READMEs that become stagnant and wrong.

Adding a command for running tests on the CI is on the roadmap and should be implemented soon. See here: https://github.com/JamitLabs/Accio/issues/16. Can you wait like two weeks or so? I've created a reminder to inform you here, so should not forget it.

Sure thing. Sorry if I sounded gruff, was dealing with a lot of things. Appreciate your work!


[🐛] Fixing weird template literal type errors

HOW

ok yay

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Made client authority setter internal to remove internal setter method.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix isPureTableID bug

in isPureTableID function, decode the key first and then compare the length.

https://github.com/pingcap/pd/pull/808 also fix it.

Duplicated. Thanks @LiangShang


Add metrics support to CI build

Updated devtools

Updated rubocop configuration to reflect our preferences

Added excludes to rubocop config for current violations in our codebase

Improved our Circle CI build matrix trick that takes advantage of us having many parallel containers

Added rubocop only to CI build

Added other devtools config files for use down the road

Note: I didn't add ruby 2.3.0 to the build because it looks like Circle does not support it yet.

@tjchambers and @dkubb could you both take a look at this PR before I merge it? I'd appreciate feedback on the circleci bash script if you have any notes, but I mainly would like both of you to check out the configuration so you can get an idea of our style preferences.

I looked at it and read through it. I have nothing to offer or would criticize.

Thanks

@backus I'd recommend passing the shell scripts through shellcheck.net first. It'll point out lots of things; the "error code" it displays is a hyperlink to a more in-depth explanation for a specific flag.

@backus once you've passed the shell script through shellcheck.net, ping me via IM and I can do another pass if you like.
(pinging me here might not be the best since my github activity feed is too active for me to monitor; I typically have pages and pages each day in my history)

@dkubb made the changes shellcheck.net recommended


Add Getting Started section to README

README Update
Please ad a Getting Started section to the readme file so folks know how to start with this project.

Added Getting Started section in README file.


In the multi-select, some items are singular and some are plural ("Plastic Bag" v "Sofas")

Standardise to singular

fixed in #72


Removes unnecessary MKL contraction kernel flag from mkl_aarch64 build

@penpornk - here's a PR to avoid the...
//tensorflow/core/kernels:no_mkldnn_contraction_kernel
Multiple matches are not allowed unless one is unambiguously more specialized.

...error when running bazel test on a build with --config=mkl_aarch64.
Is there any chance this could be cherry-picked for the next TF 2.9 RC?

@elfringham - I've tested this fix (which @penpornk suggested) to the .bazelrc and it appears to work fine.

Thanks @penpornk


Enable header selection

Today, If we want to selct, copy data from table and paste it to excel we can update the property includeHeadersOnCopy that will automatically copy the header when copying couple of cells. So either with header or without.
Can we enable header selection via mouse so the header will be included in the selection rectangle?

Currently, you can click on header for select full column. After on event onbeforecopy you can defined, if column is full selected you add header
The better solution : use contextmenu on header and add item copy with header et create your own function copy


Progress report

I see OpenImageDenoise supports progress functions for filters, it would be interesting. In my project i could intercept the output and show some UI progress. Any chance you can do that soon?

Thanks for the suggestion! Sounds like a nice addition that should be easy enough to add, I'll take a look into it. I'm hoping to get around to adding a couple of things this weekend, but no promises :)

Done! Check out 1.5.


Noticeable latency on Spotify

Describe the problem
There is a noticeable delay on Spotify of around 2 seconds
Expected behavior
I expected there to be at least less delay (around half a second max) because I have seen many Spotify Connect devices with little to no noticeable latency.
Device information

Board (hardware info): Raspberry Pi 3B+
Device type (as seen in balenaCloud): Raspberry Pi 3
balenaOS version: balenaOS 2.72.0+rev1

Additional context
I'm basically just asking if this is normal or if it should be less delay

Just figured something out, it isn't an issue with Spotify as the song loads instantly, it's an issue with the audio stack. It's gotten worse though, it's about 14 seconds now.

I always get a delay, but it's never more than a couple of seconds.  Does this happen with Bluetooth, too?

is the Pi wireless or connected via ethernet?

Same problem here! When I reboot all pi"s (4) latency is like 1 sec... But after a day or 2 this runs up with a few seconds. Last week I hadn't used Balena for over a week or 2 and the total delay was beyond 15 seconds...

I guess a reboot daily wouldn’t be a bad thing…mayhaps it could be automated?
Sent from nowhere near my ready room with my new tricorder

On May 22, 2021, at 19:13, xvisor16 @.***> wrote:

Same problem here! When I reboot all pi"s (4) latency is like 1 sec... But after a day or 2 this runs up with a few seconds. Last week I hadn't used Balena for over a week or 2 and the total delay was beyond 15 seconds...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I get the same, but with AirPlay. The delay grows over time, so I reboot daily via the API. But for me the AirPlay delay has actually been worse than it is with Spotify.

It was across everything. I figured it out though, I had to disable multiroom. I think it was constantly searching for a receiver and never found one because I don't have another multiroom client.

I get the same, but with AirPlay. The delay grows over time, so I reboot daily via the API. But for me the AirPlay delay has actually been worse than it is with Spotify.

I think there is an inherent 2 second delay in the AirPlay implementation

The input protocols introduce a chunk of latency in order to prevent playback issues when there may be network performance problems. However, there is a known issue with latency on the input slowly increasing over days of uptime, when running in multi-room mode.  After about a week, it can get to over 20 seconds.  This issue makes note of it (https://github.com/balenalabs/balena-sound/issues/354), but I was not able to find an issue that directly addresses it.  I will create one.
The workaround is to restart the multiroom-server container on the device being used as the server, or just reboot it.  This resets that latency issue back to the usual ~2 seconds.

They’ll have to resolve this for commercial deployments. A daily reboot at home isn’t a big deal, but command latency creep at a business wouldn’t be well received.
Sent from nowhere near my ready room with my new tricorder

On Jun 24, 2021, at 17:55, Mark Chester @.***> wrote:

The input protocols introduce a chunk of latency in order to prevent playback issues when there may be network performance problems. However, there is a known issue with latency on the input slowly increasing over days of uptime, when running in multi-room mode. After about a week, it can get to over 20 seconds. This issue makes note of it (#354), but I was not able to find an issue that directly addresses it. I will create one.
The workaround is to restart the multiroom-server container on the device being used as the server, or just reboot it. This resets that latency issue back to the usual ~2 seconds.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

+1 for this issue. I'm getting a 25-30s delay when using spotify connect. Any changes to volume, start/stop make it pretty unusable

Even with a reboot?
Sent from nowhere near my ready room with my new tricorder

On Jul 17, 2021, at 09:36, Denis Kent @.***> wrote:

+1 for this issue. I'm getting a 25-30s delay when using spotify connect. Any changes to volume, start/stop make it pretty unusable
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

My bad, I thought it had been rebooted. Back to 2-3s delay after a fresh reboot. Still frustrating though. I'll look into the possibility of making the intended latency variable.

Yeah, that’s still even too long. A few hundred ms or less would be best.
I’m wondering if subnetting sound devices would be of any help there - my network isn’t all that busy. Perhaps someone can enlighten if they have more networking knowledge than I if that’s a viable option.
Sent from nowhere near my ready room with my new tricorder

On Jul 18, 2021, at 17:48, DenisKent @.***> wrote:

My bad, I thought it had been rebooted. Back to 2-3s delay after a fresh reboot. Still frustrating though. I'll look into the possibility of making the intended latency variable.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Sorry to revive this thread but has this been solved? Has anyone smarter than me written a script to reboot at, say 6 am each morning?

I have a script that calls the API every night. If you have a Linux server, a curl call will do

curl -s -X POST --header "Content-Type:application/json" --header "Authorization: Bearer YOUR-API-TOKEN-HERE" --data '{"uuid": "YOUR-DEVICE-UUID-HERE"}' "https://api.balena-cloud.com/supervisor/v1/reboot"


Put the connection strings in a file in the users personal folder

That way the strings would be a little bit more protected and when downloading a new version of SBE you’d keep your connection strings.
Add an option to use the connection strings in the application config file for backwards compatibility, even though it is not recommended.
In the future encryption of the strings may be added using DPAPI and that may not work when using the Roaming profile. Therefore use the local non-roaming profile for this.

Maybe it would be align with other tools and go for storing it in C:\Users\<user>\.servicebusexplorer?
One might argue that the tool should integrate with Azure Key Vault as well, although this should be a dedicated issue I think.

Maybe it would be align with other tools and go for storing it in C:\Users<user>.servicebusexplorer

Will not pretend I'm an expert, but rather than using %UserProfile% settings should be stored in AppFolder. This tool is not cross-platform to target user profile root directory with a dot-notation.
I'm using more than a single machine, and consider roaming settings %AppData% more useful as settings saved there are transferable and survive machine repaving.
FYI: %AppData% translates into %UserProfile\AppData\Roaming.

One might argue that the tool should integrate with Azure Key Vault as well, although this should be a dedicated issue I think.

Gonna call YAGNI on that.

Add an option to use the connection strings in the application config file for backwards compatibility, even though it is not recommended.
In the future encryption of the strings may be added using DPAPI and that may not work when using the Roaming profile. Therefore use the local non-roaming profile for this.

Always a fan of "start simple and see what people are asking for".

Agreed with everything. Let's make sure to guarantee backward compatibility :)

And here's the reason why I still think keeping connection strings in app.config is a bad idea.

PS: @paolosalvatori you might want to reset all of your SAS tokens...


Multiple queries importing the same fragment results in unique name error on the queries

Describe the bug
On 1.11.2 I'm getting errors generating my documents. In this simple example, I have a User query and a Users query. Each one imports a fragment from another file using the #import ... syntax. I'm getting a unique error on User even though it's declared in only one place. Something about the import must be declaring it twice?
  ✔ Parse configuration
  ❯ Generate outputs
    ❯ Generate types.ts
      ✔ Load GraphQL schemas
      ✔ Load GraphQL documents
      ✖ Generate
        → Not all operations have an unique name: User

 Found 1 error

  ✖ types.ts
    Not all operations have an unique name

    * User found in:

          - /sandbox/documents/user.graphql
          - /sandbox/documents/users.graphql
    Error: Not all operations have an unique name: User

This Worked fine on 1.9.1. I tried the latest 1.11.3 alphas and it's still broken.
To Reproduce
Sandbox: https://codesandbox.io/s/autumn-hooks-2627b
Expected behavior
It generates my document without errors.
Environment:

OS: macOS 11.15.2
@graphql-codegen/...: 1.11.2
NodeJS: 10.17

You can disable GraphQL Codegen's import processing by passing skipGraphQLImport: true.

@ardatan I tried setting this config option and it made no difference?

I am having the same problem, had to downgrade to v1.9.1


Correct Pilet Setup Function section parameter type

registerTile and registerMenu are PiletApi methods and not PiralApi
New Pull Request
For more information, see the CONTRIBUTING guide.
Prerequisites
Please make sure you can check the following boxes:

[x] I have read the CONTRIBUTING document
[x] My code follows the code style of this project
[x] All new and existing tests passed

Type(s) of Changes
Contribution Type
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
[ ] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes

Description
registerTile and registerMenu are PiletApi methods and not PiralApi

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Upgrade to LangGraph v0.2 Compatibility

After downloading the latest version of LangGraph Studio (Beta) today, I noticed that it only supports the newly released LangGraph v0.2. The LangGraph v0.2 update introduces breaking changes, particularly when loading the agent folder in LangGraph Studio. To maintain compatibility, an upgrade to the new structure should be implemented.

@JoshuaC215 I made the changes for myself and I'm happy to push my changes if you allow me to push a branch -> PR.

Thanks for reporting @jabra !
I wanted to test locally until I can get some more robust CI so was easy for me to just make the fix. LMK if the merged fix works for you or still causes issues (or any other suggestions / PRs on how to improve)
For future reference, are you able to open a PR by forking the repo and opening from your own branch there? I'd prefer that workflow vs opening permissions to push here (at least for now).

All good, want to help since i want to make it work for me.
I just discovered that feature of creating PR from a forked repo, super awesome.


Ai chat responsive and fixed button misalignment

Fixes Issue #865
Changes proposed
Fixed responsiveness of AIChat and fixed misaligned button with bottom border
Screenshots
https://github.com/thecyberworld/TheCyberHUB/assets/131366333/e7acc1dc-2853-4564-ac9f-577bf438c952

Code of Conduct

[X] By submitting this pull request, I confirm I've read and complied with the CoC 🖖

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[X] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).

@GFerreiroS Thanks for trying. However, I close this pr because it doesn't solve the issue, I added more explanation for what needs to be done, tell me if you understood before opening pr.


add-sync-version on android

Hi, thank for good library
I have add sync version function for my case
make same API pbkdf2 and use babel resolver, so Use node package
I'am beginner Contributing to open source and not good at English, but I hope you understand what I mean
Thank you

@ex3ndr hi. check this PR, please.

What's the point of a synchronous method? You shouldn't use pbkdf2 this way since int would block the app and on slower devices it would be very long time (in seconds0

@ex3ndr yeah, It's slower.
Some libraies for wallets use pbkdf2 async function, and I link pbkdf2 -> react-native-fast-pbkdf2
details what I did.

make file pbkdf2.native.js

import RNpbkdf2 from 'react-native-fast-pbkdf2'

exports.pbkdf2 = RNpbkdf2.derive
exports.pbkdf2Sync = RNpbkdf2.deriveSync

configure babel (add plugin)

[
    require.resolve('babel-plugin-module-resolver'),
    {
      // android and ios
      alias: {
        ...
        pbkdf2: './src/alias/pbkdf2.native.js',
        ...
      },
    },
  ]

and We can use other libs (ethereumjs-wallet, web3, ethereumjs-util etc).
This is I want to do.


Running makes you slower

STEPS TO REPRODUCE

Hit shift
Move

I'm pretty sure this is intended behavior. You run by default, and you use shift to walk.

Im not sure about that

You should run by default, as in original game. We actually changed this button from run to move but we forgot to rename it.

I'm pretty sure this is intended behavior. You run by default, and you use shift to walk.
I would assume this is correct as this is what happens in most SS13 codebases.

Im not sure about that
Probably just labeled wrong.

Okay, changed the issue


Didn't get a result from child compiler error occurs when dynamic routes params like /blogs/[blog-id]

Describe the bug
After upgrade @vanilla-extract/next-plugin from 2.3.5 to v2.3.6, Didn't get a result from child compiler error occurs when dynamic routes params like /blogs/[blog-id], but /blogs/[id] don't occur error.
This is minimum reproduce repository
https://github.com/Katsukiniwa/nextjs-vanilla-extract-css-playground
reproduce step is

clone the above repository
run npm install
run npm run dev
access to http://localhost:3000/blogs/1

Reproduction
https://github.com/Katsukiniwa/nextjs-vanilla-extract-css-playground/actions/runs/7880973075/job/21503841452
System Info
System:
    OS: macOS 14.3.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 327.86 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.volta/tools/image/node/20.11.0/bin/node
    npm: 10.2.5 - ~/.volta/tools/image/npm/10.2.5/bin/npm
    pnpm: 8.14.3 - ~/.volta/bin/pnpm
  Browsers:
    Chrome: 121.0.6167.160
    Safari: 17.3.1
  npmPackages:
    @vanilla-extract/css: ^1.14.1 => 1.14.1
    @vanilla-extract/next-plugin: ^2.3.6 => 2.3.6

Used Package Manager
npm
Logs
➜ npn run dev

><EMAIL_ADDRESS>dev
> next dev

   ▲ Next.js 14.1.0
   - Local:        http://localhost:3000

 ✓ Ready in 2.7s
 ○ Compiling /blogs/[blog-id] ...
 ⨯ ./src/app/blogs/[blog-id]/page.css.ts
Error: Didn't get a result from child compiler
Import trace for requested module:
./src/app/blogs/[blog-id]/page.css.ts
 ⨯ ./src/app/blogs/[blog-id]/page.css.ts

Validations

[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hi @Katsukiniwa, thanks for reporting this.
It sounds like it's related to the latest fix we did for the Webpack plugin in https://github.com/vanilla-extract-css/vanilla-extract/pull/1247.

@mrm007
Thanks!
However, I do not understand the modified PR that you taught me due to my lack of technical skills, and it appears difficult to resolve this issue on my own.
Is it possible for one of the maintainers to handle this issue?

@Katsukiniwa sorry, I didn't mean to say the solution is in the linked PR. Just a note to self and for @askoufis, who recently worked on that part of the codebase.


Could we change environment during training?

Hi, I want to switch to other environment automatically during training. Is that possible with the actual provided code ?
Also can we use both depth image and distance from obstacles?
Does the simulator give only the distance of obstacles in front of the drone ?

yes. you can change environment during training. however, this is not implemented. It is possible with the actually provided code.
Yes. you can use both during training. But for evaluation, you can only use one of them
The simulator provides 10 closed distances between the drone and the obstacles. Not only the obstacles that are in front.


Close Account - HTML tags and confusing wording in when closing account with workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
and login
Create a workspace and invite several members
Go to Settings/Security and Close account

Expected Result:
Error message that is displayed when trying to close account with workspace shared with other users should be correctly displayed and should have correct wording.
Actual Result:
Error message that is displayed when trying to close account with workspace shared with other users is displayed with HTML tags and includes word "policy" which might be confusing for a user that was using only NewDot, but not OldDot.
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/204634734-e477d34e-3cbe-4896-918a-d7d5ee2fc5b6.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Duplicate https://github.com/Expensify/App/issues/12747

Thanks for pointing this one out @kbecciv ! As @thesahindia mentioned (thanks!), I made that other issue to keep track of removing those HTML tags in the Close Account errors


Build command is breaking

Error displayed in console on running npm run build or yarn build
><EMAIL_ADDRESS>build:next
> next build

info  - Using webpack 5. Reason: Enabled by default https://nextjs.org/docs/messages/webpack5
info  - Checking validity of types
info  - Creating an optimized production build ...node:internal/crypto/hash:67
  this[kHandle] = new _Hash(algorithm, xofLen);
                  ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at BulkUpdateDecorator.hashFactory (/home/container/Void/node_modules/next/dist/compiled/webpack/bundle5.js:138971:18)
    at BulkUpdateDecorator.update (/home/container/Void/node_modules/next/dist/compiled/webpack/bundle5.js:138872:50)
    at /home/container/Void/node_modules/next/dist/compiled/webpack/bundle5.js:59321:9
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
    at runNextTicks (node:internal/process/task_queues:65:3)
    at processImmediate (node:internal/timers:437:9) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Node.js v17.1.0
ERROR: "build:next" exited with 1.

Use node<=16.

Feel free to reopen the issue if the problem still persists.


French and italian translations

According to the "Swiss Implementation Guidelines QR-bill" (Annex D: Multilingual glossary), the french value for the key "PaymentPart" should be "Section paiement" (instead of "Section de paiement"), and the italian value should be "Sezione pagamento" (instead of "Sezione di pagamento").
https://www.paymentstandards.ch/dam/downloads/ig-qr-bill-en.pdf

Thanks for pointing this out. I'll fix it.

Fixed in release 2.3.3


CJS build might not work due to using lodash-es

lodash-es can't be used from CJS (as far as I understand), so using it prevents the CJS build from working.

I moved it back to normal lodash, but for some reason the bundle size increase by 10k. I released version 2.0.1 to fix the issue, but will look into reducing the bundle size again.


docs: add codecov badge

Codecov Report

Merging #2 (09597d0) into main (33a6cc2) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 09597d0 differs from pull request most recent head 70138a6. Consider uploading reports for the commit 70138a6 to get more accurate results

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage   86.71%   86.71%
=======================================
  Files           1        1
  Lines         143      143
=======================================
  Hits          124      124
  Misses         12       12
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a6cc2...70138a6. Read the comment docs.


Improve Model Loading/Saving

Currently saving full model
This can cause issues if there is a desire to use model trained via DDP in non-DDP env
Should be able to save full model OR parameter set
May need to iterate through RBMs and save params seperately as well as top-level DBN params

This has been completed with transition to PyTorch Lightning / updated interfaces


Scroll and Swap not working in fluter 2.5 (Web)

Hi,
I update my flutter to 2.5,
The new version of flutter have problems with scroll and swap on the web,
First I work with carousel_slider: ^4.0.0 and see I can not swap my images,
after that, I test ListView and PageView and face the same problems,
so I downgrade to version 2.2.3 and everything work fine,

Hi @aliazimoshan, this is the intended behaviour.
There was a breaking change with the way scrollables work in flutter 2.5.0.
Please see the migration guide and let me know if it fixes your issue.
Thank you

@danagbemava-nc
Thanks for your response,
I was not aware of these changes,
Aren't we in trouble when using a third-party package like carousel_slider?

@aliazimoshan, I don't think it will be an issue.
You have more control over the gestures now, so if anything doesn't work the way you want it, you can customize it. I also believe that the package maintainers should be aware of these changes and will update their packages accordingly

@danagbemava-nc thanks, now scroll works for me.

Closing based on this comment.


Courses without a grading scale are not handled properly

Some Chalmers students are registered to courses which don't have a grading scale. This causes the following exception to be raised when the courses data is being fetched:
Traceback (most recent call last):
  File "(redacted)", line 57, in <module>
    course_participation = student.courses()
                           ^^^^^^^^^^^^^^^^^
  File "/nix/store/ksngryn4jcip7glyr8rcwwpk29ldkx7x-python3-3.11.6-env/lib/python3.11/site-packages/ladok3/__init__.py", line 4171, in courses
    self.__get_study_attributes()
  File "/nix/store/ksngryn4jcip7glyr8rcwwpk29ldkx7x-python3-3.11.6-env/lib/python3.11/site-packages/ladok3/__init__.py", line 4158, in __get_study_attributes
    self.__courses.append(CourseRegistration(
                          ^^^^^^^^^^^^^^^^^^^
  File "/nix/store/ksngryn4jcip7glyr8rcwwpk29ldkx7x-python3-3.11.6-env/lib/python3.11/site-packages/ladok3/__init__.py", line 4399, in __init__
    super().__init__(**kwargs)
  File "/nix/store/ksngryn4jcip7glyr8rcwwpk29ldkx7x-python3-3.11.6-env/lib/python3.11/site-packages/ladok3/__init__.py", line 4193, in __init__
    self.__pull_attributes()
  File "/nix/store/ksngryn4jcip7glyr8rcwwpk29ldkx7x-python3-3.11.6-env/lib/python3.11/site-packages/ladok3/__init__.py", line 4217, in __pull_attributes
    self.__assign_attr(data)
  File "/nix/store/ksngryn4jcip7glyr8rcwwpk29ldkx7x-python3-3.11.6-env/lib/python3.11/site-packages/ladok3/__init__.py", line 4206, in __assign_attr
    id=data.pop("BetygsskalaID"))
       ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'BetygsskalaID'

@dbosk: should I experiment with this branch? I see that you have other alternative branches. What is your recommendation?

@jyp that would be much appreciated!
I tried to fix this a few months ago. The fix I expected to solve the problem is in that linked branch (#69). However, with that one all module titles and grading scales goes missing. Even for students for which this wasn't a problem to begin with.  So that's why I stopped last time. I figured it would take me more effort than I had time then.
If you want to dig into it, here's some instructions on how to run the code. To generate the Python code from the literate source you'll need Noweb and the makefiles submodule:
git clone git@github.com:dbosk/ladok3.git
git submodule update --init
sudo apt install noweb

After that it's just to run make all in the src/ladok3 directory.
To run the repo version, just use poetry.
python3 -m pip install poetry

To test changes:
make all
poetry shell
poetry install # necessary just once
[in that shell]
ladok cache clear
ladok student -c <course code> -r <student identifier>

Struck me that compiling the document won't work. I have code in there fetching some of my own data from LADOK. Which won't work for you.
ladok3.pdf is the version for #69. The changes are in section 7.3.

Spent some time in pdb. Probably the problem is caused by how __init__ in <<CourseInstance methods>> on page 28 is written. To take these faux courses into considerations in __assign_attr, we never trigger the __pull_attributes (we never get any exception).
Probably that part should try __pull_attributes too. If that raises an exception, we should do a faux course version of __assign_attr.
That's it for now. I can hopefully return to this in like ~two weeks.

Couldn't resist looking at it again in the morning. Please test the branch if you can, to see if my solution solves it for you as well.

The branch appears to work perfectly for my use case. Thanks a lot!


Add GCC to test_size_of_spdm_* for aarch64

Fix #2596.
Also fixes it for CLANG.
Signed-off-by: Steven Bellock<EMAIL_ADDRESS>

Note that we currently don't have aarch64 support in CI/CD, although that might be coming. This pull request was tested locally on a
Architecture:           aarch64
  CPU op-mode(s):       32-bit, 64-bit
  Byte Order:           Little Endian
CPU(s):                 128
  On-line CPU(s) list:  0-127
Vendor ID:              ARM
  Model name:           Neoverse-N1


Adding qiskit dependencies to docs group

The docs deployment is failing because #39 made qiskit* dependencies optional, and they were only added to the tests group but not the docs one. This PR addresses the matter.

This is something I should fix in the workflows' repo: the docs should be compiled even in branches, even if not published.
This is partially covered by the doctests, whenever there are any. But it's the wrong place (fine to have it, but we should not rely on it), we also need a dry run of the publishing workflow.


Connecting ipv4 proxies via python

Please tell me how to connect a proxy to your browser. That is, I am interested in connecting not all containers, but each separately.
That is, I start a container with a browser in python.
But I do not really understand how to add a proxy during initialization. I am interested in proxy without authorization, as well as with authorization.
capabilities = {
    "browserName": "firefox",
    "browserVersion": "108.0",
    "selenoid:options": {
        "enableVNC": True,
        "enableVideo": False
    },

}

driver = webdriver.Remote(command_executor="http://<IP_ADDRESS>:4444/wd/hub", desired_capabilities=capabilities)

Thanks in advance

@poikl246 Selenoid is fully W3C compatible WebDriver solution. So you can use standard proxy capabilities: https://stackoverflow.com/questions/17082425/running-selenium-webdriver-with-a-proxy-in-python

Thanks))


feat(c#): add support csharp-language-server

What is this PR for?

Add support to csharp-language-server an alternative to omnisharp server (Today some people are experiencing issues with Omnisharp Server see https://github.com/OmniSharp/omnisharp-roslyn/issues/2574 and with csharp-ls we don't have that issue)
Does this PR fix an existing issue?

Checklist

[x] I've read the CONTRIBUTING guidelines.

@lillo42  Great PR, looking forward to having csharp-lanaguage-server due to the issues with omnisharp. The failing test mentioned not automatically installing the language server with nvim.mason but to me it seems like mason does install automatically?


Support for Tracing Headers

r? @zenazn

Actually I thiiink we're handling this at the wrong level of abstraction: the "action ID / span ID" object should be handed to chalk-log wholesale, and should understand how to render itself (i.e., no rendering logic in chalk-log). That way others can plug their format of choice into chalk-log, for instance

So if I understand correctly use .to_s on whatever is present in LSpace[:span_id] ?

Yeah, I think so (and falling back to :action_id or whatever if it's not set)

Sounds reasonable indeed

Updated

LGTM :love_letter:


[libs/movex, libs/mvex-react] Currently there's no API to remove Resource Subscribers.

What
Currently there's no API to remove Resource Subscribers.
Why is important?
This is an issue because once added they'll continue to receive updates until the resource gets destroyed.
How to fix
Add an method to remove subscribers and a way to call it from movex-react

@GabrielCTroia Could you please assign this to me as well

Sure @Abhishek-Mallick!

This is not an issue for now


[WIP] Koenig - Keep cursor on screen

refs https://github.com/TryGhost/Ghost/issues/9505

when cursor changes through the normal cursorDidChange or through certain programmatic changes we trigger a check to see if the cursor is out of the viewport and scroll it into view if necessary

TODO:

[ ] appears to break /-menu
[ ] investigate performance
[ ] investigate odd issues with backspace deleting more than one char (not sure if related to this PR)
[ ] can we restrict checks to happen one time only after a scroll has occurred?
[ ] improve offset element handling (top header and mobile nav at smaller screen sizes)

Coverage increased (+0.1%) to 72.247% when pulling 6734951b90676be20b549fd3f9ba3a83d17ace30 on kevinansfield:koenig-keep-cursor-in-view into 0f8ef2bb63094b474e3018afb26d51dd9663934f on TryGhost:master.


largest-series-product forces implementation

The tests for this exercise test a lot of the helper methods. I think given that it's this late in the path, it isn't needed. Also, it takes away a lot of freedom from the implementer. I think the tests should be guiding more by functionality needed than by methods defined.

Related information:

largest series exercise test and soltuion
Meta for exercise
Readme data

Listed here for my convenience.

@markijbema and @kytrinyx hopefully this is what you had in mind.

BTW: in the spirit of "Look to exercism for awesome code" I took the following measurements:
Flogging your code!
    44.7: flog total
     5.6: flog/method average

    11.9: Series#separate                  example.rb:30
     7.1: Series#largest_product           example.rb:9
     6.7: Series#collection_of_digits      example.rb:36
     6.4: Series#analyzer                  example.rb:17
Your code reeks this much!
example.rb -- 2 warnings:
  [19]:Series#analyzer contains iterators nested 2 deep (NestedIterators)
  [26]:Series#reduce_to_product doesn't depend on instance state (UtilityFunction)

   42.6: flog total
    4.3: flog/method average

    6.7: Series#collection_of_digits      example.rb:45
    6.5: Series#analyzer                  example.rb:22
    6.4: Series#validate_length           example.rb:17
    6.1: Series#separate                  example.rb:39

That's a much nicer result.


MainActivity Being Duplicated

Bug Information
Version Number of Plugin: 1.3.0
Device Tested On: Huawei P8 Lite Android Version 6.0
Simulator Tested On: NA
Version of VS: Visual Studio 2019
Version of Xamarin: <IP_ADDRESS>9999
Versions of other things you are using:
 <PackageReference Include="FluentValidation" Version="7.4.0" />
    <PackageReference Include="Newtonsoft.Json" Version="11.0.1" />
    <PackageReference Include="Plugin.Share" Version="7.1.1" />
    <PackageReference Include="Prism.Core" Version="6.3.0" />
    <PackageReference Include="Prism.Forms" Version="6.3.0" />
    <PackageReference Include="Prism.Unity.Forms" Version="6.3.0" />
    <PackageReference Include="Rg.Plugins.Popup" Version="<IP_ADDRESS>-pre" />
    <PackageReference Include="Xam.Plugins.Settings" Version="3.1.1" />
    <PackageReference Include="Xamarin.Forms" Version="<IP_ADDRESS>9999" />
    <PackageReference Include="ZXing.Net.Mobile" Version="2.3.2" />
    <PackageReference Include="ZXing.Net.Mobile.Forms" Version="2.3.2" />
    <PackageReference Include="Unity" Version="4.0.1" />
    <PackageReference Include="Xamarin.FFImageLoading.Transformations" Version="<IP_ADDRESS>9" />
    <PackageReference Include="Xamarin.FFImageLoading.Forms" Version="<IP_ADDRESS>9" />
    <PackageReference Include="XamEffects" Version="1.5.0" />
    <PackageReference Include="libphonenumber-csharp" Version="8.9.13" />
    <PackageReference Include="Syncfusion.Xamarin.SfRating" Version="<IP_ADDRESS>" />
    <PackageReference Include="Syncfusion.Licensing" Version="<IP_ADDRESS>" />
    <PackageReference Include="Xamarin.Build.Download" Version="0.4.11" />
    <PackageReference Include="Syncfusion.Xamarin.Buttons" Version="<IP_ADDRESS>" />
    <PackageReference Include="Plugin.PushNotification" Version="1.3.0" />

Expected Behavior
I expected the MainActivity to be launched in SingleTop mode once a user taps on the notification.
Actual Behavior
After sending the notification while the application is in the background I tao on the notification and the application opens as expected. I
have some code that runs when a notification is received and the application is in the Foreground, which I implemented in the CrossPushNotification.Current.OnNotificationReceived method in my App.xaml.cs(seeing that this event is not fired when the application is in the background).
The problem I'm having is the CrossPushNotification.Current.OnNotificationReceived in my App.xaml.cs is fired twice after following the steps above.
Code snippet
This is the method in my App.xaml.cs file being fired twice.
If anymore code is required from somewhere else, I will provide it accordingly.
CrossPushNotification.Current.OnNotificationReceived += (s, p) =>
            {
                var notificationData = p.Data;
                bool hasValue = notificationData.TryGetValue(NotificationDataKeys.NotificationIntentNameKey, out object notificationIntentName);
                if (ApplicationStateCache.ApplicationIsInForeground && hasValue && $"{notificationIntentName}" is "confirm_debit")
                {
                    notificationData.TryGetValue(ConfirmPurchaseNotificationDataKeys.CardNumberKey, out object cardNumber);
                    notificationData.TryGetValue(ConfirmPurchaseNotificationDataKeys.LoadAmountKey, out object loadAmount);
                    notificationData.TryGetValue(ConfirmPurchaseNotificationDataKeys.NotificationDescriptionKey, out object notificationDescription);
                    LoyaltyworxSale loyaltyworxSale = new LoyaltyworxSale($"{cardNumber}", Convert.ToDecimal(loadAmount), $"{notificationDescription}");
                    Device.BeginInvokeOnMainThread(() =>
                    {
                        ConfirmCardDebit(loyaltyworxSale.CardNumber, $"{loyaltyworxSale.LoadAmount}", loyaltyworxSale.LoyaltyWorxSaleDescription);
                    });
                }
            };

Hi
This might be of some assistance, I managed to replicate the exact same issue on the sample project as well, which gives me the impression that its perhaps a problem within the library.

Im trying to open different page than mainpage in onnotificationopened and the page opens for a few seconds and goes back to the main one from before giving me duplicate activity in the background so I guess its a same thing.
Im doing MainPage = new NavigationPage(new Messages());

@haxor211
Hi,
Did you manage to solve the issue? (in OnNotificationOpened the page opens for a few seconds and goes back to the main one from before)

Apologies for the very delayed response but the solution to this can be found here, if anyone is interested.
In summary, the issue was occurring because my notification payload had a "notification" object, in the end, we had to determine on the backend whether a user is on iOS or Android and send a notification payload to firebase with or without the notification object based on the latter.


Issue with line numbers and padding

Hi,
Thanks for the plugin, I really like the way it displays code blocks in a rounded cornered black background. Looks awesome on a white theme.
I've run into a few issues however:

The line numbers are off - they don't always sync up to each line of code.
IF the code block is longer - there is an unnecessary scroll bar created and the line number run a lot longer than actual code in the block.
The padding is off between the code text and the line that separates the line numbers

Would you be able to include an option to turn off line numbers completely - give the user the choice if they'd like to see it or not.
Attached below is an image of some of the issues described above.

Thank you for your question. I will fix it as soon as possible and improve some features.
---Original---
From: "Adrian @.>
Date: Wed, Apr 10, 2024 23:16 PM
To: @.>;
Cc: @.***>;
Subject: [jl15988/joplin-plugin-code-perfect] Issue with line numbers andpadding (Issue #1)
Hi,
Thanks for the plugin, I really like the way it displays code blocks in a rounded cornered black background. Looks awesome on a white theme.
I've run into a few issues however:
The line numbers are off - they don't always sync up to each line of code.
IF the code block is longer - there is an unnecessary scroll bar created and the line number run a lot longer than actual code in the block.
The padding is off between the code text and the line that separates the line numbers
Would you be able to include an option to turn off line numbers completely - give the user the choice if they'd like to see it or not.
Attached below is an image of some of the issues described above.
image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Do you have any other plugins installed, if so please provide the plugin name to help me troubleshoot the problem, thanks! @dsouzadrian

Yep, I have quite a few others installed.

As a workaround for now - I've disabled line numbers by adding the following to my custom CSS
/* CodePerfect Plugin - disable line numbers*/
.hljs-line-num
{
    display: none !important;
}

Please try updating to the latest version.


node_modules/agm-overlays: Appears to be a git repo or submodule

Getting this error after installing new agm-overlays, reverting doesn't help. Now any npm command is not executable successfully.
node_modules/agm-overlays: Appears to be a git repo or submodule

npm ERR! git Refusing to remove it. Update manually,
npm ERR! git or move it out of the way first.

node 12.2.0
npm 6.9.0

It is a topic with your team, I update without problem, try to remove the module and add it again

@havo07 is most like right. That errors comes from making manual changes to a folder. Please delete agm-overlays in node_modules and reinstall
@havo07 your help is much appreciated and I will make you a contributor os this package real soon (off to take kid to school)

I'm facing the same error on fresh install of agm-overlays in travis CI

@nkprince007, can you indicate if you've used this library in the past?
Really thinking updates to Angular and/or TypeScript are a part of this

No, I'm a fresh user to this package, but I've heard from my team that they've been using it for over a year.

I found it when it happened to me.
Somehow the .git folder got published to npm. I had no .npmignore file.
This is fixed in v1.4.1
If you are getting this issue from an older version, remove the folder node_module/agm-overlays and reinstall.