Actual worker class and logic to interact with from client.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1273  👈
#1272
#1271
#1152 : 1 other dependent PR (#1195 )
#1270
#1269
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite

Merge activity

Oct 15, 1:55 PM EDT: A user started a stack merge that includes this pull request via Graphite.


chore: lift run-e2e to yarn-project earthfile

Please read contributing guidelines and remove this line.

#6018  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @just-mitch and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

note_trial_decrypting_time_in_ms (8): 93.1 (+569%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
772
772
772

l1_rollup_calldata_gas
6,844
6,820
6,844

l1_rollup_execution_gas
587,325
587,301
587,325

l2_block_processing_time_in_ms
1,522 (+4%)
5,503 (+1%)
10,254 (-2%)

note_successful_decrypting_time_in_ms
199 (-12%)
533 (-2%)
1,102

note_trial_decrypting_time_in_ms
:warning: 93.1 (+569%)
31.8 (-25%)
117 (-1%)

l2_block_building_time_in_ms
18,726
72,925
145,879 (-1%)

l2_block_rollup_simulation_time_in_ms
18,513
72,184
144,430 (-1%)

l2_block_public_tx_process_time_in_ms
8,493
33,180
66,886 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
16,709 (+6%)
31,920 (+4%)

note_history_successful_decrypting_time_in_ms
1,354 (+3%)
2,728 (-1%)

note_history_trial_decrypting_time_in_ms
83.6 (+2%)
145 (-1%)

node_database_size_in_bytes
19,136,592
35,803,216

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
157 (-5%)
47,763
31,978

private-kernel-inner
175 (-5%)
80,794
31,978

private-kernel-ordering
137 (-4%)
57,732
50,043

base-parity
9.55 (-8%)
128
265

root-parity
75.6 (+6%)
1,244
265

base-rollup
12,110 (-2%)
110,926
957

root-rollup
49.6 (-3%)
4,551
821

public-kernel-app-logic
1,541 (-1%)
62,017
26,202

public-kernel-tail
4,158 (-2%)
168,566
3,812

merge-rollup
3,159 (-1%)
2,760
957

public-kernel-teardown
118 (-2%)
62,017
34,711

public-kernel-setup
130 (-4%)
62,017
34,711

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.9 (-1%)
17.6 (-4%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.636 (-1%)
0.544 (-4%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
51.6
80.3 (-1%)
257 (-2%)
502
972 (-1%)
1,930 (-1%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.529 (-1%)
0.495
0.468 (-2%)
0.468
0.463
0.462 (-1%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
60.4 (-3%)
118 (-1%)
373 (-1%)
739
1,451 (-1%)
2,898
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
105
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.533 (-3%)
0.532
0.508 (-1%)
0.509
0.505
0.505
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
67.6 (-1%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.589 (-1%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
51,411
543,524

Transaction size based on fee payment method

Metric
native fee payment method
fpc_public fee payment method
fpc_private fee payment method

tx_with_fee_size_in_bytes
897
1,145
1,345

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
1,250 (-6%)
861 (-5%)
3,484 (-1%)

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
5 public data writes
8 public data writes

tx_sequencer_processing_time_ms
834 (-2%)
754 (-6%)
1,336 (-5%)
892 (-6%)
2,056 (-5%)
1,080 (-5%)


vite.moduleGraph.safeModulesPath contents are... weird

Describe the bug
This is a bit of an odd one — it's not causing any problems per se, and the fault probably lies with Vite, but I haven't succeeded in reproducing it in Vite without Kit, so I'm raising it here instead.
Vite's moduleGraph has a safeModulesPath set of paths that (I think) have been determined to be safe to serve. But the paths are truncated. When I log them out, a typical list looks like this:
[
  "elte-kit/dev/generated/root.svelte",
  "elte-kit/dev/generated/manifest.js",
  "e_modules/.vite/svelte.js",
  "elte-kit/dev/runtime/chunks/utils.js",
  "e_modules/.vite/svelte_store.js",
  "elte-kit/dev/runtime/internal/singletons.js",
  "elte-kit/dev/runtime/paths.js",
  "e_modules/.vite/svelte_internal.js",
  "e_modules/svelte-hmr/runtime/hot-api-esm.js",
  "e_modules/svelte-hmr/runtime/proxy-adapter-dom.js",
  "elte-kit/dev/components/layout.svelte",
  "elte-kit/dev/components/error.svelte",
  "/routes/index.svelte",
  "e_modules/.vite/chunk-TFQY2HEV.js",
  "e_modules/.vite/chunk-U3E4LOIS.js",
  "e_modules/svelte-hmr/runtime/index.js",
  "e_modules/svelte-hmr/runtime/overlay.js",
  "e_modules/svelte-hmr/runtime/hot-api.js",
  "e_modules/svelte-hmr/runtime/proxy.js",
  "e_modules/svelte-hmr/runtime/svelte-hooks.js",
  "e_modules/vite/dist/client/env.mjs"
]

Reproduction
https://github.com/Rich-Harris/vite-safe-modules-repro
Logs
No response
System Info
System:
    OS: macOS 12.0.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 86.67 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node
    npm: 8.1.2 - ~/.nvm/versions/node/v16.13.1/bin/npm
  Browsers:
    Chrome: 97.0.4692.71
    Firefox: 95.0.2
    Safari: 15.1
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.10
    @sveltejs/kit: next => 1.0.0-next.229
    svelte: ^3.44.0 => 3.46.1

Severity
annoyance
Additional Information
No response

FWIW, I can't reproduce this. I'm getting an empty array/set. Ubuntu on WSL.

It repros for me -- the list is as described in the issue report. Also Ubuntu on WSL.

Same, arch linux

Reproducible with macos M1 Pro. But I have to visit http://localhost:3000 first, then http://localhost:3000/safe-modules-inspector, for it to show the paths. Loading the subpath URL directly after dev server startup shows an empty list.
A quick search in Vite shows this line to be truncating it.

unconditionally stripping the first 4 chars seems weird.
I remember that there is a place in vite-plugin-svelte where we strip the fs prefix, and you have to take platform into account to end up with a proper absolute path: https://github.com/sveltejs/vite-plugin-svelte/blob/843841552c3d3d02809c6db34b10b935e2b98770/packages/vite-plugin-svelte/src/utils/id.ts#L73

@bluwy this is the same for me actually, didn't realise

may be fixed by https://github.com/vitejs/vite/pull/6518

Thanks @dominikg! Not sure if you saw, but it looks like there's a test failure on that PR that will need to be looked at

yeah i just rebased the PR and it fails in the same way so seems valid. Unfortunately it's windows and my windows vm is toast.

https://github.com/vitejs/vite/pull/6518 was just merged and will be included in Vite 2.9


Early exit if folder already exists

When someone does ignite new TacoTruck but the tacotruck folder exists, we should fail.
See this issue comment:   https://github.com/infinitered/ignite/issues/241#issuecomment-244415741

Made a start on this today, should have something soon. ⌛

Let me know if you have any questions.  We don't have much documentation on our structure.


!URGENT!!! - Bot not receiving webhook updates.

Required Information

(USING LUMEN - 5.4)

Operating system: Shared Hosting
PHP version: 5.6
PHP Telegram Bot version: 0.42.0
Using MySQL database: yes
MySQL version:
Update Method: Webhook
Self-signed certificate: no
RAW update (if available):
{
"update_id":1111111,
"message": {
"message_id":756,
"from":
{
"id":135600675,
"first_name":"MHOS\u039eI\u0418",
"last_name":"\u019d",
"username":"MHN_NJ"
},
"chat":
{
"id":135600675,
"first_name":"MHOS\u039eI\u0418",
"last_name":"\u019d",
"username":"MHN_NJ",
"type":"private"
},
"date":1494250877,
"text":"شروع بازی!"
}
}

Expected behaviour

Telegram handle function should receive webhook updates and process.
Actual behaviour

handle function never being called at all, in update log i cannot see updates. i even made custom log system to log at very beginning of file, but not receiving anything.
Steps to reproduce

I dont know.
Extra details

I'm using Lumen 5.4...
My Controller:
<?php

namespace App\Http\Controllers;

use Longman\TelegramBot\Entities\WebhookInfo;
use Longman\TelegramBot\Request;
use Longman\TelegramBot\Telegram;
use Longman\TelegramBot\TelegramLog;
use Longman\TelegramBot\Exception\TelegramException;

class HookController extends Controller
{
    protected $telegram;
    protected $api;
    protected $botan;
    protected $bot_name;

    public function __construct()
    {
        $this->api = env('TELEGRAM_API');
        $this->bot_name = env('TELEGRAM_USERNAME');
        $this->botan = env('TELEGRAM_BOTAN');
        $this->telegram = new Telegram($this->api, $this->bot_name);
    }

    public function Hook() {
        TelegramLog::initErrorLog(__DIR__ . '/../../../logs/error.log');
        TelegramLog::initDebugLog(__DIR__ . '/../../../logs/debug.log');
        TelegramLog::initUpdateLog(__DIR__ . '/../../../logs/update.log');
        try {
            $this->telegram->enableExternalMySql(app('db')->connection()->getPdo());
            $this->telegram->enableAdmin((int)env('TELEGRAM_ADMIN'));
            if (!empty($this->botan)) $this->telegram->enableBotan($this->botan);
            $this->telegram->addCommandsPath(__DIR__ . '/../../../commands_unused');
            $this->telegram->addCommandsPath(__DIR__ . '/../../../commands');
            $this->telegram->handle();
        } catch (TelegramException $e) {
            TelegramLog::error($e);
        }
    }

    public function SetHook() {
        try {
            $result = $this->telegram->setWebhook(route('API.Hook'));
            echo $result->getDescription();
        } catch (TelegramException $e) {
            echo $e;
        }
    }

    public function UnsetHook() {
        try {
            $result = $this->telegram->unsetWebhook();
            echo $result->getDescription();
        } catch (TelegramException $e) {
            echo $e;
        }
    }

    public function WebhookInfo() {
        $result = Request::getWebhookInfo();
        if (!$result->isOk())
            echo 'Webhook was not retrieved! Error: ' . $result->getErrorCode() . ' ' . $result->getDescription();
        else {
            ///** @var WebhookInfo $result */
            //$result = $result->getResult();
            echo $result->toJson();
        }
    }
}

Routes file:
<?php

/*
|--------------------------------------------------------------------------
| Application Routes
|--------------------------------------------------------------------------
|
| Here is where you can register all of the routes for an application.
| It is a breeze. Simply tell Lumen the URIs it should respond to
| and give it the Closure to call when that URI is requested.
|
*/

$api = env('TELEGRAM_API');

$app->get('/', function () use ($app) {
    return $app->version();
});

$app->group(
    [
        'prefix' => substr($api, 0, strpos($api, ':')),
        'as' => 'API'
    ],
    function () use ($app) {
        $app->post('hook',
            [
                'as' => 'Hook',
                'uses' => 'HookController@Hook',
            ]);

        $app->get('hook_set',
            [
                'as' => 'SetHook',
                'uses' => 'HookController@SetHook',
        ]);

        $app->get('hook_unset',
            [
                'as' => 'UnsetHook',
                'uses' => 'HookController@UnsetHook',
            ]);

        $app->get('hook_info',
            [
                'as' => 'HookInfo',
                'uses' => 'HookController@WebhookInfo',
            ]);

    }
);

I NEED THIS FIXED VERY SOON. I LOSE MANY IF I DON'T COMPLETE THIS. PLEASE

Hi @no-nevis
I see that the pending_update_count is really high, so something clearly isn't working properly.
Is there anything in your error log?
If you access the URL of your webhook directly, does it add an Input empty! message to your error log?

I don't get ANY errors.
and, no, i get empty response when sending empty request (because my hook route only accept POST :D but even with postman and sending empty post request, i get empty response

I temporiraly fixed this with switching to getUpdate and cron job every minute, but only temp. (i cant run cli on shared hosting)

Hmm. Did you change anything that might have caused this issue?
Or did it just start happening?

Just started happening.. i changed some little things long time ago but not remember.

Have you tried resetting your webhook? (unset and set again)
Now that you're using getUpdates temporarily, what is the output of your getWebhookInfo?

{"ok":true,"result":{"url":"","has_custom_certificate":false,"pending_update_count":0}}
one of my commands was returning nothing, that's fixed but still not working :(

Could you maybe get in touch with me via Telegram (@noplanman)?
Easier to chat and sort it out 😃

It would be really nice if could at least submit your fix and not just close the Issue after a private chat . . .

@BrutalBirdie Are you having the same problem then?
Please try to reset your API key with BotFather and then reset your webhook.
If that doesn't fix it, feel free to open a new ticket and explain what you've tried and what exactly isn't working, thanks 😃

@BrutalBirdie It was a problem from the hosting bro, nothing wrong with the bot.

That's the kind of error meaning Telegram has trouble reaching your server.
It might be blocked by firewall or server is located in a country that blocked Telegram completely.


Fix the build according to API changes from cni/pkg/types

The package github.com/containernetworking/cni/pkg/types has been recently
modified and the Result structure has been moved to an interface. Instead,
two new packages cni/pkg/types/020 and cni/pkg/types/current have been added.
Those new packages provides some functions to convert the Result interface
into a 020.Result or current.Result structure.
Because we want to follow latest version, this commit modifies our cni and
virtcontainers packages so as to get current.Result structure.

Coverage decreased (-0.02%) to 62.572% when pulling 15c14211e20572995f407ef3b4b3fad0620f6407 on sboeuf/fix_build_cni_result_types into c8ff1a14238b0451e8e47995fc8d822baec3d66b on master.


Buttons on wish list are messed up - ipad pro view?

In Firefox, full view, the buttons expand into the white separation space. I don't think they should?

The layout has been updated in the demonstration site. Add this code to the Wish List Page section of the theme.css file and the class t-wish-list__item to the x-product-list__item element in the code to correct.
.t-wish-list__item .c-control-group__button {
	flex: 1 1 50%;
	padding-right: 0;
	padding-left: 0;
}

Brennan has asked me to be more thorough in my testing… i.e. Chrome Firefox, Sarai and Explorer on PC. Tablets, cell phones, etc. So that’s what I’m doing.
When you say this has been updated in the demo site, does that mean it’s been fixed in the Main site so the next run it will be corrected?
Jenn Rawlings
Assistant to the VP of Developer Relations / Miva, Inc.
www.miva.comhttp://www.miva.com/
Twitterhttp://www.miva.com/social/twitter | Facebookhttp://www.miva.com/social/facebook | Instagramhttp://www.miva.com/social/instagram | LinkedInhttp://www.miva.com/social/linkedin | Bloghttp://www.miva.com/blog
[http://www.miva.com/images/new-images/miva-email-sig.gif]http://www.miva.com/
On Feb 12, 2018, at 11:09 AM, Matt Zimmermann <notifications<EMAIL_ADDRESS>wrote:
The layout has been updated in the demonstration site. Add this code to the Wish List Page section of the theme.css file and the class t-wish-list__item to the x-product-list__item element in the code to correct.
.t-wish-list__item .c-control-group__button {
flex: 1 1 50%;
padding-right: 0;
padding-left: 0;
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/mivaecommerce/readytheme-shadows/issues/10#issuecomment-365029021, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK6vGcKH3ONV6r-x5hJlsKqZmKAiSFBNks5tUIxSgaJpZM4SCmbG.

The core code for the Shadows ReadyTheme has been updated so the next package will contain it.


Initial implementation

Looks great - we could also create a small TravisCI build to run the tests (not a high priority now, though).


[BUG] Widget section with landscape orientation doesn't show content

Environment
Self-Hosted (Docker)
System
Version 107.0.5304.110 (Official Build) (64-bit)
Version
2.1.1
Describe the problem
I'm using dashy with a custom CSS to have two widgets in the same row:
.widget-list {   display: flex;   align-items: flex-start;   justify-content: space-around; }
But when I have dashy in the main "page" it doesn't show the widgets, it only does if I click to open that section separately:
Here's a short gif video to the issue.
Additional info
No response
Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Did you get a chance to look into this?

Hi,
I'm still experiencing this. Any chance you can look at this or recommend a workaround/hack?
Thanks!


Error at class with divider

Describe the bug
Error at class with divider
class:bg-gray-900/10={messageHasValue}

What version of SvelteKit are you using?
Svelte 3.44.0
Sveltekit 1.0.0-next.297
What version of Tailwind CSS are you using?
v.3.0.23
What version of Node.js are you using?
v16.14
What browser are you using?
Safari Version latest (15.3 (176<IP_ADDRESS>.8))
Describe your issue
Problem in VSC Expected >svelte(unexpected-token)

<div class="bg-gray-900"
  <div class="text-gray-200" class:bg-gray-900/10={messageHasValue}
    some content

Reproduction

<div class="bg-gray-900"
   1.0.0-next.33
    @sveltejs/kit: next => 1.0.0-next.297
    svelte: ^3.44.0 => 3.46.4

Escaping the slash does not work either.
Severity
annoyance
Additional Information
No response

Duplicate of https://github.com/sveltejs/svelte/issues/4072.


Create a test to verify in OSS that window aggregate query was indeed pushed down to storage

Similar to https://github.com/influxdata/idpe/issues/6999, we want to have a verification test in OSS.
We can still read the query_influxdb_source_read_request_duration_seconds metric, it's set in influxdb: query/stdlib/influxdata/influxdb/metrics.go

I believe you can use the launcher to standup the testing framework in order to run a query and get metrics.


Update Sparkle (>=1.13.1)

Not sure if this project is affected (is everything served under HTTPS?). See the Sparkle vulnerability.

Looks like SoundCleod is safe:

Applications using Sparkle with HTTPS appcast feed URLs and HTTPS release notes links (if any) are safe.

We use https appcast and no release notes links:
https://github.com/salomvary/soundcleod/blob/e47b58f0c051391a647b3b16139b237b2354d7ea/SoundCleod/SoundCleod-Info.plist#L47
Will update anyway.

@salomvary Awesome, you rock!

0.20 updates Sparkle to 1.14.0


OneFuzz CLI command to download current CLI version from endpoint service

I'd like to be able to download the OneFuzz CLI version that matches my endpoint service without having to interact with pip (have a python installation available, pip install onefuzz, query the endpoint, pip install onefuzz the reported version).
@bmc-msft suggested a CLI command that could download the correct version from the endpoint. I'm inferring this would mean a version-agnostic command where any (reasonably recent - e.g. within the same major version) CLI could query the endpoint and download a version of the CLI that matches the version the endpoint is running.
This feature would enable automated scripts (such as pipelines) to be able to easily download the correct CLI version from the endpoint and then submit jobs without needing a python installation. Additionally, the download should be a lot faster than the pip method and save a lot of pipeline job time.
AB#35971

This seems reasonable and useful for teams, and would make instances a bit more "self-service".
Thinking out loud about implementation / acceptance criteria:

I think we'd probably want to keep copies of the latest CLI (for both Windows/Linux) in a new blob storage container in the non-user data func... storage account.
We'd update that new container at deploy time, and we'd want to ensure that normal OneFuzz CLI / API commands cannot access that container.
We'd probably implement this via a new API endpoint and CLI sub-command like onefuzz cli get or onefuzz cli download_latest.

Whatever sub-command you decide on, can you also add an option to specify the output file? Something like -o <outfile>? I'd like to be able to use an older client to connect and download the correct version client and then call the new client without having to also figure out what version it is. Example cmd/ps1 script:
onefuzz-cli-2.18.0.exe config ...
onefuzz-cli-2.18.0.exe cli get -o onefuzz-cli.exe

onefuzz-cli.exe template libfuzzer ...

(Also thinking out loud here:) If allowed by policy, another idea might be to save needing an existing client in the first place by having a non-auth URL where I can always download the latest CLI. That way, I can just download the correct version CLI from the endpoint using something like curl or Invoke-WebRequest:
curl -Lo onefuzz-cli.exe https://<endpoint>/cli/latest/windows
onefuzz-cli.exe template libfuzzer ...

(Also thinking out loud here:) If allowed by policy, another idea might be to save needing an existing client in the first place by having a non-auth URL where I can always download the latest CLI.

Unfortunately, this is harder to do in an authenticated fashion.

Closing.


Start refactoring client and server code

Related to #22. We want to start detaching the server codebase
and the client we're using for testing.
Ideally, the client we'll use for testing will not event be
this one, but the one we're working on in a separate repo.
One step at a time, tho. Let's first move as much of the client
code as possible outside of the ./ndt7 subtree and use the
minimal amount of dependencies to implement such client.
This change is implemented such that everything should continue
to work as before. Yet, it enables to flatten a little bit server
code and basically assume anything under ./ndt7 is server
side code plus some structure definitions.
More refactoring will be enabled by this refactoring in pure
"yak shaving" spirit.

This change is

Pull Request Test Coverage Report for Build 530

3 of 8 (37.5%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 54.62%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/ndt-client/main.go
0
1
0.0%

ndt7/download/download.go
2
4
50.0%

ndt7/results/file.go
1
3
33.33%

Totals

Change from base Build 528:
-0.01%

Covered Lines:
733

Relevant Lines:
1342

💛  - Coveralls


Adding Menus to existing layers

Is it possible to add a context menu to an already existing layer?
While the following is possible for the map its not working with layers like polyline (there failing at L.Map.ContextMenu.L.Handler.extend._createItems line 177).
mapMenu = new L.Map.ContextMenu(map)
mapMenu.addItem { text: 'Neues Feld', callback: () -> alert('Feld erstellen...') }
mapMenu.addHooks()

For polylines I'm doing the following which works:
polygon.options.contextmenu = true
polygon.options.contextmenuItems = [{ text: "gach", callback: () -> alert("gach") }]
polygon._initContextMenu()

Is that the only way to add and enable a context menu on something other than a map? It shouldn't be.

Sorry for the late reply on this issue. A context menu can be added to all vector layers that extend L.Path declaratively using the layer options. For example:
      var polygon = L.polygon([
          [-36.78271, 174.67091],
          [-36.89152, 174.64207],
          [-36.91074, 174.82815]
      ], {
          contextmenu: true,
          contextmenuInheritItems: true,
          contextmenuItems: [{
              text: 'Polygon marker item'
          }]
      }).addTo(map);

Alternatively it can be added to an existing layer using the bindContextMenu() method:
      var polygon = L.polygon([
          [-36.78271, 174.67091],
          [-36.89152, 174.64207],
          [-36.91074, 174.82815]
      ]).addTo(map);

     polygon.bindContextMenu({
          contextmenu: true,
          contextmenuInheritItems: true,
          contextmenuItems: [{
              text: 'Polygon marker item'
          }]
      });

A context menu can also be removed using the unbindContextMenuItem() method.

Hi,
I have a project where there is a need to show the context menu on map. I use tombatossals/angular-leaflet-directive. It's possible to use this plugin? If yes, could you, please provide an example?
Thank you!

Sorry I have no experience with angular so I can't provide you with specifics. Providing you can get a reference to the Leaflet map instance that angular creates I don't see any reason why you can't use this plugin.

:+1:  for bindContextMenu syntax! It should be on the docs!

@aratcliffe using the bindContextMenu syntax, when the context menu is open and I click in any other area of my viewport, it doesnt close automatically, any ideas?

I solve it by adding to the map creation contextmenu: true with no items.

@franleplant bindContextMenu() is in the docs.

Yeap, it is, I saw it, but perhaps the full example could put it into
context and show what is it for. Thank you very much for your work :smile:
On Thu, Oct 22, 2015 at 1:46 PM Adam Ratcliffe<EMAIL_ADDRESS>wrote:

@franleplant https://github.com/franleplant bindContextMenu() is in the
docs.
—
Reply to this email directly or view it on GitHub
https://github.com/aratcliffe/Leaflet.contextmenu/issues/22#issuecomment-150285286
.


Directory for --profile not resolving relative paths correctly

Description: The option --profile does not seem to correctly resolve relative paths within the given profile files in more recent versions of Snakemake.
In production code, Snakemake 7.x.x
With Snakemake 7.0.0 and later, I first encountered this in a larger pipeline, where after a call containing
snakemake [...] --profile profiles/slurm/

the error message was:
WorkflowError:
FileNotFoundError: [Errno 2] No such file or directory: 'profiles/slurm/slurm-jobscript.sh'

with a config.yaml in the provided profile directory that contains the line
jobscript: "slurm-jobscript.sh"

That file exists though in the current working directory. It hence seems that the relative path profiles/slurm/slurm-jobscript.sh is constructed correctly with the provided information, but somehow executed from a wrong working directory, or something akin to that.
In production code, Snakemake 6.1.0
With Snakemake 6.1.0, the error is similar:
WorkflowError:
FileNotFoundError: [Errno 2] No such file or directory: 'profiles/slurm/slurm-jobscript.sh'
  File "/home/lczech/miniconda3/envs/grenepipe-snakemake-6.1.0/lib/python3.7/site-packages/snakemake/executors/__init__.py", line 910, in __init__
  File "/home/lczech/miniconda3/envs/grenepipe-snakemake-6.1.0/lib/python3.7/site-packages/snakemake/executors/__init__.py", line 648, in __init__

This works with Snakemake 6.0.5 though, so I suspect that this Change Log entry:

Profiles using –cluster option can now handle relative submit script paths in combination with arguments

is at least part of the problem.
In minimal example
It get's a little weirder though.
I then created a minimal example for this. It uses my adaptation of a slightly outdated slurm cookie-cutter profile, but I don't think that particularly matters.
For simplicity, I changed the path to the profile simply to slurm/ within the directory of the Snakefile. The call is hence
cd /home/lczech/tmp_03_profile_rel_path # or wherever you put this
snakemake --profile slurm/

However, with that minimal example, the error only occurs starting with Snakemake 7.6.1 (it works with Snakemake 7.6.0), and the error message changes to:
Traceback (most recent call last):
  File "slurm/slurm-submit.py", line 48, in <module>
    cluster_config = slurm_utils.load_cluster_config(CLUSTER_CONFIG)
  File "/home/lczech/tmp_03_profile_rel_path/slurm/slurm_utils.py", line 31, in load_cluster_config
    dcc = io.load_configfile(path)
  File "/home/lczech/miniconda3/envs/snakemake-7.6.1/lib/python3.7/site-packages/snakemake/io.py", line 1644, in load_configfile
    config = _load_configfile(configpath)
  File "/home/lczech/miniconda3/envs/snakemake-7.6.1/lib/python3.7/site-packages/snakemake/io.py", line 1609, in _load_configfile
    obj = open(configpath_or_obj, encoding="utf-8")
FileNotFoundError: [Errno 2] No such file or directory: '/home/lczech/tmp_03_profile_rel_path/slurm/slurm/cluster_config.yaml'
Error submitting jobscript (exit code 1):

Looking at the FileNotFoundError line, it seems that an additional slurm/ sneaked its way into that path somehow, meaning that the last segment provided by the --profile path is somehow duplicated.
No idea why this error and the version where it occurs are different from the one in my production pipeline, but it might be caused by the same bug - hence, for now, I will not try to create another minimal example to re-create the first bug above.

I seem to encounter this bug too.
I have tried first the official, cookiecutter SLURM profiles and ran into this error.
When using the simple profile solution from https://github.com/jdblischak/smk-simple-slurm, it works, i.e., I can submit jobs to our HPC.
However, when I specify a custom jobscript in the config.yaml, I am also getting this error (FileNotFoundError: [Errno 2] No such file or directory:).
I need the custom jobscript, though, as our HPC seems to require a login bash, whereas the default is to use a regular bash/shell.

Brief update: When using --cluster-status $PWD/profiles/slurm-iris/status-sacct-robust.sh or --jobscript $PWD/profiles/slurm-iris/jobscript.sh, i.e., explicitly specifying the absolute paths via the command line, it works fine for me.
However, that partially defeats the point of having a profile in the first place.
Hence, resolving this bug remains to be important IMO.
Best wishes and stay safe,
Cedric

@lczech, I'm not able to reproduce your minimal example using snakemake v7.16.1+1.g05d92e0a
Do your examples work on the latest version of snakemake?

I just revisited this issue in another context. The issue in my case seems to indeed stem from the use of workdir: "results". When I include jobscript: "../PATH/TO/PROFILES/jobscript.sh", i.e., do this relative and go "one-folder-up" (..), it works fine.
Same for cluster-status:.


Allow for Shift + Click range-select in the Grid, similar to Windows Explorer

#60

Coverage decreased (-1.0%) to 89.32% when pulling 6007cc75dd5d4410b3be2ed915cd75cd2efeb7a8 on duteng:0.1.0-dev into a073e9995b46830f09ddbccf9fc60d4f8f974217 on Microsoft:0.1.0-dev.

Can we make this a separated projection?

Coverage decreased (-1.0%) to 89.313% when pulling f4ca97301f6721e7974f01e66517af2b9c87751c on duteng:0.1.0-dev into 487e534388c52c0b30e1cd68c2b1aa69ef2b8677 on Microsoft:0.1.0-dev.

Coverage decreased (-0.7%) to 89.602% when pulling ada01a53f325f0a7ecd6a6426a81309ba1d414dc on duteng:0.1.0-dev into 487e534388c52c0b30e1cd68c2b1aa69ef2b8677 on Microsoft:0.1.0-dev.

Coverage decreased (-0.7%) to 89.643% when pulling 2e621d5e4589f4e8b6318325390d6c3b06230221 on duteng:0.1.0-dev into 487e534388c52c0b30e1cd68c2b1aa69ef2b8677 on Microsoft:0.1.0-dev.


HHH-10601 - Persistence.generateSchema - the output file contains duplicated DDL statements

https://hibernate.atlassian.net/browse/HHH-10601

So the problem is that creating the SF kicked off "auto schema tooling"?

Yes, it is.

In SF constructor the
SchemaManagementToolCoordinator#process(...) Is call again.

Sounds reasonable then

applied to 5.1 and master


Import page contains bad markdown link.

See in production:
https://docs.superoffice.com/en/onsite/win-client/learn/import/updating-rules-for-duplicate-handling.html
https://github.com/SuperOfficeDocs/superoffice-docs/blob/main/docs/en/onsite/win-client/learn/import/updating-rules-for-duplicate-handling.md/#L1

Also here:
https://docs.superoffice.com/en/onsite/win-client/learn/import/resetting-rules-for-duplicate-handling.html


Application Exception: Twitter was not able to perform your query within the Timeout limit of 10000ms.

This is an issue created automatically by GrammarNazi when an exception was captured.
Date (UTC): 04/17/2021 15:42:09
Exception:
Reason : https://api.twitter.com/1.1/users/lookup.json?user_id=1262680558561353728%2C130595379%2C217457481%2C211511505%2C1322526472708464640%2C723688593454030848%2C1150086434918928387%2C91807741 request timed out.
Code : 408
Date : 04/17/2021 15:42:09 +00:00
URL : https://api.twitter.com/1.1/users/lookup.json?user_id=1262680558561353728%2C130595379%2C217457481%2C211511505%2C1322526472708464640%2C723688593454030848%2C1150086434918928387%2C91807741
Twitter documentation description : Twitter was not able to perform your query within the Timeout limit of 10000ms.

Twitter was down for a while, now is up


Improve usage guide

It would be great if you could provide usage examples for:

Adding and removing tests
Changing view contents based on which tests a user is part of

Thanks,
Will

Hello @williamoverton
The main use is to add some cookie value, for single-page applications.
Since they do not have the ability to accurately determine the rotation of their experiments and in this case rely on the back-end.
// example for middleware

$experiment = new Experiment('AB_YOUR_KEY');

$experiment->startAndSaveCookie([
        'red_button' => 60,
        'blue_button' => 30,
        'black_button' => 10,
]);

return $next($request);

After the request, you can get this value, for example in JS:
// Get value from cookie string
let cookieButtonValue = document.cookie.replace(/(?:(?:^|.*;\s*)AB_YOUR_KEY\s*\=\s*([^;]*).*$)|^.*$/, "$1");

// Very conditional example
if(cookieButtonValue == 'red_button') {
  document.getElementById('myButton').className = 'btn-red';
}

if(cookieButtonValue == 'blue_button') {
  document.getElementById('myButton').className = 'btn-blue';
}

//...etc

In order to remove the experiment you just need to remove you do not need the value from the array. And new users will not be assigned this cookie.


Update index.md

Fix typos on index page

Hi @msetze01, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@msetze01 Thanks for the contribution. I reviewed the content changes, and they look great.
I think the build failure is on our end. I'm investigating that now. Once it passes, LGTM.
Thank you again.

Hi @msetze01, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@msetze01 I closed / reopened this, hoping that would trigger a rebuild. It didn't. sigh. Can you push a change to trigger one? (It can even be a whitespace change).
Thank you.


How are aliases handled?

Let's say I have a page called Page-1 with an alias pager.
If I type Page-1 anywhere, then as soon as I hit enter, then Page-1 get automatically converted into a wikilink [[Page-1]].
I would have thought that if I type pager and hit enter, then pager would automatically gets converted into a wikilink [[pager]]. But it does not.
Sure enough, if I myself type [[pager]] it is a link that when clicked on takes me to the page called Page-1.
But I do not want to have to remember to type the square brackets myself; in fact, it requires me to remember all the aliases I have created, and that's not possible - I thought Automatic Linker does that for me.
So, what am I missing?

Great plugin. It would be a welcome addition if aliases were also included.

Aliases are catered for but the first time I put an alias on a page say PageA with an alias of myfirstpage and then referred to the alias in my journal and used Cmd P to parse the line it did not pick it up however when I left the journal page and returned and tried it again it worked so it may be a caching issue. Othere than that glitch aliases are working fine

aliases are working fine

So, what is wrong with the way I expect the plug-in to work as I describe above?

I tried your example in 9.15 and it works so don't understand your issue
On Sun, 10 Sept 2023, 5:55 pm DutchPete, @.***> wrote:

aliases are working fine
So, what is wrong with the way I expect the plug-in to work as I describe
above?
—
Reply to this email directly, view it on GitHub
https://github.com/sawhney17/logseq-automatic-linker/issues/60#issuecomment-1712743490,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5V4HIN553MBWLMZYR6LY3XZVW7FANCNFSM6AAAAAAZFBKXPY
.
You are receiving this because you commented.Message ID:
@.***>

I just reinstalled the plug-in, and this is what I get:

Every letter is transformed into a wikilink!
Someone opened an issue for this, so others have experienced this too.

I just installed the plugin and using 9.15 on Mac which seems to work. I
can't check it out on mobile as no plugin support.
Hopefully Sawney can get the problem sorted out.
Only thought I have is do a re-index which will rebuild any indexes and see
if that fixes it.
Success!
On Sun, 10 Sept 2023, 6:33 pm DutchPete, @.***> wrote:

I just reinstalled the plug-in, and this is what I get:
[image: image]
https://user-images.githubusercontent.com/10794265/266824400-78b42edd-d035-4cf9-9de4-4e6fa3cf3de2.png
Every letter is transformed into a wikilink!
Someone opened an issue for this, so others have experienced this too.
—
Reply to this email directly, view it on GitHub
https://github.com/sawhney17/logseq-automatic-linker/issues/60#issuecomment-1712752235,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5V4HLKAVGGT4DJLB7ZCH3XZV3PJANCNFSM6AAAAAAZFBKXPY
.
You are receiving this because you commented.Message ID:
@.***>

I don't Sawney is working on this anymore, seems like it has become abandonware.
I uninstalled it.

That's a shame .. let's hope he picks it up again. It's my favourite plugin
On Sun, 10 Sept 2023, 7:31 pm DutchPete, @.***> wrote:

I don't Sawney is working on this anymore, seems like it has become
abandonware.
I uninstalled it.
—
Reply to this email directly, view it on GitHub
https://github.com/sawhney17/logseq-automatic-linker/issues/60#issuecomment-1712765553,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5V4HOIXOR3DMBDLZUZ7XTXZWCIVANCNFSM6AAAAAAZFBKXPY
.
You are receiving this because you commented.Message ID:
@.***>

I agree it is a good plug-in, in principle. It was 1 of the 1st I installed when I started using Logseq. Alas ……

Btw .. what platform are you using?
On Sun, 10 Sept 2023, 7:35 pm DutchPete, @.***> wrote:

I agree it is a good plug-in, in principle. It was 1 of the 1st I
installed when I started using Logseq. Alas ……
—
Reply to this email directly, view it on GitHub
https://github.com/sawhney17/logseq-automatic-linker/issues/60#issuecomment-1712766420,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5V4HKRQ5U7WWMLKHSBJTTXZWCVDANCNFSM6AAAAAAZFBKXPY
.
You are receiving this because you commented.Message ID:
@.***>

macOS 13 Ventura.

I'm on Mac too so I'll see if I can recreate the weird output. If I can
recreate it I'll have a go at finding the bug 🙂
On Sun, 10 Sept 2023, 8:39 pm DutchPete, @.***> wrote:

macOS 13 Ventura.
—
Reply to this email directly, view it on GitHub
https://github.com/sawhney17/logseq-automatic-linker/issues/60#issuecomment-1712778738,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5V4HLLP22NJUORCBUCQIDXZWKHLANCNFSM6AAAAAAZFBKXPY
.
You are receiving this because you commented.Message ID:
@.***>

@adxsoft thanks. Have a look at issue #62.

Thanks, I'll check it out.
On Sun, 10 Sept 2023, 8:46 pm DutchPete, @.***> wrote:

@adxsoft https://github.com/adxsoft thanks. Have a look at issue #62
https://github.com/sawhney17/logseq-automatic-linker/issues/62.
—
Reply to this email directly, view it on GitHub
https://github.com/sawhney17/logseq-automatic-linker/issues/60#issuecomment-1712780073,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5V4HN7MP4RDGUNSVHS4VDXZWK77ANCNFSM6AAAAAAZFBKXPY
.
You are receiving this because you were mentioned.Message ID:
@.***>

This was fixed.  I sent a fix to the author and he re issued the plugin
which I installed and works perfectly fine.
On Thu, 29 Feb 2024, 8:02 pm DutchPete, @.***> wrote:

I opened this issue 8½ months ago and the dev has not stepped up once, so
I guess my Sep 10, 2023 assessment of this plugin being abandonware was
correct.
—
Reply to this email directly, view it on GitHub
https://github.com/sawhney17/logseq-automatic-linker/issues/60#issuecomment-1970697224,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5V4HIVNFAS3EQLMR2UAFDYV3XDRAVCNFSM6AAAAAAZFBKXP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQGY4TOMRSGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@adxsoft OK, thanks.


Fix LocalizationResourceManager.Init(ResourceManager, CultureInfo) doesn't trigger property changed

Description of Change
Currently Init overload with CultureInfo sets CurrentCulture, but PropertyChanged event doesn't get triggered.
Fixed that.
Bugs Fixed
Fixes: #916
API Changes
None
Behavioral Changes
When LocalizationResourceManager.Init(ResourceManager, CultureInfo) is called PropertyChanged is triggered.
PR Checklist

[x] Has tests (if omitted, state reason in description)
[ ] Has samples (if omitted, state reason in description)
[x] Rebased on top of main at time of PR
[x] Changes adhere to coding standard

[ ] Updated documentation

@maxkoshevoi can you please create an issue and link it here?

@maxkoshevoi can you please create an issue and link it here?

Done


Feature Dimension of Each Ego-network

Hello author, how did you get X in the Facebook dataset? The feature dimension of each ego-network is different from the original dataset.

Hi, we only select the attributes that the ego node in the ego network has (whose value is equal to 1 in *.egofeat). To be honest, I don't really remember the reason for this since I worked on the project a long time ago - either the same procedure was used in the original CESNA implementation, or some of the baselines scaled extremely poorly with the # of attributes, so we had to reduce their number.


How to combine the multi-thread mode of Tokio

Tokio-uring uses a single thread. If I want to use hyper and tokio-uring to implement a file server service, how to combine tokio's multi-thread runtime to improve the overall QPS?

The normal way is using message passing instead of direct function calls. You can learn about actor model, actix is a good framework using it. Here's a simple example showing how the message passing works:
use std::rc::Rc;
use tokio::sync::{mpsc, oneshot};
use tokio::task::LocalSet;

#[derive(Debug)]
pub struct UringRequest {
    tx: oneshot::Sender<UringResponse>,
}

#[derive(Debug)]
pub struct UringResponse {}

struct Uring {
    field1: Rc<usize>,
    req_rx: mpsc::UnboundedReceiver<UringRequest>,
}

impl Uring {
    async fn run(mut self) {
        LocalSet::new()
            .run_until(async move {
                while let Some(req) = self.req_rx.recv().await {
                    // do some thing
                    req.tx.send(UringResponse {}).unwrap();
                }
            })
            .await;
    }
}

pub struct App {
    uring_tx: mpsc::UnboundedSender<UringRequest>,
}

impl App {
    pub fn run(self) {
        // tokio::spawn(uring.run());
    }

    pub async fn foo(&self) -> UringResponse {
        let (tx, rx) = oneshot::channel();
        let req = UringRequest { tx };
        self.uring_tx.send(req).unwrap();
        rx.await.unwrap()
    }
}

You can see, Uring is !Send and !Sync, but App is Send and Sync. So App can be used in tokio's multi-thread runtime.

I've tried using channel for file read and write collaboration between tokio-uring and tokio's multi-thread runtimes, but the performance is no better than tokio::fs.

@silence-coding You should do some profiling to make sure which part is the bottleneck.

@songzhi OK, I'd like to ask if tokio-uring has any plans to switch to multi-thread mode? Or when will it be released as a future of tokio


Disable minification

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [X] feature request

Versions.

@angular/cli: 1.0.0
node: 6.10.0
os: win32 x64
@angular/common: 2.4.10
@angular/compiler: 2.4.10
@angular/core: 2.4.10
@angular/forms: 2.4.10
@angular/http: 2.4.10
@angular/platform-browser: 2.4.10
@angular/platform-browser-dynamic: 2.4.10
@angular/router: 3.4.10
@angular/cli: 1.0.0
@angular/compiler-cli: 2.4.10
Desired functionality.

There is a way to disable the minification in AngularCli?
After I launch the command ng build I need to have all files.js, in dist folder, separate and legible.
Mention any other details that might be useful.

Like happens in SystemJs configuration.

@Danieleeee By default Angular CLI builds are generated in dist folder configured in .angular-cli.json which you can change as well. Running ng build will generate build in dist folder which is not minified if you want minified build you need to run ng build --prod.

Hi @sumitarora ,
ng build have the same result of ng build --prod, only one file.js with all components.
I need one file.js for each component, like SystemJs do.

@Danieleeee, that's not how Webpack works. It's a module bundler, which, by definition, takes your separate modules and outputs a bundle. What is your use case that you need separate files output? Are sourcemaps not sufficient?

I work with many Components (like forms).
In the porduction is much more functional to update only the component that you want to update(change).
Instead with this configuration I have to buld and update all Components everytime.
How can be useful sourcemaps in this situation?

I think there's still either a misunderstanding here about how Webpack works or how to use it.  Are you running in watch mode? Webpack is smart enough to watch the filesystem and only rebuild things which have changed. It outputs everything to a single bundle, but that doesn't mean it rebuilds everything every time. You should see that the initial build takes a while and subsequent builds are reasonably fast.

I know that watch mode (-w) rebuild only things that are changed. But I think it's useful during the development phase. Not for update in production.
If I create the build today and I want to upgrade a component after a week, I have to leave the watch mode active for all the time?

@Danieleeee if you have to make a change you will need to redeploy all of your bundles.

Not sure what problem you're trying to solve here. You don't want to do a full rebuild for a new production deployment? That seems like a non-issue unless you're redeploying production every few minutes... in which case I'd argue for a change in your process over a change in angular-cli. In any case, the use case is not supported; again, webpack is a module bundler :)

webpack is a module bundler :)

If I have several modules, webpack make only one main bundle?
I tell you this because each of my components is a mudule (@NgModule) with its own routingModules.

I have a similar behavior with route lazy loading, but files have incomprensible name (like 0.chunk.js, 1.chunk.js,....).

There's a difference between ngModule and ES modules. Check out https://angular.io/docs/ts/latest/cookbook/ngmodule-faq.html#!#q-ng-vs-js-modules for lots of good info on this and other ngModule topics.
You can also read up on "output" and CommonChunks on the webpack website for more information. Remaining questions around this general usage would be better suited for Stackoverflow.
Hope this helps!

@Danieleeee the way the build system in the CLI works, everything gets bundled. I understand that in some cases you might not want that, but overall it's not optional (in the CLI) and usually better to bundle. It allows for a smaller total load time.
The only time you will get more than one bundle is when you have lazy loaded routes - the CLI will detect that and make separate bundles automatically.
For a CLI application, when making changes, you would always redeploy the generated build artifacts.

How to unbundle the app.bundle.js file in angular?


_data/origin/basic.yml has incorrect filenames for dayjs.

Checklist

[X] I have read and accepted the contributing guidelines.

How did you create the site?
Generated from chirpy-starter
Describe the bug
The file _data/origin/basic.yml contains the following for dayjs:
dayjs:
  js:
    common: /assets/lib/dayjs/dayjs.min.js
    locale: /assets/lib/dayjs/locale/en.js
    relativeTime: /assets/lib/dayjs/plugin/relativeTime.js
    localizedFormat: /assets/lib/dayjs/plugin/localizedFormat.js

if the following is specified in _config.yml, then these files seem to break.
assets:
  self_host:
    enabled: yes
    env: production

The files on disk seem to end up as:
$ find assets/lib/dayjs/
assets/lib/dayjs/
assets/lib/dayjs/dayjs.min.js
assets/lib/dayjs/locale
assets/lib/dayjs/locale/en.min.js
assets/lib/dayjs/plugin
assets/lib/dayjs/plugin/localizedFormat.min.js
assets/lib/dayjs/plugin/relativeTime.min.js

I'm confused as to why this doesn't seem to match here:
https://github.com/cotes2020/chirpy-static-assets/tree/main/dayjs/plugin
Given the .gitmodule file references the following:
[submodule "assets/lib"]
	path = assets/lib
	url = https://github.com/cotes2020/chirpy-static-assets.git

and this seems to be up to date, how / where are these files getting minimised?
If I disable the self_host options, then these same assets load from the CDNs correctly with the filenames expected.
Steps To Reproduce
I build the site with the following script:
#!/bin/bash
export JEKYLL_ENV=production
export RUBY_YJIT_ENABLE=1

echo; echo " - Updating bundles..."
bundle update
git submodule update

echo; echo " - Cleaning current data..."
bundle exec jekyll clean

echo; echo " - Building site..."
bundle exec jekyll build

if [ ! -d "_site" ]; then
    echo "Error: Site build failed..."
    exit 1
fi

Expected Behavior
That files on disk match files in the CDN with the minified versions if applicable.
Environment

Ruby: ruby 3.3.4 (2024-07-09 revision be1089c8ec) [x86_64-linux]
Jekyll: jekyll 4.3.3
Chirpy:

jekyll-theme-chirpy (7.1.0)
Summary: A minimal, responsive, and feature-rich Jekyll theme for technical writing.
Homepage: https://github.com/cotes2020/jekyll-theme-chirpy
Documentation: https://github.com/cotes2020/jekyll-theme-chirpy/#readme
Source Code: https://github.com/cotes2020/jekyll-theme-chirpy
Wiki: https://github.com/cotes2020/jekyll-theme-chirpy/wiki
Bug Tracker: https://github.com/cotes2020/jekyll-theme-chirpy/issues
Path: /home//.local/share/gem/ruby/gems/jekyll-theme-chirpy-7.1.0

Anything else?
No response

Google how to update the git submodule to solve your problem, thanks.


Chromium based wallet detection

I am always having issues getting the bridge sites (new and old) to connect to the Pali app on multiple pcs, as it will continually prompt over and over and never realized that its connected to the site even when it is, also see a fair amount of people in the syscoin support saying the same thing.
It always happens on windows 10, brave/chrome (chromium) and always seems to work fine in firefox. the only thing i can find is:

and

Usually end up using firefox, and telling others to use firefox instead. if you want more info i can try and find some more info.

hey @nrhs05, thanks for reporting. we are looking into bridge/dapp and trezor issues and as soon as we have a new version i'll send here for you to test, probably today or tomorrow 😄

closing for now, i'll reopen when we have the zip file ❤


Added Mayhem support

Added Mayhem support to the acpi project.
Integration was standard on this project, as some fuzzing binaries were already created by the maintainers of the project. A Dockerfile was added to compile the fuzzing binary, and a Mayhemfile and GitHub actions file were added to perform the Mayhem fuzzing tests.
One small change was added to the source code in aml/fuzz/fuzz_targets/fuzz_target_1.rs, the fuzzing file compiled to the binary. This file has not been updated in a while, and a call of a function was changed to use a new function signature. It is likely the project has not been fuzzed in some time.

LGTM!


Add a way of limiting the range of the ephemeral ports that are bound to by gather_candidates

Hi!
Inside get_component_candidates under the Connection class, the local UDP ports are randomly selected by the kernel, since 0 is provided as the port to create_datagram_endpoint. I have a use-case where I need this port range to be limited. Indeed, it's possible to limit it on the whole machine, by setting the /proc/sys/net/ipv4/ip_local_port_range under Linux. However, I need this to be controllable at a more fine grained level.
Could an addition of some kind of allowed_port_range flag be considered? In the implementation, this would require manually trying to bind to ports in the range until success.
Thanks!

The use case is essentially a Matrix bridge (bot) that forwards cellular voice calls from a GSM modem to a Matrix chatroom. Matrix uses WebRTC for calls.
The bot usually sits behind a residential connection (where the GSM modem is physically located), that is, behind a NAT that can be controlled via a web interface or UPnP (to define port forwarding). The other side of the connection is the user, who can be anywhere (assume a CGNAT of some kind).
In my mind, it should be far more reliable to offer the option of setting up manual port forwarding on the bot side. This way there is basically no need to fully rely on STUN. To do this, it is necessary to define a small port range that will be port-forwarded, and thus to limit the local ports to be selected from this pre-defined range.
When I have more time for this project, I'll get back here with a PR. Thanks!

This would also make is much easier to run in a docker container where all ports must be published in advance.

Any chance of a PR for this?

I took a stab at an implementation https://github.com/aiortc/aioice/pull/63

@gregvish any opinion on https://github.com/aiortc/aioice/pull/63 ?
Does it cover all your issues?


Write diff editor inline/side-by-side preferences to user settings

VSCode Version: 1.9.0
OS Version: Windows 10 Enterprise

Steps to Reproduce:

Initialize a git repository with a file and perform an initial commit.
open folder in vscode.
Make changes to the file.
Press Ctrl+Shift+G and click on the file to see the diff.
Switch to inline view.
Press Ctrl + to make the font appear larger (or Ctrl - for smaller)

Observed behavior:

The editor switches back to side by side view.
In screenshot attached see the options. The view is side-by-side diff but the options still say switch to side-by-side view. Note that the wrong options only appear when I zoom in or out.

@alexandrudima I am not finding this issue anymore but I think you had one for making the diff editor toggle a real user setting?

Still seeing the issue. My problem is not when zooming but when changing in between modified files.

VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-09T00:26:45.394Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

csharp
ms-vscode
1.7.0

PowerShell
ms-vscode
0.9.0

Steps to Reproduce:

Initialize a git repository with at least two files and perform an initial commit.
Modified both files.
Go to see the diff in the GIT section.
Switch to inline view.
Now click on the second file to see its diff.

Observed behavior:

The editor switches back to side by side view.
The toggle options are wrong, same way as in the screenshots by preetsaimutneja.

Should I open an independent issue since it is a bug for me?
Also I agree with the feature request.

Manual workaround: Change your settings by setting the following: "diffEditor.renderSideBySide": false
Source


E2e claiming with chain scanning

Description
Fixes issue with bitcoin claiming where it wasn't using the correct path under ledger.

Missed pushing this commit on PR #74


Fix: Progress bar does not follow drag #789

This PR fixes issue #789 and the following bugs that were uncovered as a result of fixing it:

Due to using Duration.zero as an invalid value, the pointer's behavior at the left edge of the progress bar was unnatural.
The pointer was able to go beyond the confines of the progress bar.

That is not related to the changes in this pull request. It appears that there is a lint issue in the code of the master branch.

Still though. Since I have release authority on this repo, I need to be able to have everything green prior to delaying it to pub.dev.
Once your changes are merged (along with the lint issue), then every other PR will have to re-sync to that lint fix.


jenv: no such command `install' ,how do I install jdk 1.7 or 1.6 by jenv

➜  ~  jenv doctor
[OK]	No JAVA_HOME set
[OK]	Java binaries in path are jenv shims
[OK]	Jenv is correctly loaded
➜  ~  jenv install
jenv: no such command `install'
➜  ~  jenv commands
--version
add
commands
completions
disable-plugin
doctor
enable-plugin
exec
global
global-options
help
hooks
info
init
javahome
local
local-options
options
options-file
options-file-read
options-file-write
options-origin
plugins
prefix
refresh-versions
rehash
remove
root
shell
shell-options
shims
version
version-file
version-file-read
version-file-write
version-name
version-origin
versions
whence
which
~/.zshrc
export PATH="$HOME/.jenv/bin:$PATH"
eval "$(jenv init -)"

I install jenv  by  : brew install jenv
this is version:
➜  ~  jenv --version
jenv 0.4.0

There is no way to install JDK with jenv,  you have to do it manually.
After you can use it with jenv add

oh , I thought it has method of install . I'm wrong.
thx.


L1 icache and dcache on M1 are the same sysctl

https://github.com/klauspost/cpuid/blob/e32428e6729530015b46da6a4eafce536b19de49/os_darwin_arm64.go#L85-L86
It's not clear if this was intentional, but it seems possible to get the dcache value on macOS. Currently both L1I and L1D are filled from the same sysctl.

@ironiridis I do not have access to HW, nor MacOSX, so you are welcome to send a PR with tested changes.


mgmt/imgmgr: Replace SHA256 with SHA1 for data SHA

This changes SHA256 to SHA1 to be used for data check before allowing
image upload to be resumed.

@bgiori fyi

Could as well use crc16 and use only 2 bytes if security is not a concern! :-P

Sure, except I think hash function fits better here :-)
I mean, I do not think we need anything fancy here since this is to check that client tries to resume upload of the same image. I just have no idea what is reasonable to use here so went with the most obvious (I think) SHA hash. But I am happy to change it to anything most people will agree on.

You can also truncate SHA256, it is perfectly valid to truncate it down to as few as 128 bits which still gets you better collision protection in fewer bits than SHA1 (and smaller code size, if you already use SHA256 elsewhere).

Agree with Simon,  we should not promote known broken hash functions :-)

yeah, Simon's proposal absolutely makes sense to me. the only question is if we should just have this fixed on 128 bits or allow both full or truncated sha - just to avoid some problems in future in case we need to scale it again ;-)

I updated this PR to:

have sha field name for hash instead of datahash (this will be used by newtmgr as previous name caused issues with mcuboot)
accept full SHA256 or value trimmed to 1/2 or 1/4 of original size

I hope 2nd change makes sense :-)

@ccollins476ad I can change it to accept anything that has at least let's say 4 or 8 characters - it works for me perfecly. I am just not sure if it makes sense in terms of how SHA works... but actually, do we really care? this is just informational anyway :-)

I am just not sure if it makes sense in terms of how SHA works

If using only for integrity checking, should be perfectly OK to use 2, 3, 4, whatever number of bytes: https://en.wikipedia.org/wiki/Avalanche_effect

Just remember about collision frequency, that's still a function of the number of bits. With two bytes, there's a 1 in 256 chance of a collision completely at random. Obviously there is still the signature check, but this may just be frequent enough to cause annoying errors in the wild.

@simonratner True (but shouldn't that be 1 in 65536?).  But I'm just wondering if it is the firmware's place to enforce a minimum hash length.  The hash field is optional as it is; why not let the client decide how much to include?

Good point, @ccollins476ad. Also if needed this length will be only adjusted in single client (newtmgr or whatever other app is used) without worrying about compatibility.


Generate staging DB with fake data

added a couple of CRUD functions
for details of the fake data generation, see the comments in data_faking.py
init.sql is updated such that it contains only the data generated by the Minimal, DemoUsers, and Cypress PHP scripts in https://github.com/boxwise/dropapp/tree/5ae4408163e963f479c6ea33788c7993c8f00be5/db/seeds

Functional test:

docker compose up --build webapp then
curl 'http://localhost:5005/cron/reseed-db' -H 'x-appengine-cron: true'

Needs clarification:

how realistic do datetime fields need to be? currently they reflect the time the script runs

 2.0 Data faking for test DB seed


Update Electron to v4

This updates Electron to the latest v4 version available.
The change only affected the package.json, package-lock.json, and the rule for asterisks in the form css.

I'm creating a new PR for this based on the latest master so we don't have a bunch of awful merge conflicts.


Add backport workflow to cherry-pick PR merge commits to other long-lived branches

Taking a look at the backport Action.

GitHub token with issue, comment, and label read/write permissions

It looks to be covered by the default permissions for GITHUB_TOKEN.
I'm guessing that the Action does require extra permissions since all other instances of the workflow are using PATs or apps but we can test this by merging this PR and trying a backport.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6925666) 79.32% compared to head (db1639c) 45.06%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #553       +/-   ##
===========================================
- Coverage   79.32%   45.06%   -34.27%
===========================================
  Files          69       67        -2
  Lines        5828     5650      -178
===========================================
- Hits         4623     2546     -2077
- Misses        984     2953     +1969
+ Partials      221      151       -70

Flag
Coverage Δ

integration-test
?

unittests
45.06% <ø> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How to use older versions

Please add how to use older versions to docs/index.md and README.md

]add<EMAIL_ADDRESS>


Import requirements.txt / setup.py Projects

It's quite hard to get started with rye today if one does not have a pyproject.toml project. A possible way would be to have a rye init --import command that takes an existing project and makes it work with rye.

#103

This would actually be nice for me assuming poetry export gets me what I'd want here. Ideally I could export to requirements and then rye init --import all my poetry-managed projects.
I need to do a little research to better understand the lift here, but assuming it's how I'm imagining it will be, I'd be interested in tackling this.

There is also an alternative world where we support setup.py entirely and just dump a pyproject.toml next to it with custom config. Not sure if that's a good or bad idea. FWIW I'm open for anything just to get the ball rolling and explore from there.
We could start feature gating some more experimental features so there is more freedom to explore.

where we support setup.py

Do you mean allow for the package to build and then pull its metadata from the distribution? I like that better tbh.

Not sure if that's a good or bad idea

One thing that comes to mind so far is that if the user doesn't know to maintain core metadata in the pyproject.toml it might cause some confusion since, iirc, most backends will prioritize the pyproject.toml for metadata.

Since pyproject.toml is also used to just configure tools like black i think the ecosystem has mostly evolved to disregard partial pyproject.toml files.

I found that PDM has a script similar to parse setup.py as a reference: https://github.com/pdm-project/pdm/blob/main/src/pdm/models/in_process/parse_setup.py

Wanted to report this here since it's relevant. I might create another issue for it to PR it if I can get some time.
If you add dev dependencies to a pyproject.toml that isn't originally managed by rye, the tool section initializes like this
[tool]
rye = { dev-dependencies = [
    "pytest>=7.4.0",
] }

Idk how others feel about this topic, but I'd like that initial setup to look something like
[tool.rye]
dev-dependencies = [
    "pytest>=7.4.0"
]

I'm closing this as resolved for now as init can import basic project snow.

fwiw, I found rye add $(pip freeze) && rye sync to work with no major issues, aside from having to bump requires-python in pyproject.toml from time to time

Personally I've thought about using uv under the hood for some imports.
Also, from what I can tell, there's a lot of focus on environment reproducibility. That might tie into project import capabilities.

I'm lost on how to actually use a requirements.txt file with rye.
I've tried rye init and had no luck, it just installed an empty project in my existing project. rye init --import says it has an unexpected argument. I also tried source .venv && python -m pip install -r requirements.txt, but the version of python that rye installed doesn't come with pip.

I believe you want rye init -r requirements.txt, then rye sync. (You shouldn't run pip commands with Rye; Rye intentionally omits pip from the created virtual environment.)

Wanted to report this here since it's relevant. I might create another issue for it to PR it if I can get some time.
If you add dev dependencies to a pyproject.toml that isn't originally managed by rye, the tool section initializes like this
[tool]
rye = { dev-dependencies = [
    "pytest>=7.4.0",
] }

Idk how others feel about this topic, but I'd like that initial setup to look something like
[tool.rye]
dev-dependencies = [
    "pytest>=7.4.0"
]

How does one switch to Rye from existing pyproject.toml, though? rye init --help doesn't tell how to import an existing pyproject.toml. I previously used PDM, and its dev-dependencies look like:
[tool.pdm]
[tool.pdm.dev-dependencies]
dev = [
    "pytest>=7.3.1",
    "pytest-asyncio>=0.21.0",
    "httpx>=0.24.0",
    "pre-commit>=3.2.2",
    "black>=23.3.0",
    "isort>=5.12.0",
    "mypy>=1.2.0",
    "sqlalchemy-stubs>=0.4",
    "pep8-naming>=0.13.3",
    "ruff>=0.0.264",
    "safety>=2.3.4",
    "coverage>=7.2.5",
]

[tool.pdm.scripts]
_.env_file = ".env/import_dev.env"


Envoy self health check endpoint

We are thinking about putting envoy behind a Google load balancer as the front proxy layer for our service cluster. GLB (Google load balancer) requires a HTTP health check endpoint and I haven't found a way in envoy to configure a path that just returns a 200 without hitting any real backend service. This check is essentially saying that the envoy proxy layer is up and running and the frontend load balancer can route traffic to it. Any ideas?

You need to setup healthcheck filter on http connection manager with pass_through_mode: false
{
                "type": "both",
                "name": "health_check",
                "config": {
                  "pass_through_mode": false,
                  "endpoint": "/healthcheck"
                }
              },

https://lyft.github.io/envoy/docs/intro/arch_overview/health_checking.html?highlight=pass through#http-health-checking-filter

reach out to https://gitter.im/lyft/envoy if there are any questions/issues. Closing this issue for now.


does client.add seed after completion?

client.add does is not seeding after the torrent is done. It does show up as a Peer, but none of the other peers seem to be able to connect to it.
Do I have to do anything special after the torrent is done or should I begin an explicit client.seed after the torrent is done? Does DHT need to be set to true?

client.add automatically seeds during and after the download is complete.
I assume you're using WebTorrent in Node.js. WebTorrent currently doesn't support the traditional methods of NAT hole punching (UPnP and NAT-PMP) that most torrent clients support. There's an issue about this here: #195. This might explain why peers outside your local network are unable to connect to your client.
As a workaround, you can set up Port Forwarding on your router.


Allow mouse cursor to be visible while video plays, click video to pause/unpause

Is your feature request related to a problem? Please describe.
We have a site where we mostly have quick videos. It is pretty annoying to our users that the mouse cursor disappears on hovering the videos, also that they can't click to pause.
Describe the solution you'd like
An option to stop disappearing the mouse cursor when hovering the video, also allow click to pause.

Hi @sinni800, this seems to be a bug, as by default Fluid Player allows clicking the video to pause, and the mouse doesn't disappear. Can you provide us with a demo on Codepen with this issue? Feel free to look at the guidelines for bug reports for more help setting up the demo.

I checked the current state again, and it's all fine nowadays. I think the issue might have been caused by us stll using prototype js which mangled around in the global js namespace of the browser. I have in the meantime completely thrown prototype out of our site, going for a vanilla JS approach.
I completely forgot about creating this issue, I am sorry for the inconvenience.

Thanks for the response @sinni800, cosing the issue since it's not a problem anymore.


Bypass-mob-griefing does not let villagers breed.

Timings link
https://timings.pl3x.net/?id=90c2a97c86354b7b88d300fd969273ab
Expected behavior
When you turn off the gamerule "mobgriefing" then enable "Villager: Bypass-mob-griefing" in purpur.yml the villagers do not breed when they are given food and beds.
Observed/Actual behavior
After constantly turning on and off the gamerule, (With bypass on in config) is that breeding only works with "/gamerule mobgriefing true"
Steps/models to reproduce

Set "bypass-mob-griefing: true" under Villager:

do /gamerule mobgriefing true inside of console.

Go in game and try to build a 😳 chamber for them to breed.

Give villagers food.

Watch them breed

Purpur version
[01:06:33 INFO]: Checking version, please wait...
[01:06:34 INFO]: This server is running Purpur version git-Purpur-1390 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 161dcf0 on ver/1.17.1)
[01:06:34 INFO]: You are running the latest version
[01:06:34 INFO]: Previous version: git-Purpur-1385 (MC: 1.17.1)
Agreements

[X] I am running the latest version of Purpur available from https://purpur.pl3x.net/downloads.
[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] My version of Minecraft is supported by Purpur.

Other
If you need anymore information from me. Please feel free to ping me in your discord (Tyler ❤ #4117) I can show you my configs for plugins if needed also.

I dont understand.. Your reproduction steps, expected, and observed are all saying different things.
For villagers to breed they need food. Normally they get this food from farmers that grief the land. If mobgriefing gamerule is false then the farmers cant farm the land, but you can still give them food yourself. Turning on mobgriefing bypass is the same as turning on mobgriefing gamerule, its not used to turn it off.


Phaser 3.17 breaks on IE 11

Version

Phaser Version: 3.17.0

Operating system: Any windows OS

Browser: IE 11

Description

the following commit https://github.com/photonstorm/phaser/commit/e0f2b829f87567e3ccfb31bae17f12d802dddaf4#diff-bec4cf8bfff946115edd34836fa564bcR1192 contains es6 arrow functions that make their way into the final dist files. The es6 syntax breaks older browsers (in my case ie11) where phaser 3.16.2 was working.
Example Test Code
Execute the phaser.js file from the published dist directory in IE11 or any other older browser that does not support es6 and the bug will be reproduced.

Additional Information
I would suggest processing the src files with either typescript or babel when producing the dist folder and changing the main in the package.json to point to dist/phaser.js instead of src/phaser.js` .
I would be willing to make the change to the build pipeline myself and submit a pr if that is desired.

+1

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


moscow food coop manual migration

Moscow Food Co-op Collection, https://www.lib.uidaho.edu/digital/moscowcoop/
should be pretty straight forward!

There are also digitized photographs in this collection, tho not published bc waiting on more detailed metadata from co-op folks, should I include? or re-visit later?

@kxuidaho let's keep it as newsletters only for now.
We will bring up photo part of the project to digital collections team.

Finished!


chore: v1.0.3

:robot: I have created a release beep boop
1.0.3 (2023-10-24)
Bug Fixes

Disable react/no-array-index-key rule (56dde85)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Wondermarin/eslint-config/releases/tag/v1.0.3 :sunflower:


Good issue: We must change home page design

Home page must be like that, This design doent include ubnjr company logo, I will attached here too.

I sent you a link (private chat) which necessary for this issue, You can see components in canva , If you have a question for this issue pls tell us.


tf.nn.gelu raises an exception when 'features'.dtype is not a floating point tensor

Click to expand!
Issue Type
Documentation Bug
Source
source
Tensorflow Version
tf 2.10
Custom Code
Yes
OS Platform and Distribution
No response
Mobile device
No response
Python version
3.9
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
tf.nn.gelu raises an exception when 'features'.dtype is not a floating point tensor. The documentation does not mention this requirement.
https://www.tensorflow.org/api_docs/python/tf/nn/gelu

A suggestion is to revise the docstring of 'features', or add a 'Raises' section to tf.nn.gelu documentation.

Issue#54475 and PR#54550 previously discussed about input types. A change was made in the code but not in the documentation.
Standalone code to reproduce the issue
x = tf.constant([-3, -1, 0, 1, 3])
y = tf.nn.gelu(x)

Relevant log output
ValueError: `features.dtype` must be a floating point tensor.Received:features.dtype=<dtype: 'int32'>

@gadagashwini I was able to replicate the issue on colab, please find the gist here. Thank you!

Hi @Ingkarat, Please take a look at this link. Thank you!

Thank you @gadagashwini. Would it be better to mention this floating requirement in the documentation? maybe as part of features's description?

Hi @Ingkarat ,
The document has been updated in Master branch.You may find it here.
https://github.com/tensorflow/tensorflow/blob/b1114184259910626a2c51802be9fd87eac1ad1c/tensorflow/python/ops/nn_ops.py#L3719-L3720
Also find the section Raises which is added in Master branch.
https://github.com/tensorflow/tensorflow/blob/b1114184259910626a2c51802be9fd87eac1ad1c/tensorflow/python/ops/nn_ops.py#L3728-L3729
The changes also may be reflected in tensorflow.org documentation with the next release.
Thank you for the suggestion and hope this is as per your expectation.Please feel free to close the issue if it resolved the purpose of this issue. Thanks!


[HUDI-6675] Fix Clean action will delete the whole table

Change Logs
Clean action.
Avoid to clean the whole table data on hdfs .
Impact
Clean action.
When it is a non-partition table,  Clean action will input the ""  as partition path , this will lead to Cleaner   to clean the whole table data on the  hdfs . path format is table_basepath  + "/" + ""
so, when path is "", it means this clean action should not delete  dir, just skip it;
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

In my company, I also encountered a situation where the entire table directory was deleted

@wqlsdb , would you mind to cherry-pick this fix into your local repo?

In my company, I also encountered a situation where the entire table directory was deleted

Hi @wqlsdb would you like to discuss it offline or email?
We encountered this issue multiple times internally, and we are trying to find the root cause. Think it could be helpful if we can find sync some common information.

@danny0405  yes.Our company plans to upgrade to the latest version

@TengHuo  ok my email<EMAIL_ADDRESS>


Add user docs for Turing/Turing SDK

In PR #164, PR #165, PR #170 and PR #171, an automated pyfunc ensembler building feature was introduced for Turing. This PR introduces a small section to guide users on how this feature can be used when deploying routers via the UI.
In addition, this PR also adds new documentation for router deployment using Turing SDK, which was introduced in PR #148, PR #152, PR #155.
Additions

docs/* - Addition of pyfunc ensembler deployment using Turing UI
sdk/docs/* - Addition of new documentation for router deployment using Turing SDK

Fixes

Tiny code cleanup to Turing SDK

Thanks a lot for the thoughtful comments @krithika369 ! I'll be merging this! 🚀


restore service container after tests

Umph, a test I added recently had some unintended consequences, breaking subsequent tests. Not sure why it didn't show sooner.
In the test, the ServiceContainer was changed, but not reset, leading to missing configuration data downstream (mocked adapter, mocked table maps, etc.) and around 40 failing tests with weird error messages.
Pretty stoopid...

Codecov Report

Merging #1879 (68a99f5) into master (0fd64ee) will decrease coverage by 20.62%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #1879       +/-   ##
=============================================
- Coverage     87.61%   66.99%   -20.63%
  Complexity     7814     7814
=============================================
  Files           227      227
  Lines         21160    21070       -90
=============================================
- Hits          18540    14115     -4425
- Misses         2620     6955     +4335

Flag
Coverage Δ

5-max
66.99% <ø> (-20.63%)
:arrow_down:

7.4
66.99% <ø> (-20.63%)
:arrow_down:

agnostic
66.99% <ø> (ø)

mysql
?

pgsql
?

sqlite
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fd64ee...68a99f5. Read the comment docs.


Suggestion for alternative navigation

Thanks for a great app! I use it all the time. However I've always secretly been hoping someone would update it with the following keybindings.
Right arrow - Show logs
Left arrow - Details view (single view)
Enter - Action menu... Stop, restart, exec, etc.

added in https://github.com/bcicen/ctop/pull/132; to be included with the next release


protobuf build.rs sometimes fails

I am finding that when testing prost, about half the time, the protobuf build fails, with the following, inside the protobuf make process:
ar: `u' modifier ignored since `D' is the default (see `U')
In file included from binary_json_conformance_suite.h:34,
                 from binary_json_conformance_suite.cc:31:
conformance_test.h:49:10: fatal error: conformance.pb.h: No such file or directory
 #include "conformance.pb.h"
          ^~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:908: conformance_test_runner-binary_json_conformance_suite.o] Error 1
make: *** Waiting for unfinished jobs....
thread 'main' panicked at 'failed to make conformance', protobuf/build.rs:182:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

I find that it always succeeds if I do this, in the protobuf/build.rs:
        let rc = Command::new("make")
            .arg("-j")
            .arg("1") // Note: 1 instead of NUM_JOBS to work around bugs in makefile
            .arg("install")
            .current_dir(src_dir.join("conformance"))
            .status()
            .expect("failed to execute make conformance");
        assert!(rc.success(), "failed to make conformance");

Would you be interested in a patch like this?

Interesting, can you repro this just with protobuf?  I don't want to limit parallelism on the build since building the conformance tests is already so slow, it would make CI even worse.  If you can repro just on the protobuf repo you can file a bug with them.  It looks somewhat similar to this workaround I had to introduce: https://github.com/danburkert/prost/pull/191/files

Also might be worth seeing if it's an issue with the latest protobuf; we can always bump the bundled protobuf version in prost.

sounds good, will write back

I switched prost over to using CMake when building protobuf, so hopefully this is no longer an issue.  Please feel free to re-open if it's still failing on latest prost master.


Avoid TokenListHolder bind tokenIcon crash

Fixes #2643
Not able to reproduce the bug. Added exception handler to avoid app crash

Let's also fix the get name issue so that when the token with null name comes, something will be displayed (blank circle perhaps, or icon if it's there).

@JamesSmartCell the getName is going to be called by bindData which we have just try-catched. or do we need to change it elsewhere?

try-catching it is only masking the issue, but it's a good idea as it won't be a big fail.

@asif-finimble I didn't really like this fix as the root bug could still happen elsewhere (possibly), so I traced the logic issue to the root like this: #2701

@JamesSmartCell yes the root bug was still pending to be solved. Its a great fix. Thanks.


[BUG]

Describe the bug
transportTimeoutSetup() should be moved before connectToServer() in transport_secure_sockets, otherwise the system may get stuck while doing TLS handshake.
I have tested this, and with current order, if internet connection is lost exactly at a specific location (which may seem not common, but can happen), system gets stuck. (and only continue working after a very long time, about 20 minutes)
System information

Hardware board: esp32

Expected behavior
correct timeouts should be set before TLS handshake, so a problem in handshake occurs, socket receive (and maybe send) function does not cause the system to get stuck.
Steps to reproduce bug

add these lines:

        TLS_PRINT( ( "TLS before negotiate\r\n" ) );
        vTaskDelay(pdMS_TO_TICKS(4000));

before
        while( 0 != ( xResult = mbedtls_ssl_handshake( &pxCtx->xMbedSslCtx ) ) )

in iot_tls.c (in libraries\freertos_plus\standard\tls\src). this will be needed later.
2. use a windows 10 (11?) laptop, connect to internet, configure a WiFi hotspot, and configure the system to connect to this hotspot.
3. start the system, and exactly after you saw "TLS before negotiate" in log console, disconnect your laptop from internet (but be sure to nut turn off the hotspot instead, windows 10 does not automatically turns the hotspot off.)
4. the system get stuck in TLS handshake. by adding some logs, i can tell you the exact location: in ssl_tls.c (in libraries\3rdparty\mbedtls\library), in function mbedtls_ssl_fetch_input, at this:
                    ret = ssl->f_recv( ssl->p_bio,
                                       ssl->in_hdr + ssl->in_left, len );

it seems it should get stuck for ever because receive function has no timeout set yet, but at least in my tests, handshake fails after about 20 minutes. (configTICK_RATE_HZ set to 100, maybe some overflow in timeout value has happened, or maybe this is correct behavior, don't know)
Solution
reverse order of these two blocks in establishConnect() in transport_secure_sockets.c (in libraries\abstractions\transport\secure_sockets):
move
    if( returnStatus == TRANSPORT_SOCKET_STATUS_SUCCESS )
    {
        /* Configure send and receive timeouts for the socket. */
        secureSocketStatus = transportTimeoutSetup( tcpSocket, pSocketsConfig->sendTimeoutMs, pSocketsConfig->recvTimeoutMs );

        if( secureSocketStatus != ( int32_t ) SOCKETS_ERROR_NONE )
        {
            LogError( ( "Failed to configure send and receive timeouts for socket: secureSocketStatus=%d.", secureSocketStatus ) );
            returnStatus = TRANSPORT_SOCKET_STATUS_INTERNAL_ERROR;
        }
    }

before
    if( returnStatus == TRANSPORT_SOCKET_STATUS_SUCCESS )
    {
        /* Establish the TCP connection. */
        returnStatus = connectToServer( tcpSocket,
                                        pServerInfo );
    }

Regards

Hello @maa1370,
Thank you for reporting the issue to us. What you said makes sense to me. Would you like to create a PR or shall I do that for you?
Thanks,
Aniruddha

@AniruddhaKanhere
Thanks for responce.
as I'm not experienced with git, please create PR yourself.
also please take a look at #3455 too, it is related to another problem in transport_secure_sockets.c i have reported, it may be easier to fix them together.
(also as you are who made PR 3406, please check my comment in issue 1646, it is not related to this issues, just wanted to write a note about it to be sure you have seen that)
Regards

As far as I remember correctly, the small timeout are set after the connection is established because handshake fails if done otherwise. In any case, this is just a sample implementation and feel free to update it as per your application requirements.

@aggarg
Thanks for response.
I disagree with you. I still think this is a bug. I think the correct method is this: If a high timeout before handshake is needed, set a high default timeout (60 seconds e.g.) before it, and after handshake, set the timeout from parameters.
Trying to handshake without a timeout set, may cause to a never or very long timeout as i described, which i think should be considered a bug.

Trying to handshake without a timeout set, may cause to a never or very long timeout as i described, which i think should be considered a bug.

That depends on your application requirements. If application is designed such that it can only function after it is connected to the MQTT broker, it would probably want to block for long during connect. Again, as I said before, this is just one sample implementation of the transport interface and you can update it as per your application requirements.

If application is designed such that it can only function after it is connected to the MQTT broker, it would probably want to block for long during connect.

i think the application should rely on its retry mechanism rather than a blocking handshake.
see the do while in mqtt_demo_mutual_auth as an example. consider two cases:
1-in my first post, after step 3, connect to laptop to internet again after a few seconds so the internet is reachable on hotspot for device again. yes, the handshake may continue (i tested, and it continues), but i think it is possible that it does not continue. i do not know the exact details really, so i'm not sure if the handshake continues or not. will the process always continue (to fail or success, not important) if the internet is reachable after X seconds? or we may have a deadlock (or maybe a very long delay in some conditions in reality, see my note about 20 minutes in my case) here? so why rely on a thing that i'm not sure behaves correctly or not when there is a better solution available?
2-consider the device has 3 WiFi Credentials saved in it's memory, and it want's to try a different one after a failed handshake. with current code, it is stuck in a deadlock (or can only try this after 20 minutes in my case).
so i think a reasonable timeout for handshake is a must, because in any case having a timeout for handshake is beneficial.
i know i can change the code for my usecase (and i have already done it), but as described i think it may cause problems for others too, because the sample implementation is used by many people without going to details. and there is a good solution available. so why not make it better?


Cant type

Type: Bug
i am not able to type on vscode i opened a new index.html file but i cant type anything it won't let me.
 It looks like you may be using an old version of VS Code, the latest stable release is 1.81.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Please update VS Code to latest supported version.
Just to confirm: did you install Vim extension intentionally and do you know how it works?
/needsMoreInfo
Is it reproducible with all extensions disabled?
You can try this with F1 and >Developer: Reload Window With Extensions Disabled

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

The issue has been solved. I deleted Vim, and everything was working fine.

Just out of curiosity, skip if you don't want to answer.
Why did you have Vim extension installed? Is it some extensions pack, tutorial, recommendations list or something else?
I saw a lot of cases when it's installed but looks like not everybody really intended to have it as they not really know how it's supposed to work.


the range of the random number generator in proxl1PRrand is too small

It looks like the random number generator in proxl1PRrand can only generate at most 32767 numbers, which is too small for large graphs

Hm, interesting!! Why is that? Can you quickly fix this?

Because it's generating a 16 bit random number...

ok if you know how to fix this, can you modify it?

I plan to use a library in c++11 as explained here https://stackoverflow.com/questions/21096015/how-to-generate-64-bit-random-numbers or @dgleich you have a better way to do this?

I've had bad luck with the C++ random number generators having issues compiling on multiple platforms. But that was about 10 years ago right when they introduced them. I would hope it's been addressed by now. But you might just check that these all compile nicely on windows, mac, and linux...