[request] Add mac support

Comfy is partially supported on mac, I did not test it yet but I will soon need it, and will be able to test mtb properly there

Tested and working, although it seems to run into a strange loop on install (like running the same thing 3 times), but it then works fine, I don't think this is related to mac


fix app.HTTP_METHOD type

Hi, Thank you for publishing such a good product!
This PR improve type of app.HTTP_METHOD.
If the return type of the handler function is wrong, as in the example below, an error is reported for "path".

This is not ideal. Because it should be the handler function that should report the error like below.

Hi @azukiazusa1 !
This is a good fix! It will be more user friendly than before. Thank you, I'll merge it.


adding GLV parameters trait

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work: This PR defines GLV parameters trait for ark-ec and will be useful in bandersnatch implementation
[x] Updated relevant documentation in the code
[x] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer

not related

[ ] Wrote unit tests

Note that this GLV parameters use a different set of definitions, and will not be compatible with a draft definition in  https://github.com/arkworks-rs/algebra/pull/127 (which seems to be inactive)

Hey @zhenfeizhang , thanks for the PR! I'll try to review this within the next few days!


Complete the Jest DI with crypto

This is preparation work for making it possible to write more sophisticated test, making test-driven-development for internal (non-browser-bundle-exposed) APIs possible.

FYI: bcrypto isn't currently building for me locally in the nix shell on macOS. I'm going to poke around, but it seems to work in CI so may be my environment.

Yeah. Weird. bcrypto is building fine on my end (including in the nix shell).


Foundationinternationalization: add Codable conformance

Add the missing conformance for Codable to Windows.  This fixes a large set of warnings when building the package.

@swift-ci please test


[VL][WIP] Spark map_concat velox function support

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

some ut would fail due to duplicate key different behavior issue (spark would throw exception if but velox always treat last_win), this @Surbhi-Vijay's PR https://github.com/facebookincubator/velox/pull/9562 address the issue.
Let's wait the PR ready.


[HUDI-4214] improve repeat init write schema in ExpressionPayload

What is the purpose of the pull request
improve the memory use in ExpressionPayload, cache the same schema
Brief change log
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

improve before：

after:


Make getblocktemplate-rpcs a default feature

Motivation
Once we're happy to support the getblocktemplate RPCs, we can turn them on in all Zebra builds, by adding that feature to the default feature list:
https://github.com/ZcashFoundation/zebra/blob/31426f3b0e38bb681df3b82a38dad07405a876a5/zebrad/Cargo.toml#L53-L55
Specifications
https://doc.rust-lang.org/cargo/reference/features.html#the-default-feature
Complex Code or Requirements
This is a well-supported Cargo configuration.
Testing
Some tests might need updates if they assume getblocktemplate-rpcs will always be disabled during the test. We should probably delete or disable those tests.

Hey team! Please add your planning poker estimate with Zenhub @arya2 @oxarbitrage @teor2345 @upbqdn


Update README.md

Updated the Discord Link.

The link redirects to discord.com.
Also, the link should be updated in two places in the README, not just one.

@vinay-agens The second link still redirects to home. Try removing the trailing slash.


Use in a pubsub lib?

Thanks for sharing this. I'm relatively new to Go, but I would like to try my hand at a simple pubsub library that uses your glob package. I'm thinking, each subscriber instance would store a compiled Glob containing the list of its subscriptions, like this:
// Subscriber glob with pattern-alternatives list
Subscriber.Subscriptions = glob.MustCompile("{core.*,plugins.categories.*}")

Does that sound right to you?

Hi @nkev,
Yes, this sounds totally right for me =)


Fix freeze command

Having lots of fun with gruescript, thanks for creating it.  Noticed the freeze command wasn't working though.  Think this changeset fixes it.

Good spot, thank you!


AppSync Support

AppSync is currently in Preview, but it would be great to have support for AppSync Lambda Resolvers here. Here is the documentation.
The way I see it, is this library could support doing things as described in the docs - using field and arguments in the payload. It could support both Invoke and BatchInvoke operations, and therefore if using BatchInvoke, it would need to handle maintaining the order of the items sent in, etc.
Thoughts? I'd be willing to help out getting this done.

Having a helper that handles both Invoke and BatchInvoke would be useful! However, i'd hold off on adding support to this repo until AppSync has left preview.


Unable to attach to macOS process

This code does not seem to work on a dotnet project out of the box.
using DataTarget dataTarget = DataTarget.AttachToProcess(Process.GetCurrentProcess().Id, true);

Fails with
Unhandled exception. Microsoft.Diagnostics.Runtime.ClrDiagnosticsException: Could not attach to process 55656, errno: 1
   at Microsoft.Diagnostics.Runtime.MacOS.MacOSProcessDataReader..ctor(Int32 processId, Boolean suspend)
   at Microsoft.Diagnostics.Runtime.DataTarget.AttachToProcess(Int32 processId, Boolean suspend)
   at Program.Main() in /Users/n8ta/SIG8/test_app/Program.cs:line 41

I have a repro project here https://github.com/n8ta-msft/clrmd-repro for arm64 macOS.
I suspect I need to sign with some specific entitlements but I have not been able to figure out which.

The problem might really be that the MacOSProcessDataReader will use ptrace given suspend: true. See https://lkml.org/lkml/2006/8/31/24. The scenario has been reported as largely affecting self-diagnostic ptrace, but the change was intentional. The change is old enough it's likely to have been ported to the ptrace implementation that macOS uses.


Flaky smoke test

See https://dev.azure.com/monacotools/Monaco/_build/results?buildId=123056&view=logs&j=4d2898ab-dfbe-557e-92e7-aaac158fdd2f&t=0a31a1a1-76c6-5f31-444a-2b6049ed7294&l=69 on Linux
  22 passing (2m)
  4 pending
  1 failing

  1) VSCode Smoke Tests (Electron)
       VSCode Smoke Tests (Electron)
         Localization
           starts with 'DE' locale and verifies title and viewlets text is in German:
     Error: Timeout: get text content '.monaco-workbench .part.sidebar > .title > .title-label > h2' after 20 seconds.
      at poll (/__w/1/s/test/automation/out/code.js:176:19)
      at async Code.waitForTextContent (/__w/1/s/test/automation/out/code.js:237:16)
      at async Search.waitForTitle (/__w/1/s/test/automation/out/viewlet.js:13:9)
      at async Context.<anonymous> (out/areas/workbench/localization.test.js:31:13)

I ran the test locally and the did pass for me. This is very frustrating since failures like this are almost never a consequence of the localization smoke test.
I will keep the item open to see how it goes in the next smoke tests. I have a debt item here https://github.com/microsoft/vscode/issues/93462 to think about what can be changed in general.
@TylerLeonhardt adding you as well. May be we can think about a different way of testing this now that we have control over the pipeline. I know we have a pseudo language pack published.

@dbaeumer maybe this test was a casualty of these recent test problems that @joaomoreno and @bpasero have been fixing.
Regarding the failure rate, this particular test looks pretty unhealthy recently https://dev.azure.com/monacotools/Monaco/_test/analytics?definitionId=111&contextType=build

I agree that there isn't any clear action to do. Maybe we can revisit the stats in 1-2 weeks or maybe you can change the order that your test is not the first one / the last one. Also worth considering is if the test is self-contained and executes OK regardless of marketplace availability.

To clarify: my changes addressed an issue in web smoke tests where the welcome editor would always appear first. I had fixed this for desktop based smoke tests already 2 weeks ago.

Agree, that the test was unhealthy lately since it depends on reading translated strings from the UI. These failures would also occur with a pseudo language pack since it was not a translation issue.
@jrieken would I be able to add a psuedo command to the core that allows me to simply return three strings. Where would I do that best?

adding you as well. May be we can think about a different way of testing this now that we have control over the pipeline. I know we have a pseudo language pack published.

If possible, we could install the language pack on the fly from the marketplace? Though I'm not sure that's a good idea for these tests.

@TylerLeonhardt that is what we do. The flakiness doesn't come from that part. It comes from the fact that we try to grab strings from the DOM and that periodically fails to mostly unknown reasons (e.g. timeouts).
So the idea is to read the strings using commands and not the DOM.

So the idea is to read the strings using commands and not the DOM.

Gotcha. I don't know too much about the smoke tests. Is it common practice for us to run commands and check the results in the smoke tests? Also for Localization tests I would guess we need to find a command that has a localized result.

@TylerLeonhardt the idea is to have a fake command that we only use to get a handful of localized strings
@jrieken can you please comment on my question here: https://github.com/microsoft/vscode/issues/126213#issuecomment-862989259

@dbaeumer I have seen this done before e.g. for the colorize integration tests: https://github.com/microsoft/vscode/blob/4f222a873074b8051b274c1d9a5343b009f9d50d/src/vs/workbench/contrib/themes/browser/themes.test.contribution.ts#L235

I added support to the smoke test driver to fetch translated strings. No need for a command anymore.

@dbaeumer and I finnaly figured out the root cause of this:
The DE extension gets installed properly. But there's a onDidInstallExtension listener which sets up a cache for localization extensions. If we quit Code before that listener gets to run (happens not so often), a relaunch of the app won't make it in German. A consecutive relaunch will actually work since the cache is recomputed.
The fix here is to make sure that when the workbench reports a localization extension has been installed, that means that the cache has also been properly setup.

@joaomoreno do you think it's possible to install extensions via CLI instead? It's something I wanna figure out anyway because for the vscode-loc repo I'd like to try installing a VSIX of the extension packs in CI.
I don't really have much context on how to do this.

Just to clarify, I meant install an extension via the CLI in the smoke tests.


Wrong results returned from whereNotContainedIn() method

I am trying to create a query to find posts which are not liked by the logged in user. I create the array containing all the objectIds of posts not liked by the user.Then I perform a query like this
 var votes = new Parse.Query(Votes); votes.equalTo("user_id", request.params.user_id);
votes.find({
success: function(results) {
 var ids = results.map(function(obj) {
 return obj.get('question').id;
});
var questions = new Parse.Query(Questions);
questions.notContainedIn('objectId', ids);
questions.find({
  success: function(results) {
      response.success(results);
  }
 });
}
});

Problem is the data returned contains wrong results.I even tried the api console and did a rest api query like
   'where={"objectId":$nin["HFAxSAyVbN","Xn8EYwbeUZ","qYfgZqaCG8"] }'

The results contained many Json objects including the objects with the above objectId's. One of the results was
 {
    "aspectRatio": 0.709,
    "createdAt": "2016-01-30T05:55:55.732Z",
    "likes": 13,
    "objectId": "Xn8EYwbeUZ",
    "postAuthor": {
        "__type": "Pointer",
        "className": "_User",
        "objectId": "OfBgyVDqpS"
    },
    "postFile": {
        "__type": "File",
        "name": "tfss-0ca1766d-b53f-4c34-8479-0034cc2e60d7-tfss-93d860c5-e60a-42bc-b948-0c965c6b4136-post.jpeg",
        "url": "http://files.parsetfss.com/b406a736-2819-4a49-9bd7-c8729bf4c562/tfss-0ca1766d-b53f-4c34-8479-0034cc2e60d7-tfss-93d860c5-e60a-42bc-b948-0c965c6b4136-post.jpeg"
    },
    "postFile_THUMBNAIL": {
        "__type": "File",
        "name": "tfss-81f5ff66-eead-4f65-bc48-347b93a21fa9-tfss-38fdbd7b-2f59-4a54-9ef4-ae7124441e96-thumbnail.jpeg",
        "url": "http://files.parsetfss.com/b406a736-2819-4a49-9bd7-c8729bf4c562/tfss-81f5ff66-eead-4f65-bc48-347b93a21fa9-tfss-38fdbd7b-2f59-4a54-9ef4-ae7124441e96-thumbnail.jpeg"
    },
    "story": "Awesome burger... Looks delicious...☺☺☺",
    "story_LOWERCASE": "awesome burger... looks delicious...☺☺☺",
    "type": "image",
    "updatedAt": "2016-08-22T18:05:37.716Z"
},

This above objectId is mentioned in the above rest api query.So the query is giving me wrong results from the class . Please check this issue and tell me what's wrong.

This seems to be a bug.

@flovilmart I am actually using the api.parse.com servers and found this bizarre bug or whatever. I know this place is only for parse-server bugs but I think it might still exist in the parse-server .Earlier such a query used to work because I have encountered many people and examples who have made the $nin query and successfully got back the desired results. So I believe something in the recent updates broke this functionality. Please check and let me know if there is a workaround to the problem.

Parse.com don't use parse-server at all, until you reproduce that error on Parse-server, i'I'll close that issue

@flovilmart Please tell me where I should report this issue .... :)

On https://parse.com/help


create: get_cluster_info

please review the "get_cluster_info" function and unit test at your convenience. Thanks.

@georgezakinih I have updated the get_cluster_info function with utility function as well as the unittest in another branch "get_cluster_info_updated". To prevent making you confused, I closed this first pull request .


Add mechanism to tell the Helix Autoscaler to scale down VM scale sets to a specific value

Part of the difficulty of getting all our systems back online during the incident tracked in https://github.com/dotnet/arcade/issues/13774 was dealing with the Autoscaler.

AutoScaler kept creating machines even though we were reaching our Azure quota and all machines were unhealthy
The only lever we have to control the auto scaler is to delete all configuration files in a storage account. This merely means the Autoscaler will stop monitoring the scale set and service bus queue.
I had to manually scale down about 50 scale sets to bring things back online

It would've been very useful to have a mechanism to force auto scaler to bring all scale sets down to 0 capacity while the outage was ongoing to both speed up recovery and ARM template deployment times.

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

This probably needs to be a new API in Helix right? I think this goes way beyond what someone can achieve in their ops rotation.

taking this issue to see the scope of the change! :)


[3.x] Fix AtlasTexture nesting

When drawing an AtlasTexture it was directly calling the VisualServer by itself instead of just forwarding the draw request to the source atlas texture (with the proper rect/region passed in). As a result an AtlasTexture being a source atlas of another AtlasTexture could have resulted in incorrect rendering. This should be fixed now (assuming other methods work as they're supposed to).
With this being fixed it means that pretty much nothing external should care if some Texture is actually an AtlasTexture as there should be no need to treat it as some special case where AtlasTexture's region and/or margin needs to be manually taken into account or something like that. If there's such special casing somewhere then it's very likely there's something wrong conceptually in there (as AtlasTexture should probably be handling this stuff by itself).
So for example fix in #37939 was conceptually wrong, the same as my fix in #51030 on top of it. I've kind of reverted them as such special casing is not needed in there (it was never needed in there, the bug was elsewhere). Now it should work properly.
Fixes #42806.
Fixes #56767.
Just note that for the frames already saved with the incorrect data above issues still hold.
I've also added a check to AtlasTexture::set_atlas() ensuring no cyclic dependency will be created between some AtlasTextures. Previously this:
var at1 := AtlasTexture.new()
var at2 := AtlasTexture.new()
at1.atlas = at2
at2.atlas = at1

would result in no error and a freeze / an infinite loop when actually using any of such textures (it was possible to freeze the editor in a similar manner). Now at2.atlas = at1 would fail and produce an error.

I've also added a check to AtlasTexture::set_atlas() ensuring no cyclic dependency will be created between some AtlasTextures.

I once went down that rabbit hole and there's still a lot of horrible ways to trigger cyclic dependencies by mixing and matching proxy texture formats, e.g.:
var a1 = AtlasTexture.new()
var p1 = ProxyTexture.new()
p1.base = a1
a1.atlas = p1

var sp = Sprite.new()
sp.texture = a1
add_child(sp)

Basically any Texture type that uses another Texture type internally can easily create such cyclic dependencies.
Also MeshTexture, and probably AnimatedTexture, etc.

I've also added a check to AtlasTexture::set_atlas() ensuring no cyclic dependency will be created between some AtlasTextures.

I once went down that rabbit hole and there's still a lot of horrible ways to trigger cyclic dependencies by mixing and matching proxy texture formats, e.g.:
var a1 = AtlasTexture.new()
var p1 = ProxyTexture.new()
p1.base = a1
a1.atlas = p1

var sp = Sprite.new()
sp.texture = a1
add_child(sp)

Basically any Texture type that uses another Texture type internally can easily create such cyclic dependencies. Also MeshTexture, and probably AnimatedTexture, etc.

Maybe adding a method like virtual bool Texture::is_referenced_by(const Ref<Texture> &other_texture) overridden accordingly by AtlasTexture, ProxyTexture etc. and used in AtlasTexture::set_atlas, ProxyTexture::set_base etc. would solve that?

I've actually removed that cyclic dependency check as that wasn't really a proper solution, it was just checking one specific case. And a proper solution (whatever it will be) can be made in another PR.

Thanks!


aobench: cannot use sleef-sys

Performance profiling revealed the crate was spending 50% of its time inside libm.so, and I decided to try using sleef to see if it would help. Unfortunately, it seemed it wasn't working, and the crate was still using libm's functions.
The benchmark's README recommends building with target-cpu=native. However, sleef-sys has a build file which checks for the presence of certain target-features, and ignores target-cpu.
So I kept target-cpu=native, and also added -C target-feature=sse,sse2,ssse3,sse4.1,avx,avx2,fma (all of my CPU's features, I think).
But then it failed to build:
error[E0463]: can't find crate for `sleef_sys`
   --> /data/Development/Rust/packed_simd/src/lib.rs:261:1
    |
261 | extern crate sleef_sys;
    | ^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

It seems the cfg(all(target_feature = "sse2")) in packed_simd's  Cargo.toml wasn't working. So I removed it and now it tried to build libsleef.so:
unsupported target: "x86_64-unknown-linux-gnu" features: "{"rdrand", "popcnt", "lzcnt", "xsaveopt", "xsavec", "rdseed", "bmi2", "xsave", "bmi1", "fxsr", "xsaves", "mmx"}"

So what are the step-by-step instructions for using sleef with this crate?

I've managed to halve the runtime of aobench --algo vector, by writing some quick & dirty sin/cos approximations with polynomials. I really hope we can get sleef to work, and that it provides good performance.
If I force ISPC to link against libm by adding --math-lib=system, it's even slower than the Rust code using libm.

and I decided to try using sleef to see if it would help. Unfortunately, it seemed it wasn't working,

Which platform are you on ?

The benchmark's README recommends building with target-cpu=native. However, sleef-sys has a build file which checks for the presence of certain target-features, and ignores target-cpu.

When using target-cpu=native cargo translates (or should translate, I think I checked this with @alexcrichton ) that to all target-feature flags of the CPU, so that in build.rs one only has to detect target features. If this isn't working, it is a cargo bug.
Note that we are not passing any target features to the C compiler. To do this we would have to upgrade the cc crate with support for target-features and target-cpu, and then propagate that to the cmake-rs crate.

So what are the step-by-step instructions for using sleef with this crate?

cargo build --features=sleef on the platforms that sleef support. I've had no problems with this on x86_64-unknown-linux-gnu and x86_64-apple-darwin, and on CI linux and windows are tested with this as well: https://github.com/rust-lang-nursery/packed_simd/blob/master/ci/run.sh#L74
I don't recall why macosx is not tested (there is a comment, but its not helpful...) - maybe an oversight.
Building and linking C libraries is brittle, so if your system differs slightly, things might fail.

and that it provides good performance.

IIRC the benchmarks results in the readme of aobench for the AVX1 machine are with sleef enabled, and it provides way better performance, but still 1.5x slower than ISPC.

What I wanted to do at some point is enable cross-language inlining for the sleef-sys crate, so that the functions can be inlined into rust. @michaelwoerister wrote instructions about how to do that here: https://github.com/rust-lang/rust/pull/53031#issuecomment-413806821

@gnzlbg I did manage to get sleef to build, but I've discovered the bigger issue.
With sleef-sys, while the sincos function is no longer an issue.
I had modified the benchmark to use fma in some places, and instead of using AVX2's fma, it now used sleef's fma, which for me means worse performance with sleef enabled
(Which is what made me thought there was an issue with the way I was building sleef)
I will work on solving #112 and #116 before continuing work on this benchmark.

it now used sleef's fma, which for me means worse performance with sleef enabled

oh damn, I only tested the sleef functions in one system, and there they always deliver a significant improvement, but on this system the llvm.fma intrinsics is really slow and I should have measured that the performance was the same as llvm.fmuladd. I think we can open a new issue for this.


[CS2103T-T11-2] AgenSee

This is the main PR for CS2103T-T11-2's master branch into AY2122S2/tp master branch
Team members:

Wang Jun Hong
Janald Ho
Bian Yuqi
Chua Shi Hong
Phua Jun Heng

Codecov Report

Merging #65 (ac23ba3) into master (4f7660a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7660a...ac23ba3. Read the comment docs.


Manual trigger + regular trigger = doesn't work

I need a text input field to be triggered programaticaly (from some ng-click for exampe) and also to be triggered from a click (like it does by default).
The manual way is supposed to be done using the e-form directive. The problem is that having this attribute wraps the input with a form, and this cancels the clickability of the field. This can be seen in the following code:
// bind click - if no external form defined
if(!attrs.eForm) {
elem.addClass('editable-click');
elem.bind('click', function(e) {
e.preventDefault();
e.editable = eCtrl;
scope.$apply(function(){
scope.$form.$show();
});
});
}
from directive.js.
It would be really nice having those two options simultaneously. Currently i'm just using jquery to manually click() the element, instead of using pure angular..

@eugef I think this can be closed.


Fatal Error Connection Lost with PacketAirPump

Mariculture: <IP_ADDRESS>a
Enchiridion: 1.2b
Forge: 1.7.10-Forge<IP_ADDRESS>6-1.7.10
All the users on my server are getting random client crashes/disconnects. I can't do anything specific to reproduce this error. I do have 2 air pumps nearby (50 to 100 blocks away). Their client says fatal error lost connection. We can reconnect and it will do it randomly until we move from the area. Gotta love NPE's lol. Here is the error log from the client itself:
http://pastebin.com/tBT0tYy7

Try the 1.3.0 alphas on curseforge. I'm done with 1.7.10, but those I believe have this issue fixed. (It's listed as alpha because i'm not working on it, (just prs from other people). Not because it's unstable


Suggested way to customize "Edit this page" link based on document

The vispy library uses the sphinxcontrib.apidoc extension to automatically generate our API documents at build time. These generated files just use apidoc/autodoc tools to pull the information from the python package's source code. The issue with this is that the default "Edit this page" link in the pydata-sphinx-theme points to where the API doc file would be if it was committed to the repository. Since they aren't you get a 404.
I've hacked something together that seems to work, but wondering if anyone here had suggestions to make it better using either smarter jinja2 tips or features in the theme that I'm not aware of. You can find all the details here: https://github.com/vispy/vispy/pull/2220
But the main context changes make it pretty obvious what I'm doing:
html_context = {
    "github_user": "vispy",
    "github_repo": "vispy",
    "github_version": "main",
    "doc_path": "doc",
    "edit_page_url_template": "{{ vispy_custom_edit_url(github_user, github_repo, github_version, doc_path, file_name, default_edit_page_url_template) }}",
    "default_edit_page_url_template": "https://github.com/{github_user}/{github_repo}/edit/{github_version}/{doc_path}{file_name}",
    "vispy_custom_edit_url": _custom_edit_url,
}

Hmm just a quick thought, if the main thing you want to do is prevent the button on some pages, could you just a very short JavaScript snipped that checks the current url and removed the button if it's a part of some pages?

I could, but in the best case I don't want to hide/remove it but rather update the URL to point to a different location (python source file instead of .rst doc file).

I have a slightly different approach:
I am making a documentation for a platform that use many modules coming from different repositories. the doc page thus lives in these repositories and I simply add it from github with a urlretreive in my conf.py.
as you @djhoese I end up with "edit this page" btn that doesn't point to the correct location and that would be super nice if I was able to customize it.

@12rambau one "workaround" for your situation is that you could create git submodules for those other repositories in your "main" repository. That way those files still "live" in your main repository even though they are controlled/versioned in the sub-repositories.

I'll have a look, I'm not really using the sub-module git fonctionnality, but I'll stay tuned in htis thread for the customization

Git submodules are 50% good and 50% bad. In your case it may make things easier. In the vispy project I got annoyed by the single git submodule we had for our docs (one code repos with one doc repos) so I just moved the doc repository content into the main repository.
If you want to see one way of working around the issue I had see the PR I referenced for vispy linked above. It has been merged and seems to be working fine.

@djhoese I didn't managed to use Git submodules and lost myself in the documentation. At least now I know it exists. Instead I decided to build a custom directive to overwrite the link via JS. here is my code if your are interested:
# -*- coding: utf-8 -*-

"""
ReST directive for dynamically change the value of the "edit this page btn". only compatblie with the current theme.
The directive require the complete raw file path (from github).
Example::
    .. custom-edit:: https://raw.githubusercontent.com/openforis/sepal-doc/custom_edit/README.rst
"""

from docutils import nodes
from docutils.parsers.rst import Directive, directives

class CustomEdit(Directive):
    has_content = False
    required_arguments = 1
    optional_arguments = 0
    final_argument_whitespace = False
    option_spec = {}
    html = """
    <script>
        var div = document.getElementsByClassName("tocsection editthispage")[0];
        var link = div.getElementsByTagName("a")[0];
        link.href = "{}";
    </script>
    """

    def run(self):

        # get the raw link
        raw_link = directives.uri(self.arguments[0])

        # transform it into an edit link
        raw = "raw.githubusercontent.com"
        github = "github.com"
        edit = "edit"
        list_ = raw_link.replace(raw, github).split("/")
        list_.insert(5, edit)
        link = "/".join(list_)

        return [nodes.raw('', self.html.format(link), format='html')]

def setup(builder):
    directives.register_directive('custom-edit', CustomEdit)

sorry for the noise, I assume you were expecting something more systematic but I least if anyone needs it, it's here...

Hi, in the vein of customizing, is there a way to completely disable the "edit this page" feature but only for generated pages (i.e., conditionally disable edit_page_url_template for certain pages)?


Fix unsoundness in EntityMut::world_scope

Objective
Found while working on #7385.
The struct EntityMut has the safety invariant that it's cached EntityLocation must always accurately specify where the entity is stored. Thus, any time its location might be invalidated (such as by calling EntityMut::world_mut and moving archetypes), the cached location must be updated by calling EntityMut::update_location.
The method world_scope encapsulates this pattern in safe API by requiring world mutations to be done in a closure, after which update_location will automatically be called. However, this method has a soundness hole: if a panic occurs within the closure, then update_location will never get called. If the panic is caught in an outer scope, then the EntityMut will be left with an outdated location, which is undefined behavior.
An example of this can be seen in the unit test entity_mut_world_scope_panic, which has been added to this PR as a regression test. Without the other changes in this PR, that test will invoke undefined behavior in safe code.
Solution
Call EntityMut::update_location() from within a Drop impl, which ensures that it will get executed even if EntityMut::world_scope unwinds.

imo it should be:
    /// Gives mutable access to this `EntityMut`'s [`World`] in a temporary scope.
    pub fn world_scope<T>(&mut self, f: impl FnOnce(&mut World) -> T) -> T {
        let result = std::panic::catch_unwind(AssertUnwindSafe(|| f(self.world)));
        self.update_location();
        result.unwrap_or_else(|e| std::panic::panic_any(e))
    }

this PR's current unsafe code is tbh incredibly sketchy, im so surprised that it doesnt throw a miri error, and if you tweak it a little it -does-. plus many smart people who know how stacked borrows work were also confused why it didnt error (hard to state how funny this is tbh).

That's definitely a much cleaner solution. I didn't realize something that straightforward was possible.
I take it BlobVec::replace_unchecked could use a similar approach?

I'm curious what impact this has on performance, particularly since we use world_scope everywhere in the hierarchy commands.

What would be the most relevant benchmarks for measuring that?

I ended up switching to the approach suggested by @hymm, which I like more after thinking about it. This approach should have better codegen since it doesn't pull in the panic machinery (correct me if I'm wrong).

bors r+


Missing icon

An extension needs an icon that will be displayed on the
marketplace and inside the vscode's extension screen.

@gorkem yes we need have it , We have it as open item in task list https://github.com/openshiftio/openshift.io/issues/1455
icon is not finalised, for now till we get it decided am planning to have OSIO icon


Browser events definition

Fixes #
Changes
Please provide a brief description of the changes here.
For non-trivial changes, follow the change proposal process and link to the related issue(s) and/or OTEP(s), update the CHANGELOG.md, and also be sure to update spec-compliance-matrix.md if necessary.
Related issues #
Related OTEP(s) #

I like the new layout of the "Events", I'm wondering whether it would read better if the "Events" section was first and the Resources / Varying values at the bottom. That way the description of the Event can mention that it may contain zero or more of the Resrouces / Variying Resources.

That way the description of the Event can mention that it may contain zero or more of the Resrouces / Variying Resources.

@MSNev Can you clarify what you mean here? It's not clear to me why an Event would contain a Resource.

Really just suggesting that as part of the "description" for an event
ie. This bit

All events have the following three high-level attributes. The event name is specified at the beginning of each section below. The payload of the event goes in a nested attribute called event.data. `event.data' for each event is listed below.

That we also describe that as part of the event definition additional fixed and varying values (currently described as Resources) may also be included with the event (when sent to the backend)
This provides guidance for both people reviewing the definitions as well as people looking to implement / consume this on the backend storage, should be be aware that while the "event" definition identifies the details of an event there may also be some other "values" provided by these locations (where-ever they end up).

I like the new layout of the "Events", I'm wondering whether it would read better if the "Events" section was first and the Resources / Varying values at the bottom.

Made this change.


view_closed support (Block Kit in Modals)

Description
As of version 1.3.0, Bolt lacks view_closed action support. view_closed events can be sent to slack app servers when notify_on_close in views.
What type of issue is this? (place an x in one of the [ ])

[x] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Reproducible in:
package version: 1.3.0
node version: any
OS version(s): any
Steps to reproduce:

Call views.open having notify_on_close: true
Close the view on Slack
Bolt doesn't handle the action request, saying [WARN]   Could not determine the type of an incoming event. No listeners will be called.

Expected result:
app.view('callback-id' , fn) can handle view_closed action as well.
Actual result:
As above.
Attachments:
Payload example:
{
  "type": "view_closed",
  "team": {
    "id": "T12345678",
    "domain": "domain"
  },
  "user": {
    "id": "U12345678",
    "username": "username",
    "name": "username",
    "team_id": "T12345678"
  },
  "api_app_id": "A12345678",
  "token": "random value",
  "view": {
    "id": "V12345678",
    "team_id": "T12345678",
    "type": "modal",
    "title": {
      "type": "plain_text",
      "text": "Title",
      "emoji": true
    },
    "close": null,
    "submit": {
      "type": "plain_text",
      "text": "Submit",
      "emoji": true
    },
    "blocks": [
    ],
    "private_metadata": "",
    "callback_id": "modal-callback-id",
    "state": {
      "values": {
      }
    },
    "hash": "random",
    "clear_on_close": false,
    "notify_on_close": true,
    "root_view_id": "V12345678",
    "previous_view_id": null,
    "app_id": "A12345678",
    "external_id": "",
    "bot_id": "B12345678"
  },
  "is_cleared": false
}

Sorry this is so long-winded but....
I started implementing this today, but got pretty stuck over the decision of what method the view_closed event should be handled with. I wanted to lay out the options here in case any others had input:
Option 1: event()
For incoming requests that we label as type "Event", there is a pretty big upside: we automatically acknowledge the request before we pass it to any listeners or middleware. This makes it so the developer won't have to call ack() in their listeners. This makes sense because you'll never have to acknowledge the event with anything other than 200 OK (for context: incoming requests like view_submission require you to acknowledge with different options depending on how you want to handle the submission or if there are any errors).
However, this is breaking convention because up until now, we've only had the event() method handle Events API events. Events API events can be sent to a different endpoint than interactive component events, but this doesn't matter much for Bolt since it will decide which kind of event the incoming request is based on its own logic rather than relying on endpoints. There might be additional developer overhead here if someone (rationally) thinks that events() should only handle Events API events.
Another (pretty big) downside is if you had several view submissions, there isn't a built-in way to filter on callback_id so you'd have to handle logic for all view closed events within one listener. A somewhat-viable workaround that I can think of off the top of my head is to provide a built-in middleware that allows you to filter on callback_id (does this already exist?) which you could attach to your event() listener
Ex: app.event('view_closed', ({ view }) => { // some logic })
Option 2: views()
Another option is using the views() method and adding a constraints object (similar to the constraints for the actions() method). This has an upside where you're handling all requests related to views in one type of listener, which may make more intuitive sense to a developer. The biggest downside for this option is that we'd likely force the developer to acknowledge the incoming view_closed events for consistency's sake. I don't think that's a huge problem, but it's a minor inconvenience.
Ex: app.views({ type: 'view_cancelled', callback_id: 'YOUR-CALLBACK-ID'}, ({ view, ack }) => { ack(); // some logic }); or maybe app.views('YOUR-CALLBACK-ID', viewCancelOnly()...
Option 3ish: actions()
Less interested in this option. It'd be less intuitive as to where the developer should handle the view cancellation and it would still require them to acknowledge it. The pro is that we only have a constraints object on the actions() method (I don't know if that's a real pro though).
I don't have a really strong opinion. I lean a little bit more towards the event() method after typing it out, but I'm worried that route may cause a little bit of confusion. Would love other's input if they have them, or any pros/cons that I may have missed (cc @seratch)

@shanedewael
Thanks for the detailed explanation 🙏 I vote for the Option 2, and also let me share my preferable interface later in this comment.

Option 1

No need to call ack() in this case is indeed pretty neat and reasonable, but I'm afraid that the two downsides are not ignorable. In particular, keeping to offer app.event only for Events API must be easy-to-understand for everyone. I don't want to have exceptions which require some explanation in docs here.

Option 3

From the viewpoint of API consistencies, there is no reason to go with app.action for it.
https://github.com/slackapi/bolt/issues/265#issuecomment-537449896

Option2

First of all, for convenience, I believe we should keep the behavior when not specifying a payload type as before (= means handling only view_submission events).
app.view('YOUR-CALLBACK-ID', ({ view, ack }) => {
    // handle only view_submission events here
});
app.view({callback_id: 'YOUR-CALLBACK-ID'}, ({ view, ack }) => {
    // handle only view_submission events here
});

Regarding the ways to specify a payload type, I came up with two ways as below. I want to allow both, but going with either is also excellent.
// Option A - giving a full name of type
app.view({callback_id: 'YOUR-CALLBACK-ID', type: 'view_closed'}, ({ view, ack }) => { });
app.view({callback_id: 'YOUR-CALLBACK-ID', type: 'view_submission'}, ({ view, ack }) => { });

// Option B - skipping the redundant part - `view_`, and giving only the suffix
app.view({callback_id: 'YOUR-CALLBACK-ID', type: 'closed'}, ({ view, ack }) => { });
app.view({callback_id: 'YOUR-CALLBACK-ID', type: 'submission'}, ({ view, ack }) => { });

The following part may be a bit off-topic, but, with this approach, we may be able to come up with a similar interface for dialogs. Introducing a new name may be able to make the framework simpler.
Disclaimer: I haven't verified the feasibility of providing the APIs for both JS and TS yet (particularly, a bit worrying about dialog_suggestion events).
// Option A - giving a full name of type
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'dialog_submission'}, ({ dialog, ack }) => { });
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'dialog_suggestion'}, ({ dialog, ack }) => { });
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'dialog_cancellation'}, ({ dialog, ack }) => { });

// Option B - skipping the redundant part - `dialog_`, and giving only the suffix
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'submission'}, ({ dialog, ack }) => { });
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'suggestion'}, ({ dialog, ack }) => { });
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'cancellation'}, ({ dialog, ack }) => { });

However, this approach introduces more ways to do the same. If we go with this, we may deprecate existing action and options for dialogs. In that case, we should have a quite long time until removing the deprecated ones.
// submission
app.action({callback_id: 'YOUR-CALLBACK-ID'}, ({ action, ack }) => { });
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'submission'}, ({ dialog, ack }) => { });
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'dialog_submission'}, ({ dialog, ack }) => { });

// suggestion
app.options({callback_id: 'YOUR-CALLBACK-ID'}, ({ options, ack }) => { }},
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'suggestion'}, ({ dialog, ack }) => { });
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'dialog_suggestion'}, ({ dialog, ack }) => { });

// cancellation
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'cancellation'}, ({ dialog, ack }) => { });
app.dialog({callback_id: 'YOUR-CALLBACK-ID', type: 'dialog_cancellation'}, ({ dialog, ack }) => { });

Having multiple ways for a single purpose is not a small downside, but having app.dialog and app.view looks more consistent to me.
.... let's get back on track. Regarding `view_closed support, if you go with Option 2 in some way, I don't have any objections for it.

I'm glad we're all in agreement! I just wanted to add one more advantage to Option 2 that I'm excited about.
With this design, you can write listener middleware that deals with general cleanup that occurs whenever a modal goes is dismissed, whether its because it was submitted or because it was canceled. Example:
// This function cleans up some temporary state from a data store and puts it on the context
// Use case: A partially initialized object is put in the database but fully initializing it depends on gathering input from the modal
function cleanUpTemporaryState({ context, next }) { /* ... */ }

// Submission handler
app.view('create_order', cleanUpTemporaryState, ({ view }) => { /* ... */ });

// Cancel handler
app.view(
  { callback_id: 'create_order', type: 'view_closed' },
  cleanUpTemporaryState,
  ({ view }) => { /* ... */ }
);

how this would work with python bolt? I trued this but does not seems to work..
@app.view_closed(callback_id):
def handle_some_action(body):
    print(f'The modal have been closed:{body}')

@smoneta Can you post a new question issue in https://github.com/slackapi/bolt-python/issues with a bit more details such as your code?

Thanks, https://github.com/slackapi/bolt-python/issues/624


Remove stale clippy directive

Running "cargo doc" gives this warning
warning: unknown lint: clippy::needless_pass_by_ref_mut
--> src/service/reload.rs:104:9
|
104 | #[allow(clippy::needless_pass_by_ref_mut)]
|         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: clippy::needless_pass_by_value
|
= note: #[warn(unknown_lints)] on by default
warning: cargo-leptos (lib) generated 1 warning
The name "needless_pass_by_ref_mut" was not wrong at the time of writing, it is just stale
https://rust-lang.github.io/rust-clippy/master/index.html#/clippy::needless_pass_by_ref_mut
Additionally this "allow" is no longer needed to get cargo clippy to "pass" as of
cargo clippy --version
clippy 0.1.71 (8ede3aa 2023-07-12)

This is a duplicate, already included in #178


Fixed developer resource links

Fixed small issue in readme where dev resource links were trying to go to locally wiki pages.

Thanks! There's already a PR up fixing this (#267), will get it merged soon 😄

Closing per other PR that fixes #267


setup for tests not working - missing message

Is your feature request related to a problem? Please describe.
When setting up tests I am getting error:

MISSING_MESSAGE: No messages were configured on the provider.

Tests are using react testing library.
Describe the solution you'd like
Working test set up.
Describe alternatives you've considered
I have tried solution based upon the testing library documentation and also this issue.
Like so:
/tests/utils/custom.tsx
   import React from 'react';
   import { render } from '@testing-library/react';
   import { NextIntlProvider } from 'next-intl';

 const customRender = (ui: React.ReactElement, options) => {
     return render(ui, {
         wrapper: (props: any) => (
             <NextIntlProvider
                 locale="en"
                 {...props}
                 {...options?.NextIntlProviderProps}
             />
         ),
         ...options?.testingLibraryOptions,
     });
 };

 // re-export everything
 export * from '@testing-library/react';

 // override render method
 export { customRender };

Then, on the actual test page:
/tests/pages/login.tsx
   import '@testing-library/jest-dom';
   import Login from 'pages/login';
   import { customRender } from '../utils/custom';

  describe('Login render Page', () => {
     it('renders the Login page', () => {
         const { getByText } = customRender(<Login />);
          expect(getByText(/login/i)).toBeInTheDocument();
     });
   ......

So, with above it is somehow unable to find the messages.
I am almost sure this is not a next-intl bug but rather that something is amiss on my setup.
Note that translations work fine on the actual component. This is a test environment issue.
Additional context
The error is thrown on the useTranslations() hook on the component page as below:

Hi @BernardA,
from what I can tell you didn't provide any messages on the provider. That's what the error message is trying to describe.
There's a short section about Jest in the docs. If you don't want to provide sample messages, you can also configure the error handling to ignore errors for missing messages.
However if you do the latter, there's currently a restriction that you have to pass an empty messages object to the provider – that might be something that I should improve.
Hope this helps!

Thanks. I am not able to test as I am bogged down by the other providers that the app requires.
In any case, note that most tests require checking that a text is present, so passing empty messages object does not seem super useful.

In any case, note that most tests require checking that a text is present, so passing empty messages object does not seem super useful.

I just meant that next-intl renders a unique placeholder if a message is not found, so you can still assert for that 😉.


No space left on device bitcoin in scheduler

Running into this while downloading the blockchain, first installations on brand new hardware while following raspibolt.org guide step by step:
EXCEPTION: 15dbwrapper_error
Fatal LevelDB error: IO error: /home/bitcoin/.bitcoin/indexes/txindex/009395.log: No space left on device
bitcoin in scheduler
Environment

Hardware platform:  Raspberry Pi 4 8Gb

solved


Support tensor stride

Summary: Support tensor stride for execution trace.
Differential Revision: D58900476

lgtm, some linter issues have popped up that may need fixing


Distinct modifier support for aggregate functions

This adds support for count(distinct *) as discussed in #1028.
I have also added support for avg(distinct *) and sum(distinct *) as both of these seemed valuable, I have not added distinct support for min and max as I don't think that adding distinct to those aggregates can impact the outcome. If it is felt that these should be added, I'm more than happy to update the PR.
There may be some confusion here between the standard distinct expression, and the distinct expression that goes inside of an aggregate function. I'm not sure whether to refer to it as 'inner distinct' or perhaps 'aggregate distinct'. When building the statement, I used aggregateDistinct to differ from the standard distinct.
I should probably also rename both _distinct() and _distinctFlag to also clarify the distinction between the distincts (see what I did there? 😛) but wanted to ask if there were thoughts on the name - naming things is always the hardest part.
I have tested this locally against sqlite3 only.
More than happy to provide more tests or other updates as necessary.

closes #1028

add support for count(distinct *), avg(distinct *) and sum(distinct *)
min and max don't really make sense with distinct, so didn't add those

Looks perfect to me. Only thing I would have changed would have been to add changed code and autogenerated files in separate commits :) @rhys-vdw any comments to this one? It had good tests and implementation was pretty much the same with e.g. not modifier.

I can always pull changes out into separate commits if that is desirable, however I think having separate commits for src and built code would be undesirable - it is not useful history & creates a point at which things will not work as you expect.
I've tried to implement this in an idiomatic way so it fits the library - I felt the naming was definitely confusing so I've updated that. These names are long, but other than calling it aggDistinct I wasn't sure where to go with it :grin: happy to change it.
Also updated the docs, good shout @elhigu. Also happy to modify / improve them if anyone has a better idea.

@ErisDS @elhigu: Having generated code in the repository at all is undesirable. Don't worry about it. The solution is to add it to the .gitignore, but there will have to be some tweaks to the release script first.
Sorry for the wait, @ErisDS. I approve of the API change.
One thing to change in the implementation before I can merge:
Instead of adding an _aggregateDistinct(), just pass an extra argument directly to _aggregate.
  // Retrieve the sum of the distinct values of a given column.
  sumDistinct: function(column) {
    return this._aggregate('sum', column, true);
  },

I have updated this PR with the suggested changes. Reduced surface area :+1:
I think whether or not generated code should be checked in depends a lot on the project and how it works - there are pros and cons from a git perspective. In this case, as the documentation in the repo depends on the generated code, I don't think it's so bad to have it checked in. I didn't realise how the docs worked at first - but actually, writing docs is a great extra check that your code does what you expect - in fact, the docs almost work like a REPL, very handy.
May I (in a separate PR) update the contribution guidelines with what I learned about the documentation, and that an update there is needed when making api changes?

I have updated this PR with the suggested changes.

Great, thanks for that.

I think whether or not generated code should be checked in depends a lot on the project and how it works - there are pros and cons from a git perspective.

The included knex.min.js script matters in the gh-pages branch, so that can be worked around. Docs, as you are obviously aware, are not generated content. I think the docs would be the same other than missing the script outside of gh-pages.

May I (in a separate PR) update the contribution guidelines with what I learned about the documentation, and that an update there is needed when making api changes?

Yes, please. :+1:

Another reason why it may be desirable to keep the generated files in git - I just changed my package.json file to "knex": "git://github.com/tgriesser/knex.git#bd97610" to check if this fixes an issue I'm encountering in my project (it doesn't... that's another story).
I know there are both pros and cons to keeping built files in the repo, just wanted to suggest that if it isn't causing major headaches (I don't know if it is or isn't ), changing it may result in some you aren't expecting :wink:

@ErisDS That case can be addressed with an install script in package.json.

I've done a bit of research on the matter recently as I just made this change to Bookshelf. I'm fairly convinced it's the right way. Note that the generated code is not necessarily correct at each commit - so keeping lib/ under version control could be more problematic than you realize. Also nobody want to be solving merge conflicts in compiled output.

I think that having /src with a postinstall script as react-router does it will be the way to go here, https://github.com/rackt/react-router/blob/620d2703b6314a03b8a54a1fccaac097d436567a/npm-scripts/postinstall.js that way if you have a copy off of github it should also work so long as you have babel installed.

@tgriesser Problem here is that the global version of babel may be incorrect. IMO it's totally valid to call npm install babel in the postinstall script and use the devDependencies version of Babel. Babel has just undergone some massive changes so you can't rely on configuration being compatible across the board.
I've been advised that the publish script is technically the correct place for this. It is also run on install, but will run before a release.

Here is how I handled it in Bookshelf. Still requires some work.

@tgriesser @rhys-vdw This feature is awesome, when can we expect a new release?


resizing dom terminal

Thank you for this wonderful project.
I'm trying to resize the (dom) terminal using this javascript:
emulator.screen_adapter.set_size_text(120,120)
emulator.screen_adapter.update()

which correctly adds the right amount of <span> elements.
However, the buildroot example still seems stuck in 80x25, even after running this in the session:
/root% export TERM=xterm
/root% export COLUMNS=120
/root% export ROWS=120
/root% resize
COLUMNS=80;LINES=25;export COLUMNS LINES;

any ideas?

You can only set text mode resolution supported by VGA: https://en.wikipedia.org/wiki/VGA_text_mode#PC_common_text_modes
If you need freely change terminal resolution, you can try use a serial port with xterm.js: https://github.com/copy/v86/issues/172#issuecomment-396976546

The vga screen can only be configured by the guest OS.


Revert "Revert "[MB-15089] change references for prd and stg to milmove-cert-bundle""

Reverts transcom/mymove#10138

Messages

:book:
:link: MB-15089

  Generated by :no_entry_sign: dangerJS against b059c86e383567db8499b55c2ff38e2ea0655983

Since we got the error both with and without these changes, I'm just going to go ahead and merge this.


langchain[minor]: Multi-file loader

Introduces the MultiFileLoader, which behaves like the DirectoryLoader, except the input is a list of file paths instead of a single directory path.

Thanks for the PR!
Is this materially different from calling the DirectoryLoader in a loop? If it doesn't support individual files, would it make more sense to add that functionality?

It's a completely different use-case. I have files from different directories that I may pick and choose from vs entire directories, so looping with the DirectoryLoader wouldn't work as that is on a directory-basis.

Thanks! Sorry for delay


Wire mixer.runtime to dynamic.Handler

Enable grpc adapter dispatch thru Mixer.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
78e457634bfae5d088d10f865fb6816e0803f12e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
8c89c457fa6e7231039b2bb9610b4a48692ea81e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: guptasu, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [guptasu,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8c89c457fa6e7231039b2bb9610b4a48692ea81e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8c89c457fa6e7231039b2bb9610b4a48692ea81e
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
8c89c457fa6e7231039b2bb9610b4a48692ea81e
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8c89c457fa6e7231039b2bb9610b4a48692ea81e
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
c0762ef501164e5023a287f3e65befafc9d325dc
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c0762ef501164e5023a287f3e65befafc9d325dc
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
7680cd904beafaac171cfe8bd0c5b30b7e197b27
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c0762ef501164e5023a287f3e65befafc9d325dc
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
c0762ef501164e5023a287f3e65befafc9d325dc
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c0762ef501164e5023a287f3e65befafc9d325dc
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
c0762ef501164e5023a287f3e65befafc9d325dc
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c0762ef501164e5023a287f3e65befafc9d325dc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
c0762ef501164e5023a287f3e65befafc9d325dc
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c0762ef501164e5023a287f3e65befafc9d325dc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
81c634bfd26f8870bf613d1810f1e384feec7220
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
81c634bfd26f8870bf613d1810f1e384feec7220
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: guptasu, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [guptasu,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
65394de00a35ac23a81bda9a9f475a22f7447971
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: guptasu, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [guptasu,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
cda2025aeff2477bd8b5560939a0d8d47c1379b2
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Azure OIDC provider

Microsoft Entra ID works well with current provider/google.go, thus, google.go should be renamed to general.go as the protocol is the same
here is how i tested with Microsoft Entra ID
1 Change Issuer Endpoint

the endpoint should be https://login.microsoftonline.com/{TenantID}/v2
--- a/client/providers/google.go
+++ b/client/providers/google.go
@@ -24,7 +24,7 @@ var (
        key = []byte("NotASecureKey123")
 )

-const googleIssuer = "https://accounts.google.com"
+const googleIssuer = "https://login.microsoftonline.com/406b12e6-b0de-4406-a743-d879574020a7/v2.0"

2 Patch examples/ssh/opkssh/cli.go

set app secret

enable gq

diff --git a/examples/ssh/opkssh/cli.go b/examples/ssh/opkssh/cli.go
index ce08fd3..e4ffa0f 100644
--- a/examples/ssh/opkssh/cli.go
+++ b/examples/ssh/opkssh/cli.go
@@ -20,11 +20,11 @@ import (
 )

 var (
-       key              = []byte("NotASecureKey123")
-       clientID         = "184968138938-g1fddl5tglo7mnlbdak8hbsqhhf79f32.apps.googleusercontent.com"
-       requiredAudience = "184968138938-g1fddl5tglo7mnlbdak8hbsqhhf79f32.apps.googleusercontent.com"
+       // key              = []byte("NotASecureKey123")
+       clientID         = "d1d0f097-9427-4fdc-a342-f500c3d54793"
+       // requiredAudience = "184968138938-g1fddl5tglo7mnlbdak8hbsqhhf79f32.apps.googleusercontent.com"
        // The clientSecret was intentionally checked in for the purposes of this example,. It holds no power. Do not report as a security issue
-       clientSecret = "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" // Google requires a ClientSecret even if this a public OIDC App
+       clientSecret = "<THE APP SECRET>" // Google requires a ClientSecret even if this a public OIDC App
        scopes       = []string{"openid profile email"}
        redirURIPort = "3000"
        callbackPath = "/login-callback"
@@ -60,7 +60,7 @@ func main() {
                        // The OPK verifier should use policy to make this decision.
                        principals := []string{}

-                       gqFalse := false
+                       gqFalse := true
                        alg := jwa.ES256

3 Patch client/oidc.go
Microsoft Entra ID's jwk does not have alg field, here is the workaround
diff --git a/client/oidc.go b/client/oidc.go
index 28c3cb8..df6eebb 100644
--- a/client/oidc.go
+++ b/client/oidc.go
@@ -185,9 +185,9 @@ func DiscoverPublicKey(ctx context.Context, headers jws.Headers, issuer string)
                return nil, fmt.Errorf("key %q isn't in JWKS", kid)
        }

-       if key.Algorithm() != jwa.RS256 {
-               return nil, fmt.Errorf("expected alg to be RS256 in JWK with kid %q for OP %q, got %q", kid, issuer, key.Algorithm())
-       }
+       // if key.Algorithm() != jwa.RS256 {
+       //      return nil, fmt.Errorf("expected alg to be RS256 in JWK with kid %q for OP %q, got %q", kid, issuer, key.Algorithm())
+       // }


Live Chat button overlaps with multiple UI elements

Description
The live chat button overlaps with the delete deployment button and other elements according to its position on the screen.

is that at 100% zoom or not?

@xmonader depends on the screen size
I have added a bottom padding in the main layout so it won't overlap if u scroll down

Verified
A padding was adding to the bottom, giving the live chat icon a good space whatever was the zooming or screen size is.


ElkArte v1.1 fresh Installation - Error strtr() expects at most 3 parameters, 4 given

Hello Developers,
I installed ElkArte v1.1 for the first time on Ubuntu Managed Server. When creating a forum topic, I have this error everywhere.
Error strtr() expects at most 3 parameters, 4 given

How can I fix it or where does the error come from?
Thanks in advance.

I found the error because the eMojis plugin was not compatible.
Apparently you have to be a little bit patient, rather all addons checked and also made compatible. Thank you!

Reported in the Elk-Emoji addon repo.
Closing this one. :)


refactor: Do one prediction per input sequence, easier experimentation

The prediction/evaluation interfaces used List[List[str]] as the prediction type to account for: a) batch inference, i.e. generate docs for multiple code snippets in one pass and b) generating multiple predictions per input (sampling). But we've now decided to do deterministic prediction (temp=0) so there's no need for the second level.
This PR changes to the prediction return type to List[str], which also makes the code simpler.
Two additional changes:

Replace the use of the max_length parameter in favor of max_new_tokens
Break-up the eval function into eval_promp for easier prompt experimentation
Updated generate.ipynb notebook accordingly

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (10294bc) 97.00% compared to head (6f2c5da) 97.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   97.00%   97.15%   +0.15%
==========================================
  Files           3        3
  Lines         167      176       +9
==========================================
+ Hits          162      171       +9
  Misses          5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Extend ConfigMap to store fwrule names

GLBC users can store a providerUid which is used in lieu of Uid when constructing l7 firewall rule names. This can be leveraged to resolve issues seen in Kubernetes #37306.
Backwards compatibility is retained by using Uid for l7 firewall rules unless providerUid is set.

This change is

Coverage decreased (-0.03%) to 45.94% when pulling 85a34516b364d0e831c0df7294c71388cc826d00 on csbell:fw-name into a8b89677d6b780185d5e6f53ed47a198be6f3008 on kubernetes:master.

Thanks for the first round of comments -- I've re-pushed the CL. The major differences are key/val-based puts and adding some unit testing.
However, I still plan on holding off until I can adequately integrate this with federation and test out the functionality.

Coverage increased (+0.04%) to 46.014% when pulling c25aebca924449bdcac34326f309a8166c125e2a on csbell:fw-name into 9bba94732590ebdb832ac725cf55d06538457df6 on kubernetes:master.

Kubernetes driver for this is here: https://github.com/kubernetes/kubernetes/pull/41942
PTAL @nicksardo

Coverage increased (+0.004%) to 46.167% when pulling f498b1ce4b1d88cfbee0983bfbdabf796e6f2a8b on csbell:fw-name into 592814bf9734ac023655d9bf92d0ce755f204f32 on kubernetes:master.

/lgtm

/approve

Need another lgtm

/lgtm

With /approve ?

/approve

Coverage increased (+0.04%) to 45.393% when pulling 68097e96dcacdc692d7886934fc69c540eef57b8 on csbell:fw-name into f5f9f5e9c8ae1ec4e01a978ce807c47ac8a8aa1e on kubernetes:master.


2 integrate embriotech progress

Related to #2

@offerijns Ready for review

@offerijns  This one should fix the issues with the charts. can you try it?
In the data model you will also find some fields names now ending with a _ underscore. Such fields are automatically reset to 0 by the stateSnapshotter() at the end of a period when taking a snapshot. I thinks this simplifies the handling of aggregated values.
Hope it does not conflict with your current implementations.


[WIP] Feature/issue 782 Android Manager APIs - PermissionManager

Fixes #782
This PR is NOT ready for review.
Risk
This PR makes no API changes.
Testing Plan

In Progress...

Summary
This PR implements the PermissionManager as described in the proposal.
CLA

[x] I have signed the CLA

Codecov Report

Merging #815 into feature/issue_782_Android_Managers will decrease coverage by 1.81%.
The diff coverage is 7.82%.

@@                           Coverage Diff                            @@
##             feature/issue_782_Android_Managers     #815      +/-   ##
========================================================================
- Coverage                                 44.27%   42.45%   -1.82%
+ Complexity                                 3205     2940     -265
========================================================================
  Files                                       373      376       +3
  Lines                                     18011    17742     -269
  Branches                                   1755     1803      +48
========================================================================
- Hits                                       7975     7533     -442
- Misses                                     9705     9874     +169
- Partials                                    331      335       +4

Impacted Files
Coverage Δ
Complexity Δ

...celink/api/PermissionManager/PermissionFilter.java
0% <0%> (ø)
0 <0> (?)

...com/smartdevicelink/protocol/enums/FunctionID.java
85.43% <0%> (-4.36%)
8 <0> (ø)

...celink/api/PermissionManager/PermissionStatus.java
0% <0%> (ø)
0 <0> (?)

...elink/api/PermissionManager/PermissionElement.java
0% <0%> (ø)
0 <0> (?)

.../main/java/com/smartdevicelink/api/SdlManager.java
29.05% <66.66%> (-8.65%)
13 <1> (ø)

...elink/api/PermissionManager/PermissionManager.java
8.88% <8.88%> (ø)
1 <1> (?)

...a/com/smartdevicelink/proxy/rpc/OnVehicleData.java
94.94% <0%> (-0.71%)
57% <0%> (-59%)

...link/proxy/rpc/UnsubscribeVehicleDataResponse.java
96.73% <0%> (-0.02%)
57% <0%> (-29%)

...celink/proxy/rpc/SubscribeVehicleDataResponse.java
96.73% <0%> (-0.02%)
57% <0%> (-29%)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6413709...1f55265. Read the comment docs.

@askirk @brettywhite PR updated to reflect the changes mentioned in your comments


chore: Remove redundant "from" in log message

Signed-off-by: terrytangyuan<EMAIL_ADDRESS>Checklist:

[x] My organization is added to USERS.md.

Thank you!


sysutils/nut: Fix typo in snmp-ups driver

See https://forum.opnsense.org/index.php?topic=14397.msg69764#msg69764

Thanks! Note: too late for tomorrow’s 19.7.8


on overlap event does not fit in the small desktop view

This block simply does not fit. This is our first tutorial.

We added zoom out in the tutorial.  No plan to fix this


Workaround custom inspection behavior causing errors

Calling util.inspect or console.log on an object that has an inspect property with a function as a value will cause that function to be invoked as part of their custom inspection behavior (https://nodejs.org/api/util.html#util_custom_inspect_function_on_objects). One of the Chrome events is named 'inspect' so this function can be called if you try to console.log the chrome instance. Normally that would throw an error since handler would not be a function, but this change will detect that case and avoid trying to attach a handler.
Should fix #15

Hey @jRiest, thanks for reporting this. I don't like very much the idea of customizing the behavior of util.inspect() in that way, i.e., inserting checks that are executed every time an event listener is registered.
Moreover, this fix does not properly work when depth is null, which is an allowed value according to the documentation.


feat(Datastore): Query OR

Enabling users to do Or Queries.

The feature isn't implemented yet in emulator.

BREAKING_CHANGE_REASON=extending filter method of query class in Datastore to support adding OR queries.

@vishwarajanand , I iterated on your review.
PTAL😀


OrderBy on a dynamic column is not working

When i want to order my query by a dynamic column name it always gives null. The sortby is the column name i get to sortby from my frontend.
query = query.OrderBy(x => x.GetType()
.GetProperty(request.SortBy, BindingFlags.IgnoreCase | BindingFlags.Public | BindingFlags.Instance)
.GetValue(x, null));
Is there a solution for this?

I've updated a working way to do this in #2035.

Duplicate of #2035


duplicate of https://github.com/plataformatec/devise/issues/471

it four years later, and I got bit by the same bug.  took me 3-4 hours of looking to figure out how to even find the terminology to locate the issue.
figure out some way to monkey patch current_page? so that it doesn't mangle the scope for your controllers on uri generation using the old syntax.  OR POST HERE, how to do it.   problem is:
devise install.
application.html.erb
unless (current_page?(:controller => "blah", : action => "blah2"))
do some shit
end
breaks, as soon as it hits the devise controllers.  but the stack trace, error message don't have anything to do with devise.  instead it mangles it, and pops up an error on current_page, with a "devise/blah", :action "blah2" URI generation error.  WHICH IS A BITCH, to debug.
...
so the problem is, current_page? with old controller syntax is inserting devise/ in front of calls to current_page?(:controller => "soome controller", :action => "some action").   THe solution had absolutely nothing to do with devise files, route selection/creation or any of that garbage.   The solution, was to explicitly call the URI_generating path.   in this case, change:
current_page?(:controller...:action....) to:
current_page?(blah_blah2_path);
thats, what fixes the retarded scoping issue, for current_page? // devise.
I look forward to some insightful commentary, on why this is happening.  How does "devise/"?  and how can I monkey patch current_page?  other than literally writing a wrapper/test/mixin?
On the plus side, now I know that URI generation craps out on the older style :controller=> action=> syntax. :)  which makes me wonder, is their a :scope variable I'm supposed to be supplying?

+1

Hello, thanks for your report.
I think there's some confusion here, I'll try to explain:
First, @naterexw, there's no index action for Devise::SessionsController, that's why you're getting the error you mentioned above.
About the current_page? helper, it tries to generate a URL based on the controller and action options by calling the url_for helper, which prepends the current controller namespace in order to generate the routes.
Since Devise use namespaced controllers, if you access a Devise page, url_for will try to automatically prepend devise/ to the controller option. You can fix this by adding a forward slash to the controller option or by using the route path helper, as you mentioned above.
For example, I've created a simple Rails application with Devise, and a Game resource:
# routes.rb
Rails.application.routes.draw do
  devise_for :users
  resource :games
end

Added a byebug call in my layout:
# app/views/layouts/application.html.erb
<%- byebug %>

When I access a Devise route, for example /users/sign_in:
(byebug) url_for(controller: 'games', action: 'show')
(byebug) *** ActionController::UrlGenerationError Exception: No route matches {:action=>"show", :controller=>"devise/games"}
nil

This happens because the current route is on the devise controller namespace. However, if I add the slash, it works properly:
(byebug) url_for(controller: '/games', action: 'show')
"/games"

This doesn't happen if we aren't inside a Devise route. For example, if I access /games:
(byebug) url_for(controller: 'games', action: 'index')
"/games"

In order to generate a devise route here, I have to manually include the devise prefix, since this controller is not on the devise namespace:
(byebug) url_for(controller: 'sessions', action: 'create')
*** ActionController::UrlGenerationError Exception: No route matches {:action=>"create", :controller=>"sessions"}
nil
(byebug) url_for(controller: 'devise/sessions', action: 'create')
"/users/sign_in"

I hope this clarifies what's happening here. This is a behavior from the Rails URL helpers, not something we added to the Devise gem.
Thank you!


disconnecting the physical keyboard while a video is playing in fullscreen causes a black-screen

Describe the bug
during a video playing on the screen in fullscreen, when i disconnect the physical keyboard from the tablet, i see nothing but a pure black-screen (generally video is still playing in background)
How to Reproduce
Steps to reproduce the behavior:

Tap on the fullscreen icon of the video player
Disconnect the physical keyboard from the tablet
Screen goes all black, can't to anything... (and user has to close and restart the app)

Expected behavior
Video should be keep playing properly
Smartphone (please complete the following information):

DDG App Version: 5.65.0
Device: Samsung Galaxy s5e
OS: LineageOS 17.1 (Android 10)

Thanks for reporting @furkanunluturkk, however, I don't have a physical keyboard to test this issue on my devices.
I saw you reported another scenario first (I've got an email notification :D ):
Steps to reproduce the behavior:
Tap on the fullscreen icon of the video player
Try to rotate the screen or presss the power button of the device
Screen goes all black, can't to anything... (and user has to close and restart the app)
Is that also happening on your device?
I tried to follow those steps and I was not able to reproduce the issue but got into another one. In my case:

Tap on the fullscreen icon of the video player
Press the power button of the device (turns off the screen)
Turn on the screen again (app is in foreground again)
Video is still present
Pressing back navigates to a black screen.

Could you tell me if you are having this issue in other scenarios, and not only when disconnecting your physical keyboard?

Thanks for reporting @furkanunluturkk, however, I don't have a physical keyboard to test this issue on my devices.
I saw you reported another scenario first (I've got an email notification :D ):
Steps to reproduce the behavior: Tap on the fullscreen icon of the video player Try to rotate the screen or presss the power button of the device Screen goes all black, can't to anything... (and user has to close and restart the app)
Is that also happening on your device?
I tried to follow those steps and I was not able to reproduce the issue but got into another one. In my case:
1. Tap on the fullscreen icon of the video player

2. Press the power button of the device (turns off the screen)

3. Turn on the screen again (app is in foreground again)

4. Video is still present

5.

Could you tell me if you are having this issue in other scenarios, and not only when disconnecting your physical keyboard?

Oh, no. First one was sort of a mistake, that's why i had modified later. It only happens when I connect/disconnect my s5e physical keyboard.
And one thing to note that: It actually reloads/refreshes the page when i connect/disconnect my keyboard. Maybe that's the reason of the black-screen. App tries to reload the page when a media playing full-screen thus it crashes.

Thanks for the response. I assume that the screen goes black and sound also stops, could you confirm that?
And just to check if the issue I found can be also related, what happens if you press back on that screen? does it navigate back to the browser or stays in that black screen?

Thanks for the response. I assume that the screen goes black and sound also stops, could you confirm that?
And just to check if the issue I found can be also related, what happens if you press back on that screen? does it navigate back to the browser or stays in that black screen?

No no, audio doesn't stop but only the video. Here I captured a record of the procedure:

Thanks.
Ok, so to summarize all the info, this is what happens:

Open video in full screen mode
Disconnect physical keyboard
Screen goes black, but audio doesn't stop playing
Pressing back does nothing

Thanks.
Ok, so to summarize all the info, this is what happens:

Open video in full screen mode
Disconnect physical keyboard
Screen goes black, but audio doesn't stop playing
Pressing back does nothing

Exactly.

Sadly, I've not been able to reproduce this issue in my test devices and we haven't received similar reports.
I will close this issue as not further exploration can be made. Thanks.


Remove inner circle from revealed fields

While you're there: flagged fields have an inner circle.


Remove tile side buffers for client data source tiles

Remove tile paddings from client data by setting tile buffer on each side to zero for GeoJSONVT option.
Fixes https://github.com/mapzen/android/issues/364

lets see if this initializer list compiles on gcc 4.9


Inference with a customized model having structural changes.

Hello, I am using a MaksRCNN model with the model. Thereafter I make a decomposition to the linear layers of the backbone using low-rank transformations. Thus I would now have some structural changes to the model and I save the model using torch.save(model.state_dict(),path_to_save). I have not made any changes to the config file as yet.  I now want to load this saved model to do inference. So my question is first, what do I need to do to get the meta_tags(that mmdetection otherwise creates like when I train a model) in the checkpoints file that I save, and secondly, do I need to make any changes to the config file in order for my changes to be reflected when I initialize the model?

As far as I know, you can prepare two detectors, one has one linear layer and the other has two layers. After decomposition, you can change the config's model type and use the new model to load the decomposed checkpoint.

@jbwang1997  okay, I will try this approach

@jbwang1997 I tried a couple of things but had no luck. Could you confirm my understanding :
As far as I could understand, we have to load the model with single layers (the original model), then run the decomposition to create the new/updated model and save it in a checkpoint. Lastly, update the value for the "checkpoint" tag in the config file to load the new checkpoint in the following initializations.
If I get it right, this approach won't  work as when initializing this model it would load the model structure from something like :
/content/mmdetection/mmdet/models/backbones/swin.py.  Maybe I am wrong but I haven't managed to solve it.  Could you guide me a bit more?

Sorry for not being clear. In my consideration, you can create a new backbone including two linear layers. After getting the decomposed checkpoint, you can update the value of type to your new backbone and the value of checkpoint to the decomposed checkpoint.


Release v1.5.8

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.
Here's what I've got...
For recipe/meta.yaml:

❌ requirements: run: numpy>=1.21,<2.0 must contain a space between the name and the pin, i.e. numpy >=1.21,<2.0
❌ requirements: run: scipy>=1.7 must contain a space between the name and the pin, i.e. scipy >=1.7
❌ requirements: run: pandas>=1.0 must contain a space between the name and the pin, i.e. pandas >=1.0
❌ requirements: run: configobj>=5.0.6 must contain a space between the name and the pin, i.e. configobj >=5.0.6

For recipe/meta.yaml:

ℹ No valid build backend found for Python recipe for package ps2ff using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
ℹ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ No valid build backend found for Python recipe for package ps2ff using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
ℹ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.


Sub-component definitions on storybook docs prop-table are hard to read

This can be fixed with one line of CSS to the appropriate td > span: white-space: pre;
Current:

Expected:

:tada: This issue has been resolved in version 1.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ENTESB-4850 No bean could be found in the registry for: ConnectionFac…

https://issues.jboss.org/browse/ENTESB-4850

Can one of the admins verify this patch?

ok to test

Processed pull request.


Update the metadata API

Update the metadata API with upstream

Closing as this is covered in the other PRs. Thanks for the help @rebornix


Odometry check failed

Hello, I recently managed to use cartographer for SLAM purposes, the problem is that the performance is definetly no accurate. I am using a rotating planar lidar to get a 3D infromation of the environment  (maybe this is why the liocalization is not accurate). The point is that I want to use the odometry form the wheels and other sensosrs to make the SLAM more robust. Thus I set the following parameters in the backpack 3D.lua:
options = {
map_builder = MAP_BUILDER,
trajectory_builder = TRAJECTORY_BUILDER,
map_frame = "map",
tracking_frame = "imu_link",
published_frame = "odom",
odom_frame = "odom",
provide_odom_frame = false,
publish_frame_projected_to_2d = false,
use_odometry = true,
use_nav_sat = false,
use_landmarks = false,
num_laser_scans = 1,
num_multi_echo_laser_scans = 0,
num_subdivisions_per_laser_scan = 1,
num_point_clouds = 0,
lookup_transform_timeout_sec = 0.2,
submap_publish_period_sec = 0.3,
pose_publish_period_sec = 5e-3,
trajectory_publish_period_sec = 30e-3,
rangefinder_sampling_ratio = 1.,
odometry_sampling_ratio = 1.,
fixed_frame_pose_sampling_ratio = 1.,
imu_sampling_ratio = 1.,
landmarks_sampling_ratio = 1.,
}
TRAJECTORY_BUILDER_3D.num_accumulated_range_data = 160
MAP_BUILDER.use_trajectory_builder_3d = true
MAP_BUILDER.num_background_threads = 7
POSE_GRAPH.optimization_problem.huber_scale = 5e2
POSE_GRAPH.optimize_every_n_nodes = 320
POSE_GRAPH.constraint_builder.sampling_ratio = 0.03
POSE_GRAPH.optimization_problem.ceres_solver_options.max_num_iterations = 10
POSE_GRAPH.constraint_builder.min_score = 0.62
POSE_GRAPH.constraint_builder.global_localization_min_score = 0.66
return options
I have a topic that is publishing a nav_msgs/Odometry msg in the odom topic as specified in the cartographer documentation. When I run the .launch file I get the following error:
[FATAL] [1524643855.448762349,<PHONE_NUMBER>.508541094]: F0425 10:10:55.000000 16791 global_trajectory_builder.cc:96] Check failed: odometry_data.pose.IsValid() { t: [0.000000, -0.000000, 0.020000], q: [0.000000, 0.000000, 0.000000, 0.000000] }
Any idea to solve this problem would be appreciated
Thanks in advance!

global_trajectory_builder.cc:96] Check failed: odometry_data.pose.IsValid() { t: [0.000000, -0.000000, 0.020000], q: [0.000000, 0.000000, 0.000000, 0.000000] }

You are sending empty data, which includes an invalid quarternion.
BTW, how many planes does your lidar provide?
Have you successfully tuned without odometry?
If not, have you tried 2D first? It is much easier to start with.

Thanks for the quick answer!
Without the odometry it does not crash, and it works, the problem is that the SLAM is not accurate at all that's why a wanted to insert /odom in the system.
Any idea why is it empty? My /odom topic is publishing messages...
It's a single plane laser rotating. Yo mean how many planes each rotation?
I tried 2D without odom, getting the same results than the ones i got using 3D.
Thanks again!

BTW here is my /odom msg:
pose:
pose:
position:
x: 0.0
y: 0.0
z: 0.0
orientation:
x: 0.0
y: 0.0
z: 0.0
w: 0.0
covariance: [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]
twist:
twist:
linear:
x: 0.195269629359
y: 0.0
z: 0.0
angular:
x: 0.0
y: 0.0
z: -0.000553466903511
covariance: [0.0004232949286233634, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0004232949286233634, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0002294552541570738]

Ok, I can see that the pose field is completley empy. Is that the reason why cartographer crash?

Yes. Cartographer dies on purpose when it sees an invalid quaternion.

Ok. Thank you again, i will fix it and report the outcomes.

I solved the odometry problem, but now im getting the following mistake:
FATAL] [1524651299.060136403,<PHONE_NUMBER>.016200277]: F0425 12:14:59.000000 21138 map_by_time.h:43] Check failed: data.time > std::prev(trajectory.end())->first<PHONE_NUMBER>58837698 vs.<PHONE_NUMBER>58837698)

OK,I managed to solve this issue by lowering the odometry_sampling_ratio. Now i can launch the cartographer without errors. Thanks! I close the issue and mark it as solved.

solve this issue by lowering the odometry_sampling_ratio

Just for documentation, you are only hiding the real issue that some of your input packets are invalid and dropping every nth packet. This is not fixed.

Could it be because I am using a filtered bag file?

Closing inactive issues.


CI: update actions/checkout and actions/setup-node

actions/checkout was already updated in main, but update of actions/setup-node is still actual


Refuses to open[BUG]

Describe the bug
Clicking icon indicates the program has started but nothing opens and the app cannot be switched to. Both portable and installed version behave the same.
To Reproduce
Steps to reproduce the behavior:

Go to 'the program'
Click on 'it'
Scroll down to '....'
See error

Expected behavior
Program should open and that is not happening
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows 11 23H2

Additional context
Add any other context about the problem here.

I can try and run a newer build of this one, not sure when I'm gonna get time to do it - but if you've not found it already, this has been pretty much superseded with https://github.com/FSGModding/FSG_Mod_Assistant
My guess at a glance at the "Win 11" OS is that the version of electron this was last built on doesn't play nice.

Thanks for the quick reply
Get Outlook for iOShttps://aka.ms/o0ukef

From: J.T. Sage @.>
Sent: Wednesday, January 3, 2024 10:16:52 PM
To: jtsage/FS_Mod_Checker @.>
Cc: HomerTheGeek @.>; Author @.>
Subject: Re: [jtsage/FS_Mod_Checker] Refuses to open[BUG] (Issue #56)
I can try and run a newer build of this one, not sure when I'm gonna get time to do it - but if you've not found it already, this has been pretty much superseded with https://github.com/FSGModding/FSG_Mod_Assistant
My guess at a glance at the "Win 11" OS is that the version of electron this was last built on doesn't play nice.
—
Reply to this email directly, view it on GitHubhttps://github.com/jtsage/FS_Mod_Checker/issues/56#issuecomment-1876253089, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASCJ33LOCYBIFXT6TYTWAUTYMYNKJAVCNFSM6AAAAABBKPWMKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWGI2TGMBYHE.
You are receiving this because you authored the thread.Message ID: @.***>