status: status updates not resilient to conflicts during writes

2021-01-15T20:35:02.728749Z     error   status  Encountered unexpected error updating status for networking.istio.io/v1alpha3/virtualservices/service-graph06/entrypoint/49, will try again later: Operation cannot be fulfilled on virtualservices.networking.istio.io "entrypoint": the object has been modified; please apply your changes to the latest version and try again
2021-01-15T20:35:02.732263Z     error   status  Encountered unexpected error updating status for networking.istio.io/v1alpha3/virtualservices/service-graph02/entrypoint/50, will try again later: Operation cannot be fulfilled on virtualservices.networking.istio.io "entrypoint": the object has been modified; please apply your changes to the latest version and try again
2021-01-15T20:35:02.732453Z     error   status  Encountered unexpected error updating status for networking.istio.io/v1alpha3/virtualservices/service-graph10/entrypoint/49, will try again later: Operation cannot be fulfilled on virtualservices.networking.istio.io "entrypoint": the object has been modified; please apply your changes to the latest version and try again
2021-01-15T20:35:02.732466Z     error   status  Encountered unexpected error updating status for networking.istio.io/v1alpha3/virtualservices/service-graph11/entrypoint/48, will try again later: Operation cannot be fulfilled on virtualservices.networking.istio.io "entrypoint": the object has been modified; please apply your changes to the latest version and try again
2021-01-15T20:35:02.732504Z     error   status  Encountered unexpected error updating status for networking.istio.io/v1alpha3/virtualservices/service-graph13/entrypoint/48, will try again later: Operation cannot be fulfilled on virtualservices.networking.istio.io "entrypoint": the object has been modified; please apply your changes to the latest version and try again
2021-01-15T20:35:02.732565Z     error   status  Encountered unexpected error updating status for networking.istio.io/v1alpha3/virtualservices/service-graph09/entrypoint/51, will try again later: Operation cannot be fulfilled on virtualservices.networking.istio.io "entrypoint": the object has been modified; please apply your changes to the latest version and try again

This is unexpected. I would think there is either a single writer, in which case we never conflict. Possibilities:

Leader election is broken - I have verified only one has any status logs
single instance writes multiple times concurrently
k8s looks at the full object for UpdateStatus, so it conflicts even if the status is unchanged, and someone happened to change the VS spec at the same time. (note: I don't know if k8s does that or doesn't - just a guess).
Something else is writing to status - there is nothing else

If k8s does treat it as a conflict if spec changes, then we should be resilient. k8s has retry.RetryOnConflict which may help

not stale
On Thu, Apr 15, 2021 at 10:05 PM Istio Policy Bot
@.***> wrote:

🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2021-01-15. It will be closed on 2021-04-30 unless an Istio team member takes action. Please see this wiki page for more information. Thank you for your contributions.
Created by the issue and PR lifecycle manager.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

2023-06-14T02:57:47.358970Z	error	status	Encountered unexpected error updating status for &{{gateway.networking.k8s.io/v1beta1/HTTPRoute 832b381f-a9be-4913-9a68-41cb0a2115ff cfhttproute-demofunction default cluster.local map[func.lessgo.cloud/function-name:demofunction func.lessgo.cloud/spec-hash:e4ec679807b85226] map[] 2735980 2023-06-13 16:35:28 +0000 UTC [{funcs.lessgo.cloud/v1alpha1 Function demofunction e68ba541-0357-4a12-94df-d565015a7304 0xc002d2be28 0xc002d2be27}] 1} 0xc001996708 0xc0025e68b8}, will try again later: Operation cannot be fulfilled on httproutes.gateway.networking.k8s.io "cfhttproute-demofunction": the object has been modified; please apply your changes to the latest version and try again

I also encountered a situation where istio update httproute got stuck in a dead loop.

It should not dead loop, only one istiod instance should be writing. Is there something else constantly writing?
You can use https://github.com/howardjohn/kubectl-grep#diffing to see

Sorry, the dead loop I mean that the loop would never stop, and I upgraded from 1.17.2 to 1.18.0, it resolved.


shape for all models verified

Wasabi and Wasabiti now also compatible with new signal model dimensions.
I need help with the variable names here: https://github.com/PTB-MR/mrpro/blob/f8b056248c6705817e0daf81f37eda3199d10511/tests/operators/models/test_shape_all_models.py#L13
The first is the model name (easy), the second is the number of input tensors of forward and the third number is the number of tensors required for the init. Any good suggestions of how to name them?

closes #227
closes #202

num_init_parameters -> n_init_parameters ?
and mention this as well in comment you linked "
Signal model, number of tensor arguments in forward (i.e. quantitative parameters) , number of tensor arguments in init (e.g. inversion time or CEST offsets)


Why grep filter returns more results with more search chars?

Environment (please complete the following information):

OS: Windows 10 64 bit
(Neo)Vim version:

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Mar 24 2022 23:02:44)
MS-Windows 64-bit GUI version with OLE support
Included patches: 1-4621

vim-clap version: SHA-1: 6fd4fecaf8b1da31c625e5f02822778d4a2a08b5
Have you reproduced with a minimal vimrc: no
Have you updated to the latest plugin version: yes

Describe the bug
When I input more chars in clap's grep input panel the sum of results increase.
To Reproduce
Steps to reproduce the behavior:
1,grep search "__"
:Clap grep +no-cache  ++query=__

clap indicate there are 51 result
2,enter P in the end
the the sum of results increase.
Expected behavior
the sum of results should decrease.
Screenshots

By the way vim-clap has bug when run without maple:
I got an error when I press  to move in result list when maple is removed:

I have to temporarily change
  function! clap#job#daemon#send_message(msg) abort
    call ch_sendraw(s:job, a:msg."\n")
  endfunction

to
  function! clap#job#daemon#send_message(msg) abort
    if exists('s:job')
        call ch_sendraw(s:job, a:msg."\n")
    endif
  endfunction

There is bug in maple or vim-clap. rg returns 97 matches, but vim-clap only show 49 matches.

I don't think so, I believe the main reason is that you are not using the same rg command that vim-clap is using, otherwise please create a new issue with a detailed report.

I got an error when I press  to move in result list when maple is removed:

Please file a new issue in order to solve it properly.

I got it:
when use maple.exe the sum of results is limited by:
g:clap.display.preload_capacity
I can get all results if I modify:
function! clap#maple#command#start_grep_sync(cmd, query, enable_icon, glob) abort
  let global_opts = s:prepare_global_opts(g:clap.display.preload_capacity)

  let subcommand = [
        \ 'grep', a:query,
        \ '--grep-cmd', a:cmd,
        \ '--cmd-dir', clap#rooter#working_dir(),
        \ '--sync',
        \ ]

  if a:glob isnot v:null
    let subcommand += ['--glob', a:glob]
  endif

  call clap#job#regular#maple#start([s:maple_bin] + global_opts + subcommand)
endfunction

to
function! clap#maple#command#start_grep_sync(cmd, query, enable_icon, glob) abort
  let global_opts = s:prepare_global_opts(g:clap.display.preload_capacity+3000)

  let subcommand = [
        \ 'grep', a:query,
        \ '--grep-cmd', a:cmd,
        \ '--cmd-dir', clap#rooter#working_dir(),
        \ '--sync',
        \ ]

  if a:glob isnot v:null
    let subcommand += ['--glob', a:glob]
  endif

  call clap#job#regular#maple#start([s:maple_bin] + global_opts + subcommand)
endfunction


Configuration of New Vaults for Spacewalk on Amplitude

This ticket is for setting up new vaults on Amplitude to support the seamless bridging assets on Spacewalk.
Technical Consideration:
Define and implement the necessary configurations for the new vaults:

@ebma can you provide technical details?

Yes. But can you please specify in the tickets how many vaults you want to have and for which assets?

@ebma I am talking to Bahila since she knows the process how to get in touch with Vaults, for now we don't know the details

@annatekl we are not dependent on external vault operators here as this is about internal vaults. I see that @vadaynujra updated the description. Thanks for that. Can you please also mention how much collateral you'd like these vaults to deposit? Tech team can then go ahead and create the accounts and prepare the commands for running them. Topping them up with the necessary KSM amounts would then be up to the product team again, but this has to wait until the accounts are created.

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber

Also here, let's only mention the new vaults and not the existing ones in order not to create confusion. And move it to the tasks repository.


Code run by sys.setprofile is not covered

Describe the bug
The codebase I'm working on uses sys.setprofile to implement some functionality. When I run the test suite with coverage, the lines of code implementing the profiling function are not reported as covered.
(profiling-sandbox) ian@ian:~/dev/profiling-sandbox$ coverage run -m unittest
<frame at 0x7f232427fd40, file '/home/ian/dev/profiling-sandbox/tests.py', line 6, code add>
<frame at 0x7f232427fd40, file '/home/ian/dev/profiling-sandbox/tests.py', line 7, code add>
.
----------------------------------------------------------------------
Ran 1 test in 0.000s

OK
(profiling-sandbox) ian@ian:~/dev/profiling-sandbox$ coverage report -m
Name          Stmts   Miss  Cover   Missing
-------------------------------------------
profiler.py       6      2    67%   6-7
tests.py          9      0   100%
-------------------------------------------
TOTAL            15      2    87%

To Reproduce
Clone this repository and run the tests.
I used python 3.8 and coverage 5.5 and 6.0b1.
$ coverage debug sys
-- sys -------------------------------------------------------
                        version: 5.5
                       coverage: /home/ian/.local/share/virtualenvs/profiling-sandbox/lib/python3.8/site-packages/coverage/__init__.py
                         tracer: -none-
                        CTracer: available
           plugins.file_tracers: -none-
            plugins.configurers: -none-
      plugins.context_switchers: -none-
              configs_attempted: .coveragerc
                   configs_read: /home/ian/dev/profiling-sandbox/.coveragerc
                    config_file: /home/ian/dev/profiling-sandbox/.coveragerc
                config_contents: b'[run]\nsource = profiler, tests\n'
                      data_file: -none-
                         python: 3.8.10 (default, Jun  2 2021, 10:49:15) [GCC 9.4.0]
                       platform: Linux-5.4.0-77-generic-x86_64-with-glibc2.29
                 implementation: CPython
                     executable: /home/ian/.local/share/virtualenvs/profiling-sandbox/bin/python
                   def_encoding: utf-8
                    fs_encoding: utf-8
                            pid: 645023
                            cwd: /home/ian/dev/profiling-sandbox
                           path: /home/ian/.local/share/virtualenvs/profiling-sandbox/bin
                                 /usr/lib/python38.zip
                                 /usr/lib/python3.8
                                 /usr/lib/python3.8/lib-dynload
                                 /home/ian/.local/share/virtualenvs/profiling-sandbox/lib/python3.8/site-packages
                    environment: -none-
                   command_line: /home/ian/.local/share/virtualenvs/profiling-sandbox/bin/coverage debug sys
                sqlite3_version: 2.6.0
         sqlite3_sqlite_version: 3.31.1
             sqlite3_temp_store: 0
        sqlite3_compile_options: COMPILER=gcc-9.3.0
                                 ENABLE_COLUMN_METADATA
                                 ENABLE_DBSTAT_VTAB
                                 ENABLE_FTS3
                                 ENABLE_FTS3_PARENTHESIS
                                 ENABLE_FTS3_TOKENIZER
                                 ENABLE_FTS4
                                 ENABLE_FTS5
                                 ENABLE_JSON1
                                 ENABLE_LOAD_EXTENSION
                                 ENABLE_PREUPDATE_HOOK
                                 ENABLE_RTREE
                                 ENABLE_SESSION
                                 ENABLE_STMTVTAB
                                 ENABLE_UNLOCK_NOTIFY
                                 ENABLE_UPDATE_DELETE_LIMIT
                                 HAVE_ISNAN
                                 LIKE_DOESNT_MATCH_BLOBS
                                 MAX_SCHEMA_RETRY=25
                                 MAX_VARIABLE_NUMBER=250000
                                 OMIT_LOOKASIDE
                                 SECURE_DELETE
                                 SOUNDEX
                                 TEMP_STORE=1
                                 THREADSAFE=1
                                 USE_URI

$ pip freeze
coverage==5.5

Expected behavior
I expected 100% test coverage of profiler.py.

I wonder if this doesn't work for the same reason that code using sys.settrace does not work.
I don't see anything in the documentation about it though and I was unable to find an earlier issue about it either.

It is the same reason: the profile hook and the trace hook are very similar, and neither measures the other.  I can update the docs to indicate that if that would have helped.
BTW, this is why coverage.py itself has only 93% test coverage: none of the code called during tracing can be measured.

@nedbat Yes, that docs update would be very useful, thanks!
If I understand correctly, this means that fixing this would require python-level changes and since that's been the case for years, it's unlikely to happen?

It would require changes in CPython.  I think it's unlikely to happen, not because of years of history, but because of the intricacies of Python calling your python profiling code, which is then traced by more Python tracing code.
I've thought about building a test harness to call my own tracer in a fake way, to measure it, but I've never built it out.

I've added a paragraph in 9288ef76.


Hide main window immediately when clicking Record

Fixes https://github.com/wulkano/kap/pull/262#issuecomment-340514387
This enabled me to delete a lot of code which is now moot.
DON'T MERGE THIS YET
I want to have another look tomorrow, with a clear mind, to see if there's any more code that could be deleted. Review wanted though.

@skllcrn You can try it at https://kap-artifacts.now.sh/hide-main-window

Seems to work just as intended besides the issue mentioned in https://github.com/wulkano/kap/pull/262#issuecomment-340520275

Merging this as it touches a lot of code. I'll improve it tomorrow if needed.


[fix][client] Fix failover consumer-listener stuck with cumulative ack and epoch time

Motivation
Currently, Pulsar-client lib doesn't increase the permits for the failover/exclusive consumer if it has listener and if that consumer has to filter out the messages because of incorrect epoch time. Because of that message listener will eventually stop consuming messages as you can see below that consumer doesn't have availablePermit and broker stops dispatching the messages, even if consumer has processed all sent messages by the broker.
stats

subscriptions" : {
"activeConsumerName" : "f8051",
:
"consumers" : [ {
        "msgRateOut" : 0.0,
        "msgThroughputOut" : 0.0,
        "bytesOutCounter" : 3623009,
        "msgOutCounter" : 6752,
        "msgRateRedeliver" : 0.0,
        "messageAckRate" : 0.0,
        "chunkedMessageRate" : 0.0,
        "consumerName" : "f8051",
        "availablePermits" : -2,

stats-internal

cursors" : {
    "my-failover-sub" : {
      "markDeletePosition" : "4748166582:37897",
      "readPosition" : "4748166582:37898",

18:52:18.473 [pulsar-client-internal-1003-1] WARN  org.apache.pulsar.client.impl.ConsumerBase - Consumer filter old epoch message, topic : [persistent://myProp/ns1/t1], messageId : [4748166582:37897:23], messageConsumerEpoch : [4], consumerEpoch : [5]  yrid:
18:52:18.476 [pulsar-client-internal-1003-1] DEBUG org.apache.pulsar.client.impl.MultiTopicsConsumerImpl - [persistent://myProp/ns1/t1][my-failover-sub] Received message from topics-consumer<PHONE_NUMBER>:37897:23
18:52:18.823 [pulsar-external-listener-863-1] DEBUG org.apache.pulsar.client.impl.ConsumerBase - [persistent://myProp/ns1/t1][my-failover-sub] Calling message listener for message<PHONE_NUMBER>:37897:23

Modifications
Pulsar consumer should increase permits if it discard messages due to epoch mismatch and continue processing messages with correct epoch.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report
Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.57%. Comparing base (bbc6224) to head (2c88663).
Report is 603 commits behind head on master.

Files with missing lines
Patch %
Lines

...va/org/apache/pulsar/client/impl/ConsumerBase.java
86.66%
1 Missing and 1 partial :warning:

...va/org/apache/pulsar/client/impl/ConsumerImpl.java
0.00%
1 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23345      +/-   ##
============================================
+ Coverage     73.57%   74.57%   +0.99%
- Complexity    32624    33923    +1299
============================================
  Files          1877     1934      +57
  Lines        139502   144986    +5484
  Branches      15299    15839     +540
============================================
+ Hits         102638   108118    +5480
+ Misses        28908    28597     -311
- Partials       7956     8271     +315

Flag
Coverage Δ

inttests
27.60% <0.00%> (+3.01%)
:arrow_up:

systests
24.55% <52.94%> (+0.23%)
:arrow_up:

unittests
73.91% <76.47%> (+1.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

...va/org/apache/pulsar/client/impl/ConsumerBase.java
75.30% <86.66%> (+1.17%)
:arrow_up:

...va/org/apache/pulsar/client/impl/ConsumerImpl.java
79.85% <0.00%> (+2.28%)
:arrow_up:

... and 596 files with indirect coverage changes


Fix broken link to image

/lgtm
@ronnylt thanks for fixing this!

/assign @bradamant3 @heckj
for approval :)

/approve


Added Mac OS X build to Lib folder CMakeList.txt files. Added a CPU_MATLAB simulation engine for those that don't have IPP/FW installed and want to test-drive MRiLab.

Title says most all of what's there. Hope this helps you with MRiLab. I am hoping to get access to the magnet, coil and sequence interfaces but I haven't managed that quite yet. Perhaps I have to install the ISMRSD? library.
best wishes,
--andrew

Hi,
So, is MRIlab compatible with mac os Catalina?


Tool freezes when trying to save Theorem

I created a framed invertible 1-cell, then created a snake from that, hit "Identity" to make a 3-cell, then contracted the snake, producing a 3-cell from the snake to the identity. I then pressed "Theorem" to save this, but the tool just froze and stopped working. I saved the workspace, but don't know to attach it here.

homotopy_io_export.zip

Thanks Manuel, I will look into this.

Fixed by #718.


Python servlet appears to hang after small number of sequential requests.

Prerequisites
Please answer the following questions for yourself before submitting an issue.

[x] I am running the latest code. Development is very rapid so there are no tagged versions as of now.
[x] I carefully followed the README.md.
[x] I searched using keywords relevant to my issue to make sure that I am creating a new issue that is not already open (or closed).
[x] I reviewed the Discussions, and have a new bug or useful enhancement to share.

Expected Behavior
Please provide a detailed written description of what you were trying to do, and what you expected llama-cpp-python to do.
I have installed the latest source (commit 165b4dc6c188f8fda2fc6161).  In order to minimize confusion, I compiled with CPU only support:
$ CMAKE_ARGS='-DLLAMA_CUDA=OFF' pip install -e .

I then attempted to build a minimal servlet of my own:
#!/usr/bin/env python3
from fastapi import FastAPI, HTTPException
from pydantic import BaseModel
import json
from typing import Dict, Any

from llama_cpp import Llama
from llama_cpp import llama_get_timings
from llama_cpp import llama_reset_timings

config = json.load(open("config.json"))
# config.json:
#{
#    "model_path": "/models/llama-3-8b-instruct-f16.gguf",
#    "chat_format": "chatml",
#    "ngl": -1,
#    "n_gpu_layers": -1,
#    "n_ctx": 32000,
#    "parallel": 2,
#    "temperature": 0.3,
#    "verbose": true
#}
llm = Llama(
    model_path=config['model_path'],
    chat_format=config['chat_format'],
    ngl=config['ngl'],
    n_gpu_layers=config['n_gpu_layers'],
    n_ctx=config['n_ctx'],
    parallel=config['parallel'],
    verbose=config['verbose']
)

class RequestData(BaseModel):
    prompt: str
    json_schema: Dict[str, Any]
    contact: str

app = FastAPI()

@app.post("/analyze")
def analyze_request(data: RequestData):
    user_message = f"{data.contact}\n\n{data.prompt}"
    messages = config['analyze_messages']
    messages[1]['content'] = user_message

    result = llm.create_chat_completion(
        messages=messages,
        response_format=data.json_schema,
        temperature=config['temperature'],
        stream=False
    )

    json_result = json.loads(result['choices'][0]['message']['content'])

    return json_result

if __name__ == "__main__":
    import uvicorn
    uvicorn.run(app, host="<IP_ADDRESS>", port=8000)

I run this server with:
$ uvicorn main:app --host <IP_ADDRESS> --port 9093 --workers 1

then I call it via curl with:
$ curl -s -X POST -d @analyze_request.json -H "content-type: application/json" -H "accept: application/json" http://localhost:9093/analyze

where my request looks like:
{
    "contact": "My name is John Doe and I'm 32 years old and my birthday is Feb 18th, 1994.  I was born in New York City, USA.",
    "prompt": "Please analyze the contact and produce and tell me the first name and birthplace of the individual. Respond in JSON, with the keys first_name, last_name, birthplace.",
    "json_schema": {
        "type": "json_object",
        "properties": {
            "first_name": {
                "type": "string"
            },
            "birthplace": {
                "type": "string"
            },
            "last_name": {
                "type": "string"
            }
        }
    }
}

the first couple of requests work fine and return the expected result.  However inevitably, after 3, or 5 or 15 or sometimes 40 requests the servlet will just hang.  What am I missing here?
Current Behavior
Please provide a detailed written description of what llama-cpp-python did, instead.
After 3, 5, 15, 30 requests - different each time, the server will simply stop responding and the final result will hang.  I have tried switching the GPU on and off, I have tried immitating the async and run_in_threadpool configuration in the main llama_cpp_python server lib, and using the context reset, and a variety of other things all to no avail.  I assume I must need to reset something but I cannot figure it out.
Environment and Context
Please provide detailed information about your computer setup. This is important in case the issue is not reproducible except for under certain specific conditions.

Physical (or virtual) hardware you are using, e.g. for Linux:

$ lscpu
Architecture:            x86_64
  CPU op-mode(s):        32-bit, 64-bit
  Address sizes:         48 bits physical, 48 bits virtual
  Byte Order:            Little Endian
CPU(s):                  64
  On-line CPU(s) list:   0-63
Vendor ID:               AuthenticAMD
  Model name:            AMD Ryzen Threadripper PRO 5975WX 32-Cores
    CPU family:          25
    Model:               8
    Thread(s) per core:  2
    Core(s) per socket:  32
    Socket(s):           1
    Stepping:            2
    Frequency boost:     enabled
    CPU max MHz:         7006.6401
    CPU min MHz:         1800.0000
    BogoMIPS:            7186.68
    Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constan
                         t_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave a
                         vx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpex
                         t perfctr_llc mwaitx cpb cat_l3 cdp_l3 invpcid_single hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a rdse
                         ed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoin
                         vd amd_ppin brs arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_
                         ctrl umip pku ospke vaes vpclmulqdq rdpid overflow_recov succor smca fsrm
Virtualization features:
  Virtualization:        AMD-V
Caches (sum of all):
  L1d:                   1 MiB (32 instances)
  L1i:                   1 MiB (32 instances)
  L2:                    16 MiB (32 instances)
  L3:                    128 MiB (4 instances)
NUMA:
  NUMA node(s):          1
  NUMA node0 CPU(s):     0-63
Vulnerabilities:
  Gather data sampling:  Not affected
  Itlb multihit:         Not affected
  L1tf:                  Not affected
  Mds:                   Not affected
  Meltdown:              Not affected
  Mmio stale data:       Not affected
  Retbleed:              Not affected
  Spec rstack overflow:  Vulnerable: Safe RET, no microcode
  Spec store bypass:     Mitigation; Speculative Store Bypass disabled via prctl
  Spectre v1:            Mitigation; usercopy/swapgs barriers and __user pointer sanitization
  Spectre v2:            Mitigation; Retpolines; IBPB conditional; IBRS_FW; STIBP always-on; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
  Srbds:                 Not affected
  Tsx async abort:       Not affected

Operating System, e.g. for Linux:

$ uname -a
Linux joe-llm 6.5.0-35-generic #35~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue May  7 09:00:52 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

SDK version, e.g. for Linux:

$ python3 --version
Python 3.10.12

$ make --version
GNU Make 4.3
Built for x86_64-pc-linux-gnu

$ g++ --version
g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0

Failure Information (for bugs)
Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.
Steps to Reproduce
Please provide detailed steps for reproducing the issue. We are not sitting in front of your screen, so the more detail the better.

Run the provided mini servlet
Execute the example request with the example request body
Run the same request 100 times in a row
Wait until it stalls.

Any hints about what I might be doing wrong here or ideas about how to overcome this issue would be greatly appreciated!

Update: I was able to confirm over the weekend that this issue is not related to CPU/GPU, nor to the servlet or core functionality.  Rather it seems related to this:

https://github.com/ggerganov/llama.cpp/pull/6555

I was able to confirm that if I run the exact same request, but without an grammar constraint, i.e., response_format=None, then the process never stalls or hangs, even across several thousand requests, whereas with the JSON format constraint included it will always fail, typically within 10-20 requests, and always before we hit 100 iterations.

Just to add a bit more here.  The 'hanging' decodes for JSON format responses do eventually return, but the times are exhorbitant. Always using the same example, the 'average' on my machine is about 5s per request.  However when it gets 'stuck', this balloons to 34 min.
AVERAGE
llama_print_timings:        load time =    1101.40 ms
llama_print_timings:      sample time =     319.11 ms /    31 runs   (   10.29 ms per token,    97.15 tokens per second)
llama_print_timings: prompt eval time =    1101.01 ms /   147 tokens (    7.49 ms per token,   133.51 tokens per second)
llama_print_timings:        eval time =    3397.84 ms /    30 runs   (  113.26 ms per token,     8.83 tokens per second)
llama_print_timings:       total time =    4914.17 ms /   177 tokens
TIME: ~5sec

PROBLEM
llama_print_timings:        load time =    1103.95 ms
llama_print_timings:      sample time =  105427.67 ms / 14150 runs   (    7.45 ms per token,   134.22 tokens per second)
llama_print_timings: prompt eval time =    1103.56 ms /   147 tokens (    7.51 ms per token,   133.21 tokens per second)
llama_print_timings:        eval time = 1790583.72 ms / 14149 runs   (  126.55 ms per token,     7.90 tokens per second)
llama_print_timings:       total time = 2057352.09 ms / 14296 tokens
TIME: 34min

I was able to resolve this finally. The issue was essentially user error on my part.  I was providing a grammar like:
{
      "type": "json_object",
      "properties": {
          "first_name": {
              "type": "string"
          },
          "birthplace": {
              "type": "string"
          },
          "last_name": {
              "type": "string"
          }
      },
     "required": ["first_name", "last_name", "birthplace"]
}

but I needed to provide a grammar like:
{
        "type": "json_object",
        "schema": {
            "type": "object",
            "properties": {
                "first_name": {
                    "type": "string",
                    "minLength": 2
                },
                "birthplace": {
                    "type": "string",
                    "minLength": 2,
                    "maxLength": 10
                },
                "last_name": {
                    "type": "string",
                    "minLength": 2
                }
            },
            "required": ["first_name", "last_name", "birthplace"]
        }
}

particularly, I needed to provide the top-level additional schema key, and the additional "type" : "object" under that.  I think what threw me off was that it seemed to 'mostly work' until it froze up, and this lead me to believe that there was something more fundamental going wrong at a lower level.
Interesting to note that the parser still tried, and succeeded in producing a convoluted parse of the half-broken object I was providing, and this then worked repeatedly "until it didn't".  Maybe it would make sense to try and run a quick validation of the object first before sending it to the parser/converter?  Or insist on the "schema" key?

Closing this with the self-admonishment: be careful!


Not show Bass and 3D options UI Equalizer

I have step install Equalizer, but UI not show Bass and 3D options. Please help me. Thanks.

can you describe where it is not showing? how you are using?


Upgrade dependency submodules

Attempt to address the issue in https://github.com/aviggiano/redis-roaring/issues/98. I have updated the submodules in the deps/ to point to the latest tag/release (note that main branches might be more recent):

CRoaring @ 9809c8e - v0.4.0
hiredis @ b731283 - v1.0.2
redis @ 4930d19 - 6.2.6
sds @ f74b9b7 - 2.0.0

There are other improvements worth regarding versioning but figured this would be a good first step. Also figured it worth focusing on making sure the tests pass after upgrading dependencies.

Hi @itskingori
It seems there's a small problems with the compilation on the new version
The CI is failing because of it. Can you take a look?

No problem. Today I'll take a look at it

Thanks. I have more experience with the Docker side of things and so this PR was a first step to first get the version right, then I follow up with some other image-building/scripting/packing related changes that I'm more in my domain (I'm in DevOps/SRE). So, I'm keen on your guidance.


Set up github actions for testing

It would be great if this repo ran the tests every time it received a new push.
See here for an example

hey bobbie - this could be another quick win. Could you also set up the tests for windows (like you did on the other repo). That would help out with https://github.com/supabase/doctest-js/issues/24


double-beep: Watch heppylosrow

double-beep requests the watch of the watch_keyword heppylosrow. See the MS search here and the Stack Exchange search here.

heppylosrow has been seen in 2 true positives, 0 false positives, and 0 NAAs.

!!/approve


[COU] Allowing courier to modify pickup date/time

Once "Ready fo Dispatch", Courier can also update the scheduled pickup date and time.

Once the Courier clicks the new button, they will access the following screen, where all details will be muted for changes except "Scheduled Pickup Date/Time".

Buttons

I propose that COURIER should ask for a change through a modal. A message will be sent to CMO. CMO will accept or deny it (this will may involve another fringe scenario). Once the CMO accepts it, the shipment will be updated and an update message is sent to sponsor and courier

@Mastaleru Great final result! Thanks!


Database Driven Report Params

This refactor updates the primary reports on the website to utilize a database supplied report configuration. Naming scheme and build state is not managed via report records within the postgres database so that the report job and the client can communicate explicitly.

Sorry I opened this PR up on the wrong repo!


cannot input 0.1 for drop chance it said only accept Int32

I think the drop chance of 1 means 1%, but if it's not I think you could just change the config.json itself and set it to 0.1 and test again!


NGINX build fails on Windows 10

PS F:\Code\nodock> docker-compose up -d nginx
Building nginx
Step 1/16 : FROM nginx
 ---> 5699ececb21c
Step 2/16 : RUN mkdir /etc/nginx/sites-available && rm /etc/nginx/conf.d/default.conf
 ---> Running in 05c19a8c8395
Removing intermediate container 05c19a8c8395
 ---> 53615299ba83
Step 3/16 : ADD nginx.conf /etc/nginx/
 ---> 4a2991bb05ed
Step 4/16 : COPY scripts /root/scripts/
 ---> 8a8e3f3a2497
Step 5/16 : COPY certs /etc/ssl/
 ---> fdbbd4bbc04e
Step 6/16 : COPY sites /etc/nginx/templates
 ---> 0920fd03b516
Step 7/16 : ARG WEB_REVERSE_PROXY_PORT=8000
 ---> Running in 69ae203cbda8
Removing intermediate container 69ae203cbda8
 ---> fe6c54e0abc5
Step 8/16 : ARG WEB_SSL=false
 ---> Running in 5decb625eda8
Removing intermediate container 5decb625eda8
 ---> c14f6eb191ba
Step 9/16 : ARG SELF_SIGNED=false
 ---> Running in 4a4eb1069fc5
Removing intermediate container 4a4eb1069fc5
 ---> d57093e65e15
Step 10/16 : ARG NO_DEFAULT=false
 ---> Running in b2d189c568d0
Removing intermediate container b2d189c568d0
 ---> 0f064b5a56f3
Step 11/16 : ENV WEB_REVERSE_PROXY_PORT=$WEB_REVERSE_PROXY_PORT
 ---> Running in e32965edeebe
Removing intermediate container e32965edeebe
 ---> d47654c41b28
Step 12/16 : ENV WEB_SSL=$WEB_SSL
 ---> Running in c2fbbb6a5777
Removing intermediate container c2fbbb6a5777
 ---> 1fe5abeeea87
Step 13/16 : ENV SELF_SIGNED=$SELF_SIGNED
 ---> Running in 563dbf23caf5
Removing intermediate container 563dbf23caf5
 ---> a76503b24b5d
Step 14/16 : ENV NO_DEFAULT=$NO_DEFAULT
 ---> Running in b7299fbeaaf9
Removing intermediate container b7299fbeaaf9
 ---> 31e87361e83f
Step 15/16 : RUN /bin/bash /root/scripts/build-nginx.sh
 ---> Running in 5e39752dc129
/root/scripts/build-nginx.sh: line 2: $'\r': command not found
/root/scripts/build-nginx.sh: line 3: syntax error near unexpected token `$'do\r''
'root/scripts/build-nginx.sh: line 3: `for conf in /etc/nginx/templates/*.conf; do
ERROR: Service 'nginx' failed to build: The command '/bin/sh -c /bin/bash /root/scripts/build-nginx.sh' returned a non-z
ero code: 2

@pranshubarve Seems to be related to the line endings. Make sure you save the build-nginx.sh script with unix line endings.
The dos2unix utility can help you with this: dos2unix build-nginx.sh otherwise your editor may allow you to directly change line endings.
I'm don't really develop on Windows sadly so I'm unsure what other tooling exists for this.

@pranshubarve Seems to be related to the line endings. Make sure you save the build-nginx.sh script with unix line endings.
The dos2unix utility can help you with this: dos2unix build-nginx.sh otherwise your editor may allow you to directly change line endings.
I'm don't really develop on Windows sadly so I'm unsure what other tooling exists for this.

OK Thank you, I will check soon.

@pranshubarve great, keep me updated!

@pranshubarve let me know how it goes 😄


Add guidelines towards determining an assignee for a pull request

While on-boarding to the @artsy engineering team, I found this rubric by @orta helpful towards determining a team member to assign to a new pull request.

@joeyAghion Hey, good morning! Any more feedback on this PR?

Seeing as @joeyAghion already gave his +1, I’ll take this.


weird behaviour when there is a ">" at the end of RowTag

By accident I had pasted the Row element name in my configuration with the trailing ">"
    df = (spark.read.format('xml')
         .options(rowTag='RowElement>')
         .load(file_location)
     )

It resulted in a valid dataframe with a schema that was expected from the data.
however when I displayed the resulting dataframe it only had 7 rows instead of the 408238 rows I was expecting
the rows were roughtly 58k apart .. so must be some "long line parsing" artifact.
so maybe its good to "sanitize" or "validate" the rowTag option to not include any XML restricted chars

Yeah it can't have the angle bracket. If it does it will probably read the closing bracket as part of the tag, then keep searching for the next angle bracket to close it, which would mean it skips some random data. Maybe I should have it throw an error in this case

Cool .. thanks for the quick solution 👍


Mobile shell package by default

Let's use mosh by default as well as ssh! It's secure as ssh and can deal with connection interruptions that is common for mobile robots with wireless connectivity.

Added in https://github.com/airalab/airapkgs/commit/e38450c89e253dbe9bd9fc1fb6ed76af6b613708


how can i follow the perivate users?

perivate users will be to skip...

When your script initializes the bot, add the parameter: filter_users = False

Now this filter will be false by default. Update your instabot

pip install -U instabot


[Docker Agent 1.17] After Containers rotates logs datadog agents stop send logs

Output of the info page (if this is a bug)
===============
Agent (v7.17.0)
===============

  Status date: 2020-02-12 14:36:14.226983 UTC
  Agent start: 2020-02-11 21:55:50.611689 UTC
  Pid: 345
  Go Version: go1.12.9
  Python Version: 3.7.6
  Build arch: amd64
  Check Runners: 4
  Log Level: debug

  Paths
  =====
    Config File: /etc/datadog-agent/datadog.yaml
    conf.d: /etc/datadog-agent/conf.d
    checks.d: /etc/datadog-agent/checks.d

  Clocks
  ======
    System UTC time: 2020-02-12 14:36:14.226983 UTC

  Host Info
  =========
    bootTime: 2020-02-11 01:50:39.000000 UTC
    kernelVersion: 4.19.95-coreos
    os: linux
    platform: debian
    platformFamily: debian
    platformVersion: bullseye/sid
    procs: 71
    uptime: 20h5m14s
    virtualizationRole: guest
    virtualizationSystem: docker

  Hostnames
  =========
    ec2-hostname: ip-*-*-*-*.us-west-2.compute.internal
    hostname: i-08c****3b
    instance-id: i-08c********3b
    socket-fqdn: 48******b
    socket-hostname: ***b***
    host tags:
      docker_swarm_node_role:worker
    hostname provider: aws
    unused hostname providers:
      configuration/environment: hostname is empty
      gce: unable to retrieve hostname from GCE: status code 404 trying to GET http://<IP_ADDRESS>/computeMetadata/v1/instance/hostname

  Metadata
  ========
    cloud_provider: AWS
    hostname_source: aws

=========
Collector
=========

  Running Checks
  ==============

    cpu
    ---
      Instance ID: cpu [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/cpu.d/conf.yaml.default
      Total Runs: 4,002
      Metric Samples: Last Run: 6, Total: 24,006
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s

    disk (2.6.0)
    ------------
      Instance ID: disk:e5dffb8bef24336f [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/disk.d/conf.yaml.default
      Total Runs: 4,001
      Metric Samples: Last Run: 194, Total: 776,194
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 71ms

    docker
    ------
      Instance ID: docker [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/docker.d/conf.yaml.default
      Total Runs: 4,001
      Metric Samples: Last Run: 178, Total: 648,640
      Events: Last Run: 0, Total: 18
      Service Checks: Last Run: 1, Total: 4,001
      Average Execution Time : 60ms

    file_handle
    -----------
      Instance ID: file_handle [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/file_handle.d/conf.yaml.default
      Total Runs: 4,001
      Metric Samples: Last Run: 5, Total: 20,005
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s

    io
    --
      Instance ID: io [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/io.d/conf.yaml.default
      Total Runs: 4,001
      Metric Samples: Last Run: 117, Total: 468,036
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 1ms

    load
    ----
      Instance ID: load [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/load.d/conf.yaml.default
      Total Runs: 4,001
      Metric Samples: Last Run: 6, Total: 24,006
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s

    memory
    ------
      Instance ID: memory [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/memory.d/conf.yaml.default
      Total Runs: 4,001
      Metric Samples: Last Run: 17, Total: 68,017
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s

    network (1.14.0)
    ----------------
      Instance ID: network:e0204ad63d43c949 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/network.d/conf.yaml.default
      Total Runs: 4,002
      Metric Samples: Last Run: 31, Total: 124,062
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 3ms

    ntp
    ---
      Instance ID: ntp:d884b5186b651429 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/ntp.d/conf.yaml.default
      Total Runs: 67
      Metric Samples: Last Run: 0, Total: 0
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 67
      Average Execution Time : 20.017s

    uptime
    ------
      Instance ID: uptime [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/uptime.d/conf.yaml.default
      Total Runs: 4,001
      Metric Samples: Last Run: 1, Total: 4,001
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s

========
JMXFetch
========

  Initialized checks
  ==================
    no checks

  Failed checks
  =============
    no checks

=========
Forwarder
=========

  Transactions
  ============
    CheckRunsV1: 4,001
    Dropped: 0
    DroppedOnInput: 0
    Events: 0
    HostMetadata: 0
    IntakeV1: 446
    Metadata: 0
    Requeued: 0
    Retried: 0
    RetryQueueSize: 0
    Series: 0
    ServiceChecks: 0
    SketchSeries: 0
    Success: 8,448
    TimeseriesV1: 4,001

  API Keys status
  ===============
    API key ending with a2379: API Key valid

==========
Endpoints
==========
  https://app.datadoghq.com - API Key ending with:
      - a2379

==========
Logs Agent
==========
    Sending uncompressed logs in SSL encrypted TCP to agent-intake.logs.datadoghq.com on port 10516
    BytesSent: 7.39424441e+08
    EncodedBytesSent: 7.39424441e+08
    LogsProcessed: 1.047821e+06
    LogsSent: 1.047821e+06

  container_collect_all
  ---------------------
    Type: docker
    Status: OK
    Inputs: 457e7b8b6fb1cff5300315ba08dbc2414e85a2533bbe8d753994a86605422858 86ab21e54f8d431dc55adeca261b4821e4b92e1ab6ec76d86e866f889b276262 107b6b0e065424c10ad9d7c362722628c16db711bc38b4870faf780ade522618 a3f92f59e858c8486ff421750f6e3acaa7064a65c70a31c685cb9e49dda0399b 4b044fd1fc5bb660e000d3bbb84df02c48f4aaf6ef9e4833a624b14a22427198

=========
Aggregator
=========
  Checks Metric Sample: 2.2 M
  Dogstatsd Metric Sample: 16,006
  Event: 19
  Events Flushed: 19
  Number Of Flushes: 4,001
  Series Flushed: 1.6 M
  Service Check: 40,146
  Service Checks Flushed: 44,142

=========
DogStatsD
=========
  Event Packets: 0
  Event Parse Errors: 0
  Metric Packets: 16,005
  Metric Parse Errors: 0
  Service Check Packets: 0
  Service Check Parse Errors: 0
  Udp Bytes: 836,257
  Udp Packet Reading Errors: 0
  Udp Packets: 16,006
  Uds Bytes: 0
  Uds Origin Detection Errors: 0
  Uds Packet Reading Errors: 0
  Uds Packets: 0

Describe what happened:
When the error: Error streaming logs: unexpected EOF container=3ef3590c8d13bf72aed418445af9f66fb5871ac0921e841b5117dcf325e260f4 (in the app container) occurs in the docker daemon logs, the datadog agent send to datadog the line grabbing logs: unexpected EOF and after that stop send more logs, for that container, until the container restarts and/or update the related stack.
The agent logs don’t show errors (even with debug log level) and the app container logs keep coming through without issues.
Describe what you expected:
The datadog agent keep sending logs from the container
Steps to reproduce the issue:
In at docker cluster swarm with json-file with json logs when rotates the log file in the container app and in the docker daemon logs shows 'Error streaming logs: unexpected EOF'
Additional environment details (Operating System, Cloud provider, etc):

AWS with EC2 instances
Docker CE 18.06 (docker swarm)
CoreOS 2303.4.0
Docker Datadog Agent (1.17)

Hi @cesarcelism, thanks for reporting this issue. We've had other reports of this issue as well, and we're currently working on a fix (#4860).
Could you share your full docker log settings as well (in particular max-file and max-size)? If it contains information you would not want to share in a public issue, feel free to email it to<EMAIL_ADDRESS>and refer to this issue in your email.
I'll update this issue when we have an image that ships a fix.

Thanks for the answer
The compose files from the app and the docker datadog-agent setup:
version: '3.4'

services:
  app:
    image: "${DOCKER_IMAGE}:${DOCKER_TAG}"
    environment:
      DB_USER: ${SERVICE_LIVE_DB_USER}
      DB_PASS: ${SERVICE_LIVE_DB_PASSWORD}
    deploy:
      replicas: ${SERVICE_APP_REPLICAS}
      labels:
        - "traefik.frontend.rule=Host:${APP_DOMAIN}"
        - "traefik.port=${PORT}"
    networks:
      - webgateway
      - bridge
    logging:
      driver: json-file
      options:
        max-size: "100m"

networks:
  webgateway:
    external: true
  bridge:
    external: true

datadog agent
version: '3.2'

services:

  datadog:
    image: datadog/agent:7.17.0
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro
      - /proc/:/host/proc/:ro
      - /sys/fs/cgroup/:/host/sys/fs/cgroup:ro
      - logs:/opt/datadog-agent/run
    deploy:
      mode: global
    environment:
      DD_API_KEY:${DD_API_KEY}
      DD_PROCESS_AGENT_ENABLED: "true"
      DD_DOGSTATSD_NON_LOCAL_TRAFFIC: "false"
      DD_LOGS_ENABLED: "true"
      DD_LOG_LEVEL: "debug"
      DD_LOGS_CONFIG_CONTAINER_COLLECT_ALL: "true"
      DD_AC_EXCLUDE: "image:datadog.*"
    logging:
      driver: json-file
      options:
        max-size: "100m"

Thanks for sharing this @cesarcelism, based on your setup https://github.com/DataDog/datadog-agent/pull/4860 should indeed fix the bug you're experiencing, I'll keep you posted when an image that includes a fix is available.

I'm testing in my pre-production environment with 1.18.0-rc.1 without issues in the last 2 days 😃 . I'll be waiting for the 1.18.0 to upgrade my production environment.
Thanks!

problem resolved at 7.20.0 🙇🏽


chore: add auto approve/merge for dependabot

Coverage remained the same at 100.0% when pulling c6a76069b5abb4e24629aba042bc76e3c963d133 on add-auto-merge-dependabot into 83ff79f9b6be3fa423f7cfe7b188c94aba27dc31 on main.

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Magogenie questions(related to MathML) not rendering properly onto content curation server

Summary
After importing magogenie content successfully onto content curation server. "MathML" not rendered the questions properly.
Link used
https://contentworkshop.learningequality.org/channels/ed8a74787e9f5bfaba57db5d81c8b099/edit
Channel ID: ed8a74787e9f5bfaba57db5d81c8b099
Screenshots

@rtibbles @aronasorman can you put a ETA on this? Its a blocker for the MG channel.

@aronasorman this should be achievable using a combination of https://github.com/transpect/mml2tex and then leveraging the xslt file in Python: http://stackoverflow.com/questions/16698935/how-to-transform-an-xml-file-using-xslt-in-python#answer-16699042

The Perseus exercise renderer does not support MathML. Math formulas will need to be converted into latex format, and then inserted into the exercise text surrounded by $ symbols.
For example, if you put in $ f(x) = 2 ^ 3 $, it will be rendered as:

@rtibbles @aronasorman @jamalex @jayoshih For more clarification, will this issue be handled in ricecooker or we need to handle it in our code (i.e sushi chef). I remember @aronasorman had taken care of the same issue before.

@yogeshmhaskule See https://github.com/fle-internal/content-curation/issues/222 You'll need to convert it to latex to bypass the html escaping using the tools @rtibbles mentioned

@jayoshih @aronasorman If you provide sample example of convert mathml data to latex in "Sample program file". So we can take reference from it. It will helpful to us to move forward.

Again, as this isn't something we support in the ricecooker, it's the responsibility of the sushi chef to convert into usable formats. You can use whatever tools you want to do the conversion, before passing it into the ricecooker.
Here's an example:

Install xsltproc (e.g., on Ubuntu, sudo apt-get install xsltproc)
Download and unzip these xslt specifications
Run a file with MathML in it through the converter:

> cat test.mml
<math xmlns="http://www.w3.org/1998/Math/MathML">
  <mrow>
    <mfrac>
      <mrow><mi>x</mi></mrow>
      <mrow><mi>y</mi></mrow>
    </mfrac>
  </mrow>
</math>

> xsltproc mmltex.xsl test.mml > test.tex

> cat test.tex
$ \frac{x}{y}$

You can either use a tool like that and run it from Python via subprocess, or you may be able to plug those xslt definitions into the tool @rtibbles linked to do it directly within Python.

@jamalex @aronasorman I went through the xsltproc and it's working for me. But few of mathml questions are not  rendering properly onto kolibri. This issue is specially to mathml which contains text. Latex conversion of same question is  $ Convert the improper fraction into whole number.\phantom{\rule{0ex}{0ex}}\frac{12}{3}$. And same data shown on cc server. After importing the questions it removes the white spaces between question text (Converttheimproperfractionintowholenumber.).
Screenshot of cc

Screenshot of kolibri

@yogeshmhaskule Can you post the full source HTML & MathML for that source question into the issue here? It seems as if the first sentence should be left outside the $, as it's not a math formula.

@jamalex Below is the response of same question.
{
	'48113': {
		'success': True,
		'question': {
			'answer_type': 'number',
			'id': 48113,
			'topic_id': 2890,
			'unit': None,
			'difficulty_level': 1,
			'content': '<math xmlns="http://www.w3.org/1998/Math/MathML"><mi>C</mi><mi>o</mi><mi>n</mi><mi>v</mi><mi>e</mi><mi>r</mi><mi>t</mi><mo> </mo><mi>t</mi><mi>h</mi><mi>e</mi><mo> </mo><mi>i</mi><mi>m</mi><mi>p</mi><mi>r</mi><mi>o</mi><mi>p</mi><mi>e</mi><mi>r</mi><mo> </mo><mi>f</mi><mi>r</mi><mi>a</mi><mi>c</mi><mi>t</mi><mi>i</mi><mi>o</mi><mi>n</mi><mo> </mo><mi>i</mi><mi>n</mi><mi>t</mi><mi>o</mi><mo> </mo><mi>w</mi><mi>h</mi><mi>o</mi><mi>l</mi><mi>e</mi><mo> </mo><mi>n</mi><mi>u</mi><mi>m</mi><mi>b</mi><mi>e</mi><mi>r</mi><mo>.</mo><mspace linebreak="newline"/><mfrac><mn>12</mn><mn>3</mn></mfrac></math>'
		},
		'possible_answers': [{
			'question_id': 48113,
			'content': '4',
			'id': 114224,
			'is_correct': True
		}]
	}
}

The MathML in the first example doesn't seem quite proper. It splits each letter of the non-math content into separate symbols. When I render it using an online MathML renderer, I get:

The format of the second example (which renders properly) looks correct -- non-math text is outside of the <math> block.

@jamalex There are quite a few questions on MagoGenie front, that are of the first type (The entire question with the text declared as Math ML). Is there a way to work around for these set of questions.
For the second one, its not a problem since only the equations or the formulas are declared as MathML and we can import them without road block.

It will probably require a pre-processing stage that detects and extracts the non-math text from the MathML block, before going through xsltproc. Depending on how consistently this content is marked up, it may be possible to do this with regular expressions, or else through parsing with an XML parser like lxml or maybe BeautifulSoup.
To more easily test final output and how it will look in Kolibri, you can use this tool:
http://khan.github.io/perseus/
(Put the output text in the Question box, and click "view rendered")


⚠ Samsung has degraded performance

In 1cfd4a2, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2818 ms

Resolved: Samsung performance has improved in 290814c.


grey "fixed" shield for circleci should just be a green "passing" shield

otherwise, the current state depends on the previous state (ie. sometimes a passing build shows up as "passing", sometimes as "fixed"). the behavior should be to always show either "failing" or "passing".

Thanks for pointing this out! I'd love you to provide an example badge with gives "fixed", so that I can check that I'm… fixing… the issue.

Tell me if this fixes things.


CurrentItem doesn't refresh if the ItemsSource collection is edited

Hi, and thanks for a great component!
I found this issue where the card view's CurrentItem doesn't update if the currently active card is removed from the ItemsSource. I haven't verified but I guess the same thing will happen if a card is added to the collection before the current card.
I added the following workaround to my code for now:
        public void HackRefreshCardsViewCurrentItem()
        {
            object selectedItem = null;
            int index = 0;
            foreach (var item in this.cards.ItemsSource)
            {
                if (index++ == this.cards.SelectedIndex)
                {
                    selectedItem = item;
                    break;
                }
            }
            this.cards.SelectedItem = selectedItem;
        }

... which I call whenever I change the card view's ItemsSource (ie it forcefully refreshes the SelectedItem).
Would be great if this was fixed so I could remove my hack! My card view is in the PanCardView mode.
Thanks so much!

v.2.5.1

Wow, so fast and it works perfectly now! Thanks so much Andrei 👍

Wow, so fast and it works perfectly now! Thanks so much Andrei 👍

you are welcome)


disable rectify image when loading in videos

Videos save the rectified images. The rectified box is checked as default and hence buggers up the matching when a video is loaded.

So you load the video (calibrated), another calibration is already loaded and you can't disable rectification?

Sorry Josh, that makes me sound like a princess that can't click a button :)
I discussed this with Ben stating that a user might think it's not working when it's actually just because it has rectified twice. It was mainly mean't as a good to have when we release it properly.
I'll include the assignees as Ben in the future to avoid confusion :)

No worries. :)
One option would be to have a dialog menu when loading to choose e.g.frame
rate (currently we guess), calibration/pre-calibrated, etc.
On Fri, Nov 23, 2018, 11:45 bcrutchleyi3dr<EMAIL_ADDRESS>wrote:

Sorry Josh, that makes me sound like a princess that can't click a button
:)
I discussed this with Ben stating that a user might think it's not working
when it's actually just because it has rectified twice. It was mainly
mean't as a good to have when we release it properly.
I'll include the assignees as Ben in the future to avoid confusion :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/i3drobotics/stereo-vision-toolkit/issues/9#issuecomment-441221027,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADA2JxUS5wvyhXyH0jul8O25pr1jddXQks5ux9_0gaJpZM4YtTeD
.

See enhancement: #25


Fix read line issue

getOneLine () doesn't work because line isn't a tool we can use - causing an error. Using read line in place of getOneLine works.

Whoops, I meant to LGTM and accidentally merged, but LGTM!


Embedded figures without captions fail JATS validation

Right now the caption has to be at the top of the figure node. If a caption is not included by default, then the embedded source creation creates a caption that is at the bottom of the figure. This isn't valid.
For example:
:::{figure} #interactive-output
:::

Creates this output

The error:

Oh - I realize this generated caption was totally broken by https://github.com/executablebooks/mystmd/pull/477 when I reduced the structure figure > embed > block > output -> figure > output - that is relied on here: https://github.com/executablebooks/mystmd/blob/main/packages/myst-to-jats/src/transforms/containers.ts#L46-L49 (test coverage 😬).
Gotta revive that, then reproduce this and fix if necessary.


Few questions related to POST, top level members..

Hello
First thanks for the spec. I saw Steve Klabnik talking about it few month and trying to turn my api to v2 with the json api specs, but I have few questions

I want to be able to add or update comment related to an app. Api response to successful post or update (different status code) with that.

POST /api/v1/:store_id/applications/:mobile_application_update_id/comments 201 if created
{
  "links":{
    "self":"https://store.com/api/v1/applications/:application_id/comments"
  },
    "data":{
      "type":"comment",
      "id":3904,
      "attributes":{
        "comment":"yeehhhhaaa",
        "rating":"3.0",
        "user_name":"B. 2",
        "user_id":123,
        "created_at":"2015-05-29T16:23:20.639+02:00",
        "updated_at":"2015-05-29T16:23:20.639+02:00"
      },
      "relationships":{
        "rating":0,
        "comments":[
        {
          "type":"comment",
          "id":3904,
          "attributes":{
            "comment":"yeehhhhaaa",
            "rating":"3.0",
            "user_name":"B. 3",
            "user_id":123,
            "created_at":"2015-05-21T09:05:19.388+02:00",
            "updated_at":"2015-05-21T09:59:22.417+02:00"
          }
        },
        {
          "type":"comment",
          "id":3875,
          "attributes":{
            "comment":"love tdd",
            "rating":"4.0",
            "user_name":"B. 3",
            "user_id":114,
            "created_at":"2015-05-20T15:12:25.988+02:00",
            "updated_at":"2015-05-20T15:12:25.988+02:00"
          }
        }
        ]
      }
    }
}

First I found that adding attributes is quite "noisy". In the spec it's wrote that it : MAY contain any of these top-level members. Is it for clarity ?

rating here, have not top level member, doesn't seems a problem for me except for constituency with the rest of the json response. What do you think?

For the Fetching Relationships parts, does the urls given just below are recommendations?

Thanks in advance for your feedbacks.
Benoit

I want to be able to add or update comment related to an app.

This isn't supported just yet, but has been much discussed. See #536 for the latest.

First I found that adding attributes is quite "noisy".

The attributes bag in the spec so that top-level members that the base spec may add to resource objects in the future (that is, sibling properties to "attributes") won't be at risk of conflicting with user-defined attributes.

rating here, have not top level member

Since rating is just a scalar value, it seems like it should just go in attributes. Is there any reason not to do that?

This has been much discussed though. See #536 for the latest.

Thanks, very interesting.

Is there any reason not to do that? (Also, what is rating representing here...I'm a bit confused.)'

Because on my app, this is difference object. rating is an average of the rating of all the comment. :) It's probably not the right name.
Thanks Ethan


updated functional IP descriptions

Hi, thank you for your contribution to Mantl! Before we can accept any code into
master, we need it to meet the following criteria. If there are any you can't
satisfy yourself, go ahead and open the pull request anyway and we'll help you
test. Feel free to delete this message once you're done. Thanks again!

[ ] Installs cleanly on a fresh build of most recent master branch
[ ] Upgrades cleanly from the most recent release
[x] Updates documentation relevant to the changes

Current IP output example

@johnswil Thanks!


Move dependency to request into peerDependencies

Fix #117

Coverage remained the same at 100.0% when pulling 305ca54f8741dde876346dc517fa048ba80086e3 on mathieug:patch-1 into 56a6fa1c52f3089747998c1739333fe847d658c1 on request:master.

Hi @mathieug , I just released<EMAIL_ADDRESS>which defines request as a peer dependency. I forgot to merge your pull request when it was still possible. I am sorry that you didn't make it into the contributors list because of that.

No worries, thanks for the v4.


Descriptions with commas are not handled correctly

Descriptions with commas are not handled correctly, csv file gets corrupted.

https://github.com/epsagon/list-lambdas/pull/23


Small Typo in the tutorial

In step 13.c of Lesson 3 of the Groceries tutorial, right where it says
Let’s break down how this layout works, starting with the outer structure of the markup.
<GridLayout rows="auto, *">   <GridLayout row="0" class="add-bar">...</GridLayout>   <ListView row="1">...</ListView> </GridLayout>
I believe, the code should instead be,
<GridLayout rows="auto, *">   <GridLayout row="0" class="add-bar">...</GridLayout>   <RadListView row="1">...</RadListView> </GridLayout>

Thank you for letting us know, @shikhin21! Feel free to open a pull-request in such cases. ;)


Provide consumer proguard configuration

Currently, any android build fails if minifyEnabled true is enabled. The source is, sun.misc.Unsafe, since -dontwarn sun.misc.Unsafe solves the issue.
Suggested solution is, add a consumer proguard file in the library project: consumerProguardFiles 'proguard-rules.pro' with at least -dontwarn sun.misc.Unsafe in it.

I can´t confirm this. My app is building without adding any proguard rules for ObjectBox.

That's weird. For me, this breaks even the debug build:
        debug {
            minifyEnabled true
            useProguard false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
            signingConfig signingConfigs.debug
        }

But, with minify disabled, everything is building:
        debug {
            minifyEnabled false
            useProguard false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
            signingConfig signingConfigs.debug
        }

I have removed all of the ObjectBox references, and the project was building again, after adding only the gradle plugin and library, the project would break once again.
Is there a chance that maybe another library brings the mentioned rule for you, so your build still works?

Maybe you have other dependencies? Or maybe some of my dependencies are providing a proguard file with the required rules.

This is my proguard file:
-keepclassmembers class ** {
    @com.squareup.moshi.FromJson *;
    @com.squareup.moshi.ToJson *;
}
# Platform calls Class.forName on types which do not exist on Android to determine platform.
-dontnote retrofit2.Platform
# Platform used when running on RoboVM on iOS. Will not be used at runtime.
-dontnote retrofit2.Platform$IOS$MainThreadExecutor
# Platform used when running on Java 8 VMs. Will not be used at runtime.
-dontwarn retrofit2.Platform$Java8
# Retain generic type information for use by reflection by converters and adapters.
-keepattributes Signature
-dontwarn okio.**

I think another library provides the rule for you. If the only change I'll make is to remove ObjectBox from my project, the build will work once again with minifyEnabled true, but if I add ObjectBox again, the build will break.

Great, that should do the trick, thanks!


Aspect ratio wrong

All,
I played the Hope stream on my Samsung Galaxy S20 and the aspect ratio is completely wrong.
Thanks
Thomas

On my Moto G5S plus (Android 8.1.0), the Hope stream started correct, then changed to have the wrong aspect ratio (compressed vertically with black bars added) and then changed back again.
This looks like a stream problem & hence we might want to remove Hope from the master service list.

On my wide format Huawei Mate 10 Pro (1440x720) it starts correctly

but then the aspect ratio is messed up

This is not related to the DVB-I Reference Client, but possibly dash.js or the encoding/packaging itself, since the same issue occurs when playing https://reference.dashif.org/dash.js/nightly/samples/dash-if-reference-player/index.html in https://reference.dashif.org/dash.js/nightly/samples/dash-if-reference-player/index.html

Ok - maybe someone can file an issue here: https://github.com/Dash-Industry-Forum/dash.js/issues/new/choose

Done here https://github.com/Dash-Industry-Forum/dash.js/issues/3459

This is an issue with the content. Chrome scales to dimensions: "2560x720" in dash.js and Shaka on the highest quality. There is only one init segment for all representations although they differ in sample aspect ratio and resolution. Might be worth checking

Lets remove this service from our service list and close this issue


Not able to clone the repository  or pull latest changes on Windows 11

Current Behavior
Cloning the repository or pulling the latest changes on windows leads to an error
Cloning into 'meshery'...
remote: Enumerating objects: 114324, done.
remote: Counting objects: 100% (4368/4368), done.
remote: Compressing objects: 100% (1143/1143), done.
remote: Total 114324 (delta 3021), reused 4306 (delta 2989), pack-reused 109956
Receiving objects: 100% (114324/114324), 247.78 MiB | 1.90 MiB/s, done.
Resolving deltas: 100% (80462/80462), done.
error: invalid path '.github/scripts/pub?gid=0&single=true&output=csv'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

I was able to clone the repo by running the command
git config core.protectNTFS false

but the files whose paths were shown as invalid were deleted and it showed up in the changes
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        deleted:    .github/scripts/pub?gid=0&single=true&output=csv
        deleted:    .github/scripts/pub?gid=0&single=true&output=csv.1
        deleted:    .github/scripts/pub?gid=0&single=true&output=csv.2

Expected Behavior

Screenshots/Logs

Environment

Host OS:  Windows
Platform: Docker or Kubernetes
Meshery Server Version: stable-v
Meshery Client Version: stable-v

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Thanks for filing this. And for sharing the details of how are you have overcome the situation with filename in file system and compatibility. This is a straightforward fix.

hey @leecalcote can I ask what the straightforward fix is/was?

@deepakdinesh1123 you can try
git restore --source=HEAD :

this will restore all the deleted files.
the error "warning: Clone succeeded, but checkout failed." means files in the repository were successfully copied to your local machine, but the process of setting the correct version of the files in your working tree failed. I am not sure how to resolve this though

Fixed by removal of Windows-incompatible filenames.


Can it be used normally on Linux because I see it uses exe.

As the title suggests, can my service also be used in a Linux environment.

No, because Topaz Photo AI does not run on Linux.


Added Bsc Mdex Vaults: USDT-USDC USDT-BUSD RABBIT-BUSD

mooMdex-bscRABBIT-BUSD
Vault: https://bscscan.com/address/0x81A51a48605bC158485040372dDAf26B83C555d8#code
Strategy: https://bscscan.com/address/0x83275A4bF921226eacf08c1aFB1dac7679E0f386#code
mooMdex-bscUSDT-BUSD
Vault: https://bscscan.com/address/0x5a3BdbC7880510EFed1c5D56eCF7c279848264A8#code
Strategy: https://bscscan.com/address/0x310A180449Dc84782ea312D62da8bF13b1613c4a#code
mooMdex-bscUSDT-USDC
Vault: https://bscscan.com/address/0x909eFB6A634F3BB9509c333070e64bFde76CFb05#code
Strategy: https://bscscan.com/address/0x4ff54B1D6F2034c8F1Df7fdb3ace7932e9Bf80F2#code
Beefy API PR:
https://github.com/beefyfinance/beefy-api/pull/352

no sense to add "-bsc" to the mooToken, as token is already belong to bsc

Check out this strategy that makes use of the ISwapMining
Mdex FIL-USDT

thanks now I am checking that

Changes done
vaults remades, setting new strategy with ISwapMining:

USDT-USDC
USDT-BUSD
RABBIT-BUSD

new vault added

USDT-BTCB

.


Changing themes from light to dark does not work

Trying to change my theme to dark does not do anything.

It's changes the plugin icon

That should be changed to say "Icon theme" since it seems to imply it changes the background of the wakatime preferences


id3 cookbook

Thanks!
Whats needed is integration testing data for travis to execute the test

Thanks!
Fine to merge after minor comments have been addressed and integration testing data is in

Updates?

https://github.com/shogun-toolbox/shogun-data/pull/99

Can you squash and write a better commit message? Want to merge this one soon

Way too old


Fixed issue where removing event handler which wasn't added was removing all event's handlers except of the last one.

@HenrikJoreteg I've encountered on a case in my code where handler was being removed before it was added.
It took a while to track down the issue but in the end, it turned out if there are multiple handles attached and if we want to remove a handler which wasn't added (so indexOf would return -1) then all event handlers would be removed except of the last one in the array.

a = [1,2,3]
i = a.indexOf(10)
a.splice(i, 1)
// result = a = [3]

published as 1.2.1, thanks!


Allow dead code in examples to fix CI build

The examples deny warnings, however a couple of examples deserialise TOML into
structs. The fields of these structs are never read, which breaks cargo test
in nightly mode.
Allow dead code to fix the CI build, as discussed on #447.

Thanks!


using tsd on TravisCI throws a HTTP status code 403

I'm using tsd on TravisCI to install some definitions and it seems like I just got a HTTP status code 403 from Git during the tsd install command. You can check the errored build and see more info.
Maybe it's worth mentioning that I am using the API from a node script (gulpfile.js) and not in the CLI.

@rolandjitsu Are you using the latest version? Have you tried add your key to the environment under TSD_GITHUB_TOKEN=... (https://github.com/DefinitelyTyped/tsd#tsdrc under token)?

Same issue related here https://github.com/DefinitelyTyped/tsd/issues/163
Just to complement the @blakeembrey response, the version using process.env.TSD_GITHUB_TOKEN are not at npm yet. you will need to use solve it using .tsdrc file.

Just to complement the @blakeembrey response, the version using process.env.TSD_GITHUB_TOKEN are not at npm yet

Shoot, sorry. We should probably release a patch for it :smile:

@blakeembrey yes, 6.0.1 I think, that's the latest right? I have not tried to add my key to the env though, did not know about it.

@Diullei I think that version is there, I just used that strategy with TSD_GITHUB_TOKEN and it seems to have worked.
@blakeembrey shall this issue be closed?

I think we can close this once the version with TSD_GITHUB_TOKEN is released, likely today. I just shot @Diullei an email with some issues I run into during publish of 0.6.2.

Ok, give it a go with 0.6.3 now :smile:


Streamable Candles

I've made a change to AnalyzableBase to allow for Candles to be streamed, rather than having to pass in the entire collection every time. if you can kindly create a branch where I can push these changes for you to review. I have a fork where progress can be reviewed. :) ObservableAnalyzableBase
thanks,
Mina

@byteshadow Thanks for your effort 😄 I'm looking forward to it 👍

Merge to #59 for more exposure


Populate simulation results to fix progress ordering

What are these @Observed(name = "function_profile") things?

Those are for the Grafana Dashboard that @dgauldie set up.


Fix snapshotting searchable snapshot indexes

Two changes here: First, when snapshotting a searchable snapshot index (or snapshotting a full cluster that contains searchable snapshot indices) then we will snapshot the index metadata which includes the pointer to the original snapshot, but skip copying the data since it already exists in the source snapshot. Second, when restoring an index from a snapshot that is itself a searchable snapshot index, then it must be handled as such and restored as a searchable snapshot index.
Resolves #7204
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #7247 (f05e8d2) into main (9f6c067) will decrease coverage by 0.59%.
The diff coverage is 47.05%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #7247      +/-   ##
============================================
- Coverage     71.18%   70.59%   -0.59%
+ Complexity    59887    59457     -430
============================================
  Files          4859     4859
  Lines        285505   285527      +22
  Branches      41143    41150       +7
============================================
- Hits         203223   201562    -1661
- Misses        65924    67365    +1441
- Partials      16358    16600     +242

Impacted Files
Coverage Δ

...in/java/org/opensearch/index/shard/IndexShard.java
69.81% <0.00%> (-0.05%)
:arrow_down:

...rg/opensearch/snapshots/SnapshotShardsService.java
63.27% <20.83%> (-3.70%)
:arrow_down:

.../java/org/opensearch/snapshots/RestoreService.java
54.69% <66.66%> (-1.60%)
:arrow_down:

...arch/repositories/blobstore/BlobStoreTestUtil.java
76.25% <73.91%> (+0.03%)
:arrow_up:

... and 492 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrross looks like we need manual backport PR's for 2.x and 2.7


YAROM query and PEP-8 formatting

See #42, #90, #162
Please use the dev branch of YAROM in lieu of the listed YAROM version in setup.py for testing/review.
My apologies for the whitespace noise created by autopep8 in the diffs.

Hi Mark, thanks for making these changes.
I've made a new branch to try and get these changes incorporated, but I'm coming up against some difficulties.
When installed, running test.py gives some errors and failures.
It appears that a separate db is being made in the project root when this command is run, so I replaced that db and related files with the ones generated in OpenWormData/scripts/.
There are still some failures when I run test.py after these manual changes, but no errors (log).
It's unclear whether the changed dependencies or changed files are causing the errors, and there is a lot of material there to wade through unfortunately.
@mwatts15 Perhaps there is a change you can think of that  we can revert that may fix this?

@mwatts15 I really appreciate the attempt to fix these issues!
I think we are coming up on a fork in the road here between PyOpenWorm & YAROM.  I'm fearing that some of the decisions we're having to take in PyOpenWorm about the level of testing we need (as evidenced by the number of tests failing in this PR) means that we may need to just keep the code bases separate for now.  The extra effort to fix failing PRs when they depend on understanding a separate code base is unfortunately too high for us right now.
Would love to get additional thoughts from you as to alternatives to this.  Otherwise, I think we'll have to address the outstanding issues you are trying to fix in another way and close this PR.

@travs From what I saw here, data was being loaded in for testing to tests/test.db, and then summarily copied over in the test setup. I chose to load the data into worm.db in the project root. Where is the data supposed to be if it's not kept in OpenWormData/WormData.n3 anymore? It's just all from the insert_worm.py script?
In any case, deleting your worm.db should do for the DataIntegrityTest tests.
I also saw this:
   File "/Users/travis/programming/worm/PyOpenWorm/tests/../README.md", line 178, in README.md
    Failed example:
        len(neurons)
    Expected:
        302
    Got:
        604

I changed the identifier function for Neurons to be more obvious (e.g., Neuron:AVAL with abbreviation). Since I don't see a static database anymore, I didn't bother with data migrations, but I don't have time to write any migration scripts right now. I can revert the identifier changes if desired.

I have added an expected failure to the DocumentationTest. These two are failing:
**********************************************************************
File "/media/c90ce379-57e7-4982-931b-dca85b87ca3d/work/openworm/PyOpenWorm2/tests/../README.md", line 164, in README.md
Failed example:
    avdl in list(e0.asserts())
Expected:
    True
Got:
    False
**********************************************************************
File "/media/c90ce379-57e7-4982-931b-dca85b87ca3d/work/openworm/PyOpenWorm2/tests/../README.md", line 168, in README.md
Failed example:
    avdl.lineageName in list(e0.asserts())
Expected:
    True
Got:
    False
**********************************************************************

How does this Evidence data come in to the database?

Where is the data supposed to be if it's not kept in OpenWormData/WormData.n3 anymore? It's just all from the insert_worm.py script?

Yes, its all from the insert_worm.py script now.  That must be run first, and it will generate the data file.

How does this Evidence data come in to the database?

Same way; insert_worm.py
Those tests that are failing are telling me the evidence system is broken.  Those documentation tests are running the code from the main readme.  If you scroll down to see the part about Evidence, you'll see what assertions are failing.  Any idea why that might be?

My apologies: I should have looked more carefully at this test. It makes perfect sense actually. The Evidence object being queried in the doctest depends on the Evidence object from above, but that object doesn't have the information needed to create an identifier. In particular, it doesn't have a PMID, Wormbase ID, or DOI attached to it. Attaching a key to the first evidence causes it to work as expected:
import PyOpenWorm as P
P.connect()

e = P.Evidence(key="Sulston83", author='Sulston et al.', date='1983')
avdl = P.Neuron(name="AVDL")
avdl.lineageName("AB alaaapalr")
e.asserts(avdl)
e.asserts(avdl.lineageName)  # doctest:+ELLIPSIS
e.save()

e0 = P.Evidence(author="Sulston et al.", date="1983")
assertions = e0.asserts()
print(str(avdl in list(e0.asserts())))
print(str(avdl.lineageName in list(e0.asserts())))

prints:
True
True

Are there any additional concerns from maintainers / active developers?


Ability to export Logs / Debug issues

Home Assistant Android version:
1.3.1 (latest)
Phone model:
Oneplus 3 (Android 9) and
Oneplus 7T (Android 10)
Home Assistant version:
0.103.5
Last working Home Assistant release (if known):
unknown
Description of problem:
I have an issue with the app: When I open a specific view the app crashes. All other views work as expected. This happens on two phones and the latest 2 Android versions. I've tried to use logcat to investigate the error but cannot find the reason for the crash.
It would be nice if I could export a crash log directly from the app.

First step should be to try to reproduce this on Chrome.

Issue also appears in latest Chrome for Android (79.0.3945.93).

In that case you should report it in the frontend repo. https://github.com/home-assistant/home-assistant-polymer/


Better support in HTEX for reporting jobs that fail without connecting

Description
When it comes to an executor using a provider like SlurmProvider to provision resources, there are a few different failure modes that are not well supported.

Job fails to submit -> Reported as a provider failure
Job starts, workers fail to start with an non-zero exit code reported (LocalProvider) -> Reported as a provider failure
Job starts, but workers fail to start (bad env/network config) -> Silently ignored
Job starts, but terminates later due to reaching walltime -> Not a failure.

In case3, when the batch system deems a task as completed/failed, the provider may not see further info reported from the queue. In such a situation the provider marks the job as JobState.COMPLETED instead of JobState.FAILED. However, this leads to a situation where Parsl would repeatedly attempt provisioning jobs when it should shut down.
Changed Behaviour
This PR introduces a new JobState.MISSING which is set by the HighThroughputExecutor when it detects that a job reported by the provider to have reached a terminal state did not connect.
Fixes # (issue)
Type of change

Bug fix

@benclifford I ran some quick tests on frontera with a bad worker_init setting to simulate broken python environment and I see the right exception being set:
ERROR    parsl.executors.status_handling:status_handling.py:141 Setting bad state due to exception
parsl.jobs.errors.TooManyJobFailuresError: Error 1:

INFO     parsl.dataflow.dflow:dflow.py:305 Task 0 try 0 failed with exception of type BadStateException
ERROR    parsl.dataflow.dflow:dflow.py:351 Task 0 failed after 0 retry attempts
Traceback (most recent call last):
  File "/home1/02551/yadunand/parsl/parsl/dataflow/dflow.py", line 302, in handle_exec_update
    res = self._unwrap_remote_exception_wrapper(future)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home1/02551/yadunand/parsl/parsl/dataflow/dflow.py", line 570, in _unwrap_remote_exception_wrapper
    result = future.result()
             ^^^^^^^^^^^^^^^
  File "/home1/02551/yadunand/anaconda3/envs/parsl_py311/lib/python3.11/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/home1/02551/yadunand/anaconda3/envs/parsl_py311/lib/python3.11/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
parsl.executors.errors.BadStateException: Executor HTEX failed due to: Error 1:

ERROR    parsl.executors.status_handling:status_handling.py:141 Setting bad state due to exception
parsl.jobs.errors.TooManyJobFailuresError: Error 1:

After that "error :" text there's an opportunity for job status to put in an exception/message. Look at the example messages in this PR https://github.com/Parsl/parsl/pull/3043 which result from provider submit errors, for example.
I think this is an obvious place to make this error something useful to the user: is there any captured stderr from the job? There should be in many cases (eg. a Python process starting up and then printing out that it cannot find a module, or the shell printing out that it cannot find Python).
That text is forming in parsl.jobs.error_handlers._get_error, which relies on the error set in the JobStatus object.
The way things are structured now, I think that in-job stdout/stderr is probably awkward to get to, but the error message here could at least describe whats going on in a static message about jobs maybe starting and where to look for more info.

It looks like there's an issue with Providers not reporting sufficient info with the JobStatus object, I've added a new issue here -> https://github.com/Parsl/parsl/issues/3058. As a temporary fix, I have updated the htex.status method to add a message to point users to where the logs are when the exception message is empty. The exception report looks like this now:
ERROR    parsl.dataflow.dflow:dflow.py:351 Task 0 failed after 0 retry attempts
Traceback (most recent call last):
  File "/home1/02551/yadunand/parsl/parsl/dataflow/dflow.py", line 302, in handle_exec_update
    res = self._unwrap_remote_exception_wrapper(future)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home1/02551/yadunand/parsl/parsl/dataflow/dflow.py", line 570, in _unwrap_remote_exception_wrapper
    result = future.result()
             ^^^^^^^^^^^^^^^
  File "/home1/02551/yadunand/anaconda3/envs/parsl_py311/lib/python3.11/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/home1/02551/yadunand/anaconda3/envs/parsl_py311/lib/python3.11/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
parsl.executors.errors.BadStateException: Executor HTEX failed due to: Error 1:
	Job is marked as MISSING since the workers failed to register to the executor. Check the stdout/stderr logs in the submit_scripts directory for more debug information


Should HTTPS redirection occur earlier in the pipeline?

Might be an ID-10T error on my part, but I'm working up a Blazor sample for web API and using the sample app here as a basis. With the sample app's pipeline order of ...
app.UseDefaultFiles();
app.UseStaticFiles();
app.UseHttpsRedirection();
app.UseMvc();

... the Index.html page loads (handled by Static File Middleware prior to the HTTPS Redirection Middleware), but the GET (and any other method, POST, etc.) throws a CORS violation (browser) and a 'method not supported' exception from endpoint middleware (app) due to (I think) the redirect working on the subsequent requests (handled by MVC after HTTPS Redirection Middleware) ... thus a protocol change on the AJAX requests.
Whether that's a correct interpretation or not ... If the order is changed for a redirect to the secure protocol on the initial index.html page request, then subsequent requests to GET, POST, etc. work fine (protocol is the same). Should the order in the pipeline be? ...
app.UseHttpsRedirection();
app.UseDefaultFiles();
app.UseStaticFiles();
app.UseMvc();

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 583ae3e7-5915-f22b-e54c-6c100cf2a7da
Version Independent ID: 95f2549e-29f9-e31a-b4d0-432b971643ff
Content: Tutorial: Create a web API with ASP.NET Core MVC
Content Source: aspnetcore/tutorials/first-web-api.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

I dunno if it's helpful to mention here, but dotnet new webapp sets up something that corroborates your suggestion:
app.UseHttpsRedirection();
app.UseStaticFiles();
app.UseCookiePolicy();
app.UseMvc();

We should do what the templates do. Not sure how they got out of order.

I'll patch it on the new Blazor topic PR that I'll be putting in shortly. The topic points to this topic+sample as a web API example for its demo.


TemporalDropout1D

Removing words and estimating from context is one of the recent language modeling tasks. This kind of noise could be useful as regularization as well.

@googlebot I signed it!

@halidziya Can you please check reviewer comments and keep us posted. Thanks!

Closing this PR now. See discussions above. Let us know if you have other concerns.


Escape characters where appropriate

What does this PR do?
It adds escaping of characters in the appropriate places before presenting the values in the visualizations and visualization wrapper.
How can I test this?

Ensure all tests pass.
Try adding <script>alert('hi');</script> in data values and ensure they are properly escaped for all chart types.

Tests are passing :+1: reviewing now-

Looks good! Nice work 👍


fix: use semver in package.json dependencies

I had a problem in my project that uses yarn workspaces, in that I had multiple workspaces depending on @sentry/browser, but they wouldn't dedupe and an old version was persistently brought in via gatsby-plugin-sentry. I tracked it down to the dependency in gatsby-plugin-sentry being declared as latest, and on switching it to * the issue was resolved.
I assume that because latest isn't a semver, and is instead a registry tag, it doesn't resolve properly in the dependency resolution of yarn.

@octalmage is there anything I can do to move this along?

@octalmage Any chance we could get this merged and released?


ci: Add a meta job to check all the tests statuses

I think this might need to be the first job in the list?
I just watched the checks for this PR and this new meta job only showed up at the very end

No it should be the last one. Sorry didn't update the description I wanted to see the result once before handing it over for review.
The "problem" is that whenever you have a matrix, the names and jobs you have to check will change whenever you update it and that can be annoying. So I like having a "meta job" that depends on it and pass if and only if all the matrix jobs pass. This way you have one job with a constant name you can apply your protection rule on.
But you can also expend it to the whole workflow like I did here. It's a bit "unnecessary" as most jobs that it depends on don't have a changing name, but I find it a bit more convenient for maintenance.
You can find a more lengthy/described description with screenshots here


is there training code available?

I couldn't find a script used for training the model. Thanks!

Technically, all the code needed from the model side to reproduce the results in the paper is available in this repository. For instance, you can take a look at the analysis scripts shared in this repo which only makes use of embedding produced from a pre-trained model.
The challenge you would face at the moment is not the code, but that most of our results were produced using the Tabula Sapiens v2 dataset which so far is not published.


Collision shape transformation bug

Godot version:

Godot 3.0 RC2 winx64
OS/device including version:

Issue description:

I was like coding my first game using tutorial series by KidsCanCode. In third part of the series there was a moment at 7:35 where we were transforming collision shape 2D to fit the players scale (https://www.youtube.com/watch?v=zWAmbgqOWkI). I was doing all exactly the same way, except transforming it not by the right horisontal button, but with the top (vertical) one. And the collision shape just disappeared. Then(without using CTRL + Z) I tried to reshape it with the right button, it appeared back but looked very strange and smashed.
Steps to reproduce:
Just make everything as in first three parts of KidsCanCode tutorial and when you get to the moment I mentioned before, try to rescale collision shape with the upper button, not right one.
Minimal reproduction project:

I can confirm that either.
I feel odd when using that for the first time, not sure what it's missing suddenly.
It happens to me when I'm trying the First Game Tutorial by the Godot Engine Documentation

@LikeLakers2  made a good point on the console output. Whenever I adjust the collisionShape close to a 'Circle' shape, it throws the bad polygon message. (Since I'm using a CapsuleShape2D, I assume that's the logic behind, that it can't be a circle)
hence posting my finding above here,

The issue persist. Anyone know how to work around it?

I've found the same issue, and bypassed it by changing the roation of the shape. Someone on Discord (thank you, WiggleWizard) sugested there should be an issue trying to set the walls to be smaller than the arcs.

Found the reason, when you drag it down, the capsule shape's height will be a negative value, then will cause it can't be painted.

Same here, once the height goes below 0 the issue occurs.

Fixed by #38617


Add limit query parameter on /get-mentors endpoint

Currently our /get-mentors end-point returns all the matched mentors, I would like to pass in a query parameter to tell the server how many mentors do we want to fetch

add a query limit to /get-mentors endpoint to limit the number of mentors sent to the front-end
/get-mentors?expertise=All&topic=-1&limit=10
should only send 10 mentors
Files to edit:
https://github.com/Rishabh-malhotraa/Vita/blob/main/api/src/controllers/api-controller.ts#L6
(and files in a client who is making a request to this endpoint
)

Can I work on this?
I know how to solve this I will use limit method on Mongoose Model.


Camel Case for Pod object

Before FIx - Local volumes do not currently support dynamic provisioning, however a StorageClass
should still be created to delay volume binding until pod scheduling.
After Fix - Local volumes do not currently support dynamic provisioning, however a StorageClass
should still be created to delay volume binding until Pod scheduling.

/assign @sftim

@sftim as discussed, created this new PR.

pinging @sftim for review.
Also can you please help me and suggest me where can I see the approver's members list, to assign it to a specific approver name.

You rarely need to assign a PR to a specific approver. There is a rota for “PR wrangling” and each week someone on the rota will put time into approving PRs that are open.
Details at https://kubernetes.io/docs/contribute/advanced/#be-the-pr-wrangler-for-a-week

/sig storage

You rarely need to assign a PR to a specific approver. There is a rota for “PR wrangling” and each week someone on the rota will put time into approving PRs that are open.
Details at https://kubernetes.io/docs/contribute/advanced/#be-the-pr-wrangler-for-a-week

@sftim Thank you for your inputs, waiting for this PR to be picked up by one of the approvers.

@sftim there is some problem with my repo branch, closing this PR and will open a new one again.

/close
there is some problem with my repo, closing this PR and will open a new one.


Add an element to display the submitted data

Closed with https://github.com/ToniMaunde/typed-formdata/commit/6851796c1ce00175cfc19e233139366637114835.