preparing the dataset uwb atcc: ValueError with n_train, n_test = _validate_shuffle_split

I extracted the uwb_atcc database ens extracted it in ZCU_CZ_ATC, putting wav file in audio folder and others in transcripts folder. I run the bash script:
bash data/databases/uwb_atcc/data_prepare_uwb_atcc_corpus.sh
there were 0 empty or blank utterances
printing the text file in: experiments/data/uwb_atcc/prep/text2_raw_spk
printing the text and tags file in: experiments/data/uwb_atcc/prep/utt2speakerid
Traceback (most recent call last):
File "data/utils/gen_train_test.py", line 61, in
main()
File "data/utils/gen_train_test.py", line 42, in main
x_train, x_test = train_test_split(
File "/home/liv/Developer/venv3.8-tf2/lib/python3.8/site-packages/sklearn/model_selection/_split.py", line 2562, in train_test_split
n_train, n_test = _validate_shuffle_split(
File "/home/liv/Developer/venv3.8-tf2/lib/python3.8/site-packages/sklearn/model_selection/_split.py", line 2236, in _validate_shuffle_split
raise ValueError(
ValueError: With n_samples=0, test_size=None and train_size=0.8, the resulting train set will be empty. Adjust any of the aforementioned parameters.
what can it be? I am not sure?

Hello!
Sorry for taking so much time to reply. Could you put here the output of experiments/data/uwb_atcc/prep/text2_raw_spk?
It looks like the dataset is not getting correctly prepared at some point. That's probably why you're getting that error about '0' samples.
Pablo

I am getting the same error as sarranetor on VScode.
Although on Google colab this is what i got:
Empty utterance: uwb-atcc_APP-O8f26B_000225_000353 uwb-atcc_APP-O8f26B 2.260 3.530 [air]
Empty utterance: uwb-atcc_TWR-JfoHJv_000234_000308 uwb-atcc_TWR-JfoHJv 2.340 3.080 [air]
Empty utterance: uwb-atcc_TWR-VIKx0e_000309_000408 uwb-atcc_TWR-VIKx0e 3.090 4.080 [air]
Empty utterance: uwb-atcc_TWR-v1sw0a_002796_002867 uwb-atcc_TWR-v1sw0a 27.960 28.670 [air]
Empty utterance: uwb-atcc_TWR-q2wbS3_000336_000419 uwb-atcc_TWR-q2wbS3 3.360 4.190 [air]
Empty utterance: uwb-atcc_TWR-ZfmGUj_002451_002578 uwb-atcc_TWR-ZfmGUj 24.510 25.780 [ground]
Empty utterance: uwb-atcc_ACCU-OvZN8g_001321_001433 uwb-atcc_ACCU-OvZN8g 13.210 14.330 [ground]
there were 492 empty or blank utterances
printing the text file in: experiments/data/uwb_atcc/prep/text2_raw_spk
printing the text and tags file in: experiments/data/uwb_atcc/prep/utt2speakerid
printing the TRAIN SET IDS file in: experiments/data/uwb_atcc/train/ids
printing the TEST SET IDS file in: experiments/data/uwb_atcc/test/ids
creating the train folder:
creating the test folder:
UWB-ATCC corpus was sucessfully created
but the next bash gave error as follows:
!bash /content/drive/MyDrive/w2v2-air-traffic/ablations/uwb_atcc/train_w2v2_base.sh
Vocabulary is empty, you passed config/vocab.json
We will create a new vocabulary from the training+test file
*** About to start the training ***
*** output folder: experiments/results/baselines/wav2vec2-base/uwb_atcc/0.0ld_0.0ad_0.0attd_0.0fpd_0.01mtp_12mtl_0.0mfp_12mfl_2acc/ ***
python3: can't open file '/content/drive/MyDrive/w2v2-air-traffic/data/src/run_speech_recognition_ctc.py': [Errno 2] No such file or directory
Done training of baseline model for UWB-ATCC database

Please help me fix the issue

Hello,
I think the error might be here:
https://github.com/idiap/w2v2-air-traffic/blob/25b91bfc1975d749bdad76bd6bd3b73cc140b2f7/src/run_asr_fine_tuning.sh#L18
Could you modify that value to:
cmd=""
And let me know what is the output?

Yeah sure, give me 5 minutes

I cant believe it actually worked damnn!!! I would have taken years to solve this issue, Thanks means a lot;
This is the output I obtained, expected 492 EMPTY UTTERANCES?
...
..
Empty utterance: uwb-atcc_APP-ZWCH4J_024924_025001 uwb-atcc_APP-ZWCH4J 249.240 250.010 [air]
Empty utterance: uwb-atcc_ACCU-bNGNLz_003137_003210 uwb-atcc_ACCU-bNGNLz 31.370 32.100 [air]
Empty utterance: uwb-atcc_ACCU-bNGNLz_003286_003369 uwb-atcc_ACCU-bNGNLz 32.860 33.690 [air]
Empty utterance: uwb-atcc_ACCU-bNGNLz_007525_007604 uwb-atcc_ACCU-bNGNLz 75.250 76.040 [air]
Empty utterance: uwb-atcc_TWR-yGF8s5_001233_001335 uwb-atcc_TWR-yGF8s5 12.330 13.350 [ground]
Empty utterance: uwb-atcc_TWR-m8CuYQ_001384_001432 uwb-atcc_TWR-m8CuYQ 13.840 14.320 [ground]
Empty utterance: uwb-atcc_APP-oDje3J_000356_000642 uwb-atcc_APP-oDje3J 3.560 6.420 [air]
Empty utterance: uwb-atcc_ACCU-y5UHTs_001414_001489 uwb-atcc_ACCU-y5UHTs 14.140 14.890 [air]
Empty utterance: uwb-atcc_ACCU-WGx5qF_001133_001227 uwb-atcc_ACCU-WGx5qF 11.330 12.270 [air]
Empty utterance: uwb-atcc_APP-sgKjJz_000308_000379 uwb-atcc_APP-sgKjJz 3.080 3.790 [air]
Empty utterance: uwb-atcc_ACCU-QfXh8b_001887_002017 uwb-atcc_ACCU-QfXh8b 18.870 20.170 [air]
Empty utterance: uwb-atcc_ACCU-hh8aIj_002189_002308 uwb-atcc_ACCU-hh8aIj 21.890 23.080 [air]
Empty utterance: uwb-atcc_TWR-mDzIBi_005798_005958 uwb-atcc_TWR-mDzIBi 57.980 59.580 [ground]
Empty utterance: uwb-atcc_TWR-mDzIBi_006064_006149 uwb-atcc_TWR-mDzIBi 60.640 61.490 [air]
Empty utterance: uwb-atcc_APP-wBCMEy_000319_000823 uwb-atcc_APP-wBCMEy 3.190 8.230 [ground]
Empty utterance: uwb-atcc_APP-wBCMEy_000973_001205 uwb-atcc_APP-wBCMEy 9.730 12.050 [air]
Empty utterance: uwb-atcc_TWR-952cUz_000760_000853 uwb-atcc_TWR-952cUz 7.600 8.540 [air]
Empty utterance: uwb-atcc_ACCU-OvZN8g_001321_001433 uwb-atcc_ACCU-OvZN8g 13.210 14.330 [ground]
Empty utterance: uwb-atcc_TWR-v1sw0a_002796_002867 uwb-atcc_TWR-v1sw0a 27.960 28.670 [air]
Empty utterance: uwb-atcc_TWR-q2wbS3_000336_000419 uwb-atcc_TWR-q2wbS3 3.360 4.190 [air]
Empty utterance: uwb-atcc_TWR-ZfmGUj_002451_002578 uwb-atcc_TWR-ZfmGUj 24.510 25.780 [ground]
Empty utterance: uwb-atcc_TWR-VIKx0e_000309_000408 uwb-atcc_TWR-VIKx0e 3.090 4.080 [air]
Empty utterance: uwb-atcc_TWR-JfoHJv_000234_000308 uwb-atcc_TWR-JfoHJv 2.340 3.080 [air]
Empty utterance: uwb-atcc_APP-O8f26B_000225_000353 uwb-atcc_APP-O8f26B 2.260 3.530 [air]
Empty utterance: uwb-atcc_ACCU-FVpUok_000535_000633 uwb-atcc_ACCU-FVpUok 5.350 6.330 [air]
Empty utterance: uwb-atcc_TWR-jBaOYB_000549_000906 uwb-atcc_TWR-jBaOYB 5.490 9.060 [air]
Empty utterance: uwb-atcc_TWR-jBaOYB_001009_001329 uwb-atcc_TWR-jBaOYB 10.090 13.290 [ground]
Empty utterance: uwb-atcc_TWR-jBaOYB_001398_001537 uwb-atcc_TWR-jBaOYB 13.980 15.370 [air]
Empty utterance: uwb-atcc_APP-Q1M9yF_005349_005423 uwb-atcc_APP-Q1M9yF 53.490 54.230 [air]
there were 492 empty or blank utterances
printing the text file in: experiments/data/uwb_atcc/prep/text2_raw_spk
printing the text and tags file in: experiments/data/uwb_atcc/prep/utt2speakerid
printing the TRAIN SET IDS file in: experiments/data/uwb_atcc/train/ids
printing the TEST SET IDS file in: experiments/data/uwb_atcc/test/ids
creating the train folder:
creating the test folder:
UWB-ATCC corpus was sucessfully created

Wow, I'm happy it worked :-)

It is expected, not all samples have a transcripts.
I'll update that part of the code right now!

Thanks for this.
I'm closing this, feel free to open it again.

I am having this problem can you help me fix this issue?
(Farooq_thesis) phd-research@phd-research:~/research_space/w2v2-air-traffic$ bash src/run_eval_model.sh
*** About to evaluate a Wav2Vec 2.0 model***
*** Dataset in: experiments/data/uwb_atcc/test ***
*** Output folder: experiments/results/baselines/wav2vec2-large-960h-lv60-self/uwb_atcc/0.0ld_0.05ad_0.05attd_0.0fpd_0.075mtp_12mtl_0.075mfp_12mfl/output ***
Integrating a LM by shallow fusion, results should be better
*** Loading the Wav2Vec 2.0 model, loading... ***
Error. Models were not found in experiments/results/baselines/wav2vec2-large-960h-lv60-self/uwb_atcc/0.0ld_0.05ad_0.05attd_0.0fpd_0.075mtp_12mtl_0.075mfp_12mfl/checkpoint-10000
Traceback (most recent call last):
File "/home/phd-research/research_space/w2v2-air-traffic/src/eval_model.py", line 250, in
main()
File "/home/phd-research/research_space/w2v2-air-traffic/src/eval_model.py", line 152, in main
processor, processor_ctc_kenlm, model = get_kenlm_processor(path_model, path_lm)
File "/home/phd-research/research_space/w2v2-air-traffic/src/eval_model.py", line 56, in get_kenlm_processor
vocab = processor.tokenizer.convert_ids_to_tokens(
UnboundLocalError: local variable 'processor' referenced before assignment

This is the output from previous command, I got stuck in run_eval_model.sh now
(Farooq_thesis) phd-research@phd-research:~/research_space/w2v2-air-traffic$ bash /home/phd-research/research_space/w2v2-air-traffic/src/run_train_kenlm.sh
*** About to start the KenLM ***
*** Dataset name: uwb_atcc ***
*** Output folder: experiments/data/uwb_atcc/train/lm ***
uwb_atcc experiments/data/uwb_atcc/train/text
Exporting dataset to text file experiments/data/uwb_atcc/train/lm/4_corpus.txt...
lmplz -o 4 --text experiments/data/uwb_atcc/train/lm/4_corpus.txt --arpa experiments/data/uwb_atcc/train/lm/uwb_atcc_4g_no_fix.arpa
=== 1/5 Counting and sorting n-grams ===
Reading /home/phd-research/research_space/w2v2-air-traffic/experiments/data/uwb_atcc/train/lm/4_corpus.txt
----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100

Unigram tokens 113301 types 1766
=== 2/5 Calculating and sorting adjusted counts ===
Chain sizes: 1:21192 2:2261260544 3:4239863552 4:6783781888
Statistics:
1 1765 D1=0.595645 D2=0.962202 D3+=1.62725
2 16099 D1=0.732908 D2=1.05218 D3+=1.47953
3 38208 D1=0.799969 D2=1.12127 D3+=1.28138
4 60883 D1=0.823461 D2=1.16559 D3+=1.23074
Memory estimate for binary LM:
type      kB
probing 2387 assuming -p 1.5
probing 2712 assuming -r models -p 1.5
trie     950 without quantization
trie     472 assuming -q 8 -b 8 quantization
trie     895 assuming -a 22 array pointer compression
trie     418 assuming -a 22 -q 8 -b 8 array pointer compression and quantization
=== 3/5 Calculating and sorting initial probabilities ===
Chain sizes: 1:21180 2:257584 3:764160 4:1461192
----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100
####################################################################################################
=== 4/5 Calculating and writing order-interpolated probabilities ===
Chain sizes: 1:21180 2:257584 3:764160 4:1461192
----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100
####################################################################################################
=== 5/5 Writing ARPA model ===
----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100

Name:lmplz      VmPeak:13164676 kB      VmRSS:9084 kB   RSSMax:2609216 kB       user:0.196349   sys:0.464826    CPU:0.661188     real:0.647472
corrected Ken LM in experiments/data/uwb_atcc/train/lm/uwb_atcc_4g.arpa
build_binary trie experiments/data/uwb_atcc/train/lm/uwb_atcc_4g.arpa experiments/data/uwb_atcc/train/lm/uwb_atcc_4g.binary
Reading experiments/data/uwb_atcc/train/lm/uwb_atcc_4g.arpa
----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100

Identifying n-grams omitted by SRI
----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100

Writing trie
----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100

SUCCESS
done doing training of KenLM
check the output folder: experiments/data/uwb_atcc/train/lm
Done training 4-gram in experiments/data/uwb_atcc/train/lm

The same issue with sarranetor:
I extracted the uwb_atcc database ens extracted it in ZCU_CZ_ATC, putting wav file in audio folder and others in transcripts folder. I run the bash script:
bash data/databases/uwb_atcc/data_prepare_uwb_atcc_corpus.sh
there were 0 empty or blank utterances
printing the text file in: experiments/data/uwb_atcc/prep/text2_raw_spk
printing the text and tags file in: experiments/data/uwb_atcc/prep/utt2speakerid
Traceback (most recent call last):
File "data/utils/gen_train_test.py", line 61, in
main()
File "data/utils/gen_train_test.py", line 42, in main
x_train, x_test = train_test_split(
File "/home/liv/Developer/venv3.8-tf2/lib/python3.8/site-packages/sklearn/model_selection/_split.py", line 2562, in train_test_split
n_train, n_test = _validate_shuffle_split(
File "/home/liv/Developer/venv3.8-tf2/lib/python3.8/site-packages/sklearn/model_selection/_split.py", line 2236, in _validate_shuffle_split
raise ValueError(
ValueError: With n_samples=0, test_size=None and train_size=0.8, the resulting train set will be empty. Adjust any of the aforementioned parameters.


image host is broken.

please fix the image display error in the Supported Methods section.

We have long noticed that some icons could not be displayed correctly. It, however, has nothing to do with OpenOOD's functionality. If you know how to fix the error, we would be very willing to merge a pull request.


addLight only add lights in the pane 0

Hi,
If I create a Plotter with 2 panes (shape=(1,2)) and add lights to it, only the 1st pane uses the lights in its rendering.
I would suggest that you can add lights selectively to different panes by adding the 'at' parameter to the AddLight() function.
By default, at=-1 would add the light to all the panes.
Thank you for a really great library,
Pierre

thanks a lot this a very good idea!


Project HTTPX:// :: Integrating The Citadel Protocol with the web browser

Speccing: HTTP -> HTTPS -> HTTPX
HTTPX will be HTTPS wherein each frame sent between the client and server use The Citadel Protocol. A NetKernel implementation will need to be written such that:
We start with an HTTPS stream, which we will then upgrade to HTTPX with the following steps:

Use an HTTPS underlying protocol, which accepts the HTTPS stream as an input

With The Citadel Protocol owning the HTTPS connection, perform The Citadel Protocol over HTTPS.

Both client/server NetKernel implementations will need to handle webserver/client logic to forward packets into the client-to-server channel.

For serverside, there is no need for WASM. However, for client-side, the protocol will need to execute using WASM.
Both client and server NetKernel implementations will need consumers of the forwarded data for rendering and processing.
[client-side] We can use TCP/TLS for establishing a connection w/handshake via: https://docs.rs/hyper/latest/hyper/client/conn/index.html.
[server-side] We can use TCP/TLS listeners for starting a server: https://docs.rs/hyper/latest/hyper/server/conn/index.html
TODO: more speccing required

Even simpler: since the traits in the hyper links above expect an AsyncRead and AsyncWrite handle, we can pass the ClientToServerChannel to when building the HTTP server. We don't need to even add a new underlying protocol.

As of #169 , we have proven HTTP works over The Citadel Protocol.
Next, we will want to create an ExternelServiceCommunicator that allows communication to some TCP/TLS socket. This will allow people to reverse proxy from the public-facing application (<IP_ADDRESS> or ::) to an internal <IP_ADDRESS> http/s service. This can also allow communication to a remote http server.
Once that is complete, we will need to integrate with an existing open-source browser (e.g., chromium).
When clients type in httpq://website.com, the custom source code will need a custom handler for httpq. The handler would need to map httpq to the default port, and using DNS, map the domain to an address. From there, the typical connection process can be called. We should also keep in mind that different login techniques may be used (e.g., passwordless and credentialed auth). By default, we should assume passwordless mode to make the httpq browsing experience identical to the normal browsing experience. However, if the client wishes to have a credentialed connection, this should be specifiable in some manner. Maybe<EMAIL_ADDRESS>Entering this could trigger a password prompt.


Version 4.0.1 not pushed to CocoaPods repository

Please push the newest changes to the CocoaPods repository. On CocoaPods there still is 4.0.0. There was quite a critical change where we evaluate trust based on the host (instead of absolute URL).
git tag 4.0.1
git push origin 4.0.1
pod spec lint
pod trunk push

Can someone please push 4.0.1? Certificate pinning won't work without this change. @daltoniam

Pushed! Should be live.


⚠ BCR Bot has degraded performance

In 027c0e3, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 884 ms

Resolved: BCR Bot performance has improved in 90acccf.


Add Kraken description in README.md

Project URL
https://github.com/sabirvirtuoso/Kraken
Description
Kraken is a dependency injection framework for Swift with easy to use syntax. Among the very few dependency injection containers available for Swift, Kraken is a great and easy one to get started. Kraken provides almost all the features of a good dependency container along with easy syntax. Available for use in iOS.
Checklist

[x] Only one project is in the request
[x] Addition in chronological order (bottom of category)
[x] Travis CI pass
[x] Supports iOS 7 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

Hey @sabirvirtuoso, your library is awesome and we appreciate your contribution.
The only problem is that the lib needs to be in the end of the category:

Addition in chronological order (bottom of category)

Thanks. 😄

The library is now added in chronological order. Please accept the pull request.

I have to call retry build on travis.
Thanks for contribution.

😃


Update package.json

Update package.json for reducing deprecated warnings while running "npm install" at first time.
While "npm install" we see some deprecated warning like below statement:
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated<EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
After update the dependency of 'babel-jest' from "24.1.0" to "29.3.1" it will be reduce deprecated warnings like below statement:
npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
And  all unit tests passed.

Appreciate the PR, and apologies it never got merged!  v4.0.1 is now updated with Jest v29.


panic in http server

When trying to remove a controlled LSP I get
http2: panic serving <IP_ADDRESS>:53698: runtime error: invalid memory address or nil pointer dereference
goroutine 341 [running]:
net/http.(*http2serverConn).runHandler.func1()
        /usr/local/go/src/net/http/h2_bundle.go:6146 +0x145
panic({0xcb0a20?, 0x2709170?})
        /usr/local/go/src/runtime/panic.go:770 +0x132
gopcep/controller.(*Controller).DelSRLSP(0xc000170000, {0xc0002a5fa8, 0x5})
        /opt/gopcep/controller/controller.go:82 +0x154
gopcep/restapi.(*handler).delLSP(0xc000484e40, 0xc00012ed00)
        /opt/gopcep/restapi/lsp.go:40 +0xa5
github.com/gin-gonic/gin.(*Context).Next(0xc00012ed00)
        /root/go/pkg/mod/github.com/gin-gonic/gin@v1.7.2/context.go:165 +0x2b
gopcep/restapi.Start.jsonLogMiddleware.func4(0xc00012ed00)
        /opt/gopcep/restapi/restapi.go:62 +0x46
github.com/gin-gonic/gin.(*Context).Next(...)
        /root/go/pkg/mod/github.com/gin-gonic/gin@v1.7.2/context.go:165
github.com/gin-gonic/gin.(*Engine).handleHTTPRequest(0xc000311860, 0xc00012ed00)
        /root/go/pkg/mod/github.com/gin-gonic/gin@v1.7.2/gin.go:489 +0x650
github.com/gin-gonic/gin.(*Engine).ServeHTTP(0xc000311860, {0x213cd30, 0xc0005a4350}, 0xc0004f6900)
        /root/go/pkg/mod/github.com/gin-gonic/gin@v1.7.2/gin.go:445 +0x198
net/http.serverHandler.ServeHTTP({0x0?}, {0x213cd30?, 0xc0005a4350?}, 0x0?)
        /usr/local/go/src/net/http/server.go:3137 +0x8e
net/http.initALPNRequest.ServeHTTP({{0x213dea8?, 0xc0001d9bf0?}, 0xc000005888?, {0xc0004d83c0?}}, {0x213cd30, 0xc0005a4350}, 0xc0004f6900)
        /usr/local/go/src/net/http/server.go:3745 +0x231
net/http.(*http2serverConn).runHandler(0x0?, 0x0?, 0x0?, 0x0?)
        /usr/local/go/src/net/http/h2_bundle.go:6153 +0xbb
created by net/http.(*http2serverConn).scheduleHandler in goroutine 48
        /usr/local/go/src/net/http/h2_bundle.go:6088 +0x21d

Added the check. You should see the log.

Added the check. You should see the log.

Well, it's not crashing anymore.. the only thing that popup in the logs are
time="2024-03-08T13:39:39.670833172+01:00" level=error client_ip="172.18.xx.xx:59059" duration=0.106676 method=DELETE path=/v1/lsp/lsp-num1_1 referrer="https://172.16.xx.xx1:1443/" request_id= status=500

This is how it should be as I suspect the LSPs do not get created on the devices themselves so when you try to delete there is nothing to delete. There are two DBs the first one is the controller DB and the second one is the network DB. You create LSPs in the controller DB and they get pushed into the network. Once pushed the devices report all of them back and they get saved into the network DB. We need to make sure they actually get created first.

This is how it should be as I suspect the LSPs do not get created on the devices themselves so when you try to delete there is nothing to delete.

Its hard to delete a non-functioning LSP if it has to be up to be able to remove it. Even if the LSP is not up, for whatever reason, I must be able to remove it from the PCE or at least put it in delete state so it gets removed when the PCC connects(if it was disconnected for some reaosn) - and that must be indicated in the webUI :)

There are two DBs the first one is the controller DB and the second one is the network DB. You create LSPs in the controller DB and they get pushed into the network. Once pushed the devices report all of them back and they get saved into the network DB. We need to make sure they actually get created first.

Yea I know, but as stated above if the information is wrong so the LSP doesn't get established there must be a way to delete it and/or put it in deleted state to later be removed from local db.


Support for Async Delivery?

In Rx2 both subscription (subscribe) and delivery (onNext) can be made async.
This is not the case in Rx3.
The following will fail with:
expected [ 'next:1', 'received:1', 'next:2', 'received:2' ] to equal [ 'next:1', 'next:2', 'received:1', 'received:2' ].
    var loggedValues = [];

    var generator;
    var observable = new Observable(g => {generator = g;}, new NextFrameScheduler());

    observable.observer({
      next: value => loggedValues.push(`received:${value}`),
      return: () => {
        expect(loggedValues).toEqual(['next:1', 'next:2', 'received:1', 'received:2']);
        done();
      }
    });

    setTimeout(() => {
      loggedValues.push(`next:1`);
      generator.next(1);

      loggedValues.push(`next:2`);
      generator.next(2);

      generator.return();
    }, 0);

Are there plans to allow async delivery?
Should not async delivery be the default? After all It is async when dealing with promises.
     var loggedValues = [];

     var resolve;
     var p = new Promise((r) => {
       resolve = r;
     });

     p.then(value => {
       loggedValues.push(`received:${value}`);
       expect(loggedValues).toEqual(['before', 'after', 'received:42']);
       done();
     });

     setTimeout(() => {
       loggedValues.push(`before`);
       resolve(42);
       loggedValues.push(`after`);
     }, 0);

Observables are referentially transparent, so they can be optionally async. If you encapsulate all state within the Observable operators, your code will work the same whether it runs synchronously or asynchronously.
Promises (etc.) force asynchrony because they are stateful. This is sometimes called Releasing Zalgo, and is a problem people encounter when they write programs that rely on mutable external state.
One solution is to always force asynchrony (at the cost of performance). The other (and better imo) solution is to write code that doesn't rely on side-effects.

Hey, Paul. I don't see why promises are stateful and, let's say, hot observables are not. Can you expand on that?

You're right, hot Observables are the definition of stateful. Most side-effects can still be encapsulated inside the Monad and multicast correctly, but if not, you can always switch to subscribing (or observing) on an asynchronous scheduler at that point.

Makes sense.


KNOX-1934 - Setting the default value of knoxsso.cookie.secure.only based on ssl.enabled flag in gateway-site.xml

What changes were proposed in this pull request?
In case the knoxsso.cookie.secure.only is not set we use the value of ssl.enabled flag (defaults to true). Using this approach and not setting knoxsso.cookie.secure.only in our OOTB knoxsso.xml makes it easier to access the admin UI without the need to edit the knoxsso topology in case SSL is disabled.
How was this patch tested?
Adding new JUnit tests:
$ mvn clean -Dshellcheck=true -T1C verify -Prelease,package
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33 min (Wall Clock)
[INFO] Finished at: 2019-08-25T17:21:54+02:00
[INFO] Final Memory: 384M/2246M
[INFO] ------------------------------------------------------------------------

Also tested the deliverable by changing the values in gateway-site.xml and knoxsso.xml as follows:
ssl.enabled=false
knoxsso.cookie.secure.only is not set
----
ssl.enabled=true
knoxsso.cookie.secure.only is not set
----
ssl.enabled=false
knoxsso.cookie.secure.only=false
----
ssl.enabled=false
knoxsso.cookie.secure.only=true

It's been working as expected.

@risdenk @moresandeep @pzampino Could any of you please review my changes? Thanks!


Panning does not work after the WPF quickstart

Mapsui Version
5.0.0-beta.5
Mapsui Platform
WPF
Device
Windows 11
Describe the bug
Following the WPF quickstart. Try to drag the map. Nothing changes. Mouse wheel works. Flinging the map works.
Additional context
I can not reproduce the problem in Visual Studio using the mapsui.sln.

I've spend quite some time on this today. I can not reproduce the bug using the mapsui.sln in VS. So, I've built a nuget package on disk and used that in the sample project (in which I could reproduce it using the online package) but could not reproduce it either. I did built Release packages. Right now I don't know how to proceed.
Possible causes:

Something in SkiaSharp
Some bug we have in our logic that only shows with some particular timing.
some bug we have in out logic that only shows with a particular build process (I did a build in VS with Release selected and used this pack command: dotnet pack /p:RestorePackages=true /p:Configuration=Release /p:Version=5.0.0-beta.15 Mapsui.sln --output Artifacts.

workaround is setting the Map from external.
like
MapControl.Map = new Map(); // and then set the layers

Thank you both for the workaround. This fixes the issue for me.

I assume this is fixed in 5.0.0-beta.6. Please reopen if it is not.


Allow import of ‘adventure.main’ module

The adventure.__main__ module cannot be safely imported; it goes ahead and begins the game loop.
This behaviour foils the ability to unit-test the code in that module. It also prevents setting an “entry point” to import, then run a function.
Please move the top-level main-line code to a if __name__ == '__main__' block.

At https://notabug.org/bignose/python-adventure/src/feature/wip/stand-alone-program (specifically, https://notabug.org/bignose/python-adventure/commit/9fb12a445847c8d8e27688052771e965378770cf) is my suggested change to address this.

Neat! I had not fully realized that, because module names are fully qualified, even a module name __main__.py does not have a __name__ of __main__ when simply imported as part of its package, but instead is named adventure.__main__.


[QA] sharing a file fails on eos

Deployed ocis-1.0.0-rc6 via hetzner-deploy/make_ocis_eos_compose_test.sh

connect a desktop client with user marie, let it sync and watch for issues while doing the next steps
on the WBE-UI:

log in as einstein
share file Portrait.jpg with user marie
create a public share link for the file Portrait.jpg

with a fresh browser session, log in as marie,

accept the share,
go to 'All Files' -> Shares, Portrait.jpg is there. OK
click open the file, it fails showing a red triangle with exlamation mark.

with a fresh browser session, visit the public share link

the link opens showing a view with file Portrait.jpg
click open the file, it fails showing a red triangle with exlamation mark.

marie's desktop client tries to sync down the accepted share, but fails with internal error 500.

12/3/20 11:46:04 AM,                                             Shares/Portrait.jpg,               testpilotcloud3,Server replied "500 Internal Server Error" to "GET https://X.X.X.X:9200/remote.php/webdav/Shares/Portrait.jpg" (skipped due to earlier error, trying again in 42 minute(s))

RC6 has still the old eos 4.5.6
To be retested with RC7 on updated eos 4.8.28

Upstream https://github.com/owncloud/ocis-reva/issues/12


PHP 8 support?

Is PHP 8 support planned for this repository? I am willing to help support it.
The main changes we need to look out for are listed here: https://stitcher.io/blog/new-in-php-8 under "Breaking changes".

x-ref:

https://github.com/zf1s/zf1/issues/31
https://github.com/zf1s/zf1/pull/32

Yeah it's absolutely planned, I'll reopen this though until it's supported

x-ref:

https://github.com/zf1s/zf1/pull/39

you should read instructions how to backport from the other repos:

https://github.com/Shardj/zf1-future/issues/96#issuecomment-740559426

some news about php 8 support ?

@Shardj Thanks for this great project! Can I donate somewhere to motivate you a bit working on PHP 8 support? :)

@Shardj Thanks for this great project! Can I donate somewhere to motivate you a bit working on PHP 8 support? :)

Hey @onlime
Sorry for the lack of motivation on my part, the webapp I work on that uses ZF1 depends on mssql which doesn't yet support PHP 8. So I've not been super motivated to upgrade ZF1 to PHP 8 since I can't do anything with it anyway yet.
As for donations, I don't yet have a way of accepting them. And I'm not sure if I really can accept donations as I work on this repo both in and out of company hours. So it could probably be considered the intellectual property of my employer as much as my own. I'll look into sorting something out there in the future maybe.

Hey @onlime
Sorry for the lack of motivation on my part, the webapp I work on that uses ZF1 depends on mssql which doesn't yet support PHP 8. So I've not been super motivated to upgrade ZF1 to PHP 8 since I can't do anything with it anyway yet.
As for donations, I don't yet have a way of accepting them. I'll look into sorting something out there in the future maybe.

@Shardj
FWIW, ZF1 is an MIT license, so not being a lawyer I'm not sure that your employer has any claim to updates to open source code under an MIT license. They received their benefit by paying you and they have benefited by others updating the project as well, including using the updated open source code that was not updated solely by you. By you keeping the code open source, you're helping the community at large.
I have a commercial project that I will be releasing at the end of this month that uses this project and I will gladly donate and even buy ad space here to help support the project! I'll check out the donations button too!  :)

@WebTigers I'm also not a laywer, and I have no idea as to what exactly is okay in relation to what rights I'd have to be paid through this repo, or any rights my employers may have for work done on this repo during company time. So I've avoided the issue completely by having the donation button on my profile, not on the repo. There's strictly no way to directly donate to this repository at all. I've simply added a way to donate to myself as a person.

@Shardj let's discuss the licensing/donation thing later (I definitely want to donate something...). Just want to let you know that I am currently working on a small PR which should be ready shortly. I am doing some 3-way-diff of zf1s/zf1 monorepo (compiled all packages into library/Zend/), my own patched zf1 1.12.20, and your master branch.
I will not find time to dig deep into it, as it's impossible to review all diffs between shardj/zf1-future and zf1s/zf1 (even after automated PhpStorm refactoring of all traditional into short array syntax and ignoring all whitespace diff). But after some small fixes, my rather large project (which uses at least a third of all ZF1 components) already seems to work 100% on PHP 8.0.2

@onlime awesome stuff, sounds like a huge step towards PHP 8 support for this repo

@Shardj here you go, #130 is mainly @Megatherium's work and it's not yet merged into zf1s/zf1 master. But I have reviewed all changes and they all make sense. Again, my project that uses quite a lot of ZF1 components runs perfectly fine under PHP 8.0.2 and I am going to run this in production as soon as you merge it, so I would quickly notice any problems.

It's out on release-1.19.0 @onlime
Enjoy!

Great, thanks. But please note that I was not able to run unit tests. If you can get them running please do so and let me know of any problems. Please also update .travis.yml and get it running under PHP 8.

#131
Good point

Hey @Shardj, just want to let you know that my rather large legacy ZF1 project is now running perfectly fine for 5 days in production on PHP 8.0 without a single issue!
It's a webhosting controlpanel/dashboard for my customers, so it's a rather complex project that uses ~ 30% of all ZF1 components. We're working on the next-gen customer dashboard which is going to be based on Laravel api backend with Vue.js/Nuxt frontend. But until that's ready, it will all still run on zf1-future. I am so glad you were supporting me getting those fixes for PHP 8 released. I have switched my whole dev environment to PHP8-only, which makes my life even a bit happier than it already is.
Please don't close this issue yet until tests run fine and while we still try to keep up with zf1s/zf1#51

3.5 months later, still no single issue with PHP 8.0. @Shardj please consider closing this issue. Or are you still planning to update tests to PHP 8 / migrate to Github actions?


Migrate this repository to github.com/metanorma

The repository github.com/metanorma has been set up to host all Metanorma related work. This is one such piece of work. While the migration will be slow (there is a lot to do, and a lot of interdependencies), we need to schedule migration for all related repositories.
Migration to Metanorma:

Repost the repository to http://github.com/metanorma/X

This should be as simple as changing the following field in .git/config: [remote "origin"]   url = https://github.com/riboseinc/metanorma-iso.git. Refer https://help.github.com/en/articles/transferring-a-repository

If this is a Ruby gem, change the address of the repository in the *.gemspec
Delete all files but the Readme in the riboseinc repository
Replace the Readme in the riboseinc repository with the message "Repository migrated to http://github.com/metanorma/X
Update the links to the repository in any documentation you maintain
Link the README in the new location to updated links for appveyor, CodeClimate, travis, etc. New links to travis should be to travis-ci.com, not travis-ci.org.
Notify @opoudjis and @strogonoff when you have migrated the repository. They will then update the links to the repository in any documentation they maintain.

@ronaldtse has not migrated this repo. Ronald, if you can confirm that he does not intend do, please close this ticket.

Fine, it's now transferred!


tensorflow canary flowers-sample - default doesn't become ready

To reproduce:
kubectl apply -f https://raw.githubusercontent.com/kubeflow/kfserving/master/docs/samples/tensorflow/tensorflow-canary.yaml
kubectl get configuration

The flowers-sample-canary shows as ready. The flowers-sample-default stays in 'Unknown'. Also don't get a status in kubectl get kfservices.serving.kubeflow.org flowers-sample -o yaml
This is on v0.1.0 of kfserving

/assign @yuzisun
/area project-health

I updated to the latest version of the kfserving controller and this works on the latest.

Awesome!
On Thu, Jul 11, 2019 at 9:56 AM Ryan Dawson<EMAIL_ADDRESS>wrote:

I updated to the latest version of the kfserving controller and this works
on the latest.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/kfserving/issues/233?email_source=notifications&email_token=AATXLCE5SYB63DASPNZLH7DP65Q3XA5CNFSM4H7EQYF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXKPFA#issuecomment-510568340,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATXLCFORCS3QEHOSR7VCYLP65Q3XANCNFSM4H7EQYFQ
.

--


Topic appears in HTML output folder even if it is referenced in resource-only map

Similar in a way to #3692 but this time an entire DITA Map is referenced as resource-only but it's topics are not considered resource-only.
Attaching a sample project.
resource-only-map.zip
So:
The "BlockA/optional_content.ditamap" submap refers to a DITA Map under a resource-only context:
  <topicgroup processing-role="resource-only">
      .......
      <topicref href="blockb.ditamap" format="ditamap" keys="BB"/>
  </topicgroup>

The "blockb.ditamap" refers to two topics:
<topicref href="content5.dita" keys="c5BB">
    <topicref href="content6.dita" keys="c6BB"/>
</topicref>

The topics are not referenced anywhere else.
I publish to HTML5 and in the output folder I have the "content4.html" and "content5.html" equivalent HTML files, so the topics have not been considered resource-only.

We have this same issue.
For us, this bug can expose content that should remain hidden. For example, a resource-only map might provide content-reuse topics for products A, B, and C. But even if a book publishes just a single topic for product B, all topics in the resource-only map get published to the HTML output directory.

Looking at KeyrefModule.java, the logic for determining whether or not to increment the filename is too simplistic and results in renamed files when it should not.
When a topic is used as both resource-only and a content topic, I'm seeing that the filename is incremented whether it's needed or not, sometimes resulting in an incremented filename with no unincremented name in the result.
I would need to spend more time with the Java code to figure out how it might be corrected.
But the algorithm needs to be:
If references to a topic are conkeyrefs and the referenced key is in a resource-only context then the temp file can have any name except one that is the same as the original topic's filename. No HTML should be generated from these topics under any circumstances.
If references to a topic are keyrefs and the referenced key is a resource-only context the key is unresolvable. No effective temp file for this use of the topic.
If references to a topic are keyrefs and the referenced key is in a normal-role context and the key is the first use of the topic, retain the topic's original filename.
If references to a topic are keyrefs and the referenced key is in a normal-role context and the key is the second or subsequent use of the topic (with a different key name, of course--we don't care about uses of topics that are duplicate key names--key references should only resolve to the first effective key definition), generate a unique topic filename, using some algorithm (i.e., use the key name, use a  value, increment, etc.).  (This also implies that filtering is done in advance of this result temp topic filename determination, or determination is filtering aware so that it knows whether a given keydef will or won't be effective when filtered.)
The algorithm should ensure that the first normal-role use of a topic retains the topic's original filename.
Follow-on processing should not generate HTML files from resource-only uses of topics.
In my testing, I'm seeing, for example, that the .job.xml file reflects a topic that is used both as resource-only and normal role as not being resource-only but with an incremented filename.
If I understand how the .job.xml file is used, there should be two entries for this topic, one for its resource-only use, with an incremented filename and a resource-only="true" and one for its normal-rule use with the topic's original filename and resource-only="false".
In other cases I'm getting two temp topics, one for the resource-only use and one for the normal-role use. The increment is applied depending on which keydef occurs first (and our default map organization puts the resource-only keydefs before the content keydefs).

Same problem here:
MainDitamap.zip
Two ReusedTopic1.html and ReusedTopic2.html files are produced in the output folder although they should be interpreter as resource only.

👍 👍 another one of our end users encountered this problem.

We are facing the same issue.
Furthermore, our resource-only ditamap contains a lot of files so the build is really slow (because all these files are processed in the output folder).
Do you known any work around ?

@ruthrapr  Probably you can set the processing-role="resource-only" attribute on the root <map> element of the resource-only map.

@raducoravu We tried processing-role="resource-only" on the root map but the files are still processed as output and copy in the output folder.

@ruthrapr what DITA OT version are you using? If you are not using the latest DITA OT 4.1 please also try to publish using it. If you are using DITA OT 4.1 maybe you can attach a zip containing a small DITA project on which the problem can be reproduced along with steps to reproduce it.

Hi @raducoravu, my test was using dita-ot-4.0.2 but after your message, I made a new clean install of dita-ot-4.1.1 without any custom plugins.
DITA-OT command was run from terminal using
bin/dita -i ../../Desktop/github-issue-3802/map.ditamap -f html5 --verbose
I runned this command against your sample (https://github.com/dita-ot/dita-ot/issues/3802#issuecomment-1522976793) and found the same result as yours. Then I runned it on mine sample.zip.
In output folder, a topic "notToPublishTopic.dita" referenced in a processing-role="resource-only" map still appear.

@ruthrapr so once you set processing-role=resource-only inside the "from_issue_480.ditamap" DITA Map on the root map element the extra "notToPublishTopic.dita" topic should no longer appear in the output folder, right? At least this seems to work on my side. I manually deleted the output folder before publishing.

@raducoravu Thanks, indeed setting it on "from_issue_480.ditamp" fixed it.
This attribute shouldn't be cascading from the "metadatas.ditamap" ?
Moreover, I tried on setting it on <topicref href="from_issue_480.ditamap" format="ditamap" processing-role="resource-only"/> but it still processed in output folder. The attribute processing-role="resource-only" must be on the "map" element of "from_issue_480.ditamp". It seems counter intuitive to me.
Sorry to hijacking your issue, I though it was related.

@ruthrapr  thanks for confirming this, you are not hijacking the issue, this is the entire point of the issue that the processing-role does not properly cascade.

The diagram for resource-only-map.zip is:

and the output directory contains:
commonltr.css
commonrtl.css
content1.html
content2.html
content3.html
content4.html
content5.html  <-- unexpected
content6.html  <-- unexpected
index.html

The diagram for sample.zip is

and the output directory contains:
out/a_topic.html
out/commonltr.css
out/commonrtl.css
out/index.html
out/metadata/notToPublishTopic.html  <-- unexpected

Another Oxygen user encountered this problem.
I re-tested it using dita-ot-4.2.2 and html5 transformation but the problem persists.
I also tested with both preprocess and preprocess2 with the same result.


ADD: privs for connector role: EKSDiscovery and SSMTermiante

We are expanding connector role to enable access for new auto-discovery plugins

@atoonk not sure if I tested this right, feel free to merge it and check again. i can jump on it first thing if something's still missing


Update README.md

Missing I18n parameter which can be localized by user. Sorry for preview pull req (closed by myself) - there was a typo - missing single quotation mark at the end of line.

Thanks for the fix!


Bug rendering Zero-width joiner Unicode sequences

(Extract from this report)
We detected an issue rendering text with Zero-width joiner sequences. What is that? Fonts can specify a glyph for certain sequence of characters. This is the case of the following example, where the same Unicode sequence is rendered on first row using only Cairo, and the second row using Harfbuzz before Cairo:

The sequence can be generated in this way:
WideString streamContents: [ :stream |
    #( 16r1F468 16r1F469 16r1F467 16r1F466 ) "<-- individual faces"
        do: [ :each |  stream nextPut: (Unicode value: each) ]
        separatedBy: [ stream nextPut: Unicode zeroWidthSeparator ]]

The Noto Color Emoji font has a specific glyph for that sequence: the family shown in the second row of the screen capture. Without Harfbuzz to apply the font rule, we can only render the individual characters of the sequence (as in the first row of the capture).
The bug: Some times the family glyph is not rendered... that portion of the image is just white. Good news is that this is reproducible, not random. This example can be found in: AeHarfbuzzRenderExample class>>#example6Emoji, but should become a test.

With PR #58 I still see random results like this:

This is in all operating systems. I will keep skipping the 4 tests until trying a different set of graphics dependencies.

The PR did un-skip renderLigatureTextWithHarfbuzz but still keeps the skip for the 3 tests on emoji font.

Link to #16

Color fonts are a quite recent feature in Cairo lib. I suspect this is bug is derived from a bug at low-level. These are some related issues and PR:

https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/537
https://gitlab.freedesktop.org/cairo/cairo/-/issues/603
https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/482
https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/397


chore(deps): update terraform github.com/terraform-ibm-modules/terraform-ibm-powervs-instance to v0.2.7

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/terraform-ibm-powervs-instance
module
patch
v0.2.6 -> v0.2.7

Release Notes

terraform-ibm-modules/terraform-ibm-powervs-instance (github.com/terraform-ibm-modules/terraform-ibm-powervs-instance)
v0.2.7
Compare Source
Bug Fixes

update ansible version to 1.1.3 (#86) (313c240)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

GitHub release
v1.1.0

Your semantic-release bot :package::rocket:


Fixed DID DHT library regression where kid becomes undefined

Fixed DID DHT library regression where kid becomes undefined
Added tests to prevent this from happening again in vector tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.12%.  Consider uploading reports for the commit 49a931e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   91.10%   91.12%   +0.02%
==========================================
  Files         116      116
  Lines       29664    29665       +1
  Branches     2199     2200       +1
==========================================
+ Hits        27024    27033       +9
+ Misses       2605     2597       -8
  Partials       35       35

Components
Coverage Δ

agent
80.86% <ø> (ø)

api
97.93% <ø> (+0.15%)
:arrow_up:

common
98.68% <ø> (ø)

credentials
95.26% <ø> (ø)

crypto
93.81% <ø> (ø)

dids
97.78% <100.00%> (+0.08%)
:arrow_up:

identity-agent
96.70% <ø> (ø)

crypto-aws-kms
100.00% <ø> (ø)

proxy-agent
96.70% <ø> (ø)

user-agent
96.70% <ø> (ø)


Add support for NSProgress

It would be great if one could just feed MBProgressHUD with activated NSProgress instance, so that it updates progress automatically.

+1 For this feature. I would love this. Right now I have to add an observer on the NSProgress and update the MBProgressHUD myself.

@VilemKurz  @brendand  Hi I am working on chatting app. Though i using  MBProgressHUDModeAnnularDeterminate Loader using podfile. Working fine. that method I am using in Tableview Cell for image loading, but when i scroll and uploading new image from iphone to server then  it is showing loader  on every image cell . How to resolve it ?? Please Help me.

@chinnuios This is completely off topic and a re-post of https://github.com/jdg/MBProgressHUD/issues/367. Don't do that.


[New Feature] Anime Command

Functions

[ ] able to search the percise Anime from keyword
has a async function if query is taking long express solves that lmao

Implementation

[ ] MAL Integration
[ ] a extensible command module

petition to make command name generic weeb command

Fixed on refactor. Closed.


Use C-string literals for EL type in C-API

Requires bumping MSRV.

This is blocked by https://github.com/dtolnay/syn/issues/1502.

This is blocked by dtolnay/syn#1502.

syn/issues/1502 has been merged if you're still planning to merge this PR

Yes I'm aware. It was still blocked until recently by https://github.com/mozilla/cbindgen/issues/927.
Now cbindgen 0.27.0 was released.
cargo-c needs an update otherwise it seems to build.


Unexpected buffer value when assigning -1

After upgrading Duktape to version 1.1.1 I got one failure test  with buffers
Duktape v1.0
var b = Duktape.Buffer(10);
b[0] = -1;
print(b[0]); //--> 255

Duktape v 1.1.1
var b = Duktape.Buffer(10);
b[0] = -1;
print(b[0]); //--> 0
```
I've implemented a wrapper around duktape Buffer to make it compatible with node's buffers so I'm running node's buffer tests.

This has been fixed in master:
((o) Duktape 1.1.99 (v1.1.0-134-g5c74ffe)
duk> var b = Duktape.Buffer(10); b[0] = -1; print(b[0]);
255

If this is breaks something concretely I can add the fix to the 1.1.2 fix list too.

For me its not of that importance and only breaks one test :) so fixing in 1.2.0 is good enough.
Sorry, I had to indicate that this might be a Two's complement buffer issue, so I'm not sure if changing the title to when assigning -1 is clear as the bug is the same with all negative values, I guess it's better to say when assigning a negative number  which will make more sense for future reference :)

Added a note for 1.1.2 fix list, closing this.


I have this....(⊙o⊙)…can not use XlabsSampler...

Error occurred when executing XlabsSampler:
list index out of range
File "E:\AI\ComfyUI\execution.py", line 317, in execute
output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "E:\AI\ComfyUI\execution.py", line 192, in get_output_data
return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "E:\AI\ComfyUI\execution.py", line 169, in _map_node_over_list
process_inputs(input_dict, i)
File "E:\AI\ComfyUI\execution.py", line 158, in process_inputs
results.append(getattr(obj, func)(**inputs))
File "E:\AI\ComfyUI\custom_nodes\x-flux-comfyui\nodes.py", line 344, in sampling
x = denoise(
File "E:\AI\ComfyUI\custom_nodes\x-flux-comfyui\sampling.py", line 176, in denoise
t = timesteps[t_idx]

andshow this when start ComfyUI

hi. it is not related with einops
could you please send your Comfy workflow in json format?

flux.json
XlabsSampler  error..

Please use "Empty Latent Image" node, "EmptySD3LatentImage" is not correct

@Anghellia---- It's true! It really worked just as you said. Thank you so much! I can't believe I didn't think of this issue. Thanks again!


Paragraph does not take entire width for short sentences

Paragraph does not take entire width for short sentences which breaks the alignment of the paragraph.
To demonstrate:

Though, if the first sentence of the paragraph is long enough to fit the entire width, the problem disappears. That can be observed by typing on the second node until the entire line is covered, then insert new lines using shift+enter.
To reproduce:

Using the example_editor demo, replace the mutable document with:

Document _createInitialDocument() {
  return MutableDocument(
    nodes: [
      ParagraphNode(
        id: DocumentEditor.createNodeId(),
        text: AttributedText(
          text:
              'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus sed sagittis urna. Aenean mattis ante justo, quis sollicitudin metus interdum id. Aenean ornare urna ac enim consequat mollis. In aliquet convallis efficitur. Phasellus convallis purus in fringilla scelerisque. Ut ac orci a turpis egestas lobortis. Morbi aliquam dapibus sem, vitae sodales arcu ultrices eu. Duis vulputate mauris quam, eleifend pulvinar quam blandit eget.',
        ),
        metadata: {'textAlign': 'center'},
      ),
      ParagraphNode(
          id: DocumentEditor.createNodeId(),
          text: AttributedText(
            text: ' Lorem ipsum dolor.       ',
          ),
          metadata: {'textAlign': 'center'}),
      ParagraphNode(
          id: DocumentEditor.createNodeId(),
          text: AttributedText(
            text: ' Lorem ipsum dolor sit amet..     ',
          ),
          metadata: {'textAlign': 'right'}),
       ParagraphNode(
          id: DocumentEditor.createNodeId(),
          text: AttributedText(
            text: ' Multi-line paragraph \nsecond \nthird \n4th  ',
          ),
          metadata: {'textAlign': 'center'}),
    ],
  );
}

Additional Context:
In the image above:

Light Red color is a Container wrapped around:
https://github.com/superlistapp/super_editor/blob/78556f359dbe2425e58ccc03676c345091cda9a3/super_editor/lib/src/default_editor/paragraph.dart#L538

Blue Grey color is a Container wrapped around:
https://github.com/superlistapp/super_editor/blob/78556f359dbe2425e58ccc03676c345091cda9a3/super_editor/lib/src/infrastructure/selectable_text.dart#L454

I used MacOS for the demo above, here's the `flutter doctor` output:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.0.4, on macOS 11.2.3 20D91 darwin-x64, locale en)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1)
[✓] VS Code (version 1.55.2)
[✓] Connected device (2 available)

Thanks. I'll add this issue to the v0.1 priority list.


Allow specifying strategy to implement @model id

Do you want to request a feature or report a bug?
Feature Request
What is the current behavior?
currently when using @model, resolver for create mutation sets id to $util.autoId().
There are situations where this is not wanted. e.g.: we may want to use the current user identity information as the ID (use case: build user setting store).
could the directive be updated to something like this:
directive @model(
    id: idStrategy
    queries: ModelQueryMap,
    mutations: ModelMutationMap,
    subscriptions: ModelSubscriptionMap
) on OBJECT
enum idStrategy {auto sub username cognitoIdentityId}
input ModelMutationMap { create: String, update: String, delete: String }
input ModelQueryMap { get: String, list: String }
input ModelSubscriptionMap {
    onCreate: [String]
    onUpdate: [String]
    onDelete: [String]
}

where:
auto: util.autoId()
sub: ctx.identity.sub
username: ctx.identity.username
cognitoIdentityId: ctx.identity.cognitoIdentityId

with auto as the default

The problem with what you suggest is now you get into the necessity for mobile and web developers to understand distributed systems concepts in databases, which is exactly what we want to avoid.

i agree we should try to avoid this if possible

This also has implications to offline storage and persistence in the clients

not necessarily

The identity of a user can be used as a key to retrieve a single object. This is made available by CUP and does not require persistence beyond what is already done. Suppose i want to store information about a User in dynamodb table and want to put auth around it. right now i could do
type User @model @auth(rules: [{ allow: owner }]) {
id: ID!
owner: String!
}

there is no direct way to get this a User. i would have to use listUsers and filter on owner field. If there are 100s of users, that means scanning the all the rows before filtering the returned data. seems costly.
this might be a limited use case, but i could see this coming up for collaborative applications where user information is maintained with appsync.
thoughts?

Not sure I understand that use case directly because you could just have a query to get that user's specific data, either with an expression or an index on the userId per my previous post. And this does impact offline storage tracking as the semantics by which we perform CRUD operations in local DBs is dependent on the key schema and references.
I'm still not convinced of your use case, but if we were to do something like this it would have to be an override and not the default, with caveats that it can break some things (hotkeys, offline).

i actually like option 1) as an advanced configuration without impact the current @model directive

I agree. I think this is a useful feature to have and could use a little more design. Let's use this issue to track the work. Also as a general note, a lot of these tasks like this one, https://github.com/aws-amplify/amplify-cli/issues/84, and https://github.com/aws-amplify/amplify-cli/issues/83 are just waiting for available hands if anyone is looking for a way to contribute 👍

I still would like to see a good use case for this, so far all the ones I've heard are hypothetical or can be solved with proper indexing on the database. I'm very concerned of leaking implementation details into an abstraction that is supposed to allow customers to focus on the job to be done rather than how it's being done. Also the data reconciliation process for offline mutations in the cache with the backend could be impacted negatively by this, so we'd need to test that. The key indices are what we use to perform object synchronization, including dependent mutations with unique keys (e.g. blogs and comments).
If there is strong customer demand for this let's look at supporting but I'd really like to get more clarity on use cases and upvotes from developers that need this to meet a use case. It might very well be that there are some non-caching or non-Mobile/Web use cases that this helps with.

@mikeparisstuff
I also prefer variant 1

This is a great issue. I don't think it is currently possible to create a one-to-one relationship between models and Cognito users without this.

@blbradley That's a pretty interesting use case and we've chatted with some people about it in the past. Can you go into detail about what you're trying to build between AppSync, DynamoDB and Cognito and what data you'd be looking to store & access using GraphQL at different parts of the lifecycle?

Sure! I'm building an app that will be doing integrations with various Git providers (GitHub/GitLab/others) and need to store the particular service's auth token per user.

Sure! I'm building an app that will be doing integrations with various Git providers (GitHub/GitLab/others) and need to store the particular service's auth token per user.

If this was storing tokens in DynamoDB, that would be discouraged. Tokens should be ephemeral and on the device not stored centrally.

I suppose that it still applies, with the server being the device. Thanks!

I want to find a way to localization and I'm thinking "locale" as sortKey might be one way for that.
But, since this is the first time for me to use dynamoDB and AppSync and I don't know it will work.
This is not the something to ask here though, would you let me know if you know how to do localization.
Thank you in advance!.

Sorry, I'm talking about server-to-server interactions. Does your statement still apply to that?

I think we'd need to investigate that more, however it's worth noting that use case isn't the primary scope for Amplify or the GraphQL transformer. This project is for client development using web and mobile apps.

I want to find a way to localization and I'm thinking "locale" as sortKey might be one way for that.
But, since this is the first time for me to use dynamoDB and AppSync and I don't know it will work.
This is not the something to ask here though, would you let me know if you know how to do localization.
Thank you in advance!.

Can you give an example of the types of queries and mutations you would like to run as a use case in your app flow? Then the data model will fall out of that.

My server-to-server interactions would happen in an Amplify managed Lambda and would be retrieving data for display in my Amplify managed React app.

I want to find a way to localization and I'm thinking "locale" as sortKey might be one way for that.
But, since this is the first time for me to use dynamoDB and AppSync and I don't know it will work.
This is not the something to ask here though, would you let me know if you know how to do localization.
Thank you in advance!.

Can you give an example of the types of queries and mutations you would like to run as a use case in your app flow? Then the data model will fall out of that.

@undefobj Thank you for your reply :)
I'm thinking something like this.
# @translation(en,ru,cn,ja,fr,es)
type Disease
  @model
{
  id: ID!
  name: String! @translation
  description: String @translation
  category: String!
  data: [Data!]!
}
type Data
  @model
{
  someData: AWSJSON
}

query DiseaseQuery {
  getDisease($locale: String!, $id: ID!) {
    id
    name
    description
  }
}

then create table like below, for example
{
id
name_en
name_ru
...
}
and, response with localized value using query variable in mapping template.
Is it possible?
Also problem could be, the maximum item size in DynamoDB is 400KB.
I'm new to DynamoDB and AppSync, and totally get lost.
At now, I think I would do something like,,,
type DiseaseRoot
  @model
{
  id: ID!
  diseases: [Disease!]!
  category: String!
  data: [Data!]!
}
type Disease
  @model
{
  diseaseRootId: String!
  lang: String!
  name: String!
  description: String
}
type Data
  @model
{
  someData: AWSJSON
}

query DiseaseQuery {
  getDisease($locale: String!, $id: ID!) {
    id
    category
    data {
      someData
    }
    diseases(
      where: { lang: $locale }
    ) {
      name
      description
    }
  }
}

I wanted to report back.  Cognito custom user attributes worked well! The only problem is the limitation of maximum 25 custom user attributes. So, only a problem as an app grows.

fyi, just to add a vote, I'm also running into this, exact same scenario as https://github.com/aws-amplify/amplify-cli/issues/134. Storing users and so it seems to make sense that id of users should be cognito sub. Also the appsync client demos such as https://github.com/aws-samples/aws-mobile-appsync-chat-starter-angular (written by @onlybakam) do this so it's confusing to see an aws app demo doing this but then the amplify cli team saying this is not a good idea and will break things in the future.
So really my question is, if we're storing Users in dynamo through appsync, and that corresponds to Cognito users, what is the best practice of what the id should be? autoId() and then use the owner field like how amplify cli sets things up now or just set id to cognito sub?
Also why does amplify gql transformer set "owner" to "context.identity.user", shouldn't it be "context.identity.sub".

So, keep in mind that AppSync has offline enabled by default.
If offline is enabled, you MUST provide an optimistic response with your mutations.
In order to provide an optimistic response, you must provide the pk locally.
That is the use case we're currently hitting and I think the only way to solve that would be with the #2 proposed solution from @mikeparisstuff

fyi, just to add a vote, I'm also running into this, exact same scenario as #134. Storing users and so it seems to make sense that id of users should be cognito sub. Also the appsync client demos such as https://github.com/aws-samples/aws-mobile-appsync-chat-starter-angular (written by @onlybakam) do this so it's confusing to see an aws app demo doing this but then the amplify cli team saying this is not a good idea and will break things in the future.
So really my question is, if we're storing Users in dynamo through appsync, and that corresponds to Cognito users, what is the best practice of what the id should be? autoId() and then use the owner field like how amplify cli sets things up now or just set id to cognito sub?
Also why does amplify gql transformer set "owner" to "context.identity.username", shouldn't it be "context.identity.sub".

@hisham we're not necessarily saying that it's a "bad idea" more that we're trying to find the best interface to maintain the abstraction for ease of use as well as flexibility. The GraphQL transformer was designed to remove the need (or greatly reduce) to write resolvers or worry about the underlying cloud implementation, so we just want to have thorough discussions around pros vs. cons for certain designs. As @CodySwannGT says part of our client implementations is to do offline by default and we have certain offline helpers that will create ephemeral local IDs when creating objects offline first and then use bookeeping techniques to reconcile them with the backend once the write is committed to the cloud. These client libraries also do optimistic responses, version control, and conflict resolution. The design allows us to do this regardless of the data source so while this is DynamoDB specific it could be other things in the future.
We just want to ensure that the designs of the interfaces are consistent, simple, and keep the proper abstractions while working seamlessly with our clients as well as allowing you the level of control you're looking for.

This issue is fixed and would be a part of the next CLI version (0.1.30).

@kaustavghosh06 it's great to know the feature is added, where can we find docs about it?

@kaustavghosh06 @mikeparisstuff did the sort key @sk/@sort end up getting implemented? Was getting an error trying these.
How would one add a sort key to @model?
Thanks

I'm also interested in option 1 mentioned by @mikeparisstuff as I've got an existing DynamoDB table with a key different from 'id' and therefore the auto-generated resolvers don't match my schema.
Looking at #356 I can see that it implemented option 2 and mentions that option 1 would be a larger piece of work.
Would you consider an initial first step towards option 1 of enforcing zero/one 'ID' type per @model and modifying the dynamodb transformer and resolver generation to use that field name if provided or 'id' otherwise?
An example would be:
#model defined with custom ID field
type UserCustomId @model {
    userName: ID!
    firstname: String!
    lastname: String!
}

#Auto generated delete input example
input DeleteUserCustomIdInput {
  userName: ID
}

#model defined with no ID field
type UserNoId @model {
    firstname: String!
    lastname: String!
}

#Auto generated delete input example
input DeleteUserNoIdInput {
  id: ID
}

I've already mocked this up locally (without sufficient testing / validations in place yet) but not sure if this is an approach you want to go with or just hold off on this until work can be done on the @pk/@sk/@sort functionality.
Happy to hear your plans for this piece of work / thoughts on the initial option.

As per https://github.com/aws-amplify/amplify-cli/issues/56#issuecomment-437635042
Where is the documentation on how to us this?  What do I put into schema.graphql to specify that my user table ID field is to be populated by AppSync with the Cognito sub or identity ID?


fix log level

Signed-off-by: huqun<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:qunhu/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

You also opened #20150 ; is that meant to be a replacement for this one? You only have one of the changes from warning -> error in that new PR; is that intentional?  It would help to have a short comment with your commit to explain why the change is necessary unless it is trivial (like a typo fix).
Also, in the future, please try and follow the recommendation to update a PR rather than create a new one. Let us know which one of these two can be closed.
If you need help figuring out how to update the active PR let us know!

Closing this for the same reason exposed in https://github.com/docker/docker/pull/20150#issuecomment-181947020
Thanks for your submission, but the current behavior is correct.

@estesp I didn't know about how to update the active PR,and will do that next time.
thanks for  prompting!


cashu requires python-bitcoinlib which makes extension unusable in LNbits

Transfered from https://github.com/lnbits/lnbits/pull/2044 here

Currently cashu extension is broken in LNbits, because it requires python-bitcoinlib which is not imported (not present in LNbits pyproject.toml).
Relevant code that uses python-bitcoinlib is here: https://github.com/lnbits/cashu/blob/0.3.0/lib/cashu/core/script.py#L9-L18
We can either:

rewrite the code to use embit instead of python-bitcoinlib (embed is imported by LNbits by default because other 3 dependencies need it)
copy required code from python-bitcoinlib to cashu repo (what boltz extension does with boltz_client dependency)
identify whether the code in lib/cashu/core/script.py is needed in LNbits context and if not, fix it so it's not imported there

Fixed by #45 (removed python-bitcoinlib)


IndexCompact: store an additional 16 bits in the primary vector

Average search time and allocation for construction and search go up a bit, but the worst-case scenario that appsWithNearDups exercises drastically improves. search is back to allocating zero bytes, and allocations for construction are more than halved
Benchmark                                                                                before    after-after
Bench.Database.LSMTree.Internal.IndexCompact/construction/construction with 0-bit  rfprec and chunk size 100  0.408e-4  0.427e-4  +4.69%
Bench.Database.LSMTree.Internal.IndexCompact/construction/construction with 16-bit rfprec and chunk size 100  1.080e-4  1.145e-4  +6.02%
Bench.Database.LSMTree.Internal.IndexCompact/construction/unsafeWriteRange-10k                                0.580e-6  0.581e-6  +0.07%
Bench.Database.LSMTree.Internal.IndexCompact/construction/unsafeWriteRange-1k                                 0.937e-7  0.945e-7  +0.81%
Bench.Database.LSMTree.Internal.IndexCompact/non-uniformity/construct appsWithNearDups                        2.098e-4  0.441e-4 -78.99%
Bench.Database.LSMTree.Internal.IndexCompact/non-uniformity/construct appsWithoutNearDups                     2.002e-5  2.080e-5  +3.86%
Bench.Database.LSMTree.Internal.IndexCompact/non-uniformity/search appsWithNearDups                           0.939e-3  0.042e-3 -95.55%
Bench.Database.LSMTree.Internal.IndexCompact/non-uniformity/search appsWithoutNearDups                        2.492e-5  3.759e-5 +50.87%
Bench.Database.LSMTree.Internal.IndexCompact/searches/searches with 0-bit  rfprec                             0.386e-4  0.558e-4 +44.58%
Bench.Database.LSMTree.Internal.IndexCompact/searches/searches with 16-bit rfprec                             0.980e-5  1.660e-5 +69.38%
Geometric mean                                                                                1.972e-5  1.430e-5 -27.50%

I have yet to check how the macro-benchmarks are affected. Will update on that later

Closed, since we're refactoring the compact index.


[aes/rtl] Fix status tracking for initial key and IV registers

Whenever the key is loaded, this must be signaled. In addition, when the IV has been fully updated internally, any write by software must reset the status tracking to prevent partial updates by software.
This resolves lowRISC/OpenTitan#2913.

Thanks for your review @rasmus-madsen .
Update: CI failed and I had to modify the fix: The key shall not be declared as used unless decryption is performed. Otherwise the decryption key generation is not triggered when changing to decryption (this caused the AES CI test on Verilator to fail). The updated PR still passes with the previously failing seeds.

@vogelpi can we merge this - I am blocked until this goes in

thank you @GregAC


Runtime error in call to authViewController(): 'Could not load NIB in bundle: 'NSBundle ... (loaded)' with name 'FIRAuthPickerViewController''

Objective C or Swift: Swift
iOS version: 9.3.5
Firebase SDK version: 3.4.0
FirebaseUI version: 0.5.4
CocoaPods Version: 1.1.0-rc1
Xcode version: 8.0 GM

Step 3: Describe the problem:
Sorry to be back here so soon after you were so quick on the turnaround with the other issue I posted earlier.
Now that 0.5.4 will build correctly, I get an exception about the bundle not being able to open the NIB file "FIRAuthPickerViewController" at runtime when FIRAuthUI.authViewController() is called.
Steps to reproduce:

Code below fails at runtime. This happens in my own project, but I see that it also happens in the sample code in this repo, so I'll reference that. Start the uidemo project, select the Auth demo, hit Start, and it'll crash immediately.

Observed Results:
The code compiles and runs, but it throws an exception at runtime during the call to authUI!.authViewController().
Here is the barf at runtime:
2016-09-12 17:08:00.576 uidemo[6783:3230924] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not load NIB in bundle: 'NSBundle </var/containers/Bundle/Application/5A387BD1-3913-41CB-A5E1-88A7306AC0E9/uidemo.app> (loaded)' with name 'FIRAuthPickerViewController''
*** First throw call stack:
(0x18333adb0 0x18299ff80 0x18333acf8 0x1889733a4 0x188815230 0x1885da118 0x1885a8ea4 0x18849c8ec 0x18849c844 0x100093b40 0x1000967d4 0x10009bdc8 0x10002426c 0x10002455c 0x1884d4be8 0x1884d4b64 0x1884bc870 0x1884d4454 0x1884d4084 0x1884ccc20 0x18849d04c 0x18849b628 0x1832f109c 0x1832f0b30 0x1832ee830 0x183218c50 0x184b00088 0x188506088 0x100032430 0x182db68b8)
libc++abi.dylib: terminating with uncaught exception of type NSException
Expected Results:
The function to successfully return the ViewController.
Relevant Code:
https://github.com/firebase/FirebaseUI-iOS/blob/070ad199730d467eacd96aeaec773082a1cc81d8/samples/swift/uidemo/AuthViewController.swift#L82

same issue in demo.

Hm, interesting. But it seems like the problem might actually be in the code that calls this base class function: https://github.com/firebase/FirebaseUI-iOS/blob/070ad199730d467eacd96aeaec773082a1cc81d8/FirebaseAuthUI/FIRAuthPickerViewController.m#L64

Hi, I am having the same issue as davidsantiago.
Objective C or Swift: Objective C
iOS version: 9.3.5
Firebase SDK version: 3.5.2
FirebaseUI version: 0.5.4
CocoaPods Version: 1.1.0-rc1
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not load NIB in bundle: 'NSBundle ... (loaded)' with name 'FIRAuthPickerViewController''
*** First throw call stack:
(0x2330791b 0x22aa2e17 0x23307861 0x27d36761 0x27be9aa3 0x279bcffb 0x2798d177 0x27882a1f 0x27882971 0x1f58cd 0x1f7fe1 0x1fcb2f 0xa4f29 0x27882a1f 0x27882971 0x27889639 0x27886b3d 0x278fba5d 0x93045 0x278f7785 0x27b1f2d1 0x27b23285 0x27b3783d 0x27b207b3 0x249aac07 0x249aaab9 0x249aadb9 0x232c9dff 0x232c99ed 0x232c7d5b 0x23217229 0x23217015 0x278f0c3d 0x278eb189 0xf6d3d 0x22ebf873)
libc++abi.dylib: terminating with uncaught exception of type NSException

This is a podspec issue, fix coming soon 👍

This should be fixed in 0.5.5

This issue still seems to exist. I'm using 'FirebaseUI/Auth', '~> 1.0', any suggestions?

@newPrimitives your issue is likely slightly different from this one. Can you post the stack trace here?

@morganchen12 It might be that I made a mistake in the migration, I inherited the code 3 days ago. Here is the stack trace:
2016-12-02 19:09:25.849 OneCoworking[24112:831553] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not load NIB in bundle: 'NSBundle </Users/nermin/Library/Developer/CoreSimulator/Devices/E5CCA957-2AC1-438F-9C52-4C95886B564E/data/Containers/Bundle/Application/4D4A6DDF-CCBA-4345-9140-E00956962D10/OneCoworking.app> (loaded)' with name 'One_Coworking.CustomFIRAuthPickerViewController''
*** First throw call stack:
(
0   CoreFoundation                      0x000000010f4e334b exceptionPreprocess + 171
1   libobjc.A.dylib                     0x000000010edc621e objc_exception_throw + 48
2   CoreFoundation                      0x000000010f54c265 +[NSException raise:format:] + 197
3   UIKit                               0x000000010feedbd2 -[UINib instantiateWithOwner:options:] + 507
4   UIKit                               0x000000010fc81c21 -[UIViewController loadViewFromNibNamed:bundle:] + 386
5   UIKit                               0x000000010fc82543 -[UIViewController loadView] + 177
6   UIKit                               0x000000010fc82878 -[UIViewController loadViewIfRequired] + 201
7   UIKit                               0x000000010fc830cc -[UIViewController view] + 27
8   OneCoworking                        0x000000010a9f7bda -[FUIAuthBaseViewController initWithNibName:bundle:authUI:] + 553
9   OneCoworking                        0x000000010a9fb1b4 -[FUIAuthPickerViewController initWithNibName:bundle:authUI:] + 89
10  OneCoworking                        0x000000010a955fe6 TFC13One_Coworking33CustomFIRAuthPickerViewControllercfT7nibNameGSqSS_6bundleGSqCSo6Bundle_6authUICSo7FUIAuth_S0 + 358
11  OneCoworking                        0x000000010a9561bf TToFC13One_Coworking33CustomFIRAuthPickerViewControllercfT7nibNameGSqSS_6bundleGSqCSo6Bundle_6authUICSo7FUIAuth_S0 + 207
12  OneCoworking                        0x000000010a9fb12d -[FUIAuthPickerViewController initWithAuthUI:] + 121
13  OneCoworking                        0x000000010a894524 TTOFCSo27FUIAuthPickerViewControllercfT6authUICSo7FUIAuth_S + 36
14  OneCoworking                        0x000000010a89415c TFCSo27FUIAuthPickerViewControllerCfT6authUICSo7FUIAuth_S + 76
15  OneCoworking                        0x000000010a8940e7 TFC13One_Coworking23FirebaseLoginController24authPickerViewControllerfT9forAuthUICSo7FUIAuth_CSo27FUIAuthPickerViewController + 55
16  OneCoworking                        0x000000010a8941aa TToFC13One_Coworking23FirebaseLoginController24authPickerViewControllerfT9forAuthUICSo7FUIAuth_CSo27FUIAuthPickerViewController + 58
17  OneCoworking                        0x000000010aa011f6 -[FUIAuth authViewController] + 267
18  OneCoworking                        0x000000010a893e4d TFC13One_Coworking23FirebaseLoginController26createSignInViewControllerfT_GSqCSo16UIViewController + 525
19  OneCoworking                        0x000000010a91358b TFC13One_Coworking18AuthFlowController17connectToFirebasefT_T + 59
20  OneCoworking                        0x000000010a9113d6 TFC13One_Coworking18AuthFlowController3actfT_T + 230
21  OneCoworking                        0x000000010a910b15 TFFC13One_Coworking18AuthFlowControllercFT18rootViewControllerCSo16UIViewController_S0_U_FTCSo7FIRAuthGSqCSo7FIRUser__T + 133
22  OneCoworking                        0x000000010a8929d3 TTRXFo_oCSo7FIRAuthoGSqCSo7FIRUser___XFo_iTS_GSqS0____iT + 35
23  OneCoworking                        0x000000010a910ea1 TPA__TTRXFo_oCSo7FIRAuthoGSqCSo7FIRUser___XFo_iTS_GSqS0____iT + 81
24  OneCoworking                        0x000000010a892597 TTRXFo_iTCSo7FIRAuthGSqCSo7FIRUser___iT__XFo_oS_oGSqS0 + 39
25  OneCoworking                        0x000000010a892681 TTRXFo_oCSo7FIRAuthoGSqCSo7FIRUser___XFdCb_dS_dGSqS0___ + 81
26  OneCoworking                        0x000000010a9e4059 __41-[FIRAuth addAuthStateDidChangeListener:]_block_invoke.275 + 58
27  libdispatch.dylib                   0x0000000111ff2980 _dispatch_call_block_and_release + 12
28  libdispatch.dylib                   0x000000011201c0cd _dispatch_client_callout + 8
29  libdispatch.dylib                   0x0000000111ffc8d6 _dispatch_main_queue_callback_4CF + 406
30  CoreFoundation                      0x000000010f4a74f9 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE + 9
31  CoreFoundation                      0x000000010f46cf8d __CFRunLoopRun + 2205
32  CoreFoundation                      0x000000010f46c494 CFRunLoopRunSpecific + 420
33  GraphicsServices                    0x0000000113d95a6f GSEventRunModal + 161
34  UIKit                               0x000000010fae1964 UIApplicationMain + 159
35  OneCoworking                        0x000000010a92d28f main + 111
36  libdyld.dylib                       0x000000011206868d start + 1
37  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
Objective C or Swift: Swift
iOS version: 9.3.5
Firebase SDK version: 3.10.0
FirebaseUI version: 1.0.0
CocoaPods Version: 1.1.1
This is the code implementation which causes the app to crash:
authUI!.providers = authConfiguration.signInProviders
return authUI!.authViewController()
Array of providers only has Facebook.

It looks like you've overwritten the default controller to expect a different nib which isn't provided by Firebase.
... with name 'One_Coworking.CustomFIRAuthPickerViewController'

I just noticed, makes sense. Thank you for pointing this out. I just don't understand how the application worked on Swift 2? Where there some drastic changes in the library?

Yeah, we've made a great deal of changes since then. This could be better documented IMO.

After pod update, I ran into this issue again.
As a workaround I've override
 - (instancetype)initWithNibName:(NSString *)nibNameOrNil
                         bundle:(NSBundle *)nibBundleOrNil
                         authUI:(FUIAuth *)authUI;

from Super "FUIAuthPickerViewController" into my own "CustomAuthPickerViewController" and hardcoded the @"FUIAuthPickerViewController" NibName.
@implementation CustomAuthPickerViewController
...

 - (instancetype)initWithNibName:(NSString *)nibNameOrNil
                         bundle:(NSBundle *)nibBundleOrNil
                         authUI:(FUIAuth *)authUI {

     self = [super initWithNibName:@"FUIAuthPickerViewController"
                           bundle:nibBundleOrNil
                           authUI:authUI];

    if (self) {
        self.title = @"Your Title";
     }

    return self;
}

...
@end

Ah, so it appears to be a bug, then.
The default implementation, uses NSStringFromClass([self class]), which I guess would return the subclass name rather than the superclass name.
I am unable to tell from the history if this was a recent change, however.
@wjuniorgit Thanks for the tip. I thought I tried that, but I don't think I was quite doing it right. I'm new to Swift and still getting used to the different syntax, but I'll try it again ASAP.

Ah, yeah, we should fix that.

For anyone interested, a temporary solution for Swift:
import UIKit
import FirebaseAuthUI

class AuthViewController: FUIAuthPickerViewController {

    override init(nibName: String?, bundle: Bundle?, authUI: FUIAuth) {
        super.init(nibName: "FUIAuthPickerViewController", bundle: bundle, authUI: authUI)
    }

    required init?(coder aDecoder: NSCoder) {
        super.init(coder: aDecoder)
    }

    override func viewDidLoad() {
        super.viewDidLoad()
    }

}

Why not to use next method?
- (FUIAuthPickerViewController *)authPickerViewControllerForAuthUI:(FUIAuth *)authUI {
  return [[FUICustomAuthPickerViewController alloc]
             initWithNibName:NSStringFromClass([FUIAuthPickerViewController class])
                      bundle:[NSBundle bundleForClass:[FUIAuthPickerViewController class]]
                      authUI:authUI];
}

I tried using a custom picker again after a while and I see that on selecting "Sign in with email" the navigation bar buttons (Cancel, Next) are still missing from the next screen. I mainly wanted to use a custom picker in order to use my own background image and remove the "Welcome" label on the main login screen only. Is there an easy way to do just these and leave the other functionality intact?

@yorgosg The "Sign in with email" screen is showing both the "Back" and "Next" buttons for me after subclassing FUIAuthPickerViewController using the code above.
In your version, is the navigation bar still showing (and the buttons are just missing)?

@cohenadair thanks a million. It turns out I was removing the navigation bar, because I think I had to on the previous implementation of FirebaseUI. It now all works.
Only one more thing: Is there a way to get rid of the "Welcome" label? I found a FirebaseAuthUI.strings file, where you can change "Welcome" to something else, but I don't know how to change its color or remove it altogether.
Thank you!!

@yorgosg Well normally, setting the view controller's title property in viewDidLoad would be enough, but that doesn't seem to work in this case -- I'm not exactly sure why.
What worked for me is setting the title in the init(nubName:bundle:authUI: method:
override init(nibName: String?, bundle: Bundle?, authUI: FUIAuth) {
    super.init(nibName: "FUIAuthPickerViewController", bundle: bundle, authUI: authUI)
    self.title = "My own title"
}

@cohenadair this worked! thanks!

@cohenadair I have another issue on using custom strings (I read your comment here: https://github.com/firebase/FirebaseUI-iOS/issues/125#issuecomment-268527162)
I've been trying to make my strings appear, but for some reason only the strings for the FirebaseAuthUI.strings are loaded correctly, so the one replacing the one on the "Sign in with email" button.
What I did is add the following four files into a FirebaseSignUp.bundle with different strings. The files in the bundle are (under a en.lproj folder):
FirebaseAuthUI.strings
FirebaseFacebookAuthUI.strings
FirebaseGoogleAuthUI.strings
FirebaseTwitterAuthUI.strings
In my code, when I want the sign up picker with my custom strings to be displayed, I do the following:
NSString *firebaseCustomStringsFilePath = [[NSBundle mainBundle] pathForResource:@"FirebaseSignUp"
ofType:@"bundle"];
authUI.customStringsBundle = [NSBundle bundleWithPath:firebaseCustomStringsFilePath];
and when I want the sign in picker to appear, I do the following:
authUI.customStringsBundle = [NSBundle mainBundle];
Any ideas?

@yorgosg Sorry, I am not able to get custom string resources to work, either. I would post a question on Stack Overflow if you haven't already.
As for the status bar, see this post if your ViewController is embedded in a UINavigationController, and this one if it is not.
If those don't work, posting another question on Stack Overflow will likely be beneficial.  If you have any other questions for me, feel free to email me (my email is in my profile), so we aren't cluttering this issue with off-topic discussion. :)

@yorgosg

regarding localizations: issue is confirmed: we can't override default translations. I'll update this ticket with time frame when this can be implemented.
you can set light content in the next way:
UINavigationController *controller = [self.authUI authViewController];
controller.navigationBar.barStyle = UIBarStyleBlack;
[self presentViewController:controller animated:YES completion:nil];

FWIW, using @cohenadair's approach, I was able to use a custom XIB alongside my custom view controller, like so:
[...]
super.init(nibName: "CustomAuthViewController", bundle: bundle, authUI: authUI)
[...]

It appears that the default FUIAuthViewController code is generating a nib name with the module prepended, e.g. my_target_module.CustomAuthViewController, which crashes vs. the working CustomAuthViewController.

@jwhitley please use next method for custom controllers:
  func authPickerViewController(forAuthUI authUI: FUIAuth) -> FUIAuthPickerViewController {
    return FUICustomAuthPickerViewController(nibName: "FUICustomAuthPickerViewController",
                                             bundle: Bundle.main,
                                             authUI: authUI)
  }

I don't understand why this is closed, sorry. I was able to repro it in the FirebaseUI-demo-swift project just by going to Auth -> Sign In.
Objective C or Swift: Swift
iOS version: 10.3.2
Firebase SDK version: 4.0.0
FirebaseUI version: master (commit 347e8173ff8b866a2e54e4a63eb1af4111e4edb0)
CocoaPods Version: 1.3.0.beta.1
Xcode version: 8.3.3
I've done the bare minimum to get the sample project to build, haven't touched any code as such.
2017-06-17 22:01:32.882647+0100 FirebaseUI-demo-swift[266:24020] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not load NIB in bundle: 'NSBundle </var/containers/Bundle/Application/09239D05-DF8E-42BD-BE6D-8DA54497C77F/FirebaseUI-demo-swift.app> (loaded)' with name 'FUIAuthPickerViewController''
*** First throw call stack:
(0x1deafb3d 0x1d137067 0x1deafa85 0x235aa7c7 0x23428eff 0x23207e6b 0x230daf63 0x230daea1 0x19bba7 0x1a0ccb 0x1a0c63 0x1a7e9f 0xe7638 0xe80d8 0x2310f785 0x2327a0ef 0x2310f785 0x2310f719 0x230f9d49 0x230f9e71 0x2310f055 0x2366133b 0x2365dc53 0x1de6b803 0x1de69a55 0x1de6a017 0x1ddbd1af 0x1ddbcfd1 0x1f567b41 0x2313ee13 0x114cf8 0x1d5aa4eb)
libc++abi.dylib: terminating with uncaught exception of type NSException

Hi have the same error
MantoApp[65711:1867445] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not load NIB in bundle: 'NSBundle </Users/luigimarino/Library/Developer/CoreSimulator/Devices/AB5267D2-F786-4420-BC6C-1D56B49BBA5B/data/Containers/Bundle/Application/4CEF2D6C-204C-4420-A991-797FA909F608/MantoApp.app> (loaded)' with name 'FUIAuthPickerViewController''

@eliotstock @freedoom1984 I can confirm issue.
It was fixed in Firebase-UI 4.1.1
Please re-open ticket next time if you have any issues.

@yorgosg Well normally, setting the view controller's title property in viewDidLoad would be enough, but that doesn't work in this case. FUIAuthPickerViewController sets the controller's title in init(nubName:bundle:authUI:), which is called after viewDidLoad, overriding the title you set.
Since when this issue is resolved there will be no need to override init(nubName:bundle:authUI:) method, the solution to change the title is to override viewWillAppear(animated:):
override func viewWillAppear(_ animated: Bool) {
    super.viewWillAppear(animated)
    self.title = ""
}

Mine doesn't work. Welcome label still there :( any thoughts?

how to disable the UIScrollView? when it scrolls it shows the white background and I am already setting it up as black and doesn't work.

https://www.youtube.com/watch?v=d_byFfP3cTw&feature=youtu.be solved


Add tenant filtering for templates in provisioning and summary pages

This PR adds tenant filtering for templates in provisioning and summary pages.
I added new named scope  applied_filtering which shows all templates in case if user is admin, in case if user in not admin only private images that belong to user's tenant and public images should
be shown.
https://bugzilla.redhat.com/show_bug.cgi?id=1524368
https://bugzilla.redhat.com/show_bug.cgi?id=1598520
https://bugzilla.redhat.com/show_bug.cgi?id=1546539
@aufi

@alexander-demichev isn't logic described in description covered by https://github.com/ManageIQ/manageiq/pull/17058 ? If not, it should be added in RBAC call (like you did in https://github.com/ManageIQ/manageiq/pull/17058 ) or in some mixin.
I think that when what to list templates (maybe some special type) we want to get same result, independently where we call it, especially when it depends on user.
Also I noticed that you are not asking for admin user you stated in description. (or is it accomplished by source_id condition ? )
@aufi

assuming that source_id attribute is not used for other purposes by other providers or core which I'm not sure
that's right.

so we need to get in to RBAC call:
Rbac.filtered(MiqTemplate or do you need it only for any special model Cloud:: ? )
and then we need to spec as well.
if you have any other questions, let me know !
thanks!

@lpichler I added new tests, can you review PR? :)

@lpichler Hi, can I get a review?

@miq-bot add_label blocker

@alexander-demichev if this can be backported, can you add the gaprindashvili/yes and the hammer/yes labels

@miq-bot assign @gtanzillo

@gtanzillo hi, can you merge/review?

Hammer backport details:
$ git log -1
commit 15058e549987cba58b342ba3d675719093212ffe
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Wed Oct 10 14:08:21 2018 -0400

    Merge pull request #17851 from alexander-demichev/named-scopes-templates

    Add tenant filtering for templates in provisioning and summary pages

    (cherry picked from commit 142a184d4619fd9d3ecebb6cff71ccd13667832e)

    https://bugzilla.redhat.com/show_bug.cgi?id=1524368

Gaprindashvili backport details:
$ git log -1
commit 119d2691ca63f5730e7f7cfa37b8b7c029e7fa2a
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Wed Oct 10 14:08:21 2018 -0400

    Merge pull request #17851 from alexander-demichev/named-scopes-templates

    Add tenant filtering for templates in provisioning and summary pages

    (cherry picked from commit 142a184d4619fd9d3ecebb6cff71ccd13667832e)

    https://bugzilla.redhat.com/show_bug.cgi?id=1623561

oops... wrong BZ in the git commit msg for G backport... The correct one is: https://bugzilla.redhat.com/show_bug.cgi?id=1598520


Small ameliorations

Hi!
First, I wanted to thank you for this great tool, that really did help me, and made me discover the multiprocessing lib, which I didn't know of, but surely will open many possibilities for future python tools and scripts I may write :D
This pr does two things:

Use list comprehension instead of for loops to populate arrays
Add a MIN_POSITIONS_NUMBER constant, which is the minimum number of position that can be used to create an android lock pattern (which is 3 in previous android versions, and is now 4), so that only patterns of minimum length of 3 are checked to save some time

Thank you!


Existing doc URL redirects

Setup redirects from all previous documentation resource URLs to the appropriate Sensu Docs Site URL.

https://github.com/sensu/website/pull/322 relates to this issue

Closed by https://github.com/sensu/website/pull/322


deck.gl Scatterplot Modifying the point size will cause the point rendering to fail

After I modify the point size here, the data format will be converted to a string, resulting in the scatter rendering failure. I think this may be a bug, and there is no unified format conversion for the data; I can render normally after converting the number type in the project

I also noticed if the last digit (min/max radius) is zero, then it doesn't render.

https://github.com/apache/superset/pull/24363


MM-26866/MM-26869 Fix a couple sidebar CSS colours

I also did some cleanup by using more -rgb CSS variables and removing some unused CSS rules.
Ticket Link
https://mattermost.atlassian.net/browse/MM-26866
https://mattermost.atlassian.net/browse/MM-26869

/cherry-pick release-5.27

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Fetching origin
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#6002-upstream-release-5.27-1597436470
Branch 'automated-cherry-pick-of-mattermost-webapp-#6002-upstream-release-5.27-1597436470' set up to track remote branch 'release-5.27' from 'upstream'.

+++ About to attempt cherry pick of PR #6002 with merge commit 3494e9d503684a9097e90a3e8057ac8832d1cea2.

+++ Conflicts detected:

UU sass/layout/_sidebar-left.scss

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.