RFC: ERC-20 Farm Balance Approval System and Permit Implementation

Abstract
Allows Farmers to delegate their ERC-20 farm balance to other contracts to call transfer on their behalf and add EIP-2612 support to ERC-20 farm balance.
Motivation
Currently, the only way to transfer ERC-20 farm balance is by calling transferToken() on the Farmer's account and there are no ways for farmers to delegate it to other contracts. Adding an approval system will allow other protocols to build on top of Beanstalk and use transformTokenFrom()
Adding permit implementation to ERC-20 farm balance will allow the Farmer's to delegate their farm balance to other contract in a single transaction which remove the need of submitting a separate transaction and reduce fiction when interacting with Beanstalk.
Specification
Event
event TokenApproval(address indexed owner, address indexed spender, IERC20 token, uint256 amount);

TokenFacet
function transferTokenFrom(
    IERC20 token,
    address sender,
    address recipient,
    uint256 amount,
    LibTransfer.From fromMode,
    LibTransfer.To toMode
) external payable;

function approveToken(
    address spender,
    IERC20 token,
    uint256 amount
) external payable;

function increaseTokenAllowance(
    address spender,
    IERC20 token,
    uint256 addedValue
) public virtual returns (bool);

function decreaseTokenAllowance(
    address spender,
    IERC20 token,
    uint256 subtractedValue
) public virtual nonReentrant returns (bool);

function tokenAllowance(
    address account,
    address spender,
    IERC20 token
) public view virtual returns (uint256);

 function permitToken(
    address owner,
    address spender,
    address token,
    uint256 value,
    uint256 deadline,
    uint8 v,
    bytes32 r,
    bytes32 s
) external payable;

function tokenPermitNonces(address owner)
        public
        view
        virtual
        returns (uint256);

function tokenPermitDomainSeparator() external view returns (bytes32);

LibTokenApprove
function approve(
        address account,
        address spender,
        IERC20 token,
        uint256 amount
    ) internal;

function allowance(
        address account,
        address spender,
        IERC20 token
    ) internal view returns (uint256);

function spendAllowance(
        address owner,
        address spender,
        IERC20 token,
        uint256 amount
    ) internal;

LibTokenPermit
bytes32 private constant TOKEN_PERMIT_HASHED_NAME = keccak256(bytes("Token"));
    bytes32 private constant TOKEN_PERMIT_HASHED_VERSION = keccak256(bytes("1"));
    bytes32 private constant TOKEN_PERMIT_EIP712_TYPE_HASH = keccak256("EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)");
    bytes32 private constant TOKEN_PERMIT_TYPEHASH = keccak256("Permit(address owner,address spender,address token,uint256 value,uint256 nonce,uint256 deadline)");

function permit(
        address owner,
        address spender,
        address token,
        uint256 value,
        uint256 deadline,
        uint8 v,
        bytes32 r,
        bytes32 s
    ) internal;

LibTransfer
function transferToken(
        IERC20 token,
        address sender,
        address recipient,
        uint256 amount,
        From fromMode,
        To toMode
    ) internal returns (uint256);

Execution

Add & modify functions on TokenFacet
Implement LibTokenPermit library
Implement LibTokenApprove library
Modify LibTransfer to use sender parameter instead of msg.sender
Write tests
Halborn audit
BIP-28

Added in BIP-29: https://github.com/BeanstalkFarms/Beanstalk/pull/87


Backup/Restore locally (optional)

I am planning to buy a home server but currently I am using apps with local backup/restore mechanism.
Might you add this feature, please?

Thanks for the suggestion! However, I don't think that it would be a very popular and useful feature for Mealient specifically. Mealient is intended to be only a Mealie client, not an independent recipe app. I am sure you can find a much more feature-rich app for your use-case :-)


FIX Dashboards not visible after bundle deployment and shutdown

Issue

This PR fixes:

#221
#245

@Abuelodelanada ready for merge? Still marked as draft. 😅


getting

sudo nprintml -a pcap --pcap_dir protocols/ -L labels.txt -4 -t -p 20
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/pkg_resources/init.py", line 568, in _build_master
ws.require(requires)
File "/usr/local/lib/python3.7/dist-packages/pkg_resources/init.py", line 886, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/local/lib/python3.7/dist-packages/pkg_resources/init.py", line 777, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (urllib3 1.24.1 (/usr/lib/python3/dist-packages), Requirement.parse('urllib3<1.27,>=1.25.4'), {'botocore'})
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/nprintml", line 33, in
sys.exit(load_entry_point('nprintml==1.0.3', 'console_scripts', 'nprintml')())
File "/usr/local/bin/nprintml", line 25, in importlib_load_entry_point
return next(matches).load()
File "/usr/local/lib/python3.7/dist-packages/importlib_metadata/init.py", line 194, in load
module = import_module(match.group('module'))
File "/usr/lib/python3.7/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "", line 728, in exec_module
File "", line 219, in _call_with_frames_removed
File "/usr/local/lib/python3.7/dist-packages/nprintml-1.0.3-py3.7.egg/nprintml/cli.py", line 21, in
import nprintml.learn.step
File "/usr/local/lib/python3.7/dist-packages/nprintml-1.0.3-py3.7.egg/nprintml/learn/init.py", line 1, in
from .automl import AutoML  # noqa: F401
File "/usr/local/lib/python3.7/dist-packages/nprintml-1.0.3-py3.7.egg/nprintml/learn/automl.py", line 13, in
import matplotlib.pyplot as plt
File "/usr/local/lib/python3.7/dist-packages/matplotlib-3.3.4-py3.7-linux-x86_64.egg/matplotlib/pyplot.py", line 43, in
from matplotlib.figure import Figure, figaspect
File "/usr/local/lib/python3.7/dist-packages/matplotlib-3.3.4-py3.7-linux-x86_64.egg/matplotlib/figure.py", line 18, in
from matplotlib import docstring, projections
File "/usr/local/lib/python3.7/dist-packages/matplotlib-3.3.4-py3.7-linux-x86_64.egg/matplotlib/projections/init.py", line 4, in
from mpl_toolkits.mplot3d import Axes3D
File "/usr/local/lib/python3.7/dist-packages/matplotlib-3.3.4-py3.7-linux-x86_64.egg/mpl_toolkits/init.py", line 1, in
import('pkg_resources').declare_namespace(name)
File "/usr/local/lib/python3.7/dist-packages/pkg_resources/init.py", line 3242, in
@_call_aside
File "/usr/local/lib/python3.7/dist-packages/pkg_resources/init.py", line 3226, in _call_aside
f(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pkg_resources/init.py", line 3255, in _initialize_master_working_set
working_set = WorkingSet._build_master()
File "/usr/local/lib/python3.7/dist-packages/pkg_resources/init.py", line 570, in _build_master
return cls._build_from_requirements(requires)
File "/usr/local/lib/python3.7/dist-packages/pkg_resources/init.py", line 583, in _build_from_requirements
dists = ws.resolve(reqs, Environment())
File "/usr/local/lib/python3.7/dist-packages/pkg_resources/init.py", line 772, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'urllib3<1.27,>=1.25.4' distribution was not found and is required by botocore

Hello @vinsesh – as best I can tell from your traceback it looks like nprintML wasn't installed correctly.

You've attempted to install the library globally on your system as root. That could work fine.
But, for whatever reason this left you with an old version of urllib3; a dependency of the library is a later version of urllib3.

You may install the library however is most useful to you. But, as I said, for whatever reason, this didn't work.
You might try simply:
python -m pip install --user nprintml

Or much better try installing into a virtualenv.
If you like, give pipx a shot, also as mentioned in the README. (I'm guessing this might be a user experience you'd like!)
Regardless, good luck!


Setting stream handler when using kotlin fails due to lack of nullability annotations

Steps to Reproduce
To reproduce the crash you only need to try to set a stream handler using kotlin in Android application:
        EventChannel(getFlutterView(), "ANY_CHANNEL").setStreamHandler(
                object : EventChannel.StreamHandler {
                    override fun onListen(arguments: Any, events: EventChannel.EventSink) {
                    }

                    override fun onCancel(arguments: Any) {
                    }
                }
        )

Logs
This call will cause a similar exception:
java.lang.IllegalArgumentException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter arguments
   at tomek.com.podcast.MainActivity$onCreate$2.onListen(Unknown Source:2)
   at io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:167)
   at io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:155)
   at io.flutter.view.FlutterView.handlePlatformMessage(FlutterView.java:690)
   at android.os.MessageQueue.nativePollOnce(Native Method)
   at android.os.MessageQueue.next(MessageQueue.java:325)
   at android.os.Looper.loop(Looper.java:142)
   at android.app.ActivityThread.main(ActivityThread.java:6541)
   at java.lang.reflect.Method.invoke(Native Method)
   at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Suggested solution
This issue is caused by lack of any nullability information in onListen:
// Code from io.flutter.plugin.common.EventChannel
    public interface StreamHandler {
        void onListen(Object var1, EventChannel.EventSink var2);

        void onCancel(Object var1);
    }

When a handler is created with kotlin that assumes that var1 in onListen is not nullable but it receives null, the mentioned exception happens.
Would it be possible to add a nullability information to StreamHandler so kotlin would by default create the following code?
         {
                    }
                }
        )

Here both arguments are of type Any?. Also, this solves my issue but other people using kotlin will for sure stumble upon this issue.
Thanks for the great work and amazing tool!

@tomaszpolanski Hi, Thank you for the suggestion. It seems to be resolved when I tried. Could you try again to see if it is fixed?

@cyanglaz Yes, I can confirm, this issue is no fixed

@cyanglaz Yes, I can confirm, this issue is no fixed

Im sorry. Is it fixed or not fixed? You mentioned it is not fixed but closed the issue, so I am a little confused.

@cyanglaz Sorry, there was a typo. The issue is now fixed


Show own bit emotes in emote menu

What should be added?
Noticed how your own bit emotes as an affiliate or partner, don't show up in the emote menu and as a result dont autocomplete either.
Why should it be added?
Just a bit annoying that you can't autocomplete them, hence why i put it as a low priority suggestion and not an actual issue with chatterino.
Maybe i'm just danking up and there's some setting in chatterino that enables this but as far as i know that doesnt exist FDM

Duplicate of #1450


Call for maintainers

Opening this issue to invite people as maintainers of this module. I'm using this module in production in  one of my apps but i'm not actively maintaining that app anymore. Also due to various reasons, I'm not able to put in enough time into this module.
If you are using this module or want to contribute, please leave a comment here.
cc @lunarraid @superandrew213

I'd be happy to maintain this

great! thanks for jumping in @philwilks. I will add you ad a collaborator. I would suggest sending/reviewing/merging some PRs before making substantial changes.


added update and service types

What changed, and why it matters
Added service types and service update commands

Fixes #256 and #255


Scenario Runner Status issue

Hey i think there is a bug in displaying scenario status loading and running.
To Reproduce
Steps to reproduce the behavior:

Run roslaunch carla_ad_demo carla_ad_demo_with_scenario_runner.launch
Click on Execute Follow Leading Vehicle Scenario
See Status indicator doesnt switch to running (green) while scenario still executes correctly

OS: [e.g. Ubuntu 20.4]
CARLA Version [CARLA 0.9.12]
scenario_runner Version [v0.9.12]

Adding @fpasch as he is a better help for ROS related interfaces


Feat/biconomy modular smart account

Add methods to use Biconomy Smart Account which uses ECDSA module as default validation module.

I have fixed some linting issues in utils and in one of the kernel files.

tests


Fix HeadVersions

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Fixes #531

This is a quick fix for the bug.
cc @xu-cheng @DomT4

I think, this is a better way to fix it.
diff --git a/Library/Homebrew/build.rb b/Library/Homebrew/build.rb
index 8915e94..f7a4543 100644
--- a/Library/Homebrew/build.rb
+++ b/Library/Homebrew/build.rb
@@ -127,6 +127,7 @@ class Build
         interactive_shell(formula)
       else
         formula.prefix.mkpath
+        formula.head.lock_version! if formula.head

         formula.install

diff --git a/Library/Homebrew/software_spec.rb b/Library/Homebrew/software_spec.rb
index b16a33c..0a6c848 100644
--- a/Library/Homebrew/software_spec.rb
+++ b/Library/Homebrew/software_spec.rb
@@ -53,7 +53,7 @@ class SoftwareSpec
     @resource.owner = self
     resources.each_value do |r|
       r.owner     = self
-      r.version ||= version.dup
+      r.version ||= version
     end
     patches.each { |p| p.owner = self }
   end
@@ -207,6 +207,10 @@ class HeadSoftwareSpec < SoftwareSpec
     @resource.version = Version.create("HEAD")
   end

+  def lock_version!
+    version.lock!
+  end
+
   def verify_download_integrity(_fn)
     nil
   end
diff --git a/Library/Homebrew/version.rb b/Library/Homebrew/version.rb
index 002bd53..cadd2c2 100644
--- a/Library/Homebrew/version.rb
+++ b/Library/Homebrew/version.rb
@@ -401,7 +401,12 @@ class HeadVersion < Version
     @commit = @version[/^HEAD-(.+)$/, 1]
   end

+  def lock!
+    @locked = true
+  end
+
   def update_commit(commit)
+    return if @locked
     @commit = commit
     @version = if commit
       "HEAD-#{commit}"

I think the current fix in this PR makes more sense (in my opinion), as I believe every resource should have an independent Version instance and they shouldn't be influencing each other.
If this already fixes the issue (and doesn't introduce any new issues we're aware of), let's merge this now and discuss a possible refinement of the fix in a separate PR (where we have more time).

Thanks @xu-cheng @UniqMartin and @DomT4 ! And sorry for the bug. 😕

Thanks for fixing this so quickly, @vladshablinsky!

This was an impressively quick PR; there's not that many in Homebrew I don't at least see before they get merged 😄. Looks good locally. Thank you @vladshablinsky! Appreciate the quick fix.


update core to 5.23.5 and sync to 4.7.8

HaHa - yeah not too surprised I did a lot wrong here :-) Feel free to just pick the core version and changelog entries then in another commit if that's easiest.


chore: jx-k8s-days-go-01 to 0.0.2

chore: Promote jx-k8s-days-go-01 to version 0.0.2

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


accept exclamation point instead of 'NOT' --- WIP

since pushing, i've experimented more with mysql and i think i need to tweak this some.
not and ! bind differently:
 mysql> select !1 + 1;  // 1
 mysql> select not 1 + 1; // 0

(some changes from running gofmt)

@acharis You have to specify a precedence for ! here: https://github.com/youtube/vitess/blob/master/go/vt/sqlparser/sql.y#L85, as defined by https://dev.mysql.com/doc/refman/5.7/en/operator-precedence.html. Note that the order is reversed for yacc.

@sougou please see https://github.com/HubSpot/vitess/blob/not-exclamation/go/vt/sqlparser/sql.y#L907  which is current rev

@sougou and thanks for taking a look. i'm still working on this, so i'll ping you when it's ready for review. i'm going to add some more features in over the next few days to cut down on PRs

ok, i just added support for the BINARY operator to this PR

@sougou I think I've just about wrapped up dev on this branch. Other things I'll work on belong in another PR. If you could take a look, that would be appreciated. The travis failure seems unrelated, and I can't repro locally.


Add support for third party data in the spec

Fixes: #60
Signed-off-by: Andrea Frittoli<EMAIL_ADDRESS>

I would prefer if we called it "customContent" instead of "data".
I believe that the intention is to provide a placeholder for any custom data that we in the spec call "content". This customContent could either be used for testing new content parameters in the protocol before proposing them to become standardized content parameters, or it could be used really as custom parameters for data that is not intended to be included in the procotol but rather remain specific to a certain use case.

I would prefer if we called it "customContent" instead of "data".
I believe that the intention is to provide a placeholder for any custom data that we in the spec call "content".

My intention is to provide a placeholder for any data that the sender would like to put in there.
It could be used to transport a non-CDEvent content over a CDEvent channel, if the content is associated with the CDEvent message type.

This customContent could either be used for testing new content parameters in the protocol before proposing them to become standardized content parameters, or it could be used really as custom parameters for data that is not intended to be included in the procotol but rather remain specific to a certain use case.

Yes, definitely fields that are not yet in the spec could be transported via this field, until a standard name is specified for them. This is what I intend to do for a POC I'm working on, because not all required fields are in the spec yet.
I receive a webhook from Gitea, and covert it to a CDEvent. I plan to use this new field to host the entire original message from Gitea, so that the receiver may consume content from there.

Fixed linter issues.

I would prefer if we called it "customContent" instead of "data".

I have a preference for short and simple names, and I don't mind to convey the idea that CDEvents can be used as an envelop to transport extra data too. But customContent would work too.

I believe it is good to prefix the field with "custom", so that it is clear that the data put in there is not standardized by the protocol.

I believe that the intention is to provide a placeholder for any custom data that we in the spec call "content".

My intention is to provide a placeholder for any data that the sender would like to put in there. It could be used to transport a non-CDEvent content over a CDEvent channel, if the content is associated with the CDEvent message type.

Well, I'm not sure about that "CDEvents channel". What would that mean? To me it is still a "CloudEvents channel".
And I believe that, in accordance with our current structure, the parameters that identifies the subject for each event type lies on top level of the subject object, and any additional data is in the "contents" sub object in there. Therefore, I don't think it makes sense to add any custom data to the top level of the subject, but only to the contents sub object. Or? Would it still be a valid CDEvent that any consumer can understand if there are additional top level subject identity parameters? Anyway, I might miss some use case there, so adding the custom data on top level of the event would work for me as well.
If we keep this custom data on the top level I'd prefer if we call it "customData". If we declare it under the subject, on same level as "content" I'd prefer if it was called "customContent".
I don't really like the term "third-party" in this case. Third-party to whom? Probably not to the producer of the event. It is just that the service/system that the producer is executing or monitoring contains more info than what the spec declares, so from the producer's perspective it is rather "additional data" instead of "third-party data".

I would prefer if we called it "customContent" instead of "data".

I have a preference for short and simple names, and I don't mind to convey the idea that CDEvents can be used as an envelop to transport extra data too. But customContent would work too.

I believe it is good to prefix the field with "custom", so that it is clear that the data put in there is not standardized by the protocol.

I believe that the intention is to provide a placeholder for any custom data that we in the spec call "content".

My intention is to provide a placeholder for any data that the sender would like to put in there. It could be used to transport a non-CDEvent content over a CDEvent channel, if the content is associated with the CDEvent message type.

Well, I'm not sure about that "CDEvents channel". What would that mean? To me it is still a "CloudEvents channel".
And I believe that, in accordance with our current structure, the parameters that identifies the subject for each event type lies on top level of the subject object, and any additional data is in the "contents" sub object in there. Therefore, I don't think it makes sense to add any custom data to the top level of the subject, but only to the contents sub object. Or? Would it still be a valid CDEvent that any consumer can understand if there are additional top level subject identity parameters? Anyway, I might miss some use case there, so adding the custom data on top level of the event would work for me as well.

Yeah, the proposal is to add it top level, since the data may not be specific to the subject only.
I believe it matches what we discussed in the WG.

If we keep this custom data on the top level I'd prefer if we call it "customData". If we declare it under the subject, on same level as "content" I'd prefer if it was called "customContent".

customData sounds good, I will update the PR

I don't really like the term "third-party" in this case. Third-party to whom? Probably not to the producer of the event. It is just that the service/system that the producer is executing or monitoring contains more info than what the spec declares, so from the producer's perspective it is rather "additional data" instead of "third-party data".

Yeah, third-party is a terrible choice of name, I will change it to additional data, thank you for the suggestion.


Hacks and Known Issues

Purpose

[Hopefully] temporary workarounds and known issues for workspace infrastructure
Hacks
Known issues

Setuptools deprecation warning when building Python packages

 UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead
https://answers.ros.org/question/396439/setuptoolsdeprecationwarning-setuppy-install-is-deprecated-use-build-and-pip-and-other-standards-based-tools/?answer=400052#post-id-400052

#78
GitHub Container Registry Packages lists the architecture unknown/unknown when manifest attestations are present: https://github.com/orgs/community/discussions/45969

Setuptools deprecation warning resolved in #130
GCR unknown/unknown architecture not important and not fixable by us


Move ansible proxy outside of the ansible package

The ansible proxy is currently being used by both the ansible-operator and the scorecard. Since it is not exclusively used by ansible anymore, the proxy should be moved to a different location.

/remove-lifecycle stale


Fix this.translations === null in translate function

I encountered this === null type error in one of the service.
TypeError: Cannot read property 'app.title' of undefined\n    at I18n.translate (/home/udocker/safety-lens/node_modules/fusion-plugin-i18n/src/node.js:47:28

This happens in SSR
The app was migrated from bedrock and don't know if my config messed it up but wanted to prevent this from happening even with the wrong config
This happens when we don't provide any other language translations other than English and users set browser locale to different languages.
I was expecting it to fallback to English automatically but it seems it's not the case.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I don't know if this is specific to Spanish locale but this is how it looks on the computer that exhibit this error.

closing it because I confirmed that my app config was wrong


See related movies or tvshows of one media

I have a suggestion based on this use case:
Eventually, when I search for something, we should add in the "search" tab, the suggestion based on the library and based on the search. (on the right side of the search form input ?)
Ex. :
Search : Homeland
Suggestion : You may also like ==> Jack Ryan, etc...

When you have an empty library, this looks pretty weird. I think we should split into two pages:

discover -> the feature you added
suggestions -> based on what you have in library

And maybe in the long term merge them back into subpages of the search.
This will simplify the usage not everything at the same place and we can edit the subtitle of the page to understand more what to do on this page, I'll let you find something cool :)
Otherwise, this is really awesome and pretty good feature :+1:
Originally posted by @iam4x in https://github.com/iam4x/bobarr/pull/82#issuecomment-616753039

Hi @mune360, what do you think of having related movies/tvshows in the details of movie? (related to #86)
I think it will make more sense here than when you are searching.

Excellent.


Disconnect old egress VPCs

As the old egress VPCs are no longer required, the first step in removing them is disconnecting them from the Modernisation Platform transit gateway.
This PR also updates the Name tags of the attachments to the new egress VPCs so that they match the previous syntax, and are monitored by our CloudWatch alarms.

Keeping them vars tidy. LGTM.


Delete Global Variable in NLP_TO_NETWORK.py

Which probably led to memory error.

@Ruobing Do you want this in the next AWS push?

@rsteed11 I think we should push it to AWS today, since it is a fundamental problem

@Robin888 In that case, let me know when you've merged to master and I'll deploy

@rsteed11 No problem. I will close this merge request and merge it to master branch


Add build arg FRAMEWORK to dockerfile to allow pytorch dockerfile

fixed the syntax issue and moved this to https://github.com/mlcommons/algorithmic-efficiency/pull/417 along with interim external containerized tests [in progress].


SR300 Camera could not be found and driver installation fails

Required Info

Camera Model
SR300

Firmware Version
I can't click info because no camera was detected

Operating System & Version
Win 10

Platform
PC

SDK Version
2.9.1

Issue Description
No camera is displayed in the Realsense Viewer and in the device manager there is no driver installed. But the cameras are named correctly. If I start Skype for example, the cameras are found and I can see an image. But in the Realsense viewer I see nothing. I tried to update the device drivers, but it gives me an error. Here is the event:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
<System>
  <Provider Name="Microsoft-Windows-UserPnp" Guid="{96F4A050-7E31-453C-88BE-9634F4E02139}" />
  <EventID>20001</EventID>
  <Version>0</Version>
  <Level>4</Level>
  <Task>7005</Task>
  <Opcode>0</Opcode>
  <Keywords>0x8000000000000000</Keywords>
  <TimeCreated SystemTime="2018-01-30T10:00:57.420874000Z" />
  <EventRecordID>1291</EventRecordID>
  <Correlation />
  <Execution ProcessID="16664" ThreadID="27600" />
  <Channel>System</Channel>
  <Computer>DESKTOP-PSOS7V2</Computer>
  <Security UserID="S-1-5-18" />
  </System>
<UserData>
<InstallDeviceID xmlns="http://manifests.microsoft.com/win/2004/08/windows/userpnp">
  <DriverName>realsensesr300depth.inf_amd64_c0b85d3599a4f443\realsensesr300depth.inf</DriverName>
  <DriverVersion><IP_ADDRESS>18</DriverVersion>
  <DriverProvider>Intel(R) Corporation</DriverProvider>
  <DeviceInstanceID>USB\VID_8086&PID_0AA5&MI_02\6&2BE25EA&0&0002</DeviceInstanceID>
  <SetupClass>{6BDD1FC6-810F-11D0-BEC7-08002BE2092F}</SetupClass>
  <RebootOption>false</RebootOption>
  <UpgradeDevice>true</UpgradeDevice>
  <IsDriverOEM>true</IsDriverOEM>
  <InstallStatus>0x643</InstallStatus>
  <DriverDescription>Intel(R) RealSense(TM) Camera SR300 Depth</DriverDescription>
  </InstallDeviceID>
  </UserData>
</Event>

Unfortunately it did not work for me ...
I have a Realsense 400 camera here, they is working without problems, but my SR300 doesnt show up correctly in the device manager.
Please help me, because it is urgent for us to make it working!

Hi @mirhec ,
The issues you are describing sounds like driver related issues. Can you please tell us:

The exact windows version you are using (WinKey + R (run) --> winver --> Alt+PrtScn (takes a screenshot of that window - or use snippingtool) --> Ctrl+V on Github)
Is DCM installed? Open Programs and Features ( WinKey + R--> appwiz.cpl) and check if you see Intel RealSense Depth Camera Manager SR300, if so- which versions? (Since you have the SR300 Virtual Driver` I assume you have this installed)
What is the version of the Depth, and RGB drivers (in Device Manager)

Here are the required information:
1. The exact windows version you are using (WinKey + R (run) --> winver --> Alt+PrtScn (takes a screenshot of that window - or use snippingtool) --> Ctrl+V on Github)

2. Is DCM installed? Open Programs and Features (WinKey + R--> appwiz.cpl) and check if you see Intel RealSense Depth Camera Manager SR300, if so- which versions? (Since you have the SR300 Virtual Driver I assume you have this installed)
DCM is not installed, I only have installed the Intel RealSense SDK 2.0 version 2.9.1. The problem is that I can't install DCM ... it tries to install:

But after a while the following error occurs:

3. What is the version of the Depth, and RGB drivers (in Device Manager)
The only device I see when I connect a SR300 is the USB device and the depth camera:

The drivers are not really installed, if I click on details it states me I need to install the drivers:

4. In Skype - when you choose the Depth camera, do you see a green screen?
No in Skype I don't see the Depth camera, but only the RGB camera:

I just noticed that your comment regarding seeing 3 devices in the device manager refers to another laptop. So this is indeed a driver issue, There is a post online referring to how to uninstall the driver and reinstalling it (which should be performed automatically via Windows Update), I will look it up for you and post again

Before trying the suggestions in that post, please note that you do not need DCM (Depth Camera Service) installed, RealSense SDK 2.0 works without it, and in fact it is preferred if DCM is absent.
In general what you should do is disconnect the camera, uninstall and completely remove the SR300 driver, and then connect the camera and reinstall the driver (hopefully Windows Update should take care of that by itself).
I've found this guide which might help the issue (https://communities.intel.com/thread/113973), please take extra precaution as some of the actions there are advanced.

I can't say why and how, but I managed it to work again. I tried to follow this description you posted, but at first it doesn't seem to work. At some time the camera was listed under "System devices" and I uninstalled it from this location, reconnected it and voila - it worked!
Thank you for your help! I'll close this issue.

I managed to install the driver by:

deinstalling the driver
shutting down Windows (important: not restarting)
turning on Windows
installing the driver

Maybe that helps you. But ideally, this should get fixed by Intel.

Made a account just to say "thank you", this worked for me. Sooo... thank you (y)


hyperscan: 5.0.0 -> 5.1.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/hyperscan/versions.
meta.description for hyperscan is: '"High-performance multiple regex matching library"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 5.1.0 with grep in /nix/store/61zrpw8ndkc9fasmyr4x684ybxrgppcy-hyperscan-5.1.0

directory tree listing: https://gist.github.com/7fa0c2c814038b3c1edb5714be143b3a

du listing: https://gist.github.com/f3082f0d415b17355195450ff85e42aa

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
hyperscan
rspamd

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/61zrpw8ndkc9fasmyr4x684ybxrgppcy-hyperscan-5.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A hyperscan https://github.com/r-ryantm/nixpkgs/archive/2b1bc3080cbfb768614298658c464090f61a19bd.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/61zrpw8ndkc9fasmyr4x684ybxrgppcy-hyperscan-5.1.0
ls -la /nix/store/61zrpw8ndkc9fasmyr4x684ybxrgppcy-hyperscan-5.1.0/bin

cc @avnik for testing.

@grahamcofborg build hyperscan rspamd

Darwin failure is not new. built on x86_64-linux locally.


Can't view new spells after spell inventory is full

Hello,
I have recently installed this plugin on my survival server and I have noticed that when my spell inventory became full, I couldn't add more spells. This is weird since there are way more spells that can be bought. I am playing in 1.13.1, which might be the source of the problem because this plugin may not be meant for this version (?). Anyways, I tried switching to "Chest Mode" and more but nothing worked. Could this issue please be fixed ASAP because it kinda very much ruins the entire gameplay.
Thanks.

Oh my god I'm so sorry I just figured out that you can change pages. I thought this worked with wool blocks in the past (could be my memory) but if it didn't, I'd like to request that it is implemented. This way of navigation is very confusing, especially because I did not see a clear list of controls anywhere. You might want to make this.
Anyhow, love your plugin. I also got another issue but I will make a new issue for that.

Never used wool blocks here, probably won’t add it in the future but if you’d like to edit the title of this issue to request it I’ll leave it open.
You should get a message in chat explaining the controls the first time you get more than one page of spells, but I understand that may be easy to miss.


Snapdragon/RPi: add preflight checks back in

Preflight checks are currently disabled for Snapdragon and Raspberry Pi but we need to add them back in and test it.

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)

@bkueng were the checks ever put back in?

No, not to my knowledge

We might as well try...

@RomanBapst this might be something you want to fix:
https://github.com/PX4/Firmware/blob/b03cfd9afad56db99bb8d4681d5be5a1ce2207d3/src/modules/commander/PreflightCheck.cpp#L692-L696

Done


 Syntax error expecting %s or %s. --> Syntax error expecting %s, %s, %s, %s, or %s.

Also, single words like "Examine" are translated with a full phrase with more than 10 words.

I thought that pre-translate:
a) Could infer that when "Syntax error" is translated as "abc_Syntax error" in 90% of times in phrases will be "replaced" as "abc_Syntax" and not with something else.
b) replace only words and not arguments.
c) it says that pre-translated 650 lines but actually only 20 lines were pretranslated and almost all with wrong arguments, words.
If you like, i will provide you with the pspp.po file that i try to translate to greek.
It will best if poedit can create a dictionary of words and phrases that can be edited from the user. Using that, people can speed translation very much by exchanging / merging dictionaries eg. on statistics. I wonder why this has not implemented yet.
Can "Argos translate" be supported as an external translator? how?

This is the open source version bug tracker. If you complain about machine translation in pre-translation, that is Pro feature and this is not the appropriate forum for support.
Poedit does correctly handle placeholders if your file correctly identifies them.
Please see http://www.chiark.greenend.org.uk/~sgtatham/bugs.html on how to describe issues in a way that other people can reproduce and understand. I'm afraid I can't make much sense of anything in this.


Add #312 Read or Update organisation admin avatar image

@albinpa Can you resolve the merge conflicts ?

Done


Ask some details of training

Thanks for your job. I'm trying to use your classification model to training the Mobilenet-SSD. The training is only on the VOC07/12 dataset(without pre-training on the COCO), but it seems so hard to get a high mAP as yours(0.68). Would you share some details about it, i.e solver parameter like (base_lr, lr_policy, max_iter) . Or there is some difference with your pre-trained model's deploy.prototxt, i.e. parameter like(lr_mult=0.1, decay_mult=0.1 for depthwise separable convolution).  Or  frozen some layer at initial stage? Thanks very much~~

@issac8huxley Frozen the base network weights at the first 5000 iterations, then use a smaller lr_mult at the lower layers (e.g. 0.01 for conv1, 0.1 for conv5, 1 for conv10). And finally , use the same lr_mult for all layers.

Thanks. Do you means the training is implement with three stage? First stage, frozen base network and enable lr_mult(1?) for add layer; Second stage, setting smaller lr_mult for lower layers; Third stage, use same lr_mult(1 or 0.1?) for all layers. So, how many iterations will be needed for each stage? Would you share your solver.prototxt ?

@chuanqi305 Thank you very much for your work. I recently used your method to train mobile-ssd. The data set is only voc0712 and no pre-training model is used. But the training result is very bad. The tested map is only 0.21, but you say that map=0.68 is relatively easy, can you provide some parameter settings for training (some tricks)
And you said above "Frozen the base network weights at the first 5000 iterations, then use a smaller lr_mult at the lower layers (eg 0.01 for conv1 , 0.1 for conv5, 1 for conv10). And finally, use the same lr_mult for all layers." Is it fine-tuned on the mobilenet model? If yes, can this setting achieve a map above 0.6?


feat: add response shape feature, update docs

Per discussion on Discord, this feature allows users to extract response types from a given Contract. This is particularly useful for backend services where you want to avoid implementing an interface.
I aimed to make this as non-intrusive as possible! All tests pass. Please read the modified Docs to get a feel for the changes/additions, and then you can look at client.ts to see the entry point of the implementation.
Here's a screenshot of how it works:

@michaelangrivera Hey just popping in for a bit of visibility, I've been celebrating the holidays the last few days, I will take a loom tomorrow, but at first glance, this looks great!

This looks pretty good! I'm not sure about the Nest part of it (see https://github.com/ts-rest/ts-rest/pull/114#discussion_r1058728842), but the generic implementation in @ts-rest/core could be pretty useful for other frameworks/backends other than the supported ones.

Codecov Report

Merging #114 (a53a384) into main (f27a68b) will decrease coverage by 0.39%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   83.33%   82.94%   -0.40%
==========================================
  Files           9        9
  Lines         168      170       +2
  Branches       38       38
==========================================
+ Hits          140      141       +1
- Misses         18       19       +1
  Partials       10       10

Impacted Files
Coverage Δ

libs/ts-rest/core/src/lib/client.ts
80.00% <50.00%> (-1.40%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


RUMM-2492: Check if WorkManager is initialized before using it

What does this PR do?
This PR adds a check to see if WorkManager is initialized before using it, because WorkManager.getInstance will throw IllegalStateException if WorkManager is not initialized and this add the noise to our telemetry.
Unfortunately, there is no WorkManager#isInitialized method yet (it will be added only in WorkManager 2.8, which is still in alpha), so had to write a hacky workaround.
Another option would be to check if we are in the main process before accessing WorkManager, but this won't work because:

with work-multiprocess artifact execution/initialization of WorkManager may be shifted to any process
User may do a custom initialization which happens after we are calling WorkManager.

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1042 (8696ce8) into release/1.14.0 (b0a810b) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           release/1.14.0    #1042      +/-   ##
==================================================
- Coverage           83.19%   83.12%   -0.07%
==================================================
  Files                 272      272
  Lines                9268     9276       +8
  Branches             1490     1493       +3
==================================================
  Hits                 7710     7710
- Misses               1153     1155       +2
- Partials              405      411       +6

Impacted Files
Coverage Δ

...ore/internal/lifecycle/ProcessLifecycleCallback.kt
84.62% <100.00%> (+11.89%)
:arrow_up:

...og/android/core/internal/utils/WorkManagerUtils.kt
100.00% <100.00%> (ø)

.../android/error/internal/DatadogExceptionHandler.kt
90.91% <100.00%> (+0.28%)
:arrow_up:

...ndroid/core/internal/persistence/file/EventMeta.kt
80.00% <0.00%> (-10.00%)
:arrow_down:

...ain/java/com/datadog/opentracing/PendingTrace.java
58.62% <0.00%> (-1.72%)
:arrow_down:

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
87.50% <0.00%> (-1.63%)
:arrow_down:

.../android/rum/internal/monitor/DatadogRumMonitor.kt
92.86% <0.00%> (-0.60%)
:arrow_down:

...rc/main/java/com/datadog/opentracing/DDTracer.java
56.07% <0.00%> (-0.42%)
:arrow_down:


mesa: fix darwin build

Motivation for this change
try to fix https://hydra.nixos.org/build/144746161/nixlog/1
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build mesa

this is a channel blocker for darwin-tested

Anyway, this seems intended usage by upstream.


[RFC]: add @stdlib/array/base/cuevery-by

Description
This RFC proposes adding the package @stdlib/array/base/cuevery-by, which cumulatively tests whether every array element in a provided array passes a test implemented by a predicate function. The function should return a new generic array. The package should also provide an #assign API for setting output values in a provided output array.
function isPositive( value ) {
	return ( value > 0 );
}

var x = [ 1, 1, 1, 0, 1 ];

var y1 = cueveryBy( x, isPositive );
// returns [ true, true, true, false, false ]

var y2 = [ false, null, false, null, false, null, false, null, false, null ];
var out = cueveryBy.assign( x, y2, 2, 0, isPositive );
// returns [ true, null, true, null, true, null, false, null, false, null ]

var bool = ( out === y2 );
// returns true

where the assign API supports an offset and stride (see, e.g., @stdlib/array/base/take).
Both APIs should support accessor arrays (see, e.g., @stdlib/array/base/take).
Related Issues
No.
Questions
No.
Other

See also @stdlib/array/base/every-by

Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

@kgryte May I work on this!?

I love to work on this  Please #assign it to me

@kgryte please assign this issue to me.


Improved readme: works on (at least some) linux distributions, too :heart_eyes:

README.md says right now:

It works on macOS(arm64/x86) and windows(x64) now, idealy linux should works but I don't have a linux machine to test it. Check out examples, cd in and go run ..

Just did with some latest Arch Linux/KDE distribution, worked fine out of the box... will checkout on Pop! OS/Gnome in the upcoming few days, too... gonna comment that here, too.
Thank you all for your work regarding imgui+golang... really appreciate all that effort... makes my "learning Go while fiddling with some cross-platform UI" really, really fun and enjoyable :heart:

I confirm - works on Fedora Workstation 36
/etc/os-release
NAME="Fedora Linux"
VERSION="36 (Workstation Edition)"
ID=fedora
VERSION_ID=36
VERSION_CODENAME=""
PLATFORM_ID="platform:f36"
PRETTY_NAME="Fedora Linux 36 (Workstation Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:36"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f36/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=36
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=36
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation

(libraries installed just like for giu)

Thanks guys! README is updated.


Image previews on mobile

Size covers the title/subtitle

Removed the photos on the preview. I think that ends this.


Add portray_clause/1

It's in the format.pl example but not the actual implementation it seems

Scryer Prolog provides it in library(format): https://github.com/mthom/scryer-prolog/blob/4ee6a7bfb828474cbcab51695f24b120b1e35314/src/lib/format.pl#L508
As building block, I suggest the nonterminal portray_clause_//1.


Update logging.h

line 1330, changing "nullptr" to "NULL", for low version compilier compatibility

I signed it!


Cannot register

App fails when you try to register at http://cypress.zareismail.com/?ref=laravelnews

Thank you for your report.


Show a Toast when a new host app starts using a non-stable runtime

Not sure what sort of toast features are available. There's probably a third party WPF nuget package we could get? Using mojo named pipe enumeration (without looking up the corresponding browser process) it is fast enough we can run every few seconds to check for new host apps and then check if its runtime path isn't stable.

Just searching on github for wpf toast to find popular WPF Toast libraries with nuget packages: https://github.com/Federerer/Notifications.Wpf

Looking for mojo named pipes means we only find apps successfully using WebView2. Instead, if we just enumerate running processes and filter to those that have overrides, then we can give better warnings for cases where the override is messed up.

Curious what the intent is here. Are we looking for apps to be able to confirm that the override setting worked?

Its for the previous times when I've set an override to debug or whatever, finished and never removed the override. Then later on I'm getting unexpected behavior from that app because I forgot the override was still applied.
The thing that's happened to me multiple times: if you pick a runtime path and pick canary for the override (rather than using the reverse runtime lookup order you explicitly pick canary as the runtime path to use) then when you stop using the app the next day canary will get updated to a new version but the override will be using the old path with the old version number in the path that no longer exists and now webview2 won't launch with that override. And I forget that the override exists and it takes me a bit to figure out why WebView2 launch is failing. I had opened a separate issue in here to try and point out to the end dev that an override has a bad path.
Do you think its too niche or too annoying for the success case?

Sounds useful, though relies on the dev opening the utilities to be able to diagnose. I wish we could point to the canary location rather than a specific version subfolder. I thought we had a scenario for that somewhere but I can't find it.

Also would be nice to include easy way to file bug from the toast or toast links to wv2util tab that has info on filing bugs.
Potentially better toast library described here:
https://learn.microsoft.com/en-us/windows/apps/design/shell/tiles-and-notifications/send-local-toast?tabs=uwp2


Default property name not working

The default property name is not working when setting it after parsing a string.

ThanksRicardo, great work ;)


Homebridge -zp

Issue

Sonos icon appears under HB accessories and from there turns on/off Sonos
Home App shows “Sonos Beam” Orange House icon but says not supported? - And has not functions
Another greyed out Beam button appears in the same room and says not playing (when it is). Opening
This greyed icon shows greyed out play and FFWD/RWD arrows but again do not function.
All other Sonos products in other rooms have been identified in the same way but zero functionality.
I have just used as is and not modified the Config.json ?  Do I need to add/modify this from the standard one?
Node.js Version. = 18.12.1
I have upgraded to 16.2 and new Home architecture but it didnt work before that so gave up.
Thanks for any guidance
Log Messages

Debug Files

Sonos icon appears under HB accessories and from there turns on/off Sonos

I've never seen a Sonos icon in HomeKit.  Do you mean a speaker icon?  Is this the Airplay 2 icon provided by the Sonos speaker itself?

Home App shows “Sonos Beam” Orange House icon but says not supported?

Did you check another HomeKit app?  What's the config.json setting for service?  Please check the READ_ME before setting this to "speaker".

You need to read the README:

Selecting "speaker" results in a not supported accessory in Apple's Home app.

Thanks, Whilst fairly IT literate (ran a small business for 25 years) I am not a programmer and JSON has passed me by…
I have tried to Read the README but I am not understanding because its written as it you know this stuff, sorry I’m a novice. I have successfully integrated many other eco systems but often just need a pointer not an assumption I know the syntax of Json.
So what should it be set to? The install sets speaker to “true” ?
Also do I need the rest of your config.schema.json? embedded….
Thanks
Mark
From: Erik Baauw @.>
Reply to: ebaauw/homebridge-zp @.>
Date: Wednesday, 21 December 2022 at 17:45
To: ebaauw/homebridge-zp @.>
Cc: Hide My Email @.>
Subject: Re: [ebaauw/homebridge-zp] Homebridge -zp (Issue #201)
You need to read the README:
Selecting "speaker" results in a not supported accessory in Apple's Home app.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

just need a pointer not an assumption I know the syntax of Json.

https://www.json.org/json-en.html
But it's probably easier to use the Homerbidge UI.


[sdl2-gfx] Fix build error on non windows

windows.h is only needed on Windows platform.
So I updated it only when WIN32, the related definitions could be added.
Other changes:

Remove include(vcpkg_common_functions)
Add unsupported messages
Update copyright
Add Supports: widows field to CONTROL file

Related issue #10570
Note: No features need to test.

Needs to wait to resolve the osg-qt regression in #10637.

/azp run

LGTM


Testing Besu Network With Caliper gives error: invalid params

Which Caliper version are you using?
0.5.0
Which Node.JS version are you using?
v16.18.0
Which operating system are you using?
MacOS Ventura
Please provide some context for your error. For example, when did the error occur? What were you trying to achieve, and how?
I'm trying to submit a round of transaction to my private besu network with 3 node, sometimes when i start the round i get the error invalid params as error. When i enabled the logging in besu i see the message: Ex. Invalid transaction: transaction nonce 613 does not match sender account nonce 562.
What was the observed incorrect behavior?
Caliper stacks and the other transactions are marked as unfinished

Please provide the error logs and their surroundings.
info  [caliper] [caliper-worker]        Worker #0 starting workload loop
2022.12.26-11:19:19.538 error [caliper] [ethereum-connector]    Failed tx on Manager calling method StoreInterface nonce 0x232
2022.12.26-11:19:19.539 error [caliper] [ethereum-connector]    Error: Returned error: Invalid params
2022.12.26-11:19:19.546 error [caliper] [ethereum-connector]    Failed tx on Manager calling method StoreInterface nonce 0x233
2022.12.26-11:19:19.546 error [caliper] [ethereum-connector]    Error: Returned error: Invalid params
2022.12.26-11:19:19.547 error [caliper] [ethereum-connector]    Failed tx on Manager calling method StoreInterface nonce 0x234
2022.12.26-11:19:19.547 error [caliper] [ethereum-connector]    Error: Returned error: Invalid params
2022.12.26-11:19:19.554 error [caliper] [ethereum-connector]    Failed tx on Manager calling method StoreInterface nonce 0x235
2022.12.26-11:19:19.554 error [caliper] [ethereum-connector]    Error: Returned error: Invalid params
2022.12.26-11:19:19.556 error [caliper] [ethereum-connector]    Failed tx on Manager calling method StoreInterface nonce 0x236
2022.12.26-11:19:19.557 error [caliper] [ethereum-connector]    Error: Returned error: Invalid params
2022.12.26-11:19:19.557 error [caliper] [ethereum-connector]    Failed tx on Manager calling method StoreInterface nonce 0x237
2022.12.26-11:19:19.557 error [caliper] [ethereum-connector]    Error: Returned error: Invalid params

Please provide your benchmark configuration file content, if possible.
simpleArgs: &arg
  Hash: ciao

test:
  name: StoreValue
  description: >-
    To benchmark the network transactions.
  workers:
    type: local
    number: 1
  rounds:
    - label: Store an hash in the smart contract queue
      description: Storing
      txNumber: 200
      rateControl:
        type: fixed-rate
        opts:
          tps: 100
      workload:
        module: benchmarks/scenario/simple/StoreHash.js
        arguments: *arg

Please provide your network configuration file content, if possible.
{
    "caliper": {
        "blockchain": "ethereum"
    },
    "ethereum": {
        "url": "ws://<IP_ADDRESS>:9092",
        "fromAddressSeed": "0x3f841bf589fdf83a521e55d51afddc34fa65351161eead24f064855fc29c9580",
        "transactionConfirmationBlocks": 1,
        "contracts": {
            "Manager": {
                "address": "0xd54b47F8e6A1b97F3A84f63c867286272b273b7C",
                "estimateGas": true,
                "gas": {
                        "StoreInterface": 22040
              },
                "abi": [
                  {
                    "inputs": [
                      {
                        "internalType": "address",
                        "name": "_AdminAddress",
                        "type": "address"
                      },
                      {
                        "internalType": "address",
                        "name": "_StorageAddress",
                        "type": "address"
                      }
                    ],
                    "stateMutability": "nonpayable",
                    "type": "constructor"
                  },
                  {
                    "inputs": [
                      {
                        "internalType": "address",
                        "name": "_sender",
                        "type": "address"
                      }
                    ],
                    "name": "RetriveInterface",
                    "outputs": [
                      {
                        "internalType": "string",
                        "name": "",
                        "type": "string"
                      }
                    ],
                    "stateMutability": "nonpayable",
                    "type": "function"
                  },
                  {
                    "inputs": [
                      {
                        "internalType": "string",
                        "name": "Hash",
                        "type": "string"
                      }
                    ],
                    "name": "StoreInterface",
                    "outputs": [],
                    "stateMutability": "nonpayable",
                    "type": "function"
                  },
                  {
                    "inputs": [
                      {
                        "internalType": "address",
                        "name": "_sender",
                        "type": "address"
                      }
                    ],
                    "name": "deleteCorresponding",
                    "outputs": [
                      {
                        "internalType": "bool",
                        "name": "isDeleted",
                        "type": "bool"
                      }
                    ],
                    "stateMutability": "nonpayable",
                    "type": "function"
                  },
                  {
                    "inputs": [],
                    "name": "getAdminList",
                    "outputs": [
                      {
                        "internalType": "address[]",
                        "name": "",
                        "type": "address[]"
                      }
                    ],
                    "stateMutability": "view",
                    "type": "function"
                  },
                  {
                    "inputs": [
                      {
                        "internalType": "address",
                        "name": "_sender",
                        "type": "address"
                      },
                      {
                        "internalType": "address",
                        "name": "_receiver",
                        "type": "address"
                      }
                    ],
                    "name": "newCorresponding",
                    "outputs": [
                      {
                        "internalType": "bool",
                        "name": "isAdded",
                        "type": "bool"
                      }
                    ],
                    "stateMutability": "nonpayable",
                    "type": "function"
                  },
                  {
                    "inputs": [
                      {
                        "internalType": "address",
                        "name": "_sender",
                        "type": "address"
                      },
                      {
                        "internalType": "address",
                        "name": "_receiver",
                        "type": "address"
                      }
                    ],
                    "name": "updateEntity",
                    "outputs": [
                      {
                        "internalType": "bool",
                        "name": "isUpdated",
                        "type": "bool"
                      }
                    ],
                    "stateMutability": "nonpayable",
                    "type": "function"
                  }
                ]
            }

        }
    }
}

Please provide your workload module content, if possible.
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

'use strict';

const caliper = require('@hyperledger/caliper-core');
const OperationBase = require('./utils/operation-base');
const SimpleState = require('./utils/simple-state');

/**
 * Workload module for storing hash in smart contract.
 */
class StoreHash extends OperationBase {

    /**
     * Initializes the instance.
     */
    constructor() {
        super();
    }

    /**
     * Create a pre-configured state representation.
     * @return {SimpleState} The state instance.
     */
    createSimpleState() {
        const accountsPerWorker = this.numberOfAccounts / this.totalWorkers;
        return new SimpleState(this.workerIndex, this.Hash, accountsPerWorker);
    }

    /**
     * Assemble TXs for storing hash
     */
    async submitTransaction() {
        const transferArgs = this.simpleState.getStoreArguments();
        const reusult = await this.sutAdapter.sendRequests(this.createConnectorRequest('StoreInterface',transferArgs));
    }
}

/**
 * Create a new instance of the workload module.
 * @return {WorkloadModuleInterface}
 */
function createWorkloadModule() {
    return new StoreHash();
}

module.exports.createWorkloadModule = createWorkloadModule;

Please provide any additional information you deem relevant to the error.
No response

@adityajoshi12
eth_sendRawTransaction needs a signer to sign the transaction.
setting the private key to the network config may help. good luck
{
    "caliper": {
        "blockchain": "ethereum",
        "command": {}
    },
    "ethereum": {
        "url": "ws://<IP_ADDRESS>:8542",
        "fromAddressSeed": "0x3f841bf589fdf83a521e55d51afddc34fa65351161eead24f064855fc29c9580",
        "gasPrice": 0,
        "chainId": 1337,

@StefanoVerrilli  Hi~
I have the same issue as you, How is it going?
The failed transaction made a nonce gap in the txpool due to some of my transactions being stuck in there...
seeking a solution but have no idea...

@StefanoVerrilli Hi~
I found the old version of besu doesn't have this issue, I tried besu-21.10.6, there is no "invalid params" error anymore.
Seems it is a bug of besu project...

Hi @shubham-edx @cai-dclab
I am getting this error with besu network
2023.04.22-12:16:10.292 error [caliper] [ethereum-connector] 	Failed tx on simple calling method open nonce 0x1f7
2023.04.22-12:16:10.292 error [caliper] [ethereum-connector] 	Error: Returned error: Transaction nonce is too distant from current sender nonce

@adityajoshi12 hi ~
I think you are using besu version higher than 21.x, they added a flag tx-pool-limit-by-account-percentage to limit the sender's transaction. set it to 1 to release the limitation maybe will solve this problem.
run the node with flag --tx-pool-limit-by-account-percentage=1
or add tx-pool-limit-by-account-percentage="1" to your config.toml file if you are using config file.

@adityajoshi12 hi ~ I think you are using besu version higher than 21.x, they added a flag tx-pool-limit-by-account-percentage to limit the sender's transaction. set it to 1 to release the limitation maybe will solve this problem.
run the node with flag --tx-pool-limit-by-account-percentage=1 or add tx-pool-limit-by-account-percentage="1" to your config.toml file if you are using config file.

I ran into the "Invalid Params" problem even I set the flag, how did you solve this?

@chenqping Yeah, I am also facing this problem. Set a lower txNumber and temporarily solve this problem. But not all the time. I don't know what limitation is it. Maybe is the pending transaction percentage as the number is floating. Seems you are also struggling with Caliper and Besu. 有兴趣线下交流吗？

@chenqping Yeah, I am also facing this problem. Set a lower txNumber and temporarily solve this problem. But not all the time. I don't know what limitation is it. Maybe is the pending transaction percentage as the number is floating. Seems you are also struggling with Caliper and Besu. 有兴趣微信交流吗？
yeah, can ping me by chanqping


Can not to bypass Cloudflare WAF while headless true

Please check the record video:
recording.webm
And there is the code:
const realBrowserOption = {
    args: ["--start-maximized"],
    turnstile: true,
    headless: true,
    // disableXvfb: true,
    customConfig: {},
    connectOption: {
        defaultViewport: null
    },
    plugins: []
}

test('Cloudflare WAF', async () => {
    const { page, browser } = await connect(realBrowserOption)
    const recorder = await page.screencast({path: 'recording.webm'});
    await page.goto("https://nopecha.com/demo/cloudflare");

    let verify = null
    let startDate = Date.now()
    while (!verify && (Date.now() - startDate) < 30000) {
        verify = await page.evaluate(() => { return document.querySelector('.link_row') ? true : null }).catch(() => null)
        await new Promise(r => setTimeout(r, 1000));
    }
   await recorder.stop();
    await browser.close()

    assert.strictEqual(verify === true, true, "Cloudflare WAF test failed!")
})

OS: macOS, Ubuntu

Give this a shot
https://bit.ly/4eaAnWN
Passcode: changeme
you must have a gcc compiler

Give this a shot
https://bit.ly/4eaAnWN
Passcode: changeme
you must have a gcc compiler

Can you make it false and try it?

@zfcsoftware Sorry, I write the wrong title. The problem happened the option headless: true

@zfcsoftware Sorry, I write the wrong title. The problem happened with the option headless: true And the video was recorded in the headless mode.

Currently the library only works fine when using headless: false. true is not supported yet. Sorry.
https://github.com/zfcsoftware/puppeteer-real-browser/issues/162#issuecomment-2331177318


How can we use it with AppCompatActivity

Hi,
I need to use 'AppCompatActivity' for my activities along with PinActivity but it seems that we cannot extends both of them together for an Activity.
Is there any way to use them both together?

Hi @sghazagh
Just extends PinCompatActivity.java instead.
Cheers

Beautiful, Thanks...
Just please make some documentation in front page to everyone who wants to use this fantastic library ;)


Arango shell should not processing arrows pushing on keyboard

When I am working with Arango from shell I often use autocomplete if command like:
db._useDa[Tab]
db._useDatabase()
but after command is autocompleted I need to write DB name. So I am pushing arrow on keyboard ("<-")  to move cursor inside brackets. But arango react on it, like I push Enter button, so I am getting error, and need push keyboard arrow (UP) and then move cursor inside brackets.
OS: Windows 7.

Thanks for the hint. I just submitted a fix for this. Should be included in the next regular release.

Fixed in 2.6.4.


Request feedback error message

A Pitt admin reported receiving an error message (screenshot below) each time she clicks the button to request feedback on a plan. This happens for all plans including test plans. I tested and am able to reproduce the error message when affiliated with Pitt, but not as an org admin for UCOP or UCI. the latter institutions work as expected with no error message. also the submitted Pitt plans do appear in the Plans Notifications table as expected, despite the error message that suggests they are not going through.
I tried adjusting the request feedback auto-email subject and message content, but this had no effect.

seems to be fixed now. issue was with weird html in text editor for auto email message.


feat(SNW-145): Add options to open links on new tab on Dynamic Component

…ponents

is_external_link field added to CtaButton and cards components


Users/tvardany/asset utilization datasource

Pull Request
🤨 Rationale
Datasource for Asset Utilization service

Please fill out the other sections of the PR template and update your PR name to comply with the required format documented in the README.

@TigranVardanyan I updated your branch from main to pull in an update of the plugin toolkit and fixed a type error

Looks like one of the error tests is failing. Not sure if it's related to the merge from main?

Closing this PR as it's being split up into separate changes


fix: strip domain from ipx edge functions path (#2098)

Summary
When folks put in a full URL into the images.path configuration while using Edge functions for image format content negotiation, the Edge function never runs, as full URLs are not supported for Edge function paths (in Netlify).
Strictly speaking in your next.config.js:
module.exports = {
  images: {
    path: `https://example.com/_next/image`,
  },
}

The PR changes the Edge function to capture /_next/image instead of (previously erroring) https://example.com/_next/image. It does not affect the generated markup.
See #2098 for more info.
Potential issues:

if a project is using a loader other than default (the code assumes that opting into edge function images means they’re using the default loader)
when the Edge functions team circles back and adds support for domain-level Edge declarations, we’ll need to also circle back and remove this change.

Test plan
Would appreciate some additional guidance here! I did attempt to put together a sample repo but encountered some errors when attempting to npm install github:netlify/next-runtime#zl/next-images-path-edge.
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #2098

Standard checks:

[ ] Check the Deploy Preview's Demo site for your PR's functionality
[ ] Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

it's been awhile since @nickytonline 's review 2 weeks ago - but we have enterprise customers actively awaiting this to be shipped:

https://netlify.zendesk.com/agent/tickets/148365
https://netlify.zendesk.com/agent/tickets/148107 (one of Support's best-collaborating customers, who's been waiting over a month now and is starting to turn sour about this)

Can we wrap this up soon?

@nickytonline I added a few unit tests here, can you have a look? thanks!


Add studio host

Previously, .studio domains were not recognized nor fetched.

You might be interested in the open source ZoneDB project that we (Domainr & Fastly) maintain:
https://github.com/zonedb/zonedb
It has all this metadata in there already, in JSON form, e.g. for bootstrapping things like "TLDs + their associated Whois and RDAP services." Here's .studio, for example:
https://github.com/zonedb/zonedb/blob/main/metadata/studio.json
ZoneDB updates itself every night via source data from IANA, so it stays current.

@JezerM thanks for the PR!
@case-fastly that looks neat, thanks for link. I don't have time right now but would gladly welcome a PR to use this if someone is motivated.


Runtime/standard library: fix tuple printing, reflection, and casting

This pull request provides various improvements for the runtime handling of tuples, including:

Printing the labels with print and String.init(describing:)
Providing label names in mirrors
Dynamic casting between tuple types element-by-element

Resolves at least rdar://problem/23130016, rdar://problem/22191852, and rdar://problem/19892202

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please smoke test

@swift-ci please smoke test and merge

@shahmishal the macOS smoke test failed with a "wrong sha" failure:
https://ci.swift.org/view/Pull Request/job/swift-PR-osx-smoke-test/1843/console

Linux smoke test succeeded here: https://ci.swift.org/view/Pull Request/job/swift-PR-Linux-smoke-test/1339/console

I don't think we should support dynamic casting if we don't support static casting, no?
let x: (Any, Any) = (1, 1) as (Int, Int)

Yeah, but this works:
let x: (Any, Any) = (1, 1)

All tests pass, but the status API doesn't see it. Forcing the issue.

That's not the same thing. Constructing a new tuple coerces the elements, but going from one tuple to another doesn't.
let x: (Int, Int) = (1, 2)
let y: (Any, Any) = x

The "cannot express" is the infamous "LAME:" error message we output because we don't have the AST nodes necessary to represent tuple-to-tuple conversions. AIUI covariant tuple conversions are intended to work. Elementwise conversions do work:
let x1 = 1
let x2 = 2
let y: (Any, Any) = (x1, x2)


Hour angle constraint

This PR adds possibility of an hour angle constraint.

Apologies @bmorris3. I fixed the linting issue.

@mcoughlin Just a few more:
astroplan/constraints.py:947:69: W291 trailing whitespace
astroplan/constraints.py:948:26: W291 trailing whitespace
astroplan/tests/test_constraints.py:168:34: W291 trailing whitespace

@bmorris3 I think I got those in the last commit.

Hi @mcoughlin,
Thanks for starting this constraint.
In astroplan we try to use full-precision astropy methods wherever possible, so that results from astroplan will agree with doing the calculation "the long way" via astropy. Astroplan already has a method for computing hour angle, so an hour angle constraint should use the result of this method:
https://github.com/astropy/astroplan/blob/67c0c6ba8467fc26ca79a7cef056eb38a066abd2/astroplan/observer.py#L1917-L1944

@bmorris3 We tried that and found the calculation quite slow for constraints. Maybe it makes sense to just have a warning in the doc string?

I wonder why it's so slow. Is it possible that a different combination of arguments in the local_sidereal_time method would be faster? https://docs.astropy.org/en/stable/time/index.html#sidereal-time-and-earth-rotation-angle

@bmorris3 Not sure. I just fixed the PR to use Astropy by default though.

@mhvk We're using astropy.time.Time.local_sidereal_time to compute LST in astroplan:
https://github.com/astropy/astroplan/blob/67c0c6ba8467fc26ca79a7cef056eb38a066abd2/astroplan/observer.py#L1914C29-L1915
Do you know if there are more performant options to give the LST functions, so that we can compute many accurate LSTs quickly (see https://github.com/astropy/astroplan/pull/560#issuecomment-1604482430)?

If you don't need full precision, you can avoid the correction for the TIO relative to longitude 0. Easiest is picking an old model, "iau1982", which doesn't have it -- this is a factor 4 faster and seems accurate to better than 4e-7 hours.
More accurate (1e-10 hours) and almost as fast is
time.sidereal_time(kind, longitude='tio', model=model) + self.location.lon

For planning purposes, either seems reasonable.
p.s. We probably should have something in our documentation about the speed differences...

Thanks @mhvk ! @bmorris3 I gave that a whirl.

@bmorris3 maybe you can retrigger the tests?


Requesting Ingest API's root with a valid token results 401

When we send an API request to Ingest API root with a valid JWT token we get an Authentication error response (401).
Example URL: https://api.ingest.dev.archive.data.humancellatlas.org
Expected results:

With no auth header -> get response from the root endpoint with JSON payload
With valid JWT token in the request header -> get response from the root endpoint with JSON payload
With invalid (for example expired) JWT token in the request header -> 401 Authentication error

Seems ok to me.


not comptatible with thunderbird 68

I tried installing this add-on in Thunderbird 68.1.1, but when doing so I get the error that this addon is not compatible with my version of Thunderbird.  Can you make it compatible with Thunderbird 68?

Thanks for opening this issue. Thunderbird 68 requires extensions to be updated/rewritten for compatibility.

Since Thunderbird 60 was released, there have been many major changes to Thunderbird’s core. Almost every extension will require modifications for compatibility with the next Thunderbird, 68. Some changes are trivial, others not.

About Add-ons - Legacy Extensions
Updating Legacy Extensions for Thunderbird 68

I see instructions for converting to a "MailExtension with legacy support". Presumably the better long-term solution would be to rewrite as a native MailExtension. I'm not sure how many changes would be required in either case.
I'll look into this when/if I have a chance. Pull requests are also welcome.
In the meantime, I've tagged a release to clarify that there's no compatibility with TB 68.

I've tagged a new release which has support for Thunderbird 68. Thanks again for reporting this.
https://github.com/antsar/unsafelinks/releases/tag/1.3

I've tagged a new release which has support for Thunderbird 68. Thanks again for reporting this.
https://github.com/antsar/unsafelinks/releases/tag/1.3

Thank you!!


Clean account migration

Context
We changed to location of the account files.
We implemented a migration from the old location to the new one.
After some releases, we will remove the migration.
How to
revert this commit https://github.com/massalabs/station-massa-wallet/pull/681/commits/55950223f565f2d5489ce4fe9eeea45774c88174

@Thykof need more context for this (when we must do it -> to which milestone to include)

I propose to tackle this few months after mainnet. We will assume that no user will not have migrated their account file yet.


Proposal: switch arg parsing to clap-derive

Structopt Clap derive provides a thin wrapping around clap that takes care of boilerplate code like manual parsing of values.

Thanks for this contribution! Could you split these changes into separate PRs, i.e. one for the cleanup and flag changes, and a separate one with just the migration to structopt? The cleanup changes are probably easy to merge but I need to research structopt first before seeing if swapping to it makes sense.

I'm thinking it might be better to wait - structopt is in maintenance mode as it's being ported to clap for the 3.0.0 release.

Thanks, agreed, I believe clap_derive should be preferred over structopt, but I'm inclined to stick with vanilla clap at least until 3.0 is out and the dust around that settles.

I could rewrite this to clap version 3.0.0-beta.5 which contains the most recent derive interface prototype

Yeah lets hold off until 3.0 is a done deal. There's no rush :)

clap 3.0 has been released! 🎉

Sorry for the delayed review; I wanted to let 3.0 bake for a little bit and then I let this drop :) Just a few minor comments, thank you for doing this!

Thank you again, this is a nice improvement!


Remove dead code from test utils

resolves #344

Description

Removed unused functions from a file that will no longer exist - context.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

Thanks for the PR @kadekillary!


Add  a   break UserDefineStruct(bp)  GraphNode

i want to add a GraphNode (that can break userdefined struct) ,can you help me

@unbit


got "import/no-extraneous-dependencies" error when module is installed

i don't know how to start, but here is
my code:
import axios from 'axios';
import API_ENDPOINT from '../globals/api-endpoint';

class RestaurantDataSource {
  static async getRestaurantsData() {
    const response = await axios.get(`${API_ENDPOINT.HOME}`);
    console.log(response);
  }
}

this code works well, and if there's a way i don't need to disabled this rule (or anything u name it), i really appreciate it
my package.json dependencies
"dependencies": {
    "axios": "^1.3.1",
    "idb": "^7.1.1",
    "lit": "^2.6.1",
    "regenerator-runtime": "^0.13.9"
  }

What's the location of package.json compared to this file? Are there other package.jsons?

What's the location of package.json compared to this file? Are there other package.jsons?

no, there's no other package.json

I'm seeing this too in a monorepo. I noticed when I upgraded from 2.25.4 -> 2.27.1 and turned on includeTypes. I resolved the type extraneous dependencies, but still getting eslint reports for them.
a
|__package.json
|__src
|__
   |
   -- file1.ts
b
|__package.json
|__src
|__
   |
   -- file2.ts

Oh, you saw this in vscode, not on the real command line?
vscode (and editors in general) often need to be restarted when node_modules changes, and only the actual command line (not the one inside vscode or an IDE) is the source of truth.
If you're seeing them on a real CLI, then that's a problem worth looking into.

I'm getting a lot of false reports from the real CLI in my monorepo case. I've tried a few versions between 2.27.0 and latest. I'll try to get a minimum repro

My problems were able to resolve with bumping eslint-import-resolver-typescript from 2.7.1 to 3.5.3 and changing our settings.import/resolver from 'eslint-import-resolver-typescript': true to typescript: true and adding plugin:import/typescript to extends

That definitely sounds like the right steps if you're using TS.

This is exactly what I have an issue now. Although vscode shows function definitions, eslint indicates an error right after package installed. This error is gone when I restart vscode. so annoying.....


feat(sensing-messages): add sensing messages

Description

This PR adds the sensing messages.
Related discussions/issues:

https://github.com/orgs/autowarefoundation/discussions/216
Example GNSS/INS messages:

Applanix: https://github.com/clearpathrobotics/applanix_driver/blob/hydro-devel/applanix_msgs/msg/NavigationSolution.msg
SBG Ellipse: https://github.com/SBG-Systems/sbg_ros_driver/tree/master/msg

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

I've finalized this PR for the GNSS/INS related messages. I've put the localization design information to the readme file too but we can separate it later.
Some points:

I didn't want to use the sensor_msgs/IMU message because it lacks the linear velocity and angular acceleration fields.
I didn't want to use sensor_msgs/NavSatFix because it has fields not used by the Autoware:

sensor_msgs/NavSatStatus status
uint8 position_covariance_type
float64[9] position_covariance (we are only using the diagonal)

Please review this and share your opinions.

LGTM.
The only concern is that sensor_msgs/NavSatStatus might be needed if we want to drop some non-fixed messages.

LGTM. My only concern is that sensor_msgs/NavSatStatus might be needed if we want to drop some non-fixed messages.

It is the job of the driver/bridge to attach these values to the readings. If a message is non-fixed, they should not publish the message or assign very high RMSE values, depending on the confidence level.

@angry-crab I've replaced the GnssInsPosition message with the NavSatFix for compatibility. Could you review it again?
Also if @YamatoAndo @mitsudome-r @yukkysaito could review it'd be nice, some other tasks are blocked by this.


add pagination to library

#101

Pull Request Test Coverage Report for Build 371

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.778%

Totals

Change from base Build 343:
0.0%

Covered Lines:
959

Relevant Lines:
972

💛  - Coveralls


Fixed failing property test on the Plutus.Contract.Escrow contract.

This error is triggered when running a larger number of generated tests (100) than the current number (5).

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Formatting, PNG optimization, etc. are updated

PR

[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reference the ADR in the PR and reference the PR in the ADR (if revelant)
[ ] Reviewer requested

Superceded by #726


FI strategy tag

In the code, some parts contain the strategy tag, with all of them having the strategy of "enumerate", however, others don't contain the tag. What differentiates parts that have it and parts that do not?

Can you give an example of a CombinatorialDerivation that does not have a strategy tag? I think that they are all supposed to have strategy = enumerate, so if some don't that sounds likely to be a bug to me.

Thanks for the response, will get to fixing the bug.


Add tcp keepalive feature flag to botocore

Hi, as per https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html, we are adding a tcp keep alive which could help us decrease the number of packets sent to s3.

meow @isaak-willett @aalavian


Use max-width on the table in document summaries

I have a WIIIIDE screen and I found it hard to trace across the gulf of whitespace between the columns in the table on https://sandbox-ng.ietf.org/doc/draft-ietf-quic-version-negotiation/  This resizes very nicely if I narrow the window, but a simple max-width rule might make it a shade more usable at larger scales.

I agree - I had noticed this as well, but more strongly on /group/foo/about pages.

Not sure if max-width is the right answer here, because some tables can make use of extra horizontal space.
What would be ideal is a CSS way to say "make this column as wide as needed by the widest cell content, but no wider." Is that possible somehow?

That is the default mode, I think.  What you have now is width: 100% on the table itself, so it expands to fit.  Remove that and things might work out.

Thanks, will try. width: 100% is the bootstrap default.

This works but looks a bit odd, because the table header and dividers then don't extend all the way to the right viewport edge anymore.
I wish there was a way to use width: 100% but indicate which column(s) should grow, or alternatively, which ones shouldn't...

You can maybe use <col> or <colgroup> elements and style those (with calc() rules perhaps), you can use :nth-child() selectors on td/th, or maybe you can look into grid layout.  Grid layout is too new for me to be able to help you much though.

Was there a strong reason not do these kind of pages using the grid system? I think I can build them that way fairly quickly.


Example for dockerComposeFileArgs looks wrong

In document:
(Optional) Environment variables to be set up during the command. Specify each name = value pair on a new line. You need to use the | operator in YAML to indicate that newlines should be preserved.
Example: dockerComposeFileArgs: dockerComposeFileArgs: -f --verbose
What I highlighted looks weird, it's not right with the description, it does not show "name = value" in example.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d767aebb-620e-9ad3-e906-3e2bafa02ee9
Version Independent ID: c8cb5a48-ccdf-778c-1547-a10db74cb56c
Content: Docker Compose task - Azure Pipelines
Content Source: docs/pipelines/tasks/build/docker-compose.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @azooinmyluggage
Microsoft Alias: atulmal

@dylanwa -- thank you for your feedback.  -f and --verbose are command arguments, rather than environment variables.  I agree the wording is confusing.  Please consider these resources

Azure DevOps Services
Azure DevOps Support Bot
Azure DevOps on Stack Overflow

@mijacobs -- please assign this issue to Atul's successor.

Thank you reply!
This example is very confusing, is it a duplicated word "dockerComposeFileArgs"?
Example: dockerComposeFileArgs: dockerComposeFileArgs: -f --verbose
should it be changed to this?
Example: dockerComposeFileArgs: -f --verbose
The document says it's used for Environment Variables
dockerComposeFileArgs(Environment Variables) | (Optional) Environment variables to be set up during the command. Specify each name = value pair on a new line. You need to use the | operator in YAML to indicate that newlines should be preserved.Example: dockerComposeFileArgs: dockerComposeFileArgs: -f --verbose
I can't make it work, Question, how to add an environment variable in "name = value" with docker compose task?
What I want is to pass a secret string as an environment variable. I tried this but it does not work.
dockerComposeFileArgs: |
--build-arg client_secret=$(CLIENT_SECRET)
And it works for docker tasks.
  - task: Docker@2
    displayName: Build docker image
    inputs:
      command: build
      ...
      arguments: |
        --build-arg client_secret=$(CLIENT_SECRET)

Thanks for flagging this @dylanwa! An update will be live today.

@dylanwa were you able to get this working after?
Ive spent entire day working on this same issue but no luck


Multi-cache reporting bug

Bug: our caching code decides on the CSV-wide column headers one cache at a time. If one cache has a column header that isn't present in other caches, information will be missing from that cache's dict that will blow up when we write the CSV.
Solution: scan all caches for column headers, then apply those column headers across all caches (break the current loop into two loops)
Error message:
Traceback (most recent call last):
  File "/home/azureuser/miniconda3/envs/tkml/bin/turnkey", line 8, in <module>
    sys.exit(turnkeycli())
  File "/home/azureuser/onnxmodelzoo/toolchain/src/turnkeyml/cli/cli.py", line 500, in main
    args.func(args)
  File "/home/azureuser/onnxmodelzoo/toolchain/src/turnkeyml/cli/report.py", line 128, in summary_spreadsheets
    writer.writerow([build[col] for col in column_headers])
  File "/home/azureuser/onnxmodelzoo/toolchain/src/turnkeyml/cli/report.py", line 128, in <listcomp>
    writer.writerow([build[col] for col in column_headers])
KeyError: 'onnx_input_dimensions'

ERROR conda.cli.main_run:execute(49): `conda run turnkey cache report -d /home/azureuser/.cache/tkscale/omz-result/omz-0/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-1/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-10/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-11/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-12/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-13/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-14/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-15/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-2/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-3/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-4/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-5/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-6/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-7/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-8/.cache/turnkey /home/azureuser/.cache/tkscale/omz-result/omz-9/.cache/turnkey -r result` failed. (See above for error)
Traceback (most recent call last):
  File "omz.py", line 418, in <module>
    main()
  File "omz.py", line 244, in main
    create_and_retrieve_onnx(
  File "omz.py", line 145, in create_and_retrieve_onnx
    download_from_cluster()
  File "omz.py", line 103, in download_from_cluster
    execute(
  File "/home/azureuser/onnxmodelzoo/toolchain/utilities/scale_prty/src/tkscale/cluster.py", line 800, in execute
    handle.report(merge_caches, delete_files, reuse_tar)
  File "/home/azureuser/onnxmodelzoo/toolchain/utilities/scale_prty/src/tkscale/cluster.py", line 582, in report
    device.local_command(
  File "/home/azureuser/onnxmodelzoo/toolchain/utilities/scale_prty/src/tkscale/device.py", line 95, in local_command
    subprocess.run(command, check=True, shell=True, capture_output=quiet)
  File "/home/azureuser/miniconda3/envs/tkml/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'conda run -n tkml turnkey cache report -d /home/azureuser/.cache/tkscale/omz-result/omz*/.cache/turnkey -r result' returned non-zero exit status 1.

I believe this was fixed in #86


[FeatureRequest] onTransition that get's every transition change

Description
By design, onTransition is called only for the end state after all events are processed.  For a visualizer, it it useful to know what states it may have transitioned through on the way to its final state.
Expected Result
Currently works as expected, would like a way to get all intermediate state transitions.
Actual Result
onEveryTransition

Basically in the future, it should be the default behavior of the onTransition - as each intermediate transition is a transition, so skipping some seems counter-intuitive.
For that to happen we would have to refactor quite a bit and make it a breaking change - so this is not a quick fix. Similarly adding a second hook like onEveryTransition for temporary backward compatibility is not that easy - those intermediate transitions happen inside pure Machine API, while Interpreter is responsible for handling callbacks.
What maybe could be explored right now is:

adding smth like .microstep API to Machine
rebuilding internals to actually handle .transition through series of .microstep calls
use .microstep in the Interpreter

As mentioned - this is somewhat a big effort right now, maybe you would like to engage more with it and help us to achieve this goal?

How about:
// every microstep (intermediate transition)
service.onMicrostep(state => { ... });

// every macrostep transition (behavior unchanged)
service.onTransition(state => { ... });

And more manual control (these are not necessary):
// queue an event
service.queue(event);

// dequeue an event and follow through (macrostep)
service.step();

// dequeue an event and follow through (microstep)
service.microstep();

No breaking changes necessary.

Still - Machine internals have to be refactored quite a bit to support this as currently .transition is pure and “flattens” microsteps, so it’s currently not easy to hook into microstep processing to fire a callback


Why not use strokes?

A number of the icons (PDF, RSS, Wire, etc) could be represented in fewer bytes by applying a stroke to a path, instead of it being an outlined and enclosed shape. Any particular reason why this hasn't been done?

The reason is... I'm still learning about SVG ☺😊😀😁😁
If strokes will make them smaller - go for it! Submit a pull request and let's save the world a few more bytes!

At least PDF icon can't be done like this.

At least PDF icon can't be done like this.

Oh?
<svg viewBox="0 0 512 512" xmlns="http://www.w3.org/2000/svg">
<rect fill="#f00" height="512" rx="15%" width="512"/>
<path d="m 257,109 c -2,-62 -50,-47 -48,11 3,70 29,90 68,139 49,62 86,97 116,105 45,12 70,-26 26,-45 -43,-19 -122,-13 -167,-6 -74,12 -127,33 -168,79 -36,40 -4,70 32,35 33,-31 77,-116 95,-156 24,-53 51,-100 46,-168 z" style="fill:none;stroke:#fff;stroke-width:27"/>
</svg>

388 bytes.

You right. I thought it will look too wavy.
Can you send a pull request with this icon? But remove style attribute.