Add binaries to Homebrew and other package management systems

Evaluate the possibility to share binary in the following package management systems at the very least:

HomeBrew
APT (Debian and Ubuntu derivatives)
RPM (RedHat derivatives and SUSE distributions)
Chocolatey/Scoop (Windows)

Homebrew
Tried to add Harvester Formula using this PR to the homebrew-core repo: https://github.com/Homebrew/homebrew-core/pull/104700
Unfortunately, this is failing because the Github repo does have enough interest : less than 75 starts, and less than 30 watchers.
Added a belgaied2/harvester tap located here: https://github.com/belgaied2/homebrew-harvester.

OBS
For the other packages, it looks like it would be relatively easy to create a package using Open Build Service.
A Home project has already created for this: https://build.opensuse.org/project/show/home:mohamed.belgaied
The following tasks are needed:

[ ] Add source file to OBS
[ ] Add spec file with the right configuration, inspired from this
[ ] Find a way to automate that

Homebrew and OBS still need a manual process, but that's okay at the moment.


Bump DPPL version to 0.27

This includes a few breaking changes + some fixes.
Of greatest importance is:

prob"..." macro is gone.
Definitions of the form @model demo(::Type{T}=...) are now converted into demo(::TypeWrap{T}=...) to improve type-stability and thus performance. But this means that one can no longer call demo(Vector{Float64}) but instead need to do demo(TypeWrap{Vector{Float64}}()).

Yep! Edited.

But we need to merge https://github.com/TuringLang/DynamicPPL.jl/pull/609 first

Is the old syntax no longer supported, or just inefficient due to type instability?

Old syntax is still supported for definition, but not for calling.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
1528

💛  - Coveralls

Anyone wants to give this the go-ahead?

Waiting with the merge until I've gotten the other two PRs through, as they are not breaking (but need to fix tests)


Card type missing in the demo

Hello,
The card type is missing in the demo and without this field the registration failed (for a 3 digits CVV).
Regards

Hi @tildedash,
I'm not sure to have understood your query - the CardType is given here: https://github.com/Mangopay/cardregistration-js-kit/blob/master/demo/index.php#L31
If you specify MAESTRO, you'll then not be required to supply a CVV.

Yes, I'm talking about the HTML field that the JS try to retrieve here : https://github.com/Mangopay/cardregistration-js-kit/blob/master/demo/index.php#L92
So cardData.cardType stays empty and _cvvValidator.validate return false : https://github.com/Mangopay/cardregistration-js-kit/blob/master/kit/mangopay-kit.js#L267
Did I miss something ?

You're absolutely rightly - sorry about the confusion. I've just corrected that with https://github.com/Mangopay/cardregistration-js-kit/commit/09f93fe24959a38d6aecca1d4172edb5d916398a :-)


HTTP-Download is corrupted, when file is too big

On Ubuntu 16.04
Godot Vers 2.1.1
I tried to download some videos. It worked, as I wanted to download a short video, but if the video is bigger than 4 seconds, the downloaded file is currupted.
Steps to reproduce:
In example project, in http-script, there are 4 lines on top for downloading 2 different videos, one works, the other not. You just need to comment/uncomment 2 lines.
Links to the videos:
https://upload.wikimedia.org/wikipedia/commons/a/a4/Xacti-AC8EX-Sample_video-001.ogv (NOT working)
http://techslides.com/demos/sample-videos/small.ogv (working)
example_download_fail.zip

Godot 2.1.1 ? Can you try with 2.1.4 ?

Remains exactly the same. Tried it with 2.2 alpha, same problem.

Possibly duplicate of https://github.com/godotengine/godot/issues/7345
Which is itself a possible duplicate of https://github.com/godotengine/godot/issues/6103

I saw these issues, but i thought  ´OS.delay_usec(1)´ was the solution which didn't work for me.

Using current master for Godot 3, both videos work fine after download.
I used the following code to download them with GDScript:
https://gist.github.com/mhilbrunner/7e30f057794b68cc5e3e23dc4be0b9c7

Assuming fixed, please comment/open a new issue if it's not the case.


Colab/Binder links don't work on Github

Describe the bug
Our cloud runner links don't work on GitHub. E.g. https://github.com/stellargraph/stellargraph/blob/develop/demos/calibration/calibration-pubmed-link-prediction.ipynb
Clicking either button hits:
Refused to load https://colab.research.google.com/github/stellargraph/stellargraph/blob/master/demos/calibration/calibration-pubmed-link-prediction.ipynb because it does not appear in the frame-src directive of the Content Security Policy.

Refused to load https://mybinder.org/v2/gh/stellargraph/stellargraph/master?urlpath=lab/tree/demos/calibration/calibration-pubmed-link-prediction.ipynb because it does not appear in the frame-src directive of the Content Security Policy.

in Safari's web console.
Environment
StellarGraph eb4d832c14e8bc8180efb96b134c892d868a890d
Additional context
N/A

(Closed by the GitHub keyword, accidentally.)


docs: add installation instructions for lazy.nvim

Added instructions in the README for how to install Neogit with Lazy.nvim as a package manager.

Hi. Thank you for your help. I'll unfortunately close this as Lazy has since been added to the README.


Notification rules

LGTM too! :shipit:

Hey there,
Thanks for your contribution but we decided to deprecate this project. Please use PDPyras instead.


refactor: remove unused code

/kind design
ReadyNodes's  parm about 'stopChannel' is not being used

/assign @damemi
please help reviewd when you are free, thanks a lot

/ok-to-test

@Mathew857 looks like you also need to update the test files:
 # sigs.k8s.io/descheduler/pkg/descheduler/node [sigs.k8s.io/descheduler/pkg/descheduler/node.test]
pkg/descheduler/node/node_test.go:77:24: too many arguments in call to ReadyNodes
	have (context.Context, *"k8s.io/client-go/kubernetes/fake".Clientset, "k8s.io/client-go/informers/core/v1".NodeInformer, string, nil)
	want (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string)

@Mathew857 looks like you also need to update the test files:
 # sigs.k8s.io/descheduler/pkg/descheduler/node [sigs.k8s.io/descheduler/pkg/descheduler/node.test]
pkg/descheduler/node/node_test.go:77:24: too many arguments in call to ReadyNodes
	have (context.Context, *"k8s.io/client-go/kubernetes/fake".Clientset, "k8s.io/client-go/informers/core/v1".NodeInformer, string, nil)
	want (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string)

ok, I'll update ASAP

/retest

/assign @damemi
node_test file updated, pls check it if you are free, thanks a lot

/retest

"skipped 213 lines unfold_more
have (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string, nil)
want (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string)
test/e2e/e2e_test.go:197:35: too many arguments in call to "sigs.k8s.io/descheduler/pkg/descheduler/node".ReadyNodes
have (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string, nil)
want (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string)
"
should I also  refactor  about node informer code  in client-go ? @damemi

should I also refactor about node informer code in client-go ? @damemi
"skipped 213 lines unfold_more
have (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string, nil)
want (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string)
test/e2e/e2e_test.go:197:35: too many arguments in call to "sigs.k8s.io/descheduler/pkg/descheduler/node".ReadyNodes
have (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string, nil)
want (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string)"

@Mathew857 that error looks to just be a similar one, this time in test/e2e/e2e_test.go, just need to remove this param from ReadyNodes there too

@Mathew857 that error looks to just be a similar one, this time in test/e2e/e2e_test.go, just need to remove this param from ReadyNodes there too

thanks reminder

/kind cleanup


new manifest

@robert3005 this is just the dependency list lock file that the build script uses to calculate whether the dependencies have changed unintentionally?  Seems like a followup to https://github.com/palantir/spark/pull/74/files#diff-600376dffeb79835ede4a0b285078036R137

Indeed.  This wasn't updated back then so when you reenable the tests it
would be failing
On Tue, 24 Jan 2017, 20:19 Andrew Ash<EMAIL_ADDRESS>wrote:

@robert3005 https://github.com/robert3005 this is just the dependency
list lock file that the build script uses to calculate whether the
dependencies have changed unintentionally? Seems like a followup to
https://github.com/palantir/spark/pull/74/files#diff-600376dffeb79835ede4a0b285078036R137
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/palantir/spark/pull/96#issuecomment-274926271, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfQVPB-eVyv63nF3BpZlR-4czPkEPZeks5rVlzBgaJpZM4LsYmt
.


Homepage image gradient

Hey -- can we add a gradient or some shading over the homepage image, so it's slightly easier to read the white text?

Victor we were going to leave it blue but add gradient. Please do not shade red.

@ZMcGroarty I think this is resolved. Can we close it?

Yep


Please fix issues reported by adapter checker

Please fix issues reported by adapter checker
https://github.com/ioBroker/ioBroker.repositories/pull/2373#issuecomment-1597106851

Fix in v0.7.6

Thanks


Reflectance map folder is invalid! and Localization Status Is Missing

We appreciate you go through Apollo documentations and search previous issues before creating an new one. If neither of the sources helped you with your issues, please report the issue using the following form. Please note missing info can delay the response time.
System information

**OS Platform and Distribution: Linux Ubuntu 20.04
**Apollo installed from : source
**Apollo version: 8.0

Steps to reproduce the issue:
When I was using carla_apollo_bridge, the localization module failed to start.
When I used the command cyber_launch start module/localization/launch/msf_localization.launch, I encountered an error: Reflectance map folder is invalid!.
After changing msf to rtk, the localization module was able to start, but the Dreamview interface showed a warning: Current Localization Status Is Missing
Supporting materials (screenshots, command lines, code/script snippets):

I'm not too clear about msf_localization.launch, but rtk localization will be ok. This error prompts that there is no Localization status. You need to check whether the gnss driver topic is normal.

I'm not too clear about msf_localization.launch, but rtk localization will be ok. This error prompts that there is no Localization status. You need to check whether the gnss driver topic is normal.

Thanks for your reply. How do I know if they're normal? Do you mean the FrameRatio ? I found that the FrameRatio of these gnss driver topic is 20 and the topic /apollo/localization/pose is also 20.

The following is the code that prints the error
https://github.com/ApolloAuto/apollo/blob/3859bee50e92d81e94f64ec4a3b3d4241978e8f5/modules/localization/rtk/rtk_localization.cc#L206-L211
which means drivers::gnss::InsStat is missing pos_type
https://github.com/ApolloAuto/apollo/blob/3859bee50e92d81e94f64ec4a3b3d4241978e8f5/modules/common_msgs/sensor_msgs/ins.proto#L8-L12
You can confirm whether carla sends these messages through cyber monitor.

The following is the code that prints the error
https://github.com/ApolloAuto/apollo/blob/3859bee50e92d81e94f64ec4a3b3d4241978e8f5/modules/localization/rtk/rtk_localization.cc#L206-L211
which means drivers::gnss::InsStat is missing pos_type
https://github.com/ApolloAuto/apollo/blob/3859bee50e92d81e94f64ec4a3b3d4241978e8f5/modules/common_msgs/sensor_msgs/ins.proto#L8-L12
You can confirm whether carla sends these messages through cyber monitor.

I check the topic /apollo/sensor/gnss/ins_stat and it is:

Is the error ins_status?

When I launch the rtk in the terminal, it will report this error: Cannot find Matching IMU. IMU messages too old. Newest timestamp[1.70685e+09], GPS timestamp[1.70685e+09]. Is it related to this error?


HydroTools Superpackage Release 2.2.3

This PR raises the minimum versions of subpackages pulled in by the hydrotools super package.
hydrotools.nwis_client>=3.2.1
hydrotools.nwm_client[gcp]>=5.0.3
hydrotools.events>=1.1.5
hydrotools.metrics>=1.2.3

Tested locally. All passed. Failing tests on GH are fixed in #169


Add more operational logging

Log more of the "failed" situations that the displays recover from (and those that it does not)

Added logging for all errors and most warnings.

Added logging in all placed where something abnormal happens.


protobuf support

_Fixes #365_
Changes proposed:

[x] Add
[ ] Prepare
[ ] Delete
[ ] Fix

Things I've done:

[x] I've pulled the latest master branch
[x] I've run npm install to install all the dependenies
[x] I've checked my code, it is clean.
[x] I've run ESLint.
[x] My pull request fixes an issue, I referenced the issue.
[x] My pull request is not too big, otherwise I've already squashed it.
[x] I've run npm run build to build the extension. (If I had done something with the extension.)

Using vscode 1.10.2 on Windows with vsicons 7.5.1 and viewing either .proto || .proto3 i'm not seeing the icon.  Can someone verify it works on there system?


solved an issue where missing dev depenencies were added to the list as None

PR Checklist

[ ] A description of the changes is added to the description of this PR.
[ ] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated

Description of changes

Codecov Report

Merging #99 (bc9fcd8) into main (f6d8a4b) will decrease coverage by 1.0%.
The diff coverage is 10.5%.

@@           Coverage Diff           @@
##            main     #99     +/-   ##
=======================================
- Coverage   95.7%   94.6%   -1.1%
=======================================
  Files         30      30
  Lines       1055    1068     +13
=======================================
+ Hits        1010    1011      +1
- Misses        45      57     +12

Impacted Files
Coverage Δ

deptry/issue_finders/misplaced_dev.py
24.3% <10.5%> (-9.1%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Inform via Log in case Sentry Requests Timeout or Fail

Problem Statement
Yesterday, we experienced Sentry requests that timed out after 5 seconds as also reported here: https://status.sentry.io/
This caused the Sentry CRON Monitors to report false positives as well as affected our response times as they increased by 5 seconds.
Unfortunately, it was hard to identify the root cause as Sentry did not report any issues (obviously) and the application logs did not show any errors or timeouts.
Solution Brainstorm
I would appreciate error logs coming from the Sentry SDK in case there is any issue with the Sentry requests. This would make it easier for us in the future to identify issues related to the Sentry tracking.

There is a reason we don't write our SDK logs to the Laravel log for example. There is a high probability this might cause an infinite loop where Sentry is reporting it's own logs which would be even worse.
We do have a logger setting where you can add one of our debug loggers or write one of you own to write SDK logs to a place of your choosing: https://docs.sentry.io/platforms/php/guides/laravel/configuration/options/#logger


Translate documentation to Dutch (NL)

Description

Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[x] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

Closing this PR as this has been taken care of in 6d239929dad467137a1d8ab0e40cee174304903e


gochimp support for handlebars

Currently, gochimp does not support handlebars templates with Mandril.   The interface assumes merge vars are string/string when in fact the API documentation stipulates they can be any json value. There is also no parameter to tell Mandril which rendering engine to use on a per message basis:
https://mandrillapp.com/api/docs/messages.JSON.html#method=send
http://blog.mandrill.com/handlebars-for-templates-and-dynamic-content.html

Hi @mattbaird , what do you think of this pull request? The MergeLanguage support seems good to me. And we need the support.
Thanks @jacksontbryan .


Streamlined workflows by minimizing clutter.

⚔ Things changed:
This PR primarily focuses on .github/workflows/python-publish.yml.

The workflow now only triggers upon manual dispatch / a successful published release (which the comments at the beginning said that it did but actually didn't).

The PyPI publish workflow doesn't require multiple dependencies / commands to be set up anymore. The build job uses the build Python package and the publishing workflow has been changed to the official one provided by the Python Packaging Authority.

Bumped dependency version for checking out source code.

Bumped dependency version for setting up Python.

🔖 To make this work:
Since the publishing workflow has been changed, you will need to remove these secrets from the repository:

PYPI_USERNAME
PYPI_PASSWORD

... and replace them with PYPI_API_TOKEN. This secret will contain a token provided by PyPI itself, which you can get from the Manage page of your project by clicking on "Create a token for project-name".
I hope this helps :D

@ranahaani Hope you'll have a look at this :D


Oop notes

I wasn't able to test it with hugo. It would be nice if someone could do this before merging the branch into the master.

I've made some hugo & stylistic fixes, and the PR looks mostly good.
However good you please clarify the sentence "which means that we have to check, if the 31st equals one"? I believe you mean either the first or second bit depending on whether one is numbering bits from one or from zero, since bits are usually numbered from least significant to most significant as far as I know.

Note that in the object header documentation we numbered bits starting at 0.

@Mr-Brownstone: could you please check the changes I made and reply to my comments?

This looks good to me, could you do a final @Felerius and then merge this?

Looks quite good, the few nitpicky comments aside. Should we maybe add a paragraph about how oops which have become invalid can happen (stacks/contexts)? I think it would be good to document that somewhere in our wiki, and I don't think we have written about that somewhere yet.


Calling (require 'ns) at the REPL should not trigger tests in ns

Circumvented by using
(binding [minitest/*currently-loading* true]
  (require '…))

@dustingetz :
the intent is to use the "eval buffer" intention to run tests
the current version monkey patches clojure.core/load , but it is not necessarily the only approach or the best approach
we could for example also monkey patch require to disable tests in that context

I think you want clojure.test/*load-tests* false

Should be fixed.
Eval (require 'ns) run tests because of eval mode
Eval file should not run tests in dependants, because of eval file mode

Should be fixed.
Eval (require 'ns) run tests because of eval mode
Eval file should not run tests in dependants, because of eval file mode

(require 'hyperfiddle.hfql20)
✅ (capI (fmapI inc (pureI 1))) := 2
...

(require 'hyperfiddle.hfql20)
✅ (capI (fmapI inc (pureI 1))) := 2
...


unknown field "replicas" in io.k8s.api.batch.v1.JobSpec, unknown field "serviceName" in io.k8s.api.batch.v1.JobSpec

Hi community. So, recently we planned to move to helm v3 from v2. Our application is using the solr helm chart that was written for helm v2. Right now I am trying to install this helm chart but it is showing this error:

The yaml file that it points to is "post-install-job.yaml". The particular line where this problem is :

I tried moving the "replicas" and "serviceName" below "template":

I also tried moving it inside "spec.template.spec" but the error more or less remains the same.
Is it some underlying issue or some other issue that I am unable to figure out. Please help.

The error you are getting is because "replicas" and "serviceName" are not part of the Job specification. The following Kubernetes docs will give you more details on the Job resource: https://kubernetes.io/docs/concepts/workloads/controllers/job/ and https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/job-v1/#JobSpec.
I am unaware of this solr Helm chart. I suggest checking with the maintainers of the chart to investigate the issue further.

But the helm chart uses these values currently in our old environment which has helm v2 and runs it without any errors. Why is  suddenly there an error in helm v3?

Got a few questions to try and understand the problem better:

What Kubernetes version is Helm 2 and Helm 3 deploying the chart to?
Are you using the same values and same chart version for Helm 2 and 3 deployment?
What is the URL to the Helm chat repo?

I am deploying the charts to Kubernetes version 1.17 with helm 2 and 1.20 with helm 3.
I am using the same values.yaml and chart.yaml version for helm 2 and helm 3 because helm 3 seems to guarantee backward compatibility(Best to my knowledge).
I can't really find the URL of the helm chart. This helm chart was not customized by me for our application rather by someone who is not in our team anymore. Meaning to say I can't find the source of this helm chart, atleast for now. I am in the process of finding about this, I am talking to my peers.
Anyways if right now I am unable to set a context properly which makes this question vague, I will talk to my peers and once I find something I will update this question with comments.. In the mean time if you think you can give me some lead I would be happy enough to take it.

@NavinKu10 If you can get more information especially around the chart this would help to troubleshoot the issue. At the moment, I can't identify what the issue might be.
Can you also try deploying the chart to Kubernetes 1.17 using Helm 3 and see what happens?

I can't deploy to Kubernetes  1.17 with helm 3 because that would mean changing to helm 3 in production cluster. We have a test kubernetes cluster with 1.20 and helm 3. This test cluster is where I am deploying our application and testing it.

Anyways, I will update you with more information. Apologies for keeping this thread open for some more time.

I can't deploy to Kubernetes 1.17 with helm 3 because that would mean changing to helm 3 in production cluster. We have a test kubernetes cluster with 1.20 and helm 3. This test cluster is where I am deploying our application and testing it.

It might be worth setting up a test cluster as you would then be able to perform like for like comparisons?

I think you are right about setting up a test cluster. But getting a test cluster requires ordering/cost factor and anyways our old cluster/production cluster is EOL and so we are going to upgrade it soon. That is exactly why I am redeploying our application in newer versions of helm and kubernetes in the test cluster that we ordered some time back.


Explore a .content class for broad margin changes and more

Capturing ideas from https://github.com/twbs/bootstrap/pull/29491#issuecomment-538315322.

I've been playing around with this lately, I came with a solution like this:
https://codepen.io/MartijnCuppens/pen/abzeBqP?editors=1100
What do you think?
/CC @ysds @ffoodd

Also related: https://github.com/twbs/bootstrap/issues/26716

@MartijnCuppens a few questions about this.
Specificity
Your pen will result in heavy specificity selectors (since :not() counts in specificity). Wouldn't something like the lobotomized owl selector be better for specificity?
Targets
You're also only targetting headings after non-headings, why? Consecutive paragraphs might have margin-top too since they'll collapse naturally with existing margin-bottom.
Values
Using rem for margin-top results in requiring each element to have its own delcaration block: by using really fluid values (like em or %) and assuming a fixed ratio between font-size and margin-top, a single declaration block could be sufficient.
Something like this could do the job:
.content > * + * {
  margin-top: 1.5em;
}

However I think it would be related to some kind of typographic scale, and for now it's not implemented this way in Bootstrap (since most values are kinda hardcoded in _variables.scss). There's no maths behind the typographic scale for now, but it could help a lot with this PR (it's much harder to implement though).
I'd love to see an incoming $typographic-scale-ratio in Bootstrap!
PS: please keep in mind that my three questions can be unrelated :)

You're also only targetting headings after non-headings, why?

I don't know, at some point in my life, I thought that was a brilliant idea.

Wouldn't something like the lobotomized owl selector be better for specificity?

Definitely
What do you think about removing the default margins form p tags and headings (and all other typographic elements)?
Made a second POC here: https://codepen.io/MartijnCuppens/pen/dyoOGdd?editors=1100
Switching to ems instead of rems feels like a good idea for paragraphs, but all headings are defined in rems.

I'd love to see an incoming $typographic-scale-ratio in Bootstrap!

Ok, what's that?

@MartijnCuppens Back to business :tada:
When using a typographic scale, every values are tight together depending on a single abitrary value: the ratio. For example, a base font size equivalent to 16px and a ratio of 2 will give the following scale: 16, 32, 64, 128, etc.
That's conceptually pretty close to what a grid is for layout.
This requires a few maths; there's tons of tools and documentation out there (recently, utopia.fyi, but you may find modularscale.com, type-scale.com, etc.).
On the design part, this ratio gives underneath meaning to the graphic design: ratio gives type depth, increases or decreases visual hierarchy, and may echo to some kind of cultural background too. It's really meaningful.
However it's not the common pattern, since a lot of graphic designers prefer to handle font-sizes "manually".
From a Bootstrap's point of view, coupling font sizes with a type scale ratio may lead to side effects (first of those would be less configurable font sizes).
You may find an example in Tachyons' type scale — they're using a 1.25 ratio.
I'm not sure I'm clear enough: explaining this in French is really easier to me :D
I love working this way, but I'm not sure it's suitable for Bootstrap.

No problem, I understand what you mean @ffoodd. We could implement the ratio, but  RFS will automatically rescale font sizes ignoring the ratio but keeping readability in mind.
Anyway, my idea was to tackle spacing issues with the .content class, not font sizes (these can be adjusted in reboot if needed).

@twbs/css-review, what are your thoughts on removing the margins from elements by default and use the .content class to control spacing between headings/paragraphs/tables/... ?
We use margin-bottom: 0 a lot in our code to remove these margins.

Seems reasonable, since those elements outside main content will likely to be in a custom layout (navbar, sidebar, footer…).
So it makes sense, I guess.


Linux compatibility

Does this core runs Linux on it?

Hello,
Can this core be able to run Linux on it?

I have not tested Linux boot-up on it yet. I assume not, as the Kernel would need I and A extensions to boot basic functionality.


Events:https://github.com/rainyt/OpenFLSpine/commit/fcbf0bee76aae3738a8baed2e5ccbadfe158f962
You can use it like this:
                 var event:AnimationEvent = new AnimationEvent();
		var spine:SkeletonAnimation;
		spine.state.addListener(event);
		event.addEventListener(SpineEvent.COMPLETE,(event:SpineEvent)->{

		});

You can update openfl-spine version 1.5.0

You are super cool :)


Install Laravel

Laravel
https://laravel.com/docs/5.7
Homestead
https://laravel.com/docs/5.7/homestead
DOCKER
https://ithelp.ithome.com.tw/articles/10188885
XAMPP
https://www.5balloons.info/install-laravel-5-7-xampp-windows/

XAMPP+WIN10
https://dometi.com.tw/blog/laravel-beginner-02/

I will try a new laravel project with npm,
and use xampp for future cooperation.

wamp.net can work!!!
@h20110213 Sorry that I forgot to check phpinfo() first.
In fact, both wamp.net and xampp are matched with Laravel requirement.


3 Bug fixes for the backend src folder

3 big fixes for the backend src folder with the descriptions in the commits below.

Closing this PR, because we don't need these changes.


fix(form-field): error when native select has no options

Fixes an error being thrown when there's a native select without any options inside a mat-form-field.
Fixes #14101.

Not to be a bother, but could someone merge these changes? There is a fix in this PR that will hopefully fix a breaking bug in my app. If there are some restrictions on why is hasn't been done yet, is there a nightly build with this fix implemented?


Repo Adoption

I'd be happy to adopt this project. I haven’t got any burning desire to expand on it's current feature set but I'd like to ensure it keeps working for people going forward so its not lost from quicklisp.

The same here, repo transfer has been requested.

Thankyou


Update Categories and Product components with improved styling and fu…

Pull Request Review
Pull Request Overview
This pull request implements enhancements to the Product component, focusing on visual presentation and responsiveness of the product cards.

Changes Made

Background Color:

The addition of a light background color enhances visibility and aesthetics.
Review: Consider testing different color shades to ensure accessibility and readability, especially for users with visual impairments.

Box Shadow:

The subtle box shadow effect successfully creates depth, distinguishing the product cards from the background.
Review: Ensure that the shadow effect is consistent across different browsers. You might want to check its appearance in both light and dark themes.

Fixed Dimensions:

Adjusting the container styles to maintain consistent dimensions is a smart choice to prevent layout shifts.
Review: It might be worth testing the behavior of the product cards on extremely small and large screens to ensure they scale appropriately.

Styling Enhancements:

The overall styling improvements contribute to better alignment and responsiveness.
Review: Consider utilizing CSS media queries for more granular control over styling on various devices, ensuring the product cards adapt seamlessly.

Code Changes

The update to the Container styled component looks good. The new styles for background color and box shadow enhance the component’s usability.
Maintaining fixed height and width properties is commendable, as it prevents layout shifts during rendering.
Review: Ensure to document any significant changes in a README or comments within the code to aid future developers in understanding the styling decisions.

Testing

Excellent work verifying the product cards' size and position across different screen sizes.
The hover effects and other interactions functioning as expected is a positive outcome.
Review: Consider adding automated tests to validate responsiveness and interactions if you haven't already.

Pull Request Comment
This pull request implements several enhancements to the Product component, significantly improving the visual presentation and responsiveness of the product cards. Key changes include:

Added a light background color for better visibility.
Implemented a subtle box shadow to create depth.
Maintained fixed dimensions to prevent layout shifts.
Enhanced overall styling for improved alignment and responsiveness.

The changes have been tested across various screen sizes to ensure consistency and functionality. Screenshots showcasing the updates will be added soon.
Great job on this update! Looking forward to your thoughts and any additional feedback.

Hi @saurabhbakolia,
I have addressed the enhancements outlined in issue #99. The pull request includes the following changes:

Added a light background color for improved visibility.
Implemented a subtle box shadow effect to create depth.
Adjusted the dimensions to maintain a consistent layout across different screen sizes.
Enhanced overall styling for better alignment and responsiveness.

Please review the changes at your convenience. I appreciate your feedback!
Thank you!

@saurabhbakolia please review it
#99 bug has been fixed

closed #99 completed via #114


Slightly obscured emails for SM companies

Woz always posts his email at least slightly obscured to prevent spam bots. Would be a shame if our post of his email here caused him to get spammed.

100%, thanks !


BLD: fixes for building with MSVC and Intel Fortran

These fixes are derived from gh-16957. That PR may take a while to land, so get this in to unblock users wanting to build with these compilers (xref gh-16988).

Failures are unrelated, this is good to go.

@andyfaff could you have another look?

This looks good to me, the icing on the cake would be #16957 to check that things are working.

This looks good to me, the icing on the cake would be #16957 to check that things are working.

Indeed, I won't forget about that. Fighting with Powershell isn't too much fun though, so I'm prioritizing use of MKL on other platforms and Intel Fortran on Linux - that should take care of most of the hiccups for Windows as well.


How to expand Max ConcurrentStreams on server?

In C#, gRPC 1.2.2, I've encounted freeze server program.
I found which is caused by the MaxConcurrentStreams option on the server.
// generated from "hellostreamingworld.proto"

public class ServerImpl : MultiGreeter.MultiGreeterBase
{
    static int serverRequestCount;

    public override async Task sayHello(HelloRequest request, IServerStreamWriter<HelloReply> responseStream, ServerCallContext context)
    {
        Console.WriteLine("Server:" + Interlocked.Increment(ref serverRequestCount));

        await Task.Delay(TimeSpan.FromSeconds(60));

        Console.WriteLine("Server:" + Interlocked.Decrement(ref serverRequestCount));
    }
}

class Program
{
    static void Main(string[] args)
    {
        if (args.Length == 0 || args[0] == "server")
        {
            // host server
            var server = new global::Grpc.Core.Server(new ChannelOption[]
            {
                // new ChannelOption(ChannelOptions.MaxConcurrentStreams, 99999)
            })
            {
                Services = { MultiGreeter.BindService(new ServerImpl()) },
                Ports = { new ServerPort("localhost", 12345, ServerCredentials.Insecure) }
            };

            server.Start();

            if (args.Length != 0)
            {
                Console.ReadLine();
            }
        }

        if (args.Length == 0 || args[0] == "client")
        {
            // client
            var channel = new Channel("localhost", 12345, ChannelCredentials.Insecure);

            var client = new MultiGreeter.MultiGreeterClient(channel);

            var tasks = Enumerable.Range(1, 10000).Select(async x =>
            {
                Console.WriteLine("client call: " + x);
                var streaming = client.sayHello(new HelloRequest());
                await streaming.ResponseStream.MoveNext();
            });

            Task.WaitAll(tasks.ToArray());
        }
    }
}

This program shows following result.

The server is limited to 8000 subscriptions.
I try to use ChannelOptions.MaxConcurrentStreams to expand this limitation,
If value is under 8000 that works but over 8000 does not work, the limit remained at 8000.
My environment is 8 core CPU so maybe 8000 is processor count * 1000?
In my system, each client subscribes to nearly 20 ServerStreaming.
That Subscribe will be used for more than 10 minutes.
In this state, the limit of one server will be only 400 clients.
This is too little!
How to expand Max ConcurrentStreams on server?

My theory is that this is related to value of Server.RequestCallTokensPerCompletionQueue.
To prevent flooding of a server, new calls on the server side are accepted via a request, by default, there is 2000 request "tokens" per completion queue. A new token is only added when a call finishes.
In your case, with streaming call, you seem to be running out of tokens. Try setting Server.RequestCallTokensPerCompletionQueue in additions to MaxConcurrentStreams
The relevant code is here:
https://github.com/grpc/grpc/blob/f6a63a2f96f8be1053e9d0cbcc429bfd4738b567/src/csharp/Grpc.Core/Server.cs#L139
Please let me know if it helped.

Thank you, your answer is perfect.
My application works fine.
I think how many RequestCallTokensPerCompletionQueue should be set.
If subscribe per connection is 20,
concurrentConnectionLimit = RequestCallTokensPerCompletionQueue * ThreadPoolSize / 20
If 8 Core CPU(threadpool size = 4) and target to 10000 concurrent user,
RequestCallTokensPerCompletionQueue will be 50000.
However, if set to 50000, the server did not start up.
I'll do GrpcEnvironment.SetThreadPoolSize(16) and RequestCallTokensPerCompletionQueue = 20000.
Is this decision OK?

It's really hard to guess what the right setting for your situations are without knowing a lot of context.
But a few notes:

It probably doesn't make sense to have more than 8 threads in the threadpool on 8core cpu (because they will be fighting over resources).
set RequestCallTokensPerCompletion queue to whatever you need (the only tradeoff is that each token will occupy some small amount of memory and will be initialized at startup and disposed at shutdown (that that's probably not even noticeable to you).

@jtattermusch I encountered the same problem of 8000-streams limitation (C# server), and luckily found this thread.
First, it appears the RequestCallTokensPerCompletionQueue is limited to 32768 == 2^15 (SHRT_MAX+1). Any value above that results the server to hang and consume very high CPU. Is it by design or a bug? (after all, this value is defined as int)
Second, besides the limitation described above, is there any other limitation for the max-tokens value? Or is it just "logical" limitation which can be increased as much as we want?
Third, it will be better, in my opinion, to document this value better, for others who might be interested in using it.
Thanks!

On Wed, Aug 30, 2017 at 8:54 AM, amitwaisel<EMAIL_ADDRESS>wrote:

@jtattermusch https://github.com/jtattermusch I encountered the same
problem of 8000-streams limitation (C# server), and luckily found this
thread.
First, it appears the RequestCallTokensPerCompletionQueue is limited to 32768
== 2^15 (SHRT_MAX+1). Any value above that results the server to hang and
consume very high CPU. Is it by design or a bug? (after all, this value is
defined as int)

No, the server shouldn't hang. Can you provide more info what the
conditions is (it might be a bug)?   Also  getting 32000 tokens per
completion queue while having more completion queues (you can have 1 per
thread) can actually give you a large number of concurrent calls (256000
for 8 threads which seems pretty high) - how many do you need?

Second, besides the limitation described above, is there any other
limitation for the max-tokens value? Or is it just "logical" limitation
which can be increased as much as we want?

No, it's just logical and each token also allocates some memory (~ several
hundreds of bytes each).

Third, it will be better, in my opinion, to document this value better,
for others who might be interested in using it.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/issues/10534#issuecomment-325899778, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJeq5G_ozx8PHlzw_E4BjmtxLSK7BMXnks5sdQcZgaJpZM4M3wuh
.

--
Jan

In my C# code, I initialize two Grpc.Core.Server instances (on different TCP ports). For each of them, I am required to support (very) high number of opened gRPC streams (those are for pending requests, and there can be hundreds of thousands of those).
Therefore, I do the following:
_server1.RequestCallTokensPerCompletionQueue = 32768;  // Total 32K * 4 (vProc/2) == 128K streams
_server2.RequestCallTokensPerCompletionQueue = 32768;  // Total 32K * 4 (vProc/2) == 128K streams

Just to clarify, I do not change the thread pool size (GrpcEnvironment.SetThreadPoolSize) or the completion queue count (SetCompletionQueueCount).
As far as I can check, whenever I increment the count to 32769 (from 32768), the server does not response to all incoming requests (if to any at all), and one of the thread's CPU consumption is at 100% (for that thread). Meaning, on 8-cores machine, with 2 servers initialized, my process constantly has 25% CPU usage (2 threads, 12.5% overall CPU each).
Do you think it is related to having two servers on the same gRPC environment?
I hope this helps.

@sreecha   is there a limit on number of request_call operations per cq in C core (right now it seems to be 32768)? If so, is that intended or is it a bug?

@jtattermusch , this is by design (because we need storage to reserve those many available-request-ids per server-completion-queue and when the number of server-completion-queues is already high, this quickly adds up).
I am not sure of the C# api... but generally this is what the server (user of grpc-c-core library) should be doing for each RPC 'Foo':

grpc_server_request_call(..) a few times (each call will reserve a 'token') [atleast once - lets say we called "x" times - so we have "x" tokens available]
When grpc-c-core receives an incoming request, it uses up one of the 'token' it allocated from the step above. So the number of tokens is "x-1"
The higher layer should call grpc_server_request_call(..) again ASAP (good practice is to do this before it even started  as it started (not completed) processing a request for 'Foo') to give back the 'token'. So that we maintain "x" available tokens.

So the number "x" is really the max number of requests you are expecting to hit the server all at the same time..  and NOT the max number of concurrent requests the server can handle at the same time.


fix: add workaround for macos-build blocker

chore: bump version

👍 I dig it. I thought the Mac build was all or nothing, but if isn't and this allows you to get something out the door, then nice thinking!

Not waiting for the build to complete to see if it fixes things. Living on the edge!


Pre trained weights

Hello,
Thank you for sharing code for the paper. Could you please share weights on google drive or any other hosting that doesn't require baidu account? I'm having problems downloading it from outside of China.

Will release the weights on google drive.

You can download weights at this link: link


Any way to generate events on receipt of PUBACK or PUBREC packets?

To prove that a subscribed client received the message from a server, it would be nice if the server could raise a event indicating a PUBACK in QOS1 or PUBREC in QOS2 was received. Mostly used for logging. Is this something that could be added to the MqttServer?

So you mean just a plain event (probably containing the application message and client ID as a property) which is fired after every ACK and PUBREC?

Yeah, that would be perfect.

When the client connects, I will publish a message with the client's ID and human-readable identifier to the server, storing it in a hashtable. Then when an ACK or PUBREC packet arrives, I can look up the human-readable identifier in the hashtable to display in a log with the topic and payload. This should prove that the client acknowledged receipt of the message from the server.

What's the status of this?

I added this feature and it will be release with version 4.1.x.


Read data is being cut while over 20 bytes

Hello
I'm working on a project in which I decided to implement the FastBle library as I found it very helpful. Unfortunately, I got to the point of reading data. Everything works perfect until the data to read doesn't excess 20 bytes. In such case, i only receive the last 20 bytes, and the beginning of data disappears. I found Issues here about the 20 bytes, but they only concerned writing data, not reading.
Is there any way of solving this problem? I would be very grateful for any suggestions.

I have also encountered this problem. Have you resolved it


fix(connectors): Native type mapping cleanup

Unify to tocDepth:3
Unify table headers
Unify headlines before tables
Unify order in Native type mapping from Prisma to x tables

Evolution in PostgreSQL (for now):

Fix grammar in main headline (##)
Move first introduction (`The PostgreSQL connector maps the ...) to correct headline and table
Add new introduction sentence
New headlines (###) for both tables
Change column order in second table: Postgres, support, then Prisma

Overall I think these pages are missing a "Prisma types" page they can link to that explains what exactly is going on here. Lucy had created a guide like page, but that is also not optimal. We need something more fundamental here.

General question: Should this information live in "Concepts" or "Reference"?
We have similar information on this page (for all connectors): https://www.prisma.io/docs/reference/api-reference/prisma-schema-reference#model-field-scalar-types.
Alternative suggestion: We move this content to the Prisma schema reference into 5 separate pages (for each database provider we support). There is some duplication of the content, and we can improve it further by linking out to a page in the "Prisma schema reference" from "Concepts" (Native type-mapping).

Feel free to open an issue about that @ruheni. I will not move this content around in this PR.

Please take over the TODOs here @jharrell @ruheni and ping me for review when suggested or committed. Thanks.

I finished the TODOs myself.


Importing from Bear backup crashes Obsidian

After using the importer to open a Bear backup (as per https://help.obsidian.md/import/bear) the app initially seems to do something (black box with some stats) but very quickly goes to a grey box where it hangs.

Hello,
Can you please attempt the import again in a fresh vault? Maybe test again with a different Bear export?
If you are able to reproduce the issue, please provide us with more information about your Bear export so we can track down the issue.
Thank you.

I have tried more than 5 times with different data sets. The last resulted in another issue I have raised re. duplicate image corruption on import. At this stage in think I'll just stick with Bear.

Hi @ilium007, there have been some fixes recently for handling attachment importing from Bear exports. Please let us know if these resolve the issue you were running into. Thanks!


Is representable_attrs intended to be part of the public API?

I've run into a situation where the representable_attrs method on one of my decorators is public in a rails console but private in the test suite. It looks like this is due to an inconsistent load order. My class inherits from Representable::Decorator.
In the test suite my class has the method implemented in the Representable module:
> @resource_klass.method(:representable_attrs).source_location
=> ["/Users/dvogel/.rvm/gems/ruby-2.2.1/gems/representable-3.0.0/lib/representable.rb", 94]

That method is indeed private, with the private block of that module beginning on line 31. However, in a rails console my class has the method implemented in the Representable::Declarative module:
> @resource_klass.method(:representable_attrs).source_location
=> ["/Users/dvogel/.rvm/gems/ruby-2.2.1/bundler/gems/representable-830f2ceb7fed/lib/representable/declarative.rb", 61]

That method is public. I'm left unsure which implementation of that method I should expect to have and whether or not I should expect to be able to rely on representable_attrs.
I've written a small test case that makes me suspect that the method is intended to be public. On the other hand, it is not mentioned in the documentation.

I'm sorry to have included a red herring in this report. The path differences, showing the release version versus the git checkout, are meaningless. I simply copy/pasted from before/after switching to a git checkout of one commit past the release:
> git log 830f2ceb7fed
commit 830f2ceb7feddef1f181952d878f22623c4a431b
Author: Nick Sutterer<EMAIL_ADDRESS>Date:   Tue Jan 19 17:37:36 2016 +1100

    newsletter.

commit 0ac4a8855c71240c813bb1b70c44961d4909d42b
Author: Nick Sutterer<EMAIL_ADDRESS>Date:   Sun Dec 20 10:27:59 2015 +1100

    releasing 3.0.0.

Nevermind, I've found my mistake.
I see now that the private method is an instance method while the public method is a class method. That was due to a silly auto-complete usage on my part.


Mobs added after 1.12 such as Drowned are not in the Disguise part of the Editor [Enhancement]

The Disguise function in the editor for SkillAPI is missing any mobs added in 1.13, 14, 15, etc.

I remade the data generator in Java instead of Python, and also added missing projectile types to Launch Trigger and Projectile Mechanic along with the missing disguises.


intuition behind Outlook Attention Generation seems does not make sense

Hi,
Thanks for your work.
As your claimed, the generated $W_A$ can work as the weight to aggregate the local context.
However, $W_A$ is generated by a Linear operation along the channel dimension, which indicates the Receptive Field is 1. The neighboring context can not be perceived during the $W_A$ generation process.
Thus, how can $W_A$ encode the relationship information?

Hi, your doubt is reasonable. However, there are some explanations to that. First, the input are forwarded into a PatchEmbed, so the Receptive Field after the PatchEmbed is patchsize, and therefore inside W_A is encoded with neighborhood context. For that you can refer to Involution (https://arxiv.org/abs/2103.06255) for detials. By the way you can also refer to #1 to join the discussion about the difference between Incolution and the Outlokk attention.

Hi,
The local context aggregation is conducted in the value projection operation. The attention weights are generated by a linear but an unfold operation is operated on the value tensor. Check that in Eq. 4 in the paper.

Hi thank you for your paper and congrats on SOTA.
I have a question related to this, from the linear projection we generate an attention map for each of pixel with in the local neighborhood. In the fold operation we are summing these weighted averages so is it not sufficient to use a singular K^2 weighting across the entire neighborhood followed by a softmax? There should only be minor differences because the current method is taking softmax multiple times and The other only does it once?
thank you

@monney I believe that the K is the Kernel_Size, so there are K^2 tokens in a KxK window, therefore there needs a (K^2)^2 attention weight to model all-pair relationships as in the standard self-attention. >_<

Thank you for your reply.
@Andrew-Qibin

The attention weights are generated by a linear but an unfold operation is operated on the value tensor.

My concern is the attention weights. They represent the importance of the local context when doing aggregation.  So, they should natually have seen the local context. As you said, they are generated by a linear operation.  They never get access to local context. How can they know the importance.

Hi thank you for your paper and congrats on SOTA.
I have a question related to this, from the linear projection we generate an attention map for each of pixel with in the local neighborhood. In the fold operation we are summing these weighted averages so is it not sufficient to use a singular K^2 weighting across the entire neighborhood followed by a softmax? There should only be minor differences because the current method is taking softmax multiple times and The other only does it once right?
thank you

@monney  has given the correct answer. By the way, another advantage of our outlooker is that you can introduce stride in unfold which allows us to run faster with no sacrifice on accuracy performance.

@Andrew-Qibin I think the main question here is that since the attention matrix does not use similarity scores in it’s generation, the attention scores are only based on central pixel.
My question related, since this is summed to single position i,j it should be sufficient to have a single attention matrix across the entire patch instead of one for each pixel. I’m just curious if this was tried or if there’s a reason for generated an attention map for each pixel and then aggregating later.

Agree with @monney
Only central pixel is considered in the attention weight generation process. How can they represent the importance of neighboring context?

@toodle I think because of #7 the weights end up being based on the KxK pixels at least indirectly, aggregating from 2K-1x2K-1 surrounding pixels. It differs from traditional attention though and is definitely more similar to a dynamic conv I think.

@monney Thanks.  Agree with your opinon on Dynamic Conv as discussed in https://github.com/sail-sg/volo/issues/5

@monney I understand that surrounding pixel can be aggregated bu Unfold operation.
However, my focus is the attention weights becuase attention weights do not get surrouding information.
I admit it works well from the experimental results but the story  is not fine.

@toodle I agree with you. The attention weights don’t take the similarity between the pixels into account, this to me is the key piece of attention. But the way they are generated the attention maps actually do end up taking into account every pixels value into account. Specifically since each central pixel generates a map for the surrounding pixels, and you fold across them, it ends up being roughly equivalent to if the attention maps were generated by a fully connected layer across all the KxK pixels.

Does that make sense if operating the unfold operation on the attention tensor to catch some local contexts?

Does that make sense if operating the unfold operation on the attention tensor to catch some local contexts?


Gdynia open data

[X] My submission is formatted according to the guidelines in the contributing guide
[X] My addition is ordered alphabetically
[X] My submission has a useful description
[X] The description does not have more than 100 characters
[X] The description does not end with punctuation
[X] Each table column is padded with one space on either side
[X] I have searched the repository for any relevant issues or pull requests
[X] Any category I am creating has the minimum requirement of 3 items
[X] All changes have been squashed into a single commit

The website is only partially in English, the main language is Polish.

Hmm,I don't see the problem you're writing about, it's two separate pages and data. :)

Hmm,I don't see the problem you're writing about, it's two separate pages and data. :)

I just rechecked it and noticed I made a mistake in my review.
I was always checking the API Docs link and not the API (which apparently is the correct one). I noticed that the API link takes you to a site-exclusive API.

API Docs leads to a project that various governments use to make their data available.
Sorry about that @olekstomek, I will correct in all PRs that I made this same mistake.


Bring vertex input in line with other pipeline state, reorganise modules

Remove this from the changelog:
- **Breaking** Major changes have been made to most parts of the graphics pipeline state.
  - Each state category is now provided by a separate type ending in `State` that lives in its own submodule of `pipeline`. Some of these were existing types that were renamed.
  - Most of the state-setting methods on `GraphicsPipelineBuilder` are deprecated. State is now set using a `_state` method, which is given one of the above state types.

And replace it with:
- **Breaking** The modules `compute_pipeline` and `graphics_pipeline` are shortened to `compute` and `graphics`, and are now public.
- **Breaking** `ComputePipeline`, `GraphicsPipeline` and `PipelineLayout` are re-exported from the base `pipeline` module, but other items are not.
- **Breaking** Major changes have been made to most parts of the graphics pipeline state.
  - Each state category is now provided by a separate type ending in `State` that lives in its own submodule of `graphics`. Some of these were existing types that were renamed.
  - Most of the state-setting methods on `GraphicsPipelineBuilder` are deprecated. State is now set using a `_state` method, which is given one of the above state types.
- **Breaking** `ShaderInterfaceEntry` now contains the start `location` and `component`, and specifies its type using a new `ty` member instead of as a format.

This PR brings vertex input state in line with the changes that were made in #1724. I've also reorganised the modules a bit, so that the modules for each state type are placed under graphics instead of directly in pipeline. This should make it neater when ray tracing pipelines are introduced. I've included some new documentation as well, especially for the graphics and vertex_input modules.
While working on this, I came across a few existing shortcomings that need to be addressed in future PRs:

Specifying shader interface entries using a general numeric type instead of a Format, and allowing more flexible matching between shader and attribute format. This is issue #1667, and requires refactoring the Vertex trait and the code in BuffersDefinition.
Allowing multiple variables to share a location, using the component decoration. This is made possible with VertexInputState as introduced in this PR, but it is not supported when using BuffersDefinition. It also requires rethinking of the Vertex trait.
64-bit input values. Because they take up two components per value, and must be matched exactly by the attribute format, they need special care. Unfortunately, my graphics driver doesn't support these at the moment, so I am unable to test it.

@Rua PR looks good. I didn't detect any issues or regressions. Merged. :+1:
It's taking longer to review, than it normally should, and I appreciate your patience. I plan to improve this situation from the next year, when I will have more time to be dedicated for the project.


Kernel restating while importing tensorflow on Old Macs, works OK on new one.

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
Describe the expected behavior
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Hello,
I am installing Tensorflow according to the Jeff Heaton. On an iMac mid-2010 with 2,93 GHz Core i7, 12GB RAM, the installation of the whole packages is OK, I can start jupyter. Than, when I want to import tensorflow as tf, the kernel restarts... I have tried it on the same host in a Parallels Virtual Machine configured with MacOS 10.13.6, same behavior. Than I have installed the same softare stack in a clean VM (VirtualBox) running Ubuntu 18.04, same behavior.
On a MacBook Pro Retina 2012, everything works. On an older MacBook Pro 17" mid-2010, Core i5, the problem is present too.
Any clue ?
Thanks for you help,
Thierry

@Tj85710, Please follow the instructions mentioned in the Tensorflow website to install Tensorflow,select the mac os.Thanks!

I have found references to this behaviour : My processors are too old, they don't support the AVX instruction set. I am building a VM with Ubuntu, 8 Xeon cores, 40 GB RAM and try to build a custom version with the correct --march flag.
Cross fingers !
Thanks for your answer,
Thierry


[stable/nats] Use bitnami/nats-exporter

Signed-off-by: Andrés Bono<EMAIL_ADDRESS>What this PR does / why we need it:
This PR substitutes the image for the NATS Prometheus exporter.
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @carrodher

/ok-to-test
/lgtm


Cancel in-progress gradle check workflow on new push

Description
Gradle checks take 30+ minutes to complete. It is quite common to push a commit to a PR, then quickly discover a new change is needed and push an updated commit, which results in two workflows running and both post a result comment to the PR. By deduping and canceling we will reduce load on the GitHub action runner (probably not on the Jenkins server unless the cancellation can propagate to Jenkins) and reduce noise on the PR.
Note I took this implementation from the suggestion on this stack overflow question.
Related Issues
Relates #9699
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Any reason not to try to figure out how to propagate the cancelation to Jenkins as part of this PR? There's an active wait loop in there that polls Jenkins, there's got to be a way to detect an abort and hit the Jenkins API?

I would rather we don't cancel/prevent inflight runs, while they might not always be useful it can save time.

@peternied Are you suggesting we don't do this at all, or that we don't propagate the cancellation to the Jenkins server? My primary motivation here is to prevent the GitHub action from posting a result (success or failure) on the PR for a commit that has been superseded by a new commit and therefore is no longer relevant.

My primary motivation here is to prevent the GitHub action from posting a result (success or failure) on the PR for a commit that has been superseded by a new commit and therefore is no longer relevant.

This is also my concern.  I often submit an update before the initial run finishes, and waste time trying to figure out why my new update failed, when it's just a lagged status from the previous run.
I don't mind Jenkins continuing to run and adding to the flaky test database of failures.

Are you suggesting we don't do this at all, or that we don't propagate the cancellation to the Jenkins server

Yes, I don't think we should do anything - I am curious what the harm of doing nothing.  I think it is beneficial to run our tests as often as we have opportunities to discover flaky tests.
Multiple comments, we have the same problem with compatibility checks, which I think is slightly mitigated by including the SHA on the comment.   If this is about pull request experience, could we make the experience better and keep the previous run results?
Maybe reuse or add/remove status comments instead?  Codecov for an example reuses the same comment and updates it as more results come back associated with a PR.  I'm not sure the complexity, but I wouldn't mind a single comment with the 'current' status and a bunch of links to previous runs.

If this is about pull request experience, could we make the experience better and keep the previous run results?
Maybe reuse or add/remove status comments instead?

This suffers from the same issue of getting an update a long while after submission that gives no indication it's not the most recent commit.
If we want to post previous run failures, is it possible to check if the commit associated with the Jenkins run is the current HEAD on the PR, and simply post a line at the top of the comment, "This run was for a previous commit" or the like?

(Or even simpler, just always add a line on the Jenkins comments giving the sha of the commit it's associated with, and the commit title.)

If this is about pull request experience, could we make the experience better and keep the previous run results?

@peternied Yes, we can do that. I just opened #9954 to make the "check compatibility" task behavior the same way as codecov with regard to updating a single comment. We can do the same thing with gradle check as well. This will greatly cut down on noise in the PR comment feed and improve the experience in my opinion.

I am curious what the harm of doing nothing. I think it is beneficial to run our tests as often as we have opportunities to discover flaky tests.

Lacking opportunities to discover flaky tests is decidedly not a problem that exists today :) There is no real harm in allowing obsolete workflow runs to proceed to completion that I'm aware of (other than increased compute resource usage). However, personally I would rather not to have to deal with test results for a commit that was never intended to be shipped even if the noise is minimized.

(Or even simpler, just always add a line on the Jenkins comments giving the sha of the commit it's associated with, and the commit title.)

@dbwiddis I believe all of our automated comments (Gradle Check, Check Compatibility, and Codecov) already include the sha of the commit that was tested.

Yes, I don't think we should do anything - I am curious what the harm of doing nothing. I think it is beneficial to run our tests as often as we have opportunities to discover flaky tests.

@andrross to the @peternied and @dblock points, the Gradle check is implemented on Jenkins and without propagating the cancellation to Jenkins there is limited value in cancelling it (we would release the Github worker very likely), the Jenkins is the real cost and bottleneck.
The real issue with current approach though, at least to me, is that by cancelling the GH, the status of still-running Jenkins check will be lost and would never make it into pull request (nonetheless it was running after the cancellation). Often flaky new tests surface after that.

We've got a couple votes in favor of the status quo, so I'm closing this.


Deprecate old installer flow

Signed-off-by: Shubham<EMAIL_ADDRESS>What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Additional information
Special notes for your reviewer

Codecov Report

Merging #4 (7c9ed63) into main (48833a2) will decrease coverage by 0.06%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   67.75%   67.69%   -0.07%
==========================================
  Files          26       26
  Lines        2388     2343      -45
==========================================
- Hits         1618     1586      -32
+ Misses        662      649      -13
  Partials      108      108

Impacted Files
Coverage Δ

agent/main.go
22.15% <0.00%> (+1.31%)
:arrow_up:

agent/reconciler/host_reconciler.go
79.62% <100.00%> (-1.36%)
:arrow_down:

Codecov Report

Merging #4 (c424da3) into main (48833a2) will increase coverage by 1.46%.
The diff coverage is 89.06%.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   67.75%   69.21%   +1.46%
==========================================
  Files          26       18       -8
  Lines        2388     1881     -507
==========================================
- Hits         1618     1302     -316
+ Misses        662      476     -186
+ Partials      108      103       -5

Impacted Files
Coverage Δ

agent/main.go
22.15% <0.00%> (+1.31%)
:arrow_up:

agent/cloudinit/file_writer.go
53.84% <100.00%> (+24.61%)
:arrow_up:

agent/reconciler/host_reconciler.go
81.48% <100.00%> (+0.49%)
:arrow_up:

...rs/infrastructure/k8sinstallerconfig_controller.go
83.24% <100.00%> (ø)

installer/bundle_downloader.go
72.63% <100.00%> (ø)

installer/installer.go
100.00% <100.00%> (ø)

installer/registry.go
100.00% <100.00%> (ø)

... and 3 more


Set payment notification fundingTotal to CurrencyValue

close #1809

Coverage remained the same at 41.027% when pulling 2067e236f2e41a130017ad23f419cd90cd708d0c on paymentnotif into b5b1cf40df7c9f7c16bbbad2f85276b40b6d1abc on ethereum-master.


Add rule for the C.R.A.P. Index

Short description
It would be nice to provide a rule that checks the C.R.A.P. Index[1] of methods and functions and reports those artifacts with critical values.
[1] http://www.artima.com/weblogs/viewpost.jsp?thread=210575
[Synced from PivotalTracker: 'http://www.pivotaltracker.com/story/show/9355967']

@manuelpichler reopen this if you stronlgy feel about this feature but I don't really see it.


SARS-CoV-2

@finersarah added CPRD GOLD code list for SARS-CoV-2.
CPRD_SARS_CoV2.xlsx

@f-eto
I have been through the list of COVID codes and classified as:

Confirmed - if code suggestive of positive COVID test.  Or code suggest definitive complication of COVID (e.g. myocarditis caused by COVID-19 infection).
Suspected if codes suggests a clinical diagnosis in the absence of confirmatory testing.  These were likely to be commonly used at the start of the pandemic when testing was not available.
Other for all codes related to advice/negative tests.

Please note that at this stage I have not differentiated between acute and long COVID.  But can as needed.
For the sake of identifying patients who have had COVID I would probably combine 'suspected' and 'confirmed' (as testing was not available at the start of the first wave).

CPRD_Aurum_SARS_CoV2.csv

As above with GOLD data.
There are three codes (left blank) that I wondered if had been cut off.  The descriptive term does not seem complete?
CPRD_GOLD_SARS_CoV2.csv

Thank you for this @Miriam-S-git.
@finersarah should we use only the confirmed codes to identify COVID-19 in the data?

@f-eto @finersarah
Just to reiterate.  I cannot be sure that all the cases I marked as 'confirmed' have had a positive PCR.  These are just the codes that seemed to suggest a definitive diagnosis (including those for a positive test).
The 'suspected' cases are the codes for 'clinically suspected'.  But during the first wave of the pandemic, there was very little COVID testing in primary care available.  So test positive cases would only have been those who went to hospitals or were key workers.


View height issue with Shrink mod

When using the Shrink mod (https://www.curseforge.com/minecraft/mc-mods/shrink_) the option to change the first person view height based on character scale does not work. It only takes effect while crouching but standing returns your view height to its regular height. Is it possible to get that fixed?

Should be fixable, I'll look into it.


Gradual memory leak with fetch (iOS only)

I noticed my application, which relies on periodic polling, has a memory footprint that grows consitently over time. I've vetted it for any global leaks and decided to scale down the scenario with a new project that runs a single fetch on an interval and observed the same behavior in steady growth. Android remained flat with no growth after releasing resources.
Note: this is in release mode, dev=false

The component does one thing -- a fetch every second and updates the state with a counter.
class NetworkTesting extends Component {
  constructor(props) {
    super(props);
    this.state = {value: 1};
  }
  componentDidMount() {
    this.fetchInterval = setInterval(() => {
      fetch('https://www.google.com')
        .then(() => {
          this.state.value++;
          this.setState(this.state);
        });
    }, 1000);
  }
  componentWillUnmount() {
    clearInterval(this.fetchInterval);
  }
  render() {
    return (
      <View style={styles.container}>
        <Text style={styles.welcome}>
          {this.state.value}
        </Text>
      </View>
    );
  }
}

Here's a peak at the allocation instrument

At around 5 hours in the footprint is over 6x what it initially was:

Here's a breakdown over time, I will continue to update it over the next few hours:

Initially: ~25 MB
3 mins: 27MB
15 mins: 30 MB
45 mins: 45 MB
60 mins: 53 MB
75 mins: 61.5 MB
90 mins: 72 MB
120 mins: 84 MB
150 mins: 98 MB
170 mins: 111 MB
210 mins: 131 MB
225 mins: 141 MB
300 mins : 182 MB

This is seen in 0.15.0, however I believe this is is separate than that of https://github.com/facebook/react-native/issues/4538

Wondering if this is something that @nicklockwood might have some thoughts towards

I've tested this a couple more times.

With 0.17.0-rc, which includes the fix for #4538
Without fetch and simply with a setInterval that updates the state.

Both of these have a gradual rise in memory. Without fetch, the increase is much smaller, but it still grows over time. The rise in memory also still exists in 0.17.0-rc with dev=false

Also discussed at https://github.com/facebook/react-native/issues/4730

Thanks for the cross ref, there's a few threads open and I haven't seen this one yet.

After retesting these cases in release mode, I can confirm that this is not a problem and only exists when running in debug mode.
:tada:


kie-issues#667: fix cleanup and settingsXml handling

After #3009
apache/incubator-kie-issues#667
Fixing cleanup and settings.xml pipeline configuration to work correctly in ASF Jenkins.

Deferred wipeout was causing issues when invoked in early stages
Docker cleanup can't be done since the overall build is in docker container that uses the docker.sock from the host - it would attempt to erase itself.
withSettingsXmlId shared library method does imply usage of a prohibited groovy method, thus replacing with explicit configFileProvider and passing as withSettingsXmlFile goes around that part of code.

Complete list:
apache/incubator-kie-kogito-pipelines#1113
apache/incubator-kie-kogito-runtimes#3272
apache/incubator-kie-kogito-apps#1909
apache/incubator-kie-kogito-examples#1820
apache/incubator-kie-drools#5572
apache/incubator-kie-optaplanner#3010
apache/incubator-kie-optaplanner-quickstarts#613
apache/incubator-kie-kogito-docs#514
apache/incubator-kie-docs#4531
apache/incubator-kie-benchmarks#273

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-optaplanner/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-optaplanner -u https://github.com/apache/incubator-kie-optaplanner/pull/3010 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/optaplanner/job/main/job/pullrequest_jobs/job/optaplanner-pr/job/PR-3010/1/display/redirect
Test results:

PASSED: 5173
FAILED: 1

Those are the test failures:

org.optaplanner.core.config.solver.SolverConfigMultiThreadedTest.solvingWithTooHighThreadCountFinishes
solvingWithTooHighThreadCountFinishes() timed out after 5 seconds


Update French Translation

Sorry for the delay. I just did a minor fix to replace "Analytiques" which sounded weird. (I'm french btw )
I sort of hesitated to merge this because the translations were already ok, but they are now closest to the english reference.
Thanks for the PR !


[in_app_purchase] Update to use google play obfuscatedAccountId

The google play API has changed and now ignores the accountId parameter
in the billing flow. It has been replaced by obfuscatedAccountId.
Pass applicationUserName through as obfuscatedAccountId rather than accountId
To use this com.android.billingclient:billing had to be updated to 2.2.0
(3.0.0 is available, but that has some breaking API changes)
The obfuscatedAccountId is not visible in BillingFlowParams, so the tests have been adjusted to match
Description
With this change the obfuscatedAccountId shows up in the server to server messages from google triggered by purchases
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR. (well, no new problems)
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

I have another commit to update the billingclient dependency to 3.0.0 and drop no longer supported developerPayload, but I figured I'd try to keep the number of moving parts to a minimum for this fix :)


forceKillChrome() creates Core Dump Files

It appears that the forceKillChrome() method in:
https://github.com/GoogleChrome/puppeteer/blob/47481967c5344dc0ca17ebaf4bd3d9650da771d0/lib/Launcher.js#L177-L195
Results in a core dump file (~16MB) being created on every shutdown, likely because of SIGKILL.
In environments like AWS Lambda where disk space is severely limited, this can become problematic.
It would be nice if Chromium would be closed gracefully, but I don't know if this is even an option.

This seems to affect only AWS Lambda environment.

@alixaxel do you know how to force kill the process, without using an external library? also, I'm interested in turn off core dump files since they are not useful on production scenarios.


[new-product] Google Nexus

@BiNZGi
Do you think that it is ready to be merged?

The preview page https://deploy-preview-4332--endoflife-date.netlify.app/google-nexus returns 404. I have to investigate in the next days and do the review...

Thanks for this contribution @WebSnke. Did not check the dates / supportedAndroidVersions yet, but here are my first comments and suggestions.

Thanks for your suggestions. I will commit them soon.

Is it ready to be merged?


Question. How to collect data from Google Analytics aggregated ...

How to collect data from Google Analytics aggregated by month, for example, to get results by month/day/year?

I mean its return data only per day in period. I want to get this metrics in total period, because sum of days will be different, because of google ga logics.

query mode : table
metrics : active users
dimension : month
Please set it up as above

Additionally, the aggregation feature is supported by google analytics api, but it is not currently supported by the plug in, so it is not available.

There is no response, so I will end it.
If you need it, please open it later


Switch internal data type from torch to numpy

Some issues I ran into

CUE-specs using lambda_str so far relied on torch operations - need to be updated, and import numpy as np probably should be added in built_in_registrations.py
Alignment inference modules, such as the BaseCoarsener expect Tensors

See also https://github.com/ZettaAI/internal/issues/23


Remove very outdated Cython compatibility measures

Remove imports of bytes, unicode and basestring. Cython knows about these classes, regardless of Python version. This is actually an optimization, since Cython optimizes those as builtins but not when imported.

Remove typedefs for adding const. Cython has supported that for a long time now, there is no need anymore for such hacks.

Remove a few redundant assignments (only in code that I was changing anyway). Generally, there is no need for an explicit assignment

cdef const char *buf = python_bytes_object

to convert bytes to const char *.

Thanks!


Simplify repo-setup to get RDO Antelope repos

Remove unrelated commands to erase tripleoclient.
It used to required with RPMs auto-upgrade policy set in
EDPM bootstrap/download_cache, which is no longer a thing.

recheck

Failing with "Unknown policy NO-ENFORCE-EMS: file NO-ENFORCE-EMS.pmod not found in (., policies/modules, /etc/crypto-policies/policies/modules, /usr/share/crypto-policies/policies/modules)" in https://logserver.rdoproject.org/50/250/49e567395600c7e59fcf59f5924ee75d98acab96/github-check/data-plane-adoption-osp-17-to-extracted-crc/dba1e2b/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/dataplane.deployment.repo.setup-openstack-lq9ct/logs/openstackansibleee.log

Failing with "Unknown policy NO-ENFORCE-EMS: file NO-ENFORCE-EMS.pmod not found in (., policies/modules, /etc/crypto-policies/policies/modules, /usr/share/crypto-policies/policies/modules)" in https://logserver.rdoproject.org/50/250/49e567395600c7e59fcf59f5924ee75d98acab96/github-check/data-plane-adoption-osp-17-to-extracted-crc/dba1e2b/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/dataplane.deployment.repo.setup-openstack-lq9ct/logs/openstackansibleee.log

Done. I've missed that this used to fail on RHEL, while was working for my cs9 stream setup as that package was missinig for the former, but presenting for the latter


Can we add aitboudad o the angular 2 formly core team?

@kentcdodds please add @aitboudad o the angular 2 formly core team?
THANKS 😄

Done


Gamepad problems in Google Chrome

This PR changes

Nothing, it's a bug fix

Describe the changes below:
When using the Gamepad API in Google Chrome, the onConnect callback for a gampad was not always being called. This would prevent setup of buttons, etc. This behavior is evident even on the Phaser Gamepad Input example. I tracked this down to a race condition where Gamepad._pollGamepads was finding gamepads before the game code could add the callback - resulting in the callback sometimes being added too late to ever fire. In my case, I had a lot of code executing before attempting the gamepad setup which pretty much guaranteed that mine was NEVER being called. The code in the Phaser example was working more often than it failed, but would still fail sometimes. To correct this, I added a check to the Gamepad._pollGamepads function which will immediately return if _active is false. This means that until game.input.gamepad.start() is explicitly called, no attempt will be made to setup the gamepads discovered in the browser. To ensure that the gamepad's onConnect event handler will always be called, one must only add the callback to the SinglePad object before calling game.input.gamepad.start(). For example,
var controller = game.input.gamepad.pad1;
controller.addCallbacks(this, {
    onConnect: someFunction
});
game.input.gamepad.start();

The other problem was that the game seemed to lose the gamepad after the focus is lost to the browser window or tab. Again, this was evident not only in my game but also in the Phaser example. In this case I tracked the issue to the SinglePad_rawPad object pointing to a defunct raw gamepad object. The timestamp field on this object would not update despite new input, leading me to conclude that this object was no longer correct as far as the browser was concerned. Checking game.input.gamepad._gamepads[0]._rawPad === navigator.getGamepads()[0] proved to be false in these cases. The code in Gamepad._pollGamepads seemed to account for this by resetting the _rawPads array on every update, but these changes were not being flowed down to the SinglePad objects. To correct this, I added the following code to _pollGamepads:
for (var g = 0; g < this._gamepads.length; g++)
{
    this._gamepads[g]._rawPad = this._rawPads[g];
}

which ensures that the _rawPad object on each SinglePad will always be a valid raw object.
Because both changes were in code specific to Google Chrome, I found no adverse effects when using Firefox after making these changes.

I have had similar issues with the callback's but eventually found myself checking the connected gamepads on callbacks as on create. Using a simple loop:

getActiveGamepad(){
	for(let i = 1; i < 5; i++){
		if(this.game.input.gamepad['pad' + i].connected){
			return this.game.input.gamepad['pad' + i];
		}
	}
	return false;
}

The issue was that sometimes a gamepad on reconnect would become pad2, etc. Also, on disconnect it makes sense to fallback to any left controller, if you have a Singleplayer scenario.

I haven't had any problems with chrome disconnecting gamepads on losing game focus. It even works connecting a gamepad when off focus. What version of chrome are you testing with?

Chrome for Windows 50.0.2661.94. The raw gamepad objects seem fine when off-focus, but the SinglePad._rawPad ends up being a different object than the one in the Gamepad._rawPads list once focus is restored. At that point, the object equality check starts failing. At first I thought that perhaps the SinglePad object was being reset somehow but I found no evidence of them changing after the game un-paused.

:+1:


v6.1.0 using deprecated rules

Bug Report

tslint-microsoft-contrib version:
6.1.0

TSLint version:
5.14.0

TypeScript version:
3.2.4

Running TSLint via: (pick one) CLI / Node.js API / VSCode / grunt-tslint / Atom / Visual Studio / etc
CLI

TypeScript code being linted
with tslint.json configuration:

  "extends": [
    "tslint:recommended",
    "tslint-microsoft-contrib",

Actual behavior
Warning: no-function-constructor-with-string-args rule is deprecated. Replace your usage with the TSLint function-constructor rule.
Warning: no-reserved-keywords rule is deprecated. Replace your usage with the TSLint variable-name rule.
Warning: no-increment-decrement rule is deprecated. Replace your usage with the TSLint increment-decrement rule.
Warning: no-unnecessary-bind rule is deprecated. Replace your usage with the TSLint unnecessary-bind rule.
Expected behavior
No usage of deprecated rules

@rbirkgit this is intended behavior tslint-microsoft-contrib rules list is alias for legacy list, and will remain in this way until next major release to avoid "breaking" projects that don't want to update TSLint core or their configuration. See details here: https://github.com/Microsoft/tslint-microsoft-contrib#legacy
You can use "tslint-microsoft-contrib/recommended" (stable list of rules that changes only in major releases) or "tslint-microsoft-contrib/latest" (recommended + all new rules added in minor releases)
You can find more information and configs descriptions in Configuration section

Thanks for this explanation. I missed this part!


Ensure OVS port is valid before setting NO_FLOOD

There could be some cases that OVS ports are left invalid. Setting NO_FLOOD for these ports will fail for sure and restarting agents would just meet the same error. Later we should enhance the port cleanup logic, either when they are firstly identified, or when their owners do the initialization. For now, as there could be invalid ports in interface cache, we should ensure a port is valid before setting NO_FLOOD.
Fixes #4673

/test-all


Where is GetWebContent api name in section "Enable metrics on static website pages" , step 7?

In this section https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-static-website-how-to?tabs=azure-portal#enable-metrics-on-static-website-pages, step 7, I cannot see GetWebContent  api name, where is it now? is it changed to GetBlob? please let us know the changes and related doc. Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d693507-4b62-07d9-a708-d26d62d990ac
Version Independent ID: 6c7f4c32-69da-3929-dbf2-1591d667f979
Content: Host a static website in Azure Storage
Content Source: articles/storage/blobs/storage-blob-static-website-how-to.md
Service: storage
Sub-service: blobs
GitHub Login: @normesta
Microsoft Alias: normesta

I have just figured it out, we should configure some settings in the Diagnostic settings of the storage account. But anyway, this should be documented.

@imeya , Thank you for your feedback. We will investigate and get back to you shortly.

@normesta Please add your comments

Thanks @imeya! The API member doesn't appear unless that member was used within the timeframe that you specify in the settings. There is some text that mentions this, but perhaps it wasn't very discoverable. I've upgraded that text to a note and I've added another note directly beneath the step that mentions the API. Thanks for helping us head off confusion.

#please-close


Typo in OrderStatus enum documentation

in OrderTypes.cs:
        /// <summary>
        /// Order waiting for confirmation of cancellation (6)
        /// </summary>
        CancelPending = 8,

the doc says '6' where it should be '8':
        /// <summary>
        /// Order waiting for confirmation of cancellation (8)
        /// </summary>
        CancelPending = 8,

as a result the type is repeated at https://www.quantconnect.com/docs/v2/writing-algorithms/trading-and-orders/order-management/order-tickets too
see: https://github.com/QuantConnect/Lean/blob/1c32144963bfd7761fe33690f2edad31f8ff6a8d/Common/Orders/OrderTypes.cs#L175C1-L178C27

Thank you for the report @akosmaroy!


Remove duplicate link from navbar

Description
Remove duplicate link from navbar.
Related issue(s)
Fixes #1238

@Yasir761 you have to follow Conventional Commits specification
Just change the title of the pr to fix: remove duplicate link from navbar

/rtm

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.428%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4793

Relevant Lines:
5053

💛  - Coveralls

@all-contributors please add @Yasir761 for code


Ability to edit shape after ajax call (not on page load)

There is some backgroud to this issue in #549, but basically I've been finding it difficult to add in an editable layer after initialisation - I want to only set the editable feature group when the shape I want to edit has been loaded rather than when the directive is called.
I guess the fundamental issue is that scope items like center have watchers when they change but there are none in controls.js.
I had a stab at trying to fix this using a watcher on the $controls.edit variable, shown here (needs more work).
https://github.com/stev-0/angular-leaflet-directive/commit/c9fe8041c4569c2c5fc8c35f84a78aa39e504593
Another thing I tried was to not declare just declare the controls: {draw: {}} variable (so it defaulted to a featureGroup) and then add the relevant layer in afterwards, but that didn't work.
Would be good to know if I am barking up the right tree (it is a bit hacky because you don't seem to be able to remove controls easily in leaflet), then I will continue with the patch

@stev-0 Do you happen to have any example of: how to load the markers and make the editable and removable, I' ?
Thanks.

I've just solved it :D>.

@dud3 Would be great if you could explain how you solved this, I'm still struggling.

I think this should guide you:
var drawnItems = $scope.controls.edit.featureGroup;

                                                                        if(geometry.shape == "Polygon") {

                                                                            // Add the Polygon geometry to the map.
                                                                            var _geometry_coordinates = JSON.parse(geometry.coordinates);
                                                                            var polygon = new L.Polygon(_geometry_coordinates);
                                                                            polygon.setStyle({color: '#66CCCC', fillColor: '#66CCCC'});
                                                                            // Comment out, and geo. shape will be editable
                                                                            // polygon.editing.enable();
                                                                            drawnItems.addLayer(polygon);

                                                                            // Push layer.
                                                                            var _push_layer = {};
                                                                            _push_layer.coordinates = JSON.parse(geometry.coordinates);

                                                                            // Push the leaflet_id first, so later on we
                                                                            // can easily remove it from the map.
                                                                            _push_layer.id = polygon._leaflet_id;

                                                                            // Push location id as well, so we can distinguish
                                                                            // if the marker already existed or not, and make a call
                                                                            // to the back-end to remove/modify the entity on the db.
                                                                            _push_layer.geometry_id = geometry.id;

                                                                            // And finally the spot_id, just in case. - Ignore.
                                                                           //  _push_layer.spot_id = geometry.spot_id;

                                                                            $scope.submission.spot.coordinates['polygon'].push(_push_layer);

                                                                            // Resolve promise. - Ignore.
                                                                           // resolve(1);

                                                                        }

And this goes for the awesome markers:
go.get.my.data(function(location) {

    leafletData.getMap().then(function(map) {

        var drawnItems = $scope.controls.edit.featureGroup;
        var coordinates = {lat: location.latitude, lng: location.longitude};

        var layer = new L.Marker(coordinates);
        drawnItems.addLayer(layer);

        var _push_layer = coordinates;

            // Push the leaflet_id first, so later on we
            // can easily remove it from the map.
            _push_layer.id = layer._leaflet_id;

            // Push location id as well, so we can distinguish
            // if the marker already existed or not, and make a call
            // to the back-end to remove/modify the entity on the db.
            _push_layer.location_id = location.id;

            // And finally the spot_id, just in case.
            _push_layer.spot_id = location.spot_id;
    })
});

This issue was moved to angular-ui/ui-leaflet#147

I'm going to rework&redesign angular-leaflet-directive to be compatible with Leaflet v1.0. It will mantain almost all its functionality, and will be compatible with the current features of the directive, but I must start from a fresh point, so I'm going to close this issue. If you think it must be worked with the new version, please reopen it.


Add "class" as a valid attribute

You can't currently set the class of a node using the attr function. If "class": "" is added to availableAttrs (line 61) then it works on Safari at least and means I can style things using CSS

As long as these limitations are documented properly, I see no reason why this attribute shouldn't be available. It's really useful to detect the class name of an element when event delegation is being used, and it's just a matter of adding one extra line to the code.
Otherwise how are you supposed to identify what element is being passed in to the event, and thus its links with the rest of your program properly?