Support tuples as result type

Now the results of the operations are returned as maps (Lua tables):
crud.insert('customers', {
    id = 1, name = 'Elizabeth', age = 23,
})
---
- bucket_id: 7614
  age: 23
  name: Elizabeth
  id: 1
...

If the result is further used in some connectors, the tuple-to-map conversion may be unnecessary, especially for the purpose of partial compliance with the box API, which has an option for returning maps and returns tuples by default.
Proposal: implement an option "tuples_as_map" with default value "true", which may be passed along with the options of each operation. In case if this option is set to "false", the tuple-to-map conversion is not performed and the result tuples are returned as-is.

NB: A tuple has :tomap() method. Maybe it would be good to borrow the option name from it.

I like the idea of using tomap in the option name. (use_tomap, tuples_tomap etc.)
Moreover, (in the future) I would like to have two functions for insert - insert_raw (which accepts tuples) and insert (which accepts objects). Rather than other operations, insert accepts tuples or objects, not only returns.
I like the idea to use tuples by default (as @knazarov suggested).
I don't see any reason to discuss on #10 PR until we have a fully discussed and accepted by @mtrempoltsev and @knazarov  RFC here.
My suggestion (within #10 ) is:

CRUD operations return objects by default (until it's not possible to return tuple with :tomap() method).
CRUD operations return tuples (firstly, a simple table objects) if use_tomap/tuples_tomap option is specified.

Later, all operations should return box.tuple objects by default.
In this case, maybe we need to get rid of *_tomap option and simply introduce pair operations: insert  -insert_map/insert_obj.

We discussed this with @mtrempoltsev and came to the conclusion that it would be impossible to have tuple format appear on the client auto-magically. There are ways to modify Tarantool core to attach format to arbitrary tuples, but it will (a) be a long discussion and (b) will not happen in Tarantool 1.10 (LTS).
For those reasons, we decided to mimic the return style of Tarantool SQL. Namely:
---
- metadata:
  - name: id
    type: unsigned
  - name: first_name
    type: string
  - name: last_name
    type: string
  rows:
  - [1, 'Ivan', 'Ivanov']
  - [2, 'John', 'Doe']
...

This will allow to:

Use crud from current connectors, without any special support. The return format is quite obvious.
Save some space by only returning the format once for the result set.

There are also possible optimizations for connectors that would like to add native support of crud. We can add an option to all operations that will return metadata ID instead of the complete description of fields, and create a separate function called crud.get_metadata(id) that will fetch the complete description by the ID. Clients will then be able to cache metadata. This will allow skipping the extra expensive payload, and thus help better utilize the bandwidth.

crud.get_metadata(id)

It requires to keep some state into lua land that mean we should manage them by hand and clear after usage.
I suppose It's easy way to get OOM in luajit.
As alternative we could implement dry_run option to return only metadata.
tarantool> crud.select(..., {dry_run = true})
---
- metadata:
  - name: id
    type: unsigned
  - name: first_name
    type: string
  - name: last_name
    type: string
...
```

Also we could add `skip_metadata` option to returns only rows (even enabled by default):
```
tarantool> crud.select(..., {skip_metadata = true})
---
- rows:
  - [1, 'Ivan', 'Ivanov']
  - [2, 'John', 'Doe']
...
```

I think connectors use static set of queries with different arguments.
So it's also a good way to run "dry_run" at initialization step cache schema and then continue work with `skip_metadata` flag.

@olegrok to be honest, I didn't understand your comment. What state are you talking about? You already have this state: when you connect to storage nodes from the router, the router downloads schema from storages.

Well, what did you mean when said "client"? I suppose it's some external service that works with crud via connector.
client <--> router <--> storage.
Direct connection to storage always has storage schema: netbox_connecton.space.space_name:format() in case of Tarantool but other connectors fetch schema as well. It means router always knows information about storage schema. And all we need to have a function allows transfer this schema to "client".
Initially it could be really simple:
-- something like
local function get_metadata(space_name)
    local replicasets = vshard.router.routeall()
    local replicaset = select(2, next(replicasets))
    local space = replicaset.master.conn.space[space_name]
    return space:format()
end

In future it could be easily extended if we want to get not all fields but only some subset of fields.
And if I correctly understood you, my suggestion was to allow router proxies schema from storage to external client using special flags to select/insert/update/...

@olegrok yes, we agree on the meaning of "client". And the fact that routers have an up-to-date schema.
With a basic implementation, when you return schema with the result set (or metadata, if we name it after the field name), you have the exact format of the tuple when you receive a reply from storage to the router. You can then just pass it back to the client. No additional long-term storage is necessary. You can get rid of the pointer to format as soon as you return the reply.
For the optimized version, you have to keep the format for some time. It is possible that between the select and the request of the format by the client, space format on the storage will change. This indeed will require the router to cache the older format. This can be mitigated by putting a TTL on such records, or just storing old formats in a temporary space, which will save the Lua heap from growing.
And you need to remember that the optimized version is just that -- and optimization. We don't have to implement it right away.

As for dry_run and skip_metadata: you can't do that, because the format on the server-side can change. You need a sequence number to differentiate between versions of the format (as is currently implemented in net.box).

Ok. Thanks for explanation.


Constant returns diagnostics

This change is

Current dependencies on/for this PR:

main

PR #3270   👈

This comment was auto-generated by Graphite.


feat: map ems severity to prom sev

Instead of using static 'critical', use label 'severity' coming from EMS and maps to recommended prometheus scale of info/warning/critical: https://monitoring.mixins.dev/#guidelines-for-alert-names-labels-and-annotations
Known severity from ems: emergency, alert, error, informational, and notice
Severities suggested for use in alertmanager/prom: critical/warning/info.

Thanks @7840vz!
promtool check rules passes!
Do you know if Prom alerts.yaml supports anchors/aliases to help reduce duplication? I haven't tried, but thought you might know. I know support for anchors/aliases varies a lot by tool and it may not be worth it to reduce this duplication.

hi! Regarding, anchors, unsure if it would work: https://github.com/prometheus/prometheus/issues/6266
Turning your dashboard and alerts into monitoring-mixin might help though:
https://monitoring.mixins.dev/
some examples:
Kube: https://github.com/kubernetes-monitoring/kubernetes-mixin
Node: https://github.com/prometheus/node_exporter/tree/master/docs/node-mixin
Here , alerts can be redefined in jsonnet format and actual yamls can regenerated from Makefile or other tooling.

Thanks. Yes, we've discussed jsonnet in the past, but only for dashboards, where there were some bigger trade-offs. For alerts, jsonnet may be a better fit.


When creating a gallery page freezes

if the Photologue uploaded a lot of photos when you create a gallery page the browser freezes. the problem is that the list for the "Photos" are loaded ALL the photos. and if they are 30,000?

The latest release of django-sortedm2m includes a performance boost that should help make this less of an issue.
I've updated photologue to use this latest release, so I think we can close this ticket now.


File > Open Recent > recent workspace no longet opens in new window when Ctrl or Shift used in VS Code Insiders

Type: Bug
Opening in new window straing from File > Open Recent menu is great tool to quickly get to another workspace wiithout loosing curren open one, and much faster then New Window and searching same workspace in new window.
So I hope this change is not intentional.
Steps to reproduce:

Have history of several opened workspaces
Open File > Open Recent submenu.
Press Ctrl or Shift and click on some of recent workspaces
Workspace in active window is replaces with selection from recent

Expecte behavior:
New window should be opened with new workspace instead of replacing workspace in active window.
This is behavior is reproducible in standalone(zip) Insiders intallation but not not reprodusible in standalone(zip) Stable intallation. However in stable Ctrl(Shift) sometimes does nothing, but never replaces current workspace.
VS Code version: Code - Insiders 1.83.0-insider (109e1f8d8afb754ed31317f79937a44e98d5063b, 2023-09-25T10:41:26.295Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2996)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.50GB (15.50GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

If this is a confirmed regression, it would help to know which change caused it. We maintain a node.js based CLI tool  vscode-bisect that automatically downloads and runs previous VS Code insiders and asks for each build if the issue reproduces. It takes up to 8 steps to find exactly the build that caused the regression.
Steps:

install node.js (if not yet done)
npx --yes @vscode/vscode-bisect@latest
follow the instructions until you found the offending build (its fine to leave the commit empty)
report back the commit range in this issue

Thanks!

That's a relief😌 Thanks
Will bisect after working hours

@bpasero
Bisect showed this range https://github.com/microsoft/vscode/compare/f36df69328ed10f76d4be03e8a82b61794b49711...491ddd816e03051785226aa389f32a6cf4ccfdf2
May be related to https://github.com/microsoft/vscode/commit/d649d877f48664eee857dcb93dd4c331bd8908a1

However it feels that some builds also had problem where only odd (1,3...) attempts opened new window. Will bisect this as well

Works as expected in today's Insiders build.
Thanks, @bpasero!


Clarify condition for triggering OAM corruption

Regarding references, Liji said he has yet to publish his OAM corruption test suite, but that blargg was the best we have in the meantime.
I think it's better to wait until we can point at a specific ROM rather than linking to blargg and overshooting the scope.

We should at least open an Issue mentioning the hanging reference


Create a separate section of test files in PR

When reviewing a PR it would be really useful if all the changes in tests files would appear at the end or within a separate section. That way I could review the code first and then the tests.

This isn't feasible because GitHub decides the order in which files load (they are lazy-loaded a few at a time, especially in PRs that touch many files)
Refer to https://github.com/sindresorhus/refined-github/pull/1085 and all of the links at the bottom to see other possible solutions to move tests files out of the way


Overriding default renderers array

It's quite common to only want to support a subset of Markdown. (I'd argue the most common use case)
Since the current implementation merges renderers with the default render config this is needlessly verbose. In addition to having to know all the keys for existing renderers to configure, if a new one gets added in a future version of svelte-markdown we'd automatically opt into it. ☹
For example to only support bold and cursive we'd have to do this:
// EmptyComponent.svelte
<slot></slot>

// Main.svelte
<script>
    import EmptyComponent from './EmptyComponent.svelte';
</script>

<SvelteMarkdown
	source={source}
	renderers={{
		text: EmptyComponent,
		paragraph: EmptyComponent,
		// em: EmptyComponent, <= We want to support this
		// strong: EmptyComponent, <= We want to support this
		hr: EmptyComponent,
		blockquote: EmptyComponent,
		del: EmptyComponent,
		link: EmptyComponent,
		image: EmptyComponent,
		table: EmptyComponent,
		tablehead: EmptyComponent,
		tablebody: EmptyComponent,
		tablerow: EmptyComponent,
		tablecell: EmptyComponent,
		list: EmptyComponent,
		listitem: EmptyComponent,
		heading: EmptyComponent,
		codespan: EmptyComponent,
		code: EmptyComponent,
		html: EmptyComponent
	}}
/>

I think the ergonomics would be improved if we could add a defaultRenderers prop that would override the default configuration instead of merging with it. The above example would be rewritten as:
// EmptyComponent.svelte
<slot></slot>

// Main.svelte
<script>
    import Em from 'svelte-markdown/src/renderers/Em.svelte';
    import Strong from 'svelte-markdown/src/renderers/Strong.svelte';
</script>

<SvelteMarkdown
	source={source}
	defaultRenderers={{
		em: Em ,
		strong: Strong ,
                // No other renderers are supported
	}}
/>

There could be even less verbose solution with a allowedRenderers prop, but it's a bit more opinionated. Eg:
<SvelteMarkdown
	source={source}
	allowedRenderers={['em', 'strong']}
/>

Let me know what you think!

This is something that can be implemented. What would the expected behaviour for non-accepted tokens be? Would they be displayed as plain text? Raw (with markdown syntax untouched)? Would they be omitted completely?
I've toyed around with making default renderer's completely optional, so they'd only get included in the bundle only if you use them. Although this would make it more complex for basic scenarios.

@pablo-abc I would expect that unsupported tokens would be left as-is, so if we don't support Strong, then Hello **world** would render without any modifications, with the stars intact.
Attempting to convert to plaintext feels like it's not something that is generally desired.  Markdown is about enhancing with markup after all, not to sanitize it. It could also already be implemented by passing EmptyComponent to all renderers as in my first example.


[SECURITY ISSUE] Operate's Backup Actuator endpoint is accessible via the default url/port

Describe the issue:
Unlike Zeebe, Operate does not have a separate management port for the actuator endpoints, which means that anyone can start the backup process at any time. As our backups are stored in the GCS, this can lead to increased costs and a theoretical DDOS attack.
Actual behavior:
curl -s -X POST -H "Content-Type: application/json" -d "{"backupId": "1"}" https://camunda-platform-test.local:8080/operate/actuator/backups
Expected behavior:
The endpoint should only be accessible via corresponding port forwarding or similar.
curl -s -X POST -H "Content-Type: application/json" -d "{"backupId": "1"}" https://localhost:8080/operate/actuator/backups
How to reproduce:
Versuche den /actuator/backups Endpunkt über den Ingress von Operate zu erreichen.
curl -s -X POST -H "Content-Type: application/json" -d "{"backupId": "1"}" https://camunda-platform-test.local:8080/operate/actuator/backups
Environment: GKE/GCP
Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

Platform: GCP
Helm CLI version: v3.14.3
Chart version: 10.0.2

We also will try to work on it before the 8.6 release for supported versions like 8.5 and 8.4.

The issue has been fixed for the Camunda 8.6 chart (unreleased yet).
We will work on fixing the previous versions.

Hey👋, I’ve been looking into the security issue with the /actuator/backups endpoint being publicly accessible. Here’s my proposed solution:
Suggested Edits:

Edit ingress.yaml:
Add the following annotation to block external access to the /actuator/backups endpoint:
nginx.ingress.kubernetes.io/server-snippet: |
  location /operate/actuator/backups {
    deny all;
  }

Edit values.yaml: Ensure the following settings are enabled to deploy the ingress:

operate:
  ingress:
    enabled: true
    className: nginx

After these changes, the /actuator/backups endpoint will be restricted and return a 403 Forbidden response when accessed externally.
Let me know your thoughts!

@zessam Thanks for the proposal, but it cannot be accepted.
The solution should be controller agnostic (it should work with all Ingress controllers, not only Nginx).
Maybe playing around defaultBackend could work. Do you like to give it a try? Here are some pseudo instructions:

Create a namespace;
Deploy Echo-Server;
In the Ingress object, create 2 rules with the same base like /foo/abc and /foo/xyz.

Try to match the first and send the traffic to the echo server, and the second should be sent to the default backend (when it's not specified, it will go to the controller directly, as I remember).


Move new deps from configure.py to pyproject.toml

The new dependencies added by cc88906 were in the old location,
braingeneers.utils.configure.DEPENDENCIES, so I wasn't able to load
any IOT functionality. Add those dependencies to the correct place in
pyproject.toml, and completely remove the confusing and redundant
DEPENDENCIES variable.

Also I know we talked about completely changing about the dependencies structure, but if we're not going to do that anytime soon, I noticed the new format allows defining optional dependency groups in terms of each other. Maybe analysis should just depend on data instead of duplicating half of its dependencies?
I'm adding a commit to this PR that does that, but if anyone doesn't like that idea it's no problem to remove it


fix: articles/security/azure-security-threat-modeling-tool-exception-management.md

Add code fence languages
Remove double quote escaping in XML

@nschonni @jegeib - We're in the process of pulling this commit to the private repository so we can verify the updates on staging. We'll post a new private repo PR # shortly and then close this PR.

moved to https://github.com/MicrosoftDocs/azure-docs-pr/pull/64999.


master: on-failure -> always

https://github.com/nix-community/infra/pull/1235#discussion_r1590512432
Seems this needs to be always instead of on-failure as the service exits successfully.

@mergify queue


Added logging & clarified validation error message

Description
When running validate in sandbox, it was not intuitive to me that it also validates the schema. I expected it to run my validate function and return only those results (a promise/boolean). When it failed with a schema error, I found myself digging through my extension.json.
My getSettings function was the culprit, returning a number when a string was expected. So the error was correct, but it could do more to guide me to the source of the problem. I believe this error only occurs when validate succeeds AND the result of getSettings does not match the schema.
In addition to clarifying the error message, this PR adds logging for init(), validate() and getSettings().

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

@Aaronius, I've added logging and updated the error message as we discussed. I wanted to add the schema validation errors as well, but I found that ajv.errors was null after validation failed. We could probably figure this out but I need to limit the amount of time I dump into this PR. I think it's good enough as is to provide value to extension devs. No rush, but let me know what you think ok?

@markhicken What is the purpose of LOGGING_ENABLED? Can you set it to false from the command line?

@markhicken let me know what you'd what you decide to do with the LOGGING_ENABLED flag, then I'll merge.

On the Logging flag. My original thought was to make a UI switch to enable/disable it. I'm not sure there's any need to disable it though, so I'll go ahead and remove the variable for now.

Done. Ready to merge if you are.

Thanks for contributing! Published as v10.8.0.

Awesome! Thx!


Replace Hilt with Tangle + Anvil

KSP Pog
https://github.com/square/anvil
https://github.com/RBusarow/Tangle

I no longer care.

I care again


toy datasets

Toy datasets needs to be ported over, with a plugin added and registered.

What does "ported over" means? Can you add a tutorial on how to add and register modules? If toy_datasets is considered as a module obviously. This comment is targeting issues #124 and #123.


When writing pre-commit hook, merge with existing hook logic

If any functionality exists in .git/hook/pre-commit prior to running secureli init, we should not remove the preexisting functionality. Instead, we should integrate logic from secureli with the existing pre-commit hook code.
Note that we will want a way to identify any logic added via seCureLI so that we can make changes to it (e.g. updates) without affecting non-secureli logic.
Here are a few ways this could be implemented:

(Easier but less correct) we could back up the state of .git/hooks/pre-commit at secureli install time. Any time we need to make a change/update to the hook, we can append the new logic onto the backup file. This won't account for any changes manually made to the pre-commit file after secureli was installed.
(Slightly more difficult) we could add some delimiter (e.g. #### BEGIN seCureLI ####/#### END seCureLI ####) to indicate sections of the pre-commit file managed by seCureLI.
We could have a single line in the pre-commit file that executes a separate script managed by seCureLI. Then we could rewrite/regenerate this script for any updates, and avoid making any additional changes to the pre-commit hook.

After a call to brainstorm ideas, this is the current proposal:

Check if .git/hook/pre-commit exists. If so, backup to .git/hooks/pre-commit.backup.<datetime>
Mention in the output that we backed up the file
Write the new file .git/hooks/pre-commit
Include at the top of the file: # Auto-generated by seCureLI


ImagePickerIOS take photo with wrong orientation

When using ImagePickerIOS camera take photo, photos only have landscape orientation, which is not matched with fact.
So I add a function to save orientation info.

anyone can help review ?

Hey! I've been going through PRs and would like to get this one moving. Two things stand out to me: there is no test plan, and there is no example of what happens prior to the fix.
Ideally your PR would include all of the sections listed in the PR template. This will help us gauge the extent of the problem as well as understand how the fix was tested.

@shergin Hi! Any chance to see this PR merged. I also have this bug with photo orientation and this patch works for me.

@doochik see my comment above, this PR lacks a test plan. Since there has been no response from the author, I'll close it. Feel free to open a new PR if you feel strongly about getting this merged.

@hramos Ok, I've opened new PR https://github.com/facebook/react-native/pull/15060


Insert Pictures into cells

Would be nice if it were possible to insert pictures (png, gif, bmp, etc) into cells.

in 0.1.11


feat(token-card): Round tokens to appropriate decimal

32.05 PSF tokens awarded. TXID:
d0657ba5acb0f08fcc8d4435bcbb9ce555958dd0f162aaeaff7ee05a803badc4

:tada: This PR is included in version 1.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Standardize Hebrew character names

The names of Hebrew characters should be standardized (e.g. shewa become sheva).
Also update the documentation

shewa > sheva
patach > patah
metheg > meteg

Did not change to ensure backwards computability;

qamets to qamats
holem to holam


Empty Tweet List View

Is your feature request related to a problem? Please describe.
Like the empty list view for categories, id like to request the feature for handling it the same way for the tweet list.
Describe the solution you'd like
I can provide a generic empty list view for both lists like in #73.
Please add the topic Hacktoberfest and assign it to me if you want me to add this feature.
cheers

This looks like it's done "No tweets saved!" shows when you tap on a category with no tweets.


add: aayush105

Description

Related Issues

Changes Proposed

Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@aayush105 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further!


fix docker package

Go modules had pulled down the latest semvar tag, which
was actually super old, had to specify the commit hash
of github.com/moby/moby to get the actual up-to-date
module.
Fixed ipfs package dependencies as they are now go module
compatible and so indirect deps don't need to be listed in
this packages go.mod file.
Fixed tests so that they didn't attempt to pull a private
image, as well as not running TestRemoveAllImages by default,
as it does as it says...
Fixed util to take the official docker images into account,
as their url is docker.io/library/ but the container
name is just , instead of library/.

@lanzafame great work! wasn't aware of some of those issues so thank you so much for this PR 👍


chore: Add config for enabling SMJ with join condition

Which issue does this PR close?

Part of https://github.com/apache/datafusion-comet/issues/901
Rationale for this change

There are known correctness and performance issues with our support for SMJ with join condtion, so we should disable it by default.
What changes are included in this PR?

New config.
How are these changes tested?

Thanks, related to https://github.com/apache/datafusion/issues/9846


Fix i vectorise

Fixes issue reported here on Discord
This is my first time editing any element functions, so please review before merging.

Which bug report?

The first message in the channel. The error was due to i being given a list that has strings in it.

I got this error while interpreting:
fizzbuzz FB## #?(ᶲkdFø, ##,##⟨h|t⟩∑⌊,_? ##→s s, _)
with no flags on the Vyxal 3 online interpreter (here)

I don't see any usage of i in that.

And if you're referring to
vyxal.VList.index(https://vyxal.github.io/Vyxal/vyxal.js:78907:90)

in the error report, that's the index method of VList, not the index element

I got this error while interpreting:
fizzbuzz FB## #?(ᶲkdFø, ##,##⟨h|t⟩∑⌊,_? ##→s s, _)
with no flags on the Vyxal 3 online interpreter (here)

I don't see any usage of i in that.

They weren't using any flags, so it was being interpreted as SBCS commands. In this case the issue could be boiled down to this: Try it Online!

The line that's throwing the error is this one, where if b is a list then it just assumes that it is a list of numbers, without actually doing any vectorisation. Adding proper vectorisation allows it to work with strings without modifying existing behavior.

Aha, I see the issue now. Merge when you're ready


Containerd is leaking snapshots

Containerd is leaking snapshots due to what looks like the garbage collection not having a lease to reference
https://github.com/containerd/containerd/blob/main/docs/garbage-collection.md#how-to-use-leases

This issue seems to be caused when kubelet container runtime is docker. the namespace moby is used instead of k8s.io. To workaround this issue till we use containerd, as docker is being deprecated, we just have a deamonset cleaning images in k8s.io.

Thanks for the issue. Let me try to fix it.

Actually containerd uses moby namespace with dockershim and this project seems to be only compatible with containerd if it's the active runtime in kubelet. If main runtime is dockershim, the snapshots will be leaked and node will run of space over time.
To solve it, we had to add a cronjob to cleanup the snapshots in k8s.io namespace. We plan to remove that cleaner once we use containerd as main runtime and kubelet will start cleaning the images/snaphshots in k8s.io namespace.


config: use LOCKSMITHD_ prefixed environment variables

This updates cloudinit to prefix REBOOT_WINDOW_* environment
variables with LOCKSMITHD_ when setting up the dropin for the
locksmithd.service unit. This is to be consistent with the other
variables (the unprefixed versions are still supported by
the locksmith daemon).
Notes
This will cause the /run/systemd/system/locksmithd.service.d/20-cloudinit.conf to output environment variables with LOCKSMITHD_ prefixed, for locksmithd to read. This ties in with the docs https://github.com/coreos/locksmith/blob/master/README.md#reboot-windows and keeps the variable names consistent.

This project has been deprecated for quite a while now. Unless it fixes a serious bug, my inclination is to reject this patch since we aren't likely to cut and ship any more releases.

I'd tend to agree with @crawford, the bug that spawned the initial investigation coreos/bugs#2463 is just a race.

Thanks, makes sense given that the project is deprecated. I'm good with this. Just made this in passing as I was looking over the code.

Then maybe add a very brief line to locksmith mentioning that unprefixed flags are also accepted?

README changes done: https://github.com/coreos/locksmith/pull/139


Not-Allowed Cursor?

Wondering if anybody is getting the "Not-Allowed" cursor when dragging items.
I referenced the code directly so that I can apply this component to a table instead of a div.
It works great, I'm even toggling between the "grab" & "grabbing" cursor when I click on the drag-handle div with in the td tag.
The issue is when I'm dragging a  tag i get the "not-allowed" cursor instead of the dragging cursor.   Anybody know how to change the cursor for dragging  tags instead  tags?
My small change to the SortableList.razor just required changing div tag to tbody

This is in the original SortableJS.  It had me wondering too and I tried to figure it out. I'm not sure why they require it on a technical level, but changing it will break the drag feature. It may have something to do with reading the screen position of the cursor when dragging the item around


travis.yml: disable updating snapshots

Will still update releases with the --update-snapshots version (I know, bad name).
Still occasionally failing but it is definitely downloading less now. Check out the travis logs.

Just to clarify this prevents the download of maven-metadata.xml for the snapshots to check for any newer versions right?
I think you also need this in the test_word.sh since that exec:java plugin is also tied to the verify phase and performs the same checks.
The actual downloading of jars is still happening in every travis build when exec:java is run since we delete any cached beam jars. https://github.com/apache/incubator-beam/blob/master/.travis.yml#L52

thanks!


User registration - No privacy policy checkbox (law)?

Description
Shouldn't the user registration have a privacy policy confirm checkbox ?

This is something we regularly patch :D is it worth a PR?

I think there is actually a setting for this in recent Shopware versions (admin interface) to enable such a checkbox?

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Bear Hunter Ninja | New Game

PR Description 📜
In this,the user chooses one from the three options available and the computer does the same simultaneously. And thus, making the combinations such that either the user wins, computer wins or its a draw or tie.
In this game, players use the gestures of a bear, a hunter, and a ninja. The rules are as follows:

Bear beats hunter (bear mauls hunter).
Hunter beats ninja (hunter shoots ninja).
Ninja beats bear (ninja kills bear).

Fixes #3097

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Niyatizzz ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@Niyatizzz resolve the merge conficts !

@Niyatizzz still there !!

@Niyatizzz still it's there !

Thank you  @Niyatizzz , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Do away with namespaces in the event handlers

This will have to wait until issue https://github.com/djalbat/EasyUI/issues/4 is tackled.

Done.


ci: check docs are buildable

Make sure docs are still buildable to avoid failures after PR merge when publishing the docs.

@rojkov want me to 'squash&merge'? :-)

Sure, gladly!

Oops. I was too quick to notice "me"....
But looks like the commit history is still there and the resulting merged commit even has got a reference to this PR in its message automatically.


Update MD file on new branch 2017-11-08_08-35-16

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


学术论文写作建议

Academic Phrasebank
https://www.phrasebank.manchester.ac.uk/

You and Your Research
https://www.cs.virginia.edu/~robins/YouAndYourResearch.html


New ff uwrf

Coverage remained the same at 34.738% when pulling 34f63a0cf3b9ee4e705752c895316a2ba33d9475 on new-ff-uwrf into b0d66edaaaccdf29699254e744b33d5c03528ae8 on master.

:+1:


Add helpdeskURL to MISC_URLS.

Add a helpdeskURL to the MISC_URLS map.
(Intended use: showing link among no-search-results recovery options when this URL is configured.)

:-1: This URL is not going to be used anywhere in frame, therefore just put it in angularjs-portal's app-config.js

Can't remember if the coarse grained authorization error page shows the
help desk link or not.
Was also thinking add a url for the outages page so it could be displayed
for an error message or status page.
On Oct 9, 2015 2:00 PM, "Tim Levett"<EMAIL_ADDRESS>wrote:

[image: :-1:] This URL is not going to be used anywhere in frame,
therefore just put it in angularjs-portal's app-config.js
—
Reply to this email directly or view it on GitHub
https://github.com/UW-Madison-DoIT/uw-frame/pull/36#issuecomment-146961678
.


Adjust some of the BUMP dependent results to SABER PR#75

Description
The fix to a "slight" slow down to the initialization of BUMP in SABER PR#75 changes the results of a few of the tests.

@travissluka Aaaaa ... You beat me to it. Thanks! I swear I wasn't waiting for you to do it.


Updated README.md

Added Service Worker explainer

LGTM too!

@erdraud please go ahead an merge this (after working out merge conflicts)

Fixed the merge conflict after the readme refresh went in, and will go ahead and commit this for you @erdraud!


Set Accept header to application/json

Scryfall has requested that clients set the Accept header. Lets do that to avoid getting blocked.
Fixes #32

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 60.714%

Totals

Change from base Build<PHONE_NUMBER>9:
0.2%

Covered Lines:
238

Relevant Lines:
392

💛  - Coveralls


Extend MenuItem syntax to include tag

added optional tag to MenuItem
We need this to show to the user which datatypes are not allowed.
Bug: T268441

No, this task intended to include also extending the OptionsMenu to make use of that field and add styling for it, etc.
It should probably build on top of #284 to prevent merge conflicts.
I admit that the description of the Phabricator task is not ideal. I will update it.

The code looks good, but the browser tests don't seem to be random failures. Even though I'm not sure why this PR should cause those tests to fail.

The code looks good, but the browser tests don't seem to be random failures. Even though I'm not sure why this PR should cause those tests to fail.

I also saw that. I am trying to figure out why they are failing still.

It was a css property that doesn't have full browser support. Please re-review :)


Implement setting the page owner & creating team

⚠ Work In Progress! DO NOT MERGE ⚠
To support representation of page ownership.

Anyone can edit any teams. Is its behavior acceptable?


Refactor test(s) that check for parameter types

Align with the pattern in https://github.com/softlayer/sl-ember-components/blob/develop/tests/unit/components/sl-chart-test.js#L99
Do not include test for Symbol

Starting work on this. @notmessenger please assign this task to me.

https://github.com/softlayer/sl-ember-components/issues/479 will be modifying the sample to follow

@notmessenger can this be closed?

Only if there are no files needing this change.  #479 only updated the sample to follow in the sl-chart-test file - not address any of the reasons for this issue existing.

@notmessenger verified no other files need these changes. All files have been refactored to use the new pattern.


D457 Segfault when calling get_motion_intrinsics

Tracked on [DSO-19103]

Nice catch!, as discussed, please add a unit test for each(D400) and later on PR with each(D500) on the relevant branch

Please remove this file you added
unit-tests/.idea/workspace.xml


Fix Rubocop cop deprecation

Builds are failing due to the following Rubocop error.
Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInLiteral` and/or `Style/TrailingCommaInArguments` instead.

@dalizard @dobrinov I can haz :eyes:? :smile_cat:

LGTM :+1:


QUESTION: Is the source code for Logic App Connectors on GitHub

Specifically looking to see the code for the Azure Blob connector: Extract archive to folder V2
to understand the limitations of this connector as the documentation might be missing some items.
Thank you!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3f7b449c-c725-3f3d-f433-69769c75efc4
Version Independent ID: 39b57ebb-6c6a-b46c-2c8e-cfc52cbea630
Content: Built-in connector overview - Azure Logic Apps
Content Source: articles/connectors/built-in.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@LRomano72
Thanks for your feedback! We will investigate and update as appropriate.

@LRomano72 Thanks for reaching out. Individual connector reference document should cover the limitation of the connector and for blob connector you can refer to this document: https://learn.microsoft.com/en-us/connectors/azureblob/
The content team works with the product team to update the document from time to time if there are any changes to the connector. But in case if you find any issue then feel free to reach out to us so we can work with the product team and update the limitation in case if it is missed in our document.
To answer your question "Specifically looking to see the code for the Azure Blob connector: Extract archive to folder V2". This connector is managed by Microsoft, and you cannot find the code details.
I will go ahead and close this issue now. Feel free to tag me in if you have any further queries or concerns.


[Slack] Support multiple workspaces

Extension – Slack
Author:

Describe the feature and the current behavior/state.
Currently this extension only supports link with one Slack workspace, it will be very helpful if it could work with multiple workspaces.
Who will benefit with this feature?
Slack user who have joined multiple workspaces
Any Other info.

Would love to see this too!


added python3-pytrinamic-pip to /rosdep/python.yaml

Please add the following dependency to the rosdep database.
Package name:
python3-pytrinamic-pip
Package Upstream Source:
https://github.com/trinamic/PyTrinamic
Purpose of using this:
This dependency is used to communicate with TRINAMIC Modules and Evaluation boards (such as motors and encoders).
Distro packaging links:
Links to Distribution Packages
https://pypi.org/project/PyTrinamic/

opensuse: I added opensuse as requested. @mabelzhang @nuclearsandwich Thanks for the hint.
PyTrinamic vs pytrinamic: @mabelzhang I have had a look at the PyYAML package (PyPI, pyyaml.org). This package also contains upper case letters in its name and is in the package name with lower case letters. An other example would be PyVirtualSerialPorts or Adafruit-Blinka, again both habe upper case letters in the name, lower case letters in the package name.
Therefore I would state that lower case letters in the package name are the more consistent choice within the rosdep.yaml file.


Add noauth support

This adds the basic config checking for noauth and creates a service client appropriately.  This also requires an update to the glide version of gophercloud to a newer version that includes the newly added noauth package.

@j-griffith I just tested this with my setup and it works well.  Could we push to get it merged?

/area openstack/standalone-cinder
pls run go get github.com/sgotti/glide-vc && glide-vc --use-lock-file, it's just to minimize the amount of vendor code we check in. I will merge!

@wongma7 Ahh, thanks! I was wondering about the glide updates!!

/lgtm

oops, glide-vc deleted the package we need :/
please edit the glide.lock file so it has the package: then do glide install -v; glide-vc --use-lock-file to get the noauth package again and prevent it from getting inadvertently deleted
   subpackages:
   - openstack
   - openstack/blockstorage/extensions/volumeactions
+  - openstack/blockstorage/noauth
   - openstack/blockstorage/v2/snapshots
   - openstack/blockstorage/v2/volumes
   - openstack/common/extensions

(sorry for lack of docs around how we use glide, I am hoping we can move to golang/dep soon since that is supposed to be a much better experience)

Thanks @wongma7 I noticed the failure and was digging at Glide to try and fix that.  I actually was thinking of proposing an update to godep, but looks like that might take some coordination.  Anyway, thanks again!!

Was glide install -v; glide-vc --use-lock-file run before this was merged?
Running glide install -v; glide-vc --use-lock-file on master, removes around ~ 60k lines of code in vendor/github.com/gophercloud/gophercloud/openstack, code which was added in this commit.
I'm only asking, because I'm vendoring github.com/digitalocean/godo in #470, and it seems a bit odd, that adding a new dependency removes ~ 75k lines.

@klausenbusk appears not, oops. you are not doing anything wrong, your looks okay to me: perhaps I could do a separate PR just to run glide install -v; glide-vc --use-lock-file again but anyhow the repo will reach desired state eventually

@klausenbusk Sorry about that, @wongma7 actually pointed that out and I thought I had it sorted but it would appear I missed something upon the actual commit.  I've submitted https://github.com/kubernetes-incubator/external-storage/pull/471 to clean that up.

@klausenbusk Sorry about that

No problem :)

I've submitted #471 to clean that up.

Thank, I will rebase when it has been merged.


AWS integration fails to create the integration and rolls back cloudformation stack with Internal failure.

Describe the bug
AWS integration fails with obscure error
To Reproduce
Steps to reproduce the behavior:
run a template that looks like this
Resources:
  DatadogAWSDatadogIntegrationAWS:
    Type: Datadog::Integrations::AWS
    Properties:
      AccountID: '123123123123'
      RoleName: shared-datadog-aws-integration
    Metadata:
      aws:cdk:path: mystack/DatadogAWSDatadogIntegrationAWS
  DatadogRoleF31A7099:
    Type: AWS::IAM::Role
    Properties:
      AssumeRolePolicyDocument:
        Statement:
          - Action: sts:AssumeRole
            Condition:
              StringEquals:
                sts:ExternalId:
                  Fn::Join:
                    - ''
                    - - '{{resolve:secretsmanager:arn:'
                      - Ref: AWS::Partition
                      - :secretsmanager:eu-west-1:123123123123:secret:DatadogIntegrationExternalID:SecretString:::}}
            Effect: Allow
            Principal:
              AWS: arn:aws:iam::464622532012:root
        Version: '2012-10-17'
      Description: Datadog integration for aws monitoring
      PermissionsBoundary:
        Fn::Join:
          - ''
          - - 'arn:aws:iam::'
            - Ref: AWS::AccountId
            - :policy/base-permissions-boundary
      RoleName: shared-datadog-aws-integration
      Tags:
        - Key: tag
          value: tag
    DependsOn:
      - DatadogAWSDatadogIntegrationAWS
    Metadata:
      aws:cdk:path: mystack/DatadogRole/Resource
  DatadogRolePolicy6CE03EE3:
    Type: AWS::IAM::Policy
    Properties:
      PolicyDocument:
        Statement:
          - Action:
              - alldatadogstuffasperdocs
            Effect: Allow
            Resource: '*'
        Version: '2012-10-17'
      PolicyName: shared-datadog-integration-policy
      Roles:
        - Ref: DatadogRoleF31A7099

Logs
1:36:58 PM | CREATE_FAILED        | Datadog::Integrations::AWS                  | DatadogAWSDatadogIntegrationAWS
Resource handler returned message: "" (RequestToken: 16b2f5a7-3d09-738e-76ae-33db3a6ad5b8, HandlerErrorCode: InternalFa
ilure)

 ❌  mystack failed: Error: The stack named mystack failed to deploy: UPDATE_ROLLBACK_COMPLETE: Resource handler returned message: "" (RequestToken: 16b2f5a7-3d09-738e-76ae-33db3a6ad5b8, HandlerErrorCode: InternalFailure)
    at FullCloudFormationDeployment.monitorDeployment (/Users/me/code/place/project/node_modules/aws-cdk/lib/api/deploy-stack.ts:505:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at deployStack2 (/Users/me/code/place/project/node_modules/aws-cdk/lib/cdk-toolkit.ts:265:24)
    at /Users/me/code/place/project/node_modules/aws-cdk/lib/deploy.ts:39:11
    at run (/Users/me/code/place/project/node_modules/p-queue/dist/index.js:163:29)

 ❌ Deployment failed: Error: Stack Deployments Failed: Error: The stack named mystack failed to deploy: UPDATE_ROLLBACK_COMPLETE: Resource handler returned message: "" (RequestToken: 16b2f5a7-3d09-738e-76ae-33db3a6ad5b8, HandlerErrorCode: InternalFailure)
    at deployStacks (/Users/me/code/place/project/node_modules/aws-cdk/lib/deploy.ts:61:11)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at CdkToolkit.deploy (/Users/me/code/place/project/node_modules/aws-cdk/lib/cdk-toolkit.ts:339:7)
    at initCommandLine (/Users/me/code/place/project/node_modules/aws-cdk/lib/cli.ts:374:12)

Stack Deployments Failed: Error: The stack named mystack failed to deploy: UPDATE_ROLLBACK_COMPLETE: Resource handler returned message: "" (RequestToken: 16b2f5a7-3d09-738e-76ae-33db3a6ad5b8, HandlerErrorCode: InternalFailure)

Expected behavior
The cloudformation should run to completion.
I expect the account integration to enable the account in datadog (this does occur)
I expect the secret to be written to secrets manager (this does NOT occur)
I expect my role to be created which I pull the secret from secrets manager (this does NOT occur)
Environment and Versions (please complete the following information):
Datadog AWS Integration 2.2.1
I am generating cloudformation via cdkv2 however I doubt this is relevant as I've included the generated cloudformation template above (which is run and faults).
Additional context
It essentially looks like the cloudformation handler is swallowing the error, which makes it very hard to troubleshoot this.
I've also logged a ticket with datadog support.

I can still reproduce this issue as shown in the orginal post.

We are facing the same error (although on Monitor and Dashboards)
We have a support case open with AWS

Thanks we just did the same, lets see what happens

Thanks for opening this issue. We are going to merge and release the change https://github.com/DataDog/datadog-cloudformation-resources/pull/257 which should catch any unhandled exceptions in the resources them selves.
However, this wouldn't expose all errors mainly because AWS does obfuscate logs/events quite heavily on their end so things such as bad type configuration and bad execution roles would still fail in non-obvious ways. Which I suspect is the reason for the failures you are seeing @flavioelawi with dashboards and monitors

We have resolved our issue;
our execution role already had the correct trust policy:
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Principal": {
                "Service": [
                    "resources.cloudformation.amazonaws.com",
                    "cloudformation.amazonaws.com"
                ]
            },
            "Action": "sts:AssumeRole"
        }
    ]
}

And a policy to allow access to the Secrets and its Kms key
        {
            "Action": [
                "secretsmanager:GetSecretValue",
                "kms:Decrypt",
                "kms:DescribeKey"
            ],
            "Resource": "*",
            "Effect": "Allow"
        },

We also added the CloudWatchLogsFullAccess managed policy to allow for the integration to push logs to Cloudwatch logs (but its log group is still empty, I guess for another issue)
The issue in our case was a typo in the dynamic reference, where we were missing the SecretString part before the Json attribute selector.
@dogfish182 in your case you are missing external_id from your dynamic reference at the end, this is what is setup by the integration lambda/code
Also some feedback:

It would be useful to know for each integration, what kind execution policy and trust policy is expected in the execution role.
I can't find it anymore, but was there a github issue in the upstream aws/cloudformation project about LogConfiguration not working?

We released the AWS resource version 2.4.0 that should capture and return any unhandled exception on the resource it self. However, as mentioned previously, errors swallowed by AWS would probably still not be captured by this change as it happens outside of the resource handler.


Multi-pass raster object.

Raster the same image several times at different speeds for different cut times. There's no need to raster the same pixels repeatedly at the same speed. If we calculate the pixel time to burn amount based on the heat impact, we can actually get pretty significant detail overall in a couple passes.

Some really skilled laser folks with the M2 nano. Do different passes at different speeds in order to get different depths. While it's entirely reasonable to run a series of  images to try to match a grey scale. It could also be the case that other pixel information could be used to store this same data.
We could, for example, raster all the red pixels at one speed and all the blue pixels at a different speed. Cutting different slices out of the image. This could also be done based on shade, so we run a raster that divides up the image based on the image shade. So we run all the pixels with a darkness of 127 to 200 in value, at one speed and all the pixels of 0-127 at a different speed.
This could be done like the zraster where the image processing is done beforehand and cut into slices. Since those parts are pretty reasonable.

With RasterWizard and other modifications like Zrasters there's some clear need for this feature to be its own object. It would store the original image and several processed sub-images which would be rastered in order. It would need to provide the ability to flip through these different passes, and have each of them rendered in different ways with some different properties. But, they would all move and act as a group. And functionally allow access to each frame within the multi-pass object.

This would also allow different backstroke objects, for unidirectional rastering where the backstroke is utilized to also provide information.
This would allow z-raster objects to be a real and understandable thing.  Since they must overlap and you can't see the ones below the other ones. You could also do a couple passes to pretty exactly match PWM rastering. Mostly because you could modulate the pixel level heat impact at each point.
These would store the original image, so you could apply more RasterWizard to other objects without breaking the original.
These would allow hybrid single images that are cropped/sliced into multiple images, so you could have an image-series that is several images but these would be processed in series rather than in parallel.

There's some need to allow slice and slash to define an image-cluster thing so they can be moved as one even while they are multiple different image elements. So 1 image set in 2 parts and their positions relative to each other is paramount. Though this might just be defined a bit as group.

I think that there is some real merit here - but the scene UI would be ... um ... messy if we are not careful and I am unclear what the UI would look like to create this stuff (just console commands?). If we could do variable speed to handle grey scale in some automated fashion, that would be awesome, especially if the results are way way better - however I am sceptical that a picture (which has extremely variable greyscale) could be rendered with varying the speeds that quickly.
HOWEVER...
This does make me wonder whether there is scope for e.g. wood carving (in the same way that 3d printers do lithophanes) by automatically varying speed and number of burns based on grey scale.

Assuming a perfect material which evaporates away at a rate entirely proportional to the laser energy it receives (so you can raster as slowly as you want without e.,g. it bursting into flames), and zero spread of heat to surrounding areas (so that you don't need to use multiple passes in order to allow surrounding material to cool down between passes), then is there really any difference between this proposed approach and a much, much slower single raster using greyscale PPI to vary the depth of material burned away?
Of course, wood, leather, acrylic etc. are not perfect materials. Leather and wood char from material either side of the cut overheating. and acrylic melts locally instead. But I do wonder how much of this can be done with one pass at slower speed and variable use of PPI to adjust the depth of burn.

The UI object would need to be different than other types. Like a group where everything is anchored in place. And It's not clear how we iterate through the different layers. But, you if we could specify that a layered object it might be useful. There's some big gaps in implementation after that idea though, because even if we modify the other routines in various ways I don't really see how the UI works. I guess we flip through them like a book or something?


Fix issue #252 make header responsive for mobile device

resolve conflict

not accepted

@Gyanthakur , I had some issues, so I forked the repository again and am working on it. After resolving the issue, I'll submit another pull request.


Optional ACAHs: X-XSRF-TOKEN

Hi everyone!
I'm using latest version (2.9.2) of this awesome project to describe my endpoints. Some of them are secured by Keycloak server (OAuth2 authorization flow) and i implemented a Swagger-UI OAuth2 security schema. Everything seems ok, but what's the problem? Keycloak server (which i'm not in control) not allow 'Access-Control-Allowed-Headers : x-xsrf-token' header, so then i'm trying to get JWT, request which made by swagger-ui always blocked by mu IDP.
Can this feature - sending CSRF token to external IDP endpoint may be optional?

Ok, I found what if I implement /csrf endpoint (for not getting HTTP/404) X-XSRF-TOKEN will be added to access headers automaticaly by this function getCsrfFromCookie() from springfox-swagger-ui/src/web/js/csrf.js.
Is it possible to provide some flag from SecurityConfiguration to that function's context?

@iutipikin seems like you're further along in the research than I am. Would be happy to accept any fix you think might fix it.

Ok, I wrote it in #2434 . ORZ 😢
Because I didn't know how to add options, I can only try to fetch the CSRF token. There are three steps:

fetch http://your-base-url/
fetch http://your-base-url/csrf
search your cookie

If your server do not support csrf, you'll see two 404 requests, but everything is ok and there are no errors. These requests are just trying to find your csrf token. If a csrf token is found, it will be automatically added to your request header.
I guess I found how to add options, I will send a pr to make these behaviors optional.

Relate issues: #2633 #2603 #2573

Pull request https://github.com/springfox/springfox/pull/2706

Thank you @fennekit

Thank you @fennekit

@dilipkrish , We are also facing the same issue #2633. Do you  think the PR @fennekit  created will resolve the issue and if yes, can we expect this in the next version?


Default timetable entry/displaying

PR #16, moving

Reusing this issue because I'm too lazy.
Essentially this is coming back for 2.0, because of the ways information will be used from now on.

Done! Read the update in #25 and review code if you're interested. TL;DR: backend supports storage, make your own frontend!


Update CMakeLists.txt for cross compiling

this line has no effect on building
and for cross compiling it produce error

This line is needed to check for presence of opencl.hpp

Then pass OpenCL_INCLUDE_DIRS in cmake so that it finds the header


feat: exclamation mark to signifying breaking (fixes #52)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 10 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 91.404%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
805

Relevant Lines:
880

💛  - Coveralls

https://github.com/versionize/versionize/issues/52


Boilerplate: Update to 74d5197fa56b3b1f2685c0f6a3f8f4830620eb60

Conventions:

openshift/golang-osd-operator: Update
openshift/golang-osd-operator-osde2e: Update ---
https://github.com/openshift/boilerplate/compare/1f4c22171986ee1bc913ac03f6a026db74b1ed14...74d5197fa56b3b1f2685c0f6a3f8f4830620eb60

commit: 8d301f75a4834309df0ab738ecb36716aa5a32a8
author: Mariusz Mazur
Add Cicada team to OWNER_ALIASES
commit: 4481e2f2b413a18abadaa5bab98f947e6ff13dd4
author: Brian Smith
OSD-25018 - Address opm bug (#397)

Addresses a bug in opm

updating opm version

adding pr check script

previous commit was not needed

commit: b61be6084af9b5b4a1151796da4349064e4c956b
author: Bo Meng
update owners for function teams
commit: 26b5db5026752aaa7f2ee8f249a806f316659ca9
author: red-hat-konflux[bot]
chore(deps): update konflux references to b202de7
Signed-off-by: red-hat-konflux<EMAIL_ADDRESS>commit: 4003c1f33d8b5675d4288ca5fa993f2bfe1ace47
author: Brady Pratt
.tekton: task-build v0.2 migration
https://github.com/konflux-ci/build-definitions/blob/main/task/buildah/0.2/MIGRATION.md
Signed-off-by: Brady Pratt<EMAIL_ADDRESS>commit: 31ccebad20641b02f07f8af02d0188e7c98d2fe2
author: red-hat-konflux[bot]
chore(deps): update konflux references
Signed-off-by: red-hat-konflux<EMAIL_ADDRESS>commit: 0a32ab39a389b1b101db95a80e5af5b3755c265f
author: Isaac
Fix typo
commit: 9521066eb0e65f819a445d0c3635c6b4c9af56c7
author: Isaac
Rollback bundle image tag requiring 'g' prefix
commit: b2f15720f6220dcf9660aeffad8da988b7691587
author: Isaac
Fix repo image tag prefix
commit: 480276a85fef665112ca9d672fefeaf09dc8831b
author: Isaac
Fix typo while accessing OLM_CATALOG_IMAGE env var
commit: 2f031930795a7daaa1a0ce4d9a18341ffe7ead15
author: Brady Pratt
KONFLUX-3729: drop setting user
leading to permission denied when trying to build
Signed-off-by: Brady Pratt<EMAIL_ADDRESS>commit: 9545e4f7f13e9afdace60efc7fea18e3d5952b21
author: Tomáš Remeš
fix the non-existing variable in build-opm-catalog.sh
commit: 72a590351f29142850b046d1a1acbfa2d8cafb46
author: Tomáš Remeš
update the condition
commit: e82858376005d927e21ce1a9f69ba5ed75916cd3
author: Tomáš Remeš
fix the build-opm-push targe after d4f5e8add3d7afdd361c069d18ae7582943273bd commit
commit: 571b278a49528f3512e754ec9041668c0fb62254
author: Brady Pratt
config: dl yq from gh releases
go mod cache downloads the entire git repo to build the project, and this cache stays in the final image. When scanned by Syft, it finds the github workflow files for yq. This then generates a garbage package URL which causes a false positive.
This is likely a bug in Syft, but we can work around it for now by downloading directly from GH releases.
https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1722411065681639?thread_ts=1722365748.535409&cid=C04PZ7H0VA8
Signed-off-by: Brady Pratt<EMAIL_ADDRESS>commit: dfd1bf05ef0a2b3c2b76e970fba20e87f136dc95
author: Brady Pratt
KONFLUX-3729: set user and copy license
preflight checks are failing otherwise
"failed": [
    {
        "name": "HasLicense",
        "elapsed_time": 0,
        "description": "Checking if terms and conditions applicable to the software including open source licensing information are present. The license must be at /licenses",
        "help": "Check HasLicense encountered an error. Please review the preflight.log file for more information.",
        "suggestion": "Create a directory named /licenses and include all relevant licensing and/or terms and conditions as text file(s) in that directory.",
        "knowledgebase_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction",
        "check_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction"
    },
    {
        "name": "RunAsNonRoot",
        "elapsed_time": 0,
        "description": "Checking if container runs as the root user because a container that does not specify a non-root user will fail the automatic certification, and will be subject to a manual review before the container can be approved for publication",
        "help": "Check RunAsNonRoot encountered an error. Please review the preflight.log file for more information.",
        "suggestion": "Indicate a specific USER in the dockerfile or containerfile",
        "knowledgebase_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction",
        "check_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction"
    }
]

Signed-off-by: Brady Pratt<EMAIL_ADDRESS>commit: 734c00455acd0b44852b222ad1af44f00da40e7a
author: Brady Pratt
KONFLUX-3729: set source-build true
and format the on-cel-expression
Signed-off-by: Brady Pratt<EMAIL_ADDRESS>commit: d5d810b4e8534655fdf8375013bd3dacab29c78b
author: red-hat-konflux
Red Hat Konflux update image Signed-off-by: red-hat-konflux<EMAIL_ADDRESS>commit: 1d6fe5fa5284f2c5b725bdffd364bdaf76ec719c
author: erosente
add check that new version and previous version are not the same.
commit: 333c2d14c98b75db87070e060201f9a40f47a001
author: Tomáš Remeš
fix the python usage in build-opm-catalog.sh too
commit: 163fa4ae2174c8875dc81af2593b6d9b83187687
author: Tomáš Remeš
fix opm-build-push command to use python venv
commit: bed447edd4a2a588118f87a753f9081f5eab4cf2
author: Brady Pratt
KONFLUX-3729: add containerfile for konflux
the base image needs to be one built in Konflux, the brew golang builder works for now.
Signed-off-by: Brady Pratt<EMAIL_ADDRESS>commit: 723a44471cf0fe2cf6dcc4369d207d6c52a32aba
author: Michael Shen
Update e2e harness image to Go 1.22

The openshift CI team no longer wishes to support the release/golang-* images moving forward

Signed-off-by: Michael Shen<EMAIL_ADDRESS>commit: e8a73611ad9810a8373401a3dd4cb40039663c24
author: Mariusz Mazur
Add mmazur to reviewers/approvers
With the RVMO work I had to familiarize myself with the olm bits of this, so while I couldn't ack any PR, I could ack some.
What type of PR is this?
(bug/feature/cleanup/documentation/test/refactor)
What this PR does / why we need it?
Which Jira/Github issue(s) this PR fixes?
Fixes #
Special notes for your reviewer:
Pre-checks (if applicable):

[ ] Tested latest changes against a cluster
[ ] Included documentation changes with PR

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.54%. Comparing base (e08b35f) to head (c03ee8a).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   46.54%   46.54%
=======================================
  Files           9        9
  Lines         752      752
=======================================
  Hits          350      350
  Misses        392      392
  Partials       10       10

/lgtm
/approve


Cannot Create a trigger on a  DynamoDB created with the CLI

Describe the bug
I tried to create a trigger from a DynamoDB table created from the CLI but I got some errors on the console
To Reproduce

amplify add api: and create a simple model (im my case I create this:

type Lead @model {
  id: ID!
  fullname: String!
  email: AWSEmail!
  phone: String!
  serviceType: Service
  comment: String
}

enum Service {
  RESIDENCIAL
  COMERCIAL
  INDUSTRIAL
}

amplify add function: create a simple function. add whatever name. no edit needed
amplify push
amplify api console
go to the triggers tab and create a new trigger from an existing Lambda Function
in the popup, Select the previous function created and leave the other inputs as is.
click on create nad you will see the error below

Cannot access stream arn:aws:dynamodb:eu-west-1:115238827609:table/Lead-xwwfwne24nd43feacszaupqof4-staging/stream/2019-08-25T15:08:37.527. Please ensure the role can perform the GetRecords, GetShardIterator, DescribeStream, and ListStreams Actions on your stream in IAM. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 4f297881-6498-49c3-b237-97e902972409)

Expected behavior
I expect the trigger to be created and let me edit/update my function on my editor and push it via the amplify cli.
Screenshots

Desktop (please complete the following information):
Model Name:	MacBook Pro
Model Identifier:	MacBookPro11,3
Processor Name:	Intel Core i7
Processor Speed:	2.5 GHz
Number of Processors:	1
Total Number of Cores:	4
L2 Cache (per Core):	256 KB
L3 Cache:	6 MB
Memory:	16 GB
Google Chrome:
  Version: 76.0.3809.100
  Obtained from: Identified Developer
  Last Modified: 8/6/19, 2:29 AM
  Kind: Intel
  64-Bit (Intel): Yes

Additional context
I tried it with a function created from the cli and with another functionc reated directly in the console. on both cases I got the same error so my assumption is that cloudformation is not doing something on the DynamoDB and prevent this to work properly.

thanks for the solution @kaustavghosh06 !
I'm not too familiar with all AWS tools, can you give me a more detailed step by step?

where do I need to add this code you mentioned?
do I need to change something in the console?
can everything be done via de CLI and this snippet?

thanks!

@horacioh Sorry for the late response:

You would need to modify this via the console for tables managed by the GraphQL transformer, but this should soon be addressed out of the box - as a part of the CLI - as a part of this PR - https://github.com/aws-amplify/amplify-cli/pull/2463

In the meanwhile, you can go the Lambda console - go to your Lambda function trigger -> Find out the Lambda Execution Role Name -> Attach the policy mentioned above as a part of the Lambda execution role in the IAM console.

Answered in 1.


Conditionally import JSX codemirror mode for SSR

Without this condition, we attempt to load the codemirror mode on the server, which breaks because it depends on being used in the browser. With this change, you can safely use component playground in server (and static) renders. :metal:
Resolves #75
/cc @kenwheeler @paulathevalley

LGTM


The login page at localhost:8080 have Bad Request

I am using Ubuntu 16.04.
I followed the tutorial and installed it successfully, but on the second day, when I ran the docker, it couldn't open the page, showing the 400 status code（Bad Request）, how can I fix this?
The output of the docker-compose up -d command was:
Creating network "cvat_default" with the default driver
Creating cvat_db ... done
Creating cvat_redis ... done
Creating cvat ... done
And the output of docker logs cvat:
logs.txt

HI @Yeah-Kun ,
Thank you for the report. Could you please insert here output of docker ps | grep cvat command?

HI @nmanovic ,
This is the information  what you need.
ffe3f099af46        cvat                   "/usr/bin/supervisord"   9 hours ago         Up 2 minutes        <IP_ADDRESS>:8080->8080/tcp, 8443/tcp, <IP_ADDRESS>:80->8080/tcp   cvat
ba6e707eb525        redis:4.0.5-alpine     "docker-entrypoint.s…"   9 hours ago         Up 2 minutes        6379/tcp                                                 cvat_redis
d92ae96756d6        postgres:10.3-alpine   "docker-entrypoint.s…"   9 hours ago         Up 2 minutes        5432/tcp                                                 cvat_db

Hi @Yeah-Kun ,
Let's do one more experiment:

docker-compose down (it will delete container and any broken files if you have any)
Inside https://github.com/opencv/cvat/blob/master/supervisord.conf file please replace apache log level from INFO to DEBUG (it will do logging from apache module more verbose)
docker-compose up -d --build (rebuild and run containers with changes above)
Go to 'http://localhost:8080/' and report results. If the problem is still exists please attach logs again.

Additional questions:

Did you do any source code modifications? (except INFO -> DEBUG)

Thanks @nmanovic ,
I have done the steps you said, but there is still this problem.
I just follow the steps in the tutorial and  never modified the code before.
Here is the logs:
cvat_logs.txt

Hi @Yeah-Kun ,
Thanks for your patience. To be honest I don't know a reason of the issue. I can reproduce BAD REQUEST only if I try to access the server using my hostname instead of localhost (without modifying ALLOWED_HOSTS).
Let's do the latest attempt with TRACE8 log level for Apache:

Run docker-compose down (it will delete container and any broken files if you have any)
Inside https://github.com/opencv/cvat/blob/master/supervisord.conf file please replace apache log level from INFO to TRACE8 (it will do logging from apache module more verbose)
Run docker-compose up -d --build (rebuild and run containers with changes above)
Go to 'http://localhost:8080/'.
Send us logs

Also it makes sense to clean cookies and/or try another browser. I hope these two experiments will give us some hints to root cause the problem. It is especially strange that you had working configuration and next day it didn't work.

Hi@Yeah-Kun ，
I have the same problem.
Have you solved this problem?

Hello @nmanovic ,
I am also thanks for your patience, your attitude makes me feel surprised.
This is the log what you need, I hope it will help you to figure the problem.
cvat_logs.txt

Hi, I am having this same problem. I have tried the suggestions here but to no avail. I also tried using a different browser, in incognito and after clearing the cache. Could we reopen the issue? Thank you!

You maybe can check your The docker config the local ip

@kmstumpf , you can use gitter.im/opencv-cvat for such questions. In general you need to provide more information. For example, logs of your CVAT instance.

the problem occurs when you try to access via ip address . it works fine with localhost:8080
i was trying to connect to cvat from another system so i used ip address and got the error bad request (400)


KE blocks keyboard when waking up on 10.12.1 (16B2338c)

A really strange but definite thing happens on macOS Sierra 10.12.1 public beta 3 (build 16B2338c). Given: MBA 13" mid 2012, embedded keyboard.
When trying to wake-up the laptop from sleep by pressing any key, the black sleep screen does not fade away, whatever key is being pressed. Only trackpad or the power button are able to wake the laptop up. Important notes:
a) Right after reboot, if I'm not logging in for a while letting the laptop to enter sleep mode, a key press DOES wake it up. But only the first wake-up after a reboot works so, any following does not.
b) All keystrokes I press when trying to wake the thing up, get recorded and show up in the password field as dots.
Also, sometimes after login I get a Bluetooth Setup Assistant window that searches for a bluetooth keyboard and says that I don't have any keyboard connected. Not sure if this has something to do with the KE.
If I quit the KE everything gets to normal. Prior to PB3 of Sierra I had no such a problem. Guess Apple changed some thing in keyboard drivers for support of the future MPB's rumored touch bar.

Ah ha, that's what it is! I'm experiencing these exact symptoms in Sierra 10.12 (doesn't wake up, bluetooth setup assistant comes up), but I assumed it was a bug in Sierra, didn't think it might be related to KE.

I think this is the same as #64

Duly noted. Thanks!

Lol, I thought this was a Sierra bug /o\ Makes sense now... Good to learn also that I'm not the only one getting the bluetooth setup assistant.


OctopOS Prime Penta Series-2

You are expected to design a short animation for OctopOS Prime in the composition of your choice.

DONE MA'AM


Cannot find file cdk.Dockerfile when using AWS CDK

Bug Description
Hi I tried to run AWS CDK on AWS cloud9 and my laptop (Mac book) for deploying Langflow onto AWS, but cdk bootstrap raises the error.
Error: Cannot find file at /Users/masaki/github/langflow/cdk.Dockerfile
    at new DockerImageAsset (/Users/masaki/github/langflow/scripts/aws/node_modules/aws-cdk-lib/aws-ecr-assets/lib/image-asset.js:1:2174)
    at new EcrRepository (/Users/masaki/github/langflow/scripts/aws/lib/construct/ecr.ts:40:37)
    at new LangflowAppStack (/Users/masaki/github/langflow/scripts/aws/lib/cdk-stack.ts:36:38)
    at Object.<anonymous> (/Users/masaki/github/langflow/scripts/aws/bin/cdk.ts:8:1)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)
    at Module.m._compile (/Users/masaki/github/langflow/scripts/aws/node_modules/ts-node/src/index.ts:1618:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
    at Object.require.extensions.<computed> [as .ts] (/Users/masaki/github/langflow/scripts/aws/node_modules/ts-node/src/index.ts:1621:12)
    at Module.load (node:internal/modules/cjs/loader:1317:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1127:12)

This says ecr.ts does not find langflow/cdk.Dockerfile and we can find the file atlangflow/docker/cdk.Dockerfile in this repo. Thus, the following fix on the line may be needed.
https://github.com/langflow-ai/langflow/blob/main/scripts/aws/lib/construct/ecr.ts#L22
const backendPath = path.join(__dirname, "../../../../../", "langflow")

should be
const backendPath = path.join(__dirname, "../../../../", "docker")

The fix works for me. Could you check my suggestion?
Reproduction
Following the steps in this readme, we will see the error when running cdk bootstrap.
https://github.com/langflow-ai/langflow/tree/main/scripts/aws
Expected behavior
Complete cdk bootstrap without errors.
Who can help?
No response
Operating System
Sonoma 14.4 (mac) and Amazon Linux 2023 (Cloud9)
Langflow Version
1.0.15
Python Version
3.12
Screenshot
No response
Flow File
No response

@harusametime
Do you need any assistance with this case? If not, please let us know if this issue can be closed.

Thank you for your contribution! This issue will be closed. If you have any questions or encounter another problem, please open a new issue and we will be ready to help you.


Find another way to access $scope.currentUser

GROUPINGS-853

Hey, in GroupingsRestController, remove the parameter from your currentUsername method, autowire in UserContextService class into the class, then call it get the current user. And for currentUsername, you should be able to return the User class. You have a unusual hack in there now, I think because you tried to return the value in the ok builder method instead of the body method.

Also, forgot to ask... do you have the name of a html file that has that  'name' field on it so that I can look at it?

All these intermixed commits from various people just can't be right process-wise.


DKIM verification fails due to msg body modification by private relays/transfer agents

An edge case that causes DKIM verification failure is when the email comes from a private relay service or a transfer agent. These intermediaries modify the body without updating the expected hash in the header.
One specific example is if Apple users select to "sign-in with Apple ID" for certain apps (i.e. Yelp), Apple will relay the email from Yelp to the receiver all under emails hosted by privaterelay.appleid.com. Even though the signature passes, the body hash check fails.
    const dkimResult = await dkimVerify(rawEmail);
    console.log(dkimResult)

spits out the following error:
    {
      headerFrom: [
<EMAIL_ADDRESS>      ],
      envelopeFrom<EMAIL_ADDRESS>      results: [
        {
          signingDomain: 'privaterelay.appleid.com',
          selector: 'prv2019',
          // abbreviated
          bodyHash: 'y/pRNiQ3oAGue/rXnUlbK8RE5WJKj5yqLqfVTXbD9vQ=',
          bodyHashExpecting: 'hf7kLUsqHDsk69NP7DoTs/lTLUh4F88Ec0c3kQ42a3k=',
          // abbreviated
          info: 'dkim=neutral (body hash did not verify<EMAIL_ADDRESS>header.s=prv2019 header.a=rsa-sha256 header.b=XjoKCxjS'
        }
      ]
    }

One way to fix this is to skip the body hash check entirely if we detect that the email is coming from a whitelisted relay service. Or one can check exactly where Apple is tempering with the body and excise that section to get the body hash.

@VasuK111 this will also be helpful for you to fix this edge case!

Sure, in the meantime I'm working on the DKIM edge cases issue, this will somehow be indirectly involved for fixing those edge cases, I think I can be assigned with this issue as well since I am indirectly solving this as well.

But how do I whitelist beforehand a particular relay service? @Divide-By-0 @winnsterx . Any thoughts please?

@saleel was this fully fixed with tests? i forget

We do have the infra and some cases are handled, but not sure if it covers the Apple case mentioned above.
If its not covered, we need to identity the changes made by Apple and add a sanitizer to revert that.
@winnsterx In you email do you also have a dkim signature from yelp? If so, its better to use with that, so verifier is trusting yelp signature and not apple-relayer (which could have same key for other domains as well?)


License

Hello,
is it possible to provide a license for this repository?
https://help.github.com/articles/licensing-a-repository/

I added an MIT license


Possible to get no results message and a stock at the same time

Something something asynchronous..

Fixed by #228


Allow for Remapping of Selected Tokens Only

Is your feature request related to a problem? Please describe.
A user may want to map five from the 10 tokens that have a matching name, but are currently restricted to do so. Currently users can either remap a single token or use the bulk-remap feature which remaps (regardless of selected or not)all the tokens with matching names.
Describe the solution you'd like
Allow users to remap only the selected tokens.
Definition of done

Can select multiple tokens and remap only the selected tokens

### Tasks
- [ ] https://github.com/tokens-studio/figma-plugin/issues/2185

+1

@LukeFinch proposing we close as this is a feature avail in the plugin today unless I'm not understanding the request.


Error while upgrading to rescript >=10

When I update the rescript version, the pipeline breaks while compiling bs-css.
Dependency on bs-css
07:21:38.090 | rescript: [1/21] src/Css_Core.ast
07:21:38.094 | rescript: [2/21] src/Css_Colors.ast
07:21:38.098 | rescript: [3/21] src/Css_Js_Core.ast
07:21:38.104 | rescript: [4/21] src/Css_Js_Core.iast
07:21:38.105 | rescript: [5/21] src/Css_AtomicTypes.ast
07:21:38.106 | rescript: [6/21] src/Css_Core.d
07:21:38.108 | rescript: [7/21] src/Css_Colors.d
07:21:38.109 | rescript: [8/21] src/Css_AtomicTypes.iast
07:21:38.110 | rescript: [9/21] src/Css_Js_Core.d
07:21:38.126 | rescript: [10/21] src/Css_AtomicTypes.d
07:21:38.134 | rescript: [11/21] src/Css_Legacy_Core.ast
07:21:38.142 | rescript: [12/21] src/Css_Legacy_Core.iast
07:21:38.145 | rescript: [13/21] src/Css_Core.cmj
07:21:38.146 | rescript: [14/21] src/Css_Legacy_Core.d
07:21:38.166 | rescript: [15/21] src/Css_AtomicTypes.cmi
07:21:38.225 | rescript: [16/21] src/Css_Js_Core.cmi
07:21:38.258 | rescript: [17/21] src/Css_Legacy_Core.cmi
07:21:38.272 | rescript: [18/21] src/Css_AtomicTypes.cmj
07:21:38.341 | rescript: [19/21] src/Css_Colors.cmj
07:21:38.447 | rescript: [20/21] src/Css_Legacy_Core.cmj
07:21:38.480 | rescript: [21/21] src/Css_Js_Core.cmj
07:21:38.494 | rescript: [1/27] Css_Core.cmi
07:21:38.496 | rescript: [2/27] Css_Core.cmj
07:21:38.496 | rescript: [3/27] Css_Core.cmt
07:21:38.498 | rescript: [4/27] Css_Core.res
07:21:38.499 | rescript: [5/27] Css_Colors.cmi
07:21:38.502 | rescript: [6/27] Css_Colors.cmj
07:21:38.505 | rescript: [7/27] Css_Colors.cmt
07:21:38.506 | rescript: [8/27] Css_Colors.res
07:21:38.508 | rescript: [9/27] Css_Js_Core.cmi
07:21:38.509 | rescript: [10/27] Css_Js_Core.cmj
07:21:38.511 | rescript: [11/27] Css_Js_Core.cmt
07:21:38.512 | rescript: [12/27] Css_Js_Core.res
07:21:38.513 | rescript: [13/27] Css_Js_Core.resi
07:21:38.515 | rescript: [14/27] Css_AtomicTypes.cmi
07:21:38.516 | rescript: [15/27] Css_Js_Core.cmti
07:21:38.518 | rescript: [16/27] Css_AtomicTypes.cmt
07:21:38.521 | rescript: [17/27] Css_AtomicTypes.cmj
07:21:38.521 | rescript: [18/27] Css_AtomicTypes.res
07:21:38.525 | rescript: [19/27] Css_AtomicTypes.resi
07:21:38.526 | rescript: [20/27] Css_AtomicTypes.cmti
07:21:38.528 | rescript: [21/27] Css_Legacy_Core.cmi
07:21:38.528 | rescript: [22/27] Css_Legacy_Core.cmj
07:21:38.528 | rescript: [23/27] Css_Legacy_Core.cmt
07:21:38.529 | rescript: [24/27] Css_Legacy_Core.res
07:21:38.529 | rescript: [25/27] Css_Legacy_Core.resi
07:21:38.531 | rescript: [26/27] install.stamp
07:21:38.531 | rescript: [27/27] Css_Legacy_Core.cmti
07:21:38.532 | Dependency on bs-css-emotion
07:21:38.532 | Different compiler version: clean current repo
07:21:38.534 | Cleaning... 28 files.
07:21:38.538 | Cleaning... 10 files.
07:21:38.563 | rescript: [1/6] src/Css.ast
07:21:38.563 | rescript: [2/6] src/CssJs.ast
07:21:38.565 | rescript: [3/6] src/Css.d
07:21:38.566 | rescript: [4/6] src/CssJs.d
07:21:38.575 | rescript: [5/6] src/Css.cmj
07:21:38.575 | FAILED: src/Css.cmj
07:21:38.575 |
07:21:38.575 | We've found a bug for you!
07:21:38.575 | /vercel/path0/dapp/node_modules/.pnpm/bs-css-emotion@2.5.1/node_modules/bs-css-emotion/src/Css.re:1:9-23
07:21:38.575 |
07:21:38.575 | 1 │ include Css_Legacy_Core;
07:21:38.575 | 2 │ include Css_Colors;
07:21:38.575 | 3 │
07:21:38.575 |
07:21:38.575 | The module or file Css_Legacy_Core can't be found.
07:21:38.575 | - If it's a third-party dependency:
07:21:38.575 | - Did you list it in bsconfig.json?
07:21:38.575 | - Did you run `rescript build` instead of `rescript build -with-deps`
07:21:38.576 | (latter builds third-parties)?
07:21:38.576 | - Did you include the file's directory in bsconfig.json?
07:21:38.576 |
07:21:38.579 | rescript: [6/6] src/CssJs.cmj
07:21:38.579 | FAILED: src/CssJs.cmj
07:21:38.579 |
07:21:38.579 | We've found a bug for you!
07:21:38.579 | /vercel/path0/dapp/node_modules/.pnpm/bs-css-emotion@2.5.1/node_modules/bs-css-emotion/src/CssJs.re:1:9-19
07:21:38.579 |
07:21:38.579 | 1 │ include Css_Js_Core;
07:21:38.579 | 2 │ include Css_Colors;
07:21:38.579 | 3 │
07:21:38.579 |
07:21:38.579 | The module or file Css_Js_Core can't be found.
07:21:38.579 | - If it's a third-party dependency:
07:21:38.580 | - Did you list it in bsconfig.json?
07:21:38.580 | - Did you run `rescript build` instead of `rescript build -with-deps`
07:21:38.580 | (latter builds third-parties)?
07:21:38.580 | - Did you include the file's directory in bsconfig.json?
07:21:38.580

ok, bs-css can be built but not the dependencies. is rescript 10 supposed to work with yarn workspaces ?

We use pnpm workspaces and rescript 10 is working in other packages


Sync prod and staging

This PR is to sync prod and staging branches so that the shipping of features at the end of every sprint is seamless.

FIXED
Merged but feel free to review the changes made.


ADDED SIMPLE FUNCTIONS FOR RETRIEVING INFO FROM SCOUT AND HOUSEKEEPER

The functions are at the moment not very sophisticated. It should
discussed more thoroughly what information one need to extract,
and what will be stored in the DB at a later stage.

👍


Dark Sky has joined Apple and no longer accepting new signups

Hi everyone! I can't reproduce an example, because I can't register Dark Sky API.
Will try to use fake data.

It is duplicate of #211

@Nastradamus If you still want real data, instead of using this repo, use this one.


Create ability to display .txt transcripts

This was finished a long time ago. Guess we forgot to close it.

Actually this is the work on Open Vault, not AAPB, so this work hasn't been done yet.


Avoid cycle-redirecting user/login page

Fix #28231, and remove some unused code. The db.HasEngine doesn't seem useful because the db engine is always initialized before web route.

I was unable to create a backport for 1.21. @wxiaoguang, please send one manually. :tea:
go run ./contrib/backport 28636
...  // fix git conflicts if any
go run ./contrib/backport --continue


Request: Scanning filtering by manufacturer ID

This is a feature request, but we recently had to abandon our use of this library due to not being able to scan filter by manufacturer ID (at least on Android, don't know what iOS world looks like).  I had added the functionality locally to the library just by passing through a manufacturerID and calling if that value was provided
                ScanFilter.Builder builder = new ScanFilter.Builder();
                builder.SetManufacturerData(manufacturerId.Value, Array.Empty<byte>() );
                ScanFilter filter = builder.Build();
                scanFilters.Add(filter);

Scan filtering should even make it possible to scan while the screen is off on Android, see #565.

Scan filtering should even make it possible to scan while the screen is off on Android, see #565.

@janusw I have a fork with working additional scan filtering (by MAC address for my needs). I can confirm this does let me scan whilst the screen is off on Android. Are you accepting PRs or should I hold off?
As far as I can see, the only scan filter supported by iOS is by service UUID (see the docs) If implemented, I  think it's worth making it clear that these additional filters will only have any effect on Android.
As a side note - most of the beacons I work with do not advertise a service UUID at all, annoyingly - hence me needing to go by MAC address for my app. It is going to make background scanning on iOS (which requires a filter) nigh on impossible for my needs. Any thoughts on that are welcome!

Scan filtering should even make it possible to scan while the screen is off on Android, see #565.

@janusw I have a fork with working additional scan filtering (by MAC address for my needs). I can confirm this does let me scan whilst the screen is off on Android. Are you accepting PRs or should I hold off?

A PR would be more than welcome 👍

As far as I can see, the only scan filter supported by iOS is by service UUID (see the docs). If implemented, I think it's worth making it clear that these additional filters will only have any effect on Android.

Agreed.

As a side note - most of the beacons I work with do not advertise a service UUID at all, annoyingly - hence me needing to go by MAC address for my app. It is going to make background scanning on iOS (which also requires a filter) nigh on impossible for my needs. Any thoughts on that are welcome!

It might just be impossible to do background scanning on iOS. We have to live with the limits imposed by the OS and the API.

@janusw ok thanks for the reply, I'll have a look at getting a PR done. Are you ok if I update the android compilation to Android 12, or want me to leave it at 8 where it is?

@janusw ok thanks for the reply, I'll have a look at getting a PR done.

Great!

Are you ok if I update the android compilation to Android 12, or want me to leave it at 8 where it is?

Don't have a strong opinion on that. I think up to now this library mostly took the conservation approach, only bumping the target version when it's really required. I think there were no significant bluetooth API changes in the latest Android versions (except for permissions), so we might as well stick to the Android 8 target for now, as long as there is no real advantage in updating.

@janusw @janusw I am trying to compile the BLE.Client.Droid project to get started on this PR, but I am getting a confusing build error.
    Error CS0006: Metadata file 'C:\projects\xamarin-bluetooth-le\Source\MvvmCross.Plugins.BLE.Droid\bin\Debug\MvvmCross.Plugins.BLE.Droid.dll' could not be found

This would seem to be a file that the build itself would create, so I'm not sure what's what. I've tried to usual suspects, deleting bin/obj folders, restarting, clean clone to a new folder etc. I'm running on windows with VS 2019 16.11.9
Have you encountered this at all?

I finally fixed this -  I opened a developer command prompt for vs 2019 to the ble.client.droid folder and ran MSbuild from there, and from the MVVMCross droid package. It built, then subsequent builds started working in visual studio. Ours is not to reason why...

@janusw here's the PR https://github.com/xabre/xamarin-bluetooth-le/pull/578

Fixed via #578.

Apart from filtering on Manufacturer data, it would also be good to have a way to filter on Service data. Right now one can only filter on Service UUID (by passing it directly to IAdapter.StartScanningForDevicesAsync).

Service-data filtering was added with #588.


ecs: export ComponentGroup

What?
exports ComponentGroup
Why?
it was missing, apparently by mistake

Hi there, thanks for this contribution!
Although we need ComponentGroup types, that class was never meant to be "instantiable" from the outside.
What is the motivation behind this PR? the first or the former?

i use a custom build (webpack + babel + typescript), and i import the types explicitly. one of my classes has a member property which is a reference to a ComponentGroup, so i need to import the type to declare it.


NIFI-3093 HIVE Support for QueryDatabaseTable

This update adds HIVE support to QueryDatabaseTable.
I included a few changes to GenerateTableFetch, but these were only for compatability with the new properties added to the DB Adapter interface. This does NOT add support to GenerateTableFetch for HIVE (as I don't think paging HIVE is possible).
I'm expecting this will need a few tweaks, just let me know.
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Do you mind rebasing this against the latest master? Please and thanks!

@mattyb149 I am still planning to update this PR.  Any chance you could take a look at https://github.com/apache/nifi/pull/1510 first and see if we can get it pulled in? It is simpler and has some direct conflicts/overlap with this PR, I'd rather get it into master before I rebase and cleanup my Hive work.

#1510 is now merged, do you mind rebasing this one? Please and thanks!

@mattyb149 I'm working through this. I found a couple of issues that I'm figuring out.
Also, I might have a way to do GenerateTableFetch with HIVE, using logic similar to what you do for SQL 2008 using ROW NUMBER.

@mattyb149 I've completed the changes. I added support for GenerateTableFetch, though Hive being hive it's not all that fast...
There is one quirk, and I feel it should be documented but I'm not sure where. When using QueryDatabaseAdapter with Hive you need to qualify your max value column with the table name. This is because Hive always qualifies the column names in the ResultSet. Also, as a result of this, you'll need to Normalize the column names.
With GenerateTableFetch, since it pulls back the max value through a query and aliases the column name, I don't think the above issue is a problem.
ExecuteSQL should work without any special changes, just remember to select a Database Adapter when testing HIVE, this didn't used to be an available option.

@patricker This PR has now conflicts since #1798 (NIFI-2624: Avro logical types) and others are merged. Would you mind rebasing this? I'd like to review once the merge conflicts get addressed, and test to see if logical types can be used with Hive tables.
Thank you for your contribution, time and effort!

@ijokarumawak I'll work on it.

@patricker Are you working on this one? If not, perhaps @ijokarumawak or I can take over.

@mattyb149 @ijokarumawak Thanks for checking in on me. I had planned to work on this, but due to recent shifts at work I don't even use HIVE anymore... If someone wants to put a bow on this I'd appreciate it.


Depth estimates are way off

Depth estimates from MC-lab are around 200m of depth, which is quite a bit off the actual depth of 0-1,5m

We have a BAR30 that we should be able to use as well woo!


64-bit LinqToExcel NuGet package?

Is there any 64-bit LinqToExcel NuGet package?

It seems that the 64-bit package still can't be located using the the NuGet Package Manager - I had to install it from the console.  Searching for "LinqToExcel" only turns up a single result.

@b-rewired You can locate it from the NuGet Package Manager by searching for LinqToExcel_x64

@paulyoder You're absolutely right - my mistake!  I am sorry to re-open this.  May I suggest you update the readme.markdown to include links to both NuGet packages?  The link to the Access engine is already there but when searching in the package manager for "LinqToExcel" it only turns up the 32-bit version.  I don't know if you can somehow address this - it's almost as though the 64-bit version doesn't want to be found.
32-bit
64-bit
Fantastic component, Paul!  I've been using it all morning and I'm impressed with your thoroughness.