$uibModal is not defined

I'm getting an $uibModal is not defined
In my app.js file:
angular.module('myApp', ['ngRoute', 'ngCookies', 'ngFileUpload', 'ngAnimate', 'ui.bootstrap'])
I'm including the ui.bootstrap
and in my controller
angular.module('myApp').controller('ShowArticleCtrl', [   '$scope', '$location', 'article', 'user', '$routeParams', '$uibModal',
when I click on the open modal button I get a $uibModal is not defined

What is the version of the library that you are using? $uibModal was renamed from $modal only recently: https://github.com/angular-ui/bootstrap/blob/master/CHANGELOG.md#0140-2015-10-09

I'm using the 0.14.1

It should work. Check the demo on our website and see how it works. Your problem is elsewhere.
Are you sure you updated to 0.14.1?

This needs a reproduction - the demo Plunker works, as can be seen here.

I get a similar problem with the $uibModal not working.  It's because I'm uglifying the library and get the following error:
Error: [$injector:unpr] Unknown provider: fProvider <- f
http://errors.angularjs.org/1.4.7/$injector/unpr?p0=fProvider%20%3C-%20f

@mtraynham We are pretty strict with our minification. Could you try the .min version we provide and see if it fails? Or perhaps that comes from your own code?

@Foxandxss Well it works with the distributed minified version, but if I do any minification (such as using wiredep) on my side it breaks.

Interestingly enough, if I switch my small app's code back to using $modal instead of $uibModal, works fine.

I'm not seeing anything particular wrong in the $uibModal code - the only thing different is the injection of the $uibModalStack string and consuming it as a $modalStack argument, but that should not be the culprit.

Found the issue, may not be related to OP.  Old $modal always passed $scope, $modalInstance as the parameters to the controller.  New one doesn't.

@mtraynham it always used di, afaik...

@pkozlowski-opensource You might be right, although something changed as the following used to work after minification.  I've added the necessary /*ngInject*/ to fix it:
$modal.open({
    templateUrl: ...
    controller: function ($scope, $modalInstance) {
    }
});

@wesleycho here is the [plunk] (http://plnkr.co/edit/qzzCLYkEbHpJjW82teJE?p=preview)
It looks like a dependency issue

@tiagoovieira $uibModal es 0.14.0+. That plunk is using 0.13.3.
I am closing this out.

actually plunk doesn't have access to angular-ui-bootstrap more recent than 0.13.3. But what I'm using is 0.14.1

You can manually put 0.14.1 in the URL that loads it. Your plunker has like loots of errors apart from bootstrap.

@Foxandxss I updated the plunkr, please let me know what errors might still persist.

Save it or share the new link (if it changed). I still see the old one.

my bad, [here it is] (http://plnkr.co/edit/qzzCLYkEbHpJjW82teJE?p=preview)

Your plunker needs:
Proper ng-app tag.
Use a controller in template
Not load jquery nor bootstrap.js (they are not needed at all)
Load app.js as script tag.
Fix your array syntax to load dependencies (they are not in sync with controller parameters)
Fix the controller that you're using for the modal.
With that, you can see that it works.

@Foxandxss it seems to be partially working, but it doesn't display the modal. Locally I get an Error: [$compile:tpload] Failed to load template: modal_conversation.html (HTTP status: 404 Not Found)

http://plnkr.co/edit/roTslCwkpewbp7nJ3Pea?p=preview

Odd thing. It works, but only after clicking the second time on the button to open up the modal.

You probably need to cache your template first, plunker is not doing that.

you mean by adding <script type="text/ng-template" id="template.html"> to the modal?

No, not exactly. http://plnkr.co/edit/wxNn5445S2Eqk23ZORG6?p=preview

:+1:  cool, it's working :smiley:

@pkozlowski-opensource Thanks ! I was using old build.

@mtraynham
I have the same problem.
How do you solve it?

@mtraynham, you might try again with the latest version of the code or a build off of master which has had all the deprecation warnings removed.

@icfantv I was able to resolve the issue on an earlier build, thanks though!
@pykiss I was creating my $modal controller's incorrectly in the following way:
var modalInstance = $modal.open({
    templateUrl: 'templates/messagedialog.tpl.html',
    controller: function ($scope, $modalInstance) {

After minification, the controller would look like:
var a = b.open({
    templateUrl: 'templates/messagedialog.tpl.html',
    controller: function (c, d) {

For some reason (as I was obviously doing this wrong before hand), $modal worked properly with c & d being mapped to $scope & $modalInstance, respectively.  After the upgrade to $uibModal, this was no longer the case as angular was looking to inject c which is not a valid injection.
My fix was to add the necessary minification annotations to the controller which would properly inject $scope and $modalInstance.  Or use ngAnnotate which does that for you:
var modalInstance = $modal.open({
    templateUrl: 'templates/messagedialog.tpl.html',
    controller: /*@ngInject*/ function ($scope, $modalInstance) {

Good deal, thanks.

I had the same issue with exact same error. I just replaced my old file with the latest one; ui-bootstrap-tpls-0.14.3.min.js... No more error ! [Solved]

Had similar inject error for $uibModal after upgrading from 0.14.3 to 1.1.2.
Some pages were working but some were not.
The reason was not injecting 'ngAnimate' into the app module.

Leaving this comment here for the future: had a similar issue, basically I had to upgrade ng-annotate to v1.1+ which includes fixes for $modal -> $uibModal change, otherwise it doesn't recognize the ModalInstanceController functions... $scope and $uibModalInstance aren't recognized there.

@csulok, IMO relying on a third-party library to keep UIBS and your code happy is a recipe for lots of unhappiness.  While the angular team does not specifically say using a third-party strictDi library like ng-annotate is bad - as you and others have found out, doing so can be cause for grief.

You're quite right. ng-annotate is a trade-off between correctness and convenience. Perhaps it takes 1-2 cases like this for that to be understood though. For me certainly.


Install fails with PostgreSQL 9.4.1 on Mac OS 10.10

Thanks for the extension, it looks to be exactly what we're looking for. I'm having some problems following the install instructions though, although it may just be that make installcheck doesn't work until after you've run make install.
make works fine, but I get failures on make installcheck.
+ ERROR:  could not open extension control file "/usr/local/Cellar/postgresql/9.4.1/share/postgresql/extension/temporal_tables.control": No such file or directory

So I copied files into postgresql/extension/ until it was happy (eventually cp temporal_tables* /usr/local/Cellar/postgresql/9.4.1/share/postgresql/extension/) and now have the following error:
+ ERROR:  could not access file "$libdir/temporal_tables": No such file or directory

However if I run make install before make installcheck then all the tests pass.

Thank you for reporting this issue. Certainly, make installcheck should be run only after you have run make install.

Yes, the code in the README and in the tutorial you sent me both indicate that it should work before running make install.

Fixed.

How was this solved, getting a similar error.

Caused by: org.postgresql.util.PSQLException: ERROR: could not access file "$libdir/temporal_tables": No such file or directory, even though it does exist.


[Bug]: Unscoped CSS

Bug type
Style
Commenter Version
2.0.5
Database
No response
Description
The CSS in this package applies custom styles to scrollbars globally. To prevent unintended interference with other components, the following styles should be scoped appropriately.
::-webkit-scrollbar {
width: 2px;
height: 2px;
}
::-webkit-scrollbar-track {
background: #f1f1f1;
border-radius: 5px;
}
::-webkit-scrollbar-thumb {
background: #888;
border-radius: 5px;
}
::-webkit-scrollbar-thumb:hover {
background: #555;
}
::-webkit-scrollbar-button {
display: none;
}
Steps To Reproduce
No response
Reproduce URL
No response

It has scoped https://github.com/Lakshan-Madushanka/laravel-comments/pull/49. What are you experiencing ?

It has scoped #49. What are you experiencing ?

I upgraded and it's fixed.


feat: setting up Product models and Controller. Adding dbcontext for …

Closes #5

You should create an issue beforehand just so we know what's being done at first glance :)

LGTM, I do miss a sevice layer but we can refactor it later.


Playlist: selected videos download bug

:bug: cannot download furthermost selected videos in playlist :confused:

Can you explain further? Don't really understand.

Suppose I have 200 videos in a playlist, When I select top nearest playlist indexes from playlist listview, the download starts immediately, but When I select last furthermost playlist indexes from playlist list view, it takes very long to get playlist info

Ah, I gotcha.
The reason is actually because it's not working at all. It tries to get the wrong video (at least when I'm trying to get last video in a 700+ long playlist. It tries to get 53rd video for some reason)
I'm gonna work on this.

Okz :+1:

:+1:  :smile:

:disappointed: started facing the problem again

:disappointed: Now the problem is when I download playlist videos with larger duration, it gets stuck irrespective of 200+ videos

Damn... I'll look into it.

It works fine now :sweat_smile:


feat(Tutorials): add inital guides for using Oculus Integration SDK - resolves #39

A couple of tutorials show casing how the Oculus Integration SDK can be
used with VRTK by using existing components or creating wrapper
components that adhere to the VRTK contracts.

This resolves #39 but for some reason adding that to the title isn't linking it to the issue?!


Opens 2 Minecraft windows upon launch

When I launch the game it opens 2 minecraft windows, I see them for a split second and then it hides 1 of them. One of them is called Java(TM) Platform SE binary and the one my game is on is called OpenJDK Platform binary. They seem to NOT be connected (ending the 1st task in task manager does not close my game, but ending the 2nd task does close the game since well, it's what the game is running on).
It uses about 1GB of memory which is why I want to know a way to get rid of it since it's annoying to end it in task manager each time.
This doesn't happen with the defualt Minecraft launcher.
Thanks

When the launcher runs the game, it just hides itself so it can reopen if the game crashes. You can modify this behavior by editing the profile that you are launching.

Closing since this is intended behavior.


As an industry reporter, I want to see a table with each facility report, so that I can select which facility to fill a report for

Description:
Wireframe + flow here

Acceptance Criteria:
Given
When
Then
Development Checklist:

[ ] Checklist item
[ ] Checklist item
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Wireframe added

@ayeshmcg to take a first pass at this


fix: fix the incorrect assertion for fixed size binary decoder

This PR tries to fix https://github.com/lancedb/lance/issues/3049
It fixes the incorrect assertion for fixed size binary decoder and add a test to verify fixed size binary decoder works.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.44%. Comparing base (f17d88d) to head (dffa4d8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3050      +/-   ##
==========================================
+ Coverage   78.24%   78.44%   +0.19%
==========================================
  Files         240      240
  Lines       77284    78637    +1353
  Branches    77284    78637    +1353
==========================================
+ Hits        60470    61685    +1215
- Misses      13696    13823     +127
- Partials     3118     3129      +11

Flag
Coverage Δ

unittests
78.44% <100.00%> (+0.19%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Marathon-UI: how to connect to the Marathon

As https://github.com/mesosphere/marathon-ui ,
I ran marathon-ui with no-docker way, it could be visited at <IP_ADDRESS>:4200, but could not "Create Application", while my marathon running normally.  So how to config my marathon-ui to connect to marathon?   Looking forward for your help. Thank you very much.

Hi @helium12, I personally used a proxy (nginx) to have marathon and marathon-ui be served from the same url locally before we started to use the docker-compose. You could also add the apiUrl o your config file. Which you should have copied from https://github.com/mesosphere/marathon-ui/tree/master/src/js/config the template to config.dev.js. I hope this works for you. If you have any more questions please ask.
Also the marathon which you are running locally should have a ui bundled with it as well.

you could visit marathon by http://marathon.docker:8080(make sure you have configured your hosts already ), it works for me.

Closing this issue; feel free to reopen if you need further information on how to "connect" to Marathon.


NSMutableDictionary with NSNumber keys bug(reproduces on 32 bit devices only)

Please pay attention on this demonstration project https://github.com/SiarheiFedartsou/FastCodingBug

It seems that it is because of tagged pointers optimization on 64 bit platforms:
  __autoreleasing NSMutableDictionary *dict = CFBridgingRelease(CFDictionaryCreateMutable(NULL, (CFIndex)1, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
    dict[key1] = @"xxx";
    dict[key2] = @"yyy";

    CFHashCode h1 = CFHash((CFTypeRef)@1);
    CFHashCode h2 = CFHash((CFTypeRef)@YES);

    Boolean e = CFEqual((CFTypeRef)@1, (CFTypeRef)@YES);

    NSLog(@"%lu %lu %u", h1, h2, e);

Result of CFEqual will be True on 64 bit platform and False on 32 bit platform.
I think that the best fix will be substitution of CFDictionary to NSDictionary in FCReadMutableDictionary or providing custom key callbacks for kCFTypeDictionaryKeyCallBacks(call - [NSObject hash] and -[NSObject isEqual:] instead of CFHash and CFEqual).

Thanks for reporting this. It's fixed in version 3.2.
I used the latter approach (custom kCFTypeDictionaryKeyCallBacks) and I've also changed FastCoder to not encode 0 and 1 and booleans any more, so it should be double-fixed :-)


How to access a custom field in custom field type

Hey,
I'm not sure if this is a bug or what, but I have a custom field type with a custom field.  The documentation shows that it can be added.  The documentation shows that it can be edited from the page.  But whenever I try to use the value, it says that the variable is not initialized.  I can see how "foo" is in the custom Date field, but there's no following line showing where it is used or how to access it.
Could someone please help me out?
Thanks.

Applicable code is found at http://js-grid.com/docs/#custom-field
Where is "foo" being used?  I can't seem to get a hold of a custom field's value.

Sorry, if this example confused you. The value "foo" is NOT used anywhere. It's just to show that you can define any custom property with any desired value, which can be used at some point if needed (not in this case).

Please re-open this question.
When I have a custom field and attempt to access it in the editTemplate and insertTemplate, I get the error that the field is never defined and is null.  Could you please put in a small thing--a console.log or something--that can show how to access this?

My example code:
.... boiler plate code eliminated
MyField.prototype = new jsGrid.Field({
items: ["1", "2", "3"],
insertTemplate: function(value) {
alert(items);
}
});
......
I get a ReferenceError: items is not defined.

Hm... How items could be found? Is it a global variable?
If you are trying to reference items from the field object it should be this.items, and it has nothing to do with jsGrid, this is JavaScript basics.


Bitbucket support

Don't know if it works out of the box, but I know that Bitbucket has webhooks.
Needs further testing.

Could be considered irrelevant if #4 became successful.


WA - Missing LOINC - Need SafeHealth to resubmit

Problem statement
Received request from Jennifer Risler from WA via Smartsheet Submission Form.  Regarding a Missing LOINC, please resubmit.
What you need to know
MSH|^~&|CDC PRIME - Atlanta, Georgia (Dekalb)^2.16.840.1.114<IP_ADDRESS>821^ISO|7uycso49^<IP_ADDRESS>.4.1.386<IP_ADDRESS>.519^ISO|WADOHPHRED^2.16.840.1.1138<IP_ADDRESS>.2^ISO|dn1fro00^<IP_ADDRESS>.4.1.386<IP_ADDRESS>.19^ISO|20220822191609-0000||ORU^R01^ORU_R01|SH00116_fffb180bf847466496d1cc3baa2ae5e7|P|2.5.1|||NE|NE|USA|UNICODE UTF-8|ENG^English^ISO||PHLabReport-NoAck^ELR_Receiver^2.16.840.1.113883.9.11^ISO
OBX|1|CWE|^^LN
Acceptance criteria

Resubmission of Missing LOINC

To Do

Research
Assign

Second Request from Jenni Risler -<EMAIL_ADDRESS>Missing LOINC, please resubmit.
MSH|^~&|CDC PRIME - Atlanta, Georgia (Dekalb)^2.16.840.1.114<IP_ADDRESS>821^ISO|7uycso49^<IP_ADDRESS>.4.1.386<IP_ADDRESS>.519^ISO|WADOHPHRED^2.16.840.1.1138<IP_ADDRESS>.2^ISO|dn1fro00^<IP_ADDRESS>.4.1.386<IP_ADDRESS>.19^ISO|20220822191609-0000||ORU^R01^ORU_R01|SH00116_fffb180bf847466496d1cc3baa2ae5e7|P|2.5.1|||NE|NE|USA|UNICODE UTF-8|ENG^English^ISO||PHLabReport-NoAck^ELR_Receiver^2.16.840.1.113883.9.11^ISO
OBX|1|CWE|^^LN

Received another Smartsheet Service Request from WA State - Jennifer Risler (jenni.risler@doh.wa.gov):
missing LOINC, please resend
MSH|^~&|CDC PRIME - Atlanta, Georgia (Dekalb)^2.16.840.1.114<IP_ADDRESS>821^ISO|7uycso49^<IP_ADDRESS>.4.1.386<IP_ADDRESS>.519^ISO|WADOHPHRED^2.16.840.1.1138<IP_ADDRESS>.2^ISO|dn1fro00^<IP_ADDRESS>.4.1.386<IP_ADDRESS>.19^ISO|20220823171610-0000||ORU^R01^ORU_R01|SH00116_638392009b3246adbe7e6b693af75bc3|P|2.5.1|||NE|NE|USA|UNICODE UTF-8|ENG^English^ISO||PHLabReport-NoAck^ELR_Receiver^2.16.840.1.113883.9.11^ISO
OBX|1|CWE|^^LN

Another one received on 8/23/2022 @ 5:10 PM:
Missing LOINC, please resend
MSH|^~&|CDC PRIME - Atlanta, Georgia (Dekalb)^2.16.840.1.114<IP_ADDRESS>821^ISO|7uycso49^<IP_ADDRESS>.4.1.386<IP_ADDRESS>.519^ISO|WADOHPHRED^2.16.840.1.1138<IP_ADDRESS>.2^ISO|dn1fro00^<IP_ADDRESS>.4.1.386<IP_ADDRESS>.19^ISO|20220823191618-0000||ORU^R01^ORU_R01|SH00116_40a23f40ed68477da624ad7d6a15ed46|P|2.5.1|||NE|NE|USA|UNICODE UTF-8|ENG^English^ISO||PHLabReport-NoAck^ELR_Receiver^2.16.840.1.113883.9.11^ISO
OBX|1|CWE|^^LN|

@sliu1000 Hi Sharon, we've flagged this as medium priority. It might make it to this sprint or the next so let's hang tight for now. We talk to WA DOH next Monday so we can update them then.

2022-09-20.  Analyzed the message and verified that sender (SafeHealth) didn't fill the LOINC code (OBX-3).  I requested them to resubmit the message.
" === email ===
Dear: Dave Cassell, or Santosh Jami,
My Name is OTT SATHNGAM.  I am an Engineer who assigned to work on your message with message ID = SH00116_fffb180bf847466496d1cc3baa2ae5e7 that sent to WA.
It was sent around 2022-08-22.  The message is missing the LOINC Code or test_performance_code (HL&: OBX-3-1, OBX-3-2, OBX-3).  Would you please fill the
in the LOINC code and resubmit to us.
If you have any question, please feel free to contact me.
Best regards,
-Ott Sathngam
CDC SWE

TEST__RESULT	PERFORMING__ORG__NAME	WELRS__HC	WELRS__ASSIGNED__HC__MANUAL	WELRS__MSH__ID	SUBMITTER__UNIVERSAL__ID__MSH_0402
Detected	SA.OTCSelfReport	COVID-19	False	386665667	<IP_ADDRESS>.4.1.386<IP_ADDRESS>.519
Detected	SA.OTCSelfReport	COVID-19	False	386665695	<IP_ADDRESS>.4.1.386<IP_ADDRESS>.519


Localizations not working in prod bundle on NextJs 14

What version of this package are you using?
2.6.1
What operating system, Node.js, and npm version?
Node 18.18.2
What happened?
After updating to NextJs 14, localizations stopped working in our production bundle. They work fine locally.
I don't see any next-translate warnings or errors when running yarn run build, only output like this:
next-translate - compiled page: /trade - locale: en - namespaces: my-web - used loader: getServerSideProps
What did you expect to happen?
Localizations should work in prod bundle

Can no longer reproduce with Nextjs 14.0.2 / next-translate 2.6.2


TypeError: undefined is not an object (evaluating '_reactNativeTcpSocket.TcpSocket.createConnection')

Description
When creating a connection I'm getting the error TypeError: undefined is not an object (evaluating '_reactNativeTcpSocket.TcpSocket.createConnection') and I'm not sure how to debug this properly to see where's the error originated
Or code:
const client = TcpSocket.createConnection(
	{ port: Port, host: IP },
	() => {
	client.write(Payload);
        client.destroy();
	});

	client.on("error", function (error) {
	     console.log(error);
	});
	client.on("close", function () {
	      console.log("Connection closed!");
	});

Relevant information

OS
Developing for Android using Linux

react-native
<EMAIL_ADDRESS>

react-native-tcp-socket
<EMAIL_ADDRESS>

I'm using Expo idk if that's relevant

So if anyone comes here, first of all I tried to "import" using
    const net = require('react-native-tcp-socket');
And that gave another error
`TypeError: null is not an object (evaluating 'Sockets.connect')`

So after someone suggested to me on Reddit, I had to eject the code with expo eject then rebuild the app using expo run:android and that worked!
So if anyone's struggling with this might wanna try that.


clean up all whitespace issues in Java files (FINERACT-821)

convert all Java files from DOS to UNIX line ending:
find . -type f -name "*.java" -exec dos2unix '{}' ';'

replace Tabs with 4 Spaces:
rpl -eRxjava "\t" "    " .

remove all trailing spaces:
find . -type f -name "*.java" -exec sed -i 's/ *$//' '{}' ';'

This PR only make whitespace clean up changes, and nothing else.  This can be "proven" by locally doing a git diff -w on it, or inspecting https://github.com/apache/fineract/pull/688/files?w=1.
See https://issues.apache.org/jira/browse/FINERACT-821 for full background.

@awasum I'll fix the Merge Conflicts on this one AFTER my other work in #684 and #685 has been reviewed and merged. (I expect it may be simplest & fastest to just completely "recreate" this PR, from scratch on HEAD, by running the commands shown above, instead of actually resolving conflicts individually.)

@awasum I'll fix the Merge Conflicts on this one AFTER my other work in #684 and #685 has been reviewed and merged. (I expect it may be simplest & fastest to just completely "recreate" this PR, from scratch on HEAD, by running the commands shown above, instead of actually resolving conflicts individually.)

Makes sense. Go for it.

Makes sense. Go for it.

but I'm waiting for you to review and hopefully merge #684 and #685 ... :smiley:

Makes sense. Go for it.

but I'm waiting for you to review and hopefully merge #684 and #685 ...

I think you are all set. Both PRs have now been merged.


chore: update findable-ui package to latest (#4043)

Ticket
Closes #4043.
Reviewers
@NoopDog.
Changes

Updated findable-ui package to v2.2.0.

Obsolete


Use proguard

Hey Mike,
I am wondering, have you ever tried to use Proguard. I read that it could speedup a little code execution.
For instance i just tried to set minifyEnabled to true, but i get errors due to class being stripped away, hence my question.

not really.  It used to be included when we used Eclipse, before AS, but even then I only used the default build.  since it's open source, the obfuscation isn't helpful, and i suspect apk size is not impacted that much - that said, feel free to give it a shot.

Ok. I don't care the obfuscation too. I was just interested because i read from afficial doc :

ProGuard optimizations perform analysis at the bytecode level, inside and across methods to help make your app smaller and run faster
I report back if i get something working.

:thumbsup:

So it reduced the size of the aar by 28%, and it's working.
As for the speedup, it's hard to tell for instance.

Sounds worthwhile - PR?

Yes, before that i need to test that nothing vital for TileView is stripped away. Running demos and my personal app should be enough.

:thumbsup:

I have a pretty frustrating situation because the produced aar is functionnal, provided we don't use MarkerLayout.MarkerTapListener, which is stripped out and despite trying i could not find a way to keep it.
Will try again later.

You can use -keep according to the docs: http://developer.android.com/tools/help/proguard.html

Yes! I almost every combinations of it. I must be missing something. For instance i have in proguard.pro :
-keep interface *$MarkerTapListener { ; }
-keep public class com.qozix. { *; }

hmm -keep public class com.qozix.MarkerLayout.MarkerTapListener doesn't work?
also, i suspect that it's going to try to strip any and all unused classes (and methods?) from the library - there are a lot that aren't used internally (the public API)...

No it doesn't. I agree that the fact that it is unused then stripped is the issue.

yeah, we'll need to be very careful that it doesn't strip out public methods that aren't in the demo (which is far from complete)

Got it! Simply :
-keep class com.qozix.** { *; }
-keepattributes InnerClasses

nice.  you're 100% sure we don't lose any of the public API?

For instance, it looks good, but i will test it on some random public api.

cool, thanks

Confirmed it strips nothing. As per doc

usage.txt
Lists the code that was stripped from the .apk
The usage.txt produced contains nothing. If i change -keep class com.qozix.** { *; } to -keep class com.qozix.**, the usage.txt contains a lot of methods.
I could also run demo and call public api from my app.

awesome, thanks for thoroughness - i'll keep an eye out for PR


⚠ Bofrost.de has degraded performance

In 1cc1766, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 945 ms

Resolved: Bofrost.de performance has improved in 11de164 after 6 minutes.


Crude gas metering

explores #17
Some notes:

ABI decoding tx calldata from bytes to Rust types is the most expensive operation, running into millions of RISC-V opcodes executed.
An ERC20 transfer takes 19K gas with the current gas model  (incl sload, sstore)
mint => 11.4K, balance => 6K, approve => 11.2K

We should probably merge the changes into rvemu first?

Yup, waiting on that here: https://github.com/lvella/rvemu/pull/1 or do you mean to upstream it?

Yup, waiting on that here: lvella/rvemu#1 or do you mean to upstream it?

Ah right, I actually don't have write permissions there, I just asked Lucas to transfer the repo to r55-eth org.

I just asked Lucas to transfer the repo to r55-eth org.

Sweet, thanks! I've pushed in the change for that.


Bug: ...Windscribe missing location US East

TLDR: US Central and US West is mentioned as possible values for region, US East is inexplicably missing

Is this urgent?

[ ] Yes
[x] No

What VPN service provider are you using?

[ ] PIA
[ ] Mullvad
[x] Windscribe
[ ] Surfshark
[ ] Cyberghost

What's the version of the program?
See the line at the top of your logs
Running version latest built on 2020-03-13T01:30:06Z (commit d0f678c)

What are you using to run the container?

[ ] Docker run
[x] Docker Compose
[ ] Kubernetes
[ ] Docker stack
[ ] Docker swarm
[ ] Podman
[ ] Other:

Extra information

Logs:

Configuration file:

Host OS:

Yes that's a recent change, for some reason my program would not want to resolve us-east.windscribe.com to ip addresses. Anyway, I've done manually so it should be back. Thanks for letting me know.


State that the curl-client provides a http client

Currently, package requiring a psr/http-client-implementation can't use this client because it doesn't seem to provide it.

This depends on the version of HTTPlug being installed, doesn't it?


WIP: Fixes #658

FYI @cmoulliard

I think that we should still improve 2 thinks

Build
"In addition to building on your local machine and pushing to a local or public cloud, you also have the ability to build and deploy your booster directly to {OpenShiftLocal}." --> We explain twice the same concept but for local build vs on openshiftlocal. This is confusing. With f-m-p you build your java application and deploy on Openshift no matter where OpenShift is running; that could be locally, remotely, ...

Launcher
"Specifically, you can use the {launcher} application to clone a new booster repository to your GitHub account and have it deployed to your {OpenShiftLocal} using the Build and Deploy process." --> Is it documented/described somewhere what is the launcher, what a developer can achieve with the launcher ? Is still "launcher" the appropriate word to be used ?

@cmoulliard let me know what you think.

[test]

merged: 406ccc9de5c099c5b42b420ae89b9ddefbc81de4


Integration with API

Good morning,
I would like to know the complete JSON response when interacting with the API. I have conducted some tests and am implementing a client in Golang, but I have not found the full JSON response when using the API integration.
Could you provide the complete JSON response example?
Thank you.

I would like to know the complete JSON response when interacting with the API at the endpoint api/v1/run. I have conducted some tests and am implementing a client in Golang, but I have not found the full JSON response when using this API integration.
Could you provide the complete JSON response example for the api/v1/run endpoint?

full response for request
curl -X POST \
    "http://<IP_ADDRESS>:7860/api/v1/run/b87811d9-9974-4d11-bfab-4d4ff0b43160?stream=false" \
    -H 'Content-Type: application/json'\
    -d '{"input_value": "message",
    "output_type": "chat",
    "input_type": "chat",
    "tweaks": {
  "OpenAIEmbeddings-gMvoo": {},
  "Qdrant-NRPl4": {},
  "SplitText-KUnLN": {},
  "File-kgHNu": {},
  "ChatInput-oYQ3r": {},
  "ParseData-XlJWG": {},
  "OpenAIEmbeddings-5zkfa": {},
  "Prompt-B8Yop": {},
  "OpenAIModel-V3jzS": {},
  "ChatOutput-1TK8r": {},
  "Qdrant-Y24Tl": {}
}}'

I test and response has
{
    "session_id": "786fd3ec-b741-42ca-9c79-906edfe65851",
    "outputs": [
        {
            "inputs": {
                "input_value": "What's Yamask attack?"
            },
            "outputs": [
                {
                    "results": {
                        "message": {
                            "text_key": "text",
                            "data": {
                                "text": "Yamask is a Ghost-type Pokémon known for its eerie appearance and connection to ancient spirits. Its primary attack moves include:\n\n1. **Astonish** - A Ghost-type move that may cause the opponent to flinch.\n2. **Hex** - A Ghost-type move that deals more damage if the target has a status condition.\n3. **Night Shade** - A Ghost-type move that inflicts damage equal to the user's level.\n4. **Shadow Ball** - A powerful Ghost-type move that may lower the target's Special Defense.\n\nThese moves leverage Yamask's Ghost-type abilities to inflict damage and potentially disrupt the opponent's strategy.",
                                "sender": "Machine",
                                "sender_name": "AI",
                                "session_id": "786fd3ec-b741-42ca-9c79-906edfe65851",
                                "files": [],
                                "timestamp": "2024-07-05 14:09:49",
                                "flow_id": "786fd3ec-b741-42ca-9c79-906edfe65851"
                            },
                            "default_value": "",
                            "text": "Yamask is a Ghost-type Pokémon known for its eerie appearance and connection to ancient spirits. Its primary attack moves include:\n\n1. **Astonish** - A Ghost-type move that may cause the opponent to flinch.\n2. **Hex** - A Ghost-type move that deals more damage if the target has a status condition.\n3. **Night Shade** - A Ghost-type move that inflicts damage equal to the user's level.\n4. **Shadow Ball** - A powerful Ghost-type move that may lower the target's Special Defense.\n\nThese moves leverage Yamask's Ghost-type abilities to inflict damage and potentially disrupt the opponent's strategy.",
                            "sender": "Machine",
                            "sender_name": "AI",
                            "files": [],
                            "session_id": "786fd3ec-b741-42ca-9c79-906edfe65851",
                            "timestamp": "2024-07-05 14:09:49",
                            "flow_id": "786fd3ec-b741-42ca-9c79-906edfe65851"
                        }
                    },
                    "artifacts": {
                        "message": "Yamask is a Ghost-type Pokémon known for its eerie appearance and connection to ancient spirits. Its primary attack moves include:\n\n1. **Astonish** - A Ghost-type move that may cause the opponent to flinch.\n\n2. **Hex** - A Ghost-type move that deals more damage if the target has a status condition.\n\n3. **Night Shade** - A Ghost-type move that inflicts damage equal to the user's level.\n\n4. **Shadow Ball** - A powerful Ghost-type move that may lower the target's Special Defense.\n\nThese moves leverage Yamask's Ghost-type abilities to inflict damage and potentially disrupt the opponent's strategy.",
                        "sender": "Machine",
                        "sender_name": "AI",
                        "files": [],
                        "type": "object"
                    },
                    "outputs": {
                        "message": {
                            "message": {
                                "text": "Yamask is a Ghost-type Pokémon known for its eerie appearance and connection to ancient spirits. Its primary attack moves include:\n\n1. **Astonish** - A Ghost-type move that may cause the opponent to flinch.\n2. **Hex** - A Ghost-type move that deals more damage if the target has a status condition.\n3. **Night Shade** - A Ghost-type move that inflicts damage equal to the user's level.\n4. **Shadow Ball** - A powerful Ghost-type move that may lower the target's Special Defense.\n\nThese moves leverage Yamask's Ghost-type abilities to inflict damage and potentially disrupt the opponent's strategy.",
                                "sender": "Machine",
                                "sender_name": "AI",
                                "session_id": "786fd3ec-b741-42ca-9c79-906edfe65851",
                                "files": [],
                                "timestamp": "2024-07-05 14:09:49",
                                "flow_id": "786fd3ec-b741-42ca-9c79-906edfe65851"
                            },
                            "type": "object"
                        }
                    },
                    "messages": [
                        {
                            "message": "Yamask is a Ghost-type Pokémon known for its eerie appearance and connection to ancient spirits. Its primary attack moves include:\n\n1. **Astonish** - A Ghost-type move that may cause the opponent to flinch.\n\n2. **Hex** - A Ghost-type move that deals more damage if the target has a status condition.\n\n3. **Night Shade** - A Ghost-type move that inflicts damage equal to the user's level.\n\n4. **Shadow Ball** - A powerful Ghost-type move that may lower the target's Special Defense.\n\nThese moves leverage Yamask's Ghost-type abilities to inflict damage and potentially disrupt the opponent's strategy.",
                            "sender": "Machine",
                            "sender_name": "AI",
                            "session_id": "786fd3ec-b741-42ca-9c79-906edfe65851",
                            "component_id": "ChatOutput-jaZhF",
                            "files": [],
                            "type": "message"
                        }
                    ],
                    "component_display_name": "Chat Output",
                    "component_id": "ChatOutput-jaZhF",
                    "used_frozen_result": false
                }
            ]
        }
    ]
}

what have in  "files": [] ?

build status not work
curl http://<IP_ADDRESS>:7860/api/v1/build/786fd3ec-b741-42ca-9c79-906edfe65851/status
<!DOCTYPE html>

    <meta charset="UTF-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <link rel="icon" href="/favicon.ico" />
    <title>Langflow</title>

    <link rel="stylesheet" crossorigin href="/assets/index-DqbJXmW8.css">

    You need to enable JavaScript to run this app.

@dosu It should be the "/run/{flow_id_or_name}" endpoint.

The build status is mostly unused in 1.0, @devalexandre
The schema definition for the API is the class RunResponse here:
https://github.com/langflow-ai/langflow/blob/fix_cli_not_resetting/src/backend/base/langflow/api/v1/schemas.py#L53
@dosu check this.

the endpoins
curl http://<IP_ADDRESS>:7860/api/v1/run/786fd3ec-b741-42ca-9c79-906edfe65851
<!DOCTYPE html>

    <meta charset="UTF-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <link rel="icon" href="/favicon.ico" />
    <title>Langflow</title>

    <link rel="stylesheet" crossorigin href="/assets/index-DqbJXmW8.css">

    You need to enable JavaScript to run this app.

and
<!DOCTYPE html>

    <meta charset="UTF-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <link rel="icon" href="/favicon.ico" />
    <title>Langflow</title>

    <link rel="stylesheet" crossorigin href="/assets/index-DqbJXmW8.css">

    You need to enable JavaScript to run this app.

not work but another work I'm create a release of langflowgo 0.1 without this :)


Feat/add create page ui

This PR implements the create page content, notably the workflow builder UI.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


does libtensorflow_inference.so contains both  "code for training .pb file"  and "code for analyzing .pb file"?

Describe the problem
I'd like to import "libtensorflow_inference.so" to an android app to and make it possible to make some machine learning in the app. But the size of "libtensorflow_inference.so"  file is too large which is 9.8M .
Because  I just want to import generated models(.pb file) to predict and don't need to train models in android app. Could you please tell me which code is used to import and analyze the .pb file and witch code is used to train a .pb file in tensorflow project?
does libtensorflow_inference.so contains both  "code for training .pb file"  and "code for analyzing .pb file"? Is possible to remove the "code for training .pb file" to minimize its size  if it contains that?

@scucheri The Android TF library is inference only, so there is no training code to remove.
However, we include a large set of ops by default.  You can probably save quite a bit of space by using selective registration. This will strip the binary down to just the ops needed for your model pb. See print_selective_registration_header.py for details.
Closing as this is neither a bug nor a feature request.

Thank you very much ~


Question about SVG branch...

Hi -
I did a merge of the 1.2.0 code branch and the SVG branch (I think :-) ) on my machine and it can import SVG images. However - it's not that useful (yet). Perhaps I've misunderstood what that branch was - I had assumed that if I could import a SVG that the app could export it as gcode.
Here's a sample SVG for a truly impossible pancake:
https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/penrose-staircase.svg
If I manually edit the SVG so that I reverse the order of the items drawn - I get this:

Some elements are not quite right yet - but it's getting closer. What I can't do is use the controls in PancakePainter to fill in areas. And when I try to export the gcode I get an error.
I can't be certain that I've done the merge correctly but I can go over that more carefully. I guess I have three questions:

Is the SVG branch something that would (with a bit more work) be able to generate gcode?
If the answer to #1 is yes - then will I have to re-order the drawing order within SVG so that the lines are drawn in the correct order?
And - how should I modify the SVG so that I can do a flood fill with them?

I've added the *.pbp file as a *.txt since this interface won't let me upload a *.pbp.
Pancake Project.txt
Thanks for any help. This is certainly a very fun device.
Sean

Just so it happens, the official SVG import is what I'm actually working on right now. The work done by @daniellmb was a good start, though was merged into a testing branch a bit prematurely, and there's numerous parts of the GCODE rendering that assume too much about the structure of the data on the layer to allow direct SVG importing without tons of cleanup. It's certainly possible and has been done with similar code, but it needs more work.
If you want it to get it to work, just work with importing simple outline paths without fills, and use the flood fill on those, and make sure and click to set the color for every single path (this also sets its data color index, read by the GCODE renderer). If you still run into issues, feel free and debug the GCODE renderer, it's just a bit of string juggling and really not to complex, with a little knowledge of Paper.js. Good luck!


Only reachable with String types.

Bug description
    at si.handleRequestError (F:\VQode\siingio\node_modules\@prisma\client\runtime\library.js:125:7178)
    at si.handleAndLogRequestError (F:\VQode\siingio\node_modules\@prisma\client\runtime\library.js:125:6151)
    at si.request (F:\VQode\siingio\node_modules\@prisma\client\runtime\library.js:125:5859)
    at async l (F:\VQode\siingio\node_modules\@prisma\client\runtime\library.js:130:9805)
    at async messagesAPI.beforeGet (webpack-internal:///(api)/./pages/api/messages/[[...id]].ts:45:34)
    at async messagesAPI.handleGet (webpack-internal:///(api)/./libs/rest-handlers.ts:47:17)
    at async messagesAPI.handleRequest (webpack-internal:///(api)/./libs/rest-handlers.ts:187:17) {
  clientVersion: '5.8.0'
}
thread 'tokio-runtime-worker' panicked at query-engine\connectors\mongodb-query-connector\src\filter.rs:753:22:
Only reachable with String types.
error======> PrismaClientRustPanicError:
Invalid `prisma.messages.findMany()` invocation:

Only reachable with String types.

This is a non-recoverable error which probably happens when the Prisma Query Engine has a panic.
facing this issue

Here is my query:
const messages = await prisma.messages.findMany({
  where: {
    chatRoomId: { contains: roomId, mode: 'insensitive' },
  },
});
console.log('messages===>', messages);

and here is my Messages model:
model Messages {
  id                   String      @id @default(auto()) @map("_id") @db.ObjectId
  sender               Users       @relation("sender", fields: [senderId], references: [id])
  senderId             String      @db.ObjectId
  edited               Boolean     @default(false)
  timestamp            DateTime    @default(now())
  content              String
  chatRoom             ChatRooms   @relation(fields: [chatRoomId], references: [id])
  chatRoomId           String      @db.ObjectId
  file                 File?
  seenBy               Users[]     @relation(fields: [seenByIds], references: [id])
  seenByIds            String[]    @db.ObjectId
  emojis               Json?
  replies              Messages[]  @relation("parentMessage")
  parentMessage        Messages?   @relation("parentMessage", fields: [parentMessageId], references: [id], onDelete: NoAction, onUpdate: NoAction)
  parentMessageId      String?     @db.ObjectId
  lastMessageChatRooms ChatRooms[] @relation("lastMessage")
  createdAt            DateTime    @default(now())
  updatedAt            DateTime    @default(now())
  deleted              Boolean     @default(false)
}

Hi @MuhammadBilalQamar, we kindly need additional information in order to investigate this issue:

Can you please share the value of roomId that triggered the error in your TypeScript snippet?
Can you please post a more complete Prisma schema? The Messages model references other models via @relation attributes, so we currently can't use that subset of a schema to attempt reproducing this issue.

Thanks!

@MuhammadBilalQamar please take a look at my colleague's comment above, without an answer we would close this issue later.


Support percentage mode

Clear and concise description of the problem
For now, the preset doesnot support. I have to change it to 48/100
slide-out-to-top-[48%]
Suggested solution
animate-name-xxx-[xx%]
Alternative
No response
Additional context
No response
Validations

[X] Read the documentation of using the package
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate

Thanks for the report.
The [] syntax is removed intentionally, you can view the reason here: https://unocss-preset-animations.aelita.me/animations/
I'll try to look into whether I can add support for % syntax, e.g. slide-out-to-top-48% when I get some time.

I've had a look at my implementation, it already supports percentage format, just without the bracket.
Playground
But that's indeed a missing test case, thanks for reporting anyway.

I've updated the documentation, feel free to raise a new issue if you need something else.


No option to load additional evidences to existing index

Up to release 19.02, it was possible to configure the --val step of the data loading pipeline to add a new evidence source to an index that already contained evidences. In 19.04 (since commit 848dd54 of PR #455, I believe), the step will instead always result in an index that contains only the data listed in the data configuration file for this run.
Adding internal data on top of the more stable public data release snapshots is a use-case we encounter, so I believe that the data loading pipeline should allow that.

Two ideas on how this could look to the user of the data loading pipeline:

a --keep-index flag, or
a data.yml file that explicitly specifies adding data to an existing base.

The latter may be more consistent with the expectations raised by the file format, whereas the former facilitates the workflow of iterating on a set of custom data in isolation before integrating it into a more complete platform instance.

To extend the use case a bit: even if we would not be starting from the snapshot but would be loading the public data via the pipeline directly, we would still like to have the option to follow the process below:

load only the public data
verify public data is loaded correctly by comparing to public portal
proceed with loading custom internal evidence data on top of public data

This definitely sounds like the sort of thing we could support without too much extra work. I think this belongs on the "operations" rather than "data" configuration side (since it changes the order things are done in, but not the final result) and @fedde-s 's suggestion of a flag sounds like the best way to do it.
I think it might a --drop-index option that defaults to True might be best, since it avoids any potential linguistic confusion about double negatives.

@afaulconbridge I made a PR and linked it to this issue (https://github.com/opentargets/data_pipeline/pull/517). I have tested a version of this in 19.04.5 but not yet in master (to where the PR is made). Please let me know what you think of this PR. I will wait for your feedback before testing it on master (I expect testing could take some time since there seems to be quite some changes between 19.04 and 19.06). Thanks!

For completeness: I rebased the pull request that Pieter mentioned to resolve the merge conflicts after several major changes in the master branch.

The patch to fix this has been released in 19.09, this is probably resolved. I haven't had the chance to test it yet, though.


work around regression in kubernetes-model breaking S2I binary builds https://github.com/fabric8io/kubernetes-model/issues/173 also add a retry in case we hit timing issues

lgtm [merge]


Confusing webpack instructions

I cannot get webpack to work. The biggest blocker is that postcss-import provides this as an example reads:
module.exports = {
  parser: 'sugarss',
  plugins: {
    'postcss-import': {},
    'postcss-preset-env': {},
    'cssnano': {}
  }
}

whereas as the tailwind docs refer to
module.exports = {
  plugins: [
    // ...
    require('tailwindcss'),
    require('autoprefixer'),
    // ...
  ]
}

plugins is a list, rather than an object and it is not at all clear how to combine them

They are just alternative syntaxes for the same thing. Personally I prefer the array syntax because it's more flexible.
The equivalent array version of your first example is this:
module.exports = {
  parser: 'sugarss',
  plugins: [
    require('postcss-import'),
    require('postcss-preset-env'),
    require('cssnano'),
  ]
}

You can learn about PostCSS's config format here: https://github.com/michael-ciniawsky/postcss-load-config

thanks a lot. Feel free to close but do keep in mid that tailwind was my introduction to postcss, so this sort of discrepancy comes early in the learning curve


Run screenshot tests on CI

PR #181 added support for running "screenshot tests" locally, but for some reason they're segfaulting on CI. I tried a couple of things in that PR to remedy, none which helped;

Running on ubuntu latest: https://github.com/AmbientRun/Ambient/pull/181/commits/363328a4753bab8d6732e43155cce84360e6462c
Adding the bevy run dependencies: https://github.com/AmbientRun/Ambient/pull/181/commits/bf0f7b42ae694bb4a1fd089726c82ac7252a1b91

I also added a test to verify that it's possible to read textures to the cpu on the ci, and that seemed to work; https://github.com/AmbientRun/Ambient/pull/181/commits/de04ddfc292e0a653b98ab66ec73d19021f3aa6e
If anyone is interested in trying to debug this, just enable these two lines: https://github.com/AmbientRun/Ambient/blob/41a6f86c3df12707a02a72b6f4c660fc63cfe6c0/.github/workflows/ci.yml#L50
That will make it run the tests on the CI.
This all is basically the first step towards #28

Fixed, there's now a golden-image-test job on the ci


EC2 - Add unit tests for Route Tables

Codecov Report

Merging #4135 (4fc7c86) into master (4ae9b0e) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4135      +/-   ##
==========================================
+ Coverage   94.54%   94.74%   +0.20%
==========================================
  Files         479      479
  Lines       52310    52310
==========================================
+ Hits        49455    49563     +108
+ Misses       2855     2747     -108

Flag
Coverage Δ

servertests
55.36% <ø> (ø)

unittests
94.67% <ø> (+0.20%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/batch/models.py
87.23% <0.00%> (+1.38%)
:arrow_up:

moto/ec2/models.py
96.00% <0.00%> (+1.47%)
:arrow_up:

moto/batch/responses.py
86.66% <0.00%> (+4.84%)
:arrow_up:

moto/ec2/responses/transit_gateway_route_tables.py
100.00% <0.00%> (+14.70%)
:arrow_up:

moto/ec2/responses/transit_gateway_attachments.py
100.00% <0.00%> (+25.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae9b0e...4fc7c86. Read the comment docs.


fix(StyleObserver): parse style without breaking urls

Regex was splitting style strings at all : and breaking urls
Fixes #301

@z-brooks thanks for fixing this so quickly- would you mind adding a test for this case?
thanks!

Sure thing.

Ok, tests done.

@jdanyow CLA is confirmed. Please merge if you think it's ready. Thanks!

@jdanyow Is this ready to merge? I can merge it. Just let me know. I'd like to get some new releases out tomorrow, if possible.

thanks again @z-brooks

I think this problem still happening when ports are included in url like: http://host:port/image.jpg

Also, there are URLs that don't have slashes like blob: URLs.


Security: if (env.IsEnvironment("Development")) is true on Azure

Using VS2015 RC.
Create a new MVC 6 app and deploy to Azure. The debugger shows that the following code in the Configure method in startup.cs returns true on Azure
 if (env.IsEnvironment("Development"))
            {
                app.UseBrowserLink();
                app.UseErrorPage(ErrorPageOptions.ShowAll);
            }

So on Azure you could leak information through the call stack and detailed errors. I used KUDU to verify ("Development") is not an environment variable.

The env var is called ASPNET_ENV or something, and its value is the environment name. Not that this necessarily explains what you're seeing...

It does, we don't default to Production yet...

Oh... we want to change the default in Antares or something? I vaguely recall discussing this like 12 months ago...

Ahh yes I dont think we ever did that.

Yes. You all promised that release would be the default a year ago. Changing the default in Antares isn't enough. Change the default everywhere as was agreed.

So default is Release (or Production or whatever) and VS sets its F5/Run setting to Development? That sounds familiar too.

That was what we agreed to, but still isn't implemented.

@blowdart can you log a bug in Tooling-Internal for VS and another bug in DNX for the runtime?

Or sorry, no bug in DNX. Just Hosting. Which is this bug. So just one bug :smile:

One new bug, that is :smile:

Yes, it's been in DNX for a while - https://github.com/aspnet/dnx/issues/777

I think this is a Hosting-specific thing though, isn't it? Maybe back then it was DNX-wide but I'm not sure that's the case anymore... is it?

We had not done this yet because we were waiting on tooling to set the variable to development, so that we didn't change everyone to prod on their dev machine overnight. Not sure if that work has been done or not yet.

There was no issue logged with tooling, so there doesn't appear to have been any tracking of this. There is now an issue.

Ok, tracked this down a bit more. VS sets it to dev when running IISExpress.

This is hosting specific.  Assigning to @Tratcher


[website] Add a "brand" page to the website

Add a basic "brand" page for the website where the logos of StyleX can be downloaded in various configurations.
Also, right clicking the logo in the nav-bar should open the brand page.

I'll work on this, can somebody please send me the logos plss

In #756 I've added a couple of additional "large" SVG assets that can be used for this. There were already "small monochrome" variants available along with an SVG favicon.
I'll soon follow-up with "small multi-color" variants of the logo which we doesn't exist yet, but probably should.


ToolTip is not showing on iOS 13 devices

ToolTip is not appearing on iOS 13 burbuttonitem tap devices but works fine on other versions

🚀  EasyTipView (2.1.0)

🚀  EasyTipView (2.1.0)


Hovering above the ground after falling (jumping)

After first jump collider starts hovering above the ground slightly (step offset on/off doesn't matter). With step offset turned on I can climb a step and collider sits normally, but if I then jump and land on that step - same hovering occures. Same thing occures when i don't jump, but simply fall down (not from the start of a game however). Do you have any ideas, why?
EDIT: I figured is has something to do with vertical velocity. Seems like some error in vertical collision detection algorythm,

I Just fixed it. Not an elegant way, but eh.
So, problem was - tracing to floor returned true after successfull trace down while being 0.15f above the ground. After that ground variable was set and y.velocity set to 0;
I shortend this trace dowb to 0.01f and after success just snaped player origin down by traced distance:
SurfController.cs

Doing this part of the script stops the player from being able to swim up in water.


Silent Rule Error:  json: unsupported value: NaN

When running the following rule http://goo.gl/5lHXKY the web interface returns immediately with no error displayed. When the rule is run the following is logged: json: unsupported value: NaN. If I remove either side of the || operator (And the operator of itself) from ($error_count > 10) || ($timeout_rate > 2) it works.

Oh, it is becuase the groups don't join, the following works: warn = ungroup($error_count > 10) || ungroup($timeout_rate > 2). Still should throw and error in the web interface though

same sympton, potentially different cause:
alert requests_by_country {
    template = requests_by_country
    $r = "transformNull(sum(stats.dfvimeopweb*.request.web),0)"
    $r_duration = "30m"
    $r_period = "7d"
    $r_hist = graphiteBand($r, $r_duration,$r_period, "",1)
    $r_now = graphite($r, $r_duration, "", "")
    $r_hist_med = median($r_hist)
    $r_now_med = median($r_now)

    $rbc = "aliasByNode(transformNull(stats._sum_dfvimeopweb.request_by_country.*,0),3)"
    $duration = "10m"
    $period = "1h"
    $lookback = 1
    $rbc_hist = graphiteBand($rbc, $duration,$period, "country",$lookback)
    $rbc_now = graphite($rbc, $duration, "", "country")
    $rbc_hist_med = median($rbc_hist)
    $rbc_hist_dev= dev($rbc_hist)
    $rbc_now_med = median($rbc_now)
    $rbc_now_dev = dev($rbc_now)

    $rbc_med_diff = ($rbc_now_med - $rbc_hist_med)/$rbc_hist_dev
    $rbc_med_bad = $rbc_med_diff < -4
    $rbc_dev_units = $rbc_now_dev/$rbc_hist_dev
    $rbc_dev_bad = $rbc_dev_units > 3

    $r_strength = $r_now_med/$r_hist_med
    $rbc_med_issues = sum(t($rbc_med_bad,""))
    $rbc_dev_issues = sum(t($rbc_dev_bad,""))
    warn = $rbc_med_issues > 0 || $rbc_dev_issues > 0
    crit = ($rbc_med_issues > 10 || $rbc_dev_issues > 10) || ($r_strength < 0.7)

}

the $r graphite expression returns a single series, $rbc returns multiple series with each a tagset, but all the rbc stuff gets transposed down. so everything in warn and crit has no associated groups.
also because of the transformNull's in the graphite queries, we don't have nulls in the graphite output. yet i also get json: unsupported value: NaN and sometimes json: unsupported value: +Inf
I tried
warn = $rbc_med_issues > 0
crit = $rbc_med_issues > 10

but i still get the same issue


Rewrite signup form tests with Playwright

During a recent Zoom meeting, pngn (a Svelte core team member) recommended Playwright for integration tests to me. We're currently using Puppeteer. Playwright was developed by the same guys who created Puppeteer at Google.
Just now had a chance to check it out and it looks great! We should refactor our signup form tests to use Playwright at earliest convenience. The big plus Playwright offers us are different browser contexts. These allow us to simulate running our tests in Chrome, Firefox and even Webkit, covering almost all web traffic. No more "It works on my machine, not sure what's going wrong on yours".

It shouldn't actually be that much work since the Puppeteer and Playwright APIs seem quite similar.
@kleinicke @l8l @alchemiker  Let me know if anyone wants to have a go at it
Here's how SvelteKit uses Playwright for integration testing.


Reducer Parser - Remove call keyword

This is not as easy as it seems.  And the change is not simply in one place. There is a rewriting of the statement related rules.

We are parsing a bit Haskell-like. There is no provision for unassigned expressions naturally in the grammar.
The current grammar is simple: "statement* expression"
This requires to change first to parse like an imperative language
Then to detect if the last statement is an expression
-- Parse "statement+" then detect if the last one is an expression to change the syntax tree.
This solves the outer block but then we will allow blocks that does not return anything as a side effect.

Removing call keyword will allow users to write whole blocks to trash away the results without a warning.

Hmm. I'm not sure if this is a good idea, semantics-wise. It assumes that functions can have side-effects, and that's pretty weird for the language that's mostly functional and pure.
Maybe there's a bigger discussion to be had here, about whether we even want Squiggle to be pure. If we're going to add many functions with side-effects in the future, we might as well just make Squiggle imperative, and maybe even replace shadowing semantics with mutable variables (I'm really unclear at this point on whether this would be good or bad, I know several arguments for both sides, but mostly lean towards functional).
If Squiggle stays functional, something like Rescript's ->ignore seems cleaner, and call currently serves this purpose. Or maybe we could mark just a few builtins (plot, print) as non-pure and allow expressions with those but not any others?..

Notes on (plot, print) like impurities.
There is a way to have them pure and functional. Otherwise we have to introduce monads and states to Squiggle implementation.
This trick is used by the PineScript developers.
Special cases like plot are transformed by the parser into functional cases.
plot(sth)
becomes
all_plots = plot(all_plots, sth)
Hence all such cases are functional but there is syntax shortcut provided for the users.
If you think carefully then there is really never ever a need to implement functions with side effects behind the scenes.
The other way, really implementing void functions, does also mean there are globals and states somewhere. It's easy but it is also the entry to non-testable applications.

I would vote for replacing call with ->ignore
And pray that nobody claims that using it is the only way for a certain library. See above. There is no need to introduce voids and internal globals to Squiggle.  There is no need to implement impurities! They can stay as syntax conversions for the ease of users.


Increase upper limit for ReadRelationships, LookupResources, and DeleteRelationships API

Currently the API limits for these requests are set to 1,000 which can make deleting/reading millions of relationships take quite a long time. This PR increased the limit to 10,000. This limit should still protect the underlying datastore while allowing for more flexibility.

Closing in favor of https://github.com/authzed/api/pull/99


Why does debugging info often repeat the 100% downloaded info ?

Checklist

[X] I'm asking a question
[X] I've looked through the README and FAQ for similar questions
[X] I've searched the bugtracker for similar questions including closed ones

Question
The verbose option for printing debugging information often, but not always, repeats the download complete line.  For an 18MB download, for example, at the completion of a download (before post-processing), it often prints:

[download] 100% of 17.90MiB in 00:10
[download] 100% of 17.90MiB in 00:10

I use the 100% indicator to check that a download completed successfully.  This is fine normally but, when downloading multiple files in one process (e.g. a batch), the number of "100%" messages does not necessarily respond to the number of successful downloads.
So, my question is why is the "100%" message often repeated ?  And, why not for all downloads but only for some ?
Thanks.

Post verbose log.

Apologies, I was going to give a verbose log example but, anyway, forgot.  Here is an example:

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--ignore-errors', u'--prefer-ffmpeg', u'--no-overwrites', u'--verbose', u'-o', u'%(title)s.%(ext)s', u'https://iview.abc.net.au/show/alan-duffy-s-astronomy-glossary/video/IV1745H001S00']
[debug] Encodings: locale US-ASCII, fs utf-8, out None, pref US-ASCII
[debug] youtube-dl version 2020.01.24
[debug] Python version 2.7.16 (CPython) - Darwin-18.7.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.2.2-tessus, ffprobe 4.2.2-tessus
[debug] Proxy map: {}
[debug] Using fake IP <IP_ADDRESS> (AU) as X-Forwarded-For.
[abc.net.au:iview] IV1745H001S00: Downloading JSON metadata
[abc.net.au:iview] IV1745H001S00: Downloading webpage
[abc.net.au:iview] IV1745H001S00: Downloading m3u8 information
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on u'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/index_0_av.m3u8?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d'
[hlsnative] Downloading m3u8 manifest
WARNING: hlsnative has detected features it does not support, extraction will be delegated to ffmpeg
[download] Destination: Alan Duffy's Astronomy Glossary.mp4
[debug] ffmpeg command line: ffmpeg -y -loglevel verbose -headers 'Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip, deflate
X-Forwarded-For: <IP_ADDRESS>
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.55 Safari/537.36
Accept-Charset: ISO-8859-1,utf-8;q=0.7,;q=0.7
Cookie: hdntl=exp=1581295249~acl=%2f~data=hdntl~hmac=c13037fcb4bfb57119c24fd9a9bef600c56d86abd83abce1ffae8955d1f15305
' -i 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/index_0_av.m3u8?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' -c copy -f mp4 '-bsf:a' aac_adtstoasc 'file:Alan Duffy'"'"'s Astronomy Glossary.mp4.part'
ffmpeg version 4.2.2-tessus  https://evermeet.cx/ffmpeg/  Copyright (c) 2000-2019 the FFmpeg developers
built with Apple clang version 11.0.0 (clang-1<IP_ADDRESS>)
configuration: --cc=/usr/bin/clang --prefix=/opt/ffmpeg --extra-version=tessus --enable-avisynth --enable-fontconfig --enable-gpl --enable-libaom --enable-libass --enable-libbluray --enable-libdav1d --enable-libfreetype --enable-libgsm --enable-libmodplug --enable-libmp3lame --enable-libmysofa --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenh264 --enable-libopenjpeg --enable-libopus --enable-librubberband --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libtheora --enable-libtwolame --enable-libvidstab --enable-libvmaf --enable-libvo-amrwbenc --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxavs --enable-libxvid --enable-libzimg --enable-libzmq --enable-libzvbi --enable-version3 --pkg-config-flags=--static --disable-ffplay
libavutil      56. 31.100 / 56. 31.100
libavcodec     58. 54.100 / 58. 54.100
libavformat    58. 29.100 / 58. 29.100
libavdevice    58.  8.100 / 58.  8.100
libavfilter     7. 57.100 /  7. 57.100
libswscale      5.  5.100 /  5.  5.100
libswresample   3.  5.100 /  3.  5.100
libpostproc    55.  5.100 / 55.  5.100
[tcp @ 0x7fb992c00880] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992c00880] Successfully connected to <IP_ADDRESS> port 80
[hls @ 0x7fb993004400] Skip ('#EXT-X-ALLOW-CACHE:YES')
[hls @ 0x7fb993004400] Skip ('#EXT-X-VERSION:2')
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment1_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/crypt.key?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992c05f80] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992c05f80] Successfully connected to <IP_ADDRESS> port 80
[AVIOContext @ 0x7fb992c06080] Statistics: 16 bytes read, 0 seeks
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment1_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992c06080] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992c06080] Successfully connected to <IP_ADDRESS> port 80
[h264 @ 0x7fb993016800] Reinit context to 1024x576, pix_fmt: yuv420p
Input #0, hls, from 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/index_0_av.m3u8?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d':
Duration: 00:02:41.00, start: 0.100511, bitrate: 0 kb/s
Program 0
Metadata:
variant_bitrate : 0
Stream #0:0: Video: h264 (High), 1 reference frame ([27][0][0][0] / 0x001B), yuv420p(left), 1024x576 [SAR 1:1 DAR 16:9], 25 fps, 25 tbr, 90k tbn, 50 tbc
Metadata:
variant_bitrate : 0
Stream #0:1: Audio: aac (LC) ([15][0][0][0] / 0x000F), 44100 Hz, stereo, fltp
Metadata:
variant_bitrate : 0
Stream #0:2: Data: timed_id3 (ID3  / 0x20334449)
Metadata:
variant_bitrate : 0
Output #0, mp4, to 'file:Alan Duffy's Astronomy Glossary.mp4.part':
Metadata:
encoder         : Lavf58.29.100
Stream #0:0: Video: h264 (High), 1 reference frame (avc1 / 0x31637661), yuv420p(left), 1024x576 (0x0) [SAR 1:1 DAR 16:9], q=2-31, 25 fps, 25 tbr, 90k tbn, 90k tbc
Metadata:
variant_bitrate : 0
Stream #0:1: Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp
Metadata:
variant_bitrate : 0
Stream mapping:
Stream #0:0 -> #0:0 (copy)
Stream #0:1 -> #0:1 (copy)
Press [q] to stop, [?] for help
[AVIOContext @ 0x7fb992c06640] Statistics: 1307540 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment2_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment2_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d12d00] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d12d00] Successfully connected to <IP_ADDRESS> port 80
frame=  393 fps=0.0 q=-1.0 size=    1792kB time=00:00:15.74 bitrate= 932.5kbits/s speed=31.2x
[AVIOContext @ 0x7fb992d13680] Statistics: 1121044 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment3_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment3_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992c06e80] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992c06e80] Successfully connected to <IP_ADDRESS> port 80
frame=  500 fps=477 q=-1.0 size=    2048kB time=00:00:19.99 bitrate= 839.2kbits/s speed=19.1x
frame=  601 fps=378 q=-1.0 size=    2560kB time=00:00:24.05 bitrate= 871.8kbits/s speed=15.1x
frame=  653 fps=307 q=-1.0 size=    2816kB time=00:00:26.16 bitrate= 881.5kbits/s speed=12.3x
frame=  713 fps=269 q=-1.0 size=    3072kB time=00:00:28.51 bitrate= 882.6kbits/s speed=10.8x
[AVIOContext @ 0x7fb992c07840] Statistics: 1316940 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment4_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment4_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d1b140] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d1b140] Successfully connected to <IP_ADDRESS> port 80
[AVIOContext @ 0x7fb992e005c0] Statistics: 1397780 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment5_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment5_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992f0ab80] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992f0ab80] Successfully connected to <IP_ADDRESS> port 80
frame= 1000 fps=311 q=-1.0 size=    4608kB time=00:00:39.98 bitrate= 944.1kbits/s speed=12.4x
[AVIOContext @ 0x7fb992c06480] Statistics: 1355668 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment6_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment6_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d13140] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d13140] Successfully connected to <IP_ADDRESS> port 80
frame= 1470 fps=395 q=-1.0 size=    6912kB time=00:00:58.79 bitrate= 963.1kbits/s speed=15.8x
[AVIOContext @ 0x7fb992e00600] Statistics: 1295508 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment7_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment7_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992f02380] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992f02380] Successfully connected to <IP_ADDRESS> port 80
[AVIOContext @ 0x7fb992c06480] Statistics: 1346644 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment8_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment8_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d12b80] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d12b80] Successfully connected to <IP_ADDRESS> port 80
frame= 1820 fps=431 q=-1.0 size=    8704kB time=00:01:12.81 bitrate= 979.2kbits/s speed=17.3x
[AVIOContext @ 0x7fb992c06480] Statistics: 1346644 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment9_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment9_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d13180] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d13180] Successfully connected to <IP_ADDRESS> port 80
[AVIOContext @ 0x7fb992d13380] Statistics: 1121044 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment10_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment10_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d1b780] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d1b780] Successfully connected to <IP_ADDRESS> port 80
frame= 2295 fps=486 q=-1.0 size=   10752kB time=00:01:31.83 bitrate= 959.1kbits/s speed=19.4x
[AVIOContext @ 0x7fb992c06480] Statistics: 1241364 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment11_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment11_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d1b780] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d1b780] Successfully connected to <IP_ADDRESS> port 80
[AVIOContext @ 0x7fb992c06480] Statistics: 1289492 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment12_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment12_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992c064c0] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992c064c0] Successfully connected to <IP_ADDRESS> port 80
frame= 2750 fps=524 q=-1.0 size=   12800kB time=00:01:49.99 bitrate= 953.3kbits/s speed=20.9x
[AVIOContext @ 0x7fb992d1ae00] Statistics: 1292500 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment13_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment13_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d1b8c0] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d1b8c0] Successfully connected to <IP_ADDRESS> port 80
frame= 3230 fps=561 q=-1.0 size=   15104kB time=00:02:09.21 bitrate= 957.5kbits/s speed=22.5x
[AVIOContext @ 0x7fb992c06480] Statistics: 1382740 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment14_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment14_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d1b8c0] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d1b8c0] Successfully connected to <IP_ADDRESS> port 80
frame= 3365 fps=536 q=-1.0 size=   15872kB time=00:02:14.60 bitrate= 966.0kbits/s speed=21.4x
frame= 3457 fps=508 q=-1.0 size=   16384kB time=00:02:18.32 bitrate= 970.3kbits/s speed=20.3x
[AVIOContext @ 0x7fb992c06480] Statistics: 1557204 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment15_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment15_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d12c00] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d12c00] Successfully connected to <IP_ADDRESS> port 80
frame= 3601 fps=493 q=-1.0 size=   17152kB time=00:02:24.05 bitrate= 975.4kbits/s speed=19.7x
[AVIOContext @ 0x7fb992d13740] Statistics: 1163532 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment16_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment16_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992d1b900] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992d1b900] Successfully connected to <IP_ADDRESS> port 80
[AVIOContext @ 0x7fb992c06480] Statistics: 384084 bytes read, 0 seeks
[hls @ 0x7fb993004400] HLS request for url 'http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment17_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d', offset 0, playlist 0
[hls @ 0x7fb993004400] Opening 'crypto+http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/segment17_0_av.ts?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d' for reading
[tcp @ 0x7fb992c02840] Starting connection attempt to <IP_ADDRESS> port 80
[tcp @ 0x7fb992c02840] Successfully connected to <IP_ADDRESS> port 80
[AVIOContext @ 0x7fb992e005c0] Statistics: 9588 bytes read, 0 seeks
No more output streams to write to, finishing.
frame= 4003 fps=510 q=-1.0 Lsize=   18333kB time=00:02:40.17 bitrate= 937.7kbits/s speed=20.4x
video:15676kB audio:2503kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.847542%
Input file #0 (http://iviewhls-i.akamaihd.net/i/playback/definst/video/iv1/IV1745H001S00MA1D1_20171216122015,1500000,1000000,650000,500000,220000,.mp4.csmil/index_0_av.m3u8?null=0&id=AgC0lkPhF87yBBFVP15QZGh1dzqI2+sSDX6uggA87Uw%2fTn8hw45EOXGjzBfDVCzeaf5KGxOGyMM5oQ%3d%3d):
Input stream #0:0 (video): 4003 packets read (16052493 bytes);
Input stream #0:1 (audio): 6899 packets read (2611405 bytes);
Input stream #0:2 (data): 0 packets read (0 bytes);
Total: 10902 packets (18663898 bytes) demuxed
Output file #0 (file:Alan Duffy's Astronomy Glossary.mp4.part):
Output stream #0:0 (video): 4003 packets muxed (16052493 bytes);
Output stream #0:1 (audio): 6899 packets muxed (2563112 bytes);
Total: 10902 packets (18615605 bytes) muxed
[AVIOContext @ 0x7fb992f035c0] Statistics: 2 seeks, 75 writeouts
[AVIOContext @ 0x7fb992c024c0] Statistics: 5028 bytes read, 0 seeks

[ffmpeg] Downloaded 18773380 bytes

[download] 100% of 17.90MiB in 00:13

[download] 100% of 17.90MiB in 00:13
[debug] ffmpeg command line: ffprobe -show_streams 'file:Alan Duffy'"'"'s Astronomy Glossary.mp4'
[ffmpeg] Fixing malformed AAC bitstream in "Alan Duffy's Astronomy Glossary.mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel 'repeat+info' -i 'file:Alan Duffy'"'"'s Astronomy Glossary.mp4' -c copy -f mp4 '-bsf:a' aac_adtstoasc 'file:Alan Duffy'"'"'s Astronomy Glossary.temp.mp4'


Select component for installation with a mouse click inside card

Currently selection is done by clicking directly on checkbox at the left-hand side.

A silly observation: you can select/deselect components by clicking anywhere but on the checkbox itself.

nice catch 👍


docs(seo): update project documentation with SEO keywords

Description
This PR adds the SEO keywords to the open-sourced docs.

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[X] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Closes #223
Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

[ ] 📜 README.md
[X] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

@Suraj-kumar00 can you change the title of the PR to reflect the issue:
feat: update project documentation with SEO keywords

Hi @BekahHW I changed the PR title.
Mam can we connect here on GitHub?


-I doesn't work with pre-commit

Environment

interrogate, version 1.5.0
OS: Windows 10
Python version: 3.8.10

Description of the bug
I'm trying to use interrogate through pre-commit with this hook
  - repo: https://github.com/econchick/interrogate
    rev: 1.5.0
    hooks:
      - id: interrogate
        language: python
        types: [python]
        args:
          [
            "-vv",
            "-i",
            "-I",
            "-M",
            "--fail-under=60",
         ]

If I run pre-commit run --all-files
I obtain
| TOTAL                                         |   517 |  378 |   139 |  26.9% |
--------------- RESULT: FAILED (minimum: 60.0%, actual: 26.9%) ----------------

If instead I run interrogate -vv -i -I -M --fail-under=60 .
I obtain
| TOTAL                                                      |             491 |            364 |             127 |            25.9% |
------------------------------------------- RESULT: FAILED (minimum: 60.0%, actual: 25.9%) -------------------------------------------

That is because in the first case __init__.py are not ignored, while in the second case they are correctly ignored as by -I documentation.
I've done the test also on -M and -i but these two parameter works properly resulting in the same output on both executions.
What you expected to happen
Output of both run should be exactly the same
How to reproduce (as minimally and precisely as possible)
Run interrogate with -I parameter using pre-commit and using cli on an  __init__.py file that lacks documentation, the one from cli should pass, the one from interrogate should wrongly fail.
Anthing else we need to know?
I guess it's pretty much the same problem of #60 but here there's no workaround!

Add pass_filenames: false to your hook. See: https://github.com/econchick/interrogate/issues/60#issuecomment-735436566


showYAxisLabels ignored

Hi!
In the Version 1.0.8-beta the "showYAxisLabel" setting seems to be ignored. After checking in the source I found that in yAxis.js the showYAxisLabel property is never applied. In xAxis.js the showXAxisLabel is used, and it works as expected. Is this an oversight, or is there a reason showYAxisLabel is not used?

As a generic FYI — I am no longer able to maintain this library. I recommend checking out victory-native as it's much more maintained.


ESC key does not work on Windows

Hi,
on Windows, I can't use ESC key. So it's impossible to cancel any dialing/refer prompt, and to hangup/reject a call with ESC key.
Here a patch for modules/wincons/wincons.c in input_thread():
 static DWORD WINAPI input_thread(LPVOID arg)
 {
        struct ui_st *st = arg;
@@ -85,23 +95,25 @@

        while (st->run) {

-               char buf[4];
+               INPUT_RECORD buf[4];
                DWORD i, count = 0;

-               ReadConsole(st->hstdin, buf, sizeof(buf), &count, NULL);
+               ReadConsoleInput(st->hstdin, buf, sizeof(buf), &count);

                for (i=0; i<count; i++) {
-                       int ch = buf[i];
-
-                       if (ch == '\r')
-                               ch = '\n';
-
-                       /*
-                        * The keys are read from a thread so we have
-                        * to send them to the RE main event loop via
-                        * a message queue
-                        */
-                       mqueue_push(st->mq, ch, 0);
+                       if (buf[i].EventType == KEY_EVENT) {
+                               if (buf[i].Event.KeyEvent.bKeyDown) {
+                                       int ch = buf[i].Event.KeyEvent.uChar.AsciiChar;
+
+                                       if (ch == '\r')
+                                               ch = '\n';
+
+                                       /*
+                                        * The keys are read from a thread so we have
+                                        * to send them to the RE main event loop via
+                                        * a message queue
+                                        */
+                                       mqueue_push(st->mq, ch, 0);
+                               }
+                       }
                }
        }

In the TODO, I can see "improve gui and multi-UA and multi-call interaction", is someone working on this or got some ideas how to implement it ?
Right now, it's impossible to select or switch from many call.
Thanks.

thanks @GGGO for the patch, it was commit to master (with minor adjustments).
regarding improving the GUI there are plans to do it, and I think we need input from
community regarding how it should work. For example we should add long-string commands
because the single key command space is "used up" ..
example:
'd'    "dial"                  Dial remote uri
's'    "sysinfo"             Print system info
      "load_module"    Load a module

I think it's two topics so I created #140 and #141


zappa update should not create new duplicate keep_warm event

I have my "keep_warm": true, in the config file but whenever I zappa update dev, it creates new keep warm event showing up in the Event Sources UI.

Duplicate of https://github.com/Miserlou/Zappa/issues/101 - resolved, fix should be pushed today.


Issue 8 add quickumls to pipeline attempt 2

Finally resolving Issue #8 to add QuickUMLS to medspacy.   By default, this is only installed and tested for non-Windows systems as Windows currently requires packages to be installed by conda as opposed to setuptools or pip.
An example notebook is now provided showing that UMLS CUIs are extracted from a small sample file.

Please let me know if there are any questions on this at all.

As discussed, I added some instructions on Windows.  @abchapman93  is going to try them out.

Okay, I was able to build this on Windows and use it, it works quite well! I made one additional commit so that it comes before context (otherwise all the QuickUMLS ents won't have context run on them).
I think this is pretty much good to go from my perspective. The new instructions for Windows were really easy to follow and worked. Here are a couple of notes of things that would be useful either now or in the near future:

Are there instructions, or ideally even a script, for processing the raw UMLS resources that come from NLM and building them in the format needed for QuickUMLS? If we were to add a script for this, it would also be helpful if the script puts it in the standard resources location and then we modify the load() function to look there for the files so the user doesn't have to always specify the path, maybe just put quickumls_path="default"
As I was going through it, I realized that QuickUMLS sometimes parses entities like "no pneumothorax" with the negation term as part of it, and ConText won't let a modifier modify a span that it is a part of. I should tweak that in ConText
Once we merge into develop, we should maybe add some more details to the notebook, or integrate it into existing notebooks

Otherwise, I think this is good, and it's really exciting!

I'll address the other aspects later, but first the issue of QuickUMLS to be added as a pipeline step before context is crucial.  I just updated this now since I forgot about order importance.  Good eye on this one!
I just looked at your commit and it looks great:
e522725ba38201a7dd99974e9394785aeb106730

I also don't think these are "must-have" changes to merge into develop, we could add documentation/instructions in develop, so I'm going to mark this code review as done 👍

We have a number of things in flight at the moment, so I wanted to make sure another pull request ran clean in CI.
Now that it is, I'll merge this in.


jsonls code formatting not working: attempt to index a nil value

nvim --version: NVIM v0.5.0-650-g4bcf54478
nvim-lsp version(commit hash): 419fa4006e7c15cbc2f81f5110952de562494cd4
What language server(If the problem is related to a specific language server): jsonls
Operating system/version: Manjaro Linux x64
Terminal name/version: Gnome

How to reproduce the problem from neovim startup
Install jsonls via :LspInstall jsonls
Add a minimal jsonls-setup to init.vim, mine is just empty:
nvim_lsp.jsonls.setup{}
Open a valid .json-file
execute:
:lua vim.lsp.buf.formatting_sync()
Actual behaviour
Error is: E5108: Error executing lua /usr/share/nvim/runtime/lua/vim/lsp/buf.lua:144: attempt to index a nil value
Expected behaviour
The buffer is being formatted (pretty-printed)
Additional notes
The documentation for jsonls
https://www.npmjs.com/package/vscode-json-languageserver

Formatting support requires the client to support dynamicRegistration for rangeFormatting. If not supported by the client, the server will not offer the format capability.

Maybe this requires additional setup defaults for formatting to work?

This issue probably belongs in the neovim/neovim repo.

Maybe this requires additional setup defaults for formatting to work?

maybe. We don't provide support for the hundreds of LSPs out there, we need improvements sent by users.

This issue probably belongs in the neovim/neovim repo.

The error message could definitely be better.

With NVIM v0.5.0-660-g2cea6ab01 my issue is gone. Has a fix been provided or did I experience a heisenbug?

With NVIM v0.5.0-660-g2cea6ab01 my issue is gone. Has a fix been provided or did I experience a heisenbug?

Can you check recently merged PRs to see if a recent fix applies to your issue here?
https://github.com/neovim/neovim/pulls?q=lsp+is%3Apr+is%3Amerged+sort%3Aupdated-desc
(or git bisect)
@Kraust updating Nvim also fix the issue for you?

@justinmk  I'm on NVIM v0.5.0-671-gc1d395a6d and still seeing the issue.

I made some more substantial tests to narrow down the issue.
When I use yamlls alone, no issue.
When I use gopls alone, no isse.
When I have open buffers with both yaml and go code, I can confirm the behavior described by  @Kraust - For the ls started second, the error message
E5108: Error executing lua /usr/share/nvim/runtime/lua/vim/lsp/buf.lua:144: attempt to index a nil value
appears.
jsonls always and reliably triggers another error message:
E5108: Error executing lua /usr/share/nvim/runtime/lua/vim/lsp/util.lua:137: bad
argument #1 to 'next' (table expected, got nil)
So I think we have two issues here:

Running multiple LS concurrently. An issue maybe better filed in neovim/neovim as mentioned by @lithammer and seen by @Kraust and confirmed by me.
Formatting json using jsonls. Probably only an issue of setup defaults for the LS.