How can I use the Model

is there a link to the pre-trained weights and how I can use the repository

All our model training code was in /OTE-GAN, Without pre-trained weights
There are two experiments on unsupervised and degradation dataset settings.
Unsupervised setting prepared the dataset from  Quality label [https://github.com/HzFu/EyeQ] EYEPACS [https://www.kaggle.com/c/diabetic-retinopathy-detection/data]
->  Change the root dictionary in train.py -> parser.add_argument("--root", default="dataset/preprocessed/ALLDATA", type=str)
parser.add_argument("--file_dir",default="dataset/Label_EyeQ_train.csv", type=str)
->  Run /OTE-GAN/train.py         (Other baseline models followed the same steps)
Degradation setting processing from https://github.com/joanshen0508/Fundus-correction-cofe-Net
-> Change the root dictionary in the train_full.py  parser.add_argument("--root", default="dataset/degratation/pre", type=str)
parser.add_argument("--file_dir",default="dataset/train.csv", type=str)
->  Run /OTE-GAN/train_full.py         (Other baseline models followed the same steps)

I didn't understand I will change the  -> Change the root dictionary in the train_full.py parser.add_argument("--root", default="dataset/degratation/pre", type=str)
to what ?
the second question you save the checkpoint at the end of  every epoch is their criteria to choose the best checkpoint

I don't know how to generate mask?


Add displayName to connectHOC and add explicit class

Pull Request Test Coverage Report for Build 131

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 95.588%

Totals

Change from base Build 130:
-0.3%

Covered Lines:
186

Relevant Lines:
187

💛  - Coveralls


unpicklable=False not applicable recursively

Hi,
I think is applicable only in first level, not recursively.
I have this structure of objects :
class Response(object):

    def __init__(self, action, status, detail):
        self.action = action
        self.status = status
        self.detail = detail

detail here can be a MyException object :
class MyException(Exception):

    def __init__(self, code, message):
        self.code = code
        self.message = message

I want to get the json representation of my Response object including only the attributes, without any other information, this is what I did :
response = Response("Hello World", "1", MyException("1", "some errors message here"))
print(jsonpickle.encode(response, unpicklable=False))

I get this result :
{
    "action": "Hello World",
    "detail": {
        "py/reduce": [
            {
                "py/type": "com.test.MyException"
            },
            [
                "1",
                "some errors message here"
            ],
            {
                "code": "1",
                "some errors message here"
            },
            null,
            null
        ]
    },
    "status": 1
}

I am expecting this format :
{
    "action": "Hello World",
    "detail": {
                "code": "1",
                "some errors message here"
    },
    "status": 1
}

@davvid This now works as expected

Thanks!


normalize whitespace in PlatformDateDirectiveSpec for Scala.js

Unit tests for Scala.js starting failing in recent scala-steward PRs due to a recent change in time formatting in Node 18.13:
https://github.com/nodejs/node/issues/46123
The space character before AM/PM had been replaced by a non-breaking space character (\\u202f).
Since the linked ticket hints at this change potentially getting reverted in the future, this PR normalizes whitespace in the date formatter specs for Scala.js so that it is expected to work with the old and new versions of Node.

Not exactly related, but I had wanted to mention in light of the other discussion: to reduce the maintenance burden of Scala.js, instead of all this platform-specific code you could csondier using scala-java-time to share code with JVM.
https://github.com/cquiroz/scala-java-time
It would possibly be less nice for users, but it's probably overall a win maintainability vs usability tradeoff.

That might be an interesting option for 1.0. I'm just unclear on what it means for JVM users from looking at their documentation. Do they get an empty jar or one that somehow shadows the JVM classes? And what exactly do you think of when you say "less nice for users"?

I'm just unclear on what it means for JVM users from looking at their documentation. Do they get an empty jar or one that somehow shadows the JVM classes?

It shouldn't mean anything for JVM users. You don't add it to JVM dependencies, and they don't get anything :)
For JS users, that library provides Scala.js implementations of the JDK java.time APIs. They still compile against the JDK classes, but when the Scala.js linker is generating the JavaScript code it is able to fish the necessary implementations out of scala-java-time.

And what exactly do you think of when you say "less nice for users"?

It might increase the size of the JS code generated for their applications. This isn't a big deal for Node.js, but browser applications are more sensitive to this sort of thing. However, it depends on their usage pattern, since Scala.js aggressively dead-code-eliminates unused code from the artifact. Many users also already have scala-java-time in their application for some reason anyway. And lastly the size increase may be insignificant compared to the rest of their app or simply pulling in Laika.
Since you have a demo Scala.js application in the repo here, to get a feel for this we can measure the size before/after making the change.

I'm just unclear on what it means for JVM users from looking at their documentation. Do they get an empty jar or one that somehow shadows the JVM classes?

It shouldn't mean anything for JVM users. You don't add it to JVM dependencies, and they don't get anything :)

Ah, I was confused by the fact that they mention the JVM artefact explicitly: "The scala-java-time library is currently available for Scala (JVM, version 8 and later)". Is there any use case then for the JVM artefacts they publish?

It might increase the size of the JS code generated for their applications. This isn't a big deal for Node.js, but browser applications are more sensitive to this sort of thing. However, it depends on their usage pattern, since Scala.js aggressively dead-code-eliminates unused code from the artifact. Many users also already have scala-java-time in their application for some reason anyway. And lastly the size increase may be insignificant compared to the rest of their app or simply pulling in Laika.
Since you have a demo Scala.js application in the repo here, to get a feel for this we can measure the size before/after making the change.

That would be an interesting experiment. Btw. I think about removing the demo app for the 1.0 branch, as it requires maintaining a Node build just for the little demo. I consider adding support for rendering the AST to the preview server instead (e.g. by adding /ast to the URL) at which point the demo app would be fairly redundant.

Is there any use case then for the JVM artefacts they publish?

Once upon a time ago maybe you could use that library on pre-JDK8, before java.time was introduced. Also I believe the JVM artifacts are published under a different package name instead of java.time.

as it requires maintaining a Node build just for the little demo

Hmm, let me see what you are doing. Ideally it should not be any more burdensome than maintaining Scala.js support in general.

Oh I see, your demo is written using React? And it's bringing in a lot of JS dependencies. The good news is that none of that is necessary :) if it's okay with you, I can open a PR to re-implement the demo with Calico which is a 100% pure Scala frontend library, then we can drop all that package.json stuff. Or, there are other popular options such as Laminar but that's not pure FP.

That sounds cool, but I still feel like removing it is the more sensible approach. There isn't any feedback on it, I don't feel people are actually using it and it heavily overlaps with the preview server's functionality, especially after it gets expanded for AST support.

Ok, fair enough! 🙁


(browse) refactor test setup into the packages TestMain

Also blocked on: https://github.com/zaquestion/lab/pull/88


Quickly and massively activating ability to modify Heath values causes the server to lag behind in synchronizing to the client

My own project quickly and massively activated the ability to modify the Heath value, which would cause the server to lag behind the client. In fact, the intermediate value of a large number of changes was lost, and the derivative UI displayed intermittently.But in this case, it can be synchronized in a timely manner. Would you please tell me? I'm not very good at c++.

This Issues section is for problems with the GASDocumentation sample project or the README. For support in your own projects, try the Unreal Engine Forums or Unreal Slackers Discord Server.


Added guards to make it pass.

Seems to be crashing without these guards on my repo - I believe its mostly if you use ? as optional params.

It was something like this setup...
@Field(type => [LatestSensorValue])
public latest: [LatestSensorValue];
which works in prod ... but its not really right it should have been
@Field(type => [LatestSensorValue])
public latest: LatestSensorValue[];

Another one was like this:
@Field(type => Image, { nullable: true, description: "The uploaded image." })
public image?(
@Arg("ImageInput", { nullable: true }) imageInput: ImageInput,
@Root() metadata: Metadata
): Image | undefined {
}
the fact that optional was used in the   public image? ... crash the tool instead of allow it to pass

I added test for the 2 cases... please let me know if there is anything I can do to get this PR through !

Codecov Report

Merging #17 (0a9474c) into main (aff589c) will decrease coverage by 1.08%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##              main      #17      +/-   ##
===========================================
- Coverage   100.00%   98.91%   -1.09%
===========================================
  Files           18       18
  Lines          366      367       +1
  Branches       120      121       +1
===========================================
- Hits           366      363       -3
- Partials         0        4       +4

Impacted Files
Coverage Δ

src/util/decoratedValue.ts
95.12% <33.33%> (-4.88%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aff589c...0a9474c. Read the comment docs.

LGTM, thanks for your contribution!


Spack endpoint needs fixing

Another causality of renaming the spack packages API... :cry: https://github.com/vsoch/uptodate/issues/57

Should be fixed with https://github.com/vsoch/uptodate/issues/57.


/vehicle/status/control_mode is always autonomous with simple planning simulator

It should be MANUAL before autoware engage, the same as the simple planning simulator in autoware.iv

It should be MANUAL before autoware engage, the same as the simple planning simulator in autoware.iv

closed for this pr merged


Support accessibility for tristate checkboxes

Currently a11y treats tristate checkboxes as if they're ordinary checkboxes. The null (indeterminate) value is treated as if it were true.
HTML supports indeterminate checkboxes.
cc @goderbauer
See https://github.com/flutter/flutter/pull/14611

Fixed via https://github.com/flutter/flutter/pull/18297


[native filter] 'Clear All' will show error in value filter

when setup a value filter + numerical filter in a dashboard, set both filter 'Apply changes instantly', then select value for each filter and then click 'Clear All', value filter will show error of too many updates
Expected results
value filter and numerical filter can be clear
Actual results
value filter show error, numerical filter can be clear to origin state
Screenshots

https://user-images.githubusercontent.com/81597121/123245951-270abf80-d49a-11eb-859b-0e95a2e2489d.mov
How to reproduce the bug

Go to USA birth name dashboard
Setup a value filter, select 'apply change instantly'
Setup a numerical filter, select 'apply change instantly'
go to dashboard and select some value for both filter and see changes
click 'Clear All' and see error in value dashboard

Environment
(please complete the following information):

superset version: master
python version: python --version
node.js version: node -v

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

Reproduced

As per the plan to deprecate support for instant filtering outlined in #15067, this bug likely won't need to be addressed (removing P1).


[Missing Provider] - Google

https://cloud.google.com/storage

Started

This provider has region specific buckets, but not region specific URLs.


android adding few more pthread api calls.

@bors r+

:pushpin: Commit 727c42a91d63600251c0621e67c7c2d6869b199d has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 727c42a91d63600251c0621e67c7c2d6869b199d with merge 57c58d57d1f3942e123d480b40cbb533d7ccca4d...

@bors retry

:hourglass: Testing commit 727c42a91d63600251c0621e67c7c2d6869b199d with merge 128fa00d78ee61f7f48efc6a1a362adf6f636fb6...

:broken_heart: Test failed - checks-actions

@rustbot author
Please confirm the build before submitting a PR.

@bors r+

:pushpin: Commit 7a3357aa0feebd6b6b0673edae6acb09cea03bd7 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 7a3357aa0feebd6b6b0673edae6acb09cea03bd7 with merge c393de305ad2fe7b8c99461c72875bd0eb75f65e...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing c393de305ad2fe7b8c99461c72875bd0eb75f65e to main...


[8.x] Add tests for LazyCollection constructor laziness

This adds tests ensuring that:

Constructing a new LazyCollection instance from a generator function is lazy.
Constructing a new LazyCollection instance from another LazyCollection instance is lazy.
Constructing a new LazyCollection instance from a Generator object is not lazy.

See here for reference: https://github.com/laravel/framework/issues/36837#issuecomment-811926022

@JosephSilber Thanks a lot for this! 👏


Fix issue with dynamically added rows not rendering reg ex patterns correctly

^[a-zA-Z0-9\.\'\_\s]{3,30}$ is rendering as ^[a-zA-Z0-9s]{3,30}$ this means you can't have spaces, apostrophe's, etc.

Fixed by double escaping in the regex patterns used in the script.js file. They now read ^[a-zA-Z0-9\\.\\'\\_\\s]{5,100}$.
Also added commas for the recipe instruction inputs as I felt these would regularly be used in instructions, this now reads ^[a-zA-Z0-9\\.\\,\\'\\_\\s]{5,100}$.


Select with total items count: unexpected behavior

I am trying to execute a query that retrieves a subset (page) of filtered items and  the total number of the items produced by the original query, while using EFCore against SQL Server 2017.
Ideally, I would like to produce a query like
SELECT COUNT(*) OVER () TotalCount,
             x.*
FROM dbo.Entities x
ORDER BY x.Id DESC OFFSET 20 ROWS FETCH NEXT 5 ROWS ONLY

or
SELECT (SELECT COUNT(*) FROM dbo.Entities x0) TotalCount,
             x.*
FROM dbo.Entities x
ORDER BY x.Id DESC OFFSET 20 ROWS FETCH NEXT 5 ROWS ONLY

Using previous a previous (pre-RTM) version of EFCore (see this StackOverflow question) it was possible using the following 'trick'
 var query = context.Set<Entity>();
 var page = query.OrderBy(e => e.Id)
                 .Select(e => e)
                 .Skip(20).Take(5)
                 .GroupBy(e => new { Total = query.Count() })
                 .FirstOrDefault();

 if (page != null)
 {
      int total = page.Key.Total;
      List<Entity> events = page.ToList();
 }

but the same code with the current EFCore package produces the following SQL Profiler trace
SELECT [t].[Id], [t].[Name]
FROM (
    SELECT [e].[Id], [e].[Name]
    FROM [tests].[Entities] AS [e]
    ORDER BY [e].[Id]
    OFFSET 20 ROWS FETCH NEXT 5 ROWS ONLY
) AS [t]
ORDER BY (
    SELECT COUNT(*)
    FROM [tests].[Entities] AS [p0]
)

SELECT COUNT(*)
FROM [tests].[Entities] AS [p1]
SELECT COUNT(*)
FROM [tests].[Entities] AS [p1]
SELECT COUNT(*)
FROM [tests].[Entities] AS [p1]
SELECT COUNT(*)
FROM [tests].[Entities] AS [p1]
SELECT COUNT(*)
FROM [tests].[Entities] AS [p1]

Notice how the SELECT COUNT(*) ... is used for sorting the items in the page and is repeated for each item.
Considering that GroupBy has always been problematic, I tried with another approach:
var query = dbContext.Set<Entity>();
var pagedQueryable = query.OrderBy(e => e.Id)
                          .Skip(20).Take(5)
                          .Select(e => new
                                       {
                                               Total = query.Count(),
                                               Item = e
                                       });

var page = pagedQueryable.ToList();

var total = page.First()
                .Total;
var items = page.Select(x => x.Item)
                .ToList();

obtaining the following result:
SELECT [e].[Id], [e].[Name]
FROM [tests].[Entities] AS [e]
ORDER BY [e].[Id]
OFFSET 20 ROWS FETCH NEXT 5 ROWS ONLY

SELECT COUNT(*)
FROM [tests].[Entities] AS [p0]
SELECT COUNT(*)
FROM [tests].[Entities] AS [p0]
SELECT COUNT(*)
FROM [tests].[Entities] AS [p0]
SELECT COUNT(*)
FROM [tests].[Entities] AS [p0]
SELECT COUNT(*)
FROM [tests].[Entities] AS [p0]

As far as I know, this approach should work properly... at least it worked in May 2018 as per this other StackOverflow answer.
Testing the same scenario with older packages, I noticed that version 1.0.6 produced the SQL I was expecting
SELECT [e].[Id], [e].[Name], (
    SELECT COUNT(*)
    FROM [tests].[Entities] AS [e1]
)
FROM [tests].[Entities] AS [e]
ORDER BY [e].[Id]
OFFSET 20 ROWS FETCH NEXT 5 ROWS ONLY

SELECT COUNT(*)
FROM [tests].[Entities] AS [e2]
SELECT COUNT(*)
FROM [tests].[Entities] AS [e2]
SELECT COUNT(*)
FROM [tests].[Entities] AS [e2]
SELECT COUNT(*)
FROM [tests].[Entities] AS [e2]
SELECT COUNT(*)
FROM [tests].[Entities] AS [e2]

but since 1.1.0 the sub-select is not present anymore.
As far as I can tell, every version produces as many SELECT COUNT(*) ... calls as the number of items in the page, which was not expected.
Is calling queryable.Count() not supported by design anymore, is it a bug or there is a different way to specify what I want?
Further technical details
EF Core version: 2.1.4
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2017 15.8.7

A couple of additional issues I found while trying the repro:
If you write the query like this:
var query = db.Set<Entity>();
var pagedQueryable = query.OrderBy(e => e.Id)
                            .Skip(1).Take(5)
                            .Select(e => new
                            {
                                Total = query.ToList().Count(),
                                Item = e
                            });

var page = pagedQueryable.ToList();

Exception:
System.NotSupportedException
  HResult=0x80131515
  Message=Could not parse expression 'value(Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryable`1[Demos.Theme]).ToList()': This overload of the method 'System.Linq.Enumerable.ToList' is currently not supported.
  Source=Remotion.Linq
  StackTrace:
   at Remotion.Linq.Parsing.Structure.MethodCallExpressionParser.GetNodeType(MethodCallExpression expressionToParse)
   at Remotion.Linq.Parsing.Structure.MethodCallExpressionParser.Parse(String associatedIdentifier, IExpressionNode source, IEnumerable`1 arguments, MethodCallExpression expressionToParse)
   at Remotion.Linq.Parsing.Structure.ExpressionTreeParser.ParseMethodCallExpression(MethodCallExpression methodCallExpression, String associatedIdentifier)
   at Remotion.Linq.Parsing.Structure.ExpressionTreeParser.ParseMethodCallExpression(MethodCallExpression methodCallExpression, String associatedIdentifier)
   at Remotion.Linq.Parsing.Structure.QueryParser.GetParsedQuery(Expression expressionTreeRoot)
   at Remotion.Linq.Parsing.ExpressionVisitors.SubQueryFindingExpressionVisitor.Visit(Expression expression)
   at System.Linq.Expressions.ExpressionVisitor.VisitAndConvert[T](ReadOnlyCollection`1 nodes, String callerName)
   at Remotion.Linq.Parsing.RelinqExpressionVisitor.VisitNew(NewExpression expression)
   at System.Linq.Expressions.NewExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.VisitLambda[T](Expression`1 node)
   at System.Linq.Expressions.Expression`1.Accept(ExpressionVisitor visitor)
   at System.Linq.Enumerable.SelectListPartitionIterator`2.ToArray()
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at Remotion.Linq.Parsing.Structure.MethodCallExpressionParser.Parse(String associatedIdentifier, IExpressionNode source, IEnumerable`1 arguments, MethodCallExpression expressionToParse)
   at Remotion.Linq.Parsing.Structure.ExpressionTreeParser.ParseMethodCallExpression(MethodCallExpression methodCallExpression, String associatedIdentifier)
   at Remotion.Linq.Parsing.Structure.QueryParser.GetParsedQuery(Expression expressionTreeRoot)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CompileQueryCore[TResult](Expression query, IQueryModelGenerator queryModelGenerator, IDatabase database, IDiagnosticsLogger`1 logger, Type contextType)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.<>c__DisplayClass13_0`1.<Execute>b__0()
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQueryCore[TFunc](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.Execute[TResult](Expression query)
   at Remotion.Linq.QueryableBase`1.GetEnumerator()
   at System.Collections.Generic.List`1.AddEnumerable(IEnumerable`1 enumerable)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Demos.Program.Main() in C:\Users\divega\source\repos\EFDemos\data-seeding\Program.cs:line 27

If you write a query like this:

var query = db.Set();
var pagedQueryable = query.OrderBy(e => e.Id)
.Skip(1).Take(5)
.Select(e => new
{
Total = query.ToList(), // also repros without the ToList()
Item = e
});
var page = pagedQueryable.ToList();
System.ArgumentNullException
  HResult=0x80004003
  Message=Value cannot be null.
  Source=Microsoft.EntityFrameworkCore
  StackTrace:
   at Microsoft.EntityFrameworkCore.Utilities.Check.NotNull[T](T value, String parameterName)
   at Microsoft.EntityFrameworkCore.Query.QueryCompilationContext.FindEntityType(IQuerySource querySource)
   at Microsoft.EntityFrameworkCore.Query.ExpressionVisitors.RelationalEntityQueryableExpressionVisitor.VisitEntityQueryable(Type elementType)
   at System.Linq.Expressions.ConstantExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at System.Dynamic.Utils.ExpressionVisitorUtils.VisitArguments(ExpressionVisitor visitor, IArgumentProvider nodes)
   at System.Linq.Expressions.ExpressionVisitor.VisitMethodCall(MethodCallExpression node)
   at System.Linq.Expressions.MethodCallExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at System.Linq.Expressions.ExpressionVisitor.VisitAndConvert[T](ReadOnlyCollection`1 nodes, String callerName)
   at Remotion.Linq.Parsing.RelinqExpressionVisitor.VisitNew(NewExpression expression)
   at System.Linq.Expressions.NewExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.Query.EntityQueryModelVisitor.ReplaceClauseReferences(Expression expression, IQuerySource querySource, Boolean inProjection)
   at Microsoft.EntityFrameworkCore.Query.EntityQueryModelVisitor.VisitSelectClause(SelectClause selectClause, QueryModel queryModel)
   at Microsoft.EntityFrameworkCore.Query.RelationalQueryModelVisitor.VisitSelectClause(SelectClause selectClause, QueryModel queryModel)
   at Remotion.Linq.QueryModelVisitorBase.VisitQueryModel(QueryModel queryModel)
   at Microsoft.EntityFrameworkCore.Query.EntityQueryModelVisitor.VisitQueryModel(QueryModel queryModel)
   at Microsoft.EntityFrameworkCore.Query.RelationalQueryModelVisitor.VisitQueryModel(QueryModel queryModel)
   at Microsoft.EntityFrameworkCore.Query.EntityQueryModelVisitor.CreateQueryExecutor[TResult](QueryModel queryModel)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CompileQueryCore[TResult](Expression query, IQueryModelGenerator queryModelGenerator, IDatabase database, IDiagnosticsLogger`1 logger, Type contextType)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.<>c__DisplayClass13_0`1.<Execute>b__0()
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQueryCore[TFunc](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.Execute[TResult](Expression query)
   at Remotion.Linq.QueryableBase`1.GetEnumerator()
   at System.Collections.Generic.List`1.AddEnumerable(IEnumerable`1 enumerable)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Demos.Program.Main() in C:\Users\divega\source\repos\EFDemos\data-seeding\Program.cs:line 27

@BladeWise thanks for reporting this.

but since 1.1.0 the sub-select is not present anymore.

Do you mean that you get the query you want with only 1.0.x? or 1.1.x too?
We will investigate if this is something we can improve. I couldn't find any obvious workaround. Someone else may think of one, but in the meantime, I would recommend you just issue two separate queries to get the total count and the pages.

Only with 1.0.x, since 1.1.x until latest (at least using the latest minor versions) the SQL produced is the same.
I suppose QueryTypes and FromSql are the only reliable workaroundat the moment... ☹

Sorry EF guys if it is annoying.
@BladeWise, it is Window Functions which are currently unsupported by EF.
If you need such queries we have implemented it in our extension for EF.
Just install our package
https://www.nuget.org/packages/linq2db.EntityFrameworkCore
And then rewrite your query in the following way:
var page = query
    .Select(e => new { Total = Sql.Ext.Count().Over().ToValue(), Item = e })
    .Skip(20)
    .Take(5)
    .ToLinqToDB()
    .ToList();

Note, that eager loading (Includes) will not work in this case.

@smitpatel to find dupe for original query with Select.

@divega to file issues for the other two cases.

@sdanyliv Thanks for pointing out your extension, but in my case a sub-query outperforms COUNT(*) OVER() by a huge margin, so I am a bit more interested in th sub-query approach.

I suppose QueryTypes and FromSql are the only reliable workaround at the moment...

@BladeWise I think just issuing two separate queries for the total count and the page is a simpler workaround, but I may be missing something.

@divega It is simpler, but as I said it is not equivalent in terms of reliability and consistency, regarding the fact that data could change between queries.

@BladeWise, sorry, i have lost of discussion point. What do you mean subquery approach? SQl is always SQL and it is the best way to talk with SQL servers.
You have mentioned best solution for your problem (in SQL) and i have proposed this approach.
Usually as an Architect, i will not approve such queries (not this one, which can use statistics even when extra data has been loaded), but there are a lot of cases when people query Count for every complex queries, because of generic “useful” paginators. We should pray for server cores and memory.

@sdanyliv I proposed two SQL solutions, one with COUNT(*) OVER(), the other using a sub-query used to compute the count (which is optimized by SQL Server to be computed once and be replicated over the rows). The latter was my main focus.
Generic paginators, as you define them, are reusable code that can be easily unit-tested and provide a good starting point to implement pagination logic. Of course, when deling with a database data size/indices/statistics matter,  so there are cases where ad-hoc optimization is needed. Nevertheless, the typical usage involves ~50/100 rows, and in such a case I doubt that having one more int/long field per row overcomes the benefits. Again, provided that they are not abused.

@BladeWise, one point, even you have to get only 100 rows, SQL server has to complete query fully, perform all joins, apply predicate to count rows, which is a performance bottleneck if there are millions of records. Enterprise dictates it’s own rules, but usually it is better to get 101 rows and tell to the user that there are some records left and needs scrolling. This rule also applies to pagination - to skip 1000 rows, server has to do that by skipping them, and you may encourage performance lost after each next page. Thanks to modern SQL optimizators, they are trying to do it fast.


Data Distribution

Hi,
Can you explain in few lines the logic of the consistent hashing, data distribution and some clues related to tokens?
Is there a simple logic as we can find in Redis Cluster like HASH_SLOT = CRC16(key) mod 16384 ?
I would like to know if I can test myself if a given key is in the good place but for that, I should understand how Dynomite routes my key.
I know that Dynomite is mooving every day, we are following that with care and test it a lot since several months, it is quite hard to know what tag/version should be tested and what part of the doc/wiki is obsolete or not but we love the product and we'll try our best to contribute in our way.
Max

For consistent hashing, each node has a token that indicate what range of data it should own.
We use murmur for the hashing.
We will come up with a tagging method and I will add this in the FAQ.  For now, just use the master branch and for  the new things, use Dev branch.

We have started to using tags in the latest version. Master branch will usually match the latest tag.


[CLARIFICATION] Chapter 16: An Encoder Decoder Network for Neural Machine Translation

I had a look at this part of the book and read the following sentences:
“Note that the French translations are also used as inputs to the decoder, but shifted back by one step. In other words, the decoder is given as input the word that it should have output at the previous step (regardless of what it actually output).”
The question is, by “shifted back by one step” are you referring to the fact of adding   SOS at the beginning of each sentence?

If no, then I am missing something.

If yes, maybe you can come with some explicit sentence because by adding  SOS  at the beginning of the sentence. I feel that the sentence is shifted forward by one step, i.e., I am saying this because you said you are working on 3rd ed.

This book is the best so far, I read it time to time and enjoy it.
Cheers,
Kasra

Hi @kasrahabib ,
I see your point, thanks for bringing it to my attention. Indeed, the decoder receives sos + the target sentence as input. In my mind, adding sos at the front of the sentence pushes the rest back by one step, but I can see how it's possible to see it differently, from the perspective of the decoder.
I'll clarify this in the 3rd edition, thanks again!


Minimum Go version to support?

The currently supported versions of Go are 1.21 and 1.20.
I assume we want both of these supported by the library as of right now?
(I thought it could be good to open an issue to document how you would like to deal with additions to the language going forward, such as slices.Equal introduced in 1.21)

I suggest targeting the two supported versions going forward in order to allow more people to use the library but still not get stuck in supporting no longer supported versions of the language. This means that we would wait with usage of newly introduced functionality until it is has landed in the previous version. (A delay of half a year or so in general)
This would imply keeping the go module directive as 1.20 for the time being. And only bumping that if required by some new functionality supported in both (at the time) currently supported Go versions.

Well said. I agree.


March 4th update no longer compatible

As of the March 4th update, injecting the cheat DLL into Blush Blush causes this output and a near-instant Unity crash.

and how do we do to make it work again ?

As of the March 4th update, injecting the cheat DLL into Blush Blush causes this output and a near-instant Unity crash.

I've seen your update but the provided, compiled .dll is still the previous verison. I'm so, way far out of my depth on compiling a new one myself (I tried, but I'm running on 15 year old ActionScript knowledge). Any way you could provide a rebuilt .dll as well?
(and thank you for doing this for free, it's really appreciated)


Fetch Python environment from Sleipnir.jl for CI

Right now we are duplicating the environment.yml file in each of the repos for the CI to have access to the Python environment. This is problematic, since any update to the Python environment will have to be extended to the 4 ODINN repositories.
For that, we should update the CI to download (e.g. using wget) the environment.yml file from Sleipnir.jl's GitHub repo.

I managed to sync files across repositories using the repo-file-sync-action with GH Actions. An example of how this work is illustrated in these two toy repositories:

Origin repository. This will be Sleipnir.jl and we will sync the environment.yml
Destiantion repository: Huginn.jl, Muninn.jl, ODINN.jl
After implementing the action and configure the sync file with the details of the repository, the next step is to create a fined-grained token (ideally, using ODINN-SciML as the owner) and add it as a GH secret in the origin repository. After the setup of the GH credentials is done (this has to be updated every 90 days), a Pull Request will be created in the destination repository. We can force the PR to be accepted, but I oppening a PR is actually the best posible workflow for this goal.

What do you think @JordiBolibar ? I can directly implement this in Sleipnir and sync with all the required repositories.

Sounds good! The only annoying things seems the 90 day token renewal, which will require maintenance.

Actually, I think you can manually configure the token to never expire. However, I am not sure about how good of a practice this is. The good news is that the new tokens in GH allow you to have a very fine-tune on the tokens, meaning that we can create a token JUST for sync the repositories we want and JUST with the necessary right to perform the sync action. In this way, we don't need to compromise any security of the repo by creating this token forever. Also, this will be kept secret in GH, so we will be safe. I can move forward with this @JordiBolibar and implement accross repositories.

OK, go for it!


Should ASP.NET Core have its own Roslyn Analyzers?

It occurred to me that the issue reported at https://github.com/dotnet/core/issues/126, where the user incorrectly attempted to use ASP.NET Core logging format string as if it was a string.Format format string (i.e. they expected that logger.LogInformation("{1}{0}", "a", "b"); would log "ba") could be solved by a Roslyn Analyzer: If all placeholders are numbers and they are not ordered, the analyzer would produce a warning.
But I think it doesn't make sense to create an analyzer just for this single issue, so:
Are there other issues that could benefit from having an analyzer (or a code fix)? Is there enough of them so that creating the analyzers would be worth it?

Stop sending me emails
On July 2, 2016, at 16:44, Petr Onderka<EMAIL_ADDRESS>wrote:
It occurred to me that the issue reported at https://github.com/dotnet/core/issues/126, where the user incorrectly attempted to use ASP.NET Core logging format string as if it was a string.Format format string (i.e. they expected that logger.LogInformation("{1}{0}", "a", "b"); would log "ba") could be solved by a Roslyn Analyzer: If all placeholders are numbers and they are not ordered, the analyzer would produce a warning.
But I think it doesn't make sense to create an analyzer just for this single issue, so:
Are there other issues that could benefit from having an analyzer (or a code fix)? Is there enough of them so that creating the analyzers would be worth it?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/aspnet/Home/issues/1629

@Kimberleyrene You'll need to stop following the GitHub repos if you do not want to get notifications.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


TestFlight beta feedback for GitHawk for GitHub

Hi,
Thanks for sending me the TestFlight.
So far it’s good. I didn’t find any bug. I just have some suggestions:

In the settings view I think there is no need for app ID near the version number.

Kindly check the attached image. Why there is an UIActionController with one option?! It will be better if the action triggers when the user click on GitHawk.

Best regards,
Mariam AlJamea.

Hello again,
One more suggestion if you don't mind: I really like how GitBucket implements the time line. I would like to see it on GitHawkApp :)

Hello again,
Today I found an issue. My inbox was one, I used GitHawkApp to reply to the message. It replied successfully but it should remove one from the inbox and display Inbox zero with the awesome animation 🎉 Kindly check the attached image.
Thanks.
Best regards,
Mariam.

Hey @Maryom, you can turn on “read on open” in the settings. That will mark an issue as read once opened. Is that the behavior you’re expecting?
Sent with GitHawk

@rnystrom re the alertcontroller actionsheet in the original post: how do we want to handle this? Just opening it directly also feels weird having the chevron. What do you think?

@rnystrom re the alertcontroller actionsheet in the original post: how do we want to handle this? Just opening it directly also feels weird having the chevron. What do you think?

@BasThomas what about adding it to this alertcontroller 👇🏼 ?

Sent with GitHawk

The tricky thing is that we already use the navigation bar for the exact functionality (opening either the org/user and repo), but from a repo overview itself that only leaves the org/user. Putting that in the ... is also confusing.

Ya I'm not terribly concerned w/ the single-action alert. It's nice that it's consistent w/ the rest of the app, so you expect it.

Well I think it’s better to make on as the default value. What do you think?

I think making "Read On Open" the default value doesn't demonstrate this feature very well. And it's one of the main reasons I use GitHawk. I often check an issue, intend to reply later, and 💨 it's gone forever

Hello,
I noticed that number of messages in the below view 👇🏼is less than the real number of messages

Sent with GitHawk

What about after a refresh?
Sent with GitHawk

What about after a refresh? ...

@BasThomas same issue
Sent with GitHawk

Do you have a screenshot of your actual notifications? I feel like there was an issue where the API doesn’t return historical notifications (stuff prior to using GitHawk).
Sent with GitHawk

It probably wouldn't hurt to start opening separate issues for different pieces of feedback/potential bugs. I'm pretty out of date with GitHawk at the moment but I'm having trouble following this thread 😅

@rnystrom No I don’t have
Sent with GitHawk

+1 @SD10 that’ll help us keep hinges tracked and organized
Sent with GitHawk

Ok I will open new issues if I find new ones 😅 sorry I thought I have to write all my feedback in one issue.
Sent with GitHawk

Closing this as I don't see any clear action points in this issue. :)


Add option to screenshot loot received over a given amount.

Include a box in the screenshot settings where you can enable screenshotting loot over a given amount of gp. This could also be added for untradeables.

Added in #6762


feat: add tipping for stackoverflow profiles

Describe the changes you have made in this PR
Added tipping functionality for StackOverflow
Link this PR to an issue
Closes #1063
Type of change (Remove other not matching type)

feat: New feature (non-breaking change which adds functionality)

How has this been tested?
https://user-images.githubusercontent.com/64399555/175388430-56071da2-567d-485a-b8ef-259897c298bd.mp4
Checklist

[x] My code follows the style guidelines of this project and performed a self-review of my own code
[x] New and existing tests pass locally with my changes
[x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

The question then is: to which user? Are you paying the user who asked the question? Or the one with the solution?

True, I think bumi had the solution-user in mind. WOuld be nice to chose or just send to both?

True, I think bumi had the solution-user in mind.

As currently there is no way to let the user choose from multiple recipients I'd agree with sending to the user who posted the solution. 👍

I'd say we go with the accepted one. Isn't this a bit of an "official" approval?
for the others people could visit the user's profile page.


Errors in traced methods get ignored.

(See: src/client/logging/_trace.ts)
Currently the "trace" decorators call the decorated method and log any errors:

Here's the code.
            try {
                // tslint:disable-next-line:no-invalid-this no-use-before-declare no-unsafe-any
                const result = originalMethod.apply(this, args);
                // If method being wrapped returns a promise then wait for it.
                // tslint:disable-next-line:no-unsafe-any
                if (result && typeof result.then === 'function' && typeof result.catch === 'function') {
                    // tslint:disable-next-line:prefer-type-cast
                    (result as Promise<void>)
                        .then((data) => {
                            writeSuccess(timer.elapsedTime, data);
                            return data;
                        })
                        .catch((ex) => {
                            writeError(timer.elapsedTime, ex);
                        });
                } else {
                    writeSuccess(timer.elapsedTime, result);
                }
                return result;
            } catch (ex) {
                writeError(timer.elapsedTime, ex);
                throw ex;
            }

The problem is that in the Promise case the exception does not get re-thrown like it does in the non-Promise case.  So the error is getting logged but also gets ignored in that case.
The error should be re-thrown and the caller should deal with it.

Closing as stale.


Fix tkinterdnd2 path for Windows

What does this PR do?
Fixes https://github.com/Nuitka/Nuitka/issues/3108.
It appears tkinterdnd2 has changed the windows path name. This small change reflects an updated path name to allow compilation without the FATAL crash (FileNotFoundError).
PR Checklist

[x] Correct base branch selected? Should be develop branch.
[x] Enabled commit hook or executed ./bin/autoformat-nuitka-source.
[ ] All tests still pass. Check the Developer Manual about Running the Tests. There are GitHub
Actions tests that cover the most important things however, and you are welcome to rely on those,
but they might not cover enough.
[ ] Ideally new features or fixed regressions ought to be covered via new tests.
[ ] Ideally new or changed features have documentation updates.

Summary by Sourcery
Fix the path for tkinterdnd2 on Windows to resolve a FileNotFoundError issue, ensuring successful compilation without crashes.
Bug Fixes:

Correct the path for tkinterdnd2 on Windows to prevent a FileNotFoundError during compilation.

I meant to check this one for a while. I was basically stuck on wether there is more than 64 bits to support, and if it's a change and in which version.

So,
I tracked this down to that version as the last to not have the change.
Successfully installed tkinterdnd2-0.3.0
(tkinter-dnd2)
kayha@Neyah MINGW64 ~/test
$ python ~/repos/Py2C/bin/nuitka --list-package-dlls=tkinterdnd2
Nuitka-Tools: Checking package directory 'C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2' ..
C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2\tkdnd\linux64
  libtkdnd2.9.2.so
C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2\tkdnd\osx64
  libtkdnd2.9.2.dylib
C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2\tkdnd\win64
  libtkdnd2.9.2.dll
Nuitka-Tools: Found 3 DLLs.
(tkinter-dnd2)

It seems they added 32 bits support to their wheel, and changed the path, so we need to check the version and the arch for the new version, and provide both paths. That way we support both versions.
kayha@Neyah MINGW64 ~/test
$ python ~/repos/Py2C/bin/nuitka --list-package-dlls=tkinterdnd2
Nuitka-Tools: Checking package directory 'C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2' ..
C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2\tkdnd\linux-arm64
  libtkdnd2.9.3.so
C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2\tkdnd\linux-x64
  libtkdnd2.9.4.so
C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2\tkdnd\osx-arm64
  libtkdnd2.9.3.dylib
C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2\tkdnd\osx-x64
  libtkdnd2.9.4.dylib
C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2\tkdnd\win-arm64
  libtkdnd2.9.3.dll
C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2\tkdnd\win-x64
  libtkdnd2.9.4.dll
C:\Users\kayha\test\tkinter-dnd2\lib\site-packages\tkinterdnd2\tkdnd\win-x86
  libtkdnd2.9.4.dll
Nuitka-Tools: Found 7 DLLs.

It seems also macOS and Linux is subject to it, and there is also ARM to consider while at it.

As a first step, I rebased this on current develop branch.

I think the old tkinterdnd2 code can be replaced with this kind of configuration:
- module-name: 'tkinterdnd2.TkinterDnD' # checksum: ac56a06b
  data-files:
    - dirs:
        - 'tkdnd/win64'
      when: 'use_tkinter and win32 and version("tkinterdnd2") < (0,4)'
    - dirs:
        - 'tkdnd/linux64'
      when: 'use_tkinter and linux and version("tkinterdnd2") < (0,4)'
    - dirs:
        - 'tkdnd/osx64'
      when: 'use_tkinter and macos and version("tkinterdnd2") < (0,4)'
  dlls:
    - from_filenames:
        relative_path: 'tkdnd/win64'
        prefixes:
          - ''
      when: 'use_tkinter and win32 and version("tkinterdnd2") < (0,4)'
    - from_filenames:
        relative_path: 'tkdnd/linux64'
        prefixes:
          - ''
      when: 'use_tkinter and linux and version("tkinterdnd2") < (0,4)'
    - from_filenames:
        relative_path: 'tkdnd/osx64'
        prefixes:
          - ''
      when: 'use_tkinter and macos and version("tkinterdnd2") < (0,4)'

Having manual code expanding those things is considered a bad thing, and we are trying to get away from it, and before we add more code branches, we rather add more configuration cases. It's a bit ugly, that we repeat conditions there, and we could define them as constants or variables, but it think it makes it actually harder to read.

I check with Linux, for old tkinterdnd2 it's the same, now lets support new one.

So, I changed it over to config, it's a bit of a monster, and DLLs and data files being unable to share things makes it a bit ugly, maybe we should consider having cases for the DLL/data file directory instead, as that will be user easy relatively.


Tracking issues for develop PageStore

Overview
The goals of the current milestone:
Set up an initial version runnable PageStore.
Tasks
Scheduled

[x] WriteBuffer module

[x] #34
[x] #40
[x] #42
[x] #41
[x] #46

[x] Version module

[x] #56
[x] #58
[x] #57
[x] #80
[x] #81

[x] PageFile module

[x] #44
[x] #52
[x] #53
[x] #54
[x] #67
[x] #89
[x] #128
[x] #154
[ ] Avoid block file_builder when internal io_buf full
[ ] sync_all folder instead of sync_all new file
[ ] Pool io_buf avoid alloc buffer for each flush or read

[ ] Manifest module

[x] #68
[x] #69
[x] Cleanup when open
[ ] Notify Cleanup job about obsoleted manifest
[x] #153

[x] Flush job

[x] #135
[x] #61
[x] #62
[x] #63

[x] Cleanup job

[x] #101

[x] GC job

[x] #106
[x] #122
[x] #102
[x] #123

[x] Photonio requirement

[x] open file with custom flags(to set O_DIRECT)
[x] let io_uring support ftruncate(2)

[x] PageStore module

[x] #78
[x] #79
[x] #98
[x] #82
[x] #99
[x] #108
[x] #109

Archived

[x] Design public and module API

[x] #7
[x] #12
[x] #13
[x] #6
[x] #8
[x] #26
[x] #27
[x] #17
[x] #28

I think we can close this and start a new development for 0.0.3.


feat: Add multiline comment

Added default multiline comment formatter.
This is an example:
https://github.com/reqable/re-editor/assets/75752751/479dcb12-ba8e-452a-96c3-ecd2bf732cd0

@tizianotedeschi Thanks for submitting the PR. I noticed that there are some configuration file modifications in the example directory. Is it necessary?

@MegatronKing No, they are not needed. I forgot to remove them from the commit


Implement QPInverseKinematics python bindings

This PR implements python bindings for the QPInverseKinematics class, which basically required to:

[x] enhance the KinDynDescriptor class in order to be able to set the state of the kinDyn object (this code will be moved via #293)
[x] implement the bindings for the LinearTask class and the derived tasks (CoMTask, SE3Task, SO3Task, JointTrackingTask)
[x] implement the bindings for the IntegrationBasedIK and the QPInverseKinematics classes

Tests for all the implemented bindings are provided.

I'm going to approve the PR even though I'd like to have another zoom-out pass. Well done @paolo-viceconte!

Feel free to mark as solved addressed comments so we have less clutter in the PR.

I added a few binded functions to the kindyn computations object via 086597a284f7b02adaad14457a49cf6ceb9a4086 and the tests are now failing on macOS but I have no clue of the reason why.
Still, I need to address some open points in the reviews of this PR.

Let's wait for the CI if there are no problems I will merge it

Conda is failing with this error:
https://github.com/dic-iit/bipedal-locomotion-framework/pull/303/checks?check_run_id=3116322815#step:7:321
@traversaro , is it due to https://github.com/conda-forge/manif-feedstock/pull/9 ?

The CI fails also because of #363. I will take care of the modification

The CI fails also because of #364 I will take care of the modification

https://github.com/dic-iit/bipedal-locomotion-framework/pull/303/commits/a8022f17fc5523fa2edadd37a09d3583e5241b70 fixes the problem

The CI fails also because of #364 I will take care of the modification

a8022f1 fixes the problem

thanks @GiulioRomualdi!

https://github.com/conda-forge/manif-feedstock/pull/11 should fix the CI failure

conda-forge/manif-feedstock#11 should fix the CI failure

Merged, it should probably take the usual 1/1.5 hours for CDN to propagate.

The conda CI is passing. The windows one is still failing but it is not related to this PR. I'm currently debugging the issue here: #374
I think it's time to merge the PR.
Thank you all for the effort 🎉


Support for negative values issue #284

start from negative secondaryValue rather than 0 and end at 0 if secondaryValue<0

:tada: This PR is included in version 3.0.0-beta.38 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update README.md

Made the instructions easier to understand, for people who are slow in the head.

Sorry, make it better.

Okay.


proposal: normalize connector properties in protobuf

When creating sources and sinks, we specify properties in the WITH clause which is parsed into a map<string, string>. However, we keep this type-unsafe representation in the catalog and compute node, this can be bad in some ways:

In RPC, we cannot tell which component is responsible for validating some fields. So #7028 could happen.
In persisted catalog, it'll be extremely hard to handle the compatibility for possible API changes. We can only resolve this by the property name, which is not robust as we're even not rejecting unrecognized fields yet.

So here I propose normalizing the connector properties in the protobuf. For those static properties, we can directly persist them in a field. For dynamic properties (like fields.v.kind in the data-gen connector), we can structure them in other ways.
message ConnectorProperties {
  oneof value {
    Kafka kafka = 1;
    Nexmark nexmark = 2;
    Datagen datagen = 3;
    Pubsub pubsub = 4;
  }
}

message Datagen {
  enum Kind {
    SEQUENCE = 1;
    RANDOM = 2;
  }
  message Field {
    Kind kind = 1;
    string start = 2;
    string end = 3;
  }

  uint32 split_num = 1;
  uint32 row_per_sec = 2;
  map<string, Field> fields = 3;
}

Just make sure, the proposal does not involve any user-facing change. The frontend is responsible for encoding the properties into bytes and meta and CN decodes it whenever needed.

Just make sure, the proposal does not involve any user-facing change. The frontend is responsible for encoding the properties into bytes and meta and CN decodes it whenever needed.

Yes. It's only related to the internal implementation to make this more type-safe.

With this refactor, it is still possible to pass through debezium properties via WITH clause for CDC connector? For example, here we set a different value for decimal.handling.mode.
create materialized source orders (
   order_id int,
   order_date timestamp,
   customer_name string,
   price decimal,
   product_id int,
   order_status smallint,
   PRIMARY KEY (order_id)
) with (
 connector = 'mysql-cdc',
 hostname = 'mysql',
 port = '3306',
 username = 'root',
 password = '123456',
 database.name = 'mydb',
 table.name = 'orders',
 server.id = '5086',
 decimal.handling.mode = 'precise'
) row format debezium_json;

With this refactor, is it still possible to pass through debezium properties via WITH clause for CDC connector?

I think so. Is there anything else to be concerned about? 🤔

With this refactor, is it still possible to pass through debezium properties via WITH clause for CDC connector?

I think so. Is there anything else to be concerned about? 🤔

So for these adhoc properties, we can still store them in a map<string, string>, am I right?

So for these adhoc properties, we can still store them in a map<string, string>, am I right?

Yes. I think we can try our best to make it type-safe, and it'll never be worse than a single large map.

As we've started to provide backward compatibility, do we need to consider this issue recently? 👀

Sure, but I am afraid not enough manpower for this.

will do in recent source refactoring

can close as done as normalized by https://github.com/risingwavelabs/risingwave/pull/13227


Multiple eventsObserver outputs in one HTML document causes z-height and other issues

The following yields a shiny app where the second tab does NOT contain the eventsObserveR ring and in the first tab there are z-height issues:
library(shiny)
library(eventsObserveR)

shinyApp(
  ui = navbarPage(
    "eventsObserver",
    tabPanel(
      "one",
      eventsObserverOutput("one")
    ),
    tabPanel(
      "two",
      eventsObserverOutput("two")
    )
  ),
  server = function(input, output){

    output$one <- renderEventsObserver({
      eventsObserveR(events = sample_events_data,
                     place.key = "station")
    })

    output$two <- renderEventsObserver({
      eventsObserveR(events = sample_events_data,
                     place.key = "station")
    })

  }

It will be easier for me to investigate if there is a URL that reproduces the problem.

@ToonTalk here's a simpler example using RMarkdown http://rpubs.com/martinjhnhadley/twoEventsObservers

Thanks. Investigating...
The console shows many errors that probably are a separate issue:

about:blank:1 Mixed Content: The page at 'https://pippio.com/api/sync?pid=1391&ref=http%3A%2F%2Frpubs.com%2Fmartinjhnhadley%2FtwoEventsObservers' was loaded over HTTPS, but requested an insecure resource 'http://lore.circulate.com/rysc?fid=lrttum'. This request has been blocked; the content must be served over HTTPS.
lounge.bundle.c61407ceda8875555b41f987a6a45ee1.js:3 WebSocket connection to 'wss://realtime.services.disqus.com/ws/2/thread/5437810348?' failed: Error in connection establishment: net::ERR_CONNECTION_RESET
open @ lounge.bundle.c61407ceda8875555b41f987a6a45ee1.js:3

When I made a quick test the second event observer instance drew the locations upside down. Probably an artefact of the way I did the testing but double check this.

Did you get a chance to confirm that this fix worked for your examples?

@ToonTalk this does work a treat now - many thanks!


M2 gcs browser empty state

This PR contains changes to show a message in the data grid when there are no items in the current directory or when there's an error while loading the items for the current directory.

I hadn't requested any review yet, I was going to request the review after the previous PR was in.

Because the comments are small I will make the changes and merge in the PR.

Thank you for the preemtive review.


[Issue 85] Fix classLabel bug

This PR fixes the bug where the probability label output is not renamed correctly, causing conversion calls with non-None class_labels to fail.

Merging.


orientationOutput isn't applied in IOS with skia

What's happening?
orientationOutput='landscape-right', in Android, it shows up correctly, but in IOS, it shows up as portrait no matter what option we choose.
Reproduceable Code
W. Skia frame processors

Relevant log output
.

Camera Device
.

Device
iPhone
VisionCamera Version
4.1.0
Can you reproduce this issue in the VisionCamera Example app?
I didn't try (⚠ your issue might get ignored & closed if you don't try this)
Additional information

[ ] I am using Expo
[X] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

When I replace useSkiaFrameProcessor with useFrameProcessor it shows up normally.

Without reproduceable code I cannot reproduce the issue
Without RELEVANT log output I cannot determine what went wrong on the native side when applying orientations
Without knowing the Camera device's sensorOrientation I don't know what the natural orientation is (counter-rotate)

Without reproduceable code I cannot reproduce the issue
Without RELEVANT log output I cannot determine what went wrong on the native side when applying orientations
Without knowing the Camera device's sensorOrientation I don't know what the natural orientation is (counter-rotate)

Have you tried using output orientation with skia on iOS? We don't do anything special, just the very basics and the orientation doesn't work

Please stop spamming.

Update the issue with logs then I can help you.

Update the issue with logs then I can help you.

I can't, my coworker has a MacBook and he's out for surgery until next week, but I'm being pressured to fix this issue until tomorrow.
So I can't provide logs now, but as I said, it seemed like a generic problem:

W. Normal frame processors it showed up normally

W. Skia frame processors it always happens

Has anyone tested IOS + outputRotation + skia?
We only needed the skia rotation fix, but it was released together with the ouputRotation feature which is a breaking change, so we're forced to use it - hence why I'm here

Can you open this issue again? This issue is not resolved, and you are likely to be ignoring a major bug in your library.
For others thinking about donating here, note this behavior before donating. I also donated and that's what I get.

Hey @tomerh2001 I'm sorry but a "major" bug is a bit exaggerated. You can always use a fixed orientation of portrait to keep it locked, that should work fine.
Orientation took a ton of time and effort to build, and even though the sponsor pool wasn't nearly full I decided to implement it in my free time anyways. Instead of only complaining about something not working and it being a "major" bug you could also thank me for building orientation as far as it is right now. Everything's working apart from orientation in Skia.
I will fix this bug soon, but I don't have time now.
Also, don't get me wrong I appreciate your sponsorship, but this is a complex issue and just demanding that I fix it immediately without even providing logs or a clear reproduction is just unfair.
I need to keep the issues clean, and if you refuse to add logs or use a proper title to at least help me organize and debug this better, then it's staying closed.
Please update with logs.

Hey @tomerh2001 I'm sorry but a "major" bug is a bit exaggerated. You can always use a fixed orientation of portrait to keep it locked, that should work fine.
Orientation took a ton of time and effort to build, and even though the sponsor pool wasn't nearly full I decided to implement it in my free time anyways. Instead of only complaining about something not working and it being a "major" bug you could also thank me for building orientation as far as it is right now. Everything's working apart from orientation in Skia.
I will fix this bug soon, but I don't have time now.
Also, don't get me wrong I appreciate your sponsorship, but this is a complex issue and just demanding that I fix it immediately without even providing logs or a clear reproduction is just unfair.
I need to keep the issues clean, and if you refuse to add logs or use a proper title to at least help me organize and debug this better, then it's staying closed.
Please update with logs.

There was a bug with the transformation matrix when using skia, a fix was released which is what I needed - but it was released together with the orientation which isn't fully working (this issue). If you would've released the bug fix first, then the orientation feature in another release, I could've just used the working bug fix version and could've spared this issue.
While I genuinely appreciate this library and its features, choosing to use it seems to just come back and continuously bite me when it comes to time sensitive builds.

While I genuinely appreciate this library and its features, choosing to use it seems to just come back and continuously bite me when it comes to time sensitive builds.

With all due respect - if you think this library is just biting you then don't use it.
I work on it in my free time, and if you need something fixed asap, contact me through my consulting agency to get full enterprise level support and almost instant fixes - billed with an hourly rate for short term fixes.
You can also always add features yourself and submit PRs/contributions here, this is how open-source works.
I am not responsible for your app's/client's deadline. If you/they need to release something sooner, maybe paying me to get it done is quicker than writing it yourself or switching to a different library (I don't think there are any other libraries that support Skia Frame Processors).
With that said; I will maybe focus on this soon in my free time, but I have a lot of other priorities right now.

While I genuinely appreciate this library and its features, choosing to use it seems to just come back and continuously bite me when it comes to time sensitive builds.

With all due respect - if you think this library is just biting you then don't use it.
I work on it in my free time, and if you need something fixed asap, contact me through my consulting agency to get full enterprise level support and almost instant fixes - billed with an hourly rate for short term fixes.
You can also always add features yourself and submit PRs/contributions here, this is how open-source works. I am not responsible for your app's/client's deadline. If you/they need to release something sooner, maybe paying me to get it done is quicker than writing it yourself or switching to a different library (I don't think there are any other libraries that support Skia Frame Processors).
With that said; I will maybe focus on this soon in my free time, but I have a lot of other priorities right now.

Fair enough. I would appreciate if this can be looked at, or at least point me to the possible culprit file/function and i'll try to fix it

See withRotatedFrame: https://github.com/mrousavy/react-native-vision-camera/blob/1723408aa8fee894a39afe312c779e3702ffb2d0/package/src/skia/useSkiaFrameProcessor.ts#L53-L90

This is my outputOrientation:

I noticed my frame.orientation is always portrait. Maybe this obvious info.
But I found that I get my expected behavior if frame.orientation = Camera.outputOrientation, which I wasn't able to force (couldn't find where), so I just copied the rotation from landscape-right (the value I chose for outputOrientation) to portrait (the constant value of my frame.orientation, I.e.:

and also did the same in getSurfaceSize:

This gives me the correct preview on IOS w. Skia.
This is definitely not a solution, but I guess it's at least a direction?
As a temp fix for now i might apply this only to IOS.
Also, can you please reopen this issue now so that others could help as well?

frame.orientation is the Frame buffer's physical orientation relative to the output orientation.
Buffers need to be rotated with transforms/Matrixes, instead of physically rotating the pixels.
So I think orientation is properly computed. I need to double check this, but it is not the same as outputOrientation, by design. That's just how Cameras work. That's why the orientation feature isn't as easy as some people think it is.


Type and fix OCPP error handling.

Signed-off-by: Jérôme Benoit<EMAIL_ADDRESS>

I think there is a tslint setting for that right? :-)

It was enabled but was making the code difficult to read because of the highlights. I think you have removed the setting or asked to remove it.
--
Jérôme Benoit aka fraggle
Piment Noir - https://piment-noir.org
OpenPGP Key ID : 27B535D3
Key fingerprint : B799 BBF6 8EC8 911B B8D7 CDBC C3B1 92C6 27B5 35D3

I think there is a tslint setting for that right? :-)

It was enabled but was making the code difficult to read because of the highlights. I think you have removed the setting or asked to remove it.
--
Jérôme Benoit aka fraggle
Piment Noir - https://piment-noir.org
OpenPGP Key ID : 27B535D3
Key fingerprint : B799 BBF6 8EC8 911B B8D7 CDBC C3B1 92C6 27B5 35D3

It was enabled but was making the code difficult to read because of the highlights. I think you have removed the setting or asked to remove it.

Ok but I don't think this was for the visibility. You can put it back :-).

It was enabled but was making the code difficult to read because of the highlights. I think you have removed the setting or asked to remove it.

Ok but I don't think this was for the visibility. You can put it back :-).


Redirect to index.html on reload

If an error occurs, or the page have to be reloaded, you will see the default spring boot "whitelabel erro page". Instead, it should be possible to redirect to "index.html".

wrong redirect to **/index.html instead of /index.html


[Feature] Enable variables in the text area of LLM_content inputs

Enable variables in the text area of LLM_content inputs. Currently this could be done by just detecting {{ text }} in the text areas and autocreating a Input port. Eventually we could have a tool in the Insert area that inserts a variable or wraps it around highlighted text.

This one is going to be challenging, but very exciting. Challenges:

[ ] We don't currently have a way to building graphs that have dynamic inputs (this is needed to auto-create an input
[ ] We don't currently have support for placeholder chiclets in the text editor.


Rainlab Translation for OC V3.

Hi,
plugins\blakejones\magicforms\classes\BackendHelpers.php
public static function isTranslatePlugin() :bool {         return class_exists('\RainLab\Translate\Classes\Translator') && class_exists('\RainLab\Translate\Models\Message') && class_exists('\RainLab\Translate\Models\Locale');     }
RainLab\Translate\Models\Locale
That model doesn't exist in RainLab Translate v2.1.3, which cause Magic Form to be untranslatable.

Basically,
I removed the class_exists('\RainLab\Translate\Models\Locale')
plugins\blakejones\magicforms\classes\BackendHelpers.php
public static function isTranslatePlugin() :bool {         return class_exists('\RainLab\Translate\Classes\Translator') && class_exists('\RainLab\Translate\Models\Message');     }
and comment out this :
// LOAD TRANSLATOR PLUGIN
        // if (BackendHelpers::isTranslatePlugin()) {
        //     \Log::info('ici');
        //     $translator = \RainLab\Translate\Classes\Translator::instance();
        //     $translator->loadLocaleFromSession();
        //     $locale = $translator->getLocale();
        //     \RainLab\Translate\Models\Message::setContext($locale);
        // }

in the file plugins\blakejones\magicforms\classes\MagicForm.php
now it seems to work.

Hello,
It´s true, now there is no option to translate message of MagicForms.
Any fix?
Kind Regard´s

same here, translation doesn't work
@blakej115  any ideas on when may have a chance to fix ?

Aany updates on this issue?

Pull request #18 has been merged in. I apologize for the delay.
Thanks!

@blakej115 Thank you! i will update and test it! :)

@az-vm For testing purposes, you can try and change the code to exactly what @apinard suggested.
On line 33 of /plugins/blakejones/magicforms/classes/BackendHelpers.php, change the code from this:
return class_exists('\RainLab\Translate\Classes\Translator') && class_exists('\RainLab\Translate\Models\Message') && class_exists('\RainLab\Translate\Classes\Locale');

Change to:
return class_exists('\RainLab\Translate\Classes\Translator') && class_exists('\RainLab\Translate\Models\Message');

See if that fixes your issue. I don't think it will, because the \RainLab\Translate\Classes\Locale should exist. If making this change doesn't fix your issue, then you are having some other kind of issue, because this change makes your code identical to what @apinard suggested.
Please let me know the result.
Thanks!

I have try to change the line, and got same result as the fix of @apinard
to show on the translation messages the word to be translated, i have to go to he page of the form, and hit the form to show to "word" and then on on "Scan for messages" the word will show to be translated.

Hello @blakej115
Ok! I will try to explain me better.
When we add some text like this:

And when we go here:

The message "text" does not show with scan and clean caches, etc..... like normal use case.
We need to go to the form in the frontend, hit the form, so then the message "text" can show up to be translated.
This as a behavior, exactly the same as the fix provided by @apinard
Hope you understand it now, or i can send you a capture video.


The ExecuteCallback rest parameter should be a readonly array

Search terms
No response
Component
No response
Playground link
No response
Sample code
No response
Bug description
The current ExecuteCallback definition might mislead developers into thinking that the array can be changed (e.g., by appending new arguments), but this is not the case. The provided array is actually a sliced version of the original. The original cannot be mutated, since it's being used in the parsing loop.
Relevant logs
No response

I think that we can leave the parameter as-is, and instead document that changing it inside the callback has no effect on the original arguments.


Update changelog

It looks like that the changelog is not up to date. Can you update it to reflect the latest changes?

Hey, I've synced the changelog file.


Add spaceship operator to "op"

This adds the missing spaceship operator to the op file.
Can be useful in combination with sorted.
Feel free to change the name, I wasn't sure what to abbreviate it to.

Hey, just got back from vacation. I'll review your PRs this weekend. Thanks!

@tominventisbe could you please add a small test.
Re the name let's call it "spaceship". Saving a couple of characters isn't worth the confusion. While the majority of developers will know what "gt" or "ge" is, I don't think it will be that easy with "spcshp". I made the same mistake with the identity function calling it "idnt". Going to fix it in the next update.

Done!


⚠ Bofrost.at has degraded performance

In 1940b0f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1264 ms

Resolved: Bofrost.at performance has improved in c89704b after 9 minutes.


de: bugfixes: shortened descriptions so that they fit in the available space, fixed color tags

removed newlines or shortened some descriptions that did not fit in the available space in the settings menu, fixed color tags.

Thank you! Merging in!


True charge array

Commits to update compatibility with cta-observatory/pyhessio@63ec30b67e805ade7f9e0b073a24bfc2fe12506f, and is therefore stored directly into event.mc.tel[#].photo_electrons as a numpy array.
@tino-michael I understand this changes the implementation you created for photo_electrons. I figured it might make more sense to have it accessed in a similar way to event.dl0.tel[#].adc_samples. Let me know if you have issue with this.

Otherwise this looks ok, and I'll merge it once you make the small change mentioned aboce.  Of course, we need to have a review of the data container structures soon - now that we process a single telescope at a time, it may not longer be necessary to have the two-level structures where we have dicts of telescopes. That would clean this up a lot.

Also, avoid for-loops over pixels

my bad... I just quickly added this to get a feeling for the event. If there is no general interest in the total number of PE, this figure can also go completely...


Update yarn.lock

Sorry, but I do not understand the intent of this change and the code looks invalid. This merely appends the word "gnishu" to a hash.


Create DL3 files with pyirf and gammapy

This pull request includes additional scripts to create the IRFs and DL3 files with pyirf and gammapy. In addition, the already-existing scripts will be updated as following the requests from pyirf.

Thank you Gabriel for your reviews and I implemented your comments. If there are any further comments, I will merge this branch to the master by the end of this month. It would be great if you could post your comments by then.


Allow use of the originating protocol in the cookie bounce feature.

Commit adds a new configuration parameter (forwardedProtocolHeader) in the
cookie bounce feature. This parameter specifies the name of an http header
that contains the originating protocol if deployed behind a load balancer.
This is useful if SSL termination happens at the load balancer in order to
maintain the security model of you web page.
Fixes #3505

@rbolkey has signed the Software Grant and Corporate Contributor License Agreement. Thanks so much

Thanks @BenFradet. I've applied the recommended changes. Let me know if I missed anything.

@BenFradet fixed the example config, and rebased.


Share analytics on register

https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/78a58a00-48af-4c16-afd8-a27b28abaea6

It should be more of a checkbox - default selected.
Subtext with the checkbox "You can always change this from App Settings"
Need a place in settings to do this. Inside App Access

What's the current status of this issue?


[Feature]: Verify all child resources of an App are eventually deleted when the related CFApp is deleted

Blockers/Dependencies
Related to https://github.com/cloudfoundry/cf-k8s-controllers/issues/334.
Background
As an App Developer
I want all child resources (CFBuild, CFProcess, env var Secret, CFPackage, EiriniLRP, kpack Image, kpack Build, StatefulSet, etc.) cleaned up upon CFApp deletion
So that I don't pollute my cluster when an App is deleted
Acceptance Criteria
GIVEN I have an App running on the cluster with all of the aforementioned child resources
WHEN I delete the CFApp resource
THEN I see that all of the child resources are eventually cleaned up
Dev Notes

Make sure we've got some form of test that covers this!
This story likely consists of ensuring that we've got OwnerRefs properly applied to everything so that they're owned by an App or one of its children.
We could also potentially leverage finalizers on the CFApp to delete anything that doesn't cleanly map to the OwnerRef model
We already have a finalizer to remove destinations from CFRoutes.
We think that the creator of the CR should set the ownerRef:

CFBuild: api shim
CFProcess: app controller
env vars secret: api shim
CFPackage: api shim
EiriniLRP: process controller
kpack image: cfbuild contoller
kpack build: kpack should handle this (test manually)
StatefulSet: Eirini should handle this (again, test manually)

Manual test results:
env vars secret: already has owner ref, manual tests show that it works.
kpack image: already has owner ref. to CFBuild. Manually deleting cfbuild cleans it up.
kpack build: already has owner ref. to Image. Manually deleting cfbuild cleans it up.
LRP: has ownerref to CFProcess. deleted correctly when CFProcess is deleted.
StatefulSet: ownerRef to LRP. Deleted when CFProcess is deleted.
CFProcess: ownerRef is missing (deleting app leaves it behind)
CFBuild: ownerRef is missing
CFPackage: ownerRef is missing


Update README.md

Fix some typos in the README file

This guy is a hacker. Wouldn't recommend approving his workflow. See https://github.com/hashgraph/hedera-mirror-node/pull/8028/files

Assumed so and was just waiting for the force push that we won't run to confirm. Closing with additional evidence.


Problems using checkpoint

Hi, sorry for the disturbance
I am a new uni student and I'm working in a class of image processing and I am doing a task of denoising OCT images. I found this repository and want to try it on my images but I am having some difficulties (noob difficulties probably). Is there anyway you could guide me how to use the pre-trained model on my images?
I thank you in advance.
Take care

Hi!
So the best starting point would be the src/retouch_denoising.py script since it has the general workflow of properly loading the trained model and performing the pre-processing steps. However you would have to adjust it since it takes in a whole OCT volume in the mhd format. You would have change line 63 of the script to instead load your image via for example opencv (which is already used in the script).


refactor(all): Prevent merge conflicts in the future

Can add more in the future
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Closing in favor of split up PRs


Demo tooltip behavior is buggy

When hovering the mouse over the Position -> Top Left element on the Tooltip page, the tooltip appears and hides in a loop.

Another JavaFX bug, I suppose. There is nothing specific in code sample. Did some tests, I see exactly the same behavior with default Modena theme.
public class Launcher extends Application {

    public static void main(String[] args) {
        launch();
    }

    @Override
    public void start(Stage stage) {
        var tooltip = new Tooltip("Test");
        tooltip.setAnchorLocation(PopupWindow.AnchorLocation.WINDOW_BOTTOM_RIGHT);

        var label = new Label("Hover Me");
        label.setTooltip(tooltip);
        label.setStyle("-fx-font-size: 5em;");

        var root = new StackPane();
        root.setAlignment(Pos.CENTER);
        root.getChildren().setAll(label);

        var scene = new Scene(root, 800, 600);
        stage.setScene(scene);
        stage.show();
    }
}

Is there way in the demo application to disable all themes, i.e. to use the default JavaFX theme to easier test this?

No, because Modena uses it's own color system (looked-up color variables) and built on different UI/UX concepts. I don't think I could make it look decent with default UA stylesheet.


updates python to v3.11

newer python is very fast relative to 3.10.
we're fast-forwarding our versions to python's most up-to-date version to get those speed increases.
Signed-off-by: James Kunstle<EMAIL_ADDRESS>

@cdolfi okay that's fine, do you mean to say 3.11 or 3.10?

@cdolfi 3.11 isn't stable w/ Pipenv so let's merge 3.10 and work on 3.11 later when it's more mature.


Update sbt-ci-release to 1.5.6

Updates com.geirsson:sbt-ci-release from 1.5.0 to 1.5.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.geirsson", artifactId = "sbt-ci-release" } ]

labels: sbt-plugin-update, semver-patch

Superseded by #112.


Implement Issue 1125 Show OEM Logo Lockscreen

Fixes #1125
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Smoke testing was performed against the develop branch of core on an ubuntu VM
Summary
Change the default value of showDeviceLogo in the LockscreenConfig from false to true to match iOS
CLA

[X] I have signed the CLA

Codecov Report

Merging #1130 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             develop    #1130      +/-   ##
=============================================
+ Coverage      46.89%   46.92%   +0.03%
+ Complexity      4048     4047       -1
=============================================
  Files            457      457
  Lines          22286    22286
  Branches        2522     2522
=============================================
+ Hits           10450    10458       +8
+ Misses         11223    11212      -11
- Partials         613      616       +3

Impacted Files
Coverage Δ
Complexity Δ

...vicelink/managers/lockscreen/LockScreenConfig.java
100% <100%> (ø)
11 <0> (ø)
:arrow_down:

...icelink/managers/lockscreen/LockScreenManager.java
32.43% <0%> (ø)
5% <0%> (-1%)
:arrow_down:

...smartdevicelink/encoder/VirtualDisplayEncoder.java
28.97% <0%> (+4.54%)
8% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b3ba4...3a56f3b. Read the comment docs.


Repository settings

Naming policy, digest algorithm and filelists for rpm repository are configured on storage level. We need to accept these settings in RpmUpload and use them to create Rpm accordingly.

@0crat assign me

@0crat assign me (here)

@olenagerasimova The job #275 assigned to @olenagerasimova/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

There is an unrecoverable failure on my side. Please, submit it here:
PID: 4@592e6706-44da-4634-a6e2-8ab630bff16f, thread: PQ-CT2E6TK9B
com.jcabi.xml.StrictXML[124] java.lang.IllegalArgumentException: 2 error(s) in XML document: -1:-1: cvc-pattern-valid: Value 'gh:Week 26' is not facet-valid with respect to pattern '[a-z]{2}:[A-Z0-9a-z.\-#/]+' for type 'milestoneID'.;-1:-1: cvc-complex-type.2.2: Element 'successor' must have no element [children], and the value must be valid.

0.53.15: CID: 92ffd047-a48d-4ac4-ae21-5ae21bfc7b76, Type: "Job milestoned"

@olenagerasimova 2 puzzles #281, #282 are still not solved.

#276 merged

@olenagerasimova 4 puzzles #281, #282, #286, #287 are still not solved.

@olenagerasimova 3 puzzles #282, #286, #287 are still not solved; solved: #281.

@olenagerasimova 2 puzzles #282, #287 are still not solved; solved: #281, #286.

@olenagerasimova the puzzle #282 is still not solved; solved: #281, #286, #287.

@olenagerasimova all 4 puzzles are solved here: #281, #282, #286, #287.


Metadata error when parent class is marked with [GlobalMethods]

Bridge generates metadata containing an error for classes nested in a [GlobalMethods] class. This error prevents usage of metadata for a lot of Retyped entities, because it's pretty common for Retyped to generate a top level entity marked with [GlobalMethods] attribute.
For the sample below the following metadata string is generated:
var $m = Bridge.setMetadata,
$n = [];
$m("Test", function () { return {"td":,"att":1048578,"a":2,"m":[{"a":2,"isSynthetic":true,"n":".ctor","t":1,"sn":"ctor"}]}; });

The error is in td property, which doesn't have any value:
"td":,

Steps To Reproduce
https://deck.net/a197fc5861aedbaccb49037cfcfd63ca
[Reflectable]
[GlobalMethods]
public static class Global
{
    public class Test
    {
    }
}

Expected Result
No error.
Actual Result
Console output:
System.Exception: SyntaxError: Unexpected token ,

The fix was just merged upstream! Will be available next Bridge release (see milestone).


UI for wishlists

As a Administrator
I need a UI for wishlists
So that deal with my wishlists more intuitively.
Details and Assumptions

A UI to interact with
Input box to input info
Buttons to submit requests of CRUD/List/Copy wishlists
Output box to show response info

Acceptance Criteria
Given a UI
When I submit a request using input box and buttons
Then I will get response showing in the output box

I am not sure how to design the UI, so it will be fine if the actual UI is not entirely consistent with the user story.


Compare sorted tags in test_save_all

Summary
qiskit-experiments does not maintain order on experiment
tags since [1] so we need to compare experiment tags in
the test_save_all test with a predictable sort order.
[1] https://github.com/Qiskit/qiskit-experiments/pull/522
Details and comments
Closes #210

Before this change:
$ LOG_LEVEL=INFO python -m unittest -v test.ibm.experiment.test_experiment_data_integration.TestExperimentDataIntegration.test_save_all
test_save_all (test.ibm.experiment.test_experiment_data_integration.TestExperimentDataIntegration)
Test saving all. ... You can view the experiment online at https://quantum-computing.ibm.com/experiments/772d71d1-5482-4b37-8ed7-492a5c46f144
You can view the experiment online at https://quantum-computing.ibm.com/experiments/772d71d1-5482-4b37-8ed7-492a5c46f144
FAIL

======================================================================
FAIL: test_save_all (test.ibm.experiment.test_experiment_data_integration.TestExperimentDataIntegration)
Test saving all.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/osboxes/ibmq/qiskit-ibm/test/ibm/experiment/test_experiment_data_integration.py", line 313, in test_save_all
    self.assertEqual(["foo", "bar"], rexp.tags)
AssertionError: Lists differ: ['foo', 'bar'] != ['bar', 'foo']

First differing element 0:
'foo'
'bar'

- ['foo', 'bar']
+ ['bar', 'foo']

----------------------------------------------------------------------
Ran 1 test in 9.308s

FAILED (failures=1)

After this change:
$ LOG_LEVEL=INFO python -m unittest -v test.ibm.experiment.test_experiment_data_integration.TestExperimentDataIntegration.test_save_all
test_save_all (test.ibm.experiment.test_experiment_data_integration.TestExperimentDataIntegration)
Test saving all. ... You can view the experiment online at https://quantum-computing.ibm.com/experiments/3a862d54-4ecf-4e63-aa9a-dd07980e1d9a
You can view the experiment online at https://quantum-computing.ibm.com/experiments/3a862d54-4ecf-4e63-aa9a-dd07980e1d9a
You can view the experiment online at https://quantum-computing.ibm.com/experiments/3a862d54-4ecf-4e63-aa9a-dd07980e1d9a
ok

----------------------------------------------------------------------
Ran 1 test in 10.437s

OK


ENH: Upgrade CI for ITK 5.4.0

Upgrade CI testing to use the latest ITK 5.4.0 version and CI configuration.
Committed via https://github.com/asottile/all-repos

Superceded by #40


Modifications for Gui

Made some modifications to allow the code to work more cleanly with the Spectralyze gui.

Based on the changes, it looks as though the updated code might still work in the single-spectrum interactive mode, therefore I will merge this pull request.  If there are problems, it should be possible to add a flag to handle the two cases (single-spectrum mode vs. gui-handled multislit mode).