refs.form.getValue() should return auto-complete values

tcomb-form requires a change event to update its value. Browsers performing an autofill do not always dispatch the change event. The result is a Struct with incomplete or missing property values.
The solutions I'm aware of:

Get the values from the DOM on "submit" or at regular intervals with something like this.refs[field].getDOMNode().value.
Disable autocomplete on the form using autocomplete="off".

Related links:

https://github.com/facebook/react/issues/1159 (browser-autocompleted form values on controlled components)
https://github.com/facebook/react/issues/2125 (onChange handler not triggered by Safari's auto fill)
https://github.com/tbosch/autofill-event (jQuery/Angular Autofill event polyfill)

Hi!
Thanks for the heads up (great issue, very informative)
It seems a common issue https://github.com/insin/newforms/issues/77

Disable autocomplete on the form using autocomplete="off"

This is easy: https://github.com/gcanti/tcomb-form/issues/95#issuecomment-89546325
just add autocomplete="off" to your form tag.

Another option could be setting the id attributes and read the values later, e.g. in componentDidMount:
var React = require('react');
var t = require('tcomb-form');

window.React = React;

var Form = t.form.Form;

var Type = t.struct({
  username: t.Str,
  password: t.Str
});

var options = {
  fields: {
    username: {
      id: 'username'
    },
    password: {
      id: 'password',
      type: 'password'
    }
  }
};

var App = React.createClass({

  getInitialState: function () {
    return {};
  },

  onChange: function (value) {
    this.setState({value: value});
  },

  componentDidMount: function () {
    var username = document.getElementByIs('username').value.trim() || null;
    var password = document.getElementByIs('password').value.trim() || null;
    this.setState({
      value: {
        username: username,
        password: password
      }
    });
  },

  save: function () {
    var value = this.refs.form.getValue();
    if (value) {
      console.log(value);
    }
  },

  render: function() {
    return (
      <div>
        <Form ref="form"
          type={Type}
          options={options}
          onChange={this.onChange}
          value={this.state.value}
        />
        <button className="btn btn-primary" onClick={this.save}>Save</button>
      </div>
    );
  }

});

React.render(<App />, document.getElementById('app'));

To anyone who stuck with is: @gcanti example will work but for some cases won't, without additional changes. Thing is, ios safary have an option to autofill whenever it or user want (with special button in interface), and componentDidMount hack won't work in this case. You should call code that is inside componentDidMount() before this.refs.form.getValue() also, and make sure that this.refs.form.getValue() is called after the state is set, i.e. in setState() callback.


Cannot use background-image CSS property.

Description
I wrote this code.
<Box
      backgroundImage={'url(/topImage.jpg)'}
      width={'100%'}
      height={'300px'}
      backgroundSize={'cover'}
    >
      <div ref={ref}>
      </div>
    </Box>

But, background-image was not generated. Console has no error.

Environment
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Fixed in #371


feat(request): Added OAuth 2 support for requests

affects: tessellate-request
Some endpoints, e.g. content service, might be protected with OAuth 2. This commit adds support for
configurable OAuth 2, so that different endpoints may use different OAuth 2 credentials.
40

Changes Unknown when pulling 12f6b0369b6d01d763e82446531b4ea0d5e06e0c on 40-tessellate-request into ** on master**.

Changes Unknown when pulling dbeec8f582db5c3360c2e5195821ff031e88ebc4 on 40-tessellate-request into ** on master**.

We should use https://github.com/zalando-incubator/node-tokens for the file credentials based tokens so we don't need to create a new token on every request.

@semonte node-tokens looks good, I created another issue here #44.


"dist" directory referenced in readme does not exist

The dist folder (https://github.com/wiredjs/wired-elements/tree/master/packages/all/dist) referenced in the readme no longer exists.
In a related issue, the sandbox set up by psshihn no longer works, for this same reason: https://codesandbox.io/s/p77jkn13nq?file=/index.html
If I edit the async script's src to "https://unpkg.com/wired-elements@latest", the sandbox then works.
Just FYI, thanks for this interesting and imaginative collection :-)

Sorry I have updated the sandbox and other links.
And sorry for being so slow at dealing with these issues


torch-mesh-isect is not compatible with your environment.yml

Thank you for publishing this code. It is quite intriguing! Unfortunately, torch-mesh-isect does not work with the environment.yml you have published. I presume it because of an incompatibility with CUDA versions greater than 9. I am unable to compile and install it with CUDA 10.2, and it would appear to be an issue for all v10 installations.
Is it possible to eliminate or workaround the torch-mesh-isect dependency? Perhaps use a similar (but more up-to-date) library?

Hi, thank you for your kind words! I also encountered problems while I tried to install torch-mesh-isect for the first time (CUDA 10.2). And I found almost all of the solutions in https://github.com/vchoutas/torch-mesh-isect/issues/23. Hope that could help you with the installation. And I can see there are also users have successfully made it run with quite new CUDA version https://github.com/vchoutas/torch-mesh-isect/issues/27. So I guess it would not be a big problem.
In this project, we use torch-mesh-isect as a part of post-processing to remove artifacts produced during registration to SMPL with offsets. You can simply work around this library by skipping the smoothing step in the post-processing https://github.com/MoyGcc/hpcwild/blob/main/registration/smoothing.py. As a trade-off, you might need to increase the weight for Laplacian loss to avoid possible non-smoothness of the surface which will lead to a bit less-detailed result.https://github.com/MoyGcc/hpcwild/blob/dea76d731cf108e77e1e3625fc42a1f444874569/registration/smpl_registration/fit_SMPLD.py#L47
Feel free to ask follow-up questions if you meet other issues.


Cannot import CSS from node_modules using "~" pattern

Describe the bug
@import '~npm_package/path/file.scss';

// styles here

Throws error:
Error: Can't find stylesheet to import.
This seems related to #291 . But the problem here is when a ~ is prefixed.
System Info

required vite version: 0.20.7
required Operating System: OSX
required Node version: 12.11.0

Logs (Optional if provided reproduction)
Error: Can't find stylesheet to import.
  ╷
1 │ @import<EMAIL_ADDRESS>  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  ../js/ts-packages/radiant-react/widgets/alert/muted/muted-alert.scss 1:9  root stylesheet
    at Object._newRenderError (/Users/ashish.shubham/thoughtspot/blink-v2/node_modules/sass/sass.dart.js:14477:19)
    at Object._wrapException (/Users/ashish.shubham/thoughtspot/blink-v2/node_modules/sass/sass.dart.js:14324:16)
    at StaticClosure._renderSync (/Users/ashish.shubham/thoughtspot/blink-v2/node_modules/sass/sass.dart.js:14299:18)
    at Object.Primitives_applyFunction (/Users/ashish.shubham/thoughtspot/blink-v2/node_modules/sass/sass.dart

What should ~ or @ refer to? I don't think this works without a defined alias.

@MarvinRudolph Updated the description to make it clearer, basically ~ resolves with node_module resolution algorithm to find the nearest package.

Unsubscribe

On 11-Jun-2020, at 4:55 AM, Ashish Shubham<EMAIL_ADDRESS>wrote:
Do NOT ignore this template or your issue will have a very high chance to be closed without comment.
Describe the bug
@import<EMAIL_ADDRESS>// styles here
Throws error:
Error: Can't find stylesheet to import.
This seems related to #291 . But the problem here is when a ~ is prefixed.
System Info
required vite version: 0.20.7
required Operating System: OSX
required Node version: 12.11.0
Logs (Optional if provided reproduction)
Error: Can't find stylesheet to import.
╷
1 │ @import<EMAIL_ADDRESS>│         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
../js/ts-packages/radiant-react/widgets/alert/muted/muted-alert.scss 1:9  root stylesheet
at Object._newRenderError (/Users/ashish.shubham/thoughtspot/blink-v2/node_modules/sass/sass.dart.js:14477:19)
at Object._wrapException (/Users/ashish.shubham/thoughtspot/blink-v2/node_modules/sass/sass.dart.js:14324:16)
at StaticClosure._renderSync (/Users/ashish.shubham/thoughtspot/blink-v2/node_modules/sass/sass.dart.js:14299:18)
at Object.Primitives_applyFunction (/Users/ashish.shubham/thoughtspot/blink-v2/node_modules/sass/sass.dart
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@AXWELL911 please unwatch this repo, don’t spam everyone with unsubscribe emails.

~ is a convention alias configured in vue-cli. There’s no such thing in Vite.

Hi, You can use @modules/npm_package_name.

I found this issue as I made the same mistake. In vite it is simply @import 'npm_package/path/file.scss' without any extra prefix like ~.

I found this issue as I made the same mistake. In vite it is simply @import 'npm_package/path/file.scss' without any extra prefix like ~.

Is there a way to set it up so that it continues to work with vue-cli but also works with vite?
I tried adding an alias in vite.config.js but no luck so far

Is there a way to set it up so that it continues to work with vue-cli but also works with vite?
I tried adding an alias in vite.config.js but no luck so far

It would be nice to have a way to configure this in vite to make migration from vue-cli projects easier.

Add this config to vite.config.js
alias: [
        {
          find: /^~.+/,
          replacement: (val) => {
            return val.replace(/^~/, "");
          },
        },
      ],

@xiaobebe alias's replacement takes string rather than function. therefore it occurs type error.

I use the following config for an Electron Project I use. It seems to work perfectly:

@/components/Loading resolve to my src/renderer/components/Loading
~bootstrap resolves to node_modules/bootstrap
~@blueprintjs to node_modules/@blueprintjs`

  resolve: {
    alias: [
      {
        find: /~(.+)/,
        replacement: join(process.cwd(), 'node_modules/$1'),
      },

      {
        find: /@\//,
        replacement: join(process.cwd(), './src/renderer') + '/',
      },
    ],
  },


Objects from Fluentd in S3 contain corruption

Describe the bug
We receive roughly 2 billion logs through our Fluentd every 24h, which are routed to Elasticsearch and also to S3 buckets.
Within the S3 plugin we have a timekey of 30s, which results in roughly 250-300k JSON objects created every 24h in our S3 buckets. Between 100-200 of these contain some sort of corruption within the object in s3 - usually non UTF-8 characters where they shouldn't be, missing characters, or jumbled strings.
To Reproduce
We have been unable to manually reproduce this on demand using fluent-cat to ingest a log which ended up with corruption in S3.
We are happy to provide more examples if required.
Expected behavior
The logs within the JSON objects in S3 contain no corruption or non UTF-8 characters.
Your Environment
- Fluentd version: 1.15.2
- Operating system: Ubuntu 20.04.2 LTS
- Kernel version: 5.8.0-1038-aws

Your Configuration
<match {logdocument.{{ team }}.dedicated.fluentd,{{ team }}.dedicated.filebeat,{{ team }}.dedicated.functionbeat,logdocument.{{ team }}.dedicated.fluentd_gcp}>
  @type copy
  @log_level info
  <store>
    @type elasticsearch
    reconnect_on_error true
    reload_on_failure true
    reload_connections false
    max_retry_putting_template 1
    request_timeout 60s
    fail_on_putting_template_retry_exceed false
    slow_flush_log_threshold {{ fluentd_slow_flush_log_threshold }}
    @id        out_es_logs-{{ team }}
    @log_level info
    log_es_400_reason true

    id_key      _hash
    remove_keys _hash

    hosts {{ elasticsearch_url }}{{ '' }}
    user "{{ es_username }}"
    password "{{ es_password[buildenv] }}"
    ca_file "{{ fluentd_conf_dir }}/{{ca_crt}}"
    ssl_version TLSv1_2
    ssl_verify false

    index_name               logs-${sky.top_tenant}-fluentd
    time_key                 time
    include_timestamp        true
    include_tag_key          true
    flatten_hashes           false
    flatten_hashes_separator _

    # Rollover index config
    rollover_index     true
    application_name   default
    index_date_pattern "now/d"
    deflector_alias    logs-${sky.top_tenant}-fluentd

    # Index template
    template_name      logs-${sky.top_tenant}-fluentd
    template_file      {{ fluentd_conf_dir }}/logs-template.json
    customize_template {"<<TAG>>":"${sky.top_tenant}"}
    template_overwrite true

    <buffer tag,sky.top_tenant>
      retry_wait {{fluentd_retry_wait | default('60')}}
      retry_exponential_backoff_base {{fluentd_retry_exponential_backoff_base | default('2')}}
      retry_type {{fluentd_retry_type | default('exponential_backoff')}}
      retry_max_interval {{fluentd_retry_max_interval | default('900')}}
      disable_chunk_backup {{fluentd_disable_chunk_backup | lower | default('true')}}
      @type file
      path {{ fluentd_data_dir }}/es-out-logs-{{ team }}

      flush_thread_count {{ fluentd_flush_thread_count }}
      flush_interval     {{fluentd_flush_interval | default('60s')}}
      flush_at_shutdown  {{fluentd_flush_at_shutdown  | lower  | default('true')}}
      overflow_action block
      chunk_limit_size {{ fluentd_chunk_limit_size }}
      # total_limit_size is set 70% of the data disk do that 1 single out can't use more than this
      total_limit_size   {{ (ansible_mounts | json_query('[?mount == `/fluentd`].size_total | [0]') * 0.7 / 1024|pow(3))  | round | int | abs }}G
      retry_forever      false
    </buffer>
  </store>
  <store ignore_error>
    @type s3
    @log_level info
    s3_bucket "{{ logstash_s3_output[buildenv].bucket }}"
    s3_region "{{ logstash_s3_output[buildenv].bucket_region }}"
    acl bucket-owner-full-control
    store_as "json"
    <format>
      @type json
    </format>
    use_server_side_encryption "{{ logstash_s3_output[buildenv].bucket_server_encryption }}"
    path ${sky.top_tenant}/${service.name}/%Y/%m/%d/
    # if you want to use ${tag} or %Y/%m/%d/ like syntax in path / s3_object_key_format,
    # need to specify tag for ${tag} and time for %Y/%m/%d in <buffer> argument.
    <buffer service.name,sky.top_tenant,time>
      retry_wait {{fluentd_retry_wait | default('60')}}
      retry_exponential_backoff_base {{fluentd_retry_exponential_backoff_base | default('2')}}
      retry_type {{fluentd_retry_type | default('exponential_backoff')}}
      retry_max_interval {{fluentd_retry_max_interval | default('900')}}
      disable_chunk_backup {{fluentd_disable_chunk_backup | lower  | default('true')}}
      @type file
      path {{ fluentd_data_dir }}/s3-out-{{ team }}
      timekey 30 # 30 seconds partition
      timekey_wait 1m
      timekey_use_utc true # use utc
      flush_thread_count {{ fluentd_flush_thread_count }}
      chunk_limit_size {{ fluentd_s3_chunk_limit_size }}
      # total_limit_size is set 70% of the data disk do that 1 single out can't use more than this
      total_limit_size   {{ (ansible_mounts | json_query('[?mount == `/fluentd`].size_total | [0]') * 0.7 / 1024|pow(3))  | round | int | abs }}G
    </buffer>
  </store>
</match>

Your Error Log
In S3:
\n�@timestamp�2022-10-15T00:16:01.074+00:00�@version\u0001�message�XMaking

Within that exact same S3 object there are plenty of examples with no corruption:
\n","@timestamp":"2022-10-15T00:16:01.094+00:00","@version":1,"message":"Response

In Elasticsearch):
"@timestamp\":\"2022-10-14T23:16:01.074+00:00\",\"@version\":1,\"message\":\"Making

Additional context
Here is the hex code for the corrupted version:
5C 6E AA 40 74 69 6D 65 73 74 61 6D 70 BD 32 30 32 32 2D 31 35 54 30 30 3A 31 36 3A 30 31 2E 30 37 34 2B 30 30 3A 30 30 A8 40 76 65 72 7369 6F 6E 5C 75 30 30 30 31 A7 6D 65 73 61 67 65 D9 58 4D 61 6B 69 6E 67

Here is the hex code for the corrupted version:

Your corrupted message looks like MessagePack binary to me.
In particular, here is what it reads like:
5C 6E AA 40 74 69 6D 65 73 74 61 6D 70 BD 32 30 32 32 2D 31
 \  n ==  @  t  i  m  e  s  t  a  m  p ==  2  0  2  2  -  1
      fixstr (10 char)                 fixstr (29 char)

This is really strange. I cannot think of any plausible code path that can leak raw
msgpack binary in this manner. Can you post your entire configuration file here?

@domokap I cheked your configuration. I think your configuration is
basically correct.
Considering that Elasticsearch receives the same entry fine (despite
corruption in S3),  I suspect there is some racy bug in S3.
In S3:
\n�@timestamp�2022-10-15T00:16:01.074+00:00�@version\u0001�message�XMaking

In Elasticsearch):
"@timestamp\":\"2022-10-14T23:16:01.074+00:00\",\"@version\":1,\"message\":\"Making

I'll find some time trying to reproduce this issue. WFM.

@fujimotos thank you. I had ruled out that it is coming from upstream but I will endeavour to double check again with our logging teams.
Thanks again.

Hi @fujimotos I found some more weird related behaviour with the S3 plugin when it is creating the bucket paths. In the config we have path ${sky.top_tenant}/${service.name}/%Y/%m/%d/. Here is a summary of the folder at sky.top_tenant of service.name folders:

mytv-se by recs: /
mytv-serv found f/
mytv-servi29T22:2/
mytv-servi743a861/
mytv-service-r1aa/
mytv-service-recf/
mytv-service-recm/
mytv-service-recs/
mytv-service/
mytv-service434e-/
mytv-servicservic/
mytv-servservice-/
mytv-servuew/
mytv-servvice-rec/

Note however that the only two valid service.name and therefore folder names should be mytv-service and mytv-service-recs. Also the other ones must be a result of corruption.
Several of us suspect that it may be due to a race condition? Hope this extra information helps.

Are every 42 EC2 node's ${sky.top_tenant} non identical or not? :thinking:


Refresh cache when the source code of outlined functions are changed

Draft proposal to update the cache logic.
Testing cases and document are incomplete.
By revisiting the caching logic, my understanding is that we should update a binary/kernel whenever the following characteristics are changes:

The signature of the kernel's source code.
The signatures of inlined JIT functions being called.
The signatures of outlined JIT functions being called.
The length of any non-constexpr variables.
The number of variables.
The value of constexpr variables.
The alignment, date type, and ptr length of tensors.
The number of warps and stages.

This patch tries to fix a corner case of characteristics 3 (C3).

My understanding is that a lot of these cases should be already captured in either the hash of the top-level function (alignment, datatype, num stages/warps etc. hint), its source code, or the source code of the called functions (default constexpr value, signature). We seem to have a bug in our caching (which I'm also investigating), but I am not sure if it means we need to capture these things explicitly

@ptillet Yeah, I meant these C1-C8 are needed to guarantee the correctness, and triton has got most of the things correct. This patch is only trying to fix a small problem with C3.

I guess when the dependent function is a constexpr, this can be troublesome. In this case, the hash of the kernel should include the hash of the constexpr instead of its repr. That's probably the bug :p

The "right" solution is probably to use the hash of the JIT function instead of its repr here https://github.com/openai/triton/blob/master/python/src/triton.cc#L243

Sure, but without analyzing the function's source code, we probably don't have its hash?
https://github.com/openai/triton/blob/86cab58d89909aebd8970ca80a3e85220dd033d9/python/triton/code_gen.py#L1156

We could just call constexpr.cache_key, when constexpr is a JITFunction that will call https://github.com/openai/triton/blob/master/python/triton/code_gen.py#L1203.
This will add more overhead though, and I think this will make offline compilation fundamentally hard. Maybe not supporting JITFunction as constexpr is the right solution. Users can still pass a boolean and have branches inside of their kernel.

Maybe not supporting JITFunction as constexpr is the right solution.

Yeah, I totally agree.

I actually think we should go further and disable anything that implements the call method

Hi @ptillet, can you take a look at my new commits?

Looks good!

@Jokeren xformers has a bunch of places where JITFunction are passed as constant expressions... would you have a suggestion on a workaround?

The suggestion would be to pass a key string as a constexpr, and do the selection inside of the kernel:
if function == "fun1":
  fun1(x)
if function == "fun2":
  fun2(x)

Passing functions as constexpr was a relatively cool feature, but I think there is a good chance it would have got in the way of our effort to reduce launch overhead via static compilation. We'll need to think through our abstractions in more depth if we want Triton to have strong support for metaprogramming.


String generators added.

Added the string generators alphaUpperStr, alphaLowerStr and alphaNumStr.
Changed the order of string generators to match that of the character generators.
Added tests for numStr, alphaUpperStr, alphaLowerStr, alphaStr and alphaNumStr.
Changed _.forall(c => c.isLetter || c.isDigit) to _.forall(_.isLetterOrDigit) in the definition of identifier.

@xuwei-k I thought that the use of suchThat was redundant for these string generators but I included it since the existing string generators used suchThat. Would you prefer the following? If so, I can push these changes.
  def identifier: Gen[String] = (for {
    c <- alphaLowerChar
    cs <- listOf(alphaNumChar)
  } yield (c::cs).mkString)

  /** Generates a string of digits */
  def numStr: Gen[String] =
    listOf(numChar).map(_.mkString)

  /** Generates a string of upper-case alpha characters */
  def alphaUpperStr: Gen[String] =
    listOf(alphaUpperChar).map(_.mkString)

  /** Generates a string of lower-case alpha characters */
  def alphaLowerStr: Gen[String] =
      listOf(alphaLowerChar).map(_.mkString)

  /** Generates a string of alpha characters */
  def alphaStr: Gen[String] =
    listOf(alphaChar).map(_.mkString)

  /** Generates a string of alphanumerical characters */
  def alphaNumStr: Gen[String] =
    listOf(alphaNumChar).map(_.mkString)

@Michaelt293 Yes, I think your proposed change is better. It's possible that a .suchThat clause that never fails isn't a big deal, it makes me nervous and can lead to problems later.

@non Great. Let me know if I should squash the commits.

The reason for the suchThat calls is that this installs a filter that is later used when generated values are shrunk. This helps avoiding some of the confusing cases where you get back a test case that the generator didn't generate from the start. But that whole mechanism is ugly anyway, so I rather have people confused over test case shrinking, than having those suchThat calls there.

This looks good to me. 👍


Crashes on splash screen

OpenSuSE 15.3 on a new computer with a fresh install of WINE 6.12 from the Emulators repo.
Install completes without issue but on launch it sits on the initial splash screen for a few minutes and then crashes.

Also tried rsync ing the drive_c and .reg files from a working wineprefix on another machine. This one gets to the login screen, but then refuses to actually accept/draw any typed characters.
This other code has a different ProgramData folder install so I am wondering if Autodesk published an update that no longer works. I'll see if I can locate the same installer used on the other machine and install from that instead.

Duplicate of #29

I'm not convinced it's the same issue. I was never even able to sign in on this install, and it takes a good 2-3 minutes to crash from when the splash screen is shown.
the "working" install I copied goes from splash to authentication page in about 15 seconds.

@vintagepc Which graphics card and desktop environment did you have installed?

KDE, this is with an nVidia GTX-1050 and proprietary drivers.
I've tried both the dxvk and opengl installation options and it makes no difference in the issue.

Okay, then I use XFCE on my system.

I'm not convinced it's the same issue. I was never even able to sign in on this install, and it takes a good 2-3 minutes to crash from when the splash screen is shown.

My bad, the other issue indeed takes you to the login before crashing.

I am having the same issue. Launch, splash screen for 2 minutes then crash report. Just tried to install it today.
Running Xubuntu 20.04 and Geforce 1080 with proprietary drivers

@alice-cash Okay, can you check if my script have created the file NMachineSpecificOptions.xml correctly?
… and also if winetricks have installed corefonts vcrun2019 … ? 😊

Okay, then I use XFCE on my system. Maybe it this the reason why it doesn’t work for you.
Have you also other repository’s configured?

Just Emulators/Wine and packman.
If this was a system or package issue I'd expect the copied wineprefix version to fail the same way, yet it acts normal. Unfortunately I just can't get further than sign-in on that one because it won't accept keyboard input.
This is one of the main reasons I despise SaaS and quasi-cloud stuff; it can break without any changes on your part and good luck figuring out why.
I haven't had time yet to dig up the installer from the previous machine I was using; I just went back to my VM and a different CAD program so the motivation to spend more time getting it working again has waned a bit. :roll_eyes:
Suggestion - maybe the scripts could maintain checksums of the known working installers so that one can more easily check to see if it's a "known" revision or if they've sneakily updated it and potentially broken something - and if it detects a new installer ask the user to report their success or failure here for others.

I'm struggeling with the same issue. I fixed it somehow a few days ago.. but forgot how and where... so I'm back here, trying to figure out what's wrong.. pretty sure it was some missing winetricks lib or something like that...

So I am not as familiar with wine and verifying packages are installed, I tried just reinstalling both and get vcrun2019 already installed, skipping and corefonts already installed, skipping. I also verified that NMachineSpecificOptions.xml is set up.
I also tried setting up with dxvk but get the exact same issue.
I have also tried reinstalling graphics drivers and updating from 460 to 465. I am clearing out $HOME/.fusion360 between attempts, if I should be doing something else let me know. Other programs like steam proton/games work.

The whole thing is really strange. 😪

Hello everyone,
I have closed some issues now and referred to this issue here, which are basically similar to this one. ⚠
So I hope that we can find faster a solution for this problem. 🧔🏼♂👩🏽🦱👱🏾♀👨🏻🦱🧑🏼🦱👩🏻👨🏿🦲🌎

Additional data point: Moving the "crashing" install to the "working" prefix results in it starting and moving to the still-unusable sign-in page.
So we are back to it being a prefix config issue as part of the problem.

@vintagepc I just find it frightening that it works with one of them and with the other, who even has the same hardware, etc., it doesn't work.
I don’t know, why it’s so.

Good to know that it's not a Manjaro-only problem, so that can probably eliminate KDE and Manjaro playing a part in the error.
Does installation work properly for you all too? The install script successfully works for me.

@suryanisaac Installer after some additional lib installs is fine but these wine-3d errors when I started from the console. It even popped up some dll name before crash... I think it might be a missing lib of some kind that is not letting some 3d rendering data to pass through. From some basic analisis of GPU Usage and programs that are using it I think that Fusion is loading default 3d view even before login for optimized loading. Thats why there are wine-3d errors I think. I don't know wine that well but maybe some 3d packets are not installed or something.

wine: Call from 0x7b02dae6 to unimplemented function ucrtbase.dll.feclearexcept, aborting

It even popped up some dll name before crash...

This message showed up right before crash in console.

I have something that might help. My workshop PC running Win7 was dealing with Fusion just fine about a week ago. Today I tried to start it and all 3d is gone. No 3d interface at all. I think that it may be a sneaky update changing some way that autodesk handles  3D

Hmm, It's worked for me on the same system configuration a few weeks ago but not now. Does anyone here know of an archive of Fusion360 .exe files?
So it's probably Autodesk that broke something?
Anyway through this whole ordeal, I'm learning more and more FreeCAD which is good I guess.

FreeCad has some CNC module? That's a deal breaker for me. If it has - I am switching right now.

Yes! https://wiki.freecadweb.org/Path_Workbench

Also something interesting @cryinkfly and @vintagepc I've found this script to work: https://gist.github.com/probonopd/0fab254aa0b6fc371d8db641822bd530#gistcomment-2799597
I followed the instructions and Fusion360 launched without a problem, on the same machine without any changes. Maybe it's something with the winetricks installed? I've also tried this after attempting your install on my system so that might play a part.

So I have found out, that it sometimes happens that not all packages are available, as you can see in the picture for example:

... and this package is needed for the TLS and HTTPS story, for example!
Here you can see it on my system:

Then I have searched and found this site here: https://github.com/lutris/docs/blob/master/WineDependencies.md
... where I get a information that we need sometimes more packages and so I think that some users must install these things here for using Autodesk Fusion 360 correctly on there system!
Also I think when I install more of these packages then maybe it could be that other things will also work for us.
As an example, there is the documentation workspace.

@suryanisaac
Winetricks definitely plays a very big role in this whole thing!
The problem is that sometimes the servers are not reachable or the sha256sum are mismatched and that takes care of it ensures that not everything is installed correctly!!!
And this can be also the reason why some users can't use the program Autodesk Fusion 360 on there system.
But at the moment I can't do anything, because it always depends on the availability of this server!

It also doesn't help if a distro has system packages for certain things that might interfere or conflict with things that winetricks might add.
In any case I've also had enough of this Autodesk BS and have been using SolidEdge Community more and more as I get to know it. (Only reason I still hang on to F360 is for things I haven't figured out how to do yet. I guess this will be more motivation than any as the time spent messing around with F360 in wine is outweighing the time it takes to start up and shutdown a VM now - Fusion has lost the "convenience" factor.
No "cloud", once it's installed, it's installed, end of story. Also doesn't phone home to the mother-ship.
Graphics don't seem as intensive as Fusion so it runs fine in a Win7 VM in Virtualbox
Free for hobbyists/makers/tinkerers
https://www.plm.automation.siemens.com/plmapp/education/solid-edge/en_us/free-software/community
the 2020 version will happily install with the correct prerequisites (Dot Net and some IE related requirements) but unfortunately crashes when trying to create a new document or open one. (But even that's a huge step forward, in Wine 5.x it would not even get past the splash screen.
It installs and launches in Wine but there is a showstopper where it crashes if you try to open or create a document. Alas I'm not well versed enough in wine debugging to understand what it needs.
I've tried FreeCAD a few times but always found the interface a horrible mess and it's a challenge to find out how to do anything when all the search results are out of date because things have been rearranged and not where it says they should be. I genuinely hope it improves and gets better but from my perspective it's been a complete non-starter any time I've tried.

Well, FreeCAD is something i'm fine with for simple parts but anything slightly complex is hard. But it's improving a lot lately and i'm hoping that it becomes better over time.
On Jul 6 2021, at 4:48 pm, vintagepc @.***> wrote:

It also doesn't help if a distro has system packages for certain things that might interfere or conflict with things that winetricks might add.
In any case I've also had enough of this Autodesk BS and have been using SolidEdge Community more and more as I get to know it. (Only reason I still hang on to F360 is for things I haven't figured out how to do yet. I guess this will be more motivation than any as the time spent messing around with F360 in wine is outweighing the time it takes to start up and shutdown a VM now - Fusion has lost the "convenience" factor.
No "cloud", once it's installed, it's installed, end of story. Also doesn't phone home to the mother-ship.
Graphics don't seem as intensive as Fusion so it runs fine in a Win7 VM in Virtualbox
Free for hobbyists/makers/tinkerers
https://www.plm.automation.siemens.com/plmapp/education/solid-edge/en_us/free-software/community @.***/0?redirect=https%3A%2F%2Fwww.plm.automation.siemens.com%2Fplmapp%2Feducation%2Fsolid-edge%2Fen_us%2Ffree-software%2Fcommunity&recipient=cmVwbHkrQUUySlNSV09FREZCWFFTSU1ETDY0QjU2NkFPT1JFVkJOSEhEUFQ0M1FFQHJlcGx5LmdpdGh1Yi5jb20%3D)
the 2020 version will happily install with the correct prerequisites (Dot Net and some IE related requirements) but unfortunately crashes when trying to create a new document or open one. (But even that's a huge step forward, in Wine 5.x it would not even get past the splash screen.
It installs and launches in Wine but there is a showstopper where it crashes if you try to open or create a document. Alas I'm not well versed enough in wine debugging to understand what it needs.
I've tried FreeCAD a few times but always found the interface a horrible mess and it's a challenge to find out how to do anything when all the search results are out of date because things have been rearranged and not where it says they should be. I genuinely hope it improves and gets better but from my perspective it's been a complete non-starter any time I've tried.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub @./1?redirect=https%3A%2F%2Fgithub.com%2Fcryinkfly%2FFusion-360---Linux-Wine-Version-%2Fissues%2F38%23issuecomment-874675095&recipient=cmVwbHkrQUUySlNSV09FREZCWFFTSU1ETDY0QjU2NkFPT1JFVkJOSEhEUFQ0M1FFQHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe @./2?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE2JSRWQ2BDQOF57LB5OUW3TWLQ6RANCNFSM47YUYPZQ&recipient=cmVwbHkrQUUySlNSV09FREZCWFFTSU1ETDY0QjU2NkFPT1JFVkJOSEhEUFQ0M1FFQHJlcGx5LmdpdGh1Yi5jb20%3D).

The problem was some users have with Autodesk Fusion 360 on Linux with Wine🍷, I can say that this problem is also represented on windows!
Here is the link: https://knowledge.autodesk.com/support/fusion-360/learn-explore/caas/sfdcarticles/sfdcarticles/Fusion-360-has-installed-but-will-not-launch.html

I have the following errors in .fusion360/drive_c/users/owen/Local Settings/Application Data/Autodesk/Web Services/Log/WebServices.log
2021-07-26T02:51:56.762Z [Fusion360:232, 596] [AdWebServices ERROR] Application not installed properly. File libcrypto-Ad-1_1-x64.dll could not be located in application dir or current dir.
2021-07-26T02:51:56.764Z [Fusion360:232, 596] [AdWebServices ERROR] Application not installed properly. File libssl-Ad-1_1-x64.dll could not be located in application dir or current dir.

Is this what we are looking for?

https://gist.github.com/probonopd/0fab254aa0b6fc371d8db641822bd530#gistcomment-2799597 also worked for me. Welp, actually one only need
winetricks atmlib gdiplus msxml3 msxml6 vcrun2017 ie8 corefonts fontsmooth=rgb winhttp win10

from that comment. Fusion 360 won't start with winetricks d3d11=disabled and you don't need to patch the installer.

Actually, didn't notice that
winetricks atmlib gdiplus msxml3 msxml6 vcrun2017 ie8 corefonts fontsmooth=rgb winhttp win10

fails at installing ie8 (needs 32-bit prefix). Removed ie8 and added dxvk + sh winetricks d3d10core=disabled d3d11=builtin d3d9=builtin dxgi=builtin. (Now wineserver doesn't consume 100% CPU.)

@ Can you testing my new version of the installation-script, please. 🕛

I can confirm the latest install script works and Fusion launches now without issue. Though the object browser items seem to be stuck in the foreground and are currently on top of my chrome window.

@alice-cash Thank you for your report. 👌


Remuxed videos "stutter" while playing

Both the original (avi) and remuxed (mp4) videos play fine in both mpv and vlc, but when the remuxed video is played in either chrome or firefox, the frames appear to be shown out-of-order. This may have something to do with ffmpeg messing up the PTS and DTS of b-frames, but I'm not sure. Native mp4 videos, which are not remuxed, play fine in both firefox and chrome.
Example: https://osu-js.pages.dev/play/?1643958

Seems similar to https://video.stackexchange.com/questions/22340/ffmpeg-repackaging-avi-h264-into-mp4-gives-choppy-playback-in-html5-video-on-c
This issue persists with the latest version of FFMPEG (ffmpeg/ffmpeg@d3f48e68b3, osu-js uses 4.3.1), so if it's a bug in ffmpeg it hasn't been fixed.

I investigated this problem a little bit and came to the conclusion that using libx264 codec can help you with #22 and this one. I have tested beatmap from the example above and didn't notice any stutters. However, in exchange for using libx264 codec, you have to sacrifice the speed of video conversion.
    await ffmpeg.run(
      "-i", ffmpegInputFilename,
      "-c:v", "libx264",
      "-c:a", "copy",
      "-preset", "ultrafast",
      "-an",
      "output.mp4"
    );

I've been trying to avoid re-encoding the video since it can take a while, but I might have to resort to it. I'm currently looking into using FFmpeg as a software decoder and writing a custom device to send the decoded video to webgl, which would also solve #22.


`FAIL_* macros break if one of the arguments contains a quote

Simple example:
`FAIL_UNLESS_EQUAL(cut.is_palindrome("tacocat"), 1)

The above will fail as the macro tries to stringify the arguments passed in, which breaks if there are any quotes. This forces tests to be written like this:
    bit result = cut.is_palindrome("tacocat");
    `FAIL_UNLESS_EQUAL(result, 1)

Which is inconvenient for tests that have many small asserts.
This issue could be fixed together with issue #225 to avoid using the `" operator in the macro and use something like $sformatf instead.

I know, I run into this a lot as well. The fact that there's no way to quote a macro is annoying (especially since this problem was already solved for C, so the SV people had a place to look for inspiration).
As mentioned in #225, printing the values of expressions is not trivial, because evaluating expressions can have side effects.


Hide attribution locally

Hide the map attribution when served locally (url contains localhost), this is usefull in screenshot testing since fonts are rendered with quite big differences depending on the OS/browser.
This is a diff between OSX/Linux see Red pixels pointing differences in the attribution div.

It is not very nice to change the public examples in order to pass the tests...

@Jesus89 the script only removes the attribution when served locally, public examples documentation.carto.com/whatever will look the same

I mean this lines <script src="../hide-attribution.js"></script>


Unexpose VelocityTracker3D

This unexposes the VelocityTracker3D class from scripting languages. See discussion in https://github.com/godotengine/godot/pull/53314, where Calinou and reduz agreed that this probably shouldn't have been exposed in the first place and can easily be created with more flexibility from scratch.
Somewhat breaks compat as it had been exposed in 3.x as SpatialVelocityTracker. From a brief glance at available projects, it wasn't ever used much. The occurrences I could find are places where Godot's API is mirrored, i.e. in bindings, not in any actual games or apps.
Supersedes https://github.com/godotengine/godot/pull/53314.

I actually use this class to track the object's positions, what should I do to move away from using this class?

I actually use this class to track the object's positions, what should I do to move away from using this class?

Write your own in whatever language you use. It should not require much to save the last positions :)

Thanks!


can i continue training this Embedding? how?

can i continue training this Embedding? how? plz

It depends on your tasks.

Better embedding
Using these pre-trained embeddings to initialize embedding model, and training new embedding model on another corpus, you could get better embeddings. Fasttest provides "-pretrainedVectors" to load embeddings before training, but some codes should be modified to maintain vocabulary matrix.
Better task performance
Initializing the embedding table with these embeddings rather than random embeddings, you will get better performances in most of tasks.


spark-history fails to install

When trying to install spark-history from the UI, I got:
"The schema for this package is not properly configured. If you are the package owner, please check your configuration. Or you may contact the maintainer<EMAIL_ADDRESS>

UI installed is disabled now.


 Check the help for details

Hello @it512
The issue you are running into seem to be due to GOOS=wasip1 not having complete network support. The WASI preview 1 specification did not contain a full definition of socket networking, so general features available on POSIX platforms such as opening listening sockets are not available.
This is unrelated to wazero and depends on the current implementation in Go, you will get a similar behavior if you try to run your program on another webassembly runtime.


setup script

Hi,
I am new to ZMQ and trying to install nzmqt .
https://github.com/jonnydee/nzmqt/blob/master/doc/Software.md
Trying to install nzmqt in Linux with Zeomq (c/c++ binding)
On the setup script part. I can not find the setup-project.sh script, not sure, i am missing some info

cd
./setup-project.sh

Secondly is this library work with ZeroMQ Zyre framework?

Hi, there is no setup script anymore. The documentation is outdated in that case. When you clone 'master' you'll now have everything you need (except ZeroMQ library itself). Regarding ZeroMQ Zyre framework -- sorry, I don't know, I'm not familiar with it.
Best regards.


Generating report in non-default location results in pdf files without plot images

i ran this with the -p option, to generate a report in a local folder and not the default.
The reports were generated and look fine other than the images missing

-p should be the full path to the projects directory. By default is it /.mounts/labs/gsiprojects/gsi/Data_Transfer/Release/PROJECTS
The images are missing because a relative path of the figure files is added to the html instead of the full path


Replace screenshots on user doc page

The message screenshots (1st and 3rd screenshot) on this page should be replaced: http://localhost:9991/help/view-the-markdown-source-of-a-message
Requirements:

same message in both screenshots
message includes some non-trivial markdown

Since I was responsible for this inconsistency, I would like to take this up. Could this be a separate PR? or could the original commit be dropped to be replaced by another?

Fixed via #3059, thanks for the report @alyaabbott! :)


WSS - Suppress certificate validation?

Is there a way to suppress the "The remote certificate is invalid according to the validation procedure. The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel." exception?
My code snippet:
var brokerHostWithPort = "wss://host:port"
var options = new MqttClientOptionsBuilder()
.WithWebSocketServer(brokerHostWithPort)
.WithTls(true, true, true, null)
.WithCredentials(userName, password)
.Build();
await mqttClient.ConnectAsync(options);
Thank you,
Radek

I used following to disable the validation...
ServicePointManager.ServerCertificateValidationCallback = delegate { return true; };

This solution does not work in .NET Core.


Addition to fnv1a_xor_hashes.txt

csfalconcontainer<PHONE_NUMBER>560670602
csfalconservice<PHONE_NUMBER>961817906
aka this is looking for CrowdStrike

Added in #10. Thanks, and keep them coming!


[consensus] removing the terminate in chained_bft_smr loop

The consensus loop/select has a terminate that should not be reachable as the loop should run forever.
This commit removes it.

we can probably remove that complete => {} line

not a bad idea :D let me try this

looks like it worked

@bors-libra r+

:pushpin: Commit d559d7c has been approved by zekun000

:hourglass: Testing commit d559d7c76a40f3aa754427e0c534ba9c931ed03b with merge 3e40b5b54f467f73e0f07ee48bfe2bea2464b585...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: zekun000
Pushing 3e40b5b54f467f73e0f07ee48bfe2bea2464b585 to master...


Add kube-proxy config reference

This is a reference for kube-proxy config generated from kubernetes-sigs/reference-docs/genref tool.
More specifically, it is generated using the following command:
./genref -include kube-proxy

👀

previews:
https://deploy-preview-26595--kubernetes-io-master-staging.netlify.app/docs/concepts/services-networking/service/#nodeport
https://deploy-preview-26595--kubernetes-io-master-staging.netlify.app/docs/reference/setup-tools/kubeadm/kubeadm-init/#kube-proxy
https://deploy-preview-26595--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/kube-proxy-config.v1alpha1/
/lgtm
/sig cluster-lifecycle network

What do you think about adding /docs/reference/config-api/_index.md to create a section for the configuration reference pages?

Since we don't have a hard limit on TOC levels, adding another level of TOC under "reference" makes sense. Do you want me to do this right now or is it okay to move this subsection after all config APIs proposed are merged?

/hold
Depends on: https://github.com/kubernetes-sigs/reference-docs/pull/214

/hold cancel
kubernetes-sigs/reference-docs#214 is in.

What do you think about adding /docs/reference/config-api/_index.md to create a section for the configuration reference pages?

Since we don't have a hard limit on TOC levels, adding another level of TOC under "reference" makes sense. Do you want me to do this right now or is it okay to move this subsection after all config APIs proposed are merged?

Do you have to move any files? If you add a section  _index.md file to the config-api directory, the files can stay in place?

Do you have to move any files? If you add a section _index.md file to the config-api directory, the files can stay in place?

That was a comment before we added the config-api subdirectory. I'll add an index.md file to that subdirectory.

The changes look good!
/lgtm

https://github.com/kubernetes/website/pull/26595#discussion_r603720133 feels like a good summary @kbhawkey.
How about

we identify some “fast follow up” changes that can come in post release
we commit to making those soon after the release
we ship these changes pretty much as is

@tengqm @kbhawkey does that sound OK?

I might be able to propose the relevant CSS changes today, BTW.

Have you guys checked the latest change and the preview? I have revised the code 11 hours ago and pushed a new commit.

👀

/approve


apt-key add fails when using proxies.

Is this a BUG REPORT or FEATURE REQUEST?:
BUG REPORT
What happened:
When configuring http proxies in kismatic-cluster.yaml and deploying to nodes without direct internet access apt keys / sources are not added and packages are not installed. Kismatic skips over these errors and continues deploying to the remaining hosts that do have direct internet access, ultimately failing when trying to bring up pods on the non-existent nodes. See the output from the kismatic install apply command
Validating==========================================================================
Reading installation plan file "kismatic-cluster.yaml"                          [OK]
Validating installation plan file                                               [OK]
Validating SSH connectivity to nodes                                            [OK]

Configuring Certificates============================================================
Found valid certificate for bizk8smaster01 etcd server                          [OK]
Found valid certificate for bizk8smaster01 API server                           [OK]
Found valid certificate for kubernetes controller manager                       [OK]
Found valid certificate for kubernetes scheduler                                [OK]
Found valid certificate for service account signing                             [OK]
Found valid certificate for bizk8smaster01 kubelet                              [OK]
Found valid certificate for kube-proxy                                          [OK]
Found valid certificate for etcd client                                         [OK]
Found valid certificate for bizk8smaster02 etcd server                          [OK]
Found valid certificate for bizk8smaster02 API server                           [OK]
Found valid certificate for bizk8smaster02 kubelet                              [OK]
Found valid certificate for bizk8smaster03 etcd server                          [OK]
Found valid certificate for bizk8smaster03 API server                           [OK]
Found valid certificate for bizk8smaster03 kubelet                              [OK]
Found valid certificate for bizhpa0s01k8s kubelet                               [OK]
Found valid certificate for bizhpb0s01k8s kubelet                               [OK]
Found valid certificate for admin client                                        [OK]
Cluster certificates can be found in the "generated" directory                  [OK]

Generating Kubeconfig File==========================================================
Generated kubeconfig file in the "generated" directory                          [OK]

Installing Cluster==================================================================
Configure Cluster Prerequisites                                                 [OK]
Gather Node Facts                                                               [OK]
Update Hosts File                                                               [SKIPPED]
Deploy Cluster Certificates                                                     [OK]
Generate Kubectl Config File                                                    [OK]
Deploy Etcd Certificates                                                        [OK]
Configure Package Repositories                                                  [ERROR]
- Task: add Docker deb key
  bizhpa0s01k8s: Failed to connect to apt.dockerproject.org at port 443: [Errno 110] Connection timed out[ERROR]
  bizhpb0s01k8s: Failed to connect to apt.dockerproject.org at port 443: [Errno 110] Connection timed out[ERROR]
Configure Package Repositories                                                  [OK]
Install Docker                                                                  [OK]
Start Kubernetes Etcd Cluster                                                   [OK]
Start Network Etcd Cluster                                                      [OK]
Start Kubernetes Kubelet                                                        [OK]
Start Kubernetes API Server                                                     [OK]
Start Kubernetes Scheduler                                                      [OK]
Start Kubernetes Controller Manager                                             [OK]
Validate Kubernetes Control Plane is Running                                    [OK]
Start Kubernetes Proxy                                                          [OK]
Label Kubernetes Nodes                                                          [SKIPPED]
Start Calico Network Components                                                 [OK]
Validate Calico Network Components                                              [OK]
  bizk8smaster01: Timed out waiting for policy controller pods to be in the ready state.[ERROR]
error installing: error running playbook: error running ansible: exit status 2

In this case, my control plane is on virtual machines with direct internet access, and the core kubernetes components are installed as expected, though the workers are on physical machines with more restrictive networking and all package deployment fails, despite passing preflight checks.
What you expected to happen:
1.) I expected kismatic to stop attempts to deploy components when no workers had been created.
2.) I expected apt-key and package installations to work properly when setting http_proxy & https_proxy values.
How to reproduce it (as minimally and precisely as possible):
Deploy workers in environments that require proxies for external communication & master nodes in environments that do not.
Set http_proxy & https_proxy in kismatic-cluster.yaml
run kismatic install apply
Anything else we need to know?:
The proxy settings for apt appear to work on the boxes that require it. I can run all of the apt commands with sudo as the kismatic user with success. It is just when being run from the kismatic deploy box that things fail.
Environment:

Kismatic version (use kismatic version): 1.6.3
Plan file Gist (remove sensitive information if any): https://gist.github.com/msm93v2/4beace0cba8ddbff9c5cb7b28076f6f1
Cloud provider or hardware configuration: bare-metal, control plan on vms, physical device workers.
OS (e.g. from /etc/os-release): Ubuntu 16.04
Kernel (e.g. uname -a): 4.4.X

Hi @msm93v2 thank you for opening the issue.
The proxy options in the plan file are global and set the environmental variables on all the nodes.
You can try setting the variables manually on the nodes that need it:
  HTTPS_PROXY: "{{ https_proxy }}"
  https_proxy: "{{ https_proxy }}"
  HTTP_PROXY: "{{ http_proxy }}"
  http_proxy: "{{ http_proxy }}"
  NO_PROXY: "{{ no_proxy }}"
  no_proxy: "{{ no_proxy }}"

The other comment about the installation proceeding after a task failed is more concerning, I will take a look at that.

Setting these variables globally does not change the behavior of kismatic install apply. perhaps the issue is not in the proxy settings itself, but
something else. Are there debug logs that my be more helpful in finding the
issue?
On Wed, Dec 13, 2017 at 11:17 AM, Dimitri Koshkin<EMAIL_ADDRESS>wrote:

Hi @msm93v2 https://github.com/msm93v2 thank you for opening the issue.
The proxy options in the plan file are global and set the environmental
variables on all the nodes.
You can try setting the variables manually on the nodes that need it:
HTTPS_PROXY: "{{ https_proxy }}"
https_proxy: "{{ https_proxy }}"
HTTP_PROXY: "{{ http_proxy }}"
http_proxy: "{{ http_proxy }}"
NO_PROXY: "{{ no_proxy }}"
no_proxy: "{{ no_proxy }}"
The other comment about the installation proceeding after a task failed is
more concerning, I will take a look at that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apprenda/kismatic/issues/976#issuecomment-351440975,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYU0ABNdjmhMXs6IVR8wgJCoWYo_UDIGks5s__iugaJpZM4RAvW4
.

From your description it would be the proxy settings that are being used on the nodes where the proxy should not be used. By "global" I meant those options will be used on all the nodes during the installation, it will not persist the variables after the installation.
Are you able to configure your network that all the nodes are able to either all use the proxy or all not use the proxy?
There should be logs in the generated\ directory for Ansible and you can find the add Docker deb key task.

The nodes that require the proxy are failing to talk out, the nodes that
don't need the proxy can talk through out just fine with the proxy set.
As I mentioned, these commands run fine in both login, and non-login shells
on all nodes. I have worked around the issue using the offline installation
method though, so if no one else has issues with it, I'm perfectly happy
chalking it up to an issue with my environment.
On Wed, Dec 13, 2017 at 11:57 AM, Dimitri Koshkin<EMAIL_ADDRESS>wrote:

From your description it would be the proxy settings that are being used
on the nodes where the proxy should not be used. By "global" I meant those
options will be used on all the nodes during the installation, it will not
persist the variables after the installation.
Are you able to configure your network that all the nodes are able to
either all use the proxy or all not use the proxy?
There should be logs in the generated\ directory for Ansible and you can
find the add Docker deb key task.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apprenda/kismatic/issues/976#issuecomment-351453462,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYU0AMgQvh-EXxdeSm2W4tcmKJEPQN0Xks5tAAHmgaJpZM4RAvW4
.

Closed in #1173


Improvements to deploy and rollback functions.

Changes rollback mechanism to always use the last release on github.
Always deletes all 'e2e-test-' test namespaces when rolling back.
Always remove the lock annotation when rolling back.
Improves output by logging status when waiting to upgrade/rollback CCM.
Minor bug fixes.

Indeed! Thanks Andrew. Forgot about the tweaks on your branch!

This should be done. Tests green after trimming back egress rules.


Use scalable and efficient sampler

The sampler may now be passed to statsd.StatsdClient to redefine sampling
behaviour. The default sampler uses pool of random number generators in
order to be efficient and scalable. The other provided sampler statsd.SyncSampler
is a little bit more efficient in non-contended cases but doesn't scale.

@quipo Should I give up on this PR?


ACCUMULO-4376 add KeyBuilder

Adds the KeyBuilder as proposed in ACCUMULO-4376. For the design, I took inspiration from the Step Builder design pattern as described in Vladimir Stankovic blog to try to give some rules to the way Keys are built. I also added a new constructor to Key that accepts all the parameters, including deleted similar to to the Key.init method, that is used to build Keys from the fields.

This is looking great, @melrief!

Here's a thought that may be distracting. I wonder if it is easy to have a single builder that accepts Text, CharSequence, byte[], etc.  Such a builder could mix and match the types; for example, a Text row and visibility, a CharSequence family and qualifier. A user might even extend such a builder to add support for building a key from a custom type.
Maybe Java 8 default methods would make this easier, a la mixins.

I agree w/ @dhutchis and would really like the ability to mix types.  For example a binary row and string column is a common usage pattern.   The builder pattern supports this usage pattern really well.
I would suggest using family instead of columnFamily, qualifier instead columnQualifier, and visibility instead of columnVisibility for the methods names.  IMO using these names will make the code users write shorter and less redundant w/o any loss in readability.
I would suggest making the builder class package private and adding a newBuilder() method to Key that returns the first interface.
Below is an example of code using all of these suggestions.
    byte r[];
    String f;
    Text q;

    Key k = Key.newBuilder().row(r).family(f).qualifier(q).build();

@keith-turner Ok I'll add the possibility to use different data types. I wasn't aware about this requirement and didn't design for it. I'll need some time.
I have to disagree in removing the column from the column components. It may be easier for who knows Accumulo but not for the new developer and being used to see columnFamily or colFam everywhere would make this choice particularly difficult imho for no reasons.
I don't understand why the newBuilder() method. What problem does it solve? The issue on doing this is that row cannot be final in the KeyBuilder anymore and must default to null when the KeyBuilder is built, which means that I have another null around for a value that cannot be null and must be set. That's why I prefer to combine passing the row and build the builder together, so I can use the constructor of the builder to set the row asap and skip a null that eventually must be not null.

I have to disagree in removing the column from the column components. It may be easier for who knows Accumulo but not for the new developer and being used to see columnFamily or colFam everywhere would make this choice particularly difficult imho for no reasons.

@melrief  those are valid points.  There are definitely two classes of users to consider, new users and experienced users.  I am thinking about making the code pleasant to read and write for more experienced users and you want to make the code easier to read/write for new users.   They are both valid concerns.  Do you think having shorter names and good javadocs on the methods would be good enough for both users?

I don't understand why the newBuilder() method. What problem does it solve?

Not much.  It offers the following advantages :

One less class in public API.   The interfaces need to be in public API, but with this static method the class implementing the interfaces can be package private.
When a developer is looking at the Key class methods in an IDE, it makes it easy to discover that a builder exists.  This could also be accomplished with good javadoc for Key that points to the Builder.

The Key.newBuilder() also mirrors common practice in Guava and other libraries, that developers may be more familiar with.  For example, ImmutableList.builder().  Of course this comes down to style and the sequence you suggest could work too.

It makes sense to mimic what common libraries do and I understand that Key.newBuilder() would be easier to find for the user because it's directly in the Key class. Both point make sense and the null thing is internal and easy to workaround anyway. You convinced me, I'll use this pattern. I'll need sometime to complete the refactoring.

After reading @dhutchis  comment about Guava I would suggest using the method name builder() rather than newBuilder().

Agreed, then we will have Key.builder(). @keith-turner about the column components, I'm a bit torn about names without column but yes, I think having good documentation together with the fact that the builder forces you into selecting one components at time could do the trick. Probably a simple example directly in the doc of KeyBuilder would be enough for new devs.

I'm a bit torn about names without column

I understand.  I don't think there is a good solution for both types of users.   Personally, I tend to lean towards making it nice for the experienced users and having good docs for the new users.  New users will either stop using it or become experienced users.  When they transition from new to experienced I suspect they will appreciate the less verbose code.

Accumulo but not for the new developer and being used to see columnFamily or colFam everywhere would make this choice particularly difficult imho for no reasons.

@melrief I was reading back over your comments.  Consistency with the existing methods names in key is a very good reason to use 'columnFamily() intsead of 'family().  Sigh, now I am torn also.

To expand on my previous comment about consistency and why I am less certain.   The reason I was torn after re-reading @melrief comment is that the issue of consistency is not about new vs existing users.   Having 20 different ways to say the same thing in the API is aesthetically displeasing.  So even though the new API may be aesthetically pleasing when considered alone, it may not be when considering it as part of the entire API. This may be ok if a new standard is set thats followed from the point forward.  Existing precedents must be considered when adding new APIs.

@keith-turner @dhutchis I pushed another commit with the design changes we discussed. Now it is possible to write
Key.builder().row(new Text("row")).family(new byte[] { 1, 2, 3 }).qualifier("foo").build()

to build a Key. There is still to decide about column family, qualifier and visibility names and, while my point is that we should be consistent and keep the column before the component name, I don't have a strong opinion about that.
@joshelser I added two tests, one to check if the bytes are reused if copyBytes is false and one to be sure that they are not if copyBytes is true.
p.s. because a lot of people are commenting, I'm going to pile new commits and then squash them at the end, if and when you decide to merge.

@melrief Here is a user scenario for building a Key from ByteBuffers. The main advantage is being able to create keys from the middle of existing arrays given their offsets and lengths.
Sadly I realized after writing the example that the Key.copyIfNeeded() method will copy all of these anyway, so the efficiency gained by the code may just be an illusion.  If it is an illusion, it would be simpler for a user to use ByteBufferUtil.toArray(bbRow) and so forth. Changing the Key class to use segments of arrays is a big change.
// These byte[]s are obtained from user code.
byte[] bigArray = new byte[500], bigArray2 = new byte[80], EMPTY_BYTES = new byte[0];

// Suppose that we want to create a key whose row is in the bigArray from bytes 105 to 115,
// whose column family is in the bigArray2 from bytes 200 to 207,
// and whose column qualifier is in the bigArray2 from bytes 60 to 69.
ByteBuffer bbRow = ByteBuffer.wrap(bigArray, 105, 10);
ByteBuffer bbFam = ByteBuffer.wrap(bigArray, 200, 7);
ByteBuffer bbQual = ByteBuffer.wrap(bigArray2, 60, 9);

// We expect hasArray() to be true for all of these.
// When hasArray() is true, we can avoid copying out the portion of the ByteBuffer to a new byte[].
// I include the case for ByteBuffers that do not have a backing array for completeness.
final byte[] bRow, bFam, bQual;
final int offRow, offFam, offQual, lenRow, lenFam, lenQual;
if (bbRow.hasArray()) {
  bRow = bbRow.array(); offRow = bbRow.arrayOffset() + bbRow.position(); lenRow = bbRow.remaining();
} else {
  // fallback to copy case
  bRow = ByteBufferUtil.toBytes(bbRow);
  // The ByteBufferUtil.toBytes method will have the following effect:
  //bRow = new byte[bbRow.remaining()];
  //bbRow.duplicate().get(bRow);
  offRow = 0; lenRow = bRow.length;
}
// Repeat for family and qualifier
if (bbFam.hasArray()) {
  bFam = bbFam.array(); offFam = bbFam.arrayOffset() + bbFam.position(); lenFam = bbFam.remaining();
} else {
  // fallback to copy case
  bFam = ByteBufferUtil.toBytes(bbFam);
  offFam = 0; lenFam = bFam.length;
}
if (bbQual.hasArray()) {
  bQual = bbQual.array(); offQual = bbQual.arrayOffset() + bbQual.position(); lenQual = bbQual.remaining();
} else {
  // fallback to copy case
  bQual = ByteBufferUtil.toBytes(bbQual);
  offQual = 0; lenQual = bQual.length;
}

// Construct key from all byte[]s with offsets and lengths.
// Note that this old API method copies the data. It would be nice to not copy the data,
// but this would bigger changes to the Key class.
Key k = new Key(bRow, offRow, lenRow, bFam, offFam, lenFam, bQual, offQual, lenQual,
	EMPTY_BYTES, 0, 0, Long.MAX_VALUE);

@dhutchis even if a copy is done, if the API accepts ByteBuffers it can help avoid forcing intermediate copies.  For example user has to copy ByteBuffer to byte array, pass that byte array to KeyBuilder, and then KeyBuilder copies what it was passed.
ByteBuffers are similar to input streams in that they have a position and reading from it can change that position.  One decision we would have to make if we accept ByteBuffers is if we want to change that position or not when reading.  If any other parts of API accept ByteBuffer, would need to see what the behavior is.  We could possibly hold off on adding ByteBuffer in this PR and open a separate issue to examine adding support for ByteBuffer the API.

Good point @keith-turner. I had a contract in mind to not change the state of the ByteBuffer.
Here is a better idea: add methods to accept a byte[], offset, and length. Users of ByteBuffers can call these methods manually via the code at the end of my previous example.

+1

The new KeyBuilderImpl now keeps not only the byte arrays but also offsets and lengths of each byte and each method now takes this offset and length as optional parameters. In this way we are able to reuse byte arrays to create Keys:
byte[] keyBytes = new byte[] { 0, 1, 2, 3, 4, 5 }
Key key = Key.builder().row(keyBytes, 0, 2).column(keyBytes, 2, 2).qualifier(keyBytes, 4, 2).build();

Thanks a bunch @melrief . This will be very nice to have.

Tests are failing on both Travis and my computer but for different reasons. On my computer the tests failing are
Failed tests:
  AccumuloReloadingVFSClassLoaderTest.testReloading:127
  ContextManagerTest.differentContexts:121

but I'm quite sure I didn't change anything related. I usually would fix the problems before submitting the code but I'm clueless. Can somebody with better knowledge of the project what is wrong with this PR and why those tests fail? The error that is printed is: org.apache.accumulo.start.classloader.vfs.ContextManagerTest.differentContexts(ContextManagerTest.java:121).

Tests are failing on both Travis and my computer but for different reasons. On my computer the tests failing are

I'd agree with you that these are unrelated to your changes. Just ignore them for now -- we'll have to figure out why they're busted (again).

I left a few more comments on trivial things (doc cleanup, primarily), but I like how this is looking! I'm running it through a mvn verify -Psunny locally and would be in favor of committing this ASAP. Presently, the only branch available to land this in is master because semver prevents us from adding new APIs to 1.8.
@melrief if you can switch the target branch to master, that would be helpful.

Presently, the only branch available to land this in is master because semver prevents us from adding new APIs to 1.8.

@melrief, currently the version in master in 2.0.0-SNAP.  So would need to change the since version in javadocs to 2.0.  I had commented on this earlier and was uncertain, sorry for the confusion.  Not sure why I was uncertain, its really very simple to figure out.

I was able to easily (without conflict) rebase this branch onto master. Let me(us) know if you want to make the rest of the fixes @melrief, otherwise, I can just make them on commit (since they're all rather simple).

I did the rebase and started with the changes but I have to force push it and probably we are going to miss some comments after the push. Are you ok with force pushing the rebase with the changes right now?

Fine by me. I just had the two comments (javadoc cleanup and the unnecessary string->text->bytes conversion). It's all recorded on JIRA for posterity.

Good, done and also change since to 2.0.

I also changed this so that it will be merged in master and not in 1.8.

Good, done and also change since to 2.0.

This looks good. One last thing is the assertSame() call. Want to fix that too? I am also ok fixing on that local commit.

I'll have to wait tomorrow but if you want to do it you are welcome :).

I'll have to wait tomorrow but if you want to do it you are welcome :).

Superb. I'm running the tests now, and will hopefully commit tonight.

Nice, thanks everybody!


Add integration test for unknown OB length

This test makes use of a DICOM file that was originally from pydicom that contains an OB field with unknown length.
This makes use of the dicom-test-files crate that provides access to
DICOM files that can be used for testing across different DICOM readers.

I will take the liberty of applying minor changes later. Thank you again, @robyoung.


Update coq 8.18 with commits from 8.17

I thought the point of testing the quick target was not that it was faster but to make sure it didn't break (b/c of universes or similar).  Was I guessing wrong?  (It definitely caught a breakage when I was preparing quotation)


Move Trivia from gyb to code gen

There is an error when generating Swift/Character.swift:177: Fatal error: Can't form a Character from a String containing more than one extended grapheme cluster

There is an error when generating Swift/Character.swift:177: Fatal error: Can't form a Character from a String containing more than one extended grapheme cluster

in SyntaxSupport/gyb_generated/Trivia.swift, you have Character(#"\t"#). Because of the # it’s a raw string literal and thus \t is interpreted as two characters, the backlash and t. Thus you can’t form a character from it. If you change it to Character("\t"), you get the literal tab character, which works.

@swift-ci please test

@swift-ci please test

@swift-ci please test

Depends on #1258

@swift-ci please test


API: support generate KCL configuration and schema from json/yaml

Feature Request
Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

provide APIs to generate KCL configuration from json/yaml/...
from json/yaml/... data representation and the schema definition
name: "demo"
mainContainer:
  name: "main"
  image: "image-ns:tag"
replicas: 1

schema Server:
    name: str
    mainContainer: Container
    replicas: int = 1

schema Container:
    name: str
    image: str

to kcl configuration: (the variable name appConfiguration is passed from API args)
appConfiguration: Server {
    name: "demo"
    mainContainer: {
        name: "main"
        image: "image-ns:tag"
    }
    # if the configuration value is exactly the same as the default value, the configuration could be omited
    # replicas: 1
}

Describe alternatives you've considered:

directly assign the json format data to the variable, then call the KclvmService.FormatCode API:
appConfiguration: Server {
    "main": "demo",
    "mainContainer": {
        "name": "main",
        "image": "image-ns:tag"
    },
    "replicas": 1
}

Teachability, Documentation, Adoption, Migration Strategy:

This is a great enhancement that requires unified consideration of other data (protobuf/openapi/yaml/json/teraform schema/...) integration interfaces in both the CLI and API interfaces, such as the cue import tool:

From data to KCL config
Infer data to KCL schema
Other schemas to KCL schemas
...

Additionally, note that there are some incompatibilities between JSON and KCL Config in the alternative solutions, e.g., null/None, true/True, false/False

I would also add another behaviour as a requirement which currently the cue import donest do.
Eg the provided json/yaml file ends up becoming non-mutable values in the generated config, for usecases where we want to override yamls from helmcharts or other sources, it would be nice to be able to mutate some of the values.
eg,
upsterem image url, would need to be able to mutate to something we want to change.
In the current Cue import behaviour this is not allowed, so one needs to modify the generate file which makes it hard to maintain. With jsonnet since it let's you mutate everything, the overrides and patches are defined sperately and the generated file can be regenerated safely.

I would also add another behaviour as a requirement which currently the cue import donest do.
Eg the provided json/yaml file ends up becoming non-mutable values in the generated config, for usecases where we want to override yamls from helmcharts or other sources, it would be nice to be able to mutate some of the values.
eg,
upsterem image url, would need to be able to mutate to something we want to change.
In the current Cue import behaviour this is not allowed, so one needs to modify the generate file which makes it hard to maintain. With jsonnet since it let's you mutate everything, the overrides and patches are defined sperately and the generated file can be regenerated safely.

❤ Thank you for your reply. I think I have understood your input and we will carefully consider and design for the data  migration and mutation.


Add support for gpuNUFFT

This PR add bindings for gpuNUFFT. however things are (not yet) working:

I had to lower the tolerances on accuracy tests
The adjoint property test is not statified
The data consistency test is not happy (probably a dimension order problem)

Alright, this is ready to review @chaithyagr. I added some instruction to install your fork, while we wait for it to be merged upstream.


Drop toOption from PlainResult/index

Fix #1568
Migration Note
If user use toOptionFromOk or toOptionFromErr from option-t/PlainResult, then they need to replace it with import { toOptionFromOk, toOptionFromErr  } from 'option-t/PlainResult/toOption';

Done by #1623


Migrating from Foxy to Galactic

Migrating from Foxy to Galactic
Add missing updates from #133

Replaces #137
@liushuya7 sorry I did mistake by force-pushing to your branch and now opened this PR.

@bailaC can you also check this one?

Rolling Binary is expected to fail until the ros2_control packages are released.

Codecov Report

Merging #138 (b06bbe2) into master (37b1c9c) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head b06bbe2 differs from pull request most recent head e6f3bfe. Consider uploading reports for the commit e6f3bfe to get more accurate results

@@           Coverage Diff           @@
##           master    #138    +/-   ##
=======================================
  Coverage    0.00%   0.00%
=======================================
  Files           8       4     -4
  Lines         756     381   -375
=======================================
+ Misses        756     381   -375

Flag
Coverage Δ

unittests
0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...l_demo_hardware/src/rrbot_system_position_only.cpp

...demo_hardware/src/rrbot_system_multi_interface.cpp

...rol_demo_hardware/src/rrbot_system_with_sensor.cpp

...rol_demo_hardware/src/rrbot_system_with_sensor.cpp

.../ros2_control_demo_hardware/src/diffbot_system.cpp

.../ros2_control_demo_hardware/src/diffbot_system.cpp

...l_demo_hardware/src/rrbot_system_position_only.cpp

...demo_hardware/src/rrbot_system_multi_interface.cpp

...l_demo_hardware/src/rrbot_system_position_only.cpp
0.00% <0.00%> (ø)

.../ros2_control_demo_hardware/src/diffbot_system.cpp
0.00% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b1c9c...e6f3bfe. Read the comment docs.


Implement IntegerArray

Fixes #25.

OK, there's a weird corner case in integer array indexing that currently fails the tests here. Integer indices on empty arrays sometimes do not give out of bounds IndexErrors. NumPy is deprecating this behavior, but the deprecation won't be live until 1.20 (https://github.com/numpy/numpy/pull/15900).
I would like to make ndindex follow any post-deprecation warning behavior for NumPy, since that leads to a cleaner API. But it will not be straightforward to tests against this until 1.20 is released. I don't know how often NumPy does major releases. If it comes around that everything else here is ready except for that, I will just code in the 1.19 behavior and update it later.

FYI, the 1.20 release for NumPy is about 6 months away.

Thanks. I didn't know there was a schedule. For now I have just emulated 1.19 behavior. I will update it once 1.20 is out, which will be a minor compatibility break, but I think it isn't a big deal.

I think it would be good to review and merge this as it is. There are still a lot of things that aren't yet implemented, like as_subindex for IntegerArray, and Tuples of IntegerArrays, but those will be more work and it might be cleaner to do them as separate PRs.


docs: add code of conduct, contributing, and update dev guide

Closes #19

@brettstack Here is the walkthrough video you demoed today - https://www.youtube.com/watch?v=wAPUb0P5quY
Please add to your dev guide (if possible as iFrame so it renders on Github) so others can benefit from the explanation when they get started on this project. Once the project is more mature, we can do another walkthrough and update the video here.

@brettstack Here is the walkthrough video you demoed today - https://www.youtube.com/watch?v=wAPUb0P5quY
Please add to your dev guide (if possible as iFrame so it renders on Github) so others can benefit from the explanation when they get started on this project. Once the project is more mature, we can do another walkthrough and update the video here.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


1.20 Incompatibility with Better Impaling (A trident mod)

https://gist.github.com/RiginDev/e0a1f9094ec0251a9e592d12c2102b79
It's an expected error since Fabrication does mess with trident mechanics like this mod, but if it's possible to fix (this was the weirdest crash log I've ever seen), it would be nice

as far as i can tell at a grance that mod does the same thing as balance.bedrock_impaling i'm guessing that's what's causing the issue so either set bedrock_impaling to banned for now or if possible use the fabrication feature instead
reason why the crash log is cursed is because i hacked together a injection that does improve compatability for some features but also makes terrible mistakes sometimes, although i thought i'd fixed most of these, i'll take a look at what i missed this time

Yeah removing better impaling is best since Fabrication does that and more! Thx!


mark the just processed message before commit offset

avoids redundant commiting and double processing on crash

:heart:


Demo doesn't work in IE9

On http://yuche.github.io/vue-strap/
IE9 throws error (while IE10+ works ok)
SCRIPT87: Invalid argument
vue.min.js (xxx:xxx)

@ipa1981 I find that it doesn't work in IE9 too.....


Upgrade to cilium v1.12.2

Signed-off-by: Waleed Malik<EMAIL_ADDRESS>
What this PR does / why we need it:
Upgrade to cilium v1.12.2.
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?

/kind feature
Special notes for your reviewer:
This is a pre-requisite for https://github.com/kubermatic/kubeone/issues/2223
Does this PR introduce a user-facing change? Then add your Release Note here:

Upgrade to cilium v1.12.2

Documentation:

NONE

/test pull-kubeone-e2e-aws-default-cilium-containerd-v1.22.12

Something seems broken, I'll try to reproduce this locally.

@ahmedwaleedmalik It's expected that the Cilium job fails. Some conformance tests are failing, but that's a known issue in Cilium. See the following tickets for more details:

https://github.com/cilium/cilium/issues/14287#issuecomment-1192288840
https://github.com/cilium/cilium/issues/12116

We can't do much about that besides eventually skipping those tests.
That said...
/override pull-kubeone-e2e-aws-default-cilium-containerd-v1.22.12

/hold

/unhold

/cherrypick release/v1.5


Introduce key/value store interface + cm backed version of it.

Especially in sources you might need to checkpoint work, or save some other state. Introduce a key/value store that's backed by ConfigMap to make it easier to work with that state.

Out of the gate with 91% code coverage.
/LGTM


Code quality fix - Classes and methods that rely on the default system encoding should not be used.

This pull request is focused on resolving occurrences of Sonar rule
squid:S1943 - Classes and methods that rely on the default system encoding should not be used.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1943
Please let me know if you have any questions.
Faisal Hameed

I've manually merged this one.


Please remove ddev-get "topic"

Hi @torenware - It looks like this isn't getting any love at this point. Could you please remove the "ddev-get" label from it so it doesn't get discovered by people looking for a maintained add-on?
Thanks!
Thanks for exploring this territory.
If you think it would be good to archive this repo, please do that after adding a link on the top of the README to https://ddev.com/blog/working-with-vite-in-ddev/

Sorry for the delay in handling this; I've been unable to give time to this project for some time, as you've figured. I've removede the topic, and will update the read-me once I'm settled on this new laptop.


max_in_flight setting not being honoured

I have an instance group (runner) with 8 instances spread across 4 AZs, and I'm overriding the max_in_flight for this instance group to 4 (the global is 1).  However, when I bosh deploy I see it's only doing 2 at a time.
logs-and-manifest.tar.gz

I believe what you're seeing is expected behaviour. Not sure if docs need to updated to reflect this?
When updating an instance group, director does one AZ at a time and waits for that AZ to finish before moving to the next. So max_in_flight is effectively max(instances-in-az, coalesce(instance_group.update.max_in_flight, deployment.update.max_in_flight)); in your case 2.

@Amit-PivotalLabs not sure if you are proposing to disregard AZ isolation. this somewhat follows the current behavior with max_in_flight + z1/zx splits.

Closing. Currently works as desired.


[LLC] Resolve issue of subclient naming

See: https://github.com/Azure/autorest.csharp/pull/1548#discussion_r724589632

Yes


Remove top-level container from DOM when removing fronts-banner ad

What does this change?

Removes the top-level ad container from the DOM when removing a fronts-banner advert
Adds a test

Why?

The top-level ad container has a minimum height on it to prevent layout shift, so we need to remove this too when removing a fronts-banner advert

Screenshots
Before
https://github.com/guardian/commercial/assets/9574885/22e2dd0c-35dc-459d-9a16-c8a647172062
After
https://github.com/guardian/commercial/assets/9574885/5df91746-db79-477c-bffb-15ae58ac6256

Nice!
I was wondering recently why removing slots is necessary, I would have thought display: none; might suffice, as removing the slot from googletag and the dom makes debugging more difficult when we're not sure why an ad is not showing.

I think that makes a lot of sense. We destroy the slot here and remove the advert from our internal dfpEnv object, so there should be no difference between hiding and removing the slot. Hiding would give us more debugging power as you say, so should be the better option. Maybe create a ticket to investigate this further?


start scene - fix an edge case

It seems like I am now unable to start a terminal at all on my device.

This can happen if you e.g. place your cursor here:

class SquareToCircle(Scene):
    def construct(self): <--- here, on the `construct` method
        <--- or here, on empty lines just after the line with `construct` method
        <--- or here
        <--- or here
        ## Set up
        circle = Circle()
        circle.set_fill(BLUE, opacity=0.5)
        circle.set_stroke(BLUE_E, width=4)
        square = Square()

(the reason: the command manimgl ... -se <this line number> itself doesn't work with these line numbers)

The this is easy - we just need to add this logic to startStopScene.ts
(I just overlooked this edge case when I wrote that.)

For example, what to do in this case:
currently: if empty lines - we check up 1 by 1
if we meet the construct method -> insert a next line and start there, e.g.:
        # -- manim-notebook VSCode extension: this comment was inserted automatically to start right after the "construct" method --

I'm a bit confused, why is this? The manimgl cmd only adds the self.embed() method underneath the current line...
Is it because self.embed() is inserted without correct tab spacing under the construct() method? I would be that Grant implemented an insertion that simply copied the indent of the preceding line when inserting self.embed()

I don't really know why their command doesn't support that,
but we operate on an abstraction layer which uses their commands, we don't modify them

Do we really want to "fix" this? I mean we have identified that this has nothing to do with us, it's just a limitation of the underlying manimgl command that it can't start the scene at these lines. So ideally, we would fix this upstream at Manim such that it also works if you just use the command line.
Of course, for a better user experience with our extension, we could detect this case and show an error notification (instead of letting the user baffled with a cryptic error message in the terminal). In such an error notification, we could even link to an open Manim issue we have opened by then. What do you think about this?

I can easily do it - after finishing with you active codebase changes

reason for closing:
decided no to edit the user's file


Darin Pope contributor spotlight

Please do not merge this PR before July 30.

Looking forward to seeing this PR gets merged @alyssat later today!

Is some other change needed in order to make this contributor spotlight visible?  When I open https://contributors.jenkins.io/ I see that the spotlight of Markus Winter is on the root page and that Darin Pope is not listed anywhere on the page.

I think we may need to contact the Infra team regarding this deployment

Thanks @krisstern .  I've opened:

https://github.com/jenkins-infra/helpdesk/issues/4207

Nodejs install failed, a build restart should be enough. @MarkEWaite can you trigger a new build?

Nodejs install failed, a build restart should be enough. @MarkEWaite can you trigger a new build?

Thanks. New build has been triggered: https://github.com/jenkins-infra/helpdesk/issues/4207#issuecomment-2260191992
Note that https://github.com/jenkins-infra/contributor-spotlight/pull/169#pullrequestreview-2209789467 was also merged, we'll see the results

Last build was successful and deployed the website (ref. https://github.com/jenkins-infra/helpdesk/issues/4207#issuecomment-2260239215).


Updates changelog after 3.2.1 release

Followup from #2352.

          1 Error

:no_entry_sign:
You need to set the App’s plist version to 3.2.2

  Generated by :no_entry_sign: Danger

Awww snap. Thanks Danger.


Tyson redis encapsulation

Encapsulated redis database.
No functionality changed.
Is this a good way of doing this? Appreciate any feedback.

Closing.