error with peer c871d11439f226281bec0f1ae7a81984de2df30c: peer did not send us anything

While syncing testnet data, the following error happened:
10:57PM INF committed state app_hash=D508E26B2702BA3052020FE8D3FCF6BB20C4BB5589CD0C9D85D19A4A77EAF555 height=18227 module=state num_txs=0
10:57PM INF indexed block height=18227 module=txindex
10:57PM INF minted coins from module account amount=21063460316073377727FX from=mint module=x/bank
10:57PM INF executed block height=18228 module=state num_invalid_txs=0 num_valid_txs=0
10:57PM INF commit synced commit=436F6D6D697449447B5B3136352039312032303420323033203137302032343120383420393320373120383220313933203236203234372032303920313332203233352037342031373320342032353220313837203234372036392032203133332032303120363320343120393720313633203133312039375D3A343733347D
10:57PM INF committed state app_hash=A55BCCCBAAF1545D4752C11AF7D184EB4AAD04FCBBF7450285C93F2961A38361 height=18228 module=state num_txs=0
10:57PM ERR SendTimeout module=blockchain peer=c871d11439f226281bec0f1ae7a81984de2df30c reason="peer did not send us anything" timeout=15000
10:57PM ERR Stopping peer for error err="error with peer c871d11439f226281bec0f1ae7a81984de2df30c: peer did not send us anything" module=p2p peer={"Data":{},"Logger":{}}
10:57PM INF Stopping MConnection service impl={"Logger":{}} module=p2p peer={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656}
10:57PM ERR Stopping peer for error err="read tcp <IP_ADDRESS>:45068-><IP_ADDRESS>:26656: use of closed network connection" module=p2p peer={"Data":{},"Logger":{}}
10:57PM INF Stopping Peer service impl={"Data":{},"Logger":{}} module=p2p peer={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656}
10:57PM ERR error while stopping peer error="already stopped" module=p2p
...
10:57PM ERR SendTimeout module=blockchain peer=cb9e91758f5ee581607b7099531845416cf1ab16 reason="peer did not send us anything" timeout=15000
10:57PM ERR Stopping peer for error err="error with peer cb9e91758f5ee581607b7099531845416cf1ab16: peer did not send us anything" module=p2p peer={"Data":{},"Logger":{}}
10:57PM INF Stopping MConnection service impl={"Logger":{}} module=p2p peer={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656}
10:57PM ERR Stopping peer for error err="read tcp <IP_ADDRESS>:59926-><IP_ADDRESS>:26656: use of closed network connection" module=p2p peer={"Data":{},"Logger":{}}
10:57PM INF Stopping Peer service impl={"Data":{},"Logger":{}} module=p2p peer={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656}
10:57PM ERR error while stopping peer error="already stopped" module=p2p
...
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=pex
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=pex
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=pex
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"275f616954e149076b4eb1f726c44e9722ae00b6","ip":"<IP_ADDRESS>","port":26656} module=pex
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"d2c3c6cec4c4412fcb70131574480db6819c65b9","ip":"<IP_ADDRESS>","port":26656} module=pex
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=pex

then the sync process stopped.
Any suggestion why this happened and how to deal with this? Maybe there is some faulty peers in the network or firewall issues?

I've updated container image with testnet fixes as per GH-11, loaded data from the snapshot (2021-10-11), it's showing now testnet network correctly, but the above errors are still there:
3:27PM INF Ensure peers module=pex numDialing=0 numInPeers=0 numOutPeers=0 numToDial=30
3:27PM INF Will dial address addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM INF Will dial address addr={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM INF Will dial address addr={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM INF Will dial address addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM INF Dialing peer address={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:27PM INF Dialing peer address={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:27PM INF Dialing peer address={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:27PM ERR dialing failed (attempts: 7): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM ERR dialing failed (attempts: 7): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM ERR dialing failed (attempts: 7): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM INF Dialing peer address={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:27PM INF Error reconnecting to peer. Trying again addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} err="dial tcp <IP_ADDRESS>:26656: i/o timeout" module=p2p tries=4
3:28PM INF Dialing peer address={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:28PM INF Error reconnecting to peer. Trying again addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} err="dial tcp <IP_ADDRESS>:26656: i/o timeout" module=p2p tries=3
3:28PM INF Ensure peers module=pex numDialing=0 numInPeers=0 numOutPeers=0 numToDial=30
3:28PM INF Will dial address addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Dialing peer address={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:28PM ERR dialing failed (attempts: 7): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Ensure peers module=pex numDialing=0 numInPeers=0 numOutPeers=0 numToDial=30
3:28PM INF Will dial address addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=pex

Is it possible that other testnet peers blacklisted my node for requesting mainnet data due to wrong container image?

While syncing testnet data, the following error happened:
10:57PM INF committed state app_hash=D508E26B2702BA3052020FE8D3FCF6BB20C4BB5589CD0C9D85D19A4A77EAF555 height=18227 module=state num_txs=0
10:57PM INF indexed block height=18227 module=txindex
10:57PM INF minted coins from module account amount=21063460316073377727FX from=mint module=x/bank
10:57PM INF executed block height=18228 module=state num_invalid_txs=0 num_valid_txs=0
10:57PM INF commit synced commit=436F6D6D697449447B5B3136352039312032303420323033203137302032343120383420393320373120383220313933203236203234372032303920313332203233352037342031373320342032353220313837203234372036392032203133332032303120363320343120393720313633203133312039375D3A343733347D
10:57PM INF committed state app_hash=A55BCCCBAAF1545D4752C11AF7D184EB4AAD04FCBBF7450285C93F2961A38361 height=18228 module=state num_txs=0
10:57PM ERR SendTimeout module=blockchain peer=c871d11439f226281bec0f1ae7a81984de2df30c reason="peer did not send us anything" timeout=15000
10:57PM ERR Stopping peer for error err="error with peer c871d11439f226281bec0f1ae7a81984de2df30c: peer did not send us anything" module=p2p peer={"Data":{},"Logger":{}}
10:57PM INF Stopping MConnection service impl={"Logger":{}} module=p2p peer={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656}
10:57PM ERR Stopping peer for error err="read tcp <IP_ADDRESS>:45068-><IP_ADDRESS>:26656: use of closed network connection" module=p2p peer={"Data":{},"Logger":{}}
10:57PM INF Stopping Peer service impl={"Data":{},"Logger":{}} module=p2p peer={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656}
10:57PM ERR error while stopping peer error="already stopped" module=p2p
...
10:57PM ERR SendTimeout module=blockchain peer=cb9e91758f5ee581607b7099531845416cf1ab16 reason="peer did not send us anything" timeout=15000
10:57PM ERR Stopping peer for error err="error with peer cb9e91758f5ee581607b7099531845416cf1ab16: peer did not send us anything" module=p2p peer={"Data":{},"Logger":{}}
10:57PM INF Stopping MConnection service impl={"Logger":{}} module=p2p peer={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656}
10:57PM ERR Stopping peer for error err="read tcp <IP_ADDRESS>:59926-><IP_ADDRESS>:26656: use of closed network connection" module=p2p peer={"Data":{},"Logger":{}}
10:57PM INF Stopping Peer service impl={"Data":{},"Logger":{}} module=p2p peer={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656}
10:57PM ERR error while stopping peer error="already stopped" module=p2p
...
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=pex
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=pex
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=pex
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"275f616954e149076b4eb1f726c44e9722ae00b6","ip":"<IP_ADDRESS>","port":26656} module=pex
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"d2c3c6cec4c4412fcb70131574480db6819c65b9","ip":"<IP_ADDRESS>","port":26656} module=pex
1:26PM ERR dialing failed (attempts: 6): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=pex

then the sync process stopped.
Any suggestion why this happened and how to deal with this? Maybe there is some faulty peers in the network or firewall issues?

The node information shown here is indeed provided by us. We are also surprised by the occurrence of timeout, we are looking for the problem
You can try to check whether the current node is synchronizing data through the following command, execute it every 5 seconds, and observe whether there is a change in sync_info.latest_block_height
ubuntu@ip-192-168-98-202:~$ curl -s http://<IP_ADDRESS>:26657/status
{
  "jsonrpc": "2.0",
  "id": -1,
  "result": {
    "node_info": {
      "protocol_version": {
        "p2p": "8",
        "block": "11",
        "app": "0"
      },
      "id": "12e5f084644059a360452ac1c1cb73d775434095",
      "listen_addr": "tcp://<IP_ADDRESS>:26656",
      "network": "fxcore",
      "version": "v0.34.9",
      "channels": "40202122233038606100",
      "moniker": "your-moniker",
      "other": {
        "tx_index": "on",
        "rpc_address": "tcp://<IP_ADDRESS>:26657"
      }
    },
    "sync_info": {
      "latest_block_hash": "056CFEB2A1351A81A3534BB5F4A691DBC8257AAC2DF3BD0E87B6B81BA60449E5",
      "latest_app_hash": "E2B1352D78B03E48F52F6241960B7337C0BFB0DA258E4DC990B8E4FA3181B78A",
      "latest_block_height": "2109095",
      "latest_block_time": "2021-11-15T02:32:57.688206878Z",
      "earliest_block_hash": "2C70CB931C1D958CDD3D68503CCD5D883D4B29579D9790D3FEF1E13BA45015DC",
      "earliest_app_hash": "E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855",
      "earliest_block_height": "1",
      "earliest_block_time": "2021-07-05T04:00:00Z",
      "catching_up": false
    },
    "validator_info": {
      "address": "CFDA914942E70D821EE91B583CB7711AF00CF7D9",
      "pub_key": {
        "type": "tendermint/PubKeyEd25519",
        "value": "zJYtsWnl3E8AQG2o6j+A99dclZjEVR1R2UV772eVpF0="
      },
      "voting_power": "0"
    }
  }
}

I've updated container image with testnet fixes as per GH-11, loaded data from the snapshot (2021-10-11), it's showing now testnet network correctly, but the above errors are still there:
3:27PM INF Ensure peers module=pex numDialing=0 numInPeers=0 numOutPeers=0 numToDial=30
3:27PM INF Will dial address addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM INF Will dial address addr={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM INF Will dial address addr={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM INF Will dial address addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM INF Dialing peer address={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:27PM INF Dialing peer address={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:27PM INF Dialing peer address={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:27PM ERR dialing failed (attempts: 7): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM ERR dialing failed (attempts: 7): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM ERR dialing failed (attempts: 7): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=pex
3:27PM INF Dialing peer address={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:27PM INF Error reconnecting to peer. Trying again addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} err="dial tcp <IP_ADDRESS>:26656: i/o timeout" module=p2p tries=4
3:28PM INF Dialing peer address={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:28PM INF Error reconnecting to peer. Trying again addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} err="dial tcp <IP_ADDRESS>:26656: i/o timeout" module=p2p tries=3
3:28PM INF Ensure peers module=pex numDialing=0 numInPeers=0 numOutPeers=0 numToDial=30
3:28PM INF Will dial address addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Dialing peer address={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=p2p
3:28PM ERR dialing failed (attempts: 7): dial tcp <IP_ADDRESS>:26656: i/o timeout addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Ensure peers module=pex numDialing=0 numInPeers=0 numOutPeers=0 numToDial=30
3:28PM INF Will dial address addr={"id":"cb9e91758f5ee581607b7099531845416cf1ab16","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"43b849debb6e2b5ffed246b76da0a7a93d14bb84","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"eef28254833827b4ff0e43d78d6a0ff81a41bbd0","ip":"<IP_ADDRESS>","port":26656} module=pex
3:28PM INF Will dial address addr={"id":"c871d11439f226281bec0f1ae7a81984de2df30c","ip":"<IP_ADDRESS>","port":26656} module=pex

Is it possible that other testnet peers blacklisted my node for requesting previously invalid network data (mainnet instead of testnet) due to wrong container image? Because of that, my node cannot sync any new data.

The node information shown here is not provided by us. It may be a node run by others in the community. Maybe you can try to pause the node first, then rm .fxcore/config/addrbook.json to start the node again

The node information shown here is not provided by us. It may be a node run by others in the community. Maybe you can try to pause the node first, then rm .fxcore/config/addrbook.json to start the node again

I've tried to remove addrbook.json, but it didn't help much, after restart it was the same.
At the end I did another resync from scratch and it worked on its own.


pull request for e2e test at 12/21/2016 15:56:24

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix travis build

Node version was too old. Grafana requires 0.12, so use 0.12
Remove usage of string.startsWith (ES2015 - apparently not supported)

Note, I'm not 100% sure why "startsWith" doesn't work in travis build. I was assuming that using babel made us compliant with ES2015, but it seems there's still some interferences....

Thanks @jotak

PS: I thought we would get rid of the question mark at the beginning of the query string :wink:

How, yes I forgot that
Next time, I'll try not to forget :)


Songs with multiple artists giving wrong lyrics

Many songs with multiple artists are showing lyrics from some other song or none at all, see examples below
No lyrics:
Aici cu mine by Proconsul, Stefan Banica, Andra
Wrong lyrics:
Salut! Ce Faci? by Directia 5, Nicoleta Nuca
Mai sus by Stela Botan, Paralela 47
Mama by F.Chart, Elena Gheorghe
Karma by Leya D, Kalif

The first three I think just aren't on any of the lyric sites the program fetches from. (at least I couldn't find them when I looked manually, let me know if you could find them though) So it may just be getting the best match it can find which would obviously be wrong.
The last two it seems to be finding the correct lyrics for me. It displays the lyrics from these pages:
https://www.musixmatch.com/lyrics/F-Charm-feat-Elena-Gheorghe/Mama
https://www.musixmatch.com/lyrics/Leya-D-feat-Kalif/Karma
(you can click on the song name to see where the lyrics are coming from)
So it seems the problem is actually the sites that the program fetches from just don't have the lyrics.
If you know of another site for fetching lyrics that would have these songs (and perhaps more), I could see about adding it though.

Thanks for your quick response! The two you found also work for me now, hadn't noticed the 1.09 version release.
The others are available at versuri.ro, would be great to have that one included!

I added versuri as a provider in 1.10.
https://github.com/fr31/spotifylyrics/releases

Awesome, thanks!

Seems common for songs in another language than English to add English title as part of the song. Lyrics fetch fine in the songs I've seen this when the English title is encapsulated in parentheses but when separated by a front slash "/" it does not. The song Voltaj - Povestea oricui / Anybody's story does not give lyrics from below link.
http://www.versuri.ro/versuri/jeig_voltaj-povestea-oricui.html
Small detail and maybe uncommon in general though.

I'll see what I can do about that this weekend.

@Shanamaj the issue should be fixed in the latest release.

Works perfectly, thanks!


Ability to pick where template goes in file

Hi! Been enjoying using your plugin. I was wondering if there is a way to pick where the template will insert into my daily note. For example, I'd like it to always be on line 6 for consistency between entries. I'm new to Obsidian, so I wasn't sure if there was something I could do on my end for that, but if not, consider this a feature request. :]
Thank you!

@angiioh hey there! It's definitely on the list, but I can't give any ETA :)

Awesome, no worries. I'm essentially trying to recreate my livejournal from 20 years ago with the mood picker, so it's not exactly a pressing matter, haha. Thanks!


wip: Application Configuration

https://github.com/fermyon/spin/blob/950e8c64a8155c4599d9c32150af6566096fed0b/examples/wip-appconfig/spin.toml#L8-L17
https://github.com/fermyon/spin/blob/950e8c64a8155c4599d9c32150af6566096fed0b/examples/wip-appconfig/src/lib.rs#L14-L19
$ curl <IP_ADDRESS>:3000/hello
Hello, Fermyon

$ SPIN_APP_NAME=Local spin-release up

$ curl <IP_ADDRESS>:3000/hello
Hello, Local

I think this is enough for an MVP. There is one hard-coded config provider (EnvProvider, which understands SPIN_APP_<KEY>).


chore: remove @babel/plugin-transform-destructuring plugin

Summary:

Hermes in<EMAIL_ADDRESS>appears to support destructuring natively. The babel preset only removes the plugin if running Hermes canary, which doesn't seem to be needed anymore.
Caniuse indicates that JSC has supported all destructuring features since iOS 11.3 (we're on ~13) https://caniuse.com/?search=destructuring
@babel/preset-env with reasonably modern defaults doesn't apply this transform anymore repl. (This is for web / Node.js support since we reuse the babel preset in Expo CLI).
Original discussion https://discord.com/channels/514829729862516747/896089100199788604/1222231550456893563

Changelog:
[GENERAL] [BREAKING] - Remove @babel/plugin-transform-destructuring transform ([a, b, ...c]) from all platforms and engines.

Test Plan:

I removed the plugin in an Expo SDK 50 project (code<EMAIL_ADDRESS>-> delete plugin).
I added a const [index, setIndex, ...foo] = React.useState(0); to the code to ensure at least one instance of destructuring (there are many throughout the default modules though).
Then ran with a clear metro cache (npx expo start -c) on iOS, Android, web, Node.js (Expo Router).
Also ran clean cache against JSC / Hermes (changing jsEngine in the app.json).
I verified by pulling the source from the browser that the transform wasn't being applied anywhere, e.g. http://localhost:8081/node_modules/expo/AppEntry.bundle?platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&app=com.bacon.mar26&transform.routerRoot=app&transform.engine=hermes&transform.bytecode=true

Source looked like: var [index, setIndex, ...foo] = (0, _react.useState)(0); (modifications primarily coming from @babel/plugin-transform-modules-commonjs and @babel/plugin-transform-block-scoping).

Built a bare app on iOS just to confirm no differences in behavior.
Then I ran a script against the Hermes bin just to be absolutely sure no errors would arise against Hermes: ./ios/Pods/hermes-engine/destroot/bin/hermes ./foo.js where foo.js contained:

const [a, b, ...c] = (() => [0, 1])();

Sharing with permission from @tmikov:

In principle, we would very much like to remove this transform.
In practice, unfortunately Hermes hasn't been widely tested with "native" destructuring, we have never shipped it with RN, since the transform has always been active. So, there is risk. If there are bugs, they will be discovered in Hermes, and Hermes has been frozen for quite some time, while we are working on Static Hermes. So, such bugs will be very painful to fix.
OTOH, Static Hermes will support tons of ES6+ features natively, like classes, block scoping, etc, and we will be removing lots of transforms there anyway.
I think ideally I would prefer to keep the transform as is for now, until we release Static Hermes as a drop-in (but much better) replacement for Hermes.

I noticed today 7 packages that need attention:
<EMAIL_ADDRESS>-> @babel/plugin-transform-nullish-coalescing-operator
<EMAIL_ADDRESS>-> @babel/plugin-transform-numeric-separator
<EMAIL_ADDRESS>-> @babel/plugin-transform-optional-catch-binding
<EMAIL_ADDRESS>-> @babel/plugin-transform-class-properties
<EMAIL_ADDRESS>-> @babel/plugin-transform-object-rest-spread
<EMAIL_ADDRESS>-> @babel/plugin-transform-optional-chaining
<EMAIL_ADDRESS>-> @babel/plugin-transform-async-generator-functions

The Expo E2E tests discovered a missing feature in Hermes destructuring implementation: https://github.com/expo/expo/pull/27885#issuecomment-2023393600
error: Destructuring in catch parameters is currently unsupported

Which comes from:
try {

} catch ({ message }) {

}

We'll just disable the transform when targeting web/server environments, which can be done in expo/expo.


At follows flutter template to trunk

- What I did

Added sample from at_widgets repository

Added at_follows_flutter

Added json-schemas for brick.yaml and pubspec.yaml to make template maintenance easier

- How I did it

Copied the lib folder from at_widgets repository, wrote the necessary config files
Built and bundled at_app

- How to verify it

Pull this branch
List the samples with dart run at_app/bin/at_app.dart create --list-samples
Run dart run at_app/bin/at_app.dart create -s at_follows_flutter<path/to/output>
Run generated sample app and verify that it work

- Description for the changelog
Added at_follows_flutter sample to trunk

For now after app build with
$ dart pub global run melos run build:generated -- sample at_follows_flutter
Like a "file_saver" package,
"share_plus" package must be added as a dependency overrides into pubpsec.yaml of builded app like this:
dependency_overrides:
  at_app_flutter:
    path: ../../../packages/at_app_flutter
  file_saver:
    git:
      url: https://github.com/incrediblezayed/file_saver.git
      ref: main
  share_plus:
    git:
      url: https://github.com/fluttercommunity/plus_plugins.git
      path: packages/share_plus/share_plus/
      ref: main

For now after app build with $ dart pub global run melos run build:generated -- sample at_follows_flutter
Like a "file_saver" package, "share_plus" package must be added as a dependency overrides into pubpsec.yaml of builded app like this:
dependency_overrides:
  at_app_flutter:
    path: ../../../packages/at_app_flutter
  file_saver:
    git:
      url: https://github.com/incrediblezayed/file_saver.git
      ref: main
  share_plus:
    git:
      url: https://github.com/fluttercommunity/plus_plugins.git
      path: packages/share_plus/share_plus/
      ref: main

Please explain further, why this dependency override is required.

I was getting this error without share_plus package
`e: C:\src\flutter\flutter.pub-cache\git\plus_plugins-ca6f0d95cff4435608679f66da374a126979a600\packages\share_plus\share_plus\android\src\main\kotl
in\dev\fluttercommunity\plus\share\MethodCallHandler.kt: (9, 16): Redeclaration: MethodCallHandler
e: C:\src\flutter\flutter.pub-cache\git\plus_plugins-ca6f0d95cff4435608679f66da374a126979a600\packages\share_plus\share_plus\android\src\main\kotl
in\dev\fluttercommunity\plus\share\Share.kt: (19, 16): Redeclaration: Share
e: C:\src\flutter\flutter.pub-cache\git\plus_plugins-ca6f0d95cff4435608679f66da374a126979a600\packages\share_plus\share_plus\android\src\main\kotl
in\dev\fluttercommunity\plus\share\ShareFileProvider.kt: (10, 7): Redeclaration: ShareFileProvider
e: C:\src\flutter\flutter.pub-cache\git\plus_plugins-ca6f0d95cff4435608679f66da374a126979a600\packages\share_plus\share_plus\android\src\main\kotl
in\dev\fluttercommunity\plus\share\SharePlusPlugin.kt: (10, 7): Redeclaration: SharePlusPlugin
e: C:\src\flutter\flutter.pub-cache\hosted\pub.dartlang.org\share_plus-3.1.0\android\src\main\kotlin\dev\fluttercommunity\plus\share\MethodCallHan
dler.kt: (8, 16): Redeclaration: MethodCallHandler
e: C:\src\flutter\flutter.pub-cache\hosted\pub.dartlang.org\share_plus-3.1.0\android\src\main\kotlin\dev\fluttercommunity\plus\share\MethodCallHan
dler.kt: (18, 9): No value passed for parameter 'withResult'
e: C:\src\flutter\flutter.pub-cache\hosted\pub.dartlang.org\share_plus-3.1.0\android\src\main\kotlin\dev\fluttercommunity\plus\share\MethodCallHan
dler.kt: (31, 11): No value passed for parameter 'withResult'
e: C:\src\flutter\flutter.pub-cache\hosted\pub.dartlang.org\share_plus-3.1.0\android\src\main\kotlin\dev\fluttercommunity\plus\share\MethodCallHan
dler.kt: (34, 24): Type mismatch: inferred type is String? but String was expected
e: C:\src\flutter\flutter.pub-cache\hosted\pub.dartlang.org\share_plus-3.1.0\android\src\main\kotlin\dev\fluttercommunity\plus\share\Share.kt: (17
, 16): Redeclaration: Share
e: C:\src\flutter\flutter.pub-cache\hosted\pub.dartlang.org\share_plus-3.1.0\android\src\main\kotlin\dev\fluttercommunity\plus\share\ShareFileProv
ider.kt: (10, 7): Redeclaration: ShareFileProvider
e: C:\src\flutter\flutter.pub-cache\hosted\pub.dartlang.org\share_plus-3.1.0\android\src\main\kotlin\dev\fluttercommunity\plus\share\SharePlusPlug
in.kt: (10, 7): Redeclaration: SharePlusPlugin
e: C:\src\flutter\flutter.pub-cache\hosted\pub.dartlang.org\share_plus-3.1.0\android\src\main\kotlin\dev\fluttercommunity\plus\share\SharePlusPlug
in.kt: (16, 72): No value passed for parameter 'manager'
e: C:\src\flutter\flutter.pub-cache\hosted\pub.dartlang.org\share_plus-3.1.0\android\src\main\kotlin\dev\fluttercommunity\plus\share\SharePlusPlug
in.kt: (17, 42): No value passed for parameter 'manager'
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':share_plus:compileDebugKotlin'.

Compilation error. See log for more details
`

And when i added this package as a normal dependency, there is a dependency conflict between share_plus and at_follows_flutter

@CemTitor this is share_plus version 3, latest is version 4. Have you tried using latest available on pub before using git dependencies?

@XavierChanth  Yes, I tried the latest version. When I pub get with latest version, here is my error:
Running "flutter pub get" in at_follows_flutter...
    Because at_onboarding_flutter >=4.0.1 depends on permission_handler ^9.2.0 and no versions of at_onboarding_flutter match >4.0.0 <4.0.1, at_onboarding_flutter >4.0.0 requires permission_handler ^9.2.0.
(1) So, because at_onboarding_flutter 4.0.0 depends on at_backupkey_flutter ^4.0.0, at_onboarding_flutter >=4.0.0 requires permission_handler ^9.2.0 or at_backupkey_flutter ^4.0.0.

    Because at_backupkey_flutter >=4.0.1 depends on permission_handler ^9.2.0 and no versions of at_backupkey_flutter match >4.0.0 <4.0.1, at_backupkey_flutter >4.0.0 requires permission_handler ^9.2.0.
    And because at_backupkey_flutter 4.0.0 depends on share_plus ^3.0.4, at_backupkey_flutter >=4.0.0 requires share_plus ^3.0.4 or permission_handler ^9.2.0.
    And because at_onboarding_flutter >=4.0.0 requires permission_handler ^9.2.0 or at_backupkey_flutter ^4.0.0 (1), at_onboarding_flutter >=4.0.0 requires permission_handler ^9.2.0 or share_plus ^3.0.4.
    Because no versions of at_follows_flutter match >3.0.7 <4.0.0 and at_follows_flutter 3.0.7 depends on permission_handler ^8.3.0, at_follows_flutter ^3.0.7 requires permission_handler ^8.3.0.
    Thus, if at_follows_flutter ^3.0.7 and at_onboarding_flutter >=4.0.0 then share_plus ^3.0.4.
    And because at_follows_flutter_test_app depends on at_onboarding_flutter ^4.0.0, at_follows_flutter ^3.0.7 requires share_plus ^3.0.4.
    So, because at_follows_flutter_test_app depends on both at_follows_flutter ^3.0.7 and share_plus ^4.0.10, version solving failed.
pub get failed (1;     So, because at_follows_flutter_test_app depends on both at_follows_flutter ^3.0.7 and share_plus ^4.0.10, version solving failed.)
Process finished with exit code 1


Old Saga data don't have "recent" data in at-a-glance, only "Longer".

It's probable that this is because the rsync'd data are a poor fit with the default "recent" window of 30 minutes and less-frequent collection interval on Saga.  But if so, we should perhaps change some of these defaults for Saga.

Fixed by fixing the rsync story.


CASMUSER-3108: Add a known issue to UAIs using a CMN default route

Description
CASMUSER-3108 Add known isssue for UAIs using a CMN default route.
Checklist Before Merging

[ ] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[ ] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport main


Sort using multiple columns

Using v<IP_ADDRESS>
TMM can only sort by a single column, but perhaps there should be a way to sort by multiple columns as well. So, we could first sort by year and for rows that have same year, we could sort by rating etc.

basically it would be possible, but this would break almost every interface for sorting we've implemented.
and since you can achieve almost the same result with a combination of filters and sorting, we won't use our limited time on this.

@mlaggner Okay. Can you please explain how I'll be able to do this via filters?

To achieve almost the same result as sorting by year/rating, you can filter by the year you want to inspect and sort by rating afterwards


Client redesign suggestion

Me and the fellas over at the #development discord channel have come up with a few improvements to the current client UI, these are my proposed changes and I'm open to any suggestions or feedback.
The main client frame
I feel like the current one is too "default-looking" and needs a bit of personality, in all my mockups bellow, a couple of changes I made were:

Having my new and unofficial logo on the top left corner
Having the discord/login/screenshot buttons slightly seperated from the minimize/maximize/close buttons to avoid confusion (This is unfinished as I do not know where to place the buttons)
Darker colors on the top bar and side bar (this improves contrast between client UI and the game itself)
Having the "selected" indicator of the buttons be a slightly darker color behind them

The grand exchange plugin (side panel)
There was nothing wrong with the current version, I just wanted to apply some of the new design rules to make it more modern, get rid of the borders and use different shades of grey for contrast and separation, changes made were:

Material design style tabs
Taller search bar, to give it more room to breathe (and removed border)
Smaller and lighter search icon, just looks better imo
Removed the borders on the ge item results
Smaller and simpler scrolling bar that matches with the rest of the design

The hiscores plugin (side panel)
The hiscores panel had some issues, nothing to big, it just needed to be realigned with my new proposed look, a few changes were made:

Made the search bar more in line with the rest of the dark layout
Moved the account type button to the top, this follows a more logical sequence (Search Name -> Select account type -> View results)
Changed the selection indicator on the buttons to a orange underline
Reduced the size of the font on the skill levels
Removed the bottom information panel as it was occupying a lot of unnecessary space, moving it to a on-hover action, this is also more inline with the current in-game behaviour
Switched the order of the combat/total level indicators, to match the ingame order

The config side panel
Again, I think there is nothing wrong with the configs panel, just changed it a bit to match the rest of the design, changes made were:

Darker colors
New search bar
Removed the square around the buttons, to give it a cleaner look
Added a line separating the configs, just to give them some structure
On the second mockup only: instead of lowering the opacity on the wrench icon, I just removed it
to avoid user confusion

After some discussion on discord, some people asked me to try a material switcher look to the configs, here is that:

The XP Tracker plugin (side panel)
Many people like this plugin as it is, I think it could be better, however I'm not sure I have the solution, either way, here's an attempt:

Made the progress bars have rounded corners
Changed the progress bars' colors to match the skill icon
Changed the skill icon to be darker, so that the level on top of it stands out more
Made the expanded tracker information different, following a "Key: value" structure, keeping the value in white to make it stand out.
Reduced the size of the total exp indicator
Moved the reset all button to the right side

PS: I'd be happy to develop some custom components to help these changes

Personally I like it how it is currently but not like I have anything against your version so if I'm outvoted I won't complain too much =p
As for functionality I really only have one thing that I saw that needs addressing after a quick look through and thats the last thing you posted "XP Trackerplugin". The reset button imo needs to be at the top because if you have enough skills "open" it creates a scroll and I would rather not have to scroll to reset.

In addition to what Stickaplex said, instead of centering the reset all button, you could add another label showing your Total XP gained for this session, and keep the reset on the right if you wanted to

This looks nice

Here be my comments with the perspective of a web developer.
Main client frame:

The logo is more striking and less noisy, I think that's a good thing for recognition. However to my eyes it also looks like a cape or even close to the logo of impactjs http://impactjs.com/ I do like orange and dark neutral though.
Is client version useful to end users? They have to update whenever runescape updates anyway. I say throw this out.
The spacing seems unnaturally decided. I do think it is appropriate to separate these user-actions from the OS controls. Perhaps a horizontal bar between? Or something more fancy like a curve color change for the backdrop--isolating it from the user actions.
This darker color is pleasant.

Grand exchange plugin:

I already like the tab underline / centered styling.
I feel the spacing between the search bar and the tabs is unnatural
The bolded 'whip' text is surprisingly harder to read
It's nice the icons show up..
Do we want to show alc prices when they are zero? (This is probably more change in behavior)
The borders indeed are unnecessary when going more material style.
I like the new scroll bar, it is closer to what discord has as a reference.

Highscores:
Really you should use the same user as a reference so we don't see a difference in data..

I do like the icons having their own boxes for *man mode selection. It also seems appropriate at the top as it changes what you see.
The tooltip seems nice. It is easy on the eyes. Consistency with in game behavior is trippple+++;
I do like the alignment of the total indicators.
The trophy seems more appropriate than an arbitrary blue star.

Config side panel:

Really not sure what is up with this bold font, it is harder to read and makes my eyes want to defocus.
I like the better contrast with the background and the icons.
Should we just not show a wrench when there's no settings, rather than a dimmed wrench?
Line separations does help keep the titles and affordances easier to coordinate. However this is inconsistent with the material design inspired display in the grand exchange plugin

RE: Material switcher
I do like the toggle switches easier. The color difference is nice, though the value needs a bit more work.

XP Tracker plugin

I like these rounded borders.
The colors, like red, yellow, green for the progress complete is kinda odd to me, given it's not like a health thing, and at high levels, the progress is so slow the colors lose their meaning.
Really feeling inconsistent with the plugin panel and the grand exchange plugin panel..
The labels like Actions left: are less important than the values themselves. I look at "651" more than "Actions left". The focus should be on the value, not the label.
I think it is the right move to move the reset button down since it is less used and less important than the progress bars.
Aren't the values displayed under the skill (exp gained ..) attached to the skill? Why is there a separation line of the same color as the background there? It makes it seem cut off, rather than an attached stub.
Not sure what is going on with fonts in these previews, but those numbers seem fuzzy to me.

@Stickaplex I too think there's nothing "too" wrong with the current one, but don't let that ever stop you from trying to improve, if you feel like your attempts were unsucessful, just don't do it :P it's just a suggestion. But I do agree that the reset button should be at the top, I forgot the trackers would stack very high, will update my mockup in a second, thank you!
@LeviSchuck First of all thank you for the compreensive feedback, I have some things to say:
Main client frame:

Please keep in mind this was just a resized png, if the logo suggestion gets approved (currently an issue in the runelite.net project) I will be making a vector version of the logo, so it will look a lot sharper and defined. As for the impactjs, it does look similar, I did not know of that logo but I see the concern.
Okay fair point, agreed.
It does feel unnatural. at first I simply separated them from the others, with the intent of finding a better position later on, and that time never came as I was not sure where to place them, however I did not understand your suggestions, mind showing me a visual example?

Grand exchange plugin:

Upon reviewing, I think you are right, I will try and make it make more sense.
Agreed, will change.
The current version also has the icons, but the API was down when I was putting together this issue so no images were loaded.
I just copied it off the current client, but good question. I have been working with the ge plugin to add some more functionality to it, so I may take a look at this.

Highscores:
Again, the API was down for quite a while so I couldn't get real data, my bad, will update this.

I thought so, makes more sense from a usability stand point
Yea I couldn't really figure out why they were using a blue star.

Config side panel:

I had a few runescape fonts already installed and confused them, I fixed it for some mockups but some have slipped with the old one, will fix.
I also like the icons by themselves, however they were some concerns on discord about it looking like a label instead of a button, so it could happen that users would think of it as a "enabled/disabled" indicator instead of a switch.
That was my suggestion, as you can see by my second mockup I hid the cog for some configs as they were not available, I should probably have made that more apparent, but there was some discussion on discord about it and we couldn't come to agreement on that. (however I agree with you)
You are right, will change.

I did not understand what you mean't by the value.
XP Tracker plugin

Just my thought exactly, but on my example, the colors matches the skills, not the progress itself.
Mind explaining further?
Great point, will change.
See @Stickaplex's comment and it might change your mind, it changed mine.
I do see your point, however I think that considering it's 1px tall and when compared to the rest of the margins of the image, it's reasonable to assume it's attached, just extra information.
Same thing as before, will fix.

The label vs the value

The label is less important than the value, making the value harder to read makes it harder to use.

I understood that, that was your 4th point, I had doubts on the 3rd

The dark theme has too much of "OSBuddy" with itself. Imo if this is being considered, I'd vouch for actually creating your own custom themes / choosing community made themes.

Oh, I see.
Value in the sense of color theory. That's why I put up an image in gray-scale.
http://learn.leighcotnoir.com/artspeak/elements-color/hue-value-saturation/
For those with diminished color reception and for view in the periphery, the value of the toggles needs more contrast.

I suggest making the false value darker

@psikoi I'd agree with the dark theme when the alignments of the icons would change for example:

maybe make them horizontal instead of vertical (I'm talking about the icons on the right bar)
Because right now, it goes too much with the osbuddy theme with the current icons/order/alignment of icons

Updated the first post and applied some of the feedback from this comment section.
Main frame

Deleted the version indicator next to the left side logo.

Ge plugin

Decreased the margin between the search bar and the first result item to be equal to the distance between the tab and the top bar
Improved the font on the "whip" search term
Moved the elements to the right, centering them in relation to the right toolbar, not the scroll bar.
Changed the "before" picture to better represent the current client status

Hiscores plugin

Improved the font on the search bar
Changed the data on both the before and after images to better present the changes
Slightly moved the "2277" total level to the left

Configs plugin

Improved the font
Removed the horizontal lines
On the material version: made the "off" version of the switcher darker

Experience trackers plugin

Created a new total experience area on the top
Moved the reset all button next to the total indicator, to prevent the user from having to scroll down when many trackers are stacked
Changed the indicator's color to grey and the value's color to white on the expanded tracker
Changed the before image to better represent the current client status

Also, another suggestion about the high alch issue, if it's 0, instead display N/A
so it's High alch: N/A instead of High alch: 0

I would love this to be a 2nd optional theme. It looks alot cleaner!

If this will be implemented it will replace the default one.

I really like this, but I don't think this is a priority? However I'd like to see it in the near future.

Well, one of the good things at being open source is that there is infinite number of people who can work on infinite number of things at once :D So, @psikoi working on this one as priority will not slow down any other progress in the client by the slightest.

Just a thought, what about trying to emulate osrs xp tracker? something like

(rs one for reference)

I guess this does make it look eerily similar to konduits

@sethtroll Actually I drew some last night that are very similar, except they don't have the info at the bottom.
It's a tricky game between clean ui and information display.

Did you have a redesign for the info panel in mind?
I threw something up real quick, not sure what else to put there

I hadn't yet, but now I do! a couple tweaks and it'll fit in real nicely, give me a few minutes.

@sethtroll what do you think of this?

Yeah looks good, could probably throw in current online players somewhere and also add a twitter link

The dream lives on, this suggestion has been developed and is awaiting approval and merging, planned to be merged on the 17th of May. 🎉 🎉


Will there be a deadzone calibration tool?

Stick drift is becoming an issue on dualsense controllers, specially BDM-010 and 020 models, and a friend an i are getting tired of having to replace the stick modules themselves, just to have the same client bring back the exact same controller with the exact same issue, we gave him hall effect stick modules and now the center point is inconsistent and even after recentering the sticks and writing permanently the changes, center point is still inconsistent after recalibration. This is not the only 1st to 2ng gen dualsense controllers we've had to do this, there were lots of dualsense controllers we've had to fix because of stick drift that we're just about to give up and tell our customers to just buy a new controller and check that it is at least a 3rd gen dualsense.

You're finding that the Alps mech is the problem and not the potentiometers? Have you tried installing new 2.3k pots on the affected axis and then performing both center and range calibration? This has worked for me on every Dualsense at my shop, I've yet to see one with an actually damaged mech so I'm surprised you're getting them so often.

We've tried that, and on a used Dualsense controller i bought for myself (which is one of the many BDM-010 units we had to repair) and after noticing the stick drift on the Y axis in the right stick i decided to check the potentiometer, there was an actual hair inside of it that gave it an irrepairable damage, don't know how did a hair got stuck inside the potentiometer but it did damage the thing and we're yet to receive our hall effect joysticks, so a deadzone adjustment tool in the calibration tools would be very convenient for those who are waiting for their replacement joystick modules to arrive.

Nope, the website can only start/stop calibration, without any extra setting (e.g. deadzone).


Remove docker update references

Installing docker from docker.io gives you docker 1.9, which doesn't work

Thank you for contributing to openstack/kolla!
openstack/kolla uses Gerrit for code review.
Please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.

This is not a code patch, this is a documentation fix.


udev_device.c: fix TOCTOU race condition

Separately checking the state of a file before operating on it may allow an attacker to modify the file between the two operations.
Reference: CWE-367.

Attacker can't do anything because sysfs is a virtual filesystem that is maintained by kernel. But I agree that this should be fixed even if harmless/unexploitable.

Hello @illiliti ,
My name is Aravind Machiry, Assistant Professor at Purdue's ECE Department.
Thank you for considering this pull request. This pull request was the result of our on-going research work (along with @szsam) to improve the security of open-source embedded projects.
In addition to scanning codebases with CodeQL, we are also doing a short (~4 minutes) survey to understand the use of static analysis tools like gcc -Wall and CodeQL in embedded software projects.
It would greatly benefit our research if you could fill this anonymous survey: https://purdue.ca1.qualtrics.com/jfe/form/SV_0OnXfr5plPe1QCa
Thank you,
Aravind


IBM-116 Event Reconciliation

on the whole it looks great.
Few things to have conversations around
Also need to cover intersite moves?


have_enqueued_sidekiq_job Diff is Wrong

expect(Sidekiq::Worker).to have_enqueued_sidekiq_job('Foo', 'BarX')

Will fail with
     expected to have an enqueued Sidekiq::Worker job
         arguments: ["Foo", "BarX"]
     found
         arguments: [["Foo", "Bar"]]

Note that it presents an Array and an Array of Arrays.

I believe this is correct. The "expected arguments" is showing you the arguments from your assertion in array form. The "found arguments" is showing you the arguments of all the jobs that are enqueued. The length of the outermost array is essentially the number of jobs enqueued. If you had multiple jobs enqueued the message would look like:
     expected to have an enqueued Sidekiq::Worker job
         arguments: ["Foo", "BarX"]
     found
         arguments: [["Foo", "Bar"], ["Foo", "Bar2"]]

+1
I encountered this when using Sidekiq::Client.enqueue_to_in.

I have the same issue as @Tolsee . If I am passing an array as one of the arguments, that array is displayed flattened in the diff message:
expected to have an enqueued MyJob job
  arguments: ["abc", [1, 2], 3]
found
  arguments: [["abc", 1, 2, 3]]

I had a similar problem, where the actual arguments were in a nested array.  Upon careful inspection, I saw that I set one of the expected items incorrectly.  After I fixed that argument, the test passed and it no longer displayed the nested array.


perform the apache switch within the database api

on a fresh installation either database/new or database/connect are
being used.
to avoid having to do another api call after setting up the database
to initialize crowbar, it is more efficient to do that within the
existing database api's.
it also brings consistency to the way the upgrade related database
endpoints are working, as they do exactly the same (plus migrations)
DEPENDS ON
https://github.com/crowbar/crowbar-init/pull/45
i need to rebase after #45 is merged done

 #crowbarctl add init subcommand

jsut tested it, and it works as expected


cannot download cassandra

cannot download cassandra
(HTTP code 401) unexpected - {"message":"Get https://registry-1.docker.io/v2/library/cassandra/manifests/latest: unauthorized: incorrect username or password"}

@elinalin , I think this is a duplicate of #3244 . Can you close this and add the extra info to the first issue (#3244)?

Duplicate of #3244


chore(): release from beta

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Tbaut:x: semantic-release-botYou have signed the CLA already but the status is still pending? Let us recheck it.


RPI2 Raspbian: rpi-update =>  /proc/config.gz changed => SELinux disabled

Hello guys, question: I compiled the Raspbian kernel in Raspberry Pi 2 to enable all the SELinux parameters in .config, and it worked, SELinux was activated with the new /boot/kernel7.img
However, I didn't realise rpi-update updates the kernel7.img, and after running rpi-update, SELinux was not enabled anymore. I could see in /proc/config.gz that all SELinux parameters are not there anymore (CONFIG_SECURITY_SELINUX=y, etc......)
The situation is not practical as locally compiling in RP2 takes loads of hours, and I'm lazy enough to cross-compile, so I can't use SELinux if the kernel stops supporting it every time I run rpi-update.
Is there any way to run rpi-update to keep those SELinux parameters (/proc/config.gz) or any other thing you could think of to avoid losing SELinux support in the kernel after running rpi-update? (maybe not running rpi-update and do something else?), or maybe I'm completely lost and you see this from a different angle?
Thanks and cheers
Ramiro.

There is no way to "merge" the changes in your kernel with the changes we have made.
If you just want to update the GPU and leave your kernel intact then run:
[code]sudo SKIP_KERNEL=1 rpi-update[/code]

Solid, I appreciate your quick response. I'll use that parameter.
Cheers
Ramiro


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1793

Questions ?
Please refer to the Backport tool documentation


It would be great to expose distribution of death over age & gender

Something like existing “Distribution of tests by age and sex”. This is an question often raised....

Right now we don't have this data, but if it becomes available we will be more than happy to process and expose it.

Closing as a duplicate of #127.


DRILL-7913: Improve the tips using the Tooltips

DRILL-7913: Improve the tips using the Tooltips
Description
Actually, the tips of web console is hard to use.

Too slowly (Delay 2s +)
No good for the readable (Font size and bg color)

Based on the Bootstrap (existed) and Popper.js (new), Use the new module Tooltips to improve these.
Documentation
N/A
Testing

@luocooong
This looks great!  As a part of this PR, could you update jquery to v 3.6.0?  There are some CVEs associated with the version of jquery that we're currently using.

@cgivre Done. And I have updated the description for the library upgrade. thanks


Version 1.78.0 - Getting "No access to job control" opening new bash terminal session

mac osx intel.
Upgraded to April 2023 1.78.0 version.
opening terminal window shows: message; "No access to job control."

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: April 2023 1.78.0 version.
OS Version: Mac OS Mojave

Steps to Reproduce:

Start VS code
Start a new bash terminal. see message. At this point i start a ruby server. Cannot debug or enter ctrl+C to terminate server.
Downgraded to latest 1.77 version fixed it.

Marvin Foster<EMAIL_ADDRESS>

I believe this is already fixed, can you see if you can reproduce in the Insiders build?
/label info-needed

mac osx intel.
version: 1.79.0-insider
commit: 02298ef4180f2a5db39e0cb6288382860b96a596
date: 2023-05-11T05:26:00.234Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 18.0.0
Does this issue occur when all extensions are disabled?: No，"Language pack extension for Chinese (Simplified)" and "Integrates ESLint JavaScript into VS Code"
bash: no job control in this shell
Cannot enter ctrl+C to terminate server


robots -  Allow to set values like "noindex" (in RobotsTags)

I try to set <meta name="robots" content="noindex"> for a Terms & Condition page, but this is not possible.
This is how I think it should work...
$SEOData = new SEOData(
    title: 'Terms & Services',
    description: 'These are our T&C.',
    robots => 'noindex',
);

At the moment, the method RobotsTags::initialize() just pushes the string 'max-snippet:-1,max-image-preview:large,max-video-preview:-1' every time.

Currently the SEOData object doesn't support the robots tag. Perhaps in the future, but not yet at least.
You might want to PR it if you have time, it's a relatively simple change.

PR Robots Tag feature


[BUG] Elevation Parameter has no effect

Describe the bug (描述)
I'm using the following code:
appBarTheme: const AppBarTheme(
                brightness: Brightness.light,
                elevation: 100.0,
)

on AssetPicker initialization.
But it doesn't seem to have an effect. There is still no effect displayed. Can you have a look into this? I couldn't really find a solution as you are using your own fixedAppBar implementation.
What I tried:
Changing the color of the Box Shadow: This works, but its not the elevation effect, but just an "overall" shadow on the AppBar:

My expectation:
Having some parameters or the possibility to pass my own appbar to make it look like this:

Thank you Andrew, you are the best! Let me know if you need additional information.
Cheers,
Marcel

Thank you Andrew, you are the best!

Really? 🤣 After these bugs and features you still take my name wrong lol.

Try this with 2.2.0-dev.4.


ChangeFeedProcessor not resuming from where it left off after shut down/crash.

We are continuously addressing and improving the SDK, if possible, make sure the problem persist in the latest SDK version.

Describe the bug
I have a very simple proof of concept to process a change feed. I'm worried about ensuring I catch every change, and I expected the lease container would help ensure that. However, I'm finding that when I stop my processor app, wait e.g. 10 minutes, then start it again, it just skips the changes that happened while it was stopped. I've tried changing configuration quite a bit and can't figure out if I'm doing something wrong of if there's a bug.
To Reproduce
        _processor = container.GetChangeFeedProcessorBuilder<T>(_options.ProcessorName, ProcessChangesAsync)
            .WithInstanceName(_options.InstanceName)
            .WithLeaseContainer(leaseContainer)
            .WithLeaseAcquireNotification((lease) => { Console.WriteLine($"Lease acquired"); return Task.CompletedTask; })
            .WithLeaseReleaseNotification((lease) => { Console.WriteLine($"Lease released"); return Task.CompletedTask; })
            .Build();

ProcessChangesAsync is just a very simple method that reads the _ts value and prints it out. This is how I'm noticing that changes are being missed.
To repro it you'll need a separate app producing data continuously. Then run the processor code, stop it, wait some time (e.g. 5-10 minutes), then start it again. The timestamps in the second run appear to be no earlier than the start of the second run.
Expected behavior
I'd expect it to process changes that happened while the app was stopped (continuing from the previous run).
Actual behavior
No changes from while the app was stopped appear processed.
Environment summary
SDK Version: 3.38.1
OS Version: Windows
Additional context
I haven't built a standalone repro of the issue (because I was expecting this to just work and trying to get it done quickly), but I did leave it stopped overnight and started it again and the same issue happened. I'm not 100% confident it's not just part of the "only latest version" behavior, but I should have had documents that stopped being modified during the time my processor was stopped (and I didn't see any changes from the time period it was stopped).
I originally tried to use WithStartTime, but thought that might cause issues, so I cleared the lease container and tried it without (same behavior both times). I also tried with a new instance id every time, which didn't help. I also tried adding WithLeaseConfiguration to ensure lease expiration while stopped, but that also had no impact.

Change Feed Processor resumes from the last point it saved. The leases are checkpointed and saved whenever you have a successful execution of the Handler for that lease.
If the lease was never checkpointed or your Handler failed to successfully process at least one batch of changes, then there is no point to resume from.
https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/change-feed-processor?tabs=dotnet#error-handling

I would suggest to look into the Leases when you stop your processor, if any of the have a Continuation property with null, then that means there was no successful execution of a batch and it's the scenario included in the public documentation.

I do see a ContinuationToken property in the lease document.

@Kyle0654 Is it not null for all Leases? If yes, then the Change Feed Processor just uses that ContinuationToken to continue (assuming the Monitored Container has not been deleted and recreated with the same name).
The other important point is, Change Feed does not report all intermediate operations. If a document received 5 updates, you will receive 1 event with the latest state of the document (not 5 updates).

There's only 1 lease, and it doesn't continue from where it left off =/

@ealsur I forgot to mention: while I can't be 100% confident it's not just only showing me the latest state in a single event, it's extremely unlikely. I'm only getting events from after I start my change feed processor code, nothing before then. I've left it off overnight and come back the next day and it skips everything in-between. It's very unlikely there were documents changed during that time that would immediately be changed after I started my app.

@Kyle0654 Could you be changing the value of _options.ProcessorName when you restart it?

When you look at the lease, does the ContinuationToken value increase from the previous value?
When you say there is 1 lease, is there only 1 document in the entire container?

You could enable logs to console:
https://github.com/Azure/azure-cosmos-dotnet-v3/blob/deab135c9b8709abf3e62f7be08e6c022513e4bf/Microsoft.Azure.Cosmos.Samples/Tools/CTL/Program.cs#L184-L191
That should show more information on what is happening when it restarts, to show if it is really resuming.

Nope I don't change it at all.
I build a standalone sample that doesn't exhibit this behavior, but the lease records look pretty much the same between the sample and the project I've been having this issue on. Could the age of the CosmosDB account have any impact on this behavior? (I'll try adding that logging now and see what I get).

Does this tell you anything? It looks a little suspect:
DocDBTrace Information: 0 : Host '1' 1 partitions, 1 hosts, 1 available leases, target = 1, min = 0, max = 0, mine = 0, will try to take 1 lease(s) for myself'.
...
DocDBTrace Information: 0 : Lease with token 0: acquired
...
DocDBTrace Information: 0 : Lease with token 0: renewer task started.
...
DocDBTrace Warning: 0 : Lease operation exception, status code: PreconditionFailed
DocDBTrace Information: 0 : Lease with token 0 update conflict. Reading the current version of lease.
DocDBTrace Information: 0 : Lease with token 0 update failed because the lease with concurrency token '"12002e7f-0000-0700-0000-65ef936e0000"' was updated by host '1' with concurrency token '"12002f7f-0000-0700-0000-65ef94900000"'. Will retry, 5 retry(s) left.
DocDBTrace Information: 0 : Checkpoint: lease token 0, new continuation "1526353662"

Could the age of the CosmosDB account have any impact on this behavior?

Not as far as I know.

DocDBTrace Information: 0 : Checkpoint: lease token 0, new continuation "1526353662"

That means the lease is being updated, the value in " is the ContinuationToken. Which should be higher than the previous one.
Do you see any Initializing the store in the logs?
The only thing CFP does is read the leases ContinuationToken and resume. The only scenarios where it would not do that is either the configuration between stop and resume has changed (processorName, Lease container), the lease container has no leases, or the leases ContinuationToken is null. What documents are returned with the previous ContinuationToken is up to the service, not controlled by the client.
One point about the Change Feed, if the document is deleted, it gets removed from the Change Feed. So if the document is removed either manually or through TTL inbetween you stop and resume, you will not see any notifications because the service does not return them.
There are no regressions/changes in this behavior in the past several years,

Ah alright, it looks like this was just the container I was using having document behavior that made it look like it wasn't resuming (because the documents get deleted when they're not active, and they're very active when they're live, so it looked like I wasn't receiving anything before starting). I tried it on another container with a much slower change rate and the behavior looks like it works fine.
Thanks for the help!

Ah alright, it looks like this was just the container I was using having document behavior that made it look like it wasn't resuming (because the documents get deleted when they're not active, and they're very active when they're live, so it looked like I wasn't receiving anything before starting). I tried it on another container with a much slower change rate and the behavior looks like it works fine.
Thanks for the help!

Thanks for confirming. That would mean that once the document gets deleted in-between stop/resume, because it gets removed from Change Feed, it is never picked up by CFP on the resume.
For reference: https://learn.microsoft.com/en-us/azure/cosmos-db/change-feed#latest-version-mode


Don't generate WIT with the name memory

This commit fixes a fuzzer-found issue in the wit-smith crate where if a function is called memory then it's not possible to feed such a WIT document through wit-component at this time. This is because linear memory is called memory and must be called that. Until this restriction is later lifted perhaps this claims the name memory early on to prevent any interface items from being named that.

Thankfully that one's already covered since it's inherently not a kebab-case name, so the core module won't ever have a conflict with that (e.g. cabi-realloc: func() would generate an export of "cabi-realloc" which is ok)


ci: check docs links fixes and configuration

This commits adds a new config for the link checker lychee. This should reduce the noise from some false negatives or un-reliable websites. It also makes the config less different between PR and main branch checks.

@mtardy is this expected: https://github.com/cilium/tetragon/actions/runs/6716913064/job/18253867950?pr=1648?

@mtardy is this expected: https://github.com/cilium/tetragon/actions/runs/6716913064/job/18253867950?pr=1648?

Yap, all good. Was fixed in 752ce86851dd7b34733f26dbe90657f0b7c07320


Aws SQS: Remove unnecessary headers from the test because of CAMEL-18123

Fix of https://issues.apache.org/jira/browse/CAMEL-18123, makes some header parameters unnecessary for purge/delete queue actions (i.e. https://github.com/apache/camel-quarkus/blob/main/integration-test-groups/aws2/aws2-sqs/src/main/java/org/apache/camel/quarkus/component/aws2/sqs/it/Aws2SqsResource.java#L86)

The fix for this was merged with the Camel 3.18.0 upgrade in https://github.com/apache/camel-quarkus/commit/3fd34e34225664ad82eeb31bc96eed36a1b82071.


game crashes when crafting items with a full inventory

Same here, when doing it on a server this is the error I get:

#218
Please, before sending an issue, see if there is another one about the same thing, that would help me a lot.


[NetAppFiles]Anf 8257 net app files 2020 09 01

This PR relates to NetApp Files (ANF) 2020-09-01.

Added Security operators to ActiveDirectory
smbEncryption, smbContinuouslyAvailable to Volume
Added ListNextLink.GetAllResourcesByPollingNextLink()  to query large result sets (volumes)

Hi would be nice to get this reviewed has been waiting.

Hi would be nice to get this reviewed has been waiting.

@bquantump  can we please get this looked at?

@bquantump  can we please get this looked at?

Can you please reference the swagger?

Can you please reference the swagger?

@bquantump  https://github.com/Azure/azure-rest-api-specs/blob/master/specification/netapp/resource-manager/Microsoft.NetApp/stable/2020-09-01/netapp.json

@bquantump  https://github.com/Azure/azure-rest-api-specs/blob/master/specification/netapp/resource-manager/Microsoft.NetApp/stable/2020-09-01/netapp.json

Please ensure this checklist is complete
https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#appendix-a-pr-review-checklist

Please ensure this checklist is complete
https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#appendix-a-pr-review-checklist

I think everything should be done. Are we missing something?

I think everything should be done. Are we missing something?


add unit tests and remove dead code

Pull Request Test Coverage Report for Build 82025

0 of 0   changed or added relevant lines in 0 files are covered.
576 unchanged lines in 81 files lost coverage.
Overall coverage increased (+0.2%) to 77.411%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Twilio/TwilioAdapter.cs
1
85.71%

/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs
1
71.43%

/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs
1
95.45%

/libraries/Microsoft.Bot.Builder/BotStateSet.cs
1
85.0%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/PromptValidatorContext.cs
1
82.35%

/libraries/Microsoft.Bot.Builder.Dialogs/WaterfallStepContext.cs
1
86.96%

/libraries/Microsoft.Bot.Builder/Inspection/InspectionSession.cs
1
76.47%

/libraries/Microsoft.Bot.Builder/ShowTypingMiddleware.cs
1
94.55%

/libraries/Microsoft.Bot.Builder.Testing/XUnit/TestDataObject.cs
1
82.35%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Twilio/TwilioClientWrapper.cs
2
0.0%

Totals

Change from base Build 82018:
0.2%

Covered Lines:
5884

Relevant Lines:
7601

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1


YAML diff is broken when editing clusters

Setup

Rancher version: v2.7.6
Rancher UI Extensions: None.
Browser type & version: Firefox 118.0.1

Describe the bug

The "Show Diff" function is cluttered with line numbers (and possibly other things) and bad indentation, making it impossible to use.
To Reproduce

Go to Cluster Management.
Click the menu for a cluster and select "Edit YAML".
Make a change.
Click "Show Diff".

Result

Expected Result

I expect a clear, uncluttered diff like in Git. If line numbers are included, they should stay at the right-hand-side of the text box.
Screenshots

See above. ☝
Additional context

It's even worse if one selects "Edit Config" instead of "Edit YAML". If you do that and then click "Edit as YAML" and "Show Diff", the diff is huge and looks even worse than when a single line gets edited.

Thanks for raising this issue. It was resolved in 2.7.7 though via https://github.com/rancher/dashboard/issues/9313 / https://github.com/rancher/dashboard/pull/9323


Incorrect macro expansion with combination of `", ``, and embedded macro usage

Background: I'm trying to fix the handling of SV macro expansion in Icarus Verilog, so this is an artificial test case designed to explore what other simulators do. The code is
`define PREFIX_        my_prefix_
`define SUFFIX          my_suffix

`define PREFIX_SUFFIX   my_prefix_suffix

`define name1           `PREFIX``_```SUFFIX
`define name2(p,s)      p``_``s
`define name3(p)        ```p``_SUFFIX

`define stringify(text) `"text`"

module test();

initial begin
  $display(`stringify(`name1));
  $display(`stringify(`name2(`PREFIX, `SUFFIX)));
  $display(`stringify(`name3(PREFIX)));
  $finish;
end

endmodule

The output is
module test();

initial begin
  $display(`PREFIX_my_suffix"");
  $display(`PREFIX_my_suffix"");
  $display("my_prefix_suffix");
  $finish;
end

endmodule

whereas I expect
module test();

initial begin
  $display("my_prefix_my_suffix");
  $display("my_prefix_my_suffix");
  $display("my_prefix_suffix");
  $finish;
end

endmodule

If I replace
`define PREFIX_        my_prefix_

with
`define PREFIX         my_prefix

the output is
module test();

initial begin
  $display("my_prefix_my_suffix");
  $display("my_prefix_my_suffix");
  $display("my_prefix_SUFFIX");
  $finish;
end

endmodule

which although it contradicts a strict reading of the IEEE standard, does at least generate compilable code.

I think what it does is consistent with several commercial simulators (another gives an error).  IEEE doesn't really cover a lot of these corner cases, UVM tends to be a good test. You should also see my paper https://www.veripool.org/papers/Preproc_Good_Evil_SNUGBos10_paper.pdf and also the preprocessor tests in Verilog Perl and better, in test_regress/t of Verilator.

Sorry, but no other simulator gets the stringification wrong as shown in the first output.

This is what I got from one:
`PREFIX_my_suffix
`name2(`PREFIX, my_suffix)
`name3(PREFIX)

Results differ, which is part of my point of that paper, that it isn't standardized.

You're missing my point. In the first case, regardless of how the macro expansion is handled, the double quotes should enclose the resulting text, not come after it.
I realise there's a lot of variation in how the macro expansion is handled, and I think your solution is a good one. I'm inclined to mimic it in Icarus Verilog.

Yes, I was misreading what you saw as wrong.  I pushed a fix to stringify undefined macros, ditto for Verilator (which BTW has the same preprocessor but additional features and tests so you may prefer using that.)  Thanks for your report.


bodymovin.js wapper for React, Angular and Vue

Thanks for GREAT work of this repo!!
For more convenient integration to some popular frameworks, I created bodymovin wapper of React, Angular and Vue which are also inspired by airbnb lottie
All of them now only implemented some basic features, and I personally don't have enough time to maintain them, so I need some help for improving them.
I think this is a right place for asking help, hope I didn't offend here.
Thanks a lot.

this looks nice! I'll take a look at it.

Thanks for your support @bodymovin :)

Unfortunately now abandoned

this looks nice!!!!!!


Pushout/pullback design

I think we should change the pushout interface to return a type that supports accessing all the parts of the pushout construction. This will prevent the kind of abstraction leak we see in AbstractPetri.
struct Pushout{S}
    span::S
    coprod::Cospan
end

Pushout(s::Span) = Pushout(s, coproduct(s))

with methods
u(p::Pushout) = begin
    f,g = left(p.span), right(p.span)
    ι1, ι2 = left(p.coprod), right(p.coprod)
    return coequalizer(f⋅ι1, g⋅ι2)
end

Cospan(p::Pushout) = begin
    coeq = u(.coproduct)
    return Cospan(f⋅ι1⋅coeq, g⋅ι2⋅coeq)
end

Agreed. It turns out that describes (co)limits as a GAT leads to a similar design, see here.

We can also add the iteration interface to span and cospan so that f,g = c is defined to be f,g = left(c), right(c) since that seems to be a common idiom.
julia> struct Point
       a::Int
       b::Int
       end

julia> x,y = Point(1,2)
ERROR: MethodError: no method matching iterate(::Point)
Closest candidates are:
  iterate(::Core.SimpleVector) at essentials.jl:603
  iterate(::Core.SimpleVector, ::Any) at essentials.jl:603
  iterate(::ExponentialBackOff) at error.jl:253
  ...
Stacktrace:
 [1] indexed_iterate(::Point, ::Int64) at ./tuple.jl:84
 [2] top-level scope at REPL[5]:1

We have to implement some of these methods: https://docs.julialang.org/en/v1/manual/interfaces/#man-interface-iteration-1
The alternative is to implement Tuple(c::Cospan) = (left(c), right(c)) and then we would get f,g = Tuple(c) which requires less effort and matches the semantics of copsans better, they aren't really iterables, they are just pairs.

Did anyone start on this? This looks like a somewhat mechanical refactor once the interface is agreed on, so I think it would be good to expose me to more parts of the codebase.

I don't think so. @epatters did you have any attempt redoing the interface?

No, in part because I didn't want to conflict with Owen's work. Owen, I think this would be a great followup to what you've already done with n-ary (co)products.

I'll work on this issue and the related #171. I ran into the annoying iteration issue while working on #192.


Feature Engineering

Feature Engineering
This tracks my progress on featuer engineering

Textblob has a function called sentiment() which returns two properties, polarity and subjectivity.


chore: add spotless format checker

checks format in build ci
auto add license header

Codecov Report

Merging #28 (444cbdc) into main (1995d50) will decrease coverage by 0.04%.
The diff coverage is 98.30%.

@@             Coverage Diff              @@
##               main      #28      +/-   ##
============================================
- Coverage     76.74%   76.70%   -0.05%
- Complexity      268      274       +6
============================================
  Files            31       31
  Lines           972      970       -2
  Branches         68       68
============================================
- Hits            746      744       -2
  Misses          184      184
  Partials         42       42

Impacted Files
Coverage Δ

.../java/com/featureprobe/sdk/server/AccessEvent.java
100.00% <ø> (ø)

...va/com/featureprobe/sdk/server/AccessRecorder.java
97.67% <ø> (ø)

...featureprobe/sdk/server/DefaultEventProcessor.java
71.87% <ø> (ø)

...probe/sdk/server/DefaultEventProcessorFactory.java
100.00% <ø> (ø)

.../com/featureprobe/sdk/server/EvaluationResult.java
72.72% <ø> (ø)

...c/main/java/com/featureprobe/sdk/server/Event.java
66.66% <ø> (ø)

...in/java/com/featureprobe/sdk/server/FPContext.java
67.39% <ø> (ø)

...ain/java/com/featureprobe/sdk/server/FPDetail.java
80.00% <ø> (ø)

...java/com/featureprobe/sdk/server/FeatureProbe.java
64.46% <ø> (ø)

.../com/featureprobe/sdk/server/FileSynchronizer.java
65.00% <ø> (ø)

... and 21 more

awaiting for #29 to be merged

This pull request has been merged into #35


[BUG] Memory leaks reported after integration tests.

I got some warnings of RMM memory leaks after completing a full run of  integration tests.   This was running 23.02, sha:  a60671064596125ff6ddfa73d664b60a1197bdba
This was running cudf 23.04,  sha:  6a67e8fe49661f7f2f6d8da119996f683a21803a.   Hardware:  A5000
Output:
23/02/02 22:51:04 WARN GpuDeviceManager: Shutting down RMM even though there are outstanding allocations 42496
23/02/02 22:51:04 WARN GpuDeviceManager: Shutting down RMM even though there are outstanding allocations 16384
23/02/02 22:51:04 WARN GpuDeviceManager: Shutting down RMM even though there are outstanding allocations 512
23/02/02 22:51:05 WARN GpuDeviceManager: Shutting down RMM even though there are outstanding allocations 48128
23/02/02 22:51:05 WARN GpuDeviceManager: Shutting down RMM even though there are outstanding allocations 17920

@abellina

Need to run integration tests single threaded with the java command line argument-Dai.rapids.refcount.debug=true and examine the logs.  Then need to grep the log for "LEAK" and debug.

@nvdbaranec can you post the full command you ran for the integration tests?

I just used the standard script. Inside integration_tests:  ./run_pyspark_from_build.sh


[ISSUE #4681]Add the implementations of missing in AbstractPluginMessageStore to ensure compatibility

Make sure set the target branch to develop
What is the purpose of the change
Add the implementations of missing in AbstractPluginMessageStore to ensure compatibility
Brief changelog
Add the implementations of missing in AbstractPluginMessageStore to ensure compatibility
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #4680 (adf0d0b) into develop (16416aa) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4680      +/-   ##
=============================================
- Coverage      44.79%   44.56%   -0.23%
+ Complexity      7530     7501      -29
=============================================
  Files            975      975
  Lines          67378    67382       +4
  Branches        8892     8892
=============================================
- Hits           30179    30028     -151
- Misses         33482    33632     +150
- Partials        3717     3722       +5

Impacted Files
Coverage Δ

...etmq/broker/plugin/AbstractPluginMessageStore.java
0.00% <0.00%> (ø)

.../broker/subscription/SubscriptionGroupManager.java
68.79% <0.00%> (-14.19%)
:arrow_down:

...n/java/org/apache/rocketmq/test/util/StatUtil.java
16.19% <0.00%> (-14.09%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
44.77% <0.00%> (-8.96%)
:arrow_down:

...va/org/apache/rocketmq/logging/inner/Appender.java
29.21% <0.00%> (-7.87%)
:arrow_down:

...he/rocketmq/controller/impl/DLedgerController.java
70.65% <0.00%> (-7.07%)
:arrow_down:

...etmq/namesrv/routeinfo/BatchUnRegisterService.java
94.73% <0.00%> (-5.27%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
47.82% <0.00%> (-4.35%)
:arrow_down:

...ketmq/common/protocol/body/ConsumerConnection.java
95.83% <0.00%> (-4.17%)
:arrow_down:

...ava/org/apache/rocketmq/filter/util/BitsArray.java
59.82% <0.00%> (-3.42%)
:arrow_down:

... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Coverage increased (+0.2%) to 48.995% when pulling adf0d0ba971f7b622052dda3e65b80751071cc91 on RongtongJin:develop-x into 16416aaacfeec8e0e8dea52652da3f60eae4b394 on apache:develop.


@Deprecated should take a message rather than an expiry time

It would be nice if @Deprecated's argument was a message, rather than a deadline. Developers deprecated features would then be encouraged to describe the replacement in the message, e.g. @Deprecated('Use the Bar.foo() constructor instead.').
The @deprecated annotation without a message should then probably itself be deprecated in favour of using @Deprecated with details.

Seems to be a dup of dart-lang/sdk#34155 with a fix.

Awesome.


CDAP-13558 Support CDC pipelines on Spark version 2.x

JIRA - https://issues.cask.co/browse/CDAP-13558
WIKI - https://wiki.cask.co/display/CE/CDC+Solution+Enhancements
In scope of this PR:

added checkstyle verification
fixed checkstyle issues

@albertshau, could you please take a look.


Sorry, I want to know the specific algorithm of item similarity recommender

Hello, I just started learning machine, English is not my mother tongue, I'm very sorry.
I built a recommendation system using GraphLab Create and Django. Now I really want to know whether the algorithm behind the use of item_similarity_recommender modeling is collaborative filtering. In addition, can you tell me more about whether it is user-based collaborative filtering or item-based collaborative filtering?
I know I shouldn't ask this question to you. I'm very sorry, but I'm always puzzled and I'm so sorry.

In here, https://apple.github.io/turicreate/docs/api/generated/turicreate.recommender.item_similarity_recommender.create.html#turicreate.recommender.item_similarity_recommender.create
Create a recommender that uses item-item similarities based on users in common.
Does this sentence mean that it is the user-based collaborative recommendation?

Hello,
why did you close this issue ? I'm really interested since it's been confusing for me.
Have you found a solution ? If so I'd be glad to have a response !
Thank you !
👍

Yes, this toolkit is an implementation of collaborative filtering. For some more details, try looking at the relevant C++ header:
https://github.com/apple/turicreate/blob/master/src/unity/toolkits/recsys/models/itemcf.hpp


VPAID play failed

Vpaid won't play I use this tag https://bs.serving-sys.com/BurstingPipe/adServer.bs?cn=is&c=23&pl=VAST&pli=14432293&PluID=0&pos=8834&ord=[timestamp]&cim=1
In firefox I get this error TypeError: document.body is null VPAIDAPI.js:84:365 and in chrome I get this error Uncaught TypeError: Cannot read property 'appendChild' of null

This issue seems to be related to DOM of the page, not Fluid Player. Can you provide more details to reproduce the issue, ex. codepen?


docs(cache): remove cache.loglevel

Remove cache.loglevel originally added in https://github.com/webpack/webpack.js.org/pull/2606.
This was removed in https://github.com/webpack/webpack/pull/9563/files.
Resolves https://github.com/webpack/webpack.js.org/issues/3246.

Thanks for quick update @skovy and for PR!


Compatibility with "Sophisticated wolves"

Is it possible to make this mod compatible with "Sophisticated wolves" mod? I'd like to have both, please...

Yes, there is the alpha for 1.10 but there is no alpha build with sophisticated wolves for 1.11.2 from what I see, unless the release supports it

Hey,
The answer is:
For versions 1.10+: Yes!  I've been slow in updating the mod to 1.11 due to time constraints, but plan to release the 1.11 version (and maybe the 1.12 branch) by early July.
For version 1.7: Ehhhhhhhhhh......
The problem with 1.7 is that it is from before forge added the capability system, which is the definitive linchpin in gsbaoge's fix (Issue #4).  Therefore, I have to implement some other method of compatibility within the 1.7 version.  These include:

Replacing EntityWolf.class at load time with a modified version (which is definitively not allowed since I'd be replacing the entire class, and therefore distributing Minecraft code within my mod)
Writing custom methods in Java bytecode and patching them in through ASM (which I've worked with before, but all I did then was add some custom enchantments and I scrapped it since my helper classes were WAY too complex)
Somehow patching the EntityWolf bytecode with a precompiled binary diff file (which I uh... I'm not sure how to go about that one.  That would probably require a ridiculous number of classloader customizations, which I have never even attempted before)

TL;DR:  Yes and "maybe?"; 1.10+ is a definite "Yep", while 1.7 would require some weird workarounds that I'm not too sure about implementing.


Delete folders !

I have problem with delete folder . This is my delete url " uploads/files/shares/sharesa not found! " .
But that's not true because added "shares" before my folder name .

I fix that . How ?
Create a new method for getFolderName in LfmController.
private function getFolderName($folder)
{
$lfm_dir_start = strpos($folder, $this->file_location);
$working_dir_start = $lfm_dir_start + strlen($this->file_location);
$lfm_file_path = substr($folder, $working_dir_start);
$arr_dir = explode('\', $lfm_file_path);
$arr_foldername['short'] = end($arr_dir);
$arr_foldername['long'] = '/' . $lfm_file_path;
return $arr_foldername;
}

Oh god this problem is windows . 👎

Fixed in 0fa6cc4.


To be able to set Sub and Pub decorators together for same method

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
[-] Tests for the changes have been added (for bug fixes / features)
[-] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
This PR address this issue, that was initially evaluated as feature. https://github.com/flamewow/nestjs-asyncapi/issues/465

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 465
What is the new behavior?
AsyncApiPub and AsyncApiSub decorators now creates method decorator with different meta keys
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Hey @bintoll , thanks for the PR
testing workflows for some reason were not executed on PR.
If you check it locally via npm run test:e2e you should get the failed tests, please fix

closing in favor of https://github.com/flamewow/nestjs-asyncapi/pull/473


feature: HTTPS support

The site is currently served as HTTP by default, without redirect. Manually switching to HTTPS throws a security error because of cert name mismatch (the cert is a GitHub cert).
Once that's cleared up, HTTP can then redirect to HTTPS.

GitHub pages now supports HTTPS and can enabled via the repos' settings tab.

Y'all are quick!
(And sorry for the semi-duplicate!)

done1

NIce - thanks!


pyspeedtest.py crashing

To whom it concerns,
I love your code and it's functionality within python.
I'm running a python script where within a While True loop I call your download function, it runs for approx and hour or two and then crashes giving me the following error output;

[ ] 1. Exception in thread Thread-1121:
[ ] 2. Traceback (most recent call last):
[ ] 3.   File "/usr/lib/python3.4/threading.py", line 920, in _bootstrap_inner
[ ] 4.     self.run()
[ ] 5.   File "/usr/lib/python3.4/threading.py", line 868, in run
[ ] 6.     self._target(*self._args, **self._kwargs)
[ ] 7.   File "/usr/local/lib/python3.4/dist-packages/pyspeedtest.py", line 85, in downloadthread
[ ] 8.     response = connection.getresponse()
[ ] 9.   File "/usr/lib/python3.4/http/client.py", line 1172, in getresponse
[ ] 10.     response.begin()
[ ] 11.   File "/usr/lib/python3.4/http/client.py", line 351, in begin
[ ] 12.     version, status, reason = self._read_status()
[ ] 13.   File "/usr/lib/python3.4/http/client.py", line 321, in _read_status
[ ] 14.     raise BadStatusLine(line)
[ ] 15. http.client.BadStatusLine: ''
[ ] 16.
[ ] 17. Traceback (most recent call last):
[ ] 18.   File "speedtest.py", line 96, in
[ ] 19.     TestSpeed()
[ ] 20.   File "speedtest.py", line 51, in TestSpeed
[ ] 21.     down = round(st.download())
[ ] 22.   File "/usr/local/lib/python3.4/dist-packages/pyspeedtest.py", line 107, in download
[ ] 23.     total_downloaded += thread.downloaded
[ ] 24. AttributeError: 'Thread' object has no attribute 'downloaded'

Is there a way to rectify this or is it somehow an issue with my script?
Many thanks,
Paul

https://github.com/fopina/pyspeedtest#discontinued :(


Add '&' as shorter syntax for 'space'

I think concatenation with space is just as common as with either empty or
newline.  This change adds more succinct syntax for this.  The analogous Haskell
library* also has syntax for this with '<+>'.  (It uses '<>' for our '+', and
'<$>' for our '/'.)
I don't care about the particular identifier, but I found having to type foo space bar space baz tiresome.
[*] https://hackage.haskell.org/package/wl-pprint-1.2/docs/Text-PrettyPrint-Leijen.html

Codecov Report

Merging #70 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage      98%   98.03%   +0.02%
==========================================
  Files           6        6
  Lines         251      254       +3
  Branches       33       32       -1
==========================================
+ Hits          246      249       +3
  Misses          5        5

Impacted Files
Coverage Δ

core/src/main/scala/org/typelevel/paiges/Doc.scala
97.93% <100%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78777cb...5438c41. Read the comment docs.

I think this looks okay. I'm a bit negative on operators personally due the difficulty in looking them up, but it may be convenient enough.
@non @coltfred thoughts?

I think symbols can be a necessary evil to make things more readable. We already have a few in there and this one is consistent with the others. I'd say my ultimate stance is that there should always be an alphanumeric version, but adding symbols is fine.
Maybe we should open an issue and put the symbols all together in a "syntax object" or something, but for now I'd be fine with just merging this and dealing with it as a more overarching question.

thanks for the PR. I agree that space is a common way to compose


Optimise rendering

I was thinking that it could be done in a similar way to how you have set up the particle system, as in use a dynamic Arraylist and not a fixed native array. This avoids a massive loop in the main render method, and means that you no longer need to perform null checks.

Working on that now


Update helloword_bosnian

What does the program do ?
print and fix hello world
In what programming language it is written?
pascal

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others