Only send comment tip if comment was successfully created

PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number: fixes #945
What is the current behavior?
If a comment fails to be created, a tip of 1 LBC is still sent to the creator.
What is the new behavior?
If a comment fails to be created, a tip is not sent to the creator.

Thanks so much for the PR! We'll get this reviewed soon. Once that's done, can we show you some appreciation?

@clay53 Thank you for the PR. The plan is to implement this differently by saving the comment locally upon failure for automatic retries, until the comment is posted successfully. This way, this always ensures that the tip is sent first before the comment actually goes through, otherwise it would be theoretically possible to post comments without tipping (if the tip request subsequently fails).

@akinwale Ok, that sounds good. I personally believe comment tips should be removed (and can be easily removed through building it yourself if someone gets annoyed about it) so I wasn't too worried about it but that does make sense and I agree that that is an issue with this solution.


Add an icon after project title for project type

I'd like to have an icon after project title in project page to indicate the project type.
So it's easier to see the type of the project with-out scrolling down to the dependencies.
This is useful for debugging Guppy and also for the user.
Describe the solution you'd like
Add the project type icon after the project title in gray (same gray as the settings gear) or purple of the heading - check what looks better.
The project type can be accessed inside ProjectPage with {project.type}. Just a mapping to the icons is needed. Code for the icons can be copied from CreateNewProjectWizard\MainPane.js.

You could try adding filter: grayscale() to the CSS for that icon.

hi @christiansessler, thanks for tackling this. To your styling: I think the icon can be a bit larger and vertical centered so it lines up nicely with the title.
For the coloring:
You could also inline the svgs and modify the style of the svg. Here is an example.
Filtering would probably also work but I think inlining svg is more flexible. Just check that the icons are correctly rendered in CreateNewProjectWizard.
I also think that it's good to refactor these icons to a new component location like in the Codesandbox so it can be re-used at both positions easily.


How to create .zshrc if zsh is installed from source?

I installed zsh from source successfully. But, when I ran exec ./zsh/bin/zsh -l, I got this error:
********/zsh/share/zsh/5.5.1/scripts/newuser:6: zsh-newuser-install: function definition file not found
/etc/zshrc:54: compinit: function definition file not found

It seems that the .zshrc is needed. How to add the .zshrc file?
Thanks!

You should make install as well so that zsh functions are copied (if you didn't). And use the path of the installed zsh instead of ./zsh/bin/zsh which is the path of the compiled zsh. make install should copy that to its intended path.


chore: update worker-kv to 0.5.0

Fixes #101. Version 0.5.0 contains breaking changes with the get operation on KV stores. These changes were made to fix inconsistencies with the JS api, but it unintentionally fixed this issue.

Thanks! LGTM. I'll get this merged and will roll out a release by EOD today or tomorrow.


ComputeEngineCredentials incorrectly throws RuntimeException

Unless we really think getDefaultServiceAccount can't fail here, we should not convert the IOException to a RuntimeException.
  @Override
  public String getAccount() {
    if (serviceAccountEmail == null) {
      try {
        serviceAccountEmail = getDefaultServiceAccount();
      } catch (IOException ex) {
        throw new RuntimeException("Failed to to get service account", ex);
      }
    }
    return serviceAccountEmail;
}

This method is called by sign, which throws SigningException but does not catch this RuntimeException! SigningException is also a runtime exception and shouldn't be.

Since this library is pre-1.0 we're allowed to change the API. We should make SigningException (and possibly others) checked since they came fail unexpectedly due to problems external to the program itself, and therefore client code should write handlers.

AppEngineCredential creates its service account when the object is created and does properly throw IOException if this fails. That's probably what we should do here.

serviceAccountEmail is transient:
  private transient String serviceAccountEmail;

so if it's serialized it will be looked up again when needed. Can it have a different value then?

If we make SigningException a checked exception, we will require anyone who is using credentials.sign() to add exception handling.
Amongst Google libraries, I only see one use (albeit an important one) https://github.com/googleapis/java-storage/blob/6f172eba6fd6e9c11a1f49569249ea6e714ea91f/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageImpl.java#L781

If we make SigningException a checked exception, we will require anyone who is using credentials.sign() to add exception handling.
Amongst Google libraries, I only see one use (albeit an important one) https://github.com/googleapis/java-storage/blob/6f172eba6fd6e9c11a1f49569249ea6e714ea91f/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageImpl.java#L781

That is a good thing and is why we should make this a checked exception.
Everyone now has to handle an unexpected runtime exception. In most cases they're not so they're shipping buggy, unreliable code that fails unexpectedly.
The alternative is to figure out to make getDefaultServiceAccount or getAccount not fail. That is, what it can do that is correct behavior instead of throwing a runtime exception? But if there is no such behavior it needs to be a checked exception.

That is a good thing and is why we should make this a checked exception.
Everyone now has to handle an unexpected runtime exception. In most cases they're not so they're shipping buggy, unreliable code that fails unexpectedly.
The alternative is to figure out to make getDefaultServiceAccount or getAccount not fail. That is, what it can do that is correct behavior instead of throwing a runtime exception? But if there is no such behavior it needs to be a checked exception.

Downgrading this to a P2 since it's not blocking any critical functionality at this stage.  If that should change, let me know :)


Trojan found (possible false positive)

Describe the bug

Windows Security detected this script having a trojan-like behaviour, I looked into it but didn't have time to really go into the code and I thought I'd let you guys know.
Environment

OS: windows 10, build 2004
Compiler: not relevant

To Reproduce
The weird thing is that I was having this version of vpckg for a few weeks and never had any issues. The trojan warning appeared after I tried copying my workspace folder from a drive to the OS drive.
My local repo is @ b271aeffa25c53f3750f58ad6209f3fa7c528716

same issue, windows 8.1, denied by windows defender

@BillyONeal, could you help have a look?

This seems like something you'd have to report to Defender (via the Windows Feedback tool), or otherwise exclude.

@Mayhem93, feel free reopen if you expect vcpkg do something here.


feat(FX-3256): pull to refresh for saved search list

The type of this PR is: Feature

This PR resolves FX-3256
Description
A user should be able to pull down on the screen when they are in the list and trigger a refresh action to see the latest updates to their saved search list.
Demo
https://user-images.githubusercontent.com/3513494/132001278-dbf0cb00-a74c-4d40-9ca7-c2af38b66673.mp4

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Implement pull-to-refresh behavior for saved alerts list page - dimatretyak

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (Implement pull-to-refresh behavior for saved alerts list page - dimatretyak)

  Generated by :no_entry_sign: dangerJS against 13941151f9945512e739bc4f1e7f54632a6fb0f9

Is this refresh animation suitable? (we now have such a refresh animation after deleting the saved search alert)?
https://user-images.githubusercontent.com/3513494/132001494-917cfb8f-1cb9-4c62-b561-5038421e83ea.mp4


displayed both analog and digital in one web page

🛠 Fixes Issue (Number)

👨💻 Changes proposed

✅ Check List (Check all the applicable boxes)

[ ] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
[ ] This PR does not contain plagiarized content.
[ ] My Addition/Changes works properly and matches the overall repo pattern.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

This working project will be:

from:


Prisma Introspection Crashed on In-Memory CockroachDB

Hi Prisma Team! Prisma Migrate just crashed.
Command
introspect
Versions

Name
Version

Platform
debian-openssl-1.1.x

Node
v16.13.2

Prisma CLI
3.9.2

Engine
bcc2ff906db47790ee902e7bbc76d7ffb1893009

Error
Error: [introspection-engine/connectors/sql-introspection-connector/src/introspection_helpers.rs:241:64] called `Option::unwrap()` on a `None` value

Thanks for the report. Can you share some additional information so we can potentially reproduce this? How does one run such an "In-Memory CockroachDB"? What version? Anything special about your schema or does it happen for all?

So what could be happening here is we have foreign keys available with columns that do not exist in the table. We crash because the table does not have a column mentioned in the foreign key.
We load relations separately from the tables, so it would be very interesting to get a proper reproduction to find a solution for these cases.

Ping @ppoddar-affordably

Hey @ppoddar-affordably.
Since we haven't heard back from you, we are going to close this issue. Feel free to open new one, providing all information necessary for reproduction.


workflows/clustermesh: set kubectl version to match the one of the kubernetes cluster

By default, the helm/kind-action action downloads a fixed version of kubectl (v1.23.12 in v1.5.0). Let's configure it so that the kubectl version matches that of the kubernetes cluster we are creating, to ensure better compatibility.

workflows/clustermesh: set kubectl version to match the one of the kubernetes cluster

TravisCI hit new flake: https://github.com/cilium/cilium/issues/25235


KAFKA-9073: check assignment in requestFailed to avoid NPE

This is a cherry-pick of the bug-fix included in https://github.com/apache/kafka/pull/6884 to 2.3 and older branch.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ableegoldman @hachikuji

Can we add a test for this case?

By the way, I vaguely recall another minor bug you found during that long PR: Also found a minor bug in MetadataUpdate that removed topic would still be retained with null value of num.partitions.

Ack, I think you were referring to this: https://github.com/apache/kafka/pull/6884/files/ddfe28f9dd5ce26f8f189946e5c5d90b627e33ca#r307557509 Will update this PR as well.

@mjsax I tried to add a unit test but this is not very straight-forward to test the exact root cause since it has to be a race condition between the assignment / subscription change and the request callback / metadata snapshot construction. I feel it is relatively safe to merge to old branches since it is a cherry-pick from trunk / 2.4. WDYT?


Update Swift-Kuery-ORM Guide

In the guides we should look at mentioning that you can override the tablename property in Models.

The ORM guide has the same set up as Swift-Kuery for connecting to different databases. We could copy that over if we want to demonstrate this support.


[FLINK-7030] Build with scala-2.11 by default

+1, but a rebase is needed.

rebased and fixed conflict

will merge this once travis passes.

@zentol build is passing :)

I'm aware of that.

Thanks!


Add UsernameValidator

We have a lot of duplicated code to check if a username is valid.
That's because

the current validators only returns true/false (so we can't show users an appropriate message like "The username is too short)
the code has been implemented here and there in very different times

So, what about adding a centralized and more powerful validator?
Pros:

it can be overridden with a subclass
the valid username characters are now in a configuration setting.
every check can be performed separately
every check is now in a common class

Cons:
There's a BC break: before we had the concrete.user.username.allow_spaces configuration key that allowed having a space in the middle of a username, now we have concrete.user.username.allowed_characters.boundary to describe the chars that can occur at the beginning/end of a username and concrete.user.username.allowed_characters.middle to describe the chars that can occur in the middle of a username.
There's a migration that adds spaces to concrete.user.username.allowed_characters.middle if concrete.user.username.allow_spaces is true, but 4rd party tools relying on concrete.user.username.allow_spaces may have problems.
BTW it's not a great BC problem: this may occur only if people customize concrete.user.username.allowed_characters.middle.

PS: if the approach of this PR is ok, I'm planning to add two other validators with a similar approach: Concrete\Core\User\Validation\PasswordValidator and Concrete\Core\User\Validation\EmailValidator.

PS: I removed the condition that a username can't be USER_SUPER (that is, 'admin').
That's because:

'admin' is usually already in use, so when we create another user, it can't have a username 'admin'.
for security reasons, someone may want to change the superuser username, and create a "fake" user with username 'admin' but without root privileges.

This sounds like a much needed feature. However @KorvinSzanto has already implemented a Password Validator and I believe some validator interfaces. You can find them in Concrete\Core\Validator. Can you make sure this UserValidator utilizes the same approach that his password validator does, and make them work together if at all possible?  Same with Email validator.


BehaviorSubject (in Ionic Project) behaves strangely after update to latest Angular (v6 to v7)

Hi guys,
I've checked out a very simple ionic v4 Project with a login flow.
The demo worked perfectly fine, but since this project is already 5 months old, I've decided to create a new ionic project with the latest ionic cli and put the source into the new one... with the latest stable ionic dependencies.
Besides other updates, the update of the ionic project updated the angular version from v6.1 to v7.2 (including its deps) and TypeScript from 2.9 to 3.1.
RXJS has been updated from 6.2.2 to 6.3.3.
But then the rxJS-BehaviorSubject (here: authState$) acts totally weird, see following screenshot.
Code: https://github.com/meumobi/meu-starter.login-flow.ionic-v4/blob/master/src/app/core/auth/auth.service.ts
When using the BehaviorSubject with the latest Ionic dependencies, it acts strangely:
Code:
console.log('isAuthenticated: ', this.authState$.getValue());
console.log('isAuthenticated: ', this.authState$);

Behaviour in console:

So what happens:
The getValue() returns the initial value, where as the printed object contains the correct value (true). This seems strange to me as they're both called right after each other.
I would be really cool if you could tell me what's going on.
Thanks so much in advance,
Sascha
P.S.: Stackoverflow ticket created in parallel - with all necessary information: https://stackoverflow.com/q/55396235/344514
Ionic version:
[x] 4.x
Ionic info:
Ionic:

   ionic (Ionic CLI)             : 4.12.0 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.1.2
   @angular-devkit/build-angular : 0.13.7
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.3.7
   @ionic/angular-toolkit        : 1.4.1

Cordova:

   cordova (Cordova CLI) : not installed
   Cordova Platforms     : not available
   Cordova Plugins       : not available

System:

   Android SDK Tools : 26.1.1 (/usr/local/share/android-sdk)
   NodeJS            : v8.15.1<EMAIL_ADDRESS>   npm               : 6.4.1
   OS                : macOS Mojave
   Xcode             : Xcode 10.2 Build version 10E125

When I change back the versions (to the original package.json) it will work again.

I might have tracked it down to one single dependency that causes this issue.
Last one working: "@ionic/angular": "4.0.0-beta.17"
Not working: anything higher than<EMAIL_ADDRESS>When creating a new ionic project, it ships with 4.1.0. Which means that it cannot work with a new project. I can pretty much test it by changing the version... from beta.17 to beta.18 or the latest version.

Hi there! This issue does not appear to be an issue with the framework itself, so it will be closed. Please review your issue and open a new ticket on the appropriate project repository, or feel free to post a question on the Ionic Forum. Thanks!


Metric advection demo

I've done the bubble shear test case with metric advection - would it be useful to put it up as a demo? I don't know how niche this is :)

Sure, go for it!

@jwallwork23 could you please tell me how you computed the "relative L2 error" in the bubble shear section in your thesis? I'm thinking what would be the best way to interpolate the fields such that they're on the same mesh - i.e. interpolate the final solution or the initial one onto the other one's mesh, or interpolate both of them on a fine resolution uniform mesh?
I'm also curious how you computed the relative error considering there are 0 values of the concentration field. I don't know if there's a more elegant way to do it than just manually handling those :)

https://github.com/jwallwork23/adapt_utils/blob/master/unsteady/test_cases/bubble_shear/run_adapt.py
Here’s the code. It appears I redefined the initial condition on the final mesh. I think the relative error is meant as a quotient of spatial integrals, rather than pointwise? (I don’t have the thesis open- am on the train.)

Ah sorry, I should have thought myself to look at the code :) thanks for this!

Hi, I am interested in this demo. where can I find the files ?

From: "Davor Dundovic" @.>
Sent: 7/26/24 12:26 PM
To: mesh-adaptation/animate @.>
Cc: Subscribed @.***>
Subject: [mesh-adaptation/animate] Metric advection demo (Issue #144)
I've done the bubble shear test case with metric advection - would it be useful to put it up as a demo? I don't know how niche this is :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Hi @karimnorouzi, the PR is under review at the moment (https://github.com/mesh-adaptation/animate/pull/145) so you can look there. It will likely get merged within the next week


[HMAC] Wipe secret feature misalignment doc vs. RTL

Description
Doc
The wipe secret register, in the intro of the doc (here, last paragraph: https://opentitan.org/book/hw/ip/hmac/index.html), it says that the internal variables will be reset to the written value from this register WIPE_SECRET. But the register description (https://opentitan.org/book/hw/ip/hmac/doc/registers.html#wipe_secret) is saying that a XOR is done instead. So which description should be considered?
RTL
Within the RTL I can see that:

hmac.sv: the secret key is replaced by the wipe_secret register value
prim_sha2: all the internal values are XORed with the wipe_secret register value

Thanks for catching @martin-velay! It seems earlier the secret key and internal values were both XORed with the wipe_secret register value, and then this was changed for the secret key only in this commit https://github.com/lowRISC/opentitan/commit/198acd66883a3f0811ff8554f61d069367f1efc6 triggered by this issue https://github.com/lowRISC/opentitan/issues/8506, hence the discrepancy, and the register description was probably never also updated.
It would make sense, for the sake of consistency (also with clearing in other OT IP), to do the same for the internal values in the sha-2 engine and clear by overwriting with the wipe_secret register value rather than XORing, and I don't see it would have much (or any) impact on DV. Does anything stand in the way of this change @andreaskurth @vogelpi?

I've just had a look at the original issue and the commit (thanks for the references @gdessouky!). In my view there stands nothing in the way of switching from XOR to Overwrite everywhere inside HMAC/prim_sha2.

@gdessouky is working on this -- thx Ghada!

@gdessouky - do you mind estimating how much work is needed for this. I'm assuming that a couple of days of effort is probably more than necessary. Please revise the estimate if necessary.

@johngt - sorry to have not replied earlier, was OoO this week. This PR #22852 would close this issue already, once merged. It was half a day's effort if you still need to revise the estimate.


Is it possible to show year, month, day, hour, minutes in individual column

Hi,
Is it possible to show year, month, day, hour, minutes in individual column ?
In Datetime Picker mode, it's long to go to next years,
Thank ypu

Also expect this feature


Consistently apply list-map typing to Conditions slices.

Patch merge strategy is not supported for CRDs, so we can drop those
markers. Apply the list-map markers to all Condition slices. Conditions
should never be optional, since a controller should ensure that all
Condition types are always present in the status field.
This fixes #342
/cc @robscott @bowei @danehans

/ok-to-test

Thanks!
/lgtm
/approve


Staging always hits the staging-secure endpoint

Problem
We added the ability to toggle between staging and production secure endpoints in staging versions of the app.
However, the .env.staging file points to the staging-secure www instead of hitting production by default
Why is this important?
We need this so we can test certain secure flows on staging app versions. Otherwise, they have to be tested on production.
Solution
Fix the .env.staging file.

Working on this just haven't had time to test it.


[MM-20565] Fix: #13507 - Migrate grouplist to TS

Summary
This PR is for Migrating grouplist components to Typescript
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/13507
JIRA Ticket

@devinbinnie  Thank for your review comments, I have fixed them. Please review.

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

/update-branch

@DHaussermann gentle reminder to review this PR when you have the time

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4922.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

@pankajhirway  Thanks for the fix on this.
I do see a small issue.

When trying to check the box next to a group a JS error occurs and the box is not checked.

react-dom.production.min.js:21
Uncaught TypeError: Cannot read property 'checked' of undefined

The same thing happens when I click "Configure"

This occurs on browser and desktop.

Thanks for testing @DHaussermann .
Working on this issue.

@pankajhirway or @hanzei  would one of you please be able to resolve conflicts on this so I can do the 2nd round of testing?

I don't feel comfortable resolving these conflicts. Maybe @Willyfrog can help?

i've merged locally and seems to not have conflicts and test passes, I'll try that here as well

/update-branch

Error trying to update the PR.
Please do it manually.

i've created a PR against his master, but it feels way too big.
Seems like it's been long since updated against master and I can't tell if it's going to break something else, so I'd say to wait until contributor answers

Hi Guys, Sorry about the delay, will work on resolving the conflict today.

@hanzei @DHaussermann  I am not able to see the Groups link in the side bar. Do I have to enable a plugin or feature ? If so, How can I enable it .

@DHaussermann @hanzei  I see that LDAP is an enterprise feature, How can I test the Groups feature on local machine ?

Hey @pankajhirway,
I did set up a test server which runs the enterprise code. But I'm unsure how easily it's possible to set up an LDAP group there. @DHaussermann Can you help?

@hanzei I can setup LDAP using our test instance but it doesn't seem like the HA server setup is working.  I'm not sure if there is a way we can license the regular cloud server.

@DHaussermann  Can you do one round of tests again please.

Hi @pankajhirway  I was able to

Hi @pankajhirway, I was able to spin up a non HA server and take another look at this.
I do see a JS error occurring in the Groups admin UI. This occurs both when clicking "Link Selected Groups"  as well as when you type a character in the search box

Can you confirm if this is related to the migration to TS?
Also note that the issue I was seeing in the past https://github.com/mattermost/mattermost-webapp/pull/4922#issuecomment-604069112 is no longer occurring 👍

@DHaussermann I have fixed the reported issues (Verified on the Test server), Please re-test.

Thanks for the contribution @pankajhirway :tada:


Initializing JS/TS language features crashing

Type: Bug
I've noticed TS not working as expected recently. It's slow to initialize the TS functionality or never does
VS Code version: Code 1.92.0 (Universal) (b1c0a14de1414fcdaa400695b4db1c0799bc3124, 2024-07-31T23:26:45.634Z)
OS version: Darwin arm64 23.4.0
Modes:

System Info

Item
Value

CPUs
Apple M2 Max (12 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
12, 10, 8

Memory (System)
64.00GB (10.92GB free)

Process Argv
--crash-reporter-id 79d6849b-a4d5-4501-8610-28f360280d97

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

prettier-vscode
esb
10.4.0

copilot
Git
1.219.0

copilot-chat
Git
0.18.1

vscode-jsonnet
Gra
0.6.1

scala
sca
0.5.7

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyonecf:30548226
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
jg8ic977:31013176
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
2f103344:31071589
impr_priority:31102340
nativerepl1:31104043
refactort:31108082
ccplt:31103426
pythonrstrctxtcf:31103194

I disabled all extensions and it is still happening

Please try collecting the TS Server log from the crashed instance:

Set "typescript.tsserver.log": "verbose"

Restart VS Code and reproduce the problem

Open the TypeScript section of the output panel

At the very top, find the first line that prints to path to the semantic error log file. It should look something like:
[Info  - 19:54:59.247] <semantic> Log file: /Users/matb/Library/Application Support/Code - Insiders/logs/20200213T104930/exthost55/vscode.typescript-language-features/tsserver-log-ZT2zau/tsserver.log

That file contains the typescript logs.

Look through that log file for the first error or stack trace you see. If you can share the log, I can also take a look to see if anything stands out

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this


Tissues should be expanded when share link (or Open in Gene Expression) is utilized

Selected tissues should be autoexpanded when a user clicks a share link or clicks Open in Gene Expression from cell guide. We are also seeing intermittent loading errors.
From @dsadgat: Look at neuron in cell guide. Go to marker gene section, computational genes, click link to open in gene expression. See that neuron is not shown within the tissues (default collapsed it looks like). Sometimes, the loading state never goes away. Not quite sure whats happening, but the loading state issue is not always reproducible.

This fix is in prod now!
https://cellxgene.cziscience.com/gene-expression?tissues=UBERON%3A0000916%2CUBERON%3A0001013%2CUBERON%3A0002369&genes=TSPAN6%2CTNMD&ver=2

Actually this scenario is part of share link cellType filter fix that Seve has in this PR

Actually somehow Seve's fix doesn't fix this one:
https://localhost:3000/gene-expression?genes=NRXN1&cellTypes=neuron&ver=2
Will look into it after Make-a-thon!

@seve can you help add your discovery so far regarding this ticket please? IIRC at one point the bug was fixed in your bug fix PR above by adding cell types to the dispatch payload or something 🤔 Thank you!


Lessons learned getting scantron to work.

Do Not attempt to deploy agents from a node you plan to deploy your master on!
Always deploy the first agent before the master.
Create a local ubuntu VM and generate SSH keys via ssh-keygen. Add the public key to your agents and Master authorized_keys file /.ssh/authorized_keys
You’ll need python3-pip installed on (all?) boxes and this is never mentioned
if you install ansible with pip as a user instead of root, you’ll have to add ansible to path
export PATH="$PATH:/home/{username}/.local/bin/"
logout of session completely
you probably want to install net-tools as well
apt-get install net-tools
for this ansible workload to work on IBM Cloud: edit the File "/boot/grub/menu.lst" by changing
# groot=LABEL...
to
# groot=(hd0)
When editing scantron_secrets.json you might not be able to log into the web app if you use different passwords and/or lengths longer than 13 (idk why but this happened to me). The default username is admin
Important there CANNOT be a space between –private-key={location of ssh key} and use -vvv to increase verbosity during first time install to check for any errors. Examples below:
ansible-playbook agent.yml -u ubuntu --become --private-key=../.ssh/id_rsa -vvv
OR
ansible-playbook agent.yml -u root --private-key=../.ssh/id_rsa -vvv
The docs suggest you wont have to add the first agents API key to /root/agent_config but you will!

Thanks for the awesome notes!  Some have already been merged into master from https://github.com/rackerlabs/scantron/pull/37 Please see my responses in bold below.
====
Do Not attempt to deploy agents from a node you plan to deploy your master on!  (I haven't tried this yet, what was your experience, issues you encountered?)
Always deploy the first agent before the master. (already noted in README, "The recommendation is to deploy the agents first.", https://github.com/rackerlabs/scantron/blob/master/README.md#update-agent-ansible-variables,
Create a local ubuntu VM and generate SSH keys via ssh-keygen. Add the public key to your agents and Master authorized_keys file /.ssh/authorized_keys (initial_setup.sh should take care of this, see script below):
#!/bin/bash

# Install Ansible with pip.
echo "[*] Install ansible >=<IP_ADDRESS> using pip"
pip3 install ansible\>=<IP_ADDRESS>

# Generate a passphrase-less SSH key pair for the autossh user.
echo "[*] Generating a passphrase-less SSH key pair for the autossh user"
ssh-keygen -b 4096 -t rsa -f autossh -q -N ""

# Move public key to the respective location for Ansible.
echo "[*] Move public SSH key to the Agent's ansible role."
mv autossh.pub ansible-playbooks/roles/agent/files/autossh.pub

# Move and rename private key to the respective location for Ansible.
echo "[*] Move private SSH key to the Master's ansible role."
mv autossh master/autossh.key

# Create empty scantron_secrets.json from scantron_secrets.json.empty.
cp master/scantron_secrets.json.empty master/scantron_secrets.json

You’ll need python3-pip installed on (all?) boxes and this is never mentioned (Added line noting that for the host box: apt install python3-pip -y) and also to the initial_setup.sh script.  python3-pip is installed on Master and agents through Ansible (https://github.com/rackerlabs/scantron/blob/master/ansible-playbooks/roles/master/vars/main.yml#L11 and https://github.com/rackerlabs/scantron/blob/master/ansible-playbooks/roles/agent/vars/main.yml#L10)
if you install ansible with pip as a user instead of root, you’ll have to add ansible to path
export PATH="$PATH:/home/{username}/.local/bin/"
logout of session completely
you probably want to install net-tools as well
apt-get install net-tools (on host, Master, agent, or all?)
for this ansible workload to work on IBM Cloud: edit the File "/boot/grub/menu.lst" by changing
# groot=LABEL...
to
# groot=(hd0)

(Added Cloud Provider Caveats section with this)
When editing scantron_secrets.json you might not be able to log into the web app if you use different passwords and/or lengths longer than 13 (idk why but this happened to me). The default username is admin (Can you expand on this one some more?  The minimum password length is https://github.com/rackerlabs/scantron/blob/master/master/config/settings/base.py#L225)
Important there CANNOT be a space between –private-key={location of ssh key} and use -vvv to increase verbosity during first time install to check for any errors. Examples below:
ansible-playbook agent.yml -u ubuntu --become --private-key=../.ssh/id_rsa -vvv
OR
ansible-playbook agent.yml -u root --private-key=../.ssh/id_rsa -vvv
(Was this an oversight on your end, or did you copy paste something from the README that had it?  I can't find a discrepancy in the README.)
The docs suggest you wont have to add the first agents API key to /root/agent_config but you will! (Was this prior to running the Ansible playbook?  The README notes that 'The "api_token" will have to be modified on all the agents after deploying master!'

thanks for the detailed reply! we will tackle these issues individually in other issues!


Convert color to alpha texture import option

Godot version:
3.2+
Feature description:
I have a bunch of image assets with black background color (no transparency), replace_color method could be used to replace any background color in an asset to transparent one. This could be set as an import option in Process section (among Fix Alpha Border and other stuff).
For instance, GIMP has such method: Color to Alpha.
This doesn't have to be too sophisticated, simple color replacement would be enough.
This is also a convenient feature in the case where one forgets to turn off the background layer used for making an asset on export.

Of course it's possible to make an automated batch script that converts color to alpha in GIMP, but making such script takes time and effort, and with  Godot's multi-select-reimport feature this becomes rather easy.
See #9623.

For instance, GIMP has such method: Color to Alpha.

GIMP's color to alpha implementation handles translucency, which a simple color replacement wouldn't.

Figured this should be possible to do with a custom EditorImportPlugin, something like:
func get_import_options(i):
    return [{"name": "color_to_alpha", "default_value": Color(0,0,0,0)}]

And of course by overriding all other virtual methods to make it actually work!


calculate plot size given the parameter k

Using a formula instead of a constant is better for improving plotman to work with plots with a different k.
Formula from Chia Proof of Space Construction "Space Required" section.

Test failed because the test file size 100GB is too close to rule out that is not a k32 plot.

I'm not sure where the diffrence come from. I'll take a look into it.

The formula in the document, assumes that each entry on average takes k bits.
But the entries are "parked", that is, each 2048 entries are stored together as a group.
But the actual size needed for each park is different.
Chia used constant park size to increase performance.
So, there are spaces wasted in the parks.
By looking into the source code of chiapos, I am able to find exactly how park size is calculated and thus account for some of the space differences.
I wrote code to find out the plotsize taking park sizes into account. plot_size.py:
# the following constants are from chiapos pos_constants.hpp

# EPP for the final file, the higher this is, the less variability, and lower delta
# Note: if this is increased, ParkVector size must increase
kEntriesPerPark = 2048

# To store deltas for EPP entries, the average delta must be less than this number of bits
kMaxAverageDeltaTable1 = 5.6;
kMaxAverageDelta = 3.5

# The number of bits in the stub is k minus this value
kStubMinusBits = 3

def calc_average_size_of_entry(k, table_index):
    '''
    calculate the average size of entries in bytes
    the average size of entry is approximately k/8 bytes
    but due to wasted space of parks, it is larger than that
    '''
    return calc_park_size(k, table_index) / kEntriesPerPark

def byte_align(num_bits):
    return (num_bits + (8 - ((num_bits) % 8)) % 8)

def calc_park_size(k, table_index):
    '''
    park size in bytes for storing kEntriesPerPark = 2048 entries
    it is approximately kEntriesPerPark * k / 8, but it is actually larger than that
    derived from chiapos EntrySizes::CalculateParkSize
    '''
    line_point_size_bits = byte_align(2 * k)
    stub_size_bits = byte_align((kEntriesPerPark - 1) * (k - kStubMinusBits))
    max_delta_size_bits = byte_align((kEntriesPerPark - 1) * kMaxAverageDeltaTable1 if table_index == 1 else (kEntriesPerPark - 1) * kMaxAverageDelta)
    return (line_point_size_bits + stub_size_bits + max_delta_size_bits) / 8

def get_probability_of_entries_kept(k, table_index):
    '''
    get the probibility of entries in table of table_index that is not dropped
    the formula is derived from https://www.chia.net/assets/proof_of_space.pdf,  section Space Required, p5 and pt
    '''

    if table_index > 5:
        return 1

    power = 2**k

    if table_index == 5:
        return 1 - (1 - 2 / power) ** power    # derived from Space Required p5
    else:
        return 1 - (1 - 2 / power) ** (get_probability_of_entries_kept(k, table_index + 1) * power) # derived from Space Required pt

def get_plotsize_scaler(k):
    '''
    get scaler for plot size so that the plot size can be calculated by scaler * k * 2 ** k
    '''

    result = 0
    for i in range(1, 8):
        probability = get_probability_of_entries_kept(k, i)
        average_size_of_entry = calc_average_size_of_entry(k, i)
        scaler_for_table = probability * average_size_of_entry / k
        #print(f"probability = {probability}, size = {average_size_of_entry}, scaler = {scaler_for_table}")
        result += scaler_for_table

    return result

console output:
k = 20, scaler = 0.792, size = 0.02 GB
k = 21, scaler = 0.790, size = 0.03 GB
k = 22, scaler = 0.789, size = 0.07 GB
k = 23, scaler = 0.788, size = 0.15 GB
k = 24, scaler = 0.787, size = 0.32 GB
k = 25, scaler = 0.786, size = 0.66 GB
k = 26, scaler = 0.785, size = 1.37 GB
k = 27, scaler = 0.784, size = 2.84 GB
k = 28, scaler = 0.783, size = 5.89 GB
k = 29, scaler = 0.783, size = 12.18 GB
k = 30, scaler = 0.782, size = 25.19 GB
k = 31, scaler = 0.781, size = 52.01 GB
k = 32, scaler = 0.781, size = 107.29 GB
k = 33, scaler = 0.780, size = 221.14 GB
k = 34, scaler = 0.780, size = 455.37 GB
k = 35, scaler = 0.779, size = 936.82 GB
k = 36, scaler = 0.779, size = 1925.98 GB
k = 37, scaler = 0.778, size = 3957.05 GB
k = 38, scaler = 0.778, size = 8123.48 GB
k = 39, scaler = 0.777, size = 16665.72 GB

This is indeed much closer than 0.762. It turns out the scaler is different for different k, probabally due to space waste differences.

Is there any of the Chia code that would be useful to copy and paste?  We already to that for the command line parsing of plotting processes so we could do it for other bits as needed.  Also, there is a mechanism to track the different versions of chia, though they haven't changed that code since we started copying it.
https://github.com/ericaltendorf/plotman/blob/1876d4cbda73fb38584f95113a00f01af1e21704/src/plotman/chia.py

Oh, and thanks for the hard work here.  :]

We cannot copy the code in this case, because chiapos is implemented in C++. I changed them a bit to run in python. Also, I think the code is too complex for this simple usage.

I would default to having the actual calculations present in the code.  If they are kind of slow then we can run them as needed, or at start up, and cache results.  If they are super slow then we can consider pre-generation.
I think it is reasonable to continue these here and view this PR as a general improvement on the assumptions and simplifications that plotman has at present.  It would be good to provide pinned links in the code to the C++ code it 'mirrors'.  This allows for easier maintenance and verification.  Let's pin the links to release versions as in the link I shared for the copied code.
I'm thinking I may restructure that to have a separate module per version like plotman/chia/v1_1_5.py or such and an interface to get at each by just latest version or a specific version.  But, I can follow up with that when I have time.  In case I hadn't mentioned it to you, I forget where I wrote it, I imagine that we could identify the version of chia that each plotting process is using and use the proper cli parser etc for it.  Someday...

I moved to code that is from chiapos to chiapos.py, since it is different from chia-blockchain.
I think code ported from chiapos should not be duplicated every time there is a new version, since the code from chiapos is much less likely to change.

I just realized that the size calculated here is the minimal size of the plot file. So we expect an actual file will be about 1-2% larger than it(I guess, there is no proof though). This can be used to tell whether a plot file is of certain size K and whether it is complete.


Create a dimensionality reduction enrichment function

This function takes a multi-table dataset and clusterize the secondary table variables and then adds them to the secondary table.
The methods returns the enriched dictionary file path.

Will be obsoleted when the new instance-variable coclustering algorithm will be available.


Tutorial: Using aas-timeseries with Kepler data

This notebook will be a brief introduction to the Python package aas-timeseries, focusing on how to use it to visualise Kepler data. Aas-timeseries is already extensively documented, so this tutorial will not aim to replicate the documentation, but rather to highlight how it can be most useful for Kepler data and how it interfaces with Lightkurve's functionality.
Learning goals:

Visualising Kepler data in an aas-timeseries figure
Working with Astropy units to create data arrays with attached quantities
Using Kepler metadata to create a "view" in an interactive aas-timeseries figure

👍

This notebook is now ready for review! Please note that it's offline only, as aas-timeseries interactive figures are not currently supported by Google Colab.

Hmm, I'm confused!  I keep running into this error which I haven't been able to debug yet:

@barentsen That's curious, I haven't encountered that one. I'm running the notebook locally in a Jupyter notebook, where it displays the figure as expected. Out of curiosity I tried running it on colab again, and did not see this error there either, but there did seem to be some issues with the inline install of Astropy, so I've commented out that line for now.

If you have time, can you tell me what version of the following packages you have installed:
aas-timeseries
jupyter-aas-timeseries
astropy

(you can probably just grep this from the output of pip list)

@barentsen Here are my versions:
aas-timeseries         0.1b4
jupyter-aas-timeseries 0.1.7
astropy                4.1rc1
traitlets              4.3.3

Looks like I got the first part working by downgrading traitlets from 5.0.4 to 4.3.3.  (All other versions are the same.)

I think it's best not to merge this tutorial into the space telescope repo until we've opened an issue on the aas-timeseries repo to figure out the errors we're seeing, however the notebook looks great otherwise and I think the text content is ready for copy editing!
The filename is Using aas-timeseries with Kepler data.

@astrobel and @barentsen I finished copy editing this notebook. It was in good shape writing-wise, I made small copy edits throughout. It's all set on my end!


[SPARK-12447][YARN] Only update the states when executor is successfully launched

The details is described in https://issues.apache.org/jira/browse/SPARK-12447.
@vanzin Please help to review, thanks a lot.

Test build #48108 has started for PR 10412 at commit 9923e58.

Test build #48108 has finished for PR 10412 at commit 9923e58.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48108/
Test FAILed.

Jenkins, retest this please.

Test build #48113 has started for PR 10412 at commit 9923e58.

Test build #48113 has finished for PR 10412 at commit 9923e58.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48113/
Test PASSed.

ping @vanzin you had started reviewing this, do you have time to take another look?

This one fell through my radar... @jerryshao could you resolve conflicts and look at the comments? thx

Sure, I will do it.

Test build #60250 has started for PR 10412 at commit fba6e5c.

Jenkins, retest this please.

Test build #60251 has started for PR 10412 at commit fba6e5c.

Test build #60250 has finished for PR 10412 at commit fba6e5c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60250/
Test PASSed.

Test build #60251 has finished for PR 10412 at commit fba6e5c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60251/
Test PASSed.

LGTM, merging to master / 2.0.


Doesn't work on disabled element?

When I apply the directive to a <button> element that has either the disabled attribute or a CSS property of pointer-events: none, then the tooltip won't be shown.  It seems like the display of the tooltip is dependent on the cursor being in a normal state, and not any state that would be associated with a disabled element.
That's a problem, because there's a common use case of needing to display a tooltip for a disabled element, to explain why the element is disabled.
Is this something that any option on this directive can control, to enable the display?

@donp-kitcheck I did not find a way to get mouse events on a disabled button. Try using class="disabled" instead of the disabled property and add CSS properties for this class.
https://stackoverflow.com/questions/16109228/clicking-a-disabled-input-or-button/16109366

You can also wrap another element around it!
I.e.:
<span style="display: inline-block" tooltip="I'm disabled!">
    <button type="submit" disabled>Save</button>
</span>


fix: YAML was invalid, and application/json is the default anyway

Awesome! thanks @ojongerius that seems to have fixed it.


关于无法进行explore的问题

我执行了这两个代码，但是会出现这个报错，然后机器人不作任何运行：
roslaunch xju_simu simple_world.launch
roslaunch xju_explore explore.launch
执行的launch如下（是与视频中一致的）：

出现问题：
[ WARN] [1719835548.911818530, 1365.695000000]: Timed out waiting for transform from base_link to carto_map to become available before running costmap, tf error: canTransform: target_frame carto_map does not exist.. canTransform returned after 1365.69 timeout was 0.1.
小车没有执行任何动作想问问应该怎么解决呀

Some function packages are missing. Some function packages in the thirdparty folder need to be downloaded and compiled, such as navigation, teb_local_planner, costmap_converter, etc.

缺少一些功能包，thirdparty 文件夹里的一些功能包需要下载下来编译，如navigation 、teb_local_planner 、costmap_converter 等


Typechecking

Tighten up the typechecking on HolidayBase
ditto holidays.utils
then I did the UK, because it's nearby
then I picked off a couple of the more egregious warnings where the same function was defined twice
then I'd had enough, I certainly don't intend to go through every country...

(need a more recent version of black to fix the workflow)

rebased this - and #662 - on the beta branch so as to pick up updated black and in the expectation that the workflow will now pass

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

30 of 30 (100.0%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.1%) to 99.042%

Files with Coverage Reduction
New Missed Lines
%

holidays/holiday_base.py
1
92.73%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
6428

Relevant Lines:
6442

💛  - Coveralls


about models

Can you provide the model used by the project again? The link in the readme file has expired.

Can you open source the model and dense_depth dataset? as shown

Please try it again. Just  ignore these images wth dense.


Unpin xarray

xarray 2024.7.0 works very well with gpm-api. No need to pin. The datatree integration is still ongoing and datatree-package can be used without issues.
https://github.com/conda-forge/gpm-api-feedstock/blob/6af7be2c4722d8cad2613317444da921c5346be7/recipe/meta.yaml#L30

Resolved by #7 :+1:


Question about the download links

Could you please publish a link to all of the Baidu Netdisk files? I wish to download all the model files quickly rather than one by one.

Is there any plan to save the model files to other netdisks? For example, Google Drive or Dropbox. It should be very convenient for oversea researchers.

Many thanks for your work!

After uploading all data, we will release a link to all files.
Considering free space of Google Drive(15GB) and Dropbox(2GB), we chose Baidu Netdisk(1 TB free space) to store files.

@shenshen-hungry
Thanks a lot for your prompt response!
Could I upload the model files in this repo on Google Drive with your license/credit? I have an educational Google Drive account of my previous university.

Right now all the links does not work!
Or there might be something wrong with the Baidu Netdisk?

@imWildCat Thanks for your proposal. We're going to discuss if uploading files to Google Drive.

@bruceyang620727 I tested the links in China, Korea, Japan and the US. But I didn't meet any problems.

Hi Shenshenphungry,
I have tried every links and I got nothing but the response below:

@bruceyang620727 I guess the problem may be caused by your location or web browser. Using a VPN or changing browser could help you download the data.

Dear shenshen-hungry,
Ya! I think you are right cause I totally forgot the VPN^^

I felt sorry about these links!
Neither the browser Chrome with VPN nor my cellphone could download the files for each links.
Plus, there is not a response from the web chrome!
However, the response from cellphone is as below:

@bruceyang620727 Did all of links return this page?

Yes! all of the links return the same page

Hi shenshen-hungry,
I wonder if there is any good news since yesterday

@bruceyang620727 I'm so sorry. Yesterday, I tested all links with several VPN from different countries, but found nothing can cause this error. We'll decide if uploading files to Google Drive or other net disk s not in China.

Dear shenshen-hungry,
Grateful to hear the good news and appreciate for your kindly understanding^^

Hi shenshen-hungry,
I am also facing difficulty in downloading word2vec files. I am asked to create an account on Baidu app Because i dont have knowledge of chinese, not able to sign up. Not able to register through my indian mobile number.

Does some version of models are present on some google drive link, which overseas people can access.

@SwatiTiwarii This url (https://passport.baidu.com/v2/?reg&overseas=1) supports oversea phone number (except for Europe).


Obsolete flutter_native_timezone dependency in feat/macos-support branch

Describe the bug
flutter_native_timezone has become stale. It has been removed on develop branch but was brought back in feat/macos-support. flutter_native_timezone uses the kotlin version that is no longer supported by more recent kotlin plugin that comes with Android Studio. Hence I can't build or run the app using device_calendar on Android
To Reproduce
Steps to reproduce the behavior:
Compare the pubspec.yaml files on these branches.
Expected behavior
flutter_native_timezone should be removed from feat/macos-support as well.
Device(s) tested
This can be very important as not all device vendors do calendar in the same way.

OS: Android

Thank you @ash80. I missed this when creating the feature branch.
It is removed now.

In case you still cannot build or run the app on Android, please reply here and I will open the issue again.

Built successfully! Thanks

@IVLIVS-III Hey, device_calendar [4.3.1-4217521123] still fetching flutter_native_timezone. Am I doing something wrong?

@DanilKarasev as far as I see, flutter_native_timezone has only been removed in the develop branch and any other branch based on develop, (e.g.: feat/macos-support).
It is still listed as a dependency in the release branch.
Hence it is downloaded when you depend on any (pre-)releases from pub.dev.
I guess it will be removed when publishing version 5.0 of device_calendar.

@IVLIVS-III Thanks! Then I guess only option now is to clone repo and use it as local package as of now.

While all new stuff should go to 5.x now, I feel we should at least keep 4.X usable and vulnerability free (without too much effort)
So 4.3.2 perhaps?

Any idea when this can be released ?

Same problem here.
Could you publish a version 4.4.0 or similar that uses flutter_timezone instead of the stale flutter_native_timezone?
Thanks.

All maintainers are ob a really low time-budget at the moment. Please provide a pull request, that addresses your concern.
This will be the fastest way to get this issue fixed.


Fix formatting and add clarification re. new dashboards

@timhallinflux Updated with those suggestions.

@russorat -- have a peek at this and make sure you are happy with this treatment.  It's tough teasing apart the host specific, pre-canned, and unchangable "dashboards" from the proto-board, dashboard templates which can span hosts are changable ...etc.   They appear in different spots...etc.


Song suggestions

Suggest some songs to the user based on the artist whose song was just downloaded.

already a part of issue #20.


Do not echo printf return value

The current implementation would echo both the contents and printf return value which is incorrect. This commit fixes the issue.

Perhaps  would accomplish the same thing, but be more in line with the style of project?

Yes. I can change to that if you wish.

Thanks :)

Done.


Support Domain Checksums

Enable domain checksums - an aggregation of all ETag values for all objects within a domain.
These will be created asynchronously using the same process as with domain info.

Changed REST api for requesting a rescan: https://github.com/HDFGroup/hsds/commit/6b6680aafccbb916419de952e09db41e7632a53d

This should be working.  An MD5 checksum is computed over all chunks and metadata objects in the domain (other than the domain json (i.e. changing the ACLs doesn't modify the checksum).
hsinfo can be used to show checksum for given domain.    You can use hsinfo --rescan <domain> to force checksum to be computed.


roslaunch urXX_moveit_config ur5_moveit_planning_executing.launch

It seems a typo. It should be 'execution'.

maybe this could be closed, right? it's fixed on the kinetic-devel branch

Yes, this should've been closed with the merge of #226.


Using Manager, does not require to set database on the Model

When using a Manager, setting a database on the Model is not necessary.
We can assume that in case where database is not set on the Model, and the database is set on a Manager, that the Manager database is correct and we can safely swap it.

Thank you @tsifrer but the manager is deprecated and will be removed in version v1.0.0


Validate flag for helm_remote extension

I have found an issue with one of our Helm charts.
Error: chart requires kubeVersion: >=1.21.0-0 which is incompatible with Kubernetes v1.20.0\n\nUse --debug flag to render out invalid YAML
My Kubernetes version is 1.25.3, so I suspected helm. Here is the solution: https://github.com/helm/helm/issues/10086#issuecomment-909595139
But the case is Tilt built in helm function doesn't support validate flag, so this change uses a custom template command which optionally validate-able.

This had to be rolled back because it broke namespace injection. https://github.com/tilt-dev/tilt-extensions/issues/506.
Sorry, I should have caught this. The helm() built-in does its own namespace injection because helm template does not. There's a longer history on this here: https://github.com/helm/helm/issues/5465
i think the best way to move this forward is to add the validate argument to the built-in helm() function. would you be willing to put together a pr for that?

@nicks Thanks to catch the problem :) Does it make sense to reopen the PR with an appended  namespace?
yaml = local(namespace + build_helm_command(helm_tpl_cmd, None, None))


New configuration not applied after creating admin user

Can you provide a little description of what's wrong?

Sorry man, I completely overlooked your commit. I see what you mean. Riak also needs to be restarted, since it's configuration also changes. All must be fixed now.


Check Team Availability flow zip is not in the package

Check Team Availability flow zip is not in the package I downloaded.

Check Team Availability flow zip is not in the package I downloaded.

This flow is part of the Power App package and will be created when you import the Power App. Thanks

Thanks Alex 🤦♂.
Can't believe I missed it! It's been a long day.


Simpleobsws to perform the scene change

Hi !,
i would like to use your software to run a certain scene in obs;
these are the scenes currently loaded in my obs:
request = simpleobsws.Request( "GetSceneList" )
"scenes": [
{
"sceneIndex": 0,
"sceneName": "Scene 5"
},
{
"sceneIndex": 1,
"sceneName": "Scene 4"
},
{
"sceneIndex": 2,
"sceneName": "Scene 3"
},
{
"sceneIndex": 3,
"sceneName": "Scene 2"
},
{
"sceneIndex": 4,
"sceneName": "Scene"
}
]
I would like to use the "set Scene Name" (or another) function to execute, for example, "Scene 5", but I don't understand the syntax of the command itself.
Can you please give me a correct example to run, through your script "sample_request.py", the execution of a certain scene, among those present in obs studio
Many thanks !

Hi, I second that. I have built a control hardware using a raspi, and want to change the scene on the touch of a button. For that I also need a hint in the right direction. The request eample does not show how to pass parameters. I want to know how I can set the reuqest parameter for 'SetCurrentProgramScene' request. Thanks

Hi, I found it. Here is a python example code:
import logging
logging.basicConfig(level=logging.DEBUG)
import asyncio
import simpleobsws
parameters = simpleobsws.IdentificationParameters(ignoreNonFatalRequestChecks = False) # Create an IdentificationParameters object (optional for connecting)
ws = simpleobsws.WebSocketClient(url = 'ws://ip:4455', password = 'password', identification_parameters = parameters) # Every possible argument has been passed, but none are required>
async def make_request():
await ws.connect() # Make the connection to obs-websocket
await ws.wait_until_identified() # Wait for the identification handshake to complete
request = simpleobsws.Request('GetVersion') # Build a Request object
request = simpleobsws.Request('GetSceneList') # Build a Request object
data = {'sceneName': 'Beach2'} #, f'inputSettings: {url}': url}
request = simpleobsws.Request('SetCurrentProgramScene',data) # Build a Request object

ret = await ws.call(request) # Perform the request
if ret.ok(): # Check if the request succeeded
    print("Request succeeded! Response data: {}".format(ret.responseData))

await ws.disconnect() # Disconnect from the websocket server cleanly

loop = asyncio.get_event_loop()
loop.run_until_complete(make_request())

@McMornan thanks for the code. Really really helpful !!
If you have found other similar requests please share them.
Thanks again


Ambiguous constructor matching is not working well

Fixes #69

Do we also need to fix https://github.com/aspnet/Common/tree/dev/src/Microsoft.Framework.ActivatorUtilities.Sources?

Couldn't tell if the test scenario of a ctor with an IEnumerable<TService> and other more complex DI scenarios are covered here... are they?

@davidfowl Since we can't do the service registration lookup as part of ActivatorUtilities, the plan was to not change its current behavior.

@Eilon Doesn't cover IEnumerable<TService> - I'll add a few combinations tests that deal with it + generic types. I'll work under the assumption that we are in no way special casing collection types. For instance we won't treat these as overlapping:

public Foo(List<IService> services)
public Foo(IList<IService> services, int count)

Updated

:shipit:

:shipit:


Beautify the code

Changes in this pull:

Change var to let in as many cases as allowed
Beautify the code.
Literalize specific strings, instead of using primitive concatenation.
Add use strict at the top of files without.
Change == to === and != to !==

. . . so did you test it?

Test successful!

why do you hate semicolons? and why do you replace var's with let but not use const when appropriate?
I would not replace var with let inside loops.. if you don't want any var in your code you could define the variables outside of the loop.

To be clear I'll change my upvote once the controller message is fixed.

Changed.

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

4
0
0
4

Vote Breakdown

User
Yes
No
Abstain

lurr
✔

ags131
✔

TheRealMaxion
✔

tedivm
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


Recording the names of people who want to be kept up to date

The following participants at MozFest wanted to be kept up to date with future developments of this work:
@sonyahanson
@kynan
@rissom
@Charc248
@Sam1360
@Ourobot
@dvigneshwer

@npch The session was very informative, can we particpate in any ongoing issue with our feedbacks ?

@dvigneshwer once we have typed up the input from the workshop, we will create a set of issues representing things we'd like people to provide input and contribute effort.
Until then, please create new issues for anything you think it is important that we discuss as a group. Look forward to your contributions.

Awesome


Various fixes

This PR includes a number of fixes and improvements.  The changes are as follows:

Add ts-node as a dependency
Force download of spec.html if it doesn't exist (current behavior: script errors and crashes)
Ensure that generated folder exists before attempting to write a file inside of it
Add additional logging to scripts

Congrats on making the first blood!


New Extension - Swap In Out

This extension works with the etleneum.com Chainmarket contract and allows to send LN to onchain and vice versa.
Swap Out let's you take satoshis from an LNbits wallet to an onchain address.
Swap In allows for funding an LNbits wallet with an onchain transaction.

Congrats. Looking forward to testing

This is going to be really useful for a BTC-to-fiat extension 🌮

Oooo, fresh commits, will test now

What happens if two people pay on onchain address at the same time

The etleneum contract prevents that! When you click reserve, on the swap
in, the offers are no longer available for other users!
Check the contract here: https://etleneum.com/#/contract/c8w0c13v75
On Thu, Mar 24, 2022 at 11:37 AM Arc @.***> wrote:

What happens if two people pay on onchain address at the same time
—
Reply to this email directly, view it on GitHub
https://github.com/lnbits/lnbits-legend/pull/551#issuecomment-1077533142,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC4F74Q7FGLBRSZFDOEVKGTVBRHYTANCNFSM5P5OZOAQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

It doesnt. Two people could send funds at the same time

etleneum shut down today :(
https://twitter.com/etleneum2/status/1550109786250760192

Sad end for this PR. Botlz soon though!


Trouble with custom model hosted on OpenAI compatible endpoint

I'm having a really hard time using alpaca_eval for a seemingly trivial and widespread use case. This benchmark is a frequently referenced metric, and many models have an alpaca_eval score. I have a custom model I'm working on, it's currently hosted on an openai-compatible endpoint. e.g. mymodelnfererence_provider.com/openai/v1 and I just want to evaluate that model with all defaults. the default evaluator/annotator etc...
I can't seem to find an example of this use case. There are many examples in model_configs. Though, its not clear how the OpenAI base URL is configured differently for the case of the openAI compatible model endpoint, vs. the annotation process where we alwayts call to openai proper.
atomic-0:
  prompt_template: "/Users/tastycode/workspace/nola-ai/evalite/model_configs/atomic-0/prompt.txt"
  fn_completions: "openai_completions"
  completions_kwargs:
    openai_api_base:
      "https://api.runpod.ai/v1/vllm-tmdlg8/openai/v1"
    model_name: SARG-ai/atomic-0
    temperature: 0.7
    top_p:
      1.0
  decoder_kwargs:
    model_name: "gpt-4"
    num_procs: 1
    batch_size: 1
  pretty_name: "Atomic 0"
  link: "https://huggingface.co/SARG-ai/atomic-0"

unfortnuately, i still ended up having to monkey patch decorders/openai so that my custom model name would not be sent to actual openai.
Once I run the eval with  OPENAI_CLIENT_CONFIG_PATH=/workspace/nolai/evalite/client_configs/openai_configs.yaml alpaca_eval evaluate_from_model \   --model_configs '/workspace/nolai/evalite/model_configs/atomic-0'
I'm happy to offer making the following changes:

Outlining a clear example of evaulate_from_model where the model is accessible via OpenAI compatible endpoint
Explaining what an annotator is, and how it is different from an evaluator including examples demonstrating why one might choose to define an annotator, when it's best to use a particular combination of evaluator/annotator
Explain the difference between a decoder and an annotator
Explain how the decoder, annotator and evaluator and "client" work together to produce the alpaca eval score

If you could share any guidance on the above , it would be quite helpful. The current command fails with
WARNING:root:Unknown error.
 It's likely a rate limit so we are retrying...
INFO:root:Sleeping 2 before retrying to call openai API...
 Did you mean to use v1/completions?', 'type': 'invalid_request_error', 'param': 'model', 'code': None}}.

It seems that what you want from AlpacaEval is only the annotations. AlpacaEval also provides the code to generate outputs for your convenience, but if you prefer generating the outputs on your side you should go ahead: you definitely do not need alpaca_eval for that! Given the completions/outputs simply use: alpaca_eval --model_outputs 'example/outputs.json'. We provided some code for completions (alpaca_eval evaluate_from_model  --model_configs 'example') to make it easier to use, but you definitely do not need that if you don't find it natural.
To answer your questions:

see this config for an example of a model that uses openai_client with a different end point: https://github.com/tatsu-lab/alpaca_eval/blob/main/src/alpaca_eval/models_configs/Mistral-7B-Instruct-v0.2/configs.yaml. Why are you setting decoding_kwargs and where did you see that? that's not a thing...  Note that one slight challenge is that you will need a different API key for generating your outputs (calling your server) and for calling OpenAI for annotations. Given that use OpenAI client in both cases, that means you need to set OpenAI API key twice to something different. You can do that by setting your client_configs like that:

default:
    - api_key: "<your OpenAI API key here>"

SARG-ai/atomic-0:
    - api_key: "<some_local_api_key>" # use your local key for your model

Annotators are the actual object that perform the annotations (i.e the LLM as a judge object). At a high level the input is a dataframe containing the input and output pairs, and the output is the score as evaluated by the model. For historical reasons, decoders = completion functions (e.g. openai's, anthropic's, vllm's), those are helper functions for uniformizing the API to all the different ways of generating text from a model. They are text in text out, and they not specialized at all for AlpacaEval. We use them both inside the annotator (for getting the output given the desired prompt) and for generating outputs.


export: add extra columns from outbound fks

Change the main entity request to attributegroup and add extra meaningful column values for outbound foreignkeys. For example showing the RID of a foreignkey value might not be useful, and we might be able to replace it with other fields (the same type of heuristics that we have for row-name). See #701

This has been merged with master. Assigning to @hongsudt for review, and suggest extra changes if needed.

#785 and #786 has been created for further changes regarding this. I am going to close this issue.


Update Get-PnPAzureADAppSitePermission.md Documentation

Type

[ ] Bug Fix
[ ] New Feature
[ ] Sample
[X] Doc Fix

Related Issues?
What is in this Pull Request ?
Fixed wording of documentation and added missing example descriptive text.

Thanks @LeonArmston !


Virtual Machine log tab shows master zone VM id corresponding log

Description
When setting up a federation, the VM log tab of a VM belonging to the slave zone, seen through the master zone login session, shows the VM log of the VM in the master zone instead, if it doesn't exist, it shows
Log for VM <id> not available
To Reproduce

Setup two zones
Create a VM in the slave zone
Create (or not) a VM with the same id in the master zone
Log in through the frontend of the slave zone and lookg at the VM log
Log in via the master zone
Switch to the slave zone view
The VM log seen will be the one corresponding to the VM with the same id existing in the master frontend.

Expected behavior
View the log of the VM of the slave zone through the master zone login via the slave zone view.
Details

Affected Component: Sunstone
Version: 5.8.1, 5.8.2

Additional context
Two pictures of the same VM, seen from slave zone login session, and seen from the master zone login session but switching to the slave zone view. The logs are diffrent, but it show be the same.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Currently the VM logs are read from the frontend via its filesystem by the sunstone server
that limitation affects the info shown when the sunstone server and the oned managing the VM are not in the same server.
It will be added a check for the VM log, such that, when sunstone and oned are not in the same server, the last 15 lines of the VM log will be added to the VM template and that information will be shown in the VM log tab.
The master zone will still show its filesystem logs.

We'll do this in two phases

Disable VM log tab if the VM is remote on a federated oned
Add a new API call, one.vm.log, that includes log information. This will be useful in HA and federation scenarios

PRs to merge:

one: #4826
doc: OpenNebula/docs/pull/1153


updated the token name and symbol only

updated the token name and symbol only
Originally posted by @jlewko10 in https://github.com/solana-labs/token-list/issues/12611#issuecomment-1006516498
Wanted to update token name and symbol but cannot automerge since the token is edited now. Can someone review and accept my PR?

Please help me with above

didyou able to get it

closing due to inactivity, please reopen if still an issue


Challenges of Getting Started translated to Indonesia

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[x] Add new translation (feature adding new translations)

Checklist:

[ ] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #8025

Description

Add Indonesia Translation for Getting Started.

@tamami thanks for the pull request, can we have someone to do a peer review. We can merge post that.

Just want to point out that this translation is only for the first challenge of Getting Started.

Awesome @alistermada thanks for QA. Letvus know when this is ready.

@raisedadead I'm unsure about the usage of some untranslated terms like project, code/coders/coding, and software development. I can confirm that translations are accurate, although the translation for "user story" is a bit iffy.
I'll ask other Indonesians to help review. We haven't yet established a set of rules to how tech terms will be translated.

Okay, thanks for the update @alistermada just let us know when this is ready to be merged. Blocking meanwhile.

Closing as stale. Please resubmit when ready.
Happy Coding


Can't minify v3.6.7

Expected behaviour
Correct minification
Actual behaviour
No minification. With a previous version of the library (3.6.3) no error was showing.
Steps to reproduce
Environment

Browser: -
Version: -
Operating System: -
Version: -

Console errors (if any)
GulpUglifyError: unable to minify JavaScript
Caused by: SyntaxError: Unexpected token: operator «>»
Link to where the bug is happening

Duplicate of #2174 2174


E2E: go workflow_dispatch main SLSA3 config-noldflags

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2465646248
Workflow name: go workflow_dispatch main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.main.config-noldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Thu Jun  9 03:01:52 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2470238628
Workflow name: go workflow_dispatch main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.main.config-noldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Thu Jun  9 18:07:19 UTC 2022
Tests are passing now. Closing this issue.


Deploy rubygems after succesfull build using travis-ci

After a commit to master the gem will be built and pushed by Travis-ci  into rubygems for immediate publish.
@aphyr i cant enable travis-ci for the repo, it requires admin on it, if you have the time please login into travis-ci and enable the builds for riemann/riemann-mongodb before merging the branch, thanks!

OK, I think Travis-CI is good to go. Merging. :)


Remove snark-test from CI

The snark integration test only tests features tested in other integration tests. Removing it to lower cloud resource usage.

!ci-build-me

!approved-for-mainnet


Use #trailing_zeros_count in Int#gcd

I tried to use tzc when implementing it the first time, but got a whole lot of wrong results when I ran my benchmark suite over a bunch of inputs. Lets hope this is more correct than when I tried it :sweat:

For reference, I tested the new implementation against the old one for a couple million random numbers from all primitive number types and both methods always returned the same value.
You are receiving this because you commented.Message ID:
@.***>

I ran this on a Linux based AMD Ryzen 9 5900HX, 4.5GHz, 8C|16T laptop.
What special things need to be enabled to compile it more optimally?


Added support for Date objects

Added the following to service.parse:
    if (iso8601 instanceof Date){
      return iso8601;
    }

Including unit tests and update of the demo. please tell me if any changes are necessary from my side. thanks.

Thanks for the contribution @amitit! Looks good.


How to proceed with interrupted svn2git

Hi,
I thought this is a pretty common scenario, but somehow couldn't find any useful suggestion on how exactly to proceed. So please excuse me if it is already discussed elsewhere.
I am converting a fairly large svn repo , something like 70 GB by using svn2git ..repo-url in verbose mode. After it ran for over 2 days and still not done with git svn fetch, I lost network connection; so the process got interrupted.
I ran the git svn fetch manually so that it doesn't run the git init again. I thought it would be smart enough to pick up from where it left but going by the messages looks like it is re-fetching the same content. Appreciate if someone can point me how to proceed  assuming I may not be continuously on the network. If svn2git can be broken down into git init, git fetch etc, what will be the subsequent commands.
If it helps I migrated the trunk alone with --trunk trunk --nobranches --notags, which itself took like 6 hrs or so. Now I want to migrate the branches + tags
Thanks.

Had a similar problem but lost the connection when my VPN dropped out. I'm trying again using a machine on the same network first, but I'll look into your local mirror approach if it hasn't completed by tomorrow.

With svn2git version 2 or later, you may also want to try using svn2git --rebase as suggested here. This is the same thing you would do to keep the git mirror synced with the svn source, as documented in the README.


http: name-resolver is never invoked

Hi,
I was trying to use the async DNS option and hit a little wall.
(http/connection-pool {:dns-options {:name-servers ["<IP_ADDRESS>"]}})

result
it continues to use my local setup.

fix
in create-connection, (InetSocketAddress. host port) does the resolution and thus bypasses the name resolver from Netty.
With the following fix, I've got the expected network datagrams.

Thanks for catching this.


[FEATURE]: Collage Preview

Is your feature request related to a problem?
No
Description
No response
Describe the solution you'd like
A Option to Show with part of the Collage you are actually taking at the time and a real time Preview where you can See the incomplete collagen coming togehte
Describe alternatives you've considered
None
Additional context
No response

Hey and thanks for your request. Sure we can think about a post processing after every taken image, but this would have an impact to the performance (especially to Raspberry Pi which are used a lot) and currently not sure if I'd like to go that step.
Also collage creation source is one of the parts need to be reworked further for next release.of Photobooth.


Fix formatting in 6.4 upgrade recipe

The end of a code block is missing so the rest of the notes formatting is broken.

Thanks Jiri! :)


[Bug] encoding issue

I openned a flag: Application mapping results - XXE injection and saw an encoding issue in the example payload given in the note:

Maybe there is wrong encoding when the database is filled with python reset.py ?
Is latin1 the right encoding to use?
https://github.com/pavanw3b/sh00t/blob/master/reset.py#L23

Hey @noraj,
Thanks for spotting this. In other words, it's actually because of bad character copied to WAHH data file: https://github.com/pavanw3b/sh00t/blob/master/configuration/data/wahh.json#L513. Scroll right to spot it.
I've fixed it on my local. Will remote push to master soon. I'll also check if there are any more occurrences of these characters.
Thanks again!


request: make leaderboard paginated

Is your feature request related to a problem? Please describe.
The leaderboard command is something that can benefit a lot from being paginated, however, Klasa lacked of the support for lazy loaded pages.

:warning: This issue depends on #1465's resolution.

Describe the solution you'd like
Make leaderboard use LazyPaginatedMessage.
Describe alternatives you've considered
Keeping it as-is.
Additional context
N/a.

Fixed in #1719


dist/scripts/modernizr.js Not Found

It looks like lib/assets.php is trying to enqueue dist/scripts/modernizr.js although it doesn't exist. It does however seem like it's being included in dist/scripts/main.js, so enqueuing it is redundant anyway.
I've fixed this temporarily by commenting out the line wp_enqueue_script('modernizr', ... in lib/assets.php and modernizr seems to be triggering just fine without it.

this was fixed with version 8.0.1, see https://github.com/roots/sage/issues/1351 and https://discourse.roots.io/t/modernizr-added-to-dist-js-main-js-and-still-called-from-assets-php-as-dist-js-modernizr-js/2975

I am using version 8.0.1. After some debugging I've discovered that the problem occurs because I've changed Bower's package directory in .bowerrc to assets/vendor -- somehow this is causing Modernizr and jQuery to be bundled with main.js. Changing it back to bower_components and rebuilding fixes it, but why is this happening in the first place?

@saulfautley mainBowerFiles, which is used by asset-builder as a dependency, behaves a little weird in this situation and doesn't respect your bowerrc changes. I added an option to overcome this.
If you want to change the directory, in your gulpfile use asset-builder as such:
var manifest = require('asset-builder')('./assets/manifest.json', {
  paths: {
   bowerDirectory: 'assets/vendor'
  }
});

@austinpray I've tried that but it doesn't seem to work. Looking through the code of asset-builder it seems that bower_components is hardcoded (lib/buildGlobs.js:112) and has no way of changing via options. I have manually changed this line to reflect my custom Bower directory and it works perfectly, even without specifying the paths.bowerDirectory option.

@saulfautley oh yeah you are right. I manually check for bower_components to fix some corner case with jquery plugin naming. It definitely needs to be way more clever than that. I'll get around to fixing it but patches definitely welcome!

closing this here since it's being addressed upstream https://github.com/austinpray/asset-builder/issues/22


[GHSA-vp68-2wrm-69qm] matrix-sdk-crypto contains potential impersonation via room key forward responses

Updates

Affected products

Comments
Make 'affected products' versions SemVer compliant.

Hi there @poljar! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory


Override value of typeahead input after typeahead:selected event

Hi,
I'm able to override the value of the ngmodel when the typeahead:selected event fires but when the element lost focus ("blur") the original value is reverted although the ngModel still has the modified value. I guess this is  on typeahead.js behaviour not the directive. So from the documentation, I would like to try callling the typeahead("val", myval) but the problem is that the target element is not being returned by the directive. Isn't it supposed to return also the target elemen just like what typeahead does on "typeahead:selected" event?
Thanks

Hi @istian i am having problems creating a directive for the typeahead:selected and typeahead:autocompleted events using the Siyfion/angular-typeahead. I am trying to use $scope.on to get the same but there are a list of typeahead controls so i am unable to determine which control the selected event is firing and i dont think there is an inbuilt directives to add in the HTML for selected and autocomplete events so i created a directive of my own but nothing seems to happen with that.
Please let me know how i can create a directive to add to each control to get the selected and autocompleted events.

Closing as this is > 1 year old. Please use angular-typeahead >=v1.0.0 from now on and open a new issue if your run into troubles again.


Will this repository be maintained?

@davechallis @jonathanstrong Hi.
Do you have any plans to continue maintaining this repository?
I'm working on LightGBM's rust bindings.
https://github.com/vaaaaanquish/lightgbm-rs
I have an issue where I want to integrate the interface with XGBoost.
If the maintenance continues, I can provide some pull requests.
I have the energy to take over as maintainer if you want.
Please provide a policy. I am waiting for a good answer :)

@vaaaaanquish hi, and thanks for the pull requests! Sorry about the delay in replying I've just got back from a long holiday.
I'm planning to keep maintaining the repository, so happy to accept pull requests (I'll try and review/merge them later this week, hopefully on Friday).
Also happy to add you as a collaborator on this repo, if you're keen to work on it. I'm crazy busy with work at the moment, so not had much time for open source work.

@davechallis Thx. Looks good to me :) I'm keen to work for rust-xgboost

@vaaaaanquish I've reviewed the pull request, looks good to me. I've added you as a collaborator now, any problems, let me know!


⚠ Mobitopup has degraded performance

In b34d5e5, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 6288 ms

Resolved: Mobitopup performance has improved in fd7acf8.


operators [O] prometheus (0.47.0)

thanks to #1045 for mentioning
the operator tries to monitor all namespaces even in single namespace installation.
when the installation will be namespace scoped, the operator should work as previously.
when the operator is installed cluster scoped, he will manage all the serviceMonitors, prometheusRules... in all namespaces, and the prometheus, alertmanager instances only in his namespace.
i didnt checked the cluster scoped option yet, but the namespace scoped work as always worked before.
(i hope the signoff will work now)

/merge possible

/merge possible


feat(golang): support node list in method response

before: impl obtain_vehicle_brand(identifier) response {}
after: impl obtain_vehicle_brand(identifier) ~response {}

// IFipeClient defines the interface of the provided methods
type IFipeClient interface {
  before: ObtainVehicleBrand(context.Context, *Identifier) (*Response, error)
  after: ObtainVehicleBrand(context.Context, *Identifier) (*[]Response, error)
}

https://github.com/isaqueveras/juaz/pull/9


Make Multi scene setup

This Pull request restructors how the scene displaying works. It is now prepared to support scenes in scenes.
It also resulted into a clean up of the old way to setup event listeners. Now, event listeners should be set at the end of there contructor or construct method

Task linked: CU-861m3uaae Make multi scene setup


Document how to undo/recreate release

Is it possible to undo a release, and if so, can you please document how to do this?
If for any reason there is an error in a release that makes it unusable, I think it would make sense to have the ability to roll back/undo that release, fix the error, and then release again with the same version number.
See for example https://github.com/fortify-ps/fortify-ssc-parser-symfony-security-checker/releases, where v1.0.1 is immediately superseded by v1.0.2 to fix an error in the build process; it would have been nicer to just re-publish a v1.0.1 release.
Somewhat related; suppose that someone accidentally deletes a release from the GitHub Releases page; is it possible to have release-please-action recreate that release instead of having to manually recreate it?

I don't think this tool supports reverting releases. Unfortunately, just as many other release automation tools, release-please tags, commits, and pushes the release changes to remote before it can ensure that the release has actually succeeded (i.e. build artifacts were pushed somewhere). I think for now you'd have to do:

Manually delete the release tag so that release-please knows it's not the latest release.
Clean up your manifests (i.e. package.json in JavaScript) to refer to the previous version.
Delete any other release artifacts like generated GitHub releases and the release-please's manifest.

And then re-run the release manually. Even with this last but I'm not sure how to do that without going through the entire "change -> release pr -> release job on main" workflow.


[Question] Confirm Transaction packet (clientbound)

Is confirm transaction packet from server always not accepted?
Spigot & minecraft lan(integrated) server send it not accepted when it should be accepted(i think).
Is there a reason why it works like this?

S = sent packet, R = received packet
//...Drop item code sending&receiving packets...
S-Click window(wID:0, s:36, drop stack)
R-CTc(a:false)
R-WI(wID:0)
R-SS(wID: 255, s:-1, i:null)
R-SS(wID:0, s:36, i:null)
S-CTs(a:false)
S-PPL
//..wait, repeat for whole inventory, player will drop everything.. so it works..
On wiki it says

Packet from server indicating whether a request from the client was accepted, or whether there was a conflict (due to lag)

i don't think 0-14ms(on remote server) would be considered as lag...
(i switched from 1.11 to 1.12 just now and it is still the same)

I don't provide specific support with how to use the protocol here, only issues specific to the library. I would check the protocol documentation. Perhaps you are trying to perform an invalid action?

I don't think so, my code works...
I was asking why it works like this, CTc packet should send accepted: false when there was a conflict...
log:

Sent-ClientWindowActionPacket(windowId=0, slot=36, param=DROP_SELECTED_STACK, actionId=1, action=DROP_ITEM, clicked=com.github.steveice10.mc.protocol.data.game.entity.metadata.ItemStack@164dd)
Received-ServerSpawnObjectPacket(entityId=2759, uuid=5748c9ea-f42a-4c4e-bc91-4b9a0c15d15f, type=ITEM, x=-437.5, y=70.31999999284744, z=-70.5, pitch=0.0, yaw=-135.0, data=com.github.steveice10.mc.protocol.packet.ingame.server.entity.spawn.ServerSpawnObjectPacket$2@8065a60, motX=0.01525, motY=0.138125, motZ=0.298125)
Received-ServerEntityMetadataPacket(entityId=2759, metadata=[EntityMetadata(id=0, type=BYTE, value=0), EntityMetadata(id=1, type=INT, value=300), EntityMetadata(id=2, type=STRING, value=), EntityMetadata(id=3, type=BOOLEAN, value=false), EntityMetadata(id=4, type=BOOLEAN, value=false), EntityMetadata(id=5, type=BOOLEAN, value=false), EntityMetadata(id=6, type=ITEM, value=com.github.steveice10.mc.protocol.data.game.entity.metadata.ItemStack@164dd)])
Received-ServerEntityVelocityPacket(entityId=2759, motX=0.01525, motY=0.138125, motZ=0.298125)
Received-ServerConfirmTransactionPacket(windowId=0, actionId=1, accepted=false)
Received-ServerWindowItemsPacket(windowId=0, items=ItemStack)
Received-ServerSetSlotPacket(windowId=255, slot=-1, item=null)
Received-ServerSetSlotPacket(windowId=0, slot=36, item=null)
Received-ServerKeepAlivePacket(id=46660041)
Sent-ClientConfirmTransactionPacket(windowId=0, actionId=1, accepted=false)
Sent-ClientPlayerPositionRotationPacket(x=-437.5, y=69.0, z=-70.5, yaw=0.0, pitch=0.0, onGround=true, pos=true, rot=true)
Sent-ClientKeepAlivePacket(id=46660041)
Received-ServerEntityVelocityPacket(entityId=2759, motX=0.0065, motY=0.0, motZ=0.126875)

Well this is not that important because it works..


Allow larger rate limits for extended time intervals

This PR updates RedisRateLimiter to support larger values for burstCapacity by changing its type from int to long, enabling greater flexibility for extended time intervals.
The changes include validation to ensure that the burstCapacity does not exceed the maximum allowed value that can be safely handled by Redis scripts, which is 2^53 - 1.
Closes #3594

@TheFreaky Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


this is not available for laravel 5.4

please make it usable with laravel 5.4
thanks a lot ;)

I'll work on that

I don't have much time for that, a donation would speed up the process if possible. Thanks

@aliabdzad I've pushed a working version for Laravel 5.4 Waiting for your feedback


Remove the cache parameter from the campaigns endpoint

The /campaigns endpoint currently has a cache boolean url parameter that can be passed. This used to be necessary with helping to clear the cache for the campaigns index endpoint, since there was no other way to properly clear the cache if a campaign was edited.
However, with #6109 & #6126 in place, the cache (if set to "temporary") can be cleared either on a general cache clear, or if set to a specified number of hours or to "permanent" then it can be cleared when a campaign is updated (for both the cache of the single campaign and all collections where the campaign might be a part of the response).
With the above options in place, I'd like to remove the cache url parameter which makes some of the logic in the ApiCache class a little wonky since some endpoints (like the show /campaigns/:id) don't really bother with passing additional parameters. @DFurnes also pointed out that it is probably not best to allow clearing the cache by hitting an endpoint :scream:
@DFurnes is for it, but wanted to check with both @uy and @aaronschachter since you might be using the cache parameter in places for the mobile app...

Haven't been using cache param anywhere in iOS.

Ok, good to know :) @jonuy ?

Not using this anywhere in code, but have used it multiple times to manually clear. As long as we've got another method to clear cache, then this is fine.