Running 'hot' with absolute image paths

Laravel Mix Version: 0.8.8
Node Version (node -v): 7.5.0
NPM Version (npm -v): 4.3.0
OS: Windows 10

Description:
Running npm run hot and I have an absolute image path (/images/codewall.jpeg) in my styles but hot isn't serving them at all. Hot styles work but seems to not include images with them
http://localhost:8080/images/codewall.jpeg returns Cannot GET /images/codewall.jpeg
Steps To Reproduce:
Add a background to a div, run npm run hot try viewing the page.

This was fixed in 0.10.0.


reachability.startNotifier() causes a crash in swift3(xCode8)

reachability.startNotifier() causes a crash in swift3(xCode8)

I'm having the same problem...

Away from computer for a few days, please try stackoverflow.com in the meantime

https://github.com/ashleymills/Reachability.swift/wiki/Raising-an-issue


Feat/front updates

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (87d3acf) 92.94% compared to head (384193c) 92.94%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   92.94%   92.94%
=======================================
  Files          17       17
  Lines         340      340
  Branches       98       98
=======================================
  Hits          316      316
  Misses         24       24

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix for 0.8.x

Thanks for this. Chat Enhancements is next on my list for migration and I plan to work on it tonight, so I'll review this then 👍🏼


wget command isn't working properly

When I try to install on top of a 14.04.5 LTS and I copy/paste the command, it asks me for my password but then goes back to command prompt and does nothing. When I try to use the appliance, I can't change the proxy setting from within the appliance. One of these has to work. I'm using this on a workstation within my lab.

I've tried the gsettings command, I've tried to edit the non-existent etc/environment. Please help :)

https://stackoverflow.com/questions/11211705/setting-proxy-in-wget


Implement allowlist framework for dependencies

Signed-off-by: Paul S. Schweigert<EMAIL_ADDRESS>Allow operators to specify an allowlist of dependencies and allowed versions.
The allowlist is stored in a config file.
A sample allowlist might look like:
allowlist = { "wheel": ["0.44.0", "0.43.2"] }

which would imply that the wheel package is allowed, but only versions 0.43.2 and 0.44.0 .
For this PR, the allowlist is empty, which means all dependencies are allowed, and it is stored locally. In a future PR, this should move into a Kubernetes configmap so that it can be updated without having to rebuild the container.
Each dependency can optionally specify a list of allowed versions. If the list is empty, then all versions of the dependency are allowed.
An example:
allowlist = { "wheel": [] }

This could also be adapted to store a minimum allowed version instead of listing all allowed versions, depending on requirements.

still need to add tests for the new functionality...

ok, this should be ready for review now

xref #369


feat(app): theme and UI overhaul

cba to write loads of issues rn but this is what doing these are the things outstanding after this:

remove the play button on the play screen after you've already hit play on setup screen. just don't need to do that twice
on the post-game screen, show the places of everyone who played, and how many turns each of them lasted.
add a 'contact' array and show on the play screen with name & colour. ( [left hand, right hand, left leg, right leg] )
add/edit colours
bug fix: the play button on the setup screen is in a container that covers the whole width at the bottom of the screen, you won't notice until the list(s) are long enough that you need to scroll. Should be a simple fix.
probably more things i really should have noted down as i was going

@CCrampsie feel free to pick up any/all of the above 🙏 when/if you pick something can you either create an issue and put it into in progress on the board, or just message me to let me know so that we don't end up stepping on each others' toes 🙏
Sorry this PR really got out of hand - feel like it was kind of necessary but understand this is probably annoying for basically the whole app to change without any warning, sorry!

merging this with my admin rights as i want to do some stuff


WIP: Inject node error to test metrics & telemetry

Inject a dummy error to compute nodes, just to test metrics & telemetry.
Do not merge!
/hold

/close

/close


Updates in the color module

Removed _random_colors
Updated _random_color: it generates random HSV values and convert to RGB

Closes #82.

@nippoo ready for review/merge

Coverage remained the same at 95.06% when pulling a1b804b84892ea7cbab48e42342d5f773cb79e88 on rossant:update-colors into 6ad001722757d9d23f3a79a679a396717443b174 on kwikteam:master.

Coverage increased (+0.02%) to 95.07% when pulling 4e479f2f903155720cc40277c91c859e3aadcf74 on rossant:update-colors into 6ad001722757d9d23f3a79a679a396717443b174 on kwikteam:master.


Errors null bug

When errors is null errors.length call is causing uncaught error. Fixed by adding check on errors and then calling the original errors.length.

I should have fix it as follows: if (errors && !errors.length) return


No video for STANDALONE-RICE on R36S

On R36S with latest release of ArkOS (03302024):
If 'STANDALONE-RICE' for N64 emulation is selected the game will start (sound works) but there is no video (black screen).
After some digging I found out that video works if the line
ResolutionWidth = 480
in the [Video-Rice] section of /home/ark/.config/mupen64plus/mupen64plus.cfg is removed.

Interesting as that line works fine with the rg351mp.  I don't support that device.  Copying @AeolusUX so he's aware and can accomodate that if needed in his custom ArkOS image.

Interesting as that line works fine with the rg351mp. I don't support that device. Copying @AeolusUX so he's aware and can accomodate that if needed in his custom ArkOS image.

Will check when I start doing the update on the community image. It used to work before with that line.


Toolbar not staying within the boundaries of the text area

I am filing this issue so I have a place to show people what I want to fix. I need some help knowing how to describe this behavior - and where to start looking for how to fix it.
When using the built-in Hallo editor in Wagtail 2.16, the toolbar follows as you scroll up and down a long rich text area.
https://user-images.githubusercontent.com/5952/199617022-77684fc0-92c3-401e-8fd3-e046290134de.mov
But when using wagtail-hallo and Wagtail 3.0.3, the toolbar will happily follow you up the page - rather than coming to rest at the top of the text area when you scroll up and becoming invisible when you scroll down. This behavior starts with the 0.1.0 release of wagtail-hallo.
https://user-images.githubusercontent.com/5952/199617063-79e9d988-d8c6-40dc-a1d4-c1a5ab0a79c1.mov

I have created a Gitpod that demonstrates the floating toolbar problem using bakerydemo.  You can spin up your own Gitpod instance using this URL: https://gitpod.io/#https://github.com/cnk/bakerydemo/tree/hallo
Once you have logged in (admin/changeme), edit the home page and note how the toolbar does not stay inside the text area. From the debugging I have managed to do, it appears to me that setPosition is only being called once, when the toolbar gets created the first time: https://github.com/wagtail-nest/wagtail-hallo/blob/main/wagtail_hallo/static/js/vendor/hallo.js#L308 Wagtail uses halloToolbarFixed so setPosition should be called when the window is scrolled but doesn't appear to be doing so. Could it be that these events are not getting attached? https://github.com/wagtail-nest/wagtail-hallo/blob/main/wagtail_hallo/static/js/vendor/hallo.js#L3190

I tried this in Wagtail 4.2 and the issue is still happening. Probably no surprise. 😄
Uploading Screen Recording 2023-02-07 at 16.24.37.mov…

I found the source of the problem:
hallo.js includes this in the _create() function for halloToolbarFixed:
        jQuery(window).on('resize', function (event) {
          return _this.setPosition();
        });
        jQuery(window).on('scroll', function (event) {
          return _this.setPosition();
        });

Turns out that, for whatever reason, the window no longer scrolls in Wagtail 3 or 4. However, the .content-wrapper element does scroll. So switching out that code for this fixed the toolbar location behavior:
        jQuery('.content-wrapper').on('resize', function (event) {
          return _this.setPosition();
        });
        jQuery('.content-wrapper').on('scroll', function (event) {
          return _this.setPosition();
        });

Still need to figure out how to fix the "resize the input field to make room for the toolbar" behavior, though.

Here is a video of the "resize to make room for the toolbar" behavior from Wagtail 2.16. Since all the javascript in this repo was extracted from Wagtail 2.16, I would guess that the JS is still here but that the HTML has changed so it is no longer finding the same elements it used to use for the calculation.
https://user-images.githubusercontent.com/5952/219878262-e5d52185-2e3e-4512-b615-ce40d42567ce.mov

I've put in a PR for this: #39

I incorporated @coredumperror PR #39 in to #42.


15223: generate empty in convert

This PR updates the code so that when an empty report (or any situation where the number of items cannot be determined) makes it to the convert step.
Test Steps:
There are a integration tests that covers this, but as the pipeline is currently structured this is hard to test manually as the report function will synchronously fail.
Changes

Adds a new trackEmptyReport that can be used anywhere in the pipeline
Updates the convert step to use it if it cannot determine the number of items

Checklist
Testing

[x] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[x] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

#15223

To Be Done
Specific Security-related subjects a reviewer should pay specific attention to

@thetaurean 100% think there are tech debt tickets to be made for action history but I have always been unsure where to start since I think there could be an argument to simply rewrite the whole thing.
For the other pipeline steps, maybe?  This spot in in convert is a little unique in the sense that its only part of the pipeline where the number of items is unknown in case of an error


Basic example hangs in 0.4dev

The basic example in the README hangs when using UMAP from the master or 0.4dev branch.
import umap
from sklearn.datasets import load_digits

digits = load_digits()

embedding = umap.UMAP().fit_transform(digits.data)

If I do
pip install umap-learn

then the code works as expected (taking only 5-10 seconds). However, it hangs when using a version of UMAP built from the 0.4dev branch or master. It looks like it is doing something since I see the message
/home/gclenden/anaconda3/envs/umap_debug/lib/python3.7/site-packages/umap/spectral.py:243: UserWarning: Embedding a total of 2 separate connected components using meta-embedding (experimental)
  n_components

I think the commit where this occurs is https://github.com/lmcinnes/umap/commit/eb6774056aa5fc8a858d466eaba4a1cb35c978ae. It works as expected on the commit prior to that one https://github.com/lmcinnes/umap/commit/c26bc8dac3e8fc71a4221986cf3cf0926b573766. However, I don't know enough about numba/tbb to explain why this might be happening.

One thing to try would be rolling back to numba=0.46 and llvmlite=0.30. There were defintiely some issues there, but that may not be this problem. I'll try to look in more detail tomorrow. Worst case you can probably remove the requirement and uninstall tbb to get things working.

Rolling back to numba=0.46 and llvmlite=0.30 seemed to fix the issue. Thanks Leland!

@gclen Could you maybe figure out where exactly the program gets stuck and report it here?

FWIW: I had the same issue and downgrading numba and llvmlite worked for me also. I'd be happy to try to help diagnose the problem @sleighsoft but I don't know how to go about doing that.

I ran
import umap
from sklearn.datasets import load_digits

digits = load_digits()
embedding = umap.UMAP(n_neighbors=5, min_dist=0.3,metric='correlation', verbose=True).fit_transform(digits.data)

and got the following output
/home/gclenden/anaconda3/envs/umap_debug/lib/python3.7/site-packages/sklearn/base.py:197: FutureWarning: From version 0.24, get_params will raise an AttributeError if a parameter cannot be retrieved as an instance attribute. Previously it would return None.
  FutureWarning)
UMAP(a=None, angular_rp_forest=False, b=None,
     force_approximation_algorithm=False, init='spectral', learning_rate=1.0,
     local_connectivity=1.0, low_memory=False, metric='correlation',
     metric_kwds=None, min_dist=0.3, n_components=2, n_epochs=None,
     n_neighbors=5, negative_sample_rate=5, output_metric='euclidean',
     output_metric_kwds=None, random_state=None, repulsion_strength=1.0,
     set_op_mix_ratio=1.0, spread=1.0, target_metric='categorical',
     target_metric_kwds=None, target_n_neighbors=-1, target_weight=0.5,
     transform_queue_size=4.0, transform_seed=42, unique=False, verbose=True)
Construct fuzzy simplicial set
Fri Jan 10 10:54:24 2020 Finding Nearest Neighbors
Fri Jan 10 10:54:26 2020 Finished Nearest Neighbor Search
Fri Jan 10 10:54:28 2020 Construct embedding
/home/gclenden/anaconda3/envs/umap_debug/lib/python3.7/site-packages/umap/spectral.py:243: UserWarning: Embedding a total of 2 separate connected components using meta-embedding (experimental)
  n_components

I used ctrl-C to interrupt the script when it was hanging and it appeared to be hanging in the same spot (I did this a few times). It looks like it gets stuck in ~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/byteflow.py in propagate_phi_map(phismap)
The full stack trace is:
---------------------------------------------------------------------------
KeyboardInterrupt                         Traceback (most recent call last)
<timed exec> in <module>

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/umap/umap_.py in fit_transform(self, X, y)
   1848             Embedding of the training data in low-dimensional space.
   1849         """
-> 1850         self.fit(X, y)
   1851         return self.embedding_
   1852

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/umap/umap_.py in fit(self, X, y)
   1817             self.output_metric in ("euclidean", "l2"),
   1818             self.random_state is None,
-> 1819             self.verbose,
   1820         )[inverse]
   1821

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/umap/umap_.py in simplicial_set_embedding(data, graph, n_components, initial_alpha, a, b, gamma, negative_sample_rate, n_epochs, init, random_state, metric, metric_kwds, output_metric, output_metric_kwds, euclidean_output, parallel, verbose)
   1078             negative_sample_rate,
   1079             parallel=parallel,
-> 1080             verbose=verbose,
   1081         )
   1082     else:

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/umap/layouts.py in optimize_layout_euclidean(head_embedding, tail_embedding, head, tail, n_epochs, n_vertices, epochs_per_sample, a, b, rng_state, gamma, initial_alpha, negative_sample_rate, parallel, verbose)
    229             epoch_of_next_negative_sample,
    230             epoch_of_next_sample,
--> 231             n,
    232         )
    233

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/dispatcher.py in _compile_for_args(self, *args, **kws)
    351                 argtypes.append(self.typeof_pyval(a))
    352         try:
--> 353             return self.compile(tuple(argtypes))
    354         except errors.ForceLiteralArg as e:
    355             # Received request for compiler re-entry with the list of arguments

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/compiler_lock.py in _acquire_compile_lock(*args, **kwargs)
     30         def _acquire_compile_lock(*args, **kwargs):
     31             with self:
---> 32                 return func(*args, **kwargs)
     33         return _acquire_compile_lock
     34

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/dispatcher.py in compile(self, sig)
    766             self._cache_misses[sig] += 1
    767             try:
--> 768                 cres = self._compiler.compile(args, return_type)
    769             except errors.ForceLiteralArg as e:
    770                 def folded(args, kws):

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/dispatcher.py in compile(self, args, return_type)
     75
     76     def compile(self, args, return_type):
---> 77         status, retval = self._compile_cached(args, return_type)
     78         if status:
     79             return retval

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/dispatcher.py in _compile_cached(self, args, return_type)
     89
     90         try:
---> 91             retval = self._compile_core(args, return_type)
     92         except errors.TypingError as e:
     93             self._failed_cache[key] = e

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/dispatcher.py in _compile_core(self, args, return_type)
    107                                       args=args, return_type=return_type,
    108                                       flags=flags, locals=self.locals,
--> 109                                       pipeline_class=self.pipeline_class)
    110         # Check typing error if object mode is used
    111         if cres.typing_error is not None and not flags.enable_pyobject:

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/compiler.py in compile_extra(typingctx, targetctx, func, args, return_type, flags, locals, library, pipeline_class)
    549     pipeline = pipeline_class(typingctx, targetctx, library,
    550                               args, return_type, flags, locals)
--> 551     return pipeline.compile_extra(func)
    552
    553

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/compiler.py in compile_extra(self, func)
    329         self.state.lifted = ()
    330         self.state.lifted_from = None
--> 331         return self._compile_bytecode()
    332
    333     def compile_ir(self, func_ir, lifted=(), lifted_from=None):

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/compiler.py in _compile_bytecode(self)
    391         """
    392         assert self.state.func_ir is None
--> 393         return self._compile_core()
    394
    395     def _compile_ir(self):

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/compiler.py in _compile_core(self)
    362             res = None
    363             try:
--> 364                 pm.run(self.state)
    365                 if self.state.cr is not None:
    366                     break

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/compiler_machinery.py in run(self, state)
    336                 pass_inst = _pass_registry.get(pss).pass_inst
    337                 if isinstance(pass_inst, CompilerPass):
--> 338                     self._runPass(idx, pass_inst, state)
    339                 else:
    340                     raise BaseException("Legacy pass in use")

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/compiler_lock.py in _acquire_compile_lock(*args, **kwargs)
     30         def _acquire_compile_lock(*args, **kwargs):
     31             with self:
---> 32                 return func(*args, **kwargs)
     33         return _acquire_compile_lock
     34

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/compiler_machinery.py in _runPass(self, index, pss, internal_state)
    300             mutated |= check(pss.run_initialization, internal_state)
    301         with SimpleTimer() as pass_time:
--> 302             mutated |= check(pss.run_pass, internal_state)
    303         with SimpleTimer() as finalize_time:
    304             mutated |= check(pss.run_finalizer, internal_state)

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/compiler_machinery.py in check(func, compiler_state)
    273
    274         def check(func, compiler_state):
--> 275             mangled = func(compiler_state)
    276             if mangled not in (True, False):
    277                 msg = ("CompilerPass implementations should return True/False. "

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/untyped_passes.py in run_pass(self, state)
     87         bc = state['bc']
     88         interp = interpreter.Interpreter(func_id)
---> 89         func_ir = interp.interpret(bc)
     90         state["func_ir"] = func_ir
     91         return True

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/interpreter.py in interpret(self, bytecode)
    114         else:
    115             flow = Flow(bytecode)
--> 116             flow.run()
    117             self.dfa = AdaptDFA(flow)
    118             self.cfa = AdaptCFA(flow)

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/byteflow.py in run(self)
    141         self._build_cfg(runner.finished)
    142         # Prune redundant PHI-nodes
--> 143         self._prune_phis(runner)
    144         # Post process
    145         for state in sorted(runner.finished, key=lambda x: x.pc_initial):

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/byteflow.py in _prune_phis(self, runner)
    227         _logger.debug("Used_phis: %s", _lazy_pformat(used_phis))
    228         defmap, phismap = find_use_defs()
--> 229         propagate_phi_map(phismap)
    230         apply_changes(used_phis, phismap)
    231         _logger.debug("DONE Prune PHIs".center(60, '-'))

~/anaconda3/envs/umap_debug/lib/python3.7/site-packages/numba/byteflow.py in propagate_phi_map(phismap)
    200                     for rhs, state in sorted(list(defsites)):
    201                         if rhs in phi_set:
--> 202                             old = frozenset(defsites)
    203                             defsites |= phismap[rhs]
    204                             defsites.discard((rhs, state))

KeyboardInterrupt:

Let me know if you need me to run any other tests :)

There are some issues with the new numba release and its interactions with parallel constructs. This seems to be another symptom of that.


strptime from date strings

Allow a formatting string to be passed as a command arg, then do the dates to seconds conversion in the library

And strftime before output


type error in - mgcpy.independence_tests.mgc_utils.local_correlation.local_covariance  " -expected 'int_t' but got 'long long'"

mgc function is not working and I can't change the type in "local_correlation.cp37-win_amd64.pyd".
I tried :
mgc = MGC()
mgc_statistic , independence_test_metadata = mgc.test_statistic(X,Y)
and i have this error message   :
File "mgcpy\independence_tests\mgc_utils\local_correlation.pyx", line 83, in mgcpy.independence_tests.mgc_utils.local_correlation.local_correlations
File "mgcpy\independence_tests\mgc_utils\local_correlation.pyx", line 138, in mgcpy.independence_tests.mgc_utils.local_correlation.local_correlations
File "mgcpy\independence_tests\mgc_utils\local_correlation.pyx", line 16, in mgcpy.independence_tests.mgc_utils.local_correlation.local_covariance
ValueError: Buffer dtype mismatch, expected 'int_t' but got 'long long'
I use Windows 10 & Python 3.7

Sorry for getting back late, but we just updated mgcpy to 0.4.0. Does it work now?

Hi,
@sampan501 , sorry for the delay. I tried to update in pyhton but it seems that pyhton didn't find a new version 0.4.0. I tried to upgrade and I tried to fix the new version "pip install mgcpy==0.4.0", it was the same. the new version is already available ?

Are you using Mac OS Mojave or Linux? For Mac OS pip install --upgrade mgcpy should work, but for linux, follow this:
git clone https://github.com/neurodata/mgcpy
cd mgcpy
python3 setup.py build_ext --inplace

A fix for the long error should be in the next version

Could you give us an idea of when the next version will be released?

ETA on that should be sometime within the next month. I've looking at this more closely, it seems though that it may be a compiler error. Cython code needs to be compiled before running. I will update the ReadMe with install instructions for this, but for now instructions for installation are here https://wiki.python.org/moin/WindowsCompilers.

I've tried following those instructions but still no joy unfortunately.


Add a clang 18 bot

This will require a roll of fmtlib after https://github.com/fmtlib/fmt/issues/3607 is addressed.

LLVM reverted the change that enabled -Wdeprecated-literal-operator by default for now.
commit 0d9919d362a7a70b2a7970861d897ecc47ec9e4d
Author: Reid Kleckner<EMAIL_ADDRESS>Date:   Tue Aug 22 18:10:41 2023 -0700

    Revert "[Clang] CWG1473: do not err on the lack of space after operator"""

    This reverts commit f2583f3acf596cc545c8c0e3cb28e712f4ebf21b.

    There is a large body of non-conforming C-like code using format strings
    like this:

      #define PRIuS "zu"
      void h(size_t foo, size_t bar) {
        printf("foo is %"PRIuS", bar is %"PRIuS, foo, bar);
      }

    Rejecting this code would be very disruptive. We could decide to do
    that, but it's sufficiently disruptive that I think it requires
    gathering more community consensus with an RFC, and Aaron indicated [1]
    it's OK to revert for now so continuous testing systems can see past
    this issue while we decide what to do.

    [1] https://reviews.llvm.org/D153156#4607717


Test backfill corrections date-handling functions

Esp. get_training_date_range and associated functions.

Closed in https://github.com/cmu-delphi/covidcast-indicators/pull/1768


Delete line items in Cart Craft Commerce

Question
Hello Ben, i would like to use sprig to delete items in the cart of a Commerce Project. I tried to use the following Code, but without any success.
<form sprig s-method="post" s-action="commerce/cart/remove-line-item">
    <input type="checkbox" name="lineItems[40][remove]" value="1">
    <input type="submit" value="Remove from Cart">
</form>

Server Response: Unable to resolve the request: commerce/cart/remove-line-item
I also tried to use s-action="commerce/cart/update-cart", also without any success.
Do you have any solution?
Thanks in advance

It doesn't look like commerce/cart/remove-line-item is a valid controller action in https://github.com/craftcms/commerce/blob/develop/src/controllers/CartController.php. Do you have a working example that is not using Sprig?

Hi Ben,
yes i got this code from an answer from Luke:
https://github.com/craftcms/commerce/issues/277#issuecomment-377667782

Glad to hear it!


remove phpcs from running for php8

I created https://github.com/php-tuf/php-tuf/issues/70 to figure out what is going on with phpcs and php 8. The failure looks like a bug.
I think it is better to stop this check for now so there is no confusion about checks on currently supported version of php passing. The actual phpunit tests will still run on PHP 8 and phpcs will run on all versions for PHP 7 that are in our matrix.

#73 proves the next phpcs release should fix this. I don't think we should use the dev version for now.
So we can do this PR now or just accept the failures until phpcs 3.5.7 comes out.

Is there anything like an XFAIL we can use here?

Is there anything like an XFAIL we can use here?

@davidstrauss hmmm, that would better but I couldn't find anything in github workflows that would allow use to that.
I created #70 as todo to add remove this condition when the new version is released.


VERGE installation on ubuntu fails

Hello,
I am trying to install Verge wallet in ubuntu system.
I followed all steps that provided in README.md file.
After installation when I hit ./verged or ./verge-qt this gives me an error like,
VERGED-qt command not found .Same for verged
please help me to install VERGE wallet in ubuntu.

We need more information, either provide a log by copying the one of the build.
Or try again with shell script inside the root directory: chmod u+x go.sh && ./go.sh

go.sh will likely return the same error.
If compilation has failed, and 181 line statament is false ( "if [ -e ~/VERGE/src/qt/VERGE-qt ]; then" )
then case go.sh will nonetheless try to execute VERGE-qt at line 263.
But VERGE-qt does not exist, because if compilation has failed, then there was no "sudo make install", therefore, there will be the same "VERGED-qt command not found"

"VERGED-qt command not found .Same for verged"
neither of these exist after compilation. they are ./VERGE-qt and ./VERGEd (case sensitive)
also, go.sh will definitely work if you are using an ubuntu system. ive tested it on 16, 17, and 18.

I definitely meant VERGE-qt, just quoted without checking.
I didn't say that go.sh will fail. I said "go.sh will likely return the same error."
If compilation has failed, then there will be no ~/VERGE/src/qt/VERGE-qt and "sudo make install" will not be executed.
Therefore when go.sh will try to execute VERGE-qt at line 263 it will return "VERGE-qt command not found".
This is what i meant, it has nothing to do with ubuntu.
You don't notice this if compilation was successful, but if compilation has failed nothing is going to stop go.sh from trying to execute VERGE-qt (which does't exist)

If compilation has failed, go.sh will just return error about "VERGE-qt command not found", but it will continue to work.
Despite failed compilation it will try to download "complete VERGE Blockchain" and create desktop and menu items.
So it will definitely work, but why?

i mean go.sh will compile VERGE-qt and VERGEd on an ubuntu system. from the first post, it seems he was trying to type the wrong name because they are both case sensitive.

True.
Most likely wrong names are the reason for the aforementioned error.
I've just presumed, that with go.sh (in case of failed compilation and correct names) there would be the same outcome as if he typed the wrong names, i.e. ".. command not found".
Moreover, things might get even more confusing, as go.sh (despite all errors) would create menu/desktop icons, intuitively indicating that installation has completed successfully.

Helli,
I tried all ways that you tell me in above discussion the error looks like aas below

So, compilation has failed indeed and there is no VERGE-qt binary.
As of now, go.sh script has only one checkpoint which you can use to debug this problem.
Try to find the "Compile fail not VERGE-qt present" line in you console and show us the lines before that message.

yes, i have got an error like,

Ok, lets try another way.
Please write the results returned by the following commands:

sudo apt-get update && sudo apt-get -y install git libcanberra-gtk-module lynx unzip libdb4.8-dev libdb4.8++-dev build-essential libtool autotools-dev automake pkg-config libssl-dev libevent-dev bsdmainutils git libboost-all-dev libminiupnpc-dev libqt5gui5 libqt5core5a libqt5dbus5 libevent-dev qttools5-dev qttools5-dev-tools libprotobuf-dev protobuf-compiler libqrencode-dev libseccomp-dev libcap-dev

find /usr/lib -name libdb_cxx-4.8.so

grep --include=*.hpp -r '/usr/include' -e "define BOOST_LIB_VERSION" | sed 's/[^0-9]//g'

Hiee,
I followed steps that you have told, see

cd $HOME/VERGE
wget -O $HOME/boost_1_63_0.zip https://sourceforge.net/projects/boost/files/boost/1.63.0/boost_1_63_0.zip
unzip boost_1_63_0.zip
cd boost_1_63_0
sh bootstrap.sh
sudo ./b2 install
sudo ldconfig
cd ..
./autogen.sh
./configure --with-gui=qt5 --with-boost-libdir=/usr/local/lib/
make -j$(nproc)

//if everything is OK then
sudo make install

// if 163, then just do
cd $HOME/VERGE
./autogen.sh
./configure --with-gui=qt5 --with-boost-libdir=/usr/local/lib/
make -j$(nproc)
sudo make install

I am following  steps provideed by you its taking time to install I soon let you know :+1:

its not working still :-1:

paste the results

What command is not working?
And no more screenshots, please
Just copy output of failed command

When I used last command,
sudo make install it gives me an error like,

std::allocator >&, bool&, bool&, std::__cxx11::basic_string<char, std::char_traits, std::allocator >&, std::__cxx11::basic_string<char, std::char_traits, std::allocator >&)':
/home/admin1/VERGE/src/walletdb.cpp:206: undefined reference to `CTransaction::CheckTransaction() const'
collect2: error: ld returned 1 exit status
Makefile:1840: recipe for target 'VERGEd' failed
make[2]: *** [VERGEd] Error 1
make[2]: Leaving directory '/home/admin1/VERGE/src'
Makefile:4534: recipe for target 'install' failed
make[1]: *** [install] Error 2
make[1]: Leaving directory '/home/admin1/VERGE/src'
Makefile:538: recipe for target 'install-recursive' failed
make: *** [install-recursive] Error 1

Error log is ,

Makefile:1840: recipe for target 'VERGEd' failed
Makefile:1898: recipe for target 'test_verge' failed
Makefile:1858: recipe for target 'qt/VERGE-qt' failed
make[2]: Leaving directory '/home/admin1/VERGE/src'
Makefile:1553: recipe for target 'all' failed
make[1]: Leaving directory '/home/admin1/VERGE/src'
Makefile:538: recipe for target 'all-recursive' failed
Making install in tor
make[1]: Entering directory '/home/admin1/VERGE/tor'
make[2]: Entering directory '/home/admin1/VERGE/tor'
/bin/mkdir -p '/usr/local/bin'
/usr/bin/install -c contrib/client-tools/torify '/usr/local/bin'
/bin/mkdir -p '/usr/local/etc/tor'
/usr/bin/install -c -m 644 src/config/torrc.sample '/usr/local/etc/tor'
/bin/mkdir -p '/usr/local/share/tor'
/usr/bin/install -c -m 644 src/config/geoip src/config/geoip6 '/usr/local/share/tor'
make[2]: Leaving directory '/home/admin1/VERGE/tor'
make[1]: Leaving directory '/home/admin1/VERGE/tor'
Making install in src
make[1]: Entering directory '/home/admin1/VERGE/src'
make  install-am
make[2]: Entering directory '/home/admin1/VERGE/src'
Building LevelDB ... Executes: make -C leveldb all
make[3]: Entering directory '/home/admin1/VERGE/src/leveldb'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/admin1/VERGE/src/leveldb'
CXXLD    VERGEd
Makefile:1840: recipe for target 'VERGEd' failed
make[2]: Leaving directory '/home/admin1/VERGE/src'
Makefile:4534: recipe for target 'install' failed
make[1]: Leaving directory '/home/admin1/VERGE/src'
Makefile:538: recipe for target 'install-recursive' failed

i forgot to ask, what version of ubuntu?

// As indicated by the last screenshot, it is Xenial.
// Either this will work, or i don't know what is going on:
printf '#!/bin/bash\ncd $HOME/VERGE\n./autogen.sh\n./configure CPPFLAGS="-I/usr/include -O2" LDFLAGS="-L/usr/lib" --with-gui=qt5 --with-boost-libdir=/usr/local/lib/\nmake -j$(nproc)\nsudo make install\n' > verge_script.sh
chmod +x verge_script.sh
./verge_script.sh  2> verge_script.sh.err.log
// And then copy the output of the
cat verge_script.sh.err.log

@Smurfy303, so, did it worked or not?

Not working :(

Is that it?
"cat verge_script.sh.err.log" - also not woriking?

It's working, I am showing you the last lines of that command,

/home/admin1/VERGE/src/main.h:520: undefined reference to nBestHeight' libbitcoin_wallet.a(libbitcoin_wallet_a-wallet.o): In function CMerkleTx::GetDepthInMainChain() const':
/home/admin1/VERGE/src/main.h:1109: undefined reference to CMerkleTx::GetDepthInMainChain(CBlockIndex*&) const' libbitcoin_wallet.a(libbitcoin_wallet_a-wallet.o): In function CBlockHeader::SetNull()':
/home/admin1/VERGE/src/main.h:1216: undefined reference to nBestHeight' libbitcoin_wallet.a(libbitcoin_wallet_a-wallet.o): In function CBlock::ReadFromDisk(unsigned int, unsigned int, bool)':
/home/admin1/VERGE/src/main.h:1474: undefined reference to OpenBlockFile(unsigned int, unsigned int, char const*)' libbitcoin_wallet.a(libbitcoin_wallet_a-wallet.o): In function GetAlgo(int)':
/home/admin1/VERGE/src/main.h:171: undefined reference to nBestHeight' libbitcoin_wallet.a(libbitcoin_wallet_a-wallet.o): In function CBlock::ReadFromDisk(unsigned int, unsigned int, bool)':
/home/admin1/VERGE/src/main.h:1489: undefined reference to CheckProofOfWork(uint256, unsigned int, int)' libbitcoin_wallet.a(libbitcoin_wallet_a-walletdb.o): In function ReadKeyValue(CWallet*, CDataStream&, CDataStream&, int&, std::vector<uint256, std::allocator >&, bool&, bool&, std::__cxx11::basic_string<char, std::char_traits, std::allocator >&, std::__cxx11::basic_string<char, std::char_traits, std::allocator >&)':
/home/admin1/VERGE/src/walletdb.cpp:206: undefined reference to `CTransaction::CheckTransaction() const'
collect2: error: ld returned 1 exit status
make[2]: *** [VERGEd] Error 1
make[1]: *** [install] Error 2
make: *** [install-recursive] Error 1

@Smurfy303
Also, there is a possibility that you have the same issue that i've once had.
Eventually i didn't find the cause of the problem, but there is some dirty fix, that i used.
For some reason, during configuration the "out-shared" directory was not created.
In this issue https://github.com/vergecurrency/VERGE/issues/766 same problem was solved by just using sudo with go.sh, assuming that issue was with user permission,
which i highly doubt, because i got this bug randomly on the same OS in the seemingly same conditions.
And i would not recommend using sudo ./go.sh, but do as you please.
After all, i just did "mkdir src/leveldb/out-shared" before compilation.
So, in full this would be:
printf '#!/bin/bash\ncd $HOME/VERGE\nmkdir src/leveldb/out-shared\n./autogen.sh\n./configure CPPFLAGS="-I/usr/include -O2" LDFLAGS="-L/usr/lib" --with-gui=qt5 --with-boost-libdir=/usr/local/lib/\nmake -j$(nproc)\nsudo make install\nVERGE-qt\n' > verge_script.sh
chmod +x verge_script.sh
./verge_script.sh

Just checked this issue again (without aforementioned fix). And got the same error on freshly cloned git repo.
//////////////////
Assembler messages:
Fatal error: can't create out-shared/db/db_bench.o: No such file or directory
make[3]: *** [Makefile:415: out-shared/db/db_bench.o] Error 1
//////////////////
BUT
it turns out, that "src/leveldb/out-shared" direcory WAS created but was not used and was empty.
So, after i've just launched the compilation again (without aforementioned fix, without cleaning, without removing VERGE directory), there was no error. And compilation was successful.
Maybe, for some reason, during compilation, the attempt to copy files in "src/leveldb/out-shared" was made before the "src/leveldb/out-shared" was actually created?
Also, i was wrong - the bug is not that random, but i still think it has nothing to do with user permissions.
However, maybe it is not relevant to the current issue and you've got some different bug.

Ok, "race between directory creation and a build command" - it's leveldb thing - https://github.com/google/leveldb/issues/556
So, using "make" instead of "make -j$(nproc)" or "make -j", seems like helping to avoid the "Fatal error: can't create out-shared/db/db_bench.o: No such file or directory" issue.


Fix https://github.com/mozilla/thimble.webmaker.org/issues/1269

CodeMirror doesn't seem to like having display:none applied, but with this it seems to work.  See if you can break it.

@humphd Looks like that did the trick. Tested in FF & Chrome :+1: R+


Sourcing from custom recipe

(use-package projectile
:ensure t
:recipe (:fetcher github
:repo "abo-abo/projectile"))
doesn't source projectile from abo-abo's fork.

System: archlinux
The other packages install just fine. Just not off of the recipe fetcher option.

Closing issue.
The new / more up to date documentation in the README.md helped me get this working:
(use-package projectile
:ensure t
:recipe (projectile :type git :host github :repo "abo-abo/projectile"))

Oh, dear. I hadn't realized that I wasn't being notified about issues on this repository. Sorry about that, glad you figured it out!

Oh, and because I haven't gotten to writing the user manual yet (which covers the new recipe format in full detail), check out https://github.com/raxod502/straight.el/issues/37#issuecomment-307639746.

You're updated README.md in the develop branch led me to the correct solution.
Looking forward to your updates of the FIXME temporary links.
Great work by the way. Really enjoying following this project. I look forward to inspecting the Radian to see your history of commits and the evolution of going from package.el to straight.el .


annotation on streetscape.gl

Hi! thanks for the amazing tool.
am trying to implement annotation on LiDAR data. so i want to draw a 3D cuboid on top of point-could Layer tried nebula.gl but it is not working as expected
Is there a recommended approach?
Thanks!

@aubeena007 https://avs.auto/#/xviz/protocol/schema/geometry-primitives   polygon type


rMalMon1 EAR

Assembly review request
ToLID: rMalMon1
Species: Malpolon monspessulanus
Project: ERGA-BGE
Affiliation: CNAG

Hi @fcamara7
Thanks for sending the EAR of Malpolon monspessulanus
I added the corresponding tag to the PR and appointed @tbrown91 as assignee to supervise.
I will contact a reviewer ASAP.
*****
EAR Reviewer Selection Process
Date: 2024-04-29 15:59

All Eligible Candidates:

Github ID     | Full Name   | Institution | Total Reviews | Last Review | Active | Busy | Calling Score | Adjusted Score
------------------------------------------------------------------------------------------------------------------------
additive3     | Jo Wood     | Sanger      | 1             | 2024-02-26  | Y      | N    | 999           | 1049
SarahPelan    | Sarah Pelan | Sanger      | 1             | 2024-03-22  | Y      | N    | 999           | 1049
joannacollins | Jo Collins  | Sanger      | 1             | 2024-03-27  | Y      | N    | 999           | 1049
DomAbsolon    | Dom Absolon | Sanger      | 1             | 2024-04-22  | Y      | N    | 999           | 1049
tommathers    | Tom Mathers | Sanger      | 1             | 2024-04-26  | Y      | N    | 999           | 1049
tbrown91      | Tom Brown   | IZW         | 8             | 2024-02-21  | Y      | N    | 993           | 993

Selected reviewer to call first: Jo Wood (additive3)
The decision was based on:
- different institution ('Sanger')
- active ('Y')
- not busy ('N')
- highest adjusted calling score in this particular selection (1049)
- chosen based on oldest review and fewest reviews among the finalists

HI – I can review this one if needed. Already took a quick look at it…
Dr. Thomas Mathers
Senior Computer Biologist
Genome Reference Informatics Team
Tree of Life
Wellcome Sanger Institute
Hinxton
Cambridge
CB10 1SA
Twitter: @Thomas_Mathers [twitter.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__twitter.com_Thomas-5FMathers-3Flang-3Den-2Dgb&d=DwMGaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=MigC00eCez0AYiD8Bi3uR5vUblihAN7OJ3KK8sbnotw&m=tJRHixSYq-VP6FIxTiP35xdkMZl3FaXQVx1qay3XZ-7I4UkhUxDC7h1P98bVhcBb&s=hffLCC65eIfPsnmm3hnO-CV4DYCZYG2ebSippldU3zw&e=
Publications: Google Scholar [scholar.google.co.uk]https://urldefense.proofpoint.com/v2/url?u=https-3A__scholar.google.co.uk_citations-3Fhl-3Den-26user-3D5XjBm94AAAAJ-26view-5Fop-3Dlist-5Fworks-26sortby-3Dpubdate&d=DwMFAg&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=MigC00eCez0AYiD8Bi3uR5vUblihAN7OJ3KK8sbnotw&m=KIKynKbLKfS4YVQYVctJHL39ls39CbRogxK7G0OumbwWdwS4Qdlkrg9NnRJHPJGs&s=T2pa4qY1i623xxULQ3x4gTTj4JvNcKbwYHoNm5knTFc&e=
From: Diego De Panis @.>
Reply to: ERGA-consortium/EARs @.>
Date: Monday, 29 April 2024 at 15:00
To: ERGA-consortium/EARs @.>
Cc: Subscribed @.>
Subject: Re: [ERGA-consortium/EARs] rMalMon1 EAR (PR #37) [EXT]
Hi @fcamara7 [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_fcamara7&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=MigC00eCez0AYiD8Bi3uR5vUblihAN7OJ3KK8sbnotw&m=kCRyd1jTmXuh7AYOukssECAGxS41h4Z-_vt0hBODfduSYAi-5i1pCTLkUKvt4XII&s=BlsrCwGzBIDasvJdR1yFk3dRZfR4KLBVra3X2muzyk4&e=
Thanks for sending the EAR of Malpolon monspessulanus
I added the corresponding tag to the PR and appointed @tbrown91 [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_tbrown91&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=MigC00eCez0AYiD8Bi3uR5vUblihAN7OJ3KK8sbnotw&m=kCRyd1jTmXuh7AYOukssECAGxS41h4Z-_vt0hBODfduSYAi-5i1pCTLkUKvt4XII&s=8Duo6oyFrtEatuvXujqubxoXHoD-YqxKLQerJ3KuiVQ&e= as assignee to supervise.
I will contact a reviewer ASAP.

EAR Reviewer Selection Process
Date: 2024-04-29 15:59
All Eligible Candidates:
Github ID     | Full Name   | Institution | Total Reviews | Last Review | Active | Busy | Calling Score | Adjusted Score

additive3     | Jo Wood     | Sanger      | 1             | 2024-02-26  | Y      | N    | 999           | 1049
SarahPelan    | Sarah Pelan | Sanger      | 1             | 2024-03-22  | Y      | N    | 999           | 1049
joannacollins | Jo Collins  | Sanger      | 1             | 2024-03-27  | Y      | N    | 999           | 1049
DomAbsolon    | Dom Absolon | Sanger      | 1             | 2024-04-22  | Y      | N    | 999           | 1049
tommathers    | Tom Mathers | Sanger      | 1             | 2024-04-26  | Y      | N    | 999           | 1049
tbrown91      | Tom Brown   | IZW         | 8             | 2024-02-21  | Y      | N    | 993           | 993
Selected reviewer to call first: Jo Wood (additive3)
The decision was based on:

different institution ('Sanger')

active ('Y')

not busy ('N')

highest adjusted calling score in this particular selection (1049)

chosen based on oldest review and fewest reviews among the finalists

—
Reply to this email directly, view it on GitHub [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ERGA-2Dconsortium_EARs_pull_37-23issuecomment-2D2082836534&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=MigC00eCez0AYiD8Bi3uR5vUblihAN7OJ3KK8sbnotw&m=kCRyd1jTmXuh7AYOukssECAGxS41h4Z-_vt0hBODfduSYAi-5i1pCTLkUKvt4XII&s=9yw1nbKJmtJRDNcu2oiL0TJCIEfUyiWlXe_DOwICGqo&e=, or unsubscribe [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABVP3G5CPKEVG4V7QKSBNCDY7ZG7FAVCNFSM6AAAAABG6KTGHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSHAZTMNJTGQ&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=MigC00eCez0AYiD8Bi3uR5vUblihAN7OJ3KK8sbnotw&m=kCRyd1jTmXuh7AYOukssECAGxS41h4Z-_vt0hBODfduSYAi-5i1pCTLkUKvt4XII&s=1LR6Ttm62PkDvJ_PT4IgJ7z7HWLTSZanteHpcSkANcQ&e=.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

The Wellcome Sanger Institute is operated by Genome Research Limited, a charity registered in England with number 1021457 and a company registered in England with number 2742969, whose registered office is Wellcome Sanger Institute, Wellcome Genome Campus, Hinxton, CB10 1SA.

Hi @fcamara7 can you please edit the pull request so that it only contains one file. It looks like you need to merge with the ERGA-consortium branch first before submitting your pull request. Please close the request and make a new one with just the rMalMon EAR

Sorry, looking again, you need to delete the mApoAgr2 folder from your EAR directory


[Docs] Typo "visitior" in sharing-a-design

Typo

Desired State
https://docs.meshery.io/extensions/sharing-a-design
It should be 'visitor'

Contributor Guides and Handbook

📚 Instructions for contributing to documentation

Meshery documentation site and source

🛠 Meshery Build & Release Strategy
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

i would like to work for this issue

@captain-Akshay , we appreciate your enthusiasm to contribute but kindly consider reviewing existing open issues in Meshery prior to contributing. This issue you have raised is duplicate of #8911

yes i actually went through that @akhilender-bongirwar but that's was on page https://docs.meshery.io/extensions/publishing-a-design
and my apologies but it wasn't clear that it was regarding all the typo "visitior"among the docs that's why i created another as its is for another page


For Teresa: 2021 Updates to SGF Webpage

Overview
Brief description of what this PR does, and why it is needed.
Demo
If applicable: screenshots, gifs, etc.
Notes
If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.
Testing

Include any steps to verify the features this PR introduces.
If this fixes a bug, include bug reproduction steps.

This has already been resolved so closing this one

This has already been resolved so closing this one


Undepends on blade binaries

Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

#177


Outbound http controller

See https://github.com/pondersource/nc-sciencemesh/issues/122

Closing this one as a duplicate of that, since we can now see them both in https://github.com/orgs/pondersource/projects/1/views/4?layout=board&filterQuery=outbound


Remote team clock

Description
Create the component as shown in the video attached below.
Animation Preview

Screenshot/Video:

https://github.com/user-attachments/assets/c6a218ef-9b09-44aa-9bc5-24f80860c041

[!NOTE]
Please refer to the Animata contributing guidelines available here for rules on how to contribute to the project. Let us know in the comments if you’re working on this issue, and feel free to ask any questions!

Requirements

Create a new animated component that matches the provided design.
Add example usage of the component in the documentation or storybook.

 Guidelines & Best Practices

Write reusable and clean code following the project’s style guide.
The component should be fully customizable. The user should be able to modify props such as duration, easing, color, and size where applicable.
Follow the Contributing Guidelines before submitting your pull request.

[!IMPORTANT]
To ensure more contributors have the opportunity to participate, we kindly request that:

Each contributor submits only one pull request related to this issue.
If you're interested in working on this issue, please comment below. We will assign the issue on a first-come, first-served basis.

Additional Resources
Posted on X by: https://x.com/KumailNanji/status/1821162391419093017

[!Tip]
Join our Discord community if you need help or have any questions. We're here to help you get started and guide you through the process. Join now

plz assign this to me..

@ShoomanKhatri  Sure, I will assign it once you're done with your other issues. In the meantime, this will remain unassigned for other contributors.

Hie @ShoomanKhatri
Can i take this task ? can you provide any reference?

Hey, can I be assigned this task? I already have the PR finished with me.

i would like to take part in this!!!

Hey @sudhashrestha,
I’ve created the PR: https://github.com/codse/animata/pull/368.
Please review it and let me know if any changes are needed. Looking forward to your feedback.


New: Decouple configuration unit tests from main suite

Configuration unit tests affects whole TestNG tests. That is, when running 1 random test from IDE, (@(Before|After)Suite) configuration also run and fail (because no related configuration test was run).
Solution introduced to run dedicated programmatically created test suite inside configuration test, and analyse results, thus decoupling (@(Before|After)Suite) configuration from main suite.

[x] Add test case(s) - not applicable
[x] Update CHANGES.txt

@dsankouski Could you fix the conflict?
@krmahadevan LGTM, could you check too?


fixes #98

using THashSet to store nonStandardIndicators and traversing the via forEach without the need to create iterator

Fixed by  https://github.com/consulo/consulo/commit/698acdd6f26911bc5419f4d3691032b8517ca287


Update New-TransportRule.md

“Applies to:” with ExO and ExO Online Protection
is misleading/confusing because it’s the opposite message than the statement at the beginning that SCL-Exceptions DO NOT apply in ExO.

@MithunRathinam, same comment and actions as #10837.


Use StringIndexType from Azure.Core and default to UTF-16

There was some talk about putting StringIndexType into Azure.Core, and @annatisch suggested we default it to UTF-16 if not hide it all together.
/cc @maririos

See https://github.com/Azure/azure-sdk-for-net/blob/fe8e623c8ef31810a4712fb12fec4ecbc019859f/sdk/textanalytics/Azure.AI.TextAnalytics/src/Constants.cs#L10 for what @maririos did.

Looking at how this is handled in the TextAnalytics in the Python SDK - the default is set at the client level, and can be overridden per operation. The default value is UnicodeCodePoint.
Current default in QnA is TextElements_v8. I think if the default is to change - that needs to be from the Service team and updated in the Swagger spec.
As for hiding this setting and handling it internally, for QnA, this is part of the request model, not an operation argument. And the model already defaults the value.

For more context on TA, the default for the service is also TextElements_v8 so someone that uses REST can decide which encoding according to the environment they are using.
Each library sets the value that aligns with its language. .NET, JS, and Java use Utf16CodeUnit and Python UnicodeCodePoint so the output the service sends makes sense for that language

Ah thanks for that context @maririos! That helps :)

In that case we might need to move the clientside per-language default into a directive in the autorest readme to update the model. Otherwise we'd need to hand-wrap the generated models which I'd rather avoid...
Or we remove this from the generated model entirely, and like TA, have this as a client parameter that we apply to the outgoing model on request.


Receive: First-use screen design with tips

In our call #94, we discussed that users may not know which fields are optional and may have concerns about privacy if they think that some of the text information in payment requests will be stored o the blockchain and visible to the public in all eternity.
One suggestion was to show an intro screen before creating the first payment request, to explain these things. That way we would not have to litter the receive form with lots of "optional" tags and explainers.

Came up with something like this. Probably can be shorter and I am not sure If we need to mention the name of fields. Could also be a modal.

We should just do our best with this copy and then rely on user testing to see what they say. People might say certain things we mention are super obvious, but then have other questions, and we can then switch the info around.
Should we tell users that they can keep track on payment requests status in the activity list?


Provide a mechanism to specify text/template delimiters in the template-resources

I'd like to use confd to template Apache Camel routes which use {{ and }} for properties placeholders and having to escape them all in the template file would make it look horrific and hard to manage.  It would be easy to change the delimiters to say [[ and ]] so that {{ and }} will be treated as literals and left alone in the route file.
Specifying the delimiters in the global confd configuration file would be useful if one wanted it to be set globally, but by also being able to specify the delimiters in the template resource, it would allow for context dependent setting that would only apply to the given template.  Once this is done, a simple modification to func createStageFile in resource/template/resource.go such as the following makes it easy to add this capability (please forgive me for any bad syntax, I'm not a go programmer):
if t.delimiters != nil {
tmpl := tmpl.Delims(t.delimiters.left, t.delimiters.right)
}
then execute the template to create the stage file as in
if err = tmpl.Execute(temp, nil); err != nil {
etc...
Thanks!!!

@metcalfjm it sounds like a great idea! I've been doing just fine escaping the {{ and }}, so that was not on the table for me. Feel free to open a PR with changes.


Is it possible to import other functions in

example
<style scoped lang="ts">
import { test } from './test'

css({
  '.demo-button': {
    '--button-primary': (props) => `{color.${props.color}.600}`,
    '--button-secondary': (props) => `{color.${props.color}.500}`,
    display: 'inline-block',
    borderRadius: '{radii.xl}',
    transition: '{transition.all}',
    color: () => test(),
    boxShadow: `0 5px 0 {button.primary}, 0 12px 16px {color.dimmed}`,
    span: {
      display: 'inline-block',
      fontFamily: '{font.secondary}',
      borderRadius: '{radii.lg}',
      fontSize: '{fontSize.xl}',
      lineHeight: '{lead.none}',
      transition: '{transition.all}',
      backgroundColor: '{button.primary}',
      boxShadow: 'inset 0 -1px 1px {color.dark}',
    },
    '&:hover': {
      span: {
        backgroundColor: '{button.secondary}',
      }
    },
    '&:active': {
      span: {
        transform: 'translateY({space.4})'
      }
    }
  },
  variants: {
    size: {
      sm: {
        span: {
          padding: '{space.4} {space.6}',
        },
      },
      md: {
        span: {
          padding: '{space.6} {space.8}'
        },
      },
      lg: {
        span: {
          padding: '{space.8} {space.12}'
        },
      },
      xl: {
        span: {
          padding: '{space.12} {space.24}'
        },
      },
      options: {
        default: {
          initial: 'sm',
          md: 'md',
          lg: 'lg',
          xl: 'xl'
        },
      },
    },
  },
})
</style>

For component library scenarios, we may need to be compatible with various types of props and different components will reuse similar logic. We can try to introduce this approach to achieve logic reuse. The reason for not using utils is that utils must use dynamic imports, and its meaning is more about style reuse rather than logic judgment reuse.

I have created a pull request for this, but there are still some issues that exist currently. Once I have refined the details, I will push it.

Hey @SGAMERyu :)
Thank you so much for the pull request!
I would like to reach you out concerning your work on Pinceau, could we talk on Discord?
I think I sent you a message recently there!


cilium-dbg: Add sysdump command

This command, expected to be run inside the Cilium container, simply
informs users with a friendly message that they are using the wrong tool
to dump clusterwide state, and provides a link about how to do so.
Suggested-by: André Martins<EMAIL_ADDRESS>

The context here is we've started receiving bug reports from users using the wrong tool to run the sysdump. I figure we could mitigate that a little by providing a more user-friendly message to tell them how to do it correctly.

/test


Downloading

How do I input it as a plugin to my better discord..?

in %appdata%/BetterDiscord/plugins
You need to download zeresPluginLibrary too, and put it in the same folder.


Don't fail-fast containerd test matrix

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We now set fail-fast to false for large matrixes like the containerd tests to not abort ongoing jobs which may succeed.
Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
Which issue(s) this PR fixes:

None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

/approve
/lgtm


[audio] Unable to play music audio.. but can play sound audio

I'm using code from GitHub as of 2019-09-01 for raudio.c/raudio.h  and running this stand-alone.  I'm into problems using the Music set of functions.  When I write the following:
`
Music	music;

InitAudioDevice();
music = LoadMusicStream(argv[1]);
PlayMusicStream(music);
getchar();
UnloadMusicStream(music);
CloseAudioDevice();

`
It acts as if it's playing but actually, I get no audio output, and it shows when calling the function GetMusicTimePlayed(), it will stay at a consistent 0.
INFO: Audio device initialized successfully
INFO: Audio backend: miniaudio / WASAPI
INFO: Audio format: 32-bit IEEE Floating Point -> 32-bit IEEE Floating Point
INFO: Audio channels: 2 -> 2
INFO: Audio sample rate: 44100 -> 48000
INFO: Audio buffer size: 1440
INFO: Audio multichannel pool size: 16
INFO: Audio stream loaded successfully (44100 Hz, 32 bit, Stereo)
INFO: [C:\test\ff.mp3] MP3 sample rate: 44100
INFO: [C:\test\ff.mp3] MP3 bits per sample: 32
INFO: [C:\test\ff.mp3] MP3 channels: 2
INFO: [C:\test\ff.mp3] MP3 total samples: 9582336
Everything looks normal except that no audio is being played.
Now if I were to use the Sound set of functions everything works fine:
`
Sound	sound;
InitAudioDevice();
sound = LoadSound(argv[1]);
PlaySoundMulti(sound);
getchar();
UnloadSound(sound);
CloseAudioDevice();

`
I'm compiling on Windows with Visual Studio 2013 x64.  Let me know if there's something that I'm missing?

I tried a few things to see if I could debug the issue.  The first thing I tried was disabling various backends to see if that would make a difference using DirectSound and WinMM from the miniaudio.h to see if that would make a difference.  However, the results remained the same where audio only worked using the Sound related functions but nothing using Music.
I tried a different computer to see if maybe if it had something to do with my sound card, but also got the same result.

@cheesetaco123 did you try with different files and different file formats (.ogg, .mp3)?

@raysan5, thank you for your reply.  I have tried the samples within the resources folder being chiptun1.mod, guitar_noodling.ogg, mini1111.xm, and tanatana.flac & .ogg versions using the Music functions.  It seems that using the Music API functions that I'm able to read all of these files.. but sadly no audio.
However using the Sound functions, I can hear the guitar_noodling.ogg, and tanatana.ogg.
Today, I'm going to try and install Visual Studio 2017 to see if maybe it's something to do with the version of compiler that I'm using and will report back.

Sadly, I got the same results on Visual Studio 2017 as well on a totally different computer..  The last thing that I can think of is that I am building this stand-alone.  So to do this, maybe I should explain I am pulling the following files into a project:
dr_flac.h
dr_mp3.h
dr_wav.h
jar_mod.h
jar_xm.h
miniaudio.h
raudio.h
raudio.c
stb_vorbis.h
main.c
Then within the raudio.c, I had made the following modifications so that it would pull in the file format support, and allow it to run in this way.
#define RAUDIO_STANDALONE
#if defined(RAUDIO_STANDALONE)
#include "raudio.h"
#include <stdarg.h>         // Required for: va_list, va_start(), vfprintf(), va_end()
#else
#include "raylib.h"         // Declares module functions

// Check if config flags have been externally provided on compilation line
#if !defined(EXTERNAL_CONFIG_FLAGS)
#include "config.h"         // Defines module configuration flags
#endif
#include "utils.h"          // Required for: fopen() Android mapping
#endif
#define MA_NO_JACK
#define MINIAUDIO_IMPLEMENTATION
#include "miniaudio.h" // miniaudio library
#undef PlaySound                // Win32 API: windows.h > mmsystem.h defines PlaySound macro

#include <stdlib.h>             // Required for: malloc(), free()
#include <string.h>             // Required for: strcmp(), strncmp()
#include <stdio.h>              // Required for: FILE, fopen(), fclose(), fread()

#define SUPPORT_FILEFORMAT_OGG
#if defined(SUPPORT_FILEFORMAT_OGG)
#define STB_VORBIS_IMPLEMENTATION
#include "stb_vorbis.h"    // OGG loading functions
#endif

#define SUPPORT_FILEFORMAT_XM
#if defined(SUPPORT_FILEFORMAT_XM)
#define JAR_XM_IMPLEMENTATION
#include "jar_xm.h"        // XM loading functions
#endif

#define SUPPORT_FILEFORMAT_MOD
#if defined(SUPPORT_FILEFORMAT_MOD)
#define JAR_MOD_IMPLEMENTATION
#include "jar_mod.h"       // MOD loading functions
#endif

#define SUPPORT_FILEFORMAT_FLAC
#if defined(SUPPORT_FILEFORMAT_FLAC)
#define DR_FLAC_IMPLEMENTATION
#define DR_FLAC_NO_WIN32_IO
#include "dr_flac.h"       // FLAC loading functions
#endif

#define SUPPORT_FILEFORMAT_MP3
#if defined(SUPPORT_FILEFORMAT_MP3)
#define DR_MP3_IMPLEMENTATION
#include "dr_mp3.h"        // MP3 loading functions
#endif

Not sure if there's anything you could suggest anything else I could experiment with?

should also add.. here's main.c
#include <stdio.h>
#include "raudio.h"

int
main(int argc, char *argv[])
{

	Music	m;

	InitAudioDevice();
	m = LoadMusicStream(argv[1]);
	PlayMusicStream(m);
	getchar();
	UnloadMusicStream(m);
	CloseAudioDevice();
}

@cheesetaco123 Audio system was reviewed yesterday, please, could you try with latest version from github?

@raysan5 Thank you for the attempts to look into the issue.  I have pulled the latest and tried the code, but sadly getting the same results.

Let me know if there's any additional tests that I can try?

This is weird, I've done some tests and everything works perfect for me. Also, Sound playing uses exactly the same internal playing backend than Music, only difference is that Music is sent to device in pieces and Sound in one go... sorry, no idea what could happen, it should be debugged on your device...

Closing this issue for now.

I would like to report the same issue. I had an .ogg file and, although it was loaded correctly, it didn't play.
After some toying around I found that GetMusicTimePlayed(·) always returned 0, even though IsMusicPlaying(·) returned 1.
Finally, I could hear the music calling
UpdateMusicStream(music)

on each frame.
I am not sure is this workaround is efficient with the resources though.

@autopawn Actually, that's the expected behaviour. You must update the Music stream buffer every frame.

Sorry, I saw https://github.com/raysan5/raylib/issues/957#issuecomment-527130878 and I thought that it was right since nobody commented on it.
Maybe improving the comment
// Updates buffers for music streaming

on the cheatsheet, by adding something like (this should be called on every frame) could be useful.
Although, my failure not looking at the examples.


artisan queue:restart not working properly with daemon

Hello,
I know this bug as already been reported, but all issue related have been closed, example: #6950.
What's the issue:

run queue daemon (php artisan queue:work --daemon on 5.2)
run ps |grep php you will see your process
run queue restart (php artisan queue:restart)
run ps |grep php process has been killed, not restarted

I test it with redis and rabbitmq drivers. Bug exist since 4.1 at least. If you need a working project to see the bug on action, I can provide one.
How It should work, when we do a restart, the process should be reloaded after spawining it.
Solution I see:

fix to make this working as wanted and provided by the documentation => complex, but it could help
adapt the documentation to say what it really do following you use daemon or listen option in queues => easy, no code to change, just habit of people

What cache driver please?

Correct me if I'm wrong, don't you still need supervisord (or equivalent) to start the new process.

Yes, you are totally correct @crynobone. Restart just means "stop".

So I raise an issue in the documentation?

hello,
i've a question,
when i'm doing a queue:restart and then a ps,
my workers are still there.
it's a cache problem?
thanks


Add support for importing CityJSON datasets

This PR relates to #88. A first version of the CityJSON import is ready for review.

@clausnagel cool work!
One thought: It seems that the CityJSONReader read the CityJSON file into main memory, which may leads to java.lang.OutOfMemoryError when importing large CityJSON file.  Is it possible to use chunk-wise read&Import like the CityGML-Import?

Thanks @yaozhihang. Yes, you are right, each CityJSON dataset is read into main memory for processing. There are deliberate design decisions in CityJSON that hinder a similar chunk-wise parsing of input datasets as we have implemented it for GML-encoded CityGML datasets. Also see this CityJSON issue: https://github.com/tudelft3d/cityjson/issues/6.
A good overview of pros and cons of the CityJSON approach can be found here: https://github.com/tudelft3d/cityjson/issues/20.
Being able to read a CityJSON dataset feature-by-feature would help us to keep the memory footprint of the import process low. The CityJSON approach is rather to keep the size of individual files small, and then to link several files by a master file (very much like the tileset.json file is used in 3D Tiles). This is of course also a valid approach.
To avoid out of memory errors while parsing a CityJSON file, we could add a simple file size check and refuse processing files that exceed a certain limit (not sure what this limit is though). Any other ideas are welcome!
For the export of CityJSON files (see #89) we will face a similar challenge. The current CityGML export simply streams every city object into the output file. For the CityJSON export, we have to make sure that the output file doesn't grow too big. One approach could be to limit the number of city objects per file. Or we could enforce a spatial tiling for every CityJSON export, with every tile being written to a separate CityJSON file. The second approach would be easier to implement based on the exisiting code. Well, again, I'm happy for ideas.

Hi @hugoledoux, nice to meet you here.

Yes, XLink information is temporarily stored in a database (either server-side or in a local file-based database). The XLinks are resolved in a separate step after the import. This allows us to handle forward and backward XLinks in arbitrarily large files, but requires a two-phase import approach.

For textures (especially global appearances) it's the same.

We already offer spatial tiling or a maximum feature count for CityGML exports to keep the output file sizes small. But if the user doesn't define this, we currently do not have to take special care because we then simply stream into a single (and potentially huge) file. The user must know what to do with this result and how to further consume it.
This fallback strategy would have to be different for CityJSON. But that's fine, just takes additional efforts. The master-file approach you have in mind would be a way to handle this (if you already have material to share I would be interested). The only additional issue I see is how this would work with a WFS service.

Yes, falling back to cjio would be an option. cjio could be either bundled with the Importer/Exporter, or (as a first simple solution) we could point the user to cjio in a user dialog if the CityJSON file size is too big.

Well, I did some more experiments with large CityJSON files. It seems that the Gson library we use for reading CityJSON has a memory issue. For a 200MB CityJSON file, Gson occupies ~6GB while parsing. The memory is released once the file has been read, but the application may have already crashed beforehand. Well, not so nice, will have to take a closer look at this.

https://github.com/3dcitydb/importer-exporter/blob/cityjson-import/impexp-core/src/main/java/org/citydb/citygml/importer/reader/cityjson/CityJSONReader.java#L56
I'm not sure if its is bug. The code line above shows that the global appearances are counted for the feature counter filter. But according to the documentation (p.138), the counter filter should only be applied for top-level features. The CityGMLReader may have the same issue.

@yaozhihang I did not change the behaviour compared to the master branch. Global appearances are counted there as well. I think this is a separate discussion and independent from this PR. Would you like to go ahead and create a new issue for this?

I reworked some of the Gson code in citygson which helped to reduce the memory footprint by the factor ~4.5. The importer can now handle reasonably large CityJSON files. There will always be an upper limit, but also other software will face this.

@clausnagel Nice. The import of the large CityJSON file is now significantly better!
I found another small issue. When running a validation process against this CityJSON dataset Test_LOD2_Building_CityJSON.zip, the console window prints out the following error message:
[14:31:08 ERROR] An unexpected error occurred.
[14:31:08 ERROR] java.lang.RuntimeException: Failed to invoke public org.citygml4j.cityjson.feature.AbstractCityObjectType() with no args
[14:31:08 ERROR] java.lang.InstantiationException: null

Nevertheless, the CityJSON-Import works very well.

fixed in 729862fb231abf9c8dfe2cb13c811d076dfee32d


invalid_count block other tests execution

Steps to reproduce:
Table contain column 'strColumn' which type is 'string'
test.yml:
checks testTable:
    - row_count:
        warn: when = 0
        name: Table cannot be empty
    - schema:
         fail:
            when required column missing:
               - strColumn
    - missing_count(strColumn) = 0:
          name: strColumn should be provided
    - invalid_count(strColumn) = 0:
          name: strColumn must be a positive number # << Not true because strColumn is string
          valid min: 1                                                      # << Invalid pattern because string cannot be greater then 1

Expected results:
At least 3 results should be returned for row_count, schema and missing_count. Error from the invalid_count should be captured by get_checks_fail_text()
Current results:
1 result received for schema, 3 results missed
Environment:
soda-core-spark-df==3.0.46
Databricks

SODA-1806

@jmarien what this number mean?


[Task]

Description

Add apache incubutor footer page in hertzbeat website footer https://hertzbeat.apache.org/

refer https://streampark.apache.org/

Task List

[ ] Add apache incubutor footer page in website

I'll have a try


PnP-Site DisableFlow doesn't work on communication site

The flow disabling script doesn't work for the communication site. I have executed the following commands and the execution was successful without any issues (no errors).
Connecting to site via the command Connect-PnPOnline -Url https://tenant.sharepoint.com/sites/sitename -UseWebLogin
Then executed the script Set-PnPSite -DisableFlows:$true for hiding flow button.
But the button is not hiding on the page library. Unfortunately this seems to be an issue with Set-SPOSite command as well. I understand the scripts will throw error for group connected sites, but should work for communication sites. am I missing some facts here?
Any help appreciated!
Thanks, Nakkeeran.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a453f6db-c1b0-3769-9972-d948616982df
Version Independent ID: d9e27a2c-8408-95ba-6d88-46e63fe878a1
Content: Set-PnPSite (PnP.Powershell)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Set-PnPSite.md
Service: sharepoint-powershell
GitHub Login: @pamgreen-msft
Microsoft Alias: pamgreen

Hello @nakkeerann
how are you?
Even though the PnP documentation articles are on this repository, I need to kindly redirect you to open PnP cmdlets issues/pull requests here, in that repository, where a member of the PnP community will be able to correct the article/review your PR with your feedback.
The documentation for PnP cmdlets is then synced from that repo into this one.
Thank you!

@get-itips Thank you very much for the contribution and sharing this explanation. @nakkeerann Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Table: add setRowsSynced method

Fixes #414.
The tests assert that:

the table is initialized with a synced array
the synced array may be replaced
the replacement array is correctly synced
mutating the replaced array has no effect

While we're at it: do the row mutation methods (addRow, insertRowAt, removeRow, ...) all work as intended when { enableSync: true } or (if not) are they intended to do so? Should they delegate to the proxied array or throw?

– https://github.com/offirgolan/ember-light-table/issues/414#issuecomment-306396016
Fun fact: they delegate to the synced array. It may be noteworthy that setRows does not destroy or replace the binding. Instead the synced array's elements are replaced with the given rows.


How to start GUI

Hello,
Is it possible for you to add some steps describing how to actually launch the GUI?  I managed to get everything installed, but can't figure that out.
This is really attractive to someone like me who would like to play around in Seurat, etc. but never finds the time to actually learn R.
Thanks!

After installing
BingleSeq::startBingleSeq()

After installing
BingleSeq::startBingleSeq()

Hi,
I have now updated the readme to include the command. Thanks both!

Hi,
I have now updated the readme to include the command. Thanks both!


v1.0.6

Changes:

Move config.json to /etc/wlanpi-chat-bot
Move yaml commands and bash scripts into Python module and include as package data
Handle exception which occurs when we have reachability and an invalid bot token (404 error)
Add --bot_token option to pass in the token during development
Add --debug option to increase debug output when running chatbot directly during development

So, for development, you could do something like this:
cd <repo root>
source venv/bin/activate
(venv): sudo venv/bin/python3 -m chatbot --debug --bot_token "5057111591:AAE1h2dHaWJXmv1s_hKL2a1Szb8e2_8eAa0"

Nice updates! Thanks.


Add deploy pipeline run list into stage page

Acceptance criteria:
enable diagram tree like for CI part;


Add ability to generate report from template

I just add some automation to remove routine manual work when you create report from template.
add

ZIF_EXCEL_READER->LOAD_SMW0  to load template from smw0
ZCL_EXCEL->FILL_TEMPLATE to merge template with data
ZCL_EXCEL_TEMPLATE_DATA  -  class to hold data
ZCL_EXCEL_FILL_TEMPLATE  - class that merge data with template

change

ZCL_EXCEL_WORKSHEET->MT_MERGED_CELLS type to public

complete article with examples, instruction how to use it
https://blogs.sap.com/2020/05/22/best-way-to-generate-microsoft-excel-xlsx-from-template-in-abap/

Please, help me.
What wrong with TYPES?

EMPTY KEY does not exist in 702

Do I need additional proactive steps on my part to merge the code?

I hope this new feature will be quickly approved and merged. It will accelerate Excel development a lot.

@AntonSikidin check conflicts

#781 was merged and resulted in some conflicts, sorry for the inconvenience.

@AntonSikidin I am currently reviewing your PR, I will solve the conflicts and do some proposal soon.

Dear Anton, owners and contributors,
First of all, Anton, sorry for the delay for reviewing such a great improvement. As it's quite complex, it took some time to review your PR, so I preferred to not solicit you again for all intermediate merged PRs during the review.
I'd like to propose some little changes and I need your opinion and approval. I also solicit owners and contributors for the same because it's an important improvement (@AndreaBorgia-Abo @gregorwolf @larshp etc.). I made Anton's solution + proposed changes available here: https://github.com/sandraros/abap2xlsx/tree/New-Review-of-AntonSikidin. Below is the list of all my points and questions.
The tool is described in the link above posted by Anton.
Thanks for reading and helping me.
Sandra
As I propose many (but little) changes, I first describe the major changes which are most impacting:

Changes impacting people who already use Anton's fork:

Removal of DDIC objects, replaced by class types (to reflect current abap2xlsx trends to not use DDIC objects, unless mandatory)
Some public members from ZCL_EXCEL_FILL_TEMPLATE were turned into private: all the methods (one public method CREATE was added to call them) and the attribute mt_merged_cells.
People who made some forks may be disturbed by renamed local variables and renamed private types, and the many little changes.

Noticeable improvements:

Program ZDEMO_EXCEL_GET_TYPES (generator of TYPES statements based on the Excel template file): it can propose automatically the types string, t_number, D and T, based on cell number formats, to reduce the adaptation work.
Coding (internal): I removed some code by using existing abap2xlsx methods like SET_CELL, DELETE_MERGE and SET_MERGE.

More questions:

Should we keep the new method LOAD_SMW0? (the goal is to load Excel template files from SMW0) I personally agree with that (con: there are other possibilities to store files, if we do it for SMW0, there's no reason to refuse other people proposing other methods ; pro: providing one way to deliver Excel file demos with abap2xlsx is a good point, and we can say it will be the only method provided by abap2xlsx)
I preferred to place the program ZDEMO_EXCEL_GET_TYPES in the _demos package. This program is essential in proposing automatically the TYPES coding, but it's neither a demo program nor an abap2xlsx runtime program, it's made to help people create their programs quickly. I don't think another package is to be created, but maybe should it be placed in the main package?

Proposed detailed changes:

General proposal: use abap2xlsx coding guidelines everywhere:

There's a new naming proposal here, that I applied to the private and local objects, but not to the exposed names (public objects, parameters) because the tool is already published.
There are new DDIC objects that I propose to remove because we are trying to not create any more DDIC object in abap2xlsx (and even removing them). I hope that it will not have too much impact on existing installations.
DATA, FIELD-SYMBOLS, etc., are moved to the top of each procedure instead of placing them in the middle of procedures (right before usage).
Position of dot and comma in chained statements, proposing to have:DATA: lv_var1,
  lv_var2.

instead of:DATA
     : lv_var1
     , lv_var2
     .

AND/OR on two lines, proposing to have:LOOP AT ... WHERE field1 = field1
              AND field2 = field2
              AND field3 = field3.

instead of:LOOP AT ... WHERE field1 = field1 AND
                  field2 = field2 AND
                  field3 = field3.

New program ZDEMO_EXCEL_FILL_TEMPLATE

Proposal: change package to _demos
Proposal: default choice changed to read the Excel template from the demo example in the MIME Repository, so that people can immediately execute and see the result.
Proposal: replace obsolete OCCURS with TYPE STANDARD TABLE.
Proposal: change path from C:\Users\sadfasdf\Desktop\abap2xlsx\ZABAP2XLSX_EXAMPLE.xlsx to c:\temp\whatever.xlsx as in ZDEMO_EXCEL37.
Proposal: handle exceptions if file is not found, etc., to avoid short dumps.
Proposal: change type of date and time fields from respectively C 10 and C 8 to D and T, so that to provide a more convenient example. Note that the Excel template file has been updated accordingly to have cells with date and time number formats.

Changed class ZCL_EXCEL

New method FILL_TEMPLATE

Proposal: replace calls to the 4 methods CREATE OBJECT, GET_RANGE, SIGN_RANGE and FIND_VAR from ZCL_EXCEL_FILL_TEMPLATE, by unique new method CREATE from ZCL_EXCEL_FILL_TEMPLATE.

Changed class ZCL_EXCEL_WORKSHEET

New attribute mt_merged_cells

Proposal: keep it private instead of making it public (see reason in zcl_excel_fill_template)

New class ZCL_EXCEL_FILL_TEMPLATE

Proposal: turn all public methods into private, except FILL_SHEET (called by method FILL_TEMPLATE of ZCL_EXCEL) and create method CREATE (calls the other methods which are now private) which calls CREATE OBJECT, GET_RANGE, DISCARD_OVERLAPPED, SIGN_RANGE.
Proposal: public attributes should be READ-ONLY
The proposed changes imply adding RAISING zcx_excel in the methods.
New attribute MT_NAME_STYLES filled by method FIND_VAR; it's used by program ZDEMO_EXCEL_GET_TYPES to determine the best ABAP type based on the number format of cells. NB: t_number is currently arbitrarily set to type P length 16 decimals 4 as decfloat16 is currently not supported by abap2xlsx.
Method validate_range

Proposal: extend possible ranges from row form 1:1 to equivalent cell form A1:XFD1, so that these ranges can be generated by abap2xlsx

Method find_var

Proposal: initialize the new attribute MT_NAME_STYLES.

Method fill_sheet

Proposal: use DELETE_MERGE and SET_MERGE instead of changing attribute MT_MERGED_CELLS from private to public to change its value directly. Added RAISING zcx_excel in the method signature.

Method fill_range

Proposal: rename parameter CH_DIFF into CV_DIFF
Proposal: replace LOOP AT EXIT with READ TABLE
Proposal: review the logic of Excel [variable] replacement by calling the method SET_CELL of ZCL_EXCEL_WORKSHEET which handles it nicely. That also avoids referring to cl_abap_typedescr=>typekind_int8 which does not exist in 7.02.

Method get_range

OK

Method sign_range

OK

Method discard_overlapped

OK

New DDIC structures and types

Proposal: replace them with types in classes or other same existing types.DDIC Object                    Replacement
-----------------------------  ----------------------------------------
zexcel_s_template_data         ts_template_data_sheet    in zcl_excel_template_data
zexcel_t_template_data         ts_template_data_sheets   in zcl_excel_template_data
zexcel_template_s_range        ts_range                  in zcl_excel_fill_template
zexcel_template_s_var          ts_variable               in zcl_excel_fill_template
zexcel_template_sheet_title    zexcel_sheet_title (DDIC)
zexcel_template_t_cell_data    private type tt_cell_data_no_key in zcl_excel_fill_template
zexcel_template_t_range        tt_ranges                 in zcl_excel_fill_template
zexcel_template_t_sheet_title  tt_sheet_titles           in zcl_excel_template_data
zexcel_template_t_var          tt_variables              in zcl_excel_fill_template

New program ZDEMO_EXCEL_GET_TYPES

Proposal: change package to _demos
Proposal: propose types t_number (arbitrarily set to P length 16 decimals 4), date, time or string based on cell number format (thanks to new attribute MT_NAME_STYLES of ZCL_EXCEL_FILL_TEMPLATE)
Proposal: change path from C:\Users\sadfasdf\Desktop\abap2xlsx\ZABAP2XLSX_EXAMPLE.xlsx to c:\temp\whatever.xlsx as in program ZDEMO_EXCEL37.
Proposal: Replace calls to CREATE OBJECT, GET_RANGE, DISCARD_OVERLAPPED, SIGN_RANGE, FIND_VAR with the call to the new method CREATE
Proposal: instead of generating obsolete code OCCURS 0, use TYPE STANDARD TABLE OF ... WITH DEFAULT KEY (compatible 7.02)

New class ZCL EXCEL TEMPLATE DATA

Proposal: add READ-ONLY to MT_DATA

Changed interface ZIF_EXCEL_READER

New Method LOAD_SMW0

OK

Changed class ZCL_EXCEL_READER_2007

New Method zif_excel_reader~LOAD_SMW0

Removal of cl_bcs_convert=>xtab_to_xstring (because it returns a XSTRING with extra null bytes and I prefer to avoid future issues) by using WWWPARAMS_READ (to read the 'filesize' attribute) and SCMS_BINARY_TO_XSTRING

ZEXCEL_DEMO_TEMPLATE (binary MIME object in SMW0)

Proposal: change package to _demos
Proposal: change MIME type from xlsx to application/vnd.openxmlformats-officedocument.spreadsheetml.sheet as there are more chances to have the latter one already configured in SAP systems (?)
Proposal: change number format of cells containing date and time fields to reflect the changed types of program ZDEMO_EXCEL_FILL_TEMPLATE, to be respectively D and T. The chosen number formats are the ones that will reflect the Windows user's regional format (e.g. m/d/yyyy for USA people, dd/mm/yyyy for French people, etc.)

ZDEMO_FILL_TEMPLATE (transaction code)

Proposal: remove it as other demo programs don't have transaction codes. There is also the central demo program ZABAP2XLSX_DEMO_SHOW which automatically adds ZDEMO_EXCEL_FILL_TEMPLATE in the list of demo programs.

Ok, at long last here are my thoughts:

LOAD_SMW0: I'm in favour of keeping this method, however I wonder if we can build some additional flexibility in the system, just not too much: a generic "LOAD" method in a dedicated interface, then we provide an implementation against SMW0. This way, one could swap in an implementation for server-side local files, archival systems, and so and so forth. Oh and... do we even have SMW0 on BTP?

Placement of ZDEMO_EXCEL_GET_TYPES: I agree, the types assistant belongs to the main package, since it doesn't demo any existing features of the library, unlike the template filler which indeed does that. The report name should consequently lose the "DEMO" part, for example "ZEXCEL_GET_TYPES".

Comma positioning: the alternate style is only useful when commenting out code to disable it, with git it makes little sense to adopt it. In favour of "comma at end".

AND/OR positioning: no opinion on this, I tend to side with the proposal but I'm sure I have occasionally written the other format.

ZCL_EXCEL_FILL_TEMPLATE: went looking for the reason "mt_merged_cells" is proposed private in the code, instead of later on in the comment, found "excell" (double L) in description. I swear I wasn't looking for typos, they're just happy to see me! ;)

Just saw this older discussion #452 about introducing a MIME Repository reader, and the answer was mostly NO. Maybe we should stay on that decision, and the code to read the MIME file should be moved to the the demo program? There is also this discussion #632 to move abap2xlsx to ABAP Cloud (BTP), I would think that it doesn't support the MIME Repository. Because of the latter discussion, I would propose to have ZDEMO_EXCEL_GET_TYPES in the new folder "not_cloud", because the program displays a dynpro (Cloud-incompatible).
NB: I'll try to push the changes proposed above to AntonSikidin:master this week-end.

Maybe we should stay on that decision, and the code to read the MIME file should be moved to the the demo program?

It comes down to these two considerations, compatibility with BTP and "core business", so to speak: this project deals with reading / writing XLSX, where from / to is not really our business. I withdraw my suggesion for a generic LOAD, makes no sense now.
Ok for "not cloud" as location for the new report.

I have pushed new commits to Anton branch.
These latest changes are as discussed:

moved the program ZEXCEL_TEMPLATE_GET_TYPES to the package "not_cloud" (this program was originally named ZDEMO_EXCEL_GET_TYPES, I renamed it because it's not a demo)
removed all the SMW0 stuff from ZIF_EXCEL_READER and ZCL_EXCEL_READER_2007 (reason: #452 and #632), and have a subroutine LOAD_SMW0 locally defined in programs ZEXCEL_TEMPLATE_GET_TYPES and ZDEMO_EXCEL_FILL_TEMPLATE. People currently using Anton version will have to review their programs if they use these SMW0 methods.

Additionally, I have:

renamed the Web Repository Excel file ZEXCEL_DEMO_TEMPLATE to ZDEMO_EXCEL_TEMPLATE to keep the names consistent with all demo objects (ZDEMO_EXCEL_*).

Now I think we can go a step further to see if everybody agrees with the latest proposals, and maybe merge this really nice feature. 😀

Finally done! 🥳 Maybe it's worth a blog post on SAP Community...

@sandraros I'm not sure you believe in coincidences, but let me tell you the story: I'm writing a guide to abap2xlsx for my coworkers and I found this conversation while trying to document templates handling. At the same time, @Keller-Michael posted "our future requires engagement".
Does this count as a sign? :)


General quality improvements

Improve:

[ ] the documentation
[ ] error messages
[ ] performance
[ ] test untested functionality

ropensci statistical standards as a reference.

Raise error when multiple estimation syntax is used twice in formula part. e1a76a7

[ ] Nicer error message when i() reference level not contained in X1.

closed as not very concrete


Explicit extending syntax

So, previously there was some logic when you wrote styled(X) that checked if X was a StyledComponent or not, which I never liked. So here's an attempt at fixing it.
const Parent = styled.div`
  margin: 0.5rem;
  width: 2rem;
  height: 2rem;
  background: papayawhip;
`

/* Old way. This used to merge Parent's rules
 * with A's, but now simply wraps it and passes
 * className to it like it was any other component.
 */
const A = styled(Parent)`
  border: 4px solid palevioletred;
`

/* New way. No extra component is created, which
 * is preferable, but now the behaviour is explicit.
 */
const B = Parent.extend`
  border: 4px solid tomato;
`

/* Now there's an explicit way of changing tags,
 * which is not something to be used all the time
 * but might be useful in some cases.
 */
const C = Parent.extendWith('span')`
  border: 4px solid peru;
`

When rendered, you can see that A simply wraps Parent but the other two don't:

We'd need the babel plugin to inject componentId and displayName correctly in this case, but it should be ok I think. This is a breaking change, because styled(X) will no longer inherit static variables like propTypes or defaultProps from X (X.extend does though), but given there's a direct upgrade path I'm fairly happy with shipping this as part of v2.

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Danger's not seeing the test changes in this PR, weird.

Also what is going on with appveyor? Failing on a whitespace bug. Could be an old transitive dependency (like stylis)? @mxstbr can we make appveyor use yarn instead of npm?

I really like this idea 👍 but in my opinion it would be cool if you could extend styled components without the extend.
const B = Parent`
  border: 4px solid tomato;
`

But then you'd have to check if this component is called as a styled-component or React component. Don't know if this is worth the little bit cleaner look.

Danger's not seeing the test changes in this PR, weird.
That's happening on other PRs as well. Might be related to the move to DangerJS.

Yeah that can't be done. Something can't be both a tagged template literal and a constructor function. But also, I think that's pretty confusing so I think .extend is good

I think there's some weirdness in it. Mainly on extendWith case, though I understand the reasoning.
Wouldn't it be better, as a API, styled-component which are going to extends another to Always define it's target?
const Parent = styled.div`
  margin: 0.5rem;
  width: 2rem;
  height: 2rem;
  background: papayawhip;
`

const A = styled.div.extends(Parent)`
  border: 4px solid palevioletred;
`

const C = styled(ThirdPartyCmp).extends(Parent)`
  border: 4px solid peru;
`

That way we got some consistency and styled only deals with its attr's, never giving the illusion to consumer that tagName is rewritable in anycase.

@geelen @edygar Am I correct in that, if this was to be merged, it will support use-case
const Icon = ({className, type}) => (
    <i className={className}>
        {type}
    </i>
)

const StyledIcon = styled(Icon).attrs({
    className: 'material-icons'
})`
    font-size: 2rem;
`

// no attrs :(
const BlueStyledIcon = styled(StyledIcon)`
    color: blue;
`

because that would be swell! :)
This is a contrived example, and might not be the most idiomatic way of using styled-components, but IMO it's the expected behavior. Implicit or explicit it would be nice to be able to do this.

BTW, I think the naming of extendWIth might be a bit unfortunate, since the behavior is more like replaceWIth. Maybe replaceWithTag to make it super clear as to what's going on? It's a bit wordy, but if it's only intended to be used rarely, that might be a good thing (like react's lifecycle methods).

Yeah I thought extendChangingTag or extendForComponent or something might be better.
@GGAlanSmithee not sure what's going on with your BlueStyledIcon above, can you clarify. But in general:
styled(X).attrs({/*... attrs ...*/})` /*... styles ...*/ `

This wraps X and passes any attrs including className which it generates from the styles.
X.extend.attrs({/*... attrs ...*/})` /*... styles ...*/ `

This creates a new component that merges attrs and styles with whatever X had previously.
Does that answer your question?

@edygar I was initially going to implement that, but decided against it. I think, in the general case, you want to keep whatever underlying tag or component was used previously.
Could you explain the need of extend? I mean, A went just fine there at your first example.
const A = styled(Parent)`
  border: 4px solid palevioletred;

Is there a recommended way to use extend on a non styled-component? Meaning, we often use styled-components to style the root component of a render function.  Just stick with styled(Component) ?

@FrancescoA yep, and pass down className to the outermost styled component.


Enhanced Scroll Button Design: Height, Width, Line-Height, and Color Adjustment

Height Adjustments: Increased the button's height for improved accessibility.
Width Adjustments: Modified the width to create a more balanced appearance.
Line-Height Adjustments: Optimized line-height for better text readability within the button.
Color Changes: Updated the color to enhance visibility and match the overall design theme.

@YOGINIMAHIMA1 this is not needed, so i am closing this issue.


Free filename_buf in save_sprites error handling and update color_values comment

The function save_sprites in src/file.c allocates memory with malloc:
https://github.com/dfirebaugh/spritely/blob/1411138521dcc3070cc5840914eda42fe87e2c6c/src/file.c#L88
Normally this memory is freed at the end of the function:
https://github.com/dfirebaugh/spritely/blob/1411138521dcc3070cc5840914eda42fe87e2c6c/src/file.c#L134
It is possible for the function to return early if the stbi_write_png call is not successful:
https://github.com/dfirebaugh/spritely/blob/1411138521dcc3070cc5840914eda42fe87e2c6c/src/file.c#L116-L128
filename_buf must be freed before this early return, otherwise the memory is leaked.
This PR adds the necessary free call.
This PR also updates the comment for color_values in src/colors.h:

Use the correct name for the array
The color_t value must be multiplied by NUM_COLOR_COMPONENTS for the index to be correct

Thank you for your work on this.  I probably should have merged this.
I'm closing this PR because i'm refactoring this project to incorporate zig.  File io will likely be rewritten.