#10: Not just fetch public methods but also fetch protected methods

I don't have a working project with disco configured in it, so I haven't been able to test this in real-world code, but I think by fetching the protected methods, it should be able to work directly (right?)

Looks good from my point of view. I quickly hacked together a test case which proved that it actually works :)
This is what I did: I added a Configuration class in the tests/bitExpert/Disco/Config folder:
/**
 * @Configuration
 */
class BeanConfigurationWithProtectedMethod
{
    /**
     * @Bean({"singleton"=true})
     * @return SampleService
     */
    protected function singletonDependency()
    {
        return new SampleService();
    }

    /**
     * @Bean({"singleton"=false})
     * @return MasterService
     */
    public function masterServiceWithSingletonDependency()
    {
        return new MasterService($this->singletonDependency());
    }

    /**
     * @Bean({"singleton"=false})
     * @return SampleService
     */
    protected function nonSingletonDependency()
    {
        return new SampleService();
    }

    /**
     * @Bean({"singleton"=false})
     * @return MasterService
     */
    public function masterServiceWithNonSingletonDependency()
    {
        return new MasterService($this->nonSingletonDependency());
    }
}

In addition to that I added 2 new methods to the AnnotationBeanFactoryUnitTest to make use of the configuration class above:

    /**
     * @test
     */
    public function protectedSingletonDependencyAlwaysReturnsSameInstance()
    {
        $this->beanFactory = new AnnotationBeanFactory(BeanConfigurationWithProtectedMethod::class);
        BeanFactoryRegistry::register($this->beanFactory);

        $bean1 = $this->beanFactory->get('masterServiceWithSingletonDependency');
        $bean2 = $this->beanFactory->get('masterServiceWithSingletonDependency');

        $this->assertSame($bean1->service, $bean2->service);
    }

    /**
     * @test
     */
    public function protectedNonSingletonDependencyReturnsDifferentInstance()
    {
        $this->beanFactory = new AnnotationBeanFactory(BeanConfigurationWithProtectedMethod::class);
        BeanFactoryRegistry::register($this->beanFactory);

        $bean1 = $this->beanFactory->get('masterServiceWithNonSingletonDependency');
        $bean2 = $this->beanFactory->get('masterServiceWithNonSingletonDependency');

        $this->assertNotSame($bean1->service, $bean2->service);
    }

Ideally we would check if each configuration setting is correctly interpreted for protected methods but for now I am fine with proving that the singleton configuration "works".
Would you mind adding both to the your branch?

Thanks, I've added the unit tests and the test configuration to my PR now. Thanks for helping me with the tests, I was unsure of how to actually test the added functionality :)

Thank you @skoop for your second contribution within a week ;)


Text and Icon not on same line in button

Hi,
I have a Button with a text and an icon in it. The text and the icon are not on the same line (see image).
How can I fix that.

i think as a hotfix, you can set margin-top: -4px or some other px to the icon tag
if i remember correct, change vertical-align doesn't work
does that work for you? if not, i can start my testserver and have a look

margin-top: -3px worked perfectly. Changing vertical-align doesnt works :(


[WIP] Enforce code style

Steps:

Add prettier
Add eslint and an appropriate configuration file
Add a git pre-hook
Add some sort of CI (Travis, Circle, ...)

This PR is more of a discussion to see what the team thinks about different configurations.

Closing, replaced with #15


add publish.yml

If we set up to publish automatically from tag pushes, then presumably the tag implies no further testing is needed for that release. It's unclear what running tests would buy us AFTER there is already a tag. If we want to run tests BEFORE tagging, that's definitely possible as well.
We should also be aware of the setup needed to run tests against actual Keygen server and hitting API request limits.
The publishing is setup by going to:
pub.dev/packages//admin
and configuring as described by this doc:
https://dart.dev/tools/pub/automated-publishing#publishing-packages-using-github-actions
Any package that we want to publish automatically has to be first setup on pub.dev.


I enter the world and no resources are generated

This is intended behavior. Minecraft resources are artificially generated anyways.

Given that one of the mod features is listed as 'Ore spawning just below surface', could you point us to which config property in the generator needs to be flipped to enabled this?
I've played around with those settings but can't seem to find it either.

Was this issue (feature) ever resolved?  How does one enable ore generation in T++?


There is already a popular HTTP request router called mux

Please consider renaming the project.

Mux is a concept not brandOn Dec 5, 2016 7:16 PM, Peter Bourgon<EMAIL_ADDRESS>wrote:Please consider renaming the project.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

Hello, If you think that is issue than i well doing itOn Dec 5, 2016 7:30 PM, Marcel Franke<EMAIL_ADDRESS>wrote:Mux is a concept not brandOn Dec 5, 2016 7:16 PM, Peter Bourgon<EMAIL_ADDRESS>wrote:Please consider renaming the project.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

They called it in the standard lib mux as well. Is this a huge issue ?On Dec 5, 2016 7:31 PM, Marcel Franke<EMAIL_ADDRESS>wrote:Hello, If you think that is issue than i well doing itOn Dec 5, 2016 7:30 PM, Marcel Franke<EMAIL_ADDRESS>wrote:Mux is a concept not brandOn Dec 5, 2016 7:16 PM, Peter Bourgon<EMAIL_ADDRESS>wrote:Please consider renaming the project.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

Muxing is a concept, but calling your project "mux" conflicts with a well-established project, and confuses users neednessly. Of course, you're free to do whatever you like.

Before i launched my project on github. i have searched on github with a key word "mux". I have found many router projects with this name and my conclusion was than that it's ok.
the namespace is different "github/donutloop/mux"


How to make spatial effect on different layers

hello, im currently trying to make a space type map and wonder if i could make panning on different layers of an svg image to move at a different rate, say i have 3 layers and want the front layer to move at normal speed and back layer at slower.

Hmm, sorry I don't think that's possible with panzoom. If the layers overlap, the top element with Panzoom initialized would eat up the events, which caters to a different use case. There may be some fidgeting you could do to make this work, but it sounds like it might be out of scope for panzoom.


Bump Dependencies #2815738150

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/2815738150

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Create whysid.json

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

This is almost ready to merge. You just need to change the name of your file to match your github username. Let us know if you need any help with that.


use true number of pileup interactions in pileup producer

It seems that in the pu_weight producer, the wrong column (PV.npvs) has been used to determine the PU event weights.
The mc_profile that is used to determine the PU weights [1] only contains values up to a number of Pileup of 73, which leads to the PU weights shown in [2].
In the PU producer, we are using these weights to determine the PU event weights based on the number of reconstructed primary vertices (PV.npvs) [3], however, this column takes values above 73, which leads to both large event weights of159 and event weights of 0.
Based on the information found in [4], I think that the correct column to determine the event weights would be Pileup.nTrueInt. I also took a look into the NanoAODs and it seems that for the UL samples, the max. value of this column seems to be around ~< 73, which would be in agreement with the mc_profile we have seen in [1].
[1] https://github.com/columnflow/columnflow/blob/3a69281abeefc614986b89f0a7601e7a45df5888/columnflow/tasks/cms/external.py#L65
(mc profile from here: https://raw.githubusercontent.com/cms-sw/cmssw/435f0b04c0e318c1036a6b95eb169181bbbe8344/SimGeneral/MixingModule/python/mix_2017_25ns_UltraLegacy_PoissonOOTPU_cfi.py)
[2] Small section of Number of Pileup vs. nominal PU weight:
 (66, 1.7605077201696504),
 (67, 2.4973721771534723),
 (68, 3.604846391289538),
 (69, 3.510370430997905),
 (70, 5.546157726604674),
 (71, 16.473486457289216),
 (72, 30.20828844763221),
 (73,<PHONE_NUMBER>439475),
 (74, 0.0),
 (75, 0.0),
 (76, 0.0),

[3] https://github.com/columnflow/columnflow/blob/3a69281abeefc614986b89f0a7601e7a45df5888/columnflow/production/cms/pileup.py#L34
[4] https://twiki.cern.ch/twiki/bin/viewauth/CMS/PileupJSONFileforData

HI @dsavoiu, thank you for the quick review!
I took a quick look into the config form the hh2bbtautau analysis and the MC PU profile seems to be the same as I linked in my PR ([1]), so I think we're save to merge.
[1] https://github.com/uhh-cms/hh2bbtautau/blob/7666ed0426c87baa8d143ec26a216c3cadde513b/hbt/config/configs_run2ul.py#L612C33-L612C197

OK, thanks for checking! Then I also think we should go ahead with the merge, and if needed we can follow up with @riga once he's back.

This looks good, thanks for the fix!
On the hh2bbtautau side we only have to adjust the renormalization, so we're good with the upstream change.


Release version

hello,
A release version or a screenshot would be nice to see your app.

Hi,
Thank you for the tip. I am new at GitHub.
I made this application just to support an article that I wrote, but I will do as you suggested.

ok thanks

I have forked your version and created a release
https://github.com/fredatgithub/ExpressionBuilder/releases/tag/v1.0


FCMA feature selection excludes the best performed voxel

Hi,
I found this potential issue for FCMA feature selection step, which may lead to excluding the best performed voxel when selecting the top k number of voxels.
At the end of the fcma_voxel_selection_cv.py:
with open(file_str + 'result_list.txt', 'w') as fp:
    for idx, tuple in enumerate(results):
    fp.write(str(tuple[0]) + ' ' + str(tuple[1]) + '\n')

    # Store the score for each voxel
    score[tuple[0]] = tuple[1]
    seq[tuple[0]] = idx

result is an iterator of tuples. tuple[0] is the voxel ID, which index the voxel, tuple[1] is that voxel's score. The tuples are ranked, such that the highest performed voxel would be ranked at the top, thus when being enumerated, the best performed voxel would have idx = 0. As a result, seq[tuple[0]] = idx would assign the best performed voxel the rank of 0.
Then when using fslmaths to select the top k number of voxels, as in make_top_voxel_mask.sh:
for file in ${input_dir}/*_seq.nii.gz
do
	# Preprocess the file name
	fbase=$(basename "$file")
	pref="${fbase%%.*}"

	# Create the voxel mask
	fslmaths $file -uthr $voxel_number -bin ${output_dir}/${pref}_top${voxel_number}.nii.gz

done

-uthr would up-threshold the input file based on the voxel_number input. For example, it k = 3000, -uthr would select voxels that have the rank from 0-3000, including the top 3000 voxels and all non-brain voxels, which also have the value of 0. Then -bin would binarize the file into a mask, excluding all voxels that have 0 value, including the non-brain voxels and the best performed voxel which has the value of 0 because it ranks 0. In this way, I believe FCMA feature selection would exclude the top-performed voxel.
If I was correct about this issue, the solution should be pretty simple, and can be done: (just added +1 to idx)
with open(file_str + 'result_list.txt', 'w') as fp:
    for idx, tuple in enumerate(results):
    fp.write(str(tuple[0]) + ' ' + str(tuple[1]) + '\n')

    # Store the score for each voxel
    score[tuple[0]] = tuple[1]
    seq[tuple[0]] = idx + 1

Please let me know if this does or doesn't makes any sense or if I misunderstood the script and this is not a potential issue. Thank you all very much!

@yidawang are you able to look at this?

The description makes sense to me. I couldn't remember all the details of how fslmaths works. If it is as described above, I am fine with the proposed fix with a 1-based index system. Please submit a PR to fix it. Thanks!


Setup action fails with is not a bzip2 file

Output of action:
Run dhall-lang/setup-dhall@v4
Fetching dhall releases from https://api.github.com/repos/dhall-lang/dhall-haskell/releases/latest
/home/runner/work/_actions/dhall-lang/setup-dhall/v[4](https://github.com/everquoteinc/omni-k8s/runs/7948120634?check_suite_focus=true#step:3:5)/src/install-dhall.sh https://github.com/dhall-lang/dhall-haskell/releases/download/1.41.2/dhall-1.41.2-x86_64-Linux.tar.bz2 https://github.com/dhall-lang/dhall-haskell/releases/download/1.41.2/dhall-json-1.7.11-x86_64-Linux.tar.bz2 https://github.com/dhall-lang/dhall-haskell/releases/download/1.41.2/dhall-yaml-1.2.11-x86_64-Linux.tar.bz2
Downloading dhall from: https://github.com/dhall-lang/dhall-haskell/releases/download/1.41.2/dhall-1.41.2-x8[6](https://github.com/everquoteinc/omni-k8s/runs/7948120634?check_suite_focus=true#step:3:7)_64-Linux.tar.bz2
Downloading dhall-json from: https://github.com/dhall-lang/dhall-haskell/releases/download/1.41.2/dhall-json-1.[7](https://github.com/everquoteinc/omni-k8s/runs/7948120634?check_suite_focus=true#step:3:8).11-x[8](https://github.com/everquoteinc/omni-k8s/runs/7948120634?check_suite_focus=true#step:3:9)6_64-Linux.tar.bz2
Downloading dhall-yaml from: https://github.com/dhall-lang/dhall-haskell/releases/download/1.41.2/dhall-yaml-1.2.11-x86_64-Linux.tar.bz2
bzip2: (stdin) is not a bzip2 file.
tar: Child returned status 2
tar: Error is not recoverable: exiting now
bzip2: (stdin) is not a bzip2 file.
tar: Child returned status 2
tar: Error is not recoverable: exiting now
bzip2: (stdin) is not a bzip2 file.
tar: Child returned status 2
tar: Error is not recoverable: exiting now

Using version 1.41.1 until this is resolved. See https://github.com/marketplace/actions/setup-dhall#with-a-specific-version for details.

Root-cause and fix: https://github.com/dhall-lang/dhall-haskell/issues/2438
I think that this issue can be resolved.

Thanks @K0Te , marking as resolved


itkCenteredEuler3DTransform fails when applying SetComputeZYX(true) after parameters are set

Description
itkCenteredEuler3DTransform is supposed to rotate (around a user specified center) and translate an element in 3D space. When the transformation parameters are set via SetParameters function, the rotation matrix and the offset are calculated following ZXY order (unless previously ZYX order was specified). If SetComputeZYX(true) is applied, the rotation matrix is computed again, but not the offset. The offset in this class depends on the rotation matrix, so when matrix gets updated, the offset should do so as well. If SetComputeZYX(true) is applied before SetParameters function, the rotation matrix and the offset are calculated correctly because when SetParameters is called,  the offset is computed with the coherent rotation matrix (ZYX). If computations are required in ZXY order, there is no problem, as the matrix is calculated this way by default. The problem arises when SetParameters function is called before SetComputeZYX(true).
Steps to Reproduce
In order to test this bug, a point in space was transformed using itkCenteredEuler3DTransform. The transformation parameters consisted only in 3 rotation parameters (no translation was applied) and the rotation center was set to the point that was transformed.
Code:
#include <cstdlib>

#include <itkCenteredEuler3DTransform.h>
#include <itkPoint.h>

int main()
{
	const double dtr = (std::atan(1.0) * 4.0) / 180.0; // cast angles from degrees to radians

	using CenteredEulerTransformType = itk::CenteredEuler3DTransform<double>;
	CenteredEulerTransformType::Pointer centeredtransform = CenteredEulerTransformType::New();
	CenteredEulerTransformType::ParametersType transformParameters = centeredtransform->GetParameters();
	transformParameters[0] = 32;
	transformParameters[1] = -51;
	transformParameters[2] = 17;
	transformParameters[3] = 0;
	transformParameters[4] = 0;
	transformParameters[5] = 0;

	itk::Point<double> rotationCenter; // center of rotation
	rotationCenter[0] = 14.26;
	rotationCenter[1] = -32.819;
	rotationCenter[2] = 48.019;

	CenteredEulerTransformType::ParametersType parameters(9);
	parameters[0] = transformParameters[0] * dtr;
	parameters[1] = transformParameters[1] * dtr;
	parameters[2] = transformParameters[2] * dtr;
	parameters[3] = rotationCenter[0];
	parameters[4] = rotationCenter[1];
	parameters[5] = rotationCenter[2];
	parameters[6] = transformParameters[3];
	parameters[7] = transformParameters[4];
	parameters[8] = transformParameters[5];
	centeredtransform->SetParameters(parameters);
	centeredtransform->SetComputeZYX(true);

	itk::Point<double> testPoint;
	testPoint[0] = rotationCenter[0];
	testPoint[1] = rotationCenter[1];
	testPoint[2] = rotationCenter[2];

	itk::Point<double> outputTestPoint = centeredtransform->TransformPoint(testPoint);

	double computeError = (outputTestPoint[0] - testPoint[0]) * (outputTestPoint[0] - testPoint[0]) +
		(outputTestPoint[1] - testPoint[1]) * (outputTestPoint[1] - testPoint[1]) +
		(outputTestPoint[2] - testPoint[2]) * (outputTestPoint[2] - testPoint[2]);
	computeError = std::sqrt(computeError);

	double errorTolerance = 0.001;

	if (computeError < errorTolerance)
	{
		std::cout << "The point is transformed correctly!!\n";
	}
	else
	{
		std::cout << "There was an error transforming the point!!\n";
	}
}

Expected behavior
The output point should the identical (or really similar) to the input one as the transformation being applied is a rotation through the transformed point itself, with no translation.
Actual behavior
The result of the transformation is a point far from the theoretical one. The reason is that rotation matrix is computed in SetParameters in ZXY order and recomputed in SetComputeZYX in ZYX order. The offset however, is calculated in ZXY order in SetParameters but is not recomputed coherently in SetComputeZYX.
Versions
This error was tested in ITK 4.13 and in ITK 5.0 and both showed the same error.
Environment
I am working in Windows 10 and Visual Studio 2017.
Additional Information
To execute this test correctly, SetComputeZYX should be changed to false, or should be executed before SetParameters.
This could be corrected in two different ways:
1- The offset gets updated when calling SetComputeZYX(true) coherently with the rotation matrix.
2- Make SetComputeZYX update nothing, but user should be "forced" to call this function before calling SetParameters function.

The transforms with the "Centered" moniker are not recommended for usage. They add the transform center as an optimization parameter. The recommend transform to use is the Euler3DTransform, which allows the user to set a fixed parameter for the center of the transform.
@hjmjohnson Do you think some type of documentation or warning should be added to these classes?

@blowekamp I think these should have documentation stating that they are not recommended for usage.  Additionally, I think they should be deprecated, or at least put in an external module.


Error loading over HTTPS with HSTS

code-server version: v1.32.0-245
OS Version: Slackware64 v14.2

Description
INFO  Loading IDE
webpack-internal:///./packages/logger/out/main.js:1  INFO  Starting socket [1/5]...
__webpack_hmr:1 Failed to load resource: the server responded with a status of 404 (Not Found)
webpack-internal:///./packages/logger/out/main.js:1  INFO  Connected to socket
webpack-internal:///./packages/logger/out/main.js:1  INFO  Start workbench
webpack-internal:///./packages/logger/out/main.js:1  ERROR  Failed "Start workbench" duration=948ms
webpack-internal:///./packages/logger/out/main.js:1  ERROR  [UriError]: Scheme contains illegal characters.
webpack-internal:///./packages/logger/out/main.js:1  WARN  Load completed with errors duration=1274ms
The resource https://rkeene.dev:8443/0-17fd0b.bundle.js was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
4__webpack_hmr:1 GET https://rkeene.dev:8443/__webpack_hmr 404 (Not Found)

Steps to Reproduce

Start code-server with a TLS server certificate key
Attach to the session with a web browser (Chrome) via a ".dev" domain (or any other site that is HTTPS-only via HSTS)
Get a blank dark-grey screen
Look at the JS Console
See a bunch of errors
Wish it had worked

I getting this error as well

I found an issue referring to this problem in #141

Fixed!


feat: Use our rust-lightning fork

The fork has support for adding/removing of custom output needed for DLCs to work

bors r+

bors r+


feature Add cloud meta manager skeleton

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


[ci skip] adding user @wildsm

Hi! This is the friendly automated conda-forge-webservice.
I've added user @wildsm as instructed in #4.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #4

@wildsm should have access to this, in-case he needs to merge a new release on conda forge


Uncontrolable

Hello team!
First, I wanted to congratulate you for the work done.
I create this issue because the library "Uncontrolable" has done an update today and changed has changed the import of the component.
Before:
import uncontrollable from 'uncontrollable';
Now:
import { uncontrollable } from 'uncontrollable';
react-big-calendar need to stabilize the dependency or replace the imports of it?

@NguyenJeremy69 Try to reinstall react-big-calendar. The problem with uncontrollable should be fixed.


"Shuffle: Full" groups holes with their nearby entrances

I'm not sure if this is intended or not but "shuffle: full" groups hole with their respective entrances (graveyard hole with church and so on). If it was intended then would it be possible to get a mode that doesn't link them together, I exclusively play full and I would love to randomly get dungeons in the church or lost wood tree.

Currently, all shuffle options below madness shuffle holes and corresponding doors in pairs. This will be configurable in the future when I replace the shuffle categories with flag based configuration options for 0.5.0.


[13.0.x] ISPN-13464 Add CDDL+GPL license to server zip

https://issues.redhat.com/browse/ISPN-13464

Merged, thanks


test generation with numpy.ndarray

Using master at checkout a3829e0ef4f9809e3be500348d0b00430248e4e7
Generating tests for a subclass of numpy.ndarray doesn't seem to work properly.
This might not be possible due to the way numpy.core.multiarray works.

python --version
Python 3.6.3 :: Anaconda, Inc.
python -c "import numpy as np;print(np.version.version)"
1.15.4

sample.tar.gz
If I put a from numpy import array in the enh_ndarray.py, it picks up the array.  I attempted to figure out where in generators/default.py to fix this but could not find it.

Hi Eric. I just took a look at your sample. Am I correct in assuming that you are referring to the generated test case for array_finalize?
I believe the issue here is that Auger currently assumes that a class can be instantiated without an argument. Since you have overwritten new with a required argument (shape), I believe this is the underlying issue. From your sample, it's not obviously clear to me at this point on how we could resolve this.


Change tx status method doc

https://docs.near.org/api/rpc/transactions#transaction-status
In reality, we wait until the block of the last corresponding receipt_id is final, and only then return the result. So the user does not need to check anything.
Return type is FinalExecutionOutcomeView, it's by the definition Final execution outcome of the transaction and all of subsequent the receipts.
I've found this while working on https://github.com/near/nearcore/issues/6837
Maybe I'll change the signature of tx status method or add the new one with more fine-grained way to ask for the result without waiting until everything is final

let me know if we should merge it 👍

I'm not sure this is the case, can you explain a bit more? This RPC call eventually ends up in get_final_transaction_result and there it doesn't actually check the status of each receipt, it just returns the status for all available receipts. In particular it could return FinalExecutionStatus::NotStarted for some.
https://github.com/near/nearcore/blob/315d186b5b792bf942455fcbab0a0a5ddb08a621/chain/chain/src/chain.rs#L3605
cc @jakmeier do you happen to know how this works?

Valid concern.
If it's true, then I want to clarify how EXPERIMENTAL_tx_status works
The doc is ambiguous
https://docs.near.org/api/rpc/transactions#transaction-status-with-receipts
I thought it gives fully final result
The main difference from tx is that it uses get_final_transaction_result_with_receipt underneath. It does not check if the corresponding blocks are finalised.
So, the receipts may not be included into finalised blocks yet, right?
@wacban @jakmeier I've created the proposal for improving tx status method, please leave any comments there
https://github.com/near/nearcore/issues/9542

I am not sure about this TBH. But the description in https://github.com/near/nearcore/issues/6834 suggests we indeed wait for all execution outcomes to be available in the polling loop. So this part of the documentation seems outdated:

In the case of function call transactions, this query will not wait for all receipts generated by this transaction to finish before returning a result. Rather, it will only wait for its return value to finish before returning; which could be a promise.

On the other hand, this seems to be still true:

In addition, tx endpoint does not provide finality guarantees. To make sure that the entire execution is final, it suffices to ensure every block_hash in every outcome is final.

I wrote my exact (but probably flawed) understanding in https://github.com/near/nearcore/issues/9542

this seams to be stalled, any

@gagdiez I see you merged this PR but I'm not sure if it was ready or abandonded. @telezhnaya, the author, did you mean to get it merged?

@gagdiez please roll it back
It's not the time, we still need to wait for the release

@telezhnaya change has been reverted in b9fc109ca582ea1e5a8438438532562969179f17

@telezhnaya  I have also created a new PR #1660 , and left it as draft state so you can let us know when this change is ready to be merged.


Docker config update to match vocabulary

Moves docker-related files into a root docker/ directory, and updates example docker commands to reflect the new structure.
Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

To be honest, I'm going to close this in favor of the monorepo work that's on its way.


Auk ecosystem

Just one question about the file name structure. Also, some pages will probably link somewhere else eventually (e.g. feathers-rest will link to REST/Configuration) but we can change that later. Let's get this started 😄


0RTT

I have a question when dose you support 0rtt in you development on client

Hello, see https://github.com/cloudflare/quiche/issues/683#issuecomment-720582743. Basically we don't have any plan to implement this right now, but it's something we would like to support eventually.


usbrelay: 1.0 -> 1.0.1

Description of changes
Mostly changes related to packaging in other distributions. See https://github.com/darrylb123/usbrelay/compare/1.0...1.0.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

It would be better to split changes into seperate commits telling what they do

It would be better to split changes into seperate commits telling what they do

This would result in 5 oneline commits. I'll just update the commit message explaining each change. The changes are trivial and minor comment in the commit message should be sufficient (IMHO).

Result of nixpkgs-review pr 191851 run on x86_64-linux 1

2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

4 packages built:

python310Packages.usbrelay-py
python39Packages.usbrelay-py
usbrelay
usbrelayd

Thank you!


Beta Home Assistant 0.89.0b2 - policies.ratelimit.QuotaViolation

After installing the BETA of Hass, connecting with toon. I get this issue:
(i removed my personals)
Strange one: i connect to toon with @hotmail.com e-mailadress. And in this log file is my @gmail.com emailadres.. i don't get it..
Error setting up entry eneco-001-xxxx for toon
Traceback (most recent call last):
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 175, in _get_agreements
for agreement in agreements]
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 175, in
for agreement in agreements]
AttributeError: 'str' object has no attribute 'get'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/homeassistant/config_entries.py", line 283, in async_setup
result = await component.async_setup_entry(hass, self)
File "/usr/local/lib/python3.7/site-packages/homeassistant/components/toon/init.py", line 56, in async_setup_entry
display_common_name=entry.data[CONF_DISPLAY]))
File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 106, in init
self._authenticate()
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 153, in _authenticate
self._get_agreements()
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 178, in _get_agreements
raise AgreementsRetrievalError(response.text)
toonapilib.toonapilibexceptions.AgreementsRetrievalError: {"fault":{"faultstring":"Rate limit quota violation. Quota limit  exceeded. Identifier : xxx@gmail.com","detail":{"errorcode":"policies.ratelimit.QuotaViolation"}}}

As you can see from the last message, you are in quota violation with the service. Not sure how you get that, never happened to me. As for the email issue, they is indeed strange. Can you please try the library out of home assistant context and report back?

there is a hidden folder in you configure folder. In that folder is  a file that is called config_entries. (Mary something like that)
The data stored in that place is used for this component.

Can you please try the library out of home assistant context and report back?

How does it works? I don't know what to do

You can follow installation instructions and usage from https://toonapilib.readthedocs.io/en/latest

there is a hidden folder in you configure folder. In that folder is a file that is called config_entries. (Mary something like that)
The data stored in that place is used for this component.

In this file is the right username (@hotmail.com) what i use to log on to my toon/mijn eneco.

do you have some leftovers in your configuration.yaml
only this is needed. for the reworked component
toon:
    consumer_key: API_CONSUMER_KEY
    consumer_secret: API_CONSUMER_SECRET

I have no leftovers of the custom component
After a restart of Hass it works. Very nice. But after  hours the issue is back again.
I did restart Hass at 8:11 AM this morning. And at 9:52 the first error occured.

deps/lib/python3.7/site-packages/toonapilib/toonapilib.py (ERROR) - message first occured at 09:52 and shows up 46 times

Do you have any other components that use an email address for authentication.

it looks like my account for https://developer.toon.eu/ is the problem. That's one is in use for this. All other auth by e-mailadress has an sepparated account.
So the component polls to many with the account https://developer.toon.eu/. Because is works for 1,5 hour. So my settings are good. But after that time period it's blocked..

I have some more errors (not only quota violation); i will post them below
1:
pdate for sensor.current_power_usage fails
Traceback (most recent call last):
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 351, in _get_status_value
output = self.status[value]
File "/config/deps/lib/python3.7/site-packages/cachetools/init.py", line 48, in wrapper
cache[k] = v
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 94, in setitem
self.expire(time)
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 174, in expire
cache_delitem(self, curr.key)
File "/config/deps/lib/python3.7/site-packages/cachetools/cache.py", line 63, in delitem
del self.__data[key]
KeyError: (<toonapilib.toonapilib.Toon object at 0x71f9f2f0>,)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 220, in async_update_ha_state
await self.async_device_update()
File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 348, in async_device_update
await self.hass.async_add_executor_job(self.update)
File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.7/site-packages/homeassistant/components/toon/sensor.py", line 139, in update
section = getattr(self.toon, self.section)
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 371, in power
power = self._get_status_value('powerUsage')
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 353, in _get_status_value
raise IncompleteStatus(self.status)
File "/config/deps/lib/python3.7/site-packages/cachetools/init.py", line 48, in wrapper
cache[k] = v
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 94, in setitem
self.expire(time)
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 174, in expire
cache_delitem(self, curr.key)
File "/config/deps/lib/python3.7/site-packages/cachetools/cache.py", line 63, in delitem
del self.__data[key]
KeyError: (<toonapilib.toonapilib.Toon object at 0x71f9f2f0>,)

Thu Mar 07 2019 16:46:37 GMT+0100 (Midden-Europese standaardtijd)
Update for sensor.solar_production_to_grid fails
Traceback (most recent call last):
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 351, in _get_status_value
output = self.status[value]
File "/config/deps/lib/python3.7/site-packages/cachetools/init.py", line 48, in wrapper
cache[k] = v
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 94, in setitem
self.expire(time)
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 174, in expire
cache_delitem(self, curr.key)
File "/config/deps/lib/python3.7/site-packages/cachetools/cache.py", line 63, in delitem
del self.__data[key]
KeyError: (<toonapilib.toonapilib.Toon object at 0x71f9f2f0>,)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 220, in async_update_ha_state
await self.async_device_update()
File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 348, in async_device_update
await self.hass.async_add_executor_job(self.update)
File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.7/site-packages/homeassistant/components/toon/sensor.py", line 139, in update
section = getattr(self.toon, self.section)
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 385, in solar
power = self._get_status_value('powerUsage')
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 353, in _get_status_value
raise IncompleteStatus(self.status)
File "/config/deps/lib/python3.7/site-packages/cachetools/init.py", line 48, in wrapper
cache[k] = v
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 94, in setitem
self.expire(time)
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 174, in expire
cache_delitem(self, curr.key)
File "/config/deps/lib/python3.7/site-packages/cachetools/cache.py", line 63, in delitem
del self.__data[key]
KeyError: (<toonapilib.toonapilib.Toon object at 0x71f9f2f0>,)

Thu Mar 07 2019 16:46:32 GMT+0100 (Midden-Europese standaardtijd)
Update for sensor.power_cost_today fails
Traceback (most recent call last):
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 351, in _get_status_value
output = self.status[value]
File "/config/deps/lib/python3.7/site-packages/cachetools/init.py", line 48, in wrapper
cache[k] = v
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 94, in setitem
self.expire(time)
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 174, in expire
cache_delitem(self, curr.key)
File "/config/deps/lib/python3.7/site-packages/cachetools/cache.py", line 63, in delitem
del self.__data[key]
KeyError: (<toonapilib.toonapilib.Toon object at 0x71f9f2f0>,)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 220, in async_update_ha_state
await self.async_device_update()
File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 348, in async_device_update
await self.hass.async_add_executor_job(self.update)
File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.7/site-packages/homeassistant/components/toon/sensor.py", line 139, in update
section = getattr(self.toon, self.section)
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 371, in power
power = self._get_status_value('powerUsage')
File "/config/deps/lib/python3.7/site-packages/toonapilib/toonapilib.py", line 353, in _get_status_value
raise IncompleteStatus(self.status)
File "/config/deps/lib/python3.7/site-packages/cachetools/init.py", line 48, in wrapper
cache[k] = v
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 94, in setitem
self.expire(time)
File "/config/deps/lib/python3.7/site-packages/cachetools/ttl.py", line 174, in expire
cache_delitem(self, curr.key)
File "/config/deps/lib/python3.7/site-packages/cachetools/cache.py", line 63, in delitem
del self.__data[key]
KeyError: (<toonapilib.toonapilib.Toon object at 0x71f9f2f0>,)

@rikmaris are you now using HA: 0.89 or still using a beta version.
I can not reproduce these issues.

My https://developer.toon.eu/ account is different than my Eneco account. the API does not give any email address. these errors are really weird

@rikmaris can you please try out the library as mentioned in the documentation I specified and report back please?

For the last 5-6 months I used ToonHA custom component and today  I updated to 0.89.1 and tried to use the built-in new Toon component, but after few hours I started to get QuotaViolation error.
Rolling back to ToonHA custom component and everything seems back to normal.

I guess you should open an issue on the official component

The same problem on HA  https://github.com/home-assistant/home-assistant/issues/21825

I guess you should open an issue on the official component

This has been done already.
As for the actual ToonHA custom component, it works perfect for my needs.
Thanks to all the contributors.

You can close this issue.
i did remove my integration with Nest and the error didn't occur anymore. Only have the same problem as @yellowonblack . So i will use the custom component.


Multiline log message displayed on a signle line

The problem:
On the commit page, multiline log messages are diplayed on a single line.
On the repo browser page and on the log page, only the first line is shown.
Where there is not enough space, It would be great to show the full message on mouse over in a tooltip and put an icon indicating that the message is truncated.
Gogs: <IP_ADDRESS>4 Beta
Git: 2.1.4
Debian 8

I updated Gogs and it seems that it's solved in the Commit page. Thanks
I leave this issue open for the repo browser page and on the log page showing only the first line.

@MathB thanks your update info!

This should be fixed by master branch.


Hostdb

I'm not 100% sure that this is complete, but I moved all of the hostdb stuff into its own package. I also switched from using an array that you went through in linear time every request to using a tree that only requires log time every request.
It's a weighted binary tree, but has no sorting. The tree helps with the weight, and there's a map to do lookups because we don't really care what order stuff is in, just that it's weighted. There are a few tests to make sure that the tree works alright.

Is a tree necessary? I suppose it depends on how many entries there are, and how frequently the HostDB is queried. I think it's fair to assume that there will be a lot of entries, but queries won't be terribly frequent. Surely the performance boost is negligible unless you're querying more than once every few seconds. Trees require more effort to maintain; there are more pitfalls in their implementation, and I can't imagine it'll be fun to encode/decode them.

Easy to encode and decode, just pull out the entries. It's not consensus or anything, everyone can have trees that look different and it won't cause problems. Especially since they'll all be functionally equivalent anyway.
I just wasn't happy with doing a linear search every time we wanted to pull a random host. Theoretically you're going to be pulling dozens to hundreds of hosts all at once, out of a pool of hopefully thousands. Linear will make that hundreds of thousands of array accesses, which isn't terrible but it's not great either.
Perhaps a bit of over optimization but at this point I've written a decent number of tests and I don't think tree failure is a risk.

I think that I also did it because over break I felt like working with trees. This was perhaps also a mistake, because it might introduce code burden in the future.
It's quite modular though, the new interface model keeps things compartmentalized well. Changing the tree won't affect anything outside of the hostdb package.

True. Interfaces definitely work to our favor here. And linear search is definitely not pretty if it will truly require 100k accesses.
I guess the real issue with encoding/decoding is that you may not want to load the entire HostDB into memory (is this realistic?). Traversing and manipulating a tree on-disk == not fun.

You'd want the whole thing in memory if you're selecting a bunch of items at random. If it becomes cumbersome, we could build the tree out of a random subset of hosts and just ignore the rest.


Update dacid userid module documents

🏷 Type of documentation

[ ] new bid adapter
[ ] update bid adapter
[x] new feature
[ ] text edit only (wording, typos)
[ ] bugfix (code examples)
[ ] new examples

📋 Checklist

[x] Related pull requests in prebid.js or server are linked
[ ] For new adapters check submitting your adapter docs

released with 7.21


addTrafficType/listTrafficTypes fields

ISSUE TYPE

Enhancement Request

COMPONENT NAME

API

CLOUDSTACK VERSION

4.17.2

CONFIGURATION

N/A
OS / ENVIRONMENT

N/A
SUMMARY

Enhance listTrafficTypes or add a new API (getTrafficType?) to return all fields used in addTrafficType.
Currently, there is no API to return fields for terraform to manage this resource.  The various networks labels (eg. kvmnetworklabel) are inaccessible.
STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

I do see network labels set but they aren't documented in ListApis.
{
    "listtraffictypesresponse": {
        "count": 2,
        "traffictype": [
            {
                "id": "0ffa5dd7-12a1-4ac0-b37f-e85a3b90ac9a",
                "traffictype": "Management",
                "physicalnetworkid": "05fcfaee-1504-4f8e-b77a-34669e78372a",
                "kvmnetworklabel": "123"
            },

@poddm to be clear on this; you want the request parameters from https://cloudstack.apache.org/api/apidocs-4.18/apis/addTrafficType.html to be added to the respons parameters of listTrafficTypes ?

@poddm to be clear on this; you want the request parameters from https://cloudstack.apache.org/api/apidocs-4.18/apis/addTrafficType.html to be added to the respons parameters of listTrafficTypes ?

Yup -

To make it clear, the list API current returns this:
> list traffictypes physicalnetworkid=6a20338e-f16f-4333-a96f-2d110888d016
{
  "count": 2,
  "traffictype": [
    {
      "id": "8d785d45-c198-45b7-a857-1bddccb6e3bf",
      "kvmnetworklabel": "cloudbr0",
      "physicalnetworkid": "6a20338e-f16f-4333-a96f-2d110888d016",
      "traffictype": "Guest"
    },
    {
      "id": "9f6bf8c0-f834-46e6-9edf-bdeb22e00629",
      "kvmnetworklabel": "cloudbr0",
      "physicalnetworkid": "6a20338e-f16f-4333-a96f-2d110888d016",
      "traffictype": "Public"
    }
  ]
}

The issue/task is to add the following fields in response of the above API (that are request parameters of the add API https://cloudstack.apache.org/api/apidocs-4.18/apis/addTrafficType.html)
vlan | The VLAN id to be used for Management traffic by VMware host | false
isolationmethod | Used if physical network has multiple isolation types and traffic type is public. Choose which isolation method. Valid options currently 'vlan' or 'vxlan', defaults to 'vlan'. | false
hypervnetworklabel | The network name label of the physical device dedicated to this traffic on a Hyperv host | false
kvmnetworklabel | The network name label of the physical device dedicated to this traffic on a KVM host | false
ovm3networklabel | The network name of the physical device dedicated to this traffic on an OVM3 host | false
vmwarenetworklabel | The network name label of the physical device dedicated to this traffic on a VMware host | false
xennetworklabel

Ultimately, we would like to manage more of cloudstack with terraform.  The mismatch between addTrafficType and listTrafficType is preventing me from enhancing the terraform provider.

@rohityadavcloud taking this up.

@DaanHoogland I see that the 14.8.2 milestone is added for this enhancement. Does this have any bearing on the base branch or should I go ahead and make the changes against main?

@DaanHoogland I see that the 14.8.2 milestone is added for this enhancement. Does this have any bearing on the base branch or should I develop against main?

It is mostly your choice, but in case of new features we usually do main and in case of bug fixes/improvements that don't involve DB changes we usually take the latest release branch (or an older one if applicable). I this case you could even develop against 4.17 as that is what the user reports, and we can after development merge the fix forward. One thing to consider there is; the older the branch the bigger the conflict resolution effort will be.
Just tell us and I can adjust the milestone accordingly.


fix: Update kms policy for root user

KMS policies has its own permissions which allows specific users to take certain actions. These permissions override regular IAM permissions and therefore need to be configured correctly during creation. This change allows the root user (as well as other users assigned our kmsAdmin role) to modify/delete kms keys and successfully clean up the environment.
Due to the way AWS wires its permission sets, this config change is required so that when an IAM user is granted an kmsAdmin role, it will be able to assume kms* policies instead of the limited policies previously specified.

Nice, this should prevent orphaned keys. Any docs we should update to let users know that roles with kms perms in the same account will have access to manage these kms keys?


[21.11] Linux 4.4 removal

Description of changes
Backport of #159237.
cc @ajs124 @jonringer @vcunat @tomberek

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I wonder if it's worth backporting the config cleanup.

Already caused the first conflict, so I dropped the commit entirely. Waiting for eval and I'd merge then.


Bug: Incorrect Hex to Binary conversions beyond 6 bytes

Conversions of all Hex characters fail after the first 6 bytes, and are left as all zeros.
Conversion of the following selections:
f1
f1f1
f1f1f1
f1f1f1f1
f1f1f1f1f1
f1f1f1f1f1f1
f1f1f1f1f1f1f1
f1f1f1f1f1f1f1f1
f1f1f1f1f1f1f1f1f1
f1f1f1f1f1f1f1f1f1f1

Gets converted to:
11110001
1111000111110001
111100011111000111110001
11110001111100011111000111110001
1111000111110001111100011111000111110001
111100011111000111110001111100011111000111110001
11110001111100011111000111110001111100011111000111110000
1111000111110001111100011111000111110001111100011111000000000000
111100011111000111110001111100011111000111110001111100000000000000000000
11110001111100011111000111110001111100011111000111110000000000000000000000000000

Thanks for pointing this out. Like I mentioned on the feature request, will probably be a while until I get to this, but I'll keep it in mind. Feel free to submit a PR.


Fixed SplitArrayField.has_changed() for empty values.

django.contrib.postgres.forms.SplitArrayField.has_changed() returns True when initial is empty list and data is list of empty strings. This is a problem when a form is submitted with input fields left blank - resulting in e.g. ["", "",] (passed to has_changed() and evaluated as True instead of False). I believe the issue I'm describing should be more clear from the written tests.
Note that this bug in has_changed() method causes issues with FormSets which fail to correctly validate empty forms (in cases where SplitArrayField is used).
The issue is similar to https://github.com/django/django/pull/9520

I updated the commit (check the diff) as I realized the behavior I implemented only makes sense when using remove_trailing_nulls=True. See https://docs.djangoproject.com/en/2.2/ref/contrib/postgres/forms/#django.contrib.postgres.forms.SplitArrayField.remove_trailing_nulls
I'm not sure what makes sense in case remove_trailing_nulls=False, probably the default behavior.

Fixed. Also note https://github.com/django/django/pull/11970/commits/5167db50ba48113d010944a7cfde5ab8b433afa7
I added assertions how the SplitArrayField behaves in case remove_trailing_nulls=False. Which is kind of weird behaviour, not sure it's correctly handled.

@paveldedik Thanks again :+1: I pushed minor edits and added tests for validation error in has_changed().
Welcome aboard :boat:


Linux will not start after installing. Three other users have had this problem: "Fatal server error: (EE) AddScreen/ScreenInit failed for driver 1"

Please paste the output of the following command here:
EGL_MESA_drm_image required.
(EE)
Fatal server error:
(EE) AddScreen/ScreenInit failed for driver 1
(EE)
(EE)
Please consult the The X.Org Foundation support
at http://wiki.x.org
for help.
(EE) Please also check the log file at "/tmp/Xorg.crouton.1.log" for additional information.
(EE)
(EE) Server terminated with error (1). Closing log file.

Please describe your issue:
After installing, kde will not start.
Multiple users have had similar issues.
https://github.com/dnschneid/crouton/issues/3235
https://github.com/dnschneid/crouton/issues/3276
https://github.com/dnschneid/crouton/issues/3213
If known, describe the steps to reproduce the issue:
After successfully installing kde and setting up a username and password, I start kde, the screen goes black, and it returns to chrome os with an error message. This has happened for xfce as wellTh
Thank you!

Okay I've looked into it some more, and I've found some possible solutions that I have yet to try but have worked for others.
Solution #1
The reason it doesn't work is because the method 'xorg' can't get the screen to move over to Linux.
Fortunately, there's the 'xiwi' method, which lets you open Linux through a browsing tab or window. It's faster and will (hopefully) work better. So that's cool.
Make sure to get this extension!
Change the downloading script to
sudo sh ~/Downloads/crouton -t xfce,xorg,xiwi
Then when you go to start it up, you have more options to open Linux that could work.
sudo startxfce4 (that will launch in a separate screen via 'xorg', the default)
sudo startxfce4 -X xiwi (that will launch in a window via 'xiwi')
sudo startxfce4 -X xiwi-fullscreen (that will launch fullscreen via 'xiwi')
sudo startxfce4 -X xiwi-tab (that will launch in a browsing tab)
Thanks to https://github.com/DennisLfromGA
Solution #2
This is voodoo magic to me, but here you go.

OK.
Download this file to your "Downloads" directory in ChromeOS:
20-armsoc.txt
In crosh window, run shell command to launch bash-like shell
Rename downloaded file from .txt to conf:
cd ~/Downloads
mv 20-armsoc{.txt,.conf}

Login into chroot without X11:
sudo enter-chroot -n precise
Move that file into proper place and flush the RAM cache:
sudo mv ~/Downloads/20-armsoc.conf /usr/share/X11/xorg.conf.d/
sync

Logout chroot with "Ctrl + d" or run exit command
Re-login into chroot with X11/freon:
sudo startxfce4
That's all, maybe...
Regards.

Thanks to
https://github.com/tista500

For method 1, do I have to funny uninstall the existing files and stuff? and if so, how do I do so?

I've done method 1. Now I have a new problem altogether. I'm getting this:

I've looked for a way to solve this, but didn't find any useful articles, except one using he bootstrap and apt-get; both of which didn't work.

Okay, so finally figured out how to get crouton to work. So when you download your system, don't even include "xorg" in your list of targets. It's evil. Just put extension and xiwi. (By targets I mean the things in the download scripts after "-t")

So like:
sudo sh ~/Downloads/crouton -t xfce, xiwi, extension
The extension has yet to fail me. :-)
Make the sure the extension it turned on btw.

Thanks. I got it done.
Sorry I didn't reply sooner.

No prob glad it worked. 👍

This solution does not seem to work for Samsung ARM-based Chromebooks. Further tutorials will help a lot. It is possible(I did it somehow) but not easy.

I just installed crouton on a ARM Samsung Series 3 Chromebook and was just as puzzled as everyone else at xorg not starting, with failed to load driver: exynos.
I first tried to chroot and run sudo apt-get install xserver-xorg-video-armsoc-exynos but apt complained about unresolved dependencies and I went looking for a quicker solution.
Downloading and placing 20-armsoc.conf into /usr/share/X11/xorg.conf.d/ according to @runner18's instructions fully resolved this hurdle.


Action hanging when deploying function

When using the functions action V1 to deploy to my production function on windows, the action hangs when spinning up the function. Logs here:
##[Initialize]
##[ValidateParameter]
##[ValidateAzureResource]
Using RBAC for authentication, GitHub Action will perform resource validation.
Sucessfully acquired site configs from function app!
Detected function app sku: Consumption
Sucessfully acquired app settings from function app (RBAC)!
Detected function app language: Dotnet
##[PreparePublishContent]
Will archive . into d:\a_temp\temp_web_package_6845877634426281.zip as function app content
Will use api/zipdeploy to deploy (rbac authentication)
##[PublishContent]
Waiting for function app to spin up after app settings change.
I've let it run for in excess of five minutes with no sign of it deploying the zipped files.

+1
https://github.com/atbagga/SampleFunctionAppJava/runs/457627394?check_suite_focus=true

Hi @Rocinante89,
Thanks for reporting the issue, is this a Linux Consumption function app or a Windows Consumption function app?
For now, to mitigate the issue, you can set SCM_DO_BUILD_DURING_DEPLOYMENT = false and ENABLE_ORYX_BUILD = false in your app settings. This will prevent scm site from duplicating the build process.

@Hazhzeng its a Windows Consumption Function app.
Thanks for responding. I’ll give those steps a shot.

Do I set those in env of my action yaml? I did that and my build still hung

Hi @tpluscode,
No, the app settings can be set in portal -> function app -> configuration -> application settings.

No luck. I set those app settings in portal and the build hangs all the same 😞

I'm seeing the same behavior with a dedicated app service plan:

##[Initialize]
##[ValidateParameter]
##[ValidateAzureResource]
Using RBAC for authentication, GitHub Action will perform resource validation.
Sucessfully acquired site configs from function app!
Detected function app sku: Dedicated
Sucessfully acquired app settings from function app (RBAC)!
Detected function app language: Dotnet
##[PreparePublishContent]
Will archive functionbuild into /home/runner/work/_temp/temp_web_package_9327459972894883.zip as function app content
Will use api/zipdeploy to deploy (rbac authentication)
##[PublishContent]
Waiting for function app to spin up after app settings change.
##[error]The operation was canceled.

And for what it's worth, the word "successfully" is misspelled in the output.

Same issue, setting SCM_DO_BUILD_DURING_DEPLOYMENT and ENABLE_ORYX_BUILD to false didn't help. Does anyone know a  workaround to deploy?

Deleting the function and recreating it fixed it. (The flags were also set to false)

We're experiencing the same issue since yesterday, running Linux Function (Node) on the Consumption plan.
Run Azure/functions-action@v1
##[Initialize]
##[ValidateParameter]
##[ValidateAzureResource]
Using RBAC for authentication, GitHub Action will perform resource validation.
Sucessfully acquired site configs from function app!
Detected function app sku: Consumption
Sucessfully acquired app settings from function app (RBAC)!
Detected function app language: Node
##[PreparePublishContent]
Will archive . into /home/runner/work/_temp/temp_web_package_33096149634728955.zip as function app content
Will use WEBSITE_RUN_FROM_PACKAGE to deploy
##[PublishContent]
Waiting for function app to spin up after app settings change.

I recreated my app and the deployment succeeded the first time but then gets stuck on subsequent runs

FWIW I replaced the functions step with Azure/webapps-deploy@v2 and I think it deploys without issues.

I added the SCM_DO_BUILD_DURING_DEPLOYMENT = false and ENABLE_ORYX_BUILD = false in local.settings.json, restarted the app and all was good


[Ionic 2] Tapping on disabled/readonly ion-input scrolls without showing the keyboard. Gif attached.

Not sure if this is a bug.
Short description of the problem:
I have a profile page where fields are setup as readonly & disabled for now but will be editable in the future.
What behavior are you expecting?
Tapping on the disabled input fields adds scrolling.

Run ionic info from terminal/cmd prompt: (paste output below)
Your system information:
Cordova CLI: 6.3.1
Ionic Framework Version: 2.0.0-rc.1
Ionic CLI Version: 2.1.0
Ionic App Lib Version: 2.1.0-beta.1
ios-deploy version: 1.9.0
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v6.7.0
Xcode version: Xcode 8.0 Build version 8A218a

Hello, thanks for using Ionic! Does this issue also happen on an Android device running the same app? Also, if you add this:
IonicModule.forRoot(MyApp, {
      scrollAssist: false
}) ;
``` to your `app.module.ts` file does it still happen? Thanks!

Sorry for the late response. The scrollAssist seems to have done the trick on ionic view and emulator at least. I'll test on android and report back soon.
btw what is the difference between scrollAssist and autoFocusAssist?

@adamdbradley just tested this with the scroll branch and it seems to still be an issue.

It doesn't seem that scrollAssist or autoFocusAssist are listed in the config API docs. Are these referred to somewhere else in the documentation?

Just updated to RC 5 - I have a readonly input and this issue is still present. Ion-scroll is adding margin-bottom to make room for the keyboard - but none appears.

@haydenJogs92 Same here! This is also a bug.
I tried to use a readonly input field and bind the (click) handler on it. When I tap the field on emulator, the screen gets scrolled a bit and nothing happens. I have to click a second time in order to trigger the click event.
I also tried disabled=true, it worked. But I don't want to gray out the text displayed in the input field. I think for now, I've got to set it as disabled and use extra CSS styles to change the text color.

This seems to be still an issue, at least for me.
Adding this:
IonicModule.forRoot(MyApp, {
scrollAssist: false
}) ;

Disables it for all Inputs, but I want this to happen only for "readonly".
Ionic info:
    @ionic/cli-plugin-proxy : 1.4.12
    @ionic/cli-utils        : 1.13.0
    ionic (Ionic CLI)       : 3.13.0

global packages:

    cordova (Cordova CLI) : 7.1.0

local packages:

    @ionic/app-scripts : 3.0.0
    Cordova Platforms  : android 6.3.0 ios
    Ionic Framework    : ionic-angular 3.7.1

System:

    Node : v6.11.3
    npm  : 3.10.10
    OS   : Windows 10

Misc:

    backend : pro


KOGITO-2099: Generate a SVG diagram automatically on each BPMN/DMN diagrams save

To make the use of VSCode more friendly for RHPAM users (especially on the integration with Kie Server), the idea is to provide a configurable way to generate the SVG on each save of the BPMN/DMN diagram and provide a similar capability of business central.
The following commands were added:

"kogito.dmn.runOnSave": "extension.kogito.silentlyGenerateSvgDmn",
"kogito.bpmn.runOnSave": "extension.kogito.silentlyGenerateSvgBpmn"

Whenever the user config those commands, we will auto-generate (silently) the SVG for BPMN and DMN diagrams. (PMML extension was not affected).
For vscode-extension-pack-kogito-kie-editors, I've configured the respective parameters as default.
Feature Video

@ederign I bit confused what is the default value for kogito.bpmn.runOnSave and kogito.bpmn.runOnSave. In the VS code settings, there is extension.kogito.silentlyGenerateSvg but in the video there is extension.kogito.generateSVGOnSaveBpmn and extension.kogito.generateSVGOnSaveDmn.
Do I understand correctly that for both kogito.bpmn.runOnSave and kogito.bpmn.runOnSave if I have empty string "" then nothing is executed and if I have extension.kogito.silentlyGenerateSvg then the SVG is generated silently after each save?

Hi @tomasdavidorg, thanks for the review, replies:

if I have empty string "" then nothing is executed after save

On the BPMN and DMN extension yes. Nothing should also happen also in the absence of the property.
On PMML extension, nothing should be changed.

if I have extension.kogito.silentlyGenerateSvg then the SVG is generated silently after each save?
For DMN, you need to define the key: kogito.dmn.runOnSave=extension.kogito.silentlyGenerateSvg
For BPMN, kogito.bpmn.runOnSave=extension.kogito.silentlyGenerateSvg

if I have extension.kogito.getPreviewSvg then the SVG is generated after each save and notification is displayed?

That is correct.
Also, on our 'test' extension (packages/vscode-extension-pack-kogito-kie-editors/), I've configured the parameters to be default. So on each save, we should have the svg generated for both bpmn and dmn editor.s

IIRC DMN did not have the SVG generated on save; it was only BPMN.
We had to make a change on DMN to prevent it from happening as it was not desired.
@karreiro can you please confirm/deny/advise?

Hi @manstis, IIUC the SVG mechanism exists in the DMN side as well to support this kind of use case:

Am I missing something?

@karreiro no, no.. I am just out of date.
I remembered that in Business Central we had to disable the auto-SVG generation.
Times have obviously moved on.


Extension causing significant performance hit

I've noticed a significant hit to web page loading performance on Firefox when I have this extension enabled, versus when it's disable. I'm not sure if anyone else has reported in about performance issues, or if its a known problem?

It's not known problem. which version of Firefox are you using? Also which OS?

Firefox 66.0.5
Mac OS 10.14.4
Extension version 0.16
Do you have any tips for how to debug where the exact performance hit may be coming from?

I am not sure how to help. A few months ago I tried to optimize it so I did:

updating progress in not less than 250ms, so at most 4 updates per second.
not moving progress back as the new elements are requested.
moved from gradients to updating a block element width.

There is one thing that could be CPU consuming: transitions are animated. You can switch off the animation from the add-on preferences. Just change the "Smooth" to "No". Is this improving the load-times on your side?

@luben I just disabled the smooth rendering and it seems to have improved performance by a lot. Feel free to close this issue. I will suggest that perhaps the default for this option should be "No". Users can opt-in if they feel like their computer is performance enough to handle smooth rendering. Otherwise, I worry that people will choose to just uninstall the extension due to the issue, rather than report it and have a constructive discussion like the one here.
Thank you for the help.

Yes, I agree that disabling the smooth anymation may be better default.

v0.18 changes the default to disabled


DOC: organize stringmethods in what's new

Added summarized section to the release note based on the discussion in  #9386

@sinhrks Thanks! But, you will have to rebase (and probably solve some conflicts after my PR that reorganized the whatsnew file a bit). But you can put the section under "New features" (eg just before 'other enhancements')

Sure, rebased.

@sinhrks Merged this, thanks! I will look into the docstring linking thing. Ping #9599


[GLUTEN-6887][VL] Daily Update Velox Version (2024_11_01)

Upstream Velox's New Commits:
e6af8b666 by Richard Barnes, Remove unused-variable in velox/buffer/tests/BufferTest.cpp (11398)
e03999f0d by Rong Ma, Supports serializing a range of rows for CompactRow (10714)
bacd769bc by Jialiang Tan, Fix fast abort condition in global arbitration (11382)
c89d8d634 by Jialiang Tan, Fix flaky test MockSharedArbitrationTest.arbitrateBySelfMemoryReclaim (11397)
1e7a82f03 by Bikramjeet Vig, Fix flakiness in TraceUtilTest.getTaskIds (11394)
5cbba0979 by Guilherme Kunigami, add opaque type support to hive type serde (11253)
0dc6eb8ce by Bikramjeet Vig, Normalize NaNs in to_ieee754_32 and to_ieee754_64 (11393)
7c93ebad3 by Bikramjeet Vig, Add ability to verify expression fuzzer runs on a subset of rows (11267)

@marin-ma how much perf gain on sort based shuffle after this PR is merged
e03999f0d by Rong Ma, Supports serializing a range of rows for CompactRow (10714)


Add ability to search by admin note when adding a question to a program

Description
Admin note should be a field admins can search by when adding a question to a program
Release notes
The title of the pull request will be used as the default release notes description. If more detail is needed to communicate to partners the scope of the PR's changes, use this release notes section.
Checklist
General

[ ] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)

User visible changes

[ ] Wrote browser tests using the validateAccessibility method
[ ] Manually tested at 200% size
[ ] Manually evaluated tab order

Issue(s) this completes
Fixes #4325

Please clean up PR description


Nick: Watch blashsmm.com

Nick requests the watch of the watch_keyword blashsmm\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

blashsmm\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


DO NOT MERGE: Made the generated ruby code send Grpc errors to gax-ruby.

DO NOT MERGE until gax-ruby/pull/28 has been merged.
This was done because we are removing a dependency to GRPC in a file resolving this gax-ruby issue.

will be good

LGTM


feat(deps): multiselect library as dependency

Closes #3254 .

@deviantony RTM

cc @xAt0mZ for merge


dubbo-spring-boot-starter 不兼容 spring-boot 2.1.1

What's error message?

My test works, however, dubbo-spring-boot-starter 0.2.1 will upgrade Spring Boot 2.1.1.RELEASE


DE: fix 'total' translation

Provisional PR, does not need to be merged or released.

Already merged in #18


Fixing md-progress-circle's README link to Google spec

There was an extra http:// on it

@robertodecurnex can you amend your commit message to be of the form:
chore(progress-circle): fix invalid link in readme ?

done @jelbourn


AMBARI-25159. http.strict-transport-security change does not take affect in 2.7.x.

What changes were proposed in this pull request?
Redundant security request customizer was removed.
How was this patch tested?
Manual testing.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4938/
Test PASSed.


Add missing ShapeStyles

Missing styles:

[x] HierarchicalShapeStyle
[x] Material
[x] AngularGradient
[x] ConicGradient
[x] EllipticalGradient
[x] RadialGradient
[x] ImagePaint
[x] SelectionShapeStyle
[x] SeparatorShapeStyle
[x] TintShapeStyle
[x] ForegroundStyle
[x] BackgroundStyle

Missing modifiers:

[x] opacity
[x] blendMode
[x] shadow

@carson-katri Is this ready to be merged?


Add missing dependency to package.json

Just a minor tweak I made while working on moving client to choo. Seems like package was required but didn't make it in to package.json.

gotcha


Exchange admins can also deploys addin

Exchange admins can also deploy add-in from centralized deployment if this is enabled.

Hi @Rahul973125 Can you upload the image, proposed in this PR, to the repo's media folder. We require all media, that are referenced in our topics, to live in their respective media folders.
Thanks!
CC: @denisebmsft @kwekuako @dstrome

Hi @Rahul973125 Can you upload the image, proposed in this PR, to the repo's media folder. We require all media, that are referenced in our topics, to live in their respective media folders.
Thanks!
CC: @denisebmsft @kwekuako @dstrome

Hi @traya1  can you please help on the steps to access the repro folder.

Hi @Rahul973125 Can you upload the image, proposed in this PR, to the repo's media folder. We require all media, that are referenced in our topics, to live in their respective media folders.
Thanks!
CC: @denisebmsft @kwekuako @dstrome

@traya1  File uploaded could you please have a check. The file name is AAD.png


figure role allowance update

ARIA in HTML is updating to allow the doc-example role on the figure element when it has a child figcaption.  The doc-example role inherits from the figure role, intended to work similarly but exposed as with a role description of "example" rather than "figure".

Thanks, @scottaohara I added doc-example as an allowed role for figure.


What is the use of enum Type defined in Box in label.proto?

I see that enum Type is defined in Box message but there is no field with that type.
What is the use of this enum?
https://github.com/waymo-research/waymo-open-dataset/blob/04152e70f4fe633c2d0d1a7b4b10a6299759faaa/waymo_open_dataset/label.proto#L38-L46

It is used to pass the metrics computation configuration to tell what is the  type of the boxes you are generating. https://github.com/waymo-research/waymo-open-dataset/blob/04152e70f4fe633c2d0d1a7b4b10a6299759faaa/waymo_open_dataset/protos/metrics.proto#L111

You beat me to it; I should have seen this in the first place.


Swappable Site Model

fixes #4

make site model swappable

I didn't take a look at the test failures (for now). You should definitely run tox -e style once to format the code according to black's standards etc.

Well, I didn't either, as they do not concern me right now. No tests have been implemented, yet.
As soon as we come to an overall conclusion, I will implement the required tests.

the failing tests resolve to feincms3 ckeditor.
can you fix these so that the non-existing tests for this will yield a positive result?

I have released feincms3==0.94.1 which works with Python < 3.8 again and'll trigger a new build.

:= is Python 3.8+

Yes, I've fixed this a few days ago in feincms3 but I haven't uploaded a patch release containing this fix.

Yes, I've fixed this a few days ago in feincms3 but I haven't uploaded a patch release containing this fix.

I was just about to adjust setup.cfg to make sure that python>=3.8 is required.

Okay, fixed the issue with the site foreign key being added to string instead of the sender. Eliminated duplicate code.
Added FEINCMS3_SITES_SITE_MODEL to testapp settings as django's orm will check that key on start.

removed the extraneous init module from root (was added by pycharm, argh)
removed the duplicate code.

Nice, thanks!


Fix RequestContext propagation and callback invocation

Motivation:
We currently use RequestContext.push(..) to propagate a RequestContext
to a non-I/O thread or to replace the current context with another.
When propagating a RequestContext a non-I/O thread, the onEnter and
onExit callbacks must be invoked, while they should not be invoked when
replacing a context.
RequestContext.push(...) currently never invokes the callbacks, which
can lead to inconsistent state transition between threads.
Modifications:

Modify RequestContext.push() so that the caller can choose to call the
callbacks, where the default behavior is to call the callback

Add RequestContext.invokeOnEnter/ExitCallbacks()

Reorganize the type hierarchy of RequestContext and its subtypes

Split AbstractRequestContext into:

AbstractRequestContext
NonWrappingRequestContext extends AbstractRequestContext
Default*RequestContext extend NonWrappingRequestContext

Add RequestContextWrapper that extend AbstractRequestContext

Rewrite ServiceRequestContextWrapper using RequestContextWrapper
Add ClientRequestContextWrapper

Fix a bug where THttpService does not push its context when calling
its delegate such as ThriftCallService
Fix a bug where ThriftCallService pushes its context unnecessarily
Fix a bug where AbstractCompositeService does not push its context
wrapper
Add HttpTracingIntegrationTest which ensures that Zipkin/Brave's
thread-local variables are transferred correctly.
Miscellaneous

Unignore RequestContextTest.contextAwareEventExecutor()

Result:

RequestContext propagation works as expected
Call tracing of nested calls works as expected

/cc @anuraaga @synk

LGTM

Current coverage is 64.30% (diff: 60.37%)

Merging #220 into master will increase coverage by 0.77%

@@             master       #220   diff @@
==========================================
  Files           274        277     +3
  Lines         10523      10574    +51
  Methods           0          0
  Messages          0          0
  Branches       1520       1525     +5
==========================================
+ Hits           6686       6800   +114
+ Misses         3099       3038    -61
+ Partials        738        736     -2

Powered by Codecov. Last update 21688e0...2bde003

LGTM~

I checked the tests, and LGTM

Thank's for reviewing @anuraaga @kojilin and @synk


defaultSelectedItems for MultiRange in react-instantsearch

Hi,
I messaged on gitter regarding this.
Pasting all the content.
I want to predefine the numeric refinements in MultiRange just like defaultSelectedItems in RefinementList
const VirtualRefinementList = RefinementList.connect(() => null);

{/*We create default refinements like this*/}
<VirtualRefinementList attributeName="category_slug" defaultSelectedItems={[“mobiles"]} />

{/* how to create default numeric refinements
 pseudo code… or it can be a VirtualMultiRange
*/}
<VirtualRefinementList attributeName=“price" defaultSelectedItems={[>15000]} />

Really need help with this. @vvo

@harshmaur can you try: defaultSelectedItems=":50000"?
This is currently a #fail of our API, too hard to understand and not documented.
Sorry for late reply.

Hi @vvo Thanks you for reply. I will test it out and get back to you. Can you tell me how I would do >= or <= with this syntax?

Using <VirtualRefinementList attributeName="price" defaultSelectedItems=":50000" /> gives error getSelectedItems(...).map is not a function(…)

Hello @harshmaur, if you want to have a default selected range using the MultiRange, you could try with defaultSelectedItem instead of defaultSelectedItems (little typo here, sorry). This syntax works for a MultiRange, not a RefinementList. The RefinementList expects an array of default items.
If I look to your example you would have something like:
<VirtualMultiRange attributeName="price" defaultSelectedItem="150000:" />
Also, the defaultSelectedItem you choose should match with one of the item manually declared using the items props.
Full example with a MultiRange:
<MultiRange attributeName="price"
                items={[
                  {end: 10, label: '<$10'},
                  {start: 10, end: 100, label: '$10-$100'},
                  {start: 100, end: 500, label: '$100-$500'},
                  {start: 500, label: '>$500'},
                ]}
                defaultSelectedItem="500:"
/>

If I wanted to select the "<10" by default, I would have written: ":10"
Definitely our doc should be improved here.
Let me know if it works better.

Got it works now!! You can close the issue if you want to.

Let's close this, we will need to get back at how we provide defaultRefinements in a consistent way still.


s/MiniTest::Unit::TestCase/MiniTest::Test/g

I've been getting the following deprecation warning:
MiniTest::Unit::TestCase is now Minitest::Test. From hamming_test.rb:4:in `<main>'

So I've run
grep -rl MiniTest::Unit::TestCase . | sort | uniq | xargs sed -i s/MiniTest::Unit::TestCase/MiniTest::Test/g

I have not tested all of these -- I ran a couple by hand but make no promises.
If this causes compatibility problems, is there a way to suppress the deprecation warning?

This is tricky. When we launched exercism, the stable ruby included MiniTest 4.x, and if we require Minitest 5.x then we need to explain gem install in the setup.
Also, in order to not get the deprecation warning, we'll need to say gem 'minitest', '~> 5.0' before we require anything, in case people have an older ruby with a newer minitest.
Since the most recent ruby now ships with a recent Minitest, I'm open to making the change, but I'd like to make sure that we get the documentation and everything fixed as well.

I've decided to go ahead and switch to using the recent Minitest.
Would you rebase onto master, please?
Also, the new minitest syntax is Minitest::Test, not MiniTest::Test.

Done -- sorry for the delay. I used this command:
grep -rl MiniTest::Unit::TestCase . | sort | uniq | xargs sed -i s/MiniTest::Unit::TestCase/Minitest::Test/g

I've tested a few manually, and they run fine (and without deprecation warnings! :tada:), but I haven't done anything exhaustive.
I've also completely removed the caveat about testing libraries from the README.

Sweet, thanks!


D072896 ack fix

this changes address 2 things:

slack messages changed in 2 ways:

"*" to were not covered by the regex to determine the alertname which causes empty filter for PD incident and with that no ack
the interactive message seems to be changed in the way that we need to access the "attachment" section (before: message.OriginalMessage.Text / now:  message.OriginalMessage.Attachments[0].Text )

pagerduty incident object had changed causing "unmarshal array into Go value of type pagerduty.Incident"

We need to fix this quickly - thx for checking.

My main concern is that the PagerDuty/go-pagerduty library has/had some issues which are fixed on our sapcc/go-pagerduty fork (see commits).
Not sure they made it upstream meanwhile. Unfortunately, we cannot switch to upstream before. Did you check @geisslet?

It's the latest release: https://github.com/PagerDuty/go-pagerduty/releases/tag/v1.1.2
Isn't that enough?

We need to stick with github.com/sapcc/go-pagerduty until the fixes are upstream.

the lib changed the way how it's done, that's why it works now by using object ManageIncidentsOptions instead of object Incident:
old:
c.pagerdutyClient.ManageIncidents(user.Email, []pagerduty.Incident{*incident}
new:
c.pagerdutyClient.ManageIncidents(user.Email,[]pagerduty.ManageIncidentsOptions{incident})
Don't see a blocking point left and guess they won't do your valid changes to upstream :(

This looks good.
One last thing: It appears the the changes to the regex break the tests. You can run them manually via make tests. I added travis support so they are automatically executed for all subsequent PRs.
Could you check @geisslet?

test runs locally successful now.
=== RUN   TestFilterIncidents --- PASS: TestFilterIncidents (0.00s) PASS coverage: 11.4% of statements in ../../../pulsar/...
travis-ci setup seems not complete.


Some compiling errors: "unresolved reference" and "await suspension"

Hi, I correctly replaced the 2 paths in the "CMakeLists.txt" but the build fails for these errors:

Class CameraActivity.kt, line 280. "The 'await' suspension point is inside a critical section"
Class CameraActivity.kt, line 218. "Unresolved reference: maxBy" and "Unresolved reference: it"
Class CameraUtil.kt, line 66. "Unresolved reference: maxBy" and "Unresolved reference: it"

I'm new to Kotlin syntax, how can I solve them?
Thanks in advance

Ok, I solved the 2nd and 3rd error. Initially I replaced the "maxBy" method with "maxByOrNull".
But then I deleted the Android studio project, I reimported it and the maxBy error was solved.
The first error is still here...
I coded a workaround (with the delay() method) but when the app "loses" the first detected face and detects the second one, it crashes

Hi @Mik-el, sorry for the late response but I'm a bit busy..
Anyway, good that you managed to solve issue 2 and 3. Following this answer, you can try to use a Mutex instead of the ReentrantLock, just change this line.
It's been a few years that I'm not anymore into Kotlin/Android development, so I may be not able to fully help you.
Let me know how it goes


[Request] Allow tray icon to display text instead of graph

I find it useful for RAM instead of seeing a graph in system tray to see a number which is GB of RAM used. Would be nice if you could implement this as an option.

I hacked this in a fork, but without a setting: https://github.com/Leroy231/tray-monitor/commits/ram-number/

Hi,
Currently I do not free time for this project,
but I would like to accept this feature (with style option in settings, and graph as default) as PR is case you want upsteam it


// is not accepted as a comment

// is not accpeted as a comment even though the different risc v extensions do accept it.
See here or here

Yes, I agree that this would be very useful


Rename to svelte-presisted-store

Rename package to svelte-presisted-store since it supports session store (not just local storage anymore)

[x] Add deprecation warning to svelte-local-storage-store with instructions
[x] Add bold warning to README with link to new package
[x] Rename package
[x] Publish new package

Resolved


Not able to find the binaries required

I am not able to find those binaries you mentioned in your repo , clipper, preprocessor, databasebuilder,

I am not able to find those binaries you mentioned in your repo , clipper, preprocessor, databasebuilder,too

There is an external dependency on C++ binaries to run core server functionality. I unfortunately also do not have access to that code base anymore after having changed jobs.


Make igniter an only: [:dev, :test] dependency by default

We originally decided not to go this route because of the additional friction imposed during installation. However, project generators like mix igniter.new and mix phx.new can add :igniter automatically as a dependency.
Additionally a reason I didn't want to do this was because the process of installing packages that don't have an optional dependency on igniter would then "break", but we have resolved this issue via automatically detecting and patching dependencies with conflicting only options.

With this in place, I think we should do the following:

adjust igniter.new to do a only: [:dev, :test] on the added igniter dependency.
change all packages that use igniter to make it an optional: true dependency.

This prevents any igniter code from shipping to production environments (which isn't really dangerous to do, just annoying), and will make people in general happier with including igniter as a dependency of their projects.
@zachallaun thoughts?

This is actually a very easy change to make in igniter itself, we just change the generated dep to optional. The only place it is a bit more complicated is on the packages that use igniter which have to communicate to users that they must first install igniter. When generating tasks, we would change the --optional to be the default, and use --no-optional to make it required.

We don't need only: [:dev, :test] for #1, just optional: true, but otherwise yes your understanding is correct.
Agreed on the clarity changes you describe there. With that said, mix igniter.gen.task should do that automatically so that it shows in the docs etc. We can also probably write an upgrader for this.

We don't need only: [:dev, :test] for #1, just optional: true, but otherwise yes your understanding is correct.

Gotcha -- optional: true means the dep isn't included in any env unless the end user includes it, in which case it'll be in whatever env they put it in (like [:dev, :test]).

With that said, mix igniter.gen.task should do that automatically so that it shows in the docs etc.

Yes, I'm thinking that the call would be included in the generated moduledoc unless --no-optional is specified.
Another thing we could do is have mix igniter.gen.task default to optional or not based on how Igniter is specified in the library's deps. If it's optional, the default is --optional. If it's not optional, the default is --no-optional. IMO, that'll be a better UX for the vast majority of cases. Otherwise, at least some people will be running the generator and think, "shit, I meant for that to be non-optional" (or whatever the non-default is).

We can also probably write an upgrader for this.

I was thinking about that a bit. Since it's up to the library author to decide whether Igniter is optional, the upgrade path is non-linear. Some will want to switch to optional and then have their tasks automatically converted, while others will want to make Igniter required. Perhaps this belongs in mix igniter.refactor.optional_task [my_lib.my_task] (or something)?

Another thing we could do is have mix igniter.gen.task default to optional or not based on how Igniter is specified in the library's deps. If it's optional, the default is --optional.

Oh, thats clever. 👍

Its also a pretty easy change to make manually, maybe we just let it be manual :D

I'm also totally fine with this. We should update the Igniter.Mix.Task moduledocs to give more examples of the basic "shape" of both optional and non-optional Igniter tasks.

My app was failing with errors about another library.
 2024-11-05T16:58:09.228 app[d8901e2c623528] cdg [info] WARN Reaped child process with pid: 381 and signal: SIGUSR1, core dumped? false
 2024-11-05T16:58:21.189 app[d8901e2c623528] cdg [info] 16:58:21.186 request_id=GAUg_KBGwDy3ofAAAAYB [info] GET /
 2024-11-05T16:58:21.192 app[d8901e2c623528] cdg [info] load JSON for humbleicons icon family<EMAIL_ADDRESS> 2024-11-05T16:58:21.196 app[d8901e2c623528] cdg [info] Logger - error: {removed_failing_handler,disco_log_handler}
 2024-11-05T16:58:21.197 app[d8901e2c623528] cdg [info] 16:58:21.193 request_id=GAUg_KBGwDy3ofAAAAYB [error] Iconify error with icon: "bars": No icon set found at<EMAIL_ADDRESS>for the icon `bars`. Find icon sets at https://icones.js.org
 2024-11-05T16:58:21.197 app[d8901e2c623528] cdg [info] Iconify.icon_error/2 @ (iconify_ex 0.5.3) lib/iconify.ex:765
 2024-11-05T16:58:21.197 app[d8901e2c623528] cdg [info] Iconify.list_json_svgs/3 @ (iconify_ex 0.5.3) lib/iconify.ex:690
 2024-11-05T16:58:21.197 app[d8901e2c623528] cdg [info] Iconify.get_svg/3 @ (iconify_ex 0.5.3) lib/iconify.ex:653
 2024-11-05T16:58:21.197 app[d8901e2c623528] cdg [info] Iconify.svg_as_is/3 @ (iconify_ex 0.5.3) lib/iconify.ex:592
 2024-11-05T16:58:21.197 app[d8901e2c623528] cdg [info] Iconify.do_prepare_icon_css/4 @ (iconify_ex 0.5.3) lib/iconify.ex:553
 2024-11-05T16:58:21.197 app[d8901e2c623528] cdg [info] Iconify.prepare_icon_css/2 @ (iconify_ex 0.5.3) lib/iconify.ex:536
 2024-11-05T16:58:21.197 app[d8901e2c623528] cdg [info] Iconify.prepare/2 @ (iconify_ex 0.5.3) lib/iconify.ex:94
 2024-11-05T16:58:21.197 app[d8901e2c623528] cdg [info] Iconify.iconify/1 @ (iconify_ex 0.5.3) lib/iconify.ex:23
 2024-11-05T16:58:21.197 app[d8901e2c623528] cdg [info] load JSON for heroicons-solid icon family<EMAIL_ADDRESS> 2024-11-05T16:58:21.541 app[d8901e2c623528] cdg [info] 16:58:21.540 request_id=GAUg_KBGwDy3ofAAAAYB [info] Sent 500 in 354ms
 2024-11-05T16:58:21.543 app[d8901e2c623528] cdg [info] 16:58:21.541 request_id=GAUg_KBGwDy3ofAAAAYB [error] ** (RuntimeError) No icon set found at<EMAIL_ADDRESS>for the icon `question-mark-circle`. Find icon sets at https://icones.js.org

Turns out it igniter that was causing the issue, adding only: :dev solved the problem

I do not see any possible way that igniter could cause that error. I think it's more likely that recompiling does fixed your problem TBH

Here is a reproduction:
https://github.com/kantum/iconify_igniter

I'll look when I'm back from vacation unless @zachallaun has time. But I can't conceive of any possible way this could be igniters fault 😅 these libraries have nothing to do with each other and igniter doesn't do anything that could impact other deps.

Oh does including igniter/rewrite/sourcerer somehow cause Mix to be available in a release? because iconify_ex does Code.ensure_loaded?(Mix) as a sneaky way to check for dev environment (since by default all deps are in :prod)

Oh does including igniter/rewrite/sourcerer somehow cause Mix to be available in a release?

Maybe? Igniter tasks wrap Mix tasks, so presumably there's some dependency reference from Igniter back to Mix. I sort of thought that Mix was always stripped from releases, but maybe not.
@mayel As a test, could you try replacing this runtime check with this compile-time one:
if MIx.env() == :prod do
  def dev_env?, do: false
else
  def dev_env?, do: true
end

Only issue with that is that it'd always be false, since mix deps are compiled with :prod env even in dev environments.

Only issue with that is that it'd always be false, since mix deps are compiled with :prod env even in dev environments.

Ah, you're right; never mind.

Completed: 7fe684d79fd823ebd2c25ff55bb37330fcab8cce

@mayel this should also resolve the issue you saw, but also you probably want a different solution than detecting mix, as there are clearly ways to make it available in prod 😆

This will only resolve it for users who install igniter later though :)

I've updated all ash packages to use this new optional pattern, so once they are all released, Ash users will no longer be shipping igniter to production. Ash users that installed before the new installers may be presented with messages like "please install igniter" in order to use tasks that would have "just worked" before, but given that all of the igniter tooling is dev/build-time tooling, I'm comfortable with this.


Adjustments on Product card in Product details

Current state:

Desired state:

Key improvements:

The headline should be changes, on desktop is should be Playfair Display 24px bold 120% line height, on mobile Playfair Display bold 18, 120% line height, color 4F4F4F

The main font with the content should be Roboto 14px regular 150% line height, the same on desktop and mobile, color 4F4F4F

Listing needs to be changed from  to desired one

All content in this component should fit the grid, there shouldn't be any additional margin (besides the listing)

List of qualities should be changed from  to
, changes in font size 14px, weight (name of a quality = regular, value of a quality = bold), color 4F4F4F, line height 150%

Please assign me for testing this issue after it will be done.

Changes in develop, I just couldn't edit dots in list items, because they are rendered as text


catch token expire

Hi I am trying to catch token expire because my aim to logout the application once token is expire but i am able to to catch the token expire ....please help me one the

Heya! This issues list is already not the best place for general help with the library, and your question is not really easily answerable as is. I recommend seeking out a colleague, friend, or consultant to help you out, or possibly turn to Stack Overflow (with a more complete question).