enhancement: handle partial note ids on the CLI

closes #191
Here we change the behavior of 2 commands to accept a prefix of the note id hex:

input-note show
tx new consume-notes

The behavior is currently located in the CLI, although we could consider moving the logic to the client/store.

* Because this function is on the CLI binary, and the CLI binary always uses `SqliteStore` for the Store, maybe the lookup function can be located in `SqliteStore`. This would allow for a more specific implementation. Doesn't have to be done right now and could be left for a future PR but it might be a bit cleaner. We could also add it to `Store` as a default function that utilizes the more inefficient `get_input_notes(NoteFilter::All)` while maintaining the more specific `SqliteStore` implementation.

I like the Idea of an auto implemented function in the store. All things considered we might as well add this to the store trait as a default implementation. As you said I'd keep it for a follow-up PR.

* If possible we might want to add a test for a success and failure case to validate the lookup function

Added one in cli/input_notes.rs that tests the three cases: no match, match, multiple matches


Improve the way we deliver Examples in command line

The build and run commands both have long sections of examples.  In run them come in the middle of the page in build they come at the end.

Standardize examples at the end of every page
Design a consistent structure for calling out "categories of examples" in these larger sections

http://docs.docker.com/reference/commandline/build/
http://docs.docker.com/reference/commandline/run/

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

#dibs I'd like to work on this if no one else is.

@dharmit \0/ go for it.  This one is interesting...

@moxiegirl @GordonTheTurtle @jfrazelle is this taken? I would like to work on it if is available.

@lordzero0000 Go for it!

#dibs If nobody takes this, I do.


Added total sensor, hourly and previous cycle for energy based sensors

Added total that never resets
Added an attribute to all sensors which is previous cycle - I feel it's more important for me to know how much energy I used last hour, day, week or month then till this point in the cycle. I'm tempted to actually add separate sensors for that to be honest to be able to have recorder track the history and give me better stats but still undecided
Changed the list of excluded words when creating the friendly name so that things like month or today don't get in there from some plugs like Tapo P110 for example
Added friendly name generation for the integration entries page based on another pull request but used same logic as in this repo as it's more robust I think plus again added more excluded words

Hi @miczlo !
Thank you for contribution. I would like to merge your pull request and also @Kathou99 pull request https://github.com/martinarva/dynamic_energy_cost/pull/41, but i'm a bit afraid i will break something.
Would you be able to check both pull requests and check if its ok?

Should be fine, I merged with @Kathou99 one before adding this pull request, but then reverted
https://github.com/martinarva/dynamic_energy_cost/pull/41/commits/3ed58e344cc0018220f601c0509a3b6922693e41
because it gave me errors and I didn't have time to find out why and why the change
I also changed the way they added friendly naming on the integration page as there seemed to be potential for double underscore to mess things up plus something wouldn't work and again couldn't be bothered.

Should be fine, I merged with @Kathou99 one before adding this pull request, but then reverted 3ed58e3 because it gave me errors and I didn't have time to find out why and why the change I also changed the way they added friendly naming on the integration page as there seemed to be potential for double underscore to mess things up plus something wouldn't work and again couldn't be bothered.

So when i merge @Kathou99 first and then yours, everything should be ok?

I think so but there will be a conflict or two as like I said I modified there code after the merge.


The playspace feels a bit weird in the top-left of the corner on early levels.

Is there a way to zoom in on the playspace, or centre it on the screen, without breaking other stuff?

I have a camera positioning until script I can repurpose for this


How integrate this library in react-native

Hi! This is wrapper for iOS and its not appliable for react-native
You can use https://github.com/tradingview/lightweight-charts with react-native Webview. You can check the documentation here
If you need help with integration, open the issue here

Hi! This is wrapper for iOS and its not appliable for react-native
You can use https://github.com/tradingview/lightweight-charts with react-native Webview. You can check the documentation here
If you need help with integration, open the issue here


expose and document createElement and createHelper

Addresses https://github.com/acdlite/recompose/issues/66.
Happy to update. It is certainly not perfect. There are a couple intentional omissions here:

introduced ReactChildrenType but didn't really know how to concisely document the type of children...but then again, neither do the react docs ;)
left out createHelpers's _helperLength,  setDisplayName parameters. These don't seem to be used much even internally, and the leading underscore seems to indicate this should remain internal only, so I didn't document the optional params.

Current coverage is 100.00%

Merging #116 into master will not affect coverage as of c337317

@@            master    #116   diff @@
======================================
  Files           42      42
  Stmts          325     325
  Branches         0       0
  Methods          0       0
======================================
  Hit            325     325
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of c337317

Powered by Codecov. Updated on successful CI builds.

Let's hold off on this until https://github.com/acdlite/recompose/issues/117 is resolved. In the meantime, you can import createHelper at recompose/createHelper.


Update FFI to EffectFnX types

@gbagan Can I get your review on this?

That seems nice. Maybe we can add inline annotations on non-FFI functions for purescript-optimizer.

That seems nice. Maybe we can add inline annotations on non-FFI functions for purescript-optimizer.

Yeah, but that'll be its own PR. We need snapshot tests to verify that it's even worth doing.


[Feature] Save result table column preferences

Is your feature request related to a problem? Please describe.
Not an problem.
Describe the solution you'd like
I like to see the Packet Loss and Healthy columns. As they are not enabled by default I enabled them. Unfortunately these settings are only saved in the current session. On every login I need to re-enabled it. It would be nice if we can save the column  settings per user.
Additional context
N/A

For later ref; https://www.answeroverflow.com/m/1299170023327399986


Question: Sample Time

Background:

I am using this for a slow-acting temperature control system.  It will take minutes for the system to react.
The temperature sensors sample once every 10 seconds (these are DS18B20 sensors so not incredibly granular).
I am using that to feed a circularbuffer<5> and my temperature reading is the average of that buffer.

tl;dr my &Input is a 60-second average.
Further: My current efforts have QuickPID loop() every X seconds based on Arduino's Ticker.
I suspect that your code is intended to sample temperatures over time, taking action when sampleTimeUs expires.  If I'm correct, my circular buffer and Ticker are redundant to the QuickPID functions, and I could eliminate those and just run QuickPid::Compute() in my main::loop().  Right so far?
I "need" the running average to smooth out the UI, so I'll keep that no matter what.
So all that to set up my question:  Should I use the average for %Input and QuickPID::SetSampleTimeUs() to something like 10 seconds and call QuickPID::Compute() every second or so?  I'm leaning that way (or even longer periods) because of the slow-acting time of the system.
OR
Should I use the current "live" temperature reading, a more frequent loop, and a longer sampleTimeUs time?

I haven't done any testing on a slow acting control system yet, but its good first of all get the time parameters identified and set correctly. A good thing to estimate firstly is the time constant of your system. Let's say for example that it's 5-minutes (300 seconds).  It's suggested elsewhere that the sample time (PID compute period) should be at least 5-10x less than the time constant, so keeping with the example, this could be set to 30 seconds. With sensor readings coming in at 1 reading per 10 seconds, you would get 3 new readings (that are averaged in your circular buffer) for each sample period. I think the sensor rate should be more than 2x the PID compute period so this seems OK.
I took a quick look at the DS18B20 datasheet and it says the resolution can be set to 12-bit, which means you can get about 0.08°F resolution. For 12-bit mode, the max conversion time is 0.75 seconds.
I think using the running average temperature is OK, but you might find slightly better response using the raw temperature data. I wouldn't set the PID rate so fast that you get less than 2.5 temperature readings per PID compute period. As per the example, you could use 30 seconds: SetSampleTimeUs(30000000)

Thanks for your thoughts on this.  It will be a bit before I have a physical representation of the environment, so I'm sure you understand I'm trying to get close enough to use as a starting point right now.
I just identified a need to use two loops for this application, the main control loop (area being controlled), and a loop controlling the max temperature output of the heating system in order to avoid damage.  This should be fun!


Terminology + plot

What difference do you make between pitchgram and spectrogram? Isn't it a plot of magnitude of STFT in both cases?
Same question for reassigned pitchgram vs. reassigned spectrogram, what is the difference?
Last: how would you plot the best the spectrogram?
This works, but it's not optimal (i.e. the window is too small, it's not zoomed, etc.):
import tfr
import matplotlib.pyplot as plt
signal_frames = tfr.SignalFrames('test.wav')
P = tfr.pitchgram(signal_frames)
plt.imshow(P.transpose())
plt.show()

Do you think you could add in the README a ready to use Spectrogram/Pitchgram plot code?

Oh ok, pitchgram has a log frequency scale (a bit like Constant-Q transform?)...

Yeah, but it solves some problems with CQT. I used CQT before and this was
superior.
Dne st 26. 9. 2018 19:45 uživatel josephernest<EMAIL_ADDRESS>napsal:

Oh ok, pitchgram has a log frequency scale (a bit like Constant-Q
transform?)...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bzamecnik/tfr/issues/26#issuecomment-424807646, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAbOrPisLd9Y_Q-U6-Xw9wMQbJ0sVB_Aks5ue70cgaJpZM4W7Gxt
.

Ok thanks!
Last question (and then I'll study this by myself): with standard STFT, it's possible to STFT a signal, modify / do some masking on the S[t,w] matrix, then perform an iSTFT and get a modified signal. This is very often used in denoising, etc.
Is there something similar with Reassigned spectrogram? i.e. you perform a ReassignedSTFT, then you get a matrix, you modify/mask some values in some time frames, and then inverseReassignedSTFT to get the modified signal? If possible, would you have an example for this?

Yeah, you're asking if the transform is invertible. I'm afraid directly
not, but maybe there's some lossy transform. Maybe some research tried to
solve invertible variants of reassigned STFT. Anyway, I remember NSGT
(non-stationary Gabor transform) which was overcomplete and invertible. But
I don't have practical experience with it yet.
Hope it helps.
Dne st 26. 9. 2018 19:49 uživatel josephernest<EMAIL_ADDRESS>napsal:

Ok thanks!
Last question (and then I'll study this by myself): with standard STFT,
it's possible to STFT a signal, modify / do some masking on the S[t,w]
matrix, then perform an iSTFT and get a modified signal. This is very often
used in denoising, etc.
Is there something similar with Reassigned spectrogram? i.e. you perform a
ReassignedSTFT, then you get a matrix, you modify/mask some values in some
time frames, and then inverseReassignedSTFT to get the modified signal? If
possible, would you have an example for this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bzamecnik/tfr/issues/26#issuecomment-424809221, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAbOrNu-Nhc1brKh2WBnc75LNt5raMiQks5ue75EgaJpZM4W7Gxt
.

Thanks.
IIRC:

Gabor transform = specific case of STFT when window function = Gaussian
Non stationary Gabor transform (NSGT) is a generalization of STFT in which the frequency bins can be
something else than linear freq scales, such as logarithmic (ConstantQ transform), etc. :

Our CQ-NSGT algorithm is not limited to linear frequency scales (as is the STFT), but can be used with arbitrary scales, most notably with logarithmic (aka “constant-Q”) scales relevant for musical applications, or also perceptually informed Mel scales.

https://grrrr.org/research/software/nsgt/


Added the MaterialViewpager in a fragment, How do i remove the arrow?

pretty much tried everything to remove the arrow. since i call the toolbar in the activity and not the fragment there's no way to hide that arrow.
help?

did you try to hide the toolbar from matetrialviewpager ?
matetrialviewpager.getToolbar().setVisibility(GONE)

i cant use materialviewpager.getToolbar() for some reason, i always get a null object reference error. i got the toolbar in the MainActivity using the findViewbyid option

Amith,
Could you please upload your code how you figured out to use a library within a fragment?
I am having a hard time to do it.
Thanks!
Dan

hi Dan, i used the MaterialPageViewer just as any other layout in the fragment. just create an xml with this viewpager and call it in a fragment. away from my computer at the moment but i will upload the code if you still need some help.

Hi Amith,
I am trying to do the same, add the viewPager in fragment, and dead stuck on it. A snippet would be very helpful.
Thanks in advance!

My solution was to leave the fragment with the materialviewpager without any other toolbar and add a toolbar to the other fragments.
Then on the creation of the view on the fragment that contains the materialviewpager instance just hook up the its toolbar with the one supplied by the activity:
`@Override
public void onViewCreated(View view, @Nullable Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState);
super.onCreate(savedInstanceState);
    mViewPager = (MaterialViewPager) getActivity().findViewById(R.id.materialViewPager);

    ...

    AppCompatActivity hostActivity = (AppCompatActivity) getActivity();

    Toolbar toolbar = mViewPager.getToolbar();
    hostActivity.setSupportActionBar(toolbar);
    final ActionBar actionBar = hostActivity.getSupportActionBar();
    if (actionBar != null) {
        actionBar.setDisplayHomeAsUpEnabled(true);
        actionBar.setDisplayShowHomeEnabled(true);
        actionBar.setDisplayShowTitleEnabled(true);
        actionBar.setDisplayUseLogoEnabled(false);
        actionBar.setHomeButtonEnabled(true);
    }`

Could any one post the code on how to add the viewPager in a fragment


issue with css menu on mobile

my problem is that the menu should close after clicking an anchor link in the mobile menu. It works without smooth-scroll (see here). When smooth-scroll is running however I have to close the menu manually. See it here
Any idea how to get back the desired behavior (automatic close of the mobile menu after click/tap)?

You can use a callback after SmoothScroll runs to close the menu.
smoothScroll.callback(function () {
    // Some JS to close the menu
})

Thanks, any idea what this could be. I'm not fit enough for coming up with something useful.

@thob I actually think I figured out what this is! If any of this doesn't make sense, please ask me to clarify...
When Smooth Scroll animates a link, it uses event.preventDefault() to stop the page from just jumping to the link.
Once that's done, it uses the pushState JavaScript method to update the URL without causing another jump (if you used location.hash or location.href the page would jump again).
The problem with this last part (the pushState bit) is that it doesn't trigger a state change for:target.
As a result---this is the unfortunate part---there's no way to fix it as the code is written today. I thought you were using a JS approach to expand and collapse the menu. Your CSS approach is awesome, but fails with the way Smooth Scroll is currently written.
The good news: I plan on refactoring Smooth Scroll with a different approach. When you click a link:

Smooth Scroll will find the anchored element.
It will remove the id from that element and store it as a data attribute (data-id) on that element.
The link will do it's normal behavior, triggering an hash change in the URL. This will change the :target, which means your CSS approach will work.
Because there target element no longer has an id, no jump will happen.
After the hash changes, Smooth Scroll will locate the element whose data-id matches the hash, and run the old animation method I'm using today.

This approach has fewer CSS quirks or browser compatibility issues associated with it because it's letting the browser do more of the heavy lifting (versus trying to recreate URL history in JavaScript).
I'm hoping to get this done this week, but I can't commit to a hard launch date. But that's why this isn't working currently. Sorry about that!

Also, reopening this and marking it as a bug.

FYI: if using the CSS menu with a jquery based smooth scroll it works

Fixed with v10.0.0 https://github.com/cferdinandi/smooth-scroll/pull/283
Will be merging as soon as the build tests pass

thanks for this super fast reaction!

My pleasure! And thanks for letting me know about a weird edge-case bug I probably wouldn't have caught otherwise. This is one of my favorite things about open source projects!


ConvertMHLOToLinalgExt Failed :mhlo.sort to linalg_ext.sort

I am trying to understand tf.NonMaxSuppressionV4 lowering in iree with static shapes.I have attached tf,hlo and iree log file.
For tf->HLO I used:tensorflow/bazel-bin/tensorflow/compiler/mlir/tf-opt  -xla-legalize-tf-with-tf2xla=device-type=XLA_CPU_JIT  tf.mlir
The output HLO I try to run using :
/data/aruna/iree-latest/iree-build/iree/tools/iree-run-mlir --iree-input-type=mhlo -iree-hal-target-backends=dylib-llvm-aot -iree-flow-dispatch-formation-enable-operand-fusion -iree-flow-dispatch-linalg-on-tensors-tile-sizes="0,0,0,0" -print-ir-before-all -print-ir-after-all  hlo.mlir &>out.mlir
Got error as :loc(callsite("hlo.mlir split at line #1":19:13 at "hlo.mlir split at line #1":2:3)): error: 'linalg_ext.sort' op dimension must be within (0, 1]
Thanks
tf.log
hlo.log
iree .log

Looks like an underimplemented of the sort lowering. That work was just done recently. Hanhan: do you have any idea on what is going on here?

Looks like there is a sort op not lowered correctly.
    %12:2 = "mhlo.sort"(%arg1, %11) ( {
    ^bb0(%arg4: tensor<f32>, %arg5: tensor<f32>, %arg6: tensor<i32>, %arg7: tensor<i32>):  // no predecessors
      %92 = "mhlo.compare"(%arg4, %arg5) {compare_type = "TOTALORDER", comparison_direction = "GT"} : (tensor<f32>, tensor<f32>) -> tensor<i1>
      "mhlo.return"(%92) : (tensor<i1>) -> ()
    }) {dimension = -1 : i64, is_stable = false} : (tensor<3xf32>, tensor<3xi32>) -> (tensor<3xf32>, tensor<3xi32>)

I think we miss the case that dimension = -1. This is defined in XLA operation semantics, so it should be an easy fix, I'll send it out soon

If no dimension number is provided, then the last dimension is chosen by default.

Landed the patch upstream. Will get fixed in the next integration.
https://github.com/tensorflow/tensorflow/commit/956f5c8b826652a5d1f0dc315f38bc30ba42dd0b#diff-c00bdbe9d983f1358e442fa0ea5ea984046931192394e63bcbae65edc1d36f39


Cannot find package 'stream'

Describe the bug
This happens after the latest update for kit. I got the following error with npm run build:

19:39:57.691
> Cannot find package 'stream' imported from /vercel/path0/web/.svelte-kit/output/server/app.js

19:39:57.691
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'stream' imported from /vercel/path0/web/.svelte-kit/output/server/app.js

19:39:57.691
at packageResolve (internal/modules/esm/resolve.js:664:9)

19:39:57.691
at moduleResolve (internal/modules/esm/resolve.js:705:18)

19:39:57.691
at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:819:11)

19:39:57.691
at Loader.resolve (internal/modules/esm/loader.js:89:40)

19:39:57.691
at Loader.getModuleJob (internal/modules/esm/loader.js:242:28)

19:39:57.691
at ModuleWrap. (internal/modules/esm/module_job.js:73:40)

19:39:57.691
at link (internal/modules/esm/module_job.js:72:36)

Reproduction
Clone my repo here: https://github.com/winston0410/portfolio-2021
cd ./web
npm install
npm run build
Logs
No response
System Info
System:
    OS: macOS 11.4
    CPU: (8) x64 Apple M1
    Memory: 27.66 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.4.1 - /nix/store/i0sl2paxrjshqn5ps24pdhdkql07x6ra-nodejs-16.4.1/bin/node
    npm: 7.18.1 - /nix/store/i0sl2paxrjshqn5ps24pdhdkql07x6ra-nodejs-16.4.1/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Safari: 14.1.1
  npmPackages:
    @sveltejs/adapter-static: next => 1.0.0-next.18
    @sveltejs/adapter-vercel: next => 1.0.0-next.28
    @sveltejs/app-utils: next => 1.0.0-next.3
    @sveltejs/kit: next => 1.0.0-next.162
    svelte: ^3.34.0 => 3.42.4

Severity
blocking all usage of SvelteKit
Additional Information
I got the same error on both local and vercel.

I think that import statement is coming from node-fetch. We haven't changed the node-fetch version in many months though

This happens after the latest update for kit.

This doesn't seem to have broken because of a kit upgrade, but because of https://github.com/winston0410/portfolio-2021/commit/859ead8c0a970ec6ac91f410795736af7763e161#diff-4b5e57f6eb2f42b9039b3d1e13929295f231749c510cbe341cd68036d9af97e2

It's because you added a dependency on node-fetch 3.0 final. I get the same error if I try to upgrade SvelteKit to use that version: https://github.com/sveltejs/kit/pull/2422

@benmccann Yes I have added in node-fetch, because I got an ERR_MODULE_NOT_FOUND for fetch in my server side code.
And I think I got that error after I have added in a wrapped fetch to my code, but it looks alright to me? It should pick up fetch from either global or window?
// index.ts
var createWrapped = (f) => {
  f = f ? f : fetch;
  return async (url, opts) => {
    const res = await f(url, opts);
    return {
      ok: res.ok,
      status: res.status,
      body: await res.json()
    };
  };
};
var git_clone_aa4ce5db_default = createWrapped;
export {
  git_clone_aa4ce5db_default as default
};

#2422

I hope this will solve the issue. Thank you for your time for helping me out.

You must set ignoreTryCatch: true for @rollup/plugin-commonjs: https://github.com/rollup/plugins/issues/1004

I found a decent work-around since updating Kit wasn't working for me. Downgrading to version 2.6.5 of node-fetch solved all errors.
npm I<EMAIL_ADDRESS>

I can support @jckr's advice. Was using node version 14 when I got this error.
Updating to the current node version 18.6.0 solved it :+1:

I ran into this too. Upgrading to 16 worked, but unfortunately, that really complicates my setup, as I have other things that require Node 14.

I ran into this too. Upgrading to 16 worked, but unfortunately, that really complicates my setup, as I have other things that require Node 14.

kit requires node 16 https://github.com/sveltejs/kit/blob/21d97256f8320fa7a8e3ccf859894e1bc28046d2/packages/kit/package.json#L97

Using multiple node versions is easy with nvm: https://github.com/nvm-sh/nvm

i had the same issue, my node version is 16.13.0

solved by this https://github.com/octokit/octokit.js/issues/2126#issuecomment-1186210471


Unification of error messages for e2e test

Coverage decreased (-0.3%) to 96.552% when pulling e069bceb4abe93c5826167a5e4a701f5b644529d on akoniar:unification-error-messages into 27118204df8db1caa8cf94cedefc09946a6fc13d on bucharest-gold:master.

Coverage decreased (-0.3%) to 96.552% when pulling e069bceb4abe93c5826167a5e4a701f5b644529d on akoniar:unification-error-messages into 27118204df8db1caa8cf94cedefc09946a6fc13d on bucharest-gold:master.

@lholmquist Please, code review

@akoniar looks like travis is broken

@akoniar still broken.  you should probably run npm run test before pushing up

@akoniar landed as 50a7f72


Add BlastTab format.

Codecov Report

Merging #24 into master will decrease coverage by 0.25%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master     #24      +/-   ##
===========================================
- Coverage      4.89%   4.64%   -0.26%
  Complexity       25      25
===========================================
  Files            34      34
  Lines          1002    1056      +54
  Branches        199     208       +9
===========================================
  Hits             49      49
- Misses          951    1005      +54
  Partials          2       2


When capturing onPaymentMethodReceived form is not submitted

If I capture the event, then the form is not submitted. I have tried returning true, but no results.
What am I missing?
onPaymentMethodReceived: function (result) {
        if (result.details.lastTwo) {
            $('#id_card_ending').val(result.details.lastTwo);
        }
}

<form class="the-form" action="" method="POST" autocomplete="off">

onPaymentMethodReceived prevents automatic form submission—you'll have to do it yourself. Something like this should work:
onPaymentMethodReceived: function (result) {
        if (result.details.lastTwo) {
            $('#id_card_ending').val(result.details.lastTwo);
        }
        $('.the-form').submit();
}

Does that help?

Actually, I also had to get the nonce and use native submit (not jquery's) because it was ignoring a
redirection. The fact that catching the event prevents the form submission should be in the documentation.
Thank you

Glad we could steer you in the right direction. We're in the process of updating our docs with an onPaymentMethodReceived form submission example, which should be on our live docs in a few days. Thanks for the suggestion!

@alculquicondor we have updated our documentation to describe the fact that the onPaymentMethodReceived callback prevents form submission. Take a look here.

Hi, I am finding that $('#myForm').submit does not work, though myForm.submit (native) works. But I need the jquery one because I would like the results to be in a bootstrap modal without reloading the page. Is this possible?


Adding pre-requisites section to help people get set up to run the ex…

…amples

@bfosberry what's up with this, do we want to rebase on current master and review again?

ping @bfosberry


Add a 'raw data' viewer like PVRTexTool

Basically something like this:

This pvrtextool dialog is for wrapping existing raw data with the pvr header... tacentview does not yet support saving pvr files. However, it may be reasonable to allow display of 'raw' pixel data if you happen to know the pixel-format, dimensions, mipmaps etc. Will leave this request open but may not get to it for a while. Thx for the suggestion.

Tentative plan here is to make a 'raw import' dialog. The dialog would allow specification of the filetype to create (only lossless filetypes much like the paste filetypes).
Fields of the raw-import dialog would include:

Filename
Pixel Data Offset (default 0)
Pixel format. Would include BC / ASTC / Packed / ETC / EAC / PVR but probably not palettized or vendor-specific formats.
Width / Height
Mipmaps (default off)
Colour profile (specifies both colour-space and LDR/HDR). This is less ambiguous than just a colour-space because quite often the space of the RGB components is sRGB while the alpha is linear).
Premultiplied alpha (for formats that support an alpha channel, if premult was true we would need to 'undo' it by multiplying by the reciprocal of the alpha).

Note: Updating display 'live' would be needed so different dimensions / offsets could be experimented with on the fly.
Note: Care would have to be taken that we don't ever overrun the available data by pre-computing the needed buffer size given the width/height/mips/pixel-format. This would then be compared to the actual size of the data being imported (filesize - offset) and if too little data not performing an import. Would need a warning message of some kind.

Still ToDo:
* Allow changing filetype in same import session.
* Support the remaining filetypes (TIFF, APNG, WEBP done, TGA, PNG, QOI, and BMP not).
* Implement the 'live' checkbox.
* Colour profile selection.
* Create test raw images with and without mipmaps/offsets. Make sure rows are not reversed etc.
* Better messaging when import fails (decode error, not enough data, etc).

This is the final version of the import dialog. Will close this issue after testing a few more raw files.

Commit ee73529ed9d1bad6e72c18b0143dac7e9dc4c0fd includes various raw test images.


PhantomJS crashes at the end of the tests while all tests passed

Hello !
I am using Protractor and PhantomJS in a continuous integration process. We build the project on a remote web server and launch E2E tests using Grunt, Protractor and PhantomJS. I am using Jenkins for that. I also use protractor-html-screenshot-reporter to have reports and screenshots when tests failed.
The problem is that even all tests passed (I know it because the reports show me that), sometimes (about 50%) the execution failed because PhantomJS may have died at the end of the tests. It is annoying because, in Jenkins, I am using the return code of the execution to know if the tests passed.
I am using PhantomJS v1.9.8 and Protractor v1.3.1
Here is my Protractor configuration
var HtmlReporter = require('protractor-html-screenshot-reporter');

exports.config = {

    onPrepare: function() {
        // Add a screenshot reporter and store screenshots to `e2e/debug`:
        jasmine.getEnv().addReporter(new HtmlReporter({
            baseDirectory: 'e2e/front/debug',
            takeScreenShotsOnlyForFailedSpecs: true
        }));
    },

    specs: ['spec/**/loginSpec.js', 'spec/**/*Spec.js'],

    baseUrl: 'SOME_URL',

    jasmineNodeOpts: {
        showColors: true,
        defaultTimeoutInterval: 30000
    }
};

And here is a part of my log file in Jenkins

Running "logDevReportAdmin" task
    admin report can be found at http://SOME_URL/src/test/webapp/e2e/admin/debug/report.html

Running "protractor:devAdminPhantomjs" (protractor) task
    util.puts: Use console.log instead
Starting selenium standalone server...
    util.puts: Use console.log instead
Selenium standalone server started at http://SOME_URL/wd/hub
    ...

    Finished in 6.566 seconds
3 tests, 5 assertions, 0 failures

    util.puts: Use console.log instead
Shutting down selenium standalone server.

Running "logDevReportFront" task
    front report can be found at http://SOME_URL/src/test/webapp/e2e/front/debug/report.html

Running "protractor:devFrontPhantomjs" (protractor) task
    util.puts: Use console.log instead
Starting selenium standalone server...
    util.puts: Use console.log instead
Selenium standalone server started at http://SOME_URL/wd/hub
    ........F
/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/error.js:113
var template = new Error(this.message);
^
UnknownError: Error communicating with the remote browser. It may have died.
    Build info: version: '2.43.1', revision: '5163bce', time: '2014-09-10 16:27:33'
System info: host: 'SOME_IP', ip: 'SOME_IP', os.name: 'Linux', os.arch: 'amd64', os.version: '3.2.0-58-virtual', java.version: '1.7.0_55'
Driver info: driver.version: PhantomJSDriver
at new bot.Error (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/error.js:113:18)
at Object.bot.response.checkResponse (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/response.js:106:9)
at /mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:319:20
at /mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1582:15
at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1640:20)
at notify (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:444:12)
at notifyAll (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:422:7)
at resolve (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:400:7)
at [object Object].fulfill (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:512:5)
at /mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1507:10
==== async task ====
    WebDriver.takeScreenshot()
at [object Object].webdriver.WebDriver.schedule (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:302:15)
at [object Object].webdriver.WebDriver.takeScreenshot (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:917:15)
at [object Object].to.(anonymous function) [as takeScreenshot] (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/lib/protractor.js:58:25)
at ScreenshotReporter.reportSpecResults (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor-html-screenshot-reporter/index.js:141:10)
at [object Object].reportSpecResults (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/minijasminenode/lib/jasmine-1.3.1.js:1901:39)
at [object Object].jasmine.Spec.finishCallback (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/minijasminenode/lib/jasmine-1.3.1.js:2470:21)
at [object Object].jasmine.Spec.finish (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/minijasminenode/lib/jasmine-1.3.1.js:2475:8)
at [object Object].onComplete (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/minijasminenode/lib/jasmine-1.3.1.js:2504:10)
at [object Object].jasmine.Queue.next_ (/mnt/jenkins/work/jobs/E2E Tests/workspace/src/test/webapp/node_modules/protractor/node_modules/minijasminenode/lib/jasmine-1.3.1.js:2219:14)
>>
Fatal error: protractor exited with code: 1

I hope someone can help me ! Maybe @juliemr :)
Thanks for you help !

Closing as a duplicate of #557


Definition of Git Process

Development of the application specifications shall be collaborative.
Efficiently doing so requires definition of a process, which is kept by all involved persons.

GitProcess shall define such process including, e.g.:

having a master branch on GitHub, and every commit on it is representing an official version initiating further actions in neighboring domains (e.g. implementation or procurement)
having a development (instead of tsi, tsp and so on) branch on GitHub, which is common base for all persons, who are involved into the specification process
using short living feature and issue branches for driving the specification
ApplicationOwner and a small number of colleagues being Collaborators on the repository (so no need for forks),
… but committing on master and development being blocked in the beginning (so no push into origin/master or origin/development, but merge requests and review required).

GitProcess shall state the tools for implementing the process, e.g.:

GitHub
local Git
VSCode

GitProcess shall be complemented by a step by step screenshot series for explaining how to implement the process on the tools.

Added a reference to a description of the Forking Workflow to the ApplicationPattern documentation.
Step-by-step guidelines for ApplicationOwners and contributors are still missing.

Step by step screenshot series for explaining how to implement the process in VS Code is missing.

Process has been described and separate Issues have been created for the step-by-step guidelines.


syntax highlighting doesn't work until certain keys are pressed

MacOS version: 10.15.4
zsh-syntax-highlighting version: 0.7.1
When typing out a command, syntax highlighting doesn't appear immediately. The only way to get the syntax highlighting to appear is to either:

Press space
Press backspace
Press enter

Tiny GIF showing the issue: https://giphy.com/gifs/WRzfHFuxegBhhCYaUo

Can you reproduce the problem in zsh -f?  (Run that.  You'll get a hostname%  prompt.   At that prompt, run source /path/to/zsh-syntax-highlighting.zsh by hand, after replacing /path/to with the correct value, then type in your test command and check if it's highlighted correctly.)
If not, it'll be due to interaction with some other plugin.  You'll have to check your dotfiles.  (You could also try the feature/redrawhook branch.)

Ahh, the issue was a new source was appended to my .zshrc.
Sourcing it last in my .zshrc fixed it for me :facepalm:

Thanks for following up.
This might be a bug in that other plugin, actually.  When z-sy-h wraps a widget, it calls a previous user-defined wrapper function, if one was present when z-sy-h was installed.  That other plugin doesn't seem to do that, meaning it must be installed before any other plugins that wraps widgets — which, naturally, isn't composable.  (There can only be one such plugin in any one user's configuration.)

@t2nerb keep in mind you will have to source zsh-history-substring-search.zsh after zsh-syntax-highlighting if you ever want to use it

Ahh, the issue was a new source was appended to my .zshrc.
Sourcing it last in my .zshrc fixed it for me 🤦

thanks, worked for me 🥳


PyPI version and repo version

Hi,
The PyPI version of this package https://pypi.org/project/sphinxcontrib-yaml/ is higher than in the repo, but the release date of the PyPI version is way older than the latests commits to the repo.
From where should I install to make sure I have the latest version of the code?

sphinxcontrib-yaml package is obsolete. See https://pypi.org/project/sphinxcontrib-autoyaml/ instead. It contains the latest code.


ARIA Accessibility elements through props

It would be nice if I could do this:
import MySvg from './MySvg.svg';

function renderWithAccessibility() {
  return <MySvg title="title" desc="desc"/>;
}

and the SVG was transformed to this:
<svg>
  <title>title</title>
  <desc>desc</desc>
</svg>

To support ARIA SVG accessibility.
Thoughts from package maintainers?

Yes. Sure. PR Welcome 👍


build_torcx_store: Bump the default Docker to 19.03

Part of coreos/coreos-overlay#3477

Closing as WONTFIX with the overlay PR.


Update setup.py

Adding a description string to setup.py so that project not described as UNKNOWN in pypi

Hi, @lowks. Sorry, I just noticed this pull request. Thanks!


Tab completion on Windows

Under the "Windows" section:
Enable tab completion with source az.completion.sh. - the "source" command is not available on Windows.
The documentation should be updated with the correct steps to activate tab completion on windows.

Tab completion is not available on Windows CMD.
In the README, the text that reads "Enable tab completion with source az.completion.sh" is not actually under the 'On Windows:' heading.
We can update the formatting to make this more clear.

If you look at the structure of the proceeding sections, there's no way to tell that that's not part of the windows section.

Agreed, it's not clear in the README.

Changed the issue name to reflect this.


GSK-248 verify and upload df before model

bug fix for "Model gets uploaded even if there is an error in column_types"

@princyiakov, with the current solution we're not really fixing the problem, there's now another case possible:

you make a mistake in model upload parameters, for example classification_labels
Dataset will be uploaded, but the model won't be

To fix the problem we should probably add a "dry run" option for both upload dataset and upload_model methods.
When each of these functions is called with dry_run=True nothing is uploaded, but all of the validations are called.
Then inside upload_model_and_df we do something like:
for dry_run in [True, False]:
   upload_df(..., dry_run=dry_run)
   upload_model(..., dry_run=dry_run)

In this case either both objects get uploaded or none


UPDATE TO PREVIOUS THREAD: It seems to sometimes only work when you put your variable name in quotation marks.

In regards to using firefox, its not that bad but there is some bugs that still need squashing. I log in to imagefx first and then I input my info as normal. however, there seems to be a fluctuation glitch on how it wants to work. I will sometimes use quotations and it allows the email into the env, but however when i run the variable on imagen3.py , it says my token is not valid. Will explain more when im out of school

duplicate #49


Accordion is-open does not work as expected when using "$scope.accordion"

Bug description:
If you have an accordion with close-groups=false and you are using an object $scope.accordion to control multiple groups, the groups do not follow the values of the object properties as expected. Only if the variable is called accordion.
I guess it's an issue with inheritance or something, since $scope.accordion seems to be an object that uib is using. Fix might just be to say not to use that name in the docs.
Link to minimally-working plunker that reproduces the issue:
http://plnkr.co/edit/4cItCuNWEsHrVLFv03yL?p=preview
Version of Angular, UIBS, and Bootstrap
Angular:  1.5.3
UIBS: 1.3.1
Bootstrap: 3.3.6

I think it might be because of calling the controller accordion with controllerAs.
@wesleycho, thoughts on this? Should we just document it?

Yep, you're probably right - this is an unfortunate side effect of the implementation of controllerAs in Angular.

Alright, then I will assume the resolution is to just document this behavior rather than changing the controllerAs to some obscure name.
PRs welcome!

If we do decide to document, we need to do it for every component with controllerAs.
I'm not sure whether it's worth doing so though.

@wesleycho, sounds good.
@karlr42, thanks for reporting, but after talking with the team, we are not going to make any changes at this time. As Wes stated, this is an unfortunate side effect of controllerAs usage, and is something we have to live with for now.


Add documentation about how to search existing tests/examples for how to do something

As developers, we have the benefit of being able to go search in test suite code to see how something is done. Its not ideal but in lieu of any other forthcoming documentation, it might make sense to at least export our test suite code to some place user's can go get it to search for themselves as a last resort. Of course, they might wind up also discovering how many features we have that we don't test either ;)
-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.
Ticket number: 2262
Status: Pending
Project: VisIt
Tracker: Feature
Priority: Normal
Subject: add link to checkout test suite code to Wiki
Assigned to: -
Category: -
Target version: -
Author: Mark Miller
Start: 05/08/2015
Due date:
% Done: 0%
Estimated time:
Created: 05/08/2015 02:11 pm
Updated: 05/12/2015 06:41 pm
Likelihood:
Severity:
Found in version: 2.12.3
Impact: 3 - Medium
Expected Use: 3 - Occasional
OS: All
Support Group: Any
Description:
As developers, we have the benefit of being able to go search in test suite code to see how something is done. Its not ideal but in lieu of any other forthcoming documentation, it might make sense to at least export our test suite code to some place user's can go get it to search for themselves as a last resort. Of course, they might wind up also discovering how many features we have that we don't test either ;)
Comments:
The code for the test script is already on the test suite results page for each test. Maybe we just need to add some text somewhere that explains this (on the scripting page somewhere) and have a link to the test suite from there.

The code is open source on github now, so any user can see the test code.

I think I will re-open and adjust title here...lets have some basic documentation explanations with references to our test suite code so users have an idea how to go look at how something is handled there. Basically an extra paragraph somewhere in the documentation that explains a few key steps in searching for how to do something with VisIt from the test suite (and examples) codes.

Should include stuff from here

One possible solution would be to export the scripts to our users manual.


Improve brotli compression performance

There is significant performance loss in #97 when client requests brotli compression.
I'd like to find a way to improve it. At least make it as fast as commit 7113041.
Benchmark

master branch 7113041
feature/issue-33 2ee86cb

br
Running 10s test @ http://localhost:5000/Cargo.toml  2 threads and 10 connections  Thread Stats   Avg      Stdev     Max   +/- Stdev    Latency     2.82ms  206.74us  11.20ms   86.73%    Req/Sec     1.78k    34.26     1.84k    83.50%  35471 requests in 10.00s, 54.16MB readRequests/sec:   3545.80Transfer/sec:      5.41MB
Running 10s test @ http://localhost:5000/Cargo.toml  2 threads and 10 connections  Thread Stats   Avg      Stdev     Max   +/- Stdev    Latency     5.50ms    2.16ms  26.19ms   71.38%    Req/Sec     0.92k    65.42     1.03k    78.50%  18233 requests in 10.01s, 17.01MB readRequests/sec:   1821.76Transfer/sec:      1.70MB

@weihanglo I have create a pull request for this issue, which also fixes a severe bug introduced by my previous pull request #97 :sweat_smile: Please help review thanks


Add hover on button "become a partner" button in cta section, Fixes #306

Fixes #306
before:

after:
https://github.com/user-attachments/assets/a6fd2a59-92ed-438c-993e-1e044f926225
@anuragverma108 @PriyaGhosal please review this pull request and add it under hacktoberfest24

@anuragverma108 @PriyaGhosal please review this merge request.

Conflict resolved

Conflicts resolved again so please take a look and merge this pr under the main branch @anuragverma108

Could you please also provide me with the hacktober fest accepted labels?


docs: updated cookbook title.

ping @deekoder

ping @koolhead17 can you fix gitter link?

You have to resolve conflicts as well @koolhead17

This can be closed via https://github.com/minio/cookbook/pull/140

Closing this in favour of #140


srcset not updated with AVATAR_URL

The attribute srcset of the avatar is not updated with the env var AVATAR_URL, on some device the default image will be display.
Possible fix:
Adding an env var AVATAR_2X_URL to update the attribute would fix the issue or using AVATAR_URL to update srcset (but we will lose the utility of srcset).

Thank you!  Let me work on a fix.  I think I will go with your recommendation of AVATAR_2X_URL

Fixed by https://github.com/techno-tim/littlelink-server/commit/b06bb9443f23b5215fd14475b457728086461cf2


CORTX-31068: Refactoring needed for Hare-ha communication module

Solution:
Added new base classes for resources and events. These calsses will be
used as parent classes for all the resources and events
Signed-off-by: Swapnil Gaonkar<EMAIL_ADDRESS>

1N deployment is failing ? @SwapnilGaonkar7

Can one of the admins verify this patch?

@mssawant @Shreya-18 I have addressed your review comments.
Please have a look.
Tested 3 node deployment after changes.

@mssawant @Shreya-18 @d-nayak please review as you get chance.

Please resolve the conflicts

@SwapnilGaonkar7 looks like there is conflict in one file. Please resolve.

Done

1N Deployment and premerge test is failing.. need to check this

@SwapnilGaonkar7 @mssawant lets merge this PR - looks like needs rebase as well.

Looks good. Can you post steps where a new event type is added and sent?

Current implementation is as follows,
class ResourceType:
class Node(ResourceType):
	create_event():
		return HaEvent

class HaEvent:
class NodeEvent(HaEvent):
	send():
	    subscribers = get_subscribers('node')
            subscribers.send()

class Ha():
	send_event(resource):
		event: HaEvent =  resource.type.create_event()
		event.send()

If in future, we want to add new resource type(e.g. cluster) then following will be the code structure for it
class Cluster(ResourceType):
	create_event():
		return HaEvent

class ClusterEvent(HaEvent):
	send():
	    subscribers = get_subscribers('cluster')
	    subscribers.send()

For adding new interface similar to MessageBus, following structure will be used
class MessageInterface():

# Existing
class MessageBusInterface(MessageInterface):
    create_producer()
    send()
    create_listener()

# Addition
class Consulnterface(MessageInterface):
    create_producer()
    send()
    create_listener()


Line Chart - hoverBorderColor possible?

I noticed the bar chart has an option for hoverBorderColor, I was wondering if such a thing is possible for Line Charts as well?

@alancwoo  pointHoverBorderColor will change the hover color for points

@etimberg I'm sorry I think my phrasing wasn't clear, I was wondering if the line itself could be changed on hover through an option, such that one could have a subdued line, and then when hovering over a point the whole line could change

Oh, sorry. I misunderstood. Currently we don't have that functionality.

This would be really cool, I tried for ages to get it to work as the line graph was the first thing I played around with in the library. ;)


Ionic 4 support?

Hi everyone,
are there any plans to support super-tabs in Ionic 4?
Kind regards,
Thomas

Yes. When it's in late beta / stable stage.

Please watch the following branch for updates on Ionic 4 development: https://github.com/zyra/ionic2-super-tabs/tree/master


Add support for DialogFragment

It's almost exactly the same as regular Fragment, I'm not sure if there is an easy way to share the boilerplate code between them.
If anyone does try to add support for DialogFragments, this will keep the dialog on the screen for orientation changes.
    @Override
    public void onDestroyView() {
        if (getDialog() != null && getRetainInstance()) {
            getDialog().setDismissMessage(null);
        }
        ButterKnife.reset(this);
        super.onDestroyView();
    }```

I will have a look at DialogFragment. I guess it's just a copy & paste from already existing MvpFragment implementation

Yea, that's what I've done in my current project.

I've been experimenting with this library a tiny bit this afternoon and was looking for a similiar PreferenceFragment implementation.
I think the best and most flexible solution for this is a delegate interface / abstraction similar to what we can find in the latest support library update. So I would expect this library to provide abstract MVP implementations for the most common base classes, but if I cannot find a particular implementation, I can still extend the support to any type of Activity, Fragment, etc that I'm looking for.

Yep, actually, the ViewState implementation already works like that by providing a delegate. Have a look at ViewStateManager and  ViewStateSupport. Maybe I should rename ViewStateManager to something like ViewStateDelegate and rename methods  to match activity / fragments lifecycle names to make it more clear how to use them.

Yes, please rename to make them more clear with the design pattern.
Igor
On Apr 27, 2015 4:06 PM, "Hannes Dorfmann"<EMAIL_ADDRESS>wrote:

Yep, actually, the ViewState implementation already works like that by
providing a delegate. Have a look at ViewStateManager and ViewStateSupport.
Maybe I should rename ViewStateManager to something like ViewStateDelegate
and rename methods to match activity / fragments lifecycle names to make it
more clear how to use them.
—
Reply to this email directly or view it on GitHub
https://github.com/sockeqwe/mosby/issues/14#issuecomment-96799511.

I have written a new blog post which describes how to use the delegate.
http://hannesdorfmann.com/android/mosby-playbook/
See "Tip 22" (scroll down to the end of the page)

@sockeqwe  your blog page show 404 error :D is there any example for dialogfragment in your project?

@siavashabdoli I have updated the linke: http://hannesdorfmann.com/android/mosby-playbook
No there i no example project, but dialogfragments doesn't behave differently than any other fragment.

@sockeqwe  Yes, I see but we can't extend your library class directly in this one. I have to implement MvpViewStateDelegateCallback and implement attaching detaching and all MVP logic, is it right?

@sockeqwe I read your blog post and understand how to use the delegate. However, your example code for a DialogFragment uses a custom view. Where should I call the delegate.onViewCreated(View, Bundle) method if I'm overriding onCreateDialog(Bundle) instead?

@sockeqwe I see that we use a MvpViewStateDelegateCallback in the document. Is this only available in mosby3?

@SuperThomasLab
sorry, I have missed your comment / question, somehow I have accidentally muted this thread.
I think it works if you just use onCreateDialog(Bundle) for the dialog title etc. onCreateView(...) for your main custom view.  I have never tried it.
@liuzhen2008  it might have been renamed in Mosby3 (or moved into another package, but it there is the same class also in Mosby 2 (and Mosby 1).
I have to update the docs #185

@sockeqwe Any idea what the name is in mosby2?
I see BaseMvpDelegateCallback or FragmentMvpDelegate. Is this it?

I think it was MvpViewStateDelegateCallback  (must be implemented by your Fragment or Activity) ActivityMvpViewStateDelegateImpl and FragmentMvpViewStateDelegateImpl where you have to forward (delegate) the lifecycle events to.

@sockeqwe Are you planning on adding base implementations for DialogFragment or should it be handled by developer by design?

Not planned to add a DialogFragment base implementation for MVP, MVP ViewState and MVI (mainly because of time constraints) but if such a base implementation is that straight forward as it is with any other Fragment (just adding the corresponding delegate) then we can add it to this library.
Do you wanna send a pull request?

If I'll manage to implement it I'll surely make a PR, but currently (sadly) I just need a fast working solution for my specific MVP case for my work so please do not consider it 'incoming asap' :). Btw, big thanks(!) for your work with Mosby, awesome blog posts, The Context podcast and everything! 👍

Thank you very much!
If you use traditional Fragment lifecycle callbacks and setup your Dialog's view in Fragment.onCreateView() I would expect that simply adding the delegate like I did here works.

I'm not sure if it is a good idea to even add this to mosby. It's yet another thing to maintain and I can't imagine how busy someone like @sockeqwe must be anyways. The suggested solution of adding the delegate worked with no problems. If anyone stumbles upon this and wants to copy paste an implementation for MVI check out this gist.


Add Troubleshooting slow Requests page to Navigation

Hi docs,
We want to add this page in main docs webpage.
Pivotal story: https://www.pivotaltracker.com/story/show/136064321
Regards
@swetharepakula && Shash

Looking good @shashwathi   Thanks!
Should this appear as a link on the main page too? You can put in a PR for that too if you like (master_middleman/source/index.html.md.erb)

@shashwathi, we submitted a separate pr for @jncd's suggestion. thanks.


crond: can't execute '/bin/bash' for user root

Hi Adrien,
The cronjob does not run properly for me on the latest release 2.12.0, and is giving the following error in docker log:
2019-05-13 13:12:00 [18] | crond: can't execute '/bin/bash' for user root
2019-05-14 01:12:00 [18] | crond: can't execute '/bin/bash' for user root
I have resolved it by adding the bash package to the Dockerfile.
Let me know if you would like a PR.
Charles

I could not reproduce your problem, but installing bash is anyway really useful, in particular with arbitrary scripts that can be executed now using DEPLOY_HOOK.
And now bash is installed thanks to your PR #47, so I close the issue.


Missing DI IKeyEncryptionKeyResolver registration in ProtectKeysWithAzureKeyVault methods

This is my bad, I missed this before.
AzureKeyVaultXmlDecryptor depends on the IKeyEncryptionKeyResolver dependency, and this isn't being registered in these overloads.
This fixes that.

Thanks @jsquire . Any new package versions planned soon?

Your timing is uncanny.   Both data protection packages were released today.


kbfs team folder "split"

We've run into an issue with a KBFS team directory, where one of my co-workers isn't able to see the current contents of the directory, and I'm not able to see files and directories that she created. I am, however, able to see the directories I've created from my other devices (computer at home, iPad, etc.)
I just created log 3a5d98ed911c22f33263ae1c, if it contains anything useful.
Note that this issue has been going on since before I installed the debug build (see https://github.com/keybase/kbfs/issues/1700 for details).

There doesn't seem to be anything wrong with the device you sent the logs from.  Can you please send logs from the other device of your co-worker that isn't seeing an up-to-date view, and paste the log ID here?  I'l get to it as soon as I can, but it might take me a day.

Here is the ID: d8c41dbd751f87c0a1b10e1c

Curious whether this could somehow be related to https://github.com/keybase/client/issues/13256 ... the "work laptop" mentioned in the other ticket is the same device as in this ticket.


Feat/dtoss 4076/mesh retrival function

Description
Add scheduled ReceiveMeshMailbox Function to get payload from mesh mailbox and send to the azurite blob sample-container.
Added associated shared functions to support the ReceiveMeshMailbox function.
Added unit tests for the ReceiveMeshMailbox function.
Updated CICD pipelines to include dependencies for mesh mailbox client in build and test.
Context
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-4076
Type of changes

[ ] Refactoring (non-breaking change)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)

Checklist

[ ] I am familiar with the contributing guidelines
[ ] I have followed the code style of the project
[x] I have added tests to cover my changes
[ ] I have updated the documentation accordingly
[x] This PR is a result of pair or mob programming

Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

[ ] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Can you rename the PR title to follow the naming convention, please


No docs for Assertion Functions

Bug Report
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#assertion-functions
https://www.typescriptlang.org/docs/handbook/2/narrowing.html nor https://www.typescriptlang.org/docs/handbook/2/functions.html doesn't mention this feature.
🔎 Search Terms
Assertion Functions, docs

It is mentioned in https://www.typescriptlang.org/docs/handbook/2/narrowing.html#assertion-functions nowadays, fixed by https://github.com/microsoft/TypeScript-Website/pull/2446 a month after your issue :)


pyproject.toml: add appdirs keyword

This will help people find this project on pypi.

Could one of the maintainers add appdirs keyword to the https://github.com/platformdirs/platformdirs, please?


Get.testMode = true is ineffective

unable to run navigation test as Get.testMode is ineffective
`     test("test description", () async {
  SplashScreenController controller = SplashScreenController();
  await controller.fetchData();

});

`

Please provide a reproduction code

Steps to reproduce
SplashScreenController
import 'package:deggia_regular/ui/route/route_names.dart';
import 'package:deggia_regular/ui/views/home/home_screen.dart';
import 'package:deggia_regular/utils/locator.dart';
import 'package:flutter/material.dart';
import 'package:get/get.dart';

class SplashScreenController extends GetxController {
  StorageService storageService = locator<StorageService>();

  @override
  void onInit() {
    super.onInit();
    fetchData();
  }

  Future fetchData() async {
    Get.testMode = true;
    bool isFirstTime = await storageService.firstTime();
    if (isFirstTime) {
      await storageService.setFirstTime();
      await Get.offAndToNamed(RouteName.on_boarding);
    } else {
      await Get.offAllNamed(RouteName.homepage);
    }
  }
}

group("first_time_load", () {
    setUp(() {
        var service = StorageServiceMock();

  when(service.firstTime()).thenAnswer((realInvocation) async => true);
  when(service.isLightMode()).thenAnswer((realInvocation) async => true);

  locator.registerFactory<StorageService>(() => service);
    });

    test("test description", () async {
      SplashScreenController controller = SplashScreenController();
      await controller.fetchData();
    });
}
)

I'm also running into an issue with this. I am hoping this is a quick thing to fix. Here's what I found from the commits
testMode was added in this commit
The checking of this value appears to have been removed in this commit
If I'm reading this history correctly, checking testMode here should resolve it? I'm unfamiliar with the justification behind the commits listed though, I could be misunderstanding how this feature is supposed to work now!


Set the job name, args and provider_job_id on Jobba

… when a lev routine is called with perform_later
Requires https://github.com/openstax/jobba/pull/2

OK going to remove set_job_args from here.


Update nginx.conf to run over HTTP

removing SSL listener and config to run nginx over HTTP. Use case is for offloading SSL to a higher stack (CDN or Load Balancer) and run web tier without requiring a local cert to be present.

First, thanks @saltysoup for using Aphelion and making a pull request as well!  We looked at the proposed change and wanted to provide a reason why we enforced SSL.  We wanted to make sure that we protect the traffic between LB/CDN -> Web Server (hosting the UI), hence the use of HTTPS.  When we deploy this on AWS, we do have LB with HTTPS turned on and we also make sure the traffic between LB and NGINX is secure.
Now, we could also make SSL optional.  Any thoughts on this?

hi @kood1, the reason for my thoughts on making SSL optional was because it makes initial deployment and testing much simpler and quicker.
I understand that in a normal scenario, you'd want to implement SSL to encrypt traffic either directly on the web facing Aphelion web server and possibly between the ALB + Web Server. However, my thoughts are that a lot of people (like myself) would be interested in testing the solution first to see how it works, and then depending on initial feedback and experience, decide to spend more time in integrating it or 'productionizing' aphelion.
With the default SSL settings in nginx.conf, this doesnt work when you deploy it in a docker container within ECS or behind an AWS load balancer; unless you go and create a new certificate such as Let's Encrypt on the Web Server docker image or instance (which adds more overhead and more likelihood of saying 'this is all too hard' and abandoning further tests).
Ultimately, I think its a decision for you and the Finra team on sacrificing SSL options to allow quicker and easier testing (adoption) of the solution vs. building in security mechanisms for best practice (at the cost of additional overhead for initial deployement + risk of abandonment).
Thank you for taking the time to read my comment, very cool product by the way;- I've showed it to a few of my customers and they seemed excited about it as well!

Hi @saltysoup thanks for the details. We think it is definitely important to have quicker and easier adoption of the solution, with reasonable defaults. We will go ahead and merge this PR.
However, we want to provide an option to turn on SSL, via configuration for production usage too. We will work on this enhancement in the coming weeks.
Also, we are still working on setting up automated builds to push the docker images. Do you need these changes immediately in the docker images ?

hi @lathanagaraj  its OK I pulled the web docker image, edited out the SSL conf and created a new image (which I've used in ECS). Not sure if you want to take the SSL conf out in the default image or maintain 2 different copies (might mean more maintenance overhead moving forward though).


Update app.js

Issue #, if available:
Description of changes:
How Has This Been Tested:
[x] My testing has passed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

AWS CodeBuild CI Report

CodeBuild project: nodejs-build-cloudfront-extensions
Commit ID: 6675a674934c83fa4065b5466f198b55fb7a27b7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: nodejs-build-cloudfront-extensions
Commit ID: e69dcc6f136b023c270b73df6148dc5b2eb24313
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Re-enable attachment replication tests

Overview
These tests were disabled because they weren't passing, but the underlying issue has since been fixed.
This commit re-enables the tests.
COUCHDB-3174

Checklist

[x] Code is written and works correctly;
[x] Changes are covered by tests;
[x] Documentation reflects the changes;
[x] I will not forget to update rebar.config.script
with the correct commit hash once this PR get merged.

+1


[Bug]: Gsheet unsupported option are in bold

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Gsheet does not support Insert sheet and hence the option was in grey and in the current ADS it is observed that it is displayed in bold.
Steps To Reproduce

create a Gsheet data source
Authorise the data source
click on Add Query
Select Insert one
Navigate to select the entity
and observe that unsupported is also highlighted in blood

Public Sample App
No response
Environment
Release
Issue video log
No response
Version
cloud

Marking this as low effort as a guess, considering this was working before and seems to have regressed.

This is an old issue. Not the unsupported option are light and cursor is disabled on them.

@rohan-arthur should we close this issue ?


Build timekeep.rc for all targets and set owner of RTC node

on shinano we also build timekeep
build the init rc also for these targets so that it is always at the same level

Hi @jerpelea !
Can you please take a look at this and merge it?


v0.138.4

Patch release containing these commits
And these PRs:

https://github.com/dependabot/dependabot-core/pull/3326
https://github.com/dependabot/dependabot-core/pull/3337
https://github.com/dependabot/dependabot-core/pull/3301
https://github.com/dependabot/dependabot-core/pull/3327
https://github.com/dependabot/dependabot-core/pull/3319
https://github.com/dependabot/dependabot-core/pull/3329
https://github.com/dependabot/dependabot-core/pull/3338
https://github.com/dependabot/dependabot-core/pull/3339
https://github.com/dependabot/dependabot-core/pull/3344
https://github.com/dependabot/dependabot-core/pull/3349
https://github.com/dependabot/dependabot-core/pull/3331
https://github.com/dependabot/dependabot-core/pull/3352

Looks like https://github.com/dependabot/dependabot-core/pull/3351 snuck in also.
Would be nice to have something in place to prevent this from happening or rejig our workflow. This has happened a few times recently with release PRs waiting for CI.

Would be nice to have something in place to prevent this from happening or rejig our workflow

Small change: we could just tag from the branch's tip instead of tagging the merge commit?
Bigger change: orienting around GitHub releases  might be interesting - this "double-check my release notes" style of PR could perhaps be a "draft release".
For this build in particular I'm going to stick with tagging the merge commit as I don't fear https://github.com/dependabot/dependabot-core/pull/3351 (it actually sounds rather useful!). Thanks for flagging.


Update hyperlink to redux-devtools repo

Updating the hyperlink to reflect the new redux-devtools repo location.
Before opening a pull request, please ensure:

[x] You have followed our contributing guidelines
[x] Double-check your branch is based on dev and targets dev
[ ] Pull request has tests (we are going for 100% coverage!)
[ ] Code is well-commented, linted and follows project conventions
[ ] Documentation is updated (if necessary)
[ ] Internal code generators and templates are updated (if necessary)
[ ] Description explains the issue/use-case resolved and auto-closes related issues

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)
IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0%) to 99.679%

Totals

Change from base Build<PHONE_NUMBER>:
-0.0%

Covered Lines:
250

Relevant Lines:
250

💛  - Coveralls


Serialize / save wallet ?

Hi.
does this support serializing or persisting the wallets in a db ?
I could not figure that out by checking the code but maybe I overlooked it.
thanks.

The CLI saves wallet and account data in a yaml file.


Fix DNS provider names in README

typo and letter case

+1 on the AWS name fixes
-1 on Hurricane - I would just delete the abbreviated version, leave just "Hurricane Electric DNS".

Done.


Can't seem to get past the "sign-in without a password next time" page

Describe the bug
This library works great if it doesn't run into the "sign-in without a password next time" page:

What version of MintAPI are you using?
Name: mintapi
Version: 1.65
Summary: a screen-scraping API for Mint.com
Home-page: https://github.com/mintapi/mintapi
Author: Michael Rooney
Author-email<EMAIL_ADDRESS>License: The MIT License
Location: c:\users\xxx\appdata\roaming\python\python38\site-packages
Requires: keyring, selenium, xmltodict, requests, configargparse, oathtool, selenium-requests, pandas
Required-by:
What command[s] did you run / steps to reproduce?
was just trying to log in to my account
Stacktrace/error received:
N/A
What did you expect to happen?
Should click "Skip for Now"
What actually happened?
Got stuck on this page
Additional context
Add any other context about the problem here.

Running on Windows 10

Sometimes it also looks like this:

@sparky2708 this will be addressed in the next major version. If you run off of the main branch of the repo instead of off PyPi, you will have this situation handled.


Detect Pluto notebooks files in tutorial

Thanks for the template it's very helpfull to make reproducible papers!
I just wonder if you would be open to add the possibility to add julia scripts that are not Pluto notebooks in the tutorial folder? I can make a PR if you're interested.
Thanks again!
PS: here's our use case if you're wondering:
We have a script that does a benchmark and a notebook for displaying the code and the results. We don't want to make the benchmark inside the notebook because it would take forever on Github's servers (and Pluto adds time), but we want people to be able to perform the benchmark if they want to, and we need to have it close to the notebook code, so inside the tutorial folder.

Thanks for the template it's very helpfull to make reproducible papers!

I'm happy to hear that

I just wonder if you would be open to add the possibility to add julia scripts that are not Pluto notebooks in the tutorial folder?

So, you mean before running the notebook to check whether it is a Pluto notebook? That already happens if you avoid specifying the files, that is, use
build_notebooks(BuildOptions(dir))

instead of
build_notebooks(BuildOptions(dir), files)

see
https://github.com/rikhuijzer/PlutoStaticHTML.jl/blob/d3698bf9618e78986702dd2380ff5d604f2b722a/src/build.jl#L358-L380

We don't want to make the benchmark inside the notebook because it would take forever on Github's servers (and Pluto adds time)

How long is forever by the way? Especially since you mention that Pluto adds time. If your benchmark takes an hour, adding a few minutes for the Pluto runtime shouldn't be too bad. If your benchmark time is below an hour, then maybe running it in CI isn't too bad as long as you ensure that caching works.

Hoo I'm sorry I'm running an older version of the Tutorial 🤦. Sorry for the inconvenience.
The benchmark is not taking so long using the script, something like 10-20min, but when running from Pluto it was stuck even after one hour so I just killed it. Maybe I'm doing something wrong... I have to say we benchmark our package that is in Julia, another one in Julia but based on a Python package, and another one in R. So a lot of ways to fail. Right know I'm struggling to make Python work on the github action.

Hoo I'm sorry I'm running an older version of the Tutorial facepalm. Sorry for the inconvenience.

No problem :slightly_smiling_face:

The benchmark is not taking so long using the script, something like 10-20min, but when running from Pluto it was stuck even after one hour so I just killed it. Maybe I'm doing something wrong...

I've had that happen to me too once.  I have to say we benchmark our package that is in Julia, another one in Julia but based on a Python package, and another one in R. So a lot of ways to fail. Right know I'm struggling to make Python work on the github action.

Then I said nothing. Getting R and/or Python to work in GitHub Actions is terrible!


Observation: Message on tedge/errors is recently missing when we are not connected

Describe the bug
This is an observation about functionality that has recently changed and that was detected by two system-tests.
Not sure if the tests needs to be updated or else.
Usually, when we caused a parsing error e.g. with this: sudo tedge mqtt pub tedge/measurements { then we received a complaint on topic tedge/errors when tedge-mapper-c8y was running.
Recently, it looks like we really need to connect to C8y to get the same error message on the error topic.
To Reproduce
These two tests were testing the behavior:
pysys.py run tedge_mapper_c8y_positive
pysys.py run tedge_mapper_c8y_negative

Expected behavior
Test should pass or be fixed.
This could be achieved by subclassing the test to EnvironmentC8y.
Screenshots
First approach. We connect before causing an error:
sudo tedge connect c8y
sudo tedge mqtt pub tedge/measurements {

On MQTT:

Second approach: we only start the tege-mapper-c8y service and then cause the error (no
sudo systemctl start tedge-mapper-c8y.service
sudo tedge mqtt pub tedge/measurements {

On MQTT:

I think the tests need to be updated.

tedge-mapper-c8y tries to get its c8y object ID by using JWT token and HTTP request at the mapper start-up.
If the device is not connected c8y, the retrieval fails.
There is no use-case, which sending some Thin Edge JSON measurements to Cumulocity mapper without connecting to c8y (in other word, without having c8y mosquitto bridge confiugration).

Updating the tests is simple. We would just loose the opportunity to test the mapper in isolation (or we invent test-doubles for the JWT things : )

Oops I haven't seen the last message. Here is a draft PR that makes the test connect https://github.com/thin-edge/thin-edge.io/pull/967 . Lets decide how we continue with the message loop in advance.

We will fix to make the two loops (JWT token loop and translation loop) work independently.

Before proposing a solution, here a description of the root causes of this issue.

MQTT and HTTP aspects are tangled due to the protocol used by c8y.
When there is no MQTT connection to c8y, the tedge mapper cannot send data to c8y via HTTP - because a JWT token must be requested via MQTT.
Furthermore, to post an HTTP request to c8y one needs an internal id of the device - and this internal id has to be retrieved via HTTP.
The c8y mapper try to get the internal id on start before doing anything else. So if there is no MQTT connection to c8y when the c8y mapper starts, it is stuck in this init loop. Requesting the internal id only when required just pushed the issue a bit further. If the device is not connect to c8y via MQTT when HTTP is required for the first time - say because an event needs to be sent over HTTP, then the mapper will be stuck in a loop trying to get a JWT token.
Storing the internal id + JWT token once retrieved might help - but if there is no MQTT connection, then there is no way to have a fresh JWT token, hence HTTP connections will start failing too.
The main difference between MQTT messages sent by the mapper and the HTTP requests posted by the mapper is persistency. The MQTT messages are persisted by the local MQTT broker, while the HTTP requests are lost when the mapper fails to post them - hence the infinity loop that is the root cause of this issue.

As a summary.

If the c8y bridge is down, then there is no point posting an HTTP request to c8y.
When the bridge is down, the c8y mapper must either fail or postpone and persist any request that requires HTTP.
When the bridge is up again, the c8y mapper must send all the pending requests that require HTTP.

This ticket has expanded from the original description. The integration tests have switched to robot framework so I feel it is no longer applicable. Closing.


Annoying reminders in Telegram when channel.db > 7 GB

I think it's very annoying to receive a reminder every 5 minutes and it spams telegram unnessecarily!
Personally an hourly one would be sufficient and a symbol ⚠ could be added to give it more expression!
Maybe also an option in config.json could be made to set the interval manually...
it , or even an option

As a workaround edit api/constants.js, on line 70 change urgent: 5 * 60 to urgent: 60 * 60.  this will set it to an hour. then jet restart daddy.
you'll need to git checkout -- api/constants.js prior to git pull.

Thanks for the quick workaround :-)


Added a "note" in tf.where as workaround for issue #38349

Can you fix build errors?
    tensorflow.python.framework.errors_impl.InvalidArgumentError: Value for attr 'T' of int32 is not in the list of allowed values: bfloat16, half, float, double, complex64, complex128
    	; NodeDef: {{node Sqrt}}; Op<name=Sqrt; signature=x:T -> y:T; attr=T:type,allowed=[DT_BFLOAT16, DT_HALF, DT_FLOAT, DT_DOUBLE, DT_COMPLEX64, DT_COMPLEX128]> [Op:Sqrt]

@codeadmin-peritiae Can you please check @mihaimaruseac's comments and keep us posted ? Thanks!

@codeadmin-peritiae, Any update on this PR? Please. Thanks!

@codeadmin-peritiae, Any update on this PR? Please. Thanks!

@gbaned, I really don't understand why a couple of build fail because of a string definition... In any case, I'm still working on it... thank you.

The docstring also has testable code. That code runs and can fail

The docstring also has testable code. That code runs and can fail

I red the error details and I found the issue was probably a type mismatching.
I was trying to check my code fixing before to submit a PR update. This was time consuming...
I take the opportunity to ask a suggestion:
Is it reasonable to try to make code checks "locally" on my machine, before to update PR code; or there is no alternative and code checks have to be completed by the TF continuous integration platform after a PR update?
Thank you

You can always test locally, bazel test //tensorflow/path/to:test

@codeadmin-peritiae Can you please check @mihaimaruseac's comments and keep us posted ? Thanks!

You can always test locally, bazel test //tensorflow/path/to:test

... not so easy :-)
In any case, I updated the PR.
Thank you.


Generate a client.

Client is working for unary calls, needs tests for error conditions.

Some further tests added, remaining tests will need to be made against an HTTP server that does not use a real Protean HTTP handler.

Done


Consistent use of H5, HDF5, VP, VPTS, PVOL in documentation

Update authors and copyright holder

All changed to HDF5


Need some help understanding new violation

Hi! First of all: thanks for building and maintaining this software, I have found it very useful 👍
This week I was updating one of my dependencies and ran into a new violation. This puzzles me because the kind of dependency that is now seen as a violation has been present in the same files for months, without any problems. Can you try to help me understand why this would suddenly be a problem?
It is a public repository, an example of a PR causing the errors can be found here: https://github.com/barryvanveen/blog/pull/305.  The PR updates laravel/framework. In the PR you can also see my deptrac config file, which I have updated a bit once I noticed the new naming that was introduced.
Files in app/Infrastructure/Console/Commands/ extend a class vendor/laravel/framework/src/Illuminate/Console/Command.php.  These are files in layer Infrastructure depending on a file in layer Framework. According to my config this should be allowed. Still it breaks.

All 8 errors are variations on "Error: App\Infrastructure\Console\Commands\ImportData must not depend on Illuminate\Console\Signals (Infrastructure on Framework)".
And this is the bit that puzzles me. When I comment it out any usages of Illuminate\Console\Signals, I still have many other examples of Infrastructure depending on Framework code. And somehow, then it is fine and I have no violations.

Any help would be greatly appreciate, I just can't see the problem 😅

I am taking a look. Having some trouble getting a " non-compiled" version running so that I can step through the deptrac code as it is generating the violations. But I am on it. It just might take some time. Please be patient.

@barryvanveen I got it. The Illuminate\Console\Signals class is marked with the @internal annotation. Therefore any reference to it outside of the layer itself is always marked as a violation.

Hi @patrickkusebauch, thank you for investigating, I could not have figured that out by myself 🙏
If you don't mind, can you help me understand exactly why this is a violation of the layer boundaries?
I have a console command class called CreateUser that is part of the Infrastructure layer. It extends a class called Command that is part of the Framework layer. The Command class has trait InteractsWithSignals that uses code with the @internal annotation.
To me, it feels like my Infrastructure code uses Framework code, which is okay according to my configuration. Is the problem that my code extends the Framework code? I know for certain that no part of CreateUser explicitly interacts with the annotated code.

I would discourage you from extending classes and using traits across layers. Why? Well, what does it mean to do either of those things? It means the code in the trait or parent class is also part of the child class. Therefore any calls to internal classes will fail.
Basically code in "InteractsWithSignals" is as good as code directly in "Command". And any code directly in "Command" is as good as in "CreateUser".
Now this is the puritan way that forces you into a certain design mindset that you might not like. The "problem" here is Symfony design and forcing upon you inheritance. That's just not a good design, if you want to separate layers like deptrac does.
It up to you if you want to either ignore deptrac or decouple Symfony from your application.

I like the puritan way that deptrac helps to enforce. It makes it very visible how the dependencies run and I have to be explicit in when to allow a violation and when not. Thank you for your help!


Ask a question. why don't we use one  statefulset to manage all clickhouse server pods?

one StatefulSet  with one clickhouse pod, it's more flexible configuration than multiple pods per one StatefulSet,
please read https://github.com/Altinity/clickhouse-operator/issues/167#issuecomment-533470927


Migrating to Terragrunt when previously using the -state option

My Terraform state file is currently stored separately from my templates, because the state file is specific to the environment (e.g. production vs. QA/staging) but the templates are not (generally speaking). Therefore, when I run Terraform with local state, my scripts always specify the -state option.
I'm now trying to migrate to remote state using Terragrunt. When Terragrunt runs terraform remote config, there doesn't seem to be a way to pass the -state option such that it's used by remote config but not by the actual command. This results in a Terraform error:
export TERRAGRUNT_CONFIG=/opt/deploy/state/dev/.terragrunt
cd /opt/deploy/generated/dev && terragrunt refresh -state=/opt/deploy/state/dev/terraform.tfstate -var-file=dev.tfvars
[terragrunt] 2017/01/24 09:58:10 Reading Terragrunt config file at /opt/deploy/state/dev/.terragrunt
[terragrunt] 2017/01/24 09:58:10 Initializing remote state for the s3 backend
[terragrunt] 2017/01/24 09:58:10 Configuring remote state for the s3 backend
[terragrunt] 2017/01/24 09:58:10 Running command: terraform remote config -backend s3 -backend-config=key=terraform.tfstate -backend-config=encrypt=false -backend-config=region=us-east-1 -backend-config=bucket=my-bucket
Remote configuration updated
Remote state configured and pulled.
[terragrunt] 2017/01/24 09:58:13 Attempting to acquire lock for state file dev in DynamoDB
[terragrunt] 2017/01/24 09:58:13 Attempting to create lock item for state file dev in DynamoDB table terragrunt_locks
[terragrunt] 2017/01/24 09:58:14 Lock acquired!
[terragrunt] 2017/01/24 09:58:14 Running command: terraform refresh -state=/opt/deploy/state/dev/terraform.tfstate -var-file=dev.tfvars
Failed to load state: Remote state found, but state file '/opt/deploy/state/dev/terraform.tfstate' also present.
[terragrunt] 2017/01/24 09:58:15 Attempting to release lock for state file dev in DynamoDB
[terragrunt] 2017/01/24 09:58:15 Lock released!
exit status 1
[terragrunt] 2017/01/24 09:58:15 exit status 1

It seems like I need to run terraform remote config manually with the -state option as a one-time migration, and then never pass it to Terragrunt. Since this wasn't immediately obvious, perhaps it would be worthwhile to document this case? Ideally, Terragrunt could provide a way to perform the remote config explicitly (i.e. with -state, but without running any other command) based on the settings in .terragrunt, including creation and configuration of the S3 bucket, if necessary. I tried running terragrunt remote config, but it refuses to do anything:
Instead of manually using the 'remote config' command, define your remote state settings in .terragrunt and Terragrunt will automatically configure it for you (and all your team members) next time you run it.

That behavior makes sense unless -state is being specified.

Since this wasn't immediately obvious, perhaps it would be worthwhile to document this case?

Good point! We should definitely have a "migrating state to Terragrunt" section in the Readme. PR's for that are very welcome!

Ideally, Terragrunt could provide a way to perform the remote config explicitly (i.e. with -state, but without running any other command) based on the settings in .terragrunt, including creation and configuration of the S3 bucket, if necessary.

Agreed. Perhaps we need a terragrunt terragrunt-init command that:

Prompts you for the location of your current state (if any)
Prompts you to enter where you'd like state to be stored
Prompts you to specify if you'd like to enable locking
Based on all this info, terragrunt executes any necessary remote config commands and (optionally) generates the .terragrunt file for you.
The command could also support various command-line flags so you can run it non-interactively.

A PR for that would also be very welcome!


Pytest Debugging: Cannot read property 'testsuites' of null

Issue Type: Bug
Hi,
I have issues when I try to debugg the pyton tests (using pytest). Debugging is started from the VC Code test GUI.
It was working well without any problems and then all of a sudden, without any VSCode updates, without pytest version update or changing any other python package used in the venv.
When tests are started from the test gui, they all execute and work well, show the correct test status. The issue is only when debugging and the only error message that is outputed is: Error: TypeError: Cannot read property 'testsuites' of null.
Tried as well with the latest version of pytest (6.2.4) and running the latest VS Code version (1.58.2), but it still behaving the same.
Could it be maybe due to a certain extension? Just saw in python extension changelog that the latest update from 2 days ago vas related to debugging.
Thanks!
VS Code version: Code 1.58.2 (c3f126316369cd610563c75b1b1725e0679adfb3, 2021-07-14T22:10:12.490Z)
OS version: Darwin arm64 20.5.0
Restricted Mode: No

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.35GB free)

Process Argv
--crash-reporter-id 81dc5ac2-167c-4b36-b980-418dc32ad0a0

Screen Reader
no

VM
0%

Extensions (19)

Extension
Author (truncated)
Version

aws-toolkit-vscode
ama
1.27.0

vscode-simpler-icons
dav
1.6.5

gitlens
eam
11.6.0

vscode-pull-request-github
Git
0.28.0

gc-excelviewer
Gra
3.0.42

vscode-graphviz
joa
0.0.6

MagicPython
mag
1.1.0

vscode-docker
ms-
1.15.0

python
ms-
2021.7.1053846006

vscode-pylance
ms-
2021.7.5

jupyter
ms-
2021.8.1054968649

remote-containers
ms-
0.187.1

vsliveshare
ms-
1.0.4583

autodocstring
njp
0.5.4

material-icon-theme
PKi
4.8.0

preview-vscode
sea
2.2.5

rf-intellisense
Tom
2.8.0

pdf
tom
1.1.0

vscode-icons
vsc
11.5.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
pythonvspyt639:30300192
pythontb:30283811
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
pythonvssor306cf:30341832
bridge0708:30335490

/extPython


Windows 10 dark mode support

Enable Windows 10's dark mode titlebar. It will also switch from dark to light and vice-versa as the option is changed in Windows' settings.

Thank you for supporting the project! 🎉
We will review your pull request and integrate it into the source as soon as we can.


document $alias in hook script

When the hook script is run, $alias contains the real name of the certificate directory in $CERTDIR. This is useful to know when the domain is a wildcard like "*.my.com", but as far as I can tell it's not documented anywhere.

I'm currently reworking the documentation and examples completely so I'm closing all issues and pull requests that only change those files, thanks anyway!
The "hidden" variables will be documented as well.


[DO NOT MERGE] [TEST] Testing Hugging Face docs

Again another attempt to see how these docs work. Maybe I should try stuff locally. But this is temporary.

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   55.35%   55.35%
=======================================
  Files         102      102
  Lines        2598     2598
=======================================
  Hits         1438     1438
  Misses       1160     1160

Flag
Coverage Δ

#unittests
55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955c8df...85868ba. Read the comment docs.

Yeah the thing is I am unsure if CI build for draft PRs if I push changes.

Deleted in Favour of #200


Sometime textures have some artifacts

Maybe something  iswrong with dma channel 0?

Fixed by adding DC_FlushRange before glTexImage2D
But what causes this bug?


feat: Added Expr.all and Expr.any to Dask

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[x] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #637
Closes #

Checklist

[x] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.
I used all_horizontal_test.py to run tests. All tests pass.

@FBruzzesi any_all_test.py now runs successfully without xfails.