Locking down the visual F# codebase

Hi,
we are at the part of our release cycle where we become very hardcore about which changes we accept into the codebase.  The reason we do this is that we do not want to run the risk of breaking the product build, and losing valuable days of product testing for cosmetic changes to the code.
We do still want bug fixes and changes that tangibly improve the customer experience of the product are very much valued at this time.  However, cosmetic changes, cosmetic refactoring, renaming of files will have to wait until v.next.
Over the years we have lost many days of product testing due to build breaks that the developer and all of the code reviewers were convinced shouldn't have hurt anything, and so we get paranoid about now.  That is why we raise the bar on check-ins the closer we get to release.
Please continue to look over the bug list, investigate the issues and try to find fixes.  We aim to ship with the highest quality we have ever achieved.
Thank you

Good! the release is near :smile: , but can we have a vnext branch pls?
I know the focus is on fsharp4, np about that ( i need to push a pr for a bug btw :D ) but can you create an unstable branch or use master for vNext? vnext pr are annoying because two months from now we need to rebase and retest another time.
Let's use master as vnext:

branch fsharp3.1 from master ( fsharp3.1 = stable branch for 3.1)
merge fsharp4 in master

now master can accept pr for vnext (netcore/cleanup/features), and fsharp4 is locked down for next version. Also no need to change build server or anything
Some features/bugfix cannot enter fsharp4 ok, but wait more months is not needed

A related issue.
Can we create an high level roadmap pls? wiki/github page, maybe some github milestones for backlog/fsharp4/vnext and highlevel issues (netcore/asp.net vnext/big features/ideas)?
Or a chat with team+contributors and a log.
Different people can help with different skills.
Someone can contribute with an improvement or features for next version but is not going to help with bugfix on fsharp4.  I think that's ok if this does not create regression on fsharp4 release.
I know i cannot fix some fsharp4 bugs (i focus on vs extension/crossplat for now because i need to understand the codebase).
I can try to fix some, but others are going in next version (too much refactoring/etc).
I know we already discussed it in #265 and other issues for next version like #334 #323 #262 #264 #263  etc but with no actionable results (issues are sleeping with discussion tag)
Now fsharp4 is bugfix only, but some bug can be fixed with new features (like folders in vs project) and some other need to be future prof (like my, useless now, port of test suite to nunit, but that's ok, i not asked before start implementing it).
This need only a bit of communication, a project is not only small bugfix, otherwise is boring


Fix typo in stackoverflow-dark.js

Duplicate of https://github.com/react-syntax-highlighter/react-syntax-highlighter/pull/524


guard-nanoc is slower than old nanoc autocompile

I recently upgraded to Nanoc 4, and started using guard-nanoc. However, the time it takes guard-nanoc to find a change and recompile the relevant documents seems longer than what nanoc autocompile previously did for me.
I think this falls apart in two challenges:

speeding up nanoc compilation in general (especially when very few things have actually changed)
caching more things in memory with guard-nanoc

Regarding the first point, I have some ideas (that I should perhaps post in the nanoc issue tracker).
Regarding the second point, I wonder to what extent guard-nanoc itself can be optimized to behave more like nanoc autocompile did?
My previous workflow was to keep nanoc autocompile running, make a change, then watch the browser (which would autoreload as I saved a file). Unfortunately, I cannot do this anymore with the latest Nanoc, as reloading is just too slow.

@RubenVerborgh Is this still an issue as of the current release-4.2.x branch?

I will verify this week and let you know!

It seems ok!


🗺 Add Fastly to CLI options

Progress

[ ] RFC: #4613
[ ] PR: #4860

Related Issues

#2888

#4841 is now merged, which will provide new extra config options (serverConditions, serverMainFields & serverMinify) that can be used to implement this instead


!!!! WIP !!!!! add admin interface

@biilmann could you take a look at this?
 I went with one like this for now. If I did it the other way I would refactor the shared code into methods (which could be painful).
I was also thinking we should write a wrapper (see what I did in Authlify) around the context. It will expose things like 'isAdmin', 'log', 'claims' directly.

@biilmann could you help me with 2 things:

[ ] serializing Data back to the client. I can't seem to get it to work. I think that it is surrounding issues with loading the data from the DB
[ ] updating line items. If we have already done any processing on  an order (paid/shipped) we shouldn't let them update anything here. Only if both states are in pending

And then I wanted to talk about how we would best acquire and lock the system. We have a bunch of mutations that will mess with an order. We need to make sure that they don't collide. I am thinking of having an ID lock? Some way to ensure that I don't just trample on other data. What do you think?


Set fs._unpatched when patching the 'node:fs' module

This allows inspecting the unsandboxed view of the file system if it's needed, such as for writing other sandbox guarding logic.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update MovieClip frame immediately with gotoAndPlay #3180

Employs the same approach for updating the current frame and invoking the onFrameChange callback as gotoAndStop()

Looks good to me.
If I could change anything, it would be to turn part of that into a function
if (previousFrame !== this.currentFrame)
 {
   this._texture = this._textures[this.currentFrame];
   this._textureID = -1;

   if (this.onFrameChange)
   {
     this.onFrameChange(this.currentFrame);
   }
}

That part of code is called 3 times now.
Would be nicer if it read something like
if (previousFrame !== this.currentFrame)
{
  changeFrame();
}

On each occasion. That way if we need to update the changing frame behaviour, we're not fixing it in 3 places!

Thanks @themoonrat - good suggestion! Update committed.

nice work fellas 👍


Druid 31.0.0 release notes (WIP)

Release and upgrade notes for Druid 31.0.0
This PR has:

[x] been self-reviewed.

See https://github.com/apache/druid/pull/17092


Helm: remove init container/volume as they are no longer required

Closes #1261
This PR removes the init container and volume/volume mount from the DaemonSet as they are no longer required.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.80%. Comparing base (ca5f23e) to head (f6305a9).
Report is 1 commits behind head on main.

:exclamation:  There is a different number of reports uploaded between BASE (ca5f23e) and HEAD (f6305a9). Click for more details.
HEAD has 3 uploads less than BASE

Flag
BASE (ca5f23e)
HEAD (f6305a9)

oats-test
1
0

k8s-integration-test
1
0

integration-test
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1273       +/-   ##
===========================================
- Coverage   80.42%   52.80%   -27.62%
===========================================
  Files         132      133        +1
  Lines       13535    13596       +61
===========================================
- Hits        10885     7179     -3706
- Misses       2133     6038     +3905
+ Partials      517      379      -138

Flag
Coverage Δ

integration-test
?

k8s-integration-test
?

oats-test
?

unittests
52.80% <ø> (-0.26%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Nice initiative! I'd keep this PR "on hold" for a while until we release a new major/minor version of Beyla, to keep supporting a feature that is required in Beyla 1.8.

@mariomac I guess this can be merged now that 1.9 has been released?

@marevers yeah thank you!


Implement YAML configuration

It might be a good idea to support both path->claims and claim->paths kind of configuration to support both CBAC and RBAC scenarios.


Mistake in Destructor example

Location: https://github.com/rougier/CPP-Crash-Course?tab=readme-ov-file#32destructor
Issue: In main, that should be Foo foo; instead of Foo foo(); (which will give a "most vexing parse" error").

Thanks. Can you make a PR?

@rougier Done! Opened PR #6


fix typo

Minor rewording

@CharlesCZ Please squash your commits into one. Thanks.

@CharlesCZ Please squash your commits into one. Thanks.

squashed

/lgtm
/approve


Demo isn't working

First of all, thank you for building a React wrapper for zbar.wasm!
Now, onto the problem: I've tried everything (Chrome/Safari on macOS/iOS), and I even attempted to replicate it in my Next.js app, but I'm not getting any output. I also tried different types of barcodes (Code 128/EAN), but nothing seems to work. Is there currently an issue with the demo?
I hope you can help me,
Simon

The demo current only supports qr_code, this is due to my options config, if u wanna support code_128, u need to set format in options;
Here is a demo:
import React from 'react'
import { BarcodeScanner } from 'react-barcode-scanner'
import "react-barcode-scanner/polyfill"

export default () => {
  return (
    <BarcodeScanner options={{ formats: ['code_128'] }} />
  )
}

Oh perfect!
Thank you very much


Rerun make gen

There appears to be some changes missing from main.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 52.342% (-0.005%) from 52.347%
when pulling c5e6f4be4548c6c0c15f64fffb556406de4ba926 on rerun-make-gen
into cee34f884963a0a3a536fef449bb9857f1f8dc9a on main.


[Paid feature] Rewind 💰

Rewind lets you take back your last Like or Nope. If you accidentally passed on someone you wanted to get to know, they are no longer lost in the ~Tindersphere~ VSindersphere forever. Use Rewind to bring their profile back by tapping the yellow arrow icon on the main screen.

https://www.help.tinder.com/hc/en-us/articles/115004493323-Rewind

Yes it is nice idea

Honestly it would be nice if the rewind feature would allow you to look through ALL (or at least last X days) worth of un-matched profile cards to "take another look", rather than just the single previous one. Since this app is still in it's infancy, there are plenty of profiles that haven't really been built out completely, so there's not necessarily anything worth swiping on. Almost wish there was a "skip" or "revisit" in X days option.


feat: tfsec does not support terraform 1.5.0+ check block

Is your feature request related to a problem? Please describe.
We started using the Terraform check block, new to Terraform 1.5.
Unfortunately, tfsec scanning fails because it doesn't know what to do with that block.
$ tfsec $TF_DIR --include-passed $SOFT_FAIL_ARG $MIN_SEV_ARG $CONFIG_ARG -f junit --out "$REPORT_PATH"
Error: scan failed: builds/[REDACTED]/aws/global-policies/networking-shared-permissions-boundary.tf:111,1-6: Unsupported block type; Blocks of type "check" are not expected here.

Describe the solution you'd like
Tfsec should ignore these blocks until you find something worthy of a security finding.
Describe alternatives you've considered

Disable tfsec scanning

Not a great idea, even if we are also scanning with checkov

Don't use aws_iam_policy_document object and store as raw json

Hard to read and maintain, changes to any part of the policy show up in a single line change. Bad idea.

Let it blow up at apply time

Going with this until tfsec supports the new block from Terraform

I have solved this problem by https://github.com/aquasecurity/defsec/pull/1354
Currently waiting for defsec (tfsec dependency) to be released.

This issue will be resolved by merging https://github.com/aquasecurity/tfsec/pull/2060

hey @simar7 I know it's not nice to tag people around, but we have such a nice momentum of people trying the new feature from terraform being blocked by a dependency update on your side. could we have this solved?
from what I saw https://github.com/aquasecurity/tfsec/pull/2084 is the latest PR updating the defsec dependency

Closing as Trivy supports this now.

@simar7 tfsec doesn't yet support new terraform 1.5+ syntax right? Trivy now supports it but tfsec still didn't update the dependency and most importantly release a version that we can use or am I missing something?
If that's the case I think this shouldn't be close yet because the problem is not solved as of now

I agree with what @ilmax said. This issue was ready to be merged but kept being kicked down the road because this issue hasn't been dragged across the finish line.


Add transparency while plotting a result that is not over the whole mesh

Using the following code, we see that transparency is now working while trying to plot a result not over the whole mesh :
from ansys.dpf import core
core.connect_to_server('<IP_ADDRESS>', 50052)
from ansys.dpf.core import examples

filepath = examples.multishells_rst
ds = core.DataSources(filepath)
model = core.Model(filepath)
mesh = model.metadata.meshed_region
stress = model.operator("SX") ## ISSUE 2 # replace by S
stress.inputs.requested_location.connect('Nodal')
s = stress.outputs.fields_container()
mesh.plot(s[1], shell_layers = core.shell_layers.top)

It seems the issue pointed out in #12 is solved. Closing this one.

This should be enabled in an easier way using features of PR #130.


Unpack failed

Unknown error, may be the app is incompatible or may have an environment detection that causes the failure, You can open an Issue on GitHub(https://github.com /CodingGay/BlackDex).

Why is it bringing this


Refined Vision Prompt: Integration of Keyboard Shortcuts over Search Function

✨ Refined Vision Prompt: Integration of Keyboard Shortcuts over Search Function
This PR proposes a significant methodological enhancement to the VISION_PROMPT framework. I'm proposing the PRESS action as a more efficient alternative to the existing SEARCH function. This update is aimed at refining the interaction model to better align with intuitive, real-world navigation methods. The proposed changes underscore several key benefits:

💻 Enhanced Shortcut Utilization: The PRESS action could be a single or a combination of key presses, applicable in any active window that the operator engages with. This approach significantly streamlines navigation across different operating systems by using known shortcuts. This change also offers a more precise and efficient means of interaction:
VISION_PROMPT = """
...
1. PRESS - Recommend keyboard shortcuts for efficient navigation and interaction.
   Response Format: PRESS "{{key combination}}", detailing the specific action's utility.
...
Example Response:
For tasks in Google Chrome:
- PRESS 'Ctrl+T' or 'Cmd+T' to open a new tab.
- PRESS 'Ctrl+L' or 'Cmd+L' to focus the address bar.
- TYPE "{{search term}}".
- PRESS 'Enter' to initiate the search.
...
"""

This is then parsed, the operator will execute:
def press_keys(key_sequence):
 """
 Simulates pressing a sequence of keys.
 """
 keys = key_sequence.lower().split("+")
 # todo: the pyautogui.hotKey(*keys) didn't work as expected, it should be fixed .
 for key in keys:
     pyautogui.keyDown(key)
 for key in reversed(keys):
     pyautogui.keyUp(key)
 return f"Pressed keys: {key_sequence}"

🤷 OS Agnostic Approach: The enhanced VISION_PROMPT significantly improves context awareness. This feature can pick out the operating system and application in use from the provided screenshots, enabling a more adaptive, OS-agnostic functionality. This adaptability ensures that the tool remains universally applicable, irrespective of the user’s operating environment:
VISION_PROMPT = """
You are a hypothetical, OS-agnostic Self-Operating Computer, designed to simulate interaction with any
graphical user interface. Your role is to analyze visual input, provided as a screenshot with a grid overlay, and
suggest a series of simulated actions to accomplish the user's task. While you do not directly execute these
actions, your suggestions aim to demonstrate precision and efficiency, favoring keyboard shortcuts over mouse
interactions wherever possible.

Consider the current screen and the user's objective. Your task is to determine the most efficient simulated
actions, utilizing application-specific shortcuts that are universally applicable across various operating systems.
...
"""

🧠 More Defined Contextual Understanding: The revised VISION_PROMPT now offers a more nuanced and defined approach to understanding and responding to user tasks. This includes a heightened ability to discern specific requirements based on the visual cues within the user interface, leading to more accurate and contextually relevant suggestions.

⚠ Stricter role-play: The revised VISION_PROMPT now offers a stricter role-play to ensure GPT-4V's response aligns with the context:
VISION_PROMPT="""
...
Your ONLY SIMULATED ACTIONS are:
...
"""

I believe by utilizing this change, we can benefit the outlined points; let me know what you think.

@sirlolcat this looks awesome. I agree with the approach. I'll take a look at this PR a little closer and let you know if I have any questions. If you'd like to discuss further, feel free to reach out to me at<EMAIL_ADDRESS>

@joshbickett I appreciate the time you're putting into this. I'll adjust this PR accordingly as its draft, let me know if you want to discuss or change anything.

@sirlolcat this may have some impacts on the vision of the project so we're discussing this PR still. Thank you again for the PR. Hope to have an update soon!

@joshbickett thanks for the update; I appreciate the time and effort you're putting into this, I m open to further discussion. I would be more than happy to help you with the discussion on this.

@sirlolcat wanted to let you know I haven't forgotten this PR! This project got a lot more attention than expecting so we're sorting through priorities, but I'll get to this eventually! :)

Amazing, I can help with benchmarking. Would you like to discuss the approach further first? I'm flexible to putting more time on this. Let me know about it.

https://github.com/OthersideAI/self-operating-computer/assets/42594239/7692eeff-ec2b-4bcc-97bc-23228395df8c
@sirlolcat I reviewed this yesterday but I think I forgot to respond. I think this PR is on the right track, but I have a few additional thoughts.
I typically run two basic test cases over PRs:

"Go to YouTube and play Holiday music"
"Go to Google Docs and write a poem"

PRESS occasionally makes a more optimal action and that was great to see, but it often failed test cases (see video). It appeared the main issue was trying a key command when the right window was not active. Long-term I think this PRESS method could be key to the project. The goal is to emulate how a human interacts with the modern computer via inputs and outputs and this PR progresses us towards that goal.
Additional thoughts.. right now gpt-4-vision-preview is pretty bad at following instructions from my experimenting. I had to play a lot with thinning down the prompt to make it as basic as possible for the model. If you can get this PR to pass these tests cases and a few others I think we could merge it in, but you may find that gpt-4-vision-preview is too basic. With that said I think as models get better this type of prompt you built will work. Let's keep this conversation going and see what we can do!

I am testing out different prompts and testing the results. A bit more changes in vision prompt can improve the results..

Hi @sirlolcat, I am curious if you have any new findings / updates on this PR. Let me know, thanks!

@sirlolcat after hacking around with a lot of methods to get key commands to work, it appears re-architecting the project to use the system_prompt did it. Not sure why I didn't design it originally that way, I think I was sleep deprived lol.
Anyway, I am going to close this PR now that key commands are integrated in the project.


numpy.digitize and awkward arrays

I am trying to use numpy.digitize with awkward arrays but it does not work.
However, it works if I flatten it out. Do you think there is an easy solution for that?
np.digitize(array['my_favourite_variable'], [0, 1, 2])
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-224-e8e74a6ae969> in <module>
----> 1 np.digitize(array_mc_train['abs_pitch_y'], [0, 1, 2])

<__array_function__ internals> in digitize(*args, **kwargs)

~/.local/lib/python3.7/site-packages/numpy/lib/function_base.py in digitize(x, bins, right)
   4813         return len(bins) - _nx.searchsorted(bins[::-1], x, side=side)
   4814     else:
-> 4815         return _nx.searchsorted(bins, x, side=side)

<__array_function__ internals> in searchsorted(*args, **kwargs)

~/.local/lib/python3.7/site-packages/numpy/core/fromnumeric.py in searchsorted(a, v, side, sorter)
   1294
   1295     """
-> 1296     return _wrapfunc(a, 'searchsorted', v, side=side, sorter=sorter)
   1297
   1298

~/.local/lib/python3.7/site-packages/numpy/core/fromnumeric.py in _wrapfunc(obj, method, *args, **kwds)
     59
     60     try:
---> 61         return bound(*args, **kwds)
     62     except TypeError:
     63         # A TypeError occurs if the object does have such a method in its

ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

Not broken per se— the issue is that numpy.digitize is not a ufunc. We take advantage of NEP 13 (adopted in Numpy 1.13.1) to override the behavior of all Numpy ufuncs, which are 1 input → 1 output functions that are mapped across whole arrays (input array shape = output array shape). numpy.digitize doesn't have exactly this interface.
>>> numpy.digitize
<function digitize at 0x7fd644f29ae8>
>>> numpy.sinh
<ufunc 'sinh'>

There is a proposal in the works, NEP 18, that would provide a mechanism for overriding all Numpy functions, not just the ufuncs. It is now provisionally accepted and has just been added to Numpy 1.17, but I haven't looked into how I would use it yet. (It would only work for a subset of users—those who upgrade to Numpy 1.17.)
By the way, this was a copy-pasted answer from issue #13. Unlike that case, numpy.digitize really could have been a ufunc and I don't see why it isn't. After all, "digitization" is just an affine transformation followed by floor, and each of those steps is a ufunc. You could do those steps manually:
numpy.floor((array*scale) + offset).astype(numpy.int64)

This is made entirely out of ufuncs (*, +, numpy.floor; the astype is not a ufunc but is implemented for all awkward arrays), so it should be applicable on any array. Given that, there's a good argument for awkward having a built-in digitize that does the above, depending on when I manage to add NEP 18.

Thank you for your answer. Your proposal should work fine, but I believe only for equally spaced bins. If the bins are not equally spaced then the affine transformation depends on the bin itself and I don't know if you can write with this ufuncs.

I see—that's why numpy.discretize is not a ufunc. I was surprised by that because anything that can be a ufunc should be, since that provides the most capabilities. If you don't have too many levels, you could do it with masks, but none of these are great options.
Without ufuncs, you can unwrap and re-wrap a JaggedArray: get the content, apply the Numpy function, and put it in a new JaggedArray with the same starts and stops.

It worked, thank you very much, and it is a good workaround for all the numpy functions that are not ufunc! I hope in the future, thanks to NEP18, the process will be simplified!


Shift some test pipelines to use codebuild resources

related to https://github.com/AdoptOpenJDK/openjdk-build/pull/1571
We can run tests on Codebuild machines, so we should verify that all tests can run on those dynamically spun up machines, and leverage those resources.
Grinders:
functional tests: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Simple/29
openjdk tests: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Simple/30
Currently those resources have 'codebuild' label, and only xlinux platform (potentially aarch64 and windows to come), so we could use an "||codebuild" ADDITIONAL_LABEL for xlinux platform and see how that flows.

@gdams @johnoliver - please let me know when we are clear to start utilizing codebuild resources (i.e., when token stuff cleared up).

Closing this as no longer required, there is also the option to use Azure resources.


Profile adds

Jan Schenk
Ian McDonald
Fixup for Bartolo

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/anthony-bartolo.yml
:white_check_mark:Succeeded
View

advocates/ian-mcdonald.yml
:white_check_mark:Succeeded
View

advocates/index.html.yml
:white_check_mark:Succeeded
View

advocates/jan-schenk.yml
:white_check_mark:Succeeded
View

advocates/map.yml
:white_check_mark:Succeeded
View

advocates/media/profiles/ian-mcdonald.jpg
:white_check_mark:Succeeded
View

advocates/media/profiles/jan-schenk.png
:white_check_mark:Succeeded
View

advocates/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Build error on 0.6.1-SNAPSHOT

https://gist.github.com/marker68/54ba84fa9cf1d1165e7be88aaf1a35d6
Since 0.6.0 isn't available at maven now, I tried to build from source and got this error.
Environment:
Mac OS X 0.11
Intel core i5
$ clang++ -v
Apple LLVM version 7.3.0 (clang-703.0.29)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

It looks like your libnd4j copy is outdated. Pull master, and build it before nd4j, and you'll be fine.


'NoneType' object has no attribute 'aenter' when using cosmos client. It works for the initial calls but then it starts failing and returning this error

I am using Cosmos database in my code and i am able to save some info in a container I want sometimes, other times it fails.
I call the method submit feedback where i use my cosmos client with "async with" and it seems like for some calls the client gets closed and has the value None and then i get this error when i try to save my feedback.
I saw this issue in other thread "session of AioHttpTransport is None at runtime, despite what's ruled out from typing #32309" but I did not found the solution. Please don't redirect me to that one.
I will provide some parts of my code
from azure.cosmos.aio import CosmosClient
from azure.cosmos import exceptions as cosmos_exceptions
from approaches.approach import Approach
from approaches.chatreadretrieveread import ChatReadRetrieveReadApproach
from approaches.chatreadretrievereadvision import ChatReadRetrieveReadVisionApproach
from approaches.retrievethenread import RetrieveThenReadApproach
from approaches.retrievethenreadvision import RetrieveThenReadVisionApproach
from config import (
CONFIG_ASK_APPROACH,
CONFIG_ASK_VISION_APPROACH,
CONFIG_AUTH_CLIENT,
CONFIG_BLOB_CONTAINER_CLIENT,
CONFIG_CHAT_APPROACH,
CONFIG_CHAT_VISION_APPROACH,
CONFIG_GPT4V_DEPLOYED,
CONFIG_INGESTER,
CONFIG_OPENAI_CLIENT,
CONFIG_SEARCH_CLIENT,
CONFIG_SEMANTIC_RANKER_DEPLOYED,
CONFIG_USER_BLOB_CONTAINER_CLIENT,
CONFIG_USER_UPLOAD_ENABLED,
CONFIG_VECTOR_SEARCH_ENABLED,
# CONFIG_COSMOS_CLIENT,
)
CONFIG_COSMOS_CLIENT = "cosmos_client"
...
@bp.route("/submit-feedback", methods=["POST"])
async def submit_feedback():
try:
if not request.is_json:
return jsonify({"error": "Request must be JSON"}), 415
    request_json = await request.get_json()

    # Validate required fields
    feedback_text = request_json.get("feedbackText")
    Liked = request_json.get("Like_or_Dislike")
    question = request_json.get("question")
    answerContent = request_json.get("answerContent")
    citations = request_json.get("citations")

    print(feedback_text,Liked,question,answerContent)

    logging.info("Feedback text: %s", feedback_text)
    logging.info("Liked: %s", Liked)
    logging.info("Question: %s", question)
    logging.info("Answer content: %s", answerContent)

    if not feedback_text:
        return jsonify({"error": "Missing required fields: feedbackText"}), 400

    if not Liked:
        return jsonify({"error": "Missing required field: isLiked"}), 400

    if not question:
        return jsonify({"error": "Missing required field: question"}), 400

    if not answerContent:
        return jsonify({"error": "Missing required field: answerContent"}), 400

    # Get the Cosmos DB client from the app configuration
    cosmos_client = current_app.config[CONFIG_COSMOS_CLIENT]
    if cosmos_client is None:
        logging.error("Cosmos DB client is not configured")
        return jsonify({"error": "Internal server error cosmos client"}), 500

    AZURE_COSMOSDB_DATABASE = os.getenv("AZURE_COSMOSDB_DATABASE")
    AZURE_COSMOSDB_CONVERSATIONS_CONTAINER = os.getenv("AZURE_COSMOSDB_CONVERSATIONS_CONTAINER")

    if not AZURE_COSMOSDB_DATABASE:
        logging.error("AZURE_COSMOSDB_DATABASE environment variable is not set")
        return jsonify({"error": "Internal server error"}), 500

    if not AZURE_COSMOSDB_CONVERSATIONS_CONTAINER:
        logging.error("AZURE_COSMOSDB_CONVERSATIONS_CONTAINER environment variable is not set")
        return jsonify({"error": "Internal server error"}), 500

    async with cosmos_client:
        database = cosmos_client.get_database_client(AZURE_COSMOSDB_DATABASE)
        container = database.get_container_client(AZURE_COSMOSDB_CONVERSATIONS_CONTAINER)

        # Create a feedback document
        feedback_document = {
            "id": str(uuid.uuid4()),
            "feedback": Liked,
            "feedbackText": feedback_text,
            "question": question,
            "answerContent": answerContent,
            "citations": citations,
            "timestamp": datetime.datetime.now(datetime.timezone.utc).isoformat(),
        }

        try:
            await container.upsert_item(feedback_document)
        except Exception as e:
            logging.error(f"Error upserting feedback document: {e}")
            logging.error(traceback.format_exc())
            return jsonify({"error": f"Internal server error: {e}"}), 500

        return jsonify({"success": True, "message": "Feedback successfully recorded!"})

except Exception as e:
    logging.error(f"Error in /submit-feedback: {e}")
    logging.error(traceback.format_exc())
    return jsonify({"error": str(e)}), 500

...
@bp.before_app_serving
async def setup_clients():
cosmos_client = CosmosClient(
url=f"https://{AZURE_COSMOSDB_ACCOUNT}.documents.azure.com:443/", credential=AZURE_COSMOSDB_ACCOUNT_KEY
)
print(f"Cosmos client: {cosmos_client}")
current_app.config[CONFIG_COSMOS_CLIENT] = cosmos_client
These are parts of the backend (app.py) of my flask app
Thanks !

hi @TomasHipolito, this seems like there might be an error in the way things are getting saved in your application - I am not quite sure how the cosmos_client would be NoneType with the check you have before. When you debug this, what is the cosmos_client object?
One way you may be able to go around this is to include await client.__aenter__() in your setup_clients() in order to intialize the client without using async with in the next piece of your code. This might help with initializing the client in a separate context, but the question of why it is NoneType seems to me like an application-level bug, not an SDK one.

Hi @simorenoh.
Thanks for the reply ! I managed to solve my issue. Besides creatng the client in the setup_clients() in the @bp.before_app_serving , i also included the creation of the cosmos client in my submit_feedback() function in the @bp.route("/submit-feedback", methods=["POST"]) and also close it there.
So everytime i call the methof submit_feedback() it creates and closes a cosmos client. I kept the initialization of the client in the setup clients, ut for some reason the cosmos client was being closed so I found this workaround.

Closing since Tomas seems to have been resolved - if anything else comes up do let us know and we'll be happy to help out. Thanks!


Avoid results being subject to ETH price fluctuations

Is there a way to just input a fixed value for gas fiat price estimation?
I like looking at $ values, since they are easier for me to process. When optimising functions it's hard to tell whether a change was good or bad, since I tend to look at the dollar values, but then I have to figure out whether it might've just been a jump in the eth/usd price.
Why not have the option to just input a fixed price for reference (say 4k$ eth, for example)? This would remove the need for registering with an api and would allow for a better reference for testing.
Or even better: show the prices in eth cost, instead of some currency. I currently don't see an option for this.

Nice idea, but perhaps rename the issue title "Avoid results being subject to ETH price fluctuations" so that it's clearer what you want.  To check my understanding, you are proposing at least one of the two new features:

feature to fix ETH price so that fiat prices can be displayed without fluctuations over time
showing prices in ETH, skipping currency

Exactly. And yes, that title does bring it to the point

Agree on this. Price in ETH are much more convenient to get the difference.

In the latest version you can do this by setting the tokenPrice option as below:
tokenPrice: "1"

https://github.com/cgewecke/hardhat-gas-reporter/releases/tag/v2.0.0


Add Energy and randomize price

Todo:

Randomize Energy Prices
Buy Solar, Wind and Batteries
Time of day (morning 75, noon 100, afternoon 75, evening 50, late evening 25, midnight 0, early morning 25)
Weather changes
Solar output
Wind output

Open:

Randomize Price
Update View


How to deal with polyfills working for IE11, suddenly breaking

Category

[x] Question
[ ] Typo
[ ] Additional article idea

Question
This is somewhat between a bug and a question. Over at https://github.com/microsoft-search/pnp-modern-search/issues/576 we got logged an issue that the web parts suddenly fail to load in IE11. The "culprit" is a core.js polyfill.

The issue is most likely something new OOB trying to define the same polyfill, and thus it breaks. This was not previously present on a modern page so all was good. Now something has shipped OOB, defining this for IE11, thus it breaks when trying to redefine it.
I know IE11 is not a focus area, but how do we best deal with global defines missing in 3rd party, when 1st party suddenly adds it to the mix. Ensure we add a check first for all polyfills in case the import doesn't do it right? No one is to blame, and 1st party will evolve and include libs not originally there, but maybe we should have some SPFx advice around this area?
Error message
Something went wrong
If the problem persists, contact the site administrator and give them the information in Technical Details.
Technical Details
[SPLoaderError.loadComponentError]:
Failed to load component "42ad2740-3c60-49cf-971a-c44e33511b93" (SearchResultsWebPart). Original error: Failed to load entry point from component "42ad2740-3c60-49cf-971a-c44e33511b93" (SearchResultsWebPart). Original error: Error loading https://component-id.invalid/42ad2740-3c60-49cf-971a-c44e33511b93_3.14.1
Cannot redefine non-configurable property 'includes'

Environment details (development & target environment)

Your Developer Environment: [Windows 10]
Target Environment: [ SharePoint Online]
Framework: [Node.js v10]
Browser(s): [IE v11 | Edge | Chromium Edge v79]
Tooling: [VS Code | SPFx v1.10.0]

Went for a workaround instead.


Add odo preference set PushTimeout / pod timeout configuration

What kind of PR is this?

/kind feature
/kind enhancement
What does does this PR do / why we need it:
Adds the ability to set your own pushtimeout, being able to configure
how long to wait for the push to time out.
For example:
odo preference set PushTimeout 30

Will set the default pod timeout to 30 seconds.
Which issue(s) this PR fixes:
Fixes #943
How to test changes / Special notes to the reviewer:
odo create nodejs
odo preference set PushTimeout 1
odo push

Signed-off-by: Charlie Drage<EMAIL_ADDRESS>

@cdrage @kadel I think the term pushTimeout is more suited than podTimeout (pointed out in https://github.com/openshift/odo/issues/943#issuecomment-436576072) as the user might not be familiar with the term pod.

Thanks @mik-dass I've updated it to reflect that :) !

2019/11/27 21:00:02 Submitted failure event to sentry (id=25330b1e62124c4faa164d17776a9028)
error: could not run steps: step integration-e2e-benchmark failed: template pod "integration-e2e-benchmark" failed: the pod ci-op-jnpf6y69/integration-e2e-benchmark failed after 42m30s (failed containers: setup, test): ContainerFailed one or more containers exited

/retest

Thanks @dharmit and @mik-dass I've updated the PR again (see the new commit)

Installing from release registry.svc.ci.openshift.org/ci-op-rjylqw8h/release@sha256:0412c61324b7ac2f603b1148e052eb39606eb89ee3b09bb1a273c17d798732fd
level=warning msg="Found override for release image. Please be warned, this is not advised"
level=info msg="Consuming \"Install Config\" from target directory"
level=info msg="Creating infrastructure resources..."

/retest

/lgtm


[Bug] no-resolve compatibility issue

Verify steps

[X] I have read the documentation and understand the meaning of all configuration items I have written, avoiding a large number of seemingly useful options or default values.
[X] I have not reviewed the documentation and resolve this issue.
[X] I have not searched the Issue Tracker  for the problem I am going to raise.
[X] I have tested with the latest Alpha branch version, and the issue still persists.
[X] I have provided server and client configuration files and processes that can reproduce the issue locally, rather than a desensitized complex client configuration file.
[X] I have provided the simplest configuration that can reproduce the error I reported, rather than relying on remote servers, TUN, graphical client interfaces, or other closed-source software.
[X] I have provided complete configuration files and logs, rather than providing only parts that I believe are useful due to confidence in my own intelligence.

Operating System
MacOS, Windows, Android
System Version
general issue
Mihomo Version
https://github.com/MetaCubeX/mihomo/commit/38fd37108b22b0e937cae7743c562a2147c65cca
Configuration File
rules:
  - IP-CIDR,<IP_ADDRESS>/16,no-resolve

Description
Users used to configure as:
rules:
  - IP-CIDR,<IP_ADDRESS>/16,no-resolve

But with the changes in https://github.com/MetaCubeX/mihomo/commit/38fd37108b22b0e937cae7743c562a2147c65cca, such a config style will no longer work with the build of the alpha branch.
I personally understand that - IP-CIDR,<IP_ADDRESS>/16,direct,no-resolve is a better format, but there are still a lot of existing rule sets configured in this style, i.e., the famous ACL4SSR.
I think with such a breaking change, we should throw a more conspicuous error message, instead of error: proxy no-resolve not found, and what's more, it's better to provide compatibility for the old style.
Logs
No response

cc @wwqgtxx

The format of IP class routing rules has always been type, content, proxy, additional parameters (optional). Are you sure your example is correct?

The format of IP class routing rules has always been type, content, proxy, additional parameters (optional). Are you sure your example is correct?

I don't know the history of this, but the rule set I'm using for years is in this format, and it works well for a long time:
https://github.com/ACL4SSR/ACL4SSR/blob/master/Clash/Providers/LocalAreaNetwork.yaml#L14-L25

The format of IP class routing rules has always been type, content, proxy, additional parameters (optional). Are you sure your example is correct?

I don't know the history of this, but the rule set I've used for years is in this format, and it works well for a long time:
https://github.com/ACL4SSR/ACL4SSR/blob/master/Clash/Providers/LocalAreaNetwork.yaml#L14-L25

The rule-provider and rules are not the same thing

Well, it seems to be pretty much the same thing, incompatible with the old:
https://github.com/MetaCubeX/mihomo/commit/763a127287697fe471f0e643e3bd3f5abfad85e9#diff-eb7196056bcd4b0f538c50fb88e2d11a4c61befa15277a4321a8c0cc95e858dcR82-R84

The rule-provider and rules are not the same thing.
Do not use the content of the rule-provider for rules.


v-html not working with iframes

Vue.js version
2.0.2
Reproduction Link

~~http://jsfiddle.net/df4Lnuw6/~~
http://jsfiddle.net/joeinnes/36x7yvyf/1/
Steps to reproduce
Add an iFrame into a v-html rendered field
What is Expected?
The iframe should render
What is actually happening?
Not clear - looks like Vue tries to render itself into the iframe.

Hi, thanks for filling this issue. Your repro link doesn't seem to show the problem, please fix it.

Apologies, corrected the fiddle to http://jsfiddle.net/joeinnes/36x7yvyf/1/

The iframe is rendering fine here.
http://jsfiddle.net/L092crg4/
Also your original src won't work inside jsfiddle, so I changed it to bing.com

The original src might be what's causing the problem. I'll double check when I get home.

Yes, that was it. I'm sorry, I didn't read the src carefully enough, I believed it was a normal twitter embed frame, but it looks like there's some kind of custom Ajax call in there that's breaking the rendering.
Apologies for wasting your time.


Can't specify rootElement using npm import

I'm using NPM and installed the 1.0.8 version of d3-v6-tip. I'm trying to specify a different element where I can append the tooltip (for style reasons), but it's still attaching to the document body.
The code I'm using is this
this.tip = d3tip()
      .attr('class', 'd3-tip')
      .rootElement(document.getElementById('graph'))
      .html((EVENT, d) => d.tooltip.replace('_x', d.x).replace('_y', d.y))

but I'm receiving the following error
index.js:157 Uncaught TypeError: Object(...)(...).attr(...).rootElement is not a function

Can you please help me? I don't want to load this library as a standalone library, so I'm trying this road. Thank you very much

There is no such method  rootElement in the API and nor it is planned to be added.
Not sure about your reasons though, can you elaborate more? What styling reasons you mean?

The reasons aren't important I think. The problem is that in your library you declare the following code
var direction = d3_tip_direction,
        offset = d3_tip_offset,
        html = d3_tip_html,
        node = initNode(),
        svg = null,
        point = null,
        target = null

    function tip(vis) {
        svg = getSVGNode(vis)
        point = svg.createSVGPoint()
        document.body.appendChild(node)
    }

While in the original tip library the code is this
var direction   = d3TipDirection,
        offset      = d3TipOffset,
        html        = d3TipHTML,
        rootElement = document.body,
        node        = initNode(),
        svg         = null,
        point       = null,
        target      = null

    function tip(vis) {
      svg = getSVGNode(vis)
      if (!svg) return
      point = svg.createSVGPoint()
      rootElement.appendChild(node)
    }

With this problem, I can't specify a custom rootElement.
The style areasons are only for my personal file organization, so I can put scss in the same component I attach the tooltip

Interesting - I think it was removed at the second iteration of this library
https://github.com/cgav/d3-tip/blob/master/src/index.js
Here is a history

Currently, I am not sure about that method, I don't know how it works, and nor I have time to check it deeply

If you can find a time to fix this issue, please create a PR and include working example so I can check it as well and if everything  will look all right, I will merge it

ok I wil open a PR with the working example, hoping to help your project 😄

To be honest, I don't consider this project mine, my part will be less than 1 %, compared to the whole effort

I don't know hot to attach a working example, as in a JSFiddle I can only import the actual version of the d3-v6-tip package. Have you got any idea on how to make this? Thanks


Functions have no argument at call site despite having the correct signature

Version and Platform (required):

Binary Ninja Version: 3.0.3233 Personal
OS: MacOS
OS Version: 12.4
CPU Architecture: M1

Bug Description:
Functions have no arguments where they are called, even though Binja correctly find all parameters.
I'm making a an architecture plugin for an embedded architecture and found this weird behaviour where Binja find the correct function signature but then fails to apply it at the call site.
Function signature:

LLIL:

HLIL(broken):

I found this discussion where another user was having the same issue.
I tried creating a calling convention but that doesn't really help since this architecture doesn't have one.
class DefaultCallingConvention(CallingConvention):
    int_arg_regs = ['R0', 'R1', 'R2', 'R3', 'R4', 'R5', 'R6']

Functions using registers in a different order then the one specified generates wrong function signatures.
For example a function using R0 and R4 will also have R1, R2, R3 as parameters.

I might have found a fix.
While messing around with calling conventions I noticed that the registers not specified in the calling convenction were getting the correct type in the function signature and were present in the function call site.
So I created an empty calling convenction and now all functions are displayed correctly at theis call site.
HLIL(correct):

class DefaultCallingConvention(CallingConvention):
    int_arg_regs = []

_arch = binaryninja.architecture.Architecture['Test']
_arch.register_calling_convention(DefaultCallingConvention(_arch, 'default'))
_arch.standalone_platform.default_calling_convention = _arch.calling_conventions['default']

So maybe this isn't a bug, but it's at least unexpected to have Binja fails to display function arguments without at least a warning

We believe this is a documentation issue, rather than an actual implementation issue. However, we'll look into it (and add some documentation regardless). Thanks for the report!


default app via public appstore

It's cool to see that there now seems to be an app and that it's even open source :+1:, but self-compiling seems like an enormous hurdle that only relatively few teams will (be able to) take. Lacking the iOS dev knowledge (and time to acquire it), I'd be willing to trust you guys and use a default app from the public AppStore (and even pay a couple EUR for it)...
If you need this to properly encrypt push messages (as it seems to me) or to deliver push notifications at all, by no means remove this option to self compile, but have a ready to use fallback for easier adoption and smaller / non-iOS dev teams...
Maybe like Threema: don't send the message via push notification but just an ID that something happened... once the app is activated it can fetch the message securely.

The app is now in the app store.

not for me...

I've re-opened the issue.
I'm guessing you're in a non-US app store?  We're in the process of submitting to all countries.

ah ok, i'm in the german app store...
and it is available now... thanks a lot ;)


Ria 2935 pba payment

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RIA-2935
Change description
RIA-2935 PBA Payment
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

I focus on Business part of the feature which is really good. Let's merge this PR and update integration tests and functional tests within next PRs


Zig 13 compatibility

Duplicate of #58

I already made you the zig-0.13.0 branch for zig 0.13.0 support. main branch matches master branch zig.


Packaging for PyPI

Any idea why grammalecte is not on PyPI? it would be nice so we can package padpo with grammalecte as an install dependency.

Based on #5 of @Seluj78, padpo is now on PyPI. You may have a try and give feedback.
For grammalecte, I have no idea. It is not developed with git but with fossil.
I talked to @pofilo who created a mirror of grammalecte on GitHub, we don't have yet an easy solution to get a tagged version of grammalecte-cli in GitHub (which could then be a dependency in the requirements.txt). I don't know why grammalecte is not on PyPI, and, to ask the creator, one has to create an account on the grammalecte fossil (I didn't do that).
I've just uploaded padpo 0.2.0 on PyPI that tries to install automatically grammalecte on first padpo usage.

Nice to hear! Thanks!


fix rmae

Fix to #101
https://github.com/Nixtla/utilsforecast/issues/101

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey. Thanks for your contribution. I had fixed this in a separate branch by doing this:
diff --git a/utilsforecast/losses.py b/utilsforecast/losses.py
index 1c6ec4b..45864f8 100644
--- a/utilsforecast/losses.py
+++ b/utilsforecast/losses.py
@@ -327,16 +327,15 @@ def rmae(
     """
     numerator = mae(df, models, id_col, target_col)
     denominator = mae(df, baseline_models, id_col, target_col)
+    denom_rename = {m: f"{m}_denominator" for m in baseline_models}
+    denominator = ufp.rename(denominator, denom_rename)
+    res = ufp.join(numerator, denominator, on=id_col)
     if isinstance(numerator, pd.DataFrame):
-        res = numerator.merge(denominator, on=id_col, suffixes=("", "_denominator"))
-        out_cols = [id_col]
         for model, baseline in zip(models, baseline_models):
             col_name = f"{model}_div_{baseline}"
             res[col_name] = (
                 res[model].div(_zero_to_nan(res[f"{baseline}_denominator"])).fillna(0)
             )
-            out_cols.append(col_name)
-        res = res[out_cols]
     else:

         def gen_expr(model, baseline):
@@ -348,10 +347,11 @@ def rmae(
                 .alias(f"{model}_div_{baseline}")
             )

-        res = numerator.join(denominator, on=id_col, suffix="_denominator")
         exprs = [gen_expr(m1, m2) for m1, m2 in zip(models, baseline_models)]
-        res = res.select([id_col, *exprs])
-    return res
+    model_cols = [
+        f"{model}_div_{baseline}" for model, baseline in zip(models, baseline_models)
+    ]
+    return res[[id_col] + model_cols]

Can you please do that instead?
About the single baseline, I think we can support the baseline model being a string and repeating that string for each model. That maintains the current behavior and also allows that use case, e.g. rmae(series, models=['model1', 'model2'], baseline_models='model0')

On a second thought, I've never liked the output of the rmae, it's very strange when used in evaluate. I think this is a good opportunity to change the baseline model to be a single string and use it for every model. That way, when used with evaluate it won't add extra columns. It'll still require a change in the evaluate function to append the baseline name to the metric, e.g. rmae_naive or similar, but I can do that in a followup PR.

Both approaches seem good to me.
As long as the most common scenario (baselining several models against one) is easy to do then I think it makes sense.
Should I close this PR then?

If you want to incorporate the suggested changes in https://github.com/Nixtla/utilsforecast/pull/103#issuecomment-2209339010 please go ahead, otherwise you can close it and I'll make them in a separate PR.

Superseded by #105


Adding Super Mario 64 and VVVVVV

I think the idea was to make the SM64 stars local, if I recall.

I argued that they should be local to avoid comparisons to LttP's non-local triforce hunts, but others claimed they aren't comparable. Forcing stars local leaves about 5 checks and really doesn't make sense to have in a multiworld, in my opinion. I'm conflicted because non-local stars goes against suggested goal types for the async, but local stars seem pointless. I'm willing to try non-local once and see how it goes.

Updated game weights, changed random setting for Timespinner to produce parseable results, updated SM64 an V6 to 0.2.5, made Power Stars local.


Validation: Fix missing descriptions

This PR addresses missing descriptions.

Global effort to fix validation errors
@adegeo
The Content & Learning team is fixing build validation errors on docs.microsoft.com. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. I’d very much appreciate your timely review and feedback on these changes I’ve suggested. Thanks!


The Zingo! configuration innappropriately mixes fn parameters with on-disk data

We need to rationalize the Zingo! configuration such that data that belongs in a config file, is there.

Shouldn't ZingoConfig be inside a OnceCell or a OnceLock?


MV and LV wires can't be placed if an HV wire exists on the tile.

How to reproduce;

Place an HV wire on a tile.
Attempt to place an MV or LV wire on the same tile.
You will be unable to do so unless you cut the HV wire first.

Unless this is a balance change I'm unaware of, you've always been able to place any kind of wire on any tile, so long as the wire wouldn't be a duplicate.

note that placing HV wires on tiles with LV/MV still works

Pretty sure this was fixed recently


PX4-ROS-Package - broken?

Hi,
i am trying to compile the newest firmware as ros package. it runs well, but ros doesnt find the package after install. the workspace is ready to use because the other packages build in this catkin_ws are working properly. bash.rc is working.
i am now running an old version from "px4ros". this works.
is ros capabilty broken actually?

@TobiMiller Could you describe what you are trying to achieve with it? We have largely evolved our ROS-facing infrastructure over the last couple of months.

its fixed. the newest px4ros repository is working.
but the mavlink problem still exists.
1.

roslaunch px4 gazebo_ardrone_empty_world.launch

working without erros, gazebo is up and running

roslaunch mavros px4.launch fcu_url:="udp://:14540@<IP_ADDRESS>:14557"

=> connects, but it stops at

[ INFO] [1458132618.198629927,<PHONE_NUMBER>00]: MAVROS started. MY ID 1.240, TARGET ID 1.1

any suggestions? thats the reason why qgroundcontrol dont connect


[Dynamic Regions] workload report 9005: Region is unavailable during one tikv network partition form other tikv

Bug Report

What version of TiKV are you using?
./tikv-server -V
TiKV
Release Version:   7.1.0-alpha
Edition:           Community
Git Commit Hash:   503174b571788f01aef154157cafd53bacd6b860
Git Commit Branch: heads/refs/tags/v7.1.0-alpha
UTC Build Time:    2023-04-04 11:41:26
Rust Version:      rustc 1.67.0-nightly (96ddd32c4 2022-11-14)
Enable Features:   pprof-fp jemalloc mem-profiling portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine cloud-aws cloud-gcp cloud-azure
Profile:           dist_release
2023-04-06T02:45:44.899+0800	INFO	k8s/client.go:132	it should be noted that a long-running command will not be interrupted even the use case has ended. For more information, please refer to https://github.com/pingcap/test-infra/discussions/129
What operating system and CPU are you using?
8c/32g
Steps to reproduce
inject  one tikv network partition form other tikv
https://tcms.pingcap.net/dashboard/executions/plan/1664013
ha-tikv-random-to-tikv-all-network-partition-last-for-10m
http://perf.pingcap.net:3000/d/WOw1JWmVk/ha-test-case-detail?orgId=1&refresh=10s&var-case_id=2851125
What did you expect?
no 9005 error
What did happened?
workload report 9005: Region is unavailable during one tikv network partition form other tikv
[2023/04/06 02:57:42.294 +08:00] [INFO] [collection.go:150] ["[2023-04-05 18:57:42] execute run failed, err Error 9005: Region is unavailable\r\n"]
...
[2023/04/06 03:05:45.240 +08:00] [INFO] [collection.go:150] ["[2023-04-05 19:05:45] execute run failed, err Error 9005: Region is unavailable\r\n"]
[2023/04/06 03:05:45.240 +08:00] [INFO] [collection.go:150] ["[2023-04-05 19:05:45] execute run failed, err Error 9005: Region is unavailable\r\n"]
[2023/04/06 03:05:45.240 +08:00] [INFO] [collection.go:150] ["[2023-04-05 19:05:45] execute run failed, err Error 9005: Region is unavailable\r\n"]
[2023/04/06 03:05:45.241 +08:00] [INFO] [collection.go:150] ["[2023-04-05 19:05:45] execute run failed, err Error 9005: Region is unavailable\r\n"]
[2023/04/06 03:05:45.508 +08:00] [INFO] [collection.go:150] ["[2023-04-05 19:05:45] execute run failed, err Error 9005: Region is unavailable\r\n"]

/type bug
/severity major
/assign tonyxuqqi

@Lily2025 It should be fixed by #14550


Fix shellcheck SC2148 and SC1008

Motivation for this change
Existing issues requesting ShellCheck compliance: #133088, #21166.
This change only prepares for running ShellCheck by indicating which shell ShellCheck should interpret the code (Bash). The same can also be achieved by renaming the scripts to .bash, but that would be much more involved and risky, possibly including changes to other repos which reference scripts by name.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual) N/A
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/) N/A
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I don't understand the ofborg-eval, nor how

This PR does not cleanly list package outputs after merging.

relates to the details of that step. Does anyone have any details?

Looks like nix-build --arg pkgs import ./. {} ./lib/tests/release.nix timeouts because of the rebuilds

Looks like nix-build --arg pkgs import ./. {} ./lib/tests/release.nix timeouts because of the rebuilds

Uh-oh. Maybe I need to make a bajillion PRs instead?

I'm not sure how I feel about this one. It's true that .sh usually means posix shell, but in nixpkgs it's generally assumed that we're using bash-isms everywhere. This shellcheck adds a lot of line noise given that shell=bash is the default for nixpkgs in practice.

Yeah, if I knew it was going to get merged I'd probably rather rename the files and be done with it. Much less noise.

Is there maybe a way to make shellcheck assume bash by default?

Is there maybe a way to make shellcheck assume bash by default?

Yes, --shell=bash. Unfortunately then you have to pick out the false positives from the already huge output.

Is there maybe a way to make shellcheck assume bash by default?

Yes, --shell=bash. Unfortunately then you have to pick out the false positives from the already huge output. A quick ~git grep /bin/sh | wc -l shows 452~ git grep -F '#!/bin/sh' | wc -l shows 101 results…

Do any of those actually use a shell that is not bash?

Yes, --shell=bash. Unfortunately then you have to pick out the false positives from the already huge output. A quick ~git grep /bin/sh | wc -l shows 452~ git grep -F '#!/bin/sh' | wc -l shows 101 results…

Do any of those actually use a shell that is not bash?

How do we verify that programmatically? I can't find any detailed dependency resolution documentation for Nix. Also, running Bash as /bin/sh changes its behaviour, so we'd probably get false positives that way.

If anything uses something except nix-shell -i bash which is rare.
Why can't we patch shellcheck to assume nix-shell is bash? That would be a bit easier and would require less changes.

If anyone is interested: an overlay which makes shellcheck believe nix-shell is bash.
diff --git a/.config/nixpkgs/overlays/shellcheck-nix-shell.patch b/.config/nixpkgs/overlays/shellcheck-nix-shell.patch
new file mode 100644
index 0000000..8745112
--- /dev/null
+++ b/.config/nixpkgs/overlays/shellcheck-nix-shell.patch
@@ -0,0 +1,26 @@
+diff --git a/src/ShellCheck/Data.hs b/src/ShellCheck/Data.hs
+index e22b424..a1417a4 100644
+--- a/src/ShellCheck/Data.hs
++++ b/src/ShellCheck/Data.hs
+@@ -135,6 +135,7 @@ shellForExecutable name =
+         "ksh"   -> return Ksh
+         "ksh88" -> return Ksh
+         "ksh93" -> return Ksh
++        "nix-shell" -> return Bash -- dirty hack
+         _ -> Nothing
+
+ flagsForRead = "sreu:n:N:i:p:a:t:"
+diff --git a/src/ShellCheck/Parser.hs b/src/ShellCheck/Parser.hs
+index 92eb61f..dd7cadb 100644
+--- a/src/ShellCheck/Parser.hs
++++ b/src/ShellCheck/Parser.hs
+@@ -3302,7 +3302,8 @@ readScriptFile sourced = do
+         "dash",
+         "bash",
+         "bats",
+-        "ksh"
++        "ksh",
++        "nix-shell"
+         ]
+     badShells = [
+         "awk",
diff --git a/.config/nixpkgs/overlays/shellcheck.nix b/.config/nixpkgs/overlays/shellcheck.nix
new file mode 100644
index 0000000..09113d1
--- /dev/null
+++ b/.config/nixpkgs/overlays/shellcheck.nix
@@ -0,0 +1,12 @@
+final: prev: {
+  haskellPackages = prev.haskellPackages.override (oldArgs: {
+    overrides = final.lib.composeExtensions (oldArgs.overrides or (_: _: { }))
+      (hfinal: hprev: {
+        ShellCheck = final.haskell.lib.doJailbreak (hprev.ShellCheck.overrideAttrs (oldAttrs: with final; {
+          patches = oldAttrs.patches or [ ] ++ [
+            ./shellcheck-nix-shell.patch
+          ];
+        }));
+      });
+  });
+}

I've set this as a draft, for several reasons:

Most importantly, a better solution would be to rename the files from .sh to .bash, which would clearly indicate to anyone reading it (including tools like ShellCheck) that the shell dialect matters, and that programmers should feel free to use bashisms to improve maintainability, speed, etc.
Someone could fairly easily create one PR per package, which would be much easier to get merged individually.
There seems to be no clear standard for shebang lines in this project. Some scripts seem to use #!/bin/sh when they shouldn't, because they contain bashisms. Others use #!/usr/bin/env bash, #!/usr/bin/env nix-shell plus #!nix-shell -i bash -p …, others again use #!@shell@ or #<EMAIL_ADDRESS>I don't know whether all of these forms are valid, and if so, when they should each be used.

#!@runtimeShell@ Allow to resolve bash at build time. So for wrapper I would prefer using that. For independant script that will not be rebuild /usr/bin/env bash seem better because it choose bash at runtime. #!/usr/bin/env nix-shell with --pure is even better because it show explicitly dependencies of a script but require more work to use this style so just usign env is fine if you only need tools in stdenv like sed/find/cat/cd/mv/...


Distinct in Fetch XML Query seems to be working after all

Dear,
It seems that the List Rows actions does support the distinct operator in the Fetch XML Query.
This in contrast to what is stated in part https://docs.microsoft.com/en-us/power-automate/dataverse/list-rows#fetch-xml-query
The notes (and workaround) can be removed (or kept for reference/alternative)
Best regards,
Koen

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4fae8260-c3b8-4582-884d-72119ab256b7
Version Independent ID: a12c64c0-9293-d86c-91c3-bce01efd1e1b
Content: Use lists of rows in flows - Power Automate
Content Source: articles/dataverse/list-rows.md
Service: power-automate
GitHub Login: @MSFTMan
Microsoft Alias: Deonhe

@radioblazer Do you know if this feature is now fully supported?

Started conversation with Matt T.


Naming rules of helm release name

hi Authors，
I want to know the regular expression of helm chart release name ? Or naming rules. Could you please share it? Thanks.

Hi @septyy
I was actually just discussing this today in my own work, and we found out by passing in an invalid release name.
The regex is in the error output as you can see from the terminal snippet below. I've included the version I'm on.
[/home❯
➤ helm install stable/mysql --namespace test-change --name testT
Error: release name testT is not a valid DNS label: a DNS-1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')
[/home❯
➤ helm version
Client: &version.Version{SemVer:"v2.12.0", GitCommit:"d325d2a9c179b33af1a024cdb5a4472b6288016a", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.12.2", GitCommit:"40665d0724368cb0581288773844b61bdf928791", GitTreeState:"clean"}

I was autogenerating the release name based on multiple parameters and was getting validation errors on the name. The regex in previous comment is correct but it does not take the length limit on the name for 53 characters into account, see below code section. Was ending up in this post after some search and I think it is good to have it written here for other that may end up in the same situation.
https://github.com/helm/helm/blob/9a5eb70320c1c1b7b6f1c5a6f0f5420cb1c934a0/pkg/chartutil/validate_name.go#L55-L78


[SQLiteCpp] update to 3.0.0

Library name: SQLiteCpp
New version number: 3.0.0
Version 3.0.0 - January 31 2020
C++11 is now required
CMake 3.1 minimum
Visual Studio 2015 minimum
Update Googletest to latest release 1.10
Add Github Actions continuous integration solution
Add Valgrind memcheck tool to Travis CI
Remove Statement::isOk() deprecated in 2.2.0 when renamed to Statement::hasRow()
Replace Database::backup() "C" implementation by calling the Backup class
#252 Run Valgrind memcheck on Travis CI
#253 Keep inline functions for GCov code coverage
#254 Re-enable Coverity static analysis
#256 Fix linking with system library (libsqlite3)
#242 Added a getIndex method and used it (KOLANICH)
#257 Improve Statement unit tests coverage (bind by name with a std::string)
#234 support for external sqlite3 (BioDataAnalysis/emmenlau)
#243 adding a pure attribute to getIndex() (KOLANICH)

https://github.com/SRombauts/SQLiteCpp/releases/tag/3.0.0

Thanks for posting this issue. This issue has been fixed. So I am closing this issue for now.


Build argument enable_rlz causes error with GN

Apparently the build argument enable_rlz is not supported anymore. I have seen the error when building several previous versions already.
It does not prevent Chromium from building though.
...
[368/368] LINK gn
  -> Configuring Chromium
ERROR at the command-line "--args":1:522: Build argument has no effect.
symbol_level=0 is_debug=false fatal_linker_warnings=false treat_warnings_as_errors=false fieldtrial_testing_like_official_build=true remove_webcore_debug_symbols=true ffmpeg_branding="Chrome" proprietary_codecs=true link_pulseaudio=true linux_use_bundled_binutils=false use_gtk3=true use_gconf=false use_gnome_keyring=false use_gold=false use_sysroot=false use_system_libjpeg=true enable_hangout_services_extension=false enable_widevine=true enable_nacl=false enable_swiftshader=false enable_nacl_nonsfi=false enable_rlz=false enable_rlz_support=false enable_remoting=false enable_google_now=false safe_browsing_mode=0 enable_hotwording=false enable_print_preview=false custom_toolchain="/tmp/makepkg/inox/src:default" host_toolchain="/tmp/makepkg/inox/src:default" clang_use_chrome_plugins=false
                                                                                ^----
Did you mean "enable_vr"?

The variable "enable_rlz" was set as a build argument
but never appeared in a declare_args() block in any buildfile.

To view all possible args, run "gn args --list <builddir>"
Done. Made 5440 targets from 1266 files in 1343ms
  -> Building Chromium
ninja: Entering directory `out/Release'
...

I can't say when the argument was deprecated, but I created ungoogled-chromium's disable-rlz.patch for Chromium 57. I don't mind if this patch is also included in Inox.
This is going on a tangent, but adding --fail-on-unused-args to gn gen maybe ease the process of upgrading GN flags.

Integrated Eloston's patch in PR https://github.com/gcarq/inox-patchset/pull/90. Closing.


Upgrade AudioKit DO NOT MERGE

Xcode 11.5
AudioKit 4.10.1
remove unneccessary @objc qualifier for AKSynthOne
Builds on device for iOS13.5…need testing for devices on iOS versions < 13

I think this ship has sailed.


feat: parse sgid userinfo data

feat: parse sgid userinfo data
This commit adds a new method, parseData, which helps to parse the
sgid userinfo object so that any stringified array or object values
are parsed as objects.

This commit is implemented according to the SDK implementation
requirements as linked here: https://www.notion.so/opengov/SDK-implementation-requirements-1f9b7cbd2bd4406b85d6645fe3e365dd#dcabe67d14034525bfd5e84acc1c59c6

This commit also adds the necessary unit tests for the newly introduced
utility functions that support parseData

Current dependencies on/for this PR:

develop

PR #69   👈

This comment was auto-generated by Graphite.


'New open access publications' still mentions old OA policy & links to old webpage. Replace by "Ghent University has a policy setting out its vision and guidelines for scholarly publishing."

Story
Replace "Ghent University has implemented an Open Access mandate for scientific publications as of publication year 2010. Learn more" with
"Ghent University has a policy  setting out its vision and guidelines for scholarly publishing."
Current situation:

Desired situation:
https://www.ugent.be/intranet/en/research/impact/schol-publishing/policy-ugent.htm

Implementation suggestion

  Ghent University has a
  policy setting out its vision and guidelines for scholarly publishing
  .

```

fixed


runtime.md: Fix sub-bullet indentation

The indentation of the sub bullets for the status entries under State were not
indented by the 4 spaces required by markdown. They did not render well in
the pdf, at least with my native build with pandoc v1.13.2. Change them to 4
spaces, which now renders well.
Signed-off-by: Graham Whaley<EMAIL_ADDRESS>

Oh wait, adding spaces makes it better in the PDF?

It does for me - in the html also. Without the spaces it was much less clear that those were sub-points to the previous point. I'm having trouble finding a definitive markdown reference (anybody?), but from the random pages I have found I think the requirement is for four spaces or a tab character to increase the level of indentation.

Yeah. Definitive documentation on stuff lack that is lacking
On Thu, Jun 9, 2016, 06:45 Graham Whaley<EMAIL_ADDRESS>wrote:

It does for me - in the html also. Without the spaces it was much less
clear that those were sub-points to the previous point. I'm having trouble
finding a definitive markdown reference (anybody?), but from the random
pages I have found I think the requirement is for four spaces or a tab
character to increase the level of indentation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/opencontainers/runtime-spec/pull/495#issuecomment-224871661,
or mute the thread
https://github.com/notifications/unsubscribe/AAEF6VbpvEQX9MvhT6UIST3VnqC8eVDLks5qJ_zMgaJpZM4Ixy8J
.

On Thu, Jun 09, 2016 at 04:45:16AM -0700, Graham Whaley wrote:

I'm having trouble finding a definitive markdown reference (anybody?)…

From 1:
List items may consist of multiple paragraphs. Each subsequent
paragraph in a list item must be indented by either 4 spaces or one
tab…
I expect that's intended to be read with “block element” instead of
“paragraph”, in which case it's the reference you need.

I did a bit more digging. It is slightly more convoluted...
Looking at the Makefile, pandoc is invoked with the 'from' type as 'markdown_github'. I guess that definitively means the spec is formatted in github flavour markdown (I don't think I've seen that specifically noted anywhere else?). If we go find the github markdown reference:
https://help.github.com/articles/basic-writing-and-formatting-syntax/#lists
then it says:
"You can create nested lists by indenting lines by two spaces."
Thus, I checked how the sub-list in runtime.md looked when viewed:

on github web interface (github rendered)
in the generated pdf
in the generated html
for both the master and the submitted patched version.

In the master version, it looks fine when rendered on github, but both the pdf and html render the sub-list as a 'non-bold' list at the same level of indent using the same style of bullets. On my screen/system at least it is hard to tell the difference from the top level list.
In the patched branch the sub-list is indented and uses a different bullet style, which is much clearer.
So, although technically we could stick to the two spaces as per the github_markdown spec, the docs seem to render much better with four spaces.

LGTM
that does make a big difference for the pdf and html docs. Thanks!

Should we file follow-up PRs for the other instances?  For example
[1,2] (and I imagine there are more).

I imagine this PR could add more. And image-spec needs to be double checked.

LGTM

On Fri, Jun 10, 2016 at 10:41:16AM -0700, Michael Crosby wrote:

Merged #495.

Follow-up PRs it is 1 ;).


Expose server.build to build new model instances from Factories

We'd find it useful to add a build function similar to what exists in Factory Girl in Ruby, so for example you could call var post = server.build('post'); and you get an object with all the properties in the factory without saving it to the DB. Seems like that function already exists here, so we just need to expose it.
@samselikoff  Happy to pick this up and submit a PR if you think it's a good idea.
CC @tundal45

That's interesting. Out of curiosity, what's your use case?

I do think this is a good idea, though you should know with the ORM factories will be building Mirage.Model instances instead of just json. (Those models will have an .attrs property which will expose the json, too.)

@jherdman Our most common use is case is when testing a creation form. We could do var post = server.build('post');, fill in the form fields on the page with attributes from post, and then assert that the object that got saved to the DB is the same.
@samselikoff cool, is that something that is available now or is it progress?

The ORM is in the beta release but the Factory doesn't leverage it yet. That will be the highest priority once 0.2.0 ships. New factories will land in 0.2.1.

Btw I'm not sure factories are the best solution for your use case. Factories are really purposed to seed your database with certain data. Your test sounds more like a user filling in data, which you wouldn't want the factory to be responsible for (I think). I could comment more if I saw the code.

@samselikoff The kind of use we are envisioning is what factory_girl provides. The idea is that var post = server.build('post') would not affect the contents of server.db but give us an in-memory object that we can use.

@tundal45 Yep, that's exactly correct + what I'm modeling mirage factories after. Just to clarify, that in-memory object will be a Mirage.Model (rather than an EmberData.Model).

@samselikoff At least for our use case thus far, we are ok with it being Mirage.Model.

Filing this under the "Ability to make Ember Data models from Mirage factories" card in the Roadmap project.


Add feeds from Versions.props to NuGet.config

We need all restore sources to be located in NuGet.config since internal feeds can only be restored from there. More details including next steps here
/cc @riarenas @jcagme

Can you please take a look @natemcmaster @dougbu

@JohnTortugo, Nate isn't back yet (early August). Best to CC @aspnet/build to get our attention in any case.

Thanks @dougbu !


[CELEBORN-390][FLINK] Refine synchronization in FlinkShuffleClientImp…

…l#updateFileGroup

What changes were proposed in this pull request?
Refine synchronization in FlinkShuffleClientImpl#updateFileGroup.
Why are the changes needed?
To make synchronization more efficient.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT

ping @RexXiong @zhongqiangczq @FMX Please take a look


neovim support?

any way to get this working for neovim?
Currently only get the 256color code for the base2tone-Lake-Dark colorscheme

Added support for true color terminal.
It works correctly in my environment:

macOS 10.11.3
iTerm 3.0.10
neovim 0.1.5 with termguicolors option

Is the problem solved?

solved! thanks!


[WIP] First pass of get_dependencies.

As discussed in the design doc, this PR contains the first pass of the get_dependencies function. Now, every time a cell is run, a map from cell number to code that represents the dependencies is printed.
TODO:

[ ] figure out how to expose this to the user
[ ] tests

I'm going to leave some comments and then merge this -- looks great!


Video start and end time are wrong.

Hi, when I load a video file I got wrong video start and end time.
When I load the example bunny video I got this in the UI:
start 35:00 - end 44:56
Should be:
start 00:00 end 09:56
It's like a wrong offset added. Why this happend?

Android
react-native": "0.62.2
react-native-video": "^4.4.5
react-native-video-controls": "^2.4.0

Android 9.
I am using the example provided in this repo.
This is a screenshot of the video.
https://imgur.com/a/WnNfYf7

the same for iOS


Switch test runner to pytest

I have tested and the following things I need still work:

Local coverage-reports in html when running bare "tox"
Running just a subset of tests, even though the syntax to so is different.

Therefore, I'll be merging this code.
This does NOT mean that existing tests will be rewritten to pytest-style or new tests will be written in pytest-style or pytest fixtures will be used.


When designing any CLI tool, please keep in mind that someone may want to embed it

So, it may make sense to have a lib and a cli tool wrapping the lib.

Yes, of course. I plan implement everything as lib and provide compiler executable in cli subfolder.


update github.com/containers/* dependencies

This implies some changes to the code to adapt to some API changes, and
to change some transitive dependencies that are added or dropped.
Signed-off-by: Valentin Rothberg<EMAIL_ADDRESS>

Fixes: #2196

@vrothberg Thanks for taking care of this one! :+1: I think we will run into some test problems here, which I already tried to fix partly in #2191. I will stop there and give this one precedence. Feel free to reach me out if you need any support... :upside_down_face:

@vrothberg Thanks for taking care of this one!  I think we will run into some test problems here, which I already tried to fix partly in #2191. I will stop there and give this one precedence. Feel free to reach me out if you need any support...

Thanks! I'll apply the changes to the unit tests as well :+1:

Codecov Report

Merging #2195 into master will increase coverage by 51.77%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           master    #2195       +/-   ##
===========================================
+ Coverage   31.48%   83.25%   +51.77%
===========================================
  Files          76       12       -64
  Lines        6797      866     -5931
===========================================
- Hits         2140      721     -1419
+ Misses       4535       99     -4436
+ Partials      122       46       -76

/test e2e_features_rhel

/ok-to-test

LGTM

LGTM

/test e2e_fedora
/test e2e_features_fedora

/test e2e_features_rhel
/test e2e_rhel

/test e2e_features_rhel
/test e2e_rhel
/test e2e_fedora
/test e2e_features_fedora

/retest

Rebasing to master should fix the tests.

/test e2e_rhel
/test e2e_fedora

@saschagrunert @giuseppe @rhatdan can you drop a LGTM?

/lgtm

/approve

@vrothberg Do we want to backport this to the 1.14 release branch?

@vrothberg Do we want to backport this to the 1.14 release branch?

May God have mercy on us :) I think we should backport that to be on the safe side. There is a bunch of fixes in the updated dependencies that we should use.


Make the temp folder for Save-Module configurable

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.

Steps to reproduce
In Azure Functions, we use the Save-Module cmdlet to download the function app dependencies. At times, the modules to be installed are very large and the operation fails because there is not enough space in the temp directory. Having the ability to set an alternative to the temp directory via an environment variable could help us in this scenario. For reference, please see https://github.com/Azure/azure-functions-powershell-worker/issues/771.
Expected behavior
N/A

Actual behavior
N/A

Error details
N/A

Environment data
N/A

Visuals
No response

/cc @anatolib @stefanushinardi

Thanks for opening is issue, we are thinking through how we could light up this experience for you (and other users) without introducing complexity to the interface for other users

After discussing this we decided to make this a parameter on Install-PSResource, Save-PSResource, Update-PSResource the parameter can be called -TemporaryPath


Bumping arcade sim version

The sim was broken by the latest updates to pxt-common-packages and pxt-core and i think it got missed in this commit:
https://github.com/microsoft/pxt-arcade/commit/46042e8020ca487b0a8aae38172b56c9ae626ff5

I have a PR with more changes see jacdac

https://github.com/microsoft/pxt-arcade/pull/2725


[osg-qt]How to import osgQt into project via vcpkg + cmake?

openscenegraph/osgQt#57

I think below contents could be used in cmake when the port installed by vcpkg:
find_package(PkgConfig REQUIRED)
pkg_check_modules(osgqt REQUIRED IMPORTED_TARGET openscenegraph-osgQt)
target_link_libraries(main PkgConfig::osgqt)


New Search Editor focuses results instead of query input when seeded (use focusResults: false by default)

VSCode Version: 1.48.1
OS Version: Mac OS 10.14.6

Steps to Reproduce:

Select text
Open New Search Editor (either via command pallet or key binding)
Cursor jumps to first line of results (summary info, i.e. 1 result - 1 file)

Does this issue occur when all extensions are disabled?: Yes/No
Yes

TL;DR: "focusResults": false might be a more expected default for Search Editor: New Search Editor
Expected Behavior: I expected that upon opening a Search Editor: New Search Editor the query term would be highlighted and the focus would remain on the query term. In the below screenshot I would expect "Foo" is highlighted and the query bar has focus.

Note that when there is no highlighted text this is the behavior when opening a New Search Editor:

I expected this behavior because it is the same behavior as the other two search cases:
Find:

...and Search: Find in Files

This often becomes an annoyance for me because of the following use case:

Have Search Editor: New Search Editor bound to Cmd+Shift+F
Working in a file, happen to have some highlighted text
Realize I might need to make some change in another file, open a New Search Editor w/ Cmd+Shift+F to find out
Highlighted text is searched for automatically
Start typing/paste what was on my clipboard thinking it will override the search term
End up inadvertently editing the search results
Press Esc to get back to the search query
Try typing/pasting again
Eventually try to close the New Search Editor and am modally prompted to save it because I inadvertently edited it earlier
Close the modal w/ mouse or Cmd+D (which I learned because of this, silver linings)

I believe this might be relatively recent behavior that was added w/ https://github.com/microsoft/vscode/issues/95582 and/or https://github.com/microsoft/vscode/issues/97823
Based on those I found that I could get the functionality I expected by setting "focusResults": false in keybindings.json, i.e:
    {
        "key": "shift+cmd+f",
        "command": "search.action.openNewEditor",
        "args": {
            "focusResults": false
        }
    }

...at which point I considered just not bothering posting an issue 😅  But because the behavior seems to be inconsistent I think "focusResults": false might be a more sensible default for search.action.openNewEditor.
Complete conjecture but I imagine the current behavior might have led to issues like: https://github.com/microsoft/vscode/issues/105034 as my first instinct was to wonder why the search results were editable at all.

I think this makes sense, to be consistent with the other search widgets.


DigitalOcean Postgres + PGBouncer Issues

Broken out from prisma2/#556 on request from @janpio .
Similar to specs/#386 and prisma2/#1438, we have been attempting to use Prisma2 against a Digital Ocean PostgreSQL 11 database service.
Operating without pgbouncer, the application initially runs fine, but eventually runs out of connections. When this happens, the query engine also seems to spin and use all available CPU.
Since this seems to be a connection release/starvation issue, we added pgbouncer in front of Postgres.  Digital Ocean offers pgbouncer-based pools with transaction, session, and statement settings. With a transactional pool in place, we receive errors with prepared statements, e.g. "prepared statement 's1599' does not exist."
We've also tested a session pool but it still ran out of connections eventually.
We are using the &connection_limit=15 argument in our connection string (without pgbouncer), but are still seeing the issue.  We're currently using preview21, and planning to update to preview22 shortly. We're hoping that using the flag discussed in specs/#386 plus a transactional pool will solve the issue against a Digital Ocean provided pgbouncer/postgres.
We're also exploring moving to mysql, but it's requiring additional work to get around some of the current limitations with how Prisma2 handles strings in mysql, along with some unrelated innodb issues.  Postgres is definitely our preferred technology for our project.
On recommendations from the Prisma team, we modified the client code to add the --always_force_transactions flag to the query engine invocation here: https://github.com/prisma/prisma-client-js/blob/7ee403f1b255e8506d92b675d53bf9a8b2bea097/packages/engine-core/src/NodeEngine.ts#L336
With this in place, the first query executed would work, but queries afterwards would fail with "Error in connector: Error creating a database connection."  I believe this is due to the Digital Ocean pgbouncer not having the settings mentioned here: https://github.com/prisma/prisma-engines/pull/403
Doing some research, it seems like these are uncommon settings, with pgbouncer defaulting them off and not recommending them.  This can be worked around, but might make it difficult for Prisma2 to work with some of the major providers: https://github.com/pgbouncer/pgbouncer/issues/110#issuecomment-182501545
I've worked on setting up a custom pgbouncer server in front of the Digital Ocean managed Postgres, but their SSL configuration looks like this may not be an option.
We're continuing to look for workarounds and configuration changes to get this working.

We can confirm this problem with DigitalOcean's PgBouncer (Connection Pool) feature as it unfortunately does not allow setting any configuration on PgBouncer. We are looking into finding a workaround that matches Prisma's connection behavior.

Hi @janpio, have you guys made any progress on this? If not, I'd look into migrating my database from Digital Ocean to AWS unless, of course, you guys are about to release a fix

For anyone finding this, the connection leaks mentioned here ended up being a separate issue.  We corrected it and dropped pgbouncer from our configuration.
I didn't get this working, but I did spend a little time working on manually setting up a pgbouncer server in front of the DO postgres, which would have allowed me to configure the settings as recommended.  Not sure if that is any easier than switching services if you're able.
@MaxAst I think they're looking at other options in issue #2453

okay cool, thank you @Linktheoriginal!

We will probably soon release an updated pgBouncer mode: https://github.com/prisma/prisma/issues/2520. Will update this issue here as well when that happened.
(You can probably right now use forceTransactions:true in the PrismaClient constructor without the custom configuration and have a working setup in 99% of the cases - but these last 1% is what we can unfortunately only fix with this new release for DO's Connection Pool feature)

https://github.com/prisma/prisma/issues/2520 is now closed, we implemented a ?pgbouncer=true query param for the connection string that you can use to enable PgBouncer mode.
Available in alpha now, and in the next beta soon.

I have created PostgreSQL 12 database cluster in digital ocean, and using connection pool. in my java code Application.properties i have configured database properties as below:
`spring.datasource.url=jdbc:postgresql://private-db-postgresql--.b.db.ondigitalocean.com:25061/*********?pgbouncer=true
spring.datasource.username=*********
spring.datasource.password=*********
spring.datasource.driver-class-name=org.postgresql.Driver
spring.jpa.properties.hibernate.default_schema=*********`
when i am trying to run the application getting below error:

Caused by: org.postgresql.util.PSQLException: ERROR: prepared statement "S_3" already exists
at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2553) ~[postgresql-42.2.16.jar:42.2.16]
at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2285) ~[postgresql-42.2.16.jar:42.2.16]
at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:323) ~[postgresql-42.2.16.jar:42.2.16]
at org.postgresql.jdbc.PgConnection.executeTransactionCommand(PgConnection.java:857) ~[postgresql-42.2.16.jar:42.2.16]
at org.postgresql.jdbc.PgConnection.rollback(PgConnection.java:900) ~[postgresql-42.2.16.jar:42.2.16]
at com.zaxxer.hikari.pool.ProxyConnection.rollback(ProxyConnection.java:396) ~[HikariCP-3.4.5.jar:na]
at com.zaxxer.hikari.pool.HikariProxyConnection.rollback(HikariProxyConnection.java) ~[HikariCP-3.4.5.jar:na]
at org.hibernate.resource.jdbc.internal.AbstractLogicalConnectionImplementor.rollback(AbstractLogicalConnectionImplementor.java:121) ~[hibernate-core-5.4.21.Final.jar:5.4.21.Final]
... 27 common frames omitted
Caused by: org.postgresql.util.PSQLException: ERROR: prepared statement "S_1" does not exist
at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2553) ~[postgresql-42.2.16.jar:42.2.16]
at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2285) ~[postgresql-42.2.16.jar:42.2.16]
at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:323) ~[postgresql-42.2.16.jar:42.2.16]
at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:473) ~[postgresql-42.2.16.jar:42.2.16]
at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:393) ~[postgresql-42.2.16.jar:42.2.16]
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:164) ~[postgresql-42.2.16.jar:42.2.16]
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:114) ~[postgresql-42.2.16.jar:42.2.16]
at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeQuery(ProxyPreparedStatement.java:52) ~[HikariCP-3.4.5.jar:na]

Please open a new issue @kanchangpr and fill the issue template - then we can take a look at the details and try to help you.

Please open a new issue @kanchangpr and fill the issue template - then we can take a look at the details and try to help you.

created new issue #4735. thanks for your response.

Besides adding &pgbouncer=true also make sure that:
If you have created a new database user, make sure you have assigned proper permissions to it.
Docs: https://www.digitalocean.com/docs/databases/postgresql/how-to/modify-user-privileges/
Video: https://youtu.be/tsOHw2T1HvI?t=596
But even after that, although DB connection pooling is working properly in most cases, it just does not work with nextauth (https://next-auth.js.org). I am getting various kinds of errors when I try to login using Google (via next-auth):

Callback error
OAuthAccountNotLinked
504 Gateway Timeout
Redirect back to login page, without logging in user.

It is working absolutely fine:

locally
without connection pool (on Digital Ocean Managed DB and Heroku)
with & without connection pool (AWS, Digital Ocean Droplet)

Can you open a new issue about the problems you are experiencing please @muditgoel01? I see no way how this could really be connected to using PgBouncer, but we are happy to look into that (optimally with a small reproduction repository).


Add quality setting for PNG image

Original post on Discourse.
On my website, the PNG images resized with Hugo are bigger than the original.
For example, with an image called apercu-slack.png:

the original is 1280x920px and weight 26ko
the resized version is 1024x736px and weight 60ko

The original image:

The resized version:

https://github.com/foobaz/lossypng maybe

I have made a repo to test the quality parameter of Golang's image/png library. I will try to add imaging and lossypng.
https://github.com/aitva/golang-png-encoding

@aitva much appreciated.

Hi, I've spent some time toying with the image library and here is what I found:

just encoding and decoding the PNG image through go increase its size
the PNG image I am using come with a color palette, which greatly reduced its size
passing the image through imaging removes its color palette, greatly increasing its size
using the lossypng library does not help, the image quality is affected and the image size increase

The good news is that there is an easy fix ! We can reuse the original color palette on the reduced image.
Thus, we go back to something very close to the original size and the image is not altered:

original image: 1280x920px and 26297 bytes
original image through go: 1280x920px and 31368 bytes
resized image: 1024x736px and 47339 bytes
indexed image: 1024x736px and 23617 bytes

There are more details at https://github.com/aitva/golang-png-encoding

Thanks for this, really appreciated.


Motion maps from 'i' & 'a' causes 'ciw', 'caw', and others to fail

Hello,
I'm unable to run commands using the motions 'iw' & 'aw' after using the following remaps:
noremap i h
noremap a j

This deviates from Vim behavior since Vim allows iw & aw to be used to manipulate words as expected from ciw daw yaw etc
After doing some code skimming, I believe the issue stems from the following items in the map getting out-prioritized whenever a motion map using 'i' or 'a' as the target keys is created using mapCommand():
    { keys: 'a<character>', type: 'motion', motion: 'textObjectManipulation' },
    { keys: 'i<character>', type: 'motion', motion: 'textObjectManipulation', motionArgs: { textObjectInner: true }},

This is because _mapCommand() method writes user-defined maps to the beginning of the defaultKeymap using .unshift()
I'm thinking the issue would be resolved by ensuring that these a<character> and i<character> commands don't lose priority. This can be accomplished is by keeping these items at the front of map.
Here's a possible solution:

create a var invariantMap that contains the a<character> and i<character>  mappings
create a var userMap that contains the user-defined mappings
instead of accessing defaultKeymap directly throughout the code, we could replace it with a getCombinedKeymap() method that returns a map that union of the invariantMap, userMap, and thedefaultKeymap (respecting that order for priority). This way, the invariant mappings remains prioritized over the user-defined mappings, and the user-defined mappings remains prioritized over the default mappings.

Would this strategy make sense?

Running :noremap i h in vim 8.2.8 produces the same result as in codemirror-vim. Maybe there is some other option in vim that needs to be turned on to allow to resolve the conflict between i and ia?

I believe I made a mistake on my end. I don't run into the issue any more. If anyone runs into this issue again re-open this one!

@ivyraine What was the problem? I have a similar issue I usually solve with operator-pending bindings (omap)—can't do that here.

@Acumane  https://github.com/replit/codemirror-vim/pull/97 implements omap, could you please check on https://raw.githack.com/replit/codemirror-vim/omap/dev/web-demo.html if it works as expected?