Could reply the issue notification email to add new reply to issue?

Gitea version (or commit ref): 1.10.0
Git version:
Operating system: Docker
Database (use [x]):

[ ] PostgreSQL
[X] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
Now the issue notification email has been configed, and we could get the  notification email when someone @me or reply my issue,
but how about i reply the email i got then the issue is replyed with the email content? I think it would be a cool function and more convenient for communication.
Screenshots

It's not a trivial task. Perhaps through a POP account is a good start? Otherwise it would be difficult without a standard mail subsystem. Unix-like systems usually have one, but Windows doesn't. Then each message should be MIME parsed. The real trick however is to strip the quoted parts of a reply, though. Here's one library I've found for that: https://github.com/kvannotten/mailstrip

This would be a useful function.

@esradioli did you mean @strk's comment on #6998?

It's not a trivial task. Perhaps through a POP account is a good start? Otherwise it would be difficult without a standard mail subsystem. Unix-like systems usually have one, but Windows doesn't. Then each message should be MIME parsed. The real trick however is to strip the quoted parts of a reply, though. Here's one library I've found for that: https://github.com/kvannotten/mailstrip

I find that this function in Gitlab is called "reply-by-mail".

It's not a trivial task. Perhaps through a POP account is a good start? Otherwise it would be difficult without a standard mail subsystem. Unix-like systems usually have one, but Windows doesn't. Then each message should be MIME parsed. The real trick however is to strip the quoted parts of a reply, though. Here's one library I've found for that: https://github.com/kvannotten/mailstrip

I think https://github.com/emersion/go-imap would be a better choice.

I second the usefulness of this feature request. We've had a discussion about this over at https://codeberg.org/corona-contact-tracing-germany/cwa-android and wondered whether there was a feature request issue open already.
@suli3 maybe you can rename the issue title to "[Feature request] Add Issue reply by mail"? That way it'd be easier to figure out at a glance what this issue is about.

A PR to fix this #13585

#2386 seems to be related


parent experiment id -- GeoMIP timeslice experiments

There are initialisation discrepancies between CMIP6-CV and ES-DOC for the GeoMIP timeslice experiments G6SST2-sulfur (G6SulfurSlice2), G6SST2-solar (G6SolarSlice2) and G7SST2-cirrus (G7CirrusSlice2) which take place in year 2100 of G6sulfur, G6solar and G7cirrus.

GeoMIP experiment
CMIP6-CV parent experiment id
ES-DOC is_initialized_by
GeoMIP GMD

G6SST2-sulfur (G6SulfurSlice2)
ssp585
G6sulfur
"Each Tier 1 experiment will have two associated time-slice simulations, one at the beginning of the coupled simulation and one at the end."

G6SST2-solar (G6SolarSlice2)
ssp585
G6solar
ditto

G7SST2-cirrus (G7CirrusSlice2)
ssp585
G7cirrus
ditto

I think the description of these second timeslice experiments in section 3.1 of the GeoMIP GMD paper implies that the simulations should be taken from the end of experiments: G6sulfur, G6solar and G7cirrus and not from ssp585.

Haven't looked at it yet, but we should note that Ben Kravitz, leader of GeoMIP, sent this email out yesterday:
"I'm getting a couple of inquiries about G6solar and G6sulfur.  The specifications document that I sent around a few months ago is now online:
http://climate.envsci.rutgers.edu/GeoMIP/doc/G6specs.docx "

I will alert Ben Kravitz to check this, but I think that the ES-DOC parent experiment is correct (and the CV is wrong).  I also noticed that some of the parent activities are wrong in the CV.  If Ben concurs, I think we need to make the following changes to the CV:
For G6SST2-sulfur
parent experiment id: G6sulfur
parent activity id: GeoMIP
For G6SST2-solar
parent experiment id: G6solar
parent activity id: GeoMIP
For G7SST2-cirrus
parent experiment id: G7cirrus
parent activity id: GeoMIP
For G6sulfur, G6solar, and G7cirrus
parent activity id: ScenarioMIP  (not CMIP)

I concur with @charliepascoe 's assessment and with @taylor13 's suggested changes.  I'll admit I'm not entirely sure what "parent activity id" is supposed to do, so I'm trusting you on that one.

@bkravitz thanks for confirming. Those changes are now in place, take a peek at CMIP6_experiment_id.html and let me know if anything else needs tweaking
@charliepascoe @taylor13 ping


Change Nmap to Masscan?

Can you change or customise the use between masscan and nmap
something like:
https://github.com/zan8in/masscan

Hi @bugeja1989 !
Why do you need Cameradar to use masscan over nmap?
Nmap should be able to discover RTSP hosts with no problem, just as well as masscan.
The repository you linked is a heavily inspired implementation of masscan bindings based on my nmap package, which is fine but I don't see why using it would improve Cameradar.

Well for one, masscan is able and is tuned to send packets at a faster rate than that of NMAP if you not know of it yet to cover IP ranges and Subnets. See: https://github.com/robertdavidgraham/masscan#transmit-rate-important
NMAP is slow and is usually used against a single or a few multiple targets, not the whole internet for that matter.

Sure this would work 👍
Cameradar is not intended to be a tool used to discover exploitable IP cameras on the internet, it is intended to be a penetration testing tool, precisely aimed at small, specific targets.
There could be cases where masscan might be relevant, but they could easily tend towards the illegal, which is why I will not integrate masscan over nmap for Cameradar.
Unless you have another argument than scanning the whole internet, which is not the intended purpose of this tool, I do not think I'll change my mind 😄

Welp. That concludes the issues in this and #300

@phr34k0 I'm curious about your use case then, because if it is a valid one I'd be willing to offer the choice between using masscan and nmap during the discovery phase in Cameradar.
How many subnetworks do you usually need to scan in parallel? Do you work for a company with thousands of active sites with CCTV coverage? Do you then usually know the exact IPs of the cameras, or at least the IP ranges at which they are available, or do you have to guess and scan the whole network?
If it's not the case with your clients/company, note that surveillance cameras should always be on a separate network, isolated from the rest of the infrastructure, for multiple reasons:

Many brands of cameras are vulnerable to known exploits (especially Chinese brands), very likely many zero days, and some even have backdoors, that allow any attacker to take control of the camera and use it as a host in the network, from which to conduct further reconnaissance & attacks
Cameras should ideally never be accessed remotely but only on-site by security guards. If they are to be accessed remotely, that should be done through IP whitelisting to allow only the NOC access to the cameras. Potential attackers having even only read access on what is going on onsite can facilitate social engineering and physical attacks.

That said, I could see a case where if you work for a large company and they ask you for a threat assessment of all of their networks without telling you where exactly IP cameras might or might not be available, that could take considerable time with Cameradar. It seems to me like quite an edge-case though 😬

@phr34k0 I'm curious about your use case then, because if it is a valid one I'd be willing to offer the choice between using masscan and nmap during the discovery phase in Cameradar.
How many subnetworks do you usually need to scan in parallel? Do you work for a company with thousands of active sites with CCTV coverage? Do you then usually know the exact IPs of the cameras, or at least the IP ranges at which they are available, or do you have to guess and scan the whole network?
If it's not the case with your clients/company, note that surveillance cameras should always be on a separate network, isolated from the rest of the infrastructure, for multiple reasons:

Many brands of cameras are vulnerable to known exploits (especially Chinese brands), very likely many zero days, and some even have backdoors, that allow any attacker to take control of the camera and use it as a host in the network, from which to conduct further reconnaissance & attacks
Cameras should ideally never be accessed remotely but only on-site by security guards. If they are to be accessed remotely, that should be done through IP whitelisting to allow only the NOC access to the cameras. Potential attackers having even only read access on what is going on onsite can facilitate social engineering and physical attacks.

That said, I could see a case where if you work for a large company and they ask you for a threat assessment of all of their networks without telling you where exactly IP cameras might or might not be available, that could take considerable time with Cameradar. It seems to me like quite an edge-case though 😬

I can't tell you all of the details, but what I can tell you is that the company I work with works closely with Alpha Strike Labs and Cyble. We do advance OSINT, have our eyes on Indicator of Compromise (IOC) from Advance Persistent Threat (APT) and Ransomware groups aside from gathering exposed systems. We scan by subnets or by ASN level. Masscan speeds up the process without all the unnecessities from NMAP. If we do need things like grabbing banners and CVEs from vulners with NMAP --script, that can be done so separately.
And yes, we are fully aware of brands or rebranded devices, DMZ enabled network without firewalls etc.. I can always comment out or improvise your code so it is of no issue for me. Just dropping by to see issues and having my 2cents to reconfirm if its possible for the change so everyone else can stop asking the same thing over. What you did was the right thing to avoid a misuse of the code. 😺

The thing is, it's going to get misused anyway 😄 I could see a valid case for having a private version of the repo with a masscan alternative, specifically accessible to people that I can be pretty sure will make good use for it though, if you are interested.

The thing is, it's going to get misused anyway smile I could see a valid case for having a private version of the repo with a masscan alternative, specifically accessible to people that I can be pretty sure will make good use for it though, if you are interested.
Disclaimer though, I do not have as much free time these days as I did when I wrote the tool so it could take some time.

Sounds fun. Sure thing. I can bet that the tool could be use to do more than just RTSP aided with CVEs.


security: fix CVE-2023-39319

This is a PRIVATE issue for CVE-2023-39319, tracked in http://b/293889520 and fixed by http://tg/c/1976594.
/cc @golang/security and @golang/release

@gopherbot please open backport issues.


[BUG] build/Build-Nightly.ps1

The variable $runPublic in line 45 is not defined. It should be named $runPublish. As $runPublic results to $null the comparsion $runPublic -eq $false is always false and the code in the if statement is never reachedand the comparsion $existing_pnpcoresdk_hash -ne $pnpcoresdk_hash has no impact.

@matthiasklauke - good catch, have fixed it.


fixed toast again

comes with https://github.com/music-encoding/music-encoding.github.io/pull/29

Could you briefly explain why this change is necessary and what the impact is? It’s hard to review code when I don’t know what the motivation for it is.

reacts to the comment by @lpugin in #48


Hamburger menu has no visible focus when focussed with keyboard

Description
When tabbing through the site it should be possible to see which element is in focus by the presence of a visible focus outline. The hamburger menu and its corresponding close button are missing this outline.
Screenshots

Additional information
No response

Can i work on it ?

Sure @sidharthviz

PR: #4245  solves this issue

PR: #4245 solves this issue

Hi @alokVerma749 Please work on those issues which you've been assigned for, Thank you

Hi @sidharthviz I apologize for not communicating my plans beforehand. I had noticed that this issue had been open for a while and I wanted to take action to move it forward. In the future, I will make sure to check before taking on any issues.

@alokVerma749  No worries! Good for you 👍🏼

@alokVerma749 please don’t make PRs for issues already assigned to other people, it’s bad etiquette. This issue was only created yesterday so it hadn’t been open “for a while” like you state. Please give the assignee time to work on things. For many this is their first contribution to open source and it can be discouraging to have this happen.

My apologies for this conduct. As I am new to contributing


WebPage Implementation/Revamp!

Revamp the page and create multiple tabs!
For the different tabs I was thinking
LP stats - My wallet - NFTs
LP stats will have the data and the charts
My wallet ... well it's straight forward 😅
NFTs the stats and the charts

The site is becoming noisy 😄
Maybe add some colors too (can do this part later)


enable dotnet portable debug database in *.csproj

by default visual studio will generate pdb files that can not be used in vscode to debug with dotnet core (tested dotnet 3.1).
This extract xml snippet can enable debug.  not sure if this work with monoDevelop.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: qingfengxia sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

This seems OK, but since the MSBuild properties are common to all projects and configurations, I think you could add them to this shared property group block: https://github.com/mono/CppSharp/blob/master/Directory.Build.props#L4

ah, I am not familiar with C# build system,  not even know there is such an option for all projects.
not sure if dotnet build will look into  that  https://github.com/mono/CppSharp/blob/master/Directory.Build.props#L4

ah, I am not familiar with C# build system, not even know there is such an option for all projects.
not sure if dotnet build will look into that https://github.com/mono/CppSharp/blob/master/Directory.Build.props#L4

That file is automatically included by MSBuild.
So all you should need is to add:
    <DebugType>portable</DebugType>
    <DebugSymbols>true</DebugSymbols>

To the line I linked previously.

Can you make the requested changes to merge this one?

@qingfengxia you just need to edit this line: https://github.com/mono/CppSharp/blob/af275edb55f4628266259ac7c19ea5a786b47aa6/Directory.Build.props#L42


Create sub-categories for random data

I noticed that the demo doesn't have any sub-categories anymore, thus we don't have access to this feature. Shouldn't we add some again? (#2056)

Just mentiion it here the demo doesn't have sales neither.

We can re-iterate on the products catalog and introduce some subcategories. They were removed when we made new products for Saleor 2.0 release. It wasn't intentional, I think we just forgot that we can have them 😉

@timcla Maybe you'd had some time to take a look at the current structure and propose some subcategories?

(Current...)
ACCESSORIES
Homewares
Paints
APPAREL
T-shirts
Polo shirts
Hoodies
Footwear
GROCERIES
Juices
Alcohol

(planned...)
ACCESSORIES
Homewares
Paints
Music
Mugs
APPAREL
T-shirts
Polo shirts
Hoodies
Footwear
GROCERIES
Juices
Alcohol
Coffee
Tea
Oil


Tests fail against current master branch

I am on c5884ce9ce3ac73b025d0bc58c4d3d72870edc0b and get this test output:
ENG000656:minio-go aaronschlesinger$ go test -race ./...
--- FAIL: TestMakeBucketErrorV2 (2.05s)
	api_functional_v2_test.go:65: Error: Anonymous access is forbidden for this operation gx5xrbpfiso4r33klhomnhnouvophm
--- FAIL: TestGetObjectClosedTwiceV2 (0.19s)
	api_functional_v2_test.go:112: Error: Anonymous access is forbidden for this operation 34jrkpn5lgynk92oah2svn4qcfe4fn
--- FAIL: TestRemovePartiallyUploadedV2 (0.10s)
	api_functional_v2_test.go:197: Error: Anonymous access is forbidden for this operation bjz5zvcro11h95phaa3msl4f3dwkm6
--- FAIL: TestResumbalePutObjectV2 (0.15s)
	api_functional_v2_test.go:264: Error: Anonymous access is forbidden for this operation k1154pqzhmzhd5x52hlecczh5hs2oi
--- FAIL: TestResumableFPutObjectV2 (0.10s)
	api_functional_v2_test.go:375: Error: Anonymous access is forbidden for this operation 5vs5xutzqcv4gov2ubju9lpixigoil
--- FAIL: TestMakeBucketRegionsV2 (0.11s)
	api_functional_v2_test.go:451: Error: Anonymous access is forbidden for this operation obtghc94f5il2j5qo5umq26nbp4o4q
--- FAIL: TestResumablePutObjectV2 (0.11s)
	api_functional_v2_test.go:503: Error: Anonymous access is forbidden for this operation 5mmab9zziw5x2bpdmsipgsosm1yh2l
--- FAIL: TestGetObjectReadSeekFunctionalV2 (0.11s)
	api_functional_v2_test.go:567: Error: Anonymous access is forbidden for this operation hyef3cusj02lyeyw0etvjsfy19r4i6
--- FAIL: TestGetObjectReadAtFunctionalV2 (0.13s)
	api_functional_v2_test.go:681: Error: Anonymous access is forbidden for this operation m2wozuulnu9l6s92qs6wklxbgfggtr
--- FAIL: TestFunctionalV2 (0.11s)
	api_functional_v2_test.go:822: Error: Anonymous access is forbidden for this operation f0jibm0azy1gcrad5kqf03fc40j6j5
--- FAIL: TestMakeBucketError (0.12s)
	api_functional_v4_test.go:89: Error: Anonymous access is forbidden for this operation 6ov9dlm6rq3unimnkd25ieg9ulr2wy
--- FAIL: TestMakeBucketRegions (0.11s)
	api_functional_v4_test.go:135: Error: Anonymous access is forbidden for this operation yg5je0sr60qv4mfct1osknds4aqk2w
--- FAIL: TestGetObjectClosedTwice (0.11s)
	api_functional_v4_test.go:187: Error: Anonymous access is forbidden for this operation 2zo2q0gkrh1hodjdeifvali6gtacoa
--- FAIL: TestRemovePartiallyUploaded (0.21s)
	api_functional_v4_test.go:272: Error: Anonymous access is forbidden for this operation r0a9gy36pimbhorvgvmcdvdmt5nw9d
--- FAIL: TestResumbalePutObject (0.11s)
	api_functional_v4_test.go:342: Error: Anonymous access is forbidden for this operation 5rlsuspt1n4v05h6ph4pvaxux3lwya
--- FAIL: TestResumableFPutObject (0.11s)
	api_functional_v4_test.go:452: Error: Anonymous access is forbidden for this operation gn4mdbej9ewz5rzs4obavftv1ezomv
--- FAIL: TestResumablePutObject (0.18s)
	api_functional_v4_test.go:532: Error: Anonymous access is forbidden for this operation scv0rmlyub39kjmkdbjgpibvgbpnkm
--- FAIL: TestGetObjectReadSeekFunctional (0.11s)
	api_functional_v4_test.go:596: Error: Anonymous access is forbidden for this operation txkeaboi3bois3rrl6l3wmzr1bw0pa
--- FAIL: TestGetObjectReadAtFunctional (0.10s)
	api_functional_v4_test.go:710: Error: Anonymous access is forbidden for this operation aibg3gdem9tll06fvxyuc5hn6huymh
--- FAIL: TestFunctional (0.11s)
	api_functional_v4_test.go:851: Error: Anonymous access is forbidden for this operation zq2ftf09vmhkqufy0m05zpa5gzir0n
FAIL
FAIL	github.com/minio/minio-go	4.469s

ENG000656:minio-go aaronschlesinger$ go test -race ./...
--- FAIL: TestMakeBucketErrorV2 (2.05s)
api_functional_v2_test.go:65: Error: Anonymous access is forbidden for this operation gx5xrbpfiso4r33klhomnhnouvophm
--- FAIL: TestGetObjectClosedTwiceV2 (0.19s)
api_functional_v2_test.go:112: Error: Anonymous access is forbidden for this operation 34jrkpn5lgynk92oah2svn4qcfe4fn
--- FAIL: TestRemovePartiallyUploadedV2 (0.10s)
api_functional_v2_test.go:197: Error: Anonymous access is forbidden for this operation bjz5zvcro11h95phaa3msl4f3dwkm6
--- FAIL: TestResumbalePutObjectV2 (0.15s)
api_functional_v2_test.go:264: Error: Anonymous access is forbidden for this operation k1154pqzhmzhd5x52hlecczh5hs2oi
--- FAIL: TestResumableFPutObjectV2 (0.10s)
api_functional_v2_test.go:375: Error: Anonymous access is forbidden for this operation 5vs5xutzqcv4gov2ubju9lpixigoil
--- FAIL: TestMakeBucketRegionsV2 (0.11s)
api_functional_v2_test.go:451: Error: Anonymous access is forbidden for this operation obtghc94f5il2j5qo5umq26nbp4o4q
--- FAIL: TestResumablePutObjectV2 (0.11s)
api_functional_v2_test.go:503: Error: Anonymous access is forbidden for this operation 5mmab9zziw5x2bpdmsipgsosm1yh2l
--- FAIL: TestGetObjectReadSeekFunctionalV2 (0.11s)
api_functional_v2_test.go:567: Error: Anonymous access is forbidden for this operation hyef3cusj02lyeyw0etvjsfy19r4i6
--- FAIL: TestGetObjectReadAtFunctionalV2 (0.13s)
api_functional_v2_test.go:681: Error: Anonymous access is forbidden for this operation m2wozuulnu9l6s92qs6wklxbgfggtr
--- FAIL: TestFunctionalV2 (0.11s)
api_functional_v2_test.go:822: Error: Anonymous access is forbidden for this operation f0jibm0azy1gcrad5kqf03fc40j6j5
--- FAIL: TestMakeBucketError (0.12s)
api_functional_v4_test.go:89: Error: Anonymous access is forbidden for this operation 6ov9dlm6rq3unimnkd25ieg9ulr2wy
--- FAIL: TestMakeBucketRegions (0.11s)
api_functional_v4_test.go:135: Error: Anonymous access is forbidden for this operation yg5je0sr60qv4mfct1osknds4aqk2w
--- FAIL: TestGetObjectClosedTwice (0.11s)
api_functional_v4_test.go:187: Error: Anonymous access is forbidden for this operation 2zo2q0gkrh1hodjdeifvali6gtacoa
--- FAIL: TestRemovePartiallyUploaded (0.21s)
api_functional_v4_test.go:272: Error: Anonymous access is forbidden for this operation r0a9gy36pimbhorvgvmcdvdmt5nw9d
--- FAIL: TestResumbalePutObject (0.11s)
api_functional_v4_test.go:342: Error: Anonymous access is forbidden for this operation 5rlsuspt1n4v05h6ph4pvaxux3lwya
--- FAIL: TestResumableFPutObject (0.11s)
api_functional_v4_test.go:452: Error: Anonymous access is forbidden for this operation gn4mdbej9ewz5rzs4obavftv1ezomv
--- FAIL: TestResumablePutObject (0.18s)
api_functional_v4_test.go:532: Error: Anonymous access is forbidden for this operation scv0rmlyub39kjmkdbjgpibvgbpnkm
--- FAIL: TestGetObjectReadSeekFunctional (0.11s)
api_functional_v4_test.go:596: Error: Anonymous access is forbidden for this operation txkeaboi3bois3rrl6l3wmzr1bw0pa
--- FAIL: TestGetObjectReadAtFunctional (0.10s)
api_functional_v4_test.go:710: Error: Anonymous access is forbidden for this operation aibg3gdem9tll06fvxyuc5hn6huymh
--- FAIL: TestFunctional (0.11s)
api_functional_v4_test.go:851: Error: Anonymous access is forbidden for this operation zq2ftf09vmhkqufy0m05zpa5gzir0n
FAIL

Do you have access keys set?
os.Getenv("ACCESS_KEY"),
os.Getenv("SECRET_KEY"),

You should run the shorter version to avoid functional tests. "go test -short -race"

Do you have access keys set?
os.Getenv("ACCESS_KEY"),
os.Getenv("SECRET_KEY"),

BTW you need S3 access to test functional tests, that is why - "Anonymous access is forbidden for this operation 5vs5xutzqcv4gov2ubju9lpixigoil"

BTW you need S3 access to test functional tests, that is why - "Anonymous access is forbidden for this operation 5vs5xutzqcv4gov2ubju9lpixigoil"

This is expected for full functional tests, as practice for just running unit tests it should be run as "go test -race -short"  - so closing this issue.

BTW you need S3 access to test functional tests, that is why - "Anonymous access is forbidden for this operation 5vs5xutzqcv4gov2ubju9lpixigoil"

Ah, I missed that part. Some documentation in the README indicating that requirement would be very helpful, since that's a significant one.

Ah, I missed that part. Some documentation in the README indicating that requirement would be very helpful, since that's a significant one.

Yeah absolutely will add that.

Thanks!


CHEF-3447: Fix resource_id to avoid breaking InSpec's reporter such as json or json-automate

Description

This PR fixes the delegation error raised when k8sobject (aka resource) is nil and an attempt is made to fetch the uid in resource_id. Therefore, it breaks reporter like json or json-automate
(Note: uid is delegated to metadata; and metadata is delegated to resource; and resource is alias for k8sobject
Related Issue

CHEF-3447: InSpec K8S resources with Automate reporter generate exceptions
CHEF-3929: inspec-k8s resource ids do not work with Automate reporter
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New content (non-breaking change)
[ ] Breaking change (a content change which would break existing functionality or processes)

Checklist:

[x] I have read the CONTRIBUTING document.

Run for the specs as it is not part of CI yet:
❯ bundle exec rspec test/unit/libraries/*
No examples found.

Finished in 0.00036 seconds (files took 0.57629 seconds to load)
0 examples, 0 failures

Run options: --seed 53767

# Running:

.......................................................................................................................................................................................................................

Finished in 0.046408s, 4632.8219 runs/s, 6507.4987 assertions/s.

215 runs, 302 assertions, 0 failures, 0 errors, 0 skips


Support route prefix

Version: 4.3.1.
hashbang: true
Our site is divided into multiple different apps each with their own route prefix. I.e.:
http://somehost.com/
http://somehost.com/admin <-- site prefix
We used the "base" param on the ko-component-router element but the behavior wasn't as expected. Instead of seeing the expected route of /admin/#!/some-page we instead got the route of /#!/admin/some-page.
From reviewing the code (specifically the getter for Router.prototype.base) it seems the the latter is the expected outcome. It would seem then that the option we are looking for does not exist. Therefore, would it be possible to have a new "prefix" option added to the router to allow for what we need?

Sounds like you want nested routing.
ko.router.useRoutes({
  '/admin': {
    '/foo': ...,
    '/bar': ...
  }
})

Using CommonJS/AMD, you would break the sub-apps into separate modules.

Would that achieve the #! in the middle? I.e.: /admin/#!/some-page ?
We have different pages/apps with different scripts that load depending on the route that you initially hit.

Are all of the sub-apps tied together, or are they totally independent? If each sub app defines it's own base — i.e. the admin page has a router with a base path of /admin — you should achieve what you're looking for.

I'm having the same issue as this.
i have bob.com/admin/index.html
which can be bob.com/admin/
trying to route:
bob.com/admin/#!/dashboard
setting
ko.router.setConfig({     base: "",     hashbang: true, });
and
ko.components.register('app', {     viewModel: class App {         routes: any;         constructor() {             this.routes = {                 '/admin': [                     { '/!': 'home' }                 ]...
results in
bob.com/#!/admin/dashboard
if i don't do the nested routing it results in
http://localhost:16289/#!/admin/

Our apps are independent of each other. So a user going to the /admin app is in a completely different app then the user going to the / route. Setting the base doesn't achieve the expected result in the /admin page (as stated above). Is this a bug? Is it expected that the base for /admin should result in routes with /admin as the prefix?

That would definitely be a bug; the base path should precede the #!. There can be some funky requirements when using the pushstate polyfill though. I'll try to get to making an example later today.

@barake knows more about hashbang routing and IE usage than I do

Is this happening all browsers, or just IE9 with the history polyfill?
The html5-history-api polyfill requires configuration to work with the router in general:
https://github.com/Profiscience/ko-component-router/blob/master/docs/basic.md#installation
In this case, you'd need to make your setup call look something like:
window.history.setup('/admin', '!/', null);

I am on chrome latest.
Tested it with polyfill and without, didn't try /admin in the polyfill though.

t'was a bug, and it has been squashed. 4.4.1 should work as expected.


[NSE-821] Fix Wholestage Codegen on unsupported pattern

What changes were proposed in this pull request?
This patch fixes wholestage codegen on unsupported pattern.
The issue is introduced by a variant LeftOuter SortMergeJoin
with Projection as its right child, which breaks the codegen
depedency pattern.
This patch introduced a check on this pattern and stop doing
codegen under this case.
Signed-off-by: Yuan Zhou<EMAIL_ADDRESS>How was this patch tested?
pass jenkins

verified locally, merging


Better password handling

Add a better way to handle password verification for password stored with password_hash

Fixes #3.

Thanks for the merge ! I got messed up with Branches so I added a new Pull Request with a few improvements on tags and the same password correction. Sorry for that.
Also, is there a way to create users or do you handle that manually directly on the DB ? As with this new password system you need to hash your passwords with the password_hash php function.

I create users via DB.
When I've time to work on it, I'll create a registration page.


Missing screenshots and steps.

It appears that the steps was supposed to show the screenshots but the page only shows a text box with a copy button.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d74d8a8-30f0-662e-1081-7a471fb2da67
Version Independent ID: 506d1806-cccf-15c6-52ee-ef7785334808
Content: Add your organization's privacy info - Azure Active Directory
Content Source: articles/active-directory/fundamentals/active-directory-properties-area.md
Service: active-directory
Sub-service: fundamentals
GitHub Login: @msaburnley
Microsoft Alias: ajburnle

@kokeysian Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

Hey @kokeysian thanks for your feedback. The page is displaying the screenshots. I am going to close this github issue. If Thanks again! #please-close


feat: add ok boolean to DWNResponseStatus

What type of PR is this? (check all applicable)

[ ]  ♻ Refactor
[x]  ✨ New Feature
[ ]  🐛 Bug Fix
[ ]  📝 Documentation Update
[ ]  👷 Example Application
[ ]  🧑💻 Code Snippet
[ ]  🎨 Design
[ ]  📖 Content
[ ]  🧪 Tests
[ ]  🔖 Release
[ ]  🚩 Other

Description
This PR adds an ok boolean to the DWNResponseStatus for requests that were successful
Related Tickets & Documents
Resolves https://github.com/TBD54566975/web5-js/issues/904
Mobile & Desktop Screenshots/Recordings
Added code snippets?

[ ]  👍 yes
[x]  🙅 no, because they aren't needed

Added tests?

[ ]  👍 yes
[x]  🙅 no, because they aren't needed
[ ]  🙋 no, because I need help

[optional] Are there any post-deployment tasks we need to perform?
Please run npm install or make sure @web5/crypto package is installed before testing
[optional] What gif best describes this PR or how it makes you feel?

Hey @Toheeb-Ojuolape! Thanks for this! Great work, if you could add some tests that confirm the behavior that would be great!

Hey @Toheeb-Ojuolape! Thanks for this! Great work, if you could add some tests that confirm the behavior that would be great!

Hi @LiranCohen I've added some tests. Hope you find it acceptable. Thank you

Hey @Toheeb-Ojuolape! Thanks for this, I'm seeing a few Type errors in the test runner for some reason, will pull it down in a bit to confirm myself.
For the tests, would you mind creating it's own specific test for each interface that describes the behavior. That way it's easy to find the behavior of the specific test. As well as adding a negative test case (can be within the postiive one as well) to show it returning false.
Something along the lines of `status ok boolean should be true if the response is ok'.


I built a site with Eleventy!

If you want to list your site on 11ty.dev you must create a Pull Request. Unfortunately we can no longer keep up with the scale of creating these files manually from GitHub issues.
To do this, create a new file in _data/sites/*.json with this format: (the source_url field is optional)
{
	"url": "https://www.star-shaped.org/",
	"name": "Star Shaped",
	"description": "A blog about web development, knitting, and other assorted things.",
	"twitter": "starshaped",
}

url: The site’s production URL
name: Name of the site
description: A short text description of the site
twitter: Twitter username for the site or the site’s author.
authoredBy: An array of Twitter usernames of the site’s authors. Supplements the twitter entry. (Optional)
source_url: URL to the source code (Optional)

Opened a PR, #489. Thanks!

please close this issue as the PR was merged


DEPRECATION WARNING is generating when play task 6.1.11 | AUDIT | Ensure no ungrouped files or directories exist

Feature Request or Enhancement

Enhancement [x]

Summary of Request
I want to not get any warnings after playing task 6.1.11 | AUDIT | Ensure no ungrouped files or directories exist
Currently this is the output: [DEPRECATION WARNING]: Specifying a list of dictionaries for vars is deprecated in favor of specifying a dictionary. This feature will be removed in version 2.18.
Describe Alternatives You've Considered
As an alternative solution this tip could be used: Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. But it doesn't solve the problem.
Suggested Code
To do that the list of dictionaries on line https://github.com/Illibur/RHEL9-CIS/blob/devel/tasks/section_6/cis_6.1.x.yml#L233 should be replaced with using a dictionary
  vars:
      - rhel_09_6_1_11_ungrouped_files_found: false

change into:
  vars:
      rhel_09_6_1_11_ungrouped_files_found: false

Thanks Illibur. That was bugging me too. I can roll that into my #177 PR.


Proposal: add eth_baseFeePerGas method

Summary
Add a method, tentatively called eth_baseFeePerGas, to get the base fee of the next block.
Motivation
The base fee of a block can be computed using some values from the previous block, like its base fee and the amount of gas used. The formula to do this isn't that involved so, in principle, clients could do it without the need to ask the node. But:

While the formula is simple, it's not trivial. It also involves integer math that clients could get wrong.
The formula involves some values like ELASTICITY_MULTIPLIER and BASE_FEE_MAX_CHANGE_DENOMINATOR that could change in the future (or even become dynamic values?)

Specification
I'm not sure about the name of the method. eth_baseFeePerGas seems good enough, and consistent with existing methods, but it could be misleading. One alternative is eth_nextBaseFeePerGas or eth_nextBlockBaseFeePerGas.
I don't think this method should receive any params.
The return value would be just an Integer.

Update for this: this might still be included (maybe?), but this value can be obtained right now by doing this:
const { baseFeePerGas } = await provider.send("eth_getBlockByNumber", ["pending", false])

Update for this: this might still be included (maybe?), but this value can be obtained right now by doing this:
const { baseFeePerGas } = await provider.send("eth_getBlockByNumber", ["pending", false])

Will this return a different value depending on the client?

Will this return a different value depending on the client?

My guess is that it shouldn't, but I don't know if that's specified somewhere on this repo.


Talk

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

How to Test
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Please delete options that are not relevant.

[ ] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build 5357

34 of 134 (25.37%)  changed or added relevant lines in 17 files are covered.
4 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.7%) to 31.71%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/features/game/scenes/PlayGame.ts
0
1
0.0%

src/features/game/objects/ObjectsRenderer.ts
0
2
0.0%

src/features/game/parser/ObjectsParser.ts
0
2
0.0%

src/features/game/mode/explore/GameModeExploreManager.ts
0
3
0.0%

src/pages/academy/game/subcomponents/GameActionManager.ts
0
3
0.0%

src/features/game/mode/talk/GameModeTalkManager.ts
0
4
0.0%

src/features/game/dialogue/DialogueRenderer.ts
0
7
0.0%

src/features/game/mode/explore/GameModeExplore.ts
0
7
0.0%

src/features/game/utils/GameUtils.ts
0
10
0.0%

src/features/game/location/GameMap.ts
8
25
32.0%

Files with Coverage Reduction
New Missed Lines
%

src/features/game/mode/talk/GameModeTalkManager.ts
1
0%

src/features/game/mode/talk/GameModeTalk.ts
1
0%

src/pages/academy/game/Game.tsx
1
0%

src/pages/academy/game/subcomponents/GameManager.ts
1
0%

Totals

Change from base Build 5345:
0.7%

Covered Lines:
1833

Relevant Lines:
5356

💛  - Coveralls


When importing a slave with higher UID/GID than master, quotas entries prevent synchronization from occuring

Author Name: Roy Keene (Roy Keene)
Original Redmine Issue: 5450, https://dev.opennebula.org/issues/5450
Original Date: 2017-10-10
Original Assignee: Juan Jose Montiel Cano

In OpenNebula 5.4.1 if you try to import a slave that had a higher GID or UID than the
master's highest UID/GID then when the synchronization occurs the INSERT will fail
with a primary key violation (when trying to create a new group):
Tue Oct 10 15:14:34 2017 [Z100][ONE][E]: SQL command was: INSERT INTO group_quotas (group_oid, body) VALUES  (102,'<QUOTAS><ID>102</ID><DATASTORE_QUOTA></DATASTORE_QUOTA><NETWORK_QUOTA></NETWORK_QUOTA><VM_QUOTA></VM_QUOTA><IMAGE_QUOTA></IMAGE_QUOTA></QUOTAS>'), error 1062 : Duplicate entry '102' for key 'PRIMARY'
Tue Oct 10 15:14:34 2017 [Z100][ReM][I]: Error replicating log entry 206 in zone

Setup conditions:
MASTER
1. onegroup create dev
1. onegroup create ten01

SLAVE
1. onegroup create ops
1. onegroup create ten0
1. onegroup delete ten0
1. onegroup create ten01

Setup federation between master and slave
Then create a new group, which will be group ID #102
Replication to slave will fail because the slave already has an entry in "group_quotas" regarding group ID #102, left over from before the federation
Possible solutions:

Use "INSERT OR REPLACE" for synchronization to replace the invalid data
Delete the "group_quotas" (and likely "user_quotas") data when importing slaves

Original Redmine Comment
Author Name: Roy Keene (Roy Keene)
Original Date: 2017-10-11T16:10:16Z

Attached is a patch I am using.

Original Redmine Comment
Author Name: Juan Jose Montiel Cano (Juan Jose Montiel Cano)
Original Date: 2017-10-27T14:07:47Z

Hello. I'm trying to reproduce this bug but I can't reproduce it, did you delete all users and groups in slave zone? you need to recreate all users and groups into master zone.
You can view a guide about this here: http://docs.opennebula.org/5.4/advanced_components/data_center_federation/federationconfig.html#importing-existing-opennebula-zones
Thanks!

Original Redmine Comment
Author Name: Roy Keene (Roy Keene)
Original Date: 2017-10-27T15:52:56Z

I followed the procedure as documented.  The issue is that when you import the master data into the slave it replaces the USER and GROUP tables on the slave from the master, but does not clear the USER_QUOTAS or GROUP_QUOTAS tables, so they refer to user and group IDs that no longer mean anything, and further if you then try to create a new user/group on the master it will try to create the corresponding blank quota entry on the slave and fail, since the OID key is already present.
It is 100% reproducible in OpenNebula 5.4.1 and I can provide a demo if requested.


[Edgent-407] JsonFunctions additions

add valueOf*()
add unpartitioned()
cleanup some earlier javadoc

looks like test host load/timing issue of unrelated tests: mqtt and fvtiot.  rerun.

arrg. see EDGENT-408 for the MqttOpenTest failures unrelated to these changes.
Continuing and merging these changes.


Fix metadata corruption by cherry pick from tikv

Bug Report
Please answer these questions before submitting your issue. Thanks!
As https://github.com/tikv/tikv/issues/11526 describe
1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiFlash version? (Required)

update


[Masthead] L0 options with dropdown is missing 8px space between label & chevron

Masthead L0 options with dropdown is missing 8px space between label & chevron

Both WC and React carets have the 8px margin styling applied. Looks like there is a difference in the caret svg file sizing that may be causing this.
WC:

React:

@shixiedesign as Anna mentioned above, the 8px margin is in there.

Hey @guilhermelMoraes, the 8px is there but I think the issue is the svg chevron in web components is not the size we're expecting which is causing the spacing to look off. You can see in the Web components vs React screenshots I have above that the svg size is different.


Any Tier Boss idea. The Shadow.

The idea of this boss is that it should by no means be fair, in a way that the boss will not try to fight fair , he will use tricks and underhanded tactics to gain advantage. He is supposed to be fairly  weak in terms of HP and armor, but will not let you hit him for too long. He should have higher then usuall Attack speed, since some of his abilities will be linked with it.
So, the begining of a fight should be non-standart, when your team walks in the boss pit, he is not there, in fact it is completely empty and when someone gets in the middle of a pit, the smoke appears and the boss jumps on a closest target to the center, marking him with unpurgable debuff  Marked, this target will be high priority for some abilities. After the taget is Marked boss aggroes on that target and starts to hit him, but the aggro can be shifted if you stun the boss and then the aggro will be reset on a closest unit to the boss. When Marked taget dies, someone else randomly becomes Marked.
Spell 1: The boss  always has a buff on him which tells what effect his next finishing move wil do, each Xth attack(need to be balaced, depending on attack speed, about each 7-9 seconds finishing move need to proc)  will be finishing move. Buff include: ( Bash a targer for 3 seconds; Apply Rupture; Apply 70% slow with overtime gets weaker, but only if you move, when you stand it gets stronger again; 30% healing decrease; Attacked target will implode after 7 seconds, pushing all nearby allies away; Makes next boss's ability which hits that targer to act as if you are marked(lasts 30 seconds). And those buffs should rotate in predictable manner so you would be able to tell what he will cast next.
Spell 2: The boss dissapears for 5 seconds, after 3 seconds , one of 4 sides of Marked target will be highlited , meaning that when boss appears , he will charge at Marked target from that side. When boss appears he will be quickly dashing to  the Marked target  from the side which was highlited , damaging , stopping and aggroing on the first hero which he encounters on his way , if this hero is Marked , he will take 10000% more damage and be stunned for 7 seconds.
 If the knife drops on the ground, the boss teleports to the knife ,makes a quick spin damaging all nearby units and applying physical DoT, then starts to sprint towards Marked target for 10 seconds, while sprinting the boss has 50% increased attack speed. If the knife hits another hero , who is not Marked then this hero gets blood scent but is not pinned and knife stays in the ground, can still be killed.
Spell 4:The boss smells target who has blood scent on them,  then the boss teleports behind them applying strong bleeding,physical DoT,but doesn't last long, if Marked target also gets this DoT, then it won't dissapear until the unit is healed to full.
At about 70% HP the boss gets into Phase 2.
In Phase 2 all spells get buffed.
Spell 1: THe boss gets finishing move more often.
Spell 2 works the same, but together with the boss an illusion will appear on the opposite side and also sprint to the Marked target, it deals 50% less damage to all non-Marked targets.
Spell3: The boss always teleports to the knife and spins, also and illuson appears at each other knife which already lies on the ground and also spins, dealing 70% of the damage ot all non-Marked, targets.
Spell 4: Together with the physical DoT , magical damage DoT applyed for the same duration, Marked target also gets healing debuff for 50%.
At 30% HP the boss gets into Phase 3.
In Phase 3:
Spell 1 is still showing buff which wil be applyed in the next finishing move, but now it can lie and instead of predictable pattern it randomises.
Spell 2 is still showing indecators,but they also don't have to be true, the dirctions are randomised for boss and the illusion.
Spell 3 the boss is throwing knifes at each player in the boss pit.
Spell 4 the boss also stuns targets for 1.5 seconds.
If you are still reading so far, then thank you  for your attention and have a nice day.

Having the boss only appear if they walk into the center of the arena is a really neat idea. We just need a good way to coerce players into walking into the center. Maybe a free bounty rune or a trail of mangos leading there.
"The idea of this boss is that it should by no means be fair." but remember you have to give players reliable ways of countering these "unfair" moves or else you risk creating an unenjoyable boss fight.
I can't tell from the description but does the "Mark" ever change heroes without those heroes dying? If not I would suggest implementing one or else you'll have players suiciding on purpose just to switch agro or other some such nonsense. What if it switched heroes once or twice each phase based on RNG?
Try and avoid exceedingly long stun duration, maybe replace with something equally unfair but more fun for players.
Idea: What if rupturing a player also healed the boss when the ruptured player moves
Idea: What if you replaced his dash mechanic with a "Skewer" type charge that applies "rupture" if it skewers a marked unit.

Well, by unfair I meant that it is a fighting style of a boss, by means of disjointing projectiles and dissapearing all the time.
About stun, yes I just wanted to highlight that playstyle of "protect the carrier" the Marked unit. Like , the Marked target has to cooperate with the team and together they work towards blocking boss's tricks, so stun can be replaced by heavy debuff, like bleed DoT or may be some other form of CC witch is not so boring, may be something like moderate slow witch grows if you try to move and decrease when you stand.
The problem with switching is that I supposed that the team ought to deliberately make a choice whom to mark, because the marked  target has a lot of pressure on them, I really don't think that randomizing it would be benefitial, but may be through some sort of predictable cast it is possible to change the mark up, but to be honest it is up to debate, since again the point of a fight is to make the Marked target someone who needs you akin to bodyguards, so it can be argued against swithching roles up or not.
Healing boss while moving with bleed from spell 3 can be interesting and certantely can e considered, may be as addition from Phase 2.
As per dash, I really just meant that Boss becomes sort of a projectile which has to be blocked, so any type of movement should be fine as long as it's tragectory is predictable.
Thank you on your imput, please feel free to comment on any of my ideas, I am open to the debate.

I don't like the mark being permanent and based on which hero was nearest center. It doesn't make sense and it's one of those 4th wall breaking spells that just feel icky. "The players know the mechanic and sent in ursa/bristle/axe/misha first and the 'Trickster' god just plays into it" What kind of Trickster is he if he is pwned by his own mechanic!? Then the team that doesn't know this one very trivial detail (sending the right player to the right spot at the right time before the fight) has NO CHANCE to defeat the boss, not because they're bad, but because they sent in skywrath or crystal maiden first!
This needs to be changed. It's the one ugly detail that's ruining an otherwise perfectly reasonable concept.

Hiding idea is cool. Can be used with better mechanics though. Closed.


Style radio buttons

Style the radio buttons to match the theme of the rest of the extension.

#75 Completes this task.


[MINOR] Code improvement for Java

Why are the changes needed?

To satisfied the code scanning suggestion of Java language by CodeQL, with no feature changes

Ignored error status of call

https://github.com/apache/kyuubi/security/code-scanning/88

Inefficient empty string test

https://github.com/apache/kyuubi/security/code-scanning/87

Inefficient String constructor

https://github.com/apache/kyuubi/security/code-scanning/84

Missing Override annotation

https://github.com/apache/kyuubi/security/code-scanning/78
https://github.com/apache/kyuubi/security/code-scanning/79
https://github.com/apache/kyuubi/security/code-scanning/80
https://github.com/apache/kyuubi/security/code-scanning/81
https://github.com/apache/kyuubi/security/code-scanning/82
https://github.com/apache/kyuubi/security/code-scanning/83

Useless toString on String

https://github.com/apache/kyuubi/security/code-scanning/108

Use of default toString()

https://github.com/apache/kyuubi/security/code-scanning/107

Unread local variable

https://github.com/apache/kyuubi/security/code-scanning/96

Random used only once

https://github.com/apache/kyuubi/security/code-scanning/192
https://github.com/apache/kyuubi/security/code-scanning/191

Missing enum case in switch

https://github.com/apache/kyuubi/security/code-scanning/193

redundant usages of length when calling substring

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #4944 (b1b4dfa) into master (a9fcf3f) will not change coverage.
The diff coverage is 0.00%.

 Learn more

Thanks, merged to master.


Kworkingbranch

Hello I added a nav bar to add more styling and added a few buttons to direct to home menu twitter search and download zip file button . also  can automatically link to artist name.

I also cropped spotify and deezer picture to even the spacing in the column


flex-column needs flex-row

The .flex-column class sets the flex direction, but any embedded flex-boxes inherit this attribute on Safari 9.0.3.
an attribute to revert or set row direction --  .flex-row or .flex-reset or ??? would be a welcome.

need this too!


Add recording for additional test case, automate recorded config capture

Updated the test fine tuning model deployment client to also enable capturing a recording and playing it back. That test case now also has a recording
The playback configuration is now also captured and recorded while recording mode, and then automatically sanitized and saved saved back at the end of the recording to ensure it remains up to date automatically
In playback mode the tests will now always use the saved "playback" configuration. This makes the tests running locally behave the same as those running in CI/CD to make it easier to catch issues

API change check
API changes are not detected in this pull request.


ci: bypass proxy.golang.org in Go toolchain installation

Directly access golang.org/dl to avoid errors such as

go: golang.org/dl/go1.21.4@latest: module golang.org/dl/go1.21.4: Get "https://proxy.golang.org/golang.org/dl/go1.21.4/@v/list": dial tcp: lookup proxy.golang.org on <IP_ADDRESS>:53: server misbehaving
Error: Process completed with exit code 1.

Reported-by: Julian Wiedmann<EMAIL_ADDRESS>

/ci-verifier

Marked for backport to all stable branches as it enhances https://github.com/cilium/cilium/pull/27857


[Middlewarify] Middlewarify map controller

Still, in development. Don't ready for CR. Just for awareness.
Note: I've tried as much as possible to commit step by step in order to show you the process that I've followed.
This PR aims to break responsibilities into middlewares. Each middleware tries to follow SRP principle. By composing them in a set of middlewares we can perform, for instance, map creation (anonymous) or map instantiation (named map).
The good parts:

Smaller functions, improving readability and maintainability (easy to add, modify or remove middlewares). We will be able to compose and reuse them in multiple ways.
Improved error handling: taking advantage of middleware system to short-circuit the normal workflow.
Graceful asynchronous code handling: by using callback provided by express' middleware system. Step module is no longer needed.

The bad parts:

Rely on res.locals to pass info and results of previous middlewares to next middleware. I do believe there is a room of improvements here. Stay tuned ;)

This PR materializes the middleware architecture that I've tried to explain some time ago.

Hey folks!
It's alive!!! and ready for CR...
I've stopped this PR at this point, we can go deeper in some areas but I thought that it could be too hard to follow the following changes. I've broken functionality as much as possible, by refactoring other controllers we will find common middlewares among them. At the moment, all middlewares belong to map controller but my idea is that they end up being refactored as isolated middlewares.
Furthermore, map controller is responsible for building middlewares, so map controller needs their dependencies to build them. In the future controller should only know about middlewares. After refactoring all controllers, I want to see how the rest of them (layergroup, named-maps, etc..) look like before changing current app building system.
Please don't hesitate to comment or share your comments.

res.locals is crying out loud for a refactor. Currently it looks like a catchall global variable. It's better than before, though.
We need to order res.locals into buckets:

res.locals.db
res.locals.auth
res.locals.user
...

In order to abstract this res.locals thing, we could initialize all the middlewares with the appropriate context buckets.
   MapController.prototype.composeCreateMapMiddleware = (res, useTemplate = false) => {
   ...
   const context = res.locals;

    return [
        cors(),
        userMiddleware(context),
        this.prepareContext(context),
        doSomethingWithUser({user: context.user}),
        doSomethingWithUserAndAuth({user: context.user, auth: context.auth})
    ];
};

I think that this res.locals refactor should NOT go in this PR.

res.locals is crying out loud for a refactor.

+1000

In order to abstract this res.locals thing, we could initialize all the middlewares with the appropriate context buckets

If we go for it then we have to compose middlewares for each incoming request. That's is going to penalize response times for sure. So we need to create middleware chain while building the application.
For the time being, I'll go for your proposal of namespacing res.locals.
Thanks for the feedback

:+1: totally agree with your comments
We must try to stop using the URL params from res.locals and start using them from req.params. Is the first step to decouple both "params containers" and in the future we can remove req.params from res.locals

The final objective should be to establish res.locals as the single source of truth for the input parameters. res.locals should be initialized by the middlewares with the data held in (among others):

res.params
res.body
res.query
res.get(headerName)
res.hostname

The controllers should work only with res.locals.

I don't think so or maybe I'm not understanding you.
Why do we need to duplicate de params? What is the advantage of reading a URL param from res.locals instead of req.params or a header from res.locals instead of req.get()? Why doesn't a controller work with Request and Response objects (including the res.locals)?
In addition to "maintaining the same things twice" and the problems related to it, using a single source of truth adds a lot of problems: services/methods receiving unneeded info, lazy dependencies ... Really, until some weeks ago, we had a single source of truth: req.params

The controllers shouldn't know that they run inside an Express application (req/res). They should receive only a big context parameter (set to res.locals in this case) or ideally an object with only the data they need: {user, db, ...}
We refactored/are refactoring it to res.locals instead of req.params because it's the recommended way of doing it now (stackoverflow). req.params should only be used for the request's urls params (/:i-am-a-parameter)
One purpose of using res.locals is to abstract the controllers of the info's source. For example some parameters can be sent using query params, body fields or http headers. Handling this in the controllers only adds noise. In addition, this approach let's us decouple input handling from processing.
Nice thread 😄

what I said, but in animated gif format


linuxPackages.rtw88: 2022-11-05 -> 2023-07-23

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Tested on Steam Deck (rtl8822ce), works well and seems to be a slight performance improvement over vendor driver.


ExtendedTools: crash and memory leak in Object Manager tool

Environment
System Informer 3.0.7310 (bc98048)
Windows 10 x64 22H2
Description
The following steps lead to a System Informer crash:

Open Tools -> System -> Object Manager
Select any object in the right pane and click "Security" in the context menu
Close the security editor/message box
Select "Security" again on the same object
System Informer crashes (0xC0000005 / STATUS_ACCESS_VIOLATION) at https://github.com/winsiderss/systeminformer/blob/5d97d6b3f99bd7c651b448ae414f39150cf9af2f/plugins/ExtendedTools/objmgr.c#L534

I believe this happens because EtObjectManagerHandleCloseCallback wrongly deletes the entry->Name and entry->TypeName strings after showing the security dialog, but they are still needed e.g. when clicking on "Security" again.
Additionally it seems that the Name and TypeName strings for the current shown objects are not freed when navigating to another directory on the left pane, leading to a memory leak of string objects. This can be seen by rapidly switching between directories and watching the memory usage and object counts. There is a cleanup function EtCleanupTreeViewItemParams, but it's only called when the Object Manager tool is closed and not when we change between directories. (And shouldn't EtCleanupTreeViewItemParams also cleanup item->TypeName in addition to item->Name?)

Thanks, fixed 👍


Fix account switcher on Discover page - fixes #857

The switcher will now render correctly on the Discover repositories page.

The result looks good, but tests are failing.

My suggested regex was matching a lot of pages as isDashboard, which made isRepo fail.

How would this be fixed?


Package isolation tests failing

Description of the issue
dev_tools/packaging/isolated_packages_test.py::test_isolated_packages is failing in several PRs (example).
Error log

=================================== FAILURES ===================================
_____________________ test_isolated_packages[cirq-google] ______________________
[gw0] linux -- Python 3.8.12 /opt/hostedtoolcache/Python/3.8.12/x64/bin/python

cloned_env = <function cloned_env.<locals>.base_env_creator at 0x7f6079dccdc0>
module = Module(root=PosixPath('cirq-google'), raw_setup={'name': 'cirq-google', 'version': '0.15.0.dev', 'url': 'http://github...res=['google-api-core[grpc] >= 1.14.0, < 2.0.0dev', 'proto-plus>=1.20.0', 'protobuf>=3.13.0', 'cirq-core==0.15.0.dev'])

    @pytest.mark.slow
    # ensure that no cirq packages are on the PYTHONPATH, this is important, otherwise
    # the "isolation" fails and for example cirq-core would be on the PATH
    @mock.patch.dict(os.environ, {"PYTHONPATH": ""})
    @pytest.mark.parametrize('module', list_modules(), ids=[m.name for m in list_modules()])
    def test_isolated_packages(cloned_env, module):
        env = cloned_env("isolated_packages", *PACKAGES)

        if str(module.root) != "cirq-core":
            assert f'cirq-core=={module.version}' in module.install_requires

        result = shell_tools.run_cmd(
            *f"{env}/bin/pip install ./{module.root} ./cirq-core".split(),
            err=shell_tools.TeeCapture(),
            raise_on_fail=False,
        )
>       assert result.exit_code == 0, f"Failed to install {module.name}:\n{result.err}"
E       AssertionError: Failed to install cirq-google:
E           DEPRECATION: A future pip version will change local packages to be built in-place without first copying to a temporary directory. We recommend you use --use-feature=in-tree-build to test your packages with this new behavior before it becomes the default.
E            pip 21.3 will remove support for this functionality. You can find discussion regarding this at https://github.com/pypa/pip/issues/7555.
E         ERROR: Could not install packages due to an OSError: [('/home/runner/work/Cirq/Cirq/cirq-core/cirq/interop/quirk/cells/__pycache__/parse_test.cpython-38-pytest-7.1.1.pyc.[18](https://github.com/quantumlib/Cirq/runs/6103992908?check_suite_focus=true#step:5:18)18', '/tmp/pip-req-build-zfalukpo/cirq/interop/quirk/cells/__pycache__/parse_test.cpython-38-pytest-7.1.1.pyc.1818', "[Errno 2] No such file or directory: '/home/runner/work/Cirq/Cirq/cirq-core/cirq/interop/quirk/cells/__pycache__/parse_test.cpython-38-pytest-7.1.1.pyc.1818'")]
E
E         WARNING: You are using pip version [21](https://github.com/quantumlib/Cirq/runs/6103992908?check_suite_focus=true#step:5:21).2.4; however, version [22](https://github.com/quantumlib/Cirq/runs/6103992908?check_suite_focus=true#step:5:22).0.4 is available.
E         You should consider upgrading via the '/tmp/cirq-pytest/ce65cd07-09fb-48b4-a75c-5bc633b87b[25](https://github.com/quantumlib/Cirq/runs/6103992908?check_suite_focus=true#step:5:25)/bin/python -m pip install --upgrade pip' command.
E
E       assert 1 == 0
E        +  where 1 = CommandOutput(out=None, err='  DEPRECATION: A future pip version will change local packages to be built in-place witho...mp/cirq-pytest/ce65cd07-09fb-48b4-a75c-5bc6[33](https://github.com/quantumlib/Cirq/runs/6103992908?check_suite_focus=true#step:5:33)b87b25/bin/python -m pip install --upgrade pip\' command.\n', exit_code=1).exit_code

Cirq version
cirq-core==0.15.0.dev

Suspected to be transient: OSError: ERROR: Could not install packages due to an OSError: [('/home/runner/work/Cirq/Cirq/cirq-core/cirq/interop/quirk/cells/__pycache__/parse_test.cpython-38-pytest-7.1.1.pyc.1818', '/tmp/pip-req-build-zfalukpo/cirq/interop/quirk/cells/__pycache__/parse_test.cpython-38-pytest-7.1.1.pyc.1818', "[Errno 2] No such file or directory: '/home/runner/work/Cirq/Cirq/cirq-core/cirq/interop/quirk/cells/__pycache__/parse_test.cpython-38-pytest-7.1.1.pyc.1818'")]


Adjust the default log priority order,  use slf4j first

What is the purpose of the change
Adjust the default log priority order,  use slf4j first.
Currently using slf4j most.
Due to the priority log4j, dubbo has no log output.
dubbo.application.logger must be configured to take effect.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


AAF read adapter should look for type Clip when it's finding a Marker's parent element from the Track

In merge request https://github.com/PixarAnimationStudios/OpenTimelineIO/pull/1239, it left markers with the Track if target_track.child_at_time(marker.marked_range.start_time) returns something that does not have markers property, for example Transition.
This is less-than ideal. Instead, it should probably look for Clip and attach the marker to the clip found.

From the TSC Meeting: Do we want to add some API so child_at_time can filter down so we avoid returning transitions? Do we ever want a transition returned by this method?

Yes, I think that is a good idea. The work-around #1239 has been merged for now, but your suggestion would be a cleaner fix.
Does it even make sense for child_at_time to ever return a Transition? Shouldn't a Transition always overlap a different child of the parent Composition?


Unstructured OpenstackProviderSpec

Another attempt to address the move of OpenstackProviderSpec from cluster-api-provider-openstack to openstack/api/machine. See #2117 for background. In that PR, we simply replaced our imports. The result is that we could only decode the new thing. The problem is that we may still get the old thing if we're talking to an old cluster.
We only need the decoding to steal the osImage from the master machines so we can use that value for new workers. Rather than importing both schemata, trying to figure out which version we're talking to, and decoding against the correct one, this commit unmarshals the providerSpec as raw JSON into an Unstructured object and explicitly paths into it map-wise.
On the creation side, we're told that the spoke cluster itself will understand the new thing even if it's an old version (MAPI also unmarshals the JSON raw). So it should be fine to continue using recent vendored installer code to generate MachineSets (which will contain new-apiVersion OpenstackProviderSpec).
HIVE-2308

/assign @lleshchi
/cc @JoelSpeed @dtthuynh

/hold
Trying to find out if we can do pre-merge testing.

/hold cancel
@dtthuynh has verified this fix manually, seems to work :+1:

/lgtm

/cherry-pick mce-2.5

/cherry-pick mce-2.5

Sure, just ignore me completely, bot. I'll do it manually: #2200


Revising data literal syntax.

I'm thinking of reverting to the previous {} and [] syntax for data literals.
Although using [] for all data literals was a neat idea and unambiguous with indexing,
it's easier to visually distinguish list data from record data if the delimiters are different.
It's also easier to visually separate an initializing type from the payload:
T[a: 123] vs [T a: 123].
It get's worse if T is a generic expansion or an array-like type for eg: [[]T 1, 2, 3]
Although it could be avoided with inference var a []T = [1, 2, 3],
it's better to allow an idiomatic rhs initializer: var a = []T[1, 2, 3]
This also means the empty record literal doesn't need special syntax. Previously [:], would change to {}.
Some other awkward cases with the current syntax:
Record literal inside array literal: [[a: 123]]
Declaring record members in multiple lines:
var b = [T
  a: 123,
  b: 234,
]

Resolved with c75689bfbbcc761d0b23ad33a854a15761ff2ccd


Suggestion: Add indicator at the market of an already whispered offer.

🚀 feature request
Is your feature request related to a problem? Please describe.

When using the market functionality in the overlay, whispering a trader should mark that you've sent them a message in order to avoid confusion as to who has already been contacted.
Describe the solution you'd like

A marker or some text notifying the user that this trader has already been contacted through the overlay.

Hi, thanks for creating an issue. This seems like a neat idea to add.

1.0.8 (2020-07-09)

added a lower opacity for market results once they have been requested (#780)

Requested results are now displayed with a lower opacity to be distinct able. Thanks for your suggestion!


Hydration error using asynchronous global state (Pinia, useState) between adjacent component

Environment

Operating System: Windows_NT
Node Version:     v20.0.0
Nuxt Version:     3.11.1
CLI Version:      3.11.1
Nitro Version:    2.9.5
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      app, runtimeConfig, css, googleFonts, modules, devtools, srcDir, dir, alias, pinia
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-u2kiq1?file=app.vue
Describe the bug
My application needs to share asynchronous information between two adjacent component, but hydration errors are returned to me and this is very frustrating.
look example below, simple application using useState, but we have a same error using Pinia
https://stackblitz.com/edit/nuxt-starter-u2kiq1?file=app.vue
Where am I going wrong?
Additional context
No response
Logs
[Vue warn]: Hydration node mismatch:
- rendered on server: <!---->
- expected on client: div

On the road right now but could be similar to https://github.com/nuxt/nuxt/issues/19258

@manniL
Yeah, is similar, but to Global State it shouldn't be error, right? For cascade flow we can use a prop...

I think this is the same issue as https://www.youtube.com/watch?v=dZSNW07sO-A.
Global state can't update HTML that has already been rendered.

@danielroe Wow, I was surprised to learn that this operation is as expected from nuxt 3, a big change that didn't exist in nuxt 2, we were able to render there, as the flow was something more global.
It was clear that in nuxt 3 we will have to work on a flow of props and emitters so that the application recognizes the changes and re-renders it correctly.
"Global status will just be a shortcut to not go from prop to prop"


CHAOS-3328 helm install and upgrade

Helm upgrade and install infra

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65e86cc538461c0914a30d7a--harness-developer.netlify.app


[mujs] Missing fixes

Follow-up from #29543:

Fix name of unofficial cmake config.
Fix version information of cmake config.
Add and document official usage: mujs.pc (as in upstream makefile)
Link libm when available  (as in upstream makefile)
Enable shared linkage for non-windows  (as in upstream makefile)
Cleanup

Extras remarks (not adressed):

The unofficial cmake config is fairly obsolete with the official pc file.
The official downloads are at https://mujs.com/downloads/
There is also a GH organization matching the company's name, but it seems less popular:
https://github.com/ArtifexSoftware/mujs
The licensing might be more complex:
https://tracker.debian.org/media/packages/m/mujs/copyright-1.3.2-1

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Thanks for the fix @dg0yt. This looks much better.

Why all those changes I was not aware of?

Why all those changes I was not aware of? Are those new requirements for all future ports?

Some changes are identical to what I requested for mupdf, your other PR.
Some changes are for old port shortcomings with regard to upstream.
Some changes are pure cleanup.
It is all based on the current maintainer guidelines.
To discuss all those issues, it needs fair time for review and constructive communication.


This library is already included into the Scraping section.


hotkey 'ctrl+c' invalid in outer terminal

VSCode Version: 1.21
OS Version: win10

hotkey 'ctrl+c' invalid in outer terminal when open from vscode

Duplicate of https://github.com/Microsoft/vscode/issues/6451


Conflict in docs when navigation menu items have the same name

Documentation Issue
Small bug I ran into on the beta docs. Noticed this specifically for the "On This Page" navigation sidebar on the right side of the page, but might be present in other places. It look like when two sections have the same name, the links and the indicator to show which section is active always jumps to the last of the two sections.
Saw this issue specifically in the "Lexical Building Custom Features" section here, where both the "Server Features" and the "Client Features" section have a "Markdown Transformers" sections and a "Nodes" section.
Additional Details

I've merged in a feature here to give us the ability to add custom #anchors to the docs to prevent this issue. Once we update the source docs, this will be fixed 👍🏽


Fix swiping on the iPad

On larger screen sizes the swiping does not swipe all the way.

Closed with 7efc3adc8fc68119f0368451d64e3ca68ad57cbf


sorting-room: Align hints.md content to sorting_room.go source

In the hints.md, it describes that we can check if this is FancyBox.
That is inconsistent to the type in sorting_room.go source.
I think FancyNumber is supposed to be the correct word in the hint.

Thanks for the review and merge. :)


SendTransaction request

Description
Closes #18
Type of change

[ ] New feature (non-breaking change which adds functionality)

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Pull Request Test Coverage Report for Build 6a728f28715d8899f38398a23266491a59653a37-PR-34

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build ad932605898b88c4966fadf8167963d66e3ca2c5:
0%

Covered Lines:
133

Relevant Lines:
133

💛  - Coveralls


Build PyPi package

It'd be super awesome if the framework was available as a pip package.
It doesnt matter as much if it's hosted somewhere else than the actual PyPi registry...
BTW, i do have a branch with this done but cant push it here.

This was done using Poetry and published to private Gitlab instance, would be best to keep the 'public' framework package available publicly (PyPi or Github?)

This was built and pushed temporarily to https://pypi.org/project/neuroglia-python/ (neuroglia was already taken!).
I'll push a PR for these additions...


Add optional target regions input

This should limit all variant callers to only calling variants within the target regions.

There are many IDT custom captures and a few other targeted panels, but I think this is the latest IDT exome panel we have 'xGen Lockdown Exome Panel v1 capture set' with hg19 BED file located here:
/gscmnt/gc13025/info/feature_list/94b23d66f667472690a7ee165e2037b6/94b23d66f667472690a7ee165e2037b6.bed
We will need to create interval lists (one for targets, one for tiled) instead of BED files. Also, the coordinate system will need to be liftedOver from nimblegen-human-buildhg19 to GRCh38DH.


Fix #25

The fix of card #25 is very simple, you can handle both types of args just by adding  if "use_tools" in kwargs.keys() and (kwargs["use_tools"] == "True" or kwargs["use_tools"] == True):.

@Demian143 thanks a lot for your PR. I just confirmed the new test passed!


Syntax highlighting

I know it's been implemented with 0.2.0 but how do I actually use it? Does it automatically detect code blocks, can I specify a highlighter to be used (language) and which languages are actually supported?

Hi @daenney!
Yes, code blocks are automatically detected, actually the highlighter is highlight.js and you can specify your language, for example ruby :
[source,ruby]
----
require 'sinatra'

get '/hi' do
  "Hello World!"
end
----

You can find more informations in the asciidoctor documentation :
http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#source-code

Thanks!

You're welcome


Pac paportal download reverse manifests records order at each execution

I don't know if this is the right place to ask the problem but every time I run the following command in the vscode terminal :
pac paportal download --path '.' --webSiteId 'xxx' --overwrite
then the records in the .portalconfig/org-manifest.yml and .portalconfig/manifest.yml files are rewritten in the reverse order of the previous execution.
It forces me to rerun the command before committing files to avoid unintelligible diff in commit history.

Yes, I have verified this behavior, running download the second time eliminates the inadvertent diff. As this is not ideal, we will look into this issue.

This issue has been fixed and will be shipped as a part of our upcoming release in January.

@ThierryBIENVENU, the fix has been released with Power Platform Tools v1.1.16.

Thanks @MrRishabhJain for the follow-up.
I've tested v1.1.16 and the manifiest is more stable but there are new component with DisplayName $RELATIONSHIP$adx_webpageaccesscontrolrule: and $RELATIONSHIP$adx_entitypermission: which change order now at each download.
Oddly, even if there no change, cheksum change. See capture

@ThierryBIENVENU, Thanks for bringing this scenario to our attention, seems like sorting records beyond the record ID is required here. Will update here once this fix is released.

Hey @ThierryBIENVENU, we had resolved this issue and the manifest should be generating successfully now, can you please confirm?

Hello @MrRishabhJain, Nice to hear, the manifest is much more stable now and generates less noise during commit.
Great job.


The defect in Log Writer

file: framework/src/Illuminate/Log/Writer.php
line 214: $this->monolog->pushHandler($handler = new StreamHandler($path, $this->parseLevel($level)));
Pls use param $filePermission when new Monolog\Handler\StreamHandler.
For example, the params for Monolog\Handler\StreamHandler -> __construct, $filePermission default NULL.
At this time, file mod always is 644. And there is a log file created by http user, then console user 'Jam' in a diffrent group , now Jam can't write it, also when he execute 'artisan', that's important.

We're open to PRs please. :)

@GrahamCampbell
Emmm....I feel a little embarrassed. (:3」∠)
I'm not good at English, what is 'PRs'?
And I have a suggest... Logfile' mod can defined by config file.

Does that mean ’Pre-release‘ ?

PR = Pull request. Sorry about that.

Hah hah hah. It's doesn't matter. Thank you.


Refactor parameter initialization and validation

This change separates parameter default value in signature, type of validation and initialization expression inside method body into separate fields and moves logic from CodeWriterExtension into Parameter itself.
Fixes https://github.com/Azure/autorest.csharp/issues/2208

I thought whether a parameter is required would be decoupled from DefaultValue. If this is still the case, why remove the IsRequired and add a IsOptional? What is the difference from before?

From docs.microsoft.com: "Each optional parameter has a default value as part of its definition. If no argument is sent for that parameter, the default value is used."
We can call property "IsSignatureOptional" to make the difference clear


Better memory observation for tidb_query executors

Feature Request
Inspired from https://github.com/pingcap/tidb/issues/11840. Currently we have no existing way to check how much memory is used in some memory-heavy executors like hash aggregation and top n. Adding metrics to these executors should help diagnose these kind of problems without the need to build a specialized binary.

Hello @breeswish I am interested to contribute to this issue

@AlyHKafoury Thanks for your interest. Do you need any help or guidance?

@breeswish Yes please, it is my first contribution to the rust community.

@AlyHKafoury As for this issue, you may consider starting from TopN executor first (top_n_executor.rs). You can increase a variable recording memory usage when a bulk of record is   inserted to the heap. And finally, at the place where execution is finished, e.g. collect_statistics, you can collect the memory usage to a global prometheus metrics (or a local prometheus metric which later flushes to the global prometheus metrics). However Arc is heavily used in TopN executor so how to correctly count memory usage can be a challenge (you may record a memory usage that far larger than actual use).

@breeswish Great explanation, I will start to give it a look today and ask for further instructions if needed

@breeswish Is the size only affected for BatchTopNExecutor or the size of other structs is also important ?

@AlyHKafoury Sorry for the late reply! I miss the notification. Ideally you should observe memory usage for all executors. However other executor will not use much memory.


When visualizing a pose, why is self.ax.invert_xaxis() used?

When visualizing a pose, why is self.ax.invert_xaxis() used?
What exactly is the definition of 'extrinsic'?
@suniique

I noticed that the extrinsic is an x-North, y-East, z-Up coordinate system, which isn’t the right-handed coordinate system, so use self.ax.invert_xaxis.


Swiper wont render the item at the centre vertically

<Swiper>
  <View  style={{ flex: 1, backgroundColor: 'red', justifyContent: 'center', alignItems: 'center' }} >
    <Text>HELLO WORLD</Text>
  </View>
</Swiper>

This is the complete jsx in the page.
Attached screenshot:  https://ibb.co/nz4LaQ. The text is not aligned in the centre vertically.

Try to use margin: 0 auto (or margin-vertical: 0 and margin-horizontal: auto) on your <View> component.


to top does not properly append to body in ie8.

to top is not appending to the body as it should in ie8.  works fine in ie9+..  is this intended bryce?  do you still support ie8 with jqmodal?
div.jqm({
    toTop: true,
    modal: true,
    overlay: 100,
}).jqmShow();

IE8 is definitely supported. I dropped ActiveX bleed-through code for IE6 during the rewrite, so that browser is not 100%, but IE8 should be. Can you pass along your code example (@ http://plnkr.co/ ) ?


The 2nd VoLTE Video call, no image is displayed.

Hi!
I clone the repository and build all docker images, then do call VoLTE Voice and Video.
It do well in VoLTE Voice, But during the 2nd/4th/... VoLTE Video call, no image is displayed.
Logs:
(1)pgw
09/07 08:30:00.094: [pgw] WARNING: No need to send 'Delete Bearer Request' (../src/pgw/pgw-gx-handler.c:394)
09/07 08:30:00.094: [pgw] WARNING:   - Bearer[Name:ims1] has already been removed. (../src/pgw/pgw-gx-handler.c:396)
09/07 08:30:00.095: [pgw] WARNING: No need to send 'Delete Bearer Request' (../src/pgw/pgw-gx-handler.c:394)
09/07 08:30:00.095: [pgw] WARNING:   - Bearer[Name:ims1] has already been removed. (../src/pgw/pgw-gx-handler.c:396)

09/07 08:30:22.705: [gtp] WARNING: [31] LOCAL  No Reponse. Give up! for step 1 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:599)
09/07 08:30:22.711: [gtp] WARNING: [33] LOCAL  No Reponse. Give up! for step 1 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:599)
09/07 08:30:22.782: [gtp] WARNING: [8388657] REMOTE No Reponse. Give up! for step 2 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:599)
09/07 08:30:38.193: [pgw] WARNING: No need to send 'Update Bearer Request' (../src/pgw/pgw-gx-handler.c:335)
09/07 08:30:38.193: [pgw] WARNING:   - Both QoS and TFT are same as before (../src/pgw/pgw-gx-handler.c:336)

(2)mme
09/07 08:30:13.782: [esm] ERROR: Unknown message(type:203) (../src/mme/esm-sm.c:250)
09/07 08:30:13.789: [esm] ERROR: Unknown message(type:203) (../src/mme/esm-sm.c:250)
09/07 08:30:13.790: [esm] ERROR: Unknown message(type:203) (../src/mme/esm-sm.c:250)
09/07 08:30:13.819: [esm] ERROR: Unknown message(type:203) (../src/mme/esm-sm.c:250)
09/07 08:30:16.704: [gtp] WARNING: [45] REMOTE Request Duplicated. Discard! for step 1 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:402)
09/07 08:30:16.710: [gtp] WARNING: [47] REMOTE Request Duplicated. Discard! for step 1 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:402)
09/07 08:30:16.750: [gtp] WARNING: [8388627] LOCAL  Request Duplicated. Discard! for step 2 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:337)
09/07 08:30:16.781: [gtp] WARNING: [8388628] LOCAL  Request Duplicated. Discard! for step 2 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:337)
09/07 08:30:19.704: [gtp] WARNING: [45] REMOTE Request Duplicated. Discard! for step 1 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:402)
09/07 08:30:19.711: [gtp] WARNING: [47] REMOTE Request Duplicated. Discard! for step 1 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:402)
09/07 08:30:19.751: [gtp] WARNING: [8388627] LOCAL  Request Duplicated. Discard! for step 2 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:337)
09/07 08:30:19.782: [gtp] WARNING: [8388628] LOCAL  Request Duplicated. Discard! for step 2 type 97 peer [<IP_ADDRESS>]:2123 (../lib/gtp/xact.c:337)

Pcaps：
VoLTE Video 2nd not Good.zip

Hi @GuoXiaxuan : Very happy to hear that voice call works flawlessly. Sorry to say this but I don't think Video call works properly at the moment as I haven't tested it myself extensively. I believe there is significant work to be done for Video call so I don't know when I will be able to support Video call

@herlesupreeth Thank you very much for your contribution, I will continue to pay attention to this project.

@GuoXiaxuan I fixed some RTP configuration bugs, can you now give it a try with Video call?

Did you get the chance to try out video call. I would like to close this issue

Video calling is tested and it should work. Closing this due to inactivity


[DROOLS-993] fix use of globals with temporal operators

Mario, before merging these changes, I think it would be good to fix the tests to use constant globals.

@etirelli Good point Edson, I changed the test.
Merged by https://github.com/droolsjbpm/drools/commit/75cb39d15


Single story hoisting

Just tried out Ladle, that what I wanted to build years ago because SB is too slow and the bundle size is too big
Single story hoisting is the one I missed most
another one is how to inject preview header? I use it to inject google fonts, it would be nice that we can customise the layout

Single story hoisting is the one I missed most

This seems pretty arbitrary, why not just to update the default title?

another one is how to inject preview header?

You should be able to do that through .ladle/components.tsx: https://www.ladle.dev/docs/providers
You can add there useEffect to inject additional tags into the head or use library like react-helmet.

I would love to have the default story be hoisted, yes I managed to make them hoisted by changing the title to components and set storyName as component name

You can add there useEffect to inject additional tags into the head or use library like react-helmet.

yes I can change anything programatically but it would be nice config it directly, for example the document title


refactor PDO_SQLSRV bind param related tests

This change is

Coverage remained the same at 72.541% when pulling f3e31b834d39182bad26cceb5a599861ea375002 on v-kaywon:refactorPDOTests4 into 8f67a413aa4267f2fb9a462c67e88aa3927185f6 on Microsoft:dev.

Codecov Report

Merging #612 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #612   +/-   ##
=======================================
  Coverage   77.17%   77.17%
=======================================
  Files          25       25
  Lines        7308     7308
=======================================
  Hits         5640     5640
  Misses       1668     1668

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f67a41...3b65f26. Read the comment docs.

Coverage remained the same at 72.541% when pulling 3b65f26776f433108a25704c2ac01e7be7fd9a54 on v-kaywon:refactorPDOTests4 into 8f67a413aa4267f2fb9a462c67e88aa3927185f6 on Microsoft:dev.

Coverage remained the same at 72.541% when pulling 9196c557f82649889c175dd2e7c8d0e13eabe666 on v-kaywon:refactorPDOTests4 into 8f67a413aa4267f2fb9a462c67e88aa3927185f6 on Microsoft:dev.

Coverage remained the same at 72.541% when pulling 98d7307860df92bacfcb81bc6a70b1c6dfc1a369 on v-kaywon:refactorPDOTests4 into 8f67a413aa4267f2fb9a462c67e88aa3927185f6 on Microsoft:dev.

Coverage remained the same at 72.541% when pulling c5d02cbeec57899b4452631aa85c96f571cbd832 on v-kaywon:refactorPDOTests4 into 8f67a413aa4267f2fb9a462c67e88aa3927185f6 on Microsoft:dev.

Coverage remained the same at 72.541% when pulling b808f3bd870de04143bbf192d15e0a2db00b832c on v-kaywon:refactorPDOTests4 into 8f67a413aa4267f2fb9a462c67e88aa3927185f6 on Microsoft:dev.


fix broken param name docs

A few param docs were broken using resourceName instead of name: <param resourceName="app">
my guess is a greedy rename refactor broke them
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run

/azp run

/azp run

@radical is this just a flaky test?

/azp run

/azp run

/azp run

/azp run

/azp run

I'm rage merging this one.

@davidfowl i am impressed with how long your persevered.


Cookies aren't set

Hi,
I used this composer script. De forms are correctly passed to Mautic, but there's a problem with the sending of cookies. That doesn't work and don't see any errors.
Do I need to configure something somewhere extra?
CURL is active on the webserver, do I need other modules active?
Kind regards,

Can you make sure that you're using the latest code? Because I was fixing that bit lately.

I installed the latest code, downloaded via composer last week.

Do you have Mautic JS tracking on the website that submits the form?

I have the following Mautic JS included on every page:
<script>             (function(w,d,t,u,n,a,m){w['MauticTrackingObject']=n;                 w[n]=w[n]||function(){(w[n].q=w[n].q||[]).push(arguments)},a=d.createElement(t),                 m=d.getElementsByTagName(t)[0];a.async=1;a.src=u;m.parentNode.insertBefore(a,m)             })(window,document,'script','https://mywebsite.mautic.net/mtc.js','mt');             mt('send', 'pageview');         </script>

Please check if new version 1.1.3 that contains https://github.com/escopecz/mautic-form-submit/pull/9 fixes your issue. If not let us know and I will reopen.


Updated to auto-plugin with minor changes

We updated the plugin with the following changes:

autoplugin
can be used only for integration tests
removed explicit settings for host, port. we use the configMappings
removed setting to initialize cassandra with a cli script

Thanks a lot! This seems like a pretty big PR. Will review this as soon as I can!


add readme badges

I want to add readme badges .Please assign this issue to me under GSSOC

I am working on this issue

@S-ishita you are assigned this issue.

@S-ishita you are assigned this issue.

You forgot to add as assignee .... @Yash-Parsana


Connect backend to frotend

This feels like a rather deprecated issue.
Closing it as it is most likely not needed anymore.


Model does not generate eos when SFTTrainer with setup_chat_format is used

System Info

transformers version: 4.44.2
Platform: Linux-6.1.85+-x86_64-with-glibc2.35
Python version: 3.10.12
Huggingface_hub version: 0.24.6
Safetensors version: 0.4.5
Accelerate version: 0.33.0
Accelerate config: 	not found
PyTorch version (GPU?): 2.4.0+cu121 (True)
Tensorflow version (GPU?): 2.17.0 (True)
Flax version (CPU?/GPU?/TPU?): 0.8.4 (gpu)
Jax version: 0.4.26
JaxLib version: 0.4.26
Using distributed or parallel set-up in script?: No
Using GPU in script?: Yes
GPU type: Tesla T4

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[X] My own task or dataset (give details below)

Reproduction
I am trying to use SFTTrainer along with setup_chat_format. When trained even for large number of steps (max_steps set to 100 in the example below for reproducibility), the model fails to generate eos_token. Instead, it outputs the chat_template directly and then continues to ramble.
Running:
from datasets import load_dataset
from transformers import AutoModelForCausalLM, AutoTokenizer
from trl import SFTConfig, SFTTrainer, setup_chat_format

model_name = "HuggingFaceTB/SmolLM-135M"

tokenizer = AutoTokenizer.from_pretrained(model_name, use_fast=True)
dataset = load_dataset("grammarly/coedit", split="train").filter(lambda x: x["task"] == "gec")
dataset = dataset.train_test_split(test_size=0.005, seed=42)
dataset_train_sft, dataset_test_sft = dataset["train"], dataset["test"]

def format_to_messages(example):
    messages = [
        {"role": "user", "content": example["src"]},
        {"role": "assistant", "content": example["tgt"]}
    ]
    return {"messages": messages}

def format_ds(ds):
    return ds.map(format_to_messages, remove_columns=["src", "tgt", "_id", "task"])

model = AutoModelForCausalLM.from_pretrained(model_name, attn_implementation="sdpa", device_map={"": 0})
model.gradient_checkpointing_enable(gradient_checkpointing_kwargs={"use_reentrant": True})

model, tokenizer = setup_chat_format(model, tokenizer)

training_arguments = SFTConfig(
    output_dir="./sft",
    log_level="debug",
    bf16=torch.cuda.is_bf16_supported(),
    fp16=not torch.cuda.is_bf16_supported(),
    max_steps=100,
    warmup_steps=10,
    max_seq_length=512,
    learning_rate=2e-5,
    eval_strategy="steps",
    eval_steps=50,
    do_eval=True,
    optim="adamw_torch",
    per_device_train_batch_size=4,
    gradient_accumulation_steps=2,
    per_device_eval_batch_size=4,
    save_steps=100,
    logging_steps=50,
)

trainer = SFTTrainer(
    model=model,
    train_dataset=format_ds(dataset_train_sft),
    eval_dataset=format_ds(dataset_test_sft),
    tokenizer=tokenizer,
    args=training_arguments,
)

trainer.train()

inputs = tokenizer.apply_chat_template(
    [{"role": "user", "content": "Improve the grammar: I doesn't like you"}],
    tokenize=True,
    return_tensors="pt",
    add_generation_prompt=True,
).to(trainer.model.device)

tokens = trainer.model.generate(inputs=inputs, max_new_tokens=256)[0]
print(tokenizer.decode(tokens))

Outputs:
<|im_start|>user
Improve the grammar: I doesn't like you<|im_end|>
<|im_start|>assistant
I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like you. I don't like

Is there something I'm doing wrong?
Expected behavior
The generation returns I don't like you.<eos_token>.
I also tried setting tokenizer.padding_size = "left", but it doesn't help

Base model's bos, eos, and pad token ids are the same, however, if you set the chat template bos is changed to <|im_start|>, and eos<|im_end|> and pad token is the same as eos. This is what causes the endless generation because the model does not learn eos_token because it is the same as the pad which is ignored during training. if you change the id of the pad token to something like , it should be fine. This is similar to this issue