Kits and variants leak between windows when using Remote Containers extension

Brief Issue Summary
I have two projects using CMake Tools and Remote Containers extensions for VS Code. When I have them opened simultaneously in two separate VS Code windows, I see that they "interact".
Expected:
Extension instances in different VS Code windows must be isolated from each other.
Apparent Behavior:
I see the following message:
[variant] >> Missing setting "foo" in variant definition.

in the window of the project that does not have "foo" in variants.json.
I have also noticed that changing kit in one window affects saved kit in another window, i.e. if I reload another window, it will change kit too.
Platform and Versions

Operating System: Windows 10, Ubuntu 18.04 in WSL 2, Docker Compose
CMake Version: 3.10.2
VSCode Version: 1.58.0
CMake Tools Extension Version: 1.7.3
Compiler/Toolchain: GCC, Clang

Other Notes/Information
I have to note that both projects mount source at /code directory within container. Maybe it is related (I can imagine that CMake Tools can be using workspace directory to identify cached sessions).
I will be glad to provide more information if needed. These are closed source projects, so I will keep details with me for now.

@i-ky, thank you for opening this report. I think this is by design and the extension cannot differentiate between 2 different projects if they mount towards the same path. The kit selection is saved at project level and path is the key information.
If there would be a bug to save the kit selection at some other level (global versus project) then it would manifest the same but we would have caught this already and it would impact all the users, not only developers that work with remote containers.
Also, does this happen only when you open both projects at the same time? How about when you open one after another, a kit selection done in the previous project is seen in the second project if you open it after you close the first?

@andreeis, thank you for such a prompt response! I will be able to provide answers to your questions tomorrow. But I guess I don't need to open both projects simultaneously. It is just the way I noticed this behaviour. Usually I focus on one project or another, but today I was multi-tasking and both happened to be in front of my eyes at the same time. I should also say that remote development in containers is a new thing for us. There were no issues when developing locally.

I think this is by design and the extension cannot differentiate between 2 different projects if they mount towards the same path. The kit selection is saved at project level and path is the key information.

What do you really mean by "project level"? If I open the same folder locally and in container, is it the same "project level" or different? As I understand, VS Code will treat them as two independent workspaces. And if two projects are opened in their respective development containers, these are two independent workspaces too, even if workspace folder happens to be the same in both containers. And according to documentation, VS Code provides extensions with a workspace specific ExtensionContext.storageUri to store data. It seems that using workspace folder as key is unnecessary.

Makes sense, I will investigate. I only need a repro. I will search for a get started or if you have anything else handy let me know. This is new for me as well and to be able to answer precisely I will have to debug what the extension is doing and explore what better information is available to fix this (if it's a bug and not by design as I thought initially).

Using a workspace folder as the key for some data is necessary to support multi-root workspaces.  If the same folder is opened in several workspaces we can reuse the state saved to that folder if the state is keyed off of the folder URI.  The storageUri, if I'm not mistaken will be different for every "workspace" where that folder is used so the state will appear to have been "lost."

Also, does this happen only when you open both projects at the same time? How about when you open one after another, a kit selection done in the previous project is seen in the second project if you open it after you close the first?

@andreeis, I've done some testing. Settings leak when I open projects one after another as well. Kit selection seems to leak in both directions. Variants leak only one way. This is probably related to project configurations.
Both my projects have same set of kits available for selection, but one of them has more variants. Variant selection leaks from a project with less variants to a project with more variants, but not vice versa.

I only need a repro. I will search for a get started or if you have anything else handy let me know.

Sure. These two projects are closed source, but I guess I will be able to provide you with a minimal example later today.

@bobbrow,

If the same folder is opened in several workspaces we can reuse the state saved to that folder if the state is keyed off of the folder URI.

Shouldn't workspaces be isolated?

If the same folder is opened in several workspaces we can reuse the state saved to that folder if the state is keyed off of the folder URI.

This works well while you are confined within a local filesystem. But if user opens same path/URI from different remote machines or from different containers, the folder should not be "same".

The storageUri, if I'm not mistaken, will be different for every "workspace" where that folder is used so the state will appear to have been "lost."

Yes, I guess so. But there is not much to "loose". Kit and variant can be selected in a few clicks. I may be biased here, but I would really prefer this behaviour. VS Code itself stores UI state (e.g. opened files) per workspace and everyone seems to be happy with that.


Wallabag Configuration

Hi,
I try to configure miniflux to work with Wallabag. Miniflux wants a Wallabag-Client-ID, a Wallabag-Client-Secret, a Wallabag-User, a Wallabag-Password and the Wallabag-API-URL. Most of these required attributes will be created with the creation of a new "client" in Wallabag, except the Wallabag-API-URL.
Do you know, where I can get the Wallabag-API-URL?

Wallabag-API-URL is a base installation URL of Wallabag.
In these examples http://doc.wallabag.org/en/master/developer/api.html
it's http://localhost:8000/


Rebuild ExternalIndex while triggering an index recreation

While invoke index rebuild API with  /admin-ng/index/createIndex, only adminUISearchIndex is cleaned and rebuilt.
This PR make externalIndex cleaned and rebuilt as the same way as adminUISearchIndex.
If externalInbox is not processed in index creation process, some search results will be conflict with each other from different endpoint. This will affect some scenes like batch update data or clean up data.
Your pull request should…

[ ] have a concise title
[ ] close an accompanying issue if one exists
[ ] be against the correct branch
[ ] include migration scripts and documentation, if appropriate
[ ] pass automated tests
[ ] have a clean commit history
[ ] have proper commit messages (title and body) for all commits

This will, I imagine, conflict with #2857 which will likely go in first.  It might be worth your time to look at that PR and see if it solves this issue already.  If not it might make sense to base you work from that branch so that you don't have to come back to as many merge conflicts :D

Isn't that what /api/recreateIndex is for?
If I understood @KatrinIhler correctly, this would become a single index with Opencast 11 anyway, but for now, we probably do not want to mix them, do we?

@lkiesow My mistake, this patch affect 3 endpoints clearIndex, recreateIndex/{service}, recreateIndex.
Besides, I looked into #2857, it's a huge PR with a very good idea.
Yet, this PR still avoid some misleading result in migration and test environment.
So, I think this PR could be merged, and after #2857 is merged, only a few lines should be modified to use one single index.

Sorry, my fault.
Today, I found that, the recreateIndex for adminUISearchIndex is located at /admin-ng/index/recreateIndex.
And, the recrateIndex for externalIndex is located at /api/recreateIndex.
So, just as the API name metioned, there are two different endpoint to handle different index.
I think this PR should not be merged.


🐞 [Bug]: Fix typo in Domains solution

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?
Dashboard
What happened?

Fix: Deploy Domains Instance
Move domains out of the applications and into the deploy section
Remove the ssh dialogue from the deployment list

Steps To Reproduce
No response
which network/s did you face the problem on?
Dev
version
37ba5b4
Twin ID/s
No response
Node ID/s
No response
Farm ID/s
No response
Contract ID/s
No response
Relevant screenshots/screen records

Relevant log output
-

Fix: Deploy Domains Instance

Is the typo here Domain, not domains, Deploy Domain Instance?

Remove the ssh dialogue from the deployment list

Shouldn't the SSH section be removed?

Fix: Deploy Domains Instance

Is the typo here Domain, not domains, Deploy Domain Instance?

Remove the ssh dialogue from the deployment list

Shouldn't the SSH section be removed?

The typo was the a in Deploy a domains instance

Verified, Devnet cc0b65f.
Typo was fixed.

And ssh tips were removed.


feature allow HLL and QUANTILE_STATE types on duplicate table

Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall


Unclear how to complete uprintln! example

The sample we're meant to complete for uprintln! has us implementing the Write trait, but we don't have the std crate available to bring std::fmt into scope. Am I missing something here?

Write is actually defined in core::fmt and then re-exported in std::fmt. I'll add a note about that.

Added a note.


Update nanobox to 2.3.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Package is not code signed, so I've opened an issue on the developer's Github repository.


Button Toggle States Would Look Cool if btn-secondary was the inactive, and another class (btn-primary, btn-danger, etc) could be the active state

I feel like the Button Toggle Inactive and Active states are not clear. I would prefer it myself if the inactive state was styled as btn-secondary, and active state actually used the applied class (such as btn-primary). Maybe a new class would be applicable, so users aren't confused (btn-primary-active).
Here's an example of what I'm talking about:

Here's some CSS to make it work now (it still uses the off color for .active).
[data-toggle="buttons"] .btn:not(.active) {
  color: #373a3c;
  background-color: #fff;
  border-color: #ccc;
}

Not sure of the accessibility implications of the white vs. colorful approach you're suggesting. (/cc @patrickhlauke )

Maybe a new class would be applicable, so users aren't confused

Yeah, if we want this, I think we'd have to go with that route, for consistency and clarity.
Keep in mind that we can't include every permutation of button styles that folks might possibly want; otherwise the framework would become bloated. So this might end up rejected as "interesting, but not common enough".
/cc @mdo to evaluate whether we want this

the colourful version wouldn't be more accessible/inaccessible than the current way of doing it (modulo colour contrasts...which reminds me i need to check the ratios since @mdo changes these recently).
reminder that for each of those states you'll also need a "focused but inactive" and a "focused but active" styling
my main concern though would be that this use of the colour palette may be a bit too....visually opinionanted?

We won't be going this route or providing additional classes for this. Thanks though!


gzip all responses

gzip all responses, will improve our overall performance

@noam-almog I think this is done (or should be done if it's not) on amazon load balancer
adding it here as well will actually harm performance

@noam-almog I can verify and make sure it works on the load balancer if you want

@OriHoch right now responses are not gziped, i checked in dev tools


[jsoncpp] set DEBUG_LIBNAME_SUFFIX=d

Hi @shelltdf
Please update the CONTROL version when modifying a portfile.

Hi @shelltdf, here are the latest test results from the current CI system:

triplet
port
master
test
notes

x64-windows

pdal-c
Pass
Skip

pdal
Pass
Fail
Regression

x64-windows-static

No Change

x64-osx

No Change

arm64-windows

No Change

x86-windows

pdal-c
Pass
Skip

pdal
Pass
Fail
Regression

x64-linux

No Change

x64-uwp

No Change

arm-uwp

No Change

please see #6014. Is there some reason why this is required?

Hey @shelltdf, I'm going to close this PR for now due to lack of activity and unclear motivation for the changes. Feel free to reopen the PR or restart the conversation about these changes whenever it is best for you. Thanks for the contribution!


fix: set the kpm related test cases to execute sequentially

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

fixed #948

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.787%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2293

Relevant Lines:
2612

💛  - Coveralls


Regression for LCA007

System Health details
System Information

version
core-2024.12.5

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.13.0

os_name
Linux

os_version
6.6.66-haos

arch
x86_64

timezone
America/Los_Angeles

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

HACS Data
ok

GitHub API Calls Remaining
4964

Installed Version
2.0.1

Stage
running

Available Repositories
1511

Downloaded Repositories
65

Home Assistant Cloud

logged_in
true

subscription_expiration
June 7, 2025 at 5:00 PM

relayer_connected
true

relayer_region
us-east-1

remote_enabled
true

remote_connected
true

alexa_enabled
false

google_enabled
false

cloud_ice_servers_enabled
true

remote_server
us-east-1-12.ui.nabu.casa

certificate_status
ready

instance_id
a6eaa44fbfa24ac7a868e05f411a3356

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 14.1

update_channel
stable

supervisor_version
supervisor-2024.12.0

agent_version
1.6.0

docker_version
27.2.0

disk_total
62.3 GB

disk_used
23.6 GB

healthy
true

supported
true

host_connectivity
true

supervisor_connectivity
true

ntp_synchronized
true

virtualization
kvm

board
ova

supervisor_api
ok

version_api
ok

installed_addons
Home Assistant Google Drive Backup (0.112.1), Advanced SSH & Web Terminal (19.0.0), RTSP Simple Server Add-on (v0.17.6), Studio Code Server (5.18.0), Z-Wave JS UI (3.18.0), ESPHome Device Builder (2024.12.2), Docker Wyze Bridge (2.10.3), Glances (0.21.1), Firefox (1.3.2), eufy-security-ws (1.9.1), OnStar2MQTT Home Assistant Add-on (BigThunderSR) for Vehicle 1 (1.20.1), Piper (1.5.2), openWakeWord (1.10.0), File editor (5.8.0), Whisper (2.4.0), Music Assistant Server (2.3.4), Matter Server (6.6.1)

Dashboards

dashboards
6

resources
27

views
25

mode
storage

Recorder

oldest_recorder_run
December 18, 2024 at 8:58 PM

current_recorder_run
December 29, 2024 at 3:39 PM

estimated_db_size
4325.93 MiB

database_engine
sqlite

database_version
3.45.3

Sonoff

version
3.8.1 (ffa7e22)

cloud_online
1 / 1

local_online
1 / 1

Checklist

[X] I have read the FAQ to see if there is a known solution to my problem.
[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
Seeing this error message this morning, wasn't seeing it yesterday:
light.great_room_1: Lookup table not found for color mode (model: LCA007, color_mode: hs)

This device is referencing LCA006 for its measurements.  I suspect something has gone wrong here.
Reproduction steps

Install an LCA007
Setup Powercalc
Turn bulb off, then on
Entities go unavailable, errors appear in log
...

Debug logs
2024-12-29 15:56:18.250 DEBUG (MainThread) [custom_components.powercalc.sensors.group.custom] Group sensor sensor.all_lights_power. State change for sensor.family_room_led_strip_power: <state sensor.family_room_led_strip_power=5.78; state_class=measurement, calculation_mode=lut, integration=powercalc, source_entity=light.family_room_led_strip, source_domain=light, energy_sensor_entity_id=sensor.family_room_led_strip_energy, unit_of_measurement=W, device_class=power, friendly_name=Family Room LED Strip power @ 2024-12-29T15:56:18.248760-08:00>
2024-12-29 15:56:18.251 DEBUG (MainThread) [custom_components.powercalc.sensors.group.custom] Group sensor sensor.all_lights_power. State change for sensor.entryway_led_strip_power: <state sensor.entryway_led_strip_power=5.00; state_class=measurement, calculation_mode=lut, integration=powercalc, source_entity=light.entryway_led_strip, source_domain=light, energy_sensor_entity_id=sensor.entryway_led_strip_energy, unit_of_measurement=W, device_class=power, friendly_name=Entryway LED Strip power @ 2024-12-29T15:56:18.249153-08:00>
2024-12-29 15:56:19.209 DEBUG (MainThread) [custom_components.powercalc.sensors.power] light.great_room_1: State changed to "off". Power:0.40
2024-12-29 15:56:19.209 DEBUG (MainThread) [custom_components.powercalc.sensors.group.custom] Group sensor sensor.all_lights_power. State change for sensor.great_room_1_power: <state sensor.great_room_1_power=0.40; state_class=measurement, calculation_mode=lut, integration=powercalc, source_entity=light.great_room_1, source_domain=light, energy_sensor_entity_id=sensor.great_room_1_energy, unit_of_measurement=W, device_class=power, friendly_name=Great room 1 power @ 2024-12-29T15:56:19.209229-08:00>
2024-12-29 15:56:19.209 DEBUG (MainThread) [custom_components.powercalc.sensors.group.custom] Group sensor sensor.all_lights_energy. State change for sensor.great_room_1_energy: <state sensor.great_room_1_energy=18.3358; state_class=total_increasing, source_entity=light.great_room_1, source_domain=light, source=sensor.great_room_1_power, unit_of_measurement=kWh, device_class=energy, icon=mdi:lightning-bolt, friendly_name=Great room 1 energy @ 2024-12-29T15:56:19.209545-08:00>
2024-12-29 15:56:19.209 DEBUG (MainThread) [custom_components.powercalc.sensors.group.custom] sensor.all_lights_energy: Recalculate, current value: 1222.6261
2024-12-29 15:56:19.210 DEBUG (MainThread) [custom_components.powercalc.sensors.group.custom] delta for entity sensor.great_room_1_energy: 0.0000, prev=18.3358, cur=18.3358
2024-12-29 15:56:19.210 DEBUG (MainThread) [custom_components.powercalc.sensors.group.custom] sensor.all_lights_energy: New value: 1222.6261
2024-12-29 15:56:21.976 DEBUG (MainThread) [custom_components.powercalc.strategy.lut] Color mode not natively supported, falling back to HS
2024-12-29 15:56:21.977 ERROR (MainThread) [custom_components.powercalc.strategy.lut] light.great_room_1: Lookup table not found for color mode (model: LCA007, color_mode: hs)
2024-12-29 15:56:21.977 DEBUG (MainThread) [custom_components.powercalc.sensors.power] light.great_room_1: State changed to "on". Power:None
2024-12-29 15:56:21.978 DEBUG (MainThread) [custom_components.powercalc.sensors.group.custom] Group sensor sensor.all_lights_power. State change for sensor.great_room_1_power: <state sensor.great_room_1_power=unavailable; state_class=measurement, unit_of_measurement=W, device_class=power, friendly_name=Great room 1 power @ 2024-12-29T15:56:21.977937-08:00>
2024-12-29 15:56:21.979 DEBUG (MainThread) [custom_components.powercalc.sensors.group.custom] Group sensor sensor.all_lights_energy. State change for sensor.great_room_1_energy: <state sensor.great_room_1_energy=unavailable; state_class=total_increasing, unit_of_measurement=kWh, device_class=energy, icon=mdi:lightning-bolt, friendly_name=Great room 1 energy @ 2024-12-29T15:56:21.978220-08:00>
2024-12-29 15:56:21.979 DEBUG (MainThread) [custom_components.powercalc.sensors.group.custom] skipping state for sensor.great_room_1_energy, sensor unavailable or unknown

### Diagnostics dump or YAML config

_No response_

@ejpenney Thanks for reporting this issue.
I’ve identified the cause: yesterday, I refactored the property linked_lut in model.json to linked_profile, as it better reflects its purpose of linking to another profile (not limited to lights). I deprecated linked_lut in the code and implemented a fallback.
However, I overlooked the fact that the library is updated independently of the corresponding code changes. Additionally, I need to wait a few months to fully transition the library JSONs to ensure users have updated to newer Powercalc versions.
To resolve the issue promptly, I’ll revert to using linked_lut in the profile library for now.

Should be fixed after restart btw.

Thanks! I rebooted and that light is working now!


Actions/Conditions Ignored if tuple is changed in an Action

Current behavior (how does the issue manifest):
Consider we have conditions c1,c2,c3 which are always true and corresponding actions a1,a2,a3. In a1 if we try to modify tuple value then a2 & a3 are not getting executed.
Expected behavior:
All actions a1,a2,a3 should get executed as c1,c2,c3 are always true.
Minimal steps to reproduce the problem (not required if feature enhancement):
Attached rule descriptor and main.go.
Run main.go file and see the output. Repeat the same by commenting line 72,73 you can see the difference.
Please tell us about your environment (Operating system, docker version, browser & web ui version, etc):
running with latest code taken from github.
Flogo Rules version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X
Additional information you deem important (e.g. issue happens only occasionally):
issue.zip

Can you send the attachments? Even better, can you include a test case?

hi @balamg. files attached, Run main.go file and see the output. Repeat the same by commenting line 72,73 you can see the difference.

Bala,
Abhay has built a go client for tgdb. Please work with him to built a Store
implementation for Rules
Sent from my iPhone
On Jun 7, 2019, at 3:00 AM, balamg<EMAIL_ADDRESS>wrote:
Closed #54 https://github.com/project-flogo/rules/issues/54.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/project-flogo/rules/issues/54?email_source=notifications&email_token=AESTIKDB4WP6IXO2CLK55SLPZIWTTA5CNFSM4HQDWI5KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR3OG4XY#event-2396810847,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AESTIKF75RHMKNDTWJEMVQTPZIWTTANCNFSM4HQDWI5A
.


Fixed typos in docs

Hi @andymccurdy
In redis-py, I found few part of code have typos in documentation, I understand it don't have any functional impact on redis-py, I would like to update it. I am raising PR for that.
Thanks

awesome, thanks!


"No console output" mode?

I could not figure out the following: I'd like to setup VSCode to be run from console (i.e. powershell)
When I do so, VSCode doesn't block the execution, but it start output log into the console, so it became unusable. How can I tell it not to do the logs? Also, I would suggest make it the default behavior and add the opposite flag: --verbose

VSCode Version:

Version 1.1.1
Commit def9e32467ad6e4f48787d38caf190acbfee5880
Date 2016-05-13T13:29:20.776Z
Shell 0.37.6
Renderer 49.0.2623.75
Node 5.10.0

OS Version: Windows 10

Steps to Reproduce

Open powershell.exe
Run Set-Alias code "C:\Program Files (x86)\Microsoft VS Code\Code.exe" so you can use it as a command.
Open current directory with code .
Control is returned to you

expected
no output on the console from vscode
actual

This should work when running ./bin/code or ./bin/code.cmd, no output should happen and control should return to the terminal. You can use a --wait flag if you need to wait for it to terminate. Let me know if this doesn't solve the issue.

I see, thank you for the pointer!
I still think that running batch file shim to discard output is pretty hacky way to achive the desired behavior. I.e. flash of a black cmd screen doesn't look particularly right.
BTW, where command line flags for code can be found?

@vors it's done that way to avoid launching Electron when not necessary and to suppress its output once launched, plus the different platforms launch in slightly different ways (plus .sh and .cmd are required just for Windows).
code --help will give you the command line flags, provided the bin/ dir is in your PATH. Also see https://code.visualstudio.com/Docs/editor/codebasics#_additional-command-line-arguments

great, thank you!


Expand on function parameters documentation, add -preview=in

Underline the difference between argument and parameter.
Split the first sentence between type constructors and storage classes.
Finally, add documentation on what in will means with -preview=in.
Waiting on dlang/dmd#11000

@ibuclaw @kinke : Does the doc work for you, too ?

Wrt. params and args, I usually explain that args are used at the call sites, and params by the callee.
Wrt. in and new -preview=in, it's IMO best to think of it as being passed by ref, similar to C++ const T&, and potentially being optimized to pass-by-value. That's important because of aliasing and the ref-param potentially being mutated via another param, global state or another thread.

Fixed. Thanks for the tip about $(COMMA) @ibuclaw !

Addressed @AndrejMitrovic 's review, 3 outstanding comments.

Ping

Self merging because it's been a while and the beta is out. Feel free to raise a PR and tag me if something is wrong.


ASPA Fixes

aspa error handling (so-far fixed errors are quickly merged to master)
small code quality improvements
remaining aspa design discussions

in aspa.c:65:
static struct aspa_store_node **aspa_store_get_node(struct aspa_store_node **node, const struct rtr_socket *rtr_socket)

Do I correctly assume that there would be at most one struct aspa_store_node for a certain struct rtr_socket?

in aspa.c ll 492–510:
	if (notify_src)
		// Notify src clients their records are being removed
		for (size_t i = 0; i < new_array->size; i++)
			aspa_table_notify_clients(src, aspa_array_get_record(new_array, i), rtr_socket, false);

	if (old_array) {
		if (notify_dst)
			// Notify dst clients of their existing records are being removed
			for (size_t i = 0; i < old_array->size; i++)
				aspa_table_notify_clients(dst, aspa_array_get_record(old_array, i), rtr_socket, false);

		// Free the old array and their provider sets
		aspa_array_free(old_array, true);
	}

	if (notify_dst)
		// Notify dst clients the records from src are added
		for (size_t i = 0; i < new_array->size; i++)
			aspa_table_notify_clients(src, aspa_array_get_record(new_array, i), rtr_socket, true);

shouldn't notification first occur for old_array, then new_array?

do we want to call an as_path of length 0 invalid?

in aspa.c:102
static enum aspa_status append_to_set_array(uint32_t ***sets, size_t *size, size_t *capacity, uint32_t *new_set)

i find the term set here somewhat confusing, as sets is a pointer to an array of arrays, not to sets in the python sense

You‘re right. Can you come up with something else?

in aspa.c:65:
static struct aspa_store_node **aspa_store_get_node(struct aspa_store_node **node, const struct rtr_socket *rtr_socket)

Do I correctly assume that there would be at most one struct aspa_store_node for a certain struct rtr_socket?

Correct

I don't see the point of using an abstraction layer for abstraction's sake. The aspa_array_get_record function does unnecessary bounds checks which I want to skip to improve performance
-------- Original Message --------
On 9 Jan 2024, 09:42, carl wrote:

@carl-tud commented on this pull request.

In rtrlib/aspa/aspa.c:

#endif
while (existing_i < array->size &&

	aspa_array_get_record(array, existing_i)->customer_asn < current->record.customer_asn) {

	array->data[existing_i]->customer_asn < current->record.customer_asn) {

We should really use ˋaspa_get_recordˋ and ˋaspa_set_recordˋ as an abstraction layer over the data field.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

do we want to call an as_path of length 0 valid?

Wouldn’t that mean that the path lacks an origin AS? I guess then it can’t be valid..

when not in-place, we may need to overwrite the last-added record (which is in a different data structure than e.g. existing_record) when for a certain customer_asn, multiple announcements and withdrawals take place in one cache update.

I don't think that's the case. The array of operations gets ordered stably before any kind of update mechanism takes place -- regardless of whether that may be an in-place modification algorithm or a some sort of "build new and swap in" technique. Please correct me if I'm not seeing something here, the update function sort of peeks the next op and checks,

if the current op we're dealing with is an ASPA_ADD op (on a side note, I'm open to renaming these to ASPA_ANNOUNCE and ASPA_WITHDRAW respectively),

and the peeked, that is, the next op, is an ASPA_ADD op too, then we check for a duplicate announcement and fail if so
and and the next op is an ASPA_REMOVE op, we check if its CAS matches the one we're currently dealing with -- if true, we disregard both the add op and the remove op because they're annihilating each other.

...
Again, this logic should hold for both update approaches. I'd be happy if you could somehow clarify what kind of scenario not covered above needs access the previous op..

Thanks for your feedback. I agree that the code is not very readable. This is in part due to the complexity of in-place and not-in-place implementation using macros.
The tests (in #10) show that my implementation is functionally superior to the previous state: the not-in-place code didn't compile, many test cases would fail or cause segfaults.

Let's get both to a state where they compile and work before declaring one of them as superior approach.

@carl-tud Can we agree on either in-place or not-in-place before cleaning up the implementations? I would favor the latter because it required either equivalent amount of or way less time in performance tests and blocks less, generally.

No, I think we should rather get both approaches working, then do a proper performance test. Could you please explain these "scenarios of failure" which led you to making these changes?

when not in-place, we may need to overwrite the last-added record (which is in a different data structure than e.g. existing_record) when for a certain customer_asn, multiple announcements and withdrawals take place in one cache update.

I don't think that's the case. [...] I'd be happy if you could somehow clarify what kind of scenario not covered above needs access the previous op..

I noticed the mistake in my thinking, you're right! I'll push a commit removing this unnecessary code quickly.

closed because further development happens in branch update-variants


[labs/analyzer] Add ability to customize the output location of a given source file

The analyzer currently implements a getJSPathFromSourcePath() function using ts.getOutputFileNames().
However, just because we can determine that src/foo.ts gets output by tsc to build/foo.js doesn't mean that's where the file is ultimately importable from (which is what jsPath intends to capture), since additional transforms outside of ts can (and often do) further process that into another location that is ultimately published (i.e. we output to ./development/*.js and process that further with rollup to ./*.js).
This is something we're going to hit pretty quickly when we start testing against real-world packages, and will likely need to solve by allowing the caller to the analyzer to effectively configure the getJSPathFromSourcePath() function.

I think there are two approaches the can help associate published files with compiler output:

Reverse the export mapping. Once we know all the output paths for all the source files, we can run those through the export map and see what file path(s) they match against, and then reverse the wildcard replacement to generate the export path. Because exports only support a single * wildcard, I believe this is possible.
There's a change of ambiguity with multiple matches, but I think that could be solved by running each export path (if there are multiple) back through the export patterns can choosing the first match (as Node does). Hopefully then there would only be one left.

Use source maps. If the project has been built, then we can try to import every file we can that mapped from exports. This should be possible similar to above by using the export's file path as a glob against the file system. Then we can see if those files have source maps and use the files mapped into the output to look up source files in the TS program.
This might be good enough to map input to output even through other build steps like minification and bundling, with the downside of it requiring the project to be built.

A third escape-hatch solution is to have a config file and let people specify the reverse export mapping themselves. So it'd be a mapping of source file globs to published file globs. To support replacement I think we'd need to restrict globs to a single wildcard like Node exports. Otherwise authors would use a complex glob but map to a fixed output.
This would essentially be a little duplicative of the project's build / bundler config, but hopefully not too bad.


Docker image for MacOSX

Adding an image for building MacOSX binaries.
This steps on a preexisting base image that is somewhat too huge (and appears to support GUI), but is subject to future optimisations.
Also, the final pyinstaller binary is not tested due to lack of access to a native OSX environment. Any actual confirmation would be greatly appreciated.

Thanks for your conversation.


Add some logging

Would be super useful for debugging application or pipelines built on the top of the lib

Addressed by #537


Update Minimal Mistakes' screenshot and add tags

@mmistakes  Thanks for all your great themes. And your Jekyll 2016 article. Keep it up. Cheers.

Wow quickest merge ever! Thanks @geraldb :smile:


Update minimum version of genno

As noted by @awais307, we should bump the minimum required version of genno to the one that introduces genno.operator.
How to review

Read the diff and note that the CI checks all pass.

PR checklist

[x] Continuous integration checks all ✅
~[ ] Add or expand tests; coverage checks both ✅~ Just bumping dependency
~[ ] Add, expand, or update documentation.~ Just bumping dependency
~[ ] Update release notes.~ Just bumping dependency

This should also go in the release notes. For examples, see:
https://github.com/iiasa/ixmp/blob/49ec67dc41dd91bee52879dbfbd83f24064d5f76/RELEASE_NOTES.rst?plain=1#L75
https://github.com/iiasa/ixmp/blob/49ec67dc41dd91bee52879dbfbd83f24064d5f76/RELEASE_NOTES.rst?plain=1#L91-L94

Merging this since the coverage is not affected, codecov just didn't register the reports correctly.


Exam mode: Update the scheduling for the exam live statistics

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I implemented the changes with a good performance and prevented too many database calls.
[x] I documented the Java code using JavaDoc style.

Motivation and Context

We noticed that the current usage of the scheduled tasks causes issues on production. This implementation is updated now.
Description

We reused the MainInstanceMessageSendService and the DistributedInstanceMessageSendService in order to schedule the exam live statistics saves after restart. This allows us to handle this task only on the main server. In addition, this should solve the production issue.
Steps for Testing

Prerequisites:

1 Instructor
One/Multiple Students
Exam

Log in to Artemis
Create an Exam
Register multiple students
Navigate to the Exam Live Statistics dashboard
Enable the Exam Live Statistics
Participate with the students in the exam
Verify that actions are collected
Stop the Exam Live Statistics
Reload the Exam Live Statistics Dashboard
No actions should be visible (stopping the Exam Live Statistics should remove all actions from the cache)
Enable the Exam Live Statistics
Actions should be received again

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Tested on Staging together with @sleiss and works good.


Support archiving hard links

Tar (at least GNU tar) seems to notice when files being archived are hard links, and stores them as such, extracting as hard links.
I'm not quite sure how this should be implemented (and besides, I don't currently/yet need it) but it should have an option like the symlink option in #117.

Makes sense to me!

I looked into how busybox tar and gnu tar did it.  The way is to record in a HashSet the (inode, device number) of every file they have written, if it has hard link count > 1.  Then when they see this (inode, device number) a second time, jsut the header is written, with typeflag set to 1 and an appropiate linkname.
The appropiate place to set the type flag should be append_fs in Builder, because it is where the header is prepared.  However in order for append_fs to know it is a hard link, Builder has to tell it, that means adding a parameter to append_fs.  That would make append_fs having 7 parameters and it may be too many.  Every caller such as append_path has to pass the parameter around too.  So, I am considering to put append_fs inside impl Builder
fn append_fs(&mut self,
             path: &Path,
             meta: &fs::Metadata,
             read: &mut Read,
             link_name: Option<&Path>) -> io::Result<()> {

So that dst, mode and the new HashSet of (inode, device number) can be retreived from self.
That would be a big change as some other module-level function like append_path will be moved to self too.  I would like to ask if this is acceptable, or there is a better approach?

@BrianOn99 sounds great to me!

@alexcrichton Then I will take this issue, while make sure not changing external API.

See #192, extending append_fs would be too high level when not building an archive from the filesystem but passing in partial headers + paths + readables directly.


[Request External] PAG 343 - ShowWarning

The 'Check Credit Limit' page (343) supports credit limit checks based on various datasets such as General Journal Lines, Sales Lines, Service Lines, ... All of these reuse the (local) function 'ShowWarning'.
We've extended this page with our own 'Transport Service' tables to integrate extra credit checks and would like to apply the same pattern like for 'Service Lines' (or other datasets) and would thus need the 'ShowWarning' function to be set to 'External'

Duplicated via #3622


⚠ Bofrost.nl has degraded performance

In 17271f7, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 2761 ms

Resolved: Bofrost.nl performance has improved in 725cbea after 6 minutes.


How to show user information after login?

Hi I tried to create a SHOW view for current login users, but when I tried to view it, it just went blank, how can I display the user fields I added in the user's table after they logged in?

I think we do need to be able to do this, I will think about how best to specify it. Probably using presets in the fixed state of a view embedded on a page (which you can't do right now)

implemented in #853, and explained how to use this at the bottom of the cookbook on the wiki: https://wiki.saltcorn.com/view/ShowPage?title=Cookbook

Thanks, got it.


"validate.kyverno.svc-ignore" denied the request: resource Job/deploykf-auth/deploykf-auth-generate-secrets

Checks

[X] I have searched the existing issues.
[X] This issue is NOT security related. (Please disclose responsibly)
[X] This issue is NOT specific to the CLI. (Please open a CLI issue)

deployKF Version
0.1.5
Kubernetes Distribution
k8s
Kubernetes Version
Client Version: v1.30.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.25.14+k0s

Description
I try to sync dkf-core--deploykf-auth but got this error:

admission webhook "validate.kyverno.svc-ignore" denied the request: resource Job/deploykf-auth/deploykf-auth-generate-secrets was blocked due to the following policies require-requests-limits: autogen-validate-resources: 'validation error: CPU and memory resource requests and limits are required. rule autogen-validate-resources failed at path /spec/template/spec/containers/1/resources/limits/' restrict-image-registries: autogen-validate-allow-registries: 'validation failure: failed to check deny preconditions: failed to substitute variables in condition value: failed to resolve allowedregistries.data.registries | parse_yaml(@) at path : JMESPath query failed: Invalid type for: , expected: []jmespath.JpType{"string"}'

FYI: I already have an existing kyverno in my cluster but the doc for using existing kyverno is not available so I also deploy kyverno from deployKF itself.
Relevant Logs
No response
deployKF Values (Optional)
No response

@namirinz please know that you can NOT run two versions of Kyverno on the same cluster! It will almost certainly break your cluster because both will be trying to fight each other for control of almost everything.
Right now, you are correct that we don't document how use an existing Kyverno install, this is because deployKF 0.1.5 depends on using exactly version 1.10.0 of Kyverno, and users are unlikely to have exactly that version.
We hope to update the embedded version of Kyverno in the next release, and provide instructions for using an existing Kyverno, but every version past 1.10.0 has had some critical flaw preventing us from using it.
We will make 1.12.X work, but it needs testing, there has been a significant change with the ClusterPolicy that replicates secrets. If the policy is created before the source Secret it wont replicate until the undocumented BACKGROUND_SCAN_INTERVAL (https://github.com/kyverno/kyverno/issues/9560) has elapsed. But I think I have a workaround (where you set the match to the Secret itself rather than the target Namespace).

So the only way to use deployKF for now is to remove the existing kyverno in the cluster and use embedded kyverno from deployKF?

I am going to close this because it's not technically an issue with deployKF.
But we are actively working on getting a newer version of Kyverno in deployKF 0.1.6 (see the changelog for more info about it).


To get around this, I used the api endpoint with requests instead. This might point towards a solution.

can you show the code you use instead?

Sure.
`def upload_a_file_to_dataset(filepath, dataset_id, clowder_url, user_api):
url = '%s/api/uploadToDataset/%s?key=%s' % (clowder_url, dataset_id, user_api)
file_exists = os.path.exists(filepath)
before = datetime.now()
if os.path.exists(filepath):
filename = os.path.basename(filepath)
m = MultipartEncoder(
fields={'file': (filename, open(filepath, 'rb'))}
)
try:
result = requests.post(url, data=m, headers={'Content-Type': m.content_type},
verify=False)
            uploadedfileid = result.json()['id']
            return uploadedfileid
        except Exception as e:
            print('failed to upload file, error')
            print(e)
            print(str(datetime.now()))
else:
    print("unable to upload file %s (not found)", filepath)
return None`

Sure.
``
def upload_a_file_to_dataset(filepath, dataset_id, clowder_url, user_api):
url = '%s/api/uploadToDataset/%s?key=%s' % (clowder_url, dataset_id, user_api)
file_exists = os.path.exists(filepath)
before = datetime.now()
if os.path.exists(filepath):
filename = os.path.basename(filepath)
m = MultipartEncoder(
fields={'file': (filename, open(filepath, 'rb'))}
)
try:
result = requests.post(url, data=m, headers={'Content-Type': m.content_type},
verify=False)
            uploadedfileid = result.json()['id']
            return uploadedfileid
        except Exception as e:
            print('failed to upload file, error')
            print(e)
            print(str(datetime.now()))
else:
    print("unable to upload file %s (not found)", filepath)
return None

``

i can also reproduce this issue when uploading large files.

I'll take a look at this soon. Since I have code that works I believe I should be able to fix it.

I notice that the difference is that I'm using verify=False and this is verify=True in pyclowder. This is set in connector (where it is set to True) and the default is True.
Should we switch this to False, or just do False if the files are above some size?

Does this happen in an extractor, or using client?

verify == FALSE means it does not test SSL certs, this is bad. This should only be used as a last resort in case you use self signed certs.

OK. Will look into a better fix.

@bingzhang how large of a file did you test and have it fail? Could you share it?

@bingzhang how large of a file did you test and have it fail? Could you share it?

something like 1 GB.

OK.
If I use my code above and put verify=True, a file that's 1.8 GB will upload.
If i use
   file_id = client.post_file("/uploadToDataset/%s" % dataset_id, path_to_large_file)
then i get a timeout.

from https://requests.readthedocs.io/en/latest/user/quickstart/#timeouts:
timeout is not a time limit on the entire response download; rather, an exception is raised if the server has not issued a response for timeout seconds (more precisely, if no bytes have been received on the underlying socket for timeout seconds). If no timeout is specified explicitly, requests do not time out.

So that means that we have not received a response from clowder for 5 seconds. Does this happen at the end of the upload or in the middle?

I'm saying the middle based on the time. Uploading a 1.8 GB file (which I tried) took about 30 seconds.


Minor touches

Change from xchange-xtension to HoverXchange.
Change version in manifest.js to correct version.
Make new icon.

hello


samples: Bluetooth: Add missing svc data for broadcast audio sink

Add missing service data for BASS for the broadcast audio sink sample.
fixes https://github.com/zephyrproject-rtos/zephyr/issues/68919

Updated a Kconfig value as it caused BSIM to fail with the new advertising length


ngx_debug_pool: updated to nginx-1.15.9/tengine-2.3.x

Test Case:

Tested-by: Xiaochen Wang
Date: Sat Mar  2 22:28:41 CST 2019
pwd: /home/xiaochen.wxc/work/github/tengine-xiaochen
cases: modules/ngx_debug_pool/t/
git log:

commit 0aac4babdc2e95918b9c526842648df80aaf4c73 (HEAD -> master, origin/master, origin/HEAD)
Author: Xiaochen Wang<EMAIL_ADDRESS>Date:   Sat Mar 2 22:27:36 2019 +0800

    ngx_debug_pool: updated to nginx-1.15.9/tengine-2.3.x

case result:

$ TEST_NGINX_UNSAFE=yes TEST_NGINX_BINARY=/home/xiaochen.wxc/work/github/tengine-xiaochen/objs/nginx prove -I /home/xiaochen.wxc/work/github/tengine-xiaochen/tests/nginx-tests/nginx-tests/lib modules/ngx_debug_pool/t/
modules/ngx_debug_pool/t/test.t .. nginx: [alert] detected a LuaJIT version which is not OpenResty's; many optimizations will be disabled and performance will be compromised (see https://github.com/openresty/luajit2 for OpenResty's LuaJIT or, even better, consider using the OpenResty releases from https://openresty.org/en/download.html)
modules/ngx_debug_pool/t/test.t .. ok
All tests successful.
Files=1, Tests=3,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.13 cusr  0.02 csys =  0.19 CPU)
Result: PASS

Report-generated-by: http://github.com/chobits/tengine-script/runtest.sh

ACK


Revert "Improved robustness of filtering, including negation"

Reverts google/link-diver#26

I thought I would be able to redo the merge since I had forgotten to add changes, but that appears to not be the case, so I am going to revert and revert and merge the missed changes in a new PR


python310Packages.scancode-toolkit: relax intbitset constraint

Description of changes
Fix build (https://hydra.nixos.org/build/175437116)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 171635 run on x86_64-linux 1

2 packages built:

python310Packages.scancode-toolkit
python39Packages.scancode-toolkit


Error when default column names are different

I am using bulk insert in Rails Table.
My id column is named as PRODUCT_ID and created_at and updated_at are respectively RECORD_CREATE_DATE and RECORD_UPDATE_DATE.
The bulk insert takes these values as NULL and I get an error because these fields have not null constraint.
How do I solve these?

Hi @nishantkumar1292, can you post your schema.rb (at least the relevant table), the adapter your using and eventually a test to reproduce your issue?

There hasn't been any activity on this for a few months, so I'm going to close this issue. If it is still a problem, please feel free to reopen it.


Compiler panics when using #[spirv(object_to_world)]

Hi, I encountered compiler panic and I report here as output says.
Expected Behaviour

The compiler doesn't panic.
I also want to know how do we use #[spirv(object_to_world)] correctly.
Example & Steps To Reproduce

Create shader

lib.rs
#![cfg_attr(
    target_arch = "spirv",
    no_std,
    feature(register_attr),
    register_attr(spirv)
)]

use spirv_std::glam::Vec4;
#[cfg(not(target_arch = "spirv"))]
use spirv_std::macros::spirv;

#[spirv(closest_hit)]
pub fn test_closest_hit(#[spirv(object_to_world)] _object_to_world: [Vec4; 3]) {}

build it

build.rs
use std::error::Error;

use spirv_builder::{Capability, MetadataPrintout, SpirvBuilder};

fn main() -> Result<(), Box<dyn Error>> {
    SpirvBuilder::new("../shader", "spirv-unknown-vulkan1.2")
        .capability(Capability::RayTracingKHR)
        .extension("SPV_KHR_ray_tracing")
        .print_metadata(MetadataPrintout::Full)
        .build()?;

    Ok(())
}

get panic

> cargo build
    Blocking waiting for file lock on build directory
   Compiling builder v0.1.0 (C:\Users\hato2\Desktop\rust-gpu-issue\builder)
error: failed to run custom build command for `builder v0.1.0 (C:\Users\hato2\Desktop\rust-gpu-issue\builder)`

Caused by:
  process didn't exit successfully: `C:\Users\hato2\Desktop\rust-gpu-issue\target\debug\build\builder-8dcc5829546998ea\build-script-build` (exit code: 1)
  --- stderr
     Compiling core v0.0.0 (C:\Users\hato2\.rustup\toolchains\nightly-2021-08-10-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core)
     Compiling rustc-std-workspace-core v1.99.0 (C:\Users\hato2\.rustup\toolchains\nightly-2021-08-10-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\rustc-std-workspace-core)
     Compiling compiler_builtins v0.1.49
     Compiling libm v0.2.1
     Compiling spirv-types v0.4.0-alpha.12
     Compiling bitflags v1.3.2
     Compiling num-traits v0.2.14
     Compiling glam v0.17.3
     Compiling spirv-std v0.4.0-alpha.12
     Compiling shader v0.1.0 (C:\Users\hato2\Desktop\rust-gpu-issue\shader)
  error: internal compiler error: unexpected panic

  note: the compiler unexpectedly panicked. this is a bug.

  note: we would appreciate a bug report: https://github.com/EmbarkStudios/rust-gpu/issues/new

  note: rustc 1.56.0-nightly (ae90dcf02 2021-08-09) running on x86_64-pc-windows-msvc

  note: compiler flags: -Z unstable-options -Z codegen-backend=C:\Users\hato2\Desktop\rust-gpu-issue\target\debug\rustc_codegen_spirv.dll -Z symbol-mangling-version=legacy -C opt-level=3 -C embed-bitcode=no -C target-feature=+RayTracingKHR,+ext:SPV_KHR_ray_tracing --crate-type lib --crate-type dylib

  note: some of the compiler flags provided by cargo are hidden

  query stack during panic:
  end of query stack
  note: `rust-gpu` version 0.4.0-alpha.12

  error: could not compile `shader`
  Error: BuildFailed

I created a repository for this issue https://github.com/hatoo/rust-gpu-issue.
You can reproduce by clone and build it.
System Info

Rust: 1.56.0-nightly (ae90dcf02 2021-08-09)
OS: Windows 11 Pro
GPU: RTX 2080ti
SPIR-V: v2021.2-dev v2021.1-42-g5dd2f769

Backtrace

Backtrace

<backtrace>

Thanks for the issue! Looks like the problem is due to some problematic interaction between internal compiler details due to unused parameters. In the meantime, this issue can be worked around via using the parameter in some way (I've not done raytracing stuff before, not sure what form the shader takes or if there's output variables, but something like this):
#[spirv(closest_hit)]
pub fn test_closest_hit(#[spirv(object_to_world)] object_to_world: [Vec4; 3], something: &mut f32) {
    *something = object_to_world[0].x;
}

Thanks! I've succeeded to work around compiler panic but I still fail to use #[spirv(object_to_world)].
I tried all types that I think it's fit to the 4x3 matrix e.g. [Vec3; 4], [Vec4; 3], [[f32; 3]; 4], Affine3A .. but I always get errors like
error: [VUID-ObjectToWorldKHR-ObjectToWorldKHR-04307] According to the Vulkan spec BuiltIn ObjectToWorldNV variable needs to be a matrix with 4 columns of 3-component vectors of 32-bit floats. ID <2> (OpVariable) has columns 0 and rows 0 not equal to expected 4x3.
    %object_to_world = OpVariable %_ptr_Input__arr__arr_float_uint_3_uint_4 Input

I checked valid SPIR-V emitted by glslc and I found that we need to use OpTypeMatrix to express matrix type.
test.rchit
#version 460

#extension GL_EXT_ray_tracing : enable

void main() {
	float x = gl_ObjectToWorldEXT[0][0];
}

glslc test.rchit --target-env=vulkan1.2

and got
...
%float = OpTypeFloat 32
%_ptr_Function_float = OpTypePointer Function %float
    %v3float = OpTypeVector %float 3
%mat4v3float = OpTypeMatrix %v3float 4
%_ptr_Input_mat4v3float = OpTypePointer Input %mat4v3float
%gl_ObjectToWorldEXT = OpVariable %_ptr_Input_mat4v3float Input
...

But I couldn't find any way to use OpTypeMatrix by rust-gpu.
Is there a way to use OpTypeMatrix or any workaround?
Should I create another issue about this?

Ah, shoot, yeah, we currently don't expose OpTypeMatrix. That feature is currently tracked by #82 :(


blur feed

the suggestion in the feed is blur and thumbnails and titles are not visible unable to understand the content

@vaishnavis31 Please read readme.md and then try to solve the issues.

the extension is all about hiding the irrelevant videos in your feed. you will have to mention comma seperarted values in inout which will show only those videos to you


Adding a Mainteiner is shown as a Owner

Go to your project's Admin page
Go to Mainteiners
Add a new mainteiner
Go to your project's detail page

The mainteiner is shown under a Owners title.

I think we should use the same word for this, either Mainteiners or Owners but not both.

Hi @humitos, I would like to implement this. Since I'm new here, can you please tell me the next step towards the process.

This was a question I had the other day, if rtd differences between the main owner (who created the project) and others owners.

Hey @stsewd, from what I've inspected in the Project model, RTD doesn't differentiate between owner and maintainers. A user(maintainer/owner) can remove another user.
If A is an owner and B is a maintainer, B can remove A, because of users attribute (ManyToMany relation with User model) and logic implemented.
@humitos, I believe that's why you've considered this a UI enhancement and not a model critical design change. Correct me if I missed something!
But I wanted to know if it is required to differentiate owner and maintainer?

Yes. I'm talking about the UI (not the behind the scenes and django modeling).

Should it be called owner or maintainer? In my opinion, maintainer is a better choice.

@humitos, since this issue is considered under UI improvement, I've created a PR with taking maintainer as the word because it is used in other places as well. Can you please review it?

This was resolved in https://github.com/rtfd/readthedocs.org/pull/3703


create sum.c

sum.c
basic C program file add two integers and return it's sum

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


DO NOT MERGE: Unit test generation

This PR is for review together with https://github.com/googleapis/toolkit/pull/879
It depends on https://github.com/googleapis/gax-php/pull/42, so will not be merged in its current state, but instead rebased after that PR is merged
Add MockStubTrait and MockUnaryCall

Current coverage is 88.75% (diff: 39.28%)

Merging #2 into lro will decrease coverage by 1.03%

@@                lro         #2   diff @@
==========================================
  Files            18         20     +2
  Lines          1341       1369    +28
  Methods         147        154     +7
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1204       1215    +11
- Misses          137        154    +17
  Partials          0          0

Powered by Codecov. Last update 497320b...49045ed


Improve radio select box styling & usability

@diegodayone I refactored and fixed some styles here, + some mobile usability improvements — hope you don't mind
Ref https://github.com/RadiCards/radi.cards/commit/f5c71c40279d044a7a6d80c2e248e20368ef9f50


Display optimization on iPhone device page

Fix the problem of zooming in the page after entering content on iPhone device #213

Just tested. Amazing fix!


Document init param in dora grid

Closes #49.
Modify README.md to document --init in dora grid.

thanks a lot @alexisthual !


New release notes and changelog updates for v4.0.0

Description
We would like to write release notes and update the changelog of version 4.0.0.
Dependencies
This issue is blocked by the following ones:

[x] #283

Checklist

[ ] Add release notes.
[ ] Update changelog.
[ ] Apply release notes to the 4.0.0 release.

There is no need to update previous release notes.


Simplify map tasks and also respect map_task kwargs

Signed-off-by: Katrina Rogan<EMAIL_ADDRESS>TL;DR
Instantiate a separate run_task (inner task) for map tasks that respects the map task kwargs (e.g. environment, resources, etc) but uses the input run_task resolver.
Tested on flytesandbox.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[x] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
Tracking Issue
https://github.com/flyteorg/flyte/issues/1170
Follow-up issue
NA

closing in favor of using overrides


"BotKube notifier" commands should be executable only from a slack channel

Currently, we can execute BotKube notifier commands to start/stop notification from outside the channel (like DM) also. We should restrict these command execution to happen only from the configured channel.

Fixed with https://github.com/infracloudio/botkube/pull/39


How to create Flex-free model in TFLite

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
TensorFlow installed from (source or binary): Installed via PIP
TensorFlow version (or github SHA if from source): Tensorflow 2.3.1

Command used to run the converter or code if you’re using the Python API
import tensorflow as tf
converter = tf.lite.TFLiteConverter.from_saved_model(saved_model_dir)
converter.target_spec.supported_ops = [
  tf.lite.OpsSet.TFLITE_BUILTINS, # enable TensorFlow Lite ops.
  tf.lite.OpsSet.SELECT_TF_OPS # enable TensorFlow ops.
]
tflite_model = converter.convert()
open("converted_model.tflite", "wb").write(tflite_model)

NOTE: Model is successfully converted.
Failure details
If the conversion is successful, but the generated model is wrong,
state what is wrong:

TFlite model is working fine at CPU Linux 16.04 and RaspberryPi. But it gives BUS ERROR at edge device. Details.

The original model is in PyTorch. I have used PyTorch-ONNX-Tensorflow-TFLite approach to convert the model in TFLite.
I am sharing graphs of ONNX and TFLite model. Link
Geeks says

Using Flex op requires to build TF op kernels which is difficult to support various targets.
If the required Flex op is only FlexMul, I think you might be able to create Flex-free model with some refactoring.

How can do this "create Flex-free "?

Could you share your FlexMul op details? Which type being calculated? Which input shape being calculated?
TFLite Mul can support F32, I32, QI8, QUI8, and QI16 inputs and support up to 4 dims if broadcasting is needed or the same input shapes.
If you can modify your model to adjust the above Mul op constraints, the FlexMul op requirement will be gone.

Could you share your FlexMul op details? Which type being calculated? Which input shape being calculated?
TFLite Mul can support F32, I32, QI8, QUI8, and QI16 inputs and support up to 4 dims if broadcasting is needed or the same input shapes regardless of dimensions.
If you can modify your model to meet the above Mul op constraints, the FlexMul op requirement will be gone.

I have already shared graphs.Link
Input to model is = [1,500,120]

If you can modify your model to meet the above Mul op constraints, the FlexMul op requirement will be gone.HOW?

Could you share your Flex-enabled tflite model file to us instead of the graph and share some warning logs like the below example you can see those warnings in tf-nightly version when you are converting the model?
I1120 16:16:16.002125 2530115 flatbuffer_export.cc:...] TFLite interpreter needs to link Flex delegate in order to run the model since it contains the following flex op(s):

Flex ops: tf.MaxPool
Details:
        tf.MaxPool {data_format = "NCHW", device = "", explicit_paddings = [], ksize = [1, 1, 2, 2], padding = "VALID", strides = [1, 1, 2, 2]}
        tf.MaxPool {data_format = "NCHW", device = "", explicit_paddings = [], ksize = [1, 1, 3, 3], padding = "VALID", strides = [1, 1, 1, 1]}

Based on the above information, you can find which one is the original operators in the source graph and replace the one with the supported operator case by modifying the source graph.

Could you share your Flex-enabled tflite model file to us instead of the graph image if possible? And it would be helpful to understand why the FlexMul op is introduced if you can share some warning logs like the below example. You can see the following warnings in tf-nightly version when you are converting the model.
I1120 16:16:16.002125 2530115 flatbuffer_export.cc:...] TFLite interpreter needs to link Flex delegate in order to run the model since it contains the following flex op(s):

Flex ops: tf.MaxPool
Details:
        tf.MaxPool {data_format = "NCHW", device = "", explicit_paddings = [], ksize = [1, 1, 2, 2], padding = "VALID", strides = [1, 1, 2, 2]}
        tf.MaxPool {data_format = "NCHW", device = "", explicit_paddings = [], ksize = [1, 1, 3, 3], padding = "VALID", strides = [1, 1, 1, 1]}

Based on the above information, you can find which one is the corresponding operator in the source graph for the FlexMul op in the TensorFlow Lite and you can find a way to replace the source operator with the supported operator case by modifying the source graph.

Sorry,I can not share model. I have used TF 2.3.1 for conversion and while conversion there is no log as you mentioned.
For Flex ops details, There is FlexMul and FlexADDv2 in TFLite graph and MatMUL ops in source graph(ONNX).

@nehasoni3 can you share the screenshot of the tabs that appear when you click Mul op and FlexMul op in the netron app?
And can you share the input tensor type of Mul op and input shape information of Mul op?

@nehasoni3 can you share the screenshot of the tabs that appear when you click Mul op and FlexMul op in the netron app?
And can you share the input tensor type of Mul op and input shape information of Mul op?

If you can click the + button, which is located at each input and each output, there is more information regarding input types and shapes.

If I use this only,
converter.target_spec.supported_ops = [   tf.lite.OpsSet.SELECT_TF_OPS] tflite_model = converter.convert()
This works but every op is of Flex.
But If I use,
converter.target_spec.supported_ops = [   tf.lite.OpsSet.TFLITE_BUILTINS] tflite_model = converter.convert()
I got this log-
`---------------------------------------------------------------------------
Exception                                 Traceback (most recent call last)
/usr/local/lib/python3.6/dist-packages/tensorflow/lite/python/convert.py in toco_convert_protos(model_flags_str, toco_flags_str, input_data_str, debug_info_str, enable_mlir_converter)
212                                                  debug_info_str,
--> 213                                                  enable_mlir_converter)
214       return model_str
4 frames
Exception: :0: error: loc(callsite(callsite("Mul@__inference___call___2921" at "PartitionedCall@__inference_signature_wrapper_2928") at "PartitionedCall")): 'tf.Mul' op is neither a custom op nor a flex op
:0: note: loc("PartitionedCall"): called from
:0: error: loc(callsite(callsite("add_2@__inference___call___2921" at "PartitionedCall@__inference_signature_wrapper_2928") at "PartitionedCall")): 'tf.AddV2' op is neither a custom op nor a flex op`

Yes, this is an expected behavior. The current model input for conversion can not be covered by the TFLite builtin op set. So we need flex ops or custom ops.

If you can fix the input shapes in the model during conversion, those Flex op requirements might be gone.

If you can fix the input shapes in the model during conversion, those Flex op requirements might be gone.

How can I fix the input shapes. Do I need to change its dtype or what?

I am assuming that the model is using float32 type, which is a typical choice among ML model. If it is true, the Flex requirement is due to the input shapes. The input shape can be fixed by (1) modifying the original source graph or (2) using TFLite converter V1 API's input_shapes argument https://www.tensorflow.org/api_docs/python/tf/compat/v1/lite/TFLiteConverter

@abattery Now, FlexMUL is removed but FlexAddV2 op is still there. Will you guide me to remove that FlexAddV2 op?

The same strategy can be applied to FlexAddV2 ops. Fixing the input shape of the FlexAddV2 ops can help replacing them with TFLite Add ops.


Truly Modular - Sinytra Connector Incompatibility

Mod Name
Sinytra Connector
Mod Homepage
https://modrinth.com/mod/connector
Minecraft version
1.20.1
Describe the bug
When using the mods together, modular tools will lack attributes/stats and become ineffective
Steps to reproduce

Download Truly Modular and its modules/dependencies.
Download Sinytra connector (as well as connector extras and forgified fabric API) to the same modpack
Load up the game and modify a tool in the modular workbench

Logs
https://gist.github.com/Popsikul/473586f68c8e502e15efeb9bfe15af70
Additional context
No response

Resolved by MIAPI devs


Installation overview

"Install RiboViz and dependencies" docs/user/install.md would be improved by a brief 1-paragraph overview that it is indeed the complete installation instructions for riboviz for a variety of operating systems. Just saying who/what the document is for at the top of the page.

Updated as of commit c6db89a.


"Replace with evaluated expansion" works incorrectly

a{,1,2,3} gets expanded to a1 a2 a3, but it should get expanded to a a1 a2 a3, at least this is what Bash does

Fixed for the next update


required block fields not being represented properly in the graphql schema

Description
as discussed in https://github.com/payloadcms/payload/discussions/764
{
  slug: "landing",
  fields: [
    {
      name: "cards",
      type: "blocks",
      blocks: [cards],
      required: true,
    },
  ],
}

is outputting
type Landing {
  cards: [Landing_Cards]
}

instead of
type Foo {
  cards: [Landing_Cards!]!
}

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

should I just make the union type always non-nullable? is there a case where [null] will be returned?

Hey @chaoky — good question!  There will never be a case where [null] will be returned, so yes, you can make the union type always non-nullable.
Thank you!

I made every list element non nil, I honestly think that this should be the default in GraphQL, who's is returning [null]?

Merged! Thank you @chaoky!!!


Hyper-V: minor update LIS-Mount-CD to support run remotely and clean iso file

Update LIS-Mount-CD and SETUP-RemoveIsoFromDvd.ps1 files

In LIS-Mount-CD, change downloading the iso file to test server directly. When use "Add-VMDvdDrive -VMName $VMName -Path $isoPath" to mount remote iso file to vm, it will fail by "Unable to mount the ISO file", so use invoke-command.
Add cleanupScript SETUP-RemoveIsoFromDvd.ps1 to Function.xml. If the test case is pass, the vm will be removed, but the iso file still on the server, meanwhile, removeISOFromDvd also can check remove dvd successfully or not.

Thank you so much.
Before fix:
10/22/2019 10:55:48 : [INFO ] MOUNT-CD started running ...
10/22/2019 10:55:49 : [INFO ] Run test case against the target machine ...
10/24/2019 05:26:01 : [INFO ] MOUNT-CD ended running with status: FAIL.

After fix:
   ID TestArea             TestCaseName                                            TestResult
------------------------------------------------------------------------------------------------------------------------

    1 CORE                 MOUNT-CD                                                   PASS

Test using localhost
[LISAv2 Test Results Summary]
Test Run On           : 10/29/2019 14:04:47
VHD Under Test        : ubuntu_18.04.1_gen1_gen2.vhdx
Initial Kernel Version: 4.15.0-38-generic
Final Kernel Version  : 4.15.0-38-generic
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:6

   ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
-------------------------------------------------------------------------------------------------------------------------------------------
    1 CORE                 MOUNT-CD                                                                          PASS                 3.93

@johnsongeorge-w Please review and sign off if you are ok.

@johnsongeorge-w Please review and sign off if you are ok. If all comments are closed, I am ok to merge it also.

LGTM. Review comments not addressed, wait for it to be resolved.

Test results against latest run
[LISAv2 Test Results Summary]
Test Run On           : 11/01/2019 02:15:45
VHD Under Test        : ubuntu_18.04.1_gen1_gen2.vhdx
Initial Kernel Version: 4.15.0-38-generic
Final Kernel Version  : 4.15.0-38-generic
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:5

   ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
-------------------------------------------------------------------------------------------------------------------------------------------
    1 CORE                 MOUNT-CD                                                                          PASS                 2.79


Centralized Configuration

Which configuration could become centralized?

Which configuration could become centralized?

The first round are configurations that must/should be the same between controllers.

OIDC configuration
enrollment durations for routers/identities
API rate limiters

Things that won't/can't are host specific configuration or chick-and-egg configurations (i.e. what ports the API is hosted on and its identity).
This effort is controller centric. The future may include router configuration.


Missing content-encoding : br from the response

The MGW drops the content-encoding : br header from the response, for a passthrough request which having a backend of "content-encoding: br".
Can we have the support for content-encoding : br for passthrough requests?

The current behavior of http module is that the response payload is decoded and then encoded in transport layer to support the accept-encoding specified by the client. Before sending the response to transport the content-encoding header is dropped and then transport set the header again. Since http module currently supports only gzip and deflate formats, even though the backend responded with the content-encoding: br, the content-encoding header will not be set. That is why the header is dropped when getting the response. To resolve the issue, http module should support br format. This is more like a New Feature than a Bug.

In addtion to that, we need to avoid the decoding payload during the client forward() remote method as it should behave as a passthrough.


[demo-store] Add support for Checkout Links to the demo-store template

WHY are these changes introduced?
To support merchants migrating to Hydrogen from the Online Store who use Checkout Links, this PR adds basic support for these Checkout Links to the demo store template, to serve as a working example.
Checkout Links have the URL structure https://[my_store]/cart/[variant_id]:[quantity]?discount=[discount_code]
They might also contain more than one [variant_id]:[quantity] separated by a comma, for checkouts with more than one product variant.
Seperate PR here https://github.com/Shopify/shopify-dev/pull/32522 for adding a link to this example, in the Hydrogen migration docs.
WHAT is this pull request doing?

Adds a route - ($lang).cart.$lines.tsx
Adds checkoutUrl as a field in the cartCreate mutation

With this PR, the demo store should support Checkout Links, for example:
https://hydrogen.shop/cart/41007289663544:1,41007289696312:2?discount=HYDROBOARD
Using this Checkout Link should result in a new cart being created with the merchandise and discount code from the URL, and then you should be redirected straight to the checkout - video example below.

Video example 📹 (click me!)
https://user-images.githubusercontent.com/48892838/229340253-466dd233-a491-461a-965c-d42a25e94bf8.mp4

HOW to test your changes?

Apply the changes to a demo store template
Test different variations of Checkout Links to make sure they work as expected on the demo store and don't break anything 😅

Checklist

[x] I've read the Contributing Guidelines
[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've added a changeset if this PR contains user-facing or noteworthy changes
[ ] I've added tests to cover my changes
[ ] I've added or updated the documentation

Thanks @frehner !
I had completely missed the previous work on this (apologies!) but glad this has been of help anyway. Obviously a little over-eager to contribute 😅
Excited to see the new Remix cart implementation when it's done!


V0.3.0

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2cb504c). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   65.32%
=========================================
  Files             ?        7
  Lines             ?      646
  Branches          ?        0
=========================================
  Hits              ?      422
  Misses            ?      224
  Partials          ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

v0.3.0


Upgrade pages-build-and-deploy actions

Succesful run: https://github.com/PicnicSupermarket/diepvries/actions/runs/9385675398


Docker Image?

The documentation has a page for Docker, but the instructions for building the image aren't present (currently it's "Coming Soon").
Can these be added so that we can use Docker to run CM-Well? The instructions for running are there, but aren't of much use without the image instructions.

Hi,
for the time being you can use the unofficial image:
https://hub.docker.com/r/eorz/cm-well
Please see the instructions there how to pull/run this image.
I will appreciate if you will respond whether it worked or not.
Thanks!

I'm able to get the image working - thanks!


Add OSM amenitys to turn-by-turn directions

Rename references to amenities

By references do you mean all instances of turnamenities?

Yes, turnamenitys to turnamenities. 'amenities' is the proper plural spelling of 'amenity'.

I mean 'amenitys' is a misspelling.

Tests should be added to ensure that the get() and attach() methods work as expected.

@flibbertigibbet Ahh, now I see. Thanks.

Pushed new code.

+1


Source files json in pretty format with line breaks

See also #176. I cannot reopen that, so I am creating a new one with a (hopefully) more clear description.
Source maps are generated in an "ugly" json format, without line breaks or indentation. Very much like a minified CSS file.
This may be good enough for most cases, but there are some situations where a pretty format would be more useful:

If the source map is checked into a git repository. git diff, merge etc works much better if the code is broken into multiple lines.
If a developer is actively looking at the source map code.

Usually the main benefit of a non-formatted file is performance, by slightly reducing the file size.
This is not really relevant here, because the file will only be downloaded if someone opens the browser developer tools.
Current format:
{"version":3,"sources":["overrides.css","overrides/_forms.scss","overrides.scss","variables/_typography.scss", [..]

Pretty:
{
  "version": 3,
  "sources": [
    "overrides.css",
    "overrides/_forms.scss",
    "overrides.scss",
    "variables/_typography.scss",
[..]

This should be optional, so that existing code does not change unexpectedly from downloading a new version of gulp-sourcemaps.

Upvote on this pls... we keep sourcemaps in repos as well and continue to run into merge conflicts.


hello excuse me this is just hurts my eyes

meh It doesn't look like that

maybe do something like...

[ ] Switch to a different prominent color library, because the current one doesn't support webp
|

[ ] Switch to webp for saving images

It's not up to me how markdown looks on github


Add vault command

[x] Add VaultCommand
[x] Update README
[x] Add to README: How to write sub-commands
[x] Add some tests

Well, tests ain't the best in the world, and testing command line input is a bit tricky, so maybe this suffices for now. 😅 I tried it as a path dependency in noa and it all works, tho. 😇

What do you think @minhqdao?


Add new content

Add Sets, logical operators and some build-in methods for list and dict

Hi. Thank you for reply.
I fixed issue.


Using user token to push change and bot token to request change in build workflow

#972  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite


1016 Can't Connect to the Appx Data Server

I am using Node ODBC 2.3.1. Everything was working great until today. For some reason, it is no longer able to make a connection. I haven't run the OS updates. I am getting below error message. I was wondering if you can assist me. Thank you!
[Error: [odbc] Error connecting to the database] {
  odbcErrors: [
    {
      state: '00000',
      code: 0,
      message: "[Dharma][ODBC Dharma Driver 09.01.0000][Dharma/SDK] -1016 Can't Connect to the Appx Data Server"
    },
    {
      state: '00000',
      code: -1016,
      message: "[Dharma][ODBC Dharma Driver 09.01.0000][Dharma/SDK] -1016 Can't Connect to the Appx Data Server"
    }
  ]
}

Thank you! Stay Safe!

@hansaliyad1 were you able to get this one working? I'm not sure what would cause a connection to stop working if it was working fine before except for something like a network interruption, routing issues, or maybe something like an expired password?

Going to close this since there is no activity for over a year and it seems like it isn't an issue with the package.


Date format is getting changed after converting syslog object to toRfc5424SyslogMessage

Hi,
Require date as below format in my Syslog message
"2019-07-18T18:56:38.001+05:30"
Setting date using below API.
syslogMessage.setTimestamp
But After converting syslogMessage object to toRfc5424SyslogMessage and my format of date is changed as below.
"2019-07-18T13:26:38.001Z".
Is there any way to achieve my requirement?
is it possible to provide setTimestamp(String date) API which accepts string instead of Date object?

Hi ,
Any update on above query?

https://tools.ietf.org/html/rfc5424#section-6.2.3
   The TIMESTAMP field is a formalized timestamp derived from [RFC3339].

   Whereas [RFC3339] makes allowances for multiple syntaxes, this
   document imposes further restrictions.  The TIMESTAMP value MUST
   follow these restrictions:

   o  The "T" and "Z" characters in this syntax MUST be upper case.

   o  Usage of the "T" character is REQUIRED.

   o  Leap seconds MUST NOT be used.

   The originator SHOULD include TIME-SECFRAC if its clock accuracy and
   performance permit.  The "timeQuality" SD-ID described in Section 7.1
   allows the originator to specify the accuracy and trustworthiness of
   the timestamp.

   A syslog application MUST use the NILVALUE as TIMESTAMP if the syslog
   application is incapable of obtaining system time.

@arjunpidugu642 you are asking to use another timezone in the syslog timestamp than the GMT timezone, correct?
Would it make sense to use the time zone of the server on which the java-syslog-client runs? java.util.TimeZone#getDefault()
https://docs.oracle.com/javase/8/docs/api/java/util/TimeZone.html#getDefault--
public static TimeZone getDefault()
Gets the default TimeZone of the Java virtual machine. If the cached default TimeZone is available, its clone is returned. Otherwise, the method takes the following steps to determine the default time zone.
 * Use the user.timezone property value as the default time zone ID if it's available.
 * Detect the platform time zone ID. The source of the platform time zone and ID mapping may vary with implementation.
 * Use GMT as the last resort if the given or detected time zone ID is unknown.
The default TimeZone created from the ID is cached, and its clone is returned. The user.timezone property value is set to the ID upon return.

As per RFC 5424 and RFC 3339,  We need to follow timestamp with respect to time zone which we can achieve using Coordinated Universal Time(UTC).
T indicates date time and Z indicates time zone whereas  Z is not required if we have time stamp with an offset from UTC.
2019-07-19T21:19:51+05:30 (with an offset of  +05:30 from UTC)  equivalent to 2019-07-19T16:49:51Z in UTC => Both are valid according to RFC
But as per your code

@arjunpidugu642

what would be the date format for your case?
is it the timezone not being changed to GMT that is the thing that matters the most? or the formatting of the date?

From what I remember, I picked "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'" because it's what I found for RFC 5424 / 3329.

But as per your code ,
Timestamp format is "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"  example 2019-07-19T16:49:51Z
and I am expecting " yyyy-MM-dd'T'HH:mm:ss.SSSXXX" 2019-07-19T21:19:51+05:30
Lets assume a case ,
Msg1 is generating from location A with timestamp 2019-07-19T21:19:51+05:30  after converting( yyyy-MM-dd'T'HH:mm:ss.SSS'Z) 2019-07-19T16:49:51Z
Msg2 is generating from location B with timestamp 2019-07-19T22:19:51+04:30  after converting( yyyy-MM-dd'T'HH:mm:ss.SSS'Z) 2019-07-19T16:49:51Z
And syslog server is running in location C and both msges are showing same msg timestamp.
It would be easy if we have followed timestamp  "yyyy-MM-dd'T'HH:mm:ss.SSSXXX" instead of converting to UTC and adding Z.

Thanks a lot for your response.
I require below timestamp format " yyyy-MM-dd'T'HH:mm:ss.SSSXXX"

what would be the date format for your case?  Ans=>         " yyyy-MM-dd'T'HH:mm:ss.SSSXXX"

what would be the date format for your case? ->[My Answer] " yyyy-MM-dd'T'HH:mm:ss.SSSXXX"
is it the timezone not being changed to GMT that is the thing that matters the most? or the formatting of the date? -> [Answer]  Timezone is being changed to GMT but my request is about format of date.
Please find below examples as per RFC 3339:
"""1985-04-12T23:20:50.52Z ->   This represents 20 minutes and 50.52 seconds after the 23rd hour of
April 12th, 1985 in UTC.
1996-12-19T16:39:57-08:00 ->   This represents 39 minutes and 57 seconds after the 16th hour of
December 19th, 1996 with an offset of -08:00 from UTC (Pacific
Standard Time).  Note that this is equivalent to 1996-12-20T00:39:57Z
in UTC.
1990-12-31T23:59:60Z -> This represents the leap second inserted at the end of 1990."""
So,  According to RFC3339.  1996-12-19T16:39:57-08:00( "yyyy-MM-dd'T'HH:mm:ss.SSSXXX") is equavalent to 1996-12-20T00:39:57Z("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'") and both are valid date formats.
My requirement is to send syslog message in below date format -> "yyyy-MM-dd'T'HH:mm:ss.SSSXXX".
Please help me on this.

@cyrille-leclerc ,
Can you please help me on this.

I have started to introduce more configurability for the time format and timezone, I need to adapt the unit tests as well.

Thanks @cyrille-leclerc .


Don't use nbsphinx_prompt_width to hide prompts

I'm creating this issue because your repo contains a conf.py file with
nbsphinx_prompt_width = 0

... presumably in an attempt to remove the prompts from code cells.
I just want to give you a heads-up that this will stop working once https://github.com/spatialaudio/nbsphinx/pull/439 is merged.
For more reliable alternatives, see https://nbsphinx.readthedocs.io/en/latest/custom-css.html.

Fixed in this commit. Thanks for the heads up!


chore: hmac interception logic with dio

Added the hmac signature interception logic

Commit title should probably use feat: instead of chore.