feat(table): support sticky headers, footers, and columns

Closes #5885, #5890

Heads up - looks like RTL support is lacking. Left and right are absolute positions and the logic should reverse the column sticky position directions

Added two commits:

Add support for RTL (directionality changes should influence sticky column positioning)
Move sticky setter/getter to the mixin

One footnote of this is its not compatible with virtual scrolling, we would need to rethink some of this when we apply that strategy.

Amazing? Could we have a minor release to test out this feature pretty please? 💐

For examples on how to use the sticky stuff, check out the examples that start with "table-sticky-*"
https://github.com/angular/material2/tree/master/src/material-examples

Next minor release is probably going to be in a couple weeks

@andrewseguin  thanks! I haven't figured out how to have an angular cli boilerplater with master version of material2 though.
...sorry I'm a beginner 😢

Hi, is there any specific date when the Mat-table release with sticky/ pinned columns for IE be publicly available
Thanks for your help.

Hi,
Yes, that is really cool and i really need the sticky columns for my project. So if possible i need to know more a less when this is going to be released. Thanks :)

Sticky  is not working in IE. In chrome also, Sticky column alignments are breaking while scrolling.

Hi, Sticky/Fixed header is not working in IE. Is there any plan to fix this issue in next release?

@andrewseguin are You guys planning to add examples showing sticky header and columns to main material site (https://material.angular.io/)?
Material is awesome and each new feature should he highlighted on main site.
For example look at Kendo UI(https://demos.telerik.com/kendo-ui/) they are clearly showing what's new, what's updated.
Sticky header, footer and columns was one of most desired feature, but when You go to main site there isn't even a single example showing it.

IE11 explicitly won't be supported; we decided that the amount of code it would take to work around the absence of position: sticky (and the resources spent maintaining it) isn't worth it based on its share of browser users.
Andrew was just able to finish up the feature before going out-of-office for a while; I'd be happy to accept PRs that add examples for the docs site.

Hi!
I have updated to the latest version, but if i add the sticky keyword to multiple columns, the columns go behind each other other then staying at the position where they are.
So all three of my colums end up sticky on the left side of the screen:
`
<th mat-header-cell *matHeaderCellDef mat-sort-header> Resourcegroup
<td mat-cell *matCellDef="let element"> {{element.resourceGroup.resourceGroup}}

    <ng-container matColumnDef="description" sticky>
      <th mat-header-cell *matHeaderCellDef mat-sort-header> Name </th>
      <td mat-cell style="white-space: nowrap; padding-right: 8px;" *matCellDef="let element"> {{element.resourceGroup.description}} </td>
    </ng-container>

    <ng-container matColumnDef="status" sticky>
      <th mat-header-cell class="headerPadding" *matHeaderCellDef> status </th>
      <td mat-cell style="white-space: nowrap; padding-right: 10px;" *matCellDef="let element"> {{element.status}} </td>
    </ng-container>

`
Please advice!

I have a similar problem. It seems that it is browser dependant:

bottom sticky rows go behind each other with a minimal vertical offset (1px?)
(except for one row with a specified colspan over all columns, which goes correctly below the other overlayed ones).
The top sticky rows stick ok.
Problem only in Chrome (Version 67.0.3396.99 64bit)
In Firefox Quantum everything is ok.
I am using native <table cdk-table ...> with <td cdk-footer-cell ...>

updated yesterday, July 5th (v.6.3):
  "dependencies": {
    "@angular/animations": "^6.0.7",
    "@angular/cdk": "github:angular/cdk-builds",
    "@angular/common": "^6.0.7",
    "@angular/compiler": "^6.0.7",
    "@angular/core": "^6.0.7",
    "@angular/flex-layout": "^6.0.0-beta.16",
    "@angular/forms": "^6.0.7",
    "@angular/http": "^6.0.7",
    "@angular/material": "github:angular/material2-builds",
    "@angular/platform-browser": "^6.0.7",
    "@angular/platform-browser-dynamic": "^6.0.7",
    "@angular/router": "^6.0.7",
    "core-js": "^2.5.7",
    "npm": "^6.1.0",
    "rxjs": "^6.2.1",
    "zone.js": "^0.8.26"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^0.6.8",
    "@angular/cli": "^6.0.8",
    "@angular/compiler-cli": "^6.0.7",
    "@angular/language-service": "^6.0.7",
    "@types/jasmine": "^2.8.8",
    "@types/jasminewd2": "~2.0.3",
    "@types/node": "~8.9.4",
    "codelyzer": "~4.2.1",
    "jasmine-core": "~2.99.1",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~1.7.1",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "^1.4.3",
    "karma-jasmine": "~1.1.1",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "^5.3.2",
    "ts-node": "~5.0.1",
    "tslint": "~5.9.1",
    "typescript": "~2.7.2"


Implementation of pagination and filter number of records

[ ] Develop pagination component

By default all results are returned
The user has the option to limit results displayed on a page at a time to 100, 250, 500, or All
Default pagination is 100
The system will limit results displayed on the page based on option selected
The user will have the option to select additional pages if results exceed selection filter

@JorjaComer  will work with BA team to determine how to document this functionality as the requirements for table pagination


stl_defaultTabTextColor not working

Hello,
I set
app:stl_defaultTabTextColor="##FFFFFF"
but text in tab not color white.
help me, please :(

Hi, @NhenDen
I'm sorry late reply.
I’ve been busy lately at work :P
It was already resolved?
Try it
app:stl_defaultTabTextColor="#FFFFFF"


TMA: Release Atom and E-Core updates

Release CSV and XSLX formats for Atom and E-Core TMA. XLSX change log notes copied below.

Atom TMA version 1.1.

FP_UOPS changed to FPDIV_Uops
Added BR_MISP breakdown stats
Frontend_Bandwidth/Latency changed to Fetch_Bandwidth/Latency
Load_Store_Bound changed to Memory_Bound
Icache changed to ICache_Misses
ITLB changed to ITLB_Misses

E-Core TMA version 2.3.

FP_UOPS changed to FPDIV_Uops
Added BR_MISP breakdown stats
Frontend_Bandwidth/Latency changed to Fetch_Bandwidth/Latency
Load_Store_Bound changed to Memory_Bound
Icache changed to ICache_Misses
ITLB changed to ITLB_Misses
Store_Fwd changed to Store_Fwd_Blk

@captain5050 Heads-up since this will change generated ADL perf metrics.
perfmon/scripts$ diff -rup perf-main/ perf-pr | diffstat
 alderlake/adl-metrics.json   |  132 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------
 alderlaken/adln-metrics.json |  120 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
 2 files changed, 148 insertions(+), 104 deletions(-)

I grabbed the PR and compared the Linux perf output before and after. It all looks good. Thanks!

Thanks Ian and Ryan.


Rebase to go.mod to latest Argo CD v2.0, adopt new APIs as needed, and retest

Once ApplicationSet v0.1.0 and Argo CD v2.0 are out the door, we should adopt the latest Argo CD v2.0 (attempting to keep backwards compatibility where it is straightforward), including fixing any changed APIs, and retesting.

The combined v0.1.0 ApplicationSet + ArgoCD installation is installing argocd 2.0.0, while its current stable version is 2.0.3. Can you release a combined manifest that tracks the latest stable argocd?


Issue with pixijs v4 Spritesheet.js

In Spritesheet.prototype._processFrames you are using _.Rectangle and _.Texture but the code can not resolve the _. When I replace the _ with PIXI like this PIXI.Rectangle and PIXI.Texture it works.

We dont use it, its babel.
If you want to copy the class or override just one method, use this as reference: https://github.com/pixijs/pixi.js/blob/dev/packages/spritesheet/src/Spritesheet.js
Otherwise, please provide more information about the case.


getGlobalFromScript and setGlobalFromScript don't work

What is your question?
I've tried using those but neither do anything so how can I access global variables from other scripts?

It works for me
No matter what the version, the first thing you need to check is the variable declaration; it needs to look like this:
var = value

Not this:
local var = value

If the declaration is correct as well as the spelling when using the function, please send your code and what version you're using and we may be able to help

It works for me No matter what the version, the first thing you need to check is the variable declaration; it needs to look like this:
var = value

Not this:
local var = value

If the declaration is correct as well as the spelling when using the function, please send your code and what version you're using and we may be able to help

I'm on 0.7.1h (the latest) and the variable is a bool that comes from a script in the scripts folder called healthBar.lua

getGlobalFromScript("healthBar.lua", 'isHotfixHud')

The path doesn't start in script folder start in you mod folder getGlobalFromScript("scripts/healthBar.lua", 'isHotfixHud')

The path doesn't start in script folder start in you mod folder getGlobalFromScript("scripts/healthBar.lua", 'isHotfixHud')

That also doesn't work

@Drawoon2 what is your usage of the function, I've been trying but nothing worked

This issue is stale because it has been open for 5 days with no activity.

No one actually gave me a answer,
I did manage to find a unproper solution that worked, it used setVar
Imma close the issue but when someone finds out how to use getGlobalFromScript normally, warn me plz


Setting the port number in griddb_webapi.properties doesn't seem to work

I have set the port to be 8080 in my configuration but it seems to default to 8081 no matter what I do.
Here is the conf in my docker container
$ docker exec -it web-api cat /webapi/conf/griddb_webapi.properties

port=8080

failoverTimeout=5

transactionTimeout=30

containerCacheSize=100

maxResponseSize=20

maxRequestSize=20

loginTimeout=5

maxQueryNum=10

maxLimit=1000000

And then if you look at the logs, it is still running on port 8081:

  .   ____          _            __ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/
 :: Spring Boot ::        (v2.1.0.RELEASE)

2024-02-26 19:27:05,098 INFO  [main] org.springframework.boot.StartupInfoLogger: Starting Application on 01703ff58ddb with PID 1 (/webapi/webapi-ce/build/libs/griddb-webapi-ce-5.5.0.jar started by root in /webapi/webapi-ce/build/libs)
2024-02-26 19:27:05,101 INFO  [main] org.springframework.boot.SpringApplication: No active profile set, falling back to default profiles: default
2024-02-26 19:27:06,097 INFO  [main] org.springframework.boot.web.embedded.tomcat.TomcatWebServer: Tomcat initialized with port(s): 8081 (http)
2024-02-26 19:27:06,113 INFO  [main] org.apache.juli.logging.DirectJDKLog: Initializing ProtocolHandler ["http-nio-8081"]
2024-02-26 19:27:06,120 INFO  [main] org.apache.juli.logging.DirectJDKLog: Starting service [Tomcat]
2024-02-26 19:27:06,121 INFO  [main] org.apache.juli.logging.DirectJDKLog: Starting Servlet Engine: Apache Tomcat/9.0.12
2024-02-26 19:27:06,131 INFO  [main] org.apache.juli.logging.DirectJDKLog: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: [/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib]
2024-02-26 19:27:06,192 INFO  [main] org.apache.juli.logging.DirectJDKLog: Initializing Spring embedded WebApplicationContext
2024-02-26 19:27:06,193 INFO  [main] org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext: Root WebApplicationContext: initialization completed in 1057 ms
2024-02-26 19:27:06,220 INFO  [main] org.springframework.boot.web.servlet.ServletRegistrationBean: Servlet dispatcherServlet mapped to [/]
2024-02-26 19:27:06,224 INFO  [main] org.springframework.boot.web.servlet.AbstractFilterRegistrationBean: Mapping filter: 'characterEncodingFilter' to: [/*]
2024-02-26 19:27:06,224 INFO  [main] org.springframework.boot.web.servlet.AbstractFilterRegistrationBean: Mapping filter: 'hiddenHttpMethodFilter' to: [/*]
2024-02-26 19:27:06,224 INFO  [main] org.springframework.boot.web.servlet.AbstractFilterRegistrationBean: Mapping filter: 'formContentFilter' to: [/*]
2024-02-26 19:27:06,225 INFO  [main] org.springframework.boot.web.servlet.AbstractFilterRegistrationBean: Mapping filter: 'requestContextFilter' to: [/*]
2024-02-26 19:27:06,506 INFO  [main] org.springframework.scheduling.concurrent.ExecutorConfigurationSupport: Initializing ExecutorService 'applicationTaskExecutor'
2024-02-26 19:27:06,679 INFO  [main] org.apache.juli.logging.DirectJDKLog: Starting ProtocolHandler ["http-nio-8081"]
2024-02-26 19:27:06,683 INFO  [main] org.apache.juli.logging.DirectJDKLog: Using a shared selector for servlet write/read
2024-02-26 19:27:06,695 INFO  [main] org.springframework.boot.web.embedded.tomcat.TomcatWebServer: Tomcat started on port(s): 8081 (http) with context path ''
2024-02-26 19:27:06,697 INFO  [main] org.springframework.boot.StartupInfoLogger: Started Application in 1.977 seconds (JVM running for 2.377)
2024-02-26 19:27:14,471 INFO  [http-nio-8081-exec-1] org.apache.juli.logging.DirectJDKLog: Initializing Spring DispatcherServlet 'dispatcherServlet'
2024-02-26 19:27:14,471 INFO  [http-nio-8081-exec-1] org.springframework.web.servlet.FrameworkServlet: Initializing Servlet 'dispatcherServlet'
2024-02-26 19:27:14,477 INFO  [http-nio-8081-exec-1] org.springframework.web.servlet.FrameworkServlet: Completed initialization in 5 ms

here is my Dockerfile:
FROM gradle:jdk8 as gradleimage
COPY webapi /webapi
COPY repository.json /webapi/conf/repository.json
COPY griddb_webapi.properties /webapi/conf/griddb_webapi.properties

WORKDIR /webapi/webapi-ce/
RUN ./gradlew build

ENV GS_WEBAPI_HOME=/webapi

WORKDIR /webapi/webapi-ce/build/libs/
ENTRYPOINT ["java","-jar","griddb-webapi-ce-5.5.0.jar"]

Here I am copying the properties file prior to building and running jar file.

Thank you for your report.
I'll check it.

I'm sorry, but the specification for port was changed.

port in griddb_webapi.properties: Unused
server.port in application.properties: Added

Could you try the following steps ?

Copy webapi-ce/src/main/resource/application.properties
to your working directory
(in case of your Dockerfile, it is /webapi/webapi-ce/build/libs/)
Edit server.port in it

I'll update README and API Reference.

I have updated the following files:

griddb_webapi.properties
API Reference
README

thank you


fix: improve coverage

upgrade appleboy/gofight package
improve code coverage

Codecov Report

Merging #9 into master will increase coverage by 2.06%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master     #9      +/-   ##
========================================
+ Coverage   97.93%   100%   +2.06%
========================================
  Files           2      2
  Lines         145    145
========================================
+ Hits          142    145       +3
+ Misses          2      0       -2
+ Partials        1      0       -1

Impacted Files
Coverage Δ

prom.go
100% <0%> (+2.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c6ef6...60eac35. Read the comment docs.

Codecov Report

Merging #9 into master will increase coverage by 2.06%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master     #9      +/-   ##
========================================
+ Coverage   97.93%   100%   +2.06%
========================================
  Files           2      2
  Lines         145    145
========================================
+ Hits          142    145       +3
+ Misses          2      0       -2
+ Partials        1      0       -1

Impacted Files
Coverage Δ

prom.go
100% <0%> (+2.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c6ef6...60eac35. Read the comment docs.

Thank you so much :smile:

@Depado You merged so quickly 👍 Thanks.

You're welcome. Also created a new release as v1.2.0
Cheers :+1:


[nghttp2] Update to 1.42.0.

Update nghttp2 from 1.39.2 to 1.42.0. This includes
a fix for CVE-2020-11080, added in version 1.41.0:
https://github.com/nghttp2/nghttp2/security/advisories/GHSA-q5wr-xfw9-q7xr

Should add vcpkg_fixup_pkgconfig() after vcpkg_install_cmake()

Done.

vtk-m regression will be fixed in #14884.

Thanks!


Name platform-specific module files using a normalized target triple

Swift currently looks up platform-specific .swiftmodule, .swiftdoc, and .swiftinterface files by architecture name:
Foo.swiftmodule/
    x86_64.swiftmodule
    x86_64.swiftdoc
    arm64.swiftmodule
    arm64.swiftdoc

As part of module stability, we'd like to clean this up by using a normalized form of the target triple instead:
Foo.swiftmodule/
    x86_64-apple-ios-simulator.swiftmodule
    x86_64-apple-ios-simulator.swiftdoc
    arm64-apple-ios.swiftmodule
    arm64-apple-ios.swiftdoc

We will still support the architecture-only names for backwards compatibility, but we'll prefer the target triple names.
Normalization covers architectures ("amd64" -> "x86_64"), OSes ("macosx10.11" -> "macos"), and vendors ("unknown" -> "apple"); it also makes implicit "simulator" environments explicit. Apple platforms are the only ones that currently build for multiple architectures in practice, so normalization is only applied on those; other platforms will look for the full triple passed to the compiler (if they ever see a swiftmodule directory, which again, they won't).

This PR is best reviewed commit-by-commit. The first three commits should be NFC; if they aren't, I'd like to know, because I may have broken something subtle. There is a diagnostic I'd like to add too, but I'll do that in a separate PR.
(@aciidb0mb3r, this shouldn't break you, but you may want to be aware of it.)
Resolves rdar://problem/47094708.

@swift-ci please test

Thanks for notifying. I wonder if SwiftPM should also switch to this structure instead of emitting swiftmodule and swiftdoc files directly in the build dir.

I think SwiftPM's okay for now, but if it ever wants to support multi-arch products then it'll become interesting.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 1d360222b4cc9a15083fe997d157c7a0f5c3cdd7

Build failed
Swift Test OS X Platform
Git Sha - 1d360222b4cc9a15083fe997d157c7a0f5c3cdd7

@swift-ci please test


[REGRESSION]: Azure CLI@2 - toolExecutionError.indexOf is not a function

New issue checklist

[X] I searched for existing GitHub issues
[X] I read pipeline troubleshooting guide
[X] I checked how to collect logs

Task name
AzureCLI@2
Breaking task version
No response
Last working task version
No response
Regression Description
Our pipeline stopped working April 02 and the error message does not get logged since toolExecutionError.indexOf is not a function causes a crash.
This seems to have been introduced in this commit: https://github.com/microsoft/azure-pipelines-tasks/commit/9e519cb289c4da4a03928dfcd3a9bbe113696b2e by @LeftTwixWand.
The problem seems to be that you try to use indexOf on toolExecutionError which in some cases is neither a string nor an array at e.g. https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/AzureCLIV2/azureclitask.ts#L101.
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
windows-2022
Relevant log output
==============================================================================
Task         : Azure CLI
Description  : Run Azure CLI commands against an Azure subscription in a PowerShell Core/Shell script when running on Linux agent or PowerShell/PowerShell Core/Batch script when running on Windows agent.
Version      : 2.237.3
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-cli
==============================================================================
##[error]Unhandled: toolExecutionError.indexOf is not a function
##[error]TypeError: toolExecutionError.indexOf is not a function
    at azureclitask.<anonymous> (D:\a\_tasks\AzureCLI_46e4be58-730b-4389-8a2f-ea10b3e5e815\2.237.3\azureclitask.js:101:77)
    at Generator.next (<anonymous>)
    at fulfilled (D:\a\_tasks\AzureCLI_46e4be58-730b-4389-8a2f-ea10b3e5e815\2.237.3\azureclitask.js:5:58)

### Full task logs with system.debug enabled

_No response_

### Repro steps

```yml
schedules:
  - cron: "0 19 * * *"
    displayName: At 19:00 every day
    branches:
      include:
        - main
    always: true
pr: none
trigger: none
pool:
  vmImage: "windows-2022"

stages:
  - stage: abc
    jobs:
      - job: abc
        steps:
          - task: AzureCLI@2
            displayName: Take down qa appservices and serviceplan
            inputs:
              azureSubscription: "ABC"
              scriptType: ps
              scriptLocation: scriptPath
              scriptPath: "iac/azure-pipelines/abc.ps1"

It is because of commit https://github.com/microsoft/azure-pipelines-tasks/commit/9e519cb289c4da4a03928dfcd3a9bbe113696b2e#diff-cf206bc78bf4397822ed49cd2e9a2edd8a9bc732c31af52660e58ea0edd5e63aR101
There is an untyped error and no check if error is type of string or array before the "indexOf"-method is called for it. @LeftTwixWand

I had a similar issue occur, but for me it was due to not passing in an appropriate Azure Subscription. Perhaps this could be your issue? Maybe try confirming whether this subscription exists or not 🤔

I had a similar issue occur, but for me it was due to not passing in an appropriate Azure Subscription. Perhaps this could be your issue? Maybe try confirming whether this subscription exists or not 🤔

Yes, the reason our pipeline is failing in the first place is due to something else, but this issue is about the error not getting properly logged because of the indexOf error crashing the task before the real error can get reported.

Some issue for me with a service connection.

Hello @ponbac, @JulianCodespotiMYOB and @jonmikeli
Thank you for reaching me.
As @ponbac noticed, my changes do not work properly. But the indexOf issue occurs in the error-handling part of the code.
Which means that the error has already happened.
I'm 99% sure that the original issue, which you have - is expired secrets on your service connection.
So please, update the secrets on your service connection or (recommended): convert your service connection from secrets-based to Workload Identity Federation. And this should mitigate the issue.
From my side, I'll try to revert the changes asap.

Meanwhile, we can use the previous version of the task by using task<EMAIL_ADDRESS>

Adding a note that I am using service connections with federated identity and recevied the same error. Using @shanoor's comment about downgrading the task version bypassed the error.

Just wanted to note that we are also having this issue and we are also using Workload Identity Federation. Downgrading as suggested by @shanoor fixes the issue.
@LeftTwixWand

Hello @ponbac, @JulianCodespotiMYOB and @jonmikeli Thank you for reaching me.
As @ponbac noticed, my changes do not work properly. But the indexOf issue occurs in the error-handling part of the code. Which means that the error has already happened.
The most common reason for service connection error - is expired secrets. So please, check the secrets on your service connection are valid. If not - please update the secrets or (recommended): convert your service connection from secrets-based to Workload Identity Federation. This should mitigate the issue for some of you.
From my side, I'll try to revert the changes asap.

Hi @LeftTwixWand ,
Thank you for your answer.
In case it helps, I have created a new connection and same result.
I will use the former version while the issue is solved.

Same problem here, even using Workload Identity Federation

Faced the issue today. We are using Workload Identity Federation as well.

if you use task<EMAIL_ADDRESS>then you will get the error: 'unable to locate executable file: 'powershell'. Please verify.....
and this is the actual error.
to resolve this just add the pool image as 'windows-latest' and it will work with task: AzureCLI@2 also.
you need to add the below part in your script before the task
pool:
vmImage: "windows-latest"
steps:

task: AzureCLI@2


Graph v1.0 API reference not showing navigation pane.

Graph v1.0 API reference not showing navigation pane. If you open the following article, the left side nav pane is missing: https://learn.microsoft.com/en-us/graph/api/overview?view=graph-rest-1.0&preserve-view=true
But if you toggle to beta, it shows up correctly for beta:
https://learn.microsoft.com/en-us/graph/api/overview?view=graph-rest-beta&preserve-view=true

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d489b596-8db6-6b4e-7271-77a6fb735c37
Version Independent ID: afc8208d-990b-098f-0508-fcd5745d35e6
Content: Microsoft Graph REST API v1.0 endpoint reference - Microsoft Graph v1.0
Content Source: api-reference/v1.0/overview.md
Product: non-product-specific
GitHub Login: @angelgolfer-ms
Microsoft Alias: MSGraphDocsVteam

Thank you @boeapen for catching this error. I've linked a PR that will fix the issue.


Bug/duplicate failure response messages

It looks good to me.However squashing the commits would have helped.


Support session

What is the expected enhancement?
Support Qiskit Runtime session. Probably easier to wait for https://github.com/Qiskit/qiskit-ibm-runtime/issues/548 to finish first though.

@kt474 - can you elaborate on the intent of this issue?

Do we want to be able to write something like:

with Session(service=service, backend=backend_name) as session:
    job = backend.run(circuits, session=session)

Will provider use Session from qiskit-ibm-runtime?

I don't know the exact details (@jyu00 maybe you can elaborate) but yes, I think we would want to same format as qiskit-ibm-runtime. The snippet you posted makes sense to me.

For now, to keep things more simple, we can use Session from qiskit-ibm-runtime but ideally we copy over the necessary code to this repo and then remove the duplication.

Yeah we want the user interface to be as similar as possible. In qiskit-ibm-runtime Session can be used both as a context manager and passed in as a parameter to the primitives (because context manager is not always possible/easy). So we should support both here as well.

@jyu00 , if I understand you correctly, then we would also like to support passing Session as a parameter to either IBMBackend() or to IBMBackend.run(), like it is an (optional) parameter to Sampler or Estimator. I don't think it is a good idea to change the interface to IBMBackend, although that would be more similar to what is done in the primitives. I would prefer to pass Session as a parameter to IBMBackend.run(). Do you agree?

I don't think it is a good idea to change the interface to IBMBackend

I agree, since people don't instantiate IBMBackend directly.
Unfortunately it's a bit difficult to retro-fit Session into backend.run and keep the interface consistent. After thinking about this some more, how about

With a context manager

provider = IBMProvider()
backend = provider.get_backend("ibm_gotham")

with Session() as session:
    job1 = backend.run(circuits)
    job2 = backend.run(circuits)  # <--- we'll need to check/raise this is not the same backend

Without context manager

provider = IBMProvider()
backend = provider.get_backend("ibm_gotham")
backend.set_options(session=Session())
job1 = backend.run(circuits)
job2 = backend.run(circuits)

Now Session in qiskit-ibm-provider will continue to accept max_time in its constructor. Unlike its counterpart in qiskit-ibm-runtime, it obviously won't accept service. I don't think it's necessary to pass a backend either, since the backend to be used can be inferred.
How does this sound?

My approach was that Session should be a member of the IBMProvider and not of IBMBackend. I view the backend as a physical being and having a Session would not be in line with that. I also wanted to keep IBMBackend similar to that in qiskit-ibm-runtime, and that one does not own a Session.
I am also not sure about passing session as an option to the backend. All the other options are of type configuration/run options.
Please have a look at what I did in the PR #675 and tell me if you agree with this direction or if you still think the Session should be passed to the backend.

@merav-aharoni after some feedback from internal users, we settled on
# without context manager
backend = provider.get_backend("ibmq_manila")
backend.open_session()
backend.run(...)
backend.close_session()

# with context manager
with backend.open_session():
    backend.run(...)

The main reasons behind this are

Easy to open a new session without having to create a new object
We can still pass backend around to methods that take a Backend object (like in qiskit-experiments)
No need to specify the session parameter at each run


Solar Neutron activator is missing from NEI

i wanted to build fustion reactor everything was find until i came to craft solar V activator and i found them missing they are nowhere to be found using latest mekanism after updating to the laterst beta its showing.

Fixed in development.


Mapping time boost was removed in 7.10

This was always a NOOP on the server and was removed from the server.
Here we obsolete them with a compiler warning

Opened https://github.com/elastic/elasticsearch/issues/64982 to log the breaking change on the server.

Boost already removed on master


Address for check mailing in registration email doesn't include line breaks.

Mine looks like this:

That's odd... the <br /> tags are definitely in the template, so they're probably being rendered... I guess something somewhere along the way is stripping them out?

@harrislapiroff Do you know if this is still happening? The email templates have undergone fairly significant changes since this issue was created.

I have no idea, honestly :. Maybe we should have some views for sample renderings of emails?

We do have views for sample renderings of emails ;-)

jklol

It looks like this is resolved, looks like as part of #506.


The return of TSHttpTxnIsInternal changed.

When the name changed in the move to 7.0.  The original version had a return
value of TS_SUCCESS(0) if the transaction is internal.  The new version has a
return value of True(1) if the transaction is internal.  This plugin changed
the name but not the return value test.

We should cherry-pick this back to 7.1.x IMO.

[approve ci]


re-arrange interaction fields for new design

Discussed with designer and 2 fields need to be put back in that were taken out before.


Update README.md

Is your feature request related to a problem? Please describe.
README.md is somewhat out of date.
Describe the solution you'd like

Integrate new tables and data into README.md.
Pull into docs/ for Jekyll serving
Bonus: autogenerate Snowflake schema from METADATA table or the generating notebook

Done directly in master.


Performance optimisation of readName method

Hi.
I just started to also read a bit of what is happening under the hood of wren and started with the compiler. It looks really straight forward. Kind of what I write when writing simple compilers. While reading, I stumbled upon line 529ff and thought that it could be done faster, right?
My C knowledge is a bit rusty (did that in school a bit, but that's really long ago), but the readName method seems to be doing much more then it has to. If you would read a break token, you would still call the ìsKeyword-method 15 times more often then you would have, when bailing out after matching the break if statement. Maybe something like:
if (isKeyword(parser, "break")) type = TOKEN_BREAK;
else if (isKeyword(parser, "class")) type = TOKEN_CLASS;
else if (isKeyword(parser, "else")) type = TOKEN_ELSE;
…

Or using a switch statement or something?

switch statement isn't possible since you can only check 1 value against several integers.
But I also do think that "else" should be added.

Yeah, good call. Not sure what I was thinking there. :)


Add campaign skip button

Context
In the original game there was a campaign skip button which would progress you to the end of chapter 10. It is available after doing a small amount of story to finish the interactive tutorial.
It used to progress your player level and halidom, and grant you some material rewards.
If you did not skip, it used to grant you hustle hammers + materials equivalent to the fort level ups skipping would have granted you.
The feature request
This button should be implemented in Dawnshard. We should also implement the reward after Ch.10 for both skipping and not skipping.
Implementation details

The button kicks you to the title screen after pressing it rather than trying to encode the vast amount of data in update_data_list
The main campaign quests can be identified by having a _Gid in the QuestData asset of 100XX where XX is the chapter number.
Unsure about how to identify main campaign stories.
See packet capture here: https://dragalia-api-docs.readthedocs.io/en/latest/dragalia/story_skip_skip.html

I have begun work on this.

Implementation questions:

Do we want to skip the hard and very hard quests?
Do we know the details of which buildings to level up? And to what levels?

No, I think it’s just normal as it’s intended to skip past doing story to unlock other parts of the game. Hard/Very Hard is only done to unlock resources. 2. See below linkWiki page: https://dragalialost.wiki/w/Beginner's_Guide#The_Story_Skip_OptionSent from my iPhoneOn 24 Apr 2024, at 04:30, jelq @.***> wrote:
Implementation questions:

Do we want to skip the hard and very hard quests?
Do we know the details of which buildings to level up? And to what levels?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I wish I saw this earlier! I manually tested the correct amount of exp already! 🤣
Thanks much!

@jaredstrong89 Thanks for your PR for the initial issue. Unless I missed something, I don't think it includes the Chapter 10 reward for not skipping. However, I think this can be done in a separate pull request -- would you be happy to contribute that as well?

Yes, I can look into it after making adjustments to the first PR.

Yes, I can look into it after making adjustments to the first PR.

@jaredstrong89 I've opened #787 to cover the chapter 10 reward. Let me know if you'd like me to assign it to you :)

Yes, I will take it. I have done some preliminary testing on that one.


(sourcetree) Migrate SourceTree

This PR is to move the SourceTree package from https://github.com/jivkok/Chocolatey-AutomaticPackages/tree/master/SourceTree to the Core Team Packages. @jivkok and I would prefer to have the package in this repository for easier maintenance.
I invited the Chocolatey user as a maintainer.
Please note that the update script immediately will update, since currently the latest version is not available yet on Chocolatey.

Besides above comments it looks good and if it is removed from ketarin jobs it is good to merge.

@pascalberger said...
I invited the Chocolatey user as a maintainer.

I have accepted the invite.
Have you confirmed with @jivkok that he has removed the package from his automatic execution?

I send @jivkok a mail asking to remove his script. Waiting for confirmation

Mergin this as @jivkok has removed his Ketarin scripts.


Support inline math

As requested here.

There is support for inline math. (And was at the time this issue was created.) So... Maybe the original request was for block math?
Anyway, closing.

That link mentioned inline Math and Display Math.
So this issue probably should be reopened and renamed as "Support Display Math".

The default depends on image rendering service, but you can override it by starting the formula with things like \displaystyle or \textstyle:
https://tex.stackexchange.com/questions/32824/show-inline-math-as-if-it-were-display-math

CodeCogs defaults to display and seems to encourage non-standard \inline for inline.


Incompatible after upgraded from Page8's plugin

Question
I assume that I wouldn't need to do anything after upgrading from Page 8's many to many plugin, but I got errors in the CP like this on all the many to many fields: Unable to find component class 'Page8\ManyToMany\fields\ManyToManyField'. I wonder what I did wrong.
I didn't run composer require verbb/many-to-many && composer remove page-8/craft-manytomany, but I remove page-8/craft-manytomany and specify "verbb/many-to-many": "2.0.0" in composer.json, and run composer install (without composer.lock) together with Craft & bunches of other plugins I want to update. I assume this is the same as running composer require and composer remove as you suggested.
It would be great if you can advise.
Additional context
PHP version 8.1.9
Craft edition & version	Craft Pro 3.7.61

Should be fixed in 2.0.1

Hi @engram-design ,
Thanks for looking into it so quickly.
It still doesn't migrate correctly though. The field warning (e.g. Unable to find component class 'Page8\ManyToMany\fields\ManyToManyField') is gone, but the field settings (i.e. Linked Section and Associated Field) are not migrated over. They are both set to the first option in the dropdown, and the Many to Many fields in the existing elements are all empty.

Hmmm, nothing should've changed on that front. But it's probably not a great move that both the Linked Section and Associated Field setting use the ID, instead if the UID, which it should be using to be compatible with project config.
I'll be making that change shortly, but it shouldn't have a bearing of your field.
Can you send through your field settings, before you've saved the field? In the fields database table, and the settings column.

Strange. There is a section with the ID of 4 and a field with the ID of 93, correct?

Yup, it's supposed to be section ID 4 and field ID 93.
It doesn't look like the UID changes have been released yet. But even with that, the issue persist, as the first migration script m221130_000000_verbb_migration already migrates the field settings incorrectly.
Anyway, the issue can be fixed by manually update the field settings. Will do for now.

You're right, I'd not pushed that change! See 2.0.2.
The migration does re-apply your project config settings (so we can change the namespace for the field type), so unless that's somehow different to what's in your database, I don't see how that could change.
It also could be an issue that you might've done the updates before the initial m221130_000000_verbb_migration migration was run, which might've messed things up.
Regardless, will keep this open for now.


Vendor Name
pi3g
Vendor Country
DE
Vendor URL
https://buyzero.de/
Product Links
https://rpilocator.com/?vendor=pi3g
Additional information
https://github.com/nerves-metal-detector/nerves_metal_detector/blob/master/CONTRIBUTING.md#adding-new-vendors-and-products-from-rpilocator
Vendor name (from rpilocator) does not match URL. Figure out if another name needs to be used.

Name BuyzeroDe


Remove images volumes if user specified --rm

Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

LGTM

Included in #2446


Bump frequenz-api-microgrid to 0.15.3

This is only to indirectly bump the api-common dependency to 0.5.x so it is compatible with other APIs.

The test package installation CI check fails because we need a release of common API v0.5.3 and microgrid API v0.15.3 first for it to pass.

And this needs the dependencies updated when common API v0.5.3 and microgrid API v0.15.3 are released.

This PR is actually not needed, as the SDK already depends on frequenz-api-microgrid >= 0.15.1, so downstream projects can upgrade to frequenz-api-microgrid == 0.15.3 without any SDK updates!

On a second thought, since most downstream projects (at least API actors) won't depend explicitly on frequenz-api-microgrid, the only sane way to specify the dependencies to make sure there are no conflicts would be to use a SDK that has v0.15.3 as the minimum microgrid API version.
So downstream projects don't need to update the SDK version, but if they don't they could potentially end up with cryptic errors about pip not being able to find a set of dependencies that work well together.


Dimensions.get('window') is not returning the current values on Android

Description
The width and height returned by Dimensions.get('window') are not updating. The first time it's called, it returns the correct values. But if I change the device screen orientation and call it again, it returns the same values as before. This only happens on Android, and only started happening after I upgraded from RN 0.62.2 to 0.63.0
React Native version:
0.63.0
Android only
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Add an onLayout like this to a View in your app: onLayout={() => {    console.log(Dimensions.get('window'));  }
Rotate the device and notice that the width and height printed to the console stay the same after each rotation

Expected Results
The width and height should update to reflect the new screen layout

have you tried the newer useWindowDimensions()?
https://reactnative.dev/docs/usewindowdimensions

I haven't yet. Seems handy, but our app is all class components so we can't use it without rewriting them or wrapping them in function components.

I can confirm. On Android the event listener wont trigger on orientation change. It makes no difference if we use Dimensions.addEventListener('change', setWindowSize); or useWindowDimensions(). On iOS it still works

onLayout seems to have changed behavior in 0.63 but I'm not sure exactly how. It's breaking my app on iOS only right now by failing to call onLayout when a parent element resize causes a child element to move on the screen. Seems likely related to this issue. What changed with onLayout in 0.63?

weirdly, when using this package the device orientation changes get detected...

I can confirm. On Android the event listener won't trigger on orientation change. It makes no difference if we use Dimensions.addEventListener('change', setWindowSize); or useWindowDimensions(). On iOS it still works

Yes, it not work with android !!

Any updates on this issue?

I can confirm it is not working on android, but on iOS is it still ok. Using RN 0.63.2. Probably also happening on 0.63.3, I will try to update later.
This has broken my orientation-dependent rendering, I had to check the 'screen' dimensions to get the correct orientation change and I see a lag in the orientation layout change after device rotation of about 2-3 seconds (only on android).

How is this issue still going on? How can such a popular framework not have a working Dimensions module?!

This one is pretty mild, it has only been open for 3 months. There are outstanding bugs going on 4 years without solutions. There's a lot of undocumented, inconsistent-across-platforms, or (especially on Android) broken stuff in RN. FB has developed somewhat of a reputation for subpar community management with this project. Many issues get closed without resolution or explanation. PRs linger for months or years. Long standing bugs never get fixed/merged because FB has closed internal workarounds. etc, etc.
I'm not complaining however, it's free software, we can fork and fix it ourselves if the quirks bother us. It's just a shame to see an innovative and otherwise great project like RN marred and slowed by seemingly indifferent maintainers.
As for a fix, I've found that many measurement problems on Android are corrected by doing two things:

Add collapsible={false} to your views you plan to measure. Even if you have a ref on a view Android/RN will still "optimize" (remove) it leading to unexpected behavior
Use a ref and the .measure function to get the measurement at the time you need it instead of relying on onLayout. Frequently onLayout doesn't get called when expected or doesn't return the values you expect because of animations or mounting behavior. Just be aware that .measure returns different values than onLayout. IIRC measure will give you the absolute pixel size on screen where onLayout gives you the untransformed original size (ex: if transform: [{scale: 2}] is on a view onLayout will give width: 50 and .measure will give width: 100)

@react-native-bot This is the really critical issue which breaks all Android orientation related styling in apps. When this can be reviewed by maintainers? Thanks...

The fix for this is checked into the master branch (thank you @ajpaulingalls and @ejanzer) and will naturally make its way into the first<EMAIL_ADDRESS>release candidates.
If you want it to be included in the future<EMAIL_ADDRESS>patch release, please upvote this comment.
https://github.com/react-native-community/releases/issues/212#issuecomment-725612630

I'd like to note that my issue about the dimensions API is still actuai, and dimensions is not working good with (at least) a split-screen feature, my issue is #30371 and it's still broken on 0.63.4(as I just tested), since the patch mentioned above was included in 0.63.4 I expected it to work, but it didn't do a thing to me.
Also let me know if I should close my issue(react with -1), since this one seems to be the same. Can anyone else also confirm the issue being present in 0.63.4, or am I trippin

any solution for this issue?

Hi
I am in this problem, too... any solutions?

@martingg88 @jcabrerazuniga https://github.com/facebook/react-native/issues/30371#issuecomment-794430866 might be pretty helpful for certain cases

Dimensions.get('screen') still doen'tt update when rotating device. I have to close/reopen the app to get it to update.
Dimensions.get('window') seems to work though, but I use both in my app to calculate dim of statusbar/navbar.
RN version 0.64

Hello,
I can't use orientation feature. useWindowDimensions() never fires or a console.log("dimensions") forcing a rerender is never updated with right values.
My app is already big and its is complicated to know what it can be conflicting

This is still an issue in 64.1.

This is still an issue in 64.1.

@jmsbrett Version 0.64.2 seem to have a fix for it.

@ws333 just tested, 0.64.2 still got #30371 thought, going to bump it once again at 0.65 😩

Hi, is there any fix? still its not working for me on android

@MrAdex77 does it actually work on 0.64.2? Last time I tried it still had the same value for whatever split screen dimension I've put

Updated to 0.63.4 from 0.63.3, and confirmed fixed on Android.


planning: Bubble up error messages from logs

Problem
Creating discussion from #1422

CLI and API errors are are not very informative, eg Model failed to load with status code 500
There are more useful error logs in cortex.log and cortex-cli.log
We can bubble up the useful error messages for common errors for users to troubleshoot, or give detailed errors

Success Criteria

Common Errors messages are bubbled up to CLI and API

List of common Errors (WIP)

Insufficient VRAM #1439
Could not load engine #1422
Uncaught errors uncaught exception of type cpp

Tasklist

Closing this, thanks @namchuai!


update docs to address feedback

Update docs to address feedback

closes #1
closes #2

@gmao-cda let me know if this update addresses the questions you had.


710 fixed header nav

What does this pull request aim to achieve? 💯
closes #710
Fix header nav to top

closing to rename branch with feature prefix to trigger build

@jyclam  Please note that this has to work well with mobile as well. Currently it needs to be fixed.


bpf: split complexity configurations into separate files

The complexity testsuite currently loads configuration from a single file for each BPF object and kernel version. In the file each line is a distinct configuration for that BPF object. For example:
-DFOO=1
-DBAR=1

would compile twice. Once with FOO defined, once with BAR. In practice we have about 30 to 40 defines per each line, which makes editing, diffing, etc. a nightmare.
Switch the format from one line per configration to one file per configuration. This makes it easier to diff and also to resolve merge conflicts.
The existing configurations were converted to invidiual files using the following script:
#!/bin/bash

set -euo pipefail

for dir in bpf/complexity-tests/*; do
    test -d "$dir" || continue
    pushd "$dir" || exit 2
    for f in *.txt; do
        i=0
        while read -r line; do
            test -z "$line" && continue
            i=$((i + 1))
            target="$(basename "$f" .txt)"
            mkdir -p "$target"
            echo "${line// /$'\n'}" > "$target/$i.txt"
        done < "$f"
    done
    popd || exit 2
done

/ci-verifier

This PR is probably best reviewed with Hide whitespace changes enabled.

/test

/test

Travis failure is due to https://github.com/cilium/cilium/issues/26617

Timo is on PTO, so no review from him. Dylan and Robin reviewed instead.


Proper text not view in MDTextField

Description of the Bug
when typing in MDTextField char move right to left when type more text. its perfectly work but problem in last char that i typed in that not show.
To view that char need to use right arrow key to move cursor after that char view
Code and Logs
from kivymd.app import MDApp
from kivy.uix.screenmanager import Screen
from kivy.lang import Builder
kv="""
MDTextField:
    hint_text: "Email"
    pos_hint: {"center_x":0.5, "center_y":0.6}
    size_hint: 0.2,0.09

"""
class MyApp(MDApp):
    def build(self):
        screen = Screen()
        screen.add_widget(Builder.load_string(kv) )

        return screen

MyApp().run()

@WithSJ @HeaTTheatR this is a bug of TextInput

when the same code run in the android text field works perfectly...
I think this bug only in desktop

it might be from SDL2, so it's internal of Kivy

looks like it's a problem from kivy
the cursor moves the character ammount before it shows in screen, so it might has not real limmiter on the right side while the text is "moved " to the left

I am closing this issue because it is not related to KivyMD library.

I am closing this issue because it is not related to KivyMD library.


Update Mailbox to 0.7.2

Issues have been fixed. In addition, Mailbox is at 0.7.2 now.

Thank you for the contribution. It was merged directly as e48921b1b5b23a55eca07fa1a6f8faca98496f9d to keep commit history cleaner. Your contribution is still credited to you.


Enable native animations

This is enabled by default in projects created with RN39+
Since this project was created with much older project template, it has to be enabled by default.

Automated message from Dropbox CLA bot
@borisyankov, it looks like you've already signed the Dropbox CLA. Thanks!


alt comparison report header

Please remove the word "Damage" from the header of the summary table

Fixed:


Follow up on "googlechrome.fireeye issue on install #338"

This is still an issue

Hi @zaqes, I have reopen #338. Let's move our conversation there since you already have already posted error messages on that issue.


TSan-fixes4

Closes #3032.

I've marked this WIP simply because I'm not in love with the call_once solution, and hoping someone has a better idea...

I don't think anyone else will be thinking about this problem, so this will likely be the only proposed solution.

Another possibility for the call_once is maybe to just get rid of the dynamic cast?  It looks like it's maybe there as a debug-style assertion...

\azp run ITK.Linux.Python

/azp run ITK.Linux.Python

@jhlegarreta I can't seem to figure out how to get github to show me what you changed on top of my changes here...

@jhlegarreta I can't seem to figure out how to get github to show me what you changed on top of my changes here...

Only included <mutex> instead of <atomic> in here:
https://github.com/InsightSoftwareConsortium/ITK/pull/3029/commits/9f3459cd75cfeb72531defece0ad9f644f589803#diff-2d02c5eb0b0d66ba315f710393a2935a82bcdc7e2e7b685e69105e8b0aae5ed0R27
following https://en.cppreference.com/w/cpp/thread/once_flag
The error report:
https://open.cdash.org/viewBuildError.php?buildid=7676273
Otherwise, in a terminal, if you can retrieve your former commit (e.g. git reflog), I guess git diff 9f3459c..{former_commit} should show the difference.
I rebased interactively and push-forced, since the change had been introduced in the 2nd commit of the 3 series.
HTH.

I don't think anyone else will be thinking about this problem, so this will likely be the only proposed solution.

OK, well I guess we can go with this if people find it reasonable...


bug: kits mixpanel events are no longer sent to mixpanel

Background
We're missing the following events in mixpanel: ETH_MESSAGE_COUNT, POLY_MESSAGE_COUNT, BNB_MESSAGE_COUNT`
All stopped 8 days ago, but no code changes were made. https://github.com/palomachain/kits
https://count.palomachain.com/ works.
Done when

[ ] we're receiving the 3 mixpanel events daily again

https://github.com/palomachain/kits/pull/13


WIP: Added support for trusted proxies / hosts in Request.

[ ] Add test for getUserIP
[ ] Add test for getMethod
[ ] Add test for getIsAjax
[ ] Add test for getIsPjax

Q
A

Is bugfix?
yes

New feature?
yes

Breaks BC?
no

Tests pass?
yes

Fixed issues
#10854

Need some feedback on:

yii\filters\HttpCache uses $_SERVER directly. It currently has a dependency on \Yii::$app->response, can I just add a dependency on \Yii::$app->request to remove the usage of the global array?
Same for ErrorHandler.

Also, what is the convention on using getters vs magic properties inside the core?
In Response I see: ->getHeaders().

yii\filters\HttpCache uses $_SERVER directly. It currently has a dependency on \Yii::$app->response, can I just add a dependency on \Yii::$app->request to remove the usage of the global array?

Yes.

Same for ErrorHandler.

Yes.

@samdark I'm looking into the CSRF tests now and I'm having some issues.
This is the original code:
/**
     * test CSRF token validation by POST param
     */
    public function testCsrfTokenHeader()
    {
        $this->mockWebApplication();
        $request = new Request();
        $request->enableCsrfCookie = false;
        $token = $request->getCsrfToken();
        // accept no value on GET request
        foreach (['GET', 'HEAD', 'OPTIONS'] as $method) {
            $_POST[$request->methodParam] = $method;
            $this->assertTrue($request->validateCsrfToken());
        }
        // only accept valid token on POST
        foreach (['POST', 'PUT', 'DELETE'] as $method) {
            $_POST[$request->methodParam] = $method;
            $request->setBodyParams([]);
            //$request->headers->remove(Request::CSRF_HEADER);
            unset($_SERVER['HTTP_' . str_replace('-', '_', strtoupper(Request::CSRF_HEADER))]);
            $this->assertFalse($request->validateCsrfToken());
            //$request->headers->add(Request::CSRF_HEADER, $token);
            $_SERVER['HTTP_' . str_replace('-', '_', strtoupper(Request::CSRF_HEADER))] = $token;
            $this->assertTrue($request->validateCsrfToken());
        }
    }

However with enableCsrfCookie set to false, the CSRF value will be saved in the session.
In my test setup, the session component does not work in phpunit due to output already started...
I've created a new test in SessionTest
public function testOpen() {
        $session = new Session();
        $session->open();
        $this->assertFalse($session->getIsActive());

        ini_set("session.use_cookies", 0);
        ini_set("session.use_only_cookies", 0);
        ini_set("session.cache_limiter", "");
        $session->open();
        $this->assertTrue($session->getIsActive());
}

This illustrates that session does not work in PHPUnit.
It also indicates the tests for Request actually test Session as well.
One solution would be to mock a Session component that doesn't actually use session but instead just uses an array. This will work fine for unit tests.
Alternatively, Request::getCsrfToken could be used instead of loadCsrfToken, since we already assume an attacker cannot guess the CSRF token generated in a previous request, it is not unreasonable to assume an attack also cannot guess the CSRF token generated in the current request.
Please let me know how you'd like to proceed!

I'd use getter.

I've refactored the masking of CSRF tokens (related to the BREACH) vulnerability class.

Use Security::randomBytes, even if such strong randomness is not needed, it does not hurt and makes the code easier to read.
Introduced separate masking and unmasking functions that take care of masking and url encoding. Note that the unmasked token is never url encoded.
Have added tests for the masking.

OK but that looks like totally unrelated. Would be great if it could be separated.

Yes I'll make a separate PR for that, it caused this PR to fail though, due to failing tests.

#13837

I've refactored the changes, will merge master back into this after #13837 is merged.
--> This might need to be squashed before merging 8-)

This is ready!

@cebe I've updated the tests as well and have updated the getRemoteHost() documentation to reflect it's actual functionality.
So now you have:
getUserIP() --> get the users' IP.
getRemoteIP() --> get the next hop IP.
getRemoteHost() --> get the next hop host.
We do not have
getUserHost() --> it requires a DNS lookup.
Note that by default:
Apache does not provide REMOTE_HOST (https://httpd.apache.org/docs/2.4/mod/core.html#hostnamelookups)
Nginx doesn't provide it at all, as far as I can tell.

What happened to automated tests?
FYI: I've run the tests in RequestTest locally but not the whole suit.

Tests seems to be skipped if branch isn't up to date. Merged it w/ master and it seems to fix it.

Tests seems to pass.

For the purpose of introducing this without BC break and without introducing security issues:
Current behavior of Request class is the following:

userIP: taken from $_SERVER['REMOTE_ADDR'] currently, no header involved.
userHost: taken from $_SERVER['REMOTE_HOST'] currently, no header involved.
isSecureConnection: Yii currently trusts the X-Forwarded-Proto header.

The default config in current state of this PR, will automatically trust X-Forwarded-For to retrieve the user IP. This should not be the default as it will make applications that rely on IP address for access checks insecure after updating Yii.
Also the filterHeaders implementation currently allows returning an empty list of headers when a host does not match any trustedHostConfig entry. I see no use case for this as it would result in very weird behavior of the application, which uses e.g. Host:, X-Requested-With: for ajax detection, User-Agent, etc. I do not think there is a reason to block these, at least on in terms of a "trusted proxy feature".
I'm going to propose some changes in a PR.

@cebe Feel free to directly commit to my PR branch; I think you have write permissions there automatically.

@cebe Feel free to directly commit to my PR branch; I think you have write permissions there automatically.

done. @SamMousa @yiisoft/core-developers please review the current state.

Is anymore needed for this PR?

@SamMousa these two questions:

https://github.com/yiisoft/yii2/pull/13780/files#r125862700
https://github.com/yiisoft/yii2/pull/13780/files#r125259774

Also the separate issues are to be created since when this one will be closed comments will be forgotten soon.

@samdark Have added this to my todo list; it might take me a while to get to it though; I'm swamped at the moment :(

What about breaking on 1st match in filterHeaders()?

@samdark I think I've handled all feedback, or replied in the comments. (@cebe requested changes to the docs but marked htem in the source code so github disagrees)

Merged. Thank you very much for it and for being patient addressing our comments.


Handle zero count aggregation buckets

Don't merge – needs wellcometrust/catalogue#391 to be deployed
When the above PR makes it into the API, we will see all workType filters in the dropdown, even when they have an aggregation count of 0.
This PR will hide those zero-count filters unless they have already been selected.

@davidpmccormick @gestchild the API has been deployed
e.g.
https://api.wellcomecollection.org/catalogue/v2/works?aggregations=workType&query=simple


Illegal invocation

I just discovered that Vercel is injecting the package @nuxt/web-vitals into my Nuxt app, for speed insights:

Their speed insight stats are great, but I get a lot of "Illegal invocation" errors as a result of this dependency:
TypeError: Illegal invocation
  at send(../../../node_modules/.pnpm/@nuxtjs+web-vitals@0.2.6/node_modules/@nuxtjs/web-vitals/dist/runtime/utils.mjs:29:15)
  at sendToAnalytics(../../../node_modules/.pnpm/@nuxtjs+web-vitals@0.2.6/node_modules/@nuxtjs/web-vitals/dist/runtime/providers/vercel.mjs:19:3)
  at e(../../../node_modules/.pnpm/@nuxtjs+web-vitals@0.2.6/node_modules/@nuxtjs/web-vitals/dist/runtime/web-vitals.mjs:10:25)
  at r(../../../node_modules/.pnpm/web-vitals@3.5.0/node_modules/web-vitals/dist/web-vitals.js:1:1114)
  at <anonymous>(../../../node_modules/.pnpm/web-vitals@3.5.0/node_modules/web-vitals/dist/web-vitals.js:1:6764)
  at sentryWrapped(../../../node_modules/.pnpm/@sentry+browser@7.85.0/node_modules/@sentry/browser/esm/helpers.js:90:17)

Any idea how to solve this?
Not sure if this is a bug in this module or on Vercel's side. I also posted it here, to be sure: https://github.com/orgs/vercel/discussions/5105

Seems like it was fixed by Vercel.


Are you planning to support focus-detr in mmdetection 3.x and when?

https://github.com/IDEA-Research/detrex/tree/main/projects/focus_detr has the implementation of focus-detr in detrex(based on detectron2). Are you planning to support it in mmdet3.x and when?

@Artificial-Inability Hello, we don't have plans to support it at the moment, but we welcome the community to submit pull requests (PRs).


Added a project that allows building an iOS Framework

I've added an xcproject that builds a framework. This would mean this project supports Carthage via a rule:
github "mokagio/UICollectionViewLeftAlignedLayout" "869bf3b04a0f250cfd6e66752a10cc887cf04717"

Or, once you tag post merge, just this:
github "mokagio/UICollectionViewLeftAlignedLayout"

FWIW, I'd love to see this merged. I'm currently using @SandyChapman's fork.

Thanks a lot @SandyChapman for your work on this. Sorry it took me so long to get onto merging it.
Cheers 🍻


CI issues due to fetch_openml of iris

There still are occasional CI errors due to failing to fetch Iris dataset from OpenML (https://github.com/ramp-data/iris/issues/1). It's transient so restaring the CI later usually fixes it.
Related to https://github.com/openml/OpenML/issues/1092
The error message is also very confusing as it would show,
                raise CalledProcessError(retcode, process.args,
>                                        output=stdout, stderr=stderr)
E               subprocess.CalledProcessError: Command '['python', 'prepare_data.py']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

database_connection = None

    @pytest.fixture
    def session_toy(database_connection):
        database_config = read_config(database_config_template())
        ramp_config = ramp_config_template()
        try:
            deployment_dir = create_toy_db(database_config, ramp_config)
            with session_scope(database_config['sqlalchemy']) as session:
                yield session
        finally:
>           shutil.rmtree(deployment_dir, ignore_errors=True)
E           UnboundLocalError: local variable 'deployment_dir' referenced before assignment
/home/runner/work/ramp-board/ramp-board/ramp-engine/ramp_engine/tests/test_dispatcher.py:39: UnboundLocalError
---------------------------- Captured stderr setup -----------------------------
Traceback (most recent call last):
  File "/usr/share/miniconda/envs/testenv/lib/python3.6/site-packages/sklearn/datasets/_openml.py", line 414, in _get_data_info_by_name
    url, error_message=None, data_home=data_home
  File "/usr/share/miniconda/envs/testenv/lib/python3.6/site-packages/sklearn/datasets/_openml.py", line 179, in _get_json_content_from_openml_api
    raise OpenMLError(error_message)
sklearn.datasets._openml.OpenMLError: None
 During handling of the above exception, another exception occurred:
[...]
    raise OpenMLError(error_message)
sklearn.datasets._openml.OpenMLError: Dataset iris with version 1 not found.

So there is a second bug in pytest fixtures about deployment_dir badly handled when create_toy_db fails but that's not too critical.

switch to sklearn load_iris?


Move diff_drive_controller to ResourceManager

Do the migration we did on #99, #112 , #109.

Resolved by #128

Resolved by #128


Added a test for trackback location

Added a simple test for Trackback location

You didn't ask for my review, but... for the record... I like it!  Removing import of JDK internal packages, refactoring out logic into a shared function, and adding tests for somewhat obscure (but important) features... it's all good!

Your review is always welcome and appreciated, @cmoesel !


[NLJ] implementation layout

add comments for existing many to one join logic
add TODOs for code change to support NLJ
add query context fields needed for NLJ
compiler changes for matching many to many joins

Let's have some discussion first


Custom errors are more gas efficient than using require

This PR tackles clarity on why the function reverted instead of a generic require failure.
Issue #26 relates to this PR.

Looks good, I like this better than comparing a boolean with a boolean (thing == false).

Updated to fit with the new code updates @skyn3t2030


Add normal mappings for closing tabs

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
It is not currently possible to directly close tabpages with a normal map. You have to use the :tabclose/:tabonly ex commands. As a heavy tabpage user, this feels suboptimal, especially when compared with the abundance of normal maps for manipulating windows beneath <C-w>.
Describe the solution you'd like

Introduce normal map [count]<C-w>C/<C-w>[count]C as a shortcut for :[count]tabclose. E.g.:

<C-w>C closes the current tabpage.
3<C-w>C or equivalently <C-w>3C closes tabpage 3.

Introduce normal map [count]<C-w>O/<C-w>[count]O as a shortcut for :[count]tabonly. E.g.

<C-w>O closes all tabpages except for the one currently visible.
3<C-w>O or equivalently <C-w>3O closes all tabpages except for tabpage 3.

Why?

They feel consistent enough with the existing <C-w> estate to be defaults. <C-w>C and <C-w>O are to tabs as <C-w>c and <C-w>o are to windows.
:[count]close is mapped to [count]<C-w>c/<C-w>[count]c already. Similarly, :[count]only is mapped to [count]<C-w>o/<C-w>[count]o. It makes sense to have analogues for tabpages too.

Describe alternatives you've considered
I've been using these maps in my config for years:
nnoremap <silent> <C-w>C :<C-u>exe (v:count ? v:count : '') . 'tabclose'<cr>
nnoremap <silent> <C-w>O :<C-u>exe (v:count ? v:count : '') . 'tabonly'<cr>

These work well, but are limited in one small way: you can only specify the count before the <C-w>, not after, which is subtly inconsistent with the rest of the <C-w> estate.
Additional context

I'm unable to find any plugins that map <C-w>O/<C-w>C.
tpope/vim-fugitive, a popular community plugin, uses o for opening a fugitive objects in a new split and O for opening them in a new tab. Perhaps there is a soft convention here: maps with lowercase letters should act upon windows and maps with uppercase letters tabs. <C-w>T somewhat reinforces this.

... if this sounds reasonable, I'm very happy to implement.

I think <C-w>c is better to run :close. :)


Insistences between Spec and manifest/yaml Validation

Summary
I've been reading the spec, and noticed within the SLO type, the docs say timeWindow is optional. This is echoed in the OpenAPI spec.

However, oslo has the field as required within the manifest.
I'm happy to fix this, however I don't know which should be considered as correct. Any guidance?
PS, have we ever thought of OpenAPI to Golang Generators so updating the OpenAPI spec would automatically update the Go structs?

Hey @nieomylnieja,
I have taken some time to define in openapi (https://github.com/thisisibrahimd/openslo/blob/feature/add-budget-adjustment-spec/schemas/v1/schema.yaml) and generated gocode with openapi-generator with custom configs at https://github.com/thisisibrahimd/openslo-go.
Please let me know if this is helpful.


Bug 1765086: add registry-proxy support, bump bundle-lib

Coverage remained the same at 40.97% when pulling 225b4d992b03e8eebdfb28d05b23ca27b3e74356 on bz1765086-fix-registry-proxy into 7d5015c7a5ad278baa47dc8bacbf05eb5612dd56 on release-4.1.

closed won't fix


Support decrypting API keys encrypted with an encryption context

What does this PR do?
When decrypting the API key using KMS, try first with the encryption context added by the Lambda console UI, then try without.
Motivation
The Lambda console UI changed the way it encrypts environment variables. The current behavior is to encrypt environment variables using the function name as an encryption context. Previously, the behavior was to encrypt environment variables without an encryption context. The Lambda Extension currently only supports API keys encrypted using the previous behavior. We need to support both, as supplying the incorrect encryption context will cause decryption to fail.
Testing Guidelines
I added unit test coverage for this function and tested manually.
Types of changes

[x] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

[x] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[x] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog

Codecov Report

Merging #77 (3972bbd) into main (836741a) will increase coverage by 1.38%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   81.32%   82.71%   +1.38%
==========================================
  Files          12       12
  Lines         632      642      +10
==========================================
+ Hits          514      531      +17
+ Misses         96       87       -9
- Partials       22       24       +2

Impacted Files
Coverage Δ

ddlambda.go
80.28% <ø> (ø)

internal/metrics/api.go
88.67% <ø> (ø)

internal/metrics/batcher.go
100.00% <ø> (ø)

internal/metrics/context.go
100.00% <ø> (ø)

internal/metrics/listener.go
74.41% <ø> (ø)

internal/metrics/model.go
90.90% <ø> (ø)

internal/metrics/processor.go
100.00% <ø> (+2.56%)
:arrow_up:

internal/metrics/time.go
66.66% <ø> (ø)

internal/trace/context.go
75.00% <ø> (ø)

internal/trace/listener.go
59.61% <ø> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836741a...3972bbd. Read the comment docs.


ts-ebml plugin: add support for v3.x

coverage: 71.152%. remained the same
when pulling d259fb5a655d46cd8089b4244c5e983291fb5227 on ts-ebml-3
into 3795a2aa2da1c9d266717a9a7d31333d31dfbe81 on master.


fix(plugin/cors): Update plugin schema and docs

Summary

In the example, none of the origins urls have double quotes .
In the Configuration page, it says  If you want to allow all origins, add * as a single value.
Which makes people think that you only need to set * without double quotes as in the example
But in fact, it will cause kong to fail to start with an error of error parsing declarative config file" /tmp/home/kong/kong.yml
The correct origin should be "*" as shown in the image.
  config:
    origins:
      - "*"

Checklist

[ ] The Pull Request has tests
[ ] There's an entry in the CHANGELOG
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog
update cros plugins shema and docs

[Implement ...]

Issue reference

Fix #[issue number]

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

hi @chronolaw
Can you help review this PR  at your convenience ?

When you use declarative config, * must be enclosed in quotes because * is a special character in YAML Spec and must be enclosed in quotes. There are other special characters like this: {, }, [, ], &, *, #, ?, |, -, <, >, =, !, %, @, : also ` and ,
In traditional mode, it is not necessary to enclose the configuration in quotes when using curl:
curl -X POST http://localhost:8001/plugins \
    --data "name=cors"  \
    --data "config.origins=*"


LSUN download Data

Added the function to download LSUN data from the site, extract it and then delete zip file

Closes #2746. @AniTho I'll review in 1-2 days.

Closing this since it is stale and the prototype version of LSUN in #5390 includes downloads.


[AutoPR securityinsight/resource-manager] Creating first and basic sw…

…agger for new RP of ASI (Azure Security In… (#4142)

Generated from 36aca1e97fc2907ffb6ddb2be9d32781c6d1cea0

Change the location of the readme files

Packaging update of azure-mgmt-securityinsight

(message created by the CI based on PR content)


Add issue title here

File: tests/unit/context_retriever/test_context_handler.py
FIXME - This can't be a good pattern, let's cleanup later.

Automatabot test


goodvibes: add glib-networking for TLS support

glib-networking is needed to connect to https streams when using libsoup. without this change stations that require https fail with the error Failed to download playlist (6): TLS/SSL support not available; install glib-networking. after the change streaming https works as expected.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

cc maintainer: @zendo

thanks!


feat(kubernetes): switch to monthly billing

show node billing type and provide an option to switch node billing type to monthly
Closes #MBP-354

@antleblanc  thanks for you comment. I have removed all files in packages/manager/modules/kubernetes/

@antleblanc @marie-j  can you please review this

Hello @radireddy,
Your pull request is now closed due to inactivity.
Feel free to re-open it if you have any update.
Anna Bot for OVH UX <3


Update rest of the proto files

Description of your changes:

Update pipeline_spec.proto
Update job.proto
Update experiment.proto
Remove parameter.proto
Remove resource_reference.proto

This is updated from #6.
Checklist:

[ ] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

Not all comments from https://github.com/difince/pipelines/pull/6 were addressed in this change, could you take a look at the reviews in the previous PR and apply them here as well? thanks!

Hey @Linchin do you have time to look at this? If not, Diana and I are happy to take over and work on the rest of the changes to move this forward. We hope to start moving this forward again


Update Url class to common syntax

looks like query should be called url search params.
The complete url spec

I guess the query string is also called the query string:

A URL’s query is either null or an ASCII string. It is initially null.

So I guess it is called URLSearchParams when parsed, and query when a string attached to the full url

Also, I want to make sure query strings are parsed and built correctly, so:
foo[bar][0][che]=happy

would convert to:
foo = {
  bar: [
    {
      che: happy
    }
  ]
}

and likewise, if you passed that dict into the url builder it would convert back to foo[bar][0][che]=happy

I think query_params for the parsed query of the Url is pretty good. That's what I changed dsnparse's parsed query string to. RFC3986 section 3.4 doesn't give a good name for the actual assignment statements of each part of the query

Postgres calls the query part paramspec


Simplify public interface.

This is what you need to do to set up a single animation.
public static readonly Config Config = new Config
{
	MetadataEnabled = true,
	EventsEnabled = true,
	PoolingEnabled = true,
	TagsEnabled = true,
	VarsEnabled = true,
	SoundsEnabled = false
};
DefaultProviderFactory<ISprite, SoundEffect> factory = new DefaultProviderFactory<ISprite, SoundEffect>(Constants.Config, true);

Stack<SpriteDrawInfo> drawInfoPool = new Stack<SpriteDrawInfo>();

SpriterContentLoader loader = new SpriterContentLoader(Content, scmlPath);
loader.Fill(factory);
foreach (var entity in loader.Spriter.Entities)
{
	var animator = new MonoGameAnimator(entity, factory, drawInfoPool);
	animators.Add(animator);
}

This is horribly overcomplicated. Ideally, it should look roughly like this:
var template = new SpriterAnimatorTemplate(Content, scmlPath);
var animator = template.MakeAnimator();

Additional configs could be moved away to a separate controller class.

Not really. You can do something as simple as:
            var factory = new DefaultProviderFactory<ISprite, SoundEffect>(new Config());
            SpriterContentLoader loader = new SpriterContentLoader(Content, scmlPath);
            loader.Fill(factory);
            var animator = new MonoGameAnimator(loader.Spriter.Entities.First(), factory);

My version is twice as simple, tho. : - )
Also this way you'll create a separate pool for every single animation, which is a waste. n fact, I don't understand why you even need to expose the pool and pass it separately. You can just make is a private static field.

I agree, it is twice as simple.
I exposed the pool because:

I like giving the user as much control as possible
Using the pool for other parts of the game
Multithreading support - in case things are animated in different threads. This COULD be done as some kind of per-thread static pool, but still, I prefer to leave it to the user

As I mention for other things as well, version 2 SHOULD handle all of this better, without really the need for pooling in the first place.


fix: calculate positions for elements inside iframes correctly

Fixes #28
When cy.realClick() or cy.realHover() are called on elements that are inside of an iframe within the Cypress app's own iframe, the position calculated for the element doesn't account for the possible offset position of its containing iframe.

I cannot merge PRs without tests. If you want this to be merged please add some tests or wait – I will add some tests myself

I have an update with tests I'll push up here soon, just gotta polish it up a bit.
I don't think it covers elements that are being transformed themselves (transform applied to the target element or one of its containers, as opposed to a transform on the <iframe> itself), but I don't think the library covers that case before this PR anyway. I'd prefer to leave that out of this PR and report it as a separate issue

Just pushed up a commit fixing the failing test and rebasing on develop.
Sorry about that, I recently changed some git defaults to not index untracked files by default. I typically work in a very large repo and that change speeds up all my git commands. Still haven't acclimated to it yet, so I keep forgetting to manually add untracked files to my commits.
Let me know what you think of the approach I went with (or take the PR over if you'd prefer), i added some HTML files to test the iframe behavior against.

I'm still getting a failure on the swipe test, for the toTop test. It only fails when run in CI mode, it passes fine with cypress open. @dmtrKovalenko would you be able to look into that for me?

Hey, just checking in here. I haven't had time to come back to this, but I'm hoping to put some more time in this upcoming weekend to see if I can figure out why the build is failing (and to respond to the outstanding comments)

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Just checked in on this and saw it was merged - thanks for taking this over, gonna upgrade in our app today 😃


Improve LinuxLiveDataReader

Removes this to conform to current styles. Personally I would prefer to prefix everything with this.

Looks good to me.  I haven't tested this yet and since it's touching (a little) of the gcroot code I'm about to move I'm going to go ahead and merge it.  Since it's going into the 'testing' branch it'll get tested later as a whole when I'm wrapping up this sprint of changes.  Thanks!


Nested queries got laggy on UI

Hi, I previously consulted a way to query data nested, it works like a charm!
This is the code:
 Stream<List<DbMessageWithDbContactOrRoomMember>>
      getMessagesWithRoomMemberByRoomId(String roomId,
          {int perPage = 25, int pageNum = 0}) {
    debugPrint("[dao] roomid: $roomId, perPage: $perPage, pageNum: $pageNum");
    final outerMessages = alias(messages, 'm');
    final replies = alias(messages, 'i');
    final selectReplies = selectOnly(replies)
      ..addColumns([
        FunctionCallExpression('json_group_array', [replies.id])
      ])
      ..where(replies.originalId.equalsExp(outerMessages.id));
    final replyIds = subqueryExpression<String>(selectReplies);
    final query = select(outerMessages).join([
      leftOuterJoin(
          roomMember,
          roomMember.id.equalsExp(outerMessages.fromId) &
              roomMember.roomId.equalsExp(outerMessages.roomId))
    ])
      // ..limit(perPage, offset: pageNum * perPage)
      ..limit((pageNum + 1) * perPage, offset: 0)
      ..addColumns([replyIds])
      ..where(outerMessages.roomId.equals(roomId))
      ..orderBy([
        OrderingTerm(
            expression: outerMessages.sendTime, mode: OrderingMode.desc)
      ]);
    return query.watch().map((rows) {
      final messageById = {
        for (final row in rows)
          row.read(outerMessages.id)!: row.readTable(outerMessages),
      };

      return rows.map((row) {
        final id = row.read(outerMessages.id)!;
        DbMessage dbMessage = messageById[id]!;
        final original = switch (dbMessage.originalId) {
          null => null,
          var id => messageById[id],
        };
        final childIds =
            (json.decode(row.read(replyIds)!) as List).cast<String>();
        DbMessageExtra dbMessageExtra = DbMessageExtra.fromDbMessage(
          dbMessage,
          // originalityMessage: null, repliedMessages: null
          originalityMessage: original != null
              ? DbMessageExtra.fromDbMessage(original!,
                  repliedMessages: null, originalityMessage: null)
              : null,
          repliedMessages: [
            for (final childId in childIds)
              if (messageById.containsKey(childId))
                DbMessageExtra.fromDbMessage(messageById[childId]!,
                    repliedMessages: null, originalityMessage: null)
          ],
        );
        // print(dbMessageExtra);
        return DbMessageWithDbContactOrRoomMember(
          dbMessageExtra,
          roomMember: row.readTableOrNull(roomMember),
        );
      }).toList();
    });
  }

I can get the messages and originality message and replied messsages of it.
But now, I found every time a data updated, the whole things got laggy.
This is out of my scope, actually, am using Stream as you can see, it shoudldnt effect much since it async,
but the result is my UI got laggy every time new message comes in, and everytime I sned a message ,
Can u help me why it got stuck?

How many messages are there? Is there an index on the room or on messages.originalId (there should be one if you're using foreign key constraints and have the foreign key pragma enabled)?
How are you opening the database, are you using NativeDatabase.createInBackground?

@simolus3  The laggy I didn't occured previous or not very severe, but recently, when I did something :
I using RxList to contains mssages (with GetX), then for every get have messages.bindStream() operation
Is that possible the issue to cause laggy? It looks like will subscribe streams again and again.
Also, the messages here are 32 max for one batch, and maybe 64 for 2 batch, not too much.

then for every get have messages.bindStream() operation

I wasn't aware of RxList before, which package is providing messages.bindStream() or what is that doing?

It looks like will subscribe streams again and again.

Drift is kind of optimized for this since the StreamBuilder widget can cause similar things. If you cancel a subscription and then re-subscribe to it reasonably quickly (one event loop iteration between those, we cancel streams after one Timer.run iteration), the query should not be run again.

It's GetX, widely used, it provides a way to do stream like behavior but simpler, RxList a can a.bindSream to make it use streams return by drift.
Since GetX so widely used, am just wonder the reason, why I using a.bindStream in every time get data from sql and stream to UI got laggy.
One possible reasons is that, when I get data from sql and bindStream, if there is a sql update, and then same time updating UI (since it's stream), it might got some kind of race trace problem

Are you calling close() on the rx objects after you don't need them anymore? If you have thousands of "different" streams in drift (different SQL or different parameters), the lag would be unavoidable. It looks like there is no way to unsubscribe from a stream after passing it to bindStream without closing the rx object.

One possible reasons is that, when I get data from sql and bindStream

Why do you call bindStream every time? Do you have a way to use switchMap to combine multiple streams into one if you don't need all of them at once?

@simolus3 I didn't called close() anywhere, since this is a APP lifecycle object to be called.
but the bindStream might called many times eveytime I enter the page, it will be called in initState func.
Where could I close the stream on UI? dispose or somwhere? Does bindStream many times will casued UI laggy?

dispose or somwhere? Does bindStream many times will casued UI laggy?

It looks like there is no way to cancel a stream passed to bindStream, so yeah - from a quick look it appears as that method inherently leaks resources.
But let's merge this discussion into https://github.com/simolus3/drift/issues/2807, which appears to be about the same problem.


Extending inner class from named class generates Parse Error: Could not determine inheritance

Godot version: 3.1.beta.custom_build.f7d2750

OS/device including version: Ubuntu 16.04 64bit

Issue description: I have a script which extends Node that has an inner class and that inner class also extends Node. It works fine but it crashes the editor when I close and reopen the project.

Steps to reproduce: Comment out the inner class of ParentAndChild.gd and the project opens fine. Uncomment it again in the editor, run the scene and it works as expected. Close and reopen the project and it will crash.

handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x354b0) [0x7f86ce0764b0] (??:0)
[2] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x2468012] (/home/oreo/Apps/Godot/godot/./core/string_db.h:125)
[3] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x5771d0] (/home/oreo/Apps/Godot/godot/modules/gdscript/gdscript_parser.cpp:5173 (discriminator 1))
[4] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x5adeeb] (/home/oreo/Apps/Godot/godot/modules/gdscript/gdscript_parser.cpp:8100)
[5] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x5ae7e4] (/home/oreo/Apps/Godot/godot/modules/gdscript/gdscript_parser.cpp:8189)
[6] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x4da019] (/home/oreo/Apps/Godot/godot/modules/gdscript/gdscript.cpp:575)
[7] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x4dbcf0] (/home/oreo/Apps/Godot/godot/modules/gdscript/gdscript.cpp:2146)
[8] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x26612a4] (/home/oreo/Apps/Godot/godot/./core/cowdata.h:369)
[9] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x26617eb] (/home/oreo/Apps/Godot/godot/./core/reference.h:260)
[10] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x121c6f6] (/home/oreo/Apps/Godot/godot/editor/plugins/script_editor_plugin.cpp:2480 (discriminator 2))
[11] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x121d0f0] (/home/oreo/Apps/Godot/godot/./core/reference.h:267)
[12] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0xd0829f] (/home/oreo/Apps/Godot/godot/./core/reference.h:267)
[13] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0xdbf888] (/home/oreo/Apps/Godot/godot/./core/reference.h:285)
[14] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0xdc8c10] (/home/oreo/Apps/Godot/godot/editor/editor_node.cpp:308)
[15] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x2451424] (/home/oreo/Apps/Godot/godot/core/object.cpp:957)
[16] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x15c4f5b] (/home/oreo/Apps/Godot/godot/scene/main/node.cpp:184)
[17] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x15c4ec5] (/home/oreo/Apps/Godot/godot/./core/cowdata.h:70 (discriminator 3))
[18] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x15d7b01] (/home/oreo/Apps/Godot/godot/scene/main/node.cpp:2523)
[19] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x1606388] (/home/oreo/Apps/Godot/godot/scene/main/scene_tree.cpp:457)
[20] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x427c50] (/home/oreo/Apps/Godot/godot/platform/x11/os_x11.cpp:2973)
[21] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64(main+0xdf) [0x41902f] (/home/oreo/Apps/Godot/godot/platform/x11/godot_x11.cpp:55)
[22] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7f86ce061830] (??:0)
[23] /home/oreo/Apps/Godot/godot/bin/godot.x11.opt.tools.64() [0x41aee9] (??:?)
-- END OF BACKTRACE --

Minimal reproduction project:
Test.zip

Still same result as in the above comment. Since it's not crashing and the scripts seem functional, I'll move it to the next milestone. The error should still be investigated.

This seems fixed in 3.4.4-stable.


Added Documentation for Azure Remote

Closes #5151
Integrated documentation for azure remote in user-guide/data-management/remote-storage/azure-blob-storage .

@shcheklein I've made the changes. Could you please review them?

@aayushk9 thanks, I've put a comment to do the next step here!

@shcheklein Thank you for your feedback. I've made the changes, please let me know if there are any further edits needed.

@shcheklein Have a look :)

@shcheklein I've added the missing descriptions.

Hey @shcheklein, thanks for pointing out those changes. I have included the requested modifications and please let me know if any further changes are needed.

thanks @aayushk9 , I've fixed it a bit and it's ready to merged!


Update to Go 1.19

Update to Go 1.19.
Note that Go 1.19 has x509 verification changes that will require MSP updates.

@yacovm @C0rWin Could you comment on the latest thoughts around the MSP updates for Go 1.19? Are you hopeful this can be completed for a v2.5 LTS release around end of year?

I cannot comment before I get time to investigate thoroughly, and in any case we should let @adecaro and @ale-linux  take a look at it, before even discussing timelines.

PR for MSP updates being worked in PR https://github.com/hyperledger/fabric/pull/3774 by @C0rWin

@denyeart, is there any plan to review and take action wrt #3774? Golang 1.20 is going to be released soon. However, we still need to move Fabric to 1.19 first, and we cannot, which seems a little bit pitty.

@C0rWin Initially we were waiting for Angelo or Ale to approve https://github.com/hyperledger/fabric/pull/3774. But since the PR is in Draft state with failed checks I don't think anybody has looked at it. If you can make the PR green and out of Draft state I'll make sure it gets review. I agree we need to move to 1.19 soon.
PS The tests have been more flaky since moving to Github actions, we're working to improve those. In the interim as a maintainer you can click into any failures and re-run them to make it green.


Script to check for tasks completion.

For use during transition to finals to ensure all compiles and games have completed.

Depends on the method in PR #400 being used to stop game tasks.

see comment on #400


Openjdk pin make

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Builds succeed.
/nix/store/ywi1rap9k6ia26q3paxf2shpi7i0rxsn-openjdk-19.0.2+7
/nix/store/z7pq8m9h7dk1zbwvk834camp13zx2anx-openjdk-17.0.6+10
/nix/store/dz0w4bh6fwrpys46agw1b4x54ykfihxc-openjdk-11.0.18+10


Media

This issue is a no-op; it is used to store images/media for the project.

https://user-images.githubusercontent.com/87919558/209453564-ba8a84a2-26bf-498a-8cd1-55bef03bc0e1.mov

https://user-images.githubusercontent.com/87919558/209453569-42e61e51-e0a1-4934-bdea-18d465d41ca6.mov