CJM-45417-globalDecisionContext

Setting global decisionContext with data like current date/time, date…/time page loaded, browser name/version, scroll position, etc

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[X] I have made any necessary test changes and all tests pass.
[X] I have run the Sandbox successfully.

One other comment, when implementing the values within page and referringPage, please do so without adding any additional dependencies.  Let me know if there are some values that can't be determined easily with code or browser apis.  If i recall correctly, @ericfichtel did some work for parsing urls into parts and it was different for node vs at.js in order to keep the library size small.

I wonder if there is a way we could be lazy about generating the context. I imagine there are many rules that won't use these properties, but we have to calculate them every time. Perhaps using getters or by changing the API so that when a context variable is requested we can calculate it on the fly.

We compute things like the browser name, page, and referringPage context only once during the initialization of the context provider. The computed values are stored in coreGlobalContext and reused for subsequent getContext calls.
Additionally, the window context is updated on each getContext call to utilize the most recent window size and scroll positions. Similarly, the time context is also updated on each getContext call to provide accurate information such as pageVisitDuration and currentDay.

In DecisioningEngine/index.js the renderDecisions command needs to have it's context flattened as well.
commands: {
      renderDecisions: {
        run: decisionContext =>
          applyResponse({
            propositions: decisionProvider.evaluate(
              flattenObject(contextProvider.getContext(decisionContext))
            )
          })
      }
    }


fix: revocation reponse status code should be 200

Corresponding spec change: https://github.com/notaryproject/specifications/pull/319

The CI failed, looks like this PR is waiting for #238 to be merged.


Environment#current() is deprecated. What is replacement?

The Environment#current() is deprecated. What is replacement or if replacement missing how we can get Environment in places where it not passed as parameter.

There are two variants:

Pass as parameter
Keep a reference to an env object somewhere in your objects.

Environment#current() uses ThreadLocal to keep an env object, but it's not correct behaviour in some cases. If you are using concurrent environments for multitheareading you need only one environement object and you can create as many env objects not attached to threads.

I see, very thanks. I was thinking there is a short easy way, but it's not documented. I think we should talk about this in concrete examples. Let's discuss this around the code. I've open a PR soon.


The attribute name is set to the invalid value

Bug Description
the attribute name is set to the invalid value
Expected Behaviour
AMP Validation Error
Steps to Reproduce
See a screenshot below
Screenshots

Additional Context

Plugin Version:1.0.0-rc.1
Operating System: macOS
Browser:Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Hi @netnaps, thanks for your report!
This is already known and will be resolved in the upcoming 2.0.2 of the AMP WordPress plugin. It should be released today or tomorrow, so stay tuned! Or better yet: enable automatic updates so you don't have to do that manually 🙂

Thanks @swissspidy this works now just checked as always you have been very helpful.


Update README.md

There aren't much obvious issues seem to be left. A patch release with the latest PRs merged would be nice, no need to hurry though.

@ahmetsait  Agreed, you have really done a great job cleaning up and adding some features, so thank you for the excellent work.  The only remaining feedback I know of is in the Discussions around providing a custom folder location for the native libraries and then a signed version.


Delegate to foam.util when cloning property values that do not…

… implement clone()

@jingt06 FYI. @jacksonic PTAL @ tests. This change seems right, but it introduces a couple failures in index-related tests.
The particular issue @jingt06 found was that GROUP_BY's use of someSink.clone() did not clone the array in an ArraySink to get properly separated groups. We could, instead have foam.core.Array implement cloneProperty, but I think that, in general, we want foam.util.clone() to be a reasonable implementation for property values.


drupal_theme_rebuild() is deprecated

https://www.drupal.org/node/3348853
Introduced in branch/version: 10.1.x / 10.1.0
Use \Drupal::service('theme.registry')->reset() instead

MR created.


CTKFlagPhoneNumberTextField's  init?(coder aDecoder: NSCoder) not implemented.

Is there any reason to not do something like this:?
    required public init?(coder aDecoder: NSCoder) {
            super.init(coder: aDecoder)
            setup()
    }

Right now due to current implementation it is impossible to create CTKFlagPhoneNumberTextField in .xib file or storyboard. If there are no reasons to disallow creation from xibs it would be awesome to implement initWithCoder.

Hi,
Thanks you for your suggestion. I will add initWithCoder today ;)

@grifas Thanks, it would help a lot!

It's done !


Cold start perf regression after logical replication

this commit adds a few hundred milliseconds to startup time. To reproduce locally, run the test_startup_simple test. It's visible in metrics too
ty @bayandin for reporting
cc @knizhnik I'm not sure what's going on with basebackup and logical replication and if there's an easy fix. If there isn't an easy fix we can always cache the compressed basebackup.

"There's magic everywhere"
This is results of test_startup_simple at main:
test_startup_simple.0_start_and_select: 0.144 s
test_startup_simple.0_wait_for_spec: 2 ms
test_startup_simple.0_sync_safekeepers: 9 ms
test_startup_simple.0_sync_sk_check: 0 ms
test_startup_simple.0_basebackup: 23 ms
test_startup_simple.0_start_postgres: 21 ms
test_startup_simple.0_config: 0 ms
test_startup_simple.0_total_startup: 55 ms
test_startup_simple.1_start_and_select: 0.443 s
test_startup_simple.1_wait_for_spec: 2 ms
test_startup_simple.1_sync_safekeepers: 0 ms
test_startup_simple.1_sync_sk_check: 0 ms
test_startup_simple.1_basebackup: 369 ms
test_startup_simple.1_start_postgres: 27 ms
test_startup_simple.1_config: 0 ms
test_startup_simple.1_total_startup: 398 ms

Now change endpoint.rs wal_level from logical to replica and get:
test_startup_simple.0_start_and_select: 0.142 s
test_startup_simple.0_wait_for_spec: 2 ms
test_startup_simple.0_sync_safekeepers: 9 ms
test_startup_simple.0_sync_sk_check: 0 ms
test_startup_simple.0_basebackup: 22 ms
test_startup_simple.0_start_postgres: 20 ms
test_startup_simple.0_config: 0 ms
test_startup_simple.0_total_startup: 53 ms
test_startup_simple.1_start_and_select: 0.134 s
test_startup_simple.1_wait_for_spec: 2 ms
test_startup_simple.1_sync_safekeepers: 0 ms
test_startup_simple.1_sync_sk_check: 0 ms
test_startup_simple.1_basebackup: 34 ms
test_startup_simple.1_start_postgres: 21 ms
test_startup_simple.1_config: 0 ms
test_startup_simple.1_total_startup: 57 ms

So second restart time is almost 10x times slower. But not always... Sometimes (usually just after rebuild) times are much better (but still slower then with wal_level=replica):
test_startup_simple.0_start_and_select: 0.353 s
test_startup_simple.0_wait_for_spec: 3 ms
test_startup_simple.0_sync_safekeepers: 14 ms
test_startup_simple.0_sync_sk_check: 1 ms
test_startup_simple.0_basebackup: 29 ms
test_startup_simple.0_start_postgres: 24 ms
test_startup_simple.0_config: 0 ms
test_startup_simple.0_total_startup: 72 ms
test_startup_simple.1_start_and_select: 0.239 s
test_startup_simple.1_wait_for_spec: 2 ms
test_startup_simple.1_sync_safekeepers: 0 ms
test_startup_simple.1_sync_sk_check: 0 ms
test_startup_simple.1_basebackup: 118 ms
test_startup_simple.1_start_postgres: 22 ms
test_startup_simple.1_config: 0 ms
test_startup_simple.1_total_startup: 142 ms

And what we can see in PageserversList log - "fast run":
handle_basebackup_request{lsn=Some(0/150EDB8) prev_lsn=None full_backup=false}: basebackup complete lsn_await_millis=67 basebackup_millis=8

"slow run":
handle_basebackup_request{lsn=Some(0/150EDB8) prev_lsn=None full_backup=false}: basebackup complete lsn_await_millis=337 basebackup_millis=19

So most of the time is spent in waiting for LSN.
One of the possible explanation may be  that with wal_level=logical WAL takes more space and so need more time to replay.
But it is not true - you can see that basebackup LSN is the same in both cases.
With wal_level=replica lsn_await_millis is always 0 and so startup time is very stable.
I will continue investigation but may be somebody have some theory?

So most of the time is spent in waiting for LSN.

When I add a sleep(1) between the two runs it's fast, so this checks out. But idk why it would be slow on prod. We have more than 1 second between suspend and start usually.
Another interesting fact is that If I add:
        from fixtures.types import Lsn
        lsn = Lsn(endpoint.safe_psql("SELECT pg_current_wal_lsn()")[0][0])
        print("FFFFFFFFFFFFFFFFFFFFFFF", lsn)

before endpoint.stop() I see that lsn has moved forward the second time. That wasn't the case int the past.

Wild theory: We know that something moved the lsn at the same time as basebackup, so is it possible that even though we have the lsn we need, we get stuck on this lock for 100-500ms? I added some logging and saw 1215 calls to wait_lsn during this short test. Idk who's calling it so much.

I confirmed that adding sleep fix the problem with start-up slowdown.
Concerning "advanced LSN" - I suspected that it may be caused by save LR state (using logical messages).
I commented them out but it doesn't;t somehow affect startup time.

Ok, looks like I found the difference. It explains both LSN increment and wait for lsn delay.
initdb creates database with wal_level=replica. And then we change it to logical. It cause wal logging PARAMETER_CHANGE record. I already inestigated why this record was generated: see https://neondb.slack.com/archives/C03QLRH7PPD/p1697032959557879
There is no way to specify wal_level for initdb. So we should either use cached ((precreated) basebackup. Either come to terms with this extra hundred msec.

There is no way to specify wal_level for initdb. So we should either use cached ((precreated) basebackup. Either come to terms with this extra hundred msec.

Ok. Let's not come to terms with it. Makes a big difference. https://neondb.slack.com/archives/C04BT3XH8PL/p1698932105832869
I found that adding sleep(1) doesn't help if I also detach the tenant. So pageserver detaches fast enough to miss some wal. That explains why the problem exists in prod despite long sleep.
So we could cache the basebackup, or we should at least detach less forcefully in the common case, and wait until we catch up with safekeepers.

I still don't understand why it's so common in prod though. Looks like 30-80% of startups are impacted. In most cases there's enough time between suspend and start for this wal to be processed.

I am not able to reproduce the problem with the latest sources:
test_startup_simple.0_start_and_select: 0.136 s
test_startup_simple.0_wait_for_spec: 2 ms
test_startup_simple.0_sync_safekeepers: 9 ms
test_startup_simple.0_sync_sk_check: 0 ms
test_startup_simple.0_basebackup: 33 ms
test_startup_simple.0_start_postgres: 18 ms
test_startup_simple.0_config: 0 ms
test_startup_simple.0_total_startup: 63 ms
test_startup_simple.1_start_and_select: 0.122 s
test_startup_simple.1_wait_for_spec: 1 ms
test_startup_simple.1_sync_safekeepers: 0 ms
test_startup_simple.1_sync_sk_check: 0 ms
test_startup_simple.1_basebackup: 42 ms
test_startup_simple.1_start_postgres: 18 ms
test_startup_simple.1_config: 0 ms
test_startup_simple.1_total_startup: 62 ms


Unify resources for stable and them for head

Stable and head have their resources respectively, though the resources are completely same.
Both of resources have been upgraded same time according to commits or PRs, so having separated resources is nonsense at this moment.

Is it a problem to replace following dependencies with homebrew's one, additional to jemalloc?
libuv
msgpack
unibilium
libtermkey
libvterm

These replacement is proposed in #118 and #129, which seem to be inactive now.

Is it a problem to replace following dependencies with homebrew's one, additional to jemalloc?

It should be fine, though I hope those are reguarly updated to newer versions.

@jszakmeister Any objection to this? BTW do you know why -DUSE_BUNDLED_BUSTED=OFF was there? see https://github.com/neovim/homebrew-neovim/pull/195#discussion_r89353644

@jszakmeister Any objection to this? BTW do you know why -DUSE_BUNDLED_BUSTED=OFF was there? see #195 (comment)

It was added because we only use it for test purposes, and we don't do that as part of the recipe.  One less thing to install and worry about.  I believe it was Florian who did it (see #56).

And no, I don't have any objections to merging the resources... though they were separated at one point because HEAD and stable diverged.  So we're coming full circle here. :-)

Won't you merge this?

@equal-l2 reason for DUSE_BUNDLED_BUSTED was mentioned above. It needs to remain. A general guideline is: don't change things without knowing why.

@justinmk All right, I will revert DUSE_BUNDLED_BUSTED.

Merged based on @alyssais feedback.

I will make another PR to handle luajit and luarocks sometime soon.


Replica pipeline fixes

This doesn't quite work with GCC with empty input arrays, but I don't think that's a problem we need to solve right now.


Add back the default folder

Describe the feature
Add back the default folder components, assets, store, plugins, layouts as it was like before
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

Hello :wave: the new directory structure is enabled with the compatibilityV4 flag and will be default in Nuxt 4. If you wish to have the directory structure of Nuxt 3, you can take a look at the doc and change your nuxt config.


Set Up a Workflow With Extended Employee Onboarding

Tutorial URL: https://developers.sap.com/tutorials/cp-starter-ibpm-employeeonboarding-3-workflow.html
Labels :
Landscape Labels: trail1 & trail2
SCPTest-eboard: Automate and Extend Employee Onboarding
Priority label :‘High-prio’
Step 2: Import sample application
In Sub step 2 Give steps to create Dev space or provide a prerequisite step to create dev space. Workflow management extension should be included

Thanks for reporting this. The section have added to create or edit dev space in the tutorial.
@MichaelCzcz  - please close the ticket.


Date picker doesn't remember date in calendar when only one date is picked

Describe the bug
When using the date picker component and selecting a single date, it does not remember the date when the calendar is opened again.
Reproduction

If you go to the https://next.shadcn-svelte.com/docs/components/date-picker page, input one date in the Date Range Picker component, close the component and then open it again, it will not select the date in the calendar.
Logs
No response
System Info
Chromium (Arc Browser)

Severity
annoyance

Also on Chromium Arc but I am unable to reproduce.
https://github.com/user-attachments/assets/6851c387-a939-41bf-97f2-e84f1631bff8

Sorry should have been more clear, this only happens when one date is selected, if your video you always select two dates. Here is a video on my end:
https://github.com/user-attachments/assets/ba82f113-e7aa-44a5-8638-7932fbc4b83a

A range with a single date isn't a range, it's a single date. The value isn't committed until both a start and end date are selected.

That's fair! I can see if I can put a PR up that mimics Bit UI's date range picker functionality shown in the video below. Also, I am curious why yall use a Popover + Range Calendar over the Bits UI Date Range Picker.
https://github.com/user-attachments/assets/78e34597-93c3-49aa-a9c0-08c493aa783a


Failed to create storage account in sandbox (MSLearn)

This is autogenerated. Please review and update as needed.
Describe the bug
Failed to create storage account in MSLearn sandbox working on the following module:
https://docs.microsoft.com/de-de/learn/modules/store-app-data-with-azure-blob-storage/4-create-storage-resources
Command Name
az storage account create
Errors:
The command failed with an unexpected error. Here is the traceback:
[Errno 30] Read-only file system: '/home/julian/.azure/commands/2021-07-30.13-44-58.storage_account_create.292.log'
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 514, in execute
    load_cmd_tbl_func=self.commands_loader.load_command_table, args=args)
  File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 170, in raise_event
    func(self, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/azlogging.py", line 95, in init_command_file_logging
    self._init_command_logfile_handlers(metadata_logger, args)  # pylint: disable=protected-access
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/azlogging.py", line 115, in _init_command_logfile_handlers
    logfile_handler = logging.FileHandler(log_file_path, encoding=LOG_FILE_ENCODING)
  File "/opt/az/lib/python3.6/logging/__init__.py", line 1032, in __init__
    StreamHandler.__init__(self, self._open())
  File "/opt/az/lib/python3.6/logging/__init__.py", line 1061, in _open
    return open(self.baseFilename, self.mode, encoding=self.encoding)
OSError: [Errno 30] Read-only file system: '/home/julian/.azure/commands/2021-07-30.13-44-58.storage_account_create.292.log'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az storage account create
--kind StorageV2
--resource-group learn-526a56ab-210b-4a71-8539-9f9fe0959619
--location centralus
--name mslearnsajmo0815

Expected Behavior
Storage account to be created
Environment Summary
Linux-5.4.0-1055-azure-x86_64-with-debian-10.2 (Cloud Shell)
Python 3.6.10
Installer: DEB

azure-cli 2.26.0 *

Extensions:
ai-examples 0.2.5
ssh 0.1.5

Additional Context

storage


Fix Text Input Error Focus

This pull request is to fix the text input error focus on Light and Dark mode. The color of the focus while in an "error state" was inconsistent on light and dark mode, and, in my opinion, keeping the focus and border color the same (which is red in an error state) seemed to be the most logical solution.
These are all examples in an error state with focus.
Light Old Input Error Focus State:

Dark Old Input Error Focus State:

Light New Input Error Focus State:

Dark New Input Error Focus State:

Thanks


Tried everything, vcpkg works with CMake but paths fail in Visual Studio 2019 on correct config

Sorry to file another consecutive issue, but as the title says, vcpkg works with CMake but in VS2019, even with x64 and Debug correctly set, no include or lib paths are found.
Tell me if I slipped up on the steps:

vcpkg dir is C:\vcpkg
VCPKG_DEFAULT_TRIPLET set to x64-windows (VS2019 reflects this, too)
vcpkg install boost
vcpkg integrate install
CMake GUI, I have 'CMAKE_TOOLCHAIN_FILE' set to the vcpkg.cmake file path and yes, it does import the config options from it. Again, Boost's include dir is detected
Open in VS2019, config is set to Debug x64, tried to build, but it fails to find the Boost headers I used.

@Schala, I want to confirm the last step, do you open the project that generate by CMake in above steps via VS2019? How do you use boost in your project?
If use it with cmake, you need to add the following code in your CMakLists.txt file:
   find_package(Boost REQUIRED [COMPONENTS <libs>...])
   target_link_libraries(main PRIVATE ${Boost_LIBRARIES})
   target_include_directories(main PRIVATE ${Boost_INCLUDE_DIRS})

if use it with msbuild:
You only need to set configuration to Debug x64 by default.

I do. I open the .sln file, check that the config is x64 and Debug on "ALL_BUILD", and hit build. I currently only use Boost.Asio, a header-only component.

Alright, figured it out. I was missing the target_include_directories bit. I assumed since they were in my vcpkg include path that it was unnecessary.


make gcg output actual Host/Scheme used instead of gcg.sh

hi, sorry for the late response, i will be back with this project and check all of your PRs, really appreciate it


[flutter_localizations] re-generate localization command throws errors

Follow instructions from https://github.com/flutter/flutter/tree/master/packages/flutter_localizations#adding-a-new-string-to-localizations or directly execute the command below.

That's normal, it has to make a round trip inside Google to get translated via the last step

@guidezpl
That's interesting, appreciate the info. Agreed, it needs to be documented better.


Refs #32655 -- Improved error if iter_test_cases() is passed a string.

https://code.djangoproject.com/ticket/32655

@cjerdonek Thanks :+1: Is there anything left for this ticket? I'm asking because you used Refs... instead of Fixed... in your commit message.

Thanks, @felixxm. I just did that because there was also discussion of deprecating extra_tests on the ticket. Alternatively, it could be marked "Fixed" and a new ticket opened.

Yes, right. I still believe that we should deprecate it. Let's keep it as a Refs. Thanks :+1:

Let's keep it as a Refs

Okay, sure. Then maybe the ticket's title can be updated to reflect the expanded scope.

Then maybe the ticket's title can be updated to reflect the expanded scope.

Updated.

Great, thank you.


How to read client hello with boost::asio::ip::tcp::socket  ?

I am trying to simulate tls handshake for a https request over https_proxy
I have this code
#include <iostream>
#include <set>
#include <boost/asio.hpp>
#include <boost/beast/http.hpp>
#include <boost/process/async_pipe.hpp>
#include <boost/lexical_cast.hpp>
#include <boost/beast/core.hpp>
#include <boost/beast/version.hpp>
#include <boost/asio/connect.hpp>
#include <boost/asio/ip/tcp.hpp>

std::vector<boost::asio::const_buffer> toBuffers(std::string str) {
	std::vector<boost::asio::const_buffer> buffers;
	buffers.push_back(boost::asio::buffer(str));
	const char miscCrlf[] = { '\r', '\n' };
	buffers.push_back(boost::asio::buffer(miscCrlf));
	return buffers;
};

class ConnectionManager;

class Connection : public std::enable_shared_from_this<Connection> {
	public:
		Connection(const Connection&) = delete;
		Connection& operator=(const Connection&) = delete;
		explicit Connection(boost::asio::ip::tcp::socket socket, ConnectionManager& manager);
		void start();
		void stop();

	private:
		void doRead();
		void doWrite();
		boost::asio::ip::tcp::socket socket_;
		ConnectionManager& ConnectionManager_;
		std::array<char, 8192> buffer_;
};

typedef std::shared_ptr<Connection> ConnectionPtr;

class ConnectionManager
{
	public:
		ConnectionManager(const ConnectionManager&) = delete;
		ConnectionManager& operator=(const ConnectionManager&) = delete;
		ConnectionManager();
		void start(ConnectionPtr c);
		void stop(ConnectionPtr c);
		void stopAll();

	private:
		std::set<ConnectionPtr> connections_;
};

Connection::Connection(boost::asio::ip::tcp::socket socket,
		ConnectionManager& manager)
	: socket_(std::move(socket)),
		ConnectionManager_(manager)
{
	boost::asio::socket_base::keep_alive option(true);
	socket_.set_option(option);
}

void Connection::start() {
	doRead();
}

void Connection::stop() {
	socket_.close();
}

void Connection::doRead() {
	auto self(shared_from_this());
	socket_.async_read_some(boost::asio::buffer(buffer_), [this, self](boost::system::error_code ec, std::size_t bytesTransferred) {
		char data[bytesTransferred];
		std::memcpy(data, buffer_.data(), bytesTransferred);
		std::cout << "PACKET : " << std::endl << data << std::endl;
		if (!ec) {
			doWrite();
		} else if (ec != boost::asio::error::operation_aborted) {
			ConnectionManager_.stop(shared_from_this());
		}
	});
}

void Connection::doWrite() {
	auto self(shared_from_this());
	boost::asio::async_write(socket_, toBuffers("HTTP/1.1 200 Connection established\r\n"), [this, self](boost::system::error_code ec, std::size_t) {
	});
	doRead();
}

ConnectionManager::ConnectionManager(){
}

void ConnectionManager::start(ConnectionPtr c) {
	connections_.insert(c);
	c->start();
}

void ConnectionManager::stop(ConnectionPtr c) {
	connections_.erase(c);
	c->stop();
}

void ConnectionManager::stopAll() {
	for (auto c: connections_)
		c->stop();
	connections_.clear();
}

class agent {
	public:
		agent(const agent&) = delete;
		agent& operator=(const agent&) = delete;
		explicit agent();
		void run();

	private:
		void doAccept();
		void doAwaitStop();
		boost::asio::io_context io_context_;
		boost::asio::signal_set signals_;
		boost::asio::ip::tcp::acceptor acceptor_;
		ConnectionManager ConnectionManager_;
};

agent::agent()
	: io_context_(1),
		signals_(io_context_),
		acceptor_(io_context_),
		ConnectionManager_(){

	signals_.add(SIGINT);
	signals_.add(SIGTERM);
#if defined(SIGQUIT)
	signals_.add(SIGQUIT);
#endif // defined(SIGQUIT)
	doAwaitStop();
	boost::asio::ip::tcp::resolver resolver(io_context_);
	boost::asio::ip::tcp::endpoint endpoint = *resolver.resolve("<IP_ADDRESS>", "8080").begin();
	acceptor_.open(endpoint.protocol());
	acceptor_.set_option(boost::asio::ip::tcp::acceptor::reuse_address(true));
	acceptor_.bind(endpoint);
	acceptor_.listen();
	doAccept();
};

void agent::run() {
	io_context_.run();
};

void agent::doAccept() {
	acceptor_.async_accept(
			[this](std::error_code ec, boost::asio::ip::tcp::socket socket)
			{
				if (!acceptor_.is_open()) {
					return;
				};
				if (!ec) {
					ConnectionManager_.start(std::make_shared<Connection>(
							std::move(socket), ConnectionManager_));
				};
				doAccept();
			});
}

void agent::doAwaitStop() {
	signals_.async_wait(
			[this](std::error_code /*ec*/, int /*signo*/)
			{
				acceptor_.close();
				ConnectionManager_.stopAll();
			});
}

int main(int argc=0, char* argv[]=0){

	try {
		agent nipoAgent;
		nipoAgent.run();
	}
	catch (std::exception& e) {
		std::cerr << "exception: " << e.what() << "\n";
		exit(1);
	}
	return 0;
};

It will open port 8080 on <IP_ADDRESS> over tcp
As you see I have printed the socket input as PACKET
std::cout << "PACKET : " << std::endl << data << std::endl;

And when I set https_proxy and do a curl, I am expecting to see all which comes to the socket as PACKET in output
So the sequence is like this
curl --- https://blah.com sends connect  request ---> main.cpp (<IP_ADDRESS>:8080)
main.cpp --- return HTTP/1.1 200 Connection established\r\n ---> curl
curl --- sends client hello ---> main.cpp
But here I do not see the client hello request as PACKET and it is empty
Build it
[~]>$ g++ main.cpp -o test

Run it
[~]>$ ./test

Set https_proxy and do curl
[~]>$ export https_proxy="<IP_ADDRESS>:8080"
[~]>$ curl https://ident.me -v
* processing: https://ident.me
* Uses proxy env variable https_proxy == '<IP_ADDRESS>:8080'
*   Trying <IP_ADDRESS>:8080...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 8080
* CONNECT tunnel: HTTP/1.1 negotiated
* allocate connect buffer
* Establish HTTP proxy tunnel to ident.me:443
> CONNECT ident.me:443 HTTP/1.1
> Host: ident.me:443
> User-Agent: curl/8.2.1
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 200 Connection established
<
* CONNECT phase completed
* CONNECT tunnel established, response 200
* ALPN: offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: none
* OpenSSL/3.1.2: error:0A00010B:SSL routines::wrong version number
* Closing connection
curl: (35) OpenSSL/3.1.2: error:0A00010B:SSL routines::wrong version number

Check the output of main.cpp
[~/data/git/MortezaBashsiz/testboost]>$ ./test
PACKET :
CONNECT ident.me:443 HTTP/1.1
Host: ident.me:443
User-Agent: curl/8.2.1
Proxy-Connection: Keep-Alive

�hU
PACKET :

PACKET :

For proof that the client sends hello packet to main.cpp you can see in tcpdump output

As you see, there should be something in the second PACKET as output
My question is where I made a mistake ?

@klemens-morgenstern
Thank you so much for your answer
TBH, I am not experienced in C++ and this is my first try, and I am trying to learn. I didn't understand what should I do to fix this code.

You'll need to look into pointers and all the other stuff that make lose their mind in C++ i fear. try this first though:
template<std::size_t N>
std::array<boost::asio::const_buffer, 2u> toBuffers(const char (&str[N]))
{
       return {
           boost::asio::buffer(str),
           boost::asio::buffer("\r\n")
       };
};

@klemens-morgenstern
I got error while using this code
error: declaration of ‘str’ as array of references

My bad:
template<std::size_t N>
std::array<boost::asio::const_buffer, 2u> toBuffers(const char (&str)[N])
{
       return {
           boost::asio::buffer(str),
           boost::asio::buffer("\r\n")
       };
};

@klemens-morgenstern
Thanks, code works, but it did not solve the issue
I think here is a misunderstanding
I tried to describe my issue in previous comment
I don't think that function toBuffers is related to what I asked since it used in doWrite and I print the income packet in doRead
I am talking about client hello request which generates in client curl side and transferred to server main.cpp
When I write randome stream on socket over tcp, it receives the packet and print it on output but for the request client hello from curl it does not print anything and the output is empty
Writing to tcp socket
[~]>$ echo "aaaaaaaaaaaaa" > /dev/tcp/<IP_ADDRESS>/8080
[~]>$

The output of main.cpp
PACKET :
aaaaaaaaaaaaa

I had some tests around it
I decided to implement it with pure socket then I wrote following code
#include <iostream>
#include <string>
#include <stdio.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <arpa/inet.h>
#include <stdlib.h>
#include <unistd.h>
#include <string.h>
#include <netdb.h>
#include <sys/uio.h>
#include <sys/time.h>
#include <sys/wait.h>
#include <fcntl.h>
#include <fstream>
using namespace std;
int main()
{
    char msg[1500];
    sockaddr_in servAddr;
    bzero((char*)&servAddr, sizeof(servAddr));
    servAddr.sin_family = AF_INET;
    servAddr.sin_addr.s_addr = htonl(INADDR_ANY);
    servAddr.sin_port = htons(8080);
    int serverSd = socket(AF_INET, SOCK_STREAM, 0);
    int bindStatus = bind(serverSd, (struct sockaddr*) &servAddr,
        sizeof(servAddr));
    listen(serverSd, 5);
    sockaddr_in newSockAddr;
    socklen_t newSockAddrSize = sizeof(newSockAddr);
    struct timeval start1, end1;
    gettimeofday(&start1, NULL);
    int bytesRead, bytesWritten = 0;
    int newSd = accept(serverSd, (sockaddr *)&newSockAddr, &newSockAddrSize);
    memset(&msg, 0, sizeof(msg));//clear the buffer
    bytesRead += recv(newSd, (char*)&msg, sizeof(msg), 0);
    cout << "PACKET : " << endl;
    cout << msg << endl;
    string response = "HTTP/1.1 200 Connection established\r\n\r\n";
    strcpy(msg, response.c_str());
    bytesWritten += send(newSd, (char*)&msg, strlen(msg), 0);
    memset(&msg, 0, sizeof(msg));//clear the buffer
    bytesRead += recv(newSd, (char*)&msg, sizeof(msg), 0);
    cout << "PACKET : " << endl;
    cout << msg << endl;
    gettimeofday(&end1, NULL);
    close(serverSd);
    return 0;
}

It will open port 8080
And when you use this port as https_proxy
export https_proxy="<IP_ADDRESS>:8080"

And then use the curl to get some https url
curl -L https://google.com -v
* processing: https://google.com
* Uses proxy env variable https_proxy == '<IP_ADDRESS>:8080'
*   Trying <IP_ADDRESS>:8080...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 8080
* CONNECT tunnel: HTTP/1.1 negotiated
* allocate connect buffer
* Establish HTTP proxy tunnel to google.com:443
> CONNECT google.com:443 HTTP/1.1
> Host: google.com:443
> User-Agent: curl/8.2.1
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 200 Connection established
<
* CONNECT phase completed
* CONNECT tunnel established, response 200
* ALPN: offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: none
* OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to google.com:443
* Closing connection
curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to google.com:443

And the output of code is
./server
PACKET :
CONNECT google.com:443 HTTP/1.1
Host: google.com:443
User-Agent: curl/8.2.1
Proxy-Connection: Keep-Alive

PACKET :

As you see the second PACKET: is empty
Which the request client hello has been sent from curl to port 8080

I will close this ticket since I believe this is not boost problem and something is wrong from my side


[W-13120528 + W-13121643] bug fixes - breadcrumbs, code snippet

refs:

W-13120528
W-13121643

breadcrumbs bug

fix breadcrumbs bug + refactor code so it's easier to maintain
minor refactoring of the code

code snippet bug
Fixed a bug where each code snippet has an unexpected border around it. Caused by upgrading a software dependency previously (postcss-nesting).

loom video: https://www.loom.com/share/bb429959c6184c70bd32cc89c7b0d423


feat: add testRandBlob CLI for testground tests

Overview
ATM, test-infra repo is using my fork of celestia-app, which is not ok.
We need a CLI command for tests to trigger PFBs from apps' side, hence we have added another command named TestRandBlob
This PR contains another renaming, touching removal of Wire prefixes
Ref: https://github.com/celestiaorg/test-infra/issues/159

Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[x] Linked issues closed with keywords

Codecov Report

Merging #1311 (220d5e1) into main (abfca15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1311   +/-   ##
=======================================
  Coverage   49.79%   49.79%
=======================================
  Files          76       76
  Lines        4374     4374
=======================================
  Hits         2178     2178
  Misses       2014     2014
  Partials      182      182

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


how to seed sample data into the mongo db ?

I tried to seed the sample data but looks like if the below command does anything.
 MONGO_SEED=true npm start
'MONGO_SEED' is not recognized as an internal or external command,
operable program or batch file.

In production.js
set
seedDB: {
seed: process.env.MONGO_SEED === 'true',
then
MONGO_SEED=true npm start:prod
if got problem
use npm install gulp-sass --save-dev

It's already configured that way, so should it work ?
seedDB: {
  seed: process.env.MONGO_SEED === 'true',
  options: {
    logResults: process.env.MONGO_SEED_LOG_RESULTS !== 'false',
    seedUser: {
      username: process.env.MONGO_SEED_USER_USERNAME || 'seeduser',
      provider: 'local',
      email: process.env.MONGO_SEED_USER_EMAIL ||<EMAIL_ADDRESS>      firstName: 'User',
      lastName: 'Local',
      displayName: 'User Local',
      roles: ['user']
    },
    seedAdmin: {
      username: process.env.MONGO_SEED_ADMIN_USERNAME || 'seedadmin',
      provider: 'local',
      email: process.env.MONGO_SEED_ADMIN_EMAIL ||<EMAIL_ADDRESS>      firstName: 'Admin',
      lastName: 'Local',
      displayName: 'Admin Local',
      roles: ['user', 'admin']
    }
  }
}

Also, how does the gulp-sass relate to mongo seed ?

What is the you got error.
if you run MONGO_SEED=true npm start:prod
follow the [https://github.com/meanjs/mean/blob/master/README.md#running-with-user-seed]

I am running it in a command prompt and i get the below error.
'MONGO_SEED' is not recognized as an internal or external command,
operable program or batch file.

try to,
clone master repo.
and run it.

So it doesn't work on the code generated by yo generator ? It should all be same correct ? how would it be any difference ?

I used clone master repo.
it's work for me.

Probably a problem with environment variables in windows

Thanks, I figured it was a problem with the command prompt I am using, tried the same in cygwin and it worked.


Revert changes in #29

Revert changes, now we need to use our own addExternalLibs function because the  MLIRContext mismatches with CUDA's.
This commit needs to be merged after https://github.com/intel/intel-xpu-backend-for-triton/pull/74.

Close this PR as it is has done in #74


Add place to mount Coral usb accelerator

since it works and speeds prediction... (i.e., https://github.com/UNCG-DAISY/SandCam/discussions/61)
could go inside or outside..

New case designed to have mount points inside and outside, will test and see if inside gets to hot. This is issue can be closed when testing is done

i propose we close this for now, since the mounting points are incorporated.. @jacobstasiewicz if you want to open a new issue for testing temps inside the case, then go for it.


Add description for new View Monitoring role to scope to Monitoring V2

Once https://github.com/rancher/rancher/issues/31411 is resolved, we'll need to add a description to the newly created Role that clearly specifies that this Role is only meant for users using Monitoring V2 and only provides access to External Links such as Prometheus, Grafana, and Alertmanager.
If it makes sense, we might also want to override the displayName from Access Monitoring to something that would make more sense to the end user.

@westlywright can you update https://github.com/rancher/docs/issues/3061 once you finish this task? In case any of the naming has been changed as a result of this issue.

Translation name could be added as a placeholder until the backend is ready (though it could possibly be renamed too).

The description for this should also specify that this only provides permissions to users who are a Project Member of at least one Project. Users who are Cluster Members only will not be able to use these permissions.

Original rancher/rancher ticket closed, which now has a new one: https://github.com/rancher/rancher/issues/43399
Checking on relevance to this ticket based on history.


fix(packaging): esy @release create fails on linux

This reverts ad136eef1867e14e67a2a0e0c31a3945d02d83f1/#2254
The workaround is broken since the server hosting the binary seems to be down entirely, and the issue seems to have been fixed.

/azp run

Awesome, thanks @glennsl !


HELM: cainjector.enabled=false does not disable cainjector deployment for chart

Describe the bug:
When installing cert-manager via the helm chart, as of version 0.12.0, setting the cainjector.enabled flag to false no longer disables the deployment of the cainjector.
Expected behaviour:
Setting the cainjector.enabled flag to false should disable the deployment
Steps to reproduce the bug:
kubectl apply --validate=false -f https://raw.githubusercontent.com/jetstack/cert-manager/release-0.12/deploy/manifests/00-crds.yaml

helm install --name cert-manager --namespace cert-manager jetstack/cert-manager --set cainjector.enabled=false --version 0.12.0

or
kubectl apply --validate=false -f https://raw.githubusercontent.com/jetstack/cert-manager/release-0.13/deploy/manifests/00-crds.yaml

helm install --name cert-manager --namespace cert-manager jetstack/cert-manager --set cainjector.enabled=false --version 0.13.0

Anything else we need to know?:
Tested working with cert-manager version 0.11.0 and 0.11.1, no longer works with 0.12.0+
Issue most likely stems from this commit: https://github.com/jetstack/cert-manager/commit/3f2e9dd37f38471df1ba06d1d1e151232a3ba935
Environment details::

Kubernetes version: 1.14.8-gke.33
Cloud-provider/provisioner: GKE
cert-manager version: 0.12.0+
Install method: helm
Helm version - Client: v2.13.1
Helm version - Server: v2.13.1

/kind bug

This is fixed by #2552, which will be in v0.13.1 & released today!


Missing response body content on few occasions

This is my lua script.

[ ] the response content of a URL returning a 404 is missing in the HAR. The content loaded from that 404 page will be present in the HAR output.

Is is expected? Am I missing anything?
I tried to pass handle_httpstatus_all = True in my spider, but it didn't work either for the HAR file:
Note that if the page I request is returning a 404, splash:html() still give me the content.

[ ] if the following snippet is present on a page, the full content of the page is missing in the HAR file

<script type='text/javascript'> window.location.href = "<url>"; </script>

It could be related to the target website. Have you tried some other website, with the same lua script?

Good point, I found an other website with window.location.href and the content is present. As we're talking of phishing websites, they are sketchy by definition. I'll try to come with an example.
For the 404, it is pretty consistent, you can try with http://circl.lu/dsafasdfdsf for example.

And for the empty content: https://lululujcojsta.blogspot[.]com/?m=0 (warning, phishing content)
FYI, this is the content I get with curl: foo.txt


Add Order Placing tab

Describe the solution you'd like
Add a new page of Order to give restaurants the ability to place orders from their menu item and automating the inventory updation

This issue gets Resolved over #19 PR


Implement PATCH method instead of PUT for all plugin connection api

Description
As we discussed #1405 a while back, the solution was to separate api into 2 step since we didn't find a elegant way to implement PATCH.
However, I found out it is doable while I reading jira code. After discuss with @e2corporation , We agreed that it is better for us to adopt PATCH mechanism instead of multiple api for connection createion and updation.
Describe the solution you'd like

Add PATCH method to connection api for all plugins (ae/github/gitlab/jenkins)
Remove PUT method
Unify request/response body format for connection api
Unify property name to camelCase

Todo

[ ] Backend API
[ ] Frontend UI

Has the Feature been Requested Before?
No

@narrowizard , this affect jira connection management, please take a look


Unable to locate external dependencies

Hi,
I have a problem when trying to evaluate a form where I am requiring a package that is not from Clojure or local.
The code/tests are running perfectly fine in the command line. Conjure works perfectly fine when only requiring namespaces from the current project or from Clojure itself (e.g. clojure.string). It is just failing when trying to load packages that are in the deps.edn (e.g. Instaparse, Reitit).
Here is an example of an error I am seeing in Conjure after trying to load the current buffer:
; --------------------------------------------------------------------------------
; eval (buf): /project/src/parser/parser.clj
; (err) Execution error (FileNotFoundException) at parser.parser/eval5645$loading (REPL:1).
; (err) Could not locate instaparse/core__init.class, instaparse/core.clj or instaparse/core.cljc on classpath.

I suspect it is not a bug but a mere configuration problem on my side (something like a missing classpath settingor something like that), though I can't seem to find any pointers on how to solve that issue. Any help would be appreciated!
I am running clj <IP_ADDRESS>3 and a fairly recent version of Conjure (I think I updated my NeoVim plugins last week).

So, I find the problem. It was between the keyboard and the chair...
I somehow forgot that I needed to start my REPL in the root folder of my project. Everything is working as expected.
Apologies for opening an issue for such a mundane question.

Ah I see! Glad you found it! Sorry I didn't get around to helping in time.

No worries! Thanks for all the good work!

On 23 May 2022, at 22:43, Oliver Caldwell @.***> wrote:
Ah I see! Glad you found it! Sorry I didn't get around to helping in time.
—
Reply to this email directly, view it on GitHub https://github.com/Olical/conjure/issues/356#issuecomment-1135119931, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACAWX5UPMWD3UWFJNUNS6BTVLPUWNANCNFSM5WNL2BQQ.
You are receiving this because you modified the open/close state.


Unuseful week in dayGridMonth

In this specific situation:

days 0 and 6 hidden (Saturday and Sunday)
month starts on Sat or Sun (like December 2024)

dayGridMonth shows the first row with only days of the previous month, in this case November.

Thank you for bringing this rare case to my attention. I will try to fix this problem.


refactor(gmail): rewrite

Probably closes #414, closes #870. Adds myself as maintainer for the Gmail userstyle and rewrites it from scratch.

[x] Advanced filters
[x] Label menu modal

[x] New label input

[x] Settings
[x] Compose mail window
[x] Tooltips
[x] Gmail logo

Note to self: undo icon filter that overrides label colors:

Sidebar unthemed.

Google Chat status unthemed. Dropdown too.

Important unthemed.

Quick settings unthemed.

Labels unthemed.

Divider unthemed.

IMAP status unthemed.

Hover on mail unthemed.

Attachment preview unthemed.

Trash warning unthemed.

@r58Playz fixed the important indicator, labels settings page, trash warning, hover on mail box shadow, and the attachment chips. I could not theme the IMAP status (requires lengthy setup) and Google Chat/Meet sidebar and dropdowns (don't have on my Gmail account ig). Quick settings has been left intentionally unthemed for now, will get to it later.


Not Support Expect:100-continue (HTTP/1.1)

libcurl will send http/1.1 head  Expect:100-continue  by default. this will cause a 2 second wait for any huge data post requset.
version  0.13-dev,python 2.6.6

usage:
$python -m bottle test_module

Seems WSGIRefServer will not transmit request to bottle if it didn't get request body.


Can we write and use our own code generator?

Is it possible to write and use our own code generator from Plasmic UI builder?
It would be nice if we could get some abstract model of components and render whatever code we want to render ourselves

Hi @aleksandrlat , yes it's possible - the full underlying model is available here:
https://docs.plasmic.app/learn/model-quickstart/
Note that this is still quite early. First, the schema does evolve, but usually pretty incrementally/non-violently. Second, the main thing that's missing is documentation of the types. But sharing this in case it helps unblock you.
Out of curiosity, what are you thinking of doing with that?

Thank you @yang!

Out of curiosity, what are you thinking of doing with that?

We have our design system and we use styled components in the code. Styled components is strict requirement for code base. So to get buy in from the team I want to try to generate react styled components.
I will read the docs. Do you have open source react code code generation? This can be a good example for me to see implementation. And I can re-use part of it for sure.

Hello @yang!
Is codegen.plasmic.app open source too now?
Could you please point me to where it is located?


Create a discord server

Gitter is a bit chaotic, and I personally think creating a Discord server instead of using Gitter would be beneficial. You could spread it out into different channels, for example extension-development, help, development etc. Also, lots of communities are moving from Gitter to Discord, so I think VSCode should as well.

I also support @Milo123459
discord will be the better choice than Gitter

@zareami10 May I ask why you think there shouldn't be a discord server? Is there something you like about Gitter? I asked a question about a month ago and still haven't gotten a response.

@zareami10 May I ask why you think there shouldn't be a discord server? Is there something you like about Gitter? I asked a question about a month ago and still haven't gotten a response.

Well I personally don't think projects should change their communication platforms that easily unless there is a very strong reasoning, because then we would have to change platforms every other week.
But besides that Gitter is moving to Matrix, an open standard protocol with a much better future. Thus I would never understand any moves towards a closed and proprietary platform such as Discord.

Okay. Maybe a way of linking Matrix & Discord? A matrix bridge?

Telegram also can be good choice.

Issue's dead, and I doubt it's happening. There will probably be a community one


Enable CI on Fuchsia

r? @Thomasdezeeuw

Oops, forgot this in #191. Thanks @tamird.

Oops, forgot this in #191. Thanks @tamird.


Refactor and fixes placeholders

Fixes #473

This feature has been implemented and will be included in the next update. Thank you for the suggestion.


feat: entity explorer de-duplication

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

Add a TL;DR when description is extra long (helps content team)

Fixes https://github.com/appsmithorg/appsmith/issues/22113

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/build-deploy-preview=release

/build-deploy-preview env=release

/build-deploy-preview env=release


docs: Add ENV vars for Android setup

The type of this PR is: Documentation
Description
This PR updates the Android setup instructions with a few necessary ENV vars. See this slack convo for more info.
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

🙏🏼 thanks @damassi


[POL-41] Public API Auth Tokens

Create API tokens in personal settings to use as Bearer tokens in our Public API vs. cookie.

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog :^)

POL-41

Do you mean something like this? 😉
https://polar.sh/settings/tokens

Test

Haha oops. Yes. Forgot about it since it's hidden.
Will update the description. Since we'll work on our API/SDK this upcoming quarter, I think we can quickly design and move this into our main settings (nice prompt for the API given our audience)

Awesome, this is chef kiss
On Tue, Oct 03, 2023 at 15:09:53, Emil Widlund @.***>
wrote:

Access Token settings design can be found here: https://www.figma.com/
file/1p2oOjsRBgSrr3SC4zySJG/Polar-v0.
3%3A-Rewards-%26-Social?type=design&node-id=611-15490&mode=design&t=FphuEgKnbb5OOyUW-11
—
Reply to this email directly, view it on GitHub
https://github.com/polarsource/polar/issues/1230#issuecomment-1744948162,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACEY44R5KOWAS55A2RVAULX5QFCDAVCNFSM6AAAAAA5CYCONSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBUHE2DQMJWGI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Merge in Kickflip to Skate proper

This will make Skate opinionated about rendering and what it uses to do so:

Named slots is polyfilled (possibly can use v0 shadow DOM in Blink)
Incremental DOM is the defacto virtual DOM implementation.

Pros:

Skate puts less of the onus on users to decide the best way to do things.
You can still use any templating language you want as long as it compiles down to Incremental DOM.
We push for functional web components.

Cons:

It gets a little bigger.
People can no longer choose how they want to render things, but this could be alleviated by being able to choose your own templating language if it compiles down to Incremental DOM.

I think if it increases the consumeability of skate without taking away actual widely used features (e.g. just adding a bit of opinionated flavour) it is a good idea. Anyone wanting to get into the topic fast would use Skate+kickflip anyway, so merging them would make it easier. The only thing I am a little concerned about is the amout of polyfilling - skate currently only fills tiny amounts and I think that is actually an advantage of skate by itself.

The amount of polyfilling is a temporary issue I'm willing to risk at this point for the sake of simplicity and more widespread adoption.

@marcoms You'd probably have an opinion here.
@antitoxic you've been vocal in the past about Skate not having an opinionated way to render. This would fix that. Input is appreciated.

I must admit I don't have experience with functional approaches like React uses. One thing I've been wary of is how animation would be possible between two different DOM states (which is why I have in the past been interacting with the DOM directly on property changes instead of re-rendering). I believe Aurelia automatically animates layout changes but something like that would probably be non-trivial and require more thought.

@marcoms that's a very valid concern. There can be issues with this. For example, if

a render occurs during the middle of an animation and your animation is based on changes to the style attribute that Incremental DOM isn't aware of, or
the position of the animating element changes relative to its siblings and there is no key defined ,it would be blown away and re-rendered

For 1, there are a couple of work arounds. Perhaps you could simply use the render() function to animate the style property similar to how react-motion does things:
skate('my-element', {
  properties: {
    animationWidth: skate.properties.number()
  },
  render (elem) {

  }
});

Or you could simply tell Incremental DOM not to diff the style attribute using the statics prop on an element:
skate('my-element', {
  render () {

  }
});

For 2, a simple approach would be to give the element that you know might be affected a key so that Incremental DOM knows where it is in the diff tree:
skate('my-element', {
  render () {

  }
});

A possible future goal might be to declaratively animate a component from within the render() function similar to react-motion:
skate('my-element', {
  render (elem) {
    <sk-animate defaultStyle={{ x: 0 }} style={{ x: spring(10) }}>

    </sk-animate>
  }
});

Thanks for the in-depth response. While I become acquainted with this new way of things, is it possible to emulate skate's current behaviour of rendering once and mutating the (shadow) DOM as normal (in property setters, for example) using kickflip?

What you could do, if you really wanted to, is to do something like:
skate('my-element', {
  properties: {
    myProp: {
      render: false,
      set () {
        // do mutations here
      }
    }
  }
});

The issue here is that if you have any other properties then you need to make sure they don't re-render or you'll lose the mutations you made in the setter for myProp. It would just be something you'd need to do as a convention if you're mutating things.
In terms of how this actually works in practice, I can't comment for sure. Theoretically this should work, but it (obviously) deviates from the recommended way of rendering and I haven't tried it yet.


fix: remove curand dependency

Signed-off-by: wep21<EMAIL_ADDRESS>Related Issue(required)

Description(required)
remove unused curand dependency
Review Procedure(required)

build check
run check(if possible)

Related PR(optional)

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Read commit-guidelines
[x] Assign PR to reviewer

If you are adding new package following items are required:

[ ] Documentation with description of the package is available
[ ] A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Since I'm not familiar with this issue, I'll leave the review to @yukkysaito.


I need a shortcut to not start the console when I dock it to the system taskbar and start it again,Maybe it's a bug, too.

[ ] I have checked that a similar feature request does not already exist.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
I hope to provide a shortcut that does not automatically pop up the console, because once I start the console, I minimize the software, and then click on it, it is very troublesome, and I have to switch between it, because my phone here shares a taskbar position with the console. If I don't share the same location, I can easily turn off the console, resulting in the phone being turned off.
scrcpy-noconsole.vbs can not be fixed in the taskbar, use it to start the software, and then fixed in the taskbar, and then I close, and then open from the taskbar, will still start the console
Maybe this is a bug.

scrcpy-noconsole.vbs can not be fixed in the taskbar, use it to start the software, and then fixed in the taskbar, and then I close, and then open from the taskbar, will still start the console

scrcpy-noconsole.vbs can not be fixed in the taskbar

#2159


Demo: got Future  attached to a different loop

I am trying the example out on Python 3.8.5 and getting the following error when invoking the /trigger endpoint:
$ PORT=8004 python pubsub_broadcaster_server_example.py
INFO:     Started server process [58697]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8004 (Press CTRL+C to quit)
INFO:     ('<IP_ADDRESS>', 37088) - "WebSocket /pubsub" [accepted]
INFO:     <IP_ADDRESS>:37124 - "GET /trigger/ HTTP/1.1" 307 Temporary Redirect
INFO:     <IP_ADDRESS>:37124 - "GET /trigger HTTP/1.1" 200 OK
Failed to notify subscriber sub_id=a8fd8a8aaf6d42238d6bda98f193bf40 with topic=germs
Traceback (most recent call last):
  File "/home/bridge/venv/websocket/lib/python3.8/site-packages/fastapi_websocket_pubsub/event_notifier.py", line 156, in callback_subscribers
    await self.trigger_callback(data, topic, subscriber_id, event)
  File "/home/bridge/venv/websocket/lib/python3.8/site-packages/fastapi_websocket_pubsub/event_notifier.py", line 129, in trigger_callback
    await subscription.callback(subscription, data)
  File "/home/bridge/venv/websocket/lib/python3.8/site-packages/fastapi_websocket_pubsub/event_broadcaster.py", line 157, in __broadcast_notifications__
    async with self._publish_lock:
  File "/usr/lib/python3.8/asyncio/locks.py", line 97, in __aenter__
    await self.acquire()
  File "/usr/lib/python3.8/asyncio/locks.py", line 203, in acquire
    await fut
RuntimeError: Task <Task pending name='Task-20' coro=<EventNotifier.callback_subscribers() running at /home/bridge/venv/websocket/lib/python3.8/site-packages/fastapi_websocket_pubsub/event_notifier.py:156> cb=[gather.<locals>._done_callback() at /usr/lib/python3.8/asyncio/tasks.py:758]> got Future <Future pending> attached to a different loop
INFO:     ('<IP_ADDRESS>', 37644) - "WebSocket /pubsub" [accepted]

The client does see the events though:
$ PORT=8004 python pubsub_client_example.py
running callback for guns!
running callback for germs!
running callback for germs!
running callback steel!
Got data None

This what I have installed:
aiohttp==3.7.4.post0
async-timeout==3.0.1
asyncpg==0.22.0
attrs==20.3.0
broadcaster==0.2.0
certifi==2020.12.5
chardet==4.0.0
click==7.1.2
fastapi==0.63.0
fastapi-websocket-pubsub==0.1.17
fastapi-websocket-rpc==0.1.18
flake8==3.9.0
h11==0.12.0
idna==2.10
iniconfig==1.1.1
mccabe==0.6.1
multidict==5.1.0
packaging==20.9
pkg-resources==0.0.0
pluggy==0.13.1
py==1.10.0
pycodestyle==2.7.0
pydantic==1.8.1
pyflakes==2.3.1
PyJWT==2.0.1
pyparsing==2.4.7
pytest==6.2.3
requests==2.25.1
sentry-sdk==1.0.0
six==1.15.0
starlette==0.13.6
tenacity==7.0.0
toml==0.10.2
typing-extensions==<IP_ADDRESS>
urllib3==1.26.4
uvicorn==0.13.4
websockets==8.1
yarl==1.6.3

Hi @mikebridge,
Thanks for reporting this!
I believe you have found a bug in the recent released version (a silly mistake as well - initing
self._publish_lock in init instead of within the with statement).
I'll create and deploy a new version soon, meanwhile feel free to use the previous version (0.1.16)

Hi @mikebridge - check out 0.1.18
Should resolve this issue ;-)

@orweis Great, thant seems to work, thanks!


ignore headers transfer_encoding_chunked and content_length to work with http assemblers.

added ignore_header_transfer_encodig_chunked and ignore_header_content_length to settings.
ignore_header_content_length:
useful if body length and content length does not match. happens with owa servers. or working with pre http assemblers that unzips compressed content without changing content-length.
ignore_header_transfer_encodig_chunked:
useful when working with pre-http assemblers which assembles chunked content into one http packet without changing transfer-encoding field.
may be useful for someone.

Thanks, but since it's an ABI change (changes sizeof(struct http_parser)), it can't land until the next major release.  That's not expected to happen anytime soon.


fix: skip-connection-status flag works

What does this PR do?
we've been ignoring --skip-connection-status since this command was sf-ified.  Flags weren't typed before.
What issues does this PR fix or reference?
@W-13957953@

QA:
Without fix, connectionStatus is reported in the JSON output for sf org list --skip-connection-status --json
With fix, connectionStatus is NOT reported in the JSON output for .../plugin-org/bin/dev org list --skip-connection-status --json


Calculate date range

I wonder if it is possible to replicate this fiddle using pickadate instead of UI datepicker:
http://jsfiddle.net/j145bph3/

Not working example due to resources unavailable, but this should in theory work:
https://codepen.io/amsul/pen/nGckA
Add the last field yourself and calc the amount?


TAP: Avoid errorring out with aborting user hooks

Running AbortingUserHooks.pxp with enableTAP=1 gives

I have tried to reproduce this using the patches in PR #327 (HEAD: 7f65963 (Docs: Add developer section, 2022-12-13)). I enabled JU and TAP. Neither of them produce this error.
•run()
  Start of test "Unnamed"
  Encountered "Abort" in user hook "TEST_BEGIN_OVERRIDE" (No source procedure)
  Fatal: Error: Prototype function USER_HOOK_PROTO was called.
  Encountered "Abort" in user hook "" (aborting-user-hooks.ipf)
  Failed with  errors
  Leaving test suite ""
  Encountered "Abort" in user hook "TEST_END_OVERRIDE" (No source procedure)
  Test finished with 4 errors
    ▶ Encountered "Abort" in user hook "TEST_BEGIN_OVERRIDE" (No source procedure)
    ▶ Encountered "Abort" in user hook "" (aborting-user-hooks.ipf)
    ▶ Encountered "Abort" in user hook "TEST_END_OVERRIDE" (No source procedure)
  End of test "TEST_END_OVERRIDE"

But I found an interesting bug:

ExecuteHook is called for TEST_BEGIN_CONST
User hook create an error
ExecuteHook is called for TEST_SUITE_END_CONST !!!
ExecuteHook is called for TEST_END_CONST

The third step isn't allowed as no test suite was created!

Okay if it does not reproduce the internal storage rewrite in #327 did fix it. Nice!


Using Utf8Json as InputFormatters/OutputFormatters

Hi @domaindrivendev,
Since I don't know how to reopen an old thread properly ( #1815 ) , I hope you don't mind I re-open one here refering back to the original issue opened by @Sliverb back then.
Same as him, I am also using Utf8Json serializer as input/output formatters to exchange data on my server. And by doing so, it seems that any JSON data serialized on the body of the request doesn't get 'discovered' by swashbuckle/ApiExplorer.
To show you what happens I have re-create a minimal app for your convenience there : https://github.com/darkurse/SwashbuckleWithUtf8JsonTest
If I use the default serializer it all works, if I specify the Utf8Json serializer it doesn't work anymore.. All depends on the following lines ( Note that Utf8JsonOutputFormatter, Utf8JsonInputFormatter, Utf8JsonContractResolver are classes on the minimal app project ):
 services
            .AddMvcCore()
            .AddApiExplorer()
            // note: If I comment out the AddMvcOptions section, I will see the body populated as expected
            .AddMvcOptions(option =>
            {
                option.OutputFormatters.Clear();
                option.OutputFormatters.Add(new Utf8JsonOutputFormatter(Utf8JsonContractResolver.Instance));

                option.InputFormatters.Clear();
                option.InputFormatters.Add(new Utf8JsonInputFormatter(Utf8JsonContractResolver.Instance));
            });

With the Mvc Options set , we get an empty body :

Without the Mvc Options set , we get the proper body documented :

I'm afraid there would be the same work to do as the one you made to be backward compatible with NewtonSoft.. But I don't know how and where to start to make such a mapping..
Any ideas, pointers, help is welcome.
Thank you in advance,
Julien

[Update] I have created the mirrored the idea of the project Swashbuckle.AspNetCore.Newtonsoft and created a project Swashbuckle.AspNetCore.Utf8Json ( disclaimer : This is a TEST project, so nothing is polished ).
It seems that I can now view the schema on the swagger UI .. but the POST parameters are still not working. I don't know what I am doing wrong at this point. Any pointers would be appreciated.

[Update] I have mirrored the idea of the project Swashbuckle.AspNetCore.Newtonsoft and created a project Swashbuckle.AspNetCore.Utf8Json hoping that it help in viewing the POST parameters in the swagger UI, unfortunately it didn't change anything.
I am wondering now if this is because Utf8JsonOutputFormatter and Utf8JsonInputFormatter have both something to do with the ApiExplorer.

@darkurse - what you've done is exactly what I would have recommended - the ISerializerDataContractResolver abstraction is intended to encapsulate serializer-specific behavior, and so an implementation needs to be created for any new serializer that we want SB to support.
However, the fact that you're seeing no schema defintion with the Utf8 formatters configured also makese me think this is somehow related to ApiExplorer.

@domaindrivendev , thank you for your precious feedback.
Maybe the ApiExplorer is not the (only) one to blame for this because I noticed another thing.. I remembered that Swashbuckle also reads the generated xml documentation file via the o.IncludeXmlComments(xmlPath); .. So I went to look at this xml file and this is what I noticed ( my apologize :
[...]
    <member name="M:SwashbuckleWithUtf8JsonTest.Controllers.WeatherForecastController.Set(SwashbuckleWithUtf8JsonTest.WeatherForecast)">
        <summary>
        Setting le forecast
        </summary>
        <param name="p">Le parameter</param>
    </member>
    <member name="T:SwashbuckleWithUtf8JsonTest.WeatherForecast">
        <summary>
        Le forecast class
        </summary>
    </member>
[...]

The p parameter represents the body parameter of my controller's entry point
    [HttpPost]
    public void Set([FromBody]WeatherForecast p)

It seems that the $ref is missing in the generated XML.. Is OpenApi used to generate this file ? Or is it going through another process ?
In any case, if I bypass the GenerateXML section altogether, it doesn't help either. So issue seems multifold.

OK - I was very curious about this so ended up digging into the ASP.NET Core code, specifically around ApiExplorer and came across the following snippet:
https://github.com/dotnet/aspnetcore/blob/c925f99cddac0df90ed0bc4a07ecda6b054a0b02/src/Mvc/Mvc.ApiExplorer/src/DefaultApiDescriptionProvider.cs#L411
if (formatter is IApiRequestFormatMetadataProvider requestFormatMetadataProvider)
{
    var supportedTypes = requestFormatMetadataProvider.GetSupportedContentTypes(contentType, type);

This tipped me off to the fact that custom input and output formatters needs to implement IApiRequestFormatMetadataProvider  and IApiResponseTypeMetadataProvider respectively to play nicely with ApiExplorer, and thus Swashbuckle.
I guess the intention is that you use the abstract implementations (InputFormatter and OutputFormatter) rather than interfaces directly, as these include some of this for you already. However, the additional interfaces you need to implement are very simple and so you could go with either approach. I tested this out with your sample app and it worked perfectly.

Well done !
I think I went completely off track this morning with my "generated xml documentation" idea.. Playing with the code again, I saw that I made wrong assumptions.
I have now done as suggested and voila : !

Thank you so much for your time, much appreciated 👍

@darkurse  any chance you have a sample repo that covers what you did?  I am experiencing the same exact issue.

@darkurse  disregard, I found https://github.com/neuecc/Utf8Json/tree/master/src/Utf8Json.AspNetCoreMvcFormatter. Hope that helps anyone else.
Then it's a matter of doing what was already shared:
``
services.AddControllers(option =>
{
option.OutputFormatters.Clear();
option.OutputFormatters.Add(new JsonOutputFormatter(StandardResolver.Default));
option.InputFormatters.Clear();
option.InputFormatters.Add(new JsonInputFormatter());
});
``

I'm glad you found it yourself.. As written in my unclear addendum, I have cloned the current project and made the changes to make it work for me.
Sorry that I couldn't help you out earlier. I just couldn't find the time :/


Clearly erroneous dynamic UBO offset error triggered

ERROR: [DS] DescriptorSet Code 63 : VkDescriptorSet (0x13e5c939f90) bound as set #0 has
dynamic offset 0x3a00. Combined with offset 0 and range 0x40 from its update, this oversteps its
buffer (0x13e4c2c5f40) which has a size of 0x100000.

There's no way that 0x3a00 + 0 + 0x40 > 0x100000, right? :)
Should be noted that the buffer has mixed contents (used as a streaming buffer for all kinds of things like vertex/index data, UBO data etc).

That is a bizarre case and the math certainly doesn't add up.
I just modified a test app to exactly replicate your numbers and I'm not hitting the error case.
The values being printed appear to exactly match the values that are being compared so I don't think that's the issue.
Your descriptorType is "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC", right?
Which version of the layers are you running? I ran my test with the latest layer code on master but I'm not aware of any changes to this code for at least a few weeks, and certainly no bugs like you're hitting.
Are you able to build the layers from source?
If so, you can break in this case pretty easily and see what's going on. Let me know if you're able to do that or any other info you can give.
I don't doubt that you're hitting this error, but until I can replicate it, it's not clear to me what may be the problem.

I saw in another issue that it looks like you're using sdk-1.0.8. I pulled that code and I realized there was one change I knew about in the dynamicOffset validation code, but it was just that this same check was replicated twice with the exact same code. The replicated check is removed in master, but that doesn't explain the issue you're seeing.
I re-ran my test on the sdk-1.0.8 code and still didn't hit the error.

It reproduces consistently. Unfortunately I don't yet have a smaller repro than this:

Check out, build and run my PSP emulator: https://github.com/hrydgard/ppsspp  (MSVC 2015, debug mode)
Go into settings, choose Backend: Vulkan, let it restart
Run any game, like Lumines. Maybe even works with cube.elf which can be gotten here: http://www.ppsspp.org/files/cube.elf

I will look into building the validation layers.

I'm unable to reproduce this error with wither a 32-bit or 64-bit build of the PSP emulator, when using validation layers from the latest GitHub source.
If you are still seeing this message, do you think you could try capturing your application with vktrace?  Maybe we can reproduce the error when replaying the trace file.

Closing due to inactivity.  I was unable to reproduce the issue locally.  Reopen if the issue still exists.

@dustin-lunarg Sorry for forgetting about updating this.
This still repros if you comment out the following in Windows/GPU/WindowsVulkanContext.cpp:
// another validator bug (validator #299)
if (msgCode == 63 && startsWith(pMsg, "VkDescriptorSet"))
	return false;

(I add such code to silence erroneous checks so I can hit others).
The demo "Suicide Barbie" from the build-in Homebrew Store is enough to repro it.
However, now (with SDK 11) the error makes more sense:
ERROR: [DS] DescriptorSet Code 63 : VkDescriptorSet (0x65c8) bound as set #0 has dynamic offset 0x100000. Combined with offset 0 and range 0x40 from its update, this oversteps its buffer (0x19) which has a size of 0x100000.

This looks valid, but actually isn't  - the UBO bind offset used in this case is actually 0x100. No idea where it gets 0x100000 from.

@dustin-lunarg  I'm suspicious of this code in core_validation.cpp : vkCmdBindDescriptorSets:
        // Save dynamicOffsets bound to this CB
        for (uint32_t i = 0; i < dynamicOffsetCount; i++) {
            pCB->lastBound[pipelineBindPoint].dynamicOffsets.emplace_back(pDynamicOffsets[i]);
        }

Surely this should clear dynamicOffsets before pushing things to the back of it?

@hrydgard can you retest with #547? Handling of dynamic offsets was pretty thoroughly broken.

@chrisforbes Thanks, I'll try to test it soon (either I find time to build the layers, or I'll test it as soon as the next release is out).

@hrydgard I'm still not able to reproduce DescriptorSet message.  I have tried with layers built from the latest master, sdk 1.0.11, 1.0.8, and 1.0.5.
I started by setting a breakpoint on the return statement from:
// another validator bug (validator #299)
if (msgCode == 63 && startsWith(pMsg, "VkDescriptorSet"))
    return false;

This breakpoint is never hit.  I have also remove the 'msgCode == 63' from the expression in case the code is different.  Removing those lines also does not produce any messages that include the text 'VkDescriptorSet' in the debug output.  With 1.0.11 and prior I only see a few of these performance warnings:

PERFORMANCE WARNING: [SC]  Code 2 : Vertex attribute at location 1 not consumed by VS
PERFORMANCE WARNING: [SC]  Code 2 : Vertex attribute at location 6 not consumed by VS

With the latest master there are a few new validation messages:

ERROR: [ParameterValidation]  Code 5 : vkCreateGraphicsPipelines: parameter pCreateInfos[i].pRasterizationState->flags must be 0
WARNING: [DS]  Code 12 : Additional bits in Dest accessMask 36864 [VK_ACCESS_TRANSFER_WRITE_BIT | VK_ACCESS_MEMORY_READ_BIT] are specified when layout is VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL.
WARNING: [DS]  Code 12 : Additional bits in Source accessMask 20480 [VK_ACCESS_TRANSFER_WRITE_BIT | VK_ACCESS_HOST_WRITE_BIT] are specified when layout is VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL.

For the app, I have built from this commit: https://github.com/hrydgard/ppsspp/commit/b5b94f4a4d736ca471427dc3ba49773be59ac5c6
I am testing with a GeForce GTX 960M, driver version 365.19
Is it possible that I am hitting a different execution path in the app due to differences in driver features?
With the latest loader, there is also an adjustment required to the list of layers being loaded by the app.  CheckLayers() is now failing for device layers due to a combination of  device layers being deprecated and a duplicate layer in validationLayers[].  Removing "VK_LAYER_GOOGLE_unique_objects", which is part of "VK_LAYER_LUNARG_standard_validation", from validationLayers[] will fix the problem.  With the deprecation of device layers, the behavior of vkEnumerateDeviceLayerProperties is to return the list of layers enabled for the instance.  It looks like the loader filtered the duplicate unique_objects layer, so only reports standard_validation.

@dustin-lunarg I just reproduced it again, on a 700-series nVidia.
I forgot, though - there's one more thing that seems to affect it. Go into Settings->Tools->Developer tools and check "Developer Menu". This adds a little button to the top left that is drawn using a different dynamic UBO (and different shaders etc) than the main graphics output, which seems to be what is confusing the validator. Also enable "Show FPS counter" in graphics settings (far down), just to be sure.

@hrydgard With the Developer Menu enabled I do see the following with sdk-1.0.11:

ERROR: [DS] DescriptorSet Code 63 : VkDescriptorSet (0x204d) bound as set #0 has dynamic offset 0x100000. Combined with offset 0 and range 0x40 from its update, this oversteps its buffer (0x1c) which has a size of 0x100000.

With the latest master these messages no longer appear.  I did some bisecting and it looks like this was resolved by #475.

Thank you Dustin, happy to see both that you could repro and that it's now fixed in master :) Closing again.
Now I just need to get around to filing an issue for the
if (msgCode == 15 && startsWith(pMsg, "In vkBindImageMemory, attempting"))
    ...

case..


Fix for 'ManyToOneRel' object has no attribute 'verbose_name' on Document/Images Usage page

Users cannot view the usage details of documents or images (where they’re being used) used at least once in any multiple Parentalkey levels models from the Wagtail admin site. This seems to be a problem in referencing the verbose_name of the correct child field due to the nested structure of multi-level ManyToOneRel fields.
More information including steps to reproduce the issue on a fresh Wagtail project can be found on #11482.
This fix should also fix an initial issue where the first field level's verbose_name is excluded from the returned string.
For example, for a field reference of ResourceItem → Document within a ResourceGroup object:
Current result: Document
This fix's result: Resource item → Document

@terrsoshi  thank you for this PR.
Are you able to add unit tests for the new behaviour so that it does not break in the future, are you also able to look at the CI failures and address the issues?


Lightbox: Item is not displayed when image source changed

OpenUI5 version:
1.52.5
Browser/version (+device/version):
Chrome 64.0.3282.167 (Mac)
Any other tested browsers/devices(OK/FAIL):
URL (minimal example if possible):
https://openui5.hana.ondemand.com/test-resources/sap/m/demokit/cart/webapp/index.html
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

Navigate to the detail page of an item in the official Shopping Cart Demo App
Klick on the image to open the lightbox.
Now choose another item from the list
Klick again on the image to open the lightbox.

What is the expected result?
The Lightbox should open both times showing the image clicked on.
What happens instead?
Only after the first opening of the lightbox an image will be displayed.
The other times, only a loading indicator will be displayed and an error message after a while.
Any other information? (attach screenshot if possible)
The issue is caused by the fact, that the setImageSource function is called when the lightbox is still closed. The if-Statement in
https://github.com/SAP/openui5/blob/df9d522bcb6020a15591aa0729a765dd22887754/src/sap.m/src/sap/m/LightBoxItem.js#L167 needs to be fixed, as it prevents the image source beeing updated when the popup is not opened. Instead the update of the image source should only be prevented when the dialog is openend.

reopened issue after accidentally closing it

Hello @ffleige ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Gery


Investigate the impact of grid editor on extensions and API

Some random notes now that grid editor layout has landed on master:

should we deprecate ViewColumn in favour of new API that exposes the grid system to extension authors?
if we decide to keep ViewColumn, how should it map to the grid system

should the order be by creation time (current solution)
should the order be by visual appearance (this would probably map best to our previous behaviour)

should we just introduce an OR-type for ViewColumn that is number so that the column is never undefined when > 3? in the current state viewcolumn will be undefined for any editor that opens in a position > 3 which is bad because extensions might have used this as a check to find out if the editor is in the editor area or not (e.g. panel, embedded editor)
we probably want to introduce a new dynamic ViewColumn that allows to open an editor to the side of the active one (ViewColumn.SIDE_BY_SIDE?) so that an extension can simply use that instead of having to make the math with absolute view columns

I am not sure if it already exposed, but accessing the View configuration from code/extensions code AND support programmatic opening of either individual or a set of views with a preconfigured setup (think of 3D editors where you open up X, Y, Z, Camera views altogether as a "workspace".
Is this supported/considered as part of this feature?
Predefined constants for 1/1, 1/2, 1/3, 1/4 view sizes which would dynamically be evaluated when someone refers to it AND would stick to the view, so in case of a window resize each view's size would be recalculated based on this parameter.

For vscodevim, each editor has it's own state (undo stack, history, cursor position, etc), and every time the active editor changes, we load the appropriate state. We maintain a map of all the states with the key being fileName + viewColumn such that if the same file is open across two different panels, it will have separate state.
Lately, we've been running into an assortment of issues with the extension loading the wrong state because: (1) file name has changed, (2) user moved the editor to a different panel, etc. With the introduction of grids, I think this will exacerbate the problem.
Is there a better alternative to generating a unique ID for the editor? If we continue using the filename + position in the editor, we'll need better events for when a user moves the window to a different viewColumn/gridPosition as the current API (onDidChangeTextEditorViewColumn) only fires on certain view column changes.

@jpoon we will still maintain compatibility and have a unique ViewColumn per editor (by just counting from left to right and up to down) even in grid world. When the user moves the editor group to another location, you will still get an event as before.
We never supported this event when moving individual editors though and I don't think grid will make it any different. For us, moving an editor is closing it at the originating editor group and opening it at the target. it is not even the same editor widget underneath.
So it seems to me you do not have a requirement for a row/column specific view column? rather as before, a unique position for each editor?

Landed via https://github.com/Microsoft/vscode/pull/51876

So it seems to me you do not have a requirement for a row/column specific view column? rather as before, a unique position for each editor?

That is correct. We need a unique ID for each editor and we are generating that based off it's position. Hence, with the introduction of the grid, we'd need something similar or... if there was some other way to garner uniqueness that would be optimal.

If we continue to generate a unique ID based off it's position, we'd need to update that ID if the textEditor position in the grid changes. Will there be an event that an extension can register to be notified of such changes? The behaviour of the existing onDidChangeTextEditorViewColumn event is suboptimal for this use case as it only seems to fire on very specific view column changes as you noted in #35602.

@jpoon the event will fire if:

you move the group (containing all editors) to another position in the grid
you close a group and as a result the position of other groups changes (e.g. close a group to the left of the current one)

We do not fire an event if you drag a single editor tab out of a group into another group. But this behaviour is totally unrelated to us moving to a grid model, it has always been like that for the reasons I mentioned earlier.

We do not fire an event if you drag a single editor tab out of a group into another group.

Maybe this belongs in a separate issue, but can I request we get an event for just this?

@jpoon yes, separate issue please.


Add Milestones API

Fixes GH-88
Signed-off-by: Gordon Smith<EMAIL_ADDRESS>

Hi @GordonSmith.
Before we can merge your PR, can you include some tests and update the README file to document your method?

closed by 4268802ebf9ee9597951ed614cc76bf42c75e601


TLS issue in Samsung Devices

Basically i'm facing issue in Samsung Devices all devices working Fine it give exception that :
Something went wrong while connecting ,make sure the credentials are right and try again:
W/System.err(29284): org.jivesoftware.smack.SmackException$NoResponseException: No response received within reply timeout. Timeout was 5000ms (~5s). While waiting for establishing TLS [XMPPTCPConnection[not-authenticated] (0)]
W/System.err(29284): 	at org.jivesoftware.smack.AbstractXMPPConnection.waitForConditionOrThrowConnectionException(AbstractXMPPConnection.java:731)
W/System.err(29284): 	at org.jivesoftware.smack.tcp.XMPPTCPConnection.connectInternal(XMPPTCPConnection.java:857)
W/System.err(29284): 	at org.jivesoftware.smack.AbstractXMPPConnection.connect(AbstractXMPPConnection.java:526)
W/System.err(29284): 	at org.xrstudio.xmpp.flutter_xmpp.Connection.FlutterXmppConnection.connect(FlutterXmppConnection.java:527)
W/System.err(29284): 	at org.xrstudio.xmpp.flutter_xmpp.Connection.FlutterXmppConnectionService.initConnection(FlutterXmppConnectionService.java:72)
W/System.err(29284): 	at org.xrstudio.xmpp.flutter_xmpp.Connection.FlutterXmppConnectionService.lambda$start$0$org-xrstudio-xmpp-flutter_xmpp-Connection-FlutterXmppConnectionService(FlutterXmppConnectionService.java:93)
W/System.err(29284): 	at org.xrstudio.xmpp.flutter_xmpp.Connection.FlutterXmppConnectionService$$ExternalSyntheticLambda0.run(Unknown Source:2)
in flutter just on every samsung device this show why
@vavadiyahiren @florisgravendeel @therif @umairrafiq1133

then also when i try to reconnect it says TLS certificate issue why ??

Facing Same issue .
@florisgravendeel @vavadiyahiren

i also using samsung android 14  and app crash

not a problem use my XMPP package just import
xmpp_plugin:
git:
url: https://github.com/danishrafiqe/chat_state_xmpp.git
ref: main
On Wed, Jun 12, 2024 at 9:04 PM Furqon Romdhani @.***>
wrote:

i also using samsung android 14 and app crash
—
Reply to this email directly, view it on GitHub
https://github.com/vavadiyahiren/xmpp_plugin/issues/115#issuecomment-2163414088,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU77ZNNTNPAVCOW6YMDQKWDZHBWQHAVCNFSM6AAAAABJGVMKQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTGQYTIMBYHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

just please don't push any code in it
On Thu, Jun 13, 2024 at 10:05 AM Danish Rafiq @.***>
wrote:

not a problem use my XMPP package just import
xmpp_plugin:
git:
url: https://github.com/danishrafiqe/chat_state_xmpp.git
ref: main
On Wed, Jun 12, 2024 at 9:04 PM Furqon Romdhani @.***>
wrote:

i also using samsung android 14 and app crash
—
Reply to this email directly, view it on GitHub
https://github.com/vavadiyahiren/xmpp_plugin/issues/115#issuecomment-2163414088,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU77ZNNTNPAVCOW6YMDQKWDZHBWQHAVCNFSM6AAAAABJGVMKQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTGQYTIMBYHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[WFCORE-2531] - Validation of cardinality of attribute groups and object type attributes on PersistentResourceXMLDescription

retest this please!

Failures are unrelated.

OK, TKS. Tests is passing locally, so I was suspecting it was unrelated with my changes.


Include Leap Year Code

Hey, I'm not too sure whether what I did was right. I changed current_max = -368 if it was a leap year. If that's wrong, you can use the function that I used anyway and edit the code to make sure it works.

The problem isn't the maximum. When there's a leap year, there is a 29th day of February. Normally March 1st is the 60th day of the year, but on leap years March 1st is the 61st day of the year.
There should be some way to have March 1st still be Wallpaper number 60, instead of Wallpaper number 61 on a leap year. It's not necessary to allow a user to set a unique wallpaper for February 29th (so it's only shown on leap years) but if you would like to do that somehow, go ahead.

This has been fixed, but thanks for the contribution.


Add phylogeny workflow

We are working with @ekg and @urbanslug on this one.

@urbanslug is getting close with https://github.com/urbanslug/taxophages

@urbanslug is getting close with https://github.com/urbanslug/taxophages

@urbanslug, what are we missing to get to show information (metadata, real/predicted variants, etc...) on the tree?

@urbanslug, what are we missing to get to show information (metadata, real/predicted variants, etc...) on the tree?

Hello @AndreaGuarracino and @pjotrp, just a little bit of customizing the Auspice UI and then also maybe some QC that I'm through with @ekg

Hello @AndreaGuarracino and @pjotrp, just a little bit of customizing the Auspice UI and then also maybe some QC that I'm through with @ekg

Update: I have the workflow here https://github.com/urbanslug/bh20-seq-resource/tree/master/workflows/phylogeny
I now need to figure out dependency management on the host where it'll run.

Update: I have the workflow here https://github.com/urbanslug/bh20-seq-resource/tree/master/workflows/phylogeny
I now need to figure out dependency management on the host where it'll run.

We'll sort the dependencies. Can you do a full PR on this repo?

We'll sort the dependencies. Can you do a full PR on this repo?

Yes, yes for sure 😄 .

Yes, yes for sure 😄 .


fix: updated terraform module and fixed depriciation variables

What :

Updated the Azurerm version from 3.112 to  4.0.0
Added Provider Configuration  version.tf
Fixed attributes like retention policy trust policy and encryption
Removed skip_provider block as it is depreciated

Why :

Dynamic Blocks has been removed in 4.0.0 version
Provider alias was not recognized by Terraform

Terraform Security Scan Failed
Show Output


squid:S2162 -  equals methods should be symmetric and work for subcla…

This pull request is focused on resolving occurrences of Sonar rule squid:S2162

equals methods should be symmetric and work for subclasses
You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid:S2162
Please let me know if you have any questions.
M-Ezzat

Just started reviewing :):rocket:

Thank you very very much!


Option to not produce source maps.

TLDR: This issue is for an option to not produce source maps.
I'm using pika/web for three.js & it's orbit controls:
    "@pika/web": {
        "webDependencies": [
            "three",
            "three/examples/jsm/controls/OrbitControls.js"
        ]
    },

This also produces source map files which are huge and I don't need:
web_modules/
drwxr-xr-x@ 3 owen  staff    96B Jun 15 13:43 three/
-rw-r--r--@ 1 owen  staff   562K Jun 15 12:50 three.js
-rw-r--r--@ 1 owen  staff   1.8M Jun 15 12:50 three.js.map

web_modules/three/examples/jsm/controls:
-rw-r--r--@ 1 owen  staff    10K Jun 15 12:50 OrbitControls.js
-rw-r--r--@ 1 owen  staff    38K Jun 15 12:50 OrbitControls.js.map

I think this comes from the tracer rollup plugin? I'd like an option to not produce source maps.

Sure, I think that makes sense as an opt-in option. Can I ask why you don't want them, if they're free? You're just not using them?

First, let me admit: I am ridiculously minimalist! I don't use workflow tools that require "compiling" my JS before running it. My only workflow tools come in at git commit or npm install/publish time.
So I'm very Vanilla JS, and all my workflow is in npm scripts.
This has little to do with the map thing but it clarifies that I'm, err, different from todays dev in the same way you've discovered .. they are definitely not minimalist! And truth be told, following the crowd, so to speak.
So in the case of maps, I only used them years ago when modules required lots of babel etc. But when modules hit the browsers, I reverted to not needing them. Being lazy, I didn't look for other good reasons to have maps.
It does, however, make sense to be able to un-minify, code. Chrome tries to support "pretty printing" minified code for example. I don't know if the maps help in that case, I couldn't get devtools to pretty print a test minified file.
So, long story short, because I (apparently) don't need them, I made this issue. I'm fine putting this on the back burner, I can git-ignore them if I want to, and your other work is far more important.

I second this request, mainly because I've so rarely needed source maps for third party libraries, because I've rarely needed to debug them. (The bug is 99.99% of the time in my own code, not theirs.)

I don't need source maps because all code is es6 originally. They are huge and they slow down the generation.

This has been merged to master via --no-source-map. Thanks @sdegutis for contributing and everyone for the discussion!

Note: Support has been merged to master but won't be released for a few more days. But, you can try it today via:
npm install http://cdn.pika.dev/@pika/web/master


.Net 6 support.

Hi,
The startup speed of .Net 6 applications has been greatly improved. Is it possible to add support for .Net 6 to solve the problem of slow startup speed?

There is an open pr for .net 6.  How about you go take a look.

@danatcofo
I tried .Net 6 branch, open project prompt, cannot find ElectronNET.WebApp.NET6.csproj，
I tried to manually add and run ElectronNET.CLI project, stuck on the startup page.
ElectronNET.WebApp project run error.

PR are still being checked and the official support will come with the next big update.. but got it to work with the current version without any problems..

@GregorBiswanger Thank you! Can't wait to try out my Electron.NET-powered apps over .NET 6 😃!

Hi @GregorBiswanger  really appreciate your efforts
We are eagerly waiting for the new big update

I think it is ready

Hi @GregorBiswanger ,
Could you kindly share if there is any tentative timeline by when Electron.NET with .NET 6.0 support is planned to be publicly available?
Thanks,
Bhargavi Gowri.

Hi @GregorBiswanger - what is the current state of this issue?
Thx for your work!

🎉🚀 New Electron.NET version 23.6.1 released 🚀🎉
With native Electron 23 and .NET 6 support. Your problem should be fixed here. If you continue to have the problem, please let us know. Please note the correct updating of your API & CLI. Info in the README. Have fun!