Parallelise Acceptance Tests

We are following a pattern of one test per class in our Acceptance Tests and we can customise each one a lot.
Since the whole suite is taking over an hour now, it would be great to try to parallelise them as much as we can.

I'm not convinced yet that having Component Tests and Acceptance Tests that parallel each other with the same level of granularity is the best way to go. I think we should look at making the Acceptance Tests much less granular, which would also have the benefit of making the tests run faster.

That is very true @scottfrederick, reviewing ATs and pulling some down to CTs if we are comfortable now with them should be the way to go.
However, I still see a lot of value on parallelising all of them, especially the ATs. Since they are and will be, always the slowest.
Do you see that as a separate chore to this one?

@AlbertoImpl wasn't this recently completed?

Yes, it was! Thanks @royclarkson


Handle empty 'items' array

Don't show the arrow icon if the 'items' array is empty

Thanks @tonysepia! That's been merged and published to NPM as 2.0.1.


decode thumbnails to colorant array

https://github.com/ashwani-rathee/ExifViewer.jl/pull/3#discussion_r906758222

After digging into the formats a bit, I realize that this is not immediately easy work. Basically we'll need to introduce a more flexible API in JpegTurbo to allow custom tables and parameters, and then add Jpeg compression support in TiffImages.
It's a bit busy here recently so I guess I won't pick this up before Aug.


Maduong/bugfix/282569 the cli should look for a compose file anywhere in the folder (not just at the root)

Verifies docker-compose and docker file exist somewhere in the repo, not just the root

Hi @thegalah, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (maduong). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Previews

What should the previews show?

completed in https://github.com/Stonks3141/ctp-nix/pull/35


Add a simple telegram echo-bot

Codes for an echo-bot.

Thanks for your Contribution.
Keep Contributing.


fix: readme, and testing semantic version releasing

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Order runs by date descending.

Fixes #366.

I do not really like that 1 second delay stuff. Maybe it would be better to populate the grid with the good order to start with. So I would prefer a server side solution.

I totally agree. I replaced this ugly solution by a sorting, but on client side, not on server side.


294 fix dnspython deprecated query method

Coverage decreased (-1.3%) to 98.301% when pulling 0b62db664c0b9a106a9a9508bc2854fd5065cbd7 on 294-change-notes into 2eca4f9486525710f6c72dd80fcddf32525e47ce on dev.

Coverage decreased (-1.3%) to 98.301% when pulling 0b62db664c0b9a106a9a9508bc2854fd5065cbd7 on 294-change-notes into 2eca4f9486525710f6c72dd80fcddf32525e47ce on dev.


unexpected keyword argument 'socket_connect_timeout'

UnixDomainSocketConnection fails if it's given socket_connect_timeout as shown in this issue with celery:
"Invalid Arguments for task test.add: init() got an unexpected keyword argument 'socket_connect_timeout'"
https://github.com/celery/celery/issues/2903

Ya, whoops missed this one. Thanks.


[GSoC] Interactive mode for swift CLI tool ArgumentParser

I don't feel like it's my place to do this but I really want to see this move forward.
This a pr for #449 since everything seems to work. I didn't do the work @KeithBird did. I just open this PR in order to see this feature move forward.
Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

Thanks, @mackoj! This is definitely still in progress, but not ready to merge on main yet. I'll work on putting together a list of things we'll want to get in for the next minor version release.


A bit of cargo-miri cleanup

@bors r+

:pushpin: Commit fb428dfee3252f378f796c7497a8fb29753c795d has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit fb428dfee3252f378f796c7497a8fb29753c795d with merge 9cab7979f8de065ec000a944fdf245cea2103af8...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 9cab7979f8de065ec000a944fdf245cea2103af8 to master...

This condition is useless now

I spent a bit of time figuring out what you mean, only to then realize that you deleted your comment -- which I don't see when going through my inbox. Please post a follow-up saying "never mind" in those cases, that would have saved me some unnecessary work. :)


sdl: handle adaptive vsync (-1) in GLGetSwapInterval

My system uses adaptive vsync by default, which means SDL_GL_GetSwapInterval returns -1, which go-sdl's errorFromInt() treated as an error. It couldn't get an error from SDL so it gave me "Unknown error (probably using old version of SDL2 and the function called is not supported?)"
(Note that SDL_GL_SetSwapInterval is correctly mapped, and a -1 there means an actual error)

Thank you @Lundis for the PR! I will merge this as well.


Fix selection includes SVG style and data-testid value

Details

Doing a text selection potentially includes the SVG style text and also the data-testid value if it starts with _.
Fixed Issues

$ https://github.com/Expensify/App/issues/29921
PROPOSAL: https://github.com/Expensify/App/issues/29921#issuecomment-1781389124
Tests

Web/Desktop/mWeb
Avatar SVG
Same as QA Steps
Copy to clipboard icon
On dev, copy to clipboard icon data-testid is SvgCopy Icon but we need the id to start with _, so

Manually set the data-testid to _a Icon in Icon/index.js.
The rest of the steps are the same as QA Steps

Android/iOS
Can't do text selection

[x] Verify that no errors appear in the JS console

Offline tests

Same as Test steps
QA Steps

Web/Desktop/mWeb
Avatar SVG

Open any chat with a default avatar
Do a text selection on the chat header by dragging it from the right of the title to the left of the avatar
Copy it
Paste it on any text field, except the composer
Verify the pasted text doesn't contain some random style text

Copy to clipboard icon

Open any chat
Press the header to open the profile page
Do a text selection on the email by dragging it from the left of the email to the right of the copy icon
Copy it
Paste it on the composer
Verify the pasted text doesn't contain <_a Icon> text

Android/iOS
Can't do text selection

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Avatar SVG
https://github.com/Expensify/App/assets/50919443/7224ae68-a1d6-4447-8ad4-465d101a5087
Copy to clipboard icon
https://github.com/Expensify/App/assets/50919443/95d26e82-8b85-4ce8-aa25-a189eb68225d

iOS: Native

iOS: mWeb Safari

Avatar SVG
https://github.com/Expensify/App/assets/50919443/7ac3b2c8-349b-4418-8d60-b6e7e0c591df
Copy to clipboard icon
https://github.com/Expensify/App/assets/50919443/979576a9-b3cf-4e49-8237-dbd3926dce98

MacOS: Chrome / Safari

Avatar SVG
https://github.com/Expensify/App/assets/50919443/f7f54a8c-2ab6-43b9-a12b-965b07771848
Copy to clipboard icon
https://github.com/Expensify/App/assets/50919443/b03216a2-1588-42b5-94fc-da67942b6ffa

MacOS: Desktop

Avatar SVG
https://github.com/Expensify/App/assets/50919443/937a29dd-6651-4adc-b77b-0e70d6845c59
Copy to clipboard icon
https://github.com/Expensify/App/assets/50919443/ad0ceca3-be93-49c0-bd18-adbcdd87e770

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.94-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.94-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.95-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Feature request: "incompatibility" caveat

Description of feature/enhancement
The stanza would be true/false. It should include a link that maintainers provide to e.g. documentation, release notes, upgrade guides etc.
If set to true, installation of the cask requires user confirmation, before proceeding.
Justification
some applications write data in application specific formats to the users disc. That means that every now and then an update comes along that requires user intervention in order for the new app to work properly with data written by the old app.
Example use case
The result would look something like this:
$ brew cask install awesome-app …

awesome-app 3.8 is NOT backwards compatible.
If you want to use this app with data created by older versions, see:
http://www:awesome-app.com/release-notes.html before continuing.

$ Continue with installation (Y/n):

Alternatively the caveat could be restricted to brew cask upgrade/reinstall instead of install

This falls within the scope of “not a discoverability service”:

users are expected to have reasonable knowledge about the apps they’re installing through us before doing so.

You proposed solution wouldn’t work for your problem. A stanza alone is insufficient for this.
Picture this: we’re both at version 3.9 and a backwards-incompatible 4.0 is released with the stanza. You upgrade by I don’t (I missed it). Then a version 4.1 is released. Do we remove the stanza? Because if you don’t, you’ll still have it there and get the same (wrong) warning. But if you do, I won’t get the warning when I upgrade.
Then we have to enter the realm of making the stanza accept a version number, but then we change the format, ….
We toyed with a similar idea in the past. It’s not worth the trouble.


runtime error: invalid memory address or nil pointer dereference when running GetStream

GetStream fails (worked yesterday evening).
The issue seems to be related with the goja package as I am getting the following: [panic]:\ngithub.com/dop251/goja.(*Runtime).toReflectValue
stacktrace:
github.com/dop251/goja.(*Runtime).toReflectValue
        /home/eyal/projects/go/pkg/mod/github.com/dop251/goja@v0.0.0-20220516123900-4418d4575a41/runtime.go:1945
    github.com/dop251/goja.(*Runtime).ExportTo
        /home/eyal/projects/go/pkg/mod/github.com/dop251/goja@v0.0.0-20220516123900-4418d4575a41/runtime.go:2217
    github.com/kkdai/youtube/v2.evalJavascript
        /home/eyal/projects/go/pkg/mod/github.com/kkdai/youtube/v2@v2.7.14/decipher.go:138
    github.com/kkdai/youtube/v2.playerConfig.decodeNsig
        /home/eyal/projects/go/pkg/mod/github.com/kkdai/youtube/v2@v2.7.14/decipher.go:125
    github.com/kkdai/youtube/v2.(*Client).decryptNParam
        /home/eyal/projects/go/pkg/mod/github.com/kkdai/youtube/v2@v2.7.14/decipher.go:75
    github.com/kkdai/youtube/v2.(*Client).unThrottle
        /home/eyal/projects/go/pkg/mod/github.com/kkdai/youtube/v2@v2.7.14/decipher.go:62
    github.com/kkdai/youtube/v2.(*Client).GetStreamURLContext
        /home/eyal/projects/go/pkg/mod/github.com/kkdai/youtube/v2@v2.7.14/client.go:321
    github.com/kkdai/youtube/v2.(*Client).GetStreamURL
        /home/eyal/projects/go/pkg/mod/github.com/kkdai/youtube/v2@v2.7.14/client.go:315
    github.com/kkdai/youtube/v2.(*Client).GetStreamContext
        /home/eyal/projects/go/pkg/mod/github.com/kkdai/youtube/v2@v2.7.14/client.go:228
    github.com/kkdai/youtube/v2.(*Client).GetStream

Same here:
19:16:50 219 bin took 4s ➜ ./youtubedr download 'https://www.youtube.com/watch?v=MeaW1QRugFk'
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x14803de]

goroutine 1 [running]:
github.com/dop251/goja.(*Runtime).toReflectValue(0xc00028ae00, {0x0?, 0x0?}, {0x15fde40?, 0xc000286120?, 0xc000286120?}, 0xc000286148)
	/Users/lcs/go/pkg/mod/github.com/dop251/goja@v0.0.0-20220214123719-b09a6bfa842f/runtime.go:1925 +0x23e
github.com/dop251/goja.(*Runtime).ExportTo(0xc00028ae00?, {0x0, 0x0}, {0x15e0fa0?, 0xc000286120?})
	/Users/lcs/go/pkg/mod/github.com/dop251/goja@v0.0.0-20220214123719-b09a6bfa842f/runtime.go:2197 +0x185
github.com/kkdai/youtube/v2.evalJavascript({0xc0000ea900, 0x812}, {0xc0004f058c, 0x10})
	/Users/lcs/Developer/personal/youtube/decipher.go:138 +0xcc
github.com/kkdai/youtube/v2.playerConfig.decodeNsig({0xc000ba4000?, 0xc000284f00?, 0x17a98a4?}, {0xc0004f058c, 0x10})
	/Users/lcs/Developer/personal/youtube/decipher.go:125 +0x4a
github.com/kkdai/youtube/v2.(*Client).decryptNParam(0xc0001a6de0, {0x0?, 0xc0000e64f6?}, {0xc000ba4000?, 0x1d156d?, 0x218000?}, 0xc000284f00)
	/Users/lcs/Developer/personal/youtube/decipher.go:75 +0x11d
github.com/kkdai/youtube/v2.(*Client).decipherURL(0x8?, {0x17b4138, 0xc000036080}, {0x7ff7bfeff8f5, 0xb}, {0xc0000e6480, 0x471})
	/Users/lcs/Developer/personal/youtube/decipher.go:40 +0x33a
github.com/kkdai/youtube/v2.(*Client).GetStreamURLContext(0x203000?, {0x17b4138?, 0xc000036080?}, 0x106196e?, 0x1019c28?)
	/Users/lcs/Developer/personal/youtube/client.go:329 +0x4b
github.com/kkdai/youtube/v2.(*Client).GetStreamURL(...)
	/Users/lcs/Developer/personal/youtube/client.go:315
github.com/kkdai/youtube/v2.(*Client).GetStreamContext(0xc0001a6de0, {0x17b4138, 0xc000036080}, 0x0?, 0xc0000003c0)
	/Users/lcs/Developer/personal/youtube/client.go:228 +0x5c
github.com/kkdai/youtube/v2/downloader.(*Downloader).videoDLWorker(0xc000042540?, {0x17b4138?, 0xc000036080?}, 0xc000286300, 0x100e765?, 0x90?)
	/Users/lcs/Developer/personal/youtube/downloader/downloader.go:153 +0x4e
github.com/kkdai/youtube/v2/downloader.(*Downloader).Download(0xc0001a6de0, {0x17b4138, 0xc000036080}, 0xc00038c000, 0xc0000003c0, {0x0, 0x0})
	/Users/lcs/Developer/personal/youtube/downloader/downloader.go:56 +0x25f
main.download({0x7ff7bfeff8d5?, 0x0?})
	/Users/lcs/Developer/personal/youtube/cmd/youtubedr/download.go:54 +0x170
main.glob..func1(0x1cf0f00?, {0xc00007dec0?, 0x1?, 0x1?})
	/Users/lcs/Developer/personal/youtube/cmd/youtubedr/download.go:20 +0x2a
github.com/spf13/cobra.(*Command).execute(0x1cf0f00, {0xc00007dea0, 0x1, 0x1})
	/Users/lcs/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:860 +0x663
github.com/spf13/cobra.(*Command).ExecuteC(0x1cf1180)
	/Users/lcs/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:974 +0x3b4
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/lcs/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:902
main.main()
	/Users/lcs/Developer/personal/youtube/cmd/youtubedr/main.go:9 +0x25
19:17:00 219 bin took 4s ❯

I added back the '=' and now it works:
19:28:51 219 youtube on  master +1 -1 ➜ go build ./cmd/youtubedr
19:28:57 219 youtube on  master +1 -1 took 2s ➜ ./youtubedr download 'https://www.youtube.com/watch?v=MeaW1QRugFk'
192.36 MiB / 192.36 MiB 100 % [==============================================================] 0s ] 4.27 MiB/s
19:29:59 219 youtube on  master +1 -1 took 56s ➜ diff decipher.go decipher.go.orig
132c132
< 	_, err := vm.RunString(myName + "=" + jsFunction)
---
> 	_, err := vm.RunString(myName + jsFunction)
19:30:10 219 youtube on  master +1 -1 ❯

Following @choonsiong solution, seems that the last commit need to be reverted.

I added back the '=' and now it works:
19:28:51 219 youtube on  master +1 -1 ➜ go build ./cmd/youtubedr
19:28:57 219 youtube on  master +1 -1 took 2s ➜ ./youtubedr download 'https://www.youtube.com/watch?v=MeaW1QRugFk'
192.36 MiB / 192.36 MiB 100 % [==============================================================] 0s ] 4.27 MiB/s
19:29:59 219 youtube on  master +1 -1 took 56s ➜ diff decipher.go decipher.go.orig
132c132
< 	_, err := vm.RunString(myName + "=" + jsFunction)
---
> 	_, err := vm.RunString(myName + jsFunction)
19:30:10 219 youtube on  master +1 -1 ❯

Strange that yesterday it complained about it because it already had the = in it, causing a similar problem...

I added back the '=' and now it works:
19:28:51 219 youtube on  master +1 -1 ➜ go build ./cmd/youtubedr
19:28:57 219 youtube on  master +1 -1 took 2s ➜ ./youtubedr download 'https://www.youtube.com/watch?v=MeaW1QRugFk'
192.36 MiB / 192.36 MiB 100 % [==============================================================] 0s ] 4.27 MiB/s
19:29:59 219 youtube on  master +1 -1 took 56s ➜ diff decipher.go decipher.go.orig
132c132
< 	_, err := vm.RunString(myName + "=" + jsFunction)
---
> 	_, err := vm.RunString(myName + jsFunction)
19:30:10 219 youtube on  master +1 -1 ❯

Strange that yesterday it complained about it because it already had the = in it, causing a similar problem...

Indeed, probably need help from other who is more familiar with the codebase to check the reason of previous error.

I've created the fix-decipher branch that stores artifacts for debugging purposes. Unfortunately I am not able to reproduce the issue at the moment.
Please check out the branch and run make test-integration. Does anything fail?

I've created the fix-decipher branch that stores artifacts for debugging purposes. Unfortunately I am not able to reproduce the issue at the moment.
Please check out the branch and run make test-integration. Does anything fail?

Looks fine
19:47:53 217 youtube on  HEAD took 24s ➜ git branch
* (HEAD detached at origin/fix-decipher)
  master
19:48:25 217 youtube on  HEAD ➜ make test-integration
mkdir -p output
rm -f output/*
ARTIFACTS=output go test -race -covermode=atomic -coverprofile=coverage.out -tags=integration ./...
ok  	github.com/kkdai/youtube/v2	20.968s	coverage: 79.3% of statements
?   	github.com/kkdai/youtube/v2/cmd/youtubedr	[no test files]
ok  	github.com/kkdai/youtube/v2/downloader	5.046s	coverage: 85.0% of statements
19:48:51 217 youtube on  HEAD took 22s

I've just merged it into master.


Implement native histograms

Prometheus now supports a new "Native Histograms" datatype. We should implement this here.

@SuperQ Do you know if the text version of "native histograms" has been finalised? I would like to implement in the pull exporter for opentelemetry-js.

Sadly, native histograms can only be exposed through protobuf for now, which is not supported in the Python client.

Hello any following along here. I am working on a design doc for text based support for native histograms: https://docs.google.com/document/d/1qoHf24cKMpa1QHskIjgzyf3oFhIPvacyJj8Tbe6fIrY/edit. It is still preliminary, and I plan to share with the broader prometheus-dev (and OpenMetrics) communities soon. Feel free to comment now though!

Hi,
Since this (plain text native histograms) is not finalized or implemented yet, I'm looking at trying to implement protobuf support in the python client.
Anyway, there are two ways of handling proto types in the client, and I figured this was as good a place to ask as any:

keep all the internal structure as is, and just do an edge conversion from Sample to protobuf in a generate_latest
do what golang does, and store all samples in the registry as protobuf structs, and only convert them to plain text at the edge

The first one is the least amount of changes, but also has to deal with re-aggregating samples that have been "split" for plain text reasons (things like _created).
The second is much more involved, but has the benefit of being consistent with the golang client. I would also assume it's overall more performant but I might be wrong there.
Thoughts?
PS: Happy to move this into it's own issue or discussion thread (or wherever you want to point me at)


Update request: Joplin-Desktop 2.14.17 → 3.0.14

Package name: Joplin
Latest released version: 3.0.14

Current version on the unstable channel: 3.0.15
Current version on the stable/release channel: 2.14.17

[x ] Checked the nixpkgs pull requests

Notify maintainers
@HugoReeves
@qjoly

Note for maintainers: Please tag this issue in your PR.
I cannot synchronize with the joplin server I self-host as you can see in the screenshot. It says I must have version 3.0 minimum.

I think the update to Joplin 3.x will not be backported (it is a breaking change). In the meantime you can switch to the unstable channel or wait for NixOS 24.11.

I think the update to Joplin 3.x will not be backported (it is a breaking change). In the meantime you can switch to the unstable channel or wait for NixOS 24.11.

Do you mind elaborating on why it's a breaking change?

It looks like Version 3.x will only synchronize with 3.x servers. Therefore it will break anyone running a 2.x server.


DarkMode custom css Vue-Multiselect vue3 (Tailwind)

Hi is there a way to customize the darkmode that is now integrated in laravel using the possibility of modification as per the documentation? or if there is a way I ask if someone has ever had this need or problem.
Thank you

Here is little hack to use multi-select in both light and dark-mode with tailwind.
/* in your app.scss of laravel */
.multiselect .multiselect__tags {
    @apply dark:bg-gray-900 dark:border-gray-700 dark:text-gray-300
}

.multiselect__tags .multiselect__single {
    @apply dark:bg-gray-900
}

.multiselect .multiselect__input {
    @apply dark:bg-gray-900
}

.multiselect .multiselect__content-wrapper {
    @apply dark:bg-gray-900 dark:text-gray-300 dark:border-gray-800
}

.multiselect .multiselect__option--selected {
    @apply dark:bg-gray-700 dark:text-gray-300
}

any tips on changing the group tags also ?


Support for the 4-gang US version

Hey, are you guys planning on adding support for the 4-gang US version of the TX Ultimate?

Closing as my PR was merged https://github.com/SmartHome-yourself/sonoff-tx-ultimate-for-esphome/pull/27


Thin light bar on top of window

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
A thin, transparent bar shows up
To Reproduce
Steps to reproduce the behavior:
start runlite
Expected behavior
no bar to be there
Screenshots

Environment (please complete the following information):

OS:linux

What DE/WM are you using?

i3-gaps with picom for composition

Can you post a screenshot of all the settings under the Windoow Settings group of RuneLite's settings?

According to another admin, they use i3-gaps without issue, so this is likely a compositor or JVM bug.

I'm currently using i3-gaps and picom too, this definitely seems like an issue with either your configs or the JVM.
As it appears for me:

This looks like a bug in i3 that picom is making visible. See yshui/picom#547. You can work around this by setting frame-opacity = 1.0 in your ~/.config/picom/picom.conf

@abextm thanks! I actually have no frames, so I could see why this might bug out.
I just noticed that the other day and worked it out, didn't even think of runellite I'll give it a shot!


document debugging with allocation tests

Motivation:
The tooling around the allocation counter tests is pretty opaque and
also not easy to use.
Modifications:
Document what interested folks should know.
Result:
More people will be able to debug allocations in SwiftNIO.

sorry guys,  this is still a bit rough but I wanted to get something out ASAP for @2bjake :)

thanks so much @Lukasa and @glbrntt for the reviews, took all feedback.

Very nice, it all makes sense to a newbie.


Research private stamp testing using the latest Host and worker bits from the nightly build

Research private stamp testing using the latest Host and worker bits from the nightly build.
We will need these details for the test plan review which will take place at the end of August 2020.
Here is some additional details from the workitem (https://github.com/pragnagopa/azure-functions-integration-tests/issues/1) that @pragnagopa created on her repo.
Please reach out to her in case you have any questions on this area.
Here is a potential flow to get started, but again, I could be missing important details.

Pull Functions Host bits from CI dev nightly build (we can get these from our internal prerelease feed)
Prepare Host bits for private stamp (there might be an additional step between 1 and 2
Upload to blob via Update RU feed for Windows
Pull latest RU feed
Update RapidUpdateFeed.xml and upload host.zip to the blob storage used by the private stamp
Kick off test runs on each language worker - with FunctionAppURLs on private stamp

Once you have this information, please add it to the test doc.

Hi @madelinegordon -- For this work item, could you please write down the the steps to do this?
Once you have verified the steps, please start prototyping a PowerShell script to automate this process.

Update 12/14/20: The only thing left is to update the OneNote.


⚠ Roblox site has degraded performance

In f0df71e, Roblox site (https://www.roblox.com/) experienced degraded performance:

HTTP code: 502
Response time: 27554 ms

Resolved: Roblox site performance has improved in a4e8256 after 10 minutes.


Review Proposed Structure for C4Image

Review C4ImageProtocol.swift which proposes a structure for C4Image.
Plan is to convert methods from protocol, then remove the protocol file.

Looks good


Midi Time Code Events

Hi,
I'm new to C# and trying to figure out how the Midi Time Code works.
I use _inputDevice.EventReceived and _inputDevice.MidiTimeCodeReceived EventHandler to receive Full/Quarter Frame MTC events.
When I try to use them together, only _inputDevice.EventReceived works.
Sorry for the stupid question, but why is _inputDevice.MidiTimeCodeReceived not working in this case?
_inputDevice.MidiTimeCodeReceived += OnMidiTimeCodeReceived; // MTC Quarter Frame Event
_inputDevice.EventReceived += OnEventReceived; // MTC SysEx Full Frame Event

Input device is listening for events. Press any key to exit...
01/03/2021 16:04:12 MTC SysEx Full Frame: [1:53:11:13]
01/03/2021 16:04:12 MTC SysEx Full Frame: [1:2:44:24]

Separately each EventHandler works great
_inputDevice.MidiTimeCodeReceived += OnMidiTimeCodeReceived; // MTC Quarter Frame Event
//     _inputDevice.EventReceived += OnEventReceived; // MTC SysEx Full Frame Event

Input device is listening for events. Press any key to exit...
01/03/2021 16:11:49 MTC Quarter Frame: [0:29:13:27]
01/03/2021 16:11:49 MTC Quarter Frame: [0:29:13:29]

//     _inputDevice.MidiTimeCodeReceived += OnMidiTimeCodeReceived; // MTC Quarter Frame Event
_inputDevice.EventReceived += OnEventReceived; // MTC SysEx Full Frame Event

Input device is listening for events. Press any key to exit...
01/03/2021 16:31:14 MTC SysEx Full Frame: [0:17:13:14]
01/03/2021 16:31:14 MTC SysEx Full Frame: [1:18:44:21]

using System;
using Melanchall.DryWetMidi.Devices;
using Melanchall.DryWetMidi.Core;
namespace TimeCodeGen
{
    class Program
    {
        private static InputDevice _inputDevice;
        static void Main(string[] args)
        {
            _inputDevice = InputDevice.GetByName("testport");
            _inputDevice.RaiseMidiTimeCodeReceived = true;
            _inputDevice.MidiTimeCodeReceived += OnMidiTimeCodeReceived; // MTC Quarter Frame Event
            _inputDevice.EventReceived += OnEventReceived; // MTC SysEx Full Frame Event
            _inputDevice.StartEventsListening();
            Console.WriteLine("Input device is listening for events. Press any key to exit...");
            Console.ReadKey();
            if (_inputDevice != null) { }
            _inputDevice.Dispose();
        }
        // MTC SysEx Full Frame Event
        private static void OnEventReceived(object sender, MidiEventReceivedEventArgs e)
        {
            int ffHours, ffMinutes, ffSeconds, ffFrames;
            var sysEvent = e.Event as NormalSysExEvent;
            byte[] sysData = sysEvent.Data;
            ffHours = sysData[4] - 96;
            ffMinutes = sysData[5];
            ffSeconds = sysData[6];
            ffFrames = sysData[7];
            Console.WriteLine(DateTime.Now + " MTC SysEx Full Frame: [" + ffHours + ":" + ffMinutes + ":" + ffSeconds + ":" + ffFrames + "]");
        }
        // MTC Quarter Frame Event
        private static void OnMidiTimeCodeReceived(object sender, MidiTimeCodeReceivedEventArgs tc)
        {
            Console.WriteLine(DateTime.Now + " MTC Quarter Frame: [" + tc.Hours + ":" + tc.Minutes + ":" + tc.Seconds + ":" + tc.Frames + "]");
        }
    }
}

Hi,
Are you sure your device always send both MTC and SysEx events? Please show me what events arriving without additional processing (please comment _inputDevice.MidiTimeCodeReceived += OnMidiTimeCodeReceived;):
private static void OnEventReceived(object sender, MidiEventReceivedEventArgs e)
{
    Console.WriteLine(e.Event);
}

Capture as many events as you can to see that both MTC and SysEx (which are events of different types) are sent by the device.

Yes, I generate both events via Vegas 14 Pro Edit (full-frame messages called for cursors position changes), MIDI OX shows the received both events correctly.
I uploaded logs to my github:
https://github.com/seejkee/MidiTimeCodeEvents/
just modified a bit for readability
Console.WriteLine(DateTime.Now + " sysex event: " + e.Event);

Thanks, but we need to capture events again. Please modify your WriteLine to this:
Console.WriteLine($"[{DateTime.Now}] {e.Event}");

Because those events are not sysex ones. Also I see in your log lines like this:
01/03/2021 22:53:19 MTC Quarter Frame: [2:31:56:22]

So you didn't comment _inputDevice.MidiTimeCodeReceived += OnMidiTimeCodeReceived;. Please comment it. We need to see raw MIDI events.

So you didn't comment _inputDevice.MidiTimeCodeReceived += OnMidiTimeCodeReceived;. Please comment it. We need to see raw MIDI events.
I'm sorry that, I fixed it now
https://raw.githubusercontent.com/seejkee/MidiTimeCodeEvents/main/console_Out_events.txt

I'm sure that shown events are not the same as you got when you opened the issue. In your code you have the line:
var sysEvent = e.Event as NormalSysExEvent;

But in your log there are a lot of events that are not NormalSysExEvent so your program will crash on sysEvent.Data. Use this code:
// MTC SysEx Full Frame Event
private static void OnEventReceived(object sender, MidiEventReceivedEventArgs e)
{
    int ffHours, ffMinutes, ffSeconds, ffFrames;
    var sysEvent = e.Event as NormalSysExEvent;
    if (sysEvent == null)
        return;

    byte[] sysData = sysEvent.Data;
    ffHours = sysData[4] - 96;
    ffMinutes = sysData[5];
    ffSeconds = sysData[6];
    ffFrames = sysData[7];
    Console.WriteLine(DateTime.Now + " MTC SysEx Full Frame: [" + ffHours + ":" + ffMinutes + ":" + ffSeconds + ":" + ffFrames + "]");
}
// MTC Quarter Frame Event
private static void OnMidiTimeCodeReceived(object sender, MidiTimeCodeReceivedEventArgs tc)
{
    Console.WriteLine(DateTime.Now + " MTC Quarter Frame: [" + tc.Hours + ":" + tc.Minutes + ":" + tc.Seconds + ":" + tc.Frames + "]");
}

So please uncomment
_inputDevice.MidiTimeCodeReceived += OnMidiTimeCodeReceived; // MTC Quarter Frame Event
_inputDevice.EventReceived += OnEventReceived; // MTC SysEx Full Frame Event

and check again.

    if (sysEvent == null)
        return;

@melanchall Thank you very much! It's worked :)


Added streaming to fastq chunking step

Jenkins, test this please

Jenkins, test this please

Jenkins, test this please

Jenkins, test this please

Jenkins, test this please

Jenkins, test this please


derive_var_trtsdtm - user feedback

In the adsl workflow (https://roche-gsk.github.io/admiral/articles/adsl.html) derive_var_trtsdtm appends a time_stamp of 00:00 this shows in the console but not in the dataset. Albeit benign is this designed?
https://myteams.gsk.com/_api/v2.1/drives/b!FNNldQ__A0WRKCVMrqgAMmTBDGe-709BnN0VCBVHDh9cL86DlG5iR5vuDeaZN8ay/items/01V5Q7RQEFQAQHLRLPKRCIVTNTCPLL4DJ5/thumbnails/0/c3000x2000/content?prefer=noredirect%2Cclosestavailablesize&cb=1&s=L3NpdGVzL0FkbWlyYWwvTGlzdHMvYWRtaXJhbCBJc3N1ZSB0cmFja2VyfEltYWdlc3wxMA

@kabis-ops the comment you provided seems to discuss a different issue. I thought this issue was on the date not fully being printed in the dataset when it's midnight. I might be missing something here

Hi @teckla-gsk, you are right these are different issues but they are all related to the user feedback on derive_var_trtsdtm: that's why it is included here.
The midnight issue is now corrected (thought we may still have this issue with time zone), but the documentation of the function should be updated as per the 1st bullet.
And regarding the 2nd bullet, I guess we need to discuss whether we should impute partial dates by default in the function even if the filter parameter provides options to filter on complete dates?
@bundfussr , @aehmann-gsk , @thomas-neitmann - what do you think?
The derive_var_trtedtm will need to be updated in the same way.

I think we should add parameters (date_imputation and time_imputation) to specify the imputation. Then it is clear from the call whether imputation is done or not. I am not sure which default we should use. Maybe no default?
There are more issue regarding these functions:

If imputation is done, the imputation flags need to be added as well. (We need to rename the functions then.)
In derive_var_trtedtm() the imputation must be done before the last observation is selected.
The default for filter_ex is Roche specific. Should we provide no default value to force the user to think about it?

From Questions and Comments discussion on Dec 13th, 2021 - this functionality can be incorporated in the enhancement of derive_var_lstalvdt to be derive_var_extreme_dt(m)


Mock doesn't work after setUpPyfakefs

After I run a fake_filesystem_unittest.TestCase with the self.setUpPyfakefs() method, unittest.mock doesn't seem to work correctly in subsequent test cases.
Here is an example that reproduces the issue:
import os
import unittest.mock

from pyfakefs import fake_filesystem_unittest

class TestFakeFsUnittest(fake_filesystem_unittest.TestCase):
    def setUp(self):
        print('{} Before setUpPyfakefs: {}'.format(self.__class__.__name__,
                                                   os.path))
        self.setUpPyfakefs()
        print('{} After setUpPyfakefs: {}'.format(self.__class__.__name__,
                                                  os.path))

    def test_none(self):
        pass

class TestMockOsPath(unittest.TestCase):
    def test_rename(self):
        print('{} before mock: {}'.format(self.__class__.__name__,
                                          os.path))
        with unittest.mock.patch('os.path'):
            print('{} after mock: {}'.format(self.__class__.__name__,
                                             os.path))

When the TestFakeFsUnittest runs first, I get:
TestFakeFsUnittest Before setUpPyfakefs: <module 'ntpath' from 'C:\\pyenv\\dev36\\lib\\ntpath.py'>
TestFakeFsUnittest After setUpPyfakefs: <pyfakefs.fake_filesystem.FakePathModule object at 0x000001F8E59645C0>
TestMockOsPath before mock: <module 'ntpath' from 'C:\\pyenv\\dev36\\lib\\ntpath.py'>
TestMockOsPath after mock: <module 'ntpath' from 'C:\\pyenv\\dev36\\lib\\ntpath.py'>

But if TestMockOsPath runs first (e.g. by renaming TestFakeFsUnittest to be alphabetically after) I get:
TestMockOsPath before mock: <module 'ntpath' from 'C:\\pyenv\\dev36\\lib\\ntpath.py'>
TestMockOsPath after mock: <MagicMock name='path' id='2650908079776'>
TestZFakeFsUnittest Before setUpPyfakefs: <module 'ntpath' from 'C:\\pyenv\\dev36\\lib\\ntpath.py'>
TestZFakeFsUnittest After setUpPyfakefs: <pyfakefs.fake_filesystem.FakePathModule object at 0x0000026936764E10>

That's interesting - I could reproduce it. I didn't understand it yet (seems to be some module caching issue), and the obvious workaround is to put such tests into separate files, but I will have another look later.

Having the test in separate files doesn't help (at least when using a test suite to run all tests). I created the above example as the simplest reproduction, but I originally discovered the issue from changing one of my tests to use the setUpPyfakefs call, and having tests in another module fail.

Hm, ok, you are right - this won't help if this a module caching issue. One (ugly) way to avoid this is to import os inside the test -  but there has to be a better way. I will probably have another look tomorrow.

Fixed by @absolutelyNoWarranty in #336.


Update casper

Move CI from circleCI to github actions
Update zxlib
Update zemu
Update SDK
Improvements from code review

Disable circleci, we can ignore that


[RELEASE] Version extension

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#1708 5aa6498a3 Thanks @aulneau! - This update adds the global variable VERSION to all cache keys for any data that is persisted in local storage. This makes it so when the wallet updates, there isn't any leaking between versions and avoids using possibily outdated/stale data.

@aulneau with the VERSION variable, will users have to re-authenticate entirely with their Secret Key upon (automatic) upgrade each time? Or simply re-enter their passwords as already the case?
Are there any other UX effects to introducing this variable for caching?

@markmhx this is only for the cached API call data, not user/wallet data. UX remains the same.


Making everything more useful

Moved everything around and added Video model. Allows for easier manipulation rather than dealing with Runner directly.

Fixes #16


KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API

https://issues.apache.org/jira/browse/KAFKA-13821
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks for the contribution @tang7526!

@vvcephei | @jeqo for a second pair of eyes

Merged #12139 into trunk

Thanks, @tang7526 for the contribution!


app is closed

Same seconds after leaving the app I  get a popup with the information that the app is closed because of a problem and I should wait for a new version to install .
I just have had a look on my medication and did no changes in the app before. This happens now every day .
I cannot find the Problem.
Do others have the same issue ?

Which version are you using? Have you tried restarting your phone?

Thank you for quick reaction !
Restart did not solve the Problem, I use  Fdroid repository Version 1.5.1.

Ok, that explains it: there was an issue introduced with v1.5.1 which caused crashes. v1.5.2 fixes it, but this may take a few days to be rolled out to F-Droid - unfortunately, I cannot influence that...

Ok , thank you!

So v1.6.0 is now active on F-Droid, but they have a tremendous timing in picking just the bad releases: This version crashes when a reminder is being created. So wait for v1.6.1 to try again.
Sorry for the inconvenience, I will work on my testing coverage to make sure future app updates will be more stable!
I will keep this issue open until v1.6.1 is available on F-Droid.

v1.6.1 is now available on F-Droid


Users can now delete git branches

Description
Users can now delete branches in the repository view by right clicking on a selected branch.
Users are not allowed to delete their currently used branch. As pre-caution we disable the delete function if the current projects selected git repo is that of the selected branch from the repository view.
Related Issue

NONE

Checklist

[X] I read and understood the contributing guide as well as the code of conduct
[X] My changes generate no new warnings
[X] My code builds and runs on my machine
[X] I documented my code
[X] Review requested

Screenshots

For some reason the toolbar thing acts weirdly without a git repo. I don't think that this is something caused by your PR but since you're working in the area of branches here it might be good to fix this.

When i git init in a folder there's this error. Might be related to the git client not updating the current branch.

For some reason the toolbar thing acts weirdly without a git repo. I don't think that this is something caused by your PR but since you're working in the area of branches here it might be good to fix this.

Should be a next pr instead

When i git init in a folder there's this error. Might be related to the git client not updating the current branch. If i restart AE and go to the repositories navigator the same thing happens.

Yes because your trying to index github branches when there is none. We should do state management on the repos also. A next pr


Get macroblock information

Is there any way to get macroblock information of frame with pyav?
If it impossible, is there any another way to get motion vector.
I've based on http://www.princeton.edu/~jiasic/cos435/motion_vector.c

Possible: yes. Currently implemented: no.
I'm personally unfamiliar with these macroblocks and use of motion vectors in the library. I see the motion-related fields of AVFrame getting used by a few codecs, and some motion-specific files (e.g. motion_est.c. Can you tell me any more about the use case, where I might tend to find files with motion vectors, etc.?

I intend to use them for advanced shot\scene detection as a part of NDVR-problem (Near Duplicate Video Retrieval). More over, MVs (and Optical Flow) are very interesting features for NDVR itself. Surely, I can get it from frames (http://opencv-python-tutroals.readthedocs.org/en/latest/py_tutorials/py_video/py_lucas_kanade/py_lucas_kanade.html), but many videos already have this information.

This link helped me greatly.
Play a video with macroblock types overlaid:
ffplay -debug vis_mb_type INPUT

Play a video with motion vectors overlaid:
ffplay -flags2 +export_mvs INPUT -vf codecview=mv=pf+bf+bb

Looks like this gets into the realm of code deprecated and removed from libav, and then deprecated from ffmpeg. See this discussion.

PR #106 is about dealing with these deprecated structure members.

Motion vector support is coming from side data soon™. See #558

Is it possible to retrieve the motion vectors without decoding the actual frame?


Broken link

The link on the Train Tab to learn more about classifiers does not work. When clicked, it says "Javascript:void(0);"

The proper link is this one: http://www.ibm.com/smarterplanet/us/en/ibmwatson/developercloud/doc/visual-recognition/overview.shtml

Thanks @kathrynmcelroy! I've got it fixed in the code, we'll update the app shortly.


feature request: Reverse tunneling

Hi,
I would be really interested in implementing the reverse tunneling feature. Could you provide me with some minimal guidance? What are the major difficulties you have mapped so far, how would the high-level object's interaction look like, etc?
Cheers,

Should not be hard to add, but it has never been requested more than once.
and as you can already do it in a wonky way https://github.com/erebe/wstunnel/issues/19
I never spent time on this feature.
P.s: I am starting a new job, so i doubt i will implement it in the near future
Hope it helps

Should not be hard to add, but it has never been requested more than once.
and as you can already do it in a wonky way https://github.com/erebe/wstunnel/issues/19
I never spent time on this feature.
P.s: I am starting a new job, so i doubt i will implement it in the near future
Hope it helps

This would be a great addition for wstunnel :)
Maybe someone wants to start a pull request!

It is done in release https://github.com/erebe/wstunnel/releases/tag/v8.0.0
Let me know if it is nok for you


Add info about number of deleted files, db delete failure

Add information about number of deleted files for folder deletion
Warn about the case where the files are deleted in s3 but not in db

Before submitting a PR to the dev branch:

[x] Tests passing
[X] Black formatting
[X] Rebase/merge the dev branch
[x] Note in the CHANGELOG

Additional checks before submitting a PR to the master branch:

Change version in setup.py (?)

@zishanmirza  has also approved


Add functionality to directly interact with BigQuery

methods like pandas read_gbq can be used.

Added some functionality in this regard.


Documentation for contributors

Add some "How to contribute" page with informations:

About binaries

How to use them

How to fix common CI problems
How to propertly write manifests.
Naming conventions
Recommended workflow before pushing.

Run checkver, create git hooks, ... example

If you need help with any documentation just /cc me 👋

that would be great if you can make a PR for the pages inside guide section (docs/guide/contribute/README.md).


Add a committed comparison benchmark

At least on my machine (M1 Pro), I get the following on python 3.11:
Running rbloom
    2.52s
Running pybloomfiltermmap3
    4.78s
Running pybloom3
   46.76s
Running flor
   76.94s (via bytes because cannot convert 'float' object to bytes)
Running bloomfilter2
  165.54s (via bytes because unsupported operand type(s) for <<: 'int' and 'float')

I didn't update the benchmark results in the README, or update that (at least for me) pybloomfiltermmap3 seems to be fine on python 3.11 now.
Also, per updated guidance from rust, we should probably include the Cargo.lock.

This is beautiful code! Excellent work <3


add 'remove' for List

Added a remove function for List, similar to Haskell's delete. Of course, delete is already taken in JavaScript, so I called it remove instead.

Anything else I should do to help get this merged in? Would love to DRY up some of my projects. :smiley:

thanks


feat: Remove user segment

ref https://github.com/getsentry/team-sdks/issues/44
Remove user segment and all user segment related logic.
https://go.dev/ref/mod#go-mod-file-module-deprecation

@cleptric I went ahead and completely removed it in d66770f6e46f90f3a223896dbbd2e8b8d44e123e

@AbhiPrasad Please update Changelog as well with this change.

Thanks @AbhiPrasad


fix: release action to use secrets properly

It looks like we need to pass the secrets from workflow to the action.

Release Note
NONE

Merging. No need to check as it only affects night release workflow.


undefined symbol: _ZTIN10tensorflow8OpKernelE

When I try to import the correlation kernel, it report error:
Traceback (most recent call last):   File "/home/user/work/tf_flownet2/FlowNet2_src/test.py", line 6, in <module>     tf.resource_loader.get_path_to_datafile("./ops/build/correlation.so"))   File "/home/earhian/anaconda3/lib/python3.6/site-packages/tensorflow/python/framework/load_library.py", line 56, in load_op_library     lib_handle = py_tf.TF_LoadLibrary(library_filename) tensorflow.python.framework.errors_impl.NotFoundError: /home/user/work/tf_flownet2/FlowNet2_src/./ops/build/correlation.so: undefined symbol: _ZTIN10tensorflow8OpKernelE

What's your TF version? We used 1.2.0 here.


shape TPCDS check all query shape, except ds64

Proposed changes
there is a known bug on ds64 analyze. add ds 64 shape check latter
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.05 seconds
stream load tsv:          503 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230714105607_clickbench_pr_178297.html


Generated credentials owner is not the current user

My CA is restricted to the root account for more security, but it would be nice if the generated stack was not owned by the same user. I.e. if there was a way to specify the owner of the output, or use the current user.  I did mention this here;
https://github.com/kubernetes-incubator/kube-aws/issues/961#issuecomment-333786912
But thought I should make a new issue for it.

Do you mean written files? Why don't directory after you finish running kube-aws


Stable version

i'm trying to install you package in a Yii2 project. The composer refuses to install because:
Could not find a version of package paramako/pornhub-api-client matching your minimum-stability (stable). Require it with an explicit version constraint allowing its desired stability
can you please help me??

Hey!
I released v1.0 to match your minimum stability
Please try to drop composer cache and then reinstall the package
composer clear-cache
composer require paramako/pornhub-api-client


browser.fire 'click' not working with eventHandlers added via Backbone.Events

In my test when I do
target = browser.querySelector('#target-selector')
browser.fire 'click', target, @callback',

the event is dispatched and the callback is called, but the click event handler on that element does not fire.
However, if I do
browser.evaluate "$('#target-selector').click()"

then the click event handler runs. Any reason why browser.fire would not act the same.
using zombie 0.10.1
PS this only happens for event handlers that are attached by Backbone, here is a gist showing this problem:
https://gist.github.com/1256944

Just wondering why this is closed? It's not fixed and is still a problem in the current code base. If I execute clickLink on a valid link, my backbone event handler should augment the href and it does not get called at all. This works perfectly in a 'real' browser. Are you actually going to fix any of these bugs or has support ceased on this project? All I can see here is curt, one-line responses which show little to no respect for any of your users and which don't actually address any of the issues being raised.
As a lot of us are using this in tests on real projects, it would be good to know if we should just go and use an alternative solution?

This issue references an event handling bug in the DOM, which affects jQuery/Backbone/others. A while back, brianmcd works on and contributed a fix, I added a test case to make sure this doesn't regress. Zombie has been shipping with that fix and accompanying test for 2 years now!
If you determined there's another bug lurking in there, you're more than welcome to open a new issue. If you submit a pull request with a test case and a fix, then I will review it and merge it into a future release, as I do with all bug fixes.


NUCLEO_F746ZG Ethernet enabling

Hello,
We should be able to use LwIP library for NUCLEO_F746ZG after this PR.
Cheers
Armelle

Please share the test results from ethernet.
cc @geky @sg-

I close it and keep the future mbed os one.

Is this not functional or why did you close it?

Is this not functional or why did you close it?

It will come to mbed later, there are few more pieces missing at the moment


Continually runs in background

I found that the headless task that is started by the scheduler continually runs in the background, causing battery drain if you follow the following steps:

Set up a background task according to the documentation
Run your app using react-native run-android
After your app loads, close it by removing it from your 'recent apps' list
Wait for the background task to execute, or force execution of the job

At this point if I shake my phone, the developer menu appears. Only after I open the app, and minimise it do things start to work as normal again. It seems like more than just a headless JS task is starting as it is causing a lot of battery drain on my phone until I open the APP to reschedule the background task.
Have someone else experienced this issue as well?

I am getting lots of user reports that my app uses extreme amounts of battery. The cause is most likely this.

@vikeri would this potentially be fixed by 2.0.0? @toteto

@Jacse Are you using the alwaysRunning flag on 1.2.4? Because that could drain a lot of battery potentially. With 2.0.0 I haven't had any issues with battery when running the job every 15 mins and for two hours a day running it every minute. Try 2.0.0 and see if that helps.

I wasn't using the alwaysRunning flag when I tested it. I also didn't have any battery issues if the app was still in the recently used apps list.
Once I removed the app it had an error message like "background job crashed" then "rescheduling backgroundjob" or something along those lines. Only background tasks that ran after that seemed to drain the battery.
Anyway, 2.0.0 will probably fix it since it uses a different scheduling mechanism. Thanks


Document the environment variables used in maya api service

Is this a BUG REPORT or FEATURE REQUEST?
FEATURE REQUEST
Details
maya api server defines the environment variables (referred as ENV) with an appropriate context.
e.g. the replica count of OpenEBS volume in default context one has to set the ENV variable
DEFAULT_REPLICA_COUNT=1 # or some non-negative value

e.g. similarly to fetch the replica count of OpenEBS volume in a context named XYZ one has to set the ENV variable
XYZ_REPLICA_COUNT=1

The ENV context can be set by passing XYZ as the value against the request option
env.mapi.openebs.io/env-var-ctx=XYZ

NOTE: Environment variables can sometimes be tricky if the user running the process (e.g. here maya api service) should have access to these variables.
Refer to below snippet for other ENV variables understood by maya api service
// EnvironmentVariableDefaults is a typed label that defines the environment variable
// defaults
type EnvironmentVariableDefaults string

const (
	// Default value for environment variable context
	EnvVariableContextDef EnvironmentVariableDefaults = "DEFAULT"
)

// EnvironmentVariableKey is a typed label that define the environment variables
type EnvironmentVariableKey string

const (
	// PVPProfileNameEnvVarKey is the environment variable key for persistent
	// volume provisioner's profile name
	//
	// Usage:
	// <CTX>_PVP_PROFILE_NAME = <some value>
	PVPProfileNameEnvVarKey EnvironmentVariableKey = "_PVP_PROFILE_NAME"
	// PVPNameEnvVarKey is the environment variable key for persistent volume
	// provisioner's name
	//
	// Usage:
	// <CTX>_PVP_NAME = <some value>
	PVPNameEnvVarKey EnvironmentVariableKey = "_PVP_NAME"
	// PVPControllerImageEnvVarKey is the environment variable key for persistent
	// volume provisioner's controller image
	//
	// Usage:
	// <CTX>_CONTROLLER_IMAGE = <some value>
	PVPControllerImageEnvVarKey EnvironmentVariableKey = "_CONTROLLER_IMAGE"
	// PVPPersistentPathEnvVarKey is the environment variable key for persistent
	// volume provisioner's replica persistent path
	//
	// Usage:
	// <CTX>_PERSISTENT_PATH = <some value>
	PVPPersistentPathEnvVarKey EnvironmentVariableKey = "_PERSISTENT_PATH"
	// PVPStorageSizeEnvVarKey is the environment variable key for persistent
	// volume provisioner's replica size
	//
	// Usage:
	// <CTX>_STORAGE_SIZE = <some value>
	PVPStorageSizeEnvVarKey EnvironmentVariableKey = "_STORAGE_SIZE"
	// PVPReplicaCountEnvVarKey is the environment variable key for persistent
	// volume provisioner's replica count
	//
	// Usage:
	// <CTX>_REPLICA_COUNT = <some value>
	PVPReplicaCountEnvVarKey EnvironmentVariableKey = "_REPLICA_COUNT"
	// PVPReplicaImageEnvVarKey is the environment variable key for persistent
	// volume provisioner's replica image
	//
	// Usage:
	// <CTX>_REPLICA_IMAGE = <some value>
	PVPReplicaImageEnvVarKey EnvironmentVariableKey = "_REPLICA_IMAGE"
	// PVPControllerCountEnvVarKey is the environment variable key for persistent
	// volume provisioner's controller count
	//
	// Usage:
	// <CTX>_CONTROLLER_COUNT = <some value>
	PVPControllerCountEnvVarKey EnvironmentVariableKey = "_CONTROLLER_COUNT"
	// PVPReplicaTopologyKeyEnvVarKey is the environment variable key for persistent
	// volume provisioner's replica topology key
	//
	// Usage:
	// <CTX>_REPLICA_TOPOLOGY_KEY = <some value>
	PVPReplicaTopologyKeyEnvVarKey EnvironmentVariableKey = "_REPLICA_TOPOLOGY_KEY"
	// OrchestratorNameEnvVarKey is the environment variable key for
	// orchestration provider's name
	//
	// Usage:
	// <CTX>_ORCHESTRATOR_NAME = <some value>
	OrchestratorNameEnvVarKey EnvironmentVariableKey = "_ORCHESTRATOR_NAME"
	// OrchestratorRegionEnvVarKey is the environment variable key for orchestration
	// provider's region
	//
	// Usage:
	// <CTX>_ORCHESTRATOR_REGION = <some value>
	OrchestratorRegionEnvVarKey EnvironmentVariableKey = "_ORCHESTRATOR_REGION"
	// OrchestratorDCEnvVarKey is the environment variable key for orchestration
	// provider's datacenter
	//
	// Usage:
	// <CTX>_ORCHESTRATOR_DC = <some value>
	OrchestratorDCEnvVarKey EnvironmentVariableKey = "_ORCHESTRATOR_DC"
	// OrchestratorAddressEnvVarKey is the environment variable key for orchestration
	// provider's address
	//
	// Usage:
	// <CTX>_<REGION>_<DC>_ORCHESTRATOR_ADDR = <IP_ADDRESS>
	OrchestratorAddressEnvVarKey EnvironmentVariableKey = "_ORCHESTRATOR_ADDR"
	// OrchestratorCNTypeEnvVarKey is the environment variable key for orchestration
	// provider's network type
	//
	// Usage:
	// <CTX>_ORCHESTRATOR_CN_TYPE = <some value>
	OrchestratorCNTypeEnvVarKey EnvironmentVariableKey = "_ORCHESTRATOR_CN_TYPE"
	// OrchestratorCNInterfaceEnvVarKey is the environment variable key for orchestration
	// provider's network interface
	//
	// Usage:
	// <CTX>_ORCHESTRATOR_CN_INTERFACE = <some value>
	OrchestratorCNInterfaceEnvVarKey EnvironmentVariableKey = "_ORCHESTRATOR_CN_INTERFACE"
	// OrchestratorCNAddrEnvVarKey is the environment variable key for orchestration
	// provider's network address
	//
	// Usage:
	// <CTX>_ORCHESTRATOR_CN_ADDRESS = <some value>
	OrchestratorCNAddrEnvVarKey EnvironmentVariableKey = "_ORCHESTRATOR_CN_ADDRESS"
	// OrchestratorNSEnvVarKey is the environment variable key for orchestration
	// provider's namespace
	//
	// Usage:
	// <CTX>_ORCHESTRATOR_NS = <some value>
	OrchestratorNSEnvVarKey EnvironmentVariableKey = "_ORCHESTRATOR_NS"
	// OrchestratorInClusterEnvVarKey is the environment variable key for orchestration
	// provider's in-cluster flag
	//
	// Usage:
	// <CTX>_ORCHESTRATOR_IN_CLUSTER = <some value>
	OrchestratorInClusterEnvVarKey EnvironmentVariableKey = "_ORCHESTRATOR_IN_CLUSTER"
)

With 0.8.1, most of the values are pushed into the storage classes and storage policies. Still a few remain as ENV. The CAS templates could be looked into to update the documentation.


Suggest wallets via deep linking functionality for mobile browsers

When a user access the widget from mobile browser, instead of the message "You do not have a wallet connected", suggest using one wallet via deep links.
Trust Wallet: https://medium.com/@trustwallet/mobile-dapps-with-deep-linking-and-trust-wallet-6a4712b9b9a4
Status.im: https://get.status.im/browse/easytrade.io

@sebazelonka we need to style the modal on branch:feat/deep-linking


Update to Qt6 and MO2 2.5.0

This fully updates the code to PyQt6. MO2 2.5.0 still throws errors that PyQt5 isn't present even with the try-except statements, so I removed it completely. Unfortunately, this comes with some caveats:

Qt6 doesn't have pyrcc, so it has to use Qt's rcc, which requires installing Qt 6
Qt's rcc generates a PySide6 import, so resources.py has to be edited to use PyQt6

I switched to a powershell build script to change the import automatically

PyQt6 isn't on GitHub, only PyPI, so the alternate build instructions don't work anymore

This also includes a fix for hide type being case sensitive

Alternately, we can just install PyQt5 alongside PyQt6 and keep using pyrcc5, but that'd still require editing resources.py


Add repository to Cargo.toml

So that crates.io includes a link to the repo.
@poljar: should I be requesting review from you or is the a team I should be using?

So that crates.io includes a link to the repo.
@poljar: should I be requesting review from you or is the a team I should be using?

We don't have a formal team for this currently so it's fine to request from me. I'll be away next week until the end of the month so if you have more PRs comming @dkasak would probably be the person to request from.


bower.commands.version should return the new version

Right now, bower.commands.version updates bower.json and prints the new version with console.log.
What it should do is

Use the logger to print the new version
Return the new version so that callers have access to it

OK... so, I see now that the Logger is not available at the appropriate time, so maybe scratch that suggestion


When doing yolox/trt_evaluate.sh for fp32 tensorrt model, what's the reason this error occurred? how can i fix it?

trt_model checkpoints/tensorrt/yolox_x_8x8_300e_coco_20211126_140254-1ef88d67.trt
loading annotations into memory...
Done (t=0.55s)
creating index...
index created!
[                                                  ] 0/4952, elapsed: 0s, ETA:Traceback (most recent call last):
File "tools/2d/evaluate_trt.py", line 142, in
main()
File "tools/2d/evaluate_trt.py", line 103, in main
engine, context, input_shapes=input_shapes_, output_shapes=output_shapes_
File "./det2trt/utils/tensorrt.py", line 49, in allocate_buffers
context.set_binding_shape(binding_id, dims)
AttributeError: 'NoneType' object has no attribute 'set_binding_shape'

You can set https://github.com/DerryHub/BEVFormer_tensorrt/blob/1b39aac2fc260b65347a9479bb4e85905c37dff2/tools/2d/evaluate_trt.py#L40 to trt.Logger.VERBOSE to see how the error happened.

Hi, I believe it's a bug. When evaluating fp32 trt yolox-x model, I found that the context is none, which means engine.create_execution_context() returns none. But the engine is not none. It doesn't happen in other precision types of trt, only in fp32 trt. fp32 pth model works fine too.


keyd doesn't capture the power button

I'm trying to left behind the ubuntu keyboard shortcuts and the only one I can't replace is the control+power to reboot my machine.
When I run sudo keyd -m and then press the power button, I have nothing in capture screen.

@herrsimon is correct. Most power buttons emit ACPI events which never propagate to userspace in form of input events.


Semver violation

It looks like the changes from the 1.0.0-alpha.x releases have gotten rolled into a 0.2.1 release. However, there are breaking changes in the way impagination needs to be implemented since 0.2.0. I think even the way the underlying impagination library is included has changed. In short, bumping from 0.2.0 to 0.2.1 in my project fails completely. Can you please revert this and make the new release at least 0.3?

Thanks @TopsyCM
We were not able to revert the v0.2.1 release since it was released more than 24 hours ago, but have deprecated v0.2.1 in favor of v0.2.2 which is equivalent to v0.2.0

New major released finally released as v1.0.0-alpha.6


Added custom video capture sample

AVCaptureDeviceDiscoverySession warning is there in Mac SDK too so i didn't touch it.

Ok, this is something that we will need to investigate.
Did you notice any problems at runtime?

no runtime issues

When I close the app, the audio still goes on

Typically I like to add a subscribe to self flag in the code , so I don't have to go outside the app to start a session, publish etc
void publisher_on_stream_created(otc_publisher *publisher, void *user_data, const otc_stream *stream) {
     session_on_stream_received(session, user_data, stream);
}

You decide if you want it.. not an issue for me..

are we ok to merge now? any blocking issues?

are we ok to merge now? any blocking issues?

I am still seeing pods configuration on the xcodeproj, did you run pod deintegrate?

are we ok to merge now? any blocking issues?

Raj, did https://github.com/opentok/opentok-macos-sdk-samples/pull/7#issuecomment-1442599367 get fixed? Thanks

When I close the app, the audio still goes on
fixed by implementing window close handler.

Also ran pod deintegrate

Merging, since @jvalli tested already and @chetanvangadiTokbox gave us a 👍.


Remove workaround for unnamed_addr constants for LLVM JIT

The JIT has been fixed in llvm r362139.
rdar://51809210

@swift-ci Please test

Can you commit the regression test in the radar as well, or is it already in?

The workaround commit https://github.com/apple/swift/pull/24944/files added the regression test


Replace unsafeRunSync in tests

An attempt to improve the health of our CI and set a better example for others.

It's not really necessary to do them all at once.  We can make Good First Issue tickets by splitting this up by module.  Let's make incremental progress here.


[Dev] Remove Jira support from merge script

Describe the enhancement requested
Since we've migrated, we can drop all of that, right? Also include the jira token store in dev/merge.conf.sample.
Component(s)
Developer Tools

Would love to get rid of all of that but we still have ~5 PARQUET issues per release from JIRA. IMO we should just get rid of that too, I think most of the parquet issues are handled within arrow Jira/GH anyway...

Would love to get rid of all of that but we still have ~5 PARQUET issues per release from JIRA. IMO we should just get rid of that too, I think most of the parquet issues are handled within arrow Jira/GH anyway...

IIUC the Parquet PMC would have to be ok with moving the parquet-cpp issue tracking to apache/arrow/issues. I don't know why there would be objection, particularly since the code has lived in arrow for years now, but technically they are responsible, governance-wise.

Maybe @pitrou can start a lazy consensus thread on the parquet mailing list about that?

I'd be happy to do the migration.

A mere lazy consensus wouldn't be enough as it's a disruptive change. It would need an actual PMC vote. Given the lack of reaction on the previous ML thread, I'm not optimistic.

We can revive this now that Parquet also uses GH for issues. @raulcd


[Network] API version bump to 2020-06-01

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

Network


Guestbook-go vagrant, no IP's in final step

Following the getting started instructions using vagrant, I get 0 IPs in the final step. How do I access the guestbook from the host?
$ cluster/kubectl.sh get services guestbook -o template --template='{{index . "publicIPs"}}'
current-context: "vagrant"
Running: cluster/../cluster/vagrant/../../cluster/../_output/local/bin/darwin/amd64/kubectl get services guestbook -o template --template={{index . "publicIPs"}}

We discussed this a bit on IRC -- let me know if nothing I suggested there works out or if you need help with any of it.
I'm going to take this issue to mean that we need to improve the example to make it clear what to do if you're running vagrant, and I'll work on that when I have some spare time.

And for future reference, the ideas from IRC are:
a) Put the minions' IPs into the service's publicIPs field
b) Use kubectl proxy to talk to the service through the master.
c) Don't worry about the service, just hit the pod IP directly
Using c is certainly easiest if you're just messing around to get a feel for using kubernetes. You could also probably configure vagrant to route the service's IP to one of the VMs, but that's getting outside the scope of kubernetes.

Thanks again for your help! The cluster/kubectl.sh update -f foo.yaml &cluster/kubectl.sh get service frontend --output > foo.yml commands are really useful. I set the public IP in the service, but still cannot reach it from my host web browser. I keep looking into it and seeing if I can spot something.

So it ended up being an issue with Mavericks (OSX 10.9.6) running virtualbox. Upgrading to Yosemite resolved it. I figured it out by observing flaky behavior with the network connections to Virtual Box itself, Host Only and DHCP occasionally going in and out of connection.


MAID-2022: beaker-plugin-safe-app tests

One tiny thing: warning package.json: "dependencies" has dependency "express" with range "^4.15.3" that collides with a dependency in "devDependencies" of the same name with version "^4.15.4"
And then I'm still getting errors with the updated beaker-safe-app, as noted: https://github.com/maidsafe/beaker-plugin-safe-app/pull/90


add missing buf linter defs

Initial fix for https://linear.app/trunk/issue/TRUNK-10710/update-buf-docs-to-include-all-3-linters


Add Divide Landing Page Project

Prerequisites

[X] I am a GSSoC-22 Participant
[X] I checked to make sure that this issue has not already been filed

Description
I need to add a project that divides the landing page by just hovering the mouse to both sides of the page.
Tech Stack
Web Development (HTML,CSS,JS)

closed with #655


Preparing release 1.0

Coverage remained the same at 100.0% when pulling ce983a64536d55e0ecbb2f53f7fe76c8c5200f2f on prepare-release-1.0 into e86551d1f14b2ef20b3a9f5c83c405a874d94e88 on master.


"New Binary File" leaks binary view objects

Version and Platform (required):

Binary Ninja Version: 3.5.4504
OS: Windows
OS Version: 11
CPU Architecture: x64

Bug Description:
When creating new binary data files in the UI, the reference to them isn't deleted after you close the tab. This leaks binary view references.
Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

Open a New Binary Data file
Close the tab
In the console, run: import gc ; gc.collect()
In the console, run: get_memory_usage_info()
Observe the BinaryView count is not 0
Repeat steps 1-5 ad nauseam

Expected Behavior:
I expected closing a tab to free the BinaryView it had open.
Additional Information:
Bug specific to New Binary Data, there might be other leaks hiding elsewhere. Bug was introduced between 3.1 and 3.2 stable.

After a bisect, it seems like it was this commit: https://github.com/Vector35/binaryninja/commit/3d61328406a3e70b4b7de2c4f8c67fad594f3666


Dismiss and Alert ends with strange behaviour

Description
It seems that there is issue with presenting and dismissing in new navigation API. Checking Integration app and new Presentation API I can see issue where I use Dismiss and Alert. It ends with just dismissing and console error. It also makes next presentation broken because it is presented and automatically dismissed.
Checklist

[ ] I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
[ ] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior

Presented screen is dismissed
Alert is shown

Actual behavior

Presented screen is dismissed
Error is printed on cosole
Next presentation is broken

Steps to reproduce

Open Integration app
Select Presentations APIs
Press Open Sheet
Press Dismiss and Alert
Press again Open Sheet to see next broken presentation

The Composable Architecture version information
prerelease/1.0
Destination operating system
iOS 16.1
Xcode version information
14.1
Swift Compiler version information
swift-driver version: 1.62.15 Apple Swift version 5.7.1 (swiftlang-<IP_ADDRESS>.3 clang-14<IP_ADDRESS>)
Target: arm64-apple-macosx12.0

@mpiotrowskibsg Our integration suite doesn't have a ton of documentation at the moment, but it shouldn't be viewed as "case studies" of working examples. It doesn't just exercise happy paths, but also exercises "unhappy" paths that sometime demonstrate some unfortunate vanilla SwiftUI behavior. In this case, SwiftUI itself just doesn't support programmatically swapping a sheet with an alert. The workaround most folks seem to apply is to space out dismissal and presentation using delays.
I'm going to convert this issue to a discussion since it's not a bug with the library, but rather a current behavior of vanilla SwiftUI.


how about MacOS

i learn that can support ios android and web，  how about maos and windows?
how about vulkan?

This library is mobile. You can try glfw.

至于vulkan的,目前比较好的做法是,开启自己的分支/

其实更想跨平台，不仅仅是mobile，而glfw对移动平台支持不好，因为跨平台经常在Pc下调试，比频繁走手机更方便~

目前没有好的办法,不过有个折中的办法.你可以将glfw按照glfm的接口封装起来,并且工作量很低.

As stated, GLFM will probably never have Windows+macOS+Linux support, and GLFW is best suited for that.
An issue for vulkan is here: https://github.com/brackeen/glfm/issues/17
Additionally, I added an issue for macOS support via Catalyst, which would require minimum code changes (although OpenGL is not supported) https://github.com/brackeen/glfm/issues/37
Closing this issue in favor of the other two


RabbitMQ Connect Failed: Broker unreachable

Is this a bug report?
Yes

Can you also reproduce the problem with the lastest version?
Yes
Environment

Operating system: Windows 10
Visual Studio version: VS 2017
Dotnet version: Core 2.0

Steps to Reproduce

Try to register more than 30 queues in RabbitMQ

Expected Behavior

Allow to register more queues without exceptions
Actual Behavior

After updating MassTransit packages to the latest version (<IP_ADDRESS>6-develop) I experience problems with registering more then 26 queues. For example, code below crushes with error

[20:51:06 ERR] RabbitMQ Connect Failed: Broker unreachable: guest@localhost:5672/test

    static void Main(string[] args)
    {
        var builder = new ConfigurationBuilder()
                .AddJsonFile("appsettings.json", true, true);

        var configuration = builder.Build();

        Log.Logger = new LoggerConfiguration()
            .MinimumLevel.Debug()
            .WriteTo.Console()
            .ReadFrom.Configuration(configuration)
            .CreateLogger();

        Log.Information("Starting Receiver...");

        var services = new ServiceCollection();

        services.AddSingleton(context => Bus.Factory.CreateUsingRabbitMq(x =>
        {
            IRabbitMqHost host = x.Host(new Uri("rabbitmq://guest:guest@localhost:5672/test"), h => { });

            for (var i = 0; i < 27; i++)
            {
                x.ReceiveEndpoint(host, $"receiver_queue{i}", e =>
                {
                    e.Consumer<TestHandler>();
                });
            }

            x.UseSerilog();
        }));

        var container = services.BuildServiceProvider();

        var busControl = container.GetRequiredService<IBusControl>();

        busControl.Start();

        Log.Information("Receiver started...");
    }

So, it can't register 27 queues. However it works if I decrease the number to 26 :)
If I downgrade MT NuGet packages to the latest stable 4.0.1 version it perfectly works and I can register up to 50 queues.
Also, another observation - with <IP_ADDRESS>6-develop versions it takes much longer to start this very tiny app. However when I test it with latest stable 4.0.1 and try to create 50 queues it starts almost immediately.
Reproducible Demo

https://github.com/pshenichnov/MassTransit.RabbitMQ-Connect-Failed-Broker-unreachable

So I can reproduce the slow startup with the develop branch, but I can't reproduce the startup crash.

have you tried to increase 27 to 50 etc?
maybe that specific magic number relates somehow to my environment

Mine doesn't even work with 26, max queues are 24 before it blows up.

Tried with 50, still works. Created a unit test on the develop branch, still works. Yes, it's slow, which I'll figure out, but I can't reproduce the crash on net452 or netcoreapp2.0.

Okay, now I'm seeing it. Not sure why though.

Verify with the latest develop and close please, I can no longer reproduce it with the fix.

Works as expected. Thank you for quick response.


Git: command 'github.codespaces.publish' not found

Opening this to draw more attention to this issue, shown here (https://github.com/orgs/community/discussions/67031)

I'm trying to publish my codespaces branch to a private repository, but after clicking publish branch, the following error is shown:
Git: command 'github.codespaces.publish' not found

I can't seem to find anything on the internet on this, so I am making this.
The template I used for this codespace was (https://github.com/theodorusclarence/ts-nextjs-tailwind-starter)
Any ideas? Thank you

@thecherrie Does this consistently reproduce for you? I haven't had any luck hitting this myself. Can I have you export your logs (F1 > Codespaces: Export Logs) and email them to me at<EMAIL_ADDRESS>to help me look into this further?

Git: command 'github.codespaces.publish' not found

Opening this to draw more attention to this issue, shown here (https://github.com/orgs/community/discussions/67031)

I'm trying to publish my codespaces branch to a private repository, but after clicking publish branch, the following error is shown:
Git: command 'github.codespaces.publish' not found

I can't seem to find anything on the internet on this, so I am making this.
The template I used for this codespace was (https://github.com/theodorusclarence/ts-nextjs-tailwind-starter)
Any ideas? Thank you


ENH: Add PrepareDerivative/SaveDerivative interfaces

These are intended to break DerivativesDataSink functionality into separable components and avoid unnecessary writes that cause invalidation of downstream nodes.
Tests forthcoming.

@mgxd I think this is ready to go. I expanded the tests to check everything we were checking with DerivativesDataSink.

Yup, looks good to me!


[invoke, gitlab] Add option to cancel redundant pipelines to pipeline commands

What does this PR do?
Adds a new invoke command, invoke pipeline.clean-running-pipelines to cancel running pipelines on a git ref.
When invoke pipeline.run is used, the same logic is run, and the user is asked whether they want to cancel existing running pipelines on the same git ref or not.
Motivation
Limit the number of pipelines running by removing redundant pipelines.
Try to prevent conflicts in kitchen tests (they can happen if two pipelines with kitchen tests run at the same time on the same commit).

Yes, I cancelled it to test the PR, let me run a new one


I've updated the flame-engine version in sample app

My thanks to Paul Teale for the great unique book about the flame-engine.
I post this thread just in case if anybody is curious about sample code migration to the latest version of the flame packages.
You can find the flame v1.8.0 migration steps in this repository: https://github.com/tnsoftbear/migrate_building_games_with_flutter_book_app
Feel free to post PR and issues there, if you see necessary fixes that can be applied more.

I also made an updated version of the codebase - available here: https://github.com/crcdng/building_games_with_flutter
Flame 1.14 / Flutter 3.16


Issue and ferry a Service Account Token to an Extension on bootstrap

As part of [META] System Indices access for Extensions, the plan is for an extension that reserves indices to receive a token on bootstrap that the extension can utilize to interact with its reserved indices. This token will be referred to as a Service Account Token because it represents the identity of the extension and can be used by the extension to act as itself when making requests on the extension's reserved indices.
I'm filing an issue to track the work to create an interface within the IdentityPlugin extension point of core that can be used to trigger the security plugin's implementation of issuing a service account token. After issuance, the token also needs to be ferried to an extension.
I see 2 possible options for ferrying this token to an extension:

As part of the InitializeExtensionRequest which is initiated from core and used to initialize an extension. The handler on the SDK side can be found here.

As a separate Transport action that is sent after successful initialization. I recommend this option.

You can see a sample implementation of a separate transport action for ferrying service account tokens in here. (There's an open PR on the SDK repo to address token handling on the SDK side that provided implementations of ferrying a service account token and obo token: https://github.com/opensearch-project/opensearch-sdk-java/pull/892)
Sending this as a separate Transport Request potentially allows the transport action to be re-used for token rotation, whereas an initialization request is only meant to be performed once.
Acceptance Criteria:

[x]  Define an interface in core on the IdentityPlugin that can be called to issue a service account token given an extension's unique ID.
[x] Create a new TransportAction that runs after successful InitializeExtensionRequest to issue and ferry the service account token to an extension
[ ] Implement the interface in the Security plugin

Future followup:

[ ] Update https://github.com/opensearch-project/opensearch-sdk-java/pull/892 to consume the TransportAction and initialize the extensionRestClient on the SDK side

[Triage] Thanks for filing this issue @cwperks. Please add an additional note about what is required for closing.

[Triage] Hi @cwperks, thanks for adding the action items. This looks like it is clear defined so marking as triaged.

Still waiting on review in core. Left comment asking for review.

Still waiting.

Still waiting.

Adding this back to make sure that we check off all the acceptance criteria are complete

@scrawfor99 If you have any pointers/POCs for how this could be done that would be useful to add to this item


⚠ Bofrost.es has degraded performance

In f8e66db, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1576 ms

Resolved: Bofrost.es performance has improved in 453f319 after 6 minutes.


rebuilding index fail cause index file missing

OrientDB Version: 3.0.11 3.0.12
Java Version: 8
OS: centos
Expected behavior
rebuild index on Studio
Actual behavior
missing .irs or (.sbt and irs)
Steps to reproduce

@FriedEggsWithLeek could you provide more details on how do you work with the database? How did you get the database?


Sync workflow files

This PR syncs the specified GitHub workflow files from the central repository.
Changes:

try right pnpm install - (10a964d)
REMOVE PNPM INSTALL BECAUSE THIS WOULD JUST RESULT IN MORE MERGE CONFLICTS BECAUSE OF PNPM-LOCK FILE (--NO-FROZEN-LOCKFILE) - (2f28b2b)

The branch has been updated with the latest changes.


[Improvement] [LDAP] Config value should return real null instead of 'null' string

Purpose of the pull request

Currently if LDAP Config value is not set,  DS would get String "null" as default value instead of real null currently.  #11324
This PR is to fix this problem.
Brief change log

Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
dolphinscheduler/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/security/impl/ldap/LdapServiceTest.java

Codecov Report

Merging #11325 (aef123e) into dev (caa6287) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11325      +/-   ##
============================================
+ Coverage     40.13%   40.25%   +0.11%
+ Complexity     4948     4841     -107
============================================
  Files           988      974      -14
  Lines         37721    37321     -400
  Branches       4148     4137      -11
============================================
- Hits          15140    15024     -116
+ Misses        21038    20755     -283
+ Partials       1543     1542       -1

Impacted Files
Coverage Δ

...nscheduler/api/security/impl/ldap/LdapService.java
6.38% <ø> (ø)

...olphinscheduler/plugin/task/emr/EmrParameters.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...heduler/plugin/task/jupyter/JupyterParameters.java
33.33% <0.00%> (-46.67%)
:arrow_down:

...inscheduler/server/worker/config/WorkerConfig.java
0.00% <0.00%> (-46.16%)
:arrow_down:

...duler/plugin/task/zeppelin/ZeppelinParameters.java
33.33% <0.00%> (-36.67%)
:arrow_down:

...inscheduler/server/master/config/MasterConfig.java
0.00% <0.00%> (-33.34%)
:arrow_down:

...heduler/plugin/task/chunjun/ChunJunParameters.java
46.15% <0.00%> (-29.71%)
:arrow_down:

...org/apache/dolphinscheduler/remote/utils/Host.java
42.55% <0.00%> (-2.13%)
:arrow_down:

...che/dolphinscheduler/api/python/PythonGateway.java
17.82% <0.00%> (-1.99%)
:arrow_down:

...che/dolphinscheduler/alert/AlertSenderService.java
50.73% <0.00%> (-1.15%)
:arrow_down:

... and 65 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Hello @EricGao888 @caishunfeng @SbloodyS , is there anybody can help review and merge the PR?

Thanks for your contribution. This is a good beginning. Considering that it's your first contribution, I think we can get deep communication, you can contact me through mail or add WeChat(SbloodyS), when mail or added, please tell me who you are. I think I can help to familiar with the Dolphinscheduler if you meet with problems. @huage1994

Thanks for your contribution. This is a good beginning. Considering that it's your first contribution, I think we can get deep communication, you can contact me through mail or add WeChat(SbloodyS), when mail or added, please tell me who you are. I think I can help to familiar with the Dolphinscheduler if you meet with problems. @huage1994

Fine. Thx a lot!


Cannot get light-up technique of assembly load to work for ASP.NET Core 2.0

I recently learned about the light-up technique that Application Insights uses to get their assemblies loaded into any ASP.NET app. Here is a link to it.
I've implemented an IHostingStartup class in an assembly.  I'm using a target of netcoreapp2.0. One thing I'm not sure if it could be an issue is that I had installed the .NET Core 2.1 preview (first and the second one), and the SDK that comes with it. So my .NET Core SDK is 2.1.
I followed exactly the same process of making sure my assembly, symbols and deps.json are put in the right place in the my user profile tree under the .dotnet subdirectory paths. In fact I used the nice Powershell script that I think Luke Latham wrote and referred to here.
I verified that the files are copied correctly, and that my deps.json file has the necessary entries.
When I run a hosting app like the HostingStartupSample that Luke used (all of the source is here, I get this exception as it starts up:
System.InvalidOperationException: Startup assembly ShiftLeft.NetCore.Agent failed to execute. See the inner exception for more details. ---> System.IO.FileNotFoundException: Could not load file or assembly 'ShiftLeft.NetCore.Agent, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.
   at System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks, IntPtr ptrLoadContextBinder)
   at System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, IntPtr ptrLoadContextBinder)
   at System.Reflection.Assembly.Load(AssemblyName assemblyRef)
   at Microsoft.AspNetCore.Hosting.WebHostBuilder.BuildCommonServices(AggregateException& hostingStartupErrors)
   --- End of inner exception stack trace ---

I have no idea why it cannot find it. I set the COREHOST_TRACE=1 environment  variable but didn't see anything more than what I already knew.
Here is the code:
using Microsoft.AspNetCore.Hosting;
using ShiftLeft.Agent;

// Use a Hosting Startup Attribute to identify the IHostingStartup implementation.
[assembly: HostingStartup(typeof(ShiftLeft.NetCore.Agent.AgentHostingStartup))]

namespace ShiftLeft.NetCore.Agent
{
    public class AgentHostingStartup : IHostingStartup
    {
        public static void Main(string[] args)
        { }

        public void Configure(IWebHostBuilder builder)
        {
            Logger.Instance.Log("AgentHostingStartup.Configure...");
        }
    }
}

The Main() entrypoint is to make the compiler happy -- apparently I cannot use that interface without having a Main entrypoint? All I do for my configuration is simply use a logger class to tell me if it gets loaded.
I could use some additional tips on troubleshooting this or if you think there's a bug. Thanks, Bob

I have a little more information on this:

I set the environment variable COREHOST_TRACE =1.
In the output of dotnet run I see my environment variables set for IHostingStartup to work:

DOTNET_ADDITIONAL_DEPS: "c:\Users\Robert Uva\.dotnet\x64\additionalDeps\AgentInHost\"

Note that the class library assembly I'm trying to get loaded is now called AgentInHost (I had used a different one in my original post of this issue).

I also see this in the output:

``` which seems to confirm that it is using that location for configuration probing. One of the directories in that location is `AgentInHost` .
4.  When I manually look at the ` C:\Users\Robert Uva\.dotnet\store\x64\netcoreapp2.0\AgentInHost\1.0.0\lib\netcoreapp2.0` path, I see my `AgentInHost.dll` as expected.

Is there anything else I should be looking for in the output?

@pakrym

It's location under c:\Users\Robert Uva\.dotnet\x64\additionalDeps\AgentInHost is shared\Microsoft.NETCore.App\2.0.0\AgentInHost.deps.json.
My app's runtimeconfig.json contains:
{
  "runtimeOptions": {
    "tfm": "netcoreapp2.0",
    "framework": {
      "name": "Microsoft.NETCore.App",
      "version": "2.0.0"
    },
    "configProperties": {
      "System.GC.Server": true
    }
  }
}

Hm, looks correct, what's the contents of AgentInHost.deps.json?

I had originally tried to get ShiftLeft.NetCore.Agent to be loaded using the IHostingStartup technique, but I wasn't sure if the failure was related to the my assembly's dependencies. So I built a brain-dead simple class library, AgentInHost, to see if that can be loaded. And it did not. So you can ignore the ShiftLeft.NetCore.Agent since I'm focusing now on trying to get AgentInHost loaded.

Hi @bobuva , were you able to get this figured out?


feat: download of zip response from api client request

Works with both the proxy and in the browser now
https://github.com/scalar/scalar/assets/6374090/44210c29-46d1-4501-8105-381de01ab5e5

I think I still need to update the tests


Website build failure missing graphs file

remote: processing: jcase.json
remote: processing: kg365.json
remote: processing: dcc52.json
remote: Traceback (most recent call last):
remote:   File "/societies/androidvulns/poole/poole.py", line 733, in <module>
remote:     main()
remote:   File "/societies/androidvulns/poole/poole.py", line 727, in main
remote:     build(opts.project, opts)
remote:   File "/societies/androidvulns/poole/poole.py", line 590, in build
remote:     macros[fn]()
remote:   File "./macros.py", line 811, in hook_preconvert_stats
remote:     month_graphs(months_range(first_date, last_date))
remote:   File "./macros.py", line 838, in month_graphs
remote:     with open(filename, 'w') as graph_file:
remote: FileNotFoundError: [Errno 2] No such file or directory: 'graphs/graph-2009-09.gv'

Should be OK now - just needed a placeholder in the graphs directory so that the directory itself gets uploaded


Add ex_doc

Disclaimer: I worked on those docs myself
They are from my knowledge the best auto generated docs any language has:

Code: https://github.com/elixir-lang/ex_doc
Examples: http://elixir-lang.org/docs/master/elixir/Kernel.html

Added, attributed, and closed. Thanks!