Mac OS: Firebase crashing Unity2017.4.1f1 with .NET 4.6

Hi,
I just moved my project to .NET 4.6 and noticed that Firebase is crashing the Editor under MacOS.
Is there ay way to fix this?
Thanks,

Could you share the editor log with the crash?
What version of the SDK are you using?

Editor-prev.log
Editor.log
Here are the files, hope it helps

I'm having the same problem, my logs look nearly identical.  Unity editor is crashing about every 3 to 5th play.  Anyone else?

After upgrading from Firebase 4.5.0 to 4.5.2, the problem seems to be solved.

Jinxed it. :(
It's happening a lot less now, but just got an editor crash.  Similar to before, the last log items are a large number of "Firebase App Initializing..." items.
editor.log
thread_suspend failed
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Stacktrace:
Native stacktrace:
0   libmonobdwgc-2.0.dylib              0x000000013ed6db01 mono_handle_native_crash + 277
1   libsystem_platform.dylib            0x00007fff73120f5a _sigtramp + 26
2   libmonobdwgc-2.0.dylib              0x000000013ee974ec mono_class_vtable_full + 65
3   libsystem_c.dylib                   0x00007fff72ebe1ae abort + 127
4   libmonobdwgc-2.0.dylib              0x000000013eee6f20 GC_noop6 + 0
5   libmonobdwgc-2.0.dylib              0x000000013eee663a GC_stopped_mark + 62
6   libmonobdwgc-2.0.dylib              0x000000013eee6396 GC_try_to_collect_inner + 311
7   libmonobdwgc-2.0.dylib              0x000000013eee7acb GC_try_to_collect_general + 158
8   libmonobdwgc-2.0.dylib              0x000000013eee7b40 GC_gcollect + 13
9   Unity                               0x0000000100cde9bb _Z16CleanupAfterLoadv + 155
10  Unity                               0x0000000100d32858 _ZN18LoadSceneOperation19IntegrateMainThreadEv + 472
11  Unity                               0x0000000100d34a66 _ZN14PreloadManager26UpdatePreloadingSingleStepENS_21UpdatePreloadingFlagsEi + 470
12  Unity                               0x0000000100d35432 _ZN14PreloadManager35WaitForAllAsyncOperationsToCompleteEv + 114
13  Unity                               0x00000001012ebdd7 _ZN18EditorSceneManager19RestoreSceneBackupsERSt6vectorINS_11SceneBackupE13stl_allocatorIS1_L18MemLabelIdentifier105ELi16EEENS_14PlayModeChangeEb + 1815
14  Unity                               0x00000001019a8455 _ZN20PlayerLoopController13EnterPlayModeEb + 533
15  Unity                               0x00000001019a32a6 _ZN20PlayerLoopController12SetIsPlayingEb + 278
16  Unity                               0x00000001019a2af5 _ZN11Application9TickTimerEv + 4069

Anyone else experiencing Unity editor crashes with Firebase 4.5.2 and C# 4.6 scripting?

@marcz88 could you try upgrading to Firebase Unity SDK 5.0.0 ?  We've resolved some cleanup issues in some components.

Thx, I upgraded yesterday and have only seen one editor crash so far.  Happened when I was building, not when I was playing.  So far no Play crashes which is amazing.
Reviewing the editor.log (sorry got overwritten before I could save it) it looked like the crash occurred during garbage collection, at the end of scene load, but I didn't see the same Firebase logging occurring at that time.  Definitely an improvement. I'll grab the editor.log next time I have a crash.

@criistii and @marcz88 which Firebase components are you using?  Also, it looks like you're both running the editor on OSX is that correct?  It would be great to understand the problematic environment so we can get to the root cause of this.

I'm only using Messaging.  Running:
OSX 10.13.4
Unity 2017.4.2f2
Firebase 5.0.0

I am working on Mac OS 10.13.x with Unity 2018, Visual Studio for Mac. I am using the Database and authentication.
Also, the project is under .NET 4.x, mostly for the "await" keyword.

I have same issue on macOS 10.13.4, 10.13.5 but it's work in 10.13.3 and I go to try in Window OS, it's work !!!

@marcz88 and @criistii we've been looking into this issue and have at least identified and fixed one issue.  The "Firebase Services" MonoBehaviour (we use it to pump a job queue on the main thread) ends up pointing at a deleted object when the editor is running and recompilation occurs.  This can end up in a NullReferenceException but not really a crash AFAIK.
The other issue @marcz88 referenced where the editor crashes and there are multiple app initializations in the log, it makes me wonder whether you're initializing Firebase on the main thread?  If you're not then we'll run into all sorts of issues with job scheduling.

We think the 5.1.0 release of the Firebase Unity SDK resolves this issue:
Release notes: https://firebase.google.com/support/release-notes/unity#5.1.0
Download: https://firebase.google.com/docs/unity/setup
Please give it a try and reopen the issue if you're still running into problems.

Hi guys, apologies for the long delay in responding.  I shifted focus on the project, then went on a vacation.  I upgraded to 5.1.0 last week, and I was holding my breath for about 3 days because didn't see any editor crashes.  But yesterday and today have experienced 4 crashes, all that happened immediately after log entries similar to:
thread_suspend failed
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
Firebase App initializing app __FIRAPP_DEFAULT (default 1).
One unique thing about the crashes, they all have the "thread_suspend failed".  I don't see this entry anywhere else in the logs.  Is that a firebase log entry, and if so does that give you any clues? Thx

Hi @marcz88,
Are you getting any different native call stack when this crash happens? Or is it similar to the one you reported earlier? If it's any different, could you post an updated log file and stack trace?
Also could you verify whether the crash still happens in the latest Firebase Unity release (5.2.0) and if there are any reliable repro steps?
Thanks!
Jon

It's still happening pretty consistently with 5.1.0, about 1 editor crash every 10 times I click the play button. Sometime happens when I stop. The stack traces appear to be in the garbage collection, during scene load/unloads.  I'll try out 5.2.0 and if I continue getting crashes, I'll collect a bunch of logs and send them for comparison.  Thx for your help.

Thanks. BTW, did you see @stewartmiles's comment above about not initializing Firebase on other threads (only on the main thread)?
Also, are you keeping a reference to the Firebase objects (FirebaseApp, FirebaseAuth, FirebaseDatabase, FirebaseStorage, etc.) or just using DefaultInstance each time?
Finally, could you confirm which specific Firebase plugins you are using? (Auth, Database, Analytics, etc.)
Thanks again!
Jon

Regarding initializing Firebase on the main thread: I'm not initializing Firebase myself, just accessing the default instance like I've seen in other examples.  I'm only using Messaging.  I have a class called Notification derived from MonoBehavior that registers for MessageReceived and TokenReceived as below:
    void Start()
    {

#if UNITY_ANDROID || UNITY_IOS
Debug.Log("Setting up Firebase messaging event handlers...");
Firebase.Messaging.FirebaseMessaging.MessageReceived += OnMessageReceived;
#if UNITY_ANDROID
Firebase.Messaging.FirebaseMessaging.TokenReceived += OnTokenReceived;
#endif
#endif
}
with handler functions for OnMessageReceived() and OnTokenReceived().  Is there anything wrong with doing it this way?
I'm also integrated with AWS SDK for database, lambda and messaging.  I'm using Firebase to receive messages and tokens on my iOS and Android clients in a unified way, and using AWS SDK to create topics, subscribe to topics so my lambda functions can use AWS SNS to notify clients of important data changes.  Any possible issues with doing this?

Firebase Unity will lazily initialize things the first time they are accessed, so that will initialize FirebaseApp and FirebaseMessaging inside the Start() which I think should be fine, unless there's some way that's running from a different thread.
I'll delve into this a bit more, but definitely send along some logs if you can get them.

Oh, one small suggestion. Does it help if you hold onto a reference to Firebase.Messaging.FirebaseMessaging somewhere in your code? I am concerned that the Firebase.Messaging.FirebaseMessaging object may be getting garbage-collected. Just grab the reference and keep it somewhere that stays in memory for the duration of your app. Let me know if that workaround makes a difference.

I can try it, but not exactly sure how to hold a reference to Firebase.Messaging.FirebaseMessaging. I don’t see a way to get the instance to this. Do you mean FirebaseApp? if so, I see a GetInstance(string name), but don’t see the documented GetInstance() function (the one without the name parameter). Can you elaborate? Thx

On Aug 9, 2018, at 9:17 PM, jonsimantov<EMAIL_ADDRESS>wrote:
Oh, one small suggestion. Does it help if you hold onto a reference to Firebase.Messaging.FirebaseMessaging somewhere in your code? I am concerned that the Firebase.Messaging.FirebaseMessaging object may be getting garbage-collected. Just grab the reference and keep it somewhere that stays in memory for the duration of your app. Let me know if that workaround makes a difference.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/firebase/quickstart-unity/issues/160#issuecomment-411945855, or mute the thread https://github.com/notifications/unsubscribe-auth/ASomSUTtdlXKg3kUa7KoylFs8i91kzpqks5uPN8VgaJpZM4TqM3Z.

Sorry, I meant the FirebaseApp.DefaultInstance. Sorry.

Hi,
I've been looking deeper into this and have tested a minimal sample with scene transitions, and I'm still having trouble reproducing the crash, so I need a little more information:

You're registering the event listeners in Start(). Where are you un-registering the event listeners? Are you registering and unregistering them in every scene or just one time?
Are you accessing any of Firebase in any other part of your code besides these event registrations / unregistrations? Are you holding onto any objects you receive in the event handlers (the MessageReceivedEventArgs or TokenReceivedEventArgs)?
Have you tried running with Firebase.FirebaseApp.LogLevel = Firebase.LogLevel.Debug to see if anything else is logged?

Thanks,
Jon

After making the suggested changes, things have gotten much better.  I didn't see a crash for quite a while but was holding my breath because I've seen this issue suddenly go away for a few days then reappear.  That said I had editor crash when I turned the Play button off. I took a look at the log since I enabled Firebase debugging and I noticed something peculiar.  It looks like Firebase is shutting down then trying to restart immediately, and it happens multiple times during the stop until it finally crashes.  Check out the attached log.
Editor-crash-onstop.txt

Thanks, I'll take a look at the log and get back to you. I do see what you're talking about with it re-initializing Firebase App briefly before tearing it down again, very odd.
A few more questions:
Are you clearing the DefaultInstance before or after unregistering the message event listeners?
Do you have multiple Firebase packages added to your project or did you only import FirebaseMessaging.unitypackage?

I only imported one package, the FirebaseMessaging.unitypackage.
Here is the only Firebase related code in my app:
        // Use this for initialization
        void Start()
        {
#if UNITY_ANDROID || UNITY_IOS
            Debug.Log("Setting up Firebase messaging event handlers...");

            firebase = Firebase.FirebaseApp.DefaultInstance;
            Firebase.FirebaseApp.LogLevel = Firebase.LogLevel.Debug;
            Debug.Log("Firebase:" + firebase.Name + " MessageSenderId=" + firebase.Options.MessageSenderId.ToString());

            Firebase.Messaging.FirebaseMessaging.MessageReceived += OnMessageReceived;
#if UNITY_ANDROID
            Firebase.Messaging.FirebaseMessaging.TokenReceived += OnTokenReceived;
#endif
#endif
        }

        private void OnDestroy()
        {
#if UNITY_ANDROID || UNITY_IOS
            Debug.Log("Unregistering Firebase messaging event handlers...");

            Firebase.Messaging.FirebaseMessaging.MessageReceived -= OnMessageReceived;
#if UNITY_ANDROID
            Firebase.Messaging.FirebaseMessaging.TokenReceived -= OnTokenReceived;
#endif
            firebase = null;
#endif
        }

#if UNITY_ANDROID
        public void OnTokenReceived(object sender, Firebase.Messaging.TokenReceivedEventArgs token)
        {
            Debug.Log("Received Registration Token: " + token.Token);
            m_DeviceToken = token.Token;

            if (LoginAWS.getInstance().IsLoggedIn())
                Register(() => { Debug.Log("Notification.Register complete"); });
        }
#endif

#if UNITY_ANDROID || UNITY_IOS
        public void OnMessageReceived(object sender, Firebase.Messaging.MessageReceivedEventArgs e)
        {
            UnityEngine.Debug.Log("Received a new message from: " + e.Message.From);
            if ((e.Message.Notification != null &&
                !e.Message.Notification.Equals("")) ||
                (e.Message.Data != null &&
                !e.Message.Data.Equals("")))
            {
                // if app has initialized and is logged in
                if (LoginAWS.getInstance().IsLoggedIn())
                    ProcessNotification(e.Message.Data);
            }
        }

Update! I removed the Firebase SDK completely and saw editor crashes. It appears to not be related to Firebase. I'm checking other plugins now to narrow it down. Thx for your help.
Marc

Same problem. I wrote in the support, but they could not reproduce
https://fogbugz.unity3d.com/default.asp?1065755_8pnsa7l0c2otmsv9

We are expecting a fix to come out with 2018.2.8 next Friday. However, with that we are seeing a slightly different crash:
Thread 0 Crashed:: CrBrowserMain  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fff6eaf5e3e __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fff6ec34150 pthread_kill + 333
2   libsystem_c.dylib             	0x00007fff6ea52312 abort + 127
3   com.unity3d.UnityEditor5.x    	0x0000000100ffe041 HandleSignal(int, __siginfo*, void*) + 81
4   libmonobdwgc-2.0.dylib        	0x0000000138439c15 mono_chain_signal + 79
5   libmonobdwgc-2.0.dylib        	0x000000013830b85b mono_sigsegv_signal_handler + 414
6   libsystem_platform.dylib      	0x00007fff6ec27f5a _sigtramp + 26
7   ???<PHONE_NUMBER>00000000 0 + 0
8   libmonobdwgc-2.0.dylib        	0x00000001385531b6 GC_mark_some + 476
9   libmonobdwgc-2.0.dylib        	0x0000000138552a72 GC_stopped_mark + 146
10  libmonobdwgc-2.0.dylib        	0x000000013855277a GC_try_to_collect_inner + 311
11  libmonobdwgc-2.0.dylib        	0x0000000138553eb9 GC_try_to_collect_general + 158
12  libmonobdwgc-2.0.dylib        	0x0000000138553f2e GC_gcollect + 13
13  com.unity3d.UnityEditor5.x    	0x0000000100d157f9 CleanupAfterLoad() + 297
14  com.unity3d.UnityEditor5.x    	0x0000000100d455cd LoadSceneOperation::PlayerLoadSceneFromThread() + 1053

Since it doesn't sounds like this is Firebase, I'm closing this issue.  Please let us know if you see a Firebase DLL / shared library in a stack trace.


noteTweenScale code add-on request

What is your question?
Hey beihu I was wondering on the next update that can you add the noteTweenScaling code from notes since the noteTweenX and noteTweenY are added on couple years ago when the psych engine Lua updated and the codes on noteTweenX and noteTweenY are on the funkinLua.hx on the psychlua folder and I was adding the noteTweenScale it kinda lag and slows the game when the duration are on 0.1 seconds so yea I was asking to you if you can add that code on the funkinLua.hx
Edited:
This is the example of the noteTweenScaling('idk', 0, scale-7, duration-0.1, 'ease')
Ok on the code I added that there is different between the pixel and not pixelated
On the pixel scale that the original on scale is 7 and on the non pixelated the original scale is 0.7 kinda confusing on the pixel scale and the non pixelated scale

already add this function now


Enable ansible-lint and yamllint

Galaxy already checks for it
https://github.com/geerlingguy/ansible-role-php/blob/master/.ansible-lint

ansible-lint includes yamllint


Remove proxy, as a proxied account. Reject when try to sign.

Description
Get reject when try to sign via WalletConnect revoke authority as a proxied.
Steps to Reproduce
Wallet setup:

wallet_a with proxy on wallet_b
proxied for wallet_c with All operations access

Try to remove proxied from wallet_b
-- successful removing
Try to remove proxy as a proxied wallet

Expected Behavior
Successful signing as a proxied account
Actual Behavior
Reject while signing
Environment
https://github.com/novasamatech/nova-spektr/commit/23ee363cc50fa75f156ee799eb31603b13a0eee2

Example
https://github.com/novasamatech/nova-spektr/assets/40560660/cba912e9-175a-4fda-b0ea-2dd1645a9a19

logs:
nova-spektr.log

Status verification: ✅


ci: Run pre-commit checks in CI

Closes #172
e6c3a4b ci: Run pre-commit checks in CI
adeee1e flake8: Fix config formatting error
commit e6c3a4b162ab1690cc0a196fbb45acc39313b280
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Thu Oct 3 13:52:24 2024 +0000
ci: Run pre-commit checks in CI

Run the pre-commit checks in a github workflow to validate that a PR
or a direct push to the repo does not introduce new errors.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>
commit adeee1eb5022fc59257180964b48130931ddfe20
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Thu Oct 3 14:00:20 2024 +0000
flake8: Fix config formatting error

The list of paths under `exclude` had a formatting error. Entries must
be separated by commas.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

You can find a passing test run of this here: https://github.com/russellb/llama-stack/actions/runs/11163763978

4100e5a3ae3c5f89984ceb42e409051c922d7c74


:class on  element breaks Bootstrap 5 dropdown behaviour

Vue version
3.2.45
Link to minimal reproduction
https://sfc.vuejs.org/#__DEV__eNrtVdtu20YQ/ZUpX2QDJtk4jpsSVhE7TePWCdymbg2k7MOKHFJrL2eZvUhVBP17Z3mR5cQu0L70JQREcudydObCmXV02rbJwmOURSe2MLJ1YNH5FpSgeppHzubRdznJptXGwRoMVrCByugGJuw2ySkngEE9mWntrDOi7eQKHSyEgmnw2suj6x/Pzt68yqN9gJwKTdZBY+tBPTlHpTRca6PKryb7O/6WLf7Io/dodB4d5NElYfe8Wvbnq7lBlvyZU+WpcFIT+LYUDn/V3hS4ZzOmJKlmTIB1uEGATfjncWqZC8Am3HYAGnGLZ1qVe/uQcVAKRRfn4G04Q4buQGA6hZHggHaS9tnk3PHBYdMqZsSn4A8nStItMO+KUzx3rrVZmhYlJTe2RCUXJiF0KbVNus3oi2fJYfI0LaV1aWHtnSJpJCUsySPmpRjPupVCO0d0LJLksDbSrYJiLp4+P4rNzJ4e/n528cu8rpcf/zr/pv35pTj9cHl0/Lamy7fPv/54/eTdtT8/fvL96zfL9z+9Ki8OL0T54fCHb1/+9vr4GaMWRlurjawlMa4gTatG+75VhhDhao6gsHIwF1RCaXRb6iWBbtFwJiwU2hgsnFodwMw7cGz+7hw0IVRCctGdhkJpiyCrTlnM+UDcnYq9Qo0KBq4ZKCitY0zQvWUejeVjqmNJk77CnPtSLhhZWMvUuQudkISGE9V6F9dG+7YLI4Qw3seQxusexDayJj7aem4tO1gujCg1qdXWCWaOtjmJna5rhUEWa++4NzC2yNRKYVZsm/Wdmkf87Bvs/sW9LuKZHWB2KH1Ox6vPeMcNkodKKocmftRz6FpYxJU2oZc4Yd3H+aDlo0mKJX8KHNKLQsnilhX3v9R9RluvwcJmc8KtvniIRKrkp1GlXu2Idj1H6cMV+/9Klo2oa5hUy3jGvTrJdqfO5kuh/2Whw8ztz+FtO3Gjg6jfTnHDs/LGauJV183xfFBwZNk42blgnndJxi/jWLZVERbkjU20qVN+S4wnJxtM0DbxzOilRcPAYRfdYaQsXHCeDVKJBs0/YX5i+jjuduaHDvsvi+Nmd2/MPJUKu/UR/mVYXJto8zcj95PT
Steps to reproduce
Create a simple bootstrap dropdown, but add a :class property to the input element which changes a class (e.g. fw-bold) depending on the selected element.
Click to open the dropdown, click on an item which would prompt the above class to change.
See SFC playground example, which has two dropdowns - one with the :class, and one without.
Relevant template snippet

            <input readonly class=" btn dropdown-toggle btn-outline-secondary" :value="val"
                :class="{ 'fw-bold': makeBold() }"
                data-bs-toggle="dropdown">

{{ s }}

What is expected?
The input element re-renders and the dropdown is closed.
What is actually happening?
The input element displays correctly,  but the dropdown does not close.
System Info
SFC Playground with Bootstrap 5.2.3

Any additional comments?
This may be in the no-mans-land between Bootstrap and Vue :)

Bootstrap adds a class called show that vue is unaware of, and it seems to make the close behaviour depend on that.
When you select "zero", which makes Vue add another class to the element, Vue overrides the classes with the ones it knows - and show is not one of them, so it's effectively being removed.
And bootstrap then doesn't close the dropdown, because appearantly, that missing class on the input means it's not in need of closing, or something.
You can verify this by: 1) opening the dropdown 2) removing the show class on the input 3) selecting any entry. It will also not close.
This is a wontfix. Two libraries changing the same element is generally a very bad idea. Vue can't reliably to its job (and neither can bootstrap as we see) when other code is messing in its turf.

...Vue overrides the classes with the ones it knows - and show is not one of them, so it's effectively being removed.

That's more than a little unexpected.  Is there a reason that Vue can't leave those classes it doesn't know about untouched? Would having and additional (but less flexible) variant of the :class attribute help?
I think I can solve my particular problem by using a computed CSS style to 'bold' the text rather than the bootstrap utility fw-bold class.

We would need to diff the classList of every element on every component update, which would add non-trivial overhead in the perf-sensitive update path.


💡Add a Feedback Form/Page to "Star Connect Hub" Website

Hey @Priyaaa1
I would like to add a feedback form/page
Use Case

User: Clicks on the "Give Feedback" button.
System: Displays the feedback form as a popup.
User: Fills out the feedback form, providing optional name and email, selecting the type of feedback, and entering comments.
User: Clicks the "Submit" button on the form.
System: Displays a confirmation message indicating the feedback was submitted successfully.
User: Closes the feedback form popup.

To improve user experience and gather valuable insights from visitors, i suggest to add a feedback form/page to the "Star Connect Hub" website. This form will allow users to provide their opinions, report issues, and suggest improvements directly.

For example like this:

Please assign this issue to me.

@Priyaaa1 pls assign this issue to me.

Hey @Priyaaa1 On which email id should the feedback be sent??

@MastanSayyad email<EMAIL_ADDRESS>


Move client tests on mobile browsers to the separate task

We do it to have an ability to restart client tests on mobile devices only while we are fixing unstable tests

/cc @inikulin

lgtm


WorkflowExecutor hard to extend

Hello all,
We have an application using conductor core to orchestrate workflow. For business purpose, we had to extend the Conductor to add new property (we already created a PR to make conductor model more extensible, if you could also some feedback on that). Currently, we need to setup some fields of the workflow before to start it (because it will be decided before to allow us to add these fields, and in case of sub-workflow as first task, the behaviour of our workflow will break. For more info cf. https://github.com/Netflix/conductor/blob/master/core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java#L398)
Now, we were thinking to create an interface to be implemented in the WorkflowExecutor, with a startWorkflow that does not take all these parameters, but only the workflow execution to start. Meanwhile, the creation of this workflow execution will happen in another method (protected one).
A simple snippet:
public String startWorkflow(final Workflow workflow)

protected Workflow buildWorkflow(
    WorkflowDef workflowDefinition,
    Map<String, Object> workflowInput,
    String externalInputPayloadStoragePath,
    String correlationId,
    Integer priority,
    String parentWorkflowId,
    String parentWorkflowTaskId,
    String event,
    Map<String, String> taskToDomain)

What do you think? Would you agree with this approach?
Thanks

@andrea11 I did leave a comment on #1336 that since this breaks interface contracts, we would want to hold off on making this change in a minor version upgrade but will definitely add this to our list of features for the next major version upgrade.
Your approach for introducing an interface for the start workflow would work, but please ensure that validations are being applied in the buildWorkflow method.


auto merge don't work

It had been working for a year before stopped a week ago despite I did not touch anything:
https://pull.git.ci/check/vstavrinov/streamlink

Were there changes in. github/workflow folder? GitHub restricts auto merging using installation tokens when files are present in that folder.

There was added the second file. Is it the reason? It's strange. So I should move pull.yml there, right?

Sorry, that's not true. The file was added when the pull was installed. So, nothing changed and the cause is somewhere else. Maybe it is on the GitHub side.

.github/workflows/main.yml
this file was changed in the pull request https://github.com/vstavrinov/streamlink/pull/51/files.

It works. Thank You.


Move pinned dependency to end

This pinned dependency is causing the coherent parent algorithm to resolve older versions of corefx binaries (this is the 3.0 shipping version) in aspnetcore and other downstream repos that tie their corefx inputs transitively to the extensions inputs.

@riarenas I'm pretty sure this is going to solve the cpd issue in aspnetcore-tooling


Implement uncentered version of RMSProp. Rename old version to RMSPropAlex

See https://github.com/dmlc/mxnet/pull/5043#issuecomment-280674628

@howard0su Should be useful for pair-testing with keras.

Please see #5116. I closed this pull request as it was erroneously based on my master branch.


[util] disable allowDoNotWait for Port Royale 3

Fixes the game getting stuck in infinite loading screens sometimes when entering city view
Fixes #2148

Do we know what the root cause is?

Not sure. Know almost nothing about debugging something like this.
Now that i'm trying again to get some more logs i can't reproduce it all of a sudden. So hold off with the PR anyway.

I am so confused.
How i usually test different different dxvk versions along with proton is that i download a release from this github.
If i have the game set to proton 7.0 i then go into teamapps/common/Proton 7.0/dist/lib/wine/dxvk/ and rename the files to something like d3d9_b.dll and then extract the downloaded files into the folder. Same for 64bit.
For this game i am launching using proton 7.0-2rc which comes with 1.10.1 and if i use the ones that come along with proton i just cannot reproduce this issue. If i use 1.10.1 or a master artifact downloaded from this site i can reproduce it.
The files downloaded from here are also not the same size and sha256 checksum as the ones included with 7.0-2rc even tho they are supposedly both 1.10.1. I'm guessing that's because the compilation is slightly different.
If i am missing something here please enlighten me.
Note the OP of the original issue is using wine so i am guessing they are using the github downloaded version.

FYI, I stumbled across this fix completely by accident and have been happy enough that it let me play the game for more than a couple of days of today game time without any lockups. As to the "why" it works, no idea... and why the lockups don't happen with the proton dxvk build (I can also confirm the same behavior), also no idea.

FWIW, I also noted difference between official and self-compiled version when I tried to use Mingw builds a while ago.
I used freshly compiled DXVK on a game I payed recently and it crashed after a few minutes of gameplay. I tried to localize the problem by recompiling toolchain with different binutils or gcc versions but with no luck. Meanwhile with official DXVK I was able to play for hours without any issues (same with winelib version).
It's not certain which build is broken, it can be correct official DXVK correctly failing where it should, but Proton DXVK not correct. Or vice-versa.
I googled there is a difference how toolchain should be compiled for cross-compilation, not only posix threads but some libraries should be linux binaries (not *.lib or *.dll) because otherwise compiler will produce broken binaries which will work but have incorrect memory management (or so). So I though it was the source of the problem in my toolchain, but I did not found what and how I should fix.

BTW, there is also llvm-mingw
Back then I was too busy testing self-compiled mingw toolchain to try this project, but it seems compile current DXVK master branch fine (despite a lot of warnings during compilation). I only checked dxvk triangle test (built with -Denable_tests=true) and it runs ok.
Could someone check if same issues present in DXVK built with llvm-mingw?

FWIW, I also noted difference between official and self-compiled version when I tried to use Mingw builds a while ago. I used freshly compiled DXVK on a game I payed recently and it crashed after a few minutes of gameplay. I tried to localize the problem by recompiling toolchain with different binutils or gcc versions but with no luck. Meanwhile with official DXVK I was able to play for hours without any issues (same with winelib version).

i'm no expert but maybe it's a problem with environment variables CFLAGS etc. With Arch Linux the file /etc/makepkg.conf might be worth checking out for instance even just commenting out all the C and LD flags to see if it makes a difference. Also looking at an example package build https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=dxvk-winelib     you can see there they use sed a bit to make sure things are a certain way with the flags.

Could someone check if same issues present in DXVK built with llvm-mingw?

Here is the build of current git master branch: dxvk-llvm-mingw.zip
I used llvm-mingw-20220323-msvcrt-ubuntu-18.04-x86_64.tar.xz. It can be extracted somewhere and used as is with DXVK, just export PATH="/path/to/llvm-mingw:${PATH}", but for this build I added full paths in original cross-files just in case.
I'm on Gentoo, and llvm-mingw looks like all-in-one I wanted all this time for DXVK cross-compilation (instead of building and configuring crossdev environment just for DXVK). I did more extensive testing with some heavy games and was able to play with almost whole RAM/VRAM/swap full without issues.

I did more extensive testing with some heavy games and was able to play with almost whole RAM/VRAM/swap full without issues.

Not really the issue in this particular case, since the game mostly stays under 1GB of RAM of system memory, and I doubt its VRAM usage is causing the lockups.
One of the 3D wizards here needs to look into why the workaround I lucked my way into appears to be working. It ultimately needs to be fixed in the standard builds.

I did more extensive testing with some heavy games and was able to play with almost whole RAM/VRAM/swap full without issues.

Not really the issue in this particular case, since the game mostly stays under 1GB of RAM of system memory, and I doubt its VRAM usage is causing the lockups.

I was my case, where DXVK compiled on my system was not able to operate properly under heavy load. So I specifically tested llvm-mingw build for this, and since it passed the test I can say this build kind of legit (at least on my system).
Still worth to check how it differ from official and Proton builds in your case, maybe this will help pinpoint the problem.

@pchome i tried using your build as a drop in replacement instead of the ones that come with proton and i could still reproduce the freeze :)

@Blisto91 thanks.
This is how Proton builds differ from defaults:

they use their own *FLAGS, auto-generated cross-files and --buildtype=plain (similar to what Gentoo does for meson projects)
https://github.com/ValveSoftware/Proton/blob/58eba7108f2b44a47a7c2ae7530363619228524f/Makefile.in#L177-L182
https://github.com/ValveSoftware/Proton/blob/58eba7108f2b44a47a7c2ae7530363619228524f/make/rules-meson.mk
there may be difference how they compile toolchain vs how it compiler by distros (flags/options/etc.)
https://github.com/ValveSoftware/Proton/blob/58eba7108f2b44a47a7c2ae7530363619228524f/docker/gcc.Dockerfile.in

So, it can be as "simple" as it was before (years ago) with -O2 vs -O3 compiler optimizations, which IIRC was single compiler flag triggered by -O3 mode and caused instability or performance hits. Or it can be effect from other flags, like -mstackrealign for 32bit builds. I doubt they use custom patches for DXVK.

Either way it's not good proton dxvk and official dxvk produce different results. Makes it harder to debug and find issues xd.
@doitsujin Do you want me to close this PR if there is something else going on?

Do we know what the root cause is?

Probably worth looking at the disasm of what the game does when it calls LockRect with DONOTWAIT. The reason we have this hack is that one HDR demo ends up literally just doing:
HRESULT hr = device->LockRect(..., DONOTWAIT)
while (FAILED(hr)) {
  // Oops, I forgot to make the result equal to this!
  device->LockRect(..., DONOTWAIT)
}

Maybe this is another instance of that.

If Proton and Wine D3D runs fine, it can be result of -mstackrealign flag in Proton, but in Wine they redefine __stdcall and __cdecl by adding __attribute__((__force_align_arg_pointer__)). This attribute has same effect as -mstackrealign but applies only to functions called by external applications (they mark them WINAPI), so do not cause big performance hit (just guessing).

-mstackrealign
Realign the stack at entry.  On the x86, the -mstackrealign option generates an alternate prologue and epilogue that realigns the run-time stack if necessary.  This supports mixing legacy codes that keep 4-byte stack alignment with modern codes that keep 16-byte stack alignment for SSE compatibility.  See also the attribute "force_align_arg_pointer", applicable to individual functions.

Even if something else in Proton "fixes" the problem maybe still worth to use __attribute__((__force_align_arg_pointer__)), at least for 32bit builds.

@pchome WINED3D run fine in both wine and proton as far as i remember.
For dxvk if you run it with the official realease/artifact/build intructions in readme then it sometimes freezes when entering city view unless the conf option is set. With dxvk included in proton it runs fine without the variable in proton and wine.

Ehm, why close it? I've tested the workaround extensively and know it works... we just don't know why :sweat_smile:. I have no idea how to debug this either in order to find out, but that doesn't make it unwarranted IMHO... the game does hang otherwise on regular builds of dxvk.

Omg...
I made a fresh fork of the dxvk repo and forget it would remove the branch... ffs :sweat_smile:


Bot required to sign CLA

URL to the linked Repo/Org: https://github.com/ChainSafe/ssz-js/pull/112
Steps to reproduce the problem:

Activate any bot and the pr will be blocked by the CLA

What is the expected result?
Greenkeeper should not be required to sign CLA

This is covered in the README. Whitelist greenkeeper[bot]

Like ghuntley mentioned, just whitelist all the bots and users who don't need to sign the CLA :)


Add indexer guide

Added a guide on creating NEAR Indexer in collaboration with @khorolets 💪

added indexer concept
added NEAR Indexer walkthrough

Fixes /near/devrel/issues/23

@thisisjoshford could you have a look at final version, please? I guess we're ready to merge it if you are confident with it.


Update building images with containerd clusters

clarification that customer can continue to use docker build will containerd clusters unless they are building images inside aks

@khowling : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


1.12 telegraf rollup

High-level description
This PR is a rollup of five existing Telegraf PRs, all of which were stuck in PR with interdependent failing tests:

#3409 (backport to 1.12 from 1.13)
#3476
#3492
#3494
#3511

Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-4061 Remove dcos-metrics
DCOS_OSS-4060 dcos-metrics API reports null values for system load
DCOS_OSS-4090 Missing expected container in response from /v0 API
DCOS_OSS-4071 Metrics v0 API changed some metric names
DCOS_OSS-4144 Remove mesos_id tag from v0 metrics API
DCOS-42339 More than 500.000 open TCP connections between mesos agents and dcos telegraf.
DCOS-41900 Remove duplicate logs from dcos_metadata
DCOS_OSS-4180 Downgrade 'empty containers' error to info

Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[x] Test Results: link to CI job test results for component
[x] Code Coverage (if available): link to code coverage report

@mesosphere-mergebot bump-ee

I'm seeing some bizarre failures on the EE PR so I've opened #3515 with the head on the mesosphere fork instead of my personal fork. Hopefully this resolved the issue.


Fix Transforms' representations

Override __str__ instead of __repr__ in Transform
Add Conjunction.__str__
Add test_str and FakeTransform.__str__
Remove __str__ override in Aggregate and _AggregateMatrices

We never discussed this last change so I'll give more details about it:
Currently, when we have an Aggregate transform and call str on it, it calls the __str__ method of Transform, which returns the class name:
>>> from torchjd.autojac._transform.aggregate import Aggregate
>>> from torchjd.aggregation import Mean
>>> A = Mean()
>>> t = Aggregate(A, set())
>>> str(t)
'Aggregate'

This does not indicate that the aggregator is Mean(), and I think it's fine like this for two reasons. We will rarely ever use several different aggregators in the same Transform, and this is in line with having Transform strings quite minimalist: for instance they do not contain the arguments of the Grad, Jac or even Select transforms.
So instead of overriding _AggregateMatrices.__str__ and Aggregate.__str__ to add the contained aggregator's string, we just use the inherited Transform.__str__ which just returns the class name.
By the way, I think that having str(t) == "Aggregate" is much better than having str(t) == "_Reshape ° _AggregateMatrices ° _Matrixify, which doesn't give any more information and is much longer.

Also note that this seems to work nicely in the debugger which seems to use str and not repr:

However, if you type:
>>> transform

in the terminal, you will get
<torchjd.autojac._transform.base.Composition object at 0x7f54daf059a0>

You have to type:
>>> str(Transform)

to get
'Jac ∘ Diagonalize ∘ Init'


⚠ Spryr has degraded performance

In 322c2ba, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3615 ms

Resolved: Spryr performance has improved in b23ee18 after 7 minutes.


localhost:8080 does not serve index.html by default

Throws a 404. Static content is inaccessible.

This is because I did not give the required command line argument. Will include this in readme.md


[WIP] shipyard.yaml reference file

Signed-off-by: Meg McRoberts<EMAIL_ADDRESS>This content was developed in 0.15.x.  The https://github.com/keptn/keptn.github.io/pull/1238 PR moves this content to 0.16.x and replaces this PR.
This PR does the following:

Creates a reference page for the shipyard.yaml file to summarize the synopsis of the file.  We will certainly refine this page more and add xrefs to this file from other pages as we move forward but, if reviewers agree, this is the general shape of the page.
Deletes old material from the manage/shipyard file that is now in this file.
Creates a separate manage/triggers file.  Note that this is unchanged from what was previously in the manage/shipyard file so does not require review for this exercise.

Issues for review:

Should this page be called "shipyard.yaml" or just "shipyard"?
Are the elements in this file "fields" or "parameters" or something else?
What should be included in the "Synopsis" section?  I tried to incorporate some tasks into the Synopsis but not sure if this works and exactly how to arrange them.
How should we handle "optional" bits in the Synopsis?  I started to surround them with square brackets (e.g. [triggeredOn...] following man page conventions but I fear that may just muddle the issue, especially for a yaml file where indentation is so significant.  Opinions?
Should we include the mini-synopses in each task section or should we get all of that in the main "Synopsis" section?  If we keep them in the individual task section, is having the "Synopsis:" lead-in helpful or just noise?
What should be on this page that is not currently included?  I am favoring keeping this terse with xrefs to other pages in the doc set for more details and examples but perhaps there is other information that should be included here.

This PR replaces https://github.com/keptn/keptn.github.io/pull/1178.

This content has been moved to https://github.com/keptn/keptn.github.io/pull/1238, which implements the changes in the 0.16.x tree.  I am closing this PR.


HTTP Error Again

Hi Dr. Wang,
I was trying to download the dataset by
import cospar as cs
adata_orig = cs.datasets.hematopoiesis()
But a HTTP error occurs since the url "https://kleintools.hms.harvard.edu/tools/downloads/cospar/LARRY_adata_preprocessed.h5ad" is now inaccessible,
And also there are some issues about gene_expression_dynamics function.
Could you check it? Thanks!

That is true. Please use the latest CoSpar in our github. This will work.
git clone https://github.com/ShouWenWang-Lab/cospar
python setup.py develop
--
Shou-Wen Wang, Ph.D.
Principal Investigator
School of Life Sciences | School of Science
Westlake University
Shilongshan ST #18, Xihu, Hangzhou, Zhejiang
https://www.shouwenwang-lab.com/
From: Zhklu2003 @.>
Date: Thursday, June 27, 2024 at 1:44 PM
To: ShouWenWang-Lab/cospar @.>
Cc: Subscribed @.***>
Subject: [ShouWenWang-Lab/cospar] HTTP Error Again (Issue #11)
Hi Dr. Wang,
I was trying to download the dataset by
import cospar as cs
adata_orig = cs.datasets.hematopoiesis()
But a HTTP error occurs since the url "https://kleintools.hms.harvard.edu/tools/downloads/cospar/LARRY_adata_preprocessed.h5ad" is now inaccessible,
And also there are some issues about gene_expression_dynamics function.
Could you check it? Thanks!
—
Reply to this email directly, view it on GitHubhttps://github.com/ShouWenWang-Lab/cospar/issues/11, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABDCASX2NF7OJBVXLTDIXKDZJORDXAVCNFSM6AAAAABJ7F46V2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3TOMJZG4ZDAMA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Thanks for help!
Also, I have met a problem. When I run the code below
import cospar as cs
adata_orig = cs.datasets.hematopoiesis_subsampled()
adata = cs.tmap.infer_Tmap_from_multitime_clones(
adata_orig,
clonal_time_points=["2", "4"],
later_time_point="6",
smooth_array=[20, 15, 10, 5],
sparsity_threshold=0.1,
intraclone_threshold=0.2,
max_iter_N=10,
epsilon_converge=0.01,
)
cs.tl.progenitor(
adata,
selected_fates=["Neutrophil","Monocyte"],
source="transition_map",
map_backward=True,
bias_threshold_A=0.5,
bias_threshold_B=0.5,
sum_fate_prob_thresh=0.2,
avoid_target_states=True,
)
gene_name_list = ["Gata1", "Mpo", "Elane", "S100a8"]
selected_fate = "Neutrophil"
cs.pl.gene_expression_dynamics(
adata,
selected_fate,
gene_name_list,
traj_threshold=0.2,
invert_PseudoTime=False,
compute_new=True,
gene_exp_percentile=99,
n_neighbors=8,
plot_raw_data=False,
)
gene_name_list = ["Gata1", "Mpo", "Elane", "S100a8"]
selected_fate = "Neutrophil"
cs.pl.gene_expression_dynamics(
adata,
selected_fate,
gene_name_list,
traj_threshold=0.2,
invert_PseudoTime=False,
compute_new=True,
gene_exp_percentile=99,
n_neighbors=8,
plot_raw_data=False,
)
I will meet a type error TypeError: asarray() got an unexpected keyword argument 'copy'.
Could you give me some advice? Thanks.

And I am wondering if you have replication code online for this CoSpar paper? Some of figures and experiments cannot be found in https://cospar.readthedocs.io/.


[ios] Fix broken use_frameworks from React-bridging

Summary
use_frameworks! is broken again in react-native 0.69 because React-bridging. in the use_frameworks! mode, header structures are flattened, so #include <react/bridging/CallbackWrapper.h> is not reachable to the header. to somehow workaround the issue without touch React-bridging imports, the pr do these things:

use header_mappings_dir to keep react/bridging header structure
because the header structure is not default framework header structure, explicitly HEADER_SEARCH_PATHS is necessary.
forward declare CallbackWrapper and use it internally in ReactCommon. so that we don't need to add HEADER_SEARCH_PATHS for React-bridging to every pods depending on ReactCommon/turbomodule/core, e.g. React-RCTSettings.podspec.

Changelog
[iOS] [Fixed] - Fix use_frameworks! for 0.69
Test Plan
$ npx react-native init RN069 --version next
# add `use_frameworks!` to ios/Podsfile
# comment out use_flipper!() in ios/Podfile
# patch node_modules/react-native with these changes
$ yarn ios

cc @dmitryrykun

thanks @cortinico @dmitryrykun. this is the minimum impact solution i can do so far. let me know whether it makes sense to you.
basically, the nested include or import like #include <react/bridging/CallbackWrapper.h> or #include <react/renderer/uimanager/primitives.h> will break use_frameworks. in framework header search, the formal way is #import <Framework/Header.h>. that's basically the main reason why use_frameworks is broken in new architecture mode. hopefully you can have some discussion for the nested import inside Meta.

Great work @Kudo, thanks!

cool. the internal CI failed from Meta looks success suddenly. that should be you folks from Meta helping. hopefully we can fix the use_frameworks problems soon.

Hello folks, I don't think this fix in in 0.69.0 as of now? Do we need a quick bump to include it?

Hey @imWildCat 👋
This is already in the list of commits for 0.69.1.

@fortmarek thanks for your prompt reply! I subscribed this discussion.

@imWildCat you might like https://github.com/mikehardy/rnfbdemo/blob/main/patches/react-native%2B0.69.0.patch


cannot use r (type *http.Request) as type "github.com/cescoferraro/api/vendor/golang.org/x/net/context".Context in argument to chi.URLParam:

func MyRequestHandler(w http.ResponseWriter, r *http.Request) {
	userID := chi.URLParam(r.Context(), "userID") // from a route like /users/:userID
	w.Write([]byte(fmt.Sprintf("hi %v", userID)))
}
func runServer() {
	venom.PrintViperConfig()
	r := chi.NewRouter()
	r.Use(middleware.Logger)
	r.Get("/:userID", MyRequestHandler)
	http.ListenAndServe("<IP_ADDRESS>:" + strconv.Itoa(viper.GetInt("port")), r)
}

[00] 2016/11/11 22:28:50 http: panic serving <IP_ADDRESS>:60547: interface conversion: interface {} is nil, not *chi.Context
[00] goroutine 8 [running]:
[00] net/http.(*conn).serve.func1(0xc420086b80)
[00] 	/usr/local/go/src/net/http/server.go:1491 +0x12a
[00] panic(0x80aac0, 0xc420013440)
[00] 	/usr/local/go/src/runtime/panic.go:458 +0x243
[00] github.com/cescoferraro/api/vendor/github.com/pressly/chi.RouteContext(0x7f9a3dc81190, 0xc420013300, 0x40d02f)
[00] 	/go/src/github.com/cescoferraro/api/vendor/github.com/pressly/chi/chi.go:70 +0xed
[00] github.com/cescoferraro/api/vendor/github.com/pressly/chi.URLParam(0x7f9a3dc81190, 0xc420013300, 0x876383, 0x6, 0xc420013300, 0x1)
[00] 	/go/src/github.com/cescoferraro/api/vendor/github.com/pressly/chi/chi.go:77 +0x39
[00] github.com/cescoferraro/api/cmd.MyRequestHandler(0x7f9a3dc81158, 0xc420013400, 0xc4200c23c0)
[00] 	/go/src/github.com/cescoferraro/api/cmd/server.go:40 +0x84

What am I missing here? ON the README it says  userID := chi.URLParam(r, "userID") // from a route like /users/:userID but URLParams signature does not like this func URLParam(ctx context.Context, key string) string {

Hey, @cescoferraro. The chi.URLParam function receives a *http.Request as parameter but you are passing a context.Context.
To fix your code, use
chi.URLParam(r, "userID")

@ustrajunior I did not made myself clear
with chi.URLParam(r, "userID") I get
cannot use r (type *http.Request) as type "github.com/cescoferraro/api/vendor/golang.org/x/net/context".Context in argument to chi.URLParam
with userID := chi.URLParam(r.Context(), "userID") I get
interface conversion: interface {} is nil, not *chi.Context

probably because your vendored x/net/context is either behind the 1.7 one or ahead (with brad's new 1.8 cancelfunc changes). if you unvendor it should work.

Having the same described problem here, removing my x/net/context did not solve the issue. My solution was as @cescoferraro mentioned, pinning my vendor to v2.0.0rc1 (just fyi for future readings)

hey guys, yea, @pxue called it. It's the mix up between x/net/context and context which are not compatible with eachother, they are technically different types. Perhaps in 1.9 when they figure out aliasing this will get smoothed out.. that is a while from now. I bet there would be a way to make some pkg that allowed you to use both because it would translate between the types, perhaps I'll write that one day.


Display the day!

In this app, display the day when I'm logging to make it easier for me to track which days have been logged etc
https://mvcfamilyapp20191103.azurewebsites.net/DailyLogs

Yes, I've got it working!


Cleanup P and Underline tags

#Paragraph tags will now get cleaned similar to spans.
#textDecoration: underline will now be replaced with U tags
#INS tags will be replaced with U tags.

Merged, with a few tweaks. Thanks!


[Enhancement] Automatically create partitions to optimize the use of batch interfaces

Fixes #issue
Opt create 1000 partition from 70s -> 15s in my env.
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[x] 3.0
[ ] 2.5

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:disappointed: fail : 38 / 76 (50.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/ListPartitionDesc.java
0
6
00.00%
[77, 78, 79, 81, 82, 84]

:large_blue_circle:
com/starrocks/load/InsertOverwriteJobRunner.java
0
7
00.00%
[244, 254, 255, 256, 257, 258, 259]

:large_blue_circle:
com/starrocks/sql/analyzer/AnalyzerUtils.java
11
22
50.00%
[961, 962, 973, 974, 975, 976, 977, 978, 981, 982, 983]

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
9
17
52.94%
[2228, 2229, 2246, 2247, 2248, 2249, 2250, 2251]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
18
24
75.00%
[885, 886, 887, 1259, 1269, 1270]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 71 / 84 (84.52%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
11
17
64.71%
[2246, 2247, 2248, 2249, 2250, 2251]

:large_blue_circle:
com/starrocks/load/InsertOverwriteJobRunner.java
11
15
73.33%
[258, 259, 260, 269]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
21
24
87.50%
[1259, 1269, 1270]

:large_blue_circle:
com/starrocks/sql/ast/ListPartitionDesc.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AnalyzerUtils.java
22
22
100.00%
[]

@Mergifyio backport branch-3.2

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0


Adds file_browser.html example (update for row_headers feature)

Updates #19 from @telamonian to rely on the new row_headers feature introduced in #24 .  The add-filebrowser-example branch was first rebased:

Commit history was squashed to 1 commit
Changes to tree_row_header.js and 'events.js` were removed.
Changes to perspective.html were removed (which relied on the above).
README.md changes reverted (no need to add your example to the gallery - I'll do this automatically via script when I dist).

Next, the example was refactored.  Unfortunately some of my comments from the original PR were quickly outdated by rapid progress on this API.

Removes __config, __collapse and __expand pass-through.
Uses row_headers instead of row_indices, et al columns.
Adds a custom tree_header renderer ala perspective.html, modified to handle the lack of an empty 'root' node.
Adds a click handler to dispatch to collapse and expand()
Refactors code into 2 script sections - "fake filesystem generator" and "data model for regular-table" sections.
General cleanup and lint-powered reformat.

Thanks for the review!  I will think about concise ways to name the "corner" as well, PRs welcome.


ARC-1092 Autoscaling for branch and deployment queues

Autoscaling based on branch and deployment queue messages

Looks good in ddev so I am going to merge


Use go base image

Description
Changes to point to Default go image version in common.mk file.
GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

https://github.com/dell/csm/issues/1098

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[ ] I have verified that new and existing unit tests pass locally with my changes
[ ] I have not allowed coverage numbers to degenerate
[ ] I have maintained at least 90% code coverage
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Backward compatibility is not broken

How Has This Been Tested?
Image build:

@panigs7 , Please keep this request on hold until I have resolved all issues identified by gosec. I have already submitted it for review as part of https://github.com/dell/csi-metadata-retriever/pull/42. Thank you.


Furo documentation : the show source button

Hi,
This is an informative issue for the furo theme:  if you want the 'show source' button you have to use the furo (https://github.com/pradyunsg/furo/releases/tag/2022.01.02) release.
See:

https://github.com/pradyunsg/furo/discussions/443
https://github.com/pradyunsg/furo/discussions/374

Thank you Simon for for your fantastic work !

The build logs for https://shot-scraper.datasette.io/en/0.14.1/ on https://readthedocs.org/projects/shot-scraper/builds/17012547/ show that it used furo-2022.4.7-py3-none-any.whl
In #82 I'm trying the most recent Furo release.

Oh, I think I see - I would need to set html_show_sphinx = True if I wanted to include that "Show source" link in my documentation.
Since the docs are available as raw markdown in GitHub I don't plan to add that setting.


fix: port script crash on python 3.8

The previous syntax was only valid in Python 3.10 and onwards.

bors merge
Thanks!


Concurrent INFO() calls crash [multithreading]

Description
As the title suggest the test case below crashes either by segfault or double free. The problem does NOT occur with, say, WARN(). I assume because INFO() buffers the messages in a non-thread-safe way.
Steps to reproduce
TEST_CASE("concurrent infos")
{
  std::thread t([]() {
    for (int i = 0; i < 100; ++i)
      INFO("i: " << i);
  });
  for (int i = 0; i < 100; ++i)
    INFO("i: " << i);
  t.join();
}

Extra information

Catch version: 3a3f1529794059e1f8947c1d44ed10327b2a35d8
Operating System: CentOS (devtoolset-6)
Compiler+version: gcc 6.2/icc 2017

Many thanks for Catch!
Aram

I probably should have mentioned other macros as well as assertions, but Catch is not thread safe.

I see. In that case I believe it would be helpful to mention it also in the "Assertion macros" "Logging macros" doc files in the reference section.

I will think about it


Selection event handlers

This PR simplifies the process of setting up Tangram feature selection callbacks (such as on hover or click), removing the need for boilerplate code for DOM events by tying into Leaflet's existing event handlers.
A new concept of selection event handlers has been added to Tangram, currently with two events supported:

hover
click

Selection event handlers will be passed the same selection object returned by direct calls to scene.getFeatureAt() (which is still supported and available for custom input/event needs).
Two additional properties have also been added to the returned selection object:

pixel: the XY location within the map container where the event occurred, in the form { x, y } (this wasn't previously necessary since the user already needed to pass it explicitly to getFeatureAt(pixel))
leaflet_event: the Leaflet event that triggered the selection is also passed through (it contains information that may be useful for deeper or existing Leaflet integrations)

Handlers for these events can be configured in two ways:
When creating the Leaflet layer:
An events object can be passed with other leaflet layer options. hover and/or click properties can be set to a callback function:
var layer = Tangram.leafletLayer({
   scene: 'scene.yaml',
   events: {
      hover: function(selection) { console.log('Hover!', selection); },
      click: function(selection) { console.log('Click!', selection); }
   }
};

Updated after Leaflet layer creation:
Selection events can be added, changed, or removed after layer creation with a call to layer.setSelectionEvents(events). It takes the same events object as above:
layer.setSelectionEvents({
   hover: onTangramHover,
   click: onTangramClick
});

Or, to remove an event, layer.setSelectionEvents({ click: null });.

cc @nvkelso @meetar @louh


[Unity Plugin] Query all OpenCL capable devices for Radeon Rays

Steam Audio Forum related to this issue.
Currently, Steam Audio Unity plugin fails if the first OpenCL device does not support Radeon Rays. Go through all the devices before complete failure in case another OpenCL device does support Radeon Rays.

This crash archive with Unity-project:
https://www.dropbox.com/s/xy6ckahi8778zny/Unity crash Steam Audio.zip?dl=0

The latest release, Steam Audio 2.0-beta.18, includes a fix for this bug.


Expose the TypedEvent conversion trait

This is a trivial API changes that exposes the tendermint::abci::event::TypedEvent marker trait.

[ ] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[x] Added entry in .changelog/

Codecov Report

Merging #1296 (907841a) into main (7955217) will increase coverage by 0.0%.
The diff coverage is n/a.

:exclamation: Current head 907841a differs from pull request most recent head 442dc0c. Consider uploading reports for the commit 442dc0c to get more accurate results

@@          Coverage Diff          @@
##            main   #1296   +/-   ##
=====================================
  Coverage   64.2%   64.3%
=====================================
  Files        271     271
  Lines      24450   24450
=====================================
+ Hits       15719   15722    +3
+ Misses      8731    8728    -3

see 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix devices error

Fixes Sentry error KAP-3G8
TypeError: devices.some is not a function

I agree with the change, but it would be good to figure out why devices is not an array in the first place.


Renaming .paml file does not rename code-behind file.

Migrated from https://github.com/Perspex/Perspex/issues/381

This issue does not occur with xaml files, and we've already switched the perspex templates and the designer to xaml.
I guess no need to try and fix this.

Great news! I will close the issue then.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: zbachore sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[YUNIKORN-932] Added some extra log message

What is this PR for?
Added a few new log messages for the case when there is no outstanding requests.
Also added a log message for the recovery part, to check if we got an answer from the api server or not
What type of PR is it?

[ ] - Bug Fix
[X] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-932
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Thank you @wilfred-s for the review!


Added aria properties

This pr is pretty naive. There may be things things missing and I'm pretty sure that the indexed version could be more restrictive.

I don't think any of these are properties, but are instead attributes. A "property" is something that exists in the prototype of HTML elements, and will often have an alternative javascript name to avoid name clashes or illegal identifiers. For example, the class attribute has a corresponding className property, for is htmlFor, etc.
As far as I can tell, there is no "built in" ARIA support at the javascript level, as none of these have associated property names if you start poking around the DOM with the web inspector.
Looks like we'd want to add the role attribute too? (Which again is an attribute, not a property).
As for the indexing, we'll definitely want to consider doing something else there. As it stands all those properties will be unusable :smile:. I'd suggest just using a type variable for the row, which will allow the aria attributes to be used on any element. This is perhaps not totally ideal, as we're basically throwing away what indexing gives us, but in this case the attributes are associated with particular roles rather than elements, and we definitely don't have a way of modelling that with the current indexing.
I'd also suggest we define these in a Halogen.HTML.Properties.ARIA module perhaps, and not drop them in with the more common properties?

That makes sense. I agree they aren't properties.
I spent a little while reading Halogen.HTML.Properties.Indexed and couldn't work out exactly what I needed to do to make these restricted by their role so your suggestion of making them work for every element sounds sensible.
The two main problems I had were

I haven't been able to work out how to make these specifically attributes. ThepropNames aren't wrapped in a Maybe like the attrNames are.

It didn't seem quite right to add these to the GlobalAttributes synonym.

How would I go about "using a type variable for the row, which will allow the aria attributes to be used on any element"?

Ah sorry, I should have explained more!

To make them attributes we just use the Attr constructor rather than prop.
The type variable row thing is just using a type like ariaDescribedby :: forall r i. String -> IProp r i - since r is left unspecified it will unify with any row, making it compatible with any element.

Thanks thats super clear now : )

@garyb not sure why travis took half an hour but this is ready for a second look when you are available : ).

It just takes that long now unfortunately. Code good to me, can you regenerate the docs and I'll do one final check through?

Docs regenerated.

Sorry a few more things:
Can you add the new ARIA modules in here https://github.com/slamdata/purescript-halogen/blob/b8353d53a536b9b9cebda6984956459a8a8afb17/gulpfile.js#L46-L72 and then do the docs
For the new props, do you think maybe we should camelcase them? I'd probably expect things to be like ariaValueMin rather than ariaValuemin, ariaLabelledBy instead of ariaLabelledby, etc.
What do you think about dropping the aria prefix too? As they're in their own modules they can be imported under a separate namespace to avoid confusion/collision with other properties/attrs.

If you're happy with matching value names across these modules e.g. selected such that they should be used like
import Halogen.HTML.Properties as P
import Halogen.HTML.Properties.ARIA as PA

instead of
import Halogen.HTML.Properties as P
import Halogen.HTML.Properties.ARIA as P

Then I'm happy to remove the aria prefix.
I totes prefer the camelcased one. I was trying to stay consistent with things like readonly but perhaps "readonly" is a single word? The web lol!

Yeah, importing as PA or ARIA was what I had in mind - also because importing multiple modules as the same thing will be a warning in 0.8 unless they're imported with an explicit list (import X (y, z) as A) so as to avoid problems with name collisions if modules are extended at a later date.
And that is an excellent point, just use your discretion as to where the humps should go. :laughing:

I renamed the values. I chose to camelCase all of them to keep the module consistent.
I also updated the gulpfile and docs.

All looks great, thanks!


CLI communication with the API of APIM exposed in APIM

Jeremy is not able to reach directly the API Manager, the CLI is instanced in a Jenkin slave to communicate with the API Manager, he have no other solution than publishing the API of the API Manager in the API manager with a Virtual host protection.
The API exposition is normalyzed and look like;  https://intranet-api:443/fr/apim/v13/portal....
The API is configured without security.
The actual configuration file have only server and port parameter.

This will be implemented as an additional parameter that can be set to anything and if set, it will be replace the default value set internally. Obviously the customer has to take care pointing to the same version number as the CLI is doing, which is currently 1.3. I'll make that clear in the documentation.
As any other the parameters, the new one: APIMANAGER_API_BASEBATH can be set as a command-line parameter or the environment properties file.
Here is an example:
APIMANAGER_API_BASEBATH=/fr/apim/v13/portal

This will be implemented as an additional parameter that can be set to anything and if set, it will be replace the default value set internally. Obviously the customer has to take care pointing to the same version number as the CLI is doing, which is currently 1.3. I'll make that clear in the documentation.
As any other the parameters, the new one: APIMANAGER_API_BASEBATH can be set as a command-line parameter or the environment properties file.
Here is an example:
APIMANAGER_API_BASEBATH=/fr/apim/v13/portal


Implement new UI as VueJS / TypeScript Project

Signed-off-by: Frank Jogeleit frank.jogeleit@web.de<!--  Thanks for sending a pull request!  Here are some tips for you:

If this is your first time, please read our contributor guidelines in the CONTRIBUTING.md file.
Please label this pull request according to what type of issue you are addressing.
If the PR is unfinished while opening it specify a wip in the title before the actual title, for example, "wip: my awesome feature"
-->

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area tests

What this PR does / why we need it:
Release v1.0.0
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from issif after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

LGTM label has been added.  Git tree hash: 1cdee4d5ca1194e95562f98faa05cccbfbd09bca

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fjogeleit
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fjogeleit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fjogeleit
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fjogeleit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Issues with the Find a Store store tiles

Description:  The tiles do not match the visuals provided. The text is centered and should be left justified. The padding is wrong, and there are icons missing near textlinks
How to duplicate: Go to the Store finder and choose “use my location” view results.

PR: GH-2586


[BEAM-12546] Swap to use ArrayBlockingQueue to improve performance of QueueingBeamFnDataClient

Saw about a 3.5% reduction in nexmark query 5 pipeline execution time and pipeline cost on Dataflow.
Nexmark query 1 and query 10 weren't CPU bound in this location so minimal improvement expected in pipelines that don't spend a lot of CPU time here.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @ajamato

LGTM. Assuming you verified this did increase performance.

Run Java PreCommit

LGTM. Assuming you verified this did increase performance.

Yeah, it was minor in almost all cases except when this QueueingBeamFnDataClient became the bottleneck.


Minor Improvement

Add final
Unnecessary semicolon ''
Use StandardCharsets
Fix javadoc

Coverage decreased (-0.002%) to 98.454% when pulling 6ba7b2965ddd702858b8a4603c2a42875d280655 on arturobernalg:feature/minor_improvement into 7ebb8db97794986ef958a8b9a50d057940b58105 on apache:master.


Quick action - Split expense is created in a new group chat when splitting from Quick action

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Go to FAB > Split expense > Manual.
Create manual split expense with two users.
Go to FAB
Click Split expense under Quick action.
Create another split expense.

Expected Result:
The new split expense will be created in the same group chat (production behavior).
Actual Result:
The new split expense is created in a new group chat.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/dab5aa85-bca1-4b58-adf6-a84390f6d92f

View all open jobs on GitHub

@MonilBhavsar FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this bug might be related to #vip-split

Is this working correctly on production?

On prod, the split is added to the same group chat. On staging, it is added to a new group chat.

@Gonals can you please have a look? Seems like we might not be saving the correct reportID to the NVP in this case

This does seem like a server side issue to me

I was wrong. QuickAction NVP seems correct, so client side issue

Proposal
Please re-state the problem that we are trying to solve in this issue.
The new split expense is created in a new group chat.
What is the root cause of that problem?
When we create split bill via QAB, we're calling splitBillAndOpenReport which will always create a new optimistic report because in this function, we call createSplitsAndOnyxData with existingSplitChatReportID param as empty
https://github.com/Expensify/App/blob/944751fcec525ece0da16a6a4efd80ad8ab4ff8c/src/libs/actions/IOU.ts#L3597
https://github.com/Expensify/App/blob/944751fcec525ece0da16a6a4efd80ad8ab4ff8c/src/pages/iou/request/step/IOURequestStepAmount.tsx#L186
What changes do you think we should make in order to solve the problem?
In the case we create a split bill via QAB that means the report already exists we should call splitBill function which already handle this case and also navigate to the correctly report after creating.
What alternative solutions did you explore? (Optional)
NA

Proposal
Please re-state the problem that we are trying to solve in this issue.
The new split expense is created in a new group chat.
What is the root cause of that problem?
When we create split bill via QAB, we're calling splitBillAndOpenReport which will always create a new optimistic report because in this function, we call createSplitsAndOnyxData with existingSplitChatReportID param as empty
https://github.com/Expensify/App/blob/944751fcec525ece0da16a6a4efd80ad8ab4ff8c/src/libs/actions/IOU.ts#L3597
https://github.com/Expensify/App/blob/944751fcec525ece0da16a6a4efd80ad8ab4ff8c/src/pages/iou/request/step/IOURequestStepAmount.tsx#L186
What changes do you think we should make in order to solve the problem?
In the case we create a split bill via QAB that means the report already exists we should call splitBill function as the same here which already handle this case and also navigate to the correctly report after creating.
https://github.com/Expensify/App/blob/944751fcec525ece0da16a6a4efd80ad8ab4ff8c/src/pages/iou/request/step/IOURequestStepAmount.tsx#L186
We should fix the same for IOURequestStepScan and IOURequestStepDistance page
What alternative solutions did you explore? (Optional)
NA

@Gonals can you please have a look? Seems like we might not be saving the correct reportID to the NVP in this case

I noticed this bug, but it didn't have anything to do with the QAB (when I tested). It happened for non-QAB flows too 🤷
I'll test again in a bit

Yep. This happens whenever you try to split again between the same group, QAB flow or not. Not a blocker

Thank you for looking Alberto!
@nkdengineer can you please confirm your proposal for all the split cases

@nkdengineer can you please confirm your proposal for all the split cases

@MonilBhavsar Sure, the bug only happens when we create a split request with skipping the confirmation step (via QAB). So we only need to fix this case as I mentioned in my proposal.

@nkdengineer's proposal looks good to me
🎀👀🎀 C+ reviewed

@DylanDylann The PR is here.

Payments made and job closed. @DylanDylann can you take care of the checklist? Thanks!

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/39413
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/39413#discussion_r1588976721
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal

Go to a group chat
Create a split bill in this group
Go FAB and click on quick action button
Create the split bill again
Verify that the split bill is created in the group chat above

Do we agree 👍 or 👎

Looks good, but we might have a regression here https://github.com/Expensify/App/pull/40961#issuecomment-2095565285

@MonilBhavsar I tested and it still works for me on the latest main.

tested and it still works for me on the latest main.

👍 We can close this after creating regression test

Filing thing, thanks all!


[IOTDB-3485] Insert with wrong type didn't return error massage

IT added

Coverage decreased (-0.008%) to 44.111% when pulling aca688baab77e763444bcc71985ae4176fb8ccb4 on insertValidate into 16314af65afe20d8e7ffeeac6465027335e4ad11 on master.


Improve paradigm presentation - "Elegant decluttering"

We want to add some way to distinguish sections of the paradigm presentation without confusion.

Separate linguistic content from labels
Separate sub paradigms from each other better

Also addressing #1013 #1014 #1012

For future search: Accordion

Also see UAlbertaALTLab/morphodict-frontend#66


New NotBlankString type in org.kotools.types.text package

Description
We would like to introduce an experimental NotBlankString type in the org.kotools.types.text package, declared as class instead of value class, for making it available on all Kotlin platforms and on Java in a backward compatible way.
Here's the minimum viable Kotlin API that this type should have:
interface NotBlankString : Comparable<NotBlankString> {
    companion object {
        fun create(value: Any?): NotBlankString = TODO()
        fun createOrNull(value: Any?): NotBlankString? = TODO()
    }

    override fun compareTo(other: NotBlankString): Int
    override fun equals(other: Any?): Boolean
    override fun hashCode(): Int
    override fun toString(): String
}

Like the kotools.types.text.NotBlankString type, this new type should be serializable as String.
Here's an example of Kotlin code that encodes and decodes this type using the JavaScript Object Notation (JSON) format from kotlinx.serialization:
val text: NotBlankString = NotBlankString.create("Kotools Types")
val encoded: String = Json.encodeToString(text)
println(encoded) // "Kotools Types"
val decoded: NotBlankString = Json.decodeFromString(encoded)
println(decoded == text) // true

Checklist

[ ] Add the type with a private constructor, update the public API binaries and update the unreleased changelog.
[ ] Add the create function, test its behavior with Kotlin and its compatibility with Java, update the public API binaries and reference this new function in the documentation of the type.
[ ] Add the createOrNull function, test its behavior with Kotlin and its compatibility with Java, update the public API binaries and reference this new function in the documentation of the type.
[ ] Add the toString function, test its behavior with Kotlin and its compatibility with Java, then update the public API binaries.
[ ] Add the equals and the hashCode functions, test their behavior with Kotlin and their compatibility with Java, then update the public API binaries.
[ ] Make the type serializable, test its serialization and deserialization processes, update the public API binaries and the documentation of the type.
[ ] Make the type implementing Comparable, test the behavior of compareTo with Kotlin and its compatibility with Java, update the public API binaries and the unreleased changelog.
[ ] Close this issue and update the tracking ones if present.

The compatibility of NotBlankString with Java will be implemented by the issue #404.


Deploy app to Heroku

Storing credentials
https://stackoverflow.com/questions/50928752/best-way-define-important-credentials-in-spring-boot

Should I use the main branch or create a release branch for deployment?

To deploy:
git subtree push --prefix my-app heroku master

https://cobudget-backend.herokuapp.com/


t2t_usr_dir doesn't work

Dear all,
I want to add my own hyper-parameter settings by using --t2t_usr_dir option as described in
https://github.com/tensorflow/tensor2tensor/blob/master/docs/walkthrough.md#adding-your-own-components
To do this, I created a dir on ~/usr/t2t_usr and added following codes:
# In ~/usr/t2t_usr/__init__.py
from . import my_registrations

# In ~/usr/t2t_usr/my_registrations.py

from tensor2tensor.models import transformer
from tensor2tensor.utils import registry

@registry.register_hparams
def transformer_my_very_own_hparams_set():
  hparams = transformer.transformer_base()
  hparams.hidden_size = 1024

Then, I run the following commands to register it:
t2t-trainer --t2t_usr_dir=~/usr/t2t_usr --registry-help
But I got the following errors:
INFO:tensorflow:Importing user module t2t_usr from path /path/to/usr
Traceback (most recent call last):
  File "/path/to/.pyenv/versions/tensorflow/bin/t2t-trainer", line 191, in <module>
    tf.app.run()
  File "/path/to/.pyenv/versions/anaconda3-5.0.1/envs/tensorflow/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 124, i
n run
    _sys.exit(main(argv))
  File "/path/to/.pyenv/versions/tensorflow/bin/t2t-trainer", line 182, in main
    hparams = create_hparams()
  File "/path/to/.pyenv/versions/tensorflow/bin/t2t-trainer", line 81, in create_hparams
    return tpu_trainer_lib.create_hparams(FLAGS.hparams_set, FLAGS.hparams)
  File "/path/to/.pyenv/versions/anaconda3-5.0.1/envs/tensorflow/lib/python3.6/site-packages/tensor2tensor/tpu/tpu_trainer_lib.py", line 75,
 in create_hparams
    hparams = registry.hparams(hparams_set)()
  File "/path/to/.pyenv/versions/anaconda3-5.0.1/envs/tensorflow/lib/python3.6/site-packages/tensor2tensor/utils/registry.py", line 171, in
hparams
    display_list_by_prefix(list_hparams(), starting_spaces=4)))
LookupError: HParams set  never registered. Sets registered:
    aligned:
      * aligned_8k
      * aligned_8k_grouped
      * aligned_base
      * aligned_grouped
      * aligned_local
      * aligned_local_1k
      * aligned_local_expert
      * aligned_lsh
      * aligned_memory_efficient
...

Does anyone have any suggestion to fix this?
Thank you in advance.

also I have the same problem


Serialization can't handle inf

This is a separate serialization bug from #213.
It appears that when _T=inf, boost throws an exception on reading it.
https://stackoverflow.com/questions/28696663/boost-serialization-1-5-5-crash-when-meets-nan-and-inf
In KernelTest::t5 this is due to the _T member of Simulation which is not initialized yet from the NSDS, but even if that were fixed, it wouldn't fix the larger issue of handling inf, since that is a valid value for finalT, so I make an issue here until we find a work-around.

This is only a problem for xml files I believe, it shouldn't affect binary archives.
By the way I just experimented with removing _T from Simulation, do we need it there?  It was only like a 3-or 4-line change.  In principle it can be different from NSDS->finalT(), but then we just set it in EventsManager directly from there and skip storing it in Simulation, seems to work well enough.
This doesn't fix it though.  I just realized I made a mistake in the issue description, it is not Simulation::_T that causes a problem, but EventsManager::_T, which maybe just needs to be initialized in the right place.  (In t5, a simulation step is not executed, so not all initialization takes place with the new scheme.)

https://github.com/siconos/siconos/commit/f6b88b4114ac3d1aab124cb4f155edf698b0ee85 fixes KernelTest::t5
but i'll leave this open as xml serialization is very brittle if we can't read nan and inf


Punycode dependency isn't transpiled

When using commons-validator-js in the browser, it is pulling in punycode which isn't transpiled, causing errors in browsers without robust es6 support.
From the punycode.js release notes:
"This release drops support for old environments. Punycode.js v2.0.0 targets Node.js v6+ and nothing else. For the old version that offers the same functionality with broader support, including Rhino, Ringo, Narwhal, and web browsers, see v1.4.1."

Good catch, thanks!


Allow NavItem to accept regular element props (e.g. onClick)

Currently NavItem does not accept any props other than the few defined in it's interface.
It might make sense to allow people to give it regular props.

Update: this is actually a bug.
Accepts regular html attributes
https://github.com/dabapps/roe/blob/master/src/ts/components/navigation/nav-item.tsx#L6
But does not apply ...remainingProps


🌇 Sunsetting Jaeger clients 🏁

The Jaeger clients have faithfully served our community for several years. We pioneered many new features like remotely controlled samplers and per-operation / adaptive sampling, which were critical to the success of tracing deployments at large organizations. However, now that the larger community in OpenTelemetry has caught up with the Jaeger clients in terms of feature parity and there is full support for exporting data to Jaeger, we believe it is time to retire Jaeger's native clients and refocus the efforts on the OpenTelemetry SDKs.
For new applications, we recommend using the OpenTelemetry APIs and SDKs. For applications that are already instrumented with the OpenTracing API, we recommend replacing the Jaeger client with the corresponding OpenTelemetry SDK and the OpenTracing shim/bridge (available in most languages supported by Jaeger). We published a blog post that shows an example of the migration steps for Java: "Migrating from Jaeger client to OpenTelemetry SDK".
We will announce the deprecation of Jaeger clients at the beginning of November and give people till the end of year to submit any fixes/PRs. Then in January 2022 we will make the final releases of Jaeger clients and stop accepting new PRs (unless a security issue is discovered).

This is a tracking issue to make the respective changes in the docs/website and in the Jaeger client repos.

[x] docs/website https://www.jaegertracing.io/docs/latest/client-libraries/#deprecating-jaeger-clients
[x] #3380
[x] #3381
[x] Go client

Notice https://github.com/jaegertracing/jaeger-client-go/commit/68a1fa6911d73c55113dbe57d5d2eb312f8eda6a

[x] Java client

Notice https://github.com/jaegertracing/jaeger-client-java/commit/49d40135fe3ed81048f0ba55246240edc71811bf

[x] Python client

Notice https://github.com/jaegertracing/jaeger-client-python/commit/a81052e73d238692ed5c6101aab420f51d414a64

[x] Node.js client

Notice https://github.com/jaegertracing/jaeger-client-node/commit/ddb639d9985e38fd8ea93be73b004f4014760989

[x] C# client

Notice https://github.com/jaegertracing/jaeger-client-csharp/issues/230

[x] C++ client

Notice https://github.com/jaegertracing/jaeger-client-cpp/issues/292

I would like to get a vote from all maintainers before we proceed.
@albertteoh
@joe-elliott
@jpkrohling
@pavolloffay
@vprithvi

+1

In light of this announcement, is the all-in-one code already reflecting the recommended direction? Would it be already (or potentially) a getting started guide to this migration for the go community?

Good point, we could dogfood the upgrade ourselves this way. Also in the hotrod example.

Added

upgrade HotROD example
upgrade internal use of Jaeger client

@rbroggi are you interested in giving one of these a try?

Added

upgrade HotROD example
upgrade internal use of Jaeger client

@rbroggi are you interested in giving one of these a try?

Would love to :slightly_smiling_face:

Added

upgrade HotROD example
upgrade internal use of Jaeger client

@rbroggi are you interested in giving one of these a try?

Would love to slightly_smiling_face

After studying the APIs it seems that there is no native way of representing the jaeger-client config.Metric and config.Logger. My understanding is that we would loose in the all-in-one and HotROD the functionalities carried by those two parameters. Is my assessment right? If it's wrong would you please point me to resources/ideas/documents that show how to reach same features in open telemetry?

Can you elaborate (or point to code)?  I am not sure what dependency on the logger we would have as logging from the SDK itself is not that interesting. For metrics - yes, I can see that might create some challenge, I don't really know if OTEL SDK exposes the same indicators about its performance as Jaeger SDK did. It's not that we have specific dependencies on those indicators though (they should be mentioned in the blog post on HotROD).

+1
We will personally not be able to move to OTEL clients until they support remote sampling, but I think starting this migration is the right choice.

Exciting news. Is there any timeline to keep accepting the security fixes? Are there any long-term plans to communicate the deprecation from the SDKs themselves, such as logging that SDKs are deprecated/sunset?

@rakyll good points. Do you have any thoughts on those timelines? I would prefer to go no longer than 6m, because keeping up with dependencies upgrades is also a sizeable effort (especially for doing releases after those upgrades).

Deprecation notices in all client repos (except C#) are made. Documentation is updated: https://www.jaegertracing.io/docs/latest/client-libraries/#deprecating-jaeger-clients

Sorry, you seem to missed some when tagging the maintainers in the initial post. I will deprecate C# later today once I'm in the office.

One aspect that I've found lacking is the documentation about how to setup Jaeger to work with opentelemetry clients.  The Jaeger documentation makes mention of using the OpenTracing bridge, but doesn't seem to mention whether any changes are needed on the Jaager server side.  It still isn't clear to me whether one would need to run the OTEL collector in addition to the Jaeger server.

@EronWright

you only need OpenTracing bridge if your code is still using OpenTracing instrumentation. If you use OpenTelemetry instrumentation, it will work with OTEL SDK directly without a bridge.
Whether you need/want OTEL collector depends on your setup. If you configure OTEL SDK to export data in OTEL native format (like OTLP), then you will need OTEL collector for now (in the future Jaeger collector will accept OTLP directly, this is part of Jaeger V2 work). But you can also configure OTEL SDK to use Jaeger exporters and send data directly to Jaeger collector.

Sadly not everyone can switch as easy to OTEL. The C# client only supports .NET Core and ASP.NET Core. Other platforms, especially Xamarin, are no longer supported. Therefore we are currently stuck using the jaeger-client-csharp.

Yes, that's fair, this is why the OpenTelemetry bridge was introduced, to ease the migration. If there are issues with the bridge implementation, please open tickets in the respective OTEL repo.

Ticket is open (and linked in my previous post). Just wanted to have it here as a note for anyone doing Mobile on .NET.
There is sadly no easy way for solving this. The technique used in the implementation is just not available on those platforms (and won't be in the foreseeable futures AFAIK) and doing it differently would basically mean to have a completely new implementation for .NET.

This issue has been around for almost 2yrs, and all of the planned work has been completed, so closing it and removing from pinned.


tiny model ckpt not match the model weights

When I use the tiny model and find that some of the shapes in the model do not match the shape of the model
this is the ckpt:vssm_tiny_0230_ckpt_epoch_262.pth

this is the model weights:

this is the model config:

So where do you get that config file?

So where do you get that config file?

from the readme table 'Classification on ImageNet-1K with VMambav2'
https://github.com/MzeroMiko/VMamba/blob/main/classification/configs/vssm/vmambav2_tiny_224.yaml

It seems that the hyper-parameter in the picture your provide mismatch what in https://github.com/MzeroMiko/VMamba/blob/main/classification/configs/vssm/vmambav2_tiny_224.yaml, e.g.  ssm_d_state=16 in your fig, but SSM_D_STATE=1 in the yaml config. Fix that and try again.

It seems that the hyper-parameter in the picture your provide mismatch what in https://github.com/MzeroMiko/VMamba/blob/main/classification/configs/vssm/vmambav2_tiny_224.yaml, e.g. ssm_d_state=16 in your fig, but SSM_D_STATE=1 in the yaml config. Fix that and try again.

oh, this is my mistake, thanks.


Update non-standard-users.md

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

Approved

@joeyglocke
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

Approved

I’m not sure I have that permission for these PRs. I’ve never done that
before.
On Wed, Nov 30, 2022 at 5:21 PM Manuela Scanu @.***>
wrote:

@joeyglocke https://github.com/joeyglocke Thanks for approving. Could
you please help us merge? Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/7802#issuecomment-1333010897,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMODQNNNNZIMPQBJHQQGTCDWK74QTANCNFSM5DXP2MUA
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

@SerdarSoysal
@joeyglocke
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@SerdarSoysal
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@SerdarSoysal
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Tanka should manage the namespace resource

In the current setup, one needs to create the namespace manually or with k.core.v1.namepace. However, in line with letting Tanka set the namespace on a resource at runtime (based on the environment), it should also create and own a namespace if it doesn't exist already.
In this way, we completely mitigate the need of defining a namespace resource in Jsonnet and we wouldn't need a manual action to get one.
WDYT?

What if a namespace is part of the defined set of resources? I typically do this because I include labels and annotations to my namespaces.
Tanka could benefit from a concept of resource deploy ordering? Maybe that should be a separate issue?

@ghostsquad Tanka already sorts resources by dependency (namespaces + crd's first, etc).
This is probably about having the environment implicitely include it's default namespace, so you don't need to add it manually

Exactly, if a namespace is created and managed in the jsonnet code, tanka should not interfere (also because of backwards compat).

@ghostsquad Tanka already sorts resources by dependency (namespaces + crd's first, etc).

@sh0rez is it possible to manipulate that ordering?

Not stale

This has not come up in recent discussions, namespace handling appears to work just fine. Closing this issue.
Feel free to open another issue if urgent action becomes needed

This has not come up in recent discussions, namespace handling appears to work just fine. Closing this issue.
Feel free to open another issue if urgent action becomes needed