[SPARK-31278][SS] Fix StreamingQuery output rows metric

What changes were proposed in this pull request?
In Structured Streaming, we provide progress updates every 10 seconds when a stream doesn't have any new data upstream. When providing this progress though, we zero out the input information but not the output information. This PR fixes that bug.
Why are the changes needed?
Fixes a bug around incorrect metrics
Does this PR introduce any user-facing change?
Fixes a bug in the metrics
How was this patch tested?
New regression test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25146/
Test PASSed.

Test build #120438 has started for PR 28040 at commit 7def4de.

Test build #120442 has started for PR 28040 at commit b57aa74.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25150/
Test PASSed.

Test build #120438 has finished for PR 28040 at commit 7def4de.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120438/
Test FAILed.

Test build #120442 has finished for PR 28040 at commit b57aa74.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120442/
Test FAILed.

Test build #120444 has started for PR 28040 at commit 4655611.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25152/
Test PASSed.

I've proposed similar issue (not same issue but the approach to resolve would be similar) in #25987 in Oct. 2019. It didn't get some love. Could we please revisit it as well? Thanks in advance.

Test build #120444 has finished for PR 28040 at commit 4655611.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120444/
Test FAILed.

@HeartSaVioR Thanks for bringing that PR to my attention. We should get that in as well! Would you like to take over both?

I'm not sure I get it. My PR fixes a different bug so while there may be conflict between twos, twos are valid by theirselves. Why not deal with this PR (or my PR) quickly and do rebase, and deal with other? I think this PR is getting close to merge.

Test build #120539 has started for PR 28040 at commit 62044dc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25245/
Test PASSed.

Test build #120539 has finished for PR 28040 at commit 62044dc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120539/
Test FAILed.

Looks like the change brought side-effect and build failure is related. Could you please fix these tests as well?

I reverted the changes with respect to the empty progress. Seemed to be a bit more risky than I'd like, as I'd like to warmfix this into Spark 3.0

Test build #120544 has started for PR 28040 at commit 5fbbf41.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25250/
Test PASSed.

Test build #120544 has finished for PR 28040 at commit 5fbbf41.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120544/
Test FAILed.

Retest this, please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25259/
Test PASSed.

Test build #120553 has started for PR 28040 at commit 5fbbf41.

Test build #120553 has finished for PR 28040 at commit 5fbbf41.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120553/
Test PASSed.

Oh github didn't post my comment - the minor comment is, we renamed the field due to the semantic change, and it's being reverted now even though the purpose of revert is not relevant to this. Could you rename it again? It's OK you'd like me to do it as a follow-up, or even a part of #25987.

Test build #120603 has started for PR 28040 at commit d7792fd.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25307/
Test PASSed.

Test build #120603 has finished for PR 28040 at commit d7792fd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120603/
Test FAILed.

retest this please

Test build #120608 has started for PR 28040 at commit d7792fd.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25312/
Test PASSed.

Test build #120608 has finished for PR 28040 at commit d7792fd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120608/
Test PASSed.

@tdas I added 50 retries to the test to alleviate your concerns around flakiness.

Test build #120701 has started for PR 28040 at commit d501127.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25399/
Test PASSed.

Test build #120702 has started for PR 28040 at commit 68848d9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25400/
Test PASSed.

Test build #120702 has finished for PR 28040 at commit 68848d9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120702/
Test FAILed.

retest this please

Test build #120703 has started for PR 28040 at commit 68848d9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25401/
Test PASSed.

Test build #120701 has finished for PR 28040 at commit d501127.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120701/
Test FAILed.

Looks like the flaky test is below (and this PR made it flaky), not in streaming aggregation.
org.apache.spark.sql.kafka010.KafkaSinkMicroBatchStreamingSuite.streaming - sink progress is produced

Test build #120703 has finished for PR 28040 at commit 68848d9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120703/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25441/
Test PASSed.

Test build #120743 has started for PR 28040 at commit 2c9ed55.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25442/
Test PASSed.

Test build #120743 has finished for PR 28040 at commit 2c9ed55.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120743/
Test PASSed.

https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120743/testReport/ passed without flakiness

Test build #120814 has started for PR 28040 at commit 786d921.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25513/
Test PASSed.

Test build #120814 has finished for PR 28040 at commit 786d921.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120814/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25623/
Test PASSed.

Test build #120931 has started for PR 28040 at commit 68bf147.

Test build #120931 has finished for PR 28040 at commit 68bf147.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120931/
Test FAILed.

Unrelated flaky test: org.apache.spark.sql.hive.thriftserver.CliSuite.SPARK-11188 Analysis error reporting

retest this please

Test build #120932 has started for PR 28040 at commit 68bf147.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25624/
Test PASSed.

LGTM for this PR. @brkyvz feel free to merge it.

Thanks @HeartSaVioR @tdas for the review. Merging to master/3.0. Let's jump on #25987 next.

Test build #120932 has finished for PR 28040 at commit 68bf147.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120932/
Test PASSed.

Hi @HeartSaVioR  regarding the above PR i didn't understand the -1 value showing for ElasticSearch Sink for numOutputRows.
What does -1 represent in numOutputRows ?
Is it that it doesnt support for ES Sink or is there some bug in that ?


flutter doctor can't find Android SDK, but ANDROID_HOME is deprecated.

brew install android-sdk
echo 'export ANDROID_SDK_ROOT="/usr/local/share/android-sdk"' >> ~/.zshrc
source ~/.zshrc
flutter doctor

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.io/setup/#android-setup for detailed instructions).
      If Android SDK has been installed to a custom location, set $ANDROID_HOME to that location.

ANDROID_HOME is deprecated.  The variable is now called ANDROID_SDK_ROOT.

It also complains that Android SDK is missing command line tools, but I have installed:
  Path                                                | Version | Description                                     | Location
  -------                                             | ------- | -------                                         | -------
  build-tools;27.0.3                                  | 27.0.3  | Android SDK Build-Tools 27.0.3                  | build-tools/27.0.3/
  emulator                                            | 27.1.10 | Android Emulator                                | emulator/
  extras;intel;Hardware_Accelerated_Execution_Manager | 6.2.1   | Intel x86 Emulator Accelerator (HAXM installer) | extras/intel/Hardware_Accelerated_Execution_Manager/
  patcher;v4                                          | 1       | SDK Patch Applier v4                            | patcher/v4/
  platform-tools                                      | 27.0.1  | Android SDK Platform-Tools                      | platform-tools/
  tools                                               | 26.1.1  | Android SDK Tools                               | tools/

which "tools" are missing?

ANDROID_HOME is deprecated......  why doesn't flutter look in $ANDROID_HOME/tools?

Adding these to my PATH didn't fix it.  I tried adding build-tools, too.  That didn't fix it either.

Also it doesn't detect ANDROID_NDK_HOME path automatically.

[!] Android toolchain - develop for Android devices
• Android SDK at /usr/local/share/android-sdk
• Android NDK location not configured (optional; useful for native profiling support)
• ANDROID_HOME = /usr/local/share/android-sdk
✗ Android SDK is missing command line tools; download from https://goo.gl/XxQghQ
• Try re-installing or updating your Android SDK,
visit https://flutter.io/setup/#android-setup for detailed instructions.
$ ls $ANDROID_NDK_HOME/

CHANGELOG.md       build/             ndk-build*         ndk-gdb*           ndk-which*         prebuilt/          shader-tools/      source.properties  sysroot/            README.md          meta/              ndk-depends*       ndk-stack*         platforms/         python-packages/   simpleperf/        sources/           toolchains/

$ ls $ANDROID_SDK_ROOT/

.knownPackages  build-tools/    emulator/       extras/         licenses/       patcher/        platform-tools/ tools/

$ echo $PATH

...:/usr/local/share/android-sdk/tools:/usr/local/share/android-sdk/platform-tools:...

so i checked the flutter code, ANDROID_HOME might be deprecated but is still used in the code. I think the easiest and safest bet is have them both pointing to the same sdk.
"packages/flutter_tools/lib/src/android/android_sdk.dart"
"packages/flutter_tools/lib/src/android/android_workflow.dart"
for my mac OSX the means:
export ANDROID_SDK_ROOT=/Users//Library/Android/sdk
export ANDROID_HOME=$ANDROID_SDK_ROOT
Note: flutter seams to remember these settings. So removing the env vars and running flutter doctor again might work! It's really quite hard to exactly know whats going on because flutter tries to be really smart (I prefer dump software)

second problem,

also realated to flutter trying to be smart, the android platform tools. I had a android sdk installed via homebrew and a android studio later. To clean things up removed the homebrew install only to have flutter suddenly complaining about the missing android sdk..
Again, flutter remembers junk taken up from somewhere..
2a) add the android sdk to the shall command path:
export PATH=${PATH}:/Users//Library/Android//sdk/platform-tools/
2b) gradle bakes some env state into properties. In my case removing some local.properties files actualle solved my problem. I used 'ag android-sdk' to find places in my src dir which referring to an old android-sdk dir from homebrew and removed them.
have fun,

I have the same issue. But it works fine on command line when run flutter doctor. When I run it from AS, I got:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.2.3, on Linux, locale en_CA.UTF-8)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.io/setup/#android-setup for detailed instructions).
      If Android SDK has been installed to a custom location, set $ANDROID_HOME to that location.
[✓] Android Studio (version 3.1)
[!] IntelliJ IDEA Ultimate Edition (version 2017.3)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] VS Code (version 1.21.1)

! Doctor found issues in 2 categories.

I am using Ubuntu 17.0.4. ANDROID_HOME is pointing the right folder.

I got the flutter installation working, the android setup is the tricky part. I have detailed out how I have done it in this blog post: https://blog.gauravagarwalr.com/posts/2018-04-11-setting-up-flutter/

ANDROID_HOME is not "might be" deprecated.  It is deprecated.

I have the same issue. I have tried the above solutions but none of them is helpful. I am currently using Windows 10 version 1803(OS Build: 17134.112). Here, I am showing my output of flutter command: flutter doctor -v. Moreover, I have tried the flutter upgrade command too...
Please help me, I am unable to use flutter...

Still same issue

Hey I might catch a lot of grief here, but I have the same warning come up and it has not affected one single thing as far as running commands, creating apps or running the emulator or anything at all. I just ignore it and proceed with app development.

also affected by it, has anyone found a deterministic solution for that? I reckon this prevents you from developing with Flutter right? e.g. not just an ignorable error?

having the same issue... this is a discouraging way for people who starting out with their existing IDE(s) and dont wana grab the full android studio package...

I was having this problem as well. Was able to fix it based @crux's on solution: https://github.com/flutter/flutter/issues/15114#issuecomment-376582281
export ANDROID_SDK_ROOT="/Users/$USER/Library/Android/sdk"
export ANDROID_HOME=$ANDROID_SDK_ROOT

In my case, I simply didn't have Android Studio installed. During the installation of the AS, apparently, a few files under the /Users/$USER/Library/Android/sdk/ folder are replaced by "new ones".

In my case, I simply didn't have Android Studio installed. During the installation of the AS, apparently, a few files under the /Users/$USER/Library/Android/sdk/ folder are replaced by "new ones"...
echo $ANDROID_SDK_ROOT and echo $ANDROID_HOME print empty lines. I had first tried to instal sdkmanager using brew, but it didn't solve the problem, so I uninstalled it later.

In my case, installing Android Studio solved the problem. During the installation of the AS, apparently, a few files and folders under the /Users/$USER/Library/Android/sdk/ folder are replaced by "new ones"...
echo $ANDROID_SDK_ROOT and echo $ANDROID_HOME print empty lines. I had first tried to instal sdkmanager using brew, but it didn't solve the problem, so I uninstalled it later.

In my case, installing Android Studio solved the problem. During the installation of the AS, apparently, a few files and folders under the /Users/$USER/Library/Android/sdk/ folder are replaced by "new ones"...
echo $ANDROID_SDK_ROOT and echo $ANDROID_HOME print empty lines. I had first tried to instal sdkmanager using brew, but it didn't solve the problem, so I uninstalled it later.

I had the same issue on win 10 using VS Code. It was resolved by running VS Code in administrator mode.

Running as root is not a "resolution".  This variable is deprecated and the implementation should be fixed.

I was having this problem as well. Was able to fix it based @crux's on solution: #15114 (comment)
export ANDROID_SDK_ROOT="/Users/$USER/Library/Android/sdk"
export ANDROID_HOME=$ANDROID_SDK_ROOT

I have same problem
How i can do this and Is this for windows or mac

export ANDROID_SDK_ROOT="/Users/$USER/Library/Android/sdk"
export ANDROID_HOME=$ANDROID_SDK_ROOT

Flutter provide command to update our Android SDK path:
Use flutter config --android-sdk <path-to-your-android-sdk-path>

Flutter provide command to update our Android SDK path:
Use flutter config --android-sdk <path-to-your-android-sdk-path>
Thank you!
Before:

    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.io/setup/#android-setup for detailed instructions).
      If Android SDK has been installed to a custom location, set $ANDROID_HOME to that location.```
After:
```[!] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    ✗ Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

This is on Ubuntu 16.04. Perhaps the flutter doctor documentation just needs to be updated.

Flutter provide command to update our Android SDK path:
Use flutter config --android-sdk <path-to-your-android-sdk-path>

Worked for me as well. OSX Mojave.
Kept getting this error:
Android sdkmanager tool not found (/usr/local/Cellar/android-sdk/24.4.1_1/tools/bin/sdkmanager).
Try re-installing or updating your Android SDK,
visit https://flutter.io/setup/#android-setup for detailed instructions.

#0      throwToolExit (package:flutter_tools/src/base/common.dart:26:3)
#1      AndroidValidator._ensureCanRunSdkManager (package:flutter_tools/src/android/android_workflow.dart:260:7)
#2      AndroidValidator.licensesAccepted (package:flutter_tools/src/android/android_workflow.dart:194:5)
<asynchronous suspension>
#3      AndroidValidator.validate (package:flutter_tools/src/android/android_workflow.dart:155:19)
<asynchronous suspension>
#4      Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:105:52)
#5      Doctor.diagnose (package:flutter_tools/src/doctor.dart:162:41)
#6      _AsyncAwaitCompleter.start (dart:async/runtime/libasync_patch.dart:49:6)
#7      Doctor.diagnose (package:flutter_tools/src/doctor.dart:152:24)
#8      DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:29:39)
#9      _AsyncAwaitCompleter.start (dart:async/runtime/libasync_patch.dart:49:6)
#10     DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:28:42)
#11     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:372:18)
#12     _asyncThenWrapperHelper.<anonymous closure> (dart:async/runtime/libasync_patch.dart:77:64)
#13     _rootRunUnary (dart:async/zone.dart:1132:38)
#14     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#15     _FutureListener.handleValue (dart:async/future_impl.dart:129:18)
#16     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:642:45)
#17     Future._propagateToListeners (dart:async/future_impl.dart:671:32)
#18     Future._complete (dart:async/future_impl.dart:476:7)
#19     _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
#20     _AsyncAwaitCompleter.complete.<anonymous closure> (dart:async/runtime/libasync_patch.dart:33:20)
#21     _rootRun (dart:async/zone.dart:1124:13)
#22     _CustomZone.run (dart:async/zone.dart:1021:19)
#23     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:947:23)
#24     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#25     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#26     _runPendingImmediateCallback (dart:isolate/runtime/libisolate_patch.dart:115:13)
#27     _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:172:5)

After setting: flutter configure --android-sdk /Users/davidwparker/Library/Android/sdk/ it was fine.

What is flutter looking for?
I installed the tools (sdkmanager is just working fine) and installed platform-tools with sdkmanager, as it is supposed to.
android-sdk is downloaded and installed to /tools but even pointing $ANDROID_HOME to this folder is not helping flutter detecting sdk tools.
What does it expect?
PS I want to run flutter build on a headless machine.

Solved: By adding two paths in  "System variable"'s Path destination.

../Android/sdk/platforms
../Android/sdk/platform-tools
P.S. Should be added to System Variables -> Path (Not on User Variables -> Path)
https://imgur.com/a/kTxUaOd

That doesn't "solve" the fact that ANDROID_HOME is deprecated.

That doesn't "solve" the fact that Flutter relies on a deprecated environment variable.

You should be able to set the SDK path using flutter config if you'd prefer not to use the ANDROID_HOME variable. A few people above have said this worked fine - is it not working for you?
(FWIW, I don't think Android Studio deprecating their use of ANDROID_HOME means it's any less valid for Flutter to read it - setting an environment variable to pass paths to applications is common and Flutter presumably picked ANDORID_HOME for convenience because many people already had it set.. it's not all that different to if Flutter supported setting a variable named FLUTTER_ANDROID_SDK and used that).

I'm no longer using Flutter, and I'm not asking for help.  I'm pointing out that Flutter is using a deprecated envar.  This seems to be causing some issues for some new users.

That's a total crap that this issue opened on March 3rd is still actual at December 7th after Flutter 1.0 has been released. Starting working with Flutter and being not able to smoothly run a sample project is a real shame and as I see from this thread this is happening for a lot of people.

I finally solved the problem!!!!.>>Ubuntu 18<<, Need to make paths the same，
like:/home/name/flutter   and /home/name/Android-SDK
Check ndk-bundle/toolchains Is it complete?,You can download> android-ndk-r16b-linux-x86_64.zip
Then modify the environment and AS configure,restart AS,no devices ->Android Device
I hope I can help you all.

export ANDROID_HOME=/home/liangchen/Android/Sdk
export PATH=$ANDROID_HOME/tools:$PATH

export ANDROID_HOME=/home/liangchen/Android/Sdk
export PATH=$ANDROID_HOME/tools:$PATH

export ANDROID_HOME=/home/liangchen/Android/Sdk
export PATH=$ANDROID_HOME/tools:$PATH

Be sure to install the Android SDK Platform-Tools as well:

Flutter provide command to update our Android SDK path:
Use flutter config --android-sdk <path-to-your-android-sdk-path>

thank you

check your sdk path,i had this error before. make sure your sdk path have platform folder

If ANDROID_HOME/licenses doesn't exists, flutter doctor will not find Android SDK.
Flutter (Channel beta, v1.3.8, on Linux)

#Just copy this for Android Studio set up
#SDK exporting - this will solve your issue
export ANDROID_HOME=/home/youngdevps/Android/Sdk
#Tools exporting - it can be need in your case
export PATH=/home/{Username}/Android/Sdk/platform-tools:$PATH
export PATH=/home/{Username}/Android/Sdk/tools:$PATH
export PATH=/home/{Username}/Android/ndk-build:$PATH
export ANDROID_SDK_ROOT=$HOME/Android/sdk
#avdmanager, sdkmanager
export PATH=$ANDROID_SDK_ROOT/tools:$PATH
export PATH=$PATH:$ANDROID_SDK_ROOT/tools/bin
#adb, logcat
export PATH=$PATH:$ANDROID_SDK_ROOT/platform-tools
#emulator
export PATH=$PATH:$ANDROID_SDK_ROOT/emulator
#Just copy this for Flutter set up set up
#fLUTTER
export PATH=${PATH}:/home/{Username}/development/flutter/bin
export PATH=${PATH}:/home/{Username}/development/flutter/bin/cache/dart-sdk/bin
export PATH="$PATH":"~/.pub-cache/bin"
export PATH="$PATH:/home/{Username}/development/flutter/bin"
export PATH=/home/{Username}/development/flutter/bin:$PATH
export PATH=$PATH:/home/{Username}/development/flutter/bin
#THIS MUST BE AT THE END OF THE FILE FOR SDKMAN TO WORK!!!
export SDKMAN_DIR="/home/{Username}/.sdkman"
[[ -s "/home/{Username}/.sdkman/bin/sdkman-init.sh" ]] && source "/home/{Username}/.sdkman/bin/sdkman-init.sh"
export PATH="$HOME/.rbenv/bin:$PATH"
eval "$(rbenv init -)"
It will work if you copy and change username correctly. and suscribe to my channel for programming help
https://www.youtube.com/channel/UCaYBAKpckm_6OSs7rJNGodQ?view_as=subscriber

Hi guys. Please help me in flutter.
When I run flutter doctor command, It shows me this error:

I update the flutter, Android Studio, and even sdk manager, however I see this error again.
Please help me to resolve this problem.

I search this page,but I don't look carefully.I try in Flutter console ,find config method,and set SDK path.Log tips type error. Add quotes pass.

https://icetutor.com/question/flutter-does-not-find-android-sdk-2

Flutter provide command to update our Android SDK path:
Use flutter config --android-sdk <path-to-your-android-sdk-p

Flutter provide command to update our Android SDK path:
Use flutter config --android-sdk <path-to-your-android-sdk-p

For me the issue was the usage of tilde operator in the Android_home path.
I had to change my ANDROID_HOME
export ANDROID_HOME=~/Library/Android/sdk ->
export ANDROID_HOME=/Users/username/Library/Android/sdk
it worked after that

on running "flutter config --android-sdk /Users/sagarkhurana/Library/Android/sdk/"
getting output
Setting "android-sdk" value to "/Users/sagarkhurana/Library/Android/sdk/". You may need to restart any open editors for them to read new settings.
and after that running "flutter doctor --android-licenses"
getting same output
Android sdkmanager tool not found (/Users/sagarkhurana/Library/Android/sdk/tools/bin/sdkmanager). Try re-installing or updating your Android SDK, visit https://flutter.dev/setup/#android-setup for detailed instructions.
Please help

I tried everything!, the only thing that worked for me was finding where the sdkmanger was in the first place, for me /usr/local/bin/sdkmanager and literally copy the sdk manager and paste it in the /users/username/Library/Android/sdk/tools/bin/sdkmanager. (yes I did create tools and bin folders because the were not there), after reinstalling and installing sdk and android studio at least 6 times, this was the only option left

on running "flutter config --android-sdk /Users/sagarkhurana/Library/Android/sdk/"
getting output
Setting "android-sdk" value to "/Users/sagarkhurana/Library/Android/sdk/". You may need to restart any open editors for them to read new settings.
and after that running "flutter doctor --android-licenses"
getting same output
Android sdkmanager tool not found (/Users/sagarkhurana/Library/Android/sdk/tools/bin/sdkmanager). Try re-installing or updating your Android SDK, visit https://flutter.dev/setup/#android-setup for detailed instructions.
Please help

Verify that following path exists: /Users/sagarkhurana/Library/Android/sdk/tools/bin/sdkmanager
My .zshrc (Catalina):
export PATH="$PATH:$HOME/flutter/flutter/bin"
export PATH="$PATH:$HOME/flutter/flutter/.pub-cache/bin"

export ANDROID_SDK_ROOT="$HOME/Library/Android/sdk"
export ANDROID_HOME=$ANDROID_SDK_ROOT

export PATH="$PATH:$ANDROID_HOME/tools"
export PATH="$PATH:$ANDROID_HOME/platform-tools"

/Users/{USER}/Library/....

on Mac OS open  /Users/YOUR USER NAME/.flutter_settings and edit the path.

Found the solution thanks to sagarkhurana00786
On Linux I did:
flutter config --android-sdk /home/merritt/Android/Sdk/
(change to where your Sdk is actually installed)


clang-tidy action suggestions are not formatted correctly

Problem
Clang-tidy gives suggestions that then fail formatting
Solution
It should respect .clang-format

Sadly this didn't work

This is still a problem, no use closing it @luishfonseca. You should explain why we can't fix it easily right now, maybe someone in the future can do it. We can also redirect people here later.

Sure, here's the explanation of why it's not fixed and how to cope with it:
clang-tidy has 3 ways to operate: just warn, try to fix, write fixes to a file.
When it attempts to fix, it can then format the code afterwards. However, in our action, the fixes are stored in a file and the suggested, so the format step can't be used.
Occasionally, clang-tidy will suggest unformatted code, just accepting leads to CI failure. This same problem applies to any code suggested through the GitHub interface.
The solution is to locally amend the erroneous commit without any changes, that alone will trigger the pre-commit and format the changes.


Http StatusCode always 200

I load ratelimit component to my dapr runtime. But it return http status code with 200 always whatever the server response is success or failure.
Expected Behavior

return status code not 200 when the server response is failure.
Actual Behavior

return http status code with 200 always whatever the server response is success or failure.
Steps to Reproduce the Problem

different with stack
step 1: no ratelimit

step 2: with ratelimit

config yaml
apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
  name: ratelimit
spec:
  version: v1
  type: middleware.http.ratelimit
  metadata:
    - name: maxRequestsPerSecond
      value: 100000

Problem
I thank it's reason is in nethttpadaptor.
This code didn't process response status code.

@fingthinking Check the code, the statusCode is returned by "github.com/didip/tollbooth", if you do not reach limit, it would return no error.

@fingthinking Check the code, the statusCode is returned by "github.com/didip/tollbooth", if you do not reach limit, it would return no error.

OK! Thank you for your answer. But even if I actively set the status code to 500, the status code is always 200, which is not what I expected. I think it is a bug. Do you have another point of view?

I'll try to repro this today and push a fix if needed.

This is indeed a bug, thanks for reporting, I've added a test and a fix for this in #1429

This is indeed a bug in the adaptor, thanks for reporting, I think I've fix this in #1429

LGTM, thank u. I will test this PR.


provide password via environment variable HTTPIE_PASSWORD

This is a reviving #229 which enables passing of the auth password as environment variable.
The original pr had unfixed cr comments and was never addressed and was ultimately retracted it seems.
The initial comments are addressed in this pr.
If there are other comments related to this change I'm happy to fix them.
Solves my use case; in this pr:

add support for auth password as env HTTPIE_PASSWORD
add test (make test-all fine)
update docs
update changelog

@uncle9999


Feature: UI Sliders to control bone_damp_*, gaze_strength, and blink_threshold

Proposal: Make the UX more user-friendly by adding sliders to control motion control related inputs. Additionally expose gaze_strength and blink_threshold to the user to allow configuring winking without editing code.

Closing for now as the UI system has been completely overhauled. Please feel free to reopen if this will still be worked on.


Fix class\struct inconsistency warnings

Warnings reported by Visual Studio. Nothing serious, but still, less warnings - better.

Hello,
Thanks for the contribution, less warnings is always a good thing


Bump hashicorp/aws from 3.58.0 to 3.59.0 in /terraform

Review https://github.com/ministryofjustice/aws-root-account/pull/265
Do we want to update? Is there any impact from update?
If no issues, carry out update.

Done


docs: glossary infra

This PR replaces #34155 and splits the work needed for the glossary infra. This PR intention is to only set-up the infrastructure.
Remaining work:

[x] Add term file #34232
[ ]  Modifyglossary.md once the PR above and this one get merged. #34234

Closes #33117

@adeebshihadeh! In the original PR, you requested that I revert this change (see comment). I had made that adjustment to prevent the CI from failing and to keep the build process simple. The alternatives would be either adding steps to use Python 3.11+ (which includes tomllib by default) or relying on a third-party package, though the latter isn’t my preferred approach.
Please provide some insight on how to proceed.

Oh, that's fine then. I thought ubuntu-latest pointed to 24.04 nowadays anyway.

Oh, that's fine then. I thought ubuntu-latest pointed to 24.04 nowadays anyway.

No problem, It seems the rollout started on Dev 5th and they plan on it being completed by Jan 17th. Source


Single argument passed to the varargs parameter is not converted into array

also cannot pass raw array as varargs argument


dropdown border bug

noticed the dropdowns sometimes are missing the right border when you first land on the page, or before interacting with them.

addressed - closing


Downsampling rate

Hi!
From your ResBlock class, I can see that you use a constant downsampling rate of 2 by using the nn.AvgPool2d layer with kernel_size=3, stride=2 and padding=1.
However, in your arXiv paper, the first residual block downsamples the width from 2048 to 512 which indicates a downsampling rate of 4. Also, I don't understand how the last layer upsamples the feature map from 1024x64x32 to 2048x64x32 since in your code, a Conv2d layer with kernel_size=(1,1) is used here.
Is this a mistake in the visualization of the architecture?
Thank you!

Hello!!
Yes... Strangely I haven't pick up on that visualization error. We tried to have an extra layer on both sides and I must have forgotten to correctly update the figure.
It should go like
2048,64
1024, 32
512, 16
128, 4
The final conv-1x1 shouldn't change the dimensionality either as you pointed out.
Thanks for pointing out!

Thanks a lot for the fast reply and clarification!
Since you use 4 pooling layers, I assume you mean:
2048,64
1024, 32
512, 16
256, 8
128, 4
Thanks again!

And I did it again ahah!!
Exactly that!


Handling alignment for uniforms and push constants

Requirements
Standard Uniform Buffer Layout
Every member of an OpTypeStruct with storage class of Uniform and a decoration of Block (uniform buffers) must be laid out according to the following rules:

The Offset decoration must be a multiple of its base alignment.

Any ArrayStride or MatrixStride decoration must be an integer multiple of the base alignment of the array or matrix from above.

The Offset decoration of a member must not place it between the end of a structure or an array and the next multiple of the base alignment of that structure or array.

The numeric order of Offset decorations need not follow member declaration order.

reference
These also then follow the rules from std140. Also mentioned in 14.5.4.
Additionally from the SPIR-V spec
Composite objects in the UniformConstant, Uniform, and PushConstant Storage Classes must be explicitly laid out. The following apply to all the aggregate and matrix types describing such an object, recursively through their nested types:

Each structure-type member must have an Offset Decoration.

Each array type must have an ArrayStride Decoration.

Each structure-type member that is a matrix or array-of-matrices must have be decorated with

a MatrixStride Decoration, and

one of the RowMajor or ColMajor Decorations.

The ArrayStride, MatrixStride, and Offset Decorations must be large enough to hold the size of the objects they affect (that is, specifying overlap is invalid). Each ArrayStride and MatrixStride must be greater than zero, and no two members of a given structure can be assigned to the same Offset.

Meaning
RLSL needs to explicit decorate members of a struct with the correct offset. That offset needs to follow the rules defined in std140, and this only applies to PushConstant and Uniform.
Implementation
Idea 1
RLSL can easily generate the correct offset from the rules from std140 but then the Rust and RLSL code would get out of sync.
One idea would be to only check if the struct is conformant with the rules from std140. Then RLSL would just extract the offset that was defined by the user.
Generally annotation of structs doesn't seem reasonable, for example you don't want your Vec3<f32> to be 16 bytes wide in the vertex input. Either accept the performance hit, or create separate types for the all the uniforms.
Idea 2
#[derive(Packed)]
pub struct SomeStruct{
    pub v: Vec4<f32>,
    pub f: f32
}

// generated
fn compute_packed(&self) -> Packed<SomeStruct>{..}

Compute the correct layout inside RLSL and implement Packed in normal Rust as a custom derive.
It would then know how to serialize the specified struct with the rules of std140.
And Packed could look like this
struct Packed<T>{
    _m: PhantomData<T>,
    data: Vec<u8>
}

// Hopefully the max size can be computed statically
struct Packed<T: Uniform>{
    _m: PhantomData<T>,
    data: [u8; T::Size]
}

For example if you have
let uniforms: Vec<SomeStruct> = ..;

I am unsure how exactly I could implement it because custom derive doesn't expose type information but I think there should be a way. I might have to use const_fn. Alternatively everything could be computed in a build script with the reflection api.
How do you currently handle alignment? What would be your preferred API?

Idea 3
#[derive(Packed)]
pub struct SomeStruct{
    pub v: Vec3<f32>,
    pub f: f32
}

Maybe packed should just create a complete new struct under the hood.
// Generated
pub struct SomeStructPacked{
    pub v: Vec3<f32>,
    _p: f32, // do this properly with #repr
    pub f: f32
}
trait Packing {
    type Packed;
}

struct Packed<T: Packing>{
    _m: PhantomData<T>,
    data: T::Packed
}
// generated
impl Packing for SomeStruct {
    type Packed = SomeStructPacked;
}

And then you would create those structs directly Packed<SomeStruct>::new(..);. At least then you would lose some performance duo to copying because you can just use Packed directly.

I think a possible implementation of the generated code could look like this:
pub trait Alignment {
    const REST: usize;
}
#[repr(C)]
struct Align<A: Alignemnt> {
    data: A,
    _align: [u8; A::REST]
}

impl Alignment for Vec3<f32> {
    const REST: usize = 4; //
}
impl Alignment for f32 {
    const REST: usize = 0;
}

#[repr(C, align = "16")]
pub SomeStructPacked{
    v: Align<Vec3<f32>>,
    f: Align<f32>
}

#[derive(Packed)]
pub struct SomeStruct{
    pub v: Vec3<f32>,
    pub f: f32
}


Document project and seed configuration

Hey guys,
as announced beforehand, here is my proposal to add inline documentation for the project.config.ts and seed.config.ts using jsdoc notation (http://usejsdoc.org/). This aims to fix #861.
Greetings
Dope

Alright, the indentation is fixed and some last misspellings are corrected :) I'm done from my side.

I dont know why the appveyor build failed for the second commit, it ran fine for the first one, and the second one only removes some whitespace and alters documentation. I generally have a feeling that the appveyor build tends to fail on PRs with multiple commits (For the first one mostly succeeds but further builds tend to fail due to timing problems / racing conditions).

That's Chrome webdriver that fails, IE is passing. Something with Chrome on Windows maybe ?


Type definitions for createUser() and updateUser() parameters

Implementing type definitions for arguments of createUser() and updateUser() methods in auth. This improvement was suggested for the Node SDK during a recent API review discussion.
@bojeil-google Do we need to send this through the API review process?
See #62.

Hmm, I don't think we need to go through the API review, but we can quickly run it by someone on the council to confirm.

Got the confirmation that API review process is not required for this change. It was suggested to use anonymous types if possible, but I believe named types make the code simpler (since each type has many fields), and it will surely make the documentation easier to navigate as well. The type names used here (CreateRequest and UpdateRequest) were already approved for the Java SDK.

Reassigning to @bojeil-google for one more review, since index.d.ts was updated.


Feature request: impl AsyncBufRead

Hi, can you please implement https://docs.rs/tokio/1.7.1/tokio/io/trait.AsyncBufRead.html? It would be better to have read_line(), lines(), etc.

I don't believe OpenSSL provides raw access to its internal buffer. If you need an AsyncBufRead implementation, you can wrap SslStream in a BufReader.


do not update the browser's URL on a simple page load

when you open a link such as this one:

https://firmware-selector.openwrt.org/?target=ipq40xx%2Fgeneric&id=linksys_whw03v2

the page immediately rewrites browser's URL adding version=23.05.4& to it. this is a very minor annoyance, but IMHO the page should only modify the browser's URL if the user actually selects something. please consider fixing this.

The missing version in the link is actually an oversight that was fixed. But I understand that it might be behavior against the norm/expectation. I will fix it if does not complicate the code too much.


Will this work on Windows OS?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

This should work on all x86 devices which have docker support. But this is not how you open an issue, please don't just leave the template text and add nothing else.


Version 0.1 of Auth software.

This is to add Version 0.1 of the software portion.

Appropriate blocks were added and formatting was changed to 2-space indents


Accessibility - Locale Selector - Screen reader is not identifying this (back button) control. Hence the user does not know its presence.

Detailed description
Issue -
Select by location or by language : back button - Screen reader is not identifying this control. Hence the user does not know its presence.
Expected -
Screen reader should identify this control with appropriate Role/Label. And also this has to be made keyboard operable.

@Praveen-sr
Could you please test the back button usage again?
Thank you!

@RaphaelAmadeu Yes, ram verified on the link you provided, but Screen reader is not identifying the link in each card, all are announced only as text.

@RaphaelAmadeu Sure, can you provide link to re test?
Thanks!

@Praveen-sr
You can use staging for the test,
Thanks!

@RaphaelAmadeu Now screen reader (jaws) is identifying the button role. But, the label is given as "select region". Since the triggering control also has the same label, this is confusing.
Hence recommend to label this as "back".
Voiceover iPhone: VO is not identifying the button role still.

@Praveen-sr
We updated this component some days ago,
we thought that hardcoding the label with 'back' is not a good approach as it would not adapt for language changes,
Can you test this again please?
Thanks!

@RaphaelAmadeu Re tested this, now screen reader is announcing the label as "select region" which is inappropriate. To avoid confusion, the label can be given as "Go back to Select region" ?

I suggest "Select a different region" for the aria-label for the back button.

Since the icon is suggesting go back, how about 'Go back to select a different region'.


Broken codeblock at _root.scss -> ln: 20

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
// @each $color, $value in $theme-colors-rgb {
//   --#{$prefix}#{$color}-rgb: #{$value};
// }
There is no colormap for theme-colors-rgb and when imported _root at other custom file is not working.
Reduced test cases
// @each $color, $value in $theme-colors-rgb {
//   --#{$prefix}#{$color}-rgb: #{$value};
// }
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome, Firefox
What version of Bootstrap are you using?
v5.2.0

You're likely missing the new maps stylesheet. Double check our release notes, migration guide, or blog post.

Also please don't open a discussion and issue for the same problem. Choose one and if it's wrong, we can convert it.

Sorry my failure for opening both, but i did not sure about it is a bug or discussion topic for giving info yu know, but thanks for enlightening for it. Actually i did not notice that _maps.scss file and not thought there was. It gave me an error about that when i import and i reached here because. I am newly exploring github and environments like discussion, issues like so. :) And there was a line about $theme-colors-rgb at _root maybe it stemmed from this, maybe you will fix this at a minor bug fix ;)
Here is line at _root :
// @each $color, $value in $theme-colors-rgb {
 //   --#{$prefix}#{$color}-rgb: #{$value};
 // }
when i comment out this like so, it works proper i say otherwise throws error.

and _variables : there is no line about $theme-colors map..
and so, when i tried this at https://getbootstrap.com/docs/5.2/customize/sass/#variable-defaults
@import "../node_modules/bootstrap/scss/functions";

// Default variable overrides
$body-bg: #000;
$body-color: #111;

// Required
@import "../node_modules/bootstrap/scss/variables";
@import "../node_modules/bootstrap/scss/maps";
@import "../node_modules/bootstrap/scss/mixins";
@import "../node_modules/bootstrap/scss/root";

// Optional Bootstrap components here
@import "../node_modules/bootstrap/scss/reboot";
@import "../node_modules/bootstrap/scss/type";
// etc

root is throwing error :( and i can not customize bootstrap in my way. Maybe you can advice any way to work with it.
And so, thanks for all help. Have a nice day !


Error: decodeTask: imageFrame.pixelData is undefined after decoding

Hi All,
I am attempting to set up an embedded view using version 4.2.7 from here within my own ASP MVC application following docs.ohif.org/deployment/#embedded-viewer, using the ?url= param to pass my own JSON object.
I've tried generating my own JSON from a DCM/Dicom file, and I have also tried using the sample JSON/DCM from the link above. Both result in the js error below:
index.umd.js:55464 Uncaught (in promise) Error: decodeTask: imageFrame.pixelData is undefined after decoding
If I drop the ?url= param and use the worklist view provided by the sample viewer config (here) I can browse and view images correctly.
At this point I'm not sure what I'm missing - does anyone have any ideas? Thanks.

@kin3tik, I didn't look at your solution but I have this feature implemented in DICOMcloud (.NET 4.7), check these referenced:

 OHIFController
OHIFService

The code generates an older version of the JSON metadata which need to be updated to work with the latest version of the viewer but may give you an idea.

Hi @Zaid-Safadi , thank you for the suggestion. I haven't had any issues (I think) parsing the dcm files using fo-dicom to generate the JSON metadata, and I've tried just using the JSON metadata + dicom file in the OHIF Viewer documentation as a sanity check, but both in the same issue from my original comment :(

@kin3tik, it's possible the documentation's JSON file is outdated. It's not living documentation, and we update it infrequently. This is an area I wish we were better, but we have funding limitations.
There should be an issue floating around where we discuss the new format. Have you verified that after the JSON is requested, a DICOM Web request to retrieve the frame is made?

@dannyrb hi danny, thanks for the reply. I can confirm it makes a network request to the dicom file - the issue seems to be occurring after this. I attached a visual studio solution to the second comment that reproduces my issue. Completely lost as to how to resolve.

I have the same issue.  The same configuration works on commit d76fab0bc9012cf4e619fc418b075abd30279745 from a year ago.  Not sure if it matters but I am using wadouri.  Also the same issue as OP, I see the dcm file transferred, but fails on decoding.

I believe I'm running into the same issue when trying wadouri with an old dcm4chee server. The wado downloaded file seems to be correct and works with other applications.


Fix log popup placement [JENKINS-33109]

This fixes the log window popup placement from JENKINS-33109 and makes the window placement more natural when users have scrolled down a list of stages.
This places the popup for logs centered at the top of the visible area (a natural placement).  It also adds information about the element triggering the popup (which can be used to modify placement if desired).
@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

:bee:

super-big :bee: :)

:bee:

@reviewbybees done

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.


Using QNAP Nas certificate

Hello !
Thanks a lot for this example. In order to avoid bothering with solving ACME challenge stuff (or exposing the Nas to the internet) for enabling secure connexion, do you think there would be a way to use the automatically received certificate by the QNAP certificate app for a containered vaultwarden?
This of course would assume you access the vaultwarden through the [your nas name].myqnapcloud.com domain name which might be confusing, but could work.
Have you any thought on it/an idea on how to properly update your proposed docker-compose file?
Thanks a lot!

Thanks for checking this repo!
You can investigate how the QNAP certificate app stores the Let's Encrypt certificate and the Let's Encrypt key via the administrative SSH connection which is a builtin feature of the QNAP NAS and you could create a small helper Docker image that extracts the QNAP certificate into other format which can be used with the other application (e.g. Traefik) by writing a script in your favorite programming language like Go or Shellscript and, for example, saving the extracted certificate on a named volume might enable us to use the QNAP certificate with traefik.

Hey, thanks a lot for your suggestions ! I will reopen this if I find something interesting :)


If the first parameter supports the code, it will be better

UglifyPHP.minify("C:/web/file.php", {
/* Other Code */
}

If the first parameter supports the code, it will be better。
For example, like this
let phpCore = `
  <?php
    echo 'hello uglify-php'
  ?>
`
UglifyPHP.minify(phpCore, 'core', {
/* Other Code */
}

UglifyPHP.minify("C:/web/file.php", 'file', {
/* Other Code */
}

That's actually a good idea.
I'm currently making other changes too.
In the end of this week i will release a new version.
Thanks @BlackHole1

wow, I'm looking forward to it


FO: wording harmonization

Following https://github.com/PrestaShop/blockreassurance/pull/11/files

Thank you @AlexEven


Fallback to config in external strategy

Fallback to cluster configured in the config file when unsuccessfull with scheduling for external strategy

/lgtm

/approve
/lgtm


Demo seems broken on IE9

Check the attached screenshot.. What could be the reason? How to fix?

This isn't a Foundation or FoundationPress issue, it's an IE9 issue.  IE9 cuts off CSS files that are longer than some length (though I can't remember what the exact length is).  You can check out BlessCSS to fix this.

Thanks for replying!
I was aware about it but just wanted to make sure. I will reopen this (if required) after I try out BlessCSS.


syntax highlighting for json response #52

made changes in the index.html for syntax highlighting

didnt get what you meant by conflict


Error after signing in

I don't know if I am doing anything wrong here but after signing in to discord, I get the message
{"errorType":"Error","errorMessage":"Failed to get user access token","trace":["Error: Failed to get user access token","    at Runtime.exports.handler (/var/task/src/func/oauth-callback.js:27:19)","    at processTicksAndRejections (internal/process/task_queues.js:97:5)"]}
This is on a fresh install with no changes being made to source code. Where should I start to troubleshoot this? Does the GitHub repo need to have the same name as the parent repo?

Did you set the client ID and client secret correctly?

Closing for inactivity. Please reopen if you still have any issues.


Error: Cannot find module 'orchestrator' when node_modules is a symlink

I would like to put node_modules in a tmp directory and symlink to it from the actual working directory, to save lots of disk space wasted by gazillion of little files when working with many projects that need the same set of modules. But when I do this I get
Error: Cannot find module 'orchestrator'
This only happens when symlinking to the node_modules directory, not when this directory is a real one.
This looks like some module loading code does not like symlinks (on linux).
It would be great if that could be resolved, thanks for your attention!

This is a node issue.

Are you sure? Would you please link me to any document that gives some more information about this issue, especially I would be very interested in how to solve this problem.
Thank you very much for your attention!

For my special situation https://github.com/npm/npm/issues/10013#issuecomment-189176273 was the solution!

However, this is not a solution - file system features of the underlying operating system should not be a problem for an application like gulp. Please re-open this issue until the problem is solved, thanks.

What do you propose we do to fix it, and why do you think it should be part of gulp itself?

Guys, I'm late, but This happen with me, and I after I read a lot of thing that not help me, I re-install the gulp... just this, and it is ok


Map SimpleNameReference  return types in Ballerina to OpenAPI spec generation

Purpose

Resolves https://github.com/ballerina-platform/openapi-tools/issues/1171

Goals

Please refer to the issue above issue

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Test environment

Java JDK 11

@aneeshafedo Do we support unions of http errors (i.e. http:BadRequest|http:NotFound) with 18eeb33?

As it seems we cannot have two HTTP status code records as return.
ex:
resource function get res3(string id) returns http:BadRequest|http:NotFound {
        return {
            mediaType: "json",
            body: "Bad Request"
        };
    }

This gives the below ambiguous type error probably because that both of the records inherited from *CommonResponse.


Possible Bug: response is not defined after the first http request

Steps to reproduce:

Create http_scripts/response.http script:

POST https://httpbin.org/anything
Content-Type: application/json

{
        "id": "0001",
        "type": "donut",
        "name": "Cake"
}

{{ $global['responseData'] = response.parsedBody }}

Execute it in Cli: httpyac -a "http_scripts/response.http"

Expected results: $global['responseData'] has response.parsedBody assigned
Actual results: Httpyac throws exception "ReferenceError: response is not defined"
However this script is executed without exceptions:
POST https://httpbin.org/anything
Content-Type: application/json

{
        "id": "0001",
        "type": "fruit",
        "name": "Apple"
}

POST https://httpbin.org/anything
Content-Type: application/json

{
        "id": "0001",
        "type": "donut",
        "name": "Cake"
}

{{ $global['responseData'] = response.parsedBody }}

As a result, $global['responseData'] contains response of the first HTTP request but not the second as expected. So it looks like that 'response' object is created only after the script is executed but not before.
And here's the last attempt which actually worked well for me:
POST https://httpbin.org/anything
Content-Type: application/json

{
        "id": "0001",
        "type": "donut",
        "name": "Cake"
}

{{
    $global['responseData'] = response.parsedBody
}}

So the difference here is that the script opening and closing brackets {{ ... }} are place on a separate lines. In the previous examples script was written within the same line as the brackets.
So it looks that sometimes it is complicated to understand at which point the script, which is written after request line, is executed - before or after actual HTTP request. That can lead to unwanted results. In the first 2 examples it seems that script is treated as a part of request body generation (which is actually a good feature and I use it a lot) and executed before actual HTTP request happens. And in the last example script is treated as a response processing script. So the behavior depends only on where you will put the brackets.
However if this is expected feature, then it would be nice to have that described in the documentation. Also maybe it would be good to have a possibility to explicitly define where request generation script ends and where response processing script starts.

@woolfas The distinction for me is really the line break after {{ and the script content. If there is no line break, you want to use templating mechanism (and is executed before request). This feature is needed to allow some simplification for response body
{{
  exports.body= {
   foo: "bar"
  }
}}
POST <some_url>
{{body}}

I don't see the need for an explicit separation between response body and script area. This would be visual only, as Intellij Http Client does not provide this either and I want to remain compatible. You could specially mark the script area, but it would change the execution time (executed before response display).
POST https://httpbin.org/anything

{
        "id": "0001",
        "type": "donut",
        "name": "Cake"
}

{{@response
  console.info("on every response");
}}

Maybe as a tip. In the outline editor I show the distinction between request body and script area

POST  https://httpbin.org/json

{
  "test": 1
}

{{
  // post request script
  exports.header = response.headers['content-type'];
}}


change to proper bullet list

my 2 cents ;)

@simonaco Oh...haha :sweat_smile:  too slow :wink:

:D bullet points are even better! any articles you might've used Juri and would be useful to add to the list?


python3Packages.xdis: 4.2.4 -> 5.0.4, fix build

Motivation for this change
ZHF: #97479
@NixOS/nixos-release-managers
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/97486
6 packages built:
python37Packages.uncompyle6 python37Packages.unrpa python37Packages.xdis python38Packages.uncompyle6 unrpa python38Packages.xdis

just waiting for ofborg


Mobile view: overlapping text when tap to view measurement point in graphs

Description:
Tap on graph to see measurement point info, in mobile view this is drawn on top of min max average area.

QA passed


launching web interface?

Hi everyone,
Trying to get an instance of this up and running but having some issues.
grabber is working fine, but I dont seem to be able to start the web interface?
Web3 connection established
Killed
What am I doing wrong? How should this be launched properly?
Been looking at the code, nice work, expect a deluge of pull requests from me.

can you run the server?
node app.js

yeah but i get
Web3 connection established
Killed
and nothing listening on port 3000 at all during the process.
I should mention I'm trying with neither etc or eth. Just wanted to check I was launching correctly, must be more params i need to change.

Oh, geth needs to be running.


Segfault

This looks very interesting, but I'm unable to successfully run the example. I modified the trainData, testData, and logFile paths of the config file appropriately. Valgrind reports this:
==12259== Memcheck, a memory error detector
==12259== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==12259== Using Valgrind-3.15.0 and LibVEX; rerun with -h for copyright info
==12259== Command: ./runme Config_amz.csv
==12259==
new Network
==12259== Invalid write of size 4
==12259==    at 0x10F124: Network::Network(int*, NodeType*, int, int, float, int, int*, int*, int*, float*, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, cnpy::NpyArray, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, cnpy::NpyArray> > >) (Network.cpp:13)
==12259==    by 0x10D01E: main (main.cpp:472)
==12259==  Address 0xb is not stack'd, malloc'd or (recently) free'd

Apologize for the late reply! The team just got back from the conference. We'd happy to help. As mentioned in the README: "Additionally, Transparent Huge Pages must be enabled. SLIDE requires approximately 900 2MB pages, and 10 1GB pages. (https://wiki.debian.org/Hugepages)"
May I ask if you that is enabled?

I have similar issue:
./runme Config_amz.csv
new Network
new Layer
new Node array
Illegal instruction (core dumped)

I reversed to  2d10d46 and then I was able to run the experiment.
My TPH configuration:
hugeadm --pool-list
      Size  Minimum  Current  Maximum  Default
   2097152     1000     1000     1000        *
1073741824       20       20       20

TL;DR on my Ubuntu 19.10 machine I added:
transparent_hugepage=always hugepagesz=1GB hugepages=10 hugepagesz=2MB hugepages=900
to GRUB_CMDLINE_LINUX_DEFAULT in /etc/default/grub. Then update-grub and reboot. You can verify with cat /sys/kernel/mm/transparent_hugepage/enabled and hugeadm --pool-list.

Note: mmap returns -1 on error, the current code checks for NULL:
https://github.com/keroro824/HashingDeepLearning/blob/b7b3bba9bab1fb0e70de7644daa9e2312f21de82/SLIDE/Layer.h#L58

@yvdriess  This should be resolved in the pull request #22.

TL;DR on my Ubuntu 19.10 machine I added:
transparent_hugepage=always hugepagesz=1GB hugepages=10 hugepagesz=2MB hugepages=900
to GRUB_CMDLINE_LINUX_DEFAULT in /etc/default/grub. Then update-grub and reboot. You can verify with cat /sys/kernel/mm/transparent_hugepage/enabled and hugeadm --pool-list.

so sorry to interrupt, but I could not find the grub file, should I create one in the location /etc/default/grub ?

Hi,
Im sorry but I don't know why you are missing this file if you have a recent Ubuntu. Perhaps running the update grub command would restore it.
Best regards,
Jose

From: One-punch24<EMAIL_ADDRESS>Sent: Monday, November 2, 2020 7:26 PM
To: keroro824/HashingDeepLearning<EMAIL_ADDRESS>Cc: Jose Lopez<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [keroro824/HashingDeepLearning] Segfault (#6)
TL;DR on my Ubuntu 19.10 machine I added:
transparent_hugepage=always hugepagesz=1GB hugepages=10 hugepagesz=2MB hugepages=900
to GRUB_CMDLINE_LINUX_DEFAULT in /etc/default/grub. Then update-grub and reboot. You can verify with cat /sys/kernel/mm/transparent_hugepage/enabled and hugeadm --pool-list.
so sorry to interrupt, but I could not find the grub file, should I create one in the location /etc/default/grub ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkeroro824%2FHashingDeepLearning%2Fissues%2F6%23issuecomment-720884472&data=04|01|lopez.jo%40northeastern.edu|558d265d7a3545a9649008d87fa84628|a8eec281aaa34daeac9b9a398b9215e7|0|0|637399707993220673|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=a4g8w7krqWS0fJa%2F5rcswaG9aY%2Bp4WPcz6LXbF8poYs%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE3WNBV7HK555A4HKBRE333SN5Z63ANCNFSM4K75GGGA&data=04|01|lopez.jo%40northeastern.edu|558d265d7a3545a9649008d87fa84628|a8eec281aaa34daeac9b9a398b9215e7|0|0|637399707993220673|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=5umWRaYJubP%2B%2BZ6wDWVPNs3EfA9Cfp4yvO4BBtxIWIY%3D&reserved=0.

Thank you so much for replaying. I am a little bit busy these days for some exams.
 Can I consult you later? I was so happy and amazed that you answer me so
------------------ 原始邮件 ------------------
发件人:                                                                                "keroro824/HashingDeepLearning"<EMAIL_ADDRESS>发送时间: 2020年11月10日(星期二) 凌晨0:12
收件人<EMAIL_ADDRESS>抄送: "1482806551"<1482806551<EMAIL_ADDRESS>主题: Re: [keroro824/HashingDeepLearning] Segfault (#6)
Hi,
Im sorry but I don't know why you are missing this file if you have a recent Ubuntu. Perhaps running the update grub command would restore it.
Best regards,
Jose

From: One-punch24<EMAIL_ADDRESS>Sent: Monday, November 2, 2020 7:26 PM
To: keroro824/HashingDeepLearning<EMAIL_ADDRESS>Cc: Jose Lopez<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [keroro824/HashingDeepLearning] Segfault (#6)
TL;DR on my Ubuntu 19.10 machine I added:
transparent_hugepage=always hugepagesz=1GB hugepages=10 hugepagesz=2MB hugepages=900
to GRUB_CMDLINE_LINUX_DEFAULT in /etc/default/grub. Then update-grub and reboot. You can verify with cat /sys/kernel/mm/transparent_hugepage/enabled and hugeadm --pool-list.
so sorry to interrupt, but I could not find the grub file, should I create one in the location /etc/default/grub ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkeroro824%2FHashingDeepLearning%2Fissues%2F6%23issuecomment-720884472&data=04%7C01%7Clopez.jo%40northeastern.edu%7C558d265d7a3545a9649008d87fa84628%7Ca8eec281aaa34daeac9b9a398b9215e7%7C0%7C0%7C637399707993220673%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=a4g8w7krqWS0fJa%2F5rcswaG9aY%2Bp4WPcz6LXbF8poYs%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE3WNBV7HK555A4HKBRE333SN5Z63ANCNFSM4K75GGGA&data=04%7C01%7Clopez.jo%40northeastern.edu%7C558d265d7a3545a9649008d87fa84628%7Ca8eec281aaa34daeac9b9a398b9215e7%7C0%7C0%7C637399707993220673%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=5umWRaYJubP%2B%2BZ6wDWVPNs3EfA9Cfp4yvO4BBtxIWIY%3D&reserved=0>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I seemed to have solved this problem but still got segment fault. I really want to consult you later to solve some strange problem.
Thank you for your help again!
------------------ 原始邮件 ------------------
发件人:                                                                                "keroro824/HashingDeepLearning"<EMAIL_ADDRESS>发送时间: 2020年11月10日(星期二) 凌晨0:12
收件人<EMAIL_ADDRESS>抄送: "1482806551"<1482806551<EMAIL_ADDRESS>主题: Re: [keroro824/HashingDeepLearning] Segfault (#6)
Hi,
Im sorry but I don't know why you are missing this file if you have a recent Ubuntu. Perhaps running the update grub command would restore it.
Best regards,
Jose

From: One-punch24<EMAIL_ADDRESS>Sent: Monday, November 2, 2020 7:26 PM
To: keroro824/HashingDeepLearning<EMAIL_ADDRESS>Cc: Jose Lopez<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [keroro824/HashingDeepLearning] Segfault (#6)
TL;DR on my Ubuntu 19.10 machine I added:
transparent_hugepage=always hugepagesz=1GB hugepages=10 hugepagesz=2MB hugepages=900
to GRUB_CMDLINE_LINUX_DEFAULT in /etc/default/grub. Then update-grub and reboot. You can verify with cat /sys/kernel/mm/transparent_hugepage/enabled and hugeadm --pool-list.
so sorry to interrupt, but I could not find the grub file, should I create one in the location /etc/default/grub ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkeroro824%2FHashingDeepLearning%2Fissues%2F6%23issuecomment-720884472&data=04%7C01%7Clopez.jo%40northeastern.edu%7C558d265d7a3545a9649008d87fa84628%7Ca8eec281aaa34daeac9b9a398b9215e7%7C0%7C0%7C637399707993220673%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=a4g8w7krqWS0fJa%2F5rcswaG9aY%2Bp4WPcz6LXbF8poYs%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE3WNBV7HK555A4HKBRE333SN5Z63ANCNFSM4K75GGGA&data=04%7C01%7Clopez.jo%40northeastern.edu%7C558d265d7a3545a9649008d87fa84628%7Ca8eec281aaa34daeac9b9a398b9215e7%7C0%7C0%7C637399707993220673%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=5umWRaYJubP%2B%2BZ6wDWVPNs3EfA9Cfp4yvO4BBtxIWIY%3D&reserved=0>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Is code run, I have killed problem  ???

@jlopezNEU
Is code work now or not?


Widen List AttributeTypes to Seq

Resolves #510

This currently fails CI because I have yet to figure out how to regenerate semconv locally; however, that should be the only thing it needs

@iRevive could you regenerate semconv for this?

Sure

done. I also updated a few places with 'asInstanceOf' casts.

thanks!


Add Anzen to ecosystem page

What changed? Why?
Adding Anzen to Ecosystem page
Notes to reviewers
Anzen is a RWA-backed stablecoin
Terms and conditions (linked in homepage footer): https://app.anzen.finance/terms
Additional Informational Links:

https://partners.circle.com/anzen
https://app.rwa.xyz/assets/USDz
https://defillama.com/protocol/anzen-v2
https://coinmarketcap.com/currencies/anzen-finance/

How has it been tested?
Anzen has been audited by Zellic, Peckshield, and Halborn.
https://docs.anzen.finance/developer-resources/audits
Terms link

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

@bshyong
Hi there! Thanks for this PR! Confirming this is currently being reviewed.

@wbnns any updates on this PR? 🙏
We are launching our protocol token on Base next week
https://anzen.finance/anzen-on-base

@bshyong
Hi there! Thanks for your patience. Apologies, we recently updated the way we categorize and subcategorize apps; could you please define the category and subcategory?
We'll do our best to complete the review as soon as possible once you do! 🙏

Updated!  @wbnns


Either duplicate System.ValueTuple PackageReference warning or build error due to System.Range type generation

I tried this package but I have an issue when targeting net462.
Your RandomSkunk.RuntimePolyfill.targets contains a package reference to System.ValueTuple.
If my project does not add a package reference to System.ValueTuple then the build fails with the following error messages:
(...)\obj\Release\net462\RandomSkunk.RuntimePolyfill\RandomSkunk.RuntimePolyfill.PolyfillSourceGenerator\System.Range.cs(110,16): error CS8137: Cannot define a class or member that utilizes tuples because the compiler required type 'System.Runtime.CompilerServices.TupleElementNamesAttribute' cannot be found. Are you missing a reference? [(...)\src\(...)\(...).csproj::TargetFramework=net462]
(...)\obj\Release\net462\RandomSkunk.RuntimePolyfill\RandomSkunk.RuntimePolyfill.PolyfillSourceGenerator\System.Range.cs(110,16): error CS8179: Predefined type 'System.ValueTuple`2' is not defined or imported [(...)\src\(...)\(...).csproj::TargetFramework=net462]

If my project adds a package reference to System.ValueTuple then a warning message is shown:
(...)\src\(...)\(...).csproj : warning NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functionality to ensure a consistent restore behavior. The duplicate 'PackageReference' items are: System.ValueTuple 4.5.0, System.ValueTuple 4.5.0. [TargetFramework=net462]

This might be the reason for this:
https://learn.microsoft.com/en-us/nuget/concepts/msbuild-props-and-targets#guidance-for-the-content-of-msbuild-props-and-targets

There are a few things that must not be done in packages' .props and .targets, such as not specifying properties and items that affect restore, as those will be automatically excluded.

[...]
Some examples of items that must not be added or updated: PackageReference, [...], etc.

I think I found the answer and the solution.
There is an ExcludeRestorePackageImports MSBuild property which will be set to true when the Restore target runs. So when restoring then your .targets file will not be imported, but when building then it is imported.
So in my .csproj file I add the package reference only when restoring.
<ItemGroup Condition="'$(TargetFramework)' == 'net462' And '$(ExcludeRestorePackageImports)' == 'true'">
  <PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>


net/http: does not handle semicolon-terminated cookie strings very well

What version of Go are you using (go version)?

$ go version
1.16.3

Does this issue reproduce with the latest release?
I tried version 1.18 and it did not solve my problem completely.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/Users/xxx/go/bin"
GOCACHE="/Users/xxx/Library/Caches/go-build"
GOENV="/Users/xxx/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/xxx/go/pkg/mod"
GONOPROXY="git.xx.oa.com"
GONOSUMDB="git.xx.oa.com"
GOOS="darwin"
GOPATH="/Users/xxx/go"
GOPRIVATE="git.xx.oa.com"
GOPROXY="https://goproxy.cn,direct"
GOROOT="/Users/xxx/go/go1.16.3"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/xxx/go/go1.16.3/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16.3"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/xxx/develop/doc_pro1/xxx-xxx/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/gg/4vpkn5v518g_bdwnnq4w6zpm0000gn/T/go-build3887804640=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
The following code has reproduction problems：
import (
	"fmt"
	"net/http"
)

func main() {
	r := &http.Request{Header: map[string][]string{"Cookie": {"test1=1;"}}} // This test cookie string ends with a semicolon
	r.AddCookie(&http.Cookie{Name: "test2",Value: "2"}) // Append a cookie
	for _, c := range r.Cookies() { // Only test1 is printed, test2 is missing
		fmt.Println("cookie:", c.Name, c.Value)
	}
        fmt.Println(r.Header.Get("Cookie"))
}

What did you expect to see?
The actual printed results of the demo code:
cookie: test1 1
test1=1;; test2=2

The result I expect：
cookie: test1 1
cookie: test2 2
test1=1; test2=2

Why can't the http.Request.AddCookie() method remove the semicolon at the end and then append the cookie string?

Thanks for the report. Do you know if the relevant specification says anything about this, or is this more related to nuances of the net/http API?
CC @neild.

Thanks for the report. Do you know if the relevant specification says anything about this, or is this more related to nuances of the net/http API?
CC @neild.

Sorry, I didn't find the specification either, it's just that we had a problem with it in our production environment, we were using version 1.16 and found that some of the cookie strings ended in a semicolon and then some of the cookies were lost after appending a new cookie. i looked at the http.Request.AddCookie() implementation and it doesn't start with Instead of removing the extra semicolon first, it goes on to add another one. Has the standard library considered correcting this beforehand to make it conform to the standard before adding a new cookie?

FYI, here is the spec for the Cookie header: https://datatracker.ietf.org/doc/html/rfc6265#section-4.2.1
cookie-header = "Cookie:" OWS cookie-string OWS
cookie-string = cookie-pair *( ";" SP cookie-pair )

And cookie-pair is described here: https://datatracker.ietf.org/doc/html/rfc6265#section-4.1
cookie-pair       = cookie-name "=" cookie-value
cookie-name       = token
cookie-value      = *cookie-octet / ( DQUOTE *cookie-octet DQUOTE )
cookie-octet      = %x21 / %x23-2B / %x2D-3A / %x3C-5B / %x5D-7E
                       ; US-ASCII characters excluding CTLs,
                       ; whitespace DQUOTE, comma, semicolon,
                       ; and backslash

According to the spec, semicolon should be excluded from the cookie-value (US-ASCII characters excluding CTLs, whitespace DQUOTE, comma, semicolon, and backslash).

FYI, here is the spec for the Cookie header: https://datatracker.ietf.org/doc/html/rfc6265#section-4.2.1
cookie-header = "Cookie:" OWS cookie-string OWS
cookie-string = cookie-pair *( ";" SP cookie-pair )

And cookie-pair is described here: https://datatracker.ietf.org/doc/html/rfc6265#section-4.1
cookie-pair       = cookie-name "=" cookie-value
cookie-name       = token
cookie-value      = *cookie-octet / ( DQUOTE *cookie-octet DQUOTE )
cookie-octet      = %x21 / %x23-2B / %x2D-3A / %x3C-5B / %x5D-7E
                       ; US-ASCII characters excluding CTLs,
                       ; whitespace DQUOTE, comma, semicolon,
                       ; and backslash

According to the spec, semicolon should be excluded from the cookie-value (US-ASCII characters excluding CTLs, whitespace DQUOTE, comma, semicolon, and backslash). And there is not trailing semicolon in the cookie-string.

In theory, it should indeed be as specified in the draft, but our production environment did encounter a cookie string ending in a semicolon, which caused us problems; I was hoping that the standard library would be compatible with this situation, after all, go 1.16 would simply lose the newly appended cookie, and although subsequent versions have fixed this problem, they have never removed that extra semicolon.

Request.AddCookie is very simple in how it appends cookie values: If an existing Cookie header is present, it appends a semicolon and space before the new cookie value. This works correctly, so long as the existing Cookie header is valid.
It is not valid for a Cookie header to end in a semicolon. I don't think it makes sense for AddCookie to check for a specific form of invalid Cookie header. If it does make sense, then we need a cohesive understanding of what forms of invalid Cookie headers AddCookie will correct; would we also convert a=b;;b=c into a=b;b=c, for example? What do we do if the existing Cookie header is entirely unparsable?
Go 1.18's Request.Cookies function is more permissive about extraneous semicolons in cookies. If I run the example above with 1.18 (playground link), I see:
cookie: test1 1
cookie: test2 2
test1=1;; test2=2

This should also be considered a dup of #38437

Ok, thanks for the replies!


Create an intro

Add an intro about yourself: who are you, what is your strength, why are you here.

We need to buy a camera for this task!


Inline user documentation

In GitLab by @jakebeal on Feb 1, 2019, 21:15
Make sure there is enough UI user documentation and/or tooltips to make it easy for a new user to figure out how to use the intent parser.

In GitLab by @jakebeal on Mar 12, 2019, 11:05
assigned to @sumorok

In GitLab by @jakebeal on May 21, 2019, 10:46
removed assignee

In GitLab by @nwalczak on Jun 5, 2019, 11:14
I had looked at adding tooltips to the menu items in Google Apps.  As far as I could find, it's currently not supported, which is too bad.
The buttons are implemented via HTML, so tool-tips should be possible, however it seems like it's not as straight forward to due tooltips for HTML as you would think.  The examples I found involved writing a bunch of css.

In GitLab by @jakebeal on Jul 1, 2019, 10:38
assigned to @nwalczak

In GitLab by @nwalczak on Oct 1, 2019, 11:33
created branch 20-inline-user-documentation

In GitLab by @nwalczak on Oct 1, 2019, 11:33
mentioned in merge request !64

In GitLab by @nwalczak on Oct 2, 2019, 10:06
closed via commit 16bd0784c184df655ff43f64e9154a5aa5e80e96

In GitLab by @nwalczak on Oct 2, 2019, 10:06
closed via merge request !64

In GitLab by @nwalczak on Oct 11, 2019, 14:12
mentioned in commit 16bd0784c184df655ff43f64e9154a5aa5e80e96


Extend with DataInspector component

It's a little useful extend i think. 😉

Hi @Xertium!
I really appreciate this FIRST MR.
I think that's a great improvement, however we need to change it a bit to avoid crashing. I left a comment in the code for you. Do you think you'd be able to address that?

@Xertium any chance this will go in anytime soon? Awesome work btw!

Hi @Manouli !
I have to find some time for this and I promise I will. Not soon, but not too far. 🙂 I just finished my project, when i'm done with bug fixes this will be my priority. And thanks btw!


read_bio_samples latin characters

I'm trying to replicate your code but I get an error when I load the CoNLL dataset for either ESP or NED, I get the error that 'utf-8' codec can't decode byte .... in position .....
This I can solve by specifying encoding in open() but I am curious if you did any preprocessing of the CoNLL files such that you don't get the same error. I took the CoNLL 2002 data from the official website https://www.clips.uantwerpen.be/conll2002/ner/
Thank you!

Hi @svenspa, thanks for your interest in our work!
I don't remember all the details as we did the experiments for this paper almost 4 years ago, but the error looks like that the input is not using the utf-8 encoding? Did you try identifying the encoding of the files and specify that encoding manually when trying to read the files?

Thank you @ccsasuke for your quick response!
This indeed works but then I ran into other issues. However, I think I fixed it right now. It's running so I will give you an update probably tomorrow.

Hi @ccsasuke, I fixed it! I think you took some preprocessing steps for the CoNLL data. So after accounting for the encoding when reading the file, I had some issues like exploding memory on the GPU and errors in the evaluation function. Now it seems that you split the data on "\t" which does not work for the "raw" NER files downloaded from the original website or a GitHub repo. I changed this step and I added DataParallel for more efficient use of the GPU. Right now everything works fine and I get similar results as published in your paper.
Should I submit a PR such that people can see what might work for them as well? (I saw a similar issue with the memory before in your repo)

@svenspa Thank you so much for the PR! I've left some comments on the commit.
I have two high-level comments:

Could you make the encoding change in a separate subclass of BioDataset since it is specific to the CoNLL data but not all sequence tagging datasets?
Could you make the DataParallel change in a separate PR and make sure that you can reproduce the experiments in the paper? Alternatively, you can either create a new file with this multi-gpu training, or add an option to turn it on, so that it will not introduce a breaking change to the current code.

Thank you for contributing to the project! I've merged your changes to the main branch.


rollup min-viable product

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e2fce30) 32.05% compared to head (94b6314) 36.71%.
Report is 17 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   32.05%   36.71%   +4.66%
==========================================
  Files           7        9       +2
  Lines         496      463      -33
==========================================
+ Hits          159      170      +11
+ Misses        337      293      -44

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix syntax for 'file is checkedout' warning banner and removal of hyphens

Changes made per Jinlu's suggestions. Merged into release/0.55.0


fix numCPU (open /sys/fs/cgroup/cpu.max: no such file or directory)

If we try to run ingress app on Debian 11 we will get an error:
livekit-ingress[68889]: open /sys/fs/cgroup/cpu.max: no such file or directory
this merge request fix it

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Chekh Mikhail seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.