Allow attributes on expression

This PR adds a new AST node AttrExpr. This node is used when outer attributes are applied to an expression that is not an expression statement.
fn foo() {
    bar(#[attr] 1); // CallExpr(.. ArgList(.. AttrExpr(..)))
    #[attr] func();   // ExprStmt(Attr(..), CallExpr(..))
    #[attr] func()    // AttrExpr(Attr(..), CallExpr(..)) last expression of a block is not an ExprStmt
}

It seems like stable rustc allows attributes on certain expressions when operator precedence is not confusing despite the unstable stmt_expr_attributes feature.
This PR currently isn't trying to produce parse errors and instead allowing attributes on arbitrary expression with the same precedence as lambda (this is suggested in the stmt_expr_attributes tracking issue). Probably errors can be reported on a validation pass.
This PR addresses #919's second and third case.

Hm, this expr_block_contents looks way to complicated. Let me see if I can simplify it a bit...

I did that refactoring. Will update PR.

@pcpthm would you mind rebasing this on a copule of cosmetic changes I am about to push?

(basically, flattening this all a bit)

@matklad I rebased your commit. This PR is updated to include bigger change than first (a new AST syntax kind) to address issue on attributes on non-ExprStmt expression leaking to outer block. Do you think introducing a new AST node right approach?

Do you think introducing a new AST node right approach?

I don't think so, treating attrs as children of expressions seems better. Ie, we don't create "decorator" nodes, for things like modifiers or visibilty, we store them directly as children and introduce traits like "visibility owner".

Whet we need here I think is an Option<Marker> arguemnt  to expr_stmt. See, for example, how block_expr works

Actually, I couldn't come up with how to implement parsing without introducing an another node because each expression type start an own node and I can not inject children to such node. If there is a way to "meld" two nodes after parsing, it can be much simpler to implement, I think.

@matklad The problem is Option<Marker> needs to be passed to not expr_stmt, every expression types possible (tuple_expr, array_expr, ... etc. ) if I am correct. That is a modularity hazard and want to avoid.

. If there is a way to "meld" two nodes after parsing, it can be much simpler to implement, I think.

We can do this (CompletedMarker::precede achieves something similar). I am not sure it would be the definitive win, we need to try things out and make sure we use the single approach everywhere.
Currently, at least two approaches are used simulateneosly:

don't call start/finish at all inside parsing function, let the caller take care of this (maybe_item works like this)
instead of calling start, accept a Marker argument call finish explicitelly (lifetime_param does this)

And there's a third one:

call both start/finish, but allow caller to prepend values to the nodes (this'll require new API)

My gut feeling is that the Marker approach, although a bit boilerplatey, is the most robust one.

Another thing to keep in mind is that if we want to support parsing attributes "inside" expressions, like
1 + #[foo] 2

We'll need t teach atom to parse attrs anyway

Am I right to assume this also addresses #759?

@killercup
Attributes on match arms are already handled (no error) but parse tree seems incorrect.

Ah, cool! Updated the issue to show the second case, attributes on blocks, don't work yet :)

So, how about this plan:

first, we refactor maybe_item to also accept Marker as an argument: the current approach is confusing, and doing this refactor should give us a rough feeling about how it'd work for expressions
if it works ok for items, we could try it for expressions as well

I wouldn't worry too much about modularity here parser is nicely isolated from the rest of the analyzer, and this is what is most important.

Okay, let me try that plan. My word about modularity was too much and actually I'm thinking that approach is not bad after thinking.

Another PR with suggested approach incoming.

I just installed and enabled it, but it gives me "false" errors like this:

In main.rs, I have stmt_expr_attributes and type_ascription enabled (among many other features). How can I tell rust-analyzer to take my enabled features into account? :)


Verspaetung should access Kafka metadata periodically to grab the latest topic offsets

kafka/tools/GetOffsetShell.scala has some example code to riff on but at it's core there's calls into ClientUtils.fetchTopicMetadata which should give the necessary partition information to grab the latest offsets.
The polling mechanism should be configurable, but will likely need to be triggered based on topics inferred from #2

With ba2fa562acf848537cd0f7ab1496c03dc4b210b8 this exists now, it's just godawful ugly and bad.


[Question]: multimodal workflows

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I want to build a multimodal chat using streamlit and llamaindex workflows, wherein user can upload images or provide text questions. Can you provide the best practice and sample codes.

But how to integrate workflow here?

@dosu where is the workflow here?


MenuItem: emit contextmenu to support right click

In electron env, right click menuItem and show context menu is common use cases. So menuItem should support emit right click event :)
Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

@click.native.right: https://jsfiddle.net/leopoldthecuber/vvzojc39/


Add info about where to add webhooks

As mentioned in #292, we currently don't say where to set up your webhooks. This PR adds a note about where to find the webhooks in the org settings.
@toolmantim do you think it needs more than this? I would have liked to mention the provider-specific guides we have too, but they don't seem to be linked from within the app after you've set up your pipeline? Do they only appear on the initial blank pipeline setup page?
Closes #292

I would have liked to mention the provider-specific guides we have too, but they don't seem to be linked from within the app after you've set up your pipeline? Do they only appear on the initial blank pipeline setup page?

I'm not sure which provider-specific webhook guides you're talking about? The blank pipeline setup page being this one…?

I meant this one 😄:

That link to "setup a GitHub webhook" at the bottom I thought wasn't anywhere in the rest of the app, but I've since found it at the bottom of the Repository Settings page 👍🏻

Oh yeah, that one! Those webhooks are different — they're the GitHub webhooks, to power The GitHub integration. The webhooks I was referring to in the issue were our own web hook notifications (which people can point to their own servers) — which is what this PR fixes.
🚀


Support page

Includes adding support email settings for within-community support
Also include Sassafras support email for admins only
For now just give emails, no need for a form
Also add meals coordinator role and send meals support requests to them while account requests go to billers?
Allow meals coordinators to do sensible things

Originally created by Willie Northway at 2015-08-20 01:24, migrated from redmine-#2906

Subject changed from Add a way for people to report bugs / request features to User feedback form

Description updated (diff)
Priority changed from 5 to 4
Estimate set to 2.00 h

By Tom Smyth at 2016-05-14 05:26

Category set to Public Release

By Tom Smyth at 2017-01-19 18:31

Subject changed from User feedback form to Support page

By Tom Smyth at 2017-01-25 03:57

Priority changed from 4 to 2

By Tom Smyth at 2017-01-26 08:36

Description updated (diff)

By Tom Smyth at 2017-01-25 03:58

Priority changed from 2 to 4

By Tom Smyth at 2017-03-29 05:32

Description updated (diff)

By Tom Smyth at 2017-01-26 19:57

Category deleted ( ~~ Public Release~~ )

By Tom Smyth at 2017-09-06 13:58


Set-DbaLogin -Allow pipeline from Get-DbaLogin

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[x] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[x] Adding code coverage to existing functionality
[x] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Accept Get-DbaLogin as input to Set-DbaLogin on the pipeline.
Approach

Get-DbaLogin outputs SqlInstance, Name. On Set-DbaLogin I added ValueFromPipelineByPropertyName to the SqlInstance and Login parameters. I also had to add an alias of Name to the Login parameter.
Commands to test

Get-DbaLogin -SqlInstance sql1 -Login test | Set-DbaLogin -RemoveRole bulkadmin

Dangit... had some branch issues, apparently I didn't get it fixed correctly. I'll give it another shot shortly.

I think I got it switched over to the appropriate method (InputObject).

Test needs to also be updated to include the additional parameter.

added the requested updates and will merge when tests pass 💯

got it! todo: change to SMO Login output and update tests

Thanks!!


Http gem needs to be updated for security reasons

Hi all
I'm one of the developers for OpenVNet, a project that implements DCell. Github has brought to our attention that the Ruby http gem before 0.7.3 does not verify hostnames in SSL connections, which makes it vulnerable to man in the middle attacks.
Since the newest version of DCell still freezes http at 0.5.x, I tried to update it myself. Updating the gem to its most recent version 3.0.0 gave me the following error:
Apr 10 06:02:08 ci vnet-vnmgr[5717]: D, [2018-04-10T06:02:08.253041 #5721] DEBUG -- : Terminating 4 actors...
Apr 10 06:02:08 ci vnet-vnmgr[5717]: /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/reel-0.4.0/lib/reel/response.rb:3:in `<class:Response>': uninitialized constant HTTP::Header (NameError)
Apr 10 06:02:08 ci vnet-vnmgr[5717]: Did you mean?  HTTP::Headers
Apr 10 06:02:08 ci vnet-vnmgr[5717]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/reel-0.4.0/lib/reel/response.rb:2:in `<module:Reel>'
Apr 10 06:02:08 ci vnet-vnmgr[5717]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/reel-0.4.0/lib/reel/response.rb:1:in `<top (required)>'
Apr 10 06:02:08 ci vnet-vnmgr[5717]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/reel-0.4.0/lib/reel.rb:18:in `require'
Apr 10 06:02:08 ci vnet-vnmgr[5717]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/reel-0.4.0/lib/reel.rb:18:in `<top (required)>'
Apr 10 06:02:08 ci vnet-vnmgr[5717]: from /home/kemumaki/dcell/lib/dcell.rb:2:in `require'
Apr 10 06:02:08 ci vnet-vnmgr[5717]: from /home/kemumaki/dcell/lib/dcell.rb:2:in `<top (required)>'
Apr 10 06:02:08 ci vnet-vnmgr[5717]: from ./bin/vnmgr:8:in `require'
Apr 10 06:02:08 ci vnet-vnmgr[5717]: from ./bin/vnmgr:8:in `<main>'

I figured a newer version of reel might have adjusted to any changes in the http gem so I updated reel to its newest version 0.6.1. The error changed to the following.
Apr 10 06:05:50 ci vnet-vnmgr[5770]: /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/tasks/task_fiber.rb:34:in `terminate': task was terminated (Celluloid::Task::TerminatedError)
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/actor.rb:345:in `each'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/actor.rb:345:in `cleanup'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/actor.rb:329:in `shutdown'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/actor.rb:321:in `handle_crash'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/actor.rb:166:in `rescue in run'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/actor.rb:148:in `run'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/actor.rb:130:in `block in start'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/thread_handle.rb:13:in `block in initialize'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/actor_system.rb:32:in `block in get_thread'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/internal_pool.rb:130:in `block in create'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from (celluloid):0:in `remote procedure call'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/calls.rb:92:in `value'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/proxies/sync_proxy.rb:33:in `method_missing'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/proxies/cell_proxy.rb:17:in `_send_'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid.rb:169:in `new'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid/supervisor.rb:16:in `supervise_as'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from /opt/axsh/openvnet/vnet/vendor/bundle/ruby/2.3.0/gems/celluloid-0.16.0/lib/celluloid.rb:194:in `supervise_as'
Apr 10 06:05:50 ci vnet-vnmgr[5770]: from ./bin/vnmgr:33:in `<main>'

I had a look at the celluloid code in the stacktrace but it seems like it's generic code to handle any crashes. It looks like updating the http gem will require some deeper knowledge of how DCell and Celluloid interact so I was wondering if could get some help with this.
Thanks in advance
~Metallion

I would also like to see DCell upgraded to support http > 0.7.3 in response to this vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2015-1828


use Kawashima's database rewrite instead of the snapshot

In the current prototype, the snapshot is used as a "flat database". This has the problem that the nodes are currently written to the db "the old fashioned way", and never pruned.
An alternative, would be to mimic Mr Kawashima's PR and storing the nodes by path directly in the db/snapshot.

We have implemented an intermediate method for this, pending the full rebase on top of PBSS. We can close this, as this method has proven a huge performance and size gain, and we will not return to the older method.


Missing dependencies and peer conflicts

I tried setting up a project this afternoon and had to do some work to figure out dependencies. Following the directions of the readme I ran into the following issues:

Lock the versions of nx, @nrwl/workspace, and @nx/node to 16.10.0 to remove peer dependency warnings.
Manually install @nx/devkit with fixed version 16.10.0.
After generating a project and app I had to add @nx/react to the project manually.

While the last step makes sense from a "standard NX usage point of view", it was still missing something I had to just know to follow the getting started guide.
There are probably other versions of nx and associated tools that would have worked, but 16.10.0 was easy to standardize on.

Choosing Vite as my build tool also seemed to create some getting-started friction. I had to manually remove the base href in index.html despite including the baseHref in the build options.
I also needed to add "base: './',"  to the vite config so that it produces relative paths for resource bundles.

Thanks for the report, @dpsthree. Some of these issues should be fixed in the beta branch that includes updates for Nx 17.

Lock the versions of nx, @nrwl/workspace, and @nx/node to 16.10.0 to remove peer dependency warnings.
I created #62 to keep track of this.

Manually install @nx/devkit with fixed version 16.10.0.
This should be fixed in the beta branch.

After generating a project and app I had to add @nx/react to the project manually.
This is not required if you want to write a Forge app without Custom UI. For Custom UI apps the step here includes installing the @nx/react. Do you think this should be mentioned somewhere else?

I have never tested this with a vite build target but the required changes that you described sound quite similar to the steps documented here. I guess we could have a section in the docs to describe the steps required to configure different builders (webpack, vite) for Custom UI projects. I created #63 if you would like to have a go at this.
If you want to test the Nx 17/beta branch, you can migrate nx to the latest 17 version following the Nx guide and then nx migrate<EMAIL_ADDRESS>(there may be a way to run these two commands in one go but I am not sure how).

This is not required if you want to write a Forge app without Custom UI. For Custom UI apps the step here includes installing the @nx/react. Do you think this should be mentioned somewhere else?

I probably just missed that line. Thanks

I have never tested this with a vite build target but the required changes that you described sound quite similar to the steps documented here. I guess we could have a section in the docs to describe the steps required to configure different builders (webpack, vite) for Custom UI projects. I created #63 if you would like to have a go at this.

I'm struggling with several issues related to Nx 16 and Vite that are not related to this plugin. I think I will try the 17 branch for a bit before looking further down this path.

If you want to test the Nx 17/beta branch, you can migrate nx to the latest 17 version following the Nx guide and then nx migrate<EMAIL_ADDRESS>(there may be a way to run these two commands in one go but I am not sure how).

I'm working with a new project so I will try a fresh install.

Working through this a second time with the beta branch was a lot smoother. Once the v17 work is merged this issue looks resolved to me.

Closing this issue. Most of the mentioned points should be covered in<EMAIL_ADDRESS>The items not covered in the release have separate issues.


MINOR: Remove toStruct and fromStruct methods from generated protocol classes

Update few classes that were still using the removed methods (including
tests that are no longer required).
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

This is nice, maybe we will also remove struct.writeTo and struct.read after #9641  #9766  and KAFKA-10863 is accomplished.

This is nice, maybe we will also remove struct.writeTo and struct.read after #9641  #9766  and KAFKA-10863 is accomplished.

@dengziming Looks like StickyAssignor also uses Struct still. Once all usages are removed, maybe we can delete Struct altogether instead of only some methods in it.

@dengziming Looks like StickyAssignor also uses Struct still. Once all usages are removed, maybe we can delete Struct altogether instead of only some methods in it.

Hmm, we may need to keep Struct as a type for Schema, however. So you may be right that we can only remove the serialization/deserialization methods.

Hmm, we may need to keep Struct as a type for Schema, however. So you may be right that we can only remove the serialization/deserialization methods.

Yes, #9766 is trying to repace Struct inStickyAssignor. I am not sure about removing Struct class, I will try to check it, but we can remove serialization/deserialization methods.

Yes, #9766 is trying to repace Struct inStickyAssignor. I am not sure about removing Struct class, I will try to check it, but we can remove serialization/deserialization methods.

JDK 11 build passed, JDK 8 and 15 had unrelated flaky failures.

JDK 11 build passed, JDK 8 and 15 had unrelated flaky failures.


hot reload gives "PlatformException(already_connected, connection with device already exists, null)"

with flutter_blue 0.6 & flutter  1.7.8 ,
detailed error description :

Successfully connected to the device
But if make any change in UI related code, while the device is in connected sate & then save to trigger 'Hot Reload' causes following error

Reloaded 10 of 598 libraries in 1,728ms.
E/flutter (14222): [ERROR:flutter/shell/common/shell.cc(184)] Dart Error: Unhandled exception:
E/flutter (14222): PlatformException(already_connected, connection with device already exists, null)
E/flutter (14222): #0      StandardMethodCodec.decodeEnvelope
package:flutter/…/services/message_codecs.dart:564
E/flutter (14222): #1      MethodChannel.invokeMethod
package:flutter/…/services/platform_channel.dart:316
E/flutter (14222):
E/flutter (14222): #2      BluetoothDevice.connect
package:flutter_blue/src/bluetooth_device.dart:38
E/flutter (14222):
E/flutter (14222): #3      FindDevicesScreen.build....
package:irrismart_dl/pages/bleScan.dart:97
E/flutter (14222): #4      MaterialPageRoute.buildPage
package:flutter/…/material/page.dart:87
E/flutter (14222): #5      _ModalScopeState.build.
package:flutter/…/widgets/routes.dart:666
E/flutter (14222): #6      Builder.build
package:flutter/…/widgets/basic.dart:6427
E/flutter (14222): #7      StatelessElement.build
package:flutter/…/widgets/framework.dart:3974
E/flutter (14222): #8      ComponentElement.performRebuild
package:flutter/…/widgets/framework.dart:3924
E/flutter (14222): #9      Element.rebuild
package:flutter/…/widgets/framework.dart:3721
E/flutter (14222): #10     StatelessElement.update
package:flutter/…/widgets/framework.dart:3981
E/flutter (14222): #11     Element.updateChild
package:flutter/…/widgets/framework.dart:2876
E/flutter (14222): #12     SingleChildRenderObjectElement.update
package:flutter/…/widgets/framework.dart:5099
E/flutter (14222): #13     Element.updateChild
package:flutter/…/widgets/framework.dart:2876
E/flutter (14222): #14     SingleChildRenderObjectElement.update
package:flutter/…/widgets/framework.dart:5099
E/flutter (14222): #15     Element.updateChild
package:flutter/…/widgets/framework.dart:2876
E/flutter (14222): #16     SingleChildRenderObjectElement.update
package:flutter/…/widgets/framework.dart:5099
E/flutter (14222): #17     Element.updateChild
package:flutter/…/widgets/framework.dart:2876
E/flutter (14222): #18     SingleChildRenderObjectElement.update
package:flutter/…/widgets/framework.dart:5099
E/flutter (14222): #19     Element.updateChild
package:flutter/…/widgets/framework.dart:2876
E/flutter (14222): #20     ComponentElement.performRebuild
package:flutter/…/widgets/framework.dart:3935
E/flutter (14222): #21     Element.rebuild
package:flutter/…/widgets/framework.dart:3721
Also note following code for "package:irrismart_dl/pages/bleScan.dart:97"
 body: RefreshIndicator(
        onRefresh: () =>
            FlutterBlue.instance.startScan(timeout: Duration(seconds: 8)),
        child: SingleChildScrollView(
          child: Column(
            children: <Widget>[
              StreamBuilder<List<ScanResult>>(
                stream: FlutterBlue.instance.scanResults,
                initialData: [],
                builder: (c, snapshot) {
                  **print("Body: BLE Scan Stream 1");** // This line not printed after hot reload
                  return Column(
                    children: snapshot.data
                        .map(
                          (r) => ScanResultTile(
                            result: r,
                            onTap: () {
                              myDevice = r.device;
                              Navigator.of(context).pushReplacement(
                                  MaterialPageRoute(builder: (context) {
                                try {
                                  r.device.connect(); // This is line 97
                                } catch (e) {
                                  print("Error: Connect Device $e");  // Not printed when error . Why error not catched ??
                                }
                                return Status();
                              }));
                            },
                          ),
                        )
                        .toList(),
                  );
                },
              ),
            ],
          ),
        ),
      ),

Please help to resolve this issue .
Thanks,
Gaurav

Have you got any solution? I am having the same problem.


stm8ef / XY-LPWM

I found a link to your repository for XY-LPWM on the Internet.
I wanted to make an indicator for myself based on PWM XY-LPWM.
I ordered the boards on Aliexpress, but when I received them, it turned out that they had another controller with a worn-out name (in the SOP-16 case).

Do you happen to know what controller this is???

@Igor26974 I've moved your question to the appropriate repository added your finding to the README.md in the hope that others know that the vendor should be asked for a confirmation before ordering.


Split multilang master jobs by language

From internal CL description:
Experiment with reorganizing basictest multilang jobs on master into per-language jobs.
The goals

reduce the overall duration of test jobs
make test failures/flakes easily attributable to owners
make flakiness of given language easier to assess from the master dashboard directly

this PR only adds new kokoro .cfg scripts, so the test failures are definitely unrelated.


EVP_MD performance fix (refcount cache contention)

Partial fix for #17064. Avoid excessive writes to the cache line containing the refcount for an EVP_MD object to avoid extreme cache contention when using a single EVP_MD at high frequency on multiple threads. This changes performance in 3.0 from being double that of 1.1 to only slightly higher than that of 1.1.

This pull request is ready to merge

Merged to master.
OTC: Candidate for 3.0?
as a performance fix rather than a functionality one, this isn't automatic.

This is marked as OTC-hold but also appears to have been merged. Can this be closed?

This is marked as OTC-hold but also appears to have been merged. Can this be closed?

It's been merged to master. @paulidale is asking OTC whether it should additionally be merged to 3.0 or not. So it should remain open until OTC respond.

OTC: this can go back to 3.0
https://github.openssl.org/otc/technical-policies/blob/master/votes/vote-20220315-backport-17857-EVP_MD-performance-fix.txt


Anchor Offset is being reset every frame

Values set with set_anchor_offset_x() or set_anchor_offset_y() are being reset every frame.

It seems like components are reverting to setting the properties to the property targets even when the properties are not animated. This is unintended behaviour and will be fixed.


Sort image tags by version instead of purely alphabetically

This helps when your image tags are versioned:
myrepo:foo-1
myrepo:foo-11
myrepo:foo-5

becomes
myrepo:foo-1
myrepo:foo-5
myrepo:foo-11

Sure that is a great idea, thank you for your help!
You got me thinking about also including -r so the latest version would be first, -Vr.  Let me know what you think.

Yep, sounds good to me 😀


Ability to cancel drawing

Currently the user can press Esc to cancel drawing. Should also add a button that cancels as well. Could appear only when user has selected a drawing tool.

try this
L.DomEvent.on(document.getElementById('abbruch'), 'click', this.disable, this);

this worked for me:
drawControl._toolbars.draw._activeMode.handler.disable()
given:
var drawControl = new L.Control.Draw({position: 'topleft'});


Replace all not atomic

From contrebasse on 2012-07-13T02:59:39Z
Spyder Version:  2.1.9
Python Version:  2.7.3
Qt Version:      4.8.1, PyQt4 (API v2) 4.9.1 on Linux
What steps will reproduce the problem?

Open a file
Press Ctrl-H to open the replace bar
Replace all occurences of a word
Press Ctrl-Z To undo the replacement What is the expected output? What do you see instead? I expect to see all replacements reverted at once, instead I have to press Ctrl-Z for each replacement made.

Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1117

From pierre.raybaut on 2012-07-28T11:48:11Z
This issue was updated by revision 7b7d940d20c7 .
Status: Fixed


Update Codex to the latest StructuredLogger.dll

Xamarin.Designer builds fail with:
First chance exception: System.NotSupportedException: Unsupported log file format. Latest supported version is 6, the log file has version 7.
2018-08-28T02:50:23.2388961Z    at Microsoft.Build.Logging.BinaryLogReplayEventSource.Replay(String sourceFilePath)

I think this is fixed.


Add Stage 1 status

@littledan @zbraniecki @FrankYFTang @nciric

Should we now move it to proposals org?

tc39-transfer → tc39, yes

Moved to tc39-transfer; can one of the chairs (@bterlson, @gesa, @MylesBorins, @robpalme) move it into tc39?  Thanks!


Could you expose clang-format-diff.py (or git-clang-format) to the precommit hook?

Hello,
I'd like to request a way to run either of these from the precommit hook, with the goal of only reformatting the changed lines. This would pair very nicely with https://github.com/akaihola/darker, and I would hope it's usable in a similar way as their precommit hook.
It might already be possible to do what is desired - but if so, would you be able to add it to the documentation? I would be happy to help if needed.

Sorry, see this is a better fit for the mirror https://github.com/pre-commit/mirrors-clang-format. I'll reopen there


auto-convert most of KIDL constructs to Thrift ones

Already does some useful stuff
Try
python lib/biokbase/data_api/rpc_util.py specs/ci-KBaseGenomesCondensedPrototypeV2.spec

DO NOT MERGE!
This PR is now primarily for the purpose of discussing how to structure the Data API
Latest ideas from Dan are in object.thrift, object/api.py and object/impl.py with a first pass at the developer documentation in docs/create_api.rst


Move to autoloading instead of require_once

Good reasons are given in the PEAR2 standards wiki:
http://wiki.pear.php.net/index.php/PEAR2_Standards#Introduction
http://wiki.pear.php.net/index.php/
PEAR2_Standards#use_of_include.2Frequire.2Frequire_once.2Finclude_once_not_allow
ed

Steps:
 * copy trunk to branch "autoload"
 * remove all require* used to load classes
 * create Minify/autoload.php
 * register function in min/index.php
 * ab test comparison to trunk
 * fix unit tests/extras
 * merge to trunk

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 7 Oct 2008 at 6:52

yeah great i did it this way with autoload. perfect and so easy!!

Original comment by<EMAIL_ADDRESS>on 9 Mar 2009 at 8:15


New version: Jags v3.0.0

Registering package: Jags
Repository: https://github.com/JagsJulia/Jags.jl
Created by: @goedman
Version: v3.0.0
Commit: 389e955220bb6efc02f1f0da85aed993c9d78d89
Reviewed by: @goedman
Reference: https://github.com/JagsJulia/Jags.jl/issues/20

Thank you!


Show payment summary for peer

Codecov Report

Merging #2160 (b66f005) into master (80a484e) will decrease coverage by 0.87%.
The diff coverage is 18.91%.

@@            Coverage Diff             @@
##           master    #2160      +/-   ##
==========================================
- Coverage   63.12%   62.24%   -0.88%
==========================================
  Files          78       78
  Lines        3645     3719      +74
  Branches      231      235       +4
==========================================
+ Hits         2301     2315      +14
- Misses       1327     1387      +60
  Partials       17       17

Impacted Files
Coverage Δ

squeaknode/db/squeak_db.py
95.22% <11.76%> (-3.95%)
:arrow_down:

squeaknode/admin/squeak_admin_server_handler.py
20.03% <12.50%> (-0.32%)
:arrow_down:

squeaknode/node/squeak_controller.py
49.15% <37.50%> (-0.41%)
:arrow_down:

squeaknode/node/squeak_store.py
47.40% <50.00%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a484e...b66f005. Read the comment docs.


Improve binstub specs

What was the end-user problem that led to this PR?
The problem was that I run into some failures when testing rubygems against the latest bundler 2-1-stable branch of bundler.
What was your diagnosis of the problem?
In certain contexts, the previous approach of overwriting the version constant led into version mismatch issues.
What is your fix for the problem, implemented in this PR?
Since in this case we are actually testing some rubygems stuff present in the generated binstub, but we don't really care what the bundler gem is actually doing, we can follow the same approach as other specs and install a "dummy" bundler gem to the system gems home used by our specs.
Why did you choose this fix out of the possible options?
I chose this fix because it still tests the same thing but in a more resilient way, I believe.

@bundlerbot merge


Apple Smart Banner not working

Hi
I am using the library for setting the title & meta that makes my webpage prompting Apple's smart banner on iOS platform. But I found that it not working for me, I've tried do the following:
...
if (isIOS(window.navigator.userAgent)) {
    return (
      <Helmet
        meta={[
          {
            name: 'apple-itunes-app',
            content: `app-id=${appStoreId}, app-argument=${deepLink}`,
          },
        ]}
      />
    );
  }
...

and the HTML code looks no problem like the following screenshot

I am confused by the situation for about 2 days, I've tried to add the meta to raw HTML files it ran perfectly, buy in React code it not working anymore and I googled the problem no one can answer my question, so anyone in here has solution for my problem or it's really an issue in the library?
Thanks

I found that the meta info is not rendered at the page first loading, it rendered after a while with async methods of React, so I think this is the key why Safari can't recognize the meta.

Also having this issue, any help is appreciated!

Yep, you need to server-side render your web app for the metadata/title managed by react-helmet to be rendered as part of the script source.  Once you're rendering your React app on a server you can checkout how to render react-helmet on the server here: https://github.com/nfl/react-helmet#server-usage


[CMake] Attempt to serialize execution of 'swiftCore' target and its embedded variants

Restrict them all to a common single-task pool

@swift-ci smoke test

@swift-ci smoke test


Set jsonpFunction by default

Hi,
jsonpFunction, is set by default to prevent conflicts within app when multiple webpack runtimes (from different compilation) are used on the same webpage.
For example, a widget built with webpack being loaded into a site which is too webpacked.
https://webpack.js.org/configuration/output/#output-jsonpfunction

Can this be merged?

@iansu

@Timer

ping @Timer

@ianschmitz any update on this.

@sibiraj-s, I'd love to help you get this through.
This seems to introduce a different issue, in two apps built in CRA would still conflict. Could we use the app name instead? It's available within the config as a variable.

This seems to introduce a different issue, in two apps built in CRA would still conflict.

Yeah. I didn't think of that. Will update.

Thanks, let me know when that's done @sibiraj-s - I think we can land this in 3.1 if you can get it done in the next few days.

It's available within the config as a variable.

I searched for one. but i couldn't find any. Should I go ahead add one?
incase If i missed it. Can u point me.

Sorry, you're right!
Just require in the package.json as we do here: https://github.com/facebook/create-react-app/blob/47e9e2c7a07bfe60b52011cf71de5ca33bdeb6e3/packages/react-scripts/scripts/init.js#L88
Then you can use appPackage.name :)


I got Nan values during the training stage-1

Hi,
I started training stage-1.
In the first iteration, everything is fine but after the first iteration,each model generates only nan value. what can be the reason?
this gives me NaN
face_emb = self.imageproj(face_emb)
this gives me NaN
self.reference_unet(
ref_image_latents,
ref_timesteps,
encoder_hidden_states=face_emb,
return_dict=False,
)
in the first iteration, each model works fine

Could you test the pull request #133?

i will test now but I also encounter this problem when I don't validate.
i change enter the validation code part like this and I am not validating the network after the first iteration
if global_step % cfg.val.validation_steps == 0: # or global_step == 1:
in the first iteration, network produces result as expected, and in the second iteration it gives me nan

it works now, thanks @xumingw

I also met that problem, how did you solve it?

你好，请问您是怎么解决的？


refactor base API to be async

Refactor Datastore impls and tests accordingly.
Closes #7.

Ah, whoops, I meant to squash the [wip] ... commits. Doing a quick force-push fixup given that this library currently has no dependents.

definitely noone will mention :)
nice job. this week we will make the sqlite backend working in Codex


Add support for open method to take in additional arguments

Some use cases allow open method to take in institution_type(ex. ins_3) to open Plaid directly to that institution credentials.
To support flexibility for uncertain amount of arguments, I added a spread on all arguments possibility.

This is to resolve https://github.com/plaid/react-plaid-link/pull/111 ...not sure how to link.

Hi @abartolo-
This method has been deprecated and we suggest you use the full link flow. If you have more questions please reach out to your account manager and they can provide more details.


#Region tag codefolding doesn't seem to work with Jupyterlab notebooks

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

Start Jupyterlab notebook.  Add #region / #endregion cells

Actual behavior
The region folding operation doesn't work / isn't recognized
Expected behavior
Region folding like in other python files - not sure if this is possible with the cell structure, but it is one of the few things I miss from JupyterLab and the TOC plugin.  Ideally, it would take JupyterLab's H1-H6 headers for code folding, but #region folding would be a very good alternative.

Your Jupyter and/or Python environment
JupyterLab 2.1.1
Please provide as much info as you readily know

Jupyter server running: Local
Extension version: NA
VS Code version: 1.45.1
Python and/or Anaconda version: 3.7.0
OS: Windows
Virtual environment: NA

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

@Allenite What extension are you using for #region folding?

I am using this extension for region outlines.
santacodes.santacodes-region-viewer
But region folding itself is built into VSCode, of course.
https://code.visualstudio.com/updates/v1_17#_folding-regions

@Allenite Currently the jupyter editor is implemented as a separate webview. This means that it doesn't currently respect many overall VS Code editor features. While we won't be addressing this directly this issue will be fixed by the upcoming support that VSCode core is adding for native notebooks. Just track this issue here to see the progress on that work.
https://github.com/microsoft/vscode/issues/91987


Reopen #443 according to #364

Fix bugs

Hmm... permissions errors on CI build

Ah, I just saw #547

https://twitter.com/ChaobotsC/status/873593020997713920

If you'd like, I could fix the API tokens and encryption and everything, then resubmit. This isn't getting passed without proper handling of the tokens.


MWPW-135967: card container to support fragments

When MEP is used for Cards, they are inserted into the Cards Container as Fragments.
This code change is to fix the cards container not rendering fragments correctly, resulting in cards displayed in the wrong order/position.
Resolves: MWPW-135967
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/mariia/promodemo/special-offers/special-offers?martech=off
After: https://mwpw-135967--milo--adobecom.hlx.page/drafts/mariia/promodemo/special-offers/special-offers?martech=off

Before:

After (Card positioned as 2nd, as dictated by the MEP manifest):

@3ch023 I created this page with your changes to test the use case of fragments that contain merch cards and I noticed that in this example while the fragment contains three cards, only one is displayed on the page.
I also noticed your before/after link doesn't contain any fragments (I might be missing a step to test this with personalization).

No further concerns, but I noticed that CTAs are not aligned across cards. I think there was a recent PR trying to tackle this. Is this behaviour expected for now?

Correct, that is being fixed here


Buggy Character (INI, GS & BE)

fvtt-Actor-Gerambalosch.zip
With his armor eqipped, he shows INI 13 (correct).
With his armor unequipped, he shows INI 11 (incorrect).
My char should have calculated INI of 13.5 -> rounded up to 14.
This is modified by -1 encumbrance from his armor (+3 encumbrance armor / -2 encumbrance Belastungsgewöhnung 2)
I exported my char and attached it. What is kaputt? :)
EDIT: GS does the same thing - when I unequipp, the max GS goes from 5 down to 3.

The Pantherrüsung has a weight of 23. If you don't equip it, you get an additional encumbrance of 3 which is not modified by the Belastungsgewöhnung.
See your carrying capacity in the inventory.
The weight of equipped armor does not count towards the carrying capacity limit

OMG, sometimes its so simple... You wouldnt believe how long i thought
about that.
Well, i'm in my shaming corner.
Thanks for the clarification.
Plushtoast @.***> schrieb am So., 11. Apr. 2021, 16:59:

The Pantherrüsung has a weight of 23. If you don't equip it, you get an
additional encumbrance of 3 which is not modified by the
Belastungsgewöhnung.
See your carrying capacity in the inventory.
The weight of equipped armor does not count towards the carrying capacity
limit
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Plushtoast/dsa5-foundryVTT/issues/269#issuecomment-817321494,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO7QFHZCSPCSFMDEXLMJ7X3TIG2NNANCNFSM42XXEYHA
.


Ra/test min api

Moves #23907 to this branch so I can push commits.

@furoTmark
Thanks for the fix. Be sure to check out your name as a contributor about the 3rd of next month on the What's new page

Didn't see my name, but glad to help!


Configure Faucet in TestNet to generate more transactions

Following some recent updates to the Faucet, to have a ledger, it is not sending as many transactions to the nodes in TestNet.
Maybe it just needs an updated config file or otherwise a software change.

I saw some errors loading a block after a restart so think the Faucet deployed is no longer compatible with the deployed Agora.

After deploying Agora v0.28.2 and Faucet with same Agora submodule the transaction rate is about 20 per block.


Feature Request: Integration of OpenAI Embeddings

I would like to request the integration of OpenAI embeddings into the project. As OpenAI offers powerful language models, incorporating their embeddings could significantly improve the performance and capabilities of our project.
Please let me know if there are any concerns or additional requirements for implementing this feature. I am more than happy to contribute to the development and testing process.

Hi @argen666, welcome! Please let me know which ways are you thinking to integrate embeddings;
could be used on a per-chat, per-message, per-chunk level, and to enable many use cases: search, memory, context injection.
First I'd like to hear from you: what would be the use case - how would you use embeddings and where would they show up in the user interface?

Hi @enricoros, I guess the basic use case is to build a more complete research assistant trained on multiple custom documents.
The basic step-by-step guide using embeddings:

Retrieve the custom papers related to the subjects you're interested in. (for example, academic papers)
Compute the embeddings for each of the papers. LangChain framework can be used.
Choose a platform to store the embeddings. For example, Pinecone or any of recommended by OPENAI vector database
https://platform.openai.com/docs/guides/embeddings/how-can-i-retrieve-k-nearest-embedding-vectors-quickly
Create an index for embeddings. An index is a data structure used to organize and search the embeddings.
Upload the embeddings to Database.
Once the embeddings are uploaded, we can start asking questions about the topics covered in the papers.

In our case, I think we need to add support for the vector databases listed above and add configuration for connecting to them in the application settings.
This way, the user will be able to connect their own knowledge base for use.
Please share your thoughts on this matter.
Thanks

@argen666 @enricoros I have made a PR for this here, it is a decent start functionality-wise as a proof of concept
I know it could be better integrated into the current codebase and have a better UI for sure

@michaelcreatesstuff Great work! I also implemented this functionality in parallel with you. I'm not creating a PR yet because I'm waiting for langchainJS to add the implementation to work with Redis and other vector databases. At the moment, I also have to use Pinecone because of these limitations.

@michaelcreatesstuff Thanks. I haven't tried that since I decided to focus on external vector stores to have an independent knowledge base

I believe Big-AGI could benefit greatly from embeddings as this could allow for exploration of new use cases and extended functionalities for the code assistant and textual contexts.
Here is an attempt to provide a proper request description using the repo template to help continue the discussion.
This of course was generated with some help from Big-AGI running GPT4(preview) and vetted by me:
Why
Integrating textual embeddings into Big AGI will transform the way users interact with uploaded text files by providing a more efficient and semantically rich processing method. Instead of directly inserting text into the context window, the new feature will create embeddings that capture the essence of the text. This will enable users to perform complex language tasks on larger documents without being constrained by the context window size, leading to more accurate and context-aware responses from Big AGI.
Description
This enhancement to Big-AGI will involve a transparent shift in handling uploaded text files. Upon upload, instead of placing the text into the context window, the system will generate text embeddings using a selected embedding service. These embeddings will then be used within the current conversation to maintain the flow and context. The system will be designed to support a variety of embedding services and vector databases, ensuring flexibility and extensibility. The initial implementation will focus on an in-browser vector database to provide immediate, client-side functionality without the need for server-side processing.
Requirements

[ ] Design and implement an abstraction layer that allows for interaction with various embedding services (e.g., OpenAI, Hugging Face, LocalAI).
[ ] Create a service adapter interface that defines the contract for integrating new embedding service providers.
[ ] Modify the text file upload workflow to include an embedding generation step using the selected service provider through the abstraction layer.
[ ] Ensure the new embedding workflow is transparent to the user, mimicking the current user experience as closely as possible.
[ ] Integrate the embedding process with the existing conversation context management, replacing the direct text insertion mechanism.
[ ] Design a scalable architecture that allows for the future addition of external vector databases (e.g., FAISS, Chroma, Vectara, Pinecone).
[ ] Implement a configuration system that enables users to select their preferred embedding service and vector database.
[ ] Make the current flow a fallback strategy for situations where embedding generation fails or when users prefer the traditional text insertion method.
[ ] Create documentation and user guides explaining the benefits of the new feature and how to use it effectively.

(Generated with big-AGI using GPT4(1106) and vetted by the author of this post)

Thanks for the description, clearly made by GPT-4 because it sounds good, but it's low on details.
I read when to generate and where to store. But how are the embeddings being used? Just storing them is not enough.
Is the objective to have a RAG use case? Embeddings can be used for many purposes, and I'd be curious about the top ways to use them. (Rag, MemGPT-like, etc.)

I can share here my use cases here:

Semantic search of relevant data over a colection of documents
-- I would like to be able to have multiple collections of documents to select which collection to chat with (for example all my financial documents in one collection or "workspace", my health-related documents on another and so on)

Semantic search over previous chat conversations or summarization of memory to have a bot "learn" as we interact.
-- A personas-generated agent could be the "narrator" responsible for summarization of chat conversations which will then be stored as vector embeddings and then used on future conversations.

As to where to store the vectors: ... well that is a difficult one because there are only a couple vector-db for the browser (This is the only one I know about)
-- but IMHO vectors should be stored on a more "persistenty" and user-governed database which could probably be enabled by adding integrations ... the fun part with this is the fact that the list of vector-db servicess is quite large (maybe leverage langchain-js?).
-- (maybe we can start with some OpenSource integrations like Chroma and we can ask @lunamidori5 to add that to their installer 😉 )

I hope this adds to the conversation. I would love to lend a hand to make this land on big-AGI.

@bbaaxx its next on my list! Just need to get WSL working


Preview Model

When training a model I usually go for 600 epochs to get maximum accuracy. There are times where I would like to see if the model is going to turn out the way I expect it to. It would be super helpful for me to be able to hit some sort of a "preview" button that renders the model where the training process is currently, and then continues the training to the specified epochs number and renders that one at the end also.
Or perhaps the number could be specified in the trainer before starting the training. "Preview Epochs" set to for example 100 and "Final Epochs" set to 600. Models are rendered at both 100 and 600 epochs.
If that is a lot of time to make a small feature, no worries. But figured it can't hurt to ask.

The three best checkpoints are always saved. As a workaround, you could export one of those?

I am not quite sure how to do that since I have been spoiled by the GUI
version. Are you able to still send commands in the CLI when the training
process was started from the GUI?
On Tue, Oct 24, 2023 at 12:52 AM Steven Atkinson @.***>
wrote:

The three best checkpoints are always saved. As a workaround, you could
export
https://github.com/sdatkinson/neural-amp-modeler/blob/main/bin/export/main.py
one of those?
—
Reply to this email directly, view it on GitHub
https://github.com/sdatkinson/neural-amp-modeler/issues/319#issuecomment-1776536295,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4XUIM3HSYZYKPBWRICNYVTYA5CSHAVCNFSM6AAAAAA6EDY2EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGUZTMMRZGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'd open a second terminal and do it there.
I'd also recommend copy-pasting the checkpoint you want to export since it may get deleted in favor of a better one as the trainer continues.

Okay, I will try this. Since all this functionality exists already you can
close the request.
On Wed, Oct 25, 2023, 11:12 AM Steven Atkinson @.***>
wrote:

I'd open a second terminal and do it there.
I'd also recommend copy-pasting the checkpoint you want to export since it
may get deleted in favor of a better one as the trainer continues.
—
Reply to this email directly, view it on GitHub
https://github.com/sdatkinson/neural-amp-modeler/issues/319#issuecomment-1779505038,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4XUIM6WSQM3ICHNDBB72H3YBET4HAVCNFSM6AAAAAA6EDY2EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZGUYDKMBTHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


sentry_dart_plugin default release version

Environment
sentry_dart_plugin: 2.1.0
Steps to Reproduce

run flutter packages pub run sentry_dart_plugin
observe release uploaded to the Sentry web UI

Expected Result
The plugin docs says the release is constructed from the pubspec, so I'd expect release look like buildName+buildNumber.
My Sentry initialization sets release at runtime to buildName+buildNumber (matching with pubspec as it should be) and because of that uploaded symbols are not linked/not used with issues and I have two sets of releases shown in Sentry web UI.
Actual Result
The release is shown as buildName (buildNumber).

My Sentry initialization sets release at runtime to buildName+buildNumber

you mean the release set by default through SentryFlutter.init?

you mean the release set by default through SentryFlutter.init?

That is correct

@denrase could you have a look pls

@ekuleshov Could you sahre the code with us where you set buildName+buildNumber? If the values from pubspec.yaml are the ones you want, you do not have to set this explicitly in options setup.

I'm using the package_info_plus to get the version info:
      PackageInfo pi = await PackageInfo.fromPlatform();
      _appVersion = '${pi.version}+${pi.buildNumber}';

@ekuleshov Could you sahre the code with us where you set buildName+buildNumber? If the values from pubspec.yaml are the ones you want, you do not have to set this explicitly in options setup.

I would hope so, but uploaded artifacts wasn't linked with the app release. I've hacked it around in pubspec.yaml like this for now, but this shouldn't be required.
version: &ver 2.0.7+32
...
sentry:
  ...
  release: *ver
  ...

Thx, i'll try to reproduce this.

let us know if this is still an issue


finetuning: No pytorch_model.bin file after running train_it.sh

I am trying to finetune the pretrained model version with new data. It now runs successfully creating mlflow experiments and the output folder files. However, I have not found a way to use the finetuned model.
This is a similar issue to #87 and #118 but my checkpoint folder does not contain the pytorch_model.bin, so now I am having issues when trying to model.load_state_dict(prefix_state_dict). I am following the suggestions on the issues I mentioned and my code is:
lora_path = '/...../output/sft_v0.1_ft_grad_ckpt/checkpoint-500/adapter_model.bin' # no pytorch_model.bin file was found
model = MplugOwlForConditionalGeneration.from_pretrained(
      'MAGAer13/mplug-owl-llama-7b-pt',
      torch_dtype=torch.bfloat16
  )
  peft_config = LoraConfig(
      target_modules=r'.*language_model.*\.(q_proj|v_proj)', inference_mode=False, r=8, lora_alpha=32, lora_dropout=0.05
  )
  model = get_peft_model(model, peft_config)
  model.print_trainable_parameters()
  prefix_state_dict = torch.load(lora_path, map_location='cpu')
  model.load_state_dict(prefix_state_dict)

The output folder structure is:
- adapter_config.json
- adapter_model.bin
- REDME.md
- train.log
- runs/
- checkpoint-500/
-- adapter_config.json
-- adapter_model.bin
-- optimizer.pt
-- rng_state_0.pth
...
-- rng_state_7.oth
-- scheduler.pt
-- trainer_state.json
-- training_args.bin

I get an error on the last line,   model.load_state_dict(prefix_state_dict):
RuntimeError: Error(s) in loading state_dict for PeftModel:
	Missing key(s) in state_dict: "base_model.model.query_tokens", "base_model.model.vision_model.embeddings.cls_token"....

which I think confirms that I am using the wrong lora_path, but I don't see the pytorch_model.bin file.  Does anyone have any insight on what may be happening or how I could load the new finetune model if I don't have the pytorch_model.bin file?

Solved:
from peft import PeftModel

model = MplugOwlForConditionalGeneration.from_pretrained(
    pretrained_ckpt,
    torch_dtype=torch.bfloat16
).to(device)

m = PeftModel.from_pretrained(model, lora_adapters_path)
model = m.merge_and_unload()


Change API for color set functions to take an integer (of colors to return) as an argument.

I'm thinking an API along the lines of set2 : Int -> List Color instead of set23 : List Color, set24 : List Color and so forth. With this we could eliminate some duplication in the code by defining each color set just once and using List.take on it. This makes it easier to use the package if you don't know beforehand how many colors you need. Also: I think it will be clearer that it is "three from set two", not "set twentythree" with this change.
I could take upon myself to implement this if it is desired.
Awesome initiative to bring these great data visualisation palettes to Elm!

I guess my proposed API will lead to some problems if used as is. We would have to return the empty list for arguments less than one, but that is not as big of a problem as returning the entire palette with length n when the argument is greater than n. That might lead to unanticipated behaviour for the user. For example: they expect a list of length 12, but get 10.
Alternatively we cycle the palette so the overflow takes colors from the beginning of the list. But that is not super-intuitive and seldom useful in a plotting context. This is the second option.
None of these two optimal, but I'm not happy with the API as it is either. Is it reasonable to expect the user to check the maximum number of colors in a palette?
What is more desirable: to always get a list back that has the same length as the input (at least when the argument is positive) or never get duplicate colors?
A third option is to return a Maybe. Return Nothing when the argument is out of range, but that seems a bit clunky.
I'm leaning towards the first option, which happens to be the behaviour of List.take.

@RalfNorthman
I've adopted the generated code to include a function like set2 : Int -> List Color. It is using as much information as what is available when generating the color file. As long the elm compiler gets rids of as much as possible code on compile time this approach seems doable.
Please try out the version 4.1.0 :)


NixOS doesn't support getting hostname from DHCP server

Describe the bug
From man configuration.nix:
networking.hostName
  The name of the machine. Leave it empty if you want to obtain it from a DHCP server (if using DHCP).

So having empty hostname is supposed to work.
However, this happens when setting networking.hostName = "" and booting on a network where the DHCP server passes the hostname "clientA" to the NixOS machine:
localhost NetworkManager[928]: <warn>  [1575302169.8262] hostname: couldn't set the system hostname to 'clientA' using hostnamed: GDBus.Error:org.freedesktop.DBus.Error.NotSupported: Changing system settings via systemd is not supported on NixOS.
localhost NetworkManager[928]: <warn>  [1575302169.8263] policy: set-hostname: couldn't set the system hostname to 'clientA': (1) Operation not permitted
localhost NetworkManager[928]: <warn>  [1575302169.8263] policy: set-hostname: you should use hostnamed when systemd hardening is in effect!

To Reproduce
Steps to reproduce the behavior:

A network with DHCP server that gives hostname to client.
A NixOS client machine with networking.hostName = ""
Boot the client.
See that client hostname is not what the DHCP server asked and the system journal includes warning that the hostname could not be set.

Expected behavior
I expect the hostname given by the DHCP server to be set as a "transient hostname". https://www.freedesktop.org/software/systemd/man/hostnamectl.html.
Additional context
I'm runnign GNOME3 with NetworkManager. Perhaps non-NetworkManager setups work?
Metadata
NixOS 19.09.

This is because of GDBus.Error:org.freedesktop.DBus.Error.NotSupported: Changing system settings via systemd is not supported on NixOS., networkmanager probably uses systemd for this and it's patched out in our fork.

Perhaps we can update that patch to allow setting the transient hostname only?
Simpler reproduce steps:
$ hostnamectl --transient set-hostname foobar
Could not set property: Changing system settings via systemd is not supported on NixOS.

That sounds like it should be at least allowed. We should move this issue to the systemd nixos repo.
(or at least open the issue there).

I cannot create issue in https://github.com/NixOS/systemd. Either issues are disabled or I don't have rights. (It seems I can create a pull though.)

@Mic92 ^

I don't have the power to open issues up there, but I am also not sure, we really need a second issue tracker. It might just create confusion, where to open up issues and people have to look in two places.

cc @NixOS/systemd

No need to create issues over there, nixpkgs uses vanilla systemd by now, and that behaviour is part of a downstream patch.

To add some additional information:

This is broken due to one of our downstream systemd patches (pkgs/os-specific/linux/systemd/0007-hostnamed-localed-timedated-disable-methods-that-cha.patch) that forbids setting the hostname via D-Bus (sd-bus).
I see the following possible fixes (though there might be better ways):

Allow changing the hostname via systemd if networking.hostName is empty (but this might be a bit difficult to implement and maintain, depending on how we implement it)
Always allow changing the hostname via systemd (CLI and/or sd-bus - easy to implement, but might not be desirable, especially with tools like NetworkManager)
Patch NetworkManager (and other tools) to use a different mechanism to set the hostname (but this is probably a bad idea as that requires elevated privileges).

Update after having a quick look at src/hostname/hostnamed.c (systemd): It would probably be best to allow org.freedesktop.hostname1.set-hostname and only deny org.freedesktop.hostname1.set-static-hostname. This would allow NetworkManager and other tools to change the transient hostname but the kernel hostname would only be updated if /etc/hostname isn't empty (i.e. networking.hostName should work as expected).
Additionally it might be nice if we could drop 0007-hostnamed-localed-timedated-disable-methods-that-cha.patch entirely and replace it with custom Polkit rules (I think that should be possible, but I know very little about Polkit). If that works we could also change the rules dynamically based on networking.hostName and without having to recompile systemd (or anything else).

Being able to drop more of our patches sounds good, but can polkit be used to even disallow root to do these actions?
What happens on systems with polkit disabled?

can polkit be used to even disallow root to do these actions?

Idk, but probably not. I guess it's only intended to grant additional privileges (but it could be possible). But ideally no services should be running as root.

What happens on systems with polkit disabled?

This obviously has to be checked properly, but as long as it's implemented sane (I'd consider everything else as a critical security bug) it should obviously reject everything.
src/shared/bus-polkit.c seems to confirm this, but I wouldn't take it as proof as there are additional control-flow paths and I didn't check the whole function:
                        /* Treat no PK available as access denied */
                        if (sd_bus_error_has_name(e, SD_BUS_ERROR_SERVICE_UNKNOWN) ||
                            sd_bus_error_has_name(e, SD_BUS_ERROR_NAME_HAS_NO_OWNER))
                                return -EACCES;

Hmm, I think https://github.com/NixOS/nixpkgs/pull/26608 remove a similar restriction in our downstream patch, by just not creating that file via NixOS.
Looping in @lheckemann.

@flokli that also seems like a nice and easy fix. The implementation is here. This would be a viable alternative to using Polkit (though it might require a reboot after changing networking.hostName but I guess that wouldn't be a big problem).

cross-referencing for context: https://github.com/NixOS/nixpkgs/issues/80038

@primeos do you want to give this a try?
You should be able to test this without rebuilding the world, by just passing that other systemd via systemd.package.

@flokli I thought about it, but unfortunately I cannot easily test this currently due to some ongoing setup changes. Would be best if someone who uses NetworkManager could give it a shot (is anyone in this thread interested and has time?). If it would help I could create a PR, but testing is the actual work.
As for the implementation: I think it would be best to drop that part of our systemd patch entirely. I.e. always allow method_set_hostname (unconditionally) and only deny method_set_static_hostname. Then depending on if networking.hostName is empty or not it should only allow to set the transient hostname (vs. additionally the static hostname).
From man hostnamectl:

This tool distinguishes three different hostnames: the high-level "pretty"
hostname which might include all kinds of special characters (e.g. "Lennart's
Laptop"), the static hostname which is used to initialize the kernel hostname at
boot (e.g. "lennarts-laptop"), and the transient hostname which is a fallback
value received from network configuration. If a static hostname is set, and is
valid (something other than localhost), then the transient hostname is not used.

Happy to give this a spin, once there's a PR open :+1:

@flokli ok, I've opened #91232 ;) I've also had time to quickly test this manually, but not with NetworkManager.

Thanks for fixing this!


Update link to Celery's configuration docs page

Small thing. The link in README to Celery's documentation page on configuration details was outdated.

Coverage remained the same at 96.454% when pulling afa4babc913d5464eea1d66b6bb1a5d9da724d9e on Weyzu:update-docs-link-in-readme into efecf544a5d79be17417725c4c6cece378a29546 on sontek:master.


A few Typescript and Knex issues

Here are some misc things that I think could be changed. I've never written an open source PR before, I think it's easier if an existing contributor changed it:

Knex supports objects for joins and aggregates. It's especially useful for multi-column joins:

.join(
  'foo',
  {
    'foo.col1': 'bar.col1',
    'foo.col2': 'bar.col2',
  },
)

Something like this ((table: TableRef<QB>, columns: Record<string, ColumnRef>): QB;) could be added to JoinMethod.

Knex's limit now supports an additional param "skipBinding" (https://github.com/knex/knex/issues/4805). Objection's FirstOperation calls limit without skipBinding, which triggers an error in some databases (Materialize).

Objection's type exports UniqueViolationError, but this actually needs to be imported from db-errors.

Objection's Model type doesn't include "propertyNameToColumnName".

(not a real issue) addOperation and KnexOperation aren't documented or exposed through types, but they're useful for new or custom Knex operations.

Thanks for building and maintaining this awesome library!

Same problems here for Objection errors. In Typescript We can't do that :
import { UniqueViolationError } from 'objection';


Add custom migrations path override

👍
Looking forward for this feature.

Thanks , not entirely sure why the tests are failing

@RC1140 I believe it's failing because of this search magic: https://github.com/go-pg/migrations/blob/master/collection.go#L132 that excludes the go-pg/migrations/examples/ that have references to my_table. But in a new project it doesn't auto-exclude.
Honestly I don't know why it's designed in a way to auto-walk these file paths looking for migrations, instead of specifying a path (which is a normal production flow) in the first place. Maybe the @vmihailenco  can enlighten us the initial considerations. Thanks.

Thanks for the PR, but I prefer to export DiscoverSQLMigrations instead so existing API is not changed.


[Feature Request] @types/ for packages that already include types as Unused

Hi, great project!
I noticed that Webpack 5 now includes types, so including @types/webpack is no longer necessary.
We probably have a lot of packages like this.
To figure out which packages now include types, maybe we can look in each dependency's package.json for a "types" key?

What is the issue you're seeing? Is @types/webpack being reported as a false positive?

I see the potential too: If the dependency comes with it's own type definitions, and you have a @types dependency of it installed that is now deprecated, it's useless and should be removed, no matter if you included it or not.

In the example above, @types/webpack should be reported as unused.

:rocket: This issue has been resolved in v2.30.0. See Release 2.30.0 for release notes.

As far as I can see Knip just needs to check for the types (or typings) field in package.json`, so that's what it's doing now :)

:rocket: This issue has been resolved in v2.32.0. See Release 2.32.0 for release notes.


fix(ci): fixed github ref name.

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area ci
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

I pushed a 0.5.1 tag to test this out.
It works.
/cc @leogr

I removed the tag.
Dockerhub images will be overwritten (i will make sure to make a new release as soon as this gets merged).

/approve


Feature addition policy

Each addition to the beacon API carries a significant implementation and maintenance cost, since in general, there's an expectation that beacon nodes actually will implement the API as specified.
As such, we should consider the requirements for any new additions to the common API so as to manage expectations with users and keep implementation burden reasonable.
A couple of ways this can be done:

minimal approval requirements - ie at least N clients commit to implementing the API by approving it
minimal released implementations - ie features are not merged until a client release exists supporting the feature (to ensure that we don't add features that are unimplementable or that nobody actually is willing to implement)
explicitly experimental / extension API (to manage user expectations around API stability)

this is similar to how the engine API defines a "required" of the more general JSON-RPC API - modules can creatively be used for "special-interest" features such as distributed validator middleware etc

While many features are obvious (ie hard-fork related updates to BN/VC interface), others are more nuanced - it is trivial to keep adding things to a standard, but much harder to remove or change things.
In general, it's fairly cheap to keep things in PR until they pass minimal QA bars such as above - the PR serves as implementation guide for early adopters avoiding fragmentation while at the same time making it easy for implementers to track what is "usually" supported by clients and what is not.

The original beacon API was designed to provide an interface to the data structures in the spec, along with some minor additions where they were required to avoid a lot of back-and-forth with multiple API calls to obtain information, or where the required information was held in larger data structures such as state.
I tend to agree that we need to try to limit the scope of the changes to the API such that they don't expand too far beyond this remit.  Requiring beacon nodes to do work that can be done outside of the beacon nodes seems to be overloading the API, and adding more methods makes it harder for new entrants to implement either a client or a server.
An alternative is to consider putting such APIs in their own namespace and their own repo.  The MEV-boost-related API calls are a decent example of this, where there is still input from the client teams and they work on much the same principles, but they are their own entity.  They can use separate top-level endpoints to provide separation, and client teams won't have the same pressure to build and maintain them if they do not have the time or desire to do so.

To me, two great examples are

mev
lightclient
where we're adding api calls specifically for basically non beacon-apis functionality.

To varying degrees we've got a split of the amount of implementation on both, and it's not really documented as to the level of support for various things (even the OG rest api had certain endpoints not supported by certain clients), which is why I've added a table to try to capture that in changes, but with all these things, once the implementation is done it's harder to go back and fill that table - it kind of appeared very late in the picture.
At least being their own namespace I think would make sense. This would make the UX better for people looking for them a lot cleaner, as well as make it arguably easier for devops / systems type people to load balance certain endpoints, block subroutes etc.
I guess this does ultimately pose the question did we make the wrong choice on MEV and / or Lightclient, and is it something that there's lessons to learn from...

There are other recent examples too: distributed validator endpoints and validator performance API come to mind.
Re light client data, these actually have direct backing in the beacon spec, so they shouldn't be controversial as far as adding them here goes.
MEV indeed is a troublesome example, but perhaps not so much: all clients have expressed approval and actually implemented it.


Support PHP 7.1 void return type

As per PHP 7.1, a new void return type is introduced ( https://wiki.php.net/rfc/void_return_type )
This basically means that the TypeGenerator needs to be patched to support void.
No further changes really needed in this component, as it doesn't really focus on method body generation.

Done in #87 and released with 3.1.0.


v1.50.1 creates debug.log automatically

Issue Type: Bug

Open a folder
Open any file in said folder

VSCode will automatically create a debug.log file. This issue was not present on v1.50, but appeared on v1.50.1.
Related: #105191. (Bug was fixed on v1.49.2, has now reappeared again). Repro steps from that issue are likely to work now too.
VS Code version: VSCode 1.50.1 (d2e414d9e4239a252d1ab117bd7067f125afd80a, 2020-10-15T10:44:06.171Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz (8 x 2112)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.84GB (0.77GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (47)

Extension
Author (truncated)
Version

better-comments
aar
2.1.0

html-snippets
abu
0.2.1

vscode-sqlite
ale
0.9.0

bracket-pair-colorizer-2
Coe
0.2.0

vscode-markdownlint
Dav
0.37.1

vscode-eslint
dba
2.1.10

githistory
don
0.6.12

gitlens
eam
10.2.2

EditorConfig
Edi
0.15.1

vscode-npm-script
eg2
0.3.13

vscode-front-matter
eli
1.7.0

prettier-vscode
esb
5.7.1

vs-code-xml-format
fab
0.1.5

vscode-npm
fkn
3.3.0

ginfuru-vscode-jekyll-syntax
gin
0.1.1

vscode-jekyll-snippets
gin
0.9.3

gc-excelviewer
Gra
3.0.40

Python-autopep8
him
1.0.2

vue-snippets
hol
0.1.12

svg
joc
1.3.11

docthis
joe
0.7.1

vsc-python-indent
Kev
1.11.0

kite
kit
0.129.0

restructuredtext
lex
129.0.0

template-string-converter
meg
0.1.8

code-beautifier
mic
2.3.3

dotenv
mik
1.0.1

vscode-docker
ms-
1.6.0

python
ms-
2020.9.114305

remote-wsl
ms-
0.50.1

debugger-for-chrome
msj
4.12.11

vscode-streamdeck
nic
4.1.5

hide-gitignored
npx
1.1.0

vetur
oct
0.28.0

vscode-versionlens
pfl
1.0.8

material-icon-theme
PKi
4.3.0

ruby
reb
0.27.0

synthwave-vscode
Rob
0.1.8

trailing-spaces
sha
0.3.1

svg-preview
Sim
2.8.3

control-snippets
svi
1.9.1

sass-indented
syl
1.8.12

html-preview-vscode
tht
0.2.5

vscode-icons
vsc
11.0.0

vscode-ruby
win
0.27.0

markdown-all-in-one
yzh
3.3.0

material-theme
zhu
3.9.3

(1 theme extensions excluded)

I am unable to repro with the steps from previous issue as well as the current one. We haven't changed the runtime between 1.50 and 1.50.1, so highly unlikely the issue resurfaced. Can you paste the contents of debug.log ?

I had same problem. For me it was ckolkman.vscode-postgres extension that was creating debug.log.

I can confirm this behaviour. The contents of the file:
[1019/095427.124:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3)

Version: 1.50.1 (user setup)
Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a
Date: 2020-10-13T15:06:15.712Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041

For some reason I can't repro anymore, but here is one of the files it created while i still could repro:
[1018/120034.920:ERROR:registration_protocol_win.cc(103)] CreateFile: Systemet finner ikke angitt fil. (0x2)
[1018/120330.913:ERROR:registration_protocol_win.cc(103)] CreateFile: Systemet finner ikke angitt fil. (0x2)
[1018/120724.633:ERROR:registration_protocol_win.cc(103)] CreateFile: Systemet finner ikke angitt fil. (0x2)

(Poorly) Translated: The system cannot find the specified file

Hello, I can confirm that this issue is still happening on v1.50.1. VSCode keeps creating a debug.log on the root of my working directory with these contents:
[1019/155955.848:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3)

I am having the same issue. I've ran as administrator as well.
[1016/093125.450:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3) [1016/121627.459:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3)
Version: 1.50.1
Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a
Date: 2020-10-13T15:06:15.712Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041

@balintbalazs @AlphaEndgame @cDurhamZP based on the log, the issue you are facing is from chrome and not vscode please refer to https://bugs.chromium.org/p/chromium/issues/detail?id=1138853 for more info.
@ent3r I am closing this issue, can reopen if there is a repro with vscode, the issue is getting side tracked with unrelated bug from chrome or other chromium related browsers.

that would make sense if it wasnt for the fact that i dont have chrome/chromium installed. im guessing since electron is also chromium it goes under that bug?

I managed to get the error to go away by removing an extension: JavaScript Debugger (Nightly)
Not sure if correlation or causation, but there it is

@cDurhamZP the problem is not the extension but the extension spawning any chromium browser for debugging which would hit the issue I had linked.

im guessing since electron is also chromium it goes under that bug?

@ent3r Depends on what other electron app you might have, if there is a reliable repro it would help.

I'll have a look if it appears again, thanks for the quick response

Hello,
same here with VSCodium 1.50.1 and able to repro while not using Chrome :

clone https://git.spip.net/spip-contrib-extensions/cvt_rechercher.git somewhere on your Windows 10 machine
open this repo in VSCodium
clone https://git.spip.net/spip-contrib-extensions/responsivenav.git somewhere else on your Windows 10 machine
open this 2nd repo in another VSCodium
open the file prive\squelettes\contenu\configurer_responsivenav.html
TADAM !

Maybe it's something about windows access permissions to files/folders ?

@jmoupah VSCodium is not vscode, they wouldn't have the runtime that contains the fix yet.

Ok, thanks for your answer.
Thing is, I don't see any issue on the repo https://github.com/VSCodium/vscodium/issues?q=is%3Aissue+debug.log


Chore/theme updates 20210707

For #216

use TitilliumWeb font
reduces font size
small tweaks for legacy content

Lots more to be done, but these are some key starts.

Have also added: Header colours, container backgrounds, table and figure tweaks
Merging.


make generate-images fails with newer inkscape versions

Gitea version (or commit ref): 7744b36
Git version: not relevant
Operating system: not relevant
Database (use [x]): not relevant

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
make generate-images fails with newer inkscape versions (version 1.0) because some CLI arguments have changed.
References:
https://inkscape.org/sk/doc/inkscape-man.html
https://wiki.inkscape.org/wiki/index.php/Using_the_Command_Line#Changes_from_0.92
Instead of inkscape -f <infile> ... -e <outfile>, it should be inkscape <infile> ... --export-file=<outfile>.
(I stumbled upon this when creating my own Gitea logo)
This could be helpful:
inkscape --version 2>/dev/null | cut -d ' ' -f 2 | cut -d . -f 1 prints the major inkscape version which then can be compared to '0' or '1'.

Should be resolved with https://github.com/go-gitea/gitea/pull/12316 if you want to give it a try.

Should be resolved with #12316 if you want to give it a try.

This works, thanks!


Remove unsupported go1.7

Kubernetes only support go1.8 now, or else it won't compile. This PR removes go1.7 in travis.
Fix #104.

Self-merging to unblock other PRs.


characterCounter not working by following documentation

Expected Behavior
Expect the characterCounter to work by following the documentation.
Current Behavior
It is not working, it is saying that characterCounter is not a function.
Possible Solution
I eventually got it to work by using this code:
var textNeedCount = document.querySelectorAll('.validate.center-align.inputfield');
M.CharacterCounter.init(textNeedCount);

Steps to Reproduce (for bugs)
<!-- Compiled and minified JavaScript -->
    <script src="https://cdnjs.cloudflare.com/ajax/libs/materialize/1.0.0/js/materialize.min.js"></script>
    <script src="https://code.jquery.com/jquery-3.4.1.min.js"
        integrity="sha256-CSXorXvZcTkaix6Yvo6HppcZGetbYMGWSFlBw8HfCJo=" crossorigin="anonymous"></script>
    <script>
        $(document).ready(function () {
            $('.validate.center-align.inputfield').characterCounter();
        });
    </script>

It's a problem loading the libs, add jQuery first
<!-- Compiled and minified JavaScript -->
<script src="https://code.jquery.com/jquery-3.4.1.min.js"
        integrity="sha256-CSXorXvZcTkaix6Yvo6HppcZGetbYMGWSFlBw8HfCJo="crossorigin="anonymous">
<script src="https://cdnjs.cloudflare.com/ajax/libs/materialize/1.0.0/js/materialize.min.js"></script>    </script>
<script>
   <!-- my code blablabla -->
</script>

It's a problem loading the libs, add jQuery first
<!-- Compiled and minified JavaScript -->
<script src="https://code.jquery.com/jquery-3.4.1.min.js"
        integrity="sha256-CSXorXvZcTkaix6Yvo6HppcZGetbYMGWSFlBw8HfCJo="crossorigin="anonymous">
<script src="https://cdnjs.cloudflare.com/ajax/libs/materialize/1.0.0/js/materialize.min.js"></script>    </script>
<script>
   <!-- my code blablabla -->
</script>

@arnaumanyosa Is it possible to do it without jQuery and just vanilla Javascript, or is jQuery a requirement?

@arnaumanyosa Is it possible to do it without jQuery and just vanilla Javascript, or is jQuery a requirement?

I'm totally new on this but I guess is not necessary. Anyway you should always check the documentation
https://materializecss.com/getting-started.html
(and close this issue :D )


docs: Adds PHP integration page

This commit adds a new page to the Integrations category demonstrating how to create Dagger Functions to test and publish a generic PHP application. It is based on the archived guide at https://archive.docs.dagger.io/0.9/128409/build-test-publish-php/

Nicely done @vikram-dagger, I'm catching up on things now.


Handle paths with a '?' in them

This is actually quite tricky, as URI does not let you create these by
default, you need to sneak them in using URL.toUrl(). If you attempt to
use the URI constructor directly then a '?' is interpreted as the start
of the query string, and %3f is encoded to %253f, so there is no way to
actually pass in an ecoded question mark to the URI constructor.

Out of curiosity, in what cases can a uri pointing to a jar contain question marks? Any examples?

Just make a directory with a question mark in the name on Linux (won't work on windows).

Perhaps skip the test on Windows?


Adding ability to publish VSIX

Allows our CI build to publish updates to vsixgallery
Fixes nuget warnings while packaging nuget package because libraries are not stable releases

Are you handling version numbering for CD builds? Right now, versions are taken from the version.txt files, but to do CD, we would want at least the revision number changing on each deployment

Are you handling version numbering for CD builds? Right now, versions are taken from the version.txt files, but to do CD, we would want at least the revision number changing on each deployment

We don't use version.txt for ApiPort.Vsix builds. But, in restore.ps1, we increment the "revision" number by default, so takes into account the version that exists in the vsix manifest.

We should consolidate the versioning strategy, but that'll work for now


Question: What new updates are coming so far?

I have a question: Are there any new updates coming this month or next month? If so, what are you adding?

We're working on the vanilla branch mainly right now.

 I really hope so because I've been really looking forward to that and I didn't get to experience it last year.

 I really hope so because I've been really looking forward to that and I didn't get to experience it last year.

 I really hope so because I've been really looking forward to that and I didn't get to experience it last year.

Scream Fortress moment

Wait, Scream Fortress?! is that a Halloween stage coming?!

 I really hope so because I've been really looking forward to that and I didn't get to experience it last year.

Scream Fortress moment

Wait, Scream Fortress?! is that a Halloween stage coming?!

No, it's an event in Team Fortress 2 that occurs every October. Although it would be quite funny to see a "Scream Fortress" map.

 I really hope so because I've been really looking forward to that and I didn't get to experience it last year.

Scream Fortress moment

Wait, Scream Fortress?! is that a Halloween stage coming?!

No, it's an event in Team Fortress 2 that occurs every October. Although it would be quite funny to see a "Scream Fortress" map.

Oh. well fr are you gonna do a Halloween update?

 I really hope so because I've been really looking forward to that and I didn't get to experience it last year.

Scream Fortress moment

Wait, Scream Fortress?! is that a Halloween stage coming?!

No, it's an event in Team Fortress 2 that occurs every October. Although it would be quite funny to see a "Scream Fortress" map.

Oh. well fr are you gonna do a Halloween update?

I'm not going to. I ain't a dev. I'm basically the opposite, as I'm banned. However I don't know about if there will be a Halloween update,, but if there is, I feel like it'd just be a title screen change or something. However, I definitely do see potential in the Scream Fortress map idea, don't get me wrong.

Can you at least tell me what the devs did last year for Halloween?

Can you at least tell me what the devs did last year for Halloween?

I don't know what they did. Fairly certain I was banned by then. Check the sm64js wiki, you may find something there.

 I really hope so because I've been really looking forward to that and I didn't get to experience it last year.

Scream Fortress moment

Wait, Scream Fortress?! is that a Halloween stage coming?!

No, it's an event in Team Fortress 2 that occurs every October. Although it would be quite funny to see a "Scream Fortress" map.

Oh. well fr are you gonna do a Halloween update?

I'm not going to. I ain't a dev. I'm basically the opposite, being banned. However I don't know at all if there will be a Halloween update,, but if there is, I feel like it'd just be a title screen change or something. However, I definitely do see potential in the Scream Fortress map idea, don't get me wrong.

I'm genuinely considering just trying to make a Scream Fortress map and trying to get it added now...

really?!


Remove version: GnuWin32.Grep version 2.5.4

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/gnuwin32/files/grep/2.5.4/grep-2.5.4-setup.exe/download
OK
(Automated message - build 923)

URL: https://sourceforge.net/projects/gnuwin32/files/grep/2.5.4/grep-2.5.4-setup.exe/download
Status Code: 200
(Automated message - build 900)

Close with reason: URL works;


Error : Failed to create chart: can't acquire context from the given item

Hi,
I'm trying to make a multi-line chart using chart.js (which is a very nice tool :) ) but i got the error
Failed to create chart: can't acquire context from the given item and i don't find why it make this error...
i give you in attach file my code (HTML and JS and the source file json)
Thanks for your help
TESTING.zip

Hello @Fourbasse76,
I solved the issue. you just forgot to add one line in your code.You are not passing the 2d context of the canvas (ctx) when calling the constructor. Just  add following line in your code before myChart.
var ctx = document.getElementById("chart").getContext("2d");
var myChart = new Chart(ctx, {...
Let me know if you still got the error.
Thanks.

Hi ,
WHen i add the line i got this error

TypeError: document.defaultView.getComputedStyle(...) is null
ut.getStyle@/chart.min.js:7:154316
De@/chart.min.js:7:74365
acquireContext/<@/chart.min.js:7:76989
acquireContext@/chart.min.js:7:76761
construct@/chart.min.js:7:92206
ni@/chart.min.js:7:91959
@/script.js:56:15
c@https://code.jquery.com/jquery-3.4.1.min.js:2:27737
fireWith@https://code.jquery.com/jquery-3.4.1.min.js:2:28487
l@https://code.jquery.com/jquery-3.4.1.min.js:2:78787
o/<@https://code.jquery.com/jquery-3.4.1.min.js:2:81117
at /chart.min.js:7:154316

i precise that i work in jquery ;)

i change my code now it work :D

Actually, I still had the error

Having the same error... I've tried some other stuff but no success.


gasAfterPaymentCalculation is too high

https://www.notion.so/krustuniverse/Gas-Estimation-d7ca3d6676964d4d821ad38892aeb3c7

I think the calculation is quite precise, as compared to fulfillment on baobab. It cost: 108,478 (we did some extra calculation in the fulfill functions.)
ref: fulfilment transaction: https://baobab.scope.klaytn.com/tx/0xb5ec55bb4e2a27e7f3f3348916e5b1f9ed22d3112b0f4b7c7b10d47bc072bc41?tabId=internalTx

@KelvinThai Yes, the calculation should be precise, but the main point of this issue is that it is 3x larger than with Chainlink. That is quite significant difference! I am suspecting we do something quite unoptimized and wanted to know what it is and if we can improve it.

I think the number is outdated. I tried chainlink on bsc testnet and the gas used for fulfillment is 188,297 which is somewhere similar to ours.
ref: https://testnet.bscscan.com/tx/0x948c53e0a133783ae5397c9806477bb7c5611bb189ef104f863ed5272eb033f8

I am not fully convinced. At https://vrf.chain.link/, there is a link to VRFCoordinator (https://sepolia.etherscan.io/address/0x8103b0a8a00be2ddc778e6e7eaa21791cd364625#readContract) which allows to query config through getConfig and it returns the following response
minimumRequestConfirmations   uint16 :  3
maxGasLimit   uint32 :  2500000
stalenessSeconds   uint32 :  86400
gasAfterPaymentCalculation   uint32 :  33285

We changed quite many things related to gas after payment calculation for VRF and RR. The description above are outdated and does not correspond to the latest code. Will raise the issue again if we encounter it again.


Updated Navigation number

Updated Navigation number from 5 to 6
Please verify the following:

[ ] yarn ci:test jest tests pass with new tests, if relevant
[ ] README.md has been updated with your changes, if relevant

Describe your PR

Thanks @mrshahzeb7!!


Change the endpoint we call for page restore

After we switch to restriction-table based access checking we'd need to call a different endpoint to signal an undelete. The revision-table based wouldn't be broken too, so it's safe to deploy prior to the switch.
The problem is that on the HTML endpoint the access check is done in parallel with content request, and the content request is the one that would update the restriction table, so we get a race condition. Notifying the title endpoint avoids that issue.
cc @wikimedia/services

Coverage remained the same at 93.117% when pulling 5bbac5d863f13e64542f0bf3d5e6d9472d127b00 on Pchelolo:undelete-fix into fb5a3abbdc853f8442ae6cb8966b0afa2b7316d3 on wikimedia:master.

Created a gerrit patch: https://gerrit.wikimedia.org/r/#/c/320458/


Several genes show "doesn't seem to be a gene in this genome" on main page

Example: see TC_RS00050 under Muridarum Nigg

It seems that these are genes that have no encoded proteins in wikidata.   Working on a solution now

Looks like the protein bot is  '# only using items with exactly one swiss-prot or trembl ID'  and the mygene call for TC_RS00050 returns 2 ids in the trembl field. https://mygene.info/v3/gene/1245533 . Will have loop @stuppie in here and think about how to include thes.

... and to note, this is a link that reproduces the error: http://chlambase.org/organism/243161/gene/TC_RS00070

I modified the query to make the encoding property optional.

Now, it properly selects non-coding genes


Story: Stop-sequence for python

Added support for stop sequence using python. We have made modification only in example_app.py.
https://antaris.atlassian.net/browse/AT-4662

Another approach is needed to handle the stop sequence logic