Implement base functionality for kafka connector inserts

This is the first of 5 PRs based on #4230
This PR focuses on adding code to the kafka connector to support inserts. Something to note is that inserting won't actually work because none of the encoders are included. Each of the four encoders will have their own follow-up PRs after this one gets merged. This PR also lays out the base interfaces and classes for the encoder.
I have changed how the encoder works since #4230 . Each RowEncoder has a collection field that will store row data until requested as a byte[] by the KafkaPageSink. The page sink will call overloaded put(EncoderColumnHandle, value) methods to add values to the row. Then once the page sink gets the byte[] from the RowEncoder it calls a clear() method that clears the backing collection.
This PR is part of the implementation for #3980

The RowEncoder now has a putValueAt method that has a block and position as parameters. This method handles getting the value from the block at the given position and calling the correct put method. I also changed the parameters of the DispatchingRowEncoderFactory and the RowEncoderFactory to no longer take a Map containing just the dataSchema. Instead it takes an Optional<String> that contains the parsed avro data schema if it exists. This Map was just used for the data schema so it seemed like overkill to me. I also added support for writing to multiple partitions, although this feature is not tested.

I also added support for writing to multiple partitions, although this feature is not tested.~

I would prefer to add it as a followup with test.

As you address the comments please squash the fixups. And a commit with simplest possible Encoder to this PR. It will make PR a bit larger, but he will have some validation that abstractions are sound.

I would prefer to add it as a followup with test.

Ok, probably best not to rush things.

And a commit with simplest possible Encoder to this PR.

They're all pretty equivalent in terms of complexity, maybe the csv one is simplest

I would prefer to add it as a followup with test.

+1.

And a commit with simplest possible Encoder to this PR.

They're all pretty equivalent in terms of complexity, maybe the csv one is simplest

CSV is fine

I've added a commit with the csv encoder

Made changes based on the suggestions made by @findepi
Kafka inserts commit

Removed default implementations of methods in RowEncoder interface
Added AbstractRowEncoder class that provides structure for the different data format encoder implementations
Changed putValue methods to appendValue methods in the encoders that now only take the block and position as parameters
AbstractRowEncoder now tracks the current column index for appending values to the row encoder, no longer have to pass column handle as parameter when appending
Encoders now get the current session during implementation
Changed name of field keyDecoder in KafkaColumnHandle to keyCodec so that it can be used without confusion for the decoder and the encoder
Added check in KafkaMetadata to make sure insert columns match actual columns
KafkaPageSink#appendPage now has some (limited) error handling if a producer record fails to send
Changed column handles stored in row encoder from Set to List to preserve correct order
The producer factory now uses an ImmutableMap to store config info

CSV encoder commit

CSV encoder now uses currentColumnIndex to append values to the String[]
CSV encoder uses AbstractRowEncoder constructor
kafka_key column in csv table is no longer hidden, users are able to specify a key

Changes based on review from @losipiuk
Kafka inserts commit

validateColumns returns void and columnHandles are copied in AbstractRowEncoder constructor
Add check in appendColumnValue to make sure currentColumnIndex is not greater than number of columns
Add callback in KafkaPageSink that counts number of producer records that fail to send and throw error if number is greater than 0

CSV encoder commit

remove size field from CsvRowEncoder
clear no longer does anything in the CSV encoder because there are checks to make sure that every column is appended for every new row
toByteArray checks to make sure that every column has been updated with values for each new row

Rebased and brought in KafkaColumnHandle changes

I'm feeling good about where this PR is at @losipiuk @aalbu any more comments?

The other encoders are blocked by this pr for now. They can be found here:

Json Encoder PR - https://github.com/charlesjmorgan/presto/pull/4
Raw Encoder PR - https://github.com/charlesjmorgan/presto/pull/3
Avro Encoder PR - https://github.com/charlesjmorgan/presto/pull/5
@losipiuk @aalbu

Thanks !


Wizard workflow

Links

Issue link https://github.com/usdigitalresponse/neighbor-express/issues/121
Documentation links

GIF/Screenshots:

Changes:

There are 2 steps to sending emails (enqueueing and then sending). Now these are separated

How To Test:

Follow local development instructions in send_email_messages/README.md.
or I have deployed this code live to staging

Feedback I'm looking for:
UI feedback, any cleanup we want to do, does this breakdown of steps make sense, anything else that we could do to make this error-protective and keep users on the right path.
Things left to do before deploying:

[ ] ...

Yeah, I imagine computeMessagesToCreate will be refactored as part of implementing https://github.com/usdigitalresponse/neighbor-express/issues/122 :) My idea would be to break it down so it loops over message types, and queries for deliveries in the relevant status for that message type (where now it loops over deliveries, and then over message types in the inner loop). But yeah, not going to do that in this PR.

(manually released the block to staging, walnut creek and paterson)


Chore (prisma) : Bumped the version of prisma

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution @rnbokade, unfortunately just bumping the Prisma version will noe be enough as a lot of the tests will have breaking changes. However, I am already working behind the scenes on this, and will update everything to the latest Prisma version, including all the fixes, in the next 2-3 weeks :) Will close your PR for now, hope that's fine!

will soon upgrade via #842


Split admin functions into AdminClient

Currently, all api calls are wrapped inside a single client but considering the very large number of potential api calls it seems like it might be wise as the client grows to split the admin methods into their own client so there is better separation of concerns.  If others think this is a good idea it's something I would be willing to implement.

I'd say that's probably fine, i.e. all things being equal it's probably a good way of breaking up the functionality.
It would either be a big breaking change or require some deprecation warnings through the old (and still functional) methods on the 'primary' client.


[CP] Update Flutter Fix Log on How to Update Kotlin Gradle Plugin

Issue Link
https://github.com/flutter/flutter/issues/144454
Target
stable
PR Link
https://github.com/flutter/flutter/pull/145936
Changelog Description
Update Flutter Fix log on how to update Kotlin Gradle Plugin that was introduced in Flutter 3.19.x
Impacted Users
All Flutter devs
Impact Description
Users no longer need to figure out by themselves on how to update their Kotlin Gradle plugin when needed
Workaround
Reading the breaking change document here https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply. Or ask for a support in Discord or Stackoverflow.
Risk
low
Test Coverage
yes
Validation Steps
No response

@brainwo while I understand that this may bring a bit of confusion, I do not see this as a regression or severe bug needing to be hotfixed into a release.
With cherry-picks, we do our best to ensure that issues meeting the criteria are addressed swiftly, however, cherry-pick requests that do not follow the cherry-pick guide may slip by triage.  Please ensure that the PR link is updated with the cherry-pick pull request.
CC: @zanderso @christopherfujino

My bad, I skipped that part of the guide.
I have now updated the link with the cherry-pick pull request.

https://github.com/flutter/flutter/pull/149881 merged


hi,I have the same issue.How to solve it?

Do you want to request a feature or report a bug?

What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.

@feiyang0117 please recreate issue if problem still exists. Thanks!

ok


chore(ESLint v9 Fixes)

This PR fixes the new warnings reported with the upgrade to v9. It additionally enables some more eslint rules and fixes the errors associated with them.

fix eslint warnings pt 1
fix eslint warnings pt 2, enable more eslint rules

Closing in favor of completing the work under this ticket


Shopify-CLI: "shopify login" command not working

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Theme
Expected behavior
This app was in working condition. But now, after i upgrade my shopify cli to the recent version, i was unable to run the app in my local, which says error as below
[push] ╭─ error ──────────────────────────────────────────────────────────────────────╮
[push] │                                                                              │
[push] │  Failed to prompt:                                                           │
[push] │                                                                              │
[push] │  Command login not found. Did you mean auth logout?                          │
[push] │                                                                              │
[push] │  This usually happens when running a command non-interactively, for example  │
[push] │   in a CI environment, or when piping input from another process.            │
[push] │                                                                              │
[push] │  To resolve this, specify the option in the command, or run the command in   │
[push] │  an interactive environment such as your local terminal.                     │
[push] │                                                                              │
When i looked through the doc, i saw that shopify login command was removed. Need to use

shopify theme dev --store "shop.myshopify.com"

as a command to login to store.
Here is my code am using in Shopify.js within my theme repo, please let me know the exact structure or format to update the command in this file
await shopify({
command: "login",
env: {
SHOPIFY_SHOP: process.env.PERMANENT_DOMAIN,
SHOPIFY_PASSWORD: process.env.PASSWORD,
}
});
Actual behavior
unable to run my theme in local with npm run dev.
Verbose output
NA

Reproduction steps

3.NA
Operating System
mac OS
Shopify CLI version (check your project's package.json if you're not sure)
3.57.0
Shell
No response
Node version (run node -v if you're not sure)
v16.20.2
What language and version are you using in your application?
No response

Hi @Sowmiya-Arunachalakumar , do you mean that shopify theme dev --store "shop.myshopify.com" didn't work for you?


Setup database_consistency checker

https://github.com/djezzzl/database_consistency is a gem which allows static checking of potential mismatch in database schema and database models.

@tachyons I have gone through the readme of database_consistency checker and was able to set it up on local-setup, please assign me this issue, so that i can make a pull request.

@SimardeepSingh1450 Sure

@tachyons created a pr at #3785 , also to run this checker there is a command which is needed to execute, can you tell me where to place that instruction ?


Paper link is broken

Hi,
I want to access the paper mentioned on this repository, but it seems the link is broken.
Regards

The link is good to me. This is the paper title: Xie, Jinyu, and Qian Wang. "Benchmark Machine Learning Approaches with Classical Time Series Approaches on the Blood Glucose Level Prediction Challenge." KHD@ IJCAI. 2018. This is the link http://ceur-ws.org/Vol-2148/paper16.pdf If you still cannot get access to the paper, I will send you a pdf. Thanks.


WinUI 3 new project templates have incorrect comment about OnLaunched

Changing comments in the OnLaunched method for Desktop applications. These comments held true for UWP but OnLaunched always gets called.

@ShashankNay, any idea why there's a diff on every line 1? Do you have nonstandard line terminators set in your editor and/or git config?

I'm not sure, my git config has autocrlf = true and things look okay in VS.

/azp run


Separating the frontend storefront calls to use the new endpoints

to run locally:
make sure you checkout the master backend branch
make sure you pull the latest into the master backend branch
make dev on backend if needed
make reindex_es on backend if needed
checkout this frontend branch
to test:
open developer tools, the network tab
Make sure that when storefront loads there are no references to
http://<IP_ADDRESS>:8001/api/storefront/
and instead are references to the following endpoints
http://<IP_ADDRESS>:8001/api/storefront/featured
http://<IP_ADDRESS>:8001/api/storefront/recent
http://<IP_ADDRESS>:8001/api/storefront/most_popular
http://<IP_ADDRESS>:8001/api/storefront/recommended
Ensure that recommended recomendations still only appear for the beta users (eg. bettafish)
Ensure that store front, search, and clicking on apps still function

Two things I'm noticing:
The important one

I'm not getting the images for Recommended For You.  The image is available in the API call, but it's not in the  tag

The weird thing I see (that doesn't seem to affect performance however):

/api/metadata takes less than 1 second to load before pulling this branch
It's taking 3 seconds after pulling the branch.

Otherwise, I <3 that visually this is definitely faster. Pre-fetch times were 5-10s, post-fetch are 4 or less before something is on the screen.

:+1:    It looks likes it works.

The /metadata call is still confusing, but it could be tied to data throughput since there are now ~10 calls made simultaneous vs 7.
Code looks good.
Calls are broken up into small result sets.
Search functions as expected.
All images load.
:+1:


Loading Template into Composer stalls

When you load a template into composer in 2.14.3 the status bar indicates that it is working on loading the new template but could go on for hours and it does nothing until you cancel the task. Once you cancel the task the new template has loaded but parts of the template are missing.

@AgAssist please report this in the issue tracker (hub.qgis.org) or ask for help in one of qgis support channels.
This repository is dedicated to QGIS Website issues.


Transfers: reliably send transfers from consumer to provider

What this PR changes/adds
If the Consumer tries to initiate a transfer but the Provider is not available, the consumer does not manage the error. If the Provider later becomes available, the request did not get processed. This PR solves this issue.
If the request is unsuccessful, we keep the entity in the same state (with a state update, to increment its internal state count) and save it to break the lease and send the TP again potentially on the next iteration.
This "long retry" mechanism implements an exponential wait mechanism so as not to overflow the provider when it becomes available again. There might be many consumers queuing up requests to one provider.
After a given number of retries is exhausted, the transfer state moves to ERROR.
An additional "short retry" mechanism could also be implemented later in the IdsMultipartSender side, as a complement to this mechanism. The low level retry should be very short so as not to hog consumer resources and hammer the provider.
Why it does that
Reliable delivery
Further notes
Linked Issue(s)
Closes #336
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] added relevant details to the changelog? (skip with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #1007 (c5d7909) into main (705a447) will decrease coverage by 0.10%.
The diff coverage is 79.31%.

@@             Coverage Diff              @@
##               main    #1007      +/-   ##
============================================
- Coverage     63.09%   62.99%   -0.11%
- Complexity     2551     2556       +5
============================================
  Files           633      635       +2
  Lines         13679    13745      +66
  Branches        953      958       +5
============================================
+ Hits           8631     8658      +27
- Misses         4606     4647      +41
+ Partials        442      440       -2

Impacted Files
Coverage Δ

...connector/transfer/core/CoreTransferExtension.java
0.00% <0.00%> (ø)

...fer/store/memory/InMemoryTransferProcessStore.java
96.15% <ø> (-0.08%)
:arrow_down:

...pse/dataspaceconnector/spi/retry/WaitStrategy.java
0.00% <0.00%> (ø)

...ceconnector/spi/retry/ExponentialWaitStrategy.java
75.00% <83.33%> (-15.91%)
:arrow_down:

...sfer/core/transfer/TransferProcessManagerImpl.java
75.77% <83.67%> (+2.41%)
:arrow_up:

...nector/metrics/micrometer/MicrometerExtension.java
0.00% <0.00%> (ø)

.../micrometer/MicrometerExecutorInstrumentation.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705a447...c5d7909. Read the comment docs.

@algattik Pls resolve the conflicts, I can merge afterwards

@juliapampus I've resolved the conflicts, thanks in advance :)


How to collect or cancel a reserved payment?

I have been struggling with this for an embarrassingly long time. Once I use a single use pipeline to reserve a payment, what do I do to get a URL to collect or to cancel that reserved payment?

I am not sure I completely follow what you mean.  However, in the system I worked on we reserved payments with the single use pipeline, and Amazon would send the results back to a URL we specified in our Amazon FPS settings (on the Amazon website).
Setting up Amazon FPS is EXTREMELY frustrating, and it is a terrible system. :/  Amazon's developer forums are pretty good though, and are monitored by actual Amazon FPS devs.
As to cancelling (prior to payment), I have no idea if this is even possible.  Refunding is possible.

Thanks for taking the time to reply, Peter. I am able to reserve the
payment just fine -- it is when it is time to settle/collect that
payment that I am trying to figure out.
On Tue, Nov 29, 2011 at 3:54 PM, Peter Boling
<EMAIL_ADDRESS>wrote:

I am not sure I completely follow what you mean.  However, in the system I worked on we reserved payments with the single use pipeline, and Amazon would send the results back to a URL we specified in our Amazon FPS settings (on the Amazon website).
Setting up Amazon FPS is EXTREMELY frustrating, and it is a terrible system. :/  Amazon's developer forums are pretty good though, and are monitored by actual Amazon FPS devs.
As to cancelling (prior to payment), I have no idea if this is even possible.  Refunding is possible.

Reply to this email directly or view it on GitHub:
https://github.com/tylerhunt/remit/issues/14#issuecomment-2947740

I must not have used remit in the way you are attempting to.  If Amazon has a 'reserve' payment that is never collected until you send a request to collect it I am unaware of it.  But that doesn't mean it isn't there.  The API is enormous, and I only used Remit for one tiny slice of it which included payments which were automatically charged by Amazon, with no (little) waiting.  There may be other remit users who have experience with this.  I'll leave this issue open.  Please report back if you gain any insight on the Amazon dev forums.

@mikepence, have you tried calling settle?
Pass in the reserve_transaction_id you got back from Amazon when you called reserve.  And pass in all of the other transaction details you passed to Amazon in reserve.
settle_request = Remit::Settle::Request.new(:reserve_transaction_id => reserve_transactionID,...)
@remit_api.settle(settle_request)

I am setting up a single use pipeline with :reserve => true, and what I get back includes a tokenID, but no reserve_transaction_id. Maybe I need to be doing it differently...

You need to take that token from the pipeline and use it to call Settle.  The pipeline only authorizes the transaction from the user.  You still need to tell the API to execute it.

Right, I think I have got it. After the pipeline returns a token, I have to call Reserve with that token, then, subsequently call Settle. The docs are plentiful, but very obtuse.

What is odd is that doing a pipeline call with reserve=true has no apparent effect.


[Snyk] Upgrade @hashgraph/hedera-local from 2.12.0 to 2.12.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @hashgraph/hedera-local from 2.12.0 to 2.12.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 21 days ago, on 2023-08-09.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
Patch coverage has no change and project coverage change: +0.75% :tada:

Comparison is base (7725f13) 76.94% compared to head (4fc075c) 77.70%.

:exclamation: Current head 4fc075c differs from pull request most recent head 532b107. Consider uploading reports for the commit 532b107 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
+ Coverage   76.94%   77.70%   +0.75%
==========================================
  Files          39       26      -13
  Lines        2859     2274     -585
  Branches      575      464     -111
==========================================
- Hits         2200     1767     -433
+ Misses        479      363     -116
+ Partials      180      144      -36

see 14 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@ebadiere looks like a bad merge. Please rebase to simplify the changes


[release/0.11 backport] [ci] Fix integration test failure

backport of https://github.com/microsoft/hcsshim/pull/1799

(cherry picked from commit f5c5797f78896320e92d76dede481b540da3d4cf)

hopefully fixes the failures on https://github.com/microsoft/hcsshim/pull/1900

@helsaawy @kevpar looks like CI needs approval first 😅

One failure on Window-2022; I guess not related to this PR, is that a known flaky test?
=== Failed
=== FAIL: internal/exec TestExecStdinPowershell (10.00s)
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Install the latest PowerShell for new features and improvements! https://aka.ms/PSWindows

PS D:\a\hcsshim\hcsshim\internal\exec> ping <IP_ADDRESS>

Pinging <IP_ADDRESS> with 32 bytes of data:
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128

Ping statistics for <IP_ADDRESS>:
    Packets: Sent = 4, Received = 4, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 0ms, Maximum = 0ms, Average = 0ms
PS D:\a\hcsshim\hcsshim\internal\exec> exit
    exec_test.go:123: timed out waiting for process to complete

And build failures in one part, because it looks like it depends on a version of containerd that requires go1.21;
go build  -gcflags=-trimpath=D/src  -o bin/ctr.exe -ldflags '-X github.com/containerd/containerd/version.Version=82df7d5 -X github.com/containerd/containerd/version.Revision=82df7d52086e1e39d7b56819d89ea75eab5eb9fd -X github.com/containerd/containerd/version.Package=github.com/containerd/containerd -s -w ' -tags "urfave_cli_no_docs"  ./cmd/ctr
+ bin/containerd.exe
go build  -gcflags=-trimpath=D/src  -o bin/containerd.exe -ldflags '-X github.com/containerd/containerd/version.Version=82df7d5 -X github.com/containerd/containerd/version.Revision=82df7d52086e1e39d7b56819d89ea75eab5eb9fd -X github.com/containerd/containerd/version.Package=github.com/containerd/containerd -s -w ' -tags "urfave_cli_no_docs"  ./cmd/containerd
# github.com/containerd/containerd/pkg/cri/sbserver/podsandbox
Error: pkg\cri\sbserver\podsandbox\sandbox_run.go:63:20: undefined: errors.Join
note: module requires Go 1.20
# github.com/containerd/containerd/runtime/v2
Error: runtime\v2\shim.go:383:16: undefined: errors.Join
note: module requires Go 1.20
# github.com/containerd/containerd/plugins/streaming
Error: plugins\streaming\manager.go:265:16: undefined: errors.Join
note: module requires Go 1.20
# github.com/containerd/containerd/snapshots/storage
Error: snapshots\storage\metastore.go:141:19: undefined: errors.Join
note: module requires Go 1.20
# github.com/containerd/containerd/pkg/cri/server
Error: pkg\cri\server\sandbox_stats_list.go:51:33: undefined: errors.Join
note: module requires Go 1.20
mingw32-make: *** [Makefile.windows:32: bin/containerd.exe] Error 1
Error: Process completed with exit code 2.

Looks like I probably needed https://github.com/microsoft/hcsshim/pull/1752 which looks to be in the v0.12 and v0.10 branches, but not in v0.11

Cherry-picked that one; some minor conflicts in go.mod due to https://github.com/helsaawy/hcsshim/commit/478b6da9f5f5a579c2815e32ca1729be5a346f40 not being in this branch, but I didn't want to risk adding newer dependencies, so instead, I re-ran go mod tidy and go mod vendor)

And.. 🙈 now Ci  needs approval again 😅

https://github.com/microsoft/hcsshim/pull/1881 this PR should take care of fixing all the test failures

DOH! I didn't see that one (or I didn't play close attention). 🙈

DOH! I didn't see that one (or I didn't play close attention). 🙈

Ah no I had drafted it to check status of tests before un-drafting but couldn't get to it last week.

Let me close this one in favour of https://github.com/microsoft/hcsshim/pull/1881 (thanks!)


segfault when getting properties

This Neon function reliably segfaults on both OS X and Linux:
fn test(call: Call) -> JsResult<JsValue> {
    let scope = call.scope;
    let arg = try!(call.arguments.require(scope, 0));
    let obj = try!(arg.check::<JsObject>());
    let foo = try!(obj.get(scope, "foo"));
    let obj = try!(foo.check::<JsObject>());
    obj.get(scope, 0)
}

when called with an object such as { foo: ["bar"] }.
Reported on Slack by @msvbg -- thank you Martin!

Thanks! A+ effort :)


⚠ Bofrost.lu has degraded performance

In 87b579c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 812 ms

Resolved: Bofrost.lu performance has improved in 8cd21ba.


router-view 能否将matchedRoute暴露出来？

What problem does this feature solve?
在嵌套路由中，我需要在自定义插槽中获取当前RouterView匹配到的路由节点配置信息，如果不能暴露出matchedRoute，请问我该如何获取？
What does the proposed API look like?
<router-view v-slot="{ Component, route, matchedRoute }">   <custom :component="Component"  :route="matchedRoute"/> </router-view>

matchedRoute shouldn't be necessary in userland. If you think this is worth adding, please open an RFC in the vuejs/rfcs repo. Note you can manually get it with the route.matched array.


Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

❯ truffle unbox pet-shop                                                                                ─╯
✔ Preparing to download
✔ Downloading
✔ Cleaning up temporary files
⠋ Setting up boxnode-pre-gyp WARN Tried to download(404): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.4/fse-v1.2.4-node-v79-darwin-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v79 ABI, unknown) (falling back to source compile with node-gyp)
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:221:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:22:1: error: no viable conversion from 'Localv8::Context' to 'v8::Isolate '
X(Boolean)
^~~~~~~~~~
../../nan/nan_converters_43_inl.h:18:23: note: expanded from macro 'X'
val->To ## TYPE(isolate->GetCurrentContext())
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/cibn/Library/Caches/node-gyp/13.1.0/include/node/v8.h:2639:37: note: passing argument to parameter 'isolate' here
Local ToBoolean(Isolate isolate) const;

duplicate of #291


KAFKA-14499: [4/N] Implement OffsetFetch API

This patch implements the OffsetFetch API in the new group coordinator.
I found out that implementing the RequireStable flag is hard (to not say impossible) in the current model. For the context, the flag is here to ensure that an OffsetRequest request does not return stale offsets if there are pending offsets to be committed. In the scala code, we basically check the pending offsets data structure and if they are any pending offsets, we return the UNSTABLE_OFFSET_COMMIT error. This tells the consumer to retry.
In our new model, we don't have the pending offsets data structure. Instead, we use a timeline data structure to handle all the pending/uncommitted changes. Because of this we don't know whether offsets are pending for a particular group. Instead of doing this, I propose to not return the UNSTABLE_OFFSET_COMMIT error anymore. Instead, when RequireStable is set, we use a write operation to ensure that we read the latest offsets. If they are uncommitted offsets, the write operation ensures that the response is only return when they are committed. This gives a similar behaviour in the end.
Note that this PR does not adds the MemberId and MemberEpoch fields to the request. This will be done in the next PR.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@jolshan Thanks for your review. I have addressed your comments.

@dajac can you answer this real quick? Otherwise lg https://github.com/apache/kafka/pull/14120#discussion_r1302269425


Update husky to version 7

Type of issue
Request to update husky
The issue refers to the:

nitro-generator
example nitro projects

Infos
https://typicode.github.io/husky/#/?id=migrate-from-v4-to-v7
https://github.com/typicode/husky-4-to-7
Needs project config change

The hard part will be - how to uninstall husky githooks from version 4 on updating a project

On updating projects with husky 4 an node 16/npm 8

It could be necessary to run git config --unset core.hooksPath
but easier is to run npm uninstall husky before installing updated projects ;-)


Switch to using the procfs crate

We should use procfs instead of reading and parsing procfs ourselves. This will probably be a breaking change since the errors will probably change.

Added procfs to the related projects in the README (https://github.com/rust-psutil/rust-psutil/pull/118).


Can't make a ChatEventDataProcessor targetting multiple EventTypes

So I wanted to create my own processor that reacts to MessagePosted and MessageEdited, so I put this at the top:
public override EventType Event { get; } = EventType.MessagePosted | EventType.MessageEdited;
After like half an hour debugging, I realize those aren't actually flags.
Can we make them flags, so they are combinable? Or is the plan like "add the existing processor classes and subscribe to the events you want to process"?

I'd make it flags, make the "AllEvents" int.MaxValue, and then in the router just ask (event_type & Event)

I had originally designed the system to have one event per processor, hence the lack of flags support. However you raise a good point, I think this would be a good addition to the event system. I'll aim to start working on this some time next week, the event system was due an update anyway I guess.

I was unable to make the EventType enumeration support flags, so we're just going to have to put up with using an array of EventTypes instead. Besides that minor issue, everything else has been implemented as requested.


Schematics program

What program was used to create the schematics ("hardware/elektrosluch.brd" and "hardware/elektrosluch.sch")? EAGLE? What version of the program?
Can you indicate it in the files here? E.g. some file with meta content, like "hardware/ReadMe".

Hello,
not many people have asked about this yet. Yeah, it is Eagle, version 6.5.
I will update the info when I find some time!
Regards,
Jonas

I was not able to view the BRD or SCH in EAGLE 7.5.0 Light.
Error:
line 6, column 56: This is not an EAGLE file.
Is it EAGLE free version or full version?

As I said, it is made in Eagle 6.5. That is probably the reason it won't open in Eagle 7.5.0
It should open in free version without a problem.
Regards,
Joans


fix (iOS): refresh control not behaving correctly if it is offscreen

FIXES https://github.com/facebook/react-native/issues/45858
Summary:
When working with UIRefreshControl in a custom React Native component, we encountered a problem where the refresh control did not behave correctly if it was offscreen. Specifically, attempts to programmatically begin or end refreshing were ignored if the control was not visible. This typically manifested as the refresh control not updating its state properly when it was re-rendered or moved in the view hierarchy.
Happening only on old-arch.
Problem Details
Offscreen Refresh Control Ignored: The UIRefreshControl would ignore calls to beginRefreshing and endRefreshing if it was not currently visible on the screen.
Inconsistent State: The internal state _currentRefreshingState might not match the actual state of the UIRefreshControl, leading to unexpected behavior.
Steps to Fix
Track Visibility with didMoveToWindow:
Implement the didMoveToWindow method to track when the refresh control is added to or removed from the window.
Use a flag _hasMovedToWindow to keep track of this state.
And check this flag should be true whenever we start or end refreshing
Changelog:
[IOS] [FIXED] - Fixed an issue where the refresh control would not behave correctly if it was offscreen.
Test Plan:
Issue Screen recording
https://github.com/user-attachments/assets/73b45c27-19c2-4eeb-991e-33b45f0a6d97
Fix Screen Recording :
https://github.com/user-attachments/assets/ffc6b6e6-fc68-498c-abdf-3144c31caa86

@cortinico Please have a look.

@cipolleschi @cortinico Can this be prioritised

This is a fix for the old architecture only and we are focusing on the New Architecture, so we can't prioritise this.
As first step, please check whether the issue is present also in the New Architecture. If that's the case, could you please fix it also in the New Architecture? At that point we might be able to import it and land it.

This is a fix for the old architecture only and we are focusing on the New Architecture, so we can't prioritise this.
As first step, please check whether the issue is present also in the New Architecture. If that's the case, could you please fix it also in the New Architecture? At that point we might be able to import it and land it.

This is is old arch-specific not reproducible on new arch


Small edits to /etc/config.sample.toml

Bug report
System info:  InfluxDB v1.2.2
Three issues:

[coordinator]

# The maximum number of series a SELECT can run.  A value of 0 will make the maximum series
# count unlimited.

Next line should be:
#max-select-series = 0

[http]

# Determines whether HTTP authentication is enabled.
# auth-enabled = false

This is a little confusing as the setting applies equally to situations where HTTPS is enabled, so I would propose "HTTP/HTTPS" to avoid confusion. Otherwise it really does look like you're saying "auth only with http... but what about https?")

[http]

# Determines whether HTTP request logging is enable.d
# log-enabled = true

should read:
# Determines whether HTTP request logging is enabled.
# log-enabled = true

I'm a bit confused by #1. I see this in the current file:
  # The maximum number of series a SELECT can run. A value of zero will make the maximum series
  # count unlimited.
  # max-select-series = 0

What's wrong with that? The only difference I see is the lack of a space between # and max-select-series.

Also, for the second, should we not make a reference to HTTP? It makes it sound like the authentication has something to do with HTTP rather than it being authentication used over HTTP. Maybe it should read: Determines whether user authentication is enabled over HTTP/HTTPS.

agreed..  it should read ...enabled over HTTP/HTTPS.

Never mind on the first. I think I found the issue:
  # The maximum number of series a SELECT can run.  A value of 0 will make the maximum series
  # count unlimited.

  # The maximum number of series a SELECT can run. A value of zero will make the maximum series
  # count unlimited.
  # max-select-series = 0

👍


Save WinSetView.ps1 parameters to a file

(Feature request.)  Create a file containing the parameters to WinSetView.ps1.  This would allow WinSetView.ps1 to be run on another device, without user intervention, from a batch file.  E.g.:
  rem Use https://github.com/LesFerch/WinSetView to generate parameters for their PowerShell script
  rem WinSetViewParams.txt and WinSetView.ps1 reside in the folder "%USERPROFILE%\scripts\".
  set /p params=<"%USERPROFILE%\scripts\WinSetViewParams.txt"
  Powershell.exe -ExecutionPolicy Bypass "%USERPROFILE%\scripts\WinSetView.ps1" %params%

I've tested the following modification to WinSetView.hta; it creates a parameter file %APPDATA%\WinSetView\WinSetViewParams.txt:
Sub RunScript
  CmdLine = "Powershell.exe -ExecutionPolicy Bypass " & Chr(34) & MyPath & "WinSetView.ps1" & Chr(34) & " " & Params
  Dim CmdFile
  set CmdFile = oFSO.CreateTextFile(AppData & "\WinSetViewParams.txt")
  CmdFile.Write Params
  CmdFile.Close()
  oShell.Run CmdLine,Visible,False
  Window.Close
End Sub

Great idea and thanks for the code! I'll add that into the next update.

Thanks for writing this awesome project!  --Joe
On Wed, Apr 21, 2021, 1:38 PM LesFerch @.***> wrote:

Great idea and thanks for the code! I'll add that into the next update.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/LesFerch/WinSetView/issues/11#issuecomment-824238059,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAHOFA3FJISYAIZKLL6353TJ4EQHANCNFSM43KQG6KA
.

@LesFerch
Kudos to @jglandorf
I added to hta (changed CmdFile to ParamFile for clarity)
Dim Count, Pick, Language, oOption, LangCount, LangLast, TaggedHTML, LangIndex, SubMode, ParamFile

added  here the last extra line
'Set up paths
If Not oFSO.FolderExists(AppData) Then oFSO.CreateFolder(AppData)
CSVFile = AppData & "\WinSetView.csv"
ParamFile = AppData & "\WinSetViewParams.txt"

also modified this block to reflect the "prior art" but dont know how correct that cut and paste is
Sub RunScript
  CmdLine = "Powershell.exe -ExecutionPolicy Bypass -File " & Chr(34) & MyPath & "WinSetView.ps1" & Chr(34) & " " & Params
  oStream.Open
  oStream.WriteText Params
  oStream.SaveToFile ParamFile,2
  oStream.Close
  oShell.Run CmdLine,Visible,False
  Window.Close
End Sub

Anyway AFAIK my portable usage works ok

Unattended.cmd

set appdata=%~dp0
set appdata=%appdata:~0,-1%
Powershell.exe -ExecutionPolicy Bypass -File "%~dp0WinSetView.ps1" "%~dp0WinSetView\WinSetViewParams.txt"
explorer "%appdata%"

That "-File" parameter breaks the command line. The Params don't get passed. I went with suggestion from @SumatraPeter and replaced MyPath with ".". Fixes the problem of running from a folder with a space in the same and still passes the params.

This feature has now been rolled into the code in the Main branch. Please test and let me know if it's OK.

Nicely implemented
However an unknowing user could pull the trigger prematurely by running command before hta
also at end of run we are faced with NO folders not even the starting work dir
so can I suggest a mod to top and tail

WinSetView.cmd

@Echo Off

if not exist ".\AppData\WinSetViewParams.txt" echo Usage:- ^
Run WinSetView.hta to create or update WinSetViewParams.txt & pause & exit

Set /p Params=<".\AppData\WinSetViewParams.txt"
Powershell.exe -ExecutionPolicy Bypass .\WinSetView.ps1 %Params%
explorer %~dp0

Excellent! I removed explorer %~dp0 and instead added Explorer $PSScriptRoot to WinSetView.ps1. That way, the behavior is consistent regardless of how it's launched.

Great but the aim her is to use a previous set of user saved params easily
I find if they are in a subfolder thats not easy to drag and drop

It is easier if the Params.txt is saved in the main folder (it is just that one file, rest can stay in the app data)
With the suggestion to keep last run by that name (allows for double click - same as before)
HOWEVER can also rename a copy to say LesPreferedParams.txt (then can drag and drop as per following)

@Echo Off

if not exist ".\WinSetViewParams.txt" echo Usage:- ^
Run WinSetView.hta to create or update WinSetViewParams.txt & pause & exit

Set /p Params=<".\WinSetViewParams.txt"
if exist ".\%~n1.txt" Set /p Params=<".\%~n1.txt"

Powershell.exe -ExecutionPolicy Bypass .\WinSetView.ps1 %Params%

Thanks. I like putting the above CMD in the AppData folder. Main branch updated accordingly.

Seems good enough to me
So guessing this is closed and version can be released as 1.3.1 / 1.4 ?

I'm considering doing it as a 1.31 or 1.32 release. But, I'm working on
custom settings for search results, which will be a 1.40 release. I may
hold off until that's ready, since that should be anywhere from 1-5 days
away.
On Fri, Apr 23, 2021 at 1:08 PM GitHubRulesOK @.***>
wrote:

Seems good enough to me
So guessing this is closed and version can be released as 1.3.1 / 1.4 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/LesFerch/WinSetView/issues/11#issuecomment-825795808,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS25QO7PDCRZFUY5MLZORE3TKGSSHANCNFSM43KQG6KA
.

anywhere from 1-5 days

yes looking at output from
https://github.com/microsoft/Windows-classic-samples/blob/master/Samples/Win7Samples/winui/WindowsSearch/WSFromScript/QueryEverything.vbs
that generates thousands of lines to filter

I encountered the same issue running cscript across network as I did here
You may need to note that whilst hta can be run from \server\folder the reason I said use mapped drive z:
is that hta will not see the support language files nor will ps1 save the settings in such a \URL location

Yes. I just tried it running from a drive I have attached to my router with
a share of \<IP_ADDRESS>\Videos. No mapped drive. I see the same issue.
The reg backup saved, so Reg.exe was okay with it, but Languages not read
and settings not saved. How to detect? Just look for a drive letter in the
path?
On Fri, Apr 23, 2021 at 2:01 PM GitHubRulesOK @.***>
wrote:

I encountered the same issue running cscript across network as I did here
You may need to note that whilst hta can be run from \server\folder the
reason I said use mapped drive z:
is that hta will not see the support language files nor will ps1 save the
settings in such a \URL location
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/LesFerch/WinSetView/issues/11#issuecomment-825826194,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS25QO7C5KRWSYT6X5JIDMLTKGYX5ANCNFSM43KQG6KA
.

somewhere (not very helpful)
I thought I saw that PS can auto allocate \server\name by translating to first free drive from z: down
but cant remember where

WRONG THREAD Asit was raised in "portable use" but related here one reason CMD drops back to a windows dir
'\\ADVENT\Share\WinSet View'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported.  Defaulting to Windows directory.
Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.

C:\Windows>

It looks like WinSetView.ps1 is fine with the UNC path. WinSetView.hta
needed a little fix. It now uses "." which is working for me on UNC paths
and mapped drives. Now the CMD script is another matter. No sure what can
be done about that.
On Fri, Apr 23, 2021 at 3:09 PM GitHubRulesOK @.***>
wrote:

WRONG THREAD Asit was raised in "portable use" but related here one reason
CMD drops back to a windows dir
'\ADVENT\Share\WinSet View'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported.  Defaulting to Windows directory.
Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.
C:\Windows>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/LesFerch/WinSetView/issues/11#issuecomment-825863105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS25QOZVL7HEC6M4H5MPDNDTKHAWVANCNFSM43KQG6KA
.

Maybe replace the CMD with an HTA.
On Fri, Apr 23, 2021 at 3:35 PM Les Ferch @.***> wrote:

It looks like WinSetView.ps1 is fine with the UNC path. WinSetView.hta
needed a little fix. It now uses "." which is working for me on UNC paths
and mapped drives. Now the CMD script is another matter. No sure what can
be done about that.
On Fri, Apr 23, 2021 at 3:09 PM GitHubRulesOK @.***>
wrote:

WRONG THREAD Asit was raised in "portable use" but related here one
reason CMD drops back to a windows dir
'\ADVENT\Share\WinSet View'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported.  Defaulting to Windows directory.
Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.
C:\Windows>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/LesFerch/WinSetView/issues/11#issuecomment-825863105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS25QOZVL7HEC6M4H5MPDNDTKHAWVANCNFSM43KQG6KA
.

WinSetView.vbs replaces WinSetView.cmd for GUI-less execution. It works on UNC paths. That is, you can RUN the script from a UNC path. The Explorer view for a UNC path will NOT get any new view set with WinSetView. It has to be drive letter mapped to get the same views as local drives.

Great cant test just now as running an errand
I had replaced the cmd with a number of %~dps and copy to %temp% as before
but the user would need to ignore the UNC error message so not very silent

Testing against uncommon usage such as UNC path with a space
suggests all is well
just beware some user may yet complain it does not work from their Klingon named cloud gogglebox account on a mac server in the outer galaxy

WinSetView v2 uses an INI file to pass all parameters.


[FEAT]: Iframe chatbot embedding customizations

What would you like to see?
Ability to customize the appearance of the iframe to be placed in a website.
So colors, fonts, logo, etc.

The embed chat widget has these options - seen here:
https://github.com/Mintplex-Labs/anything-llm/blob/master/embed/README.md#script-customization-options
Iframe (window in website) is TBD
https://github.com/Mintplex-Labs/anything-llm/issues/676


fix_auth: use random when fixing secret_token(s)

fix_auth is the tool users use when they lose a v2_key.
After losing a v2_key, the passwords can't be retrieved and are thus invalid.
The option of --invalid bogus resets these passwords to a known value.
The user can then go into the ui and correct.
The MiqDatabase table is an exception here. session_secret_token and csrf_secret_token do not contain provider passwords but rather random strings. So the invalid option works a little differently for this table. If you specify invalid, it will populate with a random string and not the bogus value provided by the user.
Unfortunately #962 introduces a bug where session_secret_token and csrf_secret_token are populated with bogus value.
This PR fixes that code and adds specs to prevent another regression.
/cc @jrafanie @abellotti
UPDATED: reworded. thanks @abellotti
UPDATED: The bug luckily was found before going out with 5.3 or 5.4

Minor nit:  commit message:
..Unfortunately it had a regressing with MiqDatabase and the hardcode...
Should be:
..Unfortunately it had a regression with MiqDatabase and the hardcode...

@jrafanie good question:
AuthModel#hardcode was removed. Which looks simple enough.
MiqDatabase#hardcode overrides AuthModel#hardcode here. So removing that extension point means we no longer are calling into the overridden hardcode and not calling the correct logic.
My first fix overrode all of AuthModel#recrypt in MiqDatabase, but as you can see here, all that was needed was to reintroduce the hardcode method/extension point.

Thanks @kbrock, I was :confused: but now I get it and the change looks good.

Thanks @jrafanie Was surprised that you didn't see the fix right away. Since it was basically spurred by something you had said while looking at it.
Appreciate the: "So what. You extracted a method. How does that fix anything?"
It makes me feel better because I had though the same when I removed that method and introduced the bug. :)

Yeah, if it's not obvious, it's usually worthwhile asking.  :smiley_cat:


Mismatch token timestamp web client and php server cause exception

I am using version 3.5 of the library. The issue is that the timestamp on the client with firebase web and the timestamp on the php server is mismatched and that causes an exception to be thrown when validating token in php. See details below:
On the client i get the token with:
fbase_auth.currentUser.getIdToken(true)
  .then((token) => {
        // return token
});

On the php server i run this code:
public function getUserFromTokenId($idTokenString) {
   $idToken = $this->auth->verifyIdToken($idTokenString);
   $uid = $idToken->getClaim('sub');
   return $this->auth->getUser($uid);
}

With the $idTokenString sent in from the client.
When running verifyIssuedAt in IdTokenVerifier class i get the error message:
"This token has been issued in the future."
The problem is that inside that code you have:
private function verifyIssuedAt(Token $token)   {
    if (!$token->hasClaim('iat'))  {
        throw new InvalidIdToken('The claim "iat" is missing.');
     }

     if ($token->getClaim('iat') > time())  {  // this fails..
        throw new InvalidIdToken('This token has been issued in the future.');
   }
}

The problem is as mentioned that the token from the client is in the future compared to the timestamp on the server. The test i ran the timestamp (from clock) on the server was 5 minutes slower then on client, so mismatch in timestamp caused it to not work (exception thrown)..

Hey @alexswe1! Thank you for your report - this seems to be the same issue as in #140 - if you agree, I'd like to close this issue and we can continue the discussion over there, where I already added a proposal to work around this issue: https://github.com/kreait/firebase-php/issues/140#issuecomment-350273278

Yes, same issue, although I reported it first.
On Fri Dec  8  9:18 , Jérôme Gamez<EMAIL_ADDRESS>sent:

Hey @alexswe1! Thank you for your report - this seems to be the same issue as in #140 - if you agree, I'd like to close this issue and we can continue the discussion over there, where I already added a proposal to work around this
issue: #140 (comment)
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kreait/firebase-php","title":"kreait/firebase-php","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-
b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kreait/firebase-php"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jeromegamez in #139: Hey @alexswe1! Thank you for your report - this seems to be
the same issue as in #140 - if you agree, I'd like to close this issue and we can continue the discussion over there, where I already added a proposal to work around this issue: https://github.com/kreait/firebase-
php/issues/140#issuecomment-350273278"}],"action":{"name":"View Issue","url":"https://github.com/kreait/firebase-php/issues/139#issuecomment-350273621"}}}

Continued in #140

4.9.0 (Documentation) should fix the issue for special use cases.


fix: align enable_overlap_scheduler naming between code and docs

Motivation
docs:

server_args:
...
[--disable-nan-detection] [--enable-overlap-schedule] [--enable-mixed-chunk]
...

launch_server.py: error: unrecognized arguments: --enable-overlap-scheduler

Modifications
Checklist

[x] Format your code according to the Contributor Guide.
[x] Add unit tests as outlined in the Contributor Guide.
[x] Update documentation as needed, including docstrings or example tutorials.

Good catch! Can you fix the doc instead of the code?

Good catch! Can you fix the doc instead of the code?

Sure. fix docs and test code indeed sounds more reasonable.


Fix the NPE occurred when using EnableApolloConfig with Spring 3.1.1

What's the purpose of this PR
Fix the NPE occurred when using EnableApolloConfig with Spring 3.1.1 in master branch
Which issue(s) this PR fixes:
Fixes #4178
Brief changelog

Disable namespace placeholder support for Spring version prior to 3.2.x and add necessary warn logs

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.
[x] Update the CHANGES log.

Codecov Report

Merging #4180 (6a23d8b) into master (7c6c535) will increase coverage by 0.00%.
The diff coverage is 11.11%.

@@            Coverage Diff            @@
##             master    #4180   +/-   ##
=========================================
  Coverage     52.57%   52.57%
- Complexity     2616     2620    +4
=========================================
  Files           484      484
  Lines         15192    15201    +9
  Branches       1571     1572    +1
=========================================
+ Hits           7987     7992    +5
- Misses         6646     6651    +5
+ Partials        559      558    -1

Impacted Files
Coverage Δ

...spring/spi/DefaultApolloConfigRegistrarHelper.java
74.19% <11.11%> (-25.81%)
:arrow_down:

...ervice/service/ReleaseMessageServiceWithCache.java
87.05% <0.00%> (+1.17%)
:arrow_up:

.../apollo/internals/RemoteConfigLongPollService.java
78.31% <0.00%> (+1.20%)
:arrow_up:

...nfigservice/filter/ClientAuthenticationFilter.java
93.61% <0.00%> (+2.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6c535...6a23d8b. Read the comment docs.


Add prometheus metrics for network probes

Create and update prometheus metrics for agents' network probes.

This change is

Review status: 0 of 4 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

pkg/utils/metrics.go, line 126 at r2 (raw file):

	)

	if gauge, ok := tryRegisterGaugeVec(am.ProbeConnectionResult); !ok {

lis it possible in golang to use some range and describe calling of this method only once (smth like):
for metric := range [am.ProbeCoonnectionResult, am.ProbeHTTPCode]  {
if gauge, ok:= tryRegisterGaugeVec(metric); !ok {
...
}
}

pkg/utils/metrics.go, line 146 at r2 (raw file):

		am.ProbeTCPConnection = gauge
	}
	if gauge, ok := tryRegisterGaugeVec(am.ProbeTCPConnection); !ok {

Duplication of above

Comments from Reviewable

Reviewed 1 of 3 files at r2, 2 of 4 files at r3, 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

Comments from Reviewable

Two minor comments: one from me and one from codeclimate.
Fixed


Latest tag with any prefix

Currently badge for latest GitHub tag does not support tags with prefix other than v. For projects with such custom prefix (https://github.com/mrdoob/three.js - "r" prefix, https://github.com/square/picasso - "picasso-parent-" prefix) we get "tag | none". This change solves this problem.

I appreciate these tests and the functionality change.
I'm not thrilled about these functions. The code is convoluted and difficult to follow. While I'd prefer it be rewritten, I'm fine with accepting a change as long as we're not making it worse.
Once you remove the v from the regex I will merge it.

So we should create a new issue for rewriting this latest(versions) function. I like you idea (thanks for it!) and we should check if this will handle all cases :-)

Sounds great. I'm down to help or give feedback if you'd like to take the lead. I think there is only one entry point (latest) so it's worth thinking about the clearest way to factor out the helper functions, and giving them their own tests if necessary.
By the way, I just discovered Sazerac which may be a nice way to queue up these tests in Mocha. Wouldn't hurt to use that for our data-driven tests in Shields. There are a few others for the Lua badge helpers with a home-grown implementation of something like Sazerac.


Handlebars: not beautifying properly?

I'm having trouble getting my HTML with Handlebars to beautify. I am using Atom Beautify within the Atom editor.
With grammar in Atom set to HTML, beautifying leads to this:

As you can see, the Handlebars content is all on the same line and not properly indented/nested.
Switching my grammar to Handlebars (provided by the Atom Handlebars package) and beautifying leads to this:

The top-most block helper {{#if}} and its corresponding {{/if}} is properly beautified but the nested block helper and other Handlebars expressions are not.
In the above screenshots I was hoping the beautifier would make it look like:
{{#if currentUser}}
  {{#if hasCConFile}}
    {{> paymentMethod}}
  {{else}}
    {{> ccForm}}
  {{/if}}
{{/if}}

I'm using Atom 0.139 and Atom Beautify 0.14.1 which is using "js-beautify": "^1.5.1". My code might look a little weird cause it's actually Spacebars, a Meteor.js fork of Handlebars.

I ran the example through v1.8.0-rc2, and the results are still the same. I'm commenting here because I transposed out the code and thought I might as well save someone else the effort in pursuing this enhancement:
Input:

  {{#if currentUser}} {{#if hasCConFile}} {{> paymentMethod}} {{else}}{{> ccForm}} {{/if}} {{/if}}

Actual output:

    {{#if currentUser}}
        {{#if hasCConFile}} {{> paymentMethod}} {{else}}{{> ccForm}} {{/if}}
    {{/if}}


Peerconnection_client example segmentation fault

Hello,
I tried to run peerconnection_client example linked with libwebrtc.a but I end up with a segmentation fault.
I am running on a Unix machine 16.04.1-Ubuntu x86_64.
After running your script, I run the attached CMakeLists.txt in a different directory :
(dev)⚡ % cmake ..     /storage/Cosmo/libwebrtc_aisouard/libwebrtc/WorkingDir/out
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Checking for module 'gtk+-3.0'
-- Found gtk+-3.0, version 3.20.8
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /storage/Cosmo/libwebrtc_aisouard/libwebrtc/WorkingDir/out

Then make :
(dev)⚡ % make                                  /storage/Cosmo/libwebrtc_aisouard/libwebrtc/WorkingDir/out
Scanning dependencies of target ex_lib
[ 14%] Building CXX object CMakeFiles/ex_lib.dir/storage/Cosmo/libwebrtc_aisouard/libwebrtc/out/webrtc/src/webrtc/examples/peerconnection/client/conductor.cc.o
[ 28%] Building CXX object CMakeFiles/ex_lib.dir/storage/Cosmo/libwebrtc_aisouard/libwebrtc/out/webrtc/src/webrtc/examples/peerconnection/client/defaults.cc.o
[ 42%] Building CXX object CMakeFiles/ex_lib.dir/storage/Cosmo/libwebrtc_aisouard/libwebrtc/out/webrtc/src/webrtc/examples/peerconnection/client/peer_connection_client.cc.o
[ 57%] Linking CXX static library libex_lib.a
[ 57%] Built target ex_lib
Scanning dependencies of target peerconnection_client
[ 71%] Building CXX object CMakeFiles/peerconnection_client.dir/storage/Cosmo/libwebrtc_aisouard/libwebrtc/out/webrtc/src/webrtc/examples/peerconnection/client/linux/main.cc.o
[ 85%] Building CXX object CMakeFiles/peerconnection_client.dir/storage/Cosmo/libwebrtc_aisouard/libwebrtc/out/webrtc/src/webrtc/examples/peerconnection/client/linux/main_wnd.cc.o
/storage/libwebrtc_aisouard/libwebrtc/out/webrtc/src/webrtc/examples/peerconnection/client/linux/main_wnd.cc: In member function ‘virtual void GtkMainWnd::SwitchToConnectUI()’:
/storage/Cosmo/libwebrtc_aisouard/libwebrtc/out/webrtc/src/webrtc/examples/peerconnection/client/linux/main_wnd.cc:248:23: warning: ‘GtkWidget* gtk_alignment_new(gfloat, gfloat, gfloat, gfloat)’ is deprecated [-Wdeprecated-declarations]
   GtkWidget* valign = gtk_alignment_new(0, 1, 0, 0);
                       ^
In file included from /usr/include/gtk-3.0/gtk/gtk.h:248:0,
                 from /storage/Cosmo/libwebrtc_aisouard/libwebrtc/out/webrtc/src/webrtc/examples/peerconnection/client/linux/main_wnd.cc:14:
/usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:79:12: note: declared here
 GtkWidget* gtk_alignment_new        (gfloat             xalign,
            ^
[More Gtk warnings]
[100%] Linking CXX executable peerconnection_client
[100%] Built target peerconnection_client
When I run the code and then I press Connect :
 (dev)⚡ % ./peerconnection_client     /storage/Cosmo/libwebrtc_aisouard/libwebrtc/WorkingDir/out
[1]    7813 segmentation fault (core dumped)  ./peerconnection_client
In gdb :Thread 1 "peerconnection_" received signal SIGSEGV, Segmentation fault.
0x0000000000426e99 in sigslot::lock_blocksigslot::single_threaded::lock_block (this=0x7fffffffb450,
mtx=0x1329710) at /usr/local/include/webrtc/base/sigslot.h:257
257				m_mutex->lock();

Is it linked to Gtk deprecated functions ?
Thank you
CMakeLists.txt

More background info:

we used your scripts
we took the example code that come shipped with libwebrtc out.
we compiled libwertc separately and installed it
we then tried to build the example code separately using the provided cmakelists, and linked against the installed version of libwebrtc.

it failed.
as a check, and to have a basis for comparison, we also compiled libwebrtc using the instructions at webrtc.org, switched to release-branch 57, and did the same thing as above, and it worked.

can you reproduce the problem?
any idea what we are doing wrong?

I'm not sure about what's going on here, I needed to add these lines:
  ${ex_ROOT}/../../../base/asyncsocket.cc
  ${ex_ROOT}/../../../base/messagehandler.cc
  ${ex_ROOT}/../../../base/physicalsocketserver.cc

Please type the following line before running the process in gdb:
set follow-fork-mode child

Then send me the whole input, I'm building peerconnection_server in the meantime.

I'm having this right now:
Thread 1 "peerconnection_" received signal SIGSEGV, Segmentation fault.
0x00007ffff5f2b58f in std::__detail::_List_node_base::_M_hook(std::__detail::_List_node_base*) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
(gdb) bt
#0  0x00007ffff5f2b58f in std::__detail::_List_node_base::_M_hook(std::__detail::_List_node_base*) () at /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#1  0x0000000000428099 in void std::list<sigslot::_opaque_connection, std::allocator<sigslot::_opaque_connection> >::_M_insert<sigslot::_opaque_connection>(std::_List_iterator<sigslot::_opaque_connection>, sigslot::_opaque_connection&&) ()
#2  0x0000000000427751 in std::list<sigslot::_opaque_connection, std::allocator<sigslot::_opaque_connection> >::push_back(sigslot::_opaque_connection&&) ()
#3  0x0000000000426f77 in void sigslot::signal_with_thread_policy<sigslot::single_threaded, rtc::AsyncResolverInterface*>::connect<PeerConnectionClient>(PeerConnectionClient*, void (PeerConnectionClient::*)(rtc::AsyncResolverInterface*)) ()
#4  0x0000000000423543 in PeerConnectionClient::Connect(std::string const&, int, std::string const&) ()
#5  0x0000000000415906 in Conductor::StartLogin(std::string const&, int) ()
#6  0x000000000040e5b2 in GtkMainWnd::OnClicked(_GtkWidget*) ()

By the way, you should use GTK2 to avoid deprecated warnings and strange behaviour.

I'll try to replace the sample with peerconnection on my side tonight GMT+2
Le 18 mai 2017 18:17:07 GMT+02:00, alex gouaillard<EMAIL_ADDRESS>a écrit :

More background info:

we used your scripts
we took the example code that come shipped with libwebrtc out.
we compiled libwertc separately and installed it
we then tried to build the example code separately using the provided
cmakelists, and linked against the installed version of libwebrtc.

it failed.
as a check, and to have a basis for comparison, we also compiled
libwebrtc using the instructions at webrtc.org, switched to
release-branch 57, and did the same thing as above, and it worked.

can you reproduce the problem?
any idea what we are doing wrong?

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/aisouard/libwebrtc/issues/46#issuecomment-302459699

--
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.

Hi，Is this problem solved?


Implement autorest x-ms extensions

x-ms-extensions are defined here:
https://github.com/Azure/autorest/blob/master/docs/extensions/readme.md
We need to re-implement them in Autorest v3 generators.
Assuming remodeler passes the metadata, this is the extensions I believe are language specific:

x-ms-skip-url-encoding
x-ms-enum
x-ms-client-flatten
x-ms-parameterized-host
x-ms-error-response
x-ms-odata (Python doesn't plan to support)
x-ms-azure-resource (ARM specific)

I expect the remodeler to do something about it:

x-ms-parameter-grouping (should create the group in the YAML)
x-ms-parameter-location (should be in the right place in the YAML)
x-ms-paths (should be a regular path on consumption)
x-ms-client-name (new field preferred name: name from Swagger or x-ms-client-name)
x-ms-discriminator-value (new field preferred value: value from Swagger or x-ms-disc-value)

Needs to be discussed if we drop support:

x-ms-external
x-ms-mutability
x-ms-request-id
x-ms-client-request-id

Dedicated issues:

x-ms-pageable: #7402
x-ms-long-running-operation: #7405

Done


As a SCRS admin, I want a continuous integration strategy

create a development server instance and repo for DEV
create tests that run from development server when pushed to DEV branch in GitHub
create a report of pass and fails  that gets published for public to view
Examine the Heroku workflow to determine if this can be leveraged
Merge new code to Master branch only after DEV tests run and pass

https://github.com/integrations/feature/code

Check out Travis for CI:
https://travis-ci.org
On Sun, Jul 3, 2016 at 10:17 AM Josh Sherman<EMAIL_ADDRESS>wrote:

create a development server instance and repo for DEV
create tests that run from development server when pushed to DEV branch in
GitHub
create a report of pass and fails that gets published for public to view
Examine the Heroku workflow to determine if this can be leveraged
Merge new code to Master branch only after DEV tests run and pass
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PennStateSoftwareTest/FinalProjectPennState/issues/149,
or mute the thread
https://github.com/notifications/unsubscribe/AFI0ngL2tJXXvfjbCO4V6B4ciiTecuvRks5qR-CvgaJpZM4JD5gh
.


Python Version does not get updated

Describe The Problem
I tried to update wireguard's dashboard today (./wgd.sh update), but it fails because the installed Python version is too low. I would have expected the update script to also update my Python version if it is below the minimum required version.
Expected Error / Traceback
root@wireguard:/etc/wgdashboard/src# ./wgd.sh update
[WGDashboard] OS: debian
[WGDashboard] ✔ Python is installed
[WGDashboard] ✗ Could not find a compatible version of Python. Current Python is Python 3.9.2.
[WGDashboard] WGDashboard required Python 3.10, 3.11 or 3.12. Halting install now.
Terminated

To Reproduce
LXC-Container in Proxmox created via https://tteck.github.io/Proxmox/#wireguard-lxc
Running ./wgd.sh update
OS Information:

Debian 11
Python 3.9.2

Hello Raukze, I think updating Python itself is kind of a big ask if you just want to update your WGDashboard, because there are a lot of changes between Python versions. therefore it is really riskful to suddenly update the Python version.
But if you see this differently! Please tell me how we can improve this!

The point I want to make is that ./wgd.sh installs Python if it is not already installed. Therefore, I would have expected it to also update the version of Python when I use the update command of ./wgd.sh. I mean, I also understand your point that it is risky, but in my case I have a dedicated LCX container in Proxmox running only wireguard and WGDashboard. Maybe an optional flag would be a way to let the user decide. What do you think?

To add to that. I tried manually updating the Python version to 3.10.0 with the following commands from here
wget https://www.python.org/ftp/python/3.10.0/Python-3.10.0.tgz && \
tar -xvf Python-3.10.0.tgz && \
cd Python-3.10.0 && \
sudo ./configure --enable-optimizations && \
sudo make && \
sudo make altinstall

I then added the symlink ln -s /usr/local/bin/python3.10 /usr/local/bin/python3
When running the ./wgd.sh update I get the following errors:
root@wireguard:/etc/wgdashboard/src# ./wgd.sh update
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.10/urllib/request.py", line 216, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/local/lib/python3.10/urllib/request.py", line 519, in open
    response = self._open(req, data)
  File "/usr/local/lib/python3.10/urllib/request.py", line 541, in _open
    return self._call_chain(self.handle_open, 'unknown',
  File "/usr/local/lib/python3.10/urllib/request.py", line 496, in _call_chain
    result = func(*args)
  File "/usr/local/lib/python3.10/urllib/request.py", line 1419, in unknown_open
    raise URLError('unknown url type: %s' % type)
urllib.error.URLError: <urlopen error unknown url type: https>
------------------------------------------------------------
| Are you sure you want to update to the ? (Y/N): Y
| Shutting down WGDashboard...                             |
| Downloading  from GitHub...                            |
| Upgrading pip                                            |
| Installing latest Python dependencies                    |
| Update Successfully!                                     |
------------------------------------------------------------

I then tried running ./wgd.sh start which also is no success:
root@wireguard:/etc/wgdashboard/src# ./wgd.sh start
[WGDashboard] WireGuard is already installed.
------------------------------------------------------------
[WGDashboard] Starting WGDashboard with Gunicorn in the background.
[WGDashboard] Creating Python Virtual Environment under ./venv
sudo: ./venv/bin/gunicorn: command not found

it seems to be stuck in the script after that output.

Hi, please try the step 1,2 and 3 on here "How to update?" and see if it works?

Damn I just restored the backup. Will try the whole update progress later again. Thanks!

Update is successful:
root@wireguard:/etc/wgdashboard/src# ./wgd.sh update
------------------------------------------------------------
| Are you sure you want to update to the v4.0.4? (Y/N): Y
| Shutting down WGDashboard...                             |
| Downloading v4.0.4 from GitHub...                            |
| Upgrading pip                                            |
| Installing latest Python dependencies                    |
| Update Successfully!                                     |
------------------------------------------------------------

But when trying to start:
root@wireguard:/etc/wgdashboard/src# ./wgd.sh start
------------------------------------------------------------
[WGDashboard] Starting WGDashboard with Gunicorn in the background.
[WGDashboard] Creating Python Virtual Environment under ./venv
sudo: ./venv/bin/gunicorn: command not found

and it stops there.

reported a few weeks ago that the upgrade process does not work moving from v3 to v4 but as yet still no resoloution but some troubleshooting links it back to bcrypt

Hi @Raukze , you mind follow these steps instead of using ./wgd.sh update?

Change your directory to wgdashboard
cd wgdashboard/src

Update the dashboard
git pull https://github.com/donaldzou/WGDashboard.git --force

Install
sudo ./wgd.sh install

@donaldzou the updating method is through GitHub correct?

@donaldzou the updating method is through GitHub correct?

Yes that's correct.

I am having this exact same issue. I am not engineer so I am unsure how to solve the issue.
I first tried with ./wgd.sh update but that failed to work, and then I tried the git pull method. Neither way resolves my issues. I thought it looked like a simple fix but updating Python seems to be more than annoying.
`root@wireguard:/etc/wgdashboard/src# ./wgd.sh install
[WGDashboard] Starting to install WGDashboard
[WGDashboard] OS: debian
[WGDashboard] ✔ Python is installed
[WGDashboard] ✗ Could not find a compatible version of Python. Current Python is Python 3.9.2.
[WGDashboard] WGDashboard required Python 3.10, 3.11 or 3.12. Halting install now.
Terminated
root@wireguard:/etc/wgdashboard/src# ./wgd.sh start
[WGDashboard] WireGuard is already installed.
[WGDashboard] Starting WGDashboard with Gunicorn in the background.
./wgd.sh: line 59: ./venv/bin/activate: No such file or directory
sudo: ./venv/bin/gunicorn: command not found
[WGDashboard] Checking if WGDashboard w/ Gunicorn started successfully
[WGDashboard] WGDashboard w/ Gunicorn started successfully
root@wireguard:/etc/wgdashboard/src# ./wgd.sh stop
[WGDashboard] WGDashboard is not running.
root@wireguard:/etc/wgdashboard/src# ./wgd.sh debug
[WGDashboard] WireGuard is already installed.
[WGDashboard] Starting WGDashboard in the foreground.
Traceback (most recent call last):
File "/etc/wgdashboard/src/dashboard.py", line 18, in
import bcrypt
ModuleNotFoundError: No module named 'bcrypt'
------------------------------------------------------------`

I am having this exact same issue. I am not engineer so I am unsure how to solve the issue. I first tried with ./wgd.sh update but that failed to work, and then I tried the git pull method. Neither way resolves my issues. I thought it looked like a simple fix but updating Python seems to be more than annoying.
`root@wireguard:/etc/wgdashboard/src# ./wgd.sh install
[WGDashboard] Starting to install WGDashboard
[WGDashboard] OS: debian
[WGDashboard] ✔ Python is installed
[WGDashboard] ✗ Could not find a compatible version of Python. Current Python is Python 3.9.2.
[WGDashboard] WGDashboard required Python 3.10, 3.11 or 3.12. Halting install now.
Terminated
root@wireguard:/etc/wgdashboard/src# ./wgd.sh start
[WGDashboard] WireGuard is already installed.
[WGDashboard] Starting WGDashboard with Gunicorn in the background.
./wgd.sh: line 59: ./venv/bin/activate: No such file or directory
sudo: ./venv/bin/gunicorn: command not found
[WGDashboard] Checking if WGDashboard w/ Gunicorn started successfully
[WGDashboard] WGDashboard w/ Gunicorn started successfully
root@wireguard:/etc/wgdashboard/src# ./wgd.sh stop
[WGDashboard] WGDashboard is not running.
root@wireguard:/etc/wgdashboard/src# ./wgd.sh debug
[WGDashboard] WireGuard is already installed. [WGDashboard] Starting WGDashboard in the foreground. Traceback (most recent call last): File "/etc/wgdashboard/src/dashboard.py", line 18, in import bcrypt ModuleNotFoundError: No module named 'bcrypt' ------------------------------------------------------------`

Do you for any reason NEED python3.9.2? Otherwise you can try to install python3
On apt systems
sudo apt install python3.11

and then try again!

Trying on Proxmox in an LXC container but it only sees up to 3.92.

Trying on Proxmox in an LXC container but it only sees up to 3.92.

Hi @BigFidel , if you look over the documentation, when I tested on Debian 11 I had to manually build Python 3.11 from source, maybe that's case?
Installation

Thank you for your help! Unfortunately I can’t confirm because I took the easy route and created a new container with the latest code. All working now. Only questions I have are about the app you built.
Really enjoy your work, thank you!

That’s great!
Sure, do you mean the desktop app?

From: BigFidel @.>
Sent: Saturday, November 9, 2024 11:36:58 AM
To: donaldzou/WGDashboard @.>
Cc: Donald Zou @.>; Mention @.>
Subject: Re: [donaldzou/WGDashboard] Python Version does not get updated (Issue #422)
Thank you for your help! Unfortunately I can’t confirm because I took the easy route and created a new container with the latest code. All working now. Only questions I have are about the app you built.
Really enjoy your work, thank you!
—
Reply to this email directly, view it on GitHubhttps://github.com/donaldzou/WGDashboard/issues/422#issuecomment-2466023009, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGARNUKVWYBXAY2HXQRJRKDZ7V7NVAVCNFSM6AAAAABPURM37WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGAZDGMBQHE.
You are receiving this because you were mentioned.Message ID: @.***>

Yeah honestly I don’t understand the UI! I’ll mess with it more (exhausted here) before bugging you more. I’ll probably play with it tomorrow and figure it out.

No problem! If you wish, you could join our discord server and we can chat from there:
https://discord.gg/MXDBpuRB
Get Outlook for iOShttps://aka.ms/o0ukef

From: BigFidel @.>
Sent: Saturday, November 9, 2024 11:40:51 AM
To: donaldzou/WGDashboard @.>
Cc: Donald Zou @.>; Mention @.>
Subject: Re: [donaldzou/WGDashboard] Python Version does not get updated (Issue #422)
Yeah honestly I don’t understand the UI! I’ll mess with it more (exhausted here) before bugging you more. I’ll probably play with it tomorrow and figure it out.
—
Reply to this email directly, view it on GitHubhttps://github.com/donaldzou/WGDashboard/issues/422#issuecomment-2466026401, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGARNUJQ3OOYZQJE2H53PHLZ7V74HAVCNFSM6AAAAABPURM37WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGAZDMNBQGE.
You are receiving this because you were mentioned.Message ID: @.***>


Fix embedded sourcemap URL (fixes #31)

Verified that @nzakas has signed the CLA. Thanks for the pull request!

+2


c2go autoStaticName: use baseOfFile

Codecov Report

Merging #21 (4ddc56c) into musl-go (6b59455) will not change coverage.
The diff coverage is 45.76%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b59455...4ddc56c. Read the comment docs.


[BUG] legacy code in LogConfigurator

Describe the bug
stumbled across this by chance, the comment claims that this should've been removed with ES 7.0 (which obviously didn't happen if it was still present in 7.10.2 at the time of forking away). it should be re-considered if this is still needed and be refactored accordingly (either by fulfilling the promise of the comment or by removing the comment and cleaning up the code as needed).
https://github.com/opensearch-project/OpenSearch/blob/6629b09aad2629fafb7aad998153867c2f3fe472/server/src/main/java/org/opensearch/common/logging/LogConfigurator.java#L192-L201
To Reproduce
n/a
Expected behavior
no code which has a comment stating that it should've been removed a long time ago.
Plugins
n/a
Screenshots
n/a
Host/Environment (please complete the following information):
n/a
Additional context
stumbled across this because this code tries to scan all files present in the config/ folder on startup and it failed on some file for us (i still don't know why... but got a workaround now so i can safely ignore the problem for the time being). it'd be great if it wouldn't have to scan all files even just for startup time reasons (as plugin configs are now also in this folder there will be more and more files to scan, increasing the startup time - not by much, but still: "death by a thousand cuts" applies here as well).

@rursprung Could you help me double check, it is the "hack" part that cause problem to you?
https://github.com/opensearch-project/OpenSearch/blob/2c27dfddbdabbf064317bd315a5464ba5f41c1da/server/src/main/java/org/opensearch/common/logging/LogConfigurator.java#L211-L229
I want to make sure that removing the customized override of the method getConfiguration() can solve your problem.
Scanning all files from config directory can not be avoided after fulfilling the promise of code removal, because scanning all files is an old behavior since 2016:
https://github.com/opensearch-project/OpenSearch/blob/2c27dfddbdabbf064317bd315a5464ba5f41c1da/server/src/main/java/org/opensearch/common/logging/LogConfigurator.java#L129-L131
If you would suggest to avoid scanning files in config folder, then I think it's better to create a separate issue, and that will need more work.

Thank you for reporting the legacy code to be removed!
The legacy code in LogConfigurator class have been removed by PR https://github.com/opensearch-project/OpenSearch/pull/4568 / commit https://github.com/opensearch-project/OpenSearch/commit/3ca749f09bf284263391d296af56e01fb81e0cfa.
So that the node name will not be added into log pattern for customized log4j property file from version 3.0
The version that shown in the warning message for the code removal is also updated to 3.0, by PR https://github.com/opensearch-project/OpenSearch/pull/4569. The warning message will be updated in version 2.3.1 and 2.4.0 and above.
I will close the issue now, if you think scanning all files from config directory is a problem, please open a new issue.

I will close the issue now, if you think scanning all files from config directory is a problem, please open a new issue.

thanks! i'll re-verify once 3.0.0 is coming out and the removal is in there (it's not a priority for us right now, thus i won't bother testing the latest main version manually) and raise a new issue with more details if there's still a problem related to this.


file: manually parse out every top-level field

Struct tag unmarshaling fails (because of the Batcher) interface, so we have to explicitly parse out each sub-object.
Issue: https://github.com/moov-io/paygate/issues/8

The problem with Batcher is that you can't decode an interface{}, because there's no implementation. Instead we have to pull out the other fields and then batch itself.
It's a bit annoying, but I don't think we want to replace Batcher with batch (exported).


Timeline slider - Mouse swipe control

@teshukatepalli1  as discussed please look into this swipe control issue.
https://main--aldevron--hlxsites.hlx.page/test/timeline-slide
https://www.aldevron.com/25th-anniversary

@Kummu007 - please validate and connect with Vinay if the issue still persists

@pardeepgera23  this is not working as expected. @Vinaykumargujja  please check this once

Hi Kumaresan - As discussed with Client, they are ok with this. It can be taken as an enhancement in Phase 2.

As per the above thread, the Clients are okay with this in this Phase. It can be taken as an enhancement in Phase 2. Hence closing the the ticket,


Combine SERVICE_TAGS and SERVICE_x_TAGS

With the following docker-compose:
traefik:
  image: traefik
      - SERVICE_TAGS=traefik.frontend.rule=Host:www.iadvize.com
      - SERVICE_80_TAGS=traefik.frontend.entryPoints=http,traefik.protocol=http
      - SERVICE_443_TAGS=traefik.frontend.entryPoints=https,traefik.protocol=https

Registrator will register only SERVICE_x_TAGS

@samber can you point me in direction for getting registrator to work with traefik?


Question on Adding classes

This isn't really an issue but a question I had Sal or someone else that might know. I'm not is the value of the bsg-add-class filter compared to bsg-classes-to-add or the standard genesis_attr_{$context}. Referring to this wiki, these examples below all seem to work the same with the exception of bsg-add-class only able to add one class, so I'm just wondering when to use each?
add_filter( 'bsg-classes-to-add', 'hide_sidebar_on_xs_screen_size', 10, 3 );
function hide_sidebar_on_xs_screen_size( $classes, $context, $attr ) {
    if ( 'sidebar-primary' === $context ) {
        $classes[] = 'hidden-xs';
    }
return $classes;
}

add_filter( 'bsg-add-class', 'hide_sidebar_on_xs_screen_size', 15, 3 );
function hide_sidebar_on_xs_screen_size( $classes, $context, $attr ) {
    if ( 'sidebar-primary' === $context ) {
        $classes[] = 'hidden-xs';
    }
return $classes;
}

add_filter( 'genesis_attr_sidebar-primary', 'themeprefix_add_css_attr' );
function themeprefix_add_css_attr( $attributes ) {
	$attributes['class'] .= ' hidden-xs';
	return $attributes;
}

genesis_attr_sidebar-primary
This is the default Genesis behavior everything else is layered on top.  As your notes above indicate, this may be preferable to bsg-add-class.
bsg-add-class
You make an excellent point that there may not be any real value in this filter since the corresponding genesis_attr_ filter can be used instead.  We should reconsider example number 2 on https://github.com/salcode/bootstrap-genesis/wiki/Hide-Primary-Sidebar-on-XS-Screen-Size and probably refactor it to use genesis_attr_sidebar-primary instead.
However, even if we modify documentation to recommend against using this filter, I think it makes sense to keep it around.
bsg-classes-to-add
This is the filter I use most often.  The default Bootstrap values are assigned here and then these can be modified (as we do in bootstrap-markup-layout-options.php).  I find this particularly useful for overwriting (rather than adding to) the default values.

In regard to the custom attributes, here's a handy function I wrote to return the current genesis_attributes to add to the bsg-classes-to-add array.
if( current_user_can('administrator') ) {
    add_action( 'wp_footer', 'bsg_list_genesis_attr_filters' );
}

function bsg_list_genesis_attr_filters() {
    global $wp_filter;
    $genesis_attr_filters = array();
    $output = '
';
    foreach ( $wp_filter as $key => $val ) {
        if ( FALSE !== strpos( $key, 'genesis_attr' ) ) {
            $genesis_attr_filters[$key][] = var_export( $val, TRUE );
        }
    }
    foreach ( $genesis_attr_filters as $name => $attr_vals ) {
                   $name = str_replace("genesis_attr_","",$name);
        $output .= "
$name
";
    }
    print "$output
";
}

Output
head
body
site-header
site-title
site-description
header-widget-area
breadcrumb
breadcrumb-link-wrap
search-form
nav-primary
nav-secondary
nav-header
nav-link-wrap
nav-link
structural-wrap
content
taxonomy-archive-description
author-archive-description
cpt-archive-description
date-archive-description
blog-template-description
posts-page-description
entry
entry-image
entry-image-widget
entry-image-grid-loop
entry-author
entry-author-link
entry-author-name
entry-time
entry-modified-time
entry-title
entry-content
entry-meta-before-content
entry-meta-after-content
archive-pagination
entry-pagination
adjacent-entry-pagination
comments-pagination
entry-comments
comment
comment-author
comment-author-link
comment-time
comment-time-link
comment-content
author-box
sidebar-primary
sidebar-secondary
site-footer
site-inner
content-sidebar-wrap
nav-footer
jumbotron-header
widget


built packages don't tree shake react-native-web

When the packages are built with babel, they end up requiring all of react-native-web without tree shaking unused code. This means for an app consuming one of the modal packages, there's not way to tree shake rnw because there is a dependency that "requires" all of the package.

I'm not sure if this will work, but you can try the babel-plugin-import plugin
[
    "import",
    Object.assign(
      {},
      {
        'modal-react-native-web'
      },
      {
                libraryDirectory: resolveNodeModules('modal-react-native-web'),
	       camel2DashComponentName: false,
      }
    ),
    `fix-modal-react-native-web-imports`
  ]

It should use the babel plugin for react-native-web instead of aliasing.
import { StyleSheet } from 'react-native'
translates to
import StyleSheet from 'react-native/dist/exports/StyleSheet'

modal is now supported in react native web.
https://github.com/necolas/react-native-web/releases/tag/0.14.0
Thank you for using this library!


[ctemplate:x64-windows] build failure

Host Environment

OS: Windows 10
Compiler: visual studio 2017

To Reproduce
Steps to reproduce the behavior:
./vcpkg install ctemplate:x64-windows
Failure logs
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:136 (message):
Command failed: E:/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/bin/cmake.exe --build . --config Debug --target install -- -v
Working Directory: E:/vcpkg/buildtrees/ctemplate/x64-windows-dbg
See logs for more information:
E:\vcpkg\buildtrees\ctemplate\install-x64-windows-dbg-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_build_cmake.cmake:91 (vcpkg_execute_build_process)
scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
ports/ctemplate/portfile.cmake:22 (vcpkg_install_cmake)
scripts/ports.cmake:90 (include)
Error: Building package ctemplate:x64-windows failed with: BUILD_FAILED
Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

@jchdng，thanks for reporting this issue, could you attach failure log E:\vcpkg\buildtrees\ctemplate\install-x64-windows-dbg-out.log?

install-x64-windows-dbg-out.log

@jchdng, thanks for attaching the logs, from your log, it seems that affected by other libraries, could you try the following steps to check what files it reference.

Open x64 Native Tools command
Go to E:\vcpkg\buildtrees\ctemplate\src\1ec256a62b-c7b6f00c13
Execute
cl.exe  /IE:\vcpkg\buildtrees\ctemplate\x64-windows-dbg\include   /TP -D_VARIADIC_MAX=10 -Dlibctemplate_EXPORTS -Iinclude /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1    /W3 /wd4005 /wd4996 /wd4018 /wd4025 -D_CRT_SECURE_NO_WARNINGS /showIncludes  /FS -c E:\vcpkg\buildtrees\ctemplate\src\1ec256a62b-c7b6f00c13\src\htmlparser\jsparser.cc
Check the include files

For me, The inlcude files is
Note: including file: F:\VCPKG\src\buildtrees\ctemplate\x64-windows-dbg\include\htmlparser/statemachine.h
Note: including file:  F:\VCPKG\src\buildtrees\ctemplate\x64-windows-dbg\include\config.h
Note: including file:   f:\vcpkg\src\buildtrees\ctemplate\x64-windows-dbg\include\windows/port.h
Note: including file:    f:\vcpkg\src\buildtrees\ctemplate\x64-windows-dbg\include\windows/config.h
Note: including file: F:\VCPKG\src\buildtrees\ctemplate\x64-windows-dbg\include\htmlparser/jsparser.h
Note: including file:  F:\VCPKG\src\buildtrees\ctemplate\x64-windows-dbg\include\config.h
Note: including file: F:\VCPKG\src\buildtrees\ctemplate\x64-windows-dbg\include\htmlparser/jsparser_fsm.h
include files.txt

@jchdng, please reopen this issue if it still be a problem for you.


Remove list row separators between terminal tabs

Description
Removed the dividers between the terminal tabs see screen recording below.
Related Issues

close #1485

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[x] I documented my code

Screenshots
https://github.com/CodeEditApp/CodeEdit/assets/128280019/7398e485-aabe-47d2-828e-099ede59d503

This has already been done in #1471. Thank you for your effort.


Slightly improve the performance of removeNullCharacters

Most of the strings shouldn't contain special chars (<= 0x1F) so we can have a fast path which just checks if the string contains at least one such a char.

I profiled pdf.pdf with a sampling interval equals to 0.1ms.
Here's a profile without the patch:
https://share.firefox.dev/3Quo0Mb
and one with the patch:
https://share.firefox.dev/3tMyfCI
The function is now around ~3 times faster.

It might not matter all that much, performance wise, but given how and where this helper function is being used do we still need the following part of it?
https://github.com/mozilla/pdf.js/blob/f098121644fb665ad40c847a9fe7fefa2bdbf2a0/web/ui_utils.js#L216-L219
(This function was originally placed in src/shared/util.js, hence the additional validation.)


. QA GREEN

Tutorial issue found: https://github.com/sap-tutorials/abap-core-development/blob/master/tutorials/abap-s4hanacloud-procurement-purchasereq-shop-ui/abap-s4hanacloud-procurement-purchasereq-shop-ui.md contains invalid primary tag.
Your tutorial was not created. Please double-check primary tag property.
Each tutorial md-file shall have primary tag provided above. Example:
---
title: Text Bundles within Node.js SAP HANA applications
description: Working with text bundles in Node.js
primary_tag: products>sap-hana
tags: [ tutorial>intermediate, products>sap-hana, products>sap-hana--express-edition ]
---
Affected server: QA GREEN

Hi @mervey45,
we got dozens of this issues. Could you please check the primary_tag?


Add tooltip text to hide and edit action buttons

In the customize modal for the colection, add toll tips for the hide eye and edit icon buttons.
Tooltip info:
eye icon - text: "Show/Hide" - placement: right
edit icon - text: "Edit" - placement top

Use the existing <Tooltip component

I would like to try this one please. @MrRobz

I would like to try this one please. @MrRobz

Go for it

This can be closed


StringLength on records (C# 9)

I noticed that StringLengthAttribute does not work on record types.
I assume it's due record's behaviour of { get; init; } that they are not re-assignable?
[Test]
public void StringLength()
{
    var request = new Fixture().Create<MyRecord>();

    Assert.AreEqual(5, request.String2.Length); // succeeds
    Assert.AreEqual(17, request.String1.Length); // fails
}

public record MyRecord([StringLength(17)] string String1) {
    [StringLength(5)] public string String2 { get; set; }
}

Attributes on the constructor attributes target the backing field. you need to specify that you want to target the property
Check if this is working
public record MyRecord([property: StringLength(17)] string String1) {
    [StringLength(5)] public string String2 { get; set; }
}

Attributes on the constructor attributes target the backing field. you need to specify that you want to target the property
Check if this is working
public record MyRecord([property: StringLength(17)] string String1) {
    [StringLength(5)] public string String2 { get; set; }
}