centerMode option added

Added centerMode option to enable centerMode functionality which is missing in current day implementation.

Just took a quick look, you have some uncommented code included. I'll dig a little deeper soon, but I am quite busy at the current time. If people want to test and confirm that it works, that will also help me.
Thanks for contributing!

Verified, Works fine with variable width slides and great to have firstSlideLeftAligned feature.

Just took a quick look, you have some uncommented code included. I'll dig a little deeper soon, but I am quite busy at the current time. If people want to test and confirm that it works, that will also help me.
Thanks for contributing!

Verified, Works fine with variable width slides and great to have firstSlideLeftAligned feature.

Thanks for checking. Glad to know it will be a help.

Do you wanna merge @nishantuie?

Looks, good. But my computer died, I'll get a new one the 21th so it's hard for me to make the final things - it's not forgotten :)

Yeh, let's merge. Let me know if I can be of any help.
Regards,
Nishant Joshi
M: +91-9898028503
On Monday, November 18, 2019, 03:32:33 PM GMT+5:30, Allan Kimmer Jensen<EMAIL_ADDRESS>wrote:

Do you wanna merge @nishantuie?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Looks, good. But my computer died, I'll get a new one the 21th so it's hard for me to make the final things - it's not forgotten :)

@Saturate Thanks for reviewing.

:eyes:


Smart-Card based OpenVPN fails after upgrade to openssl3

Hi there,
this is a complex issue and I am not yet 100% sure whether this is an OpenSSL/OpenVPN/OpenSC issue. From all my debugging I did till now I think this might be an OpenSSL issue; so please be gentle and redirect me to the relevant projects if you think I am wrong.
OpenVPN uses client TLS certificates and in my case I am using the certificate on a Yubikey. When connecting I get the following output from OpenVPN (in this specific case the output is the info callback from OpenSSL):
2022-04-02 18:44:07 us=508919 SSL state (connect): SSLv3/TLS read server hello
2022-04-02 18:44:07 us=511134 VERIFY OK: depth=2, C=US, O=Entrust, Inc., OU=See www.entrust.net/legal-terms, OU=(c) 2009 Entrust, Inc. - for authorized use only, CN=Entrust Root Certification Authority - G2
2022-04-02 18:44:07 us=511625 VERIFY OK: depth=1, C=US, O=Entrust, Inc., OU=See www.entrust.net/legal-terms, OU=(c) 2012 Entrust, Inc. - for authorized use only, CN=Entrust Certification Authority - L1K
2022-04-02 18:44:07 us=512109 VERIFY X509NAME OK: CN=*.tld
2022-04-02 18:44:07 us=512156 VERIFY OK: depth=0, CN=*.tld
2022-04-02 18:44:07 us=514372 SSL state (connect): SSLv3/TLS read server certificate
2022-04-02 18:44:07 us=514774 SSL state (connect): SSLv3/TLS read server key exchange
2022-04-02 18:44:07 us=514974 SSL state (connect): SSLv3/TLS read server certificate request
2022-04-02 18:44:07 us=515012 SSL state (connect): SSLv3/TLS read server done
2022-04-02 18:44:07 us=515086 SSL state (connect): SSLv3/TLS write client certificate
2022-04-02 18:44:07 us=515758 PKCS#11: __pkcs11h_openssl_ex_data_free entered - parent=0x558b129515d0, ptr=(nil), ad=0x558b12951610, idx=1, argl=0, argp=0x7fdd062e0b58
2022-04-02 18:44:07 us=516172 SSL state (connect): SSLv3/TLS write client key exchange
2022-04-02 18:44:07 us=517993 SSL alert (write): fatal: internal error
2022-04-02 18:44:07 us=518052 OpenSSL: error:020000B3:rsa routines::missing private key
2022-04-02 18:44:07 us=518078 OpenSSL: error:1C880004:Provider routines::RSA lib
2022-04-02 18:44:07 us=518107 OpenSSL: error:0A080006:SSL routines::EVP lib
2022-04-02 18:44:07 us=518138 TLS_ERROR: BIO read tls_read_plaintext error
2022-04-02 18:44:07 us=518171 TLS Error: TLS object -> incoming plaintext read error

When I recompile pkcs11-helper/opensc/openvpn against openssl 1.1 it instead starts querying pkcs11 and asking for a token password:
SSL state (connect): SSLv3/TLS write client certificate
PKCS#11: __pkcs11h_openssl_ex_data_free entered - parent=0x22ccd50, ptr=(nil), ad=0x22ccd90, idx=1, argl=0, argp=0x7fc3109e6fde
SSL state (connect): SSLv3/TLS write client key exchange
PKCS#11: __pkcs11h_openssl_rsa_enc entered - flen=51, from=0x22e14c0, to=0x22ea9a0, rsa=0x2265940, padding=1
PKCS#11: Performing signature
PKCS#11: pkcs11h_certificate_signAny_ex entry certificate=0x227b000, mech_type=1, source=0x22e14c0, source_size=0000000000000033, target=0x22ea9a0, *p_target_size=0000000000000100
PKCS#11: Getting key attributes
PKCS#11: __pkcs11h_certificate_getKeyAttributes entry certificate=0x227b000
PKCS#11: _pkcs11h_session_freeObjectAttributes entry attrs=0x7ffd8accb290, count=6
PKCS#11: _pkcs11h_session_freeObjectAttributes return

I also tried swapping /usr/lib64/pkcs11/opensc-pkcs11.so with /usr/lib64/pkcs11/opensc-pkcs11.so but that just resulted in the same issue. Is there any way to better debug openSSL here?

I am closing here, looks like an issue in pkcs11-helper.

I wonder how to clasify this report

engine based, i.e. https://github.com/openssl/openssl/issues/17092
by key method, i.e. https://github.com/openssl/openssl/issues/17286

Due to error "OpenSSL: error:020000B3:rsa routines::missing private key" looks like second case.

The issue was that pkcs11-helper used EVP_PKEY_get1_RSA.html and altered the returned key, which no longer works:

... will be a cached copy of the provider's key. Subsequent updates to the provider's key will not be reflected back in the cached copy, and updates made by an application to the returned key will not be reflected back in the provider's key.

So it is design failure in OpenSSL 3?

No idea, I am not a OpenSSL developer -- it is not for me to say whether the new designer is better or worse. The proper solution seems to implement a custom provider. This is also what openvpn does for external keys coming up in openvpn 2.6.

There is no announcement that OpenSSL will not support custom key method not engine based. Functionality is deprecated but not removed!
Remark: get0 returns constant instance so cannot be used for updates.

3.0 is a major version change and consequently is not guaranteed to be 100% API compatible. We tried to minimise the places where the API was actually broken between 1.1.1 and 3.0, but this is one of those places. It was a deliberate design decision to do this (basically it was the least worse option).

So get1[0|1|_ "return cached copy of the provider's key" of provider key.
But case is NOT for provider keys. So cached copy does not make sense and get0/get1 must work as before.
As is reported in issue #17092 impacted are RSA and DSA keys, not EC keys. Why? The difference is how engine is associated with ecdsa/ec keys.
Let review ec process in e_nss:
a) pkey created by "DER to Internal" function over public key data
b) engine method is set unconditionally on key  obtained by get1_
c) application context is set on key, Remark: obtained by get1_
So in above scenario after point b) key and pkey should be considered as non-provider key.
RSA/DSA differ as exist API that allows program to get method associated with key.
Code  in e_nss engine has an "optimisation"  to avoid key recreation if key uses engine provided method. So b) looks like:
b) key  obtained by get1_
b.1) if method match provide by engine go to c)
b.2) replace key: create new engine base key using _new_method(e), copy public part and assign newly created key on pkey.
c) as for ecdsa/ec keys
Why does not work? Trace shows that key is already created with engine method! The lost application context indicates use of "cached copy".
What I do: I comment "optimisation" just for testing and RSA/DSA key tests pass.

Conclusion:
Explicit set of key method provided by engine works.
OpenSSL defect is that it consider as "provider key" a key that uses engine method set implicitly!
Remark: In case of e_nss method is d2i_PUBKEY.

About this issue: if a key uses external method it cannot be considered as provider key.


Fix infallible ToEtcExpr tests

These two asserts were comparing a value of type Optional[String] with
a value of type String for inequality, so they were guaranteed to
always succeed.

[x] Tests added for any new code
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)

Codecov Report

Merging #1417 (17d376c) into unstable (18bb04b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           unstable    #1417      +/-   ##
============================================
- Coverage     76.07%   76.05%   -0.02%
============================================
  Files           338      338
  Lines         10962    10962
  Branches        546      546
============================================
- Hits           8339     8337       -2
- Misses         2623     2625       +2

Impacted Files
Coverage Δ

...he/io/annotations/parser/CommentPreprocessor.scala
92.77% <0.00%> (-2.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18bb04b...17d376c. Read the comment docs.


chore: clean up babel and rollup config

:tada: This PR is included in version 1.7.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix defect ensemble model (with Code) and genetic algorithm

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #2304
What are the significant changes in functionality due to this change request?
The EnsembleModel (with code) uses a different parallelization strategy. The batching mode has been enabled in that strategy (parallelMode ==2)
I also created an issue #2318 to better re-design the batching system

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Test mac on 54f43a4 : invalidated by @wangcj05
RuntimeError: Found incorrect download: libaec. Aborting

The changes are good. @alfoa Could you document how you define job '' prefix'' and 'uniqueHandler' inside Ensemble? This will help for future rework on the job submission function.

I can add th

Job Test qsubs sawtooth on 54f43a4 : invalidated by @wangcj05
unable to remove libraries

Job Test qsubs sawtooth on 54f43a4 : invalidated by @alfoa
fetch failure

The pylint complains the docstring:
ravenframework/Models/EnsembleModel.py:1:0: C0114: Missing module docstring (missing-module-docstring)
It seems you have removed the module docstring in the EnsembleModel, could you update it? @alfoa

The pylint complains the docstring:
ravenframework/Models/EnsembleModel.py:1:0: C0114: Missing module docstring (missing-module-docstring)
It seems you have removed the module docstring in the EnsembleModel, could you update it? @alfoa

@wangcj05 done

Job Test Ubuntu 20-2 Optional on a522493 : invalidated by @wangcj05
failed at fetch

Job Test qsubs sawtooth on a522493 : invalidated by @alfoa
Set python environment taking 6+ hrs?

Job Test qsubs sawtooth on a522493 : invalidated by @alfoa
Set python environment taking 6+ hrs?

@wangcj05 There is a problem with HPC testing (set up enviroment) that is not related to this PR.  (It does not seem to be a spurious problem since I invalidated the job multiple times and it gets stuck at the same step)

@wangcj05 @joshua-cogliati-inl It seems that now in devel/main there is a cascade of failures (https://civet.inl.gov/branch/2903/) after merge of PR #2309  (I dnk if it is related...probably it is not)

@wangcj05  now it fails because cvxpy is missing?

Job Mingw Test on 7ff7659 : invalidated by @alfoa

@wangcj05 the Mingw Test  are failing and I don't see a correlation with this MR.

Job Mingw Test on 7ff7659 : invalidated by @alfoa

@wangcj05 the Mingw Test  are failing and I don't see a correlation with this MR.

How many tests are failing? (And if only a few, which ones?) Thanks.

@wangcj05 the Mingw Test  are failing and I don't see a correlation with this MR.

How many tests are failing? (And if only a few, which ones?) Thanks.

FYI, there are around 33 tests failed in previous MingW test. Many for optimizations, such as simulated annealing. I have checked the new tests right now, it seems the runs are ok for now. Let's see if the test on Mingw can pass or not. @joshua-cogliati-inl

@wangcj05 the Mingw Test  are failing and I don't see a correlation with this MR.

How many tests are failing? (And if only a few, which ones?) Thanks.

FYI, there are around 33 tests failed in previous MingW test. Many for optimizations, such as simulated annealing. I have checked the new tests right now, it seems the runs are ok for now. Let's see if the test on Mingw can pass or not. @joshua-cogliati-inl

@wangcj05 @joshua-cogliati-inl unfortunately they are still failing...now in the TSA, PostProcessors, Datamining etc.

@joshua-cogliati-inl Let's try to test it on devel first. Can you pull the changes for cvxpy and test it on your trivial white space branch?

@joshua-cogliati-inl Let's try to test it on devel first. Can you pull the changes for cvxpy and test it on your trivial white space branch?

Hm, which set of changes for cvxpy? d3c7069be99dea3f491e0be1ffa2d2e5bd45ff66 ?

@joshua-cogliati-inl Let's try to test it on devel first. Can you pull the changes for cvxpy and test it on your trivial white space branch?

Hm, which set of changes for cvxpy? d3c7069 ?

https://github.com/idaholab/raven/pull/2317/commits/7ff765916d50c843a6a4357b206dc219bbda3bd0

@joshua-cogliati-inl Let's try to test it on devel first. Can you pull the changes for cvxpy and test it on your trivial white space branch?

Hm, which set of changes for cvxpy? d3c7069 ?

7ff7659

Thanks: https://github.com/idaholab/raven/pull/2113

Job Mingw Test on 7ff7659 : invalidated by @alfoa

Changes are good, PR checklist is good. PR can be merged.


Ported to babel 6

Hi,
Thanks code.  A repo is worth 1,000 words.  I wanted to use babel 6, so I committed a port.
Thanks,
_matt

Cool - @mutac do you mind if I merge this to a branch for now?
Babel 6 is still pretty new and is still missing support for some features like Decorators and loose mode.

@mutac this is now merged into the babel-6 branch, and released to npm as 1.0.0-alpha2.

(I'm closing this since it's merged, just not to master)

Cool, thank you!


chore(azure): add azure nvidia builds

What problem does this PR solve?:
Adds Azure GPU builds to CI
Which issue(s) does this PR fix?:

https://jira.d2iq.com/browse/D2IQ-85258

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

It only took 5 months, but Azure was finally able to provision capacity for us \o/:

lgtm.
we dont support GPU in azure yet. https://docs.d2iq.com/dkp/2.3/supported-infrastructure-operating-systems#id-(2.3)SupportedInfrastructureOperatingSystems-Azure.
We can keep the TC build configuration in current stage (paused) until we support it.

closing as we do not support azure with GPU yet.


Program Compatibility Assistant

Expected Behavior
CloudFlare WARP <IP_ADDRESS> TSR during installation should provide complete and useful hyperlinked URLs to correct errors, not truncated, tersely-worded spartan banners whose textual-contents can neither be wholly viewed nor clicked-on ie. hilight/selected for reuse by copy/paste.
Actual Behavior
###Program Compatibility Assistant
A digitally signed driver is required
Basil

Windows blocked the installation of a digitally unsigned
driver. Uninstall the program or device that uses the driver
and check the publisher's website for a digitally signed
version of the driver.```

### Section that requires update
Incomplete URL in popup is not selectable to copy/paste nor is its content functionally as a hyperlink.

### Additional information
<details>
![image](https://user-images.githubusercontent.com/68332197/115702875-72d4a780-a337-11eb-9666-4764dfca3ad2.jpeg)
</details>

I don't believe this is an issue anymore


How to connect to a remote machine/workspace?

Hi,
There is a usecase where user has a remote machine (or just remote container) and they want vscode-web can connect to it so that when open terminal on vscode-web, it will open terminal on that remote machine.
Can we do that with VsCode-web?
Thank!

what you need is https://github.com/coder/code-server

Thank you


Bump the kubernetes version to 23.3.0

Fixes https://github.com/powerfulseal/powerfulseal/issues/356.
Signed-off-by: Naga Ravi Chaitanya Elluri<EMAIL_ADDRESS>

@seeker89 PTAL. Thanks.


Support Pinecone Serverless in Pinecone vector store

System Info
Langchain.dart: ^0.7.2
Dart:Dart SDK version: 3.1.5 (stable) (Tue Oct 24 04:57:17 2023 +0000) on "windows_x64"
Platform: Windows 11 Home Version 10.0.22631 Build 22631
Related Components

[ ] doc-loaders
[ ] doc-transformers
[ ] prompts
[ ] llms
[ ] chat-models
[ ] output-parsers
[ ] chains
[ ] memory
[X] stores
[ ] embeddings
[ ] retrievers
[ ] agents

Reproduction

Import langchain_pinecone
Create pinecone index
Use langchain_pinecone documentation to write code-
final vectorStore = Pinecone(
indexName: xxxxxxx,
embeddings: embeddings,
apiKey: PINECONE_API_KEY,
environment: 'aped-xxxxxxxxx',
);

Expected behavior
The error recieved is-
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: PineconeClientException({
E/flutter (14516):   "uri": "https://controller.aped-xxxxxxx.pinecone.io/databases/xxxxx",
E/flutter (14516):   "method": "GET",
E/flutter (14516):   "code": 404,
E/flutter (14516):   "message": "Unsuccessful response",
E/flutter (14516):   "body": ""
In pinecone.io, the host is- https://(project_id).svc.aped-xxxxx.pinecone.io
It is serverless hosted on aws us-east-1. I tried changing baseURL and giving api key as headers but unable to interface with pinecone API

Hey @AdvaitKale01,
The client we use (pinecone) currently only supports pinecone pod-based indexes.
It would be good if someone could send a PR to the client to add serverless support, I don't think there should be many changes.
Once the client supports it, we can easily add support in the LangChain.dart Pinecone vector store.

Okay. Thanks for the update!


Typo

@avbhardwaj : Thanks for your contribution! The author(s) have been notified to review your proposed change. @evanwindom

The PR has merged and should be live in production soon.
#please-close


fix: null event in updateFieldValue

fixes #16

Great catch! I forgot that null incorrectly has a type of object.


json error: expected value at line 1 column 1

MAC os m3 ,
I  used auth application-default login, and Im using the same json ,
but this is failling with  json error: expected value at line 1 column 1
no clear of which expected value failed
let config = ClientConfig::default().with_auth().await;
match config {
Ok(con) => {
let client = Client::new(con);
info!("successfully connected ")
}
Err(error) => {
error!("something failed {}",error)
}
}

This doesn't work for me either. I have vanilla JSON, downloaded from GCP, and configured the path with GOOGLE_APPLICATION_CREDENTIALS_JSON env. This error hit me in the face...

Let me add that this works just fine:
    let credentials: CredentialsFile = serde_json::from_slice(&fs::read(std::env::var(
        "GOOGLE_APPLICATION_CREDENTIALS_JSON",
    )?)?)?;

    let config = ClientConfig::default()
        .with_credentials(credentials)
        .await?;


Fixes zeeqs helm chart deployment (hazelcast host Env. Variable name)

The "hazelcast" env variable on zeeqs helm chart was outdated, causing a bad deployment and resulting in the application crash when receiving an http request (/graphiql or POST).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.sargastico seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @Sargastico. Thanks for your PR.
I'm waiting for a zeebe-io or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

Hi @Sargastico. Thanks for your PR.
I'm waiting for a zeebe-io or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

Hi @Sargastico. Thanks for your PR.
I'm waiting for a zeebe-io or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign salaboy
You can assign the PR to them by writing /assign @salaboy in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sargastico can you please sign the CLA?

@salaboy I signed with the CLA assistant.

@Sargastico hmm.. it is still saying that you haven't signed.. are you sure you did it with the github user that you used to send the PR?

@salaboy Yes. I open the CLA and it's says that I have already agreed. (I don't have any other github user)

I can see it in the patch.. for example.. look at this PR -> https://patch-diff.githubusercontent.com/raw/zeebe-io/zeebe-cluster-helm/pull/84.patch the email from the user is : From: Zoltan Nebli<EMAIL_ADDRESS>and in your PR
I can see this: From: sargastico<EMAIL_ADDRESS>which is not your email: https://patch-diff.githubusercontent.com/raw/zeebe-io/zeebe-zeeqs-helm/pull/3.patch

@salaboy I see... Sorry for that, I will fix it

@salaboy it's working, sorry for the delay.

no worries.. merged


fix: http url match support params

bug fix: https://github.com/midwayjs/midway/issues/915

Codecov Report

Merging #74 (d79daa1) into master (fa32c78) will increase coverage by 0.03%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   85.90%   85.94%   +0.03%
==========================================
  Files          34       34
  Lines        2491     2498       +7
  Branches      678      683       +5
==========================================
+ Hits         2140     2147       +7
  Misses        317      317
  Partials       34       34

Impacted Files
Coverage Δ

packages/serverless-spec-builder/src/wrapper.ts
88.04% <83.33%> (-0.60%)
:arrow_down:

packages/gateway-common-http/src/common.ts
91.35% <100.00%> (+1.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa32c78...d79daa1. Read the comment docs.


Remove-Item fails when file ownership only matches current users group

This was all tested on a server running Ubuntu 14.04. I have a group on the system called "sharing" that my user account and others are a member of to help facilitate sharing of files. Many files have their permissions set to <different users>:sharing on a 2nd hard drive on the server. If I use "rm" in Bash I can delete files that are setup with these permissions even if my user account is not the owner because I am a member of the same group that owns the file. If I go into Powershell and try to use "remove-item" to delete the same file I get an error message saying access was denied.
Steps to reproduce
Example 1: Bash Only
# group members
$ cat /etc/group | grep sharing
sharing:x:1001:,tony,plex
# create a test file. These commands were run in BASH.
$ echo "hello" >> test_del.txt
$ ls -la | grep test_del.txt
-rw-rw-r--  1 tony tony        6 Jan 15 10:45 test_del.txt
# change the ownership of the file
$ chown plex:sharing test_del.txt
$ ls -la | grep test_del.txt
-rw-rw-r--  1 plex sharing        6 Jan 15 10:45 test_del.txt
# using "rm" in bash can successfully delete the file
$ rm test_del.txt

Example 2: Try to delete the file using PowerShell
# recreate the test file and change ownership
$ echo "hello" >> test_del.txt
$ ls -la | grep test_del.txt
-rw-rw-r--  1 tony tony        6 Jan 15 10:45 test_del.txt
$ chown plex:sharing test_del.txt
$ ls -la | grep test_del.txt
-rw-rw-r--  1 plex sharing        6 Jan 15 10:45 test_del.txt

# jump into PowerShell and try to delete the file
> remove-item ./test_del.txt

Example 3: Set the ownership to the current user and sharing group and delete the file
$ echo "hello" >> test_del.txt
$ ls -la | grep test_del.txt
-rw-rw-r--  1 tony tony        6 Jan 15 10:45 test_del.txt
$ chown tony:sharing test_del.txt
$ ls -la | grep test_del.txt
-rw-rw-r--  1 tony sharing        6 Jan 15 10:45 test_del.txt

# PowerShell will be able to successfully delete the file with these ownership settings
> remove-item ./test_del.txt

Expected behavior
"rm" in BASH is able to delete the file so PowerShell should be able to as well.
Actual behavior
PowerShell returns the following error:
> Remove-Item ./test_del.txt
Remove-Item : You do not have sufficient access rights to perform this
operation.
At line:1 char:1
+ Remove-Item ./test_del.txt
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : PermissionDenied: (/home/tony/test_del.txt:FileI
   nfo) [Remove-Item], IOException
    + FullyQualifiedErrorId : RemoveFileSystemItemUnAuthorizedAccess,Microsoft
   .PowerShell.Commands.RemoveItemCommand

Environment data

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0
PSEdition                      Core
GitCommitId                    v6.0.0
OS                             Linux 4.4.0-109-generic #132~14.04.1-Ubuntu SMP Tue Jan 9 21:46:42 UTC 2018
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

@agizmo  Do you the issue with latest PowerShell 7.0 build?


merge fails to overwrite properties

Hi there,
I stumbled upon this in https://github.com/rackt/react-router/pull/599 - I cannot override properites using lib/utils:merge:
> merge({a:'a'}, {a:'b'})
{ a: 'a' }

// triggers different code path
// https://github.com/hapijs/qs/blob/9250c4cda5102fcf72441445816e6d311fc6813d/lib/utils.js#L25
> merge({a:'a'}, {a:undefined})
{ a: 'a' }

Is this desired behaviour? If not, any idea for a workaround?
Thanks!
Max

I'm not sure why you're trying to use the merge method from this directly, as that's not intended usage at all and is not supported.
If you need a merge function, you should look at something like hoek, underscore, lodash, or amp


Make the actual config hostname the logger hostname

Coverage decreased (-0.4%) to 63.098% when pulling c65f9d3d4a215dbc57b4f6f5a67e0bdd5ff0b264 on fix/hostname into 46b3401cba918a9c5fd3685b49cd84e0c5ae19f9 on master.

Coverage decreased (-0.4%) to 63.098% when pulling c65f9d3d4a215dbc57b4f6f5a67e0bdd5ff0b264 on fix/hostname into 46b3401cba918a9c5fd3685b49cd84e0c5ae19f9 on master.


Convert documentation into Markdown

GTK documentation uses its own form of Markdown with some extensions for linking: https://developer-old.gnome.org/gtk-doc-manual/stable/documenting_syntax.html.en By converting this into Zig's Markdown format when translating, we can get nice integration with Zig's new Autodoc (which already works great with this project).
gi-docgen syntax should also be supported: https://gnome.pages.gitlab.gnome.org/gi-docgen/linking.html

Reopening because gtk-doc block comment syntax was missed. See gtk-3.0.Widget for an example of where this matters.


Performance Fix - Use col_ids during codegen of Index scan

Currently, the codegen of index scans in terrier/noisepage call the function col_oid_to_ids every time they have to fetch a tuple or operate on it. This PR, modifies that and generates the col_ids in TPL and directly uses them in the scan.

@rohanaggarwal7997 Do you have benchmark numbers for this?

No

I changed the description

After seeing the changes, I'm not really comfortable with breaking a clean abstraction of leaking the notion of col_ids up above the storage layer. We're basically caching the first part of the computation that the storage layer does by stashing the col_id vector in the layer above, and then still doing expensive computations at each IndexIterator::Init when we do the ProjectedRowInitializer creation.
It's a huge breaking of abstractions for what's likely less than 1% of on-cpu time.


push API for advection

The rotate lat/lon calculation is NOT implemented (#40)
Create spherical interpolation
Change CVTTrackingElmCenterBased into 3d version, directly use the target fields instead of dx.
Conversion between XYZ coords to Latlon coords
Add a spherical test mesh
Create a test  #file test/testFortranMPAdvection.f90 on push/MPs interpolation
Create a test file(test/testFortranCreateRebuildMPs.f90), and move create/rebuild MPs fortran test there.
Cleaning and naming changes(Lat_Lon => Rot_Lat_Lon)

Looks good to me (merged and deleted branch).


URGENT - Android Issue for InAppBilling - Partial Data

Bug Information
Version Number of Plugin: 1.2.4
Device Tested On: All Android Devices
Simulator Tested On: _
=== Visual Studio Community 2017 for Mac ===
Version 7.4.1 (build 48)
Installation UUID: 1488c34f-2fe3-4b7b-bc18-0b8125bff107
Runtime:
Mono <IP_ADDRESS> (2017-10/6bf3922f3fd) (64-bit)
GTK+ 2.24.23 (Raleigh theme)
Package version: 508010000

=== NuGet ===
Version: <IP_ADDRESS>45
=== .NET Core ===
Runtime: /usr/local/share/dotnet/dotnet
Runtime Versions:
2.0.5
2.0.0
2.0.0-preview2-25407-01
2.0.0-preview1-002111-00
1.0.1
SDK: /usr/local/share/dotnet/sdk/2.1.4/Sdks
SDK Versions:
2.1.4
2.0.0
2.0.0-preview2-006497
2.0.0-preview1-005977
1.0.0-preview2-003131
MSBuild SDKs: /Library/Frameworks/Mono.framework/Versions/5.8.1/lib/mono/msbuild/15.0/bin/Sdks
=== Xamarin.Profiler ===
Version: 1.6.1
Location: /Applications/Xamarin Profiler.app/Contents/MacOS/Xamarin Profiler
=== Apple Developer Tools ===
Xcode 9.2 (13772)
Build 9C40b
=== Xamarin.Mac ===
Version: <IP_ADDRESS> (Visual Studio Community)
=== Xamarin.iOS ===
Version: <IP_ADDRESS> (Visual Studio Community)
Hash: 3979d081
Branch: d15-6
Build date: 2018-03-09 16:22:34-0500
=== Xamarin.Android ===
Version: <IP_ADDRESS> (Visual Studio Community)
Android SDK: /Users/Shared/Android/sdk
Supported Android versions:
2.3    (API level 10)
4.0.3  (API level 15)
4.1    (API level 16)
4.2    (API level 17)
4.3    (API level 18)
4.4    (API level 19)
4.4.87 (API level 20)
5.0    (API level 21)
5.1    (API level 22)
6.0    (API level 23)
7.0    (API level 24)
7.1    (API level 25)
8.0    (API level 26)
8.1    (API level 27)
SDK Tools Version: 25.2.5
SDK Platform Tools Version: 27.0.1
SDK Build Tools Version: 26.0.1
Java SDK: /usr
java version "1.8.0_101"
Java(TM) SE Runtime Environment (build 1.8.0_101-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.101-b13, mixed mode)
Android Designer EPL code available here:
https://github.com/xamarin/AndroidDesigner.EPL
=== Xamarin Inspector ===
Version: 1.4.0
Hash: b3f92f9
Branch: master
Build date: Fri, 19 Jan 2018 22:00:34 GMT
Client compatibility: 1
=== Build Information ===
Release ID: 704010048
Git revision: 6a86203dd590c6cfdf814c8832d24d2ad1e2606f
Build date: 2018-03-20 11:16:55-04
Xamarin addins: 8d83cea9e4ae03cb0c14ba3fbaafdbb0cbd170e7
Build lane: monodevelop-lion-d15-6
=== Operating System ===
Mac OS X 10.13.4
Darwin 17.5.0 Darwin Kernel Version 17.5.0
Mon Mar  5 22:24:32 PST 2018
root:xnu-4570.51.1~1/RELEASE_X86_64 x86_64
=== Enabled user installed addins ===
Gorilla Player <IP_ADDRESS>
Internet of Things (IoT) development (Preview) 7.1
Steps to reproduce the Behavior
Debugging App when redirected to Subscription page.
Expected Behavior
Show Active Subscription Details correctly - along with price.
Actual Behavior
Gets Only ProductId & Name , Other Details not obtained. App Already registered in Play Store. Still same issue exists. Works fine in iOS.
Code snippet

### Screenshots
Debug Android -

Debug iOS -

@jamesmontemagno  @prashantvc
I debugged manually by adding the Source directly to the project and was surprised to see that
when
var x= new InAppBillingProduct();
is used, it's not initializing other properties like CurrencyCode, Description, LocalizedPrice, etc. Only items created are Name and ProductId.
After checking, I found that Linker Settings was Link All and Linker was aggressively removing other properties.
Adding Plugin.InAppBilling;Plugin.InAppBilling.Abstractions into Linker exclusion list helped.
Do you think adding Preserve attribute in Abstraction project would help?

how did you achieve to attach source code directly? I am not even able to do that. when I do that   Plugin.InAppBilling.InAppBillingImplementation.HandleActivityResult line is not recognized. I tried adding reference of  billing android project also but still doesnt work for me
 protected override void OnActivityResult(int requestCode, Result resultCode, Intent data)
    {
        base.OnActivityResult(requestCode, resultCode, data);
        Plugin.InAppBilling.InAppBillingImplementation.HandleActivityResult(requestCode, resultCode, data);

    }

@EmilAlipiev  What's the problem you are facing at first place?

When I try to attach the source code directly on my project, I am getting build error as below. not sure if that it something to do with Current Activity plugin

@EmilAlipiev Add Reference to All Projects except iOS project, uninstall the nugets which you had at first place.

For example, Nuget installation doesnt add reference of Plugin.InAppBilling.Android on my Droid project. how does it work using nuget?

@EmilAlipiev Nuget works with Bait and Switch https://log.paulbetts.org/the-bait-and-switch-pcl-trick/

I have followed these steps

uninstalled package from all projects

added references on android project

added reference on .net standard2.0 shared project

but it still doesnt recognize  Plugin.InAppBilling.InAppBillingImplementation.HandleActivityResult in my mainactivity.
that works fine if i just use nuget.

Check Plugin.InAppBilling.Android, it has Plugin.CurrentActivity nuget, this seems to be target version issue. Just update the nuget in it

it shows that it is installed fine. plugin has standard 1.6 version. i thought that this could be the issue but even upgrading to 2.0.1 didnt help me

Do you have any sample project maybe you achieve to attach it? i can compare this way

Closing for now as it was fixed up with linker. Will create a new issue to add preserve flags

<IP_ADDRESS>-beta


Question about dataset file split.json

Thank you for your excellent work! I have a small question about the released dataset.
Why is there always one fewer file under the 'extra' tag in the split.json file compared to the number of images that should be categorized as 'extra' in the images file?
For example in the spot scene, there are 10 images under the 'extra' tag in the split.json:

but there are 11 images in the images file that should be categorized as ‘extra’:

This issue also occurs in other quantitative assessment scenarios.

Thank you for bringing this to our attention. You are correct. After reviewing the data, I can confirm this inconsistency occurred during the very early generation of the 'extra' evaluation index.
To ensure fair comparison, all methods (including on-the-go) use the same data split. Please use the provided split file for evaluation and report the metrics based on that.
Best regards,
Weining


Add note to tutorial how to update myst-cli

Which area is this feature request for?
Other
Describe the feature you'd like to request
It would be nice to have a section in https://myst-tools.org/docs/mystjs/quickstart that describes how to update to the latest version of myst-cli. I think it's npm update myst-cli but I don't know npm so well, so I am not sure if this is the supposed way.
Also, there are some other versions showing from myst and mystjs which I people (or at least me :D ) might get confused by:
jan-hendrik@JanHendriksAir mystjs-minimal-example % npm view myst version
0.0.1-alpha
jan-hendrik@JanHendriksAir mystjs-minimal-example % npm view mystjs version
0.0.15
jan-hendrik@JanHendriksAir mystjs-minimal-example % npm view myst-cli version
0.1.17
jan-hendrik@JanHendriksAir mystjs-minimal-example %

Describe the solution you'd like
No response
Describe alternatives you've considered
No response

Hi @kolibril13 -- there is a section here:
https://myst-tools.org/docs/mystjs/installing#updating-myst
I wonder if you want to take a crack at moving this to the quickstart guide? I think it can be duplicated -- and if you want you can use the {embed} directive.
Let me know -- otherwise I can take a go at this early next week!

Hii @rowanc1,
Looking forward to that search field, that's the feature I use most when reading docs :)
Here is the pr: https://github.com/executablebooks/mystjs/pull/288
(I did not know how to use  {embed} there, so I just copied and pasted the content)
Also, it looks a bit unusual to have two installation guides, but I can see the reason why that's the case and I also don't have a better idea.

Nice, thank you! It is live!
https://myst-tools.org/docs/mystjs/quickstart#installing-the-myst-cli
Yeah, I agree on the two pages, I am not totally sure that we need the second one anymore at all. The only thing that doesn't have an alternative home is the latex install comments (which aren't very comprehensive anyways). My thinking was that we might have that as a troubleshooting guide/reference material that goes into a lot more depth than the quickstart.
It could also be something like "installing dependencies" or something and merge with the page below it? (latex, npm/node, imagemagik, inkscape).
If you have specific thoughts on how to improve this, always welcome PRs! :)
Agree, I miss search a lot ... it will get done!

I am going to close this specific issue! Thanks again for the PR.
And -- we should document the embed syntax @fwkoch, it is pretty cool. :)

troubleshooting guide/reference

sounds good, that would probably be a bit similar to an FAQ.
Maybe these resources can also be linked to at the end of the quickstart installation chapter.


can't recognize router using multiple middlewares.

I'm using Nodejs 16.13 and typescript.
// can't find
router.use('/:apiKeyId/monitor', [checkApiKey], monitorRouter);

// find
router.use('/:apiKeyId/monitor', checkApiKey, monitorRouter);

Hi @dontbesatisfied! Thank you for opening the issue.
I've tried to reproduce this problem here but I couldn't. Could you submit a sample project that reproduces this problem and send me the link?
That way is easier to identify and fix the problem.

(Further information about my test)
I've tried with the following code:
router.get('/path', [func1], func2);

function func1(req, res, next) {
    try {
        // ...
        return next();
    } catch(err) {
         return res.status(501).send("...");
    }
}

function func2(req, res) {
    // ...
    return res.status(502).send("...")
}

and the result was as expected:
    ...
    "/path": {
      "get": {
        "description": "",
        "parameters": [],
        "responses": {
          "501": {
            "description": "Not Implemented"
          },
          "502": {
            "description": "Bad Gateway"
          }
        }
      }
    },
    ...

Anything different you did, let me know.

Thanks for reply :)
Did you tried using typescript?

Hi @dontbesatisfied. No, I didn't. But if you are using typescript, no problem, you can make a sample project using it. Thanks!

This issue will be handled in the #150.


nixos-option does not support flakes

Describe the bug
Running nixos-option nix.nixPath fails because I don't have a nixpkgs entry in my NIX_PATH. This requires me to use my compatibility wrapper (https://github.com/cole-h/nixos-config/tree/c02cdf4702db3e383073426396dea31c40ae6e71/compat) with -I nixpkgs=compat; otherwise, the program aborts.
To Reproduce
Steps to reproduce the behavior:

nixos-option nix.nixPath without nixpkgs in NIX_PATH
Observe abort due to lack of <nixpkgs/nixos>

Expected behavior
I would expect a --flake flag, just like nixos-rebuild has, to be able to e.g. nixos-option nix.nixPath --flake .#hostname.
Notify maintainers
cc @Ma27 @chkno
Metadata

system: "x86_64-linux"
host os: Linux 5.8.7-zen1, NixOS, 20.09.20200912.ac8a276-cosmere (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 3.0pre20200903_8a945d6
channels(vin): ""
channels(root): ""
nixpkgs: /home/vin/.config/nixpkgs/compat

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: installer.tools.nixos-option

Yeah, I'm aware of that. The core problem is IMHO that nixos-option doesn't even compile with nixUnstable (IIRC).

Still important to me, but I've got somewhat of a workaround:
https://github.com/cole-h/nixos-config/tree/caac20b38db4e6d5127b11cb7728ff9ef97fb01b/compat
With the above folder layout, one can run nixos-option <option> -I nixpkgs=./compat and it should work +/- as expected.

Another symptom of this is:
nixos-option hardware.cpu.intel.updateMicrocode

terminate called after throwing an instance of 'nix::ThrownError'
  what():  The option `xdg.portal.wlr' does not exist. Definition values:
- In `/etc/nixos/configuration.nix':
    {
      enable = true;
    }
zsh: abort (core dumped)  nixos-option hardware.cpu.intel.updateMicrocode

system: "x86_64-linux"
host os: Linux 5.10.81, NixOS, 21.11 (Porcupine)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.4
channels(root): "nixos-21.05.4481.c5f1ee98224"
channels(nikolay): "nixpkgs-unstable-21.11pre310022.14b0f20fa1f"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

After fixing/updating channel to match system one.
I suspect that it should be possible to work-around it with a wrapper like
let
  nixosOptionsWrapper = pkgs.writeShellScriptBin "home-manager" ''
    exec ${pkgs.nixos-options}/bin/nixos-options -I "nixpkgs=$(nix flake metadata nixpkgs --json | ${pkgs.jq}/bin/jq -r '.path')" "$@"
  '';

(Not tried yet. I had such one for home-manager before switched it to Flakes completely)

nixos-option uses two expressions configExpr and optionsExpr https://github.com/NixOS/nixpkgs/blob/77d8adb8b98a160603a5457159d04935a15c82f4/pkgs/tools/nix/nixos-option/nixos-option.cc#L588-L589 which can be overridden by --config_expr and --options_expr https://github.com/NixOS/nixpkgs/blob/77d8adb8b98a160603a5457159d04935a15c82f4/pkgs/tools/nix/nixos-option/nixos-option.cc#L606-L609.
My flake is compatible with nix_2_3 via flake-compat https://github.com/adomixaszvers/dotfiles-nix/blob/b092ec237ff64fa975d90b43cc5345c3de239426/flakeCompat.nix and https://github.com/adomixaszvers/dotfiles-nix/blob/b092ec237ff64fa975d90b43cc5345c3de239426/default.nix so I could use nixos-option like this:
❯ export CONFIG_PREFIX='let flake = import ~/.config/nixpkgs; in flake.nixosConfigurations.raspberrypi-nixos'

~
❯ nixos-option --config_expr "${CONFIG_PREFIX}.config" --options_expr "${CONFIG_PREFIX}.options" nix.nixPath
Value:
[
  "nixpkgs=/nix/store/hkl03hpzvq0pj2qkc56485dd8fm27nng-source"
  "nixos-hardware=/nix/store/xmdajfhdaxc38kjymr7rdfdya6yv9r0s-source"
  "sops-nix=/nix/store/kmsf5s8pqha16cxmhqlsg81ld7chwzm3-source"
]

Default:
[
  "nixpkgs=/nix/var/nix/profiles/per-user/root/channels/nixos"
  "nixos-config=/etc/nixos/configuration.nix"
  "/nix/var/nix/profiles/per-user/root/channels"
]

Type:
"list of strings"

Description:
''
  The default Nix expression search path, used by the Nix
  evaluator to look up paths enclosed in angle brackets
  (e.g. <literal><nixpkgs></literal>).
''

Declared by:
[ "/nix/store/hkl03hpzvq0pj2qkc56485dd8fm27nng-source/nixos/modules/services/misc/nix-daemon.nix" ]

Defined by:
[ "/nix/store/xn9biv5gqcl8qhphpz72w50hn9ks8yl4-source/nixos/nix-registry.nix"

And it works with home-manager configurations too:
❯ export CONFIG_PREFIX='let flake = import ~/.config/nixpkgs; in flake.homeConfigurations.work'

~
❯ nixos-option --config_expr "${CONFIG_PREFIX}.config" --options_expr "${CONFIG_PREFIX}.options" home.stateVersion
Value:
"21.11"

Default:
"18.09"

Type:
"one of \"18.09\", \"19.03\", \"19.09\", \"20.03\", \"20.09\", \"21.03\", \"21.05\", \"21.11\""

Description:
''
  It is occasionally necessary for Home Manager to change
  configuration defaults in a way that is incompatible with
  stateful data. This could, for example, include switching the
  default data format or location of a file.
  </para><para>
  The <emphasis>state version</emphasis> indicates which default
  settings are in effect and will therefore help avoid breaking
  program configurations. Switching to a higher state version
  typically requires performing some manual steps, such as data
  conversion or moving files.
''

Declared by:
[ "/nix/store/g1gcxnf5whqzc72g63h0jai6if9fsp6b-source/modules/misc/version.nix" ]

Defined by:
[ "<unknown-file>" ]

It should be possible to make it less clunky by upgrading nixos-option code.

I did a wrapper to workaround this because bash is much simpler than C++
https://github.com/lucasew/nix-option
It has some rough edges but works fine

Here is the overlay I've used to make nixos-option work for flakes:
self: super: {
  nixos-option = let
    flake-compact = super.fetchFromGitHub {
      owner = "edolstra";
      repo = "flake-compat";
      rev = "12c64ca55c1014cdc1b16ed5a804aa8576601ff2";
      sha256 = "sha256-hY8g6H2KFL8ownSiFeMOjwPC8P0ueXpCVEbxgda3pko=";
    };
    prefix = ''(import ${flake-compact} { src = /etc/nixos; }).defaultNix.nixosConfigurations.\$(hostname)'';
  in super.runCommandNoCC "nixos-option" { buildInputs = [ super.makeWrapper ]; } ''
    makeWrapper ${super.nixos-option}/bin/nixos-option $out/bin/nixos-option \
      --add-flags --config_expr \
      --add-flags "\"${prefix}.config\"" \
      --add-flags --options_expr \
      --add-flags "\"${prefix}.options\""
  '';
}

Created a PR that adds this workaround optionally for those that want it: https://github.com/NixOS/nixpkgs/pull/258212

For those stumbling on this, I found a workaround:
nix eval /etc/nixos#nixosConfigurations.$(hostname).config.nix.nixPath
Also, it's possible to set your NIX_PATH to your flake with
nix.registry = lib.mapAttrs (_: value: { flake = value; }) inputs; # nix.generateRegistryFromInputs in flake-utils-plus

nix.nixPath = lib.mapAttrsToList (key: value: "${key}=${value.to.path}") config.nix.registry; # nix.generateNixPathFromInputs in flake-utils-plus # nix.nixPath is not available in HM
# or in HM
home.sessionVariables.NIX_PATH = (lib.concatStringsSep ":" (lib.mapAttrsToList (name: path: "${name}=${path.to.path}") config.nix.registry));

Funnily enough, yesterday I stumbled with https://github.com/NixOS/nixpkgs/issues/97855#issuecomment-1000815005.
Applying https://github.com/NixOS/nixpkgs/issues/97855#issuecomment-1075818028 as an overlay fixes the issue for me.

I think nobody mentioned yet that one can use nixos-rebuild repl instead


Support inline events declaration rz-slider-end="myFunc()" without using options object in js

Steps to reproduce
A common pattern in angularjs is to have an existing collection of business objects (from json) and bind the angular controls to them and their properties. E.g. if I already have 10 items in cart, and all textboxes, dropdowns, ranges etc work with them directly, why would I create 10 superficial options objects? The sliders are going to have identical options anyway, except for the business object.
<div ng-repeat="item in cart.items">
        <rzslider rz-slider-model-"item.price" rz-slider-end="processItem(item) />
</div>

rz-slider-end doesn't exist, and ng-change doesn't work without ng-model, and I typically need to pass the whole item object to the event handler, not just one property/value.
Expected behaviour
My rz-slider instances come from ng-repeat template and it's easier to instantiate them with inline attributes instead of separate js options objects.
Actual behaviour
I have to potentially declare multiple options object and assign them to multiple sliders which is problematic with templates.
Update:
I worked around the problem by creating a function that provides separate options object for each slider, but this feels backward and complicates the process of simply displaying items from json:
$scope.getSliderOptions = function(item) { return { onEnd: function() {$scope.processItem(item);}}}

<rzslider rz-slider-model="item.quantity" rz-slider-options="getSliderOptions(item)"

Whether you implement it or not, I'd like to thank you for this great component!

Hi @Ekus , thanks for submitting this clear issue.
The version 1.0 library was using this pattern but as you can see today in the options, there are so many. Thus, it was getting complex to handle all of them and provide realtime changes on these options. This is why we removed this API.
If you only need the onEnd event, you can create inline options:
<rzslider rz-slider-model="vm.priceSlider.value"
          rz-slider-options="{ onEnd: vm.processItem}"></rzslider>

vm.priceSlider = {
  value: 200
}

vm.processItem = function(sliderId, modelValue) {
  console.log(modelValue);
}

Demo: http://jsfiddle.net/6u9498u8/

Thanks for the clarification and the inline options solution! I haven't seen it mentioned in the documentation, maybe it's good idea to include it, or highlight it in some popular scenarios.
I still believe inline attributes and binding are what makes angularjs so friendly to designers and non-coders, but I understand the challenge (albeit I was hoping angularjs had a mechanism to automate it). Thanks for the reply!


Integrate AST exporter JSON plugin in the official clang repository?

Have you considered adding the ASTExporter.cpp in the clang repository itself?
Right now it is pretty tedious to install facebook-clang-plugins because it requires to recompile your own clang,
and to install it, and to override existing one. Wouldn't it be simpler if the plugin was already in clang
so we could just call the regular clang binary?

The AST Exporter is only used by Infer, and so this entire repo has been merged into the infer repo: https://github.com/facebook/infer/ and development continues there. We are planning on archiving this repo in the near future.
Because the AST Exporter is only used for infer, I don't think it would have high chances of getting into the clang repositories, but I could be wrong about that. Do you have another use for this plugin?

Yes I would love to leverage the clang AST from OCaml in semgrep: https://semgrep.dev/
See also https://github.com/returntocorp/semgrep

More generally any OCaml programmer who would like to to stuff on c++ would benefit from an easy-to-install OPAM library that can leverage clang C++ ASTs. Just like what CIL did for C 20 years ago
https://github.com/cil-project/cil

Not saying you shouldn't use this plugin (we use it in production and it works well), but have you looked at clangml? https://gitlab.inria.fr/tmartine/clangml

Oh no I didn't know about clangml! Thx! I'll have a look.


Revert "Live image cache"

Reverts flutter/flutter#50318
This broke some internal tests.
/cc @xster @jason-simmons

LGTM

/cc @goderbauer FYI


CLI version

Hello!
Could a CLI-only version be made available?
Would be usefull on small headless servers..
Thks!

The cli binary is on its way, but it might take some time.
The split into 2 binaries is complete, the GUI version works the same as before, but the CLI version is still an emtpy shell...
I have to design the commandline options now to allow you to configure the app first. You would start from a default config, where each option you specify changes a value in the existing config. No options would start thye app with the current (latest) config.
What do you think?

Well, the idea is to have a headless server running swyh-rs. The config file might be generated via a desktop-enabled computer on the same network to serve as a base for the cli version, which could be quiet sufficient to fulfill the goal. That could be a good hassle-free start?

You'll be able to generate the config file settings with commandline options. And this will be persistent, so once the config is to your liking you can run without any options. At least that is what I'll try to implement.

The cli version is working now, I'll prepare an new release later today or tomorrow.
Only thing missing: autoreconnect to the last used player if you don't specify a player on the commandline.
Everything is controlled with command line options:
swyh-rs-cli.exe -p 5901 -l info -s 1 -i 10 -b 16 -r false -a true -d true -u true -o <IP_ADDRESS> -e <IP_ADDRESS> -f flac -h

Recognized options:
    -h (--help) : print usage
    -c (--config_id) string : config_id [_cli]
    -p (--server_port) u16 : server_port [5901]
    -a (--auto_reconnect) bool : auto reconnect [true]
    -r (--auto_resume) bool : auto_resume [false]
    -s (--sound_source) u16 : sound_source index [os default]
    -l (--log_level) string : log_level (info/debug) [info]
    -i (--ssdp_interval) i32 : ssdp_interval_mins [10]
    -d (--disable_chunked) bool : disable_chunked encoding [true]
    -b (--bits) u16 : bits_per_sample (16/24) [16]
    -f (--format) string : streaming_format (lpcm/flac/wav) [LPCM]
    -o (--player_ip) string : the player ip address [last used player]
    -e (--ip_address) string : ip address of the network interface [last used]

Args { config_id: None, server_port: Some(5901), auto_resume: Some(false), sound_source_index: Some(1), log_level: Some(Info), ssdp_interval_mins: Some(10.0), auto_reconnect: Some(true), disable_chunked: Some(true), use_wave_format: None, bits_per_sample: Some(16), streaming_format: Some(Flac), player_ip: Some("<IP_ADDRESS>"), ip_address: Some("<IP_ADDRESS>") }

You can try the new prerelease 1.7.0-beta

The new 1.7.0 CLI version is now released, so I'll close this.
If you have any problems using it please open a new issue.


Explicit local variables

🚀 Feature
Currently we have no way to explicitly define variables local to an op. They must either be defined as inputs/outputs or implicitly via binding a variable to a container file/dir/socket. This is limiting because it means we have to create a container simply to define (or set) a variable. It's also limiting because we can't specify the data type or constraints.
Pitch
Example (assumes https://github.com/opctl/opctl/issues/899, https://github.com/opctl/opctl/issues/898, and https://github.com/opctl/opctl/issues/900 to show the synnergy)
name: echoer
inputs:

  # this is an input variable of type string
  - name: whoToGreet
    description: who shall we greet?
    string: {}

run:
  serial:

    # this is a local variable of type string
    - name: greeting
      description: The greeting to echo
      string:
        default: Hello $(whoToGreet)!

    - name: echo
      description: This container echoes a greeting to the caller!
      container:
        image:
          ref: alpine
        cmd: [echo, $(greeting)]

How does whoToGreet get set?

How does whoToGreet get set?

It's an input variable so it's set by the caller (CLI, API client, etc..)

How does whoToGreet get set?

It's set in the defined input


feat: add email to connector form

Checklist

[x] Manual verification
[ ] Unit test coverage
[ ] E2E test coverage
[ ] Needs manual QA?

Summary
Adds a email field for the request a connector form.
No validation on input as of now.

Closes #4010


Jenkinsfile: Run steps in parallel

Instead of deploying SES, then CaaSP, then ..., do steps in parallel
where possible.
This should speedup the CI runs a lot.

Does this need anything from https://github.com/SUSE-Cloud/socok8s/pull/145 or is this an alternative approach?

Does this need anything from #145 or is this an alternative approach?

I think this is a different thing. Not sure if we need something from #145

Seems to be always failing with:
msg: Timeout waiting for the floating IP to be attached.

See https://ci.suse.de/blue/organizations/jenkins/cloud-socok8s%2Fsocok8s/detail/PR-310/6/pipeline/34#step-43-log-354

Would it be possible that the whole job fails once any of parallel step fails?

https://ci.suse.de/blue/organizations/jenkins/cloud-socok8s%2Fsocok8s/detail/PR-310/18/pipeline/  succeeded. The subsequent failure of the later job was unrelated.


ec2-amis.nix: add 19.09 amis

also replace /home/deploy -> $HOME to allow running the script from outside
the bastion.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @NixOS/backports @edolstra

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/what-is-the-process-for-publishing-the-official-nixos-amis/4581/2

Backported in d0770296475


Login, user.csv file not existing

When loging in, getting an error of file not existing

@Retr0gr fixed this on #6


Make sure it's legit to use Engine API

On driver startup, I use the Docker Engine API to inspect all containers and see if they're using my driver, and add it to the internal reference if it is.
I'm not 100% sure this is "appropriate," but I have no idea how else to do it, so here we are!

Pretty sure this is okay

Nope. Not okay on startup! Falling back to a file-based solution.


appKeyPrefix undefined value

Motivation
Follow up PR for #927
Description
It fixes issue https://github.com/near/near-api-js/issues/325
Checklist

[ ] Read the contributing guidelines
[ ] Commit messages follow the conventional commits spec
[ ] Performed a self-review of the PR
[ ] Added automated tests
[ ] Manually tested the change

Is the original issue from 2020 that seeing the undefined prefix on their LocalStorage keys is potentially discomforting to users? If the entire purpose of the prefix is to differentiate between keys on another wallet on the same domain (😱) then replacing it with default  doesn't do anything to alleviate the collision problem.
Mutating live LocalStorage keys carries some risk that we should be very critical about taking on, especially given that this mutation would need to remain indefinitely for future compatibility. @MaximusHaximus and I discussed instead adding a breaking change which requires a prefix, and communicate that "undefined" will need to be explicitly passed in order to avoid invalidating user keys. This gives control over the change to the WalletConnection consumers and spares NAJ the burden of needing to mutate keys forever.
Overall though I don't think this issue is anything other than cosmetic, given that we cannot retroactively force consumers to use a unique key. I don't believe it's worth taking on the risk of mutating LocalStorage keys indefinitely to make LocalStorage key names more palatable.

Good points all around. I'll open another PR that throws if no appKeyPrefix is passed in and we can close this in favor of that solution. The minority of users that were doing
new WalletConnection(near)

will now have to do
new WalletConnection(near, "undefined")

If they want to access the keys they had potentially accumulated

Alternative solution implemented in #1014


Gateway discover problem after update from loraserver 2.5.0 to 2.6.0 and lora-app-server to version 2.5.1

I have 3 gateways with the 2.5.0 version of the LoraServer all 3 gateways were seen with Gateway discovery, updating to the 2.6.0 and 2.5.1 lora-app-server version are seen only in pairs.

in debug loraserver view a error:
time="2019-03-22T10:09:17+01:00" level=info msg="gateway/mqtt: publishing downlink frame" qos=2 topic=gateway/001bc506702009a9/tx
time="2019-03-22T10:09:17+01:00" level=info msg="finished unary call with code OK" grpc.code=OK grpc.method=SendProprietaryPayload grpc.service=ns.NetworkServerService grpc.start_time="2019-03-22T10:09:17+01:00" grpc.time_ms=0.898 peer.address="<IP_ADDRESS>:55332" span.kind=server system=grpc
time="2019-03-22T10:09:19+01:00" level=info msg="gateway/mqtt: uplink frame received"
time="2019-03-22T10:09:20+01:00" level=info msg="finished client unary call" grpc.code=OK grpc.method=HandleProprietaryUplink grpc.service=as.ApplicationServerService grpc.time_ms=9.325 span.kind=client system=grpc
time="2019-03-22T10:09:20+01:00" level=info msg="backend/gateway: downlink tx acknowledgement received" gateway_id=001bc506702009a9
time="2019-03-22T10:09:20+01:00" level=info msg="gateway/mqtt: uplink frame received"
time="2019-03-22T10:09:20+01:00" level=info msg="gateway/mqtt: uplink frame received"
time="2019-03-22T10:09:20+01:00" level=error msg="finished client unary call" error="rpc error: code = Internal desc = handle received ping error: get ping lookup error: get ping lookup error: redigo: nil returned" grpc.code=Internal grpc.method=HandleProprietaryUplink grpc.service=as.ApplicationServerService grpc.time_ms=0.981 span.kind=client system=grpc
time="2019-03-22T10:09:20+01:00" level=error msg="handle proprietary up error" error="rpc error: code = Internal desc = handle received ping error: get ping lookup error: get ping lookup error: redigo: nil returned"
time="2019-03-22T10:09:21+01:00" level=info msg="gateway/mqtt: gateway stats packet received" gateway_id=001bc506702009a9

I expect this has been fixed by v2.6.1 :-)


Alerted word of website does not return results, search on same term does

When I search for https://mywebsite.net and mywebsite.net I find recent messages mentioning my site or specific URLs in it.
I've added https://mywebsite.net and mywebsite.net to my Alert words. However, is:alerted (myzulip.com/#narrow/is/alerted) does not return these messages.

I would be great if they are returned there too, so I can monitor when anyone needs help with my site. Thanks!

@wardweistra Is it only the is:alerted view that's broken here?  Or are the alert words just not being recognized in general?  For example, does mywebsite.net show up with the typical styling for alert words when somebody sends you a message?

@showell Here's a test case to get some better answers:
I've set test, test.com and https://test.com as alert words.
Then I sent myself the message: "This is a test message about the website test.com, which can be found at https://test.com which contains the page http://test.com/banana, also known as test.com/banana" (I highlighted the hits I would expect, but they're plain text without markup in Zulip)
It shows in my conversation as:

Only the word test and the exact match of https://test.com seem to match.
Same when looking at the message in is:alerted.
(Below I've removed the alert words again, not to confuse what causes highlighting)
However, searching for test.com nicely hits all the mentions:

Even though the same alert word does not hit.
Interestingly searching for https://test.com or http://test.com or https://test.com/ give the exact same result. I guess that's being stripped.
Searching for test.com/banana finds the message:

Strangely it also highlights the other test.com mentions in the message, but other messages with test.com or test.com/somethingelse are not returned.
It also does not return a message with http://test.com/banana/something.
And a search for exact http://test.com/banana/something does not return a message with http://banana.com/?url=http://test.com/banana/something

I suspect the issue here is that the ahocorasick.Automaton algorithm we're using is not configured to consider punctuation characters.  @benneyman do you know if we could support having punctuation in alert words easily here?

This seems related to #24395.


Update matryoshka-core to 0.18.4

Updates com.slamdata:matryoshka-core from 0.18.3 to 0.18.4.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.slamdata", artifactId = "matryoshka-core" } ]

labels: library-update, semver-patch

Closing in favor of #4527


erro Unresolved reference: chip

Problem
<what's wrong or missing, please include any applicable:

Click Make Project in Android Studio to build Android CHIPTool
Unresolved reference: chip

Proposed Solution
<suggested fix, suggested enhancement>

@hainahouwei Did you follow the steps described in https://github.com/project-chip/connectedhomeip/tree/master/src/android/CHIPTool? It seems you haven't built the CHIP controller JAR before builting the CHIPTool project.

Hi @Damian-Nordic @hainahouwei ,
I have encountered the same problem, therefore I would like to check if this issue has any progress?
I do have followed the the steps described in https://github.com/project-chip/connectedhomeip/tree/master/src/android/CHIPTool, but still, the build is failed.
Attach the screenshot fyi:

I noticed that you mentioned the CHIP controller JAR , may I know which file/command you were referring to, I did not see it on the README.md?
Many thanks!

scripts/examples/android_app.sh should generate CHIPController.jar and SetupPayloadParser.jar, and copy them to src/android/CHIPTool/app/libs.
It looks like you're missing these jars, resulting in the unresolved reference errors.  Can you check if those jars are there?

I just ran into this also. The problem is in the Android build instructions. If the environment is not bootstrapped the android_app.sh script fails.

Check out the CHIP repository.

1a) Bootstrap it.  source scripts/bootstrap.sh

In the command line, run the following command from the top CHIP directory:

TARGET_CPU=arm64 ./scripts/examples/android_app.sh
See the table above for other values of TARGET_CPU.

Open the project in Android Studio and run Sync Project with Gradle Files.

Use one of the following options to build an Android package:

Click Make Project in Android Studio.

Run the following command in the command line:
cd src/android/CHIPTool
./gradlew build

Makes sense, bootstrap is required before we build anything in CHIP. I will update the docs.

-->>>> 1a) Bootstrap it. source scripts/bootstrap.sh gives us error,

Hi @austinh0
where is the location of CHIPController.jar and SetupPayloadParser.jar
i have follow in https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/android_building.md
but still not see  CHIPController.jar and SetupPayloadParser.jar

CHÀO@austinh0 vị trí của CHIPController.jar và SetupPayloadParser.jar ở đâu
tôi đã theo dõi trong https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/android_building.md nhưng vẫn không thấy CHIPController.jar và SetupPayloadParser.jar
I'm also having the same error as you, I've run the command TARGET_CPU=x64 ./scripts/examples/android_app_ide.sh many times but it still doesn't have .jar files in the android/CHIPtool/app/lib/ folder. Do you have a solution yet?

jonsmirl@ares:~/aosp/esp-matter/connectedhomeip/connectedhomeip$ ls ./examples/android/CHIPTool/app/libs
AndroidPlatform.jar  CHIPClusters.jar    jniLibs            libMatterTlv.jar       README.md
CHIPClusterID.jar    CHIPController.jar  libMatterJson.jar  OnboardingPayload.jar

I still have the problem that it doesn't create .jar files after running the set_target command


Chef Guidebook

About the PR

Adds a Chef and (basic, non-updating) Mix + Recipe Guidebook.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Added Chef Guidebook

cheese is made of milk not soy milk!!!!!!!!!!!!


change Color

Can we change color of the scroll bar . i would like to have the color of material themes .
is this possible ?
if so Please suggest on how that can be achieved

Hi @deephakdd,
All the CSS can be overriden or you can even make your own custom CSS to completely modify the apparence of the scrollbar.
Use the original documentation of Malihu Scrollbar available here: Scrollbar styling & themes
Let me know if you have any further question.

@deephakdd as a follow up, have you been able to customize the scrollbar?

I am closing the issue but feel free to reopen if you still need assistance on customizing the scrollbar.

hi ,
Thanks for the reply . i was able to override by changing in the jquery.mCustomScrollbar.css
i just have a small doubt ,
can i not simply override your classes in my css file?
i dont want to use jqery so i cant create a custom theme
thanks once again for the reply

@deephakdd yes you can override the CSS it should work out of the box.


How to execute 9.10 Visual Inspection and Attestation Test cases on Inferno ?

Hello,
Can you please brief us about the process of  9.10 Visual Inspection and Attestation test case on inferno testing tool.

Those are the requirements that Inferno could not test automatically. You need to talk to your proctor to figure out how to test those items.

@yunwwang , Thank you for quick response. We will communicate further with our proctor.


Set DYLD_LIBRARY_PATH to test with the just-built stdlib

With Swift in the OS, we need to ensure that the test suite runs with
the standard library we just built, instead of the one form the
operating system. We do this by telling dyld to pick the one from our
build directory by setting the DYLD_LIBRARY_PATH. Swift takes the same
approach in their test suite.

@swift-ci please test

Does this not work at all at the moment, or only for some tests?
I wonder if it would be better to put this into the lit/lit-lldb-init file we are passing to every lldb instance.

I wonder if it would be better to put this into the lit/lit-lldb-init file we are passing to every lldb instance.

That's exactly what this patch does :-) Maybe I'm misunderstanding the question?


Query Without Opening Skill Functionality

Hi,
I was wondering how (if it's possible) to handle user intents that don't require the formal opening of a skill through flask-ask. What I mean is this type of requests:
"Alexa, ask <skill_name> what  is.
For example, "Alexa, ask Stockify what the current price of Apple Stock is."
or, "Alexa, ask Fitness Tracker how far I've run today."
So these are questions a user may ask Alexa without explicitly launching the skill (ie. without "Alexa, start memory game").
Best,
Max

That's the normal behavior for a lot of skills, if I'm understanding your question.
For example, if you say "open MySkill" or "start MySkill" (and you don't have a session open or any kind of data persistence going on), you'll hit the LaunchRequest intent. Mine gives some helpful hints about what you can ask for/say. (As the voice design guidelines suggest.)
If you say "ask MySkill to do X" then it will route directly the intent for X based on your Utterances. I.e. you don't have to first say "start MySkill". The act of matching an Utterance and sending an Intent implicitly triggers the skill and gives it the right information for Flask-Ask to route it to your specific intent.
If you're saying you don't want to say "ask MySkill" at the beginning, then you have to either have an open session (like being in the middle of your example game skill), or be one of the special integrations (like for smart home stuff) that can handle bare commands like "Alexa turn off living room lights".
Does that help?

Yep! I just mishandled something because I thought the launch function is always called, but as you said it maps straight to the intent!
Thanks for your response!


Add displayName and classDisplayName to TestDescriptor

This fixes https://github.com/gradle/gradle/issues/4424
https://github.com/gradle/gradle/issues/4423
JUnit 5 introduces @DisplayName and dynamic tests, which allows users to
customize test case and test class' name. This should be taken into
account. This PR introduces displayName and classDisplayName which are
used for display. When rendering HTML reports, these two fields will be used.
It's a large PR, but I very much want this to be into 4.6. To make this change backward-compatible and not cause regression, I did many defensive work, e.g. add overload method signature to guarantee public API unchanged.

Here're 2 screenshots of the HTML reports. "Display name" supersedes "name" and "name" is put into title attribute of HTML tag.

We should not do this for 4.6, the risk is of introducing late regressions is too high and it's only an aesthetic issue.

OK. I'll make it targeted to 4.7.

@oehme TestNG does support display name but that's quite tricky: https://stackoverflow.com/questions/15220262/custom-test-method-name-in-testng-reports
Since we're trying to keep this change backward-compatible, I'd say let's keep TestNG part as it is unless users complain or request.

Some things I want to check on.
The calls to removeParentheses are all this one correct?
I just want to make sure that tests with names like this one won't have parentheses stripped out.
@Test
fun `🦆 ~|~test with a really, (really) terrible name & that needs to be changed!~|~`() { }

@JLLeitschuh removeParentheses only remove trailing parentheses, the purpose is to make legacy test case compatible with JUnit 5. For example, legacy test assertTestPassed('TestClass','testMethod') will fail on JUnit 5 because JUnit 5 Vintage output name is testMetho().

I thought about the class name issue some more and I think we should display it properly (not hidden in a tooltip). The reason is IDE integration: When the user sees a failed test case in the report, they might want to copy-paste the name of the test class into the "Find Type" search box in the IDE. If we only show the display name, that would not be possible. So I think showing the simple name in addition to the display name would be a good idea.

Now the test case name is displayed in a particular format:

WDYT? @oehme @eriwen

I think we should reverse the heading - Show the display name on top and the class name in the breadcrumb.
For the test methods I'd probably add a dedicated Method name column. The current styling looks pretty distracting to my eyes.

I think we should reverse the heading - Show the display name on top and the class name in the breadcrumb.

Yes, that's better.

For the test methods I'd probably add a dedicated Method name column. The current styling looks pretty distracting to my eyes.

Actually I already tried that extra column, and personally I like this way more. I'm okay with both solutions, so we can do that if you prefer.

If we stay with a single column we need to improve the styling. Right now it looks very distracting.

If the display name and the technical name aren't identical, the extra column will emerge:

@oehme @bmuschko If you don't have more suggestion on it, I'll merge this PR.

Just stumbled upon this. Why does the value of classDisplayName default to the class's simple name for JUnit but FQCN for other runners, for instance Spock? Shouldn't it be consistent and always default to the FQCN if the @DisplayName annotation isn't available?


Messaging: Setup Firebase SDK backend

Setup a backend which will call Firebase SDK to send notifications
This backend should be accessible via API

Here are the different parts of the backend that have to be set up:

Lambda that can send messages to topic(s) or user(s) (Complete)
Authorizer Lambda that verifies that the person sending the message has the correct permissions
Table(s) containing message-sending permissions
Firebase token registration API to associate user IDs with Firebase push tokens

Done and ready for review.


Increasing version of rqt_image_view in kinetic

Increasing version of rqt_image_view in ROS kinetic from 0.4.11-0 to 0.4.13-0

0.4.13 (2018-05-02)

add build dependency on Qt5 dev package

0.4.12 (2018-05-02)

save and restore the smooth image check box state
allow image rotation in 90° steps
use Python distutils to install the global rqt_image_view executable

This package has not been bloomed for kinetic at this version so we cannot accept this PR.
I also noticed that you do not appear to be listed as a maintainer of this package. Has this proposed update been reviewed by the package maintainers? It's typical for new releases to be made by one of the maintainers.

@dirk-thomas : Is it possible to increase the version of rqt_image_view also in the kinetic distribution?

Is it possible to increase the version of rqt_image_view also in the kinetic distribution?

Sure, done in #18394.

Perfect, many thanks @dirk-thomas !


Pie chart not rendering in the latest master release, even when data is there

Make sure these boxes are checked before submitting your issue - thank you!

[X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version
Trunk version 6e79e84b025259f5741a04f69b79360404872c5c
Expected results
Pie chart should render
Actual results
Pie chart does not render, while the explore_json end point does return valid x/y data.

Javascript errors in browser (Chrome 73.0.3683.86, Also repro's in Safari)
I see these errors:
Uncaught TypeError: Cannot read property 'tickFormat' of undefined     at Object.generate (3.9e5517691a3754ec100e.chunk.js:2)     at e (2.425a345ff22d808395dd.chunk.js:1) /superset/explore/?form_data=%7B%22datasource%22%3A%22145__table%22%2C%22viz_type%22%3A%22pie%22%2C%22url_params%22%3A%7B%7D%2C%22granularity_sqla%22%3A%22secondsSinceEpoch%22%2C%22time_grain_sqla%22%3A%22P1D%22%2C%22time_range%22%3A%22Last+week%22%2C%22metric%22%3A%22count%22%2C%22adhoc_filters%22%3A%5B%5D%2C%22groupby%22%3A%5B%22fare_insight_codes%22%5D%2C%22row_limit%22%3A1000%2C%22pie_label_type%22%3A%22key%22%2C%22number_format%22%3A%22.3s%22%2C%22donut%22%3Afalse%2C%22show_legend%22%3Atrue%2C%22show_labels%22%3Atrue%2C%22labels_outside%22%3Atrue%2C%22color_scheme%22%3A%22bnbColors%22%7D:1 Unchecked runtime.lastError: The message port closed before a response was received.
The minified JS file above looks like this (just the portion in the console stack trace):
Tt.x2Axis && Tt.x2Axis.tickFormat && Tt.x2Axis.tickFormat(H),                 !e(["dist_bar", "box_plot"]) && Tt.xAxis && Tt.xAxis.tickFormat ? Tt.xAxis.tickFormat(H) : Tt.xAxis.tickFormat(function(t) {                     return t.length > k ? t.substring(0, k) + "…" : t                 })
Steps to reproduce

Just group by on a column and choose a pie chart visualization.

Other notes
I tested that the Sunburst chart works just fine. But its troublesome that Pie chart is not working.

Hi @kristw ... any idea when this might be fixed. Seems like a pretty basic bug if something like Pie Chart itself is not rendering. How do you guys work around this at AirBnb ? Is there a special branch I should be on instead of trunk ?

This should be fixed by
https://github.com/apache-superset/superset-ui-plugins/pull/36
which is released with<EMAIL_ADDRESS>We need to bump the version of the chart in master.

I think this is fixed in the lyftga branch

I also faced with this issue, was it fixed for you @agrawaldevesh ?

I haven't updated my branch yet to test out whether it works on the latest master. I am anxiously waiting for the lyftga branch to be merged in to test then whether we have a fix for this.


Add datetime TicketLock in Events and prevent ticket-generation after the ticketlock

Since the app now is live and we have had some problems with migrations, we maybe should consider if there is any alternate methods to achieve this functionality without changing the tables.
A suggestion would be if we decide that all ticket-sales always end 2 days before the actual event, we could simply use the already provided start DateTime to attribute to determine when ticket-generation should be blocked.

Currently start & stop in Event is strings and thereby requires us to check if it is convertible to DateTime before inserting.

Add a block to delete ticket so that it can´t be removed less than 48h before the event.


Ghosting in 3D rendering

open in Microsoft Edge/113.0.1774.42

@934556826 - did you try other browsers?
Thanks for providing info on the browser you are using.   I can confirm that this happens in that version of Microsoft Edge.    Additionally, this is now also happening in my version of Chrome:
This issue is the same as this previous report that was closed:
https://github.com/Kitware/glance/issues/472


About the new version

Hi, Thanks for your work and I find some files were updated, such as 03_generate_rnn_data.py and 04_train_rnn.py . Is it because the previous file has an error? (Because I ever used the files that has not updated to train my agent.) And I read the updated code and find they are almost the same except that RNN can predict reward now. Is it right?

I revised it and it can work.


Could not find a version to edit for app 'AppName'

We didn't changed our build settings and this error
[!] Could not find a version to edit for app 'AppName'
appeared since yesterday.
Can this be related to the recent update to itunesconnect?
Is this related to fastlane or this tool?
itunesconnect deliver: 2.11.0
fastlane: 2.97.0
deliver 2.96.1 Summary

Hi @Gregoirevda ,
without the build log its hard to identify the issue.
However it seems Fastlane has a similar issue: https://github.com/fastlane/fastlane/issues/1517,
it seems defining the app_version input on deliver solves the issue. This input of deliver is not wired in as a step input, but the step has an input: Additional options for deliver call which you can use to define this option.

Note that this doesn't occur if you set skip_app_version_update  to false


feat(wip): masonry

This PR resolves PHIRE-3
Description
See https://github.com/artsy/palette-mobile/pull/138 description is a WIP still

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against 1129c5015c68583df6d264d30b059a487d586fac

boss 🔥🔥


Random dying of the game

I have random errors when a player is logged in.
With the following patch I was able to fix it:
diff --git a/boids.lua b/boids.lua
index 2ad78aa..a0e1e9f 100644
--- a/boids.lua
+++ b/boids.lua
@@ -109,7 +109,7 @@ function creatura.get_boid_dir(self)
 	local boid_pos
 	local closest_pos
 	for _, object in ipairs(boids) do
-		if object then
+		if object ~= nil then
 			boid_pos, vel = object:get_pos(), vector.normalize(object:get_velocity())
 			if boid_pos then
 				local obj_yaw = object:get_yaw()
--
2.39.2

I also had it dying with that fix so I added if object and object ~= nil then

Now I have it made not to die anymore:
diff --git a/boids.lua b/boids.lua
index 2ad78aa..a5824e3 100644
--- a/boids.lua
+++ b/boids.lua
@@ -109,7 +109,7 @@ function creatura.get_boid_dir(self)
 	local boid_pos
 	local closest_pos
 	for _, object in ipairs(boids) do
-		if object then
+		if object and object ~= nil and object:get_velocity() ~= nil then
 			boid_pos, vel = object:get_pos(), vector.normalize(object:get_velocity())
 			if boid_pos then
 				local obj_yaw = object:get_yaw()

if object and object:get_velocity() then [...]
... is probably fine, could also use get_pos() or any other objref method.
see https://rubenwardy.com/minetest_modding_book/en/quality/common_mistakes.html#be-careful-when-storing-objectrefs-ie-players-or-entities

Were these random errors like mine?
"ERROR[Server]: An unhandled exception occurred: C++ out of memory"
in draconis
maybe they are related?


Start SQL Script over several SQL servers

Hello,
a question I haven't figured out yet. In SSMS I can run one SQL over several SQL servers or all SQL servers of a group.
How does this work with Azure Data Studio?
If this is not yet possible, I would like to see it. This function is extremely helpful.

This functionality isn't currently implemented in ADS unfortunately. I'll be closing this as a duplicate of https://github.com/microsoft/azuredatastudio/issues/28 - you can follow that for any updates in that area


No cmake option to build shared library

Dear Developers,
It would be great if you added a feature to build SIRIUS with cmake as a shared library.
Thank you in advance.

Hello,
thank you for your request!
The cmake in branch build_shared_library, link, builds both static and shared (libsirius.so) libraries by default. Note that there is only a library if either CUDA or Fortran bindings are activated, otherwise SIRIUS is header only. E.g. to build the shared library containing the CUDA kernels and the Fortran bindings use the following flags for cmake (default for both CUDA/Fortran is Off)
cmake -DCREATE_FORTRAN_BINDINGS=On -DUSE_CUDA=On -DCMAKE_INSTALL_PREFIX=/install/path /path/to/SIRIUS

We will remove the branch as soon we merge it into develop or master.

Thank you!


How does it compare with Rocket.Chat?

I think rocket.chat is far far further with features and development than space.talk. And honestly my favorite was a spacetalk

Rocket.chat has chosen to be more of a Slack clone, SpaceTalk is investigating patterns that differentiates it from being another clone just like that. This is my view of the matter.

I just want to emphasise that "Rocket.chat has chosen to be more of a Slack clone" is @timbrandin personal "view of the matter" and not at all shared by the Rocket.Chat team :)
You can enter our https://demo.rocket.chat and talk to the team if you want our long plan.

I should also advice @engelgabriel to stop harassing me on joining their project, also this is not the place to advertise another application.

Sorry, I though @mitar specifically mentioned Rocket.Chat on the question.

This is a pretty non-constructive comparison and really not helpful. :-(


[WIP][pilot] improve/correct error message on beta submit

Motivation and Context
Had a report of pilot beta submission saying "already submitted for review" when not submitted. Looks like error handling and message output needed to be better.
Description

uploaded_build.ready_for_beta_submission? didn't necessarily mean it was already submitted
Doing separate check for "waiting for review" and "beta approved"
Throwing user error if other state and showing the state error

Testing
Update Gemfile to 👇 and run bundle install, bundle update fastlane, or bundle update
gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "joshdholtz-pilot-improve-beta-submit-error"

          1 Warning

:warning:
Pull Request is Work in Progress

  Generated by :no_entry_sign: Danger


Where are the logs ?

Hello,
I was looking for the logs after a problem on my server, I looked in the documentation but I did not find anything.
So my question is "simple", where are the logs located ? Is it possible to configure them ?
Deployment method

[ ] Docker Compose
[ ] Kubernetes
[ x] GoDojo

Environment information

Operating System: Ubuntu 20.04
DefectDojo version: V2.4.1

Thanks.

The logs of the install are written to the 'logs' directory in the same location/directory that godojo was run in.
So, if you run godojo in /opt/godojo, the logs would be located in /opt/godojo/logs:
# pwd
/opt/godojo
# tree
.
├── dojoConfig.yml
├── godojo
├── logs
│   ├── cmd-output_1644908712465994339.log
│   └── dojo-install_1644908712465994339.log
└── runtime-install-config.yml

1 directory, 5 files

If you mean the logs from DefectDojo, then that would depend on how you launched DefectDojo after doing the install.
If you used the example start and stop scripts at https://github.com/DefectDojo/godojo/tree/master/docs-and-scripts then the logs would be in the screen sessions for the various parts of DefectDojo (Django, celery worker, celery beat)
If you fronted the install with Apache or Nginx, the logs would be where they were configured for that services.  Same goes for the database used by DefectDojo - usually /var/logs in most Linuxes.
If you wrote a service file for systemd, then you'll use the systemctl and journalctl commands to get the logs.
The old documentation files have examples which may work for systemd service files that might be useful examples.  I wrote those originally but that was years ago:
https://github.com/DefectDojo/Documentation/blob/master/docs/running-in-production.rst
HTH

Hello @mtesauro,
Thank you for your reply.
Yes I used this solution:
If you used the example start and stop scripts at https://github.com/DefectDojo/godojo/tree/master/docs-and-scripts then the logs would be in the screen sessions for the various parts of DefectDojo (Django, celery worker, celery beat)
But even with these information I have no idea where are the logs, I tried to add -L -Logfile ... to the scripts but even with that it does not work, I have no logs appearing.
After that I tried to add -f celery-worker.log to the celery script, but I still have no logs, is it possible to add a script or something else to have all logs in one folder ? (/var/log/dojo/ for example) ?
Or the place where I can find the logs.
Btw, I also tried the command screen -S worker, to go in the screen, but even with that I have no idea where the logs are.
Thank you.
Best regards.

So, in the case of those scripts, the "logs" are written to stdout (standard out) and that output is "written" to the screen session so there's not really a great way to look back at them.
If you want them written to disk, you could either create a service file like I mentioned above (see here) or a quick and dirty method would be to redirect the commands in the screen sessions to a file.  For example, you could change the command at https://github.com/DefectDojo/godojo/blob/master/docs-and-scripts/dojo-start#L16 to:
screen -S worker -D -m /bin/bash -c 'source /opt/dojo/bin/activate && C_FORCE_ROOT="true" celery -A dojo worker -l info --concurrency 3 >> /opt/dojo/logs/celery-worker.log'
Warning: The command ^ line wrapped - its a single line. The same as the link above with " >> /opt/dojo/logs/celery-worker.log" added.
You'll need to validate that works. I've not tried recently - before docker-compose, I used that 'hack' to get logs out of Defectdojo years ago.  You'll also need to make sure that the directory and file permissions allow the user running the dojo-start script to write to that directory - in my example /opt/dojo/logs.
If you add those 'append to a file' parts to the 3 screen commands in dojo-start (lines 16, 19, 26) you can get logs from celery-worker, celery-beat and DefectDojo/django for example:
line 16 add  >> /opt/dojo/logs/celery-worker.log
line 19 add  >> /opt/dojo/logs/celery-beat.log
line 26 add  >> /opt/dojo/logs/django-DefectDojo.log

Hello @mtesauro thank you very much !!
I will try this today.
Best regards.


Add facebook messenger webhook endpoint for actionable notifications/message based events

Description:
Add endpoint for facebook messenger platform webooks to make configuration easier (adds handling for 'get my id' message) and fire events for messages/quick replies like telegram
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#5299
Example entry for configuration.yaml (if applicable):

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Any updates?


Change server version error to exception rather that system stop call

One way to close #408

Have you checked that throwing the exception properly crashes the app, resulting in a new pod being brought up when running in a cluster environment?