runecrafting plugin needs to be better

please we need ring of dueling swape beetwheen duel arena and castle wars this would help for runecrafting so much and make it easier. we need autoswapper between duel arena and castle wars! i don't even get 50k xp per hour when i following guide switch says 70k plus xp per hour. even if i use f keys it still not get up to 70k xp not even close. so swaping in equipment interface is all people need for runecrafting! i use all 3 pouches. some people can get 70k xp plus and thats not fair because i don't even get 50k xp per hour when i do fast i can.

According to Jagex's recent statement any menu modifications on worn/equipped items are not permitted.


Fixes #1886

This adds the "PARALLEL SAFE" flag to all functions in the cartridge where I'm certain that there are no thread safety problems.
It also bumps the version number of the cartridge.

@greglandrum Perhaps @rvianello should look at this, I'm not savvy at postgres cartridges.

I couldn't yet find an occasion to work with parallel query support in postgres, but fwiw the changes look good to me. The modified functions should be stateless, and therefore paralell safe (the only ones I'm not fully confident with are the fmcs aggregate functions, but just because I ignore the exact implementation).

@greglandrum  Do you want me to look at the aggregate functions for parallel safety?

yes, I agree, sorry in case my comment sounded negatively, I didn't mean to delay this PR.

ok, looks like we agree this should be merged... it's done.


➕Feature : Styling The "Vertical Scroll Bar"  To Match WebsiteTheme!

Hey @Abidsyed25
I Want to make an Enhancement for the Vertical Scroll bar in the Right Side.
Currently it is not styled (it's default) to follow the Website's theme.
As you can see-

This is How I Want to Enhance it to follow the Website theme

Please take a look.
I would like to work on it, Please assign me.
Thankyou!

@aslams2020 ok


站内搜索的search.xml文件总出现编码错误，配置文件没问题。

Expected behavior (预期行为)
Actual behavior (实际行为)
This page contains the following errors:

error on line 9 at column 37: Input is not proper UTF-8, indicate encoding !
Bytes: 0x10 0x3C 0x63 0x6F
Below is a rendering of the page up to the first error.

Steps to reproduce the behavior (重现步骤)
http://vinoit.me/search.xml
NexT Informations
NexT Version:

5.0.1

NexT Scheme:

Mist

Other Informations (Like Browser, System, Screenshots)
上次通过定位到文章的具体行，然后重新编辑文章，才搞定了这个错误。这次新写了一篇文章，又出现了这个问题。

修改generator插件去掉所有html标记试试

generator.js和search.ejs这两个吗？该如何修改@flashlab ,求教。

https://neveryu.github.io/guestbook/
编码和文件开头都要设置

ds.charset = 'UTF-8';
加上就好了，不懂可以问我
https://neveryu.github.io/guestbook/

ds.charset = 'UTF-8';这句加在哪里?@Neveryu

@vinoZHU dont understand u, write in English if not solved. If solved, close it please. Thank's!

@ivan-nginx  I'm sorry for forgetting to close it.

Don't worry, i'll fix this soon. =)

@ivan-nginx Thank's!

@vinoZHU @Neveryu 请教博主是如何解决这个问题的呢？我遇到了和您描述一样的情况 demo
This page contains the following errors:
error on line 53 at column 35: Input is not proper UTF-8, indicate encoding !
Bytes: 0x08 0x50 0x79 0x74
Below is a rendering of the page up to the first error.

Recently, I have came across the same problem. Where should I add the ds.charset = 'UTF-8'?  @vinoZHU @Neveryu @MuYunyun
Thanks in advance!

NexT is rebased into organization repo.
If you want new feature, fix, or support, create new in NexT v6.x repo (desirable in English).
There is instructions on English or Chinese how to update from v5.1.x to v 6.x
You also may read this for details.


Example bug using create timer and calling an activity.

If I use a create_timer inside of a method on my workflow code which calls an activity, the timer fires but the code after the timer does not execute. This is true even if I use a do block to execute after the timer fires - async versions or blocking.
Example hack code modifying the booking sample to show this.
Expected Output
Timer fires, activity gets scheduled and called, and workflow completes successfully
Actual Output
Timer fires, and workflow spins on decision tasks until the workflow execution timeout is reached (or event limit is exceeded)
Fri Jul 08 21:52:00 GMT-400 2016
40
WorkflowExecutionTimedOut
Fri Jul 08 21:51:36 GMT-400 2016
39
DecisionTaskScheduled
Fri Jul 08 21:51:36 GMT-400 2016
38
DecisionTaskTimedOut
Fri Jul 08 21:51:06 GMT-400 2016
37
DecisionTaskStarted
Fri Jul 08 21:51:06 GMT-400 2016
36
DecisionTaskScheduled
Fri Jul 08 21:51:06 GMT-400 2016
35
DecisionTaskTimedOut
Fri Jul 08 21:50:36 GMT-400 2016
34
DecisionTaskStarted
Fri Jul 08 21:50:36 GMT-400 2016
33
DecisionTaskScheduled
Fri Jul 08 21:50:36 GMT-400 2016
32
DecisionTaskTimedOut
Fri Jul 08 21:50:06 GMT-400 2016
31
DecisionTaskStarted
Fri Jul 08 21:50:06 GMT-400 2016
30
DecisionTaskScheduled
Fri Jul 08 21:50:06 GMT-400 2016
29
TimerFired
Fri Jul 08 21:50:03 GMT-400 2016
28
TimerStarted
Fri Jul 08 21:50:03 GMT-400 2016
27
DecisionTaskCompleted
Fri Jul 08 21:50:03 GMT-400 2016
26
DecisionTaskStarted
Fri Jul 08 21:50:03 GMT-400 2016
25
DecisionTaskScheduled
Fri Jul 08 21:50:03 GMT-400 2016
24
ActivityTaskCompleted
Fri Jul 08 21:50:03 GMT-400 2016
23
ActivityTaskStarted
Fri Jul 08 21:50:03 GMT-400 2016
22
ActivityTaskScheduled
Fri Jul 08 21:50:03 GMT-400 2016
21
DecisionTaskCompleted
Fri Jul 08 21:50:03 GMT-400 2016
20
DecisionTaskStarted
Fri Jul 08 21:50:02 GMT-400 2016
19
DecisionTaskScheduled
Fri Jul 08 21:50:02 GMT-400 2016
18
ActivityTaskCompleted
Fri Jul 08 21:50:02 GMT-400 2016
17
DecisionTaskCompleted
Fri Jul 08 21:50:02 GMT-400 2016
16
DecisionTaskStarted```

Additional info:

This is only broken if the call to the activity client inside of the method body is the final call to the activity client in the entire workflow. If you modify the workflow code and add a call like
client.echo 'test' on line 67 then it works as expected.

You do not need to pass the activity client if you do what I described on line 1.

@hyandell tagging you since you seem to be most recent person working on this repo... I can submit more concrete code to find out what's going on around blackholing activities when dealing with timers.

Does anyone monitor this repo?


Improve test coverage

Codecov Report

Merging #12 (77823c4) into main (995db44) will increase coverage by 2.78%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main       #12      +/-   ##
===========================================
+ Coverage   97.21%   100.00%   +2.78%
===========================================
  Files          11        11
  Lines         395       391       -4
  Branches       69        67       -2
===========================================
+ Hits          384       391       +7
+ Misses          5         0       -5
+ Partials        6         0       -6

Impacted Files
Coverage Δ

src/django_upgrade/ast.py
100.00% <ø> (+8.33%)
:arrow_up:

src/django_upgrade/main.py
100.00% <100.00%> (+3.33%)
:arrow_up:

src/django_upgrade/tokens.py
100.00% <100.00%> (+6.03%)
:arrow_up:

src/django_upgrade/data.py
100.00% <0.00%> (+1.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995db44...77823c4. Read the comment docs.


Add 2 samples

Signed-off-by: Chip Zoller<EMAIL_ADDRESS>Related Issue(s)
Description
Adds two new sample policies, one with kuttl and CLI tests, the other without.
Checklist

[x] I have read the policy contribution guidelines.
[x] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
[x] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

cc @mintbomb27


loosen dependency versions

Codecov Report

Merging #128 (cc455a6) into main (d560d4c) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   74.05%   73.98%   -0.07%
==========================================
  Files          38       38
  Lines        1557     1557
  Branches      259      338      +79
==========================================
- Hits         1153     1152       -1
+ Misses        331      330       -1
- Partials       73       75       +2

Flag
Coverage Δ

unittests
73.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

belay/packagemanager/downloaders/common.py
87.50% <100.00%> (-3.13%)
:arrow_down:

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Why buildMCMC takes forever to compile?

I have started to use nimble today but failed because buildMCMC just won't finish. I don't know if  I did something wrong in the following code.
Simulated Data
library(lme4)

I <- 25
J <- 5
beta <- c(-0.2, 0.1)
theta <- 1
sigma <-0.5
library(ggplot2)
library(scales)

simfun <- function(substance=letters[1:10],experiment=factor(1:5),log10HQ=seq(-1,3,by=0.2),theta=1,sigma=0.1,beta=c(-0.2, 0.5)){
  expdat <- expand.grid(experiment = experiment,log10HQ=log10HQ,substance=substance)
expdat$HQ <- 10^expdat$log10HQ
expdat$obs <- factor(seq(nrow(expdat)))
n <- nrow(expdat)
nsub <- length(substance)
re <- rnorm(nsub,0,theta)
names(re) <- substance
fixed <- beta[1]+beta[2]*expdat$log10HQ
expdat$y <- re[expdat$substance]+rnorm(n,0,sigma)+fixed

expdat$effect <- gtools::inv.logit(expdat$y)
return(expdat)
}
expdat <- simfun(substance=factor(paste0("S",1:I)),experiment = factor(1:J),log10HQ=seq(-1,3,by=0.2),theta=0.5,beta=c(-0.2,0.5),sigma=0.3)

Nimble Implementation
## install.packages("nimble", repos = "http://r-nimble.org", type = "source")
library(nimble)
## load NIMBLE library

## define the model
code <- nimbleCode({
  alpha ~ dnorm(0, 0.001)
  beta ~ dnorm( 0, 0.001 )
  tau.y ~ dgamma(0.001, 0.001)
  tau.re ~ dgamma(0.001, 0.001)
  for(j in 1:M){

  ranef.v[j]~dnorm(0, tau.re)

  }
  for (i in 1:N){

    y[i] ~ dnorm ( mu.y[i], tau.y )
    mu.y[i] <- alpha+beta*x[i] + ranef.v[unit[i]]

  }
})

## constants, data, and initial values
constants <- list(N = nrow(expdat),M=nlevels(expdat$substance),x = expdat$log10HQ,unit=as.numeric(expdat$substance))

data <- data.frame(y = expdat$y)

inits <- list(alpha = 0, beta = 0.5, tau.y=1,tau.re=1)

## create the model object
system.time(Rmodel <- nimbleModel(code=code, constants=constants, data=data, inits=inits))

Default MCMC Algorithm
## create default MCMC algorithm directly from model object
system.time(Rmcmc <- buildMCMC(Rmodel))
## compile model and MCMC algorithm
Cmodel <- compileNimble(Rmodel)
Cmcmc <- compileNimble(Rmcmc, project = Rmodel)

## execute MCMC algorithm and extract samples
Cmcmc$run(10000)
samples <- as.matrix(Cmcmc$mvSamples)

Thanks for trying nimble.
In a nutshell, yes we have had slow processing times for some big models
(ok, not even huge) for some setup and compilation steps.
We have many processing steps running much faster on the devel branch of
our repository, and you are welcome to try that.  We have a few more steps
still to speed up.  We are close (maybe a couple of weeks?) to releasing
our devel branch as version 0.4.
One thing you can do for buildMCMC is include "useConjugacy = FALSE" as an
argument.  This will skip inspection of the model for conjugate
relationships to which Gibbs samplers can be assigned and assign adaptive
random walk samplers instead.  At the moment, these can be as fast or
sometimes fasters, so it's not a problem.  In the upcoming release the
inspection steps will be much faster.
Please let us know how it goes.
Perry
On Wed, Jun 3, 2015 at 6:03 AM, Zhenglei Gao<EMAIL_ADDRESS>wrote:

I have started to use nimble today but failed because buildMCMC just
won't finish. I don't know if I did something wrong in the following code.
Simulated Data
library(lme4)
I <- 25J <- 5beta <- c(-0.2, 0.1)theta <- 1sigma <-0.5
library(ggplot2)
library(scales)
simfun <- function(substance=letters[1:10],experiment=factor(1:5),log10HQ=seq(-1,3,by=0.2),theta=1,sigma=0.1,beta=c(-0.2, 0.5)){
expdat <- expand.grid(experiment = experiment,log10HQ=log10HQ,substance=substance)expdat$HQ <- 10^expdat$log10HQexpdat$obs <- factor(seq(nrow(expdat)))n <- nrow(expdat)nsub <- length(substance)re <- rnorm(nsub,0,theta)
names(re) <- substancefixed <- beta[1]+beta[2]*expdat$log10HQexpdat$y <- re[expdat$substance]+rnorm(n,0,sigma)+fixed
expdat$effect <- gtools::inv.logit(expdat$y)return(expdat)
}expdat <- simfun(substance=factor(paste0("S",1:I)),experiment = factor(1:J),log10HQ=seq(-1,3,by=0.2),theta=0.5,beta=c(-0.2,0.5
),sigma=0.3)
Nimble Implementation
install.packages("nimble", repos = "http://r-nimble.org", type = "source")
library(nimble)
load NIMBLE library
define the model
code <- nimbleCode({
alpha ~ dnorm(0, 0.001)
beta ~ dnorm( 0, 0.001 )
tau.y ~ dgamma(0.001, 0.001)
tau.re ~ dgamma(0.001, 0.001)
for(j in 1:M){
ranef.v[j]~dnorm(0, tau.re)
}
for (i in 1:N){
y[i] ~ dnorm ( mu.y[i], tau.y )
mu.y[i] <- alpha+beta*x[i] + ranef.v[unit[i]]

}
})
constants, data, and initial values
constants <- list(N = nrow(expdat),M=nlevels(expdat$substance),x = expdat$log10HQ,unit=as.numeric(expdat$substance))
data <- data.frame(y = expdat$y)
inits <- list(alpha = 0, beta = 0.5, tau.y=1,tau.re=1)
create the model object
system.time(Rmodel <- nimbleModel(code=code, constants=constants, data=data, inits=inits))
Default MCMC Algorithm
create default MCMC algorithm directly from model object
system.time(Rmcmc <- buildMCMC(Rmodel))## compile model and MCMC algorithmCmodel <- compileNimble(Rmodel)Cmcmc <- compileNimble(Rmcmc, project = Rmodel)
execute MCMC algorithm and extract samplesCmcmc$run(10000)samples <- as.matrix(Cmcmc$mvSamples)
—
Reply to this email directly or view it on GitHub
https://github.com/nimble-dev/nimble/issues/63.

Hi Zhenglei,
Following up on Perry's comment, I just ran your code on my own Linux
machine (thanks for the reproducible example). It did take longer than we
would like (and as Perry says, we're greatly improving this in the next
release), but not forever. I found the buildMCMC step to take about 40
seconds. When you say forever, how long did you wait for it to finish, and
what platform and processor are you running on?
Chris
On Wed, Jun 3, 2015 at 6:30 AM, perrydv<EMAIL_ADDRESS>wrote:

Thanks for trying nimble.
In a nutshell, yes we have had slow processing times for some big models
(ok, not even huge) for some setup and compilation steps.
We have many processing steps running much faster on the devel branch of
our repository, and you are welcome to try that. We have a few more steps
still to speed up. We are close (maybe a couple of weeks?) to releasing
our devel branch as version 0.4.
One thing you can do for buildMCMC is include "useConjugacy = FALSE" as an
argument. This will skip inspection of the model for conjugate
relationships to which Gibbs samplers can be assigned and assign adaptive
random walk samplers instead. At the moment, these can be as fast or
sometimes fasters, so it's not a problem. In the upcoming release the
inspection steps will be much faster.
Please let us know how it goes.
Perry
On Wed, Jun 3, 2015 at 6:03 AM, Zhenglei Gao<EMAIL_ADDRESS>wrote:

I have started to use nimble today but failed because buildMCMC just
won't finish. I don't know if I did something wrong in the following
code.
Simulated Data
library(lme4)
I <- 25J <- 5beta <- c(-0.2, 0.1)theta <- 1sigma <-0.5
library(ggplot2)
library(scales)
simfun <-
function(substance=letters[1:10],experiment=factor(1:5),log10HQ=seq(-1,3,by=0.2),theta=1,sigma=0.1,beta=c(-0.2,
0.5)){
expdat <- expand.grid(experiment =
experiment,log10HQ=log10HQ,substance=substance)expdat$HQ <-
10^expdat$log10HQexpdat$obs <- factor(seq(nrow(expdat)))n <-
nrow(expdat)nsub <- length(substance)re <- rnorm(nsub,0,theta)
names(re) <- substancefixed <- beta[1]+beta[2]*expdat$log10HQexpdat$y <-
re[expdat$substance]+rnorm(n,0,sigma)+fixed

expdat$effect <- gtools::inv.logit(expdat$y)return(expdat)
}expdat <- simfun(substance=factor(paste0("S",1:I)),experiment =
factor(1:J),log10HQ=seq(-1,3,by=0.2),theta=0.5,beta=c(-0.2,0.5
),sigma=0.3)
Nimble Implementation
install.packages("nimble", repos = "http://r-nimble.org", type =

"source")

library(nimble)
load NIMBLE library
define the model
code <- nimbleCode({
alpha ~ dnorm(0, 0.001)
beta ~ dnorm( 0, 0.001 )
tau.y ~ dgamma(0.001, 0.001)
tau.re ~ dgamma(0.001, 0.001)
for(j in 1:M){
ranef.v[j]~dnorm(0, tau.re)
}
for (i in 1:N){
y[i] ~ dnorm ( mu.y[i], tau.y )
mu.y[i] <- alpha+beta*x[i] + ranef.v[unit[i]]
}
})
constants, data, and initial values
constants <- list(N = nrow(expdat),M=nlevels(expdat$substance),x =
expdat$log10HQ,unit=as.numeric(expdat$substance))
data <- data.frame(y = expdat$y)
inits <- list(alpha = 0, beta = 0.5, tau.y=1,tau.re=1)
create the model object
system.time(Rmodel <- nimbleModel(code=code, constants=constants,
data=data, inits=inits))
Default MCMC Algorithm
create default MCMC algorithm directly from model object
system.time(Rmcmc <- buildMCMC(Rmodel))## compile model and MCMC
algorithmCmodel <- compileNimble(Rmodel)Cmcmc <- compileNimble(Rmcmc,
project = Rmodel)
execute MCMC algorithm and extract samplesCmcmc$run(10000)samples <-

as.matrix(Cmcmc$mvSamples)

—
Reply to this email directly or view it on GitHub
https://github.com/nimble-dev/nimble/issues/63.

—
Reply to this email directly or view it on GitHub
https://github.com/nimble-dev/nimble/issues/63#issuecomment-108412389.

@paciorek , I tried it again. Forever means literally more than 10 minutes.  What I have under sessionInfo():
R version 3.2.0 (2015-04-16)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 7 x64 (build 7601) Service Pack 1
I ran it in RStudio, maybe there is some problem with using RStudio and codes involving setting variable environments.
In fact, I tried to knit the Rmd file and the line did run and it took 177.56 seconds. Also it output lots of warnings.
## create default MCMC algorithm directly from model object
system.time(Rmcmc <- buildMCMC(Rmodel))

##    user  system elapsed
##  175.49    0.11  177.56

Zhenglei, yes, I believe this might be a known problem with using NIMBLE
from RStudio.  We have fixed this in the upcoming release of NIMBLE.  But
unfortunately, for the older versions of NIMBLE, it causes NIMBLE
processing to take very long times when using RStudio -- sometimes even
seeming like forever.
This problem is described in detail at this NIMBLE Users Google Group
posting.  If you follow the instructions, it may well solve the problem for
you.
https://groups.google.com/forum/#!topic/nimble-users/sa_S9cM-ul0
And let me say again, this problem is fixed in our upcoming release --
hopefully within the next couple weeks.
Good luck, please let us know if this works.
Daniel
NIMBLE Development Team
On Fri, Jun 5, 2015 at 2:50 AM, Zhenglei Gao<EMAIL_ADDRESS>wrote:

@paciorek https://github.com/paciorek , I tried it again. Forever means
literally more than 10 minutes. What I have under sessionInfo():
R version 3.2.0 (2015-04-16)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 7 x64 (build 7601) Service Pack 1
I ran it in RStudio, maybe there is some problem with using RStudio and
codes involving setting variable environments.
In fact, I tried to knit the Rmd file and the line did run and it took
177.56 seconds. Also it output lots of warnings.
create default MCMC algorithm directly from model object
system.time(Rmcmc <- buildMCMC(Rmodel))
user  system elapsed
175.49    0.11  177.56
—
Reply to this email directly or view it on GitHub
https://github.com/nimble-dev/nimble/issues/63#issuecomment-109233121.

@danielturek , I see the problem now. I am looking forward to the next release. And I like the idea of being able to use customized model definitions and MCMC algorithms.

I’ll add that the warnings should be harmless, if they appear to be C++ compiler warnings about types.  The compilers we use on our main development machines (OS X and linux) don’t issue those warnings but they come up on Windows, so we’ll have to remember to get those cleaned up.  Thanks
Perry

On Jun 5, 2015, at 7:29 AM, Zhenglei Gao<EMAIL_ADDRESS>wrote:
@danielturek https://github.com/danielturek , I see the problem now. I am looking forward to the next release. And I like the idea of being able to use customized model definitions and MCMC algorithms.
—
Reply to this email directly or view it on GitHub https://github.com/nimble-dev/nimble/issues/63#issuecomment-109310987.


Clarify comment against github.repositories setting

If we don't change the default then I'm not clear if that means all repositories or none.
It would be good to add to the comment to make it obvious.

i have finally got it working!  i was getting same problem as issue #43
it definitely required

ssh key setup in git for windows and entering ssh key in github user settings

in user settings it required

"github.host" as default
"github.username": "" example "chrmarti"
"github.repositories": "<username/repository-name"
example "microsoft/vscode-github-issues-prs"

this didn't run straight "out of the box" on defaults and it took me ages to work out how to get it going
I had also setup the ssh keys first, and had nothing in user settings so it ran "out of the box" and nothing worked.
it wasn't until i put the settings as outlined above that it actually worked.
I think this is definitely needs to be documented in the README.md
I spent stupid amounts of time trying to get this working, it's all blindingly simple once you work it out, but for those that are still learning (like myself)
I didn't know in point 3. above if you needed

"https://github.com/microsoft/vscode-github-issues-prs"
"microsoft/vscode-github-issues-prs"
"vscode-github-issues-prs"

and if you don't put in "github.repositories": "<username/repository-name" it tells you that "@ has no issues"
once working it does display all issues that are both under milestones and also those that are not.


Add eos-vm benchmarks

eosvm doesn't seem to show up in the charts?

I have rebased master, and included eos-vm in the notebook so the charts get generated.

Can you add eosvm to the README?

I already modified the script https://github.com/ewasm/benchmarking/pull/150/files#diff-a6dee7477faf26016717d019cdc8bf1b , althought I modify it manually, do you want me to use the nbconvert tool instead?

Now I converted the notebook to a script, and included the charts generated by the script.


Add a method to remove polygons

Hi, I'm having trouble removing existing Polylines on Android (I've not tested on IOS).
This is how I add them:
this.map.addPolygon({
	id: this.circular_polyline_id,
	fillColor: new Color("#0099FF"),
	fillOpacity: 0.7,
	points: circlePoints.map(c => {
		return {
			'lat': c[1],
			'lng': c[0]
		}
	})
});

Before adding, I try to remove them like this:
this.map.removePolylines([this.circular_polyline_id]).then(response => {

});

I've tried everything, even using setTimeout, etc.
Any ideias what I'm doing wrong?

You're adding a polygon but remove a polyline.
The available functions currently are: addPolygon, addPolyline, and removePolylines.

@EddyVerbruggen, thanks for the quick response but, how do I remove an existing polygon ?

There's currently no exposed function to do that.

So, how could I draw a circle with a fill color without using the addPolygon function ?

You could either send a PR to add the remove function, or wait 15 minutes for me to add it.

@EddyVerbruggen, I'll gladly wait 15 minutes for your function! :-)

4.1.1 released ➡ grab it while it's 🔥

I already update to the latest version, it works! Thanks!!!

sorry to revive old issue, but is there a way to draw circles from a centre and radius with this plugin? or will I have to draw a 'rough' circular polygon from multiple points?


Add monitor_cpu_utilization_too_high_period variable to configure the number of seconds of the period for CPU

Would you consider adding another variable to adjust the interval between checks in the CPU Utilization?

Our application relies on a highly available cluster, and so a period of 60 seconds with a higher CPU threshold (thanks for making that configurable!) would really suit us nicely. Happy to contribute with a PR for you to review.
🙌 Thank you for making this module! It's been super helpful for our application since we launched late last year.

Hi @mmarcotte,
Thank you for raising the issue. I've added the varibles you want. Please refer to release v2.1.0
If there's no further question, I'll close this bug next week. Thanks.

This is perfect, thank you so much! 🙏


Strange behaviour in trivia with long answers

When the answer to certain questions is fairly long, the bot cuts off the answer:

And for whatever reason, it sometimes leads to incredibly weird capitalisation situations like this:

Please try it again and it should work properly, if it does, close the issue.

@numbermaniac yo dude you still having the issue after updating NadekoBot? Otherwise you can close the issue 0/

Well, it looks like it's working :) If anything does still go wrong I'll open an issue here, but it looks good so far. Thanks!


[RFC] Stereo Matching Datasets API

🚀 The feature
The proposed feature aims to extend the current datasets API with datasets that are geared towards the task of Stereo Matching. It's main use case is that of providing  a unified way for consuming classic Stereo Matching datasets such as:

Middlebury2014
Kitti
SceneFlow

Other considered dataset additions are: Sintel, FallingThings, InStereo2K, ETH3D, Holopix50k. A high level preview of the dataset interface would be:
class StereoMatchingDataset(Dataset):
    def __init__(self, ...):
        # constructor code / dataset specific code

    def __getitem__(self, index: int) -> Tuple[Tensor, Tensor, Tensor, Tensor]:
        # processing code
        # ...

        # imgs: Tuple[Tensor, Tensor]
        # dispartieis: Tuple[Tensor, Tensor]
        # occlusion_masks: Tuple[Tensor, Tensor]

        if self.transforms is not None:
            imgs, disparities, occlusion_masks = self.transforms(imgs, disparities, occlusion_masks)

        img_left = imgs[0]
        img_right = imgs[1]
        disparity = disparities[0]
        occlusion_mask = occlusion_masks[0]

        return img_left, img_right, disparity, occlusion_mask

Motivation, pitch
This API addition would cut down engineering time required for people that are looking into working on, experimenting, or evaluating Stereo Matching models or that want easy access to stereo image data.
Throughout the literature, recent methods (1, 2) make use of multiple datasets that all have different formatting or specifications. A unified dataset API would streamline interacting with different datasources at the same time.
Alternatives
The official repo for RAFT-Stereo provides a similar functionality for the datasets on which the network proposed in the paper was trained / evaluated. The proposed StereoMatchingDataset API would be largely similar to it, whilst following idiomatic torchvision.
Additional context
Stereo Matching task formulation.
Commonly throughout the literature the task of stereo matching requires a reference image (traditionally left image), its stereo pair (traditionally the right image), the disparity map (traditionally the left->right disparity) between the two images and an occlusion / validity mask  for pixels from the reference image that do not have a correspondent in the stereo pair (traditionally left->right). The proposed API would server data towards the user in the following manner:
Proposal 1.
class StereoMatchingDataset(Dataset):
    def __init__(self, ...):
        # constructor code / dataset specific code

    def __getitem__(self, index: int) -> Tuple[Tensor, Tensor, Tensor, Tensor]:
        # processing code
        # ...

        # imgs: Tuple[Tensor, Tensor]
        # dispartieis: Tuple[Tensor, Tensor]
        # occlusion_masks: Tuple[Tensor, Tensor]

        if self.transforms is not None:
            imgs, disparities, occlusion_masks = self.transforms(imgs, disparities, occlusion_masks)

        img_left = imgs[0]
        img_right = imgs[1]
        disparity = disparities[0]
        occlusion_mask = occlusion_masks[0]

        return img_left, img_right, disparity, occlusion_mask

The above interface for data consumption is more aligned with the larger dataset ecosystem in torchvision where a dataset provides all the required tensors to perform training. However, this approach makes the assumption the user / algorithm does not require the right disparity map or the right occlusion mask. An alternative to this assumption would be a modification of the interface such that the user may be able to access the right-channel annotations:
Proposal 2.
def __getitem__(self, index: int) -> Tuple[Tuple, Tuple, Tuple]:
        # processing code
        # ...

        # imgs: Tuple[Tensor, Tensor]
        # dispartieis: Tuple[Tensor, Tensor]
        # occlusion_masks: Tuple[Tensor, Tensor]

        if self.transforms is not None:
            imgs, disparities, occlusion_masks = self.transforms(imgs, disparities, occlusion_masks)

        return imgs, disparities, occlusion_masks

# in user land, the API feeds all the available data to the user
for (imgs, disparities, occlusion_masks) in stereo_dataloader:
        # however, the user becomes responsible to deconstruct the batch in order to get
        # the classic task definition data
        img_l, img_r, disparity, occlusion_mask = imgs[0], imgs[1], disparities[0], occlusion_masks[0]
        # ...

User feedback would be highly appreciated as it is highly unlikely one can be aware of all the use-cases / methods in Stereo Matching. Some preliminary pros and cons for each proposal:
Proposal 1
Pros:

Provides strong guarantees about the data (not all datasets provide disparities for both views, i.e ETH3D)
Follows the common specification of the Stereo Matching task.
The user is provided with a familiar / idiomatic experience and receives all the necessary data for training with no need for additional data handling / manipulation

Cons:

It can restrict data access to the user with no out of the box way of recovering it (i.e. right disparity maps / occlusion masks). This would render the API unusable for some use-cases (if there are any).

Proposal 2
Pros:

The user gets all the data (left / right annotations instead of just left)

Cons:

Breaks away from the standard of other dataset APIs in torchvision.
Forces the user to check his data / data merging strategies (i.e. using ETH3D would yield None for the right channel annotations)
Users need to manually unpack the data into tensors that are provided to models / losses.

cc @pmeier @YosuaMichael

An approach similar to the one in the optical flow dataset would indeed lead to tuples with only one element @NicolasHug and require to user to make checks on the sizes / shapes of the batch elements. Optical Flow generally tracks pixel shifts through time from one view, whilst Stereo Matching tracks pixel shifts between two views coming from two separate cameras captured at the same time.
Some functionality that would be nice to have would be that of providing an easy of creating a DatasetWrapper that can sample from several StereoMatchingDatasets at the same time as it is a technique used recently in the SotA: CREStereo. For that particular use case Proposal 1 is better suited as it guarantees data uniformity.
Providing users a way to mix and match datasets under Proposal 2 would require some rather hacky solutions. Users would either have to provide their custom collate_fn if they somehow find themselves mixing different format datasets or rely on placeholder Tensors and loss masking or other such mechanisms.
Whilst the multi-dataset use case is not necessarily a functionality that must be provided to the end user, it is at least a higher-order functionality that is recurrent in several other Vision tasks such as classification, segmentation, detection etc. Should a method arise where both disparity maps are utilised and we had opted for Proposal 1, that would imply changing the API both internally and it terms of its interface.

Thanks for the effort of making stereo datasets available. I recently started to use some of these so I'd like to add my user experience data point into the discussion in case it could be useful.
It seems to me a bit counter-intuitive that transforms function has different inputs than the dataset items. I expected that these would be the same. In that respect, the approach in the optical flow dataset seems to me more intuitive. Also, is there any reason why to transform data which won't get out anyway?
Another thing: wouldn't it be useful to allow the transforms to modify what outputs are returned - and return that directly as a dataset item? Datasets I checked don't allow that now but typically it wouldn't break anything there either if allowed. If that was allowed one would be able to make datasets compatible simply by providing a fitting transforms function suitable for that use case.

Hey @tpet! Thank you for your input and feedback as it is very valuable!
At that time the picture wasn't very clear of how users would prefer to interact with this specific vision task. One of the cases we were trying to build around was that of training using batches containing samples from several datasets at the same time, similarly to what was loosely described in the CREStereo paper.
Something we were taking into account was trying to have a unified way of calling the transforms irrespective of the dataset.
Because some augmentation techniques, namely horizontal flipping, require having both a valid left and a right disparity map in order to be performed, we wanted to somehow unify the returns / behaviour of each dataset.
Even though multiple inputs are necessary to perform said type of augmentations, a "classic" stereo-matching pipeline still requires only some of them in order to perform the optimization step: (left image, right image, disparity, Optional[mask]). As such, the behaviour we were looking for in terms of functionality should've looked something like:
for batch in stereo_dataset_loader:
  left, right, disp, mask = batch
  preds = model(left, right)
  loss = criterion(preds, mask)
...

Where stereo_dataset_loader was a simple torch.utils.data.DataLoader which possibly received as input either one StereoMatchingDataset or a torch.utils.data.ConcatDataset composed from multiple StereoMatchingDataset that were all initialised with the same transform chain.
The choice at the time stemmed from the fact that if each type of dataset was to return only the items it contains, irrespective of the transform chain, then users would've had to define independent transform chains for each dataset and a custom batch collate function for the DataLoader.
It would be very much appreciated if you could share what you believe to be a desired / ideal workflow when dealing with Stereo Matching related tasks / training pipelines as that would provide very valuable insights into what users might want when utilising these datasets.

I agree that it should be possible to easily create batches from multiple datasets. I was thinking that the transforms function could be used to make the datasets compatible. In cases where one needs to combine datasets providing different things (e.g. some are missing the masks, some have only left disparity), it seems that one shared transform chain may not be enough anyway and it may be good to expose this fact to the user.
Personally, I would prefer to keep the input of the transforms function identical to what the dataset provides, so that one can think of it just as conversion from dataset[i] to transforms(*dataset[i]) (perhaps transforms(**dataset[i]) for dict examples). In case it is required that the transforms function have common interface for all stereo datasets, then maybe all the datasets should return output in the same form.
Regarding the usage of the transforms function and its outputs, I would allow it change what goes to the output. That would add a lot of flexibility and may then help to get different datasets to common ground. If the compatibility effort is already done in the transforms function, I suppose one could then use the default collate function.


DBeaver 5.3.x not refreshed

Database table screen doesn't be refreshed with the refresh button and so on.
I've been tested with MariaDB or MySQL drivers on Ubuntu 18.04 and Windows 10.
DBeaver version 5.3.201901062110 (2019.01.07)

DBeaver version 6, now it works again. So I close this issue.


Feature/submitting test flight builds

This is the final step in TestFlight automation, release the build for external testing.  This is triggered after any push to master.

Went ahead and added a merge from dev to master to this, so we'll get nightly TestFlight builds.

@ibeckermayer yes and no. I’ll dm you about it.


Milestone 2

Individual function work:

[ ] Write unit test function (3-5 edge cases)
[ ] Write internal code for function
[ ] Ensure code passes unit test (via pytest)

Gropl:

[ ] Package able to be installed from GitHub

R to-dos ~ (can copy over once we have the R repo)

[ ] Create project structure
[ ] MIT license
[ ] Code of Conduct
[ ] DESCRIPTION file
[ ] CONTRIBUTING.md
[ ] README.Rmd
[ ] R package function specifications

We should also go over our Milestone 1 feedback in lab!

This group was pushing their changes into the main branch, meaning that this group has not set up protection for the main branch
We deleted all the branches so it looks like we are working directly in the main branch...

I thought we need to delete all other branches after merging to the main branch? So I did that.
Github workflow ok, but you guys did not use milestones.
We did create a milestones1 checklist and it's closed after all is done. I'm not sure if that's the milestones he was looking for


ERROR  Unable to display notification: exit status 1

Every time after finished session. Instead of a sound and a notification it goes straight away for the break timer.
I am on FreeBSD with sway or hikari / alacritty as my terminal.
Other things are working.
Do I need to install some lib or what seems to be a problem?

@8rj9 Do you notice this behaviour with the latest version?


Implement size method

We would like to implement a size method, which would find repos in a given size range. It will be very similar to other range methods of Finder class. Check search api doc for syntax details.

@sonalkr132 Can I take this one?

ahh.. not really. It is a basic new comer issue. If you are interested in working on this gem I will open more difficult issues soon enough :+1:

Sure. But since I am not too familiar with working with ruby gems a newcomer issue will be a good one to start with.

a newcomer issue will be a good one to start with.

You have already sent a PR :tongue: Don't worry.. it is nothing you can't handle.

Yeah please review the PR :stuck_out_tongue:


Fix CSS example on docs (active class on , not )

Just a small fix for the readme :-)

Good catch, thanks!


⚠ Bofrost.lu has degraded performance

In 3f6e544, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1707 ms

Resolved: Bofrost.lu performance has improved in 9d8bdd0 after 16 minutes.


error[E0004]: non-exhaustive patterns: async_tungstenite::tungstenite::Error::AttackAttempt not covered

Hi, I'm trying to use your package but I can't compile it.

OS: Windows 11
Rust version: rustc 1.73.0 (cc66ad468 2023-10-03)

Dependencies in Cargo.toml:
[dependencies]
polars = "0.34.2"
pyo3-polars = "0.8.0"
sqlx-exasol = "0.7.1-alpha-3"

Steps to reproduce:
cargo new teststuff
cargo add polars
cargo add pyo3-polars
cargo add sqlx-exasol

Creating a file /src/main.rs with:
use polars::prelude::*;

fn main() {
    println!("Hello, world!");
}

Running the following commands in teststuff:
cargo run

Resulting in the following error:

Compiling polars-row v0.34.2
Compiling sqlx-exasol v0.7.1-alpha-3
Compiling polars-core v0.34.2
error[E0004]: non-exhaustive patterns: async_tungstenite::tungstenite::Error::AttackAttempt not covered
--> C:\Users\XXX.cargo\registry\src\index.crates.io-6f17d22bba15001f\sqlx-exasol-0.7.1-alpha-3\src\error.rs:54:23
|
54 |         let e = match e {
|                       ^ pattern async_tungstenite::tungstenite::Error::AttackAttempt not covered
|
note: async_tungstenite::tungstenite::Error defined here
--> C:\Users\XXX.cargo\registry\src\index.crates.io-6f17d22bba15001f\tungstenite-0.20.1\src\error.rs:64:5
|
15 | pub enum Error {
| --------------
...
64 |     AttackAttempt,
|     ^^^^^^^^^^^^^ not covered
= note: the matched value is of type async_tungstenite::tungstenite::Error
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
|
65 ~             WsError::HttpFormat(e) => SqlxError::Protocol(e.to_string()),
66 ~             async_tungstenite::tungstenite::Error::AttackAttempt => todo!(),
|
For more information about this error, try rustc --explain E0004.
error: could not compile sqlx-exasol (lib) due to previous error
warning: build failed, waiting for other jobs to finish...

Hi @Marmeladenbrot ,
I'll be looking into this today. Looks like it's due to some platform specific stuff from async-tungstenite that makes it fail to compile.
It's also a wake-up call to at least set some cargo check CI jobs for windows and mac-os.

@Marmeladenbrot My initial assumptions were wrong, but I enhanced the CI nevertheless. The build was failing due to a vulnerability fix in tungstenite that was propagating upwards (and was done as a patch version, not a minor version). I fixed the issue and published version 0.7.1-alpha-4. Please try that instead.
Additionally, #18 has more details regarding the issue itself, if you are interested. Thank you for reporting this!

@Marmeladenbrot If you find the time, it'd be great to confirm that things are working now. If you still encounter issues, feel free to re-open this issue or create a new one, as applicable.


waiting list participants ELIXIR-LU DMDS training 2021-06-14

Waiting list DMDS June 2021
If people might decline their seats, particularly when asked to confirm, we can replace them with the following participants who contacted us:

Tainá MARQUES<EMAIL_ADDRESS>(contacted us via mail)

Parul Tewatia<EMAIL_ADDRESS>(contacted us via mail)

Also Mariethe Botes  -<EMAIL_ADDRESS>(via mail)


Add Migration Assistant Deployment Option to AWS DMS and OpenSearch Service with UX Improvements

Is your feature request related to a problem?
Currently, the AWS Console does not have any references to the Migration Assistant, making it challenging for customers to discover and deploy the Migration Assistant easily. The lack of integration means customers must rely on separate documentation and processes, which can slow down their adoption and deployment of migration solutions.
What solution would you like?
Update the AWS Console to include references to the Migration Assistant in both the Solutions Guide and the Solutions deployment workflow. This would involve:

Determining which CloudFormation templates should be linked from the AWS Console integration.
Open-sourcing the AWS Solution CFN template source in the OpenSearch-Migrations GitHub repository.
Adjusting the internal build process to enable AWS Solutions to pull the CFN templates from the open-source repository.
Updating the AWS Solutions documentation to include references to this new integration.
Updating the AWS Console interface to link to and reflect this new integration.

What alternatives have you considered?

Direct Access via GitHub: Users could directly access and deploy the CFN templates from the GitHub repository, but this approach still requires additional manual steps and is not as discoverable.
Solutions Landing Page: The AWS Solutions Landing page is helpful but may not always be discoverable.

Do you have any additional context?
This integration would provide a better user experience for customers looking to deploy the Migration Assistant.
Jira Epic(s)

https://opensearch.atlassian.net/browse/MIGRATIONS-2151
https://opensearch.atlassian.net/browse/MIGRATIONS-2087

These changes have been deployed and are now accessible directly via this repo, AWS OpenSearch, AWS DMS, and AWS Solutions.


fixing adam

While loop which rises t is meant till convergence so each optimiser step t=t+1

oh lol, good catch


Assertion error message sequencing

I love AssertJ, but I find the sequencing of many of the error messages to be counterintuitive.
Take for example:

Expecting: <actual> to be equal to: <expected> but was not.

Per Wikipedia:

The most common use of the colon is to inform the reader that what follows the colon proves, explains, defines, describes, or lists elements of what preceded it.

Accordingly, when I begin reading that assertion error message my mind is, well, expecting to see "Expecting: <expected>", not "Expecting: <actual>".  It's only when I read the closing, "but was not" that I realize I've interpreted the whole error message backwards.
I believe something like the following would be more intuitive and concise:

Expected: <expected>, but was: <actual>.

I realize this may be a matter of personal preference, or of locale, so I'm filing this issue mainly to see if others find the current message style counterintuitive as well.
If enough do, maybe the solution would be to just change it, or perhaps some sort of localization or message style facility could be introduced to make it configurable.

Some prior art for configurable reporting styles in Atrium:
https://github.com/robstoll/atrium/blob/v0.7.0/README.md#reporterbuilder.

The rationale of the error message design was to follow how the assertion read where actual comes in before expected, but you are raising a fair point.
I'm happy with the Expecting: <expected>, but was: <actual>.  suggestion or better with displaying both values on different for ease of comparison (when you don't have IDEs visual comparison).
I think it only applies for isEqualTo though, for example isBefore error message looks like:
Expecting:
  <2011-01-01T00:00:00.000>
to be strictly before:
  <2012-01-01T00:00:00.000>

which seems fine to me.
Thoughts  on that latter error message ?

I also found it difficult to process that format of the error message when I started to use the library. I'm still not completely get used to it (after a couple of months of usage).
For the latter I would prefer something like this:
Actual:
  <2011-01-01T00:00:00.000>
is not strictly before:
  <2012-01-01T00:00:00.000>

Although, I agree, it is somewhat easier to process in the original format, than the original message of isEqualTo.

@martin-tarjanyi I agree your error message is clearer, it's not top priority  though for me but contributions accepected ;-)

We will start with the equals error message since it's the most used by far.
We will align it to Idea and Truth with:
expected : foo
but was  : bar

We will start with the equals error message since it's the most used by far.
We will align it to Idea and Truth with:
expected : foo
but was  : bar


Include experiment docs link in the chaos-experiment CSV yaml

Each experiment has a corresponding CSV yaml consisting of experiment metadata. The experiment doc link should also be provided as part of its spec, to enable rendering that on the chaoshub

Ref CSV: https://github.com/litmuschaos/chaos-charts/blob/master/charts/generic/pod-delete/pod-delete.chartserviceversion.yaml
Ref Hub View: https://hub.litmuschaos.io/charts/generic/experiments/pod-delete

This is fixed by https://github.com/litmuschaos/charthub.litmuschaos.io/pull/87


add NIOFoundationCompat lib to package products

Fixes #54

@swift-nio-bot test this please

@swift-nio-bot test this please

@swift-nio-bot test this please... this is not related and we have an outstanding pr for the flaky test.

@tanner0101 thanks so much!


.snakes command bug

Description

When giving argument python in subcommand get of command snakes, bot returns Wikipedia page of Python programming language instead of returning result related to python snake.
Steps to Reproduce

Type .snakes get python
Expected Behaviour

An embed which contains information about Python snake retrieved from Wikipedia.
(Not including link of most suitable Wikipedia page but can be found by using a search engine with keywords python genus Wikipedia)
Actual Behaviour

Known Impacted Platforms

[ ] Web
[ ] Desktop
[x] Android App
[ ] iOS App

Would you like to implement a fix?
Note: For high-priority or critical bugs, fixes may be implemented by staff.

[ ] I'd like to implement the bug fix
[x] Anyone can implement the bug fix

This looks like it has been done intentionally 😉

This looks like it has been done intentionally 😉

Ok! 😂


Need to Restart after setting Path?

Does a computer need to be restarted after setting the path? What if a user just closes all Cmd windows and starts a fresh terminal session?

I think just closing the CMD windows and starting a fresh terminal will take care of it and if not then restart usually does the trick.


Highlightr says “undefined” for language it doesn’t recognize

GitHub markdown and file extensions can be anything. Should fall back to bare text if this is the case.
Probably time to do a local girl of Highlightr and fix these things. Should return nil if it can’t detect the language.

Bug Report Dump (Auto-generated)

Version 1.15.0 (SEE BUILD PHASE)
Device: iPhone X (iOS 11.1.2)
TestFlight: false

Fixed in #1148


Unable to load asset (prefix: "sounds/" -> prefix: "assets/sounds/")

I believe audioplayers: ^0.16.1 introduced a breaking change from audioplayers: ^0.15.1
I used to have static final instance = AudioCache(prefix: "sounds/")
When playing instance.play(...) I would now (0.16.1) get an exception Unhandled Exception: Unable to load asset: sounds/...
I changed initialization to AudioCache(prefix: "assets/sounds/")  and now it works as expected.
I got the idea from https://github.com/luanpotter/audioplayers/pull/597

Thank you for the fix ;)

It did. You got it exactly right. Please check the changelog :)
The reason was to allow for people to use different folders if they wanted

Hmm, is this breaking change documented in the changelog? I cannot see it in this changelog but maybe it's documented in some other changelog? https://github.com/luanpotter/audioplayers/blob/master/CHANGELOG.md


Root size mediaqueries

Hi, Is there a way to force calculation to the 16px I set in the gruntfile?
Or only the root font-size, and not the ones declared in a mediaquery?
It appears to use the root font-size declared last, which would be desirable, but it doesn't ignore mediaqueries, so in this case it uses 90% instead of 100%:
html {
font-size: 100%;
}
@media only screen and (max-width: 768px) {
html {
font-size: 90%;
}
}

this should've been posted on the grunt-pixrem repo, sorry.
Anyhow, it's fixed. I used pleeease, but now i use the regular grunt-pixrem, which fixed this issue.


Potential bug in PersistedData.isArray()

In #5062 it was noted, that for some reason the PersistedData for a JSON object returns true for isArray() - and not only for actual JSON arrays.
This issue was worked around in the PR by an additional check because a JSON object is also a "value map",
However, it is unclear whether this is specific to JSON or a bug in PersistedData...?
This should be investigated in more detail and potentially fixed in PersistedData

this is not a security issue, so close until it becomes a real bug :)

This is a potential bug that needs to be investigated further.
Most of our bugs are no security issues, but that doesn't mean they shouldn't be investigated and fixed.


Interferon terms

Good morning,
I would like to kno
w why there is not an intermediary term between cytokine production and the different type of interferon production. I suggest the term interferon production between them. And to do the same in every cytokine related terms and the different types of tinterferon. What do you think about that?

Hello @Ayllonbe
Sorry about the long delay !
This is what the GO has today:

cytokine production
-- type I interferon production
---'interferon-alpha production'
---'interferon-beta production'
---'interferon-delta production'
---'interferon-epsilon production'
---'interferon-kappa production'
---'interferon-omega production'
---'interferon-tau production'
-- 'type III interferon production'
--- 'interleukin-28A production'
---'interleukin-28B production'
---'interleukin-29 production'

What are you suggesting we add ?
Thanks, Pascale

Hi!
I think that adding the terms interleukin production and interferon production as subclass of cytokine is better than using a narrow synonym. I would propose that:
cytokine production

interferon production
-- interferon type I production
-- interferon type II (interferon gamma synonym)
-- interferon type III
--- interferon lambda 1 (interleukin-28A production synonym)
interleukin production
-- interleukin-2 production
...

Thanks
Aaron

Hi,
I've added the two parents.

Hi!
Yes, I think that it is more evident to explore the GO structure. If the
change you have in every cytokine case (cytokine production, cytokine
response....) could make the ontology more readable. Only if the community
is agreeing with that.
thank you for listening to me.
Regards
Aaron Ayllon Benitez
On 13 February 2018 at 13:38, pgaudet<EMAIL_ADDRESS>wrote:

Hi,
I've added the two parents.
[image: image]
https://user-images.githubusercontent.com/4782928/36150207-320507d6-10c3-11e8-85e0-db6c59880ae7.png
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/geneontology/go-ontology/issues/14140#issuecomment-365254853,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG79o-DJ9H8JTt1fPMan4T9Li2zRy30cks5tUYJRgaJpZM4PJyo2
.

@addiehl @RLovering (who else works in immune-related processes?)
Is that OK with you ?

this makes sense to me

I am totally opposed to this change, as I have argued on multiple occasions in the deep past.  Unfortunately, it is difficult to dredge up some of my earlier argumentation as it is buried in dead email accounts and old SourceForge entries, so I will have to try to summarize it here.
The division of cytokines into "interleukins" and "non-interleukins" is an arbitrary lexical division that reflects the tortured history of naming proteins in immunology rather than any shared structural or functional characteristics among the proteins called interleukins vs those that are not.  This is in sharp contrast to the chemokine (and their receptors), which share strong structural homology and general functional roles, and similarly to the interferons, which again share strong structural homology and somewhat more varied but general functional roles.
I suggest that all parties to this discussion read PMID:12103349 and PMID:12464567.  The designation of a newly discovered cytokine as an interleukin was at one point a point of pride and envy among immunologists and this trend was recognized fairly early on (PMID:1934243), but the application of the "interleukin" designation was arbitrary in that some researchers just didn't bother.  On the other hand, we have such things as the non-existant "IL-14", which was claimed on fairly weak evidence and genomic sequencing data that was disavowed by most of the original authors (PMID:8755619), reflected in the fact that there is no official IL14 gene in human or mouse.
The argument that adding interleukin grouping terms makes the ontology more "readable" is a completely non-ontological notion.  When we create grouping terms in the GO, such terms should be created because of commonalities that go beyond arbitrary naming.  There are much more useful ways one could group cytokine related terms, if people actually concerned themselves with structure and biological activities, and indeed, I had once worked on this at one point over a decade ago but gave up due to other responsibilities.  Key point: If you are searching for terms by reading the ontology instead of using a search function, then you need better training in the use of AmiGO and other ontology browsers.
Sorry for being so contrary, as always,
Alex

Hi @addiehl https://github.com/addiehl,
Thank for your honest and well-documented response. My purpose with that
extension in the cytokines classification was totally from the point of
view of the application. I work with similarity method exploiting the
bio-ontologies and I found weird that interferon-alpha production has the
same similarity with interferon-gamma production and interleukin IL-2
production only because they share the same ancestors subClassOf. I am not
a specialist in the cytokines fields (I have only some notions), and
obviously, IFN and IL have strong structural homology and strong general
functions, but they have a difference between them (still the strong
similarity), for that, they have different names (chemokine, interferon,
interleukine) and not only interleukine. Well, maybe I am totally wrong
with this suggestion, but I thought that could be a good solution to
similarity constraints.
Again, thank you for your response
Regards
Aaron
On 13 February 2018 at 16:25, Alexander Diehl<EMAIL_ADDRESS>wrote:

I am totally opposed to this change, as I have argued on multiple
occasions in the deep past. Unfortunately, it is difficult to dredge up
some of my earlier argumentation as it is buried in dead email accounts and
old SourceForge entries, so I will have to try to summarize it here.
The division of cytokines into "interleukins" and "non-interleukins" is an
arbitrary lexical division that reflects the tortured history of naming
proteins in immunology rather than any shared structural or functional
characteristics among the proteins called interleukins vs those that are
not. This is in sharp contrast to the chemokine (and their receptors),
which share strong structural homology and general functional roles, and
similarly to the interferons, which again share strong structural homology
and somewhat more varied but general functional roles.
I suggest that all parties to this discussion read PMID:12103349 and
PMID:12464567. The designation of a newly discovered cytokine as an
interleukin was at one point a point of pride and envy among immunologists
and this trend was recognized fairly early on (PMID:1934243), but the
application of the "interleukin" designation was arbitrary in that some
researchers just didn't bother. On the other hand, we have such things as
the non-existant "IL-14", which was claimed on fairly weak evidence and
genomic sequencing data that was disavowed by most of the original authors
(PMID:8755619), reflected in the fact that there is no official IL14 gene
in human or mouse.
The argument that adding interleukin grouping terms makes the ontology
more "readable" is a completely non-ontological notion. When we create
grouping terms in the GO, such terms should be created because of
commonalities that go beyond arbitrary naming. There are much more useful
ways one could group cytokine related terms, if people actually concerned
themselves with structure and biological activities, and indeed, I had once
worked on this at one point over a decade ago but gave up due to other
responsibilities. Key point: If you are searching for terms by reading the
ontology instead of using a search function, then you need better training
in the use of AmiGO and other ontology browsers.
Sorry for being so contrary, as always,
Alex
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/geneontology/go-ontology/issues/14140#issuecomment-365299880,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG79o7F4-27MWFIMSMD497mygkl1sCFBks5tUalYgaJpZM4PJyo2
.

The only shared similarity across all the cytokines that happen to be called interleukins is the name.  This is not the situation for the chemokines and the interferons.  There are a number of protein families represented by certain subsets of interleukins, but some of those protein families have members which do not happen to be named interleukin-X, even though in a different universe they might well be.
Grouping terms based on the "interleukin" name only serve to suggest that naming, no matter how arbitrary, is an appropriate principle for structuring the Gene Ontology.  This is in fact completely contrary to why the GO was created in the first place.

So,
What do you think about to create only an intermediary class interferon
between cytokine and all type of interferons?
On 13 February 2018 at 18:18, Alexander Diehl<EMAIL_ADDRESS>wrote:

The only shared similarity across all the cytokines that happen to be
called interleukins is the name. This is not the situation for the
chemokines and the interferons. There are a number of protein families
represented by certain subsets of interleukins, but some of those protein
families have members which do not happen to be named interleukin-X, even
though in a different universe they might well be.
Grouping terms based on the "interleukin" name only serve to suggest that
naming, no matter how arbitrary, is an appropriate principle for
structuring the Gene Ontology. This is in fact completely contrary to why
the GO was created in the first place.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/geneontology/go-ontology/issues/14140#issuecomment-365337851,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG79o---vGMoQLfqY7rf0NMbSNKjkVnFks5tUcPqgaJpZM4PJyo2
.

Interferons are grouped by immunologists into three types, based on structural relatedness and functional characteristics.  Type I interferons include the interferon-alpha and interferon-beta as well as some lesser known interferons, and were originally associated with anti-viral immunity, though they have other immune modulatory effects.  Type II interferon, AKA interferon-gamma, is very well studied cytokine with a wide variety of effects on various cell types and is strongly associated with Type I immune responses.  Type III interferons, interferon-lamda 1, 2, and 3, are a separate group that are more recently discovered and associated with antiviral responses.  Interferon-lamda 1, 2, and 3 are also known as IL29, IL28A and IL28B, respectively, which points again to the arbitrariness of the application of the interleukin designation.
The grouping of the interferons by type is based again on structural and function similarities.  I do not strongly support a common "interferon production" term per se (as well as analogous terms), as we already have separate grouping terms for Type I and Type III interferon production as well as an interferon-gamma production term, but given the loose structural and functional similarities among the interferons, I can accept such a class, because of the structural relatedness and association with anti-viral immune responses, among other processes, seen for all interferons.

Alex and all,
How can we get better at having institutional memory about these things.
As you say there is a lot of info in trackers but hard to find.
What I often do in other ontologies is create a class and immediately
obsolete it, e.g. for "interleukin production". We can then provide a
short textual description and a link to the wiki (which can itself have
links to tickets if need be).
We also have 'interleukin production' as a narrow syn. I think this is
appropriate. But we can also annotate this with a link to a ticket or
page discussing why a term hasn't been created. Currently there is not a
good way to know whether NARROW means (a) this is a true subclass but
not we haven't got round to making a subclass or it's not important
enough (b) this is an inappropriate concept but technically the scope is
still narrower.
We can also get better at using the wiki. We could have a category that
is 'biological modeling' or 'ontology content' and tag pages describing
design decisions in the ontology. This would be separate from the
technical editors docs on RTD. It may interweave with the DPs, but in
this case it's different. Yes this is work, but going back to find
previous discussions is also work...

Hi Chris,
I agree with your suggestions and hope that some version of them can be implemented.
Also, I did find a 2014 version of my objections, and I know there are email threads as well:
https://sourceforge.net/p/geneontology/ontology-requests/11250/
-- Alex

HI @cmungall
Is it possible to add a db cross reference to the GO wiki for the interleukin/interferon synonym? Otherwise I can add it to the 'comment' for now.
Thanks, Pascale

I think that's a good idea. This would be done as an annotation axiom using
the has dbxref property
On Feb 22, 2018 7:13 AM, "pgaudet"<EMAIL_ADDRESS>wrote:

HI @cmungall https://github.com/cmungall
Is it possible to add a db cross reference to the GO wiki for the
interleukin/interferon synonym? Otherwise I can add it to the 'comment' for
now.
Thanks, Pascale
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/geneontology/go-ontology/issues/14140#issuecomment-367711854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADGOf0F6b6KnQ6VGXg7uJQKtaEX3tHkks5tXYQhgaJpZM4PJyo2
.

Hello @Ayllonbe
So I ended up adding a link to this page:
http://wiki.geneontology.org/index.php/Why_isn't_interleukin_in_GO%3F
to the term 'cytokine production'.  Does that address the issue ?
(Maybe there are other terms to which this should be added - although there are so many of these terms I dont think we can be exhaustive, at least not with some manual edits).

WRT interferon, I don't think it's worth it to create  a grouping class for just two terms.
Let me know if this addresses the point you were raising, and apologies for the long delay for dealing with this !
Thanks, Pascale

I have added the same x-ref to the interleukin synonyms of:

GO:0004896 cytokine receptor activity
GO:0050663 cytokine secretion

I didn't do

response to cytokine
cytokine-mediated signaling pathway
regulation of cytokine production

Since these didn't have any 'interleukin' synonym. Let me know if I should add these.
Thanks, Pascale

Hello Pascale,
Yes the issue is about the term "cytokine production". I think the addition
to the interleukin synonyms is great and it is not necessary to add
interleukine.
Thanks for listening and don't worry for the delay.
Regards
On 23 May 2018 at 13:12, pgaudet<EMAIL_ADDRESS>wrote:

I have added the same x-ref to the interleukin synonyms of:

GO:0004896 cytokine receptor activity
GO:0050663 cytokine secretion

I didn't do

response to cytokine
cytokine-mediated signaling pathway
regulation of cytokine production

Since these didn't have any 'interleukin' synonym. Let me know if I should
add these.
Thanks, Pascale
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/geneontology/go-ontology/issues/14140#issuecomment-391309594,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG79ow1AtqEJTNc7lHuOz1ESJFbN_lU0ks5t1UQLgaJpZM4PJyo2
.

--
Aarón Ayllón BenítezPhD Student in Bioinformatics**INSERM U1219 - Erias
team and CNRS (UMR 5800) - MABioVis team - LaBRI, Université Bordeauxp:+33
(0)5 40 00 38 83a:351, cours de la Libération F-33405 Talence cedex, France
<EMAIL_ADDRESS>

Great ! Thanks for your feedback.


Cannot read Property 'multi' of undefined

came across this bug today, probably when options weren't declared
`ERROR: G:\Discord*****\node_modules\nedb\lib\datastore.js:568
multi = options.multi !== undefined ? options.multi : false;
^
TypeError: Cannot read property 'multi' of undefined
at Datastore._update (G:\Discord*\node_modules\nedb\lib\datastore.js:568:19)
at G:\Discord*\node_modules\nedb\lib\executor.js:40:13
at Object.process (G:\Discord*\node_modules\async\lib\async.js:731:21)
at next (G:\Discord*\node_modules\async\lib\async.js:728:27)
at Immediate. (G:\Discord*****\node_modules\async\lib\async.js:24:16)
at runCallback (timers.js:696:18)
at tryOnImmediate (timers.js:667:5)
at processImmediate (timers.js:649:5)`

This was caused by incorrect variable's being sent in the wrong order
Would like to see some better error handling than an exit with exit code -1


buildPython*: bring back buildPython*.override

Like packages, build helpers returned by callPackage have their own override that can produce a customized version of them with specific dependencies overridden. However, the current implementation of makeOverridablePythonPackage (the function that adds .overridePythonAttrs to the packages buildPython* returns) doesn't consider such <function>.override attribute, causing buildPython*.override to get lost.
This PR fixes makeOverridablePythonPackage and unshadows buildPython*.override, making it possible to override the dependencies of buildPython*. E.g., buildPythonPackage.override { unzip = unzip-custom; } returns a derived version of buildPythonPackage with the unzip package overridden with unzip-custom.
This is a much simplified and less controversial version of #271762.
This PR causes no rebuild and is fully backward compatible.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux


What about logging for client-side code?

I ran into an interesting issue using the logging the repo has enabled using pino & @logtail/pino packages in src/libs/Logger.ts.
I started seeing the following error
NextJS pino Error: Cannot find module <local-repo-path>/.next/server/chunks/lib/worker.js
After some significant digging, I realized that the logging using pino with logtail is limited to server-side operations only, and by mistake I was using the logger in client-side components page.tsx etc. As pino uses worker threads from NodeJS, which is not available on client side, understandably build process was running into "Cannot find module". Unfortunately, the error messages showed no hints, and it was super hard to find what was going on, at least for a newbie like me 😄
Questions

As one is developing their client side UX, there can be a lot of bugs/misbehaviors over there too. How would one generate+get logs to investigate such client-side issues? - What is the suggested best practice that nodeJS and nextJS devs use?

One option I see is to use @logtail/browser for generating client-side logging - but that will make the logging functionality complicated to keep the logic and behaviors consistent on both client and server side. Also, as users grow, the volume of logs generated will become exponentially high and it will become a needle in a haystack to have all those logs be sent to betterstack. I guess one can have some flag in setting to enable sending detailed logs to betterstack with some session-ids to be able to point out to.

I  tried out using @logtail/browser for client-side pages and it got complicated with nextJS's SSG optimizations resulting in some log statements executing during the build rather than at runtime - lol.

OR another option is to just use console logging for client side and ask the user to copy and send client-side logs from browser's console - which is not so user-friendly.

??

Besides investigating bugs - is product usage analytics of how users are using the product a valid usage of pino based logging? if no, what alternative packages should one consider for that?

@avibathula Indeed, it seems pino.js has better support for server side.
For now, I didn't find any solution working for both server and client side. It seems most of the solution is focusing on server side. There isn't any full-stack solution. I would love to hear any suggestion.
One solution is to use console.log for the frontend and use Sentry to collect the logs. This is definitively not ideal.

What do you use when building front end to ensure what you want is what is happening, as well as when debugging??
Get Outlook for iOShttps://aka.ms/o0ukef

From: Remi Wg @.>
Sent: Sunday, October 27, 2024 3:14:17 PM
To: ixartz/SaaS-Boilerplate @.>
Cc: Avi Bathula @.>; Mention @.>
Subject: Re: [ixartz/SaaS-Boilerplate] What about logging for client-side code? (Issue #46)
@avibathulahttps://github.com/avibathula Indeed, it seems pino.js has better support for server side.
For now, I didn't find any solution working for both server and client side. It seems most of the solution is focusing on server side. There isn't any full-stack solution. I would love to hear any suggestion.
One solution is to use console.log for the frontend and use Sentry to collect the logs. This is definitively not ideal.
—
Reply to this email directly, view it on GitHubhttps://github.com/ixartz/SaaS-Boilerplate/issues/46#issuecomment-2440193846, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABKCM64D3IWCAZ6E23CLFNLZ5VJSTAVCNFSM6AAAAABQVYGXE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGE4TGOBUGY.
You are receiving this because you were mentioned.Message ID: @.***>

I mostly use Sentry for frontend.


[ConstraintSystem] Add missing handling of Stmt * to getLoc

Something I have noticed while debugging a problem.

@swift-ci please smoke test

@swift-ci please smoke test Linux platform


Coordinate system tutorial

Motivation and Context
An updated version of https://github.com/facebookresearch/habitat-sim/pull/1498.
How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@dhruvbatra It turned out that even though the PR https://github.com/facebookresearch/habitat-sim/pull/1498 was open on Sep 22, 2021, the code was written so well that it works like a charm even after merging current main. I've also updated code to be more similar to other sim tutorials.
The updated cached colab version of the tutorial can be found here. Let me know if you wand something specific to be added/addressed.
Should I also add a corresponding doc page for the aihabitat website?

Yeah, @eundersander does has a habit of writing code like that 😄. Cached colab tutorial looks great! No comments.
Yes, let's add a corresponding docs page and list it in the docs. Thanks @rpartsey!

Looks like one of flaky tests is failing 3/3 times. The functionality that may impact the test wasn't touched and it is not reproducible on the other PRs.

Looks like one of flaky tests is failing 3/3 times. The functionality that may impact the test wasn't touched and it is not reproducible on the other PRs.

Fixed on habitat-lab side in scope of https://github.com/facebookresearch/habitat-lab/pull/1134.


2: plugin only works with string field type

Change Summary
Pertains to issue: https://github.com/typesense/gatsby-plugin-typesense/issues/2
Adds a new function to gatsby-node.js called typesenseGetValue, which checks the field type and converts the value to the correct type:

if a field is an int32/int64 the field value will be converted via the parseInt() function
if a field is of type float the value will be converted via the parseFloat() function
if a field is of type boolean, the value will be checked to see if it is either "0", an empty string or "false" returning false, otherwise true.

This works with a list of values and with singular values i.e. float & float[]
PR Checklist

[x] I have read and signed the Contributor License Agreement.

@nonapod Good catch and thank you for the PR! Looks good for the most part, I left some comments.
I've also updated CircleCI settings to run tests on PRs from forks, so the next commit you push to this branch should hopefully trigger tests automatically.

@nonapod Good catch and thank you for the PR! Looks good for the most part, I left some comments.
I've also updated CircleCI settings to run tests on PRs from forks, so the next commit you push to this branch should hopefully trigger tests automatically.

Hi @jasonbosco I've made a change or two to the tests however it looks like I'm running into this issue:
Failed: "[Typesense] Could not create collection pages_v1_1606802095152: TypeError: Cannot read property 'message' of undefined"
Would you have any immediate suggestions for this? If not I can dig in locally here and give it a crack. Thanks!

Awesome! Thank you.
The (unfortunately unhelpful) error message you’re seeing shows up when an
axios mock is missing in the tests and an actual request is attempted. I
can take a closer look tomorrow.
On Mon, Nov 30, 2020 at 10:13 PM Les Cordell<EMAIL_ADDRESS>wrote:

@nonapod https://github.com/nonapod Good catch and thank you for the
PR! Looks good for the most part, I left some comments.
I've also updated CircleCI settings to run tests on PRs from forks, so the
next commit you push to this branch should hopefully trigger tests
automatically.
Hi @jasonbosco https://github.com/jasonbosco I've made a change or two
to the tests however it looks like I'm running into this issue:
Failed: "[Typesense] Could not create collection pages_v1_1606802095152:
TypeError: Cannot read property 'message' of undefined"
Would you have any immediate suggestions for this? If not I can dig in
locally here and give it a crack. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/typesense/gatsby-plugin-typesense/pull/3#issuecomment-736247071,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADP5DYDMRN356BBXG35WGTSSSCO5ANCNFSM4UHCW5EA
.

--
Jason Bosco
Co-founder
Typesense

@nonapod Turns out the mock was missing one more field, which is why the test failed. I've added it here: https://github.com/typesense/gatsby-plugin-typesense/pull/3/commits/7bcb6e46749573d5ddd9935411075e0805595457#diff-bfc1a899a2cb64cb566a7038666804adc7ffce33432f942bfdba634769ecd5d9R130
To make debugging easier in the future, I've also enabled verbose logging in the tests, so we'll know the last request that was made. We can then use that to know which mock has the issue.
Thank you again for the PR! I'll merge it in shortly.

I've published this to NPM as v0.2.0.

@nonapod Turns out the mock was missing one more field, which is why the test failed. I've added it here: 7bcb6e4#diff-bfc1a899a2cb64cb566a7038666804adc7ffce33432f942bfdba634769ecd5d9R130
To make debugging easier in the future, I've also enabled verbose logging in the tests, so we'll know the last request that was made. We can then use that to know which mock has the issue.
Thank you again for the PR! I'll merge it in shortly.

Thanks @jasonbosco will help out in future if I encounter anything else!


Validation/processing of QCArchive records

Description
Drafting part of the backend for automated benchmarking. The scope here is to look at a QCArchive record and make an educated estimate of whether or not the output from quantum chemistry is sufficiently different from the SMILES/CMILES representation to invalidate it for benchmarking purposes. There will be many ways of doing this; my first pass is just throwing the OpenEye toolkit at it and seeing if something sensible comes out.
Most of the discussions for context have happened elsewhere, but https://github.com/openforcefield/cmiles/issues/36 is the sort of case we are looking to catch (among others).
Todos
Notable points that this PR has either accomplished or will accomplish.

[ ] Split out and capture other "failures" as a set of validation flags
[ ] Allow user overrides of default values of validation flags
[ ] Add test cases of the molecules that trigger the above
[ ] Don't rely exclusively on OpenEye
[ ] Construct a spreadsheet/database that ties records to their validation results as booleans, to prevent redundant calculations
[ ] Use the above data to skip validation (?)

Questions

[ ]

Status

[ ] Ready to go

CI for this idea won't pass until QCSubmit is on Anaconda or I hack together a temporary workaround. I will also be adding an example notebook that shows off this approach


Checkbox table

Problem Description
I am trying to use the react-table as a checkbox table.  That is, the first column will be checkboxes, which in turn should select the row.  I am able to select the checkboxes in my application, but once I sort it, the checkbox column do not get sorted.  Also for some reason in the pen, the checkboxes are not coming up correctly.
I feel there might be a better way to implement this.  Is there a better way to implement a Checkbox table using react-table?
Code Snippet(s) or Codepen (http://codepen.io/tannerlinsley/pen/QpeZBa?editors=0010)
https://codepen.io/poushy/pen/jwwyxQ
Steps to Reproduce

Bring up the table with checkboxes
Click on one or two row checkboxes
3.Sort the table
Even though rest of the table gets sorted, the checkboxes do not get sorted. That is, if I select row1, and row3, then sort and row1 and row3 goes to the bottom, the selected checkboxes remain at the same row.
Expected: The rows that are selected should be sorted correctly, i.e. row1 and row3 should be selected.

Here is an example:
https://codepen.io/aaronschwartz/pen/WOOPRw?editors=0010

Thank you @aaronschwartz - I will try this out!

@aaronschwartz I have the same question. In your example, I want have a checkbox in the header, if the user clicked it. All checkbox in the rows will be checked. I been working on this for a while...

@hijoncon See updated pen.

I'd really appreciated it! @aaronschwartz thank you!


use closures with preserved names as option handler functions

this pr aims to simplify this file in terms of:

no need to actively declare new functions state gets passed to
no need to pass through state down the runtime chain

Needs a rebase


Can't right click the kettle at all.

I don't know if this is an intended feature at all or if I'm doing something wrong, but whenever I click the kettle, even with an open hand, it simply just doesn't work. I'm using quite a large mod set, and I can provide a list if needed. But if this is an intended feature at all, please let me know. I really appreciate the work you put in porting this, and I hope I can be able to use your mod.
Thanks,
Fahdi

same issue here I've be unable to fully migrate my personal mod pack because farmers respite dose not wok in 1.20.1 either in a modpack or on its own(version 3.0.2)

I'm having the same issue. I tested with only the following mods and the problem still happens:
fabric-api 0.92.2+1.20.1
farmersdelight 1.20.1-2.1.6+refabricated
farmersrespite 3.0.2
sodium 0.5.11+mc1.20.1
my console output gives me the following error when I right click a kettle:
Failed to handle packet net.minecraft.class_2885@66e3fd4f, suppressing error
java.lang.IllegalArgumentException: [Fabric] Extended screen handler farmersrespite:kettle must be opened with an ExtendedScreenHandlerFactory!
at knot//net.minecraft.class_3222.handler$bbh000$fabric-screen-handler-api-v1$fabric_storeOpenedScreenHandler(class_3222.java:4898)
at knot//net.minecraft.class_3222.method_17355(class_3222.java:1041)
at knot//com.chefsdelights.farmersrespite.common.block.KettleBlock.method_9534(KettleBlock.java:119)
at knot//net.minecraft.class_4970$class_4971.method_26174(class_4970.java:1133)
at knot//net.minecraft.class_3225.method_14262(class_3225.java:343)
at knot//net.minecraft.class_3244.method_12046(class_3244.java:1140)
at knot//net.minecraft.class_2885.method_12547(class_2885.java:34)
at knot//net.minecraft.class_2885.method_11054(class_2885.java:8)
at knot//net.minecraft.class_2600.method_11072(class_2600.java:22)
at knot//net.minecraft.class_3738.run(class_3738.java:18)
at knot//net.minecraft.class_1255.method_18859(class_1255.java:156)
at knot//net.minecraft.class_4093.method_18859(class_4093.java:23)
at knot//net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:782)
at knot//net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:164)
at knot//net.minecraft.class_1255.method_16075(class_1255.java:130)
at knot//net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:764)
at knot//net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:758)
at knot//net.minecraft.class_1255.method_18857(class_1255.java:139)
at knot//net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:743)
at knot//net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:675)
at knot//net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265)
at java.base/java.lang.Thread.run(Thread.java:833)

Is a fix for this planned in the near future?

Y'all I found an unofficial patch that fixes this issue
https://github.com/Adlumia7/Farmersrespite-Fabric/releases/tag/v3.0.8


⚠ Jenkins Plugins Artifactory has degraded performance

In 9cdf028, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1199 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 0425d73 after 13 minutes.


Fix clippy::useless_let_if_seq / clippy::equatable_if_let warnings.

Objective

Fix clippy::nursery lints clippy::useless_let_if_seq & clippy::equatable_if_let warnings.

Solution

Generally followed clippy's advice.  Some were of simple form "if let a = b {}" which became "if b == a {}", while others were of the form "let {mut} a = b; if c { a = d};" which became "let a = if c { d } else { b };"

NOTE: resulting code was untested except for passing automated CI tests

I've left feedback on each change. Some of these are great, others are less clear, and one should be refactored to a match statement.


bcm283x: Fixes #226: unrolling DMA controlBlocks

The DMA controlBlocks are unrolled and the parameter txLen is set to a fixed value.

Codecov Report

Merging #440 into master will increase coverage by 0.03%.
The diff coverage is 61.11%.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   63.47%   63.51%   +0.03%
==========================================
  Files         122      122
  Lines       12549    12555       +6
==========================================
+ Hits         7966     7974       +8
+ Misses       4360     4358       -2
  Partials      223      223

Impacted Files
Coverage Δ

host/bcm283x/dma.go
43.46% <61.11%> (+0.69%)
:arrow_up:

devices/lepton/lepton.go
88.41% <0.00%> (+1.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b7fa6...d586fd8. Read the comment docs.

gohci


[Feature Request] Consider allowing the ability to opt-out of distributed tracing for expected HTTP error responses

Summary
In some situations, service calls return an HTTP response code in the range normally interpreted as an exception though that response is an expected and normal scenario to the consumer of the associated client library.   For example, when using an If-Match constraint with the Storage client library when updating metadata for a blob, a mismatch in the ETag results in an HTTP 412 (Precondition Failed) response.
While this status code is semantically correct, it is also considered an expected and normal scenario to some callers.   For example, the Event Processor client library will attempt to claim ownership of a partition by making a conditional request.   Since multiple processor instances are competing for ownership, it is expected that the conditional request will not succeed for the majority of them.   In this case, the Event Hubs client handles the resulting storage exception and considers it as part of the normal application path.
However, within the Storage client, the diagnostics scope considers the request a failure an emits the associated exception data.   When customers using the Event Hubs processor are integrating with Application Insights, they are seeing diagnostics information that indicates errors in their application, though these entries are not indicating actual problems and are just noise.
It may be worth considering if we wanted to include a feature that would allow consumers of a client library to declare expected response failures as such and avoid emitting error diagnostics for them.
Related Items

[BUG] Event Hub Processor Host - creating errors when checkpointing to blob (#9908)

//cc: @pakrym, @tg-msft

cc @lmolkova

Distributed tracing goal is to provide observability. We are tracing both: successful and unsuccessful requests i.e. you can tell that checkpointing failed or took longer than expected because there was something happening underneath. E.g. if you have a storage outage or configuration issue, and you know it's not EventHub SDK that misbehaves or it's not your app issue, but external dependency issue, but your storage call.
If you exclude (do not log the call to storage) customers could be confused with questions why it took so long, was this time spent in my process?
So I don't believe that simply not logging a call will help, but instead will bring other issues.
It seems the problem is that we should not consider 412 as failure (but still log the call).
And it's complicated here because component above (checkpoint) thinks it's a valid status code, but component below (storage) thinks it's a failure.
There are very few  controversial cases like that (401. 403, 404, 409, 412, 429 and perhaps that's it) where it's hard to tell whether it's an error or success.
So the proposal I see is: let's tell storage that we expect 412 here and it's ok, so let's not mark it as failure.
Here is why I think it will not solve the problem:
The behavior to mark them as failures is actually Azure Monitor behavior (and even without EventHub SDK instrumentation, it will log HTTP calls to storage as failures).
We have the same logic for any other HTTP request (incoming and outgoing) and even if EventHub and Storage can change it, it will be inconsistent with telemetry reported for customer service.
Azure Monitor provides filters on the AppMap to filter out 4xx and we certainly need to do more to cover such cases.

I created a draft PR to patch up Storage as suggested at #9944.

We need a guidance from Azure Monitor here.

I believe this is the right issue even though the title could be updated for more general use cases.
In our situation, we make calls to get a blob that may or may not exist; if it does, we do something, if it doesn't, we do something else. In this case, getting 404 is a legit case. Dealing with this using an exception means:

We get error logs in Application Insights and in our log files; we can filter Error and Warning logs, but then we also lose legitimate Azure-Core errors.
While it's not major, we still "pay the price" of having exceptions thrown, while it's a best practice not to throw exceptions (mostly for performance reasons) for such cases. We could make a call to ExistsAsync before, but then we pay for a full roundtrip, and it won't guarantee that in the meantime the file wasn't created/deleted.

409 Conflict is also an expected case, for example for caching we might check if an entry exists, if not we generate the data and save it. If another instance saved it too in the meantime, it's fine.
As @lmolkova it depends on specific case, so I think what's needed here is a way to specify expected status codes when doing the request, for example:
await blobClient.DownloadToAsync(
  stream,
  expectation: new BlobRequestExpectations
  {
    successStatusCodes = new[]
    {
      StatusCodes.Status200OK,
      StatusCodes.Status404NotFound
    }
  }
);

Is there any progress on this? Seeing that this issue has existed for 2 years makes me kinda sad.
I hook into the ILogger for some custom log targets, and I get this noise as well which is incredibly annoying.

The required APIs should be available now in Azure.Core to be able to implement this feature.  In order to suppress distributed tracing for a given status code, AddClassifier() should be called on RequestContext prior to passing it to the method in question.  An example can be found in the TableServiceClient here.
Please reach out with any remaining questions on implementation.

@annelo-msft What about the Azure.Storage.Blobs client? As far as I can see, this is only implemented in the Azure.Data.Tables client, and only specifically for 404 on DeleteIfExists, 409 on CreateTableIfNotExists, and 404 on GetEntityIfExists.
Or is there a way that I, as a user of these libraries, can modify the RequestContext instead of having to rely on the (relatively slow) implementation on the Azure SDK team's part?

Hi @Archomeda - you're correct that this is only implemented in Azure.Data.Tables currently.  As I understand it, this issue tracks the work to incorporate the feature in the Storage libraries.  @seanmcc-msft is driving that work.  My understanding of the process is that the client feature crew will work with architects to determine how to expose this functionality on those libraries.  They do have the option to expose the RequestContext directly to give callers full control of the pipeline on a per-request basis.

Related (duplicate): #33690

Hi @jsquire, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.


[move-model] Represent Move attributes in the move-model.

Attributes weren't yet represented in the move-model. This PR adds a representation and extends the model builder to translate them from the expansion AST.
Motivation
Attributes in the model are needed for playing with EVM code generation, and possibly also Jazz.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
NA
Related PRs
NA

:broken_heart: Test Failed - ci-test

/land


sdk: make qualifier_attr dep optional

Problem
solana-sdk depends on qualifier_attr but only uses it when the dev-context-only-utils feature is activated.
Summary of Changes
Makes qualifier_attr a dependency only when dev-context-only-utils is selected

Buildkite errors look unrelated?
called `Result::unwrap_err()` on an `Ok` value: "{\"programId\":\"Eed4HpWg1eDoJ1K1fRyWjwU9xhvvx9vu2dfThYRNCYqh\",\"signature\":\"51AgqiyatpuKU1VSdCHFt57FX7m8RjdYoAdqCGzLddaqqB2whRpWaCTSeMKrT5JuZyzV5c3iEfvz8EuD3mY1ijFf\"}"

On my machine the failing test only fails sometimes

On my machine the failing test only fails sometimes

Yes, it's known flaky. I don't think the failure is related to your change

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.2%. Comparing base (075c790) to head (71e64e3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1088   +/-   ##
=======================================
  Coverage    82.1%    82.2%
=======================================
  Files         880      880
  Lines      235597   235597
=======================================
+ Hits       193632   193673   +41
+ Misses      41965    41924   -41


fix(operator): add OwnerReference for controller

Purpose of PR?:
Earlier controller deployment uninstallation was failing during helm uninstallation due to a lack of ownership of the controller. This PR adds the operator as the owner of the controller deployment
Fixes #1638
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[X] Bug fix. Fixes #1638
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[X] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

I have tested the functionality and controller uninstalls successfully.

The failing test seems to be flakey. It passed with a few retries showing the same error in the last push.

@rootxrishabh can you please rebase the PR. thanks


GreenDroid and ViewPager

I'm using GreenDroid in my app and my classes are extending GDActivity.
I'd like to use in futre ViewPager (do something like G+ oraz new Android Market view pager).
I'd like to confirm, but it is impossible to use it with GreenDroid?
ViewPager is working on Fragments, and then I should extend FramgmentActivity not Activity.
http://android-developers.blogspot.com/2011/08/horizontal-view-swiping-with-viewpager.html

Using GreenDroid with the Android compatibility package is completely possible. The only thing you have to do is to extend FragmentActivity and handle the ActionBar on your own. Keep in mind the ActionBar is actually a regular View you can add in your layouts ...


Implement DictSquashUpdatePtr

Fixes #293

@har777  you have a conflict, can you resolve it?

@har777 you have a conflict, can you resolve it?

Done!