Units of positions, masses and accelrations?

Hi Mike
What units are the positions and masses expected to be in and what are the units of the returned acceleration?
Kind Regards
Jordan

Whatever you want! The acceleration you get will be in units of (your supplied G) * (your supplied masses) / (units of your supplied coordinates)^2


Attempt to make the migration use django-fsm to set state on migrated…

I found out that the migrate_rr_applications.py is not longer working. I believe I have traced it to the switch to django-fsm.
This is me attempt att fixing it but I got stuck on "PermissionDenied: Invalid "accepted" transition", see full traceback below.
If I skip running "perform_transition()" the import seems to work as it should.
$ m migrate_rr_applications var/otf_export_2018-06-20/otf_rapid_response_application_export.json
Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/frjo/.virtualenvs/otf-django/lib/python3.6/site-packages/django/core/management/__init__.py", line 371, in execute_from_command_line
    utility.execute()
  File "/Users/frjo/.virtualenvs/otf-django/lib/python3.6/site-packages/django/core/management/__init__.py", line 365, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/frjo/.virtualenvs/otf-django/lib/python3.6/site-packages/django/core/management/base.py", line 288, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/Users/frjo/.virtualenvs/otf-django/lib/python3.6/site-packages/django/core/management/base.py", line 335, in execute
    output = self.handle(*args, **options)
  File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/contextlib.py", line 52, in inner
    return func(*args, **kwds)
  File "/Users/frjo/Sites/otf-django/opentech/apply/funds/management/commands/migrate_rr_applications.py", line 245, in handle
    self.process(id)
  File "/Users/frjo/Sites/otf-django/opentech/apply/funds/management/commands/migrate_rr_applications.py", line 291, in process
    submission.perform_transition(status, lead)
  File "/Users/frjo/Sites/otf-django/opentech/apply/funds/models.py", line 589, in perform_transition
    raise PermissionDenied(f'Invalid "{ action }" transition')
django.core.exceptions.PermissionDenied: Invalid "accepted" transition

@frjo I've pushed some changes that fix the issue. Can you test locally?

Works very well locally, thank you.

Will create a new branch for each content type based on this branch.


Editable number cells

This adds editing functionality to number cells in tables. There is some frontend validation:

while editing: the input box will have a red outline if the text is not a valid number
when submitting (shift + enter): the box will shake if the text is not a valid number and will not a call cellEdit

A valid Java number falls into one of these three cases (regardless of data type):

An empty string '', which is treated as 0
The string 'NaN', which is treated as NaN
Anything that returns false from isNan()

Codecov Report

Merging #333 (c18e61a) into main (9ee4c6a) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   67.47%   67.25%   -0.23%
==========================================
  Files         245      246       +1
  Lines       13121    13210      +89
  Branches     1892     1865      -27
==========================================
+ Hits         8854     8884      +30
- Misses       3840     3889      +49
- Partials      427      437      +10

Flag
Coverage Δ

unittests
67.25% <100.00%> (-0.23%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...tive/app/src/lib/component/core/number/__init__.py
100.00% <100.00%> (ø)

... and 19 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Stop using go modules. They don't work yet.

Signed-off-by: Ronald G. Minnich<EMAIL_ADDRESS>

People can do their own go get if they have to. This situation is not working for modules just now.

People can do their own go get if they have to. This situation is not working for modules just now.

Module usage already removed by https://github.com/Harvey-OS/harvey/pull/1065

Module usage already removed by https://github.com/Harvey-OS/harvey/pull/1065


Mini player becomes unresponsive

Once you hover over the stars they seem to take the foreground and then make the whole miniplayer unresponsive until radiant is closed and reopened.
None of the buttons in the mini player work when its in this state. The progress bar and track information will update though.

Version: 1.3.3

I have the same issue, except the controls are still responsive for me. It seems that there's no code being called to hide the rating bar after it's been activated.

Google look to have removed the 5 star ratings option, and I can't seem to replicate this with the thumb up/down system  https://productforums.google.com/forum/#!topic/play/HwKmVF5N5YA


WIP: NOOBS support

This is the first draft of NOOBS support. Even if the Raspberry Pi Foundation probably won't include this, it could be added to https://github.com/procount/pinn, a fork of NOOBS (OS list at https://github.com/procount/pinn-os). I created some images, replace them if you don't like them

Thanks for this, @AaronDewes. I've not used NOOBS personally, but from what I see online it's like an OS installer image for Raspberry Pi?
Can you please share more details on what exactly does it achieve?

Yes, It is an OS installer which can install multiple OSes on one SD card. It contains a list of OSes suitable for the RPi running from it, which it gets from the RPi Foundation (NOOBS) or procounts repos (PINN)

As this PR itself doesn't work yet, please check export-noobs/00-release/files/marketing/slides_vga/A.png and export-noobs/00-release/files/marketing/slides_vga/B.png. These are images displayed during install telling more about the OS you can add more or remove/replace my images, they are just examples. The first one is based on your website, the second one on the README of this repo.

Closing this PR, as this is incompatible with PINN (because PINN also can use external USB drives which makes umbrel incompatible with PINN) and umbrel is not likely to be added to NOOBS.


can't login

after installation , trying to login to the dashboard i get
"Login failed. Please check your credentials and try again."

fyi: I found that --config-name=local_llm worked but --config-name=local_llm_neo4j_kg resulted in this symptom. Change the database provider from pgvector to postgres solved the issue for me

no matter what i do it shows errors reading the config file
it happens when i --config-name=local_llm do this config

fyi: I found that --config-name=local_llm worked but --config-name=local_llm_neo4j_kg resulted in this symptom. Change the database provider from pgvector to postgres solved the issue for meFYI: 我发现 --config-name=local_llm 可以工作，但 --config-name=local_llm_neo4j_kg 导致了这个问题。将数据库提供者从 pgvector 更改为 postgres 解决了我的问题

how to change it fastly?

when using knowdelge graphs cannot log in even change vector dabase from pgvector to postgres

yea exactly my problem
I like the idea of this software so much
I just wish it could work ,
i am sorry i am not a coder myself i wish i could contribute to this project

Hey @Mikemansour we shipped version v0.2.84 today which should solve this problem. If you're running Docker, you might have to prune your images (Docker likes to cache versions, and you'll need to make sure that your R2R container is updated!).
Hope this helps, but let me know if you run into any issues!

Hey @Mikemansour we shipped version v0.2.84 today which should solve this problem. If you're running Docker, you might have to prune your images (Docker likes to cache versions, and you'll need to make sure that your R2R container is updated!).
Hope this helps, but let me know if you run into any issues!

Thank you very much @NolanTrem . After cleaning up the R2R image and upgrading to version 0.2.84, there are no more errors. But I'm still curious, is this config a default configuration? If I want to use my own configuration, such as just changing the model called by ollama, what should I do? I saw the toml file demo in the knowgraph docs, but I didn't see a complete example of the toml file and how to use it (via the command line).

@NolanTrem  并且 我应该怎么进入neo4j的界面，我尝试了很多的neo4j的用户名和密码都是错的

now it can login but still buggy

@Mikemansour it looks like your R2R CLI might be caught up, but Docker is using a cached image. In your logs it says that that it's starting R2R with version 0.2.76.

If you're fine wiping out your existing docker containers and can do a clean install, you might try running these commands (assuming you're on a Mac/Linux):
docker stop $(docker ps -a -q) This stops all existing running images
docker system prune -af --volumes This clears all of the containers and volumes from your docker.
docker network prune --force This cleans up any docker networks that were left in a bad state
docker volume rm $(docker volume ls -qf dangling=true) As a failsafe, this should clean up any remaining docker volumes that the first command didn't get
Then, just make sure that you're on the most recent CLI version by running r2r version—it should be v0.2.84. Then just run your command r2r serve --docker and your container should be good to go, and it will build with the most recent image.

I use the Mac M2 Pro , and I run the command of "r2r --config-name=local_llm serve --docker", there are two problems:
A) it shows the details of r2r container can't running in the docker desktop with the message that "lack of OPENAI_API_KEY and said that it's "ImagePraser need this key".
B) Can't log in (I am not sure whether it's the above problem related also or not)
Just for your reference and hope to get it solved soon , thx for attention.

A) it shows the details of r2r container can't running in the docker desktop with the message that "lack of OPENAI_API_KEY and said that it's "ImagePraser need this key". B) Can't log in (I am not sure whether it's the above problem related also or not)
Just for your reference and hope to get it solved soon , thx for attention.

You can set OPENAI_API_KEY to anything; I set it to "ollama". I guess this is because when the project starts, it imports the OpenAI client, which checks for OPENAI_API_KEY but doesn't actually use it.

I have the same issue after cloning the latest repo. I can't login and I had to spend over 3 hours just trying to get to login page. Sorry, that's completely unusable to me.  I wish it did work from the start.

@iSevenDays Which repo did you clone? Our recommended install process to use R2R and the dashboard is as follows:
pip install r2r
export OPENAI_API_KEY=sk-...
r2r serve --docker
Cloning the repo should be done if you want to contribute/develop on top of R2R for yourself.
The above commands will automatically launch the login page for you. The docs here are up to date, as far as I can tell. If you found something that was outdated, we'd love to know.
The video is outdated, but this is due to us iterating and implementing improvements quickly. It's an unfortunate consequence of creating static content like this. I'd love for you to get up to running with the project, so if the installation above doesn't work, please let me know. Happy to help more then.

On the latest version, completely clean install, on a linux server (headless), and when connecting to the server I get the login page, but when I set the server ip as the instance url it refuses first login.

@salja03-t21 Have you able to solve the problem ?

No, not yet. Have not paid much attention to it yet. Hopefully someone can help me to resolve it.

Any luck guys?

Wow still no answer!

No, not yet. Have not paid much attention to it yet. Hopefully someone can help me to resolve it.

@salja03-t21 it looks like you're trying to log into your dashboard using the URL at which your dashboard is deployed? The URL that you should use is for your R2R deployment.By default this is at localhost 8000. The dashboard needs to communicate with a server to work.
If you clear out any cached docker images and run r2r serve --docker I'm almost certain it will allow you to log in.


[Relay][Op] Remove reverse attribute from reshape and reverse_reshape operators.

Currently relay has separate operators for reshape and reverse_reshape however in c++ they were both implemented using shared functions. The weird part is that ReshapeAttrs has a reverse attribute that was used for reverse_reshape but not exposed in the python API of reshape. This often causes headaches when trying to create a new reshape operator in a pass from existing attributes, since python doesn't expect a reverse argument. As far as I can tell, there's no reason to have a separate reverse_reshape op. Consolidating the two and exposing reverse in python leads to a much cleaner and more obvious API without breaking any tests or use cases.

@vinx13 @icemelon9 @electriclilies can you guys take a look at this PR and let me know what you think?

Looks good to me! Thanks for getting this up quickly

Out of curiosity, what is the thinking around versioning of the relay ir ? Would the removal of nodes

@u99127 I think this change won't remove any nodes from the relay IR, since reverse_reshape just constructs a reshape node with the reverse attribute set to true. There is no standalone reverse_reshape op, only a constructor.
This makes transforming a graph with a reshape in it is difficult because when you encounter a reshape op, you must check the value of reverse in its attributes, then copy all of the attributes except for reverse to a new set of attributes, then pass those attributes into the reshape constructor or the reverse_reshape constructor depending on what the value of the reverse attribute is.

@tqchen i think we're gonna need your input to make a decision here. The issue Lily mentioned should be resolved. Our two options for fixing it are to consolidate the reshapes as in this PR, or create separate attributes and functions for reverse_reshape. Which do you prefer?

As a rule of thumb, we should always keep reshape consistent with numpy API. We can however, introduce additional attrs to reverse reshape given it is non-standard

Based on TQs feedback we should keep reshape and reverse_reshape separate. We can do this while resolving the hidden reverse attribute by splitting the type relationship for the two ops. I've updated this PR to do that instead. @icemelon9 can you take another look?

I think @tqchen and @icemelon9 need to take another look to confirm that these changes look good before we can merge. I believe this solution addresses their concerns while removing the hidden reverse attribute as elegantly as possible.

@icemelon9, I made the change recommended by TQ. This should now be ready to merge.


[future request] Forge Version

do you have a plan to port to Forge?

May be a bit late but I ported it to forge :)

thanks!


Get close matches

wf = Workflow("tesile")
wf.Composition = standard_nodes.UserInput("Aluminum")
wf.BoxSize = standard_nodes.UserInput(3 * [1.0e-5])
wf.Seeds = function_node(...)
wf.Grid = function_node(...)
wf.Elasticity = function_node(...)
wf.Plasticity = function_node(...)
wf.Phase = function_node(...)
wf.Homogenization = function_node(...)
wf.Material = function_node(generate_material, elements=wf.Compositions)

The previous error message in this situation was: Could not find attribute Compositions on tesile (Workflow) or among its children (dict_keys(['Composition', 'BoxSize', 'Seeds', 'Grid', 'Elasticity', 'Plasticity', 'Phase', 'Homogenization'])).. It was sort of difficult to figure out which one I wanted to say for this large number of possibilities. So I added get_close_matches to append the message: Did you mean 'Composition' and not 'Compositions'?
Also, in general I find the error messages in pyiron_workflow difficult to understand. It must be difficult for @liamhuber to figure it out alone so I'm gonna make suggestions in the upcoming weeks.

The same thing could be used also elsewhere (like io?)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 91.266%

Files with Coverage Reduction
New Missed Lines
%

mixin/semantics.py
6
96.69%

Totals

Change from base Build<PHONE_NUMBER>3:
0.02%

Covered Lines:
2999

Relevant Lines:
3286

💛  - Coveralls

The same thing could be used also elsewhere (like io?)

Yes, I imagine there's a few places where it's useful, but I couldn't name them all off the top of my head. When it's used as here to strictly add to the information returned, I am totally behind this.


Remove close message from stale bot

The message were saying that issue will be closed if no activity but we don't do that anymore

Good catch.


[Java] AtClientImpl refactoring to be similar to Dart SDK

Description
The _get, _put, and _delete methods in AtClientImpl.java should follow similar Dart SDK methodologies.
Tasks

[x] Implement key validation like in the Dart SDK (AtClientValidation)
[x] Write AtClientValidation junit tests
[x] Implement VerbBuilders (from, cram, pkam, llookup, lookup, plookup)
[x] Write VerbBuilder junit tests
[x] Assume SelfKey data is always encrypted (do not do Metadata.isEncrypted check)
[ ] Implement ResponseTransformers
[ ] Use llookup:all to both 1. get the data and 2. update the Metadata in the AtKey object. (Use Transformers)

Additional context
Comment from gkc: https://github.com/atsign-foundation/at_java/pull/29#issuecomment-1197502834
Comment from VJag: https://github.com/atsign-foundation/at_java/pull/29#issuecomment-1197799153

Tasks 3., 4., and 5., : https://github.com/atsign-foundation/at_java/pull/36

Tasks 1. and 2. (AtClientValidation) : #37

Tasks 6 and 7 done on local machine, waiting on #40 (aka #36) to be merged


Difference between AZP and VSTS?

I noticed some Micrososft agents require VSTS credentials, while others AZP.   Is VSTS depracted?  Which one should be used?  For example, when we pull an image from mcr.microsoft.com/azure-pipelines/vsts-agent it uses VSTS.  But when we build our own they require AZP info.   What is the difference??

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23328b13-f079-ad21-5d7a-6c640f25391c
Version Independent ID: 4a39889d-fa00-ae2b-aa43-f358631b7b1a
Content: Deploy a Azure Pipelines agent on Linux - Azure Pipelines
Content Source: docs/pipelines/agents/v2-linux.md
Product: devops
Technology: devops-cicd-agents
GitHub Login: @steved0x
Microsoft Alias: sdanie

@azilber Thank you for the feedback.
Please refer to issue https://github.com/MicrosoftDocs/azure-devops-docs/issues/8104 for further updates.

@azilber Are you talking about this section of the article: Authentication type
You have several different choices - when using Azure DevOps Services, you use a PAT - when you are using Azure DevOps Server or TFS, you have a choice, which depends on the TFS version and how you have configured the authentication for that server.
Am I misunderstanding? Please provide more info if I have, and I'll try to answer. Thank you.

I got some more context on this, vso, vsts, and azp, these are just the naming conventions for various artifacts and variables in the product, depending on the product name at the time that the item was added to the product (Visual Studio Online->VSO, Visual Studio Team Services->VSTS, Azure DevOps ->AZP). Also (as you see on some of the pages like variables) some of the old names map to the same variable as the new names (for backwards compat). Except in certain cases which would be called out (and I can't think of any offhand) if an older item was deprecated, it would be called out in the docs. Does this info help? Please reactivate this issue if you have more questions or a specific example you want us to look at. And thank you for your feedback.


GET /tests

Replace the current healthcheck with a resource on the above uri that returns a 200 if all tests passed in the last run or a 500 if one of them failed.
The body of the response will contain a list of each test with the test's name and status.... e.g.
[
{"testClass":"me.atam.atam4j.dummytests.PassingTest","testName":"testThatPasses","passed":true},
{"testClass":"me.atam.atam4j.dummytests.FailingTest","testName":"testThatFails","passed":false}
],"allTestsPassed":true}

I will be starting this this week.  If not, will let you know.
Cheers


I always get 401 unauthorized error when use test bot

I have read:

Usage information
Help information

I am using the latest version of the library.
I'm trying to connect my bot created in a test environment. However, even though I input the correct bot token, I keep getting a 401 unauthorized error.
this is my code:
import TelegramBot from 'node-telegram-bot-api';

require('dotenv').config();

const bot = new TelegramBot(TELEGRAM_TOKEN, {
  polling: true,
});

bot.on('message', (msg) => {
  const chatId = msg.chat.id;

  bot.sendMessage(chatId, 'Received your message');
});
bot.on('polling_error', (error) => {
  console.log({ error });
});

and this is my package.json
"dependencies": {
    "dotenv": "^16.4.5",
    "express": "^4.19.2",
    "node-telegram-bot-api": "^0.65.1"
  },
  "devDependencies": {
    "@types/express": "^4.17.21",
    "@types/node": "^20.12.12",
    "@types/node-telegram-bot-api": "^0.64.6",
    "nodemon": "^3.1.0",
    "ts-node": "^10.9.2",
    "typescript": "^5.4.5"
  }

I saw the testEnvironment option in api docs.
However, when I try to input 'testEnvironment' in the options, it says that it's not a valid option. Has the 'testEnvironment' option been removed? How can I develop using a bot deployed in a test environment?

@judy9712
Hi i've just bumped into this issue and suppressing the error helped, the API with test env still works
        // @ts-ignore         new TelegramBot(TOKEN || '', {polling: true, testEnvironment: true});
But it is still an issue with ConstructorOptions interface. I hope more comments will help devs to see it.

Same issue. Just created account in test environment, created 2 bots with bot father bot and neither of them works. Both returning 401 Unauthorized on getMy endpoint. Tried to revoke tokens and use new ones - no luck so far. Any thoughts?

@vsolovev have you tried the workaround from my comment above?

Same issue. Just created account in test environment, created 2 bots with bot father bot and neither of them works. Both returning 401 Unauthorized on getMy endpoint. Tried to revoke tokens and use new ones - no luck so far. Any thoughts?

The proper way is:
const bot = new Telegraf(env.TELEGRAM_BOT_TOKEN, {
  telegram: {
    testEnv: true,
  },
});

@rock1nbvv
you just supressed ts error, it does not have anything to do with 401 error

@timurrakhimzhan
As far as i remember i have suppressed the ts-error so the ts config would allow me to build the app using the configuration parameter that enables test env. And it seemed to me that i was working with test env eventually(i had other issues with it though)
Yet i did quite a while ago so correct me if i am wrong.


Refactor: use fully-qualified paths in Compact derives(Deon Branch)

@mattsse All done, create a new PR from Deon branch

@mattsse Is it okay if i apply for other issues, is that allowed?

sure, but please no more unrelated doc changes :)

Sure, duly noted


Spec : get rid of object patching

Adds expect(...).to matcher. Removes Object#should and Object#should_not. But leaves possibility to re-enable them with spec_enable_should macro.
Commits are made in a fashion to make them easier to read:

https://github.com/waterlink/crystal/commit/b9356aa6045c5315ac362647fd80c763880585eb - adds expect method and spec_enable_should macro.
https://github.com/waterlink/crystal/commit/aa5df1ecf258b4fad904942ca9d487d6398a7a43 - fixes all specs to use expect(...).to matcher (~ +5000/-5000, probably kills browser, so read from git directly)
https://github.com/waterlink/crystal/commit/0ec2ab6289de385ff0da5c60b075537e5cb01263 - a bunch of TODOs. I have encountered bunch of specs that are commented out, but seems like they want to be pending.
https://github.com/waterlink/crystal/commit/ab3caeb0a86e5d6acd3e7a5f8248c074fadd2225 - fixes template for crystal init to generate example_spec.cr with expect(...).to matcher style.

So, unexpectedly, doesn't change a thing about performance:
Before:
compile: 1:36 mins and 1.4GB of RAM
suite run: 3:04 mins and 1.6GB of RAM

After:
compile: 1:48 mins and 1.4 GB of RAM
suite run: 2:50 mins and 1.6 GB of RAM

Both compile steps were peaking for 1-2 seconds to 2 GB and then back to 1.4GB

This one might be hard to read from github (it may kill your browser). Better checkout it and look at commits diffs separately through git.

Will fail on travis, I forgot to check if I have some new shoulds in specs after rebase..

Now should be fixed

@waterlink There was a previous pull request regarding this: https://github.com/manastech/crystal/pull/334

It is still possible that someone would want to use #should on their domain objects. For example in some sort of rule engine, where you can describe rules and it will use exactly #should and #should_not for rules.
I consider expect form more readable then should, consider this example:
some_array
  .filter { ... }
  .map { ... }
  .reduce(...) { ... }
  .should eq(something)

Here #should call just gets lost in enumerable calls chain. The same with expect:
expect(
  some_array
    .filter { ... }
    .map { ... }
    .reduce(...)  { ... }
).to eq(something)

Much more readable.

On the other hand it is kinda surprise that Object gets 2 new methods only if you include certain std library.

and I find its block form extremely useful:
expect { ... }.to raise_error BlaBlaError, /.../
expect { ... }.to change { ... }.from(x).to(y)

@asterite feel free to close this one, if you feel like. I will probably create spec2.cr as a standalone library and include expect syntax there.

I'm actually considering merging this. You are not the only one to ask this, and it's not fair that just because I think should is OK it should be the de-facto way in our specs (no pun intended :-P).
I think we should vote this. Should we create a separate thread for the voting?
My pros and cons for expect are:
Pros:

No methods added to Object. We could even have expect be a method of the Spec module and include it in the top-level, so its documentation is in that module.
Readability: this is actually subjective, but it's nice to be able to spot expectations right at the beginning of a line. Plus you are forced to use parenthesis so the subject is clearly visible.
People coming from Ruby that use RSpec are probably using the expect syntax right now, and it'll be a surprise for them that we have the old syntax (even though Crystal != Ruby).

Cons:

You have to type more: lines are longer, you are forced to use a pair of parenthesis (which force you to use the shift key).
Projects will need to be updated to use the new syntax. But crystalshards says there are just 80 projects, and I don't think all of them have specs. Plus they won't have the massive amount of specs the compiler has. And it's not like we are on 1.0.

+1
The should syntax was for a long time a main reason to avoid RSpec in the Ruby community, mainly for the disadvantages already listed, adding two methods to every object and thus possible conflicts with libraries which want to use these names.

My vote is +1 obviously :)
If this gets merged, then I would like to fix small things I have mentioned in "todo" commit and probably after rebase there will be more .shoulds which need to be converted.

Having been through several languages, the expect syntax is actually a welcome changed. It supports a stronger separation of testing framework and application code, so there isn't a collision.
Examples of test frameworks I've used for comparison:

Jasmine for Javascript
it('has assertions', function() {
  expect(1).toEqual(1);
});

Ginkgo for Golang
It("has assertions", func() {
  Expect(1).To(Equal(1))
})

Implying that it is a pattern commonly used.
In short +1!

@asterite @jtarchie @jhass What do you thing about having more lightweight syntax then expect, which will not usually require lots of parenthesis to type in and will still preserve all the benefits of expect(subject).to matcher:
should subject, matcher
# or
must subject, matcher

Real example:
should file.contents, contain(a_substring)

Tbh. I don't think that reads well.

The pros far outweigh the cons for me. :+1: to expect.

:+1:  from me. i think expect reads better, zero monkey patching, and follows patterns of other BDD frameworks

So, looks like almost everyone up until now wants expect syntax.
And the questions are:

Should we support both syntaxes?
If yes, should we convert all current specs to expect syntax and disable should syntax for crystal, but allow it for other libraries out there?

@waterlink i would:

make expect official
update the stdlib specs to use expect
i'd add a deprecation warning to Object#should with a date/version set for removal

external packages still work, but have a deadline for updating

@waterlink Let's use the new expect syntax. I feel that most (if not all) people are OK with this change. Also, as time passes RSpec users will use expect and forget about should so having should in Crystal will feel old. And many other languages have the expect syntax as well.
I just pushed some commits. @waterlink I'm sure you used script or something to replace all should with expect. Can you run that script again and open a new pull request? I promise not to commit anything in between.
We can leave should  for now with a deprecation message, saying it will be gone in version 0.9. That is, the next release will still have it, with a deprecation warning, and it will be gone by 0.9. For now we can do something like this:
def should(...)
  {{ puts "Warning: 'obj.should matcher' is deprecated, please use 'expect(obj).to matcher'".id }}
  # here goes the original code, or maybe use `expect` here
end

That prints that message at compile-time when using it. I'd add a similar warning to should_not. Eventually we can add a @[Deprecated("msg")] attribute.

i not like expect and not use rspec >= 3 :)
don't know why all love it, for me it more typing

@kostya, you should definitely try it for more than couple of minutes :D
And more typing is not a big deal.. Usually developer's job is not to type
much, but operate on different text objects efficiently.
Actually, why I like expect syntax is because it sounds more naturally to
me:
"2+2 should equal 4"  vs   "expect 2+2 to equal 4".
The difference between two is that "should" version declares that '2+2'
should equal '4', but it doesn't reveals any intent that it actually
checks, that '2+2' is equal to '4'. "expect" on the other hand reveals the
action that really happens: it will expect 2+2 to equal 4.
"should" can have this capability if you say:
"assert 2+2 should equal 4" or "ensure 2+2 should equal 4". But it still
sounds a bit odd (have a better example?), I would go with "is" keyword in
this case:
"assert 2+2 is equal 4" or "ensure 2+2 is equal 4" or "check that 2+2 is
equal 4".
Effectively last 2 are the same as "expect 2+2 to equal 4" in their form:
"    ".
Yes the downside is that you need a bit more parenthesis, since Ruby and
Crystal is not native English language :)
--
Best Regards,
Alexey Fedorov,
Sr Ruby Developer, Clojure Developer, Rust Developer,
+49 15757 486 476
2015-05-05 1:43 GMT+03:00 kostya<EMAIL_ADDRESS>
i not like expect and not use rspec >= 3 :)
don't know why all love it, for me it more typing
—
Reply to this email directly or view it on GitHub
https://github.com/manastech/crystal/pull/564#issuecomment-98876069.

@kostya for me it's also more typing, and more parenthesis :-(
Such a hard choice to take!
I wonder if anyone really had a problem with should conflicting with their library methods. As far as I know the original problem was "delegation issues" with BasicObject and things that don't even exist in Crystal.
@waterlink As for semantic, I think that if you are going to write lots of specs it's better to have a short syntax. And I don't think anyone complained about that in RSpec < 3.
Actually, please hold on. I'll check with @waj if he agrees to change to the expect syntax.

eq() actually also add slowdowns to typing, best 1.should == 2, not 1.should eq(2)

+1 for expect to me. I agree with @waterlink as for being for readable.
As a twist...I've seen syntax like this in C++:
REQUIRE(a == b);

What if a macro were used instead? Something like:
expect a == 5

instead of:
expect(a).to eq(5)

Still readable but less typing.

@kostya I personally sometimes forgot to put the should, so I had some specs like some.long.expression == expected and of course that spec passes and there's no hint that you made a mistake. You can't do that mistake with eq. And I found that mistake in other's code.
@kirbyfan64 yes, it could be done with a macro, but adding matchers becomes harder because you would need to add cases to that macro. For now should/expect are fine.

@kirbyfan64 Then it becomes simple assert I think.

@asterite BTW, I haven't used script for that, just raw emacs+evil-mode + couple of recursive macro.

I wonder if anyone really had a problem with should conflicting with their library methods.

Not my experience, in fact I already had to educate people already that RSpec 3 has the ability to remove should completely, since they're were all like "RSpec?

@jhass they should definitely read these:

http://rspec.info/blog/2013/07/the-plan-for-rspec-3/
https://www.relishapp.com/rspec/rspec-core/v/3-0/docs/configuration/zero-monkey-patching-mode
http://www.rubydoc.info/github/rspec/rspec-core/RSpec/Core/Configuration:disable_monkey_patching!

@waterlink thanks, I know these ;)

@jhass what's the fundamental problem with adding a method to every object?

@asterite If it is not a documented method on Object, then it basically violates the rule of the least surprise. I'm totally fine with #should(_not) if they will be defined on Object always (regardless of me using spec or not) and it will be documented here: http://crystal-lang.org/api/Object.html (or on Kernel)
In that case there are no surprises, it is just like normal built-in method, that all objects have.

I moved should and should_not to a Spec::ObjectExtensions method so it should be easier to document all of spec, even if we monkey-patch Object. I think I prefer should because it's easier to type (and many others think that too, although obviously many prefer expect).
As I said earlier, in my experience should and should_not were never a problem in Ruby because of their conflict with other methods, only because of some BasicObject rules or something like that, which we don't have. So let's keep it simple for now.
I also worry about adding expect as an alternative, because then it will be like all the names you have to learn in Ruby like map/collect, find/detect, etc.

I know this is old, but reading through it seems like a lot of people wanted expect syntax. Could someone clarify why this pull request didn't get merged?

+1
For the record, I support it still. Maybe it is time just to write another test library. :-)

Both https://github.com/ysbaddaden/minitest.cr and https://github.com/waterlink/spec2.cr support it already.

But still, if it's a good idea and people want it shouldn't it be included in the standard library, and shouldn't it be used in the tests for the standard library? I think just because other solutions exist for it doesn't mean that it shouldn't be considered here.

Scroll up, I voted in favour too.

Oh my bad you were responding to jtarchie wanting to write another test library.


hls m3u8 EXTINF tag  malformed?

Hi,
i am using a standard http.hls.conf to stream mainly audio to mobile clients (android, ios)::
`listen              1935;
max_connections     1000;
daemon              off;
srs_log_level       verbose;
srs_log_tank        file;
srs_log_file        /usr/local/srs/srs.log;

pid                 /var/run/srs.pid;

http_server {
    enabled         on;
    listen          80;
    dir             /var/local/srs/www;
}
vhost sc.cs {
        gop_cache       off; # inserted

hls {
    enabled         on;
    hls_fragment    2;
    hls_window      10;
    hls_path        /var/local/srs/www;
    hls_m3u8_file   [app]/[stream].m3u8;
    hls_ts_file     [app]/[stream]-[seq].ts;
}

}`
Issue:
When I send rtmp from ffmpeg to srs I get audio on newest android and iOS. On Android 5, the standard player is stuck. the m3u8 file looks like this:
#EXTM3U #EXT-X-VERSION:3 #EXT-X-MEDIA-SEQUENCE:41 #EXT-X-TARGETDURATION:7 #EXTINF:6.014, no desc livestream-41.ts #EXTINF:6.014, no desc livestream-42.ts #EXTINF:6.014, no desc livestream-43.ts #EXTINF:6.015, no desc livestream-44.ts #EXTINF:6.014, no desc livestream-45.ts
However, when I send ts files directlyfrom ffmpeg  into the same hls directory, all android mobiles work, and the m3u8 file looks like this::
#EXTM3U #EXT-X-VERSION:3 #EXT-X-MEDIA-SEQUENCE:0 #EXT-X-ALLOW-CACHE:YES #EXT-X-TARGETDURATION:11 #EXTINF:10.008422, livestream000.ts #EXTINF:10.008256, livestream001.ts #EXTINF:9.985100, livestream002.ts #EXTINF:10.008056, livestream003.ts #EXTINF:10.007778, livestream004.ts #EXTINF:9.984700, livestream005.ts #EXTINF:10.008033, livestream006.ts #EXTINF:10.007844, livestream007.ts #EXTINF:9.985078, livestream008.ts #EXTINF:10.008256, livestream009.ts
please note that the srs m3u8 format inserts a "no desc", probably followed by a return. According to the specs, the
tag  format should be::
 #EXTINF:<duration>,<title>
Maybe I oversee something, or maybe something is beyond my understanding, but can this difference be the cause of the stream not working on android 5?
I would like to use the auto-cleaning  tools in srs to clean up the streamdir automatically, as writing ts files directly from ffmpeg does not have that functionality...
Thanks for any pointers!

Use on_hls to manage your ts files.


When Dubbo is measured with large load, the consumer spends much more time than the provider.

    不知道各位Dubbo的用户及官方的朋友，有没有遇到或者听过这样的例子。

提供方执行很快，但是消费方却需要很长的时间，有时候就直接超时了，提供方可能1s不到，消费方需要等到几十秒然后超时了，这个场景下gc，cpu看了都还好，之前有抓包提供方返回的报文在交换机上就很迟发出来了。
有没有遇到相似的，或者有分析思路。
Translated from Google:
I don't know if you and Dubbo's users and official friends have encountered or heard such an example.
The provider performs very quickly, but the consumer takes a long time, sometimes it will time out directly, the provider may not be 1s, the consumer needs to wait for tens of seconds and then time out. In this scenario, gc, cpu read Fortunately, the packets returned by the packet capture provider were sent out late on the switch.
        Have you encountered similar, or have analytical ideas.

I think you can give us a demo that can reproduce this issue.
That will be help us large time to reproduce this issue.

Do you have the actually QPS for each method invocation?
If you have some hot service considering to separate it to a new connection with "connection".
Dubbo's single connection model is designed for small consumers compared with less providers. But if you suffered much heavy traffic on it you should try increasing the number of connections.

之前有抓包提供方返回的报文在交换机上就很迟发出来了。
这种情况优先看下两端的网卡，是不是已经打满，重传率高不高，等等

看抓包sudo tcpdump -i any -vvvnnttttSs0 port 20880(端口) -w dump.pcap
然后用wireshark分析报文，可以看到时间

用arthas看下服务调用耗时，https://github.com/alibaba/arthas/blob/master/README_CN.md 和 https://alibaba.github.io/arthas/trace.html


Mnemonic length affects the seed being generated

Thank you for your work on this project.
I am trying to generate a 24 word mnemonic with the latest version.

Use "bc8249f88ac9880a2c54db0e851d4b6e4ab5465e3af68d4dc132231640613e76" as hex-based 256 bit entropy

Set "Mnemonic length" to "use raw entropy (3 words per 32 bits)" (256 bit / 32 = 8 * 3 = 24 words)

Results in the 24 word mnemonic of: "route banner lawsuit better obtain agree rally opinion attend cigar fan symptom prize permit jump gain minute host erode economy goat correct what slot"

Use the same entropy as before

Set "Mnemonic length" to "24 words"

Results in the 24 word mnemonic of: "color village afford alien scale actual arctic shaft bulk sustain diary wrestle rally afford abuse exchange click valley hub slam hundred skate diesel prefer"

In both cases, the raw binary entropy stays the same but the binary checksum changes and with that the word indexes.
Why is that?
Is this a known issue?

Fixed word length hashes the entropy, whereas raw entropy does not. This is so that unusual entropy lengths can be encoded, eg it becomes possible to encode, say, 243 bits of entropy into a mnemonic (which would appear to contain 256 bits of entropy but in reality the entropy underlying it does not). It's not possible to directly convert 243 bits to a mnemonic, so a hash is used in that case.
https://github.com/iancoleman/bip39/blob/90f7a5ec9309c755dd06a534190067fa6f1f97fe/src/js/index.js#L1620-L1642


Fixed hyperloglog type assertion check.

The Dice server was breaking with the wrong pfadd command.
This has been caught using TCL Redis tests.
Issue:

Fix:

Added a unit test case.


feat: get HMAC keys method

TBD

iOS is working and validated
Android there is an issue on the native layer, but the bridging seems correct
We can merge this to start integrator validation now and allow some additional time for Android to get fixed


feat: add colored cable like items

closes: #320

Do we want the window that is opened on exporter click to also say e.g Cyan Exporter instead of Exporter?

To fix the ordering issues in the datagen I think that PROPERTY_BY_DIRECTION needs to be ordered.

Yes I had a read at Map.of and the implementing ImmutableMap  uses a random access order, that is only garantieed to be stable inside one jvm lifetime.


fix: async code example

Oh no, it was pr to test branch

:tada: This PR is included in version 2.0.0-test.3 :tada:
The release is available on:

npm package (@test dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Using react-native-vision-camera 4.0.5 there is increase of 3MB size in android bundle

What's happening?
I have started using this library. I can notice there is size increase of 3MB.

Reproduceable Code
NA

Relevant log output
NA

Camera Device
NA

Device
android
VisionCamera Version
4.0.5
Can you reproduce this issue in the VisionCamera Example app?
I didn't try (⚠ your issue might get ignored & closed if you don't try this)
Additional information

[X] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

VisionCamera is quite a big library with C++ files and a dependency on the Barcode scanner. I think 3MB are not critical.
What's the issue?
If there's anything in there that shouldn't be in there (like META_DATA) then please let me know.


Is zcertificate going to be updated to a more modern version of zlint?

It seems that the current version of zlint being used is from 2019 -- which seems like a lifetime ago. Any plans to update to a more recent version?

It should be fairly straightforward to drop in a newer version. If nobody else does over the next few days I'll take a crack at it.
As a follow-up it would be nice to add command line options for including/excluding lint categories using the newer ZLint 2.x+ API but I'm not sure I'll have time to get to that.

:wave: @pjsg - Thanks for opening this issue to prop an update. Sine #17 ZCertificate is using v2.2.1, the latest tagged release.


Update to work under Julia 1.2

bors merge+

Also, I just realized that bors merge is sufficient. We don’t need to add the + at the end.

bors merge

So, the failures on Windows on 1.3 and 1.4 are due to a known issue with 7z on Windows.
But I have no idea why we are getting failures on 1.0.

I think it’s only failing on 1.3 and 1.4 on Windows? If that’s a known issue, I’ll just update the Travis config to allow those failures.

bors merge


Fix HTTPS request on README.md

How about we fix some HTTPs

@IceCereal that's a good issue for first timers. From next time raise an issue for the same and only when assigned, solve it.
Could've been a good first issue for the beginners. Anyway, I'm merging this now. LGTM


What is the purpose of the "Live Update Axes' Min/Max" checkbox under Axis Styling?

I notice that when the view is changed and the checkbox is not selected, the X Min/X Max/Y Min/Y Max fields remain stagnant. When the checkbox is selected, those values do change as I alter the view window. I experimented to see if I exported the graph the resulting svg file would have the mins and maxes set to the values in the field, but they were not.

The text fields containing the axes' min/max values react to changes in the view window by default, and the live update checkbox is there to allow a user to turn that feature off if they want to. "Update" refers to updating the values in the text fields, not updating the view window. Changing the values in the text fields won't affect the svg plot unless the user clicks "Set Extents".

What is the practical usage of this feature? I guess I can't see why anyone would want to turn the live update off.

I suppose I just don't understand why anybody wouldn't want the values to be live updating.

The only use case I remember discussing was the event that a user wants to have a specific range that they want to zoom back to without typing it out again. The min/max values wouldn't be overwritten when they manipulate the plot, then they could just click "Set Extents" again to snap back.
A better option for that particular situation might be to implement a feature allowing users to save "views" of the plot that they can zoom to, but the checkbox was significantly less complex at the time.

It's pretty useful in practice.  It's nice to be able to explore the data, and then snap back to a pre-set range.

Dr. Bowring and myself have discovered the root of this issue to be something separate (although related). I will close this issue and open a new one that's more relevant to the cause of the problem.


Shadow shaders break in URP 14.0.9

In the past these shaders worked well in all Unity versions. Right now 2022.3.15LTS breaks the shadow receiving shader.
It only happens with 3 or 4 cascades, so it probably is a keyword issue. It also happens with 2 cascades when conservative enclosing sphere is enabled
Soft shadows now also have enums for the quality tiers

I feel stupid. This happens when transparent receive shadows is disabled.
When it is checked it works fine.


Raspberry Pi

Can this run on Raspberry Pi?
I do not think there are any ARM 32-Bit releases, so if this works with Box86 (a x86 emulator) can instructions be added?

( just check main readme, you will find your desired steps
Building on Linux

Install the required tools:

sudo apt-get install nodejs
sudo apt-get install npm

Clone the repository and set the current directory to the root:

git clone https://github.com/julianoappelklein/hokus.git && cd hokus

Install NPM dependencies and build:

npm install && npm run dist-linux

( just check main readme, you will find your desired steps
Building on Linux

Install the required tools:

sudo apt-get install nodejs
sudo apt-get install npm

Clone the repository and set the current directory to the root:

git clone https://github.com/julianoappelklein/hokus.git && cd hokus

Install NPM dependencies and build:

npm install && npm run dist-linux

Sorry, I created this issue when I was less familiar with Linux, and the command line in general, and I forgot about this issue.


Mainnet-017: New pre-signed pause txs

Create new pre-signed pause transactions because the current ones will be invalidated by upgrading DeputyGuardianModule in task 020.
This is the second in a series of tasks for the Granite upgrade.
Sequence
The following table outlines the upgrade sequence, including the nonce allocation of each safe.

ordering
task
FUS
SC
FOS

016
Set recommended/required ProtocolVersions
7

>> 017
Re-sign Presigned Pauses

96

018
Upgrade FP contracts
8
6

019
Re-enable permissionless FPs

95

020
Upgrade DeputyGuardianModule

7

This has been simulated through tenderly
The command used for this was:
SIMULATE_WITHOUT_LEDGER=1 \
FOUNDRY_SENDER=0xF0871b2F75ecD07e2D709b7a2cc0AF6848c1cE76 \
TEST_SENDER=0xF0871b2F75ecD07e2D709b7a2cc0AF6848c1cE76 \
just \
   --dotenv-path .env \
   --justfile ../../../presigned-pause.just \
   sign

We can see that the pause slot of SupechainConfig (0x95703e0982140D16f8ebA6d158FccEde42f04a4C) has been set from 0 -> 1 :

The final trace show that the event pause has been emitted.


Above 60 fps bugs Stormhawk barrel throw

There are a few Stormhawks in Stormveil Castle that throw explosive barrels at you; The enemies outside the door at "Rampart Tower" site of grace. When playing at above 60fps (I had the game capped at 120fps when testing this) the barrels crumble the exact frame they leave the Stormhawks claws when throwing at you. They're supposed to throw the barrel at you and explode on impact, but instead they break instantly mid-air (with no explosion).

Hmm that could be a bug but I don't have a save file that is that far yet. I've spent about 20 minutes ingame since release...
Could you try lowering game speed with the latest <IP_ADDRESS> release and record it?

Hi,
Here's a video showing the bug at 60fps and 120fps and lowered game speed: https://www.youtube.com/watch?v=rKqooO6DU3o

So this also happens at 60fps with lower game speed? That would indicate a game/engine bug rather than an issue with the unlock itself.

I can confirm this is a bug with the fps unlock, I can toggle it off and on, on the barrel disappears, off the barrel is thrown and explodes just fine. Game speed doesn't seem to help with unlocked fps.

I had one throw and it disappeared and another one work right after, I think it might be a game mechanic.

I can confirm this is a bug with the fps unlock, I can toggle it off and on, on the barrel disappears, off the barrel is thrown and explodes just fine. Game speed doesn't seem to help with unlocked fps.
Here's my save, load it up, walk outside and you'll see the 2 birds. ER0000.zip

So it does not happen on your end with 60fps lock and reduced game speed?

I can confirm this is a bug with the fps unlock, I can toggle it off and on, on the barrel disappears, off the barrel is thrown and explodes just fine. Game speed doesn't seem to help with unlocked fps.
Here's my save, load it up, walk outside and you'll see the 2 birds. ER0000.zip

So it does not happen on your end with 60fps lock and reduced game speed?

Game speed stopped the issue at 80% game speed for myself, shown in the comparison videos below.
144 FPS Cap, 100% Game Speed
60 FPS Cap, 100% Game Speed
144 FPS Cap, 80% Game Speed

Anything above 71 FPS at 100% game speed causes the barrel issue.

This sounds like a timing issue of the engine as the barrel is thrown normally even at 165fps on 75% speed. Probably not much we can do other than hoping FromSoft will fix their engine, although I haven't looked into it yet.

Will using this tool disable the ability to get achievements?

I just went through this section and had no bug.
Barrels exploded as intended.

ER FPS Unlock v<IP_ADDRESS>, with only frame rate lock ticked and set at 144.
Nvidia gtx 1060 6gb, driver version  511.79, preferred refresh rate to highest available and vsync Off
Game is "onsl" 1.02.3, set to high, 36>52 fps
Windows 11

I just went through this section and had no bug. Barrels exploded as intended.

ER FPS Unlock v<IP_ADDRESS>, with only frame rate lock ticked and set at 144.
Nvidia gtx 1060 6gb with a slight overclock, driver version  511.79, preferred refresh rate to highest available and vsync Off.
Game is "onsl" 1.02.3, set to high, 36>52 fps depending on the scenery.
Windows 11.
No Huds, no mods, no FPS counters; no Geforce Experience or anything that could be interfering.
Simple144 Hz monitor without gsync.

Edit: I tried changing fov early game and clipped through the floor. It didn't happened since I disabled this option. Maybe related ? It was pre <IP_ADDRESS>.

My Bad.

This is literally the only known relevant bug that happens when the frame rate is unlocked.
It was definately worth of From Software to lock the entire game at 60fps for everybody, instead of just fixing this 👍, which would have probably taken 10 minutes.


Error in existing SDK - Unable to Get Ongoing Conversation ID from Omnichannel SDK event automatically

Good day!
I need to obtain the ongoing conversation ID at the page level since I have configured Omnichannel in our web application. To do that, I created some code and an Omnichannel SDK predefined event, the code for which is provided below.
window.addEventListener("lcw:onMessageReceived", function handleWidgetMessageReceivedEvent(payload){

    alert("OnMessageRecieved"+ payload.detail.conversationId);
    // Handle the live chat widget message sent event
});
We don't receive any conversation-related information when we start a chat, but when we refresh the page in the browser, data starts to appear. When we start a chat, we don't get any conversation-related information, but when we refresh the page in the browser, information starts to appear.
If you have any further questions, kindly let me know.
Thank you...

@vivekkumarcf If this is a question related to our documentation, please provide a link to the topic.
Unfortunately, we're unable to handle Support requests for the product here. To contact Support, consider one of the options described here: https://docs.microsoft.com/dynamics365/get-started/support/.

@phecke I had gone through this- below link, provided by support team only.
https://learn.microsoft.com/en-us/dynamics365/customer-service/developer/reference/events/lcw-onmessagereceived
Post implementation, I had a conversation with the support team, and they accepted it as a bug in the omnichannel SDK and suggested I raise the issue here.
Please let me know how we can proceed in this regard.

@vivekkumarcf If this is a question related to our documentation, please provide a link to the topic.
Unfortunately, we're unable to handle Support requests for the product here. To contact Support, consider one of the options described here: https://docs.microsoft.com/dynamics365/get-started/support/.

@phecke I had gone through this- below link, provided by support team only.
https://learn.microsoft.com/en-us/dynamics365/customer-service/developer/reference/events/lcw-onmessagereceived
Post implementation, I had a conversation with the support team, and they accepted it as a bug in the omnichannel SDK and suggested I raise the issue here.
Please let me know how we can proceed in this regard.

@vivekkumarcf This channel is for documentation feedback. We do not handle product bugs here and I do not know why the support team sent you back here.
However, in the interest of not bouncing you around any further, I will forward your issue to a PM on the product team.

@phecke Thanks for taking to the next level. How do I know what they've done?

@shubhadaj Could you please share any latest update on the same?


Cleanup r1

This fixes and cleans up dockerfiles.
Let's get this over with.

@native-api Thanks so much for this, but we need some additional changes as you remove libjpeg-turbo too.

No need for changes. The build logic will detect that relevant envvars are no longer present and use the one bundled with OpenCV.
You can delete the corresponding logic from setup,py altogether if you'd like but it's not strictly necessary atm.

I deleted libjpeg-turbo from dockerfile because it was failing the build, see commit message.

@native-api Change this part here from setup.py which redirects OpenCV to use custom jpeg libs:
if all(v in os.environ for v in ('JPEG_INCLUDE_DIR', 'JPEG_LIBRARY')):
            cmake_args += [
                "-DBUILD_JPEG=OFF",
                "-DJPEG_INCLUDE_DIR=%s" % os.environ['JPEG_INCLUDE_DIR'],
                "-DJPEG_LIBRARY=%s" % os.environ['JPEG_LIBRARY']
            ]

to
 cmake_args += ["-DBUILD_JPEG=ON"]

Or simply just remove it entirely, as "-DBUILD_JPEG=ON" is set by default .

@native-api This change is very important as build will fail if no jpeg libs are found.

if all(v in os.environ for v in ('JPEG_INCLUDE_DIR', 'JPEG_LIBRARY')):

this ensures that a custom JPEG library is only used if JPEG_INCLUDE_DIR and JPEG_LIBRARY envvars are present.

if all(v in os.environ for v in ('JPEG_INCLUDE_DIR', 'JPEG_LIBRARY')):
this ensures that a custom JPEG library is only used if JPEG_INCLUDE_DIR and JPEG_LIBRARY envvars are present.

Yes, but we just removed it(i.e. libjpeg-turbo), so no jpeg support will be present in final build which is dangerous.

@native-api see my comment here: https://github.com/skvark/opencv-python/issues/204#issuecomment-516444192
OpenCV itself provide optimized libjpeg-turbo libs starting from this PR: opencv/opencv#11497
Therefore we can safely remove custom jpeg part from cmake, In this way OpenCV will use its own optimized libjpeg-turbo libraries.

As it is now, the bundles jpeg-turbo is already used, I checked:
--   Media I/O:
--     ZLib:                        /lib/libz.so (ver 1.2.3)
--     JPEG:                        libjpeg-turbo (ver 2.0.2-62)
<...>
[  4%] Built target libtiff
[  9%] Built target libjpeg-turbo
[  5%] Built target libpng
<...>

As it is now, the bundled jpeg-turbo is already used, I checked:
--   Media I/O:
--     ZLib:                        /lib/libz.so (ver 1.2.3)
--     JPEG:                        libjpeg-turbo (ver 2.0.2-62)
<...>
[  4%] Built target libtiff
[  9%] Built target libjpeg-turbo
[  5%] Built target libpng
<...>

@native-api It normally doesn't happens, but if it did , then it may've fallen back to building libjpeg-turbo  if no jpeg header files/libs are found on the path specified. But to be on safe side I suggest to make this change otherwise I'll merge it, what's your opinion?

If you can't understand why there's no problem due to https://github.com/abhiTronix/opencv-python/pull/4#issuecomment-518764737 , just trust me on this.

@native-api ooh, I misread that comment. My apologies. I'll merge it.


Fix for the bad import (#211)

A simple fix for the bad import in base_features.py.

Thanks for this PR!


Add Zero Clause BSD license

close #642

Shall the copyright line be included in the license text (with a generic name like this), per @landley's comment in https://github.com/spdx/license-list/issues/23?

Yes there should be a copyright line, also to match the SPDX text as closely as possible https://github.com/github/choosealicense.com/issues/636
@jhabdas there are two test failures:

the name doesn't match what is in SPDX https://travis-ci.org/github/choosealicense.com/builds/493146734#L1301-L1305
one of the examples wouldn't be detected https://travis-ci.org/github/choosealicense.com/builds/493146734#L1310-L1314 ... for that one, the problem is almost certainly the first line. Find an example that doesn't have such additions to the text (licensee can't tell whether such additions are nefarious or not, so conservatively does not give a positive identification of a license with added text)

That's my project, I can yank the intro line if it would help?

Done. Try now?

@landley thanks, works now!

Thanks. I'm on +8:00 and had to run to immigration today. Sounds like we've got progress. But I'm not sure what's left.

the name doesn't match what is in SPDX https://travis-ci.org/github/choosealicense.com/builds/493146734#L1301-L1305

Opened a pull a few days ago to have the title adjusted at the SPDX end. Once that blocker is cleared CI should pass.

the name doesn't match what is in SPDX https://travis-ci.org/github/choosealicense.com/builds/493146734#L1301-L1305

Opened a pull a few days ago to have the title adjusted at the SPDX end. Once that blocker is cleared CI should pass. Not sure who to ping but I do know I had issues merging because someone updated the same LOC after my pull was submitted but hasn't commented on my PR.

the name doesn't match what is in SPDX https://travis-ci.org/github/choosealicense.com/builds/493146734#L1301-L1305

Opened a pull a few days ago to have the title adjusted at the SPDX end. Sorry for the mess in the pull I was working with an older copy of the source.

the name doesn't match what is in SPDX https://travis-ci.org/github/choosealicense.com/builds/493146734#L1301-L1305

Opened a pull a few days ago to have the title adjusted at the SPDX end. Once that's merged CI should start passing if I'm reading Travis properly.

the name doesn't match what is in SPDX https://travis-ci.org/github/choosealicense.com/builds/493146734#L1301-L1305

Opened a pull a few days ago to have the title adjusted at the SPDX end. Once that's merged CI should start passing if I'm reading Travis properly. I'll get the copyright line added here in a jiff.

@waldyrious I remember you mentioning adding the license title to the top of the license. I left it out as it's not part of the license text. I maintain no opinion as to its inclusion in this pull request but personally don't plan to use it.

Please just let SPDX stay how it is and change the title here if you need to match it. I don't see a huge difference between "Zero Clause BSD" and "BSD Zero Clause" (with or without hyphens), and would rather avoid the churn. It's been stable in SPDX for several years now, the stability itself means something.

If anything in SPDX needed to be fixed, it's that even though I submitted it to their mailing list with "Your Name" in the license's copyright line, the copy at https://spdx.org/licenses/0BSD.html is cut and pasted from my toybox project's license page with my name in the copyright line. (I hadn't considered it worth the churn to fix, but if somebody else wants to...)
(Alas SPDX deleted its mailing list archives, and google still pulls up https://lists.spdx.org/pipermail/spdx-legal/2015-June which is 404, but I still have the copy in my outbox. I used the same copyright line the "license template" link from https://www.openbsd.org/policy.html has, since the Open BSD suggested template license was the upstream source I modified to create 0BSD in the first place. I went back to the source for the standards body submission...)

@landley the SPDX list archives moved but sadly the old links were not cool enough to redirect, I guess. Anyway: https://lists.spdx.org/g/spdx/topic/22079600
@jhabdas thanks for pushing this forward.
I made as consistent as possible with what's in SPDX at this point and will merge soon. Tests are only failing at this moment due to unrelated external links being flakey.

Thanks to all. I took the liberty of adding this to Wikipedia. @landley please feel free to make any adjustments you see fit. https://en.wikipedia.org/wiki/BSD_licenses

@mlinksva That was my first post about it, asking if there was a form to fill out. They pointed me at the correct procedure document and I did a second post in their official format, and that's where I used the "your name" copyright. Alas I can't navigate their new archive to find it.
@jabdas Yes, thanks for pushing it forward.
Re: wikipedia: I can't edit wikipedia because they don't want anyone with first hand knowledge collapsing their quantum state. It would jeopardize their status as the world's largest accumulation of anecdotal evidence. (The closest I come is ading things to the "talk" pages of articles.)
But please stop deadnaming the license. It was called Zero clause BSD first (by multiple years on the toybox website), was approved and published by SPDX before it was ever even submitted to OSI, and even OSI has now switched to more or less conform to SPDX. (Modulo word order and a hyphen.)
While creating the new license I asked Marshall McKusick (when he was keynote speaker at Ohio LinuxFest in 2013) if he was ok calling a derivative of OpenBSD's suggested Template License "Zero Clause BSD" and he said yes, and while convincing OSI to undo their mistake I asked him again if he remembered and got an explicit statement of support from him (I attached the full email to http://lists.landley.net/pipermail/toybox-landley.net/2018-October/009780.html although dreamhost's web server thinks "blah.eml" is a format to download rather than ascii text to display, which I can't fix because dreamhost, but feel free to copy it somewhere more convenient if you like).
Seriously, the OSI misnaming was a mistake and it's over now. Please don't memorialize it, it never served any purpose except to confuse people and even OSI eventually admitted that and fixed it.

Um, it says "merged". How do I tell when it's identified 0bsd in https://github.com/landley/toybox (is there something to look for on that page? Do I need to modify the file for it to reevaluate it?) and when (or if) does https://help.github.com/articles/licensing-a-repository/ update? (I dunno the procedure here...)
Thank you very much.

@landley it'll take awhile, see https://github.com/github/choosealicense.com/issues/642#issuecomment-463318223
I'll add a note here when github.com knows about 0BSD, but if you wish to test yourself with a cron job o something, it'll be when https://api.github.com/licenses/0bsd doesn't 404.

But please stop deadnaming the license.

@landley Ideally there would be one name. Practically it's the telephone game. Just tell me what you want Wikipedia to saw WRT the name and consider it done.

But please stop deadnaming the license.

@landley Ideally there would be one name. Practically it's the telephone game. Just tell me what you want Wikipedia to say WRT the name and consider it done.

Just the new name please. The controversy is resolved. If you'd like me to post the controversy to the talk section, I can, but these days it only serves to confuse matters.
Kirk McKusick (the maintainer Bill Joy handed BSD off to at Berkeley) has endorsed the new name (twice). The guy who submitted it to OSI under the other name has acknowledged the new name (also twice). OSI took down the old page and put up a new page with the correct name. SPDX's approval came significantly before OSI's submission, and if you're going by dinosaur naming rules I was publicly using the name in toybox something like a year before I sent it to SPDX (and spoke to McKusick about it at Ohio Linux Symposium 2013, before that, showing I already had the name by then and was clearing it).

At any rate, thanks. This license lexicographically sorts to the top and bottom of lists now depending on if the list is sorted by SPDX identifier or name. And I'm confident that exposure will help prevent that nagging doubt FOSS devs feel when they start pulling in bits and pieces of otherwise free code into their projects and have to question authors about how to use it. 0BSD is ultra clear, significantly more accessible and I'm confident it will be replacing the MIT in years to come.

At any rate, thanks. This license lexicographically sorts to the top and bottom of lists now depending on if the list is sorted by SPDX identifier or name. And I'm confident that exposure will help prevent that nagging doubt FOSS devs feel when they start pulling in bits and pieces of otherwise free code into their projects and have to question authors about how to use it. 0BSD is ultra clear, significantly more accessible and I'm confident it will be gaining greater adoption quickly.

At any rate, thanks. This license lexicographically sorts to the top and bottom of lists now depending on if the list is sorted by SPDX identifier or name. And I'm confident that exposure will help prevent that nagging doubt FOSS devs feel when they start pulling in bits and pieces of otherwise free code into their projects and have to question authors about how to use it. 0BSD is ultra clear, more accessible than most other licenses and I'm confident it will be gaining greater adoption quickly.

At any rate, thanks. This license lexicographically sorts to the top and bottom of lists now depending on if the list is sorted by SPDX identifier or name. And I'm confident that exposure will help prevent that nagging doubt FOSS devs feel when they start pulling in bits and pieces of otherwise free code into their projects and have to question authors about how to use it. 0BSD is ultra clear, more accessible than most other licenses and I'm confident it will be gaining even greater adoption quickly.

At any rate, thanks. This license lexicographically sorts to the top and bottom of lists now depending on if the list is sorted by SPDX identifier or name. And I'm confident that exposure will help prevent that nagging doubt FOSS devs feel when they start pulling in bits and pieces of otherwise free code into their projects and have to question authors about how to use it. 0BSD is ultra clear, more accessible than most other licenses I've seen and I'm confident it will continue greater adoption given it fixes what WTFPL got wrong.

At any rate, thanks. This license lexicographically sorts to the top and bottom of lists now depending on if the list is sorted by SPDX identifier or name. And I'm confident that exposure will help prevent that nagging doubt FOSS devs feel when they start pulling in bits and pieces of otherwise free code into their projects and have to question authors about how to use it. 0BSD is ultra clear, more accessible than most other licenses I've seen and I'm confident it will continue greater adoption for years to come.

At any rate, thanks. This license lexicographically sorts to the top and bottom of lists now depending on if the list is sorted by SPDX identifier or name. And I'm confident that exposure will help prevent that nagging doubt FOSS devs feel when they start pulling in bits and pieces of otherwise free code into their projects and have to question authors about how to use it. 0BSD is ultra clear, more accessible than most other licenses I've seen and I'm confident it will gain wide adoption in years to come.

At any rate, thanks. This license lexicographically sorts to the top and bottom of lists now depending on if the list is sorted by SPDX identifier or name. And I'm confident that exposure will help prevent that nagging doubt FOSS devs feel when they start pulling in bits and pieces of otherwise free code into their projects and have to question authors about how to use it. 0BSD is ultra clear, more accessible than most other licenses I've seen and I'm confident it will gain even wider adoption in years to come.

At any rate, thanks. Your license lexicographically sorts to the top and bottom of lists now depending on if the list is sorted by SPDX identifier or name. And I'm confident that exposure will help prevent that nagging doubt FOSS devs feel when they start pulling in bits and pieces of otherwise free code into their projects and have to question authors about how to use it. 0BSD is ultra clear, more accessible than most other licenses I've seen and I'm confident it will gain even wider adoption in years to come.


typedoc support version updated

@Drarig29

Actually, I reopened the PR and I'll push commits on it. So you'll be a co-author and get some credits :stuck_out_tongue:

I know I should write unit tests or e2e tests...
but I always find it overkill until I have to test everything still works properly :sweat_smile:


chore: update packages

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


update fixed seed nodes

lbrycrd currently uses Jack's vultr servers as the fixed seeds. This switches the mainnet seeds to LBRY servers. It also updates the testnet seed to a real testnet server

looks good, testnet is operating with the seed node and DNS seeds for me
ACK to merge


Admin Interface / GUI

Does Masstransit have a peeking interface to the health of the ongoing state/sagas?

There is nothing built in to display saga state, but if they're in SQL it should be easy to query and display in your application.

I can build my own GUI, can you share a code snippet on querying a saga, so that I can render the sagas state

It depends upon your storage system. If you're using SQL, you can just query the SQL to search for sagas in a particular state. Be careful not to lock rows though or you can stall message processing.
In most cases it is best to use events to update a front-end data store to show saga state.

Hi, this is hair pulling frustrating, I build the UI, but dont know how to get a list of sagas status...
For e.g. like an inbox of sagas status... can you point me to a snippet, sql or mongo anything will help


Document how to attach a djangocms-blog apphook

Add some documentation and link the django CMS docs for more indepth information

+1 on this

In the meantime, you may want  to getting familiar with django CMS by checking these tutorials:

https://www.youtube.com/watch?v=NbsRVfLCE1U
https://www.youtube.com/watch?v=Dj8dhgmzlFM

they are a bit old but still valid reference material


line:col positions in parser

Pull Request Description
Add line:column information to source code references produced by the parser. This information will be used by GUI2 as part of the solution to #8134.
Important Notes

parse_all_enso_files.sh has been used to ensure this doesn't affect tree structures.
parse_all_enso_files.sh now checks emitted locations for consistency, and has been used to verify that all line:col references match the values found by an independent scan of the source up to the given UTF8 position.

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[ ] ~Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.~
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[] ~If GUI codebase was changed, the GUI was tested when built using ./run ide build.~

What is the status of this PR? Are the @Frizi comments addressed? Do we want to merge it or discard in favor of #8236 ?

I think it's an improvement regardless of #8236. In the future we might make use of it for a more edit-resilient metadata map format.


CCM.xsl:52-55: For CCM, the following test cases need to...

The puzzle 66-c487e21b from #66 has to be resolved:
https://github.com/yegor256/jpeek/blob/faea600f44b8a750701047afee520df9bdbeb3a1/src/main/resources/org/jpeek/metrics/CCM.xsl#L52-L55
The puzzle was created by George Aristy on 01-Feb-18.
Estimate: 30 minutes, role: IMP.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@yegor256/z please, pay attention to this issue

Job #147 is now in scope, role is DEV

@0pdd all puzzles are solved

@0pdd all puzzles are solved

The job #147 assigned to @llorllale/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@0crat refuse

@0crat refuse (here)

@llorllale You can't do that, unless you have one of these roles: ARC, PO. Your current roles are: DEV.

@0crat refuse (here)

@llorllale The user @llorllale/z resigned from #147, please stop working. Reason for job resignation: Order was cancelled

Tasks refusal is discouraged, see §6: -15 points just awarded to @llorllale/z

@oridan/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat  wait pull request #235 be merged.

@0crat wait pull request #235 be merged. (here)

@oridan The impediment for #147 was registered successfully by @oridan/z

The puzzle 66-c487e21b has disappeared from the source code, that's why I closed this issue.

@elenavolokhova/z please review this job completed by @oridan/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

The job #147 is now out of scope

@0crat quality good

Order was finished, quality is "good": +35 point(s) just awarded to @oridan/z

Quality review completed: +8 point(s) just awarded to @elenavolokhova/z


Add script to remove user resources

How'd you validate / test?

The following validation was performed
Environment Setup

Create 4 users; 2 admin and 2 non-admin
import a couple of datasets and models for each user
Create project group for non-admin user 1

Ensure running script as admin user only affects resources owned by the admin user

expected results are to remove all resources for the admin 1 user only. No other user's resources should not be touched.
Test ran successfully.

Ensure running the script as non-admin does not affect admin user resources

expected results are to remove all resources from test user 1 only.
Test ran successfully.

Ensure Script works if the user has no resources to remove

After removing resources for a user, run the script again.
Script correctly exits with message that no resources need be removed.

Ensure that script works when some groups have no resources, but others do

This test is covered by the admin user test. It was setup to not have any project groups to validate this situation.


Running test() returns False

Running test() actually returns False. (After I comment out the french and the Chinese as well).

Does it fail consistently for you? I just ran it and it passed.

Did you change the confidence level when you called generate_keys() or find_prime()?  If you generate keys with a low confidence level then it is more likely that you will create keys using numbers that are not prime.  If the keys are not generated using prime numbers encrypt() and decrypt() will not work properly and will cause test() to return False.  If you did not change the confidence level it is very unlikely but still possible that you got bad keys.


[DO NOT MERGE] ROX-16995: Test OCP-4.13 against StackRox 4.0.0

Description
This PR is for testing OCP 4.13 compatibility with ACS 4.0.0
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

/test ?

/test ocp-4-13-operator-e2e-tests ocp-4-13-qa-e2e-tests

/test ocp-4-13-operator-e2e-tests ocp-4-13-qa-e2e-tests

/test ocp-4-13-operator-e2e-tests ocp-4-13-qa-e2e-tests

/test ocp-4-13-operator-e2e-tests ocp-4-13-qa-e2e-tests

/test ocp-4-13-operator-e2e-tests ocp-4-13-qa-e2e-tests

/test ocp-4-13-operator-e2e-tests ocp-4-13-qa-e2e-tests

/test ocp-4-13-operator-e2e-tests ocp-4-13-qa-e2e-tests

/test ocp-4-13-operator-e2e-tests ocp-4-13-qa-e2e-tests

/test ocp-4-13-operator-e2e-tests ocp-4-13-qa-e2e-tests


Mesos CNI plugin set calico hostname

Hi,
I have not found any options how can i set the hostname of the containers using marathon. Marathon gives a generated name to the docker containers and i would like to use other names as a hostname for the containers with calico.
For example i would like to use the hostname ngnix.calico_net instead of mesos-7ec3bb00-8e69-40df-8bc3-5d8a0a402454-S4.2870fd43-be4e-4b30-87dd-7995f5b1c8f0.calico_net.
Is this possible? Thank you very much.

Move to projectcalico/cni-plugin: https://github.com/projectcalico/cni-plugin/issues/278


rewrite forecast module to get data from NCEP

Is your feature request related to a problem? Please describe.
The forecast.py module provides convenient access to cloud cover and irradiance data from weather models stored on a Unidata THREDDS server. But sometimes I want model data that's not available from Unidata THREDDS. For example, HRRR subhourly irradiance data is available in NCEP's grib files, but not from Unidata. As another example, the period of record on the Unidata THREDDS server is typically shorter than the online NCEP servers. And if you write the code to go directly to NCEP for one variable, then maybe we should just do that for all variables.
Describe the solution you'd like
Rewrite forecast.py to get data directly from NCEP. I think this is more feasible than it used to be thanks to recent improvements in xarray.
Describe alternatives you've considered
See if Unidata/NOAA can add more variables to the THREDDS service.
Additional context
This supports the Solar Forecasting 2 projects.

I suggest to implement grib_filter API.
https://nomads.ncep.noaa.gov/cgi-bin/filter_gfs_0p25_1hr.pl?file=gfs.t12z.pgrb2.0p25.anl&var_ALBDO=on&var_DLWRF=on&var_DSWRF=on&subregion=&leftlon=0&rightlon=360&toplat=90&bottomlat=-90&dir=%2Fgfs.2019020212

From what I've seen on the matter, the grid_filter API gives out a .grib format. To manipulate the file into giving point data, such as what pvlib forecast currently does, it would be necessary to use a module that can operate on grib files, such as pygrib. However, to my knowledge, using pygrib on a windows is a bit complicated and could prove itself to be a frustrating experience for some users.
I am curious to know what is the current state of progress on this matter, as I have found myself to be limited by the amount of different weather variables available on Unidata THREDDS. Have there been any pertinent improvements since the initial posting date?

For the near (~1 year) future, all major forecast related activity will be in https://github.com/SolarArbiter/solarforecastarbiter-core. See, for example, the nwp fetch script. In that project, we are using the grib filter API to get data from NCEP. Supporting that or similar code in pvlib would be a major distraction from its core mission, so I'm going to close this issue.


chore(dep) Upgrade to Concerto 1.0

Changes

Switches to Concerto 1.0.0
Fixes publish script to use latest

Coverage remained the same at 95.616% when pulling 01dbf7f175465e901b0bdb8432d5a149a384a5d2 on jeromesimeon:js-0.22 into ae9e4a46c71e1c565f61d532650f421843a50e42 on accordproject:master.


Fix ZoneBinaryCallback documentation

There was a small mistake in the documentation, because it was copy-pasted from ZoneUnaryCallback and not fixed.

Great find and thanks for the fix, @ben-xD !!! 🙏  👍


Stop tap events from bubbling out of the overlay

Fixes #250

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

test/overlay.html, line 51 at r1 (raw file):

        var tapSpy = sinon.spy();
        document.addEventListener('tap', tapSpy);
        overlay.$.scroller.dispatchEvent(new CustomEvent('tap', {

Should we dispatch this test event on the overlay instead of the scroller?

Comments from Reviewable

test/overlay.html, line 51 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
> Should we dispatch this test event on the overlay instead of the scroller?

Well, shouldn't really matter in practice. The event we're interested in is actually fired and bubbles from inside the scroller so this is kind of more 'realistic' case in that sense.
Copied the test case from the one above which follows the same pattern.

Comments from Reviewable

Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


All files in package directory should get added to the image during package build.

Currently the build is only copying the language specific code files into the package, copy all contents.

This does not appear to be an issue. I added subdirectories with files in them and all expected excess files were in the appropriate directory at function runtime.


fix: incorrect paddings in Search popover

Explanation of Change
Removed additional padding as it's not needed now (now everything automatically handled by ScreenWrapper component).
Fixed Issues

$ https://github.com/Expensify/App/issues/53461
PROPOSAL: N/A
Tests

Go to search tab
Open various Popover/Modal windows and be sure they all have a correct top/bottom padding

Offline tests
N/A
QA Steps

Go to search tab
Open various Popover/Modal windows and be sure they all have a correct top/bottom padding

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@mountiny do you think it would be reasonable to ask @ZhenjaHorbach for review? Since he reviewed original PR where all insets were re-worked and these changes are toughly related

Thanks both! Good to merge

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


fix columns operation

I was trying to use the columns operation to add a RemainingTimeColumn field to a progress output, but it had no effect. Checking the code, it is built but not passed in Run.

Hey @joprice , thank you for your contribution! :smiley:
I've verified your PR and sure enough, you are totally right! 😊
I'm gonna merge it and create a new release!


Generic (or just dynamic) Type and TypeSchema

Currently, Type is defined as:
pub enum Type {
    Constructed(&'static str, Vec<Type>),
    Variable(Variable),
}

Since the constructor depends on &'static str, this has the restriction that all types must be created at compile time. This is does not allow for most use cases of Hindley-Milner, including the most common "adding a type system to a compiler". Ideally, types could be dynamically created.
I've yet to check the code, but I guess anything that can be compared could be used for identifiers, like this:
pub enum Type<T: Eq> {
     Constructed(T, Vec<Type<T>>),
    Variable(Variable),
}

Very cool library, btw!

Hi @blueridanus, thanks for the feedback! I was also unsatisfied with the limitations of using &'static str — using traits as you've shown is a good idea. For full compatibility, the trait bound would need to be Clone + Eq + Display + FromStr, which is a lot to ask for. I could relax these requirements with separate impl blocks, though.
pub enum Type<T: Clone + Eq> {
    Constructed(T, Vec<Type<T>>),
    Variable(Variable),
}
...
impl<T: Clone + Eq + FromStr> Type<T> {
    fn parse(&str) -> Result<Self, ParseError> { ... }
}
impl<T: Clone + Eq + Display> Display for Type<T> {
    fn fmt(&self, f: &mut fmt::Formatter) -> Result<(), fmt::Error> { ... }
}
impl<T: Clone + Eq + FromStr> FromStr for Type<T> {
    type Error = ParseError;
    fn from_str(&str) -> Result<Self, Self::Error> { ... }
}

I'll play around with this!

Upon further inspection, I think the best path forward is a new trait:
pub trait Name: Clone + Eq {
    fn arrow() -> Self;

    fn show() -> String { ... }
    fn parse(&str) -> Result<Self, ()> { ... }
}
// we provide some impls
impl Name for &'static str { ... }
impl Name for u32 { ... }

@blueridanus the name-trait branch has an implementation of this, but it slows the library down by about 10%. I might revisit this later when my other work has stabilized.

I was able to do this in a backwards compatible way! It's in the 4.2.0 release — see the Name trait.


with_items implementation for tasks

First pass of with_items will perform like ansible's.  Register and using templates as a substitute for a list will not work yet

To finish off this task, register support needs to be done.
Solution:

Add a register param in task.Run(...),  if the param is not empty then use it as a list.  This way it task.Run knows that it's a with_items call.
Could also check the with_items field of the task.  If the with_items field isn't null keep adding onto the register variable if it's present


Nick: Watch carsremovals.com.au

Nick requests the watch of the watch_keyword carsremovals\.com\.au. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

carsremovals\.com\.au has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


fix(gateway): Correct ISTIO_META_OWNER env var

Missing the 's' in 'apis'. This update matches the changes to the injection-template.yaml in https://github.com/istio/istio/pull/18485.

In response to a cherrypick label: new pull request created: #19515


Want for the paper

Hi, Can you put the paper on the github. I have search it, but can't find it any more.

there is no paper. we haven't published about this repository


x/website: mode=json&include=all does not include go1.4-bootstrap-20171003.tar.gz

https://golang.org/dl/?mode=json&include=all shows go1.4-bootstrap-20170518.tar.gz and go1.4-bootstrap-20170531.tar.gz but not the latest go1.4-bootstrap-20171003.tar.gz, linked in https://golang.org/doc/install/source.

CC @dmitshur via https://dev.golang.org/owners

After building go1.4 I noted that go version reports go1.4-bootstrap-20170531, that is correctly listed on https://golang.org/dl/?mode=json&include=all.  So the file name is incorrect.


'SignedNumber' is unavailable: Please use 'SignedNumeric & Comparable' instead.

using xcode 9.1 or even latest beta 9.3
/// Base protocol for all numeric types of SwiftAA
public protocol NumericType: _NumericType, SignedNumber, ExpressibleByFloatLiteral, Hashable { /* intentionally left blank */ }
this seems to fix it
public protocol NumericType: _NumericType, SignedNumeric & Comparable, ExpressibleByFloatLiteral, Hashable { /* intentionally left blank */ }

only happening in latest beta. will close.


F# should be fsharp

gi list returns f# as a language you can generate patterns for.
However trying to use it results in an error:
08:12 $ gi f#

# Created by https://www.gitignore.io/api/f

#!! ERROR: f is undefined. Use list command to see defined gitignore types !!#

# End of https://www.gitignore.io/api/f
~/dev/scratch/fsharp-test/test
08:12 $

Perhaps f# should be changed to fsharp? C# is already under csharp Happy to submit a PR if you think this is a good idea

Oh wow good catch!  Yeah it should be changed to fsharp.  If you want to submit the PR, please submit    it to: https://github.com/dvcs/gitignore.  If not, I can submit it as well.

ha, wrong repo

Nah, It's my fault.  I'm move all of these projects under the DVCS banner.  It's just taking some time.


Read Incoming Data from RX_PIN

#define RX_PIN 1

Design a process to read incoming data from the receiver (Rx) pin and reconstruct it into the Packet struct.
The UART start and stop bits do not need to be included in reconstruction. The parity bit should be processed upon reception and should not be stored. All remaining data (headers?, Packet body) should be encoded into the Byte struct.

Use this specification for the time being:


Mains powered devices not working as repeaters

Would it be possible to add information about zigbee repeaters to the database? The website says that most mains powered devices will act as repeaters for other zigbee devices, but this is not always the case. For example, sengled outlets and bulbs do not function as repeaters (at least the ones I have). I spent weeks diagnosing zigbee issues before I figured this fact out.
Maybe just a note on devices that don’t follow the rule?

every device is editable using the "Edit" button and such notice can be added below or in the supports field