Solution states' best times in db do not match extracted history

My current run is nearly at 2B rounds. The best solution is 947040ms, and I believe this comes from a pinpoint-minimized solution, which is essentially fully replayed rather than straight from the db. Feeding the preview of this solution into the route debugger replays it as 944258ms.
Solutions not pinpoint-minimized have the history extracted in reverse from the db, meaning there can be some race conditions, but generally every access should be retrieving a pair (history step, time to do that step) which should be accurate.
Another possibility is that the preview itself allows enough flexibility in movements that the route debugger is actually improving the route. For example, currently an instruction "Move... to [exit]" is being handled as a move to the exit's destination, rather than a movement to the spot with that exit and then taking that exit.

For example, currently an instruction "Move... to [exit]" is being handled as a move to the exit's destination, rather than a movement to the spot with that exit and then taking that exit.

I might be concerned about this at some point, but it doesn't seem to be the case for this route.

Plausibly the problem in #104 is happening here as well: the solution being added is inefficient somewhere without using warps, as the "Move... / Collect / Move..." would be turned into just "Move... / Move...". The preview only emits the last one, and then the route interpreter simply uses the shortest path.

This is happening even more generally, and reliably during the search start sequence against the basic route which should be 1090723; when the route is recreated, the goal state's best time is 1094858.

I found a couple of issues. One appeared to be a case of two condensed edges with different requirements and different times; even though the History item contains the elapsed time, recreate_step needed to choose the step that got there in the least time instead of the first in the list.
The next issue was the menuwarping one. This case was basically the route looping back on itself--we hadn't checked for that occurring, and it should be solved by retrieving the best elapsed time from the previous state, rather than relying on the state that delayed itself unnecessarily.
Together, these took care of pretty much all the issues... but it made new ones crop up that I haven't deciphered yet. I think it has something to do with chaining condensed edges in a way that violates the triangle inequality. That should be okay, of course, but I suppose this means that we haven't correctly updated the state db.


Query for Edge collections does not use correct Indices

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[ ] 3.1
[ ] 3.2
[x] 3.3
[ ] self-compiled devel branch

Mode:

[ ] Cluster
[x] Single-Server

Storage-Engine:

[ ] mmfiles
[x] rocksdb

On this operating system:

[ ] DCOS on

[ ] AWS
[ ] Azure
[ ] own infrastructure

[ ] Linux

[ ] Debian .deb
[ ] Ubuntu .deb
[ ] SUSE   .rpm
[ ] RedHat .rpm
[ ] Fedora .rpm
[ ] Gentoo
[ ] docker - official docker library
[ ] other:

[x] Windows, version: 10
[x] MacOS, version: 10.13.3

this is an AQL-related issue:
[X] I'm using graph features
I'm issuing AQL via:

[x] web interface with this browser:     running on this OS:
[ ] arangosh
[x] this Driver: Java

The AQL query in question is:
FOR obj IN @@collection
    FILTER obj._from == @from AND obj._to == @to AND obj.type == @type
    RETURN obj

where @collection is an Edge - Collection dataObjectRelations (see below).
There are the following indices available for the collection:
ID	Type	Unique	Sparse	Deduplicate	Selectivity Est.	Fields	Action
0	primary	true	false	n/a	100.00%	_key
2	edge	false	false	n/a	45.81%	_from, _to
15770388	hash	false	false	false	99.99%	_from, _to, type
15770464	hash	false	false	false	0.15%	type

However, explain shows that the edge index is used, although the hash index containing all fields would be much more selective.
Query string:
  FOR obj IN @@collection     FILTER obj._from == @from AND obj._to == @to AND obj.type == @type
 RETURN obj

Execution plan:
 Id   NodeType          Est.   Comment
  1   SingletonNode        1   * ROOT
  6   IndexNode            1     - FOR obj IN dataObjectRelations   /* edge index scan */
  7   CalculationNode      1       - LET #1 = ((obj.`_from` == "dataObjects/104024345") && (obj.`type` == "dataObjectTypeRelations/62877267"))   /* simple expression */   /* collections used: obj : dataObjectRelations */
  4   FilterNode           1       - FILTER #1
  5   ReturnNode           1       - RETURN obj

Indexes used:
 By   Type   Collection            Unique   Sparse   Selectivity   Fields      Ranges
  6   edge   dataObjectRelations   false    false        61.24 %   [ `_to` ]   (obj.`_to` == "dataObjects/62931491")

Optimization rules applied:
 Id   RuleName
  1   use-indexes
  2   remove-filter-covered-by-index

The Edge collection in re has about 1.500.000 entries, therefore any hints for a speedup of this query is appreciated.

Just looking at the selectivity estimates, it seems that the hash index on _from, _to and type should be the preferred one.
I tried to reproduce the issue locally with some similar setup, and when I try it the more selective hash index is actually used as expected. So it may happen with specific datasets only.
Is it possible to share the dataset somehow, or come up with an artifical dataset that produces the same undesired behavior?

Please find the dataset here:
https://owncloud.polymind.gmbh/index.php/s/BWJCJbH27mmkrNx
The following query
FOR obj IN dataObjectRelations
    FILTER obj._from == "dataObjects/46259213" AND obj._to == "dataObjects/46258947" AND obj.type == "dataObjectTypeRelations/37651780"
    RETURN obj

has the following execution plan:
Execution plan:
 Id   NodeType          Est.   Comment
  1   SingletonNode        1   * ROOT
  6   IndexNode            1     - FOR obj IN dataObjectRelations   /* edge index scan */
  7   CalculationNode      1       - LET #1 = ((obj.`_from` == "dataObjects/46259213") && (obj.`type` == "dataObjectTypeRelations/37651780"))   /* simple expression */   /* collections used: obj : dataObjectRelations */
  4   FilterNode           1       - FILTER #1
  5   ReturnNode           1       - RETURN obj

Indexes used:
 By   Type   Collection            Unique   Sparse   Selectivity   Fields      Ranges
  6   edge   dataObjectRelations   false    false        50.33 %   [ `_to` ]   (obj.`_to` == "dataObjects/46258947")

Optimization rules applied:
 Id   RuleName
  1   use-indexes
  2   remove-filter-covered-by-index

Thanks. Got it reproduced and am looking now.

It turns out that this is not easily fixable.
The edge index on _to is chosen because it has medium average selectivity (50%) but it is backed with an in-memory hash cache, which has amortized O(1) access cost. So finding documents in it will be relatively fast.
The hash index on _from, _to, type has much better selectivity (99.99%) but it is not backed with an in-memory hash cache. As the index data are stored in RocksDB, finding the first element in the index will have an amortized cost of around O(log n), and in total the optimizer considers the costs of using that index higher than using the edge cache with its in-memory hash table cache.
The only sensible way I can think of right now to fix this is to specify the desired index explicitly in the query string, but there is yet no syntax for this. Worse, indexes in ArangoDB only have numeric ids, and writing numeric index ids into query strings will not lead to greater understandibility or legibility.
Maybe I am overlooking something obvious, but at the moment I do not have a good idea how this could work nicely.

Thank you for your investigations. Would it be possible to declare the hash index as in-memory explicitly?
Furthermore, if the selectivity of the Edge index drops, is there any possibility that the hash index gets ranked up?


plot_sample needs to normalize its 1D histograms

See here for discussion. We need to add hist_args=dict(normed=True to the call to corner.corner - can you take care of this please, @jennykim1016 ? Thanks!

What happened to this?


📃: WhosThat(Pokemon)

🔴 Title : WhosThat
🔴 Aim : To track the IP Address
🔴 Tech Stack Used : Reactjs
Screenshots 📷

:white_check_mark: To be Mentioned while taking the issue :

Full name : Maheshwari Love
What is your participant role? (Mention the Open Source Program name. Eg. GSSOC, SSOC, JWOC, etc.) GSSOC

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

@Avdhesh-Varshney please assign me this task

@Maheshwari-Love no games allowed


Start showing subway entrances at zoom 17

Currently they are zoom 18+

#120
We also show amenity IN ('bench', 'waste_basket') at zoom 18. Can/should that be moved to zoom level 17 too? Or should we leave that the way it is for now.

Let's leave that street furniture at zoom 18 and keep this just for subway entrances.


Elements rangeproof

Add new primitives that support access to (hashes of) range proofs and surjection proofs.  Adds these hashes to the default signature hash.

Done reviewing the C code in 982367c5049c6cbc92557f03fa5b3f70f135d3f9. Only issue is the source typing thing.
Was relieved to find that this doesn't actually implement any rangeproof logic, only treats them as raw bytes to be hashed.

I've made some changes to attempt to prevent the same sort of bug from reoccurring.  The problem is somewhat hard because the naive specification of these primitives was still satisfied by the erroneous implementation.

@sanket1729 I still don't know how to add you as a reviewer.  I don't know what github's criterion is.

I explicitly added Sanket to this repo. The existing list of potential reviewers appears to be the ElementsProject "Owners" and nobody else.

@apoelstra the primitives themselves always fix their types.  It's just that the reference implementation did not, which is why it allowed me to make an error on the input type being Word32 instead of ().

While I've pushed a correction, I've reverted this to draft until I get sufficient testing infrastructure in place to detect this mistake in the elements-rangeproof-broken branch.


Remove extra include path

There is no need to point into the random123 path as we are already
including the top-level path and all generated code includes paths based
on the coreneuron include directory.

not true! actually the additional -I is useful because modfiles typically include random123.h differently in the VERBATIM block...


quickstart example failed no version is available

background
Trying to run model_analyser as in quick start.
I have the same issue as in previous issue, though the explained solution did not work for me.
Steps:

run docker with mapping all directories:

docker run -it --rm --gpus all         -v /var/run/docker.sock:/var/run/docker.sock         -v $HOME/model_analyzer/examples/quick-start:/quick_start_repository    -v /home/shai/output:/home/shai/output     --net=host --name model-analyzer   nvcr.io/nvidia/tritonserver:21.08-py3-sdk /bin/bash

in container bash, run model_analyser profile:

model-analyzer profile -m /quick_start_repository/ --profile-models add_sub --triton-launch-mode=docker --output-model-repository /home/shai/output/model_output --override-output-model-repository

results:
2021-09-09 09:15:32.428 INFO[entrypoint.py:113] Starting a Triton Server using docker...
2021-09-09 09:15:33.561 INFO[analyzer_state_manager.py:130] No checkpoint file found, starting a fresh run.
2021-09-09 09:15:33.561 INFO[analyzer.py:81] Profiling server only metrics...
2021-09-09 09:15:38.975 INFO[gpu_monitor.py:73] Using GPU(s) with UUID(s) = { GPU-52faa4b8-dd4c-0ab4-6676-9f39263202b8 } for profiling.
2021-09-09 09:15:39.998 INFO[server_docker.py:162] Stopping triton server.
2021-09-09 09:15:43.250 INFO[model_manager.py:87] Running auto config search for model: add_sub
2021-09-09 09:15:43.251 INFO[run_search.py:144] Will sweep both the concurrency and model config parameters...
2021-09-09 09:15:43.251 INFO[run_search.py:290] [Search Step] Concurrency set to 1. Instance count set to 1, and dynamic batching is disabled.
2021-09-09 09:15:46.61 INFO[client.py:80] Model add_sub_i0 load failed: [StatusCode.INTERNAL] failed to load 'add_sub_i0', no version is available
2021-09-09 09:15:46.62 INFO[server_docker.py:162] Stopping triton server.
2021-09-09 09:15:47.685 INFO[run_search.py:290] [Search Step] Concurrency set to 1. Instance count set to 2, and dynamic batching is disabled.
2021-09-09 09:15:50.555 INFO[client.py:80] Model add_sub_i1 load failed: [StatusCode.INTERNAL] failed to load 'add_sub_i1', no version is available
2021-09-09 09:15:50.555 INFO[server_docker.py:162] Stopping triton server.
2021-09-09 09:15:52.106 INFO[run_search.py:290] [Search Step] Concurrency set to 1. Instance count set to 3, and dynamic batching is disabled.
2021-09-09 09:15:54.989 INFO[client.py:80] Model add_sub_i2 load failed: [StatusCode.INTERNAL] failed to load 'add_sub_i2', no version is available
2021-09-09 09:15:54.989 INFO[server_docker.py:162] Stopping triton server.

and no profiling found

Could you check the contents of /home/shai/output/model_output?
Could you check the permissions of /home/shai/output?
If the model_output directory is non-empty, from inside the container could you run tritonserver --model-repository=/home/shai/output/model_output and see if triton starts up fine?

Hi @aramesh7 .
1.
> ls /home/shai/output/model_output/
add_sub_i0   add_sub_i11  add_sub_i14  add_sub_i17  add_sub_i2   add_sub_i22  add_sub_i25  add_sub_i28  add_sub_i30  add_sub_i33  add_sub_i5  add_sub_i8
add_sub_i1   add_sub_i12  add_sub_i15  add_sub_i18  add_sub_i20  add_sub_i23  add_sub_i26  add_sub_i29  add_sub_i31  add_sub_i34  add_sub_i6  add_sub_i9
add_sub_i10  add_sub_i13  add_sub_i16  add_sub_i19  add_sub_i21  add_sub_i24  add_sub_i27  add_sub_i3   add_sub_i32  add_sub_i4   add_sub_i7

but :
> ls /home/shai/output/model_output/add_sub_i0/
config.pbtxt

 > ls -alh output
total 12K
drwxr-xr-x  3 root root 4.0K Sep  9 13:05 .
drwxr-xr-x  9 shai shai 4.0K Sep  9 09:32 ..
drwxr-xr-x 37 root root 4.0K Sep  9 13:09 model_output

 > ls -alh | grep output
drwxr-xr-x   3 root root 4.0K Sep  9 13:05 output

tritonserver was not found in the sdk container:

> docker run -it --rm --gpus all         -v /var/run/docker.sock:/var/run/docker.sock         -v $HOME/model_analyzer/examples/quick-start:/quick_start_repository    -v /home/shai/output:/home/shai/output     --net=host --name model-analyzer   nvcr.io/nvidia/tritonserver:21.08-py3-sdk /bin/bash

root@gpu-worker-1:/workspace# tritonserver --model-repository=/home/shai/output/model_output
bash: tritonserver: command not found

Ran instead:
 docker run -it --rm --gpus all         -v /var/run/docker.sock:/var/run/docker.sock         -v $HOME/model_analyzer/examples/quick-start:/quick_start_repository    -v /home/shai/output:/home/shai/output     --net=host --name model-analyzer   nvcr.io/nvidia/tritonserver:21.08-py3 --model-repository=/home/shai/output/model_output

=============================
== Triton Inference Server ==
=============================

NVIDIA Release 21.08 (build 26170506)

Copyright (c) 2018-2021, NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

Various files include modifications (c) NVIDIA CORPORATION.  All rights reserved.

This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license
ERROR: Detected NVIDIA Tesla K80 GPU, which is not supported by this container
ERROR: No supported GPU(s) detected to run this container

NOTE: Legacy NVIDIA Driver detected.  Compatibility mode ENABLED.

/opt/tritonserver/nvidia_entrypoint.sh: line 69: exec: --: invalid option
exec: usage: exec [-cl] [-a name] [command [arguments ...]] [redirection ...]

Tesla K80 is not supported? Whic GPUs are supported?
Nvidia driver:
nvidia-smi
Fri Sep 17 10:06:13 2021
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 460.91.03    Driver Version: 460.91.03    CUDA Version: 11.2     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  Tesla K80           Off  | 00000000:00:04.0 Off |                    0 |
| N/A   38C    P0    63W / 149W |      0MiB / 11441MiB |    100%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|  No running processes found                                                 |

Hi, @shaikatzir I am facing the same problem. See the installation section. You must write absolute path for output model repo. Its works for me.

THanks @YaZlob ,
I think I do use it ...
 -v /home/shai/output:/home/shai/output

--output-model-repository /home/shai/output/model_output

@shaikatzir Its possible that the reason the models aren't loading is because of the GPU not being supported in the container. You could try to build the model analyzer Dockerfile yourself.
See here for instructions.
In this method you are certain to have the tritonserver binary, you can run triton on the output_model_repository_path

Using T4 Tesla (instead of Tesla K80) have solved the issues.
Thanks @aramesh7


changing colors of foldable region pairs & its interpolated zone texts

I want to change colors of foldable region pairs. What I mean is assigning different colors to first, second and third foldable region pairs each. How can I do this?  I inspected this very usuful package source code, where I found all region pairs are colorized as @text-color-info. I can't figure out how to modify this part of code.
Plus I'm wondering if I could put some color on the text area between foldable region pair. Can I tweak this wonderful package like that? Any help will be appreciated.

I know this is a bit late, but I recently started using custom-folds, and I figured out the way to change color so here you go,
In styles\custom-folds.less,
Replace all "@text-color-info" with:
"@syntax-color-removed" - for Red color
"@syntax-color-removed" - for Red color
"@syntax-color-removed" - for Red color
"@syntax-color-removed" - for Red color
"@syntax-color-removed" - for Red color

I know this is a bit late, but I recently started using custom-folds, and I figured out the way to change color so here you go,
In styles\custom-folds.less,
Replace all "@text-color-info" with:
"@syntax-color-removed" - for Red color
"@syntax-color-renamed" - for Blue color
"@syntax-color-added" - for Green color
"@syntax-color-modified" - for Orange  color
"@background-color-error" - for Darker Red color #c00
"@background-color-warning" - for Yellow color #ffaa2c
"@background-color-success" - for Green color #17ca65
"@background-color-selected" - for Blue #4182C4
"@app-background-color" - for Dark Grey #333


soul.sql english

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #526 (6e79704) into master (26e17f7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #526   +/-   ##
=========================================
  Coverage     15.28%   15.28%
  Complexity      306      306
=========================================
  Files           251      251
  Lines          5175     5175
  Branches        489      489
=========================================
  Hits            791      791
  Misses         4292     4292
  Partials         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e17f7...6e79704. Read the comment docs.

麻烦重新拉一下代码 另外一个pr又增加了新的sql


Retrieve search results.

Hey, I was wondering if there was a method to retrieve the search results after the callback has been triggered on search. I did not see ( or didn't look hard enough ) for a method or callback to retrieve the search results.
Has anyone else figured out a way to retrieve the search results?

I don't believe there is a way to do this currently with the search callback, however, if you use customSearch, you can collect the results that you intend to appear from the search, so that will have the same effect. It's fairly simple to implement. There is an example in customize-search if you need some help.


testing pep8

Hello @EdinsonRequena! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file selenium-course/modulo_II/assertions.py:

Line 53:80: E501 line too long (270 > 79 characters)


Tagging of unseen files not working

Dear NeuroNER authors,
I have downloaded and installed the NeuroNER project as well as the necessary dependencies (tensorflow, python3, etc.). Note that I am using python 3.6.
When I try to apply an existing model on the sample of documents provided I have an error:
Command launched:
python3 main.py --parameters_filepath=./parameters.ini --train_model=False --use_pretrained_model=True --dataset_text_folder=../data/example_unannotated_texts --pretrained_model_folder=../trained_models/conll_2003_en
Error:
Traceback (most recent call last):
File "main.py", line 446, in
main()
File "main.py", line 268, in main
parameters, conf_parameters = load_parameters(arguments['parameters_filepath'], arguments=arguments)
File "main.py", line 119, in load_parameters
pretraining_parameters = load_parameters(parameters_filepath=os.path.join(parameters['pretrained_model_folder'], 'parameters.ini'), verbose=False)[0]
File "main.py", line 119, in load_parameters
pretraining_parameters = load_parameters(parameters_filepath=os.path.join(parameters['pretrained_model_folder'], 'parameters.ini'), verbose=False)[0]
File "main.py", line 119, in load_parameters
pretraining_parameters = load_parameters(parameters_filepath=os.path.join(parameters['pretrained_model_folder'], 'parameters.ini'), verbose=False)[0]
[Previous line repeated 980 more times]
File "main.py", line 93, in load_parameters
nested_parameters = utils.convert_configparser_to_dictionary(conf_parameters)
File "/home/netmail/neuroNER/NeuroNER-master/src/utils.py", line 105, in convert_configparser_to_dictionary
my_config_parser_dict = {s:dict(config.items(s)) for s in config.sections()}
File "/home/netmail/neuroNER/NeuroNER-master/src/utils.py", line 105, in
my_config_parser_dict = {s:dict(config.items(s)) for s in config.sections()}
File "/home/netmail/.local/lib/python3.6/configparser.py", line 858, in items
return [(option, value_getter(option)) for option in d.keys()]
File "/home/netmail/.local/lib/python3.6/configparser.py", line 858, in
return [(option, value_getter(option)) for option in d.keys()]
File "/home/netmail/.local/lib/python3.6/configparser.py", line 855, in
section, option, d[option], d)
File "/home/netmail/.local/lib/python3.6/configparser.py", line 394, in before_get
self._interpolate_some(parser, option, L, value, section, defaults, 1)
File "/home/netmail/.local/lib/python3.6/configparser.py", line 407, in _interpolate_some
rawval = parser.get(section, option, raw=True, fallback=rest)
File "/home/netmail/.local/lib/python3.6/configparser.py", line 781, in get
d = self._unify_values(section, vars)
File "/home/netmail/.local/lib/python3.6/configparser.py", line 1149, in _unify_values
return _ChainMap(vardict, sectiondict, self._defaults)
File "/home/netmail/vens/tensorflow/lib/python3.6/collections/init.py", line 874, in init
self.maps = list(maps) or [{}]          # always at least one map
RecursionError: maximum recursion depth exceeded while calling a Python object
It seems that it fails to load the parameters from the config file.

Have you changed any of the NeuroNER files?

I only changed the parameters.ini file to set train_model to False:
[mode]
At least one of use_pretrained_model and train_model must be set to True.
train_model = False
use_pretrained_model = True
pretrained_model_folder = ../trained_models/conll_2003_en

Does running python3 main.py works?

It fails if I run it with the updated parameters.ini file but it does work if I run it with the default file.

These are the only two lines I changed in the file (left hand side is default, and right hand side is the new file):
train_model = True                                            | train_model = False
use_pretrained_model = False                          | use_pretrained_model = True

Have you changed NeuroNER/trained_models/conll_2003_en/parameters.ini  by any chance?

Yes I did changed that file as well.

This explains that the issue. This file shouldn't be changed. Thanks for reporting the issue, we'll add some more user friendly error message.

Thanks for the reply I will try not changing the parameters.ini in the trained_models folder.
I got confused by this part of the documentation:
The following parameters in the src/parameters.ini configuration file must also be set to the same values as in the configuration file located in the specified pretrained_model_folder

I have revert the changes in NeuroNER/trained_models/conll_2003_en/parameters.ini so that it is now:
train_model = True
use_pretrained_model = False
The file in /src/parameters.ini contains:
train_model = False
use_pretrained_model = True
When I execute:
python3 main.py --train_model=False --use_pretrained_model=True --dataset_text_folder=../data/example_unannotated_texts --pretrained_model_folder=../trained_models/conll_2003_en
The error that I get now is:
NeuroNER version: 1.0-dev
TensorFlow version: 1.1.0
NeuroNER version: 1.0-dev
TensorFlow version: 1.1.0
{'character_embedding_dimension': 25,
'character_lstm_hidden_state_dimension': 25,
'check_for_digits_replaced_with_zeros': 1,
'check_for_lowercase': 1,
'dataset_text_folder': '../data/example_unannotated_texts',
'debug': 0,
'dropout_rate': 0.5,
'experiment_name': 'test',
'freeze_token_embeddings': 0,
'gradient_clipping_value': 5.0,
'learning_rate': 0.005,
'load_only_pretrained_token_embeddings': 0,
'main_evaluation_mode': 'conll',
'maximum_number_of_epochs': 100,
'number_of_cpu_threads': 8,
'number_of_gpus': 0,
'optimizer': 'sgd',
'output_folder': '../output',
'parameters_filepath': './parameters.ini',
'patience': 10,
'plot_format': 'pdf',
'pretrained_model_folder': '../trained_models/conll_2003_en',
'reload_character_embeddings': 1,
'reload_character_lstm': 1,
'reload_crf': 1,
'reload_feedforward': 1,
'reload_token_embeddings': 1,
'reload_token_lstm': 1,
'remap_unknown_tokens_to_unk': 1,
'spacylanguage': 'en',
'tagging_format': 'bioes',
'token_embedding_dimension': 100,
'token_lstm_hidden_state_dimension': 100,
'token_pretrained_embedding_filepath': '../data/word_vectors/glove.6B.100d.txt',
'tokenizer': 'spacy',
'train_model': 0,
'use_character_lstm': 1,
'use_crf': 1,
'use_pretrained_model': 1,
'verbose': 0}
Checking compatibility between CONLL and BRAT for deploy_spacy set ... Done.
Checking validity of CONLL BIOES format... Done.
Load dataset... Traceback (most recent call last):
File "main.py", line 446, in
main()
File "main.py", line 274, in main
dataset.load_dataset(dataset_filepaths, parameters)
File "/home/netmail/neuroNER/NeuroNER-master/src/dataset.py", line 291, in load_dataset
self.alphabet_size = max(self.index_to_character.keys()) + 1
ValueError: max() arg is an empty sequence

I had the same error as @lujea on a fresh install
spacy didn't have the module en installed and it created 0 bytes files: deploy_spacy.txt, deploy_spacy_bioes.txt in directory example_unannotated_texts and also another empty file news.ann in the deploy directory.
When I tried again after installing the module en, it showed error.
Deleting these empty files made it work.
I think this project needs to list all the necessary dependencies. It's not just tensorflow or Brat, you also need to install:

spacy
spacy modules, esp. english
sklearn
matplotlib (amongst others, if you haven't installed them yet, otherwise running main.py fails)

@heri thanks very much for the feedback, deleting the empty files solved the issue.
I agree with you they are missing dependencies that are not specified. I had already solved the dependencies issue, which allowed me to train the model. The problem was really the empty generated files in the example_unannotated_texts folder and the news.ann.

Thanks for the feedback!

spacy didn't have the module en installed and it created 0 bytes files

Interesting, I had erroneously assumed spacy would throw some error message instead of being mute. I'll add some more user-friendly message there.

I agree with you they are missing dependencies that are not specified.

All the dependencies should be specified in https://github.com/Franck-Dernoncourt/NeuroNER/blob/master/install_mac.md, https://github.com/Franck-Dernoncourt/NeuroNER/blob/master/install_ubuntu.md, or https://github.com/Franck-Dernoncourt/NeuroNER/blob/master/install_windows.md
We will add a requirements.txt at some point.


typo

Sorry, no tests.

Coverage decreased (-0.02%) to 91.313% when pulling 18c19f87d60bd270577930cce819c41bfda4adc2 on dnafault:master into 67427a4d0c3112127ee48a1110291354782abdfa on RoaringBitmap:master.

Thanks.


ref and key are not omitted from Props-generated table

Bug Report
Describe the bug
Props component includes ref and key props in props table when passed a component created with React.forwardRef. I would argue these props should not be exposed because they cannot be documented in our code. They are also part of React's API in that they are documented elsewhere and considered assumed knowledge in our docs.
To Reproduce
Create this component
// docs/Faulty.tsx

import React from "react";

export interface FaultyProps {}

const Faulty = React.forwardRef<HTMLDivElement>((props, ref) => {
  return
{props.children}
;
});

export default Faulty;

With this documentation
{/* docs/Faulty.mdx */}

import { Props } from "docz";
import Faulty from "./Faulty";

# Faulty

<Props of={Faulty} />

Expected behavior
ref and key are omitted from generated props table
Environment

OS: macOS 10.14.5
Node version: 10.15.3
Yarn version: 1.16.0
Docz packages:

{
  "docz": "1.2.0",
  "docz-theme-default": "1.2.0"
}

Additional context/Screenshots

For what it's worth, I tried passing custom docgenConfig but since it propFilter must be a function, it is not parsed correctly by load-cfg.

I encountered a similar problem. Moreover, earlier on the same version of docz it was OK, perhaps this is due to the update of third libraries.
The problem is that when calling props.parent (https://github.com/styleguidist/react-docgen-typescript/issues/151), it is always null. And therefore all properties fall into the props table.
It is also interesting that if I builld examples from the docz repository, then the props.paren check works.


String: Group Anagrams in Javascript

https://leetcode.com/problems/group-anagrams/

I'll take this up

I'll take this up

Go ahead, i've assigned it to you


Allow deleting of files from inside the app

Allow deleting files from inside the app
I've now had several people email me with requests to add this feature.
My concern has been (and still is) to not make the app 'dangerous' to use -- I don't want an accidental mis-click to delete a file!
solution
There will be a new button in the settings that will toggle inside the right-click menu a new entry "delete file". By default "delete file" will not appear in the right-click menu, but once the setting is toggled, it will.
We don't want to permanently delete the file when user clicks "delete file" (no fs.unlink()) -- so I recommend we use https://github.com/sindresorhus/trash 🎉 (I'm open to other suggestions).

🚧 WIP with #333

⚠ The problem has been solved -- you can delete files. But the view doesn't get automatically updated. It will take a bit of work to get the vied to update:

every item in the finalArray contains its own index, so the whole array needs to be reindexed
possibly notify users if an error occurred and the file was not deleted successfully 🤷♂


Adds Beaker acceptance tests

Allows acceptance testing of changes.
To try:
bundle install
bundle exec rspec spec/acceptance/class_spec.rb

Requires vagrant and virtualbox be setup

Sweet, thanks!


Kapacitor and InfluxDB cann't work different manchine?

My InfluxDB works on server A and my Kapacitor works on Server B,but I cann't get the alert,and the InfluxDB always log:
[subscriber] 2016/08/25 17:35:03 write udp <IP_ADDRESS>:59634-><IP_ADDRESS>:47051: write: connection refused
[subscriber] 2016/08/25 17:35:13 write udp <IP_ADDRESS>:53807-><IP_ADDRESS>:47051: write: connection refused
[subscriber] 2016/08/25 17:35:23 write udp <IP_ADDRESS>:53584-><IP_ADDRESS>:47051: write: connection refused

They cann't work on different manchine? I have wroked all the afternoon and My heart will dead.I don't know how to do now ?

What versions of Kapacitor and InfluxDB? And what does your Kapacitor configuration look like? Is your hostname set in a way that the InfluxDB server will be able to reach the Kapacitor server using that hostname?
Also, what does the output to a SHOW SUBSCRIPTIONS look like when run from the InfluxDB CLI?

Kapacitor and InfluxDB are all 0.13 version,here is my Kapacitor conf:
hostname = "localhost"
data_dir = "/var/lib/kapacitor"

[http]
  bind-address = ":9092"
  auth-enabled = false
  log-enabled = true
  write-tracing = false
  pprof-enabled = false
  https-enabled = false
  https-certificate = "/etc/ssl/kapacitor.pem"
  shutdown-timeout = "10s"

[replay]
  dir = "/var/lib/kapacitor/replay"

[storage]
  boltdb = "/var/lib/kapacitor/kapacitor.db"

[task]
  dir = "/var/lib/kapacitor/tasks"
  snapshot-interval = "1m0s"

[[influxdb]]
  enabled = true
  name = "localhost"
  default = true
  urls = ["http://bj2-crm04:8086"]
  username = ""
  password = ""
  ssl-ca = ""
  ssl-cert = ""
  ssl-key = ""
  insecure-skip-verify = false
  timeout = "0"
  disable-subscriptions = false
  udp-buffer = 1000
  udp-read-buffer = 0
  startup-timeout = "0"
  [influxdb.subscriptions]
  [influxdb.excluded-subscriptions]
...

You mean the ** hostname** shoud be the hostname or the ip of the machine, not the  localhost?
That maybe the problem,but I have install Kapacitor and InfluxDB in the same machine now .

You mean the hostname should be the hostname or the ip of the machine, not the localhost?

Yes, otherwise InfluxDB does not know where to forward points to. Whatever is set as hostname must be resolvable by InfluxDB, so you certainly don't want it to be localhost if the services are running on different machines. The output of SHOW SUBSCRIPTIONS will show you where InfluxDB has been forwarding points, but you probably want to set Kapacitor's hostname to the IP address of the other machine.


Fixing incorrect proxy URL handling

Please describe the change you are making
This PR fixes the incorrect handling of proxy URLs on image upload.

Integrated into #12


Chrono Cross hangs after first battle

tonyhax version: tonyhax 1.4.3
Installation method: wrote the savegame to the memory card using a modded PS2
Entry point game: Tony Hawk's Pro Skater 4 German version (SLES-03955)
Console model: SCPH-5502 (PAL)
Integrity check: passed
BIOS version: v3.0 01/06/97 E
Target game: Chrono Cross US version (SLUS-01041)
Bug explanation:
Chrono Cross boots and initially seems to run fine.
But for me, the game always hangs after the first battle and won't return back to the dungeon after the battle results screen. The disc drive sounds like it is stuck in an endless loop of spinning down and spinning up again (sound recording attached)
chrono_cross_drive_sound.zip

Tried different media and burn speeds - no change
Other games (namely Xenogears and Metal Gear Solid) work just fine on the same PS1 using tonyhax
Chrono Cross (the same media that don't work properly on the PS1) works just fine on a PC using RetroArch with BeetlePSX
It doesn't matter whether I try to run an unmodified image of Chrono Cross (Disc 1 MD5: 3B29EE931DF29F51ECF0817F30E103D7) or one with a PAL patch applied

This sounds (literally) like a dying CD  drive. Some games are more finicky then others. Just because one game works ok with an iffy CD drive doesn't prove the CD drive is working optimally. This should be looked at though to see if it is reproducible.

Could you please try with latest 1.4.5?

Could you please try with latest 1.4.5?

For me, Chrono Cross is working even worse than before. I tried 10 times, but the game always hangs before or after the first in-game FMV (the opening FMV, title screen and gameplay demo worked flawlessly every time, though). When it hangs before the first in-gameFMV (right after naming the first character), it hangs in the manner I described earlier. When it hangs after the FMV, the disc continues to spin normally.
Although Xenogears and Metal Gear Solid still work normally even for longer periods of time, I guess it could be a dying disc drive after all. FMV playback in THPS4 is getting noticeably worse, and that's an original disc which is in good condition. A few times today, the disc stopped spinning entirely and the drive started making funny noises (possibly failed attempts at starting the drive motor).

Sounds like a dying CD drive indeed, specially considering there's at least one report that says it's working for him (#38). Closing.


Add getDomain functions as exportables

Below is list of functions that needs to be exported
func getDomainStatsBalloonFieldInfo

func getDomainStatsVcpuFieldInfo

func getDomainStatsNetFieldInfo

func getDomainStatsBlockFieldInfo

func getDomainStatsPerfFieldInfo

func getDomainStatsLengthsFieldInfo

func getMemoryParameterFieldInfo

func getDomainStatsStateFieldInfo

func getDomainStatsCPUFieldInfo

func getDomainStatsLengthsFieldInfo

Why do you think they need to be exported ? They are internal helper APIs used by other functions that are exported.

@berrange to use them for parsing returned data from GetAllDomainStats function

Currently this helper functions are exported
DomainStatsState
DomainShutoffReason
DomainCrashedReason
DomainShutdownReason
DomainPausedReason
DomainBlockedReason
DomainRunningReason
DomainNostateReason

is this intentional or accidental?

That doesn't make any sense at all - GetAllDomainStats returns a struct with explicit fields for each item of data. There's no parsing involved.
Those other functions you mention are not functions - they're types for enumerated constants.

@berrange Thanks for info, figured it out.
Closing issue.


.net standard support

EventFlow.MongoDB is built for full framework net451. Since mongo and EventFlow support .netstandard and therefore netcoreapp could the MongoDB package support it too?

hi @edwardwilson
I'm more than willing to assist but I'm currently overloaded with work as it is. If you are willing to wait, I will eventually get to it.
Alternatively, you could create a pull request and I can merge it in?

packet 0.0.2 deployed to nuget, project updated to support nuget in vs 2017


Support not only dates, but also incrementing primary key as cursor for pagination

Something like this:
https://docs.confluent.io/kafka-connect-jdbc/current/source-connector/index.html#incremental-query-modes
in fact, using only a last changed ts, we are forcing the user to add a ts column. Sometimes the user just want to use a classical integer incrementing id, without a ts (in this case we will get only inserts and not updates).


Cluster-autoscaler: pick one of the matching node groups at random

Currently the first matching node group is picked for scale up. CA should select it at random so that all node groups grow in a similar way.
cc: @fgrzadkowski @piosz @jszczepkowski

This change is

LGTM
Do we have a plan to choose node group in a more sophisticated way?

# k8s.io/contrib/cluster-autoscaler
./utils.go:185: cannot use len(expansionOptions) (type int) as type int32 in argument to "math/rand".Int31n

Fixed.

k8s-merge-boot seems broken. Merging manually


Error: git-ql died of signal 9

Environment Details -

Operating System - MAC OS Sierra (10.12.4)
Go version - go1.8
cmake version - 3.8.0
make version - GNU Make 3.81

I have installed gitql as mentioned in the README file.
Whenever I run gitql, I get the following error -
paritoshwalvekar in ~/go/src/github.com/cloudson/gitql on develop λ gitql
[1]    10778 killed     gitql
paritoshwalvekar in ~/go/src/github.com/cloudson/gitql on develop λ git ql
error: git-ql died of signal 9

If I have missed something obvious, I would be glad to fix that.

This doesn't seem to be an error with git rather than gitql.
Tale a look here

Hi @paritosh16, did you fix it?


reporting metrics for graphite before close, also removed systemExit

Trying to fix our Travis builds

Coverage decreased (-0.006%) to 71.209% when pulling 6d22031f861aed486b37c124491cdf47afe18898 on travis-tests-fixes into 8a1f081ff4d3933483a60d5e8bcd8a2f76caeeb3 on master.


Scope gets broken when using the registry mirror feature

Description
We have Containerd configured to look at an mirror registry (harbor) for images for all major public registries as we run an airgapped environment and populate harbor with securityscanned copy of those registries.
But we are unable to pull images from GCR, as GCR supports imagetags like "gcr.io/image1" and containerd sets an incorrect scope for the mirror
Jul  2 20:27:56 <IP_ADDRESS> core[1641]: 2020-07-02T18:27:56Z [ERROR] [/core/service/token/token.go:48]: Unexpected error when creating the token, error: Unable to parse image from string: kubernetes-dashboard-amd64

which means we are unable to pull those images from harbor. (see https://github.com/goharbor/harbor/issues/11852 )
Steps to reproduce the issue:

Use harbor, pupulate harbor with a project called GCR and mirror for example "kubernets-dashboard" into it
Set the mirror Settings for Containerd like this:

[plugins]
  [plugins."io.containerd.grpc.v1.cri"]
    [plugins."io.containerd.grpc.v1.cri".registry]
      [plugins."io.containerd.grpc.v1.cri".registry.mirrors]
        [plugins."io.containerd.grpc.v1.cri".registry.mirrors."*"]
          endpoint = ["https://harbor.sce-dcn.net/v2"]
        [plugins."io.containerd.grpc.v1.cri".registry.mirrors."docker.io"]
          endpoint = ["https://harbor.sce-dcn.net/v2/docker-hub"]
        [plugins."io.containerd.grpc.v1.cri".registry.mirrors."docker.elastic.co"]
          endpoint = ["https://harbor.sce-dcn.net/v2/elastic"]
        [plugins."io.containerd.grpc.v1.cri".registry.mirrors."*.gcr.io"]
          endpoint = ["https://harbor.sce-dcn.net/v2/gcr"]
        [plugins."io.containerd.grpc.v1.cri".registry.mirrors."gcr.io"]
          endpoint = ["https://harbor.sce-dcn.net/v2/gcr"]
        [plugins."io.containerd.grpc.v1.cri".registry.mirrors."k8s.gcr.io"]
          endpoint = ["https://harbor.sce-dcn.net/v2/gcr"]
        [plugins."io.containerd.grpc.v1.cri".registry.mirrors."us.gcr.io"]
          endpoint = ["https://harbor.sce-dcn.net/v2/gcr"]

Ty to run anything with gcr.io/kubernetes-dashboard

Describe the results you received:
The Image cant be pulled from harbor, as the scope doesnt fully match the rewrite
Describe the results you expected:
The Image gets pulled, like all other images that are longer than just the container-name (e.g google/kubernetes-dashboard would work just fine)
Output of containerd --version:
containerd github.com/containerd/containerd v1.3.4 814b7956fafc7a0980ea07e950f983d0837e5578

Any other relevant information:

What is the scope value you are seeing? The pull scope is set by the registry, not by containerd.

this are the http calls that get done by the host, seen from thze registry
Jul  2 22:44:40 <IP_ADDRESS> proxy[1641]: <IP_ADDRESS> - "HEAD /v2/gcr/kubernetes-dashboard-amd64/manifests/v1.10.1 HTTP/1.1" 401 0 "-" "containerd/v1.3.4" 0.002 0.004 . Jul  2 22:44:40 <IP_ADDRESS> proxy[1641]: <IP_ADDRESS> - "GET /service/token?scope=repository%3Agcr%2Fkubernetes-dashboard-amd64%3Apull&scope=repository%3Akubernetes-dashboard-amd64%3Apull&service=harbor-registry HTTP/1.1" 500 0 "-" "Go-http-client/1.1" 0.004 0.004 .

I agree that scope=repository%3Akubernetes-dashboard-amd64%3Apull doesn't look right. Can you curl the /v2/gcr/kubernetes-dashboard-amd64/manifests/v1.10.1 endpoint and get the WWW-Authenticate header? I just want to figure out the source of that value. There were some recent changes related to scoping, but this is unexpected as something containerd would add.

sure, the result ist
curl -I https://harbor.sce-dcn.net/v2/gcr/kubernetes-dashboard-amd64/manifests/v1.10.1
HTTP/1.1 401 Unauthorized
Server: nginx
Date: Thu, 02 Jul 2020 21:33:14 GMT
Content-Type: application/json; charset=utf-8
Content-Length: 152
Connection: keep-alive
Docker-Distribution-Api-Version: registry/2.0
Set-Cookie: sid=ec535d981077ca7aad03631c3b9bf57b; Path=/; HttpOnly
Www-Authenticate: Bearer realm="https://harbor.sce-dcn.net/service/token",service="harbor-registry",scope="repository:gcr/kubernetes-dashboard-amd64:pull"
X-Request-Id: a5036162-5ca7-4ad0-8c8e-db68d2882099

And the Problem might also be in the cri, as we are consuming containerd through it

Unfortunately this is still present in 1.4.1

Is this happening when the registry value is too long or is there any idea what causes it to happen?


Check for full microSD card

Continuing #1577 here. This pull request checks if the microSD card is full and takes appropriate action.

@bansiesta Could you please cross-check this still works on a full microSD card? It does seem to behave for me.

@bansiesta I noticed I hadn't implemented the free space check pacing based on the remaining space as I originally proposed, but for the sake of getting something in this weekend rather than in a few weeks, I guess the current throttling is fine. So if you can re-test this and it holds up, we can get it merged.

I added the check every 20MB in 0265885. I'm testing it right now.

Tested, works!

Awesome!


dApp: Transfer screen redirect when no channels exist

Fixes #2039
Short description
Whenever all channels for all connected tokens are closed and settled a dialog appears warning the user about not having any connected open channels or connected tokens. The dialog has a button that redirects the user to the token select screen.
Definition of Done

[x] Steps to manually test the change have been documented
[x] Acceptance criteria are met
[ ] Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

Connect to a token and open a channel.
Close and settle the channel.

So can the dialog be closed else than clicking on the action button?

Usually, you can also close the dialog by clicking outside it but when the hide-close prop is set you can only close it by manually emitting a close event.

Thanks for taking the time to review @weilbith 👍


some wiki guard mistake，benchmark result. possibilities of other KV engine replacement？

// start one vasto shell
vasto shell
create cluster ks1 dc1 3 1
use keyspace ks1
desc ks1 dc1

delete cluster ks1 dc1

the last line should be delete
I get my bechmark on a i7 7550/16G laptop
time ./vasto bench --keyspace=ks1 -n 1024000 -c 16
benchmarking on cluster with master localhost:8278
put :    35s [===================================================================>] 100% 29145.12 ops/sec
put,get    :   29058.5 op/s
Microseconds per op:
Count: 1024000  Average: 527.6445  StdDev: 371.17
Min: 0.0000  Median: 464.7338  Max: 26443.0000
put :    35s [====================================================================] 100% 29142.38 ops/sec
get :    31s [===================================================================>] 100% 32221.78 ops/sec
put,get    :   32110.0 op/s
Microseconds per op:
Count: 1024000  Average: 470.7078  StdDev: 201.14
Min: 0.0000  Median: 464.2912  Max: 15578.0000
put :    35s [====================================================================] 100% 29142.38 ops/sec
get :    31s [====================================================================] 100% 32218.41 ops/sec
real    1m7.219s
user    0m43.063s
sys     1m17.438s
By the way，is it possible to replace the embed rocksdb with other KV engine？
For most of other KY engines，there is no equivalent Merge operation as Roscksdb‘s. Only some simple put/get/delete/iterate/batch write operations

Many other KV engines provide iterate operation too, as well as get/put/write operations, but most don't implement merge operation.
Of course，all those engines have their own APIs, which are not compatible with rocksdb’s.
Do you mean that to replace the beneath KV engines, most of the vasto KV related API must be change to satisfied vasto and KV inter operation?

What are the KV engines you have in mind?

maybe later.


Query and update

In this project, I used transactions to update and delete records. I also used my knowledge of aggregate functions and GROUP BY to answer analytical questions.
LINK TO THE SCREENSHOTS hosted on Imgur. PS: ITS SAYING THAT MAY CONTAIN 18+ IMAGES BUT ITS JUST THE SCREENSHOTS OF THE PGADMIN4 RESULTS
edit: changed the link with the updated photos.

Thank you for the review!


fix user communities when seeding and userCount updating

userCount wasn't updating correctly when a user joined so that works now and also the seeds were messed up and not adding all of the communites the user was a part of

fixed the create community page change and the communities page should update correctly


Support user-defined key file path location

This PR adds a parameter to the constructor, so that the key file can be set to another location.
If it is not supplied, the default path ($HOME/.pylgtv) will be used.
This would be the first step to solve https://github.com/home-assistant/home-assistant/issues/5645

Great, I updated my PR to use this repo again
https://github.com/home-assistant/home-assistant/pull/5732


Do something with + in links

They are currently ignored, but they signify which way the segment is going (ATCG or GCTA)

It was said in the meeting that we can ignore this. Maybe we can add it later when we have added all other features.


Adding EFLOW-Mariner specifc commands

We also need updates for config.toml, right?

@jlian what do you mean by config.toml? This it's just for adding CA certs to the OS.

@fcabrera23 from here thanks @terrymandin
https://github.com/terrymandin/EFLOWNestedEdge/blob/main/README.md#step-1---create-the-device-installation-scripts

We should also test this tool e2e with EFLOW before merging

@jlian  this is not part of this script - That's part of the OS configuration. We plan to move that in our next EFLOW update, so that step will be no longer necessary.

I think as part of the releases there are templates that include these configs like this one https://github.com/Azure-Samples/iotedge_config_cli/blob/main/templates/tutorial/device_config.toml
So when customer runs
./iotedge_config --config ~/nestedIotEdgeTutorial/iotedge_config_cli_release/templates/tutorial/iotedge_config.yaml --output ~/nestedIotEdgeTutorial/iotedge_config_cli_release/outputs -f

It consumes from the template config.toml

To update this for EFLOW, I'm actually not sure what is the best approach. We could just have a different template for EFLOW but ideally it's a bit smarter than that and can automatically fill the right config based on the OS. Or maybe we should just take this part out and update the system defaults, but @lfitchett I think said that wouldn't work.
Thoughts? CC @varunpuranik

After seeing a message from Paramesh looks like I misunderstood. Basically EFLOW 1.4 will have the same sockets as the default config.

Hi @jlian,
We are introducing the change of the sockets in the EFLOW 1.3 version next week. So that step won't be necessary anymore. I think the PR should be fine now.
Thanks,
Francisco

Can we test your change with EFLOW 1.3 before merging?

@jlian  - Yes, I'm creating the guide also and will test everything as soon as i have the new EFLOW 1.3 image.

@jlian  - I just finished testing with the new EFLOW 1.3 version and suggested PR changes, plus the inbox sockets changes work correctly.

Great! I don't have ability to merge and I guess the build check needs to run. @lfitchett or @varunpuranik can you help?

BTW @fcabrera23 how feasible would it be to make this more EFLOW native with PowerShell commands instead of having to ask the user to go into the Linux parts?


Cookies lost during multiple redirects

Cookies are lost when set by sites returning redirects.
Example:
r=requests.get('http://hostA/url1')
where url gives multiple redirects, possibly multiple sites.
e.g. hostA/url1 -> 302 -> hostB/url2 -> 302 -> HostC/url3
Expectation:
r.cookies would have all the cookies set by hostA, hostB, and hostC
Actual Result:
r.cookies contains only the cookies set by the hostC. The others are lost.
Further example from real-world scenario:
$ python3
Python 3.6.1 (v3.6.1:69c0db5050, Mar 21 2017, 01:21:04)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

import requests
r=requests.get('redactedurl')
r.history
[<Response [302]>, <Response [302]>, <Response [302]>, <Response [302]>]
len(r.cookies)
1

r=requests.get('redactedurl', allow_redirects=False)
r.cookies
<RequestsCookieJar[]>
c=r.cookies
r.status_code
302
r=requests.get(r.headers.get('location'), allow_redirects=False, cookies=c)
r.status_code
302
c.update(r.cookies)
r=requests.get(r.headers.get('location'), allow_redirects=False, cookies=c)
...
r.status_code
200
c.update(r.cookies)
len(c)
3

System Information
$ python3 -m requests.help
{
  "chardet": {
    "version": "3.0.4"
  },
  "cryptography": {
    "version": "2.1.4"
  },
  "idna": {
    "version": "2.6"
  },
  "implementation": {
    "name": "CPython",
    "version": "3.6.1"
  },
  "platform": {
    "release": "17.3.0",
    "system": "Darwin"
  },
  "pyOpenSSL": {
    "openssl_version": "1010007f",
    "version": "17.5.0"
  },
  "requests": {
    "version": "2.18.4"
  },
  "system_ssl": {
    "version": "100020bf"
  },
  "urllib3": {
    "version": "1.22"
  },
  "using_pyopenssl": true
}

r.cookies contains only the cookies set by the most recent response. Use a Session and collect the cookies from Session.cookies.


Add XLA-only merge that can merge all types.

This prevents insertion of H2D and D2H copies when XLA-GPU clusters
have int32 outputs. This merge is only used the merge the outputs
from the XlaRun and the the PartitionedCall node.

LGTM from me, but I want @rmlarsen to also take a look.

Update: I ran the internal benchmarks with this and found some minor regressions, checking if they are noise or not.

Update: I ran the internal benchmarks with this and found some minor regressions, checking if they are noise or not.

Checking in too see if any real issues were discovered.

Checking in too see if any real issues were discovered.

No issues, the only "regression" was a noisy benchmark.  I've kicked off the submission internally.


Password requirements during registration should be applied during password reset

In a default Laravel application, RegisterController::validator is defined in the "user-land" controller. It seems that the intention is to make it somewhat obvious to the developer how to change those requirements to suit their needs. For example, you might want to increase your password requirements ( currently min:6 ).
The password reset flow however has PasswordResetController::rules defined in the ResetsPassword trait, using a separately defined set of requirements for password ( same by default though ).
I imagine that most developers won't realize that if they change the password requirements in  RegisterController, that the end user will not have those same requirements applied during password reset by default.
As far as I can tell this isn't documented anywhere, but I feel like it might fall under the category of "potential security issue". At a minimum, maybe the rules method should be lifted out of the ResetsPassword trait and into PasswordResetController with possibly some notes in the docblocks and / or authentication documentation.

For suggestions and feature requests please use the https://github.com/laravel/internals repo.

Thanks @themsaid :+1:


Fix some bad code

I did an analysis in IDEA and fixed some bad code.

Merged, thanks. For some reason the auto close didn't work. Please feel free to close.

For some reason the auto close didn't work.

I see some commits to 25X and 30X branches but not to master as requested by Author. As no change with auto-closing comment was commited to default branch of repository GH didn't act on them I guess.

Looks like the glitch we had a few days ago is still affecting things. Locally I have the commit to master but agree it isn't showing up in the GUI commit history. I'll try re adding manually.

@paulk-asert Hi Paul
As master branches on gitbox and github diverged, with GH having it at 7f3675ea29, one can do following (not limited to):

with GH admin priviliges for this repo - force push gitbox master to github, as 7f3675ea29 is in gitbox as c652220bb0
or
merge GH master as suggested by You may want to first integrate the remote changes. If you pull and everything is up-to date, you are pulling from gitbox I suppose. So you could do, assuming your master is even with gitbox master:

git fetch https://github.com/apache/groovy master:ghmaster
git merge ghmaster
git push
git branch -D ghmaster

It will allow master on GH to advance to newly created commit on sync (but it can't be squashed one, it has to have links between merged commits). It would look like this: https://github.com/apache/groovy/compare/master...pz-apache:gh_gb_masters?expand=1

Yes, gitbox is the real master. GH is the mirror. We don't have admin privileges on GH. I'll see what ASF infra say.


Allow to specify what media is copied to site_dir

We have a bit a special mkdocs setup. The markdown files are distributed accross the source folder.
I.e. our scripts folder has a README.md that describes all the scripts inside.
In order to do this we set docs_dir to the root of the repository. We then use the pages list in mkdocs.yml to link these files in a meaningful structure.
This work well and gives us a nice looking documentation.
However one issue is that mkdocs is copying the whole source tree into the site directory.
It would be nice to have a way to specify what media is copied, either by having a white and/or blacklist. Or by explicitly setting an option like media_dirs that specifies the folders that should be copied.

I can see this being useful, but I dont think this is a use case we want to try and target initially. So I've marked this as post-1.0 which we are currently trying to drive towards with the minimum features required.

This is a feature I could use as well. We also have a custom site_dir called web which results in the output being built as:
<root>
 - README.md
 - other.md
 - mkdocs.yml
 - web/
     - .git/
     - README/
     - other/
     - mkdocs.yml
     - site/
        - css/
        - fonts/
        - etc..
     - web/
        - .git/
        - css/
        - fonts/
        - etc..
        - mkdocs.yml
        - site/
          - etc..

Something wacky is going on, and I feel that it should only look at .md files in the source folder structure, and then replicate only that in the `site_dir`.

@achton The problem is that your site_dir is within your docs_dir - you shouldn't do this, we should stop people doing this (#384). We can't only look at .md files because people include images and all sorts of other assets which are perfectly valid in documentation.
There was a change recently (#254) that stopped us copying dotfiles, so your .git wont be copied - but this hasn't yet been released. Keep an eye on on the 0.12.0 milestone for that being available - I'm pushing to get that out the door soon.

I believe this has been sufficiently address in #1020. Yes, we still copy everything in the doc_dir, but that is the way it should be (if you don't want a file in your site-dir, then don't put it in the doc_dir). However, we no longer assume all CSS/JavaScript should be linked in the templates. I'm closing this as "fixed."


Moved pixel ajacent to others to try to avoid danger failure.

Checklist

[x ] I ran npm test locally and it passed without errors.

[ x] I only edited the _data/pixels.json file.

[x ] I entered the username in the pixels.json that I'm also using to create this pull request.
[x ] I acknowledge that all my contributions will be made under the project's license.

I'm pretty sure I followed instructions, but danger failed.  I noticed that most existing reserved pixels were adjacent to other reserved pixels, so I moved my lone pixel into the region with the other colored pixels in hopes of fixing the problem.  No avail.

Hi @slooney64. There seems to be a bug with Danger that I filed with them. But I manually merged your changes in. Thank you!


Auto complete

I'm working with version 1.13 and I still find that there is no proper auto complete for the tags.  There's a couple of other editors I've used with better auto-completes.

When a tag is started (ex. <di) the pop-up appears with the suggestions, which is ok.  But  Brackets doesn't complete on Tab or Enter.
Brackets does complete once the tab entry is finished but leaves the end tag on the same line.  What I  have seen on other editors is that the auto-complete leaves an empty line with the cursor at the correct tabbed in location with the closing tag on the line below.

So what would be nice is if one starts typing a tag (ex <d) the pop-up options window appears and hitting tab or enter or some mouse options (which I find too time consuming and annoying... have to remove the hand from the keyboard).  Upon pressing either option the auto-complete finishes with the proper structure:

|      ---> cursor here properly indented

I like Brackets but haven't used it much mainly for this reason

I was using the 1.2 version and everting was working fine, but when i update for the 1.13 version it just stoped to work, when i tried to run it on the terminal it just dont show nothing.
i'm using the last version of arch-linux.
sorry for my english


HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
149
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
44
Maven dependency ordering for branch

+1
mvninstall
773
trunk passed

+1
compile
473
trunk passed

+1
checkstyle
85
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1052
branch has no errors when building and testing our client artifacts.

+1
javadoc
172
trunk passed

0
spotbugs
486
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
707
trunk passed

_ Patch Compile Tests _

0
mvndep
24
Maven dependency ordering for patch

-1
mvninstall
138
hadoop-ozone in the patch failed.

-1
compile
55
hadoop-ozone in the patch failed.

-1
javac
55
hadoop-ozone in the patch failed.

-0
checkstyle
25
The patch fails to run checkstyle in hadoop-ozone

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
735
patch has no errors when building and testing our client artifacts.

-1
javadoc
53
hadoop-ozone in the patch failed.

-1
findbugs
105
hadoop-ozone in the patch failed.

_ Other Tests _

+1
unit
358
hadoop-hdds in the patch passed.

-1
unit
107
hadoop-ozone in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

5816

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1315

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2a93514f426d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4f925af

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-compile-hadoop-ozone.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1315/out/maven-patch-checkstyle-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/testReport/

Max. process+thread count
390 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
1143
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
30
Maven dependency ordering for branch

+1
mvninstall
630
trunk passed

+1
compile
388
trunk passed

+1
checkstyle
71
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
968
branch has no errors when building and testing our client artifacts.

+1
javadoc
173
trunk passed

0
spotbugs
458
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
678
trunk passed

_ Patch Compile Tests _

0
mvndep
20
Maven dependency ordering for patch

+1
mvninstall
585
the patch passed

+1
compile
399
the patch passed

+1
javac
399
the patch passed

+1
checkstyle
90
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
758
patch has no errors when building and testing our client artifacts.

+1
javadoc
176
the patch passed

+1
findbugs
708
the patch passed

_ Other Tests _

+1
unit
379
hadoop-hdds in the patch passed.

-1
unit
333
hadoop-ozone in the patch failed.

+1
asflicense
56
The patch does not generate ASF License warnings.

7750

Reason
Tests

Failed junit tests
hadoop.ozone.om.request.s3.bucket.TestS3BucketCreateRequest

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1315

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a9c39b494fac 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4f925af

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/3/testReport/

Max. process+thread count
1325 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
543
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
33
Maven dependency ordering for branch

+1
mvninstall
603
trunk passed

+1
compile
356
trunk passed

+1
checkstyle
64
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
804
branch has no errors when building and testing our client artifacts.

+1
javadoc
150
trunk passed

0
spotbugs
415
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
604
trunk passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

+1
mvninstall
546
the patch passed

+1
compile
355
the patch passed

+1
javac
355
the patch passed

+1
checkstyle
62
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
654
patch has no errors when building and testing our client artifacts.

+1
javadoc
159
the patch passed

+1
findbugs
692
the patch passed

_ Other Tests _

+1
unit
303
hadoop-hdds in the patch passed.

-1
unit
3363
hadoop-ozone in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

9491

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestContainerStateMachineFailures

hadoop.ozone.client.rpc.TestKeyInputStream

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.client.rpc.Test2WayCommitInRatis

hadoop.ozone.client.rpc.TestReadRetries

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1315

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ed82037be8b1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4f925af

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/4/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/4/testReport/

Max. process+thread count
3855 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
97
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
28
Maven dependency ordering for branch

+1
mvninstall
638
trunk passed

+1
compile
386
trunk passed

+1
checkstyle
68
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
955
branch has no errors when building and testing our client artifacts.

+1
javadoc
171
trunk passed

0
spotbugs
457
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
675
trunk passed

_ Patch Compile Tests _

0
mvndep
18
Maven dependency ordering for patch

+1
mvninstall
586
the patch passed

+1
compile
399
the patch passed

+1
javac
399
the patch passed

+1
checkstyle
79
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
752
patch has no errors when building and testing our client artifacts.

+1
javadoc
166
the patch passed

+1
findbugs
708
the patch passed

_ Other Tests _

-1
unit
353
hadoop-hdds in the patch failed.

-1
unit
2362
hadoop-ozone in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

8646

Reason
Tests

Failed junit tests
hadoop.hdds.scm.block.TestBlockManager

hadoop.ozone.scm.node.TestQueryNode

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.container.server.TestSecureContainerServer

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1315

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e6d421fe112b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6244502

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/5/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/5/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/5/testReport/

Max. process+thread count
5299 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Updated and rebased the patch as now HDDS-1927 got checked in.
It is ready for review.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
82
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
13
Maven dependency ordering for branch

+1
mvninstall
652
trunk passed

+1
compile
417
trunk passed

+1
checkstyle
79
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
970
branch has no errors when building and testing our client artifacts.

+1
javadoc
174
trunk passed

0
spotbugs
465
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
680
trunk passed

_ Patch Compile Tests _

0
mvndep
22
Maven dependency ordering for patch

+1
mvninstall
588
the patch passed

+1
compile
417
the patch passed

+1
javac
417
the patch passed

+1
checkstyle
89
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
882
patch has no errors when building and testing our client artifacts.

+1
javadoc
231
the patch passed

+1
findbugs
818
the patch passed

_ Other Tests _

+1
unit
424
hadoop-hdds in the patch passed.

-1
unit
3528
hadoop-ozone in the patch failed.

+1
asflicense
65
The patch does not generate ASF License warnings.

10322

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.hdds.scm.pipeline.TestPipelineClose

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.container.server.TestSecureContainerServer

hadoop.ozone.client.rpc.Test2WayCommitInRatis

hadoop.ozone.TestMiniOzoneCluster

hadoop.ozone.client.rpc.TestCommitWatcher

hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.client.rpc.TestReadRetries

hadoop.ozone.om.TestOzoneManager

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1315

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 61def168f189 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 93daf69

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/10/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/10/testReport/

Max. process+thread count
4420 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/10/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thank You @xiaoyuyao for the review.
I have addressed review comments.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
29
Maven dependency ordering for branch

+1
mvninstall
618
trunk passed

+1
compile
376
trunk passed

+1
checkstyle
70
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
846
branch has no errors when building and testing our client artifacts.

+1
javadoc
162
trunk passed

0
spotbugs
445
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
644
trunk passed

_ Patch Compile Tests _

0
mvndep
20
Maven dependency ordering for patch

+1
mvninstall
574
the patch passed

+1
compile
368
the patch passed

+1
javac
368
the patch passed

+1
checkstyle
72
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
664
patch has no errors when building and testing our client artifacts.

+1
javadoc
154
the patch passed

+1
findbugs
657
the patch passed

_ Other Tests _

+1
unit
289
hadoop-hdds in the patch passed.

-1
unit
1984
hadoop-ozone in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

7758

Reason
Tests

Failed junit tests
hadoop.ozone.container.server.TestSecureContainerServer

hadoop.ozone.client.rpc.TestWatchForCommit

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1315

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 9b0c75acbd59 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d2225c8

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/11/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/11/testReport/

Max. process+thread count
5101 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/11/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Fix an implicit toString of symbol object which should not throw TypeError

Force serialize exposed a bug in JavascriptConversion::ToString which throws if it is passed a symbol wrapper object instead of correctly calling Symbol.prototype.toString.

Does this fix #435 as well?

Yes, looks like this also fixes #435

Awesome - looks good.


Remove percentage output from EDS reporting

Mitigates https://github.com/istio/istio.io/issues/3853 by removing the inexplicable "(50%)" from output.
A follow-up will be needed to address the documentation in https://istio.io/docs/ops/traffic-management/proxy-cmd/

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: esnible
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [esnible]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@esnible: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
22a4d8806035b63f08fabb43879663fa45f0d27f
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
22a4d8806035b63f08fabb43879663fa45f0d27f
link
/test istio-codecov-master

prow/istio-unit-tests.sh
22a4d8806035b63f08fabb43879663fa45f0d27f
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
22a4d8806035b63f08fabb43879663fa45f0d27f
link
/test istio-codecov-master

prow/istio-unit-tests.sh
22a4d8806035b63f08fabb43879663fa45f0d27f
link
/test istio-unit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
22a4d8806035b63f08fabb43879663fa45f0d27f
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/approve
/lgtm
You'll need to fix the golden outputs in the tests.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: esnible, liamawhite
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [esnible,liamawhite]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: esnible, howardjohn, liamawhite
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [esnible,howardjohn,liamawhite]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: esnible, howardjohn, liamawhite
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [esnible,howardjohn,liamawhite]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@esnible: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
9455d9de564817fac5536c4d545b98a1c16b8a9e
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Let those kudos do their thing.

What's this PR do?
It was looking for a URL parameter, rather than the ol' JSON data. This PR fixes that. 🐛
How should this be reviewed?
Look at those changes. 👀
Any background context you want to provide?
We were also sending an Accepts header which like isn't a thing. jQuery seems to automatically sends the correct Accept header so no need to try to override that here.
Relevant tickets
References a bug in #6424.
Checklist

[ ] Documentation added for new features/changed endpoints.

LOVELY 💩


NullReferenceException in Health Check

We have NullReferenceException in our logs when we trigger our pod’s health check, the exception is there even the bus is healthy.
Stack Trace:

fail: Microsoft.Extensions.Diagnostics.HealthChecks.DefaultHealthCheckService[104]
      Health check masstransit-bus threw an unhandled exception after 12.7546ms
      System.NullReferenceException: Object reference not set to an instance of an object.
         at MassTransit.Transports.ReceiveEndpointCollection.<>c.<CheckHealth>b11_3(<>fAnonymousType56`2 x) in MassTransit.dll:token 0x6003457+0x0
         at System.Linq.Enumerable.SelectArrayIterator`2.ToArray() in System.Linq.dll:token 0x60001c3+0x12
         at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source) in System.Linq.dll:token 0x600011a+0x1b
         at MassTransit.Transports.ReceiveEndpointCollection.CheckHealth(BusState busState, String healthMessage) in MassTransit.dll:token 0x6000cf7+0xb2
         at MassTransit.Transports.BaseHost.CheckHealth(BusState busState, String healthMessage) in MassTransit.dll:token 0x6000c6c+0x0
         at MassTransit.MassTransitBus.CheckHealth() in MassTransit.dll:token 0x60009de+0x0
         at MassTransit.AspNetCoreIntegration.HealthChecks.BusHealthCheck.Microsoft.Extensions.Diagnostics.HealthChecks.IHealthCheck.CheckHealthAsync(HealthCheckContext context, CancellationToken cancellationToken) in MassTransit.AspNetCoreIntegration.dll:token 0x6000013+0x0
         at Microsoft.Extensions.Diagnostics.HealthChecks.DefaultHealthCheckService.RunCheckAsync(HealthCheckRegistration registration, CancellationToken cancellationToken) in Microsoft.Extensions.Diagnostics.HealthChecks.dll:token 0x6000024+0x107

Environment
 .NET 6 Preview 7 / MassTransit 7.2.1

Duplicate of https://github.com/MassTransit/MassTransit/issues/2645
Which was already fixed and released in 7.2.2.


Support multiple topic subscriptions across multiple namespace

Currently, multiple topic subscriptions are supported in the same namespace. Some users want to support multi-topic subscriptions across multiple namespaces. The main consideration is authentication and authorization under multiple namespaces and multiple topics.
First:
MultiTopicsConsumerImpl.java => topicNamesValid
Remove check logic
Second:
Check the content related to permissions, mainly for verification logic under multi-namespace and multi-topic, such as creating consumer, calling schema, authorizing, canceling permissions, etc

Seems this not need to much change, maybe remove the namespace checking, and check if all the the tests passed.


[HELP] Can I setup traefik with 2 different domains?

Hey,
Basically I have been using ´nginx´ for reverse proxy stuff since I started needing it. Now I am try to find a way to come to ´traefik´. I have a noob question and it is: Can I add 2 different domains?
I wanted to setup a gerrit docker with a ´abc.com domain´ but all the other containers with ´cba.com domain´.
Thanks,
Miguel de Carvalho

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.


I would like to buy you a coffee

Sorry I didn't fill out the issue template :)
I really like this implementation of FZF.
Is there a way to support this work financially?

Sorry I didn't fill out the issue template :)
I really like this implementation of FZF.
Is there a way to support this work financially?

Tysm for the kind words and generous offer @Artem-Schander  :)
I do this for fun and my own small contribution to the open source community, no donations are necessary.

I understand. Thank you for your efforts, I really appreciate it


Ctrl+Hover blocks e.g. Copy/Cut/Paste etc.

When a function call or symbol is defined in two different files, the quick open box pops up with different suggestions, effectively blocking all keyboard shortcuts outside of it's scope.
E.g.

Double click on a symbol to highlight it
Keep the mouse still hovering
Press Ctrl in order to sequence Ctrl+C

The quick open box then pops up and you are unable to perform your copy.

https://github.com/austin-----/code-gnu-global/issues/15#issuecomment-191892712

@csholmq this seems to be the behavior of the extension you are using, could that be? Looks like on Ctrl+down they would popup a picker to select the target. I do not think this is standard Code behavior otherwise.

Oh, totally missed that. I was debugging the wrong extension actually :)


NuGet update

Just wondering if it would be possible to publish an updated NuGet package including the recent bug fixes / PRs?

v4 is rolling out now


Import 43aa0b05fa: Bypass Priority Sort clutch fixes (by Caity)

This is an automated proposal to look at a commit made by Caity and import it into Overte

Commit:
43aa0b05facc50c25f538e865a1e80ab2888a5f3

Author:
Caity

Date:
Tue, 21 Jan 2020 21:16

Bypass Priority Sort clutch fixes

Stats:

Filename
Stats
Lines
Added
Removed
Lines in blame

interface/src/Application.cpp

15
7
8
2

interface/src/Application.h

4
2
2
⚠ 0

interface/src/Menu.cpp

4
2
2
⚠ 0

libraries/entities-renderer/src/EntityTreeRenderer.cpp

45
37
8
6

libraries/entities-renderer/src/EntityTreeRenderer.h

18
15
3
1

5 files
-
86
63
23
9

To work on this, please assign the issue to yourself, then look at the commit and decide whether this would be a good addition to Overte.

If the commit is useful, tag it with "Tivoli: Keep", and keep it open until it's merged.
If the commit is not useful, tag it with "Tivoli: Discard", and close it.
If the commit is not useful right now, but might be later, tag it with "Tivoli: Maybe later", and close it.
If it's hard to decide, tag it with "Tivoli: Discuss", and keep it open.

Useful commits should be submitted as a PR against Overte. Tag this issue in PR, so that it's automatically closed once the PR is merged.
You can cherry-pick this issue with this command:
git cherry-pick 43aa0b05facc50c25f538e865a1e80ab2888a5f3

zone culling


Tracking issue for AnyMoE

This is a tracking issue for the development of AnyMoE, which will be broken up into several PRs.

[x] Core functionality, plain models, all APIs: #476
[x] Support for vision models: #515
[x] Support saving and loading gating layer: #519
[x] #528
[x] #529

Done!


Adding note

Closes https://github.com/MicrosoftDocs/office-docs-powershell/issues/7226

Docs Build status updates of commit 5130f57:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Grant-CsTeamsUpgradePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@Kateyanne Please merge this Pr. Thanks

Docs Build status updates of commit 3027f80:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Grant-CsTeamsUpgradePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


New Radau error estimate.

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Update logo images.

These are on Figma and we can tweak them if needed.

Gonna YOLO this, can revert if you hate it


ENH: cross_val_multiscore

Scikit-Learn only accepts scorer that output a float (although see https://github.com/scikit-learn/scikit-learn/pull/7388)
This make it limiting for mass-multivariate analyses like TimeDecoding and GeneralizationAcrossTime.
I suggest we add our own cross_val_multiscore that score the estimator but allows outputing an array of score
e.g.
def cross_val_multiscore(est, X, y, cv=5, **kwargs):
    """cross-validated scores when each score is an array rather than a number.
    """
    if isinstance(cv, int):
        cv = StratifiedKFold(cv, random_state=0)
    scores = list()
    for train, test in cv.split(X, y):
        est.fit(X[train], y[train])
        scores.append(est.score(X[test], y[test]))
    return np.mean(scores, axis=0)

I think this can be closed after #4103? Good to have this!


Incorrect distance

I am using Kontakt beacons for testing and have changed the txPower to -69 as that is the default values for Kontakt.
But for beacons that are placed at 5m the my values range from 11-45m with a median of 18m.
Interestingly the closer the beacon is from the device the more accurate my values are for the distance.
Is there a way to get correct distances for beacons placed at about 5-10m?

Hi,
Thanks for reporting that issue. I've seen the similar problem. I think it may be related to the hardware. As you noticed, when the device is close to the beacon, distance is calculated correctly. Maybe it requires a separate calculation formula for longer distances? You can check, how it behaves with official SDK provided by the Kontakt. If official SDK  also returns incorrect values, you can report it to the support of the Kontakt company.
Exact formula for calculating distance is here: https://github.com/pwittchen/ReactiveBeacons/blob/RxJava1.x/library/src/main/java/com/github/pwittchen/reactivebeacons/library/Beacon.java#L72
Regards,
Piotr

The issue was not with the formula but rather the device and environment noise. Since my use case was indoor navigation, I had account for the noise in the RSSI values using Kalman Filter and some other statistical models and then use the formula to get distance. This at least ensured that even though the values were not accurate but they were relatively correct while dealing with multiple beacons.


fix: app level css fix

Removing text-align: center on demo css

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Instance: cleanup usage

See TODOs in Instance.scala

I guess we can close this issue, because all TODO are addressed as individual issues. Agree?