Support yarn?

This was just a thought that came to my head. But would ya'll consider supporting yarn? Seems like it'd be really useful here because the yarn.lock locks down the package versions and maintainers would probably like to keep that up to date. I envision seeing pull requests that update the yarn.lock and potentially the package.json if the version range is out of date.

As far as I can tell, the package.json is exactly the same in yarn as it is in NPM, so greenkeeper as it is would work just fine with yarn. However, there is a proposed feature update npm-shrinkwrap.json if exists, which would present a feature difference in NPM vs Yarn. You may want to leave a comment there, since this seems more like a variant on that feature than a change to anything existing.

Yeah, maybe these could be merged, but I was thinking more specifically:

I envision seeing pull requests that update the yarn.lock and potentially the package.json if the version range is out of date.

Greenkeeper doesn't support this yet, and that's why I filed this issue. Happy to merge them though. But I think the work required will be pretty different.

We would love to send updates to the yarn.lock file along with our pull requests. Especially because that would be a deterministic operation, that doesn't require a file system, like shrinkwrap does.
We are operating Greenkeeper without any outside investment into the company. We want to build a business that must only serve the community we are building this for, which of course includes ourselves – not any investors.
With the very limited resources we're having because of this, we decided to focus our engineering efforts on migrating Greenkeeper over to GitHub integrations as fast as possible. It doesn't sound like that big of a change, but it's changing a lot behind the curtains.
I think that Yarn and Greenkeeper could be an excellent match, but unfortunately they did not reach out to us prior to their public launch.
They pride themselves as an open community project, and that their ideas were discussed and validated by a lot of people. I'm sad to see that we weren't part of that group.
All I'm left with now is the very sad task to tell you that this isn't going to land anytime soon. It could have been different a few weeks ago when we set our current roadmap.
We're trying our very best to get this to you as soon as possible, and hope you understand our current priorities.
Thank you,
Stephan

Thanks for the explanation @boennemann! Best of luck on your endeavors! I appreciate all that you do for the community. Looking forward to when you can get around to this!

@boennemann I completely see where you're coming from.
I'd be happy to help implement this feature as it could be a really nice win for yarn projects. Do you think you could provide some tips on how to do this? I understand if it is out of scope and that's fine too.
Also as a sidenote I took a quick glance through the code and found evilhackerdude and some other random files. :P what's the story there?

I am actually wondering if this could be solved on the CI side, eg. Travis. When greenkeeper makes a pull request, Travis could spot a difference in package.json, run yarn and commit updated yarn.lock to the PR. It might be a long shot and I don't have that much experience with Travis customization just yet. Opinions?

Thanks for the idea, but the PR should update the lock file too

Oh, misunderstood your comment. Yes, this would still require work on greenkeepers part

Really? How so? Once there is a PR, the greenkeeper doesn't care about anymore, right? So if Travis can just commit to that PR with updated yarn.lock, everything should be just fine.
Thinking about it, there actually no need to check on change in package.json, because yarn takes care of it. After successful build, the Travis would just need to commit yarn.lock if it has changed during run.

There is a slight issue when build is actually executed for a multiple environments (node versions). It would be necessary to specify which version is used for this update I guess.

I guess this is no longer that hot idea after recent discoveries<EMAIL_ADDRESS>For open source apps it can still find it's use, but there is a probably much lower number than modules.

It would be cool to know whether this will be implemented in Greenkeeper since that would be one of a few reasons to switch from private Bitbucket to private Github.

@FredyC you may be interested in a recent Yarn blog post about this subject - https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all
The blog post was made shortly after a discussion here sindresorhus/meta#4

i see lots of value in what yarn provides, but greenkeeper is more important to my workflow at this point. because of this, i'm holding off adopting yarn until greenkeeper supports it, but would love to be able to use it for some of my projects.

A quick update: For the time being there is a community built workaround for this: https://gist.github.com/maxrimue/16e272c4e0b8a8ac9dd5570e180e08c0
We published our roadmap: https://git.io/greenkeeper-roadmap
Yarn support still isn't in it, but we're planning to open up Greenkeeper soon, so that the community can contribute features, just like yarn support.

Possibly useful: https://yarnpkg.com/en/docs/cli/generate-lock-entry

https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all

@destroyerofbuilds, I read it but don't buy the idea.
The problem is when the user discovers the problem, they report the issue to the contributors.
The way we report the issue is typically by the symptom.
At this point, no one, users or contributors, knows about what went wrong.
With the lock file in the library, contributors have a hard time to figure out what actually breaks because when they run yarn and run tests in the library, everything still works as expect.
It is a burden on the contributor needing to aware that, "ah, maybe there is a break in the dependency".
Which defeat the purpose of lock file in the first place.

BTW I created this project to help with this: https://github.com/clarkbw/circleci-update-yarn-lock  definitely not perfect but at least automates the process of creating an updated yarn.lock file.

We should consider prioritizing this as Travis will soon run yarn with --frozen-lockfile causing greenkeeper builds to fail with the following error:

If I got it correctly, it's because greenkeeper doesn't update yarn.lock.
Reference on Travis repo: https://github.com/travis-ci/travis-ci/issues/7395#issuecomment-288854276

@diegohaz well travis already run yarn with --frozen-lockfile so every greenkeeper branch is failing because if this.
mass greenkeeper issues inc 🙈

Any updates on this? Circleci is not using --frozen-lockfile, but since the yarn.lock is not updated on greenkeeper branches, it is worthless.
If you need any help, please let us know how.
(the workaround from @clarkbw does not work for us, because it uses yarn generate-lock-entry to regenerate yarn.lock which is different from what yarn creates when running yarn install)

(the workaround from @clarkbw does not work for us, because it uses yarn generate-lock-entry to regenerate yarn.lock which is different from what yarn creates when running yarn install)

BTW, I'm updating the fix right now.  Happy to look into this as well.  An important note for anyone working on this is that the yarn.lock file needs to be updated before tests are run.

Well with the May 2nd release of Greenkeeper 2.0 and a lot of features put out on the roadmap I hope this gets added!

I've added yarn check to my CI setup.  Ensures that the yarn.lock and package.json file are in sync. It isn't ideal, but it keeps tests from passing in cases where the lock file is out of sync.

Y'all might dig that npm5, due out ~May 5th, is as fast as yarn and will have lock files too.

Will greenkeeper support updating that lockfile?

We're also using yarn check to ensure files are in sync like @jrjohnson.
@jdalton Will npm5 have a command comparable to yarn check? Unfortunately I couldn't find a changelog for npm5.

@keimlink I think your safest bet might be https://github.com/npm/npm/pull/16244
What is still left you can find in v5.0.0 (project)

@zcei Thanks for the links! The performance comparisons between npm and yarn in npm/npm#16244 were very interesting.

I've added yarn check to my CI setup. Ensures that the yarn.lock and package.json file are in sync. It isn't ideal, but it keeps tests from passing in cases where the lock file is out of sync.

@jrjohnson, @keimlink you may wan to run yarn install with --frozen-lockfile. It's a flag that causes yarn to check that the lockfile agrees with your package.json file. If they are out of sync --frozen-lockfile will fail the install.
--frozen-lockfile is not yet documented on the website, but there is an issue file to do that - https://github.com/yarnpkg/website/issues/378

Y'all might dig that npm5, due out ~May 5th, is as fast as yarn and will have lock files too.

@jdalton please keep in mind that npm has had shrinkwrap files (their lockfiles) for years. A core missing feature from npm is the lack of support for automatically generating a lockfile the first time your run npm. Instead, you must call npm shrinkwrap to generate a shrinkwrap file for the first time. This makes adopting the best practice of using lockfiles difficult to organically grow within a community.
npm@5 is not quite as fast as yarn according to this comment.
yarn also just accepted the following change, which will introduce a three fold decrease in installation times - https://github.com/yarnpkg/yarn/pull/3234#issuecomment-297552326

Will greenkeeper support updating that lockfile?

@SimenB GreenKeeper 2.0 supports npm's npm-shrinkwrap.json lockfile. GreenKeeper does not support Yarn.

Will npm5 have a command comparable to yarn check?

@keimlink @jdalton I haven't seen any support within npm for ensuring the lockfile doesn't fall out of sync.

In general, if anyone wants to maintain their dependencies, and use Yarn, please look into renovate. I came across it several month ago, and it's been a really nice tool to throw into a Jenkins setup, and keep all my package dependencies updated, and occasionally update my project's lockfiles.

@destroyerofbuilds npm5 will automatically generate lock files on install and it's perf has been noted to be faster than yarn in many cases.

@jdalton I am just curious, what makes that benchmark you have linked more relevant than the one posted later (by non-owner)? That shows kinda opposite opinion...

@FredyC Others have reported wins too. It's been said that speeds of either vary from project to project so you'll likely see cases of both winning out. It's pretty rad though that they're that close to each other. Everyone wins!

At this point, no one, users or contributors, knows about what went wrong.

@unional I assume users refers to application developers. Let's assume these users are following engineering best practices and committing lock files to their projects. Under this assumption, then we can assume that at some point, before their application broke, they ran yarn upgrade, npm test, and their unit tests failed (or, if they don't have unit tests, then they tested their application in a browser).
Upon encountering the failure, is it to much to ask them to run git diff, and notice the transitive dependencies that changed, and report the issue to those dependencies?

npm5 will automatically generate lock files on install

@jdalton thank you for bringing that to my attention. I hadn't realized that feature made it into the npm@5 roadmap. Glad to see npm@5 adopting a feature that will lead to a greater adoption of lockfiles within our community.
@unional the lockfile behavior of npm@5 will now, by default, be similar to yarn, though you will be able to still use npm-shrinkwrap.json files if you wish (just requires the extra npm shrinkwrap step).

@FredyC Others have reported wins too. It's been said that speeds of either vary from project to project so you'll likely see cases of both winning out.

I do agree with you @jdalton that speeds with vary between projects, but also operating systems, network environments, etc.
If you find any benchmarks that come with their test methodology, I'd appreciate references. I'm always trying to keep an eye out for how people benchmark the performance of these package managers (I have a slightly modified benchmark script myself). I'm also trying to keep an eye out for what conditions allow one package manager to excel over another.

Hi everyone, I am a yarn contributor and I am not here to tell to use yarn instead of npm, but I need your help to understand better the situation :)
I saw greenkeeper the last week and I think it does an awesome work; @finnp @boennemann are there any plans to support yarn in some ways and specifically to support the generation of yarn.lock file? We want to adopt it in the yarn project itself without doing things like that https://gist.github.com/maxrimue/16e272c4e0b8a8ac9dd5570e180e08c0 if we can.
I tagged you guys because you seems the most active developer on the codebase, sorry if I am wrong O.o and thanks for your time!

@voxsim please see the Greenkeeper roadmap - https://github.com/greenkeeperio/greenkeeper/projects?sort=oldest
As noted by @boennemann, and listed under the title Open up Greenkepper on the Roadmap, the Greenkeeper core team will be looking at opening their core to community maintained modules that implement features such as Yarn support.
In the meantime, please consider looking at adopting renovate. (It comes with Yarn and yarn.lock support, plus rebasing, monorepos, and auto-accept on build success)

@destroyerofbuilds Linking to a competitor that you're a contributor of is kinda gross 🤢

@jdalton ? could you please explain me? who is competitor of who? Maybe I lost some pieces O.o btw thanks @destroyerofbuilds! :D

I'm not going to side track this thread more, so will remove my comment after I reply to you. But @destroyerofbuilds contributes to renovate, a greenkeeper alternative.

Alrighty, yarn support, what's taking us so long?
Generating lockfiles on the server side isn't the most trivial problem to solve, but with npm5 adopting package-lock.json by default it's something we will hopefully find a nice solution for soon.
In the meantime: We renamed greenkeeper-shrinkwrap to greenkeeper-lockfile.
We added

npm5 support
yarn support
made it simple to add more CI services

Please let us know how it works for y'all.
I'm going to close this issue while we're trying to figure out how to best add server-side lockfile support, especially with private and git dependencies.
Think you can beat us to it? Great news: This very repo now contains our core worker job implementation. It's not documented yet, but we made the first step of open sourcing it to progress with our promise of opening up Greenkeeper for community contributions.
Peace and love,
Stephan
P.S.: Thanks a lot @maxrimue for providing initial yarn support with this script.


[ClangImporter] Stop abusing a Clang API to avoid a use-after-free.

In order to allow LLDB to debug an app as it was written (in theory), we stuff a semi-preprocessed version of the bridging header into the generated swiftmodule file, so that we can fall back on it if the original bridging header is deleted. The specific functionality we want is in Clang's -rewrite-includes option, but we need to write to an in-memory buffer instead of a file.
The existing code took the meat of clang::RewriteIncludesAction and recreated it manually. We got away with this in the past, but upstream Clang has changed how clang::RewriteIncludesAction works, and now what we were doing before results in the (unused) file output stream being deallocated before the (also unused) buffering stream wrapped around it. Rather than continue trying to half-use an existing Clang FrontendAction, just make a new one that does the thing we want and nothing else.
I'd like to revisit this whole idea in the future – it doesn't actually preserve debuggability in the case where the bridging header may have changed, because we don't check for modifications in all the things it includes. But for now this should preserve the existing functionality.
rdar://problem/33693128

@swift-ci Please asan test

@swift-ci Please smoke test

cc @aschwaighofer

Merging pre-review to get the ASan bot back to blue.

Sounds reasonable to me, and the code looks reasonable, too.  But I'm not an expert in this.


Gradient Style

Hello
I am trying to set the style to Gradient (id ring style = 5) but the result is the same as id ring style = 2. Do I vape set any other configuration to the ring?

Please read documentation.


Auto-disambiguator

We need a script/IRC command to automatically disambiguate an article. I'm not quite sure how the syntax would work.

My current thinking is that this will have to be set up something like $game with repetitive manual input.


KAS-4647: Enable new mu-auth for testing

https://kanselarij.atlassian.net/browse/KAS-4647

Jenkins builds:

https://jenkins.kanselarij.org/job/kaleidos/job/custom_frontend_backend_combination/364/

Current issues:
some ECONNRESETS where happening. Perhaps due to yggdrasil bug locking up the system?
mocklogin sessions are not always created or deleted or valid.

merged the config changes to DEV already for easier deploy for testing

submissions-write still contains minister-roles. I think they should be read-only now.

Accidentally merged this into development instead of acceptance, but pulled the changes from the branch directly afterward


Terminal crashes when second-last tab is closed and alwaysShowTabs is false

Environment
Windows build number: Microsoft Windows NT 10.0.18362.0
Windows Terminal version (if applicable): 0.6.2951.0

Any other software?

Steps to reproduce
1 Set the following global settings in profile.json
    "alwaysShowTabs": false,
    "showTabsInTitlebar": false,

2 Start Terminal

No tab bar visible

3 Control-Shift-t to create a new tab

Here it's PowerShell Core, but reproduces with git-bash for example
Tab bar becomes visible here.
Switching between tabs here does not affect the outcome.

4 Type exit to terminate the currently-visible shell

Middle-clicking the active tab also works. Middle-clicking the other tab does not reproduce.
If extra shells were opened, this doesn't reproduce, it seems to only happen when the tab bar is hidden as part of closing the current tab.
Setting close-on-exit means this doesn't reproduce until the tab is closed, so not related to the shell process terminating.

Expected behavior

Current tab closes
Tab bar disappears
Other tab is usable.

Actual behavior

Current tab closes
Tab bar disappears
(!!) Other tab content is visible, but cursor is not flashing and input is not handled
(!!) A few seconds later, the application crashes, logged in Event Viewer:

Faulting application name: WindowsTerminal.exe, version: 1.0.1910.22001, time stamp: 0x5daf7ab2
Faulting module name: TerminalControl.dll, version: 1.0.1910.22001, time stamp: 0x5daf7988
Exception code: 0xc0000005
Fault offset: 0x0000000000008268
Faulting process ID: 0x2bec
Faulting application start time: 0x01d5a030043b34f4
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_0.6.2951.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_0.6.2951.0_x64__8wekyb3d8bbwe\TerminalControl.dll
Report ID: eb98c87f-b71c-4108-97b3-626d6a0af7f1
Faulting package full name: Microsoft.WindowsTerminal_0.6.2951.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App

I have raised a Feedback Hub issue, but it has not yet appeared in "My feedback". I'll update this ticket once it's showing up (it said it would take a few minutes, but now it shows nothing...)

I'm marking this one for feedback until we get that link. Thanks!

My original feedback never appeared, so I recreated it on another machine: https://aka.ms/AA6p585
Here is the Application Error in Event Viewer. It looks the same as the one from my other machine
Faulting application name: WindowsTerminal.exe, version: 1.0.1910.22001, time stamp: 0x5daf7ab2
Faulting module name: TerminalControl.dll, version: 1.0.1910.22001, time stamp: 0x5daf7988
Exception code: 0xc0000005
Fault offset: 0x0000000000008268
Faulting process ID: 0x4144
Faulting application start time: 0x01d5a0f636dc63b3
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_0.6.2951.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_0.6.2951.0_x64__8wekyb3d8bbwe\TerminalControl.dll
Report ID: af74987f-91be-4e0f-913b-8fa7701c124e
Faulting package full name: Microsoft.WindowsTerminal_0.6.2951.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App

Based on the signature, this looks like a /dupe of #2947. Thanks for the report!


🐛 [firebase_auth] sendEmailVerification on iOS sends default link even with actionCodeSettings.

Bug report
When calling sendEmailVerification() on auth object along with actionCodeSettings. The default verification link in received in mail, but configured link with dynamic link as mentioned in actionCodeSettings should be received. It works in android, but it doesn't in iOS. I am testing in iOS emulator. I guess it shouldn't make a difference with a real device.
Steps to reproduce
Steps to reproduce the behavior:

Authenticate user with Firebase auth.
Create a actionCodeSettings object with your own dynamic link such as "example.page.link", along with android package name and iOS bundleId.
Call user.sendEmailVerification(actionCodeSettings)

 var actionCodeSettings = ActionCodeSettings(
        url: "https://www.example.org/?email=$email",
        dynamicLinkDomain: "example.page.link",
        android: {
          "packageName": "com.example.app",
          "installApp": true,
          "minimumVersion": "10"
        },
        iOS: {"bundleId": "com.example.app"},
        handleCodeInApp: true);
await auth.sendEmailVerification(actionCodeSettings);

The email received in mail starts with: https://example.firebaseapp.com/..... which is incorrect.
Expected behavior
The email received in mail should be configured as per the actionSettings parameters passed.
The desired email link should start with: https://example.page.link?.....
Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 1.23.0-8.0.pre.99, on Mac OS X 10.15.7 19H2 x86_64, locale en-IN)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
[✓] Android Studio (version 4.0)
[✓] VS Code (version 1.49.3)
[✓] Connected device (1 available)

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.11.0-180.0.dev
Flutter SDK 1.23.0-8.0.pre.99
food_angels 0.3.8+25

dependencies:
- async 2.5.0-nullsafety.1 [collection]
- country_code_picker 1.4.0 [flutter]
- cupertino_icons 0.1.3
- firebase_auth 0.18.0+1 [meta firebase_core firebase_core_platform_interface firebase_auth_platform_interface firebase_auth_web flutter]
- firebase_core 0.5.0 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- firebase_dynamic_links 0.6.0+1 [flutter firebase_core]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_localizations 0.0.0 [flutter intl characters collection meta path typed_data vector_math]
- flutter_paginator 0.0.6 [flutter]
- flutter_rating_bar 3.0.1+1 [flutter]
- flutter_slidable 0.5.5 [flutter]
- flutter_svg 0.18.0 [path_drawing xml vector_math meta flutter]
- geohash 0.2.1
- geolocator 5.3.2+2 [flutter meta equatable google_api_availability location_permissions vector_math]
- google_maps_flutter 0.5.29 [flutter flutter_plugin_android_lifecycle google_maps_flutter_platform_interface]
- google_sign_in 4.5.3 [google_sign_in_platform_interface flutter meta google_sign_in_web]
- http 0.12.2 [http_parser path pedantic]
- http_interceptor 0.3.2 [flutter http]
- image_picker 0.6.7+4 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- in_app_update 1.1.11 [flutter]
- intl 0.16.1 [path]
- like_button 0.2.0 [flutter]
- location 3.0.2 [flutter meta location_platform_interface location_web]
- mailer2 1.2.5 [dart2_constant mime logging path intl charcode]
- open_mail_app 0.0.3 [url_launcher flutter]
- provider 4.3.2 [flutter nested collection]
- rounded_letter 0.0.6 [flutter]
- share 0.6.4+3 [meta flutter]
- shared_preferences 0.5.8 [meta flutter shared_preferences_platform_interface shared_preferences_linux shared_preferences_macos shared_preferences_web]
- sign_in_with_apple 2.5.2 [meta flutter]
- sqflite 1.3.1 [flutter sqflite_common path]
- stripe_sdk 2.4.3 [flutter http url_launcher uni_links mask_text_input_formatter]
- toast 0.1.5 [flutter]
- transparent_image 1.0.0
- url_launcher 5.5.0 [flutter url_launcher_platform_interface url_launcher_web url_launcher_linux url_launcher_macos]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- boolean_selector 2.1.0-nullsafety.1 [source_span string_scanner]
- characters 1.1.0-nullsafety.3
- charcode 1.2.0-nullsafety.1
- clock 1.1.0-nullsafety.1
- collection 1.15.0-nullsafety.3
- convert 2.1.1 [charcode typed_data]
- dart2_constant 1.0.2+dart2
- equatable 1.2.4 [collection meta]
- fake_async 1.2.0-nullsafety.1 [clock collection]
- file 5.2.1 [intl meta path]
- firebase 7.3.0 [http http_parser js]
- firebase_auth_platform_interface 2.0.1 [flutter meta firebase_core plugin_platform_interface]
- firebase_auth_web 0.3.0+1 [flutter flutter_web_plugins firebase meta http_parser intl firebase_core firebase_auth_platform_interface js]
- firebase_core_platform_interface 2.0.0 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.0 [firebase firebase_core_platform_interface flutter flutter_web_plugins meta js]
- flutter_plugin_android_lifecycle 1.0.8 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection meta typed_data vector_math]
- google_api_availability 2.0.4 [flutter]
- google_maps_flutter_platform_interface 1.0.3 [flutter meta plugin_platform_interface stream_transform]
- google_sign_in_platform_interface 1.1.2 [flutter meta quiver]
- google_sign_in_web 0.9.1+1 [google_sign_in_platform_interface flutter flutter_web_plugins meta js]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- image_picker_platform_interface 1.1.0 [flutter meta http plugin_platform_interface]
- js 0.6.2
- location_permissions 3.0.0+1 [flutter meta]
- location_platform_interface 1.0.0 [flutter meta plugin_platform_interface]
- location_web 1.0.0 [flutter flutter_web_plugins location_platform_interface http_parser meta js]
- logging 0.11.4
- mask_text_input_formatter 1.0.7 [flutter]
- matcher 0.12.10-nullsafety.1 [stack_trace]
- meta 1.3.0-nullsafety.3
- mime 0.9.6+3
- nested 0.0.4 [flutter]
- path 1.8.0-nullsafety.1
- path_drawing 0.4.1 [vector_math meta path_parsing flutter]
- path_parsing 0.1.4 [vector_math meta]
- path_provider_linux 0.0.1+2 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_platform_interface 1.0.2 [flutter meta platform plugin_platform_interface]
- pedantic 1.9.0
- petitparser 3.0.4 [meta]
- platform 2.2.1
- platform_detect 1.4.0 [meta pub_semver]
- plugin_platform_interface 1.0.2 [meta]
- process 3.0.13 [file intl meta path platform]
- pub_semver 1.4.4 [collection]
- quiver 2.1.3 [matcher meta]
- shared_preferences_linux 0.0.2+1 [file flutter meta path path_provider_linux shared_preferences_platform_interface]
- shared_preferences_macos 0.0.1+10 [shared_preferences_platform_interface flutter]
- shared_preferences_platform_interface 1.0.4 [meta flutter]
- shared_preferences_web 0.1.2+7 [shared_preferences_platform_interface flutter flutter_web_plugins meta]
- sky_engine 0.0.99
- source_span 1.8.0-nullsafety.2 [charcode collection path term_glyph]
- sqflite_common 1.0.2+1 [synchronized path meta]
- stack_trace 1.10.0-nullsafety.2 [path]
- stream_channel 2.1.0-nullsafety.1 [async]
- stream_transform 1.2.0
- string_scanner 1.1.0-nullsafety.1 [charcode source_span]
- synchronized 2.2.0+2
- term_glyph 1.2.0-nullsafety.1
- test_api 0.2.19-nullsafety.2 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0-nullsafety.3 [collection]
- uni_links 0.2.0 [flutter]
- url_launcher_linux 0.0.1+1 [flutter]
- url_launcher_macos 0.0.1+7 [flutter]
- url_launcher_platform_interface 1.0.7 [flutter meta plugin_platform_interface]
- url_launcher_web 0.1.2 [url_launcher_platform_interface platform_detect flutter flutter_web_plugins meta]
- vector_math 2.1.0-nullsafety.3
- xdg_directories 0.1.0 [path process flutter]
- xml 4.2.0 [collection convert meta petitparser]```

</details>

---

Hi @ibrahimbroachwala
Can you please provide  a complete reproducible minimal code sample
Thank you

I have the same issue. Using a iPhone XS. Modifying the action link in the template in Firebase Console changes what I receive in my email, but modifying actionCodeSettings doesn't. In fact, many fields of actionCodeSettings doesn't seem to have any impact (url, handleCodeInApp, dynamicLinkDomain). This is a fairly recent regression, it was working properly ~1-2 months ago.

This now works for me as of firebase_auth: 0.18.1+2. The patch notes FIX: on iOS use sendEmailVerificationWithActionCodeSettings instead of sendEmailVerificationWithCompletion (#3686 ). Based on this, I think either this issue is a duplicate of #3571 or I commented on the wrong issue. Either way, happy it is fixed!

I tested in firebase_auth: 0.18.1+2 as @bkoznov mentioned. Its working fine now 👍🏼
Thanks @bkoznov.
Closing this issue.


Defended JavascriptFunction against use after a context has been disp…

…osed.

Thanks for picking those up.  Actually, do we need to implement Equals() for JavaScript function?  I've just realised that it won't work with putting them in a HashMap.

If you want to put them into a HashMap you also need a proper GetHashCode() implementation. Probably that is what is missing here... The Map first queries by the hashcode value and then finds the right object by comparing all objects with the same hashcode using equals. But the implementation in this PR looks independent of this, so are you talking about your own (external) code?
However, you are right. The current implementation seems to implement an equals (which is not used within Javascript.Net), but lacks the otherwise requires GetHashCode... So maybe either Equals should be deleted or GetHashCode added?


Does it support document composition?

Does MarkDig supports document composition?
Where some Link to md document get included in the rendered document?
Given 2 documents like :
Document_1.md
# Table of contents
* [Introduction](#user-content-introduction)
* [Another section](#user-content-another-section)
* [Credits](#user-content-credits)

# Introduction
[foo](Import:link/introduction.md)

# Another section
Some more text would go here.

# Credits
And the credits would go here.

Here indroduction have a link for composition [foo](Import:link/introduction.md).
Introduction.md
=From loren ipsum markdown=
Palato et admonuit atque vires, tu quibus praebuit bracchia. Vivere mea inque
quam motis pro verba verum, quod lucis sibi.

1. Resolvit insignis verba fuisset et solent Hesperidas
2. Et tum frondere proximus
3. Frigore tuta quoque melior trepidans ducitur cervicibus
4. Umentes consiliique dies sanguine summisque turba
5. Medio carinis
6. Quid nec quae tua fores vulneris

The rendered Md will be : introduction md got inserted in the base document.
# Table of contents
* [Introduction](#user-content-introduction)
* [Another section](#user-content-another-section)
* [Credits](#user-content-credits)

# Introduction
=From loren ipsum markdown=
Palato et admonuit atque vires, tu quibus praebuit bracchia. Vivere mea inque
quam motis pro verba verum, quod lucis sibi.

1. Resolvit insignis verba fuisset et solent Hesperidas
2. Et tum frondere proximus
3. Frigore tuta quoque melior trepidans ducitur cervicibus
4. Umentes consiliique dies sanguine summisque turba
5. Medio carinis
6. Quid nec quae tua fores vulneris

# Another section
Some more text would go here.

# Credits
And the credits would go here.

Does MarkDig supports document composition?

No (Similar question: #618 )
But you can do it by parsing to a SyntaxTree, inspect the links (e.g via doc.Descendants<LinkInline>()), do the Markdown.Parsing on the reference link, copy the content of the parse into the other syntax tree and render from it.


Autocomplete

1. Mistakenly single option for autocomplete
Take for example the following code:
var tmp = document.createElement("script");
tmp.setAttribute("src", "https://ajax.googleapis.com/ajax/libs/jquery/3.3.1/jquery.min.js");
document.getElementsByTagName("body")[0].appendChild(tmp);

tmp.     // <--- start autocomplete (M-tab)

Here it will automatically fill "setAttribute". But there are other functions which could be called.
same here:
    var rawFile = new XMLHttpRequest();

    rawFile.overrideMimeType("application/json");
    rawFile.open("GET", file, true);

    rawFile.     // <--- start autocomplete (M-tab)

Here it fills it with "onreadystatechange". I guess there are more cases.
2. Missing autocomplete
Take for example the following code:
document.     // <--- start autocomplete (M-tab)
window.         // <--- start autocomplete (M-tab)
console.        // <--- start autocomplete (M-tab)

I dont know if these cases are special, so I am not sure if there is more like this. But trying to autocomplete these will fail and nothing will be offered (autocomplete returns "no match").

Hi I think you need setup .tern-project and add browser lib.
{
  "libs": [
    "browser"
  ]
}

Ah, yes. You were right. Thanks in advance :)!


how to delete an entry from a metrics Family

I am looking for an equivalent to remove_label_values  from prometheus crate. Is there a way to remove an entry from a metrics Family?

This is available in the upcoming version, but for now it's only available in the master branch.
https://github.com/prometheus/client_rust/blob/master/src/metrics/family.rs#L240-L260


JAVA_HOME or java.jdt.ls.java.home should not be required for projects that don't develop Java code

Extension Name: vscode-gradle
Extension Version: v3.12.2
OS Version: RHEL8
VSCode version: 1.62.2
Describe the bug
The extension complains about not finding a setting for JAVA_HOME or java.jdt.ls.java.home, even when it's not being used to develop Java code. The extension seems to partially work, though. No language server is started, but Gradle tasks can be executed.
To Reproduce
Start VS Code with extension installed without installing Java extension, without setting a JAVA_HOME environment variable (but with java in PATH.
Expected behavior
I would expect the extension to fall back on the system location for java, which is on PATH, like Gradle itself does, and not require JAVA_HOME or the Java VS Code extension. I see from #249 that this is what the extension used to do.
Screenshots

Output from "Gradle for Java"
Log showing that the system installation for Java is being taken, but I'm guessing this comes from Gradle, not from VS Code.
[info] [gradle-server] Server started, listening on 43861
[info] Gradle client connected to server
[info] Java Home: /usr/lib/jvm/java-1.8.0-openjdk-<IP_ADDRESS>2.b06-2.el8_4.x86_64
[info] JVM Args: -XX:MaxMetaspaceSize=256m,-XX:+HeapDumpOnOutOfMemoryError,-Xms256m,-Xmx512m,-Dfile.encoding=UTF-8,-Duser.country=US,-Duser.language=en,-Duser.variant

Does the bug still exist if you disable all other extensions?
Yes

Is there any gap if you set JAVA_HOME in your environment variable? AFAIK Gradle it self will adopt both the two configurations, but i'm not sure which has the higher priority (JAVA_HOME and PATH)

I can, of course, set JAVA_HOME to make it work. This means, though, that all other developers also need to set JAVA_HOME before starting VS Code. The extension could make life easy by trying to extract JAVA_HOME from the java executable that is on PATH, as it used to.

Also, my java executable on RHEL8 is /bin/java. To get the extension to work with this executable, I have to set JAVA_HOME to /, which looks very weird.

Get it. I'm going to let the language server pick the same config with Gradle.


Q: How does production deployment work?

I don't see any documentation, though I do see something in .travis.yml -- how and when does the code get deployed to production? (point me toward documentation is good). I'd like to know what happens after a PR is merged so I can be on the look out for issues and success metrics.

When PRs are merged to master they are autodeployed.
@seanmarcia set that up, I think?

Correct! On a successful merge to master travis auto deploys the code :)


NuGet Publisher fails with 409 due to publishing symbols packages twice

When using the NuGet Publisher task with a wildcard pattern of *__.nupkg, the step inevitably fails when symbols packages are present. For example, if I have these packages:
bin\my.1.0.nupkg
bin\my.1.0.symbols.nupkg

This task will find both files and try to publish them both. But nuget.exe push will automatically push the symbols package when you push bin\my.1.0.nupkg so when this task then tries to push the symbols package itself, a 409 inevitably results.
I workaround this by using this search pattern instead of the default: **\*.nupkg;-:**\*.symbols.nupkg but it would be nice if the task was smart enough to suppress symbol packages from being uploaded twice.

Your workaround is the correct way to achieve what you want.
At some point, NuGet will probably change how symbols packages work. Per their design that a package is uniquely identified by id + version, it's pretty broken that the client emits two packages with the same id + version but different contents.

Shouldn't this workaround be the default value though? It seems broken that the vso task's default will always lead to failure in the presence of symbols packages. And if there are no symbols package, the new default value would not have any adverse effect.

Symbols packages aren't emitted by default. There's no harm in your PR, though, so I'll take it :) Thanks!

In NuProj projects which produce nupkg, symbols packages are emitted by default. So I'm hitting it a lot. Thanks for accepting.

what am I doing wrong?
I'm using a dot net push task step in my Azure CI pipe and am getting this 409 error.
I see this task is closed as if it's all good, but I don't think so.
Active code page: 65001

SYSTEMVSSCONNECTION exists true

SYSTEMVSSCONNECTION exists true

SYSTEMVSSCONNECTION exists true

"C:\Program Files\dotnet\dotnet.exe" nuget push D:\a\1\a\Ross.Manifest.PdfSplitter.OpenSource.1.0.0-CI-20201030-190639.nupkg --source https://pkgs.dev.azure.com/RossEnvironmentalServices/_packaging/1631486d-2386-7339-ae02-4bbae3d4a949/nuget/v3/index.json --api-key VSTS

Pushing Ross.Manifest.PdfSplitter.OpenSource.1.0.0-CI-20201030-190639.nupkg to 'https://pkgs.dev.azure.com/RossEnvironmentalServices/_packaging/1631486d-2386-7339-ae02-4bbae3d4a949/nuget/v2/'...

  PUT https://pkgs.dev.azure.com/RossEnvironmentalServices/_packaging/1631486d-2386-7339-ae02-4bbae3d4a949/nuget/v2/

  Accepted https://pkgs.dev.azure.com/RossEnvironmentalServices/_packaging/1631486d-2386-7339-ae02-4bbae3d4a949/nuget/v2/ 21430ms

Your package was pushed.

"C:\Program Files\dotnet\dotnet.exe" nuget push D:\a\1\a\Ross.Manifest.PdfSplitter.OpenSource.1.0.0-CI-20201030-190639.symbols.nupkg --source https://pkgs.dev.azure.com/RossEnvironmentalServices/_packaging/1631486d-2386-7339-ae02-4bbae3d4a949/nuget/v3/index.json --api-key VSTS

Pushing Ross.Manifest.PdfSplitter.OpenSource.1.0.0-CI-20201030-190639.symbols.nupkg to 'https://pkgs.dev.azure.com/RossEnvironmentalServices/_packaging/1631486d-2386-7339-ae02-4bbae3d4a949/nuget/v2/'...

  PUT https://pkgs.dev.azure.com/RossEnvironmentalServices/_packaging/1631486d-2386-7339-ae02-4bbae3d4a949/nuget/v2/

  Conflict https://pkgs.dev.azure.com/RossEnvironmentalServices/_packaging/1631486d-2386-7339-ae02-4bbae3d4a949/nuget/v2/ 4221ms

To skip already published packages, use the option --skip-duplicate

error: Response status code does not indicate success: 409 (Conflict - The feed already contains 'Ross.Manifest.PdfSplitter.OpenSource 1.0.0-CI-20201030-190639'. (DevOps Activity ID: 7978D218-A115-4018-987E-A10F1E93E14C)).

Usage: dotnet nuget push [arguments] [options]

Arguments:

  [root]  Specify the path to the package and your API key to push the package to the server.

Options:

  -h|--help                      Show help information

  --force-english-output         Forces the application to run using an invariant, English-based culture.

  -s|--source <source>           Package source (URL, UNC/folder path or package source name) to use. Defaults to DefaultPushSource if specified in NuGet.Config.

  -ss|--symbol-source <source>   Symbol server URL to use.

  -t|--timeout <timeout>         Timeout for pushing to a server in seconds. Defaults to 300 seconds (5 minutes).

  -k|--api-key <apiKey>          The API key for the server.

  -sk|--symbol-api-key <apiKey>  The API key for the symbol server.

  -d|--disable-buffering         Disable buffering when pushing to an HTTP(S) server to decrease memory usage.

  -n|--no-symbols                If a symbols package exists, it will not be pushed to a symbols server.

  --no-service-endpoint          Does not append "api/v2/package" to the source URL.

  --interactive                  Allow the command to block and require manual action for operations like authentication.

  --skip-duplicate               If a package and version already exists, skip it and continue with the next package in the push, if any.

##[error]Error: The process 'C:\Program Files\dotnet\dotnet.exe' failed with exit code 1

##[error]Packages failed to publish

This is still an issue in 2024. Why has it been closed?

I feel your pain right now. Hitting exact same issue, and finding dozens of tickets from 2016/2017/2018/2019 for this issue....
All of which were closed/skipped, auto-closed, or closed without any actual solution, other then "don't include symbols"

Microsoft is being a doos again 🗡


Update kernel for odroid-ux4 (1.X)

@agherzan @floion @lifeeth @michal-mazurek
Connects to resin-os/resinos#92

This looks like it needs a rebase

We are not intending to release this on 1.x so closing this PR.


How to use command line seeding and downloading file?

Thanks for the great project!
My pc : Window8.1 -> created two VirtualBox machines: Ubuntu14.04.2 64 bit
In both Ubuntu installed Webtorrent & webtorrent-hybrid
I'm using command line in one example :A
zdf@zdf-VirtualBox64:~$ webtorrent-hybrid seed aa.txt
seeding: aa.txt
magnet uri: magnet:?xt=urn:btih:c53c2bb5059ad3406100cffdc269dbca7e57db40&dn=aa.txt&tr=udp%3A%2F%2Fopen.demonii.com%3A1337&tr=udp%3A%2F%2Ftracker.openbittorrent.com%3A80&tr=udp%3A%2F%2Ftracker.publicbt.com%3A80&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80&tr=wss%3A%2F%2Ftracker.webtorrent.io
speed: 0 B/s  downloaded: 0 B/16 B  uploaded: 0 B  peers: 0/0  hotswaps: 0
time remaining: a few seconds remaining  total time: 996s  queued peers: 0  blocked: 0
In other example:B
zdf@zdf-VirtualBox64:~$ webtorrent-hybrid magnet:?xt=urn:btih:c53c2bb5059ad3406100cffdc269dbca7e57db40
fetching torrent metadata from 0 peers
No mater use webtorrent-hybrid or webtorrent command
"B" always not start download.
Eventually I use another PC open chrome -> instant.io download the hash upper.
It can download at instant.io!  and then "B" downloaded from chrome
How to use command line only and transfer each other?

Webtorrent-hybrid won't work on windows, and webtorrent as a cli won't connect to web clients. I think that this issue might have something to do with that.
can you post your commands in windows as well?

I don't run command line on windows
Just created 2 VirtualBox machines on my laptop and test command line, laptop is windows.
VirtualBox "A" ubuntu 64bit
VirtualBox "B" ubuntu 64bit

@ericwooley The webtorrent-hybrid CLI does connect to web clients, as well as to other webtorrent-hybrid clients, so his test case should work.
@zoudf My guess is that Virtualbox has a firewall that is blocking WebRTC connections. WebRTC usually finds a way to connect as long as one side doesn't have an overly restrictive NAT. In this case, with two VMs trying to connect to each other, I bet it's just failing to do NAT traversal.
Here's something that is more likely to work: Try seeding from one of the VMs and downloading from https://instant.io using your normal web browser outside the VM.

Another idea: try specifying a TURN relay server. This is a server that will get used to relay traffic between two peers that can't directly connect (like your two VMs).
Just use the rtcConfig parameter to the WebTorrent constructor to specify the server to use. For testing, you can use the config here: https://instant.io/rtcConfig but it's only good for 5 minutes, so this isn't suitable for use in production. Just to get your test working.
You can run your own TURN server or just use Twilio's service (it's super cheap).

@feross Sorry if I miscommunicated, but I meant that the webtorrent-hybrid CLI does, and the regular cli does not.

@ericwooley Gotcha. Thanks for clarifying.

@feross  Yes, after changed VirtualBox machine network setting: NAT--> Bridge. It works well.
Thank you!

Nice.


Segfault in FilterSupportedDevices

After https://github.com/codeplaysoftware/computecpp-sdk/issues/77 , I'm glad to announce I'm having yet another crash. But totally AMD-free this time!
Soo, without further ado:
#0  0x00007fca16a8ea12 in tensorflow::(anonymous namespace)::FilterSupportedDevices(std::vector<tensorflow::Device*, std::allocator<tensorflow::Device*> > const&, tensorflow::gtl::InlinedVector<tensorflow::DeviceType, 4> const&) ()
   from /usr/lib/python3.6/site-packages/tensorflow/python/../libtensorflow_framework.so

Stack trace of thread 20108:
                #0  0x00007fca16a8ea12 _ZN10tensorflow12_GLOBAL__N_122FilterSupportedDevicesERKSt6vectorIPNS_6DeviceESaIS3_EERKNS_3gtl13InlinedVectorINS_10DeviceTypeELi4EEE (libtensorflow_framework.so)
                #1  0x00007fca16a8d776 _ZN10tensorflow12_GLOBAL__N_115ColocationGraph17GetDevicesForNodeEPNS_4NodeEPPSt6vectorIPNS_6DeviceESaIS6_EE (libtensorflow_framework.so)
                #2  0x00007fca16a8b46d _ZN10tensorflow6Placer3RunEv (libtensorflow_framework.so)
                #3  0x00007fca1cc852f9 _ZN10tensorflow19GraphExecutionState13InitBaseGraphERKNS_17BuildGraphOptionsE (_pywrap_tensorflow_internal.so)
                #4  0x00007fca1cc84ec5 _ZN10tensorflow19GraphExecutionState16MakeForBaseGraphEPNS_8GraphDefERKNS_26GraphExecutionStateOptionsEPSt10unique_ptrIS0_St14default_deleteIS0_EE (_pywrap_tensorflow_internal.so)
                #5  0x00007fca1af90a27 _ZN10tensorflow13DirectSession29MaybeInitializeExecutionStateERKNS_8GraphDefEPb (_pywrap_tensorflow_internal.so)
                #6  0x00007fca1af90c8f _ZN10tensorflow13DirectSession12ExtendLockedERKNS_8GraphDefE (_pywrap_tensorflow_internal.so)
                #7  0x00007fca1af90e03 _ZN10tensorflow13DirectSession6ExtendERKNS_8GraphDefE (_pywrap_tensorflow_internal.so)
                #8  0x00007fca187a4b45 TF_ExtendGraph (_pywrap_tensorflow_internal.so)
                #9  0x00007fca1844d621 _ZL20_wrap_TF_ExtendGraphP7_objectS0_ (_pywrap_tensorflow_internal.so)
                #10 0x00007fca28919ad0 _PyCFunction_FastCallDict (libpython3.6m.so.1.0)
                #11 0x00007fca2893fd1b n/a (libpython3.6m.so.1.0)
                #12 0x00007fca288d3b5a _PyEval_EvalFrameDefault (libpython3.6m.so.1.0)

Hey @mirh
Two questions:

Is that a SEGFAULT?
What is reported in your computecpp_info?

Thanks

ComputeCpp Info (CE 0.5.1)
GLIBC version: 2.26
GLIBCXX: 20160609
This version of libstdc++ is supported.
********************************************************************************
Device Info:
Discovered 2 devices matching:
  platform    : <any>
  device type : <any>
--------------------------------------------------------------------------------
Device 0:
  Device is supported                     : UNTESTED - Untested OS
  CL_DEVICE_NAME                          : Loveland
  CL_DEVICE_VENDOR                        : Advanced Micro Devices, Inc.
  CL_DRIVER_VERSION                       : 1800.11
  CL_DEVICE_TYPE                          : CL_DEVICE_TYPE_GPU
--------------------------------------------------------------------------------
Device 1:
  Device is supported                     : UNTESTED - Untested OS
  CL_DEVICE_NAME                          : AMD E-350 Processor
  CL_DEVICE_VENDOR                        : AuthenticAMD
  CL_DRIVER_VERSION                       : 1800.11 (sse2)
  CL_DEVICE_TYPE                          : CL_DEVICE_TYPE_CPU

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Manjaro 17.1
TensorFlow installed from (source or binary): this very dev/amd_gpu branch
Python version: 3.6.4
Bazel version (if compiling from source): 0.9
GCC/Compiler version (if compiling from source): 7.2.1

Hi @mirh, what version of ComputeCpp have you downloaded? I see you are using a pretty recent GCC which might have some incompatibilities with the compiler we use to make the CE builds, particularly if you are using the Ubuntu 14.04 build. Apologies if I've asked you this in a different thread!

The ubuntu 16.04 one.
Though I see Luke is back on a coding spree today.. So guess like I might come back checking this in a week or so..

Oh, I was slightly hoping you'd say the 14.04 one, then we might have the solution to the problem! We build the 16.04 package with GCC 5.4, honestly I doubt that this is the issue (and I've been checking just in case there have been some breaking changes from 5 through to 7) but it might be worth trying it just in case, as debugging remotely is quite hard (and we might not be able to test your exact setup any time soon).

Still happens with latest dev/amd_gpu and computecpp 0.6.0

@mirh have you tried using older GCC (4.8/5.4) or Clang (3.9) as @DuncanMcBain mentioned above?

I tried 4.9 and build failed after some seconds. Not in the mood to experiment further (especially considering.. I don't know, the crashy thingy looks way more mundane than something with the compiler)
Also, no hurry on my side.

Sure. Thanks for trying. All I can recommend after this is to attempt to look in a debugger to see if (for example) it is the vector being empty, as Luke suggested. I'm afraid we have otherwise been totally unable to reproduce this crash 😞

Ok so.. I spent the best part of the last two days to understand how to get the equivalent of python3.6-dbg on arch.
UNFORTUNATELY, I'm just damn getting this problem with my own python build https://github.com/tensorflow/tensorflow/issues/16836
It should derive from the same exact source arch guys used to build release package.. YET type has different dimensions and make the program abort.

Oh, that's disappointing... Do you need the python-dbg package to be able to build a debug TensorFlow library? Otherwise, I'd try building that (i.e. bazel build -c dbg), then running something like
gdb python sometest.py

and looking for the break in libtensorflow_whatever.so.

Gdb python support requires python-debug build (which in turn required rebuilding numpy, tf and freaking gdb itself)
Though, it didn't pass my mind to build tensorflow with dbg switch.
But the problem is, that for some reason, debug python builds have sys.getsizeof(type) = 416 (instead of 400).
That is not liked by this

Ah, I see, that's unfortunate. I have to say, when debugging Python, I've never used the special debug libraries or anything like that, just running python as my GDB executable (it will then get the debug info for the shared libs that have it). I understand if you don't want to go further with this, but we've been unable to reproduce your issue so far :(

just running python as my GDB executable

In that case, the info I get doesn't seem particularly more than the one I posted from coredump in the OP.

Really? Huh! Personally I've used this setup internally here when debugging some bad kernel failures and had no problems. That said, I was making a debug tensorflow wheel, installing that then running (and that wheel can be really really big). I don't remember making any other particularly strange modifications...

Ok, I see.
So I'll try to rebuild tf with normal python, but bazel build -c opt --config=sycl -c dbg --strip=never

I think that should work! I was able to have a decent-ish debugging experience using that configuration :+1:

Ehrm... I have been trying to compile and recompile the thing for almost the whole last 3 days..
But for the love of me, there are just some kernels (e.g. argmax_op.cc and fused_batch_norm_op.cc) that makes everything go OOM.
Now, initially I thought that.. Well, it's me to be the problem: pretending to make suffice a 3GB laptop for this stuff.
But after adding a shitton of swap file and campering in front of top, I noticed (in those cases) freaking compute++ first pretending 3GB is the new standard for a bit.
Then after a short while 5-6gb becomes the norm.
Finally it suddenly skyrockets to 9.6 and crash epically.
I guess like reporting this (if you manage to reproduce?) should go on the computecpp repo, but I'm just this much tired.

I didn't realise you only had 3GB RAM. Compiling a debug build of TensorFlow with that amount of RAM is going to be very challenging indeed (FWIW, I had 16 here originally, but upgraded as compiles tend to take so much). We have been unable to reproduce your issue internally, but I'm operating on the assumption that the vector of devices is empty, which is why the crash is happening. Next week I'll take another look at that code and see if there's a line where we try to look at an element of the vector without checking whether it exists or similar.

Yes but I mean.. I was also skeptic about the whole affair initially
But I can't understand why debug builds would take almost an order of magnitude more memory to complete.
And requiring more than 10GB of ram is bad even for most of your normal computers today.

TensorFlow is huge, and linking takes lots of RAM. I'll admit that it seems excessive, but you can run into similar problems when linking LLVM, for example. If I remember correctly, one of the Python/C++ wrapper libraries in TensorFlow is over 2GB by itself, in debug builds. That will assuredly take much more than 3 GB to link successfully.
I've not looked at the code surrounding your crash yet. I still plan to look at it this week.

Hi @mirh, we'll try to take a look at this this week. @lukeiwanski have we attempted a debug build internally? It looks like this might even come up in plain Eigen builds.

So.. It took for good this fix for debug python builds (not even trying anymore for debug tf builds)
This is what I got
(gdb) py-bt
Traceback (most recent call first):
  0x7ffff089cf58
  <built-in method TF_ExtendGraph of module object at remote 0x7ffff0886a58>
  File "/usr/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1392, in _extend_graph
    graph_def.SerializeToString(), status)
  File "/usr/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1332, in _run_fn
    self._extend_graph()
  File "/usr/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1361, in _do_call
    return fn(*args)
  File "/usr/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1355, in _do_run
    options, run_metadata)
  File "/usr/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1137, in _run
    feed_dict_tensor, options, run_metadata)
  File "/usr/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 905, in run
    run_metadata_ptr)
  File "classify_image.py", line 157, in run_inference_on_image
    {'DecodeJpeg/contents:0': image_data})
  File "classify_image.py", line 193, in main
    run_inference_on_image(image)
  File "/usr/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 126, in run
    _sys.exit(main(argv))
  File "classify_image.py", line 227, in <module>
    tf.app.run(main=main, argv=[sys.argv[0]] + unparsed)

Cstack.txt

@DuncanMcBain / @mirh I will look into that first thing on the Monday. As far as I know we cannot reproduce the issue.
Pinging @mehdi-goli for Eigen assert part of the issue

I knew I'd seen this error somewhere! On Friday, I actually ran into the assert() problem in the office. Thanks very much @mirh, we'll continue to investigate!

To put it simply, there is a slight problem with building Eigen in certain build configurations. We'll work on a fix for this, and let you know here when it's properly pushed. Thanks for looking!

@DuncanMcBain  ping. Any update on this?

Sorry, no. I won't have time to work on this issue.

@mirh there are couple problems in this issue.
One mentioned in https://github.com/lukeiwanski/tensorflow/issues/205#issuecomment-372218778 regarding asserts.. I believe guys on our end are looking at fixing it in Eigen.. workaround for that would be to add  #include <cassert> before Eigen is included.. I would not recommend solving this one.. as you should avoid building debug TF in the first place - fastbuild target will have most of the debug info needed anyway.
I am setting up environment to match yours. GCC 7.2.1 and Python 3.6.5 - anything else?
Can you provide me with the build command that you are using?
Can you confirm that you tried it with GCC 4.8 / 5.4 and / or Clang 3.9?

No, I cannot confirm you that I tried gcc 4, 5 or clang. Just 7.2.1 (and now 7.3.1, but whatever).
Build is bazel build --config=sycl //tensorflow/tools/pip_package:build_pip_package
And I don't have problems with all the debug packages of the world, if it is to help finding out the problem.

Can you try with GCC 4 / 5 or Clang 3.9?

I.. guess in a day or so.

That would be very helpful

I am not able to reproduce the issue with GCC 7 and Python 2/3 on Ubuntu 16.04.
Next to try is the Manjaro.

Possibly, but then wouldn't you get similar problem with computecpp_info?

The crash seems in whatever makes the "list" in tensorflow, more than something about computecpp

What confuses me about this crash is.. that list should always has at least CPU device in it.. but this one seems to be empty?

At least in computecpp_info, as you can see from the third comment, both devices are presented.
Also, on running any TF testcase, the GPU is explicitly stated to be there (./tensorflow/core/common_runtime/sycl/sycl_device.h)
Unfortunately, I can report of https://github.com/codeplaysoftware/computecpp-sdk/issues/77 coming up again with tf 1.8 and cpp 0.7.0...

At least in computecpp_info, as you can see from the third comment, both devices are presented.

Yes, that's what I am getting at. If computecpp_info reports them runtime should(tm) work just fine. ( @DuncanMcBain  to confirm? )

EDIT: I'd also swear until like a week or so ago, configure had you asking which gcc you wanted to use. Now, for reasons, even if I remove it altogether I get no feedback of it at all.

We moved to cross-compilation approach that uses computecpp driver - that way instead of having to call 2 compilers (host and device) you call just one. That way we don't need custom python script to manage that process, bazel takes care of things.
As of the ComputeCpp 0.7 and TF 1.8 as I mentioned earlier - do not use it for now. It is very unstable.. and in the worst case scenario it will break your AMD driver to the point that you need to hard re-boot your rig.
Thanks for testing it tho! It's very useful! Do you want a hoodie? ;D

Yeah if it appears in one it should be seen in the other. It's not exactly the same code (i.e. the same source files), but it's incredibly similar.

Actually, I fear my last problem is a regression in computecpp 0.7.0, because even amd_gpu is giving me the same problem now (and of course, this had to happen that one time I get lazy after some release)
I'm just trying to change to 0.6.1 to see if that really nails it down.

We moved to cross-compilation approach that uses computecpp driver - that way instead of having to call 2 compilers (host and device) you call just one. That way we don't need custom python script to manage that process, bazel takes care of things.

All nice and dandy, but how would I tell it to use /usr/bin/gcc-4.9 instead of the "default" one?

Hola
Would it make sense for any of these commits (prolly 6d09da2 I guess, but I cannot further bissect revisions in between due to an undefined symbol error) to have fixed this?

Well, no answer for my little wondering.. Fixed it is fixed, so gg.

Sorry, I missed this first time 'round! It's fixed now? I don't know that any of the commits in that range would fix it, and it's nice to know what fixed it in case i breaks again, but I'm also not going to look a gift horse in the mouth...


bad merge in softlayer_server_relaunch.rb

there's the detritus from a git merge in this module, and it looks like there's duplicate of the method... not sure which one is correct :)

@matburstorm would you be so kind as to point out the specific file[s] and line[s] you're referring to?

On 05/14/2015 08:13 AM, Matt Eldridge wrote:

@matburstorm https://github.com/matburstorm would you be so kind as
to point out the specific file[s] and line[s] you're referring to?
—
Reply to this email directly or view it on GitHub
https://github.com/softlayer/knife-softlayer/issues/24#issuecomment-102067925.

Here's my commit to a local repo:
diff --git a/lib/chef/knife/softlayer_server_relaunch.rb
b/lib/chef/knife/softlayer_server_relaunch.rb
index cd41e19..fe36a06 100644
--- a/lib/chef/knife/softlayer_server_relaunch.rb
+++ b/lib/chef/knife/softlayer_server_relaunch.rb
@@ -1,3 +1,4 @@
+# -- coding: utf-8 --

Author:: Matt Eldridge<EMAIL_ADDRESS>© Copyright IBM Corporation 2014.
@@ -100,8 +101,6 @@ class Chef
end
end
-||||||| merged common ancestors
-=======

Author:: Matt Eldridge<EMAIL_ADDRESS>© Copyright IBM Corporation 2014.


Update MD file on new branch 2017-32-10_11-12-08

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Replace 'node:stream' & 'node:util' with 'stream' & 'util'

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
ENOENT: no such file or directory, open 'node:stream'

      at Runtime.readFile (node_modules/jest-runtime/build/index.js:1987:21)
      at Object.<anonymous> (node_modules/@fastify/busboy/lib/main.js:3:24)
      at Object.<anonymous> (node_modules/undici/lib/fetch/body.js:3:16)
      at Object.<anonymous> (node_modules/undici/lib/fetch/response.js:4:47)
      at Object.<anonymous> (node_modules/undici/index.js:119:29)
      at Object.<anonymous> (node_modules/@elastic/transport/src/connection/UndiciConnection.ts:36:1)
      at Object.<anonymous> (node_modules/@elastic/transport/src/connection/index.ts:22:1)
      at Object.<anonymous> (node_modules/@elastic/transport/index.js:28:5)
      at Object.<anonymous> (node_modules/@elastic/elasticsearch/index.js:35:5)
      at Object.<anonymous> (node_modules/@elastic/elasticsearch-mock/index.js:24:36)

Here is the diff that solved my problem:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 8794beb..de4754f 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -1,7 +1,7 @@
 'use strict'

-const WritableStream = require('node:stream').Writable
-const { inherits } = require('node:util')
+const WritableStream = require('stream').Writable
+const { inherits } = require('util')
 const Dicer = require('../deps/dicer/lib/Dicer')

 const MultipartParser = require('./types/multipart')

This issue body was partially generated by patch-package.

@sirgalahadcm Which node version are you aiming to support?

I am trying to switch from 18 to 20 and this issue came up, but I think now it might be a config issue on my end. All uses of node:something are failing

@sirgalahadcm sounds like you have old node version somewhere in your pipeline.
Node 20 should handle these prefixes without a hitch

I read: jest-runtime
If there are some mocks, they should be updated


How do I setup a random port for the embedded mongo instance for this

I noted that when I have mongo running in the background while I used the embedded test, the test will fail with an address in use (port 27017).
Is there a way to set the embedded database to use a different port and have this work?
I can stop my mongo instance and it will work but ...

Hi,
thanks for asking! This project made it into Spring Boot itself, the project is obsolete since Spring Boot 1.5
Here's the link to the reference documentation: Auto-configured Data MongoDB tests
You have two options:

Random port for embedded mongo (only has an effect when on the path): No action needed on Spring Boot 1.5 (see https://github.com/spring-projects/spring-boot/issues/8044) , or if you are on 1.4.x and below, spring.data.mongodb.port=0
Disable the auto configuration of embedded mongo while using DataMongoTestlike this:

import org.junit.runner.RunWith;
import org.springframework.boot.autoconfigure.mongo.embedded.EmbeddedMongoAutoConfiguration;
import org.springframework.boot.test.autoconfigure.data.mongo.DataMongoTest;
import org.springframework.test.context.junit4.SpringRunner;

@RunWith(SpringRunner.class)
@DataMongoTest(excludeAutoConfiguration = EmbeddedMongoAutoConfiguration.class)
public class ExampleDataMongoNonEmbeddedTests {
}

If you want to use this project right here with Boot 1.4, then you set the port to 0 like show above or just don't put embedded mongo on the path.


Update Spain holidays

I've fixed Valencia and Aragón holidays.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0004%) to 98.92%

Totals

Change from base Build<PHONE_NUMBER>:
0.0004%

Covered Lines:
6124

Relevant Lines:
6140

💛  - Coveralls


Generate navmesh\roadmap\guidancefield

Hi!
I have read the documentation and read the relative issues, but still confused how to generate navmesh file or guidancefiled. For roadmap, I know that we can draw by hand using the Python utilitiy provided.

From this comment, I realized that the navigation mesh should be drawn by hand in a 3D modeling tool and then be translated to .nav file using the objToNavMesh.py, correct me if I'm wrong :(. If this is the case, could you please recommend me a good 3D modeling tool to use  to draw a navigation mesh, Blender?

How can we generate a guidancefield? I notice that there is a file named fieldM.txt. what's the workflow to generate such file?

For roadmap, we can generate it using the Python tool roapmapBuilder.py, is there any other option?

Thank you so much.

Answers to your question:

Yep. I use blender and/or maya for that purpose. Just create some continguous mesh that represents the traversable space and objToNavMesh will convert it. It's a bit fragile and doesn't do a good job of error reporting if it finds a problem with your nav mesh. I may upgrade that program to be a blender plug in to help facilitate creating navigation meshes.

roadmapBuilder.py has a context that allows for the creation and editing of fields. Right now there's no automatic method (just like with navigation meshes and road maps). But you can create a field, specify its resolution, align it with your simulation domain and then paint the guidance field.

roadmapBuilder.py is currently the only path I use for creating roadmaps. One of these days I'll implement one of the algorithms that does it automatically.

Sorry, this is all by hand.  :-/

Thank you for your answers 👍

Hi,
I'm trying to use objToNavMesh to convert my .obj file.
I test this code on a simple .obj file as following:
v 0 0 0 v 2 0 0 v 2 3 0 v 4 3 0 v 4 0 0 v 6 3 0 f 1 2 3 f 2 3 4 f 2 4 5 f 4 5 6
However, objToNavMesh.py still reports error numpy.linalg.LinAlgError: Singular matrix.
Could you please give me some instructions on how to build the mesh(is there any specific requirements for this mesh?) that is suitable for objToNavMesh.py?
Thank you so much.

Sorry for the slow delay. I was on vacation with my family.
I've now tackled your problem. The solution is in this PR: https://github.com/curds01/MengeUtils/pull/5. Essentially, it's doing more analysis on the input file and tries to give helpful feedback on the properties of the input mesh that are causing problems.
In the case of your file:

You've got a z-up world and the objToNavMesh assumed a y-up. I've added a flag to specify a z-up.
You've got inconsistent winding in your mesh faces. You want to make sure that your vertices are always ordered in a counter-clockwise order when looking "down" at the polygon.

You can try exercising the PR directly. Or you can wait a bit and I'll merge it into master. I like taking a bit of time between "fixing" a problem and merging the solution so I can look at it with fresh eyes. Alternatively, if you'd like to look at it and review it for me, that'd be great too.

Ooops -- the PR has moved to https://github.com/curds01/MengeUtils/pull/6.

Thanks you so much!
In fact, I have also assumed that it could be the problem of coordinate system.
Besides, I am also trying to use roadmapBuilder.py to generate guidance field.
I used these two files as input:
1.feildM.txt, which is the original field file for the scene globalNavSwap.
2.global.xml, which is the original obstacle file for the scene globalNavSwap. (This can be successfully loaded alone)
However, it seems that  the roadmapBuilder.py cannot correctly parse the fieldM.txt. And it reports the following errors:

File "roadmapBuilder.py", line 340, in main
field = GLVectorField( (0,0), (1, 1), 1 )
File "D:\menge\Menge2017\mengeutils-master-new-new\MengeUtils-master\vField.py", line 299, in init
VectorField.init( self, minPoint, size, cellSize )
File "D:\menge\Menge2017\mengeutils-master-new-new\MengeUtils-master\vField.py", line 28, in init
self.setDimensions( size )
File "D:\menge\Menge2017\mengeutils-master-new-new\MengeUtils-master\vField.py", line 87, in setDimensions
self.gridChanged()
File "D:\menge\Menge2017\mengeutils-master-new-new\MengeUtils-master\vField.py", line 313, in gridChanged
self.genArrowDL()
File "D:\menge\Menge2017\mengeutils-master-new-new\MengeUtils-master\vField.py", line 328, in genArrowDL
self.arrowID = glGenLists(1)
File "D:\menge\Menge2017\mengeutils-master-new-new\MengeUtils-master\venv\lib\site-packages\OpenGL\platform\baseplatform.py", line 402, in call
return self( *args, **named )
File "D:\menge\Menge2017\mengeutils-master-new-new\MengeUtils-master\venv\lib\site-packages\OpenGL\error.py", line 232, in glCheckError
baseOperation = baseOperation,
OpenGL.error.GLError: GLError(
err = 1282,
description = '\xce\xde\xd0\xa7\xb2\xd9\xd7\xf7',
baseOperation = glGenLists,
cArguments = (1,),
result = 0L
)

Could this be the problem of the version of PyOpenGL package?  :/

oh, the function VectorField.gridChanged() has been override. The problem solved after commenting the second declaration of this function.


[TCH001] Improvement with FastAPI dependencies

FastAPI makes extensive use of the type annotations at runtime, which then requires that the relevant imports be available at runtime. This can cause issues when Ruff suggests they be moved into type-checking blocks.
Ruff has some configuration options which allows for these imports to be excluded from the type-checking block, such as:

`runtime-evaluated-base-classes
runtime-evaluated-decorators

One place which I think isn't covered is the argument to Depends and Security which allows FastAPI to execute functions in order to perform argument injection.
E.g.
def get_foo():
    return "foo"

from .foo import get_foo
from fastapi import Depends
from typing import Annotated

def repeat_foo(foo: Annotated[str, Depends(get_foo)]):
    return foo + foo

Now I may have missed an option that can then tell ruff that arguments to Depends should not be moved into the type-checking block. But if it is not currently possible, this may be a good improvement to add to ruff.

Have the exact same issue.
I have something like:
from __future__ import annotations

from typing import Annotated

from fastapi import Depends, FastApi
from sqlmodel import Session

from .database import get_session
from .models import test_model

app = FastAPI()

@app.post('/test/', response_model=test_model.TestResponse)
def test(
    *,
    session: Annotated[Session, Depends(get_session)],
    test: test_models.TestRequest,
) -> test_models.TestResponse:
    return test_models.TestResponse()

This flags TCH001 on Depends, Session and get_session and in reality all three are required.
Putting any of these in a type checking block results in runtime errors.
runtime-evaluated-decorators = ["app.post"] has no impact and even if it did I need to use the same Depends call on functions that are not routes.

Thanks. THis makes sense to me.

@jonyscathe @MichaReiser did you guys find any solution beside moving app declaration into a submodule?

@jonyscathe @MichaReiser did you guys find any solution beside moving app declaration into a submodule?

I'm not aware of any solution for this issue. I understand that we need a new setting to configure runtime-evaluated type annotations

For anyone looking at this, the only solution until we get something better is to:

Extract your thing declaration into a separate module
Mention the decorator in runtime-evaluated-decorators

So for example move app = FastAPI() into apps.py and import it from there while adding myproject.myapp.apps.app.post into runtime-evaluated-decorators
Or disable this checks for now.

I think one sensible and easy-to-implement solution for this particular case is to special-case Annotated and treat itself and everything past the first element in the subscript as runtime context, since Annotated is almost always used for runtime introspection. Of course that stops working as soon as you move this out into a TypeAlias in a separate module, so it would still probably be a good idea to add a third setting for symbols that always need to be available at runtime, so corresponding imports would never emit TCH001-TCH003.
But you will also need to take into account that with functions typing.get_type_hints will fail if any of the parameter or return annotations contain forward references to symbols within TYPE_CHECKING blocks, so if you get any hits within a function, you would likely have to retroactively treat all references as runtime references, which may be quite tricky to accomplish. You would likely have to eagerly go through all the annotations for every function to see if there are any matches so you can set a flag before traversing the annotation nodes on the function for semantic analysis, which would slow things down quite a bit.
The same is technically true for classes, but there, you usually can rely on the existing settings. It's also worth pointing out that this should eventually be less of a problem once PEP-649 arrives, since it will extend typing.get_type_hints with the ability for partial failure, so failures in resolving part of one of the annotations will not spread to the rest of the annotation and all the other annotations on the same object. We may see earlier adoption of this improvement thanks to typing_extensions likely containing a backport.
Also not every runtime library will use typing.get_type_hints, there's quite a few that implement their own logic, so the failure conditions are not always the same. That's why in flake8-type-checking I also have the concept of a soft-runtime use, i.e. we treat it as neither required nor not required and just never emit an error in either case, trusting that you know what you are doing.
One good example where this is necessary is SQLAlchemy's Mapped which can refer to other models in relationships and these sometimes need to be forward references without explicit import in order to break import cycles, but everything other than models needs to be available at runtime, so there's no "one-size" fits all solution there. With red knot we could eventually know which symbols refer to other SQLAlchemy models and make a more narrow exception, but at that point it would become a very targeted extension specific to SQLAlchemy.

Turns out ruff already properly clears the TYPE_DEFINITION flag for the second argument of Annotated, however there are additional flags for string annotations with a __future__ import and for the runtime context of the annotation which don't get cleared.
Not clearing those flags makes sense to me, since they provide important context, however we never check for TYPE_DEFINITION on is_typing_reference, so we treat Depends and get_foo as typing references, despite not being part of a type definition. Technically this is once again somewhat correct (especially for the from __future__ import annotations case), however it's not really helpful to treat those references that way, so it's better to never treat non-type-definitions as typing references.
I'll get a PR up with a fix.


DO NOT MERGE For testing NuttX K66 Ethernet fix

This should resolve  https://github.com/PX4/Firmware/issues/15036

Quick and uniformed-on-the-details question -
Initially you 'or' and 'and' in the interrupts bit(s), but later in the code there is  priv->ints = 0;
I assume that probably turns off all interrupt flags?

Thanks @davids5
Quick and uniformed-on-the-details question -
Initially you 'or' and 'and' in the interrupts bit(s), but later in the code there is  priv->ints = 0;
I assume that probably turns off all interrupt flags?

Yes. priv->ints is the state the driver is in. The HW KINETIS_ENET_EIMR, it the HW state. The driver takes interrupts then masks them all and does the work off off a work queue.  It processes the enabled int that hav occured. (KINETIS_ENET_EIR & priv->ints). Driver state can change priv->ints then the HW mask is restored from priv->ints. Before it was screwing with the NVIC which is not the way to do it,

@igalloway the problem was
After I got the interrupts squared away I could see problem was that when any error was detected the buffers descriptors were blindly initialized. This caused the TX of the MAC to be in a bad state. The correct thing to do, we disable the MAC, init the buffers and re-enable the MAC.


static_qt_plugins.cpp causes warnings on Visual Studio 2013

I have integrated the Qt hunter package into my codebase and now I am running into problems. The libraries that use Qt now contain the static_qt_plugins.cpp file which does not compile without warnings.
This is a problem for me as I have the "warning treated as error" option on.
Is there a workaround for this?

which does not compile without warnings

What kind of warning is it?

now contain the static_qt_plugins.cpp file

This file contains only a few lines of Qt's macro, so I guess problem is in Qt's code in fact.

Is there a workaround for this?

I think you can disable warning just for one file by modifying COMPILE_FLAGS property of a source:

https://cmake.org/cmake/help/latest/manual/cmake-properties.7.html#properties-on-source-files

Yesm, I forgot to mention that those are warnings from the QtPlugin header. In the rest of my code I have all Qt header files in one precompiled header file were I can conveniently put #pragmas around the includes to switch off warnings from external code. This does not work for the static_qt_plugins.cpp file as it is not under my control and added directly as a source for the targets that use qt.
I will try to change the files warning level with the source file properties.

IS the static_qt_plugins.cpp file also included if I use dynamic qt libraries?

Nope

How is the file added anyways?

Using INTERFACE_SOURCES feature. You can "grep" the source file you're interested in and check by what target it was added, e.g. static_qt_QJp2Plugin.cpp added by Qt5::QJp2Plugin:

https://github.com/hunter-packages/QtCMakeExtra/blob/b567f44907b7ace824f5b8077feeb9bf30d61bef/cmake/Qt5Gui_ZZZ_HunterPlugin.cmake#L128

Also I think this project may interest you:

https://github.com/ruslo/leathers

Thanks for the tip with the leathers project. I will take a look at it when I start making a linux build work. For now I "fixed" the problem by using dynamic linkage.

@Knitschi feel free to close if this one is resolved

Ok to close this I repeat the solution. I set the source file properties for the interface source files with the following cmake code:
macro( remove_warning_flags_for_some_external_files targetName )

     # blacklist of trouble makers
    set( externalFiles
        static_qt_plugins.cpp
    )

    get_target_property( linkedLibraries ${targetName} LINK_LIBRARIES )

    foreach(library ${linkedLibraries})
        if( TARGET ${library}) # prevent errors with get_property call on our own targets.
            get_target_property( isImported ${library} IMPORTED)
            if( ${isImported})      # prevent errors with get_property call on our own targets.
                get_property( sources TARGET ${library} PROPERTY INTERFACE_SOURCES )
                foreach(source ${sources})

                    get_filename_component(shortName ${source} NAME)
                    if( ${shortName} IN_LIST externalFiles)

                        get_source_file_property( flags ${shortName} COMPILE_FLAGS)
                        if( ${flags} STREQUAL NOTFOUND)
                            set(flags "")
                        endif()
                        set_source_files_properties(${source} PROPERTIES COMPILE_FLAGS "-w ${flags}")
                    endif()
                endforeach()
            endif()
        endif()
    endforeach()
endmacro()


[fix/docs]: Improve backtracking/rat_maze.cpp

Description of Change

Improve backtracking/rat_maze.cpp with refined code and documentation.

Checklist

[x] Added description of change
[x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:

👍 Anyway you can add test cases

I don't know exactly how to add tests in this algorithm?...

👍 Anyway you can add test cases

I don't know exactly how to add test cases in this algorithm?...

The main function already has the test implementation. All it needs is an assertion check.

Can you move the code in main function with the assert to a test function?

Updated, thank you. 🙂


SQLitePCLRaw.bundle_zetetic Issue

Hello @ericsink,
We are finalizing the next release of SQLCipher and noticed when we bump our dependency on SQLitePCLRaw.bundle_zetetic to 1.1.13, the UAP target is including a dependency on SQLitePCLRaw.lib.sqlcipher.windows. Unfortunately, this breaks our integration when bundling the commercial builds of SQLCipher for Windows UAP.
We previously used 1.1.11 of SQLitePCLRaw.bundle_zetetic which does not take on the lib dependency for UAP, it appears to have been added in 1.1.12.
It appears the other platform targets in that package do not depend on a lib package, was this intentional for other reasons? We are tentatively planning on rolling back to 1.1.11 but wanted to reach out to get your feedback.
Thank you,

This was probably a mistake on my part.  I will investigate.

Yep.  That was a bug.  Not sure how I managed that.
I suspect 1.1.11 is the best way for you to proceed.  The only other alternative would be for me to do a new release with this fix, but I am a little hesitant to go that way.  I could be talked into it.

Hi @ericsink,
Thanks for the quick response, no need to make another release at this time for it, we can just run with 1.1.11 for now. If it could be adjusted for the next release that would be great. Thanks!

SQLitePCLRaw 1.1.14, which includes the fix for this issue, has been pushed to nuget.org.
Feel free to reopen this issue if I didn't get it right.

Hi @ericsink,
Thanks so much. We just released SQLCipher 4.2.0 so we will look into 1.1.14 for our next release. Thanks again!


Vim plugins not loading

Hello
I tried to install some plugins for my vim editor, but is seems that plugins aren’t working. I used Vundle and I followed steps from the instruction. Here is my .vimrc file:
set nocompatible
filetype off

set rtp+=~/.vim/bundle/Vundle.vim
call vundle#begin()

Plugin 'VundleVim/Vundle.vim'

Plugin 'itchyny/lightline.vim'

call vundle#end()
filetype plugin indent on

I tried to install only one plugin just for now, only to make test, before installing more plugins. But just as I said, Vundle install plugin but they’re not working.
What seems to be a problem?

Hi：
I met this problem too. I have to run PluginInstall every time open vim.
Have you solve this problem?

I have solved my problem. The difference between our problem is that i put the Plugin statement in _gvimrc (my operation system is windows). I move the Plugin statement from _gvimrc to _vimrc and test  Plugin 'itchyny/lightline.vim', it works fine for me.
I refer to this post

I'm on Windows and encountered this problem too. It seems to be an issue with how plugin paths are added in the function s:rtp_add_a (in Vundle.vim/autoload/vundle/config.vim), which is used when vundle#end() is called. The added paths don't seem to trigger anything when Vim is loading.
On the other hand, when PluginInstall is invoked, the function s:rtp_add is used to add plugin paths individually. And this seems to work every time.
In this patch I've just modified the way s:rtp_add_a adds multiple plugins to runtimepath. Instead of concatenating all paths and ap-/pre-pending them as a single string to rtp, it calls rtp_add in a loop. There's probably a more efficient fix, but this works for me.


Heartbeat

Updated heartbeat variable.

still messed up. I'll do it in another PR.

fixed in 589c3ee9917ee0a7aad2f69de7e623ed68acfb34


Fix for sidebar vertical line issue

Doh... my fault René, I should have looked at what I was doing. Fixed now

Merged, thanks!


Add feature to skip tests.

Add feature that allows tests to be skipped, as some tests should not be run if printers do not contain specific features.

This has now been added to all of the tests that require optional features in a printer.


Remove bundler's cache files that are Git origin

For https://github.com/fluent-plugins-nursery/td-agent-builder/pull/248#issuecomment-771270276

Something wrong. I'll retry.


Changed pivot bar color

Changed the pivot bar color on the Maintenance page.
Type of change?

[x] Bug fix
[ ] New feature
[ ] Enhancement
[ ] Breaking change (breaks backward compatibility)

Description, Context, Motivation
The pivot-bar in the maintenance page did not have high contrast. So, I changed it to #FFFFFF for better contrast.
Demo:

...
Checklist:

[x] All tests passed
[x] The code follows the code style and conventions of this project
[ ] The change requires a change to the documentation
[ ] I have updated the documentation accordingly

Thanks spryor for pointing that out. I hadn't realized that we had an option to change between dark and light themes in the web-ui and that it was being controlled from the themes file. So, I've made the necessary changes and it works for both the themes.
Dark Theme:

Light Theme:

In addition, I accidentally committed .vscode files. So, I had re-commit to make sure that those files were removed from the remote branch.
Lastly, please let me know if you have any comments or if I need to make any changes.

Changed the hex codes according to the style guide and added the files back to the branch.

Added white space at the end of the files.


Fix the bug, that the music will pause on iOS

I found a bug, that the music stops playing as soon you start listen or read the volume. This happens because the default category don't allow to mix music with other apps. Now, when for example Spotify is playing the music will not stop playing on both events.
That's why I added the Category ambient to the AVAudioSession. Also, to have only one instance, I provide the session to both models.
For reading: https://developer.apple.com/documentation/avfaudio/avaudiosessioncategory
Ambient:

The category for an app in which sound playback is nonprimary — that is, your app also works with the sound turned

 private static var audioSession: AVAudioSession {
        let session = AVAudioSession.sharedInstance()
        do {
            try? session.setCategory(AVAudioSession.Category.ambient)
        }
        return session
    }

Maybe, for a better use case : enable to set the options from Flutter?

Thanks! I will consider adding category control on future version.


Repeat Alex Baumann's NPS user activity analysis using Terra NPS data

Alex Baumann undertook an effort to understand user behaviors and experiences that correlate with high and low NPS scores. That experiment is described in detail in the epic description beneath our PRD.
Repeat this process using Terra NPS data as proof of concept that the product team can conduct research looking into NPS correlates.
This analysis should be reproducible by any member of the product team provided they are suitable.

Analysis complete, query saved here: https://console.cloud.google.com/bigquery?sq=950386743938:acbd1e405a7b48efb407a9db8df3f3a8
Sharing the analysis with suitable folks.


Fix useless pkconfig file and install location

The current pkconfig file and install location isn't usable on any 64bit distro

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

When I try using this pull request with using default CMake options, the generated vulkan.pc file looks like:
prefix=/usr/local
exec_prefix=/usr/local
libdir=
includedir=/vulkan

Name: VULKAN
Description: Vulkan Loader
Version: 1.0.43
Libs: -L${libdir} -lvulkan  -lstdc++ -lm -lc
Cflags: -I${includedir}

Note that libdir is not getting set and so pkg-config won't set the -L option correctly.
Also includedir is not correct.
The revised vulkan.pc.in in this pull request looks like:
prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix=@CMAKE_INSTALL_PREFIX@
libdir=@INSTALL_LIB_DIR@
includedir=@INCLUDE_INSTALL_DIR@/vulkan

Name: @CMAKE_PROJECT_NAME@
Description: Vulkan Loader
Version: @VK_API_VERSION@
Libs: -L${libdir} -lvulkan @PRIVATE_LIBS@
Cflags: -I${includedir}

Where are INSTALL_LIB_DIR and INCLUDE_INSTALL_DIR defined?

@karl-lunarg Thank you for the feedback, I have rebased to fix the issues raised.

Where are INSTALL_LIB_DIR and INCLUDE_INSTALL_DIR defined?

My bad, they were defined by rpm packaging.


Run async tasks that access AddressBook threaded mutexes on dedicated threads

Motivation
zebra-network keeps on having hard-to-diagnose hangs. These hangs could be happening because the AddressBook uses a threaded mutex, which blocks the executor, and all async tasks scheduled on the same thread.
Designs

launch tasks that access the AddressBook mutex using spawn_blocking, so they get their own dedicated thread

if needed, make the method async, or make it return a Future
if that's not possible, use block_in_place (this blocks tasks on the same thread, but not the whole executor)

Related Work

temporary fix for #1976

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

FYI this is implemented in PR #3244.


Helm test with ct install is installing as CronJob and not Deployment

While looking at https://github.com/kubernetes-sigs/descheduler/issues/946 I noticed that in the gh-actions output https://github.com/kubernetes-sigs/descheduler/pull/945/checks ct install is installing descheduler in CronJob mode, which does not get useful events and logs back to us (even though we have helm-extra-set-args: "--set=kind=Deployment" set in https://github.com/kubernetes-sigs/descheduler/blob/master/.github/ci/ct.yaml) .
This worked at some point since we had this during reviews: https://github.com/kubernetes-sigs/descheduler/pull/895#pullrequestreview-1055672165 :thinking:
Installing it as Deployment will be better to check info and possibly add subsequent simple tests against that pod.

/assign
@knelasevero would you take a look at https://github.com/kubernetes-sigs/descheduler/pull/953 and see if it makes sense?

Thanks @a7i ! And sorry for the delay on this one. For sure reason I totally missed the notification

No worries @knelasevero


[LIGHTNODE SALE] Add Privacy, Terms and Conditions and Terms of Use

CHORE: Add the following pages that will link to new windows.

Terms and Conditions: https://docs.google.com/document/d/1puUO41mEjnj6qQqFpSyjzXIJanfG16KoXEZ8xBoB-VI/edit
Terms of use: https://docs.google.com/document/d/1xt-CNyditQZXZLcfwM_wsPMpiBL5TUiFQu7Alnw5VeY/edit
Privacy Policy: https://docs.google.com/document/d/1wohVWiIEvsrswkV3KbOoxmOmc0fwnE6Wsk_JIqQrKrE/edit?usp=sharing

@jamie088 @taariq The Designs: Figma: https://www.figma.com/design/yC7zuL9bFx9yvPd2aBalX6/Paloma-Light-Sale-Node?node-id=1045-1079&t=LTktCxS9yrHTIc4m-4

Thank you @joycehermosilla. Moving to assign now just to @jamie088

@taariq @joycehermosilla Where is the Privacy Policy used? I couldn't find it in design.

@joycehermosilla the Privacy Document is here: https://docs.google.com/document/d/1wohVWiIEvsrswkV3KbOoxmOmc0fwnE6Wsk_JIqQrKrE/edit?usp=sharing

@jamie088 @verabehr https://www.figma.com/design/yC7zuL9bFx9yvPd2aBalX6/Paloma-Light-Sale-Node?node-id=1-2491&t=l7AjgYWToQEdAUvN-4 Added here.

shipped with https://github.com/palomachain/website/pull/104


Startup apps management

Description of the new feature / enhancement
select which apps to be started with Windows
Scenario when this would be used?
Possibility to see and manage all startup apps on one place
Supporting information
No response

That's what Autoruns is for. It doesn't really make sense to recreate a utility that already exists.

In Task manager, there is the start up tab,   or are you looking for more?  /needinfo