Support for more encoding-types?

Currently the README.md says only latin1, utf-8, utf-16be and utf-16le are supported.
It seems that Atom does support other encodings: https://github.com/atom/atom/issues/1806
(and looking at encoding-selector package there's quite many from diffent ISO-8859- variants to Windows 1252 https://github.com/atom/encoding-selector/blob/master/lib/main.coffee)
Just wondering why? Just not implemented or is the README just outdated?
Well, okay utf-8 is pretty much default these days, but sometimes you just have to work with legacy stuff that is something else.

Those are the ones supported by EditorConfig:

charset: set to latin1, utf-8, utf-8-bom, utf-16be or utf-16le to control the character set. Use of utf-8-bom is discouraged.
- http://editorconfig.org


fix(discord): slash commands

修复了私聊无法使用 slash commands
修复了指令重复更新的问题

Codecov Report

Merging #145 (c9e6496) into master (5a717e1) will not change coverage.
Report is 10 commits behind head on master.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   81.83%   81.83%
=======================================
  Files           1        1
  Lines         424      424
  Branches       86       86
=======================================
  Hits          347      347
  Misses         77       77


Allow copy_extensions to list individual extensions to be copied, rather than only copying all or none

copy_extensions=subjectAltName would make life a lot easier, I don't want to have copy_extensions=copy due to the numerous risks (already listed in the man pages), but copy_extensions=none isn't very helpful either. The principle of least privilege would seem to indicate you'd want to be able to list individual extensions to copy.

It looks like there is a PR dating back to 2015 that implements this: #341
but for some reason it got neglected since then.

It looks like there is a PR dating back to 2015 that implements this: #341
but for some reason it got neglected since then.

@philomory are you willing to pick up writing a PR for this as a community issue?


Add Index, nth(index), and get_tapscript to Witness

Ref: https://github.com/rust-bitcoin/rust-bitcoin/pull/672#issuecomment-980636502
In a taproot script payment with annex, quick access to the 3rd to last element (which is the actual script in this case) is convenient.
This feels like kicking the can down the road again, but I think it's a nice to have method.
@RCasatta @dr-orlovsky were discussing this issue. I would like to ask if they have any thoughts on the addition of this.

lol. concept ACK.
I think if we ever hit four, then we should just give in and have a Vec of indices, which would at least be much cheaper than having a Vec<Vec<u8>>. But given the slowness of bitcoin and the general nature of the annex, I'll bet that we don't hit four for many years.

I was also debating adding a small helper method for getting the byte slice of the tapscript as an Option.
It would basically be:
if w.len() >= 2 && w.last().get(0)? == &0x50 { w.third_to_last() } else { w.second_to_last() }
Whether or not the Witness stack is actually p2tr or not, we don't know, so just blindly follow the BIP. The caller will have to ensure they only call it on a p2tr Witness stack.
Thoughts?

 You know, there is this thing called an array that allows you to reference multiple items by a number. :)
I suggest having a single field indices_cache storing the indices. Then instead of having whatever_to_last specialize nth(), last() on the iterator to use the cache and document this property.
Also agree fully with looking into having Vec if there are many elements - I'd still like to cache common sizes without allocation though.

I suggest having a single field indices_cache storing the indices.

This would be the correct way to do it. I would like to see what @RCasatta thinks as he originally authored the new Witness struct.

I didn't know what to say because I didn't like the API and neither adding indices_cache because it will require other allocations impacting deserializing performance.
But I think we can have a nicer API without impacting performance!
We can add the indexes at the beginning of the content field as fixed-size integers (I think u32 since u32::MAX>MAX_VEC_SIZE).
When deserializing, the number of elements in the witness is known at the beginning so we can skip the first size(u32)*witness_elements bytes and fill it while deserializing the elements. The current initial size of content (128) should still be enough to accommodate more than 75% of witnesses in mainnet but this should be double-checked.
When serializing, after encoding the witness_elements varint we can simply skip the first size(u32)*witness_elements bytes of content.
At this point, we can implement an efficient Index (and also first() last() and nth()) by doing a lookup in the indexes at the beginning of content like index = u32::from_xx_bytes( content[i * size(u32)] ) as usize
The index points at the ith element before the varint storing the length, once the length is read we have the start and end of the slice of the requested witness element.

We don't know because we would have to know the script_pubkey of previous transaction so validating this is impossible right?

What I meant was, we assume the caller to have all the external info available to discern that this is p2tr. This includes the script_pubkey of the prev_out.

Neat. It took me a moment to understand what you're saying @RCasatta but I like it. Basically we widen the allocation during deserialization and copy each witness element's length prefix into the extra area where it can be efficiently indexed into.

I don't think we should have a push method on this type. If you want to modify it you should have to convert to a Vec<Vec<u8>> and back.

Perhaps the indexing fix with push() removed can land in a future breaking version update.
Any objections to merging this as-is for now? Or does anyone else want to take a crack at adding the indexing with push() present?

I'll also add the helper method for getting the tapscript.

How about adding the indices at the end? It'll still require moving things around during push but not updating the indices and there will be generally less bytes to move. It still needs to be documented as somewhat slow but people should already expect at least allocations from push. We could optimize it by providing some reserve API.

Any objections to merging this as-is for now?

Adding APIs that will be removed in the future is not nice. I suggest you add nth(n: usize) method and then conditionally iterate or not, hiding the cache. If we implement @RCasatta suggestion we will keep it and just change the implementation.

I wouldn't mind having a push method, especially since we already have one, but it does seem like extra work and complexity for a niche feature. (Usually Witnesses are constructed in one shot from a Vec<Vec<u8>> and converted, or parsed from a transaction and never changed.)
OTOH it would be remarkably easy to fuzz this against the push-to-Vec<Vec<u8>> strategy so I'm not too worried about bugs.

TODO:

Fix fuzzer errors (le bytes vs ne bytes?)
Write tests for get_tapscript

Usually Witnesses are constructed  in one shot from a Vec<Vec<u8>>

I never implemented it myself but I'd expect at least some people would like to collect an iterator or something else that makes fewer allocations.

I'm assuming the fuzzer errors mean my logic is causing a panic instead of handling garbage input gracefully...
I'll have to look over the changes again. If anyone has time to review I'd appreciate it.
Thanks.

Not sure why the fuzzer is failing... I have no clue how to read the output.
I am assuming there's some sort of panic when the deserializer is fed garbage.

CI shows compile errors though.

These are unrelated to the PR. Probably need to rebase for some reason...?

Looks like master merged some changes to the test suite...................... not sure how/why that would affect this branch though...?
Looks like incorrect imports in bitcoin/examples/taproot-psbt.rs

See #1345

This PR can be rebased now to fix CI, sorry for the inconvenience.

I am at a loss with how to move forward with this. Looks like the bench tests are also broken.
Also, I have no clue how to read the results of the fuzz tests... again, I assume this means that my code is panicking when deserialize is fed random data somehow... but it would be nice to see what data specifically it choked on and from which byte it thought was the "start" so I can follow along and see where it's broken...
The fuzz output is just a bunch of hex with no indication of anything.

The fuzz output is just a bunch of hex with no indication of anything.

In the fuzz target source, let's take fuzz_targets/deserialize_witness.rs, there is a #[test], you can replicate the crash by replacing the placeholder "00" with ffea48004b0000ccb100ccb1 taken from the fuzzer result log.

FYI, the nightly CI fail (due to benches failing) is unrelated to this PR - I'm investigating it.

Nightly bug is fixed now.

All tests are passing.
Please review when you have the time. Thanks!

Thanks for your contribution @junderw. This PR is hard to review because there are patches later in the series that change code written earlier in the series, worse still, one patch changes ne -> le then a later patch changes le -> ne and neither patches has any justification as to why the change is being made. Can you please squash this PR down in to a set of patches that each do a single thing with description in each patch of whats being done and why - otherwise it is very hard to work out if I should ack or not.
Sorry to be a pain.

Thanks @tcharding I have separated it into two different patches. The index patch was fairly intertwined. Perhaps I could have teased out Index, but it was a small enough diff and is basically a simple wrapper around nth(usize), so I left it in.

You legend, thanks a lot man you went above and beyond, that was super nice to review!

utACK (will ACK for real once my tests finish). This looks great! My comments are only nits.
Some of these new functions are great candidates for property testing, a la #1370.

I will make another PR fixing the nits later.
Thanks!

I'll merge this. Nits can be addressed in a later PR.


Optimize tsc --w using the CoS builder

It would be great if one could run tsc -w --eraseMode (or something similar) that would allow to simply erase the TypeScript annotations and hopefully generate js code quickly
Right now making tiny change in one file:
eg. console.log('test1') to console.log('test2')
triggers "recompilation" (even if incremental) - that takes some time and keeps getting slower as project grows
VScode already makes a great job with showing errors in a project - and I would be happy to have long (re)compilation with full errors to be part of build process - what I would prefer is ability to have 'instant' change reflection in generated js files
Related to: https://github.com/Microsoft/TypeScript/issues/10878

This is a tricky problem as changes in one source file can produce errors in other source file such as renaming a function in one file, and not updating the other files to use the new name. So at the bare minimum, you need to re-evaluate error checking in the other source files in the project. In other cases, such as as changing the values of a const enum, you also have to re-emit as well.
I recently wrote my own watch script using the language service API's and wound up writing both 'watch' and 'unsafewatch' tasks. The watch task does the recompilation ala tsc, and the unsafe version does the single file fast turnaround times like you are describing, at the expense of generating code that may or may not be broken.
To do this correctly, I believe the language service API's would need to expose a way to query the interfile dependencies based on which symbols are used and where they are defined. I didn't see anything exposed in the API along those lines when I was working on this, but I think it could be a welcome addition.

I think --isolatedModules would get you part of what you want. The docs for it aren't the clearest, but I think it essentially 'turns off' full-project typechecking and puts tsc into transpilation mode. I use it for fast compilation in webpack projects and rely on my IDE + CI server to catch compile errors.

--isolatedModules is our most confusing flag. What it actually does is validates that your project can be safely single-file-transpiled. This means no using const enums, no use of unqualified value names in a merged namespace, etc.. It still performs a full typecheck to do this validation (it has to); a project that does compile correctly under this flag can be safely compiled under a faster transpile-only mode.

tsserver already knows how to do this correctly without a flag; we'll be moving the code from tsserver to tsc that can do this correctly for isolated modules

@zhengbli we will need to move the builder logic into program perhaps, and allow it to be used for both compile on save, and --watch.

also related https://github.com/Microsoft/TypeScript/issues/11229

I believe this is a really important issue.

@mhegazy - Hi, just wondering if there was an ETA on this please? Compile times are killing me...

can't look at so many peoples suffering here:
        {
            "taskName": "quick transpile",
            "suppressTaskName": true,
            "showOutput": "always",
            "command": "node"
            "args": [
                "./node_modules/typescript/bin/tsc --target YOUR_TARGET_HERE --module YOUR_MODULE_HERE --noResolve --rootDir YOUR_ROOT_HERE_IF_NEEDED --outDir YOUR_OUTPUT_FOLDER_HERE_IF_NEEDED ${relativeFile}"
            ]
        }

hook the above json into your tasks.json in .vscode folder, make sure to replace all *_HERE_* placeholders with something meaningful for your setup, add more or remove inapplicable, etc. you should know better
assign this task a shortcut File -> Preferences -> Keyboard shortcuts:

add:
 {
     "key": "ctrl+q",
     "command": "workbench.action.tasks.runTask",
     "args": "quick transpile",
     "when": "editorTextFocus"
 },

go to your TS file with changes and hit Ctrl + Q
observe the following output

so what just happened? why do i see these errors in the output?
no panic, we just transpiled the current file into JS ignoring all type checks, so we got our JS from TS lightning fast and the price of no gurantees of being correct assuming you know there were no errors
enjoy

The fix should be in typescript@next today. please take it for a spin and let us know if you are running into issues.

Like @aleksey-bykov we have a similar solution leaning on everyone's experiences to make a gulp watch task
Our typescript full compiles took around 18 seconds, incremental 15 seconds, but whatever visual studio 2015/2017 did it could produce the .js file in the time it took to refresh the browser. So we hooked up a watch to .ts files and compiled the single file.
An example of what we did is here if you're interested (Although it could use cleaning up and changing for your output):

// A experiment for quicker builds.
gulp.task('watch:typescript:quick', function () {
    return gulp.watch(files.tsFiles).on("change", function(file) {
        // Workaround to keep original folder structure
        var currentDirectory = path.dirname(file.path);
        var sourceDirectory = 'scripts';
        var index = currentDirectory.indexOf(sourceDirectory);
        var relativeDirectory = currentDirectory.slice(index + sourceDirectory.length + 1);
        var outputDirectory = __dirname + "\\scripts\\output"
        if (relativeDirectory) {
            outputDirectory = outputDirectory + "\\" + relativeDirectory;
        }
        var cmd = '"' + __dirname + '\\node_modules\\.bin\\tsc.cmd" --target ES5 --module AMD --sourceMap true --noResolve --outDir "' + outputDirectory + '" "' + file.path + '"';
        var startD = new Date();
        console.log(startD.toTimeString().split(' ')[0] + ' - File change detected. Starting incremental compilation...');
        exec(cmd, function (err, stdout, stderr) {
            if (stderr) {
                console.log("Command Failed: " + stderr);
            } else {
                var endD = new Date();
                console.log(endD.toTimeString().split(' ')[0] + ' - Compilation complete. Watching for file changes.');
            }
        });
    });
});

Obviously any errors are not reported and it does its best, so a full compile is needed at some point, but for incremental changes we wanted a quick turn around as possible like we can achieve in VS2017.
I will try out the changes to --w and see if it does what we need. Thanks

@mhegazy and team - just to say, we upgraded today (now that the ImmutableJS type definitions have been fixed) and we're seeing some impressive speed improvements in --w mode.
Thank you very much!

thanks for getting back to us on this. glad we could make it work better for you.
The change was big, so i would not be surprised if there are issues. please feel free to reach out if you are running into any issues.

We have switched to using it in production. Our watch builds are down from 14 seconds to 1-2 depending on how dependent the file is. Amazing work, looking forward to that api you say you will expose so other tools can use it too. Great Job.


[BitBucket GitHub] fixes and tests for BitBucket service integration

Add test suite for BitBucket service integration
Present BitBucket issues as a metric (for consistency with BitBucket PR endpoint and GitHub endpoints)
Factor out a shared regex
Fail cleanly if count is undefined

i.e: do this:
not this:

I expect the GH failures are caused by #979 rather than stuff I've broken. If it makes it easier to review, I could back out 3611916 so only the BitBucket tests need to be run.

I expect the GH failures are caused by #979 rather than stuff I've broken. If it makes it easier to review, I could back out 3611916 so only the BitBucket tests need to be run.

No need, I'll just run the Github tests locally before merging. They are green right now. ✅

@platan - I can't think of another case where should be valid for count/size to be undefined with a 200 OK response so I have changed the condition to check for if (res.statusCode !== 200) :+1:

updated based on latest review comments

Github service tests passing locally 👍
Thanks!


Possible Bug with Inactive warrant showing as Active?

What version of Node.js are you using?
Latest
What version of npm are you using?
Latest
What operating system are you using?
Windows Server 2019
What version of SnailyCAD are you currently using?
v1.26.7 7ecc014
Describe the Bug
I'm not sure if its a bug or not? It says active warrant but if you look at the drop down it says Inactive is selected?

Expected Behavior
Perhaps if its more clear
To Reproduce
No response

I can confirm this behavior as a valid bug

Thanks for confirming! I'll take a  look shortly


Checkpoint 3

Hi @droberts84,
Sorry about that. Here's the PR. Please see the most recent commit

👍


Nextjs 13 appDir support

Resolves #91

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


🐛 Fix check for non-public keys

The existing check && check means it will only check the key.type parameter on things that are NOT crypto keys. This flips the logic operator to a disjunction to look for things that either are not crypto keys or are crypto keys that are not public

never mind


Change to use Node instead of RawMetadata in LoadStatsConfigJSONStr

To give more extensibility to the function LoadStatsConfigJSONStr, the entire Node is given instead of "RawMetadata".
Based on this, platform specific codes may be able to fill load_stats_config_json_str with more flexibility.
Change-Id: I21117025bb99b62c18484d2f1598a001751faaa4

/cherrypick release-1.18


New Parser and Analyzer support ShowOpenTableStmt（Easy）

Required work and output

Use antlr4 to complete parse statements. The generated statement must follow the original data structure, and should be compatible with the old statement.

In the original syntax file  sql_parser.cup, the new syntax needs to be compatible with the syntax of the old version, using the syntax file sql_parser.cup of the old version as the reference standard.

Remove the logic of analyze functions in the statement and move the relevant logic to the new Analyzer framework. The new Analyzer is in the SQL/Analyzer directory.

If the code related to Privilege Check exists in the original analyzer, move the code related to privilege control into PrivilegeChecker.

When submitting the PR, please make sure there is unit test coverage for related changes.

Task

[ ] ShowOpenTableStmt

How to participate?

Pick an issue you are interested in, click the issue link and leave a comment under the issue to sign up.  One person can only choose one issue and the first person who picks the issue will be assigned.

After the issue is assigned, you should complete the task in 14 days. If you are unable to complete it within the specified time, the task will be withdrawn and assigned to others.

Participants are required to produce two pieces of content (forms including but not limited to mind maps, study notes, blogs, and tutorials) in the course of the activity, each of which should be at least 200 words.

Got questions? Join our  Slack channel  and find channel:  #sql-planner.

Before you start

Read  Contributing.md  carefully to understand how to submit a pull request and how to configure BE and FE development environment.

Sign the  Contributor License Agreement  before you make a pull request.

To learn more about StarRocks, please refer to  StarRocks documentation.

Pull request requirements

Create a pull request (PR) after you complete the task.

PR title format: [SR SQL Planner Summer Camp] + PR title

After submitting PR, you can comment under the pinned Issue [SR SQL Planner Summer Camp].

Comment format: "I have finished Issue #" + PR link

Please assign to me, thanks.

I have finished Issue #8531

Please check your CLA.thx

I have signed CLA , but status is still not signed yet .  What steps are missing ？

Please check your CLA.thx

done.

Check this issue, and if there are some conflicts, you should rebase it, please

Check this issue, and if there are some conflicts, you should rebase it, please

Pr has been mentioned again. Please check it again

@wanghuan2054  I am cuicui from the StarRocks community.Would you mind add my WeChat account (WeChat ID:StarRocks-1) or share your WeChat account with me? I will mail you the gift of StarRocks SQL Planner Summer Camp.


Impossible to render/view a pdf

Hello,
I'm trying to render a simple PDF however it is impossible to load it since I'm getting a libpdfium error
PdfViewer.uri(
      Uri.parse('https://www.clickdimensions.com/links/TestPDFfile.pdf'),
      controller: PdfViewerController(),
      params: PdfViewerParams(
          errorBannerBuilder: (context, error, stacktrace, ref) {
        log(error.toString());
        log(stacktrace.toString());

        return Container();
      }),
    );

PdfViewer.data(
      data,
      sourceName: 'damn',
      params: PdfViewerParams(
          errorBannerBuilder: (context, error, stacktrace, ref) {
        log(error.toString());
        log(stacktrace.toString());

        return Container();
      }),
      key: key,
    );

[log] Invalid argument(s): Failed to load dynamic library 'libpdfium.so': dlopen failed: library "libpdfium.so" not found
[log] #0      _open (dart:ffi-patch/ffi_dynamic_library_patch.dart:11:43)
#1      new DynamicLibrary.open (dart:ffi-patch/ffi_dynamic_library_patch.dart:22:12)
#2      pdfium (package:pdfrx/src/pdfium/pdfrx_pdfium.dart:31:43)
#3      pdfium (package:pdfrx/src/pdfium/pdfrx_pdfium.dart)
#4      _init.<anonymous closure> (package:pdfrx/src/pdfium/pdfrx_pdfium.dart:46:7)
#5      using (package:ffi/src/arena.dart:124:31)
#6      _init (package:pdfrx/src/pdfium/pdfrx_pdfium.dart:38:3)
#7      PdfDocumentFactoryImpl.openCustom (package:pdfrx/src/pdfium/pdfrx_pdfium.dart:150:5)
#8      PdfDocument.openCustom (package:pdfrx/src/pdf_api.dart:203:35)

Flutter version:
Flutter 3.22.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 761747bfc5 (2 weeks ago) • 2024-06-05 22:15:13 +0200
Engine • revision edd8546116
Tools • Dart 3.4.3 • DevTools 2.34.3

What platform do you run the code on?

Also I cannot run under the latest version because of rxdart >=0.26.0 <0.28.0 used by just audio (on both pdfrx ^1.0.69 and just_audio ^0.9.38, version solving failed.) but I havent seen any fix related to libpdfium in your last commits.

For rxdart version conflict, use dependency_overrides to pin rxdart to certain version such as 0.27.0.

I cannot see what's your environment. M1 Mac or such?
Could you please show me your flutter doctor -v?
And, did you run the code on actual device?

Sorry for the long delay I wasn't able to give you response before.
I upgrade your package to pdfrx: ^1.0.73
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':pdfrx:mergeDebugNativeLibs'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.MergeNativeLibsTask$MergeNativeLibsTaskWorkAction
   > 2 files found with path 'lib/arm64-v8a/libpdfium.so' from inputs:
      - /Users/_/Projects/front-flutter/build/pdfrx/intermediates/merged_jni_libs/debug/out/arm64-v8a/libpdfium.so
      - /Users/_/Projects/front-flutter/build/pdfrx/intermediates/cxx/Debug/3515273s/obj/arm64-v8a/libpdfium.so
     If you are using jniLibs and CMake IMPORTED targets, see
     https://developer.android.com/r/tools/jniLibs-vs-imported-targets

Flutter doctor
/Users/_/development/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.5 23F79 darwin-arm64, locale en-MX)
    • Flutter version 3.22.2 on channel stable at /Users/_/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (4 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/_/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.90.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (5 available)
    • Core M5 (mobile)                • ec4ad0bb                  • android-arm64  • Android 12 (API 31)
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 14.5 23F79 darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome 126.0.6478.127

[✓] Network resources
    • All expected network resources are available.

• No issues found!

For multiple libpdfium.so error, see https://github.com/espresso3389/pdfrx/issues/8#issuecomment-1898225027

Duplicate of #8


[Snyk] Security upgrade com.google.oauth-client:google-oauth-client from 1.33.1 to 1.33.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

dockstore-webservice/generated/src/main/resources/pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

649/1000  Why? Has a fix available, CVSS 8.7
Improper Verification of Cryptographic Signature SNYK-JAVA-COMGOOGLEOAUTHCLIENT-2807808
com.google.oauth-client:google-oauth-client:  1.33.1 -> 1.33.3
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Since it tries to change the generated POM this isn't very helpful. Thanks anyways Snyk


Add JTAppleCalendar inside custom UIView with xib

(Required) Version Number: 8.0.3
Description
I added a JTAppleCalendar view inside a Custom xib UIView that is intended for reuse across the app. I followed the exact steps from the guide and I'm receiving the following error:
Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'could not dequeue a view of kind: UICollectionElementKindCell with identifier dateCell - must register a nib or a class for the identifier or connect a prototype cell in a storyboard'
I followed the same steps to add a calendar view to a UIViewController and everything works fine. But then I decided to move the Calendar to a Custom UIView for reuse, and I'm receiving the error.
I did make sure I have added the dateCell identifier.
Steps To Reproduce

Add JTAppleCalendar view to a custom xib UIView;
Add custom UIView with the calendar inside a view controller;
try to run the app;

Expected Behavior
I'm not sure if there is a limitation for the JTAppleCalendar to work only in UIViewControllers and not into a xib UIView. But I would expect for it to work.
Additional Context

Do you have a base minimum sample app that show this issue?
The problem is simple but can be hard to track as it could be a code, xib, or storyboard problem.

I found out what the issue was. I first implemented the Calendar inside a ViewController with a prototype cell, and then copied the calendar to the custom UIView. But a UIView with xib does not support a prototype cell inside a collection (but it did show up without error after copying) and that's why it wasn't working.

Awesome. Glad the issue was found.
Closing this now.


Feature/272 manual step api implementation

Documentation needs to be adapted to these changes

Thanks @MaartendeKruijf for rebasing in the middle of my edits on the draft pull request

I think we need to fix a couple things trough the way that out args would be passed down to the manual command capability


7.1.0 does not compile on Solaris 11.4

Description
If you're suggesting a new feature then just a description will suffice.

[x] Does this issue still occur in the master branch? (Required if issue)

OS:
cat /etc/release
                             Oracle Solaris 11.4 X86
  Copyright (c) 1983, 2018, Oracle and/or its affiliates.  All rights reserved.
                            Assembled 16 August 2018

Download:
wget https://github.com/dylanaraps/neofetch/archive/refs/tags/7.1.0.zip
unzip 7.1.0.zip
cd neofetch-7.1.0
sudo make install
make: Fatal error in reader: Makefile, line 1: Badly formed macro assignment

The Makefile uses GNU features (var ?= val). I pushed a fix which removes this. Try it out and let me know.

Works perfect, thank you very much.


Restructure into a proper plugin with parametrisation

Right now, information about card labels and connection information is hardcoded and users are expected to change the source code. I usually stay far away from things like the Godot editor and really any other IDE or editor consuming more memory and/or having a slower startup time than my Vim, so I have zero® knowledge about how the best™ practices are in terms of integration.
I'm unable to find it right now, but I believe I've seen something like structured properties that should nicely integrate into the editor.
Nevertheless, the upstream documentation about making plugins should have some more info on this.

A plugin would require some extra work and the biggest benefit I see is the connection information not being hardcoded.
If _someone_© would like to invest the extra time to make it a plugin with maybe configurable attachments... it would maybe be a benefit.
In the end, I think that the code will be used and adapted very individually as every project has a different structure and different files that need to be attached.
Or different ways the interface is opened (via a menu, hotkey, etc.), So at the moment I don't see how this could all be parameterized in an effective and useful way.
But maybe my coding knowledge, especially about plugins is just not good enough.


Use C++14 number separators for large numbers, lowercase for hexadecimal

This makes large numbers easier to read.
Decimal numbers are split starting from 7 digits (in groups of 3). Hexadecimal numbers are split starting from 8 characters (in groups of 4, except ASCII characters which are split in groups of 2).
Hexadecimal numbers were also converted to lowercase for better readability when mixed with numbers.

For reference, this was used for converting hexadecimal numbers to lowercase:

VS Code regex for searching (case-sensitive): 0x([0-9a-FA-F']+)
Replace with: 0x\L$1
Files to exclude: thirdparty,*.po,*.pot (+ VCS ignores)

is this also possible in gdscript ? if not can it be implemented ?

@barbaros83 Yes, this is suppported since Godot 3.2: 123_456_789

I think it would be better to use scientific notation in many of these cases: https://www.cplusplus.com/reference/ios/scientific/
I think this is only for floats/doubles, but it can still be assigned to an int with implicit truncation.

Rebased against lastest master and tested on demo projects, it works successfully.

Maybe it's just me, but this looks awful, prefer the old way! :grin:
Seems a bit like a solution in search of a problem... but am happy with what the majority want to go for.

Not particularly against this, but for those like me used to low level, hex in lowercase if unreadable. Hex should always be uppercase.


Update Documentation

@jabhishek87 Please Update.

assign it to me, can you please add me as a collaborator o this repo

assign it to me, can you please add me as a collaborator o this repo

@jabhishek87 already sent you the invite, you havent accepted it, please check mail.


Radio - Ensure Consistency between Storybook Documentation and Codebase Property Names

Prerequisite
https://github.com/deven-org/B01LER-Kitchen/issues/824 is done and closed
Description / User Story
As a developer on the team,
I want to ensure consistency between the property names defined in the Storybook documentation for Radio component
So that the Radio component codebase accurately reflects the documented property names.
This user story outlines the need to maintain consistency between the documentation and the codebase regarding component property names. Each component is checked to ensure the property names in the codebase match the corresponding names in the Storybook documentation. If the discrepancies are found, they are listed in this table on the page "Radio". Column Current Code Property Name describes how is the property currently named in the code. Column Desired Code Property Name is how the property should be named. Properties marked green don't need adjustment.

Acceptance Criteria

[ ]  All Radio component's property names that differ from Storybook documentation property names (listed in the above mentioned table) should be updated
[ ] The updated property names should not introduce any unintended side effects or issues in the functionality of the components
[ ] The library builds successfully, and there are no reported issues related to the property name updates
[ ] Props Excel has been updated / comments have been resolved and props changed from red to black font color > @thrbnhrtmnn or @angelicahoyss can support here

Hey @angelicahoyss , I think you copy pasted the description from the checkbox issue, right? Checkbox was mentioned a few times in the user story in the description. I changed it now to "Radio".

Sorry @thrbnhrtmnn I thought I replaced it! Thank you :)

@thrbnhrtmnn I don't think the value prop is needed since we already use the label prop to manipulate the text

Hey @bar-tay , you can ignore the value prop for now, as it has its own ticket: https://github.com/deven-org/boiler/issues/824 .
We should discuss in a refinement session, if this change is really needed.

@bar-tay , no, not yet. But should still be able to do this ticket, just ignore the value prop for now. Last time i checked the PR it already looked good, but I was waiting for a dev to also have a look and approve before I would look again and approve


@orta => Adding badges to artwork brick

This doesn't use Palette (waiting on https://github.com/artsy/emission/pull/1152), and also has some issues with Unica. Not to mention um...not being up to design spec, looking a little off when rotating the phone and also probably...lots of other things! 😅
But, like voting, trying to PR early and often.

Fails

:no_entry_sign:

No CHANGELOG added.

:no_entry_sign:

[danger-plugin-jest] Could not read test results. Danger cannot pass or fail the build.

  Generated by :no_entry_sign: dangerJS

Ok, Unica is working!
Looks like:

I'm faffing a bit with the layout (trying to get a work that should have both badges to appear side by side), might ping someone tmrw to try to pair/clean that up. Works with just one badge look good.

Looks like this is if there are both badges set.

Re-assigning to @orta .

I love it, it's like a tiny change that propagates to a million files

@mzikherman, Palette is in emission now. Just FYI.

Fails

:no_entry_sign:

[danger-plugin-jest] Could not read test results. Danger cannot pass or fail the build.

  Generated by :no_entry_sign: dangerJS

Updated to use Sans from palette, instead of referencing Unica directly.


Evaluate/parse advanced expressions

Support exponentiation and multi-operand expressions ( e.g. 5+4-3*2/5**2 )
Remember to obey PEMDAS!
500 points

NOTE: This code has a lot of overlap with lab 06, so I would wait until you complete that lab to work on this issue

F17 ok


defunct issue

here is my sample code :
package main
import (
"fmt"
"github.com/scrapli/scrapligo/response"
"github.com/scrapli/scrapligo/driver/options"
"github.com/scrapli/scrapligo/platform"
"time"
)
func main() {
for {
_, err := ExecCmd([]string{"sho run","show ver"}, "x.x.x.x", "cml20")
if err != nil {
panic("wrong")
}
time.Sleep(10 * time.Duration(time.Second))
}
}
func ExecCmd(cmdlist []string, deviceip string, devicename string) (response.MultiResponse, error) {
p, err := platform.NewPlatform(
// cisco_iosxe refers to the included cisco iosxe platform definition
"cisco_iosxr",
deviceip,
options.WithPort(22),
options.WithAuthNoStrictKey(),
options.WithTimeoutOps(120time.Second),
options.WithAuthUsername("admin"),
options.WithAuthPassword("admin"),
options.WithTermWidth(256),
options.WithTermHeight(0),
)
if err != nil {
fmt.Printf("failed to create platform for %s(%s); error: %+v\n", devicename, deviceip, err)
return nil, err
}
d, err := p.GetNetworkDriver()
if err != nil {
fmt.Printf("failed to fetch network driver for %s(%s) ; error: %+v\n", devicename, deviceip, err)
return nil, err
}
err = d.Open()
if err != nil {
fmt.Printf("failed to open driver %s(%s); error: %+v\n", devicename, deviceip, err)
return nil, err
}
defer d.Close()
mr, err := d.SendCommands(cmdlist, options.WithTimeoutOps(120*time.Second))
return mr, err
}

I found lots of defunct processes,
Every 1.0s: ps -ef | grep ssh | grep -v grep | grep -v sshd                                                                                Mon Aug  8 04:40:00 2022
root	   344 32616  0 04:39 ?        00:00:00 [ssh]
root	   428 32616  0 04:39 ?        00:00:00 [ssh]
root	   516 32616  0 04:39 ?        00:00:00 [ssh]
root	   601 32616  0 04:39 ?        00:00:00 [ssh]
root     32622 32616  0 04:38 ?        00:00:00 [ssh]
root     32692 32616  0 04:38 ?        00:00:00 [ssh]
root     32740 32616  0 04:39 ?        00:00:00 [ssh]
How can we avoid it?
thanks.

will take a bit closer look later, but my initial guess/thought is that because we use ptyprocess those child processes are staying alive until the parent process (the main program) exits. we of course call close the file descriptor we get back from ptyprocess but maybe there is an additional kill method or something we can use as well. let us know if you have a solution for this as well!

right now, I have no solution yet, I found the ssh defunct will consume all memory finally in my lab.

Whether it is caused by the tty colsed before pty,
func StartWithAttrs(c *exec.Cmd, sz *Winsize, attrs *syscall.SysProcAttr) (*os.File, error) {
pty, tty, err := Open()
if err != nil {
	return nil, err
}
defer func() { _ = tty.Close() }() // Best effort.
if sz != nil {
	if err := Setsize(pty, sz); err != nil {
		_ = pty.Close() // Best effort.
		return nil, err
	}
}
if c.Stdout == nil {
	c.Stdout = tty
}
if c.Stderr == nil {
	c.Stderr = tty
}
if c.Stdin == nil {
	c.Stdin = tty
}
c.SysProcAttr = attrs
if err := c.Start(); err != nil {
	_ = pty.Close() // Best effort.
	return nil, err
}
return pty, err

}

Whether it is caused by the tty colsed before pty not sure I am 100% following here, but I think you're maybe saying similar things to this thread?
I dont think there is anything else we can really be doing in scrapligo at the moment for this for this. The processes that are left, however, are just zombie processes that will get reaped when the main program exits. I think that the scenario demonstrated in the reproduction example here is very unlikely to be a normal thing (you could for example just keep a single session alive, or you could stop the program between sleeps and re-run it via cron or w/e) that I'm inclined to close this just due to lack of anything we can likely do and the kind of non-standard-ness of it.
One more thin -- you could also just use the "standard" transport that does not do any of this pty bits and is instead entirely in go -- no zombie processes that way! So perhaps that is a viable option for your situation?

Hey there, going to close this out for now. If standard transport doesn't work for you and you can come up with a fix in either pty or here, feel free to reopen!


Correction for raw affiliation Centre Atlantique de Philosophie

Correction needed for raw affiliation Centre Atlantique de Philosophie
raw_affiliation_name: Centre Atlantique de Philosophie
new_rors: 059ynac98
previous_rors:
works_examples: W3009497135;W4287920346;W4388274739;W3022254640;W3001345342;W3014671606;W4381545817;W4286796578;W3120953924;W4288271466
contact: 92a7133090f4a73ab40516c34df8f110:d7b4c6776452466ff59001969fd18e @ univ-nantes.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


fix(nexus): fixing assert failure when removing non-existing child

Signed-off-by: Dmitry Savitskiy<EMAIL_ADDRESS>

bors merge


[LiveComponent] Password fields are not being send within form on model change

I created a component using ComponentWithFormTrait. In my form type there is an input type="password" field. If I modify value in that field directly everything works fine. Take a look at plainPassword attribute.

However when I change another field the plainPassword attribute is empty in request.

So I end up with validation error that password can not be empty. If I change that field from type="password" to type="text" everything works also fine.

https://symfony.com/bundles/ux-live-component/current/index.html#form-rendering-problems -> 'always_empty' => false

Hi!
Are you saying the always_empty => false fixed your issue?

Yes. It wasn't an obvious case for me as I use data-live-ignore attribute, so the field was filled all the time on my screen, but internally it was empty.

Awesome - happy you found that! I wish there were some more automatic way for us to "fix" that, but probably not a good idea :).
Btw, what's your use-case for using data-live-ignore here? I always like to find out.
Cheers!

Awesome - happy you found that! I wish there were some more automatic way for us to "fix" that, but probably not a good idea :).

This is something you just need to know / remember that it works this way. For my projects I "fixed" it by extending core PasswordType with my UxPasswordType, which overrides allow_empty value.

Btw, what's your use-case for using data-live-ignore here? I always like to find out.

I use it to solve that case
User entered data in field A and pressed tab to move to field B.
Moving to field B triggered an ajax request (onChange event).
In the meantime user started to type something in field B.
Then the request triggered in Field A has ended. As a result LiveComponent re-rerendered itself and emptied field B (because field B was empty in the time of making that request).


This commit moves https://github.com/non/big-electric-cat to frameles…

…s under the frameless-cats project
Other changes:

Fixes inner pairwise monoid test by generating only non-empty Map's
Updates Cats version used in big-electric-cat to 0.4.1

review by @non

(Disregard Travis build failure, we're having issues with Travis + Spark atm..)

Look good! :+1:
(Sorry I didn't comment sooner, I missed this when you opened it.)

:+1:


feat: allow linking identities when using in-app + smart wallets

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR allows linking accounts using in-app and smart wallets.
Detailed summary

Updated logic for linking accounts in in-app wallet UI
Replaced useActiveWallet with useAdminWallet for managing profiles and wallets in UI screens

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#4737  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on  Graphite


Cannot add_subdirectory on Linux

Hello guys,
when I try to add the newest release to my cmake project using add_subdirectory, it works on Windows. However if I try to build it on Linux (Manjaro), compilation fails because it tries to include windows.h from internals.h .
A CMakeLists.txt with nothing else than just "add_subdirectory(dep/glfw)" produces the same error on Linux. If I revert back to the previous major release, it works.
Any ideas?

What is the error CMake tells you?

The error occurs when I compile with "make".

It says:
"In Datei, eingebunden von /home/CG/dep/glfw/src/internal.h:186,
von /home/CG/dep/glfw/src/context.c:30:
/home/CG/dep/glfw/src/win32_platform.h:68:10: schwerwiegender Fehler: windows.h: Datei oder Verzeichnis nicht gefunden
68 | #include <windows.h>
|          ^~~~~~~~~~~
Kompilierung beendet.
"
In english: critical error: windows.h: File or Directory not found. Compiling stopped
or something like that.

How are you configuring your project? CMake should be able to detect that you are on a linux based system and from a project level exclude any windows specific files.
https://github.com/glfw/glfw/blob/master/CMakeLists.txt#L134
https://github.com/glfw/glfw/blob/master/src/CMakeLists.txt#L19
Unless you're overspecifying configure flags or cross compiling, for the most part CMake will detect that you are on linux and set UNIX which should conditionally include the correct source files.

Have you tried reproducing the issue? I couldn't fix it, so I just use 3.2.1 now.

Off of latest master using:
OS: Pop!_OS 19.10 x86_64
Kernel: 5.3.0-7629-generic
cmake version 3.15.1

I can't reproduce your issue. I am configuring my project, (which performs an add_subdirectory() as you have described) by:
mkdir build && cd build
cmake ..

Any chance you can dump your CMakeFiles/CMakeOutput.log within your build directory?


Highlight importance of backups

Internal ref:
https://github.com/arangodb/planning/issues/3042
@sleto-it Made the last part a red hint box. We could also add another (maybe just a yellow one?) about possible data loss if you want.
http://jenkins01.arangodb.biz:8080/job/arangodb-documentation/113/

Preview: http://web01.arangodb.biz/documentation/backup-improvements2/Manual/BackupRestore/


unique_id_from_tool has disappeared from the findings search filter

Hello Team,
After the upgrade form 1.15.1 to 2.0.3 is not possible anymore to filter records on "unique_id_from_tool". Is this by design or do we need another fix ?
Best,
Sal

I think this has dissapeared in the refactoring of the search filters. If there's a valid usecase to filter by these fields, we can add it back in.

A valid use case could be integration with other systems ? A valid use case could be the search for the vulnerability using a code present in the report of the tool used for the analysis ?


TypeScript crashes when assigning property to function

TypeScript Version:
3.4.0-dev.20190131, but I can repro back to at least 3.2.1.

Search Terms:
crash function property assignment
Debug Failure. Diagnostic emitted without context
Code
function A() {
  return null
}

A.B = 'foo'

function C() {
  return null
}

C.D = A

Expected behavior:
When running tsc -d, TypeScript should parse this file.
Actual behavior:
TypeScript crashes with a cryptic error message:
Debug Failure. Diagnostic emitted without context

Note that this only happens when the -d flag is specified.
Playground Link:
I can't repro in the playground because the playground doesn't seem to have an option to generate declarations.
Related Issues:
No, there are 0 issues containing the error message.

ValueModule refers to a namespace that will have a corresponding runtime value. For example:
namespace X {
  export type Y = { n: number; }
}

The X symbol will not have ValueModule set because there's no codegen for a type-only namespace. But here, it would:
namespace X {
  export const Z = 10;
}

In general in the codebase, in the absence of other evidence from context, you should assume "module" refers to the namespace construct and "external module" refers to an ES6 module.

Namespace-like objects can also be synthesized via examples like the OP.
Probably the bug here is that the declaration emit codepath wasn't hardened to do the right thing when presented with "namespaces" like the one above.

I've encountered what appears to be a variation of this bug in TS 3.3.4000 , that seems to happen with tsc --watch or tsc -d, and a particular relationship of types spread across two files.
I suspect it's the same underlying bug, because it throws that same "Debug Failure. Diagnostic emitted without context" message, and one of the necessary elements for reproduction, is assigning a property to a function.
Here's a reproducible example: https://github.com/agwells/ts-loader/tree/master/examples/fork-ts-checker-webpack-plugin
// File 1: myfunction.ts

interface NotExportedInterface {}

export function exportedFunction(): NotExportedInterface {
  return {};
}

// File2: mycomponent.ts
import { exportedFunction } from './myfunction';

export function MyComponent() {
  return null;
}
MyComponent.defaultProps = {
  // Comment out this line, and it works.
  myProp: exportedFunction(),
};

And the result:
[7:22:15 PM] Starting compilation in watch mode...

/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:71495
                throw e;
                ^

Error: Debug Failure. Diagnostic emitted without context
    at throwDiagnostic (/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:65136:61)
    at handleSymbolAccessibilityError (/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:65202:33)
    at Object.trackSymbol (/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:65221:13)
    at lookupSymbolChain (/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:28411:33)
    at symbolToTypeNode (/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:28544:29)
    at typeToTypeNodeHelper (/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:27872:27)
    at addPropertyToElementList (/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:28239:59)
    at createTypeNodesFromResolvedType (/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:28190:25)
    at createTypeNodeFromObjectType (/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:28030:35)
    at createAnonymousTypeNode (/code/reference/ts-loader/examples/fork-ts-checker-webpack-plugin/node_modules/typescript/lib/tsc.js:27984:42)

Thanks for your investigations @agwells! Could you keep your reproducible repo around please? It'll make the Typescript team a good place to test that the eventual fix works.
Thanks again for digging into this; it's super appreciated! ❤

Could you keep your reproducible repo around please?

Will do! And thanks for your help in investigating it. I wouldn't have had the time to learn the right tests to perform by myself.

Tested both of the repros here, and they're both already fixed with<EMAIL_ADDRESS>Thanks for the detailed reports! 💯


[Feature Request]: Add dark mode for Rate us page

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
The website's Rate us page doesn't support the dark mode.
I would like to add the dark mode toggle button and add the dark theme for the Rate us page
Use Case
It would provide good visibility and the users can switch between different themes according to their convenience
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSOC'24 contributor
[X] I have starred the repository

@itsekta @apu52 please assign me this issue

@itsekta @apu52 please assign this issue to me

@Vaibhav-kesarwani I have authored this issue, please search for some other issues


Change Error message namespace + policy names

Description: Change error message "the combined length of the policy namespace and name . cannot exceed 63 characters" to the combined length of the policy namespace and name . cannot exceed 62 characters
Ref: https://issues.redhat.com/browse/ACM-6838

/cc @mprahl  @dhaiducek @gparvin  @fxiang1  @Randy424  @dockerymick  @KevinFCormier

/cc @jtomasek

@yiraeChristineKim could you please run prettier to fix the CI failure?


All tests run from test runner fail due to assembly resolve error.

The test fails with the output: "The active Test Run was aborted because the execution process exited unexpectedly. To investigate further, enable local crash dumps either at the machine level or for process te.processhost.managed.exe. Go to more details: http://go.microsoft.com/fwlink/?linkid=232477"
The fusion logs show errors loading the test assembly, but all attempts are from the test runner directory and the GAC. It should be looking for the assembly in the test project output directory.

Found this on NUnits Issue list: "NUnit agent cannot resolve test dependency assemblies when mixed mode initialization runs in the default AppDomain"
https://github.com/nunit/nunit/issues/681
Also see: http://stackoverflow.com/questions/17993010/dlls-loaded-from-wrong-appplicationbase-when-trying-to-load-mixed-c-sharp-and-c/18499944#18499944
Looks like there is a fix in the works.

Running the tests in a console runner with the option -domain=None works.


Moving crypter classes to pinot-spi

#4885

Codecov Report

Merging #4897 into master will decrease coverage by 6.73%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4897      +/-   ##
============================================
- Coverage     56.62%   49.88%   -6.74%
  Complexity       53       53
============================================
  Files          1175     1175
  Lines         62792    62792
  Branches       9208     9208
============================================
- Hits          35554    31322    -4232
- Misses        24602    29041    +4439
+ Partials       2636     2429     -207

Impacted Files
Coverage Δ
Complexity Δ

...rg/apache/pinot/spi/crypt/PinotCrypterFactory.java
75% <ø> (ø)
0 <0> (?)

...in/java/org/apache/pinot/minion/MinionStarter.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...a/org/apache/pinot/spi/crypt/NoOpPinotCrypter.java
40% <ø> (ø)
0 <0> (?)

...org/apache/pinot/controller/ControllerStarter.java
68.27% <ø> (-1.73%)
0 <0> (ø)

.../server/starter/helix/SegmentFetcherAndLoader.java
0% <ø> (-64.77%)
0 <0> (ø)

...ces/PinotSegmentUploadDownloadRestletResource.java
5.38% <ø> (-55.09%)
0 <0> (ø)

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0% <0%> (-100%)
0% <0%> (ø)

...g/apache/pinot/sql/parsers/CalciteSqlCompiler.java
0% <0%> (-100%)
0% <0%> (ø)

...starter/helix/DefaultHelixStarterServerConfig.java
0% <0%> (-96.16%)
0% <0%> (ø)

...re/data/manager/config/TableDataManagerConfig.java
0% <0%> (-94.45%)
0% <0%> (ø)

... and 253 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc87b48...0ee2840. Read the comment docs.


Upgrade github.com/lucas-clemente/quic-go

Hello,
Can you edit the PR description to explain the reason behind this upgrade, thank you.

Done.


added disjoint statement

Great start!
in this case, this seems to be a typo rather than something asserted by design:
id: GO:0140516
name: mitotic nuclear pore complex disassembly
namespace: biological_process
def: "The mitotic cell cycle process in which the controlled breakdown of the nuclear pores occurs during open or closed mitosis." [PMID:32848252]
synonym: "nuclear pore complex disassembly during mitosis" EXACT []
is_a: GO:0007077 ! mitotic nuclear membrane disassembly
intersection_of: GO:0022607 ! cellular component assembly
intersection_of: part_of GO:0000278 ! mitotic cell cycle
intersection_of: results_in_disassembly_of GO:0005643 ! nuclear pore
relationship: part_of GO:0006998 ! nuclear envelope organization
property_value: term_tracker_item https://github.com/geneontology/go-ontology/issues/19947 xsd:anyURI
Note: this dodgy logical def will also show up in a query for all equiv axioms that don't match a pattern, so it's nice to know we are growing robust mechanisms for catching this sort of thing