There should be an API command to execute the color provider like we have for code complete and others

To make things consistent we should offer a API command for color providers.

There are tests for it, I suggest to mark it as verified.


Brick on Vevo music

When playing a copyrighted song (usually Vevo), the module doesn't play any music and when calling the "nowPlaying" function, it shows that it's the whole time stuck at 0:00.
Sometimes those songs work, sometimes they don't, idk.

I'm not sure if that's even fixable, but I'm just reporting it.

I will look into it.

Live on https://www.npmjs.com/package/discord-music-player/v/6.3.0.


Change Travis-CI badge from .org to .com

Pull Request
Thank you for contributing to @dvcs/gitignore and https://www.gitignore.io.
New or update
Select the appropriate check box for this pull request. This helps when merging to ensure there are no conflicts with other templates or misunderstandings of how thee template list works.
New

[ ] Template - New .gitignore template
[ ] Composition - Template made from smaller templates
[ ] Inheritance - Template similar to an existing template
[ ] Patch - Template extending functionality of existing template

Update

[ ] Template - Update existing .gitignore template

Details
Travis-CI is migrating their domain from .org to .com, this update fixes the URL in the README.md

@thatrobotdev thanks!


Question about logging each file separatly and PRE_EXECUTE event

Hi,
I am trying to import multiple files in one table, using the loop:true option for loading files in the temporary table first.
However, I would like to still have each file be logged independently, for example to know which file had an issue if there is an exception. Is this possible with the VALIDATE_SOURCE event ?
Also, what is the intended purpose of the PRE_EXECUTE event ? Could you give some exemples about what "Additional functionality" should be hooked to the event ?
Thanks,
Fabien.

Hello,
About VALIDATE_SOURCE event: it is issued before loading each file so you could use it to validate each file before load (meaning you have to iterate over the file yourself). After data is loaded in the temporary table, you can use the file_line_no column to know which file the line comes from.
About PRE_EXECUTE event: you can add anything you need to run early in the import process. Example usage can be logging the import start or downloading files from an external source to import them.


499 in Firefox resoure viewer

Resource viewer shows 499 error in latest firefox on ubuntu.
SyntaxError: "JSON.parse: unexpected character at line 1 column 1 of the JSON data"
    onpopstate URLParamsProvider.js:147
    onpopstate URLParamsProvider.js:135
    checkForURLParamsChange URLParamsProvider.js:113
    componentDidUpdate URLParamsProvider.js:162
    zl React
    unstable_runWithPriority scheduler.production.min.js:338
    React 4
    unstable_runWithPriority scheduler.production.min.js:338
    React 5
backend.js:6:2315
    r backend.js:6
    onpopstate URLParamsProvider.js:150
    onpopstate URLParamsProvider.js:135
    checkForURLParamsChange URLParamsProvider.js:113
    componentDidUpdate URLParamsProvider.js:162
    zl React
    unstable_runWithPriority scheduler.production.min.js:338
    React 4
    unstable_runWithPriority scheduler.production.min.js:338
    React 5

So that error above had nothing to do with the error causing the 499... Turns out that link didn't log to console, and I was chasing an unimportant issue.
The actual error has to do with the URL constructor in Firefox:
new URL("chrome:thesession")
// TypeError: chrome:thesession is not a valid URL.
new URL("about:config")
// URL {..valid}

This chrome:theSession string comes from rdflib. Maybe we need to change that.


how to bind a click event on iCheck checkbox?

I can't bind a click event on iCheck checkbox element ? Is there any idea ?

IMO, @puikinsh should get rid of iCheck script as it is not updated and supported for a long time and switch to pure css checkbox styling.
iCheck instead of standard events implements it's own which make maintaining js cumbersome if you deal with 3rd-party scrips which rely on 'normal' checkbox behavior.
It is not changed when checkboxes checked property was changed programmatically.


Update _index.md

rework of the german translation based on the english version
fixes #17125

/assign @rlenferink

Hi @bscheller-iso, thanks for submitting this PR. Can you please sign the CNCF CLA? After that I’ll have a look at your PR.
Instructions on how to submit the CLA are described above ;)

Hello, I signed the CNCF CLA.

/check-cla

@bscheller-iso it looks like the CLA is not picked up then. Are you sure the e-mail for the commit is the same as the one used to sign the CLA? If so, the CLA guide has the following procedure:

7. My pull request still doesn't pass!

If you haven't yet, post a comment ("I signed it") to the PR—this is needed for the system to recheck your contribution authorization.

Each commit in the pull request needs to pass. If you have commits that didn't attribute to a Github username, or to a different user that hasn't signed the CLA, that will fail that commit and all subsequent commits.

If that does not help, please submit a support request.

I signed it

/check-cla

/check-cla

/lgtm
@bene2k1 I’ll leave approval to you

/approve


New version: JetBrains.Writerside.EAP version 241.15989.11

Created by 🥟 Dumplings in workflow run #4632.
Logs
Updated: 233.14938 → 241.15989.11
Submitting WinGet manifests

Microsoft Reviewers: Open in CodeFlow

Hi @SpecterShell,

This PR's version number 241.15989.11 has 3 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 233.14938, which has 2 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 877)


bump python version to 0.0.3a1

Coverage remained the same at 72.402% when pulling 501745b8d1f8f03a6befb37935f52dea2663298f on akmorrow13:bump_python into 0ffa2af388a0142a462fd8adb1bf56268f9e6634 on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/855/
Test PASSed.


[backport] Remove cupy.cupy

Backport of #5121

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 75d6bc3b320be7c9361806472be4a7dac6cc1cbe, target branch v9) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit 75d6bc3b320be7c9361806472be4a7dac6cc1cbe, target branch v9) succeeded!


Incompatibility with Botania's Endoflame

The endoflame eats a stack of coal instead of just one when stack sizes above 64 are present.
Steps to reproduce the behavior:

Place down an Endoflame
Throw two stacks of a flammable item on the ground next to it
It will consume a stack of items instead of just 1

Expected behavior
I expected the flower to reduce the total stack size by 1.

MC version: [1.19.2]
Mod version: [1.19.2-1.2-51]
Loader: Fabric

Video:
https://github.com/frank89722/Staaaaaaaaaaaack/assets/88632676/423fe490-b16c-49cf-a16e-9127bcf39d86
Modlist:

Botania
Fabric API
Patchouli
Staaaaaaaaaaaack
Trinkets

Thank you for the bug report but there is no easy(legit) fix on my end so could you also open an issue in their issue tracker?
Botania tries to sync the item entity by setting the item to EMPTY and then setting it back to the correct value, which I believe is an unnecessary move since they can achieve the same behavior by just setting it to a new copy of the item stack, and setting an item entity to EMPTY will trigger the refill process in Staaaaaaaaaaaack which cause this to happen.

https://github.com/VazkiiMods/Botania/pull/4431

Forget all I said above, I'm just suck at coding
Should be fixed in v1.4
Thanks for the report again!


corpus.wordnet.morphy('lest') = 'l'

Hello, I hope I'm reporting this in the proper place.
In case the title is clear enough, here are the steps to reproduce:
>>> from nltk.corpus import wordnet as wn
>>> wn.morphy('lest')
'l'

Thanks

Typically non-content words should not go through wn.morphy or nltk.stem.WordNetLemmatizer.lemmatize. These function should only handle function words, more specifically words in categories that exists in wordnet, i.e. nouns, verbs, adjective, satellite-adjectives and adverbs.
Since lest is a conjunction, putting it through morphy is not should be avoided. But in this case the stopwords doesn't not contain lest:
>>> from nltk.corpus import wordnet as wn
>>> from nltk.corpus import stopwords
>>> stoplist = stopwords.words('english')
>>> sent = "he spent whole days in his room, wearing headphones lest he disturb anyone"
>>> tagged_sent = pos_tag(word_tokenize(sent))
>>> tagged_sent
[('he', 'PRP'), ('spent', 'VBD'), ('whole', 'JJ'), ('days', 'NNS'), ('in', 'IN'), ('his', 'PRP$'), ('room', 'NN'), (',', ','), ('wearing', 'VBG'), ('headphones', 'NNS'), ('lest', 'JJS'), ('he', 'PRP'), ('disturb', 'VBZ'), ('anyone', 'NN')]
>>> def lemmatize_sentence(tagged_sent):
...     for word, tag in tagged_sent:
...             wntag = penn2wn(tag)
...             if word in stoplist:
...                     yield word
...             elif penn2wn(tag) in ['n', 'v', 'a', 'r']:
...                     yield wnl.lemmatize(word, pos=wntag)
...             else:
...                     yield word
...
>>>
>>> list(lemmatize_sentence(tagged_sent))
['he', u'spend', 'whole', u'day', 'in', 'his', 'room', ',', u'wear', u'headphone', u'l', 'he', 'disturb', 'anyone']

So you might have to do something like this:
>>> stoplist.append('lest')
>>> list(lemmatize_sentence(tagged_sent))
['he', 'he', u'spend', 'whole', u'day', 'in', 'in', 'his', 'his', 'room', ',', u'wear', u'headphone', 'lest', u'l', 'he', 'he', 'disturb', 'anyone']


Messaging: Subscribe to default topics

The app should subscribe to the emergency topic by default.
The following documentation should come in handy: https://rnfirebase.io/docs/v4.3.x/messaging/topics

Verified and closed.


Simplify the suggested log4j.properties

Also include the thermometer-specific configuration, copied from the log4j.properties file in the thermometer jar (which is what we are overriding here in order to get our own logging to output).

👍


Inline log creation to remove temporary Python objects into the logger.

Closes #185

Improves the Logger(level=DEBUG).debug() benchmark by an additional 1x


Read worker information in load_fnc and request_fnc

For some use cases, we want to determine the workload based on the activate jobs in the worker. For now the only way to do this is to modify the run_worker in cli to create a Worker first then manually replace the opts.load_fnc and opts.request_fnc.
Maybe adding a worker arg to these two methods is not a good idea, I wonder if we can make cli.run_app accept a "before_run_hook" that takes worker as input to modify these methods in that hook.

This is not needed after https://github.com/livekit/agents/pull/1046


Extend EnvoyGateway Control Plane

Consider defining a WASM ABI spec for Control Plane APIGateways similar to proxy-wasm so the components defined in https://github.com/envoyproxy/gateway/pull/16 can be extended by users to define new control plane APIGateway functionality . wazero might be an apt runtime to use.

cc @AliceProxy

xref: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/config

/assign :slightly_smiling_face:

Do we have a more detailed proposal or design doc for it?
cc @AliceProxy  @danehans

@AliceProxy has been assigned so I'll let her respond.


Add dfdlx:runtimeProperties extension

New dfdlx:runtimeProperties is a space-separated list of key=value
pairs. The pairs are converted to a Map and made available on the
ElementRuntimeData for which the properties is specified. This Map can
be accessed by custom implementations of InfosetInputters and
InfosetOutputters to allow modifications and custom behaviors to the
text of simple types.
The property is only valid on dfdl:element and xs:element tags for
simple types.
Also changed "Object" to "ObjectKind" to make it more clear that it
describes the dfdlx:objectKind extension property.
DAFFODIL-2537

I've pushed updates that I think should address the comments, this includes new test InfosetInputters using the Scala/Java API to ensure coverage. It also shows some issues. For example, the Java API needs to access some Scala objects, which is pretty awkward.

Is it worth adding an implementation and a test showing the motivating example of a custom XML Infoset Inputter and Outputter for embedded XML strings in binary data?

I don't really want to add such an implementation, just because I suspect it's going to be a decent amount of work, and a decent amount of testing. I think it's basically a implementation of one of the InfosetInputters/Outputters with quite a bit of extra complicated logic. If we do want to include that in the repo I think that's worth done in another PR. Once I add some documentation (next week) I'll add this as a motivating example and probably include some pseuocode about how this might be implemented.

A writeup of these feature, including a potential implementation using Scala XML Nodes for simplicity and brevity is added here:
https://cwiki.apache.org/confluence/display/DAFFODIL/Proposal%3A+Runtime+Properties


Tracking anti-reset windup for multicopter velocity controller

Replaces #10636
The tracking anti-reset windup is widely used in industry as it is simple to implement and give good performances. It gives similar performance to the conditional integration method during step responses and reduces the delay in some special cases (e.g.:ramp-saturation-negative step).
One other main advantage is that it simplifies the code, no if statement required!
The ARW gain is computed automatically as it is shown in this paper that a good choice of this time constant is Tt = 0.5*Ti. Since in our case, Ki = Kp/Ti and Karw = 1/(Tt*Ki) (we correct the error, before the integral gain, unlike in the schematic below), the ARW gain becomes Karw = 2 / Kp.

(Image from Anti-Reset Windup for PID Controllers, L. Rundqwist, 1990, )
@Stifael I left the Z integrator with the current conditional integration method as in my opinion, it is good that the integral stays loaded with the required force to compensate gravity, even during saturation.
Log from a survey, before this PR:
https://logs.px4.io/plot_app?log=22a4db3b-163f-4175-8be9-c762e550e2a5
Log from the same survey, with this PR:
https://logs.px4.io/plot_app?log=35f24468-a378-4058-8da5-7da39aee79bd

oo

Note that this has already been flown by the test team in the previous PR.

rebased on master

@RomanBapst Can you review please?


Fix 2d editor selection persisting after application loses focus.

https://github.com/godotengine/godot/assets/2223172/91163c50-0a83-4c58-95b5-ec2d81cdfaca
Originally posted by @KoBeWi in https://github.com/godotengine/godot/issues/90090#issuecomment-2100559464

Thanks! And congrats for your first merged Godot contribution :tada:


Preserve active species and entity in entity viewer

Type

[ ] Bug fix
[ ] New feature
[x] Improvement to existing feature

Related JIRA Issue(s)
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-902
Description

Entity viewer activeGenomeId and activeObjectId are now preserved in the local storage so the if we close the tab and go back, it will take us to the view were on previously

Deployment URL
http://ev-storage.review.ensembl.org
Views affected
Entity viewer
Other effects

[ ] I have checked any requirements for Google Analytics
[ ] I have created any required tests
[ ] The PR has as its final commit a WASM/JS update commit if any Rust files were updated.

Looks good, but see my last two comments about ensObjects. I suppose we can tackle them in a separate PR.

Thanks. I have created a separate ticket to address those two comments.
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-928

Looks good, but see my last two comments about ensObjects. I suppose we can tackle them in a separate PR.

Thanks. I have created a separate ticket to address those two comments.
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-928


How to evaluate intra_f1 and inter_f1?

in evaluation.py, intra_inter = pickle.load(open('/home/huangqz/repos/binary_document_re/dataset/DocRED_baseline_metadata/dev_intra_inter.pk', 'rb')), how to get file "dev_intra_inter.pk"?

This file has been uploaded.


Update TSI with new non-blocking TSI interfaces.

This diff includes

update TSI with new non-blocking TSI interfaces.
create a tsi_adapter_handshaker, that takes a TSI handshaker implementation of old interface and converts an implementation of new interface.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

jenkins: this is ok to test

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

No significant performance differences

No significant performance differences

This looks pretty good.  Most of my comments are minor.  Please let me know if you have any questions.

Reviewed 9 of 9 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 19 unresolved discussions, some commit checks failed.

Makefile, line 2990 at r2 (raw file):

    src/core/tsi/ssl_transport_security.c \
    src/core/tsi/transport_security.c \
    src/core/tsi/transport_security_adapter.c \

Our Makefile is generated from a template, so you can't modify it directly. Instead, please modify the BUILD file and the build.yaml file and then run ./tools/buildgen/generate_projects.sh.

memory_usage.csv, line 1 at r2 (raw file):

5678.136000,512736,4195801,5849.316778,204605,,

What is this file?  I assume this was added by mistake?

src/core/tsi/transport_security.c, line 185 at r2 (raw file):

                                                protector);
  if (result == TSI_OK) {
    self->frame_protector_created = 1;

s/1/true/

src/core/tsi/transport_security.c, line 196 at r2 (raw file):

    tsi_handshaker_on_next_done_cb cb, void *user_data) {
  if (self == NULL) return TSI_INVALID_ARGUMENT;
  if (self->handshaker_result_created) return TSI_FAILED_PRECONDITION;

When does handshaker_result_created get set?

src/core/tsi/transport_security.h, line 94 at r2 (raw file):

int frame_protector_created;
int handshaker_result_created;

These can probably be bool.

src/core/tsi/transport_security_adapter.c, line 48 at r2 (raw file):

typedef struct {
  tsi_handshaker_result base;
  tsi_handshaker *handshaker;

Doesn't this implementation require that the underlying handshaker continue to exist until after the tsi_handshaker_result is destroyed?  How do we guarantee that?  Perhaps we need to refcount the handshaker object?  Or can we just assume that the few applications that will use this adapter will do the right thing until the adapter goes away?

src/core/tsi/transport_security_adapter.c, line 77 at r2 (raw file):

static void tsi_adapter_result_destroy(tsi_handshaker_result *self) {
  tsi_adapter_handshaker_result *impl = (tsi_adapter_handshaker_result *)self;
  if (impl->unused_bytes != NULL) {

No need to check this.  If you call gpr_free(NULL), it will be a no-op.

src/core/tsi/transport_security_adapter.c, line 88 at r2 (raw file):

};

tsi_result tsi_adapter_create_handshaker_result(

This can be declared static.

src/core/tsi/transport_security_adapter.c, line 117 at r2 (raw file):

} tsi_adapter_handshaker;

tsi_result tsi_adapter_get_bytes_to_send_to_peer(tsi_handshaker *self,

static

src/core/tsi/transport_security_adapter.c, line 124 at r2 (raw file):

}

tsi_result tsi_adapter_process_bytes_from_peer(tsi_handshaker *self,

static

src/core/tsi/transport_security_adapter.c, line 131 at r2 (raw file):

}

tsi_result tsi_adapter_get_result(tsi_handshaker *self) {

static

src/core/tsi/transport_security_adapter.c, line 135 at r2 (raw file):

}

tsi_result tsi_adapter_extract_peer(tsi_handshaker *self, tsi_peer *peer) {

static

src/core/tsi/transport_security_adapter.c, line 140 at r2 (raw file):

}

tsi_result tsi_adapter_create_frame_protector(tsi_handshaker *self,

static

src/core/tsi/transport_security_adapter.c, line 148 at r2 (raw file):

}

void tsi_adapter_destroy(tsi_handshaker *self) {

static

src/core/tsi/transport_security_adapter.c, line 155 at r2 (raw file):

}

tsi_result tsi_adapter_next(

static

src/core/tsi/transport_security_interface.h, line 308 at r2 (raw file):

A typical usage of the new TSI would be as follows, supporting both
synchronous and asynchrnous TSI handshaker implementations:

The term "new" will quickly grow out of date here. I suggest just saying "A typical usage supporting both synchronous and asynchronous TSI handshaker implementations would be:".

src/core/tsi/transport_security_interface.h, line 330 at r2 (raw file):

   // tsi_handshaker_next finishes. It is passed to tsi_handshaker_next as
   // the callback function.
   void on_handshake_next_done_wrapper(

If this example code is not intended to be gRPC-specific, then there's probably no need for a wrapper function here. Instead, I think you can just use on_handshake_next_done() directly.

src/core/tsi/transport_security_interface.h, line 389 at r2 (raw file):

       tsi_peer peer;
       status = tsi_handshaker_result_extract_peer(result, &peer);
       if (status != TSI_OK) return status;

This function returns void.

src/core/tsi/transport_security_interface.h, line 487 at r2 (raw file):

typedef void (*tsi_handshaker_on_next_done_cb)(
    tsi_result status, void *user_data, const unsigned char *bytes_to_send,
    size_t bytes_to_send_size, tsi_handshaker_result *handshaker_result);

As mentioned via email, I think handshaker_result can be const.

Comments from Reviewable

Performance differences noted:
Benchmark                                                   allocs_per_iteration    atm_add_per_iteration    atm_cas_per_iteration      cpu_time  locks_per_iteration      real_time  writes_per_iteration
----------------------------------------------------------  ----------------------  -----------------------  -----------------------  ----------  ---------------------  -----------  ----------------------
BM_ErrorGetStatus<ErrorCancelled>                                                                                +30.50                              +30.50
BM_ErrorStringOnNewError<ErrorWithGrpcStatus>                                                                                +2648.50                            +2648.50
BM_HasClearGrpcStatus<ErrorWithHttpError>                                                                                +6.00                               +6.00
BM_IsolatedFilter<HttpServerFilter, NoOp>                                                                                +10.00                              +10.00
BM_IsolatedFilter<ServerDeadlineFilter, SendEmptyMetadata>                                                                                +22.00                              +22.00
BM_Zalloc/5k                                                                                +39.00                              +39.00

Performance differences noted:
Benchmark                              allocs_per_iteration    atm_add_per_iteration    atm_cas_per_iteration      cpu_time  locks_per_iteration      real_time  writes_per_iteration
-------------------------------------  ----------------------  -----------------------  -----------------------  ----------  ---------------------  -----------  ----------------------
BM_ErrorGetStatus<SimpleError>                                                                                +26.00                              +26.00
BM_ErrorStringOnNewError<SimpleError>                                                                               +524.00                             +524.00

Performance differences noted:
Benchmark                                                            allocs_per_iteration    atm_add_per_iteration    atm_cas_per_iteration      cpu_time  locks_per_iteration      real_time  writes_per_iteration
-------------------------------------------------------------------  ----------------------  -----------------------  -----------------------  ----------  ---------------------  -----------  ----------------------
BM_Base16SomeStuff/64                                                                                +8.00                               +8.00
BM_HpackEncoderEncodeHeader<SingleNonInternedBinaryElem<100>>/0/16k                                                                                +91.00                              +91.00
BM_HpackEncoderEncodeHeader<SingleNonInternedElem>/0/1                                                                                +53.50                              +53.50
BM_HpackParserInitDestroy                                                                                +724.00                             +724.00

Review status: 3 of 23 files reviewed at latest revision, 19 unresolved discussions, some commit checks failed.

Makefile, line 2990 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
Our Makefile is generated from a template, so you can't modify it directly. Instead, please modify the BUILD file and the build.yaml file and then run ./tools/buildgen/generate_projects.sh.

Done.

src/core/tsi/transport_security.c, line 185 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
s/1/true/

Done.

src/core/tsi/transport_security.c, line 196 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
When does handshaker_result_created get set?

It will be set by each tsi_handshaker implementation. If it is weird to have child struct modifies the parent struct, we can remove this bool.

src/core/tsi/transport_security.h, line 94 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…

int frame_protector_created;
int handshaker_result_created;

These can probably be bool.

Done. I was assuming to use C85, thus avoid to use bool. Per offline discussion with Julien, it seems we are OK to use bool here.

src/core/tsi/transport_security_adapter.c, line 48 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
Doesn't this implementation require that the underlying handshaker continue to exist until after the tsi_handshaker_result is destroyed?  How do we guarantee that?  Perhaps we need to refcount the handshaker object?  Or can we just assume that the few applications that will use this adapter will do the right thing until the adapter goes away?

This is a temporary wrapper. We assume the user of this adapter use this correctly. For example, the underlying tsi_handshaker does not allow to use get_peer after create_frame_protector is called. Same limitation for this wrapper. We will remove this wrapper after migration.

src/core/tsi/transport_security_adapter.c, line 88 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
This can be declared static.

Done.

src/core/tsi/transport_security_adapter.c, line 117 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
static

Done.

src/core/tsi/transport_security_adapter.c, line 124 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
static

Done.

src/core/tsi/transport_security_adapter.c, line 131 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
static

Done.

src/core/tsi/transport_security_adapter.c, line 140 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
static

Done.

src/core/tsi/transport_security_adapter.c, line 148 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
static

Done.

src/core/tsi/transport_security_adapter.c, line 155 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
static

Done.

src/core/tsi/transport_security_interface.h, line 487 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
As mentioned via email, I think handshaker_result can be const.

Per our discussion, let us leave this as it is without const. Let's revisit during our next meeting.

memory_usage.csv, line 1 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
What is this file?  I assume this was added by mistake?

Done. Removed

Comments from Reviewable

No significant performance differences

Performance differences noted:
Benchmark                                     allocs_per_iteration    atm_add_per_iteration    atm_cas_per_iteration      cpu_time  locks_per_iteration      real_time  writes_per_iteration
--------------------------------------------  ----------------------  -----------------------  -----------------------  ----------  ---------------------  -----------  ----------------------
BM_ErrorHttpError<ErrorWithGrpcStatus>                                                                                -6.00                               -6.00
BM_ErrorHttpError<ErrorWithNestedGrpcStatus>                                                                                -12.50                              -12.50
BM_ErrorHttpError<SimpleError>                                                                                -7.00                               -7.00

No significant performance differences

Reviewed 3 of 3 files at r3, 16 of 17 files at r4, 2 of 2 files at r5, 1 of 1 files at r6.
Review status: all files reviewed at latest revision, 20 unresolved discussions, some commit checks failed.

src/core/tsi/transport_security.c, line 196 at r2 (raw file):
Previously, jiangtaoli2016 (Jiangtao Li) wrote…
It will be set by each tsi_handshaker implementation. If it is weird to have child struct modifies the parent struct, we can remove this bool.

Having the subclass modify the data in the parent class is workable.
As an alternative, you could have the parent class do this directly by checking whether the subclass returns a result.  For the sync case, you could handle that right in this function, using something like this:
const tsi_result retval = self->vtable->next(...);
if (*handshaker_result != NULL) self->handshaker_result_created = true;
return retval;

For the async case, this would require intercepting the callback on the way back up (i.e., store the original callback in the parent, have the parent pass its own callback to the subclass, and have that callback set handshaker_result_created and then invoke the original callback).
I can live with either way, so I'll leave this up to you.
Also, note that regardless of whether the parent class or subclass sets this field, you will probably need locking in the async case, because this variable will be updated from a different thread.

src/core/tsi/transport_security_adapter., line 0 at r5 (raw file):
I assume that adding this file was a mistake?

src/core/tsi/transport_security_adapter.c, line 88 at r2 (raw file):
Previously, jiangtaoli2016 (Jiangtao Li) wrote…
Done.

Doesn't look like this was actually done.

src/core/tsi/transport_security_adapter.c, line 78 at r6 (raw file):
Previously, jboeuf wrote…
I think that the handshaker result may outlive the handshaker which means that the handshaker result should take ownership of the passed-in handshaker and therefore destroy it in this function.

+1

Comments from Reviewable

No significant performance differences

Review status: 4 of 22 files reviewed at latest revision, 20 unresolved discussions.

src/core/tsi/transport_security.c, line 196 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
Having the subclass modify the data in the parent class is workable.
As an alternative, you could have the parent class do this directly by checking whether the subclass returns a result.  For the sync case, you could handle that right in this function, using something like this:
const tsi_result retval = self->vtable->next(...);
if (*handshaker_result != NULL) self->handshaker_result_created = true;
return retval;

For the async case, this would require intercepting the callback on the way back up (i.e., store the original callback in the parent, have the parent pass its own callback to the subclass, and have that callback set handshaker_result_created and then invoke the original callback).
I can live with either way, so I'll leave this up to you.
Also, note that regardless of whether the parent class or subclass sets this field, you will probably need locking in the async case, because this variable will be updated from a different thread.

Acknowledged. Agree that we need proper locking for ASYNC implementation. I prefer letting underlying tsi handshaker implementation set the handshaker_result_created value.
For async implementation of tsi_handshaker_next, we do not require the tsi_handshaker to set the input bytes_to_send, bytes_to_send_size, and handshaker_result, they could even be NULL.

src/core/tsi/transport_security_adapter.c, line 88 at r2 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
Doesn't look like this was actually done.

Sorry, my bad. I forget that this create is private. Usually create is public and does not use static.

src/core/tsi/transport_security_interface.h, line 491 at r6 (raw file):
Previously, jboeuf wrote…
Please document that if the call is async, the callback is guaranteed to run in another thread owned by TSI.

Done

src/core/tsi/transport_security_adapter., line  at r5 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
I assume that adding this file was a mistake?

My bad. I need sometime to get use to the github grpc development environment :)

Comments from Reviewable

Performance differences noted:
Benchmark                                                                allocs_per_iteration    atm_add_per_iteration    atm_cas_per_iteration      cpu_time  locks_per_iteration      real_time  writes_per_iteration
-----------------------------------------------------------------------  ----------------------  -----------------------  -----------------------  ----------  ---------------------  -----------  ----------------------
BM_HpackEncoderEncodeHeader<RepresentativeServerTrailingMetadata>/1/16k                                                                                +10.50                              +10.50
BM_HpackEncoderEncodeHeader<SingleNonInternedElem>/0/16k                                                                                +17.50                              +17.50
BM_IsolatedFilter<ClientChannelFilter, NoOp>                                                                                -9.00                               -9.00

Performance differences noted:
Benchmark                                                 allocs_per_iteration    atm_add_per_iteration    atm_cas_per_iteration      cpu_time  locks_per_iteration      real_time  writes_per_iteration
--------------------------------------------------------  ----------------------  -----------------------  -----------------------  ----------  ---------------------  -----------  ----------------------
BM_HpackEncoderEncodeHeader<SingleInternedKeyElem>/0/16k                                                                                +16.00                              +16.00

This looks fine to me, but I'll wait for Julien to be happy and for all tests to pass before approving.

Reviewed 19 of 19 files at r7.
Review status: all files reviewed at latest revision, 13 unresolved discussions, some commit checks failed.

Comments from Reviewable

Thanks Mark for review and your flexibility!
Do you know how to make all tests passing? The errors in the test do not seems caused by this CL.
I ran "./tools/run_tests/run_tests.py -l c" successfully on my local machine.

Performance differences noted:
Benchmark                                      cpu_time    real_time
-------------------------------------------  ----------  -----------
BM_PollEmptyPollset_SpeedOfLight/1/9.76562k      -28.50       -28.50
BM_TransportStreamRecv/16M                    -25712.50    -25712.50
BM_TransportStreamRecv/256k                     -581.00      -581.00
BM_TransportStreamRecv/2M                      -2373.50     -2373.50

There are some known test failures that are probably unrelated to this PR, but we require that you verify that there are open issues for all known failures and reference those issues here before merging the PR.
@dgquintas, can you help Jiangtao identify any known issues here and get this merged (once Julien approves)?  Thanks!

Thanks Mark and David!
Julien: could you review and approve this diff?

If you look at https://grpc-testing.appspot.com/job/gRPC_pull_requests_linux/4661/testReport/junit/(root)/sanity_linux_opt_native/tools_distrib_check_include_guards_py/ , your include guards are missing for src/core/tsi/transport_security_adapter.h and wrong for src/core/tsi/transport_security_adapter.h

No significant performance differences

markdroth: any more comments?

No significant performance differences

Reviewed 6 of 14 files at r8, 5 of 11 files at r9, 5 of 6 files at r10.
Review status: all files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

src/core/tsi/transport_security_interface.h, line 235 at r6 (raw file):
Previously, jboeuf wrote…
Ownership of the bytes is retained by the handshaker result. As a consequence, the caller must not free bytes.

Looks like this comment still needs to be addressed.

Comments from Reviewable

Review status: all files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

src/core/tsi/transport_security_interface.h, line 235 at r6 (raw file):

The caller should not free the bytes.

I already wrote "The caller should not free the bytes." Maybe add more clarification about ownership.

Comments from Reviewable

Known issues: #10887 #10888 #9153 #10882 #10839


LanguageServer script failing

Guys/ladies, I'm having some trouble getting composer/language-server setup in Ubuntu Linux. This is the latest error in my quest to finish this apparently insurmountably difficult task. Granted I'm new to composer, so this is all still a bit confusing.
After running
composer run-script --working-dir=vendor/felixfbecker/language-server parse-stubs
The script fails on line
Parsing file:///home/phatwhalemedia/.config/composer/vendor/jetbrains/phpstorm-stubs/http/http.php
Giving this error
Script LanguageServer\ComposerScripts::parseStubs handling the parse-stubs event terminated with an exception

  [RuntimeException]
  A type is missing before a type separator

If there's any further info required, please let me know.
I've been following the steps from the following link:
#611

Same. My "workaround" was to simply remove ~/.config/composer/vendor/jetbrains/phpstorm-stubs/http/http.php for the time being.

same err here :-1:

You can use the bundled language server from the vscode extension https://marketplace.visualstudio.com/items?itemName=felixfbecker.php-intellisense --> download extension --> rename to .zip --> /extension/vendor/felixbecker/language-server/bin

Also fails on vendor/jetbrains/phpstorm-stubs/standard/standard_8.php

I submitted a simple pull request to fix this.
The simple solution until that's merged is to setup your composer.json like so:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/CodyWilson/php-language-server"
        }
    ],
    "require": {
        "felixfbecker/language-server": "dev-master"
    }
}

Alternatively you could fork it yourself and do that change, and set the version control to point to your fork.

@felixfbecker any updates for this project?

@felixfbecker any updates for this project?


can not write to cloud database

I can not update a default data for new user after registration.
data only update after I sign out.

Please could you follow the issue template, providing versions, code examples and reproduction please.


drivers: nrf: add support for forcing out-of-tree drivers

An external project extending the Zephyr RTOS and its drivers may have
subsystems that must use its own specific driver(s) when active. One
example is the nRF5x NVMC that must be scheduled in between radio
operations. A subsystem may also be dependent on its own drivers for
security, real-time and/or because of hardware constrains.
In order to not introduce non-Zephyr specific code into the Zephyr tree,
an option is added to disable the in-tree drivers in Zephyr. Because
Kconfig does not support a good way of de-selecting other symbols, a
variable on the form <DRIVER>_OUT_OF_TREE_DRIVER is added as a
dependency for each <DRIVER>. For example, the out-of-tree subsystem
will select FLASH_OUT_OF_TREE_DRIVER to disable the in-tree driver. A
solution for issue #8181 would open up for a more general solution,
however #8181 requires significant effort.
Support for out-of-tree drivers is added to Nordic drivers for
clock_control, entropy and flash.
See https://github.com/zephyrproject-rtos/zephyr/pull/13631 for earlier discussion.
Signed-off-by: Thomas Stenersen<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0758e3a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14509   +/-   ##
=========================================
  Coverage          ?   52.02%
=========================================
  Files             ?      309
  Lines             ?    45574
  Branches          ?    10555
=========================================
  Hits              ?    23711
  Misses            ?    17057
  Partials          ?     4806

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0758e3a...9b25a33. Read the comment docs.

The shippable failed, but when skimming through the log it looked like xtensa things failed. I rebased with changes from master and pushed again. @carlescufi is there anything missing?

I propose to drop the out-of-tree naming and call it alternate or something along those lines. This concept should also work with 2 compatible drivers in the same tree.

@thomasstenersen @nashif I agree with the proposal, I never liked OUT_OF_TREE. I suggest:
CLOCK_CONTROL_NRF_ALT or CLOCK_CONTROL_NRF_REPLACE

If you are OK with CLOCK_CONTROL_NRF_FORCE_ALT I will use that, @nashif.

@nashif @carlescufi I changed the name to _FORCE_ALT.

Shippable failed (timed out apparently?), rebased on top of master to try this again.


Implement transactions in mongo driver

MongoDB 4 supports transactions, so we should add support for that.
Maybe via new driver keeping the current MongoDriver for MongoDB 3, or via some configuration option that would be disabled by default (or automatically enabled via feature detection/version comparison).

Looking into this now, already god the basics implemented, just have to adjust docker and travis setup so we can test it.
@j as you were requesting this recently, do you think we should allow optional transactions in mongo or should we have it always enabled? It will require running replica set and it might not be needed for most users, so I am thinking about having it optional, just not sure about the default value.
Also tagging @gustavopch and @seiyria as I know they are using the mongo driver.

It should definitely be optional, off by default. Most people using or developing software will be running a single node of mongo.

Sorry for the late response, just saw this.  @B4nan That's a rough one.  I actually started 100% mongo transactions in a re-write and before I got too ahead of myself I decided to benchmark the two use-cases.  In a high traffic environment, transactions definitely slow things down, so I'd say keep it optional.  I don't think it should be either OFF or ON, but selective somehow?
I still want to be able to do a transaction if I want to.
We run ecom, so transactions on checkouts are pretty crucial.

Also, unrelated and I don't want to create another issue for a question.  I haven't dug into how the UoW does changeset tracking.  Does it just simply check the root object and if that root object changes, to update it?
In other words, if I have an array and remove an element at index 2 from it, is it smart enough to issue a pull on that index?  I know DoctrineODM does smart updates like this.  I'm sure this type of change-set tracking is hard to do though.  I was hoping one day there'd be a proxy library that's smart enough to figure a Mongo query based off changes.  I attempted it and gave up. Haha.

So I guess it could work this way:

add new config toggle (global) to enable/disable implicit transactions (those that happen automatically when flushing)
add new platform option to distinguish drivers that are capable of tx but do not want them implicitly by default (will be true for mongo platform)
so by default, mongo will be able to do explicit transactions via em.transactional(), but flushing will not cause implicit ones
you will be able to enable implicit transactions manually, which will result in same behaviour as sql drivers

I will probably delay this for some 3.x release as it turned out being not that easy to incorporate into CI build and mainly because I don't want to postpone v3 release forever :]

Does it just simply check the root object and if that root object changes, to update it?

Currently yes, but it will update only properties that actually changed. But for array, it will update it as a whole. Would be nice to support more granular array change sets, but nothing I am planning to work soon...

Any update on this?

It will land soon, probably not next feature release, but the following one (3.5).

Will be part of 3.4.
https://mikro-orm.io/docs/next/usage-with-mongo/#transactions


UX - Buttons / Menus

Hello.
As i read FireCoder is in its early stage. Maybe it is the perfect time, to give some suggestions what could improve the usability of FireCoder. These things would be nice:

a copy button, to copy the generated code-text
a cancel / stop button to stop the ai commenting more text, because the code is finished but the AI explaination has a too long text
a drop-down menu where we can store the chats (with the possibility to delete them by a small X-button)
a mouse-button rightclick context menu, when selecting code inside the VScode editor. Inside such a context menu
could be something like: analyze code, find problem, reformat code, etc. This could be send back to FireCoder and it will
automatically start the chat.
Start / Stop Server Button: Because sometimes i dont need FireCoder. And if i am not able to deactivate it, my RAM is full. So deactivating the Server manually would free RAM space

I think these few things, by adding some "Buttons" and "Menus" could improve the usability of FireCoder.

Hello. I appreciate your thoughts a lot.
I am not sure that I will be able to do these features soon. But I am going to start with the second feature. It looks doable.
You can use this issue to follow updates regarding your suggestions.
Thank you very much.

I am happy if i can influence a little bit to FireCoder, so it can become better. Not all features need to be implemented at once. Take your time and add them version by version. Just how it fits best to your schedule.


[release-1.16] Fix manifest generate generates deprecated versions of templates

Please provide a description of this PR:
Manual cherry-pick https://github.com/istio/istio/pull/42513.
Also, combine this one https://github.com/istio/istio/pull/41838, which unblocks the former PR.
From https://istio.io/latest/docs/releases/supported-releases/, the min supported version is 1.22.
Fix https://github.com/istio/istio/issues/42945.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-cni

integ-pilot_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-cni

integ-pilot_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot

integ-telemetry-istiodremote_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-cni

integ-pilot_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-pilot

integ-telemetry-istiodremote_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio_release-1.16
dcd4418cac3729ec4c3d55b3e17dd12def2bd66c
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


xGov-105 Cheaper USDC Onramp/Offramp for US Algorand Users -> To update before period 3

Cheaper USDC Onramp/Offramp for US Algorand Users

Be sure to change the status to Final if you want to be part of the next session
status: Draft -> status: Final

Proposer, please post your algorand forum discussion thread link here. Thank you.


Create async-convertible version of StrictTransportSecurityHeader authorizer

Somehow these changes went missing. See lack of commit referencing this issue.


Grammar fix

PR will fix the grammatical error on generic.md
What does this PR do?
"an" is not required with the plural noun "links"
Change will remove the article from incorrect line

Thanks :)


fix pubsub-simple sample

Description
Fixed pubsub-simple topic parameter.
Issue reference
Please reference the issue this PR will close: #174
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[X] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

my mistake - wrong SDK version locally

my mistake - wrong SDK version locally


CFP: BackendTLSPolicy for Cilium Gateway API and HTTPRoutes

Cilium Feature Proposal
We have a need to be able to use BackendTLSPolicy in Cilium Gateway API for HTTProutes to our services, which is defined in the Gateway API standard in Kubernetes: https://gateway-api.sigs.k8s.io/api-types/backendtlspolicy/?h=backendtlspolicy
Describe the feature you'd like
We are currently experiencing issues when using Cilium Gateway API, especially for services that has its own TLS already pre-configured.

Am I to assume that Cilium Gateway API does not currently support BackendTLSPolicy for HTTPRoutes as of 1.15.2? That would explain why its not working for me after following the Gateway API docs on configuring it.  I don't get any errors, but I also don't see any Status in the BackendTLSPolicy object.
I also would like to see this implemented.

I make the same observation like @kenlasko - I "think" I configured everything correct(?) but it just does not seem to work. I try to do terminate-and-reencrypt on my gateway to my backend service but the backend keeps on saying I am talking http to it instead of https as specified via the BackendTLSPolicy

Having the same issue as @OevreFlataeker where a backend service is expecting a HTTPS connection but is only getting a HTTP one from the gateway.
I can get this working with the below but I then loose the use of the signed certificate from Cert-Manager and only the Self Signed from the service is presented.

Listener Protocol
TLS Mode
Route Type Supported

TLS
Passthrough
TLSRoute

Could you kindly provide a full example what you did so I can check this with my setup? (Still beginner...) Thanks!

Here's my config:
---
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: kubeapi
  namespace: cilium
spec:
  gatewayClassName: cilium
  infrastructure:
    annotations:
      io.cilium/lb-ipam-ips: <IP_ADDRESS>
  listeners:
  - name: https
    protocol: TLS
    port: 443
    hostname: "k3s.mydomain.com"
    tls:
      mode: Terminate
      certificateRefs:
      - kind: Secret
        name: letsencrypt-wildcard-cert
        namespace: cilium
    allowedRoutes:
      namespaces:
        from: All

---
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: kubeapi
  namespace: default
spec:
  parentRefs:
  - name: kubeapi
    namespace: cilium
    sectionName: https
  hostnames:
  - "k3s.mydomain.com"
  rules:
  - backendRefs:
    - name: kubernetes
      namespace: default
      group: ""
      kind: Service
      port: 443

---
apiVersion: gateway.networking.k8s.io/v1alpha2
kind: BackendTLSPolicy
metadata:
  name: k3s-tls-policy
  namespace: default
spec:
  targetRef:
    kind: Service
    name: kubernetes
    group: ""
    namespace: default
  tls:
    caCertRefs:
      - kind: ConfigMapReference
        name: kube-root-ca.crt
        group: ""
    hostname: k3s.ucdialplans.com

Everything gets created, but the BackendTLSPolicy object doesn't have a Status like every other Gateway API object, which implies that its not actually active at all. The spec for BackendTLSPolicy states that Status should be there.
This would make sense as it appears that BackendTLSPolicy has yet to be implemented in Cilium.

And this serves you the service's webpage but just with a different/untrusted cert? In my case I get "http spoken on a https port" as the response as the service apparently receives a http request from the gateway instead of https... will check my config for deviation

In my particular case, I get an error because my webpage requires a certificate, but I get a similar error. It makes sense because the HTTP route is passing port 443 but the TLS connection is terminated at the gateway and the BackendTLSPolicy isn't being used to apply the desired cert.

Sorry about the delay here, but yes, Cilium does not currently support BackendTLSPolicy, as it's moving forward in Gateway v1.1. Thanks for the feedback, and we'll make sure we prioritize appropriately once Gateway v1.1 is out. (There may be changes to his API in v1.1 or v1.2, let me check about that first though).

Hi all
I wonder if there are any roadmap items regarding backendTlsPolicy?

Yes, we would like to implement it, but noone has got to it yet. PRs welcomed, as always.

Maybe I am misunderstanding something, but apart from having TLSPassthrough is there really no other way to speak TLS to the backend with Gateway API? This seems to be something pretty basic and desirable? I wonder why this has not been done yet?


UI and Social Media Updates

These commits include the following changes:
-added social media sharing for Facebook, Twitter and G+ to the show view so users can share posts on social media.
-changed the typography and made it uniform throughout all the views in the app. I don't know how to apply styling to the devise error messages though.
-added instructions on how to use ElasticSearch and Redis on Nitrous.

@dwanjuhi1 merged! ...beautiful! :)


Extendable models in the config

The variable set in each controller or place might be ugly but it solves the problem in Spatie's way.
Closes #92

@rennokki - Thanks your PR. Here are my 5 seconds :) Maybe they could help as inspiration?!
Load the models via __construct
Currently the model files are initialized each time when needed.
Example: In the PagesController, in each method we have a $pageModel = config(...).
We could use the __construct to initialize all needed models and in the methods ( e.g.index etc.) we call the model via $this->pagesModel->....
Should be the same result, but maybe not so ugly?
Bind the model
I saw it in other projects already, and here they have the same as we have it here.
The used model if defined in a config file and in the app, they call it via app('xxx').
An example for this is https://github.com/rinvex/laravel-tenants/blob/master/src/Providers/TenantsServiceProvider.php#L35

Are these possible alternatives or did you analyzed these already and there is a reason why you decided not to do it this way?


Implementing Undo and Redo features by using the Memento Pattern

This pull request add the features "Undo" and "Redo" to the system by using the Memento Design Pattern. This allows the user to go back in the states of the program if the user wants to undo the last change, or even restore the program to the original state.
In the same way, the "Redo" feature was also implemented, which allows to restore a state after the user use the "Undo" action. This enhances the user experience since it´s easier to fix an error and interact with the system.
Desing proposed in the PR:

Thank you so much for the PR and adding so much stuff! Really appreciate it :D
I was also thinking of implementing undo/redo but didn't know how to integrate it well from the UI side.

the design patterns.
It seems that you guys branched from the main branch and the UI implementation was changed in develop branch so I'm having a lot of conflicts! I'll try to fix them asap

Sorry for the late reply. I was quite busy for the last couple of weeks :(


Allow questions and answers in the same buffer

First of all, thanks a lot for the copilot chat interface! I have really been waiting for such an interface since I got access to github copilot! :-)
I'm missing the ability to have shell (comint) like experience where the question and answer are written in the same buffer.
The advantage is obviously that you only need to change to a single buffer in order to provide both the input and the output.

Try shell-maker frontend. It does what you need.

Thanks! It's working fine!
However, I then lost all the syntax highlighting. What I'd like is the following:

Variable pitch font for the interaction
Markdown interpretation of backticks and hashes, and anything else that github copilot outputs.
Syntax highlighting of code sections with a different background color, which should be shown in a fixed font

In short, I'd like to something visually similar to the VSCode github chat, but in emacs.

Meanwhile I "solved" this by writing the following function which displays the current buffer as markdown in the a temporary buffer:
(defun copy-buffer-to-temp-markdown ()
  "Copy the current buffer to a temporary read-only buffer and display it in markdown mode."
  (interactive)
  (let* ((ctx (buffer-substring-no-properties (point-min) (point-max)))
         (temp-buffer (generate-new-buffer "*Temp Markdown*"))
         (original-buffer (current-buffer)))
    (with-current-buffer temp-buffer
      (insert ctx)
      (markdown-mode)
      (read-only-mode 1)
      (local-set-key (kbd "q")
                     (lambda ()
                       (interactive)
                       (kill-buffer (current-buffer))))
    (switch-to-buffer temp-buffer)
    (variable-pitch-mode t))))

I pushed a new branch: shell-polymode.
It uses polymode to enable mardown-mode for copilot answers.
Can you try it and tell me if this is what you are looking for ?

Great! For me it is almost perfect. Here are a few few remaining nitpicks.

Sometimes markdown is missed
It would be nice to hide the leading '#' signs for the buffer
Is it possible to change the background color for a box around the markdown code? Note that just changing the face for the markdown-code-face does not change the background of the characters trailing the end of the line.
There is a redundant line before the code block

My mystake. Now it uses mardown-view-mode which display the result and not the markdown code.
For the background, I can't do anything but maybe this is a face defined by mardown-view-mode. You could try to customize it.

Great! Indeed markdown-view works much better.
Regarding the background, I have learned that if you turn on the face attribute extent then the background face extents to margin and you get a boxed feeling.
The only thing remaining is the "redundent line". But I can certainly live with that.
Thanks a lot again! I have already created a binding for jumping straight to the copilot-chat-shell buffer, which I will certainly use a lot.
Now, if we could only customize the prompt?

I think that the redundant line is inside copilot answer, I do not modify anything, just write the received tokens as-is.
Customizing the prompt may be a bad idea as it is used by polymode to detect the end of the markdown area. It uses regexp for that. Or the regexp must depend on the customization. This could lead to a lot of side effects…


[Web]: Pointer acts incorrectly when typing at TextField wrapped in Stack

Steps to Reproduce

Create project with represented code sample.
Run at Flutter Web (I use Chrome)
Click to TextField, write something
Move pointer to a Button 1

Expected result: Pointer is at click state
Actual result: Pointer is at text editing state
Note: Tried to wrap TextField with MouseRegion - didn't help
Note 2: Works properly if to run as desktop app on  macOs
How it works on web:
https://user-images.githubusercontent.com/17158960/202515244-ff808b02-2f46-4372-b563-cf7b1669c37d.mov
How it works on macOs:
https://user-images.githubusercontent.com/17158960/202515191-53c6067b-2946-4931-9790-8ef1b6b9c2ce.mov

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Pointer at stack',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Padding(
        padding: const EdgeInsets.all(40.0),
        child: Stack(
          children: [
            const TextField(
              maxLines: 10,
            ),
            Positioned(
              top: 0,
              right: 0,
              child: TextButton(
                onPressed: () {},
                child: const Text('Button 1'),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

Logs
Launching lib/main.dart on Chrome in debug mode...
lib/main.dart:1
This app is linked to the debug service: ws://<IP_ADDRESS>:56237/ue6ev_J_pzs=/ws
Debug service listening on ws://<IP_ADDRESS>:56237/ue6ev_J_pzs=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://<IP_ADDRESS>:56237/ue6ev_J_pzs=/ws
Flutter Web Bootstrap: Programmatic

Analyzing pointer_at_stack...
No issues found! (ran in 2.2s)

[✓] Flutter (Channel stable, 3.3.8, on macOS 12.6 21G115 darwin-x64, locale ru-RU)
    • Flutter version 3.3.8 on channel stable at /Users/dmitrijrepin/sdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (9 days ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0-rc2)
    • Android SDK at /Users/dmitrijrepin/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0-rc2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] IntelliJ IDEA Community Edition (version 2021.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Thanks for the report @Malarg
I believe the use case should probably be covered in this issue which you can follow-up on.
https://github.com/flutter/flutter/issues/31952#issuecomment-540108865
https://github.com/flutter/flutter/issues/31952#issuecomment-540110503
Closing this issue as duplicate. If you disagree, write in comments and I'll reopen it.

@darshankawar I believe this is a separate bug for the following reasons:

That issue was about the ability to override default cursor while this one is about incorrect default cursor.
This issue has specific condition: a button over a focused text field in a stack, and this does not happen with a de-focused field.
This specific case is not listed in the checkboxes that remain.

This snippet is modified to also show the same button outside of Stack and these videos also show a button over a de-focused field for comparison.
Flutter 3.3.8, CanvasKit.
https://user-images.githubusercontent.com/44893228/202733274-68ab11cf-c148-433f-b5ba-9bd7defdbbb6.mp4

Code
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Pointer at stack',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Padding(
        padding: const EdgeInsets.all(40.0),
        child: Column(
          children: [
            TextButton(
              onPressed: () {},
              child: const Text('Button outside of Stack'),
            ),
            Stack(
              children: [
                const TextField(
                  maxLines: 10,
                ),
                Positioned(
                  top: 0,
                  right: 0,
                  child: TextButton(
                    onPressed: () {},
                    child: const Text('Button in Stack'),
                  ),
                ),
              ],
            ),
          ],
        ),
      ),
    );
  }
}

flutter doctor -v
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.3.8, on Ubuntu 20.04.5 LTS 5.14.0-1054-oem, locale en_US.UTF-8)
[!] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/linux#android-setup for more details.
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.72.2)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

! Doctor found issues in 1 category.
alexey@alexey-akvelon-dell:~/temp/flutter_test_project5$ flutter doctor -v
[✓] Flutter (Channel stable, 3.3.8, on Ubuntu 20.04.5 LTS 5.14.0-1054-oem, locale en_US.UTF-8)
    • Flutter version 3.3.8 on channel stable at /home/alexey/snap/flutter/common/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (9 days ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /home/alexey/Android/Sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/linux#android-setup for more details.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2021.2)
    • Android Studio at /home/alexey/bin/android-studio
    • Flutter plugin version 68.1.2
    • Dart plugin version 212.5744
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.72.2)
    • VS Code at /usr/share/code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Ubuntu 20.04.5 LTS 5.14.0-1054-oem
    • Chrome (web)    • chrome • web-javascript • Google Chrome 106.0.5249.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

@darshankawar I agreed with Alexey. Reopen the task, please

Thanks for the feedback. Reopening.

Based on the details provided here and here , the behavior is replicable using both renderers.

 stable, master flutter doctor -v
[✓] Flutter (Channel stable, 3.3.8, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.3.8 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (25 hours ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.6.0-7.0.pre.18, on macOS 12.2.1 21D62 darwin-x64,
    locale en-GB)
    • Flutter version 3.6.0-7.0.pre.18 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2921ca0c48 (2 hours ago), 2022-11-21 21:43:26 -0500
    • Engine revision 8dd8e092e4
    • Dart version 2.19.0 (build 2.19.0-415.0.dev)
    • DevTools version 2.19.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Can anyone please set a priority label for this?

/cc @yjbanov

I can just confirm that this is still an issue with Flutter 3.24.3 in October 2024. Button and MouseRegion will have the correct cursor when the text field isn't focused but as soon as the text field is focused, the text field cursor will be displayed, even over the the button/mouseregion. This only occurs in web (with the default canvas kit, I haven't tried wasm). This bug does not affect windows or mac releases.


Adding the 507 (Insufficient Storage) status code.

I am adding support for the 507 status code.

Thank you for your contribution 🚀


WalletConnect does not work. Link non-responsive on TFE

The "WalletConnect" link within the connect eth wallet component is non-responsive for me. Firefox.
True on token.fariground.wtf
and
the mainnet deploy preview https://token-monorepo.netlify.app/

note: only appear to be an issue on TFE. Console is fine.

Tested: Working fine


Stitching failed for images from overhead camera.

Hey, thanks for the wonderful repo but it failed for over head images.
I tried using your repo for images captured from a rotating PTZ  Camera and the output result show only the images appended to each other.
FYI, Check below attached output and input images, any feedback or advice is really appreciated.

@trohit920 sorry for delayed response. Are you still facing the issue?

@trohit920 Please let me know if you are still facing the same issue.


Help: How to get rid of space between two components?

Hi,
First of all, thank you for such an  amazing plugin.
I'm trying to put file_icon and file_name right next to each other but there is extra space which I don't know how to get rid of. I have  put left and right separators to empty strings but space still exists.
My  config.
        lualine_c = {
            {"filetype", icon_only = true, component_separators = {left = "", right = ""}},
            {"filename", color = {gui = "bold,italic", fg = "#ebdbb2"}}
        },

My output currently.

use the padding option.
        lualine_c = {
            {"filetype", padding={right=0}, icon_only = true, component_separators = {left = "", right = ""}},
            {"filename", padding={left=0}, color = {gui = "bold,italic", fg = "#ebdbb2"}}
        },


Multiple alternative alleles

Thanks for the great tool, it's very helpful to have an off-the-shelf genomics RDB.
I have noticed that GEMINI does not handle multiple alternative alleles.  GEMINI also seems to assume any alternative allele with a length > 1 is an indel.
Here are a few examples where the type/sub_type is mistaken.  I know that the formatting of some of the following variants is wrong (e.g. CCG CCA), but I think they are useful to show potential edge cases.
These misannotations will affect the SNP, MNP, indel counts and also cause imprecise reporting of num_het, num_hom_alt etc.
I am happy to help work through the source code to split alternative alleles into separate records, but I don't want to duplicate efforts if this is already under revision.
Thanks.

gemini query -q "select chrom,start,end,ref,alt,aaf,type,sub_type,num_hom_ref,num_het,num_hom_alt from variants where end>790750 and end<790770" my.db

chr1	790755	790760	GTGTA	GTG,G,GTGTG	None	indel	unknown	10	97	268

gemini query -q "select chrom,start,end,ref,alt,aaf,type,sub_type,num_hom_ref,num_het,num_hom_alt from variants where end>808625 and end<808640" my.db

chr1	808628	808631	CCG	CCA	0.763661202186	indel	ins	23	127	216

gemini query -q "select chrom,start,end,ref,alt,aaf,type,sub_type,num_hom_ref,num_het,num_hom_alt from variants where end>812825 and end<812832" my.db

chr1	812826	812829	CTC	TCT	0.00134408602151	indel	ins	371	1	0

gemini query -q "select chrom,start,end,ref,alt,aaf,type,sub_type,num_hom_ref,num_het,num_hom_alt from variants where end>801300 and end<801310" my.db

chr1	801305	801308	ACC	GTT	0.00134770889488	indel	ins	370	1	0

gemini query -q "select chrom,start,end,ref,alt,aaf,type,sub_type,num_hom_ref,num_het,num_hom_alt from variants where end>805100 and end<805109" my.db

chr1	805101	805103	CG	AA,CT	None	indel	unknown	374	2	0

this can be closed.

Thanks to @brentp, full support for multiple alternate alleles is available in master and will be in the forthcoming release.

I think this hasn't been included yet:
It would be very useful to support multiple alt alleles when using a bed/vcf(-like) file with the annotate tool.
We (and others) use an internal database of NGS data for frequency exclusion (because you have a large control set of exomes/genomes from a population not represented in 1KG/ExAC/ESP and/or because you want to filter out pipeline-specific artifacts. If you have multiple alt alleles and one is an artifact/common while the other is your causal mutation, you obviously don't want to exclude the entire position, just the common/artifact allele.

Brent is working on that right now.  Will be in the forthcoming release.

Awesome thanks!

In the context of multiple alts, proper annotation with a VCF will require that the annotation VCF is also decomposed and normalized in the same way as the VCF that was loaded into GEMINI.
Decomposition and normalization will be required pre-processing steps for all input VCFs in the next release.

@jxchong we think that forcing decomposition + normalization before is the best way and should improve the annotation. But, there could be use-cases or ways of doing this we haven't thought of so let us know.
The vt software (https://github.com/atks/vt) is quite good at doing this now and the developer is fixing bugs as we report them.


Affective task: some SAMs on the edge are incomplete

Part of their drawings are cut off. We want to redraw the missing lines.

https://github.com/ml4ai/tomcat-baseline-tasks/blob/main/tasks/affective_task/images/buttons_images/Valence.jpg if you see here the images are perfect! Maybe something to do with the buttons?

It was the textbox causing that issue. Reduced the size, now that's fixed!


feat: inject provider version in updater

This PR injects provider version in updater.

Hey @eddycharly 👋🏼 quick question about this recent change, does this mean that once we update the kops provider version it will force the updater resource to rollout the cluster?

Hey, it will find a difference in the updater resource and trigger an update. The cluster will roll out only if kOps thinks it needs to.


Confusing Rhetoric about supported VM instances

"On instances that support hyperthreading, Accelerated Networking is supported on VM instances with 4 or more vCPUs. Supported series are: D/Dsv3, E/Esv3, Fsv2, Lsv2, Ms/Mms and Ms/Mmsv2." is confusing because you can deploy a E16as_v4 VM with accelerated networking despite it not explicitly supporting hyper-threading in the documentation. Also, this documentation has not been updated since Jan 2019 and since then, the Dv4 and Ev4 was released (Nov 2019). Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f89338c0-968d-c22f-5b0d-ed3870ebc2fa
Version Independent ID: 6daae1cc-f758-1d37-9de3-80a2832c08ef
Content: Create an Azure VM with Accelerated Networking using Azure CLI
Content Source: articles/virtual-network/create-vm-accelerated-networking-cli.md
Service: virtual-network
GitHub Login: @gsilva5
Microsoft Alias: gsilva

@kmccullagh19 Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

The article has since been updated to include more up to date information about supported SKUs, including a pending PR that will allow anyone to get a real-time view of this.
At this time, I'm going to close this issue as it no longer lists a SKUs directly (which was a large maintenance issue).
#please-close


Standardize Transient bytecode

This is important because it will allow for changes to be made more swiftly to the project.

Current standard:
Each instruction is 8 bytes (64 bits) long, following this layout:

Byte
0
1
2
3
4
5
6
7

Purpose
Opcode
Size
Source1 High
Source1 Low
Source2 High
Source2 Low
Destination High
Destination Low

Instructions are expected to begin at offset 0x00 (beginning of file) and to be aligned to a multiple of 8. The program counter increments by 8 after executing an instruction successfully. The last instruction is to be a halt, and following this, all variable storage is to be placed. source1, source2, and destination are addresses that point to the base address of each variable. Size is the amount of bytes to be read, starting with the base pointer.

Revision 1:
Default endianness is now little-endian, to allow for variables to be downcasted. Instructions are no longer fixed-length but instead depend on the instructions. The pointer size (word size) is now 32 bits. The length of memory instructions should be dynamic and there are to be flags specifying the execution mode.
Layout:

Byte
0
1
2
..

Purpose
Opcode
Pointer mode
Address size
Instruction-specific data ..

Pointer mode: Each argument is assigned two bits, meaning that each instruction can have a maximum of four arguments. The first argument (leftmost) corresponds to bits 0 and 1 of the pointer mode field. These can be three values:
0: absolute addresses
1: pointer-to-pointer
2: immediate
Address size: Describes the length of data to be read at each one of the pointers. This is redundant if the pointer mode is pointer-to-pointer or immediate, as the pointer size is always 32 bits. Being an 8-bit (1 byte) field, this gives 2 bits per argument, i.e. three values:
0: 16 bit value
1: 32 bit value
2: 64 bit value

Possible instructions:
//                    Value Value Sum
add ptr_mode add_size arg_1 arg_2 arg_3
//                    Ptr   Value
jie ptr_mode add_size arg_1 arg_2
//
hlt

Planned 0.2.0 instruction set
Mov
Layout: opcode ptr_mode add_size arg_1 arg_2
Opcode: 0x01
Description: Sets arg_1 to arg_2
Add
Layout: opcode ptr_mode add_size arg_1 arg_2 arg_3
Opcode: 0x02
Description: Adds arg_1 and arg_2 and stores in arg_3
Sub
Layout: opcode ptr_mode add_size arg_1 arg_2 arg_3
Opcode: 0x03
Description: Subtracts arg_2 from arg_1 and stores in arg_3
Mul
Layout: opcode ptr_mode add_size arg_1 arg_2 arg_3
Opcode: 0x04
Description: Multiplies arg_1 and arg_2 and stores in arg_3
Div
Layout: opcode ptr_mode add_size arg_1 arg_2 arg_3
Opcode: 0x05
Description: Divides arg_1 by arg_2 and stores quotient in arg_3
Rem
Layout: opcode ptr_mode add_size arg_1 arg_2 arg_3
Opcode: 0x06
Description: Divides arg_1 and arg_2 and stores remainder in arg_3
Equ
Layout: opcode ptr_mode add_size arg_1 arg_2 arg_3
Opcode: 0x07
Description: If arg_1 is equal to arg_2, store 0x1 in arg_3, otherwise store 0x0
Cgt
Layout: opcode ptr_mode add_size arg_1 arg_2 arg_3
Opcode: 0x08
Description: If arg_1 is greater than arg_2, store 0x1 in arg_3, otherwise store 0x0
Clt
Layout: opcode ptr_mode add_size arg_1 arg_2 arg_3
Opcode: 0x09
Description: If arg_1 is less than arg_2, store 0x1 in arg_3, otherwise store 0x0
Jmp
Layout: opcode ptr_mode arg_1
Opcode: 0x0A
Description: Set program counter to arg_1, effectively jumping to arg_1
Jie
Layout: opcode ptr_mode add_size arg_1 arg_2
Opcode: 0x0B
Description: Set program counter to arg_2 if arg_1 is 0x1.
Jne
Layout: opcode ptr_mode add_size arg_1 arg_2
Opcode: 0x0C
Description: Set program counter to arg_2 if arg_1 is 0x0.
PutI
Layout: opcode ptr_mode add_size arg_1
Opcode: 0x0D
Description: Print arg_1 to the console as an integer.
PutC
Layout: opcode ptr_mode add_size arg_1
Opcode: 0x0E
Description: Print arg_1 to the console as an ascii character.
Imz
Layout: opcode ptr_mode add_size arg_1
Opcode: 0x0F
Description: Invokes the image size (in bytes) from the virtual machine and stores it in arg_1
Hlt
Layout: opcode
Opcode: 0xFF
Description: Halts execution and exits the virtual machine


Image retrieving

I have an object of Image class, but how can I add the full image to a ImageView for example?

Closing as duplicate. Please refer to the issue @Linnun mentioned.


Crash occurs upon opening an additional session of Calculator that is not the same size and mode of the current, open session

Describe the bug
Crash occurs upon opening an additional session of Calculator that is not the same size and mode of the current, open session
Steps To Reproduce

Launch a session Calculator in Standard mode with History/Memory panel not displayed
Leave this 1st session open throughout the rest of the steps
Open a 2nd session
Resize the 2nd session to display History/Memory panel
Switch the 2nd session to another mode of calculator such as Scientific
Close the 2nd session
Open a 3rd session
If the mode of the third session reverted to the same mode of the 1st session, change the mode of the 3rd session to the mode that 2nd session was before it was closed
Close the 3rd session
Open 4th a session (if crash does not occur open and close additional sessions)

Expected behavior
Calculator doesn't crash
Device and Application Information

Application Version: 10.2005.23.0

Additional context
Repro rate: 50% to 75%
Requested Assignment
I'm just reporting this problem.  I don't want to fix it.

This is your friendly Microsoft Issue Bot. I created this issue automatically as requested by a team member.

@grochocki Yes, this issue also occurs on my PC.

The repro steps can be simplified to:

Ensure the 1st instance of Calculator is opened in Standard mode.
i.e. If not, switch it to Standard mode, close it and reopen it.
Open the 2nd instance and it should be in the same mode (Standard) as the 1st instance.
Switch the 2nd instance to Scientific or Programmatic mode and then close the 2nd instance.
Open the 3rd instance and crash happens.

The repro rate is nearly 100%.

I can't seem to reproduce this issue on Windows 11, application version: 11.2403.6.0. Could this have been fixed? Can someone confirm?


Double click an operator to focus the graph on them

https://www.reddit.com/r/Rainbow6/comments/aam9o2/this_is_a_site_i_made_showing_how_different/ectliik/?context=3

Need to think carefully about how to unfocus from an operator to view the whole graph again
Make irrelevant relationships/operators translucent or darker?
Need to experiment with:

Double click to focus on a relationship/operator?
Hover to focus on a relationship/operator (tap on mobile)?
Tap/single click to focus on a relationship/operator?

https://bl.ocks.org/almsuarez/4333a12d2531d6c1f6f22b74f2c57102

@J-888 made a really good concept for how it should look: https://imgur.com/fDzguF0

Heyo, gonna give this a shot. Wish me luck.

Sounds good, best of luck @schang1146 :)

Hey @schang1146, are you still interested on working on this issue at some stage? 😊
There is absolutely no pressure to say yes or no btw. Just thought I'd check in! :)

Have to say probably not at the moment, busy with some stuff and won't have the chance to work on it. Sorry!


Multimon primary monitor or command line descision

I tried to address the issue of #3439 and some more of the multimonitor / primary monitor problems for myself.
The FreeRDP code makes always a fallback to 0,0 since the primary monitor is always not found.
My fix may be still work in progress and I don't know if it is as FreeRDP intended this. But I am open for advice how to do it properly.
Currently I look up what the user specified on the command line with /monitors:x,y... and take x as the default monitor (primary). If no command line option was given I use the default monitor which I get with
screen = DefaultScreenOfDisplay(xfc->display);
monitor_index = XScreenNumberOfScreen(screen);

and last we try to make a fallback to 0,0 if still no monitor was found (I heard that it is a thing in newer *nix versions that there is no primary monitor set).
In my tests on ubuntu 15.10 / xfce4:
/monitors:0, /monitors:1, /monitors:1,0 /multimon:force (our server does not advertise multimonitor),  /monitors:0,1 /multimon:force or /multimon:force only - did work.
(PS: I don't know how the Merge pull requests ended up in this PR ... maybe we have to cherry-pick 827cb5cc63505ca967c503f930268ad8a0a91278)

Hi Kai, could you cleanup your git history to remove merge commits ?

Closed, I redid my history.

@T3N4K4 Did you delete this branch by accident or don't you want to merge your changes anymore?