Shuffle doesn't appear to work

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
Python release (python3 --version):
Component/platform:
Description of problem:
Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:

Hi there,
I wanted to use the shuffle button built into the mini media player card for lovelace, but it appears that this integration is not in this component, though it is supported by itunes-api.  Any chance to add it?


Can't see "approve or deny any pending permission request" on SharePoint Admin Center

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
Display this  pop up window before deployment that indicates solution package requires permissions approval:

Observed Behavior
The pop up window doesn't show up and the deployment shows error message:

Steps to Reproduce
Follow this tutorial: https://docs.microsoft.com/en-us/sharepoint/dev/spfx/use-aad-tutorial
Also, I don't see any of the following on my SharePoint Admin Center:

What I see on my SharePoint Admin Center is:

Also, one thing I noticed is that I am able to see pop up window after removing the following from config/package-solution.json file:
"webApiPermissionRequests": [
{
"resource": "Microsoft Graph",
"scope": "User.ReadBasic.All"
}
]
But, by removing this, I see the following error on running gulp serve --nobrowser:

SPFx version: 1.4.1
Please let me know if you need additional details. Thanks!

An update on this. After updating release preferences to targeted release for everyone (Microsoft 365 admin center -> Settings -> Organizational Profile -> Release preferences), I am able see approval page. After approval, I ran gulp serve --nobrowser, I get this error:

On selecting cancel, I get an additional error:

On selecting OK, the app crashes and refreshes. Please let me know if there are any addtional settings I need to do. Thanks!

Could it be related to this?
https://github.com/AzureAD/azure-activedirectory-library-for-js/issues/580

@mcmynn83 Thanks for your suggestion. Tried one approach. Because I am not able to remove accounts not required, I tried opening the browser in incognito window. Now, I don't get any error. I see the following:

@licypal - It sounds like the issue is fixed that this was opened up for.  Please let me know and I will close the issue, or specify exactly what is still wrong.

@mcmynn83 Thank you, you can close this issue. Created a new issue with what I need solution for: https://github.com/SharePoint/sp-dev-docs/issues/2390.


There is a new error after executing "Extract Parameter" action for a "type" string inside the errors.json template file

OS: All
Build Version: 20201120.3
Repro Steps:

Open the errors.json template file in VS Code -> Place the cursor inside the "type" string somewhere inside the "resources" section of a template -> Click the lightbulb -> Click "Extract Parameter..." -> Type a parameter name -> Type a description.
Check whether there is a new error or not.

Expect:
There is no new error.
Actual:
There is a new error.

Template validation failed: The template resource '[parameters('automationAccountName')]' at line '84' and column '36' is not valid. The type property cannot be an expression. Please see https://aka.ms/arm-template/#resources for usage details.

More Info:

This issue doesn't reproduce for other template files.
This issue also reproduces for object-variable-properties.json template file.

This issue also reproduces after executing "Extract Variable..." action.
The error message does not correspond to the error location if this error is by design.

@jorgecotillo This didn't used to be required, right?  Is this a change?

This is an expected error - see this note in the testcase:

Ideally we shouldn't show the lightbulb for extract inside this string, but that works is probably not worth the effort.  Thx.

This is an expected error - see this note in the testcase:

Ideally we shouldn't show the lightbulb for extract inside this string, but that works is probably not worth the effort.  Thx.


IC | Enhancements of KITs due to new / enhanced standards

Description
We plan to enhance some of our existing standards. This will also result in corresponding adaptions of the Industry Core KIT. Currently it is not yet clear which standard changes will make it into rel. 24.12.
In addition, it might be necessary to adapt the KIT to the new framework policy.
Impact

Additional information

[ ] I'm willing to contribute to this feature

Presented in the DRAFT Feature Freeze -> Committer is needed

Closed by NSC because no progress. Please reopen and assign an upcoming release if needed.


Unclear statement or typo

Line 391 in in IUA.b, Rev.1.2 from September 21, 2019, states:
A user with a mobile device wishes to retrieve a medical document to which they have authorized access.
It's not clear who or what is meant with they.

cleaned up the examples to clear the terms used as discussed in the July F2F meeting.


Abstracts the pie chart originally used in smn/Pets and later stolen borrowed in mch and mnk into a shared UI component so everyone can use it without breaking shit by referencing SMN's CSS.
This also comes with a lovely bonus of like 19 new files because ~ typescript css module definitions ~. Woo.
CC @Kovensky, @Toastdeib, and @ayyaruq
Bonus points for anyone who can be bothered trying to sort out whatever causes the build to fail if the definitions aren't there. Would be good to be able to ignore 'em.

Having taken a look over this, I have nothing meaningful to contribute to the review. Everything looks fine as far as I can tell.
 Typescript pls.


Adding signature and recipient's public key to whisper envelope

These two options are useful for identifying to whom was the whisper message directed, and what's the pubKey that signed the message.
https://web3js.readthedocs.io/en/1.0/web3-shh.html#notification-returns

fixed commit message. merging.


initial load

Kha is loading several assets before giving control.
This includes shaders and the project.kha file itself
Could these be embeded in the js file ?
These would alow the website to easily control when the game is loaded (before its extra loading takes place) and this would also limit the number of http connections.

I've noticed the same thing when building on Flash. Is this behavior normal? I would have thought the assets got packaged in with the SWF.

Yes, that's completely normal. For Flash you can use the the --embedflashassets option (in theory - in pratice I recently broke that (see https://github.com/KTXSoftware/khamake/issues/14) but will be back in few days and in 15.9).
The assets Kha loads at the start are the shaders. Embedding that in js seems reasonable, will do.

@RobDangerous Thanks for the info! I'm glad you mentioned the shaders. After copying my project.kha file to address that error I got another about a null reference.
TypeError: Error #1009: Cannot access a property or method of a null object reference.
at kha.graphics4::FragmentShader()
at kha.graphics4::ImageShaderPainter/initShaders()
at kha.graphics4::ImageShaderPainter()
at kha.graphics4::Graphics2()
at kha.flash.graphics4::Graphics2()
at kha::Starter/onReady()

I don't understand, what did you do to project.kha and what error did you try to address by doing so?

@RobDangerous When I built the flash build my project.kha did not get copied / created in the build directory so I got the following error:
Error #2044: Unhandled ioError:. text=Error #2032: Stream Error. URL: file:///D|/Work%20Files/Haxe/Game/build/flash/project.kha
at kha.flash::Loader/loadBlob()
at kha::Loader/loadFiles()
at kha::Loader/loadProject()
at kha::Starter/start()
at Main$/main()
at boot_ffe6/init()
at flash::Boot/start()
at boot_ffe6()
After copying the project.kha to the build directory the above error went away then I got the TypeError: Error #1009 above.

Well, that won't work, project.kha isn't just copied to the build dir, every system gets a specialized version of that file.
Do you use any special parameters when running khamake? What's the output of calling it? Do you use the Kha or the haxelib version?

@RobDangerous Interesting....I just rebuilt the project to post the output and now everything is working. Last night I did resync with the repo so maybe something changed? My directory structure is as follows after the build:
GameRoot
|Assets
|build
|-flash
|--kha.swf
|--*.agal
|--project.kha
|-project-flash-intellij
|-temp
|-project-flash.hxml
|-project-flash.hxproj
|Kha
|Sources
|project.kha
My Assets directory didn't get copied but I haven't added it to the project.kha yet....

That's kinda strange. Please inform me, when you run into the problem again.
Files look good. Assets are only exported when they are listed in project.kha. You can auto-add everything in Assets with --addallassets.

With the recent changes some of this have been addressed but I think we can have something even better:

an option to not load Graphics2 shaders (maybe even disabling the Graphics2 api at compile time so to not hit an issue at runtime). This way for game that do not require it, it can load faster

option to embed some assets/font to allow for a minimal loading screen

Did you do any tests on how much that would actually help? Not sure it's worthwhile, those shaders are tiny.

There is already an issue about asset-embedding.

you are right, this is nothing

great


Improve composites

Use asserts and improve the code for running the children.

Use iterator instead of index: https://github.com/aigamedev/btsk/blob/8124c3e73719a05638a053782a749d039ae7cedf/BehaviorTree.cpp#L215

Solved.


Implementing a PSI visualisation in Typescript

Hello 👋
This is my first issue on a public project 😅
I hope to do well and that I don't say anything stupid.. haha
Is your feature request related to a problem? Please describe.
I've been using Material Icons for about a year now and I'm very happy with it, it's a nice change from the horrible things that are offered by default when you install the IDE.
However, as someone who codes a lot in PHP & Typescript, I'm a bit disappointed with the PSI support for TypeScript.
An abstract class is not supported on the TypeScript side while on the PHP side it is... and the visual when you manipulate a lot of files, it's quite important, as much as the name of the files!
Do you think PSI integration is possible for Typescript? 🥺
Describe the solution you'd like
I don't think there is any need to reinvent the world for this kind of thing, if I take what is done on the PHP side, we should adapt the colour to the TypeScript graphic charter

Describe alternatives you've considered
Well, after reading a bit of documentation, the only possible alternative would be to import icons and have the selection done on the file name, but that seems to me to be an overkill solution because there is already a PSI system for PHP and it would be enough to transpose it to other languages.
Additional context
Euh.. ❤🇫🇷

I was curious about this, so I looked into it a bit.
Looks like what icon gets dealt is probably dependent on what the language plugin parses/recognizes.
I created a Kotlin file and added a single abstract class into it, and also added a empty Kotlin file. When the IDE first starts up both files are recognized as a plain Kotlin file (PsiFile). However, later on, the file with the abstract class gets recognized as a class (KtClass).
I did the same thing with typescript, and both of the files remain recognized as JSFileImpl (which is a PsiFile). Looks like the Typescript support (atleast for the bundled intellij ultimate) doesn't treat them the same, so they all get the same file icon. So I guess without having special names for the file & creating an association, we'd need the typescript language plugin to recognize the file with an abstract class as another type of PsiElement.
That being said, I'm just an outsider looking in at a black box and assuming things work the way they do, so take it with a grain of salt.

This is something I wanted from day one, but alas it's not something available out of the box, and if some implementation is needed, it's definitely not something that should be done within the scope of this plugin.
In my opinion, it wouldn't make sense in JavaScript as files can be represented in many ways:

IIFE
module.exports
class(es)
angular module
list of exported elements
etc

Also, it depends on the framework/libraries. The contents of a file can vary a lot, it could be eslint.js, gulpfile.js, app.js, server.js... and don't get me started on the index.js which can serve many purposes.
Truly, to bother parsing the files in order to detect what kind of psi elements are in there are most of the time completely useless. It could make sense in well-defined frameworks such as Angular or Nest, but it's an exception to the rule. Relying on the extension is usually the rule of thumb here, the aforementioned frameworks advise on that, and other frameworks recommend to do the same (Redux, RxJS, etc). But its' seldom enforced and still not enough reason to do so.
BTW, next time please open a Discussion for this, not a bug. Thanks


Vulkan: Alpha scissor/test material has pixel Z-order issues

Godot version
4.0 ed395c6b99915809347a87b0d65220c256d6ec3f
System information
Windows 10 64 bits GLES3 GeForce GTX 1060 6GB/PCIe/SSE2
Issue description
When I use an alpha clip material for foliage, I expect it to behave like an opaque material, going through the opaque rendering pass, so it should not have Z-ordering issues in its pixels. However it looks like it does have that typical issue:

Steps to reproduce

Create a mesh made of two intersecting quads (or make two separate quads), typical setup for classic grass
Create a new StandardMaterial3D with transparency set to Alpha Clip and an albedo texture.
Assign the material to the mesh instances.
Observe they completely disappear with Vulkan errors. I assume that's a different issue. Close the scene and reopen it. Observe the clipping issue.

Minimal reproduction project
AlphaClip.zip

The MRP can no longer be opened in Alpha13. However Alpha Scissors no longer has this issue with z-order. There are other z-order issues in the pipeline and I'll open another ticket, but it's no longer present here.


Remove translate3d from list and use css will-change property

@alexandrudima I've completely removed canUseTranslate3d from vs/base/browser/browser.ts.

Had to reopen due to extra painting detected after this change.


Additional routes

What

Create different route tables for the each public subnet
Add ability to create different additional routes into public and private route tables

Why

We need this features in order to resolve legacy routes issue
Enhancement this module

Module doesn't work if we use resource in additional_routes_private.
  additional_routes_private = [
    {
      cidr_block = "<IP_ADDRESS>/24",
      gateway_id = "${aws_vpn_gateway.default.id}"
    },
    {
      cidr_block = "<IP_ADDRESS>/24",
      gateway_id = "${aws_vpn_gateway.default.id}"
    },
    {
      cidr_block = "<IP_ADDRESS>/24",
      gateway_id = "${aws_vpn_gateway.default.id}"
    },
    {
      cidr_block = "<IP_ADDRESS>/24",
      gateway_id = "${aws_vpn_gateway.default.id}"
    }
  ]

Terraform apply on the test environment:

Terraform plan after apply:

closing it since it's very old and the module has been updated many times since then


Upgraded to Poetry to Improve Dependency Management

Upgraded to Poetry to Improve Dependency Management + Code Cleanup
What user problem are we solving?
Currently, our Python backend strongly depends on Anaconda for environment and package management, resulting in a lack of separation between development and production environments. This creates challenges in maintaining and replicating the exact dependencies required for each environment.
What solution does this PR provide?
This pull request introduces the use of Poetry as a Python package manager tool to better define our development and production dependencies. By adopting Poetry, we can achieve better separation between the two environments and simplify the management of dependencies. In addition, this sped up build checks from 30mins to 5 mins. This migration also allows for venv caching as well.
The key changes in this PR include:
Created a pyproject.toml file in the poetry branch, which serves as the configuration file for Poetry.
Populated the pyproject.toml file with the necessary dependencies, both for development and production modes. The dependencies were inspired by the existing conda/environment.yml or requirements.txt files.
Updated the Python build check in the GitHub Actions workflow to use Poetry for environment setup. This ensures that the correct dependencies are installed during the CI/CD process.
Updated the Dockerfiles to use Poetry for environment setup. This ensures consistency between local development and deployment environments.
Ensured that installing Python dependencies updates the pyproject.toml file automatically. This eliminates the need to manually add dependencies to the conda/environment.yml file or requirements.txt.
Code Cleanup
Also some minor code cleanup occurred with the wiki.tsx file. The path names were wrong and directly needed the entire path when accessing the png file. So, import statements were deleted and path names were directly implemented in the code. Also the learn.tsx file was deleted as it was blank and not in use.
Testing Methodology
How did you test your changes and verify that existing
functionality is not broken
To test these changes and verify that existing functionality is not broken, the following steps were taken:
Checked out the poetry-setup branch locally and ensured that Poetry was installed.
Built and ran the backend application locally using Poetry for environment setup. Confirmed that the application started successfully and all existing functionality was working as expected.
Triggered the CI/CD pipeline using the GitHub Actions workflow and verified that the build process completed without errors.
updated Docker files with the new Poetry-based environment setup and tested using docker build.
Requested feedback and conducted code reviews with team members to validate the changes and address any potential issues.
Any other considerations
Update documentation and ReadME files + we need to gitignore poetry.lock
add pre-commit hooks in poetry to make sure poetry.lock and pyproject.toml are correctly in sync

no python-package-conda.yml action
no requirements.txt
no conda/environment.yml (conda deprecation)
update installation script in package.json at the root
update dockerfiles (train dockerfile + Dockerfile)
update readme to describe how to get setup on poetry (and add resource on pyenv to get the right python version)
add pre-commit hooks in poetry to make sure poetry.lock and pyproject.toml are correctly in sync
pre-commit hooks of interest to add are: poetry-check, poetry-lock. Learn more
How to build pre-commit hooks into github: Here
Precommit YAML file to add to: Here
make sure to add logger to the list of packages as we just added it

poetry-setup branch is not in use anymore. please update pr description? @codingwithsurya

you didnt actually deploy docker containers in your testing. all you did was build dockerfiles and run them with docker run

youll also want to explain the purpose of cleaning up imports in wiki.tsx and remove learn.tsx
maybe these import cleanups should be its own mini pr for better tracking!

youll also want to explain the purpose of cleaning up imports in wiki.tsx and remove learn.tsx
maybe these import cleanups should be its own mini pr for better tracking!

Let's just put this in the title and make it clear that we did some code cleanup for better tracking. Otherwise, as u saw before, i'm going to have to re-do all my changes to poetry branch.

so we are just lumping cleanup wirh poetry to save time? @codingwithsurya

so we are just lumping cleanup wirh poetry to save time? @codingwithsurya

yep. thats fine, right? we wanna get this out ASAP.

so we are just lumping cleanup wirh poetry to save time? @codingwithsurya

yep. thats fine, right? we wanna get this out ASAP.

considering the complexity of the extra cleanup, you're good. you can keep working on this PR

@codingwithsurya I tested your poetry setup on my end. I got it to work for windows! backend and frontend spin up perfectly fine.

@farisdurrani this PR can be merged contingent on the following

My PR gets merged into this branch
You test the poetry setup on your branch

I had to run the command poetry env use $(pyenv which python) to get poetry to use the version of python that I installed through pyenv to match the toml file python version requirements, anyone else?

so you need to use the latest version of python 3.9 in order for poetry install to work @dwu359

I had to run the command poetry env use $(pyenv which python) to get poetry to use the version of python that I installed through pyenv to match the toml file python version requirements, anyone else?

so you need to use the latest version of python 3.9 in order for poetry install to work @dwu359

So I ran
pyenv install 3.9
pyenv local 3.9
yarn startb

And that gave me an error unless I created a new poetry virtual env specifying the specific pyenv install for python 3.9

I also ran into an error when building the docker image from Dockerfile: Type error: '"@/features/Train/redux/trainspaceApi"' has no exported member named 'useGetColumnsFromDatasetQuery'. Did you mean 'useLazyGetColumnsFromDatasetQuery'?
Someone probably forgot to change the names to match in a previous pr, shouldn't be hard to fix

Would it be a good idea to have two separate poetry environments, one for the backend, and one for backendCore btw? We already have two separate docker files for each

Would it be a good idea to have two separate poetry environments, one for the backend, and one for backendCore btw? We already have two separate docker files for each

that would be a good idea. if we know what deps are used on backend/ vs. backendCore, we can make the builds probably more optimized?

@codingwithsurya can you please add poetry shell at the beginning of the yarn run installb instruction?

@codingwithsurya can you please add poetry shell at the beginning of the yarn run installb instruction?

added it in. Can you check @farisdurrani

I also ran into an error when building the docker image from Dockerfile: Type error: '"@/features/Train/redux/trainspaceApi"' has no exported member named 'useGetColumnsFromDatasetQuery'. Did you mean 'useLazyGetColumnsFromDatasetQuery'? Someone probably forgot to change the names to match in a previous pr, shouldn't be hard to fix This error was caused by the ImageParametersStep btw

I also ran into an error when building the docker image from Dockerfile: Type error: '"@/features/Train/redux/trainspaceApi"' has no exported member named 'useGetColumnsFromDatasetQuery'. Did you mean 'useLazyGetColumnsFromDatasetQuery'? Someone probably forgot to change the names to match in a previous pr, shouldn't be hard to fix This error was caused by the ImageParametersStep btw

updated that @dwu359

@codingwithsurya can you please add poetry shell at the beginning of the yarn run installb instruction?

already added

as of saturday evening, everything works except docker builds/runs. Need some help on this.

as of saturday evening, everything works except docker builds/runs. The dockerfiles currently committed are a draft and need to be changed. Need some help on this. @karkir0003 @farisdurrani @dwu359
also for some reason my docker builds take insanely long (15-20 mins) so need to figure out how to speed up the process.

What happens when you try to build a docker image?

as of saturday evening, everything works except docker builds/runs. The dockerfiles currently committed are a draft and need to be changed. Need some help on this. @karkir0003 @farisdurrani @dwu359
also for some reason my docker builds take insanely long (15-20 mins) so need to figure out how to speed up the process.

What happens when you try to build a docker image?

same. I tried making some updates/fixes to Dockerfile. The build takes pretty long, but the image size is like 12 GB on docker desktop. was wondering how we can optimize this. Thoughts @dwu359

as of saturday evening, everything works except docker builds/runs. The dockerfiles currently committed are a draft and need to be changed. Need some help on this. @karkir0003 @farisdurrani @dwu359
also for some reason my docker builds take insanely long (15-20 mins) so need to figure out how to speed up the process.

What happens when you try to build a docker image?

So TrainingDockerFile built just fine but for the regular dockerfile we initially were facing errors with the path in yarn run secrets command. We fixed that and we were trying to re-test but dockerbuild was taking sooooo long (like around 20 mins or so). We were already 4-5 hours into working so at that point we were kinda tired and didn't keep trying to see if the test worked. I wonder if docker runs faster on your guys's machines.

as of saturday evening, everything works except docker builds/runs. The dockerfiles currently committed are a draft and need to be changed. Need some help on this. @karkir0003 @farisdurrani @dwu359
also for some reason my docker builds take insanely long (15-20 mins) so need to figure out how to speed up the process.

What happens when you try to build a docker image?

So TrainingDockerFile built just fine but for the regular dockerfile we initially were facing errors with the path in yarn run secrets command. We fixed that and we were trying to re-test but dockerbuild was taking sooooo long (like around 20 mins or so). We were already 4-5 hours into working so at that point we were kinda tired and didn't keep trying to see if the test worked. I wonder if docker runs faster on your guys's machines.

@codingwithsurya I was able to get Dockerfile to build on my machine. Had to make some minor fixes

I'm testing docker build -t train -f TrainingContainer.Dockerfile . ... @codingwithsurya

as of saturday evening, everything works except docker builds/runs. The dockerfiles currently committed are a draft and need to be changed. Need some help on this. @karkir0003 @farisdurrani @dwu359
also for some reason my docker builds take insanely long (15-20 mins) so need to figure out how to speed up the process.

What happens when you try to build a docker image?

So TrainingDockerFile built just fine but for the regular dockerfile we initially were facing errors with the path in yarn run secrets command. We fixed that and we were trying to re-test but dockerbuild was taking sooooo long (like around 20 mins or so). We were already 4-5 hours into working so at that point we were kinda tired and didn't keep trying to see if the test worked. I wonder if docker runs faster on your guys's machines.

@codingwithsurya I was able to get Dockerfile to build on my machine. Had to make some minor fixes

oh nice man! what were the changes?

lemme push it real quick. minor ordering of the commands

now the catch was that i didnt do a docker run. it took so long to see if it worked on my end.

now the catch was that i didnt do a docker run. it took so long to see if it worked on my end.

so both trainingdockerfile and dockerfile builds work now?

now the catch was that i didnt do a docker run. it took so long to see if it worked on my end.

yea no worries , it takes ages. docker run is pretty slow too. might just put a movie on to pass the time lol

@codingwithsurya pushed some of my changes/fixes for poetry

@codingwithsurya pushed some of my changes/fixes for poetry

awesome. good thought on switching to root directory right before COPY ..
and all the consecutive commands cd to backend

@codingwithsurya pushed some of my changes/fixes for poetry

awesome. good thought on switching to root directory right before COPY ..
and all the consecutive commands cd to backend

can you give the docker build a try for Dockerfile and make sure the docker run works as intended. Also, im trying to test docker build for TrainingContainer.Dockerfile. Getting some frustrating connection pool timed out error from pypy when the poetry install is running

@codingwithsurya i got TrainingContainer.Dockerfile to build successfully.

@dwu359 potential tool for finding unused deps for our pyproject.toml files
https://github.com/fpgmaas/deptry

@dwu359 potential tool for finding unused deps for our pyproject.toml files
https://github.com/fpgmaas/deptry

https://fpgmaas.github.io/deptry/rules-violations/

@dwu359 potential tool for finding unused deps for our pyproject.toml files
https://github.com/fpgmaas/deptry

Hmm yeah it does seem like something that would be neat to add to one of our GitHub workflows

@dwu359 potential tool for finding unused deps for our pyproject.toml files
https://github.com/fpgmaas/deptry

Hmm yeah it does seem like something that would be neat to add to one of our GitHub workflows

not sure if this library is good enough. I was trying to see if it has decent github star count + fairly recent commits to see if the repo is actively maintained


Spring Cloud Netflix build broken with releaser

Since it is now a two step build (build contract modules, then back to root and build). We've updated CI, but now I have to do things by hand.

I did the contract build my self, then am reruning releaser with 3- option to build and run everything else.

Hmm you shouldn't be needing to do that. Just remember to run it with the config option.
$ java -jar ~/repo/spring-cloud-release-tools/spring-cloud-release-tools-spring/target/spring-cloud-release-tools-spring-1.0.0.BUILD-SNAPSHOT.jar --releaser.pom.branch=vDalston.SR1 --spring.config.name=releaser

It will automatically call the proper script - https://github.com/spring-cloud/spring-cloud-netflix/blob/master/config/releaser.yml#L3

Does the jenkins releaser do that?

yup https://github.com/spring-cloud/spring-cloud-jenkins-jobs/blob/master/src/main/groovy/org/springframework/jenkins/cloud/release/SpringCloudReleaseMaker.groovy#L85


Yoga: Bump up Ubuntu repo versions

Such change is a great candidate to be automated with periodic workflow.

Such change is a great candidate to be automated with periodic workflow.

Except for the fact that (on CentOS at least) we typically spend many days doing multinode testing to validate the update...
We've only just added these repo versions for Ubuntu, so probably the changed packages will be quite few, and this should be fairly safe (plus Ubuntu is inherently more stable than stream)

Such change is a great candidate to be automated with periodic workflow.

Except for the fact that (on CentOS at least) we typically spend many days doing multinode testing to validate the update...
We've only just added these repo versions for Ubuntu, so probably the changed packages will be quite few, and this should be fairly safe (plus Ubuntu is inherently more stable than stream)

I think we could be more safe generally with Ubuntu and Rocky 9 automated periodic promotion workflows - and leave the Stream ones as a manual job.

Such change is a great candidate to be automated with periodic workflow.

Except for the fact that (on CentOS at least) we typically spend many days doing multinode testing to validate the update...
We've only just added these repo versions for Ubuntu, so probably the changed packages will be quite few, and this should be fairly safe (plus Ubuntu is inherently more stable than stream)

I think we could be more safe generally with Ubuntu and Rocky 9 automated periodic promotion workflows - and leave the Stream ones as a manual job.

Ok, but do we now need to rebuild all the containers to match?

Such change is a great candidate to be automated with periodic workflow.

Except for the fact that (on CentOS at least) we typically spend many days doing multinode testing to validate the update...
We've only just added these repo versions for Ubuntu, so probably the changed packages will be quite few, and this should be fairly safe (plus Ubuntu is inherently more stable than stream)

I think we could be more safe generally with Ubuntu and Rocky 9 automated periodic promotion workflows - and leave the Stream ones as a manual job.

Ok, but do we now need to rebuild all the containers to match?

match as in one tag for all? well, that's simplicity, right?

Such change is a great candidate to be automated with periodic workflow.

Except for the fact that (on CentOS at least) we typically spend many days doing multinode testing to validate the update...
We've only just added these repo versions for Ubuntu, so probably the changed packages will be quite few, and this should be fairly safe (plus Ubuntu is inherently more stable than stream)

I think we could be more safe generally with Ubuntu and Rocky 9 automated periodic promotion workflows - and leave the Stream ones as a manual job.

Ok, but do we now need to rebuild all the containers to match?

match as in one tag for all? well, that's simplicity, right?

Match as in having the same packages in the host OS & images.

Such change is a great candidate to be automated with periodic workflow.

Except for the fact that (on CentOS at least) we typically spend many days doing multinode testing to validate the update...
We've only just added these repo versions for Ubuntu, so probably the changed packages will be quite few, and this should be fairly safe (plus Ubuntu is inherently more stable than stream)

I think we could be more safe generally with Ubuntu and Rocky 9 automated periodic promotion workflows - and leave the Stream ones as a manual job.

Ok, but do we now need to rebuild all the containers to match?

match as in one tag for all? well, that's simplicity, right?

Match as in having the same packages in the host OS & images.

Does it ever fully match on a production deployment? I doubt that - maybe on day one it does.

Such change is a great candidate to be automated with periodic workflow.

Except for the fact that (on CentOS at least) we typically spend many days doing multinode testing to validate the update...
We've only just added these repo versions for Ubuntu, so probably the changed packages will be quite few, and this should be fairly safe (plus Ubuntu is inherently more stable than stream)

I think we could be more safe generally with Ubuntu and Rocky 9 automated periodic promotion workflows - and leave the Stream ones as a manual job.

Ok, but do we now need to rebuild all the containers to match?

match as in one tag for all? well, that's simplicity, right?

Match as in having the same packages in the host OS & images.

Does it ever fully match on a production deployment? I doubt that - maybe on day one it does.

I expect it does mostly currently, because we don't update the repos often


Updated version with more detail on Azure SGX / DCAP / TCB

I reviewed the docs here which were the things we might salvage, but the docs explain how to validate if the tcb and dcap verifier are on chain. considering our docs mainly point people to either use our neutron deployment (in which case they won't have to verify since we already know they exist) or else do mock sgx, I don't think we need to put these back into the docs. if we need it in the future (say we start to recommend people to deploy their own tcb and dcap), we can pull this message documentation the PR:
You can verify that the `dcap-verifier` in instantiated by running:
```bash
   # Export all variables
   export DCAP_CODE_ID="7095"
   export TCBINFO_CODE_ID="7094"
   # Query DCAP_CODE_ID to get the contract address and export it to a local variable
   neutrond --node $NODE_URL query wasm list-contract-by-code "$DCAP_CODE_ID" --output json | jq -r '.contracts[0]'
   export DCAP_CONTRACT=$(neutrond --node $NODE_URL query wasm list-contract-by-code "$DCAP_CODE_ID" --output json | jq -r '.contracts[0]')

You can also verify that the tcbinfo contract is instantiated by running:
   # Query TCBINFO_CODE_ID to get the contract address and export it to a local variable
   neutrond --node $NODE_URL query wasm list-contract-by-code "$TCBINFO_CODE_ID" --output json | jq -r '.contracts[0]'
   export TCBINFO_CONTRACT=$(neutrond --node $NODE_URL query wasm list-contract-by-code "$TCBINFO_CODE_ID" --output json | jq -r '.contracts[0]')

We have currently instantiated the following FMSPC "00606A000000", you can verify by queryint the contract state:
neutrond --node $NODE_URL query wasm contract-state smart "$TCBINFO_CONTRACT" '{"get_tcb_info": {"fmspc": "00606A000000"}}'


Migrating deprecated terminal shell settings didn't do what I would expect

Testing #124836
With the following settings:
{
	"terminal.integrated.defaultProfile.windows": "PowerShell",
    "terminal.integrated.shell.windows": "cmd.exe",
	// "terminal.integrated.shellArgs.windows": []
}

I saw the terminal migration notification and then clicked "Migrate", and my settings changed to:
{
    "terminal.integrated.defaultProfile.windows": "Generated",
	// "terminal.integrated.shellArgs.windows": []
}

Which is defintely not what I expected to happen.

Perhaps if the shell/shellArgs match one of the detected profiles, the name of that profile can be used?
So in the sample above, terminal.integrated.defaultProfile.windows: Command Prompt

I'm also kinda confused by this... here's what I had:
{
    "terminal.integrated.shell.linux": "/snap/powershell/160/opt/powershell/pwsh",
    "terminal.integrated.shellArgs.linux": [
        "-Login"
    ],
    "terminal.integrated.profiles.linux": {
        "bash": {
            "path": "bash"
        },
        "zsh": {
            "path": "zsh"
        },
        "fish": {
            "path": "fish"
        },
        "tmux": {
            "path": "tmux",
            "icon": "terminal-tmux"
        },
        "pwsh": {
            "path": "pwsh",
            "icon": "terminal-powershell"
        }
    },
    "terminal.integrated.defaultProfile.linux": "pwsh"
}

and it turned it into:
{
    "terminal.integrated.profiles.linux": {
        "bash": {
            "path": "bash"
        },
        "zsh": {
            "path": "zsh"
        },
        "fish": {
            "path": "fish"
        },
        "tmux": {
            "path": "tmux",
            "icon": "terminal-tmux"
        },
        "pwsh": {
            "path": "pwsh",
            "icon": "terminal-powershell"
        }
    },
    "terminal.integrated.defaultProfile.linux": "Generated"
}

The behavior should be:

If there is an exact match (eg. just cmd.exe), it should assign the existing profile as the default ("Command Prompt").
If there is not an exact match (eg. pwsh -Login), it should add the profile to the list and set it as the default. As for the name maybe something like ${basename(path)} (migrated) would be best.

To verify, see https://github.com/microsoft/vscode/pull/125352#issue-660462095 and try other combinations

@eamodio or @TylerLeonhardt could you pls verify this?

@meganrogge with the following:
"terminal.integrated.shell.osx": "/Users/tyleonha/.powershell-daily/pwsh",
    "terminal.integrated.shellArgs.osx": [
        "-Login"
    ],
    "terminal.integrated.profiles.osx": {
        "bash": {
            "path": "bash",
            "args": [
                "-l"
            ],
            "icon": "terminal-bash"
        },
        "zsh": {
            "path": "zsh",
            "args": [
                "-l"
            ]
        },
        "fish": {
            "path": "fish",
            "args": [
                "-l"
            ]
        },
        "tmux": {
            "path": "tmux",
            "icon": "terminal-tmux"
        },
        "pwsh": {
            "path": "pwsh",
            "icon": "terminal-powershell"
        },
        "pwsh (2)": {
            "path": "/Users/tyleonha/.powershell-daily/pwsh"
        }
    },
    "terminal.integrated.defaultProfile.osx": "pwsh (2)"

I don't get a notification. Is that expected?

If you've already said don't show again to the notification in that workspace, yes.

@meganrogge ah... I hit the x which didn't show the notification until I reloaded the window.

@TylerLeonhardt that was another fix that went in to make sure we're not annoying

Migration doesn't seem to be working for me. Here's a gif:

These are the same settings as here https://github.com/microsoft/vscode/issues/125177#issuecomment-856115201

Ah looks like if I already define terminal.integrated.profiles.osx then this migration doesn't work. If I delete that setting (and use zsh instead as the default profile, the migration works.

Meaning if you set the defaultProfile to the name of a profile that already exists within your profiles.osx it doesn't work? I think that's by design.

Gotcha. The only thing I'll mention is this, with a terminal.integrated.profiles.osx defined does not prompt me:
    "terminal.integrated.shell.osx": "/Users/tyleonha/.powershell-daily/pwsh",
    "terminal.integrated.shellArgs.osx": [
        "-Login"
    ],
    "terminal.integrated.profiles.osx": {
        "bash": {
            "path": "bash",
            "args": [
                "-l"
            ],
            "icon": "terminal-bash"
        },
        "zsh": {
            "path": "zsh",
            "args": [
                "-l"
            ]
        },
        "fish": {
            "path": "fish",
            "args": [
                "-l"
            ]
        },
        "tmux": {
            "path": "tmux",
            "icon": "terminal-tmux"
        },
        "pwsh": {
            "path": "pwsh",
            "icon": "terminal-powershell"
        },
        "pwsh (2)": {
            "path": "/Users/tyleonha/.powershell-daily/pwsh"
        }
    },
    "terminal.integrated.defaultProfile.osx": "bash",

but this without it defined does prompt me:
    "terminal.integrated.shell.osx": "/Users/tyleonha/.powershell-daily/pwsh",
    "terminal.integrated.shellArgs.osx": [
        "-Login"
    ],
    "terminal.integrated.defaultProfile.osx": "bash",

I guess I would expect the migration to still happen (and a new profile be added to my existing terminal.integrated.profiles.osx) but maybe that's out of scope.

That seems wrong

@meganrogge ah... just opened dev tools:
ERR Cannot add property /Users/tyleonha/.powershell-daily/pwsh (migrated), object is not extensible: TypeError: Cannot add property /Users/tyleonha/.powershell-daily/pwsh (migrated), object is not extensible
    at Object.run (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2851:102800)

it's working for me on Windows.

https://github.com/microsoft/vscode/pull/125352/files#diff-8df911bf58ca35baec7e0c02b60c36c1dc33694f7a61089ba69adf888c98f466R385

Hmm what does that mean?

Here's a repro on non-Windows without PowerShell:
    "terminal.integrated.shell.osx": "zsh",
    "terminal.integrated.shellArgs.osx": [
        "-l", "-i"
    ],
    "terminal.integrated.defaultProfile.osx": "bash",
    "terminal.integrated.profiles.osx": {
        "bash": {
            "path": "bash",
            "args": [
                "-l"
            ],
            "icon": "terminal-bash"
        },
        "zsh": {
            "path": "zsh",
            "args": [
                "-l"
            ]
        },
        "fish": {
            "path": "fish",
            "args": [
                "-l"
            ]
        },
        "tmux": {
            "path": "tmux",
            "icon": "terminal-tmux"
        }
    },

any errors in dev tools with that repro? or if you turn on trace logging?

Beyond this:
[2021-06-07 10:46:43.443] [renderer3] [error] Cannot add property zsh (migrated), object is not extensible: TypeError: Cannot add property zsh (migrated), object is not extensible
    at Object.run (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2851:102800)

I don't see anything... which Output should I dig into specifically?

Run set log level -> trace -> open developer tools. you should see a migration message. migrated from shell/shellArgs...

I wonder if this could be the issue https://github.com/microsoft/vscode/issues/125177#issuecomment-856135100 @Tyriar

Hmmm I don't see that....only:
TRACE CommandService#executeCommand setContext
log.ts:272 TRACE KeybindingService#dispatch ⌃` workbench.action.terminal.toggleTerminal
log.ts:272 TRACE CommandService#executeCommand workbench.action.terminal.toggleTerminal
log.ts:272 TRACE terminalInstance#ctor (instanceId: 1) Objectargs: (2) ["-l", "-i"]color: undefinedexecutable: "zsh"icon: b {id: "terminal-bash", definition: {…}, description: undefined}useShellEnvironment: true__proto__: Object
log.ts:278 DEBUG Terminal process ready (shellProcessId: 94128)
log.ts:272 TRACE KeybindingService#dispatch ⇧⌘P workbench.action.showCommands
log.ts:272 TRACE CommandService#executeCommand workbench.action.showCommands
log.ts:272 TRACE CommandService#executeCommand workbench.action.toggleDevTools
log.ts:272 TRACE Layout#layout, height: 1415, width: 1289
log.ts:296   ERR Cannot add property zsh (migrated), object is not extensible: TypeError: Cannot add property zsh (migrated), object is not extensible
   at Object.run (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2851:102800)
log.ts:272 TRACE CommandService#executeCommand setContext

The fix here is probably:
const profiles = { ...this._configurationService.inspect<{ [key: string]: ITerminalProfileObject }>(TerminalSettingPrefix.Profiles + platform).userValue } || {};

Even better is marking the type as readonly: Readonly<{ [key: string]: ITerminalProfileObject }>

We might be able to catch this in the future with https://github.com/microsoft/vscode/issues/125690

I don't understand what's going wrong here though - if userValue is undefined, profiles get set to {} already
const profiles = this._configurationService.inspect<{ [key: string]: ITerminalProfileObject }>(TerminalSettingPrefix.Profiles + platform).userValue || {};

I'd think making it readonly would be even worse since then we can't add properties to it - such as the newly created profile

Which works fine, the failure case was when @TylerLeonhardt had profiles set. The Readonly there just corrects the type we're receiving from the config service

ok, should this be a candidate or moved to June?

I think it meets the candidate bar, we really want migration to be solid


Vpc sc allow null for identity type

Hello,
modules/vpc-sc is already supporting null for ingress_policies.identity_type.
This PR adds support for null for egress_policies.identity_type.
Example
This is required for example to implement an egress rule for using Connected sheets with Bigquery for a selected list of identities (refer to [1]).
In the following example, egressFrom.identityType is absent (hence null), and the list of identities is managed through identities.
- egressTo:
    operations:
    - serviceName: 'bigquery.googleapis.com'
      methodSelectors:
      - permission: 'bigquery.vpcsc.importData'
    resources:
    - projects/628550087766 # Sheets-owned Google Cloud project
  egressFrom:
    identities:
    - serviceAccount: sa1@[REDACTED]
    - serviceAccount: sa2@[REDACTED]

As mentioned here [2], the egress_from.identity_type is optional,  specifies the type of identities that are allowed access to outside the perimeter. If left unspecified, then members of identities field will be allowed access.
Changes

updated vpc_sc/variables.tf variables default value & validation
updated the vpc_sc test result for the null capability
tfdoc for vpc_sc
updated fmt for cloudsql-instance/variables.tf (missing a blank line after comment)

References
[1] https://cloud.google.com/bigquery/docs/connected-sheets#vpc-service-controls
[2] https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/access_context_manager_service_perimeter

@LudovicEmo can you provide a code example where the module fails today. The example you listed in (1) doesn't use null but ANY_USER_ACCOUNT

@juliocc

Thanks @LudovicEmo. I left a comment below.
Can you please run tools/tfdoc.py to update the readme?

not sure what is needed here, already updated README with tfdoc in commit 65b32ea

@LudovicEmo can you provide a code example where the module fails today. The example you listed in (1) doesn't use null but ANY_USER_ACCOUNT

@juliocc
The example here: https://cloud.google.com/bigquery/docs/connected-sheets#vpc-service-controls uses identityType: ANY_USER_ACCOUNT.
However the derived example in my description is using a list of identities instead, with the identities list only, identityType in this case mut not be present, hence must be null/absent.

However here we are not opening for any user account, we are controlling the list of identities.

Understood. Thanks for the context, I think it makes sense.

Thanks @LudovicEmo. I left a comment below.
Can you please run tools/tfdoc.py to update the readme?

not sure what is needed here, already updated README with tfdoc in commit 65b32ea

Run it again because the linter is complaining.

Thank you for being thorough and making our job easy! :)


[TorchFix] Add weights_only to torch.load

torch.load without weights_only is a potential security issue (see https://github.com/pytorch/test-infra/pull/4671)
Adding  weights_only=True is potentially unsafe correctness-wise if full pickling functionality is needed, but it should be rare and the tests should catch it (and I changed couple of places to  weights_only=False after the tests failures).
The "unittests-macos (3.8, macos-m1-12)" failure is preexisting.

I guess we could go for this to lead by example, but there is no other benefit to it

@pmeier The thing is that very likely soon weights_only=True will become default in PyTorch.
So specifying appropriate value for weights_only now will also prevent surprises.

However, in all instances in this PR that is not an issue. We have generated the pickled file either dynamically at runtime or statically as part of the repository. Thus, there is no security issue since we are not loading third-party stuff.

I agree that weigths_only should not be a concern for training checkpoints (as they are not persistent), but I would argue that any potentially executable binary code checked into the repository/torch.hub is a security treat and for that codepath I would insist on using the weighs_only
@kit1980 do you mind updating the checkpoint loading path to weigths_only=False as @NicolasHug  suggested or test that it's fine to use True (and mention it in the test plan)

Committed the suggestions by @NicolasHug and rebased the PR.


add min and max information in the decide output for continuous outputs

should also update README.md

All the Readme is still in V1, maybe we should do another PR modifying this in one batch


External Object Index

Allow users to store object index externally so that they don't need to call op.list() to fetch objects list.
For example, databend can store this index into metasrv, and then restore it back.

That's right.
This is @junnplus is working on, we store internal files information to the databend-meta, don't fetch them from underlying object storage with opendal.list.

We can design an IndexLayer which will implement list ( and stat ) for underlying services so that we can provide a list-able service even when the underlying service only supports the read operation. For example, http services.

FYI:
Databend will use the opdal op.list and not store any file meta in metasrv(We will remove: store stage file meta to metasrv) in the future.


Added enableFeedback property to few standard widgets.

Description
Add enableFeedback to few standard widgets:

BottomNavigationBar (InkResponse)
DropdownButton (Inkwell in _DropdownMenuItemButtonState)
FloatingActionButton (RawMaterialButton)
PopupMenuButton (Inkwell in tooltip, IconButton)

Related Issues
Fixes #69397
Completed widgets

[x] BottomNavigationBar
[x] FloatingActionButton
[ ] PopupMenuButton
[ ] DropdownButton

Tests
I added the following tests:

BottomNavigationBar with enabled feedback.
BottomNavigationBar with disabled feedback.
BottomNavigationBar with enabled feedback by default.
FloatingActionButton with enabled feedback.
FloatingActionButton with disabled feedback.
FloatingActionButton with enabled feedback by default.

Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.

PR is still incomplete, will post updates.


Nice debugger frontend

We have our own debugger and its frontend. That gives us great opportunity to make it nice.
Ideas welcome.
I am myself in favor of Zeit-like branding with monotype font faces.

#158

added in #160


Bump version number

I'm not sure what the convention is here. Version 1.3.0 is everywhere in this branch except in version.go.

Huh, looks like I missed that in the v1.2.1 release and this one. Good catch!


Template v6.2.0 is not working

Describe the bug
Using the template from the website but getting an error:
Template format error: Unresolved resource dependencies [FrontEndDistributionToS3S3Bucket3A171D78] in the Resources block of the template
To Reproduce
Create the template with the following parameters:
https://solutions-reference.s3.amazonaws.com/serverless-image-handler/latest/serverless-image-handler.template
AutoWebPParameter | Yes
CloudFrontPriceClassParameter | PriceClass_100
CorsEnabledParameter | No
CorsOriginParameter | *
DeployDemoUIParameter | No
EnableDefaultFallbackImageParameter | No
EnableSignatureParameter | No
FallbackImageS3BucketParameter | -
FallbackImageS3KeyParameter | -
LogRetentionPeriodParameter | 1
SecretsManagerKeyParameter | -
SecretsManagerSecretParameter | -
SourceBucketsParameter | assets.bucket.com
Expected behavior
Template would get installed
Please complete the following information about the solution:

[x] Version: 6.2.0
[x] Region: us-east-1
[x] Was the solution modified from the version published on this repository? No
[x] If the answer to the previous question was yes, are the changes available on GitHub?
[x] Have you checked your service quotas for the sevices this solution uses?

Screenshots

Hi @karensg,
You are correct, it appears that deployments are not working properly unless the demo UI is enabled. This is as a result of some missed conditions on new cdk constructs, we apologize for the inconvenience and will get a patch out.
Thank you for bringing this to our attention.
Simon

Hi @karensg,
Thanks for your patience, the patch has been released and deployments should be fully functional again.
Thanks again for letting us know about this issue.
Simon

Thanks, updated from 6.2.0. Everything works.


Excalidraw Room (Collaboration Server)

Application Name
Excalidraw Room
Application Source Code URL
https://github.com/excalidraw/excalidraw-room
Application Language
Typescript
Application Architectures
linux/arm64, linux/amd64
Additional Information
Excalidraw has a feature to start a live collab session and do collaborative drawing. This requires excalidraw-room, or the collaboration server to be configured. The excalidraw deployment then needs to point to this server in order to enable live drawing/collab session.
Assign to self

[ ] I will create a PR to containerize this application myself

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Sorry I am not interested in supporting this.


Update OpenAPI spec with our latest APIs

APIs added

[x] Finetuning (files + fine-tune)
[x] Function calling
[x] Image endpoint
[x] Models endpoint

responded to the comment above. One more change, can you add back the safety_model to CompletionRequest? safety model is supported, technically.

Good catch, done!


How can I implement call, bind & apply methods on hostDelegate

Hello. I have some C# functions that return the C# List. The list is mimicking javaScript array with all its methods.
// C# code
public class myclass{
   public JSList<int> func => new JSList<int>(1)
}

public class JSList<T> : List<T>
{
   public int push(params dynamic[] elements)
   {
      // do somethin;
   }
}

Also, I have JS function that tries to execute push method with apply(). I cannot modify JS code, but I can append some functions. Is there any way i can implement call, bind & apply methods?
//JS Code
let myclass = new myclass();
myclass.push.apply([1,2,3], [4,5,6])

Thank you!

Hi @mithrey,
A couple of questions:

In your JavaScript code above, should that be myclass.func.push.apply([1,2,3], [4,5,6])? Please clarify what myclass is on the JavaScript side.
The first argument to apply is the this object, for which you're passing [1,2,3]. Does that mean that you expect your push function to work on normal JavaScript arrays as well as C# lists?

Thanks!

myclass is C# class(line 2). I'm using AddHostType on C# side.  ps: i've modified JS code.
This is just simplified example. In my case push works on C# hostObjects as well as on JS objects. But i need it to work with apply, bind, call methods.
Thank you!

It worked for me! Such a simple solution. Thank you again!


Document usage of secretName in Binding

We should document the usage of secretName in Binding.

This is part of #90


Fix UI: The Twitter(X) logo is not visible on desktop yet it is when seen on a mobile devices

The Twitter(X) logo/button is not visible on desktop yet it is when seen on a mobile devices.
on mobile:

on desktop:

hey @DhanushNehru  can you plz add hacktoberfest and hacktoberfest-accepted tags too, would help a lot

Thanks a lot @DhanushNehru .

Great work @Sha1kh4 . Thanks for your contribution


Need to update gamedata for 2021-06-22 update

Every vtable of classes derived from CBaseEntity needs to be updated (CBaseEntity::BCanCallVote() was added).
I need to do maintenance for other plugins, so this one is a bit low priority at the moment; throwing the issue up as a reminder.  Will take care of it myself down the line if I need to, but if anyone wants to get ahead of me for ✨ maintainer credit ✨, feel free to PR.
If someone else tackles it, do keep in mind that the reported offsets for the CBaseObject vtable is known to be inaccurate on asherkin's dumper.

Memory patches or in-function offset lookups may also be broken. Have to clean up asserts on those.


use rust-analyzer.linkedProjects

with this VS code configuration RA works transparently across the two Cargo workspaces

This looks good to me, but the file conflicts with local configuration (any per-workspace configuration will end up making the file dirty). I'm not sure there's another way to do this though...

I see two options to resolve this:

Only documenting that developers should add this config, but actually not have it in the repo
Force users to have their configuration outside the repo, which seems to be doable as described on this stackoverflow post (though I didn't fully try it).

Only documenting that developers should add this config, but actually not have it in the repo

that would be useful to have in the app-template README (probably easy to miss the new info if you already know how to init an app-template project).
as there's no good solution to incorporate this right now I'll close the PR until we come up with a solution.


python310Packages.geopandas: 0.14.1 -> 0.14.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.geopandas is: Python geospatial data analysis framework
meta.homepage for python310Packages.geopandas is: https://geopandas.org
meta.changelog for python310Packages.geopandas is: https://github.com/geopandas/geopandas/blob/v0.14.2/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.14.2 with grep in /nix/store/krf92b6ldjv3rs1wflmp18smdasx5mj0-python3.10-geopandas-0.14.2
found 0.14.2 in filename of file in /nix/store/krf92b6ldjv3rs1wflmp18smdasx5mj0-python3.10-geopandas-0.14.2

Rebuild report (if merged into master) (click to expand)

14 total rebuild path(s)

14 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.bsuite
python310Packages.folium
python310Packages.geopandas
python310Packages.osmnx
python310Packages.plotnine
python310Packages.rlax
python310Packages.wktutils
python311Packages.bsuite
python311Packages.folium
python311Packages.geopandas
python311Packages.osmnx
python311Packages.plotnine
python311Packages.rlax
python311Packages.wktutils

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/krf92b6ldjv3rs1wflmp18smdasx5mj0-python3.10-geopandas-0.14.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.geopandas https://github.com/r-ryantm/nixpkgs/archive/ff793254e3116e4a9fbf651789d004a9b1ce648e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ff793254e3116e4a9fbf651789d004a9b1ce648e#python310Packages.geopandas

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/krf92b6ldjv3rs1wflmp18smdasx5mj0-python3.10-geopandas-0.14.2
ls -la /nix/store/krf92b6ldjv3rs1wflmp18smdasx5mj0-python3.10-geopandas-0.14.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages failed to build:

python310Packages.bsuite
python310Packages.plotnine
python310Packages.rlax
python311Packages.bsuite
python311Packages.plotnine
python311Packages.rlax

8 packages built:

python310Packages.folium
python310Packages.geopandas
python310Packages.osmnx
python310Packages.wktutils
python311Packages.folium
python311Packages.geopandas
python311Packages.osmnx
python311Packages.wktutils

Maintainer pings
cc @das-g @imincik @nh2 @nialov @r-burns @sikmir @willcohen for testing.

Result of nixpkgs-review pr 279713 run on x86_64-darwin 1

4 packages marked as broken and skipped:

python310Packages.bsuite
python310Packages.bsuite.dist
python311Packages.bsuite
python311Packages.bsuite.dist

12 packages failed to build:

python310Packages.folium
python310Packages.folium.dist
python310Packages.geopandas
python310Packages.geopandas.dist
python310Packages.osmnx
python310Packages.osmnx.dist
python310Packages.plotnine
python310Packages.plotnine.dist
python310Packages.wktutils
python310Packages.wktutils.dist
python311Packages.plotnine
python311Packages.plotnine.dist

8 packages built:

python311Packages.folium
python311Packages.folium.dist
python311Packages.geopandas
python311Packages.geopandas.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python311Packages.wktutils
python311Packages.wktutils.dist

@sikmir , what's the error message for your nixpkgs-review python310Packages.geopandas failure ? I see it successfully building in https://github.com/NixOS/nixpkgs/pull/279713/checks?check_run_id=20284486436

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/week-in-geospatial-team/37035/2

@sikmir , what's the error message for your nixpkgs-review python310Packages.geopandas failure ? I see it successfully building in https://github.com/NixOS/nixpkgs/pull/279713/checks?check_run_id=20284486436

That's strange, but nix build -L .#python310Packages.geopandas is OK, while nixpkgs-review pr 279713 shows fails.

Failed packages are failed on master as well.

Failed packages are failed on master as well.

Do you have some error messages ?

Just in case, it's OK on darwin:
Result of nixpkgs-review pr 279713 run on x86_64-darwin 1

4 packages marked as broken and skipped:

python310Packages.bsuite
python310Packages.bsuite.dist
python311Packages.bsuite
python311Packages.bsuite.dist

20 packages built:

python310Packages.folium
python310Packages.folium.dist
python310Packages.geopandas
python310Packages.geopandas.dist
python310Packages.osmnx
python310Packages.osmnx.dist
python310Packages.plotnine
python310Packages.plotnine.dist
python310Packages.wktutils
python310Packages.wktutils.dist
python311Packages.folium
python311Packages.folium.dist
python311Packages.geopandas
python311Packages.geopandas.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python311Packages.plotnine
python311Packages.plotnine.dist
python311Packages.wktutils
python311Packages.wktutils.dist

Failed packages are failed on master as well.

Do you have some error messages ?

https://hydra.nixos.org/build/245903727
https://hydra.nixos.org/build/245897391

Failed packages are failed on master as well.

Do you have some error messages ?

https://hydra.nixos.org/build/245903727 https://hydra.nixos.org/build/245897391 https://hydra.nixos.org/build/245898199

But these are plotnine, bsuite and rlax failures (which should be fixed by https://github.com/NixOS/nixpkgs/pull/275438).
What I was curious about where the geopandas failures reported in https://github.com/NixOS/nixpkgs/pull/279713#issuecomment-1882544177

What I was curious about where the geopandas failures reported in #279713 (comment)

I have no those logs now, but looks like it was some local problem, since re-build is OK (see https://github.com/NixOS/nixpkgs/pull/279713#issuecomment-1885599403)

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/week-in-geospatial-team/37035/3


Implementation Idea

School Account
Fields:

authority: Public key of the school administrator.
enrollmentFee: The cost to enroll in the school (in SOL or lamports).
classRegistry: A mapping of class names to their NFT metadata.
bookRegistry: A mapping of book names to their NFT metadata.

Student Account
Fields:

studentId: Unique identifier for the student (can be generated using a counter in the School account).
studentNft: The address of the student's ID NFT.
enrolledClasses: A list of class names the student is enrolled in.
ownedBooks: A list of book names the student owns.

Program Functions
enroll
Inputs:

authority: Public key of the student enrolling.
payment: Amount of SOL (or lamports) to pay the enrollment fee.

Logic:

Verify the payment is sufficient.
Mint a new student ID NFT and assign it to the student.
Store the student's information (studentId, studentNft) in the School account.
Transfer ownership of the NFT to the student.

registerClass
Inputs:

authority: Public key of the student.
className: The name of the class to register for.

Logic:

Verify the student is enrolled in the school (check the School account).
Check if the class exists in the classRegistry.
Update the student's enrolledClasses list.
Optionally, mint a class NFT and transfer it to the student.

requestBook
Inputs:

authority: Public key of the student.
bookName: The name of the book to request.

Logic:

Verify the student is enrolled in the school.
Check if the book exists in the bookRegistry.
Check if the student meets the requirements (e.g., enrolled in a specific class, has completed a certain module).
Mint the book NFT and transfer it to the student.

updateClassRegistry
Inputs:

authority: Public key of the school administrator.
className: Name of the class.
classMetadata: Metadata for the class (e.g., description, teacher, schedule).

Logic:

Only allow the school administrator to perform this action.
Add or update the class information in the classRegistry.

updateBookRegistry
Inputs:

authority: Public key of the school administrator.
bookName: Name of the book.
bookMetadata: Metadata for the book (e.g., title, author, subject).

Logic:

Only allow the school administrator to perform this action.
Add or update the book information in the bookRegistry.

Documentation diagram
https://mermaid.live/view#pako:eNqNVMFy2jAQ_RWNTu4MYQzBBnzoDGAgJKHtlLSHhh5UW8EabInK8jQE8--VJRuEgaY-eLS7b7Vvn1bawYCFGHpwxdEmAk_-kgL5DZ4HYULoT3Bz8zGfUSIIiskbBosgYizOwdDSqw8aPlS4BRZgTDmL4wRTASYY52BknXpOEkYcI4HBKEZpCr7iFUkF3-bAt049l3KGjK2NlLF14pAZOmfyvBBZKGvrTjQXSb-MKucXtD2nbZacE-ku9wGfJk85mFqGWdKbaq3SNMMH8MzPwZ11tEronZZLMH6E-kigHMws0z62oRJ0d5hrwaROOuir4HfMycu21HL8WgBpIDu5t2quksO9yhqEYZkiWEVFsqjX_Z3hVCjNpdQ6NDarKvGNog_Wqaes-XCUU8WVlo9WtS5Rjwo15aiCff5DMU8jsjGYDRTo2ya8OEAXMPWBqTZKs1969CvhB4EgjKY6OjPGBhBaU352XR5Mw_MK6soAdbMKGqgoZFKdI4pW77RTYs7buVZVCgsWW3kOyTszbZ5r_Yyub1_MKShGWbIyVanNtTmqV_rTlf-_sWHMgnUQIULNC6huVQgYNeKH5h7_ATF7LBbFHzZggnmCSChfyF3hWUIR4QQvoSeXIeLrJVzSvcShTLDFlgbQEzzDDchZtoqg94LiVFqZGkKfIEk9qSA4JJLJXL-_6hluwA2iPxhLDonSht4OvkLPtZtuv3Xbtl231bYdu9eAW-jdtpxmp9vtOj3Hdvtuv71vwDe1gd3sOT236_Z6TrfTcWTS_i92N9-d

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

I like this a lot and think it is the general direction we should go.
Personally, I'm still grappling with Anchor design patterns so I'd prefer to start more simply. If everyone else is already comfortable with Anchor design, then we can ignore this and I'll play catchup.
If people want to take this route, I'd suggest we make a simple first iteration just to ensure it works, is at least modestly secure and we have basic frontend connectivity:

School Account
Fields:

authority: Public key of the school administrator.
enrollmentFee: The cost to enroll in the school (in SOL or lamports).
classRegistry: A Vec of Strings indicating registered classes
bookRegistry: A Vec of Strings indicating class books .

Student Account
Fields:

studentId: Unique identifier for the student (can be generated using a counter in the School account).
studentNft: The address of the student's ID NFT.
enrolledClasses: A list of class names the student is enrolled in.
ownedBooks: A list of book names the student owns.

Program Functions
enroll
Inputs:

authority: Public key of the student enrolling.
payment: Amount of SOL (or lamports) to pay the enrollment fee.

Logic:
Verify the payment is sufficient.
Mint a new student ID NFT and assign it to the student.
Store the student's information (studentId, studentNft, student pubkey) in the School account.
Transfer ownership of the NFT to the student.

Also, there were a few things I thought of here:

Would it be easier for a first pass to just lazily indicate the class & book registries as a Vec of strings?
If we iterate successfully, perhaps enrolledClasses and ownedBooks could be part of the NFT metadata, something which I understood to be more lightweight?
I'd take the basic assumption that one wallet pubkey == one IRL student. If this is a good assumption, how can we ensure that one IRL student (e.g. wallet) isn't minting multiple studentID NFTs? First thought is to log the wallet pubkey

Anyway, these are my first thoughts. I'd be able to allocate some time to this over the weekend if we like this direction so far.


twiddler.addGroup

The function twiddler.addGroup is not available.
The examples given in the README file do not match the current state of the twiddler master branch.
Maybe this commit is missing?
https://github.com/waptang/supervisor_twiddler/commit/ab76aacde2fbea653ad7dd64e61eab141990f8fe

Yes,  one more request for the AddGroup() , that I need to manage my process group dynamicly. Thx so much


[Feature Request][.Net]: Count token usage for OpenAIClientAgent

Is your feature request related to a problem? Please describe.
The token usage information is included in ChatCompletions, but OpenAIClentAgent returns ChatCompletions.Choice[0], which prevents developers get token count information.
Describe the solution you'd like
Return ChatCompletions in OpenAIClientAgent so the token count information can be retrieved in the similar way of the following example
https://microsoft.github.io/autogen-for-net/articles/MistralChatAgent-count-token-usage.html
Additional context
No response

I'll work on this


Allow padding on mj-container component

Fix #204 #160

Hello @pixelize
padding is supported only on td and p for every client that's we can't add it on the container
And it could break so many thing that being computed from container's width

Hey @iRyusa, it's not working on p or div on Outlook clients right ? Does it matter if we can apply it anyway and accept that will not not rendered in Outlook but in others email/web clients ?
Just did some test on Litmus, my test layout was ok on these ! Btw, you're more expert than me in css properties support in email clients, it's up to you 👍

Hey @pixelize, we really appreciate your PR, thanks for contributing!
Unfortunately, as @iRyusa said, merging this would lead to too many uncontrolled issues. We want MJML to be responsive and supported on every major email clients, which includes Outlook, without requiring users to dig in what works and what doesn't for each email clients.
I hope it makes sense to you and hope to have more contributions from your side, glad to have you onboard!

Happy to help such a great project !
No problem, I totally agree with you. Good to know of you want MJML to be driven, will keep in mind for next PR :)


Incorrect error message on unclosed element after properly closed elements

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
latest version
Link to runnable example
No response
Steps to reproduce
This code

produces this error
1:1: Expected a closing tag for `</B>` (1:1-1:4)

Which seems to come from here: https://github.com/syntax-tree/mdast-util-mdx-jsx/blob/bf60d93bdffde6e4d3359324170d438e5ee62a63/lib/index.js#L424-L471
Expected behavior
I would have expected an error that asks me to close the  tag/element.
Actual behavior
The error asks me to close the  tag, which is itself a closing tag
Affected runtime and version
<EMAIL_ADDRESS>Affected package manager and version
No response
Affected OS and version
No response
Build and bundle tools
No response

Thanks, released in https://github.com/syntax-tree/mdast-util-mdx-jsx/releases/tag/3.1.1!


[ci.yaml] firebaselab recipe

Fixes firebase lab recipe
Sets xcode to 12c33 (what was in starlark)
Fix web_benchmarks_html missing task_name (this target was missing from ci.yaml)

In addition, the main issue was missing to update the devicelab_osx_sdk in starlark
https://github.com/flutter/flutter/issues/85803
Pre-launch Checklist

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I signed the [CLA].
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[X] All existing and new tests are passing.

Since the caches got wiped, and the expiration timeouts may not be enough, we could land this one all tasks are expired to kick the tree (\cc @jonahwilliams the tree gardener)


choosing bitrate when encoding audio

In tf1.15 there was the support of  choosing bitrate when encoding audio
https://github.com/tensorflow/tensorflow/blob/r1.15/tensorflow/contrib/ffmpeg/ffmpeg_ops.py#L101
Now the possibility is cut out
It is very important feature in speech recognition tasks. So It will be great when you return back this option.

contrib module is deprecated and no longer part of TensorFlow.
Have you tried using tf.audio.encode_wav ?

contrib module is deprecated and no longer part of TensorFlow.
Have you tried using tf.audio.encode_wav ?

Hi.
I talk about bitrate, not sample rate.
Neither of any encoders support the option now.
As I mentioned earlier it is very important feature in speech recognition tasks.
As a proof of my words you could look at paper from Google https://arxiv.org/pdf/1808.05312.pdf  p3.3

Thanks for the feature request @avnx, but I'm confused. Setting a bitrate doesn't seem to have been part of the tf.contrib.ffmpeg public API? Do you mean you edited the source code?
It would be nice if encode/decode audio had this support. I think we could mark this contributions welcome, because I doubt the core team has bandwidth to look at it.

Thanks for the feature request @avnx, but I'm confused. Setting a bitrate doesn't seem to have been part of the tf.contrib.ffmpeg public API? Do you mean you edited the source code?
It would be nice if encode/decode audio had this support. I think we could mark this contributions welcome, because I doubt the core team has bandwidth to look at it.

Hi,
Yes, I edited source code. It was not hard as you can see https://github.com/tensorflow/tensorflow/blob/r1.15/tensorflow/contrib/ffmpeg/ffmpeg_ops.py#L101
Just change one option and that's it.
I tried to go deeper in current code tf2.2 and I can't imagine how I could "turn on" the option to encode with different bitrate.

@avnx ffmpeg and all tf.contrib has been removed from tensorflow code tree and is not part of the distribution since TF 2.0.
They are being distributed to separate repos and pip. tensorflow-io are mostly for I/O, audio/video, tensorflow-addons are mostly for additional tf.keras related modules. You can open feature request issues to tensorflow/io if it is audio related.

@avnx ffmpeg and all tf.contrib has been removed from tensorflow code tree and is not part of the distribution since TF 2.0.
They are being distributed to separate repos and pip. tensorflow-io are mostly for I/O, audio/video, tensorflow-addons are mostly for additional tf.keras related modules. You can open feature request issues to tensorflow/io if it is audio related.

so what do you want to say? I didn't get you.
I opened feature request and attached info where you (Google) use bitrate manipulation during solving speech recognition tasks. I say that it is very important feature in speech recognition tasks and it is good to have it. Especially considering the fact that there was the opportunity to do that in older versions of tf.
I would be happy to do that by myself but tf code became very complicated in processing an audio (since tf2) and I don't think that I am capable of adding this feature by myself.

@avnx I was suggesting you to open a feature request issue in  tensorflow/io, so that we can track the progress there. We will add support for your feature request if there is enough interests from overall community.
Since  tensorflow/io and  tensorflow/tensorflow are two different repos, feature requests cross the repo might not have been noticed.

@avnx I have opened a feature request in https://github.com/tensorflow/io/issues/994 .
Let's continue the conversion there to track the progress.

@avnx I was suggesting you to open a feature request issue in tensorflow/io, so that we can track the progress there. We will add support for your feature request if there is enough interests from overall community.
Since tensorflow/io and tensorflow/tensorflow are two different repos, feature requests cross the repo might not have been noticed.

I am sorry. Didn't get your idea first time.
Thank you!


Can this architecture work on 2D segmentation?

Excuse me, I'm a student who just start learning image segmentation. I wondering if I can do 2D segmentation using your architecture, cause this paper since to be for 3D segmentation. TX :)

Yes, ACDC dataset is used by 2D slices.


Add connector - Generated certificate text field greyed out

Description - What happened? *
After generating the certificate in the Certificate field the generated certificate text is shown as greyed-out colour.
Also, Generate & Download Certificate (Slow) is mentioned. Should this mention of "slow" still be present there?
Expected Behavior *
Should show in dark black color once the certificate is generated.
Observed Behavior *
Generate Certificate after generating the certificate in the Certificate field the generated certificate text is shown as greyed out colour.
Steps to Reproduce

Launch app with valid credentials
Click on Connectors
Click on Add Connectors
Enter all valid data
Click on Next
Enter all valid data
Click on Generate Certificate

Context Information
No response
Relevant log output
No response
Screenshots

In my opinion, it works as designed. Since the certificate field is not meant to be interacted with, it only makes sense to grey it out to convey that message to the user.
Only thing I would change is the wording. "Slow" is vague and should be replaced with a label below the button along the lines of "Generating a new certificate can take some time"

@jkbquabeck what do you think?

@illfixit I fully agree with @kamilczaja

@kamilczaja @jkbquabeck does it look good enough?

@kamilczaja @jkbquabeck does it look good enough?

I would remove the asterisk, I think the proximity is enough to get the point

@kamilczaja @jkbquabeck does it look good enough?

I would remove the asterisk, I think the proximity is enough to get the point

Jakob said the same, done :)


Prune public api (prep 2.18.0 stable release)

Cleaning up the Public API.

Remove CredentialEnvelope
Remove AuthToken
Add Perf library to the Base SDK's internals-visible-to. (QuickPulseServiceClient)

The CredentialEnvelope and AuthToken are our wrappers around the Azure.Identity libraries.
First, because we don't control these libraries, we don't want to provide a contract of their values.
Second, these classes are not intended for use by our customers.
For Partners
These changes will be available in the nightly build after this PR merges
Please ping me if you need access to these changes sooner.
Partners are invited to submit a separate PR to add their libraries to our internals-visible-to.

@renatosalas

@pharring Please take a look. Thanks!

For SnapshotCollector, we use reflection for CredentialEnvelope and AuthToken (it's a "light-up" feature), so making them internal is OK as long as we understand that they can't change in the future.
For the Windows profiler agent, I don't think this is a problem. We set the CredentialEnvelope, but we neither read or use it.
For the Linux profiler, I think we'll want to add an InternalsVisibleTo entry for Microsoft.ApplicationInsights.Profiler.AspNetCore. @xiaomi7732, what do you think?

For SnapshotCollector, we use reflection for CredentialEnvelope and AuthToken (it's a "light-up" feature), so making them internal is OK as long as we understand that they can't change in the future.
For the Windows profiler agent, I don't think this is a problem. We set the CredentialEnvelope, but we neither read nor use it.
For the Linux profiler, I think we'll want to add an InternalsVisibleTo entry for Microsoft.ApplicationInsights.Profiler.AspNetCore. @xiaomi7732, what do you think?

Thanks for loop me in. Linux Profiler will use reflection for CredentialEnvelop too. No need for InternalsVisibleTo there either.


feature: Add simple wait command for web

Quick and dirty wait feature only for keyboard. Might be overpowered in the current iteration but being able to wait would be nice.
Will try to think of good touch implementation.

Thank you for submitting the first PR!
So as for this feature, the easiest way to implement it for both touch and keyboard, would be to remove the code I have around the player attack, the makes it so a turn is not taken when the player swings at nothing. If you just took a turn when the player swings at nothing, you will have a "wait" command for both input controls.
That being said, I think introducing a wait command is overpowered because right now, the game relies on chance as to whether the player or monster gets first attack. (The monsters have a random chance to not move when out of sight, otherwise moves randomly). Because of this reason, I will need to decline this pull request.

What's the specific design intent in terms of feel and progression? I'd love to contribute to the project so I want to align with your vision on what the game will be long term. I made the pull request before I read some of your reddit comments so I wasn't aware of what you were thinking of in terms of design.
Being able to pass a turn seems like an obvious feature to help traverse the dungeon since the player's success depends largely on being able to mitigate/avoid damage once the DPS race begins. Being forced to cede initiative even when the player can see the enemy coming feels similar to not getting equipment drops. Additionally, I think darting in and out of the fog seems to allow re-rolling for more favorable initiative outcomes, which possibly could encourage odd play patterns. I found myself walking back and forth if I saw the path to an enemy would not give me first strike.
When I finally killed the Lich, the run precluded avoiding damage and as such I highly valued potions to keep health high. I didn't have a set of boots until I reached the end since I was buying a potion each visit. While the health and damage management game can be rewarding broadly speaking, I think adding some tactical nuance would be welcome. Something as simple as broadcasting attack effect and range for enemy attacks that conclude the following turn could add a lot of decision making.

I definitely need to outline my intentions for game feel and all that. I added an issue to include a Roadmap, and I feel like that would be a good place to state my intentions.
That's a good point about poking in and out of fog. It does make for some weird gameplay behavior. I am open to changing this, however I cannot see a clear path of how to do so. If you have a solid idea, please make a github issue, as it will be easier to track and discuss in detail.
I like the idea of adding more tactical nuance, however, could you clarify what you mean by: "Something as simple as broadcasting attack effect and range for enemy attacks that conclude the following turn could add a lot of decision making." ?
Thanks again for keeping up on Reddit and submitting a PR!

I'll open an issue for discussing the fog of war in relation to combat initiative but I don't have a particular direction either for the design.
For the other point, to be more concise, I think enemies should have attacks that take more than one turn to resolve and/or they'll also telegraph their attacks. A recent game as example is Into The Breach. The enemy attacks initiate and colors the tactical grid with their attack pattern. Some subsequent turn, the attack actually comes out. If the attack patterns are sufficient interesting, the player being able to see the attack opens up some fun designs.

Ah, I see what you are saying now. I will create an issue for that. I think it's a good suggestion.


[Feature]: Master support Straw2 algorithm when select node and nodeset

What this PR does / why we need it:

Straw2 is a selection algorithm which is widely used in Ceph.
This pull request make cubefs support Straw2 algorithm.

Effect:
=== RUN   TestBenchStrawNodeSelector
    node_selector_test.go:237: Node 3 select times 38
        Node 2 select times 31
        Node 1 select times 21
        Node 0 select times 10

    node_selector_test.go:47: Data Node 0
        	Total Space:102400 MB
        	Avaliable Space:45254 MB

    node_selector_test.go:47: Data Node 1
        	Total Space:204800 MB
        	Avaliable Space:95745 MB

    node_selector_test.go:47: Data Node 2
        	Total Space:307200 MB
        	Avaliable Space:144415 MB

    node_selector_test.go:47: Data Node 3
        	Total Space:409600 MB
        	Avaliable Space:218970 MB

    node_selector_test.go:237: Node 1 select times 21
        Node 2 select times 27
        Node 3 select times 41
        Node 0 select times 11

    node_selector_test.go:53: Meta Node 1
        	Total Space:204800 MB
        	Avaliable Space:86231 MB

    node_selector_test.go:53: Meta Node 2
        	Total Space:307200 MB
        	Avaliable Space:163373 MB

    node_selector_test.go:53: Meta Node 3
        	Total Space:409600 MB
        	Avaliable Space:190349 MB

    node_selector_test.go:53: Meta Node 0
        	Total Space:102400 MB
        	Avaliable Space:64432 MB

--- PASS: TestBenchStrawNodeSelector (0.00s)
PASS
ok  	github.com/cubefs/cubefs/master	15.967s

Which issue this PR fixes:

Special notes for your reviewer:
Release note:

please squash the 3 commits into one.

please squash the 3 commits into one.

Ok.


Allow lists without a leading blank line to be rendered as lists (GitHub flavored)

Maybe there is already a way to do this, but I didn't find it in the current extensions.
The regular markdown (not GitHub flavored) requires an empty line between a sentence and the start of a list:
This is a sentence

- list item 1
- list item 2

The following in regular markdown (and in pegdown) doesn't render the list items in a list:
This is a sentence
- list item 1
- list item 2

In GitHub it does.
Is there currently a way to achieve the same behavior as in GitHub?

@depryf, there is no way to do it in pegdown and no easy way without risking breaking a lot of parser rules.
The difficulty in maintaining and modifying pegdown parser was one of the reasons I rewrote commonmark-java to replace pegdown in my Markdown Navigator plugin for IntelliJ IDEs: https://github.com/vsch/idea-multimarkdown. The parser project is https://github.com/vsch/flexmark-java has very detailed source based AST with source offset for every part of the element. I need that for syntax highlighting and other plugin source reliant features.
It is CommonMark 0.27 (GitHub Comments) compliant but In the last release I added list parsing options to emulate list indentation rules used by: markdown.pl, MultiMarkdown (like pegdown 4 space indents) and kramdown (GitHub Docs). The only extensions that pegdown has that I did not yet implement are: typographic quotes, smarts and definition lists. The rest of the extensions are available, with some extra ones that pegdown does not have.
As an added bonus and what motivated me to switch the parsing is 30-50x faster than pegdown on average documents and several thousand times faster on pegdown's pathological input like [[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[.
The AST offsets are bug free and regular. It is also fully modifiable unlike pegdown's with next, prev and parent links.

Thank you for the answer. I guess this issue can be closed then!


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #41.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #41

@conda-forge-admin please rerender

@conda-forge-admin please rerender


model import problem

Your code suggests you've got Issue defined in the base model somehow. Is this a new ckan feature? (We run ckan 2.2 at the moment)
 Module ckanext.issues.controller.controller:421 in all_issues_page         view
>>  func.count(model.Issue.id).label('issue_count'),
AttributeError: 'module' object has no attribute 'Issue'

I understand now. The code was moved from elsewhere, where the model was actually the issue model. The all_issues_page I was trying is generally broken anyway.


mv: Mv hardlinks windows should fail

Hi,
This PR is related to #5451, but not necessarily closes it. On windows, making a hardlink would not be recognized, but now it is:
# on windows
create file named hard_link_a
mkhardlink /H hard_link_b hard_link_a

Currently:
> mv hard_link_a hard_link_b
# removes hard_link_a

Now:
> mv hard_link_a hard_link_b
mv: 'hard_link_a' and 'hard_link_b' are the same file

Now with the issue related on case-insensitive OSs. Currently
touch a
mv a A

would succeed only on linux, but fail on both windows, macOs due to being case-insensitive Os. I have been trying to make it work across all OS, but changing the order of some of the error handling blows up some of the tests. Is that even something we want to support, or is the current behavior the intended one?
I have seen lots of issues with mv lately, including some I caused with my PR (sorry 😛  ) , so would like to improve at least the behavior of certain operations.
Basically I started trying to fix case-insensitive, ended up fixing moving hardlinks :P

What can we do to get this going? I believe it may be the only thing holding up integration of uu_mv into nushell. Any ideas @tertsdiepraam? Sorry to tag you. It's been a few weeks and it would be great to move forward with this.

I'll take a look :)

please reopen when ready


Are due dates the same as deadlines? Can't get the due date to set properly when sending tasks to Todoist.

Hi there! Thanks for this amazing plugin.  Works beautifully for me, but have a question and potential issue with due dates on tasks being sent to Todoist.
Are deadlines (as referred to in the settings) the same as due dates? I've tried setting both deadlines and schedules for tasks in Logseq, then sending those over to Todoist, but nothing seems to set the due field on my tasks.  I checked in the developer tools network section and confirmed that the payload sent to Todoist always seems to have due set to null, so it just seems like we're not sending it over.
Running Logseq v0.9.17 and v5.0.2 of your plugin.  Any help would be appreciated.  Thanks!

Thanks for reporting! Will look into it.

This is resolved in the latest version.

Amazing! Works like a charm, much appreciated 🍻


fix(cicd): fixes release order

What
fixes release order

:tada: This PR is included in version 1.21.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.21.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Zonal enabled + module disabled throws error

Problem
With zonal enabled and this module disabled, it would throw the following error...
* module.nat-zone-3.module.nat-gateway.data.google_compute_instance_group.zonal: Resource 'google_compute_instance_group_manager.default' not found for variable 'google_compute_instance_group_manager.default.name'

Fix
The problem is an inherent problem lower level in Terraform, not "fully" respecting the count on a data resource to not try to resolve all dependencies inside an unused (count = 0) data stanza.  This is a well known problem, and the workaround is to have a cascading value to fall back onto, hence the concat+element trick.

LGTM, thank you.


Assertion 'next_offset == JMEM_HEAP_END_OF_LIST ... in jmem_heap_alloc

JerryScript revision
3c723c9bc1aec08a54bc44bba7987e4324f440e4
(latest master - 2020.09.21.)
Build platform
Ubuntu 18.04.5 LTS (Linux 4.15.0-112-generic x86_64)
Build steps
tools/build.py --debug --logging=on --error-messages=on --line-info=on
Test case
found by test262-esnext test:

built-ins/TypedArray/prototype/find/BigInt/predicate-call-changes-value

Output
 ICE: Assertion 'next_offset == JMEM_HEAP_END_OF_LIST || jmem_is_heap_pointer (JMEM_HEAP_GET_ADDR_FROM_OFFSET (next_offset))' failed at /home/oszi/jerryscript/jerry-core/jmem/jmem-heap.c(jmem_heap_alloc):187.Error: ERR_FAILED_INTERNAL_ASSERTION

Expected behavior
no assert

note: built-ins/TypedArray/prototype/find/BigInt/predicate-call-changes-value passes on latest master ( 4b2dbd5c2165f60e770e400d56c90d23fa224048 )
I'm going to check which revision fixed this assertion.

I bisected, 32de38198a5186a25c369c4cd1991925958edb46 fixed this issue.


Can not install sails. no such package available : @sailshq/express

Hi,
i am trying to install sails, but i get an error, that submodules are not available.
npm install sails -g
npm ERR! Darwin 16.4.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "sails" "-g"
npm ERR! node v6.9.1
npm ERR! npm  v4.0.5
npm ERR! code E404

npm ERR! 404 no such package available : @sailshq/express
npm ERR! 404
npm ERR! 404  '@sailshq/express' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 It was specified as a dependency of 'sails'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

Even info can find it:
npm info @sailshq/express
...
code E404

It seems there is something broken in the build.

Thanks. Fixed it. Missing @named directive in my npm proxy


I've tried:
 $selectizeInput.on('focus', doSomething);
Also, I tried adding an onfocus property to the corresponding <select> tag:
<select onfocus="doSomething">
None of this worked. How do I get it working?

This is going to be part of the 0.12 release. See https://github.com/brianreavis/selectize.js/pull/185