Error while training

Had a problem while training on my own dataset converted from coco to icdar_2013.
here is the output :
Looking for blah\craft_mlt_25k.h5

blah\tensorflow\python\keras\engine\training.py:1844: UserWarning: `Model.fit_generator` is deprecated and will be removed in a future version. Please use `Model.fit`, which supports generators.
  warnings.warn('`Model.fit_generator` is deprecated and '

Epoch 1/1000
11/90 [==>...........................] - ETA: 1:01 - loss: 5.4118e-04

---------------------------------------------------------------------------
UnknownError                              Traceback (most recent call last)
<ipython-input-9-a78793f98407> in <module>()
     19     ],
     20     validation_data=validation_generator,
---> 21     validation_steps=math.ceil(len(validation) / batch_size)
     22 )

blah\tensorflow\python\keras\engine\training.py in fit_generator(self, generator, steps_per_epoch, epochs, verbose, callbacks, validation_data, validation_steps, validation_freq, class_weight, max_queue_size, workers, use_multiprocessing, shuffle, initial_epoch)
   1859         use_multiprocessing=use_multiprocessing,
   1860         shuffle=shuffle,
-> 1861         initial_epoch=initial_epoch)
   1862
   1863   def evaluate_generator(self,

blah\tensorflow\python\keras\engine\training.py in fit(self, x, y, batch_size, epochs, verbose, callbacks, validation_split, validation_data, shuffle, class_weight, sample_weight, initial_epoch, steps_per_epoch, validation_steps, validation_batch_size, validation_freq, max_queue_size, workers, use_multiprocessing)
   1098                 _r=1):
   1099               callbacks.on_train_batch_begin(step)
-> 1100               tmp_logs = self.train_function(iterator)
   1101               if data_handler.should_sync:
   1102                 context.async_wait()

blah\tensorflow\python\eager\def_function.py in __call__(self, *args, **kwds)
    826     tracing_count = self.experimental_get_tracing_count()
    827     with trace.Trace(self._name) as tm:
--> 828       result = self._call(*args, **kwds)
    829       compiler = "xla" if self._experimental_compile else "nonXla"
    830       new_tracing_count = self.experimental_get_tracing_count()

blah\tensorflow\python\eager\def_function.py in _call(self, *args, **kwds)
    853       # In this case we have created variables on the first call, so we run the
    854       # defunned version which is guaranteed to never create variables.
--> 855       return self._stateless_fn(*args, **kwds)  # pylint: disable=not-callable
    856     elif self._stateful_fn is not None:
    857       # Release the lock early so that multiple threads can perform the call

blah\tensorflow\python\eager\function.py in __call__(self, *args, **kwargs)
   2941        filtered_flat_args) = self._maybe_define_function(args, kwargs)
   2942     return graph_function._call_flat(
-> 2943         filtered_flat_args, captured_inputs=graph_function.captured_inputs)  # pylint: disable=protected-access
   2944
   2945   @property

blah\tensorflow\python\eager\function.py in _call_flat(self, args, captured_inputs, cancellation_manager)
   1917       # No tape is watching; skip to running the function.
   1918       return self._build_call_outputs(self._inference_function.call(
-> 1919           ctx, args, cancellation_manager=cancellation_manager))
   1920     forward_backward = self._select_forward_and_backward_functions(
   1921         args,

blah\tensorflow\python\eager\function.py in call(self, ctx, args, cancellation_manager)
    558               inputs=args,
    559               attrs=attrs,
--> 560               ctx=ctx)
    561         else:
    562           outputs = execute.execute_with_cancellation(

blah\tensorflow\python\eager\execute.py in quick_execute(op_name, num_outputs, inputs, attrs, ctx, name)
     58     ctx.ensure_initialized()
     59     tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
---> 60                                         inputs, attrs, num_outputs)
     61   except core._NotOkStatusException as e:
     62     if name is not None:

UnknownError: 2 root error(s) found.
  (0) Unknown:  IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed
Traceback (most recent call last):

  File "blah\tensorflow\python\ops\script_ops.py", line 249, in __call__
    ret = func(*args)

  File "blah\tensorflow\python\autograph\impl\api.py", line 620, in wrapper
    return func(*args, **kwargs)

  File "blah\tensorflow\python\data\ops\dataset_ops.py", line 891, in generator_py_func
    values = next(generator_state.get_iterator(iterator_id))

  File "blah\tensorflow\python\keras\engine\data_adapter.py", line 807, in wrapped_generator
    for data in generator_fn():

  File "blah\keras_ocr\detection.py", line 642, in get_batch_generator
    lines=lines) for lines in line_groups

  File "blah\keras_ocr\detection.py", line 642, in <listcomp>
    lines=lines) for lines in line_groups

  File "blah\keras_ocr\detection.py", line 107, in compute_maps
    line, orientation = tools.fix_line(line)

  File "blah\keras_ocr\tools.py", line 520, in fix_line
    sortedx = centers[:, 0].argsort()

IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed

	 [[{{node PyFunc}}]]
	 [[IteratorGetNext]]
  (1) Unknown:  IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed
Traceback (most recent call last):

  File "blah\tensorflow\python\ops\script_ops.py", line 249, in __call__
    ret = func(*args)

  File "blah\tensorflow\python\autograph\impl\api.py", line 620, in wrapper
    return func(*args, **kwargs)

  File "blah\tensorflow\python\data\ops\dataset_ops.py", line 891, in generator_py_func
    values = next(generator_state.get_iterator(iterator_id))

  File "blah\tensorflow\python\keras\engine\data_adapter.py", line 807, in wrapped_generator
    for data in generator_fn():

  File "blah\keras_ocr\detection.py", line 642, in get_batch_generator
    lines=lines) for lines in line_groups

  File "blah\keras_ocr\detection.py", line 642, in <listcomp>
    lines=lines) for lines in line_groups

  File "blah\keras_ocr\detection.py", line 107, in compute_maps
    line, orientation = tools.fix_line(line)

  File "blah\keras_ocr\tools.py", line 520, in fix_line
    sortedx = centers[:, 0].argsort()

IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed

	 [[{{node PyFunc}}]]
	 [[IteratorGetNext]]
	 [[IteratorGetNext/_4]]
0 successful operations.
0 derived errors ignored. [Op:__inference_train_function_7457]

Function call stack:
train_function -> train_function

I updated to the lastest code but got the same error... the difference with icdar is that my characters are defined in quadrangles, not axis-aligned boxes... could that be the issue ?

Sorry, I found out my dataset has some missing data. I fixed it


Use original triton op type to construct print format specifier for device_print

The core Triton is a small number of people, and we receive many PRs (thank
you!).  To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.

This PR aims to address https://github.com/triton-lang/triton/issues/4248, to correctly device_print the value if it is an signed integer.
The signness info is lost when lowering TTGIR to LLIR (e.g. i32 is always signless in MLIR), but the lowered data type is currently being used for constructing the format specifier in the PrintOpToLLVM implementation (https://github.com/triton-lang/triton/issues/4248#issuecomment-2241253835), so a negative value is printed out as an unsigned int, thus confusing users.
This PR proposes to rely on the original triton op data type to determine the format specifier, as it retains the original signness info.
A minimal reproducer is
import torch
import triton
import triton.language as tl

@triton.jit
def print_kernel(ptr):
    value = tl.load(ptr)
    tl.device_print("value in kernel from device_print", value)

print_kernel[(1,)](torch.tensor(10, dtype=torch.int32).cuda())
print_kernel[(1,)](torch.tensor(-10, dtype=torch.int32).cuda())
print_kernel[(1,)](torch.tensor((1 << 31) + 1000, dtype=torch.uint32).cuda())

Previously, it prints
pid (0, 0, 0) idx () value in kernel from device_print: 10
...
pid (0, 0, 0) idx () value in kernel from device_print:<PHONE_NUMBER>
...
pid (0, 0, 0) idx () value in kernel from device_print:<PHONE_NUMBER>

(always as unsigned int)
Now it prints correctly
pid (0, 0, 0) idx () value in kernel from device_print: 10
...
pid (0, 0, 0) idx () value in kernel from device_print: -10
...
pid (0, 0, 0) idx () value in kernel from device_print:<PHONE_NUMBER>

Extra LIT tests and python unit tests are added as well; also manually verified that they failed without the fix and passing now by running
$ pytest python/test/unit/language/test_subprocess.py
$ cd python/build/cmake.linux-x86_64-cpython-3.10; lit test

Complete the following tasks before sending your PR, and replace [ ] with
[x] to indicate you have done them.

[X] I am not making a trivial change, such as fixing a typo in a comment.

[X] I have written a PR description following these
rules.

[X] I have run pre-commit run --from-ref origin/main --to-ref HEAD.

Select one of the following.

[X] I have added tests.

/test for lit tests
/unittest for C++ tests
/python/test for end-to-end tests

[ ] This PR does not need a test because FILL THIS IN.

Select one of the following.

[ ] I have not added any lit tests.
[X] The lit tests I have added follow these best practices,
including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)

looks like interpreter tests are failing

Yeah, because the function signature has been changed

looks like interpreter tests are failing
Yeah, because the function signature has been changed

yeah sorry missed it; fixed now
(I did not get a chance to really test it myself yet though; traveling out of town; hoping the automated integration test could verify it)

Looks good, thanks for adding that. Few more nit comments and this is good to go

Thanks for the review! PR description updated; PTAL


clangd consuming too much disk space and cpu

-- /tmp is completely filled up, taking around ~150G and all files are pch files. I work on a project of decent size, bit it should not be taking around ~150G of disk space.
-- around ~50 clangd processes have been running for more than a day now.
System information
Output of clangd --version:
[I] ➜ clangd --version
clangd version 10.0.0-4ubuntu1~18.04.2
Editor/LSP plugin:
Neovim/coc.nvim
Neovim version:
NVIM v0.4.4
Build type: Release
LuaJIT 2.1.0-beta3
Coc installed using: Plug 'neoclide/coc.nvim', {'branch': 'release'}
Operating system:
[I] ➜ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.4 LTS
Release:	18.04
Codename:	bionic
Other plugins:
Plug 'tpope/vim-sleuth'
" vim-clang-format takes the clang-format from the project root.
Plug 'kana/vim-operator-user'
Plug 'rhysd/vim-clang-format'
""" Git integration.
" Shows a git diff in the sign column.
Plug 'airblade/vim-gitgutter'
" Git wrapper so awesome, it should be illegal :D
Plug 'tpope/vim-fugitive'
" Auto completion support.
Plug 'neoclide/coc.nvim', {'branch': 'release'}
" Syntax highlighting support. Needs coc.nvim installation.
Plug 'jackguo380/vim-lsp-cxx-highlight'

-- /tmp is completely filled up, taking around ~150G and all files are pch files. I work on a project of decent size, bit it should not be taking around ~150G of disk space.

Those pch files are temporary and deleted when clangd exits. So them being around implies:

Clangd is still running and you've opened a lot of different files, hence it is still keeping the pchs around.
Clangd has crashed and didn't manage to clean those up.

And assuming you've got 50 clangd processes (which should correspond to 50 editor instances, a sane editor/plugin should spawn only one clangd per editor instance, and shut it down on exit). It sounds a lot like you might have the first problem.
If you have a lot more clangd instances than there's editor instances, something might be off, possibly with the plugin.

@kadircet I am not working with 50 files. In fact, the list of files I have opened is only limited, maybe 7. Not sure which plugin is leaking these. I do occasionally see a few error messages like connection lost to the server(or something like that), but they seemed harmless. Let me get back with more information.

hi @amandeepgautam i am closing this due to inactivity. please re-open if you find more info.

@kadircet Sure. I was not able to reproduce this anymore and things are working fine for some time now. Thanks.

I've been having the same issue with clangd version 10.0.0, installed by my Ubuntu package manager. After a day or two of using the emacs eglot LSP client, I noticed over 600 GB of .pch and .pch.tmp files in my /tmp directory. Upon further investigation, I discovered that clangd was seg-faulting every few seconds, and each time it seg-faulted, the LSP client spawned a new instance to reconnect. Here's the issue I submitted against eglot before realizing the problem was with clangd. Once I'd switched to a source build of clangd 13.0.0, the problem went away, but I'd like to be able to use a more stable version of clangd.

yikes :/ unfortunately there's little we can do without a reproducer of the crash. first of all you can try setting --background-index=false and check if crash is triggered by a file you are editing (if crash doesn't go away).
If it doesn't go away, you can provide -j=1 to limit indexing to a single thread, then by looking at clangd logs you'll know which file triggered the crash again.
Afterwards you can generate a reproducer of the crash and send it here, so that we can fix the issue (and make it available with 12 release hopefully).

why setting -j=1 seems not working?


[5pt] Create tool to create inundation files for a unit for all applicable benchmarks

Create tool to create inundation files for a unit for all applicable benchmarks. It is just a wrapper file that can be run on it's own using benchmark data. A unit has it's own HUC8 number, so it can scan the benchmark folder looking for it's HUC as part of the folder name which gives this tool the files it needs to run inundation on all applicable stages. It's outputs go into the unit folder.. final/inundation/{file name}. The output file names needs to keep the benchmark code at the front of the file. eg. ble_100yr_inundation.gpkg  and  ble_500yr_inundation.gpkg. Multiple benchmark inundation outputs can all go in this same folder of final/inundation

This Issue is no longer relevant. The new tool, run_unit_benchmark_test.py, PR 283,  will take the applicable HUC from the unit name and download the exact correct benchmark files it needs process. For bulk processing, we generally won't need it but we mostly the new tool of s3_batch_evaluations.py.  Note: That does not push back to S3 as it is assumed the user wants to review it and will upload manually when they are ready.


I've added bigbird's attention to my model, but not seeing a decrease in memory

I've replaced the attention layers in Enformer with those in bigbird, but the memory usage calculated by tf.get_memory_info shows the usage is still basically the same (within 1%). I'm wondering if I need to include code from the encoder or decoder to see a decrease in memory usage?
Thanks!

To clarify, you are using https://github.com/google-research/bigbird/blob/5f2a5aa7fbab23e32e0e0b41c5f0192f0c023e05/bigbird/core/attention.py#L637 with attention_type = 'block_sparse' ?
What's your sequence length ?

Yes, the memory used increases with sequence length.
I'm not using XLA, and thanks for the tip!

https://www.tensorflow.org/guide/profiler#memory_profile_tool may also be useful. The XLA memory viewer (https://cloud.google.com/tpu/docs/pytorch-xla-performance-profiling-tpu-vm#memory_viewer) is better but both are useful.


github: Add check-clang.sh workflow

This has been ported over from the first continuous integration setup.
Closes: https://github.com/ClangBuiltLinux/continuous-integration2/issues/95

TIL about tuxmake docker images :) thanks!


Error with install_lua_modules.sh

nutty@Dream-machine:~/waifu2x$ bash install_lua_modules.sh
install_lua_modules.sh: line 16: luarocks: command not found
install_lua_modules.sh: line 17: luarocks: command not found
install_lua_modules.sh: line 18: luarocks: command not found
install_lua_modules.sh: line 19: luarocks: command not found
install_lua_modules.sh: line 20: luarocks: command not found
Cloning into '.cudnn'...
remote: Enumerating objects: 2074, done.
remote: Total 2074 (delta 0), reused 0 (delta 0), pack-reused 2074
Receiving objects: 100% (2074/2074), 801.49 KiB | 1.54 MiB/s, done.
Resolving deltas: 100% (1351/1351), done.
install_lua_modules.sh: line 11: luarocks: command not found
install_lua_modules.sh: line 22: luarocks: command not found

luarocks: command not found

Torch7 not installed.
Also, Torch7 may be difficult to install in recent environments due to CUDA and qt version issues

这是来自#@邮箱#的自动回复邮件。 您好，发送的邮件已经收到，我将尽快给您回复。感谢您的来信


AB#5023 - Reactivated and Updated Yup validation

Proposed changes

Related issues

Checklist

[ ] I consider the submitted work as finished
[ ] I tested the code for its functionality
[ ] I wrote test cases for the relevant uses case
[ ] I added/update the relevant documentation (either on github or on notion)
[ ] Where necessary I refactored code to improve the overall quality

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

This looks good. @r-joyce please merge.


.Net: cl100k_base tokenizer

The existing GPT3Tokenizer class uses p50k_base encoding. GPT-3.5, GPT-4, and text-embedding-ada-002 all rely on cl100k_base encoding.
The below table is extracted from the OpenAI notebook on token counting.

Encoding name
OpenAI models

cl100k_base
gpt-4, gpt-3.5-turbo, text-embedding-ada-002

p50k_base
Codex models, text-davinci-002, text-davinci-003

r50k_base (or gpt2)
GPT-3 models like davinci

SharpToken

@dluc are you able to look into this?


Training

Hi, I just try to train with other scenes in llff datasets. How to make a dataset like flower as I noticed that there is a masks and segments subfolder under the flower folder.

segments and masks are not required for training NeRF-SOS, but are required for semantic-NeRF. You can safely remove the requirement of masks and segments in gen_dataset.py


csvParserPipe creates invalid xml when column names contain spaces

Current Behavior
When I feed an csv to the csvparserPie and the headerline values contain spaces these spaces are not escapedand directly used in the generated xml elements
Expected Behavior
I would expect the spaces and other unwanted chars to be removed or escaped (f.e. replaces with "_") so my xml is valid
Environment Information
FF 8.2
Steps To Reproduce
No response
Configuration
<Adapter name="processfile">
	<Receiver name="processfile">
		<DirectoryListener
			inputFolder="c:\temp\input"
			inProcessFolder="c:\temp\inprocess"
			processedFolder="c:\temp\processed"
			createFolders="true"
			messageType="contents"/>
	</Receiver>

	<Pipeline>
		<Exits>
			<Exit name="READY" state="SUCCESS"  />
		</Exits>
		<CsvParserPipe name="parsecsv" fieldSeparator=";" prettyPrint="true"/>
	</Pipeline>
</Adapter>

Input
access-code-password-recovery-code.csv
What database are you using?
No response
What browsers are you seeing the problem on?
No response
Relevant Log Output
<csv>
<record>
<Identifier>9012</Identifier>
<Access code>12se74</Access code>
<Recovery code>rb9012</Recovery code>
<First name>Rachel</First name>
<Last name>Booker</Last name>
<Department>Sales</Department>
<Location>Manchester</Location>
</record>
<record>
<Identifier>2070</Identifier>
<Access code>04ap67</Access code>
<Recovery code>lg2070</Recovery code>
<First name>Laura</First name>
<Last name>Grey</Last name>
<Department>Depot</Department>
<Location>London</Location>
</record>
<record>
<Identifier>4081</Identifier>
<Access code>30no86</Access code>
<Recovery code>cj4081</Recovery code>
<First name>Craig</First name>
<Last name>Johnson</Last name>
<Department>Depot</Department>
<Location>London</Location>
</record>
<record>
<Identifier>9346</Identifier>
<Access code>14ju73</Access code>
<Recovery code>mj9346</Recovery code>
<First name>Mary</First name>
<Last name>Jenkins</Last name>
<Department>Engineering</Department>
<Location>Manchester</Location>
</record>
<record>
<Identifier>5079</Identifier>
<Access code>09ja61</Access code>
<Recovery code>js5079</Recovery code>
<First name>Jamie</First name>
<Last name>Smith</Last name>
<Department>Engineering</Department>
<Location>Manchester</Location>
</record>
</csv>

Anything else?
No response

Can this also be done for plus sign? Should i make a new issue for this? We also have a csv where there are plus signs in the csv headers
e.g.
naam;woonplaats+postcode;telnr
i'd like the plussign to be replaced with an underscore as well


Lumen TOS

Another for you! I don't think they have a full-on TOS but they have http://lumenlearning.com/copyright/ and some related attribution guidelines. If you could take a look and see if anything rings bells, that would be great.
Lumen has these types of content:

very small amount of informational content owned by Lumen
third party courses and materials owned by institutions, orgs, or faculty teams that Lumen works with to mark content and host on their candela back-end platform
faculty contributed edits defaulted under cc by per separate agreements with schools they work with. edits are public but dont get put into canonical version of course until lumen approves

I've reviewed. We can discuss later today.


2 storyshots libraries???

 Issue by pyros2097
Saturday Mar 04, 2017 at 12:18 GMT
Originally opened as https://github.com/storybooks/storyshots/issues/82

Why are there 2 storyshots libraries? Which one should I use. Its  seems they are different versions also.
npm i -D @kadira/storyshots
npm i -D storyshots

 Comment by mnmtanish
Saturday Apr 01, 2017 at 11:07 GMT

Please use the storyshots module


[Improvement] Unify the modification behavior of the comment field.

What would you like to be improved?
Currently, only the fileset supports the removeComment change; other entities like catalog and table only support updateComment changes. Additionally, newComment cannot be null or an empty string. We should unify this behavior.
How should we improve?
Unify the modification behavior of the comment field：

deprecated the removeComment change
the new comment of updateComment supports null and empty string

@mchades i want to have a try.

@koonchen No problem! Please go ahead and feel free to ping me if you have any questions

Deprecate the removeComment change across all entities.
Reasoning: With the new behavior of updateComment (detailed below), removal of comments can be handled using this existing operation instead of a separate change type.

Allow null or empty string as valid values for newComment in updateComment.
If newComment is null or an empty string, it should be interpreted as removing the comment.

@AbhiSharmaNIT Yeah, you summed it up correctly!
I have not seen @koonchen  submit the relevant PR so far, so I think if you are interested in this issue, you can also submit a PR.

@mchades this week is a national holiday, and you didn't assign me

@mchades this week is a national holiday, and you didn't assign me

assign is not a required step, you can start at any time.

@mchades I don't think so. You need to let others know the urgency and responsibility of the matter.

@mchades I don't think so. You need to let others know the urgency and responsibility of the matter.

I think the comments on the issue are sufficient. If you care about this, it has been assigned to you now, so please start as soon as possible.
Others can also submit at any time before relevant PRs are submitted.


fix: change partition limit for new topic creation

Verification
#fail
rhoas kafka topic create --partitions=3000
# pass
rhoas kafka topic create --partitions=900

Looks good. These tests need to be updated.

Done


netdata: Fix netdata-claim.sh

Motivation for this change
This should fix the first issue listed in  #127375, namely that the netdata-claim.sh script is unable to find both openssl and sbin/netdatacli.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 127381 at 24d5b050 run on x86_64-linux 1

1 package built successfully:

netdata

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/tools/system/netdata/default.nix:92:5:
   |
92 |     maintainers = [ ];
   |     ^


Updating to current version v1.0.6

Coverage decreased (-0.3%) to 76.433% when pulling 90361631e9e58e440d291582ec0d134bf70a30bf on master into d30d22fe4752aab478892d0fc5f7086976d1f1d6 on develop.


[BEAM-13534] Update TestAutomatedExpansionService liveness check to not depend on exec call

Simplify integration test significantly using gRPC functionality, re-enable test on Samza and Spark.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

 I think we've got it?

I think it's there, should be a good place to leave it for the holidays


Add unit tests

Changes Unknown when pulling 9e2e53002170ddde17b5398459d492f23ba067ce on feature/unit-testing into ** on master**.

Changes Unknown when pulling 94fbf344de52998e551d7babd56a752395e4e758 on feature/unit-testing into ** on master**.

YOLO merge to fix critical bugs! <3


X-Frame-Options is deprecated - the corresponding information should also be added using content-security-policy header

PHP Version: 8.3   | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Platform(Default)

Expected behaviour:
Also add corresponding frame-ancestors information in content-security-policy (at least by default) for storefront, etc.
Actual behaviour:
Currently the CoreSubscriber adds X-Frame-Options with DENY which makes sense. However, that header is actually deprecated,
so it can still be used but the corresponding information should also be added using Content-Security-Policy header to be safe in the future.
How to reproduce:
see above

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-38817
[created from NEXT-38817, comment 502152]


Bleak error message for variance mismatch with parent

Input
→ View on sorbet.run
# typed: true

module Parent
  extend T::Generic
  Elem = type_member(:out)
end

module Child
  extend T::Generic
  include Parent
  Elem = type_member(:in)
end

Observed output
editor.rb:11: Type variance mismatch with parent Parent https://srb.help/5015
    11 |  Elem = type_member(:in)
          ^^^^^^^^^^^^^^^^^^^^^^^
Errors: 1

Expected behavior

Should show what the variance in the child and parent is
Should attempt to explain (briefly) why this is not allowed
Should show the location of the matching type member in the parent

To top it all off, there are no tests for this in Sorbet right now.

I've added docs for this error message in the error-reference that we should encourage people to look at.


add the new shardmasters to iabak

You might want to test Group.hasUser; I wasn't actually able to test it.

Please submit changes to http://propellor.branchable.com/todo/ instead of using github pull requests, which are not part of my workflow. Just open a todo item there and link to a git repository containing your changes. Did you know, git is a distributed system? The git repository doesn't even need to be on github! Please send any complaints to Github; they don't allow turning off pull requests or redirecting them elsewhere.  -- A robot acting on behalf of Joey Hess


Use lineup for tabular data

Should make a mockup before investing too much time.
https://lineup.js.org/integrations/react

Proposal: In the div at the bottom, where we eventually want a heatmap, have a lineup table with four columns:

The name of a cell cluster
The total number of cells of that type
The number currently selected

Is this good, or would something else be more useful?

Could we bring in other data for the genes to make a good example?

Let's make a LineUp module for cells that would show each cell and it's attributes as a row in LineUp.
@ThHarbig: let's talk about whether this is something you could do as a little excursion, also to give us feedback on how easy it is for outsiders to create additional Vitessce views.


CODE folder containing projects that can be compiled and linked at runtime.

This issue is to track the progress of the CODE folder and it's implementation.

Needs a bit more polishing, such as being able to start all characters at once. Also applies to services.


Feat/776 Resizable panes in trading app

Related issues 🔗
Closes #776
Description ℹ
Modifies the Trading Grid page such that the sections can be resized.
Demo 📺
https://user-images.githubusercontent.com/981531/179237218-5c20999b-ac1c-412c-b050-643b92067027.mp4
Technical 👨🔧
I've not spent much effort on the styles. Specifically, I'm thinking about any padding/margins around components now that I've removed the CSS grid layout. Happy to take some guidance.

I have checked out this branch and played around with it, and I would be really happy to see this merged. Are there any known issues that prevent this from being merged (apart from waiting for review)? @mattrussell36 @edd

I've made a few tweaks and I'm happy for it to move to review and merge.

Having had a quick play with this, I think it's great, though have noticed a couple issues.
One is with the bottom panel (positions/orders/collateral). You don't seem to be able to resize it below the default value other than to hide it completely.  Once hidden it's quite fiddly to bring it back. Not impossible, but I can see some users getting stuck.
I'd suggest allowing the user to resize freely below the default height. In terms of bringing it back from being closed completely, a nice solution would be to still show the tabs at the bottom but no panel content, and then have it pop open again if the user clicks the tab. I'm presuming that might be quite a bit of work, so maybe a easier fix would be just to disable the ability to hide it completely, by setting a minimum height or something.
Also, when you resize your chart, the Y-axis label overlaps the high/low data at the top. Might be better if the high/low bar wraps when it's not got room.

One other point, is that we don't currently have any local saving of state (eg, what market you'd selected, what tabs you had selected) which is a bit inconvenient, but potentially becomes annoying if we add customisability like this which you have to re-do every time you access the platform.

Tested this : following the video for guidance, all together a pleasant experience where i as the user feel in full control of the sizing, very intuitive, some slight ugly wrapping with the middle pane field values when at minimum, but thats to be expected.


[turborepo] Non-deterministic turbo change detection when using certain workspace configs

What version of Turborepo are you using?
1.8.3
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Describe the Bug

Multiple invocations of turbo --dry are giving non-deterministic results. To isolate variables I've disconnected from the internet, used --force etc. None of that seemed to make it stable.
I spoke about this with @mehulkar and @gsoltis privately.
Expected Behavior
If all things equal, multiple invocations of a build should give deterministic results.
To Reproduce
Don't currently have time to create a reproduction as it's embedded in a very complex monorepo. Turbo setup is pretty vanilla.
{
  "$schema": "https://turbo.build/schema.json",
  "pipeline": {
    "build": {
      "dependsOn": ["^build"],
      "outputs": ["dist/**", "build/**"]
    },
}

Reproduction Repo
No response

  - 'apple'
  - 'apple/deployments/*'
  - 'apple/packages/**'

I think was the problematic setup in pnpm-workspace.yaml. There are package.jsons at all these levels. I changed it to:
  - 'apple/**/*'

Which seems stable but y'all do mention in docs that nested workspaces are not supported.

I'm going to close this in favor of #4178 since it turned out to be a feature that's not currently supported.

👍🏼 sounds good to me!


Fix query output

Query output was broken for GNQLs with more than 10k results.  This fixed it and provides a better experience when using the text output option.

@bradchiappetta instead of limiting the output to 10 by default, should we simply hardcode size=10 to the request so we only pull 10 from the server? This would make it much faster. We could add a size or max_results parameter to enable people to grab more.
Otherwise, I feel good to sign off.

@andrew-morris : the problem with that suggestion is that if folks want to use other output formats besides the default Text (like JSON) they would only get 10 results, and I think the desire here is to allow the other non-text formats to pull the full result query when desired.


Plugins for APEX

Creating plugins for APEX might be helpful.

where i can found it ?

They are not yet implemented :).


[Device Support Request] Decoupled mode for Xioami Aqara wall switch (lumi ctrl_neutral)

After 0.0.62 version bump into new HomeAssistant I tried using the switch in decoupled mode. I made the changes in the cluster configuration (BasicClusterDecoupled -> decoupled_mode_left & decoupled_mode_right), using value 254 for decoupled.
This worked, and now I'm receiving zha_event in HomeAssistant any time a button is pushed, but I'm not able to distinguish left from right button from the event data:
Left button:
{
    "event_type": "zha_event",
    "data": {
        "device_ieee": "00:15:8d:00:03:5a:39:cb",
        "unique_id": "00:15:8d:00:03:5a:39:cb:4:0x0006",
        "device_id": "cb97e9c30a5411eb83b8d70661890843",
        "endpoint_id": 4,
        "cluster_id": 6,
        "command": "attribute_updated",
        "args": {
            "attribute_id": 0,
            "attribute_name": "on_off",
            "value": 0
        }
    },
    "origin": "LOCAL",
    "time_fired": "2021-10-07T13:48:49.133884+00:00",
    "context": {
        "id": "7c59476337bdfa17d778fbc430a16900",
        "parent_id": null,
        "user_id": null
    }
}

Right button:
{
    "event_type": "zha_event",
    "data": {
        "device_ieee": "00:15:8d:00:03:5a:39:cb",
        "unique_id": "00:15:8d:00:03:5a:39:cb:4:0x0006",
        "device_id": "cb97e9c30a5411eb83b8d70661890843",
        "endpoint_id": 4,
        "cluster_id": 6,
        "command": "attribute_updated",
        "args": {
            "attribute_id": 0,
            "attribute_name": "on_off",
            "value": 0
        }
    },
    "origin": "LOCAL",
    "time_fired": "2021-10-07T13:48:50.917194+00:00",
    "context": {
        "id": "21ba5824a248f7fae8784e95841b01f0",
        "parent_id": null,
        "user_id": null
    }
}

How could I identify one button from another, to create an automation?

Have you tried to add an automation from the device view?
Or from the automations view selecting as trigger the device?

if I'm not mistaken, you should see several options listed like "button_N" [Short|Double] press

I just realized that the device is of type ctrl_neutral and not the ctrl_ln I was checking.
ctrl_neutral currently has no events implemented for the second button. The PR #761 is stale and does not look like it is going to advance.
If you have availability to do tests (with local quirks), I can try to implement the quirks for the second button.

Im trying to change aqara wall switch h1 EU - lumi.switch.n2aeu1 to decoupled mode. @alceasan how did you do that? were you able to integrate this switch to hassio in decoupled mode?

No, I integrated it in normal mode. I don't think you can join the switch in decoupled mode because the device resets on joining a new zigbee network and goes back to coupled mode.
After joining to the zigbee network, I changed to decoupled mode using clusters:

i was wondering, because of that reset  after pairing.
I dont have clusters ff22 and ff23 in list of cluster for my switch, so also this needs to be added for lumi.switch.n2aeu1


[stubs] Prevent CMake from linking with object lib

Attempting to link against an object library results in a CMake error. Prevent such an error by removing a line I mistakenly added in b86125ac.

Ah, is that where the Linux-only error we've been seeing came from?

@jrose-apple Yes, looks like it.

@swift-ci Please test Linux platform

@swift-ci Please smoke test OS X platform

Ah, is that where the Linux-only error we've been seeing came from?

Yes, my apologies! 🙇

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 49248a44c26d17a6c748f9db553ec90f3b6d4c06
Test requested by - @jrose-apple

The test failure on Linux appears unrelated. More importantly, the Linux build of the runtime succeeded, which indicates the patch works as expected.

Yeah, we need to get this in. @swift-ci Please smoke test

@jrose-apple Smoke test appears to have passed. Sorry again for the build break! 😞

@jrose-apple I am going to merge this since it passed the tests and you said it "needs to get in".


secure connect failure

can you let us know the possible error values and reasons for secure connect response failure.
We are seeing 0x80070057(invalid argument) error from event viewer bio-metric log with EventId as 1609.
We have used mbedtls+github(secureDeviceConnectionProtocol) sources to generate secure connect response to sensor adapter library.
We are using Test signing machine with bio-metric service enable and observed that windows event viewer detected secure connect response and returned above error.

Hi prafulla-git,
 I'am confused about the model certificate usage, can you explain for me:
 1. new SDK add IntermediateCA1 and IntermediateCA2, device should preserve and transmit these to driver?
 2. root CA aleady exist in Windows?

thank you!

@prafulla-git How you were able to generate Test certificates from Test vectors and install on windows 10?

Hi,
Are you asking about how the test certificate installed on win 10?, if so,
Test certificate is already installed on win 10 when you enable Test
signing mode on win 10.
In case if are asking about how to generate intermediate CA1/CA2 from test
certificate,  it can be converted to hex format from the installed
certificate on win10 when test signing is enabled.
Thanks,
Prafulla
On Wed, 5 Apr 2023 at 6:44 PM, Yaduvir Singh @.***>
wrote:

@prafulla-git https://github.com/prafulla-git How you were able to
generate Test certificates from Test vectors and install on windows 10?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/SecureDeviceConnectionProtocol/issues/17#issuecomment-1497467291,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKHXRSMKMI6UMGB5HJAAWK3W7VV37ANCNFSM4F4QEZOQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Thanks,
Prafulla Kota
9866544810

I have test signing mode enabled, But I don't see any certificate in the root or intermediate CA named "Secure Bio Sensor". I am getting 0x80070057(invalid argument) just like yours on secure connect. I return 3359 Bytes ( Model 846Bytes, ICA1 1025 Bytes, ICA2 1114 Bytes) to the sensor connect response. But i don't see an installed certificate in Windows 10 machine. Do you see "Secure Bio Sensor" certificate pre installed on test signing mode on like below?. I dont have this certificate installed but i got a picture from other bug filled

Hi,
I also didn't see this certificate under certmgr, But a similar certificate
is generated by us and signed by MSFT to work with production model keys,
when i open the .cer file we have generated, it displays in a similar way.
I am yet to recollect if there was a certificate visible like this for the
MSFT Test certificate.
Are you using the keys provided at below link for Test certificate?
https://github.com/Microsoft/SecureDeviceConnectionProtocol/wiki/Secure-Device-Connection-Protocol
I hope you have enabled secure biometrics via registry entries and post
enabling that, you should see "bioiso.exe" is running on the system.
Thanks,
Prafulla Kota
On Wed, Apr 5, 2023 at 10:42 PM Yaduvir Singh @.***>
wrote:

I have test signing mode enabled, But I don't see any certificate in the
root or intermediate CA named "Secure Bio Sensor". I am getting
0x80070057(invalid argument) just like yours on secure connect. I return
3359 Bytes ( Model 846Bytes, ICA1 1025 Bytes, ICA2 1114 Bytes) to the
sensor connect response. But i don't see an installed certificate in
Windows 10 machine. Do you see "Secure Bio Sensor" certificate pre
installed on test signing mode on like below?. I dont have this certificate
installed but i got a picture from other bug filled
[image: image]
https://user-images.githubusercontent.com/104233060/230154281-194ba0ae-e572-48ff-b00a-c8b44f8ccb14.png
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/SecureDeviceConnectionProtocol/issues/17#issuecomment-1497845781,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKHXRSNHAJFONFGILFHLL3DW7WRXBANCNFSM4F4QEZOQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Thanks,
Prafulla Kota
9866544810

Thanks, It resolved secure connect. But Starting the Windows Hello Enrollment first time  EngineAdapterIdntifyFeatureSetAuthenticated is called as there is no template enrolled i return WINBIO_E_UNKNOWN_ID which results in event "Windows Biometric service could not complete an identification process" with no Error. How to make this function pass? i tried returning S_OK, WINBIO_E_NO_MATCH, WINBIO_E_ENROLLMENT_IN_PROGRESS all of them returns some error event in event viewer.

I had forgotten to close it during Oct 2018, Closing it now.


Bump Version to v1.0.0

Codecov Report

Merging #7 (4c83406) into master (422e634) will decrease coverage by 4.25%.
The diff coverage is 23.54%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   40.37%   36.11%   -4.26%
==========================================
  Files           7        7
  Lines         265      407     +142
==========================================
+ Hits          107      147      +40
- Misses        158      260     +102

Impacted Files
Coverage Δ

nexo/exceptions.py
39.13% <0.00%> (ø)

nexo/client.py
29.08% <18.95%> (+2.82%)
:arrow_up:

nexo/response_serializers.py
20.89% <20.89%> (ø)

nexo/helpers.py
92.30% <83.33%> (-7.70%)
:arrow_down:

nexo/__init__.py
100.00% <100.00%> (ø)

tests/test_api_request.py
100.00% <100.00%> (ø)

tests/test_helpers.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1022c07...4c83406. Read the comment docs.


Wayland support

I'v tested the examples using sway, weston (wayland) and i3 (X11) WM and key input in wayland seems to be broken, it does nothing when in X11 it turn the model.
Also related to wayland and to tiling WM (this bug appear only in sway and not in weston) the display size of the content of the window is cut, resizing the windows fix it.

Oh, this might be bug in winit actually. I'm working on Windows, but checking linux version in Ubuntu on virtual machine, and I have some weird input issues there too, need a closer look at this. Also there is might be a chance that I misused winit someway.

Just to give an update on this, I use Ubuntu 21.04 on wayland and winit 0.25.0, and I haven't noticed any input issues so far. I can rotate the model in the example "simple" using A and D keys. In my own app, I use mouse movement (device event) and keyboard (window) events successfully.
The screenshot in this bug report no longer works.
However, I have noticed that the "simple" example and my own app have issues when manually enlarging or maximizing the window. The window decoration resizes correctly and the rg3d rendering process apparently "updates" correctly to produce a larger frame, but then frame is cropped in old, smaller dimensions. When manually shrinking the window to smaller than default dimensions, the renderer correctly produces a smaller frame, but then a black border/frame/box is added "outside" the window decorations using the same size as the "original" window.  Resizing the window again won't fix it this time.


Support for using a custom system image?

pyjulia allows starting julia with a system image, like this Julia(sysimage=sys_image_path). Is something like this possible in juliacall?
I've started a project with pyjulia. I include a subdirectory and Julia code to compile a system image with PackageCompiler. I include a python function that performs all the steps, instantiating the compilation project and doing the compilation. Then, when my python module is imported the next time and the custom system image is found, it is used. It would be great to be able to do something like this with pythoncall.

It would be easy enough to add an environment variable to select a sysimage to use. I'll put it on the to-do list
I think what you want though is for a package to be able to choose the sysimage? The problem with that is that the sysimage is a global choice, so what happens if another package also wants to choose a sysimage? Something possible could be to have a mechanism to automatically create sysimages, and packages could define scripts to get run when creating the image.

Exactly. I want the user to install my python package, and then be able to push a button to make the code load and run more like statically compiled code.
I'm not super familiar with culture of python packages. In particular, is the installed package tree is meant to be immutable, as it is in Julia? But, at the moment, I store this system image and some user choices in the source tree of the Python package.
What I have is a bit fragile. Here is the directory where the sysimage is created. And for simplicity, it is not installed elsewhere, but rather lives here.
This is the python function that complies the system image. This is the "button" to push.
And here is the code that loads the system image if present.

By global I meant that when you fire up Julia, it can only use one sysimage. That means that if there are two packages which would like to be able to control the sysimage being used, they will conflict with each other. So there are two options:

Have the user explicitly choose which sysimage to use, e.g. via an environment variable.
Have the JuliaCall package itself generate and use a sysimage, providing a way for different packages to signal what they need to be compiled into the image.

In the short term, option 1 is really simple to add so I'll do that. So you can provide your users with a script to generate a sysimage and tell them to use the environment variable, if they want to.
Option 2 would be really neat, but will be a fair bit of work. It would certainly make using custom sysimages seamless: packages  essentially just provide precompile scripts, and JuliaCall would gather these up and generate a sysimage automatically. So this is on the to-do list, but further down the list.

Issues for these two options are #73 and #76 if you'd like to track those.

I think option 1 is a good way to get the ball rolling. It allows python packages that depend on juliacall to experiment with ways to compile and use a system image.

Closing, but happy to discuss further.


Static Assets Option 2 (Use a deploy identifier, don't fingerprint files)

This approach:
I think it is best overall. It is the simplest approach (although option 3 is the simplest change from current practice). It solves the circular request in the public folder without having to bundle everything (which option 1 requires).
How it works:

Use the BEGIN_DEPLOY_DATE env variable to hash for a deploy ID (i.e. XYZ). (or as a fallback set an deploy ID in a file or env).
Do a simple search and replace on every outgoing response changing /_public/ -> /_public/v-XYZ/
Deploy static assets with no fingerprinting (and no static.json needed).
Any request to /_public/v-XYZ/foo.mjs gets the 200 response and is cached forever.
Any incorrect request to /_public/v-NOPE/foo.mjs or /_public/foo.mjs gets 302 redirect to /_public/v-XYZ/foo.mjs
When any static asset is served do the same replacement for /_public/ -> /_public/v-XYZ/. This solves the circular reference problem. It does not solve the waterfall issue, but this bundling can be done with the opt in @bundles pragma.

Pros:

Eliminates any need for static.json or other manifest.
Doesn’t require changes to Architect (just turn fingerprinting off)
Simpler and hopefully  less error prone.
Search and replace on outgoing requests is much simpler regex (which should be faster).
Strong caching guarantees (/_public/v-XYZ/foo.mjs is as unique as /_public/foo-XYZ.mjs and can be safely cached forever).


ProtoGrain generator update

It works simple but does the job. Here are two usecases:
Example 1:
dotnet protograin.dll "MyProtoFile.Proto"
Will output a csharp class named MyProtoFile.cs
Example 2:
dotnet protograin.dll "c:\test\PathToMyProtoFile.Proto" "OutputNameOfCSharpClass"
Will output a csharp class named OutputNameOfCSharpClass.cs

Ohhh awesome :-)


Update to 3.2.1 and add license_file to recipe

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


PT-964: Restyling improvements

Description :sparkles:
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #116 (a9a10ac) into master (fbef646) will decrease coverage by 0.21%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   90.84%   90.62%   -0.22%
==========================================
  Files          86       86
  Lines        2207     2209       +2
  Branches      427      429       +2
==========================================
- Hits         2005     2002       -3
- Misses        198      203       +5
  Partials        4        4

Impacted Files
Coverage Δ

.../domain/events/eventSearchForm/EventSearchForm.tsx
90.62% <ø> (-0.29%)
:arrow_down:

src/domain/app/header/Header.tsx
73.68% <50.00%> (-12.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbef646...a9a10ac. Read the comment docs.


Feature: Detect EIP-1167 minimal proxy contracts

Some contracts are minimal proxy contracts, which we can identify simply by checking if the bytecode matches a known pattern. See the details here: https://eips.ethereum.org/EIPS/eip-1167
These contracts do a delegatecall on another contract, inheriting its logic. We can find this address by matching the pattern given in the EIP description. In the future, we may wish to show the source code of the contract that a proxy contract resolves to.

that's already implemented in my indexer prototype! pretty easy :)
will leave this open until it is published.

Completed with #1417

Completed with #1417


Some props inaccessible in code (PCL)

Hello!
I'm using CarouselView in PCL project - Profile111
It works in XAML with appropriate bindings, but some properties could not be used in code - build error on using ItemsSource, for example:
Error CS0012 The type 'IEnumerable' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
Adding reference to NetStandard 2.0 does not help.

@alexpetin try this https://github.com/dncuug/X.PagedList/issues/59#issuecomment-255189553

Installing Microsoft.NETCore.Portable.Compatibility 1.0.1.   OK https://www.nuget.org/api/v2/package/Microsoft.NETCore.Jit/1.0.2 2381ms Installing Microsoft.NETCore.Jit 1.0.2. Install failed. Rolling back... Package 'Microsoft.NETCore.Jit.1.0.2' does not exist in project 'MDU' Package 'Microsoft.NETCore.Jit.1.0.2' does not exist in folder 'C:\Work\mdu\MobileApp\D\packages' Executing nuget actions took 3.91 sec Could not install package 'Microsoft.NETCore.Jit 1.0.2'. You are trying to install this package into a project that targets '.NETPortable,Version=v4.5,Profile=Profile111', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
So, the Microsoft.NETCore.Portable.Compatibility package is incompatible with PCL Profile111...

@alexpetin could you pls try to install older prerelease versions?

btw seems Installing Microsoft.NETCore.Jit 1.0.2. cannot be installed

https://github.com/dotnet/standard/issues/542#issuecomment-465375220 ?

dotnet/standard#542 (comment) ?

PCL Profile111 project is not a NetStandard project, nothing to rename :)

@alexpetin could you pls try to install older prerelease versions?

Could not install package 'Microsoft.NETCore.Portable.Compatibility 1.0.0'. You are trying to install this package into a project that targets '.NETPortable,Version=v4.5,Profile=Profile111', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

Could not install package 'Microsoft.NETCore.Runtime.Native 1.0.2-rc2-24027'. You are trying to install this package into a project that targets '.NETPortable,Version=v4.5,Profile=Profile111', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

@alexpetin try it https://forums.xamarin.com/discussion/80045/error-using-nuget
Add project.json to your PCL

PCL Profile111 is not compatible with netstandard 2.0
Никакой жсон не поможет :)

1.x only

"CardsView": "1.6.2"

can you install this version? because this version works fine on one of my projects (i added project.json file for sure)

Yes, no errors with 1.6.2. Without any json.

@alexpetin piece of s***t :)
Hm, i will try to find workaround, but cannot promise. PCL is deprecated )

ok, thanks!

So, 1.6.2 is for PCL
If you want to use latest updates, you should migrate to netstandard


fix(typegen): don't generate relationships across schemas

PostgREST doesn't detect relationships across schemas

maybe we'll want this not only in typescript tough. So maybe some filter at relation fetching level

IIRC these are used by the dashboard to detect fkeys across schemas, so we need to keep it as is.

I wonder if that make sense for postgres-meta to not handle cross-schemas relations. PostgREST might not handle it, but postgres itself does.

The typegen is designed with PostgREST use case in mind, although it's not documented as such - we may want to make this explicit at some point though (e.g. rename the route to postgrest-types/typescript)


Duplicating HTTP proxy

@whyrusleeping
I have no clue of a better name for this.
A little proxy tool that sits between nginx and two ipfs daemons' gateways

proxies each request to both of the backends (v03x + v04x), simultaneously

we can't do this serially, because we can't reasonably time out and try the next backend

the only thing we can reliably say is when a request is successful

requests and responses should not get buffered (RAM usage!)

first successful response is sent to the client

after successful response, request/response to other backend is aborted/discarded

first error is discarded

second error is sent to the client

proxies each request to both of the backends (v03x + v04x), simultaneously

:+1:
Can we make pinbot use nginx so we can pin on both v03 and v04 at the same time?

Maybe nginx isn't the right way for pinbot, but it would be nice to be able to pin on both versions somehow.

Yes we'll take care of that too this week

:rocket:

We have multireq running fine now https://github.com/whyrusleeping/multireq


Replace the current resource-server-webapp with a version based on Spring Boot and add support for webjars

Merged (on master).


[GENERIC viewer] Don't display the errorWrapper, for documents with signatures (PR 13217 follow-up)

According to a decision by UX and PM, please see https://bugzilla.mozilla.org/show_bug.cgi?id=1705060#c2, in Firefox we should first of all not display the notification-bar for signatures. Secondly, as can also be seen there, we shouldn't display the notification-bar at all and it's thus disabled in https://bugzilla.mozilla.org/show_bug.cgi?id=1705327.
If we purposely don't display a notification, for documents with signatures, in the built in Firefox PDF Viewer then it cannot be necessary in the GENERIC viewer either.

/botio-linux preview

Thanks!


setToken function is not working

Describe the bug
The setToken function doesn't seems to work for me. I'm running into the following error:
TypeError: client.setToken is not a function.
To Reproduce
Steps to reproduce the behavior:

I just copied the Quickstart code.

Expected behavior
I expect the function to work.
Screenshots
-
Additional context
No fancy things, just a clean Node.js project. The other functions do work for me.

Hi, thank you for creating an issue.
Seems like it is a mistake in our quickstart guide.
setToken is not a method but a setter, so you could try to set token like so
client.token = "YOUR_TOKEN"

Yes, that works. Thanks!


⚠ Fortnite has degraded performance

In 78142a3, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1669 ms

Resolved: Fortnite performance has improved in 09f6d5d.


Changelog entries end up under wrong version when MR is created before but merged after release

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1038
Originally created by @DouweM on 2019-09-24 14:02:36

When adding a changelog entry using https://github.com/mc706/changelog-cli, it is automatically added under the "Unreleased" section at the top, along with any existing unreleased changelog entries. When a new version of Meltano is then released, the "Unreleased" section is renamed to the new version identifier, and a new "Unreleased" section is added at the top.
This works well for any changelog entries in the master branch, but can cause problems for changelog entries in unmerged merge requests that were created before the new version was released, but will only be merged after.
A changelog entry like this was originally added to the "Unreleased" section and should stay there, but since it was surrounded by entries that used to be in "Unreleased" but are now under "[new version]", Git will assume that it still belongs among those other entries once the merge takes place, resulting in the new entry being moved under "[new version]" as well, even though it should actually be under "Unreleased".
This happened when 0.43.0 was released, for example, which was fixed in https://gitlab.com/meltano/meltano/merge_requests/929.
The only way to currently prevent this from happening is by rebasing your branch on top of master after a new version is released, after which you'll want to manually verify that the entry ended up in the correct section, and move it if not.
Longer term, we'll likely want to do what we did at GitLab as well: all new changelog entries are added represented by individual YAML files under /changelogs/unreleased, which are automatically moved to CHANGELOG.md as part of the release process. CHANGELOG.md is never modified directly.
For more information about that approach, see:

https://about.gitlab.com/2018/07/03/solving-gitlabs-changelog-conflict-crisis/
https://docs.gitlab.com/ee/development/changelog.html

View 4 previous comments from the original issue on GitLab


Regression: Not redirected to sign-in with invalid session

Steps to reproduce:

Sign-in to your current dev install
Delete your database
Re-start the dev server
Try to navigate through the app

Expected result: You are redirected to /signin
Actual result: You are shown the "Error" page and the console contains the 401 unauthorised response error followed by 1 or more Adapter operation failed errors.

The fix for this should fall out of the work outlined in https://github.com/TryGhost/Ghost/issues/6048#issuecomment-154045037


Bootstrap has unmet peer dependency jquery

I Got this using yarn on my react project.
<EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>- 3"
"dependencies": {
.... some others,
    "bootstrap": "^4.5.0",
.... some others,
  }

This is a simple warning that means that I should have into my dependencies jquery 1.9.1 al least or is there some dependencies missing from bootstrap?

You are missing the jquer dependency. If you are adding it via another way, like HTML CDN, you can ignore that.

You are missing the jquer dependency. If you are adding it via another way, like HTML CDN, you can ignore that.

Thanks so much


V3 - Import files to Dev-App

Changes from V2:

Added check for 'null' form fields on the server side.
Added separator for Import File in drop-down dialog.
Fixed width of file name displayed in "Import File" dialog.
Server now sends status '0' when everything is okay instead of string.

Patch looks totally good to me, just small things here....
Thank you!

Merged! Thanks


Show Public Group Resources when Logged In

Resolve CZO Group visibility when logged in. Resource lists that are visible when not logged in should be visible when logged in.

This is issue is not limited to CZO Group visibility. For example, I am not a member of the group “2018 CUAHSI NSG for Hydrology Workshop” If I try to access this group when logged in, I see the message “You are not a member of this group” and cannot see any additional information.  When logged out, I can see four public/discoverable resources associated with that group and a list of the users that shared them.  If I can see public resources when logged out, I should be able to see them when logged in.

Also note that the current help documentation at https://help.hydroshare.org/participation-and-collaboration/group-visibility/ states that for Public Groups:

"Any HydroShare user can view the list of group members
The list of resources shared with the group is only visible to group members"

So, there are a few inconsistencies here. IMO, public resources should be visible on a Public Group Landing page because they are publicly available through Discover anyway.

Related to issue 3736.

@dtarb  I am fixing this as part of my work on #4211

Addressed in PR #4419


Feature : Adding dark mode (#1432)

Fixes #[1432]
Changes:
Created a button when clicked take to dark mode and when click again take back again to light mode.
Screenshots of the change:

Hi @Ajddn, thanks for the PR. We do not usually accept any PR if it has not been approved for fixing in the original issue. If you wish to address any specific open issue, please leave a comment in the issue and wait for approval. I'll close this PR for now and follow up in the issue.


feat: Improvement for adding a product to lists

What

This PR changes the "Add a product to a list" dialog:
When there is no list, it is clearly explained that a list should be created
When at least one list is available, a Save button is now displayed to force the user to validate its choice

Video
In video, this should be better understandable:
https://user-images.githubusercontent.com/246838/195114586-c004bb7d-0231-4578-a6ff-3e43aede7ce0.mp4

We used to solve this by pre-creating a few lists in the old app (Product I ate, Shopping list)


Importing code in editor fails with "undefined symbol error"

Hello,
I've been following exactly this https://docs.godotengine.org/en/3.1/tutorials/plugins/gdnative/gdnative-cpp-example.html C++ Gdnative tutorial. Back when I was using Windows 10 it worked fine, but now I am on Ubuntu 18.04 and it doesn't work.
The code (exactly the one used in the tutorial) compiles without any problem; however, when I try to import the libs into Godot, I get those errors :
Can't resolve symbol godot_gdnative_init. Error: /home/thefamousrat/Documents/Godot/test/src/bin/x11/libgdexample.so: undefined symbol: godot_gdnative_init  modules/gdnative/gdnative.cpp:347 - Failed to obtain godot_gdnative_init symbol  modules/gdnative/gdnative.cpp:488 - No valid library handle, can't get symbol from GDNative object  modules/gdnative/nativescript/nativescript.cpp:1504 - No nativescript_init in "res://src/bin/x11/libgdexample.so" found
Anyone has any inputs on this ? I've seen this error pop up for other persons on Linux. I'm using Godot 3.1.2 and the latest Godot-cpp/godot_headers repos (I tried using the nativescript-1.1 branch, but to no avail).
Thank you

I have the same error in OSX 10.14.6
E 0:00:00:0589   Can't resolve symbol godot_gdnative_init. Error: dlsym(0x7fcc5c43abf0, godot_gdnative_init): symbol not found
E 0:00:00:0589   Failed to obtain godot_gdnative_init symbol
E 0:00:00:0589   No valid library handle, can't get symbol from GDNative object
E 0:00:00:0589   No nativescript_init in "res://bin/osx/libgdexample.dylib" found
Also I compiled changing the src folder path instead of beside to inside the project "/demo" directory contrary to what the documentation says, other way I couln't compile.

Similar, Godot 3.1.2, Manjaro 4.19
E 0:00:00:0257   Can't resolve symbol godot_gdnative_init. Error: /home/biip/Documents/Projects/test/demo/bin/x11/libgdexample.so: undefined symbol: godot_gdnative_init
E 0:00:00:0257   Failed to obtain godot_gdnative_init symbol
E 0:00:00:0257   No valid library handle, can't get symbol from GDNative object
E 0:00:00:0257   No nativescript_init in "res://bin/x11/libgdexample.so" found

Not sure why the symbol is missing, but here's a few possibilities to try:

Is your godot_gdnative_init marked extern "C"?
Did you rename that function? If so, update the GDNativeLibrary's symbol_prefix. For example, use test_ if you renamed the function to test_gdnative_init.
The nm command (on both Linux and Mac OS) lists all the symbols in a binary. Does the function show up if you do nm <your compiled .so/.dylib> | grep gdnative?

Man this is so strange. I removed the project and started for scratch. And now it works for some reason. I've already done this 3 times, so I'm not sure why it's suddenly working.
I repeated the process one more time to see if I could replicate the errors. But still works just fine.
@sheepandshepherd No changes - it's all copy/paste from the documentation.
This is actually more or less just a summary of the documentation - which worked for me:

Create project folder: mkdir gdnative_cpp_example
Go into folder: cd gdnative_cpp_example
Clone C++ GDNative: git clone --recursive https://github.com/GodotNativeTools/godot-cpp (worked with both master-branch and 3.1-branch)
Go into folder: cd godot-cpp
Build bindings: scons platform=linux generate_bindings=yes bits=64
Create folder for our source code: mkdir gdnative_cpp_example/src
Inside src add new files gdexample.h, gdexample.cpp and gdlibrary.cpp. See doc for soruce
Download SConstruct and place it in the main folder gdnative_cpp_example
Open Godot and create project at: gdnative_cpp_example/demo/
Create bin folder inside demo: mkdir gdnative_cpp_example/demo/bin
Add new files gdexample.gdns and gdexample.gdnlib inside bin. See doc for source
From main folder gdnative_cpp_example run scons platform=x11
Go back into Godot, add the sprite, apply the Godot icon and reference gdexample.gdns (As described at the end of this paragraph)

File/folder layout looks like:
gdnative_cpp_example
    |-- demo
    |    |-- bin
    |         |-- gdexample.gdnlib
    |         |-- gdexample.gdns
    |
    |-- godot-cpp
    |-- src
    |    |-- gdexample.h
    |    |-- gdlibrary.cpp
    |    |-- gdlibrary.cpp
    |
    |-- SConstruct

Here is a ZIP of the files - except for godot-cpp. Perhaps @TheFamousRat could make a file compare to see if there is any differences:
godot3.1-stable_gdnative_cpp_test.zip


Panning doesn't work that good when initially zoomed in

Codepen
https://codepen.io/soentio/pen/QXgybQ
Reproduction:

Select pan tool
Pan to the most left
The first visible marker is the one of the second element. Try tooltipping. The very first marker is clipped.

I've set series.data purposefully so long, as the more entries a series have, the more visible the issue gets.
Explanation

I'd like to see all values
The first element is clipped
No error message

still not working well

Still not working version 3.35.5.
Also when you pan to the right, the limit is before the last datapoint.
Also when you use the "Selection Zoom", panning is not working at all when you include the first or last datapoint in the selection.
Reproduction:

Open Line Charts -> Zoomable Timeseries  (https://apexcharts.com/javascript-chart-demos/line-charts/zoomable-timeseries/)
Select "Selection Zoom"
Select an area including first datapoint
Select "Panning"
Try panning. Nothing happens.


Fix some words

I fixed some words of the vocabulary list at the request of Mercari LET team.

@merasako Please review.


SBT 1.x fails to resolve Maven2 parent dependency as a POM file

steps

Create SBT 1.1.1 project with the following content

version := "0.1"
scalaVersion := "2.12.4"
resolvers ++= Seq(
  "SBT Investigation" at "http://nexus.dev.zeptodev.com/content/repositories/sbt-investigation"
)
libraryDependencies ++= Seq(
  "com.zeptolab.notifications" % "notifications-client-api"  % "2.32"
)

Make sure that build.properties contains sbt.version = 1.1.1
Launch sbt and try update
Get the problem with unresolved dependency commons-dependencies-parent-2.165.jar

problem
The project depends on our library notifications-client-api. This library itself is dependant on parent notifications-client which is dependant on commons-dependencies-parent.
commons-dependencies-parent does not have jar file. It's just a descriptive POM which contains dependency management and other stuff.
All artifacts are accessible in our internal Sonatype Nexus repository. For the purpose of investigation I've set up access to these artifacts here
The problem is that SBT 1.x is trying to download commons-dependencies-parent-2.165.jar instead of commons-dependencies-parent-2.165.pom and fails with error.

sbt.librarymanagement.ResolveException: unresolved dependency: com.zeptolab.notifications#notifications-client-api;2.32: SBT Investigation: unable to get resource for com/zeptolab/commons#commons-dependencies-parent;2.165: res=http://nexus.dev.zeptodev.com/content/repositories/sbt-investigation/com/zeptolab/commons/commons-dependencies-parent/2.165/commons-dependencies-parent-2.165.jar: java.net.ProtocolException: Unexpected status line: HTTP/1.1 404 Not Found

expectation
SBT 1.x must  resolve parent dependency as a POM file
notes
SBT 0.13.x works great with the same setup
sbt version: 1.1.1

Found a workaround, might be useful.
Setting updateOptions := updateOptions.value.withGigahorse(false) helps

sbt 1.3.0 switches to using Coursier, so I am closing this for now.


Update benefits-and-holidays.md

Updating PTO policy to state that team members who do not have regularly scheduled hours or are scheduled for less than 10 hours a week do not receive PTO.
URL of RTD document: https://civicactions-handbook.readthedocs.io/en/marctjones-patch-2/

Approved


discussion + links

IDE's in nim for nim
not sure what's the plugin support with these (good plugin support is indeed fundamental)

first attempt by araq: https://github.com/nim-lang/Aporia/
that was since deprecated in favor of https://github.com/Araq/nimedit
more here: https://github.com/nim-lang/Nim/wiki/Editor-Support

client/server communication for plugins

sublime model (uses async)
RPCS

nimtwirp (uses protobuf)
GRPC (also supports bidirectional streaming but that feature seems overkill for plugin; i don't know of a nim port)
capn'proto (also supports advanced RPC feature to access arbitrary nested data efficiently); has nim ports

shared memory vs RPC (client/server)
shared memory

probably simpler for simple things, but may be more complex once you run into memory sharing issues
need to take care of blocking issues (could freeze editor)
not good for security (eg if plugins are untrusted)
a bad plugin could crash the editor
potentially faster in memory intensive applications; not sure it applies for text editor unless you're dealing with giant files, then it could be relevant
doesn't help with remote editors

RPC

requires serialization/deserialization step (but can be 100% transparent in most cases), eg:

using raw nim types, eg: https://github.com/nim-lang/Nim/pull/10346 generic parse[T](a: string)
easy to extend to arbitrary nim types using macros
using protobuf (https://github.com/oswjk/nimpb which is faster than https://github.com/PMunch/protobuf-nim)
using json; that has some limitations inherent to json; eg needs base64 encoding for binary data etc; but marshall + %* from stdlib can be used for serialization/deserialization
using bson (https://github.com/SSPkrolik/nimongo nimongo.bson) which addresses some issues with json; more efficient

base GUI editor
scintilla

open source

C api, making easy to port via nimterop
https://www.scintilla.org/ScintillaDoc.html#TextRetrievalAndModification

ported nimscintilla to nimterop - took 10 minutes!

not sure how feature-rich compared to sublimetext (including syntax files, tabs, panes within tabs etc)

not sure how efficient compared to sublimetext (eg large text buffers, 100's of panes)

not sure how advanced it is compared to sublime

sublimetext

closed source

rich plugin API

python (type safety etc); but can be wrapped into a nim API, at some cost

use cases

editing a remote file; this should be lag-free except maybe on save/load

misc links

https://github.com/sieukrem/jn-npp-plugin/wiki/Direct-calls-to-Scintilla

Feud had come quite a ways. Plugin system that started out based on nimterop's has come quite a ways and is working well.
Some plugins use shared memory and threads and feud makes it relatively easy.
RPC has been based on nng and is working fine. Using the bus protocol for now but leverage is still primitive.


Changing the path patterns to call acsp-api

Changing the path patterns to call acsp-api

CI: No security warnings found

CI: No security warnings found


Integ test adjustments

Description of Change
Fixes small things and improves the flow of using the mock server while using running py42 integration tests.

Use default arguments that are the expected host/port of the mockserver when environment variables are not set.
Corrects the name of said environment variable in the CONTRIBUTING guide as well as update the CONTRIBUTING guide to include part about default variables.
Make URLs easier to parse; remove unneeded class variables
Some formatting and spelling fixes
Makes test py2 compat

Issues Resolved
n/a
Testing Procedure
Now, when testing the mock server PRs, you don't have to worry about setting the environment variables.
PR Checklist
Did you remember to do the below?

[n/a] Add unit tests to verify this change
[n/a] Add an entry to CHANGELOG.md describing this change
[n/a] Add docstrings for any new public parameters / methods / classes

I am going to work out something regarding empty JSON in requests

I am going to work out something regarding empty JSON in requests


Redesign: Inspector og library tab lists

Feature Description
Update design for inspector and library tab lists based on Figma.

[x] Update tab icons
[x] Update tab typography and current tab indicator
[x] Update colors for background and border
[x] Update tooltip to new component where applicable

Current design
New design

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Verified in QA


segfault on reusing a structure after ASN_STRUCT_FREE_CONTENTS_ONLY().

I'm not sure if this is a bug or working as intended. I didn't encounter this problem with v0.9.24, and am seeing it now with 0.9.27, but maybe I just got lucky before.  I also switched from native-types to wide-types which may have contributed.
When trying to reuse a message structure after using and then "emptying" it, setting attributes using things like OCTET_STRING_fromBuf() can segfault. An example LDAP code fragment looks like this;
msg = calloc(1,sizeof(LDAPMessage_t))
msg->messageID = msgid;
res->protocolOp.present = LDAPMessage__protocolOp_PR_searchResEntry;
SearchResultEntry_t *searchResEntry = &res->protocolOp.choice.searchResEntry;
/* Populate the msg searchResEntry attributes here... */
...
/* Now empty the msg and reuse it for a searchResDone response. */
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_LDAPMessage, msg);
msg->protocolOp.present = LDAPMessage__protocolOp_PR_searchResDone;
SearchResultDone_t *searchResDone = &res->protocolOp.choice.searchResDone;
/* And now this will segfault... */
OCTET_STRING_fromString(&searchResDone->matchedDN, basedn);

The problem is that OCTET_STRING_fromString() tries to free the existing matchedDN attribute before alloc/set the new one. However, the existing matchedDN attribute contains a garbage pointer left over from the previous searchResEntry message.
I realize this is pretty normal C behavior; freeing things doesn't re-initialize/zero the pointers, and it's up to the caller to do that. However, there appears to be some effort in things like OCTET_STRING_free() to leave the free'd structure in a valid initialized state, doing things like zeroing the pointer after free. Digging around other *_free() functions it looks like most others don't do this.
I think the right thing here is to adhere to C conventions and have ASN_STRUCT_FREE_CONTENTS_ONLY() offer no guarantees that the structure is left in a valid initialized/zeroed state. In that case I think *_free() functions should never expend effort on things like zeroing pointers after free(), because that just masks that this cannot be relied on.

I thought about changing OCTET_STRING_free() to stop zeroing the pointer to the allocated string buffer, or about changing all the constr_<whatever>_free() to make them all zero the buffer pointer if the member happens to be an OCTET STRING... But the logic says that if the member of a constructed type is an OCTET STRING, then OCTET_STRING_free() would be invoked - and it should zero the relevant pointer, thus preventing the reported problem from happening.
@velichkov what do you think about this?

The problem bites you when the OCTECT_STRING is inside a "choice" union. It doesn't matter if the pointer was zero'ed in one of the "choice" message structures, if you then re-use the message for a different message type with a different structure, it may have OCTECT_STRING elements with a different alignment in the  union. This means the new message's OCTECT_STRING could have a random garbage pointer from other parts of the previous message structure in the union.
Note I didn't hit this problem before 0.9.27 and I switched to native types,  but I suspect I just got lucky with the alignment of the elements in the different message types using non-native types.
It's not a big deal once you know that ASN_STRUCT_FREE_CONTENTS_ONLY() doesn't guarantee that the message is initialized into a sane state and you need to zero it yourself. The main niggling issue is it ALMOST initializes it into a sane state, wasting a few cycles doing so, and giving you a false impression that it does.
IMHO it should either free and initialize it properly (which would maybe involve the CHOICE_free() zeroing the whole union), or don't initialize it at all.  I lean towards the latter choice since it's consistent with the behavior of free(), but you probably want to make it clear either way what the behavior is.

The problem bites you when the OCTET_STRING is inside a CHOICE union.

I see. Does it apply to SET as well?

IMHO it should either free and initialize it properly (which would maybe involve the CHOICE_free() zeroing the whole union), or don't initialize it at all.

I lean towards the first choice (no pun intended :).  I wonder if the whole thing should be zeroed in case of SET as well?
@velichkov, your input is welcome here!  @brchiu what's your opinion?

A small problem is these xxxx_free() function only knows the pointer but not the structure size, for example LDAPMessage_t in this case, if we want to zero the entire structure, we might have to tweak a little to include the sizeof(LDAPMessage_t) information in asn_DEF_LDAPMessage.
@dbaarda  In skeleton\asn_internal.h, if we change :
#define	FREEMEM(ptr)		do { free(ptr); ptr = (typeof(ptr))NULL; } while(0)

Could this be helpful ?

The problem is it's not enough to zero out the pointers, you need to zero out everything, including native integers and doubles since a different message type will overlay a different struct in the union over that value, which might end up putting a pointer where that native integer or double was before.
If you are really going to do this, then every *_free() for "leaf" elements must zero out it's entire contents if contents_only is true (if contents_only is false, the whole thing is going to be free'd and thus doesn't need to be wiped). Container elements like CHOICE and SET can rely on their contained elements zeroing their own contents, and just need to zero any extra supporting struct fields like count's or choice values.

@dbaarda  Got it.
Again, I found the problem that not knowing the size of previous allocated memory indeed exists for *_free(), unlike LDAPMessage, if the types are 'inherited' from base types.
Taking DelRequest of generated LDAP3 files as an example, it inherits from LDAPDN. LDAPDN inherits from LDAPString which inherits from OCTET_STRING and it is a basic type (at least in certain sense). So the task is to have a suitable way, when we want to zero out memory allocated for DelRequest, we know we have to zero out sizeof(OCTET_STRING_t).
Good news is : PR #93 has done this leaf-finding task.
Bad news is : it has not been accepted in vlm's repository yet.
However, since @mouse07410's repository has included this #93, through merging https://github.com/vlm/asn1c/pull/143 indirectly. Perhaps I can implement the idea there.
Please stay tuned.

@brchiu I agree - it isn't that simple.
I'm considering perhaps just documenting that if
a. the PDU includes CHOICE or SET element(s), and
b. the re-use may involve different "sub-objects" (like what @dbaarda described),
then using ASN_STRUCT_FREE_CONTENTS_ONLY() is inappropriate and would likely lead to errors/crashes.

hi, Both,
Based on @mouse07410's repository master branch, I partially implement a fix to tackle this issue in my own repository zero_out_structure_when_free_content_only.
The reason I said 'partially' because only SET_free(), SET_OF_free(), SEQUENCE_free(), CHOICE_free() and OCTET_STRING_free() are modified to zero out allocated memory.
There are BOOLEAN_free(), NativeInteger_free(), NativeReal_free() and the ASN__PRIMITIVE_TYPE_free() have not be handled due to lack information like struct_size field of *_specific_t structure.
Review and advice are welcomed.

I think if anything that has a union zero's out the space used by that union, then the problem will be mostly fixed. I think since you've covered the "container" types, I think you have it covered.

I think if anything that has a union zero's out the space used by that union, then the problem will be mostly fixed. I think since you've covered the "container" types, I think you have it covered.

I agree in principal, but I thought that only CHOICE and SET (and maybe SET OF) would qualify as "union" types?
Also, let's continue this discussion here: https://github.com/vlm/asn1c/pull/146

In the meanwhile, hopefully fixed in the mouse-master.

@mouse07410 or @brchiu, would you please post a single comment summary of the arguments and a suggestion in this patch? So far I am leaning towards fixing the _FREE/_free semantics to be non-zeroing, and creating ASN_STRUCTURE_CLEAN macro to explicitly deal with application level corner-cases. The motivating example seems to be just a wrong use of abstraction, so it does not look convincing.

@vlm, I don't mind to revoke this pr if there is better way to solve (or prevent users' wrong usage) this issue. You can just do what you think is the best on your solely discretion.
Thank you for your great effort.

@vlm I think that since the patch does fix the problem without imposing undue restriction on what a reasonable user would expect, and is fairly simple/small - it should be in.

I was reluctant to merge https://github.com/mouse07410/asn1c/pull/12, because it introduces recursive (read: quadratic) memory resetting behavior when contents_only option is present. Consider the hierarchical structures. Freeing them would memset() each of the inner structures, then memset() the outer structure, and so on. This essentially resets each byte of the structure as many times as the number of layers in the hierarchy. This is wasteful and unnecessary.
Therefore I introduced ASN_STRUCT_RESET() macro which does clear the contents, and discouraged using ASN_STRUCT_FREE_CONTENTS_ONLY() in the application code.
https://github.com/vlm/asn1c/commit/8d99d7b5c87d5a805472a51007d5f640932d435e


[Feature Request] Command List

Is your feature request related to a problem? Please describe.
It would be really cool if the bot had a prefix to show all the available command of the bot, since when you try to use it, discord automatically tries to use an already existent bot that has a similar prefix to run the command.
What is your ideal solution to the problem?
A list of commands for the bot
How would this feature be used?
If you type the prefix of the bot, discord will show you all the possible commands of the bot
Additional Info
No response
Checklist

[X] I have checked the documentation to make sure this feature doesn't already exist
[X] I have searched for similar feature requests
[X] I have confirmed that my requests is not on the list of things that will not be added
[X] I am running the latest version of the bot:

try help

You are describing the help command, which already exists


Update NET8 Compatibility

So... here we are again, haha. I fixed this project too. I haven't tested it on Windows, but it works fine on iOS and Android. I really want to thank you for your time. This is not critical for me, so whenever you have time to review it, it would be nice.

I agreed with the PR of @agustinbishel.
I have a project referencing .net8.0 project, like Infrastructure and I can't reference banditoth.MAUI.Multilanguage on version 1.0.6 in this project because TargetFrameworks is not compatible with net8.0, I need ITranslator interface in Infrastructure project.
Thank you, Stephan.

I agreed with the PR of @agustinbishel. I have a project referencing .net8.0 project, like Infrastructure and I can't reference banditoth.MAUI.Multilanguage on version 1.0.6 in this project because TargetFrameworks is not compatible with net8.0, I need ITranslator interface in Infrastructure project. Thank you, Stephan.

Hey @StephanArnas
Please check again, the 1.0.6 version should be working fine with .net8 :)

This pull request is for DeviceId, which I will verify sooner or later whether its working or not :)

Thanks for your answer.
Sorry I was not clear in my request :)
The version 1.0.5 targeted frameworks net8.0 and net7.0, which means I was able to reference the project in class library project in my solution.

The version 1.0.6 do not target framework net8.0, so I can only reference it into my MAUI project.

My issue is I need ITranslator in the class library project (like Infrastructure), maybe you could consider having another package  banditoth.MAUI.Multilanguage.Abstracts or targeting net8.0 ?

I hope my answer bring you more context on my request, if you try to install banditoth.MAUI.Multilanguage on class libray project, you will have this error :
Package banditoth.MAUI.Multilanguage 1.0.6 is not compatible with net8.0 (.NETCoreApp,Version=v8.0). Package banditoth.MAUI.Multilanguage 1.0.6 supports:

net8.0-android34.0 (.NETCoreApp,Version=v8.0)
net8.0-ios17.2 (.NETCoreApp,Version=v8.0)
net8.0-maccatalyst17.2 (.NETCoreApp,Version=v8.0)
net8.0-windows7.0 (.NETCoreApp,Version=v8.0)

Oh yes, I read too fast the commit, I thought you were adding net8.0 to banditoth.MAUI.Multilanguage but indeed, it's for DeviceId, should I open a bug to reference it ?


Bug 13140 - Mocking of getters/setters on automatically mocked classes does not work

Summary
Setting HEAD to commit bf4d2d6013eebf0b02b9ec3cac57c3641bb02071 and running the tests will show that mocking of getters/setters on automatically mocked classes did not work at all.  This request fixes that problem whilst maintaining existing functionality.  All (non-mercurial) tests currently pass.
This is my first pull request so I do not know if the request number is the same as the issue number and have thus not updated the Changelog.md file with this fix.  Apologies for any inconvenience.
Fixes #13140
Test plan
Test coverage can be seen in the aforementioned commit.

related issue https://github.com/facebook/jest/issues/13140

Thanks for sending a PR @staplespeter! There are conflicts - would you be able to resolve them?

Hi @SimenB, yes I'll update the pull request.

@SimenB Pull request updated.  I've made some assumptions about the type changes in #13247 and dynamically typecast Mocked to PropertyDescriptor to get things to work.  TBH this is from a position of mostly ignorance, however the existing tests for my changes still pass.
Any questions do please ask of course.

I've made some assumptions about the type changes in #13247 and dynamically typecast Mocked to PropertyDescriptor to get things to work.

Can spot this typecast ;D Could you point me to the line, please?
Regarding the type changes from #13247. All should be good if running yarn build and yarn test-types pass without errors. Note that type tests run agains the build, so remember to rebuild each time you make changes.

I've made some assumptions about the type changes in #13247 and dynamically typecast Mocked to PropertyDescriptor to get things to work.

Can spot this typecast ;D Could you point me to the line, please?
Regarding the type changes from #13247. All should be good if running yarn build and yarn test-types pass without errors. Note that type tests run agains the build, so remember to rebuild each time you make changes.

Apologies, I got dragged out the door for dinner and hadn't made the commit...  The changes should be apparent now, in the latest commit.
I have run yarn build, yarn jest and yarn test-types, with passes.  Mercurial tests were skipped.

Checked out the branch and looked through your change. I think all is fine with types. Looks right for my eye.

I have updated the code comments as requested.  The removal of the "object._esModule" check in getSlots() did not effect any test results.  This case is handed later when assigning the metadatain "getMetadata()"

https://github.com/facebook/jest/releases/tag/v29.1.0

@SimenB Yes of course, I'll take a look ASAP

Great, thanks! No immediate rush 👍

@SimenB can you tell me how to recreate the problem you encountered?  I didn't receive any exceptions when executing jest.mock('@google-cloud/datastore');. Apologies if i have missed something obvious

Just need to instantiate it
import { Datastore } from '@google-cloud/datastore';

jest.mock('@google-cloud/datastore');

new Datastore();

@SimenB I have added a fix and a test, ran the local build and tests, and created a new pull request - https://github.com/facebook/jest/pull/13391


Add 'include' and 'exclude' options for more fine-tuned control over brfs'd files

I have a project where I need to exclude certain source files from being transformed by brfs (due to various reasons). I found many issues where people have similar needs, e.g. #76 #70 #55 #41.
This pull request adds support for opts.include and opts.exclude, both taking a minimatch pattern, which is matched against the source file path being transformed. Minimatch was already a dependency by browserify#glob.
Usage examples:
browserify -g [ brfs --exclude '**/node_modules/problematic/*' ] ...
browserify -g [ brfs --include '**/src/foo/bar/**' ] ...
I also added .editorconfig, which helps other contributors to maintain the formatting style of the project (e.g. disable whitespace trimming).

What about this?


fix: Fixing one instance of async vulnerability

Details
This PR partially addresses this dependabot alert about using a vulnerable version of "async." Where possible, it updates the dependencies we have that rely on async and bumps them to use a current, secure version of the package. For the case where this is not possible, we are choosing to resolve this dependabot alert without fixing them, as the amount of work required to make a fix is not logical for the low risk that this vulnerability poses for us.
This dependency was updated by removing and re-adding the<EMAIL_ADDRESS>entry of the lockfile, since our caret version, when refreshed, would bump up to a secure version of async (2.6.4).
Motivation
Keeping dependencies up-to-date.
Context
This change leaves a few dependencies on async at lower-than-secure versions. Secure versions of async are specifically 2.6.4, and then 3.2.3 and above. However, there are other dependencies of ours which rely on things which rely on things (and so on)... which rely on async at a vulnerable version.  Namely, tfx-cli at its latest version relies on<EMAIL_ADDRESS>Additionally, tfx-cli has a dependency on prompt, which relies on<EMAIL_ADDRESS>and which also has its own dependency on<EMAIL_ADDRESS>which uses<EMAIL_ADDRESS>Options considered:

 enumerate options

Pull request checklist

[n/a] Addresses an existing issue: Fixes #0000
[n/a] Added relevant unit test for your changes. (yarn test)
[n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[x] Ran precheckin (yarn precheckin)

Codecov Report

Merging #1142 (f1146ba) into main (b0f8fb5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1142   +/-   ##
=======================================
  Coverage   90.66%   90.66%
=======================================
  Files          59       59
  Lines        1446     1446
  Branches      172      172
=======================================
  Hits         1311     1311
  Misses        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f8fb5...f1146ba. Read the comment docs.