Uncaught TypeError: Rollbar\Payload\Frame::__construct(): Argument #1 ($filename) must be of type string

When logging a message (any level) with explicit Rollbar::log call, this error happens.
On PHP 8.0.12 with both 3.0.0 and master@ad22e3589116ff5958c3b6ff35c65d959266414d and Rollbar defaults.
Does not seem to happen when issues are caught through default error handlers.
Does not happen when capture_error_stacktraces is set to false on init.
Fatal error:  Uncaught TypeError: Rollbar\Payload\Frame::__construct(): Argument #1 ($filename) must be of type string, null given, called in /srv/vendor/rollbar/rollbar/src/DataBuilder.php on line 479 and defined in /srv/vendor/rollbar/rollbar/src/Payload/Frame.php:18
Stack trace:
#0 /srv/vendor/rollbar/rollbar/src/DataBuilder.php(479): Rollbar\Payload\Frame->__construct(NULL)
#1 /srv/vendor/rollbar/rollbar/src/DataBuilder.php(454): Rollbar\DataBuilder->makeFrames(Object(TypeError), false)
#2 /srv/vendor/rollbar/rollbar/src/DataBuilder.php(425): Rollbar\DataBuilder->makeTrace(Object(TypeError), false)
#3 /srv/vendor/rollbar/rollbar/src/DataBuilder.php(406): Rollbar\DataBuilder->getExceptionTrace(Object(TypeError))
#4 /srv/vendor/rollbar/rollbar/src/DataBuilder.php(375): Rollbar\DataBuilder->getBody(Object(TypeError), Array)
#5 /srv/vendor/rollbar/rollbar/src/Config.php(732): Rollbar\DataBuilder->makeData('...', Object(TypeError), Array)
#6 /srv/vendor/rollbar/rollbar/src/RollbarLogger.php(215): Rollbar\Config->getRollbarData('...', Object(TypeError), Array)
#7 /srv/vendor/rollbar/rollbar/src/RollbarLogger.php(120): Rollbar\RollbarLogger->getPayload('...', '...', Object(TypeError), Array)
#8 /srv/vendor/rollbar/rollbar/src/Handlers/ExceptionHandler.php(28): Rollbar\RollbarLogger->log('...', Object(TypeError), Array)
#9 [internal function]: Rollbar\Handlers\ExceptionHandler->handle(Object(TypeError))
#10 {main}
  thrown in /srv/vendor/rollbar/rollbar/src/Payload/Frame.php on line 18

Thanks for the detailed report, @thomasme! I can confirm your analysis:
Rollbar\DataBuilder::makeFrames() may set a $filename to null and later pass that to the Rollbar\Payload\Frame constructor:
$filename = isset($frameInfo['file']) ? $frameInfo['file'] : null;
// ...
$frame = new Frame($filename);

The Frame, however, does not allow for null filename.
public function __construct(private string $filename)

Planning a fix for the upcoming version 3.0.1.

Hello, is there a way how to bypass this error?

same question here, it is taking is down in production

I downgraded one version down and it's working fine.

same problem here. I changed version to dev-master (https://github.com/rollbar/rollbar-php/commit/bdcb1d7922c0ae4a1b09bf93f8e03fb73b8f35a7) and it's working fine on PHP 8.1.

This was fixed in v3.1.0.


[10.x] Add mergeIfMissing method  to ValidatedInput class

This PR introduces the mergeIfMissing method. The mergeIfMissing method allows for merging additional data into the validated data, but only for keys that are not already present.
Example

dd($request->safe()->all());  // ["name" => "Taylor Otwell"]

$validated = $request->safe()->merge(['name' => 'James']);

dd($validated->all()) // ["name" => "James"]

$validated = $request->safe()->mergeIfMissing(['name' => 'James']);

dd($validated->all()) // ["name" => "Taylor Otwell"]

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Add flowchart for managing ready-to-merge PRs

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

This documentation PR adds a flowchart and a diagram guideline.
Flowchart for managing ready-to-merge PRs
A flowchart can be a helpful addition to a complex decision tree.
Many thanks to @SMillerDev for the idea and initial version of the chart.

New diagram guideline
Looks like this is the first diagram in the Homebrew documentation so it’s a good time for a little guideline, too.
Pinging @Homebrew/tsc but feedback welcome from everyone, of course.

I'd say the stuff about the driver should be a separate pull request. It's useful, but it really distracts from the added diagram.

I'd say the stuff about the driver should be a separate pull request.

Makes sense! Removed for now.

I don't mean to be bikeshedding here, but the "Modify and push" text doesn't have a white background (like "Push the button"), so the "a" in "and" seems a little too close to the line. Is it possible to make the text background white or is it intentionally this way? Disclaimer: I don't know anything about rules for diagrams 😅

I don't mean to be bikeshedding here, but the "Modify and push" text doesn't have a white background

@nandahkrishna Fixed, thanks!
And yes, that’s exactly the kind of feedback I meant to solicit ❤

Are there bottles that need to be rebuilt?

I don't think it's really clear how to answer this question without the explicit “check for bottle :unneeded” step.

Thank you all for the thorough review and helpful feedback @nandahkrishna @Rylan12 @SMillerDev @MikeMcQuaid @reitermarkus!

Looks good! One minor thing: the color of the ✅ is a little distorted. It's not unreadable, though, so maybe not worth fixing.

Thanks @claui! Would be good to fix that if possible.


Classification throws RuntimeError for real nodule location

Related to #229 : While the nodule classification works for providing nodule locations with small values in each dimension, it fails when I tried to classify a real nodule (first one of patient LIDC-IDRI-0003).
Expected Behavior
A cancer probability should be returned.

Checklist before submitting

[X] I have confirmed this using the officially supported Docker Compose setup using the local.yml configuration and ensured that I built the containers again and they reflect the most recent version of the project at the HEAD commit on the master branch
[X] I have searched through the other currently open issues and am confident this is not a duplicate of an existing bug
[X] I provided a minimal code snippet or list of steps that reproduces the bug.
[X] I provided screenshots where appropriate
[X] I filled out all the relevant sections of this template

confirmed

I did some checking... I may be wrong, but it looks like the specified slice is not valid.
The one we are running the test for is {'x': 367, 'y': 349, 'z': 72} but the DICOM at this slice looks like a mess:

While when I run the test on {'x': 367, 'y': 349, 'z': 189} it doesn't fail. Here is how the image looks at specified slice:

@WGierke, @reubano what do you think?

Hi Serhiy, can you check the slice indices, please?
The z axis is the number of the slice starting at 0. This is because the image position does not always start at a fixed value. I'm taking this from the design doc. Also, the used Python library for the LIDC images interprets it like that. Thanks!
On Dec 29, 2017, 10:31 PM, at 10:31 PM, Serhiy-Shekhovtsov<EMAIL_ADDRESS>wrote:

I did some checking... I may be wrong, but it looks like the specified
slice is not valid.
The one we are running the test for is {'x': 367, 'y': 349, 'z': 72}
but the DICOM at this slice looks like a mess:

While when I run the test on {'x': 367, 'y': 349, 'z': 189} it
doesn't fail. Here is how the image looks at specified slice:

@WGierke, @reubano what do you think?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/concept-to-clinic/concept-to-clinic/issues/268#issuecomment-354502724

I knew I missed something. Will keep checking this issue.


Bug in compute_epsilon?

Hi, thanks for a great tool. I am trying out the python version and when I load your .csv sample data into the Python GUI and then try to run the DRT calculation using "Simple Run" or "Baysian Run" run I get the following error:
pyDRTtools/main/general_fun_v8.py", line 106, in compute_epsilon
return epsilon[0]
TypeError: 'float' object is not subscriptable
[1]    94298 abort      python pyDRTtools.py

Thank you for reporting the issue you encountered while using pyDRTtools, including the error message. The issue with "compute_epsilon" function has already been resolved in the current version on GitHub. Nonetheless, we are working on new version that will be released soon.


go get fails

Trying to get ratt going on Debian/jessie. I tried:
% go get -u github.com/Debian/ratt
package github.com/Debian/ratt
	imports pault.ag/go/debian/control: unrecognized import path "pault.ag/go/debian/control"
package github.com/Debian/ratt
	imports pault.ag/go/debian/version: unrecognized import path "pault.ag/go/debian/version"

At looks like https://pault.ag/go/debian is returning 502 Bad Gateway errors.

done, thanks


Frontend: simplify some flag logic (NFC)

Using the three parameter form of hasFlag makes it possible to fold
away the conditional code.  NFC.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge


Error when user provides a customized record_factory function for 10.0 version

Following the logging document https://docs.python.org/3/library/logging.html
Do:
old_factory = logging.getLogRecordFactory()

def record_factory(*args, **kwargs):
    record = old_factory(*args, **kwargs)
    record.custom_attribute = 0xdecafbad
    return record

logging.setLogRecordFactory(record_factory)

Then coloredlogs 10.0 throws error:
File "C:\anaconda3\envs\pt4\lib\site-packages\coloredlogs\__init__.py", line 1110, in format
    else logging.LogRecord
TypeError: __class__ must be set to a class, not 'function' object

Hey Weijie and thanks for the feedback! I've just released coloredlogs 11.1 which should resolve the problem you reported. I also added a test to avoid regressions in the future.


TOMEE-2239 removing the try-catch block

Merged!

Oh yeah!

@tveronezi Can you close PR please? According to @radcortez everything was merged.


[Issue#145] add playwright tests - ccr page

Resolves 5/5 item from the list - CCR - Code Compile Run page #145
Scope of change

add tests for the CCR - Code Compile Run page
update ccr page
fix style: add empty lines for better readability
fix incorrect page reference
refactor tests:
-> replace wait(8_000) with waitForPageToLoadURL()
-> replace addUnit() with performCurrencyConversionWithXtoXunit()
-> add performCurrencyConversionWith1to1Unit()
-> simplify page.url assertion
-> fix navigateToPage()
-> add searchForWeatherInLocation()

Great work, @bugITwhisperer!


Update hiera config version to 3.0.7-boxen1

Updates the config to use 3.0.7-boxen1 as all the other files point to in the 4.0.1 tag. I found that running this module the first time worked fine but subsequent runs try to downgrade to 3.0.5-boxen1.

+1

+1

thanks! 🍭

released as 4.0.2


Use named struct fields for population

I was looking at the Population.cpp code and was thinking it's perhaps a bit more verbose than it needs to be.
Example:
mPopulationGrowth[PopulationTable::Role::Child] += mPopulation[PopulationTable::Role::Scientist] / 4 + mPopulation[PopulationTable::Role::Worker] / 2;

This could be much shorter if we used named fields:
mPopulationGrowth.child += mPopulation.scientist / 4 + mPopulationworker / 2;

I propose we replace the std::array used in PopulationTable with named fields.
I think the key point here is that there are complex non-symmetric interactions between the various population components, so it's not very well suited for array processing. Perhaps we should instead use named struct fields.
This would appear to be opposite of the case for StorableResources, where there is no real interaction between the fields within a struct. Rather there is interaction with corresponding fields in different struct instances, and this is done in a very symmetric way, and so array processing is useful there.
Another indication that PopulationTable is perhaps more suitable to named fields, are the many places in which the Role enum values are statically set at compile time. Actually, if we used named constants, it would likely drastically reduce uses of the Role enum, perhaps even eliminating the need entirely. If we do need a bit of dynamic field access for a few remaining cases, we could perhaps use references to members instead (&PopulationTable::workers).

I also just noticed that PopulationTable is declared as a struct, but has the data fields marked as private:
struct PopulationTable
{
public:
// ...

private:
	std::array<int, 5> table;
};

On another matter, I typically put struct fields first, even before public methods. Not sure if we have much of a convention on that. It feels a bit backwards from the usual convention we use with classes.

In retrospect, PopulationTable maybe should be a class. I was trying to make it a basic data type, but it is developing some decent logic. I can see why key private members could be at the top of the class definition to aide in readability.
I think the current system is workable, but the shorter syntax is appealing for what you are recommending. There can be more functions on PopulationTable to aggregate common cases such as PopulationTable::employable (all scientists and workers).
But I just finished refactoring it... :)

There are still a few uses of the Role enum in the Population model code. These could potentially be eliminated by performing bulk operations on all population components together. The PopulationTable struct already has an operator+=. By adding operator/ and operator%, the role update code could be written to work on all roles at once, and so eliminate the need reference specific roles.
There are still a few asymmetries that cause difficulties though. One is the way students are split into either workers or scientists. I think rather than use random numbers to choose which role they move into, they should instead contribute to growth towards both, but at different rates.
Another asymmetry is how both workers and scientists become retirees. Actually, the last couple of lines at the end of the spawn code has an if guard, to prevent taking from a role with no members. This guard isn't totally effective in that you can still take 2 members from a role with only 1 member. Instead, we can perhaps internally have retiredWorker and retiredScientist, instead of a retired field, and then group them together with a retirees() method that simulates the old retired field. That would allow proper tracking of retiring workers and scientists, without drawing too many from a potentially depleted pool of source workers/scientists.
Another point worth noting is the kill code seems to favour workers and scientists, and to kill them at less than half the rate of other population components. This is partly due to the larger divisor, requiring more death accumulation to result in a death. Though it's also in a large part due to the random number code, where only either workers or scientists can be killed any any given round. As written, it's not possible for workers and scientists to die together in the same round, short of a starvation event. This also means the death rate for these two roles is effectively halved.


update logging.cc

原logging.cc中的maybeRotate函数无法完成完成日志名更新

@yedf cc

There is a conflicting file. Could u plz resolve it?

FYI @yedf  The ci is crashed.


Devel repo is missing

Hi, I am using the docker images to build rpm packages but the devel repo is missing from the mirrors and is making it impossible to build some rpms.
I need the libuv-devel package from that repo. This is the the corresponding centos mirror I am referring to:
http://centos.mirror.server24.net/8.3.2011/Devel/x86_64/os/Packages/
Thanks

Hi @mtorromeo, I believe it has been fixed in the AlmaLinux OS 8.4 release: http://repo.almalinux.org/almalinux/8/devel/.


Update specs2-core, specs2-mock to 4.20.5

About this PR
📦 Updates

org.specs2:specs2-core
org.specs2:specs2-mock

from 4.14.1 to 4.20.5
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.specs2" }
}]

labels: test-library-update, early-semver-minor, semver-spec-minor, version-scheme:semver-spec, commit-count:1

Superseded by #219.


Build with exception "no such package '@llvm-raw//utils/bazel':" .

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):macOS monterey 12.0.1
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:No
TensorFlow installed from (source or binary):source
TensorFlow version: r2.8
Python version: python3.9
Installed using virtualenv? pip? conda?:pip
Bazel version (if compiling from source): bazel 3.7.2
GCC/Compiler version (if compiling from source): Apple clang version 13.0.0 (clang-13<IP_ADDRESS>)
CUDA/cuDNN version: no enabled
GPU model and memory:: no enabled(Just CPU model)
Describe the problem
The "bazel build --config=dbg --strip=never -c dbg --copt='-g' --cxxopt='-g' //tensorflow/tools/pip_package:build_pip_package" always failed at the step pull and install the package from url "https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz" with msg "no such package '@llvm-raw//utils/bazel':" , maybe  it is too large , can it be solved by download the package  to local and install from local ? If so ,  I want to download it to local firstly and install from local , but how to install it  from local ? any file need to be modified ?
Provide the exact sequence of commands / steps that you executed before running into the problem
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
ERROR: An error occurred during the fetch of repository 'llvm-raw':
Traceback (most recent call last):
File "/Users/xxx/ai/tf/tensorflow/third_party/repo.bzl", line 64, column 33, in _tf_http_archive_impl
ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz, https://github.com/llvm/llvm-project/archive/55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz] to /private/var/tmp/_bazel_shenyufeng/a4eaa5fcc3d32c786eb9bb79fa0163a2/external/llvm-raw/temp10925281720111290723/55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz: Premature EOF
ERROR: Error fetching repository: Traceback (most recent call last):
File "/Users/xxx/ai/tf/tensorflow/third_party/repo.bzl", line 64, column 33, in _tf_http_archive_impl
ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz, https://github.com/llvm/llvm-project/archive/55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz] to /private/var/tmp/_bazel_xxxx/a4eaa5fcc3d32c786eb9bb79fa0163a2/external/llvm-raw/temp10925281720111290723/55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz: Premature EOF
ERROR: no such package '@llvm-raw//utils/bazel': java.io.IOException: Error downloading [https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz, https://github.com/llvm/llvm-project/archive/55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz] to /private/var/tmp/_bazel_shenyufeng/a4eaa5fcc3d32c786eb9bb79fa0163a2/external/llvm-raw/temp10925281720111290723/55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz: Premature EOF
INFO: Elapsed time: 1738.882s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

It seems the package llvm-project-55c71c9eac9bc7f956a05fa9258fad4f86565450.tar.gz broken ,as I download it manually and also failed to uncompress it  at local.

@shenyufeng1234,
Issue is with Bazel version. Latest Tensorflow version r2.8 requires Bazel 4.2.1 or 5.0.0.
For Xcode version is 13, download llvm 12 from brew and tried to compile using the llvm 12 as per build configuration. Thanks!

Closing as stale. Please reopen if you'd like to work on this further.


typoUpdate stream-load-manual.md

Modify the sequential label
Proposed changes
Issue Number: close #xxx
Modify the sequential label，Stream load  task has only four steps and should not be labeled 5
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0


Don't link to notebook.readthedocs.org

That website is just someone's personal notes. I think the desired link is jupyter.rtfd.org.

Correct! Thanks @brettcannon!

These links should have been jupyter-notebook.readthedocs.org

Sorry! See #14.


unmockedModulePathPatterns can not detect module path

Think this might be related to closed issue https://github.com/facebook/jest/issues/88
I'm using a windows machine. Any time I try to require an external module, be it in node_modules, or any folder relative to the spec file, I receive an npm error
Found 1 matching tests...
FAIL  tests\xxx.spec.js
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0
There was no more debug information available so I reduced my spec file to a single line
var React = require('react'); and found that it was failing when trying to require react module.
My package.json file seems to be in order at least according to the example in the docs.
Here's a section of it
"dependencies": {
  "react": "^0.10.0",
  "react-tools": "^0.11.0"
},
"scripts": {
  "test": "jest"
},
"jest": {
  "testFileExtensions" : ["js"],
  "unmockedModulePathPatterns": ["./node_modules/react/"]
}

My directory structure looks something like this so the <rootDir> should default to where package.json is. And it should be able to find react library from  unmockedModulePathPatterns provided
+-- __tests__
|   +-- testfile.spec.js
+-- node_modules
|   +-- react
+-- testfile.js
+-- package.json
+-- preprocessor.js

I debugged the source code and found that there is an error that is getting swallowed on requiring React at node_modules\lib\ReactCompositeComponent.js: Cannot read property 'DEFINE_MANY' of undefined - which would suggest to me that Jest is ignoring the unmockedModulePathPatterns

unmockedModulePathPatterns are used internally by Jest to create a RegExp against which all required modules will be tested. As such, you need to provide a valid regex pattern.
For example, this worked nicely for me :
unmockedModulePathPatterns: [
      "node_modules\\" + path.sep + "react",
      "node_modules\\" + path.sep + "reflux",
      "node_modules\\" + path.sep + "react-router"
    ],

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

unmockedModulePathPatterns will only work with absolute paths or partial path patterns, but no relative paths. This is by design and will most likely not be changed.


Can't get balances with 403

Hey!
Just want to start off by saying that this is a great package you've built here. Just curious if this is still working for you?
I tried rotating my keys and whitelisting the IP to test the balances endpoint but I would get 403 every time.
Please let me know if you have time to look into this. Thanks!

As commented on the PR I haven't tested this for a while and I know that Newton are doing a lot of changes so it could be broken.
I would love to have a sandbox Environment from Newton to test against but last time I checked they were not willing to provide one.
I will test again and try to fix this, the api is not well documented and most of what's in this package is based on trial and failure


Updated readme

This PR updates the readme. The changes here are at the "Installation and Usage" part, and an addition of a "Instruction for Mac users" field.

I want to thank you for taking the time to contribute to this. I'm grateful @raznerdeveloper


Exception in thread "main" java.lang.IllegalStateException: Unable to find tools.jar

On windows, my JDK is installed at C:\Program Files\Java\jdk1.8.0_65.
JAVA_HOME is set to that directory.
From the code at we can see that 'locateToolsJar()' is searching in the wrong library.
Instead of searching in 'return new File(home,"../lib/tools.jar");' it should be 'return new File(home,"/lib/tools.jar");'
From 'https://docs.oracle.com/javase/tutorial/essential/environment/sysprop.html' we can see that java.home is 'Installation directory for Java Runtime Environment (JRE)' and not JDK

Faced similar issue when I downloaded the jar and try to run.


Feature Request: Meeting Conflict

Would be nice of awmy could keep meetings stored and tell people if their proposed meeting time conflicts with other standing meetings. This would be very useful since we are a global org with so many teams.

AWMY is not intended to be Mozilla-only, so I'm not sure it makes much sense. It's also currently very much stateless, so that this would not be an easy fix...

As I consider this out of scope, closing.


An icon for Topsoil

Although obviously not critical, an icon for Topsoil would be much appreciated if anyone with the ability feels the urge to contribute.


Fix auth upper bound

Replaces https://github.com/googleapis/packman/pull/127
google-cloud-python is effectively using version 3.0.0 anyway. Having this upper bound causes version conflicts, so it was doing more harm than good.
Also exclude pre-releases from all upper-bounds.

Current coverage is 91.23% (diff: 100%)

Merging #133 into master will not change coverage

@@             master       #133   diff @@
==========================================
  Files             3          3
  Lines           719        719
  Methods         150        150
  Messages          0          0
  Branches        116        116
==========================================
  Hits            656        656
  Misses           63         63
  Partials          0          0

Powered by Codecov. Last update 50079b2...eb1851d


bug: keyboard navigation after doing search

In the search and pagination example:
https://bossanova.uk/jexcel/v3/examples/datatables
if we make a search (e.g. type ELEC in search box),
and then try to navigate down using the keyboard, the selected cell  disappears, spreadsheet becomes empty, and we can see negative page numbers.

Thanks for spotting that out. It has been fixed.


Module parse failed: Unexpected token

What version of React, ReactDOM/React Native, Redux, and React Redux are you using?

React:  18.0.15
ReactDOM/React Native: 18.0.6
@reduxjs/toolkit: "^1.8.3",
Redux: 4.2.0
React Redux: 8.0.2

What is the current behavior?
Module parse failed: Unexpected token (10:12)
File was processed with these loaders:

./node_modules/ts-loader/index.js
You may need an additional loader to handle the result of these loaders.

What is the expected behavior?
The reason of not doing build: react-scripts-build is because in AWS linux server freezes on npm run build I'm trying to setup webpack.config to make it faster.
I'm sure this is something simple idk where to post this, I have 2 months experience with typescript. Idk if is the tsconfig.json or webpack.config
npm start works fine

Which browser and OS are affected by this issue?
windows 11 AMD razer
Did this work in previous versions of React Redux?

[X] Yes

This appears to be an issue with your own application code and build setup, rather than React-Redux. You need to actually compile your app code with Babel or TypeScript to turn that JSX syntax into plain JS.
See https://www.robinwieruch.de/webpack-babel-setup-tutorial/ and https://www.taniarascia.com/how-to-use-webpack/ for a couple good articles on how to do this.

I think is something in the tsconfig file but I have no idea what it is

This has nothing to do with Redux, your setup is not able to handle <Jsx>.


Problem with shapes in simple transformed distributions

Hi,
I'm working on an application with normalizing flows which requires sampling constrained values for some dimensions of the flow.
I found that the dimension verification to be a bit unpredictable in distrax.Transformed.
For example, a simple a sigmoid transformation of a multivariate normal works well using tfp jax substrate but  doesn't work with distrax:
from jax import numpy as jnp
import haiku as hk
import distrax
from tensorflow_probability.substrates import jax as tfp
tfd = tfp.distributions
tfb = tfp.bijectors

prng_seq = hk.PRNGSequence(123)
event_shape = (3,)

base_dist = tfd.MultivariateNormalDiag(
    loc=jnp.zeros(event_shape),
    scale_diag=jnp.ones(event_shape),
)
q_distr = tfd.TransformedDistribution(base_dist, tfb.Sigmoid())
q_distr.sample(seed=next(prng_seq)) # All good :)

base_dist = distrax.MultivariateNormalDiag(
    loc=jnp.zeros(event_shape),
    scale_diag=jnp.ones(event_shape),
)
q_distr = distrax.Transformed(base_dist, distrax.Sigmoid()) # Doesn't work :(
# ValueError: Base distribution 'MultivariateNormalDiag' has event shape (3,), but bijector 'Sigmoid' expects events to have 0 dimensions. Perhaps use `distrax.Block` or `distrax.Independent`?
q_distr = distrax.Transformed(base_dist, tfb.Exp()) # Doesn't work either :(

Would be very nice to have this supported by distrax.
Thank you!!!
All best,
Chris

Hi Chris,
Thank you for your comment. This was an intentional design choice for distrax to make bijectors closer to their mathematical definition. Note that distrax.Sigmoid is a bijector that transforms a scalar value x into another scalar value y by applying the transformation y = sigmoid(x). Since the bijector acts on scalars, having a 3-dimensional input vector throws an error.
To avoid the error, you need a bijector that transforms a vector x into a vector y by applying the transformation y_i = sigmoid(x_i) for each component i of the vector. To obtain such bijector, as suggested by the error message, you can use distrax.Block(). For example, this code snippet should work:
base_dist = distrax.MultivariateNormalDiag(
    loc=jnp.zeros(event_shape),
    scale_diag=jnp.ones(event_shape),
)
bij = distrax.Block(distrax.Sigmoid(), 1)
q_distr = distrax.Transformed(base_dist, bij)

Hi Francisco,
Thanks so much for the quick and insightful reply.
I agree, making this explicit declaration of Block brings clarity in many cases. I'll modify my scripts as suggested.
Enjoy the rest of the weekend :)
Best, Chris


⚠ Bofrost.fr has degraded performance

In cdeed3d, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 999 ms

Resolved: Bofrost.fr performance has improved in 0325efd.


Migrate Indexer docs to Nextra

Description

Fixed and checked all links manually.

Both within the indexer section and outside where it linked to indexer content.
Turned absolute links into relative ones.

Converted all terminals to have filenames.
Fixed all pages to use Nextra callouts.
Did a scan of all pages to make sure the styling seems alright.

Checklist

Do all Lints pass?

[] Have you ran pnpm spellcheck? - Didn't work for me still unfortunately
[X] Have you ran pnpm fmt?
[X] Have you ran pnpm lint?

@gregnazario @hariria The indexer docs migration is ready for review whenever you have a chance :)

@hariria @gregnazario Resolved all except the card change (I added a screenshot above for you to make the call on what you'd prefer, it's a 2 second change if you want the cards :) )


Maintaing the History of the books

Description
I would like to implement a feature that allows users to track their reading history, so they can keep a record of the books they have read. Can U please assgin me this project under GSSOC'23
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the [Contributing Guidelines]
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

@vivxsdb Given the absence of authentication or authorization features, how do you plan to execute its implementation?

Actually I am planning to provide the authentication to your project

Which will be easier for the user to use this platform

Please assign me with this issue under GSSOC'23 I want to work on this issue

@vivxsdb ok go for it

@vivxsdb any updates?

@vivxsdb please go through the discussion and read the following
then again open an issue related to that
like if you can work on that technologies

I have completed the backend part today i am going to submit

@vivxsdb Have you gone through discussion?

U mean the issues section


Jvenstad/do unified

@mpolden please review.
Must be merged with https://git.ouroath.com/vespa/hosted/pull/5752

I'll fix these things in a new PR, if you don't mind?

Sure!


Bindable dropdown

Hi! I would like to help the development of the project and participate in the development.🔥
I thought that adding dropdownField as a standard element in UnityMvvmToolkit would be very useful!
I will be glad of any criticism and corrections)

@ChebanovDD  Good afternoon! What else needs to be fixed so that the changes can get into develop?


Dark mode toggle: Refactor label for better A11Y support for screen readers

Instead of using an aria-label, the full label works fine under the following conditions.

Hiding the icon spans/divs to screen readers with aria-hidden="true".
Adding htmlFor to the label.
Adding screen reader only text to the label.

Why? The aria-label on checkboxes is only read under certain conditions. Generally it requires a tab or direct checkbox access key such as x with NVDA. Using a real label allows the user to know what the control does even while exploring with virtual navigation, arrow keys.

@ianhodge Can you send this one in to main? Thanks.

done!
On Thu, Apr 6, 2023 at 12:51 AM Alex Stine @.***> wrote:

@ianhodge https://github.com/ianhodge Can you send this one in to main?
Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/warpdotdev/commands.dev/pull/63#issuecomment-1498488651,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWZT4JJTUPV2BXMWKPHU2G3W7ZDUXANCNFSM6AAAAAAVYILPZ4
.
You are receiving this because you were mentioned.Message ID:
@.***>


[Workspaces] Users without personal datasets

Users without personal datasets but that belongs to one or more workspaces which have datasets, should automatically change to one of those workspace?
Better to show all datasets from all workspaces in datasets list allowing to filter by workspace?

+1 For showing all datasets with the option to filter by workspace

See also #984

Specifications related to the proposal (WIP)
If NO dataset in any workspace: show the piece of code
Workspace is filtrable
A workspace belongs to a User or a Group and it's attached to an email. example: Alice workspace, IBM workspace, Linguists team workspace
A user/group can be invited to other workspaces based threw the email address
Filter: Automatic table refreshing on a check, need to uncheck one by one to remove filters
Define Filtered column and Sort column (in the first version I would recommend activating filters only for Workspace)
New feature: "add to top list" to keep accessible the main datasets user is working on
Doubt/pain point:
A workspace doesn't exist at the URL level, so we can´t share a batch of datasets belonging to a workspace for example

I think that keeping workspace as part of url is critical. As you mentioned, sharing datasets in different workspaces is one of them, but also, be able to distinguish datasets with same name allocated in different workspaces.
We need to discuss about workflow with workspace filters and the weird behaviour about breadcrumb + workspace filters

Summary

[ ] Breadcrumb. Datasets> Goonies>Dataset name
[ ] Filter is activated on Goonies dataset List when I click on Goonies
[ ] Add top list feature on default list (but filters stays the priority)

QA

[ ] Add Grey BG hover on filters
[ ] Invert order to: Workspace, Task, Tags

[ ] Modal shadow:
x: 0 px
Y: 8 px
Blur: 20px
Alpha: 20%
Color: #5D6997

[ ] Increase size of user modal (aprox 300px/200px) and give more space between account circle and modal


Multi caret undo breaks after typing too many characters

Godot version
v4.1.stable.official [970459615]
System information
Windows 10
Issue description
When replacing many instances of text with multi caret editing, if you replace it by typing too many characters the undo stack breaks with an error message scene/gui/text_edit.cpp:4002 - Condition "!undo_stack_pos->prev()" is true. Breaking.
Steps to reproduce
Multi caret select a lot of text and replace it by typing new text. Attempt to undo.
https://github.com/godotengine/godot/assets/3820082/8b605188-6de3-450c-a9e8-82b2b4ace3f8
Minimal reproduction project
N/A

Tagging @Paulb23 since they implemented Multi-caret editing.

Found the cause, basically the undo queue hits it maximum. Setting is in Project Settings -> GUI -> Common -> Text Edit Undo Stack Max Size: https://docs.godotengine.org/en/stable/classes/class_projectsettings.html#class-projectsettings-property-gui-common-text-edit-undo-stack-max-size
By default it's 1024. Each individual character change counts as an action. So if you've got 20 line multi carat, you can type just over 50 characters in one go before you hit the limit and undoing the operations results in an error. (20 x 50 =1000)
You can raise this limit (though you may need to restart to take effect) and it'll be able to take more characters.


Sometimes a child element is re-created in safari instead of just updating the attribute/property

This example is using lit-element but I think applies to lit-html as well:
https://jsbin.com/fereyax/edit?html,console,output
In this example, when the button is pressed the border style of a custom element is changed. The constructor of the child custom element color-panel logs a message in the console.
This happens in various scenarios on iOS Safari, but most reliably reproduced as follows:

Open the link https://jsbin.com/fereyax
click on the button to change the color
Go to a different tab in Safari
Come back to the original tab and click the button again
At this point, the constructor of the child element is called again.

This happens on Desktop Safari as well if you go to a different tab and stay there for 30 seconds - 1 min. Go back to the tab and hit the button -> Child Element gets recreated.

I believe it has something to do with how Safari puts background tabs into hibernation.

This probably has to do with the template cache. We store the processed lit-html Template objects in a WeakMap keyed by the identity of the TemplateStringsArray that we received as the first argument. I bet that as a page hibernates, those objects are GC'ed, and when the page wakes up new instances are created, cause us to have cache misses.

I have reproduced this without switching tabs on mobile either, but it is much harder to reproduce. Even those scenarios could be explained where GC happens for whatever reason.
(This bug is really annoying for one particular case I have, where the scroll position gets reset among other things in a virtual list).

We can use a Map instead of a WeakMap. It's a memory leak, but only of templates that are never rendered against and their source is collected correctly.

As I mentioned, I have no device that runs Safari. I'll try to get one next
week to run some tests.
On Fri, Oct 19, 2018, 00:37 Justin Fagnani<EMAIL_ADDRESS>wrote:

We can use a Map instead of a WeakMap. It's a memory leak, but only of
templates that are never rendered against and their source is collected
correctly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Polymer/lit-html/issues/575#issuecomment-431187306,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEyp4gCxf7IIBqnOfsTRTOHPsq7FoZks5umQKmgaJpZM4XvNJb
.

templates that are never rendered

Don't know the code well, but as an outsider: You could kep a WeakMap and a Map. Promote from WeakMap to Map on render.

I have the exact same issue, it causes a lot of trouble especially with elements which are expected to be placed on a website at most once (e.g. dialog controller), containing Google Maps (resets positions, markers, overlays...) or having on-create animations (e.g. charts).
In my app there is no need to switch tabs, it happens every few seconds (there are some realtime updates).

@merlinnot are you also seeing the in just Safari?

Yes, only in Safari. Chrome works perfectly fine.

Argh... I forgot that we hadn't actually switched to WeakMaps yet. This could be a nasty problem...
I made a JS-only reproduction and filed a WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=190756

Ugh! That means it may take some time till this is resolved. :(

I'm trying to ping my contacts on WebKit. We'll see. A workaround would be to either compile out template literals, or to concatenate the strings to build the cache key.

The bug is already imported to their internal system, so hopefully it gets addressed quickly. We'll still need a workaround in the meantime.

Here's a pure JS reproduction of the problem that @justinfagnani submitted to WebKit authors: https://codepen.io/pen/?editors=0012
What do you propose as a workaround until the fix for this lands? We could construct our own key from a string concatenation instead of using the array object id, but that means we can no longer use WeakMap to hold the templates, which adds a memory leak. It also has some other side-effects with template locality no longer being part of the key (i.e. two identical templates in different locations in the souce should have a different key under native implementation, but will share the same key with this implementation). I can't really think of another solution that does not have these problems.
Do you think we should use this workaround solution as a default for all browsers, or introduce some kind of detection for Safari and special-case for that browser only?
I'll try to have a preliminary PR in before end of the weekend that explores the available options.

For those following, @ruphin has a PR up at #579. With a small change, I think we can mitigate the perf impact to spec-compliant browsers and get this released soon.

I'm so glad someone else is experiencing this bug in Safari also (sorry for the enthusiasm). I have a couple key components that are broken in Safari because of this and have spent many hours trying to fix.
From what I have seen, it is like @pshihn explained "the constructor of the child element is called again". Which in turn causes Safari to loose the template.
To verify @ruphin solution PR #579, I updated template-factory.js with result.key and marker and it did seem to work.
Please cut a release with this fix.
Much appreciated and great job on lit-html!

Fixed by #579

Release v0.14.0 fixes the issue for me.
Awesome job and thanks a million!


Support Unicode 15 + Emoji 15

The beta data files are already available. Here are the commits that add support for it: https://github.com/node-unicode/node-unicode-data/compare/0f5bfbcc6f2dac90c17d2c84241d822d83812711^...71cb96b6d6eacc867ac2f702a4dc0eb5d1df5b47 I’ll keep this issue open until the official Unicode 15 + Emoji 15 release happens, since the data might still change before then.

This issue can be closed now that Unicode 15 has been released.


Nested repeaters unable to hydrate with node.input() or v-model

Reproduction
https://formkit.link/44bb8f00a799b49833b55e7e4a1b3623 (node.input)
Reproduction
https://formkit.link/3492c58d3f55196088ce29ba9201dee9 (v-model)
Describe the bug
When we defer the hydration of a repeater with node.input() or v-model the hydration fails and we are left with an empty state (beta.12).
Environment
• OS: macOS
• Browser Chrome
• Version >106

Woooooooooooooo 🍻. Finally. Fixed in beta.17

Releases 0.17.0, 0.17.1 and 0.17.2 are indeed fixed but 0.17.3 seems to have a regression because the issue is again present. I'll try creating a minimal repo to demo asap because I wasn't able to reproduce it on the playground, unfortunately.

You sure? 0.17.3 didnt really make any changes to this system at all.

There may be more to this. I'm not able to reproduce a minimal repo.
In my project, installing any of 0.17.0, 0.17.1 and 0.17.2, the repeater renders its items when hydrated with node.input, as soon as I install 0.17.3, it consistently fails by not rendering any of the items, and without error.
I'll dig more.

Ok, so it appears I should have been calling getNode within onMounted to guarantee that the form input is mounted before trying to hydrate it.
onMounted(async () => {
    const form = getNode('editForm');
    await form.input(initialData.value);
});

What I still don't understand is why it works with the other versions.

Can you provide a reproduction of what you are seeing?


Ask @foonathan how to use libclang + VS on appveyor

Aka fix appveyor build.
Related: #10, #29

Here is my Appveyor script: https://github.com/foonathan/standardese/blob/master/appveyor.yml
libclang is preinstalled.

I've noticed that you're building clang 3.8 in your Travis script. Clang 3.7 is in the Travis whitelist, and you can take libclang from that package (See https://github.com/GueimUCM/siplasplas/blob/master/.travis.yml#L103)

I'm not building clang 3.8, I'm downloading it. And given the time it takes Travis to install something, it is faster.

And given the time it takes Travis to install something, it is faster.
Good to know.

Also at the time of setting it up, LLVM's apt mirror was down.

Yeah, my builds magically become green some days ago...


CLOUD-688 flattened ambari role allocator logic

@lpuskas

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1101/

lgtm


style: dead bird to X

PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #6851

[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Did your issue had any of the "$" label on it?

[x] Fill up your DOT address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸
Footer and all the other locations uses that X

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 769abca
Refactored the code for opening the shopping cart modal from the navbar. Moved the logic and configuration from ShoppingCartModalConfig.ts and ShoppingCartButton.vue to Navbar.vue to improve code organization and performance.

🤖 Generated by Copilot at 769abca

ShoppingCartButton
Simpler, no more emit -
Autumn leaves falling

@yangwao When Twitter rebranded to X, the bird didn't fly away—it just got crossed out! 🐦✖

@yangwao The Twitter bird didn't just fly away; X marks its final resting spot.

pay 30 usd

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.48 USD/DOT ~ 6.696 $DOT
🧗 16UcV9V6nVvPYdHz98ymUKmNLkzjCEU5sbKJMi7hxYyTHjzR
🔗 0x577e8b29080d74c5e35980ddae54c135bf64610a18847ad47fc8a9f2c29b9792
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


vkpeak crashes at vkMapMemory() on APUs with large dedicated GPU memory allocations set in BIOS (>512MB)

vkpeak tries to allocate 3 ncnn::VkMat instances here. The allocation size is derived from VulkanDevice::get_heap_budget().
VulkanDevice::get_heap_budget() returns memory budget from the first heap with VK_MEMORY_HEAP_DEVICE_LOCAL_BIT flag. In the case of AMD APUs, this returns the heap representing dedicated GPU memory allocated by the BIOS.
When ncnn::VkMat does the actual allocation however, it uses VkBlobAllocator::fastMalloc(). It handles integrated GPU devices in a special way, specifically requiring VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT and preferring VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT.
As a result, VkMat allocates memory from the 3rd heap with only 256MB of capacity. This causes allocation failures in VkAllocator::allocate_memory() and NULL being passed into vkMapMemory() in VkBlobAllocator::fastMalloc(), resulting 0xc0000005 in amdvlk64.dll.
There's also potential memory performance issue, as the 256MB (device local | host visible) memory on APUs is not cacheable.

hi
please test if this fix works for you https://github.com/Tencent/ncnn/pull/4936

Tested. It allocated from the expected heap and no longer crashed. Thanks for the fix.

fixed release https://github.com/nihui/vkpeak/releases/tag/20230812


Ignore "parameters" tagged cells?

To use papermill, you need to tag the first cell with "parameters", and it should include only declarations. But it doesnt seem like we should enforce the same lint rules on this cell, since its basically "inputs" to the notebook.

Yes, I think we should support this.
Also, I've noticed that it's easy to make mistakes with tags. E.g. accidentally tagging two cells with "parameters". We can't catch all such tagging mistakes, but it might be nice to help out a bit.
I'm overall not very familiar with projects using notebook tags, so I'm not sure if the following more general proposal will be useful or not. Please let me know what you think.
What about allowing rules that target specific tags? And maybe excluding such tagged cells from the global rules, where more specific rules for the tag have been supplied?
Say you have these global rules:
rules = {
  max_cells_per_notebook: 3,
  max_lines_per_cell: 3,
  max_function_definitions: 2,
  max_class_definitions: 0,
  magics_whitelist: []
}

But if you also want:

to allow at most one cell tagged with parameters in the notebook
that if there is such a cell, to not count it towards the global max_cells_per_notebook allowance
to limit the number of lines in this cell to 10 (i.e. to say roughly, "10 parameters should really be enough for this kind of notebook!")

Maybe in addition to rules, you should also be able to supply rules_for_tag:
rules_for_tag = {
  parameters: {
    max_cells_per_notebook: 1,
    max_lines_per_cell: 10
  }
}

Cells tagged parameters would not count towards the global max_cells_per_notebook, and would not be subject to the global max_lines_per_cell - they'd need to follow rules_per_tag["parameters"] instead. They would still need to follow/contribute to others, such as max_function_definitions, because those were not overridden for the tag.
As usual, I continue to feel the fear that notebooks are a disaster zone of duplicating an already well established way of doing things in a worse way in many respects. And that every tool/proposal to help out with notebooks is enabling this disaster. But at the same time, I haven't seen a better solution than notebooks - I need notebooks! :)


Deleting Campaign with Ratings Throws Exception

Description

Deleting a campaign that has dm ratings throws an exception
Expected Behavior

Campaign should be deleted successfully
Actual Behavior

Query exception: integrity constraint violation is thrown
Steps to Reproduce

Log in with test account
Create campaign, (choose "None" as character)
Logout of test account
Login with different user
Join the campaign created in step 2 with different user
Create an Entry within that campaign, including the submission of a dm rating
Log back in with user who created campaign
Delete campaign

Context
Particular edge case for campaign deletion failing
Possible Fix
Fix foreign key constraints between ratings, entries, and campaigns tables
Other
Description
Additional Notes

Hey team! Please add your planning poker estimate with ZenHub @bcobo341 @IanjhPhillips @JasonGadoury @RobertoNittolo


Add basic RTC API

This pull request adds a very basic RTC API. It can be used to read and set the time, but no alarms or other interrupts are supported yet. There are also a few commits adding general debug stuff to the time module, as that was useful to me while I developed this.
I'm marking this PR as a draft, as it's based on #25. Otherwise, this is ready to review.
cc @lthiery

Build fails for STM32L0x1 due to warnings. Will fix shortly.

There was also another problem that was masked by the first: The RTC example only works on STM32L0x2.
Everything's fixed now. Pull request has been rebased. I've rolled the fixes into the existing commits.
This is ready for review now.

You rock! Thanks again for all your recent PRs!

You rock! Thanks again for all your recent PRs!

Thank you :-)
And thank you again for all the reviewing/merging!


test: improve spawn_setuid_setgid test

Check that the child process' uid and gid are correctly set.

Not that I dislike the change, but out of curiosity, did you run into any weird problems with the test?

Not that I dislike the change, but out of curiosity, did you run into any weird problems with the test?

Not really. I was just reviewing https://github.com/libuv/libuv/pull/938 and saw some issues with the tests in that PR, and thinking about possible solutions: https://github.com/libuv/libuv/pull/938#discussion_r76897643, I thought it was a good idea to implement it for the current tests.

:+1:

PR updated! CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/115/

CI seems "green"

@saghul @cjihrig LGTY?

Oh, sorry, yeah, LGTM

LGTM

Landed as https://github.com/libuv/libuv/commit/4a71e7747a4a2acc888a914033e648e5d8521024


[Bug]: Re-rendering a VectorSource with a different key keeps previous cached tiles, causing flickering.

Mapbox Implementation
Mapbox
Mapbox Version
default
Platform
iOS
@rnmapbox/maps version
10.0.0-beta.70
Standalone component to reproduce
import React from 'react';
import {
  MapView,
  ShapeSource,
  LineLayer,
  Camera,
} from '@rnmapbox/maps';

const Map = () => {
  const [forceRerenderNumber, setForceRerenderNumber] = useState(0);
  const { data: webSocketUpdates } = useFetchZoneStatusUpdatesQuery();

  useEffect(() => {
    const refetchTiles = async () => {
      await MapboxGL.offlineManager.invalidatePack('evacuation_zone_layer');
      await MapboxGL.offlineManager.invalidateAmbientCache();

      setTimeout(() => {
        setForceRerenderNumber((prev) => prev + 1);
      }, CacheTimeoutPeriod + 1000);

      setTimeout(
        () => setForceRerenderNumber((prev) => prev + 1),
        CacheTimeoutPeriod + 3000,
      );
    };

    if (UpdateEvacZonesIds.includes(webSocketUpdates?.layerToUpdate ?? '')) {
      refetchTiles();
    }

    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [webSocketUpdates]);

    return (
      <MapView style={{flex: 1}}>
         <MapboxGL.VectorSource
              key={forceRerenderKey}
              id="evacuation_zone_layer"
              tileUrlTemplates={buildTileTemplatesURLs('evacuation_zone')}
           >
           <MapboxGL.FillLayer
                id="evacuation_zone"
                layerIndex={LayerIndexes.ZoneFill}
                style={{
                  fillColor: ['get', 'color'],
                  fillOpacity: 0.4,
                  fillOutlineColor: '#232323',
                }}
                sourceID="evacuation_zone_layer"
                sourceLayerID="evacuation_zone"
              />
          </MapboxGL.VectorSource>
      </MapView>
    );
}

Observed behavior and steps to reproduce
The fill layer gets cached and conflicts with the newly fetched tiles. As you zoom in and out the color changes. The actual color should be red but it switches from purple to red. This is happening in both iOS and Android.
Is there any way to discard all previously cached tiles to make sure this doesn't happen?
https://user-images.githubusercontent.com/24256469/231426288-a1cd9586-4a4e-4956-9804-b65b15260358.MP4
Expected behavior
The layer to stay red.
Notes / preliminary analysis
No response
Additional links and references
No response

@wmonecke Thanks for the report, in the code forceRerenderKey is not defined, please make your example complete

@mfazekas Updated the code. The forceRerenderKey is simply a number that gets increased to force a rerender of the component.

@wmonecke it's still not something we can run, even more undefined things. Please post a complete component that we can  run.
Also why does the color change? Did the url changed in vector source? Or just the url content? In the later case try changing the url too.

The tileUrlTemplates stays the same between re-renders. The color should NOT change, that is the bug I am trying to report. The tileUrlTemplates should be fetching the new tiles which would be the color red and only red.
I can't really post our server tile URL because of sensitive data.
I cannot provide a fully working example because that would need env keys.
@mfazekas  I am just trying to show that the previously shown tiles are somehow interfering with the newly fetched ones.
I don't think this issue should be closed though 😅

@mfazekas Could we reopen this issue, please? This functionality is critical to our organisation.

@wmonecke Sorry we do close issues if there is not enough info to reproduce it. This is an issue list for reproducible bugs, sorry. We do still accept PR-s, fixes.
Unfortunately we don't have resources to provide free support.

Will dig into the code and submit a potential PR for this issue. Thank you for the prompt response!

we are finding that changing the url of the VectorSource just makes the fill / line layers just vanish rather than getting updated

Can you try unmounting the VectorSource then remounting it with the updated
url?
A bit hacky but it's what is working.
On Sat, 13 May 2023 at 09:09, Dakuan @.***> wrote:

we are finding that changing the url of the VectorSource just makes the
fill / line layers just vanish rather than getting updated
—
Reply to this email directly, view it on GitHub
https://github.com/rnmapbox/maps/issues/2787#issuecomment-1546555395,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFZB7VMCVKCPZQOFRQDU7M3XF4XRVANCNFSM6AAAAAAW3OV7QQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


HDDS-5502. [OFS] URI parser throws URISyntaxException when path contains space

https://issues.apache.org/jira/browse/HDDS-5502
java.net.URI(String) rejects parsing unescaped space characters (probably others as well) in the given String, raising URISyntaxException when the input path has such characters.
Added a custom parser to work around the limitation. Use hadoop.fs.Path to parse the input path string (which uses URI internally but normalizes input) instead.

@smengcl I am unable to re-run CI workflow. Can you please re-trigger CI by pushing an empty commit?

@smengcl I am unable to re-run CI workflow. Can you please re-trigger CI by pushing an empty commit?

Yes.
It turns out there is a valid corner case caught by the acceptance misc test.
hdfs dfs -ls ofs://om/volume1/bucket1 2>&1

${output} = -ls: Can not create a Path from an empty string

Working on the fix.

Thanks @vivekratnavel for reviewing and merging this patch!


find website support chat ui

I have consulted all the documents on the official website and could not find the support chat UI similar to the following, but I think this is also a relatively common component. Do other people have any ideas, or I did not read the documents carefully enough?

thanks very much.

Hi @joeylin. Although this is a common component, I don't think it will ever be implemented in this project as a reusable component. Mainly because this is a very specific component.
However this could be developed as an example of what you can build with this shadcn/ui.

@joeylin, you might want to try https://github.com/marcusschiesser/ui - It's a chat component based on shadcn-ui.
I started writing a PR for the new chat component and wanted to send it to shadcn-ui, but I agree with @dan5py that a chat component is too specific and out of this project's scope.
My goal with https://github.com/marcusschiesser/ui is to make a set of beautiful components for LLM applications. So there are more to come.

@joeylin you can also checkout my repository: https://github.com/jakobhoeg/shadcn-chat

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

How can I make liek this in shadcn/ui?


Fixed bug produced by using random UUID to replace same UUID used for partitions due to old bug.

Codecov Report

Merging #5175 into 1.1 will decrease coverage by <.01%.
The diff coverage is 95.23%.

@@             Coverage Diff              @@
##                1.1    #5175      +/-   ##
============================================
- Coverage     82.54%   82.54%   -0.01%
- Complexity    11015    11019       +4
============================================
  Files          1330     1330
  Lines         45064    45072       +8
  Branches       5665     5668       +3
============================================
+ Hits          37199    37204       +5
+ Misses         5225     5224       -1
- Partials       2640     2644       +4

Impacted Files
Coverage Δ
Complexity Δ

...rate/metadata/doc/CrateMetaDataUpgradeService.java
84.61% <95.23%> (+0.24%)
30 <0> (+4)
:arrow_up:

...peration/collect/BatchIteratorCollectorBridge.java
65.78% <0%> (-10.53%)
2% <0%> (ø)

...ration/collect/collectors/OrderedDocCollector.java
90% <0%> (-10%)
5% <0%> (-1%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
85% <0%> (-5%)
2% <0%> (ø)

.../collect/collectors/LuceneOrderedDocCollector.java
90.12% <0%> (-3.71%)
25% <0%> (-1%)

...in/java/io/crate/breaker/RamAccountingContext.java
80% <0%> (-3.34%)
19% <0%> (-2%)

...ration/collect/collectors/LuceneBatchIterator.java
86.81% <0%> (-3.3%)
35% <0%> (-1%)

...transport/executionphases/ExecutionPhasesTask.java
92.59% <0%> (-2.78%)
24% <0%> (ø)

...ticsearch/indices/recovery/BlobRecoverySource.java
71.25% <0%> (-2.5%)
6% <0%> (ø)

...a/io/crate/operation/fetch/NodeFetchOperation.java
83.67% <0%> (-2.05%)
13% <0%> (ø)

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72ce30...df80c10. Read the comment docs.


TuSimple Test: The model and loaded state dict do not match exactly.

I tried to use the pretrained model 'tusimple_large' to test and I'm running into this error.
Command used to test
python tools/condlanenet/tusimple/test_tusimple.py configs/condlanenet/tusimple/tusimple_large_test.py '/content/gdrive/MyDrive/LaneDetection/tusimple_large.pth' --show --show_dst '/content/showPath' --result_dst '/content/result'
Error:
The model and loaded state dict do not match exactly
size mismatch for bbox_head.mlp.layers.0.weight: copying a param with shape torch.Size([64, 200, 1]) from checkpoint, the shape in current model is torch.Size([64, 100, 1]).
[                                                  ] 0/2782, elapsed: 0s, ETA:Traceback (most recent call last):
File "tools/condlanenet/tusimple/test_tusimple.py", line 236, in
main()
File "tools/condlanenet/tusimple/test_tusimple.py", line 232, in main
crop_bbox=cfg.crop_bbox)
File "tools/condlanenet/tusimple/test_tusimple.py", line 141, in single_gpu_test
return_loss=False, rescale=False, thr=hm_thr, **data)
File "/usr/local/lib/python3.7/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/usr/local/lib/python3.7/site-packages/torch/nn/parallel/data_parallel.py", line 159, in forward
return self.module(*inputs[0], **kwargs[0])
File "/usr/local/lib/python3.7/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/content/gdrive/My Drive/LaneDetection/conditional-lane-detection/mmdet/models/detectors/condlanenet.py", line 329, in forward
return self.forward_test(img, img_metas, **kwargs)
File "/content/gdrive/My Drive/LaneDetection/conditional-lane-detection/mmdet/models/detectors/condlanenet.py", line 369, in forward_test
kwargs['thr'])
File "/content/gdrive/My Drive/LaneDetection/conditional-lane-detection/mmdet/models/dense_heads/condlanenet_head.py", line 444, in forward_test
masks = self.mask_head(mask_branch, mask_params, num_ins)
File "/usr/local/lib/python3.7/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/content/gdrive/My Drive/LaneDetection/conditional-lane-detection/mmdet/models/dense_heads/condlanenet_head.py", line 119, in forward
x = torch.cat([locations, x], dim=1)
RuntimeError: Sizes of tensors must match except in dimension 2. Got 80 and 40 (The offending index is 0)
Please help me figure out what is wrong.
Thanks in advance.

Dataset path:
TuSimple Dataset installation as mentioned in dataset.md was confusing as the directory structure I got was different from what is mentioned in the installation when I ran the code. So I made dataset root to point to my tusimple-test.
Am I facing the issue due to this?

解决了吗

求指导

解决了吗

I meet the same question.
After debugging, I found that locations.shape is (1, 1 40, 100) and x.shape is (1, 64, 80, 200) and locations.shape is decided by /conditional-lane-detection/configs/condlanenet/tusimple/ tusimple_large_train.py :72
location_configs=dict(size=(batch_size, 1, 40, 100), device='cuda:0'))
so, I changed it to location_configs=dict(size=(batch_size, 1, 80, 200), device='cuda:0')) to match the size. And the result seems to be correct.

[{"name":"Accuracy","value":0.9654015183,"order":"desc"},{"name":"FP","value":0.0200934579,"order":"asc"},{"name":"FN","value":0.0350167745,"order":"asc"},{"name":"F1","value":0.9723876298,"order":"asc"}]

By the way , neither the smalll size nor medium size model causes the error. If anyone have a clue about x.shape's change please tell me:smile:

非常感谢

I meet the same question.
After debugging, I found that locations.shape is (1, 1 40, 100) and x.shape is (1, 64, 80, 200) and locations.shape is decided by /conditional-lane-detection/configs/condlanenet/tusimple/ tusimple_large_train.py :72
location_configs=dict(size=(batch_size, 1, 40, 100), device='cuda:0'))
so, I changed it to location_configs=dict(size=(batch_size, 1, 80, 200), device='cuda:0')) to match the size. And the result seems to be correct.

[{"name":"Accuracy","value":0.9654015183,"order":"desc"},{"name":"FP","value":0.0200934579,"order":"asc"},{"name":"FN","value":0.0350167745,"order":"asc"},{"name":"F1","value":0.9723876298,"order":"asc"}]

By the way , neither the smalll size nor medium size model causes the error. If anyone have a clue about x.shape's change please tell me😄
非常感谢，还有个问题 怎么输出它的性能指标
[{"name":"Accuracy","value":0.9654015183,"order":"desc"},{"name":"FP","value":0.0200934579,"order":"asc"},{"name":"FN","value":0.0350167745,"order":"asc"},{"name":"F1","value":0.9723876298,"order":"asc"}]


pointer initialization #382

See #382

This change is

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

types/resolve.go, line 340 at r1 (raw file):

	out = strings.Replace(out, " [", "[", -1)
	out = strings.Replace(out, "] ", "]", -1)
	out = strings.Replace(out, " ]", "]", -1)

There are now a lot of combinations of replacing, what about a regex that covers all of these?

Comments from Reviewable


Ability to determine the Proxied Destination before proxying

What should we add or change to make your life better?
It would be very helpful to determine the proxied destination before we actually proxy. Maybe this can be done with a method on the IReverseProxyFeature (or something accessible via IReverseProxyFeature) that would determine the proxy destination and then use this value when proxying the request.
Why is this important to you?
I'd like to output a Via response header that contains some information about where the request was proxied to. I can't use IReverseProxyFeature.ProxiedDestination as this property is only available after the request has been proxied and no headers can be added as the request has already started.

You can (and should) do this in response transforms, you'd have full access to the request and response at that point.
https://microsoft.github.io/reverse-proxy/articles/transforms.html#extensibility
Alternatively, you can do this in middleware. Place the middleware after LoadBalancing and then look at IReverseProxyFeature.AvailableDestinations. There should only be one left at that point and that's the one that will be proxied to.

I was just thinking that my idea wouldn't work because of the built in middleware, e.g. health check middleware, that could filter out the "pre-determined" destination between the call to my proposed method and the request being proxied. It would still work for me as I'm not using them, but it wouldn't work for others, at least not nicely.
I think response transforms may be the way to go. I'll take a look tomorrow, but as long as I have access to the IReverseProxyFeature with the ProxiedDestination set, I think it'll be a winner 👍
The middleware idea wouldn't work in my scenario as I could be left with multiple AvailableDestinations and not know which one would be picked by the proxy prior to sending.

I was just thinking that my idea wouldn't work because of the built in middleware, e.g. health check middleware, that could filter out the "pre-determined" destination between the call to my proposed method and the request being proxied. It would still work for me as I'm not using them, but it wouldn't work for others, at least not nicely.

That's a matter of ordering. Session affinity goes before load balancing, where your component would go after.

The middleware idea wouldn't work in my scenario as I could be left with multiple AvailableDestinations and not know which one would be picked by the proxy prior to sending.

You should be using LoadBalancing to address that. The default behavior is to log a warning and pick randomly if there are still multiple available destinations when you reach the end of the middleware pipeline.

I think response transforms may be the way to go. I'll take a look tomorrow, but as long as I have access to the IReverseProxyFeature with the ProxiedDestination set, I think it'll be a winner

It is, but you shouldn't need it since you'll have direct access to the proxy request and response and their RequestUrl.

I'm going to be using the proxy to route tenant requests to their data sovereign regions. LoadBalancing doesn't seem like it's going to be much use to me just yet.
I'm glad I'll have access to the IReverseProxyFeature as the proxy request and it's URL isn't much use.
To give more context of what I'm doing to achieve, I want to output a Via header that looks something like:
Via: HTTP/1.1 eu (a:2;f:1;d:us)
This should adhere to the HTTP spec, but more importantly; it'll tell me that the request hit the EU proxy (eu), (a for "all") there were 2 destinations in AllDestinations, (f for "filtered") there was 1 destination in AvailableDestinations (we have middleware that filters AllDestinations), then finally (d for "destination") the request was proxied to the US region (us would be the destination identifier).
Thanks for your help, I'll reply back tomorrow after I've tried a response transform. 👍 I'm also happy to have a call to talk about our use-case if you're interested.

Interesting. I'd have expected tenant routing to be handled at the routing layer, and each data sovereign region to be its own cluster. What field(s) on the request do you use to identify the tenant?

We're going to be using a claim in the JWT to determine the tenant region. I did want to have each region be a cluster but I couldn't work out a way to do that. The examples given were of filtering destinations in a given cluster. Do you have any suggestions?

Ah, routing by claim would be hard, especially since we normally decide what auth to apply after routing.

No worries, what we've got so far is working and appears to be working well. Let me know if you'd like any further information or if there's any way I can help.
I'll update you tomorrow when I've tried out the response transform, but I'm hopeful.

We're going to be using a claim in the JWT to determine the tenant region. I did want to have each region be a cluster but I couldn't work out a way to do that. The examples given were of filtering destinations in a given cluster. Do you have any suggestions?

@Tratcher - we had talked about this scenario of being able to change the way that routes are mapped to clusters and destinations. Can he replace the existing mapping and just provide his own collection of available destinations?

Fyi, using a ResponseTransform appears to work. 👍
However, my only issue now is unit testing it as I can't create a new ResponseTransformContext and initialise the HttpContext property in a .NET Core 3.1 app as the property is init only. There's no interface for me to implement and provide my own implementation to the ResponseTransform.Apply(ResponseTransformContext) method, e.g. IResponseTransformContext. I can't create a child of ResponseTransformContext and hide the HttpContext property with the new keyword as the ResponseTransform.Apply(ResponseTransformContext) method only see's the hidden property which will always be null.
Please be careful with init only properties as .NET Core 3.1 apps don't support them (locked to lang version 8.0, init was added in 9.0) and if there's no interface that I can implement to provide my own implementation, e.g. IReverseProxyFeature, I'm stuck.

If the backend destination fails to respond, e.g. a timeout or some other issue, the ResponseTransform won't be called. This breaks a very important scenario for me. I still want the Via header to be included in the response, but I can't seem to figure out how to do that.

It really would be useful to have something like:
services.AddReverseProxy(options =>
{
    OnBeforeProxy = (context) =>
    {
        // This would be called somewhere just prior to https://github.com/microsoft/reverse-proxy/blob/2fd46596c7cc370660f024e442ac3c8c00b88acf/src/ReverseProxy/Proxy/ProxyInvokerMiddleware.cs#L80
    }
});

Please be careful with init only properties as .NET Core 3.1 apps don't support them (locked to lang version 8.0, init was added in 9.0) and if there's no interface that I can implement to provide my own implementation, e.g. IReverseProxyFeature, I'm stuck.

See https://github.com/microsoft/reverse-proxy/issues/837, there are C# 9.0 options for 3.1.

If the backend destination fails to respond, e.g. a timeout or some other issue, the ResponseTransform won't be called. This breaks a very important scenario for me. I still want the Via header to be included in the response, but I can't seem to figure out how to do that.

The lack of transforms on response failures is an interesting gap. Right now many response transforms can be marked as "Always" or "Success", but at the moment "Always" doesn't include a failure to respond. I'm going to open a separate issue for that.

It really would be useful to have something like:
services.AddReverseProxy(options =>
{
    OnBeforeProxy = (context) =>
    {
        // This would be called somewhere just prior to invoking the proxy, e.g.
        // https://github.com/microsoft/reverse-proxy/blob/2fd46596c7cc370660f024e442ac3c8c00b88acf/src/ReverseProxy/Proxy/ProxyInvokerMiddleware.cs#L80
    }
});

You could do that with a request transform, it gives you the HttpContext and the content you want to add doesn't depend on the actual response.

Thanks, Chris. I did install the .NET 5.0 SDK in the build pipeline, but then I had an error with the test project, so I just ended up switching the solution over to .NET 5.0.
I'm doing something similar with the request transform, but I'm stuck with it not being called when the backend fails to respond. :( Which is a real pain because that's exactly the type of issue where I'd want to see a Via header in a HAR file or network trace and see which backend they were routed to.
On a more positive note: Yarp is a really great tool. You're doing a good job. I'm really excited about using it.

I'm doing something similar with the request transform, but I'm stuck with it not being called when the backend fails to respond.

? Request transforms are called before sending the request, they should always run. If there's a response failure you'll get a 502/503, but any extra response headers you added before that should still be sent.

Sorry, my bad, I meant response transform.

Yep, that works. Thank you very much. 👍

We're going to be using a claim in the JWT to determine the tenant region. I did want to have each region be a cluster but I couldn't work out a way to do that. The examples given were of filtering destinations in a given cluster. Do you have any suggestions?

@Tratcher - we had talked about this scenario of being able to change the way that routes are mapped to clusters and destinations. Can he replace the existing mapping and just provide his own collection of available destinations?

Routes are hard coded to a cluster right now, but what you can do in middleware is completely replace the IReverseProxyFeature if you want to re-route. You could use IClusterChangeListener to collect clusters to choose from.
At that point you have to ask if using IHttpProxy directly would be simpler.

I'm fine with having a single cluster with multiple destinations configured, then using middleware to filter the destinations.
But I imagine there being a requirement to dynamically choose a cluster for a given route. It's not an issue for me because the destinations are in Azure and we can scale out to achieve high availability/load balancing.

Triage: Seems to be answered, closing.


azcopy tls version

Hi! Which version of TLS is used in azcopy 7.1? Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e224df65-311e-166c-caff-918f47ad2f57
Version Independent ID: 21914f58-1720-39d9-acb7-ed8475cab9d4
Content: Copy or move data to Azure Storage with AzCopy on Linux
Content Source: articles/storage/common/storage-use-azcopy-linux.md
Service: storage
GitHub Login: @seguler
Microsoft Alias: seguler

@kpako396p Thanks for the feedback. We are actively investigating and will get back to you soon.

Azure storage(Including Azcopy) uses TLS 1.2 on public HTTPs endpoints but TLS 1.0 and TLS 1.1 are still supported for backward compatibility. More can be found here: https://docs.microsoft.com/en-us/azure/storage/common/storage-security-tls
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.