ParameterSlider: Parameter snapping during mouse drag causing issues

Knobs weren't responding smoothly when a parameter range was set at (0 -> 3) and the snap was at 1. Fixed by having an additional member variable holding the last value created by the slider then using this variable instead of the normalized value in the mouse drag function.
Here's the constructor
ParameterSlider::ParameterSlider(StateManager* s, size_t p_id)
   : juce::SettableTooltipClient(), juce::Component(), param_id(p_id + 1), state(s)
{
    // param_id is initialized to p_id + 1 so that update_param_id runs on the first call
    update_param_id(p_id);
    setOpaque(true);
    setColour(ColourIds::sliderColourId, juce::Colour(0xff000000)); // to change the colour of the slider, set colour id 1
    last_value = state->param_value(param_id);
    last_value = PARAMETER_RANGES[param_id].convertTo0to1(last_value);
}
And here's the updated function
void ParameterSlider::mouseDrag(const juce::MouseEvent& e) {
    // change parameter value
    auto cur_position = e.getPosition();
    auto change = cur_position - last_mouse_position;
    auto speed = (e.mods.isShiftDown() ? 0.05f : 1.0f) * pixels_per_percent;
    auto slider_change = 1.0f * float(change.getX() - change.getY()) / speed;
    auto new_val = last_value + slider_change;
    state->set_parameter_normalized(param_id, new_val);
    last_mouse_position = cur_position;
    last_value = new_val;
}
Great work on the template by the way! Using it to update a filter plugin I made a few years ago.

Thanks. Will take a look later today and push something!


Added return value to DurationField.prepare_value

@timgraham this is in response to my prior pull request (sorry for all the added friction - this is sort my first time actually patching Django, other than Docs and a couple patches back in the SVN days). Let me know if you need anything updated in this.

merged in 49647bec6e86b8d3d370ea1d8a80423185502c5a.


[Bug]: Appsmith auto-updates not cleaning up old images after update

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The old images of Appsmith are not getting deleted when auto-updating the image.
Steps To Reproduce

Launch Appsmith container with auto-update enabled
Wait for updated to be pushed
cmd: docker images
Observe the old images that have not been deleted

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
1.9.16

@sum35h, were we able to reproduce this? If I recall right, we couldn't reproduce this, right?


Clean up "dev" code

For example, https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Main.hx#L1015:
if( !FileSystem.exists(proj) ) {
	FileSystem.createDirectory(proj);
	File.saveContent(proj + "/.current", "dev");
}

@dpeek pointed out that saving ".current" should probably happen outside of the if statement.  On further reading of the source though, that isn't necessary at all - we shouldn't write it to begin with.  Or if we do, we should reset it when disabling dev.
Either way it would be nice to make this more obvious, or possibly write some unit tests for it.

What's with the original issue. Does this still need addressing?

Basically in some places (but not all) we set ".current" to the string "dev" when dev mode was enabled.  But this wasn't actually required - the existence of a ".dev" file is all that matters.
Furthermore, it meant when you disabled dev mode on a library, it did not always restore the previous version as "current".
Fixed now.


Some generic refactoring

See each comments for more details

Closing in favor or a more completed one https://github.com/lnspec-tools/lncodegen/pull/35


message_fetch: Convert to typed_endpoint.

Migrated message_fetch to typed_endpoint.
Removed the old narrow_parameter as we have shifted to the new NarrowParameter Pydantic Object.
This new object provides better error messages for data validation, hence changed the error messages in test_message_fetch.
num_before and num_after are required parameters, added them to all the calls of get_messages_backend.
narrow: Use NarrowParameter instead of dictionary.
Earlier we were using the type OptionalNarrowListT for all functions
that required "narrow" as a parameter.
This commit changes all the functions accepting a "narrow"
to use a list of the new NarrowParameter
instead of OptionalNarrowListT which is a list of dicts.

I've split the commit into 3 commits.
For the multiple error messages I've used a List of Dict as it seemed to be the most readable option.
Addressed the other comment as well.

@PIG208 Thanks for the review. I have addressed the comments regarding the InvalidParam in test_message_fetch.py by creating a dataclass. I have also made a new commit to change all the functions in narrow.py to use NarrowParameter instead of the earlier type alias.

Looks very nice, merged, thanks @kennethnrk! I think this was likely one of the most complex endpoints to migrate, so glad to have it cut over :)

Thanks for the work @kennethnrk! Feel free to ping me to review typed_endpoint-related changes like this. I would like to help.


[ENH] Transformers module full refactor - part I, series module

This PR refactors all transformers in the transformations module to the new interface.
Conditional on #1790 and #1774 which are included.
This is part I - the entire transformations.series module, with exception of STLtransformer which is left untouched due to current discussions around the transformer (see #1677).
For all transformers, the following was carried out:

inheritance parent is now BaseTransformer
adding tags as appropriate
moving logic to underscore methods _fit, _transform, and _inverse_transform (where applicable)
removal of check/conversion logic which is already covered by BaseTransformer
linting and cleaning up docstrings

Reviewers should focus on individual transformers and the general pattern.
Changes to extension templates should be reviewed in #1774, not here.
Changes to BaseTransformer should be reviewed in #1790, not here.

@TonyBagnall, FYI. This is transformers, so also closely linked with TSC.
The refactored transformers should work out-of-the box on numpy3D inputs (they didn't before).

@lmmentel, would also appreciate a look and comments, since you recently looked into the transformers tutorial #1705, and the relevance for FeatureUnion.

Re "core logic", this should perhaps be better "implementation of abstract method which contains core logic"?

@chrisholder, I think I addressed/commented on your change requests:

as discussed on slack, I replaced the slightly obscure "core logic" line in the docstrings with something more extensive, throughout the transformer module
imports in get_test_params should stay in there, since we're using them only in testing. By design, when the package is used (not tested), the method can be ignored, so it should stay "hidden".

@GuzalBulatova, I think I addressed your comments?

pandas.DataFrame is interpreted as a multivariate series (not as a univariate panel), so the first thing is fine
in the BoxCoxTransformer, I've set the univariate-only tag to True, so it's an 1:1 mirror of pre-refactor function now

Merging since I would like to use this as example to point to in another PR, and @GuzalBulatova's review was a comment not a change request, so formally not a blocker.
@GuzalBulatova, kindly let me know (or unmerge) if you feel there is still outstanding items on Theta - I thought I've addressed them by reverting.


stf15/test stf 1123 with ci fixes

[jenkins] Reformat list of tested_files to trigger tests.
Initial implementation of certificates for Interconnect
Make ansible-linter happy

test

This PR was for testing #367 and has verified an issue I was seeing in #371 so I'm closing this one out.


IndexError: list index out of range

ubuntu@VM-0-3-ubuntu:~/apk-downloader$ python3 main.py com.imdb.mobile
Hello, Welcome to APK Downloader !!!
Getting download link...
Found app name, APK would be named: IMDb:Movies&TVShows
Traceback (most recent call last):
  File "/home/ubuntu/apk-downloader/main.py", line 199, in <module>
    main()
  File "/home/ubuntu/apk-downloader/main.py", line 165, in main
    token = re.findall("token','([^\']+)", last_script)[0]
IndexError: list index out of range

same problem


Can we expose ViteDevServer._pendingReload to consumers

Clear and concise description of the problem
At the moment, when I run a Jest test for the first time, when unoptimized dependencies are discovered the server gets flagged to do a "reload", where it optimize the dependencies and re-bundles the cache.
This results in tests failing, because they are unable to resolve dependencies in the cache while things are reloading.
To resolve this locally, after transformRequest I've added:
if (viteServer._pendingReload) {
  await viteServer._pendingReload
}

This works great, but it's an internal property, so I shouldn't use it. Lets make it accessible to consumers :)
Suggested solution
Rename _pendingReload -> pendingReload and remove the @internal tag.
Alternative
Other alternatives to resolve my issue:

Have a way to turn of optimizing deps after the server has started.
Expose _registerMissingImport to consumers, so we can set our own function for handling missing imports.
Make sure the consumer adds everything to either exclude/include for optimizeDeps

Additional context
No response
Validations

[ ] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

By the way, I am scott-the-brewer, this is just my main github account.

Hi, while I do think there's a bug here, I can't reproduce it consistently.
Could you please provide an example repo so that I can test the fix?

I haven't had time to create a reproduction of this, as we've developed our own jest-preset-vite in-house and I'm unable to share that code.
But I think this ticket can be closed, as I don't think this is the best way to resolve the issue. Potentially multiple ViteDevServer's could be open locally, maybe one for development and one for testing, and then both would have access to the cache directory.


Add kustomize overlay for standalone installation (master)

replace the namespace where kfserving is deployed with kubeflow
replace KFServing configmap gateway with kubeflow-gateway.kubeflow.

Fixes #976

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

If I understand correctly, in #976 @yuzisun means to add and overlay for kubeflow while retain the existing standalone one. Also we need change the document for kubeflow user.
Another thing is, I saw 3 PR for released version too, in my opinion we need not do that.

@pugangxa, Thank you for your comments,

If I understand correctly, in #976 @yuzisun means to add and overlay for kubeflow while retain the existing standalone one. Also we need change the document for kubeflow user.

To retain existing namespace(kfserving-system), some values need to be parameterized.
certificate.yaml, webhookcainjection_patch.yaml... and so on. I will apply them.

Another thing is, I saw 3 PR for released version too, in my opinion we need not do that.

@yuzisun mentioned "publishes the yaml for every KFServing release", so I judged the way of deployment would be changed as pipeline's one as below by releasing a improved version of each branch containing these yamls,
https://www.kubeflow.org/docs/pipelines/installation/standalone-deployment/#deploying-kubeflow-pipelines
I will update the document, as soon as the way of deployment is determined.
Please let me know what I misinterpreted.

@pugangxa, Thank you for your comments,

If I understand correctly, in #976 @yuzisun means to add and overlay for kubeflow while retain the existing standalone one. Also we need change the document for kubeflow user.

To retain existing namespace(kfserving-system), some values need to be parameterized.
certificate.yaml, webhookcainjection_patch.yaml... and so on. I will apply them.

Yes we should retain it for standalone kfserving deployment and these part will need overlay.

Another thing is, I saw 3 PR for released version too, in my opinion we need not do that.

@yuzisun mentioned "publishes the yaml for every KFServing release", so I judged the way of deployment would be changed as pipeline's one as below by releasing a improved version of each branch containing these yamls,
https://www.kubeflow.org/docs/pipelines/installation/standalone-deployment/#deploying-kubeflow-pipelines

OK, I am OK to commit it to different versions.

Please let me know what I misinterpreted.
I will update the document, as soon as the way of deployment is determined.

I'm hesitant to deploy to the kubeflow namespace. Many of our users consume us standalone as well. One of the challenges of working with kubeflow is that it's so heavyweight -- I'm much more interested in pursuing an option where we never deploy to the kubeflow namespace..

@jazzsir thanks for taking on this, the default should be still standalone installation in kfserving-system namespace, the intention of the original issue is to add another kustomize overlay to allow deploying to kubeflow namespace for users who are using Kubeflow and like to get on to the newer releases of KFServing. I think the change here would be making the namespace kustomizable instead of current way hardcoding the namespace everywhere.

@yuzisun @ellistarn thanks, I will make the namespace kustomizable

/ok-to-test

I tested it with gcr.io/kfserving/kfserving-controller:v0.4.0, because with the latest version, failed to run the controller.
{"level":"error","ts":1599011472.7178133,"logger":"controller-runtime.source","msg":"if kind is a CRD, it should be installed before calling Start","kind":"TrainedModel.serving.kubeflow.org","error":"no matches
for kind \"TrainedModel\" in version \"serving.kubeflow.org/v1beta1\"","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128\nsigs.k8s.io/controller-$untime/pkg/source.(*Kind).Start\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/source/source.go:88\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1\n\t/go/pkg/mod/sigs$k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:165\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/in$ernal/controller/controller.go:198\nsigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startLeaderElectionRunnables.func1\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/manager/internal.g$:477"}
{"level":"error","ts":1599011472.7179267,"logger":"entrypoint","msg":"unable to run the manager","error":"no matches for kind \"TrainedModel\" in version \"serving.kubeflow.org/v1beta1\"","stacktrace":"github.c$m/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128\nmain.main\n\t/go/src/github.com/kubeflow/kfserving/cmd/manager/main.go:145\nruntime.main\n\t/usr/local/go/src/runtime$proc.go:203"}

/retest

@jazzsir you might want to run following commands
git fetch upstream
git rebase upstream/master

/retest

@jazzsir Can you help rebase the PR ?

Close it, because of a problem with rebase, and it will be recreated.


usetech dotnet

https://github.com/usetech-llc/cosmos_api_dotnet

It looks unmaintained. Closing, feel free to re-open if disagreeing.


feat!: project re-org to yafti.core model

@marcoceppi does the re org work need to happen still?  I have little context

This doesn't have to happen anymore - depends on what you all want to carry forward


Update nginx configuration to allow processing of static-signed files

Uses fix provided in Magento nginx.conf.sample https://github.com/magento/magento2/pull/2323

+1, this nginx config mod is needed for let the version 2.1.3 work correctly.
Otherwise the url rewrite for static files doesn't work on magento CE 2.1.3.

Thanks guys, merging in.

Build 1.11-1 image (https://github.com/mageinferno/docker-magento2-nginx/tree/1.11-1). Should be done in a few minutes.


docs: How to run a data companion and use the pruning API

Add documentation for the ADR-101 feature branch. In the documentation, add information such as:
### Tasks
- [x] Introduction
- [x] gRPC services
- [x] Pruning services

I believe I've added all the content needed for the docs

Merged on PR #1307


send Zulip notification when cron job fails

Let's see if this works...

@pietroalbini does this look right to you? I don't have much experience with GH actions so there's a lot of guesswork involved here.^^

@pietroalbini does this look right to you? I don't have much experience with GH actions so there's a lot of guesswork involved here.^^

Looks correct at first glance!

Looks correct at first glance!

Great, thanks. :) Let's see if I get a notification tomorrow, then.
@bors r+

Great, thanks. :) Let's see if I get a notification tomorrow, then.
@bors r+

:pushpin: Commit 333d7bb2c5f197c21922e5505384ee0c24f7c931 has been approved by RalfJung

:pushpin: Commit 333d7bb2c5f197c21922e5505384ee0c24f7c931 has been approved by RalfJung

:hourglass: Testing commit 333d7bb2c5f197c21922e5505384ee0c24f7c931 with merge 838de0e8382960ed024509cac2b25c1e2b48b144...

:hourglass: Testing commit 333d7bb2c5f197c21922e5505384ee0c24f7c931 with merge 838de0e8382960ed024509cac2b25c1e2b48b144...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 838de0e8382960ed024509cac2b25c1e2b48b144 to master...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 838de0e8382960ed024509cac2b25c1e2b48b144 to master...


fix(Profile): Add loading spinner on update profile info

What this PR does 📖
1. Add loading spinner on update profile info

Which issue(s) this PR fixes 🔨

Resolve #1887
Resolve #1755

Special notes for reviewers 🗒
Additional comments 🎤

waiting on feedback regarding UI


Focus

Could be possible to add the focus effects of MaterialEditText? Colors of texts and underline color and width changes depending if it is focused or not

Maybe! I will take a look.


Update github library description and add keywords

In github library description we should have link to https://docs.zendframework.com/zend-code instead of github.io and it would be nice to have also some keywords with the library 😄

Suggestions? 😁
On 29 Jul 2017 10:28 AM, "Michał Bundyra"<EMAIL_ADDRESS>wrote:
In github library description we should have link to
https://docs.zendframework.com/zend-code instead of github.io and it would
be nice to have also some keywords with the library 😄
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zendframework/zend-code/issues/126, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakOxKKU--6fe88LFO1y57vz9GbPQSks5sSu0bgaJpZM4OnTAH
.

zendframework, php (obviously) and maybe: reflection, code-generation (or code-generator), ... hm ...

This repository has been closed and moved to laminas/laminas-code; a new issue has been opened at https://github.com/laminas/laminas-code/issues/11.


feat: rss for blog

I simplified to avoid using cheerio and adding the content, the user can click on the rss to read on the website, otherwise it's a nightmare with the code blocks and everything.


Update the Definition of the Variety

Codecov Report

Merging #1501 (039d1d7) into master (ef58fde) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
- Coverage   39.52%   39.39%   -0.14%
==========================================
  Files         598      590       -8
  Lines       35068    34956     -112
==========================================
- Hits        13861    13770      -91
+ Misses      19680    19656      -24
- Partials     1527     1530       +3

Impacted Files
Coverage Δ

proxy/vmess/validator.go
80.59% <ø> (ø)

testing/servers/tcp/tcp.go
81.81% <0.00%> (-5.46%)
:arrow_down:

testing/scenarios/common.go
73.07% <0.00%> (-4.62%)
:arrow_down:

transport/internet/udp/hub.go
73.61% <0.00%> (-4.17%)
:arrow_down:

transport/internet/system_listener.go
48.07% <0.00%> (-3.85%)
:arrow_down:

transport/internet/websocket/connection.go
16.51% <0.00%> (-3.67%)
:arrow_down:

transport/internet/kcp/connection.go
69.61% <0.00%> (-2.77%)
:arrow_down:

transport/internet/system_dialer.go
46.98% <0.00%> (-2.41%)
:arrow_down:

transport/internet/kcp/listener.go
81.18% <0.00%> (-1.99%)
:arrow_down:

transport/internet/headers/http/http.go
83.54% <0.00%> (-1.90%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef58fde...039d1d7. Read the comment docs.


Delete legacy is_categorical, is_static

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)

[x] Did you read the contribution guide?
[ ] Did you update the docs? We use Numpy format for all the methods and classes.
[ ] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Type of Change

[ ] Examples / docs / tutorials / contributors update
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Improvement (non-breaking change which improves an existing feature)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

Codecov Report

Merging #94 (8521cef) into master (d48e4f5) will decrease coverage by 4.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   88.04%   83.81%   -4.23%
==========================================
  Files          50       50
  Lines        2283     2280       -3
==========================================
- Hits         2010     1911      -99
- Misses        273      369      +96

Impacted Files
Coverage Δ

etna/transforms/datetime_flags.py
100.00% <ø> (ø)

etna/transforms/detrend.py
98.21% <ø> (-0.07%)
:arrow_down:

etna/transforms/pytorch_forecasting.py
26.38% <0.00%> (-73.62%)
:arrow_down:

etna/models/nn/tft.py
45.00% <0.00%> (-55.00%)
:arrow_down:

etna/models/nn/deepar.py
47.36% <0.00%> (-52.64%)
:arrow_down:

etna/loggers/base.py
92.30% <0.00%> (-1.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d48e4f5...8521cef. Read the comment docs.


[BUG] A running background task will block new requests from the OpenAPI view when using a metrics exporter middleware

Describe the bug
To Reproduce
Steps to reproduce the behavior with a minimum self-contained file.
Replace each part with your own scenario:

Create a file with:

from time import sleep

from fastapi import FastAPI, BackgroundTasks
from starlette_exporter import PrometheusMiddleware, handle_metrics

app = FastAPI()
app.add_middleware(PrometheusMiddleware)
app.add_route("/metrics", handle_metrics)

def task(seconds):
    print("Starting task, sleep", seconds)
    sleep(seconds)
    print("Done task, sleep", seconds)

@app.get("/{seconds}")
async def test(seconds: int, background_tasks: BackgroundTasks):
    print(f"In route with seconds={seconds}")
    background_tasks.add_task(task, seconds=seconds)
    return f"{seconds} hello world!"

Open the OpenAPI docs view and click "Try It Now".
Send a request with 10 seconds (or something else but make it long enough).
The response will return immediately.
Immediately send another request and the request will block until the backgroud task will finish.

Expected behavior
Requests shouldn't be blocked by background tasks
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

OS: Linux
FastAPI Version 0.52.0
Python version, 3.7.7

Additional context
At first, I thought about opening this issue in starlette-prometheus package but then I tried it with starlette-exporter as you can see in the example and it still happens. I don't know why is it reproducing with the OpenAPI view but not via curl and I don't have the knowledge to investigate this issue.

Just for clarity, the request blocks at this line:
   background_tasks.add_task(task, seconds=seconds)

No, the first request is handled correctly and fast. The second one is stuck in the OpenAPI interface and it doesnt even get to the route function. I tried both sync and async tasks.

@DoronCohen what happens if you register an async task instead of a sync one?  FastAPI says it handles both properly, but I'm wondering if that's incorrect, starlette only shows async examples.

I tried both but they both behave the same way. I tried to think what does it have to do with the OpenAPI docs view. Still a mystery to me

I have hit a similar issue, but I think this bug is actually a specific case of https://github.com/encode/starlette/issues/919. So a Starlette bug, not a FastAPI bug.

I don't use any middleware but it happens on my app too. Why does it happen?

Same problem here, with the GZipMiddleware enabled the request is blocked until the background task finishes. If I disable it it works as expected.
The curious thing is that the log shows that the request was correctly processed, so I initially assumed it was a reverse proxy problem.

Same here, could verify the issue with this code:
`from typing import Optional
import time
from fastapi import FastAPI, BackgroundTasks, Request
from fastapi.middleware.gzip import GZipMiddleware
app = FastAPI()
def lol():
import time
time.sleep(15)
app.add_middleware(GZipMiddleware, minimum_size=1000)
@app.middleware("http")
async def add_process_time_header(request: Request, call_next):
start_time = time.time()
response = await call_next(request)
process_time = time.time() - start_time
response.headers["X-Process-Time"] = str(process_time)
return response
@app.get("/")
def read_root(background_tasks: BackgroundTasks):
background_tasks.add_task(lol)
return {"Hello": "World"}
@app.get("/items/{item_id}")
def read_item(item_id: int, q: Optional[str] = None):
return {"item_id": item_id, "q": q}`

I'm experiencing a similar issue with the elastic apm-agent-python - running a background task blocks the request that initiated it from returning. When not adding the apm middleware, the response returns immediately as expected, and the background task runs separately until it finished.

@rafalstapinski https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.run_in_executor

Same here.  Do a long task in background and start thread pool.
I am wondering the thread run in the long task is handing request too.

Is there a workaround for this? I am hitting the same issue.

has anyone had any luck with this? i'm experiencing the same thing, feels like quite an essential part of background tasks that it shouldn't block requests

It is related to https://github.com/encode/starlette/issues/919, for workaround you can use a custom handler.

@ycd that seems to relate to apps that use middleware extending BaseHTTPMiddleware and to my knowledge my app isn't using that:
(Pdb) app.middleware_stack
<starlette.middleware.errors.ServerErrorMiddleware object at 0x1095e3970> # ServerErrorMiddleware doesn't extend BaseHTTPMiddleware
(Pdb) app.user_middleware
[]

seems like my issue was actually due to my database. tried using postgres instead of sqlite and it worked fine

Same here, any updates?


How to configure the app and Ingress with different base path

Describe the bug
When installing WEGO with the Helm chart, I want to expose the WebUI for local development and testing via an ingress under a different path than / (e.g.: /wego).
Currently, as far as I can see, there is no parameter or ENV var exposed to configure the application to make use of it. The only thing that is possible, is to configure the ingress resource via the Helm chart, which does not function when set to something different than /.
Also figured out, that there is actually a path parameter for the application that seems to be dead code. One can start the app with, for example, --path=/wego with no effect at all (see: cmd/gitops-server/cmd/cmd.go#L84).
Some other Helm charts correctly configure the application and ingress by allowing the user to change the path and route prefix. This is something I did in my local cluster with, for example, the kube-prometheus-stack and it is working as expected (apps are reachable via the ingress). This can be achieved by setting prometheus.prometheusSpec.routePrefix and prometheus.ingress.paths.
Environment

Operating System: MacOS 12.4
Weave-Gitops Helm chart version: 2.2.5
Weave-Gitops app version: v0.9.1
Flux Version: 0.31.5
Kubernetes: v1.21.12 (kind, running local)
Kong (for ingress): 2.8

To Reproduce
Steps to reproduce the behavior:

have a local Kind cluster running with Kong as ingress controller
get the Helm chartshelm repo add weave https://helm.gitops.weave.works
helm repo update weave

deploy WEGO with the helm charthelm upgrade weaveworks-gitops weave/weave-gitops \
  --install \
  -n flux-system \
  -f values.yaml  # see the values that were used below in "Additional Context"

verify the app is runningkubectl get deploy -n flux-system -l='app.kubernetes.io/name=weave-gitops'

try to open the website in a browser or use curlcurl -I http://localhost/wego

wait for the backend timeout (with HTTP/1.1 504 Gateway Time-out).
now try it with port-forwarding and do the curl again (expected response HTTP/1.1 200 OK)kubectl port-forward service/weaveworks-gitops-weave-gitops -n flux-system 9001:9001
curl -I http://localhost:9001/wego

Expected behavior
When ingress path is set to /wego the website should be reachable.
Actual Behavior
The website is not reachable and the requests time out.
Additional Context (screenshots, logs, etc)
Values used to deploy WEGO via the Helm chart:
adminUser:
  create: true
  username: admin
  # htpasswd -bnBC 10 "" 'CHANGEME' | tr -d ':\n' | sed 's/$2y/$2a/'
  passwordHash: <use the result from the command above>
ingress:
  enabled: true
  className: kong
  hosts:
  - host: localhost
    paths:
    - path: /wego
      pathType: ImplementationSpecific

Alternative values used (with annotations for Kong to modify the requests):
adminUser:
  create: true
  username: admin
  # htpasswd -bnBC 10 "" 'CHANGEME' | tr -d ':\n' | sed 's/$2y/$2a/'
  passwordHash: <use the result from the command above>
ingress:
  enabled: true
  annotations:
    konghq.com/preserve-host: "true"
    konghq.com/strip-path: "true"
  className: kong
  hosts:
  - host: localhost
    paths:
    - path: /wego
      pathType: ImplementationSpecific

Just ran into this issue when setting up the dashboard under a subpath too. Are there any plans to prioritize fixing the issue?
Happy to help contribute if it's a relatively straightforward solution and if I could get some code pointers.

Is there an update on this?

@kaybinwang thank you for your offer of help!
Unfortunately, this issue is not straightforward because of the way the app is currently set up. We researched this issue earlier: configuring the backend part is not a problem, the issue is that the frontend is generated as static files and is not configurable enough to make "the app and Ingress with different base path" with the current app setup.
So, this issue will require more bandwidth for deeper research and a major rework, which we don't have right now. We'll get back to it when we have more bandwidth. We know that our users are interested in this functionality, and we keep this in our priority backlog.

Waiting eagerly for this new feature.
Still can't provide access to my users from the internet.
They have to port-forward.

New ask from the community: https://weave-community.slack.com/archives/C0248LVC719/p1693487267920289

Based on what I researched for this issue long ago (If nothing has changed drastically while I was away), there are technical issues with the current OSS setup which prevent it from configuring basepath dynamically.
I do not remember many details, because it was long ago and I had just started working on the product then. @ozamosi helped me with the research. But I remember that configuring backend for this was not a problem. The issue was with frontend generated as a set of static files with hardcoded paths. And it was impossible to change the paths for some reason without a major rework.
So, the current issue was put on hold while a major rework to simplify cross-product development process was being discussed and then with the new product setup we were going to revisit the issue.
I am not sure what the current state on merging the repos is, I bet there are other priorities.

I would guess to fix this we'd have to address:

some runtime config declaring the subpath

perhaps this would have to be injected into the returned index.html from some BE config?
Perhaps just setting a <base /> tag?
I've seen a trick where an ingress controller can also inject a <base /> tag too.

api service: write some new injector to add this subpath as a prefix to each request
<BrowserRouter /> add a basepath prop
Figure out how to get parcel (the FE build tool) to dynamically load assets from a subpath. From searching the parcel repo and @opudrovs' comment above, this seems to be the tricky bit.

Looks like building with parcel --public-url ./ will make the css/js assets relative.
Combined with a <base href="foo/" /> tag this should work.
From https://github.com/parcel-bundler/parcel/issues/9092 parcel injects some assets (link:css from my testing) at the very top of <head> before the base tag, so can't really use that.
But if we injected a <base /> tag ourselves in the static file handler in the golang code that would be a workaround..

Also if anyone knows of other prior art here that would be interesting, e.g. can kube-dashboard / prometheus' UI / others? be configured under subpath?

@foot Thanks for taking the initiative!
I am willing to take any solution, however I think from the user's perspective it is the "usual" and convenient way maybe to handle the subpath configuration in the application and ingress configuration. In my experience normal configuration procedure in this scenario is:
a) let the application know the subpath it is being hosted under in some way (examples below)
b) configure ingress object (path, maybe add rewrite if required for application)
Examples:
Grafana has these options (in the helm chart):
grafana.ini:
  server:
    domain: monitoring.example.com
    root_url: "%(protocol)s://%(domain)s/grafana"
    serve_from_sub_path: true
ingress:
  enabled: true
  hosts:
    - "monitoring.example.com"
  path: "/grafana"

or kube-prometheus-stack using the routePrefix swtitches
## Prefix used to register routes, overriding externalUrl route.
## Useful for proxies that rewrite URLs.
##
routePrefix: /

From the PR it looks as if you are aiming to solve it another way with the headers alone. This may be dependent on individual ingress controller header support but I may be wrong about that.
Just thinking that the users expectation may be different in terms of configuring subpaths ... but feel free to ignore this remark.

From the PR it looks as if you are aiming to solve it another way with the headers alone. This may be dependent on individual ingress controller header support but I may be wrong about that.

Yeah indeed, I've been thinking about it too and we wanna support all the ingress controllers.
I will change the code so we can work with a standard PrefixPath ingress resource.

Add some --route-prefix
Add some redirect at / to redirect to --route-prefix for when you're port-forwarding
Add the /health under the route-prefix or keep it on the root? 🤔 both? What does prom do?

additionalArgs:
  - --route-prefix=/foo/

ingress:
  enabled: true
  hosts:
  - host: ""
    paths:
      - path: /foo
        pathType: Prefix

Kind of thing?


fix, not click same page

@BlackMix Thanks for PR but what's the issue ? Pagination emits the events but if the value is the same doesn't happen; anyway we could add that if check.
Howeverdisabled  attribute to pagionation link change the style and that's no good.

u can remove disabled, my bad
But I tested and last time I could to click in same page e sent request for api
I need to do it
thx


Scrollbar appears on DIV with 100% height

@gromo
As you can see in the screenshot,

the scrollbar will also appear on DIVs where no scrollbar is necessary, e.g. on 100% height DIVs.
Also the scrollbar seems not to update correctly, as you can see here:

How to avoid that?
I would like to try to update the plugin automatically or just remove and reinitialize it, but unfortunately you have not documented such parts...

Can you provide an example on jsFiddle.net?
There are 2 moments to check first:

Did you apply styles (height:100% and others) by class and not by id?
Did you try to disable scrollbar initialization and look at default browser's scrollbar behavior?

If both moments are done correctly (styles applied by class and native browser scrollbar behavior is what you expect) prepare example on jsFiddle or send me archive with HTML/CSS/JS to look at.
By default scrollbar is updated automatically when content/container size is changed (if you didn't set option "autoUpdate" to false). But if you need to reinitialize it manually, just call scrollbar initialization on your container again without options. Plugin is smart enough to skip custom scrollbar initialization on element that was already initialized - it will just recalculate scrollbar sizes.

Thanks for the reply.

Yes, I apply all styles to a class, not to a ID. The class is "panel-inner". I renamed the classname from macosx-style to it. But why is that a problem?
I can try this, but I don't  think that a browser scrollbar will appear if the height ist 100% like the window and overflow:auto is set

Ok, I already checked to call the plugin again with the stack of elements for the scrollbar before your answer. Unfortunately that didn't help. The look remains like image 2 of my first post

Напишу сюда, так как, судя по всему относится это к текущему топику.
Суть в следующем. Цссы для скроллбара у меня подключены свои.
Когда дело доходит до скролла в скролле, появляется странный баг. А именно:
Когда ставишь классу, на который вешается скролл по умолчанию overflow: auto (для мобильников например, где нету скроллов шириной 17 пикселей, чтобы корректно отображалось)
В цссе для скроллбара для класса scroll-wrapper поставлено свойство overflow: hidden !important;
для класса scroll-content поставлено свойство overflow: scroll !important;.
Соответственно overflow: auto может появиться только в том случае, если скроллбар не инициализирован.
Но когда имеется свойство на классе, на который я инициализирую скроллбар, будь то overflow: auto или overflow: scroll случается то, что внешний скролл делается видимым, по непонятной причине.
Здесь я выделил внутренний скролл розовым цветом http://jsfiddle.net/AZ6CZ/12/
Если же закомментировать overflow: auto / overflow: scroll на диве, на который активируется скролл, то всё вроде как становится на места. Но при этом не инициализируя скролл, всё идёт через оверфлоу визибл, как это задаётся всеми браузерами по умолчанию
http://jsfiddle.net/AZ6CZ/13/
Не могу понять причину такого поведения

I don't speak Russian or Ukrainian. Please write in English

@julmot Please prepare example on jsFiddle.net as Evangeline-Rei did.

@gromo Unfortunately I don't get the fiddle to show the bug. However, this is my situation: http://jsfiddle.net/rdr0xpsh/ . Can you give me tips what I should check so that I can maybe debug it myself? I can't post my whole project since it is proprietary for a customer...

Look at http://jsfiddle.net/rdr0xpsh/1/ - it works correctly.
Before debugging do not initialize plugin and look at native browser scrollbar behavior - it should be the same as you expected from custom scroll. In your example it won't be so as you set 'overflow' option to 'hidden' - change it to 'auto'
The way I debug plugin:

change debug variable value to true - it allows avoid infinity loop if you fuck up with the code
console.log(s) after section "// calculate init sizes" to see original container height/width
console.log(s) after $.each(s, updateScroll); to see current height/width that were set to content/container

That's all.

As I already said I don't get the fiddle to show the bug. The fiddle is just to show my environment. I thought maybe you can determine any mistake that could create that bug.
Thank you for this tips. I'll keep them in mind and try to debug my issue.

Unfortunately I can't debug the issue. I set the overflow property to auto so that I see the browser default scrollbar. It works great without the plugin. After initializing the plugin I get the already known problems. Also if I remove the complete HTML-DOM-Nodes inside the content of the panel-inner (in your example called maxosx-scrollbar or something like that) the scrollbar will not refresh. Instead it will look like screenshot 2 (small scrollbar even when no content is displayed).
As you can see panel-inner is empty:

I also added the console.log(s) things at the places you told me. At the time when the scrollbar will not refreshed it will also not log any object. The last object that has been logged before the error occured was:

So unfortunately I'm at the startpoint now.
Any other options? Maybe a TeamViewer session would solve the issue.

Your content is moved to DIV with class scroll-content as I see from screenshot, and it has height applied. So, everything looks correct from my point of view according HTML DOM structure. I can't tell more without source codes of your page. I don't need entire application, just one page that you can save right from your browser.

All inline styles are made by your plugin.
However, would it be helpful to offer a remote session? Because of copyright issues I can't post the source code of the application since it is a application for a customer. And as you could see in the fiddle a simulated problem will not work.

Send me email with remote session credentials to<EMAIL_ADDRESS>with date/time/timezone you will be available. I will try to allocate some time for you.

Just send you a email :)

Hello together,
I've had a remote session with @gromo today. He had a very important tip for that issue. On the scroll-element the style attribute with display:block; was created from a script. The scrollbar plugin will never create such style attributes. It will show and hide the scrollbar with CSS classes. That means, that it is a script from my application that shows/hides the scrollbar in the wrong situations and therefore the scrollbar will appear not correctly.
I found out which script is responsible for this behaviour. It is a script that shows/hides navigation items (like a DropDown where the scrollbar should appear if there is not enough space). Unfortunately the developer who created the script (another guy in my company) selected all elements including div-elements from the scrollbar to hide/show. The correct way would be only to select the list-elements from the DropDown.
I'm sorry for creating this issue since it was a problem from the environment, not from the plugin. Also I want to thank @gromo for helping me with this remote session. Many thanks!!


css: Fix unread marker leaking through message header.

before:

after:

Reproducer: This can happen at a random zoom level for you, or you can decrease the left position of .unread_marker to see it.
discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/unread.20marker.20spilling.20out

@timabbott Let me know if you need me to test this.

Looks great, merged, thanks @amanagr!


Fix invalid value for rel attribute

There is a typo in the previous_and_next_navigation component as the "previous" link has an invalid link type.
This corrects rel="previous" to the correct rel="prev".

Good catch! It looks like we've got this problem in a few other places too:
https://github.com/search?q=user%3Aalphagov+rel%3D"previous"&type=Code&utf8=✓


Feature: Add openfinex-cloud client

[ ] Drop config table
[ ] Rename to opendax-cloud
[ ] Rename opendax to ow-hdwallet


VisualizationConfig

Needs :

[x] Parser in VizConfig
[x] In Config.java - Adding VizConfig to switch-case
[x] Test Adding something to cineast.json

Implemented


Add example of chaining Results using verbose or backpassing syntax

The example parses strings such as "John Lennon was born in 1940" to extract the first name, last name, and birth year. It does so first in a verbose manner, using nested with blocks, and then uses backpassing instead, which of course is much shorter & cleaner. I also included two commented out functions showing what the upcoming ? operator will look like.
As I'm quite new to Roc, please let me know if any of this is wrong or not idiomatic, I'm happy to make changes if needed.

Thanks for all the great feedback!
I'll do this today.

Done! As you suggested:

Replaced Str.split with Str.splitFirst
Removed toPair which is not needed anymore
Removed the backpassing examples and replaced them with regular Result.try using lambdas
Cleaned up the code and comments, in particular the ? operator examples.

I can't wait for the ? operator, it will make Roc code even nicer! 👍

I had forgotten to run roc format main.roc, so I just did that.
Oddly, the tests fail on spawn ./examples/Arithmetic/main 20 4, but this PR doesn't touch that so I'm confused.

Oddly, the tests fail on spawn ./examples/Arithmetic/main 20 4,

I'll check that out

The failure is a segmentation fault.
I wanted to check it out with valgrind but it does not recognize an instruction:
❯ valgrind ./examples/Arithmetic/main 20 4
==9642== Memcheck, a memory error detector
==9642== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al.
==9642== Using Valgrind-3.22.0 and LibVEX; rerun with -h for copyright info
==9642== Command: ./examples/Arithmetic/main 20 4
==9642==
vex amd64->IR: unhandled instruction bytes: 0xF4 0x8A 0x4F 0xFD 0xF 0xB7 0x57 0xFE 0x41 0x89
vex amd64->IR:   REX=0 REX.W=0 REX.R=0 REX.X=0 REX.B=0
vex amd64->IR:   VEX=0 VEX.L=0 VEX.nVVVV=0x0 ESC=NONE
vex amd64->IR:   PFX.66=0 PFX.F2=0 PFX.F3=0
==9642== valgrind: Unrecognised instruction at address 0x2a7fd3.
==9642==    at 0x2A7FD3: ??? (in /home/username/gitrepos/forks/ageron/roc-examples/examples/Arithmetic/main)
==9642==    by 0x2A83B0: ??? (in /home/username/gitrepos/forks/ageron/roc-examples/examples/Arithmetic/main)
==9642==    by 0x3: ???
==9642==    by 0x480425F: ???
==9642==    by 0x7FFFFFFFFFFFFFFF: ???
==9642==    by 0x480461F: ???
==9642==    by 0x2: ???
==9642==    by 0x2AC232: ??? (in /home/username/gitrepos/forks/ageron/roc-examples/examples/Arithmetic/main)
==9642==    by 0x2A7845: ??? (in /home/username/gitrepos/forks/ageron/roc-examples/examples/Arithmetic/main)
==9642==    by 0x1FFEFFF8DF: ???
==9642==    by 0x2: ???
==9642==    by 0x34BC73: ??? (in /home/username/gitrepos/forks/ageron/roc-examples/examples/Arithmetic/main)
==9642== Your program just tried to execute an instruction that Valgrind
==9642== did not recognise.  There are two possible reasons for this.
==9642== 1. Your program has a bug and erroneously jumped to a non-code
==9642==    location.  If you are running Memcheck and you just saw a
==9642==    warning about a bad jump, it's probably your program's fault.
==9642== 2. The instruction is legitimate but Valgrind doesn't handle it,
==9642==    i.e. it's Valgrind's fault.  If you think this is the case or
==9642==    you are not sure, please let us know and we'll try to fix it.
==9642== Either way, Valgrind will now raise a SIGILL signal which will
==9642== probably kill your program.
==9642==
==9642== Process terminating with default action of signal 4 (SIGILL)
==9642==  Illegal opcode at address 0x2A7FD3

I tried several ways to figure out the actual instruction but failed, can you give me tip here @bhansconnect?

I would open it up in objdump and jump to those instructions. See what it says. Is Val grind somehow in the middle of an instruction. Are those bytes garbage. Other.

The arithmetic example runs fine with basic-cli 0.13 so I'm just going to focus on #192.
I've attached my attempts to view the unrecognized instruction just in case we need it in the future:
unrecognised_instruction.txt

https://github.com/roc-lang/examples/pull/203 needs to be merged in first to resolve the expected checks.

A new operator ? (the "try" operator) will soon be added to the language

? is here now, we should update this before merging

I'll update this PR today 👍


[fastlane_core] Add support for platform detection for refresher service

This is used to get a feeling of how many people use fastlane with iOS or with Android projects. The data is being sent to refresher

👍


[Bug Report]

Describe the bug
Error being thrown when trying to open the AnvilUI during backpack deletion.
Versions (please complete the following information):

Minecraft Server Version: 1.21
Plugin Version: v2.2.2

Pastebin any errors in console
Link: https://pastebin.com/Uc0wTB3M
Issue
Everything else works fine, but when I go to remove a backpack, it tries to, the UI where you pick the backpack to remove flashes and the error in the pastebin gets thrown in the server console. Java is not my area at all so I can't make much sense of it.
Screenshots
Can provide if needed, unsure of what to show.

I dont have planed to solve this issue for now. I'm too busy to work on my minecraft plugins.
If you want to use this plugin you can compile the code, just use the geyser-experimental branch.
If you have no idea then add me on discord and i can provide you with the .jar file


test(abg): exercise JAR mode for all typings

#1335  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @krzema12 and the rest of your teammates on  Graphite


Switched broken pypip.in badges to shields.io

Hello, this is an auto-generated Pull Request. (Feedback?)
Some time ago, pypip.in shut down. This broke the badges for a bunch of repositories, including ribbon. Thankfully, an equivalent service is run by shields.io. This pull request changes the badges to use shields.io instead.
Unfortunately, PyPI has removed download statistics from their API, which means that even the shields.io "download count" badges are broken (they display "no longer available". See this). So those badges should really be removed entirely. Since this is an automated process (and trying to automatically remove the badges from READMEs can be tricky), this pull request just replaces the URL with the shields.io syntax.

Coverage remained the same at ?% when pulling 003c54f7a6a07499e5719f3632151da6dfb50969 on movermeyer:fix_badges into b6de3f4ec0da51adb3cd029bd2aa530b6bee2ad1 on hanks:master.


bug(playground): model being download is listed in the usable one

cc @feloy

Fixed by https://github.com/projectatomic/ai-studio/pull/676


list Field with min_length and default_factory does not validate min_length

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
I created a model where I have a field of type list[SomeOtherModel]. I want to enforce that a list is provided with at least one element and defined it as some_field_list: list[SomeOtherModel] = Field(default_factory=list, min_length=1).
However, the min_length is not validated. Only when I remove the default_factory argument.
Having thought a bit about it I think that this makes sense but it was not immediately obvious. If this is as intended, would it be worth mentioning this in the docs?
Example Code
from pydantic import BaseModel, Field

class TestModel(BaseModel):
    some_list: list[str] = Field(default_factory=list, min_length=1)

TestModel.model_validate({})

Python, Pydantic & OS Version
pydantic version: 2.9.2
        pydantic-core version: 2.23.4
          pydantic-core build: profile=release pgo=false
                 install path: /path/to/.venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.10 (main, Sep  7 2024, 01:03:31) [Clang 15.0.0 (clang-15<IP_ADDRESS>.5)]
                     platform: macOS-13.7-arm64-arm-64bit
             related packages: mypy-1.13.0 typing_extensions-4.12.2
                       commit: unknown

Hi @mschoettle,
You can use the validate_default setting to get the expected behavior here:
from pydantic import BaseModel, Field

class TestModel(BaseModel):
    some_list: list[str] = Field(default_factory=list, min_length=1, validate_default=True)

TestModel.model_validate({})
"""
pydantic_core._pydantic_core.ValidationError: 1 validation error for TestModel
some_list
  List should have at least 1 item after validation, not 0 [type=too_short, input_value=[], input_type=list]
    For further information visit https://errors.pydantic.dev/2.10/v/too_shor
"""


fix: workaround compute log display issues

Summary
Simple workaround to introduce a newline at the end of the postamble to ensure that the last bit of log displays properly in the given error scenario. We'll be following up internally with the compute api team to understand why this is required.
Testing
Sample program from #963 for 9x and Viya connections.

The issue was fixed. Log contents can be fully shown on output log panel with Viya connection.


Remove usages of assert within common-utils

I should have done this yesterday, but it's clear that common-utils has a few usages of assert that will be problematic. Removing these usages since there is a bit of friction doing package bumps.

I keep using the wrong branch!!!!


I had a problem adding a swagger to the ocelot gateway

Pictured above,How can I set curl on the swagger to make it look like the following figure？

Thanks

Consolidated into #1953

Consolidated into #1953


mark spl as broken spl on kernel 4.7 or higher

#18209
@shlevy this commit didn't apply cleanly. would marking it broken this way be ok?

Would be nicer with lib.versionOlder

lib.versionOlder actually also accepts versions that are equal. should i fix lib.versionOlder to use != -1 then?

Ah, versionAtLeast seems to be the one (though note arg order)

used verisionAtLeast and tested on my setup since i can not use kernel>=4.7 due to zfs/spl


Add custom manager to match pip install commands in CI

Codecov Report

Merging #609 (78b0553) into main (e428b78) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   97.50%   97.50%
=======================================
  Files           6        6
  Lines         400      400
  Branches       80       80
=======================================
  Hits          390      390
  Misses          8        8
  Partials        2        2


how to update options during interaction, how to stop interaction?

Hello,
at first, thanks a lot for this wonderful contribution: for quite a while, I thought about implementing s.th. similar myself - but always withdrew that idea because of the foreseeable effort.
But now, everything I had to do was to write a trivial wrapper around your module in order to use it with Svelte.
However, that work raised a few questions, two of them are:

is it possible to update the initially given options while an interaction is ongoing? (e.g., the "containment" of a "draggable")
is it possible to stop (i.e. abort) an ongoing interaction? (e.g. an ongoing drag-and-drop operation by means of the ESC key)

Thanks in advance for your effort!
Kind regards,
Andreas Rozek

Hello @rozek
Sorry for the delayed answer. Very glad to know that you liked the work done here.
About updating options during interaction, my initial assumption is that is possible. Need to perform tests though.
About aborting an ongoing interaction, this is one of the many behaviours that jQuery UI already had and should be available in agnostic-draggable as well. Also needs test to confirm, but I'm almost sure stopping/cancelling on the fly is perfectly possible.


Development workflow seems broken

The expected workflow:

git clone
Select Node.js version that the project expects
npm install --global npm
npm install
npm test

Fails.
I would say that this issue depends on

[ ] #422
[ ] #424
[ ] #426
[ ] #322

@mightyiam , seems like all four issues are fixed ATM...

Thank you, @kuraga. Yes, but there is #460.


Add Support for PLC Structured Text Language (IEC 61131-3)

Description:
I would like to request the addition of PLC Structured Text (ST) language support in GitHub. This language, which is part of the IEC 61131-3 standard for programming industrial automation systems, is widely used in PLC programming for developing control logic in various industries.
Why is this important?

Industry Usage: Structured Text is a key language in industrial automation, control systems, and machine programming, where it is used for complex logic and algorithms. Despite its extensive use in industrial applications, GitHub currently lacks native support for Structured Text syntax highlighting, making it harder for developers to share and collaborate on code.

Consistency with IEC 61131-3: Structured Text is a standardized language under the IEC 61131-3 framework, which ensures that it follows a clear and structured syntax. Adding support for this language would align with GitHub’s goal of supporting a wide variety of languages, especially those that adhere to international standards.

Improved Developer Experience: Implementing syntax highlighting and language recognition for Structured Text would significantly improve the readability of code and collaboration on projects that involve PLC programming, especially for those working in automation and manufacturing sectors.

Suggested Features:

Syntax highlighting for Structured Text files, with typical extensions like .st, .scl, .exp.
Language recognition based on keywords and syntax defined in the IEC 61131-3 standard.

Thank you for considering this request. The inclusion of Structured Text would be beneficial to a wide range of developers working in industrial and automation-related fields.

Can you please update your request to use the template that was there and fill in all the fields. The point of these issues is to offer people the opportunity to contribute to the project where the authors of the issues are not in a position to contribute a PR themselves. This is why we ask for a link to a grammar that supports the language you're requesting.

This is a duplicate of Issue #6472.

You said something I've always wanted to say，I was looking for a software that would support this language, after all, a lot of code had to be written down。

I found a TextMate grammar for PLC Structured Text: https://github.com/msftrncs/vscode-st/blob/symbolprovider_ideas/syntaxes/st.tmLanguage.json

Hello, I can't find any PLC examples that are in plain text format and not visual images.
Can you provide some?

These files are exported from Siemens TIA Portal with the SCL format. I had to rename them to *.txt since *.scl was unsupported for uploading..
Festo_PtP_Drives_PN_v1_2.txt
LSitop_PseDiag.txt

Any sample added to a PR needs to be locatable on GitHub with a clear license covering the source.

Alright, here is a few repos with SCL code:
https://github.com/OttoMeister/Siemens-Tia-Portal-PID-Controller
https://github.com/ChristofGroschke/MQTT-Siemens-S7-1500
https://github.com/d-ani/SCL-UnitTesting
Any SCL or UDT files within these repos are examples in plain text.


when load the MNIST, the NoneType error occured

I follow the tutorial load the "torchvision MNIST", the NoneType  error occured

See this: https://github.com/TorchStudio/torchstudio/issues/1
If you haven't already please download the latest version (0.9.3) and install it, then launch TorchStudio, click **Menu > Settings...*, click Reset Local Python Environment, restart TorchStudio, and click Install.

Thank you for the reply. It is indeed caused by env problem.
But I'm going to collapse, the anaconda, all utils pkg, env path have been deleted 0.0

possible solution
tuple: (image, target) where target is index of the target class."""
def init(self, root: str, train: bool = True, transform: typing.Optional[typing.Callable] = None, target_transform: typing.Optional[typing.Callable] = None, download: bool = False):
super().init(root, train, transform, target_transform, download)


PDY-1121 Java Sample Accelerator should include files for creating a fat jar

Can we add in the https://github.com/sample-accelerators/java-functions-accelerator/blob/main/DEPLOYING.md file how we can build fat jars?

@joeeltgroth @dolfolife looks like this went stale, can we get it tested and merged?


Cross platform?

Sorry, it took a long time to reply. Frm the beginning I wanted to create crossplatform library. That is why I stopped developing a termbox branch with full-mouse support.  In the beginning demos worked good on Windows and Ubuntu. I need to check the latest code and fix if it does not work.

Yes, it has some trouble in Ubuntu. Will fix it.


Install a Config.cmake file

Hi,
we are combining a couple of ROCm libraries in U.S. Exascale Computing Project libraries and applications.
We would like to include roctracer in ECP AMReX and dependent applications. To make this inclusion via CMake easier, would it be possible to add and install CMake *config.cmake files on install for roctracer?
The workflow we would prefer would export the roctracer CMake targets via such a file for simpler inclusion, similar as we do with rocprim & rocrand/hiprand:
https://github.com/AMReX-Codes/amrex/blob/db8e47927065fcf283f6aae631f91a07b222876b/Tools/CMake/AMReXParallelBackends.cmake#L210-L213
ROCm CMake package ref:
https://rocmdocs.amd.com/en/latest/Installation_Guide/Using-CMake-with-AMD-ROCm.html#rocm-cmake-packages

Hi, is anyone working on this problem already? :)

Hi, I am still interested in making roctracer usage from CMake less awkward :)
https://github.com/AMReX-Codes/amrex/blob/f270b3d5db8f8b7ab010bc9134632361b8a9009c/Tools/CMake/AMReXParallelBackends.cmake#L251-L261

Hi @ax3l -- I can confirm there is a ticket (and work internally) at AMD for this, if you'd like I'd be happy to mirror this to the ORNL JIRA for tracking.

Hi @arghdos, thank you, much appreciated.

Just tagging along, since we are interested in a clean roctx integration as well. In the meantime, I added a Find module which does essentially the same thing

+1 - would be nice to have this support for packages like ExaGO / Re::Solve as even if we have a dependency expressed in our package.py, we cannot consume the installed version without quite a hack

+1 It would be good to have CMake.config for ROC Tracer so it can be linked to in the same way as most of the other ROCm packages.

This is something that is needed for PyTorch as well and is not present in ROCm 6.2. The CMake module should include proper IMPORTED targets as well.

Hi @ax3l @naromero77amd @pelesh @cameronrutherford @upsj just wanted to provide an update here. We have pretty much stopped development on roctracer, rocprofiler, and rocprofiler v2. We designed a new profiling library from scratch called rocprofiler-sdk and did a beta release in ROCm 6.2. It is dramatically improved over the previous iterations. The API is relatively stable at this point and we’ve done hackathons with several tools at this point (TAU, Caliper, HPCToolkit, Linaro Map, CrayPAT) and I believe y’all will be as happy with our new direction as they were. Y’all will be please to hear that
find_package(rocprofiler-sdk)
find_package(rocprofiler-sdk-roctx)

are fully supported with namespaced imported interface CMake targets. We are distributing a new ROCTx for various reasons: the old ROCTx couldn’t be separated from roctracer without breaking existing codes, you couldn’t install the old ROCTx without installing roctracer, etc. so this new ROCTx is designed to be standalone (in addition to adding new functions such as roctxProfilerPause and roctxProfilerResume).
We encourage all of y’all to transition to using the new APIs sooner rather than later and if y’all need a consult on the transition, please let me know and we can set something up.

Thanks @jrmadsen for the quick reply. I found a buglet and hope the it can be that it will not be too much work to address:
https://github.com/ROCm/rocprofiler-sdk/issues/21

Thanks, @jrmadsen! I created an issue at Re::Solve repository, and we will start transition.

@jrmadsen Hoping you can clarify this questions or point us to the relevant documentation.
Is librocprofiler-sdk-roctx.so compatible with libroctracer64.so?
As an initial step in the transition, I only included rocprofiler-sdk-roctx package and the associated imported target:
rocprofiler-sdk-roctx::rocprofiler-sdk-roctx

To my surprise, it seems to automagically work in PyTorch.
I am still seeing libroctracer64.so linked in -- perhaps because I didn't explicitly add the rocprofiler-sdk package (nor the imported target rocprofiler-sdk::rocprofiler-sdk).

@jrmadsen Hoping you can clarify this questions or point us to the relevant documentation.

I’ve been asking our docs team to take care of this for a while. There aren’t docs posted yet unfortunately.

Is librocprofiler-sdk-roctx.so compatible with libroctracer64.so?

No. The ROCTx implementation differs and roctracer will attempt to use the old method to talk to ROCTx, which isn’t supported in the new ROCTx. Unless it got backported without my knowledge, which I’d be very surprised to hear, but I also really only concern myself with the new library and leave other people to manage our legacy tool libraries.

As an initial step in the transition, I only included rocprofiler-sdk-roctx package and the associated imported target:
rocprofiler-sdk-roctx::rocprofiler-sdk-roctx

To my surprise, it seems to automagically work in PyTorch.

I’m surprised myself if I am understanding you correctly. You just did a find_package and didn’t add it to the target_link_libraries(…) of anything?
If you mean you did the find_package and used the interface target, I am not surprised. It was probably able to find the <roctracer/roctx.h> from the include path from HIP or the roctracer target and the symbols were resolved by the rocprofiler-sdk-roctx library when linking.

I am still seeing libroctracer64.so linked in -- perhaps because I didn't explicitly add the rocprofiler-sdk package (nor the imported target rocprofiler-sdk::rocprofiler-sdk).

Yeah, you are likely linking to roctracer somewhere. Just FYI, supporting roctracer and rocprofiler-sdk in the same build is not recommended. We’ve successfully used the new rocprofv3 (built on rocprofiler-sdk) on PyTorch applications which contain roctracer, but I highly suspect that roctracer is going to have problems with anything HSA related when a rocprofiler-sdk tool is present. In other words, we haven’t seen any problems with rocprofiler-sdk when roctracer is present but we haven’t delved into how well roctracer works when rocprofiler-sdk is present.

Well, for clarity, the rocprofiler-sdk docs are here: https://rocm.docs.amd.com/projects/rocprofiler-sdk/en/latest/
I was referring to the rocprofiler-sdk-roctx docs being presently missing.

So to clarify, when just using roctxRangePush/Pop, the only thing I would need to change to move from roctracer to rocprofiler-sdk-roctx is the target I'm linking against and the include path?

So to clarify, when just using roctxRangePush/Pop, the only thing I would need to change to move from roctracer to rocprofiler-sdk-roctx is the target I'm linking against and the include path?

Yes, the function signatures of roctxRangePush/Pop in rocprofiler-sdk-roctx are identical to the ones provided by the roctracer roctx.
#include <roctracer/roctx.h> --> #include <rocprofiler-sdk-roctx/roctx.h>
and
libroctx64.so --> librocprofiler-sdk-roctx.so


[0.4.0] Upgrade to dbt v0.20

(same basic story as https://github.com/fivetran/dbt_hubspot_source/pull/46)
Are you a current Fivetran customer?
Jeremy Cohen, dbt Labs, yes!
What change(s) does this PR introduce?

Require fivetran_utils: [">=0.2.0", "<0.3.0"]. Lower + upper since you have full control over this package, and can release it whenever you need.
Require dbt >= 0.20.0. Just a lower bound because we can rely on dbt_utils (via fivetran_utils) to hold the upper dbt bound for us.
Bump project version (cosmetic only)
Bump dbt version in integration tests, and remove dbt version requirement from integration tests dbt_project.yml — this will just use the dbt version requirement in the packages it depends on

Does this PR introduce a breaking change?

[x] Yes (please provide breaking change details below.)
[ ] No  (please provide explanation how the change is non breaking below.)

Is this PR in response to a previously created Issue

[ ] Yes, Issue [link issue number here]
[x] No

How did you test the PR changes?

[ ] CircleCi
[ ] Other (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

[ ] BigQuery
[ ] Redshift
[ ] Snowflake
[x] Postgres
[ ] Databricks
[ ] Other (provide details below)

I ran this on Postgres, everything passed, with one tiny change: I needed to wrap quotes around the default column in brand_data, since default is a reserved word in Postgres.
dbt deps
dbt seed
dbt run
dbt test

As before, happy to run against the other warehouses if you'd like. With an update like this, if the package parses/compiles/runs right on one, it ought to across the board.
Provide an emoji that best describes your current mood

🕴 🕴

I realize I accidentally included an edit to integration_tests/data/brand_data.csv that wrapped a column named default in quotes. This was needed to run integration tests on Postgres locally, but it doesn't make sense to include as part of this PR.


Smart command suggestion

Fixes #54. Typing "adr" -> "add", "storr" -> "store", etc.
TODO:

[ ] Add tests

@INCENDE @rachx Please review, thanks

Coverage increased (+0.1%) to 84.734% when pulling 11d5fc484eeb16bb3edfec456ef8fa30d853f1b7 on type-command-support into 3b3470f26ef05f433072ff4d3e60d22c43f5d18f on master.

Changes Unknown when pulling bed4c3be9f606ab03f1d3cb6a0db4487194ec289 on type-command-support into ** on master**.

Coverage increased (+0.4%) to 84.96% when pulling 76c0acf28c113df3785376da00434dde3ac721f8 on type-command-support into 20430b7f421532722319fa84cdb0473b4197d04a on master.

@fanwgwg You can help to review this also

Coverage increased (+0.1%) to 84.734% when pulling 76c0acf28c113df3785376da00434dde3ac721f8 on type-command-support into 20430b7f421532722319fa84cdb0473b4197d04a on master.


[CWS] btfhub based constants fallback

What does this PR do?
This PR implements:

a constant fetcher based on data from https://github.com/aquasecurity/btfhub-archive
a constant fetcher based on current kernel BTF

TODO:

[x] add doc comments
[x] run pahole only once per btf file (currently once per struct)
[x] compress the format of the exported json (maybe deduplicated constants + index pointing to array)
[x] add flags to extractor tool

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

Neat use of btfhub here. We should chat and map out our future plans for CO-RE/BTF. I have some ideas that might allow us to transition some things earlier rather than later.

This is a good idea, this PR also contains a constant fetcher based on CO-RE/BTF for the current kernel if available, so we get the best of both worlds


Collapsible items on sidebar alignment issue

I am making a small demo in angular 2.  I am facing issue on my sidebar  alignment gets disturbed when i add Collapsible body . Please refer Image below .
here is my code :
code.txt
The issue  i am getting is this :

Could you please provide plunker? Sharing code in txt file is not often the best practice.

@Ashwani44 does it not happen with plain MaterializeCSS ? (if you put the same code in a HTML file, which statically bring in MaterializeCSS)

Yes, when i use Plain Materialize CSS  then my layout is proper, i don't find any issue but when i use  angular2-materialize then i get above issue ,my layout of collapsible gets disturbed.
here is my code

      menuMaterialize

test1

test1

test1

dashboardDashboard

messageMessages

        peopleFriends

First

Second

Third

Fourth

Main

        Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.

My CSS
    .side-nav {
     margin-top: 64.2px !important;
     }
    #sidenav-overlay{
    position:fixed;
    top:0;
    left:0;
    right:0;
    height:120vh;
    background-color:transparent!important;
   z-index:997;
   will-change:unset;
   }

Did you finde the Problem?
I'm use plain MaterializeCSS.

Well i left using MaterializeCss as i was finding less support from
materialize as per angular 2 is concerned and i switched to angular 2
material ..i am doing good.
On 27-Aug-2017 5:49 pm, "Syndlex"<EMAIL_ADDRESS>wrote:

Did you finde the Problem?
I'm use plain MaterializeCSS.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/InfomediaLtd/angular2-materialize/issues/271#issuecomment-325194912,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APnA7pa-k3UYfBKP-UqRTZvF5SOo5iTjks5scV7ugaJpZM4NgsEv
.


Added Eager Loading

Added Eager Loading  following https://www.entityframeworktutorial.net/eager-loading-in-entity-framework.aspx.

Not needed.


Name clash with AWSSDKSwift v4.x

The AWSLambdaEvents define enum namespaces for the Events (S3, SNS, SES, SQS...). These mean you cannot use v4.x of AWSSDKSwift with swift-aws-lambda-runtime. This is partly the fault of AWSSDKSwift as in v4.x the framework name is the same as the main struct name, so you cannot differentiate between S3 in AWSSKDSwift and S3 in AWSLambdaEvents.
This is resolved with the AWSSDKSwift v5.0 alpha as the framework names have been prepended with AWS. Thus won't be an issue in the future.
I'm not sure if anything will be done about this now, given the issue will disappear in the future, but I must say using such general terms for a very specific part of a service wasn't necessarily the best idea.

@adam-fowler An

@fabianfett I would have thought removing one layer, something like this, would work
public struct SNSEvent: Decodable {
    public struct Record: Decodable {
        ...
        let sns: Message
    }
    public struct Message {
        ...
    }
}

While might not be the best solution, Swift does allow prefixing types with module names, to differentiate types (eg. AWSSKDSwift.S3 vs AWSLambdaEvents.S3). In the example above, @adam-fowler, you could use AWSLambdaEvents.SNS.Event to refer to this type.
Furthermore, Swift supports creating type aliases as needed:
typealias SNSEvent = AWSLambdaEvents.SNS.Event

Hope that helps.

@eneko unfortunately AWSSDKSwift v4.x is split into multiple libraries, one for each service, with each library named after the service. eg SNS, S3, etc. And the problem is the library's main class is also called the same name. This means to access the AWSSDKSwift S3 I would have to use S3.S3 but this confuses the compiler and it doesn't know which S3 I am talking about.
This has been resolved in the alpha of version 5.x as we have prefixed all the library names with 'AWS'.

I see, thanks for clarifying.

being able to use AWSSDKSwift together with AWSLambdaEvents is a good goal
unfortunately name clashes of this sort are bound to happen in libraries that are in similar domains until swift gets better name spacing solutions. the work mentioned above to maki it easier to disambiguate the module and main type in AWSSDKSwift is important
we could explore adding a namespace of sorts for the events/triggers defined in AWSLambdaEvents

Even having a seprarate file where you would import AWSSDKSwift only and make typealiases for that does not work? (or for AWSLambdaEvents)

Even having a seprarate file where you would import AWSSDKSwift only and make typealiases for that does not work? (or for AWSLambdaEvents)

Yes that would work, but would be a pain in the ass. I posted this issue without really thinking there was much that could be done, but to make sure issues like this were thought about for future commits. With the alpha version of AWSSDKSwift 5 this issue disappears.

@tomerd @kneekey23 Also informed me that these names might become a problem in the future. She proposed that we add an "Event" immediately after the service name like S3Event instead of namespacing like S3.Event. I guess we should revisit this before 1.0 latest.

I guess we should revisit this before 1.0 latest.

sgtm

Now that Soto 5.0.0 has been released, this issue could be closed.
Might be still a good idea to consider updating these types to avoid collisions with other frameworks or libraries.

I still would like this to be revisited and I would prefer the name spacing of S3Event to S3.Event to prevent future naming collisions with other frameworks/libraries on the horizon.

We fixed this in swift-server/swift-aws-lambda-events#2


cannot create cordova app

(node:3197) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): App id contains a reserved word, or is not a valid identifier.
(node:3197) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Also experiencing this issue on a fresh install with cordova create cordova data-center [com.example.data] [DataCenter] --template cordova-template-framework7-vue-webpack...


Only set database_file if DATABASE_URL is missing

Recently, Heroku stopped overwriting database.yml from DATABASE_URL (https://github.com/heroku/heroku-buildpack-ruby/commit/be1ac0d8c6187ae366a9bdd668f2a00d7fdd1914), so, unless your database.yml contains a spec for the environment you're deploying, it fails when trying to establish the connection. We should call database= only once, either directly or from database_file=.

Thanks! (and sorry for the wait)

Thanks! :heart:


"ambient_light_disabled" render mode in custom shader still gets ambient light contribution

Godot version
4.0.dev (e69b7083d)
System information
Manjaro Linux, NVidia 1080ti (nvidia drivers)
Issue description
When writing a custom ShaderMaterial and setting render_mode ambient_light_disabled still gets contribution from the Ambient light source.
For example I set the DIFFUSE_LIGHT output of my light function to vec3(0.0) which I would expect to render entirely black, but there is still contribution from the ambient light.
This is most easily seen with the default Sky based world environment because there are differences in the ambient light based on direction.
It seems like there is room for a feature request here as well.
That when render_mode ambient_light_disabled is set, Godot disables automatic ambient light contribution and instead adds a pass (eg if (AMBIENT_LIGHT_PASS)) like how sky shaders have multiple passes.
This would allow more flexibility on the shading.
Steps to reproduce

Open a new scene and insert a simple mesh like a Cube.
Insert the sample world environment
Create a new shader material for the cube with the following code:

shader_type spatial;
render_mode ambient_light_disabled;

void fragment() {
    ALBEDO = vec3(1.0);
}

void light() {
    DIFFUSE_LIGHT = vec3(0.0);
}

You will see that the mesh is still lit and has variations from the skybox radiance map.

Modify the world environment and set "Ambient Light" to "Color" with a black color.
This is what I would expect to see with no Ambient light contribution to the shader.

Minimal reproduction project
No response

Duplicate of https://github.com/godotengine/godot/issues/56332 (same cause).


[Feature Request] Some idea to make this tool more interesting

Hi ZhangGe,
This is  an excellent work which help me a lot during my work.
I have been looking for a good visual model modification tool, and then I found that this tool may be able to meet my expectations. So I hope to contribute to this work to make it more interesting.
Here are some points I think could make this tool more useful:

A cleaner UI. The tool's UI is not as clean as native netron's. Actually I have pushed a PR(https://github.com/ZhangGe6/onnx-modifier/pull/122) to achieve a better UI.
Support node coloring. User can change the color of selected node, this will need modification of netron.
Support selecting nodes and make some changes (delete/coloring...) to these nodes.
Support load&download of mlir model. Since MLIR has been the most popular ai compiler infrastructure, a model modification tool which can parse the IR of mlir will be very useful. I have developed some codes before to convert the mlir ir to onnx node and display it with netron, and also convert it back to mlir ir file.
Support adding a new node attribute.
Support inserting custom node.

......

I will be very glad if you are interested in my proposal. And I will be very happy to contribute to  implement these ideas. Looking forward to you reply.

Hi @Gxiandy, thanks for the inspirational suggestions and efforts! I edited the comments with proposed points as an ordered list, and want to share my opinions for them respectively.

I tried the PR locally and found that the index page gets really cleaner! But maybe the PR will not be merged, mainly for two reasons: a) As netron focuses on visualization, the UI is expected to be as clean as possible. However, onnx-modifier focuses on model editing, so the interactive buttons should be reached as conveniently as possible. To this point, "hiding" the buttons in the menu dropdown will make users have to do one more click, and may not be a good idea. b) If the buttons are hidden, the demo gif in the readme should be updated together.
Yes! This is really a good idea! It can help users mark/locate the nodes they are interested in.
Deleting the selected nodes is already supported.
Good job! As I know, mlir support is still under active development in netron project. Waiting and reusing the feature may be the right direction. In addition, to keep focusing and things simple, onnx-modifer focuses on editing ONNX only.
Editing attribute is already supported. What is the real case to ADD a new attribute?
Yes! This is exactly what the community calls for.


Fix typo in README

Hello! I was having a look at the docs here:
https://www.twilio.com/console/chat/getting-started
I noticed a grammatical error in "Create an Chat Service", which should be "Create a Chat Service".
I found it here too, so I thought I'd take a look.
Thank you in advance!

Thanks!


View/Route detection to prevent failed fetchs from backend

If you navigate to the a view or route (like the contact form) located in the root, then it tries to GET the content in the backend, and fails.

The view name will be chopped of the url and so it will fetch the content of the root to render de view (which is correct). The view name does need to be there in the helper. Maybe it's better to switch to the @@ notation in the frontend also.

I belive this is already in place, let's reopen if not:

https://github.com/plone/plone-react/blob/778e77bff4821d8d3a1f5de1d229f846101a47a6/src/helpers/Url/Url.js#L14-L36

(the example, contact form, is still not implemented but when it is we'll add to the list above)


Fix Windows Server version for RS4 in comment

My bad; inadvertently used the wrong version on this line (added in 73d28eadd65466bcb6dfd92096909ccdf1bd6ee8 / https://github.com/Microsoft/hcsshim/pull/568)

ping @stefanscherer @mat007

LGTM. Nice catch 🔍

ping @jhowardmsft @jstarks ptal


feat(Examples): Add 2048 Demo to MAX32655

Description
This PR adds the 2048 Demo which splits the task of the game between the ARM and RISC-V cores for the MAX32655.
Checklist Before Requesting Review

[ ] PR Title follows correct guidelines.
[ ] Description of changes and all other relevant information.
[ ] (Optional) Link any related GitHub issues using a keyword
[ ] (Optional) Provide info on any relevant functional testing/validation.  For API changes or significant features, this is not optional.

/clang-format-run

/clang-format-run

/clang-format-run

/clang-format-run

Fixed linter errors and outdated/unfinished comments. Moved all the semaphore/mailbox definitions, for both the RISCV and ARM core, into their separate ipc_defines.h which should match.


webkit repl right inside intellij idea?

This is an amazing project. But switching and copying/pasting code between the browser and the IDE is just tedious, why not put the repl inside the IDE? This way you can send code directly into gorilla (cmd-shift-L for loading file, cmd-shift-P for eval), and using all the editing power (paredit, autocompletion, etc) of intellij.

Thanks for the kind words! I'd also love to see better integration with IDEs like IntelliJ. I don't think it will be very easy, though, as I don't think IntelliJ supports very deep integration with Webkit. I also would want to ensure that any changes that were made did not affect the ability to run Gorilla standalone, as this is very useful for server-based usage.
I'm going to close the issue as "won't fix", just because I don't think it's really possible. But I'd love to be proven wrong with a PR :-)


Simple integer to string

Issue here
The same case for me too, I use paper_trail for tracing records, the type of item_id is one of string,
uuid, integer, and fetch them through ecto reflections, save as text type.
uuid to string is automatic well done, but integer to string blocked me.
The PR  helps  simplify similar works.

This PR seems to introduce an unexpected coercion between types. Could a custom Ecto.Type work in your case?

closed, I will patch paper_trail.


Event problem

`public event EventHandler GameFlowChanged;
private readonly TaskCompletionSource _work = new TaskCompletionSource(false);
public async Task EventExampleAsync()
{
// Initialize a connection to the league client.
var api = await LeagueClientApi.ConnectAsync();
Console.WriteLine("Connected!");
// Register game flow event.
GameFlowChanged += OnGameFlowChanged;
api.EventHandler.Subscribe("/lol-gameflow/v1/gameflow-phase", GameFlowChanged);

// Wait until work is complete.
await _work.Task;
Console.WriteLine("Done.");

}
private void OnGameFlowChanged(object sender, LeagueEvent e)
{
var result = e.Data.ToString();
var state = string.Empty;
switch (result)
{
    case "None":
        state = "main menu";
        break;
    case "Lobby":
        state = "lobby";
        break;
    case "ChampSelect":
        state = "champ select";
        break;
    case "GameStart":
        state = "game started";
        break;
    case "InProgress":
        state = "game";
        break;
    case "WaitingForStats":
        state = "waiting for stats";
        break;
    default:
        state = $"unknown state: {result}";
        break;
}

// Print new state and set work to complete.
Console.WriteLine($"Status update: Entered {state}.");
_work.SetResult(true);

}`
I see Connected, but when i switch of game, it don't print anything

Hi! I don't actively maintain this project, but I'm happy to try and help you with your problem.
Can you provide some steps that I can use to reproduce the issue? It still works for me:

Code gist link: https://gist.github.com/bryanhitc/31ab55cb808a8b7378c6bfda169e7fec


fix CLIc version in CMake

If possible:

define the CLIc version in the pom.xml
use the CLIc version from the pom into the CMakeLists.txt

Hence we control all from the pom and gather versionning tag in the pom.


No Tab indicator on register form on buttons and checkboxes

As a console user I want to be able to navigate with the keyboard and I need to see where my tab indicator is currently.
Acceptance Criteria*

[ ] I am able to see where my tab indicator is currently.
[ ] The "selected" button/link/etc. has a boarder like the main navigation

@juergrinaldi which register form do you mean? the one in the customer portal or the one on the "login" register for a new user.

customer portal. https://zitadel.cloud/
(and I just saw that I posted the issue in the wrong repository, my bad.)

@juergrinaldi can we close this? since you created another issue in the portal repo?

it's still not completely fixed in both (console & customer portal), especially the (primary) buttons.
for example:
here the primary button (Actions) is tab selected:

here it is not selected:

even though there is a slight indication on the color, it's pretty much not visible. Better would be to go the same approach as in the main menu:

Hi, I would love to work on this. hopefully, it's not too late because it seems there has not been any activity or fix to this

Hei @Deepizel
It would be great if you work on this.
I will assign you to the issue. And Thank you very much.

Hey @Deepizel Do you still work on this?

I would love to but I cant find the docs to setup the application on my
local machine
On Wed, May 1, 2024, 9:54 AM Fabi @.***> wrote:

Hey @Deepizel https://github.com/Deepizel Do you still work on this?
—
Reply to this email directly, view it on GitHub
https://github.com/zitadel/zitadel/issues/4057#issuecomment-2088173323,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXDSXQLEGGY3RTEJIAXMNVLZACUWBAVCNFSM54YV7JJ2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBYHAYTOMZTGIZQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I would love to but I cant find the docs to setup the application on my local machine
…
On Wed, May 1, 2024, 9:54 AM Fabi @.> wrote: Hey @Deepizel https://github.com/Deepizel Do you still work on this? — Reply to this email directly, view it on GitHub <#4057 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDSXQLEGGY3RTEJIAXMNVLZACUWBAVCNFSM54YV7JJ2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBYHAYTOMZTGIZQ . You are receiving this because you were mentioned.Message ID: @.>

You can find the contribution guidelines here: https://github.com/zitadel/zitadel/blob/main/CONTRIBUTING.md
In there you have a linkt to the console which is what you need here. You can find how to run it in the readme there. This is the direct link: https://github.com/zitadel/zitadel/tree/main/console


Use improved bezier curve intersection detection algorithm

According @barmac we use an overly complex algorithm to compute our quadratic and cubic bezier curve intersections.
We could consider incorporating the bezier.js intersection logic and see if it improves our library in terms of speed, complexity, and/or bundle size.

We use Beziér clipping and according to this article it is

...marginally slower than an algorithm based on implicitization (...) for curves of degree four and less...

Beziér curves in SVG path are either 2nd or 3rd degree.

Open for external contributions.

This repo is exponentially faster than bezier.js, well done!


Use http's timeout api

Currently twitter gem users can not set a timeout for requests which could lead to stuck requests.
This fixes #791.

@tak1n Thanks!

I will see where the proper place for this in the docs is and open another pr for doc when I get to it :)


test_runner: use glob to loop over all org tests

In test-runner.py, use a glob to iterate over all the test data files in the linked.data.gov.au/org directory, rather than listing them individually.

Merging without review since this is Richard's code anyway


[bug]: Update to 4.2.4 causes CUDA out of memory error in WSL/docker

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Linux
GPU vendor
Nvidia (CUDA)
GPU model
RTX 2060 Super
GPU VRAM
8GB
Version number
4.2.4
Browser
Waterfox G6.0.16
Python dependencies
No response
What happened
When generating with many LORAs added, Invoke 4.2.4 reports that my system is out of memory:

It seems to be filling VRAM, but doesn't fall back to system RAM once VRAM is full, then crashes.
I've changed the fallback setting in Nvidia console to system, it makes no difference.
If I use Invoke 4.2.1, it works fine. Unsure about versions in between.
What you expected to happen
Overflowing VRAM should fallback to system RAM, and overflowing system RAM should fallback to Swap. It should not throw an error once VRAM is full.
How to reproduce the problem
Using my setup install Invoke 4.2.1 and generate an image with heavy memory requirements (SDXL, many loras, controlnets, etc). It will work fine.
Then, update to Invoke 4.2.4 and generate another image with the same parameters. It will no longer work and you'll see this error. (use random seed, otherwise it might just copy the last image)
Additional context
My setup is Windows10 > WSL2 > Debian12 > Docker > InvokeAI. This is my docker compose:
invokeai-nvidia:
  build:
    context: ./InvokeAI
    dockerfile: docker/Dockerfile
  environment:
    - INVOKEAI_ROOT=/invokeai
    - INVOKEAI_LOG_LEVEL=info
    - INVOKEAI_HASHING_ALGORITHM=blake3_multi
  volumes:
    - ./invokeai:/invokeai
    - ./models:/invokeai/models
    - /mnt/g/Main/VirtualBox/WSL/models:/invokeai/models/g-mnt
  network_mode: host
  tty: true
  stdin_open: true
  deploy:
    resources:
      reservations:
        devices:
          - driver: nvidia
            count: 1
            capabilities: [gpu]

Discord username
No response

Update:
Have just finished testingolder versions, is definitely an issue specifically with 4.2.4.
Everything up to 4.2.3 works fine.


allow to configure incremental type check behavior

Codecov Report

Merging #59 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   94.19%   94.23%   +0.03%
==========================================
  Files           9        9
  Lines         448      451       +3
  Branches       58       60       +2
==========================================
+ Hits          422      425       +3
  Misses         26       26

Impacted Files
Coverage Δ

src/worker/TsCheckerWorker.ts
92.3% <ø> (ø)
:arrow_up:

src/checker/IncrementalChecker.ts
96.22% <100%> (+0.07%)
:arrow_up:

src/TsCheckerWebpackPlugin.ts
95.78% <100%> (+0.04%)
:arrow_up:

src/worker/TsCheckerRuntime.ts
97.56% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae0c56d...9ec8b03. Read the comment docs.


[support request]More document about dependencies

What is your problem or scenario?
We need more documentation on dependencies. If possible, provide an installation tool to check whether the dependencies are met.
Koordlet will throws an error when the kubelet readonly port is not open. But I didn't find the relevant info in the documentation.

Sorry for this experience, your suggestion is very good, we will continue to improve the document construction. Can you submit a PR to modify the installation documentation, and add a requirement section?

/assign @LambdaHJ


[zh]Update content/zh/blog/_posts/2020-12-02-dockershim-faq.md

/lgtm
/approve

The inconsistency has been resolved.
/unhold


Samples link is broken in Readme.md

The following appears to be broken:
https://github.com/Microsoft/Recognizers-Text/blob/master/samples

and the Specs and Patterns links also appear broken.

...more broken links under API Documentation
https://github.com/Microsoft/Recognizers-Text/blob/master/recognizers-number/src/number/numberRecognizer.ts

I still see lots of broken links on the Readme

Hi @johnataylor ,
The links should be fixed now on the master branch
Thanks

Links were fixed. Thanks for reporting this!


Update changelog and readme

Coverage remained the same at 90.047% when pulling e53f1664c95f719faeb5f909d82e14afbabb5f44 on update-changelog-readme into 6f19b3d270f709c0fd587fceba485283a0143dfa on master.


More common math binary operators such as atan2

exmex (partial) derivation feature is awesome but the lack of some common math/trigonometry binary operators reduces its general usefulness. It'd be awesome if operators like atan2 were implemented, including their derivatives.

What else except atan2 is missing?

Actually it looks like it's pretty much the only binary one. On the unary side, perhaps the h variants of the various a*h like atanh etc. You can use that list as reference: https://docs.sympy.org/latest/modules/functions/elementary.html: it mentions atan2, asinh, etc.

What is you use case that you need functions like atanh or asinh?

atan2 has been implemented in #52 with function call syntax atan2(y, x).


Search among the entries

Is it missing "search for the entries among the boards"? And it can have options like search only the undone/done lists.

@rislam thanks for suggestion, some kind of search definietely would be usefull

search per board added in v1.8.0. TBD. how to implement search among all boards