feature/cloud-support feedback

The feature/cloud-support looks good, thx Markus for your hard & continuous work
I found some errors and have some suggestions & questions:
Errors:

dnsmasq is looping around saying bad address at line 2 of /etc/dnsmasq.d/development
-> problem with hostname -i (I hacked it with $(hostname -i | cut -d' ' -f1)
Fix code right (UID/GID) also inside the entrypoint.sh of storage container ?
Fix truncating log files with touch instead of cp /dev/null in configuration.yml

Suggestions:

Use a default symlink to docker-compose.yml for the inexperienced user as
Elmar suggested. Every one can of course change later the symlink to another
target to suit their needs.
Rename storage to shared to reflect shared data among all containers (cache,dns,ftp,...)
Explain to the user there is a convenient way to shell it into the running container
docker exec -ti [main|web|storage|...] bash (for debugging, inspection, ...)
Use dockerfile extends to separate development from production

extends

Extend another service, in the current file or another, optionally overriding configuration.

Divert volume pointer only inside sourcecode to point to /code local (devel) or remote (cloud),
maybe using the above extends at buildtime and ENV state? It means the main & web container
are always pointing to the sourcecode container
We would also need a sort of export/import to a running container for runtime injection and
source code synchronization. (docker dependency > 1.8)

Usage:  docker cp [options] CONTAINER:PATH LOCALPATH|-
        docker cp [options] LOCALPATH|- CONTAINER:PATH

A better way IMHO could be also lazy instantiation of /code or /db with a URL, git clone, ...
Maybe we would also need a read/write or read-only flag to prevent accidental data overwrites.
Decoupling main from web container using the main container only for buildtime configuration and
mgmt services like backup/restore webdata, dbdata, ... Reduces footprint, the main container can be started on demand with cron or manually to execute mgmt tasks

Questions:

How can I inject the sourcecode at runtime and not only at buildtime
How can I generally make changes at runtime
Is there a chance to set the hostname and/or alias, e.g. main main_1, web web_1 ...
How can I propagate container names to upstream dnsserver.
This makes hard to ssh into main without introspecting the running container
Whats about exchanging dnsmasq with unbound or adding firewalld services ?
If docker-compose scalability is not needed (e.g.: main_1, main_2, ...) can we rename or better alias the container names?

Please forgive me if I don't know how your environment is working in deep details :-)
just my 2 cent

Please join #docker-boilerplate on typo3.slack.com


Empty repository

Hi,
I read your paper and intersted in testing it. Is it possible to get the code?
Thanks!

Hi, the code is currently being prepared for release and will be posted soon.

Thank you!

No worries! Thank you for taking an interest.


Update istio/proxy sha to include istio/proxy/#1819

#5059
Fixes https://github.com/istio/istio/issues/6361

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incfly, wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test e2e-simple

prow/istio-pilot-e2e.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test e2e-simple

prow/istio-pilot-e2e.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9f0234e21228c9ac6be8ff362ef0cd4c3e3ce13d
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Support swapped DP/DM pins

implement #29

Add new configuration option pinout

For example,

pin_dp=1, pinout=PIO_USB_PINOUT_DPDM (default) > pin_dp=1, pin_dm = 2
pin_dp=1, pinout=PIO_USB_PINOUT_DMDP (default) > pin_dp=1, pin_dm = 0

To set pinout, define PIO_USB_PINOUT_DEFAULT as PIO_USB_PINOUT_DPDM(default)/PIO_USB_PINOUT_DMDP, or set pio_usb_configuration.pinout`

FYI this is working for me. It would be best to be able to set DP and DM to any pin but requiring them to be next to each other isn't so bad as long as they can be swapped IMO. This is very helpful. If anyone needs hardware for testing PIO USB please let me know I may be able to provide some boards that might be useful. Thanks.

I take it this change makes it possible to specify arbitrary GPIO pins for data +/-  as long as the pins are consecutive?
Will this pull request be completed?   I'm working on a project where I'd like to connect a USB type A port to 2 of the GPIO pins such that the micro USB can be used for power delivery without concern with data pins.  Does this change make my scenario possible?  Thanks

Just to give some more context, I made the mistake of assuming that A0 and A1 on the Adafruit QT Py RP2040 board would be consecutive and increasing.  They are actually GP28 and GP27 respectively.  It was a naïve mistake, and I feel foolish, but I am pretty sure that others will make it.  In the meantime, I have designed a board (and had 50 made) that is a perfect form factor but has the pins reversed.  This patch would solve that for me.  Thanks for doing the work and considering the pull request

What's the status of this PR? This is a very helpful feature. Like others have mentioned already, the need for DP and DM to be consecutive and DM = DP + 1 is not a constraint that is clear. In my case, I have a board where layout was optimized to swap DP and DM for signal integrity reasons.
Anything I can do to help this move along?

Got this branch working with my custom board, but I see there's been lots of commits to main after this pr was made. Any chance of getting it merged? 😊


Notebooks: "..." on Cells Can Persist and Is Not Clickable when Cell Is Unselected

Create new notebook, add some code cells. Mouse over the "..." and move your mouse vertically up through other cells and you will see the "..." appear on multiple unselected cells.
In addition, if a cell is unselected, clicking the "..." doesn't do anything.

Fixed


[Chore #158427726] Add wireframes for UI layout

What does this PR do?

Add wireframes for UI

Description of Task to be completed?

Visualize the various webpages and their relationship

Any background context you want to provide?
Add UI sketch layouts, custom avatar image and favicon.
[finishes #158427726]
What are the relevant pivotal tracker stories?
#158427726
Screenshots

Your UI are great


Updating images and copy across Concepts/Tutorials/How-To-Guides

[ ] I have added the tests to cover my changes.
[ ] I have updated the documentation and CHANGELOG accordingly.
[ ] I have read the CONTRIBUTING document.

@AlejandroEsquivel Please can you point out which image is missing and has to be added in Quantum Gravity and which cell output in
PennyLane Tutorial contains the user directory.

@Emmanuel289 @AlejandroEsquivel the QG tutorial does not look ready.  It's missing one image (qg_workflow_2.png) and the third has not been updated.  additionally the cells need to be re-run since no output is showing.
Other images that need updating

workflow in the concepts page
mnist tutorial
pennylane tutorial
autoencoder tutorial needs cells to be executed
quantum chemistry tutorial
probably some other places

see other comment

@wjcunningham7 @AlejandroEsquivel  I went through the RTD and updated images/cells in various places:
-Concepts Page
-Machine Learning/Linear and convolutional autoencoders
-Machine Learning/MNIST classifier
-Machine Learning/Classical and quantum support vector machines
-Machine Learning/Using Covalent with PennyLane for hybrid computation
-Astronomy
-Quantum Gravity (Accuracy of model seems low for 0.11)

Using QAOA to solve the Max-Cut Problem (Looks good to me, no updates were made)
I ran into some dispatch errors in the following tutorials
Training quantum embedding kernels for classification (fails dispatch at cell 7)

Quantum Ensemble Classification (Fails dispatch at cells 8/9)


Bump golangci-lint to v1.48.0

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This incorporates new linters as well as the configuration update. New lint reports have been fixed as well.
Which issue(s) this PR fixes:

None
Does this PR have test?
None

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

Codecov Report

Merging #1072 (52be4bb) into main (b33aada) will increase coverage by 0.03%.
The diff coverage is 66.66%.

:exclamation: Current head 52be4bb differs from pull request most recent head 761bbe7. Consider uploading reports for the commit 761bbe7 to get more accurate results

@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
+ Coverage   50.43%   50.46%   +0.03%
==========================================
  Files          42       42
  Lines        4761     4756       -5
==========================================
- Hits         2401     2400       -1
+ Misses       2281     2278       -3
+ Partials       79       78       -1

/retest

Rebased and fixed a bunch of other lint reports.


Sending in batches

I'm trying to send over 100k emails efficiently, and I was wondering when I pass an array of emails to the to method, if it's actually sending it in batches or one-by-one. Thanks for all the help =)
ex. new_email |> to(array_of_emails)

This partly depends on the adapter. On Mandrill for example, Bamboo will send just one API call, and Mandrill will send one email per person in the to field. I think most other APIs and adapters do this as well, but you'd need to check the API docs of your service to see how it handles the to field to be sure.
I hope that helps :)


Please update to the latest version of forge 1.19 because the mod does not work

Well, a few days ago forge updated and made your mod unusable, so hopefully you can update it soon.

i have the same problem


NER model is not predicting any labels, even on test set during traning

Hi, thank you for this repo, unfortunately I ran into some issues and because there is no error message, I am unable to debug it....
When I try to generate predictions, I get blank output (model isn't predicting anything).
I realised that during training it also failed to predict any entities, but there was no error message, just warnings.
I used the following script to prepare dataset:
!python generate_data.py --task ner   \
                  --input_dir ./data/   \
                  --ade_dir ./ade_corpus/  \
                   --target_dir biobert_ner/dataset/   \
                  --max_seq_len 512 --dev_split 0.1   \
                  --tokenizer biobert-base   \
                   --ext txt --sep " "  \

Log:
Reading data

Train data:
Progress: [====================] 303/303

Test Data:
Progress: [==================> ] 191/202/Users/lsolis/Documents/GitHub/PubMed_pipeline/ehr-relation-extraction/ehr.py:186: UserWarning: Invalid annotation encountered: ['12 hours'], File: ./data/test/106967.ann
  warnings.warn(msg)
Progress: [====================] 202/202

ADE data: Done

Data successfully saved in biobert_ner/dataset/train.txt
Variable successfully saved in biobert_ner/dataset/train.pkl
Data successfully saved in biobert_ner/dataset/train_dev.txt
Variable successfully saved in biobert_ner/dataset/train_dev.pkl
Data successfully saved in biobert_ner/dataset/devel.txt
Variable successfully saved in biobert_ner/dataset/devel.pkl
Data successfully saved in biobert_ner/dataset/test.txt
Variable successfully saved in biobert_ner/dataset/test.pkl

Generating files successful. Files generated: train.txt, train.pkl, train_dev.txt, train_dev.pkl, devel.txt, devel.pkl, test.txt, test.pkl, labels.txt

Then run_ner.py
cd biobert_ner
export SAVE_DIR=./output1
export DATA_DIR=./dataset

export MAX_LENGTH=128
export BATCH_SIZE=16
export NUM_EPOCHS=5
export SAVE_STEPS=1000
export SEED=0

python run_ner.py --data_dir ${DATA_DIR}/ --labels ${DATA_DIR}/labels.txt --model_name_or_path dmis-lab/biobert-large-cased-v1.1 --output_dir ${SAVE_DIR}/ --max_seq_length ${MAX_LENGTH} --num_train_epochs ${NUM_EPOCHS} --per_device_train_batch_size ${BATCH_SIZE} --save_steps ${SAVE_STEPS} --seed ${SEED} --do_train --do_eval --do_predict --overwrite_output_dir

At the very last stage there was a print out in terminal, here is a fraction of it
05/10/2022 04:38:49 - WARNING - __main__ -   Example 1966, Example: 8 O

05/10/2022 04:38:49 - WARNING - __main__ -   Example 1966, Example: .  Not sure how they solved it, but there was an issue with GCP. Where are you training the model?

Thank you for your reply!
It seems that NER and RE were implemented in different Python versions. My guess is - Google Colab upgraded their default version when you were transitioning from one task to the other?
NER task requires Python3.7
RE - Python3.8
Running RE in Python3.7 gives the same error as when I run NER in Python3.8!
Maybe it's worth updating README - because it took me quite some time to figure it out - requirements get installed in both Python versions with no issues at all, so there is nothing to raise a flag regarding versioning.
Other than that - amazing work, thank you! :)

Interesting. I used the same python version to train both NER and RE tasks (Python 3.8.3). I didn't use Google Colab for training, so I'm not sure if this is a google colab specific issue. But feel free to add a troubleshooting section in the README and pull up a PR!


multiple calls to decorateIcons leaves icons empty

When programatically calling decorateIcons()  more than once during the initial rendering ( e.g. from a block js that is present more than once in a page)  only the icon related to the first call will be printed,
the rest of the icons will be replaced with: https://github.com/adobe/helix-project-boilerplate/blob/main/scripts/lib-franklin.js#L189
The current hypothesis it concurrent access to ICONS_CACHE, the first call sets the value to true in:
https://github.com/adobe/helix-project-boilerplate/blob/main/scripts/lib-franklin.js#LL151C7-L151C18
and while the icon is loading for the first call to  decorateIcons()  , the second call to  decorateIcons()  does not evaluate https://github.com/adobe/helix-project-boilerplate/blob/main/scripts/lib-franklin.js#LL150C16-L150C16 but directly jumps to https://github.com/adobe/helix-project-boilerplate/blob/main/scripts/lib-franklin.js#L186.

I think this is no longer an issue given the change icons are handled.


Update Smart Rollup tutorial

Tutorial needs some updates, primarily that for the binary you can use octez-smart-rollup-node without the alpha.
Related issue: if you wait too long between origination and starting the Smart Rollup node, it can't get enough info from the rolling L1 node. This fix changes the sandbox for this tutorial to use an archive node: https://gitlab.com/trili/hello-world-kernel/-/merge_requests/4

This file also needs the -alpha change I believe https://github.com/trilitech/tezos-developer-docs/blob/staging/docs/tutorials/smart-rollup/set-up.md#L80. Otherwise LGTM.


CI Security Scan for EE trigger test

Test2

/scan

/scan

/scan

/scan

/scan

/scan

/scan

scan

test

/scan

/scan

/scan


Memory leak in _blinkTiming

creation of _blinkTiming leaks memory is object is set from blink to on to blink. The destruction is also unchecked so calling clear after only calling on will try to free unallocated memory. Better to use a fixed array for the blink pattern.

Agree! The blink() method should just take the pattern-array as a reference, and use it wherever it is located. No new. No copy. The convenient class patterns should be static const, and any "dynamic" user provided patterns, is left to the user to memory manage.


Engine parallelism testing

This PR adds a new test to ELECTRIC/pytest/bench5/test_simulation.py that runs an analysis using two engines.

Codecov Report

Merging #28 into master will increase coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   93.30%   93.72%   +0.41%
==========================================
  Files           2        2
  Lines         239      239
==========================================
+ Hits          223      224       +1
+ Misses         16       15       -1

Impacted Files
Coverage Δ

ELECTRIC/ELECTRIC.py
91.01% <0.00%> (+0.59%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e6c78...fe350c4. Read the comment docs.


Enable feature flags in Django & React using django-waffle

Overview

add & configure django-waffle library
create api-feature-flags API endpoint
add feature flags Redux actions & reducers to store currently active feature flags in state
create FeatureFlag component to accept a flag and check whether it is active in the feature flags state, rendering only if so
add temporary "Claim a facility" text on FacilityDetailsSidebar component to activate only when the claim_a_facility feature is active
set some default props in the NavbarDropdown component to fix two prop types warnings

Connects #514
Demo
With claim_a_facility switch active:

->

With claim_a_facility switch inactive:

->

With no claim_a_facility switch:

->

Notes
We discussed potentially using this library https://github.com/garbles/flag but after investigating a bit further it seems like the functionality we needed from it was fairly straightforward to implement on our own. Since the library's still pre-official-release it seemed preferable to use our own implementation.
Testing Instructions

get this branch then ./scripts/update
./scripts/manage resetdb, ./scripts/manage processfixtures and ./scripts/manage createsuperuser
sign in to the Django admin and verify that you now see entries for Django-Waffle
without setting a switch, visit the React app and then look at the details page for a facility. Verify that you do not see the "Claim this facility." text at the bottom of the sidebar
back in the Django admin, add a claim_a_facility switch but do not yet activate it, then save the new object
return to the React facility details page and refresh, verifying that you still don't see the "Claim this facility." text
back again in the Django admin, activate the claim_a_facility switch and then save the update.
return again to the React facility details page and refresh, verifying that when the page fully loads you do see the "Claim this facility." text

Checklist

[ ] fixup! commits have been squashed
[x] CI passes after rebase
[x] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Looking at this now

Thanks for your help with this! Going to merge then will run the migrations on staging.


Port #9488 and part of #9463

Port #9488 (advance protoc version) and part of #9463 (advance BoringSSL version) to master.

Test failures:
Basic Tests Linux - #9437
gRPC_performance_pull_requests - #9499

This PR  has broken master, in particular the generate_project sanity check: https://grpc-testing.appspot.com/job/gRPC_master_linux/1398/testReport/junit/(root)/sanity_linux_opt/tools_buildgen_generate_projects_sh/

And yes, I don't know why Jenkins didn't complain. If you go to master right now and run generate projects, you'll see how it tries to do
-  s.dependency '!ProtoCompiler', '3.1.0'
+  s.dependency '!ProtoCompiler', '3.0.2'

on src/objective-c/!ProtoCompiler-gRPCPlugin.podspec


[feature] reveal in side bar

Describe your idea
Hi, i would like to request this feature, the idea is when you do searching, and click the class file, i always need to find the file location in the (left) side bar, it kinda PITA if the apps is heavily obfuscated, it would be great to have feature to right click the file (in code panel), and have option to reveal in side bar.
thank you

@RamadhanAmizudin this is already added, check View -> Sync with editor menu action or button at toolbar with same icon.


Add framework framework

Add framework.framework to serialized output
For briefs and services (ie. services, draft_services and archived_services) add the frameworkFramework field to the output. This is required for the admin app to be able to generate buyer app service URLs in a framework agnostic way.
The key frameworkFramework is not nice but it follows the existing pattern. This pattern should probably be changed to include sub-resources as sub-objects rather than having one big flat key space.
Add lotSlug to serialized Brief and Service
This adds in lotSlug with the intention of replacing the lot key. This follows the pattern we're using elsewhere and also opens us up to adding sub-resources as objects rather than flattening them into the object.

Like you say, it's not pretty but :+1:


Some problems on RPi3B

Hi,
Some problems when i execute your scripts:

only android devices can be paired.
after paired with android devices, the audio don't output to rpi3.
iphone bluetooth devices don't list raspberry.

Thanks.

What kind of Bluetooth device are you using? The Bluetooth capabilities of the Rasbperry Pi is very limited, so it is recommended to use an external USB Bluetooth stick.


Node 4.x install error

I have a problem when I try to install this module in NodeJS 4.3.0 and 4.4.1 (npm -v 2.14.12 and 2.14.20) on Mac Os X and Linux
1081 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "gps-util" "--save"
1082 error node v4.4.1
1083 error npm  v2.14.20
1084 error code ELIFECYCLE
1085 error<EMAIL_ADDRESS>install: node-gyp rebuild
1085 error Exit status 1
1086 error Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
1086 error This is most likely a problem with the mmmagic package,
1086 error not with npm itself.
1086 error Tell the author that this fails on your system:
1086 error     node-gyp rebuild
1086 error You can get information on how to open an issue for this project with:
1086 error     npm bugs mmmagic
1086 error Or if that isn't available, you can get their info via:
1086 error
1086 error     npm owner ls mmmagic
1086 error There is likely additional logging output above.
It's sound like an error when try to install the dependencies<EMAIL_ADDRESS>if I try to install mmmagic the version installed is 0.4.1 and the installation work fine.

I tried to upgrade mmmagic but the tests failed
https://travis-ci.org/vanng822/gps-util
Maybe time to find a package for replacing mmmagic. The only function we use there is type inspection. I couldn't find any pure javascript package that did well this job by that time. Should be some these days.

I removed mmmagic which means that those functions bellow will not check the content type
tcxParseFile
tcxParseURL
gpxParseFile
gpxParseURL
Make sure trust your source or write a wrapper and inspect the content


Min entity data size.

Hello.
I want to use the repository for one task.  The number of records is about 50,000. After the first filling, I will only update them.  The size of one record is limited.  I think it would be nice to enter the parameters - the granularity and the minimum size of the record, which would save you from swelling.  Perhaps in my case it is not so critical.  What do you think about it?
IGetBufferSizeStrategy

Hi @lobster2012-user, again about v5: now page allocation contains 5 free-space lists with diferent sizes.
/// 90% - 100% = 0 (7344 - 8160)
/// 75% -  90% = 1 (6120 - 7343)
/// 60% -  75% = 2 (4896 - 6119)
/// 30% -  60% = 3 (2448 - 4895)
///  0% -  30% = 4 (0000 - 2447)

Every time a document are inserted/update, page are realocated in one index based on how many bytes are free


player.seekTo() support?

I've looked through the code of usePlayer and haven't seen anything relating to the seekTo function discussed in Youtube's docs.
Is this feature supported here? If not, any plans on implementing it?

There is no direct function you can destructure from the usePlayer composable. But you should be able to access it via the exposed instance.
const player = ref();
const { instance } = usePlayer('dQw4w9WgXcQ', player);

instance.value?.seekTo(); // Fully typed

Currently I feel like there is no need to directly expose each method the player provides via the usePlayer composable. The composable provides direct access to the most common methods but not all of them.

Cool, this works.

Great, love to hear that!

I have done this, so I can second that this works. I would like to promote https://github.com/vue-youtube/docs/issues/3 here, because this would exactly address this question.


Save entire map as an image

Hello. Thank you for your excellent map editor.
While using your map editor, I noticed "Save Image" button only saves content that user sees in "canvas".
We can upload large resolution image as background image.
And need to work on map by moving & moving if we can't see entire part with lowest minimize (30%).
IF you could add "Save map" button that saves entire "workarea" with all contents in & workarea resolution, that will be good.

solved #234


Feature Request: "OK" button to confirm selection

Main Request:
Add [cpOKButton] (To add the "OK" button like you done for "Cancel" button).
Comments:

I think it would be very easy to add as i guess all it should do is close the dialog (as apposed to the cancel button reverting to the previous color)
It's a bit weird for me to think that in the current situation in order to confirm my selection i need to click somewhere else in the window, did i miss something?

Bonus:

Add [cpOKButtonText] (To change the text of the button)
Add [cpOKButtonClass] (To add the "OK" button class for design purpose)

Thanks ahead and nice work!

HI
I would also add an extra option to define the behaviour when user clicks out:
[onClickOut]=revert/change
So we can have all combinations
Thanks!


fix: Cannot read properties of undefined (reading 'matches')

The useWidgetFocus is failing in autoLayoutMode. The hook was meant for absolute positioning mode, not for autolayout where everything is positioned relatively.
PR fixes following issue(s)
Fixes #23880

Type of change

Bug fix

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan
Issues raised during DP testing
Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/build-deploy-preview env=release

Tested this PR and LGTM


SLIDEV extension icon not appearing in activity bar

please help me!
SLIDEV extension icon not appearing in activity bar
SLIDEV扩展图标未出现在活动栏中

How can this be resolved！

Same problem and the commands do not work either

Instead of opening the markdown file, use the "Open Folder" in vs code to open the project folder.
See https://github.com/slidevjs/slidev-vscode/issues/14

现在本地安装project文件夹
npm init slidev

接下来直接打开生成的slidev的文件夹，slidev的图标会显示在侧边栏。在之后你在当前workspace添加你的文件或者文件夹就可以了。


Update Package.swift to Support Swift Package Manager

Re-creating this ticket because the soln was never merged:
#275
"_In order to use Swift Package Manager to add Dollar as a dependency in Xcode 11, the Package.swift file must specify at least one target.
This PR updates Package.swift to add Dollar as a target._"
// swift-tools-version:5.1
import PackageDescription

let package = Package(
    name: "Dollar",
    platforms: [
        .iOS(.v9)
    ],
    products: [
        .library(name: "Dollar", targets: ["Dollar"])
    ],
    targets: [
        .target(name: "Dollar", path: "Sources")
    ]
)

Works well for me.

Taking a look. My last comment was to add additional platforms which I can do.

Taking a look. My last comment was to add additional platforms which I can do.


Add Russian Translation

Thank you, published in 5d89352
You had changed the english-translation file to russian so I fixed that by moving it to the Russian folder instead.

You are welcome. Thank you for such a nice mod!
Didn't know how to add a translation other than change the original english-translation file, sorry for that.


shared/api/url: Add WithQuery

This adds a WithQuery method to shared/api/url so that we can easily add custom queries to an api.URL.

Thanks!


add print-key command

This prints the public key entry for a private key in a bindle client's secrets_keys.toml or a bindle server's signing-keys.toml file.
Example:
$ bindle print-key
version = "1.0"

[[key]]
label = "Matt<EMAIL_ADDRESS>roles = ["creator"]
key = "Qx6Q8d0K8sb0828S8hivB9ev+CWB+i1jqv596F3MbFQ="
labelSignature = "v6trXDbBKLl+9dXgmNlySajcPYHTeqwPy3Zy+PybD5qKGfPoMhkEp1pnkpSWHz5KT1F5yGxyUAvk4EbFmW7KDg=="

Note that you can use --label to filter to only keys whose label matches. This is approximately consistent with the way GPG works.
$ bindle print-key --label Matt
version = "1.0"

[[key]]
label = "Matt<EMAIL_ADDRESS>roles = ["creator"]
key = "Qx6Q8d0K8sb0828S8hivB9ev+CWB+i1jqv596F3MbFQ="
labelSignature = "v6trXDbBKLl+9dXgmNlySajcPYHTeqwPy3Zy+PybD5qKGfPoMhkEp1pnkpSWHz5KT1F5yGxyUAvk4EbFmW7KDg=="

Signed-off-by: Matt Butcher<EMAIL_ADDRESS>

See also #198. This outputs keys in the format described there.

Also, if no matching keys are found:
$ bindle --server http://localhost/v1 print-key --label foo
version = "1.0"
key = []

If a key on the secret keys file fails to decode, a warning is sent to STDERR, but the process will continue on. This is how gpg works, and it makes sense, because otherwise a single corrupted key could prevent you from being able to ascertain anything about your keyring.

This is the mac os test flake I've been seeing. Should be fine to merge


downstream_peer metrics unknown in custom TCP metrics dimension

Bug Description
Following https://istio.io/latest/docs/tasks/observability/metrics/customize-metrics/#use-expressions-for-values, we have defined the following extra dimensions for our server-side TCP metrics:
"metrics":[
  {
    "dimensions":{
      "dir":"'in'",
      "src_app":"downstream_peer.workload_name"
    },

However src_app is always "unknown". After increasing the verbosity, we continue to see this error:
{"level":"debug","time":"2023-03-03T01:18:56.031961Z","scope":"envoy wasm","msg":"expr_evaluate value error: No value with name \"downstream_peer\" found in Activation"}
{"level":"trace","time":"2023-03-03T01:18:56.032003Z","scope":"envoy wasm","msg":"wasm log stats_inbound tcp_stats_inbound: [external/istio_proxy/extensions/stats/plugin.cc:633]::report() Failed to evaluate expression: <downstream_peer.workload_name>"}

What is strange however, is that the "standard" source_workload label is set correctly:
# TYPE istio_tcp_connections_closed_total counter
istio_tcp_connections_closed_total{reporter="destination",source_workload="mesh-e2e-tcp-client-a-ea1t-us",destination_service="mesh-e2e-server-a-ea1t-us.mesh-e2e-a-ea1t-us.svc.ea1t.us.a",dir="in",src_app="unknown"} 0
# TYPE istio_tcp_connections_opened_total counter
istio_tcp_connections_opened_total{reporter="destination",source_workload="mesh-e2e-tcp-client-a-ea1t-us",destination_service="mesh-e2e-server-a-ea1t-us.mesh-e2e-a-ea1t-us.svc.ea1t.us.a",dir="in",src_app="unknown"} 10
# TYPE istio_tcp_received_bytes_total counter
istio_tcp_received_bytes_total{reporter="destination",source_workload="mesh-e2e-tcp-client-a-ea1t-us",destination_service="mesh-e2e-server-a-ea1t-us.mesh-e2e-a-ea1t-us.svc.ea1t.us.a",dir="in",src_app="unknown"} 11900
# TYPE istio_tcp_sent_bytes_total counter
istio_tcp_sent_bytes_total{reporter="destination",source_workload="mesh-e2e-tcp-client-a-ea1t-us",destination_service="mesh-e2e-server-a-ea1t-us.mesh-e2e-a-ea1t-us.svc.ea1t.us.a",dir="in",src_app="unknown"} 11900

Version
istio 1.15.5 (though this issue has persisted at least since 1.10).

Additional Information
Seems similar to https://github.com/istio/istio/issues/39614.

I test with following IOP, works as expected.
# export mesh_id cluster_id in metrics
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  name: custom-tags
  namespace: istio-system
spec:
  meshConfig:
    accessLogFile: /dev/stdout
    defaultConfig:
      extraStatTags:
        - src_app
  values:
    global:
      meshID: mesh1
    telemetry:
      enabled: true
      v2:
        enabled: true
        prometheus:
          configOverride:
            outboundSidecar:
              metrics:
                - name: requests_total
                  dimensions:
                    src_app: downstream_peer.workload_name
            inboundSidecar:
              metrics:
                - name: requests_total
                  dimensions:
                    src_app: downstream_peer.workload_name

@zirain, requests_total is an HTTP metric. We are specifically running into this issue for TCP connection metrics (both the connections opened / closed, as well as bytes sent / received). Can you try you IOP with a TCP metric (like istio_tcp_connections_closed_total?)

not stale


Use releases

It would be nice if you make releases on a regular basis. A release could be done after some minor or a major edit.

Using a 'release' allows for quick and easy notification using the 'watch release' feature of github :)
Please include the 'pdf' file output in the ,build pipeline' to close https://github.com/wsargent/docker-cheat-sheet/issues/124 too


Any way to pull realtor data with sold properties or listings?

I am working on learning python and found this project. It is really awesome!
I was able to modify the output name of the excel file based on the parameters i was searching for.
I am trying to find a way to add realtor names to the list of sold properties. I looked through the html on the site and found it is under <strong data-testi id or Seller-sc-okw218-0 jDsXJc. Looking through your code it looks like it goes directly to the api so the names might not be the same on the site as what would show up on the json payload.
Is there a way to run a query to the api to see what field names they have?  or can realtor fields be be added? I was trying to do it myself but have a lack up understanding in how this all works together at this point.
Sorry if this is not the place to post this but am not sure what to do without the fieldnames.

Change your listing type to sold to get sold properties.

Hey thanks for the quick response.  I want to add the realtors who worked on the deal to the results. Pulling a list of sold property works perfectly but the agent info is not being looked for.

I am not sure the data is easy to get in a fast manner, I can check again if you'd like.

@cullenwatson added agents.


Creating specific Nodes in Model

Creating the Nodes (gates) like: and-gate, or-gate, XOR-gate etc.

What Nodes do you plan to implement until we merge this branch?

AND, OR, XOR just so we have at least some functionality.


No configuration for the debug configuration type launch snapshotInitialize is available

Issue description: I am facing this error when I try to download symbols or publish an extension. I have realized that the problem only occurs if I am using a workspace.

AL Extension Version: v6.1.362735

Server Version: ES Business Central 16.5 (Plataforma 16.0.15884.15941 + Aplicación 16.5.15953.0)

Steps to reproduce the issue:
I've created two extensions using "AL:Go..." option in VSCode. If I open separately everyone in a diferente VSCode instance, I can download symbols, but If I create a workspace including both folders and I try to download symbols in any of them the OUTPUT shows "Error: No server has been chosen." and the AL Language launches the error: "No configuration for the debug configuration type launch snapshotInitialize is available".

I've attached an example (AL workspace with two AL extensions)

Workspace Sample.zip
Regards,
Carlos

Same here.
I also have this issue when working with workspace.
Zoran M.

Oops I forgot to mention a little detail: I am getting this issue since I updated VSCode to the last version (v1.51) and rebooted the laptop.   ;-)

Yes, it looks like something got broken in my opinion in vscode's configuration code base.
Naming and saving the workspace and (unfortunately) restarting vscode should fix the issue.

This workaround is not working for my.
I've renamed and recreated the workspace (restarting VSC every time) but I always get the same error.
Regards

Had the same problem, and I was able to solve it by adding a launch configuration to the workspace file.

Yes, adding one launch configuration at workspace file, works for me too.
But, if you add more than one launch configuration, it fails again. As I use several launch configurations, I prefer to open each folder in a different VSCode instance.

Nothing seems to help can't even Debug an Customer Sandbox at the moment, keep getting this message
"No configuration for the debug configuration type launch attach  is available" (assume its related)
Is there an solution for this soon? Even tried creating an new project from scratch and have the same issue, can we downgrade or have an workaround for this so I can help my customers!!

@Easystep2
Can we have a concise repro step. I have 1.51.1 and also 1.52.insider (green vscode)
I have a workspace with 2 projects each having its own launch.json in the .vscode folder.
After creating the workspace I have restarted vscode on 1.51. I have tried without restarting on 1.51.1 and had no issues.
I have many configurations in both my launch.json files.
I have no issues downloading symbols, debugging, publishing. Or any other command that requires that we connect to  a server using the configuration settings,

Hi,
Right now I have 1.51.1 version and I don't get to reproduce the issue. Maybe this issue was fixed in this version?


Wrong column name in result from sqlite join with subquery

On sqlite the result of this query:
knex('A')
  .select('A.id', 'B.id as r')
  .innerJoin(knex('A').as('B'), 'A.aid', 'B.id')
  .then(function (row) {
    console.log(row);
  });

is this:
[ { A: 1, r: 2 },
  { A: 2, r: 3 },
  { A: 3, r: 4 },
  { A: 6, r: 7 } ]

while on postgres an mysql I get the correct:
[ { id: 1, r: 2 },
  { id: 2, r: 3 },
  { id: 3, r: 4 },
  { id: 6, r: 7 } ]

Is there something about sqlite joins that I'm missing, or is this a bug in knex?

Oh, and in my real case I need to join the subquery and cannot simply use innerJoin('A', 'A.aid', 'B.id').

You probably want:
knex('A')
  .select('A.id', 'B.id as r')
  .innerJoin('A as B', 'A.aid', 'B.id')
  .then(function (row) {
    console.log(row);
  });

not:
knex('A')
  .select('A.id', 'B.id as r')
  .innerJoin(knex('A').as('B'), 'A.aid', 'B.id')
  .then(function (row) {
    console.log(row);
  });

The latter outputs:
select "A"."id", "B"."id" as "r" from "A" inner join (select * from "A") as "B" on "A"."aid" = "B"."id"

I'm not sure why sqlite3 driver gives this binding output, however.

I need to use the subquery in the join. In my actual use case the subquery is more complex. So the output is coming from the sqlite driver? Then I probably need open an issue there instead of here.

Yeah I'm not sure how the columns are mapped to the values on their end... Might be good to reproducing with the raw query against the sqlite3 lib directly without knex to confirm it's the source of the issue.


Fix #67 Fixed Cookie creation in cookie plugin.

fix #67
Fix applied by calculating the expireIn (max-age) seconds instead of expire datetime.
Expanded save spec by using a more complete cookie.
Use DATE_COOKIE constant instead of DateTime constant.
Expand the cookie header content with all parts.

I did not know how to assert values in the cookie object, since the cookiejar can not be mocked (final). Any suggestions? :)

Thanks for the report and the PR. I will review this shortly.

that indeed looks more robust to me. @sagikazarmark can you maybe help with phpspec / my fear of a test that will randomly fail?

Hmm hhvm does not seem to handle 4 digit year in cookie expires date.
https://3v4l.org/bmmjC

oh well... hm, whatever then lets just put 99 :-D
not our problem to solve really, and in 2099 we probably won't live
anymore (and i would be surprised if PHP was still around then...). and
in 2100, 99 will probably mean 2199 so we are all good.

One last minor thing (Style CI) and ready to merge from my point of view.

:+1: maybe also squash the commits.

Fixed and squashed :8ball:

Merged this manually because there were some conflicts.

Thanks @Bouwdie


Support API for Search and AQL

We have a customer "Corvus Insurance" who is extensively using our Terraform provider. They would like to be able to query a repository based on an AQL query or property search.
POST /api/search/aql
items.find(
    {
        "repo":{"$eq":"libs-release-local"}
    }
)

@williammanning Can you provider more information for this customer's use case? What do they use AQL query for? Do they wish to use it in conjunction with other resources in the HCL?
If you can provide some pseudo-HCL with the AQL usage, it will help us figure out what to implement.

@williammanning
The terraform provider is about resource creation and management. Create a repo, delete a user, etc. Your AQL is a simple read operation - meaning, it isn't doing any resource management.
Also,
We do have a format for how we take in feature requests and you would have been provided with a template. If you can expand upon your request and also use the template, we'd be happy to help. In the meantime, we will be closing the ticket due to insufficient details


Docs/readme url

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Fix wrong contributors url
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Would you please check merge conflict?

thanks, i checked


Add the ability to display no upper text

This change simply adds an options (localized) to display no upper text in the application on the splash screen.
NOTE: change 3742d0 is from another feature branch that was reverted in change 4224009. The gitignore file in cc09b91 is already part of another pull request that includes the change in 32742d0

Feature-branch madness from scripts on my machine...


How to get your IP addresss

How to get your ip on Windows, Linux and Mac

Done!
https://github.com/lgallard/qBittorrent-Client/wiki/How-to-know-your-qBittorrent-server's-IP-address


render() and renderSync() are deprecated for the sass package

Hi,
After having created a performance issue for the sass package, I learned that the render() and renderSync() methods were deprecated and suffered from performance issues:

https://github.com/sass/dart-sass/issues/1913#issuecomment-1469070397
https://github.com/sass/dart-sass#legacy-javascript-api

We can also notice it in the comments of the code:

Ideally, we should suggest a way to use compile() and compileAsync() methods for the following lines:
https://github.com/dlmanning/gulp-sass/blob/c04bb67043fdbcb930152232ee9ba4caff0b2599/index.js#L145
https://github.com/dlmanning/gulp-sass/blob/c04bb67043fdbcb930152232ee9ba4caff0b2599/index.js#L158
Example from sass:
const sass = require('sass');

const result = sass.compile(scssFilename);

// OR

// Note that `compileAsync()` is substantially slower than `compile()`.
const result = await sass.compileAsync(scssFilename);

Heads up: we (the Sass team) are going to start emitting deprecation warnings for uses of the legacy API pretty soon.

Since Sass 1.79.1 the deprecation warnings are now active:
Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.


Controller Packet - in python

Just like the Headset position, I am attempting to write python script to send Controller packets. Connection to the control API and sending data basically works, but I can't get 'orientation' working properly.
The following 'builds' a packet of 144 bytes total length:
controller_packet = Struct(
        Const(Int32ul, 2),              # Version
        Padded(4, Const(Byte, 1)),      # SendFullState
        Padded(4, Const(Byte, 0)),      # ControllerOrigin
        "id" / Int32ul,                 # ControllerId
        Const(Int32ul, 0),              # Status
        "orient" / Array(16, Float32l), # OrientationMatrix
        "count" / Int32ul,              # PacketNum
        "pressed" / Int64ul,            # ButtonPressed
        "touched" / Int64ul,            # ButtonTouched
        "axis" / Padded(40, Array(3, Float32l)),        # we only use 1st 3 of 10 floats
)

The controller appears, but at an 'odd' location, and rotation is very strange. It appears to rotate in one plane for 180' (of a 360' sweep) and then another plane for the 2nd 180'. Does the above look correct, it's very hard to decypher the wiki page?

A simplified version of what I am doing is as follows:
from pyrr import Quaternion, Matrix44, Vector3
<snip>

for swivel in range(0,360,30):
        # Direction that controller is pointing...?
        # [X, Z, Y]
        matrix1 = Matrix44.from_eulers([radians(0),radians(swivel),radians(0)])

        print("swivel:", swivel)
        print(matrix1)
        print(matrix1.reshape(16).tolist())
        print("---")

        controller1 = controller_packet.build(dict(
                id = 1111,
                orient = matrix1.reshape(16).tolist(),
                count = count,
                pressed = 1,
                touched = 0,
                axis = [0, 0, 0],
                ))

Output is attached.
test.txt
My (limited) understanding of Matrix math (quaterions and translation) is that a simple matrix like this should represent an spining object at the '(0,0,0,)' origin.
https://www.j3d.org/matrix_faq/matrfaq_latest.html

Think I might have got it working... took 4 bytes out of the start of the packet.
controller_packet = Struct(
        Const(Int32ul, 2),              # Version
        Padded(2, Const(Byte, 1)),      # SendFullState
        Padded(2, Const(Byte, 0)),      # ControllerOrigin

        "id" / Int32ul,                 # ControllerId
        Const(Int32ul, 0),              # Status
        "orient" / Array(16, Float32l), # OrientationMatrix
        "count" / Int32ul,              # PacketNum

        "pressed" / Int64ul,            # ButtonPressed
        "touched" / Int64ul,            # ButtonTouched
        "axis" / Padded(40, Array(3, Float32l)),        # we only use 1st 3 of 10 floats
)

And also need to 'transpose()' the vector to get the translations working.
        controller1 = controller_packet.build(dict(
                id = 1111,
                orient = matrix1.transpose().reshape(16).tolist(),
                count = count,
                pressed = 1,
                touched = 0,
                axis = [0, 0, 0],
                ))

working example code here:
https://github.com/mungewell/pyPSVR/blob/master/example3_vridgeapi/vridge_swivel_controllers.py

I'm closing this issues since it seems to be resolved.
We'll be changing packets structs/serialization to make it less confusing. See https://github.com/RiftCat/vridge-api/issues/9.


Update prover-market-page.mdx

looks like its offline?

My apologies, I'll try to figure the ports out soon

Fixed prover URL and a misconfigured .env setting. Should be working now


[wip] Annotations imports

The last remaining item in the beta release we think is the flytekit plugin system.  This is because this will affect how users install and import plugin tasks (like Spark or Pytorch, or plugin types like Pandera, etc.)
This PR attempts one possible solution.  For those unfamiliar, please take a look at this blog post first https://medium.com/@jherreras/python-microlibs-5be9461ad979 as this PR is heavily based off of that.  Also see PEP 420 for more info.  Also see the existing vaex setup which is where I found the blog posting.
We rethought the plugin code structure with the following in mind.

When we remove the alpha/beta qualifiers on the new API, we'll likely release it as 0.16.x or 0.17, it will not be 1.0.  That is, we cannot break existing users (old plugin code imports should continue to work).
For example, we'd like pip install flytekit[spark] to continue to install the existing master-branch spark functionality.  But we don't have to install the new spark stuff, based on the annotations branch.
For that, users should install something like flytekitplugins-spark.
Flytekit plugin code that is more split out, perhaps even in another repo, is cleaner because plugin systems should be more delineated and distinct.  This separation ensures that.

This PR

Moves all the new annotations branch taskplugins code into separate flytekitplugins namespace package folders, under the new top-level folder (outside of the highest level flytekit folder).  For all intents and purposes, you can think of this folder as a separate repo.
Moves all the tasks for each plugin type into a separate tests folder in each plugin.
Adds a setup.py file for each plugin
Adds a not quite working local-development only (read: not a real Pypi package) setup.py for the top level flytekitplugins folder.
Changes the plugin pandas imports to not be from the flytekit lazy loader, but pandas for reals.

Upsides of doing things this way.

Enforces separation.
Promotes ease of new contributions.

Downsides of doing things this way.

Since separation is enforced, we need a lot more stuff.  Each one will have its own setup.py, requirements file, etc.  If you want to bump the minimum flytekit version (which now is an explicit dependency), you have to go in to each plugin's setup and bump the version.
Local development no longer works without installing.  When writing flytekit, often i will export PYTHONPATH=:$PYTHONPATH to basically add the current directory to the list of places where Python searches for code. This is no longer possible for the plugins.  This is because the location of the pytorch plugin is now plugins/pytorch/flytekitplugins/pytorch/blah.py. When using something defined there, if you just write from flytekitplugins.pytorch.blah import MyBlah it won't find it.  It'd only work if you write from plugins.pytorch.flytekitplugins.pytorch.blah import MyBlah but of course you can't do that, because that won't work for after it's been deployed.
This means you have to pip install -e . each plugin.  The -e means development mode install, and it basically adds an egg link from your site-packages to the directory where you ran that command. This is fine, just more steps.

Additional notes.

Unclear if we should keep all the plugins as one repo, or have each plugin be its own github repo.  I'm inclined to the former, as is the author of the blog (search for "keep each library in a single repository").
Even though pandas is large I'd like to propose that we bundle it with flytekit.  In other words, I think the Schema type should be included when you do pip install flytekit.  I don't think we should make users pip install flytekitplugins-schema -- it's just too central.

@wild-endeavor - WOW! Thank you for doing this. A few comments.
Also we have decided to flytekit as is right - as-in we wont split flytekit into legacy and new right?

@wild-endeavor - WOW! Thank you for doing this. A few comments.
Also we have decided to flytekit as is right - as-in we wont split flytekit into legacy and new right?

Some thoughts around downsides:

Since separation is enforced, we need a lot more stuff...
We can add a boilerplate script to bootstrap a new plugin, and another script to bump versions.

Local development no longer works without installing...
I guess as long as we well document pip install -e ., it should be totally fine. Actually I have been only using this way, as it is more or less a standard/common practice.

Some thoughts around downsides:

Since separation is enforced, we need a lot more stuff...
We can add a boilerplate script to bootstrap a new plugin, and another script to bump versions.

Local development no longer works without installing...
I guess as long as we well document pip install -e ., it should be totally fine. Actually I have been only using this way, as it is more or less a standard/common practice.

Regarding repositories, I think keeping all plugins in one repo is sufficient, given most cases the plugins being relatively small. Having too many repos may require a lot more maintenance, e.g. versioning, CI.
I think it is also OK to postpone repo split at this moment, because that still seems like a luxury problem that we don't have to deal with immediately. Consider this as my Luigi maintenance experience, but of course it has very different setup. :)

Regarding repositories, I think keeping all plugins in one repo is sufficient, given most cases the plugins being relatively small. Having too many repos may require a lot more maintenance, e.g. versioning, CI.
I think it is also OK to postpone repo split at this moment, because that still seems like a luxury problem that we don't have to deal with immediately. Consider this as my Luigi maintenance experience, but of course it has very different setup.   I'll work on cleaning it up and addressing all the other comments today if that's the case.

  I'll work on cleaning it up and addressing all the other comments today if that's the case.


[✨ FEATURE]: Export Evaluator Answer Table As Csv

Feature Description 📝
Add functionality to export data from the Evaluator heuristics table to a CSV file. This feature will allow users to download the table data for external analysis and reporting purposes.
screen-recorder-thu-jun-13-2024-12-35-10.webm
Motivation 🌟
The current application allows users to view data within the Evaluator heuristics table, but lacks an option to export this data for offline analysis or reporting. By adding CSV export functionality, teams can easily share and analyze data outside the application, facilitating better collaboration and more in-depth analysis
Expected Behavior 🤔
Users should see an "Export to CSV" button associated with the Evaluator heuristics table. When clicked, the application should generate a CSV file containing the current data in the table and prompt the user to download it. The CSV file should be well-formatted, including appropriate headers for each column in the table.
Additional Information ℹ
The CSV export should capture the state of the table as viewed by the user, including any filters or sorting applied.
The implementation should ensure that special characters and commas within the data are properly escaped to maintain CSV integrity.
This feature will enable teams to use external tools like Excel or Google Sheets to create detailed reports and perform advanced data analysis, enhancing the utility of the Evaluator heuristics data.

@jvJUCA should i create  a PR
for this feature ?

This would be very useful. It would be good to validate whether the data exported as CSV would be useful, and the implementation should be done in a way that ensures quality.


Invoke without input

should be nicer, possibly the default, but I think with input will be more common

meh


Get Application Gateway Server Variables APIs changes for 2018-11-01

Latest improvements:
This is a breaking change. Get Application Gateway Server Variables APIs changes were merged in 2018-11-01. We want the APIs results to be of type List(string) rather than Dictionay(string,List)
Link to previous PR: #4916
Link to the PR with changes for 2018-12-01 version: https://github.com/Azure/azure-rest-api-specs/pull/5113

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-ruby

Can one of the admins verify this patch?

Automation for azure-sdk-for-js

Automation for azure-sdk-for-python

Automation for azure-sdk-for-node

Automation for azure-sdk-for-java

@sarangan12 could you check Ruby CI?

@nirkum18  please apply your changes to the latest 2018-12-01 api version. currently PR can't be merged with changes to existing api (and not for the newest one) and will be exluded without fixes

@nirkum18 please apply your changes to the latest 2018-12-01 api version. currently PR can't be merged with changes to existing api (and not for the newest one) and will be exluded without fixes

@MikhailTryakhov these changes have been applied to the '2018-12-01' already. But since this is a breaking change, we need to fix the code in 2018-11-01 as well.

@nirkum18 please apply your changes to the latest 2018-12-01 api version. currently PR can't be merged with changes to existing api (and not for the newest one) and will be exluded without fixes

@MikhailTryakhov these changes have been applied to the '2018-12-01' already. But since this is a breaking change, we need to fix the code in 2018-11-01 as well.

@MikhailTryakhov The changes present in 2018-11-01 currently are breaking and needs to be fixed. This PR contains the changes to fix them. Is there no way we can merge these changes?

@MikhailTryakhov, @nirkum18 so what's your decision?

@MikhailTryakhov, @nirkum18 so what's your decision?

@sergey-shandar @MikhailTryakhov We need these changes to get in to fix the already breaking code in 2018-11-01. Else these APIs would not work for anyone using 2018-11-01.

@sergey-shandar @MikhailTryakhov We need these changes to get in to fix the already breaking code in 2018-11-01. Else these APIs would not work for anyone using 2018-11-01.

Next Network SDK is going to be 2018-12-01, no fixes are planned for 2018-11-01 (though I still think that fixing older specs is a good idea).

@nirkum18 LGTM, do you have agreement with @MikhailTryakhov and could you have a look ruby again? It looks like there is a problem with tags.

Had conversation with @MikhailTryakhov
Since these changes will not affect the already in use real clients, getting these changes in will not bring much value.
So closing this PR.


ITM support

I'm currently using ITM for log messages via the itm_logger crate. This works with openocd, but I see no option to use this here. It seems that probe-rs has some support for it already.

Yes, I'm using an ST-Link via OpenOCD/GDB, then VS Code to dump the ITM messages.

In this setup itm, would be an option, but rtt is also. Why do you choose itm over rtt?

TIL. That's the problem if you only work with j-links 😅


Renamed variables to avoid shadowing built-ins

Some variables in the code base were using the same name as some Python built-ins (input, type, property, format etc.). Therefore I've renamed them. This will avoid that maybe later we'll run into problems and some strange bugs.

Coverage decreased (-0.02%) to 59.688% when pulling 893fe32e1eae96738f8ffc5d3b4cfc0ebb70b7ea on fbernhart:fix_shadowing into 5ec9d1a29be8d9fcbdd553b26441298172b92a32 on xhtml2pdf:master.


KAFKA-4879 KafkaConsumer.position may hang forever when deleting a topic

@guozhangwang  I created this PR but it lacks the test. I also has the test but I wanted to ask which Test file should be the best candidate for this?
Also there is a TODO line which I created because that method already has a timeout parameter, what do you think how can we proceed there?

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6611/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6596/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6599/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6614/
Test FAILed (JDK 7 and Scala 2.11).

Closing this since I'm taking over the issue.


The Anti-triggered Edit™ 2: Electric Boogaloo

I pulled into the wrong branch. Now this should be correct.
I'm not very familliar with git yet so I don't know how to change branches.

Are you sure this is correct? Zh-TW sounds like taiwan, not traditional version
chinese should stay "zh-CN"

https://en.wikipedia.org/wiki/Zh-TW <=trad. chinese
https://en.wikipedia.org/wiki/Simplified_Chinese_characters <= simplified one

ps.Sorry for linking

Yes, it is correct, zh-TW is indeed Traditional Chinese of the Taiwanese variety. zh-HK is Chinese (Hong Kong) but it's almost identical, and also missing from Google translate.

It's best not to simply put "chinese" as zh-CN just to remain neutral, even though Google translate does that. However if you don't think so I'll keep chinese-simplified and add back chinese as zh-CN.

For was majority of users, it is a convenience to have chinese-simplified as chinese. Just remove "-simplified", or add another one as "chinese" with zh-CN too.

I guess it is technically the majority (1.3 billion > 40-50 million)... I'll add it back

ty


fuzzy-search role not created by plugin in v5 (3.1.0-beta.1)

The fuzzy-search role isn’t auto-created by the plugin in v5 on 3.1.0-beta.1. The docs say, “Make sure to set the appropriate permissions for the search route in the Permissions tab of the Users & Permission Plugin for the role to be able to access the search route.” Without this role, I can’t set permissions or use Fuzzy Search! (Was working in v4)

Hey @qdpy,
thats odd. I'm not experiencing this issue both in a running setup and in a fresh install of Strapi v5. Could you check whether you are facing the same issue with a fresh install of Strapi?

Tested it on a fresh install and I’m facing the same issue! :') Here's my plugin.js:
module.exports = () => ({
"fuzzy-search": {
enabled: true,
config: {
contentTypes: [
{
uid: "api::wiki-page.wiki-page",
modelName: "wiki-page",
fuzzysortOptions: {
threshold: -9000,
limit: 10,
keys: [
{
name: "title",
weight: 100,
},
{
name: "content",
weight: 90,
},
],
},
},
],
},
},
});

@DomDew

Hmm... Thats really odd. I just set up a completely fresh project again just to be sure and I don't face any issues, so I'm afraid I can't reproduce your issue on my side... 😮💨
Which version of node are you running and which version of Strapi?
For me everything just works as expected 😅:

From the top of my head: Did you try "manually" rebuilding the admin panel with npm run build?
Yes, not working

"@strapi/strapi": "5.2.0"
Node: v20.11.1
@DomDew

Hm, weird...
Are you facing similar issues with other plugins or is it just this plugin?

Just this plugin!


feature: split service principal for plan and apply

Overview/Summary
As per issue #24. This PR is to add an additional user assigned managed identity and isolate permissions for plan and apply. This PR is being done before some of the others as it is a significant refactor and makes sense to do it prior to layering other changes on top.
This change is driven by community asks for 'best practice' around security. This will be combined with a second issue for required templates to demonstrate how to secure a pipeline. We want this accelerator to be consumed by all customers, including those with tight security needs, so adding these features to enable that.
In the future it could also serve as a generic model for secure pipelines with Terraform if we extract it into module(s).
In summary, the initial implementation had:

1 User Assigned Managed Identity

2 Federated Credentials (plan and apply) on the same Managed Identity, mapped to to the Environment (GitHub) or Service Connection (Azure DevOps)

2 Service Connections for Azure DevOps (plan and apply)
2 Environments (plan and apply)

This PR moves the model to:

2 User Assigned Managed Identities (plan and apply)

Each has it's own federated credential mapped to the Environment (GitHub) or Service Connection (Azure DevOps)

2 Service Connections for Azure DevOps (plan and apply)
2 Environments (plan and apply)

The .test template has been updated to include creating a management group and a resource group to prove the read and write permissions work as expected.
This PR fixes/adds/changes/removes

#24

Breaking Changes
There are no changes to the interface for users of the PowerShell module, all inputs remain the same. Just the deployed resources change.
Testing Evidence
E2E tests will be run as part of this PR.
Manual testing of:

CI / CD for Apply and Destroy with Management Groups and Resource Groups for:

GitHub
Azure DevOps WIF
Azure DevOps MSI

As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Updated relevant and associated documentation.

I am merging this as has been tested and required as the basis for the next features


fix(guide): Declared variable x in the Basic Solution for Caesars Cipher challenge

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #36044
This PR fixes the lack of variable declaration of variable x in the Basic Solution of the Guide article.  I also removed the problem description which just duplicated from the challenge itself.  Also, I removed the repl.it links and reformatted the indentation of the solutions.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Adding field set to standard controller

Critical Changes
Changes
Issues Closed
Fixes #2262

@dospromptman can you take a look at this PR when you have a chance?


Add data and scripts for LAMMPS runs on Ruby

This PR adds the Slurm sbatch script to run LAMMPS with the same configuration as we ran on GKE and Lassen as well as the output data from the LAMMPS runs.

Thank you!


feat(geo): add geo device location tracking walkthrough

Description of changes
Add create, update and remove walkthrough for geo device tracking with advanced settings

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[x] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[x] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sreeramsama there are merge conflicts now that need to be resolved - are you still working on this?

@sreeramsama there are merge conflicts now that need to be resolved - are you still working on this?

Not actively working on this PR as it is currently blocked. We are going through internal discussions in our team on some authorization design changes. There may be some changes we want to make on top of this PR.

@sreeramsama would you be able to close this PR and reopen with your changes when you are ready? The PR has already gotten stale.

Sure, that works. Will close the PR for now and re-open when we start actively working on it.


fix ice map full

RTC-12666 TCP Fallback during load
Fix for this. Main problem was that pending stun transaction map in UdpEndpoint became full. It is cleared at call shutdown but all failed candidates will create a number of transactions that are not cleared until end of call.
The fix is that stun requests, that will result in responses from ports that are routed anyway to the transport, do not need to be tracked by transacation id. Also, all transactions are cleaned up and earlier.

Regarding internalIceReceived, I guess we could ignore it for invalid response. but for invalid request we are supposed to send a response. In that case I prefer if it is constructed in IceSession.


mock testing facility ui

https://github.com/CDCgov/prime-central/issues/118

A big plus-one for the better names! There are still places using the old names in the frontend, OrderingProviderSettings.jsx and Settings.jsx, those need to be modified as well.
In general there seems to be a lot of boilerplate surrounding the data here, we need to mention the same fields in literally two dozen places. I wonder if that's inherent to the graphql approach or more about the way we're using it.


413 Request Entity Too Large for URL

Guys, I am getting the enclosed error when uploading specific files (also enclosed). I dont know if it has to do something with the extension, however jpeg and other files work perfectly fine. Its just that some do not work. I did not any kind of restriction (size, file extension). Also I dont know where the error is raised in the code. Any clue where to look at?
Many thanks - you guys are awesome!

I think you have to check web-server (nginx, apache or something) configuration. Mostly this type of errors caused by server misconfiguration.

As you can see here https://github.com/Bearle/django_private_chat2/blob/master/django_private_chat2/views.py#L104
Currently, no file size limit is enforced.

Thanks guys. Indeed it was the web-server config. Nginx limits the upload by default. In case anyone runs into the same error, I solved it adding these lines to the config: https://www.tecmint.com/limit-file-upload-size-in-nginx/


INT-2035 Simple Cookie Handling

Saves off Set-Cookie header in http_transferredCookie MessageHeader.
Transferred cookies are converted to Cookie: headers on subsequent
outbound messages.

This looks great. The only thing that made me pause a bit is the fact that we have to add TRANSFERRED_COOKIE to the "standard" request and response HTTP headers. As far as I know, that is now the only constant in the group that is not actually defined in the HTTP spec. That said, I don't know if there is any way to avoid it... basically this is specialized treatment of the "cookie" and "set-cookie" headers defined in that spec.
Gary, any ideas?... or do you think it's not a valid concern?

Hmmm... I see what you are saying.
After I issued the PR, I did actually think of leaving it as 'Set-Cookie' (but normalized to I didn't have to deal with the case-sensitivity of MessageHeaders like I had to in my first pass at this).
In other words, let Set-Cookie always be mapped in both directions (normalized to 'Set-Cookie'), but on the outbound side
a. Map it to 'Cookie' if transferCookies is true
b. Remove it of transferCookies is false
What do you think?

That sounds a bit cleaner in terms of keeping only the 'standard' headers in the HTTP_REQUEST_HEADER_NAMES and HTTP_RESPONSE_HEADER_NAMES lists. Do we lose any functionality at all with your proposed change? (such as when passing cookies across a chain of multiple request/response operations)

No, it will have the same functionality.
My only real concern is the need to normalize the header name. It means we'll take that overhead on every request. By using a known header name, we avoid that overhead. The problem is that if it comes in as set-cookie (instead of Set-Cookie), I won't find it in MessageHeaders on the way back out.
I suppose another alternative would be to move the TRANSFERRED_COOKIE out of the 'standard' headers arrays and add an additional test for it. That would be much less overhead.

Actually - I think I can do it without any extra overhead - I'll make a patch and push it...

Turned out to be much simpler to map Set-Cookie to Cookie on the inbound side.
Probably easiest to look at the total DIFF rather than this commit separately.
We should squash these commits before merging.

Okay. I'll squash locally before merging and give that one last look. Thanks.

Oops  - forgot schema docs


foldOrEmit beyond builtin.unrealized_conversion_cast

alternative to PR #1948 to fold constants hidden by builtin.unrealized_conversion_cast
see discussion in PR #1948

This way looks better than #1948. Thanks!

Jenkins Linux ppc64le Build #8340 [push] foldOrEmit beyond builti... started at 10:47

Jenkins Linux s390x Build #9294 [push] foldOrEmit beyond builti... started at 10:44

Jenkins Linux amd64 Build #9276 [push] foldOrEmit beyond builti... started at 09:44

Jenkins Linux amd64 Build #9276 [push] foldOrEmit beyond builti... passed after 1 hr 6 min

Jenkins Linux s390x Build #9294 [push] foldOrEmit beyond builti... passed after 1 hr 29 min

Jenkins Linux ppc64le Build #8340 [push] foldOrEmit beyond builti... passed after 1 hr 47 min


RDB Loader: rewrite StorageLoader in Scala, removing file archiving step

Currently in JRuby.

Changed ticket name @chuwy so CHANGELOG and release notes are internally consistent


iOS build submitted using App Center does not work on TestFlight (but works if submitted through XCode)

I have a React Native project that I'm building for iOS. I have created a "
iOS Distribution (App Store and Ad Hoc)" Certificate and an App Store Distribution provisioning profile. I've added the newly created Certificate to the provisioning profile and set the App ID to explicitly match exactly.
I'm trying to distribute the app using TestFlight but having an issue. If I create an archive using XCode and distribute to TestFlight using XCode the app installs and runs. However, if I send the same certificate and provisioning profile and use App Center to submit to TestFlight, it successfully processes the app but when I attempt to run the app it crashes. I don't understand what the difference could be that is leading to this issue. Any idea or lead would be helpful.
Thank you

Hi @myblueprinteric, can you contact App Center support  so we can better troubleshoot this please? We'll need some additional information to understand the cause of this issue.


[dtls] fix undesired kernel filtering of connected UDP

This commit fixes again the same issue which was fixed by https://github.com/openthread/openthread/pull/8168 with the same approach.
The regression was unintentionally introduced by the initial TCAT commit https://github.com/openthread/openthread/pull/9210
See https://github.com/openthread/openthread/pull/8168 for the background and discussion.

TODOs may be adding CI tests to make sure MeshCoP commissioning never fail across network links.

@canisLupus1313 I am removing you from the reviewer list as we are currently blocked by this. Please take a look if this breaks any TCAT use cases so that we can find a proper fix later.


Fix auto-fixing of deprecated interpolated strings

Fixes #6935

Note I also added a completely unrelated test, demonstrating that pizza and "task await bang" now compose correctly (at least in the syntax tree)


Replace type punning with memcpy.

The type punning in the existing code is undefined behaviour in C.
In particular, the existing code fails when running on Arm Cortex-M devices.
On Cortex-M, accessing a uint64_t that is not 8-byte aligned generates a hard fault.
The GCC bugs page (https://gcc.gnu.org/bugs/) Non-Bugs/C/Casting section provides a good explanation of why "Dereferencing a pointer that violates the aliasing rules results in undefined behavior."
@manupa-arm @areusch @liangfu

@grant-arm this looks great! want to add a unit test in tests/crt?

@grant-arm this looks great! want to add a unit test in tests/crt?

@areusch can you explain a bit more on how to test the changes brought in this PR?

@liangfu @grant-arm it seems like we should be able to call TVMNDArray_Load() with strm non-aligned. Specifically, malloc a buffer for strm that's WORD_SIZE -1 larger, then intentionally choose a starting point for strm that isn't word-aligned.

@areusch I think we can still call TVMNDArray_Load() with strm non-aligned. Its just that when de-referencing a pointer to non word-aligned location -- we should do it under memcpy so that it does what required based on the target architecture. Inside TVMNDArray_Load, I think data is already accessed via memcpy and its just some metadata such as shape are the ones directly de-referenced. Was that your concern ?
I think this might trigger a compiler warning (-Wcast-align) and a runtime error in some platforms. Therefore, depending on whether this fix clears away all cast-align warnings, we might be able to use -Wcast-align=strict which makes the warning appear for x86 too, if we are using gcc 8 or higher. If this is the case, we might be able to create a failing compilation test case using build_static_runtime ?

@manupa-arm @grant-arm it seems to me that this change is replacing pointer dereferences to **strm with memcpy. this is the correct thing to do, so now we just need to test it. the issue now is that it compiles fine, but at runtime would trigger an unaligned load. this issue should be present across platforms. I think we could write a test that intentionally calls TVMNDArray_Load with unaligned strm. i'm not suggesting we need to test every single case of mis-alignment, but a single test that calls TVMNDArray_Load with unaligned strm should be sufficient to trigger the failure without this patch.
now as to producing unaligned strm: I'm suggesting we malloc a block larger than we need, add n bytes to the pointer (n = 7 - ((uintptr_t) ptr) & 0x7), and fill that location with valid strm. then pass to TVMNDArray_Load.

@manupa-arm i'm not super-familiar with -Wcast-align=strict and its availability cross-platform. we could try adding it to the CFLAGS and see, though...I guess that should catch cases like this. i'm not sure if we have other cases where we have assumed this but it is in practice fine, though.

@tmoreau89 want to merge?


Styling for building:part=*

Status quo
Thanks to https://github.com/openstreetmap/iD/issues/6186 and https://github.com/openstreetmap/iD/issues/6114 and Quincy's code building:part is now rendered ans an area, which makes it a lot clearer to handle. Thanks!
Example: http://preview.ideditor.com/master/#background=Berlin-2018&disable_features=boundaries&id=w646475990&map=19.00/52.47219/13.44733

Improvement
However, I think the styling for building:part could be improved.
My issues are:

Layering: Those areas will by definition always layer over the original building. But only the building should hold the tags like address. So right now, I cannot get to the building without deleting parts of it; but then I cannot modify the building since I just deleted stuff …
Design: The parts are rendered transparent white. Which makes those buildings "softer" and "lighter" in their appearance when in fact they have "more" mapping/layers, so they should feel "heavier".
Rendering: A building is (in the default mode of iD "Fill areas > Partial fill") rendered as line with thicker inner line; the building part is just an area.

Suggestions:

Render the building:part with a darker red layering the red of the building, eg rgba(165, 64, 50, 0.3) + corresponding border-color
Render the building:part with a stroke, eg  stroke-width: 30px that is similar but thinner to the building
Use this stroke always, even in "Fill areas" > "Full fill"

This way I should be able to click the building below the buidling:part though the wholes of the building:part, right? I will also see the building-rendering below the building:part rendering and understand the building:part as an addition to the building.
Another idea where to add a filter for "Building Parts" to the "Map Features" selection. However, this will just case new problems like non-aligned buidling:parts, which in turn where to need a validator…

I can also not really appreciate the new style (yet?) ...
All those rendered areas makes it visually really hard to see whats going on, with the simple lines before it was much clearer IMHO.
Worse is also that those areas overlay over the actual building, hence making it much harder to map details on the building itself. So by tagging building:part the actual work becomes much harder... :disappointed:
That you cannot select the (whole) building anymore is a showstopper bug.
(Sorry, to be so negative but I really don't know how to express this otherwise.)

Another idea where to add a filter for "Building Parts" to the "Map Features" selection. However, this will just case new problems like non-aligned buidling:parts, which in turn where to need a validator…

Yeah I'm kind of tending towards just adding another filter so people don't have to see them.
It's a bit complicated too because I sometimes see people adding both building=* and building:part=* on the same way (I guess the building footprint?)

It sure would be nice to sort out editing of overlapping features (#1239, #2225). Currently, it is possible to edit coincident points by lassoing them and deselecting other points from the selected feature list. But unfortunately lassoing only selects nodes, not their parent ways.

Yeah I'm kind of tending towards just adding another filter so people don't have to see them.

The disadvantages are IMO

less experienced users will likely not know that the "real" building is below
less experienced users will not know that there is a filter option to get to it
and in the end, once they use the filter, we will likely end up with building-parts that don't follow the building-geometry anymore; which we could validate, but this would be one of those "there is an error but you will not know how to fix it"-cases

Very similar arguments go against an idea to use, what JOSM does (according to this). – How would I as a user discover such a feature?

Tip: Overlapping shapes like this can be tricky to select. In JOSM, click while holding down 'Alt' key to cycle through overlapping objects and make the selection you want.

Btw: For GoMap!! one can long-tab on an element to get a list of objects from which to choose. Also a hidden feature that you only discover when you know, there is an issue otherwise.

But that leads me to another idea:
Could iD detect, that once I click a thing that another thing is below. And then …

either: show a note in the left sidebar "you selected the building-part (or …) but there is a (LINK)building(/LINK) right below it."
or: multi-select both right away and automatically an thereby show the multi-select section in the left sidebar. Maybe with a message above like "There are objects right above eachother, which do you want to select?". Which would explain whats going on and allow me to get to the element I like.

Both would also solve the cases that 1ec5 referenced above and also https://github.com/openstreetmap/iD/issues/6162#issuecomment-482001875 ("And even then, having two lines right above one another is a pain, so that would not help.")

It's a bit complicated too because I sometimes see people adding both building=* and building:part=* on the same way (I guess the building footprint?)

That is interesting. https://taginfo.openstreetmap.org/keys/building#combinations says:

4.52% of building:part also have building
0.01% of building also have building:part (39 884x)

However, I don't see any reference to this tagging in the wiki (https://wiki.openstreetmap.org/wiki/Key:building:part, https://wiki.openstreetmap.org/wiki/Simple_3D_buildings#Building_parts), so this might be a case for a live-validator which suggests to clean up the tagging (details tbd).

multi-select both right away and automatically an thereby show the multi-select section in the left sidebar. Maybe with a message above like "There are objects right above eachother, which do you want to select?". Which would explain whats going on and allow me to get to the element I like.

Yeah, this is what I also had in mind in https://github.com/openstreetmap/iD/issues/2225#issuecomment-354593457, but adding a prompt makes a lot of sense, since the user may wind up with this list unexpectedly, unlike after lassoing.

Speaking to the original issue of building part styling: I made the building:part partial fills thinner, as recommended, and indoor areas thinner still. This definitely helps for busy buildings like this.

I don't think we should keep this for full fills though, since we'd be introducing inconsistent behavior. I agree with Bryan that we should just add filters.
Leaving this issue open so we can still consider the colors.

Speaking to the original issue of building part styling: I made the building:part partial fills thinner, as recommended, and indoor areas thinner still. This definitely helps for busy buildings like this.

I don't think we should keep this for full fills though, since we'd be introducing inconsistent behavior. I agree with Bryan that we should just add filters.
Leaving this issue open so we can still consider the colors.

This is zoomed in quite a bit. What does it look like from farther away?
Btw: http://localhost:8080/#map=20.09/39.75318/-105.00004 doesn't load for me .. ;-)

@famo My mistake! I updated the link.
The new widths are still somewhat helpful when zoomed out but I think most people would be zoomed in.

Thanks for this update, quincylvania. IMO the editing works fine now!

I can see that there are areas above eachother
I can select the buidling-area below the building:party

About the styling:
What are your thoughts on the color? You prefere the current white over a building-style color?
I suggest:

indoor - IMO the white is fine here, it makes it stand out from the building which I think is good
buidling:part - a tone of red like the building but a bit darker:

.fill-partial path.area.fill.tag-building_part {
    stroke-width: 40px;
    stroke: rgba(121, 39, 39, 0.3);
}

Re: Styling
I have to squint really hard to differentiate those two reds...
What about a style with hachure or intermittent (like construction)? Building:parts aren't rendered anyways, so I think its ok/good to deviate from the building style...
Re: Indoor
I'm hoping for #6225 (hint, hint ;-) ...

What about a style with hachure or intermittent (like construction)?

I've been leaning this direction. The fills will necessarily overlap so I think it'd look better to use a pattern for building parts instead of just a color.


Fix printf markers [phab:D1616]

Created by schroederc at 2017-05-04 18:38:59:

fromberger accepted this revision at 2017-05-04 18:45:38

schroederc closed via commit 9e1309165656dbdb4feeff2f84cf1d6b8aa39549 at 2017-05-04 18:46:17


Non-concrete fields creates malformed SQL on upsert

First, thanks for this library and all the other django<>postgres libraries, it's super clean and useful. I love and am using pglock as well!
I've tried to use pgbulk.upsert on a model with a virtual/proxy field. Specifically, I'm using hashids with a field declaration like the following:
public_id = HashidsField(real_field_name="id", min_length=6)

When calling upsert with this field present, I get an error like the following:
django.db.utils.ProgrammingError: syntax error at or near "None"
LINE 1: ...:numeric(5, 2), 'some string'::text, NULL::None), ('2...

It appears the translation from field definition to SQL is incorrect, indicated by the NULL::None in that error message.
Removing the virtual field resolves the issue. Excluding the field via upsert's  exclude has no effect unfortunately.

Fix was straightforward, addressed in #30

This also applies to the new GeneratedField in django > 5.0 for postgres. In that case the field has the attribute concrete = True but  also generated = True.
I will also create a PR for that case. We'll see how this goes.

Thanks for the PR for the fix @dalberto ! I will go ahead and ensure that generated fields are tested as well @awmath. Will close this issue and report back when deployed.

Fixed in v2.4. Generated fields are supported too


Cannot login in successfully

I built it on my VPS and It can be visited at https://huginn.voleking.me now.
However I cannot login in successfully with USERNAME admin and PASSWORD password ( I  haven't changed it before).

bundle exec rake db:seed?

Oh, it looks like the site is down. Is the Huginn process running on the server?

@cantino Yes, please wait a minute. I'm trying to fit it by myself and now it may takes some time to reproduce this issue

@cantino My site is up now! Thx.

This information may help. When I reboot my VPS, I got this issue #1618: Huginn failed to restart.
/etc/runit/2 & don't work now and I reinstall runit to fix it.

There are many issues install from source. I would like to use docker.
@cantino Thx

Sorry it was complicated. I agree Docker is a better solution than installing from source these days.

Yes, install with docker is much more easier and I can explore Huginn now! BTW, Thanks a lot.


Certificate encryption parameters are explicitly shown on whether they are available

Looking at the current documentation, it is not clear what the proper certificate configuration needs to be

there's no encryption support on node-turn for now


Update ES translation + change recalbox.fr to .com

Thanks, i'll merge as it is a bug correction :)


No shapes in profilings by default

Disable shapes in profiling by default

https://github.com/huggingface/optimum-habana/pull/1050/


[#4062] feat(iceberg-rest-server): support RegisterTable for Iceberg REST server

What changes were proposed in this pull request?

upgrade Iceberg version to 1.5.2
support register table interface for Iceberg REST server

Why are the changes needed?
Fix: #4062
Does this PR introduce any user-facing change?
no
How was this patch tested?

add UT and IT
test in local env

@jerryshao please help to review when you have time

@jerryshao @jerqi , comments are addressed, could you help to review again?


Web App Bot no longer exists in Azure portal, doc is not in sync

Hello,
It looks like the wizard to create a bot has changed in the Azure portal.
There is no Web App Bot anymore in the Create new resource wizard.
Would be good to see this adapted, or linked to a newer version

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bfbfbd93-0056-6d8b-8ee1-f7d0c6d0a739
Version Independent ID: b52c7b72-d512-d172-6569-b289e05302e6
Content: Tutorial: Language Understanding Bot C# v4 - Azure Cognitive Services
Content Source: articles/cognitive-services/LUIS/luis-csharp-tutorial-bf-v4.md
Service: cognitive-services
Sub-service: language-understanding
GitHub Login: @aahill
Microsoft Alias: aahi

@SamVanhoutte we'll review your feedback and get back to you shortly. Thanks.

Thanks for pointing out this issue. That article seems out-of-date, and we'll take them down shortly.
I would recommend following the article here, in the Bot Framework documentation: https://docs.microsoft.com/composer/how-to-add-luis?tabs=v2x
#please-close