Issues with X.A.TreeSelect

Problem Description
Describe the problem you are having and what you expect to happen
instead.
Steps to Reproduce
Give detailed step-by-step instructions on how to reproduce the problem.
Set ts_node to 0xff00ff00 which should be green but it appears as blue, and the other way round
Configuration File
Please include the smallest configuration file that reproduces the
problem you are experiencing:
The green and blue colors are swapped in the field for the foreground color
tsConfig :: TSConfig a
tsConfig = TSConfig
    { ts_font = myBoldFont
    , ts_node = (0xffebb2db, 0xff1d2021)
    , ts_extra = 0xffebb2db
    , ts_indent = 80
    , ts_originX = 15
    , ts_originY = 15
    , ts_nodealt = (0xffebb2db, 0xff1d2021)
    , ts_highlight = (0xff1d2021, 0xffb16286)
    , ts_background = 0xff1d2021
    , ts_node_width = 200
    , ts_node_height = 25
    , ts_hidechildren = True
    , ts_navigate = defaultNavigation
    }

I have set the foreground to 0xff00ff00

and here I have set it to 0xff0000ff
Also when picom is running the treeselect menu goes invisible, this is pretty simple to reproduce.
I'm running the git version of both XMonad and XMonad-Contrib, that probably matters as well.
Checklist

[x] I've read CONTRIBUTING.md

[x] I tested my configuration with xmonad-testing

nvm I will pr


fix: negated and reflexive verbs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

97 of 100 (97.0%)  changed or added relevant lines in 6 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.2%) to 92.512%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/verb/conjugationVerb.ts
27
30
90.0%

Files with Coverage Reduction
New Missed Lines
%

src/verb/conjugationVerb.ts
1
88.59%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1703

Relevant Lines:
1781

💛  - Coveralls


Is there are way to access EditorState?

Firstly. Thank you for sharing this Svelte component. It makes it a lot easier to use CodeMirror out of the box.
I'm trying to add my own autocomplete suggestions but I'm struggling to understand CodeMirror's documentation. If I understand it correctly, EditorState is needed to pass through as a CompletionContext. If this is correct is there a way to get the EditorState from svelte-codemirror-editor?
https://codemirror.net/docs/ref/#autocomplete.CompletionContext

Hi. Thanks for letting me know about this. The code I proposed didn't work unfortunately so I created an instance from scratch. When I get chance I'll try the new event. Thanks you!


Implement facial mapping of a dental image on the web

Using the clm algorithm provided from clmtrackr.js, we'll fit a facial model to the webcam video stream.
We'll implement a texture mapping of dental DICOM image onto the model, similar to the example found at https://auduno.github.io/clmtrackr/face_mask.html .

~ Some References ~
A detailed documentation about the inner workings of the CLM (Constrained Local Models) algorithm https://sites.google.com/site/xgyanhome/home/projects/clm-implementation/ConstrainedLocalModel-tutorial%2Cv0.7.pdf?attredirects=0
The original paper of the CLM algorithm: http://dl.acm.org/citation.cfm?id=1938021
Git repo of clmtrackr.js, a javascript implementation of the CLM algorithm: https://github.com/auduno/clmtrackr

Hi @sacdallago !
After researching and reading up on different computer vision library on the web this past week, I've decided on going forward with the CLM algorithm because it is the most readily available implementation for face swapping. I've read into details of its implementation, discussed it with @hesamrabeti and understood it enough to start implementing this coming week! I'll also be moving in to a new apartment by tonight with constant internet, so I shall be able to code and check them in more consistently. Please let me know if you have any other concerns! (:
Cheers,
Faye


Prevent "Back" button functionality on Gateway for additional security

On the "Portal" langing page, near the bottom, when a web visitor clicks the "Logout" link (or clicks "Home" from the menu in the nav-bar anyhere elsewhere on the site) and the web visitor is directed to "Gateway" page, clicking the Back button in the web browser should not be possible. Like, on the "Gateway" page, the web visitor should not be able to return to their previous location by pressing Back and instead should always be required to submit their passphrase again to return to the website.

@abubakarA-Dot: I merged your PR #202 into master and pushed it up to Heroku both pipelines: staging and prod. The issue persists. When clicking on "Logout" on the portal page or "Home" in the navbar on one of the other pages, Django serves the gateway template but clicking "Back" is still permitted by Django when it should not be. You can see here:

https://tarot-prod.herokuapp.com/
https://tarot-testing.herokuapp.com/

(Passphrase to copy and paste = YourMagicPassphrase.)
You mentioned that the problem could be with middleware not updating. How does that work when I am certain that I've merged your changes into master and pushed all of it (middleware included) up to Heroku? Is there a way to look at the middleware on Heroku to verify that the latest middleware changes are reflecting?
To test these changes I'm using Microsoft Edge and have cleared the cookies and all website cache data. So it's perfectly clean.

Hi @enoren5
I have checked it on both pipelines, and only the logout feature is working on the testing pipeline and no other feature is working.
Please let me look into it and fix it properly so that it can work on live server as well.

Resolved in PR's #202, #204, #205


Listen for changes

Is there any way you can listen for changes made in your Firebase database with this gem? So when a new user signs up using their iPhone and that user gets saved in the database, then the I would now it in my Ruby app using this gem?

firebase-ruby just interacts with the Firebase REST API - it doesn't do real-time, which is hard to do in a fairly synchronous language like Ruby. Such a feature is probably out of scope for this gem.


Validate DelimFile headers

Adds validation to parse DelimFile headers.
Concerns and Qs:

I think we still get a bad deserialization error for a degenerate TSV with an empty header but non-empty body with an incorrect delimiter.
Is this too hacky?

I think we still get a bad deserialization error for a degenerate TSV with an empty header but non-empty body with an incorrect delimiter.

If this is still the case, could you add a test for it?

Re alison's comment is addressed by test_header_missing in lib.rs


Drop shadow or other visual indicator that the navigation/filter is separate from the feed below it

Issue 15 https://github.com/near-daos/astro-ui/issues/91

Verified on dev. Fixed


Feat toggle content show

PR Type

[ ] Bugfix
[x] Feature
[x] Refactoring

Context

[x] Closes #7005
[ ] Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

[x] my DOT address: Payout

Community participation

[x] Are you at KodaDot Ecosystem Telegram?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 1f1c472
Refactor MediaItem.vue to use Vue 3 script setup and NeoButton component, and add translation key for hideContent label. These changes improve the user experience and the code quality of the media item component.

🤖 Generated by Copilot at 1f1c472

MediaItem shines
With script setup and button
Autumn of refactor

last round of changes from me

@daiagi  very appreciate for spending lots of time to review my code and give me useful advices

@prury please test once again

looks good on dark/white mode, desktop and mobile ✔

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.46 USD/DOT ~ 11.211 $DOT
🧗 12jXHf7yYF4wTRjDPbwFB24V1nVRPRkuU2S8Ke5ZWTfvyBGW
🔗 0x351b807993fc80bdf91da300bb37da09d6a6daf0b13c49d506dc4ae9df541de5
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


ADB problem

Hello,
is there a way to fix this problem? I'm on Android 9 on Umidigi F1.
Thanks

(please copy-paste text instead of screenshot, so it's searchable)
You have a software installed on your computer that executes adb commands with an old version of adb (31). Since this is not the same version, the adb daemons just kill each other.
Find this software and make it use the same version of adb as scrcpy (version 31 is very old).

Thanks for the hint, now the adb version error disappeared but I'm still having the others:
ERROR: Could not open video stream
ERROR: Exception on thread Thread[main,5,main]
java.lang.IllegalStateException
at android.media.MediaCodec.native_stop(Native Method)
at android.media.MediaCodec.stop(MediaCodec.java:2084)
at com.genymobile.scrcpy.ScreenEncoder.streamScreen(ScreenEncoder.java:75)
at com.genymobile.scrcpy.Server.scrcpy(Server.java:28)
at com.genymobile.scrcpy.Server.main(Server.java:110)
at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:340)
INFO: Initial texture: 1080x2336
Press any key to continue...
What am I missing?

Your hardware encoder is probably not able to encode at this definition/resolution.
Try to reduce the definition:
scrcpy -m 1024

That was the problem, with - m 1024 I can mirror my device on pc. Thanks for the support!


hawkular-metrics not working in GCP deployment

From a recent master with some patches to support CentOS/Origin.  I set these in config.yaml
openshift_hosted_metrics_deploy: true
openshift_hosted_metrics_storage_volume_size: 20Gi

Deployment seemed to go fine but when log into the console there is a banner (toast?) about a problem with metrics.  Digging deeper I find there are two pods that are not starting correctly due to problems with arguments.
Logs for openshift-infra/ hawkular-metrics shows:
2017-06-08 17:49:45 Starting Hawkular Metrics
unable to write 'random state'
unable to write 'random state'
The --truststore_authorities value is not specified. Aborting

Logs for openshift-infra/hawkular-cassandra shows:
The --truststore_node_authorities value is not specified. Aborting
  containers:
    - name: hawkular-metrics
      image: 'docker.io/openshift/origin-metrics-hawkular-metrics:latest'
      command:
        - /opt/hawkular/scripts/hawkular-metrics-wrapper.sh
        - '-b'
        - <IP_ADDRESS>
        - '-Dhawkular.metrics.cassandra.nodes=hawkular-cassandra'
        - '-Dhawkular.metrics.cassandra.use-ssl'
        - '-Dhawkular.metrics.openshift.auth-methods=openshift-oauth,htpasswd'
        - >-
          -Dhawkular.metrics.openshift.htpasswd-file=/secrets/hawkular-metrics.htpasswd.file
        - >-
          -Dhawkular.metrics.allowed-cors-access-control-allow-headers=authorization
        - '-Dhawkular.metrics.default-ttl=7'
        - '-Dhawkular.metrics.admin-tenant=_hawkular_admin'
        - '-Dhawkular-alerts.cassandra-nodes=hawkular-cassandra'
        - '-Dhawkular-alerts.cassandra-use-ssl'
        - '-Dhawkular.alerts.openshift.auth-methods=openshift-oauth,htpasswd'
        - >-
          -Dhawkular.alerts.openshift.htpasswd-file=/secrets/hawkular-metrics.htpasswd.file
        - >-
          -Dhawkular.alerts.allowed-cors-access-control-allow-headers=authorization
        - '-Dorg.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true'
        - '-Dorg.apache.catalina.connector.CoyoteAdapter.ALLOW_BACKSLASH=true'
        - '-Dcom.datastax.driver.FORCE_NIO=true'
        - '-DKUBERNETES_MASTER_URL=https://kubernetes.default.svc.cluster.local'
        - '-DUSER_WRITE_ACCESS=False'
        - '--hmw.keystore=/secrets/hawkular-metrics.keystore'
        - '--hmw.truststore=/secrets/hawkular-metrics.truststore'
        - >-
          --hmw.keystore_password_file=/secrets/hawkular-metrics.keystore.password
        - >-
          --hmw.truststore_password_file=/secrets/hawkular-metrics.truststore.password
        - '--hmw.jgroups_keystore=/secrets/hawkular-metrics.jgroups.keystore'
        - >-
          --hmw.jgroups_keystore_password_file=/secrets/hawkular-metrics.jgroups.keystore.password
        - '--hmw.jgroups_alias_file=/secrets/hawkular-metrics.jgroups.alias'

Looks like this upstream commit broke it for us:
https://github.com/openshift/origin-metrics/commit/1d53374890326415e15765323b487b20cab88877#diff-055c992974a33b91b5c3fff3576e9310
And it looks like this upstream commit will fix it:
https://github.com/openshift/openshift-ansible/commit/792fd2f34ec394574d25ce7b2819e27b4f1e04ef

So the images pulled are tagged latest.  This doesn't seem safe.  I'm going to workaround by using the image tagged v1.5.1 instead.

I'm not sure, I was able to work around the problem by adding this to my config.yaml:
openshift_hosted_metrics_deployer_version: 'v1.5.1'

With 3.6 plus some other fixes in this repo metrics are now working fine on GCP. If you still see the error message, follow the link in that message and accept the self-signed certificate for hawkular url. Then reload OCP console and the error should be gone.


[Overview] Community-developed tools regarding event registration

As this is a repository about ideas and wishes of the community, I'm creating this overview here as a space for the community to share its implementations of tools related to the new check-in functionality, specifically after @MaZderMind announced the first library in https://github.com/corona-warn-app/cwa-wishlist/issues/399#issuecomment-824595108 (many thanks).
I am hoping that the community is going to create many more useful tools for different platforms, with bulk creation, periodic regeneration, and further creative ideas.
If you have created such a tool, please contact me through this issue or otherwise so that I can add it to the overview.
End-user applications

Name
Repository
Website
Platform
License
Maintainer

There are no end-user applications (including websites, desktop programs, etc.) specifically for the creation of custom QR codes so far. Be the first to create one! ;)
Libraries

Name
Repository
Language
License
Additional information
Maintainer

cwa-event-qr-code
https://github.com/corona-warn-app/cwa-event-qr-code
NodeJs
Apache

@mlenkeit

cwa-qr
https://github.com/MaZderMind/cwa-qr
Python 3 (and 2)
MIT License

@MaZderMind

cwa-qr-api-server
https://github.com/fkusei/cwa-qr-api-server
Python (Flask)
none
Flask wrapper around cwa-qr (https://github.com/corona-warn-app/cwa-wishlist/issues/474#issuecomment-825100485)
@fkusei

@MaZderMind Wiki pages are not enabled in this repo – I am guessing creating a wiki here (and allowing the community to edit it) would be a hassle, as CWA as a project cannot recommend other projects without approval from many instances.
I added the project you mentioned to the overview.

Also, it's quite hard for the community to maintain the wiki. See https://github.com/corona-warn-app/cwa-documentation/issues/499#issuecomment-762750994

FYI https://www.coronawarn.app/en/blog/2021-04-23-qr-code-generator/

FYI https://github.com/corona-warn-app/cwa-event-qr-code


Refactor launch_workstation functions to lib in preparation of switching to CloudTrail

launch_workstation temporarily removed in preparation for incident_pony releasing later


Bundle Installation

I have installed the bundle on my pc and everything go well, but when my team mate try to install the project,he got a problem with this bundle(liuggio/excelbundle)  , the composer don’t install the bundle in the vendor folder and that’s why my team mate should run :
“composer require liuggio/excelbundle” command.
Any help? Any idea ?

@Mohammadtrabelsi What's the command you run?

@liuggio hi!
After searching I think that the bundle is not compatible with PHP7. because on my PC "PHP5.6" every think go well and my friend "PHP~7.0" got a problem when downloading the project.

please @Mohammadtrabelsi can you improve this project moving to php7?


remove unsupported online trainer

After refactoring PR in https://github.com/sustainable-computing-io/kepler-model-server/pull/102, online-trainer becomes out of track upon current release.
To avoid incompatibility, this PR removes the instruction related to online trainer deployment until we  the online trainer component.
Signed-off-by: Sunyanan Choochotkaew<EMAIL_ADDRESS>

@sthaha Thank you for the review and approval.
I also add a below change to fix the issue https://github.com/sustainable-computing-io/kepler/issues/1306#issuecomment-2008080389. If you are good with that, I will merge the PR.
https://github.com/sustainable-computing-io/kepler/issues/1306#issuecomment-2008080389


…

Specify the tensorflow-probability==0.7.0 when installing Magenta,
Since they released the  tensorflow-probability 0.8.0 and it doesn't support tensoflow 1.14.0, it needs 1.15.0 to run. However there's no tensorflow 1.15.0 currently and it raises an error:

Traceback (most recent call last):
File "/Users/dainguyen/anaconda3/envs/magenta/bin/melody_rnn_generate", line 6, in
from magenta.models.melody_rnn.melody_rnn_generate import console_entry_point
File "/Users/dainguyen/anaconda3/envs/magenta/lib/python2.7/site-packages/magenta/init.py", line 26, in
import magenta.common.beam_search
File "/Users/dainguyen/anaconda3/envs/magenta/lib/python2.7/site-packages/magenta/common/init.py", line 20, in
from .nade import Nade
File "/Users/dainguyen/anaconda3/envs/magenta/lib/python2.7/site-packages/magenta/common/nade.py", line 24, in
import tensorflow_probability as tfp
File "/Users/dainguyen/anaconda3/envs/magenta/lib/python2.7/site-packages/tensorflow_probability/init.py", line 68, in
_ensure_tf_install()
File "/Users/dainguyen/anaconda3/envs/magenta/lib/python2.7/site-packages/tensorflow_probability/init.py", line 65, in _ensure_tf_install
present=tf.version))
ImportError: This version of TensorFlow Probability requires TensorFlow version >= 1.15; Detected an installation of version 1.14.0. Please upgrade TensorFlow to proceed.

With 0.7.0, it's ok to proceed

@googlebot I signed it!


Fixed a casing issue

Previously I have processmodel.idletimeoutaction and it was always trying to apply my changes when it saw a difference but it would never actually make the change.  I finally noticed that casing matters and it needs to be processmodel.idleTimeoutAction.  I corrected that as well as also added the check to test to see if the value was NOT undefined.
if $apppool_idle_timeout_action != undef

hey @gigadafud, thanks for the PR! Could you please rebase against latest master?

it's deeply fascinating how quickly our prs become unmergable :P

@gigadafud it would also be good to add spect tests to cover this functionality

Rebased in #145


WIP: add elementpointmove interaction

add elementPointMove

[ ] line add

[x] 折线图可用
[ ]  雷达图可用

[ ] interval add

[x] 柱状图可用
[x] 条形图可用
[ ] 饼图可用

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

68 of 201 (33.83%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.9%) to 86.854%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/interaction/elementPointMove.ts
67
200
33.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.9%

Covered Lines:
10221

Relevant Lines:
11400

💛  - Coveralls


ZCL_EXCEL_WORKSHEET -> CONVERT_TO_TABLE wrong results if empty lines

Method ZCL_EXCEL_WORKSHEET -> CONVERT_TO_TABLE might return wrong results if IV_BEGIN_ROW is an empty line in the worksheet.
    READ TABLE me->sheet_content TRANSPORTING NO FIELDS WITH KEY cell_row = iv_begin_row.
    IF sy-subrc EQ 0.
      lv_index = sy-tabix.
    ENDIF.

    LOOP AT me->sheet_content ASSIGNING <ls_sheet_content> FROM lv_index.

If IV_BEGIN_ROW is an empty line and there are non-empty lines before, then READ TABLE does not find the entry and subsequent loop starts from 0 instead from worksheet line >= IV_BEGIN_ROW and adds the non-empty lines < IV_BEGIN_ROW.

Planning to fix this together with change for Issue 1195

See issue 1195 suggested coding change.


Make test_retrieve_jobs_with_deprecated_api test use the default pool.

Changes proposed in this PR

Make test_retrieve_jobs_with_deprecated_api test use the default pool.
Make the wait check if the job is running run less often.

Why are we making these changes?
Having it run on this pool makes it more reliable. We use the default pool for other tests so the resources are likely to be available immediately. This also cuts the logging verbosity by a lot if/when the test fails.

Will merge when 🟢


CustomizableHeatMapDetail has issues

@Elichartnett depending on the number of rows and columns there are sometimes empty rows and columns:

Any clue how to clean this up?

Looking into setting custom ranges for the x and y axis

@Elichartnett can you add the row and column steppers as an extra section below the chart like in the line chart example?


iOS app not opening when integrating Unity app with AltUnityTester

Hi, I am trying to test the Unity Application on iOS device via appium + altUnity tester, but after integrating AltUnity Tester in the Unity Project, whenever I launch the app on the device it's just a black screen and the application closes after 5-6 seconds. This is happening both manually and via automation scripts.

Sounds like the application is somehow not built correctly. Unfortunately the plugin cannot provide support for this situation. If you think the behaviour is due to the altunity tester plugin, then best to contact them about it.


[TextField] Add links to Input and Select

[x] I have followed (at least) the PR section of the contributing guide.

@mbrookes Thank, I have updated the wording and added new links. I often people that don't realize that they can use the native input element attributes. The links will help 👌 .

@MrHen It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!


Improve logging with zerolog

Now log messages are structured json if not on tty, on tty colored output. Log messages include source file location and more consistent error extraction. Using zero allocation logger package.

Before and after example of log messages on terminal


iOs devices are unable to process interface components and remain deformed.

Steps to Reproduce
The application for Android and Ios is already in production. However, iOs devices are unable to process interface components, as the bottomNavigationBar and FloatActionButton icons, avatar image and card content remain deformed. This happens from time to time.

Excerpt from the code on this page. Does anyone have any idea why this is happening?

[✓] Flutter (Channel stable, 1.20.2, on Linux, locale en_US.UTF-8)
• Flutter version 1.20.2 at /home/matheus/Documents/Dev/flutter
• Framework revision bbfbf1770c (7 weeks ago), 2020-08-13 08:33:09 -0700
• Engine revision 9d5b21729f
• Dart version 2.9.1
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /home/matheus/Android/Sdk
• Platform android-29, build-tools 29.0.2
• ANDROID_HOME = /home/matheus/Android/Sdk
• Java binary at: /home/matheus/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6626763/jre/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.
[✓] Android Studio (version 4.0)
• Android Studio at /home/matheus/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6626763
• Flutter plugin version 48.1.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] Android Studio (version 3.5)
• Android Studio at /home/matheus/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/191.6010548
• Flutter plugin version 44.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[!] IntelliJ IDEA Ultimate Edition (version 2019.3)
• IntelliJ at /home/matheus/.local/share/JetBrains/Toolbox/apps/IDEA-U/ch-0/193.6911.18
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see

Hi @MattheusOliveira,
By deformed, do you mean some widgets are not rendered properly on iOS ?
Can you please provide a minimal complete reproducible code sample involving those widgets that shows the issue ? The screenshot you shared won't help, please provide the sample in text format that we can copy paste and run in IDE. Also provide the iOS devices on which you are experiencing this issue.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


import calculus

in "Task_1_cubic.ipynb" why have you written:
from calculus import *

I am not sure what " * " is but isn't it easier to just write "import calculus" or "import calculus as calc"?

means it will import all the things from there. I feel it easy to use.

Oh okay, I never knew that. Thanks for letting me know!


Support for Podman over ssh remote connection

Hello there, good day!
At work, I use Golang with podman, and they have a way to connect to other machines securely through ssh tcp streams. I think it would be a great addition to this library as well :)
Here is the ssh library I found that supports the stream pass-through.
Here are some connection examples:
// connection examples:
//   - ssh://<user>@<host>[:port]/run/podman/podman.sock?secure=True
//   - unix://tmp/__podman.sock -t 0

Then this library would parse and choose the most appropriate one for the job.
I haven't explored this codebase enough to see how much work It would take, so If you need any help, please let me know

Also, the golang library is called bindings and it's in the pkg directory over in https://github.com/containers/podman/tree/main/pkg/bindings

Thank you for the report, that is indeed an interesting idea. It would probably require creating some sort of compatibility wrapper for ssh connection that would implement the tower::Service trait for integration with hyper similar to what hyperlocal does for a unix socket but that seems doable. I will look into this when I get some more free time.

I agree, I will explore more the go code and come back with hopefully how they implemented on their side

The way podman does is with a full abstraction of the http client to use ssh https://github.com/containers/podman/blob/main/pkg/bindings/connection.go#L94

there is a stream struct on the ssh2 library https://docs.rs/ssh2/latest/ssh2/struct.Stream.html

A way we could do it is to abstract the hole http client struct and use different clients for different use cases :thinking:

I think this is necessary for supporting macOS as I think it works by connecting to a virtual machine over ssh.
$ podman system connection  list
Name                         URI                                                         Identity                                                      Default     ReadWrite
podman-machine-default       ssh://core@<IP_ADDRESS>:63169/run/user/501/podman/podman.sock  /Users/blazzy/.local/share/containers/podman/machine/machine  true        true


Kyle/v0.3

A draft of the complete overhaul of the SDK I did, includes SMS Passcode UI work. Not in a finished state, though it's pretty close. Various small-ish things to clean up, and some improvements to handling error messages, and I need to add tests, but otherwise I'm pretty happy with the state it's in. But feedback certainly welcome about anything and everything! Also any questions you have feel free to leave a comment or ping me about on slack.

@ethan-stytch With the recent changes I've verified that this is in a working state. I also fixed the scrolling issues I talked about with you (and moved the "Continue" button up so that it is no longer anchored to the bottom of the page).
I'm ready to merge this now as soon as you give your approval. I expect to put up another PR this weekend just to add a little more polish for Monday but, as you said, the main thing is getting this working and I have done that now.


x11docker hello-world fails with: OCI runtime create failed ... "exec: "env": executable file not found in $PATH": unknown

Thanks much for any help you can give!
docker hello-world works fine.
x11docker version is 6.6.0. Having just installed it, I believe it's the most recent stable release.
command: x11docker --verbose --debug hello-world
I've followed the troubleshooting steps.
The issue seems to be that the directory ~/.cache/x11docker/hello-world-ID exists for a bit, and then doesn't:
x11docker.log attached.

...
==> /home/giuliano/.cache/x11docker/hello-world-70793703444/message.log <==
DEBUGNOTE[23:06:35,912]: xinitrc: Created cookie: conservatory/unix:1  MIT-MAGIC-COOKIE-1  8b57213328bf31ca229d406dbf4128f6
#ffff#636f6e7365727661746f7279#:1  MIT-MAGIC-COOKIE-1  8b57213328bf31ca229d406dbf4128f6
==> /home/giuliano/.cache/x11docker/hello-world-70793703444/xinit.log <==
xinitrc: xinitrc is ready
...
DEBUGNOTE[23:06:36,147]: storeinfo(): xinitrc=ready
DEBUGNOTE[23:06:36,287]: waitforlogentry(): dockerrc: Found log entry "xinitrc is ready" in xinit.log.
==> /home/giuliano/.cache/x11docker/hello-world-70793703444/share/container.log <==
docker: Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: "env": executable file not found in $PATH": unknown.
==> /home/giuliano/.cache/x11docker/hello-world-70793703444/message.log <==
DEBUGNOTE[23:06:36,791]: storeinfo(): containerid=2859c2ea9235efcbb30b919458f0bacdabb3b1e14fd01c5541b7b0ada01a4fa1
==> /home/giuliano/.cache/x11docker/hello-world-70793703444/share/container.log <==
Error: No such container: x11docker_X1_hello-world_70793703444

x11docker.log

Okay, weird:

x11docker/check works when run the first time.
x11docker (via docker I suppose) had to download it, and then x11docker/check ran fine.
Ran it a second time, and got the OCI error.
Removed containers and images using  docker system prune -a and verified no containers running using docker ps.
Ran x11docker/check and it worked. Exited, ran it again, it worked. Tried a few more times and it continued to work.
So I tried x11docker hello-world, docker had to download the image, and it failed as above.

The below all download the appropriate image and work fine. But hello-world downloads image, and fails.

x11docker patricknw/xaos
x11docker --gpu x11docker/xfce glxgears
x11docker --pulseaudio --share=$HOME/Videos jess/vlc

Thank you for the report!
I can confirm the issue.
Basically the reason is clear: x11docker does some setup in container and uses some common POSIX commands. However, the hello-world image is minimalist in a way that it has nearly no commands at all. The command env is just the first one that fails fatally.
I am not sure how to fix this, and if I should fix it at all.
Pro fix: support minimalist images, save resources.
Contra: core x11docker features like container user setup fail.
Let me think about this.

Do you need to use env? Just about everything I've used it for can be done other ways. In any case, not a big deal really. x11docker/check is probably a better "hello world" anyhow.

@mviereck, IMHO x11docker should expect the set of common tools/resources that should be available in any container where a GUI app is to be executed. AFAIK, hello-world does not fulfill that. This is to say that hello-world feels like a synthetic and corner case to test x11docker. There are many other images where static apps are contained in scratch, but I believe that none of them is to be used for GUIs. Probably, if any GUI app is installed in a hello-world image, env will be a dependency.
So, I'm good with supporting minimalist images, but not too minimal.

Thanks much for looking into this.

I had a look which commands are executed by x11docker in container:
mkdir chmod ln ls cp [ grep cut echo cat sed rm mv id chown rev env sh su read sleep ldd sort uniq tr printf nl basename.
A few of them could be dropped or allowed to fail, but the majority is important, most of them for container user setup.
I consider to include a dependency check at container startup to error out if an important command is missing.
env is special because x11docker uses it to overwrite a possible ENTRYPOINT in container with docker option --entrypoint env.

Thanks again for looking into it. Maybe just drop hello world from the x11docker gui and the doc? It's presence there was the only reason I tried it.

Maybe just drop hello world from the x11docker gui and the doc? It's presence there was the only reason I tried it.

?? hello-world is not part of the x11docker documentation. Where did you find this?
Currently I try an experimental option that causes x11docker to do no setup in container at all. That will disallow some features and some applications won't work anymore, but will allow minimalistic images.

And, I must have been hallucinating ;-> I can find no evidence for it in either the doc, or x11docker-gui. Don't know what inspired me to try hello-world. Probably just a hold over from walking through the docker tutorial, and thinking it was the first baby step? In any case, apologies for not checking before saying that.

I've added an experimental option --no-setup that avoids all x11docker setup done in container. This allows to run images with missing core dependencies.
However, this needs further testing and breaks a lot of x11docker features. At least every broken feature needs its own message.
This option is not ready yet. Currently I focus on other projects; not sure when I will work further on --no-setup.

Follow-up of experimental option --no-setup in #286.


Fix hang in DDP HPC accelerators

What does this PR do?
init_device was not called, so the root_gpu is 0 throughout. This leads to a hang later on in ddp_train when configure_ddp was called, as the LightningDistributedDataParallel call never completes with the redundant device ids set.
This is a recent change from https://github.com/PyTorchLightning/pytorch-lightning/pull/5016 and there aren't tests in OSS for this particular accelerator
2 main questions:

Here I'm calling init_device immediately after set_world_ranks - is that correct?
What should be done in the DDP HPC CPU accelerator which extends this? Setting the root gpu there doesn't make sense so for now I've set init_device as a no-op, but I'm not sure if that's the most robust.

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?
Make sure you had fun coding 🙃

I think the changes are fine apologies for the mistake. This is correct, devices just now have to be initialised separately from the model due to changes for the RPC plugin, and before initializing any model/connections.


Added two constructors to MockFileData to allow for lazy loading of t…

…he file content.
Rationale: when mocking a file system, it is commonly populated with a large number of files, where only a few will be relevant for each test suite. By allowing the files content to be lazy loaded, a huge amount of memory and disk reads can be saved.

why should you populate the mock file system with files you do not need in a test?

If you don't see why - you probably have no need for it, but I do. :-)
I want to have a common ground for populating my mock file system with a number of large bitmap files. Then I want to call this set-up from a number of TestFixtures. Not all of them will need all the files or the content of the files, but most importantly - many of the tests are interested in the availability of the files, but not necessarily then content of the files.
So by adding a lazy loaded file - the code will see that the file exist (which is important) but may choose not to read it's data. And then I have a huge memory and performance save.
Another benefit is that you can check if the file was actually used (if the Func was called).

I've added a test class to ensure that the content of a lazy loaded file is not touched by directory browsing or File.Exists. This makes it possible to create mocked files that are being seen by the code to be tested, without having to populate them with real data until needed. (The new commit only ensures this behavior - the feature was already there.)

I love the idea, mostly because I think it enables users to easily simulate special behaviors while reading file contents (as requested in e.g. #226 or #288).

@danbystrom I know this PR is pretty old, but we are currently in the process of bringing this library forward. Are you still willing to contribute here? If not, someone else could take this over.

Sure,
I'm using my fork all the time, so I know it is useful. It would be nice to
be able to finally merge it.
Just tell me what I can do to help.
D
2018-07-11 11:48 GMT+02:00 Florian Greinacher<EMAIL_ADDRESS>
@danbystrom https://github.com/danbystrom I know this PR is pretty old,
but we are currently in the process of bringing this library forward. Are
you still willing to contribute here? If not, someone else could take this
over.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/System-IO-Abstractions/System.IO.Abstractions/pull/144#issuecomment-404111331,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABEGNXIVLGZ3RReGOk2th-pJtXgL3wVHks5uFcoBgaJpZM4GhE9y
.

First step would be to rebase this on current master - this will then also trigger the new builds. I'd like to have this PR merged before we have to celebrate it's third birthday 🤣 🎉

I dont agree with this approach.
This is introducing bit of complexity that'll actually erode confidence in this library when the first bugs start showing up because it was lazy loading files specifically added to the MockFileSystem.
I believe the OP is needing a different solution but can't be sure because he hasn't outlined the problems he's seeing and how he's using the library. We have a proposed PR to make a change without explaining the value and necessity of making this change to the very basic assumptions of the MockFileSystem.
MockFileSystem was not built to be an in-memory file system.  There's NTFS on RAM drives for that.
MockFileSystem was built to make file system access tests isolatable and more easily repeatable.  I just don't think having MockFileSystem lazy load a whole directory of 1000 entries of massive bitmaps is not its design goal.
And like @manne mentioned, why are you building a huge dataset everytime when the tests aren't testing the whole dataset?  Seems like a problem domain isolation problem in the testing methodology.

FWIW I agree that this is a little strange. I'm heavily in the camp of your test suites should be such that the minimum amount of data is required to get your test to pass or fail.
Theres no value in having files added to the fake file system that you never interact with.

What are we thinking on this one @fgreinacher @robkeim ?

For me this feature is symmetrical with the existing MockFileData functionality.
Following your argumentation one could also question whether MockFileData and friends make sense at all. Their main purpose is to get the file system in a specific state/behaivor. You could do the same with the regular file system API, but they are there to make the setup as dense as possible.
So IMO we should accept this one.
So IMO we should

I agree with @jpreese that if we could have a concrete example of what's being tested that would help clarify the motivation for being able to lazy load files.
Understanding the why we're doing this will help us review/discuss the what we're doing which we can see in the current implementation.

Well, this feels odd. Three years ago I had a problem, I solved it and have been happy with the solution ever since. Now, however, I’m not very happy with arguing whether another solution would have been better. I have no idea what “a problem domain isolation problem in the testing methodology” means. I could probably read that sentence till my eyes started to bleed without being none the wiser. 😊
A couple of typical uses for me:

Less important: Static files. There are a number of files that are just supposed to be available at all times. Explicitly including them in each test is just a waste of coding time and loading them into memory in each test is just a waste of memory and processing time.
More important: code that takes decisions based on the existence of files. Typical scenario: I have four different versions of a portrait:
a.	Original hires jpg with a green background
b.	Hires png with transparent pixels instead of green background
c.	Lores jpg with green background replaced with a gray fund
d.	Lores png
At various times all files may not yet be available (particularly case b), and at different times it is OK to fallback to a different one and at different times it is not acceptable. A test that wishes to ensure that a particular file version is being used must therefore also populate the file system with other files that is NOT INTENDED TO BE USED, and afterwards inspect a produced result to see on a pixel level that the correct file was being used. Here is a situation when it is wasteful to populate the mock file system with actual file DATA until the code asks for it.

You seem like you're doing a lot of integration tests, and not defined functional tests. Anytime somebody says "not at this time" or similar, then you're basically implying a race condition exists.
Having the simplistic mockfilesystem start lazy loading gets us into all kinds of race conditions that I simply dont see the benefit for.    Again, for complete isolation, you will definitely need to create isolated instances and therefore I guarantee you'll be copying files around to create a valid virtual reality that you're trying to test against.
All of that is outside of the scope of the (supposed to be simple) MockFileSystem testing helpers.  You're probably better off, for those particular tests, in keeping with the current implementation and not lazyloading file data.
In theory, does it matter if the bitmap is 12 megabytes or 1kb?  You don't need to run your tests against full 4k HD bitmaps to verify the results.  If you do, then again, you're outside the scope of this library.
Even if you were trying to build a simple database storage engine... I would still say you're outside the scope of these MockFileSystem implementations, since there's so many things that aren't being surfaced when running against a real file system like NTFS or FAT.

Closing.


Update CONTRIBUTING.md

Updated contributing.md section for a better understanding of the contributor

@varun10sudhir hello Varun, thank you for suggesting the changes. As said I made the changes and added the git commands as code snippets.
Thanks!


Clicking Checkout with uncommitted files shows an unhelpful error with text "Error"

Extension version: 0.5.0
VSCode Version: 1.32.1 (1.32.1)
OS: 10.14.3 (18D109)

Steps to Reproduce:

Have uncommitted files in current branch.
Try to checkout a PR.

Notes:
I tried my steps to reproduce but could not replicate this issue, so the condition must be slightly different from what I am reporting. The issue was that running git checkout <branch> from command line was throwing an error on its own with an informative message, but pressing the Checkout button showed only a message saying "Error" (without the instructions how to fix it).

Thanks for reporting this issue! There was a problem with VS Code not returning an error code for this case, fixed in https://github.com/Microsoft/vscode/commit/a5455afcef379d9a99723c2562f70d352c142642. Will be available with the next release of VS Code in two weeks.


vocabulary.debugging

[x] vocabulary/debugging
[x] not for a function error in JavaScript
[x] examples of not for a function error

@ahmedmohamud we will close this. only detailed workswill be merged.


feat: add canonicalization latency metric

Closes #3815

this also needs to be rebased / merged with the latest main since we made some fixes to CI

Perfect, yes makes sense - I wasn't sure if I should restructure the flow on the main match statement but what you have there makes sense. Will push shortly

@Rjected I put in the changes you asked for - please let me know if the branch looks ok.

cool - just going to clean up the merge a little bit


Error running selfbuild dockerImage 0.9.0-beta.11

Hi,
we need some patches for the nginx-ingress-controller, so we build it ourself.
With running the self build 0.9.0-beta.11 docker-image we have a problem:
[dumb-init] Unable to detach from controlling tty (errno=25 Inappropriate ioctl for device). [dumb-init] Child spawned with PID 5. [dumb-init] Unable to attach to controlling tty (errno=25 Inappropriate ioctl for device). [dumb-init] setsid complete. F0718 17:21:15.516436       5 nginx.go:145] invalid NGINX template: template: nginx.tmpl:364: function "buildUpstreamName" not defined goroutine 1 [running]: k8s.io/ingress/vendor/github.com/golang/glog.stacks(0xc4202fe000, 0xc4200d2700, 0x87, 0xda) 	/home/samuele/go/src/k8s.io/ingress/vendor/github.com/golang/glog/glog.go:766 +0xa7 k8s.io/ingress/vendor/github.com/golang/glog.(*loggingT).output(0x1dd15e0, 0xc400000003, 0xc420061600, 0x1d3ee9e, 0x8, 0x91, 0x0) 	/home/samuele/go/src/k8s.io/ingress/vendor/github.com/golang/glog/glog.go:717 +0x348 k8s.io/ingress/vendor/github.com/golang/glog.(*loggingT).printf(0x1dd15e0, 0xc400000003, 0x154f95c, 0x1a, 0xc420537df8, 0x1, 0x1) 	/home/samuele/go/src/k8s.io/ingress/vendor/github.com/golang/glog/glog.go:655 +0x14f k8s.io/ingress/vendor/github.com/golang/glog.Fatalf(0x154f95c, 0x1a, 0xc420537df8, 0x1, 0x1) 	/home/samuele/go/src/k8s.io/ingress/vendor/github.com/golang/glog/glog.go:1145 +0x67 main.newNGINXController(0x0, 0xc420537e80) 	/home/samuele/go/src/k8s.io/ingress/controllers/nginx/pkg/cmd/controller/nginx.go:145 +0x542 main.main() 	/home/samuele/go/src/k8s.io/ingress/controllers/nginx/pkg/cmd/controller/main.go:31 +0x37 [dumb-init] Received signal 17. [dumb-init] A child with PID 5 exited with exit status 255. [dumb-init] Forwarded signal 15 to children. [dumb-init] Child exited with status 255. Goodbye.
We checked out the tag nginx-0.9.0-beta.11 and have no own changes and build it with:
REGISTRY=our_registry:5000 make clean build container push
Some ideas?
I see a absolute path in the logs (/home/samuele/go). Can this be the problem? How can I solve it?
Thanks!

@qux42 you are not using the latest go template. Please make sure you are not using an old custom template.


Missing info in synopsis for parse()

The synopsis for parse() is missing relevant information:

Mandates: text_input<R> is true, error_handler<ErrorHandler> is true, attribute_compatible<Attr, R, Parser> is true.
Throws: whatever attribute copying or assignemt, or semantic actions throw. (something else?), std::bad_alloc?
Returns: true on successful parse, when the entire input is consumed; false otherwise.
Effects: on successful parse attr  is assigned the value of the attribute produced by parser. On unsuccessful parse attr is assigned a default-constructed value.

And you may need a concept attribute_compatible or at least a "macro" for the purpose of documentation. You may also need to define what "successful parse" means.

#109 covers the concept part.  The rest is in the description already, just not formatted like this.  The exception is the description of hhow the out-param is compatible with the default attribute.  This is too much to repeat for each *parse() overload.  The tutorial covers it, though.

So, it looks like you are saying that most of the function description is there, just not in a user-friendly format.
I am requesting to provide a user-friendly format.
Some users will want to jump directly to the reference section and would expect to find all the relevant information here. Or at least the reference to other places that describe more generic properties. When the user wants to learn what parse() does, they will not know that prefix_prse() is almost the same. So from user's perspective such repetition one every *parse() function is rather helpful.


Modified tests to conform newly proposed subset logic.

Details are in perl6/problem-solving#3

This is overview PR, not for merging yet.


getValue inside FieldArray does not work

I have the following component using Modular Forms (great framework by the way, and clever use of typing!).
https://github.com/ffMathy/poodle.lol/blob/feature/form-submission/src/routes/index.tsx
On line 125, I have a DateSection component. When I select dates in that section, they are inserted into the form (line 127).
This should cause my FieldArray at line 144 to be able to get the value via getValue of the day property on line 147, but it is undefined.
I know this can't be, because on line 127, it is being inserted, and I've logged it out.
So it would seem as if getValue doesn't work in this case.
I am using Modular Forms with Qwik.

Thank you for the issue. I will have a look at the problem tomorrow.

Does it work if you put getValue in useComputed$ or directly in the JSX code?

If you wrap it with a <FieldArray> you can use getValues()

Does it work if you put getValue in useComputed$ or directly in the JSX code?

Both of these fail unfortunately.

If you wrap it with a <FieldArray> you can use getValues()

Still doesn't work. Returns an empty array.

I now have a repro-example!
This doesn't work:
https://stackblitz.com/edit/modular-forms-qwik-mqzpwi?file=src%2Froutes%2Fnested%2Findex.tsx
This works:
https://stackblitz.com/edit/modular-forms-qwik-3gr7yk?file=src%2Froutes%2Fnested%2Findex.tsx
So in other words, nesting the value itself around a Field seems to work.
I think this should either be documented somewhere, or fixed entirely, since I don't think it's very logical.

Hmmm, but then it seems there's also something weird going on with Date objects.
If I change the label property to be a Date and still have the Field around it, it still messes up:
https://stackblitz.com/edit/modular-forms-qwik-sdn3wi?file=src%2Froutes%2Fnested%2Findex.tsx

Thanks a lot for the code examples! As soon as I have some more time, I will investigate and solve the problem.

Hey @fabian-hiller! Thanks for that. Do you have an ETA of when this will happen? Just approximately?

@ffMathy on Monday

Great stuff. Thank you so much for everything you do!

@fabian-hiller is there a new ETA? ❤🙏

I had planned to do it earlier this week, but didn't get around to it. It's on my list. I'll try to do it tomorrow or this weekend.

Sounds great! The link I sent to the repro in Stackblitz is the same error as I am experiencing.

I have now investigated the problem. Sorry for not getting to it faster. The behavior of Modular Forms is expected. The reason is that fields are active or inactive depending on whether they are in the DOM. However, you can control this behavior in several places. For example, in the getValue method you can set the shouldActive option to false. Feel free to contact me if you have further questions or problems. More about the active state can be found in our docs here: https://modularforms.dev/qwik/guides/add-fields-to-form#field-state

I will now look at the problem with the dates. Thanks for the tip.


Introduce ExtractFields method.

This makes it posible, for instance, to customize TLS configuration when
connecting to smtp server.

Going to go ahead and close this for now. I might consider adding functionality to allow users to customize the TLS configuration (if it's not already possible), but I'll try to do it without adding new exposed functionality.
Thanks again for your contribution! Don't hesitate to let me know if you have any other ideas for the library.


Created conan.io recipe for this package.

I did not find your email address, so I write to you here.
I created a Conan recipe for your package. You can find it here: https://github.com/steakhal/conan-nameof
If you are no familiar with Conan, you can find more about it here: https://conan.io/
tldr. it is a package manager for c++
We can merge the recipe into your repository if you want to.

Thank you for that! I will add in the next update. I have one question, how to update Conan in the event of a new release?

Or should I need do my package?

I can create a PR for you with the necessary changes needed to insert the automatic packaging in the CI pipeline. Most likely using Travis.
But we don't even have to merge the recipe since it will work in separate repository too. Like now. Though I have to manually bump versions (and check whether packaging still works etc) as soon as you release. Merging would mean that you takes care of both. Obviously we would not let you alone, the Conan community is really active and responsive. You can always reach out for help on Cpplang/Conan slack channel.

My issue was more like a note that you should be aware of. And also and advertisement for trying Conan out if you haven't yet ;)

Ok, thanks. I will some learn about Conan.

@steakhal
Could you help me? I made a release of 0.9.0 with many improvements, because next week I'm going on vacation, and there will be no time to deal with the code. Could you upgrade the package?
After I come back I will add conan to https://github.com/Neargye/nameof and https://github.com/Neargye/magic_enum

Currently I'm quite busy, have a nice vacation. We will deal with this after that if it's ok for you.

Ok, thanks, no problem)


chore(weave): Improve Prompt Notebook Flows

Note: Uptook some changes from Stacey's https://github.com/wandb/weave/pull/639
Checklist:

Homepage Link:

/examples/prompts/llm_monitoring/openai_client_quickstart.ipynb

LLM Monitoring Template Instructions:

/examples/prompts/llm_monitoring/openai_client_quickstart.ipynb (same as above)
/examples/prompts/llm_monitoring/openai_proxy_quickstart.ipynb
Note: moved the dev folder to experimental since the synthetic data code cannot be executed in a colab since it relies on flat files not shipped with the weave package.

Trace Debug Template Instructions:

/examples/prompts/trace_debugging/trace_quickstart_langchain.ipynb
/examples/prompts/trace_debugging/trace_quickstart_decorator.ipynb
examples/prompts/trace_debugging/dev/synthetic_trace_data.ipynb

really appreciate the cosmetic stream renaming—i will make sure to rename the projects to be more descriptive too, once we fix the "first project != "weave"" bug.


Using queryBuilder negates the values and returns empty

If I pass a querybuilder to filter out values from the collection, the returns values are empty.
If I remove the query, values are returned. I need to return values based on the query:
var collectionReference =
     FirebaseFirestore.instance.collection(Str.BODA_REGISTRATION_COLLECTION);
 // .where(Str.UID, isNotEqualTo: FirebaseAuth.instance.currentUser!.uid); (this is not allowed, should be made to be allowed

 double radiusInKm = 10;
 String field = Str.GEOFIREPOINT_DATA;

 GeoPoint geopointFrom(Map<String, dynamic> data) =>
     (data[field] as Map<String, dynamic>)['geopoint'] as GeoPoint;

 final Stream<List<DocumentSnapshot<Map<String, dynamic>>>> stream =
     GeoCollectionReference<Map<String, dynamic>>(collectionReference)
         .subscribeWithin(
   center: center,
   radiusInKm: radiusInKm,
   field: field,
   geopointFrom: geopointFrom,
//with the commented lines below, when uncommented, the list is empty, when commented, there are values. The data in firebase is to return all except for the one with a filter as shown.
   // queryBuilder: (query) {
   //   return query
   //       .where(Str.UID,
   //           isNotEqualTo: FirebaseAuth.instance.currentUser!.uid)
   //       .orderBy(Str.UID)
   //       .orderBy(field);
   // },
 );

 await for (List<DocumentSnapshot<Map<String, dynamic>>> bodaList
     in stream) {
   final distances = bodaList.map((boda) {
     final bodaLocation = geopointFrom(boda.data()!);
     final double distance =
         center.distanceBetweenInKm(geopoint: bodaLocation);

     return distance * 1000;
   }).toList();

Possibly, have an updated documentation on how query filters work with GeoFlutterFire_plus with examples based on the approach I have up there. Or modify the package to include use of QuerySnapShot and show examples

@bwerere
Thank you for creating an issue!
As the comment below, it is not possible to use orderBy in queryBuilder because of the algorithm of geo query and restriction of Cloud Firestore. You can find the explanation in README as well.
https://github.com/KosukeSaigusa/geoflutterfire_plus/issues/62#issuecomment-1512466393
Instead of using orderBy, you can sort your query result in your client side.


Don't convert http urls to links in 'release notes' and 'description'

Tracking issue: https://github.com/NuGet/NuGetGallery/issues/6349

Question added to root issue: https://github.com/NuGet/NuGetGallery/issues/6349 - this change doesn't seem like a net win for anyone, can someone add info on what the goal is there please?


Support for Catalog Admin to access all objects

Catalog Administrators have access to all objects, but if the user starts to share portfolios to Catalog Administrators they start to limit the portfolios to be ones that are shared. This PR allows for a special id value in the resource definition filter '*' which matches any id, when we see * in the id list we allow the catalog admin to see all resources.
When we seed the data for Catalog Administrators we insert this special filter which allows the role to allow access to all instances.
as listed here
https://github.com/mkanoor/rbac_utilities/blob/99aa8a4f3fbd29caf2036f1da858a012af1e8c57/rbac.yml#L3
Marked as WIP since we have RBAC currently disabled, but this feature is usable

@mkanoor I am looking at merging this a little later this week as there will be some videos recorded Wednesday and I do not want to disrupt that work.

@mkanoor On second thought, do you want to remove the logic in this PR that re-enables RBAC and we can handle that by reverting https://github.com/ManageIQ/catalog-api/pull/207 when we are ready.  Then this PR can be merged sooner.

@gmcculloug Please review removed the 2 conflicting files


The badge is not added to README.md

I tested the badge in two different repos and it was not added to README.md.
In the commit the result was this:
https://github.com/Wurthma/DbInstallation/commit/37dd6dcf79ffe0779dc16e37a8a0fba77cf68367
I'm doing something wrong?

I guess you took the the implementation from the demo repo . But I need to update the demo repo with the latest changes that I have made. If you take a look the readme now you will see that all the github related badges has a key with it, like 'gh_license, gh_version, gh_stars' . So you have to use the key codes of the corresponding badges to make it work. You can check the available keys in the README

I guess you took the the implementation from the demo repo . But I need to update the demo repo with the latest changes that I have made.
If you take a look the readme now you will see that all the github related badges has a key with it, like 'gh_license, gh_version, gh_stars' . So you have to use the key codes of the corresponding badges to make it work. You can check the available keys in the README
(Edit: I have updated the demo repo, you can check the yml file and how it's implemented)

I updated the badge keys, I'm using only gh_stars for testing. But when I push anything the workflow don't change anything.
It does not generate automatic commit that changes README.md (chore: add badges 🦄).

@Wurthma I have been testing it the whole day now and finally figured out what was wrong.  So basically there are two actions running here . First the actual badge it action for the command then the updating the readme itself but I don't remember why, I added a redundant peace of code in the project long time ago which was only causing to stop the action flow after running only one action so the updating part never ran that's why it was hard to debug to since that didn't throw any errors too.
Anyway I removed it and it should work fine now . Try rerunning the action or push anything.

@RocktimSaikia I just made some pushs, but It does not work yet. I saw that you forked the project that i'm using to test and I'm using the yml file just like yours, but still not works.

@Wurthma That's really a strange issue as it's working on the other demo repos. Anyway I will do thorough test on the whole issue and let you know after that. And sorry for the late response . I am a bit busy with my internship.


make_jvp(f)(g) should return the function value as well

I think make_jvp should return the function value as well, like this. Thoughts @j-towns and @dougalm?

Definitely agree.


Exif info about image rotation/flipping is not respected when selecting from gallery

Doesn't work also in the sample app when selecting single or multiple images
 from this repo.
For example this one:
https://github.com/ianare/exif-samples/blob/master/jpg/orientation/landscape_5.jpg

Show after import like this in preview:

Hi @shtolik, this issue will be fixed in the upcoming release.
Thank you for reporting 👍


how to do cvmn in industrial-grade ultra-large-scale data.

In UIO method, we can download corpus from url, but how to calculate cvmn, not all data is on the disk.

Just sample part of the data.


Workaround for Adobe variable bug?

@khaledhosny
InDesign still seems to have a bug that causes any adjustment of the variable slider to jump between fonts. So if the roman variable font is selected, when the slider is moved the text jumps to italic font. Is this the same ID25 issue that we ran into with the STIX Two Text variable font?
Is this something we can workaround in the STAT table code in the YAML config file? Or elsewhere in the build process?

I think the work around is to set name ID 25 to a unique value in both Roman and Italic fonts. This should be possible right now by setting names: key on the variable font. E.g.:
fonts:
  Foo-Roman:
    source: Foo-Roman.designspace
    names:
      25: Foo-Roman
fonts:
  Foo-Italic:
    source: Foo-Italic.designspace
    names:
      25: Foo-Italic

Confirmed roman and italic variable fonts now working as expected in InDesign (which is to say not working very well at all, but at least both now accessible to the variations slider UI).


Easi 2783/capturing deleted actors spike

EASI-2783
Changes and Description

Created an ADR for how to capture the deleted actor.

made a POC test branch
unit tests to verify the actor

How to test this change

Look at the ADR
Look at the changes in the POC branch

PR Author Review Checklist

[x] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[x] Added or updated tests for backend resolvers or other functions as needed.
[x] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[x] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

Opened for the wrong branch, this is the POC, looking to merge the ADR,  not the POC. Closing in favor of PR https://github.com/CMSgov/mint-app/pull/520


chore: release  @contract-case/contract-case-jest 0.11.1

:robot: I have created a release beep boop
0.11.1 (2024-01-06)
Bug Fixes

Update documentation slightly (1845322)

Dependencies

The following workspace dependencies were updated

dependencies

@contract-case/case-boundary bumped from 0.9.1 to 0.9.2
@contract-case/cli bumped from 0.1.7 to 0.1.8

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/case-contract-testing/contract-case/releases/tag/%40contract-case/contract-case-jest-v0.11.1 :sunflower:


Add python3 to shebang

This pull request specifies python3 in the um_env_to_yaml.py script, as I got a warning when trying to run on gadi without it.

Oh don't worry this one's going to be printed and framed


18535 - Save and Resume Draft Amalgamation

Issue #: /bcgov/entity#18535
Description of changes:

Save and resume draft Amalgamation Filing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

/gcbrun

/gcbrun

Temporary Url for review: https://business-create-dev--pr-592-6275tvzb.web.app

UPDATE: After Kevin merged his PR, I'm able to save the draft and load it properly!

That's great! Does it also resume correctly?
I see we store the entire table (not the minimum specified by the schema). I think the Legal API won't care, but we need to be sure that each business is completely re-fetched when a draft is resumed. Does that fit in your existing ticket or do you want to do some of that as part of 18641?

Yup, it does! I've tried adding and saving + deleting and saving, works well.
Let's keep that as a part of #18641. I'll also mention that there.


Sharing maintenance work

Dear Kai,
thank you very much for adding @gutzbenj and me as maintainers to this repository. As we have not been using Conda before too much, we may need some assistance.
For the matter of making a start, shall I just go ahead, and acknowledge the PR #45, in order to build and release Wetterdienst 0.39.0? I figure that the machinery will recognize my acknowledgement and conclude all further steps?
When all goes well, I will follow up with the same procedure for versions 0.40.0 and 0.41.0 as well? That sounds too easy to be true!?
With kind regards,
Andreas.

@amotl If you think only the latest version 0.41 is necessary you might just merge that PR, all others will be closed without creating these versions. Otherwise go ahead step by step.

Thank you. I will go ahead step by step. Maybe some people will need the dedicated versions to hunt down for regressions of any kind. Good to have to whole history published then.

Hi again,
it looks like it will only work for newly created PRs. On #45, even after acknowledging, I don't see a merge button.

With kind regards,
Andreas.

Hi again,
as reported at https://github.com/conda-forge/wetterdienst-feedstock/pull/52#issuecomment-1201509919 ff., we might still need memberships with write permissions on the repository to be able to conclude the necessary steps like merging PRs.
With kind regards,
Andreas.

Apologies. I missed the invitation to the repository delivery by email and GitHub apparently does not display it on the user interface in any meaningful way. I've just merged #45 and will continue doing so with the others, as planned.
Thanks again for your support!

Are there any guesses how long it will take through the machinery to be visible on https://anaconda.org/conda-forge/wetterdienst?

It normally takes up to two hours to trickle through the CDN.

@amotl Sorry for being not more in the loop yesterday. I'll elaborate a bit more on the foundations of conda-forge:

Most of the hard parts of the machinery is backed by bots [1].
The maintaining part is described in [2].
Updating recipes can be done automatically via regro-autotick-bot (we just have to wait a bit for the bott to detect the new version on PyPI and issue the PR)
If we are eager to have the new version, we can issue a PR from our forks [3]
But we need to take care all the global pinnings are at their last state (regro-bot would take care of this) [4]
For pinning please refer to [5]
If we have a test suite (rather short, only basic things to check correct build) we can run those by activation in meta.yaml (currently just importing) https://github.com/conda-forge/wetterdienst-feedstock/blob/9fbb91fed18d4fa0d4fccf35e937ee2a18048d4b/recipe/meta.yaml#L57-L59
Configuring conda-forge.yml [6]

I'm having a hard time to understand which are required runtime dependencies of wetterdienst and which are optional. So the requirements run section in meta.yaml would need some expert eyes on it.
[1] - https://conda-forge.org/docs/maintainer/infrastructure.html#admin-web-services
[2] - https://conda-forge.org/docs/maintainer/updating_pkgs.html#maintaining-packages
[3] - https://conda-forge.org/docs/maintainer/updating_pkgs.html#updating-recipes
[4] - https://conda-forge.org/docs/maintainer/updating_pkgs.html#rerendering-feedstocks
[5] - https://conda-forge.org/docs/maintainer/pinning_deps.html
[6] - https://conda-forge.org/docs/maintainer/conda_forge_yml.html

Dear Kai,
thank you for this extensive list of resources. I think I will be able to handle it after running some actions yesterday, also getting into a slight conversation with the regro-autotick-bot ;].
Thanks again for giving us permissions here, so we can maintain releases on our own behalf. I hope it will save you some time in the future.
For improving the list of runtime requirements, I've just created #57.
With kind regards,
Andreas.


Staging: Change env back to staging

config.env was changed to live from staging to get real emails to send for the AppCast micro test.

Wow, opened this in the wrong repo.  Awkward and embarrassing that I can't delete it!


[BUG] long search lines scroll filters and flags

https://github.com/user-attachments/assets/edee8d60-d892-4f38-ada4-a28276c25947

interesting, I guess I never noticed this since I had wrap option set globally...
I guess it does make sense to turn it on by default for grug-far.nvim.

Should be wrapping now! 😄


proposal: cmd/go: make "go test" exit 0 if *.go files exist but none match context

It's a little weird right now that go test in a directory of non-context-matching *.go files (like golang.org/x/sys/windows/registry on Linux) results in an error, but go test in a directory without tests is fine (exit 0), and go test ./... is also fine, as long as one directory somewhere has a context-matching file.
dev:~ $ mkdir /tmp/foo
dev:~ $ cd /tmp/foo
dev:foo $ go mod init foo
go: creating new go.mod: module foo

dev:foo $ go test
no Go files in /tmp/foo
dev:foo $ echo $?
1

dev:foo $ cat > x_windows.go
package main

dev:foo $ go test
package foo: build constraints exclude all Go files in /tmp/foo
dev:foo $ echo $?
1

dev:foo $ cat > x.go
package main

dev:foo $ go test
?       foo     [no test files]
dev:foo $ echo $?
0

dev:foo $ go test ./...
go: warning: "./..." matched no packages
no packages to test

dev:foo $ mkdir bar
dev:foo $ cat > bar/bar.go
package bar

dev:foo $ go test ./...
?       foo/bar [no test files]
dev:foo $ echo $?
0

dev:foo $ go test golang.org/x/sys/windows/registry
go: finding module for package golang.org/x/sys/windows/registry
go: downloading golang.org/x/sys v0.0.0-20200602225109-6fdc65e7d980
go: found golang.org/x/sys/windows/registry in golang.org/x/sys v0.0.0-20200602225109-6fdc65e7d980
package golang.org/x/sys/windows/registry: build constraints exclude all Go files in<EMAIL_ADDRESS>
Can we instead make go test act more like the package has no tests? I'd like to see:
$ go test golang.org/x/sys/windows/registry
?       golang.org/x/sys/windows/registry [no matching files]
$ echo $?
0

This arose due to integration of Go in another build system (that builds non-Go stuff) and that build system was using the heuristic that if a directory contains *_test.go files, it running go test in that directory was reasonable. That's currently not true for directories like x/sys/windows/registry or other such OS-specific packages.

It's unclear what the change would be here exactly.
Files that exist but don't match context are treated the same as if they didn't exist at all.
go test without an argument is identical to go test ., and when you say a specific package like . or math  (not a wildcard), it is required to exist.

It seems like all of those four really need to fail instead of just printing a warning.
So then the question is whether go test should be different from those, and if so, how to draw the line.
We may have backed ourselves into a bit of a puzzle where there's no easy way out.

Adding to minutes; I still don't see an easy way out here.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

IMO the cleaner solution here is to set up the .go source files for the package in such a way that OS-specific packages continue to exist (and continue to compile) on platforms that do not support the OS-specific functionality.

FWIW that's just echo package p >dummy.go.

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

No change in consensus, so declined.
— rsc for the proposal review group


adding link for same-origin policy, per old docs

I've just signed the Contributor License Agreement, and hope to help out with the new docs.

hey @bryan-gordon4 , thanks so much for contributing!!
sorry to be pedantic but could you wrap the href with double quotes and put the protocol before the "//"  please? thanks so much :) when you do that just push another commit.

no problem @ddavison , doing so now.

no problem @ddavison , doing so now.


bug 1781804: fix revision pending message

I needed a correct message to figure out what state the operator thinks it is in
/assign @sttts

/hold
this fixes an immediate problem, but the entire approach looks wrong.

/hold cancel
the approach is weird (we aren't degraded for this reason), but we are running

/bugzilla refresh

/lgtm

/cherrypick release-4.3


[SPARK-6487][MLlib] Add sequential pattern mining algorithm PrefixSpan to Spark MLlib

Add parallel PrefixSpan algorithm and test file.
Support non-temporal sequences.

Can one of the admins verify this patch?

add to whitelist

@feynmanliang Could you take a look?

Merged build triggered.

Merged build started.

Test build #36686 has started for   PR 7258 at commit 91fd7e6.

Test build #36686 has finished for   PR 7258 at commit 91fd7e6.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class Prefixspan(

Merged build finished. Test FAILed.

@zhangjiajin Thanks for making this PR minimal! I made some comments about code style. @feynmanliang will make a pass on the implementation. @jackylk Could you make a pass as well?

That's all for now! Overall:

I am concerned with the scalability of grouping all the prefix-projected databases by prefix (Prefixspan.scala#109) followed by local processing. This may cause the entire dataset to be sent to a single worker (see inline comments).

The algorithm is not truly distributed: only the first iteration (length 1 prefixes) is performed in a distributed manner on RDDs; the remaining iterations are all done locally.

There is a lot of duplication between getPatternsInLocal+getPatternsWithPrefix and the other methods. It seems like the former two are just doing the same thing except on local Array[Array[_]] rather than RDD[_]. If we can refactor things into a common method operating on RDD[_], I think we can both solve the scalability problem and DRY up the code.

Merged build triggered.

Merged build started.

Test build #36779 has started for   PR 7258 at commit 575995f.

Test build #36779 has finished for   PR 7258 at commit 575995f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PrefixSpan(
class Prefixspan(

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #36782 has started for   PR 7258 at commit a2eb14c.

Test build #36782 has finished for   PR 7258 at commit a2eb14c.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PrefixSpan(

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36785 has started for   PR 7258 at commit 89bc368.

Test build #36785 has finished for   PR 7258 at commit 89bc368.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PrefixSpan(

Merged build finished. Test PASSed.

@feynmanliang  findPatternsLengthOne and getPatternsWithPrefix do the similar work, but the input data type is different. findPatternsLengthOne faces the entire RDD data, getPatternsWithPrefix faces part of RDD data, but the content of the data is similar. Before shuffle, the prefix and the projected database distributed in all the partitions. After shuffle, one partition only including one prefix and its projected database. In other words, after shuffle, one partition of the new RDD is same as the old entire RDD. So, findPatternsLengthOne is different from getPatternsWithPrefix, eg. findPatternsLengthOne has some collect methods.

About the parallel method, I think method 2 performance is better than method 1.

If you collect L112's frequentLengthOnePatternAndCounts (after renaming), L112-129 and L169-183 are basically identical (frequentLengthOnePatternAndCounts <=> frequentPrefixesAndCounts, filteredSequences <=> cleanedSearchSpace, prefixAndCandidates <=> prefixProjectedDatabases) and both operate on the same type Array[Int]. Can we pull out a common helper method?

@zhangjiajin The issue with method 2 is projection before filtering. It may increase the shuffle size. After we generate possible prefixes, we should count their frequencies (that does not require shuffling the suffixes), filter out invalid candidates, and then project. Basically, I'm suggesting the following:

generate prefix candidates
count their frequencies
filter and collect frequent ones
Do we have enough candidates to distribute the work? If no, go to 1 and generate candidates with length + 1.
project and group by prefixes
generate frequent patterns for each prefix
union with local frequent sequences

Merged build triggered.

Merged build started.

Test build #36933 has started for   PR 7258 at commit 1dd33ad.

Test build #36933 has finished for   PR 7258 at commit 1dd33ad.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36935 has started for   PR 7258 at commit 4c60fb3.

Test build #36935 has finished for   PR 7258 at commit 4c60fb3.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36936 has started for   PR 7258 at commit ba5df34.

@zhangjiajin Since you already collected the frequent items (length-1 patterns) to driver, you don't need to keep the RDD of length-1 patterns. When generating the final patterns, recomputing the RDD is more expensive than parallelizing the collected ones.
Another comment is to separate local computation from the distributed ones. It makes the implementation easier to read. We can create a private object called LocalPrefixSpan, with run(sequences: Array[Array[Int]], minCount: Int): Array[(Array[Int], Int)], then put all local methods under this object.

Test build #36936 has finished for   PR 7258 at commit ba5df34.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@mengxr I don't know why method 2 is projection before filtering. I think the method two is exactly what you want. The only need to add functionality to the current code is step 4 (Do we have enough candidates to distribute the work? If no, go to 1 and generate candidates with length + 1.)

Merged build triggered.

Merged build started.

Test build #37035 has started for   PR 7258 at commit 574e56c.

Test build #37035 has finished for   PR 7258 at commit 574e56c.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

@feynmanliang comments: Delete makePrefixProjectedDatabases, move the groupByKey() to the last call in this method (no need to include the two map()s on L161 and L163 since they don't do anything)
Because the pair's key is Array(), groupByKey() don't work well, so, the Array must be converted to seq before groupByKey, and be converted back after groupByKey.

Merged build triggered.

Merged build started.

Test build #37073 has started for   PR 7258 at commit ca9c4c8.

@zhangjiajin Yep, you're right. Thanks for pointing it out!

LGTM pending tests

Test build #37073 has finished for   PR 7258 at commit ca9c4c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@zhangjiajin Let's merge this version and make improvements in follow-up PRs:

LocalPrefixSpan performance
a. run should output Iterator instead of Array.
b. Local count shouldn't use groupBy, which creates too many arrays. We can use PrimitiveKeyOpenHashMap.
c. We can use list to avoid materialize frequent sequences.
If there are not enough length-1 patterns to distribute the work, we make another pass to find length-2 patterns.
Support non-temporal sequences.

I will make JIRAs for each of them. @feynmanliang will work on 1). @zhangjiajin Could you work on 2) and do some performance benchmark? Thanks!

Merged into master. Thanks for contributing PrefixSpan!

OK


Create MavericksViewMocks.ViewMocksProvider

Currently Mavericks mocks are provided by reflectively calling view.provideMocks.  This pr adds an additional way for providing mocks by setting a ViewMocksProvider.
 MavericksViewMocks.mockProvider = object : MavericksViewMocks.ViewMocksProvider {
            override fun mavericksViewMocks(view: MockableMavericksView): MavericksViewMocks<out MockableMavericksView, out Parcelable>? {
                return when (view) {
                    is Frag -> {
                        val viewModelReference = Frag::fragmentVm
                        val defaultState = TestState(num = 4)
                        view.mockSingleViewModel(
                            viewModelReference = viewModelReference,
                            defaultState = defaultState,
                            defaultArgs = null
                        ) {

                        }
                    }
                    else -> null
                }
            }
        }

When set Mavericks will first try to load a mock from the provider and then will fallback to the current behavior.
Please let me know if any additional tests or docs would be helpful. I wasn't sure what to add.

cc @elihart

I don't think travis is setup to run in non main branch prs

I had to recreate a branch and CP my commit as the rebase didn't go smoothly. This should be good to go. Thank you for working with me and accepting external contributions


Syntax of command is incorrect

grobid-service/bin/grobid-service server grobid-service/config/config.yaml
returns "The input line is too long.
The syntax of the command is incorrect."

@chabdullahsiddique I've checked the documentation and the command works fine. Could you please give us more information? SO, Java version, etc...
Thanks!

I'm closing this issue. Feel free to reopen in needs?


.NET Standard

This page mentions .NET Core in the title and refers to Azure.Messaging.EventHubs as a .NET Core library. But shouldn't this instead say that .NET Standard is supported since that's the only dependency this library has? https://www.nuget.org/packages/Azure.Messaging.EventHubs/
This is important to clarify for us since we need to use EventHubs from a .NET Framework project and could possibly use the newer Azure.Messaging.EventHubs package via a dependent .NET Standard project.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 906c5c40-2451-beb8-1859-de648af134dc
Version Independent ID: 3cce140c-2d2c-60b9-aae0-4700aac22379
Content: Send or receive events from Azure Event Hubs using .NET (latest)
Content Source: articles/event-hubs/get-started-dotnet-standard-send-v2.md
Service: event-hubs
GitHub Login: @spelluru
Microsoft Alias: spelluru

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

@adiun Thanks for feedback. We have assigned the issue to the content author. They will evaluate and update the document as appropriate.
Hi @spelluru , seems like this doc needs to be enhanced, could you please have a look at this and update the content as appropriate. Thank you.

Looks like Jess (.NET SDK owner) has already updated the article.
#please-close


[Discuss] Separate component versioning

Right now all firebase-ui-{foo} modules are versioned together.  As the rates of change of the modules continue to diverge, this makes less and less sense.  I think we should change the model such that each module has its own version number, which we can update semantically (semver.org).
We can either remove the combined firebase-ui target, or set its version number to the maximum of all other modules.
Pros:

Stable modules don't see needless version updates

Cons:

Harder to discuss version numbers when debugging issues
Need to remember to release patch version bumps when underlying SDKs change
Release branch management becomes more complicated

@puf @SUPERCILEX @TheCraftKid @morganchen12 what do you think?

@mcdonamp Do you remember where we last had this discussion? It might be useful to dig that up to link/include here too.
@samtstern The regular Firebase Android SDK uses a single version for all modules. How does module versioning affect them differently than FirebaseUI?

We copied the model from the Firebase/Play services SDKs originally.  Their major version number tells you what major version of the service (Play services APK) it is compatible with.  And their minor versions don't differ mostly out of convenience.
We don't have a service to keep up with.  But, we do have a dependency on these underlying SDKs and if we moved to separate versions we would have to tell our developers not to mix different FirebaseUI versions in the same app because of transitive dependency collisions.

I think we should keep current versioning to be consistent with underlying Firebase Android SDK. People usually use auth with other modules so it is easy to maintain single version under one variable.

Oh, @krisu7 brings up a good point. I was going to say that separate versioning makes sense, but then the whole finding the right version issue comes up. I think it would make things really messy for people looking for the latest version of X module.
So that would be my only concern, making it easy for devs to find the right version of whatever module they're looking to import.

Yeah the more I think about it the less I like my original idea to use flexible versions...

I'm thinking we let the library use its own versions and force devs to explicitly define their own versions if that's a possibility. Because of the new api and implementation Gradle build options, wouldn't we be able to use separate versions of the Play Services libraries within the library but allow developers to specify separate versions, or does the rule about conflicting Play Services version apply to that, as well?

Yeah @SUPERCILEX, it is only issue I can think of atm
@TheCraftKid don't we do something similar already? Using the latest version of module and overriding play services and support dependencies?

@krisu7 Apparently not. I just checked the build.gradle files and they all use compile.

@TheCraftKid we haven't upgraded to the 3.0 plugin yet (though that's on my TODO list).

@SUPERCILEX Wouldn't that solve our problem, though? Oh, wait, the 3.0 plugin isn't stable yet, right?

Thanks everyone for the discussion, I think we will stay with a single version for now.


/entrypoint.sh: line 212: unexpected EOF while looking for matching `"'

Hello. I added docker image scan from git action to my CI course, but sometimes I get
/entrypoint.sh: line 212: unexpected EOF while looking for matching `"'

error.
      - name: Scan the docker that is the tag.
        if: ${{ github.ref_type == 'tag' }}
        uses: aquasecurity/trivy-action@master
        with:
          image-ref: ${{ steps.login-ecr.outputs.registry }}/${{ inputs.environment || 'dev' }}/vc-backend:${{ needs.get-image-tag.outputs.image_tag }}
          format: 'json'
          scan-type: image
          severity: 'CRITICAL,HIGH,MEDIUM,LOW,UNKNOWN'
          output: vc-backend.json
        env:
          AWS_DEFAULT_REGION: ap-northeast-2

Also reproduced on my pipeline:
0s
Run aquasecurity/trivy-action@master
/usr/bin/docker run --name b5d4574f422b560fc4ec7bca065ce9277da71_414fe0 --label 1b5d45 --workdir /github/workspace --rm -e "INPUT_SCAN-TYPE" -e "INPUT_IGNORE-UNFIXED" -e "INPUT_FORMAT" -e "INPUT_OUTPUT" -e "INPUT_SEVERITY" -e "INPUT_IMAGE-REF" -e "INPUT_INPUT" -e "INPUT_SCAN-REF" -e "INPUT_EXIT-CODE" -e "INPUT_VULN-TYPE" -e "INPUT_TEMPLATE" -e "INPUT_SKIP-DIRS" -e "INPUT_SKIP-FILES" -e "INPUT_CACHE-DIR" -e "INPUT_TIMEOUT" -e "INPUT_IGNORE-POLICY" -e "INPUT_HIDE-PROGRESS" -e "INPUT_LIST-ALL-PKGS" -e "INPUT_SCANNERS" -e "INPUT_TRIVYIGNORES" -e "INPUT_ARTIFACT-TYPE" -e "INPUT_GITHUB-PAT" -e "INPUT_TRIVY-CONFIG" -e "INPUT_TF-VARS" -e "INPUT_LIMIT-SEVERITIES-FOR-SARIF" -e "INPUT_DOCKER-HOST" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/glances/glances":"/github/workspace" 1b5d45:74f422b560fc4ec7bca065ce9277da71  "-a fs" "-b sarif" "-c " "-d " "-e true" "-f os,library" "-g CRITICAL" "-h trivy-results.sarif" "-i " "-j ." "-k " "-l " "-m " "-n " "-o " "-p " "-q " "-r false" "-s " "-t " "-u " "-v " "-x " "-z " "-y "
/entrypoint.sh: line 212: unexpected EOF while looking for matching `"'

Unatended char " in the last commit: https://github.com/aquasecurity/trivy-action/commit/ee6a4f5af1dbe22ccc11905a61abd2db301d532c
Please revert @arairyus

We are also facing the issue on github action while scanning the source code
/entrypoint.sh: line 212: unexpected EOF while looking for matching `"'

I'm facing the same issue since this morning. Any updates on this?

I think the pipeline didnt build the fixed image. Our CI/CD is also broken by this.

suddenly the pipeline started failing because of the /entrypoint.sh: line 212: unexpected EOF while looking for matching `"' this error

Sorry about that. I've reverted the last commit. https://github.com/aquasecurity/trivy-action/commit/7088d18dcb87884bc7b5a4000d5517d758e9aa13
It might be a good idea to pin to a release (instead of latest) to avoid such breakages in the future.

It might be a good idea to pin to a release (instead of latest) to avoid such breakages in the future

@simar7 This repo's README points to everyone using master. As long as this is the case, then master always needs to be fully stable.
This PR should have failed via an automated test.


refactor(Package.json): Add Breaking change for major release.

Also, upgrade circleci node config to 12.17.0

:tada: This PR is included in version 1.0.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: