Update README.md

added Link to documentation on the built-in Python implmentation
Proposed Changes

(Describe the changes and rationale behind them)

Related Issues

(Github link to related issues or pull requests)

This addition has no use, as the last version has already been shipped. This does not end up with the end-user.

Closing this PR for the above given reasoning.


[MILO][MEP] Update Manifest Type and Manifest Ordering

Problem statement: The current order that MEP executes manifests is based on the source of the manifest. Instead, we need to use the manifest type to be sure that the manifests execute in a logical order.
Requirements:

Separate Manifest Type "Test or Promo" into 2 separate items in the dropdown.
Add a Manifest Execution Order, default value "normal", other values "first" and "last"
Manifest order will first be determined the the manifest execution order field: first, normal then last.
If there is more than one manifest of the same "execution order", the manifest type will break the tie. First Personalization, Promo then Test.

Note, previously, we would:

run cleanManifestList to remove duplicates
loop through the manifests
fire runPersonalization for each manifest
within runPersonalization we would fire getPersConfig to get manifest contents

Because we now need to know the contents to determine the order, we now:

loop through the manifests
fire getPersConfig on each manifest to get contents
fire cleanAndSortManifestList to merge duplicate manifest data and sort manifests
loop through the manifests in their new sorted order
fire runPersonalization for each manifest

Resolves: MWPW-142965
Test URLs:
2 manifests (1 pzn and 1 test from Target):
Before: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/two-manifests-one-from-target
After: https://mepmanifestorder--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/two-manifests-one-from-target
3 manifests with one of each manifest type in the "wrong" execution order:
Before: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-all-normal
After: https://mepmanifestorder--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-all-normal
Same as above but one manifest using first:
Before: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-first
After: https://mepmanifestorder--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-first
Same as above but one manifest using last:
Before: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-last
After: https://mepmanifestorder--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-last
Same as above but old "Test or Promo" type being used:
Before: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-test-or-promo
After: https://mepmanifestorder--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-test-or-promo
Same as above but one has no info tab:
Before: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-no-type
After: https://mepmanifestorder--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-no-type
Improved merge also solves: https://jira.corp.adobe.com/browse/MWPW-143068
Before: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/outdated-manifest
After: https://mepmanifestorder--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/outdated-manifest

trying to debug.  Started a new PR on a new branch


How to save the mesh map or TSDF map in the right way.

Hi @YuePanEdward  nice work !
I am going to save the mesh results of voxfield following the comment here
/**
   * Mesh output settings. Mesh is only written to file if mesh_filename_ is
   * not empty.
   */
  std::string mesh_filename_;

I add a param in the launch file mai_voxfield.launch:
<param name="mesh_filename" value="$(find voxblox_ros)/mai_city.ply" />
but it seems not work.
I am not familiar with ROS at all. Could you give me some hints? Thanks much!

I got it in save mesh map.
I should open a new terminal and call save map service by inputting rosservice call /voxblox_node/generate_mesh "{}"
Now it works!
Thanks for your work again.


Add Ceylon entry to Code Style preferences

Related to #43

A few things are now configurable from the Code Style settings (more options will come later).


feat: Implement bot detection categories

This is mostly just codegen and a little bit of type updates.
I'm planning to add a new example for categories, with the additional demonstration of filtering items from a category.

@davidmytton I've added an example for the bot categories. Please try it out! I also included usage and details about your filtering request in the example.

Note to self: add this to dependabot and CI

@davidmytton did you test against the decide service running locally? Since the example is using an allow list, if you tested against the test or prod server, you'd get CURL denied (as categories aren't supported until it is deployed). I also ran into this when testing so the result looks familiar.


creation: channel enablement v0.0.1

Describe the solution you'd like
We will build a tool in Composer to allow a user to enable or disable certain "Channels" that are associated with the bot registration in Azure Bot Service.
Channels we are interested in:

Direct Line
Direct Line Speech
MS Teams

Each of these basically exists in either an "ON" or "OFF" state.  There may be some sub-options for some of the channels - this is still TBD.
It is possible to use the ARM bot service library to access the REST apis control these tools.  It is also possible to use the az cli -- though we should use the library, or make direct calls to the APIs.
This is the swagger for the API:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/botservice/resource-manager/Microsoft.BotService/stable/2020-06-02/botservice.json
These are the docs for the azure cli:
https://docs.microsoft.com/en-us/cli/azure/bot?view=azure-cli-latest
This will require auth tokens from Azure.  We should be able to use the same auth mechanisms at play in the publishing/provisioning flows.
Some tricky things we'll need to figure out:

The user will need to pick an existing app registration (stored in the publishing profiles) in order to make these API calls -- this is where we store the information about the registration.
We also want to provide a "manifest generator" for teams - this will basically just involve creating a json file with some values like the app id, password, name and URL of endpoint.
There may be some other minor sub-configurations per channel - or related information that can be displayed.
It would be really great if these evolved to look/act in a similar way to the upcoming declarative adapters, each of which will have its own set of a few configuration options driven by schema.  This is mostly about UX and information architecture.

We will need input from design on this, but the UI for this can most likely be realized as ON/OFF toggles.
We will need to first:
a) Request the current status of each channel
B) If toggled, send a separate request to enable or disable the channel on a given bot resource

Work is being tracked under a different issue #5632


refactor: improve comparison of selectTextobj()

Checklist

[x] Used only camelCase variable names.
[x] If functionality is added or modified, also made respective changes to the readme.
[x] Used conventional commits keywords.

This compares:

If cursor is on the text object.
Distance between cursor row and text object row.
Distance between cursor start col and text object start col.
Distance between cursor end col and text object end col.

It now works for the test case:
*a* *|b*

yie now selects b.

I am really sorry to say this, but a change of the size +37 -24 in the core logic is exactly the kind of change I mentioned in #70 to be opposed of to accommodate fringe cases, sorry.
I'd really think about rather making this possible in mdEmphasis, or through treesitter (you can use injections to use treesitter in doc-comments).

It may seem like a big change in terms of lines, but if you looked at the contents, it should be very simple and straightforward. Most of the change is just adding a .compareTuples() function  that Lua does not have. In Python I'd just use >=.
This is also more than a refactor, it's fixing a bug. You could claim it's a corner case, but bugs are always corner cases.
I can't see how I can do this in mdEmphasis(). If I do it there I'd have to basically copy my version of selectTextobj() anyway.
Tree-sitter with doc comments won't work too well either, as not everyone uses Markdown in their comments.
Could you please take another look? I really don't have many options here.

This is also more than a refactor, it's fixing a bug.

As I said more than once, selectTextobj is working as intended. It just does not cover your "misuse" of feeding it invalid textobjects. That is not a bug.
I'm pretty sure this is fixable with smarter patterns, since the anyQuoteobject does not have this problem.

Tree-sitter with doc comments won't work too well either, as not everyone uses Markdown in their comments.

Earlier you said, you cannot use Treesitter because prople have markdown in their doccomments. Now you say cannot use Treesitter because people do not use markdown in their comments.

I pushed commit da63878 which refactored mdEmphasis.

dropped support for bold+italics, since it's inconsistent to consider bold+italics, but not other markup combinations, making the behavior of the textobj less predictable. Also greatly reduced the code complexity.
Changed the patterns in a way that simplify the code and correctly deals with your **aaaa** **bbbbb** case. The trade-off is that this adds some edge cases regarding escaped markup characters. However, this is in my view acceptable, two consecutive emphasis objects are far more common than the remaining edge cases with escaped markup.

All in all, this reduced the complexity of mdEmphasis, fixed your case by trading a common problem case for a very uncommon edge case, and makes the behavior of the textobj more predictable for the user. I hope this is acceptable.
A more reliable solution would require Treesitter, which is definitely possible, but not something I have the time to implement right now.

Thanks for trying to fix this. Although my case still isn't really fixed, where the cursor is in a different position:
*|a* *b*

|a b

that case works on my end

I'm on commit 3c76c830.
When my cursor is there:

I press yie,   is selected.
I press yae, * * is selected.

*a* *b*
^^^__^^

When the cursor is on a ^ position, it works. When it's on a _ position, it does not work indeed, since that's just a limitation of working with patterns.
For anything else, please open a bug report since this is already very much off-topic.


[TBBAS-1592] Instance save/load fixes

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] Pull request title reflects its content
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Description:

As discussed, we should also connect signals to input ports in dependency order.


dev_postgres: Make documentation (README) surrounding the database better.

Right now I just very lazily stuck some notes at the bottom of the README. Let's get that house in order.

README:

Tell developers they need to install Postgres as a prerequisite to run the site.
Put initiation of the database as part of the setup, not at the bottom of the README. Setting up the database should not be its own section in the README.

Add a database.md guide to the /docs folder.

Tell them how to install Postgres (provide a link to the download instruction page), and tell them that they need to add Postgres to their system PATH, etc. all that basic setup stuff.
Be more detailed about what's going on here: In the README, just tell the reader what to do; in the docs, explain to the reader what is happening with each step.
Explain what is happening with flask init-db and flask update-db.
Try to incorporate your own troubles setting up the database and add some troubleshooting tips that helped you if you had any issues.

I will write up a readme as I'm working on it.

Status on this: We have a pretty good baseline in database.md. Not perfect, but that's fine for a lot of reasons: rough drafts / outlines are half the work, and also the database isn't even done yet so it's hard to document something that isn't done.
I'll keep this issue open because it's not 100% but I would not worry about it for now, so I'll mark as "low priority."
I've taken the mantle of updating the docs; I have a WIP version here: https://dwreeves.github.io/flagging


new analysis

@subinamehta the workflow image is a little bit large with 2.2MB can you add a smaller one?

@subinamehta the workflow image is a little bit large with 2.2MB can you add a smaller one?

Sure

Done!!

Great! Thanks @subinamehta!


Two-sided outlier filtering mode

Two-sided outlier filtering mode

Coverage increased (+0.07%) to 92.324% when pulling 4a12ba3caef988d027ec2cefc8f9fb666da2e58f on filter-negative-kpi-values into be6d6633c9b4f20ecc3f5eeef2d004c8ba7cd17d on master.

LGTM.
Approve.

@aaron-mcdaid-zalando what do you think?

Can you say more about what this is about. I recall us having a discussion internally some time ago, but I would like it specified somewhere. Perhaps as documentation.
The default is the compute the X percentile (where X is 99.9 by default for some users) and to discard values above that threshold
The change proposed here is:

Compute percentile X for all non-negative values and discard above that.
Compute percentile X for all negative values, and to discard values below

This scheme is proposed in order to have backwards compatibility for datasets that do not have any negative values - correct?

@aaron-mcdaid-zalando three methods that are implemented do the following:

drop x% of the largest values
drop x% of the smallest values
drop x/2% on both sides of the distribution.

Plus there is this heuristics that goes for 1) if all values are non-negative, for 2) if all values are non-positive, and for 3) if the values are sowohl als auch.

@aaron-mcdaid-zalando could you pls review the changes?

@aaron-mcdaid-zalando could you pls review the changes?

Conversations resolved, and another positive review added. :+1:


Unique uuid by content not by localization.

Hi I want to suggets if is possible give to the gestor the possibility of create an unique uuid by all the localizations of the same content.
I mean we have a product in spanish, english, french and russian, and we need the same uuid for all the languages. In other firlds we can disallow the i18n. I mean we need to create a link between them.
Is this possible?
Thanks for your contribution to the comunity.

yes. but uuid has own standarts. when we crypte country code or smh about it then add to uuid then it will not be uuid. lets named it cuuid.


Add environment variable for RPC calls

In some environments like Synology docker is already integrated using good UI.
It might be easier for end user to specify RPCAUTH variable instead of dealing with command line.

@sancoder totally understand. I think it would be a cool feature to translate command line arguments to variables, but usually it takes a bit of an effort. I'm open to merge this if you're willing to contribute some code with a PR, but right now I don't have enough time to work on this myself.
Hope you understand!


Setup FOSSA as part of CI

CATEGORY
Choose one

[ ] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[x] Build / Development Environment
[ ] Documentation

SUMMARY
FOSSA will help prevent regressions on importing non-ASF compatible licenses

You could add the script to github and pull from there of course...

@mistercrunch is the command actually executing correctly? It reports that it only does a stage 1 and that something cannot be build?


docs: core dev contributions

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the new behavior?
This breaks up the core contribution guidelines into smaller markdown files that storybook can use. Storybook makes it a bit easier to organize share but if there is a strong reason against it I can put it back into a single file. I also added a few new sections on reasons why certain things are built/created/organized. There are a few todos in there for additional content I'd like to add in later follow up PRs.
If there is anything incorrect or I forgot please let me know. Happy to polish this up as much as needed.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coryrylan
Do we want to get this in for the v4 release? Please add the v4 label and let @gnomeontherun know if so.


Code action menu overlaps diff

Describe the bug
As you can see the code action menu overlaps the diff, maybe make the diff be beside the code action menu? I think it'd also be cool to be able to disable the diff.

Steps to reproduce
Use the code action menu, maybe you'll need a menu with more entries, in my case I'm using dart LSP.
Expected behavior
Be able to see the diff clearly without overlapping.
Neovim version (nvim -v)
0.8.2
Operating system/version
Ubuntu, Linux 5.4.0-42
Terminal name/version
kitty 0.26.3
$TERM environment variable
xterm-kitty

Thanks for the quick fix. I love lspsaga


iOS: Install Node 10 as 8 got dropped

Summary
We recently bumped our engine requirement in #28174.
Changelog
[Internal] [Fixed] - Install Node 10 as is required
Test Plan
test_ios_e2e should start building again.

cc @safaiyeh, @hramos


Add "website-change-monitor" to the "Open Source" list

Add Website Change Monitor to the "Open Source" list.
Repo Description
Website Change Monitor : A small web app written in Node.js to monitor specific changes on a web page and get email and Slack notifications.

Closed via https://github.com/edgi-govdata-archiving/awesome-website-change-monitoring/commit/daf29295b7e26100e4e95d95ba72a7b3751af717


Override document title for index.rst

The index page has <no-title> -- PostgREST <IP_ADDRESS> Documentation for HTML title, using the title directive, we can force it to something nicer.
I'm not sure if this fixes it at the top of the page.
http://docutils.sourceforge.net/docs/ref/rst/directives.html#metadata-document-title
http://www.sphinx-doc.org/en/stable/rest.html#directives

You're the best, thank you! That had been bugging me but I never quite got around to it.
Just tested your change locally and it works.

Just noticed there is no readme explaining how to preview the docs locally.
The steps are

install sphinx
sphinx-build -b html -a -n . _build

To see code changes reflected in the browser immediately you can also leave this running: sphinx-autobuild -b html -a -n . _build


Fix generation of config file if several apps internally use same id for their intents

we have several ui5 apps in same cap project, all (internally) using "intent1" as ID for the intent, which is perfectly valid.
Bug was introduced in 1.0.5 - all apps are generated into one single intent: "intent1", which breaks navigation. Prior to 1.0.5, the app id was used as tile config ids (e.g. "com.sample.app1", "com.sample.app2")
Fixed in this pull request. new tile config id is a combination of the app id and tile config id. e.g. "com.sample.app1-intent1", "com.sample.app2-intent1")
(second commit in the PR just replaces most of the let declarations by const (where appropriate))

Thanks! missed that bug myself!
Just published the new version to NPM!


chore: use @tsconfig/node16

Following up #14460
Summary
The lowest supported Node.js version got increased. It’s time to move to @tsconfig/node16 as well (;
Test plan
Green CI.

Ah, forgot this one 👍

@mrazauskas https://github.com/jestjs/jest/blob/1a96a5c6a348dd3bf9134813d1a99e6273f53ec2/scripts/verifyOldTs.mjs#L55

Thanks! I will look at it in the morning.


header.php does not use body_class()

I saw in the header the opening body tag <body class="site__body">
It does not use body_class()
Is there a reason why it is not using it?
IMO it should be:
<body <?php body_class('site__body') ?>>

Thanks for the question! :)
Yes, this was done on purpose. The wp body_class method produces a lot of classes and 99% of the time we found in our projects we did not need or use them or, even worse, they conflicted with names that we wanted to use as BEM blocks on the page (eg page). That's why I specifically chose to omit this commonly used method from the starter's header.php.
The class-walker-nav-menu.php was also implemented to solve a very similar issue we were having with the WP menu. With it, you can have a WP menu with the class modifiers you want and all class names following the BEM naming convention instead of a "mess" of classnames that are only sometimes useful.
Of course, if you do find the output of body_class useful then there is nothing wrong with that! :) Feel free to add it when developing, but I do not think we will add it to the starter!

In addition to @Maximilianos answer, you can also add it this way:
I am using the body_class() function by default in my forked version of this boilerplate, because it allows me to easily add body_class via the 'WordPress way'. But I am not using all the default WordPress classes anymore.
add_filter( 'body_class', [ $this, 'filter_body_class' ], PHP_INT_MAX );
`	/**
* Removes default body_classes and adds needed classes for this project
*
* @param $classes
*
* @return array
*/
public function filter_body_class( $classes ) {
$classes   = [];
$classes[] = 'site__body';
		if ( is_admin_bar_showing() ) {
			$classes[] = 'site__body--adminbar';
		}

		return $classes;
	}`


Time error

period_status == Final but game_clock != "". (see image)

Probably due to delay in update time by NBA. Choose time status (thing in brackets) based on period_status rather than game_clock.

Fixed https://github.com/kshvmdn/NBAScores/commit/58c1d174fcd214004926b7f4145a26ec209dbf24

Fixed https://github.com/kshvmdn/NBAScores/commit/58c1d174fcd214004926b7f4145a26ec209dbf24


Python3 support ?

Collecting https://github.com/google/google-visualization-python/zipball/master (from -r requirements.txt (line 9))
Downloading https://github.com/google/google-visualization-python/zipball/master
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/private/var/folders/94/_b72550n6x9bbrdcdw7w694m0000gn/T/pip-xi2ugjee-build/setup.py", line 23, in
import gviz_api_test
File "/private/var/folders/94/_b72550n6x9bbrdcdw7w694m0000gn/T/pip-xi2ugjee-build/gviz_api_test.py", line 30, in
from gviz_api import DataTable
File "/private/var/folders/94/_b72550n6x9bbrdcdw7w694m0000gn/T/pip-xi2ugjee-build/gviz_api.py", line 30, in
import cStringIO
ModuleNotFoundError: No module named 'cStringIO'

The gviz_api supports some very old python versions which made writing a single py3 version tricky.  I built a py2.7/py3 version and created a pull request but I don't know if google is actively maintaining this repo anymore.  You can find my py3 file in the pull requests.

This is now fixed in #40

This is now closed in #40


yarn start trouble error

You need to use the custom typings here https://github.com/LongTailBio/pangea-client/tree/master/src/%40types


Sidenav Tokens

Description
New Side navigation (component) tokens:

side-navigation-width
side-navigation-minimum-width
side-navigation-maximum-width
side-navigation-second-level-edge-to-text
side-navigation-third-level-edge-to-text
side-navigation-with-icon-second-level-edge-to-text
side-navigation-with-icon-third-level-edge-to-text
side-navigation-item-to-item
side-navigation-item-to-header

Related Issue
DNA-1277
Motivation and Context
:art:  Design changes:
Navigation item background tokens use a solid color
Navigation item background (selected) use a solid color
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Run report for 758c86c9
Total time: 31.2s | Comparison time: 45.6s | Estimated savings: 14.4s (31.6% faster)

Action
Time
Status
Info

🟩
SetupNodeTool(18.13.0)
3.3s
Passed

🟩
InstallNodeDeps(18.13.0)
25s
Passed

🟩
SyncNodeProject(tokens)
1ms
Passed

🟪
RunTarget(tokens:build)
15.3ms
Cached

🟩
RunTarget(tokens:generateDiffResult)
2.9s
Passed

🟩
RunTarget(tokens:test)
1.3s
Passed

🟪
RunTarget(tokens:buildManifest)
1.6s
Cached

🟩
RunTarget(tokens:noop)
4.5ms
Passed

Touched files
packages/tokens/package.json
packages/tokens/src/layout-component.json
pnpm-lock.yaml


main to prod-beta

main to prod-beta:boom:
Please title this PR with a summary of the change, along with the JIRA card number.
Suggested formats:

Fixes/Refs #RHIROS-XXX - Title
RHIROS-XXX Title

Feel free to remove this section from PR description once done.
Why do we need this change? :thought_balloon:
Please include the context of this change here.
Documentation requires update? :memo:

[ ] Yes
[ ] No

Security Checklist :lock:
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
:guardsman: Checklist :dart:

[ ] Bugfix
[ ] New Feature
[ ] Refactor
[ ] Unittests Added
[ ] DRY code
[ ] Dependency Added

Additional :mega:
Feel free to add any other relevant details such as links, notes, screenshots, here.

Codecov Report
Patch coverage: 9.52% and project coverage change: -1.82 :warning:

Comparison is base (fb10ab4) 22.35% compared to head (860654a) 20.53%.

:exclamation: Current head 860654a differs from pull request most recent head f60c4d2. Consider uploading reports for the commit f60c4d2 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           prod-beta     #184      +/-   ##
=============================================
- Coverage      22.35%   20.53%   -1.82%
=============================================
  Files             48       42       -6
  Lines            935      852      -83
  Branches         171      150      -21
=============================================
- Hits             209      175      -34
+ Misses           677      630      -47
+ Partials          49       47       -2

Impacted Files
Coverage Δ

src/Components/HistoricalDataChart/UtilTestData.js
100.00% <ø> (ø)

src/Components/Reports/ExecutivePDFReport.js
0.00% <0.00%> (ø)

src/Components/Reports/Util.js
92.68% <ø> (-3.21%)
:arrow_down:

src/Components/Reports/UtilTestData.js
100.00% <ø> (ø)

src/Utilities/api.js
0.00% <0.00%> (ø)

src/Components/Reports/Constants.js
100.00% <100.00%> (ø)

src/constants.js
70.37% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


luarocks install not working

Hi there, I installed lua and luarocks as shown and I am not able to install packages using luarocks.
For example when I type luarocks install nngraph it returns
Error: No results matching query were found.
I am able to run the notebooks though.

This is an unfortunate gotcha of a) the luarocks version I'm using and b)
luarocks in general.
The luarocks that comes with torch adds special packages, like the one
you're trying to install.
I include the "vanilla" luarocks with my lua distribution. So, if you want
to install Torch packages

Clone the github repo
cd into it
luarocks install {path_to_the_rockspec}

On Tue, Oct 18, 2016 at 10:31 PM angelleng<EMAIL_ADDRESS>wrote:

Hi there, I installed lua and luarocks as shown and I am not able to
install packages using luarocks.
For example when I type luarocks install nngraph it returns
Error: No results matching query were found.
I am able to run the notebooks though.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/alexbw/bayarea-dl-summerschool/issues/3, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAJ4jzKom7Csk22o_A2fqutMHBt4-g37ks5q1YEWgaJpZM4Kaf0w
.


Move foundry-angular-ui to a separate repo, un-monorepo the repo

In order to add new JS features like null coalescing and optional chaining, webpack needs to be updated to v5+. Webpack 5 doesn't seem to work in monorepos. (TypeError: The 'compilation' argument must be an instance of Compilation)
foundry-angular-ui is also not being supported at the moment with no plans to pick it back up. (react-native port is higher priority for the Headstorm team at the moment)
AC:

create new repo in Headstorm/ for foundry-angular-ui
rename this repo to foundry-react-ui
move the foundry-react-ui folder to the root and remove lerna
update all build steps/actions as well as any webpack config that is broken in the process

The angular codebase has been copied to a private repository inside the Headstorm git organization, I'm now in the process of safely removing it from this repo.


[FLINK-26050] Manually compact small SST files

In some cases, the number of files produced by RocksDB state backend grows indefinitely.
This might cause task state info (TDD and checkpoint ACK) to exceed RPC message size and fail recovery/checkpoint in addition to having lots of small files.
With this change, such files are merged in the background using RocksDB API.
Verifying this change
Added tests:

CompactionSchedulerTest
CompactionTaskProducerTest
EmbeddedRocksDBStateBackendTest#testSmallFilesCompaction

Verified manually, deployed to Production internally.

@flinkbot run azure

@flinkbot run azure

@rkhachatryan since the manual compaction would introduce extra CPU & IO, and it would impact the block-cache with the change of level structure. I think we could also add a doc to tell users how it impacts the throughput/core with the nexmark.


Force a hard timeout on Live resources.

The urllib3 timeout gets reset when data comes through - so a slow service that returns a little bit of data before each timeout window can keep us locked up for an indefinite amount of time.  This sets an alarm to force termination.

Coverage decreased (-0.05%) to 86.328% when pulling 2ed11dd5883c1c1d30e16bb5134f242bb99cb94e on bugfix/total-timeout into f4e0092451e76dfed77f382ce9922b08fc5cd039 on develop.


Planner crash  during simulation and optim node on ROS Melodic from src

Hi,
I tested the planner on the online tutorial of robotignite with the husky : https://www.robotigniteacademy.com/en/course/teb-local-planner/details/
Our lab robot is also a husky with various sensors, I transferred all the parameters to my Gazebo simulation from robotignite tutorial.
I have various problems such as missed loop updates on the simulation.
I tested the optim node and realize that the parameter /test_optim_node/enable_homotopy_class_planning shutdown the optim node when I started playing around on RVIZ.
tsimon@GL503GE:~/teb_catkin_ws$ rosparam set /test_optim_node/enable_homotopy_class_planning True
/opt/ros/melodic/lib/python2.7/dist-packages/rosparam/__init__.py:370: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  set_param_raw(param, yaml.load(value), verbose=verbose)
tsimon@GL503GE:~/teb_catkin_ws$ roslaunch teb_local_planner test_optim_node.launch
... logging to /home/tsimon/.ros/log/ee5d56fe-a572-11ea-a3eb-91d3f2cf57d9/roslaunch-GL503GE-29609.log
Checking log directory for disk usage. This may take awhile.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.

started roslaunch server http://GL503GE:40715/

SUMMARY
========

PARAMETERS
 * /rosdistro: melodic
 * /rosversion: 1.14.3

NODES
  /
    rviz (rviz/rviz)
    test_optim_node (teb_local_planner/test_optim_node)

ROS_MASTER_URI=http://localhost:11311

process[test_optim_node-1]: started with pid [29635]
process[rviz-2]: started with pid [29642]
[ INFO] [1591174894.346716833]: No robot footprint model specified for trajectory optimization. Using point-shaped model.
[test_optim_node-1] process has died [pid 29635, exit code -11, cmd /home/tsimon/teb_catkin_ws/devel/lib/teb_local_planner/test_optim_node __name:=test_optim_node __log:=/home/tsimon/.ros/log/ee5d56fe-a572-11ea-a3eb-91d3f2cf57d9/test_optim_node-1.log].
log file: /home/tsimon/.ros/log/ee5d56fe-a572-11ea-a3eb-91d3f2cf57d9/test_optim_node-1*.log

It seems to occur when I had the 2nd obstacle

Here is the parameter list for the husky
controller_frequency: 3.0
recovery_behaviour_enabled: true

NavfnROS:
  allow_unknown: true # Specifies whether or not to allow navfn to create plans that traverse unknown space.
  default_tolerance: 0.1 # A tolerance on the goal point for the planner.

TebLocalPlannerROS:

 odom_topic: odometry/filtered

 # Trajectory

 teb_autosize: True
 dt_ref: 0.3
 dt_hysteresis: 0.1
 global_plan_overwrite_orientation: True
 allow_init_with_backwards_motion: False
 max_global_plan_lookahead_dist: 3.0
 feasibility_check_no_poses: 5

 # Robot

 max_vel_x: 2.0
 max_vel_x_backwards: 2.2
 max_vel_y: 0.0
 max_vel_theta: 2.0
 acc_lim_x: 2.5
 acc_lim_theta: 2.5
 min_turning_radius: 0.0 # diff-drive robot (can turn on place!)

 footprint_model:
   type: "point"

 # GoalTolerance

 xy_goal_tolerance: 0.2
 yaw_goal_tolerance: 0.1
 free_goal_vel: False

 # Obstacles

 min_obstacle_dist: 0.75 # This value must also include our robot radius, since footprint_model is set to "point".
 include_costmap_obstacles: True
 costmap_obstacles_behind_robot_dist: 1.5
 obstacle_poses_affected: 30
 costmap_converter_plugin: ""
 costmap_converter_spin_thread: True
 costmap_converter_rate: 5

 # Optimization

 no_inner_iterations: 5
 no_outer_iterations: 4
 optimization_activate: True
 optimization_verbose: False
 penalty_epsilon: 0.1
 weight_max_vel_x: 2
 weight_max_vel_theta: 1
 weight_acc_lim_x: 1
 weight_acc_lim_theta: 1
 weight_kinematics_nh: 1000
 weight_kinematics_forward_drive: 1
 weight_kinematics_turning_radius: 1
 weight_optimaltime: 1
 weight_obstacle: 50
 weight_dynamic_obstacle: 10 # not in use yet
 weight_adapt_factor: 2

 # Homotopy Class Planner

 enable_homotopy_class_planning: True
 enable_multithreading: True
 simple_exploration: False
 max_number_classes: 4
 selection_cost_hysteresis: 1.0
 selection_obst_cost_scale: 1.0
 selection_alternative_time_cost: False

 roadmap_graph_no_samples: 15
 roadmap_graph_area_width: 5
 h_signature_prescaler: 0.5
 h_signature_threshold: 0.1
 obstacle_keypoint_offset: 0.1
 obstacle_heading_threshold: 0.45
 visualize_hc_graph: False

Do you have a docker file to check everything on melodic ?
Should I check other parameters due to kinetic version on robotignite ?

I made a fresh update of the source code use with
rosinstall_generator teb_local_planner --rosdistro melodic --deps --tar  --deps-depth 2 > teb_planner.rosinstall
No changes

Seems to be g2o or boost
(gdb) backtrace
#0  __GI___libc_free (mem=0x65) at malloc.c:3102
#1  0x00007ffff758c538 in g2o::OptimizableGraph::~OptimizableGraph() () from /usr/local/lib/libg2o_core.so
#2  0x00007ffff7ecdad8 in boost::detail::sp_counted_impl_pd<g2o::SparseOptimizer*, boost::detail::sp_ms_deleter<g2o::SparseOptimizer> >::dispose() ()
   from /home/tsimon/teb_catkin_ws/devel/lib/libteb_local_planner.so
#3  0x00007ffff7ecd702 in teb_local_planner::TebOptimalPlanner::~TebOptimalPlanner() () from /home/tsimon/teb_catkin_ws/devel/lib/libteb_local_planner.so
#4  0x00007ffff7ecd79d in teb_local_planner::TebOptimalPlanner::~TebOptimalPlanner() () from /home/tsimon/teb_catkin_ws/devel/lib/libteb_local_planner.so
#5  0x00005555555a302a in boost::detail::sp_counted_base::release() ()
#6  0x00007ffff7f11640 in teb_local_planner::HomotopyClassPlanner::renewAndAnalyzeOldTebs(bool) () from /home/tsimon/teb_catkin_ws/devel/lib/libteb_local_planner.so
#7  0x00007ffff7f11e30 in teb_local_planner::HomotopyClassPlanner::exploreEquivalenceClassesAndInitTebs(teb_local_planner::PoseSE2 const&, teb_local_planner::PoseSE2 const&, double, geometry_msgs::Twist_<std::allocator<void> > const*) () from /home/tsimon/teb_catkin_ws/devel/lib/libteb_local_planner.so
#8  0x00007ffff7f11f7c in teb_local_planner::HomotopyClassPlanner::plan(teb_local_planner::PoseSE2 const&, teb_local_planner::PoseSE2 const&, geometry_msgs::Twist_<std::allocator<void> > const*, bool) ()
   from /home/tsimon/teb_catkin_ws/devel/lib/libteb_local_planner.so
#9  0x000055555559749d in CB_mainCycle(ros::TimerEvent const&) ()
#10 0x00007ffff7bbd19f in ros::TimerManager<ros::Time, ros::Duration, ros::TimerEvent>::TimerQueueCallback::call() () from /opt/ros/melodic/lib/libroscpp.so
#11 0x00007ffff7bdf018 in ros::CallbackQueue::callOneCB(ros::CallbackQueue::TLS*) () from /opt/ros/melodic/lib/libroscpp.so
#12 0x00007ffff7bdfcd3 in ros::CallbackQueue::callAvailable(ros::WallDuration) () from /opt/ros/melodic/lib/libroscpp.so
#13 0x00007ffff7c32809 in ros::SingleThreadedSpinner::spin(ros::CallbackQueue*) () from /opt/ros/melodic/lib/libroscpp.so
#14 0x00007ffff7c1b4bf in ros::spin() () from /opt/ros/melodic/lib/libroscpp.so
#15 0x00005555555967cc in main ()

@tomlogan501  I have been facing the same issue. when i installed the package using
apt-get in stall ros-kinetic-teb-local-planner
the node keeps shutting down the same way you said.
I also tried to build the package from source but was unable to do so and it shows some error with the g2o
/navigation_ws/src/navigation/teb_local_planner/src/optimal_planner.cpp:172:91:
error: no matching function for call to ‘g2o::BlockSolver<g2o::BlockSolverTraits<-1, -1> >::BlockSolver(std::remove_reference<std::unique_ptr<g2o::LinearSolverCSparse<Eigen::Matrix<double, -1, -1> > >&>::type)’
   std::unique_ptr<TEBBlockSolver> block_solver(new TEBBlockSolver(std::move(linear_solver)));

tried with both using kinetic-devel branch and  melodic-devel branch but no luck
ros distro : kinetic
ubuntu: 16.04

Even in the rviz tutorial with the 3 obstacles ?

Even in the rviz tutorial with the 3 obstacles ?

yes

I am seeing the same issue with packages that I built for melodic. It might be related to g2o?

same issue! after installing from source melodic-devel branch
~/utilities/ws_rviz/src/teb_local_planner/cfg$ rviz --display-config ~/software/SpaceRoboticsChallenge/layout/rviz_test_optim.rviz
[ INFO] [1600266201.514917781]: rviz version 1.13.13
[ INFO] [1600266201.514966501]: compiled against Qt version 5.9.5
[ INFO] [1600266201.514983948]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1600266201.518589443]: Forcing OpenGl version 0.
[ INFO] [1600266202.079832253]: Stereo is NOT SUPPORTED
[ INFO] [1600266202.079898053]: OpenGl version: 4.6 (GLSL 4.6).
Segmentation fault (core dumped)

same issue! after installing from source melodic-devel branch
when running the rviz and test_optim_node seperately, then only RVIZ will crash, not the test_optim_node
~/utilities/ws_rviz/src/teb_local_planner/cfg$ rviz --display-config ~/software/SpaceRoboticsChallenge/layout/rviz_test_optim.rviz
[ INFO] [1600266201.514917781]: rviz version 1.13.13
[ INFO] [1600266201.514966501]: compiled against Qt version 5.9.5
[ INFO] [1600266201.514983948]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1600266201.518589443]: Forcing OpenGl version 0.
[ INFO] [1600266202.079832253]: Stereo is NOT SUPPORTED
[ INFO] [1600266202.079898053]: OpenGl version: 4.6 (GLSL 4.6).
Segmentation fault (core dumped)

I'm having the same issue, i'm using melodic packet manager version and i'm up to date with everything

Similar issue at #131 , deactive "Marker" in display panel and reactive before drag obstacles or publish point might work.


Fixing the tag name for %pre - preinstall script

What does this PR (Pull Request) do?

[x] This PR fixes #4882

Which Traffic Control components are affected by this PR?

Traffic Router

This doesn't require any documentation since it fixes only the install time defect.
What is the best way to verify this PR?
Upgrade and make sure the following is getting printed during upgrade.
Preparing...                          ################################# [100%]
Deleting previous version of Traffic Router webapp

The following criteria are ALL met by this PR

[x] Tests are unnecessary
[x] I have explained why documentation is unnecessary
[ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

Would you mind adding a changelog entry? We're trying to do that with all bugs from now on. I think it's also preferred that all bugs have related Issues, but you don't have to do that if you don't want to.

Addressed @ocket8888 comments on CHANGELOG.

I'll be happy to merge when conflicts are fixed

@Vijay-1 - can you fix the conflict so this can be merged?

I fixed the conflict


Wrong content in the docs related to Linked Social accounts

Is your suggestion related to a missing or misleading document? Please describe.
Refer the doc in https://is.docs.wso2.com/en/latest/learn/associating-user-accounts/

Added below config to deployment.toml
[user.association]
enable_for_federated_users = true

Access myaccount > personel info > Linked social accounts

As per the doc we cant do this association through myaccount. This can be done by rest apis or adaptive scripts. WE need to check and update this outdated content
pls refer https://medium.com/identity-beyond-borders/social-account-linking-with-wso2-identity-server-78b8a566e225

Check this comment for linking federated accounts: https://github.com/wso2/product-is/issues/13573#issuecomment-1110852040
Check this comment for linking local account: https://github.com/wso2/product-is/issues/13573#issuecomment-1111732726

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Restyle individual bots.

This restyles the individual bots to be in a grid and to look more
modern than the last setup.

Automated message from Dropbox CLA bot
@brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks!

I think the inline editing UI isn't going to work at this size, given:

(and that's without the owner-change feature)

Updated with UI fixes.

Merged, after fixing some of the whitespace in the templates.
@adnrs96 how hard would it be to enable your 4-space indent check to run in our linters for all the files except for the few we haven't cleaned yet?

It shouldn't be hard i believe, i am looking into it now.


Make NCronJob native AOT ready

Currently, NCronJob is not native AOT ready. That might be a less ideal choice for folks who run this library in the cloud and try to minimize the footprint.
There is a nice article from Microsoft itself: https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/
Basically what we want is:

Add the analyzers:

<PropertyGroup>
    <IsAotCompatible>true</IsAotCompatible>
</PropertyGroup>

Fix all errors
Create a new sample with native aot and publish the app and check if it is still doing its thing.

In the past have added AOT support to a few apps so I checked what I could do to help.
There are 3 incompatible parts:

The easy. In NCronJobOptionBuilder the code must pass the warning upstream to the user of the library with the attribute
[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)]
The compiler will warn the client code if something is unsupported by AOT.

In JobExecutor there is a call to
ActivatorUtilities.CreateInstance
this line will never be AOT compatible. It will need a breaking change, requiring all needed types to be registered in the IOC container. But is simple to do.

In JobExecutor there is a call to
MakeGenericType
this is more complicated and will requiere a redesign to as how the notifications are handled.

Those are my two cents, and seeing this issue I thought on discussing it and see how can I help.

Just adding, the updated documentation says to use IsTrimmable instead of IsAotCompatible in libraries
https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming?pivots=dotnet-8-0

@pablopioli Interesting - I can't find where IsTrimmable is a replacement for IsAotCompatible - more or less IsTrimmable is a precursor for AOT.

In JobExecutor there is a call to ActivatorUtilities.CreateInstance

Yeah - this kind of a fallback or convenient method if you forgot to register a job. We could also just "fail" in those moments.
@falvarez1 and I had some discussion around that topic.

In JobExecutor there is a call to MakeGenericType this is more complicated and will requiere a redesign to as how the notifications are handled.

Yes - could we "ignore" that somehow and tell the compiler that we never run into the issue that the type might be trimmed out at this point in time? If the user didn't register IJobNotificationHandler<> properly you can't get into the code.

@pablopioli Interesting - I can't find where IsTrimmable is a replacement for IsAotCompatible - more or less IsTrimmable is a precursor for AOT.

https://learn.microsoft.com/en-us/dotnet/core/deploying/native-aot
The important one for a library is the trim analyzer. The trim process is very agressive and if unsure it will default to remove the member. With properties there is not much of a problem, you use it or not. But for a library like this the constructors are very problematic. NCronJob could just not find any constructor at all.
The other analyzers are for single file deployment (that is a decision for the consuming app) and the AOT analyzer (if your library can support trimming the tooling will simply convert the bytecode to native code.)

In JobExecutor there is a call to ActivatorUtilities.CreateInstance

Yeah - this kind of a fallback or convenient method if you forgot to register a job. We could also just "fail" in those moments. @falvarez1 and I had some discussion around that topic.

Yes, it is more a design decision than a technical one.

In JobExecutor there is a call to MakeGenericType this is more complicated and will requiere a redesign to as how the notifications are handled.

Yes - could we "ignore" that somehow and tell the compiler that we never run into the issue that the type might be trimmed out at this point in time? If the user didn't register IJobNotificationHandler<> properly you can't get into the code.

No, you can't suppress trimming warning. You can ignore them if you are sure that it will not fail anyway. The compilation process will warn you but the program will run without problems. Unless you are treating warning as errors and then you are toasted.

We can live with the current state. Given that this was just an idea and not a real "need", we can keep it in the backlog.
That said I appreciated your input a lot @pablopioli! Let me know if you have other ideas!

@linkdotnet Do we want to pave the way for this in v4?
As identified in #106, we could
Maybe add a .UseNCronJob() extension method that would harvest the JobRegistry
and ensure every described type has been previously registered.
Otherwise, throw an InvalidOperationException ("The following types haven't
been registered in the dependency injection container: ...").

And then drop the call to ActivatorUtilities.CreateInstance in JobExecutor.

I have to check some issues and prs - I can vaguely remember why the code is there, but have to dig a bit deeper.
basicslly we wanted to make it easier for users in certain scenarios


Limit access to a folder

It would be great to have a CLI option to limit the access of code-server to a particular folder, so users cannot read or write outside that folder. Something like:
server-code --data-dir $HOME/public-projects

We don't provide that functionality, but if you're a seasoned Linux veteran or taken Red Hat courses regarding Linux permissions, chmod and chown serves this purpose for you.

As for preventing the user to invoke cd to the folder, that's something we can't do. Perhaps container-based development workspaces might be your thing?

Linux permissions, chmod and chown serves this purpose for you.

Yes, it could work for the Terminal. But what about this dialog?

Is there a way we can limit it to a particular folder?

Perhaps container-based development workspaces might be your thing?

Yes, I guess it is the most secure solution. Thanks for your quick answer.

@PhaserEditor2D there's nothing we can solve about that, that's intended by design.

Thanks anyway!

came here looking for the same thing. Seems weird to give anyone root level access to a server. Has anyone figured out a solution yet?

@joeshub Run code-server as a different user and only allow that user to edit those files. Or chroot code-server into that directory.

I would suggest to run code-server in docker and mount a host OS folder into that docker container


Support elliptical mask shapes

This PR adds the feature to specify elliptical masks. In the mask section of the config file, all three of "a", "b", and "angle" (see documentation of lenstronomy.Util.mask_util.mask_ellipse() for definitions) should be provided instead of "radius" for the elliptical mask to be created.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.51%. Comparing base (03e1a95) to head (c9ce44f).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   99.50%   99.51%
=======================================
  Files           8        8
  Lines        1015     1021    +6
=======================================
+ Hits         1010     1016    +6
  Misses          5        5

Files with missing lines
Coverage Δ

dolphin/processor/config.py
99.50% <100.00%> (+<0.01%)
:arrow_up:


Change text binding behavior for editing text

This pull request is relating to https://github.com/SwiftBond/Bond/issues/64 issue. This puts more importance on user input  and simpler than https://github.com/SwiftBond/Bond/pull/61 .
I use isFirstResponder() because UITextView doesn't have editing property.

Fix in v3.7.2. Thanks!


change copyright year in footer

Coverage remained the same at 42.114% when pulling 05b3cc15b13a217d56ca168ef16f75ac44296385 on hetmanchuk:master into 4b50f89324ad3b3fd475ce725c55a99b4e4eedfc on supergiant:master.


Allow Icons color for payments icons

What:
Allow all icons on payments to get custom color

Why:
Closes 20
The problem is due to the fact of clustering together brand icons like Visa with other payment icons like BankNoteIcon while the former one shouldn't allow color but the other should support color updates

How:
Remove payments from the exclude-color flag on npm run generate

Media:
https://www.loom.com/share/155f0dd56e9547e5ab04519171d315a6
Checklist:

[x] Release notes added
[ ] Ready to be merged

I think we should be strict with the interface definition and we should separate icons payments from icons that belongs to payments brand

Following your proposal, I think we can just add brands folder and keep all the logos there

I have created a dedicated folder for brands. In that sense, I have updated the code accordingly and now the documentation looks like


Model Persist/Load with Hadoop File Server

Description of Problem:
Currently only two methods exist in code for model saving and loading - either locally only, or locally first, and then uploading it to cloud. What I need is another method / embedded code for creating a temporary .tar file in memory for the RasaNLUInterpreter and then directly uploading to HDFS. Similarly, it should be downloaded from there directly from the URL/.tar file too.
Overview of the Solution:
You can look at TensorFlow Hub's Implementation for Model Saving and Loading - they save .tar.gz files that can be saved or loaded directly from any URL, even though the model has multiple files to save as individual components.
Examples (if relevant):
import tensorflow_hub as hub
model_url = 'http://<IP_ADDRESS>:50070/webhdfs/v1/user/root/NLPEngine/universal_sentence_encoder_large_5.tar.gz?op=OPEN'
model = hub.load(model_url)

Blockers (if relevant):
Currently because every component in RASANLUInterpreter's Pipeline expects a model-directory for saving to be a local path, its becoming too difficult to manually overwrite every component's persist method in order to save RASA Models to Hadoop File Server.

Thanks for submitting this feature request 🚀 @yennycheung will get back to you about it soon! ✨


Publish a container image for Apple M1 machines

Bug Description
Crash on Docker for Mac Kubernetes, M1 chip.

Cloud SQL Proxy version (./cloud_sql_proxy -version): 1.22.0

The M1 is an ARM chip and the stack trace says asm_amd64, which makes me think it's not running an ARM binary. Which docker image are you using?

@hazcod Can you confirm which docker image you're using?

This is the official one, but it might be emulated Docker for Mac via qemu I guess to x86?

I assume you're using the default image and not alphine or buster.
In any case, this should just work, but perhaps there's still an issue here with Docker? We'll investigate.

How are you starting your container? I see there are some known issues with Docker on the M1 chip:

Not all images are available for ARM64 architecture. You can add --platform linux/amd64 to run an Intel image under emulation. In particular, the mysql image is not available for ARM64. You can work around this issue by using a mariadb image.

https://docs.docker.com/docker-for-mac/apple-silicon/#known-issues

Note: the link above recommends running ARM64 containers on Apple Silicon. Recently distroless added support for ARM64.

We probably need to do something special to support ARM64 in the default container. Until then I think using the emulation flag as Eno described above is a suitable work around.

For reference how I run it via Kubernetes on Docker for Mac:
apiVersion: apps/v1
kind: Deployment

metadata:
  namespace: "{{ .Values.namespace }}"
  name: "{{ .Values.name }}-api"

  labels:
    app: "{{ .Values.name }}"
    owner: "{{ .Values.owner }}"

spec:
  replicas: {{ .Values.replicaCount }}

  selector:
    matchLabels:
      app: "{{ .Values.name }}"
      component: "api"

  strategy:
    type: Recreate

  template:

    metadata:

      labels:
        app: "{{ .Values.name }}"
        owner: "{{ .Values.owner }}"
        component: "api"

      annotations:
        seccomp.security.alpha.kubernetes.io/pod: runtime/default
        {{ if not .Values.developmentMode }}
        # do not enable on Docker for Mac, since it doesn't support AppArmor
        container.apparmor.security.beta.kubernetes.io/api: runtime/default
        {{ end }}

    spec:

      restartPolicy: Always

      {{ if not .Values.developmentMode }}
      serviceAccountName: "{{ .Values.serviceAccount }}"

      initContainers:
      - image:  gcr.io/google.com/cloudsdktool/cloud-sdk:slim
        name: workload-identity-initcontainer
        command:
        - '/bin/bash'
        - '-c'
        - |
          curl -s -H 'Metadata-Flavor: Google' 'http://<IP_ADDRESS>/computeMetadata/v1/instance/service-accounts/default/token' --retry 30 --retry-connrefused --retry-max-time 30 > /dev/null || exit 1
      {{ end }}

      containers:
      -
        imagePullPolicy: Always
        image: eu.gcr.io/cloudsql-docker/gce-proxy:1.22.0
        name: cloudsql-proxy

        command:
        - '/cloud_sql_proxy'
        - '-enable_iam_login'
        {{ if not .Values.developmentMode }}
        - '-ip_address_types=PRIVATE'
        {{ end }}
        - '-instances={{ .Values.app.db.requests.instanceUrl }}=tcp:3126,{{ .Values.app.db.meta.instanceUrl }}=tcp:3127'

        {{ if .Values.developmentMode }}
        env:
        -
          name: GOOGLE_APPLICATION_CREDENTIALS
          value: /sa.json

        volumeMounts:
        -
          mountPath: /sa.json
          name: {{.Values.name}}-api-sajson
          readOnly: true
        {{ end }}

        resources:
          requests:
            cpu: 0.5
            memory: 0.5Gi
          limits:
            cpu: 0.5
            memory: 0.5Gi

        securityContext:
          readOnlyRootFilesystem: true
          privileged: false
          runAsNonRoot: true
          allowPrivilegeEscalation: false
          capabilities:
            drop: [all]
          seccompProfile:
            type: RuntimeDefault

      volumes:
      {{ if .Values.developmentMode }}
      -
        hostPath:
          path: {{ .Values.devServiceAccountFile}}
        name: "{{.Values.name}}-api-sajson"
      {{ end }}

@hazcod I don't have access to an Apple Silicon machine presently. However, if there's interest you could build your own container by making two changes to the Dockerfile at the root of this project:

Change Line 22 to  RUN CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build -ldflags "-X main.metadataString=container" -o cloud_sql_proxy ./cmd/cloud_sql_proxy
Change Line 25 to FROM gcr.io/distroless/static:nonroot-arm64.

After those changes, you'll have an M1 friendly version of the Cloud SQL Auth proxy. But again, I don't have an Apple Silicon machine at the moment and can't verify myself.

Peeking in here again for official arm64 images. :-)

We have this prioritized internally for the first half of this year. Right now, there's other work in flight that takes priority (e.g., v2 proxy).

Fixed by https://github.com/GoogleCloudPlatform/cloudsql-proxy/pull/1193. We'll have an M1 friendly container in the next release.


[newrelic-logging] helm doc update

Updated the readme to reflect the correct way to set the fluentBit.path option when deploying the helm chart.

Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [mychartname])

Closing as this has been pending action from submitter for a couple months now.


When trying to import exported file into open IV I get open formats error:

Got 31 expected 32

I haven't used this tool in a while. Might be that the format has changed or there is a bug in my exporter (most likely). Any chance you can share the exported file with me?

Closing this for now, feel free to re-open with more information or after I've created a new implementation.


fix: Fix and update demo notebook

Closes #371.
See https://github.com/CQCL/guppylang/blob/fix/demo-notebook/examples/demo.ipynb for the rendered notebook.
Drive-by: Add bool.__xor__ method for the example.
We should check for notebook regressions in CI to avoid breaking the example in the future. See #375

Codecov Report
Attention: Patch coverage is 47.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 91.01%. Comparing base (1dfebef) to head (fd3b2fc).
Report is 1 commits behind head on main.

Files
Patch %
Lines

guppylang/definition/struct.py
44.73%
21 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   91.32%   91.01%   -0.32%
==========================================
  Files          47       47
  Lines        5294     5322      +28
==========================================
+ Hits         4835     4844       +9
- Misses        459      478      +19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix(sec): upgrade mysql:mysql-connector-java to 8.0.28

What happened？
There are 2 security vulnerabilities found in mysql:mysql-connector-java 8.0.23

CVE-2022-21363
CVE-2021-2471

What did I do？
Upgrade mysql:mysql-connector-java from 8.0.23 to 8.0.28 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
How can we automate the detection of these types of issues?
By using the GitHub Actions configurations provided by murphysec, we can conduct automatic code security checks in our CI pipeline.
The specification of the pull request
PR Specification from OSCS

run buidall

@realize096 can you submit a pr for branch-2.0

run buildall


[release-4.15] OCPBUGS-32269: chore: remove image based FBC and replace with dynamic generation

cherry-picked from 5730a678c699afd75b13b3a79645a92bfc67dc5f

/lgtm

/lgtm

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.77%. Comparing base (9e63486) to head (cdac237).

Additional details and impacted files

@@              Coverage Diff              @@
##           release-4.15     #610   +/-   ##
=============================================
  Coverage         81.77%   81.77%
=============================================
  Files                24       24
  Lines              1838     1838
=============================================
  Hits               1503     1503
  Misses              226      226
  Partials            109      109

/override ci/prow/precommit-check

/jira refresh

/jira refresh

/jira refresh


feat(flagship): lifecycle hooks

created by vance hu @VanceHubb (the account is about to be deactivated).
Backgrounds
Right now flagship's module patching scripts can only apply to a specific module in a fixed event (ios before link and android after link). And we cannot add project specific patches easily using current framework.
Features
Replaced the current design with a more extensible lifecycle hook design. So a user can:

Add project specific hooks by creating ./buildHooks folder under project root path
Execute the script in any of supported lifecycle events. Currently supporting: 'beforeCopyBoilerplate' | 'beforeLink' | 'beforeIOSPodInstall' | 'afterLink' | 'failed';
Filter hooks by platforms / dependencies / dependency versions

No Breaking Change
No breaking change - all the current patches are restructured in a way that behaves exactly same as the previous commit. Still we should scrutiny all the current patches to make them more restrictive though (add dependency version conditions, etc)
Todo

Revisit exiting patches to apply them more appropriate conditions
Split some global fixes into separate hooks to make them more modular
Add more lifecycle events if needed

Note: a lot of script file changes are just adding metadata to the functions. No feature inside the functions are changed

This looks like a great enhancement Vance. How can we test it in the wild?

@DavidRhodesBB All the current modules are converted the hook-style plugins so you can safely run flagship on any existing projects and expect nothing changed in generated files. To create a new plugin, try create a file under {projectPath}/buildhooks folder. Example:
const buildHooks: BuildHook[] = [
  {
    name: 'appcenter android patch',
    platforms: ['android'],
    lifeCycle: 'afterLink',
    packages: [{
      packageName: 'appcenter'
    }],
    script: configuration => {
      fs.update(
        path.android.mainApplicationPath(configuration),
        'new AppCenterReactNativePackage()',
        'new AppCenterReactNativePackage(application)'
      );
    }
  }
];
module.exports = buildHooks;

bump. this would be helpful reducing patches we need in a few ongoing flagship upgrading processes

superseded by this branch: https://github.com/brandingbrand/flagship/compare/develop...vancehu:hooks_master?expand=1


Create pull_request_template.md

Adds a pull request template to help organize the commit history

Adds a pull request template to help organize the commit history

Maybe a template for commit messages as well? Maybe something along this line:

A one line summary of what the change in the commit is about
And a brief description of the reason for the change.

The guys at Zulip have a nice commit discipline

For PRs, I don't love having to fill in both what and why. In many cases I feel like that's basically the same, or that the why just is "to get feature x".
I'd rather just have the what-section and the test-section.

For PRs, I don't love having to fill in both what and why. In many cases I feel like that's basically the same, or that the why just is "to get feature x".
I'd rather just have the what-section and the test-section.

I very much agree with this, often its the same thing written in different words on those two


Continuous scrolling pause on hover

I am using the following settings in order to achieve continuous scrolling:
			    dots: false, 			    arrows: false, 			    slidesToShow: 1, 			    slidesToScroll: 1, 			    centerMode: false, 			    draggable: true, 			    speed: 7000, 			    autoplay: true, 			    autoplaySpeed: 0, 			    vertical: false, 			    infinite: true, 			    pauseOnHover: true, 			    cssEase: 'linear',
It works great apart from one little issue. It does not pause on hover. Well, it does but with a huge delay. Was wondering if there is a way of making the pause on hover work perfectly.

I needed this EXACT thing, thank you!! Your settings worked beautifully, but I see what you mean with the delay on hover. @kenwheeler any idea why this is happening?

Here's a half answer that's worthless without the second half, but hopefully it inspires someone.
You have to wait for the animation that takes {speed} to finish before it will pause. If using JS animations (useTransform set to false), animations occur using jQuery.animate(). This function can be interrupted with calling .stop(true, false) on the .slick-track. I have not been able to restart the carousel after that is called though.

I found a solution which is not ideal, but it works:
// var normalSpeed = 2000;
// var quickSpeed = 500;
$slider.on('mouseenter', () => {
  var track = $('.slick-track')[0];
  // ORIGINAL cssText "opacity: 1; width: 30000px; transform: translate3d(-1400px, 0px, 0px); transition: transform 2000ms linear 0s;"
  track.style.cssText = "opacity: 1; width: 30000px; transform: translate3d(-1400px, 0px, 0px); transition: transform 500ms linear 0s;"
  $slider.slick('slickSetOption', 'speed', quickSpeed, true).slick('slickPause');
}).on('mouseleave', () => {
  $slider.slick(slickSetOption', 'speed', normalSpeed, true).slick('slickPlay');
});

Manually updating the transform value to my quickSpeed got it to zip to the end of the transform.
Setting transform and transition to undefined stops it where it is.
Definitely a hack, and changing the value of transform/transition instead of cssText did not work.


Add threshold prop

Relating to #37, adds an optional threshold prop and changes the preventDefault mechanism to only trigger when the drag is larger or equal to the threshold.

Thanks for the PR @MathieuLoutre !
This seems like the right approach generally. However I don't think there's a need to allow threshold to be configurable. I think for now we can pick a value that seems to work nicely in most use cases. We've been trying to track the UX of popular mapping implementations like google maps, and they seem to interpret any movement as a drag. I think hard coding the threshold around 1 would work for most people.
Like
const shouldPreventTouchEndDefault = Math.abs(dragX) >= 1 || Math.abs(dragY) >= 1;

Sure, I see the sense in that. I've used 5 in my tests because in my particular use case you have to move and select a few times in a row which makes movement on click a bit more likely. But I suspect 1 or 2 can be good "safe" values (when do you actually mean to move the "map" 2px or less?).
Happy to close this PR and make another one without the additional test etc. to keep the history clean. Let me know what you think the best value to hardcode is.

This PR is fine, you can just squash to have a single commit. Whatever you think.
For the threshold, I would say 1 is fine, at least from locally testing thats been fine for me. So either dX > 1 or dY > 1.

Hi @scottyantipa. All good, I've made the changes.


Import content from conf files

A great feature in contentctl which would enable faster onboarding of content from a splunk environment is import from existing conf files.
There was initial work towards that here: https://github.com/splunk/contentctl/pull/84
But since that was opened the structure of the codebase has changed significantly.  As such, that PR has been closed out.
Let's track this as it is an oft-requested feature, especially for new users.
I will tag @0xC0FFEEEE directly in this issue so that they can provide comments and feedback if they would like 😄

Some context as to why this would be a great feature from the perspective of a Splunk cloud customer w/ >950 ESCU rules enabled:
When we adopted Splunk ES, we opted to enable, tune and tweak ESCU rules in-place, as there was no clear benefit to cloning detections given that ES does not provide any means to merge changes from upstream security_content updates.
Over time we've modified a number of these rules to various extents and it's simply not worth the time/effort to manually compare and merge in changes from an updated ESCU detection, meaning we are likely missing out on some beneficial updates.
Our eventual goal with DaC is to maintain our own fork of security_content, and for the eventual switchover to happen, we will need to import our local savedsearches.conf before merging in changes from ESCU v4.16 (IIRC) to date.
I'm also considering whether we should manage our filter macros as code, so importing macros.conf would also be nice, and would certainly help with the switch to our forked content pack.


Update to JRE 11 once available

Once we are running a new JRE, there will be no problem with netty tcnative stuff needed for grpc.
Depends on https://github.com/docker-library/openjdk/issues/211
See https://github.com/openzipkin/docker-zipkin-gcp/issues/2

We should revisit this in 2 months after the GA of JDK 11 http://openjdk.java.net/projects/jdk/11/

@shakuzen

the Spring Framework/Boot version we’re using doesn’t officially support Java 11 so I’m not super surprised. Framework 5.1 and Boot 2.1 will officially support 11.

let's do this once 2.1 is final!

looks like oracle doesn't support JDK 11 on Alpine
adoptopenjdk/openjdk11:x86_64-alpine-jdk-<IP_ADDRESS>-slim seems available

unfortunately the base "slim" image is significantly larger than our image including zipkin:
adoptopenjdk/openjdk11             x86_64-alpine-jdk-<IP_ADDRESS>-slim   9c9050889d49        16 hours ago        248MB
openzipkin/zipkin                  latest                             458ff0e55eef        6 weeks ago         147MB

https://github.com/docker-library/openjdk/issues/272 is latest for tracking alpine, they are waiting for someone to make a package for alpine, which seems to have not occurred.

Looks like they have one for alpine in JDK 12 (EA), but it is huge. Possibly this could be trimmed down to JRE only
openjdk                                              12-alpine                          0c68e7c5b7a0        8 days ago          339MB


[Bug] exportOnlyField does not seem to work

Bug report
What I did
Inside the setupListOperation method of my resource's CRUD controller I added a column with 'exportOnlyField' => true as follows:
$this->crud->addColumn([
    'type' => 'number',
    'name' => 'max_uses',
    'exportOnlyField' => true,
]);

What I expected to happen
The column to not be visible in the column visibility dropdown.
What happened
The column remained visible in the column visibility dropdown.
What I've already tried to fix it

Seeing if visibleInExport and visibleInTable work -> true.
Seeing if the data attributes get set correctly on the table header -> true.
Clearing the local storage.

Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
### PHP VERSION:
PHP 7.4.9 (cli) (built: Aug  7 2020 19:23:06) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.9, Copyright (c), by Zend Technologies

### LARAVEL VERSION:
v7.28.3@b0942c391975972b1a54b2dc983e33a239f169a9

### BACKPACK VERSION:
4.0.61@1977e0cc52fa7cf9547eaeadf03f5cd88402b574

MySQL version is 8.0.21.

Thanks for the report and for the fix, I am going to close this in favor of keeping the discussion in the PR.
Best,
Pedro


manual cherry-pick of #26729

Fixes issues with bad load balancing in multi-network.
See #26729
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.7
4c26d659c0c84ec0b75bcbb5023983e0a805aad9
link
/test release-notes_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.7
f93e667cac33e8c05b907c82c6e51bc2a06df074
link
/test release-notes_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Do we plan to pull in the stuff around using a separate gateway in 1.7.x? If not, should this PR have REQUESTED_NETWORK_VIEW set by default if values.global.network is set?
It's an odd behavior change that we just get rid of later. Breaks accessing a remote network from ingress in a different network.

cc @nmittler


Symbol provider timeouts

The symbol provider model was created with the following assumptions:

We'll need to get symbols from multiple sources
Certain sources will benefit from async calls
Certain sources will take longer to resolve than others
Sources might take longer to resolve than is reasonable for a decent intellisense experience

However, the current implementation using Promise.all() ensures that we'll wait until every symbol provider completes its work. We're currently hitting issues with intellisense for large/complex M files (ex. ~16s to resolve a Hover request for a library symbol),
This change allows the consumer to set a timeout (AnalysisSettings.symbolProviderTimeoutInMS) for symbol provider activities. When the timeout is reached, the symbol provider returns an empty result. This allows the base analysis class to return symbols from providers that completed in time.
Further improvements in this area would include:

Tracing events when timeouts occur
Preventing the timeout from occurring until at least one symbol provider has returned
Better support for cancellation all around

Further debugging from the vscode-powerquery side showed that most of the time is spent in the inspection code, prior to actually waiting on symbols... so this change has no impact on the current vscode extension but will be more relevant when we use it in Power Query Online (where we might be waiting on server-side query analysis results). I'm going to commit this for now, and look at adding more async behavior to the analysis code path.


git - display upstream remote/branch for the given local branch

In response to Issue #5676

Hi,
I tried this change with the amuse theme but the upstream isn't displayed in the prompt. The amuse theme uses the function git_prompt_info.
If I test the parse_git_upstream_branch on the command line the upstream branch name is displayed.

Any ideas?

@easterwood I don't seem to be having the same issue. See Below.

Things to try out.

Did you restart your terminal session?
Did you make changes to the git_prompt_info function on this line? https://github.com/robbyrussell/oh-my-zsh/pull/5677/files#diff-6fd2f97d5b3acf53783112ad92948f12R7

I forgot to mention that I merged your change into this repo w/o conflicts.

Did you trying restarting your terminal/session?

After restarting the pc the behavior is the same.

Hm, I sourceed the lib/git.zsh file and now it works.


[Bug] Potential memory leaks when redrawing snippets

When updating snippets, which contains ajaxified links, their click handlers are not removed. Therefore resulting in memory leaks. Although small, but still present.
These links should have event listeners removed before snippet's HTML being rewritten.

Thank you, I completely missed that. I will take a look at it as soon as I can.

Fix in the latest commit c0b326fa6b0c04da8c564bb3e30ab79e6e387d77.


Add action type field for sendPayment records

An action field should tell if the issue was closed or set ready


Training models on all full datasets

Rebuilds eval_tool into model_tool to make training multiple models easier
Trains models on wikipedia datasets alone, augmented with debias data, and augmented with random data

NB: This branch contains jetpack's commits as they have not yet been merged into master but I will review them seperately in his PR.

Could you add a description to the README of what all the different dataset files are?

Also should remove eval_tool.py

Change hyperparameters to the newest version:
MAX_SEQUENCE_LENGTH = 250
MAX_NUM_WORDS = 15000
EMBEDDING_DIM = 100
EMBEDDING_TRAINABLE = False
LEARNING_RATE = 0.00005
BATCH_SIZE = 128
EPOCHS = 20
DROPOUT_RATE = 0.3
CNN_FILTER_SIZES = [128, 128, 128]
CNN_KERNEL_SIZES = [5,5,5]
CNN_POOLING_SIZES = [5, 5, 40]

We should pull out the code in the "Model bias analysis" notebook into a library so we don't need to duplicate it for each notebook.

Agreed. Thanks for doing that jetpack! :-)

Responded to comments, PTAL.


HealthServiceDateTime null ref fix

Fixed null reference when creating a HealthServiceDateTime from a HealthServiceDate and comparing it to a LocalDateTime with the same year, month, day.

@RandomEngy,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:shipit:


[GLSL] Place magic uniforms to uniform buffers

The absence of a plain uniform helps a lot in the case of shared contexts. Plain uniforms are the state of the program object, not the state of the context. In other words, when you modify uniforms through the glUniformXXX functions, you change the state of the program. It is bad when the program is shared between contexts because it's requires additional synchronization. So it would be nice if there was an option like "place_magic_uniforms_to_ubo".

Main problem with emitting UBOs is packing concerns. One magic value per UBO is too inefficient and might cause limits to be exceeded, and packing them together leads to the problem of which binary layout should be used for the UBO.

I think all uniforms should be packed in one ubo. Binary layout doesn't matter. A uniform offset for each magic value can be queried at runtime.


deprecation message is printed even when warningThreshold and failThreshold are not used

Version: 1.0.0.RC6-4
In my config I'm using failFast: true and do not specify build section at all. Nevertheless, I see the following message in console:

[Deprecation] - 'warningThreshold' and 'failThreshold' properties are deprecated. Please use the new 'maxIssues' config property.

Is that intended?

That's probably working as intended since the default configuration is used and there the warningThreshold and failThreshold are defined.

Are there any reason to keep deprecated properties in default configuration?


12514 Monterey Circle, Fort Washington, MD is been parsed incorrectly.

12514 Monterey Circle, Fort Washington, MD
became
12514 Monterey Circle Fort, Washington, MD
In [2]: usaddress.tag("12514 Monterey Circle, Fort Washington, MD")
Out[2]:
(OrderedDict([('AddressNumber', '12514'),
              ('StreetName', 'Monterey Circle'),
              ('StreetNamePostType', 'Fort'),
              ('PlaceName', 'Washington'),
              ('StateName', 'MD')]),
 'Street Address')

Added to the next round of training data. Thanks @chengguangnan!


Request IDs (frontend)

Apply a request ID to each update.
Keep track of which updates have not been acknowledged by the backend.
Don't revert updates that have not yet been acknowledged.

This has been done, but wasn't marked in a commit.


Reference field edit vs. create

I have a reference field dropdown that throws a ng-admin.min.js:19125 TypeError: Cannot read property 'values' of undefined in ng-admin/src/javascripts/ng-admin/Crud/field/maReferenceField.js at the initialChoices mapping fuction on edit view but works properly on create view.
The create view looks like,
    tracker.creationView()
        .title('Create Tracker')
        .fields([
            nga.field('MOST_Metric_ID', 'reference')
                .label('Metric Name')
                .attributes({'placeholder': 'Select a metric'})
                .validation({ required: true })
                .targetEntity(metrics)
                .targetField(nga.field('metric_name')),
            nga.field('note', 'text')
        ]);

The edit view extends the create view like,
    tracker.editionView()
        .title('Edit Tracker')
        .fields(
            tracker.creationView().fields()
        )
        .actions(editActions);

UPDATE The reason this is different between edit/create is the presence of the scope.values.
I can confirm through console.log(...) debugging the initialEntries array of objects changes from.
[Entry, Entry, Entry, Entry, Entry, Entry, Entry]

to,
[undefined, Entry, Entry, Entry, Entry, Entry, Entry, Entry]

Whereas the undefined is messing up the choices mapping function. I'm not sure what the unshift function is doing if the scope.value is X, but it appears there may be a bug here. Maybe wrapping this in a check for undefined would work?

I found this was due to an issue with the addResponseInterceptor and the way I was mapping the data. Very strange race conditions...


Why is the name of the app not showing up with Android ?

Hello,
When sending a push notification, it works fine on iOS but on Android, the name of the app is not showing up, only the message, why is this happening ?
               $pushManager = new PushManager(PushManager::ENVIRONMENT_PROD);
                //
                // Development one by default (without argument).
                // $pushManager = new PushManager( PushManager::ENVIRONMENT_DEV );

                // Set the device(s) to push the notification to.
                // Pourquoi 0 ???
                $devices = new DeviceCollection( array(
                    new Device( $friendDevice->getToken() )
                ));

                //Send back where did we send it ?
                $platform = $friendDevice->getPlatform();

                // Then, create the push skel.
                // DO NOT ADD BADGES!!!
                $message = new Message( $message, array(
                    'custom' => array(
                        'type'      => $type,
                        'id'        => $id,
                        'friendId'  => $user->getId(),
                        'friendName'=> $user->getName(),
                        'requestId' => $requestId
                        )
                    )
                );

                //IF IOS IF ANDROID
                if ( $platform == "iOS" )
                {
                    // Then declare an adapter.
                    $adapter = new ApnsAdapter( array(
                        'certificate' => $this->certificate
                    ));

                } elseif ( $platform == "android" || $platform == "Android" )
                {
                    // Then declare an adapter.
                    $adapter = new GcmAdapter(array(
                        'apiKey' => $this->apiKey,
                    ));

                }
                // Finally, create and add the push to the manager, and push it!
                $push = new Push( $adapter, $devices, $message );
                $pushManager->add( $push );
                $pushManager->push();````

Thanks

GCM custom options aren't implemented yet, sadly.
I could really use them right now to be honest.

@MilesYM it's not documented but you can already pass a title to your notification :
new Message("body", [
    'title' => "Your notification or app title"
])

@MilesYM, is your issue was solved by the last answer?


Mesh overhaul with custom vertex attributes #592

Pull request draft for #592

Gonna fix the rough edges now and propose this PR. ⌨

https://github.com/bevyengine/bevy/issues/592#issuecomment-702027807

Has this been tested with sprite/2d pipelines?

Works all for me🙂

Quick summary

You can straight forward throw any attribute data at Mesh now and it will be mapped to the named binding slot. No dealing with vertices structs anymore.
That also means that VertexBufferAttributes don't need to be defined upfront. All necessary info (stride, shader_location) is implicit.
Shader attribute naming is now mostly irrelevant. Attributes that start with "I_" will be used for instancing.

Uncool things

No support for interleaved buffers at all. This is cool for desktop GPUs (and any CPU) but might be a bottleneck on mobile GPUs. https://github.com/bevyengine/bevy/issues/592#issuecomment-702027807
No way of using half for vertex attributes. Would be nice to have, since normals, vertex-colors and most uv's can be stored as half just fine. (This wasn't possible before either, but now it would be harder to add)
Late failing when vertex buffer is required by shader but not defined by mesh. This could be hard to debug in bigger projects.

Okay, from my POV there’s nothing to add to this anymore. 🙂
Some post PR things: While this approach will work for now, over long term, we will hit some issues:

As https://github.com/bevyengine/bevy/issues/592#issuecomment-704679922 mention, there will be issues regarding max. bound buffers. from wgpu limitations when animations come into place.
Unbound attribute handling.
Mobile GPUs still preferer interleaved data.
Support for half or other formats

My idea would be to decouple all these things from mesh.rs and instead add something like a VertexDataToGPUAdapter which could:

Bundle attributes into interleaved buffers
Convert attributes to half or other formats
Undefined attribute handling
Allow for custom attribute encoding, like converting normals into octahedrons for reduced bandwidth.

This would probably sit somewhere at render_pipeline.rs and would be user configureable. The API would be something like Res<VertexDataToGPUConfig> and could have functions like:

fn set_attribute_post_processing(attribute_name: &str, on_attribute_post: Fn) (handles type conversion + attribute post proccessing)
fn set_attribute_prefered_interleaved_buffer(attribute_name: &str, buffer_id: usize)
fn set_attribute_missing_behaviour(attribute_name: &str, on_attribute_missing: Fn)

I'll gonna keep this a draft until I figured out the proper API for interleaved. It's trickier than I thought.

Cool cool. I really appreciate the thought you're putting into this!

Okay, I want to draw a line now. In a future PR, I will introduce the custom vertex format system, the fundaments should be fine for this now. 🙂

once merge conflicts are resolved i do one last pass then i think this is ready to go

[ ] Write Changelog
[ ] Write Summary
[ ] Write Future To-Dos

Oooff, git desktop went a little crazy here...

Summary (Dev version)

mesh.rs packs now all attributes into one buffer via attributes_to_vertex_buffer_data().
mesh.rs also provides dummy buffer (VERTEX_FALLBACK_BUFFER_ID)  for undefined attributes, so the pipeline can be rendered in any case.
render_pipeline can now specializes on individual buffer descriptions.
reflect_layout returns each attribute as a single buffer. (This shall be subject of change later)
Removed any old code like VertexAttribute, Vertex, AsVertexBufferDescriptor
RenderResourceContext uses u64 now.
mesh.attributes is a HashMap now.

Future stuff

Add API to customize attribute data befor passing to buffer to allow:

Float -> Half/NormU16/... conversion
Attribute Packing (is that even still a thing?)
normal compression
(custom initialization of undefinied attributes ?)

Allow for multiple attribute buffers.
Replace buffer names with hashes for tighter structs.
Allow for VertexAttributeValues to be unloaded after beeing send to GPU to save CPU memory.

Another followup I'd like is a "custom mesh with custom attributes" example that proves that we support arbitrary layouts with custom shaders.

In general this looks good to me. Most of my feedback is superficial. Allocating a "fallback buffer" for each Mesh feels like overkill, but its not a big deal and we could always allocate "shared fallback buffers" of varying sizes if/when it becomes a problem.

Agree. I'm thinking of a generic buffer that expands size by the largest allocated mesh. Will add this to the followup.

Looks like sorting attributes breaks the shader_custom_material and shader_defs examples. Maybe something was reliant on that order?

Gave the new fixes a try with various permutations of attributes in custom shaders and they all worked. I think this is good to go!

After update to latest bevy code, there is a big performance degradation caused by this PR.

@J-F-Liu that's probably related to #764. I have a PR out that should fix it

My frame rate dropped from 28 to 7, I check out mesh-allocation-fix and have a try, the frame rate rises to 25.
Btw, Mesh:: attribute(&mut self, should remove mut.

@J-F-Liu sounds interesting, can you tell what exactly you are doing? (or even provide some source code?)

@julhe There are 5431 mesh objects rendered as PrimitiveTopology::LineList, plus mouse movement screen ray interaction checking.

I'm guessing the extra allocations for the VertexBufferDescriptor in each entity's PipelineSpecialization are to blame for the slight drop in performance (and maybe also the act of re-computing it).
If so that would be resolved by the followups called out here: https://github.com/bevyengine/bevy/pull/768#issue-513771946

I think the approach we're using now is the right path forward. We just need to remove some of the hot-spots introduced by some slightly naive choices made for simplicity (and to meet the 0.3 deadline that I have arbitrarily set :smile: ).


Need to rewrite NAT

Need to rewrite NAT using DirectSend for ARP requests, instead of confusing merges.

Done.


When I go to the board recruiting page it is broken

When I go to the board recruiting link it is broken: https://devedmonton.com/board_recruiting
But if I got to the board page and then click the "board recruiting page" link then it works fine

Same issue as https://github.com/devedmonton/DES-Website/issues/258#issuecomment-1762664750 should be fixed with #263


Release/0.3.2

I plan on releasing this once I have had a chance to do a bit of local testing on the GETs.
/cc @duncan @loufranco for any review they want to do

I just did a full catchup with our master, built, and tested both on iOS and Mac. We’ll probably integrate with our client later today, but I don't foresee any issues there.

Awesome, thanks for that @duncan!


Support for ESLint Flat config

ESLint is introducing a new "flat" configuration format. This is feature complete but you still need to opt in to it.
I've just updated my project to use this, and Knip is now listing 1 unused file and 17 unused dependencies where it wasn't before because it doesn't understand that these are actually used by Eslint now:
-> % npx knip
Unused files (1)
eslint.config.mjs
Unused devDependencies (17)
@typescript-eslint/eslint-plugin   package.json
@typescript-eslint/parser          package.json
eslint                             package.json
eslint-config-prettier             package.json
eslint-formatter-mo                package.json
eslint-plugin-jest                 package.json
eslint-plugin-jest-extended        package.json
eslint-plugin-jest-formatting      package.json
eslint-plugin-no-secrets           package.json
eslint-plugin-perfectionist        package.json
eslint-plugin-pii                  package.json
eslint-plugin-prettier             package.json
eslint-plugin-security             package.json
eslint-plugin-unicorn              package.json
eslint-plugin-write-good-comments  package.json
globals                            package.json
prettier                           package.json

I can fix this by manually adding my eslint.config.mjs file to the entry array in my Knip config, but it would be good if I didn't need to do this:
import type { KnipConfig } from 'knip';

const config: KnipConfig = {
  entry: ['src/index.ts', 'eslint.config.mjs']
};

export default config;

Cheers

Flat configs are supported in Knip, but the .mjs extension is missing:

https://github.com/webpro/knip/blob/main/packages/knip/src/plugins/eslint/index.ts#L25
https://github.com/webpro/knip/blob/main/packages/knip/src/plugins/eslint/index.ts#L36

You're up for a fix and a PR? :)

Flat configs are supported in Knip, but the .mjs extension is missing:
* https://github.com/webpro/knip/blob/main/packages/knip/src/plugins/eslint/index.ts#L25

* https://github.com/webpro/knip/blob/main/packages/knip/src/plugins/eslint/index.ts#L36

You're up for a fix and a PR? :)

https://github.com/webpro/knip/pull/525 :)


Separate release notes document into multiple release-specific files

Currently, the release notes document is a single file that contains all release changes. This is making it hard to manage as more release content are added over time. Also, people want a single pattern of linking to a specific release, for example,

https://docs.zowe.org/stable/getting-started/release/v1.15.0.html

Instead of

https://docs.zowe.org/stable/getting-started/summaryofchanges.html#version-1-15-0-lts-september-2020 where the date varies.

Therefore, it's proposed that we split the single document into release-specific files. To do that, there are some considerations:

URL redirect: If we split the file, this would break the previous URLs. Many blogs and articles refer to the old URL so must ensure that proper redirect is set up.

@BrandonJenkins14 @ajinrocket @janan07 @IgorCATech @MichaelABroadcom for awareness and comments if any.

 [Doc] Enhance the Zowe doc navigation experience

Hi. I tried to open the link but it is for a private Trello board. Is there
a shared link?
Michael Aimino
Technical Writer  |  Mainframe Software Division
Broadcom
office:<PHONE_NUMBER>
750 Holiday Drive, 3rd Floor  |  Pittsburgh, PA 15220
<EMAIL_ADDRESS> |   broadcom.com
On Wed, Feb 10, 2021 at 12:58 AM nannanli<EMAIL_ADDRESS>wrote:

https://camo.githubusercontent.com/208d50cabd9d101500fe5dd548265dcfa00e017e397395692a173e7116c1094a/68747470733a2f2f6769746875622e7472656c6c6f2e73657276696365732f696d616765732f6d696e692d7472656c6c6f2d69636f6e2e706e67 [Doc]
Enhance the Zowe doc navigation experience
https://trello.com/c/HL3Pk6Vs/29-doc-enhance-the-zowe-doc-navigation-experience
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zowe/docs-site/issues/1446#issuecomment-776464718,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APBPII6PQ2DQMC44YWJHSOLS6IOANANCNFSM4SMMM76Q
.

--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.