Allow bind syntax for "label-has-for"

We sometimes have components that combine form elements and labels:
       <label :for="id" ...>
       <input :id="id" ...>

id in this case is a property set on the custom component.
Unfortunately the plugin ignores :for completely and complains about missing for attribute.

can you provide a short reproduction of this behavior so we can try fixing it properly?

This is yet another barrier to Vue3 adoption. If Vue allows binding with :for then this should be part of the linting rules.

As far as I could tell, it is a problem both in vue@2 and vue@3, but anyway, could you, then, provide a reproduction link?

There's an example - Vue SFC Link
And regarding the Vue3 comment, I just started encountering this issue as I was forced to upgrade to Vue3 and used the ESLint AirBnB preset. That preset required me to get familiar with disabling a lot of rules that just didn't work with legit code like this one.

Any updates on this topic?

A PR would be merged if someone wants to put one together.

So, I just gave this a look, and I'm pretty sure that this is an issue with your configuration, also it should be related to this other issue: https://github.com/vue-a11y/eslint-plugin-vuejs-accessibility/issues/54 (in this other issue there are some recommendations of workarounds, but PRs are still welcomed to fix that issue).
and as far as I can tell, it does not have anything to do with Vue@3.
The reproduction I made is here: https://github.com/vhoyer-bug-reproductions/eslint-plugin-vuejs-accessibility
if you think there was a mistake in my judgement feel free to re-open this issue


The MSIX Release v7.2.3 seems not correctly signatured?

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
When I try to install Powershell-7.2.3.msixbundle, Windows Application Installer tells me it is not signatured ans thus not trusted. It's OK to install using the .msi file. I didn't see this MSIX package's hash value in release note, either, but it's truly within the assets. What's wrong with this?
Btw I found this problem when try to use WinGet-Create to update the manifest of Powershell in winget-pkg, and winget-create reports an System.IO.FileNotFoundException error. I guess it's the same problem with what I encountered as below.
Expected behavior
MSIX package installed successfully.

Actual behavior
Windows Application Installer tells me it is not signatured ans thus not trusted.

Error details
No response
Environment data
Current Version: 7.2.2
Want to update to: 7.2.3

Visuals
No response

This should now be fixed


Container fails with errors - docker - tobegit3hub/simple_tensorflow_serving:latest-py34

@tobegit3hub
I'm trying to run the docker instance on windows 10.
(base) λ docker --version
Docker version 18.09.2, build 6247962

(base) λ docker run -d -p 8500:8500 tobegit3hub/simple_tensorflow_serving:latest-py34

Docker install completes properly with no errors. The container also startups with no obvious errors.
But, the endpoint at http://<IP_ADDRESS>:8500/ returns an internal server error.
(base) λ curl http://<IP_ADDRESS>:8500/
Internal Server Error

On inspection, docker's logs shows:
(base) λ docker logs 0b8b9968c3b9
[uWSGI] getting INI configuration from /tmp/uwsgi.ini
*** Starting uWSGI 2.0.18 (64bit) on [Sat Jul 13 03:56:44 2019] ***
compiled with version: 6.3.0 20170516 on 10 July 2019 06:45:50
os: Linux-4.9.125-linuxkit #1 SMP Fri Sep 7 08:20:28 UTC 2018
nodename: 0b8b9968c3b9
machine: x86_64
clock source: unix
pcre jit disabled
detected number of CPU cores: 2
current working directory: /simple_tensorflow_serving
writing pidfile to /tmp/uwsgi.pid
detected binary path: /usr/local/bin/uwsgi
uWSGI running as root, you can use --uid/--gid/--chroot options
*** WARNING: you are running uWSGI as root !!! (use the --uid flag) ***
your memory page size is 4096 bytes
detected max file descriptor number: 1048576
lock engine: pthread robust mutexes
thunder lock: disabled (you can enable it with --thunder-lock)
uWSGI http bound on <IP_ADDRESS>:8500 fd 3
uwsgi socket 0 bound to UNIX address /tmp/uwsgi.sock fd 6
uWSGI running as root, you can use --uid/--gid/--chroot options
*** WARNING: you are running uWSGI as root !!! (use the --uid flag) ***
Python version: 3.4.10 (default, Mar 20 2019, 00:50:15)  [GCC 6.3.0 20170516]
Python main interpreter initialized at 0x5573028aa050
uWSGI running as root, you can use --uid/--gid/--chroot options
*** WARNING: you are running uWSGI as root !!! (use the --uid flag) ***
python threads support enabled
your server socket listen backlog is limited to 100 connections
your mercy for graceful operations on workers is 60 seconds
mapped 145840 bytes (142 KB) for 1 cores
*** Operational MODE: single process ***
Traceback (most recent call last):
  File "./simple_tensorflow_serving/server.py", line 19, in <module>
    from manager import InferenceServiceManager
  File "./simple_tensorflow_serving/./manager.py", line 16, in <module>
    from tensorflow_inference_service import TensorFlowInferenceService
  File "./simple_tensorflow_serving/./tensorflow_inference_service.py", line 12, in <module>
    import tensorflow as tf
  File "/usr/local/lib/python3.4/site-packages/tensorflow/__init__.py", line 35, in <module>
    from tensorflow._api.v1 import compat
  File "/usr/local/lib/python3.4/site-packages/tensorflow/_api/v1/compat/__init__.py", line 21, in <module>
    from tensorflow._api.v1.compat import v1
  File "/usr/local/lib/python3.4/site-packages/tensorflow/_api/v1/compat/v1/__init__.py", line 649, in <module>
    from tensorflow_estimator.python.estimator.api._v1 import estimator
  File "/usr/local/lib/python3.4/site-packages/tensorflow_estimator/__init__.py", line 8, in <module>
    from tensorflow_estimator._api.v1 import estimator
  File "/usr/local/lib/python3.4/site-packages/tensorflow_estimator/_api/v1/estimator/__init__.py", line 8, in <module>
    from tensorflow_estimator._api.v1.estimator import experimental
  File "/usr/local/lib/python3.4/site-packages/tensorflow_estimator/_api/v1/estimator/experimental/__init__.py", line 8, in <module>
    from tensorflow_estimator.python.estimator.canned.dnn import dnn_logit_fn_builder
  File "/usr/local/lib/python3.4/site-packages/tensorflow_estimator/python/estimator/__init__.py", line 25, in <module>
    import tensorflow_estimator.python.estimator.estimator_lib
  File "/usr/local/lib/python3.4/site-packages/tensorflow_estimator/python/estimator/estimator_lib.py", line 53, in <module>
    from tensorflow_estimator.python.estimator.inputs import inputs
  File "/usr/local/lib/python3.4/site-packages/tensorflow_estimator/python/estimator/inputs/inputs.py", line 23, in <module>
    from tensorflow_estimator.python.estimator.inputs.pandas_io import pandas_input_fn
  File "/usr/local/lib/python3.4/site-packages/tensorflow_estimator/python/estimator/inputs/pandas_io.py", line 31, in <module>
    import pandas as pd
  File "/usr/local/lib/python3.4/site-packages/pandas-0.25.0rc0-py3.4-linux-x86_64.egg/pandas/__init__.py", line 30, in <module>
    from pandas._libs import hashtable as _hashtable, lib as _lib, tslib as _tslib
  File "/usr/local/lib/python3.4/site-packages/pandas-0.25.0rc0-py3.4-linux-x86_64.egg/pandas/_libs/__init__.py", line 3, in <module>
    from .tslibs import (
  File "/usr/local/lib/python3.4/site-packages/pandas-0.25.0rc0-py3.4-linux-x86_64.egg/pandas/_libs/tslibs/__init__.py", line 3, in <module>
    from .conversion import localize_pydatetime, normalize_date
  File "pandas/_libs/tslibs/conversion.pyx", line 234, in init pandas._libs.tslibs.conversion
AttributeError: type object 'pandas._libs.tslibs.conversion._TSObject' has no attribute '__reduce_cython__'
unable to load app 0 (mountpoint='') (callable not found or import error)
*** no app loaded. going in full dynamic mode ***
uWSGI running as root, you can use --uid/--gid/--chroot options
*** WARNING: you are running uWSGI as root !!! (use the --uid flag) ***
*** uWSGI is running in multiple interpreter mode ***
spawned uWSGI master process (pid: 9)
spawned uWSGI worker 1 (pid: 13, cores: 1)
spawned uWSGI http 1 (pid: 14)

Any ideas?

It seems to be the compatible problem for the latest code with uwsgi and pandas.
The code for py34 is not tuned yet so it may has some bugs. You may try install with source or pip install with older version like simple-tensorflow-serving==0.6.6.


Add support for enabling and configuration of ceph telemetry module

Is your feature request related to a problem? Please describe.
Currently ceph-ansible seems unable to enable or even configure the options of the Telemetry module (https://docs.ceph.com/en/latest/mgr/telemetry/).
The easier this module can be enabled and set up, the more telemetry is likely submitted by clusters set up and operated via ceph-ansible.
Describe the solution you'd like
I'd like an easy config switch to first enable telemetry (including accepting the license) - https://docs.ceph.com/en/latest/mgr/telemetry/#enabling-telemetry. Additionally setting the enabled channels (https://docs.ceph.com/en/latest/mgr/telemetry/#channels) and collections (https://docs.ceph.com/en/latest/mgr/telemetry/#collections) would be nice.
Last but not least allowing to define ident info (https://docs.ceph.com/en/latest/mgr/telemetry/#contact-and-description) should be possible.
Describe alternatives you've considered
Alternatively those settings have to come either by manual commands after a cluster has been created or by added Ansible tasks.
Both seems not really a clean solution with ceph-ansible managing all other things Ceph out of the box.

Is this really stale already?

I'd still love to see this feature

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

please kindly reconsider

I'm not against that, we just don't have the bandwidth at the moment for this.
Contributions are welcome .. 😁

@frittentheke,
@asm0deuz is taking a look at this one

@guits any way to keep this issue alive?


keybind for menu

Possible to rebind the key to pull up the framework menu on MHR? I use insert as my discord mute button ,,

Already fixed in b4fd4326a4ab5ee08376dfbf9eabb28515580723
Download newer builds from here: https://ci.appveyor.com/project/praydog/reframework-dev/build/artifacts


Remove PEP8 errors in tests

This PR removes the PEP8 errors in the tests module. Part of #347.

We're getting closer to merging #347


Arduino support?

Is it possible to use this on the ESP32 Arduino core currently?

Any update on this?

Sorry, missed this completely. It was written for ESP32 using ESPHome with Arduino core, so it should work for other use cases.


Exceptions starting DDS can't be caught without running in a zone

The following code tries to start DDS but passes an invalid URI:
import 'dart:async';

import 'package:dds/dds.dart';

Future<void> main() async {
  try {
    final a = await DartDevelopmentService.startDartDevelopmentService(
      Uri.parse('http://bogus.local/'), // This isn't valid
    );
    print('1');
  } catch (e) {
    print('2');
  }
  print('3');
}

None of the numbers here get printed, but the app terminates with an unhandled exception:
Unhandled exception:
SocketException: Failed host lookup: 'bogus.local' (OS Error: No such host is known.
, errno = 11001)
#0      _NativeSocket.startConnect (dart:io-patch/socket_patch.dart:721:35)
#1      _RawSocket.startConnect (dart:io-patch/socket_patch.dart:1914:26)
#2      RawSocket.startConnect (dart:io-patch/socket_patch.dart:27:23)
#3      Socket._startConnect (dart:io-patch/socket_patch.dart:2138:22)
#4      Socket.startConnect (dart:io/socket.dart:805:21)
#5      _ConnectionTarget.connect (dart:_http/http_impl.dart:2484:20)
#6      _HttpClient._getConnection.connect (dart:_http/http_impl.dart:2923:12)
#7      _HttpClient._getConnection (dart:_http/http_impl.dart:2928:12)
#8      _HttpClient._openUrl (dart:_http/http_impl.dart:2783:12)
#9      _HttpClient.openUrl (dart:_http/http_impl.dart:2620:7)
#10     _WebSocketImpl.connect (dart:_http/websocket_impl.dart:1021:42)
#11     WebSocket.connect (dart:_http/websocket.dart:320:22)
#12     new IOWebSocketChannel.connect (package:web_socket_channel/io.dart:81:28)
#13     connect (package:web_socket_channel/src/_connect_io.dart:15:24)
#14     new WebSocketChannel.connect (package:web_socket_channel/src/channel.dart:144:16)
#15     _defaultWebSocketBuilder (package:dds/src/dds_impl.dart:54:27)
#16     DartDevelopmentServiceImpl.startService (package:dds/src/dds_impl.dart:82:40)
#17     DartDevelopmentService.startDartDevelopmentService (package:dds/dds.dart:97:19)
#18     main (file:///C:/Dev/Test%20Projects/write_to_exited_process/bin/vm.dart:7:44)
#19     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297:19)
#20     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

Exited (255).

Speaking to @bkonyi, it sounds like this is not intended and we shouldn't need to wrap our own zones (in this case in the DAP startup code that tries to ensure there is a DDS for the target process) to handle these errors.

@derekxu16 can you take a look when you have a chance?

Possibly related to this (but if not I can file another issue)

This issue felt familiar, so I did some digging and found this: https://github.com/flutter/flutter/pull/141821
Basically, this is just the behavior of zones, which is kind of gross.

Ah, thanks for the info, that explains what I see. I handled this by using a completer in https://dart-review.googlesource.com/c/sdk/+/366662 but that's also quite gross, so if we could eliminate the need for a zone (the original issue here) we can remove than and just have the original simple try/catch :-)

@bkonyi, so is our goal here to make exceptions thrown when starting DDS catchable? This webSocketBuilder call currently doesn't run in a Zone with an error handler (https://github.com/dart-lang/sdk/blob/fe91f3eed881db23f51dda65616b004a35ed2f57/pkg/dds/lib/src/dds_impl.dart#L83). So I think that if we want to make exceptions thrown when starting DDS catchable, we have to use a Completer + runZonedGuarded similarly to how @DanTup used them in his CL.

Yeah, basically we just don't want unhandled asynchronous exceptions to leak out of DDS. If it makes sense to throw (e.g., if remoteVmServiceWsUri points to a VM service that doesn't exist) we should throw synchronously. If it makes sense to swallow an exception (e.g., the VM service connection disappears, which indicates we DDS should shutdown), we should do that and shutdown gracefully.

I've just published dds 4.2.3, which includes the fix.
https://pub.dev/packages/dds/versions/4.2.3

Thanks! I've opened https://dart-review.googlesource.com/c/sdk/+/368567 to remove the unnecessary zone (and confirmed the test still passes).


Detect node headers in nvm directory

Instead of downloading headers at configuration time it would be great if existing node headers would be detected if they are placed in ~/.nvm/versions/node/$(nvm current)/include.

This tool is intended to be cross platform; a big part of the rewrite was streamlining and simplifying the design. NVM isn't supported on windows, so this isn't very high priority to me. I'll add it to the backlog of changes to consider, but don't hold your breath.
You're welcome to make the change yourself and issue a pull request (against dev). This would belong in the NodeJS.cmake; a bit of refactoring to make the download optional and some logic for defining the header locations from nvm.


Dynamic aliases

These are aliases that are only dynamically associated with a target. For example the target that today resolves to would depend on the current date. These are potentially not enumerable, Next Monday, `
It's likely that links in this form would not appear as backlinks.
Unsure about use cases beyond dates.

These are potentially not enumerable

Although, we can make it work in many cases:
export function expandAliasPrefix(prefix: string) {

Can expand "2" to "2 weeks from now", "2 days from now" ....


fix(http): properly invoke abort

The abort signal does not work as abort is not invoked. This pr fixes that issue and invokes abort when abort signal aborts.

😄 eslint is not happy about me removing void keyword haha

@amrbashir hi, I have added it to .changes dir but im not sure if it is okay or not.

thank you


Compile error: the method take exists for mutable reference, ... trait bounds were not satisfied

error[E0599]: the method `take` exists for mutable reference `&mut swc_ecma_ast::Regex`, but its trait bounds were not satisfied
   --> /Users/niklas/.cargo/registry/src/github.com-1ecc6299db9ec823/swc_ecma_transforms_compat-0.87.0/src/regexp.rs:46:56
    |
46  |                 let Regex { exp, flags, span } = regex.take();
    |                                                        ^^^^ method cannot be called on `&mut swc_ecma_ast::Regex` due to unsatisfied trait bounds
    |
   ::: /Users/niklas/.cargo/registry/src/github.com-1ecc6299db9ec823/swc_ecma_ast-0.73.0/src/lit.rs:224:1
    |
224 | pub struct Regex {
    | ---------------- doesn't satisfy `swc_ecma_ast::Regex: Iterator`
    |
    = note: the following trait bounds were not satisfied:
            `swc_ecma_ast::Regex: Iterator`
            which is required by `&mut swc_ecma_ast::Regex: Iterator`
            `&mut swc_ecma_ast::Regex: Iterator`
            which is required by `&mut &mut swc_ecma_ast::Regex: Iterator`

error[E0277]: the trait bound `swc_ecma_ast::ExprOrSpread: From<swc_ecma_ast::Expr>` is not satisfied
  --> /Users/niklas/.cargo/registry/src/github.com-1ecc6299db9ec823/swc_ecma_transforms_compat-0.87.0/src/regexp.rs:53:37
   |
53 |                     args.push(flags.into());
   |                                     ^^^^ the trait `From<swc_ecma_ast::Expr>` is not implemented for `swc_ecma_ast::ExprOrSpread`
   |
   = note: required because of the requirements on the impl of `Into<swc_ecma_ast::ExprOrSpread>` for `swc_ecma_ast::Expr`

error[E0277]: the trait bound `swc_ecma_ast::ExprOrSpread: From<swc_ecma_ast::Expr>` is not satisfied
  --> /Users/niklas/.cargo/registry/src/github.com-1ecc6299db9ec823/swc_ecma_transforms_compat-0.87.0/src/regexp.rs:49:41
   |
49 |                 let mut args = vec![exp.into()];
   |                                         ^^^^ the trait `From<swc_ecma_ast::Expr>` is not implemented for `swc_ecma_ast::ExprOrSpread`
   |
   = note: required because of the requirements on the impl of `Into<swc_ecma_ast::ExprOrSpread>` for `swc_ecma_ast::Expr`

The version of swc_ecma_ast should be updated.

0.73 is the latest version.
In the project I have set this
swc_ecmascript = { version = "0.141.0", features = ["parser", "transforms", "module", "optimization", "react", "typescript", "utils", "visit", "codegen", "utils", "preset_env"] }
swc_common = { version = "0.17.19", features = ["tty-emitter", "sourcemap"] }
swc_atoms = "0.2.11"

even after deleting Cargo.lock and regenerating it, I still get that error.

Fixed with https://github.com/swc-project/swc/commit/ac2357ebd9db876c9c5e753637d608ecceb179c5
Sorry for inconvinience


fix toContain suggest to contain equal message

fixes #6808
Summary
toContain provides a useful "suggest to contain equal" message. This is however not formatted properly.
This PR add a line break to enhance readability.
Test plan
Only updated snapshots.

Codecov Report

Merging #6810 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6810   +/-   ##
=======================================
  Coverage   63.63%   63.63%
=======================================
  Files         235      235
  Lines        9017     9017
  Branches        4        3    -1
=======================================
  Hits         5738     5738
  Misses       3278     3278
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277c547...870ebcb. Read the comment docs.

Mind adding a changelog? :)

Fix lint and we can merge this :)

in a bit !!


feat: Add isFirstFrame and onStart event to SpriteAnimation

Description
This adds isFirstFrame and onStart event callback to sprite_animation.dart.  May not be useful for everyone but I needed to trigger another event whenever an animation was called as multiple factors could trigger that animation.
Checklist

[x] The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
[x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

Breaking Change

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Not certain what format is off....

Not certain what format is off....

Just run flutter format . and it will will it for you.

Not certain what format is off....

Just run flutter format . and it will will it for you. (or melos run format if you have installed melos)

Ran and updated.  I am so used to that being ran in VS Code that I forgot to do it when I did all of this in Android Studio.

@munsterlander would an API as #1552 solve your issue?
For example, would adding a listener to the controller to check when it starts suffice?

I'm not certain but at first glance, I don't think it would, at least not without additional code to determine where the animation is at.

@munsterlander I believe you can listen to the value an determine where the animation is at.

@munsterlander I believe you can listen to the value an determine where the animation is at.
I'm on the phone right now but perhaps in the upcoming week I can provide some code to show that functionality.

That's what I meant.  I would need one listener with a switch statement and now would be math,  i.e. animation.length-currentFrame==0 then it's the end, if it's 0 then the beginning and every where else in between.
Currently, it's just clean defined callbacks. I mean the api route will work - not saying it won't - but it's more verbose and less intuitive.
Ultimately, I will go which ever way you all want to go though.

I will look into this but wouldn't controller.value = 0 be enough?

I will look into this, but wouldn't controller.value == 0 be enough? You could also check against lowerBound or upperBound.
I'll soon make a sample code to actually see how the implementation would be. Then, if you don't mind, I'll ask for your feedback, since it's very helpful.
Thanks a lot!

For sure and I will gladly test. I can go either way, but I liked the callbacks because it was set and forget. With a listener, I need to have the switch statement for the current frame as compared to other values and this means my onStart and onComplete code is now comingled.  That is where my fear of making things more complex vs what do we gain type issue.  I really like single scope functions and not multi function but multifunction can be more versatile, so...

@munsterlander what do you think of:
 _controller.addStatusListener((status) {
  if (status == AnimationStatus.forward) {
    // Started
  } else if (status == AnimationStatus.completed) {
    // Completed
  }
});

I like the idea of having onFrame(index) callback. That way the user will have flexibility of reacting to specific moments within the animation cycle, and even have multiple actions firing at different frames. The onStart() callback then becomes unnecessary.

so how would you check in the update method if (frameIndex == currentIndex)?

Simply call the onFrame() whenever the currentIndex variable is updated.

@alestiago I believe #1552 relates to a SpriteAnimationWidget, i.e. a Flutter widget that can be added anywhere in the Flutter tree, but not in a Flame game. This PR is about a SpriteAnimationComponent, which works within a Flame game, but can't be added directly into a Flutter tree.

I like the idea of having onFrame(index) callback. That way the user will have flexibility of reacting to specific moments within the animation cycle, and even have multiple actions firing at different frames. The onStart() callback then becomes unnecessary.

so how would you check in the update method if (frameIndex == currentIndex)?

Simply call the onFrame() whenever the currentIndex variable is updated.

That makes total sense and I'm like why didn't I see that.  Ok, let me adjust this today.

@munsterlander what do you think of:
 _controller.addStatusListener((status) {
  if (status == AnimationStatus.forward) {
    // Started
  } else if (status == AnimationStatus.completed) {
    // Completed
  }
});

I think you can also do:
_controller.forward().whenComplete(...)

Would the above work for your usecase?
I think this suggested approach is more flexible and as you stated more versatile. For example, you can define the callbacks after the initialisation. A big advantage is that just by googling you can find good solutions since this is just how AnimationController in Flutter works.
We could add onComplete and onStarted callbacks to SpriteAnimationController. Although it would be more convenient, it will deviate us from the "Flutter" side and add more code to maintain. I'm curious to know why Flutter decided not to add those function callbacks altogether. Do you know of any Flutter ticket (GitHub issue) that addresses this?
Wdyt?

I mean, it's a valid solution. I think ultimately, the team needs to weigh in on whether they want to standardize and use event driven callbacks or universal listeners.

@st-pasha both SpriteAnimationWidget and SpriteAnimationComponent use SpriteAnimation. So a change on SpriteAnimation alters both APIs.
I'm not sure if @munsterlander is using SpriteAnimationWidget or SpriteAnimationComponent.
Regardless, I think for SpriteAnimationWidget we should aim for a "Flutter" approach and for SpriteAnimationComponent we should aim for a "Flame" approach. Note that this onStart event is accessible when using SpriteAnimationWidget.
I believe if we try to close the gap between "Flame" and "Flutter" approaches the developer experience will be richer. For example, the recent children addition to Component closed this gap. Hence, I'm thinking perhaps, for flame related animations we should try to mimic the "Flutter" approach to.
Anyways, here I'm worried that by adding the AnimationController, as in #1552, we would end up having two APIs that do exactly the same thing:
 _controller.addStatusListener((status) {
  if (status == AnimationStatus.forward) {
    // Started
  } else if (status == AnimationStatus.completed) {
    // Completed
  }

and
spriteAnimation.onStart = () {...};
spriteAnimation.onComplete = () {...};

My concern is regarding the developer experience since the developer would have to choose between these two. This is not necessarily  "bad"; but we should be aware of it.

Reading #1552, AFAIU, the SpriteAnimationWidget uses a SpriteAnimationController, which in turn uses a Flutter AnimationController and a TicketProvider. In other words, SpriteAnimationWidget is driven by an external Flutter clock. There is no corresponding mechanism for the SpriteAnimationComponent, which is controlled by the Flame engine's game loop. So, I'm not sure how the two approaches can be reconciled.

Reading #1552, AFAIU, the SpriteAnimationWidget uses a SpriteAnimationController, which in turn uses a Flutter AnimationController and a TicketProvider. In other words, SpriteAnimationWidget is driven by an external Flutter clock. There is no corresponding mechanism for the SpriteAnimationComponent, which is controlled by the Flame engine's game loop. So, I'm not sure how the two approaches can be reconciled.

I like the idea of having onFrame(index) callback. That way the user will have flexibility of reacting to specific moments within the animation cycle, and even have multiple actions firing at different frames. The onStart() callback then becomes unnecessary.

so how would you check in the update method if (frameIndex == currentIndex)?

Simply call the onFrame() whenever the currentIndex variable is updated.

@st-pasha I remember why I struggled with the onFrame(index) implementation.  This is mainly due to my lack of dart knowledge, but how do you pass a parameter to a dynamic function?  In short, if the below is my invocation, how do I set the frame number?
myAnimation.onFrame = (frameIndex: 0){
      //do stuff
    };
myAnimation.onFrame = (0){
      //do stuff
    };

When it is created in the component is it?
  void Function(frameIndex)? onFrame;
  onFrame?.call();

Sorry, I am at a loss of how to get the user defined frame into that function call.

There are at least two ways:
// 1
onFrame?.call(index);

// 2
if (onFrame != null) {
  onFrame(index);
}

There are at least two ways:
// 1
onFrame?.call(index);

// 2
if (onFrame != null) {
  onFrame(index);
}

So that is what I was trying, but I was getting errors.  Here is the full code:
sprite_animation.dart
  /// Registered method to be triggered when the frame changes.
  void Function(index)? onFrame;

void update(double dt) {
    clock += dt;
    elapsed += dt;
    if (_done) {
      return;
    }
    while (clock >= currentFrame.stepTime) {
      if (isFirstFrame){
        onStart?.call();
      }
      if (isLastFrame) {
        if (loop) {
          clock -= currentFrame.stepTime;
          currentIndex = 0;
        } else {
          _done = true;
          onComplete?.call();
          return;
        }
      } else {
        clock -= currentFrame.stepTime;
        currentIndex++;
      }
      onFrame?.call(index);
    }
  }

My component:
explodingPoppedAnimation.onFrame = (0){
      _explodingNow = true;
    };

This throws it expects an identifier, so I did:
 explodingPoppedAnimation.onFrame = (index: 0){
      _explodingNow = true;
    };

This throws:
A value of type 'void Function({dynamic index})' can't be assigned to a variable of type 'void Function(dynamic)?'. (Documentation)  Try changing the type of the variable, or casting the right-hand type to 'void Function(dynamic)?'.

I tried variations but always ended up with similar error.  Apologies again, dart is not my strongest language and I have been looking but have not been finding examples of this type of call.

You need to provide types for the arguments. So:
void Function(int index)? onFrame;

explodingPoppedAnimation.onFrame = (index) {
  _explodingNow = true;
};

So that would be a bad quick typing of the function call, with that, this is the error:
A value of type 'void Function({dynamic index})' can't be assigned to a variable of type 'void Function(int)?'. (Documentation)  Try changing the type of the variable, or casting the right-hand type to 'void Function(int)?'.

is this correct:
   explodingPoppedAnimation.onFrame = ({index=0}){
     _explodingNow = true;
   } as void Function(int index)?;

Not quite. Curly braces around an argument mean that you want this to be an optional argument. So fn = ({index = 0}){...} is a function takes an optional named parameter index, and can be called like this: fn(index: 1) or fn(). Since you haven't given the type for index, Dart assumes it's dynamic, which basically means "any type". So, fn(index: 'hello') would also work.
Now, an onFrame parameter should be a function that takes a single argument, which is integer and unnamed. Thus, you want to write like this: onFrame = (int index){...}. Here no-braces means it's a regular positional parameter, and it cannot be required. So, this function can be called as onFrame(1) but not onFrame('hello').
In some situations, Dart is able to detect argument types automatically. Thus, you can also write onFrame = (index){...}, which assigns a function of type void Function(dynamic) to a parameter of type void Function(int).

 /// Registered method to be triggered when the frame changes.
 void Function(int index)? onFrame;
// upload.....
onFrame?.call();

When calling the onFrame function, don't forget to pass the frame index:
onFrame?.call(currentFrameIndex);

Ok, I think this is what has had me confused the whole time.  Understanding everything that you just wrote, in my component, when I call animation.onFrame(0 or 2 or whatever) that then would trigger the onFrame?.call(currentIndex).  How / where is the comparison occurring where the passed index from the component is getting compared to the currentIndex in the sprite_animation class?  At some point there needs to be if passedIndex==currentIndex then....  thats why onStart and onComplete were easy to me, but this is dropping me for a loop.  There needs to be a comparison somewhere of the two values but I can't seem to make them sync.
Again, I sincerely apologize for what is probably a simple thing, I am trying to help where I can, but I fear I am just causing more problems.

Hmm, the onFrame() should be invoked by the SpriteAnimationComponent with the value of the current frame index. Then, the callback that you provide can look at that frame index and decide to take action based on what index it is. Something like
animation.onFrame = (int index) {
  if (index == 0) {
    // This is the beginning of the animation: the balloon rises up through the air
  } else if (index == 12) {
    // Suppose 12'th frame is when the balloon pops
    FlameAudio.play('pop_sound.mp3');
  } else if (index == 18) {
    // Suppose this is the end of the animation, so you add a "fade-in" effect here
    animation.add(OpacityEffect.to(0, EffectController(duration: 1)));
  }
};

Literally as I was editing my response, I understood what was happening.  Ok, I can update the PR.  I am dumb.  Sincerest apologies, lol.

@st-pasha Thank you again so much.  I had it stuck in my brain that when you instantiate onFrame in your component, it is passing the requested index to the class and the comparison needed to happen in the class.  Once I realized that the class passes the index to your anonymous function in your component, it all clicked.
I have added the code as @erickzanardo and you have requested.  Now having done that, I left onStart in there and it may be something you want removed, but I would make a strong argument for leaving it and maybe just a plea to leave it, because I like how clean it makes my code.
I don't need a bulky switch statement in an onFrame where I make calls to other functions, because I can just call onStart and that code that is needed is there and the onComplete code is guaranteed to only run once.   Either way, I can go with whatever you all want to do, but I find use in all three methods.
Maybe @spydon will come rushing in to support my weak argument?

Perhaps it could make sense to have onStart to be a counterpart of onComplete and run only once when the animation starts, but not as it loops?

Makes sense. Let me change that real quick.

Suggested tests:
1. Check that the sequence of events is onStart -> onFrame x n -> onComplete.

2. Check that for an animation with n frames, onFrame is called exactly n times.

3. Verify that `onFrame` is called at the beginning of each animation frame, not at the end.

With the Mock Sprite, does it mock any length of frames or is it by default, just a single frame animation?

Suggested tests:
1. Check that the sequence of events is onStart -> onFrame x n -> onComplete.

2. Check that for an animation with n frames, onFrame is called exactly n times.

3. Verify that `onFrame` is called at the beginning of each animation frame, not at the end.

I added 1 and 2.  For 3, I am not certain how exactly to test that.

Edit:  Also, I am not 100% the test for event lifecycle will work for all devices - specifically, line 123.  If I call that expect after the update, I am curious if its synchronous in nature or if its working because my device is slow and the onComplete executes faster than the update.  Anyway, I open to suggestions.

There are no asynchronous operations involved here so you don't have to worry about the order.
For test number 3 you can run small increments in update to see that the first increment that overlaps the frame triggers the callback (and not the last). It looks like it actually triggers in the end of the frame now, so you'd have to call the callback for the next index (wrapped with modulo if the animation should repeat) in the while-loop, and the callback for the first frame has to be done together with the onStart callback.

For test number 3 you can run small increments in update to see that the first increment that overlaps the frame triggers the callback

Good idea!

so you'd have to call the callback for the next index (wrapped with modulo if the animation should repeat) in the while-loop

I think a more reliable approach is to call onFrame() immediately after the currentIndex++ statement (and also currentIndex = 0). That way you won't have an extra call when the animation is about to complete.

    test('verify call is being made at the first of the frame for multi-frame animation', () {
      double step = 0;
      final sprite = MockSprite();
      final animation =
      SpriteAnimation.spriteList([sprite, sprite, sprite], stepTime: 1, loop: false);
      animation.onFrame = (index) {
        if(step % 1 == 0){
          expect(index,step);
        }
      };
      while(step <= 3){
        step += 0.5;
      }
    });
    ```

I moved the `onFrame` call as  suggested and this is passing.  I just want to check and make sure this is what you were thinking?  I have a merge conflict that for whatever reason won't fetch on my machine, so I will need to figure it out.

I moved the onFrame call as suggested and this is passing. I just want to check and make sure this is what you were thinking? I have a merge conflict that for whatever reason won't fetch on my machine, so I will need to figure it out.

Almost, you also have to pass the step to update, and you can't have % 1 when you have a step of 0.5 since both the beginning and end of a frame will result in 0 then.
So it would be something like this instead:
    test('verify call is being made at the first of the frame for multi-frame animation', () {
      var timePassed = 0.0;
      var dt = 0.5;
      var timesCalled = 0;
      final sprite = MockSprite();
      final spriteList = [sprite, sprite, sprite];
      final animation = SpriteAnimation.spriteList(spriteList, stepTime: 1, loop: false);
      animation.onFrame = (index) {
          expect(index, timePassed);
          timesCalled++
      };
      while(step <= 3){
        timePassed += dt;
        animation.update(dt);
      }
      expect(timeCalled, spriteList.length);
    });

Edit: @spydon and @st-pasha I just want to confirm with you that onFrames expected behavior (by doing the changes suggested) means that it would not be called on the last frame of a non-looping animation and the only way for that to succeed would be by calling onComplete. By doing the calls after currentIndex is incremented, this is a by-product UNLESS I pull it out of the if statement and just put it after the if statement, in which case onFrame will get called regardless of the type of animation but at the beginning of every frame. Does that make sense?

Yes, onFrame should be called for the last frame too, and it should not be called when onComplete is called since that should be called once the last frame ends, not when it begins. It should be fine to have it within the if-statement since the if statement checks if the current frame is the last frame before currentIndex is incremented.

I have a merge conflict that for whatever reason won't fetch on my machine, so I will need to figure it out.

This is due to the change that was merged in #1564, do you need help sorting out the conflict?

@spydon Here is what ended up passing:
    test('verify call is being made at the first of the frame for multi-frame animation', () {
      var timePassed = 0.0;
      const dt = 0.5;
      var timesCalled = 0;
      final sprite = MockSprite();
      final spriteList = [sprite, sprite, sprite];
      final animation = SpriteAnimation.spriteList(spriteList, stepTime: 1, loop: false);
      animation.onFrame = (index) {
        expect(index, timePassed);
        timesCalled++;
      };
      while(timePassed <= 3){
        timePassed += dt;
        animation.update(dt);
      }
      expect(timesCalled, spriteList.length-1);
    });

Other tests were corrected.  I will now work on resolving the conflict.  Its a simple conflict, but git isn't fetching the change, so I just need to see why.

  expect(timesCalled, spriteList.length-1);
});

Why do you have -1 here? It should be called for each frame?

  expect(timesCalled, spriteList.length-1);
});

Why do you have -1 here? It should be called for each frame?

Thats what we are discussing here: https://github.com/flame-engine/flame/pull/1492#discussion_r856426592

You can run flutter format . and then commit the result to make the formatting check pass.

This thing is annoying.  I ran it, committed and pushed, then melos says lines over 80, so I go correct those, re run it, commit, but something else pops up after push.  I have rerun it, commited and pushed again, lol.  Quick question on that though, do you manually run that command or do you let Android Studio (if you use that) do its reformat code before commit?

This thing is annoying.  I ran it, committed and pushed, then melos says lines over 80, so I go correct those, re run it, commit, but something else pops up after push.  I have rerun it, commited and pushed again, lol.  Quick question on that though, do you manually run that command or do you let Android Studio (if you use that) do its reformat code before commit?

I let android studio auto format. Maybe you don't have the newest version of flutter? Then the formatting can differ, run flutter upgrade first.

I do. Not certain, but I found this and will check it shortly.   https://stackoverflow.com/questions/27092772/auto-code-formatting-in-android-studio


Translate /docs/configuration into Korean.

/area documentation
What would you like to be added:
Translate docs/configuration into Korean.
Why is this needed:
There is no docs docs/configuration in Korean

/assign
/assign bluefriday


[DEV] Fixing stalling CI build for TF

Position of the problem

Both TF CI builds started timing out a couple days ago. The last passing build was this one (besides the passing build, the corresponding PR passed the checks twice consecutively and didn't ever time out, which indicates with extremely high confidence that it did not cause the issue.
The builds fails after 25-50 min with the error "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself."
Other builds are fine.

What we know

The failure is stochastic; sometimes one of the two TF builds (for Python 2.7 and 3.6) fails while the other passes. Most common case is that both fail, indicating that P(failure) is high.
There are cases where TF Py 2.7 fails while 3.6 passes and cases where 3.6 fails while 2.7 passes, so the issue is not specific to a Python version.
We did not merge any changes that did not pass the CI checks, hence the failure is not caused by a change on our end in isolation. It is all or in part due to something that changed on the Travis side or in the build dependencies (e.g. TF).
Timing variance for the TF builds has greatly increased as a result of this issue (now 20-40 min, before it was about 20-25 min).
The issue is not due to large tests taking too long to run.
The issue is not due to multiprocessing tests.
The issue is not due to image preprocessing tests.
The issue is not due to timeout configuration of Travis.

My opinion
The timing of the failure makes me think that the breaking change is the upgrade to TF 1.8 (the build installs TF via pip install tensorflow, which would have switched from 1.7 to 1.8 in the past few days).
1.8 might be using too much RAM or suffer from multiprocessing issues.
I will try reverting to TF 1.7 until we can figure it out.
CC
@Dref360 @taehoonlee @DavidAriel

Update: reverting to TF 1.7 fixes the build. https://github.com/keras-team/keras/pull/10101

I think that it actually is a Travis CI timeout, but this is a symptom of a deeper performance issue you mentioned that causes the timeout to begin with. I wasn't able to change the Travis 10 minutes default timeout, but even if it was changed the TF rollback sounds reasonable.

The problem isn't that the tests are taking too long to run, it's that execution is stalling (no output whatsoever) for over 10 min. Could it be that a single test has started taking over 10 min to run?

Actually, I think that there is a test that takes more than 10 minutes and causing the timeout error:
test_serialization in the keras/activations_test.py
The reason I say that is after examining this  Travis log I noticed that only gw0 worker thread does all the work and gw1 get stuck. The last print the gw1 lets out before it enters the test that times out is that test_saving_recurrent_layer_without_bias has passed.
The next test (that times out) for gw1 is test_serialization since files are ordered alphabetically, and it is the first in the file. Also, you can see no "passed" printed for this test. The rest of the tests in keras/activations_test.py and in the tests folder are done solely by gw0.
After that, eventually Travis kills gw1 and fails the build.

test_serialization takes a few seconds normally (with TF 1.7). What about TF 1.8 would cause it to stall? And is this indicative of an actual bug? Can you reproduce this locally?

The test_serialization looks good in my local PC:
 $ pip show tensorflow
Name: tensorflow
Version: 1.8.0
Summary: TensorFlow helps the tensors flow
Home-page: https://www.tensorflow.org/
Author: Google Inc.
Author-email<EMAIL_ADDRESS>License: Apache 2.0
Location: /home/taehoonlee/miniconda2/envs/taehoonlee/lib/python2.7/site-packages
Requires: protobuf, tensorboard, absl-py, grpcio, enum34, six, termcolor, gast, wheel, backports.weakref, astor, mock, numpy
Required-by:

 $ KERAS_BACKEND=tensorflow pytest tests/keras/activations_test.py -k test_serialization
=================================== test session starts ====================================
platform linux2 -- Python 2.7.13, pytest-3.5.0, py-1.5.3, pluggy-0.6.0 -- /home/taehoonlee/miniconda2/envs/taehoonlee/bin/python
cachedir: .pytest_cache
rootdir: /home/taehoonlee/keras, inifile: pytest.ini
plugins: pep8-1.0.6
collected 14 items / 13 deselected

tests/keras/activations_test.py::test_serialization PASSED                           [100%]

========================= 1 passed, 13 deselected in 0.80 seconds ==========================

It's not a particular test imo.
For exemple :
In this PR, https://travis-ci.org/keras-team/keras/jobs/373965739
tests/test_multiprocessing.py::test_multiprocessing_training_from_file
is blocked.
Tf release note : https://github.com/tensorflow/tensorflow/releases
Looking at TF 1.8 release note. I don't see anything that would cause this issue.

Update nsync synchronization library to avoid slow primitives on Linux.
Low-level graph construction now calls the TensorFlow C API.

For info, the CPU optimizations are the same as 1.7.

I agree that test_multiprocessing_training_from_file is blocked in the log you linked, I misread the log files I read, they show the same thing.
Specifically it is like so in the log file I linked in my previous comment, so I carefully assume it is like so in all build logs that failed.
So my current hypothesis is that the stalling test is test_multiprocessing_training_from_file and not test_serialization
@taehoonlee, did test_multiprocessing_training_from_file also run fine on your setup?

As I said, it's not a particular test. It's purely random.
In this build.
https://travis-ci.org/keras-team/keras/jobs/373577762
It passes.

OK I agree, it is random.


Discv5 AuthHeader Packet Preparation

Helpers to simplify creation of auth header message packets.
Builds on top of #737
To-Do

[ ] Clean up commit history

Cute Animal Picture

I've addressed the feedback, put will wait with rebasing until the parent PRs are merged.


Included CSAT

Updated flows to include in channel CSAT

This PR has been superseded by https://github.com/GenesysCloudBlueprints/limitless-flows-blueprint/pull/3 (to fix the merge conflict)


02282018 remove old bmc

https://gerrit.openbmc-project.xyz/#/c/9004/ will be removing support for the legacy bmc control object.  BMC reboots now go through the BMC phosphor state object.

@geissonator what systems support the new method? All of them? How long have they supported it for?
This is a tool external to the BMC, so it needs to account for scenarios where we only have one or the other method available (BMCs running old OpenBMC builds).
Depending on the answer to the questions above we may want to do this in phases. Generally:

Continue to use the old method, but print a warning saying it's deprecated and will be removed in in timeframe X. Introduce an option and documentation to force the use of the legacy approach.
Switch the implementation to use the new approach, ensure the command exit status is failure if the new approach is not supported. Users must update to add the switch for the legacy approach if necessary.
Once we're convinced there are no BMCs with firmware that only supports the legacy approach (e.g. reaching date X), remove it.

This new interface has been in place since this commit on all systems - https://gerrit.openbmc-project.xyz/#/c/1558/.  (Jan 2017) so I think we're fine to just merge this as-is.


{keymap}: separate color per each key bindings keymap

Good morning, Chris!
Is it possible to add a feature for {keymap} to have a separate color per each key bindings keymap.

To make variables just like flexprompt.settings.*_keymap, but for colors
flexprompt.settings.emacs_color
flexprompt.settings.vicmd_color
flexprompt.settings.viins_color
Thank you in advance!
Have a good day!

Include the escape codes in the strings.
E.g.
flexprompt.settings.emacs_keymap = "\027[38;5;69m".."emacs"

Wow! Thank you. I didn't know about this way. Thank you for the link!


Does mosn support http3?

Does mosn support http3?
Does mosn support Triple X?

Does mosn support http3? Does mosn support Triple X?

not support http3 yet. not support triple X yet.
Welcome to submit PR if you are interested.


Clarify port documentation

"Typically, port 5671 and 5672 must be opened on the machine consuming data from the event hub."
Is this inbound from the perspective of the consuming machine? Also, are these ports TCP-only, or TCP/UDP?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2258670a-245c-ede4-5805-a07e589d5f13
Version Independent ID: 136e5653-2eae-8fa5-ded2-116254acf792
Content: Stream Azure monitoring data to Event Hubs
Content Source: articles/monitoring-and-diagnostics/monitor-stream-monitoring-data-event-hubs.md
Service: azure-monitor
GitHub Login: @johnkemnetz
Microsoft Alias: johnkem

@bmilbauer Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

@femsulu please assign to @nkiest

adding @nkiest

Any updates on this?

#reassign:nkiest

@nkiest Can you comment on this?

#label:"CreateAzMonWIFeb2021"

Thank you for your contribution to the Azure Monitor documentation. We have created a workitem for this issue in our internal backlog database. We will prioritize it and make any necessary changes as we are able.
#please-close


Design

Description
Someone can suggest a design to improve the UI/UX.
There are many stuffs than can be implemented to improve the UIUX of the website which can be improved

The website and footer section looks odd
About Us section looks oddly big and hurts the user's eyes
In hospital bed page we see hospital beds are shown which a user can find to be difficult
The homepage can be made attractive by using different designs and colours too

Screenshots
No response
Additional information
No response

I'm currently exploring UI/UX in Canva and Figma , I would like to give it try to improve the interface of the web app

I'm currently exploring UI/UX , I'm passionate about it, I would like to give it try to improve the interface of the web app

Go with it

I'd like to contribute to this project can this assigned to me.


Modifier -> SwiftUI -> View fundamentals -> View -> Input and event modifiers: widgetURL(_:)

Doc: https://developer.apple.com/documentation/swiftui/view/widgeturl(_:)

[ ] Swift implementation
[ ] Elixir implementation

LiveView Native cannot be used to create widgets.


Check compatibility and add 5.2 version

Need to test the plugin with UE v5.2.
If v5.1 works without modification, it should still be built for 5.2 and provided via releases.

Hi! I need to use this plugin on 5.2. Do you have any test cases I can run to make sure the plugin is behaving correctly?


Certificate expired

Hi,
your project stop work, because of certificate revocation.
Original Exception was java.security.cert.CertPathValidatorException: validity check failed
Caused by: java.security.cert.CertPathValidatorException: validity check failed
Caused by: java.security.cert.CertificateExpiredException: NotAfter: Wed May 23 13:04:11 CEST 2018
Could you repair it asap please? I need it for my school project, just need working playground connection for now.
Many Thanks

Hi,
the problem is not in the library but rather in the EET playground itself. Responses from this environment are signed with an expired certificate (NotAfter: Wed May 23 13:04:11 CEST 2018).
Here is one communication log I recorded today, capturing the request/response with this expired certificate: https://gist.github.com/todvora/2210e2d5ae146c47bf1ef12d64e36e53
There is currently nothing I can do with it, they have to renew the playground certificate. The certificate isn't part of this library, it's delivered with every XML response during the real communication mode (on the playground endpoint). I just enforce certificates validation.
Let's just hope they will fix it soon. For your school project, feel free to point your teacher to this issue. If you send messages int the CommunicationMode.TEST, they are not signed (here's why), there is no certificate to be validated and nothing to fail currently. Maybe you can present this mode.
Best regards,
Tomas

They know about the problem and promised that it will be solved: https://twitter.com/SPCSS_sp/status/999385203817832448

Resolved, playground now uses fresh certificate valid till 2019:

The actual certificate can be seen here: https://github.com/todvora/eet-client/blob/master/src/test/resources/keys/crls-demo-cert.pem (not used by the library, only for JUnit purposes).
Your real communication against the playground endpoint should be OK now.
Best regards,
Tomas


filename isn't vertically centered in Chrome's file input

The text on file inputs is not centered on Chrome.
This looks to be an issue with Chrome, as it is centered on Safari and FireFox.  The baseline for the text is shifted up a few pixels.
I don't know if this is fixable cross-browser in a good way.
setting line-height to 0 seems to help a bit
 input[type="file"] {
   display: block;
+  line-height: 0;
 }

Chrome default

Recentered

How do you reproduce this issue? I used the file input example from http://getbootstrap.com/css/#forms-example and used the master branch. The text to the right of the file input looks centered to me. Why is the file input button rounded in the screenshots?

Sorry, I should have been more clear:
The above screenshots are of http://getbootstrap.com/css/#forms using the latest Chrome on Mac OSX

We supposedly set display: block in order to "Set the height of file controls to match text inputs", but FWICT the heights don't seem to match.
Random observation: Setting display: flex fixes the alignment in Chrome (ditto with -webkit-flex in Safari), although the height still doesn't match.
CC: @mdo

There's no good way to center this across all browsers—the file input is super inconsistent. Punting as a won't fix.


'ue4 conan generate' fails on 5.1.0

Output of the ue4-docker info command:
ue4-docker version:         0.0.102 (latest available version is 0.0.102)
Operating system:           Linux (Ubuntu 20.04.3 LTS, 5.11.0-1028-aws)
Docker daemon version:      20.10.12
NVIDIA Docker supported:    No
Maximum image size:         No limit detected
Available disk space:       491.4 GiB
Total system memory:        30.35 GiB physical, 6.39 GiB virtual
CPU:                        8 physical, 16 logical (x86_64)

Building 5.1.0 fails at the ue4 conan generate step:
Copying the "ue5.1-Linux-x86_64-unknown-linux-gnu" Conan profile into a new profile named "ue4"...
Retrieving thirdparty library list from UBT...
Traceback (most recent call last):
  File "/usr/local/bin/ue4", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/ue4cli/cli.py", line 222, in main
    SUPPORTED_COMMANDS[command]['action'](manager, args)
  File "/usr/local/lib/python3.8/dist-packages/conan_ue4cli/main.py", line 48, in main
    SUBCOMMANDS[subcommand]['function'](manager, args[1:])
  File "/usr/local/lib/python3.8/dist-packages/conan_ue4cli/commands/generate.py", line 153, in generate
    libs = [lib for lib in manager.listThirdPartyLibs() if lib != 'libc++']
  File "/usr/local/lib/python3.8/dist-packages/ue4cli/UnrealManagerBase.py", line 183, in listThirdPartyLibs
    return interrogator.list(self.getPlatformIdentifier(), configuration, self._getLibraryOverrides())
  File "/usr/local/lib/python3.8/dist-packages/ue4cli/UE4BuildInterrogator.py", line 20, in list
    modules = self._getThirdPartyLibs(platformIdentifier, configuration)
  File "/usr/local/lib/python3.8/dist-packages/ue4cli/UE4BuildInterrogator.py", line 170, in _getThirdPartyLibs
    self.runUBTFunc('UnrealEditor', platformIdentifier, configuration, args)
  File "/usr/local/lib/python3.8/dist-packages/ue4cli/UnrealManagerBase.py", line 695, in <lambda>
    ubtLambda = lambda target, platform, config, args: self._runUnrealBuildTool(target, platform, config, args, True)
  File "/usr/local/lib/python3.8/dist-packages/ue4cli/UnrealManagerBase.py", line 687, in _runUnrealBuildTool
    return Utility.capture(arguments, cwd=self.getEngineRoot(), raiseOnError=True)
  File "/usr/local/lib/python3.8/dist-packages/ue4cli/Utility.py", line 125, in capture
    raise Exception(
Exception: child process ['/home/ue4/UnrealEngine/Engine/Build/BatchFiles/Linux/Build.sh', 'UnrealEditor', 'Linux', 'Development', '-Mode=JsonExport', '-OutputFile=/tmp/tmps0jdktyq/ubt_output.json'] failed with exit code 1
stdout: "Setting up bundled DotNet SDK
Running command : dotnet Engine/Binaries/DotNET/UnrealBuildTool/UnrealBuildTool.dll UnrealEditor Linux Development -Mode=JsonExport -OutputFile=/tmp/tmps0jdktyq/ubt_output.json
Welcome to .NET !
---------------------
SDK Version:
Telemetry
---------
The .NET tools collect usage data in order to help us improve your experience. It is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.
Read more about .NET CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry
----------------
Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only).
Learn about HTTPS: https://aka.ms/dotnet-https
----------------
Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
--------------------------------------------------------------------------------------
"
stderr: "Could not execute because the specified command or file was not found.
Possible reasons for this include:
  * You misspelled a built-in dotnet command.
  * You intended to execute a .NET program, but dotnet-Engine/Binaries/DotNET/UnrealBuildTool/UnrealBuildTool.dll does not exist.
  * You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH.
"
The command '/bin/sh -c ue4 conan generate' returned a non-zero code: 1

Could this have something to do with UBT needing to be pre-built?

Please, report this to https://github.com/adamrehn/conan-ue4cli instead.

Apologies - moved to https://github.com/adamrehn/conan-ue4cli/issues/20

Apologies - moved to adamrehn/conan-ue4cli#20

Could you solve this issues?
I tried to override the conan-ue4cli version via -conan-ue4cli git+https://github.com/JJC1138/conan-ue4cli.git@ue5fix via ue4docker trying these two patches: https://github.com/adamrehn/conan-ue4cli/pull/21 https://github.com/adamrehn/conan-ue4cli/pull/15 - unfortunately that did not fix the issue.

Assuming there wasn't some failure to honour -conan-ue4cli, that suggests that the fix from those PRs is not sufficient. I at least don't know enough about conan-ue4cli to be able to say more than that.
If you just build the minimal image, and then run it up, install that version of conan-ue4cli, and execute ue4 conan generate, does it work? If so, then there might be something wrong with the -conan-ue4cli handling in ue4-docker. If not, then the fix is not sufficient, and there's nothing we can do in this repo until conan-ue4cli is correctly fixed.


Version bump

Related Issues

[none]

Security Implications
[none]
System Availability
[none]

why do we need another version bump here?

apparently prettier missed something that showed up during deployment


more comment types for Matlab

(Original issue 776 created by None on 2012-05-30T00:23:04.522440+00:00)
Matlab has two types of comment that pygments doesn't support:

Block comments start with %{ and end with %}. Each of these must appear on a line by itself, with the exception of whitespace.

Anything on the current line that follows a ... is a comment.

Full details are available on the Mathworks website at http://www.mathworks.com/help/techdoc/ref/specialcharacters.html.
Please add these comment types to pygments. Thank you very much!

(Original issue 776 last updated on 2012-08-19T09:08:39.472168+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by birkenfeld on 2012-08-19T09:08:39.470136+00:00)
Closes #776: implement more comment types for MATLAB.
→ <<cset 59408e7c9e80>>


[BUG] EasyAuth crashes the server when using Create's Deployer block

Versions

EasyAuth mc1.19.1-3.0.0-8
Fabric API 0.76.0+1.19.2
Create 0.5.0.i-961+1.19.2

Describe the bug
Server crash when using the Deployer from Create (caused by easyauth validation)
To Reproduce
Steps to reproduce the behavior:

Spawn the deployer item
Put it on the ground
Connect the creative motor to it
It will crash

Expected behavior
It shouldn't crash, user is authenticated
Additional context
Attaching the crash report
crash-2023-04-09_02.19.37-server.txt

It was fixed in 3.0.0-14 version.

Oh, my bad! Thanks for the quick response :) I guess the issue can be closed.


Fix typo

Are you sure it's not nvm? "Node Version Manager"

Sorry, never mind I read that wrong. Not a typo then.

It was not a typo at all.


Poset: add clone, ==, hash and sub

Extends the POSet class with some useful methods to compare and (partially) copy posets.

+1, very nice and useful
I would suggest an integration with model views to pass visibility and other filters as parameters.


add MailDev service

this PR adds the MailDev service as an alternative to MailHog.
why is MailDev MegaCool™?

when you get a new email you're getting updated directly in the tab title

MailDev has some PrettyCool™ features like responsive view, see email as text, etc

might be worth adding some competition to MailHog. who knows.

Thanks @godbout!


Set proper lower bound for portalocker dependency, drop packaging dependency

packaging was only used as a dependency to check for the version of portalocker in use.
This drops that dependency and instead corrects the minimum version of portalocker to the one checked here.
It should be safe to depend on a version of portalocker that has been out for 3 years at this point, and is not quite as intrusive as #117 that would remove portalocker altogether (and in all honesty, that PR has been out there for a year, with no sign of merging).

@microsoft-github-policy-service agree

There is a history behind it.

packaging was only used as a dependency to check for the version of portalocker in use.
This drops that dependency and instead corrects the minimum version of portalocker to the one checked here.
It should be safe to depend on a version of portalocker that has been out for 3 years at this point

We started with portalocker=~1.6 in the first place, and then @bluca convinced us to relax the lower bound for Linux. If @bluca can chime in to say it is now OK to also use portalocker 1.6+ on Linux, we will consider this PR.

#117 that would remove portalocker altogether (and in all honesty, that PR has been out there for a year, with no sign of merging).

You can chime in in that PR and ping the reviewer there. That PR was developed based on a need at that time, but the integration test effort was suspended, so, there is little motivation to move forward.

@rayluo Thanks for the feedback. My angle to this is trying to prune extra dependencies that aren't really needed – seems a waste to depend on (and download!) all of packaging just to be able to compare a version to another.
If, AIUI, not upgrading Portalocker is mostly the issue of more work for downstream Linux packagers, I understand and we'll need to deal accordingly, packagers can be an ornery bunch 😄

It looks like Ubuntu 20.04 (still LTS supported) has python3-portalocker 1.5.1-1, so that would be an issue for pinning to 1.6+.
Debian Bullseye (the oldest still supported Debian) has 2.2.1, not an issue.

(I don't quite know how to check for the other major distros.)
Maybe the heuristic for whether the file_open_kwargs can be passed could be done without an external dependency – some ideas:

parse portalocker.__version__ "by hand" into a version_info style tuple and compare it
check whether file_open_kwargs exists in the __doc__ for portalocker.Lock.__init__ – a bit hacky, maybe, but should do the trick?

IOW, @bluca, what do you think, would Portalocker >= 1.5 be a good middle ground 3 years after #49? 😁

IOW, @bluca, what do you think, would Portalocker >= 1.5 be a good middle ground 3 years after #49? 😁

yes, fine by me

@rayluo Okay, rebased + pushed a version that changes the pin to >= 1.4.


Can't switch to the Code Editor when in the Debug Tool

As the title says, go to the debug tool, and try to switch to the code editor

The code editor button is also drawn wrong:

Unlike other places:

This has been fixed


Add target-c-int-width in x86_64-blog_os.json

There was an error in Travis-CI

error: Error loading target specification: Field target-c-int-width in target specification is required

So I add "target-c-int-width" to the x86_64-blog_os.json file

{
"llvm-target": "x86_64-unknown-none",
"data-layout": "e-m:e-i64:64-f80:128-n8:16:32:64-S128",
"linker-flavor": "gcc",
"target-endian": "little",
"target-pointer-width": "64",
"target-c-int-width": "32",
"arch": "x86_64",
"os": "none",
"disable-redzone": true,
"features": "-mmx,-sse,+soft-float"
}

I think the value is "32" which is the same in other OS

Thanks for reporting! It seems like the field was introduced it this PR: https://github.com/rust-lang/rust/pull/44906
As far as I understand it, the field controls the size of the return type and the argc parameter used by the native main function, which is called from libc. We don't use libc, so the value of this field doesn't matter to us (but 32 is the right choice for most C calling conventions).


[Feature] Support JDK 11 compiling

Purpose of this pull request
close #1552
Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in you PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

@wuchunfu Now it's ready to review, I test on my laptop, it can build success with jdk11 and submit to Flink cluster success.

@wuchunfu Now it's ready to review, I test on my laptop, it can build success with jdk11 and submit to Flink cluster success.

We should generate two version of release in dist, Java 8 and Java 11.

I think maybe we only keep the current setting is Ok, the release of java 8 can execute successful on java 11.
Is there anything I haven't considerate?

I think maybe we only keep the current setting is Ok, the release of java 8 can execute successful on java 11. Is there anything I haven't considerate?

In Java specification, lower version code alway can run on higher version vm. The different for compile two version is higher version Java byte code have more optimizations, or new instruction.

I think maybe we only keep the current setting is Ok, the release of java 8 can execute successful on java 11. Is there anything I haven't considerate?

In Java specification, lower version code alway can run on higher version vm. The different for compile two version is higher version Java byte code have more optimizations, or new instruction.

Yes, but I think we don't need to provide release binding with different jdk, if user want to use jdk11 to build they can build from the source by themselves, other projects seem not provide different jdk release.

I think maybe we only keep the current setting is Ok, the release of java 8 can execute successful on java 11. Is there anything I haven't considerate?

In Java specification, lower version code alway can run on higher version vm. The different for compile two version is higher version Java byte code have more optimizations, or new instruction.

Yes, but I think we don't need to provide release binding with different jdk, if user want to use jdk11 to build they can build from the source by themselves, other projects seem not provide different jdk release.

You are right, most project didn't to that. It's a suggestion, maybe we can do this in the future

It is best to add the corresponding CI check for this

SkyWalking is a good example. https://github.com/apache/skywalking/

It is best to add the corresponding CI check for this

Thanks for your suggestion, I added the CI with jdk11.

Well done. good to see you finish this job, finally, let's explain this in the documentation.

I added some information in build.md, please review.

Hi, did you test the spark-example?


Set of constraints raises Error

I am using the python optimal control library to optimise the trajectory of a 2D rocket. Please find attached a minimum reproducible sample code of the optimisation process of the problem. Whenever I am trying to set constraints for only some of the states, I get the error described after the minimum reproducible example. Is there an appropriate way to define multiple separate constraints passed in the "constraints= [..., ..., ...]" argument of the solve.ocp() function? Also, instead of using range -np.inf to np.inf for state parameters that I do not want to bound, is there a value that makes the code ignore the specific state parameter constraints?
T_max_Single = 7607000/9

g = 9.81
m = 114239.00
k = 18.74
I = 16071705.59

import numpy as np
import math
import control as ct
import control.optimal as opt
import matplotlib.pyplot as plt
import logging
import time
import os
plt.style.use("default")
from IPython.display import display
from colorama import *
import sympy as s
from scipy.integrate import odeint

#Definition of the states
def rocket_update(t, x, u, params):

    xpos = x[0]
    U = x[1]
    z = x[2]
    W = x[3]
    θ = x[4]
    q = x[5]

    T = u[0]
    a = u[1]

    # Return the derivative of the state
    dydt = np.array([U,
            T*np.cos(θ-a)/m,
            W,
            T*np.sin(θ-a)/m-g,
            q,
            T*k*np.sin(a)/I])

    return(dydt)

def rocket_output(t, x, u, params):
    return x                            # return (full state)

Tf = 8

# Define the rocket movement dynamics as an input/output system
rocket = ct.NonlinearIOSystem(
    rocket_update, rocket_output, states=6, name='rocket',
    inputs=("T", "α"), outputs=("x", "U", "z", "W", "θ", "q"))

# Define the time horizon (and spacing) for the optimization
horizon = np.linspace(0, Tf, Tf, endpoint=True)                                        #############IMPORTANT

# Provide an intial guess (will be extended to entire horizon)
bend_left = [T_max_Single, 0.01]          # slight left veer                     #############IMPORTANT

# Optimal Control Problem
Initial_x = 0 #m
Final_x =  5 #m

Initial_z =  0 #m
Final_z = 200 #m

Initial_θ = np.pi/2 #m
Final_θ = np.pi/3 #m

Final_Thrust = T_max_Single

x0 = [Initial_x, 0, Initial_z, 0, Initial_θ, 0]; u0 = [bend_left[0], bend_left[1]]
xf = [Final_x, 0, Final_z, 0, Final_θ, 0]; uf = [Final_Thrust, 0]

#T_max_Single
Min_T = 1 * T_max_Single
Max_T = 9 * T_max_Single
a_min = -20* np.pi/180
a_max = 20* np.pi/180

# Approach 3: terminal constraints
#
# We can also remove the cost function on the state and replace it
# with a terminal *constraint* on the state.  If a solution is found,
# it guarantees we get to exactly the final state.
#
print("Initialisation of optimisation")
# print("Checkpoint_1")

# Input cost and terminal constraints
R = np.diag([0, 0])                 # minimize applied inputs
cost3 = opt.quadratic_cost(rocket, np.zeros((6,6)), R, u0=uf)

con1 = [ opt.input_range_constraint(rocket, [Min_T, a_min], [Max_T, a_max]) ]

terminal = [ opt.state_range_constraint(rocket, [Final_x, -np.inf, Final_z, -np.inf, -np.inf, -np.inf],
                                                [Final_x, np.inf, Final_z, np.inf, np.inf, np.inf]) ]

# Reset logging to its default values
logging.basicConfig(
    level=logging.DEBUG, filename="./steering-terminal_constraint.log",
    filemode='w', force=True)

# Compute the optimal control
start_time = time.process_time()
result3 = opt.solve_ocp(
    rocket, horizon, x0, cost3, con1,
    terminal_constraints=terminal, initial_guess=bend_left, log=False, method="trust-constr",
    options={'eps': 0.01})

print("* Total time = %5g seconds\n" % (time.process_time() - start_time))

Error:
/opt/anaconda3/lib/python3.8/site-packages/scipy/optimize/_constraints.py:386: OptimizeWarning: At least one constraint is unbounded above and below. Such constraints are ignored.
  warn("At least one constraint is unbounded above and below. Such "
/opt/anaconda3/lib/python3.8/site-packages/scipy/optimize/_constraints.py:432: OptimizeWarning: Equality and inequality constraints are specified in the same element of the constraint list. For efficient use with this method, equality and inequality constraints should be specified in separate elements of the constraint list.
  warn("Equality and inequality constraints are specified in the same "

A couple of issues that might be relevant:

You are using input_range_constraints to constrain some of the inputs and not others.  Depending on the optimizer, this might now work (this is the first warning you are getting).  You may need to use input_poly_constraints to just constrain the inputs that you care about.
You are using the method keyword in solve_ocp, but there is no such keyword.  You want to use minimize_method (and minimize_options).  This one is tricky because there is no warning (I found it because I have put in a warning in a PR that I am working on).

Thank you very much. The second comment described a keyword issue in my uploaded code, which should be fixed.
Regarding your first comment, is there an example where the constraint structures are used in practice?

Thank you very much! I will be closing the issue now. In case there is any example of use of these constraints in similar examples, I will be delighted to learn about it.

I am reopening this issue since I have now improved my  opt.solve_ocp() command and wish to fully comply with the documentation of the control library which is otherwise producing results very reliably. As described above, I get the same error messages about the constraints, but the "SLSQP" solver solves correctly. I am using SLSQP solver since my constraints are linear.
This is the part of the code that has changed:
con1 = [ opt.input_range_constraint(rocket, [Min_T, a_min], [Max_T, a_max]) ]

terminal = [ opt.state_range_constraint(rocket, [Final_x, -np.inf, Final_z, -np.inf, -np.inf, -np.inf],
                                                                                [Final_x, np.inf, Final_z, np.inf, np.inf, np.inf]) ]
result = opt.solve_ocp(
    rocket, horizon, x0, cost, con1, terminal_constraints=terminal,
    initial_guess=bend_left, log=False, minimize_method="SLSQP",
    minimize_options={'ftol': 0.000001, 'eps': np.finfo(float).eps, "maxiter": 500, "disp":True})

And this is the error message:
/opt/anaconda3/lib/python3.8/site-packages/scipy/optimize/_constraints.py:386: OptimizeWarning: At least one constraint is unbounded above and below. Such constraints are ignored.
  warn("At least one constraint is unbounded above and below. Such "
/opt/anaconda3/lib/python3.8/site-packages/scipy/optimize/_constraints.py:432: OptimizeWarning: Equality and inequality constraints are specified in the same element of the constraint list. For efficient use with this method, equality and inequality constraints should be specified in separate elements of the constraint list.
  warn("Equality and inequality constraints are specified in the same "

How can I correctly define multiple constraints on inputs only and then on states only, in the form: input_constraint_1, input_constraint_2, ... input_constraint_n  ,  state_constraint_1, state_constraint_2, ..., state_constraint_n, and then pass them into the opt.solve_ocp().
I am attempting to promote this excellent solver in my thesis, that is the reason for my need to fully comply with the "grammar" structure of the library.
Thank you for your time.

The following should work
# Reformulation
A = np.array([
    [ 1, 0,  0, 0, 0, 0],
    [-1, 0,  0, 0, 0, 0],
    [ 0, 0,  1, 0, 0, 0],
    [ 0, 0, -1, 0, 0, 0],
])
b = np.array([Final_x, -Final_x, Final_z, -Final_z])
term_con2 = opt.state_poly_constraint(rocket, A, b)

result2 = opt.solve_ocp(
    rocket, horizon, x0, cost3, con1, terminal_constraints=term_con2,
    initial_guess=bend_left, log=False, minimize_method="SLSQP",
    return_x = True,
    minimize_options={
        'ftol': 0.000001, 'eps': np.finfo(float).eps,
        "maxiter": 500, "disp":True})
print("* Final state:", result2.states[:, -1])

The output that I get (using a slightly newer devleopment version of the code, so some details may be different) is:
Optimization terminated successfully    (Exit mode 0)
            Current function value: 0.0
            Iterations: 76
            Function evaluations: 1628
            Gradient evaluations: 76
Summary statistics:
* Cost function calls: 1628
* Constraint calls: 1722
* System simulations: 2937
* Final cost: 0.0
* Final state: [ 5.00000044e+00  2.20695572e+01  2.00000000e+02  2.54755631e+01
  5.57648576e-01 -1.04469522e-01]

I think this addresses the issue.  Re-open is not.


Signals only connect to root

Godot version
4.0.dev 8cddd3b
System information
Windows 10
Issue description
When connecting signals true the editor.
they always connect to the root script not the selected script.
Steps to reproduce
Try connecting somewhere else
Minimal reproduction project
mrp signal not connecting.zip

Looks fixed in dcf2a62


Add well-known aliases -p/-o for -pid/-output

These should feel more familiar for anyone coming over from perf.

Didn't we already support that? I use -p all the time. Or are you just doing this to add it to the help text?

It works right now by semi-accident, because we (currently) have no other flag starting with o or p. This way we can both have it in the help text + ensure it remains functional in the future.

I have no problems with this change, but it definitely doesn't work by accident. It was an explicit constraint I was optimizing for when I restructured magic-trace's CLI.


rafthttp: fix wrong return in pipeline.handle

pipeline.handle is a long-living one, and should continue to receive
next message to send out when current message fails to send. So it
should continue instead of return here.
follow from #3737

lgtm

LGTM

LGTM


How to load multiple models for planing and control them independently？

In this sandcastle demo，https://sandcastle.cesium.com/?src=3D Tiles Clipping Planes.html  ， I load multiple 3dtiles models in a scene and add a plane entity to each model，When I move one of the plane entities, the others will move up and down，The parameter printed in the callback function of callbackproperty is always the plane of the last model，How can I control it separately？

Hi @Makabaka-goodnight, you will likely need to maintain separate targetY values for each plane.
Cesium is a big project, so we use GitHub for feature requests and bug tracking exclusively. I would ask that you take this to the Cesium Forum, where there are members of the community and developers from the team who can help, to continue troubleshooting if needed. Thanks!


Make ngrok tunneling optional when deploying core

Currently ngrok sidecars are deployed in webhook pods for the sources, so that one can connect a source when running core locally, in a private or local network.
However, when core is deployed in a public network, then the ngrok tunnelling is not needed as the ingestion webhooks for the sources can be configured directly on the public interfaces.
We need to make the ngrok deployment optional inside the helm charts.

Issue resolved.

Issue resolved.


Fixed some Swift overlay compilation problems on Windows

This fixes some of the problems that prevent us from successfully compiling the Swift overlay on Windows. I've separated this out from a larger fix because this should be pretty much the uncontroversial part. Anyway, we simply treat Windows the same as Linux and Android which makes this part of the code compile.
There are additional (and potentially controversial) fixes needed to get the whole overlay to compile on Windows. Please see the Swift forum topic here for more info.
Specifically, @MadCoder : what would be the preferred solution to make LLP64 and LP64 platforms happy? E.g. one proposed solution is to replace uses of long, etc with size_t. E.g. change
dispatch_semaphore_t  dispatch_semaphore_create(long value)
to
dispatch_semaphore_t  dispatch_semaphore_create(ssize_t value)
Also please see this PR over on the compiler side which fixes another problem with the Swift overlay.

cc @MadCoder @compnerd

@dplanitzer seems that there are some conflicts, would you mind rebasing?

(Closing since it is out of date, #413 has an updated patch)


Fix/reward stakereregistration order by

Context
Closes #382, and bumps to the released version of<EMAIL_ADDRESS>

$ yarn workspaces run test

> @cardano-graphql/api-cardano-db-hasura
$ yarn build && NODE_ENV=test jest -c ./test/jest.config.js query
$ yarn codegen && tsc -b ./src
$ graphql-codegen
  ✔ Parse configuration
  ✔ Generate outputs
 PASS  test/genesis.query.test.ts
 PASS  test/cardano.query.test.ts
 PASS  test/stakeRegistrations.query.test.ts
 PASS  test/stakeDeregistrations.query.test.ts
 PASS  test/withdrawals.query.test.ts
 PASS  test/transactions.query.test.ts
 PASS  test/blocks.query.test.ts
 PASS  test/epochs.query.test.ts
 PASS  test/delegations.query.test.ts
 PASS  test/rewards.query.test.ts
 PASS  test/activeStake.query.test.ts (6.578 s)
 PASS  test/stakePool.query.test.ts (6.654 s)
 PASS  test/utxos.query.test.ts (18.797 s)

Test Suites: 13 passed, 13 total
Tests:       42 passed, 42 total
Snapshots:   16 passed, 16 total
Time:        19.738 s
Ran all test suites matching /query/i.

> @cardano-graphql/cli
$ NODE_ENV=test jest -c ./test/jest.config.js cli.test.ts
 PASS  test/cli.test.ts (14.065 s)
  CLI Test
    ✓ Shows the program help if no arguments are passed (348 ms)
    system-info command
      ✓ Logs an object useful during issue reporting (257 ms)
    docker command
      ✓ Shows the program help if no arguments are passed (466 ms)
      init
        ✓ writes a config file to the appropriate platform-specific path, scoped by command, copies a docker compose file to use as boilerplate, and handles secret generation (547 ms)
        ✓ can be used in automated processes using command arguments (526 ms)

Test Suites: 1 passed, 1 total
Tests:       5 passed, 5 total
Snapshots:   3 passed, 3 total
Time:        14.546 s
Ran all test suites matching /cli.test.ts/i.

 > @cardano-graphql/client-ts
$ shx echo No tests in this package
No tests in this package

> @cardano-graphql/server
$ graphql-codegen && yarn build && NODE_ENV=test jest -c ./test/jest.config.js
  ✔ Parse configuration
  ✔ Generate outputs
$ tsc -b ./src
npx: installed 73 in 8.442s
  console.log
    GraphQL HTTP server at http://<IP_ADDRESS>:3302/ started

      at Server.<anonymous> (../src/Server.ts:91:13)

 PASS  test/Server.test.ts (10.092 s)
  Server
    ✓ can be configured to listen on a specified host and port (220 ms)
    Server - Internals
      Allowing specific queries
        Booting the server without providing an allow-list
          ✓ returns data for all valid queries (12 ms)
        Providing an allow-list produced by persistgraphql, intended to limit the API for specific application requirements
          ✓ Accepts allowed queries (12 ms)
          ✓ Returns a forbidden error and 403 HTTP response error if a valid but disallowed operation is sent (14 ms)
      configuring introspection
        ✓ stops the schema being introspected (38 ms)
        ✓ allows the schema to be introspected (18 ms)
        ✓ cannot be used with the allow-list feature enabled
      configuring metrics
        ✓ requires tracing to be enabled (6 ms)

Test Suites: 1 passed, 1 total
Tests:       8 passed, 8 total
Snapshots:   0 total
Time:        10.425 s
Ran all test suites.
Done in 54.78s.


add local sync router

add local sync router

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@3594ccb). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff             @@
##             develop     #121   +/-   ##
==========================================
  Coverage           ?   34.17%
==========================================
  Files              ?      148
  Lines              ?    26080
  Branches           ?        0
==========================================
  Hits               ?     8914
  Misses             ?    17166
  Partials           ?        0

Impacted Files
Coverage Δ

libproto/src/router.rs
76% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3594ccb...6e71390. Read the comment docs.


Remove Bootstrap?

I think with the dropdowns being used from bootstrap we might need to keep this for now.
Currently being used for the product dropdown and we'll probably be using it for the indicators and series dropdowns as well

I think with the dropdowns being used from bootstrap we might need to keep this for now.

Agreed :)


why FinalMLP has code but could not find the paper and aaai 2023 has been finished？

It will be available later.

@kongshuchen  Please find the paper at https://arxiv.org/abs/2304.00902


Add Brouwer (2019) dataset

Adds and processes Brouwer dataset. The OSF repo provides 2 additional csv files: one with retrieved DOIs and a deduplicated version. These were not used because we are still working on our own DOI retrieval tool and will deduplicate on DOI afterwards.

Great!


Release cassandra salesforce

New feature for ADF copy
Feature Additions

The following linked service types have been added:

OnPremisesCassandraLinkedService, SalesforceLinkedService

The following dataset types have been added:

OnPremisesCassandraTableDataset

The following copy source types have been added:

CassandraSource

Hi @peshen, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@peshen If you are internal to Microsoft, please follow the instructions here for joinging the Azur eorg:  http://aka.ms/azuregithub

@azuresdkci test this please

@peshen no tests?

@azuresdkci add to whitelist

@peshen we cannot even look at this PR until the CLA issue is resolved.  Please respond on thsi PR, or we will close it today.

As Mark mentioned, please add object samples in azure-sdk-for-net/src/ResourceManagement/DataFactory/DataFactory.Tests/Framework/JsonSamples/ and resend the pull request.

Hi mark, I have done http://aka.ms/azuregithub before and have successfully complete a pull request. Now what's wrong with my account?

@markcowl

@peshen please add samples.tests per @jackmagic313 's comment.

@markcowl I am not sure what "Build finished. No test results found." mean. Even I add some test, there still will be this error.

@peshen you have merge conflicts, that's why no tests ran. Also per the previous comments, you must add a test for these features.

@bgold09 But it shows build finished. Why build can finished with merge conflict?

@markcowl  Looks good, finally..

@markcowl can we merge?


fix(avoidance): fix unexpected behavior in yield scenario

Description
In current logic, only when the front (nearest) target object should be avoid and the avoidance path is unsafe, the module executes YIELD maneuver. But, it should execute YIELD maneuver in following scenarios, too.

Ego doesn't have to avoid the front object (passable without avoidance path).
Ego has to avoid the behind object.
Avoidance path is unsafe.

I found two bugs in the avoidance module:

The module never execute YILED maneuver if the front object is NOT avoid_require = true.
The module never cancel approved avoidance path if the front object is NOT avoid_require = true.

:arrow_down: Ego collides with NPC because of above bugs.
https://user-images.githubusercontent.com/44889564/223875419-f575247a-d020-40aa-843b-98c1dfb2d974.mp4

Diff1

The module never execute YILED maneuver if the front object is NOT avoid_require = true.

Search nearest object that should be avoid.
  for (const auto & o : data.target_objects) {
    if (o.avoid_required) {
      data.avoid_required = true;
      data.stop_target_object = o;
    }
  }

Diff2

The module never cancel approved avoidance path if the front object is NOT avoid_require = true.

Transit yield maneuver to cancel approved when the front object should be avoided.
  if (!data.safe && registered) {
    data.yield_required = true;
    data.candidate_path = toShiftedPath(data.reference_path);
    RCLCPP_WARN_THROTTLE(
      getLogger(), *clock_, 5000,
      "found safe avoidance path, but it is not safe. canceling avoidance path...");
  }

Expected behavior

Execute YIELD manauver even if the front object is NOT avoid_require = true.
Keep enough distance in stopping behavior.

https://user-images.githubusercontent.com/44889564/223874980-660b1dac-f4cb-4e26-91f5-e519b62ed1b8.mp4

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[TIER IV INTERNAL LINK] 352/362
NOTE: UC-A-04-00306-, UC-A-04-00307- is out of scope.


Fix dev services on podman, plus tesing enhancements

Dev services now;

work correctly with podman and cgroups2
extracts the dev service images up to application.properties to allow easier syncing of image versions
removes hard-coded dev service images
introduces horreum.dev-services.keycloak.container-port config to allow for writing tests against a known keycloak port

Merged, and back-ported.
Thanks for your contribution !


Implement database schema

Create required schema in Magma database

As part of this task, lets initiate a discussion with the Community regarding the pure schema design within Magna (no exact table layouts yet)

karthik subraveti  30/06/2021
If it is implemented as storing request/responses, it looks fine. I would ideally prefer CBSDs to be stored instead. Also this doesn't seem entirely consistent with how entities exist in orc8r today. @Hunter Gatewood (FB) posted this today on discussions https://github.com/magma/magma/discussions/7845. I'm not sure if the goal is to completely align these services with orc8r today.


dependencies are broken in 1.7.1

I get errors with just simple
import coursier.maven.MavenRepository

with 1.7.1, it simply does not recognize coursier!

https://github.com/lihaoyi/Ammonite/issues/1003


update college logic

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

44 of 45 (97.78%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 80.083%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sis_provisioner/utils.py
16
17
94.12%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
768

Relevant Lines:
959

💛  - Coveralls


Some metrics have been implemented

Update the repo to show the metrics that have been implemented.

🚀 🍰

:shipit:


Can anchore detect JDK or JRE level vulnerabilities?

Is this a request for help?:
Yes, Need information on Anchore's ability to find vulnerabilities on a specific JDK or JRE being installed in an image.
Also consider the fact that JDK/JRE installation within the image is just through unpacking the zip archive to a particular folder in the container.
@zhill Appreciate your feedback on this.
Thanks.

Is this a BUG REPORT or a FEATURE REQUEST? (choose one):

Version of Anchore Engine and Anchore CLI if applicable:
What happened:
What did you expect to happen:

Any relevant log output from /var/log/anchore:
What docker images are you using:
How to reproduce the issue:
Anything else we need to know:

Hi Folks, Any update on this if anchore has native support to track vulnerabilities at JDK/JRE level?
This is really important for us to detect security issues at JDK/JRE level as our applications (https://wso2.com) are heavily dependent on java runtime as a 3rd party dependency.
Thanks.

@DilanUA this would fall under the "binary" support area since you're indicating it is installed outside of a package manager. We currently do not specifically look for java binaries in that feature, but could add support for detecting them and their versions. Are javac and java as the binaries that would adequately represent the JDK and JREs?


Use Amazon API version 2 for RDS

This allows the use of "storage_encrypted: true" and other v2 API
options.

Not sure why those tests are complaining about credentials. It works fine here...

@philbrookes We enabled integration tests on Travis but it uses encrypted Travis env variables, and these are only ran on branches in the original org (IE, chef).
I need to add something to the README

So the encrypted Travis environment variables is why my build is failing? Because the patch has been working fine here for multiple people...

What else is needed to make this land so I don't have to patch my ChefDK? Thanks.


added instuctions for installation with gofish

What this PR does / why we need it: To Fix issue 2624
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2624
Special notes for your reviewer: Tested installing on MAC and Windows
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

/approve
/lgtm
@bacongobbler just as a sanity check!

Just following up here: https://github.com/fishworks/fish-food/pull/40


Error 405 (Method Not Allowed)

Hey again!
I managed to run Circular and sign in with Twitter. Now I have trouble making posts. All in-app actions I make return an Error 405, method not allowed from Twitter. The links that "go off" are
api/settings
api/times and
api/posts
I am using nginx.
Thank you in advance.
PS In which folder am I supposed to create the 'uploads' folder?
Update: I tried placing this
To allow POST on static pages
error_page  405     =200 $uri;
In my configuration. I wouldn't receive any errors on the console but it still wouldn't post.

v2 is going to be a complete backend rewrite using a different stack (Node), so closing this issue. Cheers!


New Matchers

Assertion for TextInputLayout
Create assertions to interact with TextInputLayout
Type of Change

[ ] Bug fix
[X] New Feature
[ ] Improvement
[ ] Other?

Tests
Added 3 tests to validate new feature

Hey @AlexSoaresDeSiqueira how are you doing?
Thank you for your contribution on the library! 🎉
Can you please tell me more about why are you adding this new feature?
It will be nice for all users to know how to use it and why we can't achieve the same result with the current methods.
Cheers! 👍

Of course, I just update the README and the comment of PR right now


Zaliemss

Describe the analysis solution you'd like to see
A clear and concise description of what you want to happen.
Desarrollo
Additional context
Add any other context or screenshots about the feature request here.

Gdfccgxxxxjl FBI protection program b****


Add optional arguments to interface, to enhance compatibility

In version 6 all methods in Endroid\QrCode\Builder\Builder were refactored towards arguments, either in the constructor or in the build method. To allow the interface to be compatible, this MR adds the arguments to the build method in the interface.

Forgot that one, thank you!