AAPT Issues (?) with Samsung framework-res

Hello there, i'm trying to theme my Samsung Framework-res.apk, but one magical glitch stopped me and led me dig for it. I'll attach the error that apktool gives me, it seems to be an AAPT issue on some PNGs but this is not the main issue since it can be manually fixed changing their name - (no more errors are thrown after those manual renaming). Basically, changing the windowBackground color to black, made me noticing that somehow a red glitch on WiFi texts was magically appearing.
Album@Imgur - in order to keep this bug report clean and small.
My first move, in order to try fixing the issue,  has been to set EVERYTHING from SecSettings.apk and framework-res.apk into transparent (#00000000) using regular expressions to match every colors and item lines (found in all their XML files) placing (at)android:color/transparent, but yet some wifi labels were still there.
AAPT issues perhaps?
Thanks in advance, cheers.
Information

Apktool Version (2.1.1) -
Operating System (Windows) -
APK From? (ROM) -

Stacktrace/Logcat
Decompilation:
I: Using Apktool 2.1.1 on framework-res.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...

Compilation
I: Using Apktool 2.1.1
W: Could not find sources
I: Checking whether resources has changed...
I: Building resources...
W: C:\Users\Jertlok\Desktop\apkbench\framework-res\res\drawable-sw360dp-xxxhdpi-v13\ic_knox_badge.PNG: error: File is case-insensitive equivalent to: C:\Users\Jertlok\Desktop\apkbench\framework-res\res\drawable-hdpi-v4\ic_knox_badge.png
Exception in thread "main" brut.androlib.AndrolibException: brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\Jertlok\AppData\Local\Temp\brut_util_Jar_1442071662568735255.tmp, p, --forced-package-id, 1, --min-sdk-version, 23, --target-sdk-version, 23, --version-code, 23, --version-name, 6.0.1, -F, C:\Users\Jertlok\AppData\Local\Temp\APKTOOL2743732649485842444.tmp, -x, -0, arsc, -0, PNG, -0, arsc, -S, C:\Users\Jertlok\Desktop\apkbench\framework-res\res, -M, C:\Users\Jertlok\Desktop\apkbench\framework-res\AndroidManifest.xml]
        at brut.androlib.Androlib.buildResourcesFull(Androlib.java:437)
        at brut.androlib.Androlib.buildResources(Androlib.java:371)
        at brut.androlib.Androlib.build(Androlib.java:281)
        at brut.androlib.Androlib.build(Androlib.java:254)
        at brut.apktool.Main.cmdBuild(Main.java:224)
        at brut.apktool.Main.main(Main.java:84)
Caused by: brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\Jertlok\AppData\Local\Temp\brut_util_Jar_1442071662568735255.tmp, p, --forced-package-id, 1, --min-sdk-version, 23, --target-sdk-version, 23, --version-code, 23, --version-name, 6.0.1, -F, C:\Users\Jertlok\AppData\Local\Temp\APKTOOL2743732649485842444.tmp, -x, -0, arsc, -0, PNG, -0, arsc, -S, C:\Users\Jertlok\Desktop\apkbench\framework-res\res, -M, C:\Users\Jertlok\Desktop\apkbench\framework-res\AndroidManifest.xml]
        at brut.androlib.res.AndrolibResources.aaptPackage(AndrolibResources.java:436)
        at brut.androlib.Androlib.buildResourcesFull(Androlib.java:423)
        ... 5 more
Caused by: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\Jertlok\AppData\Local\Temp\brut_util_Jar_1442071662568735255.tmp, p, --forced-package-id, 1, --min-sdk-version, 23, --target-sdk-version, 23, --version-code, 23, --version-name, 6.0.1, -F, C:\Users\Jertlok\AppData\Local\Temp\APKTOOL2743732649485842444.tmp, -x, -0, arsc, -0, PNG, -0, arsc, -S, C:\Users\Jertlok\Desktop\apkbench\framework-res\res, -M, C:\Users\Jertlok\Desktop\apkbench\framework-res\AndroidManifest.xml]
        at brut.util.OS.exec(OS.java:95)
        at brut.androlib.res.AndrolibResources.aaptPackage(AndrolibResources.java:430)
        ... 6 more

Steps to Reproduce

apktool  d framework-res.apk
apktool b framework-res.apk

Frameworks
framework-res.apk from Samsung Galaxy Note 4 MM Stock ROM
framework-res.zip@GDrive - uploaded on Google Drive due to its size
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
Yes, and it gives me some errors related to PNGs during the re-compilation.
If you are trying to install a modified apk, did you resign it?
I'm not installing the application via a normal installation procedure because it's a framework-res.apk (System).
Are you using the latest apktool version?
Yes, i'm using the version downloadable from here ApkTool Download Link.

Similar to https://github.com/iBotPeaches/Apktool/issues/1026
But let's see what you think about the second issue ;)

Fixed the PNG issue. Still not sure what I should be looking at in terms of where the problem may be at. Might need to refresh my aapt knowledge especially in regards to how it handles colors.

I've seen your new commit, pretty simple workaround!
Thank you very much!
Maybe the situation will change with the hypotetical new AAPT.

Hello.
No need to fix anything. Just rename your xxx.PNG to xxx.png.
regards

Yeah mate, thanks for your reply but i stated it too inside my bug report.
Though iBotPeaches came with a simple workaround ;)

ok sorry,i dont saw it.

Sorry for delay. 2.2.0 introduces this commit - https://github.com/iBotPeaches/Apktool/commit/a684bae43ae51859a3bd933dc0d52c3186eb8abf which properly handles @empty references. I believe this was the cause to the above errors if you could give it another shot.

Hello, iBotPeaches, unfortunately i switched to a Nexus 6P some days ago but i'm still inside plenty of Note 4 communities, i'll ask them to test this for you.

Hello, iBotPeaches,  Sorry to say but this issue still appears while recompiling my framework-res file . i am using latest framework.jar file patched by you..but still i am getting same issue
"
framework-res\res\drawable-sw360dp-xxxhdpi-v13\ic_knox_badge.PNG: error: File is case-insensitive equivalent to:"
here is my framework-res file:  https://drive.google.com/open?id=0B5yEFQJPxvK6ZGMtNUdRXzVhOEE
any workaround for this?

@rakeshraimca Did you decode it with 2.2.0 as well? That warning you posted goes against patches that directly went into 2.2.0.

I am using 2.1.1 version apktool..i decoded with that version

@rakeshraimca That is old, use 2.2.0 - https://bitbucket.org/iBotPeaches/apktool/downloads/apktool_2.2.0.jar

let me try with latest 2.2 ...will update here shortly

Yes its working now..sorry my bad..

Okay, so I am under belief this has since been fixed. Original OP couldn't test, but someone with similar issue after using the 2.2.0 binary confirmed the problem was resolved.
This should have been in 2.2.0 patch notes, but I forgot to add changelog entry for this. Closing this now. If this appears to be broken, just leave another comment.

same problem in apktool 2.4.1
I: Using Apktool 2.4.1 I: Checking whether sources has changed... I: Checking whether resources has changed... I: Building resources... W: D:\Black Box\BackUP\DS\Android Image Kitchen\New folder\Advanced+ApkTool+-+Supports+Oreo\3-Out\AsusSettings.apk\res\drawable-hdpi\asus_navigationbar_pic_1_zenuI_five.png: error: File is case-insensitive equivalent to: D:\Black Box\BackUP\DS\Android Image Kitchen\New folder\Advanced+ApkTool+-+Supports+Oreo\3-Out\AsusSettings.apk\res\drawable-mdpi\asus_navigationbar_pic_1_zenui_five.png brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\SUTANK~1\AppData\Local\Temp\brut_util_Jar_3043174590468067550.tmp, p, --forced-package-id, 127, --min-sdk-version, 26, --target-sdk-version, 26, --version-code, 26, --version-name, 8.0.0, --no-version-vectors, -F, C:\Users\SUTANK~1\AppData\Local\Temp\APKTOOL2330504736862354369.tmp, -e, C:\Users\SUTANK~1\AppData\Local\Temp\APKTOOL8521152726330176485.tmp, -0, arsc, -I, C:\Users\Sutan Karim\AppData\Local\apktool\framework\1.apk, -S, D:\Black Box\BackUP\DS\Android Image Kitchen\New folder\Advanced+ApkTool+-+Supports+Oreo\3-Out\AsusSettings.apk\res, -M, D:\Black Box\BackUP\DS\Android Image Kitchen\New folder\Advanced+ApkTool+-+Supports+Oreo\3-Out\AsusSettings.apk\AndroidManifest.xml]


Not able to install using npm or yarn

After creating an app with create-vite I am not able to install this package by either yarn or npm (I've updated to the latest npm and yarn)
This is the error I am getting:
error myPath/node_modules/vite-express: Command failed. Exit code: 2 Command: cd create-vite-express && yarn install Arguments: Directory: myPath/node_modules/vite-express Output: /bin/sh: 1: cd: can't cd to create-vite-express
Could you please verify if this is an issue?
I have tried creating projects with create-vite templates with vue for js and ts

Getting the same error

I verified it and there is a problem with internal postinstall script in vite-express package.json. Im quite supprised that it is run even when installed as a dependency. As far as I'm concerned you can ignore this error as it the script is run after the install and does not affect the installation process, but it will occur every time you run yarn add or npm install. A better fix would be to delete the postinstall script in vite-express package.json but it is not worth the hussle i guess as i'll post the fix as quick as possible. Thanks a lot for letting me know about the issue!

Thanks for your quick reply! As far as I see this is not just an error message that I can ignore. It affects the installation because in the end no files are changed at all.

Should be fixed in vite-express v0.3.3

Thanks a lot!


BUG: refguide-check incorrectly flags references to equations in docstrings

 python dev.py refguide-check complains when referencing equations from within a docstring with :math:numref:`EQ_LABEL` though the hyperlink gets generated correctly.   The error message is:
 (ERROR/3) Unknown interpreted text role "math:numref".::

Using such references from within .rst-files is not a problem (consult, e.g., signal.rst).

https://github.com/scipy/scipy/blob/main/tools/refguide_check.py#L339 has  a whitelist of "ok unknown items", this one should probably be added.


Support image reuse

Add support for following use case:

[ ] Add DockerImage property build. Boolean. Default true.
[ ] Use build property - trigger only if true
[ ] Add use case to examples


Modifying the AudioFeeder to conditionally set the AudioSessionCategory

My application does a combination of playing and recording, so when the AudioFeeder was unconditionally setting the shared AudioSession category to Playback it was causing the Recording to stop working.
I added in logic to conditionally set the AudioSession category based on the current category.

Nice! Lemme test real quick and merge...


Tighten lower bound on base

Currently this package can't be compiled with pre-AMP bases (see compile failure below for GHC 7.8.4).
And as this package is only CI-tested with GHC 7.10 & GHC 8.0, it seems like the intent is rather to support only base >= 4.8.
Configuring component lib from distributed-process-extras-0.3.2...
Preprocessing library distributed-process-extras-0.3.2...
[ 1 of 14] Compiling Control.Distributed.Process.Extras.Internal.Unsafe ( src/Control/Distributed/Process/Extras/Internal/Unsafe.hs, /tmp/matrix-worker/1490789727/dist-newstyle/build/x86_64-linux/ghc-7.8.4/distributed-process-extras-0.3.2/build/Control/Distributed/Process/Extras/Internal/Unsafe.o )
[ 2 of 14] Compiling Control.Distributed.Process.Extras.Internal.Queue.PriorityQ ( src/Control/Distributed/Process/Extras/Internal/Queue/PriorityQ.hs, /tmp/matrix-worker/1490789727/dist-newstyle/build/x86_64-linux/ghc-7.8.4/distributed-process-extras-0.3.2/build/Control/Distributed/Process/Extras/Internal/Queue/PriorityQ.o )
[ 3 of 14] Compiling Control.Distributed.Process.Extras.Internal.Queue.SeqQ ( src/Control/Distributed/Process/Extras/Internal/Queue/SeqQ.hs, /tmp/matrix-worker/1490789727/dist-newstyle/build/x86_64-linux/ghc-7.8.4/distributed-process-extras-0.3.2/build/Control/Distributed/Process/Extras/Internal/Queue/SeqQ.o )
[ 4 of 14] Compiling Control.Distributed.Process.Extras.Internal.Containers.MultiMap ( src/Control/Distributed/Process/Extras/Internal/Containers/MultiMap.hs, /tmp/matrix-worker/1490789727/dist-newstyle/build/x86_64-linux/ghc-7.8.4/distributed-process-extras-0.3.2/build/Control/Distributed/Process/Extras/Internal/Containers/MultiMap.o )

src/Control/Distributed/Process/Extras/Internal/Containers/MultiMap.hs:28:1: Warning:
    The import of ‘Data.Foldable’ is redundant
      except perhaps to import instances from ‘Data.Foldable’
    To import instances alone, use: import Data.Foldable()
[ 5 of 14] Compiling Control.Concurrent.Utils ( src/Control/Concurrent/Utils.hs, /tmp/matrix-worker/1490789727/dist-newstyle/build/x86_64-linux/ghc-7.8.4/distributed-process-extras-0.3.2/build/Control/Concurrent/Utils.o )

src/Control/Concurrent/Utils.hs:32:24: Not in scope: ‘<$>’

src/Control/Concurrent/Utils.hs:32:39: Not in scope: ‘<*>’

src/Control/Concurrent/Utils.hs:32:43: Not in scope: ‘pure’

src/Control/Concurrent/Utils.hs:32:57: Not in scope: ‘<*>’

src/Control/Concurrent/Utils.hs:32:61: Not in scope: ‘pure’

src/Control/Concurrent/Utils.hs:36:18: Not in scope: ‘<$>’

src/Control/Concurrent/Utils.hs:36:32: Not in scope: ‘<*>’

src/Control/Concurrent/Utils.hs:36:36: Not in scope: ‘pure’

src/Control/Concurrent/Utils.hs:36:50: Not in scope: ‘<*>’

src/Control/Concurrent/Utils.hs:36:54: Not in scope: ‘pure’

I've also revised the meta-data for the 3 affected releases, so there's no immediate need to upload a new version just for the meta-data fix.

https://hackage.haskell.org/package/distributed-process-extras-0.3.2/revisions/
https://hackage.haskell.org/package/distributed-process-extras-0.3.1/revisions/
https://hackage.haskell.org/package/distributed-process-extras-0.3.0/revisions/


formdata for post request

formdata in the Signup and Login page.

done.
formdata does not give any console.log().


How to use pretrained UmlsBERT to get embeddings for all the UMLS terms?

I want to load the pretrained UmlsBERT model to generate vector representations/embeddings of all the medical terms in UMLS. Which library to use to load this model since it is a modified version of BERT? Also, which layer or combination of layers provides the best representation of the vectors?

Thank you for your interest in UmlsBert.
For the creation of UmlsBert, we used the pytorch and the huggingface library.
However, at the present time, in order to use UmlsBERT architecture, you will need to use the code that we provide in the Github repo.
As for the pre-trained weights of UmlsBERT we provide a link in the README where you can download them.
From our experiments,  we observed that the best input embeddings were created when we use  the standard BERT embedding (Token, Segment, Position) and the  Semantic Type Embedding that we introduce in this architecture

Hello
I want to work with UmlsBERT on huggingface. I am a beginner in this area.
https://huggingface.co/GanjinZero/UMLSBert_ENG
How can I access the embedding of for example one concept selected from UMLS, after executing this line:
model = AutoModel.from_pretrained("GanjinZero/UMLSBert_ENG")
I will be thankful if you help me with this issue.

Hello I want to work with UmlsBERT on the huggingface. there are two UmlsBert on the huggingface:
https://huggingface.co/GanjinZero/UMLSBert_ENG , and cambridgeltl/SapBERT-UMLS-2020AB-all-lang-from-XLMR
I am a beginner in this area. How can I access the embedding of, for example, one concept selected from UMLS after executing this line:
model = AutoModel.from_pretrained("GanjinZero/UMLSBert_ENG")
I will be thankful if you help me with this issue.

GanjinZero/UMLSBert_ENG refers to https://github.com/GanjinZero/CODER, it has the same name with this repo accidently.
cambridgeltl/SapBERT-UMLS-2020AB-all-lang-from-XLMR is also another model refers to SapBERT.


EC2 CreateSnapshot return type shape doesn't match service tags

As seen in https://github.com/rusoto/rusoto/issues/351 .
XML returned from a CreateSnapshot call:
<?xml version="1.0" encoding="UTF-8"?>
<CreateSnapshotResponse xmlns="http://ec2.amazonaws.com/doc/2015-10-01/">
    <requestId>fe758bf7-b2a9-43b0-a877-b4e86baa828a</requestId>
    <snapshotId>snap-75c0xxxx</snapshotId>
    <volumeId>vol-xxxxxxx</volumeId>
    <status>pending</status>
    <startTime>2016-08-17T20:10:01.000Z</startTime>
    <progress/>
    <ownerId>83918604xxxx</ownerId>
    <volumeSize>384</volumeSize>
    <encrypted>false</encrypted>
    <description>2016818</description>
</CreateSnapshotResponse>

Note the opening tag is CreateSnapshotResponse.  From the service definition:
"CreateSnapshot":{
      "name":"CreateSnapshot",
      "http":{
        "method":"POST",
        "requestUri":"/"
      },
      "input":{"shape":"CreateSnapshotRequest"},
      "output":{"shape":"Snapshot"},
      "documentation":"
Creates a snapshot of an EBS volume and stores it in Amazon S3. You can use snapshots for backups, to make copies of EBS volumes, and to save data before shutting down an instance.

When a snapshot is created, any AWS Marketplace product codes that are associated with the source volume are propagated to the snapshot.

You can take a snapshot of an attached volume that is in use. However, snapshots only capture data that has been written to your EBS volume at the time the snapshot command is issued; this may exclude any data that has been cached by any applications or the operating system. If you can pause any file systems on the volume long enough to take a snapshot, your snapshot should be complete. However, if you cannot pause all file writes to the volume, you should unmount the volume from within the instance, issue the snapshot command, and then remount the volume to ensure a consistent and complete snapshot. You may remount and use your volume while the snapshot status is pending.

To create a snapshot for EBS volumes that serve as root devices, you should stop the instance before taking the snapshot.

Snapshots that are taken from encrypted volumes are automatically encrypted. Volumes that are created from encrypted snapshots are also automatically encrypted. Your encrypted volumes and any associated snapshots always remain protected.

For more information, see Amazon Elastic Block Store and Amazon EBS Encryption in the Amazon Elastic Compute Cloud User Guide.
"
    }

Expected behavior: service definition shape matches the XML tag.

One thing to note first is shape names are not used directly in response parsing. They really are only used as reference when traversing the model of an operation/service. It is the member name or location name needs to match the name of the XML tag.
For the root tag like CreateSnapshotResponse, the tag just provides a starting point to start parsing. This tag is never directly included in the dictionary returned by botocore. This means it is not important to have reference to the name of this root tag ahead of time in the model and therefore no guarantee needs to be made on the name of the shape for the output matching the name of the root tag.
Hope this helps. Let us know if you have any more questions.

Thanks for clarifying.  We've been assuming shapes or locations are in every botocore service definition.  Since the root tag has no guarantee of being included in the service definition, we can adjust our codegen accordingly.

Cool. Glad that makes sense. Closing issue.


[ 7.1.f ] As a developer, I want refactor projects, so that the solution has adheres to the Onion Architecture pattern.

Acceptance criteria:

[ ] Chirp.Core project contains DTOs, repository interface(s)
[ ] Chirp.Infrastructure project contains repositories, db context, data model
[ ] Chirp.Web project contains razor application

Description:
References:

1.f) Onion Architecture

After group discussion and the TA response quoted below, we have decided to place the data model in Chirp.Core (domain layer). This adheres to the project structure referenced in lecture 7:

21.10.2024 13:07:
I don't know the correct answer for this, but i think you can argue for both.
Using EF-core, our data models are closly tied to our database, which is part of the infrastucture. If you use EF-core data annotations(see link), your data model even needs to import EF-core, and since we do not want any depencencies in our domain layer, it could make sense to put them in Chirp infrastucture. The other part of your application also should avoid using the Entities directly but should use a DTO instead, having our Entities in infrastucture makes it clear when we import a Entity, not a DTO.
On the other hand, you should be able to only use the "Fluent API" (see link) for EF-core and specify for example contraints in OnModelCreating. With this you could have your Entities in Chirp core, without depending on EF-core. As you said this aligns more with other definitions of the onion architecture.
No matter what it should not be the biggest change later on, so pick what you think makes sense, it should not block your progress on the project.
https://learn.microsoft.com/en-us/ef/core/modeling/

[ ] ChirpDbContext and the Migrations folder currently reside in the Core project. These should be located in the Infrastructure project.
[ ] In order to eliminate any outwards dependencies from Core, we should use the EF Fluent API instead of having Mapping attributes in our entities.
[ ] Furthermore, the Chirp.Core.Tests should be renamed to Chirp.Infrastructure.Tests, as it only contains tests of the repositories.


[FEATURE] add 'gk' exception to the 3 character highlight requirement

also i think reducing the general limit to 2 will be bad:tm: (and will require a lot of stuff to be added to the bad list)

alternatively

No never!

racist


Matrix bug?

Hi Johnt,
we are using your B-spline package in the framework of tackling parabolic differential equations.
Creating a spline matrix A using ‘collmat’ we find that the last entry (A_nn) is, just like the entire last row 0. Is this a bug? We expected  the entire row to be 0, except for the A_nn element, which should be 1. (Just like the A_00 element is 1 and the rest of the A_0-row is 0). Right now we do some ‘artificial fixing’, i.e. setting A_nn to 1 manually.
The problem is also present in the 1st order derivative.

Hi,
The bspline package defines each piecewise polynomial to have support on the half-open interval [x_k, x_{k+1}). Hence, evaluating the last basis function at the final endpoint yields 0, making the whole B-spline zero there.
As a workaround, in my own codes I've scaled the whole interval (which is to be spanned by the B-spline) by a factor of 1 + ε, where ε is some suitably small positive number. Then evaluating the last basis function at the original endpoint yields a value that is sufficiently close to 1 for practical purposes - and hence evaluating the whole B-spline there then gives sensible results.
I think it is theoretically possible to fix the issue, but doing so complicates the (currently very short and elegant) implementation of the Cox - de Boor algorithm. However, if you and John feel this is important to fix, it could be done.


chore: bdd-nh-1587228390 to 0.0.1

chore: Promote bdd-nh-1587228390 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Correction for raw affiliation CIRAD, Département BIOS – UMR AGAP, TA A-108/01, Avenue Agropolis, 34398 Montpellier Cedex 5, France

Correction needed for raw affiliation CIRAD, Département BIOS – UMR AGAP, TA A-108/01, Avenue Agropolis, 34398 Montpellier Cedex 5, France
raw_affiliation_name: CIRAD, Département BIOS – UMR AGAP, TA A-108/01, Avenue Agropolis, 34398 Montpellier Cedex 5, France
new_rors: 00txxwv34;05kpkpg04;02w4exq36
previous_rors: 00txxwv34;05kpkpg04
works_examples: W4251510106
contact: 031278a665fc26b67b39471f0d7f1145:d371fa9f873e092b38b26920e1a226a528c5 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


Split out cradle loading logic into new library

This way haskell-language-server can reuse it without having to maintain two versions of this session setup code, which was getting quite tricky to maintain. Needs #693 and #696 merged first

Some caveats of using a private lib:

It causes not deterministic build plan errors that forces you to delete the store partially or totally
Stack cradle cant handle them in a reliable way
Being a private lib, hls will not be able to use it (or am i missing something?)

@jneira just before I read your comment I found out that I forgot to add the visibility: public field to the library! I've integrated it with haskell-language-server now but you're right, it was a bit of a pain and there are definitely some drawbacks. For one, I'm not sure if this works with ghc <8.8. Is there any reason why we can't just move this into ghcide itself?

@jneira ok right off the bat haskell-language-server fails to build with stack build --stack-yaml=stack-8.6.5.yaml, stack 2.3.1 because it can't parse this bit of the cabal file:
  build-depends:
    , ghcide:ghcide-session-loader

Mmm i thought public libraries was not fully supported in cabal but they has been recently merged, so it would need cabal-3.4 (hoping not to hit more bugs). We will have to wait a while to have stack support.

@bubba what do you think about creating directly a new subpackage (ghcide-session-loader? ghcide-bios?) with the same contents as the public library?
Maybe it will no need separate the exe from the main lib in ghcide, as the subpackage would depend on the ghcide library and the ghicde executable will depend on its library and the subpackage.
It supposes more maintaining work but imo it will be more reliable.

@jneira I think a sub-package is probably overkill for just one module. With sub packages you need to be careful whenever you're making releases on hackage etc. so that you don't upload them in the wrong order. I always mess that up with haskell-lsp and haskell-lsp-types. I've moved it into just the ghcide library for now, with the one caveat being that loadSession just errors if the -fghc-lib flag is set

I think ghcide maintainers preferred to separate hie-bios from the ghcide main lib, to not leak it to daml.
Although maybe they could confirm if it is so.

@jneira ah if thats the case then, then we might not have much choice

@bubba Other alternative would be move the ghc session logic to hls and remove it from ghcide entirely, and let it be a pure lib :smile:

@bubba @jneira Can you enumerate all the options and their tradeoffs? Things to consider:

testability
minimal dependencies in the ghcide Library stanza
compatibility with tools and IDEs

Hopefully making it easy for the code owners (@digitalasset @cocreature) to pick one.

Other alternative would be move the ghc session logic to hls and remove the exe part from ghcide entirely, letting it be a pure lib smile

That breaks all tests we currently have.

I think ghcide maintainers preferred to separate hie-bios from the ghcide main lib, to not leak it to daml.
Although maybe they could confirm if it is so.

Yes, we need to be able to build ghcide (the library) without a dependency on any Haskell build tool stuff which includes hie-bios.
What could work is to just hide the session stuff and the dependency on hie-bios behind a cabal flag.

Approach
Pros
Cons

Move loadSession into lib:ghcide
Simple
ghcide needs to be independent of haskell stuff so no hie-bios: No dice

Move loadSession into sublibrary
All in the one package
Really dubious stack support

Move loadSession into new package
?
More release churn. Now have a circular dependency on exe:ghcide -> lib:ghcide-session-loader -> lib:ghcide, so exe:ghcide might also need split out into another package

Hide behind a cabal flag
?
No good way of specifying cabal flags for dependencies directly in .cabal files. Will need to use cabal.project in haskell-language-server

cabal flags have a default. Apart from DAML nobody cares about being able to disable this so the sane option is to include it by default. We could even just reuse the ghc-lib flag here. Then apart from DAML nobody has to specify the flag and it’s not really an issue that you cannot specify flags for your build-depends in your cabal file.

@cocreature I was thinking that as well, if the default was to include hie-bios/the session loader then haskell-language-server might still be able to get uploaded to hackage eventually. I'm happy to try out this option

Now have a circular dependency on exe:ghcide -> lib:ghcide-session-loader -> lib:ghcide, so exe:ghcide might also need split out into another package

I think there would not be such circularity cause one package depends on the lib of the another one, no on its executables (they are  private for dependency management purpose).
The advantage would be it works out of the box with all stack/cabal versions and the separation is cleaner (maybe too much), only one small independent component will be more reliable, in general.
That said, agree a cabal flag with the default value would be the best option. Not sure about how can it affect the ghcide executable, it will be no buildable with the session loader disabled (so maybe simply mark it as buildable: false for the chosen flag would suffice).

I think there would not be such circularity cause one package depends on the lib of the another one, no on its executables (they are private for dependency management purpose).

I didn't realise stack/cabal could handle that!
@cocreature @jneira for now I've just reused the ghc-lib flag which I was already using as a check. The ghcide executable has buildable: False when this is turned on anyway so there shouldn't be any difference

Argh this module fails to build only on windows when building with stack and ghc-8.10. Window + cabal + ghc-8.10 seems fine. Not exactly sure what's causing it

Looks like the template-haskell bit used to generate the GhcVersionChecker is the culprit. Maybe that stuff does need moved back out into a separate module


first commit for RST & REALESTATE

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

good night, what do I have to do, thanks

I have tried to make the changes without success, I do not understand how I can do them, there is a manual to see how I can do it, thanks


[OneNote] Import fails on pages with conflicts

Fails to import pages which have conflicts, I expect it should import content from the original and discard conflicts. Alternatively it could do something like git and inline all the conflicts with suitable markers.
Failed: "<page title>" because TypeError: Cannot read properties of undefined (reading 'split')

I am getting the same issue with a number of pages during import from onenote.
Appreciate if somebody can comment

I can't seem to tell which pages work versus don't work. What do you mean by conflict @GregHib

Page sync conflicts, they happen most frequently when using multiple devices although can still happen with one. When you open notebook on the desktop app pages will have a warning icon :warning: which you can click and choose between multiple versions of the same page which changes you want to keep or discard. Resolving these issues will allow the page to be imported.


Allow WORKLOAD, SCENARIO, STEP token interpolation in non-named-scenario activities

This logic is applied in NBCLIScenarioParser, but it should also be done by default for other situations where users want to emulate the pattern easily.

This is superseded by recent architectural changes, particularly the component tree and internal labeling mechanisms.


Create main form on the landing page

The main page should contain a form to:

designate a link
designate a shortened string to it

And upon submission, saving the latter to the db.

Done in 44f1bcd7e7a9539b0a8e49ad153398c0ce75d863


create kustomization overlays for prod and development

the makefiles will have options for both.
for production, for example, log verbosity will be moderate; whereas for development, logging will be at the highest verbosity level.

Or it can be a separate script, to optionally use when needed.

too many work items queued; moving this to the next version.

no need actually:
just overriding environment variables in the customization file would suffice.
as long as people know what is customizable, that is good enough.

we can also add recommendations like # log level: keep it 3 or lower for production etc.

No need. Added to documentation.
Closing this for now.


athena: stricter socket timeout when device awake

when device is awake, reduce the TCP_KEEPIDLE delay. also set a TCP_USER_TIMEOUT according to recommendation in https://blog.cloudflare.com/when-tcp-sockets-refuse-to-die/
# current websocket sockopts
SO_KEEPALIVE: 1
TCP_KEEPIDLE: 30     # change to 5 seconds when awake?
TCP_KEEPINTVL: 10
TCP_KEEPCNT: 3
TCP_USER_TIMEOUT: 0  # set to TCP_KEEPIDLE + TCP_KEEPINTVL * TCP_KEEPCNT?

https://man7.org/linux/man-pages/man7/tcp.7.html#:~:text=TCP_KEEPIDLE

I am pretty sure websockets are intended to have TCP keepalive disabled since they have a replacement mechanism ping/pong which they claim is better.
https://websockets.readthedocs.io/en/stable/topics/timeouts.html

I guess it isn't clear to me if you can have HTTP keepalive active (so the server doesn't close the connection immediately) but disable TCP keepalive.  It seems best for the websocket to decide when the connection is dead and explicitly close and open a new connection if the websocket library has this built in.

Originally the goal was to only have the modem wake up once per minute when there is no activity to minimize power draw, which would require we disable TCP keepalive or set the interval to a very high value.  At the same time, you don't want to have to wait for a minute for a navigation request to get to the device.  I like the idea of being more aggressive with re-establishing the connection when on-road since we shouldn't have to worry about power draw.  I am not sure if we should be using TCP keepalive or ping/pong requests.  I have seen multi-second round-trip latency on cellular, which probably increases the difficulty here.

https://hpbn.co/optimizing-for-mobile-networks/#eliminate-unnecessary-application-keepalives
I will double check the current socket configuration since it did look like we have TCP keepalive enabled, which might mean the modem doesn't get to idle much.


more support for bigint

I'm not sure this is the right way to do it, but I can't find another way… (we certainly don't want to create a normal array, peek at the values, then convert to typed array).
closes #1297

I think what we do instead is split the current map function into map and typedMap, where map always returns an Array, and typedMap always returns a given TypedArray. Then, in the typedMap case we compose the given accessor with Number to safely coerce rather than relying on the implicit version which errors. (We could also short-circuit the additional number coercion if the input array is already a TypedArray.)

0d2e2d3 keeps a single entry point (map). Is it enough?

a single entry point

My thinking was we can easily look for all places that are passing a TypedArray to map and change those to typedMap. That way we don’t need the type === Array test (which also isn’t strictly accurate, since you can technically subclass Array or TypedArray, so we’d have to use isTypedArray instead).

See #1305 for an exploration of typedMap vs. map.

I'll add more unit tests tomorrow and merge.

I added some more tests. 👍 Feel free to add more. I feel confident in this change.
I spent some time thinking we could bypass the coerceNumber call for the integer array types (e.g., Uint8Array) since these types have no way of representing NaN, and hence you can’t avoid mapping null to 0. But I was forgetting that the other reason we want coerceNumber is to avoid the error coercing a BigInt to a number, which was the title of this PR, so I threw the work away. 😅


SqlDatabaseRole: cannot be used for the same login on the same server

Test-ConflictingResources : A conflict was detected between resources '[xSQLServerDatabaseRole]dbrolereader (C:\temp\sqllogin.ps1::34::8::xSQLServerDatabaseRole)' and
'[xSQLServerDatabaseRole]dbrolewriter (C:\temp\sqllogin.ps1::42::14::xSQLServerDatabaseRole)' in node 'localhost'. Resources have identical key properties but there are
differences in the following non-key properties: 'Role'. Values 'db_Datareader' don't match values 'db_Datawriter'. Please update these property values so that they are
identical in both cases.
A fix would be to use a string[] for role's instead of string

I believe this is the same as issue #108. This is gonna be resolved in PR #115

Has this now been resolved as #108 looks to have been closed?


Image URLS

I have left the standard config unchanged for the image location...
image_url: '/images',
I am running a windows server and Raneto is working perfectly but I just can't get embedded images to display. MD files display perfectly.
I have created an images folder in the root as I guess this is where the images should be?

Within this folder I have placed an image called image.jpg
If I create an image in an MD file like this....
![Test](%image_url%/image.jpg)
The image is not displayed. If I check the source html on the rendered web page I can see the url is ...
<img alt="Test" src="/images/image.jpg">
I can't figure out if this is wrong with the root image folder location or an issue with Raneto locating o them?

Help much appreciated on this one.

The images folder would likely need to be created within the public folder.

I tried that but still had the same issue with the image not being displayed. If I manually browse to the image using the web URL I get a 404 from Raneto.

On 1 Sep 2015, at 22:13, Mark Moffat<EMAIL_ADDRESS>wrote:
The images folder would likely need to be created within the public folder.
—
Reply to this email directly or view it on GitHub.

Fixed. Reinstalled Node.js

@thedaftbadger - Seems like you got it fixed? If you're having more issues, please reopen this issue or create a new one and I'll give it a look.


WIP: Add force flag to bypass validation

In case users have custom charts, or there's a problem with our schema, we need a bypass for the values validation. This flag will cause the tool to still report validation errors but proceed in spite of them.

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator
e8d8df9b5d3ade8da3a524c44bd58374dc346add
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator
e8d8df9b5d3ade8da3a524c44bd58374dc346add
link
/test lint

manifest-apply_operator
e8d8df9b5d3ade8da3a524c44bd58374dc346add
link
/test manifest-apply

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Moved to https://github.com/istio/operator/pull/353 due to some bad merges being pulled in.


set up the hwcv

:white_check_mark: Build TimeHACK AppVeyor-147 completed (commit https://github.com/TimeHACKDevs/TimeHACK/commit/432924b997 by @lempamo)


Add D-Link DUB-E100 Driver 2.4.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Are there any problems with it?


Unc path

This is a hybrid of @staticshock and my work.

unit tests that cover the actual WinPath implementation
integration test – using mock-fs and some path.sep and path.resolve faking, simulate the windows environemnt.

[ ] pending minimatch fix – it doesn't have mock-friendly platform specific code

[x] PR https://github.com/isaacs/minimatch/pull/63
[ ] merge + release

[ ] feedback
[ ] re-confirm the latest refactoring still solves the original issue – it was earlier

future work:

[ ] get tests passing on windows
[ ] appveyor

@staticshock  & @isaacs I believe this is ready for review.

the faking code needs more work actually, although the final code works in windows. The test fails, investigating further.

I fixed the mocking code for the test in-question, now as I look at other tests. There appear to be other UNC related test failures beyond this one, for example. If the entire test suite is run on a share, we get many test failures.

[ ] UNC aware cwd
[ ] UNC aware root

This is pretty close!
I inadvertently optimized away your minimatch change, but then I fixed it on 2.0.7.
I am still running into a bit of a weird issue with the test, because the path-is-absolute module is rather insistent on using process.platform, and it's also used throughout the codebase a bit.  I was able to get this specific test to work, but only because isAbsolute('/baz') is the same on Windows and Posix.
I think the right approach here, though it's more lines changed, is to pass the platform as an option to Glob, and then load all the appropriate separator/absolute/etc stuff onto the glob object, so it never has to look at process.platform or path.sep or whatever.
I'm thinking something like this in the setopts function in common.js:
self.platform = opts.platform || process.platform
self.isAbsolute = isAbsolute[self.platform] || isAbsolute;
self.resolve = path[self.platform].resolve || path.resolve;
self.sep = path[self.platform].sep || path.sep;

And then, throughout glob.js and sync.js, make sure to always call the methods off of this rather than path.<whatever>() or process.platform.
This also means that, if at some point we need to change just one of these fields, or use AOP to debug those function calls, we can either make those fields configurable, or instantiate an object and just change the relevant bits.
Of course, this can lead to glob doing something weird in some cases, but it'd make it so that we can test other windows irregularities in the future more easily, with a lot less module cache tinkering.
What do you think?

What do you think?

I'm on-board with passing platform in, in-fact it was something I considered but opting out of merely to avoid a more controversial PR. So if you are +1, I'll make it so.

I'm totally ok with involved changes that improve testability, windows support, and make the code easier to follow (including fewer hacky workarounds in tests).
Of course, bigger PR size tends to make for more back and forth in the review process, but I think we're pretty aligned on what needs to happen for this.

Of course, bigger PR size tends to make for more back and forth in the review process, but I think we're pretty aligned on what needs to happen for this.

ya I'm fine with thorough back + forth, as this module had 11,577,444 downloads in the last month.

@isaacs sorry for the delay, been under the weather. Anyways, this is ready for review.
One question (and the last failing test), is path in node 0.10.x doesn't have path[platform]...

should i skip these tests in node 0.10
should I polyfil it
am i missing something more obvious

UGGHHHH that's right.
I'd say just skip that test in node <= 0.10.  The code should still work fine, and since this is really just a matter of string juggling stuff, it should be fine to run the tests in only later versions.

@isaacs whats the ideal way to detect node 10?

I'd throw something like this in there:
var skip = false
if (/^v0\.(10|[0-9])\./.test(process.version)) {
  skip = 'Does not work on Node < 0.12'
}

test('some test name', { skip: skip }, function (t) { ...

If you wanna just leave the tests failing in 0.10, that's fine, too.  I can work it out when I merge it in.  If it's passing in 0.12 and io.js, then I can take it from there :)

Ok, just reviewed.  The test looks perfect, and nothing in the code jumps out at me as problematic.
If you think this is ready to go, I can merge and release this weekend or early next week.

If you wanna just leave the tests failing in 0.10, that's fine, too. I can work it out when I merge it in. If it's passing in 0.12 and io.js, then I can take it from there :)

I'll add the skip :package:

Ok, just reviewed. The test looks perfect, and nothing in the code jumps out at me as problematic.

:+1:

If you think this is ready to go, I can merge and release this weekend or early next week.

My use-cases work correct, I tried several ways to break it and couldn't find anything. I am fairly confident. But full disclosure, I will be on vacation new week. So if you release I wont be able to deal with fall-out, it will be on you. If you wait a week, I can help out with any fall out. Your call sir.

sorry, i am unclear why the skip isn't working as expected :(

lets actually hold off, I may have noticed other scenarios...

rebased, going to fire up the old windows gaming rig after breakfast and see whats next.

Tests should now correctly run, even on old versions of node. Switching to windows now, lets see whats left on this side of things.

@isaacs i have added the appveyor configuration, is it possible for you to set up the appveyor.com side of things? I would doit, but then node-glob would end-up stefanpenner/node-glob on appveyor.
It should be as simple as singing up for the free tier, and adding this repository. As for making the tests pass on windows, I have put together a short triage list, and will work on them this afternoon.

It looks like the issue is that the WinPath stuff in the setopts function in common.js is messing with root and path in a weird way, such that glob(process.cwd()) can't return anything, because it ends up having a root setting of c: and a pattern of /path/to/cwd.
The mocking and testing stuff looks pretty good.  I think it's the right approach.
On master right now, all the tests pass on Windows.  I'd recommend rebasing, and then applying the changes one by one and making sure that tests pass at each commit.

No longer an issue in v9.


RGBGrid Example

Great stuff Jim.
Do you have an example of how to setup an RGBGridMedium? I was trying to use a billowy smoke pyro sop, but I can't get it to export the material.
I was able to use a straight volume and a cloud medium, but for a project need a wispier source.

To setup a RGBGridMedium is completely non-obvious. (I really should make some help cards for some of this stuff, or at least a walk through YouTube video.)
To use the RGBGridMedium pbrt-v4 requires 6 volume fields instead of the normal 1 for a simple density based smoke field.
The 6 fields it requires are
sigma_a.[rgb] (absorption)
sigma_s.[rgb] (scattering)
I've attached a simple example that shows how to set it up. It focuses on use Cd fields in the sim, then converting the Cd fields to sigma_s. Then depending on the look you want you can derive sigma_a in different ways. (Which is what the Switch SOP demos).
rgb_grid_example.hiplc.gz
Also, NanoVDBs are supported too. Which mean in your Houdini scene you can work with straight VDB primitives, and as long as you have nanovdb_convert (part of the OpenVDB distribution) in your path then your VDB prims will automatically be converted.
Pretty much any input pbrt-v4 supports, the converted can handle. Though as you've seen some guidance may be needed, so feel free to ask other questions (preferably as other tickets).

Thanks. That's what I'm looking for. Now to translate it over to a .hip file. Can we make an 'examples' directory in the repo and start adding a few of these there?

Yup I'll add the example hip in the previous comment as well as a few others to the repo.


add max_retries check and exception

Description
This PR addresses the issue of unclear error handling when multiple timeouts occur during data fetching. The fetch_data function has been updated to raise a clear and descriptive error message if the maximum number of retries is reached without successfully fetching the data.
Changes:

Added logic to raise a ConnectionError after exhausting retries, with detailed error messages.
Improved logging to track the retry attempts and include status code or error information.
Ensured that if the data fetch ultimately fails, a concise error message is displayed to the user.

Fixes #18
How Has This Been Tested?
To verify the changes, I simulated network timeouts and ensured the following:

The retry logic triggers appropriately.
After max_retries is reached, the error message is logged, and a ConnectionError is raised.
The function behaves as expected when data is fetched successfully.

Tested with:

[x] Timeout simulation (5 retries)
[x] Successful data fetch after retries

If your changes affect data processing, have you plotted any changes? i.e., have you done a quick sanity check?

[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation (if necessary)
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

@peterdudfield Can you review this?


On the speed of  .rec  compared with .JPEG.

Hi @JaminFong , I've noticed you convert the ImageNet dataset to MXNet RecordIO format.
Did you observe the rec format being faster than reading the raw .jpeg image in your DALI experiments?
Thanky you.

Yes, reading rec is much faster than raw .jpeg image, especially on non-ssd devices.

Cool！


doc# fix: update Protocol ABNF syntax link url

change rfc5234 link protocol to https.

Thank you for the cleanup!


Internet connection problem

Is there an existing issue for this?

[X] I have searched the existing issues

Describe your problem
In web "internal connection problem" pop up, scripts is not running
Steps to reproduce
N/A
What hardware are you using?
ESP8266
Anything else?
Maybe issue in wiring connection

Same issue. The issue apears, when i have a script with GUI or WINDOWS Button. Then the USB restarts and don't run the script.


Instrumentation for SQLAlchemy

We use SQLAlchemy heavily and would like to instrument it. Might be able to find time to make an implementation myself if no one beats me to it.
https://pypi.org/project/SQLAlchemy/
http://www.sqlalchemy.org/

Hi @eliasbrange
We already instrument SQL database calls on the DB-API2 level (basically, cursor.execute and friends), so DB calls from SQLAlchemy should be captured. Currently, this is implemented for PostgreSQL, MySQL, SQLite and soon PyODBC.
Do you think there would be a benefit in instrumenting SQLAlchemy directly over the current DB-API2-level instrumentation?

Hmm. We are using http://pymssql.org/en/stable/ which might explain why I don't receive any captured spans then.
I honestly can't answer that. Just started playing around with APM a couple of days ago.

Yes, that would explain it :)
Adding support for additional database drivers is (usually) quite simple, see e.g. #238 for the PyODBC instrumentation that we are currently working on. The most difficult part is getting tests to work, as we like to spin up a database to test that we don't break the actual connection between the driver and the database.
I'll have a look how difficult it would be to get pymssql instrumented and tested :)

Great! I'll try aswell. Got some of my DB calls in by instrumenting ("sqlalchemy.pool", "Pool.connect"), but somehow misses some of my calls. Will have to check and see if there's another method inside there anywhere that gets called instead.

@eliasbrange nice! However I'd prefer going forward with the current strategy of directly instrumenting the driver, instead of SQLAlchemy. That ensures that the instrumentation even works when using the driver directly, or a different ORM (e.g. Django's ORM).
e.g. something like this (watch out, completely untested as of now :D)
from elasticapm.instrumentation.packages.dbapi2 import (ConnectionProxy,
                                                        CursorProxy,
                                                        DbApi2Instrumentation,
                                                        extract_signature)

class PyMSSQLCursorProxy(CursorProxy):
    provider_name = 'pymssql'

    def extract_signature(self, sql):
        return extract_signature(sql)

class PyMSSQLConnectionProxy(ConnectionProxy):
    cursor_proxy = PyMSSQLCursorProxy

class PyMSSQLInstrumentation(DbApi2Instrumentation):
    name = 'pymssql'

    instrument_list = [
        ("pymssql", "connect"),
    ]

    def call(self, module, method, wrapped, instance, args, kwargs):
        return PyMSSQLConnectionProxy(wrapped(*args, **kwargs))

That sure seems a lot more clever @beniwohli ...

@beniwohli. How do I instrument the above instrumentation without adding it elasticapm/instrumentation/register.py after I have initialized APM with apm = ElasticAPM(app, ...)?

is SQLAlchemy  DB Calls logging  available for apm?


Add support for jbang

https://github.com/jbangdev/jbang lets you launch Java/Jshell sources. It also sports a local wrapper.
Suggested by @shelajev.
Keeping @maxandersen happy 😄

Ping @maxandersen!
Usage: gm <source> <args> where source may be: URL (http*), a .java, or a .jsh file. If no explicit source is given then the first .java file is taken, otherwise the first .jsh

niice! :) how do you get jbang - just assume its in the path?

Yes, it's either on the path or the current dir has the jbang wrapper.


Math magicians: events

Hi Code Reviewer.
Below are the changes made to the code:

[x] Created a new directory called logic

[x] Coped the files calculate.js and operate.js into  logic/ directory

[x] Imported calculate.js in Calculator.js component

[x] Implemented click event handlers using the math logic from calculate.js and operate.js in  React component

[x]  All calculator buttons work according to their function

[x] The Calculator is able to perform math operations.

Hi @Umuhan
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have a descriptive branch name, it would be nice if you could update branch name to events 👍🏿
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Gram matrix notation unclear - multiplication seems element-wise, but is actually a dot product

In footnote 3, I think that the notation is confusing. For specific i and j, the element  G_{i,j} is a number, equal to the dot product between the (flattened) response of filter i and filter j. But the formula makes it seem as if we do an element-wise multiplication (without summation), between \text{layer}_n\text{[:, :, i]} and \text{layer}_n\text{[:, :, j]} . Such an element-wise multiplication would result in a matrix, and not in a scalar. I know that there is a "dot" in there, but I would also add a summation sign, or at least mention that the operator is a dot product which results in a scalar.

Sorry for the late response, I used your suggestion almost directly:


Take advantage of CMake >= 3.13 features

We can require CMake >= 3.13 (see https://github.com/google/oss-policies-info/pull/16). That means a lot of our install rules can be simplified.  The currently look like this:
https://github.com/googleapis/google-cloud-cpp/blob/0c7f077b96f802c0e10f500a3e601b2663bcf353/google/cloud/kms/CMakeLists.txt#L136-L156
They could look more like this:
# Install the libraries and headers in the locations determined by
# GNUInstallDirs
install(
    TARGETS google_cloud_cpp_kms google_cloud_cpp_kms_protos
    EXPORT google_cloud_cpp_kms-targets
    RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
            COMPONENT google_cloud_cpp_runtime
    LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
            COMPONENT google_cloud_cpp_runtime
            NAMELINK_SKIP
    NAMELINK_COMPONENT google_cloud_cpp_development
    ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
            COMPONENT google_cloud_cpp_development)

I think this is resolved, largely thanks to @dbolduc changes for #12428


How to validate an array with mixed types

I've got an array that looks like the following :
var arr = ["foo", 1,3, ...]
I want to verify that the first element of arr is a string and that the other values are integers.
Is this possible?
If not possible it would be really cool to add a custom validation function on the schema for a specific field so we can cover more complex cases.
Thanks

ok found what I was looking for!

Ok not quite :(
I found that you can add custom function but you still need to define a type. So its seems that if the type is not the same it invalidates it. So it doesn't seem straightforward to do the validation I want to do.

There are plans eventually for the simple-schema pkg to support multiple types.


Update charts

https://github.com/longhorn/longhorn/issues/4332
Signed-off-by: Derek Su<EMAIL_ADDRESS>

Need to backport to 1.3.x and 1.2.x.


HydroShare about pages

Create framework for Laura to add content for various semi-static pages related to HydroShare.

@mjstealey Not sure whether this has any connection to the help page VM you set up for the team to collectively edit help pages, and not sure whether this is still in active state now.

implemented as pages.hydroshare.org and should be re-evaluated from there


Meilisearch module

Things done
add meilisearch to systemPackages to facilitate recovering a dump

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Im also thinking about the best way to do an upgrade. But requiring multiple nixpkgs version might be hard.
The other thing that i was thinking was missing is an easy way to enable experimental features.


Exported TimeArbitraries via new testkit module

Exported time arbitraries via a separate module so that users can use them in their property checks.
Related #193

Thanks a lot for this and sorry for being a pain. This LGTM


chore: release next version

:tada: This PR is included in version 2.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


PXP-650: [CLI] Develop a panel on the TUI to display AppSignal data

Summary

Ticket: PXP-650
What's Changed

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jk-gan
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jk-gan, onimsha
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Proposed changes for version 0.2.0

We have prepared a draft of the next version and would like to hear feedback from other providers. The list of proposed changes can be found below, and the draft itself in https://github.com/erasmus-without-paper/ewp-specs-api-monitoring/commit/360443725eb38528d1e9bcc6fb6ea3ea52dc8cbf. Feel free to comment before the version is officially released.

Removed error_type parameter.

Reason: providers were making a lot of mistakes in determining the correct error type and the classification couldn't be fully relied on. The value of error types was also questionable. Most of the current types could be determined based on the other parameters. Besides, a lot of different errors could be mixed inside one category, so it was still necessary to check all the messages. Instead of adding more error types, we believe it would be better to simplify the API and remove them altogether.

Added endpoint_name parameter.

Reason: it wasn't possible to automatically filter or group the reports by the endpoint, only by the API, which could consist of multiple endpoints. The endpoint could be determined only manually by looking at the API URL, but it had to be done for each one individually, so we believe an automatic solution would be helpful.

Removed api_url parameter. Disallowed reporting errors regarding Discovery and Echo APIs.

Reason: since the endpoint will be explicitly passed in a separate parameter, the only role of API URL would be to help unambiguously identify the server host in the catalogue in order to read its admin provider and admin emails. But the only APIs for which it was needed was Discovery and Echo, as other APIs cannot have duplicates. However, the registry isn't going to report errors using the Monitoring API, as it has its own methods of notifying administrators about errors. We also believe that it isn't necessary to report errors in Echo, because this API is for developers to test authentication with the API validator, and if someone is calling Echo, then most probably they are just testing and still might have errors in their own implementation, so they shouldn't report errors to other providers. Besides, errors with authentication will certainly come out in other APIs as well. If we disallow reporting errors for Discovery and Echo, we can then further simplify the API and remove api_url parameter, as it is not needed anymore.

Split message into separate server_message and client_message parameters.

Reason: after removing the error types, splitting the message parameter is necessary to be able to differentiate the origin of the message, as it can come from two sources. Some providers also had problems with respecting the specification and were sending a client message when a server message was expected, so separating the parameters might be less error-prone as well.

Rewritten most of the specification text for clarity.

Version 0.2.0 has been officially released and Stats Portal in the DEV network is now ready to accept error reports in the new format. The old format will still be accepted for some time to give providers time to update their software.


Unable to get URL preview to work

For example:
params := PostMessageParameters{
	UnfurlLinks: true,
	UnfurlMedia: true,
	Markdown: true,
}

_, _, err := client.PostMessage("some_channel_id", "my text <https://stackoverflow.com/>", params)

What am I missing here?
p.s. I see that UnfurlMedia is never converted to config.values.Set("unfurl_media", "true") in MsgOptionPostMessageParameters (chat.go file). I guess that this is the default behavior, right?

looks like it's on Slack's side, it sometimes works and sometimes it doesn't.


Will there be an NPM package?

More of a future looking question than an issue really, but I'm just wondering if the plan is to eventually have an NPM package for run-wasm? It seems like currently it'll be quite tricky to integrate this into an existing repo and keep up to date with improvements here. Would the eventual plan be to just be able to npm install run-wasm or is there something blocking that?

Yeah we intend do have an npm package! Haven't gotten around to setting it up yet though. Need to look into it :)
I'll keep this issue open until we have one


Drop usage of the _copy_in() method of asyncpg (#6315)

Pull request opened by the merge tool on behalf of #6315

Merged into branches iso6 in d267cc7aeb55e9e3d675259d7f60add31c14c767

This branch was not deleted as it seems to still be in use.


Added Web Scraper Example with Control Rate and Prioritisation

Thanks for the template Simon! Sorry it took me so long to get it merged in. Also I did a little touching up in the excel and the file paths.


Unit Tests

Initial version of the unit tests setup:

Using OCMock for mocking and stubbing, Expecta to easily set expectations and the CocoaLumberjack framework via local pod
added some basic tests to demonstrate how to write tests for our library and to make sure the basic functionality works.

@rivera-ernesto please take a look. I still need to add some real tests, but I want your opinion from a setup perspective.

@rivera-ernesto I managed to get to a working setup for the tests. I added a few basic sanity checks, from now on we can take it from there. Could you please merge this one in so I can start working on the 2.0.0 release?

@rivera-ernesto please merge this :)

      ✓ Touch iOS Tests.xctest (12 ms)
      0 errored, 0 warning (3111 ms)
  [Info] Collecting info for testables... (2859 ms)
  run-test iOS Tests.xctest (iphonesimulator8.1, logic-test)
      -[DDBasicLoggingTests testAll5DefaultLevelsAsync]
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Invalid connection: com.apple.coresymbolicationd
2015-03-13 08:46:28:521 xctest[2374:303] Error
2015-03-13 08:46:28:586 xctest[2374:303] Warn
2015-03-13 08:46:28:587 xctest[2374:303] Info
2015-03-13 08:46:28:587 xctest[2374:303] Debug
2015-03-13 08:46:28:587 xctest[2374:303] Verbose
━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
    ✓ -[DDBasicLoggingTests testAll5DefaultLevelsAsync] (134 ms)
      -[DDBasicLoggingTests testLoggerLogLevelAsync]
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
2015-03-13 08:46:28:591 xctest[2374:303] Error
2015-03-13 08:46:28:593 xctest[2374:303] Warn
━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
    ✓ -[DDBasicLoggingTests testLoggerLogLevelAsync] (7 ms)
      -[DDBasicLoggingTests testX_ddLogLevel_async]
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
2015-03-13 08:46:28:593 xctest[2374:303] Info
2015-03-13 08:46:28:593 xctest[2374:303] Debug
2015-03-13 08:46:28:593 xctest[2374:303] Verbose
2015-03-13 08:46:28:598 xctest[2374:303] Error
2015-03-13 08:46:28:607 xctest[2374:303] Warn
2015-03-13 08:46:28:607 xctest[2374:303] Info
━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
    ✓ -[DDBasicLoggingTests testX_ddLogLevel_async] (10 ms)
    3 passed, 0 failed, 0 errored, 3 total (153 ms)
** TEST SUCCEEDED: 3 passed, 0 failed, 0 errored, 3 total ** (15838 ms)

It looks great! Even GitHub shows 2 successful checks.

Feel free to release 2.0.0 whenever you feel ready ;)

Great

It is done. Very nice :+1:


Return 400 but not 500 when request archive with wrong format (#17691)

backport #17691

@Gusted Tests PASS, so I assume this is your LGTM . :)

@Gusted Tests PASS, so I assume this is your LGTM . :)

Ah, L-G-T-M bot is too smart to prevent I vote myself.


Jira issues are not linked when the ticket issue is included in the pull request title

As can be seen in the 👇🏼    screenshot, Jira issues are linked when they appear in a commit title and in a pull request body, but not in the pull request title itself.
I tried a few different variants and none of them was linked.
This is the situation in all of our organization repositories.
Note: PR is the name of the Jira project, it does not stand for pull request

Thank you 🙏🏼

@Avivhdr Github doesn't allow links in PR titles, unless you know something I don't, but I just tried with markdown without any success.


ng build fails with TypeError: core_1.Version is not a constructor

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Yes
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

1.0.0-beta.20-4
Note our application has crucial dependencies on third-party libraries that worked fine then started failing when 1.0.0-beta.22 was released.   So our production application using those production libraries on the official release of Angular is dead.  Our work-around was to use an outdated (but working) angular-cli.  The results was different but worse insofar as it's failing on angular-cli libraries themselves now.  Found salvation using 1.0.0-beta.21 which actually worked.
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

ng build
The log given by the failure.

Normally this include a stack trace and some more information.

TypeError: core_1.Version is not a constructor
Mention any other details that might be useful.
As mentioned, things still work if you use 1.0.0-beta.21
Here's the file that errors with 1.0.0-beta-20-4:
TypeError: core_1.Version is not a constructor
at Object. (...\node_modules@angular\compiler-cli\src\version.js:18:19)
at Module._compile (module.js:556:32)

Thanks! We'll be in touch soon.

Even I am facing same issue..

Had same issue. Forgot to "freeze" version of "@angular/compiler-cli" which got upgraded and was ahead of other angular lib versions. I set it to "2.2.4" (as my other libs) and it works again.

I am facing same issue too.

I upgrade @angular-cli version to 1.0.0-beta.21 and the error resolved

Closing this as resolved.


Magnify

This is really an excellent Angular gallery component with very good documentation including integration with Angular-CLI and MaterialDesign.
The one and only feature that would be very nice to have that is absent is a magnify option when in preview mode.  Something similar to https://sachinchoolur.github.io/lightgallery.js/demos/  (click any image then see the Magnify+ and Magnify- options).

Hi @chrishandorf, I will add this to my features/improvements list.

Hi @chrishandorf, please check version 3.0.1 and option previewZoom. Demo here https://lukasz-galka.github.io/ngx-gallery-demo/#preview-with-zoom

I took a quick look and it looks great!   I will be working on integrating it and testing it on my own site this weekend.  Thank you for the wonderful work.  Where is the beer link?  :)
Chris

On Nov 1, 2017, at 6:26 AM, Łukasz Gałka<EMAIL_ADDRESS>wrote:
Hi @chrishandorf https://github.com/chrishandorf, please check version 3.0.1 and option previewZoom. Demo here https://lukasz-galka.github.io/ngx-gallery-demo/#preview-with-zoom https://lukasz-galka.github.io/ngx-gallery-demo/#preview-with-zoom
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/lukasz-galka/ngx-gallery/issues/53#issuecomment-341105377, or mute the thread https://github.com/notifications/unsubscribe-auth/ACbFIfb4Ne-yUH5MdxxSmiLyJV9L4DAeks5syHF9gaJpZM4P5yXx.

Hi @lukasz-galka ,
The Zoom option is working great.  Thank you.  I did notice one problem because there are no restrictions on the minimum / maximum amount of zoom.  If you press the Zoom- button enough times the image will eventually disappear.  That makes sense I guess, but if you press it a few more times the image re-appears but now it is upside down and it starts to get Larger every time you press Zoom-.       Maybe there should be options like this: ?
{
"previewZoom": true,
"previewZoomMin":  5,    // Zoom- can be pressed up to 5 times
"previewZoomMax": 3     // Zoom+ can be pressed up to 3 times
}

Hi @chrishandorf , thank you for suggestions. I have added 3 new options in version 3.1.0:

previewZoomStep
previewZoomMax
previewZoomMin

https://lukasz-galka.github.io/ngx-gallery-demo/#preview-with-zoom

Wow, Great Component, I Would like to Request to you please implement thumbnails slider with images in modal.

Please add image description in code because i am new one to angular.

Regards,
Saisudhakar,
<EMAIL_ADDRESS>


Try overhaul and implicits

For Option, it works really nicely.
For Try, it is not perfect, because of two facts:

We have Try<A> and Try<A, E> and there is no way of turning Error<InvalidOperationException> into Try because of type invariance of Error. So I decided to use Error<E> for Try<A, E> and Exception for Try<A>. It's not as nice but works pretty well.
Second problem which I consider a bit more serious is, that as soon as you start using Match and nested expressions, you have to explicitly put in types, so that the compiler knows the resulting type. This can be seen inside Try<A> for example.

I still don't like the distinction between two versions of Try and consider actually getting rid of Try<A> and instead implement extension methods for Try<A, E> where E : Exception. On the one hand, typing would be more elaborate, on the other hand, we'd get more specific type signatures and thanks to implicit conversions, usage would be even better than now.

I would definitely vote for removing Try, speaking of our codebase, we already have misuses for Try like http client, which always returns Try<Response, HttpClientException>, but its signature is still Try. And moving forward, we should aim for limiting the usage of weakly typed errors, So I am all for this.


Upgrade eslint-config-prettier dependency

Related to #247

Not any specific handling required and closed by #264


Cleanup and fixing the planet protect plugin.

The old meta programming method wasn't working correctly, so I fell back to explicit calls for the bad packets. Also did some cleanup on the in-game context text.

I see much of the same code, maybe common method? Also if doc string is almost the same like funcion name, it isn't needed imo.

Right now, I care less about code optimization, and more about bug fixing. We can always beautify the code later. Give people a product that works is more important.


Willow docker port conflicts with WIS docker ports used for WebRTC

I run both the WIS instance and the Willow docker on the same docker server. What I have noticed is that when the Willow docker tries to start, it wants to expose port 10000 in the container. However, WIS uses port 10000 so I get a conflict. To work around this I had to modify the Utils.sh to change the port to 20000 to avoid the issue. Thinking it may be a good idea to do this in the actual release code to avoid the problem for other users who may run the containers on the same server? (I know once 1.0 is released this will probably be less of, or not at all, an issue, but figure this may help out for developers). 😃

Good catch!
As 1.0 overall comes together we need to take a good hard look at port assignments generally and establish some defaults that make sense.
For the Willow container, exposing port 10000 is kind of a goofy hack to give Windows users a chance to flash. I don't see a reason why not to remove it in 1.0 because with the web flasher (in development) and WAS OTA there really isn't a good reason to leave it.

Makes sense and figured that was the path this would move toward. 😃


Publicising nix-snapshotter more

I think we have reached a point where nix-snapshotter is mature enough that it might be wise to try and publicise it a bit more.  It would be nice to have a bit more traffic and hopefully get some more contributors!
From the Insite/Traffic page it seems like most of our visitors are still coming for the original HN post, followed by direct searching.  We got a massive burst of interest with the HN post and it's plateaued off a little bit since then.
As I think mentioned in a prior PR discoverability suffers a little bit from the project only really being findable if you already know what you are looking for, as a suspect a lot of people do not know what a snapshotter is.
It might be wise to try and add some links to some places NixOS wiki, (“See also” for example) that point people towards this project.
Would be interested in your thoughts and any other ideas you might have @elpdt852!

The NixOS wiki is a good idea, will discuss that with @elpdt852 - thanks @RobbieBuxton !

Possibly also put in a PR to add it to awesome nix? I think it's "awesome" enough 😁.

HN post and it's plateaued

There was a small uptick on Oct 10th.
I think another popular post can and should be created from https://github.com/pdtpartners/nix-snapshotter/issues/85, namely how to get nix-snapshotter running in a public kubernetes engine.


[Proposal] Add support for page meta

With issue #3 the necessity for per page meta will become a requirement for example:

taxonomy (tags, categories, etc) used for generating taxonomy index pages
draft status flag
published_date (to enable scheduling, if the published_date is in the future the page does not get generated)
etc

Page meta could also be made available within the page as PHP variables, in the same way as the config.php variables are; page meta variables with the same key would overwrite variables set in config.php.
Possible methods of implementation:
In a recent client project I used blade comment syntax for this for example:
{{-- draft: true --}}
{{-- tags: bar, foo, etc --}}

I would be happy to dig that code out and add the functionality myself. Alternatively page meta could be added knockout.js style with a html comment such as:

These comments could then be parsed out when the page is generated to html, so that no backend meta is leaked.
I intend to use jigsaw for a blog and am very happy to help write an implementation for both this and #3.

This could also be used to enable/disable pretty URLs on a per page basis rather than as a global via the --pretty=false option.

Thanks for getting the discussion started! I think this is gonna have to be done super carefully to make sure we keep the project as simple to use as possible, so would be good to bounce around a bunch of ideas of how this could be done and figure out what seems like the best path forward.
I'm personally pretty partial to a YAML + Markdown sort of format like you see in Jekyll and Sculpin for blog posts, what are your feelings on that?

No worries, I really love the simplicity of what you have created and certainly don't wish to add any unnecessary clutter to what it already pretty usable.
I have had a look over a range of static site generators and have noticed they all tend towards YAML + Markdown akin to both Jekyll and Sculpin. I think that works really well, certainly with markdown.

I've been working on some integration using markdown for the content, essentially using some syntax for meta.
e.g.
##
# Title: Super Awesome Post
# Date: 10/21/2015
##

# This is some content

Vestibulum id ligula porta felis euismod semper. Sed posuere consectetur est at lobortis.

Those attributes would get turned into an variables that you can access in the blade template.
Something like this:
{{ $title }}
Published: {{ $date}}

{{ $content }}

I have been working on this today here. I ended up moving some parts of the functionality around to aid in testing and to make it easier to add future functionality (such as file watching and collections). Currently I have it to the point where it loads meta from file headers in a YAML format and injects it into the pages scope. All but one unit test passed, and that's because I have yet to implement overloading of the pretty option on a per page basis.

@carbontwelve Cool! Keep me updated with how it's going, would love to check it out when you have something you want to show!

I managed to implement page meta in my branch here I ended up adding some additional classes to help with the additional functionality. I'm not entirely happy with how I have laid out the execution order but its working. What do you think?

What about Frontmatter?

@jbrooksuk it seems I wrote similar functionality into my MetaParser class here I didn't know the method of data storage was called front matter haha.
I have had a look at your implementation with the idea in mind to use the library and raised some issues which stop me from using it at present.

I have had a look at your implementation with the idea in mind to use the library and raised some issues which stop me from using it at present.

I'm on them now :)

Phrontmatter now supports YAML, JSON and TOML for the meta data :)

My gut says YAML + Markdown is an easy win, and the tough part will be configuring how to add meta support for Blade pages.
So, the next question is, which Blade pages merit meta data? We've mentioned collection index/listing pages. Anything else? To me YAML frontmatter is a perfect pair with Markdown, but the job we're trying to accomplish in associating a Blade template with being an index page may better be solved a different way.
There's also the interesting idea of doing collection-ing by putting all the markdown in a folder.
What do we think about this? Are there other use cases I'm missing here? Are there things we won't be able to handle given this specific example?

Hey all, I have been playing around with the concept of collections on a branch of mine.
I have it working close to what @mattstauffer has outlined above with the exception of including a directory for storing the collection's item template.
single-{collection}.blade.php is what the collection items are passed into to render.
├─ source
│  ├─ _assets
│  ├─ blog
│  │  └─ my-blog-post.md
│  ├─ _collections
│  │  └─ single-blog.blade.php
│  ├─ blog.blade.php
│  └─ index.blade.php

For easy generation I have added a make:collection command which generates all the boilerplate for a given collection.

When running jigsaw build the CollectionHandler checks to see if the file in question is in a folder which has been registered in the config under collections. Piggy backing off of @adamwathan's markdown handler the file is compiled to blade going via the collections template e.g. _collections.single-blog.blade.php.

As mentioned above, the CollectionHandler extends the MarkdownHandler for this reason I did have to change some of the visibility from private to protected.
Side note: I have called the above handler CollectionHandler but I think a more suitable name is CollectionItemHandler which will become apparent below
Next steps
This is more of a proof of concept than anything because it is missing a lot but happy to take it as far as needed for it to be an actual PR!
What stands out as missing for is a nice way to pass collection items into a collections index page. I have been trying to think of a clean way of doing this but haven't come up with a nice way. Possibly registering collection items into Jigsaw and then when an index is being registered it can just take them from there. I have been playing about with this on a separate branch but have knowing solid yet!  As I type another avenue that could be explored is storing item meta data in a temp folder.
I think once we have a collection of items it won't be too hard to have sorting etc.

Is there no love for keeping the implementation close to what Jekyll already implements?
No matter the language of the post - blade or markdown, just use YAML front matter, and require that a date be specified (in any format parsable by strtotime), markdown posts require that a section be specified alongside a extends param as they do now.
I thought it might make it more Laravel-like by implementing collection folders using the @ prefix:

Directories prefixed by '@' are not ignored during compilation, but rather treated as collections of content. Their content will be rendered using the name of the folder (without the '@' prefix) as the first part of the URL structure.

├─ source
│  ├─ _assets
│  ├─ @posts
│  │  └─ my-first-blog-post.md
│  ├─ blog.blade.php
│  └─ index.blade.php

This would then render out as the URL:
http://mysite.com/posts/my-first-blog-post/index.html (pretty)
http://mysite.com/posts/my-first-blog-post.html

Then you could inject a $collections object into blade which manages listing and paginating collections in templates:
@foreach ($collections->paginate('posts', 10) as $post)

{{ $post->title }}

{{ $post->content }}

@endforeach

{{ $collections->pagination('posts') }}

Hi!
I'm testing jigsaw and I created a helper function call posts that get a collection of the posts with the yaml content of each file and the link of the post.
For example if I have in my post file the next yaml content:
---
extends: _layouts.master
section: body
title:  "Hello Mundo"
date:   "2014-01-24"
---

In the layout file, I can call the method posts() using a foreach like this:
@foreach (posts() as $post)

{{ $post['date'] }} » {{ $post['title'] }}

@endforeach

The content of the posts function is this:
<?php

use Mni\FrontYAML\Parser;
use TightenCo\Jigsaw\Filesystem;

function posts()
{
    $posts = [];

    foreach ((new Filesystem)->allFiles('source/posts') as $file) {
        $document = (new Parser())->parse($file->getContents());
        $posts[] = array_merge($document->getYAML(), [
            'link' => "posts/" . basename($file->getRelativePathname(), '.md')
        ]);
    }
    return collect($posts);
}

Hey folks, we've let this collections concept sit for a bit and I think it's nearing time to visit our various options.
Could anyone who has a functioning solution do me a huge favor and give me a link to your repo, or, if you'd like, make a PR?
We're looking to combine "what people are already familiar with" (e.g. Jekyll) with "what makes sense for how Blade and Jigsaw work" with "What's both simple and powerful".

I've created a working solution.  There's a readme file on the repo with an explanation of my methodology as well as some source code using it and a link to the site that it generates.  I'd love for you to check it out and let me know what you think: Jigsaw Build Decorating  The fork with the code changes is here.

Yo @mattstauffer, the fork mentioned above by @forsaken-threads 👍  is the one I was telling you about the other day - the one we've been working on at the office, check it out :)

FWIW, Phrontmatter supports YAML, TOML and JSON meta data, if that makes it more customisable 👍

This is now handled with collections in release 1.0.0 (https://github.com/tightenco/jigsaw/releases/tag/v1.0.0), see the docs for more details. Page variables can be added in YAML front matter to collection items, whether they are Markdown or Blade files, as well as in config.php.

@damiani congratulations on the release of 1.0.0, it looks amazing.


Error: "annotation.PreDestroy not present" with java 9.0

I have this error when I try to execute restclient
An exception was caught and reported. Message: java.lang.ClassNotFoundException: javax.annotation.PreDestroy
java.lang.TypeNotPresentException: Type javax.annotation.PreDestroy not present

I need to change the build script to support 9. Let me look into it.

I was able to modify build scripts a bit and build for Java 10. Uploaded the build here. The commits I made are breaking the Mac build. Will be fixing it later.

Now I have this error
java -jar restclient-ui-fat-3.6.2-SNAPSHOT.jar
Errore: LinkageError durante il caricamento della classe principale org.wiztools.restclient.ui.Main
        java.lang.UnsupportedClassVersionError: org/wiztools/restclient/ui/Main has been compiled by a more recent version of the Java Runtime (class file version 54.0), this version of the Java Runtime only recognizes class file versions up to 53.0

Can you upgrade to Java 10?

Ok, I'm sorry with Java 10 works...


digital-copyright

Hi NATSpeech!👋, I added this optional feature to digitally sign you source-code should you ever be audited or experience a software supply-chain attacks. See the dc-readme.md for instructions on accessing your hash. Feel free to contact me directly to review any questions efore accepting. ~~Best<EMAIL_ADDRESS>

Any feedback on how I can communicate this better clearer?


Add APIV2 service files

Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

Fixes: https://github.com/containers/libpod/issues/5563

LGTM assuming happy tests

Does @lsm5 need to make changes to the Fedora specfiles to install these?

He will once it merges, Just for Rawhide, I fixed F32 and F31.

Once this merges I will fix the rawhide spec file.

@baude @giuseppe @TomSweeneyRedHat @mheon @saschagrunert Can someone give this the /lgtm it needs

/lgtm

@TomSweeneyRedHat @mheon @baude @vrothberg @giuseppe @QiWang19 @jwhonce This one got the "/lgtm" but did not merge.  Could someone try again.
/retry

added to rawhide as well


Contributors for 2.0.0 release

PySCF 2.0.0 has improvements in the features, project layout, code release pipeline, and documentation. In this release, based on the git log history since the release 1.7.0, we found the contributors listed below. If you made contributions to the project after PySCF-1.7.0 (2020-01-01) but didn't find your name in the list, please reply to this post. Please also take a look at the file https://github.com/pyscf/pyscf/blob/master/NOTICE . This file records all contributors to the project. But some contributors are not  included in the file and some affiliations are incorrect. Please reply to this post if you find any changes that should be made in the file.
Abdelrahman Ahmed
Alexander Sokolov
Bryan Lau
Eric Hermes
Garnet Chan
Henrik R. Larsson
Hongzhou Ye
Huanchen Zhai
Hung Pham
James E. T. Smith
Jan Hermann
Janus Juul Eriksen
Kevin Focke
Kevin Gasperich
Lucas K. Wagner
Marc Barbry
Mark Williamson
Matthew Chan
Matthew R. Hermes
Matthew Treinish
Matthias Degroote
Max Nusspickel
Maximilian Scheurer
Muhammad Firmansyah Kasim
Nikolay Bogdanov
Ollie Backhouse
Peter Pinski
Qiming Sun
Samragni Banerjee
Sandeep Sharma
Shiv Upadhyay
Simon Ewing
Susi Lehtola
Terrence Stahl
Tianyu Zhu
Timothy Berkelbach
Verena Neufeld
Xiao Wang
Xing Zhang
Yang Gao
Yixiao Chen
Zhenyu Zhu
Zhihao Cui
Contributors for the documentation https://pyscf.org/user.html :
Alexander Sokolov
Chong Sun
Garnet Chan
Hongzhou Ye
Huanchen Zhai
James E. T. Smith
Jan Hermann
Janus Juul Eriksen
Kyle Bystrom
Ollie Backhouse
Peter Pinski
Qiming Sun
Samragni Banerjee
Sebastian Ehlert
Seunghoon Lee
Susi Lehtola
Tianyu Zhu
Timothy Berkelbach
Verena Neufeld
Xing Zhang
Xubo Wang
Yang Gao
Zhihao Cui

2.0.0 has been released; should this ticket be closed?