Incompatibility errors found when running setup script

When I ran the setup_environment.sh script most of it ran fine, but I did see a handful of errors:
ERROR: google-cloud-spanner 1.12.0 has requirement grpc-google-iam-v1<0.13dev,>=0.12.3, but you'll have grpc-google-iam-v1 0.11.4 which is incompatible.
ERROR: google-cloud-language 1.3.0 has requirement google-api-core[grpc]<2.0.0dev,>=1.14.0, but you'll have google-api-core 1.11.1 which is incompatible.
ERROR: google-cloud-translate 2.0.0 has requirement google-api-core[grpc]<2.0.0dev,>=1.14.0, but you'll have google-api-core 1.11.1 which is incompatible.
ERROR: google-cloud-translate 2.0.0 has requirement google-cloud-core<2.0dev,>=1.0.3, but you'll have google-cloud-core 1.0.1 which is incompatible.
ERROR: google-cloud-bigquery 1.6.2 has requirement google-cloud-core<0.30dev,>=0.28.0, but you'll have google-cloud-core 1.0.1 which is incompatible.
ERROR: tensorboard 2.0.1 has requirement grpcio>=1.24.3, but you'll have grpcio 1.21.1 which is incompatible.
ERROR: mssql-cli 0.17.0 has requirement prompt-toolkit<2.1.0,>=2.0.0, but you'll have prompt-toolkit 1.0.18 which is incompatible.
ERROR: mssql-cli 0.17.0 has requirement prompt-toolkit<2.1.0,>=2.0.0, but you'll have prompt-toolkit 1.0.18 which is incompatible.
ERROR: google-cloud-datastore 1.10.0 has requirement google-api-core[grpc]<2.0.0dev,>=1.14.0, but you'll have google-api-core 1.11.1 which is incompatible.
ERROR: google-cloud-datastore 1.10.0 has requirement google-cloud-core<2.0dev,>=1.0.3, but you'll have google-cloud-core 1.0.1 which is incompatible.
ERROR: google-cloud-logging 1.14.0 has requirement google-api-core[grpc]<2.0.0dev,>=1.14.0, but you'll have google-api-core 1.11.1 which is incompatible.
ERROR: google-cloud-logging 1.14.0 has requirement google-cloud-core<2.0dev,>=1.0.3, but you'll have google-cloud-core 1.0.1 which is incompatible.
ERROR: google-cloud-bigtable 0.31.1 has requirement google-cloud-core<0.29dev,>=0.28.0, but you'll have google-cloud-core 1.0.1 which is incompatible.
Some installs were done successfully and then one final error:
ERROR: Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/usr/local/lib/python2.7/dist-packages/pbr-5.4.3.dist-info'
Consider using the --user option or check the permissions.
I do have a couple of new directories (jobs and pipeline), but I'm not sure whether these errors are showstoppers or just inconvenient. Also if there's any guidance on how to modify code or config docs to point to the correct libs, that would also be great.

Hi - thanks for reporting this! Are you using a virtual environment? If not, we highly recommend it - it will prevent any mismatch between already-installed versions of libraries on your machine vs. the versions that Oculi needs.

Hi,
I did not. I actually tried the set up script within the CLI. I will try running the virtual environment script first and then the setup script to see if there is a difference ion performance.
Thanks,
[/Users/kerry.sullivan/Library/Containers/com.microsoft.Outlook/Data/Library/Caches/Signatures/signature_1078473883]
James E. White  |  Digital Marketing Manager  |  O: +1.312.693.5211  |  M: +1.312.493.6537
From: xerebus<EMAIL_ADDRESS>Reply-To: google/oculi<EMAIL_ADDRESS>Date: Thursday, November 7, 2019 at 5:43 PM
To: google/oculi<EMAIL_ADDRESS>Cc: James White<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [External] Re: [google/oculi] Incompatibility errors found when running setup script (#2)
This message is from an EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments.

Hi - thanks for reporting this! Are you using a virtual environment? If not, we highly recommend it - it will prevent any mismatch between already-installed versions of libraries on your machine vs. the versions that Oculi needs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_google_oculi_issues_2-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAJHI5AN4HDKNSV6X2ACO2DTQSSRY3A5CNFSM4JJFOF62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDOHASQ-23issuecomment-2D551317578&d=DwMCaQ&c=eIGjsITfXP_y-DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=lP0lYQkTlWLBEiwb05T3xt55HnlTQOs_RuuPSG9GyVk&m=28l1OB7eVgZHQbJoOyAJzgjes1Yugnrmsd-kfdYWb2A&s=FBeqMQRtK8A2hl8dusoWIsDyKfHI1TC7WMYMtbBIeFY&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AJHI5AINBM4MQI62462RQ53QSSRY3ANCNFSM4JJFOF6Q&d=DwMCaQ&c=eIGjsITfXP_y-DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=lP0lYQkTlWLBEiwb05T3xt55HnlTQOs_RuuPSG9GyVk&m=28l1OB7eVgZHQbJoOyAJzgjes1Yugnrmsd-kfdYWb2A&s=ES3Jb6O1xJvacaggg5HCYBkdttkcBob5kMekwz7ILBk&e=.

This message is for the designated recipient only and may contain privileged, proprietary, or otherwise confidential information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the e-mail by you is prohibited. Where allowed by local law, electronic communications with Accenture and its affiliates, including e-mail and instant messaging (including content), may be scanned by our systems for the purposes of information security and assessment of internal compliance with Accenture policy. Your privacy is important to us. Accenture uses your personal data only in compliance with data protection laws. For further information on how Accenture processes your personal data, please see our privacy statement at https://www.accenture.com/us-en/privacy-policy.

www.accenture.com

I created the virtual environment and then ran the set up script script. I got the same errors this time as well. Do you think this will be a problem or can I move forward with the rest of the set up?

Hello - Unfortunately, we have been unable to reproduce this error across multiple environments. You should certainly continue and see if you get further failures, but the errors provided (especially the EnvironmentError) are specific to your local environment. Please ensure the virtual environment was set up successfully to fully isolate your current system from the runtime environment.
Closing - can't reproduce


Refactor subprocess calls in VASP

Closes #1733.

@zulissimeta: If you have a moment, could I get your review on this?

This looks reasonable to me!

@zulissimeta: If you have a moment, could I get your review on this?
Note: The lines are not shown as covered by codecov, but they are run on an HPC machine at Princeton via GitHub Actions, and the tests pass. The codecov report does not include the coverage from the HPC machine.

Thanks, @zulissimeta! Merging now. Please let me know if any issues arise.


⚠ Ixtanet SAT has degraded performance

In 80850ef, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20798 ms

Resolved: Ixtanet SAT performance has improved in da7bac7.


Remove crawler redundant search button

There were two search buttons. This removes one.

I was curious why we had two buttons. The origin comes from an old design (see #14) where there was a separate sidebar for filtering. This was changed to the current design in #32.


LLVM stdenvs with LLD outside of pkgsLLVM

Ever since #122778 llvmPackages_*.stdenv and llvmPackages_*.libcxxStdenv respects stdenv.hostPlatform.linker. This means that it'll be using ld.bfd on Linux and cctools on macOS.
This has a big downside, namely it being virtually impossible to produce C++ binaries using these stdenvs. This seems to be caused by the fact that ld.bfd doesn't really understand the object files clang produces (cctools probably works fine? Haven't tested it on darwin so far). This is quite a shame especially with libcxxStdenv.
Current workarounds for this are either using pkgsLLVM.stdenv (which cross-compiles, however) or using the following incantation: overrideCC llvmPackages.stdenv (llvmPackages.stdenv.cc.override { inherit (llvmPackages) bintools; }).
I've been struggling to find a clear way forward and not opened a PR for this so far, but would really like to fix this in a satisfying way. The question is mostly if we a) want to preserve llvmPackages_*.stdenv using the default linker for the platforms and create a new clang+lld LLVM stdenv with a different name (which one?)  or b) revert the meaning of llvmPackages_*.stdenv to the pre 21.05 days and have it use LLD unconditionally.
cc @Ericson2314

I kinda dislike #122778 and want to make llvmPackages.stdenv use LLVM bintools by default.
Using ld.bfd in LLVM stdenv is so surprising and troublesome since we'd expect LLVM stdenv uses LLVM toolchains. And currently in chromium and firefox we actually need to explicitly introduce back ld.lld. I don't think there such a "linker of platform". Linkers are independent from platform. They are details of building process.

I don't think there such a "linker of platform". Linkers are independent from platform. They are details of building process.

Arguably you could also say this about the compiler or the toolchain in general, but it makes sense in the context of a package set generally.

Using ld.bfd in LLVM stdenv is so surprising and troublesome since we'd expect LLVM stdenv uses LLVM toolchains.

I'm also a bit torn on this one, maybe llvmPackages.stdenv should always use LLD. Then again, it does work fine for C and I think it should work fine in general on darwin with cctools?!

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/gcc11stdenv-and-clang/17734/2

This is currently one of the major obstacles to pkgsCross.*.chromium.

I think it would be surprising on Darwin if something that just needed a newer (or specific) version of clang also got lld in place of ld64.


Resizable handles on other corners

Hi, thanks for creating this.
Just curious about your timeline on  Resizable handles on other corners
any info would be appreciated
thanks!

This is a duplicate of #758 and should be closed.


Updates

I've combined #1130 #1129 #1125 and #1123 into this PR
This should not be squashed when merged

Closing in favor of #1139


Rollup's bundling is very slow

Title. We have a simple build but a long compilation time, has been noted it could definitely be because of how big tensorflow is. Options suggested include bundling tfjs separately, downgrading either TS itself or the rollup TS plugin, attempting to use parcel again (or webpack!), and so on.
This isn't too much of an issue but just a place where if we have some free time and want to work on making developing this a bit more smooth, we can just go to here to see what works, what doesn't work, and discuss solutions.
Relevant articles:
Problem w/ TS, could try to downgrade?
An article with just some general thoughts on how to speed things up.
Things that don't work:
Setting commonjs({ sourceMap: false }) in rollup.config.js
Setting "declarations" : false" in tsconfig.json

Things to note: This might very well be a performance issue on the laptop end, but it manifests on an incredibly weird way.
My laptop (unplugged) - AMD Radeon 5900HS: ~20-21s build
My laptop (plugged) - AMD Radeon 5900HS w/ NVIDIA RTX 3060 GPU - ~7s build
Olir's laptop - M1 MacBook Air - ~7s build
Shunji's laptop - M1 MacBook Pro - ~4s build
??? Incredibly odd and I'm not sure why the GPU would bottleneck this performance, especially considering my laptop is pretty capable. Along with this, inspecting in task manager/just listening to how the fans don't even fire means that there's not even a large system load when this occurs.


update golangci-lint to v1.46.2

Signed-off-by: Jens Drenhaus<EMAIL_ADDRESS>

Was there a reason why those tests have been deleted? Looks like it did not change the coverage numbers so I guess they didn't test anything useful?

The functions these test used to test were removed earlier.Even the calls to the function in the tests were removed (but not the rest of the test) so it was detected as dead code. Good linter ^^


How to turn off Chrome Password Manager in Karate

Hello,
Can't find a way in Karate to disable chrome password manager via chrome options. Here is my best, but it's not working:
{type: 'chrome', executable: '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome', goog:chromeOptions: { credentials_enable_service: false, profile.password_manager_enabled: false }}
Is there any documentation on required options hierarchy for karate driver configuration? The provided one is definitely not enough.

@dmitry-minchuk we prefer questions like this on stack overflow. that said maybe using addOptions: ['--disable-save-password-bubble'] may be sufficient.
also refer this comment in case it helps: https://github.com/intuit/karate/issues/1134#issuecomment-638990087
if you can suggest what documentation should be added (ideally submit a PR) we will update it

https://bugs.chromium.org/p/chromedriver/issues/detail?id=1015
this hasn't been working for a while


ListBox

I have changed ListBoxItem template. Now it use ripple and it is transparent. Base color of transparency is depends on foreground, if it is dark, selection in listbox become dark, otherwise white. Hence now listbox can work with any background color. For example, i have changed maindemo navigation listbox, it's background is binded on primaryhuebrush.

Thank you, been wanting to sort this out...looks good.


[FEATURE_REQUEST] Add Header Authentication

Is your feature request related to a problem? If so, please describe.
Currently the only authentication options are Keycloak and inbuilt auth. I use Authelia to manage my SSO, which supports passing user/group info through to the reverse proxied app. There are also other apps out there that can pass in user/group info in a similar way.
Describe the solution you'd like
I see this providing the same functionality as the current Keycloak auth, just grabbing the user/group info from headers passed via the proxy instead of interrogating Keycloak.
appConfig.auth (optional)

Field
Type
Required
Description

enableHeaderAuth
boolean
Optional
If set to true enable Header Authentication. See appConfig.auth.headerAuth.

appConfig.auth.headerAuth (optional)

Field
Type
Required
Description

userHeader
string
Optional
Header name which contains username (default: X-Forwarded-User)

groupHeader
string
Optional
Header name which contains group info (default: X-Forwarded-Groups)

proxyWhitelist
array
Required
Upstream proxy servers to expect authenticated requests from.

From here it could use the already existing hideForUsers and showForUsers config, but given that Keycloak has them split out I'm not sure how feasible it is. Could also extend the displayData options to have hideForGroup and showForGroup for extra configurability.
Priority
Medium (Would be very useful)
Is this something you would be keen to implement
No

I believe this is still relevant.

I started to try to hack this in as it is just process.env.REMOTE_USER or similar but the client side nature Vuejs and the Axios is a bit more than I can wrap my head around.

I found your 2.1.2 and it had a good start at the config race condition in main.js that I was running into with implementing headerAuth. I will say I'm not that good at async coding so there might be some big issues. I have it working for my use case which isn't what a maintainer likes to hear.

It is currently hardcoded for my REMOTE-USER mostly because I don't know how to access getAppConfig().headerAuth.userHeader in the nodejs services/get-user.js which is one of the few things I need to make this configurable.
There is no documentation on how to use this. I'm using Authelia but this would work for Apache/NGINX basic/ldap auth too. Even Apache and mod_auth_mellon(SAML) would allow adding a username header.
I'm using the built in users 'database' to get the hash and fake like a normal user instead of the bolt on that is Keycloak with it's own auth level.

I'll try to work on a WIP PR in a bit.

It looks like this missed 2.1.2. Should I try again? Lots of auth/permissions config could use server side help to limit information leak.

It looks like this missed 2.1.2. Should I try again? Lots of auth/permissions config could use server side help to limit information leak.

Sorry @toddejohnson, this slipped my mind. I'll look into this this week, and see if we can get something working :)

I started to try to hack this in as it is just process.env.REMOTE_USER or similar but the client side nature Vuejs and the Axios is a bit more than I can wrap my head around.

Yeah, it's annoying. If you need to read an env var client-side, prefix it with VUE_APP_ and then it can be read in Vue.

Still trying to get Authentik to work with Dashy and come across this method.
Is this suppose to work in 3.0? or still under development
I had it setup as below but getting page reload loop  from  .catch(() => window.location.reload()); but I don't know where to look deeper to see what was the error triggering it.
   users:
      - user: user1
        hash: removed
        type: admin
      - user: user2
        hash: removed
    enableHeaderAuth: true
    headerAuth:
      userHeader: X-Authentik-Username  # the tag containing username according whoami
      proxyWhitelist:
        - "<IP_ADDRESS>"  # RemoteAddr from whoami

@rxunique - You're absolutely correct, shouldn't be triggering a page reload there (not sure why I put that?!). I've updated.
I'm just looking into the header auth feature at the moment, and if I can get something working this evening, will merge as part of 3.0.1. But I'm struggling to understand what exactly needs implementing in Dashy to get this working. I've not really used Authelia, quickly tested it out with NGINX, and it seemed to work alright.
So any tips on what specifically isn't working or what needs to be added/amended would be appreciated :)

Oh pretty much nothing you need to implement, existing code works, documentation would be nice.  It was quite head against the wall trying to figure it out, but with benefit of hindsight, it's so obvious.
The flow is like this

Authtik proxy auth will add header X-Authentik-Username X-Authentik-Email X-Authentik-Groups
In dashy specify auth.users and auth.headerAuth.userHeader=X-Authentik-Username
In dashy specify the correct IP

That's it, if authentik username (or other fields) matches dashy users, you are in with per user authenticaion.
The difficulty I ran into, which may be improved on a back burner

the page loop which you already fixed
proxyWhitelist seems to be cached on container start making testing not that easy, or maybe its something else, wasn't too sure
make matches IP by string, not by range.

In my case, since all behind Traefik, on the same docker network, it was my Traefik container ip 172.x.x.x and because I restarted different container while trying to figure it out, their IP changed which made it quite a guess work with proxyWhitelist,
A generic OIDC would be superior than proxy auth, but it works now.

Hey, just another idea to deal with whitelist.
Currently matching by string is just one line of code, matching by range would need quite a few extra line of code but still need some guess work.
Different people setup docker network and proxy differently, so proxy IP as appeared to dashy will always be different.
What about add another match condition like  (proxySecret === X-Dashy-ProxySecret) || proxyWhitelist.includes() , its very easy to manually add a header 'X-Dashy-ProxySecret = MySecretHash' with proxy, certainly with treafik. That way no guess work with

The idea is to list the trusted IP of the reverse proxy that is trusted. If a request from another IP was made saying it was someone else logged in it shouldn't be trusted.

How is the status of this feature?
I see an implementation in #1390, but it doesn't implemented the groupHeader config. Also I don't get why it's selecting users from the auth.users configured ones: if we are behind an auth proxy I guess we can just setup the user from userHeader as the logged one.


Add frontmatter support to API

There was debate about this on a Discord thread about something else, but on balance we felt it would be good to add it. Lower priority though.
@mikeerickson pointed out we have his:
const fmData = new FrontmatterModule().parse(template)
but @dwertheimer countered "wouldn't const fmData = note.frontmatter make more sense?"
He and I would like to see some setters as well as getters. For example:

note.addOrUpdateFrontmatterField(key, value)
extend newNoteWithContent(content: string, folder: string, filename: string): string to add a useFrontmatter: boolean parameter

Couple of thoughts:
Not sure we need the addOrUpdateFrontmatterField because frontmatter should just be an object that has properties and string values. So you just add to the object and set .frontmatter to it. Same as .content works.
Also in your newNote... I suggest just passing the object of frontmatter as the param
Also I would suggest we have a .bodyContent field which returns just the non-frontmatter content or the whole note if there is none

We can extract the frontmatter through np.Templating's function. Just need
to see how easy that is and if the performance won't suffer. There might be
DataStore calls where we loop through a lot of notes and the frontmatter
has to be generated..., oh what if we just generate it when it's accessed!
I.E. the getter method gets called.
And what about setter? That could be muuuch trickier. I need the ranges of
the frontmatter attributes to be able to change them. I think that
functionality is missing in templating.
On Fri, May 27, 2022 at 10:20 AM David Wertheimer @.***>
wrote:

Couple of thoughts:
Not sure we need the addOrUpdateFrontmatterField because frontmatter
should just be an object that has properties and string values. So you just
add to the object and set .frontmatter to it. Same as .content works.
Also in your newNote... I suggest just passing the object of frontmatter
as the param
Also I would suggest we have a .bodyContent field which returns just the
non-frontmatter content or the whole note if there is none
—
Reply to this email directly, view it on GitHub
https://github.com/NotePlan/plugins/issues/284#issuecomment-1139717804,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZCAYWQPXPTIEZFUSIEEH3VMDR33ANCNFSM5XEAOH7A
.
You are receiving this because you were assigned.Message ID:
@.***>

@dwertheimer, I'm agnostic about the precise functions and calls, so happy to go with suggestions from you and others with more experience of modern data structures.
@EduardMe wrote:

We can extract the frontmatter through np.Templating's function. Just need
to see how easy that is and if the performance won't suffer. There might be
DataStore calls where we loop through a lot of notes and the frontmatter
has to be generated..., oh what if we just generate it when it's accessed!
I.E. the getter method gets called.

Well, you could. But I was suggesting that this is an API call, not using Plugin code. I could write that myself. The reasons are as given in the discord thread, and for me its primarily about making frontmatter a properly supported part of the whole NP system.

And what about setter? That could be muuuch trickier. I need the ranges of
the frontmatter attributes to be able to change them. I think that
functionality is missing in templating.

See above. Surely you only need to be deduce 1 item -- the paragraph that is the end of frontmatter? The start is by default paragraph 0.

That's what I mean, it's an API call, but internally it uses the Templating
code, so we don't have various slightly different implementations.
I'm relatively sure the setter will be more complicated than expected (more
moving parts than the getter). It's very blurry in my head right now.
Probably you want to do something like Note.frontmatter.title = "different title". Then we need to convert the frontmatter object into lines and
write it back at the right position, etc. or overwrite the whole block.
That's probably the simplest method. Here another complication is that the
frontmatter setter is not called directly...
On Sat, May 28, 2022 at 4:08 PM Jonathan Clark @.***>
wrote:

@dwertheimer https://github.com/dwertheimer, I'm agnostic about the
precise functions and calls, so happy to go with suggestions from you and
others with more experience of modern data structures.
@EduardMe https://github.com/EduardMe wrote:
We can extract the frontmatter through np.Templating's function. Just need
to see how easy that is and if the performance won't suffer. There might be
DataStore calls where we loop through a lot of notes and the frontmatter
has to be generated..., oh what if we just generate it when it's accessed!
I.E. the getter method gets called.
Well, you could. But I was suggesting that this is an API call, not using
Plugin code. I could write that myself. The reasons are as given in the
discord thread, and for me its primarily about making frontmatter a
properly supported part of the whole NP system.
And what about setter? That could be muuuch trickier. I need the ranges of
the frontmatter attributes to be able to change them. I think that
functionality is missing in templating.
See above. Surely you only need to be deduce 1 item -- the paragraph that
is the end of frontmatter? The start is by default paragraph 0.
—
Reply to this email directly, view it on GitHub
https://github.com/NotePlan/plugins/issues/284#issuecomment-1140329894,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZCAYW5KH77CBNNZRNSSV3VMKDL5ANCNFSM5XEAOH7A
.
You are receiving this because you were mentioned.Message ID:
@.***>

I wrote enough helpers in NPFrontMatter that I think we can close this ticket.


RFC: Add user-specified parameters for transfer byte limits

This change is a prototype that would add user parameters to NDT7 measurements and archival results. The current implementation is not ready to merge in its current form. This is an RFC.
The current implementation supports the following parameters:

param_close_after_download_bytes_acked - the server will close the websocket conn after observing tcpinfo.BytesAcked greater than the given value.
param_close_after_upload_bytes_received - the server will close the websocket conn after observing tcpinfo.BytesReceived greater than the given value.
param_cubic_download - parsed but not enableable. Included as an illustration of how we could enable this or other options in the future.

In the first two cases, the measurement/observation events depend on the measurer memoryless sample frequency - meaning that the time between actually reaching the BytesAcked or BytesReceived threshold (kernel state) and observing that (ndt-server) could be up to MaxPoissonSamplingInterval (625ms). So, there is a fundamental imprecision around when the server observes and closes the connection; there is no guarantee about how much data is actually transferred, only that it is at least the amount requested.
Currently, the parameter value is in bytes and unconstrained. Ideally, we would limit these values to a fixed set of thresholds, e.g. 1, 2.5, 5, 10, etc..

This change is

Pull Request Test Coverage Report for Build 1562

7 of 38 (18.42%)  changed or added relevant lines in 3 files are covered.
7 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-1.3%) to 80.373%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ndt7/download/sender/sender.go
2
8
25.0%

ndt7/upload/sender/sender.go
2
9
22.22%

ndt7/handler/handler.go
3
21
14.29%

Files with Coverage Reduction
New Missed Lines
%

ndt5/ndt5.go
1
89.5%

ndt5/c2s/c2s.go
2
73.21%

ndt5/protocol/protocol.go
2
83.86%

ndt5/web100/web100_linux.go
2
94.44%

Totals

Change from base Build 1559:
-1.3%

Covered Lines:
1769

Relevant Lines:
2201

💛  - Coveralls

FYI: @bassosimone @robertodauria @mattmathis your comments/feedback are welcome. Regard everything as having a question at the end: "this is how I built a prototype; is there a better way to do this?"

Obsolete


Update the README.md

The readme is a little outdated, and should be updated to reflect the following:

The files that need to be run this year
The fact that shepherd now has a docker image
The shepherd startup script

remove docker now lmao


[#133036569] Fix TF destroy for Metrics ELB.

What
The destroy failed because both listeners were referencing the same policy.
Destroying the first resource failed because it attempted to delete the
policy as well as the attachment, but the policy was still in use by the
other listener.
Using a policy per listener avoids this conflict.
How to review
Deploy from this branch as far as cf-terraform. Run the destroy-cloudfoundry pipeline, and verify it succeeds.
Who can review
Anyone but myself.

Can't really argue with this, lgtm


Request for screenrec website.

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://screenrec.com/share/fNJv3FY2Rt

Description

It would be so helpful if the website "screenrec.com" gets added to youtube-dl supported website list.

From the example given this should be easy, a good first extractor exercise.
The extractor needs a_VALID_URL such as r'https?://screenrec\.com/share/(?P<id>\w+)'.
The page contains a <script> element with a video URL that can be found with a suitable regex, say r'''\{\s*customUrl\s*:\s*'(https?://[^']+)'\s*,''', like this:
					<script>
						var playerIframe = document.getElementById('player_iframe');

						function playerInit() {
							sendMessage('init', {
								customUrl: 'https://upww.screenrec.com/videos/f_9GEsBMfidW7cvLnQKPm3Y5UFlwDHCurx.mp4/index.m3u8',
								...
							});
						}

As the URL is of M3U8 type, the _extract_m3u8_formats() method can be used to process it.
Finally title, description, thumbnail should be available through the corresponding _og_search_xxx() methods.

I am sorry but I am not good enough to perfectly execute this. Can you please elaborate in simple thanks. Thanks and sorry for troubling you in advance 😁

I hope someone will address your requirement soon, following my suggestions. Unfortunately there are a lot of issues and pull requests waiting to be processed.


Add ability to filter out unwanted premutations

I propose to fix https://github.com/autonomio/talos/issues/223 by this pull request
The code is used like
talos.Scan(
    ...
    ,premutation_filter=lambda p: p['hidden_layers']<3 or p['first_neuron']<10)

I have tested locally but not added any tests

Hello @JohanMollevik! Thanks for submitting the PR.

In the file talos/parameters/ParamGrid.py, following are the PEP8 issues :

Line 6:1: E302 expected 2 blank lines, found 1
Line 26:9: E303 too many blank lines (2)
Line 38:80: E501 line too long (85 > 79 characters)
Line 44:24: E225 missing whitespace around operator
Line 44:51: E231 missing whitespace after ','
Line 44:67: E231 missing whitespace after ','
Line 44:80: E501 line too long (85 > 79 characters)
Line 46:9: E731 do not assign a lambda expression, use a def
Line 46:11: E225 missing whitespace around operator
Line 46:20: E231 missing whitespace after ':'
Line 46:78: E231 missing whitespace after ','
Line 46:80: E501 line too long (81 > 79 characters)
Line 47:46: E711 comparison to None should be 'if cond is not None:'
Line 48:25: E225 missing whitespace around operator
Line 48:40: E231 missing whitespace after ','
Line 49:28: E225 missing whitespace around operator
Line 50:37: E225 missing whitespace around operator
Line 51:39: E225 missing whitespace around operator
Line 51:80: E501 line too long (102 > 79 characters)
Line 51:84: E225 missing whitespace around operator
Line 52:41: E225 missing whitespace around operator
Line 53:44: E225 missing whitespace around operator
Line 54:45: E225 missing whitespace around operator
Line 55:32: E225 missing whitespace around operator
Line 55:59: E231 missing whitespace after ','
Line 55:80: E501 line too long (102 > 79 characters)
Line 55:84: E231 missing whitespace after ','
Line 56:29: E225 missing whitespace around operator
Line 56:44: E231 missing whitespace after ','
Line 57:32: E225 missing whitespace around operator
Line 58:28: E225 missing whitespace around operator
Line 70:32: E231 missing whitespace after ','
Line 70:35: E231 missing whitespace after ','
Line 70:51: E231 missing whitespace after ','

In the file talos/parameters/round_params.py, following are the PEP8 issues :

Line 3:1: E302 expected 2 blank lines, found 1
Line 3:28: E231 missing whitespace after ','
Line 12:1: E302 expected 2 blank lines, found 1
Line 31:35: E231 missing whitespace after ','
Line 32:1: W391 blank line at end of file

In the file talos/scan/Scan.py, following are the PEP8 issues :

Line 155:32: E225 missing whitespace around operator

Pull Request Test Coverage Report for Build 387

23 of 34 (67.65%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 90.286%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

talos/parameters/ParamGrid.py
13
24
54.17%

Totals

Change from base Build 386:
-0.5%

Covered Lines:
1106

Relevant Lines:
1225

💛  - Coveralls

What is your thoughts on this? Is the code acceptable as is? Regarding the tests, am I right in thinking that the issue it complains about is coverage?

What is your thoughts on this? Is the code acceptable as is? Regarding the tests, am I right in thinking that the issue it complains about is coverage?

You are right,  it is because of coverage. So ideally, because we are below 100%, the coverage should remain same or rise a little (i.e. some new test comes as a byproduct). For adding a new feature, it's definitely good idea to add a test for it. Could you do it, and I will review the changes in the meantime.

Related with testing, when creating new tests, it's also a good idea to check the coverage report and use other parameters in Scan() (or which ever command is invoked) which do not already have coverage (or have few hits).

Ok, I will create a test for this.

Great :)
Also check out the pep8speaks report above for flags on pep8 violations. I've followed an approach where otherwise its strict pep8, but if lines are barely longer than the allowed 80, then let it be. If it's longer, then split as the first-line measure split the code into several commands, and if that is not possible, only then use \.

By the way, if I understood correctly, I think that this feature will be very useful as part of "reducers". As far as I collect, we could have a reducer say "drop anything with first_neuron > 5 where also batch_size < 128". Is it correct?

Yes, that is exactly the use case for it

It looks like the test takes a long time.

Right that is why I do not see any test results, I will fix that

Is there any way to get it to report any ramaining pep8 errors? The list at the top is a bit out of date

Are there any way to kill the running tests to let the fixed one run?

It's killed. I could do it when I'm logged into Travis.

One long running test still running? Can you kill that and restart the current one?

Done. For future reference, it was not first apparent where to do it (it was hidden). Have to click through the PR, and only after then it became visible. On the top view it appeared as if nothing was running.

I've cancelled the build because it wanted to go through 16000 permutations (as opposed to 22000 before).

I think this will be good:
    def test_scan_iris_3(self):
        print("Running Iris dataset test 2...")
        Scan(self.x, self.y, params=p3, dataset_name='testing',
             experiment_no='000', model=ta.templates.models.iris,
             premutation_filter=lambda p: p['first_neuron'] * p['hidden_layers'] < 9,
             last_epoch_value=True)

This should yield exactly 2 permutations and will be in line with the other tests.

Sorry for all the commits, hopefully this works

Hmm, got another error, should I squash the commits once I get the tests to pass to avoid poluting the commit log when merging

No worries, it's fine if you think it's getting close :)
For future, once you add the test, it's best to run  test_script.py locally and once it pass then push. When I'm adding something new, or make change to the mainline code, I usually leave test_script.py running like so:
while :
do
    python test_script.py
done

...I might leave it running for an hour or two. But I don't do that for minor changes. Then I just run once locally before push.
Sometimes there are "random" bugs that appear only when certain circumstances are present, so this works towards that end.

I tried to run locally but got errors in the tests where they expected tensorflow to be installed, I'm runing cntk so that prevented me from running the tests.


Upgrade provider to 3.x version

Is your feature request related to a problem?
Hashicorp releases a new version of AzureRM provider 3.0, based on what is changed upgrade process should be easy.
Also they post couple of information:
Note: Version 3.0 and 3.x versions of the AzureRM provider will be the last versions compatible with Terraform 0.12 - 0.15.
When upgrading to v3.0 of the AzureRM Provider, we recommend upgrading to the latest version of Terraform Core  - the next major release of the AzureRM Provider (v4.0) will require Terraform 1.0 or later.

Describe the solution you'd like
Upgrade existing codebase to never version of AzureRM provider.

Describe alternatives you've considered
We can wait for version 4.x but I think that if we adopt early to the most recent version, we will be ready for the potential features to come with version 3.x.

Additional context

+1 to this issue

+1 - any update on this?


Update default logo for token and network on some screens

Describe the task
Update default logo for token and network on some screens

[x] On Send fund feature

[x] Select token screen on Receive feature

[x] Token details screen

Version test : http://<IP_ADDRESS>:8900/s/9nP6PwPCyCAEiHw
Validation passed in case :

On manage token screen

On token detail screen

On Manage network screen

On Home screen with custom token and defaul token ( Rune, BRC20, token EVM)

On receive token screen

On send fund feature

On collectibles feature


Add low level realtime routing table builder

Add a new routing table builder for the low level consumer. It's not
tested yet and needs a unit test.

Please add some unit tests for the two methods ;)

Of course :)

[Current coverage][cc-pull] is 37.03%

No coverage report found for master at ef78c3f.

Powered by Codecov. Last updated by [ef78c3f...be54e8a][cc-compare]
[cc-base-branch]: https://codecov.io/gh/linkedin/pinot/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/linkedin/pinot/compare/ef78c3f0acb287a7238c08dfaa102d4641c1ae00...be54e8a3cb3f81ca691e9e362cca956afe9f1fb1
[cc-pull]: https://codecov.io/gh/linkedin/pinot/pull/210?src=pr

Unit test passing depends on #214

Please use the new classes checked in for low level consumer segment names, thanks.

LGTM otherwise


privileged containers get unintentionally constrained by apparmor

For normal containers docker will put the container in the docker-default profile.  For privileged containers, no profile is applied and the process is unconfined.  Since the container is unconfined, the child processes are subject to getting a profile from the host auto applied base on the binaries path.
To see this happen, on ubuntu, install tcpdump and apparmor on the host.  Then install tcpdump in a privileged container.  tcpdump in the privileged container will not run.
It seems the correct fix would be to create a "docker-unconfined" profile that is applied to privileged containers.  The profile would not actually restrict anything, but allow all.  The only purpose of using this profile is to prevent the host from auto applying profiles to container processes.

@ibuildthecloud is this still an issue, did we end up fixing the profile?

@ibuildthecloud @jfrazelle   could we solve this issue on release 1.6?

I've put together a change for this, although I need to test it before submitting the PR:
https://github.com/ewindisch/docker/commit/d45be4e65288f2978dfedd4a940f3debe128fd35

#dibs

@ewindisch any progress on testing your change for this?  I'm a bit stuck trying to get NetworkManager to run in a u14.04 container on a u14.04 host due to this problem, so I'm trying out your change right now.  I'll let you know how it goes.

The patches from @ewindisch don't seem quite right anymore, and I'm out of sync on where AppArmor things are moving.  I did manage to get around my problem by applying his one-line change to have privileged containers use the "docker-unconfined" profile, rather than "unconfined", and then I put this profile in /etc/apparmor.d/docker-unconfined:
#include <tunables/global>

profile docker-unconfined flags=(attach_disconnected,mediate_deleted) {
  #include <abstractions/base>
  network,
  capability,
  file,
  umount,
}

I don't know all the implications, but that's what finally worked for me last night.

@bprodoehl thank you for confirming that this solves the problem. We have a series of apparmor related changes, of which this is closer to the bottom. Once we merge those, I'll officially propose this fix.

@ewindisch great, thanks!

@bprodoehl  Can you please provide more details on your solution? I got stuck with the same problem, but I am not expert to immediately know how to modify similar to you.
Thanks

@imehrdad2012 the easiest way around it is to relocate the affected binaries in the container. Is that an option for you? Otherwise, you'll have to compile and install your own docker binary. I can post more detail on what I did, but if you can just relocate tcpdump or whatever isn't working in your container, that's a pretty easy fix.


Query engine binary for current platform "debian-openssl-1.1.x" could not be found.

I get the following error when running a simple Prisma query:
Invalid `prisma.profile.create()` invocation in
/home/cray/WebstormProjects/backend/build/db/dao/Profile.js:21:35

Query engine binary for current platform "debian-openssl-1.1.x" could not be found.
This probably happens, because you built Prisma Client on a different platform.
(Prisma Client looked in "/home/cray/WebstormProjects/backend/build/db/prisma/generated/client/runtime/query-engine-debian-openssl-1.1.x")

Files in /home/cray/WebstormProjects/backend/build/db/prisma/generated/client/runtime:

  index.js
  index.js.map

You already added the platform "native" to the "generator" block
in the "schema.prisma" file as described in https://pris.ly/d/client-generator,
but something went wrong. That's suboptimal.

I've attempted to recreate it but it works in a new project.
The only way I've found to fix it is to remove the "output" block in schema.prisma and importing Prisma with "@prisma/client"
generator client {
  provider      = "prisma-client-js"
  output        = "generated/client" //this causes it to fail
  binaryTargets = ["native"]
}

Maybe a possible clue is the fact that "query-engine-debian-openssl-1.1.x" isn't in the "runtime" folder like the error message suggests. It's in the root folder.
.
└── client
    ├── index.d.ts
    ├── index.js
    ├── package.json
    ├── query-engine-debian-openssl-1.1.x
    ├── runtime
    │   ├── //... *.d.ts files
    │   ├── highlight
    │   │   ├── //...
    │   ├── index.d.ts
    │   ├── index.js
    │   ├── index.js.map
    │   ├── mergeBy.d.ts
    │   ├── query.d.ts
    │   ├── transformDmmf.d.ts
    │   ├── utils
    │   │   ├── //...
    │   └── visit.d.ts
    └── schema.prisma

But since it works on a fresh project, I'm not sure how that could be the problem.

Right after typing this, I realized I was 'treeing' inside my development folder and not the build folder.
The problem is that "query-engine-debian-openssl-1.1.x"  isn't being copied to the 'build' folder when Typescript compiles. (Neither is schema.prisma). Copying them there manually fixes my problem.
I'll find a way to copy them over.


Website with working ipv4 address, and non-responsive ipv6 address, will show as "down" on monitor

📑 I have found these related issues/pull requests

https://github.com/louislam/uptime-kuma/issues/1242 and
https://github.com/louislam/uptime-kuma/issues/4914 seem to be related, but both don't address my issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
No response
👟 Reproduction steps

Have a website with both an A and AAAA record
Have the IP behind the A record be responsive, but the IPv6 behind the AAAA record be unresponsive

👀 Expected behavior
Uptime-kuma would happy-eyeballs (or similar) both IP addresses resolved behind the domain name, and try to hit either.
😓 Actual Behavior
The HTTP request fully fails, and times out.
🐻 Uptime-Kuma Version
1.23.13
💻 Operating System and Arch
Debian 12, Docker
🌐 Browser
Arc
🖥 Deployment Environment

Runtime: Docker 20.10.24+dfsg1
Database: Sqlite
Filesystem used to store the database on: EXT4
number of monitors: 44 (incl. groups)

📝 Relevant log output
No response

The node version shipped in v1.23.x does not have happy eyeballs support.
v2.0 bumps that to a version that includes happy eyeballs and should resolve this issue.
See #4500 for further details what needs to happen before we can publish that release.
Since this is likely resolved in v2.0 I am going to close the issue as resolved.


GRANT permission to User, not Login

Under Permissions, Item # 3 states that exec permission needs to be granted to a login. This is incorrect. Permission can only be granted to a user, and there is a difference.
Take care,
Solomon...
https://SqlQuantumLift.com/
https://SqlQuantumLeap.com/
https://SQLsharp.com/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cae5e224-054d-8787-6b4d-5259a9057f9f
Version Independent ID: 7c782643-2e58-de1b-b430-8f3ea38ec4c1
Content: xp_cmdshell (Transact-SQL) - SQL Server
Content Source: docs/relational-databases/system-stored-procedures/xp-cmdshell-transact-sql.md
Product: sql
Technology: system-objects
GitHub Login: @CarlRabeler
Microsoft Alias: carlrab

Please see PR #3720 for additional details and demo code.


cleanup Nodejs env var checks examples

Description of change
Added a list of env for iteration as done in the python cleanup
Links to any relevant issues
fixes #1359
Type of change

Bug fix (a non-breaking change which fixes an issue)

How the change has been tested
Ran unit tests locally.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have checked that new and existing unit tests pass locally with my changes

Hello, thanks for your PR!
Please do the changes to the develop branch, 1.1 has been released already and the branch will be removed soon.

Sorry it is just so confusing, i changed the files locally but weren't able to see the changes here so yeah that's why it took so much time in an easy thing...

No worries, thanks for your PR!


ALIAS syntax, can't use single quotes

In DuckDB I cannot do this:
sqlite> select region as 'my region' from bigsales limit 10;
Error: Parser: syntax error at or near "'my region'" [18]
However in sqlite3 this is no problem:
sqlite> select region as 'my region' from sales limit 10;
Sub-Saharan Africa
Middle East and North Africa
Australia and Oceania
I know I can use double quotes in DuckDB (and in sqlite3), the reason I'm asking, is because I'm generating dynamic sql and I have to escape the double quotes with backslash in the generated sql and later remove the backslash, could be much simpler if I could use quotes like in sqlite3!

Interesting, I didn't know that this worked in SQLite. I will have a look to see if I can add it.

We also have some users that use this syntax, so this would be helpful! So far, I have just dissuaded them by reminding them that it isn't good, standard SQL! :-)

So I had a look and it seems easy for me to add it to the parser as long as the AS clause is used, i.e. this would work:
select region as 'my region'

But this would not:
select region 'my region'

The reason for that is that it causes ambiguity in the parser. e.g. if you have the following statement:
select region ! 'my region'

It is not clear if 'my region' is an alias to the expression region !, or if it is a single expression region ! 'my region' without an alias.
Would only adding support as long as "AS" is used be acceptable?

That is the most common pattern I've seen with our SQLite users, so that would work well for me!

yes, only for 'AS' would work for me !

Should be implemented now in the master :)


Union types with enum and class not working property

From what I understand, the following should work but it is generating errors:
           export class FilterExpression {
                constructor();
                constructor(FilterOperator: LogicalOperator);
                constructor(public FilterOperator?: LogicalOperator) {
                    if (FilterOperator == null) {
                        FilterOperator = LogicalOperator.And;
                        this.Filters = new Array<FilterExpression>();
                    }
                }
                Filters: Array<FilterExpression>;
                AddFilter(p: LogicalOperator | FilterExpression): void {
                    var Filter:FilterExpression = null;
                    if (typeof p === "LogicalOperator") {
                        Filter = new FilterExpression(p); //Generates an error here
                    }
                    else if (typeof p === "FilterExpression") {
                        Filter = p; //Generates an error here
                    }
                    this.Filters.push(Filter);
                }
            }

            enum LogicalOperator {
                And = 0,
                Or = 1
            }

If I change it to this then I don't get any errors
                AddFilter(p: any): void {
                    var Filter:FilterExpression = null;
                    if (typeof p === "LogicalOperator") {
                        Filter = new FilterExpression(p);
                    }
                    else if (typeof p === "FilterExpression") {
                        Filter = p;
                    }
                    this.Filters.push(Filter);
                }

You need to use instanceof with classes, not typeof. For enums these are not narrowed at all. You have to consider how the generated JavaScript works with these operators. typeof p is never going to return LogicalOperator or FilterExpression so the type system doesn't allow this to work. These are the results:
>var op = LogicalOperator.And;
undefined
>var f = new FilterExpression();
undefined
>typeof op;
"number"
>typeof f;
"object"

where as f instanceof FilterExpression will return true and so TypeScript will narrow the union type via that kind of type guard. You may need to just use a set of constant numbers rather than an enum if you want to use type guards like this.

Another way to write this, keeping enum (with a few code simplications too):
export class FilterExpression {
    constructor(public FilterOperator = LogicalOperator.And) {}

    Filters: Array<FilterExpression> = [];

    AddFilter(p: LogicalOperator): void;
    AddFilter(p: FilterExpression): void;
    AddFilter(p: any): void {
        if (typeof p === "number") // enum
            p = new FilterExpression(p);
        this.Filters.push(p);
    }
}

Thanks for the info!  I figured I was probably doing something that wasn't meant to be done.  I really appreciate the last code snippet!!!  That is definitely the route I will go.  Thanks again!

Actually there is a bug that's preventing this from working correctly, see #1718.
The solution proposed above is problematic because there is no narrowing of p to number:
p = new FilterExpression(p.foo); // would still work because p is `any`

Once the bug fix is released one should be able to write
    AddFilter(p: LogicalOperator | FilterExpression): void {
        if (typeof p === "number")
            var x = new FilterExpression(p); // Safer
        this.Filters.push(x);
    }


run the aesthetic_scorer.py

nice job! I want to use the aesthetic_scorer.py  to test the aesthetic scorer about my images.
But i came across some problems, can you give me some useful advice?
code:

the code is wrong prehaps beacuse of the input_image format.
can you tell me what should i process the image before generate the aesthetic scorer

you can follow this function:
https://github.com/mihirp1998/AlignProp/blob/b519ad87484cdafcfca761013928e59a3fac0923/main.py#L89


ANR observed during Recaptcha SDK initialization in Application.onCreate

Describe the bug
During the initialization of the Recaptcha SDK in the Application.onCreate method, we are experiencing a significant number of ANRs. The ANRs seem to predominantly occur during the call to Recaptcha.getClient().
reCAPTCHA Site Key
[Please fill in your site key here]
Integration Method

[x] GMaven (Android)

SDK Version (e.g. 18.0.1):
18.2.1
To Reproduce
Unfortunately, we do not have specific steps to reproduce this issue as it seems to occur randomly across various devices and OS versions. However, the common factor is the initialization of the Recaptcha SDK in the Application.onCreate method with the call to Recaptcha.getClient().
Expected behavior
We expect the Recaptcha SDK to initialize without causing any ANRs or disruptions to the application's lifecycle.
Screenshots
[If you have any relevant screenshots, please attach them here]
Device (please complete the following information):

Model: SM-A405FN (Example device where ANR was observed)
OS: Android 11 (SDK 30)
Real Device

Additional context
The integration of Recaptcha SDK is the primary change in our recent app updates, and the surge in ANRs correlates with this. We hope the team can provide insights or potential resolutions to address this issue.
source_65398c12e4b025bb02f7451d.log

Unfortunately the ANR here is occurring in the initialization of an internal WebView.  We have consulted with the WebView team and unfortunately ANR's related to WebViews initialization are generally "unactionable".  There may be a lot going on in the main thread of the application, the device may be somewhat slow due to contention, etc.
Can you provide more data on how often this occurs?  Also, have you noticed any patterns related to the ANRs (devices, API level, etc).
You could possibly try shifting the initialization of the SDK to slightly later in your application startup to see what happens.

Is there any progress?
We're having problems with getClient since we implementented reCaptcha Enterprise for the first time, starting with 18.2.1.
We've updated to 18.3.0 but the problem still occurs.
As mentioned above in the description of this bug, it happens with all sorts of device models and Android versions.
In our case, getClient is failing somehow in 20-30% of the calls.


When adding new line items to a thing, the id of the barcode item field does not increment correctly

To reproduce:

Go to a page that has an "Add Another Item" on it, such as inventory_adjustments#new
Click on "Add another item" twice, to have three fields total
Inspect the "Barcode Entry" field and note the ID. Compare it to the prior two "Barcode Entry" fields

The first field has a different ID (should be "0") than the latter 2 (shows up as "1") for me.
These should all be unique. It's not incrementing correctly. I've tried a few things on it (thought it might be a scoping issue) without success, and it's out of scope for the issue I'm working on right now.
Criteria for completion:

Each time you click on "Add another item", the ID of the "Barcode Entry" field should be unique compared to the others
A test to prove it works

Relevant files:

/app/views/line_items/_line_item_fields.html.erb
/app/views/barcode_items/_barcode_item_lookup_html.erb

I'll look at this.

Thanks @lizzyaustad . You were totally right, that's what I ended up doing.


Export ApiLibraryKeys for use in client code

This way clients won't have to make their own copy ApiLibrary keys. Not sure if there's a better name than ApiLibraryKeys.
Alternatively a client could extract the type with something like:
type FirstArg<F extends (...args: never) => unknown> = Parameters<F>[0];
type ApiLibrary = FirstArg<typeof useMapsLibrary>;

But I'd consider that a hack. Better to just export the type imho. 🙏

This is actually a fix for a shortcoming in the @types/google.maps package. I already raised that issue in their tracker (googlemaps/js-types#95) but haven't heard back so far. It could be that this will get solved for @types/google.maps and you can import it from there. I would much prefer it that way.
If we implement this in this library, I would prefer to export the entire map as well, but also would like to find a better name for it first (maybe GoogleMapsLibraryMap / GoogleMapsLibraryName? what do you think?)

Hmm. Don't have a good suggestion for naming but your reasoning makes sense. I'll close this PR and hope you get through to @types/google.maps thanks!


tic-tac-toe

I am a beginner!! so I would like to add my small project under hacktoberfest2021.

pls assign me

Hi @Harshit-Poddar90, this is not a generic contribution repository. This means you cannot post a tic-tac-toe project under this repo. The purpose of the repo is to send bulk mails after getting the email addresses from an excel file. I am, therefore, closing this issue. Please go through the README.md file for issues you can contribute to.

Ohk np


Add shortcut keys

This PR is for issues #12, #24 and #27. Other than that, I also updated the user guide accordingly.
As for now, the shortcut keys are as follow:

CTRL + A adds add n/ p/ e/ a/ g/ b/ ra/ re/ s/ t/ to the command box.
CTRL + E adds edit to the command box.
CTRL + D adds delete to the command box.
CTRL + M adds mark to the command box.
CTRL + U adds unmark to the command box.
CTRL + Z adds undo to the command box.
CTRL + L adds clone to the command box.
CTRL + I adds view to the command box.

Welcome any feedbacks and suggestions, especially if you think there is a better shortcut key combinations to use.

Codecov Report
Base: 64.18% // Head: 63.45% // Decreases project coverage by -0.73% :warning:

Coverage data is based on head (cb31b18) compared to base (66b54a4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #147      +/-   ##
============================================
- Coverage     64.18%   63.45%   -0.74%
  Complexity      538      538
============================================
  Files            91       91
  Lines          1999     2022      +23
  Branches        255      255
============================================
  Hits           1283     1283
- Misses          606      629      +23
  Partials        110      110

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/CommandBox.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Allow raw HTTP client access

To allow BigCommerce endpoints that haven't been wrapped to be accessed, we should allow access to the underlying API client objects. This could look something like this:
bigcommerce = BigCommerceAPI(...)
bigcommerce.api_client.v2  # v2 API client
bigcommerce.api_client.v3  # v2 API client

This would require:

Stabilize the API of the private client
Refactor resource objects to share a copy of the client

Maybe SimpleNamespace could be used for the api_client object described above.


Production example: don't expose server.js

In the production setup example, server.js was meant to be placed along with the client-side assets into the dist folder. It's not a good practice, the server.js code may contain sensitive parts that are not meant to be accessible to the public via express.static.

Coverage remained the same at 100.0% when pulling 50e54164075cb50357ba256173b9512a377810e4 on sompylasar:patch-1 into 516ddc63d124cdc79e43af9c4ac5abc7c6d7f8dd on 60frames:master.

@sompylasar well spotted, thanks!


[Webportal] Admin vc list will display all virtual clusters

Now admin vc list will display all virtual clusters in webportal

Coverage remained the same at 51.687% when pulling 05222ddb9779c5f6df20d638a219f47c70c3d904 on canwan/change-admin-vc-list into 64819c75e35edf8dcdc94ed17c71083223da297b on master.


Minor markup fixes for a11y

TIL that the lang attribute on <html> is important, so I fixed that.
I also did a pass with a screen reader on the current site and noticed that demo feels awkward. Tried to improve it, please double-check I’m not doing anything dumb here, @robdodson 😅
The code section feels awkward, too, but I’m not sure how to address that.

Just started reviewing :) :octocat: Sent from GH.

+1 for lang fixes.
I don't think we can use the section role as the ARIA spec recommends against directly using abstract roles (https://www.w3.org/TR/wai-aria-1.1/#abstract_roles). Let's go with region instead.
Also looks like we have a duplicate id on each page, for example:
<ul class="literate demo" id="dash-tabs"> got called out by axe so somewhere else there's a dash-tabs id.
Also we have 200+ low contrast text warnings 😨

Also we have 200+ low contrast text warnings 😨

Yeah, I am aware. I was thinking of addressing those when we have the logo and have to figure out a page design :)

Yeah, I am aware. I was thinking of addressing those when we have the logo and have to figure out a page design :)

sgtm


feat: Add multi task execution capability with a single task-wakeup b…

I was pleasantly surprised by the simplicity and readability of your executor version. However, I was saddened by such things as the lack of the ability to execute several tasks at the same time, as well as the awakening any of task will poll all remaining tasks. So I decided to fix it the best I could.

Amazing! :) glad you enjoyed pushing forward this library


Issues with the makefile - what about a cmake based build system?

Describe the bug
I'm having difficulties using the makefile based build system. Don't get me wrong, Makefile's are very powerful and I've used them for the better part of my active developer's time. So I do not generally dislike Makefiles. But the current makefile has a number of shortcomings that would be much easier to fix in a modern environment like cmake.
Problem's I've found:

If ccache is used for the build, then GCC_TOOLCHAIN_PATH may be set wrongly, because which gcc points to ccache instead of the real gcc in /usr.
The build seems to work against TBB from the Intel oneAPI Base Toolkit, when TBBROOT is set to TARGETDIR/oneapi/tbb/latest/. However a few variables have to be adjusted for that to work. For example, in a few places $$TBBROOT is used where $(TBBROOT) seems more correct, and other similar issues.
I'd like to build without Java, but I fail to see how this can be configured.

There are other similar issues, that would be all easy to implement in cmake, but are quite challenging to implement in Makefiles. Would it be possible to consider a change?

Ok I've just found the individual build targets in the makefile, and they make it at least possible to configure the needed parts, that's quite nice! I could use them to build without Java, and it gives more control if sequential or threaded is wanted.

@emmenlau
Several notes - we would be migrating from make to bazel overtime, so we would skip cmake and would go to next generation build system.  We already have initial bazel support but it's running on Linux primarily for now
Also sequential version of library was dropped - this means less things to control.
As for problems within make system - i don't think they would ever be fixed due to migration to bazel


[WIP] Add nix derivations

I'd like to be able to declaratively specify IHaskell as part of a dev environment using Nix.

Do you have an example of how somebody would use this from Nix?

Currently this PR allows me to run
$ nix-build release.nix -A ihaskell

to generate an ihaskell executable that can then be installed as usual.
That isn't very useful on its own, but it's a good first step towards my eventual goal of being able to run a single command and bring up a notebook with additional dependencies specified as desired. I'm working on that here, and if you were to clone that repo, you would be able to do
$ nix-build ihaskell-nix/
<result path>
$ <result path>/ihaskell-notebook

to open an IHaskell notebook in the current directory.

Perfect, thanks.
It would be very useful to document that in release.nix somewhere.

I was thinking of putting it in the README after I got everything working. Current issues are:

Defining a module in a notebook doesn't work, and complains about a missing *.dyn_o. No idea why this is, although I think it has something to do with the GHC compilation pipeline that IHaskell uses.
The tests don't pass without my seemingly superfluous change. I think this has something to do with the ghc-paths module and how it interacts with the interpreter. Complicating things is the fact that doing a cabal2nix --shell . > shell.nix and running cabal configure; cabal build; cabal install; cabal test seems to work without any issues, as does stack --nix build.

I'd love advice/help with any of these things, because I'm relatively new to Haskell, IHaskell, and Nix :smile:

I decided that this is useful enough without trying to also fix the build and the missing *.dyn_o feature. I will track that in a separate PR.

@vaibhavsagar Is this working with ghc8? Do you have any plan to fix NixOS #22047 ?

@wizzup This does work with GHC 8, and I'm hoping to bring it back in nixpkgs as soon as we get a new release on Hackage 😄


Oracle CONNECT BY and START WITH format errors

When you format SQL:
CONNECT BY
and
START WITH
should be aligned like FROM/WHERE on a new line.

Thanks for report


Add a stdout reporter module

Should be relatively easy, and would allow more powerful testing & solo mining

Hmmm, maybe not stdout per se but writing to a pipe perhaps? Or any file descriptor really. This would allow other applications to consume it.
But honestly, it's probably low priority atm.


Copyright Violation in src/FloatingWindows/ImGUIIntegration.h and src/FloatingWindows/ImGUIIntegration.cpp

I'm the original author of the xsb_public "ImgWindow.cpp" and "ImgWindow.h" of which these files are clearly derived as told by the identical functions containing identical comments and naming practices where code was retained in the ImGUIIntegration.cpp file.
The original code was published under the LGPL, and whilst rights to produce derivatives were granted, it required the maintenance of copyright notices and adherence to the LGPL.
I have since publicly posted permission for derivations to obey the BSD 3 Clause in lieu of the LGPL.  (see https://forums.x-plane.org/index.php?/forums/topic/198665-x-plane-imgui-bindings-copyright-violations/ ).
Please fix your source to comply with one of the two permitted licenses.

As per the discussions on the org you have linked here are we now good or do you still something from us to not be a Copyright Violation.
I am now the head of development and the original author wanted me to make sure I get this fixed so that is what I am trying to do.

Can this now be closed?

Looks good, thanks.


BUG: Locally Optimal Block Preconditioned Conjugate Gradient (LOBPCG) gets worse with perfect preconditioner

Describe your issue.
Adding a perfect preconditoiner to the LOBPCG routine results in worse iteration.
Attached is a detailed jupyter notebook which recreates and visualizes this issue. For matrices with both linear and geometric spectrum separation, we notice severely degraded performance for finding the largest eigenvalues, using an ideal preconditioner derived from a cholesky decomposition.

lobpcg-ex.zip
The literature on this shows:

Preconditioners should improve convergence (Preconditioned Eigensolver LOBPCG in hypre and PETSc, Lashuk, et al. 2007).
Preconditioners may need to be symmetric, linear, and PSD (I verify this in the notebook) (Block Locally Optimal Preconditioned Eigenvalue Xolvers (BLOPEX) in hypre and PETSc, Knyazev, et al. 2007)
More recent results show LOBPCG should even be tolerant to asymmetry of preconditioner (Nonsymmetric multigrid preconditioning for conjugate gradient methods, Bouwmeester et al 2013)

I'm just spitballing here, but for computing largest eigenvalues I can see how preconditioning with A^{-1} might hurt convergence (as the action of A^{-1} should highlight the smallest eigenvectors in the residual for PSD matrices A), though maybe @lobpcg  might know if there's a clear bug in the scipy code that might be causing this issue.
Reproducing Code Example
n = 1000
k = 10
m = 300
kappa = 1000
np.random.seed(1234)
X = np.random.randn(n, k).astype(np.float32)
A = np.diag(np.linspace(1, kappa, n)).astype(np.float32)
f = scipy.linalg.cho_factor(A)
Linv = scipy.linalg.cho_solve(f, np.eye(A.shape[0]))
Linv = (Linv + Linv.T) / 2
for M in [None, Linv]:
    _, _, hist = scipy.sparse.linalg.lobpcg(A, X, maxiter=m, M=M, retResidualNormsHistory=True)
    print('precond? ', M is not None, 'best residual', min(np.array(hist).max(axis=1)))

Error message
# prints
# precond?  False best residual 2.5630512
# precond?  True best residual 9.13194302949972

SciPy/NumPy/Python version information
1.8.0 1.21.5 sys.version_info(major=3, minor=9, micro=10, releaselevel='final', serial=0)

The goal of the preconditioner M is to improve the condition number of the matrix M(A - lamba I) where lamba is the seeking eigenvalue and the null space is ignored.
The ideal preconditioner is the pseudo inverse of (A - lamba I).
If A>0 and lambda is the smallest, M=inv(A) is a good preconditioner  compared to the trivial M=I, since lambda is close to zero, informality speaking.
If A>0 and lambda is the largest, as in the example, M=inv(A) is a poor preconditioner  compared to the trivial M=I, as the example  demonstrates.
It surely is not a bug of the code.

That makes sense! I think I was needlessly carrying over my notion of a preconditioner for unshifted PCG.
In that case, for k > 1, we'd presumably want more than one preconditioner, M(lambda), to apply to the corresponding residuals based on the intermediate Ritz eigenvalues, correct?

Within the block, lambdas may be close enough to ignore the fact that they are different, practically speaking.


[add-resource] New Plugin: Yandex Turbo

I would like to add my new plugin to the Grav Repository.
Here are the project details: https://github.com/dragomano/grav-plugin-yandex-turbo

Apologies for taking so long to get this added to GPM. We do have plans to finish up our 'new gpm' solution that would not cause these bottlenecks.  But have a few things ahead of that first.
Added now, and should hopefully show up in the next hour.


feat!: add SingleCollapse component

Commit message should contain a line with BREAKING CHANGE, since a component is removed. This will trigger the necessary major version bump.

Commit message should contain a line with BREAKING CHANGE, since a component is removed. This will trigger the necessary major version bump.

This should be solved handeld by the "!" after the "feat", shouldn't it?:
BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type.

source: https://www.conventionalcommits.org/en/v1.0.0/

feat!: add SingleCollapse component does not tell me what broke.

feat!: add SingleCollapse component does not tell me what broke.
That makes sense, of course. I have changed it accordingly


Cql4bonnie qdm5 3 453

JIRA Ticket: https://jira.mitre.org/browse/BONNIE-453
Unit tests included so no JIRA tests.
UI Demo:

NOTE:
patient_builder_spec.js.coffee looks like it has a lot of changes, but it is just an indentation change to separate QDM and CQL tests.

if you click on the "files changed" tab above, and append "?w=1" to the end of the url, whitespace is ignored. You can't make comments, but it is a useful tool to show you only the non-whitespace changes.

Unit tests pass, only cosmetic changes remain.


Search has duplicate results (normal + unstable)

Context & versions
After fixing basic operation of the Algolia crawler and search in #1556, we get results listed twice.
Steps to reproduce

Search for "offline"

Actual behavior
Duplicate links into the various sections

Expected behavior
Only present results from /unstable when we are on /unstable.
Ideally, the results should also be ranked in a way that user manual and docs come before ADRs, tests or haddocks.

When using the search query "limits" we don't have the unstable/normal search results, but even mangled URLs which are not accessible. For example: https://hydra.family/head-protocol/unstable/head-protocol/docs/known-issues/#head-protocol-limits


office-addin-lint: support TypeScript 3.7

Any idea what's causing the one test to fail on Windows for office-addin-usage-data?

The test is timing out.
  1) Test office-addin-usage data-package
       Test groupNameExists method
         should check if groupName exists:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\agents\opx-azure-03\_work\1\s\packages\office-addin-usage-data\test\test.ts)

Looks like the test succeeded after I updated the branch with changes from master.


srs: Make SupportedSRS iterable

This resolves an issue with the demo service, which expects an iterable list of SRSs: https://github.com/mapproxy/mapproxy/blob/bc9e7dbcf3900e29066c927c04273da14e584fcc/mapproxy/service/demo.py#L142-L145
from WMS Source:
https://github.com/mapproxy/mapproxy/blob/bc9e7dbcf3900e29066c927c04273da14e584fcc/mapproxy/config/loader.py#L574-L580

Thanks for the fix. Closes #430


Fix OutputBuffer comments regarding bufferedBytes_

Address the outdated comment in #8348 that renamed totalSize_ to bufferedBytes_.
CC @xiaoxmeng

@xiaoxmeng Could u help merge it? Ty!


Support Ruby 3

Ruby 3 contains a number of changes:
https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
However, the only relevant change appears to be:
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
This PR changes the CircleCI config to support Ruby 3, but also refactors the config.
It's unclear to me why the old checks are still Required - maybe due to some GitHub project settings?

Hi, I made copious inline comments.
Also: yay! A great move to begin using the Ruby Orb better.

In order to use this, I will move forward without fixing the pointed-out YARD annotations.

In order to use this, I will move forward without fixing the pointed-out YARD annotations.

Cool thanks, makes sense. I saw your comments about YARD but did not have time to go through them all.


Bundle _templates in the pip installable theme

There are 4 _templates for autosummary that are missing in this package, and once the theme is pip-installed the output misses a few things. In the case of using  autosummary on a module, the classes will be included but their members will not.
Ideally these templates should be bundled in this pip installable package.

there seems to be no (documented) way of doing this. however, i will update the COMPAS package template such that the files are included there.
@gonzalocasas any other ideas?

I looked around, but also couldn't find any way to bundle these. And I didn't find any other theme that would do anything related to that. Are we misusing autosummary perhaps?

as far as i know this is meant to be "up to the developer". however, i noticed that our package templates include those autosummary stubs. so perhaps the easiest solution is to just use the templates, no?

this is solved since version 0.13

this is solved since version 0.13


Permission denied mac m1

Hey there. Trying to run embed Mongo in test environment but got stuck with this error:

Caused by: java.io.IOException: Cannot run program "/var/folders/yq/3bks5dkx1p5_87g951sn793c0000gn/T/extract-49a723c3-cedd-4d27-932a-5b5ce1211066extractmongod": error=13, Permission denied

I scrolled all the issues before, tried to set de.flapdoodle.embed.io.tmpdir (with System.setProperty)) and even the TMPDIR env variable to another folder. Unfortunately, the output is the same but with the another folder.
Version of flapdoodle.embed: 2.2.0
Spring boot: 2.2.6
OS: MacOS (M1 chip)

@NorthlaneKek you are using a old version as you are using spring 2.2.6 .. and flapdoodle 2.2.0 .. is there any way to upgrade to at least spring 2.6.x?

@michaelmosmann unfortunately, I'm not able to upgrade spring right now

@NorthlaneKek ,.. hmm..  flapdoodle 2.2.0 is quite old and there was a lot of refactoring done.. you can try to upgrade flapdoodle.mongo up to 3.5.4 and see if this works somehow.. and if 3.5.4 does not work make a step back until you get the newest version possible.. anything newer (>=4.x.x) will not work (or it would be a big surprise for me).
I guess that macos is preventing the execution of a binary inside of a temp folder.. so even with newer versions this problem might stick.

@michaelmosmann sorry for the late response.
I bumped up the version of the lib to 3.5.4 as you said and there appeared the exception:
Could not find class [de.flapdoodle.embed.process.config.IRuntimeConfig]
I resolved it by adding (exclude = EmbeddedMongoAutoConfiguration.class) to the @SpringBootApplication annotation.
But, it seems that mongo server doesn't even starts up now. All I can see in logs related to mongo is exceptions like:
Exception opening socket

@NorthlaneKek I am not sure if I can backport all the changes to this spring version ... I must think about it...

@michaelmosmann oh, probably, it's my fault. I think it's better to make it clear now

2.2.6 is the version of spring boot (spring itself is 5.2.5)
seems like I put this issue in the wrong repository: I'm using de.flapdoodle.embed.mongo, not de.flapdoodle.embed.mongo.spring
other teammates are not facing such problems with the same version of lib (2.2.0), spring (5.2.5) and spring boot (2.2.6)
if I use higher version of the lib (3.5.4) I see that embedded Mongo Server simply doesn't even try to start (maybe this version should be configured somehow the other way)

@NorthlaneKek .. the spring versions are kind of .. missleading.. the mongodb integration is part of the spring boot project.. and i have some integrations for 2.6.x, 2.7.x and 3.0.x. This all started because spring wrote the first integrations by themself.. but misunderstood some parts of it. So i started to struggle with their misuse of "functionality" up to a point where any refactoring needed was not possible anymore. So i started to providing my own integration and spring stopped their integration with spring boot 3.0.0. ... some background for this.

other teammates are not facing such problems with the same version of lib (2.2.0), spring (5.2.5) and spring boot (2.2.6)

Same system? MacOS with M1?

if I use higher version of the lib (3.5.4) I see that embedded Mongo Server simply doesn't even try to start (maybe this version should be configured somehow the other way)

yeah.. there was a lot of api change needed to fix bugs and extend functionality ..
I think i try to make an backport to spring boot 2.2.0 and see if this works somehow.

@NorthlaneKek

Caused by: java.io.IOException: Cannot run program "/var/folders/yq/3bks5dkx1p5_87g951sn793c0000gn/T/extract-49a723c3-cedd-4d27-932a-5b5ce1211066extractmongod": error=13, Permission denied

you can try to start the executable by yourself to see if you can fix this with setting the needed permission OR as you are using an M1 some emulation setup is needed as the mongodb binary is (if you are not using something newer .. like 6.x.x.) for an x86 cpu.

@michaelmosmann actually, as a more fast way to avoid all exceptions is to start mongo db in a docker container to pass all the tests (everything runs ok)
With 3.5.4 version I don't even see any mentions of "permission denied" exception. All I can see is that my application is unable to connect to localhost:27017 (and it's obvious because the application didn't even try to start the embedded mongo server and that's why there is no any 'permission denied' problem anymore)

@NorthlaneKek i think spring failed to start the integration and eats most of the exceptions around it..
.. one way to go could be https://www.testcontainers.org/ ..
so if you are happy with your solution we could close this issue.. if not, it is easy to reopen.

@michaelmosmann it would be really great to find out any other solutions to run embed mongo server, because I'm the only one in the team who faces this problem. Of course, I can use testcontainers or something like this, but it's not really convenient :)

@NorthlaneKek ok.. i will try.

@NorthlaneKek my first attempt to backport it to 2.2.x failed .. so any solution will be a lot more tricky.. don't expect anything in the next two tweeks..

@michaelmosmann I spotted a pretty similar error here: https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo/issues/422
and I saw you gave a link: https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo.spring/blob/spring-2.7.x--embed-mongo-4.x/src/test/java/de/flapdoodle/embed/mongo/spring/autoconfigure/AutoConfigFirstIsolationTest.java
But now it shows 'not found content'
What exactly did you recommend?

@NorthlaneKek .. the problem is here: the mongodb project changed the way how they store their archives for windows/macos/linux.. and the version you are using relies on the "old way" which stopped working with newer versions of mongodb, because the paths for the download are now different.. and not every version is supported on every platform..
so i had to solve this somehow .. and to solve this i had to change many other things..  so the old version you are using my work somehow in some cases.. but sometimes not anymore.. to fix this will be some kind of .. interesting.

@NorthlaneKek i did not had enough time for a second try to backport this stuff to spring 2.2.x .. and i am afraid that there will be no further progress this week.. (just busy)

@NorthlaneKek i guess this is still an issue.. but i did not find a way to backport this stuff.. if i can help in any other way, just ask.


Automation

Once viable classifier exists, potential to automate mapping process

Automating the mapping process sounds like a good idea, but if we take that route, we must do so with caution. I would recommend reading the Automated Edits page on the OSM wiki as well as the Automated Edits Code of Conduct.
I don't think creating new buildings would be difficult to revert (i.e. it would probably be okay with the code of conduct), but we certainly need to make sure we do not create new buildings that don't actually exist or new buildings that already exist on the map.
With what our program is doing, all of our edits need to be human-verified. It might be better to have users verify their edits by clicking on the buildings from the imagery, which forces them to visually check to make sure they are doing what they want to do.


fix(registry): explain PORT is required when using private registry information

docs LGTM assuming https://github.com/deis/workflow/pull/289#discussion_r66313671 and https://github.com/deis/workflow/pull/289#discussion_r66313726 are done

Fixed


Any tutorials on how to use this updated unlocker?

It's not released and still being worked on. So no instructions at the moment. It may actually be incorporated into the Go based Unlocker rather than this repo.

Thanks, much appreciated


fix: Invert LED mode aligns text off side of display

Fixes #890 and #896
Changes:

Fixed invert LED mode wrong alignment. In development version, it was always aligning to the left, and for Google Play version, it was aligning to the right. Now, the text with invert LED mode is centered properly.
Added documentation for handleInvertLED(hexStrings, isInverted) method to help understand what it does.

Screenshots for the change:
https://github.com/fossasia/badgemagic-android/assets/52531091/93f2ff49-910c-492b-ad03-2484906c19ec

@mariobehling Please review.


LoopingStream -> MultiUseStream

The name came from https://github.com/FabricMC/yarn/pull/338#discussion_r242899941
The comment is correctly describing the functionality, the class allows using a stream multiple times. But in my opinion the current name "LoopingStream" suggests that the stream continues at the beginning once it reached the end.
A name like "MultiUseStream" might fit better. Similarly the method getStream should be named newStream to indicate that a new stream and not an existing one is returned.
The fields could use the following names:

Obfuscated
Deobfuscated

a
collectedElements

b
delegate / source

And if it is possible to name the field of the anonymous class, then it could be named index / currentIndex.

I would suggest ReusableStream.


Seperate Menus for reporting media / Improvements

Is your feature request related to a problem? Please describe.
Between movies and TV shows, these menus should be contextually different.
Describe the solution you'd like
As an addition to this, the TV issues should have an episode / season option populated with episodes that have metadata / are present or something different. Movies might only have a few different issues, while a TV show may have an issue with a specific season, episode, or the whole show.
Describe alternatives you've considered
Having users type episode number / season number, otherwise marking as resolved.
Additional context
Makes harder than needs to be for admins to deal with issues.

I'm not entirely sure what you mean. We can add in proper episode / season info tagging to an issue which is planned but we don't have any plans to make the two menus "contextually different"?

It makes no sense for someone to “report a missing episode” for a movie, just a UX thing that could make reporting / issues a smoother experience.

It makes no sense for someone to “report a missing episode” for a movie, just a UX thing that could make reporting / issues a smoother experience.

Yeah you can't report a missing episode (unless there's a bug) for a movie. You get different options for movies or shows

Interesting... Seems like a bug of some kind... I'll do some further investigation later in the day.

I'll close this issue for the time being and see if I can get things sorted myself.


Reflection exception in Routes:resource()

Laravel Version: 5.8
PHP Version: 7.2
Database Driver & Version: 10.1.34-MariaDB

Description:
in routes/web  i wnat add resource for categories. I have App\Http\Controllers\CategoryController and add next code:
use App\Http\Controllers;

Routes::resource('categories', Controllers\CategoryController::class);

After console command artisan routes:list catch an exception
ReflectionException  : Class App\Http\Controllers\App\Http\Controllers\CategoryController does not exist

  at path-to-project\vendor\laravel\framework\src\Illuminate\Container\Container.php:790

If to method resource(...) put string 'CategoryController' - all will be ok
Steps To Reproduce:
Create CategoryController with artisan
Add to routes/web next code:
use App\Http\Controllers;

Routes::resource('categories', Controllers\CategoryController::class);

Routes::resource('categories', CategoryController::class);

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!

You can't pass a whole class path to Route::resource(), only the part after App\Http\Controllers\:
Route::resource('categories', 'CategoryController');

Doh! Because I use the full path in all of my routes, I typed ::class without realizing it in my response above.  Sorry @KartaviK for being misleading.


How many Epochs Does it Take to Reproduct Results?

I follow your instructions stated in README to train the model on "humans" dataset. I found that by default Main.py would train the model for 5000 epochs and each epoch takes quite some time.
May I ask does it really take 5000 epochs in order to reproduce the results stated in your paper?

btw, below are the metrics I got thus far at epoch 540:
540 : loss = 514.970, copyloss = 499.673, covloss = 20.444
copy BLEU: 28.3731

The BLEU is pretty close to the figure reported in your paper (29.5 in Table 1). But the copyloss seems a bit high (no reference for me to compare). Is it expected?

From what I saw, the model converges in a few hundred epoch. After the epoch 237, the loss and BLEU roughly stay the same


converts 2 pages of pdf into text file

On conversion of pdf to its corresponding text files it only converts first two pages of pdf

You are probably using the Azure Form Recognizer free tier which is limited to 2 pages only.


Feature request: Load rule files from directory

Hello!
can you consider option of loading alert rule files from directory, not specifying them one by one in configuration.
This can help:

if there is a lot of alert rules. storing them in big files can be tricky.
if rule files automatically generated.

That feature is already supported 🙂 you can load rule files via a file glob.

thanks for info!


WIP: QEMU: exclude template-service and swupdate

This commit is needed to be able to run the smoke tests.
Signed-off-by: Therese Nordqvist<EMAIL_ADDRESS>

Fine with me. I'll remember this if we ever need to include swupdate on qemu builds.

@FlorentRevest: I only needed it to be available for testing purposes. I think we might want it for running the smoke tests, but we might be able to do it some other way.
@GordanM: @erikboto wrote to me saying that we don't actually need to exclude the template service. It was a copy-paste-error from his side (I have gotten help from him with this change). So it might be unnecessary to exclude it.

@tobsan If we have a Jenkinsfile in pelux-manifests for smoke testing in qemu, can we also have a tests image where we exclude things like this? It feels it might be unnecessary to exclude it always for qemu? Or how do you think in this situation?

I'm not sure how the test image stuff works, but one can probably do lots of customizations when building it, since it is a yocto target.
When it comes to swupdate, perhaps it would make more sense to include it ONLY in the rpi build as IMAGE_INSTALL_append_rpi = "swupdate" or something like that. That way the problem will go away on its own. What do you think @FlorentRevest

@tobsan it totally makes sense to include swupdate only on supported platforms. I don't mind at all.

Then I can change this to what @tobsan suggested. Append instead of remove.


Add custom fonts

Use built in css web safe fonts in the drop down <select> box for the memes.

Done! Works great.


Fixes #66 "Error assembling WAR: webxml attribute is required"

This change might fix issue #66, if it is really an issue and not wrong usage of the tool.

Merging since there is no negative feedback


The reasults of test accuracy

Describe the Question
A clear and concise description of the question.

topology search space in NATS-Bench

Hi, I am confused by how to query one arch's test accuracy correctly. I did a test about querying one arch in two different ways. here are the code and outputs:
from nats_bench import create

search_space = 'tss'

api = create(None, search_space, fast_mode=True, verbose=True)

print(50 * '-')
info = api.get_more_info(
            1,
            dataset = "cifar10-valid",
            hp="200" if search_space == "tss" else "90",
            # hp='12',
            is_random=False
        )
print(info)

print(50 * '-')

info = api.query_info_str_by_arch(
    1, "200" if search_space == "tss" else "90"
)
print(info)

As the picture shows, the same arch gets different test accuracy. So what is the difference between these two ways? and which one you used in your paper.

cifar10-valid and cifar10 are a bit tricky.
If you try:
info = api.get_more_info(
            1,
            dataset = "cifar10",  # not cifar10-valid
            hp="200" if search_space == "tss" else "90",
            # hp='12',
            is_random=False
        )
print(info)

Then the test accuracy is the same as what you got from api.query_info_str_by_arch.

I got it. Thank you for your reply.


Supply a client request id when calling into the SDK

The JS SDK doesn't send a client request id with the requests
(unlike the .NET SDK). Will follow up with the SDK team, but for now,
we will supply the client request id when calling into the SDK (via
custom headers in the request options).
Also ensure that setting values passed to the SDK are strings (SDK
calls will fail otherwise).

Closing this PR because a change was made in the JS SDK to send the client request id automatically (will pick up the next version of the SDK that contains the change)


Update release.sh to correct messaging

The usage string says To update SRI hashes, run this again on the generated release branch but that seems to be done automatically?

The message that appears after making a release branch (and before Visit https://github.com/KaTeX/KaTeX/pulls to open a pull request.) should also prompt to update the CHANGELOG.md.

The first one is intended for changes after the branch is created.

Maybe we could rephrase the first sentence to be something like:
If you changes to the PR, the SRI hashes must be regenerated.  This can be done by running this script again on the release branch.

I forgot there was a wiki page about releasing: https://github.com/KaTeX/KaTeX/wiki/Releasing-KaTeX.

Funny, didn't you write that page? 😄 In any case, maybe it's worth adding a link to that page from release.sh (in comments at least, and maybe also echoed) so that releasers can more easily find it.


During service creation you can assign the same secret/config multiple times

Bug description
During service creation you can assign the same secret/config multiple times which you should not be able to do, as the service create will fail.
Expected behavior
If a secret/config is assigned using the 'add a secret' or 'add a config' options, it should be hidden in the drop down list so you can't select it multiple times.
Steps to reproduce the issue:

Go to 'Create service' view
Click on 'Secrets tab' at bottom of screen
Click 'add a secret' and select your secret
Repeat step 3 with the same secret
Click 'Create the service'

See Below Error

Technical details:

Portainer version: 1.20.2
Docker version (managed by Portainer): 18.06.3-ce (API: 1.38)
Platform (windows/linux): Linux (Ubuntu 18.04.2 LTS)
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): yarn start
Browser: Chrome

Reproduced on 1.23.2

We'll show a warning in this case:


Prefer vector operations over unary operations for roundEven and isfinite (GLSL/SPIRV/HLSL)

Prefer vector operations over unary operations for roundEven and isfinite.

roundEven is already covered in this PR.
https://github.com/shader-slang/slang/pull/4080/files

I went over hlsl.meta.slang and discovered these additional functions:
asuint16/asfloat16 (vector version) can just be OpBitcast.
f16tof32/f32tof16 (vector version) can be OpFConvert(OpBitCast()).
rcp vector version can be vector div.

@jkwak-work what are you doing w/this one? Looks like low priority. Should we push it out of the current iteration?

I think this is pretty easy one.
I will give a try and see if I can get it done today.


large files not converting

I have a series of JSON which are only about 100k (or greater) in size. But when I try to convert I get an empty file. Smaller files convert fine.
This is from within a Windows 10 environment.

I am having same Issue, When using stream, Also found that issue is with

if (self._extra.length > chunk.toString().length * 3) return null;// lib/core/stream.js

It happens for last chunk which happen to be at the smaller than the last stored json part.

@m-prof r you using the stream feature from jsonexport?
@akhilchandran i will try to reproduce this later.

I am just using the basic command listed on the main page (http://kauegimenes.github.io/jsonexport/),
jsonexport <JSON filename> <CSV filename>.
Gives me an empty file. Is there an option I should be using?
For reference I attach a sample file.
sample.zip

@m-prof can you try again using the branch bugfix/stream-memory-limit?

Thanks! But I am still getting an empty file. You can confirm with the sample file I sent.

@m-prof i did test with the sample you provided and got a csv with 322 lines.
try this:
git checkout bugfix/stream-memory-limit
./bin/jsonexport.js sample.json output.csv

OK good it is something on my end! Are you doing this within Windows 10?
I am not sure how to execute those commands you mentioned within Win 10 (e.g. if try jsonexport.js sample.json output.csv I get a microsoft jscript compilation error

@m-prof can you try using<EMAIL_ADDRESS>i just published this version to npm, this should fix your issue

@m-prof feel free to reopen this issue if this fix does not work for you.

Thanks so much kaue! This works now for me, for all files I checked.
I did have a follow-up on speed: things slow down for files 1.5M or higher. For me  (Win 10 Pro, Surface Pro, 16G RAM, Intel i7-7660U) when I tried a 3.9M file it took 42 minutes (command: jsonexport <json_filename>  <output_filename>. Is this sort of time to complete expected?


feat: add more features to ContinuousMapZero

This adds all the remaining material necessary for ContinuousMapZero to get the instances of the non-unital continuous functional calculus.
Co-authored-by: @adedecker

bors merge


Rotate 2d-Array by 90 degree

💥 Proposal
I want to add Rotate 2d-Matrix by 90 degree in C-Plus-Plus
[C-Plus-Plus][2d-Array][GSSOC'21]
Have you read the Contributing Guidelines on Pull Requests?

Yes

/assign


Custom icons

Hello !
Is it possible to had custom icons please ?
We can add images to Azuriom, so maybe we could use them as icons ?
Thank you !

Hi, we don’t plan to add this, but this might be useful : https://fontawesome.com/v5.15/how-to-use/on-the-web/using-kits/uploading-icons