No deviceattached or midi messages being detected or displayed

App built for Quest 3 - When plugging my Midi controller in I get the prompt menu appear and click OK. Scene opens but the text does not display any device info or incoming midi data info.
Secondly once this is solved I am simply trying to connect the incoming midi messages to trigger buttons, sliders and toggles in the UI. Can you provide steps to do this also? Thanks!

Hello,
Can you give me the logs
https://developer.android.com/studio/debug/logcat?hl=en

Logcat.txt
Would it help for me to filter it by some criterion?

Not really the full log is ok
2024/03/11 11:03:40.234 1072 5178 Warn InputManager-JNI Input channel object '499b7c7 com.oculus.os.vrusb/com.oculus.os.vrusb.UsbPermissionActivity (client)' was disposed without first being removed with the input manager!
2024/03/11 11:03:40.234 10860 10860 Info Unity Device Attached /dev/bus/usb/001/002
2024/03/11 11:03:40.234 10860 10860 Info Unity Midi.MidiEventHandler:DeviceAttached(String)
2024/03/11 11:03:40.234 10860 10860 Info Unity System.Reflection.RuntimeMethodInfo:Invoke(Object, BindingFlags, Binder, Object[], CultureInfo)
2024/03/11 11:03:40.234 10860 10860 Info Unity UnityEngine.AndroidJavaProxy:Invoke(String, Object[])
2024/03/11 11:03:40.234 10860 10860 Info Unity UnityEngine.AndroidJavaProxy:Invoke(String, IntPtr)
2024/03/11 11:03:40.234 10860 10860 Info Unity UnityEngine._AndroidJNIHelper:InvokeJavaProxyMethod(AndroidJavaProxy, IntPtr, IntPtr)

You need to have the usb permissoin in the manifest file

Yes I had a feeling it was something extra needed in the manifest. Can you confirm what exactly needs adding as I did already add android.hardware.usb.host
Do we need to add the full snippet from here - https://developer.android.com/develop/connectivity/usb/host
<manifest ...>

...

<activity ...>
...

        <meta-data android:name="android.hardware.usb.action.USB_DEVICE_ATTACHED"
            android:resource="@xml/device_filter" />
    </activity>
</application>

Did it work? Can I close the issue ? @owlandfox

Nope still trying to get some detection for plugged in controllers

From what I can see its because we also need to declare intent filters https://developer.android.com/develop/connectivity/usb/host
But im not sure where we would need to create the xml file as this seems very specific to Android file structure rather than Unity.

You need to have the android manifest file in unity : https://docs.unity3d.com/2023.2/Documentation/Manual/android-manifest.html
Add  <uses-feature android:name="android.hardware.usb.host"/> into the manifest file

Yep tried this multiple times, no success :/


[sqllab] only override limit when user does not specify

This PR cleans up the limits enforcement code and makes one key change:
It now no longer alters the user specified limit and only puts in the default limit when the user does not specify one.
Previously, the value specified in the grey box below the editor always overrides the query the user types in if they exceed the value but this value
This was tricky because users would specify a limit and export to CSV expecting that number of rows but not see the right number of rows. With this change, the UI will still show just 1K but the CSV will contain everything.

Does that mean the system administrator does not have a way to impose a hard limit?

@mistercrunch This is a good point. I just addressed it. I made the user specified limit the minumum of itself and the max the admin specified.

Codecov Report

Merging #6804 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #6804      +/-   ##
==========================================
+ Coverage   56.07%   56.07%   +<.01%
==========================================
  Files         526      526
  Lines       23247    23246       -1
  Branches     2784     2784
==========================================
  Hits        13035    13035
+ Misses       9802     9801       -1
  Partials      410      410

Impacted Files
Coverage Δ

superset/sql_lab.py
76.66% <100%> (+0.03%)
:arrow_up:

superset/views/core.py
75.07% <87.5%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 416534a...030c161. Read the comment docs.

This limit logic is getting very confusing to me.

@timifasubaa given the limit logic is somewhat non-trivial and the following statement isn’t overly clear

if they exceed the value but this value

maybe there would be merit in updating the description of this PR to explicitly state: i) what the current behavior is, and ii) what the proposed behavior will be.

@john-bodley I updated the change

@timifasubaa is it feasible to add/augment any unit tests for this?


Language Server Crashes complaining about nesting level.

In the developer console I see two errors:
CRITICAL  Error: Maximum function nesting level of '256' reached, aborting!
and then
Error: Channel has been closed
After which intellisense is completely dead.

Sounds like you have XDebug running and configured with a function nesting limit. What are the full logs? It should log something about XDebug as it should disable XDebug automatically, unless you set an environment variable to not do so.

Yeah, I forgot I had vscode pointed to a different instance of php and it had xdebug enabled. Thanks for quick response.


Fix/Add broken link for item_attendee in docs

Link to ATTENDEE documentation was missing and table entry was broken

Upstreamed, thank you for the fix @malteger!


[Feature Request]: Escape going back to previous page instead of closing out entirely

Is your feature request related to a problem?
This has been an issue that has been plaguing me since I started using this mod.
My issue is that when you press escape it closes out the entire GUI instead of just going back!
Solution(s)
Make it so that when you press escape instead of completely closing the guI it only goes back.
Describe alternatives you've considered
No response
Mod Version
1.0.5
Mod Loader Version
1.20.1 - 47.1.3
Mod Loader
Forge
Additional context
No response

Seconding this request. We at least need a keybind that can move back a page instead of trying to hit the very small click target in the corner.

I think Alt + ← for going back to the quest book and Alt + → for going forwards to the last opened quest would work well too. These keybinds are the standard for backwards and forwards, which many mice with additional buttons are pre-bound with, so you'd be able to more easily navigate the quests with the mouse.


loggerName in LogEventInfo.Create() does not fully override name set with LogManager

NLog version: 4.5.6
Platform: .Net 4.5
Current NLog config (xml or C#, if relevant)
<?xml version="1.0" encoding="utf-8" ?>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      xsi:schemaLocation="http://www.nlog-project.org/schemas/NLog.xsd NLog.xsd"
      autoReload="true"
      throwExceptions="false"
      internalLogLevel="Off" internalLogFile="C:\MyProject\Logs\nlog-internal.log">

  <targets>
    <target name="GeneralWrapper" xsi:type="AsyncWrapper" queueLimit="5000" overflowAction="Discard">
      <target name="General" xsi:type="File" createDirs="true" fileName="C:\MyProject\Logs\General${level}.log">
        <layout xsi:type="JsonLayout" includeAllProperties="false" renderEmptyObject="false">
          <attribute name="Logger" layout="${logger}" />
          <attribute name="Date" layout="${longdate}" />
          <attribute name="Exception" layout="${exception:format=toString,Data:maxInnerExceptionLevel=10}" escapeUnicode="false" />
          <attribute name="Event" layout="${message}" escapeUnicode="false" />
          <attribute name="Data" encode="false">
            <layout xsi:type="JsonLayout" includeAllProperties="true" renderEmptyObject="false" maxRecursionLimit="10" />
          </attribute>
        </layout>
      </target>
    </target>
    <target name="TasksWrapper" xsi:type="AsyncWrapper" queueLimit="5000" overflowAction="Discard">
      <target name="Tasks" xsi:type="File" createDirs="true" fileName="C:\MyProject\Logs\Tasks.log">
        <layout xsi:type="JsonLayout" includeAllProperties="false" renderEmptyObject="false">
          <attribute name="Logger" layout="${logger}" />
          <attribute name="Date" layout="${longdate}" />
          <attribute name="Event" layout="${message}" escapeUnicode="false" />
          <attribute name="Data" encode="false">
            <layout xsi:type="JsonLayout" includeAllProperties="true" renderEmptyObject="false" maxRecursionLimit="10" />
          </attribute>
        </layout>
      </target>
    </target>
  </targets>

  <rules>
    <logger name="MyProject.Core*" minlevel="Debug" writeTo="General" />
    <logger name="Tasks" level="Debug" writeTo="Tasks" />
  </rules>
</nlog>

Here goes example code, it always writes to "General" logger:
namespace MyProject.Core.Helpers
{
    public class LoggerHelper
    {
        // It's the same with any of the following two, the logger name used for the rules config
        // it's not overriden by LogEventInfo.Create

        // This one
        private static Logger logger = LogManager.GetCurrentClassLogger();
        // Or this one...
        // private static Logger logger = LogManager.GetLogger("Whatever");

        public static void TasksLog(string message, object[] data)
        {
            var logEventInfo = LogEventInfo.Create(LogLevel.Info, "Tasks", CultureInfo.InvariantCulture, message, data);
            logger.Log(logEventInfo);
        }

        public static void GeneralInfoLog(string class, string method, string menssage, object[] data)
        {
            var logEventInfo = LogEventInfo.Create(LogLevel.Info, class + "." + method, CultureInfo.InvariantCulture, message, data);
            logger.Log(logEventInfo);
        }
    }
}

What is the current result?
The config rules apply to the original name set by LogManager and everthing gets logged to target "General".

What is the expected result?
I expect the config rules to be applied to the logger name I set in LogEventInfo.Create and data to be logged accordingly to "General" or "Tasks". The layout renderer ${logger} works as I expected and renders the name from LogEventInfo and not the original name.

Did you checked the Internal log?
2018-06-09 13:41:43.6939 Debug FileTarget(Name=General): Process file 'C:\MyProject\Logs\GeneralInfo.log' on startup
2018-06-09 13:41:43.6939 Debug Creating file appender: C:\MyProject\Logs\GeneralInfo.log

Are there any workarounds? yes
I can get a logger from LogManager with the name I want, within each function call, but I intend to not to...

I think the loggerImpl will overwrite the logger name. Have to check that.
But IMO this is a pretty good option:
namespace MyProject.Core.Helpers
{
    public class LoggerHelper
    {
        // It's the same with any of the following two, the logger name used for the rules config
        // it's not overriden by LogEventInfo.Create

        // This one
        private static Logger logger = LogManager.GetCurrentClassLogger();
        // Or this one...
        // private static Logger logger = LogManager.GetLogger("Whatever");

        public static void TasksLog(string message, object[] data)
        {
            var logEventInfo = LogEventInfo.Create(LogLevel.Info, "Tasks", CultureInfo.InvariantCulture, message, data);
             LogManager.GetLogger("Tasks").Log(logEventInfo);
        }

        public static void GeneralInfoLog(string class, string method, string menssage, object[] data)
        {
            var logEventInfo = LogEventInfo.Create(LogLevel.Info, class + "." + method, CultureInfo.InvariantCulture, message, data);
            LogManager.GetLogger(class + "." + method).Log(logEventInfo);
        }
    }
}

Yes, that's what I'm actually doing, but I would prefer not to do that because of NLog's best practices https://github.com/NLog/NLog/wiki/Tutorial#best-practices-for-logging
Specifically:
1. Logger should be a static variable in each class
Creating a new Logger has an overhead, as it has to acquire locks and allocate objects.
I don't know the impact that this overhead would have in the application if say, 100 loggers are being gotten at the same time, but if it's not so significant that code will do.

Logger should be a static variable in each class
Creating a new Logger has an overhead, as it has to acquire locks and allocate objects.

true, but the loggers are cached and the getlogger is faster than getCurrentClassLogger.
static is preferred, but it's currently not possible for you case. Anyway, I highly doubt if you see any performance difference..

Ok, it'll work fine like that for me then, but anyway, if LogEventInfo.Create() should fully override the logger name, probably you should look at it, because believe me it doesn't override it for rule cheking but only fo the layout renderer ${logger}
Thanks!

@Sebastriani  If LogEventInfo.Create() should fully override the logger name, probably you should look at it

It is not intended to override the logging rules of the used logger. It would introduce too much overhead. Maybe it would be more userfriendly that the logger always assigned its name to LogEventInfo.Logger, but it would be a breaking change and few are tinkering with the NLog internals.

@snakefoot I solved it by doing this https://github.com/NLog/NLog/issues/2766#issuecomment-396003874
Thanks!

It would introduce too much overhead.

With that in mind, we will close this one. Thanks!

Created #2917 so the Logger assigns LogEventInfo.LoggerName if uninitialized (null).


bug: Complex commands don't reject invalid kwargs

Overview
The transfer(), distribute(), and consolidate() commands (at least; there may be more) silently ignore kwargs that don't actually exist.
So, if you make a silly typo, your protocol will silently do the wrong thing instead of raising an error.
Steps to reproduce
This protocol runs "successfully."
metadata = {"apiLevel": "2.2"}

def run(protocol):
    tip_rack = protocol.load_labware("opentrons_96_tiprack_300ul", 1)
    plate = protocol.load_labware("corning_24_wellplate_3.4ml_flat", 2)
    pipette = protocol.load_instrument("p300_single_gen2", mount="right", tip_racks=[tip_rack])

    pipette.transfer(100, plate.wells()[0], plate.wells()[1], this_kwarg_does_not_exist=True)
    pipette.distribute(100, plate.wells()[0], plate.columns()[2], this_kwarg_does_not_exist=True)
    pipette.consolidate(100, plate.columns()[2], plate.wells()[0], this_kwarg_does_not_exist=True)

Expected behavior
This should raise TypeError, which is what Python normally raises when unexpected kwargs are provided.
┆Issue is synchronized with this Wrike Task by Unito

Moved to Jira: RSS-474


Address errant location association

With the discussion on the Locations MVP proposal, there is now a way
forward for representing this desired association.
References:

[ONT-186] (CP-30) Topic - Location

Oh, wait, forgot to note discovery history.  Revised commit coming.


Add "crates.io: Crate Deletions" RFC

Rendered

Maybe require all crate versions to be yanked for at least $long_time.

How does this help me rename my crate that has users?

it doesn't. this will only be helpful for renames very early in a project's lifespan. for example: you discovered after two days that you wanted to use hyphens instead of underscores or vice versa. this won't help e.g. tokio rename itself to kyoto

Maybe require all crate versions to be yanked for at least $long_time.

This would likely have consequences for the 72 hour rule. npm allows deletion without prior deprecation (which I treat roughly similar to our yanking). if you made a publishing mistake, such a rule would probably prevent people from being able to quickly fix their mistake.

I'm mostly in favour of this change, but with one caveat: I think that there should be an explicit mention that, while deleting a crate or version will immediately remove it from public downloads, crates.io should reserve the right to retain the deleted version for some amount of time (maybe a few days after deletion) just as a safeguard from abuse.
72 hours is a pretty long time, and just thinking of how this feature could be abused, you could upload malicious content for that interval, then "get rid of the evidence" pretty quickly. Effectively, I think that it should be possible for someone to notice that abuse occurred, report it, and then have someone review the deleted content before it's immediately sent to the shadow realm. Doesn't have to be long, but it feels like a safeguard that should exist if this feature is added, and it should be one that's clarified does exist.

Additionally, I think that the current requirements beyond the 72-hour window are a bit strict, and would exclude some crates that I personally think might be worth including under this policy. For example, take this incredibly old crate: https://crates.io/crates/bow
I am the owner of this crate, but it relied on the long-fixed incoherent_fundamental_impls soundness hole, and is now broken permanently on all versions of Rust since… a while. Six years ago, I published an explicitly empty version to the crate including a message about how it's broken, and back before I really understood everything, I didn't yank the old, broken versions. In fact, I should probably go and do that now.
However, through a series of also-broken dependencies by me that I also haven't checked in years, is part of the swc-hosts crate, which is downloaded a handful of times a day. In fact, it was downloaded 54 times on Jun 11, so, my guess is that someone has it running in their CI somewhere, and this itself is massively inflating the number of downloads.
Now, as I said, I'm going to probably take a bit within the next few days to go and make sure all of these crates have a blank latest version that does nothing, and their past versions are all yanked. But doing this now, after 6 years, means I'm basically never going to cover that 100-download-per-month requirement unless I have another several years where I have no downloads at all. (Which will happen, but, yeah.)
My proposal for this is to modify the rules slightly: as an alternative to the 100 downloads requirement, allow crates whose latest version satisfies the 100 downloads requirement but whose versions which do not satisfy that requirement are all downloaded from Rust versions over a year old. This would require collecting additional data,

I'm mostly in favour of this change, but with one caveat: I think that there should be an explicit mention that, while deleting a crate or version will immediately remove it from public downloads, crates.io should reserve the right to retain the deleted version for some amount of time (maybe a few days after deletion) just as a safeguard from abuse.
72 hours is a pretty long time, and just thinking of how this feature could be abused, you could upload malicious content for that interval, then "get rid of the evidence" pretty quickly. Effectively, I think that it should be possible for someone to notice that abuse occurred, report it, and then have someone review the deleted content before it's immediately sent to the shadow realm. Doesn't have to be long, but it feels like a safeguard that should exist if this feature is added, and it should be one that's clarified does exist.

Additionally, I think that the current requirements beyond the 72-hour window are a bit strict, and would exclude some crates that I personally think might be worth including under this policy. For example, take this incredibly old crate: https://crates.io/crates/bow
I am the owner of this crate, but it relied on the long-fixed incoherent_fundamental_impls soundness hole, and is now broken permanently on all versions of Rust since… a while. Six years ago, I published an explicitly empty version to the crate including a message about how it's broken, and back before I really understood everything, I didn't yank the old, broken versions. In fact, I should probably go and do that now.
However, through a series of also-broken dependencies by me that I also haven't checked in years, is part of the swc-hosts crate, which is downloaded a handful of times a day. In fact, it was downloaded 54 times on Jun 11, so, my guess is that someone has it running in their CI somewhere, and this itself is massively inflating the number of downloads.
Now, as I said, I'm going to probably take a bit within the next few days to go and make sure all of these crates have a blank latest version that does nothing, and their past versions are all yanked. But doing this now, after 6 years, means I'm basically never going to cover that 100-download-per-month requirement unless I have another several years where I have no downloads at all. (Which will happen, but, yeah.)
My proposal for this is to modify the rules slightly: as an alternative to the 100 downloads requirement, allow crates whose latest version satisfies the 100 downloads requirement but whose versions which do not satisfy that requirement are over a year old and have never been downloaded more than 100 times a day. This allows those pesky CI outliers to be weeded out while still effectively meaning that nobody uses the crate.

100 downloads is too low. I'm an unknown crate author and I've released a few crates with no dependents and no advertising of the crates at all. They've all easily reached 100 downloads in the first one or two days. Bots keep downloading old versions of crates too, so each new version essentially acts as a multiplier for bot downloads. Also, releasing multiple new versions of a crate in quick succession (e.g. to fix semver breaks) seems to exponentially increase the number of bot downloads. One of my crates got a thousand bot downloads in a day and currently has 3700 downloads, more than twice the downloads of the crate it depends on. To my knowledge nobody uses it yet.

@clarfonthey as far as I know (part of) our backend storage already keep deleted files around for purposes such as this. deletions already exist, but at the moment they are restricted to admins.
@maia-s thanks for the feedback. as the RFC text mentions, these thresholds are not set in stone. if we notice that the thresholds are not sufficient we can always tweak the numbers.
It looks like so far no major blockers to such a change have been identified. I appreciate the feedback so far and the crates.io team will take it into consideration when deciding on this RFC :)
Over the past days, our support email address has received a significant number of deletion requests again from users that no longer think their crates are useful and would like to release those names to the public again. This currently leads to quite a bit of manual work for us, even if it is just responding with a rejection message.
To move this RFC one step further forward I propose to move it into FCP status, which will still be gated on reviews and support from the rest of the crates.io team for now:
@rfcbot fcp merge

@JohnTitor @LawnGnome @Rustin170506 @jtgeibel ICYMI https://github.com/rust-lang/rfcs/pull/3660#issuecomment-2232942504 😉

Linking to a planned policy change in a thread comment, so that it's easier to find: https://github.com/rust-lang/rfcs/pull/3660#discussion_r1854135667

planned policy change

see https://github.com/rust-lang/rfcs/pull/3731


Displaying bandpass filter output in periodogram?

Is there a way to only display the positive frequencies in a periodogram?  My signal chain is:

SDR Source (sample rate = 2.016 MHz)
Freq Xlating FIR Filter (raised cosine; decimation =42; output sample rate = 48 kHz)
Decimating FIR Filter (CCC; raised cosine Bandpass filter; 100-4000Hz decimation = 6; output sample rate = 8 kHz)
Complex to Real
Periodogram

This is all working fine and doing what I want except that the x-axis of the periodogram ranges from -4 to +4 kHz.  All I really want to see is 0 to 4 kHz but I can't figure out how to set the x-axis range.
Thanks for any suggestions,
Jim D

Thanks for the report. You can select a portion of the spectrum to display with a mouse. But there is no option to just permanently display the positive part of the spectrum. I'm adding an issue, it shouldn’t be much trouble: https://github.com/pothosware/pothos-plotters/issues/11

Quick update, I added this feature to the plotters. They automatically detect the data type and only show the positive part of the spectrum for real-valued signals. There is also an additional manual option to always show the full spectrum or only the positive. I will probably have this feature for the next build.


fix: separate certs from interview prep on landing page

This is what I came up with, let me know if we want some different....

Closes #37340

Nevermind, I think I am not going to be nit picky on this for now.


Port to nalgebra, add methods to assist rendering

Hello!
I was looking for a crate to use to create bezier curves in 3D and I really liked your compile time guarantees. I'm opening this PR now mostly just to give you a heads up and brief list of what I've done to see if you are interested in up streaming any of it.
Biggest change upfront is completely removing your Point type in favor of nalgebra's. I think that nalgebra and glam are the two biggest math libraries at this point, and they already have implemented seamless conversions between each other. I think it's less work to just use it.
Next was getting rid of the special implementations of the lower dimensional curves. I just wanted a single type to deal with, and performance shouldn't be different with all the const generic optimizations that can be performed.
The last part I'm working on is creating iterators that break the curve down into line segments so that you can use those line segments to create a mesh, or just draw the lines. I also added the ability to create offset line segments from the curve.
If you're interested in me working on mainstreaming these changes let me know, otherwise I'll probably end up forking.

Hey!
thank you for the PR! I haven't had much time to work on this library lately, but there are many things on my list once I get back to it (hopefully shortly). I am absolutely open to accept PRs and even adding maintainers, if they align with the specific goals of this lib

Biggest change upfront is completely removing your Point type in favor of nalgebra's.

I agree. It always felt like reinventing the wheel but it gave me more control while going through the many iterations of this library.

I think that nalgebra and glam are the two biggest math libraries at this point

What made you choose nalgebra's over glam's ?

Next was getting rid of the special implementations of the lower dimensional curves.

They are mostly a relic of the first development versions. Performance difference should indeed be negligible, especially for the lower order types (and these are usually the ones that are specialized). So yes, that'd be fine.

The last part I'm working on is creating iterators

This is great help actually. I have only written this lib to backup some knowledge from rather theoretical uni courses (and dabble in const-generics) but have rather little experience with the needs of graphical workloads. So having a more practical API for actual professionals makes a lot of sense and I do need help with that (convenience functions etc). I think naming conventions should align with those of established libraries (e.g. rhino/opennurbs?) where possible.
A quick look over your changes shows you are replacing dependency tinyvec (100% safe rust) with smallvec (a lot of unsafe, kind of a meme in the rust community) which I had also used in the past. This is a change I think I could not compromise on for this library.
At a glance I am not sure what it is required for specifically and would argue it needs to be removed.
I will dive deeper into your PR soon.
Anyway, I expect to be able to again work more on this library the coming months and am happy with any collaboration!

Honestly I swapped to smallvec because I'd used it before. I've got no issues with using tinyvec over it.
The decision to use nalgebra over glam is because nalgebra let's you be generic over the dimension and value type of the vectors, glam does not have any generic typing at all. Glam is often chosen over nalgebra for exactly this reason, because the types are simpler and it compiles a bit faster. Interop between the two is very simple though, they can both be converted into each other use into.
My fn naming is quite bad right now, it's very much in the experimental phase. But I think the most important API for drawing splines is easily breaking it down into line segments. I also wanted the ability to generate offset points so that I could make a mesh out of it

I have to backpedal a bit on the first two points...

I really want to keep the library simple, while making use of rust's powerful trait system. So keeping an own Point trait, which then can be implemented for many external types (nalgbera, glam etc.) and activated as an optional feature in Cargo.toml seems most beneficial.  However, implementing it for nalgebra proved to be more difficult than I thought and may force me to rethink my trait bounds (e.g. IntoIterator is not provided by SVector but iter() and iter_mut() are). Keeping a simple type PointN (type and trait could be renamed e.g. Trait: CartesianCoord and Type: Point ) is also nice if you have projects where you don't need all the power of nalgebra's highly generic types (everything is a matrix). I have a branch nalgebra-compat (not working) where I want to explore this.
As stated in the edit above, these specializations (QuadraticBezier, CubicBezier) should only really be needed until newton-raphson is implemented for the generic versions of the splines to do all sorts of nice things like bounding_boxes, tight boxes. These specializations already support bounding_box() and since they are a common use case for segments, I'd not remove them until then.

I will look into integrating your convenience functions next


RABSW-1069: Support for refactored DWS Storage resource and NNF Fencing functionality

Update to the latest DWS Storage resource
Support for fencing logic

This is now ready for review


[RCORE] Update comments on fullscreen and boderless window to describe what they do

There is a large amount of confusion regarding what ToggleFullscreen and ToggleBorderlessWindow do (3 questions today alone).
The current comments are insufficient, the term 'Fullscreen' no longer means what it used to in the days of CRTs, and the expectation is that the function changes the size of the window, but it does not.
This PR adds a description to each function saying what it does exactly, to help reduce this confusion for what is now becoming an increasingly poorly named function.

@JeffM2501 Thanks for the review!


Inquiry About Downloading Kinetics and SSV2 Datasets due to Missing data

Thank you for your great work!
While using your Kinetics list, I noticed that around 1% of the videos could not be found in my dataset. I used DeepMind's repository (https://github.com/cvdfoundation/kinetics-dataset) to download the data.
Could you share how you downloaded the Kinetics dataset?
Additionally, my SSV2 dataset is in video format, not frames. Could you let me know where you obtained your SSV2 dataset as well?
Thanks again for your assistance.

Problem solved.
Use OpenMMLab for download works perfect.
https://opendatalab.com/OpenMMLab


CLI refactor

Updates the CLI to get the list of starter kits from a raw JSON file hosted on GitHub starter-kits.json. Currently entries will need to be added manually. Also this won't really work until the repo is public due to short lived tokens for raw files. It will probably be ideal to write a script that generates the JSON file and put it in a GH action to automate it

Reminder to self: publish to npm after merge :)


Fix md5 checksum for big RPMs

Big RPMs don't set size in RPMSIGTAG_SIGSIZE but use RPMSIGTAG_LONGSIGSIZE instead

Hey @cavaliercoder , any chance to get it reviewed ?


Migrate to schemaForExecutor in graphql-tools

Currently during introspection codegen, graphql-tools will print this warning:
`introspectSchema` is deprecated, and will be removed in the next major. Please use `schemaFromExecutor` instead.

We should migrate away from introspectSchema before their next major.

Fixed in #1544


Remove PDFViewerApplication.initPassiveLoading and directly invoke the open-method from the extension-specific code

Move the error message localization into PDFViewerApplication._otherError
When reporting errors in the viewer we currently localize the error messages "manually" at every call-site, which seems like unnecessary repetition.

Remove PDFViewerApplication.initPassiveLoading and directly invoke the open-method from the extension-specific code
This old method is essentially just adding, a small amount of, unnecessary indirection and we can easily invoke PDFViewerApplication.open directly from the extension-specific code instead.

/botio-linux preview

/botio integrationtest

/botio-linux preview

Looks like a good simplification; thanks!


layers: Fix bug with renderpass state in cmd buffer

When a CmdEndRenderPass is called, reset the command buffer's activeSubpassContents
to the default value of VK_SUBPASS_CONTENTS_INLINE.
This fixes a but where, if a previously renderpass in a cmd buffer had been in
VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS mode, then a subsequent renderpass
in that same mode will incorrectly hit an error about an invalid call to
vkCmdBeginRenderPass() within a secondary cmd buffer subpass.

Is there a corresponding bug?
We've had a test for a while that requires this case to work correctly. Any code that's looking at the subpass contents state when there isn't an active renderpass instance is overreaching.

Bug received via direct mail from a vendor. I see the RenderPassSecondaryCommandBuffersMultipleTimes test is currently passing.
I suspect the vendor isn't running with current code that includes following at the start of validateCmdsInCmdBuffer():

if (!pCB->activeRenderPass)
        return false;

I agree that should render my current PR unnecessary.


[TEST] Implement 2 stage upgrade

What's the test to develop? Please describe
Upgrade should support 2 stage upgrade testing like 1.2.1 -> 1.2.2 - > 1.3.0

close as this has been implemented.


Сhoice of the value of taxonomy to the condition

Hi!
how much will it cost to add a function:

is a standard taxonomy: Category
added taxonomy: Status
There is a common statuses for all categories.
There is a status only for certain categories.
The plugin should provide a general status of select either or status for a particular category.

For example:
A. have five common statuses: Identification, Registration and Training, Implementation, Completion, Archive. These statuses should be selected from all entries.
Two. add the two values of taxonomy "Status" type: Issued and denied for the category "Category 1".
Three. plugin must add two entries to select only those positions that are marked as "Category 1"
p.s. I bad speak English )

This is definitely beyond the scope for this plugin, but would be a good concept for an additional Advanced Custom Fields add-on. You may try asking in the support for the ACF plugin if anyone has implemented this or would be willing to.
At this time, I'm only maintaining (bug fixes) the add-ons I've written and not implementing any new features.


Add finding local minima exercise

Looks good to me

Basic

Created config and files for minima. See pull request #45.


Break monolithic jobs into smaller services

Add sanitize inputs job
Rename project_types to process_source
Rename event_types to check_context

This is the first of a set of commits
to refactor large jobs into smaller components.
This will allow more control over dependencies
while speeding up runtime since more jobs
can run in parallel.
Change-type: major
Signed-off-by: Kyle Harding<EMAIL_ADDRESS>

@klutchell since this is fairly big to try and eyeball for errors, let's pick up a number of test repos and spin up PRs in these pointing to this flowzone branch. We'll need to test every type of project, so some candidates I can think of are:

balena-io/balena-cloud | product-os/jellyfish
balena-io/etcher | balena-os/balena-engine
something with Rust
balena-io | product-os environment-* (docker-compose)
something with NPM

@klutchell since this is fairly big to try and eyeball for errors, let's pick up a number of test repos and spin up PRs in these pointing to this flowzone branch. We'll need to test every type of project, so some candidates I can think of are:

balena-io/balena-cloud | product-os/jellyfish
balena-io/etcher | balena-os/balena-engine
something with Rust
balena-io | product-os environment-* (docker-compose)
something with NPM

Once I get these set up I will link the test PRs in the body of this PR.

Created draft PR:

Created draft PR: https://github.com/product-os/environment-staging/pull/471

Created draft PR: https://github.com/balena-io/environment-staging/pull/1081

Created draft PR: https://github.com/balenaltd/handbook/pull/66

Created draft PR: https://github.com/balena-io/balena-cli/pull/2587

Created draft PR: https://github.com/balena-io/docs/pull/2501

Created draft PR: https://github.com/balena-io/balena-api/pull/4077

Created draft PR: https://github.com/balena-os/balena-supervisor/pull/2111


Helm 3 - legacy dependency conditions not respected

Output of helm version:
version.BuildInfo{Version:"v3.0.0-alpha.1", GitCommit:"b9a54967f838723fe241172a6b94d18caf8bcdca", GitTreeState:"clean"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:11:31Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1+IKS", GitCommit:"7212ba91727da63ce9cfb2b5eba7f988f0f125d0", GitTreeState:"clean", BuildDate:"2019-05-09T14:28:29Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
IBM Cloud (IKS)
I have a helm 2 chart that includes another chart by this content in requirements.yaml
dependencies:
  - name: cp-helm-charts
    version: 0.1.0
    repository: https://confluentinc.github.io/cp-helm-charts/
    condition: kafka.internal.enabled
  - name: openldap
    version: 0.3.0
    repository: https://kubernetes-charts.storage.googleapis.com/

However if kafka.internal.enabled is set to false (in my case values.yaml sets it to true, but I have content in an additional file specified by '-f ~/cloud.yaml which sets it to false), the cp-helm-chart (confluent kafka) IS deployed regardless

@planetf1 thanks for opening
Perhaps somehow related to https://github.com/helm/helm/issues/5757

This issue happens even for dependencies specified in Chart.yaml. I have set up an example at https://github.com/hd-rk/helm-examples/tree/develop/v3-condition.
I took a look at the code, it might be because the function for processing sub-chart conditions/tags is not called in action.Install.Run
https://github.com/helm/helm/blob/ff818fceca20a4a5414fa26bcf63a305c6ef9343/pkg/chartutil/dependencies.go#L27-L32
Howerver, it's actually called in action.Upgrade.Run
https://github.com/helm/helm/blob/ff818fceca20a4a5414fa26bcf63a305c6ef9343/pkg/action/upgrade.go#L67-L70

closed via #6084

I cloned the helm repo and rebuild dev-v3 (as of today).
I then retried the deployment of a chart which worked ok with helm2
I hit the same problem as originally reported.

I built from dev-v3 and can confirm the issue is fixed

Running 3.0.1 and I seem to be running into this issue. Using helm package or helm install, with the condition set to false, it still asks me to run a dependency update, which downloads the dependency marked as not enabled. When I package it, it removes the condition in the archive, and if I install it direct, it ignores it.

running 3.0.2
apiVersion: v2
description: A Kong chart for Kubernetes
name: kong
version: 0.1.0

dependencies:
- name: postgres
  version: "0.1.0"
  repository: "file://../postgres"
  condition: postgres.enabled, kong.postgres.enabled
- name: gcloud-sqlproxy
  version: "0.1.0"
  repository: "file://../gcloud-sqlproxy"
  condition: gcloud-sqlproxy.enabled, kong.gcloud-sqlproxy.enabled

and values.yaml
gcloud-sqlproxy:
  enabled: false
postgres:
  enabled: false

helm packages ask me to run a dependency update
and when it package it don't remove deps
and when upgrade neither

Still not working one year later (v3.1.1)...

@marcadella Did you have a particular use case that broke? Please provide more details.

@technosophos I stopped using Helm because of this (and many other issues). But there has been example posted above such as this one describing thoroughly the issue.

I am aware of several issues, @marcadella, and am in the process of finding and fixing as many as I can. There are actually several intertwined issues that seem to combine in different ways. When I saw your issue above, I thought that perhaps you would like to contribute a problem case so that I could continue my list.
This particular feature was hit hard by the loss of the core maintainer who wrote and maintained this code. The rest of us are trying to learn how these features are supposed to work. So it has been hard going for us. We almost just removed the entire set of features... but lots of people seem to at least want to use them. So I've taken on the task of trying to untangle the net.

This issues have already been present in v2 (#4490, #3734) and fixed by #4917, which per comments should be merged into v3. It looks like we still don't have this fix here - it hasn't been mentioned in any release notes for v3.

That PR you mentioned was merged into helm 3.0.0-beta.4.

 But I want to share my findings in case that someone here tripped about the same thing:
After defining a dependency in a childchart, you must helm dep up in the parent chart, otherwise the changes are not pulled in (for obvious reasons). Here is my working configuration:
## Child Chart.yaml
apiVersion: v2
name: child
description: A Helm chart for Kubernetes
type: application
version: 0.1.0
appVersion: 1.0.0
dependencies:
- name: mssql-linux
  alias: mssql
  repository: https://kubernetes-charts.storage.googleapis.com
  version: ~0.11.2
  condition: mssql.enabled

## Parent Chart.yaml
# ...
dependencies:
- name: child
  version: 0.1.0
  repository: file://../child/

## values.yaml
child:
  mssql:
    enabled: false

Setting the value child.mssql.enabled to true will render the child > child dependency again. 👍

I just ran into this after converting all of my v2 charts to v3 charts after following the documentation. Can we please remove this section or at least call out that this feature doesn't actually exist in v3.x yet?
Is there any effort happening on this anymore?

Running into this as well, helm 3.3.4.

Running into this as well, helm 3.3.4.

We have the same problem with this helm version
@bacongobbler can you please consider reopening this issue?

We are facing the same issue as well on helm 3.5.3.
Currently, we use tag as a workaround:
# parent values.yaml

tags:
  subchart-enabled: true

# parent Chart.yaml
dependencies:
- name: subchart
   ...
   tags:
   -  subchart-enabled

for more information, please visit: https://helm.sh/docs/chart_best_practices/dependencies/#conditions-and-tags
By the way, the issue should be reopened or simply remove the conditions part from the doc, it's really confusing.

Same issue in 3.6.0. The tags workaround suggested by @benjamin658 doesn't appear to work either.
Please, at the very least remove the page on conditions/tags from the docs. Even better, explicitly document that this is not possible and suggest design alternatives. I wasted way too much time figuring this out because of this nonexistent feature being documented.

Does anyone have an example that works with Helm 3.7.1 to exclude an optionnal dependency ?

tags:
  subchart-enabled: true

I can confirm this workaround with tags worked for me. I used HELM 3.7.1!
The conditions still doesn't seem to work as expected.

similar to riker09's comment in case some are stuck:
I was doing everything right, but forgot that the chart still had the following at the top of Chart.yaml
apiVersion: v1
...

You do need to be on helm 3, but you also need to ensure your chart apiVersion is v2
apiVersion: v2
...

Since I originally opened I felt obliged to add a quick update as I see the discussion is still going here -->  I have refactored. All is now working. Dependencies are now in Chart.yaml. API version is v2, and conditions are working fine

@planetf1 With latest helm 3.10, api V2 I am still seeing the issue. Which version of Hem you are using? Can you please share any sample chart to test ?

@chandanghoshsfos I use it a few of our egeria helm charts, for example egeria-base .
We require 'strimzi' to setup these examples, so in our Chart.yaml we depend on it by:
dependencies:
  - name: strimzi-kafka-operator
    version: 0.32.0
    repository: https://strimzi.io/charts/
    condition: strimzi.enabled

Then for our chart, in the values.yaml  file I default this to true
# Normally we install the strimzi operator as part of the Chart. However this requires admin permissions, and
# will create cluster-scoped resources. Set to false to skip this when in a restricted environment, or needing multiple
# installs of egeria charts in the same cluster. Requires the strimzi operator to be
# installed on the cluster by an admin, or a prior install
strimzi:
  enabled: true

In our docs we tell users to specify an extra parameter if they want to omit strimzi ie:
helm install base egeria-base --set strimzi.enabled=false

This all works a treat. Hope that helps and feel free to ask any other questions about our simple example.

@planetf1 Yes, that works!
I was in an impression that when creating a helm package (*.tgz) or checking through helm dependency update, it would include or strip out the dependency package based on the condition mentioned in values.yaml also. But, that is not the case.
But that is not a problem though. When installing the chart, since it respects the boolean flag(--set strimzi.enabled=false), so that works for me too!
Thanks a lot! 👍


Create WinINFO-RemoteSERVER.txt

Hey there! I wanted to contribute a script to your BadUSB script repository. This script is pretty straightforward and does the following:
It opens up the command prompt on a Windows machine.
Then, it creates a file with a unique name based on the current date and time.
It runs systeminfo to gather system details and saves the output into that file.
After that, it uses SCP to send this file over to a remote server. I've included example credentials and an IP address for demonstration.
The script waits for the password prompt and automatically enters the password for the remote server.
Finally, it closes the terminal.

thanks


Deb creation, setting the install path?

Is there any way we can set the install path for a deb package? Right now, it defaults to /usr/share, I'd like to specify a different directory, such as /opt/<company name>/

You should be able to set the Prefix property in your .csproj file.
The default /usr/share prefix is calculated here.
So if you add:
<PropertyGroup>
  <Prefix>/opt/my-company</Prefix>
</PropertyGroup>

the dotnet deb command should pick up that path.

@danielmoncada It seems like I've answered your question, so I'll go ahead and close this issue for now :). I also believe we're compatible with .NET Core 2.1, let me know if you find any issues.


Temporarily link to the wayback machine 10k top passwords list.

Hi, https://xato.net/ is down for "a major overhaul." I'm not sure how long it will be down, so this PR temporarily replaces the broken link to the 10k top passwords list with the wayback machine version.

thanks!


Functionality to cleanup forks after a campaign is complete

As-is, turbolift users will end up with large numbers of forks in their personal org. This is annoying, and cleaning these up is a chore.
We should have a turbolift cleanup feature to delete a user's forks.
We should discuss safety aspects, e.g. should we avoid deleting forks if:

the user's PR is still open for this campaign
the user has other PRs open from their fork to upstream
... other reasons?

Some combination of warnings/prompts may help.

In the meantime, you can use turbolift foreach in combination with the gh cli tool:
(replace $USER if necessary)
(your github token will need to have delete_repo permissions checked)
turbolift foreach 'gh api -X DELETE repos/$USER/$(basename $(pwd))'

@sledigabel's suggestion: add a label to the forked repo indicating that the fork was created for turbolift, and add a new label for each campaign that uses a given fork. Use this to add a safety guard to turbolift cleanup so that we don't accidentally delete forks that are still in use for other purposes.
Another suggestion (in parallel)?
turbolift cleanup list dumps a list of repos that could be cleaned up to a file
User hand-edits the file - potentially an interactive $EDITOR session?
turbolift cleanup apply actually does the deletion


Add Cache invalidation to Altinn 2 on delegation

Description
New Internal API endpoint for invalidating cache after a new delegation has been performed.
BFF and am-ui frontend will use this endpoint to trigger cache invalidation in Altinn 2 once all individual resource delegation requests are completed.
Endpoint URL:
PUT /accessmanagement/api/v1/internal/{{party}}/accesscache/clear
Body examples:
{
  "type": "urn:altinn:person:uuid",
  "value": "00000000-0000-0000-0000-000000000000"
}

{
  "type": "urn:altinn:organization:uuid",
  "value": "00000000-0000-0000-0000-000000000000"
}

{
  "type": "urn:altinn:person:uuid",
  "value": "00000000-0000-0000-0000-000000000000"
}

Additional Information
No response
Tasks

[x] Add controller endpoint taking uuid input
[x] Add service implementation with lookup of internal ids for the uuid
[x] Add client implementation calling SBL bridge using the internal ids

Acceptance Criterias
As a main administrator/tilgangsstyrer for a party or myself
I should be authorized to clear access cache for a given recipient identified by their uuid
once cleared the recipents reportees and rights should show be updated with the latest changes

@jonkjetiloye @rtafj @nairaz Jeg har testet den og den fungrte som forventet da lukker jeg den taske.


Resetting a datepicker causes a jump, back to 1970

I encountered this issue when I tried to add a clear button to the datepicker field, where the user can reset the input (the datepicker is used as a filter in a search function). Calling the datepicker's reset() method will set the default panel to the current date, but clicking on the previous or next month button will bring up December 1969 and February 1970 respectively.
Reproduction:
Call the reset() method of a default datepicker and then try to step to the previous or next month without selecting a date first.
It was a really strange and confusing behaviour so I started to track back the calling stack to find it's route. After debugging the behaviour in multiple scenarios
Here is what I found:
The reset() method sets the this.date variable to NULL, and while the current date is used as a fallback in the NgDatepickerComponent's init function (there is even a comment that indicates this: // this.date may be null after .reset(); fall back to current date.), the this.date variable does not get reassigned. After this if the user does not select a date value, just tries to step to the previous or next month then the prevMonth() and nextMonth() functions will still use the NULL value of this.date. But the NULL will be parsed as January 1970, and the subMonths() and addMonths() methods will return with December 1969 and February 1970, respectively.
Maybe I missed a best-practise about how to clear a datepicker but this does not seems like an intended behaviour either way.
Any help appreciated,
Thanks in advance!

For those running into this issue and waiting for it to be addressed, there is an easy workaround due to all the properties of the datepicker object being public -- create your own method to reset the variables correctly. If you set a view child property on the consuming component that references the datepicker, you can just write something like this:
@ViewChild('datepickerRef', { static: false }) datepickerRef: NgDatepickerComponent;

datepickerReset() {
        this.datepickerRef.date = new Date();
        this.datepickerRef.innerValue = null;
        this.datepickerRef.init();
}


MIssion Control not working when linear mouse is working in the background

OS
MacOS 13.4.1 (c) (22F770820d)
LinearMouse
0.9.3
Describe the bug
When linearmouse is active the shortcuts for mission control no longer work.
I do not have any settings enabled on linear mouse that use and of the mission control features (mission control and Move Left/Right a Space) Though adding that feature to a button on the mouse seems to allow me to use mission control but not in the traditional shortcut way.
Quitting linearmouse solves the issue but reopening it brings it back
The bug doesnt happen on its own by opening the program, It happens after clicking on any window, doesn't have to be linear mouse
Poorly Recorded Demonstration
https://youtube.com/shorts/bD4XpRacYVA?feature=share
To reproduce

Open linear mouse
Click on either the Icon on the bar or open preferences
Alternatively Click on any application other than linear mouse
Issue persists until quitting linearmouse even if not focused on any application

Expected behavior
Mission control works by using the shortcut ctrl + arrow keys without having to quit linear mouse
Anything else?
No response

Thanks for your feedback!
I have watched the video and the problem is quite clear. However, it seems strange that I am unable to reproduce it on my end.
Could you please try to reproduce this issue and export the logs in the General panel? I will check if there is any useful information in them.

I also have an issue with Ctrl not working. Attaching my logs from General panel.
LinearMouse.log

Thank you @hexial!
Everything in the log looks normal, except I'm not sure what LogiVirtualHIDDevice is, but it doesn't seem like it would cause the control to fail.
Are you using an external keyboard or the built-in one? And. have you encountered the same situation as @angaylo22 where this issue happens not until the Settings window is open?

LinearMouse.log
Sorry, I have not logged into GitHub for a while. I installed the 9.4.0 update and recreated it, here are the logs.
I have now figured out the issue to recreate it properly
Use the same exact steps top reproduce, however I forgot to mention that I have this:

removing it fixed the issue and re-adding it brings it back.
hopefully It is possible to fix.

I will also note it does not happen on linear mouse v9.2.0

@angaylo22 Thank you! I can confirm that this bug exists.

The fix will be included in the next beta release.

Please upgrade to v0.9.5-beta.1 and see if this bug is resolved.


Skill Name
Twig
Why?
Twig is a template engine for php with a lot of features.
Reference Image

Svg Availability

[ ] I have given the official svg version of the logo in the Reference Image field.

Code of Conduct Acknowledgment

[X] I have read and agree to the Code of Conduct.

Svg Icon:

Source:https://github.com/twigphp/Twig/issues/2347


commiting A2, hoping that this is it

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

Assignment marked.


Remove bson test for kernel-mode build

Remove bson test from kernel-mode build.
Tinybson lib is located in kernel space and can't be accessed from user side tests app
Removal can be selected with config flag CONFIG_TESTS_KERNEL_MODE_COMPATIBLE
to separate it out from kernel-mode builds only

Config flag can be removed if/when bson test is fixed somehow.

Maybe unnecessary to add a flag for it, just disable in kernel mode build. This can then be reverted if it is fixed for kernel mode
Ok, I'll change the config flag with "if not flat_build" check.

Updated to build test_bson only for flat build


Make rabble an admin on planetary.name

Let's make rabble an admin and set a password for him since Planetary doesn't support sign-in-with-ssb yet.

Added him yesterday by sending him a password reset link via slack.


Float value bug

Hi,
İ have a problem like attachment file,
float values is return to bad situation

I am also facing the same issue, did you find any solution?

I made a solution like this
tspan.text(function (d) {
var n = parseFloat(d.splitted);
return (d.splitted % 1 === 0) ? d.splitted : n.toFixed(2);
});
line:6852

thank you @musaakkayaa

It's quite possible that could be a bug, but it's really hard to verify it without more information. We get a lot of reports and the more info you give us, the more likely we'll be able to address it in a timely fashion.
Please read the contributing guidelines, then add the following information to your issue:

[ ] Operating system and web browser (with version)
[ ] What version of the library
[ ] Ideally, a JSFiddle example depicting the specific problem really helps us out. Use this template for issues with 0.4.11-rc4!
[ ] If you were doing anything unusual, like using C3 in conjunction with a particular library or framework

Thank you for your cooperation — we rely on users like you to help make C3 the best charting library it can be!


Initialise React controllers via routes

Removes the dependency on Entwine in React controllers. React controllers (Campaign section) register routes with the new RouteRegister. These routes are applied to Page.js in the appBoot boot process.
I can squash this after feedback.
cc: @chillu

admin/pages loads listview and treeview twice now :(

Loading admin/assets fails with this:

I'm not getting the /admin/assets issue. I'll try updating my AssetAdmin module, could be a change in that module that's causing the issue...

All these behat tests are passing locally... I can't figure out why they are failing on travis.

The TypeError in the behat tests is caused by a conflict between using JavaScript's 'strict mode' and an ES3 fallback in a thirdparty library. Our behat tests use an old version of Firefox which requires the ES3 fallback. But this fallback uses syntax which is not valid in strict mode.

@chillu this is in danger of rotting. are you able to pick it up?

I'll put it in the "next" column on Zenhub

Behat cms build failure should be fixed through https://github.com/silverstripe/silverstripe-cms/pull/1524

The functionality works, but there's a critical performance issue where routes are being duplicated several times.
For instance, if I had visited the campaign section 4 times, every page click within that section has routes duplicated 4x

In the old code I had an exit handler that would disable routes to prevent this. I guess that code (or a variant) needs to be put back.

Removing deep-freeze broke asset-admin...

I've fixed these with https://github.com/silverstripe/silverstripe-asset-admin/pull/196.

Pushed up a fix for missing deep-freeze-strict in shrinkwrap.

Tests passing. :)

@chillu please confirm that my fixes to this PR, and to asset-admin are ok, and I'll merge.


Cannot use gettext in UWP application

Describe the bug
When I try to use gettext in a UWP application, the application failed to start.
Environment

OS: Windows 10 20H2
Compiler: VS 2019

To Reproduce
Steps to reproduce the behavior:

./vcpkg install gettext:x64-uwp
Create a new project, UWP app, C++/CX
#include <intl.h> and use gettext somewhere in code
Build and run

Expected behavior
Should run without any issue.
Failure logs
The target process aborted before activation completed.
The program '[1064] GettextTest.exe' has exited with code -1073741502 (0xc0000142) 'DLL Initialization Failed'.
Additional context
intl-8.dll iconv-2.dll ucrtbased.dll are present in the .exe folder.

Confirmed.

I tried to use libiconv only and it led to the  same error.

@JackBoosY  I tested with the commit before #11776 is merged and it was working.

@JackBoosY
I could see that in libiconv, it used GetModuleFileName to get the path and then used strchr to find the path separator.
GetModuleFileName mapped to GetModuleFileNameW but strchr is ANSI, which caused the failure in DLL initialization


Text Selection/Context Menu

It seems text editing shortcuts and context menu are disabled (missing 'Edit' in app menu)
E.g. pressing CMD + A (select all shortcut) doesn't work, which is frustrating if your wanting to quickly select and re-entering something different in the search bar.
Also right-click context menu is missing for common actions, which is probably related.

@Martin-Pitt it's not disabled. not implemented yet. Copy/paste is able to use now. but context menu is that I'm not sure it would be landed or not. however It would be great you make it PR for context menu. PR is always welcome. close the issue now.

Oh ok, sorry @ragingwind, my mistake, was confusing Electron with NW.js. (NW.js has it as a configuration)
Just for future reference, I found this article which seems to cover on how to do copy/paste: http://www.pracucci.com/atom-electron-enable-copy-and-paste.html


Inject the style classNames in the main Block Editor wrapper.

@ichim-david @tiberiuichim @pnicolli @giuliaghisini
I've been developing a project with the new style wrapper and I really think that I missed the shot when deciding where to inject the classNames.
I think that we should inject it at the very top of the Editor wrapper to be able to have enough flexibility and control over the CSS definitions in the Editor. I even think that we might save some definitions that work both for the editor and for the view mode.
I also took a closer look at EEA's style wrapper, and I think that we need to replicate the inline styling in the current style wrapper. That's why I left it untouched, the idea is that we remove the class injection, but we leave a way to inject inline definitions (if any), what do you think?
From the merged PR thinkings:
@ichim-david Several "to-dos" from the other day talk:
I think we should include the current size and align data properties in the styling classname generator.
So now we have has--align-- has--size-- classnames. See questions below.
I'm convincing myself that when we talk about width containers, the wording is not "align"... although it's a widely used concept, but it Hink that "block/container width" would be more appropriate. What happens when, we have (fairly common) use case, that given a specific container width, you still want to "justify" the elements inside the block in a way (left, center, right). eg. A button block, or a heading block.
Other use case that breaks the "align" wording is the block that has a background color, but the inner container is variable, let's say, a grid block that has a background color but the inner contents have a specific "inner width", that should be possible for a user to be able to configure.
So far, we have:

"align/inline width" (images, videos, maps) blocks alignment (I think it's the only legit use case for that wording)
"block/container width" (the outer container of a block)
"inner width" (the inner container of a block, where the content lies)

Also, as legacy, we have these properties in the root of the data structure:

size
align

all referring to image/video/maps but might be also present in custom blocks.
I think the style wrapper would have to deal with all these, and include the legacy size/align on it, generating a different set of CSS rules, so different classnames.
I do like a lot this approach, we need it for the next layout:
.addReducedTextElements() when (@reduceTextElementsSize = true) {
  @{textElementsParentSelector} {
    @{textElementsSelectors} {
      max-width: @textElementsMaxWidth;
      margin-right: @textElementsRightMargin;
      margin-left: @textElementsLeftMargin;
    }
  }
}

@textElementsSelectors: h2, h3, h4, h5, h6, p, ol, ul, blockquote;

However, as we discuss the other day, we would like more descriptive classnames, like
container-lg, etc...
and have the sizes be configurable. I agree with it, so they remain "neutral" and not tied to a name. In our last project we have:
:root {
  --layout-container-width: 1440px; // this is the header/footer container
  --default-container-width: 940px; // this is the "block inner width"
  --narrow-container-width: 620px; // this is the narrow (text elements) inner width
}

and the full-size (full viewport) in addition.
Questions:

Does the prefix has-- make any sense to you?
Should we introduce these three types of container widths in the style wrapper?

@ichim-david fixed. I will conduct more tests today with this shape.

Let's let this rest for now, do more tests and play with it.
In the meantime: https://github.com/plone/volto/pull/3412

Closing for now, we can revisit if needed


[5.2] Add tightenco/collect to replace section

Since tightenco/collect is just standalone illuminate collections from support, this replace should be added.

Sorry, we can't add unrelated packages to our composer file like that.

@GrahamCampbell Are you sure about that?

What I was really meaning is, I doubt we want to. Leaving for Taylor to decide. :)

@GrahamCampbell Thanks Graham! :)

how is this unrelated?

If you want to see reasons for and against this PR, take a look at this thread. https://github.com/tightenco/collect/issues/4
@frankdejonge argues against this PR; others argue for it.

In general third parties should not distribute laravel code like that. Laravel itself should publish this if it wanted it, surely?

@GrahamCampbell ¯\(°_o)/¯ I agree! But after taking that stance, Taylor and I looked into what it would take for Illuminate to offer this and decided it added a ton of unnecessary complexity to the core for a relatively edge-case need.
So, with his blessing, Tighten took on the task of splitting it out for folks who need it separately.

I absolutely agree with "Laravel should publish it", however since collect exists I thought this would be the right way to go.

I agree that this is probably OK in the special case of tighten/collect which is an exact copy of collections including the namespace.

Thanks @taylorotwell, @eFrane, and @GrahamCampbell :+1:
And for future reference: if this sets a problematic precedent at any point in the future, please feel free to drop this line for the same of Laravel purity; I want this to be a service, not a burden.

Note that this is still not going to work.

You need to make the support subsplit replace it too...

@GrahamCampbell This may be a dumb question, but where exactly is the "authoritative" illuminate/support composer.json? Is this just the one in the illuminate/support repo or are these generated during the subsplit process?

The one in laravel/framework please. :)

Then I don't get what there is to be done for

You need to make the support subsplit replace it too...

Then I don't get what there is to be done for

https://github.com/laravel/framework/blob/5.2/src/Illuminate/Support/composer.json needs updating please.

I'm so blind. Will do.


Unable to convert the saved model to tensorrt.

After running the convert_trt.py is following error

I've tried to find any solution but with tensorflow-gpu 2.3.0 have nothing found.
Probably I have wrong installation of TensorRT for Windows? Could you explain how you have integrated TensorRT with tensorflow. Because of tensorflow (also gpu version) couldn't find TensorRT-packages.
Thank you!

The TensorRT API in Tensorflow is not supported on Windows (you will find it if you take a look the source code).


mitigate async reserved keyword

#24 fixed by renaming instances of "async" to "asynchronous".

Coverage remained the same at 98.765% when pulling 1d4a506527042f836ecfaf543131c9ea3365a58d on NickPancakes:py37-fix into 9d84998606e1e1be38a841b46b42c799e3cdff36 on mrname:master.

Looks like py37 isn't working on Travis at the moment.
There's a workaround posted on travis-ci/travis-ci#9815 . I could add
dist: xenial sudo: true
to get py37 to work on Travis if you're comfortable with those changes.

Sorry, didn't realize that Travis does not have official support yet, let's not worry about it until this is provided.

Alright I think we're set. I did also test with py27 with async=False in test_get_load_time and it did in fact work as expected.

Thanks for humoring me @NickPancakes, looks good! Will try to cut a release today or tomorrow. Thanks for contributing!

Not a problem, thanks for the lib!


feat: improve performance with multiprocessing

I improved the scanning performance by 2.5x on my workstation. Note that this is a quite big change in the codebase and not tested rn.

multiprocessing.freeze_support() is needed on all plattforms


Added @latest to the npx @backstage/create-app

Hello Team! :wave:
Noticed while talking to @benjdlambert that using npx @backstage/create-app@latest stops errors when you try to sometimes run npx @backstage/create-app with some dependencies.
I updated it in most of the files... however I am not sure if I should do it everywhere or just in the getting started.
Let me know if I should make any additional changes.
Thanks!
Signed-off-by: Peter Macdonald<EMAIL_ADDRESS>Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Ohh I need to make a few changesets for this apparently 😅.

@benjdlambert do you want me to update it in all those locations or just in the 'getting started' page?

I think that we should just update docs/getting-started/*.md as they're the only ones that you're required to run it in, the others are just references to how you created your Backstage instance.


Cannot delete their own request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Break down in numbered steps

User A requests X from User B
User B request the same X from User A
User B cannot delete their request from the header
When you navigate tot he IOU report
Delete the money request from the popover menu

Expected Result:
Describe what you think should've happened
You should be able to delete requests you have made.
When deleting from the popover menu, the request is deleted
Actual Result:
Describe what actually happened
Unable to delete the request
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691836416831359
View all open jobs on GitHub

cc @luacmartins if you are interested

I have attached a screen recording here to make it easier for you to follow.
https://github.com/Expensify/App/assets/10254571/036f8290-ca82-47cc-9313-85a8c577bed2

The issue is interesting, for IOU reports the verification fails to confirm the user is owner of the transactions here becuase the cardID is linked to the user who is payer and thats because we link all the transactions on the IOU report to the payer (person who owes money) here.
This is really interesting issue @luacmartins

hmm we might have to add some new logic to check for the cardID and signs of each transaction as well 🤦

I am really curious why we doing this and if we have to be doing this.

@tranvantoan-qn Can you please confirm this works now?

@mountiny
It worked, there is NO error when deleting the request and the Delete option is showing correctly for each sender
But I'm wondering how the navigation flow should work to avoid the Hm... It's not here page since the request/report is deleted.
https://github.com/Expensify/App/assets/10254571/115b32b1-95cb-46b8-8b43-90744630e3ef

@tranvantoan-qn we're investigating that as part of https://github.com/Expensify/App/issues/25698

Perfect so I think this is ready to pay out

@mountiny Is the payout date 2023-08-30 or 2023-09-04?

Correct date should be 2023-09-04. This PR was deployed to production 3 days ago

Okay thanks. @mountiny Is it safe to consider this a feature request? Also do we need a regression test here? I don't think we do.

@mananjadhav This was a bug as there was backend issue with the permissions.
I think we need a regression test which will cover all the possible permission cases

@mountiny Can we use the test steps from the PR?

you can probably use those from the issue here yeah

Okay thanks. Can @anmurali help here to add the regression tests? or can you take care of that @mountiny? I don't have the access to create those.

Can you just write it down in the format that can be copy pasted and @anmurali will take care of that

$1,000 payment approved via NewDot based on BZ summary.

@JmillsExpensify Can you send me Offer for reporter role via Upwork?

@JmillsExpensify @anmurali also reporting bonus $250 to @tranvantoan-qn please, thanks!

No worries, I'll take it.

@tranvantoan-qn Upwork job is now public here: https://www.upwork.com/jobs/~0140d2e85164cfdf25. Can you apply for $250 and I'll issue payment?

i've applied for the job, thanks!

just waiting for the payment now

Hired in Upwork.

All paid out and contract closed. I think we're done here.


change min from ts

I used the library in angular5, and min not working when I set ngmodel from typescript, there is a way to control min attribute from typescript?

Pleas use StackBlitz to build an app and show the issue you mention about
I would close this until it is confirmed as an issue.


feat: add async storage as parameter to support pkce flow

What kind of change does this PR introduce?

Adds authFlowType parameter and asyncStorage to support pkce flow.

To be merged and released after https://github.com/supabase/gotrue-dart/pull/135

@Vinzent03 Thanks for the approval. Let me bump the version and push a commit to this branch right now.


Groq Integration

Since Groq follows OpenAI API, would it be possible to add support for it in the library?

As far as I understand, this might not be possible as Groq OpenAI API interface doesn't support logprobs:
Groq Cloud Documentation (https://console.groq.com/docs/openai):

@rlouf am I mistaken?

Has anybody been able to run this for Groq?

@andupotorac @sharanry I don't see any documentation supporting structured generation.
Even if a logit_bias argument was available, we still wouldn't be able to perform structured generation. In structured generation, the token filter changes every generation step.

Might be helpful to try to reach out to them and see if they implement something like you need?

I wonder if SambdaNova supports them? https://community.sambanova.ai/t/sambanova-cloud-api-reference/197


Add "disable-on-click" function to links for maps via Stimulus

This at least provides some feedback to the user that we're working on their request, and disables double clicks on the link.
To add this to other links, add data: { action: "links#disable" } to the tab or link helper.
The Stimulus links_controller will intercept any link on the page.

coverage: 94.507%. remained the same
when pulling ba7e01c06404e893f744f406fa6efaa8b8806cbe on nimmo-disable-on-click-controller
into 80c3fe58c1a1172498939eaf8ebad6dc68ddd0dd on main.


Error: WebDriver.init() when starts GUI tests

Hello everyone.
I used Ubuntu 22.04(VMWare 16) and Geckodriver 33.0, IPMI tool alredy insstalled, and I got the trouble with GUI tests.
Its isn't working, I get the error on every test:
Verify Navigation To Sensors Page :: Verify navigation to Sensors ... | FAIL |
Parent suite setup failed:
Keyword 'Retry Browser Login Attempts' failed after retrying for 2 minutes 10 seconds. The last error was: TypeError: WebDriver.init() got an unexpected keyword argument 'firefox_profile'
Can you help me, please? What I need to do? Thanks a lot!

@kaospwnz  Can u check this setup and see if it matches or is similar for running Web UI test bucket runs
https://github.com/openbmc/openbmc-test-automation/blob/master/docs/gui_setup_reference.md

Adding @rahulmah  to as well give his opinion on the above

Just try providing OPENBMC_USERNAME and OPENBMC_PASSWORD like below while running your suite and see if that works out for you.
python3 -m robot -v OPENBMC_HOST:x.x.x.x  -v OPENBMC_USERNAME:${BMC_USERNAME} -v OPENBMC_PASSWORD:${BMC_PASSWORD} \ -v GUI_MODE:header gui/gui_test/<Path_of_your_suite>

@kaospwnz all good ?

Closing the ticket.. If not working please re-open.. Thanks


Start Brevent Service from Shizuku?

Hello. It seems starting Brevent service through Wireless Debugging makes unstable Shizuku service, meanwhile starting Brevent service from Brevent ".sh" local script keeps both services running fine. Could you add an alternative to start Brevent server from Shizuku on next version?

You can activate Brevent Server first, then activae other shell script.


Fix Vulkan crash with many Omni/SpotLights, Decals or ReflectionProbes

Fixes https://github.com/godotengine/godot/issues/56657

When ClusterBuilderRD attempted to allocate memory for a buffer, it accidentally reserved memory for RenderElementData pointers instead of actual structures. This caused it to allocate much less memory than it thought, so when enough cluster elements were in a scene it overflowed the buffer. Easy to see with ASAN enabled in the issue MRP, if it doesn't crash after some camera movement resizing the window seems to trigger this bug immediately every time.
By default Max Clustered Elements in ProjectSettings is 512 items. This times 4 (clustered item types) is 2048 elements. sizeof(RenderElementData) is 80 bytes and pointer size is 8, so only 10% of needed memory is actually allocated. 10% of 2048 elements is roughly 204, and as Calinou and qarmin noted 103 (or 102) OmniLights and SpotLights (total of 206 elements) will start crashing as this is roughly where the buffer overflows the actual allocated size (204 elements) and causes an access violation or memory corruption.

Thanks!

Cherry-picked for 4.1.2.


[uflow] trained model checkpoints

Dear authors @AustinCStone @eladeban,
I would like to benchmark your model, however I cannot find the trained model checkpoints.
Would you be willing to share the files?
Kind Regards,
Stefano

Hi Stefano,
Thanks for taking a look at our work.
I am not sure we have the files and more, what exactly are you looking for?
Best,
Elad
On Wed, Apr 21, 2021 at 5:20 AM Stefano Savian @.***>
wrote:

Dear authors @AustinCStone https://github.com/AustinCStone @eladeban
https://github.com/eladeban,
I would like to benchmark your model, however I cannot find the trained
model checkpoints.
Would you be willing to share the files?
Kind Regards,
Stefano
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google-research/google-research/issues/675, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJTI4NSUBOXYANYV6BTIC33TJ27JLANCNFSM427U7RAQ
.

--
Elad Eban  |  Research Scientist  |  @.*** |  go/reModel

Greetings Elad,
if possible it would be great if you could upload the tensorflow checkpoints to replicate the results in table 14 of your paper https://arxiv.org/pdf/2006.04902.pdf.
The files should be two and similar to the checkpoints of this repository https://github.com/ppliuboy/SelFlow/tree/master/models/Sintel
thanks for your reply,
Stefano

Hi Elad,
I can not find your checkpoint now,  could you please share your validation EPE on KITTI 2012, KITTI 2012, Sintel Clean and Sintel Final train set?  EPE on all pixels can be found in your paper, but detailed EPE values, i.e. NOC and OCC (EPE on non-occlusion pixels and EPE on occlusion pixels) can not be found in your paper. Waiting for your sharing.
Best,
Kunming


[Application] Fix Resnet Application -ENABLE_TFLITE_INTERPRETER CASES

Now TFLITE Interpreter is not support loss : cross type
So in Resnet Application we made some macro to make them mse and there was some wrong part
in ResNet Application there was another macro for ENABLE_TEST GTEST's result assume that Application use cross loss
For Correct Result Fix some #if statement
TODO :  even if fix this situation TEST still failed regardless of tflite export releated code. it seem to be data feeding problem
../Applications/Resnet/jni/main.cpp:233: Failure
Expected equality of these values:
  training_loss
    Which is: 4.3914199
  4.389328

../Applications/Resnet/jni/main.cpp:234: Failure
Expected equality of these values:
  validation_loss
    Which is: 11.514971
  11.611803

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2195. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


[Download Area - Landscape] Landscape Support UI Required

Currently, the UI of the Download Area screen looks like the above screenshot, which is hard for user to use.
We need landscape based screen UI.

@gino-m  I'm thinking we need to update the design so the background containers for both the header and buttons are transparent, otherwise theres no way to make more of the screen show. Additionally, wondering if we are able to hide the clock and cell bars on landscape mode to give us more height? The top is with the clock bar and bottom screenshot is without

We spoke with @anandwana001 and @kenstershiro. @rawbzz Hiding the system tray is non-trivial and would only give us a few pixels anyway. Let's submit a fix for the crash first. The current UI isn't ideal, but improving it isn't high priority at this point.

@anandwana001 If this is working please close and this issue.

Yes, it's working fine on Landscape mode


video block balks with some vimeo URLs

example:  https://player.vimeo.com/video/903314193

https://main--famous-smoke-cigaradvisor--hlxsites.hlx.page/cigaradvisor/drafts/tmaret/blocks/vimeo-oh-no


Copying data from results grid to clipboard takes minutes

Type: Bug
simple select on azure SQL DB.
click a 'cell'
press ctrl-C
popup 'coying data...'
wait 10 seconds
paste  -  get old clipboard
wait 60 seconds
popup changes to 'copied'
past - get new text from clipboard
Azure Data Studio version: azuredatastudio 1.46.1 (ba29842b81dec01177415e53948ca2168e69c3f8, 2023-10-02T18:14:22.887Z)
OS version: Windows_NT x64 10.0.22621
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
13th Gen Intel(R) Core(TM) i9-13900KF (32 x 2995)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.82GB (9.92GB free)

Process Argv

Screen Reader
no

VM
33%

Extensions (8)

Extension
Author (truncated)
Version

sqlops-combine-scripts
Bat
2.0.1

copilot
Git
1.95.239

dacpac
Mic
1.14.0

profiler
Mic
0.14.0

schema-compare
Mic
1.21.0

sql-database-projects
Mic
1.3.1

extra-sql-script-as
pac
0.5.0

vscodeintellicode
Vis
1.2.1

It shouldn't take that long.

What kind of data are you trying to copy?
Can you reproduce it consistently?
Please gather and upload logs we can investigate.

Can you provide additional info:

How long did the query take to execute that you're copying results from?
Did you copy results instantly after execution, or editor/IDE was left open for more than 5-10 mins before copying?

Logs would be helpful too, if you can provide.

Execution time for query is 2 seconds, with 20.120 rows as a result. Copying all rows takes 1m 23s and was done as soon as the query was done executing.
I can only provide logs that don't hold any kind of personal data or information. If you list the log files that don't contain that I can send them to you!

I have the same problem. I made some local refactoring to make it much faster. I wanted to create a pull request for it but I was unable to push my branch. If someone can guide on what to do I can create a PR.

In case someone wants to create a PR, the change is a one file change and it's src/sql/workbench/services/query/common/gridDataProvider.ts. The problem is caused by using reduce function on a string array (rowValues.reduce) and I just changed that part into creating an array, pushing the elements into the array and doing .join("") at the end.

@serhat359 You can fork this repository and create a new branch in the fork and open PR with your change.
We are happy to welcome contributions, if you face a challenge - let us know!

I created the PR https://github.com/microsoft/azuredatastudio/pull/25152. It's currently awaiting approval for running the workflows.

closing issue since the improvement was merged. Thanks for the contribution!

@serhat359 could you do some benchmark testing and share a rough estimate on the % improvement in transferring data into the Windows clipboard?

@OzBob In the PR https://github.com/microsoft/azuredatastudio/pull/25152 I have some benchmarks, you can take a look at those. The performance improvement depends on the number of rows being copied into the clipboard. At low number of rows the gain is not really noticeable but at 10,000 rows and 50,000 rows we see 450x and 3,000x improvement respectively.

I just realized the performance gain seems to happen only when the setting "Prefer Providers Copy Handler" is off. When this setting is on, ADS uses the copy handler from the provider which performs bad when the number of rows is high. Internally it might have the same problem. I did some debugging to figure out the issue and it might be caused by the package azdata but I'm not entirely sure. But I guess I'll be turning the setting off for the time being.


Fix links on resource

links are not clickable at end of article
cover image is too fat
fix some typo on command

LGTM

19 words might be misspelled, please check them: addkey, AppData, cleé, d'OpenPGP, évévenement, gnupg, GnuPG, gpg, igning, io, keybase, l'identitié, openpgp, OpenPGP, PGP, regénérer, RSA, tthuon, Yubikey


Add dependeny and update documenation

Hi,
could you please add Reachability as a dependency and/ or write this in the documentation? I added pod 'ReachabilitySwift', '~> 2.1' to my podfile and needed to update your example to the code below:
func application(application: UIApplication, didFinishLaunchingWithOptions launchOptions: [NSObject: AnyObject]?) -> Bool {

        setupCaching()

        return true
    }

    private func setupCaching(){

        do{
            let reach = try Reachability.reachabilityForInternetConnection()
            try reach.startNotifier()
            let kB = 1024
            let MB = 1024 * kB
            let GB = 1024 * MB
            let isOfflineHandler: (() -> Bool) = {
                let isOffline = reach.currentReachabilityStatus == Reachability.NetworkStatus.NotReachable
                return isOffline
            }
            let urlCache = Mattress.URLCache(memoryCapacity: 20 * MB, diskCapacity: 20 * MB, diskPath: nil,
                mattressDiskCapacity: 1 * GB, mattressDiskPath: nil, mattressSearchPathDirectory: .DocumentDirectory,
                isOfflineHandler: isOfflineHandler)

            NSURLCache.setSharedURLCache(urlCache)
        }
        catch let err as NSError {
            print("Error with caching: " + err.localizedDescription)
        }
    }

The snippet below also doesn't compile in iOS9 because the interface seems to have changed...
It would be very helpful if you could provide a demo project.
if let cache = NSURLCache.sharedURLCache() as? Mattress.URLCache {
    let url = NSURL(string: "http://www.buzzfeed.com")!
    cache.diskCacheURL(url) { [unowned self] webView in
        var state = webView.stringByEvaluatingJavaScriptFromString("document.readyState")
        if state == "complete" {
            // Loading is done once we've returned true
            return true
        }
        return false
    }
}

Thanks, I will check into this and create an example project. We'd like to avoid adding Reachability as a dependency so that apps can use whatever they are already using for their other reachability needs. However I'll definitely get the README updated to make this clear.

Thanks for the example! Unfortunately it crahes on the device:
dyld: Library not loaded: @rpath/Mattress.framework/Mattress
  Referenced from: /var/mobile/Containers/Bundle/Application/06C714F0-3FDE-45D6-A73F-3B8A1DC8ECEA/MattressExample.app/MattressExample
  Reason: image not found

It sounds like you may have not run the example from the workspace. When run this way it will build Mattress as a dependency, otherwise the framework won't be there and you'll see the issue you've run into. I've verified it's working for me (after cleaning and deleting derived data just in case), so if you still have issues from the workspace let me know. Instructions were added to the README to hopefully make this clear.
Unfortunately it's not as simple as adding a text field to load a different URL, as there often may be additional work that has to be done in the diskCacheURL loadedHandler. For example, if images are loaded lazily / progressively, the JS methods to load these images will have to be triggered. If you are caching web content under your control, it's possible to make this process easy (or even unneeded), but for arbitrary pages there may be some work that has to be done to figure out what all needs to be done to fully load content for a particular page. This should probably be more clear in the README.
Caching must be done manually for each URL, but fallback when loading a URL in any UIWebView is automatic based on what is returned to the isOfflineHandler setup in the app delegate. In most cases this will just be returning the offline status from Reachability or something of that nature, but you could possibly create a more complex set of rules. However, I think that's outside the scope of an example.
If the completion handler is not being called, it is likely that you're never returning true in the loadedHandler. If you are returning true and the completion handler is not being called, please open a separate issue.
Thanks!

Sorry - but the error remains. I have downloaded the code again, opened the workspace and did a clean. It still runs on the simulator but crashes on the device with the described error above.
Is it not possible to cache every visited site I was on automatically? The textfield is not needed anymore as I have adjusted the example url.

Could you please remove the "stuff is nil" comment? It fills my console :)

I've fixed the example project so that it should build on device now.
I've also pushed out a new version 1.0.1 that includes the removal of the debug log statements. :)
Caching every site visited is not something that is built into Mattress and a bit outside the scope of what the library was designed for. However, you may be able to make something like this work with Mattress. I'd look into UIWebViewDelegate and making calls to cache data in Mattress based on that. However, it may result in some overhead while browsing.
Thanks for all the feedback and if you run into and further snags feel free to open new issues on them.

Thank you very much!
Perhaps it helps if I explain my context: I have a hybrid conference app with some UI-WebViews that display content from my CMS. So I'm thinking about preaching all the CMS pages and deploy them with the app. When ever the user has a working internet connection the cache to get updated. And when the user is offline he shouldn't see an empty page.
Isn't this something that is in scope of Mattress? Could you give me a hint how I should build this?

Ah, I understand now. I thought you meant that the user could browse to arbitrary pages that should all be cached. You could probably accomplish this using Mattress, but it's not really built with the idea in mind of shipping files as part of the app. You potentially could run the app in the simulator and manually cache all of the URLs that you'll need accessible. You would then need to take Mattress's cache directory and include it as part of the app bundle that you ship, and specify this directory for the disk cache when you initialize Mattress. It should work, but you'd need to test it out. It was really meant to cache particular specific URLs on the fly, not an entire domain or site to be accessed later.


how to install botblocker

Questions
How to install botblocker from nginx-ultimate-botblocker using jwilder/nginx-proxy ?
I have tried to install and follow the steps, it looks like I got step number 9 and 10 remaining.
how to make sure in jwilder if I have include /etc/nginx/conf.d/*; included as well as
include /etc/nginx/bots.d/blockbots.conf;
include /etc/nginx/bots.d/ddos.conf;

are included within server block?
thank you in advance

I have fixed this, will PR to ultimate botblocker repo


fix: NFS invalid stats

Fixes issues with NFS samples not showing up and log message like:
time="2020-10-14T12:34:13Z" level=debug msg="unable to retrieve NFS stats" component=NFSSampler error="error retrieving mounts for NFS: invalid NFS per-operations stats: [NULL: 1 1 0 44 24 0 0 1 0]"

This is a bug within the underlying Prometheus NFS library, see https://github.com/prometheus/procfs/issues/275

Pull Request Test Coverage Report for Build 341890450

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 57.858%

Files with Coverage Reduction
New Missed Lines
%

pkg/metrics/sampler/sampler_routine.go
2
94.74%

Totals

Change from base Build 341771892:
0.01%

Covered Lines:
11107

Relevant Lines:
19197

💛  - Coveralls


Feature/51 migrate to gha

The tests that were run through GitHub actions passed. In the subsequent empty commit the caching was also successful.
Note: There was no docker integration step in the travis YAML file, so this workflow only has one job which is the unit test.

I realized there is a separate issue for adding the docker integration. I will also add them here.

Codecov Report

Merging #57 (0777a2f) into develop (809682b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #57   +/-   ##
==========================================
  Coverage      95.99%   95.99%
  Complexity       256      256
==========================================
  Files             32       32
  Lines            624      624
  Branches          38       38
==========================================
  Hits             599      599
  Misses            19       19
  Partials           6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809682b...0777a2f. Read the comment docs.

Note: currently only the Unit-Test step is present. The Docker-Integration step will be added in a different PR (see Issue #52 )

I have removed the DS_Store files, also added it into the .gitignore file.
I have removed those test files, you are right they don't work. You will find the new and correct integration test files in the next PR (#58), in this one I am just migrating the Unit-Test.
I tried manually building the Docker image and it worked. Furthermore, the docker integration tests pass in the next PR, which uses that Dockerfile to build the docker image for testing.