Sending Message to User

Hey! I like to get the full information about an user (from my contacts or not) if he writes me a message. So on PredUpdateShortMessage, i try to call the UsersGetUsers but i need an AccessHash i didnt have. how do i get it? Here is my code:
`
case *mtproto.PredUpdateShortMessage:
	{
		caller := mtproto.RPCaller{RPC: s.mconn}

		inputUser := &mtproto.TypeInputUser{
			Value: &mtproto.TypeInputUser_InputUser{
				InputUser: &mtproto.PredInputUser{
					UserId:	u.(*mtproto.PredUpdateShortMessage).Id,
					AccessHash: ???,
				},
			},
		}

		idArray := []*mtproto.TypeInputUser{
			inputUser,
		}

		_, err := caller.UsersGetUsers(context.Background(), &mtproto.ReqUsersGetUsers{
			Id: idArray,
		})

		fmt.Println(err.Error())
	}

@Skyforces Thanks for your interest in my code. You can get user hashes using ContactsGetContacts. It also needs a hash, but you can just assign 0 to it as below.
caller.ContactsGetContacts(context.Background(), &mtproto.ReqContactsGetContacts{})

I added this example to examples/simpleshell as 'contacts' command.

Thanks for your quick reply. With your example i get all my contacts and the access hashs. It works fine but im missing Bots and foreign users, which aren't in my contact list. Maybe i understand the getUser function wrong?

@Skyforces I think
caller.MessagesGetAllChats(context.Background(), &mtproto.ReqMessagesGetAllChats{})

would work for that. It returns all the chats and channels.

It works quite good so far. Still have some question, sorry i didn't clarified them. What is the function of MessageGetChats and UsersGetUsers? I thought you can get a specific User/Chat/Channel with them based on ID. Like this:
ids := []int32{u.(*mtproto.PredUpdateShortMessage).UserId}  chats, _ := caller.MessagesGetChats(context.Background(), &mtproto.ReqMessagesGetChats{ 	Id: ids, })
Second is about the implementation of the InputUser. There are too different types, inputUserContact and inputUserForeign. One with access hash and one without. How is this implemented in your api?

@Skyforces  MessagesGetChats() needs a chat or channel ID, not an user ID. MessagesGetAllChats() returns TypeMessagesChats, which would be one of PredMessagesChats and PredMessagesChatsSlice. The both have an array of TypeChat. TypeChat is one of PredChat, PredChannel, ... . PredChat and PredChannel have an id, and you can use it for MessagesGetChats().
Now InputUser has no types of inputUserContact and inputUserForeign. Telegram's mtproto document is too old, so you should refer to the protocol definition in this protobuf file; Telegram's document version is layer 23, the latest one is layer 81, and mine is 71.

Okay, I undestand this now. You pushed me to the right point. Thank you! Keep on your good work!


⚠ Bofrost.lu has degraded performance

In f141e58, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1429 ms

Resolved: Bofrost.lu performance has improved in 7ea89c6 after 8 minutes.


Add WebAcl construct support for cloudfront

fixes #178
It's sometimes necessary to protect our cloudfront distribution with a
WAF2/WAF Classic web ACL. A very first simple approach would be to allow linking
an existing WAF resource.
Basically following should be possible:
constructs:
    website:
        # ...
        webAclId: arn:aws:wafv2:us-east-1:{account}:global/webacl/{webacl_name}/{webacl_id}

Help
I never contributed on any serverless plugin, so could someone help me out for adding tests and how I can run them on my local machine as out of the box the tests fail. And in the contributing guidelines I didn't find anything specific to that. Thx

[ ] Adding tests

@fredericbarthelet could you approve the workflow ? I would be able then to use the test execution from the Github CI as I'm not able to run them locally. Thx

We discussed this PR earlier with @fredericbarthelet and we came up with the idea illustred in #191.
Because we don't want every construct to turn into something with hundreds of options, but also we don't want to limit users. WDYT?

@mnapoli using resources extensions as stated in #191 is more than fine. This PR can be closed then and we can then refer issue #178 to #191

Discussed in #191


 Other bosses works (not wildy ones)

Type
Incorrect behavior
Operating System
None
OS Version
No response
Bug description
Boss kill folder does not contain wildy bosses screenshots. noticed this recently by killing some Artio and spindel. Nothing is there
Screenshots or videos

RuneLite version
<IP_ADDRESS>
Logs
[launcher.log](https://github.com/user-attachments/files/17013
client.log
350/launcher.log)

Can you look without windows search?

yes, last screenshots are from barrows i was doing yesterday but after that I went for Artio (no ss) today I was farming around 100+ spindel kills (0 ss in the folder.

Are your Artio and Spindel KC 1000 or over?

no, both under. Does it stop capturing past 1k?
I have Calvarion, Spindel and Artio SS saved from previous windows installation so it was working fine before but not recently.

no, both under. Does it stop capturing past 1k?

There's currently a known issue where (some?) bosses no longer trigger a screenshot when the KC is 1,000 or over because Jagex added a comma to the message.
Can you post screenshots of what the message is when you get a KC at those bosses?

by enabling "notify when taken" option in screenshot plugin?

enable the debug option in https://github.com/runelite/runelite/wiki/RuneLite-Launcher-Configuration then launch the client, do a kill, and post the client log again

client.log

this looks fine, do you have boss screenshots turned on

yes i do, havent changed any settings and mentioned It captured plenty of barrows but no Grotesque Guardians from yesterday I now see.

actually this looks like the case fixed in #18272, the kc message has a trailing period punctuation mark which is causing the match to fail

wait for the next release


add test coverage for original author conversion during migrations

And create a function to factorize a code snippet that is repeated
five times and would otherwise be more difficult to test and maintain
consistently.
Signed-off-by: Loïc Dachary<EMAIL_ADDRESS>
forgefriends source

It looks like only one of the two approvals is taken into account and I'm not sure I understand why? :thinking:

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6f6b849). Click here to learn what that means.
The diff coverage is 39.32%.

@@           Coverage Diff           @@
##             main   #18506   +/-   ##
=======================================
  Coverage        ?   46.31%
=======================================
  Files           ?      846
  Lines           ?   121123
  Branches        ?        0
=======================================
  Hits            ?    56102
  Misses          ?    58221
  Partials        ?     6800

Impacted Files
Coverage Δ

models/release.go
49.45% <0.00%> (ø)

models/review.go
50.29% <0.00%> (ø)

models/user/external_login_user.go
28.57% <ø> (ø)

modules/migration/pullrequest.go
0.00% <0.00%> (ø)

modules/migration/release.go
0.00% <0.00%> (ø)

modules/migration/review.go
0.00% <0.00%> (ø)

services/migrations/gitea_uploader.go
29.32% <37.83%> (ø)

models/issue.go
54.34% <62.50%> (ø)

models/issue_comment.go
52.09% <62.50%> (ø)

models/issue_reaction.go
81.93% <62.50%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f6b849...204018c. Read the comment docs.


Add antigen-->antidote migration notes to docs

New antidote users from antigen might start showing up to try this project after this thread: https://github.com/zsh-users/antigen/issues/725
It probably would help those new users to have some docs specific to antigen migration.

Complete.

https://getantidote.github.io/migrating-from-antigen


Start Instance calling actual EC2 endpoint

Currently I am writing some tests using this library. Following the simple example you provide:
import boto3
from moto import mock_ec2

def add_servers(ami_id, count):
    client = boto3.client('ec2', region_name='us-west-1')
    client.run_instances(ImageId=ami_id, MinCount=count, MaxCount=count)

@mock_ec2
def test_add_servers():
    add_servers('ami-1234abcd', 2)

    client = boto3.client('ec2', region_name='us-west-1')
    instances = client.describe_instances()['Reservations'][0]['Instances']
    assert len(instances) == 2
    instance1 = instances[0]
    assert instance1['ImageId'] == 'ami-1234abcd'

I follow this example and create a test of my own, a trivial one to illustrate the point:
def start_instance(instance_id):
    client = boto3.client('ec2')
    client.start_instances(InstanceIds=[instance_id])

@mock_ec2
def test_start_instance():
    start_instance('abc123')
    client = boto3.client('ec2')
    instances = client.describe_instances()
    print instances

test_start_instance()

ClientError                               Traceback (most recent call last)
<ipython-input-6-f3b792259f42> in <module>()
----> 1 test_start_instance()

/Users/dmitry/Desktop/my-sandbox/lib/python2.7/site-packages/moto/core/models.pyc in wrapper(*args, **kwargs)
     68             self.start(reset=reset)
     69             try:
---> 70                 result = func(*args, **kwargs)
     71             finally:
     72                 self.stop()

<ipython-input-5-7ae1987ef89c> in test_start_instance()
      5 @mock_ec2
      6 def test_start_instance():
----> 7     start_instance('abc123')
      8     client = boto3.client('ec2')
      9     instances = client.describe_instances()

<ipython-input-5-7ae1987ef89c> in start_instance(instance_id)
      1 def start_instance(instance_id):
      2     client = boto3.client('ec2')
----> 3     client.start_instances(InstanceIds=[instance_id])
      4
      5 @mock_ec2

/Users/dmitry/Desktop/my-sandbox/lib/python2.7/site-packages/botocore/client.pyc in _api_call(self, *args, **kwargs)
    310                     "%s() only accepts keyword arguments." % py_operation_name)
    311             # The "self" in this scope is referring to the BaseClient.
--> 312             return self._make_api_call(operation_name, kwargs)
    313
    314         _api_call.__name__ = str(py_operation_name)

/Users/dmitry/Desktop/my-sandbox/lib/python2.7/site-packages/botocore/client.pyc in _make_api_call(self, operation_name, api_params)
    603             error_code = parsed_response.get("Error", {}).get("Code")
    604             error_class = self.exceptions.from_code(error_code)
--> 605             raise error_class(parsed_response, operation_name)
    606         else:
    607             return parsed_response

ClientError: An error occurred (InvalidInstanceID.NotFound) when calling the StartInstances operation: The instance ID '[u'abc123']' does not exist

I am working from within a virtual environment and have verified that the correct path is being called upon by using moto.__path__. The version I am using is 1.0.1 according to moto.__version even though when it is installed through pip it says moto==1.1.23 in ./lib/python2.7/site-packages. I have tried uninstalling and reinstalling as well. Please advise how to proceed.

You're trying to start an instance that you haven't created (or stopped).  Moto is replying correctly, telling you that the instance does not exist.  In order to test your start_instance method, you need to create and stop an instance in your test_start_instance method first (the call to boto3's create_instances method will return the instance identifier, which you can then pass on to your method under test).
Moto isn't like a MagicMock--it's an actual in-memory representation of the AWS resources.  So you can't start an instance you haven't created, you can't create an instance in a vpc you haven't previously defined in Moto, etc.  At my work, we have a setup_mock_aws method that essentially starts Moto and populates it with all of our expected subnets, vpcs, security groups, etc.  Then we run our tests.

@bpandola you are correct, I was under the impression it worked like MagicMock, using your suggestions I was able to go ahead and create a method which populates the services I need. Thank you. I am closing this issue.


Pool type/tag data corruption

With two types:

One being empty and the other not empty
Sharing the same namespace (or global)

When used both in ecs even with different contexts, the data specialization is incorrect and the pool is constructed as the other type.
Meaning the empty type pool gets initialized like the non-empty pool creating memory corruption on the pool pointer.

Might be related to the previous use of OwnPtr for pools and how its value and counter sometimes will point to garbage, even if debug value "instance" is correct

Fixed


Add utility function to decode LN-invoice

especially amount would be nice. Now it has to be done manually outside of the lib:
const amount = decode(invoice).sections[2].value / 1000;

I have written this exact utility a million times and would be happy to add it here.
But should this really be a utility function, or should the wallet API change in a future major update to return an invoice object that has pr, amount, memo etc?


Make PAT icons bigger

Should be the same size as the Pangea Jurisdiction icons @DeveloppSoft - let me know if you need help redoing the pngs

Closing via  751a390


Fixed issues with textures, speed, and added in panic mode.

WIP DONT MERGE
Cleaned up the code
Fixed the slime pet texture being blurry
Fixed sprite going off the screen randomly
Don't allow the sprite to go off of the screen when being dragged
Fixed the slime speed by using delta. On lower refresh rates the slime will move very slowly.
Added in panic mode:

Click on the slime 5 times, panic mode stops after 2 seconds
Panic mode also cancels out if you don't click on the slime fast enough

Actually I'm just going to open up a new PR.


Reloading the .http file in the request view.

Is your feature request related to a problem? Please describe.
I find it's not as convenient if I'm actively editing the http and testing it out using req. Whenever I update the file, I need to back out and open the file again.
Describe the solution you'd like
In the request view, the following commands are currently available:
Quit (Ctrl-Q) | Copy to Clipboard (c) | Back (Esc) | With Environment (Tab) | Scripts (s) | Send (Enter) | Logs (l)

It would be nice if it allows me to reload the changes from the filesystem using a shortcut (r for example).
Describe alternatives you've considered
The alternative would be that req actively monitors the file, and reloads it whenever there is a change.
Additional context
Add any other context or screenshots about the feature request here.

I think this would be a great addition. I had been thinking about how to accomplish this without adding additional metadata (like a guid) to the .http files. There are many changes to the .http file which could change which request is selected for the user, such as changing the request names or order, and req not knowing how to load and display the correct request again. We could always watch for a file change and then show the request select view, but this also seems like it's not an intuitive editing flow to me.


Buffering post responses before sending them to origin servers

EDIT: The behaviour described below is produced because ATS isn't buffering the requests and receiving them completely before sending them to the origin servers.
We've observed the following behaviour in our ATS/8.0.5 instances (and I can reproduce it locally with master as well). Sometimes aborted transactions are reaching the origin servers, I've been able to reproduce this locally with HTTP/1.1 and HTTP/.2 using the following curl CMDs:
# http/1.1
timeout 5 curl --http1.1 -X POST -d "test" -H "Content-Length: 10" https//<IP_ADDRESS>:3129/post
# http/2
curl -X POST -d "test" -H "Content-Length: 10" https//<IP_ADDRESS>:3129/post

Setting a really small slowlog threshold (1ms) we observe the following milestones:
# http/1.1
[ET_NET 1] ERROR: [20] Slow Request: client_ip: <IP_ADDRESS>:43428 protocol: http url: http://ats_httpbin_1:80/delay/1?random=29193 status: 0 unique id:  redirection_tries: 0 bytes: 0 fd: -1 client state: 0 server state: 0 ua_begin: 0.000 ua_first_read: 0.000 ua_read_header_done: 0.000 cache_open_read_begin: -0.001 cache_open_read_end: -0.001 dns_lookup_begin: 0.053 dns_lookup_end: 0.053 server_connect: 0.053 server_connect_end: 0.069 server_first_read: -0.001 server_read_header_done: -0.001 server_close: -0.001 ua_write: -0.001 ua_close: 4.959 sm_finish: 4.959 plugin_active: 0.002 plugin_total: 0.002
# http/2
{0x2b360f0f7700} ERROR: [40] Slow Request: client_ip: <IP_ADDRESS>:49532 protocol: http/2 url: http://ats_httpbin_1:80/delay/1 status: 0 unique id:  redirection_tries: 0 bytes: 0 fd: 39 client state: 0 server state: 0 ua_begin: 0.000 ua_first_read: 0.000 ua_read_header_done: 0.000 cache_open_read_begin: -0.001 cache_open_read_end: -0.001 dns_lookup_begin: 0.000 dns_lookup_end: 0.000 server_connect: 0.000 server_connect_end: 0.002 server_first_read: -0.001 server_read_header_done: -0.001 server_close: -0.001 ua_write: -0.001 ua_close: 0.003 sm_finish: 0.003 plugin_active: 0.000 plugin_total: 0.000

I assume that what we are seeing in our production environment is caused by clients with poor connectivity. What's bugging me the most is the fact that ATS sometimes blocks this requests and other times reach the origin servers. What is the expected behaviour here?

Apparently setting proxy.config.http.send_100_continue_response to 0 (the default value) should force ATS to buffer the request till the POST body is received and then send the request to the origin server. From the observed behaviour, this is not happening. Also the old buffer_upload plugin has been removed as part of #5395. What's the current way of buffering POST requests to stop "incomplete" requests from reaching origin servers?

Answering my own question, it looks like for ATS <= 8.x the buffer_upload plugin can be used. The plugin allows to buffer requests either on memory or on disk and set a maximum request size to be buffered on memory, but if on disk buffering is enabled, it doesn't matter the size of the request body, it will always use the disk for buffering purposes. This can result on a performance penalty for small requests.
For ATS >= 8.x proxy.config.http.request_buffer_enabled can be used after cherry-picking #6024. This option lacks disk buffering support so it's only valid on environments where proxy.config.http.post_copy_size can be set to a rather small value due to obvious security reasons. Also if the POST body size exceeds proxy.config.http.post_copy_size, a 403 is returned and the request is rejected even if proxy.config.http.max_post_size is set to 0

@jvgutierrez can this issue be closed now?

I am going to close this.  If you want to buffer a POST you should create a plugin.  We have done this ourselves before and can provide an example plugin.


Versioning and NPM

Currently there are no version tags in the repository. Also, a package.json file is not included here, although npm refers to this Github repository. Is this currently manually managed or stored elsewhere? Specifically, I want to know when my new features will be pushed to npm and under which version tag. Also, what is the release cycle?
If there is anything that can be done on that end, I'll be happy to assist.

I don't manage the npm package, someone else packaged up v86 for it. Currently the best way to get v86 releases is either to build them from the repository or the releases page, which is automatically built from latest master. If it's useful to anybody, I'd accept a PR that pushes the latest master to npm in a similar manner.
Releases are rolling. There's an extensive suite of test, but I'd still recommend pinning to a specific commit if you'd like to use v86 as a dependency.


How to create a file upload button or browse button to send file from form?

Hi I did not see any documentation for uploading file through hapi-swagger form. Is this feature not supported in hapi-swagger or any work around it.  I need a browse button to upload file for testing my api. Can any body help me?

Hi, there is a section in the readme covering this https://github.com/glennjones/hapi-swagger#file-upload also if you want to see a working code the https://github.com/glennjones/be-more-hapi example project has file upload setup for one of its endpoints
Hope that helps

Ok This is going good as long as I use thi
Joi.any()
             .meta({ swaggerType: 'file' })
             .required()
             .description('Image File')

But browse button goes away if I change .required() to .optional()

Readme link out of date, currently available here:
https://github.com/glennjones/hapi-swagger/blob/master/usageguide.md#file-upload

Ok This is going good as long as I use thi
Joi.any()
             .meta({ swaggerType: 'file' })
             .required()
             .description('Image File')

But browse button goes away if I change .required() to .optional()

How to choose multiple files using HAPI ? I am using what @brahamshakti mentioned but i can choose one file in that case. Do we need to change the swagger type in that case to something like files which helps to select multiple files?


Cannot use Protractor at all; tests hang if database.list() is called

Protractor tests hang if database.list() is called
Added a comment to #225 but that issue is closed and im not sure if my comment will get it noticed.  Apologies for double-posting.
Version info
Angular: latest released
Firebase: latest released
AngularFire: latest released
How to reproduce these conditions
Minimal repro in this repo:
https://github.com/sdebaun/af-protractor-test
Steps to set up and reproduce
ng new
npm install --save angularfire2 firebase
import AngularFireModule in AppModule
add constructor with AngularFire to app.component.ts
ng serve and ng e2e, y voila!
  - Failed: Timed out waiting for asynchronous Angular tasks to finish after 11 seconds. This may be because the current page is not an Angular application. Please see the FAQ for more details: https://github.com/angular/protractor/blob/master/docs/timeouts.md#waiting-for-angular
While waiting for element with locator - Locator: By(css selector, app-root h1)

Expected behavior
To not have the test timeout waiting for angular
Actual behavior
It times out waiting for angular

@sdebaun From what I understand, Protractor doesn't work great with Web Sockets and therefore the Firebase SDK. Your best option right now is ignoring synchronization. I've spoken with the team about improving things but nothing is planned at the moment. Since this has been awhile, is there anything you have discovered?

The problem is that the firebase sdk is setting up some long running intervals and timeouts. The database client for example sends a heartbeat every 45 seconds, which you can see in the frames of the WebSocket connection in the network tab of your browser. But just calling firebase.initializeApp sets up a 30 second timeout. Protractor is waiting those timeouts and any work scheduled by them. So any tests relying on these tasks to end will timeout.

I'm experiencing the same problem. After having spent an entire day trying to figure out why all my Protractor test were failing, I realised that either removing my Firebase service from the project or ignoring synchronization fixed the issue.
I would really like to have a full Protractor support when using FireBase in my web application.

Another solution not to loose the Angular integration with Protractor, is to extend the timeout limit. Here my protractor.cong.js
const { SpecReporter } = require('jasmine-spec-reporter');

exports.config = {
  allScriptsTimeout: 60000,  // allScriptsTimeout is 30s by default

  specs: [
    './e2e/**/*.e2e-spec.ts'
  ],
  capabilities: {
    'browserName': 'chrome'
  },
  directConnect: true,
  baseUrl: 'http://localhost:4200/',
  framework: 'jasmine',
  jasmineNodeOpts: {
    showColors: true,
    ScriptTimeoutError: 60000,  // ScriptTimeoutError is 30s by default
    defaultTimeoutInterval: 60000, // defaultTimeoutInterval is 30s by default
    print: function() {}
  },
  beforeLaunch: function() {
    require('ts-node').register({
      project: 'e2e/tsconfig.e2e.json'
    });
  },
  onPrepare() {
    jasmine.getEnv().addReporter(new SpecReporter({ spec: { displayStacktrace: true } }));
  }
};

Closing for now as it's not a angularfire2 issue. If there's something the Firebase JS SDK can do to make things more testable please open an issue there.

@jamesdaniels is it possible to run firebase outside of the angular zone?
http://www.protractortest.org/#/timeouts#angular
Seems like blaugold/firebase-rxjs is doing something of the sort.
I'm not sure if it should or can be a part of angularfire2, or if it should be a part of the SDK.
Should be related to https://github.com/firebase/firebase-js-sdk/issues/119

Any updates on this.  Being able to run firebase outside of the angular zone would solve so many issues with automation

I ran into this issue too.
I believe what @blaugold said is right: the protractor is waiting for the angular fire to finish its task in the event loop. And I will also support @maistho to run firebase outside of the angular zone if it has to keep the setInterval.


Reorganize the Stages (Tools) directory structure

Problems:

Most of the stages in the build.export module are not export stages (e.g., OnnxLoad, OptimizeOnnxModel, Fp16Conversion). Move them, or rename the module?
The Report tool is sitting under the cli directory... when it's a tool
discover is the only stage that has its own directory

Proposed solution:
src/turnkeyml/
    |- tools
        |- tool.py (defines the `Tool`, `BuildTool`, and `ManagementTool` classes
        |- discover/
            |- discover_tool.py (defines `discover` tool)
            |- evaluate_script.py (defines `evaluate_script()`, the primary function of `discover`, currently named `script.py`)
        |- export.py (defines `export-pytorch` and `verify-onnx-exporter` tools)
        |- onnx.py (defines `onnx-load`, `optimize-onnx`, and `fp16-conversion` tools)
        |- report.py (defines `report` tool)
        |- cache.py (defines `cache` tool)
        |- version.py (defines `version` tool)
    |- toolchain
        |- toolchain.py (defines the `ToolChain/Sequence` class)
        |- ignition.py
        |- stage_plugins.py
        |- build_api.py (defines `build_model()`)
        |- state.py (defines `State`, was in common/filesystem.py)
    |- common
        |- status.py (was in analysis/)
        |- everything currently in common
    |- run (unchanged... but will be removed shortly anyways)

@danielholanda @ramkrishna2910 please give any feedback or objections to this change

I would personally merge discover_tool.py and evaluate_script.py into a single script (discover.py) to create a more standardized folder structure. That being said, the proposed option is also good.
All other changes greatly improve clarity.

Great!

I would personally merge discover_tool.py and evaluate_script.py into a single script (discover.py) to create a more standardized folder structure. That being said, the proposed option is also good.

I thought about this, but I was worried about file length. The discover tool is almost 300 lines and evaluate script is almost 500 lines, so the combined file would be almost 800 LoC.


Fixed hang when segfaulting after OS object destroyed (OSX and X11)

The two POSIX style crash handlers (OSX and X11) now remove their signal
handlers when they are destroyed.
Additonally if they are called while no OS singleton is set, they will
simply abort(). This should not happen now that they remove themselves,
but if a future change seperates OS object and crash handler lifetimes,
this may be easier to report/debug than hanging on SIGSEGV.

A step towards fixing #18429

Thanks!

Cherry-picked for 3.0.7.


Merge bitcoin#14060: ZMQ: add options to configure outbound message high water mark, aka SNDHWM

Looks like llmq tests flakiness again bites us here. The same tests pass locally just fine:
...
feature_llmq_chainlocks.py            | ✓ Passed  | 42 s
feature_llmq_connections.py           | ✓ Passed  | 29 s
feature_llmq_data_recovery.py         | ✓ Passed  | 127 s
feature_llmq_dkgerrors.py             | ✓ Passed  | 45 s
feature_llmq_is_cl_conflicts.py       | ✓ Passed  | 22 s
feature_llmq_is_retroactive.py        | ✓ Passed  | 120 s
feature_llmq_signing.py               | ✓ Passed  | 48 s
feature_llmq_signing.py --spork21     | ✓ Passed  | 54 s
feature_llmq_simplepose.py            | ✓ Passed  | 146 s
...
ALL                                   | ✓ Passed  | 1957 s (accumulated)
Runtime: 300 s

re-utACK, as I don't see any changes, but why did you fp?

Another flaky test failed so I pushed the same changes but with a different commit hash to trigger CI to re-run and succeed.

Ping, please resolve comments


Updating shuffle function to ES6 version.

Updating shuffle function to ES6 version, where for shuffling I just used Array.forEach function.

Thanks for PR, but I don’t think it is necessary. Because it is works currently and has good performance


Add a function to the std to handle the CALL opcode

It would be useful to have a function in the std that wraps the low-level CALL opcode specified here
The function would be used to call external contracts not known at compile time.  For example, a proposal in a DAO voting contract.
The signature for such a function might look like make_call(call_data: CallData, amount: u64, asset: ContractId, gas: u64)

Hm, I'm not sure this is necessary. CALL requires a pointer to very specifically laid-out data. This will be difficult to implement in the standard library, but moreover, is already implemented within the compiler via abi casts.
If your objective is to use the CALL opcode on contracts not known at compile time, you can do something like this:
contract;
use std::contract::ContractId;

abi MyContract {
    fn test_function() -> bool;
}

fn caller(address: ContractId) -> ContractCaller<MyContract> {
  abi(MyContract, address.0)
}

fn foo() {
  let x = caller(0x000...);
  x.test_function();
}

Unfortunately, we have had a recent regression: #2341, so this is blocked right now, but this would be the correct way to do this behavior. 2341 is a critical bug so it should get addressed soon.
Would this work for your use case? If so, I think we should close this issue.

Also if abi casts can handle this use case is it still worth it to implement issue #2331 ?

This issue is no longer relevant once #2341 and #1261 and fixed

Reopening this as we have a path forward for low-level calls. The bytes type here  would allow the SDK to encode  the calldata according to the ABI (known to the SDK but unknown to the calling contract). The calling contract would then just point to the function selector and these bytes and everything should justWorkTM.


Fixed suchThat issue

This is basically a rip off of Haskell QuickCheck's suchThat. It makes the test pass and works for my purposes though.
suchThatMaybe's type signature has changed so this is a breaking change re SemVer.

:+1: Thanks! The test was failing before, and succeeds now?

Well it wasn't explicitly failing before as much as it never ended? It is succeeding now though.

Awesome, thanks for the fix! :+1:

:+1:


@azure/identity error output doesn't show you the real error but gives you some nebulous message.

Package Name: @azure/identity
Package Version: 2.0.4
Operating system: Debian
[x] nodejs

version: v17.8.0

[ ] browser

name/version:

[ ] typescript

version:

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
Running credential.getToken("https://database.windows.net/.default"); using the CLI path gets unhelpful error messages while the real error isn't reflected. This is what I get:
/root/app/node_modules/@azure/identity/dist/index.js:1572
            const error = new Error(err.message || "Unknown error while trying to retrieve the access token");
                          ^

Error: Please run 'az login' from a command prompt to authenticate before using this credential.
    at AzureCliCredential.getToken (/root/app/node_modules/@azure/identity/dist/index.js:1572:27)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async DefaultAzureCredential.getToken (/root/app/node_modules/@azure/identity/dist/index.js:1401:25)
    at async /root/app/app.js:18:25

When I went into<EMAIL_ADDRESS>to manually output to console the entire output object from const obj = await cliCredentialInternals.getAzureCliAccessToken(resource, tenantId); (line 1542), I get this:
{
  stdout: '',
  stderr: "ERROR: AADSTS50005: User tried to log in to a device from a platform (Unknown) that's currently not supported through Conditional Access policy. Supported device platforms are: iOS, Android, Mac, and Windows flavors.\r\n" +
    'Trace ID: bb1647d8-1ddc-4f2c-a41b-7c5527f21000\r\n' +
    'Correlation ID: 83b46477-c9bf-4548-aade-309f072fc59f\r\n' +
    'Timestamp: 2022-03-31 11:12:50Z\n' +
    'To re-authenticate, please run:\n' +
    'az login --scope https://database.windows.net//.default\n',
  error: Error: Command failed: az account get-access-token --output json --resource https://database.windows.net/
  ERROR: AADSTS50005: User tried to log in to a device from a platform (Unknown) that's currently not supported through Conditional Access policy. Supported device platforms are: iOS, Android, Mac, and Windows flavors.
  Trace ID: bb1647d8-1ddc-4f2c-a41b-7c5527f21000
  Correlation ID: 83b46477-c9bf-4548-aade-309f072fc59f
  Timestamp: 2022-03-31 11:12:50Z
  To re-authenticate, please run:
  az login --scope https://database.windows.net//.default

      at ChildProcess.exithandler (node:child_process:398:12)
      at ChildProcess.emit (node:events:527:28)
      at maybeClose (node:internal/child_process:1090:16)
      at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) {
    code: 1,
    killed: false,
    signal: null,
    cmd: 'az account get-access-token --output json --resource https://database.windows.net/'
  }
}
/root/app/node_modules/@azure/identity/dist/index.js:1573
            const error = new Error(err.message || "Unknown error while trying to retrieve the access token");
                          ^

Error: Please run 'az login' from a command prompt to authenticate before using this credential.
    at AzureCliCredential.getToken (/root/app/node_modules/@azure/identity/dist/index.js:1573:27)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async DefaultAzureCredential.getToken (/root/app/node_modules/@azure/identity/dist/index.js:1401:25)
    at async /root/app/app.js:18:25

Expected behavior
The actual error should be included in the error output.
Additional context
Add any other context about the problem here.

Hello @cephalin ! I’ll be able to follow up early next week. Thank you for your patience!

@cephalin Hello hello! Beyond improving the error message, let me ask you: How did you resolve the problem? Were you able to authenticate?

@sadasant apart from manually inserting logging code into<EMAIL_ADDRESS>as I mentioned above, all I did was just following the error messages to enroll my device into InTune, etc. Which makes being able to see the error messages all the more important. There were other errors after the AADSTS50005 one, but it was pretty straightforward to fix one after another as long as I could see the error message.

@sadasant And yes I'm able to authenticate now.

@cephalin thank you! We have added changes that improve the error detection in our code. We will monitor the situation before we release this fix. Thanks again for using the Azure SDKs!

We have also made an issue to investigate supporting more error messages in the best way we can: https://github.com/Azure/azure-sdk-for-js/issues/21532


Refactor TalkMapper to introduce TalkModelCollection and TalkModel

Implement TalkModelCollection and TalkModel to separate the output representation from the mapper.
This is a fairly large change-set, so I've tried to explain my thinking in each commit message…
Key things:

I've introduced AbstractModel and AbstractModelCollection to hold methods common to the respective TwitterRequest and Talk classes.
The AbstractModel has the concept of sub-resources in additional to default and verbose fields so that I could handle speakers and tracks.
The TalkMapper still needs to pre-process the results from a database read before passing to the Model. This was done in transformResults() which is inherited from ApiMapper, so I've created a new method called processResults() to do this work.
The TalkMapper's getTalkById() returns a TalkModel rather than a collection containing one item. This makes more more sense as it's used by the TalkCommentEmailService, which now uses the 'internal representation' of the talk rather than the output view one. This change also meant that the TalkModelCollection's constructor can accept data that's already hydrated.

test this please

test this please


Scrollbars and Safearea on iOS

Looking at an iOS native Scrollview (e.g. Safari or Mailbox in Mail) in landscape on an iPhone Xs you will see the following behavior:

When the notch is on the left, the scrollbar is drawn all the way at the right edge of the screen (the content of the scrollview does not go all the way to the right to avoid potential obtrusion by the round corners)
When the notch is on the right, the scrollbar is not drawn all the way to the right and instead slightly indented (just like the content) to avoid the notch

I believe I cannot easily replicate this behavior with the Safearea and Scrollbar widget in Flutter. Either the scrollbar is always (regardless of notch orientation) drawn with a padding from the edge of the screen (and would avoid the notch if the phone is orientated to have the notch on the right) or the scrollbar is always drawn all the way at the screen edge (and thus obstructed by the notch if it happened to be on the right side).

/cc @xster @cbracken

@goderbauer would you mind posting comparable screenshots showing what we do vs what the standard platform behavior looks like?

Here's the standard platform behaviour - will show what Flutter does later :-)
Note that this isn't just a landscape thing.

Note that in the iOS example above, I didn't have to do anything - UIKit provides the behaviour for free by adjusting the scrollIndicatorInsets automatically.
This example wraps the content in a SafeArea:

This one doesn't use a SafeArea, but has padding on the content:

@tomgilder thanks for posting the examples.
CC @xster @LongCatIsLooong

Leaving this bug open but I think it's mostly a dupe of #13253 where accounting for the MediaQueryData.padding in the thumb paint calculation will solve.

I think the issue I had was slightly different. Look at the location of the scrollbar in safari: If there is no notch, the scrollbar is as far to the edge of the screen as possible. If there is a notch, the scrollbar is placed with a padding to avoid the notch:

As far as I can tell, there is no way to get that behavior easily in flutter. You either have a padding wether or not there is a notch, or there is never padding and the scrollbar goes through the notch. Example from Flutter gallery:

You're right, I think there is an additional problem indeed. Looking at iOS, it seems like on opposite side of the notch in landscape mode actually has 2 paddings. The nav bar menus, list cell items, tab bar etc all have one padding and the scrollbar has another.

This could be tricky to handle since we already defined the padding and viewInset metrics and the framework doesn't have any additional information from the engine to split 2 different types of padding by reading https://developer.apple.com/documentation/uikit/uiview/2891103-safeareainsets.

Hi @goderbauer
Is this issue still valid?
Thank you

@TahaTesser Yes. There are definitely still issues on iPhones with notches on landscape mode, including Flutter drawing the safe area for the notch on the wrong side.
I think the issues with portrait are all fixed.

Hi, @goderbauer
This problem is also applied to horizontal scroll in portrait mode. You can see more detail in my closed PR #79314. The Scrollbar always calculates the indicator position with the value from all sides in MediaQueryData.padding. Correct me if I'm wrong because the PR was a long time ago.
If your scroll area in portrait mode is not full (set the height to 300 and centralize it), the scroll indicator position will also be wrong. The area of the scroll indicator is smaller since flutter adds screen padding.
I think we should know when we apply the padding. Is it possible in flutter to apply padding in depends on the position of the widget?
Otherwise, I set padding in MediaQuery to zero to avoid extra padding for scrollbars, which are inside of other widgets

This issue still happens in 2022. In a horizontal iPhone 13, the SafeArea thinks the notch is on the right side when it is on the left side and vice-versa.

any progress ?


Add a heading "Download the app from Appstore(s)" before the store links on homepage - For OSDW 2017

From @kashifzaidi1 on January 28, 2017 5:46
Add a heading "Download the app from Appstore(s)" before the store links on homepage
Copied from original issue: codeforpakistan/Messiah-Web#67

From @Atif8181 on January 28, 2017 6:23
Kindly unsubscribe me
Thanks
Sent from my iPhone
On 28 Jan 2017, at 10:46 am, Kashif Zaidi <notifications<EMAIL_ADDRESS>wrote:
Add a heading "Download the app from Appstore(s) before the store links on homepage"

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/codeforpakistan/Messiah-Web/issues/67, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGPC2sQU0bDvGV-_eh731CUZ5VRI9pj0ks5rWtY2gaJpZM4LwbZN.

❤ 💚 💙 💛 💜


Incorrect URL generated in codechanges.

Asciidoc file has:
http://nationalparks-live-{{EXPLORE_PROJECT_NAME}}{{USER_SUFFIX}}.{{ROUTER_ADDRESS}}/ws/info/

in one place, when perhaps should be:
http://nationalparks{% if modules.pipelines %}-live{% endif %}-{{EXPLORE_PROJECT_NAME}}{{USER_SUFFIX}}.{{ROUTER_ADDRESS}}/ws/info/

This in section of rendered documentation where shows:
Once the build and deploy has finished, verify your new Docker image was automatically deployed by viewing the application in your browser:

http://nationalparks-live-project-userXY.apps.graham.pixy.io/ws/info/

You should now see the new name you have set in the JSON string returned.

Fixed by #39


LSP / When Hover.Contents.Kind is set to plain text the string, unexpected escape behavior

Issue Type: Bug
When sending back the following response (see the trace below) to a Hover LSP request, what may appear as an HTML tag gets truncated (or hidden?).
[Trace - 4:27:21 PM] Received response 'textDocument/hover - (31)' in 1ms.
Result: {
    "contents": {
        "kind": "plaintext",
        "value": "U+0008, <control>"
    },
    "range": {
        "start": {
            "line": 153,
            "character": 9
        },
        "end": {
            "line": 153,
            "character": 13
        }
    }
}

What I expected to see:
A hover tooltip with the following content U+0008, <control>.
What I saw instead:

VS Code version: Code 1.56.2 (054a9295330880ed74ceaedda236253b4f39a335, 2021-05-12T17:44:30.902Z)
OS version: Darwin x64 20.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
5, 6, 6

Memory (System)
16.00GB (0.10GB free)

Process Argv
--crash-reporter-id 06fd1910-60d0-4bee-99c6-1013780bf477

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

vscode-eslint
dba
2.1.20

vscode-npm-script
eg2
0.3.21

go
gol
0.25.0

vim
vsc
1.20.2

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt943cf:30300583
vspre833cf:30267465
pythonptprofiler:30281270
vshan820:30294714
vscoreces:30290705
pythondataviewer:30285071
vscus158:30286553
vscgsv2ct:30301613
vscorehov:30301222
bridgeflightcf:30302070
vscod805cf:30301675

Just to be clear. The content sent back is literally U+0008, <control>

@dbaeumer I see that you've flagged this as needs more info; although I am not a regular VSCode user though (I am using it as a reference point for the implementation of a small feature I am adding on gopls), still is there anything else I can provide that could be useful?

The content is show as this
"contents": {
        "kind": "plaintext",
        "value": "U+0008, <control>"
    }

and I was wondering if <control> is really the actual text or whether this is a placeholder for a special control character.

Ah, right, that could be confusing, but no <control> is the the actual text.
(snippet of where it comes from: https://play.golang.org/p/yxhLoEk2WEZ)

Thanks

@dbaeumer I did some digging and I think this may be a bug with VS Code itself...? See https://github.com/microsoft/vscode/issues/124874.

Note that emacs-lsp doesn't have this unexpected behavior, so it's not straightforward to work around this by escaping text in the server.

@rcjsuen thanks so much for investigating. Lets see what Matt has to say. Really looks like a bug in VS Code.

I have a quick look, it seems that plain is converted to markdown quite early here
https://github.com/microsoft/vscode-languageserver-node/blob/d58c00bbf8837b9fd0144924db5e7b1c543d839e/client/src/common/protocolConverter.ts#L384-L387
and MarkdownString.appendText doesn't do anything special about > and <
https://github.com/microsoft/vscode/blob/94c9ea46838a9a619aeafb7e8afd1170c967bb55/src/vs/base/common/htmlContent.ts#L48-L55
so they pass through as markdown, and are sanitised as the spec says they might be.

MarkdownString.appendText doesn't do anything special about > and <

That is what I noticed also and is why I opened https://github.com/microsoft/vscode/issues/124874.

@jhchabran @pedro-w @dbaeumer FYI https://github.com/microsoft/vscode/issues/124874 seems fixed in the latest Insiders build of VS Code.


Clarify documentation around what "hint" means in the context of Deserializer methods

In particular, "hint" was intended to indicate something that is allowed to be ignored, but is not allowed to be wrong. This is the same meaning of "hint" as in "What is the capital city of France? Hint: the name begins with Z." For example a Visitor that wants a string should not hint that it wants an integer -- data formats are not required to deserialize that correctly even when the input happens to contain a string.

I think that it might be worth adding an example that shows how you can accept multiple types from certain formats (e.g. JSON) while requiring only one format for others (e.g. bincode). Something like allowing a string or integer for an IP in human-readable formats while requiring that an integer be used for formats like bincode.


Remove 08-wasm globals

Summary
Following merge of #5806 the globals within 08-wasm can be moved to the LightClientModule type. It should be all the types within here

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Closed by https://github.com/cosmos/ibc-go/pull/6103


File server

Added options to specify a static file server, I found it useful when I didn't want to set up a separate container for a static file server on the same host I was using caddy-gen. So I added some options to take advantage of Caddy's existing static file_server capabilities. Let me know if you find this useful, I realize it's not super configurable because you can't add cache control headers and other things.
For explanation of options, see edits to README, and for example usage, see edits to docker-compose.yml

Closing in favor of https://github.com/wemake-services/caddy-gen/pull/52


Type alias for Record does not allow recursion

Bug Report

🔎 Search Terms

record recursion TS2456 ts(2456) 2456 circularily references type alias
🕗 Version & Regression Information
Reproducible on:

4.2.0-dev.20210204
4.2.0-beta
4.1.3

⏯ Playground Link

Playground link with relevant code
💻 Code

// Error: Type alias 'RecursiveRecord' circularly references itself. (2456)
type RecursiveRecord = Record<string, RecursiveRecord | null>;

// Fine
type RecursiveMap = Map<string, RecursiveMap | null>;

// Also Fine
type RecursiveIFace = { [key: string]: RecursiveIFace | null };

🙁 Actual behavior
TS2456 error for RecursiveRecord.
🙂 Expected behavior
No error for RecursiveRecord.

Duplicate #41164


RPC dies after catching up with --no-incremental-snapshots with 7/BUS

Problem
Two Jito-Solana validators running v1.17.26-jito crashed after running with --no-incremental-snapshots with error SIGBUS.

Mar 18 03:37:48 amsterdam-mainnet-rpc-1 systemd[1]: solana-validator.service: Main process exited, code=killed, status=7/BUS

OOMd


Adding a Singapore Calendar

Similarly to what has been requested for Israel, Singapore public holidays are made of fixed dates (New Year, Labour day, National Day and Christmas). Other public holidays are "religious" celebrations taken from muslim, Hinddu and Buddhist calendars). These "religious" celebrations vary every year but the Ministry of Manpower in Singapore publishes the official public holidays with 1 year in advance (currently published are 2018 and 2019).
There is no accurate way to calculate (or I do not know it) what will be the dates for these religious holidays for 2020 and beyond. Which means that this library, if it is created will have to be updated at the beginning or every year.
I have prepared a SG class covering 2018 and 2019. I could submit it but I will need some guidance as I am a newbie to all this (Github, python,...)
Here is the code:
`# -- coding: utf-8 --
class Singapore(HolidayBase):
PROVINCES = []
def __init__(self, **kwargs):
    self.country = 'SG'
    HolidayBase.__init__(self, **kwargs)

def _populate(self, year):
# Singapore became independent on 9th August 1965
    if year < 1965:
        return

    # New Year's Day
    name = "New Year's Day"
    jan1 = date(year, 1, 1)
    self[jan1] = name
    # If New year falls on Sunday, Monday becomes public Holiday
    if self.observed and jan1.weekday() == 6:
        self[date(year, 1, 2)] = name + " (Observed)"

    # Chinese New Year
    name = "Chinese New Year (1)"
    if year == 2018:
        self[date(year, 2, 16) = name
    if year == 2019:
        self[date(year, 2, 5) = name

    # Chinese New Year
    name = "Chinese New Year (2)"
    if year == 2018:
        self[date(year, 2, 17) = name
    if year == 2019:
        self[date(year, 2, 6) = name

    # Good Friday
    self[easter(year) + rd(weekday=FR(-1))] = "Good Friday"

    # Labour Day
    name = "Labour Day"
    # Started being celebrated in 1960 after People Action Party went into power
    # Reference Wikipedia (Labour Day Singapore)
    if year >= 1960:
        self[date(year, 5, 1) = name
    # if Labour day falls on a Sunday, Monday is observed
    if self.observed and may1.weekday() == 6:
        self[date(year, 5, 2)] = name + " (Observed)"

    # Vesak Day
    name = "Vesak day"
    if year == 2018:
        self[date(year, 5, 29) = name
    if year == 2019:
        self[date(year, 5, 19) = name

    # Hari Raya Puasa
    # End of Ramadan
    name = "Hari Raya Puasa"
    if year == 2018:
        self[date(year, 6, 15) = name
    if year == 2019:
        self[date(year, 6, 5) = name

    # National Day
    if year > 1965:
        name = "National Day"
        aug9 = date(year, 8, 9)
        self[feb6] = name
    # if National day falls on a Sunday, Monday is observed
        if self.observed and year >= 1965 and aug9.weekday() == 6:
            self[date(year, 8, 10)] = name + " (Observed)"

    # Hari Raya Hadji
    # First day of muslim pilgrimage to Mecca
      name = "Hari Raya Hadji"
      if year == 2018:
          self[date(year, 8, 22) = name
      if year == 2019:
          self[date(year, 8, 11) = name

    # Deepavali
      name = "Deepavali"
      if year == 2018:
          self[date(year, 11, 6) = name
      if year == 2019:
          self[date(year, 10, 27) = name

    # Christmas Day
    name = "Christmas Day"
    dec25 = date(year, 12, 25)
    self[dec25] = name
    # if Christms day falls on a Sunday, Monday is observed
    if self.observed and dec25.weekday() == 6 :
        self[date(year, 12, 26)] = name + " (Observed)"

class SG(Singapore):
pass
`

Hi,
thank you for your work.
Unfortunately, IMHO, a good library (or sw in general) is supposed to work as-is for a reasonable time (say: 10 years at least?) with no need for mandatory upgrades (which could instead be applied in case of bug fixing or more functionalities added / needed).
Moreover, a future release could, for other reasons, break compatibility with previous versions: this would impose code refactoring to anyone using it, only to keep it working from a year to the next.
For these reasons, I have to say that this approach (ie: impose a new release every year to include new year's data) is not acceptable in the official version.
But, of course, we still can receive logic for all the fixed and known holidays.
Then, I would suggest you to:

create your own fork of the library
add and commit your code there
so you can play around and test everything with no harm and, when you're done, we will be able to separate and include the compliant part of the code in the mainstream.

This way (which, btw, is the "standard" :) ) you still can stick to your custom version if the official library doesn't cover all your needs.
Thank you very much, best regards

Hi
Thank you for your quick answer. I understand your point (work as-is for a reasonable time).
If I create my own fork, will I be able to use it for the works I do in my home automation (Home Assistant binary_sensor.workday_sensor)? (This is my main objective in trying to build this "Singapore" Class).
I will follow your recommendation anyway and try my best to come out with something viable.
Best regards

The 10+ years stability will not work with other holidays as well (e.g., the newly introduced "Reformationstag" holiday in Germany (single occurence holiday for entire Germany with one year lead time, newly set up holiday in parts later on).
Given that, definition of holidays two years in advance does not sound so bad...
I think it's important to be clear with what users can expect from the library and that holidays are a moving (sometimes even fast moving) target.

I see the point, but - still - an exception can't become rule.
As a standard library, python-holidays - of course - will always try to reflect any change that will occur in the future.
On the other hand, it must be up to users whether to update or not, which means, as a rule of thumb, it will never impose cadenced updating to remain operational.
As I already explained in a direct email to popsyann, a good approach to these use cases would be to integrate external services providing the requested data as soon as they become available (ie: consume some holiday web service) but, being an impacting and disruptive modification, at least for now, we must consider it out of scope.

PS @popsyann : of course, you will be able to use your library fork if needed, either installing it manually with a "git clone .." or, if using virtualenv or similar, also adding your repo to project through requirement files.
Some info here:
https://stackoverflow.com/questions/16584552/how-to-state-in-requirements-txt-a-direct-github-source
Please keep me updated, thx!


Update to nunit3 as appveyor is upgraded

Update unit test to use NUnit3, as AppVeyor is upgraded to use NUnit3.
Explicitly set assemblies to test, as AppVeyor test auto-detection will detect SparkCLRSamples.exe but fail to find any testfixtures in it.

Hi @kai-zeng, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Kai Zeng). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

LGTM

LGTM


[Permission Request] Codeunit 1013 Job Jnl.-Post Batch

Hello,
We request that you add the following permission to codeunit 1013 Job Jnl.-Post Batch.
codeunit 1013 "Job Jnl.-Post Batch"
{
    Permissions = TableData "Job Journal Batch" = imd,
               ++ TableData "Job Journal Line" = rimd;
    TableNo = "Job Journal Line";

A user may not have the permission to manually add/modify/delete records in Job Journal Line, but they can (indirectly) trigger this codeunit. And in this codeunit Job Journal Lines may be inserted/modified and deleted through the execution of the (standard) code.
Thank you in advance.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47752.


Unable to compile IAccount.cairo due to re-definition of __validate_declare__

Compile the IAccount.cairo contract.

📝 Details
It would fail to compile the IAccount.cairo contract and give this error:
openzeppelin/account/IAccount.cairo:22:31: Redefinition of '__main__.IAccount.library_call___validate_declare__.Args.class_hash'.
    func __validate_declare__(class_hash: felt) {

🔢 Code to reproduce bug
from the src directory:
starknet-compile openzeppelin/account/IAccount.cairo

Also tried
starknet-compile openzeppelin/account/IAccount.cairo --account

Further digging: realized that the problem is with the argument name class_hash

The part I do not understand is why it does not fail in Account.cairo or EthAccount.cairo. Is this because they require --account flag when compiling and thus can break this rule?

Thanks for bringing this up @unparalleled-js!

Is this because they require --account flag when compiling and thus can break this rule?

From what I can gather, account contracts must have __validate_declare__ with the class_hash exactly. If you change class_hash in the actual contract, you get this error:
'__validate_declare__' function must have one argument `class_hash: felt`.

I suppose your solution of changing class_hash to cls_hash in the interface could work for now, but it might be worth bringing up to SW. @martriay @ericnordelo thoughts?

I created the issue in Cairo-lang here: https://github.com/starkware-libs/cairo-lang/issues/100

Just for awareness, this is blocking us at Immutable currently. Would recommend the temp solution of cls_hash as Starkware may be slow to adjust


HUD Iconbar: X/Y Position is incorrect

The ICON's in the HUD icon bar are incorrectly positioned on the x or y axis (depending on axis the bar is repeating across). They are actually position at double what the bar is set to.

Fixed issue!


Added Mahmud's Awesome MAUI Repository

We recommend adding links/samples to:

.NET MAUI Showcase
Awesome .NET MAUI


[FEATURE] Create Navbar and Hero section

Detailed description

Hacktoberfest Task 1:

Create navigation bar and hero section like this

Context
It is important for us to rebrand xD
Possible implementation
Check the design in Figma: https://www.figma.com/file/svMDNK4ZuKMfg3ItEyQmQU/Surpathhub-Rebranding[REFERENCE]
Additional information
Please use these tech stacks:
TailwindCSS and ReactJS
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi, the figma file is not opening.

Wait. Can you send view link @Tiansing

Hey can i work on this? 😄

Hey @vinzvinci and @mkubdev, I just updated the figma file, you all can now access the rebranding design through this link :
https://www.figma.com/file/svMDNK4ZuKMfg3ItEyQmQU/Surpathhub-Rebranding[REFERENCE]

I would love to work on this, can you assign it to me?

Thanks @Tiansing. Assigned @sutirthverma :heavy_check_mark:

I think you can create by using the current languages we used here, let us handle transferring the code to tailwind and react. Feel free to create PR

ok, thanks

Hey, do I have to keep the navbar fixed at top?

Hey, do I have to keep the navbar fixed at top?

Hey @sutirthverma, yes that would be fine if you keep the navbar fixed at the top.

@sutirthverma any update on this?

@sutirthverma any update on this?

Almost finished, just working on some bugs.

@sutirthverma any update on this?

Almost finished, just working on some bugs.

That's great, keep going buddy!

You can keep the old one.
#125 coming up soon

ok

Sure! We are also in a hurry, kubdev migrating to nextjs #127


[Request] Provide class names for imagenet models

I want to send a PR, with class labels for ImageNet models.
Why
Currently we get the class index output as the prediction, but a human readable string would be nice. Keras provides a method called decode_predictions which provides the string value. Internally this method uses this file, which has human readable string, along with imagenet identifier. If the torchvision models also come with such mapping, we can avoid the downloading such mapping file from external sources.
Where
I am not sure where to add this mapping file. There is a file called utils and we can place the mapping there. At the end, it will be like:
from torchvision.utils import imagenet_classes

where imagenet_classes will be a dictionary object.
Let me know what do you think. Thank you!

Python enums is a good idea, but we need a separate package to support python2 I believe, so I'd rather not use it for now

I just wanted to post an update that I am still on this issue and I will do this over the weekend. Had really crazy work days 😰

@avinassh Do you have a new update on this? I need to work on the ImageNet dataset as well. Maybe we can share some work.

@pmeier sure, how do we do it?
I haven't made much progress on this one :(

@avinassh I'm not sure. I think for example I fork from this repository and give you permission to push to it. Afterwards I can open a PR based on my fork and we both can add our changes. Mind, I never done this before. Can someone with more experience weigh in to confirm this or show us better way?

@pmeier you should go ahead with your changes and @avinassh should rebase off your branch.
At this point, @pmeier's PR seems to fix this issue so that's good.

My PR #764 was merged so this can probably be closed.

in 2023, a list like this would be very handy.


Initial RPython codegen

Hi! This codegen backend generates Python 2.7 syntax which is compatible with the RPython toolchain, as used in projects like PyPy and Typhon.
I'm still refining the output. In particular, I haven't gotten anything to translate with RPython properly. So this isn't quite ready to merge. On the other hand, there is at least one bugfix in the synthesis package here.

Hi Calvin! I'm gonna reply inline, but the basic outline:

This PR as-is is the wrong approach. The biggest problem (besides what you've pointed out) is that, as usual, RPython's type system isn't amenable to quite the shallow encoding that I had imagined. Map<Bag<Int>> is a legal Cozy type, but in RPython, that would require using a dict as a dict key, which isn't legal. I need to probably write an RPython module to give an intermediate Bag wrapper class, at least.
I think that at least some of the bugfixes are useful, and maybe we can bludgeon this into some more useful shared optimizations in the common IR. I was thinking in particular about smart constructors for statements and some expressions, so that _var1 + [] or for _var1 in [e]; ... aren't even constructed, but I'm not sure whether that interferes with the synthesis/search.
For the future, I'm still trying to understand handle types and how that works with RPython's reference semantics. RPython, like Java, has a sharp edge between primitive values like 42 and reference values like {}.
I'm also not sure how mutability works in Cozy. RPython is a warmup (and a gift to my PyPy friends), but I really want to emit Monte code, and Monte's core datastructures (List, Map, Set, the classics) are immutable by default, with opt-in mutability. At least there, I can use any data as map/set keys!

So yeah, let's not merge this, but let's also figure out how to do better next time.

Sounds good! I've cherry-picked your synthesis fix into master.

smart constructors for statements and some expressions

This is already sort-of done in the Java and C++ codegen, where all iterative operations distribute over singletons, appends, etc. It would probably be better to handle those in a separate simplification pass.

I'm also not sure how mutability works in Cozy

Most values are mutable, but there is no aliasing. Two different bag variables are always different bags; changes to one do not affect the other. Pointers (aka handles) are the only exception.

@MostAwesomeDude I closed this PR since you didn't feel confident in it, but I want to reemphasize that I think adding additional backends is a great project.
Are you still planning to continue working on this? Infrastructure to make writing new backends easier would be extremely helpful as well. Your "smart constructors" idea is neat, but I think a lot of those transformations could be done in a pre-codegen simplification pass (#49). It would also help simplify the Java and C++ backends a lot.


Icon Tap Action not working with Media Card and Select Sub Button

For any feature request you can open a new discussion here:
https://github.com/Clooos/Bubble-Card/discussions/categories/feature-requests
For any question you can open a new discussion here:
https://github.com/Clooos/Bubble-Card/discussions/categories/q-a
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
When you have a select button in a media bubble card the tap action on icon is not working anymore
Expected behavior
Popup should work
Screenshots
If applicable, add screenshots to help explain your problem.
I‘m on phone. Can provide code later if needed
YAML
If applicable, add any relevant YAML code.
Your code here

Informations (please complete the following information):

OS: iOS, Browser
Browser/App: Chrome
Bubble Card version: latest beta
Home Assistant version: Latest

Additional context
Add any other context about the problem here.
Thank you! 🍻

Hi and thank you for the feedback! I've just fixed this issue, this fix will be available in the next release.

This is now fixed in the latest release!
https://github.com/Clooos/Bubble-Card/releases/tag/v2.1.0

can confirm that is working now. Thx amazing custom-card


[FA] Test user and group when needed

What does this PR do?

Test file user and group only when it's needed
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


[FLINK-7220] [checkpoints] Update RocksDB dependency to 5.5.1

This PR updates the RocksDB dependency to 5.5.1. Further changes:

the more performant merge operator is used via setMergeOperatorName("stringappendtest").
the option .setDisableDataSync(...) was removed from RocksDB. Usage is also removed from Flink.

CC @aljoscha - suggesting to add this change also to the 1.3.2 release.

Just noticed that the license is not updated in the 5.5.1 branch, but only in master. So I guess this means we have to wait for a release that has the updated Apache compatible license?

We should still be able to switch back to the original RocksDB dependency. The licensing issue should also apply to frocksdb.

RocksDB 5.5.5 looks to include the desired licensing.

Yes, that is correct, I kindly asked them to also update their license in the releases on their issue tracker https://github.com/facebook/rocksdb/issues/2605.
I will update the PR as soon as this version is available from Maven Central.

Very good news, thanks for taking care of that!

Version 5.5.5 is already published, so from my side this is now good to merge. Can somebody give me another +1?

Looks good, +1 with request for minor change:
I would pull out the setting of the merge operator from the option factories. We should not allow users to override (or forget to set it), because we make a hard assumption on the fact that exactly that merge operator is configured.

Thanks for the review @StephanEwen . I changed my PR according to your comments. Will merge now.

Merged in 219ae33d36

The merge looks to have not been squashed.

@StefanRRichter As mentioned by Greg, we should either squash follow up commits like Stephan's comments into their parent or tag them similar to the main commit with a more descriptive message.

Agree. There are two very non-descriptive commits in the master now.
Let's try to avoid that in the future...

@uce I know, but this was not intentional. I squashed them but pushed the wrong (unsquashed) branch because of my shell history.

@uce @StephanEwen we had a bit of continued discussion in the JIRA. Can we add a pre-commit hook to the Apache repo to validate the format of the summary line?

Thanks for the pointer Greg. I didn't look at the JIRA issue. I like the idea of automating this but I would go with a pre-push hook instead of a pre-commit hook. It could be annoying during local dev if we force every commit to have the format already. I'm not sure whether INFRA allows this or not though.
@StefanRRichter Sure, can happen. 😊


[tool_crash] FileSystemException: Failed to set file modification time, path = '/var/www/html/flutter/first_app/.packages' (OS Error: Operation not permitted, errno = 1)

Command
flutter run --machine --target lib/main.dart -d emulator-5554 --track-widget-creation --dart-define=flutter.inspector.structuredErrors=true --start-paused

Steps to Reproduce

...
...
...

Logs
FileSystemException: FileSystemException: Failed to set file modification time, path = '/var/www/html/flutter/first_app/.packages' (OS Error: Operation not permitted, errno = 1)
#0      _File.setLastModifiedSync (dart:io/file_impl.dart:473:7)
#1      ForwardingFile.setLastModifiedSync (package:file/src/forwarding/forwarding_file.dart:62:55)
#2      ForwardingFile.setLastModifiedSync (package:file/src/forwarding/forwarding_file.dart:62:55)
#3      _DefaultPub.get (package:flutter_tools/src/dart/pub.dart:213:19)
#4      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:706:17)
<asynchronous suspension>
#5      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:620:33)
<asynchronous suspension>
#6      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart)
#7      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#8      _rootRun (dart:async/zone.dart:1184:13)
#9      _CustomZone.run (dart:async/zone.dart:1077:19)
#10     _runZoned (dart:async/zone.dart:1619:10)
#11     runZoned (dart:async/zone.dart:1539:10)
#12     AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#13     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:610:20)
#14     CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#15     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:339:21)
<asynchronous suspension>
#16     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart)

[✓] Flutter (Channel stable, v1.17.5, on Linux, locale en_US.UTF-8)
    • Flutter version 1.17.5 at /home/ranasl62/development/flutter
    • Framework revision 8af6b2f038 (6 days ago), 2020-06-30 12:53:55 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /home/ranasl62/Android/Sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /home/ranasl62/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions.

[!] Android Studio (version 4.0)
    • Android Studio at /home/ranasl62/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.12.1

[✓] Connected device (1 available)
    • AOSP on IA Emulator • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

! Doctor found issues in 2 categories.

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: f139b11009aeb8ed2a3a3aa8b0066e482709dde3

Fixed by https://github.com/flutter/flutter/pull/57077, not yet in stable


GUACAMOLE-457: include CAS login URI when requesting auth ticket

When attempting to use the CAS extension with a protocol-compliant CAS server, I discovered that when requesting an authentication ticket the URL used by the extension is missing the /login URI path defined in the spec.
This PR adds the necessary additional path segment before appending the service name parameter.

So, a couple of things about this:

In my experience, this isn't required - I use Guacamole against CAS 4.2.x and 5.0.x, and sending it the location without the /login results in it automatically forwarding over to the /login location.  I believe someone else posted to the list with the issue that they were using a "CAS-compatible" server that did not behave this way, but the official Apereo one seems to work without having to put /login on the URL.
In at least some versions of the CAS server, the login endpoint can be configured with the following property:
cas.securityContext.casProcessingFilterEntryPoint.loginUrl

Hard-coding /login in the code will break Guacamole's ability to log in for anyone who customizes their URLs.  I think the number of people who customize their CAS server to a different login endpoint is probably pretty low, but it's probably equally likely that the number of people running a CAS server that does not redirect login requests transparently is probably equally low.  The CAS protocol may actually define /login as the endpoint for the login, so maybe it's worth going with the protocol, but, then, if the Apereo server lets you customize it, that seems a little strange.
I'm not dead set against making this change, but I think it's worth at least noting those issues and having at least a small discussion on the issue.

The Shib server, which is at least as broadly used as Apereo does not work with the extension as shipped. On the other hand, the Guacamole extension will successfully interoperate with an Apereo server with this change.
Protocols exist for a reason -- to ensure interoperable communications. The Postel principle suggests be conservative in what you do, be liberal in what you accept from others. That the Apereo implementation of the server protocol allows authentication to work despite the absence of the /login URI is an example of the latter. But for the Guacamole extension to depend on that behavior is the antithesis of the former.
I've written several CAS client implementations over the last ten years or so. I contributed to the original Yale CAS client implementation, wrote two alternatives, and I still support a CAS extension for Wildfly. In every case we ran across users who insisted that they needed to modify aspects of the protocol (particularly the URIs, but also XML element names, namespaces, etc) to suit local circumstances. It invariably ended badly.
It's fine to try to support those who choose to run non-standard CAS, but to do so at the expense of supporting a server that correctly implements the documented protocol is indefensible.

It's fine to try to support those who choose to run non-standard CAS, but to do so at the expense of supporting a server that correctly implements the documented protocol is indefensible.

Whoa, okay :-).  You've got me on board with the change.  Most of the other people I've encountered have been of the ilk of "Well, I tried xyz once and could not get it working."  Clearly you've got substantial experience with this, and I will gladly defer to your expertise and experience.
I'll review the PR more thoroughly as soon as I get a chance.


[BUG] Cannot install wash on Ubuntu 22.04 LTS

Describe the bug
Cannot install wash on Ubuntu 22.04 LTS
To Reproduce
Steps to reproduce the behavior:
Run the scripts provided from the installation page for Ubuntu/Debian
curl -s https://packagecloud.io/install/repositories/wasmcloud/core/script.deb.sh | sudo bash
sudo apt install wash
Expected behavior
wash will be installed successfully
Screenshots
curl -s https://packagecloud.io/install/repositories/wasmcloud/core/script.deb.sh | sudo bash
sudo apt install wash
Detected operating system as Ubuntu/jammy.
Checking for curl...
Detected curl...
Checking for gpg...
Detected gpg...
Detected apt version as 2.4.5
Running apt-get update... done.
Installing apt-transport-https... done.
Installing /etc/apt/sources.list.d/wasmCloud_core.list...done.
Importing packagecloud gpg key... Packagecloud gpg key imported to /etc/apt/keyrings/wasmCloud_core-archive-keyring.gpg
done.
Running apt-get update... done.
The repository is setup! You can now install packages.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package wash
**Environment (please complete the following information) **
lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04 LTS
Release:        22.04
Codename:       jammy
Additional context
Add any other context about the problem here.

Hey @clin4 , you might find some additional help in #335, specifically around the recommendation to use cargo to cargo install wash-cli. This specific issue requires us adding jammy to our apt release list


MODRS-2 - Work with remote storage locations

MODRS-2 - Work with remote storage locations
Purpose
If the location attribute on UI is changed to link the location to the remote one (mark as remote) https://issues.folio.org/browse/UITEN-119, then this information should be stored in database in remote-storage module.
Approach

created mappings endpoint
updated unit tests

Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added, or removed?
[ ] Are there new interface dependencies?
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

INFO: api-lint: Using api-lint version: 1.0.1
INFO: api-lint: Assessing API description files: OAS
INFO: api-lint: Processing OAS 3.0 file: src/main/resources/swagger.api/remote-storage.yaml
ERROR: api-lint:
Violation - Duplicated resource path /mappings/{folioLocationId}
Violation - Duplicate key : '/mappings/{folioLocationId}'
Model: file://src/main/resources/swagger.api/remote-storage.yaml
Profile: OAS 3.0
Conforms? false
Number of results: 2
Level: Violation

Source: http://a.ml/vocabularies/amf/core#syaml-error
Message: Duplicate key : '/mappings/{folioLocationId}'
Level: Violation
Target:
Property:
Position: Some(LexicalInformation([(231,2)-(231,29)]))
Location: file://src/main/resources/swagger.api/remote-storage.yaml

Source: http://a.ml/vocabularies/amf/parser#duplicated-endpoint-path
Message: Duplicated resource path /mappings/{folioLocationId}
Level: Violation
Target: file://src/main/resources/swagger.api/remote-storage.yaml#/web-api/end-points/%2Fmappings%2F%7BfolioLocationId%7D
Property:
Position: Some(LexicalInformation([(231,2)-(262,0)]))
Location: file://src/main/resources/swagger.api/remote-storage.yaml

ERROR: api-lint: There were processing errors. See list above.

Note: When those errors are fixed, then the INFO messages will be gone too. See Jenkins "Artifacts" tab.


SDK shall use older (yet still safer) GoLang version for the widest compatibility.

To decide the baseline of go version needed, we'd need to run static vuln analysis too.

This is done.


Hosted documentation needs to be updated

I've noticed that there are features available in the crates.io published version that are not shown in the online documentation, such as LdlNumeric and LdlSymbolic, so really a cargo doc should be redone.

I've just updated the docs, should be ok now.

There seems to be some files missing. For example try clicking on LdlNumeric in https://vbarrielle.github.io/sprs/doc/sprs/sparse/linalg/cholesky/

Should be fixed now. I'll leave this issue open for a while, feel free to report any other issue.
Thanks for the coverage, it's really nice 'cause I don't spend enough time checking the state of my docs...

Closing as the doc is now up-to-date with latest changes.

You might want to consider getting Travis to automatically update the docs on every update to master. There's a tutorial at http://hoverbear.org/2015/03/07/rust-travis-github-pages/

Thanks for the tip, I'l look into that.


Temporal Accumulation Errors from Temporal Autoregressive Model

The temporal autoregressive approach introduces temporal accumulation errors, leading to issues such as blurriness and darker tones in videos, especially for longer sequences. Additional artifacts may also appear over time. Below are two examples of 16-frame video generation at 384p resolution: the first video shows results from MMDIT, while the second video shows results from MiniFlux.
https://github.com/user-attachments/assets/6335994e-d5e3-4dda-84d4-4e35a74008e2
https://github.com/user-attachments/assets/660b1861-643b-4600-bdcb-cf8fb5d57768
A possible solution to address this issue is to truncate the historical frame information, such as using only the previous 8 frames for autoregression. Have there been any plans or considerations for implementing this solution in future work?

Yes, temporal accumulation error is an important problem we will look into in the future work. We recommend reading CausVid as a highly relevant work.

Yes, temporal error accumulation is an important problem we will look into in the future work. We recommend reading CausVid as a highly relevant work.


Compile error: class "RE::ControlMap" has no member "GetRuntimeData"

Error (active)	E0135	class "RE::ControlMap" has no member "GetRuntimeData"	TrueHUD.dll (src\Debug\TrueHUD.dll) - vs2022-windows	TrueHUD\src\HUDHandler.cpp	line: 240
clib from: https://github.com/CharmedBaryon/CommonLibSSE-NG
I already fixed the error from this issue: https://github.com/ersh1/TrueHUD/issues/2
but there is another one

I'm not sure but maybe we need to use this param right now:
https://github.com/CharmedBaryon/CommonLibSSE-NG/blob/9b7c386d0355e756b4153416a76b0532f755f8de/include/RE/C/ControlMap.h#L107
HUDHandler.cpp line: 240: const auto& priorityStack = controlMap->GetRuntimeData().contextPriorityStack;
to
HUDHandler.cpp line: 240: const auto& priorityStack = controlMap->contextPriorityStack;
I tested this change in the game and everything was fine I guess (I'm not fully sure)
need your confirmation

I noticed now that you use another clib version - https://github.com/alandtse/CommonLibVR/tree/ng
Yeah there is GetRuntimeData method in ControlMap.
Maybe someone will find it useful


add normalized .path() to FileHandle

It's a feature present both in core Java 7 lib (which is currently unsupported neither in libGDX nor on Android) [https://docs.oracle.com/javase/7/docs/api/java/nio/file/Path.html#normalize()] and in Apache Commons IO [http://commons.apache.org/proper/commons-io/apidocs/org/apache/commons/io/FilenameUtils.html#normalize(java.lang.String)], and is a quite nice & simple feature. It makes the path more "canonical" by getting rid of e.g. . & .. and it's required in some cases, e.g. if the dotted paths point to internal JAR content (happened to me with relative texture paths provided from .MTL file); using an non-normalized path results in "file not found", using a normalized one works as expected.
Currently we have to either convert the FileHandle.path() by means of URI or include an additional library just for the sake of it, both being ugly & kludgy. Porting either Java 7's or Apache IO's normalizer (both are Open Source AFAIK) and exporting it as .pathNormalized() would be IMO the best solution here.

I welcome a PR, i don't think we'll implement this otherwise.


doesn't work in my installation, test-client works

hi,
I tried your node. somehow it doesn't work for me. the test-client.js works fine, but not in node red.
any suggestions? do you have a testflow which I can try to assure I don't mess up things with payload injection?
thanks and best,
michael

@jurischm
hi.
at first, i don't know your environment.
please tell me your os, node-version.
where is test-client.js from?
if you check with original artnet-node's test-client.js:
now i use forked artnet-node was customized. please check 2bbb/artnet-node.
thanks


Ignore memory areas allocated by Android's JVM (aka Dalvik) when evaluating bit-flips

As per the title. Davlik allocates very large chunks of the address space, aligning them to natural boundaries which causes false positives when doing bit-flip detection.

This should be fixed after we fix #863


OLS-447: Added TODO: refactoring params from QuestionValidator

Description
TODO: refactoring params from QuestionValidator
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[x] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.39%. Comparing base (ba653e4) to head (5e79ee0).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
- Coverage   96.39%   96.39%   -0.01%
==========================================
  Files          53       53
  Lines        1830     1829       -1
==========================================
- Hits         1764     1763       -1
  Misses         66       66

Files
Coverage Δ

ols/src/query_helpers/question_validator.py
100.00% <ø> (ø)

/lgtm

/approve


i dont understand what SCall is??

Describe your problem here.
source/psychlua/HScript.hx:168: characters 89-94 : Type not found : SCall
what am i doing wrong?
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

https://github.com/ShadowMario/FNF-PsychEngine/wiki/Libraries-versions

All versions are correct and doesn't fix it for me


update linux package builds

Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.

[ ] CI passes
[ ] Description of proposed change
[ ] Documentation (README, code doc blocks, etc) is updated
[ ] Existing issue is referenced if there is one
[ ] Unit tests for the proposed change

fixes #144

this seems to fail because it tries to do a global rather than local install on package build:
/usr/bin/install: cannot create regular file '/usr/local/lib/librestclient-cpp.so.1.1.1': Permission denied

If I read Makefile.packaging.mk correctly, it expects the installed files in ./usr? Changing $(MAKE) install PREFIX=usr to $(MAKE) install PREFIX=usr DESTDIR=. in line 5 should fix the error.

If I read Makefile.packaging.mk correctly, it expects the installed files in ./usr? Changing $(MAKE) install PREFIX=usr to $(MAKE) install PREFIX=usr DESTDIR=. in line 5 should fix the error.

Needed to set DESTDIR="$(CURDIR)" instead.


UI - Github rate limited when trying to work with assistants that have knowledge/image/vision tools which have "@gateway" reference.

Version 0.10.0-rc1 (0.10.0-rc1)
Steps to reproduce the problem:

Create an assistant and add tool knowledge/image tool from featured list of tools.
Restart script.

This results in following  Github rate limit error

This issue is not seen anymore.
I am seeing an issue with vision tool which actually was working last night with rc2 builds. Will track this in a different issue.


Automatically change current website language after profile update

@damianooldoni noticed that if a user change its preferred language in its profile, it has no effect on the selected language of the website (only for emails).
While I think it's important to let users the freedom change language at any time using the selector in the navbar, it might be more user-friendly to automatically change it just when the user save/update its profile.

Hi Nico! Actually I think the situation at the moment is very user friendly: the language selector in the navbar is great.
I think the problem here is the fact that the language field in My Profile is confusing. I got confused just after a month of holidays 😄
The language of the alert notifications is a property of the alert, exactly as the notification frequency.. I think we should move this field in the Alert page. It can be perfectly put below the frequency notification field and calling it "Alert notifications language". They fit nicely. What do you think? This means the language could change from an alert to another, even if this is unlikely to happen of course. Is the engine flexible enough to support this so that you have not to work on it too much?
Otherwise, we have a very easy alternative: just replace "Language" with "Language of alert email notifications" in the Profile panel 😄

Hey @damianooldoni, if you're okay with this I think I will rather update the text in the profile form. There would be no technical problem to move the language to the Alert (rather than the user), but I think it doesn't make much sense:

I don't see any reason for a user to have multiple alerts in multiple languages
but the user language could be used for other things than just the alert e-mail languages (for example other automated emails: lost password, ...)

Therefore, I think the language should stay a user property rather than the alert property.

Great! It makes sense to me.

I improved things as discussed:

Clearer help message on profile edit form, so users understand the change will affect emails
The current language is updated on profile save (visitors can override it at anytime from the navbar)

I don't see changes on RIPARIAS production website. Maybe will change in a few minutes or tomorrow?

I just had to revert the second change ("The current language is updated on profile save") because it's hard to make this work reliably and I don't want to spend too much time at this (late) stage for a minor issue.
The clearer message is kept.
Things are not visible yet on production, because I didn't create a release with recent changes yet, I'll do that ASAP.


Recommended hardware

Add page with recommended hardware for

desktop
HIL / real time
cloud

Proposal
Desktop
Intel Core i9-9900 or better
NVIDIA RTX 2080 Ti
32GB RAM or more
NVMe SSD

HIL / real-time
N x rack workstation (with above desktop specs)

Cloud
Kubernetes cluster
Prefer higher CPU speed over core count
Prefer higher GPU count
Prefer RTX GPUs


Mirror TEMPEST data into GCW

Request from @wilsonsj100
•	GCReW transect issue: just to make sure I understand, you’d like the “TMP” control plot and EXO data mirrored into the “GCW” data files? So GCW will now have “UP”, “TR”, and “W” plots, just like the other synoptic sites? That seems sensible and easy to do, although we’ll want to make sure the metadata clearly explain this.

@wilsonsj100 Can you confirm this is what you want:
TEMPEST data including all plots:

Just the control plot data are now mirrored into the GCW folder:

Internally, they're marked as GCW upland:

...and so appear in the final L1 data as GCW UP files that are duplicates of the TMP C data:

Yes, this is what I want. This makes it easier for comparing across the sites rather than having to pull data from the tempest control releases. Thank you so much!
One thing I was thinking about is whether or not we need all the TEMPEST data or if we want to just pull what would match a synoptic site. For example, TEMPEST has a lot more teros sensors than the synoptic sites, but I think it is probably okay for users to decide what data they want to include?
Open to thoughts here.

Yeah, I think the choice of specific data is on users; I don't want to burden the processing pipeline with that level of additional complexity/specificity. I'd suggest we add a note to the GCW metadata file about this, though.
I'll open a PR for this and tag @stephpenn1 for her feedback.

Great idea to do this @wilsonsj100 and @bpbond. Agreed with Ben, it's certainly possible but would take a lot of decisions and edits to the pipeline. We would always make a statement that if we want to cross compare synoptic sites, people can use only the depth profiles.
Will look out for the PR Ben


Move ECR public assume-role setup to Periodic definition

Source the script for ECR public account role assumption to the Prowjob definition instead of Makefile.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abhay-krishna: Updated the job-config configmap in namespace default at cluster default using the following files:

key eks-distro-base-periodics.yaml using file jobs/aws/eks-distro-build-tooling/eks-distro-base-periodics.yaml

In response to this:

Source the script for ECR public account role assumption to the Prowjob definition instead of Makefile.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


revouninstaller: Add version 2.3.5

supersedes #5205, #562
RevoUninstaller is a tool for uninstalling programs including a file scan for leftovers after uninstallation.

RevoUninstaller shows an error when loading ctrlbars.dat, un_report.dat, and winapp_report.dat.
They are all binary files that cannot be directly interpreted.
Need manual persist.

Just to double-check, the Start Menu shortcut requires UAC permission. Is this expected?

It is expected. The main program requires admin rights.


Connection refused

from pywebostv import connection
client = connection.WebOSClient('IP')
client.connect()

it give me error: [Errno 111] Connection refused
what should I check?

Did you enable remote control over network on your TV?
Did you success to use the smartphone app?  (https://play.google.com/store/apps/details?id=com.lge.app1&hl=fr on Android)

Once you have enabled remote control over network as @Gustry says, you can perhaps check if there's a anything listening on that IP and port number 3000.

how to enable remote control over network?

@reizajudiz See https://www.lg.com/uk/support/product-help/CT00008334-1437131798537-others

http://webossignage.developer.lge.com/discover/webos-signage/discover-webos-signage/
maybe my signage version a bit different. I tried all possible menu but found nothing about remote control over network.
I'm using LG SIGNAGE SM5KD

Nmap scan report for for LG SIGNAGE
Not shown: 992 closed ports
PORT      STATE SERVICE
80/tcp    open  http
443/tcp   open  https
2046/tcp  open  sdfunc
3737/tcp  open  xpanel
9080/tcp  open  glrpc
9998/tcp  open  distinct32
10000/tcp open  snet-sensor-mgmt
10002/tcp open  documentum


Create node.js.yml

Check this out: https://github.com/skhalife/calculator/pull/14/checks?check_run_id=1354667353#step:6:53