Table does not empty when foudset becomes 0 records from a foundset.loadRecords(anotherFoundset) when paginated

When a table is using the form foundset, and it becomes 0 records by a foundset.loadRecords(anotherFoundset), the extra-table does not empty if it is paginated and the user is placed on a page different than first one. A workaround could be achieved by adding this:
if(foundset.getSize() === 0)
{
foundset.loadRecords();
foundset.clear();
}
Tested on latest servoy-extra-components package and on Servoy 8.3 and 8.3.1RC1.
I attach a sample solution on zip
test_ExtraTable.zip
. Reported on Jira on https://support.servoy.com/browse/SVY-12618

Fixed in Servoy 8.3.2.


Synthesis failed for Google.Cloud.Language.V1

Hello! Autosynth couldn't regenerate Google.Cloud.Language.V1. :broken_heart:
Here's the output from running synth.py:
Cloning into 'working_repo'...
Switched to branch 'autosynth-Google.Cloud.Language.V1'
Running synthtool
['/tmpfs/src/git/autosynth/env/bin/python3', '-m', 'synthtool', 'synth.py', '--']
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/apis/Google.Cloud.Language.V1/synth.py.
Cloning into 'gapic-generator-csharp'...
Submodule 'api-common-protos' (https://github.com/googleapis/api-common-protos.git) registered for path 'api-common-protos'
Submodule 'protobuf' (https://github.com/protocolbuffers/protobuf.git) registered for path 'protobuf'
Cloning into '/tmpfs/src/git/autosynth/working_repo/gapic-generator-csharp/api-common-protos'...
Cloning into '/tmpfs/src/git/autosynth/working_repo/gapic-generator-csharp/protobuf'...
Submodule path 'api-common-protos': checked out '93c9c383396b514193735292f6880fccc777614e'
Submodule path 'protobuf': checked out '815ff7e1fb2d417d5aebcbf5fc46e626b18dc834'
Submodule 'third_party/benchmark' (https://github.com/google/benchmark.git) registered for path 'protobuf/third_party/benchmark'
Submodule 'third_party/googletest' (https://github.com/google/googletest.git) registered for path 'protobuf/third_party/googletest'
Cloning into '/tmpfs/src/git/autosynth/working_repo/gapic-generator-csharp/protobuf/third_party/benchmark'...
Cloning into '/tmpfs/src/git/autosynth/working_repo/gapic-generator-csharp/protobuf/third_party/googletest'...
Submodule path 'protobuf/third_party/benchmark': checked out '5b7683f49e1e9223cf9927b24f6fd3d6bd82e3f8'
Submodule path 'protobuf/third_party/googletest': checked out '5ec7f0c4a113e2f18ac2c6cc7df51ad6afc24081'
Cloning into 'gapic-generator'...
Cloning into 'googleapis'...
> Task :buildSrc:compileJava NO-SOURCE
> Task :buildSrc:compileGroovy
> Task :buildSrc:processResources NO-SOURCE
> Task :buildSrc:classes
> Task :buildSrc:jar
> Task :buildSrc:assemble
> Task :buildSrc:compileTestJava NO-SOURCE
> Task :buildSrc:compileTestGroovy NO-SOURCE
> Task :buildSrc:processTestResources NO-SOURCE
> Task :buildSrc:testClasses UP-TO-DATE
> Task :buildSrc:test NO-SOURCE
> Task :buildSrc:check UP-TO-DATE
> Task :buildSrc:build
> Task :extractIncludeProto
> Task :extractProto
> Task :generateProto

> Task :compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :processResources
> Task :createProperties
> Task :classes
> Task :shadowJar

BUILD SUCCESSFUL in 14s
7 actionable tasks: 7 executed
Building existing version of Google.Cloud.Language.V1 for compatibility checking
Generating Google.Cloud.Language.V1
Running post-generation script for Google.Cloud.Language.V1
Building new version of Google.Cloud.Language.V1 for compatibility checking

Changes in Google.Cloud.Language.V1:
Unable to run your project.
Please ensure you have a runnable project type and ensure 'dotnet run' supports this project.
A runnable project should target a runnable TFM (for instance, netcoreapp2.0) and have OutputType 'Exe'.
The current OutputType is 'Library'.
synthtool > Failed executing /bin/bash generateapis.sh --check_compatibility Google.Cloud.Language.V1:

None
synthtool > Wrote metadata to synth.metadata.
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/__main__.py", line 109, in <module>
    main()
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/__main__.py", line 96, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed
  File "/tmpfs/src/git/autosynth/working_repo/apis/Google.Cloud.Language.V1/synth.py", line 20, in <module>
    hide_output = False)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/subprocess.py", line 418, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '('/bin/bash', 'generateapis.sh', '--check_compatibility', 'Google.Cloud.Language.V1')' returned non-zero exit status 1.

Synthesis failed

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


Synchronous attributeChangedCallbacks

Hi again,
coming from the same perspective as in my previous pull-request I was wondering how we could improve  the polyfill experience of the attributeChangeCallbacks compared to the native experience?
A native attribute change would trigger an event callback in the same run-loop. This would also happen for the polyfill implementation of IE9. However, in Safari or the current Firefox the attribute change event would only be noticed in the next MutationObserver callback.
What about changing the polyfill to always behave synchronous as in the case of IE9? What about making the handling of these changes faster by returning earlier on style attribute changes?

the TL;DR answer is: it's a feature, not a bug.
The reason MutationObserver is used is because it's faster and it scales more when you change many things at once. It's the requestAnimationChange equivalent for attribute changes and I believe even the native implementation works in a similar way behind the scene.
You don't want to change in a blocking/synchronous way attributes because that won't perform any good for bigger projects. Each little attribute change might trigger synchronous behaviors in all subnodes of a custom elements too or vice versa.
It's like changing the window size on resize event, you don't know when that blocking behavior would stop. Having that batched and optimized natively is a great thing.
Now, I understand the createdCallback gotcha and I've provided a work around for that, but I start believing you really have some problem with asunchronous code in general ... or if you could be so kind to explain me why would you want or need that, I might re-consider this answer.

P.S. MutationObserver like Object.observe were introduced to exactly avoid synchronous blocking changes, even to regular Objects. If I were you, I rather try to figure out how to deal with these scenarios instead of asking everyone and everything to be sync and blocking. Just saying, those APIs are not there to annoy developers but to actually help them.

TL;DR: I just want to have a real consistent cross-browser behavior.
If I would override the setAttribute method as you do in one of your examples, I would get this behavior out of the box. The only use-case I would not support would be the manipulation through the web-inspector in the developer's browser.

You have a consistent behavior, you define what should happen in the CustomElement prototype and events definition and you got it. That is what this polyfill is about, an API that works across platform consistently and it does ... so that's the good news.
The bad one is, you are apparently doing things that won't even work on Polymer since it uses same MutationObserver behavior because that's what you want to do as well but you don't know it yet ;-)

btw, you didn't give me a single vald use case for this request, so I am going to close this. Feel free to change my mind with real needs and please do not mention your testing frameworks, thank you for your understanding.


update/save/delete should be able to take more than one id

I have a table with an ID that consists of both its own ID and a foreign ID (let's say questionID and commentID which makes the unique id for a comment). I can not point to this comment with update/save/delete in its current state since they only take one id (which is not enough to define my comment).
A resonable solution would be a similar implementation to findAllWhere() which allows you to use both a single id and an array with id:s.

Now implemented:
findAllWhere()
saveWhere()
updateWhere()
deleteWhere()

In v1.1.7.


Every new job should be indexed by google

And when a job is removed, it also need to be popped out from search engines.


switch to alpine

Given all the pipelines we are using aomi in, having a smaller download would be amazing. Pretty sure this is just a matter of removing bashisms from the docker-entrypoint.

Guess this got done in https://github.com/Autodesk/aomi/pull/64


[1.20] Addon Range Tier isn't applicable if gived with command

The issue that i have found appear if you have a world with cheat enabled and try to launch this command:
/give PlayerName industrialforegoing:range_addonX (where X is any number admissible)
the range_addon that you got, isn't applicable to plant sower and gather (maybe also the other machines but i haven't tried)
Just crafted addon work
Industrial Foregoing Version:
industrial-foregoing-1.20.1-3.5.17.jar
Titanium Version:
Crashlog If Applicable (Upload to pastebin/gist):
No crash
Forge version: 47.3.1
Minecraft version: 120.1

Addons have NBT, get it from JEI, craft it or add the proper NBT to it.


No music playback on compiled version

I can't play music when i npm run start the application (freshly cloned)
When choosing a song it displays itself with its title, artwork, etc. but the progress bar is "loading".
(I'm trying to implement dynamic colors based on the artwork but i unfortunately can't test my code if I can't play a song)

It happened for me as well. Close app from tray and delete %appdata%\Apple Music\Preferences and Preferences.json

npm run start is only supposed to be used for development purposes not for playing music. In that state widevine is not authorized, only for some reason on Linux, it is. I suggest you don't use npm run start or yarn start to run the application and compile it to play music.

It happened for me as well. Close app from tray and delete %appdata%\Apple Music\Preferences and Preferences.json
Also language selection does not enforce the language anymore. It shows up in Polish even if config file says en

Could you show me your .log file please, open a ticket on the discord and post your log there.


HttpRuntime.Cache fix in unit tests

[X] You've read the Contributor Guide and Code of Conduct.
[X] You've included unit tests for your change, where applicable.
[X] You've included inline docs for your change, where applicable.
[X] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
PR to fix the HttpRuntime.Cache runtime exception in unit tests
PR Description
This is not a fix, I added this test to show how it can be reproduced and also propose a potential fix.
Addresses #401

@afshinm can we close this in lieu of #406


Add button "save wallet logs" to "failed to start node" error

please change text on "failed to start node" error to "Failed to start node. Please save wallet logs and contact support." https://zpl.io/VQl06RR

Please add button "save wallet logs" to line with error

Checked on build 5.3.10045.3500

Checked on build 5.3.10045.3500


[Bug]: cyclic dependency error is displayed in one of the old application

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
One of the old app is facing a cyclic dependency error in both release and Production

Link for the app : (https://release.app.appsmith.com/applications/616d26cd8cc2642df8e19f51/pages/616d26cd8cc2642df8e19f57/edit/queries/616d26cd8cc2642df8e19f5f
Steps To Reproduce

Opened one of the old app
The cyclic dependency error is displayed

Environment
Production
Version
Cloud

This issue wasn't reproducible in any other application and even in the same application, hence deprioritizing this issue.

@Rishabh-Rathod lets close if we can't reproduce

@Nikhil-Nandagopal just to clarify, this issue was there in the application at a certain page where we could see now also but there is no way we can re-create that again. Also, I wasn't able to find out it in past it went into that bad state.
Also, it happened only for the release app which also opens up the possibility that there was a bug in the release which never went to prod which might have caused this issue.


runtime(mysql): update syntax script

Problem:

syn region ...s in syntax/mysql.vim match function names inaccurately.
no syntax rules for mysql window function.
coarse highlight definition in syntax/mysql.vim.

Solution:

add \<...\> to match the function name accurately.
add syntax rules for mysql window function.
enhance the highlight definition.

@pronovic could you please review the PR?

thanks, but I think adding \> between the function end name and the closing parenthesis does't really make a difference.

thanks, but I think adding \> between the function end name and the closing parenthesis does't really make a difference.

I have removed all the '>'s in this PR.

thanks!

@pronovic could you please review the PR?

Hi @jiangyinzuo, I guess this is already merged, so you don't need my review.  As you can see from the history, this syntax file is pretty old, and I haven't personally updated it in a really long time — I don't use MySQL much any more.  So, I'm generally ok with any changes to bring it up-to-date.  Thanks for helping out.  :)


Provide a method to convert vDOM (stored in a variable) into HTML string or DOM

What problem does this feature solve?
I want to create a chatroom application, where the chat window might potentially run for many hours and display 100.000 messages. It's not feasible to display all of these messages with a v-for directive, because the VDOM will be huge and the application will become slow. Instead I would like to use a message template and a render function, to render each incoming message into an HTML string or an ordinary DOM object, and then simply append (with plain JS) that static content to the message log <div>. That will keep the chatroom application snappy and responsive for almost forever.
I can generate the renderer function, using Vue.compile(msgTemplate), but calling the renderer function (after binding it to a component) only gives me a VDOM JS object, not any HTML that I can use. I would need to transform this JS object into ordinary HTML myself, but that wouldn't be future-proof, because maybe in future versions of Vue.js the structure of the VDOM JS Object will change, and then my plugin will stop working. So I need the Vue.js library to do this transformation for me.
Thank you.
What does the proposed API look like?
var res = Vue.compile(msgTemplate);
var vdom = res.renderer.bind(this)();
var htmlString = Vue.toHTML(vdom);

You should use a virtual list solution that renders only what is visible. Here's something that solves your use case: https://github.com/Akryum/vue-virtual-scroller

if you really need to convert it to a string you can use the vue-server-renderer but I really recommend you to use a virtual scrolling list

@posva No, I cannot use vue-server-renderer, because it doesn't compile with Webpack. It only works on the server.
I'll check the virtual scroller you showed me here, to see if it's good enough.

The virtual scroller requires that each element have the same height, in order to prevent display glitches. That is not the case with chat messages. Also vue-server-renderer won't work.
So why did you close this ticket? Did you find my idea not interesting?

If you want to directly generate real DOM, I don't see why there's the need to even go through Vue's rendering pipeline. Just use plain HTML string concatenation would give you more control and better performance.
It's possible to implement virtual scrolling that can handle dynamic height, but currently there's no solid Vue implementation yet. Still, we consider this a problem that should be dealt with in userland rather than in core.


Failing to generate any PRs

https://github.com/Homebrew/brew-pip-audit/actions/runs/7985826380
@woodruffw at one point we talked about adding more debug info when this happens

Hmmm -- I thought I added some additional context from the SystemExit, but it looks like it doesn't percolate up. I'll look into it when I get a free moment.

So the problem here seem to be that stderr is just shunted into the ether.
On Wed, Feb 21, 2024 at 12:21 PM William Woodruff @.***>
wrote:

Hmmm -- I thought I added some additional context from the SystemExit,
but it looks like it doesn't percolate up. I'll look into it when I get a
free moment.
—
Reply to this email directly, view it on GitHub
https://github.com/Homebrew/brew-pip-audit/issues/73#issuecomment-1957376961,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAGBF7BSNNPFXUYBFSEWLYUYUITAVCNFSM6AAAAABDS5E4AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJXGM3TMOJWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
All that is necessary for evil to succeed is for good people to do nothing.

So the problem here seem to be that stderr is just shunted into the ether.

Yep -- I thought it got captured with SystemExit, but I was wrong. I think this will either need an upstream brew change to raise a real exception rather than just hard exiting, or some nastiness to capture stderr.

FWIW, I think it'd be fine if the stderr from pip just got printed to the
parent process's stderr, but I think right now it goes nowhere.
On Thu, Feb 22, 2024 at 4:10 PM William Woodruff @.***>
wrote:

So the problem here seem to be that stderr is just shunted into the ether.
Yep -- I thought it got captured with SystemExit, but I was wrong. I
think this will either need an upstream brew change to raise a real
exception rather than just hard exiting, or some nastiness to capture
stderr.
—
Reply to this email directly, view it on GitHub
https://github.com/Homebrew/brew-pip-audit/issues/73#issuecomment-1960320059,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAGBBNGR3IHFGRKRFPK53YU6X6DAVCNFSM6AAAAABDS5E4AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGMZDAMBVHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
All that is necessary for evil to succeed is for good people to do nothing.


update aglet to v1.1.0

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1980
https://travis-ci.org/ingenue/hunter/builds/255436512?utm_source=github_status&utm_medium=notification

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1981
https://travis-ci.org/ingenue/hunter/builds/255551367?utm_source=github_status&utm_medium=notification

Released: https://github.com/ruslo/hunter/releases/tag/v0.19.36
Wiki page: https://github.com/ruslo/hunter/wiki/pkg.aglet
All packages updated: https://docs.hunter.sh/en/latest/packages/all.html
Added to Graphics 2D/3D section: https://docs.hunter.sh/en/latest/packages/graphics.html

Thanks!

Added to Graphics 2D/3D section

We could add ogels_gpgpu here as well, although that one sits between graphics and computer vision.

Added: https://docs.hunter.sh/en/latest/packages/graphics.html


ublox_dgnss: 0.4.3-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository ublox_dgnss to 0.4.3-1:

upstream repository: https://github.com/aussierobots/ublox_dgnss
release repository: https://github.com/ros2-gbp/ublox_dgnss-release.git
distro file: rolling/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.3.5-4

ntrip_client_node
* added ament_cmake_uncrustify
* Contributors: Nick Hortovanyi

ublox_dgnss

No changes

ublox_dgnss_node
* added ament_cmake_uncrustify
* Contributors: Nick Hortovanyi

ublox_nav_sat_fix_hp_node
* added ament_cmake_uncrustify
* Contributors: Nick Hortovanyi

ublox_ubx_interfaces

No changes

ublox_ubx_msgs

No changes

@hortovanyi presumably this PR is superseded by https://github.com/ros/rosdistro/pull/37361 and can be closed?


Install and Upgrade fixes/changes/improvements

This is another pass through the install and upgrade functions, there is still massive opportunity to improve these.

Updated formatting to 2.0 standards
Removed several unused functions
Pulled a lot of inline styles back to the CSS, there is still plenty of them left :(
The upgrade file really needs to have all those hard coded language strings moved, did not even attempt those
Cleaned up some of the markup so install and upgrade were more similar
Cleaned up some of the JS

2.0 Specific stuff, in the upgrade

Added the avatar attachment => avatar custom directory conversion.  @emanuele45 that conversion is done in one step and it should probably be looped.  I have no idea how to do that with the install controllers
Fixed a few typos and missing requires in the upgrade db file
Added the drop custom index as in 2.0 the way the search words keys are created has changed and are not compatible with 1.x.  I choose not to re-create it during the upgrade, we should make note of it the readme.  The good part is it will be a lot faster to create in 2.0 then 1.x
Added the drop openid stuffz from the db
Added a new remove directories and remove files function (action_deleteOldFiles) that are left over from 1.x function.  Many were moved to new new locations or dropped in 2.0 so I tried to ID them all and remove them, its quite a long list. @emanuele45 another one for you.  Do you want the upgrader to attempt to move existing 1.1 language files to the new location?

That should be all of it, maybe, hopes 👯

Codecov Report

Merging #3584 (240088e) into development (017a8ba) will increase coverage by 4.87%.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##             development    #3584      +/-   ##
=================================================
+ Coverage          26.23%   31.11%   +4.87%
+ Complexity         15530    11514    -4016
=================================================
  Files                438      261     -177
  Lines              75259    49429   -25830
=================================================
- Hits               19743    15379    -4364
+ Misses             55516    34050   -21466

Impacted Files
Coverage Δ

sources/ElkArte/AdminController/ManagePosts.php
15.57% <ø> (-1.37%)
:arrow_down:

sources/ElkArte/Controller/Display.php
75.33% <ø> (+0.06%)
:arrow_up:

sources/ElkArte/FileFunctions.php
19.13% <0.00%> (-2.44%)
:arrow_down:

sources/subs/Editor.subs.php
45.71% <ø> (+0.34%)
:arrow_up:

sources/subs/Post.subs.php
47.58% <ø> (ø)

sources/subs/Profile.subs.php
22.97% <ø> (-0.01%)
:arrow_down:

sources/database/Database.subs.php
26.19% <0.00%> (-23.81%)
:arrow_down:

sources/ElkArte/Database/AbstractTable.php
37.50% <0.00%> (-6.25%)
:arrow_down:

sources/subs/Auth.subs.php
39.38% <0.00%> (-2.40%)
:arrow_down:

sources/ElkArte/User.php
15.55% <0.00%> (-2.23%)
:arrow_down:

... and 199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61334a...240088e. Read the comment docs.


test(semantic): re-organize snapshot-based tests

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#7495
#7494  👈 (View in Graphite)
#6388
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


problem with procfile file name

Trying to deploy the 6-pub-sub example i found a deploy error
ERROR: (gcloud.app.deploy) Error Response: [9]
Application startup error:
2018-09-06 15:00:38 [1] [ERROR] Procfile does not exist or is not a file
In this case, I changed file name from "procfile" to "Procfile" and it deployed correctly

Can you provide more information? Did you change the name of the file in the directory, or change the name referenced in one of the yaml files? It certainly seems that it should be procfile everywhere, not Procfile.
This sample was able to deploy for me the last time I tried it.

Closing this due to lack of needed details.


Start using Sphinx>=4.0

Require the minimum Sphinx version to 4.0,
(where PyClassmember was removed)
Remove customization.py
use the Sphinx builtin :abstractmethod: and :async: options to document coroutines

Closes https://github.com/brettcannon/gidgethub/issues/143

It looks like there's a difference in how different themes are rendering the :async: and :abstractmethod: options.
In the alabaster theme (local machine), I was able to render those correctly:

In the readthedocs preview documentation, it looks like none of those are being displayed correctly. Example is the members of abc.GitHubAPI

Looking at the build log, it looks like the version of sphinx_rtd_theme that got installed on readthedocs side is 0.4.3, and we need something newer. 😕

Had to create docs_requirements.txt file, but it seems to look fine now.
I wasn't sure about bumping the version of gidgethub itself. Is this just increasing the minor version?

I don't think any version needs to be bumped since it doesn't affect the wheel file.


SkinnedMeshRenderer?

Does this work with SkinnedMeshRenderers? Anyway I could?

It has been some time since I worked on this, but I believe the answer is no. Could it? Yes, but it would likely require significant work. From a quick read up, a skinned mesh takes the base mesh data and transform it in realtime using the underlying skeleton.
I remember seeing some fracturing/slicing solutions that handled skinned meshes but I don't remember what they were, sorry.


Fdn 2237 update docs with new eventbridge event

Add docs about Auditlog > Eventbridge integration. We already have page for Eventbridge notifications as well as existing events so I've added the event name and description in the table as well as the payload.
Audit log notifications will be available during/after the march release.
(This is the first draft so feel free to comment on the content as well as the structure)

https://bk-docs-pr-1928.onrender.com/docs/integrations/amazon-eventbridge#main Here's the updated page. @jameshill I've only added [Coming soon] for now. Let me know if the design/content needs to change.

Hey @mbelton-buildkite this is ready to go when you've got a moment to review.


[Bug] Hitomi's Deep Linking can't open Hitomi galleries with language set as N/A

Device information
App version: 1.3.1 (standard, ffc80c084, 9)
Preview build: 242
Android version: 9 (SDK 28)
Device brand: motorola
Device manufacturer: motorola
Device model: moto g(6)
Steps to reproduce

Try to open a gallery that has the language set as N/A from Hitomi's website via deep linking.

Expected behavior
The app ahould be able to open the gallery just fine
Actual behavior
The app will fail to load the gallery, with the error stating that the "Gallery or Gallery type is unknown"
Other details
These types of galleries do appear in "Hitomi Unfiltered" source and do work in the app. The problem is only with the deep linking system.

Fixed in https://github.com/jobobby04/TachiyomiSY/commit/1dfe3890a974eca96b07aca16cfa1042b61a08d1


Ember serializer

Needed this for a project I'm working on. It has a Laravel backend with an Ember.js client that relies heavily on including documents. It was ridiculously easy to make, just copied JsonApiSerializer and modified a single line. I've not run into problems for my project with this one-line-changed adaption, and I couldn't imagine no one else would be waiting for this, so I decided to add some tests and write some documentation.
Let me know what you think!

Found some bugs here (most of which also exist in JsonApiSerializer).
Also, I just found out JSON API standard was originally created to work with Ember Data, so I'm considering making a switch to JSON API for my project and focusing my efforts on improving that serializer (including the test suite). If no one else is interested in this serializer, I might close this PR.

I would be very interested in you taking on the JSON API Serializer. I have not had the time and it does need some work before this can be a v1.0 project.

JSON API is taking forever to get to 1.0
https://github.com/json-api/json-api/pull/413

I'm going to close this for now, if anybody is still interested in this feel free to comment and I'll re-open it.
I also think that custom Serializers should ideally have their own home before every man and his dog/turtle decides that they want their Serializer added.


linux: enable log rotation

cc: @taruti @cjb

Ok, I'm going to write stdout/stderr to keybase.startkbfs.log -- perhaps later keybase log send can send all files that start with keybase.* (including rotated logs).


[Java] Compliation issue with generated decoder

Hi,
With version 1.10.2, I noticed a compilation issue in the generated decoder.
My message schema (yaml) file is correctly parsed into xml file. Here is my message class in generic.xml (I omitted other non-optional fields in this class):
  <message name="MyMessageClass" id="10003" description="xx" semanticType="MyMessageClass">
    <other non-optional fields>
    <field xmlns="" name="myMessageAttribute" id="3" type="string16" semanticType="String" description="xx" presence="optional" sinceVersion="7"/>
  </message>

Here is a part of the auto generated MyMessageClassDecoder:
    public void getMyMessageAttribute(final Appendable value)
    {
        if (parentMessage.actingVersion < 7)
        {
            return "";
        }

        for (int i = 0; i < 16 ; ++i)
        {
            final int c = buffer.getByte(this.offset + 104 + i) & 0xFF;
            if (c == 0)
            {
                break;
            }
            try
            {
                value.append(c > 127 ? '?' : (char)c);
            }
            catch (final java.io.IOException e)
            {
                throw new java.io.UncheckedIOException(e);
            }
        }
    }

Apparently a void method should not return string.
This issue seems only happen to fields with type string (hence the decoder has getters that takes Appendable) and has the sinceVersion attribute (hence decoder checks for actingVersion in the getter method).
Thanks for looking into this.
Qihao

Can you provide an example xml document that illustrates the issue?

This may be the same issue as the following which has already been fixed.
https://github.com/real-logic/simple-binary-encoding/issues/648

Closing as it is a duplicate which has been fixed on the 25th Feb 2019.

thanks @mjpt777 I've just verified it in a later version.


[ ASK ] how to get uuid-based-token

Halo Stephen, i want to ask you something about the package that you made .. first of all, i am very thank you that you made this .. it really help me so much :smile: ..
i want to ask you about this, you said
$ broadlink-bridge start -p <port> -t <uuid-based-token>,<uuid-based-token>,...
i want to know, how can i get that uuid-based-token ? thanks :pray:

Hi @dwilimsius,
Glad to hear the project has been helpful, let me know if you have any feature requests as you use it.
The token is something you can create yourself as it is only used for authenticating HTTP requests. It can be as simple (not recommended) as broadlink-bridge start -p 3000 -t 12345 or using a proper UUID, such as broadlink-bridge start -p 3000 -t 71451653-bf42-4652-9273-a28673c820c5.
You can use https://www.uuidgenerator.net/ to quickly generate a UUIDv4 and then copy and paste it into your .env file as TOKENS=<your-token-here> or pass it through the CLI like -t <your-token-here>.
And all your HTTP requests will then need to contain a header "Authentication": "Bearer <your-token-here>".
-- Stephen

Hi @401Unauthorized , ooh i see .. okay Stephen, thank you so much for your response .. i am gonna try it again then :smile:

Hi @401Unauthorized .. i want to ask you about this ..
so, i follow your step to connect my Broadlink to my localdevice .. but when i try to run $ broadlink-bridge connect -w my_wifi_name -p my_wifi_password -s 3 .. it suddenly make my laptop disconnected from BroadlinkProv and reconnect to my real wifi, and in terminal i saw it stuck at Attempt to connect my_wifi_name .. what should i do then ? thanks in advance Stephen

Looks like you are doing everything correctly!
Some things to note:

Make sure you are setting the correct number which aligns to the the security of your WIFI. 3 is the default and most common but you may have another setting if using an older router.

You will actually only see "Attempting to connect...". There is not going to be a "Connected" or other message in the terminal. The information will be sent to the broadlink device but the blaster will automatically switch from AP mode (where the blaster is making its own wifi called BroadlinkProv) to trying to connect to your wifi network. Your computer will automatically disconnect from the blaster and connect to your normal wifi.

Make sure the WIFI you are trying to connect to is 2.4GHz. If you have 2.4Ghz & 5.0GHz networks with the same name, the blaster may have issues picking the right one. If possible, name the 2.4GHz differently.

In order to verify the blaster is connected to WIFI, the simplest option is to log into your router's UI and see if the device is listed.
I'll create a feature request on this project to make the WIFI connection process better so that if possible, it will provide feedback to the user when the device is connected and reachable on the WIFI network.

@dwilimsius,
Were you able to get the blaster connected and broadlink-bridge running?
I'll close out this issue soon but let me know if you need more support.


Custom fields: default value not being set for boolean type

I have a custom field for devices of the type boolean. It is not required, but filterable and has the default value "false" like described on the admin site.
When I go to the page to add a new device, the default value is not set for this field. Instead only "---------" is displayed, but "True" and "False" are only selectable via the drop down menu. It seems boolean defaults don't work at all. I also testet "False", "true" and "True" as defaults and neither of them have been inserted as default value.
Text and integer fields work well. So it seems to be only an issue with the boolean type.

What version of NetBox are you running?

1.8.0


Add colored debuff shadows

Also sets the temp item enchant shadow color

Looks good, can I use this in my work?

Looks good, can I use this in my work?

ofc.. go for it

Looks good, can I use this in my work?

Yea you can add it to your wind tools


CPF-3920/Fix Search to change data

adding a predicated dao -searchFilterDAO - to filter view - FilterSearch
This PR changes the search (as seen in below image), to use the tabbed daos (cannedQueries).
In the DAOBrowserView, the dao that is displayed in the tableView is filtered by the models cannedQueries. This PR unifies the search parameter dao's to the dao's displayed in the tableView.

addresses: https://nanopay.atlassian.net/browse/CPF-3920

nice


Cookie banner

with visitor-tracking, opt-in is obligatory, and there needs to be a "privacy setting config" area, so users can reverse their decisions (latest court ruling...). Matomo provides the necessary information in the "Privacy" Sub-Menu (also iframe-Code for onboard Opt-out option).


Fix collection22

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 115306 run on x86_64-linux 1

3 packages failed to build and already failed to build on hydra master:

csvkit: log was empty
python38Packages.agate-sql: plain log  |  pretty log
python39Packages.agate-sql: log was empty

2 packages built:

python38Packages.crate
python39Packages.crate

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.agate-sql:

warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md


I can't to see  the plus icon to expand my code, when it's collapsed

VSCode Version: Code 1.3.0 (e724f269ded347b49fcf1657fc576399354e6703, 2016-07-07T16:56:12.476Z)
OS Version: Windows_NT ia32 6.1.7601

Steps to Reproduce:

change a code already commited by git
In the same line, I cannot to see the plus icon to expand my code (when it is collapsed)

dup of #9222


We need a stress testing suite to show the true capability of Flowmix as well as to surface any bottlenecks that could seriously hinder the ability to process flows in real time.

well this may sound simple but I usually use the ol' JMeter with a custom class, if you are interested I could propose one (with results). I'm concerned particularly about the memory use.

Sounds great. Memory use is definitely something worth optimizing. I'm also concerned about the data being stored primarily on-heap and the effects of garbage collection in the caches.

awesome, this could be useful to compare new versions of things


Add environment path to jpath for relative imports

enviroment main.jsonnet files updated the path of the import of
base.libsonnet to remove the relative bits because you can't assume
that the environment root is directly off the root. This breaks older
applications. The fix is to add the environment path to the jpath.
Fixes #493
Signed-off-by: bryanl<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 838

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 4.567%

Totals

Change from base Build 837:
0.0%

Covered Lines:
19

Relevant Lines:
416

💛  - Coveralls


1.3.4 Software Architecture Decision

Screenshot of the Software Evaluation method selected by the team. Done by Jansen.


Fix trace tb generation

This PR provides some improvements for the generation of Verilog test benches.
Please have a look at the commit messages for a detailed description of the changes.
There are still some problems. But it would be nice to get some feedback if the changes make sense.
If I have a solution for #1676 I can update this PR to include the changes. Or this can be done independently.

@towoe are you still interested in finishing this PR? What is blocking it?

@nakengelhardt I think it would make sense to get the hierarchy information in for const signals as well so this can be reused in a similar way as with the other signals.
But I am not familiar with the code at the moment to see how it can be done without .as_wire() and if the format is different from the other signal types it just makes it harder to retrieve the information at a later point.

I'm not familiar with the smt2 format. Is everything in infostr, including the space and what's after it, part of the comment? Is it possible to add more spaces? If so, could you change the order and put the source location at the end?
If you have a small testcase that I could play around with to see the output, and the error that it causes, that might help.
For the .as_wire() problem, you can guard it with if(x.is_wire()), but you have to figure out what the appropriate thing to do is when it's not a wire...


[tibs] Consolidate uses of Process and fix warnings

Fix warnings by using the non-deprecated APIs, and while we're at it
consolidate all the uses into a single place that checks the result and
collects stdout. Inspired by SwiftPM's checkNonZeroExit.

@swift-ci please test


Validations are needed at both core and client level

Currently, most Resources can be created with required attributes missing, which can lead to a wide array of nil pointer de-references and even deeper errors with Kubernetes provisioning.
This could be resolved easily with model validations, and validations that required IDs exist when creating resources through the client.

Closed by #71


Fix whitespace chars in makefiles/Makefile.port

During the refactoring of makefiles, some TABs in Makefile.port have been mistakenly replaced by spaces, which made the project unbuildable. This commit fixes the errorneous whitespace chars in Makefile.port file.

I signed it!
On Wed, Jan 11, 2017 at 2:40 AM googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the
company's name.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/301#issuecomment-271753599, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFvVHwQXRZXrmeou9c8PxtCIzoAFPzswks5rRDMSgaJpZM4LgGlA
.


Adds support Breadcrumbs Helper

Description
Adds support Breadcrumbs Helper
Summarize
New Breadcrumb Helper
New BreadcrumbHelperTest
Related Issues
#176

I made a few of the desired changes but it still needs tests, and also it fails on php 5.4 since the BreadcrumbsHelper is new-ish.


How do I disable the system menu from the custom buttons at the top of the form?

Form at the top of the default button will not display system when the mouse right click on the menu, but when I was at the top of the other custom button can't stop it, according to the set WindowChrome. IsHitTestVisibleInChrome no effect, whether there are other ways to solve?

I looked at other applications that have additional buttons in their title bar like MS Word and Google Chrome and it seems they behave just like AdonisUI by opening the system context menu as well.
But if you still want to suppress the context menu in your application you could attach an event handler to the MouseRightButtonUp event of the button and declare the event to be handled.
In your window xaml:
<adonisControls:AdonisWindow.TitleBarContent>
    <Button Style="{DynamicResource {x:Static adonisUi:Styles.WindowButton}}"
            MouseRightButtonUp="TitleBarButton_OnMouseRightButtonUp"/>
</adonisControls:AdonisWindow.TitleBarContent>

In code-behind:
private void TitleBarButton_OnMouseRightButtonUp(object sender, MouseButtonEventArgs e)
{
    e.Handled = true;
}

Hope this helps.

Closing this because no further feedback was given for a while. Please reopen in case the suggested solution does not work for you or does not answer your question.

Thank you very much for recording my question and giving me a reply. Your suggestion is very effective for me. Thank you at last.
From LungMaang
Sent to Mr. Benjamin Rühl
发件人: Benjamin<EMAIL_ADDRESS>发送时间: 2019年12月30日 1:38
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [benruehl/adonis-ui] How do I disable the system menu from the custom buttons at the top of the form? (#47)
I looked at other applications that have additional buttons in their title bar like MS Word and Google Chrome and it seems they behave just like AdonisUI by opening the system context menu as well.
But if you still want to suppress the context menu in your application you could attach an event handler to the MouseRightButtonUp event of the button and declare the event to be handled.
In your window xaml:
adonisControls:AdonisWindow.TitleBarContent
<Button Style="{DynamicResource {x:Static adonisUi:Styles.WindowButton}}"

        MouseRightButtonUp="TitleBarButton_OnMouseRightButtonUp"/>

</adonisControls:AdonisWindow.TitleBarContent>
In code-behind:
private void TitleBarButton_OnMouseRightButtonUp(object sender, MouseButtonEventArgs e)
{
e.Handled = true;

}
Hope this helps.
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/benruehl/adonis-ui/issues/47?email_source=notifications&email_token=AN4MKPMNDXUZ5IGXZD7XAG3Q3DN6XA5CNFSM4J7ACPQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZEPSA#issuecomment-569526216, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN4MKPOOCVOB4LAO5NSN7ATQ3DN6XANCNFSM4J7ACPQQ.


Remove some macro, merge two header files ， add bit flags and add LIN bus-type

Summary

Some macro definitions have already been defined in other header files, redundant macro definitions have been removed, and the code has been optimized.
To align with the layout of Linux can header file.
Add some bit falgs on can_frame.flags for special frames.
Add LIN bus-type header file.

This patch is associated with 'https://github.com/apache/nuttx/pull/2518', so it cannot be verified separately by CI. Please help to associate and review it. Thank you!
Impact
CAN protocol stack.
Testing
Brush the modified system to the CAN development board, and the CAN communication between the development board and peripherals is normal. The lower-half driver can make some special frame, such as tx_confirmation frame, and application program can recognize special messages through can_frame.flgas.

@acassis Hi acassis:
This patch is associated with nuttx-apps/pull/2518, so it cannot be verified separately by CI. Please help to associate and review it. Thank you!

FYI @PetervdPerk-NXP since you are the initial author of SocketCAN in NuttX

Overall I'm not a fan of merging the CHRDEV header with the SocketCAN header. Those are 2 distinct subsystems.
Also I would like to maintain compatibility with Linux I think this PR might break that.

@PetervdPerk-NXP CAN chardev header is in include/can/can.h. Merged headers are for SocketCAN only which are: include/netpacket/can.h and include/nuttx/can.h.
Changes in include/can/can.h (chardev) are not related to changes for SocketCAN.

@PetervdPerk-NXP @raiden00pl @raiden00pl
I will fix the comments and pull request commits  one by one. Thank you !

remove breaking change from this patch since the patch modify public interface drop from this pr.

@HedongGao please add to commit title and commit message also info from this PR summary, as this commit modify more things than CANIOC_XXX macros

@HedongGao please add to commit title and commit message also info from this PR summary, as this commit modify more things than CANIOC_XXX macros

Done!

@HedongGao I see you modified PR title, not commit title and commit message :) please use git commit --amend and force push.

@HedongGao I see you modified PR title, not commit title and commit message :) please use git commit --amend and force push.

Done！


Migrate off of CentOS Stream 8 in CI, EOL is May 31st, 2024

CentOS Stream 8 is used in the source-build/VMR CI.  It is also the distro used by default in the arcade source-build repo templates.  CentOS Stream 8 EOL is May 31st, 2024.
For .NET 8+, Stream 8 should be replaced with Stream 9.
For .ENT 6, we ideally would test on a distro in the RHEL 8 family.

I was doing some quick testing, and if there is some way to disable runtime's build-time dependency on lttng-ust-devel, it should be possible to use UBI8 as an alternative to Stream 8

This was resolved by the work done in https://github.com/dotnet/source-build/issues/4399.


feat: remove deleted set in tree state and optimize api

This PR removed the deleted set which is used for caching all deleted TreeID. Because the complexity of querying whether a node has been deleted is only related to the node depth and the node depth is generally not too deep, we treat it as a constant term.
Performance

main
PR

create 10^4 nodes
4.8 ms
4.7 ms

move 10^5 times
63.7 ms
122.4 ms

move 10^6 times
632.7 ms
1213 ms

checkout 10^3
66.2 ms
68.2 ms

checkout 10^3 (300 depth)
313.8 ms
347.8 ms

checkout 10^3 (600 depth)
1290 ms
1409 ms

realtime 10^3 move
464.1 ms
461.4 ms

API
When using Tree, I also found that the API design was not natural enough, so I took the advice from #223.
I added a new class LoroTreeNode in wasm, it takes TreeHandler and is responsible for operations related to the node itself.
Here are some examples
import { Loro } from 'loro-crdt'

const doc = new Loro();
// create Tree
const tree: LoroTree = doc.getTree("tree");
// create Root node
const root = tree.createNode();
// create a child node of root
const node = root.createNode();
// the unique TreeID
const id = node.id;
// make node to be another ROOT node
node.asRoot();
// move node to be child node of root
node.moveTo(root);
// set metadata of node
node.data.set("color", "red");
assertEquals(node.parent.id, root.id);
assertEquals(root.children[0].id, node.id);
const sameNode = tree.getNodeByID(id);
if (tree.has(id)){
    // delete node
    tree.delete(id);
}

‘node.asRoot();’ sounds like it doesn't change the node, and just takes a view of it. I think setAsRoot is better

‘node.asRoot();’ sounds like it doesn't change the node, and just takes a view of it. I think setAsRoot is better

I agree.

Move 10^5 times

This benchmark is moving a node to a random other node where each other node has an equal chance to be its parent, right?

Yes, 1000 nodes are created first, and randomly choose child and parent.

Is it only local op? Why does this PR make it slower?

fixed, I will update the benchmark


Unlink related works from parent

Add actions to related works view partials to unlink from parent. Right now the only way to do this is by deleting the related work. Come to think of it, this should be a CurationConcerns ticket as well.

I suspect that this may be partially (if not fully) resolved by #175  (please see https://github.com/projecthydra/curation_concerns/blob/v1.5.0/app/actors/curation_concerns/actors/add_to_work_actor.rb).  It was determined that I can return to addressing this after CurationConcerns has been updated.


360 add table name validation

Add table validation to the importers

Complete the PR on validation refactoring and merge develop in this one. Otherwise, all good.


Forms View (Tavern) with Feedback Form

Needs Description

Feedback/Contact/Request form created.

Tavern Quest Board, will be editable.


Prompt for reload when new service worker is available

When a new service worker is in waiting state, prompt the user if they want to reload the app so the service worker can kick in.

We now require new translations for alerts.newVersionAvailable. Not sure how to request those.

In the mid-term we probably want to swap the window.confirm() prompt for something more user-friendly like a "toast" message.

IMO we should just reload the page without prompting the user

So the magic ingredient is to post SKIP_WAITING message, which is something CRA specific?
I'm for no-prompt, too btw. When we introduced PWAs, we first had a tiny popup telling users of new versions available, and we got rid of even that. Having a modal is even worse :).

Alright, I'll change to no prompt.

Question:

Is the statechange event emitted only when the app receives an update (so that we don't reload in cases we don't want to)?
And also, what if we don't reload at all - would the SKIP_WAITING command transfer over to the next load (e.g. user exits the page without reload, and then opens excalidraw later in new tab.. will that new tab still have old version, or new one)?

Is the statechange event emitted only when the app receives an update (so that we don't reload in cases we don't want to)?

This "is basically fired anytime the ServiceWorker.state changes".

And also, what if we don't reload at all - would the SKIP_WAITING command transfer over to the next load (e.g. user exits the page without reload, and then opens excalidraw later in new tab.. will that new tab still have old version, or new one)?

The new service worker would skip the wait and kick in, the app needs to be reloaded to avoid having a service worker with potentially different assumptions than the app code.

This "is basically fired anytime the ServiceWorker.state changes".

Right, but when does that happen in practice in our case? You subscribe to it when the SW is waiting (in other words, only for already installed workers), so that leaves activating, activated, and redundant state changes? Which one correspond to app updates?

The new service worker would skip the wait and kick in, the app needs to be reloaded to avoid having a service worker with potentially different assumptions than the app code.

You mean when the new SW is active, but still not reflected to the app code? And are we talking about it happening after 1) users open excalidraw in a new session, or 2) still when they haven't closed the previous one?

Right, but when does that happen in practice in our case? You subscribe to it when the SW is waiting (in other words, only for already installed workers), so that leaves activating, activated, and redundant state changes? Which one correspond to app updates?

We only enter this process when a service worker is waiting.

You mean when the new SW is active, but still not reflected to the app code? And are we talking about it happening after 1) users open excalidraw in a new session, or 2) still when they haven't closed the previous one?

Skip waiting means the service worker kicks in immediately. Since it's the same service worker across all tabs (clients), these clients may be in different states. So reloading is always the best option in our case.

Thanks for the PR and the elaboration!


Implicit rules instead of scaffolding on the fly

It would be nice if I could do something like this:
public rules()
{
    return [
        'email' => 'email:rfc,dns',
    ] + \LaracraftTech\LaravelSchemaRules\Resolvers\BaseSchemaRulesResolver::generate();
}

or do you consider this out of scope?
I know, the above code is just pseudocode. There would have to be a merge() method to prevent the keys from overwriting each other.

Hi @shaedrich, I don't think this is a good idea, cause the generate method is doing some database queries and I don't think you want this overhead on every request...

Hi @Sairahcaz, I never said, it couldn't be cached 😉


Issues parsing array arguments?

Not sure if people consider this an issues, however, arrays are apparently padded with nulls for missing values,
> JSON.stringify(url('?','?t[0]=x&t[1]=y'));
"{"t":["x","y"]}"
> JSON.stringify(url('?','?t[0]=x&t[2]=y'));
"{"t":["x",null,"y"]}"

Maybe the better option would be to return objects for sparse arrays, like so,
> JSON.stringify(url('?','?t[0]=x&t[1]=y'));
"{"t":["x","y"]}"
> JSON.stringify(url('?','?t[0]=x&t[2]=y'));
"{"0":"x","2":"y"}"

I think this is a complaint against how sparse arrays are represented in JSON, and not an issue with this library.
// an ordinary sparse array
var sparse = [0,,2];
console.log(`%o`, sparse); // [0, empty, 2]
console.log(JSON.stringify(sparse)); // [0, null, 2]

Notice that passing a sparse array through JSON.stringify results in information loss. These three different arrays can only be represented by one JSON object:
var sparse = [0,,2];
var undef = [0, undefined, 2];
var nully = [0, null, 2];

[sparse, undef, nully].forEach(a => console.log(JSON.stringify(a)));
// [0, null, 2]
// [0, null, 2]
// [0, null, 2]

Adding https://github.com/websanova/js-url into the mix isn't the source uncertainty. Representing a sparse array in JSON is the source of uncertainty.
var got = url('?','?t[0]=0&t[2]=2');
console.log(`%o`, got);    // {t: ["0", empty, "2"]}
console.log(JSON.stringify(got)); // '{"t": ["0", null, "2"]}'

I think js-url does not need to return a special sparse-array-object when it finds one, because it already returns properly sparse arrays.

Vote to close per above


Add UpstreamSettingsPolicy CRD

Proposed changes
Problem: Users want to configure the behavior of the connection between NGINX and their upstream applications.
Solution: Add the UpstreamSettingsPolicy CRD, which is a direct policy that will attach to a Service that is referenced in an HTTPRoute or GRPCRoute.
Testing: Tested that validation works.
Closes #2502
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING doc
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that all unit tests pass after adding my changes
[x] I have updated necessary documentation
[x] I have rebased my branch onto main
[ ] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Would like a review on the validation of fields, then I will test that the CRD can be installed and validation works. Then I will promote the PR to be ready for review.

The design doc does mention adding the zoneSize field to the NginxProxy CRD as well. @kate-osborn Think it's worth adding that as part of this PR?

The design doc does mention adding the zoneSize field to the NginxProxy CRD as well. @kate-osborn Think it's worth adding that as part of this PR?

Let's handle that separately. I can create an issue for it.

Manually tested that current validation works.

@bjee19 Shouldn't we include an example of what the CRD looks like?

@kate-osborn
Looking at the default for keepalive time being 1 hour here https://nginx.org/en/docs/http/ngx_http_upstream_module.html#keepalive_time
our current Duration definition we use here: https://github.com/nginxinc/nginx-gateway-fabric/blob/bf17bd50009b3eecc96162e302015ee894f1fb12/apis/v1alpha1/shared_types.go#L8
seems to only be in seconds to milliseconds.
This is an issue right? Does this affect other policies whose duration are longer and yet are being limited to be seconds or ms such as ClientSettingsPolicy's keepalive time  here: https://nginx.org/en/docs/http/ngx_http_core_module.html#keepalive_time

@bjee19 good find and question.
This came up on the PR for adding the ClientSettingsPolicy CRD, and we decided to support only ms and s: https://github.com/nginxinc/nginx-gateway-fabric/pull/1793#discussion_r1546952548. Looking back at all the fields that use this type, ms and s work make sense for everything except keepalive_timeout. I think this was just an oversight.
It's not a problem, per se, since you can express hours in seconds, but it's inconvenient. Let's change the validation on Duration to ^[0-9]{1,4}(ms|s|m|h)?$. Like Michael says in the linked thread, relaxing validation isn't a breaking change, so we can make this change without bumping the version of the CRDs that depend on it.

@kate-osborn
I see, thanks for explaining and giving me more background.
Since this PR is going into a feature branch, should I make the change to the Duration validation in a separate PR targeting main? Also, would it be beneficial to cherry-pick that PR onto the recent release?

I have hereby read the F5 CLA and agree to its terms

I messed some stuff up with the feature branch, i created it a while ago so it was quite behind main. When I rebased my local branch with main and didn't update the feature branch stuff got messed up. Things should be fixed.

@kate-osborn
I see, thanks for explaining and giving me more background.
Since this PR is going into a feature branch, should I make the change to the Duration validation in a separate PR targeting main? Also, would it be beneficial to cherry-pick that PR onto the recent release?

Yes, let's fix in a separate PR that targets main. No, we don't need to cherry-pick it to the release branch. That would require a patch release, which this issue doesn't warrant.


Feat: Add JSON mode on exports.

It will be amazing for the community!!!

Sure I can add a JSON exporter, is there a particular format you have in mind or just access to block names and their positions?

@LucasDower
Schematic already uses a format that is a bit similar to JSON: https://www.reddit.com/r/Minecraft/comments/k3rrce/is_there_a_way_to_convert_schematic_files_into/
Only repo I found while googling it is:
https://github.com/MicleBrick/Schematic2Json
Which isnt very serious...
Also there are other people asking that question:
https://www.reddit.com/r/MinecraftHelp/comments/tzv3z1/is_there_a_way_to_convert_minecraft_schematics/
But as you can see there are no answers.
As of now it doesnt seem that JSON is used for storing minecraft structure nor that there is a norm for that kind of file. This means that there is no relevant norm (approved or used) that we could choose to implement.
@Dkavila
If you need to have the structure formated in a JSON file for your specific needs, I suggest you fork this repo and create your own norm for that kind of format. This will also provide you with more freedom & knowledge when it comes to programming your parser (to read the JSON files you'll make).

I imagine the main benefit of a JSON exporter is that it's the easiest to parse, any popular language has JSON libraries so if somebody wants to use the block data somewhere it's a lot easier to load a JSON file than try decipher any of the NBT-based exporters.
Like @0-zen said, it's just about deciding the format. The main concern is that (1) JSON is text-based so encoding is slow, and (2) there's potentially tens of thousands of blocks and JSON is quite verbose so the file could be massive.
We could export something simple like:
[
  { "x": 0, "y": 0, "z": 0, "block": "minecraft:stone" },
  { "x": 1, "y": 8, "z": 7, "block": "minecraft:bedrock" },
  { "x": 2, "y": 1, "z": 4, "block": "minecraft:cobblestone" },
  ...
]

which would be super implement and super simple for an external program to read but is not very suitable for massive builds.
Alternatively we could go down a similar approach to the .gltf format is a JSON file with block data buffers stored as base64 encoded strings.

I feel that if we use base64 for encoding, we are going to target people who already know how to program a bit. We might as well create our own binary format, which will be much more compact. Or we could inspire from binary PLY files, which have a structure that starts with a short ASCII header and then binary body.

Added 'Indexed JSON' and 'Uncompressed JSON' exporters.


fatal error: html.h: No such file or directory

Hello,
I'm trying to build Resiliparse 0.13.7 from source, and I'm getting this error. Can you tell me which library Resiliparse is expecting to get html.h from? I suspect I'm missing a dependency.
resiliparse/extract/html2text.cpp:869:10: fatal error: html.h: No such file or directory
#include "html.h"
^~~~~~~~
Thanks,
Dave

html.h should be part of the source package. If that files is missing from the wheel somehow, try building from the repository instead.

I downloaded the 0.13.7 source zip file and that file IS there if that line is referring to resiliparse/parse/html.h.
Any advice as to why this error would occur if the file exists?

I'm not quite sure why your compiler would look for it there. This is the relevant import:
https://github.com/chatnoir-eu/chatnoir-resiliparse/blob/develop/resiliparse/resiliparse/extract/html2text.pyx#L26


fix link typo on README.md

There's a typo on the template page file link, it links to error.error instead of error.md

thanks


Eclipse IDE for C++ 2024-03 coredumps when accessing the marketplace on openSuSE Leap 15.5

Please provide a brief summary of the bug
While attempting to bring up the marketplace panel to look for extensions, the Eclipse IDE for CPP coredumps consistently. I tried switching JVMs from 17 to 21 but it made no difference.
Did you test with the latest update version?

[X] Yes

Please provide steps to reproduce where possible

Install the required JDK for your project, in my case Java 17 or 21 Temurin release
Launch the new version of Eclipse for C++ (v2024-03)
Select the workspace you use, if asked
From the Help pull-down menu select 'Eclipse Marketplace'
The 'Eclipse Marketplace' panel will pop up for about 2 seconds and then the entire IDE crashes
hs_err_pid32738.log

Expected Results
I expect the 'Eclipse Marketplace' panel to stay open to search for the plugins/extensions that I need for the editor and the C++ language I need to use.
Actual Results
The entire IDE crashes and I am not able to use it.
What Java Version are you using?
openjdk version "21.0.3" 2024-04-16 LTS OpenJDK Runtime Environment Temurin-21.0.3+9 (build 21.0.3+9-LTS) OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (build 21.0.3+9-LTS, mixed mode, sharing)
What is your operating system and platform?
openSuSE Leap 15.5, up to date
How did you install Java?
I used SDKMAN:
script: 5.18.2
native: 0.4.6
But I also downloaded and reproduced the problem with the version you suggested at  https://adoptium.net/temurin/releases/
Did it work before?
The previous version of Eclipse that I had installed was 2021-12 for Java Development and it was running with Java 11.0.22+7 and it also has the same problem.

I have installed now the Eclipse for C++ and I still have the same issue.

Did you test with other Java versions?
I have test this issue with java 11, 17, and 21, and the version of Temurin that you have suggested above. I have encountered the same problem with all of them.

So far, that seems to be the only panel that it seems to crash the entire IDE. It only seems to crash when I try the 'Open Marketplace Favorites' or the 'Eclipse Marketplace' menu options.

Relevant log output
$WARNING: Using incubator modules: jdk.incubator.vector
May 26, 2024 2:11:48 AM org.apache.aries.spifly.BaseActivator log
INFO: Registered provider org.slf4j.simple.SimpleServiceProvider of service org.slf4j.spi.SLF4JServiceProvider in bundle slf4j.simple
*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug

*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug

*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug

*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug

*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug

(Eclipse:32738): Gdk-CRITICAL **: 02:12:12.066: gdk_window_create_gl_context: assertion 'GDK_IS_WINDOW (window)' failed
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007f3907e922e0, pid=32738, tid=32739
#
# JRE version: OpenJDK Runtime Environment Temurin-21.0.3+9 (21.0.3+9) (build 21.0.3+9-LTS)
# Java VM: OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (21.0.3+9-LTS, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Problematic frame:
# C  [libwebkit2gtk-4.1.so.0+0xe2d2e0]
#
# Core dump will be written. Default location: Core dumps may be processed with "/bin/false" (or dumping to /home/epulido/eclipse/cpp-2024-03/eclipse/core.32738)
#
# An error report file with more information is saved as:
# /home/epulido/eclipse/cpp-2024-03/eclipse/hs_err_pid32738.log
[25.643s][warning][os] Loading hsdis library failed
#
# If you would like to submit a bug report, please visit:
#   https://github.com/adoptium/adoptium-support/issues
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.

Likely #1060


Have to re-start gui before I can chat when following new user

If I try start to follow a user, then decide to chat with them, I can find them in the gui, but it goes back to the empty chat gui when I click on "start a chat". The only way I can start a chat with them at this point, is to completely shutdown keybase, and re-run run_keybase.
my log id: bd334dcbb37c2fb6670e9d1c

cc: @keybase/react-hackers

Yeah I think if you don't send a message after first creating a chat, it gets lost on next inbox refresh.
I created internal issue here: https://keybase.atlassian.net/browse/DESKTOP-2837
Maybe prioritize? (It was surprising to me too.)


Add support for custom themes.xml and styles.xml

This hook copies files in resources/android/values/ to platforms/android/res/values.
We ran into this limitation when we wanted add custom styles and theme for the android app. Android Styles and Themes

Thanks, this looks very good!
Couple things:

No need for console.log (you can comment them out if you like)
Instead of copying every file, can we just copy XML files (or better yet files named themes.xml or styles.xml?) The build breaks if there's any additional files in the values folder.

Thanks @dwieeb , yep makes sense.
I added a check to match against the file name limiting it to themes.xml and styles.xml

Thanks, @Just-Ghali! Looks great. I just merged it in.


Refresh next

Contentless PR simply to refresh the next branch with commits made automatically in main

:tada: This PR is included in version 3.8.2-next.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.8.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use new context api where available (React 16.3)

See here https://github.com/diegohaz/awesome-react-context

Proposed changes to implement this

Keep the React JSX Highcharts API the same
However, drop support for React 15
This would of course, by a breaking change for some users, so will form react-jsx-highcharts 3.0.0

StackBlitz experiments with new context api
React 16.3: here
React 16.2: here - uses create-react-context as a polyfill.

As there are lifecycle changes in React 16.3, it would be easier to drop support for React < 16.3. Otherwise the new lifecycles need to be polyfilled too. https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html
The react-leaflet also has been rewritten with the new lifecycles and new context API without the polyfills:
https://github.com/PaulLeCam/react-leaflet/tree/v2

I hadn't planned on using the new life cycle methods in this version, as the main project I use this for is still using React 16.2, I will consider it though.

Additionally in version 3, I plan to

auto generate IDs for Axis/Series etc, (if not supplied)
Prevent more user friendly errors when a user tries to use a Series type that is not available

For example using an Area Range series without Highcharts More

My main aim with this new version, is to simply the codebase to attract more collaborators, as I am struggling to find the time to support the project.

For those interested, I've just published<EMAIL_ADDRESS>would love for people to help me test. Please post here if you discover any issues.

Should the YAxis, ColumnSeries and ErrorBarSeries work without setting id attribute with the 3.0.0-alpha.5?
I'm getting strange results if I remove them from more than one YAxis.

That's the idea - if no id is present, it should default to a uuid

I think the problem is that every axis gets the same uuid. I put console.log(this.props.id) in Axis and it logs the same string for every axis.

static assignments in the classes are run only once for each class, so every instance of Axis has the same uuid:
  static defaultProps = {
    id: uuid(),
    children: null,
    dynamicAxis: true
  };

One way to solve it would be moving the id to state and have:
  state = {
    id: this.props.id || uuid();
  }

Very strange, I'm not seeing the same issue on my tests, I'll look into it

I made an example of the problem. In the example the second YAxis max={100} overrides first YAxis max={10}.
The problem goes away when id is set to either YAxis.

It’s reproduced in your screenshot. The ”Jane” columns should reach the top, but instead they are on same axis as ”John”. Try adding id’s to YAxis elements, and they will change.

Ah yeah, I see it now, your suggested fix makes sense.
I don't have access to my laptop for the rest of the weekend, would you mind opening a PR against the new-context-api branch? No worries if you're also busy though

As this needs refactoring anyway, the componentWillMount contents could be moved to componentDidMount at the same time to remove the deprecated lifecycle method. That way the React 16.4 would not whine about it.
Kind of busy right now, will try it if I have the time.

Yeah fair point, don't worry about it, I can pick this up on Sunday evening. Cheers though.

PR in #100

Found another bug. In PlotLine:
TypeError: axis.addPlotLine is not a function
example
Also, just noticed that PlotLine and PlotBand have uuid() in defaultProps.

Whoops! Good spot!

Published<EMAIL_ADDRESS>which should fix the above issues. Thanks @anajavi!

What are your plans regarding releasing this? Or do you still have things to do before releasing?

Still work to do I'm afraid, I need to update the highstock and datepickers packages, and update all the tests 😢

As enzyme does not yet understand the new context, it can be made to use react 16.2 with context polyfilling by fixing version in devDependencies:
    "react": "16.2.0",
    "react-dom": "16.2.0",
    "react-test-renderer": "16.2.0",

I checked the tests and there is indeed a lot of work..

I've updated the version first comment to display all things that still need to be done.

Just pushed informative error messages (on development environments), see example below

I think the error messages work now only on ESM-build. The webpack overwrites "process.env.NODE_ENV" by default on UMD-build.
https://webpack.js.org/concepts/mode/

Ah yes, I thought that might happen. But it works with Create React App, which hopefully covers the majority of use cases.

It might be possible to turn it off on webpack.config with something like this:
optimization: {
  nodeEnv: false
}

https://webpack.js.org/configuration/optimization/#optimization-nodeenv
I can try it out later, if it matters.

It came to my mind, that it is possible to use the umd build without any kind of bundler. Then the process would be undefined and cause errors.
So it might be better to leave it as is.

Cool, I've just pushed the final to do list item, so can hopefully publish v3 soon. Just want to get to the bottom of #94 if I can!

I think you already fixed #94. It works for me on 3.0.0-alpha.8, but fails on 2.2.1.
Nice work!

Well it displays a black squares initially, but doesn't render properly until you resize the browser window.
Seems to be something to do with calling chart.reflow() but I can't figure why that's required.

I am not able to reproduce the problem with the latest alpha.
The problem might be in the css width of the containing div. Do you have stackblitz for the problem?

I do, code here, output here.

While debugging #94 I noticed that chart events don't seem to be firing:
        <HighchartsChart
          onRedraw={ () => console.log("redraw") }> // does not fire

Setting them in the chart config works:
        <HighchartsChart
          chart={
            { events: {
              redraw: () => console.log("REDRAW") // fires correctly
            }
            }
          }>

Hi @anajavi those events need to be added to the <Chart /> sub component, which maps to the chart Highcharts configuration group.
<HighchartsChart>
  <Chart onRedraw={() => console.log('Redraw')} />

Thanks, I wasn't thinking straight.
What would you say about the following:

Calling addSeries with redraw = false in Series component: addSeries(opts, false)
Add chart.redraw() in HighchartsChart componentDidUpdate()

HighchartsChart componentDidUpdate() should run after all children are rendered, so it should redraw the chart. I could be wrong of course :)
I think that this could solve #94 and possibly be more performant.

It looks as if the parent's componentDidUpdate is not always called when the Child component is rendered, take this example
I think the application state changes need to happen above (or at) the parent component for cDU to be called

I tried it with chart.redraw and it did not help #94.
I think that the treemap is not getting right data from the chart on first run, if you check the HTML it produces, it shows that colors are set NaN:
<rect x="416.5" y="145.5" width="109" height="117" fill="rgb(NaN,NaN,NaN)" stroke="#e6e6e6" stroke-width="1" class="highcharts-point highcharts-color-0"></rect>

No idea why that happens, maybe a race condition in highcharts.

Thanks a lot for having a look. I think we might just have to launch v3 without it, and patch later on.
I'm feeling excited to launch v3, and you have waited very patiently for it.

I managed to reproduce treemap problem with pure highcharts:
https://jsfiddle.net/brdjj8y7/
It can be fixed in pure highcharts by not setting yAxis in treemap config.

Just published v3, here are the release notes.
Thanks so much @anajavi!

Thanks for the mention :) And congratulations for the release, you did great work!
I'm very happy with the lifecycle rewrites, with luck there isn't more to do for React 17 compatibility.
And now I can start testing with unstable_AsyncMode.
If you have more roadmap in your mind, just add issues or something for them.
One thing I have been thinking is using Flow typings, not terribly important though. These can be transformed to prop-types with babel-plugin-flow-react-proptypes


Demo file crahes

Hi liruoteng!
I'm currently trying to display the .flo files.
To do so i went throught your nice toolikt, got it setup on my desk and unfortunately I get the following error while launching the "python demo.py" :
Traceback (most recent call last):
File "demo.py", line 12, in
flow = kittitool.flow_read(flow_file)
AttributeError: 'module' object has no attribute 'flow_read'
Thanks in advance for your support :D !
Cheers

Hi sorry about the issue.
I forgot to update the demo file when I pushing the changes for flow lib
You may want to use this changeset #d18fb00


Return updated base_circuit from append! & prepend!.

This would make those methods behave like their counterparts in Base. Also, it would allow the use of the @chain macro.

Thank you for your contribution! It looks good to me! I'll merge when the CI/CD passes.

It seems the documentation comments need updating before this can proceed.

It seems the documentation comments need updating before this can proceed.

Alright I'm on it.

Also it seems to me that apply_gate! should return as well. Should I modify it as well?

Alright I'm on it.

Thanks!

Also it seems to me that apply_gate! should return as well. Should I modify it as well?

That would be great!

Thank you very much for the change!


RELEASE: boxSOLID, bveOXD/OXD vaults

Codecov Report

Merging #205 (2f31738) into main (721b62c) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   36.68%   36.86%   +0.17%
==========================================
  Files          19       19
  Lines        1404     1408       +4
==========================================
+ Hits          515      519       +4
  Misses        889      889

Impacted Files
Coverage Δ

config/constants.py
100.00% <100.00%> (ø)


Change the use of the Goerli network to the Sepolia network in the TestHeight test

This PR is fixing the issue #1813, to update the test to use the Sepolia network instead of the deprecated Goerli network.

This PR will be merge to main as a part of  #1861


Release a new version?

The GitHub action for https://github.com/w3c/sensors emitted some errors, probably because the Bikeshed version used does not contain the latest commits. Is there a plan to release a new version?

I cut new versions regularly. Gimme some time. ^_^

And released 2.4.3: https://github.com/tabatkins/bikeshed/issues/1773#issuecomment-861687363


Mix in a DOM Element inside a vnode tree?

Hey.
I'd like to know if it's possible to get a dom element into a vnode, and keep it between patches without side effects to input focus and other things.
I'm part of a larger project that is going to migrate to Snabbdom, but we need to get a migration plan put in place, which involves keeping our existing code that works with DOM elements.
I noticed that the hooks only seem to pass vnodes in the parameters, so I turn to creating an issue to ask for more help. Thanks in advance!

Hello,
I am not completely sure to understand what you want to do but I think there are two approaches : use vnodes all the way and / or use hooks ( or custom modules as you mentionned ).
You can use the tovnode module which will recursively convert DOM elements to vnode.
You can use it like this :
import tovnode from "snabbdom/tovnode";
const elem = document.querySelector("#someId");
const vnodeTree = tovnode(elem);

Then you can use a function to manipulate the vnode as data.
If what you meant is reusing code that uses stuff like addEventListener and native methods then you are looking for is modules. There is an elm on each vnode that you can use as a ref to the current DOM representation of a vnode that you can use inside your module / hook.
You can then create a custom module to pass to the init function to enable code reuse from your existing codebase.
You should probably look for the existing modules that provides access to the DOM APIs and see if you can port some of your code to these modules. If you have an example maybe I can try to help you with a little more details.

Hi.
I realized that "manually" created DOM elements can be tied to a DOM element generated by Snabbdom, and persist between renders, as long as the element remains.
Thanks for the help!


Unattend installation - the working version :-)

Hi, the way it's described here is not 100% correct. Here is a working version.
cmd /c 'C:\Users\student\Downloads\AADConnectAuthAgentSetup.exe REGISTERCONNECTOR="false" /q'
#$cred = Get-Credential
Set-Location "C:\Program Files\Microsoft Azure AD Connect Authentication Agent"
.\RegisterConnectoguyr.ps1 -modulePath "C:\Program Files\Microsoft Azure AD Connect Authentication Agent\Modules" -moduleName "AppProxyPSModule" -Authenticationmode Credentials -Usercredentials $cred -Feature PassthroughAuthentication

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8698cc7c-3b24-db1f-4adf-b60aeb03c97a
Version Independent ID: bf51a630-8219-8e06-e375-6425659e69eb
Content: Azure AD Pass-through Authentication - Quick start
Content Source: articles/active-directory/connect/active-directory-aadconnect-pass-through-authentication-quick-start.md
Service: active-directory
GitHub Login: @swkrish
Microsoft Alias: billmath

@guyhorn1964 Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@swkrish bumping this to get your attention on this issue.

@guyhorn1964 Thank you for catching this.  I have created a work item for this, as it will take me some time to build this environment out again.  I will re-open this and update it once I have more information.  Thank you.
#please-close


[SMALLFIX] Changed $bin variable to ${BIN} on all shell files

This smallfix defines a standard for old $bin variable inside all bin/tachyon* files

Jenkins, test this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8099/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8106/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8108/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8109/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8110/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8112/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8111/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8113/
Test PASSed.

Hi @jsimsa , I opened this smallfix to address the standard BIN variable and also to correct the issue 'bash: line 4: /../libexec/tachyon-config.sh: No such file or directory'

@caadecarvalho thank you for the PR, left one comment

@jsimsa , thanks for the comments, I duplicated because I was receiving the error, after a better understanding, I realize that when under sudo elevation, $BIN variable wasn't set (as it was set on other user session).

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8183/
Test PASSed.

LGTM ... please resolve merge conflicts

thanks, @jsimsa . Conflicts merged.

LGTM ++

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8197/
Test PASSed.