Design docs maintenance

Docs Build status updates of commit 861afc4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/assets/images/11zon_gif.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/3TierImage.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/Adaptive-markdown-Android.jpg
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/Adaptive-markdown-Android.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/Adaptive-markdown-desktop-client.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/Adaptive-markdown-iOS-75.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/Adaptive-markdown-iOS.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/Connector-desktop-html-combined.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/adaptivecard-expand-image.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/adaptivecard-hover-expand-icon.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/adaptivecard.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/card-formatting-xml-android-60.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/card-formatting-xml-desktop-v2.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/card-formatting-xml-mobile-v2.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/carousel.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/connector-android-html-combined.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/connector-android-markdown-combined.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/connector-desktop-markdown-combined.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/connector-iphone-html-combined-80.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/connector-iphone-markdown-combined-80.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/full-width-adaptive-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/hero.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/list.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/masking-information-view.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/o365connector.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/receipt.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/small-width-adaptive-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/thumbnail.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Command-box-rest-state.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Command-box-zoomed-app-state.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Command-box-zoomed-suggestions.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Command-box-zoomed-well.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/CompanyCommunicatorCompose.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Connectors/connector-app-install.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Connectors/connector-app-setup.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Connectors/connector-dialog-sideloaded.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Connectors/connector_dashboard.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Connectors/connector_dialog_uploaded.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Connectors/connector_message.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Connectors/teams-context-menu.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/EndUserHome.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/ExpertViewRequests.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/FAQPlusEndUser.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/IIS.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/ManageTeam.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/MoodleBotInformationFlow.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/MoodleInstructions/MoodleBotInformationFlow.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/MoodleInstructions/moodle-and-teams.png
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Please review and merge when you have time, @surbhigupta12.


Android: Callback isn't called on requestPermission

Library version: 2.1.5
React Native: 0.55.3
Platform: Android
Here is my simple code:
Contacts.checkPermission((err, res) => {
	if (res === 'denied') {
		Contacts.requestPermission((err, res) => {
			console.log('requestPermission result', res);
		});
	}
});

When request permission dialog appears, after I choose Deny or Accept the callback of  requestPermission never called.
Should it work that way or it's a bug?

the permission related methods are only useful on ios. For android use permissionsandroid See https://github.com/rt2zz/react-native-contacts#permissions-methods-optional


Fix - when to use default colorVariant

Accent and background hue was always set to default value.
Solves issue https://github.com/marcosmoura/vue-material/issues/533.

Yes, please accept this! 👍

There is some code related to md-table. Can you remove it?


Change unitTest to use DocEvent's test sftp server

UnitTests needs to changed to use test DocEvent's sftp server. The credentials are in the Confluence credentials page. This needs to be implemented to all the Tasks.

DocEvent revealed to be non compatible for testing platform


Edge Runtime support

🙋♂ Question
I'm trying to use immer in Vercel's Edge Functions (not directly but as a redux-toolkit dependency)
and getting the following error:
./node_modules/immer/dist/immer.esm.js
Dynamic Code Evaluation (e. g. 'eval', 'new Function', 'WebAssembly.compile') not allowed in Middleware middleware

Upon further look, it seems that Immer is using new Function call, which is not allowed in Edge Runtime
Is it possible to make Immer work in this runtime?
Environment

Immer version: 9.0.15

Afaik we don't use new Function, couldn't find it in either source or compiled version, so probably something else is wrong<EMAIL_ADDRESS>

@mweststrate Here is a repo with a reproduction: https://github.com/revmischa/amplify-ssr-next-middleware-repro
Note that this repo is specifically pointing out the lack of Edge Runtime support for AWS Amplify and it's libraries (as filed here https://github.com/aws-amplify/amplify-js/issues/9145), but since immer is a dependencies of one or more libraries Amplify or the aws-sdk depends on, the error reported originally for this issue appears in the details of the README for the reproduction.

A minimum reproduction would just be to include immer in the middleware.js of a Next.js project.

Hey @kevinold, I'm not sure how to address the above issue, as, as you might check the referred immer.esm.js file, there is no eval, dynamic function construction or WebAssembly in there.
The only thing I can think of that errors, is that Immer by default uses Proxies, which are kinda dynamic. That can be disabled however by calling enableES5() at the start of your application and before first Immer usage: https://immerjs.github.io/immer/installation#pick-your-immer-version. Otherwise it would need a deeper investigation why your Edge runtime thinks there is dynamic code evaluation in there.

FWIW, it seems the error can be suppressed with this config: https://nextjs.org/docs/api-reference/edge-runtime#unsupported-apis. If Immer still works after that, it might be a false positive.


How do I resolve an external schema?

I tried looking for examples but I can't seem to figure out how to use the resolver (I am quite new at Rust).
According to this API https://docs.rs/jsonschema/0.17.1/jsonschema/trait.SchemaResolver.html should I do
use jsonschema::[SchemaResolver]?
What next? How is SchemaResolver related to resolve-http or resolve-file?

Meanwhile, I've added a separate section about reference resolving and I hope it should cover everything in detail :) Don't hesitate to ask more questions and I'm sorry for responding so long.
https://docs.rs/jsonschema/0.22.3/jsonschema/#external-references


esp_hal implementeation of embedded_hal I2C transaction adjacent read operations seem to not follow spec

I'm working with PN532 using I2C. I need to read data where the first byte is 0x01, followed by a set of bytes. The crate I'm using wants to skip the 0x01 so it's using:
        let res = self.i2c.transaction(
            I2C_ADDRESS,
            &mut [Operation::Read(&mut first_byte), Operation::Read(buf)],
        );

What I get using this is  [1] then [1, 0, 0, 255, 0, 255], so the 1 is repeating. If I make multiple short reads the 0x01 arrives in every read (even 2 or 3 bytes).
If I issue a single large read I get only the [1, 0, 0, 255, 0, 255], so the '1' doesn't appear twice.
From that I conclude that either the read operation is sent twice on the i2c (the device notices that and responds with the full transaction every time until the complete data is read), or that there is some buffering inside esp_hal.
embedded-hal states that 'Data from adjacent operations of the same type are sent after each other without an SP or SR.', which I understand means that the device should not see two read operations but rather a single one. My understanding is that the crate I'm using works that way on other devices (not esp32), so it's not a PN532 behavior.
This is the complete info regarding embedded_hal reqirements from their source:
    /// Execute the provided operations on the I2C bus.
    ///
    /// Transaction contract:
    /// - Before executing the first operation an ST is sent automatically. This is followed by SAD+R/W as appropriate.
    /// - Data from adjacent operations of the same type are sent after each other without an SP or SR.    <----------
    /// - Between adjacent operations of a different type an SR and SAD+R/W is sent.
    /// - After executing the last operation an SP is sent automatically.
    /// - If the last operation is a `Read` the master does not send an acknowledge for the last byte.
    ///
    /// - `ST` = start condition
    /// - `SAD+R/W` = slave address followed by bit 1 to indicate reading or 0 to indicate writing
    /// - `SR` = repeated start condition
    /// - `SP` = stop condition
    fn transaction(
        &mut self,
        address: A,
        operations: &mut [Operation<'_>],
    ) -> Result<(), Self::Error>;

I see whats going on and should have a PR in a few days.

@yanshay can you give PR #2028 a try?


Preparing metadata (setup.py) ... error  for install pyboolector

[fso💀fso ibex]💯🥊sudo pip install pyboolector
[sudo] password for fso:
Collecting pyboolector
Using cached PyBoolector-<IP_ADDRESS>30110.4.tar.gz (21 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [7 lines of output]
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "/tmp/pip-install-wapqpg76/pyboolector_2df15e09845a44aea01e63ea84480e9b/setup.py", line 14, in
with open(cmakelists_txt, "r") as f:
^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-install-wapqpg76/CMakeLists.txt'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Hmm, that's odd! I'm not sure it's related to Ibex, though (I just checked, and "boolector" doesn't appear in our repo at all!)
If you're still seeing problems with thin, maybe the raise an issue there?

in vendor/google_riscv-dv/requirements.txt ,  there have a pyvcs, this package need boolector.


implement file-upload with NetflixOSS Zuul for images and other assets for prediction/classification

using alternate solution


Cody Web: Fix cody web file/symbol mention search

Fixes CODY-3375
Fixes CODY-3376
This PR makes symbol and file mention search respect the initial context repository, so we will look for files and symbols only within this repository. You can still select files from different repositories by selecting the "Files" category directly.
Test plan

Check that you can select files in the cody web demo by typing @<search term> string and you see files only within sourcegraph/cody repository (which is set as a default context for the cody web demo)

Changelog

yeahhhhhhhh vova!!!


This change fixes a silly tiny error in the syntax.

Hi, first time user of your library. I'm enjoying it. Just noticed there was a small error in syntax so I thought I'd introduce a quick fix.
Thank you,
Eugene

@abdulkadirgenc

Fixed. Thank you


Stripped the query strings from pathname before matching against path

I'm new to public PR, please let me know if I've missed anything. Apologies if I'm breaking any convention (unknowingly).
Ran into an issue where the server side route match was not working correctly when the url contained query strings.
path: /base/about
does not match against url /base/about?query=param
but it does match with /base/about/?query=param
Also (not that this matters) path /base/home/:id
when matched against /base/home/7?query=param
gives params { "id" : ""7?query=param" }
Changes proposed:

Do not consider query strings when matching pathname in matchPath. This will fix both issues mentioned above.
Added two tests to check with query params, both with and without :param

This is intentional. You should be passing only a string to this function. It's intended for location objects coming from history, which already have the search and path separated out. You should do this on your own before passing to this function.

Got it, thanks.


#351 sdkv2 liquidity pools

Working example(hopefully 😅) of the liquidity pools list page implemented using sdk v2.

Is it possible to keep pagination like with the previous implementation?

Probably this would be a good link 'Learn' button https://docs.zeitgeist.pm/docs/learn/liquidity

@saboonikhil on hold since we need the total liquidity for all pools gql schema.

Moved to #396


It's not completely clear how to embed RustPython

It's not sufficiently documented how to embed RustPython in an external project using crates.io crates, for example
rustpython-vm = { version = "0.1.2" }

in Cargo.toml fails to compile the hello_embed example
error[E0433]: failed to resolve: could not find `Interpreter` in `vm`
 --> src/main.rs:4:9
  |
4 |     vm::Interpreter::default().enter(|vm| {
  |         ^^^^^^^^^^^ could not find `Interpreter` in `vm`

error[E0433]: failed to resolve: could not find `compile` in `vm`
  --> src/main.rs:10:21
   |
10 |                 vm::compile::Mode::Exec,
   |                     ^^^^^^^ could not find `compile` in `vm`

error: aborting due to 2 previous errors

Oh, yeah, we haven't pushed a new release to crates.io in a while, I think we're going to publish a new release around the end of the month. You can use the master branch for now, rustpython-vm = { git = "https://github.com/RustPython/RustPython" }

Hey, is there any update on this issue? Looks like the push never happened. Super interested in using rust python :)

Can't get a master branch hello world build to work due to syntax error in some builtin Python module.
Is there any way we can get a useable version up on Crates.io?
Super amazingly interested in Rustpython! :D


drivers: usb: Add RP2040 USB device support.

Initial work on the USB device driver for RaspberryPi Pico SoC.
I'm quite certain there are some gaps and missing bits, and some that just need cleaning up, perhaps with feedback from others that know the stack better than I.

Please also add USB to the table of supported features in the board docs

Please also add USB to the table of supported features in the board docs

Added.

Summary for the dev-review:

raspberry-pi-pico (abbreviation rpi-pico) is the name of the board "Raspberry Pi Pico is a tiny, fast, and versatile board built using RP2040"
board name in Zephyr OS is rpi_pico
SoC name is RP2040
all the drivers in the tree for RP2040 SoC have rpi_pico postfix
comment from @yonsch "The "pico" naming was chosen because the SDK is named "pico-sdk", so we assumed pico is the name of the series, not just the board." (See discussion in the review drivers/usb/device/usb_dc_rpi_pico.c)

rpi_pico postfix can be confusing if someone is explicitly looking for the SoC name. Should we keep naming scheme or rename?

@jfischer-no nudge? Anything else you'd like to see here?

@jfischer-no nudge? Anything else you'd like to see here?

Sorry, too busy. I will try to finish my review today or tomorrow.

@petejohanson today last chance to get it in v3.1.0 (I do not want to push you, just as a hint :smile:)

Actually, missed the other comments. Working on those now.

@jfischer-no Ok, now all the comments have actually been resolved. Thanks again for the review and the nudge.

(my last few pushes were just to make the compliance check happy, FYI)


Unable to log into azure using elevated powershell: Decryption failed: [WinError -2146893813] Key not valid for use in specified state

Describe the bug
Seeing an  error while running az login.
Error: Decryption failed: [WinError -2146893813] Key not valid for use in specified state.. App developer may consider this guidance: https://github.com/AzureAD/microsoft-authentication-extensions-for-python/wiki/PersistenceDecryptionError
Related command
Az login
Errors
Decryption failed: [WinError -2146893813] Key not valid for use in specified state.. App developer may consider this guidance: https://github.com/AzureAD/microsoft-authentication-extensions-for-python/wiki/PersistenceDecryptionError
Issue script & Debug output
cli.azure.cli.core.azclierror: Decryption failed: [WinError -2146893813] Key not valid for use in specified state.. App developer may consider this guidance: https://github.com/AzureAD/microsoft-authentication-extensions-for-python/wiki/PersistenceDecryptionError
az_command_data_logger: Decryption failed: [WinError -2146893813] Key not valid for use in specified state.. App developer may consider this guidance: https://github.com/AzureAD/microsoft-authentication-extensions-for-python/wiki/PersistenceDecryptionError
Expected behavior
Need to see all the available subscriptions.
Environment Summary
azure-cli                         2.51.0
core                              2.51.0
telemetry                          1.1.0
Dependencies:
msal                            1.24.0b1
azure-mgmt-resource             23.1.0b2
Additional context
No response

Thank you for opening this issue, we will look into it.

Deleted the .azure folder and re-installed the Azure cli but still seeing the same error.

The information provided by at https://github.com/Azure/azure-cli/issues/27158#issuecomment-1675275349 is inaccurate yet.
Please try not to run Azure CLI as admin. If the issue persists, you may try to disable token cache. See https://github.com/Azure/azure-cli/issues/20231#issuecomment-1007176901


Fixed a warning.

Added a header file 'time.h' for time() sys call.

Thanks, I merged a different PR.


chore(github): imporved last PR

Having it this way makes it easier to read top->bottom and expand later
If you like the old one better then just clone the PR 😄

:+1:


Fix typo

Codecov Report

Merging #245 (7130e16) into master (088a659) will increase coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #245      +/-   ##
============================================
+ Coverage     35.67%   35.90%   +0.23%
- Complexity      657      662       +5
============================================
  Files           220      220
  Lines         11229    11229
  Branches        275      275
============================================
+ Hits           4006     4032      +26
+ Misses         6979     6949      -30
- Partials        244      248       +4

Flag
Coverage Δ

java
62.31% <ø> (+0.67%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...cketmq/client/java/impl/producer/ProducerImpl.java
32.56% <0.00%> (+1.91%)
:arrow_up:

...g/apache/rocketmq/client/java/impl/ClientImpl.java
55.30% <0.00%> (+6.75%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add a full screen dialog component

This is almost done internaly but we still need to figure out the Dialog size in a phone form factor.
We can have a sneak peek in #147

Blocked by #215


accountDetails: Fix layout regression.

We are using ImageBackground, which uses styles such as position: absolute. Because it is capable of displaying text (/componenets)
over it. So styles such as alignItems: center, flex: 1 were
resulting items to be present at vertically center of screen instead
of space below image.
By removing this styles and only keeping justifyContent: center,
works as expected.
Fix: #3228

Thanks @jainkuniya ! Merged.


Music menu crashes the game when opened

Also, lots of things changed since 2 days ago! Great work!

Fixed with latest nightly


Build scans are not supported for this build due to a build plugin composite substitution.

Build scans are not supported for this build due to a build plugin composite substitution.
This is troublesome for me because I have a couple plugins in buildSrc that depend on a project in my build that will be moving directories and now my classpath is having issues.
Expected Behavior
I have build scans published after a build with composite build substitutions.
Current Behavior
Build scans are disabled because they are not supported currently.

This is becoming more of an issue now that build scans are the only supported method to test task configuration avoidance. Gradle 5.0 docs said to either use build scan or run gradle -Dorg.gradle.internal.tasks.stats help when testing changes related to task configuration avoidance. The command still works as of Gradle 5.4 but it's clear it shouldn't be relied upon and could be removed at any time.
Build scans would be very useful in general anyway but this is a specific case that needs a supported solution.

I think this can be closed now - from Build Scan plugin release history:

2.3 - 3rd May 2019
Added support for plugin composite builds
Added support for continuous builds
Added support for capturing the details of annotation processors used during Java compilation

Thanks for following up @tazzledazzle


Update README.md to reflect performance changes in React 16

As @trueadm wrote in this issue on React documentation, the future performance optimizations mentioned in readme file are already there. 🎉

Functional components in React 16 don't go through the same code path as class components, unlike in previous version where they were converted to classes and would have the same code path. Class components have additional checks required and overhead in creating the instances that simple functions don't have.

Thanks!


How to use the code for log scale?

Please explain the same with steps

Hi, sumenmlj. The code does not support log-log or semilog diagrams. You must to convert the linear coordinates that you will get from the code to log scale by yourself.


My movies aren't being improved properly

Describe the bug
I passed this over my hentai and it didn't made me nut faster, what the fuck!
To Reproduce
Steps to reproduce the behavior:

Get your hentai
Pass this boi over it
Watch it and see what you last
No nut in wanted time range, expected: < 20s got: > 20s

Expected behavior
A big nut in less than the previous best time
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS] Arch Linux with some fancy tiling WM
Browser [e.g. chrome, safari] chrome
Version [e.g. 22] the one and only latest

Additional context
inconceivable!

Troll issue.

how you dare classify the existance of this issue as "troll" :3 uwu


Sorbet Flow Sensitivity bug with retry in exception handler

Input
→ View on sorbet.run
def some_method
  retried = false

  begin
    risky_method_that_errors
  rescue => e
    if retried
      raise e
    else
      retried = true
      retry
    end
  end
end

Observed output
editor.rb:13: This code is unreachable https://srb.help/7006
    13 |      raise e
              ^^^^^^^
Errors: 1

Expected behavior
This code is reachable, given that the rescue block mutates the value of retried before calling retry.

In this case, it's a little tricky to tell that retried could be true at the time it's declared. If you add a type annotation on the definition, the problem will go away:
→ View on sorbet.run
# typed: true
def some_method
  retried = T.let(false, T::Boolean)

  begin
    risky_method_that_errors
  rescue => e
    if retried
      raise e
    else
      retried = true
      retry
    end
  end
end

This is a bug, though I think this class of bugs is super hard to fix.
It comes from the fact that for better UX we decided that despite every exception handling could be a loop we treat it half way between them: we don't impose requirements of loops on them.
The error should have been
retried = true
Similar to one where you change type of variable in loop iteration


Icon request: Versio

URL of the site or app (required): https://www.versio.nl/
Logo resources for the icon (optional, but recommended): I was unable to find an SVG icon for this one, unfortunately. There's a PNG icon at the top left of the home page though.

Here you go!
For current Aegis (recommended for now):
https://github.com/aegis-icons/aegis-icons/blob/master/PNG/Versio.png
For Aegis beta version:
https://github.com/aegis-icons/aegis-icons/blob/master/SVG/Versio.svg


Allow overriding workflow labels in 'argo submit'

This PR allows overriding workflow labels in 'argo submit', the same way they can be overridden in 'kubectl run'

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Review feedback applied.

@jessesuen I confirmed it works in my env and the code looks good.


WASM parsing and more

I was playing around with the ballercat/wasm-loader, but I believe you want to add first-class support in Webpack?
I would like to share a bit of my work done so far. We have a first implementation of the wasm binary DCE here https://github.com/ballercat/wasm-loader/pull/7 (you might have an idea to collect the usages btw :) ) and I was thinking about a new API here https://github.com/ballercat/wasm-loader/issues/8, according to the discussion in https://github.com/webpack/webpack/issues/6433 that might not be the best approach.
I came across this:
https://github.com/webpack/webpack/blob/221d2cee4336a3873fc2c9972b7eb25a0dce028b/lib/WebAssemblyParser.js#L21-L22
I can suggest you to use the same tools I used, see example in wasm-dce, basically Babel for WebAssembly.
The tools are backend by https://github.com/xtuc/js-webassembly-interpreter, which can be used for many other things!
I already shared some of my ideas with @TheLarkInn :+1:

I tried to use wasm-dce, but it seem to have problems with imports
parseWat failed:
out.wast:2:40: error: unexpected token 0, expected ).
  (import "./module" "getNumber" (func 0 (result i32)))
                                       ^

Error: parseWat failed:
out.wast:2:40: error: unexpected token 0, expected ).
  (import "./module" "getNumber" (func 0 (result i32)))
                                       ^

    at Object.parseWat (D:\Repos\webpack\node_modules\wasm-dce\src\libwabt.js:19:13536)
    at module.exports (D:\Repos\webpack\node_modules\wasm-dce\src\index.js:59:21)

Ah sorry about that, could you please share the binary? Is it the one used in the tests here?


"Non-whitespace before first tag." error

did $ svgo logo.svg
got Non-whitespace before first tag
Did not find any info anywhere about this error msg. Can somebody give me a clue?
Thanks.

Same here on SVG's which are run through svgo beforehand.
I double checked to have BOM removed and I check my files with an xml validator.

Heh, it seems i have anything else.
svg is valid. UTF-8 without bom encoding. No any other svg loaders for fonts. But the error exists.

In my case I realized, that create-react-app have already good svg loader inside: svgr
And it's working out of the box:
import { ReactComponent as Logo } from './logo.svg';
// or
import logoPath from './logo.svg';


Fix #596: Allow file/folder download

Fixed issue mozilla#596
Here's a demo of a file download then a folder download:

I made it so that my modifications doesn't affect Thimble (Since it uses the archive function to download the whole project).
PS: Can I add CMD_FILE_DOWNLOAD to the other locales file (Thus the title [WIP] haha)? Not too sure what are your requirements when working with locales :)

Let me know when you want this reviewed.  One thing I know I'm going to tell you is that you need to rebase your code and update your master branch, because it looks like you're behind by quite a bit.

Thanks @humphd
I made the changes and pushed them (Code is ready for review 👍 ).
As for locales, I've only added CMD_FILE_DOWNLOAD to en-US. Don't I need to add CMD_FILE_DOWNLOAD to the other files? Or is that something that needs to be added in the future?
Thanks!

I hate to fix the MIME-TYPE and deal with the locales 👍

hi @humphd,
I made the changed as per your request 👍

Testing

Ok, this works great for both Chrome & Firefox when I run it from the /dist folder on localhost like - http://localhost:8000/dist/hosted.html but not in /src - is that expected behaviour?

What does it do in src/?  Is it just missing strings?  Did you run npm run localize?

npm run localize made it work in src also - didn't realize that was the missing step!

We have new code on master that does this automatically when you run the server, but I think this branch is behind and doesn't have it.

@humphd is correct. This branch doesn't have the new changes. Should I update it?

You can rebase, sure.

Hi @humphd, I just did a rebase on my branch.

@simon66 any updates on this?

Oh sorry, I didn't see the notification for this item. Going to make the changes and push them.

@simon66 how is this coming?  Can we finish it this week please?

Hi @humphd, just pushed the new changes.

OK, great.  We've just frozen the code so we can launch next week.  After the freeze, I'll come back to this.

I'm finishing this in https://github.com/mozilla/brackets/pull/780


Don't create a 'deny' cookie if user dismisses

Currently the script will create a cookie with value deny if the user dismisses cookies. I want to change this so no cookie is created at all in this case.

The only way I could think of is of you have a mysql db with all the ip's of the machines that choose refuse and every time someone visits you page you check those against the visitor's ip. if it is in the db with refuse checked than you know their choice. That would require no cookies stored on the visitor's machine. I know of no other way in which you could check someones choice regarding cookies, other than the one setting a cookie with refuse. The mysql solutions is ludicrous of course ... and could fall under the category of collecting personal data. Also you could write a disclaimer for your visitors warning them that the "refuse" choice will set a refuse cookie on their machine, and if they want no cookies should not choose anything, that resulting in the banner brought up every time they visit the site.  Or you could re-write the code to not set a cookie when refuse is selected, that also resulting in the banner being brought up every visit.  The part that should be re written is at scr/cookieconsent.js line 48. If var value == "refuse" set var cookie=""  that should work theoretically.

Currently the script will create a cookie with value deny if the user dismisses cookies. I want to change this so no cookie is created at all in this case.

You would need to create custom callbacks to do this. EU laws allow for necessary cookies without any consent, even a cookie to track that cookies have been denied is legal.


Adhere to Airbnb Style Guide

https://github.com/airbnb/javascript
I think this is our best option to have consistent code throughout the class. I did what I can but you'll notice there are more linting errors that I don't know how to fix/too afraid to mess with your guys' work.

I see those errors to but I rarely use linters so I do not know why they appear and how to fix them.

I can go through it all when I refactor my code

Alright, so I'm looking at my parts of the code and it is triggering eslint because I used bitwise operations. Removing the bitwise would require doing a complete rewrite of those sections of code despite there being nothing inherently wrong with using bitwise operations aside from them maybe getting misinterpreted as a typo for && or ||.
Can I just add an exception to the eslintrc file to allow bitwise?

Yeah sure! What’s The docs say The reasoning is about using bitwise
Gridonyx<EMAIL_ADDRESS>wrote:
“Alright, so I'm looking at my parts of the code and it is triggering eslint because I used bitwise operations. Removing the bitwise would require doing a complete rewrite of those sections of code despite there being nothing inherently wrong with using bitwise operations aside from them maybe getting misinterpreted as a typo for && or ||.
Can I just add an exception to the eslintrc file to allow bitwise?”
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@superhackerboy from eslint docs:
disallow bitwise operators (no-bitwise)

The use of bitwise operators in JavaScript is very rare and often & or | is simply a mistyped && or ||, which will lead to unexpected behavior.```

Yeah I guess I don't care lmao. Add it to the exclusion


HNC: Demo doesn't work as expected

In HNC demo, under "Hierarchical network policy" part, In the 6th block where it says Now we’ll see that we can no longer access service-2 from client a client in service-1, it appears that you can still access service-2 from a client in client-1 after following all the pre-setups. As a result, the e2e test also fails on this part.

Terminal output:
acme-org    deny-from-other-namespaces   <none>         7m26s
service-1   deny-from-other-namespaces   <none>         7m26s
service-2   deny-from-other-namespaces   <none>         7m26s
team-a      deny-from-other-namespaces   <none>         7m26s
team-b      deny-from-other-namespaces   <none>         7m26s
$ kubectl run client -n service-1 -it --image=alpine --restart=Never  --rm -- sh
If you don't see a command prompt, try pressing enter.
/ # wget -qO- --timeout 2 http://s2.service-2
<!DOCTYPE html>

<title>Welcome to nginx!</title>

Welcome to nginx!

If you see this page, the nginx web server is successfully installed and
working. Further configuration is required.

For online documentation and support please refer to
nginx.org.

Commercial support is available at
nginx.com.

Thank you for using nginx.

/cc @yiqigao217
/cc @adrianludwin

Hmm did you enable network policy in your cluster? Or I remember there was no way to enable networkPolicy on Kind? I just tried it late last week on a GKE cluster with networkPolicy enabled and it worked.

Sry false alarm, the test failed because network policy was not enabled. Made changes to reminder user who meet the same issue again.


Scan CI fixes

This PR cleans a few things I noticed while fixing #294:

Use ggshield secret scan in our local action.
Improve wording of CI messages, in particular do not talk about a --ci option: it does not exist anymore.

Codecov Report

Merging #295 (fef060b) into main (b7b9a8e) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   94.65%   94.55%   -0.11%
==========================================
  Files          75       75
  Lines        2920     2920
==========================================
- Hits         2764     2761       -3
- Misses        156      159       +3

Flag
Coverage Δ

unittests
94.55% <ø> (-0.11%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ggshield/cmd/secret/scan/ci.py
100.00% <ø> (ø)

ggshield/core/file_utils.py
88.67% <0.00%> (-5.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b9a8e...fef060b. Read the comment docs.


Sorting by Priority

Wonder if anyone can help as i've been trying with no luck to get this running.
I'm looking at trying to sort by priority using the PriorityIndicatorCell on the left side columns and by its date based on the priority.
Having the oldest Priorty1 at the top of the page and the next Priority 1 underneath it, working my way down Priority 2 then to Priority 3.
Any help would be appreciated.
cheers imcro

I should have added this to give you guy's an idea where I'm at, plus what I'm trying to do.
I can get the priority's  to come up in order just not by due date.
That's where the issues is.


incorrect POD COUNT

There was fixed #49  by #60 .  But it shows wrong number of pods, bigger than limit number. Because it shows all kind of pods : completed, Error  etc.
But it should show the same number as command kubectl describe node , "Non-terminated Pods"   field.  This field show if it possible to schedule pod on this node or not.

Fixed by #70, thanks @cloud-66!


Linear gradients begin/end points not correctly set

Linear gradients are not displayed when exporting to PNG because begin/end point coordinates are not set when creating the gradient. So instead of something like this:
<linearGradient id="svg_87" x1="0" y1="0" x2="1" y2="0">
   ...
</linearGradient>

the SVG source will only include this:
<linearGradient id="svg_87">
   ...
</linearGradient>

which when rendered as png does not display the gradient at all. The editor color fill menu, linear tab, does include the begin/end point parameters that need to be defined, but they don't make it into the svg source. See below:

If I set the coordinates by hand in the source code and then export the SVG to PNG, the gradient displays correctly.

Acknowledged. Fix should be easy but I won't have time to fix soon.

This is fixed now.

Tops! Thank you very much!


Level Dependancy

Is it possible to not use level dependency?
I keep trying to install your module, and it fails on leveldown which is a dependency on level.
It wants to do something with python for some reason and seems to fail on a windows machine.

Level is what is used to store the cached data, so its a requirement.
Nothing actually requires python, however leveldown and a few others have native C++ bindings which are built with node-gyp which uses python.

I've just installed Python, and now it's asking to install .NET 2.0 SDK and Visual Studio 2005
Is there no alternative, as every time I install Visual Studio, I end up having to format 2 weeks later to remove all the crap that it installs as its impossible to remove it all again?

Ah Windows. That explains it.  Well level, leveldown, and levelup uses native C++ bindings that have to be compiled.
I do not use windows. If you'd like to figure out how to make it work and submit a pull request that supports windows and doesn't break anything else, I'd be ok with merging that.
I have thought about allowing someone to pass an object that had certain methods to allow custom data stores, but I have not had the cycles or interest from other people using the project to warrant the work at the moment.

For what it is worth, level works on windows, you just have to have the proper developer tools installed to be able to compile the dependencies.

So far I've downloaded the repo, and replaced level with memdown and changed the import to require('memdown');
No actual runtime errors, but always comes back with undefined data at the moment.. So I am just having a look at that.
memdown is meant to be a direct drop in for leveldown, I am not sure if its a direct drop in for level. It's what I am investigating now.
I wouldn't even mind if I could find something that uses a inefficient require('fs'), as long as it does not require all this extra baggage like python+visual studio.

FWIW -- https://github.com/TooTallNate/node-gyp#installation -- Unfortunately certain developer tools are required to work with node.js, and there are thousands more modules that require node-gyp which will require compilation tools.

Well I will need to find the ones that do not require it. This is the first one I've encountered so far.

I'm not sure why, but
github.events.getFromUserOrg({ 'user': user, 'org': org }, onGetFromUserOrg);

doesn't work, always comes back with ("Error: Not Found", undefined), but
github.events._getFromUserOrg({ 'user': user, 'org': org }, onGetFromUserOrg);

does work.
I think the problem is its not a dropin. The get code always returns an error.
self.cachedb.get(cache_id + ':tag', {valueEncoding: 'utf8'}, function(err, tag) {
console.log(err, tag); // [Error: NotFound] undefined which then quits out.

I am guessing there is extra stuff I need to pass to memdown to start it caching in the first place.. But I have not learnt what that is yet.

If you are replacing cachedb object, you need a get and put method, that is about it. Get takes a single key argument, put takes a keyname and the data to associate with it. data going in should be serialized json, data coming out of get should be automatically deserialized json.

I might see about decoupling the database completely and having it as a pass in object via the setup object. That way I can do a man in the middle and see what the heck is going on.
Thank you for the signature for the get and put, I will keep you up to date with what I find going on, hopefully I will get something working nicely.

I found the problem. Memdown's error did not contain err.status = '404'; Something so simple but completely passed me.
So I have jerry rigged that in for now, see if there is a more universal way to try and figure this out.
Now to figure out how the actual storing is working as it is returning a Buffer. :+1:

This turned into an interesting thread. Keep posting your progress!  I have in the end completely ripped out the 'default' leveldb variable and relying solely on your this.config.cachedb.
This is obviously nowhere near a 'FULL' implementation. It barely even be classed as a 'hack', but this is my simple alternative for now as it's close to midnight and I've been coding one thing or another since 7:45am.
function MyDB() {
	this._store = {};
}
MyDB.prototype.db = ''; // Required to make github-cache not fail over to using the built-in.
MyDB.prototype.put = function (key, value, options, callback) {
	this._store[key] = value;
	setImmediate(callback, null);
};
MyDB.prototype.get = function (key, options, callback) {
	if ( key in this._store ) {
		var value = this._store[key];
		setImmediate(callback, null, value);
	} else {
		setImmediate(callback, {'status': '404'});
	}
};
MyDB.prototype.batch = function (array, callback) {
	for ( var i = 0, length = array.length; i < length; i++ ) {
		this._store[array[i].key] = array[i].value;
	}
	setImmediate(callback);
};

I've replaced leveldb with redis in my branch at http://github.com/area/node-github-cache
I note test 12 doesn't pass, but nor does it in this version, so I've left it for now.

Very nice.. I am swamped under at work in at the moment, but once I can breathe again, I will definitely have a look.

I think that someone needs to create a libkv for node.js that supports consul, redis, level, etc, zookeeper, etc ... then we can abstract this away.


feat: SsrMode::PartiallyBlocked

Using create_blocking_resource with SsrMode::OutOfOrder waits for the blocked fragments to resolve before returning any response, which means that they can affect headers and the <head>. However, it still uses JavaScript to replace the fallbacks with the rendered children in the browser.
It can be desirable in some circumstances — for example, if there's a good chance JavaScript is not available — to replace the fallback with the children on the server instead. This makes for a marginally slower initial response, as additional string-replacement work has to be done on the server at an O(n) cost (n = size of the first HTML chunk). However, it potentially makes for a better experience if JS is not available at all.

Also closes #1029.


release for android arm64

will there be a release for android arm64?
I'm using kivy + buildozer. And in the code there is a duckduckgo_search library that interacts with curl_cffi. It is very important for me to find a solution to compile for my OS.

Sorry. I just saw that the update came out and everything worked. The topic can be closed

What update?

@yifeikong I thought duckduckgo_search was corrected. But no, everything is the same. When launching the apk, after compiling in buiildozer. The architecture still cannot work properly.
.buildozer/android/platform/build-arm64-v8a/build/python-installs/AIGodOSINT/arm64-v8a/curl_cffi/__init__.py", line 15, in <module>
02-17 10:32:49.397  2559  2640 I python  :  ImportError: dlopen failed: "/data/data/codeberg.org.aigodosint/files/app/_python_bundle/site-packages/curl_cffi/_wrapper.so" is for EM_X86_64 (62) instead of EM_AARCH64 (183)

@yifeikong It's not easy, but I hope you can do it.


fix: remove unreachable condition

useless condition
    if (**!(accept.includes('text/html')** || accept.includes('*/*'))) {
      debug(`not redirecting ${ctx.url} (not accepting html)`)
      return next()
    }

    const ext = path.extname(ctx.path)
    if (ext && **!accept.includes('text/html')**) {
      debug(`not redirecting ${ctx.url} (has file extension)`)
      return next()
    }

It’s not useless. It can happen when accept is /

😌


split exported functions from implementation

[x] depends on https://github.com/moby/term/pull/37
[x] depends on https://github.com/moby/term/pull/43

Put the exported functions in a non-platform-specific file, and
un-export the implementations. This allows us to maintain the
GoDoc for exported functions in a single place (not having to
repeat those), and make sure that the signatures between platforms
are identical (unless not possible).

This one's best reviewed commit-by-commit (as some files are renamed / moved)

@rumpl doh! had one minor change stashed, and forgot to push 🙈 just did; PTAL; https://github.com/moby/term/compare/a97a5788274f401b12126432d8c4c4ee3b677a0c..bb04910d7c2ef73ab41c05aa452f86b6ac1ae7b4

CI is still happy; bringing this one in 👍


Added SpeechInputHandler

SpeechInputHandler is to be used with the SpeechInputSource. It allows the mapping of keywords to script methods using the Unity editor inspector.
This PR also includes a custom editor for the SpeechInputHandler that shows the registered keywords on the SpeechInputSources as a dropdown. This way, the user doesn't have to type the keywords again and prevents typing errors.

Hi @aalmada, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

@maxouellet This version uses a UnityEvent to reference the method to be called. I don't like because it forces the user to specify what game object the script is on. What do you think?

@aalmada I don't like it, but it's the beginner-friendly way to do it in Unity, so I don't have a problem with it as long as usage of this SpeecInputHandler is optional. I think it's a good way to make things accessible to beginners, without forcing more advanced programmers into a pattern that breaks encapsulation and good coding practices

I'm just worried about all the different places we can assign keywords.
Ideally this should be centralized on the keyword manager.

@HodgsonSDAS In your own words, "SpeechInputHandler only give devs the ability to assign events to keywords created on SpeechInputSource".
The SpeechInputSource/SpeechInputHandler pair can reproduce the KeywordManager behavior but I agree that it's in bit more complex form. I would also agree that the KeywordManager is enough for most applications. I just believe that there should also exist InputManager-based speech handling for more complex applications and that's implemented by SpeechInputSource. The use of the SpeechInputHandler is optional and targets users that like visual development.
IMHO KeywordManager, SpeechInputSource and SpeechInputHandler can co-exist as long as their use cases are well documented.
@maxouellet I also hate the use o UnityEvent but, to my best knowledge, it's the only out-of-the-box solution. The implementation of an alternative will take some time. It requires the implementation of custom serialization and more custom editors.
What about the SpeechInputHandler itself and the keywords dropdown?

The dropdown now doesn't show the keywords already assigned in this handler:

Unfortunately, duplicates are still possible. For example, when a new line is added. A warning is shown now:

I don't think that it's bad for the keyword to be assigned more than once, but bad it could assigned in multiple locations inside the editor. Sorry if that sounds confusing.

@HodgsonSDAS It's expected to exist multiple handlers in the scene hierarchy and these can have the same keywords assigned. This is because of the bubbling-like InputManager message routing.
The SpeechInputHandler maps the keywords to the UnityEvent using a dictionary so it doesn't support keyword duplicates. UnityEvent allows the assignment of multiple methods to the same keyword (notice the plus and minus signs in the tab).

Ahh okay, then I suppose that is fine then. I didn't realize that is the intended behavior.

@aalmada You've got some conflicts.

@aalmada You've got some conflicts.


Compile error with meson

Error:
FAILED: web  c++  -o web<EMAIL_ADDRESS>-Wl,--as-needed -Wl,--no-undefined -Wl,--start-group -ldrogon -ltrantor /usr/lib/x86_64-linux-gnu/libssl.so /usr/lib/x86_64-linux-gnu/libcrypto.so -Wl,--end-group -pthread /usr/bin/ld: /usr/local/lib/libdrogon.a(SharedLibManager.cc.o): undefined reference to symbol 'dlclose@@GLIBC_2.2.5' /usr/bin/ld: /lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed.
Build code:
`project(
'fsmtp_web',
'cpp',
default_options: [
'cpp_std=c++17'
]
)
lib_ssl = dependency('openssl')
lib_threads = dependency('threads')
comp_cc = meson.get_compiler('cpp')
lib_drogon = comp_cc.find_library('drogon', required: true)
lib_trantor = comp_cc.find_library('trantor', required: true)
sources = [
'main.cc'
]
executable(
'web',
sources,
dependencies: [
lib_drogon,
lib_trantor,
lib_ssl,
lib_threads
]
)`

@mensinda Please help resolve this issue. Thank you.

First of all, what meson version are you using, operating system, etc.?
You should be able to fix the error by adding cc.find_library('dl') to your dependencies. Also, using find_library is only recommended when there is no other viable way to get a dependency. You should use dependency('Drogon') instead (which also automatically takes care of include paths and trantor)

@mensinda Thanks so much.

Thank you ! I'll try. Im using ubuntu 20, with the latest kernel as I'm aware


Header-decor with Expandable RecyclerView

Hi Eduardo! I tried use Header-decor view with Expandable RecyclerView library (by Ryan Brooks https://github.com/rbro112/expandable-recycler-view ) to create Expandable items with sticky headers but, I have a problem, can you write any commentary to me. When I StickerheaderDecoration send request to adapter by method getHeaderId I can retrun right header position but when expandable items expended then header will be draw header on incorrect position. Can you any suggestion to solve this?

I haven't really used the header library with expandable items. The cause might be the change of item numbers in the list after an item is expanded since it seems like the library you're using adds extra items to the adapter, so calling clearHeaderCache on the decoration might force the headers to be drawn in the correct place. If you could create a sample project that shows this behaviour I could look more into it on my free time. Thanks!

@boyfox if you search both functionalities, you might want to check my implementation on my page. Feel free to ask there.

Thanks @davideas, I seen your project "FlexibleAdapter", I will be try it today.


fix build android aar on Linux because of case sensitive

"#include <android/Thermal.h>" will cause some errors when building aar on Linux,
the corrret answer is "#include <android/thermal.h>"

Sorry, maybe I click update branch button in a mistake, neecd to be merged manully.


Add context in gatsby-node.js

Hello,
I used your plugin from gatsby to retrieve photos from Cloudinary into my personal Web.
I have been able to do that with the photos, but I haven't been able to retrieve the metadata title (caption)  for each photo.
I forked your code and make some changes in gatsby-node.js:
I have nested within cloudinary.v2.api.resources cloudinary.v2.api.resource to extract
the field context: {
custom: {
alt: "Tower Eifel",
caption: "Tower Eiffel"
}
}
and create a new node including those fields.
I can see the context field with console.log but when checking with graphql I can't see anything new. And apart I think that I did wrongly nesting promises, instead of using the promises way (command(argument).then(result=>{return result}).
So, I ask for a modification of code resulting in these new fields:
context: {custom:{caption:"something written here"}}
I tried something, but I am not a experienced developer.
Thank you.

The context is available on the nodes if you set plugin option context to true.


Adding the Getting Started link to the Azuread provider

This provider works exactly the same as the Azure provider - it's just a subset of resources there that are split from the main provider - I believe we should have the getting started link available for this repository as well

This is only because we copy the contents of our README to the Python README


Update Terms/Privacy dates

Summary:

What: Set dates for privacy/terms docs to our next deploy date

Demos:
Notes:
Checklist:

[x] I merged latest trunk
[ ] I manually verified the change
[ ] I added labels to my PR
[ ] I tested in multiple browsers
[ ] I added relevant unit tests
[ ] I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

I put the same change into my acknowledgement banner PR (#709), so I think this can just be closed out


Exact match returns variations in suffixes (exact match by stem)

This issue is related to conversation at https://github.com/gnames/gnverifier/issues/80

@abubelinha, this one is life now
https://verifier.globalnames.org/api/v0/verifications/Isoetes longissimum?data_sources=0&all_matches=true

This looks much much better indeed.
It's beginning to return some first letter I/J orthovariants as well, that's great!
http://verifier.globalnames.org/api/v0/verifications/Jsoetes longissimum?data_sources=196|197|198|158&all_matches=true

Hold on @dimus ... it has broken again?
Why does this similar example not return any names?
http://verifier.globalnames.org/api/v0/verifications/Teucrium pyrenaicum subsp. guarense?data_sources=196|197|198|158&all_matches=true
Perhaps you only corrected it to matching fuzzy species names, but not infraspecies?

Definitely a bug will fix it hopefully today. https://github.com/gnames/gnames/issues/90

Fixed and published with a lot of other changes. @abubelinha please read https://github.com/gnames/gnames/releases/tag/v0.8.0


Provide multiple source vocabularies as argument

Following issue #527, --source-vocab can now take multiple files for additional source factor vocabularies.
We may want to consider changing a few variable/parameter names. For instance in train.py, now that args.source_vocab is a list, we may rename it to args.source_vocabs (parameter --source-vocabs), but it would probably not go well with the variable source_vocabs (produced by create_data_iters_and_vocabs()). This would also lead to a backwards-incompatible change.
Unit tests output 11 failures on the current master branch version. Since the content of this PR added no failures, I'm assuming the tests are passed.
Pull Request Checklist

[x] Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
until you can check this box.
[x] Unit tests pass (pytest)
[ ] Were system tests modified? If so did you run these at least 5 times to account for the variation across runs?
[x] System tests pass (pytest test/system)
[x] Passed code style checking (./style-check.sh)
[ ] You have considered writing a test
[x] Updated major/minor version in sockeye/__init__.py. Major version bump if this is a backwards incompatible change.
[x] Updated CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for adding this! Could you elaborate on what fails for you in unit tests? Current master runs tests just fine for me (and for Travis) so this must be something on your side.
Regarding the breaking change. If we would rename the --source-vocab argument for sockeye.train and sockeye.prepare_data, it would only affect training CLIs. While breaking any user scripts that call these, I would not view this as something that requires a major version bump. So i'd be fine with renaming these args and bumping only the minor version. Thoughts, @tdomhan ?

Ok, I'll change --source-vocab into --source-vocabs as soon as I get your confirmation.
The unit tests fails I get are all related to image captioning: see unit_test.txt.

Do you have python-pillow installed or something? Maybe its a version that is not compatible but it should skip these tests if not installed at all.
@lorisbaz can you advise?

I do have Pillow installed:
>>> PIL.VERSION
'1.1.7'

It seems that the problem is:TypeError: integer argument expected, got float.
It might be related to the PIL version. I tested it with 5.2.0.

Note that there is a hidden backward-incompatibility in the 1.18 range with the lhuc parameter (if you trained a model with 1.18.early, it won't run with 1.18.now). It's an easy fix (just add the keyword to the config file) but technically should have required a version bump. So together with this, it might be a reason to bump the major version.

Thanks @lorisbaz, upgrading Pillow to version 5.2.0 removed a few failures, but I still get 6: unit_test.txt.
>>> PIL.__version__
'5.2.0'

It seems related to multiple sources, since image captioning supports only a single-source input encoders.

@lorisbaz but that doesn't explain the failure of the tests, or does it? On Travis, are these tests being run? I think they are because travis installs the dev requirements, including Pillow.

I get the same 6 failures on the master branch version. There's certainly an issue with my environment.

Seems like it. Could you rebase onto latest master?

Sure, so we stay on a minor change? If so, should I increment the Sockeye version to 1.18.54, or just add a line in CHANGELOG.md under version 1.18.53? Otherwise, we switch to version 1.19.0.

I'm not sure this warrants a major version change, as there is no backwards compatibility in the sense that a trained model won't work at inference time anymore. The fact that LHUC apparently introduced a non backwards-compatible changes means that we should fix that separately (namely, being robust against lhuc missing).

The code is rebased on the latest master branch. We now have version 1.18.54.
Are there any further thoughts on changing --source-vocab to --source-vocabs?

To keep this backwards compatible, why not add --source-vocabs but keep --source-vocab (that takes just one argument). Then, when 1.19 comes out, you could remove the latter.
I agree about not incrementing for this relatively small change, but it seems like bad form to actually break everyone's scripts without incrementing.

I like the idea, although it would require two distinct ways of importing the vocabularies, according to whether --source-vocab is set or not. And we would probably need to raise an error when source_vocabs[0] != source_vocab and both are set.
Another solution would be to leave --source-vocab and create --source-factor-vocabs specifically for source factor vocabularies (not tokens). This would be consistent with the way source token and factor data files are provided (--source and --source-factors). And this would be fully backwards compatible.

The sanity check don't seem like that much of a burden. But I do also like the --source-factor-vocabs approach for 1.18, then removing it in 1.19 in favor of --source-factors. But this will all be up to the Amazon folks.

Either of those two solutions sound good. Not breaking people's training scripts is definitely something we should try to do, unless it's unavoidable.
The solution with --source-factor-vocabs might be a bit cleaner. Then we could open a issue for version 1.19 in order to not forget reconsidering using a single --source-vocabs argument.

--source-vocab remains unchanged and --source-factor-vocabs was just added.

yes, thanks for the change!


Number of PRs required for Hacktoberfest

Expected behavior and actual behavior
Expected behaviour:

The number of PRs required for Hacktoberfest 2019 is 4.

Actual behavior:

The README mentions it as 5.

Steps to reproduce the problem

This is a minor documentation fix, involving changing 5 to 4 in the README.

@ows-ali I've addressed a few other cosmetic errors in the REAME in #257
What do you think about creating a separate branch for issues other than the main coding problems? Issues could be better organised that way.

I didn't see this issue anywhere in the README, but I found and fixed it in CONTRIBUTING.md

Issue was still there. I made the edit too.

Thanks @KAHund and @adityaoberai!


Update UG for group search functionality for SearchCommand

Remember to remove viewGroup from UG

As well as update the Command Summary


global: compatible isort config with black

Signed-off-by: Harris Tzovanakis<EMAIL_ADDRESS>

Coverage remained the same at 66.701% when pulling 921f1feda51291388f0c38fbd5235add8a98c084 on drjova:fix-compatibility-with-black into 84e9a53e3b1eb0012bf24d859a1e13c8842e7548 on inspirehep:master.


set page number in footer with logic?

there is a way to calculate and display the page number with some index ?
something like this ?
options.footer = {
height: '50px',
contents: {
default:
{{page + index}}

}

for me this worked :
it will generate a footer like page 1 of 4
"footer": {
"height": "10mm",
"contents": {
// Any page number is working. 1-based index
default: ' page {{page}} of {{pages}}', // fallback value
}
}

In the example of the footer on the home page already shows how to count the pages


Feat: Enable flytekit to authenticate with proxy in front of FlyteAdmin

TL;DR
Part of an effort to integrate Flyte with GCP Identity Aware Proxy (IAP).
See tracking issue for details and motivation: https://github.com/flyteorg/flyte/issues/3965
Type

[ ] Bug Fix
[x] Feature
[x] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested (Deployed Flyte with IAP in sandbox cluster according to deployment guide in the readme added in this PR. Tested that FlyteRemote can talk to admin through the IAP, e.g. to retrieve executions, start new ones etc.)
[x] Unit tests added
[x] Code documentation added
[ ] Any pending items have an associated Issue

Complete description

Add a new option called proxyCommand to the platform config in which users can specify an external command which, if specified, is used to generate ID tokens for a proxy in front of Flyte.

This idea is derived from the existing command (external command auth type) which is used to generate tokens for Flyte itself.

The ID tokens generated by this proxyCommand are added as "proxy-authorization" header to every request (http, gRPC) that flytekit's client makes to flyteadmin, including the initial unauthenticated requests of the auth flow with flyteadmin. These additional ID tokens in the "proxy-authorization" header allow clients to interact with a flyteadmin that is protected by GCP Identity Aware Proxy (or in theory similar services from other providers)
Refactor the AuthorizationClient which currently can only be used for a pkce auth flow (despite its doc string claiming it works for a general OAuth 2.0 flow) to actually work for both pkce and default OAuth 2.0.
Add a plugin which provides a CLI that generates ID tokens for GCP Identity Aware Proxy

This plugin re-uses the AuthorizationClient in flytekit to perform an OAuth 2.0 flow with accounts.google.com.
The command is to be used as proxyCommand in the platform config for Flyte deployments protected with IAP

Add a step-by-step guide on how to deploy Flyte protected with GCP IAP

Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/

@wild-endeavor I merged #1795 into this one as requested 👍

Thanks for taking a look @wild-endeavor
I added a second subcommand to flyte-iap to generate ID tokens for service accounts:
~ flyte-iap --help
Usage: flyte-iap [OPTIONS] COMMAND [ARGS]...

  Generate ID tokens for GCP Identity Aware Proxy (IAP).

Options:
  --help  Show this message and exit.

Commands:
  generate-service-account-id-token                                         # <- new
                                  Generate a service account ID token...
  generate-user-id-token          Generate a user account ID token for...

The subcommand uses either

a service account key json file or
contacts the GCP metadata server to obtain a token when executed in Compute Engine etc.

To generate a token for service accounts, in contrast to generating one for user accounts, no browser needs to be opened interactively. The goal of this subcommand is that CICD pipelines can talk to flyteadmin through IAP. (@corleyma said they will require this.)
With that, flyte-iap is complete.
flytectl still doesn't understand the proxyCommand in the config but I will work on this next:
❯ flytectl config init
Error:

1 error(s) decoding:

* '' has invalid keys: proxycommand
ERRO[0000]

1 error(s) decoding:

* '' has invalid keys: proxycommand  src="main.go:13"

i think this looks good. cc @EngHabu to take a look though.

Taking you, @EngHabu, as suggested by @wild-endeavor 🙏

Hi Haytham, I really appreciate the time you’ve invested in looking at this PR, I'm sure you have a busy schedule :pray:

I'm less sure about reusing this command for flytectl. Requiring python dependency isn't something I would want to require in CI/CD and other automated systems

In our case, we will run pyflyte register/package in CICD as well but I agree with your concern that this shouldn't be required. I documented 2 additional ways to obtain an id token for service accounts using 1) GCP's gcloud sdk and 2) a bash script from the identity aware proxy documentation. This way, users can choose to not use python.
https://github.com/flyteorg/flytekit/pull/1787/commits/2437b84545d9cb87f9d4aaea3acd2f86401e02db

tested this with pkce, cc, and device flow btw, all works

tested this with pkce, cc, and device flow btw, all works

Thanks for testing this @wild-endeavor! 🙏
I also implemented the same logic for flytectl/the admin client in idl. Everything works, just need to polish a bit and adapt/add tests. Will ping you there as well then.

I'm trying to get all Flyte clients to pass the additional proxy-authorization header with each request.
I can use the flytekit-identity-aware-proxy plugin (with proxyCommand in the Flyte config) successfully from a FlyteRemote script, but  I'm seeing this error when trying to use flytectl.
bin/flytectl get projects

Error:

1 error(s) decoding:

* '' has invalid keys: proxycommand
ERRO[0000]

1 error(s) decoding:

* '' has invalid keys: proxycommand  src="main.go:13"

It seems the issue is that flytekit and flytectl are stuck at different versions of flyteidl? (this PR never made it in).

I'm trying to get all Flyte clients to pass the additional proxy-authorization header with each request.
I can use the flytekit-identity-aware-proxy plugin (with proxyCommand in the Flyte config) successfully from a FlyteRemote script, but  I'm seeing this error when trying to use flytectl.

bin/flytectl get projects

Error:

1 error(s) decoding:

* '' has invalid keys: proxycommand

ERRO[0000]

1 error(s) decoding:

* '' has invalid keys: proxycommand  src="main.go:13"

It seems the issue is that flytekit and flytectl are stuck at different versions of flyteidl? (this PR never made it in).

The most recent versions of flytectl (released after the move to the monorepo) use the flyteidl admin client which supports proy auth, try upgrading to e.g. >= 0.8.18 please.

The most recent versions of flytectl (released after the move to the monorepo) use the flyteidl admin client which supports proxy auth, try upgrading to e.g. >= 0.8.18 please.

I apologize, I should have posted my flytectl version, which is the v0.8.18 that you recommend.
Installed using curl -sL https://ctl.flyte.org/install | bash.
bin/flytectl version

 A new release of flytectl is available: 0.8.18 → v0.8.22
To upgrade, run: flytectl upgrade
https://github.com/flyteorg/flytectl/releases/tag/v0.8.22

{
  "App": "flytectl",
  "Build": "0a0cbce",
  "Version": "0.8.18",
  "BuildTime": "2024-06-03 10:50:36.469871 -0400 EDT m=+0.045492501"
}%

v0.8.18 still shows the error when I add proxyCommand to the flytectl config.
bin/flytectl version

Error:

1 error(s) decoding:

* '' has invalid keys: proxycommand

I apologize, I should have posted my flytectl version, which is the v0.8.18 that you recommend.

Sorry, you are right about v0.8.18 (was on my phone). Can you please try v0.8.23? The install script pointed to the archived flytectl repo until this fix a few days ago.

I apologize, I should have posted my flytectl version, which is the v0.8.18 that you recommend.

Sorry, you are right about v0.8.18 (was on my phone). Can you please try v0.8.23? The install script pointed to the archived flytectl repo until this fix a few days ago.

Ah, v0.8.23 did it. I can now use the proxyCommand field in my Flyte config.yaml.
bin/flytectl get projects

 ----- ------ -----------------
| ID  | NAME | DESCRIPTION     |
 ----- ------ -----------------
| myproject | myproject  | myproject description |
 ----- ------ -----------------
1 rows

Thanks for this! (And apologies for opening an old thread).


[KOGITO-4300] Implementing deadlines

Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Your code is properly formatted according to this configuration
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to retest this PR or trigger a specific build:

Pull Request
Please add comment: Jenkins retest this

Quarkus LTS checks
Please add comment: Jenkins run LTS

Native checks
Please add comment: Jenkins run native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

The Linux check has failed. Please check the logs.

The Linux check is successful.

The Linux check is successful.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check is successful.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

jenkins retest this

jenkins retest this

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

@cristianonicolai @tiagodolphine
I finished incorporating Marian comments, so please re-review, have a nice weekend

Answering #1175 (comment),
Thats true for the InMemoryJobService but untrue for Kogito-apps job service

So what is the meaning of repeatLimit 0 and 1 in Kogito-apps job service?
-1 is infinite repetition
0 is execute once, no repetition
1 is execute once and repeat once?
In such case R1/... will mean executing the interval twice I think. But according to the spec it should be executed just once.
Or maybe 0 and 1 have the same outcome here, in which case it's OK.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

Answering #1175 (comment),
Thats true for the InMemoryJobService but untrue for Kogito-apps job service

So what is the meaning of repeatLimit 0 and 1 in Kogito-apps job service?
-1 is infinite repetition
0 is execute once, no repetition
1 is execute once and repeat once?
In such case R1/... will mean executing the interval twice I think. But according to the spec it should be executed just once.
Or maybe 0 and 1 have the same outcome here, in which case it's OK.

0 and -1 means unlimited (but the value sent to the rest callback might be 0 both for an unlimited and a non limited timer that has been exhausted)
1 means 1 execution, 2 means 2 execution and so on

jenkins retest this

Jenkins retest this

Jenkins retest this

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

jenkins retest this

The Linux check is successful.

@kiegroup/cloud-gatekeepers please merge together with kiegroup/kogito-examples#633


Place Python at the top of requirements lists

Currently, all requirements are sorted in alphabetical order.
I personally have a strong aesthetic preference for putting the python requirement up top, with the sorted package requirements below.
In case others share my preference, here's an implementation.

Codecov Report

Merging #372 (c736307) into main (9c3242e) will increase coverage by 0.52%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   91.30%   91.83%   +0.52%
==========================================
  Files          17       16       -1
  Lines        1576     1665      +89
==========================================
+ Hits         1439     1529      +90
+ Misses        137      136       -1

Flag
Coverage Δ

unittests
91.83% <92.59%> (+0.52%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

setup.py
0.00% <0.00%> (ø)

grayskull/base/github.py
72.83% <72.83%> (ø)

grayskull/license/discovery.py
94.87% <78.12%> (-2.28%)
:arrow_down:

grayskull/strategy/abstract_strategy.py
83.33% <83.33%> (ø)

grayskull/__main__.py
95.60% <93.18%> (-2.55%)
:arrow_down:

grayskull/base/factory.py
91.17% <93.33%> (+1.17%)
:arrow_up:

grayskull/strategy/py_base.py
94.90% <94.90%> (ø)

grayskull/utils.py
97.38% <96.58%> (-2.62%)
:arrow_down:

grayskull/config.py
96.96% <96.96%> (ø)

grayskull/strategy/pypi.py
97.83% <97.83%> (ø)

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cool! Thanks for that, I few people had complained about that
LGTM!
Thanks for your contribution again! :tada:


[0-1]mel spectrogram unable to get a normal result?

hello， I use this file to extract mel spectrogram whose range is 0 to 1 https://github.com/yanggeng1995/Simplified_WaveRNN/blob/master/utils/audio.py， however，I find its hard to train waveglow， I can't even get a more normal result. Is there any solution?

Are you training from scratch or fine-tuning?

Are you training from scratch or fine-tuning?

Not yet,  I just training directly，I can use tensorflow to train normally, but I can't train normally using this repo. I am confused.

Hi @yanggeng1995 did you find a solution for this? I might be facing a similar problem.

I did not find a solution, I re-written it using tensorflow, you can find
it here  https://github.com/yanggeng1995/WaveGlow
yakku<EMAIL_ADDRESS>于2020年1月2日周四 下午8:54写道：

Hi @yanggeng1995 https://github.com/yanggeng1995 did you find a
solution for this? I might be facing a similar problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA/waveglow/issues/163?email_source=notifications&email_token=AD73U3SY2CRARRTGVKN7O23Q3XPW7A5CNFSM4JEQSRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH6IZBA#issuecomment-570199172,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD73U3VC2DUQP5DRJQRJ6TTQ3XPW7ANCNFSM4JEQSRFQ
.


improve nav bar

Is your feature request related to a problem? Please describe.
no it's not a probelm actually i just want to improve
Describe the solution you'd like.
i want to improve the apperance and style of nav bar
Describe alternatives you've considered.
i want to improve the font style and nav bar apperance
Additional context.

Show us the magic with screenshots
No response
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

can you assigned me this task
I will show you the design  before submit the code

@muskan-fatim sure go ahead and make sure the navbar changes on all pages and not just the home page

Make sure to join the discord server for further communication
Don't forget to star the repository
Complete the task in next 2 days and kindly mention your issue # in your pr like:
Closes #IssueNumber

Note: the level of the issue may change based on the quality of the PR code

Okay I will complete this task in 2 days

please check and review me


bump to pg_net 0.13.0

This is now compatible with macos, so it also reverts "feat: tmp disable pg_net on macos and allow for server start on macos (#1289) 7db7e1a9e34b9ffb9b0e3372ccf08eb4fa772f4b.

CHANGELOG for v0.12.0: https://github.com/supabase/pg_net/releases/tag/v0.12.0
CHANGELOG for v0.13.0: https://github.com/supabase/pg_net/releases/tag/v0.13.0

Please go the the Preview tab and select the appropriate sub-template:

Default
Extension Upgrade

bump ami version?


Update Readme with opencollective

This commit will update the readme
Description
[Describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves]
Check List

[ ] All tests pass. See https://github.com/sous-chefs/apache2/blob/master/TESTING.md
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

I'm a bit surprised that you removed me from the README :
Any chance we can reinstate that? I'm unsure what the policy is in sous-chefs


[hotfix] Fix interaction of Async calls/checkpointing/canceling

Before, it could happen that a Task is canceled during snapshotting.
Some State Backends would silently swallow exceptions resulting from
this and the Task would get stuck until the cleanup logic gets to it.
Now, we rethrow a CancelTaskException if isRunning is false in
StreamTask after performing snapshots.
This also moves the logic that swallows exceptions in case a task is not
running anymore from StreamTask to the async caller in Task.

Very good fix, +1 to merge this!


Support for runtime-dependencies

We should add support for "internal dependencies" defined in a package manifest and injected to only into the calls of binaries of that package. This way, we could add dependencies between tools without exposing those dependencies to the target environment.
When resolving these dependencies, we should first look at the active environment, and after that the global packages. That would allow the environments to overwrite the dependencies if needed.

Implemented


Can not set 125 Hz/250Hz rates on Logitech MX518

Information

ratbagd version (ratbagd --version): 0.16
Distribution: Arch Linux
Kernel version (ex. uname -srmo):  Linux 5.16.1-arch1-1 x86_64 GNU/Linux

Device info (if applicable):
$ ratbagctl <device> info
warbling-mara - Logitech MX518 Gaming Mouse
             Model: usb:046d:c08e:0
 Number of Buttons: 8
    Number of Leds: 0
Number of Profiles: 5
Profile 0: (active)
  Name: n/a
  Report Rate: 125Hz
  Resolutions:
    0: 800dpi (active) (default)
    1: 0dpi
    2: 0dpi
    3: 0dpi
    4: 0dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to UNKNOWN
  Button: 6 is mapped to macro '↓LEFTALT ↕ESC ↑LEFTALT'
  Button: 7 is mapped to 'profile-cycle-up'
Profile 1:
  Name: n/a
  Report Rate: 1000Hz
  Resolutions:
    0: 12000dpi (active) (default)
    1: 0dpi
    2: 0dpi
    3: 0dpi
    4: 0dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to macro '↕0'
  Button: 6 is mapped to macro '↕7'
  Button: 7 is mapped to 'profile-cycle-up'
Profile 2: (disabled)
Profile 3: (disabled)
Profile 4: (disabled)

Describe the bug
The "info" output from above is after setting the profiles using Logitech G-Hub software on Windows 10, which offers rates of 125, 250, 500 and 1000 Hz. Using ratbagctl it seems impossible to set the refresh rate to the supported values of 125 or 250 Hz. When I try to set 250, it will end up as  200 Hz. When I try to go back to 125, it ends up as 100. After this, G-Hub does not recognize the profiles any more and I have to rewrite them.
To Reproduce
Command line transcript:
alex@galaxy:~$ ratbagctl "Logitech MX518 Gaming Mouse" info
warbling-mara - Logitech MX518 Gaming Mouse
             Model: usb:046d:c08e:0
 Number of Buttons: 8
    Number of Leds: 0
Number of Profiles: 5
Profile 0: (active)
  Name: n/a
  Report Rate: 125Hz
  Resolutions:
    0: 800dpi (active) (default)
    1: 0dpi
    2: 0dpi
    3: 0dpi
    4: 0dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to UNKNOWN
  Button: 6 is mapped to macro '↓LEFTALT ↕ESC ↑LEFTALT'
  Button: 7 is mapped to 'profile-cycle-up'
Profile 1:
  Name: n/a
  Report Rate: 1000Hz
  Resolutions:
    0: 12000dpi (active) (default)
    1: 0dpi
    2: 0dpi
    3: 0dpi
    4: 0dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to macro '↕0'
  Button: 6 is mapped to macro '↕7'
  Button: 7 is mapped to 'profile-cycle-up'
Profile 2: (disabled)
Profile 3: (disabled)
Profile 4: (disabled)
alex@galaxy:~$ ratbagctl "Logitech MX518 Gaming Mouse" rate set 250
alex@galaxy:~$ ratbagctl "Logitech MX518 Gaming Mouse" info
warbling-mara - Logitech MX518 Gaming Mouse
             Model: usb:046d:c08e:0
 Number of Buttons: 8
    Number of Leds: 0
Number of Profiles: 5
Profile 0: (active)
  Name: n/a
  Report Rate: 200Hz
  Resolutions:
    0: 800dpi (active) (default)
    1: 0dpi
    2: 0dpi
    3: 0dpi
    4: 0dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to UNKNOWN
  Button: 6 is mapped to macro '↓LEFTALT ↕ESC ↑LEFTALT'
  Button: 7 is mapped to 'profile-cycle-up'
Profile 1:
  Name: n/a
  Report Rate: 1000Hz
  Resolutions:
    0: 12000dpi (active) (default)
    1: 0dpi
    2: 0dpi
    3: 0dpi
    4: 0dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to macro '↕0'
  Button: 6 is mapped to macro '↕7'
  Button: 7 is mapped to 'profile-cycle-up'
Profile 2: (disabled)
Profile 3: (disabled)
Profile 4: (disabled)
alex@galaxy:~$ ratbagctl "Logitech MX518 Gaming Mouse" rate set 125
alex@galaxy:~$ ratbagctl "Logitech MX518 Gaming Mouse" info
warbling-mara - Logitech MX518 Gaming Mouse
             Model: usb:046d:c08e:0
 Number of Buttons: 8
    Number of Leds: 0
Number of Profiles: 5
Profile 0: (active)
  Name: n/a
  Report Rate: 100Hz
  Resolutions:
    0: 800dpi (active) (default)
    1: 0dpi
    2: 0dpi
    3: 0dpi
    4: 0dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to UNKNOWN
  Button: 6 is mapped to macro '↓LEFTALT ↕ESC ↑LEFTALT'
  Button: 7 is mapped to 'profile-cycle-up'
Profile 1:
  Name: n/a
  Report Rate: 1000Hz
  Resolutions:
    0: 12000dpi (active) (default)
    1: 0dpi
    2: 0dpi
    3: 0dpi
    4: 0dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to macro '↕0'
  Button: 6 is mapped to macro '↕7'
  Button: 7 is mapped to 'profile-cycle-up'
Profile 2: (disabled)
Profile 3: (disabled)
Profile 4: (disabled)

Logs
Please start the daemon with verbosity and reproduce the issue.

I see you are on Arch, you can install libratbag-git in the fix will be there. :)


[Vue] [Tabs]: unmount prop

Description
I've run across a couple issues while using the tabs component which essentially boiled down to the fact that all of the TabContent components are mounted initially but are set to display: none.
I have various components in the tabs where I'm getting widths of elements in the onMounted hook and then using those values. However, for the tabs that aren't active when the Tabs component first mounts, those values come out to 0 because the tab is set to display: none.
My workaround is actually really easy. Just adding a v-if to each TabContent solves the issue. Like so:
<TabContent v-if="activeTab === 'TabName'" value="TabName">
So, while this is not an urgent need, it could be beneficial to the developer experience to include this as a prop on the Tabs component once rather than littering the template with a bunch of if statements.
Proposed Solution or API
I'm thinking just having a prop such as Tabs :unmount="true" or something similar. This would mount/unmount each tab on change or keep the current behavior if set to false or if ommitted.
Additional Information
No response

Same answer as this : https://github.com/chakra-ui/ark/issues/901#issuecomment-1567138626

Closing in favour of #1362


Values in key "flux-offset" of attribute "spec_parms" of class SkyModel in module catalog.py does not get saved and/or read

In ca0ab4e, the values in key flux-offset of attribute spec_parms of class SkyModel in module catalog.py did not get saved and/or read in member functions save() and __init__().

Fixed in c7d618e


Invalid Line.fillPattern annotation in Modelica.Electrical.Digital.Examples.Utilities.Counter3

Reported by beutlich on 11 Nov 2016 09:34 UTC
There are ten connect statements in Examples.Utilities.Counter3 where Line.fillPattern is set to FillPattern.Solid. According to MLS 3.3r1 section <IP_ADDRESS> there is no variable fillPattern in type Line, but there is variable pattern of type LinePattern.

Migrated-From: https://trac.modelica.org/Modelica/ticket/2107

@AHaumer @kristinmajetta @ECClauss I fixed it for branches master and maint/3.2.2.
@MartinOtter Interestingly, the error was in the MSL since v3.0, introduced by c340760a9e210260edf6ab82bcffa75836c8f95a, but it also looked strange before (in v2.2.x) with fillPattern=1


version numbers in 4.4 release broken on macOS

1.) download and extract
https://github.com/jlord/git-it-electron/releases/download/4.4.0/Git-it-Mac-x64.zip
2.) select Git-it in the Finder, it claims to be 'Version: 4.3.0' in the Info Pane, Get Info window and QuickLook
both  the CFBundleVersion and CFBundleShortVersionsString entries in your Info.plist file are not updated with the actual version number which should read 4.4.0

Ohh thanks for catching that! I'll update in the next release 👍


[api-minor] Update the minimum supported Safari version

The Ink-editor uses ResizeObserver, which is supported in all reasonably modern browsers; see https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver#browser_compatibility
With the exception of Safari, ResizeObserver is thus available in all of the browsers that the PDF.js library currently support. Rather than trying to e.g. add a polyfill, let's just bump the compatibility (slightly) to Safari 13.1 instead; see https://en.wikipedia.org/wiki/Safari_version_history#Safari_13

/botio integrationtest


Support message persistence

The NATS ecosystem (and not necessarily gnatsd itself) should support the ability to persist messages such that a client may receive messages that have been published to subjects of interest while that client was not connected to gnatsd.

As you know, I believe the larger NATS ecosystem should provide this, but I do not believe this should be core to gnatsd.

@derekcollison Sorry for creating confusion. My intent wasn't to imply that gnatsd itself should have this functionality as core. By popular community request, we are trying to use GitHub to track the NATS project roadmap. For the moment, we're using this repository as the master Issue Tracker for that purpose. Granted, that artificially bends Issue Tracker a little bit for this repo, especially when discussing things that might not exist yet, and might not (or will not) exist in gnatsd.
Another solution would be to create a 'nats-io/roadmap' repo, which would also be somewhat artificial, in that it would only exist to hold issues and milestones that point at Issues and Milestones that live in other repositories.

Issue description edited to reflect @derekcollison comment.

So, are we going to support this feature(message persistence) in our roadmap?

yes.

Hi @derekcollison / @mcqueary any estimate when this may be implemented.

I think we should have something usable by around  the end of March. What
client language are you interested in?
On Friday, February 12, 2016, Sachin Walia<EMAIL_ADDRESS>wrote:

Hi @derekcollison https://github.com/derekcollison / @mcqueary
https://github.com/mcqueary any estimate when this may be implemented.
—
Reply to this email directly or view it on GitHub
https://github.com/nats-io/gnatsd/issues/130#issuecomment-183456657.

--
Larry McQueary | Director, Messaging Technology
<EMAIL_ADDRESS>| @mcqueary | github.com/mcqueary

I am using Java 8. So far I have been using Java client built by tyagihashi. However contemplating moving to the official jnats client.

Java and Go here!

Sachin let me know if you need assistance making the move. I have not
compared jnats to Teppei's client but they should be quite similar other
than minor details. We'd like to identify anything that will ease adoption
and make sure we address it.
On Friday, February 12, 2016, Sachin Walia<EMAIL_ADDRESS>wrote:

I am using Java 8. So far I have been using Java client built by
tyagihashi. However contemplating moving to the official jnats client.
—
Reply to this email directly or view it on GitHub
https://github.com/nats-io/gnatsd/issues/130#issuecomment-183460170.

--
Larry McQueary | Director, Messaging Technology
<EMAIL_ADDRESS>| @mcqueary | github.com/mcqueary

Thanks I'll try to implement jnats and see if i hit any problem.

I have a library that shows how to write a nats client that does persistence for selected topics.
https://github.com/glycerine/tmframe/tree/master/archiver

Nice, Jason!
/cc @bjflanne

This issue is generally resolved by "Project STAN" and will be specifically addressed in nats-io/stan#40. More information will be announced next week.

404?

Apologies, that repo is not public yet. Stay tuned!
On Sunday, March 20, 2016, Chris McVittie<EMAIL_ADDRESS>wrote:

404?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/nats-io/gnatsd/issues/130#issuecomment-199026262

--
Larry McQueary | Director, Messaging Technology
<EMAIL_ADDRESS>| @mcqueary | github.com/mcqueary

@mcqueary any updates on this or an eta?

@chrismcv it's in-flight right now and should be in the MVP, which should be when all this is made public. We're working out the date right now. Are you on our Slack team? DM me your email address on Twitter and I can send you an invite.

This will be covered by STAN, not the core nats-server.


How to open Windows Terminal programmatically?

I can use Process to open cmd and some other software in c# very simply, but how can I open the new Windows Terminal?
I can't find the folder where it is.
Thanks in advance.

There should be an executable, wt.exe, on your PATH.

Thank you very much.


README do not mention the requirement to set app-name on firebase elements

Description
All Firebase elements (apart from firebase-app) require the app-name property set to the corresponding name value of firebase-app. This is mentioned in the code-lab and you can find it in the demo note-app, but it is not clear from the documentation of the elements/README. This would clear up some initial confusion for new developers who are trying out the Firebase elements.

This should be documented better, but my suggestion is that unless you have a strong reason to do so, just don't put name on your apps at all. It will create a default app and then you don't need app-name on your elements.


feat: CE-1003 Add notes to CEEB complaint outcome

Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!
Deployments, as required, will be available below:

Frontend
Backend

Please create PRs in draft mode.  Mark as ready to enable:

Analysis Workflow

After merge, new images are deployed in:

Merge Workflow

@Scarlett-Truong - As per offline discussion if a note is added to a case without a decision the case will be created under the wrong agency