Chuck Norris database 404s

The Chuck Norris Database link 404s. Do we need to use a different API for this article?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 46af0b96-2d12-9cac-2f8f-15eb49d0292d
Version Independent ID: 33db41be-42f9-bb94-65fe-0cf7d1c64f12
Content: Use the IHttpClientFactory - .NET
Content Source: docs/core/extensions/httpclient-factory.md
Product: dotnet-fundamentals
GitHub Login: @IEvangelist
Microsoft Alias: dapine

Associated WorkItem - 39222

You don't find Chuck Norris. Chuck Norris finds you.


Q: Multiple publishers for live market data streaming using ZMQ Black Box Pattern

Hi,
I'm trying to implement a live data streaming from a MT4 terminal to a Postgres database. To accomplish this, I'm using dwx-zeromq-connector and I had success when doing this for 2 currency pairs.
The way the connector works is by setting a pub/sub ports and stream data from MT4 using a python script. Now I want to stream 28 currencies, so the number of charts in the MT4 terminal is 28 and the problems of slow subscribers feels very heavy. The messages queue up and no matter what I try, it does not seems to process them any faster.
What I have tried so far is:

28 different sub sockets for all pub ports using multiprocessing and daemon threads (not at the same time)
1 socket for all 28 pub ports using multiprocessing and daemon threads (not at the same time)
28 different classes running 1 daemon thread each, one per pub
1 class having 7 different threads and each thread has 1 socket that manages 4 pub ports

None of them improves the performance. Now, looking at this zmq guide, the Black Box Pattern seems to be suitted for what I need. However, I was wondering if I should reduce the amount of pub ports by making that the publishers publish information to only 1 pub socket.
So, can many publishers publish messages to only one port using tcp protocols? How can is the zmq guide what I should really use? The specs of the VPS I'm using is 2 vCPU and 12 GB RAM.
Thank you!

Closing some stale issues. I hope you found what you were looking for! I can't really help out with application design on this repo, that's probably more of a task for stack overflow.


Update java bindings

This PR updates the java bindings to the new interface.
Notable changes:

Add reference test functions.
For benchmarking verifyBlobKzgProofBatch do counts 1, 2, 4, 8, 16, 32, 64.
For verifyKzgProof change time scale to ms (instead of ns).
Tried to update relevant tests to reflect new interface functions.

@StefanBratanov when you get a chance, could you review these changes?

@StefanBratanov when you get a chance, could you review these changes?

LGTM


Binance account info throws ZipException: Not in GZIP format

java.util.zip.ZipException: Not in GZIP format
	at java.util.zip.GZIPInputStream.readHeader(GZIPInputStream.java:165) ~[na:1.8.0_151]
	at java.util.zip.GZIPInputStream.<init>(GZIPInputStream.java:79) ~[na:1.8.0_151]
	at java.util.zip.GZIPInputStream.<init>(GZIPInputStream.java:91) ~[na:1.8.0_151]
	at si.mazi.rescu.HttpTemplate.readInputStreamAsEncodedString(HttpTemplate.java:217) ~[rescu-2.0.1.jar:na]
	at si.mazi.rescu.HttpTemplate.receive(HttpTemplate.java:126) ~[rescu-2.0.1.jar:na]
	at si.mazi.rescu.RestInvocationHandler.receiveAndMap(RestInvocationHandler.java:156) ~[rescu-2.0.1.jar:na]
	at si.mazi.rescu.RestInvocationHandler.invoke(RestInvocationHandler.java:120) ~[rescu-2.0.1.jar:na]
	at com.sun.proxy.$Proxy75.account(Unknown Source) ~[na:na]
	at org.knowm.xchange.binance.service.BinanceAccountServiceRaw.account(BinanceAccountServiceRaw.java:25) ~[xchange-binance-4.3.2-20171228.140010-55.jar:na]
	at org.knowm.xchange.binance.service.BinanceAccountService.getAccountInfo(BinanceAccountService.java:41) ~[xchange-binance-4.3.2-20171228.140010-55.jar:na]

I am receiving the same issue.
Is there any way to disable gzip for rescu?
(Wanted to create a similar issue, but better to comment here I think..)

I think it was an temporary issue on the Binance side. My application received similar ZipExceptions between 13:44 and 16:19 GMT which have now resolved without any changes for me.
Not sure if it is related, but since this morning the performance of the authenticated user trade history has also worsened, I had to increase the socket timeout to >5 seconds in order to get any data back.

The issues are also resolved on my machine at this moment.
On 28 Dec 2017 6:11 pm, ww3456<EMAIL_ADDRESS>wrote:
I think it was an temporary issue on the Binance side. My application received similar ZipExceptions between 13:44 and 16:19 GMT which have now resolved without any changes for me.
Not sure if it is related, but since this morning the performance of the authenticated user trade history has also worsened, I had to increase the socket timeout to >5 seconds in order to get any data back.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/timmolter/XChange/issues/2060#issuecomment-354321989, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACEXBFfzGItEaVi0o-EAtrfnlVXQ4nWzks5tE8uvgaJpZM4ROY1y.


ssl doesn't fully work on files.achew22.com

I was getting issues downloading the files from files.achew22.com with curl and bazel (java), so I ran an SSL test:
https://www.ssllabs.com/ssltest/analyze.html?d=files.achew22.com
It's saying that that the let's encrypt cert is an extra download. Is the let's encrypt cert included in the cert bundle on the web server? It seems that is not the case when I look at the output for the following command:
$ echo | openssl s_client -showcerts -servername files.achew22.com -connect files.achew22.com:443 | openssl x509 -inform pem -noout -text
depth=0 CN = andrewzallen.com
verify error:num=20:unable to get local issuer certificate
verify return:1
depth=0 CN = andrewzallen.com
verify error:num=21:unable to verify the first certificate
verify return:1
DONE
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            03:ff:64:5d:29:92:30:bd:cb:33:b9:f6:90:61:49:0a:90:2f
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: C=US, O=Let's Encrypt, CN=Let's Encrypt Authority X3
        Validity
            Not Before: May 16 04:45:00 2016 GMT
            Not After : Aug 14 04:45:00 2016 GMT
        Subject: CN=andrewzallen.com
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                Public-Key: (2048 bit)
                Modulus:
                    00:a0:01:83:90:af:b5:e2:88:8e:f0:fc:09:52:c6:
                    d7:dc:4f:31:a7:2b:80:db:f2:3c:46:dd:ba:af:76:
                    0a:98:b4:47:ef:20:df:ab:a1:7c:56:a4:3f:72:b2:
                    7a:8f:b6:a9:6c:63:2a:20:8e:3f:dc:c6:75:36:da:
                    cb:3d:c7:93:8f:1d:04:c8:81:38:1c:71:29:6c:a6:
                    69:51:4e:e1:54:a5:36:a3:d1:2a:54:d0:3a:fc:26:
                    4f:35:28:fd:10:a5:c2:c8:9a:42:37:a5:5b:0d:79:
                    85:51:92:48:87:c1:1b:ce:f1:a2:5d:54:e1:70:fb:
                    f7:f2:73:28:d3:63:97:77:85:58:45:34:69:2d:21:
                    30:0f:a0:d4:2b:2b:15:22:c9:16:99:3b:d2:a3:c2:
                    80:9f:6a:8b:fb:dd:b0:16:0d:e4:16:3b:a4:6a:fb:
                    90:ad:9b:a8:8d:09:c9:a9:30:fd:14:ba:ec:b4:36:
                    31:68:81:8c:00:68:15:79:56:8e:f5:05:ee:c1:bc:
                    42:03:75:dc:31:58:fa:13:49:10:f8:56:8d:d5:f0:
                    c3:a7:ec:3e:8e:9a:30:eb:13:8f:99:47:12:54:8c:
                    d1:40:1a:9c:48:50:2d:62:71:c9:79:cd:89:5a:86:
                    c7:e3:c5:57:a2:ac:a3:f9:78:64:6d:6d:77:30:23:
                    24:1f
                Exponent: 65537 (0x10001)
        X509v3 extensions:
            X509v3 Key Usage: critical
                Digital Signature, Key Encipherment
            X509v3 Extended Key Usage:
                TLS Web Server Authentication, TLS Web Client Authentication
            X509v3 Basic Constraints: critical
                CA:FALSE
            X509v3 Subject Key Identifier:
                96:0B:D2:1E:63:18:A5:A5:F7:3D:E8:A5:6E:07:56:DF:57:55:94:12
            X509v3 Authority Key Identifier:
                keyid:A8:4A:6A:63:04:7D:DD:BA:E6:D1:39:B7:A6:45:65:EF:F3:A8:EC:A1

            Authority Information Access:
                OCSP - URI:http://ocsp.int-x3.letsencrypt.org/
                CA Issuers - URI:http://cert.int-x3.letsencrypt.org/

            X509v3 Subject Alternative Name:
                DNS:achew22.com, DNS:andrewzallen.com, DNS:ci.andrewzallen.com, DNS:code.andrewzallen.com, DNS:couchpotato.achew22.com, DNS:files.achew22.com, DNS:files.andrewzallen.com, DNS:files.stoccato.com, DNS:jenkins.andrewzallen.com, DNS:sabnzbd.achew22.com, DNS:sickbeard.achew22.com, DNS:sonarr.achew22.com, DNS:transmission.achew22.com, DNS:www.achew22.com, DNS:www.andrewzallen.com
            X509v3 Certificate Policies:
                Policy: <IP_ADDRESS>.2.1
                Policy: <IP_ADDRESS>.4.1.449<IP_ADDRESS>
                  CPS: http://cps.letsencrypt.org
                  User Notice:
                    Explicit Text: This Certificate may only be relied upon by Relying Parties and only in accordance with the Certificate Policy found at https://letsencrypt.org/repository/

    Signature Algorithm: sha256WithRSAEncryption
         4d:75:dc:b1:3e:be:1b:34:57:fe:a4:ea:15:73:66:01:cf:ad:
         b2:96:72:a3:92:6d:78:0e:b5:92:28:36:74:1c:90:05:a6:ad:
         01:a6:27:20:0e:4a:38:8a:6b:5d:bd:07:42:ea:a9:33:4c:52:
         b9:3e:a9:b3:d9:25:82:48:db:53:6b:cb:24:9b:9c:d8:56:11:
         57:c4:bc:eb:f7:93:ed:62:55:61:69:1f:82:e1:97:66:1f:29:
         f9:b0:03:c0:7f:a1:06:81:c4:fc:a5:bf:49:e7:3d:4b:31:5f:
         83:7d:c8:ec:1f:d8:27:9b:af:f0:4a:9e:81:7f:57:da:60:9a:
         b0:a5:bf:26:43:93:a3:f4:02:2c:51:3a:e3:f6:c1:b3:60:3d:
         57:cf:f1:c2:68:58:20:43:6f:ae:db:fd:de:51:e4:77:9f:cd:
         1c:60:73:62:f5:49:b7:bf:6c:8c:1c:8c:44:26:2c:2d:3a:05:
         d3:46:d9:02:a4:e8:be:b1:74:9e:d3:5a:78:91:03:67:47:67:
         64:65:ef:3d:ca:0d:14:70:66:d9:15:15:7b:d3:72:31:c4:aa:
         aa:97:58:41:41:da:6b:e5:3e:c0:c0:5d:21:4a:ba:ed:f6:df:
         a0:84:68:1a:fe:bc:9f:8d:04:7a:b3:44:27:ff:3a:c9:88:4e:
         08:51:ec:31

Is there any chance you could add the full cert bundle on the server so the curl and java can work with the let's encrypt cert?

Thanks for the heads up! I think I am going to release these as binarie on github releases rather than deal with importing a new TLS chain. I'll update this thread when I have that done.

@wt I decided to just put it up without TLS but on a subdomain. If this doesn't fix things, please reopen the issue.


Update GaudiNIC multi-node-training dockerfile and setup

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


config.rb runs twice

Not sure if this is a bug or by design, but Middleman loads config.rb twice when running the server and building a site. Currently this leads to errors in my site.
This can be replicated directly after running middleman init.

Ruby version: 2.5
Middleman version: 4.3.0.rc2

That's expected. I can run even more than that during dev, it's re-evaluated on certain structural and data changes. Sounds like you're running code that generates side-effects in the config?

Ah ok, I've been setting up data structures that get duplicated when config.rb is run twice - I'll put that code somewhere in lib/. Thanks

@polyethylene1and2 If you've got a code sample, let me know. Might be fine in config with a couple tweaks.


Fix property reading from database and fix tests

This adds read operations when readAll and readGroup features from database, to get the custom properties of each feature.
Also this fixes the sql test data for the unit tests.

Coverage decreased (-0.007%) to 93.557% when pulling 55e375836143669027e7d4ac0534f329ca7ef70c on ihrigb:master into 307172866f35f5c06e767a6257a8e9b76ef1b447 on clun:master.

Thank you


Documentation description?

How can I define my doc description? At the swagger option (config/swagger.ts) doesn't have a description key

Oopsy, daisy :-D
Fixed in 3.14.0, but also 3.16.0 adds an info-object to the config so you can pass all the fields that swagger supports: https://swagger.io/docs/specification/api-general-info/


Why Markdown preview?

I don't get why it includes a markdown preview. Usually you only have text – and when you have more, it is very likely you include HTML text, but not Markdown?
So why?

Markdown is a lot easier for non-developers to work with than HTML. It's also less dangerous.
If you're not careful, someone might sneak in JavaScript into that HTML code.
I was thinking about allow making the preview flexible enough to display different content types, but that would have to be configured by the extension authors by supplying a config file, which describes the preview type.

If you're not careful, someone might sneak in JavaScript into that HTML code.

Of course, but you should trust & review your JSON files.
Also even Markdown needs to be passed through a DOM sanitisation tool or so as it can also include HTML.
Also you can hardly assume anyone would write Markdown in these JSON files, as that is not a documented feature of these files.

but that would have to be configured by the extension authors by supplying a config file

Why not just use comments on the JSON for that?

Also even Markdown needs to be passed through a DOM sanitisation tool or so as it can also include HTML.

I use markdown-it for both the editor and my add-ons and it already handles these issues:
https://github.com/markdown-it/markdown-it/blob/master/docs/security.md
Of course you should check these, but humans make flawed, so it can't hurt to add some security layers.

Why not just use comments on the JSON for that?

Either that or a real data entry in the messages.json would of course be possible. I haven't worked this out yet.

but humans make flawed, so it can't hurt to add some security layers.

Well… devs should check the stuff they have in their repo. If there is rogue stuff in their rrepo and they don't see that, this can be worse than just in some translation files.
But getting off-topic. Yes, of course it's good to have this "layer of defense". Basically, the lib looks great and by being more secure, it's also more strict.
However, it's still that you only use that.
My point is: Having a Markdown preview there kinda suggests add-on devs that this is the way to go, how they should/can do it. So this may be misleading advise. (And I know, not a deliberate advise, but it is implied there.)

Either that or a real data entry in the messages.json would of course be possible. I haven't worked this out yet.

So I'd argue for just disabling the preview unless you find such tags, i.e. disable it for now and once it is implemented the preview may be shown, and it may only be shown for these entries, where it is appropriate (iu.e. "annotated"). :smile:

Not sure why this is such a problem, you can press the eye button in the toolbar and it goes away.
Of course, it can be implemented, that the preview will only be shown when a message has been marked as markdown, but I won't disable it until then.
I write my help pages and my change-logs as markdown and need it as a major feature of the editor
Aside, I'm not sure I want to disable it for non-markdown entries:

A preview might still be of interest to see how they look with placeholders replaced.
Enabling/disabling the sidebar whenever a markdown or non-markdown editor has been selected will result in annoying UI layout rearrangements.

I guess I could do one or more of the following:

Create a setting for the extension developers to hide it on a per-extension case rather than on a per-message case.
Set the initial visibility of the sidebar to disabled  for extensions that do not have a message marked as markdown.
Remember the toggled state in the browser storage for your next visit.

How would you solve these complex views like help pages if not by using markdown or similar?
I don't see why markdown is a big no-no for extension developers.

If you use HTML, your translators need to understand HTML as well. It's a lot easier to teach people correct Markdown than correct HTML.
Anyway, there will be options for this, but I will try and collect some more input from other developers to make sure I get this right.


generate annotations

How I would use code to generate annotations from field audio files

This project aims to generate  musicians' body motion from audio,  and does not support the function to generate annotations automatically. As described in README file, all the annotations are manually annotated in this project.

Time semantics recognition ,It is not possible to generate annotations from music as described in the text (ATS),the experimental part is also tested


New develop branch manual install with yarn giving error

Dear Team,
New develop branch manual install with yarn giving error
00h00m00s 0/0: : ERROR: There are no scenarios; must have at least one.
getting below error when starting server with node server.js or pm2 tool
import Logger from './lib/Logger';
^^^^^^
SyntaxError: Cannot use import statement outside a module
at wrapSafe (internal/modules/cjs/loader.js:979:16)
at Module._compile (internal/modules/cjs/loader.js:1027:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
at internal/main/run_main_module.js:17:47
ubuntu@ip-10-0-3-85:~/edumeet/server$
Thanks

Pull the latest develop revision and use yarn start or yarn dev command.

You are using the wrong package, see here: https://stackoverflow.com/questions/53471063/yarn-error-there-are-no-scenarios-must-have-at-least-one/53471064

Fixed yarn with npm install --global yarn , but getting error visiting webpage as below
react-dom.production.min.js:290 Uncaught Error: Minified React error #200; visit https://reactjs.org/docs/error-decoder.html?invariant=200 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at t.render (react-dom.production.min.js:290)
at index.js:180
at index.js:75
at HTMLDocument.e (ready.js:23)
t.render @ react-dom.production.min.js:290
(anonymous) @ index.js:180
(anonymous) @ index.js:75
e @ ready.js:23
:4443/favicon.ico:1 GET https://test.alex.com.com:4443/favicon.ico 500

The yarn install procedure is:
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list

sudo apt update
sudo apt install yarn

Same issue i tried in fresh machine ubuntu 18.04. Above steps of yarn installation works only when Nodejs 14.X is not installed.
Same error on browser as below
react-dom.production.min.js:290 Uncaught Error: Minified React error #200; visit https://reactjs.org/docs/error-decoder.html?invariant=200 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at t.render (react-dom.production.min.js:290)
at index.js:180
at index.js:75
at HTMLDocument.e (ready.js:23)
t.render @ react-dom.production.min.js:290
(anonymous) @ index.js:180
(anonymous) @ index.js:75
e @ ready.js:23
favicon.ico:1 GET https://test.alex.com:4443/favicon.ico 500
Thanks

Do you have tried to remove the node_modules folder first?

Yes, its completely fresh manual installation and tried again its the same issue its getting failed in one or other place.
If everything is installed web portal is not working
First of all yarn not going to install when node version 14 is already present, so we need to install first yarn and then install nodejs.

This is a problem, as how to upgrade existing installations?

@Alex-YddeR can you provide us the exact nodejs and yarn packages versions?

Platform:
Ubuntu 18.04 / 20.04
Install Steps:

Install Yarn

sudo apt-get update
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
sudo apt update
sudo apt install yarn ( Install default node 8.10.0)
or
sudo apt install --no-install-recommends yarn

Yarn Version : v1.22.5

Install dependencies

sudo apt install git npm yarnpkg build-essential redis libssl-dev openssl pkg-config

Gives error on installing yarnpkg here. so skipped yarnpkg

Install NodeJS

Using Ubuntu

curl -fsSL https://deb.nodesource.com/setup_lts.x | sudo -E bash -
sudo apt-get install -y nodejs
Node Version: 14.16.1

yarn works well building the app, it either fails on server or everything installs well but web portal doesn't work
Thanks

Some how we tried to install, but when try to reach the page by adding room name it says internal server error. also when exit the conference with leave button same error is coming as per below screenshot

Thanks

Can you provide also the build log of server and app?

Sure, where can I get those logs
Thanks

Are you looking at below logs
ubuntu@ip-10-0-3-38:~/edumeet/app$ ls
Procfile  build  package.json  public  src  tsconfig.json  yarn.lock
ubuntu@ip-10-0-3-38:~/edumeet/app$ yarn
yarn install v1.22.5
[1/4] Resolving packages...
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^6.0.0 || ^7.0.0".
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^6.0.0 || ^7.0.0".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "eslint@>= 4.12.1".
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency "eslint@^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "eslint@>=5".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7".
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0".
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^5.0.0".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^15.5.4".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^15.5.4".
warning "eslint-config-airbnb-typescript ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^6.8.0 || ^7.2.0".
warning "eslint-config-airbnb-typescript ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^6.8.0 || ^7.2.0".
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency "eslint@".
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[4/4] Building fresh packages...
Done in 51.88s.
ubuntu@ip-10-0-3-38:~/edumeet/app$ yarn build
yarn run v1.22.5
$ react-scripts build && mkdir -p ../server/public && rm -rf ../server/public/ && cp -r build/* ../server/public/
Creating an optimized production build...
`	Compiled with warnings.
src/components/JoinDialog.js
Line 208:8:  '_askForPerms' is assigned a value but never used  no-unused-vars
src/components/Loader/LoadingView.js
Line 4:17:  'theme' is defined but never used  no-unused-vars
src/components/MeetingViews/Filmstrip.js
Line 265:4:  'roomClient' is assigned a value but never used  no-unused-vars
src/components/PeerAudio/PeerAudio.js
Line 103:5:  'dst' is assigned a value but never used  no-unused-vars
src/components/VideoContainers/FullScreenView.js
Line 173:5:  React Hook useEffect has missing dependencies: 'consumer' and 'roomClient'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
src/store.js
Line 66:7:  'saveSubsetFilter' is assigned a value but never used  no-unused-vars
Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.
File sizes after gzip:
212.98 KB  build/static/js/11.ff61e6df.chunk.js
90.94 KB   build/static/js/main.4f42e8e2.chunk.js
64.65 KB   build/static/js/13.9f5cd9fc.chunk.js
64.03 KB   build/static/js/12.f17f29ca.chunk.js
29.41 KB   build/static/js/room.36e6b750.chunk.js
21.11 KB   build/static/js/1.a568a4a8.chunk.js
18.49 KB   build/static/js/14.c4c15352.chunk.js
6.73 KB    build/static/js/0.501fcd1f.chunk.js
1.77 KB    build/static/js/runtime-main.53f61051.js
1.28 KB    build/static/js/file-saver.99a4fcde.chunk.js
1.09 KB    build/static/js/screensharing.3558591f.chunk.js
720 B      build/static/css/12.f94bdb3a.chunk.css
421 B      build/static/js/app.1300cd1f.chunk.js
357 B      build/static/css/main.ea979dc9.chunk.css
203 B      build/static/js/webtorrent.3ed9e320.chunk.js
155 B      build/static/js/createtorrent.2bb026e9.chunk.js
141 B      build/static/js/socket.io.d6da3eb8.chunk.js
The project was built assuming it is hosted at ./.
You can control this with the homepage field in your package.json.
The build folder is ready to be deployed.
Find out more about deployment here:
https://cra.link/deployment
Done in 80.65s.
ubuntu@ip-10-0-3-38:~/edumeet/app$ cd ../server/
ubuntu@ip-10-0-3-38:~/edumeet/server$ ls
access.ts  certs  config  connect.js  dist  httpHelper.js  lib  node_modules  package.json  permissions.js  public  server.js  tsconfig.json  userRoles.js  utils  yarn.lock
ubuntu@ip-10-0-3-38:~/edumeet/server$ rm -rf node_modules/
ubuntu@ip-10-0-3-38:~/edumeet/server$ yarn
yarn install v1.22.5
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "eslint-config-airbnb-typescript ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "eslint-config-airbnb-typescript ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "eslint-config-airbnb-typescript ><EMAIL_ADDRESS>has unmet peer dependency "eslint-plugin-react-hooks@^4 || ^3 || ^2.3.0 || ^1.7.0".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>[4/4] Building fresh packages...
Done in 252.57s.
ubuntu@ip-10-0-3-38:~/edumeet/server$ yarn build
yarn run v1.22.5
$ rm -rf dist && tsc && ln -s ../certs dist/certs
Done in 17.62s.

ubuntu@ip-10-0-3-38:~/edumeet/server$ sudo node dist/server.js

process.env.DEBUG: undefined
config.mediasoup.worker.logLevel: debug
config.mediasoup.worker.logTags: [ 'info', 'ice', 'dtls', 'rtp', 'srtp', 'rtcp' ]
(node:8686) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
(Use node --trace-deprecation ... to show where the warning was created)

Tried to install again on fresh machine we are getting same error when tried to refresh the page or by adding roomname to URL. below is the error
Internal Server Error
If you report this error, please also report this tracking ID which makes it possible to locate your session in the logs which are available to the system administrator: ce005d47-e6ab-40b1-8109-bd288c35769a
Thanks

@vpalmisano This is fixed by commit #782
Thanks


Keybindings

While basic keybindings are currently in place, several more need to be in place for decent editing support.

First step has been added: I've figured out how to handle mapping.  Turns out gxui.KeyboardEvent is hashable, so I can use events as the key type for a map.  I'm currently using a "Command" as the value type - I have hopes that this will make it easier to map actions generically.

I think we're at a place where this can be closed - key binding is working quite well, and user-configured key bindings will be trivial to implement with the way we're currently mapping them.


SystemTap

https://sourceware.org/systemtap/

I'm not sure but it doesn't look like a PL.

It's in the same class as DTrace. They are tracing frameworks. But they have their own languages to do so:
https://en.wikipedia.org/wiki/DTrace#See_also
This is an example of DTrace scripts: https://docs.oracle.com/cd/E18752_01/html/819-5488/gcfqr.html

It's fine to not include them as they are not programming language in common sense.


Refresh agenda every time I open it

Does this feature exist in Emacs orgmode core?
Yes
Orgmode link

Feature value
Quite often, I open the agenda (with <leader>oa by default) and the agenda is outdated. This happens when I opened the agenda before, then I change some events, and then open the agenda again. When it is outdated, that often confuses me until I remember that I have to do rr to refresh the agenda. It would be great if the agenda is just refreshed automatically every time I do <leader>oa.
Additional context
No response

See #656, this should now be easily doable with vim.loop.


feat(infra): add ability to provision dev tunnel

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#692  👈
#677 : 1 other dependent PR (#691 )
#681
#680
#636
#675
#664
#661
#660
#650
#649
#663
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


.env is not being included in build for deployment, but .env.local and secret.local are

Hi there,
Many thanks for this awesome nx project
I am using version 2.1.2
When I build and deploy my firebase function, the dist/apps/function folder seems to build with .secret.local and .env.local and .env is not there
This seems to be the opposite of what is said here:
https://github.com/simondotm/nx-firebase/blob/main/docs/nx-firebase-functions-environment.md
"The firebase CLI will deploy .env and/or .env. files along with function code, and they can be version controlled."
and
".env.local and .secret.local files are excluded from deployment by using an functions.ignore rule in firebase.json."
The issue that I have, regardless, is that when I console log process.env.MY_VAR in production, it comes up as undefined in google cloud logs
Is this a bug or is there something I am doing wrong? The functions block in my firebase.json looks like this (and I have made no changes to this file)
  "functions": [
    {
      "codebase": "functions",
      "source": "dist/apps/functions",
      "runtime": "nodejs16",
      "ignore": [
        "*.local"
      ],
      "logs": false
    }
  ],

Another important piece of info, if I remove the .env file, prodution starts using .env.local!

@stevebrowndotco thanks for reporting this.
It should indeed copy .env files to dist as part of the build step. For example here is one of my projects dist:

A few things to check then:

There's definitely a .env file in your firebase app project environment folder?
Your functions project.json has the following glob in its config for assets?

        ...
        "assets": [
          "apps/functions/src/assets",
          {
            "glob": "**/*",
            "input": "apps/firebase/environment",
            "output": "."
          }
        ],
       ....

(assuming your main firebase app project was named firebase)

Hi @simondotm thank you for checking

There is definitely  a .env file in the firebase/environment folder yes:

Yes glob looks the same:

@stevebrowndotco
In your first image, .env file in your environment folder is greyed by vscode, which normally indicates it is being affected by .gitignore
Please could you check you dont have .env in your .gitignore ?
This would explain it, since Nx assets copy respects those rules and would not copy .env in this case.
(The reason why .secret.local gets copied even though .gitignore'd is because the plugin adds an exception for this in .nxignore)

Hi @simondotm many thanks for looking into that. You are correct, it is because it is ignored in git! So I suppose the issue I have is now beyond the scope of this repo but more of an "nx" issue.
This is because I actually have a use case for not wanting .env in source control because of security reasons. I wonder if there is a way to leverage changing the behaviour in the nx config though...

@stevebrowndotco
If your .env files are intentionally in .gitignore but you still want to copy them to dist when building, then try adding:
!.env.*

to .nxignore
That should do it.

Hi @simondotm that did it. Thanks for taking a look even though it wasn't strictly an issue with your library


seperate-jobs attempt 1

bython

Codecov Report

Merging #1 (6cf815d) into main (a8427f1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            4         4
=========================================
  Hits             4         4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8427f1...6cf815d. Read the comment docs.


Connection disables when app is kept in background

Describe the bug
The connection is succesfull, but the moment ,I keep the app in background the connection is refused and disconnected automatically (trying with esp32)
To Reproduce
Steps to reproduce the behavior:

connect to the ble
keep the app in background(press home button)

Expected behavior
perssist connection even with the app is in background
Smartphone (please complete the following information):

Poco c3
Android version 12

Additional context
Add any other context about the problem here.

What makes you think that this wrapper library is performing a disconnect? seems more likely the implementation is not keeping the connection open.
Do you have any logging in place on the device to see if the device is being disconnected?

yeah forgot to mention below is the log i get when i press button
W (711892) BT_APPL: gattc_conn_cb: if=3 st=0 id=3 rsn=0x13 W (711892) BT_HCI: hcif disc complete: hdl 0x0, rsn 0x13
I am completely new to kmm and ble

Ok, i think i know your issue,
https://github.com/Reedyuk/blue-falcon/blob/1f6960d4bab9e98f792354a11cbcf431c7f7429a/library/src/commonMain/kotlin/dev/bluefalcon/BlueFalcon.kt#L19
You need to make sure that you pass TRUE for autoConnect.
blueFalcon.connect(device, true)

I believe you are probably using the default value which is false.


Update FF Android tracking bug

The current tracking bug is resolved fixed, but the Intl API is currently disabled for the release build. The bug to enable it on release builds it 1344625

Thanks!


Ensure that Azure Virtual Network subnet is configured with a Network Security Group

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
Is your feature request related to a problem?
As identified during the work in issue #268, terrascan recommends that all Subnets are configured with a Network Security Group.
The following provides a summary of the errors created by this missing feature:
        -----------------------------------------------------------------------
  Description    :        Ensure that Azure Virtual Network subnet is configured with a Network Security Group
  File           :        resources.connectivity.tf
  Module Name    :        root
  Line           :        46
  Severity       :        MEDIUM

    -----------------------------------------------------------------------

As a temporary workaround, we are implementing an override to disable this rule in terrascan.
Describe the solution you'd like
This issue is being raised to track addition of this feature to the module.
We are not remediating this as part of #268 as it falls out of scope for this issue.
This would also require a minor release due to the addition of new resources.
Additional context
This feature requires additional consideration due to the additional complexity associated with the differing needs around Network Security Groups.
For example:

Not all subnets support attachment of a Network Security Group (NEED TO ADD EXAMPLES)
Not all customers will need/want the same Network Security Groups rules
Customers will need the ability to add their own rules to the Network Security Groups

Linking to https://github.com/Azure/ALZ-Bicep/issues/240

Trigger ADO Sync

Trigger ADO Sync

Part of ZT so long term for now, will be part of v.next

AB#27081


feat(cluster): optional local docker registry service

Spin up a VM with docker registry service running on port 80
(available to the cluster as registry.local).

This is out of scope. Thank you anyway.


[Code health] Introduce parameterized tests to GeometryConverterTest

@gino-m Can we close this?

Ideally we'd use parameterized tests throughout, but we can close this since it's really a nice to have in this particular case.


Issue #31 : Module for Heart Beat on static images added

The module causes a block of pixel to change colour at a specific rate.
The size of the block and the rate can be changed using generic mapping.

The HDMI2USB-jahanzeb-firmware is no longer under development.
All active development is now on the HDMI2USB-misoc-firmware which supports both the Atlys and Opsis boards and has loads of other new features!


generate_plugininfo.py -i should say -p

Step 2 under "Contributing Plugins" says to use generate_plugininfo.py -i to generate plugin.json.

Optionally you can use the generate_plugininfo.py -i to interactively walk you through setting the required fields.

It looks like the script has been updated to use -p, just need to update the README :)

Updated, thanks!


[DISCUSSION]: Move xray code to it's own provider

It's currently under consideration to move the xray portion of the provider to it's own TF provider package. This has some advtanages:

Less code clutter in the current code base. Artifactory is a much for feature rich product and takes up the vast portion of this code base.
Currently xray can't be deployed locally (if someone has a local RT+XR setup it would be welcome). Which means that testing is much more complicated as it requires a dedicated stack.
Some users have remapped their infrastructure and /artifactory doesn't resolve to the default API path. This can be more easily addressed if 1 provider doesn't have to accomodate multiple product lines as each could have their own config.

This is an open commentary request from the community

New provider is at https://github.com/jfrog/terraform-provider-xray

@chb0github for what it's worth, I am strongly in favor of this. I think it makes a lot of sense.

Yeah, and it's been released. Have a look and give input


Implement Webauthn 🎉

Summary
Implements Webauthn for most security keys.
Somewhat WIP, but everything should be working!
Resolves #3660

Only issue is the need for Japanese translations and probably better typings (I don't use Typescript so I did my best)

I've also created a small daemon to clean up AttestationChallenges that were never used to make sure the DB doesn't end up getting filled with them

lintはこちらでなおしてあげてもいいかと思います。
contributorにいきなりlint100箇所以上直せってというのはどうかと思います。

batch でワンポチじゃダメですか

batch でワンポチじゃダメですか

私はその方法を知らないし、100箇所以上Resolveを確認する必要はあるのではと

@acid-chicken Sorry, I didn't know there was a proper linter until just now and my own linter (prettier) ended up breaking a lot of your guidelines there. I've applied your suggestions before seeing that there was a linter..
The one thing I'm confused about is how best to deal with the try {} catch() {} with a var inside it. I think in this case, it makes sense to use var because it will expose it to the context of the function itself and there cannot be any conditions where data would be undefined
I would also really appreciate if someone with a fido-u2f key (Yubikeys and other older keys do this) could make sure this works for them because my keys only do packed attestation.

ありがとうございます。
AttestationChallenge テーブルが UserProfile テーブルと一対一なら、テーブルを分けずに UserProfile テーブルに新しくカラムを追加した方が良いと思うのですが、新しく AttestationChallenge テーブルを追加した理由は何でしょうか？
Thank you very much.
If the AttestationChallenge table is one-to-one with the UserProfile table, I think it would be better to add a new column to the UserProfile table without splitting the table. What is the reason for adding the new AttestationChallenge table?

@syuilo It is possible that a user may have more than one challenge available to them. For example, if the user starts registration of a key and also logs in with a different key at the same time or similar. Perhaps an attacker could still lock someone out of their account with just their username and password by generating new challenges every 10 seconds so the real user's challenge was always invalid by the time they went to use their security key which would largely defeat the purpose of 2FA.

I'm also currently working on supporting some more attestations on my local copy (android-safetynet, android-key, none) as well as some yubikey u2f fixes (I found a friend with a yubikey to test with)

It is possible that a user may have more than one challenge available to them.

understood. Thank you!
@acid-chicken @mei23 @rinsuki OneToOneをManyToOneに変更した方が良さそう？

The above commits should add support for android N and later's built-in security keys and 'anonymous mode' on Yubikeys (which appears to actually be outside of spec, but they do it anyways)

Is it possible for one user to have multiple UserSecurityKeys?

@syuilo Yes, this is useful if you have a backup key, a wireless key for a phone, or just an extra key. (People got mad at Twitter for not allowing more than one key to be registered, so I figured this was the best option)

I simplified some ID column names. Seems good?

@syuilo your commit above will break the frontend, (also: credentialId in this case is generated by the security key, so I'm not sure moving it to id is a good plan anyways)

@syuilo Login uses credentialId also to tell the browser which security key(s) to give the challenge to

@syuilo Why has CircleCI has been stuck pending since I opened the PR? Is it just not set up properly? or did I do something wrong?

@Mstrodl CI was broken in the past and the patch #4909 is waiting for merge. So you can ignore these statuses for now.

I added a migration.

I added a japanese translations.
間違ってたら教えて

Currently, the only unsupported attestations are Windows Hello / TouchID on macOS (tpm attestation is super complicated) and android-key, both of which are just due to lack of testing resources. In theory android-key should work, but I haven't been able to test (my device uses android-safetynet)

I can try and help with testing android-key and Windows Hello (also possibly touch id).

二段階認証の設定が完了してない状態でログインしようとすると二段階認証を求められるバグがありますね

@syuilo Apologies! This is due to a missing check for the status of 2FA on the frontend. This should hopefully be fixed now! (Along with the error on the janitor daemon caused by a missing cast to Date)

Is it okay to merge?

jsrsasign.d.ts を待ってほしい

@acid-chicken jsrsasign.d.ts?

@Mstrodl No, that is too small. I've written almost 500 lines of code, but it's still a work in progress.

@acid-chicken oh, I assumed you'd just implement the things our code used at first

@acid-chicken any progress?

@syuilo almost done

@syuilo done so please review

とりあえずマージします
皆様ありがとうございました 🙏
Thank you guys 🙏


1.4.1 binary to address #351

@kbhomes Thank you for merging #352 to get #351 closed. When can end users expect a 1.4.1 binary to address the issues in #351 without having to download a patched older beta binary?

... In the meantime, it's very straightfoward to compile your own using xcode.

@rwoodpecker Not everyone knows how to do that. I also tried to compile Radiant with Xcode and it didn't work for me. It would just be helpful to see that integrated for the end user's sake.

Definitely agree. I can upload a compile a binary of the latest code, if people are interested while we wait for @kbhomes to do release his own.

@rwoodpecker please do.

@gasperk Give this a shot https://www.dropbox.com/s/fhep4abttrim1or/Radiant Player.zip?dl=1 Was compiled on Xcode 7 on El Capitan GM, fingers crossed it works.

@rwoodpecker working for me on El Capitan.  Thanks.

@rwoodpecker Working for me on Yosemite. Thank you for this.

@rwoodpecker works for on Yosemite as well. Thanks!

Super! Was having the same problems. This build solved it!

@rwoodpecker much appreciated, thank you

@rwoodpecker Thank you! Worked for me on Yosemite!

@rwoodpecker Awesome work, thank you.

@rwoodpecker Works for me as well. Thanks!

HUrray to you.. it work again. Thanks!

@rwoodpecker Thanks Man!

yaaaaaahoooooo
it works after 2 months of using ugly google chrome player

In case anybody needs it ASAP, I've pushed an updated build with El Capitan support here: https://github.com/jacobwgillespie/radiant-player-mac/releases/tag/v1.4.0.  As before, as soon as @kbhomes gets 1.4.1 out, switch to that.  :)

Does anyone have any idea why it is taking so long to get out a new binary? It's a complete showstopper of a bug. It was reported a month and a half ago, and the fix was merged over three weeks ago. Is it a lot of work to get it out, or has this project been abandoned?

I think developers who are interested in maintaining Radiant should consider moving the project into an organization, so we can get pull requests merged faster and make it easier to get distributed versions into the hands of end-users. @kbhomes has done great work, but we need more than one maintainer for an app with this much popularity.

I guess some sort of clarification from @kbhomes would be helpful. If he cannot keep working on this project then him saying so could get the ball rolling. Because of the radio silence, everyone is just going around saying that any day now, the new binary will be out, and things will be back to normal. That may not be the case.
This is a really great app, but right now it is completely broken. And for most casual users (me included), going to the github repo and reading through issues to seek out Dropbox links to unofficial builds is probably a bit off-putting.

@okvs Most people would not know this unless you look through lists of issues. We need a group of maintainers in order to keep a constantly changing wrapper like this up-to-date.

@kbhomes Thank you for finally fixing this issue, however I do think we need more discussion about adding other collaborators to this project to address issues quickly. Closing for now.

I don't know if it's only me, but now I can't authorize my last.fm user.

@spoulin No, same. Not scrobbling, so deauthorized and now it won't let me authorize again.
Am going to go through the old issues and see if any of the compiled versions linked to from dropbox are working.


Fix example urls 2861

Closes #2861
Describe your proposed changes here.

[ ] Signed the InfluxData CLA
(if necessary)
[ ] Tests pass (no build errors)
[ ] Rebased/mergeable

@sanderson This might solve the URL and hostname replacement, but needs more testing.


Update index.md with link to correct example files

Suggested change for #7686 pointing to the correct repository for the example directory.
May require adaptation to point to the correct branch if desired, but I didn't know how to do that. I think this is an improvement nevertheless.

I just see k8s201.md will probably need the same change.

/assign

I just see k8s201.md will probably need the same change.

OTOH, k8s201.md uses http references like https://k8s.io/docs/user-guide/walkthrough/deployment.yaml so the introductory paragraph may as well be omitted.

@drx777 Thanks for updating the links, but could you please retain the original language? We don't need to be quite so precise about how to use git ;).

Maybe it's better to adapt the 101 to the 201 style with full http links to the yaml files and remove that paragraph completely from both doc files.

@drx777 there's an interesting quandry with referencing the links externally, which boils down to older versions of the docs reference the latest examples, rendering them incorrect for older versions (see #8051 for more detail on that).
I appreciate the thought of this PR, but agree with @Bradamant3 that the detail is likely overkill on how to use git with the examples and the original language is better. In addition, it looks like the file has been updated since your PR originated, and at a minimum it needs a rebase.
I'd encourage you to update the content with the examples a bit more inline as a possible solution, rather than referencing the content that will be varying over time as examples.
/assign

👋 We've migrated the site's framework to Hugo. Please re-open this PR with changes to files in their post-migration location (/content/en/docs/...).


⚠ Bofrost.at has degraded performance

In 63fc95d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1649 ms

Resolved: Bofrost.at performance has improved in c64fbf8 after 311 days, 18 hours, 16 minutes.


if it can use for  matter bridge  server?

Can you please add some more content to your question?
If the question is if this library can be used to provide a Matter compatible device server to offer multiple bridged devices, the the answer is:

Right now: no
Is it planned that this is possible: Yes

If you want to collaborate to add support please check out the "DIscussions" senctionsabout implementing the missing Matter clusters and see if you can support here.

See https://github.com/mfucci/node-matter/discussions/45 for the current cluster support.
Right now this can be used as a bridge server to control an on / off device, if it can controlled from the command line:
matter -on "echo 255 > /sys/class/leds/led1/brightness" -off "echo 0 > /sys/class/leds/led1/brightness"
This will start a Matter server that can turn on / off the LED on the raspberry Pi, but any other shell commands can be issued instead.
We are working on supporting more clusters that will allow to control other device types and we are welcoming contributors to implement specific bridges (BLE, Zigbee, etc...)
Closing this issue, please continue the discussion on the forum if you are interested in helping or testing!


Fix: Setting extra headers

The previous implementation was probably a copy+paste error. Now the headers are properly set in the headers hash already present via the Headers module.
Fixes #3

Closed with another PR fixed https://github.com/sanzstez/gotenberg-ruby/pull/5


Benches

Is there any bench available?
In particular, I'd like to see if we could try changing the write_paquet part (for large paquets) to:
// ...
let mut writer = Vec::with_capacity(4); // could probably be out of the chunks loop
try!(writer.write_le_uint_n(chunk_len as u64, 3));
try!(writer.write_u8(seq_id));
// try!(writer.write_u8(chunk));
try!(self.write_all(&writer[..]));
// instead of copying the entire chunk into the writer,
// we could write it directly to the stream
try!(self.write_all(chunk));
// ...

On my test it seems to be better but I am really not certain.

Yeah.
You should switch to nightly in your multirust, then run make bench.
It will run benches for all feature combinations.
But this, obviously, will work only on linux or mac.

Thanks!
I've just tried cargo bench.
On 22 Feb 2016 19:14, "AnatolyI"<EMAIL_ADDRESS>wrote:

Yeah.
You should switch to nightly in your multirust, then run make bench.
It will run benches for all feature combinations.
But this, obviously, will work only on linux or mac.
—
Reply to this email directly or view it on GitHub
https://github.com/blackbeam/rust-mysql-simple/issues/41#issuecomment-187127507
.


Hwang schema demo

Hi Erik,
Thanks for merging. I should have split the change into multiple commits.
Regards,
Hongwu
On Tue, Aug 25, 2015 at 2:16 PM, Erik Niemeyer<EMAIL_ADDRESS>wrote:

Merged #1 https://github.com/01org/vmf/pull/1.
—
Reply to this email directly or view it on GitHub
https://github.com/01org/vmf/pull/1#event-392162379.

Would be good to move the new Cmakefile to the root. If you don’t want to do it let me know and I will.
From: Hongwu Wang<EMAIL_ADDRESS>Sent: Tuesday, August 25, 2015 4:20 PM
To: 01org/vmf<EMAIL_ADDRESS>Cc: Niemeyer, Erik A<EMAIL_ADDRESS>Subject: Re: [vmf] Hwang schema demo (#1)
Hi Erik,
Thanks for merging. I should have split the change into multiple commits.
Regards,
Hongwu
On Tue, Aug 25, 2015 at 2:16 PM, Erik Niemeyer <notifications<EMAIL_ADDRESS>wrote:

Merged #1 https://github.com/01org/vmf/pull/1.
—
Reply to this email directly or view it on GitHub
https://github.com/01org/vmf/pull/1#event-392162379.

—
Reply to this email directly or view it on GitHubhttps://github.com/01org/vmf/pull/1#issuecomment-134758603.

Hi Erik,
If we move the CMakefile to the root, we might need to update building
instruction documentation. If so, we need to make sure the document gets
updated at the same time.
Thanks,
Hongwu
On Tue, Aug 25, 2015 at 7:02 PM, Erik Niemeyer<EMAIL_ADDRESS>wrote:

Would be good to move the new Cmakefile to the root. If you don’t want to
do it let me know and I will.
From: Hongwu Wang<EMAIL_ADDRESS>Sent: Tuesday, August 25, 2015 4:20 PM
To: 01org/vmf<EMAIL_ADDRESS>Cc: Niemeyer, Erik A<EMAIL_ADDRESS>Subject: Re: [vmf] Hwang schema demo (#1)
Hi Erik,
Thanks for merging. I should have split the change into multiple commits.
Regards,
Hongwu
On Tue, Aug 25, 2015 at 2:16 PM, Erik Niemeyer<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

Merged #1 https://github.com/01org/vmf/pull/1.
—
Reply to this email directly or view it on GitHub
https://github.com/01org/vmf/pull/1#event-392162379.

—
Reply to this email directly or view it on GitHub<
https://github.com/01org/vmf/pull/1#issuecomment-134758603>.
—
Reply to this email directly or view it on GitHub
https://github.com/01org/vmf/pull/1#issuecomment-134790631.


Don't crash when not all Design Tokens frames are found

Is your feature request related to a problem? Please describe.
I have no need of all Design Tokens-types, so I don't have all the required frames in my Design Tokens page.
I then get this crash when running Figmagic:
Error: Error: Error: Error: Error: Error: Error: Error: Error: Error: ENOENT: no such file or directory, open 'MYPROJECT/tokens/letterSpacings.ts'

Describe the solution you'd like
Silently skipping missing frames, maybe just mentioned with a console text line
Describe alternatives you've considered
Creating empty frames

Hi @tomsoderlund,
Are you syncing elements? I see the same behavior if I have "syncElements": true but it's not giving this error if it's set to false.
I'll see what I can do, but given that it can't infer values without tokens (ergo, values) it's not surprising it breaks.

@mikaelvesavuori You're right! Only for elements. Closing.

Hey, I fixed this anyway :) Coming shortly in 4.0.15.

@mikaelvesavuori Amazing! Thank you


What coverage settings?

Here are a bunch of questions about the coverage settings:
A:

[ ] We need to change the default settings, this can be done using a yml configuration file. This file can be located:

In the project repo, named codecov.yml.
On codecov.io website for MFEM org: https://codecov.io/account/gh/mfem/yaml

Locally means version controlled, changes impact only branch up-to-date. Remote means not version controlled, act for all mfem org repos, can be edited only by project owners, changes impact all branches.

B:

[ ] The coverage results can:

Never impact the CI status.
Impact the CI status when coverage drops a certain percentage compared to the base.

Codecov Github App adds coverage status in the checks, in the patch/diff, in the PR.
C:

[ ] Patch status (annotations in the PR diff) can:

Be toggled with the "a" key.
Be deactivated in the yml config file.

D:

[ ] The status in the PR can be customized. I think we want it shorter. Thoughts welcome.

A: 1
B: 2
C: 2
D: shorter

A: fine with both
B: 2
C: 2
D: shorter

A: 1
B: 2
C: 2
D: shorter

Agreed with all of these

A: 1
B: 1, also ok with 2
C: 2
D: is this about the posts from the "codecov" bot in PRs? This can be seen if you click on the "details" link next to "codecov/project" in the PR checks, so we can even disable the "codecov" bot posts.
By the way, I get "Unauthorized" if I click on "View this Pull Request on Codecov" on the "details" page -- I thought the coverage information is public? Is there a reason to restrict this?
Essentially, for me, the only thing from codecov I'd like to see on PRs are the "codecov/project" checks showing the coverage change (don't block PR merging because of this) and the "details" link for more info, if I want to look.


current cycle card

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] (if relevant) I have tested this PR in all supported browsers.
[ ] (if relevant) I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #3611

PR #3612

PR #3613

PR #3614

PR #3615

PR #3616   👈

This comment was auto-generated by Graphite.


Finish event is emmited too early ?

var read = request.get('http://files.sa-mp.com/samp03dsvr_R2.tar.gz');
var write = targz().createWriteStream(server.data.path);
write.on('finish', function () {
    exec("cd path; ls", function (err, stdout, stderr) {
        console.log(stdout);
    });
});
read.pipe(write);

This gives output of:
announce
gamemodes
include
LICENSE
README
samp03svr
samp-npc
However folder like "filterscrips" is also unzipped but not yet shown. If I do setTimeout on exec command it all shows good.

this might be related to #20


Issue while trying to build project

Describe the Bug
Not sure if this is the right place to enquire about this issue.
Seems when I am trying to build my project I will get this issue
`
Execution failed for task ':react-native-track-player:generateReleaseRFile'.
Could not resolve all files for configuration ':react-native-track-player:releaseCompileClasspath'.
Failed to transform KotlinAudio-dd4bdab147c90fffcff7800790dbfcb41291d29b.aar (com.github.DoubleSymmetry:KotlinAudio:dd4bdab147c90fffcff7800790dbfcb41291d29b) to match attributes {artifactType=android-symbol-with-package-name, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-api}.
Could not find KotlinAudio-dd4bdab147c90fffcff7800790dbfcb41291d29b.aar (com.github.DoubleSymmetry:KotlinAudio:dd4bdab147c90fffcff7800790dbfcb41291d29b).
Searched in the following locations:
https://www.jitpack.io/com/github/DoubleSymmetry/KotlinAudio/dd4bdab147c90fffcff7800790dbfcb41291d29b/KotlinAudio-dd4bdab147c90fffcff7800790dbfcb41291d29b.aar
`
Previously I followed the steps and ran a patch for the library, not sure if this will cause any issue
https://github.com/doublesymmetry/react-native-track-player/issues/296
Steps To Reproduce
just do a gradle assemble
Code To Reproduce
N.A
Replicable on Example App?
N.A
Environment Info:
on the CI environment
How I can Help
May need help to see if there is anyway to put back the AAR file

The url for
https://www.jitpack.io/com/github/DoubleSymmetry/KotlinAudio/dd4bdab147c90fffcff7800790dbfcb41291d29b/
seems to be messed up on their server,
on a separate note, a different version for the seemingly same commit hash is working fine :
https://www.jitpack.io/com/github/DoubleSymmetry/KotlinAudio/dd4bdab147c90fffcff7800790dbfcb41291d29/
[last letter b is different]
could possibly solve your build issues for the time.

Got Execution failed for task ':react-native-track-player:generateReleaseRFile'. as well

Whoah, crazy, super big ups for the solution @oddlyspaced 🙌
Why is the diff the same for these two commits but the hash is one letter off? This violates all of my priors about how commit hashes work:

https://github.com/doublesymmetry/KotlinAudio/commit/dd4bdab147c90fffcff7800790dbfcb41291d29
https://github.com/doublesymmetry/KotlinAudio/commit/dd4bdab147c90fffcff7800790dbfcb41291d29b

Thank you! Seems like it is building correctly after i changed the reference in the patch file :)

@dcvz this is... quite strange. My guess is that its some problem with jitpack, but want to make sure it's not the build process.
In a nutshell
dd4bdab147c90fffcff7800790dbfcb41291d29b is a real commit, however it doesn't exist on Jitpack
Simultaneoulsy dd4bdab147c90fffcff7800790dbfcb41291d29 is a valid commit sha too (only different by the missing b from the previous commit). This sha however does exist on jitpack
Regardless I'm going to close this issue as we're not pointing at that version of KotlinAudio anymore, so it should be resolved in the latest version.

Anyone experiencing an issue again? I see few changes have been made in the last hour, wonder if it invalidated the patch?
[stderr]
Could not determine the dependencies of task ':app:buildReleasePreBundle'.
[stderr]
> Could not resolve all task dependencies for configuration ':app:releaseRuntimeClasspath'.
[stderr]
   > Could not find com.github.DoubleSymmetry:KotlinAudio:dd4bdab147c90fffcff7800790dbfcb41291d29.

it is not working for me :(


React Native Packager Compatibility Tip

Relevant to client 2.0.0-beta-4
Right now Horizon client is broken for React Native straight out of the box (through NPM). React Native tries to package all of a project's dependencies with its own packager. The packager checks all packages for babel configs and will try to use the package's babel config to pack the files properly. However, something seems to be wrong with it trying to use es2015-loose. The best workaround I found so far is to just remove the babel configs so that way React Native will try to package it with its own default settings (which works out well). I'm submitting this PR so that anyone else trying to work with RN on horizon v2 beta can at least start experimenting.
It's extremely hacky, if there's something is in the works to fix this permanently that would be great. Would also be awesome if someone else could validate this indeed fixes it and isn't some weird coincidence. Perhaps it would be also good to note that the current stable is not compatible with RN.

This change is

FWIW I'm using this under scripts.postinstall
// Remove babel dependencies from horizon to make React Native happy

const fs = require('fs');

const filename =<EMAIL_ADDRESS>const fileContent = fs.readFileSync(filename);
const json = JSON.parse(fileContent);
delete json.babel;
fs.writeFileSync(filename, JSON.stringify(json, null, 2));

@benjick : where did you write those script??


Virtual Fibre Channel for a RHEL8 guest not working

[Enter feedback here]
Are you sure that Virtual Fibre Channel works for a RHEL8 guest?
Despite many attempts we could not get this to work on a Windows Server 2019 Hyper-V host with a RHEL8 guest... RHEL appears to recognise the virtual HBA's and even shows the WWPN but it will not recognise it as a block device nor show any of the presented volumes...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 988640af-813f-0ca3-8844-b09cf359f9cf
Version Independent ID: 8be01cd9-2034-f44d-1016-3af62b7f0e15
Content: Supported CentOS and Red Hat Enterprise Linux virtual machines on Hyper-V
Content Source: WindowsServerDocs/virtualization/hyper-v/Supported-CentOS-and-Red-Hat-Enterprise-Linux-virtual-machines-on-Hyper-V.md
Product: windows-server
Technology: hyper-v
GitHub Login: @jperrin
Microsoft Alias: japerrin

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


[FIX] Fix issue with user selection page by updating CSS Selector

As @snowskeleton mentioned in #549 , there is also a sign in issue with the updated CSS in the user selection page. The issue can be recreated by passing your own webdriver but using your own Chrome User Profile that has been previously logged in. Since mint already has a session saved, it should go through the user selection page flow and then raise an error for not finding "Use a different user ID" button.
This PR should address this issue for anyone else going through the user selection page flow.
A side note, but the general new CSS selector trend seems to be data-testid=.

@felciano thanks for testing this! When I was using my Chrome User Profile I had thought Chrome had been just autofilling my username. However, I believe that mint now populates the email input field already with the email from the session. But for some reason email_input.clear() is not actually clearing the value in the email input and so we get the email inputted twice. So my workaround now uses a loop to send backspace keys the length of the email to remove the email autofilled by mint.

@CalvinChanCan have you tried waiting for the element to be clickable to make sure that we can actually click to clear?
https://stackoverflow.com/a/49151715

@burkematthew Thanks! The waiting for the email_input to be clickable worked! I added in the WebDriverWait and changed it back to clear the input rather than the workaround with the backspaces.

@burkematthew So I took a closer look and had thought waiting for the email input and then attempting to cleared it work. But I accidentally removed email_input.send_keys(email) so it had been using the email address from the session already.
I tried waiting for the email input, then attempted to add the email to the email but its showing up as "USERNAME USERNAME" again. From the stackoverflow link, I tried adding a click before inputting the email but still getting not able to successfully clear the email.
        email_input = WebDriverWait(driver, 20).until(
            expected_conditions.element_to_be_clickable(
                (
                    By.CSS_SELECTOR,
                    '#ius-identifier, [data-testid="IdentifierFirstIdentifierInput"]',
                )
            )
        )
        if not email_input.is_displayed():
            raise ElementNotVisibleException()

        email_input.click()
        email_input.clear()
        email_input.send_keys(email)

I tried 1d8ce4e and it is now completing the login sequence as expected (username, password and MFA), but then fails out on a
selenium.common.exceptions.WebDriverException: Message: disconnected: received Inspector.detached event

which was not happening before. Are you seeing this as well? This is with a default mintapi call using soft-tokens:
poetry run mintapi --keyring --mfa-method=soft-token --mfa-token "SOFTTOKEN" "USERNAME"

@CalvinChanCan actually I'm fairly certain that the above received Inspector.detached event is #546 and independent of the login issue this patch is trying to address. From my perspective, this patch successfully re-enables automated login and is good to go

Hmm I'm not quite sure this patch is working as intended. It certainly is getting through the user selection page but its odd that it does when I accidentally left out email_input.send_keys(email). So what I think is happening is that mint is still using the email from the session rather than the email we're passing into the mintapi constructor.
I have tried a few ways of trying to get the email to successfully clear but haven't found anything that works besides the backspace method. @burkematthew , do you have any thoughts if we should revert back to the backspace method or what we can do to resolve this issue?

I believe this patch fixes #545 (referenced here to track it)

I'll close this PR since this does not seem to be an issue.


Add link to statinamic in boilerplate README

[skip ci]

Current coverage is 67.57%

Merging #327 into next will increase coverage by +0.24% as of 8bb9ef1

@@             next    #327   diff @@
=====================================
  Files          42      43     +1
  Stmts         548     552     +4
  Branches        0       0
  Methods
=====================================
+ Hit           369     373     +4
  Partial         0       0
  Missed        179     179

Review entire Coverage Diff as of 8bb9ef1

Powered by Codecov. Updated on successful CI builds.


CVE-2016-0751 incorrectly flagged for Rails 4.2.6

This CVE was fixed in <IP_ADDRESS>. 4.2.6 is greater than <IP_ADDRESS>, so it should not be vulnerable. Yet, dawnscanner is reporting a vulnerability.

Also wrong for 4.1.15 (fixed in <IP_ADDRESS>).

I think this might also affect a number of other CVEs, for example CVE-2016-2098 or CVE-2015-7577:

(Ruby) actionpack : 4.2.6
Possible remote code execution vulnerability in Action Pack
https://groups.google.com/forum/#!topic/rubyonrails-security/ly-IH-fxr_Q
Possible Object Leak and Denial of Service attack in Action Pack
https://groups.google.com/forum/#!topic/rubyonrails-security/9oLY_FCzvoc
Object leak vulnerability for wildcard controller routes in Action Pack
https://groups.google.com/forum/#!topic/rubyonrails-security/dthJ5wL69JE
Timing attack vulnerability in basic authentication in Action Controller.
https://groups.google.com/forum/#!topic/rubyonrails-security/ANv0HDHEC3k
(Ruby) actionview : 4.2.6
Possible Information Leak Vulnerability in Action View
https://groups.google.com/forum/#!topic/rubyonrails-security/335P1DcLG00
(Ruby) activemodel : 4.2.6
Possible Input Validation Circumvention in Active Model
https://groups.google.com/forum/#!topic/rubyonrails-security/6jQVC1geukQ
(Ruby) activerecord : 4.2.6
Nested attributes rejection proc bypass in Active Record
https://groups.google.com/forum/#!topic/rubyonrails-security/cawsWcQ6c8g

(Output from a tool, which probably uses dawnscanner in the background, I think.)

Hello,
https://github.com/thesp0nge/dawnscanner/pull/205
Should resolve the false positives for CVE-2016-0751  and CVE-2016-7577


Flight API cleaning function

Data-cleaning function to produce destination Object

Assume you have picture object
Assume you have Flight object sample data
Produce a destination Object


Fail with error 'AS'

Hi guys,
New error here, I will continue my tests.
Fail with error 'AS'
Contract address: https://polygonscan.com/tx/0xf976a46752e1d447b9681b88ff52e6eda63db3b590f27b932492a40aab2854f7

Duplicate of #18


Avoid creating Secp context every time

Describe the enhancement
Secp256k1::new() is an expensive operation (IIRC hundreds of milliseconds), avoid multiple calls by using:

The provided static context https://docs.rs/secp256k1/0.26.0/secp256k1/static.SECP256K1.html
Lazy initialize the context once and reuse across https://github.com/Blockstream/gdk/blob/4058b0685e90fd1112e3b6bac5ea7ebeca00e8df/subprojects/gdk_rust/gdk_common/src/lib.rs#L33

Use case

Additional context

Thank you for the suggestion!


Terrain bounding sphere

The terrain tile bounding spheres and occludee points were computed from the quantized, packed vertices.

What was the issue?  The bounding spheres and horizon culling points were wrong when terrain was exaggerated?

What was the issue? The bounding spheres and horizon culling points were wrong when terrain was exaggerated?

Exaggerated terrain and heightmap terrain. Are the bounding spheres used for anything? The OBBs are used for culling and the lat/lon/alt rectangle is used for getting the distance to the tile.

The spheres might be used for multifrustum selection - or did you change it to use the OBB?

The spheres might be used for multifrustum selection - or did you change it to use the OBB?

Ah right, I never changed that. We could bin the OBB, but it would be much slower than using a sphere.

Update CHANGES.md in master.


Switch to using http://archives.wellcome.org for the CALM adapter

Currently we use https://archives.wellcome.ac.uk, but Wellcome proper are trying to phase out the old domain name.
The dot org domain is only available over HTTP, so I'm waiting to see if we can get an HTTPS certificate before we start fetching archive data.

Woohoo, Louise managed to get an HTTPS cert. Let's try it.


Updated the GKE version and syntax yaml files

Notes for Reviewers
This PR fixes syntax of YAML files and updates GKE version
Signed commits

[x] Yes, I signed my commits.

Reviewing again. No changes since last feedback offered.

GKE versions : 1.29.1-gke.1575000
If required please refer: https://cloud.google.com/kubernetes-engine/docs/release-notes

PR abandoned.


[BUG] Azure database status is 'Online' when its 'Paused'

Library name and version
Azure.ResourceManager.Sql
Describe the bug
The core problem appears to be related to Azure Status handling. I have a database 'TestDB' set with an auto-pause delay for testing different statuses. In the SQL Databases section, the status is shown as 'Paused'

However, when querying the same database in Azure Resource Graph Explorer, the status is returned as 'Online', which is also the status reflected in my application. This discrepancy indicates some inconsistencies in how the status is being reported.

after a while (like 6-8 hours) status polled as paused
P.S I created same issue before but pointed on the wrong library
Expected behavior
Database status reflecting correctly with auto-pause delay
Actual behavior
Database status does not reflect correctly with auto-pause delay, Azure Resource Graph Explorer returns status as 'Online' for a few hours when on database UI its 'Paused'
Reproduction Steps
1.Create sql DB
2. Set auto-pause delay for 1 hour
3. wait for status to be 'Paused' on UI
4. Go to Azure Resource Graph Explorer and query for DB
5. Find properties of DB
6. Status is 'Online' instead of 'Paused'
Environment
No response

Hey @stashut  , thank you for reaching out to us about the Azure SDK for .NET. Unfortunately, this issue is related to the service side and not the SDK side, so we are not able to help you with it. Therefore, we are closing this issue for now. If you need more assistance, please open an Azure support request. We apologize for any inconvenience this may cause you.
We value your feedback and we want to make sure that your problem is solved. If you think that we have misunderstood your issue or closed it incorrectly, please feel free to comment on this thread and reopen the issue. We will be happy to assist you further. Thank you for your understanding and cooperation.


Add test for #208 to v0.6

Adds a test for the bug discussed in #208  to branch v0.6.x

CI shows that on 1.9 the test fails while on 1.10 the test passes. This was reproduced on two additional Linux machines. Next steps:

remove Julia 1.9 as an option
merge
bump version. Technically this is breaking but we will keep 0.6.x since this branch is about to be retired.


Remove deprecated isArray.js

#8526 deprecated isArray; it should be removed before the 1.69 release.

Thanks @fredj !

Might be another good one for @YoussefV


docs(tutorial/Tutorial): describe your change...

Corrected a small typo from being ‘the app will build is...’ to ‘the app you will build is ...’

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Fix/Feature: Docs have been added/updated
[ ] Fix/Feature: Tests have been added; existing tests pass

Other information:

I signed it
On Friday, September 28, 2018, googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version https://opensource.google.com/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular.js/pull/16704#issuecomment-425352974,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQN7BZdYe5KoeslBUhDkOXZ6BjZn9j9sks5ufdXagaJpZM4W-BNi
.

--
Regards,Omar

I assume this was opened by accident.

Yes appologies I thought a word was missing.