isabelle: Use vampire and eprover from nixpkgs

Motivation for this change
The newest version of vampire is no longer under an unfree license, it changed to BSD3. This PR updates vampire and replaces it and eprover for isabelle. spass was not replaced because apparently there are some isabelle specific patches.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Thanks!


Mac Address list wifi info

It is possibile retrieve MacAddress of list wifi ?

+1 on this question and also is there an IOS implementation on the pipe or is this project working only for android ? thanks for the repo. Regards.


Error on export final results of review in Excel format

Describe the bug
After completing the review, when i try to export the result, the error comes as : "Failed to export the xlsx dataset. Send_file() got an unexpected keyword argument 'download_name' Please try again."
To Reproduce
Click export results  After completing review , selecting excel file as export result. Same issue happens if i select any other export format such as CSV.
Version information

OS: Windows 10
ASReview version 1.0

Additional context
Add any other context about the problem here.

Could you share a screenshot of the CLI?

I did share CLI above. Sorry, this is my first time using Github

Here is CLI screenshot

Can you try pip install --upgrade flask?
See https://flask.palletsprojects.com/en/2.1.x/changes/#version-2-1-0
Hope this helps.
@asreview/asreview-core please do not close this issue in case this answer solves it. We have to bump the minimal flask version.

Can you try pip install --upgrade flask?
See https://flask.palletsprojects.com/en/2.1.x/changes/#version-2-1-0
Hope this helps.
@asreview/asreview-core please do not close this issue in case this answer solves it. We have to bump the minimal flask version.

Thank you very much for the assistance. The issue resolved after upgrading flask as per instructions.


Support logging.file.path

FIX #416

@glmapper The Codecov result is not generated in this thread, is there something wrong with our Codecov configuration?


Added 'praqma' (jenkins-wiki user) to access list

I've added the user 'praqma' to both ClearCaseUCM plugin and ConfigRotator plugin. This user does not have a github account, but he has upload permissions.

It should be noted that 'praqma' is an automation user, that is only used when we release components in our pipelines. So he's not exactly able to comment in this context :)

:+1:

👍


Drop Underreact

See https://github.com/mapbox/mr-ui/issues/168#issuecomment-1176489528 for context. I have a working branch that uses create-react-app so let's go with that!

Closing as completed in #165


Wrap view around its content

How to wrap view around its content? I want to make View black border and backgroundColor around children text, but no luck.
'use strict';
var React = require('react-native');
var {Text, View} = React;
var Generated = React.createClass({
    render(){
        return (
            <View>
                <View style={{position:'absolute', top: 50, left: 50, borderWidth:2,backgroundColor:'red'}} onLayout={(evt)=>console.log(evt.nativeEvent.layout)}>
                    <Text style={{position:'absolute',top:100,left:100}}>Hello world</Text>
                    <Text style={{position:'absolute',top:150,left:150}}>Hello world</Text>
                    <Text style={{position:'absolute',top:200,left:200}}>Hello world</Text>
                </View>
            </View>
        );
    }
});
module.exports = Generated;

This is just like regular css, the problem is that you absolute position the items inside of that container, so it's not factored into layout in the same way. If you are going to absolute position the children then you need to give it a width/height. This kind of question is better suited for StackOverflow or IRC :) Good luck!


Testing this Issue for LiteRT Migration Task

1. System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow installation (pip package or built from source):
TensorFlow library (version, if pip package or github SHA, if built from source):

2. Code
Provide code to help us reproduce your issues using one of the following options:
Option A: Reference colab notebooks

Reference TensorFlow Model Colab: Demonstrate how to build your TF model.
Reference TensorFlow Lite Model Colab: Demonstrate how to convert your TF model to a TF Lite model (with quantization, if used) and run TFLite Inference (if possible).

(You can paste links or attach files by dragging & dropping them below)
- Provide links to your updated versions of the above two colab notebooks.
- Provide links to your TensorFlow model and (optionally) TensorFlow Lite Model.

Option B: Paste your code here or provide a link to a custom end-to-end colab
(You can paste links or attach files by dragging & dropping them below)
- Include code to invoke the TFLite Converter Python API and the errors.
- Provide links to your TensorFlow model and (optionally) TensorFlow Lite Model.

3. Failure after conversion
If the conversion is successful, but the generated model is wrong, then state what is wrong:

Model produces wrong results and/or has lesser accuracy.
Model produces correct results, but it is slower than expected.

4. (optional) RNN conversion support
If converting TF RNN to TFLite fused RNN ops, please prefix [RNN] in the title.
5. (optional) Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Hi, Team
I am closing this issue now because I created this issue to test transfer option for issue migration task of TFLite issue from TesorFlow core repo to respective LiteRT and ai-edge-torch but unfortunately it did not work because "You can only transfer issues between repositories owned by the same user or organization account. A private repository issue cannot be transferred to a public repository." here is reference
Thank you.


Icon not showing up

The icon in the url bar stopped showing up recently. I de/reactiviated the extension and cleared my chromium settings. Neither worked.

Can you provide more details?  Chromium version, example website where it does not appear?

Sorry to piggyback on thread, but I have same problem.
Works 1st time when extension installed.  Icon does not show up after restart of computer.
Detail:  45.0.2422.6 (Developer Build 4bbc55206b39e2dbecefed256d99f1fd16a22b36 Chromium OS)

When you look in chrome extensions, is the extension still installed and not disabled?

Extension is enabled.
Tried a windows 7 machine with Chrome browser.  The extension CKP works correctly on windows.
Still no icon on machine with Chromium OS.

I was not able to reproduce the problem in Chromium 45.0.2454.101

I am having the same issue with the icon not showing up.  I'm using Chrome Version 47.0.2526.80 m on Windows 7 Professional.  I don't think I have Chromium installed - is that needed?

For me CKP is working on a macbook and windows 7 computers.  No luck on Chromium.
Chromium is the same OS that is used on Chrome books, but is the free version.  I re-purposed an old windows computer by deleting the windows OS and installed Chromium.
in your chrome's address bar put:  chrome://extensions/
check that all options are set correctly.


Disclaimer data privacy policy

added a disclaimer about the data privacy policy

Hey @NicolasAntoine,
Thanks for the PR to close #8.
The PR lgtm, please send a screenshot of the application displaying the user data privacy notice.

There it is. Don’t hesitate to tell me if it must be modified 😊
De : Vikranth Udandarao @.>
Envoyé : lundi 4 novembre 2024 18:44
À : Vikranth3140/Mental-Health-Support-Chatbot @.>
Cc : Nicolas Antoine @.>; Mention @.>
Objet : Re: [Vikranth3140/Mental-Health-Support-Chatbot] Disclaimer data privacy policy (PR #16)
Vous n’obtenez pas souvent d’e-mail à partir de<EMAIL_ADDRESS>Pourquoi c’est importanthttps://aka.ms/LearnAboutSenderIdentification
Hey @NicolasAntoinehttps://github.com/NicolasAntoine,
Thanks for the PR to close #8https://github.com/Vikranth3140/Mental-Health-Support-Chatbot/issues/8.
The PR lgtm, please send a screenshot of the application displaying the user data privacy notice.
—
Reply to this email directly, view it on GitHubhttps://github.com/Vikranth3140/Mental-Health-Support-Chatbot/pull/16#issuecomment-2455333071, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO55MPAZF2XLS6GFDXT4A5LZ66W5JAVCNFSM6AAAAABRERGZQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVGMZTGMBXGE.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hey @NicolasAntoine,
I can't find the screenshot, please send it again.

Hey @NicolasAntoine,
I can't find the screenshot, please send it again.

Hey @NicolasAntoine,
Thanks for your PR to close #8.
Congratulations on your first merged PR.
Do checkout other repositories to contribute here


Set sensible default for minClockStack

The 'request' capability can optionally create stack traces for any monitoring event in the request that exceeds a given duration. The default is currently set to 0ms, so stack traces are created for every monitoring event, which is very expensive.
This either needs to be disabled by default, or set to a reasonable default threshold value.

The proposal would be to set a default of '-1' for disabled, and allow users to configure if they want stack generation.

Delivered by PR #47


Create a PayloadKey proto type and use it instead of bytes

Is your feature request related to a problem? Please describe.
Currently payload keys are represented in protos as bytes, so every struct using them has to manually serialize from the byte slice, and it's impossible to apply common formatting rules to the Serde data.
Describe the solution you'd like
Add a PayloadKey proto type and use it instead of bytes. Then add a Serde rule to the proto compiler that shapes the PayloadKey serialization to be a base64 string (using transparent to hide the inner byte slice, and the base64 serializer to encode it as base64).

Then add a Serde rule to the proto compiler that shapes the PayloadKey serialization to be a base64 string (using transparent to hide the inner byte slice, and the base64 serializer to encode it as base64).

Unsure about this part, are we currently doing this/applying such a rule anywhere else?

Good catch, we indeed got rid of every custom serde rule and don't do any custom shaping any more.


Add CI

I think adding CI would be nice. Could prevent things like #182

Candidates:

https://www.buddybuild.com/
https://circleci.com/
~~https://travis-ci.org/~~ slow

updated

Candidates:

https://www.buddybuild.com/
https://travis-ci.org/

I'm down for whatever is:

Free
high signal (fast, not flaky)

I think travisci because of popularity is quite slow.. why don't you give buddybuild a try, pick start plans / free

Circle is another option, they are free for open source projects too

@BasThomas circle ci is great, but not free for osx :(

actually i may be wrong about this but it's not an automated process
https://circleci.com/pricing/#faq-section-os-x

We also offer the Seed plan for OS X open-source projects. Contact us at<EMAIL_ADDRESS>for access.

Yes - you'll have to send them an email. I think they respond to them pretty quickly though.

@rnystrom ryan i think you have to enable this as the project owner

let me know if you need help, going on the sites and connecting the repo is pretty simple

@BasThomas @dkhamsing which do you feel is the most reliable?

Both Circle and Travis have been 👍

@rnystrom I've used Circle, Travis, and BuddyBuild.
Travis would be great, if it weren't painfully slow -- even on paid tiers.
BuddyBuild is a super-feature-loaded service. Has a lot of cool stuff built in that you probably won't need but are nice to have. Fast, reliable.
Circle is a no-frills service. Fast, reliable, and lets you SSH into specific builds.
I'm pretty partial to Circle.

I'd vote for BuddyBuild.

All over the place! Leaning towards Circle (Travis has also been a pain with IGLK)

@rnystrom Maybe be worth chucking to towards top of your to-do list? 😄
Would be nice to get a starting point to get a couple tests, and at least make sure things are building!
Maybe even hook up continuous deployment so we get faster builds out to test flight to constantly be looking at latest changes

@rnystrom We good to close this since it should all be working now? 😄


RFC: Create a Packed datatype

As described in #305 we run into problems of overlapping datatypes.
At first we had float for normal data, and uint8, uint32 and uint64 for bitpacked data. Now we add int8 for 8-bit quantized data, so this would still be fine without overlap of datatypes, but later we might have to add uint8 for 8-bit quantized data as well, causing problems.
To further complicate things, the tflite tensors only support types {uint8, int8, int32, int64 }, they don't have other unsigned versions.
In principle we could use the signed datatypes for bitpacking, there's not fundamental difference. One annoying this is that std::numeric_limits<T> returns 7, 31 and 63 bits, respectively, for the signed types, which is why we needed an extra std::make_unsigned in our bitpacking code.
With the int8-quantization coming up, it makes a lot of sense to simply use a new type for our bitpacked data. This will greatly improve readability of the code, and avoid mistakes. For example, if our bitpacking functions only accept a Bitpacked8 datatype, then you can not accidentally pass in an 8-bit quantized tensor. Vice versa, if a function expects an 8-bit quantized tensor, you can not accidentally pass in an 8-bit-bitpacked tensor.
The new type Packed<n> can be defined as follows:
core/packed.h:
namespace detail {

template <int B> struct underlying_type {};

template <> struct underlying_type<8> { using type = std::uint8_t; };

template <> struct underlying_type<32> { using type = std::uint32_t; };

template <> struct underlying_type<64> { using type = std::uint64_t; };

} // namespace detail

template <int B> struct Packed {
  using T = typename detail::underlying_type<B>::type;

  explicit Packed(const T x) : bits(x) {}

  static constexpr int bitwidth = B;

  operator T() { return bits; }

  T bits;
};

Usage:
template <typename T>
void foo(T x) {
  cout << "Bitwidth = " << T::bitwidth << endl;
  // use x as if its a regular uint
}

Or
template <int b> void foo(Packed<b> x) {
  cout << "Bitwidth = " << b << endl;
  cout << "Bitwidth = " << x.bitwidth << endl;
  // use x as if its a regular uint
}

With the explicit constructor, we avoid accidentally casting a normal int to a packed datatype: if we have an int x then a function will accept func( Packed(x) ) but not func( x ).

The operator T() should be discussed. Having it has the advantage that you can use Packed<32> x as if x were an int, without any runtime cost. For example you can do x ^ y to get the xor. However, this also means that if a function expects a regular int, you can pass in a Packed<32> and it will automatically cast. We might not want this, for the reasons described above: if a function expects an 8-bit quantized tensor, we don't want to allow 8-bit bitpacked tensors.
Seeing as we never directly use it as an int except for the xor, we can also overload only the ^ xor operator and not allow any other implicit casts. (This has my preference)

This construction has no runtime or binary-size overhead. This can be seen in the compiler explorer, where the function with Packed<32> has exactly the same generated assembly as the function with uint32_t .

I'm not experienced enough with C++ types and casting behaviour to really comment on what the right implementation of this would be, but I agree that it would be very nice to have an explicit bitpacked datatype - I think it would make the code a lot clearer - so I'm in favour of the idea in principle 👍


Make CanState public

This change enables pattern matching of enum CanState from client code by marking it as pub.
I've also restructured comments so that compiler doesn't complain about missing docs.
Let me know if you think this change requires more thought.

Thanks for the PR!


LoganSquare doesn't detect getters and setters on a list in Kotlin

I've got the following Java file that works fine in LoganSquare:
@JsonObject
public class Hours {
	@JsonField(name = "holidayperiods")
	public List<HolidayPeriod> holidayPeriods;

	@JsonField(name = "openingperiods")
	public List<OpeningPeriod> openingPeriods;
}

When it gets converted to Kotlin it spits the following error: error: @JsonField annotation can only be used on private fields if both getter and setter are present.. I would love to give an exact line for where it's happening, but there's a bug in Kotlin 1.0.6 where kapt doesn't show this. The bug has been fixed for future versions, but god knows when 1.0.7 is gonna be here. This is the Kotlin file used: (I kept nullability so it's as close as possible to the Java version)
@JsonObject
open class Hours {
	@JsonField(name = arrayOf("holidayperiods"))
	open var holidayPeriods: List<HolidayPeriod>? = null

	@JsonField(name = arrayOf("openingperiods"))
	open var openingPeriods: List<OpeningPeriod>? = null
}

And it's decompiled to the following Java:
@JsonObject
public class Hours {
   @JsonField(
      name = {"holidayperiods"}
   )
   @Nullable
   private List holidayPeriods;
   @JsonField(
      name = {"openingperiods"}
   )
   @Nullable
   private List openingPeriods;

   @Nullable
   public List getHolidayPeriods() {
      return this.holidayPeriods;
   }

   public void setHolidayPeriods(@Nullable List var1) {
      this.holidayPeriods = var1;
   }

   @Nullable
   public List getOpeningPeriods() {
      return this.openingPeriods;
   }

   public void setOpeningPeriods(@Nullable List var1) {
      this.openingPeriods = var1;
   }
}

HolidayPeriod and OpeningPeriod compile just fine. This class is the only one that was changed. Any reason to why this is happening?

The only difference between Java List and Kotlin List types is a presence of wildcard: List<X> in Kotlin compiles to wildcard type List<? extends X> because type parameter in Kotlin's List has out variance.
Correct workaround is List<@JvmSuppressWildcards X>, but you can also use MutableList<X> or ArrayList<X>.
Same true for Sets/Collections/Iterables, Maps, Pairs and so on.


[feat] Set Genesis State

Add the set_genesis_state function to BlobstreamX. Should only be callable by the owner.
References
Code from BlobstreamX.sol
https://github.com/succinctlabs/blobstreamx/blob/9e037665c4286c811745b283836a4da67c530547/contracts/src/BlobstreamX.sol#L91

can i work in this?

Hey @andresmayorca do you need any help ?

hey, sorry for the delay, I'm finishing


Add a utility method to bootstrap EmbulkService for ruby-based test

it is hard to write test in Ruby-based plugins. They need this code:
https://github.com/treasure-data/embulk-parser-query_string/blob/cb2e1abb0c3daedc37b5fcf06bb4b78acf5f528e/test/prepare_embulk.rb
If embulk has a utility method to run it, writing test becomes easier.

#255 improved but still not verbose.

Fixed by #268.


Documentation for tsx overriding via build script

Original Discussion: https://www.pika.dev/npm/snowpack/discuss/207
/cc @fabiancook, @FredKSchott
Documentation should have an example script, something like this:
  "scripts": {
    "build:tsx": "esbuild --jsx-factory=h --jsx-fragment=Fragment --loader=tsx"
  }

In the added docs, we should mention that this is already done for you by default, but needed if you want to define your own esbuild arguments.
@fabiancook are you able to take a look at adding?

Yep, will put in a pull request for this some time this week

Resolved via dd3318f


int.tryParse strange behavior

Hello, Dart Team!
I expected that this code will return 1 (as integer), but it is returned null.
double d = 1.0;
final fromVariable = int.tryParse(d.toString());
print( '- double var--> ' + fromVariable.toString());

console output
I/flutter (24950): - double var--> null

Also i try it in sandbox on https://dart.dev/#try-dart and it is work properly.
Few more examples:
final tryParseStringDQ =  int.tryParse("1.0");
print('=== string ===> ' + tryParseStringDQ.toString());

final tryParseDouble =  int.tryParse(1.0.toString());
print('--- double ---> ' + tryParseDouble.toString());

console output
I/flutter (24950): === string ===> null
I/flutter (24950): --- double ---> null

But in sandbox out put will be
=== string ===> null
--- double ---> 1

See screenshot of sand box  with all examples
SDK Version
flutter --version
Flutter 1.12.13+hotfix.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 27321ebbad (5 days ago) • 2019-12-10 18:15:01 -0800
Engine • revision 2994f7e1e6
Tools • Dart 2.7.0

OS Version
Windows 10 Home
Version: 1809
OS Build: 17763.914

Thank you for your attention!

The reason is that '1.0' cannot be parsed to a valid integer. You can see the actual error if you use parse instead of tryParse:
Unhandled exception:
FormatException: Invalid radix-10 number (at character 1)
1.0
^

#0      int._throwFormatException (dart:core-patch/integers_patch.dart:133:5)
#1      int._parseRadix (dart:core-patch/integers_patch.dart:144:16)
#2      int._parse (dart:core-patch/integers_patch.dart:102:12)
#3      int.parse (dart:core-patch/integers_patch.dart:65:12)

The reason why it works in the DartPad is that this is running as JavaScript where there are no difference between the types int and double. In JavaScript the toString() method on your 1.0 value will actually print 1 and not 1.0 which is why the tryParse method works in your example.

Thank you for your response.
It was not obvious that DartPad use JS instead DartVM.


Colour contrast issue with code examples

The colour contrast ratio of code examples using the light theme don't meet the minimum contrast ratio of 4.5:1 for small text.
This is a failure of WCAG success criterion 1.4.3 Contrast (Minimum).

Consider using one of these: https://github.com/PrismJS/prism-themes


RemoteStoreSorting inside remote-store-all.js

class typo error

@asciicode The class name needs to be RemoteStoreAll instead of RemoteStoreSorting, is that what you are indicating?

yup

Pull requested #1635
Thanks @asciicode :+1:


Enhancement: re-design course to create profile README.md

We could revise this course, or create a fork of this course with a separate project to account for people that already have profile READMEs, so that the template repository is the project template repository will actually create a README.md that will appear on the user's profile.
cc @githubtraining/programs

There's enough other courses that do the current style, so I'd love to relaunch this course as the profile readme course.
If it makes sense to do it as a separate course and retire this one I'd be cool with that, too!


[suggestion] different base layer for heatmaps

first: I am colorblind
Seeing the heatmaps there are a lot of the same colors (city) - yellow to red for heat and orange(?) for streets and such. All bright colors.
I coded myself so my local version uses satellite basemap as a quick fix. But for a wishlist I would like a darker basemap that can be chosen via config
Possible very dark map layer:
https://carto.com/location-data-services/basemaps/
dark matter map (second pic and below some code I found)

Are reports still using google maps? If they're still google, they will be leaflet soon, which has lots of different options.
#186
I suggested changing the main map too.

yeah reports still run gmaps - and my request

Note: soon means Soon™.
I found out that changing the tile layer in Leaflet is very easy (just change URL in one place). In the beginning I also thought of using grayscale map (to make Pokemon stand out more), but the Carto map requires an API key (which I don't want to use, due to all the hassle with Google Maps key and putting it in the config).
There's an existing discussion about maps provider in #186.


Web Audio Sound objects massive memory leak in, at least, Chrome

In, at least, Chrome there will be massive memory leaks if you try to stop and disconnect an AudioBufferSourceNode at the same time. Phaser started doing that with this commit: https://github.com/photonstorm/phaser/commit/1990bce48b82b85b487cac0b0f990caede4d8c2d
I have been digging deep into this one and there is a thread in the forums about it:
http://www.html5gamedevs.com/topic/19339-audio-memory-usage-headache/

Have a go at the dev branch version (you'll need to run grunt to build it), which reverses the stop / disconnect process.

Don't suppose you know if the recent updates resolved this or not? Would like to close this one off, but am reluctant until I'm sure it's dead.

Sorry, I haven't had time to work on the project that this bug appeared on for quite some time.
I'll try to squeeze it in today!

I easily get more than 1GB ram with the latest dev. Both in my project and my isolated test case (see below)
On the other hand I get plenty of other errors. Such as:
WebGL: INVALID_VALUE: texImage2D: no image data
255localhost/:1 [.CommandBufferContext]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering.
So I think I might be doing something else wrong.
Anyway. In the forum I have posted test cases. I've added another one with the dev phaser, does it eat memory for you?
https://dl.dropboxusercontent.com/u/116813451/PhaserSoundTest/index_dev.html

Thank you for taking the time to open this issue. However, official support for Phaser 2 has now ended as we focus on preparing Phaser 3 for beta release. In a bid to keep the project tidy, and avoid confusion, we are closing all v2 related issues.
This does not mean your issue won't be looked-at. In November 2016 the Phaser CE (Community Edition) project began. The aim of Phaser CE was to allow the community to continue v2 development. Since then it has gained significant traction, with many updates and releases.
If you are still interested in having your issue investigated we strongly recommend testing the latest Phaser CE release. And only if the problem persists, opening an issue on the Phaser CE repo.


Failed to compile C in react-native run-ios

info Fetching system and libraries information...
System:
OS: macOS 11.2.1
CPU: (4) x64 Intel(R) Core(TM) i5-5350U CPU @ 1.80GHz
Memory: 167.75 MB / 8.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 15.9.0 - /var/folders/3f/blmqd2ps4415tfgt9ffghcth0000gn/T/yarn--1613943704944-0.15182780489913972/node
Yarn: 1.22.10 - /var/folders/3f/blmqd2ps4415tfgt9ffghcth0000gn/T/yarn--1613943704944-0.15182780489913972/yarn
npm: 7.5.3 - /usr/local/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK: Not Found
IDEs:
Android Studio: 4.1 AI-201.87<IP_ADDRESS>42882
Xcode: 12.4/12D4e - /usr/bin/xcodebuild
Languages:
Java: 13.0.1 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.63.4 => 0.63.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
✨  Done in 37.31s.

This is the error: The following build commands failed:
CompileC /Users/lucasdouradoferro/Library/Developer/Xcode/DerivedData/TESTE-gmieklczzmjvswbhgblayseaytef/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Flipper.build/Objects-normal/x86_64/FlipperRSocketResponder.o /Users/lucasdouradoferro/Desktop/React\ Native\ Projects/TESTE/ios/Pods/Flipper/xplat/Flipper/FlipperRSocketResponder.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

The following build commands failed:
CompileC /Users/zouchunwen/Library/Developer/Xcode/DerivedData/AwesomeProject-aezsyvsfbghkdfgxemyrdvrlcuki/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Flipper.build/Objects-normal/x86_64/FlipperRSocketResponder.o /Users/zouchunwen/Documents/AwesomeProject/ios/Pods/Flipper/xplat/Flipper/FlipperRSocketResponder.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

resolved!!!
ios -> Podfile -> use_flipper!  replace use_flipper!({ 'Flipper' => '0.74.0' })

Closing as stale


When loading a save

[Error  : Unity Log] NullReferenceException Stack trace: ExtraTerminalCommands.Networking.ETCNetworkHandler.OnNetworkSpawn () (at C:/Users/bvver/OneDrive/Documenten/GitHub/LethalCompanyMods/TerminalShipStart/ExtraTerminalCommands/ExtraTerminalCommands/ExtraTerminalCommands/Networking/ETCNetworkHandler.cs:17) Unity.Netcode.NetworkBehaviour.VisibleOnNetworkSpawn () (at <895801699cfc4b4ab52267f31e2a4998>:0) UnityEngine.Debug:LogException(Exception) Unity.Netcode.NetworkBehaviour:VisibleOnNetworkSpawn() Unity.Netcode.NetworkObject:InvokeBehaviourNetworkSpawn() Unity.Netcode.NetworkSpawnManager:SpawnNetworkObjectLocallyCommon(NetworkObject, UInt64, Boolean, Boolean, UInt64, Boolean) Unity.Netcode.NetworkSpawnManager:SpawnNetworkObjectLocally(NetworkObject, UInt64, Boolean, Boolean, UInt64, Boolean) Unity.Netcode.NetworkObject:SpawnInternal(Boolean, UInt64, Boolean) ExtraTerminalCommands.Networking.NetworkObjectManager:SpawnNetworkHandler() (at C:/Users/bvver/OneDrive/Documenten/GitHub/LethalCompanyMods/TerminalShipStart/ExtraTerminalCommands/ExtraTerminalCommands/ExtraTerminalCommands/Networking/NetworkObjectManager.cs:29) StartOfRound:DMD<StartOfRound::Awake>(StartOfRound)

It seems like this is an issue upon loading in the network manager, did this only happen once or does this keep happening?
Could you check the following path and see if the "extraterminalcommandsnetwork" file is there?:
{LETHAL COMP PATH}/BepInEx/plugins/Beauver-ExtraTerminalCommands/ExtraTerminalCommands/
You may reach this by going to thunderstore --> selecting your modpack with my mod --> settings --> all --> browse profile folder --> follow the path as given before.

it keeps Happening. I checked the path and the file is indeed there.

it keeps Happening. I checked the path and the file is indeed there. it only happens when loading a save file. no errors when launching the game and creating a new save.
I can consistently reproduce the error by Hosting the lobby Closing the lobby on Rehosting old or new lobby (the error happens here)

I'll try to recreate your in more detail bug as soon as possible as it's getting late for me now and I still have school tomorrow ):
Do you know if it fully breaks my mod, like when you run "intro", what happens, does it still play the intro for you, for everyone, or does it just not play? Or does it crash your game completely?
Thank you for your feedback, appreciate it, I'll try looking into it what could cause the issue!

After a while I've figured out how this bug occurs, not yet fixed.
It is when you launch/join a game for the second time, just not the first time. I'll see what I can do to fix this.


A more convenient use of groupBy in ActiveRecord

I am not aware of such functionality in Yii2, so consider this a feature request.
It would be nice if we could somehow use groupBy() in the following or similar fashion:
$averageAge = User::find()
    ->groupBy(['country'])
    ->average('age');

// Print average age of users from USA, Russia
echo $averageAge['country']['US'];
echo $averageAge['country']['RU'];

The example uses average(), but the same would apply to other aggregate functions.
The main perk is being able to somehow do this on-the-fly, without adding properties to the ActiveRecord.

It appears you have incorrectly labelled this feature request as "question".

You may always use Query::asArray(true) for this.

Thank you. I was not aware of that function. However I still believe it is rather illogical that Query's aggregate functions (count,average,min,max,sum) return a single scalar value when coupled with groupBy, which is very inconsistent with standard SQL. Wouldn't it make more sense to return them as an array by default?


nixos/vaultwarden: fix test

The accept policies checkbox is no longer present on the user creation
screen.
Description of changes
fixed NixOS test for vaultwarden

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg test vaultwarden


Fix the -f option in build_podspec.sh.

@swift-nio-bot test this please

@swift-nio-bot add to whitelist


[cuDNN] Add support for log_softmax

Updated log_softmax to use OpStrategy and added cuDNN implementation
cc @masahi

thanks @altanh


Consider pass user extensions via constructor params instead of global functions.

Currently user has to create global functions to make library work:

i2c functions
pdbs_dpm_evaluate_capability

That works, but a bit dirty. IMO it would be nice to pass such things as constructor params. The same about driver - it can be passed as policy engine param. That will be more clean & flexible than hardcoding/globals.
For example, anyone will be able to experiment with alternate drivers without intruding into library code.
PS. If you feel uncomfortable from multiple open issues i can close all those. I just post notes after code review, according to my experience, no mean to push you do something. Or i can suggest PRs and so on. Let me know about preferable way.

These are currently passed in as constructor params?

Ah, sorry for buss.
The only note: https://github.com/Ralim/usb-pd/blob/main/lib/Inc/policy_engine.h#L43 first param seem to be generic driver (base driver class), not fusb.

Not sure what you mean by your note. At the moment it is the FUSB class (not a generic) as have not refactored for generic yet


Error making API request: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

I followed the Getting Started steps to configure the OpenAI endpoint, but encountered an error during execution.
Error making API request: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
In the config.yml, I  ONLY modified the following parameters:
OPENAI_API_BASE: "https://api.openai.com/v1/chat/completions"
OPENAI_API_KEY: "###"
Could anybody tell me why and how to solve it ?

How often does it happen? Could be hitting your rate limits.

every time

It seems to be a connection error on the openai server. Perhaps you can try turn on/off your VPN, change to a different machine to request, wait and try again etc.

had the same issue, i have no VPN, this was my first launch

Thanks for the help! I had the same problem and it was an issue with my VPN, restarting it seemed to work


Implement a ViewMaterial page

...for Milestone1, I'm not planning on implementing a ViewMaterial page.

Done.  I needed to implement this to surface the Material contents for unit testing.


'late' word

Dart 2.3.0
Flutter 1.5.4-hotfix.2
I can't use 'late' word as variable name or method name.
For example
class A {
    int get late => 0;
}

We want to use late as a built-in identifier in a future language feature, so most likely the parsers are already now starting to special-case it.
That should not break here, though, since a built-in identifier should be useable as a method or variable name (just not as a type or prefix name).

@Davarg  Just downloaded and tried this with Dart 2.3.0 and there does not seem to be a problem using late as an identifier name (see below). What am I missing?
$ cat stuff.dart
class A {
    int get late => 0;
}

main() {
  print('result = ${A().late}');
}

$ dart stuff.dart
result = 0

$ dart --version
Dart VM version: 2.3.0 (Fri May 3 10:32:31 2019 +0200) on "macos_x64"

FWIW, I'd also tried to repro this on v2.3.0 and the current nightly and couldn't. I'm not sure what was different here. FWIW, here's the errors @Davarg provided (he posted it in Gitter after raising here):

first for get - Expected to find ';'.dart(expected_token)
second for late - Can't have modifier 'late' here. Try removing 'late'.dart(extraneous_modifier)
third for => - Methods must have an explicit list of parameters. Try adding a parameter list.dart(missing_method_parameters). Expected an identifier.dart(missing_identifier)

I can reproduce this in the version of dart shipped in flutter stable labelled as 2.3.0-dev.0.5 , but not in the version shipped as the dart sdk labelled as 2.3.0-dev.0.5 (see below).  This was a regression that was reported here and fixed: https://github.com/dart-lang/sdk/issues/36691 .  It looks like flutter stable shipped from the bad state.
leafp-macbookpro:flutter leafp$ cat ~/tmp/test1.dart
class A {
    int get late => 0;
}

void main() {
  new A();
}leafp-macbookpro:flutter leafp$ ./bin/cache/dart-sdk/bin/dart --version
Dart VM version: 2.3.0-dev.0.5.flutter-a1668566e5 (Tue Apr 30 20:35:41 2019 +0200) on "macos_x64"
leafp-macbookpro:flutter leafp$ ./bin/cache/dart-sdk/bin/dart ~/tmp/test1.dart
file:///Users/leafp/tmp/test1.dart:2:9: Error: Expected ';' after this.
    int get late => 0;
        ^^^
file:///Users/leafp/tmp/test1.dart:2:13: Error: Can't have modifier 'late' here.
Try removing 'late'.
    int get late => 0;
            ^^^^
file:///Users/leafp/tmp/test1.dart:2:18: Error: Expected an identifier, but got '=>'.
    int get late => 0;
                 ^^
file:///Users/leafp/tmp/test1.dart:2:18: Error: A method declaration needs an explicit list of parameters.
Try adding a parameter list to the method declaration.
    int get late => 0;
                 ^^
leafp-macbookpro:flutter leafp$ ~/dart/dart-sdk/bin/dart --version
Dart VM version: 2.3.0-dev.0.5 (Tue Apr 30 12:57:36 2019 -0700) on "macos_x64"
leafp-macbookpro:flutter leafp$ ~/dart/dart-sdk/bin/dart ~/tmp/test1.dart
leafp-macbookpro:flutter leafp$

the version of dart shipped in flutter stable labelled as 2.3.0-dev.0.5
the version shipped as the dart sdk labelled as 2.3.0-dev.0.5

Ouch, that explains why I couldn't repro with what seemed like the same version. I guess this issue is already resolved then (though it's a shame this didn't somehow end up on the Flutter bad builds page to prevent it getting to stable).

Hello everyone and thanks for help. As I understand this issue is now exist only in Flutter so I created another ticket, you can see.

Agree, this is now a Flutter-only issue.


recorder doesn't log hidden sensors

Home Assistant release (hass --version): 0.65.4
Python release (python3 --version):  3.6.4
Component/platform:  recorder, history graph, filter sensor
Description of problem:
I have a sensor of which I want to display a graph using the history graph component. Because the data is noisy, I applied a smoothening step using the new filter sensor. This works, but I don't want to display the smoothened sensor value itself in the UI, so I set hidden: true in the customize section. When I do this, the graph stops displaying new information. My guess is that hidden components don't get logged by the recorder component, but this isn't mentioned in the docs.
Expected:

The graph keeps working

Problem-relevant configuration.yaml entries and steps to reproduce:
  customize:
    sensor.smooth_pv_power:
      hidden: true

sensor:
  - platform: filter
    name: "Smooth PV power"
    entity_id: sensor.pv_current_power
    filters:
      - filter: lowpass
        precision: 0

history_graph:
  solar_graph:
    name: PV production
    refresh: 60
    hours_to_show: 24
    entities:
      - sensor.smooth_pv_power

Confirm this. Have a lot of plant sensors which are used in the plant component. If the sensors are hidden no graphs are available. Very annoying.

still an issue

Still an issue

Hi, 0.81.6 here, and this is still a real issue, this behaviour denies using restore state for hidden counters, input_numbers, etc...

It's still an issue, hidden sensor data should be able to be displayed in history graph even if ti's hidden.

This is by design:
https://github.com/home-assistant/home-assistant/blob/05333f60d701a50b21f294739d9daa9dfa937da2/homeassistant/components/history/__init__.py#L62-L65
Maybe it would make sense to add an include_hidden filter similar to the include filter: https://www.home-assistant.io/components/history/#include

@anderssonpeter Since you raised this again in #21826, can you comment on why unhiding the sensor is not a good option?

still an issue.
For me it's cosmetics - I don't need/want both a regular sensor to show me the power usage, and a history graph to show me the power usage.
Relevant config:

- platform: rfxtrx
  automatic_add: false
  devices:
    115a0201861200000016a20002c71fa91679:
      name: Sikringsskap

sensor.sikringsskap_energy_usage:
  hidden: true
  device_class: power
  unit_of_measurement: 'W'

history_graph:
  gr1:
    name: Power Usage
    entities:
      - sensor.sikringsskap_energy_usage
    hours_to_show: 24
    refresh: 10

Can't really see why hidden devices are discarded, when the History-addon already has options for defining exclusions.


Clarification - On adding multiple IDPs

Do this djangosaml2 package support multiple IDPs configuration ,how can I add more than one idp in settings or we need to customize the djangosaml2 configurations to support multiple IDPs.

I have never used it with multiple IdPs nor have I explicitly dealt with this possibility. You're free to try it though and submit PRs.
I have used it in a somewhat similar scenario this way:
I implemented a custom SAML configuration loader and activated it in settings (SAML_CONFIG_LOADER = 'path.to.my.custom.saml_loader'). The custom loader is just a simple Python function that accepts request object and should return saml2.config.SPConfig object. This one I populate dynamically in my custom SAML config loader function based on the request object (e.g. URL, or whatever may be relevant for you).
It's possible that it can be achieved with a simpler solution, defining both IdPs at once and "just selecting" the proper one at runtime somehow. Off the top of my head I can't give you more detailed instructions though, source code is your best help :-)

Thank you for the information given.

By quickly peeking at the code I've found some references that mention multiple IdPs, and I think (at least) pysaml2 supports it (that's the library djangosaml2 uses in the background). So, it's possible that we also have built-in support for this, or it could be added with a few changes.
Good luck!

For clarity - is the question about multiple related IdP, or 'two step' SAML where one IdP is queried, then another after that?

Hi,
The question is about accessing different IDPs .

Ah. In that case it is very relevant to what I'm doing at the moment. If I figure it out I'll post back, but fair warning - I don't look close yet :)

Just a hint (maybe useful): take a look to the login function, there's this:
selected_idp = request.GET.get('idp', None)

That seems like you can choose an IDP via URL param (?idp=myIDP)

I'm going to add something here:
I work on a website (SaaS) that is a Service Provider and multiple companies want to let their users log in via SSO. We let the companies set up their Identity Providers' configuration into their accounts.
In our SAML_CONFIG_LOADER function we do something like this magic pseudocode:

common_config = { ... 'service': { blah },  'attribute_map_dir': blah,  blah ... }
idps = []
for idp in IdentityProviders.objects.all():
    idps.append({ ... blah ..., url: idp.xml_metadata_url, cert: idp.cert_filename, etc })

common_config['metadata'] = {
    'remote': idps
}

return SPConfig().load(common_config)

Basically, we get and put all the IdPs configs into a dict, and then load them all every time there's a request.
Is this the approach you were talking about @knaperek ?

Probably we should take in account the need to develop a WAYF (where are you from) view and template to let the user select which IDP he wants to be authenticated on. This wayf should parse the IDP metadata, single or multiple, and represent to user a menu of IDP servers, ex: google, my-home, amazon, onelogin, mysaml.it... It's only a stupid example but WAYF is the key

There is already a wayf template and logic: https://github.com/knaperek/djangosaml2/tree/master/djangosaml2/templates/djangosaml2 and https://github.com/knaperek/djangosaml2/blob/master/djangosaml2/views.py#L139-L146
All that is needed is to put multiple IdP config in settings.SAML_CONFIG['metadata']. You don't even need to use dynamic config to get this working. Here's an example: https://github.com/uktrade/staff-sso/blob/master/config/settings.py#L220-L234

@lgarvey very thanks, this means that we just have to manage large metadata files with scheduled commands and cache strategies (db or nosql with memcached). So this PR could be good, even if refactored as our needs suggests


Returned custom close reason from server according to RFC 6455

It appears to me as if this feature has been planned but not fully implemented.
By actually using the parsed string we support close reason mentioned here: https://tools.ietf.org/html/rfc6455#section-7.1.6

Ah nice catch. Thank you!


What is the difference between Freeze<Mock> vs new Mock

am getting different results when doing Freeze<Mock> vs new Mock.
I know Freeze will give me the same Instance of the mock. But when to use this and when to use new Mock
Am creating a constructor by passing the new Mock still i get different results, and when i switch it back to FreezeMock and Setup a method, the test go green.
Any inputs on these two steps will help me in understanding Moq a bit more

Can you add some sample code? I use moq with freeze regularly so I might be able to help you

Closing this issue due to inactivity. Feel free to reopen if necessary.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/eventing-writers
/assign knative-sandbox/eventing-writers
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping k8s.io/api a1613d7...cd271e7:
  > cd271e7 Update dependencies to v0.23.5 tag
  > a6b2207 Merge pull request # 108139 from liggitt/automated-cherry-pick-of-# 108138-upstream-release-1.23
  > 80b93d4 Revert v1beta1 PodDisruptionBudget select patchStrategy
bumping k8s.io/client-go b425fb6...97582f2:
  > 97582f2 Update dependencies to v0.23.5 tag
bumping knative.dev/eventing 5df47e1...02663e2:
  > 02663e2 Update community files (# 6290)
  > 04eafff Process empty tracing config in test images (# 6289)
  > 3890b39 Wathola Tracing for upgrade tests (# 6219)
  > eb2bfff upgrade to latest dependencies (# 6288)
  > 7001b65 upgrade to latest dependencies (# 6286)
  > 4be06cd Feature/keep ports for service (# 6283)
  > 5081edd Drop sendevent tool since there is kn-plugin-event (# 6284)
  > a27ee9e Use env config for tests instead of hardcoded configs (# 6282)
  > 9b9cdee Adding code of conduct to reference knative/community's CoC (# 6281)
bumping knative.dev/pkg e6e3cf0...0a1ec2e:
  > 0a1ec2e upgrade to latest dependencies (# 2474)
  > 1f7514a bump k8s deps to v0.23.5 (# 2469)
  > 19a2589 fix coverage settings (# 2471)
  > 2daa86a Electors can provide an initial set of buckets (# 2473)
bumping k8s.io/apimachinery 276a8a7...276a8a7:
bumping knative.dev/hack 14f832e...f067737:
  > f067737 Adding code of conduct to reference knative/community's CoC (# 162)

/lgtm
/approve


1 Host per IP

Pretty straightforward. We can check off item 2 of #350.

Perhaps this is more complexity than we need now, (and perhaps item 1 of #350 is also more complexity than we need now) but I was thinking that all entries should go into the inactive database, even if there are already hosts with the same ip address. Then we can pull them out of the inactive database later.
For now, we might not need to keep an inactive database. I don't think we actually use it all currently, and maybe it's best to just delete it for the time being, to keep things simple.
That only leaves adding some method of pruning hosts if they go offline for an extended period of time. 'Extended' might be difficult to define, but pruning will probably be important because I'd expect a lot of churn in the early days of the network.

many thanks


CentOS instructions are no longer valid

I tried following our build-from-source instructions for CentOS 6.5 on the website (http://rethinkdb.com/docs/install/centos/), and it looks like it is no longer valid because we now require a later version of GCC (see rethinkdb/rethinkdb#1748, especially the last comment).
We should probably update the instructions.

Fixed in 6827dd6


Ensure dataframe readbacks all have appropriate set_index

Found while exploring data.
Before:

Mac CI jobs: The agent pool assigned to this job has hit their MacOs concurrency limits
Taking the 'pass' signals on Ubuntu / Windows as sufficient, & relieving the agent pool of some overstress.


⚠ Jenkins Plugins Artifactory has degraded performance

In 01971ff, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1376 ms

Resolved: Jenkins Plugins Artifactory performance has improved in abc911d after 42 minutes.


Video Review

Hi, I'm the guy who made this video review:
[CN] Pipe-viewer！有史以來最佳的 YouTube 體驗就在這裡～
https://wiwi.video/videos/watch/798d38cd-9d10-4f8a-ac1f-f776c6d0aa2c
Thank you for including my video in your README, but I'm from Taiwan, not China. May I request that you change the [CN] to [TW]? Thanks a lot!

Changed. Thanks for reporting. Also thank you for the video review. :)


Store all database files in subdirectory specified by New

Change New if needed such that all database files are placed in given directory. If dir does not exist, it will be created.

Need to write SST files to specified path, NOT current directory.


[SPARK-37575][SQL][FOLLOWUP] Update the migration guide for added legacy flag for the breaking change of write null value in csv to unquoted empty string

What changes were proposed in this pull request?
This is a follow-up of updating the migration guide for https://github.com/apache/spark/pull/36110 which adds a legacy flag to restore the pre-change behavior.
It also fixes a typo in the previous flag description.
Why are the changes needed?
The flag needs to be documented.
Does this PR introduce any user-facing change?
It changes the migration doc for users.
How was this patch tested?
No tests

Hi @cloud-fan , this is the migration guide update follow-up. Could you review? Thanks!

thanks, merging to master/3.3!


getting ReferenceError: gtag is not defined

After implementation, getting ReferenceError: gtag is not defined

Hi, can you please check now?

I think this issue is very much outdated :thinking:
@neerajnitw3 if anything needs to be done, please open a new issue :slightly_smiling_face:


add default ciliumNetworkPolicies in audit mode

What type of PR is this?
/kind feature

What this PR does / why we need it:
this PR adds some default host firewall rules through cilium, it does not enable them by default but using the environment variable export FW_AUDIT_ONLY=false the rules will go into blocking mode. this should support kubeadm, k3s and rke2 clusters
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
TODOs:

[ ] squashed commits
[ ] includes documentation
[ ] adds unit tests
[ ] adds or updates e2e tests

Overall, the PR looks good to me.


feat: add examples page

feat: add examples page
What does this PR do?

Minor edit to category (see json update)
Adds an example page (rendered portion) that shows all the examples we
currently have
Pull and build image buttons
Reactively do in-progress for pulling

Screenshot / video of UI

https://github.com/user-attachments/assets/9a9d67a3-ecc8-4367-aea9-1061d2fa81de

What issues does this PR fix or reference?

Closes https://github.com/containers/podman-desktop-extension-bootc/issues/895
How to test this PR?

Go to examples page
Press pull image button
Then build image button after it finishes

Signed-off-by: Charlie Drage<EMAIL_ADDRESS>

Tests have been added! Ready for testing out and using 🚀
I have added some "follow up issues" to the topic here, especially lack of examples (only 3 "good" ones right now): https://github.com/containers/podman-desktop-extension-bootc/issues/864#issuecomment-2420381794

Ditto to all the points @benoitf raised.
Worked fine when testing. The biggest gap to me was how to find details or instructions for each example. Why does it exist, what does it do, and how do I use it? The source goes to the repo root, then I have to guess at the folder and look at the readme. (and ok, Tailscale doesn't have anything)
Could we link directly to the folder, or ideally have a way to view the readme directly? Maybe needs a details page for each one?
Noted a few other minor usability issues:

The page appears, then we switch buttons from Pull to Build. Is the API fast enough that we could do this before opening the page, or can we delay adding the button until we know which it is? (might need to move Source button to Link on the left so it doesn't move).
Like on the dashboard, you don't know the image you're about to pull is huge. Would be nice to include the size on the card, or warn the user when they click on the button.
No pull task or progress. Unrelated to this issue so I opened up Usability of pulling images #944.

We have https://gitlab.com/fedora/bootc/examples/-/issues/19 which I could work on next sprint with regards to descriptions of what each one does.
We have no way of knowing the size of the image before pulling, but we can at least add an approximate "size" on the description when pulling?
ACK on button delay / showing it correctly.

@deboer-tim @benoitf
Updated the code based on the review:

Added size of the image (hardcoded in examples.json), makes it easier and less calls to check for size (honestly sizes will not change much, and this is just for showing examples)
Modified how we show the buttons on load, less flickering / changes.
Did not update to svelte5 (could not get it to work very well without causing extra changes in other svelte files)
Updated rest of minor code edits

I'm no longer getting Pull buttons when I don't have the image locally:

that's my mistake, I had messed up an if statement.
Latest commit I have also updated the styling, adding a "querying" button in case it takes a while to get the list of images, etc, as well as reduce the amount of flickering on initial load.

Updated @benoitf @benoitf
The more I use svelte5, the more I'm liking it! Much cleaner code.
I have updated it to svelte5 paradigms. I also decided to use https://www.npmjs.com/package/filesize library instead of humansize since it's the same on in Podman Desktop + is more updated.

yes the library name was wrongly spelled !

looks like there are some typechecking issue but approving

Thanks! Formatter had messed up and did not put {} around href. Added and updated now.


Bump storage stress addons version to ~0.3.0

Updating java stress tests to use the newer addons template version which supports workload identity in the stress cluster (breaking change).

/check-enforcer override


Datavalidation module rename

Description
Changed module and operator names
closes: #1592
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

@utkarsharma2 could also update the naming of the test file, please?


Make Sphinx builds reproducible with a lockfile

This patch just adds and integrates a pip-tools-generated constraints file w/o adding any of the pip-tools machinery at the moment.

I don't know........................
It doesn't seem like there is a good answer here, either we accept the occasion broken something due to a version or go down this road.
My concern here is we don't have a process in place or tooling to update/audit this list...
and probably don't have the time to implement something right now
thinking

Tooling is pip install pip-tools. Nothing else is needed strictly speaking.

This is a long-planned change. I postponed making a lockfile for docs when adding the initial docs configuration. Also, per experience, it's best to have non-conflicting lockfiles for each env. But you could have an additional file combining them. I only care that the per-env ones exists, I have a PoC of an automation to batch-update them so it's not a concern. Although, I don't mean to include it in this PR.


[REG-499] Create template

Other topic, I just started using 1.3.0 of the rg-bot library and have run into problems.
Specifically, the typescript isn't correctly generating and/or the docs are wrong... The FindResult should be showing Entity|Item|Block like it did before
https://github.com/Regression-Games/RegressionBot/blob/zack/reg-428/lib/RGModels.js
Also, the BestHarvestTool constructor takes 'any' for Item instead of a nullable Item.

@abeizer Also having major issues with my non-TS bots...
2023-01-06T12:26:08.810-05:00  INFO 34521 --- [tcher-worker-13] g.r.u.m.MineflayerProcessManager         : <R0_Chester> [NODE] Error during bot execution TypeError: bot.matchInfo is not a function
2023-01-06T12:26:08.810-05:00  INFO 34521 --- [tcher-worker-13] g.r.u.m.MineflayerProcessManager         : <R0_Chester> [NODE]     at cleanupInventory (/Users/zack/RG/RegressionGames/GameMachine/assemblies/usercode_standalone/tmp_user_code/my_code_2/1192/R0_Chester/lib/HelperFunctions.js:18:30)
2023-01-06T12:26:08.810-05:00  INFO 34521 --- [tcher-worker-13] g.r.u.m.MineflayerProcessManager         : <R0_Chester> [NODE]     at EventEmitter.<anonymous> (/Users/zack/RG/RegressionGames/GameMachine/assemblies/usercode_standalone/tmp_user_code/my_code_2/1192/R0_Chester/basic/chester/index.js:194:27)

Specifically, the typescript isn't correctly generating and/or the docs are wrong... The FindResult should be showing Entity|Item|Block like it did before<EMAIL_ADDRESS>FindResult being generic makes it basically useless as there are no typing hints when using the result object and the caller is not the creator of the object.

Reverting it to Entity | Item | Block makes methods like findBlocks harder to use for TypeScript users as they'd have to manually cast the FindResult.result to Block before being able to access any of its properties (because Entity, Item, and Block share almost no properties). FindResult only seems to be used in RGBot, so as long as the JSDoc in there consistently sets the generic type it shouldn't be "basically useless"?
The constructor arguments being any is one I missed, I think the @param tags should be directly above the constructor instead of above the class.

Other topic, I just started using 1.3.0 of the rg-bot library and have run into problems.
Specifically, the typescript isn't correctly generating and/or the docs are wrong... The FindResult should be showing Entity|Item|Block like it did before https://github.com/Regression-Games/RegressionBot/blob/zack/reg-428/lib/RGModels.js
Also, the BestHarvestTool constructor takes 'any' for Item instead of a nullable Item.

FindResult being generic makes it basically useless as there are no typing hints when using the result object and the caller is not the creator of the object.

Fixed the any issue here: https://github.com/Regression-Games/RegressionBot/pull/10
As for FindResult, I'm getting typing hints in my IDE... might need to sync up in slack

Specifically, the typescript isn't correctly generating and/or the docs are wrong... The FindResult should be showing Entity|Item|Block like it did before<EMAIL_ADDRESS>FindResult being generic makes it basically useless as there are no typing hints when using the result object and the caller is not the creator of the object.

Reverting it to Entity | Item | Block makes methods like findBlocks harder to use for TypeScript users as they'd have to manually cast the FindResult.result to Block before being able to access any of its properties (because Entity, Item, and Block share almost no properties). FindResult only seems to be used in RGBot, so as long as the JSDoc in there consistently sets the generic type it shouldn't be "basically useless"?
The constructor arguments being any is one I missed, I think the @param tags should be directly above the constructor instead of above the class.

What I found was that in one of our intermediate bot implementations, we collect all the possible actions for a loop iteration, and then decide the 'best' action to take based on their relative value scores.
Before, the code typing hints in the editor would allow the user to do any action for one of those 3 types, but now the typing hints returns nothing.  After your response though, I realized that the issue is not with these changes, but rather the type that was assigned to the combined result set in the bot's code.
Also, ty for the update for the 'any' type.


Renew certificate

What's the recommended way of renewing an existing letsencrypt certificate using cmd/acme?
Just running acme cert $domain will re-issue a new .crt.
Is there a way of handling this automatically? Like "renew, when existing .crt will expire in n days"?

Good point! It isn't there yet but I'll start working in it soon.
Renew should be very easy as it doesn't require challenge resolution.

Sound's good! I like the tool so far, clean and simple implementation.
Would you mind updating this ticket when there's something to test/ use?

Of course. Will do.


pythonPackages.docker: 3.2.1 -> 3.3.0

Version update.
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python2.pkgs.docker python3.pkgs.docker

Success on x86_64-linux (full log)
Attempted: python2.pkgs.docker, python3.pkgs.docker
Partial log (click to expand)
Successfully installed docker-3.3.0
/build/docker-3.3.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dcm124sa82s26fl04hniphv1xpf5k2sm-python3.6-docker-3.3.0
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dcm124sa82s26fl04hniphv1xpf5k2sm-python3.6-docker-3.3.0/lib
patching script interpreter paths in /nix/store/dcm124sa82s26fl04hniphv1xpf5k2sm-python3.6-docker-3.3.0
checking for references to /build in /nix/store/dcm124sa82s26fl04hniphv1xpf5k2sm-python3.6-docker-3.3.0...
/nix/store/xgq453yn16pkval63spb4lvys8chbs8q-python2.7-docker-3.3.0
/nix/store/dcm124sa82s26fl04hniphv1xpf5k2sm-python3.6-docker-3.3.0

Success on aarch64-linux (full log)
Attempted: python2.pkgs.docker, python3.pkgs.docker
Partial log (click to expand)
Successfully installed docker-3.3.0
/build/docker-3.3.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gasngh5hrfavdmggpwykvvq84q7qxjyq-python3.6-docker-3.3.0
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gasngh5hrfavdmggpwykvvq84q7qxjyq-python3.6-docker-3.3.0/lib
patching script interpreter paths in /nix/store/gasngh5hrfavdmggpwykvvq84q7qxjyq-python3.6-docker-3.3.0
checking for references to /build in /nix/store/gasngh5hrfavdmggpwykvvq84q7qxjyq-python3.6-docker-3.3.0...
/nix/store/rjmscag26svaq5da5q3i9hbdyk0azf6j-python2.7-docker-3.3.0
/nix/store/gasngh5hrfavdmggpwykvvq84q7qxjyq-python3.6-docker-3.3.0


Enhance bookmarking cog

Description

When a really cool message is sent in the server, people want to bookmark it for future reference.
If many people want to bookmark the same message, the chat could be flooded with .bm<PHONE_NUMBER>313 calls.
We should add a way for users to also bookmark the same message as another user, without having to send another command.
Reasoning

To reduce the amount of messages sent in a channel when many people are wanting to bookmark a message.
Proposed Implementation

Add a reaction listener to the cog, so any users that react with the mail emoji will also have the message bookmarked for them
Would you like to implement this yourself?

[ ] I'd like to implement this feature myself
[x] Anyone can implement this feature

Duplicate of #341 which has... gone very silent


ConfigurationManager GetConfigurationAsync is often slow

Which version of Microsoft.IdentityModel are you using?
Note that to get help, you need to run the latest version.
Microsoft.IdentityModel.Protocols 7.5.2
Where is the issue?

[x ] M.IM.Protocols.OpenIdConnect

Is this a new or an existing app?
This is a new app or an experiment.
Repro
var wellKnownUri = "https://login.microsoftonline.com/common/v2.0/.well-known/openid-configuration";
var configurationManager = new ConfigurationManager<OpenIdConnectConfiguration>(
    wellKnownUri, new OpenIdConnectConfigurationRetriever());
var openIdConfig = await configurationManager.GetConfigurationAsync();

Expected behavior
I would expect the call to GetConfigurationAsync() to be very fast.
Actual behavior
The call to GetConfigurationAsync() often takes 500ms or greater.
Additional context / logs / screenshots / links to code
As this code is handling a large amount of requests from Microsoft Graph presence updates we need to be able to quickly process notifications and this one call is too slow. Part of processing the notification is validating the token that comes along with the request. This code is running in an Azure Linux Function App running on .net 8 isolated mode. I notice the issue in Azure or as well running locally from my machine with Visual Studio. I notice it hits https://login.microsoftonline.com/common/v2.0/.well-known/openid-configuration and https://login.microsoftonline.com/common/discovery/v2.0/keys and I can see with Fiddler that those endpoints return very quickly (less than 5 milliseconds each).
When I first started this app I was using version 7.2.0 of the package and upgraded to 7.5.2 and the performance was a little better but there still are cases of it being slow.

Are you sure you aren't using a sync over async pattern?

I don't believe I am. My entry point which is the Azure Function returns a Task<HttpResponseData> and the method I am calling GetConfigurationAsync from returns Task<bool>. (My function calls a method to check if the token is valid and the GetConfigurationAsync is called from that method)

@jsweiler Do you have any profile data by any chance? It would be very helpful to know where the time is being spent.

I'll try to get some and post my results.


[computer-use-demo] Refused to connect in web app

Set this up in Ubuntu using the docker image. No errors of any sort that I can see, and I'm able to connect to the NoVNC session on the system.  The web app UI is showing "refused to connect" in both boxes.
The only variable is I am accessing remotely, so it's not via localhost:8080, but [ip]:8080

Ugh - realized that this is due to not being local, and the index.html file uses localhost or <IP_ADDRESS> for the links, so it won't work.  Need to run locally or edit the index.html in the container.

Hi, i'm facing the same issue, how you fix it?

You can fix this by creating a mount point for ~/static_content/index.html and then replacing the <IP_ADDRESS> and localhost entries there with the host IP/DNS


Move bench-utils into std, and simplify workspace

This PR merges bench-utils into std, thus simplifying the dependency story for downstream crates. It also makes it easier to publish things on crates.io. cc @ValarDragon @weikengchen

LGTM sans the question about build profiles

Ok let's merge this after the relevant PRs are made to the dependant crates.

btw, should we rename this repo to std?

I agree with the renaming since the main one we use is ark_std anyway.


Memory leak detected for publish message method.

Hi,
Encountered a memory leak with pubsubclient.publish method. We tried load testing for publish message operation and found the following results:
For 100 requests, an increase of (0.1-0.2)MB.
For 1000 requests, an increase of (0.6-0.7)MB.
For 5000 requests, an increase of around 3MB.
These results continue to give an increase in memory, with increase in number of requests.
Node version - 10.16.3

@ibmappcon Can you please provide the code you are using that demonstrates the memory leak?

@kamalaboulhosn
A brief background what we are trying to achieve:
We are building a Multi tenant node js application where user can come in with their service account credentials and use our app to interact with Google pub sub for integration.
The code to publish message is some what like this:

function calledOnEachIncomingRequest() {
    const promise = new Promise((resolve, reject) => {
        let pubSubClient = new PubSub({
            credentials: {
                client_email: 'xxxxxserviceaccountemail',
                private_key: '{Redacted}'
            },
            projectId: 'projectId'
        })

        const topicInstance = pubSubClient.topic('loadTest2')
        const dataBuffer = Buffer.from('any1234')
        const attributes = {}
        topicInstance.publish(dataBuffer, attributes, (error, messageId) => {
            console.log('...................', error, messageId)
            if (error) {
                console.log(error)

            } else {
                topicInstance.flush(() => {
                    newclient.close().then(resolve(messageId))
                })
            }
        })
    })
}

calledOnEachIncomingRequest()

We also tried caching and keeping one client only instead of creating it at runtime, the problem with that approach we are seeing is we get this error:
[2432]: c:\ws\src\node_http2.cc:893: Assertion `(flags_ & SESSION_STATE_READING_STOPPED) != (0)' failed.  1: 00007FF6ABD5DD8A v8::internal::GCIdleTimeHandler::GCIdleTimeHandler+4506  2: 00007FF6ABD38886 node::MakeCallback+4534  3: 00007FF6ABD3893F node::MakeCallback+4719  4: 00007FF6ABCDCA35 EVP_CIPHER_CTX_get_cipher_data+114517  5: 00007FF6ABCE0BD1 EVP_CIPHER_CTX_get_cipher_data+131313  6: 00007FF6ABC26D76 DH_get0_q+14022  7: 00007FF6ABC24AD8 DH_get0_q+5160  8: 00007FF6ABC27D61 DH_get0_q+18097  9: 00007FF6ABC810B1 RSA_meth_get_flags+753 10: 00007FF6ABD8E203 uv_tcp_getpeername+1315 11: 00007FF6ABDA1457 uv_dlerror+2007 12: 00007FF6ABDA23E8 uv_run+232 13: 00007FF6ABD3FE7E node::NewContext+1390 14: 00007FF6ABD4048B node::NewIsolate+603 15: 00007FF6ABD408E7 node::Start+823 16: 00007FF6ABBEF3CC node::MultiIsolatePlatform::MultiIsolatePlatform+604 17: 00007FF6AC83863C v8::internal::compiler::OperationTyper::ToBoolean+129516 18: 00007FFB163F7BD4 BaseThreadInitThunk+20 19: 00007FFB1654CE51 RtlUserThreadStart+33
In both the approaches the leak is evident because as we stub the .publish call with some dummy function the memory is getting reclaimed properly.
Following is the problem  statement:

How can we use single cached client for multiple concurrent calls without introducing any memory leak ?
In case 1 is not possible, how can we create client on runtime and exit it without leaking any memory ?

Thanks!

@kamalaboulhosn any updates on this will really help.

I'll put this on my agenda for today.

Hi @ibmappcon,
I dug into this a bit today. I am indeed able to see the memory leak issue, and it appears to have something to do with the code we are generating for protos. I'd like to look at that a bit more, because it seems like we shouldn't be leaking things like that.
But my take on it (and after consulting with my colleagues, they agree) is that it's not great to create a PubSub object per request. There is a lot of data that is loaded from disk when that happens, and it's also going to cause problems with the authentication service eventually, because that downloaded info is cached across PubSub object creations.
Tomorrow I'm going to see if I can reproduce the multiple cached clients issue. Eventually that might still end up with the same issue, though, if you have thousands of users, or if you end up with thousands of Pub/Sub server sockets open.

@feywind where does this one stand? Do you think our code somewhere is retaining objects in memory unnecessarily, or is this a matter of best practices?

Im having the same issue:
process.env.GRPC_VERBOSITY = 'DEBUG';
const {PubSub} = require('@google-cloud/pubsub');

exports.EventPostPubSub = functions.runWith(runtimeOpts).https
    .onRequest(async (request, response) =>
    {
        try
        {
            const pubSubClient = new PubSub({
                // Sending messages to the same region ensures they are received in order
                // even when multiple publishers are used.
                apiEndpoint: 'us-central1-pubsub.googleapis.com:443',
            });

            const data = JSON.stringify(request.body);
            const dataBuffer = Buffer.from(data);

            const messageId = await pubSubClient.topic('event').publish(dataBuffer);
            response.send("ok "+messageId);
        }
        catch (e) {
            console.error(e) ;
            response.send("error");
        }

    });

getting very high memory usage.
          "version": "2.9.2",
          "resolved": "https://registry.npmjs.org/google-gax/-/google-gax-2.9.2.tgz",
          "integrity": "sha512-Pve4osEzNKpBZqFXMfGKBbKCtgnHpUe5IQMh5Ou+Xtg8nLcba94L3gF0xgM5phMdGRRqJn0SMjcuEVmOYu7EBg==",
          "requires": {
            "@grpc/grpc-js": "~1.1.1",
            "@grpc/proto-loader": "^0.5.1",
            "@types/long": "^4.0.0",
            "abort-controller": "^3.0.0",
            "duplexify": "^4.0.0",
            "google-auth-library": "^6.1.3",
            "is-stream-ended": "^0.1.4",
            "node-fetch": "^2.6.1",
            "protobufjs": "^6.9.0",
            "retry-request": "^4.0.0"
          },

I can confirm using the new pubsub client declaration outside of the function did the fix :)

I haven't been able to dig into this more since the last post, but I'm still under the belief that there's something leaking from the generated gax API calls. At least when I looked at it in the profiler, most of the growing memory usage was strings with generated proto code. If keeping around the same PubSub fixes it, then I'm happy to let it go for now, but I'd also be interested to hear what @alexander-fenster thinks. (Feel free to re-open as needed.)

Came across this issue after trying to track down a memory leak in our Firebase Functions that leaked when doing not much else other than publishing events. Just moving the creation of the pubsub client to outside the function vs creating a new one fixed our problem too.
Is this potentially worth re-opening @feywind? Surely it's reproducible pretty trivially?

+1 @lox. I'm able to recreate it using the below snippet.
Minimal example to recreate this.
const dotenv = require('dotenv');
const { randomSync } = require('ksuid')
dotenv.config();

const { PubSub } = require('@google-cloud/pubsub');

const c1 = new PubSub({
    projectId: process.env.PUBSUB_PROJECT_ID,
    emulatorMode: true,
});

async function main() {
    const topicId = randomSync().string.slice(1, 10)
    console.log('topic is', topicId)
    await c1.createTopic(topicId);
    const sub = await c1.createSubscription(topicId, 'sub-' + topicId);
    sub[0].on('message', (msg) => {
        console.log(msg.data.toString())
        msg.ack()
    });

    for (let i = 0; i < 10000; i++) {
        const client = new PubSub({
            projectId: process.env.PUBSUB_PROJECT_ID,
            emulatorMode: true,
        });
        const topic = client.topic(topicId)
        await topic.publishMessage({
            json: {
                'val': i
            }
        });
        console.log(i)
    }

}

main()
    .then(() => {
        console.log('done');
    }).catch(err => {
        console.log(err)
    })

Using global pub-sub outside is definitely solving this.

Thanks for adding the code. Yeah, the intended usage is to have the new PubSub somewhere global, one per application, ideally. There are a lot of things wrapped up in there (and in client.topic) that need to be cached for it to work efficiently.

@feywind understood. Would you have any thoughts on adding this note to the docs?

The particular issue is mostly Node-specific, because it's the only language (as far as I know) that has this kind of "big object" approach to the API. So I'm not sure it would make sense to put it into the shared docs. Other languages use terminology like "subscriber" and "publisher" for the objects, which make it a bit more obvious that there is machinery in there. We want to make this change for Node, too, but it's kind of gotten deprioritized.
In the meantime, here is the sort of change I've been making to samples:
https://github.com/googleapis/nodejs-pubsub/blob/70754309fb600c54d0a573f2d49ad4c419577550/samples/typescript/createProtoSchema.ts#L40
Just to kind of pull the instantiation out and put an explicit comment.

Hey @feywind,
Maybe we can add the same comment in [and readme?
My opinion is developers using this package would generally go through Reafme example first and only go through samples if they really need to look into something in specific which is not straight forward enough.
Let me know if it makes sense.


Document units of Electronegativities

I'm currently in the process of taking over the electronegativities data into my Mendeleev.jl , thus I read your documentation. I understand that electronegativities is only a semi-quantitative concept, and probably only relative values are relevant - still most of them are not dimensionless and have actually physical units attached to them.
I've tried to get the units from the descriptions. Is that correct? Especially for Nagle, I'm not sure, as there are different ways to represent polarisability. Would be nice to have units documented (and for my project, also implemented in the software).
e is elementary charge
Allen : eV
Allred_Rochow : e^2/pm^2
Cottrell_Sutton : (e/pm)^0.5
Ghosh : 1/pm
Gordy : e/pm
Martynov_Batsanov : eV^0.5
Mulliken : eV
Nagle : 1/Å
Pauling : eV^0.5
Sanderson : dimensionless
Li_Xue : 1/pm

Good point, I think you got the units right but I would have to double check to verify. I'll try to work it into the next release.


Update snowflake client

Use Snowflake query from Pypika in Snowflake database.

Coverage increased (+0.005%) to 90.953% when pulling 6efb706eaeb3b9d4f59417484122e22703984efe on RobinPapke:master into 7535eee5868efe278bacdc0b62f5c4569d627e04 on kayak:master.


helm search raises a runtime error unless helm has been initialized

After installing helm from source, if I execute helm search redis I get:
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x20 pc=0x40dfd0]

goroutine 1 [running]:
panic(0x1905e80, 0xc82000e120)
	/usr/local/go/src/runtime/panic.go:481 +0x3e6
main.searchCacheForPattern.func1(0xc8203df680, 0x26, 0x0, 0x0, 0x7f53d2f6f2d0, 0xc8203df800, 0x0, 0x0)
	/home/migmartri/work/gocode/src/github.com/kubernetes/helm/cmd/helm/search.go:63 +0x40

Problem that seems to be related to the fact that I have not initialized helm yet.
So executing helm init fixed the issue.
$ helm search redis
kubernetes-charts/redis-2.0.0.tgz

I have noticed that for some other commands there is a guard statement that tells you that the file does not exist, for example:
$helm fetch foo
Error: open /home/migmartri/.helm/repository/repositories.yaml: no such file or directory

We might want to implement the same approach for the search command. Ideally with a message a little bit more actionable that says something about executing helm init first (although this could be moved to another issue)
What do you think?

Hey @migmartri. You're absolutely right. You have to run init to configure your local environment and that's why you're getting a panic. I agree; there should be some type of guard or actionable message.


unable to load addon (zipped with win10)

Godot version:
Godot_v3.1.1-stable_win64
OS/device including version:
WIn10
Issue description:
editor/editor_asset_installer.cpp:175 - Condition ' !dir_map.has(ppath) ' is true. Continuing..:
Steps to reproduce:

create addon
use right click -> send to -> Compressed (zipped) folder
AssetLib -> Import

Minimal reproduction project:
test.zip
Related Issue: the imported addon will be added to the root project folder

download addon
https://godotengine.org/asset-library/asset/457
https://github.com/samdze/godot-modifiers-plugin/archive/4e88b9812c26d35673d6c12198aeb2f8cb2d9425.zip
import addon

It appears this is due to Windows-created ZIPs requiring a newer version to be extracted. This is likely a bug in the ZIP library we're using.
test.zip:                                                            Zip archive data, at least v2.0 to extract
godot-modifiers-plugin-4e88b9812c26d35673d6c12198aeb2f8cb2d9425.zip: Zip archive data, at least v1.0 to extract

# Extract `test.zip`, create another one using `zip -r9 test-v1.zip test`
test-v1.zip:                                                         Zip archive data, at least v1.0 to extract

test-v1.zip can be loaded successfully:

Still valid in 3.2.4 beta3

Still an issue in 3.5.1

This likely affects projects using ZIPReader now that https://github.com/godotengine/godot/pull/65281 was merged in 4.0.beta.

I saw this while browsing github issues.
https://github.com/zlib-ng/minizip-ng Might be a better maintained fork of the minizip.
Might be worth checking if it supports the bug cash.


Moving links away from java.net

At the suggestion of @rleigh-codelibre cf https://openmicroscopy.slack.com/archives/C0K5EED3R/p1502267914727547

The URL changes here all look correct and good to merge.


DOC: cdf2rdf Added version info and "See also"

I've put this in an additional PR. It's just a few details missed about the documentation. Hence the [ci skip]

rendered output https://6131-1460385-gh.circle-artifacts.com/0/html-scipyorg/generated/scipy.linalg.cdf2rdf.html#scipy.linalg.cdf2rdf

Merged, thanks @ilayn @tylerjereddy


Better and more consistent error handling by wrapping the errors

This is based on Dave Cheney's talk from Gocon 2016 and make use of the github.com/pkg/errors package to do error wrapping.
We no longer print error messages and then return them as that would lead to the same error being handling multiple times.
I have also added a missing error check inside makeRequest() after the HTTP request has been tried, plus added a couple of TODO lines in error cases where we return err but we already know it's nil.

This is similar (in approach) to some of the work I was doing in this PR: https://github.com/cloudflare/cloudflare-go/pull/10/commits/fb9939d2839d2cac32742cec29b69b0ad4299b38#diff-4aae454123f50b906f9aaef44f10011eR2 - which is based around how net.Error is an interface with methods for asserting behaviour.

I think it's two different things which can perfectly co-exist. Wrapping of errors seems like a good way to provide context of the error as it's passed up the stack (although the error messages in this PR probably could be improved over time), while your approach is related to developers using this library who needs to handle errors.

LGTM besides the couple of comments re: making those error messages private constants. This will definitely help make errors clearer to callers + tie in with my changes in #10!

The repeated error messages have now been put into constants in 18ff40f.

Thanks @Tenzer 💯


Update get_started.rst

explicit import to help us find Select2MultipleWidget

Codecov Report

Merging #513 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #513   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           7      7
  Lines         238    238
=====================================
  Hits          238    238

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34cd2e...85adcfb. Read the comment docs.

@andrewbenedictwallace good catch, thanks! documentation improvements are always welcome 👍


Support CNI IPAM DNS config

/kind enhancement
What happened:
CNI IPAM DNS strings not passed to the VM
What you expected to happen:
Currently the VM DNS config comes from launch pod as seen here. This prevents an IPAM DNS config passthrough when a VM solely uses Multus network.
Please use IPAM DNS config when the VM only uses Multus network
@phoracek
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

@rootfs in case that you are using whereabouts or static CNIs, there is an option there to configure also DNS servers

@ravidbro yes, i added DNS nameservers in whereabouts, but it is not picked up by the launcher Pod.

Then maybe the direction should be a bug there.

@ravidbro see this

/area networking

/assign @phoracek
Maybe you can have a look?

/reopen
/sig network

/remove-lifecycle rotten
/assign @maiqueb


[Snyk] Security upgrade cryptography from 39.0.0 to 39.0.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

requirements-dev.txt

⚠ Warning
moto 2.0.9 has requirement setuptools==44.0.0; python_version < "3", but you have setuptools 39.0.1.

Vulnerabilities that will be fixed
By pinning:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

509/1000  Why? Has a fix available, CVSS 5.9
Denial of Service (DoS) SNYK-PYTHON-CRYPTOGRAPHY-3172287
cryptography:  39.0.0 -> 39.0.1
No
No Known Exploit

526/1000  Why? Recently disclosed, Has a fix available, CVSS 4.8
Expected Behavior Violation SNYK-PYTHON-CRYPTOGRAPHY-3314966
cryptography:  39.0.0 -> 39.0.1
No
No Known Exploit

581/1000  Why? Recently disclosed, Has a fix available, CVSS 5.9
Use After Free SNYK-PYTHON-CRYPTOGRAPHY-3315324
cryptography:  39.0.0 -> 39.0.1
No
No Known Exploit

656/1000  Why? Recently disclosed, Has a fix available, CVSS 7.4
Access of Resource Using Incompatible Type ('Type Confusion') SNYK-PYTHON-CRYPTOGRAPHY-3315328
cryptography:  39.0.0 -> 39.0.1
No
No Known Exploit

551/1000  Why? Recently disclosed, Has a fix available, CVSS 5.3
Timing Attack SNYK-PYTHON-CRYPTOGRAPHY-3315331
cryptography:  39.0.0 -> 39.0.1
No
No Known Exploit

581/1000  Why? Recently disclosed, Has a fix available, CVSS 5.9
Denial of Service (DoS) SNYK-PYTHON-CRYPTOGRAPHY-3315452
cryptography:  39.0.0 -> 39.0.1
No
No Known Exploit

581/1000  Why? Recently disclosed, Has a fix available, CVSS 5.9
Denial of Service (DoS) SNYK-PYTHON-CRYPTOGRAPHY-3315972
cryptography:  39.0.0 -> 39.0.1
No
No Known Exploit

581/1000  Why? Recently disclosed, Has a fix available, CVSS 5.9
Denial of Service (DoS) SNYK-PYTHON-CRYPTOGRAPHY-3315975
cryptography:  39.0.0 -> 39.0.1
No
No Known Exploit

581/1000  Why? Recently disclosed, Has a fix available, CVSS 5.9
Denial of Service (DoS) SNYK-PYTHON-CRYPTOGRAPHY-3316038
cryptography:  39.0.0 -> 39.0.1
No
No Known Exploit

661/1000  Why? Recently disclosed, Has a fix available, CVSS 7.5
Denial of Service (DoS) SNYK-PYTHON-CRYPTOGRAPHY-3316211
cryptography:  39.0.0 -> 39.0.1
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)
🦉 Denial of Service (DoS)
🦉 Denial of Service (DoS)
🦉 More lessons are available in Snyk Learn

Superseded by https://github.com/Crown-Commercial-Service/digitalmarketplace-utils/pull/837


More informative error message about the key error that occurs when we get a detached ontology class in the schema

Is it advantageous to demand completely connected ontology structure? Should we just warn about detached nodes instead?

Issue obsolete after recent changes