Is following error expected?

Please describe the problem you encountered in the DuckDB documentation and include the "Page URL" link shown below.
Note: only create an issue if you wish to report a problem with the DuckDB documentation. For questions about DuckDB or the use of certain DuckDB features, use GitHub Discussions, Stack Overflow, or Discord.

Page URL: https://duckdb.org/docs/sql/query_syntax/with.html
If I put alias "a" before its not working -
I just need a for loop counter for the depth of the array elements (value of o.n=3). If I put alias "a" later it works - thank you!
Sudhir
duckdb> create table o as select json_array_length(data.items)::int n from 'oci.json';
┌───────┐
│ Count │
╞═══════╡
│     1 │
└───────┘

duckdb> with  recursive r(n) as (select n from a union all select r.n-1 n from a,r where r.n>0), a as (select * from o) select n from r;
┌───┐
│ n │
╞═══╡
│ 3 │
│ 2 │
│ 1 │
│ 0 │
└───┘

duckdb> with a as (select * from o), recursive r(n) as (select n from a union all select r.n-1 n from a,r where r.n>0) select n from r;
Parser Error: syntax error at or near "r"
LINE 1: with a as (select * from o), recursive r(n) as (select n from a union all sele...
                                               ^

Hi @smahable, the RECURSIVE keyword has to be used right after WITH, even if the first table in the WITH list is not defined by a recursive expression. So the following should work:
with recursive a as (select * from o), r(n) as (select n from a union all select r.n-1 n from a,r where r.n>0) select n from r;

thank you Gabor
sudhir
On Mon, Mar 11, 2024 at 1:08 AM Gabor Szarnyas @.***>
wrote:

Hi @smahable https://github.com/smahable, the RECURSIVE keyword has to
be used right after WITH, even if the first table in the WITH list is not
defined by a recursive expression. So the following should work:
with recursive a as (select * from o), r(n) as (select n from a union all select r.n-1 n from a,r where r.n>0) select n from r;
—
Reply to this email directly, view it on GitHub
https://github.com/duckdb/duckdb-web/issues/2473#issuecomment-1987694227,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7ECZWCY2X6P57CHG5CXM3YXVC6DAVCNFSM6AAAAABEPNXZTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBXGY4TIMRSG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Forward Routing filter doesn't support path parameters for local forwarding

Describe the bug
I am using forward scheme in my route to forward the request to local controller defined in the gateway application. My controller's API path is something like this:
/api/v1/service/{id}/path where id is path parameter.
As per the documentation of Forward Routing filter,  the path part of the request URL is overridden with the path in the forward URL. That means that whatever was mentioned in the forward:/mycustompath will be added to the url. In this case, i can't route the request to my controller where id will change for each request.
Is there a way to achieve this? We were earlier using Spring cloud zuul and we are now migrating to spring cloud gateway and this is not working for us. I am trying to write a custom filter for this where i modify the correct path in the filter. Is this correct approach for this?
Sample

RewritePathGatewayFilterFactory can help you？

RewritePathGatewayFilterFactory can help you？

@ctlove0523 that wouldn't work for me as i need to forward the request to local endpoint within the gateway itself. The ForwardPathFilter modifies the request for me and i will have to write my own custom filter for this to handle the path as mentioned in the ticket above.

@ctlove0523 that wouldn't work for me as i need to forward the request to local endpoint within the gateway itself. The ForwardPathFilter modifies the request for me and i will have to write my own custom filter for this to handle the path as mentioned in the ticket above.

We should add some things to the exchange attributes like:

original path
original query parameters
original uri template variables

We should add some things to the exchange attributes like:

original path
original query parameters
original uri template variables

Thanks @spencergibb that's exactly what i need to preserve the original path with request parameters. This was already being done in spring cloud zuul. Any idea if this will be available in spring cloud gateway anytime soon?

Thanks @spencergibb that's exactly what i need to preserve the original path with request parameters. This was already being done in spring cloud zuul. Any idea if this will be available in spring cloud gateway anytime soon?

Not immediately. TBH a pull request will be there fastest way

Not immediately. TBH a pull request will be there fastest way

@spencergibb will simply adding the additional exchange attributes help? wouldn't we also have to modify the ForwardPathFilter to preserve the request and route it as it to the local endpoint.
Route route = exchange.getAttribute(GATEWAY_ROUTE_ATTR); 		URI routeUri = route.getUri(); 		String scheme = routeUri.getScheme(); 		if (isAlreadyRouted(exchange) || !"forward".equals(scheme)) { 			return chain.filter(exchange); 		} 		exchange = exchange.mutate() 				.request(exchange.getRequest().mutate().path(routeUri.getPath()).build()) 				.build(); 		return chain.filter(exchange);
As per the current implementation of ForwardPathFilter it just overrides anything after forward:/{newpath} and add this to the request path. What we want is to preserve the path and query parameters.
Another difference between spring cloud zuul and cloud gateway is the order of RoutePredicateHandlerMapping and ZuulHandlerMapping. ZuulHandlerMapping intercepts the request first with forward scheme, runs the zuul filters and then forwards the same request to local endpoint defined in the gateway application, where as in cloud gateway the request is intercepted first by RequestMappingHandlerMapping even if the gateway has defined a route with forward scheme. The spring cloud gateway filters are not run if the request is already handled by Request mapping handler.

@spencergibb will simply adding the additional exchange attributes help? wouldn't we also have to modify the ForwardPathFilter to preserve the request and route it as it to the local endpoint.
Route route = exchange.getAttribute(GATEWAY_ROUTE_ATTR); 		URI routeUri = route.getUri(); 		String scheme = routeUri.getScheme(); 		if (isAlreadyRouted(exchange) || !"forward".equals(scheme)) { 			return chain.filter(exchange); 		} 		exchange = exchange.mutate() 				.request(exchange.getRequest().mutate().path(routeUri.getPath()).build()) 				.build(); 		return chain.filter(exchange);
As per the current implementation of ForwardPathFilter it just overrides anything after forward:/{newpath} and add this to the request path. What we want is to preserve the path and query parameters.
Another difference between spring cloud zuul and cloud gateway is the order of RoutePredicateHandlerMapping and ZuulHandlerMapping. ZuulHandlerMapping intercepts the request first with forward scheme, runs the zuul filters and then forwards the same request to local endpoint defined in the gateway application, where as in cloud gateway the request is intercepted first by RequestMappingHandlerMapping even if the gateway has defined a route with forward scheme. The spring cloud gateway filters are not run if the request is already handled by Request mapping handler.

The trouble is what part of the existing path should go there?

The trouble is what part of the existing path should go there?

if the original path has path variables and query parameters then ideally these should be added.

if the original path has path variables and query parameters then ideally these should be added.

What i ended up doing in my code was to write a custom filter to route to the internal path to my uri.
uri: forward:/
predicates:
      - Path=/api/v1/abc/*/xyz
      - Method=GET

Here is the CustomForwardPathFilter that i ended up creating:
@Override
    public Mono<Void> filter(ServerWebExchange exchange, GatewayFilterChain chain) {
        Route route = exchange.getAttribute(GATEWAY_ROUTE_ATTR);

        URI routeUri = route.getUri();
        String scheme = routeUri.getScheme();
        if (isAlreadyRouted(exchange) || !"forward".equals(scheme)) {
            return chain.filter(exchange);
        }
        ServerHttpRequest request = exchange.getRequest();
        String customPath = String.format("/internal%s", request.getPath().toString());

        return Mono.just(exchange.mutate()
                .request(exchange.getRequest().mutate().path(customPath).build())
                .build())
                .doOnEach(LogHelper.logOnNext(webExchange -> log.debug("Forwarding to URI: {}", webExchange.getRequest().getPath())))
                .flatMap(webExchange -> this.getDispatcherHandler().handle(webExchange));
    }

    @Override
    public int getOrder() {
        return 0;
    }

This should run before the ForwardPathFilter .
Here is my mapping for the api defined in the gateway application.
@GetMapping(path = "/internal/api/v1/abc/{id}/xyz")
    public Mono<String> getResponse() {
       // custom code here
    }

The filter modifies the request from /api/v1/abx/*/xyz to /internal/api/v1/abx/*/xyz.

@Anmol24 can you please share the whole filter?

@leventozkann
You only need to add this additionally to use the dispatcher handler bean, rest of the code is same.
private final ObjectProvider<DispatcherHandler> dispatcherHandlerProvider;

 // do not use this dispatcherHandler directly, use getDispatcherHandler() instead.
 private volatile DispatcherHandler dispatcherHandler;

 public MyForwardPathFilter(
         ObjectProvider<DispatcherHandler> dispatcherHandlerProvider) {
     this.dispatcherHandlerProvider = dispatcherHandlerProvider;
 }

 private DispatcherHandler getDispatcherHandler() {
     if (dispatcherHandler == null) {
         dispatcherHandler = dispatcherHandlerProvider.getIfAvailable();
     }

     return dispatcherHandler;
 }

你好，你的邮件我已经收到，每天会在晚上查看邮件并回复。急事请打电话

@spencergibb Is this feature released in 4.x spring cloud gateway version? If not then by when it will become available?


Docker build workflows timing out

Seemingly on this step (but only for arm64?):
https://github.com/interledger/rafiki/blob/0f0ff4e2f40e042a315d8c85889b4f71d37d451a/packages/auth/Dockerfile#L13
See:

https://github.com/interledger/rafiki/pull/671
https://github.com/interledger/rafiki/pull/638

This is closest related issue I've found, but I don't understand why it might manifest for us now and I don't see any github:/git: in or pnpm lockfile

https://github.com/pnpm/pnpm/issues/4739

Ugh... :upside_down_face:
https://github.com/interledger/rafiki/blob/889807585763faaf4fc68d9a5d49140776d12501/.github/workflows/docker-auth.yml#L13
https://github.com/interledger/rafiki/blob/889807585763faaf4fc68d9a5d49140776d12501/.github/workflows/docker-backend.yml#L13


Detect RPC server crash when co_await'ing

During a co_await of an IAsyncAction or IAsyncOperation, if the completion delegate is released without ever being invoked, then assume that the remote server crashed. Resume the coroutine, and the RPC error will be raised when await_resume() calls GetResults().
Note that this behavior applies only to co_await. If you manually attach a Completed handler, then it is your responsibility to detect server death.
The disconnect_aware_handler is basically the same as the lambda we had been using, just with the additional behavior of resuming the coroutine if it is destructed without ever having been invoked. We null out the coroutine handle on invoke. That lets us detect the error case in our destructor.
This fixes issue #600

/azp run

Backed out the custom context stuff due to UWP issues. Returning to just the disconnection detection.

/azp run


Can't find DLLs in PATH

I have all the DLLs of my dependencies in a single folder, which is part of the user PATH. This way, they are available everywhere and I can run all my applications during development from anywhere, without needing to copy the DLLs to the correct path.
Sadly, Dependencies can't find those DLLs.

Same problem here.


Don't call people for a machine being down

Since we mostly have clusters of machines a machine being down shouldn't be enough to call someone out of hours.
The effects of machines being down should be what calls people.

I think we'll need to add some extra work to ensure things like the DB masters still alert on host failure.

So a db master being down will cause other things to alert. hopefully. If nothing else we should test that somewhere :)

I love this concept, but a part of me says we should still be told about snowflakes going offline. In most instances this will be the quickest way to find and resolve the issue.

Add a per host hiera override for the snowflakes and enable it for everything else?

@surminus icinga would still show them offline so people triaging problems should notice it. Just they wouldn't be woken up for it.
@deanwilson indeed. I did think about that but couldnt be bothered. the snowflakes could have it in their host config.
I might get to this when im bored at devopsdays :)

I heartily approve of you doing this.
It is the way it is because back in the distant past there were many more snowflakes (sorry) - the intention was always that alerts should be from things that users will notice.
If either a machine being down will not have a serious effect on the users, or a machine being down will cause a higher-order effect which causes an alert, then machines themselves should not scream as they die, nor should you mourn their passing.

Rebased.

Closing while me and @dazahern redo this to allow overrides.


feat: enable to select featured organizations in Home and Org Search Pages

closes #1694

TO-DOs

#1766
#1767
#1774
#1768

Preview

Merging reviewed feature "filter orgs by categories" into the main - need at least 1 approval ~


UnboundLocalError in replays/sequence/prioritized.py

Hello, this part of code may raise UnboundLocalError if self.rnn_state_interval <= 1
UnboundLocalError: local variable 'T_idxs' referenced before assignment
https://github.com/astooke/rlpyt/blob/ba824f18f8598521ea4eb9f06e4f9fb129eb599a/rlpyt/replays/sequence/prioritized.py#L67-L72
I post a PR to fix this by change tree_T_idxs to T_idxs, feel free to check it out : )

BTW, there will be an ZeroDivisionError if self.rnn_state_interval = 0
https://github.com/astooke/rlpyt/blob/ba824f18f8598521ea4eb9f06e4f9fb129eb599a/rlpyt/replays/sequence/prioritized.py#L28-L31
Look like the division should be max(1, self.rnn_state_interval)?

I think fixed in that PR.  If not, please re-open!


Issue#141/fixing field filter

…s to make sure the query formats properly
Fixes #141
What was changed?
The build_where_text() class was changed. Specifically in the case where the base_field_label is used, the input string to conditons.append() was changed.
Why was it changed?
When the user would enter anything into the Label subfield of the Field of Definition filter, the application would respond with "no data meets that criteria", even if there was data that should have matched. This made the filter entirely inoperable and the UI less friendly, as there was no indication of what was going wrong on the user side.
How was it changed?
In the old code, the entire input was surrounded by two single quotes making the entire text a string, which included a string variable. In addition, the string around the wildcard characters needs single quotes in order to execute the SQL query correctly. By adding this and tweaking the string so the string variable is a variable rather than a string of the variable name, the query now calls correctly.

…s to make sure the query formats properly
Fixes #141
What was changed?
The build_where_text() class was changed. Specifically in the case where the base_field_label is used, the input string to conditons.append() was changed.
Why was it changed?
When the user would enter anything into the Label subfield of the Field of Definition filter, the application would respond with "no data meets that criteria", even if there was data that should have matched. This made the filter entirely inoperable and the UI less friendly, as there was no indication of what was going wrong on the user side.
How was it changed?
In the old code, the entire input was surrounded by two single quotes making the entire text a string, which included a string variable. In addition, the string around the wildcard characters needs single quotes in order to execute the SQL query correctly. By adding this and tweaking the string so the string variable is a variable rather than a string of the variable name, the query now calls correctly.

Great job on debugging the field filtering issue! Your code fix effectively addresses the core problem, ensuring the field label filters correctly, and the feature now works as expected. This solution aligns well with the product’s priorities, as it directly improves user functionality while maintaining the overall design and architecture. The PR is currently failing due to Pylint warnings, but these are minor linting issues that can be easily resolved to pass the workflow.
Regarding your first commit, you have the option to either fix the issue in the current PR by removing the sensitive data from the branch’s history or create a new PR after cleaning the credentials from the history. I would appreciate Professor Holdener’s guidance on which method she recommends as the best practice. Overall, this is a great fix, and with some minor adjustments, it will be ready for final approval. Keep up the good work!

Great job on debugging the field filtering issue! Your code fix effectively addresses the core problem, ensuring the field label filters correctly, and the feature now works as expected. This solution aligns well with the product’s priorities, as it directly improves user functionality while maintaining the overall design and architecture. The PR is currently failing due to Pylint warnings, but these are minor linting issues that can be easily resolved to pass the workflow.
Regarding your first commit, you have the option to either fix the issue in the current PR by removing the sensitive data from the branch’s history or create a new PR after cleaning the credentials from the history. I would appreciate Professor Holdener’s guidance on which method she recommends as the best practice. Overall, this is a great fix, and with some minor adjustments, it will be ready for final approval. Keep up the good work!

even though you have restored it back to its original state i wonder if you might need to create a new pull request all together because anyone could still just see the username and password by going through the commit history. but then again i leave judgement to the team lead and professor Holdener.

The password needs to be changed, because there is a way find it now.


add private cluster templating for capa

What does this PR do?
Adds support for proxy enabled private cluster templating for template cluster command.
Introduces following flags cluster-type, https-proxy, http-proxy, no-proxy. It makes vpc-cidr flag mandatory, if private-proxy is enabled.
What is the effect of this change to users?
Default behavior stays the same. Users will be able to create proxy enable private cluster via passing --cluster-type proxy-private flag. If proxy-private cluster type is selected, vpc-cidr and https-proxy parameters are mandatory. http-proxy and no-proxy parameters are optional. If http-proxy is not specified, it is set as same values as https-proxy.
What does it look like?
apiVersion: v1
data:
  values: |
    aws:
      region: eu-west-2
      awsClusterRole: default2
    bastion:
      enabled: false
    proxy:
      enabled: true
      http_proxy: "http://internal-a1c90e5331e124481a14fb7ad80ae8eb-1778512673.eu-west-2.elb.amazonaws.com:4000"
      https_proxy: "http://internal-a1c90e5331e124481a14fb7ad80ae8eb-1778512673.eu-west-2.elb.amazonaws.com:4000"
      no_proxy: "test-domain.com"
    clusterName: alextest36
    controlPlane:
      replicas: 1
    machinePools:
    - instanceType: m5.xlarge
      maxSize: 10
      minSize: 3
      name: machine-pool0
      rootVolumeSizeGB: 300
      availabilityZones:
      - eu-west-2a
      - eu-west-2b
      - eu-west-2c
    network:
      vpcCIDR: <IP_ADDRESS>/16
      topologyMode: GiantSwarmManaged
      availabilityZoneUsageLimit: 3
      vpcMode: private
      apiMode: private
      dnsMode: private
      subnets:
      - cidrBlock: <IP_ADDRESS>/18
      - cidrBlock: <IP_ADDRESS>/18
      - cidrBlock: <IP_ADDRESS>/18
    organization: giantswarm
kind: ConfigMap
metadata:
  creationTimestamp: null
  labels:
    giantswarm.io/cluster: alextest36
  name: alextest36-userconfig
  namespace: org-giantswarm

Any background context you can provide?

https://github.com/giantswarm/roadmap/issues/1723

What is needed from the reviewers?
This PR can be tested via specifying cluster-type flag. If flag is not used, behavior should be same as before.
Do the docs need to be updated?
New flags needs to be documented.  New behavior for vpc-cidr needs to be documented as well.
Should this change be mentioned in the release notes?

[x] CHANGELOG.md has been updated

Is this a breaking change?
No.

I’m running a test on goat to generate the private cluster template, and there seems to be issue with following generated cidrBlock syntax, notice the ' ' in subnets block:
      dnsMode: private
      subnets:
      - 'cidrBlock: <IP_ADDRESS>/18'
      - 'cidrBlock: <IP_ADDRESS>/18'
      - 'cidrBlock: <IP_ADDRESS>/18'

The command to used:
./kubectl-gs template cluster --provider capa --organization giantswarm --cluster-type proxy-private --vpc-cidr <IP_ADDRESS>/16 --https-proxy http://proxy.g/
oatproxy.gaws.gigantic.internal:4000 --machine-pool-azs eu-north-1a,eu-north-1b,eu-north-1c --region eu-north-1 > private-cluster.yaml

Re-tested and looks good now.

@bdehri What's your criteria for hiding and mentioning the new flags? This PR is adding 8 flags. Four of them are set to hidden. Four are mentioned in the changelog. But some of the hidden ones are mentioned in the changelog, while some non-hidden ones are not mentioned.
If any of the new flags is used with a provider other than capa, the user ideally should get an error. (Not sure how this is handled in other cases currently. Anyway, just ignoring silently is not helpful.)


BN does not use field of the structure if structure have only one field

Binary Ninja Version: 3.4.4090-dev
Platform: Windows 11 Version 22H2
Structure:
struct SERVICE_DESCRIPTIONA
{
    char* lpDescription;
};

HLIL:
Info = "My description"
ChangeServiceConfig2A(svc_handle, SERVICE_CONFIG_DESCRIPTION, &Info)

I expect it to be like this:
Info.lpDescription = "My description"

I've tried it with integer field, it's same.
Test code:
#include <stdio.h>

struct test {
    int sy;
};

int main() {
    struct test t;
    t.sy = 42;
    printf("%d", t.sy);

    t.sy = 40;

    return 0;
}

HLIL:
14001187c  struct test var_f4 = 0x2a
14001188d  j_printf("%d", 0x2a)
140011892  struct test var_f4_1 = 0x28

Might be a duplicate of #899 (or, at the very least, highly related).


[bug] HBM flat QUAD mode determination method is incorrect

Hi there,
In https://github.com/intel/xFasterTransformer/blob/main/benchmark/run_benchmark.sh#L224, use NUMA nodes to confirm HBM flat mode or EMR SNC-2 mode. Actually, there are some blank space  after "NUMA node3 CPU(s):" and then it takes for EMR SNC-2 mode. Here is an example for HBM CPU flat QUAD mode.
lscpu | grep "NUMA node3 CPU(s):"
NUMA node3 CPU(s):
[root@node1 bin]# lscpu | grep "NUMA:"
[root@node1 bin]# lscpu | grep "NUMA"
NUMA node(s):                       4
NUMA node0 CPU(s):                  0-39,80-119
NUMA node1 CPU(s):                  40-79,120-159
NUMA node2 CPU(s):
NUMA node3 CPU(s):

So need to use gsub to remove all the blank space first, thanks.
numa_nodes_info=$(lscpu | grep "NUMA node3 CPU(s):" | awk -F ':' '{gsub(" ", "", $2);print $2}')

Fixed


Mininval remote submissions failing

Hello,
Thank you so much for organizing FALCON - I think the field will benefit hugely from it.
I'm not sure if this is the right place to ask technical questions about working with FALCON, but I couldn't find any other discussion place.
I've been trying to work out how to set up a model to participate in the EvalAI challenge. For now, I'm just using a simple wiener filter while I make sure that my *_decoder.py and *_sample.py files work correctly. I've modeled my approach based on the sklearn decoder example you've provided.
Locally, everything works fine, I've tested it on m1 and m2 with no problems. I've prepared a docker file (copied below) and made a submission with the EvalAI CLI using the minival phase. However, all of my submissions so fair failed on remote, even though the same code works locally.
When I make a submission for m2, it seems to run fine, but the final status on EvalAI is "Failed".
The stderr file associated with a run (here)  shows the scores printed out by the evaluator:
INFO:falcon_challenge.evaluator:Evaluation: Docker side
INFO:falcon_challenge.evaluator:Loading GT from /tmp/ground_truth.pkl
INFO:falcon_challenge.evaluator:Loading submission from /tmp/submission.pkl
INFO:falcon_challenge.evaluator:Phase: minival
20201019: 0.24531026060239944
20201020: 0.3941600642726192
20201027: 0.3963393503854379
20201028: 0.22413372183382727
Returning result from phase: minival: [{'minival_split_m2': {'Normalized Latency': 0.0034699689976421476, 'Held In R2 Mean': 0.31498584927357093, 'Held In R2 Std.': 0.08061598039606627, 'Held In 20201019 R2': 0.24531026060239944, 'Held In 20201020 R2': 0.3941600642726192, 'Held In 20201027 R2': 0.3963393503854379, 'Held In 20201028 R2': 0.22413372183382727}}]

This are exactly the same scores I get running it locally, so I would think that the evaluator ran correctly. There's nothing after that in either stdout or stderr files, but the status is still "Failed".
Would you know what could be the cause of this, and how can I fix that?
COPY OF THE DOCKER FILE FOR REFERENCE
# Use a base Docker image with necessary dependencies
FROM pytorch/pytorch:2.1.2-cuda11.8-cudnn8-devel

# Install additional system dependencies
RUN apt-get update && apt-get install -y git

# Clone the falcon-challenge repository
RUN git clone https://github.com/snel-repo/falcon-challenge.git
RUN pip install -e falcon-challenge

# Copy the requirements.txt file and install Python dependencies
COPY wiener_requirements.txt /app/requirements.txt
RUN pip install -r /app/requirements.txt

# Set environment variables for local testing
ENV PREDICTION_PATH "/submission/submission.csv"
ENV PREDICTION_PATH_LOCAL "/tmp/submission.pkl"
ENV GT_PATH "/tmp/ground_truth.pkl"

# remote for EvalAI | local for local testing
ENV EVALUATION_LOC remote

# when changing the split, also chage the CMD
ENV SPLIT "m1"
ENV BATCH_SIZE 4

# set to test for EvalAI | minival for local/remote development
ENV PHASE "minival"

ENV EVAL_DATA_PATH "/dataset/evaluation_data"

# Add necessary files to the Docker image
ADD ./wiener_bare wiener_bare
ADD ./utils utils
ADD ./models models
ADD ./wiener_decoder.py wiener_decoder.py
ADD ./wiener_sample.py wiener_sample.py
ADD ./hps.yaml hps.yaml

# # Set the working directory
# WORKDIR /app

# Specify the command to run the decoder
CMD ["python", "wiener_sample.py", "-s", "m1", "-m", "per-day"]

I'm not the person to answer the technical questions here and definitely those folks will get back to you when we get a handle on it. Just wanted to mention how much we appreciate you taking the time to report back your issues/experiences!!! Also we appreciate your patience as we iron out these issues.

Of course, happy to help in a small way - FALCON is a greatly appreciated contribution to the field, and one that was really needed! I'm excited to see it being adopted as a benchmark in future work!
P.s. Joel and Brianna have been in touch by email and they have already addressed these issue, thank you!


Clarify relationship to original project

The README says:

For convenience this is a dump of the RASCSI archive RaSCSI version 1.47 available at: http://retropc.net/gimons/rascsi/

It’s not just a mirror anymore. Is there any hope to merge improvements from GIMONS RaSCSI into akuker/RaSCSI or vice versa, or are the two effectively different projects with the same name now?

I've been watching GIMONS' project for updates, but haven't seen any since April.
This project is a fork of GIMONS' project. He has the code available on his web page, but doesn't have a github repo or anything like that to allow community submissions. (I sent him a bug fix for 1.47, but doesn't look like he's pulled it into his page)
I also translated the entire project into English, so, IMO they're two different projects that are compatible with each other. I have a lot of planned updates to the code that will make it even more different, beyond just the English vs Japanese.
GIMONS is also targeting a completely different hardware architecture, the Sharp X68000. I don't have one of these, and have no way to see if my changes are still compatible.
Good suggestion though! I'll try to summarize these ramblings in the README


Localpath provisioner regression v1.21.3: Non-root users can't write to volume

Environmental Info:
K3s Version:

Broken on v1.21.3+k3s1
Workingo on v1.20.9+k3s1

Node(s) CPU architecture, OS, and Version:

kernel and arch: Linux 5.12.19-300.fc34.x86_64 x86_64 x86_64 x86_64 GNU/Linux
OS: Fedora CoreOS 34
Selinux disabled completely

Cluster Configuration:

Single standalone node (server + agent all in one)

Describe the bug:
Permissions appear to be incorrect on PVC's created with local path provisioner. On v1.21.3 I see the PVC directories under /var/lib/rancher/k3s/storage created with 0700 and owned by root. On v1.20.9 I see the PVC directories under /var/lib/rancher/k3s/storage created with 0777. The 0700 permission forbids non-root users from writing any data to these PVC directories when they're mounted into containers where as the old 0777 permissions allowed non-root users to write immediately without any further configuration
Steps To Reproduce:

Install k3s binary for v1.21.3 in /usr/local/bin and run k3s systemd unit as follows:

Description=Lightweight Kubernetes
Documentation=https://k3s.io
After=network-online.target
Wants=network-online.target

[Service]
Type=notify
EnvironmentFile=-/etc/default/%N
EnvironmentFile=-/etc/sysconfig/%N
EnvironmentFile=-/etc/systemd/system/k3s.service.env
ExecStart=/usr/local/bin/k3s server
KillMode=process
Delegate=yes
LimitNOFILE=1048576
LimitNPROC=infinity
LimitCORE=infinity
TasksMax=infinity
TimeoutStartSec=0
Restart=always
RestartSec=5s

[Install]
WantedBy=multi-user.target

Expected behavior:
Should have same behaviour as 1.20.9 (non-root users should be able to write to a PVC created by local-path provisioner without any additional work)
Actual behavior:
Not possible in 1.21.3. Need to chmod the PVC directory as 0777 before that is possible (or chown with the container user id)
Additional context / logs:

Backporting

[ ] Needs backporting to older releases

Duplicate of https://github.com/k3s-io/k3s/issues/3704

Closing as a duplicate (thanks @ChristianCiach !)


Feature Request: Trusted Web Activities instead of webview wherever possible

Feature Request
#PWA + #TWA === ❤
Ionic version:

[x] 4.x
Describe the Feature Request

Trusted Web Activities instead of webview wherever possible
Describe Preferred Solution

https://developers.google.com/web/updates/2019/02/using-twa

Mainly Latest Android (Chrome) as of now!

Hi there! Thanks for the issue. Though as this the repo for the UI portion of the framework. Any issue/feature request/question regarding the native layer should be opened on the cordova repo or capacitor repo.
A small note here, TWA are not a perfect solution for everything. While they are a nice feature, there are some limitations. Not being able to extend a web apps capabilities with native plugins being one of them. So while they may work for some people, they're not a drop in replacement for everyone.
Closing this for now, as again, this is not an issue for the UI portion of the framework.


[build] fix computer capability arch flags, add PTX, handle PTX

Now that https://github.com/pytorch/pytorch/pull/48891 has been merged I have a better understanding of how the arch code are generated.
It looks like your original wasn't producing them correctly, as -gencode=arch=compute_{cc},code=compute_{cc} generates a PTX code and not the normal compilation code. Looking at
https://github.com/pytorch/pytorch/blob/4434c07a2c0ba4debc6330063546f600aee8deb3/torch/utils/cpp_extension.py#L1556-L1563
It needed to be -gencode=arch=compute_{cc},code=sm_{cc} in your code in first place. notice that the last bit is code=sm_ and not code=compute_.
So as a follow up to https://github.com/microsoft/DeepSpeed/pull/578, this PR

[x] replaces s/code=compute_/code=sm_/ for normal archs
[x] adds +PTX for the highest arch in the jit-mode
[x] correctly handles +PTX (especially in the case of TORCH_CUDA_ARCH_LIST which was missing from my previous PR)

Do note, I'm new to all this so please kindly verify that I'm doing the right thing. I did compile and tested the resulting binary on my code only.
The weird syntax for PTX I copied from pytorch (link above), and is explained here:
https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html#just-in-time-compilation which explains that this is how PTX is encoded in nvcc flags. Quote:

By specifying a virtual code architecture instead of a real GPU, nvcc postpones the assembly of PTX code until application runtime, at which the target GPU is exactly known. For instance, the command below allows generation of exactly matching GPU binary code, when the application is launched on an sm_50 or later architecture.
nvcc x.cu --gpu-architecture=compute_50 --gpu-code=compute_50

So '-gencode=arch=compute_{cc},code=compute_{cc}')` tells nvcc to enable PTX for that arch. Very confusing.
Thanks.

Thanks @stas00 for the fix. 👍


Add example to demonstrate how it works with sentry and zap

As the title mentioned, added an example test to show it integrates with sentry and zap
(used zaptest/observer and mock sentry transport ;))

Am I right in my assessment that without this approach, you risk losing events if the main loop exits before the sentry client has time to send the event?

Am I right in my assessment that without this approach, you risk losing events if the main loop exits before the sentry client has time to send the event?

Am I right in my assessment that without this approach, you risk losing events if the main loop exits before the sentry client has time to send the event?

Hi @Dombo, I am not sure what this approach means? Could you explain more about what you thought? I am happy to answer it :)
From my understanding, sentry uses #Flush to prevent unintentionally dropping events. (which is what you mentioned.)

Am I right in my assessment that without this approach, you risk losing events if the main loop exits before the sentry client has time to send the event?

Hi @Dombo, I am not sure what this approach means? Could you explain more about what you thought? I am happy to answer it :)
From my understanding, sentry uses #Flush to prevent unintentionally dropping events. (which is what you mentioned.)


Localize https://k8s.io/docs/contribute/ to Portuguese

This is a localization request
What would you like to be added
Localize https://k8s.io/docs/contribute/ into Portuguese
Why is this needed
Readers who are looking at the Portuguese documentation, and who might want to contribute (for example, by reviewing changes) should see pages about how to contribute.
Comments
This issue is resolved once https://k8s.io/pt/docs/contribute/ exists and contains at least stub pages.
/language pt
/priority backlog

Hi @sftim
I think we can close this, right?
Thanks

/assign @sftim

Looks done to me.


Handling of monorepo config on downstream

From packit/specfile#273 (found out during the specfile release)
Partially addressed by #2037

Caused by:
https://github.com/packit/packit/blob/804c96beeb46dbb0ef209e545bd46735809628a0/packit/distgit.py#L595-L598
Reason:
https://github.com/packit/packit/blob/804c96beeb46dbb0ef209e545bd46735809628a0/packit/config/common_package_config.py#L442-L454
Specfile config got synced to the dist-git in previous release, when getting the GPG keys during the next release, we encountered this issue with ambiguous package to be used.
MultiplePackages is a backward-compatible wrapper for monorepo configs, but this doesn't seem to play very well with the preprocessing of the configs and

defaults
top-level keys

Because both of those get propagated all the way to the individual packages. IMO the first branch of the __getattr__ is unreachable, but that's just my instinct.
Notes

There is one occurence of the same issue, but with upstream_project_url that we allow to be defined only on top-level… Not sure how related it is.
It does not make sense to have monorepo config on the downstream, it might make sense to rethink the syncing of the config.

We should probably think about a “Packit-generated” configs for downstream that avoid this kind of issues.

Proposed solution

WARNING
#2037 is a minimal fix to make it work

Introduce a backreference into the package configs, e.g. _package_name that allows going back… In this case, we are given the package config, but we don't know which package we've been given (I'm strongly against passing it as an argument, since it's tied to the package config that's already passed to the method).

As for the other jobs I think we should not let the MultiplePackages object reach the handlers. The handlers should deal with the PackageConfigView(s). We should run one handler for every package config view in the MultiplePackages object.
I think we should understand why a MultiplePackages object is given to the propose-downstream and pull-from-upstream instead of just a PackageConfigView.


SQLClient mistaken parses java logger messages as other_sql client spans

One of my java applications is generating log messages like
2024-09-10 04:04:38,438  INFO [pool-7-thread-61] [LicenseCheckService]	: New live topology available in repository -- will update the license summary

which gets parsed into
{
  "value": "update the license summary\n<13>Nov 30 ",
  "key": "db.query.text"
}

and
2024-11-29 19:17:50,957  INFO [kconsumer-3] [GroupInfoUpdater]	: Skipping group info update pipeline for topology id<PHONE_NUMBER>5296

which gets parsed as
{
  "value": "Update Pipeline\n<13>Nov 30 00:00:03 group-6bdc85d785-mhhtm group-6bdc85d785-mhhtm: 2024-11-",
  "key": "db.query.text"
}

or printing traces
2024-11-30 02:25:25.113022525 (1.04144ms[1.04144ms]) SQLClient 0 UPDATE pipeline [<IP_ADDRESS> as <IP_ADDRESS>.namespace:3306]->[<IP_ADDRESS> as group.namespace:59768] size:0B svc=[namespace/group java] traceparent=[]
2024-11-30 02:25:25.113022525 (427.663µs[427.663µs]) SQLClient 0 UPDATE pipeline [<IP_ADDRESS> as group.namespace:43568]->[<IP_ADDRESS> as kafka.namespace:9092] size:0B svc=[namespace/kafka java] traceparent=[]

or viewing them tempo using
{resource.telemetry.sdk.name="beyla" && duration>2ms && span.db.system="other_sql" && name=~"UPDATE.*"}

because we are checking for the word update, but it could be in the middle of sentence in
https://github.com/grafana/beyla/blob/main/pkg/internal/ebpf/common/sql_detect_transform.go#L83

Ah, thanks for reporting this Endre, I think it's an edge case we didn't think of, the logs must be sent out through some tcp connection. I think we need to tighten that detection.

we are sending these messages out using syslog to a centralized syslog server in this case


Should rights bases be lowercase?

Is your feature request related to a problem? Please describe.
The database and display values for rights bases are both title-cased. Unless there's a good reason for it, the value we store in the database should probably be normalized i.e. lowercase.
Describe the solution you'd like
If this wasn't a conscious choice, change the first value of the RIGHTS_BASIS_CHOICES tuple to lowercase. This will also require a new migration.
Describe alternatives you've considered
If there's a reason for leaving as-is, let's leave it alone!

These can definitely be made lower case.


Add a .gitgnore for SourcePawn.

SourcePawn is the scripting language used to compile .sp files, with the outcome of an .smx file, a plugin that SourceMod can run.

Introduction to SourcePawn 1.7
SourceMod: Half-Life 2 Scripting

I'm going to close this out because the value of maintaining a template like this isn't clear to me.
@shavitush if you feel like this should still be a template listed here, please read the section about specialized templates and open a new pull request that follows the new pattern.


adding the documentation about phiID and correcting few parts

Thanks for contributing a pull request!
Please be aware that we are a loose team of volunteers so patience is
necessary. Assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
Again, thanks for contributing!
Reference issue
Example: Fixes #1234.
What does this implement/fix?
Explain your changes.
Additional information
Any additional information you think is important.

Thank you for the PR. You also removed the base_hoi file. The tests are failing because of that.

Hi @EtienneCmb, now it should be fine. This pull request is only with the new changes in the theory.rst and refs.bib files.

Thank you @Mattehub .


The Theme colors need to customization

I have facing issue with color of ListTile/s of search result the text has color light color and background color is white , how can change or customize the colors

I know this issue is very old, but I have added some code to handle this specific case. I will eventually expose the option to the plugin code as well.

I know this issue is very old, but I have added some code to handle this specific case. I will eventually expose the option to the plugin code as well.


initial decentralizer.js

Story details: https://app.clubhouse.io/dappcentral/story/6511

You sure you want me to review?
--
Alexandra Jacoby
Photographer
vaginaverite.com an unabashed exploration of the plain, ordinary,
mysterious matter of vaginas. For women: so we can see ourselves for
ourselves. Next exhibition: 12/08/2018, NYC.
https://www.instagram.com/alexandrajacoby/  [image:
https://www.instagram.com/grayscalar/]
https://www.instagram.com/grayscalar/  [image:
https://www.instagram.com/vaginaverite/]
https://www.instagram.com/vaginaverite/
On Mon, Oct 22, 2018 at 9:45 PM Brock Haugen<EMAIL_ADDRESS>wrote:

Merged #3 https://github.com/Dappcentral/protocol/pull/3 into master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/Dappcentral/protocol/pull/3#event-1919028755, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AbldLI5jrTarrtjXQtZbIOnxn84Agubiks5unnS8gaJpZM4Xsq1e
.


Some fixes and feature added.

Fixes:

Deployment target did not work, as it were looking in the wrong scriptoption. (worker instead of target)
Removed warning about cloning workers in the targetcloner.
Wrong communicationtype defined for Listener Tentacle.
Added vscode powershell formatting setting to project.
Feature:
Added support for Unicode.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Anders Andersson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

the CLA is signed, not sure why it say otherwise


Add loader option

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@67a29ee). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   91.18%
=========================================
  Files             ?        7
  Lines             ?      692
  Branches          ?        0
=========================================
  Hits              ?      631
  Misses            ?       61
  Partials          ?        0

Flag
Coverage Δ

unittests
91.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67a29ee...c45a9cc. Read the comment docs.


Is anyone has crud-generator template for Adminlte

The builtin templates are nice in the default theme. Is anyone has crud-generator template(stub files) for Adminlte

You're also always welcome to contribute.

Will do once finished

Here you go- http://labs.infyom.com/laravelgenerator/


Fix njs syntax in example

A '`' had got misplaced.

Rebased with master and added Zhidao's Reviewed-by: tag.
$ git range-diff bdb72f3...53e4c4d
-:  ------- > 1:  b757a77 Replace Homebrew section with macOS section
-:  ------- > 2:  b7d2e06 Update copyright year
-:  ------- > 3:  5667332 Fix dockerfile make command
1:  bdb72f3 ! 4:  53e4c4d Fix njs syntax in example
    @@ Commit message

         Reported-by: Zhidao HONG<EMAIL_ADDRESS>         Closes: https://github.com/nginx/unit-docs/issues/69
    +    Reviewed-by: Zhidao Hong<EMAIL_ADDRESS>         Signed-off-by: Andrew Clayton<EMAIL_ADDRESS>
      ## source/scripting.rst ##


Add attachMetadata for ServiceMonitor

I'd like to add attachMetadata to ServiceMonitor.  Same mechanism has already supported by prometheus-node-exporter chart.

@YaSuenag please rebase and bump up the version as suggested by @yellowhat

I fixed confliction, and bump chart version to 0.5.5 . Is it ok?


how to run on pixijs v5?

how to run on pixijs v5?

Use it normally in your PixiJS project, there are no requirements for v5 beyond the example in the readme.


Potential Solution for Simultaneous Movement of Multiple Actors?

I propose two new events. (or just one, see edit <_<)
First, a "Prepare Movement" event, which would just sort of enter a preparation mode, and cause any actor movement events to be registered, but not executed, yet.
Second, an "Execute Movement" event, which just causes all the previously registered movement events to happen simultaneously.
Is this feasible, codewise? I dunno; I'm just tossing out the idea. ^^;
EDIT: I just thought up a better idea, after posting this... Just have one event, and make it a container for other events, like an "if" or "event group" block. Put all the movement inside, and at the end it all goes. That seems like it'd look way nicer, and be easier to understand for newcomers.

Would be cool to have camera movement in there, too.


Update to show Select...on drop down when the bound property has no valu...

...e set

Included in push


this.props.children = null when refreshing?

So I've got React-Router set up as follows:
// App.js
render(){
    console.log(this.props)
    return (
      <div>
        <Header />
        {this.props.children}
        <Footer />
      </div>
      )
  }

// routes.js
export default (
	<Router>
	  <Route path="/" component={App} >
	    <IndexRoute component={HomePage} />
	    <Route path="/destination" component={DestinationIndexHandler} />
	    <Route path="/destination/:slug" component={DestinationHandler} />
	    <Route path="/destination/:slug/:article" component={ArticleHandler} />
	    <Route path="/article" component={ArticleIndexHandler} />
	    <Route path="/article/:slug" component={ArticleHandler} />
	    <Route name='contact' path="/contact" component={ContactHandler} />
	    <Route path="*" component={NotFoundHandler}/>
	  </Route>
  	</Router>
);

And finally:
// server.js
app.get(/^(?!.*(api|.js|.css)).*$/, function (req, res) {
  let location = createLocation(req.url);
  console.log("LOCAL")
  match({ routes, location }, (error, redirectLocation, renderProps) => {
    console.log(location);
      if (error) {
        res.status(500).send(error.message)
      } else if (redirectLocation) {
        res.redirect(302, redirectLocation.pathname + redirectLocation.search)
      } else if (renderProps) {
        let content = ReactDOMServer.renderToString(<RoutingContext {...renderProps} />);
        console.log(content);
        res.status(200).render('index', {
          content: content,
          staticPort: DEV_PORT
        });
      } else {
        res.status(404).send('Not found')
      }
    })
});

For some reason, when I refresh the page, the server side renders the view successfully but the browser renders the home view (IndexRoute). If you remove the IndexRoute, it only renders the header and footer.
If I log in the terminal I get 3 returns, the first and second being:
CHILDREN { '$$typeof': Symbol(react.element),
  type: [Function: ContactHandler],

and finally a call to NotFoundHandler, even though the route is there. Any ideas?

Thanks for your question!
We want to make sure that the GitHub issue tracker remains the best place to track bug reports and feature requests that affect the development of React Router.
Questions like yours deserve a purpose-built Q&A forum. Would you like to post this question to Stack Overflow with the tag #react-router? https://stackoverflow.com/questions/ask?tags=react-router.
We also have an active and helpful React Router community on Reactiflux, which is a great place to get fast help with React Router and with the rest of the React ecosystem. You can join at https://discord.gg/0ZcbPKXt5bYaNQ46.


Unclear resolution mechanics - singleton Func dependency with factory method resolver for a transient IService appears to share instances when the func is invoked

I don't know if this is an issue but can someone explain what's going on here? There's a transient IDependent taking a Func dependency. The Func resolves the IDependency off the kernel via a factory method. There are singleton and transient components for Func registered.
I would expect two transient IDependents (named TransientFunctionallyDependent_SingletonFunctionalDependency) to share the same instance of Func, but then resolve different IDependency instances.
Following is a LinqPad script. Output after.
<Query Kind="Program">
  <NuGetReference>Castle.Windsor</NuGetReference>
  <Namespace>Castle.Windsor</Namespace>
  <Namespace>Castle.MicroKernel.Registration</Namespace>
</Query>

void Main()
{
	staticContainerReference = new WindsorContainer();

	staticContainerReference.Register(
		Component.For<IDependent>()
			.ImplementedBy<FunctionallyDependenent>()
			.Named(TransientFunctionallyDependent_TransientFunctionalDependency)
			.LifeStyle.Transient,
		Component.For<IDependency>()
			.ImplementedBy<Dependency>()
			.Named(TransientDependency)
			.LifeStyle.Transient
			.IsDefault(),
		Component.For<Func<IDependency>>()
			.UsingFactoryMethod<Func<IDependency>>(kernel => () => kernel.Resolve<IDependency>())
			.Named(TransientFunctionalDependency)
			.LifeStyle.Transient
			.IsDefault(),

		Component.For<Func<IDependency>>()
			.UsingFactoryMethod<Func<IDependency>>(kernel => () => kernel.Resolve<IDependency>(/*expected default, or TransientDependency*/))
			.Named(SingletonFunctionalDependency),

		Component.For<IDependent>()
			.ImplementedBy<FunctionallyDependenent>()
			.Named(TransientFunctionallyDependent_SingletonFunctionalDependency)
			.DependsOn(Castle.MicroKernel.Registration.Dependency.OnComponent("dependencyFactoryMethod", SingletonFunctionalDependency))
	);

	var transientFunctionallyDependent_transientFunctionalDependency_doesNotRelease =
		staticContainerReference.Resolve<IDependent>(TransientFunctionallyDependent_TransientFunctionalDependency);
	var transientFunctionallyDependent_transientFunctionalDependency_doesRelease =
		staticContainerReference.Resolve<IDependent>(TransientFunctionallyDependent_TransientFunctionalDependency);
	if (transientFunctionallyDependent_transientFunctionalDependency_doesNotRelease == transientFunctionallyDependent_transientFunctionalDependency_doesRelease)
	{
		"trans+trans - resolved components equal".Dump();
	}
	if (transientFunctionallyDependent_transientFunctionalDependency_doesNotRelease.Dependency == transientFunctionallyDependent_transientFunctionalDependency_doesRelease.Dependency)
	{
		"trans+trans - functionally resolved dependencies equal".Dump();
	}

	var transientFunctionallyDependent_singletonFunctionalDependency_doesNotRelease =
		staticContainerReference.Resolve<IDependent>(TransientFunctionallyDependent_SingletonFunctionalDependency);
	var transientFunctionallyDependent_singletonFunctionalDependency_doesRelease =
		staticContainerReference.Resolve<IDependent>(TransientFunctionallyDependent_SingletonFunctionalDependency);
	if (transientFunctionallyDependent_singletonFunctionalDependency_doesNotRelease == transientFunctionallyDependent_singletonFunctionalDependency_doesRelease)
	{
		"trans+single - resolved components equal".Dump();
	}
	if (transientFunctionallyDependent_singletonFunctionalDependency_doesNotRelease.Dependency == transientFunctionallyDependent_singletonFunctionalDependency_doesRelease.Dependency)
	{
		"trans+single - functionally resolved dependencies equal".Dump();
	}

	transientFunctionallyDependent_transientFunctionalDependency_doesRelease.ReleaseYourDependency();
	if (transientFunctionallyDependent_transientFunctionalDependency_doesNotRelease.Dependency.Disposed)
	{
		"trans+trans - the non-releasing functional dependency was disposed".Dump();
	}

	transientFunctionallyDependent_singletonFunctionalDependency_doesRelease.ReleaseYourDependency();
	if (transientFunctionallyDependent_singletonFunctionalDependency_doesNotRelease.Dependency.Disposed)
	{
		"trans+single - the non-releasing functional dependency was disposed".Dump();
	}

	staticContainerReference.Release(transientFunctionallyDependent_transientFunctionalDependency_doesNotRelease);
	if (!transientFunctionallyDependent_transientFunctionalDependency_doesNotRelease.Disposed)
	{
		"trans+trans+nonReleasing - is not disposed".Dump();
	}
	if (!transientFunctionallyDependent_transientFunctionalDependency_doesNotRelease.Dependency.Disposed)
	{
		"trans+trans+nonReleasing - dependency is not disposed".Dump();
	}
	staticContainerReference.Release(transientFunctionallyDependent_transientFunctionalDependency_doesRelease);
	if (!transientFunctionallyDependent_transientFunctionalDependency_doesRelease.Disposed)
	{
		"trans+trans+releasing - is not disposed".Dump();
	}
	if (!transientFunctionallyDependent_transientFunctionalDependency_doesRelease.Dependency.Disposed)
	{
		"trans+trans+releasing - dependency is not disposed".Dump();
	}

	staticContainerReference.Release(transientFunctionallyDependent_singletonFunctionalDependency_doesNotRelease);
	if (!transientFunctionallyDependent_singletonFunctionalDependency_doesNotRelease.Disposed)
	{
		"trans+single+nonReleasing - is not disposed".Dump();
	}
	if (!transientFunctionallyDependent_singletonFunctionalDependency_doesNotRelease.Dependency.Disposed)
	{
		"trans+single+nonReleasing - dependency is not disposed".Dump();
	}
	staticContainerReference.Release(transientFunctionallyDependent_singletonFunctionalDependency_doesRelease);
	if (!transientFunctionallyDependent_singletonFunctionalDependency_doesRelease.Disposed)
	{
		"trans+single+releasing - is not disposed".Dump();
	}
	if (!transientFunctionallyDependent_singletonFunctionalDependency_doesRelease.Dependency.Disposed)
	{
		"trans+single+releasing - dependency is not disposed".Dump();
	}
}

public static IWindsorContainer staticContainerReference;

public static readonly string TransientFunctionallyDependent = "TransientFunctionallyDependent";
public static readonly string TransientDependency = "TransientDependency";
public static readonly string TransientFunctionalDependency = "TransientFunctionalDependency";
public static readonly string SingletonFunctionalDependency = "SingletonFunctionalDependency";

public static readonly string TransientFunctionallyDependent_TransientFunctionalDependency = $"{TransientFunctionallyDependent}+{TransientFunctionalDependency}";
public static readonly string TransientFunctionallyDependent_SingletonFunctionalDependency = $"{TransientFunctionallyDependent}+{SingletonFunctionalDependency}";

public class Dependent : IDependent, IDisposable
{
	private IDependency _dependency;
	public IDependency Dependency { get { return _dependency; } }
	private bool _disposed;
	public bool Disposed { get { return _disposed; } }

	public Dependent(IDependency dependency)
	{
		_dependency = dependency;
	}

	public void ReleaseYourDependency()
	{
		staticContainerReference.Release(_dependency);
	}

	public void Dispose()
	{
		_disposed = true;
	}
}

public class FunctionallyDependenent : IDependent, IDisposable
{
	private IDependency _dependency;
	public IDependency Dependency { get { return _dependency; } }
	private bool _disposed;
	public bool Disposed { get { return _disposed; } }

	public FunctionallyDependenent(Func<IDependency> dependencyFactoryMethod)
	{
		_dependency = dependencyFactoryMethod();
	}

	public void ReleaseYourDependency()
	{
		staticContainerReference.Release(_dependency);
	}

	public void Dispose()
	{
		_disposed = true;
	}
}

public interface IDependent
{
	IDependency Dependency { get; }
	bool Disposed { get; }
	void ReleaseYourDependency();
}

public class Dependency : IDependency, IDisposable
{
	private bool _disposed;
	public bool Disposed { get { return _disposed; } }

	public void Dispose()
	{
		_disposed = true;
	}
}

public interface IDependency
{
	bool Disposed { get; }
}

Initially I was expecting to get nothing dumped out, but instead I get
trans+single - resolved components equal
trans+single - functionally resolved dependencies equal
trans+single - the non-releasing functional dependency was disposed
trans+single+nonReleasing - is not disposed
trans+single+releasing - is not disposed

And the skipped dispose calls, I would have expected Dispose() to get called too. Again, most likely not a problem with Windsor, I'm trying to resolve bugs I'm likely introducing with my misunderstanding of the mechanics of it.

I just modified that script. So, since the transients have a singleton dependency they are also made singleton? I'll update the initial post.

I forgot to set the lifestyle so the "transient" with the singleton dependency is actually singleton. Nevermind, closing.


Problem to load json with webpack

Hi
I use the Loader with pixi, in a vue.js component with webpack.
my loading function :
    let loader = new PIXI.loaders.Loader()

    let returnJson = require('../assets/data/datas.json')
    console.log(returnJson)

    const returnImg = require('../assets/img/threshold.jpg')

    loader.add({ name:'myJson', url: returnJson })
    loader.add({ name:'myImg', url: returnImg })

    loader.load( (loader, resources) => {
        console.log(resources.myImg)
        console.log(resources.myJson)
    })

I've the good .data for 'myImg'
but this for 'myJson'
    children: []
    crossOrigin: ""
    data:
    "<!DOCTYPE html>↵↵  ↵    <meta charset="utf-8">↵    <title>template-pixi</title>↵    ↵  ↵  ↵

↵    ↵  ↵↵"
    error: null
    extension: "myjson"
    loadType: 1
    metadata: {}
    name: "myJson"
    onAfterMiddleware: MiniSignal {_tail: undefined, _head: undefined}
    onComplete: MiniSignal {_tail: null, _head: null}
    onProgress: MiniSignal {_tail: undefined, _head: undefined}
    onStart: MiniSignal {_tail: undefined, _head: undefined}
    progressChunk: 50
    type: 6
    url: "myJson"
    xhr:XMLHttpRequest {onreadystatechange: null, readyState: 4, timeout: 0, withCredentials: false, upload: XMLHttpRequestUpload, …}
    xhrType: "text"
    _boundComplete: ƒ ()
    _boundOnError: ƒ ()
    _boundOnProgress: ƒ ()
    _boundXdrOnTimeout: ƒ ()
    _boundXhrOnAbort: ƒ ()
    _boundXhrOnError: ƒ ()
    _boundXhrOnLoad: ƒ ()
    _dequeue: ƒ onceWrapper()
    _flags: 2
    _onLoadBinding :null

the Loader see the Json as a simple text, but if i check with a log 'returnJson', I get my file.
Any ideas ?...
Cheers

What is the url that webpack generates? If you hit the generated urls with a browser do you get a different response than resource-loader does?

for the image i've got this :
http://localhost:8080/static/img/threshold.0c7154b.jpg
and it's ok
but for the json
http://localhost:8080/myJson
so i return the index

Seems like a webpack issue if it isn't returning the right url.

Closing this since I believe it is a webpack configuration issue.

Hi, I know this is an old issue  - I'm aencountering the same problem and doing:
import myJson from 'jsonLocation/myjsonFile.json';

const loader = new Loader();
loader
  .add([
    { name: "myJson ", url: myJson },
 ]).load();

Will output the same thing as OP posted.
I realized that myJson  actually returns an actual JSON object/file instead of the path.


Add setting to disable  @return generation for JS Doc comments

Suggestion
🔍 Search Terms

JSDoc / jsdocs

⭐ Suggestion
Add setting to disable the new @return generation for JS Doc comments
This feature was originally added in https://github.com/microsoft/TypeScript/issues/14248
📃 Motivating Example
I worry that some users may not like the change that adds @returns automatically
We can enable this new feature by default, but should have an easy way to turn it off.
💻 Use Cases

My proposal would be to add a new parameter to the docCommentTemplate request that determines if returns are generated or not:
    interface DocCommentTemplateRequest extends FileLocationRequest {
        command: CommandTypes.DocCommentTemplate;
        arguments: DocCommentTemplateRequestArgs;
    }

    interface DocCommentTemplateRequestArgs extends FileLocationRequestArgs {
        generateReturn?: boolean; // new field
    }

/cc @RyanCavanaugh Since I think we should address this before the 4.2 RC

Since I think we should address this before the 4.2 RC

Based on the Iteration Plan RC will be created tomorrow. So, I've created a Draft PR to resolve this issue.
/cc @mjbvz

@mjbvz RC is very soon and this feels like a feature, can we add configurability in 4.3?

This is a new feature in 4.2, so I'm concerned we're going to get complaints about the change in behavior once this feature goes out. Having a setting to disable the new behavior would be helpful if people do not like the new behavior


how to call onMoveUpdate in  controller

hi
how to call onMoveUpdate?
i need get x,y in chart after change Scroll
pls help me

hi， I add a touchEventListener in controller in version 0.1.1， you can use this for get touch point. example is in BarChart basic


Changes for SNAP-2908:

What changes were proposed in this pull request?
[sparkline enhancements]

Adding text above sparklines to display units and time duration of charts.
Formatting sparkline tooltips to display numbers with 3 precision places.

How was this patch tested?

Tested Manually

Please review http://spark.apache.org/contributing.html before opening a pull request.

Review is not required as these are just configuration changes. Hence Merging.


Dynamic IIIF canvas dimensions

References

Fixes #8021

Description
Because images have varying aspect ratios and sizes, our current static default dimensions result in suboptimal layouts in Mirador. This PR sets the default canvas dimensions based on the size of the first bitstream image.
Instructions for Reviewers
This approach uses the IIIF image server's metadata response to set the default canvas size. The image sever response conforms to the IIIF Image API version 2.1.1 (and is supported by Cantaloupe). Using the image server seems reliable and  easy to implement but it does make testing difficult. I have not included a new IT. Alternately, this could be done instead by checking the bitstream image headers in DSpace.
This solution improves the default image layout. But, it's still a good idea to add explicit height and width metadata to the bitstream and this is essential when a single Item contains images of varying sizes.
List of changes in this PR:

Canvas service now has a method that updates the fallback canvas dimensions
A new utility method retrieves the dimensions from the image server via the info.json metadata.

Include guidance for how to test or review your PR.
Reviewers should be able to create a new Item with "dspace.iiif.enabled" and add a single image bitstream. The canvas dimensions in the IIIF manifest (retrieved by Mirador) should exactly match the dimensions of the image.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[x] My PR passes Checkstyle validation based on the Code Style Guide.
[x] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[ ] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[ ] If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

The big advantage to relying on the image server for image dimensions is support for JPEG2000 files. ImageIO does not support jp2 natively and adding a plugin becomes an extra, non-trivial step. Any institution using jp2 files will already have an image server with support and the IIIF image api provides a reliable way to retrieve the image dimension. So I think the approach taken here is the correct one.

after having reviewed also https://github.com/DSpace/DSpace/pull/8074
I recomend to refactor this contribution reusing the IIIFCanvasDimensionService introduced here https://github.com/DSpace/DSpace/pull/8074/files#diff-afe60b9a926a2f57cb2cc64d227812c2a34f392840a7459135cf06c1dfa020f3

@abollini , I want to be sure I understand what you are suggesting. Are you proposing that:

If default width and height are set to -1 in iiif.cfg then dspace will update the default dimensions for all images (expensive).
If the default height and width are defined in iiif.cfg and are > -1, then that dimension will  always be used as the default.
If the default dimension is NOT defined in iiif.cfg and the first bitstream has no iiif.image.width then the default dimension will be updated based on the dimensions of first image (less expensive).
If the default dimension is NOT defined in iiif.cfg and the first image has dimension metadata then the original default dimensions (currently 2200 x 1600) will be used.

@mspalti : I'm a little confused between all your PRs relating to Canvas Dimensions...I'm not sure I understand the "default" behavior you are going for myself.  If we are able to dynamically determine the Canvas Dimensions at runtime, then why would we need the CLI script added in #8074 ?  Which approach should a site choose?  Should they be encouraged to run the CLI script? Or should they use the dynamic approach and only manually modify dimensions if they dynamic approach doesn't work?
Currently, I'm a bit worried that this PR "conflicts" slightly with #8074....it seems like either we determine dimensions dynamically (this PR's approach), or we need a way to bulk add them automatically (as in #8074).  But, I'm not sure I understand why we'd need both this PR and 8074?  Am I missing something?

@tdonohue , good question. The original intent of this PR was to update the "default" canvas dimension that is used in the absence of height and width metadata. The new default would be calculated ONLY when the first bitstream in the ORIGINAL bundle lacks dimension metadata (e.g. a user uploads an image through the submission UI and sets dspace.iiif.enabled). That's a likely scenario. Of course, if the admin has the #8074 task running periodically, it's also temporary since metadata will eventually be added.
Our hard-coded "default" dimension is a guess and it's often going to be inaccurate. So the intent here is to improve that guess by basing it on the dimensions of the first image. The new guess will be imperfect in lots of cases but it will certainly be a more informed and often quite accurate. It's also an inexpensive operation since the guess requires only the dimensions of a single image even when an item contains many, many images (e.g. a book).
If I understand what @abollini  suggested, this PR might be extended to include a new configuration option for setting the dimensions of all canvases at runtime. (Maybe that's not quite what Andrea is suggesting.) This is certainly possible but yes it is slightly in conflict with #8074 and IMHO the batch CLI approach is better for several reasons. I think it would be the recommended approach.

hi, this PR has still a lot of value regardless to the #8074 one.
The #8074 is the best approach in terms of performance as it provides accurate information about all the bitstream computing these information only one time. Nevertheless, once an item has been created the IIIF viewer experience will be sub-optimal until the task is run.
The current PR assures that the item is immediately functional, including in the submission / workflow phase to allow an easier review.
Due to the performance penalties that imply looking to all the bitstreams to calculate the image size/canvas size I have recommended to

set the configuration to -1 to enable the new behavior. Any values different than that will rely only on the current metadata based solution
guess must be accurate and calculated for each individual bitstream if a metadata based value is not provided
eventually add a new configuration to accept the size of the first bitstream as a best guest

This sounds good, @abollini . The only thing I would recommend is that the default should be setting the dimension dynamically in the absence of metadata in the first image. This will typically be a better estimate than the hard-coded default (which is still needed).
Seems like a useful optimization particularly for less experienced users.
The user overrides this default behavior by setting the configuration to -1 or by adding their own global default dimensions to configuration.
For -1 we still need a cache. I have some work on that stashed that I could quickly add into the project.  It would be nice if this is in 7.2 but not essential.

@abollini @tdonohue : I've implemented the -1 configuration option and added a separate cache for bitstream dimensions. Both the dimensions and cache are working when I test. Unfortunately, because the dimensions are provided by the image server I haven't been able to write and IT for this.
The default is still to update the default dimension if the first image lacks metadata. I can change this if we agree that it's better to leave this out or make it a separate configuration option. At the moment I still think it makes sense as the default behavior.

I haven't yet replicated the connection refused error. But I did discover that the cache is not being used when configured to -1. The reason is this:
https://stackoverflow.com/questions/12115996/spring-cache-cacheable-method-ignored-when-called-from-within-the-same-class
Working on a fix for the cache now. Perhaps that will solve the issue. Also updated how we handle the NPE. A manifest should still be returned in the event that a lookup fails for some reason.

The canvasdimension cache is working again. Sorry I didn't notice that it was broken after the last batch of changes for the -1 config.
As of now, if the image server lookup fails and we have a null response, I'm reverting to the existing fallback dimensions and logging an extra error message. A manifest is returned instead of 500.
@tdonohue , I'm not sure why the image server connection fails for you. One thought is that when you use the Mirador viewer image requests are coming from the Angular host and not the backend. That might be a clue.

@mspalti : There may be something odd going on in my Docker environment with regards to the connection issues. I've realized I hit this same issue in testing two, unrelated PRs today.  I'll try again tomorrow to see if I have better luck.

@mspalti : One last request on this PR... could you please add Docs for the new configurations to the existing IIIF page? https://wiki.lyrasis.org/display/DSDOC7x/IIIF+Configuration

@tdonohue , sure, I will add to the current iiif configuration documentation.
There's actually quite a lot of undocumented iiif functionality right now. I think we need a new page  or pages to cover all of that and this feature might be something to cover in greater detail in the extended documentation.

@mspalti : Feel free to create subpages under that main IIIF page if you wish.  If I feel to rename or move them, I'll do so after the fact.  But, you are more than welcome to simply create what pages make sense to you and let me know when you feel it's ready for "review", etc.


add Cast, Singleton typeclasses, hammerlab.shapeless._ import

Coverage decreased (-2.5%) to 97.5% when pulling fcf9be6d0df2096229c17c9811b54534c410b4a1 on ryan-williams:cast into 1a388f2e6358d5d0baeb41bd1e4106c8efe7eb18 on hammerlab:master.

Coverage decreased (-1.3%) to 98.75% when pulling 9f22c6d7dfc0c5144afb17d612bb44985941eb0e on ryan-williams:cast into 1a388f2e6358d5d0baeb41bd1e4106c8efe7eb18 on hammerlab:master.


i want to make pb file of the 1558M with inference

hi,
i am trying to make pb file for the large models 1558M/774M but unable to do so.
And after making PB file i want to do inference for text generation

Hello there,
Thank you for using gpt2-client! Currently, the module does not feature a way to convert the model checkpoints to a .pb file automatically. It'd be awesome if you could create a feature request in the Issues tab with more information on what you'd like to do with it.
Cheers!


Weave using IPs from Terminated Pods before they're gone

We're using the latest (1.8.2) weave with kubernetes acting as Jenkins slaves. We've hit an issue where if we fire off many simultaneous jobs, weave will eventually assign an IP that's already in use.
kubectl output from an occurrence:
jenkins                         kubernetes-2a1399f18ac344aeb03b9cb88ba86f51-1bf4b275bd071c   1/1       Terminating         0          1m        <IP_ADDRESS>    ip-10-6-8-109.ec2.internal
jenkins                         kubernetes-2a1399f18ac344aeb03b9cb88ba86f51-1bf4b97148a82e   1/1       Terminating         0          1m        <IP_ADDRESS>    ip-10-6-8-109.ec2.internal
jenkins                         kubernetes-2a1399f18ac344aeb03b9cb88ba86f51-1bf4c755811445   1/1       Running             0          24s       <IP_ADDRESS>    ip-10-6-8-109.ec2.internal
jenkins                         kubernetes-2a1399f18ac344aeb03b9cb88ba86f51-1bf4c75768d4e9   1/1       Running             0          24s       <IP_ADDRESS>    ip-10-6-8-109.ec2.internal
jenkins                         kubernetes-2a1399f18ac344aeb03b9cb88ba86f51-1bf4c75ad7d187   1/1       Running             0          24s       <IP_ADDRESS>    ip-10-6-8-109.ec2.internal
The moment this happens, weave-npc (on all members of the cluster) will crash with an ipset dupe error:
time="2017-01-19T23:06:21Z" level=fatal msg="add pod: ipset [add weave->6D5jc_ahi2?fJ^N;K(dAGv<S <IP_ADDRESS>] failed: ipset v6.29: Element cannot be added to the set: it's already added\n: exit status 1"
The issue is reproducible as soon as we apply significant load to the cluster. Let me know if I can provide any other information.

Hi, can you supply the full logs from one of the weave-npc containers that crashes please?

@dolsen-handy are you able to supply the logs?
One other question: do the weave-npc containers restart just once and then keep going, or do they restart continuously?

The logs were in ES and tough for me to pull. Unfortunately we had a time crunch and decided to switch to flannel for our networking.
If time permits, I will try to spin up a dev cluster and re-create this issue.

OK, I'll close this for now; if you get more information please re-open.

#2795 will stop this being a problem

Nice, looking forward to trying weave again. Thanks!


Question: Leveraging Component Definitions

Question
For example, say i am using the NIST 800-53 catalog, I have established which controls are applicable to my environment, however I need to write additional component definitions (CD) for specific applications inside the environment and have them defined in the appropriate .json format.
How can users have trestle reference these CD within the generated NIST-800-53 profile so that when a SSP is generated, it brings in the CD's as well.
as shown in OSCAL Docs
Reason for question
Documentation & Demos do not provide ample documentation or examples of how a CD custom or otherwise can be referenced and added into the actual generated SSP.
Any support and help on this subject is appreciated.

I'm experiencing the same issue as @HerbBoy.   Are there examples of how to assemble an SSP using component models that have been imported into trestle and are satisfying the controls within an imported profile?  Or does this functionality not exist?

Hi @HerbBoy and @ride808 Those are good questions.  In short, we are going to have a release soon that will include updated documentation.  Many recently added features are currently lacking documentation.  With regard to CDs - we do not have that hooked into SSP generation yet but that functionality will be added after the release.  The current SSP generation involves putting content in the SSP markdown that would be better to have in the CDs.  So now that we have functionality to create and edit CDs, we will then add functionality to create SSP's from them.

@fsuits thank you for the response.
Would you be able to provide an expected timeline for the next release or two?

@HerbBoy The next release with updated documentation should be in a few days, and the release involving ssp generation from CDs is perhaps 2 weeks as an estimate.

@fsuits are there development builds and development documentation that are accessible? not full blown releases but is there a dev branch I could clone with the latest? I cloned this and tried to build from source but it ended up being the same version.
I am still looking through everything but figured id post this in case you respond before i figure it out.

@fsuits adding onto what @HerbBoy mentioned -  if there are areas/issues we could help develop to get the component to ssp functionality moved forward/implemented we'd definitely consider helping by contributing back to the project.

Hi @HerbBoy @ride808 Sorry for the delay on the release but several unexpected issues came up.  We have continuously updated the development branch so you can certainly work with it.  In addition there is an initial stab at improved documentation in https://github.com/IBM/compliance-trestle/pull/1185  We expect work for this release to be completed very soon and then begin design for the updated ssp handling based on components.  Help would be welcome but it requires breaking development into workable pieces.  We will be discussing the needed changes for ssp handling with components and see if well defined items of work are possible.

Hi again @HerbBoy @ride808 Just making sure you are aware of our recent release of trestle 1.2.0 with updates to component handling and documentation.  Please give it a try and we welcome feedback.  There are a few more things to add to component handling and then we will switch to creating the ssp from the components.

@fsuits Been working with it since it was released. A couple comments:
Docs:

csv to cd do not have documentation posted, the cli has an information option and i was able to tumble through but not all the answers are available. As in what all the sections are meant to provide in terms of value.
images are not posting (probably already aware of that one).

csv to cd do not have documentation posted, the cli has an information option and i was able to tumble through but not all the answers are available. As in what all the sections are meant to provide in terms of value.

Created issue https://github.com/IBM/compliance-trestle/issues/1243. Please add any specific suggestion you might have there. Thx!

images are not posting (probably already aware of that one).

What images are not posting?

for CSV, is it not intended to allow for multiple control mappings per line?

Yes.

images are not posting (probably already aware of that one).

What images are not posting?

One example this is from here:

@HerbBoy thanks for pointing out the image issue.  I'll need to look into that.  For now  you can find the images in the docs/tutorials directory and view them online like this one: https://github.com/IBM/compliance-trestle/blob/develop/docs/tutorials/ssp_profile_catalog_authoring/trestle_ssp_author_options.png

Yeah we found them last week, just wanted to point it out just in case

@degenaro Before i make an issue about it, the CSV's appear to have issues with whitespace. Is this intended?
example valid: "I am ok."
example invalid: "I am not ok. "

@HerbBoy Please do document the problem in an issue. Ideally, supply an example that fails (to be used to reproduce the problem) and say how it fails - exception, produced OSCAL is incorrect and here's why, etc. Also please indicate the severity. Thanks!

@HerbBoy Please do document the problem in an issue. Ideally, supply an example that fails (to be used to reproduce the problem) and say how it fails - exception, produced OSCAL is incorrect and here's why, etc. Also please indicate the severity. Thanks!

see #1247

@HerbBoy The documents have been fixed and are back online with a slightly different layout.  Thanks to @enikonovad for getting them back up!  https://ibm.github.io/compliance-trestle/

@HerbBoy @ride808 I can answer briefly your main question because it is currently being developed.
You can create component definitions using trestle now, and imp_reqs should have rules associated per component.  If a control has imp_reqs and associated rules, it then means it needs an implementation response.  So the component-generate and assemble allows the specification of prose and status for each response.
ssp-generate will then take a profile and a list of comp-defs as input and generate markdown where the prose from the compdefs is filled in, separately for each component.  And the implementation status is pulled in from the compdef for each response.
But normally a compdef does not have status associated, and the ssp needs to provide that.  So the ssp markdown is used only to provide the overall response for This System - and to set the implementation status for all the responses.  Again the only responses shown are those that have rules associated.  And the prose that came from the compdef may not be edited, but the status may change.  In addition the rule associations may not change by editing the markdown.
I hope this gives a flavor for how it is moving forward.  It is a big change to how things worked but I'm hoping for a pr early next week.

@HerbBoy @ride808 This took much longer than expected, particularly with the holidays, but I have just merged the new approach to ssp generation using components.  The documentation is also up to date, so the develop branch now has the functionality.  It's important to note the role of "rules" in the overall design, so please look at the documentation on how they are defined via props.

Great!  Thanks @fsuits.  I had a look at the merged feature. I'll work on trying out the new functionality this week.

Thanks @ride808 and I appreciate any feedback you might provide.  This is a big change and will bump trestle to 2.0 so we want to make sure no additional breaking changes are needed - including the internal API and not just the CLI functionality.  So I expect some weeks of testing - perhaps 2-3 prior to a release.

@fsuits any plan for when you'll be cutting the next release that will have SSP generation from components in place?

@ride808 We are aiming to do a release very soon - hopefully within a week if testing goes well.


Mac m1 npm start issues

on my Mac machine with m1 chip I'm facing issues in starting node server. Whenever I try to run npm start it gets stuck on running...
npm version is 6.14.7 and node version is 14.7.0
I have tried upgrading downgrading node versions but nothing is helping.

nvm only is involved in installing node and altering your PATH; once you have a version installed and available, nvm’s work is done.
The start script, in particular, is specific to your own project - it’s not something i can help with.


Full ERP CORE dataset not available?

ERP CORE consists of data from 40 participants and 6 different paradigms. MNE includes mne.datasets.erp_core, which consists of only one file (ERP-CORE_Subject-001_Task-Flankers_eeg.fif). Unless I am mistaken, there doesn't seem to be an option to either select a different subject, a different paradigm, or the entire ERP CORE dataset.
I think we should either document this, or even better, add support for the entire dataset (available here as EEGLAB .set/.fdt files).

Okay with me, then we could use it in mne-bids-pipeline, too

I can work on it in a couple of weeks, probably starting mid-September.

The idea here was to just provide a single file to play with (actually, to demonstrate metadata generation in the respective tutorial).
The full dataset is available from the ERP core website.
I don't see much value in including it here, but I won't veto if somebody is willing to add it. I just don't know why and how it would be useful -- there's a BIDS version of the dataset and MNE-Python vanilla cannot handle this. So if anything, a dataset fetched should go into MNE-BIDS, but nobody would expect it there. Hence ... I'm not convinced. Again, I won't veto.

Okay with me, then we could use it in mne-bids-pipeline, too

We already use it there. IIRC we fetch it directly from OSF.

We already use it there.

Yes I know we use the dataset :) By "use it" I mean "use the MNE fetcher" rather than our own custom code to download it.

Okay, I see
But again, this would require we download the BIDS version of the dataset, which MNE-Python vanilla cannot ingest.
If at all, that fetcher should live in MNE-BIDS.

I just thought it is confusing that the dataset is called ERP CORE when it is just one file. So yes, I like that proposal.

If at all, that fetcher should live in MNE-BIDS.

let's not add a fetcher to mne-bids.
Let's rather go with your suggestion from here:

Document the dataset is incomplete and from where the full version can be downloaded. Done.

or
make it required to have mne-bids installed when someone wants to download ERP CORE via the mne-python fetcher.

But again, this would require we download the BIDS version of the dataset, which MNE-Python vanilla cannot ingest.

make it required to have mne-bids installed when someone wants to download ERP CORE via the mne-python fetcher.

FWIW we already have code that uses read_raw_bids with an MNE dataset (tutorials/clinical/30_ecog.py) so I don't consider this point a blocker for filling out the erp_core downloading functionality. Warning or erroring out when mne-bids isn't installed for such fetchers also seems like good idea if we do want to add them. But I'm also fine with just documenting better that we just have a minimal single-file downloader and that there are better/other ways to get the full dataset.

Also, ERP CORE is also available as non-BIDS EEGLAB files.

The documentation of this dataset already mentions that this is just a tiny subset of the original ERP CORE dataset. However, I think this is really hard to find, because it is only available here: https://mne.tools/stable/overview/datasets_index.html#erp-core-dataset
It would be nice to include this description in the docstring of mne.datasets.erp_core.data_path(), but this relies on _data_path_doc, which currently does not have a field for additional notes. Are you OK with adding that, given that this section will be empty for all but one dataset (at least for now)?

Yeah that should be fine

This turns out to be more work than anticipated. The entire docstring business is rather convoluted, and a nice solution will take me more time than I currently have. So unless someone else wants to do it, I'm fine with closing this issue and leaving everything as is (also because I seem to have been the first one to get confused about this dataset, maybe everyone else did find the relevant doc page).


Improved Readme.md . Changes aim to improve the formatting, clarify steps, and ensure consistency throughout your README

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Read our contributing guidelines.
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction).
[ ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

I made the following improvements and changes to the code:
Added a title and a badge with a description to the top of the document.
Improved the formatting for alignment and layout.
Updated the search form to be centered and made it more visually appealing.
Added badges for Hacktoberfest 2023, which are becoming popular in open-source repositories.
Improved the alignment and formatting of various shields (badges).
Improved alignment and formatting of contributor-related badges.
Added a section on "How to Share" with social media sharing links.
Aligned the badges related to issues, pull requests, and help wanted sections.
Improved the alignment and formatting of the list of programming resources, making it more structured and organized.
Added anchor links for easy navigation.
Improved the formatting and layout of the "Translations" section.
These changes aim to enhance the visual appeal and organization of the code.

@sohansai
I made the following improvements and changes to the code:
Added a title and a badge with a description to the top of the document.
Improved the formatting for alignment and layout.
Updated the search form to be centered and made it more visually appealing.
Added badges for Hacktoberfest 2023, which are becoming popular in open-source repositories.
Improved the alignment and formatting of various shields (badges).
Improved alignment and formatting of contributor-related badges.
Added a section on "How to Share" with social media sharing links.
Aligned the badges related to issues, pull requests, and help wanted sections.
Improved the alignment and formatting of the list of programming resources, making it more structured and organized.
Added anchor links for easy navigation.
Improved the formatting and layout of the "Translations" section.
These changes aim to enhance the visual appeal and organization of the code.

not merging


Get version number from package.json

Hi, I found that the version number in package.json and ghec-audit-log-cli.js are inconsistent.
This pull request unifies them.
❯ node ghec-audit-log-cli.js --version
2.0.0

❯ npm link

❯ ghec-audit-log-cli --version
2.0.0

I found another inconsistency between package.json's version number and the latest release's version number but this pull request won't fix it because it should be covered by the release workflow of this project.

@kyanny I've also published a new version with all the changes you've submitted. Here you can find the release notes 🐱  https://github.com/github/ghec-audit-log-cli/releases/tag/2.1.2

Thanks @droidpl! 😸


Fixes #3251 by making sure the app exists, even in the case there are…

… no tasks.
Introduced in 0.15

The tests are broken, and we probably need a new one as well.

:rocket:

@aquamatthias merged, thanks!


Pull to refresh functionality ?

Hi.
Is there any way to active loading by pulling the layout ??
If not, Could you please add this feature?

This is a feature that is built into Xamarin Forms starting with 4.4 (I believe). Look for a control named RefreshView.

This is a feature that is built into Xamarin Forms starting with 4.4 (I believe). Look for a control named RefreshView.

Yes It's RefreshView but I want something like RefreshView that is activated by pulling down the layout and showing any custom view (like Skeleton loading ) instead of loading indicator.

Do not compare this fantastic library with xf's refresh view please

As much as I appreciate your comments, I don't want to copy things that are already (partially) in Xamarin.Forms itself. Enhancing RefreshView to become templateable is something that should be added to Xamarin.Forms (and there are already issues open for it on their GitHub). If I were to spend the effort of building it I would PR it into XF directly instead of this library :)

I came upon this as I wanted to be able to pull-to-refresh to trigger my data load, but then replace the standard XF spinner with the SquidState functionality.  For the benefit of anyone else who comes across this via internet search, I successfully achieved this by setting the RefreshView IsRefreshing binding to OneWay (see https://devblogs.microsoft.com/xamarin/refreshview-xamarin-forms/):
<RefreshView IsRefreshing="{Binding IsBusy, Mode=OneWay}" Command="{Binding LoadCommand}">


#19630 - allow ArrayExpression for populateRelation

Suggested solution for https://github.com/yiisoft/yii2/issues/19630

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
#19630

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.
In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.
Could you add these please?
Thanks!
P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests
This is an automated comment, triggered by adding the label pr:request for unit tests.

Ok, I'll create some tests


[BUG] terraform-harvester-provider cloudinit secret doesn't delete

Describe the bug
Given a terraform file like main.tf that holds a cloud-init secret.  When running
To Reproduce
Steps to reproduce the behavior:

build a main.tf file with the harvester-cloudinit_secret resource
apply it:

TF_LOG=TRACE TF_LOG_PROVIDER=DEBUG terraform apply -var-file="env/local.tfvars" -auto-approve

try to destroy it:

TF_LOG=TRACE TF_LOG_PROVIDER=DEBUG terraform destroy -var-file="env/local.tfvars" -auto-approve

Expected behavior
The terraform resource to be removed when running:
TF_LOG=TRACE TF_LOG_PROVIDER=DEBUG terraform destroy -var-file="env/local.tfvars" -auto-approve

It doesn't delete - even though terraform says it deletes.
Workaround
You need to manually clean up the secret
Environment

Harvester ISO version: v1.2.1 and up
Underlying Infrastructure: baremetal hp dl160s

Additional context
Sample main.tf resource:

resource "harvester_cloudinit_secret" "cloud-config-fileserver" {
  name      = "cloud-config-fileserver"
  namespace = var.FILESERVER_NAMESPACE_DESIRED
  # depends_on = [
  #   harvester_ssh_key.fileserver-ssh-key
  # ]
  user_data = <<-EOF
      #cloud-config
      password: ${var.FILESERVER_VM_PW}
      chpasswd:
        expire: false
      ssh_pwauth: true
      package_update: true
      network:
        version: 1
        config:
        - type: nameserver
          address:
          - <IP_ADDRESS>
          - <IP_ADDRESS>
          - <IP_ADDRESS>
      packages:
        - qemu-guest-agent
        - apt-transport-https
        - neovim
        - wget
        - ca-certificates
        - python3
        - python3-pip
        - jq
        - curl
        - gnupg-agent
        - gnupg
        - lsb-release
        - htop
        - parted
        - fdisk
        - gnupg2
        - neovim
        - software-properties-common
        - coreutils
        - sshpass
        - tmux
        - net-tools
        - unzip
        - debian-keyring
        - debian-archive-keyring
        - apt-transport-https
      runcmd:
        - - systemctl
          - enable
          - --now
          - qemu-guest-agent.service
    EOF

}

This is noticeable on v0.6.4 provider.

Couldn't reproduce on latest master version against Harvester v1.3.1
I tried first just removing the resource block from the .tf file, which worked as expected, removing just the cloudinitsecret resource. Then I also tried removing all resources with terraform destroy which also worked as expected.


Improve the Ui part and provide drag and drop operation of data stream

The most intuitive way is to introduce the imgui-node-editor library

The key to using imgui-node-editor is to need node id and pin id. There are two ways to do this. One is to modify the code in the core folder and add pin id to the core code. The other is to build an id mechanism based on the node pointer and port index through std::hash.In addition, the app in imgui-node-editor is worth learning from, as it abstracts the backend of imgui very well.


Pass configuration to date-picker

As I see in: https://github.com/duan602728596/antd-schema-form/blob/569cec68cce27938748c334efe0107826e042dd2/src/components/custom/custom.tsx#L59
it seems that right now the date-picker component is forced to always show date. In some cases should be interesting to be able to allow the user only pick a date, without time. How this can be accomplished?
Btw, thank you, good library :)

ok, i'll take a look at this place.

Added $showTime and $format configurations to suit your needs.