Deploy on linux server failed

Environment: CentOS 7.6
The deploy log as follows
[root@TestECS ~]# ls
[root@TestECS ~]# cd /
[root@TestECS /]# ls
bin  boot  dev  etc  home  lib  lib64  lost+found  media  mnt  opt  proc  root  run  sbin  srv  sys  tmp  usr  var
[root@TestECS /]# wget -q https://gitee.com/dgiiot/dgiot/raw/master/dgiot_install.sh  && sh dgiot_install.sh
osinfo: CentOS Linux
CentOS Linux 7 (Core)
cpe:/o:centos:centos:7
2021-12-03_13:39:36 970:  dgiot  single deploy  start
PING baidu.com (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=1 ttl=50 time=30.7 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=2 ttl=50 time=30.7 ms
--- baidu.com ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1001ms
rtt min/avg/max/mdev = 30.732/30.744/30.757/0.175 ms
2021-12-03_13:39:37 192:  lanip: <IP_ADDRESS>
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100    13  100    13    0     0     86      0 --:--:-- --:--:-- --:--:--    86
2021-12-03_13:39:37 180:  wlanip: <IP_ADDRESS>
2021-12-03_13:40:10 366:  install_postgres
2021-12-03_13:40:11 373:  create postgres user and group
Changing password for user postgres.
passwd: all authentication tokens updated successfully.
2021-12-03_13:40:13 352:  yum install postgres
2021-12-03_13:41:15 396:  configure postgres
2021-12-03_13:42:00 399:  make install postgres
2021-12-03_13:45:29 404:  make install pg_stat_statements
2021-12-03_13:45:35 410:  build postgres sueccess
2021-12-03_13:45:36 426:  initdb postgres success
2021-12-03_13:45:36 472:  /data/dgiot/dgiot_pg_writer/data/postgresql.conf
2021-12-03_13:45:36 230:  build /lib/systemd/system/dgiot_pg_writer.service
2021-12-03_13:45:37 269:  systemctl start dgiot_pg_writer
2021-12-03_13:45:39 484:  deploy postgres success
2021-12-03_13:45:53 552:  create /data/dgiot/dgiot_parse_server/script/.env success
2021-12-03_13:45:54 561:  install parse_server success
2021-12-03_13:46:16 576:  install install_dgiot_redis success
2021-12-03_13:46:16 316:  build /lib/systemd/system/dgiot_redis.service
2021-12-03_13:46:17 345:  systemctl start dgiot_redis
2021-12-03_13:46:17 316:  build /lib/systemd/system/dgiot_parse_server.service
2021-12-03_13:46:18 345:  systemctl start dgiot_parse_server
2021-12-03_13:46:19 836:  pg_stat_statements has installed
2021-12-03_13:46:20 316:  build /lib/systemd/system/postgres_exporter.service
2021-12-03_13:46:20 345:  systemctl start postgres_exporter
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
2021-12-03_13:46:44 316:  build /lib/systemd/system/dgiot_tdengine_mqtt.service
2021-12-03_13:46:45 345:  systemctl start dgiot_tdengine_mqtt
2021-12-03_13:46:46 275:  build /lib/systemd/system/gofastdfs.service
2021-12-03_13:46:46 310:  systemctl start gofastdfs
mkdir: cannot create directory ‘/data/dgiot/go_fastdfs/files’: File exists
[root@TestECS /]#

The script has been updated, delete the dgiot folder in the data directory, and reinstall

resolved


Undefined from fn should not hang request

Not-quite-small bug 🐞
I'm not sure, this is the right way to deal with undefined from fn, but surely one of. Other way – to throw error.

cc @leo

👍 Thanks!


Restrict scope of modification of root logger to logging_utils

scope this modification down to get_logger method in logging_utils.py
logging.root.handlers = []
logging.basicConfig(level="WARN",
format='SystemLog: %(asctime)s:%(levelname)s : %(name)s : %(lineno)d : %(message)s',
stream=sys.stdout)

Like @danrsc pointed out, the modification should be something like this:
log = logging.getLogger(__name__)

log.setFormatter(...)


Add ttar: plain text archive, replacement for tar

This changeset adds ttar, a plain text replacement for tar, and uses it
for the sysfs fixture archive. The syntax is loosely based on tar(1).
Using a plain text archive makes it possible to review changes without
downloading and extracting the archive. Also, when working on the repo,
git diff and git log become useful again, allowing a committer to verify
and track changes over time.
The code is written in bash, because bash is available out of the box on
all major flavors of Linux and on macOS. The feature set used is
restricted to bash version 3.2 because that is what Apple is still
shipping.
The programm also works on Windows if bash is installed. Obviously, it
does not solve the Windows limitations (path length limited to 260
characters, no symbolic links) that prompted the move to an archive
format in the first place.

This changeset is inspired by @grobie's comment in issue #54.
We needed an archive format because Windows fails when checking out repos with certain files (e.g., file paths that include colons or are longer than 260 characters).
For now, we are using tar: a binary format that is opaque as far as github reviews and git (diff, log -p) are concerned.
@grobie mentioned https://github.com/jtvaughan/ptar which addresses this problem but adds a dependency to another language, C.
This changeset implements a simple plain-text archive in bash 3.2, which is installed by default with all major Linux distributions and with all versions of macOS.
The script can handle plain-text files, symbolic links, and directories.

Yea, this is fine.  Not my normal bash style, but reasonably good.


[Change Request] Codeunit 8 "AccSchedManagement"

Hello, can you please the procedure  SetGLAccAnalysisViewBudgetEntries  set from local to global?
local procedure SetGLAccAnalysisViewBudgetEntries(var GLAcc: Record "G/L Account"; var AnalysisViewBudgetEntry: Record "Analysis View Budget Entry"; var AccSchedLine: Record "Acc. Schedule Line"; var ColumnLayout: Record "Column Layout")
    begin

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 52559.


v1.4 backports 2019-03-07

v1.4 backports 2019-03-07
Included

#7221 -- docs: fix gke guide (@aanm)
#7263 -- test: update k8s versions (@aanm)
#7324 -- cilium: bugtool add xfrm details (@jrfastab)

Not included

#7322 -- Abort identity allocation when endpoint creation is aborted (@tgraf)
^^ @tgraf: This depends on https://github.com/cilium/cilium/pull/7260. LMK whether you want this backported anyway.

Once this PR is merged, you can update the PR labels via:
$ for pr in 7221 7263 7324; do contrib/backporting/set-labels.py $pr done 1.4; done

This change is

test-me-please

test-docs-please

test-missed-k8s

Moving to wip state so v1.4.2 can be cut.

v1.4.2 has been cut, moving back to pending-review.

@brb Regarding #7322: #7260 will also massively benefit the scalability of 1.4 with a very simple backport so I've nominated it for backport into 1.4 as well

Missed k8s was VM start issue:
20:14:45      k8s1-1.11: make: *** [docker-image-no-clean] Error 1
20:14:45  The SSH command responded with a non-zero exit status. Vagrant
20:14:45  assumes that this means the command failed. The output for this command
20:14:45  should be in the log above. Please read the output to determine what
20:14:45  went wrong.
20:14:45
20:14:45          ===================== ERROR - VM PROVISION FAILED =====================
20:14:45
20:14:45          Unable to provision and start VM "k8s1-1.11": exit status 1", vm, err
20:14:45
20:14:45          =======================================================================
20:14:45

test-missed-k8s


Fix encoding in meta title tag and press release teasers

Summary
This PR fixes encoding in the meta title tag and press release teasers. It also appends an ellipsis after 190 characters of the teaser summary.
Metadata

Question
Answer

Did you use a meaningful pull request title?
yes

Did you apply meaningful labels to the pull request?
yes

Did you perform a self review first?
yes

CHANGELOG reflects changes?
yes

Did you perform browser testing?
yes

Risk level
Low

Relevant links
https://thinkoomph.jira.com/browse/RIGA-30

Looks good!
/approved


Dragonbones for phaser 3 fixed version with improvments

Sorry i write it's here, but noone checks PR last time.
I did many dragonbones improvments for phaser 3.
1 - Second scene bug fix.
2 - Draw ordering in animation bug fix.
3 - Diffirent fixes for IK animation.
You can download file here
https://phaser.discourse.group/t/dragonbones-improvments/7673/14?u=maddogmaycry
Enjoy.

Hello, @MadDogMayCry0 do you still have any working examples of your fixes? The site on webhost000 unfortunately went down.
Thanks.

Hello, @MadDogMayCry0 do you still have any working examples of your fixes? The site on webhost000 unfortunately went down.
Thanks.

Hi there.
Sorry, but i don't works with phaser anymore.
Cheers!

Hello, @MadDogMayCry0 do you still have any working examples of your fixes? The site on webhost000 unfortunately went down. Thanks.

https://phaser.discourse.group/t/dragonbones-improvments/7673/24


False positives in import/no-unresolved when command is run from path not correctly cased

I was getting a lot of false positives like this:
   1:34  error  Casing of react does not match the underlying filesystem                                            import/no-unresolved
   2:25  error  Casing of react-redux does not match the underlying filesystem                                      import/no-unresolved
   3:27  error  Casing of redux-form does not match the underlying filesystem                                       import/no-unresolved

In Windows, you have a case-insensitive file system which enables you to enter directories regardless of their casing. I.e. the path: C:\Git\projects\myproject\src can be entered like this:
cd C:\
cd git <-- this is the culprit
cd projects
cd myproject
cd src
npm run eslint

When using your lint rule import/no-unresolved, this will crash with the above false positives.
I think the lint rule should not go further back than the level where the package.json is. This problem will appear when you're using either PowerShell or Bash. And it was a huge pain to figure out...

Can you elaborate?

There. Sorry for the closing and opening.

Interesting. I think as well that perhaps on case-insensitive file systems, that should be detected, so that all paths are lowercased for consistency.

Perhaps, but the test is correct for local projects I think. If you have a util function, for instance, and you import it like this: import util from Util/Util, it should yield and error if the proper casing is util/util`.
The problem here is that the check recursively goes down the path all the way down to root to check the casing, and it shouldn't do that imho.

That makes sense - that as a best practice, you want casing to match exactly, but only within the project root.

Yes, precisely.

Woah! I had no idea that this was the reason I was seeing this on some of my co-developers' machines but not others. :stuck_out_tongue:
Affects the linter-eslint plugin in Atom too, e.g. if you open Atom from a PowerShell by cding to your directory (using incorrect casing) and then running atom .

For me, i've following import.
import * as _ from 'lodash';
it still gives error.
error    Unable to resolve path to module 'lodash'      import/no-unresolved

hmmmz i still got it (on a component a teammate created) but it is not stable, sometimes i get this warning and sometimes not. seems like i don't have any mistakes in the path.
I'm using vscode and windows 8.1 (my team mate uses win7)

Wow, nice find! I've been trying to figure out wth is going on for the past hour and a half. I get the error in Atom when I launch from terminal using incorrect casing somewhere along the way

merged, will go out in v2.8.0 😅


Fix parsing witness script to Payment with FromScript()

Closes #187.
Closes #186.
Please @tiero review this.
@SonnyAD you may want to test this to ensure the bug is fixed.

I confirm it works good for me. Thanks, that was quick.


fix: remove available modules from ancestor

Summary
Giving chunk group relations as following:
A
|  \
B  C
|  /
D

Remove availableModules can remove modules from parents and ancestor, we have this logic before, but for some reason it didn't work properly, this is a fix for this
Test Plan

Require Documentation?

[ ] No
[ ] Yes, the corresponding rspack-website PR is __

!bench

!bench


OU Schedule Links Broken

After the reorganization effort, the agenda links to many notebooks are now broken.

Fixed #177


MGMT-16819: LCA should use the same recert image across seed generation and post-pivot

Seems to work:
The recert image in the SeedGenerator CR:
  recertImage: quay.io/edge-infrastructure/recert:v0

After generating the seed:
sudo cat /var/seed_data/manifest.json
{"seed_cluster_ocp_version":"4.15.0","base_domain":"ibo0.redhat.com","cluster_name":"seed","node_ip":"<IP_ADDRESS>","release_registry":"quay.io","sno_hostname":"seed","recert_image_pull_spec":"quay.io/edge-infrastructure/recert@sha256:4e30af484263497eb652723de40ff99169a88d6ac6605497b1fd041152dbbe0b"}[

If we do this, though, won't seed images used during dev become invalidated the next time the recert image is updated? The exact image used during seedgen would no longer be available in the registry once the tag is updated, unless it is explicitly retagged to save the image

Good point. Possible solutions:

Make sure our infra tags all dev images also with a dummy tag that is simply just the first n letters of their hash

Seedgen CR / LCA parameter to override this pinning behavior

Thanks @donpenney.
@omertuc I think we can do both options.
One note though, essentially the 2nd option already exists today, when creating the seedgen CR the user can provide the recert image by digest, I'm unsure whether a parameter in the CR that triggers the conversion from the image tag to digest is  better than instructing the user to provide the recert image by digest.
On another note, given the overhead this change creates (keeping multiple recert images we can't clean) perhaps recert should be backward compatible, meaning if an older recert image invalidated the seed image a newer recert image should be able to recertify it.

/hold per the invalidated recert image discussion

In the production environment, we'll soon be using the RELATED_IMAGE_RECERT_IMAGE env var from the deployment as the "default" recert image, which would be a SHA reference where the image is protected from deletion. Once that's in place, dev envs would likely be the only cases using a tagged image. So maybe it's sufficient to provide the warning in the designer docs about using a tagged recert image? Could recommend using a mirrored tag if someone would want to be able to use a seed image for longer periods and ensure the same recert image is used. I've done that myself for certain test scenarios, certainly - make a timestamped tag in my own repo and use that in the seedgen CR.
But as noted in another comment, the seedgen can use a SHA reference today, if a user wants to have that explicit image used.
I think we can probably just cover this in the MD files, with warnings/recommendations. Mirroring the image is certainly an easy way to ensure you have the same recert image being used for longer tests

I tend to agree with @donpenney.
In addition, today dev users can benefit from recert improvements as they merge without rebuilding the seed image.
Note that I looked into pushing recert images by tag and git revision (in order to allow this change without losing old revisions) while it's straight forwarded for the CI registry it's the case for mirroring the images to quay.io.

Closed in favor of https://github.com/openshift-kni/lifecycle-agent/pull/401


Floating point exception

Floating point exception when call --uncipherfile mode with previously found key. File to uncipher and pub key found in archive. Any ideas why there are exception ?
test2.zip

no idea... I'll check this later.
Thx for report

Hi !
I've commit a patch for your case, it add a new functionnality : uncipher data with private key (and password if needed)
just try :
python3 ./RsaCtfTool.py --key /tmp/test/test2 --uncipherfile /tmp/test/2.bin


I still got the error message "edu.berkeley.cs#firrtl_2.12;1.2-SNAPSHOT: not found" after publishLocal firrtl

I suspect your versions of firrtl and chisel3 are inconsistent. We recently switched the default Scala version for both from 2.11 to 2.12. Make sure you're on the master branch for both and do a git pull to ensure they're up-to-date.
Alternatively, you can:
sbt +publishLocal

which will publish all cross versions (both Scala 2.11 and Scala 2.12 currently).

I update the build.sbt file with
resolvers ++= Seq(
Resolver.sonatypeRepo("snapshots"),
Resolver.sonatypeRepo("releases")
)
worked successful !! you can have a try

I believe that changing the resolvers is grabbing the published snapshots, not using a locally published version.
If you want to publish locally and use that one, you should use sbt +publishLocal


Using the official hpc base image

Signed-off-by: Mark Rossetti<EMAIL_ADDRESS>

Looks like even though the permission in the job  have write:
https://github.com/jsturtevant/windows-debug/blob/25b91ef0799071037e3a7f332976ac7b53e480de/.github/workflows/images.yaml#L14-L16
The pull request permissions are read only.  I am looking for settings that fix this but haven't found them yet


Adapter namespace is ignored

I have set a namespace in the application adapter:
import DS from 'ember-data';
import DataAdapterMixin from 'ember-simple-auth/mixins/data-adapter-mixin';

export default DS.JSONAPIAdapter.extend(DataAdapterMixin, {
  namespace: 'api/v1'
});

Yet when I log in, http://localhost:4200/api/token-auth/ is called and the namespace seems to be ignored.
I'm using simple auth token as well, so I'm not sure if this problem is simple auth only.
"ember-simple-auth": "1.1.0-beta.1",
"ember-simple-auth-token": "1.0.0",

That behaves as expected. If you want to use the same namespace you're using for the adapter for the authenticator you'd have to configure it for the authenticator as well.


Version Fix

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 8

Clones removed
==============
+ test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  -2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 8

Clones removed
==============
+ test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  -2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1

Clones removed
==============
+ test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  -2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1

Clones removed
==============
+ test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  -2

See the complete overview on Codacy


[BUG] ValueError: microshift_t must be an SELinux process domain

What happened:
https://microshift.io/docs/developer-documentation/local-development/#running-microshift
Encountered following error when executing (cd packaging/selinux && sudo make install):
semodule -i microshift.pp
sepolicy manpage --path . --domain microshift_t
ValueError: microshift_t must be an SELinux process domain:
Valid domains: abrt_t, abrt_dump_oops_t, abrt_handle_event_t, ...

What you expected to happen:
Successful execution and no errors.
How to reproduce it (as minimally and precisely as possible):
Following https://microshift.io/docs/developer-documentation/local-development/ by the letter.
sudo dnf install -y git make golang
git clone https://github.com/redhat-et/microshift.git
cd microshift
make DEBUG=true
sudo dnf install -y selinux-policy-devel
(cd packaging/selinux && sudo make install)

Anything else we need to know?:
Fixed with:
diff --git a/packaging/selinux/microshift.te b/packaging/selinux/microshift.te
index dac081b8..e5d38da1 100644
--- a/packaging/selinux/microshift.te
+++ b/packaging/selinux/microshift.te
@@ -1,5 +1,8 @@
 policy_module(microshift, 1.0.0)

+type microshift_t;
+domain_type(microshift_t)
+
 gen_require(`
     type container_runtime_t, var_lib_t, container_var_lib_t, container_runtime_tmpfs_t, container_t;
     class file { open read };

Environment:

Microshift version (use microshift version): main
Hardware configuration:
OS (e.g: cat /etc/os-release): Fedora 35
Kernel (e.g. uname -a): 5.16.16-200.fc35.x86_64
Others:

Relevant Logs

Thanks!! let's fix this.


Save data type in json

We need the data type of content to display input forms and such correctly. The data type should be validated server-side.

Suggested packages for @bminixhofer:

https://www.npmjs.com/package/data-validate
https://www.npmjs.com/package/validator
https://www.npmjs.com/package/tasdik

This has been done, but in html.


Add Scala to .travis.yml

Fine from my side
@vigsterkr you go ahead

yeah but isn't this part of #3597 already? if so it's fine there... let's just have that rebased that way everything gets tested there in that pr and close this one....


ngAnimate breaks fade-in animation of popover

After including ngAnimate module to my application it breaks fade-in animation of popover.
Demo: http://plnkr.co/edit/3ECNoqBqfUcbwTq3MnVa

versions of angular ui / bootstrap?

From linked plunk:
angularjs/1.3.9/angular.js
angularjs/1.3.9/angular-animate.js
ui-bootstrap-tpls-0.12.1.js
bootstrap/3.3.2/css/bootstrap.min.css

To clarify, it looks like it is breaking when the popover is entering - is this accurate?

@wesleycho, exactly.

Can you try based on current master?  The popover now supports ngAnimate

Closing, as the popover was refactored to support ngAnimate.
Let us know if this is still an issue.

Unfortunately it is still broken. Using ui-bootstrap-tpls-0.13.0-SNAPSHOT.min.js from today's clone. You can check it out at http://plnkr.co/edit/94yNAYcGjWcndpIH9AbL (ui-bootstrap-tpls-0.13.0-SNAPSHOT.js is there loaded from google drive).

Posting more useful Plunker for reference

Reopening as this isn't fixed on master at the moment. Ref: #3506


Can't build Xcode project: linker errors

When I try to build the generated project from Unity in Xcode, I get undefined symbols errors when linking. The symbols are:
_zip
_unzip
_addZipFile
I've tried adding the folder ZipArchive from PluginsCode, as instructed in README.md, at the Classes folder of my Xcode project, and also at Libraries/Plugins/iOS folder, but get the same errors.
What can I do to succeed the build?

Add UnityZipFile.mm from  unity Assets/plugins/ios folder to Xcode project

To-do's for UniZip for Unity & XCode:

add "PluginsCode>iOS>ZipArchive" files & folder to Unity project "Assets\Plugins\iOS"
After that copy from package UnityZip: ">Asset>Plugins" (folders, files) & add to your project VTDB: "\Assets\Plugins"

Alterations for UniZip for iOS successful build:

If package is newly imported after above setup:
(1) Open "ZipArchive.mm" file and REMOVE:

-line 270[dc release]
-line 271[gregorian release]
-line 327[comp release]
-line 328[gregorian release]
-line 40[super delloc]

(2) Open "UnityZipFile.mm" file and REMOVE:

-line 32[zip release]
-line 35[list release]
-line 59[zip release]

-Before Build in XCode select "unity framework" from "unity iPhone" and go to "build settings>other>flags" add "-lz" symbol.
contribution by: https://github.com/Ad-mob-dev


On clone with --changeset .gitignore deleted on first commit

> git tfs info
Found matching Visual Studio version at C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional

git version 2.31.0.windows.1

git-tfs version <IP_ADDRESS> (TFS client library <IP_ADDRESS> (MS)) (64-bit)
 C:\Program Files\GitTfs\git-tfs.exe

I have an environment similar to #1020, so i use clone with --gitignore and --changeset:
> git tfs clone https://tfs.ourcompany.de/tfs/DefaultCollection "$/some/path/in/tfs" --autocrlf=true --changeset=6858 --gitignore=../.gitignore

Now I saw, that the .gitignore file is being deleted on second commit (first commit is the .gitignore file itself, second commit is changeset id).
Is this a bug or a feature? Do you need any further information?

I can reproduce that the .gitignore file is removed on the second commit (which corresponds to the fist imported commit from TFS)
Currently, I cannot tell if this is intended behavior or not, but the gitignore support had a major refactoring/rewrite by @boogisha in PR #1214. Perhaps he can shed some light?

@siprbaum Sure, I'm not using git-tfs for a couple of years now, but my memory is still fresh regarding the mentioned ".gitignore" related PR #1214. I'll have a look.
On a side note, I did a quick check on a different possibility (purely browsing the code through GitHub web interface only for now, so bare with me), having --changeset option cause git-tfs to start with "a clean sheet", perhaps expecting to be the initial changeset to start cloning from, thus not paying attention if there are any files existing already, ending up loosing them (like ".gitignore" one).
If so, major suspect at the moment could be this line:
https://github.com/git-tfs/git-tfs/blob/4d2c52a29a55990dbca7774f97bb29d7b7485997/src/GitTfs/Core/GitTfsRemote.cs#L860... where GetTreeBuilder(null) should possibly be GetTreeBuilder(lastCommit) instead... but this is pure speculation for now, I still need to fire up Visual Studio and give it a proper look, so please take it for what it's worth at the moment.

@siprbaum @astuy There, I've opened a pull request #1382 which seems to address the problem at hand here (indeed being caused by that GetTreeBuilder(null), as hinted earlier).
Please feel free to have a look, or give it a test go, even - "AppVeyor" build artifacts here: GitTfs-0.33.6-96885a41.clone-changeset-keep-commited-files-1381.zip


Adding a folder with target examples for easy testing

Adds an target example that allows to compile Q# code with the compiler built from the source code, and executes the code on the QuantumSimulator for testing.
In the QsCompiler.sln under TestTargets/Simulation set the Example as start up project and simply hit Ctrl+F5. For testing the latest compiler version and whether the produced compilation can be executed on the simulation framework, edit the implementation of Main.qs in that project.
See https://github.com/microsoft/qsharp-compiler/issues/141.

Sorry I didn’t get a chance to review this, but it all happened quickly during the weekend.
I suspect this is going to be problematic in Solid, as now you have circular dependencies among repositories.
Even if it doesn’t get build during the CI build, having this circular dependencies is not a good practice and we should try to avoid it.
An option could be to create these cross-repo projects in Solid; Solid has all the repos as submodules so it would be fairly clean to do it there. Similar to the sanity tests that do the end-to-end testing, we could a X-Dev folder that let’s you have everything from source.
Another option is to create a script that let’s you replace nuget with project references, similar to the old solidify…
The current approach is convenient, but can add a lot of headache in the future…
-a.

From: bettinaheim<EMAIL_ADDRESS>Sent: Saturday, August 24, 2019 11:58:36 AM
To: microsoft/qsharp-compiler<EMAIL_ADDRESS>Cc: Andres Paz<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [microsoft/qsharp-compiler] Adding a folder with target examples for easy testing (#140)
@bettinaheimhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbettinaheim&data=02|01|Andres.Paz%40microsoft.com|c492709dea7e4402b8d208d728c511fd|72f988bf86f141af91ab2d7cd011db47|1|0|637022699180095244&sdata=1HakhCXG24YvBkcw4sHLuZcpbXplD20SxLJ8XRQgQog%3D&reserved=0 requested your review on: #140https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fqsharp-compiler%2Fpull%2F140&data=02|01|Andres.Paz%40microsoft.com|c492709dea7e4402b8d208d728c511fd|72f988bf86f141af91ab2d7cd011db47|1|0|637022699180095244&sdata=r1T%2FSLNqlgwEDWKEFAw%2FWJYE7kiY%2B%2FNpcAN5a5H%2B1J0%3D&reserved=0 Adding a folder with target examples for easy testing.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fqsharp-compiler%2Fpull%2F140%3Femail_source%3Dnotifications%26email_token%3DAFZPL5RI2BSABBEWMYXMYNDQGGAFZA5CNFSM4IPG6WN2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTHP3YZQ%23event-2581576806&data=02|01|Andres.Paz%40microsoft.com|c492709dea7e4402b8d208d728c511fd|72f988bf86f141af91ab2d7cd011db47|1|0|637022699180095244&sdata=%2Bw960PI4kHuK1wui12VXonMp3%2B5h4uiMgc7T43Gfxgk%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFZPL5UDBXBBK4TCRSRHPTDQGGAFZANCNFSM4IPG6WNQ&data=02|01|Andres.Paz%40microsoft.com|c492709dea7e4402b8d208d728c511fd|72f988bf86f141af91ab2d7cd011db47|1|0|637022699180105212&sdata=VRX%2FVLWGYX1izdvFyPEdzeuRn%2BkSgr2vJHv9di2HhzM%3D&reserved=0.


Measure impact of running DDS callbacks when processing ops

(Update) Numbers below are not what they claim to be. This is due to me making mistake and doing percentile(toint(metric), 95), while it should have been toint(percentile(metric), 95)). The general observations are still the same, and the work that is needed to better understand impact of apps is the same, but we should be careful with using numbers below (and better to get latest numbers using right quries)

We need to track clearly op processing time without the cost of running DDS callbacks.
Or other way around - be able to track cost of application callbacks.
Here is some data why it matters - looking at op processing times:

Office_Fluid_FluidRuntime_Performance
| where Data_eventName == "fluid:telemetry:OpPerf:GetDeltas_OpProcessing"
| extend WB = Data_hostScenarioName contains "Whiteboard"
| extend Summarizer = Data_clientType != "interactive"
| summarize count(), percentile(toint(Data_duration / Data_count * 1000), 95) by WB, Summarizer

WB
Summarizer
count
P95

false
false
721491
498

true
false
11198
200

false
true
295747
128

true
true
63241
80

While usage differs between Whiteboard & Chapter1 scenarios greatly, I think the data clearly points out that performance of Chapter 1 scenario is substantially (and statistically significantly) worse than Whiteboard. Summarizer data for both scenarios (where app callbacks should not be installed) supports these claims as well.
This makes it really hard to

Clearly articulate cost to apps, as all we can do is rely on this kind of indirect comparison
We can't easily track framework time and see issues on our side.

Please note that these numbers are really bad. But if you add filter "Data_count > 1000", you sill see them dropping, but still being in pretty bad territory:

WB
Summarizer
count
P95

false
false
3077
168

true
false
655
39

false
true
9600
34

true
true
48131
26

at P50, we get to 6-10ms for best case (processing 1000+ ops, and not Chapter 1), and 28ms for best case for Chapter 1.
That's only 35 ops/sec for Chapter 1 at best case scenario! Ouch!

@anthony-murphy, any thoughts on how to do it centrally (and apply to all future DDSs)?
We already have one potential bottleneck (SharedObject) to apply to 90% of cases, but there is no enforcement here unless it's part of DDS API.
https://github.com/microsoft/FluidFramework/issues/9542 is related issue that is worth considering. In discussion with Curtis, I think we will need to do something here, and one other direction popped up - maybe we will expose a "reboot your data model" kind of flow where runtime detects that we are so behind that we would prefer to move data model to latest state in one go, and then let application to reconnect to data model (same way it does no container load).
"move data model to latest state " may take two forms - apply all the ops without firing any callbacks, or just apply latest state (load latest snapshhot and move to its state, assumes no local changes or presence of 3-way merge in the future).
"Apply ops without firing callbacks" is interesting as it's the simplest model if we can make our system really fast (which is another issue to be opened & investigated). And that asks for more control from container runtime over callbacks.

The issue is that op processing, dds op application, and dds delta callbacks are all synchronous, and currently most dds combine op application, and delta callback.
The fastest and easiest is just to accept that most dds inherit from shared object and leverage that.
If we are ok with that constraint, we need to remove EventEmitter from SharedObject, and instead make the event emitter a private member of sharedObject, and have SharedObject implement the interface IEventProvider, which will proxy to the internal event emitter. We then expose our own protected emit function to be used by dds to emit their events. We can then track the duration of those events which will allow us to remove the event duration from the processing duration.
To go farther would require a much more drastic API change. Basically, DDS wouldn't be full in control of their api. For this i would probably have the processMessage callback implemented by Channels return the event data (name and args) for that message. Application would also only get some proxy object rather than real DDS. The proxy would proxy through the methods of the DDS, and then extends it with eventing based on the return events. I'm not sure such a model would be worth it, or ergonomic for developers

Yes, I was thinking about the second part.
But I think we should start simple (leverage existing SharedObjectCore infra, maybe add one more intermediate object in inheritance chain that would have only this responsibility (to make it easier to use in other places where the rest of SharedObject chain is not used today, though inheritance has its own challenges).
This will give us enough initial data to reason on next steps

One thing to consider if comparing to whiteboard data is that whiteboard has asynchronous op processing (so it can programmatically control which blobs get prefetched before telling the app about the new state from fluid). Fluid framework does not know about this since fluid does not actually support asyn op application: whiteboard has to do this in a way fluid does not understand. Combining this with experimental shared tree only computing the result of applying ops lazily, and I would not be surprised if the cost of applying ops in whiteboard according to the fluid-framework drastically underestimates the actual cost of processing the op in the DDS in addition to not actually including any of the application side costs either.

Makes sense. This basically moves more responsibility to ShareTree and Whiteboard to measure the impact of such processes to responsiveness of the application.
One side-effect to share - https://github.com/microsoft/FluidFramework/issues/9542 talks about potential solutions to a problem of too many ops / slow op applications. Whatever solution we come up to will depend on our ability to notice when system (as a whole) is not catching up and thus needs way out. With async processing runtime will not have full picture into these costs.
At the same time, you have more capabilities to detect such cases and take actions on your side, which is similar in nature.

@justus-camp , are you planning on working on this issue this month? It is assigned to April. I'll move it to May.

Don't think I'll be getting to this one. This was initially going to be one of my ramp-up tasks but I don't think it's planned for me currently. Going to un-assign myself


PowerShellGet doesn't work with NuGet CredentialProviders

Microsoft's VisualStudio.com has started hosting NuGet Repositories, but the authentication scheme that they've chosen requires a nuget.exe credential provider plugin.
I was able to get this to work with PowerShellGet but only by directly calling the NuGet.exe which is installed by PowerShellGet to add the source with credentials.
Expected Behavior

If Credentials are provided when Register-PSRepository is called, then
PowerShellGet should store those credentials!
If NuGet is present, and credentials are provided when Register-PSRepository is called, then PowerShellGet should also call nuget sources add with those credentials, to store the credentials for NuGet publishing.
PowerShellGet should not specify -noninteractive on publishing unless there's a -noninteractive switch provided to the user. This terminally breaks authentication scenarios which require a credential provider.

Current Behavior
Register-PSRepository doesn't store credentials in any meaningful way.
Find-Module with authentication (like on VSTS repositories) requires the user to provide the credentials every time -- even when they were already provided in the call to Register-PSRepository
Publish-Module does not work with VSTS repositories, because they use a Credential Provider which requires prompting, even when the credentials are provided via the -Credential parameter.
Workaround
Users need to download the VSTS Credential Provider and put it next to the nuget.exe downloaded by PowerShellGet, and then call that specific nuget.exe sources add to register their repository with credentials.  And then do it again, every 90 days.
See this gist

Since find and install work when passing -credential (although I shouldn't have to, since I passed it at registration time), I'm tempted to conclude that the credentials are simply not being passed at all when I'm trying to Publish-Module -Credential and that perhaps this could be fixed separately from the credential caching problem.

in the latest release of powershellget, it is impossible altogether to publish modules to vsts package feeds.  You are forced to downgrade to version 1.5.0.

resolved with https://github.com/OneGet/oneget/pull/442


I am not able to see the cluster in Rancher UI

We have a setup that uses the Azure AD groups for permissions. I am a member of the admin group, but I can't see the clusters in Rancher UI.
What should I do to get the access?

What version of Rancher are you using?
What Rancher roles does your admin group have, anything global?
Has the admin group been added as a member to the cluster?
In your browsers Developer Tools window, can you see the cluster in the response to the network request to /v1/provisioning.cattle.io.clusters?

No update, closing


Get rid of Iron Router

It doesn't fulfill any purpose besides routing.
We can use WebApp.connectHandlers for that.

Also this can cause some unexpected side effects. Right now I cant use the preview feature because I have some IronRouter global hooks that interfere with these routes :(

That's not Iron Router though – that's how routes work in general. You can configure the emails prefix to be something else of you have a /emails/preview route already.

You can't use FlowRouter for this, it's client only. You have to use something like Picker.
But I also vote for 2nd option, the less dependencies the better.
I can probably do this because we're just moving our app from IR to FR , which means we need to get rid of the IR dependency before we can use this package again.

You can't use FlowRouter for this, it's client only.

Ah, true. Forgot that. Would love a PR for this.

So I implemented this with meteorhacks:picker, it works great.
I started off with WebApp but actually there's a lot of stuff you need to do to process the routes and params if you want to keep the package flexible. Besides WebApp docs are kind of lacking. Picker is just WebApp plus just enough to make live easy, so I took the easy road (Picker is really small, check the code).
I still need to replace the emailForUrl helper, which also depends on IR.
Once I'm done I'll do a PR (unless you really want to go for a WebApp solution)

Thank you!
Legit thoughts on WebApp vs. . The things I've done with WebApp.connectHandlers has ended up with me wishing I'd gone with a router package instead.
Feel free to file a PR and continue pushing commits to it.

Is that emailUrlFor helpers actually going to work without IR? Because if I understand correctly, you can just pass any IR route name in there and then it creates an absolute url for your email. But without IR there are no IR route names, and you cannot lookup a route.

Or we can just leave it as is, and if you use IR you can use this helper. And then we can add some functionality for FR in that helper. What do you think?

@satyavh

Is that emailUrlFor helpers actually going to work without IR?

Nope, they won't. But we can have Iron Router as a weak dependency, and check if it's included in the main app:
if Package['iron:router']
  # do stuff

Flow Router doesn't have the routes defined on the server yet, afaik?

The iron router integration can mess things up. I have a global hook that checks if a user is logged in or not, but when I go to the preview page, I get an error saying:
Error: Meteor.userId can only be invoked in method calls. Use this.userId in publish functions.
W20151219-23:58:51.404(2)? (STDERR)     at AccountsServer.userId (accounts_server.js:80:13)
W20151219-23:58:51.404(2)? (STDERR)     at AccountsServer.user (accounts_common.js:53:23)
W20151219-23:58:51.404(2)? (STDERR)     at Object.Meteor.user (accounts_common.js:230:19)
W20151219-23:58:51.404(2)? (STDERR)     at [object Object].mustBeSignedIn (router.js:34:15)

I solved my issue my wrapping the revelant global hooks in a Meteor.isClient block.

Fixed in https://github.com/lookback/meteor-emails/pull/47.


fix: Add version property to http-event schema and convert PromiseRejection.reason into string

Problem

When HTTP Event with an error is created, it uses js-error-event to populate the error field. js-error-event contains the field version, which is not included http-event's error field. Due to this inconsistency that is also reflected on the dataplane's validation, any HTTP event with an error field is rejected.
When JSErrorPlugin handles unhandledrejection event, it adds PromiseRejectionEvent.reason as the message field. However, if the PromiseRejectionEvent.reason is an empty object rather than a string message, it is returned in the form of {}, which fails dataplane's validation for JsErrorEvents.

Fix

This PR contains changes to JsErrorPlugin and its unit test cases to handle situations where the PromiseRejectionEvent.reason is an empty object, and also changes the event schema for http-event.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Does this change fix two separate bugs? Would it make sense to file separate PRs for them?

Does this change fix two separate bugs? Would it make sense to file separate PRs for them?

Agreed, will split the PRs into two, one for http-event schema change, other for JsErrorPlugin fix


✏ Create empty actor detail screen

This can follow the pattern on the show detail screen. https://github.com/Thenlie/Streamability/blob/main/src/screens/EmptyShowDetailsScreen.tsx

Closed by #784


Staging env testing: Preview emails -> Review Students generates the "Class "Faker\Factory" not found error

https://ordev.utdallas.edu/profiles/testing/email-preview/reviewstudents?name=Test User

@betsyecastro this is because the deploy script doesn't install dev dependencies. I've manually installed them for now, but I'll update the script for staging deploys.


Fine-Tune-ESM2-On-DeepLoc.ipynb  inference step error

ModelError: An error occurred (ModelError) when calling the InvokeEndpoint operation: Received server error (500) from primary with message "{
"code": 500,
"type": "InternalServerException",
"message": "Worker died."
}
CloudWatch error:
2024-02-11T02:59:34,146 [INFO ] W-9000-bloyal__esm2_650M_membran-stdout com.amazonaws.ml.mms.wlm.WorkerLifeCycle - OSError: Unable to load weights from pytorch checkpoint file for '/.sagemaker/mms/models/bloyal__esm2_650M_membrane_loc/pytorch_model.bin' at '/.sagemaker/mms/models/bloyal__esm2_650M_membrane_loc/pytorch_model.bin'. If you tried to load a PyTorch model from a TF 2.0 checkpoint, please set from_tf=True.

Looks like an OOM error. Updated the instance type in the notebook from a ml.m5.2xlarge to a ml.r5.2xlarge


how to add rport in phone register?

i want to use sipgo and test it with sipgox, but sipgox has no rport set in register so in nat network, the contact is not correct, and i can not recv freeswitch message.
i am using linphone and it can register ok.
the difference is linphone send register with rport first, freeswitch send 200, then linphone use the rport info fill the contact head and send second register and got 200, then register is ok.

hi @yangjuncode
I guess this is more for support on
https://datatracker.ietf.org/doc/html/rfc3581
which is not yet fully supported.
Lets keep ticket open. It is on my list

Added support for client NAT and rport
https://github.com/emiago/sipgo/commit/1e42b52a547b694a43ad3d882066a203c76d15a8

@yangjuncode Added NAT support. pls rebase.

thank you very much, works!


747 - Users should be able to click on the full field of a dropdown-type filter to open up the dropdown

Purpose
Users should be able to click on the full field of a dropdown-type filter to open up the dropdown
Changes

Updated all of the Datastore Connections filters to use the MultiSelectDropdown and SelectDropdown components. As a result, a given user can click anywhere within a filter container to open the dropdown.

Checklist

[x] Update CHANGELOG.md file

[x] Merge in main so the most recent CHANGELOG.md file is being appended to
[x] Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
[x] Add a link to this PR at the end of the description with the PR number as the text. example: #1

[ ] Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
If docs updated (select one):

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Good unit test/integration test coverage
[ ] This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
[ ] The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket
Fixes #747

@chriscalhoun1974 Everything looks great! I have one question regarding the width of the dropdowns and the searchbar.
Before this update each field in the filter bar took up the same amount of space.
Now the dropdowns only take up enough space to display the text within them and the seachbar fills up the remaining space.
Is this the intended behavior? It makes sense to me but it can result in some really wide search bars. Especially on big screens.
If this is the intended behavior then it's ready to ship :shipit:

@TheAndrewJackson Great question! I can make it take a 1/3 of the screen perhaps. Let me look back at the original Figma design and consult with Simon on the expected responsive behavior. Thanks for the feedback.


Persistent BottomSheet not working

Table of Contents
Link to GitHub issues it solves
closes #92
Description
Persistent BottomSheet not working problem fixed.
Contributing has more information and tips for a great pull request.

@zeobot set lc to pass


Rename opentracing-spring-web-autoconfigure to opentracing-spring-web-starter

Fixes: #75

@pavolloffay Should I start a release, or is there a plan to wait for some other feature to land?

go ahead and cut a new one

:+1: will do

Release is in progress

0.3.4 released


Frontend login

you should put the css stuff in classes instead of writing the styles for general tags (like just "input" instead of a class). This is pretty bad practice.

I will merge this PR and apply the changes myself since I have to merge it with my stuff asap


Adds Git SSH Key Generation

Signed-off-by: ChrisJBurns<EMAIL_ADDRESS>What this PR does / why we need it:
Adds automatic Git SSH key generation if configured by user of Chart.
Which issue this PR fixes
https://github.com/fluxcd-community/helm-charts/issues/101
Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] helm-docs are updated
[x] Helm chart is tested
[x] Update artifacthub.io/changes in Chart.yaml
[ ] Run make reviewable

make reviewable

Getting errors when running make reviewable
20:04:24 [ ..  I will do a rebase and try and fix why the tests are failing as well, not sure why they're failing at the moment. I also need to figure out why the make reviewable step is failing too when I run it locally.

Think you need to Update the SnapshotFiles because of Chart bump


Use commit hash for the ncipollo/release-action for sec reasons

Implementing security best practice.
More info: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

We also need to PR this change to casper, casper-test, and integration-test branches as they don't get merged to from main.

@sacherjj I think this can be a new use-case for a workflow involving the sync-branches action.
We could have it trigger so that PRs targeting main gets mirrored to those 3 branches automatically.
This is the implementation I did for the docs gitflow where we need to keep dev and main in sync:
https://github.com/casper-network/docs/blob/dev/.github/workflows/dev_main_sync.yml


OCPBUGS-8451: Rebase to v5.1.2 for OCP 4.12

Diff to upstream v5.1.2:
https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/compare/v5.1.2...RomanBednar:rebase-v5.1.2
Changelogs since v5.0.0:

https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/releases/tag/v5.0.1
https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/releases/tag/v5.0.2
https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/releases/tag/v5.1.0
https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/releases/tag/v5.1.1
https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/releases/tag/v5.1.2

(only version bumps, sidecar updates, CVEs, bug fixes)
cc @openshift/storage

/lgtm
/approve
@RomanBednar Please fix openshift-ci-robot complaints about Jira.

/label backport-risk-assessed

/label cherry-pick-approved

/jira refresh


chore: rename tests workflow badge

:tada: This PR is included in version 2.4.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


☂ cmake: audit tasks

[ ] Mixup places that use manual target_include_directories vs target deps
[x] Verify all headers get installed as intended
[ ] Compare feature flags ENABLE_*
[x] Compare checks HAVE_*

Some Catch unit tests are missing in the CMake build:
wkaras ~/REPOS/TS
O$ cat ~/find_catch
CML=$( find . -name CMakeLists.txt )
LAST='NONE'
grep -l -F CATCH_CONFIG_MAIN $( find . -name *.cc -o -name *.cpp ) | while read P
do
F=$( basename $P )
if [[ $F != $LAST ]] ; then
COUNT=$( grep -l -F $F $CML | wc -l )
fi
if (( COUNT == 0 )) ; then
echo "$F missing"
else
let COUNT=COUNT-1
fi
LAST=$F
done
wkaras ~/REPOS/TS
O$ . ~/find_catch
authproxy_test.cc missing
uri_signing_test.cc missing
test_HostFile.cc missing
test_MTHashTable.cc missing
event_processor_main.cc missing
test_NextHopConsistentHash.cc missing
test_NextHopRoundRobin.cc missing
test_NextHopStrategyFactory.cc missing
test_PluginDso.cc missing
test_PluginFactory.cc missing
test_RemapPlugin.cc missing
benchmark_LogObject.cc missing
test_RolledLogDeleter.cc missing
wkaras ~/REPOS/TS
O$
I can't think of a quick way to check if any non-catch unit tests are missing.

It looks like there may be over 100 c/cpp/cc file that appear in a Makefile.am or Makefile.inc file, but not in a CMakeLists.txt file.  I will work on addressing this.

One way I have found to find the differences is to enable cmake's CMAKE_EXPORT_COMPILE_COMMANDS option and then compare that to the filesystem.  Cmake will output a compile_commands.json file that lists every file that will be compiled as part of the build.
jq -r 'map(.file)[]' compile_commands.json | sort | uniq > compiled.txt

find "$(pwd)" -type f -name "*.cc" -or -name "*.cpp" | sort > files.txt

Then you can diff these files.  For this to work, you have to have a cmake that builds with every available option (autest, quic, experimental plugins, benchmarks, etc).  There are known missing items like the plugins listed in #10242 and the tests in swoc in yaml-cpp that we don't build.  There are also some files (i.e. the fastcgi plugin) that autotools also does not build.
Thanks for helping to audit the cmake build @ywkaras!


gateway capture $transactionReference = 0 Permanently

this my code
  try {
            $creditCard = new \Omnipay\Common\CreditCard([
                'number' => $data['cardNumber'],
                'expiryMonth' => $data['expiration_month'],
                'expiryYear' => $data['expiration_year'],
                'cvv' => $data['cvv'],
            ]);

            $transactionId = 'ref' . time();

            $response = $this->gateway->authorize([
                'amount' => $data['amount'],
                'currency' => 'USD',
                'transactionId' => $transactionId,
                'card' => $creditCard,
                'customer_id' => auth()->user()->customer->id,
            ])->send();

            if ($response->isSuccessful()) {

                $transactionReference = $response->getTransactionReference();

                $response = $this->gateway->capture([
                    'amount' => $data['amount'],
                    'currency' => 'USD',
                    'transactionReference' => $transactionReference,
                ])->send();

                $transaction_id = $response->getTransactionReference();
                $paymentMethod = $response->getData()['transactionResponse']['accountType'];

                $isPaymentExist = Invoice::where('transaction_id', $transaction_id)->first();

                if (!$isPaymentExist) {
                    $payment = new Invoice();
                    $payment->price = $data['amount'];
                    $payment->transaction_id = $transaction_id;
                    $payment->order_id = $data['order_id'];
                    $payment->customer_id = auth()->user()->customer->id;
                    $payment->payment_date = date('yy/m/d');
                    $payment->payment_method = $paymentMethod ?? 'Online';
                    $payment->due_date = date('yy/m/d');
                    $payment->save();
                }

                return back()->with('success', "Payment is successful. Your transaction id is: " . $transaction_id);
            } else {
                // not successful
                return back()->withErrors(Lang::get($response->getMessage()));
            }
        } catch (Exception $e) {
            return back()->withErrors($e->getMessage());
        }

returned $transaction_id is always zero , the mode of authorize.net is test ,
Is that correct ?
[JDJ: edited for formatting]

Just seen this and noted. Will get back to you ASAP.

That essentially is correct and is how I have some test scripts successfuly running. The transaction reference and ID look like they may be a little mixed up on the middle, but I don't know enough about your database to say for sure.
The response to the initial authorize will return a transactionReference generated by the gateway. That trancationReference is then passed to the capture endpoint. The same transactionReference is then returned with the response to that (you then call it transaction_id at this point for looking it up on your persistent payment storage). The response to the capture will also return the same transactionReference.
On the gateway response, the transId (the capture) and the refTransId (the transaction being captured) are one and the same. Fir a void or refund, I believe they will differ, since those would be separate transactions.

thank you , it is clear


[RTC]Core Component - Default Policy & Style

User Story:
As a Front End Developer, I would like to be able quickly alter or enhance the visual style of a Core Component via the style system by modifying a pre-built style.
Acceptance Criteria:
1  FED should be able to navigate to an existing template & open the policy editor to view a default layout & display style.
2 FED should be able to navigate to a pre-defined location and easily find the css file for the teaser component & modify the appropriate CSS defaults for the following:
Layout:  Banner (height: 150), Hero (height:450)
Display:  Border (on|off)

FED should have the following Core Components already pre-configured with a policy & default style options:
a. Carousel
b. Content Fragment
c. List
d. Separator
e. Social Sharing
f. Tabs
g. Teaser
h. Text
i. Title

To me, this RTC is describing the needs for a component theme with some style presets.

Can you please elaborate what that means?  I do not think of a theme in a optional add on sense.  If a core component has a default set of rendering, it should be included as a base style.


[NFC] Rework serialization changes in #32811

This tweaks the implementation of SE-0285 to preserve backwards compatibility with the previous module serialization format. Existing default arguments all keep their previous values when serialized; #fileID and Swift 6 #file are given previously unused values.
Fixes rdar://66810027.

@swift-ci please test


#1506 Comp and Pen Scheduling Notification Sends

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
In this change the necessary code was added to get the data from the dynamodb table and send the notifications using the vaprofile ids. A scheduled celery task was created that will run every minute between 1 PM and 9 PM Eastern time from the 21st through the 28th of each month. The task will grab 3000 messages from the dynamodb table and send them to the veteran using the vaprofile id from that table. It will include the paymentAmount in the message it sends as a personalization.
issue #1506
Type of change
Please check the relevant option(s).

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation changes only

How Has This Been Tested?

How has this been tested? (e.g. Unit tests, Tested locally, Tested as a GitHub action, Depoyed to dev, etc)
Please provide relevant information and / or links to demonstrate the functionality or fix. (e.g. screenshots, link to deployment, regression test results, etc)

[x] Unit tests passing locally and on GitHub
[x] Deployed to Dev
[x] QA suite tests pass

Checklist

[x] I have assigned myself to this PR
[x] PR has an appropriate title: #9999 - What the thing does
[x] PR has a detailed description, including links to specific documentation
[x] I have added the appropriate labels to the PR.
[x] I did not remove any parts of the template, such as checkboxes even if they are not used
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to any documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have ensured the latest master is merged into my branch and all checks are green prior to review
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] The ticket is now moved into the DEV test column

there is one unit test failing, please resolve.
also, for testing, you have

Unit tests passing locally and on GitHub
Deployed to Dev
QA suite tests pass

Can you provide some testing info on the actual feature (not the mocked unit tests)? Like a screenshot of logs showing the sequence and that things actually were processed? Might be a good exercise to take Ed along on.

Good idea Cris! I'll get that info collected and put it in the testing section. I'll see if Ed is available for some learning.


How does this work together with composer based magento installations?

Hey there,
First of all: your gem is awesome, I am glad I found it.
I have a question though: recently I found that magento core can be installed using composer as well:
https://github.com/AydinHassan/magento-core-composer-installer
Does this work well together with capistrano based deployment?

Hi @sagikazarmark , did you tried it? I'm also curious, what is your experience.

Not yet, will try it in a few days.

Sorry @sagikazarmark I have not tried it. It could probably be included if you have any luck though so keep me posted/submit a pull request :smile_cat:

Will try.

You can maybe take a look at using https://github.com/capistrano/composer/  to handle your composer tasks.

That's what I am doing :wink:


Add hasHint(@StringRes resId: Int) #217

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Close: #219

@igorwojda no, you're not missing anything. Actually, I would also recommend to add resource id match for error as well.

@igorwojda Yes mate. All good!
Maybe will be better to add a new function like
    /**
     * Checks if this input layout has given hint
     *
     * @param resId - hint text resource to be checked
     */
    fun hasHint(@StringRes resId: Int) {
        view.check(ViewAssertion { view, notFoundException ->
            if (view is TextInputLayout) {
                val expectedHint = view.context.getString(resId)
                if (expectedHint != view.hint) {
                    throw AssertionError(
                        "Expected hint is $expectedHint," +
                                " but actual is ${view.hint}"
                    )
                }
            } else {
                notFoundException?.let { throw AssertionError(it) }
            }
        })
    }

WDYT @igorwojda @Unlimity ?

@Unlimity I have added equivalent method for error.

@igorwojda Yes mate. All good!
Maybe will be better to add a new function like
    /**
     * Checks if this input layout has given hint
     *
     * @param resId - hint text resource to be checked
     */
    fun hasHint(@StringRes resId: Int) {
        view.check(ViewAssertion { view, notFoundException ->
            if (view is TextInputLayout) {
                val expectedHint = view.context.getString(resId)
                if (expectedHint != view.hint) {
                    throw AssertionError(
                        "Expected hint is $expectedHint," +
                                " but actual is ${view.hint}"
                    )
                }
            } else {
                notFoundException?.let { throw AssertionError(it) }
            }
        })
    }

WDYT @igorwojda @Unlimity ?

I don't really see any benefit of doing so (instead of using one overload with in another, like in this PR).
However on the other side we have a big downside of heaving two full/long implementations - higher maintenance cost.

@igorwojda awesome! Thanks a lot! Last request from me. Could u please extract

private fun getResourceString(@StringRes resId: Int) = InstrumentationRegistry.getInstrumentation().targetContext.let { it.resources.getString(resId) }

To
common/utility/ContextUtils.kt

I will name it utilities (plular) to match other package names

Should docs/kakao be a apart of this PR?

@igorwojda don't worry about notes. This PR could contain only code related stuff. Cheers.

done

@igorwojda thanks for the contribution


Option: return errors as a tree

What version of Ajv you are you using?
<EMAIL_ADDRESS>What problem do you want to solve?
Improve readability of validation.errors.
Currently error reporting is provided as a flat list in validate.errors.
I find this list very hard to read and use to diagnose problems on large schema / instance.
What do you think is the correct solution to problem?
Provide a tree of errors instead of a flat list.
In single error mode, all the elements of the validation.errors all trace back to a single failure which made ajv failed to validate.
Here is my understanding on how schema combinators should affect the tree:

not: leaf because its child validates
allOf: absent because it forwarded its first child failure
anyOf: node whose children mirror the schema's children
oneOf: either a leaf if all its child validate or a node if some of them failed

Will you be able to implement it?
I did and it and it already helped us fix some issues: ajv-error-tree.
However I had the do the hacky job of reconstructing a tree from a flat list.
I believe that the clean solution would be to directly generate errors as a tree and flatten it if the user requires it.
Is this worth integrating in ajv?

just want to say, this is exactly what we are looking for, our use case is to do an audit: At which point the rules are failing. This would help us track down the specific path to the value and why it fails

Hey @hyusetiawan, I developed ajv-error-tree to solve my issue. Feel free to use it directly or for inspiration.


Yaml

Operation System: Win 10 Home 1709
Beaker Version: 0.7.10
I created a Website that reads a config.yml to work. But I get:
The config.yml file could not be loaded or failed to parse properly.
Error message: Error: Failed to load config.yml (404)
Seems the MIME text/yml is not recognized. How to add it?
see:
dat://60da73fcf189b8a2acc6ae3cd6a3371d65a3fa278ce8e45f4f9f7ba42e24b109

[Not related to the issue itself]
Suggestion: to host the dat website in the issue on hashbase.io to be available when you're offline.

Turns out I needed to add a Slash at the end of the url..

@pungggi hey glad it was resolved. You didn't end up needing a slash at the end of the filename, did you?


Add redux

This is a suggestion to use redux to manage state as redux can handle state more efficiently.
We can add it now or we can add it in future. It will be great if we add it in package.json for now and we can open some small issues to manage state through redux for some particular components.
What do you think?

for state management we are using React Context Api

For what feature do we need redux. Which state management module will you enhance with it.

@anushbhatia
As I mentioned in the Issue that it's a suggestion. Also as the project will grow complexities will also increase so I think redux can handle those complexities very easily.  Apologies for the late reply.

We can go for this in a later stage of the project as we have plans to shift to next


Documentation update: Added other available flags

I'm using your tool and had to go to main to find the server flag. Thought a documentation update with the other flags you've built in would be useful to others.

Thanks. I suspect we'll forget to  keep this up to date, but it helps people while evaluating.


Error with SystemJS

Hi. I use ng2-semantic-ui with SytemJS and configured it like described in docs - for version 0.6.5 it works great, but after I migrated to 0.8.1 got error
(SystemJS) Cannot set property 'true' of undefined
	TypeError: Cannot set property 'true' of undefined
	    at eval (http://localhost:5555/node_modules/ng2-semantic-ui/bundles/ng2-semantic-ui.umd.min.js:3:185)
	    at Object.eval (http://localhost:5555/node_modules/ng2-semantic-ui/bundles/ng2-semantic-ui.umd.min.js:3:188)

I've investigated this a bit further and it looks to be due to the fact that the web-animations-js doesn't work with strict mode (and thus rollup at all!).
Before I move the polyfill out of the bundle, could you please try the attached bundle and let me know if you have the same error?
ng2-semantic-ui.umd.min.zip

0.8.2 fixes this issue. Please do read the release notes to ensure the breaking change introduced doesn't affect you.


fix typo on line 177

Just noticed a little typo on line 177: "clone file" instead of "close file".

Thanks @caio-vitor


New version: Lenovo.UpdateRetriever version <IP_ADDRESS>

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @philjorgensen,

This PR's version number <IP_ADDRESS> has 4 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 5.00.0096, which has 3 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 881)

[A screenshot of a computer  Description automatically generated]

Philip Jorgensen
Professional
Commercial Deployment Readiness Team
Lenovo US
<EMAIL_ADDRESS>Lenovo.com/ushttp://www.lenovo.com/us
blog.lenovocdrt.comhttps://blog.lenovocdrt.com/
Twitterhttp://twitter.com/lenovo | Instagramhttps://instagram.com/lenovo | Facebookhttp://www.facebook.com/lenovo | Linkedinhttp://www.linkedin.com/company/lenovo | YouTubehttp://www.youtube.com/lenovovision | Privacyhttps://www.lenovo.com/gb/en/privacy-selector/
@.***
From: Stephen Gillie @.>
Sent: Thursday, May 16, 2024 11:58 AM
To: microsoft/winget-pkgs @.>
Cc: Philip Jorgensen @.>; Mention @.>
Subject: [External] Re: [microsoft/winget-pkgs] New version: Lenovo.UpdateRetriever version <IP_ADDRESS> (PR #153872)
Hi @philjorgensenhttps://github.com/philjorgensen,
This PR's version number <IP_ADDRESS> has 4 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 5.00.0096, which has 3 parameters.
Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 881)

Reply to this email directly, view it on GitHubhttps://github.com/microsoft/winget-pkgs/pull/153872#issuecomment-2115621275, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALP3TS5FPEMGZUQSSW5FKPLZCTJPPAVCNFSM6AAAAABH2KMAFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVGYZDCMRXGU.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@stephengillie
Here's a screenshot of what's shown in add/remove programs


Module name is incorrect in readme

var myApp = angular.module('myApp', ['moment-picker']); results in a NOMOD error and failure to run.
It only takes a quick glance at the source to notice that the module name is momentPicker and not moment-picker - and indeed var myApp = angular.module('myApp', ['momentPicker']) works fine - but to have the name of your module wrong at the top of your readme is an inexcusable oversight IMO.

Hello @drew-moore,
Thank you for writing and sorry for the late response.
You say that if writing moment-picker will cause an error during run, isn't it?
Maybe there is an angular naming convention system that I don't know yet, but as you can see in this plunker I don't have any errors if I add "moment-picker" as a dependency in my module.
Could you please provide an example showing this issue or, at least, a link where I can read and better understand naming conventions?
Thank you.

I had the same issue and it was because I installed the wrong package from bower. "angular-moment-picker" is used by someone else : you have to install "indrimuska-angular-moment-picker".
I guess it would be nice to mention it in the docs.

Oouh! Sorry guys, I will update readme file as soon as possibile with all information to get Angular Moment Picker.

I just released version 0.1.4 with the instructions on how to get the module.
Let me know if this issue occurs yet.
Note that Angular Moment Picker is available on bower with these names:

moment-picker
indrimuska-angular-moment-picker

Thank you ! I just upgraded and everything went fine

Happy to see you've solved!


proposal: allow omission of type parameter names in methods that don't use them

In the current generics proposal, all methods on a generic type must mention the type's type parameters.
For example:
type Foo[T1, T2 any] struct {...}

func (f *Foo[T1, T2]) Something() {}

It seems to be very common that methods like this don't actually need to mention the type parameters by name, which makes it tedious to declare them. One possibility is to avoid giving them names:
func (f *Foo[_, _]) Something() {}

but that doesn't help the extra verbosity much.
I propose that the type parameter clause in methods should only be required if the method body actually uses the type parameters.
This also makes it easier to refactor code when we might wish to add or remove type parameters to a type without undue code churn.
So we'd allow this, even though Foo is a generic type:
func (f *Foo) Something() {}

CC @griesemer

@rogpeppe Do you have a sense for how common this situation might be? (Things like func (recv T) Len() int where we don't care about the element type of a generic container come to mind. But is that about it?)

Do you have a sense for how common this situation might be? (Things like func (recv T) Len() int where we don't care about the element type of a generic container come to mind. But is that about it?)

That's the data point that a colleague encountered at work, which made me ask Roger about this feature yesterday, triggering the proposal :) Essentially, someone was trying type parameters on a large existing codebase, and a type with dozens of methods only needed to use the receiver's type parameters in about half of its methods. The other methods all had to gain repetitive [_, _] bits.
It's just one data point, so I can't argue how often this will be the case with methods on generic types. But it seems like an easy win to make this optional, just like other bits of a function declaration (return parameters, receiver, parameter names) are also optional.

@rogpeppe Do you have a sense for how common this situation might be? (Things like func (recv T) Len() int where we don't care about the element type of a generic container come to mind. But is that about it?)

In my experience refactoring and writing generic code, it's considerably more common than not. There are often auxiliary methods that don't touch the generic type at all, but also even methods that do touch the generic types can often do so without mentioning the type name specifically.
Here's an example of the latter from a trie container type that I converted to use generics:
func (i *Iter[Key, Value]) pop() {
	i.stack = i.stack[0:len(i.stack)-1]
}

Although i.stack is made of generic values, there's no need for the signature or the body of the function to mention the type parameters, so they seem redundant.
Basically, ISTM that any place that one might use _ as the name of all type parameters it would be nicer to be able to omit them completely.

I will go against the flow here. I think func (f *Foo[_, _]) Something() {} is fine. It's explicit, yes, but then it's very clear that we are defining a method of a generic type.
Please consider that the method Something might be defined in a different file than the type Foo, e g. in case of code generation. Then, allowing to omit the type parameters is confusing because it seems like we are defining a method on a normal file.
So for the sake of readability and explicitness, I respectfully oppose this proposal.

Then, allowing to omit the type parameters is confusing because it seems like we are defining a method on a normal type

Why do you think it helps to know that we're defining a method on a generic type vs a normal type?

Because the generic type has additional parameters that may or may not influence functionality, just like normal parameters do.
For example , a method func (f *Foo[_,_]) Something(Bar) is a great way of saying, "This generic method doesn't use the type parameters and has a regular parameter of type Bar that is also unused".
I tend to use cheap old computers without IDE nor gopls. When I look at a file with my editor I can only see what is in it.
If I'm looking at different file than where type Foo[T, U] is defined, and I see  a method func (f *Foo) Something(Bar) there, then in this case I will wrongly assume Foo is not a generic type.  I have to go to the trouble of of finding out where Foo is defined and opening the other file where Foo is defined to see that my assumption is wrong. With the "pants operator" [_,_] it is immediately clear that the type is generic without having to open the file with the definition.
And why its it important to know whether a type is generic or not? When defining method on a type one must know the details of that type, and the fact that it is generic is an important detail.

And why its it important to know whether a type is generic or not? When defining or even reading a method on a type one must know the details of that type, and the fact that it is generic is an important detail.

There are lots of other details of that type that are important details too (for example: is it a struct or some other type?) that aren't encoded in the method definition. Why does this particular aspect deserve to be different?

Should we be concerned about this causing confusion about the nature of Go generics? I believe there's no other place in the language where a generic type can be referenced without type parameters, and that reflects Go's lack of support for passing around "meta-types" or using "raw types", as they're called in Java. This consistency seems desirable to me.
That said, I am sympathetic to the motivation behind this proposal. I wonder if syntax that keeps the brackets but avoids enumerating the type arguments would be more clear, maybe by using ellipses:
func (f *Foo[...]) Something() {}

This syntax is still preferable to using underscores, because it never needs to be changed as the number of type parameters changes.

Type parameters are also parameters. For normal parameters in the case of , say func DoesNotUseParams (_ ...string), I certainly wouldn't argue for a special notation to be able to simplify that definition.  Same for the type parameters.
Also it's not because a method doesn't use the type parameters now that it might not need to use them in the future. Better leave them visible so they are easily used when they turn out to be needed.

Type parameters are also parameters. For normal parameters in the case of , say func DoesNotUseParams (_ ...string), I certainly wouldn't argue for a special notation to be able to simplify that definition. Same for the type parameters.

We already have a special notation to simplify that definition: func DoesNotUseParams(... string).

Also it's not because a method doesn't use the type parameters now that it might not need to use them in the future. Better leave them visible so they are easily used when they turn out to be needed.

Surely they're trivial to add when needed (just like function parameter names) ?

This seems like a premature optimization.
Also the signal in the method that Foo is a parameterized type seems important to preserve.

Ok, so we have func DoesNotUseParams(... string). But we don't have func DoesNotUseParams {...}. The mere presence of the argument list is an important signal.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

No change in consensus, so declined.
— rsc for the proposal review group

Sorry, I missed this comment and the "likely decline" comment, so responding too late, sorry!
@rsc

Also the signal in the method that Foo is a parameterized type seems important to preserve.

I don't understand why it's an important signal to preserve. If you're not mentioning the parameterised type by name in the method, then it doesn't make any difference whether the type is parameterised or not - the type comes from "elsewhere" and the fact that it's a method on a generic type doesn't really affect how you read the body of the method AFAICS. The type parameters are just annoying noise to type (and actively get in the way when refactoring to add or remove type params).
Still, we can revisit this at a later date when we get more experience.


Fix ThComponent classnames ordering in defaultProps

This PR fixes a bug where the ThComponent's base class comes after the configurable class name. This prevents a user from customizing the styling of the header without using !important in their CSS. The change allows for a custom header classname to extend the base styles.

@gary-menzel Are you the primary reviewer on this project?

Probably the only reviewer at the moment.  There are other PRs queued up that are ahead of this one (and my time is limited).  In addition, the repo owner has been away and I usually run these by him before finalising them.
I've taken a quick look and I can't see any major issue with the PR but it just has to come in behind some of the others.


RedirectableUrlMatcher needs to return a proper array with the _route parameter

Symfony's HttpUtils's checkRequestPath() expects RedirectableUrlMatcher to return an array with '_route'. This throws a notice Undefined index: _route:
        $coll = new RouteCollection();
        $coll->add('foo', new Route('/foo', array(), array(), array(), '', array('https')));
        $matcher = new RedirectableUrlMatcher($coll, new RequestContext());
        $httpUtils = new HttpUtils(null, $matcher);
        $request = Request::create('http://example.com/foo');
        $httpUtils->checkRequestPath($request, 'foo');

It's an issue with my app although I haven't yet taken the time to make a simplified app to show the issue besides the above.

Thank you @slipo.


Modify Makefile to allow DOCKER_HUB_ID to be overridden by env var

In the future we plan to have a more advanced CI/CD process and allowing the DOCKER_HUB_ID to be overridden by an environment variable will needed.
We should change
DOCKERHUB_ID:=ibmosquito

to the following
DOCKER_HUB_ID ?= ibmosquito

Sure, @oskurtt
Make sure that you find all instances of DOCKERHUB_ID in the file and change them to DOCKER_HUB_ID in addition to the initial change that Troy mentioned.  Make sure you sign off on all of your commits.


add chromedp.Env to add env vars for ExecAllocator

use-cases include setting variables such as LANG, TZ or http_proxy
for specific chrome instances.
cc #190 https://github.com/GoogleChrome/chrome-launcher/issues/29

@tmm1 we appreciate the work done. Please hold for a bit, as while I don't know whether or not I'll merge this specific PR (some clear functionality is missing to make it useful / consistent with the rest of the package), the main issue is that I'm finishing up a large refactoring of the internals (the external API will more or less remain the same) and exec allocator, while still remaining responsible for setting up exec.Command and passing the environment variables to it, the initFlags and thus this initEnv variable  no longer live in the exec allocator, but have been moved to the primary context.

Gotcha, will hold tight until the refactor is done. Thanks for the heads up.

Can this be reconsidered since the aforementioned refactor has been abandoned?

It hasn't been abandoned per se, but sure, go ahead. Even if we decide to go in some other direction with the API in the long term, we can always change this Env option since we're at a v0.

I made the requested changes and added a test.


Make the https component of the fleetspeak server optional.

This change makes it possible to run a pure fleetspeak admin server (without
running a HTTPS server as well).
The purpose of this change is to enable a distributed open source setup,
consisting of multiple HTTPS servers behind a load balancer and multiple admin
servers behind a second load balancer.
The pure admin server needs to be able to use a http based notifier, without
running a http based notification listener as well. For this, a new config
option is introduced.

PTAL.

PTAL.