v0.3.0 SPDX SBOM Does Not Have Unique SPDXID Package IDs

What happened:
I was trying to convert the JSON format of the v0.3.0 SBOM to the tag-value format. The tool I was using reported multiple non-unique SPDXID package IDs and therefore did not work. For instance, there are multiple packages with the SPDXID of SPDXRef-Package-go-module-github.com/adrg/xdg-v0.3.3.
What you expected to happen:
I expected each package's SPDXID to be unique. See the SPDX spec: https://spdx.github.io/spdx-spec/package-information/ - The spec has this description of the Package SPDX identifier field: "Uniquely identify any element in an SPDX document which may be referenced by other elements."
How to reproduce it (as minimally and precisely as possible):
I was using this tool: https://github.com/spdx/tools-java with this command:
java -jar ../../external-tools/tools-java-1.0.4-jar-with-dependencies.jar Convert chronicle-sbom.spdx.json chronicle-sbom.spdx JSON Tag
Anything else we need to know?:
You could just say, "This isn't important." And that's fine! But I thought you might be curious and, additionally, it might lead to an upstream fix, if there is even a bug!, in syft.

I think this was intended for anchore/syft , I'll transfer there.
Regarding the specific issue, in short, I agree. Originally our package IDs in the syft-json format were random IDs, so generating an SBOM from a source twice wouldn't produce the same SBOM. We eventually moved over to stable IDs that are based on the package definition, however, didn't update the package IDs created for SPDX to reference the new syft model IDs. We should probably change this.
The only other consideration not to do this is the fact that we could loose semantic usefulness of the IDs, but I think this is a secondary concern, and there are ways to solve that problem as well (if it is a problem).


[GH-13266] Fix isRHS passing

Summary

Fix the problem where isRHS was passed as a string instead of as a boolean
Ticket Link

https://github.com/mattermost/mattermost-server/issues/13266
Related Pull Requests

None
Screenshots

None

Forgive my changes on labels.  I just tested some things  on webhook. (All good now).


Update install.sh

Closing this as the underlying issue has been fixed in #19 (further details in the closing comment of #18)


app_update: Add esp_ota_write_raw function to write pre-encrypted data (IDFGH-5583)

Use esp_ota_write_raw instead esp_ota_write to write pre-encrypted data.
Signed-off-by: Axel Lin<EMAIL_ADDRESS>

Hi @mahavirj
I understand you comments in https://github.com/espressif/esp-idf/issues/6172#issuecomment-884777914.
Before introducing new "pre-encrypted" OTA image format, this function allows
existing users to implement updating pre-encrypted ota data.(https://github.com/espressif/esp-idf/issues/6172#issuecomment-881801160)
Please review if this PR is acceptable.

@AxelLin I am not quite clear on this change. So you think that application needs to take care about correct "pre-encrypted" image per flash offset per passive OTA update slot?

Hi @mahavirj
Yes, for the use case for some customers using device in closed netowrk.
I have no choice but to implement supporting "pre-encrypted" image by taking
care the correct logic in our application side.
Actually when we do OTA in an independent partition (e.g. test partition), we
can always update image to ota1 partition and set boot from ota1. (so choose image issue).

@AxelLin Thanks for explaining. It will be difficult to accept this PR, unless we add lot of explanation in documentation (and probably application as well) to clarify usage scenario here. I would request that we wait for official approach as I had highlighted in https://github.com/espressif/esp-idf/issues/6172#issuecomment-884777914. Of course, if someone find this change useful they can always refer to PR here.

And honestly, such requirement (ota with pre-encrypted image) has been asked so many times.
Waiting for a new "pre-encrypted" OTA image format could take too much time.
(It maybe not available this year)
If this PR is not acceptable, I have no choice but to maintain my on fork of esp-idf.
Thanks for your time anyway.

@AxelLin Thanks for explaining. It will be difficult to accept this PR, unless we add lot of explanation in documentation (and probably application as well) to clarify usage scenario here. I would request that we wait for official approach as I had highlighted in #6172 (comment). Of course, if someone find this change useful they can always refer to PR here.

On the second thought, by calling esp_ota_get_next_update_partition() the
firmware can easily know which encrypted ota image to download.
The only thing needs to comment or document is the feteched encrypted ota image needs
to be generated for the target partition address.
BTW, this is probably off-topic.
But I had bad experience about waitting new features ready.
e.g. regarding 802.11r support:
21 Jun 2019: we may prioritise 11r though. https://github.com/espressif/esp-idf/issues/3671#issuecomment-504357006
18 Dec 2020: 11r support will be added in future. https://github.com/espressif/esp-idf/issues/3671#issuecomment-747897503
25 Jan 2021: We are targeting 2nd quarter of 2021. https://github.com/espressif/esp-idf/issues/3671#issuecomment-766896837
Now, 11r is still not yet available. (It's more than 2 years since initial reply)

Hi @AxelLin , interested with this pr change. few question:

this is not related to this pr, since we not able to distribute pre encrypted fw and rely on automatic fw updates with plaintext fw (correct me). how to make sure and to secure out plaintext fw from unauthorize download and access from the server.
is the ota update only work with a sequence next partition boot. means after ota_0, must ota_1 then ota_0 back. is it possible for example to just always boot/use and update ota_0 update current boot partition ota_0. if fail boot factory?
since the issue is with the correct address, is it possible we just use simpler approach. let say i have factory and ota_0, and ota_1. so every time i do ota update, instead of automatic next ota partition. we just check the file name encrypted_ota_1.bin if no match then no update. if match then update to ota_1.bin and set as boot?
for the application to manage the partition how that can be done? what is application btw? is it the website to upload firmware or the fw itsef?

thanks!

@AxelLin -  We have to keep changing priorities of the deliverables based on constantly changing demands/requirements.  For example, https://github.com/espressif/esp-idf/issues/3671#issuecomment-504357006 says that 11r will be prioritised over 11k, 11v, however, we had to make 11k and 11v ready before 11r for other prerequisites. Our intention of providing the tentative timeline is to give visibility to everyone based on the current inputs. This may or may not translate into hard deadlines for us. Hope you understand!


Issues with SMB2 in InboundEndpoint

Description
We have tested the attached inboundendpoint with smb2 share in windows 2019 server with MI 4,1,0. We could see that after process the file is moved to OUT folder but the file size is 0 KB. When we open the file the content is empty.
When we tested the same CAPP with EI 6.6.0 for SMB2 protocol,its working without any issue.
Also in MI 4.1.0 we test it for FILE protocol and we did not see the issue. Seems like when we use SMB2 protocol we could observe this issue.
Steps to Reproduce
Steps to Reproduce the issue :
Get a MI 4.1.0 update level 19 pack
Create a SMB inboundendpoint
Put a file in to IN folder
Now check OUT folder and we could see the file size is 0KB
Affected Component
MI
Version
<IP_ADDRESS>
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Hi All,
Closing this ticket as the update is released.


Splitted the render part from Koa

Makes it easier to create static sites in the future

Looks fine and seems to work great. Will merge after build passes.


The issue of denoising

Hi,
I found that the x update does not rely on the model itself during denoising except for the last time step. In the function p_sample_loop, the update of x is covered by the function self.prepare_noised_input, which is shown below:

Could you please explain it since it seriously affects the results of the paper?
Thank you very much!

More than that, the code does not corrupt the single cell data, instead, it uses function self.prepare_noised_input to add a little noise to the whole single cell data then use the model to calculate x_0. The denoising mask is only applied to the x_start as the contextual information.

Hi @EddieBio, thank you so much for pointing this out! You are indeed right about the mistake on the inference steps due to incorrectly "resetting" for the masked entries (inpainting setting). I have just fixed this in this commit by correctly resetting the masked entries (
5de418c).
Since the issue was on the inference side, the model training was unaffected. After rerunning the experiments using the fixed code, we've achieved very similar results as before (see table below). This is also suggests that the diffusion model was trained optimally so that its full inpainting performance (generate from t=1,000) is very close, if not identical, to one-step inpainting (generate from t=1).
Thank you once again for catching this mistake! Please feel free to close the issue if you feel we have addressed your concern sufficiently.

Dataset
scDiff (new)
scDiff (old)
Diff (new - old)

Jurkat
0.8223 ± 0.00020
0.82259 ± 0.00012
-0.0003

293T
0.8102 ± 0.00008
0.81108 ± 0.00012
-0.0009

PBMC1K
0.7744 ± 0.00010
0.77497 ± 0.00036
-0.0006

Thank you very much for your reply. However, x is still updated by the function self.prepare_noised_input and q_sample rather than the diffusion steps except for the last time step.

Thank you for your reply. However, the x is still updated by the function self.prepare_noised_input and q_sample rather than the reversed diffusion steps (p_sample) except for the last time step.

Besides, I found that the x_corrupt in each batch is not larger than 0.

@EddieBio didn't I replace the prepare_noised_input function call already? I'm a bit confused about your last comment. Could you please elaborate?

@EddieBio didn't I replace the prepare_noised_input function call already? I'm a bit confused about your last comment. Could you please elaborate?

I see. It really solves the issue! Thank you very much!


Request for support in resizing the selection circle radius

Request for support in resizing the selection circle radius

@WenchaoD please, add this feature


Issue with large chunk sizes

This error occurs while filling a dataset with tensors having chunk size >= 2048.

@kristinagrig06 can you please follow the new format for templating the issue. It will be much easier for us to reproduce the issue.

@kristinagrig06
This error can occur if you chunk size is off charts. Because Codec only compresses chunk by chunk.
Can you send me script and send chunk size of that tensor?

https://github.com/activeloopai/Hub/blob/c5675b355b58cf30c168b51520d275c9c7d5504f/test/benchmark_new/chunk_benchmark.py
The chunk size is 2048

@kristinagrig06
I have looked into the issue. There is no bug here. It is just API misuse. When you say chunks=cs, it thinks you want cs samples in 1 chunk + every chunk should contain entire (cs, cs)  Tensor in it. Thus you get chunk shape (cs, cs, cs).
Either mention chunks=1, which will automatically mean (1, cs, cs) or say explicitly (1, cs, cs). Maybe another issue should be opened for documentation.


NTR zinc ion export from vacuole

def
The directed movement of zinc ions from inside the vacuole, across the vacuolar membrane and into the cytosol.
synonym
vacuole to the cytosol copper ion transmembrane transport
parents
GO:0034486 vacuolar transmembrane transport
GO:0071577    zinc II ion transmembrane transport ?
Reference
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC203372/

Hi @ValWood
About Zinc versus Zinc II - seems to me the phisiological form should be Zinc II - but do we really need to specify ?
This is also quite inconsistent for all ions.
@ukemi what do you suggest?
Thanks, Pascale

I don't think we need to specify unless there are multiple form (iron).....dual occurence could be merged and included as synonyms?

Iron, yes - zinc, are you sure it's always 2+ ?

No, I haven't a clue.....

this review says only 2 families of zinc transporter in metazoa
https://www.ncbi.nlm.nih.gov/pubmed/26084690
I think this is
http://www.ebi.ac.uk/interpro/entry/IPR002524
and
http://www.ebi.ac.uk/interpro/entry/IPR003689
and the same appears to apply to fission yeast.
So maybe if these are both for zinc 2+....


Update backscope instructions

add instructions for adding VITE_BACKSCOPE_URL to .env.local
modify code to use VITE_BACKSCOPE_URL

I think this should be merged after https://github.com/numberscope/frontscope/pull/148.

Per plan this will be comboed with #148 in a new PR and this one withdrawn.


kura-quickstart works only with camel 2.16.0 only, not w/ 2.16.1

Any idea why it happens? Have you found something in logs?

Where is the Camel version defined? Can't find it in the pom.xml and via grep? Would like to manually "downgrade" to be able to proceed.
Would it maybe make sense to officially revert to an older version, so that others don't run into this issue? Not being able to run a quickstart might be annoying.

Hi,
I will try to downgrade Camel in quickstart and give it try. Then I will
try to figure out what is root cause of the issue.
BTW We plan to introduce automated tests on hosted Raspberry Pi devices via
Jenkins jobs to detect such issues sooner.
Cheers!
śr., 16.12.2015 o 08:41 użytkownik Patrick Steiner<EMAIL_ADDRESS>napisał:

Where is the Camel version defined? Can't find it in the pom.xml and via
grep? Would like to manually "downgrade" to be able to proceed.
Would it maybe make sense to officially revert to an older version, so
that others don't run into this issue? Not being able to run a quickstart
might be annoying.
—
Reply to this email directly or view it on GitHub
https://github.com/rhiot/rhiot/issues/335#issuecomment-165023936.

--
Henryk Konsek
http://about.me/hekonsek

@gautric I've just to run the example with Camel 2.16.0 and still I can't see SCR service started.

I think I have found the motherfucker!
DEBUG 6 The 'io.rhiot.quickstarts.kura.camel.GatewayRouter' component's configuration could not be satisfied because it is required to be initialized by a ConfigurationAdmin service Configuration object, but one was not found.

Yeah, when I change configuration-policy="optional" everything seems to work regardless of the Camel version. But why did it stop to work? We need to investigate it little more.

@PatrickSteiner The quickstart is working again. Can you give it a try now? If you manage see timer messages in logs, then we can schedule a call and I will show you how to edit XML routes at runtime.

I ve retry it, with emulator mode, you right configuration-policy could be root cause

@hekonsek this is what I'm getting on a fresh installed / rebooted RPi
2015-12-16 10:43:02,002 [Component Resolve Thread (Bundle 6)] WARN  i.r.q.k.c.GatewayRouter - Problem when starting Kura module io.rhiot.quickstarts.kura.camel.GatewayRouter:
java.lang.IllegalArgumentException: Did not find component given by the name: properties
at org.apache.camel.impl.DefaultCamelContext.getComponent(DefaultCamelContext.java:431)
at io.rhiot.component.kura.router.RhiotKuraRouter.beforeStart(RhiotKuraRouter.java:106)
at io.rhiot.quickstarts.kura.camel.GatewayRouter.beforeStart(GatewayRouter.java:23)
at org.apache.camel.component.kura.KuraRouter.start(KuraRouter.java:49)
at io.rhiot.component.kura.router.RhiotKuraRouter.start(RhiotKuraRouter.java:79)
at io.rhiot.component.kura.router.RhiotKuraRouter.activate(RhiotKuraRouter.java:96)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.eclipse.equinox.internal.ds.model.ServiceComponent.activate(ServiceComponent.java:235)
at org.eclipse.equinox.internal.ds.model.ServiceComponentProp.activate(ServiceComponentProp.java:146)
at org.eclipse.equinox.internal.ds.model.ServiceComponentProp.build(ServiceComponentProp.java:347)
at org.eclipse.equinox.internal.ds.InstanceProcess.buildComponent(InstanceProcess.java:620)
at org.eclipse.equinox.internal.ds.InstanceProcess.buildComponents(InstanceProcess.java:197)
at org.eclipse.equinox.internal.ds.Resolver.buildNewlySatisfied(Resolver.java:473)
at org.eclipse.equinox.internal.ds.Resolver.enableComponents(Resolver.java:217)
at org.eclipse.equinox.internal.ds.SCRManager.performWork(SCRManager.java:816)
at org.eclipse.equinox.internal.ds.SCRManager$QueuedJob.dispatch(SCRManager.java:783)
at org.eclipse.equinox.internal.ds.WorkThread.run(WorkThread.java:89)
at org.eclipse.equinox.internal.util.impl.tpt.threadpool.Executor.run(Executor.java:70)

Yay! Working with bleeding edge code :) .
Use -U option when building quickstart. Then scp updated camel-kura-0.1.3 to RPi. You are using cached version now.

By scp I mean this step:
scp ~/.m2/repository/io/rhiot/camel-kura/0.1.3-SNAPSHOT/camel-kura-0.1.3-SNAPSHOT.jar pi@${RBPI_IP}:/tmp

@hekonsek this seemed to solve the problem. Log now shows
2015-12-16 10:53:26,722 [Camel (camel-1) thread #0 - timer://heartbeat] INFO  heartbeat - Exchange[ExchangePattern: InOnly, BodyType: null, Body: [Body is null]]
2015-12-16 10:53:27,723 [Camel (camel-1) thread #0 - timer://heartbeat] INFO  heartbeat - Exchange[ExchangePattern: InOnly, BodyType: null, Body: [Body is null]]

+1

sorry for mistake @PatrickSteiner, hope you enjoy it

It's alive! It's alive!

shouldn't I be seeing something in the kura Services?

Apparently switching configuration-policy="optional" disables our service from web UI, regardless of the fact that it has been properly registered. I will create a bug report for it and resolve it soon.
For now quickstart works, but you can't manage it via web UI.

New ticket for web UI issue - #338.


Replace PlaySoundA call with PlaySoundW to eliminate an import

Vim already links PlaySoundW; there's no need to also link PlaySoundA.

Codecov Report

Merging #4903 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4903      +/-   ##
==========================================
+ Coverage   81.49%   81.65%   +0.16%
==========================================
  Files         123      123
  Lines      143509   146152    +2643
==========================================
+ Hits       116948   119344    +2396
- Misses      26561    26808     +247

Impacted Files
Coverage Δ

src/sound.c
95.55% <ø> (+0.15%)
:arrow_up:

src/xdiff/xemit.c
67.1% <0%> (-1.39%)
:arrow_down:

src/if_python3.c
74.39% <0%> (-1.39%)
:arrow_down:

src/if_python.c
76.05% <0%> (-1.32%)
:arrow_down:

src/spellfile.c
73.86% <0%> (-1.23%)
:arrow_down:

src/blob.c
85.61% <0%> (-0.6%)
:arrow_down:

src/xdiff/xpatience.c
89.22% <0%> (-0.59%)
:arrow_down:

src/libvterm/t/harness.c
88.59% <0%> (-0.5%)
:arrow_down:

src/ex_cmds2.c
84.12% <0%> (-0.42%)
:arrow_down:

src/list.c
91.12% <0%> (-0.4%)
:arrow_down:

... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad222c...3f0a694. Read the comment docs.


Indexed storage

Purpose

Index storage of identities/accounts/IDPs under the current network.
Reset selected identity/account when switching network.
Block changing network during identity issuance.

Changes
The purpose +

Removed identity id, and net from identities/credentials

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

The list of identity providers is not reset when switching network. It probably works because we update it on-demand, but perhaps it should then be cleared when switching network to avoid any cross-polution.

When switching network we should default a selected account. For example I only have 1 account, and it might as well become the selected account when switching around instead of showing a blank account screen.


gulp task does not work

Hello
I have been using a yeoman/generator-chrome-extension.
When I run the build, clean-css related errors will occur.
sourcemap of bootstrap.css seems to cause.
how do I resolve this problem?
regards.
html
<html>
  <head>
    <meta charset="utf-8">
    <!-- build:css styles/popup-vendor.css -->
    <!-- bower:css -->
    <link href="bower_components/bootstrap/dist/css/bootstrap.css" rel="stylesheet">
    <!-- endbower -->
    <!-- endbuild -->
    <!-- build:css styles/main.css -->
    <link href="styles/main.css" rel="stylesheet">
    <!-- endbuild -->
  </head>
  <body>
  .....

gulpfile.babel.js: line 52-61
gulp.task('html',  () => {
  return gulp.src('app/*.html')
    .pipe($.useref({searchPath: ['.tmp', 'app', '.']}))
    .pipe($.sourcemaps.init())
    .pipe($.if('*.js', $.uglify()))
    .pipe($.if('*.css', $.cleanCss({compatibility: '*'}))) // <- this line
    .pipe($.sourcemaps.write())
    .pipe($.if('*.html', $.htmlmin({removeComments: true, collapseWhitespace: true})))
    .pipe(gulp.dest('dist'));
});

command
$ gulp build
[13:47:48] Requiring external module babel-register
(node:6899) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
[13:47:49] Using gulpfile ~/works/jsworks/extension-example/gulpfile.babel.js
[13:47:49] Starting 'build'...
[13:47:49] Starting 'lint'...
[13:47:49] Finished 'lint' after 254 ms
[13:47:49] Starting 'chromeManifest'...
[13:47:49] Finished 'chromeManifest' after 190 ms
[13:47:49] Starting 'html'...
[13:47:49] Starting 'images'...
[13:47:49] Starting 'extras'...
fs.js:634
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open '/Users/vertuxx/works/jsworks/extension-example/app/styles/bootstrap.css.map'
    at Error (native)
    at Object.fs.openSync (fs.js:634:18)
    at Object.fs.readFileSync (fs.js:502:33)
    at fromSource (/Users/vertuxx/works/jsworks/extension-example/node_modules/clean-css/lib/utils/input-source-map-tracker.js:84:30)
    at InputSourceMapStore.track (/Users/vertuxx/works/jsworks/extension-example/node_modules/clean-css/lib/utils/input-source-map-tracker.js:237:5)
    at Object.whenDone (/Users/vertuxx/works/jsworks/extension-example/node_modules/clean-css/lib/clean.js:145:44)
    at processNext (/Users/vertuxx/works/jsworks/extension-example/node_modules/clean-css/lib/imports/inliner.js:105:13)
    at importFrom (/Users/vertuxx/works/jsworks/extension-example/node_modules/clean-css/lib/imports/inliner.js:79:
$

I'm sorry. I made a mistake.

hi
I asked yeoman/generator-chrome-extension.
issue

Error message occurs that bootstrap.css.map is missing. It may be caused from relative path problem in reference. and it seems that related to cleancss use. Please ask gulp-clean-css of this

regards.

this issue move to jakubpawlowicz/clean-css.
issue


Fixed wrong directory and delete not required kubectl command

When trying to move Ansible playbook, an error occurs. Because kubernetes yaml file's directory has changed. Also, I deleted a line in the jinja2 file in order to avoid the error caused by productpage already existing.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @ichigism. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gyliu513
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [gyliu513]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/ok-to-test

@ichigism can you please sign the CLA?

@ichigism: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5c7a2295a6b7ddfc3676d3940211c324edbed0fb
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gyliu513, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [gyliu513,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I signed it!

@ichigism can you please sign the CLA?

I apologize for this late reply. the CLA sign has been done.


Don't use relative paths on lib load

Summary
Debian-specific patch to fix some failures with testing in our infrastructure.
I understand this might not be desirable upstream, but decided to PR anyway
so you at least know that we are doing it.
The failure happens because the lib directory is removed during testing and
relative paths were used:
https://wiki.debian.org/Teams/Ruby/Packaging/Tests#Case_eight:_autopkgtest_failure
Short checklist

[ ] Did you run bundle exec rubocop -a to fix linter issues?
[x] If relevant, did you create a test?
Not-applicable
[x] Did you confirm that the RSpec tests pass?
Everthing is passing
[x] If you are fixing a bug or introducing a new feature, did you add a CHANGELOG entry?
Not needed

Feel free to reject the PR in case it's not applicable.

Rubocop in our CI didn't like these changes, but it was mostly "cosmetic".
Prefer use of $LOAD_PATH over $: and prefer double quotes unless we rely on single quotes to avoid backslack escapes.
Both of those, half a dozen times each for each of the load lines here.
@mattbrictson @will-in-wi any opinion on merging this or not? I honestly can't remember why it was done exactly this way five years ago when we laid the foundations for this, and would be willing to merge if it doesn't set anyone back, and it helps make some stakeholder's life easier, even if they do have unusual requirements? :man_shrugging:

I think the point is that Debian's build tooling does something weird and
this is the workaround, under "sane" circumstances they should be equivalent
On Tue, 8 Oct 2019, 17:53 Matt Brictson<EMAIL_ADDRESS>wrote:

I do not understand why this works. How does adding "../../relative/path"
to the load path and then loading "file.rb" produce a different result than
loading "../../relative/path/file.rb" explicitly? They both resolve to the
same location on the filesystem, right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/capistrano/capistrano/pull/2038?email_source=notifications&email_token=AAAEUCGEAS7PUTZE3LRWBATQNSUJFA5CNFSM4I43LK22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAUVOCI#issuecomment-539580169,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAEUCB2JUKMKQ3AYEPNNX3QNSUJFANCNFSM4I43LK2Q
.

hmm, I'm feeling that this is indeed too much specific to the Debian tooling needs, it's probably better to keep it out of upstream, I have no problem in applying the patch on the Debian side, thanks a lot for the consideration.


s2i - committing the image due to error: invalid reference format

Hello,
I am getting an error when Building image using s2i tool. : invalid reference format error while doing build using s2i. I have attached following information.
s2i v1.1.7-dirty
Docker version 17.06.2-ce, build cec0b72
OS : macOs 10.12.6
s2i build nodejs application > registry.access.redhat.com/rhscl/nodejs-6-rhel7:latest  my/loadTesting --loglevel=3
ERROR
I1110 09:43:14.441094   19514 sti.go:683] npm WARN<EMAIL_ADDRESS>No description
I1110 09:43:14.441417   19514 sti.go:683] npm WARN<EMAIL_ADDRESS>No repository field.
I1110 09:43:15.519345   19514 docker.go:1065] Invoking PostExecute function
I1110 09:43:15.521015   19514 postexecutorstep.go:66] Skipping step: store previous image
I1110 09:43:15.521031   19514 postexecutorstep.go:115] Executing step: commit image
I1110 09:43:15.523350   19514 postexecutorstep.go:520] Checking for new Labels to apply...
I1110 09:43:15.523361   19514 postexecutorstep.go:528] Creating the download path '/var/folders/lt/0_hwh4g90bs4tfbn8m8jqx8w0000gr/T/s2i194844790/metadata'
I1110 09:43:15.777989   19514 postexecutorstep.go:536] unable to download and extract 'image_metadata.json' ... continuing
I1110 09:43:15.783153   19514 docker.go:1099] Committing container with dockerOpts: {Reference:my/loadTesting Comment: Author: Changes:[] Pause:false Config:0xc4203af200}, config: {Hostname: Domainname: User:1001 AttachStdin:false AttachStdout:false AttachStderr:false ExposedPorts:map[] Tty:false OpenStdin:false StdinOnce:false Env:[] Cmd:[/usr/libexec/s2i/run] ArgsEscaped:false Image: Volumes:map[] WorkingDir: Entrypoint:[container-entrypoint] NetworkDisabled:false MacAddress: OnBuild:[] Labels:map[io.openshift.s2i.build.commit.date:Fri Nov 10 07:00:02 2017 -0800 version:6 authoritative-source-url:registry.access.redhat.com io.openshift.s2i.build.commit.ref:dev com.redhat.dev-mode.port:DEBUG_PORT:5858 vcs-ref:7173d2ef184d571a5dda71794217f3ceae27d270 architecture:x86_64 com.redhat.component:rh-nodejs6-docker release:14.11 io.k8s.display-name:Node.js 6 distribution-scope:public description:Node.js 6 available as docker container is a base platform for building and running various Node.js 6 applications and frameworks. Node.js is a platform built on Chrome's JavaScript runtime for easily building fast, scalable network applications. Node.js uses an event-driven, non-blocking I/O model that makes it lightweight and efficient, perfect for data-intensive real-time applications that run across distributed devices. io.openshift.s2i.scripts-url:image:///usr/libexec/s2i io.s2i.scripts-url:image:///usr/libexec/s2i build-date:2017-10-18T13:20:42.554292 summary:Platform for building and running Node.js 6 applications io.openshift.s2i.build.image:registry.access.redhat.com/rhscl/nodejs-6-rhel7:latest io.openshift.s2i.build.commit.author:Manish Jain<EMAIL_ADDRESS>io.openshift.s2i.build.commit.id:d9c7f4489ee2867e71349060c34f9b5f7d4aa5a9 io.openshift.expose-services:8080:http com.redhat.deployments-dir:/opt/app-root/src io.openshift.tags:builder,nodejs,nodejs6 com.redhat.build-host:ip-10-29-120-69.ec2.internal io.k8s.description:Node.js 6 available as docker container is a base platform for building and running various Node.js 6 applications and frameworks. Node.js is a platform built on Chrome's JavaScript runtime for easily building fast, scalable network applications. Node.js uses an event-driven, non-blocking I/O model that makes it lightweight and efficient, perfect for data-intensive real-time applications that run across distributed devices. name:rhscl/nodejs-6-rhel7 vcs-type:git url:https://access.redhat.com/containers/#/registry.access.redhat.com/rhscl/nodejs-6-rhel7/images/6-14.11 io.openshift.s2i.build.commit.message:preprod 1900 users list (#11) io.openshift.s2i.build.source-location:git@github.com:TkeITMobility/TCSyncLoadTesting.git com.redhat.dev-mode:DEV_MODE:false vendor:Red Hat, Inc.] StopSignal:}
I1110 09:43:15.783578   19514 sti.go:435] error: Execution of post execute step failed
I1110 09:43:16.258006   19514 cleanup.go:33] Removing temporary directory /var/folders/lt/0_hwh4g90bs4tfbn8m8jqx8w0000gr/T/s2i194844790
I1110 09:43:16.258402   19514 fs.go:236] Removing directory '/var/folders/lt/0_hwh4g90bs4tfbn8m8jqx8w0000gr/T/s2i194844790'
I1110 09:43:16.264385   19514 main.go:165] Build failed
E1110 09:43:16.264406   19514 errors.go:266] An error occurred: building my/loadTesting failed when committing the image due to error: invalid reference format
E1110 09:43:16.264410   19514 errors.go:267] Suggested solution: check the build output for errors
I1110 09:43:16.264415   19514 errors.go:269] Details: invalid reference format
E1110 09:43:16.264634   19514 errors.go:273] If the problem persists consult the docs at https://github.com/openshift/source-to-image/tree/master/docs. Eventually reach us on freenode #openshift or file an issue at https://github.com/openshift/source-to-image/issues providing us with a log from your build using --loglevel=3

Hi @jainmnsh,
What is the purpose of the redirect in your command line?
s2i build nodejs application > registry.access.redhat.com/rhscl/nodejs-6-rhel7:latest my/loadTesting --loglevel=3

@csrwng sorry, typo while reporting the command. I meant "nodejs application repo" but my issue is resolved after i change the casing of new image . from "my/loadTesting" to "my/loadtesting" and it worked. thanks for your help.

@jainmnsh thx, good to know.

Investigating whether we should guard against tags with upper case letters

So I reproduced the behavior on Docker for Mac 17.09 and 1.13.1 (last version before CE). Both failed committing the image.
@bparees do you think it's worth validating in the s2i build command whether you're passing something with uppercase letters ?

Depends.  On linux we get a nice error already:
Build failed
ERROR: An error occurred: building hello-world-apP failed when committing the image due to error: repository name must be lowercase

but if that has changed on docker 17, then yes it probably is since the error that @jainmnsh got is pretty obscure.

I guess the short answer is yes, let's just do the validation.  it's easy and will save diagnosing this again in the future if we can't count on docker to report a good error.


Upgrade DuckDB to 0.9.X

We intend to do this. Currently blocked by: https://github.com/duckdb/duckdb/issues/9113

@archiewood It seems like https://github.com/duckdb/duckdb/issues/9113 is ok now :) 🚀


Add regex support

@madhawa-gunasekara Can you update this PR with the latest master and resolve conflicts.

@madhawa-gunasekara we have made some changes to the string type so it is not possible to merge this PR. However, we think that this will be useful to have. Can you fix and resend the PR?

We are closing this PR. Please send a new one


Fix distributed tests for table creation

Combine test methods to make it easier for connectors to override.

looks good


[BUG]: Missing items

Description
magnum, colossal, and gargantuan klien stars don't exist in the creativebar and JEI .
Minecraft Version
1.20.1
ProjectExpansion Version
1.1.0
Forge Version
47.2.30
Reproduction Steps
1.Open your Inventory
2.Try to find it

Known issue, already fixed and awaiting release

Fixed in 1.1.1


Emmet and auto suggestion don't work in VS code portable.

VS Code Version:  1.56.01
OS Version: Windows 10

Emmet and auto suggestion don't work in VS code portable.

When you open the command palette, and then search for Emmet commands, do you see all of them, or do you only see one?
If you only see one, Emmet is probably disabled. See https://github.com/microsoft/vscode/issues/123388 for details there.

I can fix it, thanks


Add expected_minimum to plots

This might be helpful especially in the case of there being a lot of noise.

Hi @jonathanng ,
What exactly do you mean by expected_minimum? Do you mean something like model fit to the convergence curve, so that it can be used to estimate what the minimum value will be, and do the early stopping?

I apologize - I added the comment a bit hastely. I found that we have already expected_minimum :)

That is a good point @jonathanng about categorical dimensions - if added that would be a bit restricted then.
What do others think?

Implemented in 0.7.2


Useless integration

Hi, I set up integration between Linkedin and D365. I can only say that this integration is completly useless. One of the main feature I would expect it would be an option to create D365 contact/lead from Linkedin contact/leads...but no, it is not supported (at least not for D365 - but it looks like it is supported for Salesforce)- what's wrong with you guys at Microsoft, how can you prefer product from competion (salesforce) before your own :D
So for anyone else, do not waste your time with trying to create contact/leads from Linkedin to D365 - its not supported (at the moment)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d70dd6f6-19ee-64d3-1633-5ac6c3e95da5
Version Independent ID: db7c12a4-af46-7a9d-3be3-9e6ed95c8f4c
Content: Enable LinkedIn Sales Navigator for Dynamics 365
Content Source: ce/linkedin/install-sales-navigator.md
Service: dynamics-365-sales
GitHub Login: @udaykirang
Microsoft Alias: udag

Hi @tomo00051,
Sorry for the delayed response.
you can sync leads between LinkedIn and D365. Here is link: https://docs.microsoft.com/en-us/dynamics365/linkedin/sync-linkedin-leads
However, for Dynamics 365 Sales (on-premises), we don't support LinkedIn Sales Navigator. If you would like to get more information regarding this, you can post a query in our communities page.
Hope this helps.
Thanks,
Uday


Running Prisma on Debian Ubuntu 22.04 [dev]

Bug description
Running any Prisma command on new Ubuntu 22.04 [dev] results in this error:
prisma:engines binaries to download libquery-engine, migration-engine, introspection-engine, prisma-fmt
prisma:download file<EMAIL_ADDRESS>does not exist and must be downloaded +0ms

Error: Error: Unknown binaryTarget debian-openssl-3.0.x and no custom binaries were provided
    at /home/stjepan/code/Spika3/node_modules/@prisma/engines/dist/index.js:21277:15
    at async Promise.all (index 0)
    at async /home/stjepan/code/Spika3/node_modules/@prisma/engines/dist/index.js:6621:29

This new version of Ubuntu uses debian-openssl-3.0.x and that seems to cause the problem.
I know that this version of Ubuntu is not officially released yet, I just want to bring this to your attention :)
How to reproduce
Try to use any Prisma command on Ubuntu 22.04
Expected behavior
No response
Prisma information

Environment & setup

OS: Ubuntu 22.04

Prisma Version
v3.9.2

See https://github.com/prisma/prisma/issues/11677 and https://github.com/prisma/prisma/issues/11356

так что делать менять ос?????


Raidboss: Omega Deltascape-nm + savage fr

Hi, this is Omega Deltascape NM and Savage FR. The continuation soon.
Changes made to the o2s timeline #2425 have been incorporated. This is why the check is not yet good.

@quisquous, on O4S Timeline.
1192.8 "--targetable", this is should be 1192.8 "--targetable--", no ?

@quisquous, on O4S Timeline.
1192.8 "--targetable", this is should be 1192.8 "--targetable--", no ?

Yes! Please fix, if you don't mind.

Ok, it's good.


v2.0.6: need to unset storage-connection-string env-var when creating SAS token for another SA

Description
As the title says, if the other account's information is provided, 1) the set storage-connection-string env-var should not be used, 2) I'm not sure if this order (of env-var -> cmd-line arguments) was clearly communicated in the manual page (help page)
It might be an issue for all related cmd-lines.
Environment summary
Install Method: How did you install the CLI? (e.g. pip, interactive script, apt-get, Docker, MSI, nightly)
curl ... | bash
CLI Version: What version of the CLI and modules are installed? (Use az --version)
v2.0.6
OS Version: What OS and version are you using?
Mac OS X 10.12.x
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
bash

You are correct, the order should be arguments > environment variable.


Testnet verification throws errors

Deploying to testnets from local or Github actions throws exceptions.
Could be related to Cloudflare, see: https://github.com/foundry-rs/foundry/pull/6079

Closed - working now.


Run oc cluster up within a playbook

The playbook could be configurable

Interesting project where the ansible playbook (galaxy role) could be used to :

Check if cluster is running
Run oc cluster up
Install oc client if missing

Remark: it doesn't include task to do oc cluster down

Cool, I'll have a look when I have some time.
On Thu, Mar 22, 2018, 08:02 Charles Moulliard<EMAIL_ADDRESS>wrote:

Interesting project https://github.com/chouseknecht/cluster-up-role
where the ansible playbook (galaxy role) could be used to :

Check if cluster is running
Run oc cluster up
Install oc client if missing

Remark: it doesn't include task to do oc cluster down
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/snowdrop/cloud-native-infra/issues/10#issuecomment-375189617,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AELBv2f2MWZ4CgadSNkt4MPa89tFnxWaks5tgz5ngaJpZM4SyAP-
.

The aforementioned project states it's only tested on OSX. Furthemore it doesn't seem to have been updated for about 10 months :(

But it could be easily adapted for Linux. I have added 2 roles to use it
and I will test it later today. BTW, the ommitter is a Red Hat engineer. So
we could contact him too in case we want to make some modifications ;-)
On Thu, Mar 22, 2018 at 8:18 AM, Georgios Andrianakis <
<EMAIL_ADDRESS>wrote:

The aforementioned project states it's only tested on OSX. Furthemore it
doesn't seem to have been updated for about 10 months :(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/snowdrop/cloud-native-infra/issues/10#issuecomment-375202024,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcTrjFwhIrJmMM7Mw3YC9npkkS6o8pAks5tg1BigaJpZM4SyAP-
.

--
Charles Moulliard
Apache Committer & PMC / Architect @RedHat
Twitter : @cmoulliard | Blog :  http://cmoulliard.github.io

Roles added


Updates to webpack logging output and working directory

If an error is thrown, catch it before trying to output logging info (currently fails hard because stats is undefined)
Update consumption of logStats to actually get passed to stats.toString

Currently always defaults to verbose with no way to override
Instead, default to normal log level and proxy through what is passed if logStats exists.

While webpack is running, change working directory to broccoli input tree

Currently, if you add a resolve.modulesDirectories option, it starts its search in the original project location

Use case for the working directory change:
You have a project in ES6 that you want to first run through Babel and then bundle with Webpack in Broccoli. There is a directory in the project called project_modules that you want webpack to search for the module AppDependancy in. It contains a single ES6 JS file called AppDependancy.js. You add ./project_modules to resolve.modulesDirectories expecting webpack to look at the file that Babel has processed. Instead, because webpack is running in your project directory, it discovers the original file – unparsed by Babel – and fail hard because it doesn't know how to parse ES6 modules. By switching the cwd to the broccoli input tree (the output of our Babel step), it will find the version of AppDependancy.js that Babel has parsed first, and successfully resolve.

@timmfin, this is also blocking us from moving forward with out product :) Would love feedback (and a merge / publish if all checks out) asap please!

Bump @timmfin. Any interest in this PR?

LGTM.
I'm thinking about tweaking the error handling some (after learning more about Webpack's errors), but I'll merge and publish this for now. Sorry for the delay!


Implement File.tempfile in Crystal

This patch implements tempfile creation natively in Crystal, instead of relying on mkstemp on some platforms.
We already used a custom implementation on Windows, but it lacked reliability in case of a name collision and produced overly long file names. So the new implementation is a complete rewrite.
Resolves #12082

Somewhat related: https://github.com/crystal-lang/crystal/issues/12393. I have a draft PR that also revamps some stuff. I'll have to see if this PR fixes that as well, then could just close that other PR ideally.


Allow committing empty segment when some messages are fetched but all filtered out

Fix #9014
It is slightly hard to add a test for this. Since the change is quite small, only tested locally.

Codecov Report

Merging #9089 (5b7aa78) into master (989df64) will decrease coverage by 42.44%.
The diff coverage is 60.00%.

@@              Coverage Diff              @@
##             master    #9089       +/-   ##
=============================================
- Coverage     68.88%   26.43%   -42.45%
+ Complexity     4734       42     -4692
=============================================
  Files          1835     1823       -12
  Lines         97119    96767      -352
  Branches      14632    14593       -39
=============================================
- Hits          66897    25582    -41315
- Misses        25532    68709    +43177
+ Partials       4690     2476     -2214

Flag
Coverage Δ

integration1
26.43% <60.00%> (-0.01%)
:arrow_down:

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us.


Remove flaky flag for flutter_gallery_ios__transition_perf

Description
Flaky issue has been fixed for flutter_gallery_ios__transition_perf. Removing the flaky flag.
Related Issues
https://github.com/flutter/flutter/issues/62081

@keyonghan This still isn't looking healthy...

Yeah, that's true. Just noticed there is still system dialog happening, probably related. With Tong's PR to dismiss dialogs before running test, let's see if things get better.


[CARBONDATA-1838] Refactor SortStepRowUtil to make it more readable

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[X] Any interfaces changed?
YES. REFACTORED convertRow INTERFACE IN SortStepRowUtil
[X] Any backward compatibility impacted?
NO
[X] Document update required?
NO
[X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
NO, ONLY REFACTOR THE CODE, DIDN'T CHANGE THE FUNCTION
- How it is tested? Please attach test report.
TESTED IN LOCAL CLUSTER WITH 3 NODES, DATA LOADING AND QUERYING IS OK
- Is it a performance related change? Please attach the performance test report.
NO
- Any additional information to help reviewers in testing this change.
NO
[X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NOT RELATED

NOTE
Refactor and optimize SortRowStepUtil to make it efficient and more readable.

Firstly we get all the indices for the 3 groups: dictionary columns, non dictionary dimension columns and measures;
Then for each group, just iterate the source row and copy data to each group without any if-else branch.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1580/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1981/

@jackylk can you review this?

LGTM


normalisePropertyExpression seems not to return the correct answer + follow up discussion

When I tried to get global value: globalContext.get("<IP_ADDRESS>"), an error appears:

TypeError: Cannot read property '168' of undefined

I found out that the key "<IP_ADDRESS>" is changed by function normalisePropertyExpression in (red/node-red/runtime/util.js) to an array msgPropParts: ["192",168,1,"1"]. Therefore, basically, we no longer have the key "<IP_ADDRESS>". We instead have 4 keys: "192",168,1,"1", which causes the above exception.
I am wondering what is the purpose of such a change made by normalisePropertyExpression function since it goes against the rule of pure JavaScript in this case.

Hi,
in JavaScript, <IP_ADDRESS> on its own is not a valid property expression:
For example, you cannot do:
var a = b[<IP_ADDRESS>]

If you want to use <IP_ADDRESS> as a key to an object, it has to be treated as a string:
var a = b['<IP_ADDRESS>']

So you cannot simply use <IP_ADDRESS> as a property key.
You should use '<IP_ADDRESS>' - a subtle but vital difference. However it appears we also choke on that - which is a bug and I'll fix it for 0.16 release.
In the meantime, you could add another layer in your property name:
globalContext.get("ipAddress['<IP_ADDRESS>']")

Or just do a .replace(".","-") before passing to globalContext.get() to avoid the issue at all.

Hi Nick,
Thanks for noticing the bug and the suggestion for the temporary solution.
I actually used the string "<IP_ADDRESS>" (not <IP_ADDRESS>). Replacing ".' with '_' is a good idea for btw :)

Hi @vucuong12
You are using  globalContext.get("<IP_ADDRESS>")
The value of the string you are passing is <IP_ADDRESS>.
Once we fix it, you'd need to use: globalContext.get("'<IP_ADDRESS>'") - note the extra quotes.

Thanks @knolleary . I got it :)


[HOLD for payment 2024-04-25] [TS migration] Migrate IOURequestStepConfirmation and IOURequestStepCategory pages to TypeScript

TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files

src/pages/iou/request/step/IOURequestStepConfirmation.js
src/pages/iou/request/step/IOURequestStepCategory.js

Issue OwnerCurrent Issue Owner: @JmillsExpensify

This issue is internal and will be handled by the TS team.

Hey, I'm from SWM and I'd like to take over this issue

Assigned, thanks!

I think we don't need to hold anymore?

I have filled out the payment summary above. @fedirjh also just sent you an offer via Upwork.

All set! Thank you.


[Bug]: The bundle channel is alpha, but the catalog is stable.

Describe the bug
Because channels are not defined in the Makefile, the default channels are used when the bundle is generated.
https://github.com/zncdatadev/trino-operator/blob/ef1c50493aaf6da0994495e7be49c1797f0e2b8a/Makefile#L8-L25
Have you searched existing issues?  🔎

[X] I have searched and found no existing issues

Reproduction
https://github.com/zncdatadev/trino-operator/blob/ef1c50493aaf6da0994495e7be49c1797f0e2b8a/Makefile#L8-L25
Screenshot
No response
Logs
No response
System Info
- go 1.22
- operator-sdk 0.18.2
- client-go 0.30.1
- k8s 1.26

Severity
I can work around it

wo can fix it :
diff --git a/Makefile b/Makefile
index e1e8a5a..fe0320b 100644
--- a/Makefile
+++ b/Makefile
@@ -23,6 +23,7 @@ VERSION ?= 0.0.1
 # To re-generate a bundle for other specific channels without changing the standard setup, you can:
 # - use the CHANNELS as arg of the bundle target (e.g make bundle CHANNELS=candidate,fast,stable)
 # - use environment variables to overwrite this value (e.g export CHANNELS="candidate,fast,stable")
+CHANNELS ?= "stable"
 ifneq ($(origin CHANNELS), undefined)
 BUNDLE_CHANNELS := --channels=$(CHANNELS)
 endif
@@ -32,6 +33,7 @@ endif
 # To re-generate a bundle for any other default channel without changing the default setup, you can:
 # - use the DEFAULT_CHANNEL as arg of the bundle target (e.g make bundle DEFAULT_CHANNEL=stable)
 # - use environment variables to overwrite this value (e.g export DEFAULT_CHANNEL="stable")
+DEFAULT_CHANNEL ?= "stable"
 ifneq ($(origin DEFAULT_CHANNEL), undefined)
 BUNDLE_DEFAULT_CHANNEL := --default-channel=$(DEFAULT_CHANNEL)
 endif

channel is alpha when CHANNELS is not defined show below, is it?
path is: bundle/metadata/annotations.yaml :
  operators.operatorframework.io.bundle.channels.v1: alpha
  operators.operatorframework.io.metrics.builder: operator-sdk-v1.33.0
  operators.operatorframework.io.metrics.mediatype.v1: metrics+v1
  operators.operatorframework.io.metrics.project_layout: go.kubebuilder.io/v4

Is it better to use the code below, i used the ?=  assignment operator symbol
diff --git a/Makefile b/Makefile
index abb06ce..f430fd6 100644
--- a/Makefile
+++ b/Makefile
@@ -10,6 +10,7 @@ VERSION ?= 0.0.1
 # To re-generate a bundle for other specific channels without changing the standard setup, you can:
 # - use the CHANNELS as arg of the bundle target (e.g make bundle CHANNELS=candidate,fast,stable)
 # - use environment variables to overwrite this value (e.g export CHANNELS="candidate,fast,stable")
+CHANNELS ?= stable
 ifneq ($(origin CHANNELS), undefined)
 BUNDLE_CHANNELS := --channels=$(CHANNELS)
 endif
@@ -19,6 +20,7 @@ endif
 # To re-generate a bundle for any other default channel without changing the default setup, you can:
 # - use the DEFAULT_CHANNEL as arg of the bundle target (e.g make bundle DEFAULT_CHANNEL=stable)
 # - use environment variables to overwrite this value (e.g export DEFAULT_CHANNEL="stable")
+DEFAULT_CHANNEL ?= stable
 ifneq ($(origin DEFAULT_CHANNEL), undefined)
 BUNDLE_DEFAULT_CHANNEL := --default-channel=$(DEFAULT_CHANNEL)


Executable project is not considered for serialization type resolution

Release Type: Official Release/GitHub (either)
Version: master
Platform(s): N/A
Describe the bug
In the Stride.Core.Assets.Package we only consider library assemblies to be loaded. This means if I have a script in my executable it would not be resolved for deserialization.
To Reproduce
Steps to reproduce the behavior:

Create an empty .NET Console application (with a solution)
Include Stride packages (Stride.Engine and Stride.Core.Assets.CompilerApp)
Create Assets folder in the project directory
Run GameStudio on the solution to add in the GameSettings, MainScene, GraphicsCompositor
Create a Script in the project

It's not possible to add the script to the scene in GameStudio. If added "by force" to the MainScene file, the AssetCompiler will warn that YamlSerializer couldn't deserialize it.
Expected behavior
It should be possible to create a single assembly game and have the same behavior as with library projects.
Additional context
I have modified the Package.cs on my dev branch to fix it:
https://github.com/manio143/stride/blob/f67805d7c6a00fb5a57dd17f6b8e46933ffc9d2e/sources/assets/Stride.Core.Assets/Package.cs#L1038-L1054
I will observe for a while if there's any issues and if not I'll submit a proper PR

Solves  #833 Script Editor bug

Note: mobile platforms (UWP, Android, iOS) need to be excluded here, because they don't have a proper assembly output (exe/dll) and instead are packaged during compilation.

Yes, the reason default is to separate library from executable is that executable projects is often a TargetFramework incompatible for loading within Game Studio (i.e. .NET Core project with .NET FW game studio).
However, it's true that if the user works only with a specific platform, the game studio can load, it's not a problem to do it.
Not sure how to properly expose that in a user-friendly way...
Maybe have a template for a "simple desktop game" that contains only an executable project matching the current framework of running editor (for now it could be either .NET Core or .NET FW, but soon it should be even more simple with only one option).


feat(matching): highlight matched string parts in options

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #57
Summary:
This change adds a matchWord property that is used to leverage markJS to make highlight selections within menuoptions.
matchWord must be set by the parent component.
Type of change:
Please delete options that are not relevant.

[x] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

Merging per discussion with Blackfalcon.


Additional Jira http Headers

We need the possibility to send additional http headers to the Jira calls.

Sounds like a good candidate for a hacktoberfest contribution ^_^


Fix assignment to uninitialized pointer

One of these things is not like the others...
Refs #650

Sigh... Thank you @flandr!

Misread set_integer; this is just a dereference of uninitialized pointer. Still a bug, but less severe.


lv2specgen: Allow to override build date

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Cool, thanks.
I've cherry-picked this and done some trivial clean-ups, added attribution, and made the main documentation index page support this as well so everything is consistent and reproducible.


About changing the API struct, e.g: muti-return with err.

	iter := query.Iter(conn)
	if iter.Error() != nil {
		log.Panicln(iter.Error())
	}

I think it would be better that iter use muti-return val, which is golang API usually do.
	iter, err := query.Iter(conn)
	if err != nil {
		log.Panicln(err)
	}

@m1nor  How do u think about it?

The correct example is in README
for iter.Scan(&name, &date) {
    //
}
if iter.Error() != nil {
    log.Panicln(iter.Error())
}

Errors in Scan will also be accessible via iter.Error(). I don't think we should break compatibility to separate Iter creation errors and Scan errors.
I'm not closing this issue because it really should be discussed.


Serialization error with hyper?

We have Tableau 10.5.3; and using the new logshark 2.1; are getting an error; but it's not a fatal error; but wondering if we should be worried; or if there is a configuration setting somewhere to change this.
Failed to process file 'hyper\hyper_2018_06_28_02_56_49-part2.log': Maximum serialization depth exceeded (does the object being serialized have a circular reference?).
Here's the logfile and the config file; stripped of servernames, usernames, and passwords.
Logshark.config.txt
tableau_logshark.log.20180628.152256.txt

Hi,
Thanks for reporting this! The problem is caused by the deeply nested json in hyper logs (often occurs when log level is set above INFO). We will fix it in the next release of LogShark

Version 3.0 able to recognize this scenario and issues a correct warning. We exclude such long lines from results, however they do not affect anything else and the rest of the data should be complete


Update PropTypes so that componentTag may accept a React Component as well as a String.

This was useful in my case to add aria attributes to the ul element.
I think there may be many other use cases as well, like using a custom styled component or glamorous component.
The only change that is needed is to the PropTypes to stop the warning.
Thank you for the awesome component!

It is unclear to me why the checks failed, but if I could get some direction on what went wrong, I would love to fix it.

You got the same issue I got with the project's Travis CI build. The node v4 build fails, showing The command "eval yarn " failed.

@jkdowdle Thanks!
As @julianfresco said, this PR itself has no plobrem with CI.


Add health check/monitoring

Add Prometheus monitoring middleware to RDFShape.
http4s already includes middleware support for it.

Redundant with #95 😅


Issue when registering

When I tried to register and use a Google generated password (you know a lenghty complex one with !@#$#@) I got this error. When I changed to password to a simpler one it worked ;)

I believe the issue was that the authentication API (responsible for registration) was not awake, it took 10 seconds or so to wake up after your first request, and when you sent another request, it was already awake and able to process your registration. The issue shouldn't appear after we move the authentication API to a paid hosting plan. 👍

We upgraded to a paid Heroku plan so the issue should no longer occur.


Let me select the month

Is a suggestion. But I find it interesting to allow you to select the entire month.

You can select a month now, but it will still be a Date object, the 1st of the month.


Wine shim docker rewrite

Why do you close?

Not worth it. I made it from the shim branch which would be just awkward to work with. If you need the code, just look at the build folder with Dockerfiles here.


Add social menu

Could this be a greenwood component?  ie, something other projects could use?
Could I somehow use https://github.com/ProjectEvergreen/greenwood/blob/master/www/components/social-icons/social-icons.js
And add meetup/linkedin, remove slack/twitter?

Yeah, feel free to grab it and add it!

Rocked out w/ just a few links in the header


Doesn't update when input changes

When the object passed into [(ngModel)] changes, the view doesn't get updated. I believe this is because the component needs to implement OnChanges and handle the change. Thanks!

Hrmm.... you're right. It must be a bug on my end then.


Index type definition has no default export

Get the following error whenever trying to follow the component registration steps in documentation:

"/node_modules/vue-form-wizard/types/index" has no default export

Managed to fix my local version by slightly editing the index type definition to look like this:
`import Vue from 'vue'
import { PluginFunction } from "vue";
export function install (vue: typeof Vue): void
import { Wizard } from './FormWizard'
import { Tab } from './TabContent'
import { Step } from './WizardStep'
export class FormWizard extends Wizard {}
export class TabContent extends Tab {}
export class WizardStep extends Step {}
declare class VueFormWizard {
static install: PluginFunction;
FormWizard: FormWizard;
TabContent: TabContent;
WizardStep: WizardStep;

}
export default VueFormWizard;`
I'm very new to both typescript and vuejs though, so I'm aware this might not be the proper "fix".

You should post a PR for this. I ran into the same situation, and it doesn't make sense for me to edit the type definition that came with the package, since my build server will simply pull the package in via NPM and I'll run into the same problem there.

@dnasir's version works for me. how do you apply this without modifying node_modules?


BigQuery FILE_LOADS failed with 400 error in streaming mode in Python

We are using FILE_LOADS to write to BigQuery in streaming mode using Python.
after running for about 1 hours, beam job throws an exception with regards to RuntimeError: apitools.base.py.exceptions.HttpBadRequestError including error message "Load configuration must specify at least one source URI".

//
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/apache_beam/runners/worker/sdk_worker.py",
line 289, in _execute
    response = task()
  File "/usr/local/lib/python3.8/site-packages/apache_beam/runners/worker/sdk_worker.py",
line 362, in <lambda>
    lambda: self.create_worker().do_instruction(request), request)
  File "/usr/local/lib/python3.8/site-packages/apache_beam/runners/worker/sdk_worker.py",
line 606, in do_instruction
    return getattr(self, request_type)(
  File "/usr/local/lib/python3.8/site-packages/apache_beam/runners/worker/sdk_worker.py",
line 644, in process_bundle
    bundle_processor.process_bundle(instruction_id))
  File "/usr/local/lib/python3.8/site-packages/apache_beam/runners/worker/bundle_processor.py",
line 999, in process_bundle
    input_op_by_transform_id[element.transform_id].process_encoded(

File "/usr/local/lib/python3.8/site-packages/apache_beam/runners/worker/bundle_processor.py", line 228,
in process_encoded
    self.output(decoded_value)
  File "apache_beam/runners/worker/operations.py",
line 357, in apache_beam.runners.worker.operations.Operation.output
  File "apache_beam/runners/worker/operations.py",
line 359, in apache_beam.runners.worker.operations.Operation.output
  File "apache_beam/runners/worker/operations.py",
line 221, in apache_beam.runners.worker.operations.SingletonConsumerSet.receive
  File "apache_beam/runners/worker/operations.py",
line 718, in apache_beam.runners.worker.operations.DoOperation.process
  File "apache_beam/runners/worker/operations.py",
line 719, in apache_beam.runners.worker.operations.DoOperation.process
  File "apache_beam/runners/common.py",
line 1241, in apache_beam.runners.common.DoFnRunner.process
  File "apache_beam/runners/common.py",
line 1321, in apache_beam.runners.common.DoFnRunner._reraise_augmented
  File "/usr/local/lib/python3.8/site-packages/future/utils/__init__.py",
line 446, in raise_with_traceback
    raise exc.with_traceback(traceback)
  File "apache_beam/runners/common.py",
line 1239, in apache_beam.runners.common.DoFnRunner.process
  File "apache_beam/runners/common.py",
line 768, in apache_beam.runners.common.PerWindowInvoker.invoke_process
  File "apache_beam/runners/common.py",
line 891, in apache_beam.runners.common.PerWindowInvoker._invoke_process_per_window
  File "apache_beam/runners/common.py",
line 1374, in apache_beam.runners.common._OutputProcessor.process_outputs
  File "/usr/local/lib/python3.8/site-packages/apache_beam/io/gcp/bigquery_file_loads.py",
line 520, in process
    job_reference = self.bq_wrapper.perform_load_job(
  File "/usr/local/lib/python3.8/site-packages/apache_beam/io/gcp/bigquery_tools.py",
line 825, in perform_load_job
    return self._insert_load_job(
  File "/usr/local/lib/python3.8/site-packages/apache_beam/utils/retry.py",
line 260, in wrapper
    return fun(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/apache_beam/io/gcp/bigquery_tools.py",
line 438, in _insert_load_job
    return self._start_job(request).jobReference
  File "/usr/local/lib/python3.8/site-packages/apache_beam/io/gcp/bigquery_tools.py",
line 449, in _start_job
    response = self.client.jobs.Insert(request)
  File "/usr/local/lib/python3.8/site-packages/apache_beam/io/gcp/internal/clients/bigquery/bigquery_v2_client.py",
line 345, in Insert
    return self._RunMethod(
  File "/usr/local/lib/python3.8/site-packages/apitools/base/py/base_api.py",
line 731, in _RunMethod
    return self.ProcessHttpResponse(method_config, http_response, request)

 File "/usr/local/lib/python3.8/site-packages/apitools/base/py/base_api.py", line 737, in ProcessHttpResponse

   self.__ProcessHttpResponse(method_config, http_response, request))
  File "/usr/local/lib/python3.8/site-packages/apitools/base/py/base_api.py",
line 603, in __ProcessHttpResponse
    raise exceptions.HttpError.FromResponse(
RuntimeError: apitools.base.py.exceptions.HttpBadRequestError:
HttpError accessing <https://bigquery.googleapis.com/bigquery/v2/projects/my-project/jobs?alt=json>:
response: <{'vary': 'Origin, X-Origin, Referer', 'content-type': 'application/json; charset=UTF-8',
'date': 'Tue, 09 Mar 2021 09:31:01 GMT', 'server': 'ESF', 'cache-control': 'private', 'x-xss-protection':
'0', 'x-frame-options': 'SAMEORIGIN', 'x-content-type-options': 'nosniff', 'transfer-encoding': 'chunked',
'status': '400', 'content-length': '318', '-content-encoding': 'gzip'}>, content <{
  "error": {

   "code": 400,
    "message": "Load configuration must specify at least one source URI",
    "errors":
[
      {
        "message": "Load configuration must specify at least one source URI",
        "domain":
"global",
        "reason": "invalid"
      }
    ],
    "status": "INVALID_ARGUMENT"
  }
}

Perhaps, this can be fixed by validating the input value [files(= element[1])|https://github.com/apache/beam/blob/v2.28.0/sdks/python/apache_beam/io/gcp/bigquery_file_loads.py#L469] is not empty.
Imported from Jira BEAM-11939. Original Jira may contain additional context.
Reported by: yshimizu.

Is this issue being actioned? We encounter this issue whenever we move a pipeline into draining.  This issue prevents us from using the draining status as a mechanism for checking if a pipeline has fully cleared its backlog, and requires us to make estimations for when a pipeline is done, before directly canceling.  This is not ideal.  I can provide more info if requested!

@rizenfrmtheashes could you provide a code sample we could use as a repro?

cc: @johnjcasey  @BjornPrime

This is very helpful, thank you so much, @rizenfrmtheashes .
As a next step, we should identify whether the error is caused in the drain logic, or this is a gap in BQ IO implementation (incorrect usage of BQ apis during the call in draining phase). I suspect it's the latter . Will try to find an owner for this to look closer.

There was a similar issue a few months ago where a pipeline in draining was running into similar errors. This connector used to throw and early error when a source URI (ie. file to load to BQ) is not provided. The other issue was mitigated with https://github.com/apache/beam/pull/17566/files where the error was replaced with a warning.
In contrast, the error in this issue looks like it's from BigQuery...
Looks like this is running into a similar problem where there are no files to load since the pipeline is in draining phase, but load job requests are still being sent.

Could reproduce this with the following pipeline:
destination = "<myproject>:<dataset>.<table>"
    empty_files = []
    load_job_prefix = "test_prefix"

    with beam.Pipeline() as p:
      (p
       | beam.Create([(destination, empty_files)])
       | beam.ParDo(bqfl.TriggerLoadJobs(), load_job_prefix))

I think it would be safe to log a warning and ignore the bundle in TriggerLoadJobs if no files are there.

Although I'm having trouble identifying what exactly causes us to end up with empty files during draining.


GO:0140030 	modification-dependent protein binding

I think that it would be good to review the use of these terms:
GO:0072572	poly-ADP-D-ribose binding
GO:0072571	mono-ADP-D-ribose binding
GO:0072570	ADP-D-ribose binding

I think that the majority would apply to the binding of proteins PTM'd by ADP-D-ribose(s) rather than the free unit. PMID:20088964
An example are Ub ligases that target ADP-ribosylated proteins. e.g. http://www.ebi.ac.uk/interpro/entry/InterPro/IPR033509/
http://www.pantree.org/node/annotationNode.jsp?id=PTN001002511

directly relates to #12787

Should we even have terms for 'modification -dependent protein binding'?
We have 2 ways to capture this. One with a term, and one with a modified form. Would it be better if we always did it one way?

As these are binding a motif + mod, it's a bit more expansive than a one:one relationship that is captured  by mod protein binding + PRO id 1:1.
I think having higher order classes, such as 'glycosylation-dependent protein binding' is also great when there is a good chance that you don't know the exact nature of the mod or even where it is.

As these are binding a motif + mod, it's a bit more expansive than a one:one relationship that is captured by mod protein binding + PRO id 1:1.

I didn't get this part

I think having higher order classes, such as 'glycosylation-dependent protein binding' is also great when there is a good chance that you don't know the exact nature of the mod or even where it is.

Yes that's a good point.  But I think (although am not 100% sure) that you can have a generic modified form from PRO.

What I mean is that the ADP-ribs. motif may reside in any number of different proteins (https://en.wikipedia.org/wiki/ADP-ribosylation). Querying based on this term would have use cases.
We've been here and dicussed this before: #12787 and these grouping term were deemed useful. Looks to me as if the ADP-D-ribose binding terms were missed in this review.

Existing annotations (experimental evidence)
Term | GP | Evidence (PMID) | binding to (ribose / ribosylated protein)
GO:0072570 | ZFIN:trpm2 | IDA (PMID:31844070) | ADP-ribose
GO:0072570 | UniProt:PARP9 | IMP (PMID:26479788) | poly ADP-ribose
GO:0072570 | UniProt:PARP9 | IMP (PMID:28525742) | poly ADP-ribose
GO:0072571 | UniProt:trpm2 | IDA (PMID:30250252) | mono ADP-ribose
GO:0072571 | UniProt:TRPM2 | IDA (PMID:30467180) | mono ADP-ribose
GO:0072572 | FlyBase:CG1218 | IDA (PMID:20088964) | poly ADP-ribose
GO:0072572 | UniProt:RNF146 | IDA (PMID:21478859) | poly ADP-ribose and ribosylated protein
GO:0072572 | dictyBase:DDB0192167 | IDA (PMID:27587838) | poly ADP-ribose
It seems so far the use are consistent with the definitions of these 3 terms. Binding of GP to ADP-ribosylated proteins are probably primarily directly through the ADP-ribose moiety, which is a rather large molecule. In some cases the poly ADP-ribose is thought to act as an adaptor or scaffold for multiple proteins. A good review is PMID:26673700 "Readers of poly(ADP-ribose): designed to be fit for purpose".
I think strictly speaking, what PMID:20088964 showed was that a poly-ADP-ribose (pADPr)-binding zinc-finger (PBZ) domain protein binds to 'free' ribose, based on NMR studies. Though the biological function may be ribosylated protein binding for the fly protein CG1218.
It makes sense to try to link ribosylated protein binding to ribose binding. We could

Add ribosylated protein binding in the definition of ADP-D-ribose binding. OR
Add a new term.

GO:0140030 modification-dependent protein binding
...ISA  (new term) ADP-D-ribose modification-dependent protein binding DEF "Interacting selectively and non-covalently with a protein upon ADP-ribosylation of the target protein."
And if all "ADP-D-ribose modification-dependent protein binding" is through binding of ADP-ribose,
GO:0072570 ADP-D-ribose binding
...ISA (new term) ADP-D-ribose modification-dependent protein binding
@hattrill Do you know of any case where ribosylated protein binding may not be also ADP-ribose binding?

Probably these represent binding are within proteins?
GO:0072572 -> 3 EXP
GO:0072571 -> 2 EXP
GO:0072570 -> 5 EXP
@raymond91125 would you have a look at the annotations to see if that's the case? If so we could standardize the term labels and definitions, and move the terms at the proper location in the ontology.
Thanks, Pascale

Sorry @raymond91125 this fell off my list to reply to:

@hattrill Do you know of any case where ribosylated protein binding may not be also ADP-ribose binding?

As far as I can see, it is ADP-ribose only:
-poly-ADP-ribosylated proteins are targeted by a variety of proteins that might recognise consecutive ADP-ribosyl units or larger strings often with some contribution from the underlying consensus motif of the target protein.
For
mono-ADP-ribosylated proteins, often recognised by distinct sets of mono-ADP-"readers" - it seems to be the ADP-ribose unit that is bound in the context on the mono-form rather than just a terminal ADP-ribose  of a chain.
The ADP-ribose of the polymer/monomer maybe modified in someway - O-acetyl-ADP-ribose is the one I have encountered. So probably the definition should have the "ADP-ribose or derivative" claus to encompass every flavour available.
Readers of poly(ADP-ribose): designed to be fit for purpose  https://academic.oup.com/nar/article/44/3/993/2502682

Actually all 10 annotations' references showed binding to ADP-ribose, the free molecule. In the case of the TRPM2 proteins, the ADP-ribose is used as a gating regulator of a channel function. In the case of RNF146, it binds poly(ADP-ribose) in vitro and binds to PARsylated proteins in cells.

Probably these represent binding are within proteins?
GO:0072572 -> 3 EXP
GO:0072571 -> 2 EXP
GO:0072570 -> 5 EXP
@raymond91125 would you have a look at the annotations to see if that's the case? If so we could standardize the term labels and definitions, and move the terms at the proper location in the ontology.
Thanks, Pascale

It seems we have a similar situation in SUMO binding vs. sumo-dependent protein binding. That is, sumo-dependent protein binding is through SUMO peptide moiety and yet these two terms are not connected in the ontology.

Should be annotated in terms of in vivo function - so for this: http://europepmc.org/article/MED/27587838
although in vitro binding poly(ADP)-ribose, target is the modified protein not free molecule.
For https://www.sciencedirect.com/science/article/pii/S0021925819631236 TRPM2 is sensing free ADP-ribose, so genuinely free.

Good point. Following the examples of other PTMs, we should certainly have a MF term of something like "ADP-D-ribose modification-dependent protein binding".
What I am concerned about is whether we should have a relationship between this new term and the term GO:0072570 ADP-D-ribose binding. From my understanding of the field knowledge, "ADP-D-ribose modification-dependent protein binding" is always via binding of the ribose moiety. Thus, I propose, to make annotation and querying easier, in addition to adding the new term to the modification-dependent protein binding branch, we also link it to the ADP-D-ribose binding as an ISA child.
But, I am also aware of the fact that the sumolated protein binding and ubiquitinated protein binding are not directly connected to SUMO binding and ubiquitin binding, respectively. So I am seeking some guidance.

We should consider if  we are going to replicate modification dependent protein binding in GO because

Seems unsustainable once we move to phosphorylation etc,

Is incomplete  because specific position is important too for modifications that occur at multiple residues.
hht1 https://www.pombase.org/gene/SPAC1834.04
binds bir1 active form hht1/InitMet-/Phos:(T3)
binds swi6 active form hht1/InitMet-/Me:(K9)
(OK we have a precedent for histone readers, but what about all other proteins?)

Does not cover annotations where only the non-modified form is bound/binds
e.g. https://www.pombase.org/gene/SPAC1F5.04c
cdc12 active form cdc12/UnPhos:(T20,T21,S64,T95,T151,S463)  binds cdc15

It seems more informative and consistent to request the modified protein version of a specific protein and use that in column 17. Am I missing something?
Is the idea that we always use modified  residue binding +  column 17 modified form?

I would say that the solution lies somewhere inbetween:
-a limited number of modified protein binding terms (there are only so many mods) as the recognition of a protein+mod is the molecular function of the binding portion of the protein - ie a reader/transducer of signaling marks.
If there is a enough info or need to capture position-specific info, then the appropriate PRO ID could be requested and used as an extension to X-dependent protein binding.
If absolutely everything needs a specific PRO ID, it puts a lot of bioinformatics pressure on the users of this data and presents an activation barrier to potential useful searches e.g. glycosylation-dependent protein binding AND extracellular.
Commiting to using a limited number of MF mod-dependent terms would be very useful and I think, wrt Noctua, it prevents a potential explosion of PRO ID requests to describe basic signaling pathway.

Sounds sensible,  I haven't been using these terms for phosphorylation-dept binding. Maybe I should rectify that.

Take a conservative step by adding the new term "ADP-D-ribose modification-dependent protein binding" but not connecting it to "ADP-D-ribose binding".

Hi @raymond91125
According to @hattrill

target is the modified protein not free molecule.

So I thought we were going to either change the term labels or obsolete the existing terms?
You can probably merge the PR for the new term, but does that close the issue?

@pgaudet
I'm not sure if we should obsolete the ribose binding terms because:

There are proteins that binds the free molecule ("In the case of the TRPM2 proteins, the ADP-ribose is used as a gating regulator of a channel function.")
Poly-ADP-ribose may be used as an adaptor to bring multiple PAR-binding proteins physically together. (https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6702056/)
Of the 10 experimental annotations, I don't believe it is stated that in vivo binding of free ribose molecule is excluded. It would seem reasonable to assume that given the in vitro binding, in vivo binding is possible if not likely, whether or not the ribose is free or being attached to a polypeptide.

@hattrill Please correct me if I'm wrong. Also do you think more should be done about this ticket?
Thanks.

So, I think we should distinguish free and covently attached to protein forms - should be annotated in terms of in vivo target molecule rather than in vitro experiment (you can get anything to stick in protein crystals at the right conc.).
See lazy mock up:

With the free unit, is it only TRPM2 that binds free ADP-ribose. If so, perhaps we should treat this the same as other channel-gating terms such as "intracellularly ATP-gated ion channel activity":

Thanks for the summary @hattrill
So I think the actin points are

[ ] obsolete
GO:0072572 poly-ADP-D-ribose binding
GO:0072571 mono-ADP-D-ribose binding
GO:0072570 ADP-D-ribose binding (keep???)
[ ] create new term, based on the TCDB description (if that helps): http://www.tcdb.org/search/result.php?tc=1.A.4.5.5, something like, ADP-ribose/NAD/pyrimidine nucleotide-gated Ca2+ channel.

Is this right?
Thanks, Pascale

Hi @pgaudet
Because of the annotations made with these terms, I would be inclined to:
rename:

GO:0072572 poly-ADP-D-ribose binding -> poly-ADP-D-ribose modification-dependent protein binding
(from proteins annotated with this term, this should be fine as this reflects the biological target)

New Term: mono-ADP-D-ribose modification-dependent protein binding (as we don't have mARPs as far as I can see from non-automated annotation). Papers such as PMID:23473667; PMID:34023495 (review)

Make new parent term 'ADP-D-ribose modification-dependent protein binding'  is_a  GO:0140030 'modification-dependent protein binding' and move GO:0072572 and new term 'mono-ADP-D-ribose modification-dependent protein binding' under this term.

Merge: GO:0072570 ADP-D-ribose binding and GO:0072571 mono-ADP-D-ribose binding -> GO:0072570 ADP-D-ribose binding.
Spec in definition that this is free molecule.
All manual annotations, apart from PARP9, are Trpm2's. Although this channel is the only example of free ADP-ribose binding in vivo, I wouldn't be surprised if there are other similar sensors.

Reannotation for PARP9 - this is an enzyme (NAD+ ADP-ribosyltransferase activity).

And would support something like: 'ADP-ribose/NAD/pyrimidine nucleotide-gated Ca2+ channel activity' for Trpm2's

Hope that makes sense.

Yes, thanks for the detailed action points.

PARP9 has already been annotated with NAD+ ADP-ribosyltransferase activity. But it is also regulated by binding to PAR PMID: 28525742.

Added three new terms. Leaving 'free ribose' binding terms separated from 'ribose PTM-dependent protein' binding terms for now. As this scheme follows that of ubiquitin-like binding terms. Further actions involving merging or obsoleting terms may be considered.

Can this be closed?

See PMID: 30097863

PARG can produce protein-free poly-ADP-ribose
PMID:8125093 Endoglycosidic cleavage of branched polymers by poly(ADP-ribose) glycohydrolase


Error on newest version Tuinty (paper fork)

I have newest version Protocollib (for newest version paper) #498
and newest version tuinty (paperfork) #199

I am having this same issue on my server. It is preventing us from updating to the latest version of Tuinity.

This occurs on Paper as well.
/Version:
This server is running Paper version git-Paper-562 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)
You are 8 version(s) behind
In-Chat:
https://gyazo.com/88047c11ec1c67be99b11926f9ec9c0e
I used [Item] & [i] for normal items & custom items.

Join my discord server https://discord.gg/VFZrAJ8. React in #info. Then follow the instructions in #updates.


CI: add k8s logs to GitHub Summary

This PR attaches logs from neonvm-system and kuttl-test-* namespaces to GitHub Step Summary.
Here's an example: https://github.com/neondatabase/autoscaling/actions/runs/6960120849?pr=597#summary-18938907450
GitHub Step Summary is limited by 1Mb, so if we have more logs then we won't be able to display it. I guess we can truncate it by 1MB, but it can be done later, for neonvm-system and kuttl-test-* namespaces 1MB is enough.
All the information is still available in the regular job output (in addition to logs and events from other namespaces)
Note that currently kuttl-test-* namespace got deleted automatically by kuttl, this will be changed in https://github.com/neondatabase/autoscaling/pull/635

@bayandin still draft ?

@bayandin still draft ?

I've pushed some minor changes, now it's ready for review!


[meshery]meshery bash script to allow installation of cli alone

Description
meshery installation bash script installs cli and also deploys Meshery server.
Provided an option to install cli and bail out, instead of proceeding with Meshery deployment.
This PR fixes #3200
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

🚀 Preview for commit 801a21ba62b9bda0eb56b5bc45f67e85d7f80387 at: https://6104268fe28ad80dc5665248--meshery-docs-preview.netlify.app

Codecov Report

Merging #3692 (801a21b) into master (b27c426) will decrease coverage by 7.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3692      +/-   ##
==========================================
- Coverage   20.59%   12.79%   -7.81%
==========================================
  Files          45       45
  Lines        3807     3807
==========================================
- Hits          784      487     -297
- Misses       2817     3205     +388
+ Partials      206      115      -91

Flag
Coverage Δ

gointegrationtests
?

unittests
12.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (-62.83%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
1.11% <0.00%> (-53.54%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
0.90% <0.00%> (-39.10%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.42% <0.00%> (-21.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27c426...801a21b. Read the comment docs.

🚀 Preview for commit fd29e4e73dfa3dd88204d12f6728b9c0ee3045e7 at: https://6104cd3e86f4046914abd0c3--meshery-docs-preview.netlify.app

🚀 Preview for commit 8b31a4408847c9eada484871915edc6d060a8b3c at: https://6104cf72ac08285e1134dc54--meshery-docs-preview.netlify.app


Install log handler for macOS embedder

Rather than relying on the engine's fallback log handling in lib/ui/ui_dart_state.cc, which is there only to avoid breaking backward compatibility with older custom embedders, install our own log handler.
Realistically, this will just continue writing logs to stdout.

That was fixed in flutter/engine#31861.


Add Documentation to Repo Wiki

🚀 Feature Proposal
Integrate all documentation found at https://docs.crossfeed.cyber.dhs.gov/product-overview into the project in the form of a Wiki.
Motivation
Adding a Wiki avoids the need to visit an external website for documentation, allows tracking of documentation changes, and integrates search capabilities.
Example
Example one: As a user, I want to search the documentation for a specific keyword.
Example two: As a developer, I want to clone the project to prepare a pull request entirely locally.
Example three: As a developer, I want to install a legacy version of crossfeed and follow the corresponding documentation for that version.

I'm not sure if we want to do this -- our documentation is already version-controlled (https://github.com/cisagov/crossfeed/tree/master/docs). Additionally, a wiki would limit more complex pages such as https://docs.crossfeed.cyber.dhs.gov/api-reference from being added.
Good ideas about search -- we should integrate with search.gov -- https://github.com/18F/federalist-uswds-gatsby#features
Additionally, we might be able to add an "edit" button directly on each doc page by following this: https://haseebmajid.dev/blog/gatsby-edit-button

Closing this for now, as we're continuing to use the docs site (where changes are still tracked in the github repo) for documentation.


Limit SF range for auto configuration

I really like this example: very well documented and easy to set up.
I would like to change the SFs that the auto configurations uses. I am quite far away from the next gateways and only messages with SF > 9 will reach the next gateway. Is there a way to change the SF range from 7 to 12 to 10 to 12?

Thanks for your compliments.
Yes it is possible to set SF manually but its effect depend on several factors.
When using OTAA activation, you can initially set the SF but it will be used for the join only. During the join the SF will be updated by the network server automatically with a SF that appears suitable to the networkserver.
When using ABP activation there is no join and the SF will not be changed. If ADR is enabled then SF may be changed over time (IIRC after the first 20 uplinks) by ADR MAC downlink command from the network server. In case of ADR the network server will select a SF that appears most suitable for the node and its signal quality (which e.g. depends on distance to gateways).
It is preferred to use OTAA for multiple reasons.
Use ADR only for stationary nodes (end devices) but not for mobile devices that are on the go.
SF is normally set automatically but if you want to set a value explicitly this is can be done with the LMIC API function LMIC_setDrTxPow(dataRate, txPower). This is a combined function that sets both data rate and transmit power.
In LMIC-node SF can be specified in the initLmic() call in setup (so you don't have to call LMIC_setDrTxPow() explicitly).
When using ABP it suffices to only specify adrEnabled and dataRate (e.g. DR_SF9 while DR_SF7 is the default).
When using OTAA you will have to specify all 4 parameters when calling initLmic() because it will only use the dataRate and txPower parameters for OTAA if setDrTxForOtaaExplicit is set to true.
initLmic() signature:
void initLmic(bit_t adrEnabled = 1,
              dr_t dataRate = DR_SF7,
              s1_t txPower = 14,
              bool setDrTxPowForOtaaExplicit = false)

Assuming that you would use ADR, to use SF9 you would have to use the following initLmic() call in setup():
(To disable ADR the first parameter should be 0.)
For OTAA:
initLmic(1, DR_SF9, 14, true)    // DR_SF9 will only be used for the initial join

For ABP:
initLmic(1, DR_SF9)

You're right. That shows SF7 and not SF10.
Partially I'm to blame for that because I forgot that LMIC-node (currently) only calls LMIC_setDrTxpow() for OTAA is ADR is disabled.
I just did some tests with a slightly modified version of LMIC-node where the ADR check is removed, but unfortunately that does not make any difference. The reason for this behavior is determined by the LMIC library, not by LMIC-node.
I therefore am unable to make any changes to LMIC-node that would allow to set a custom SF value used for the join.
This matter is not simple because the initial SF used for a join is LoRaWAN region dependent and so is the (max) txPower value. Also there is no API to set SF and txPower independently. For additional information see the following related discussion.
So currently it is not possible to set a custom SF for a join.

Thank you very much for your explanation. I follow the discussion.


Missing documentation for disableScrollPropagation

The method L.DomEvents.disableScrollPropagation isn't mentioned in the documentation.

This will be fixed in https://github.com/Leaflet/Leaflet/commit/e3f65b8dad62051079c659c9ebcf66af4ad97bbb#diff-4126cb436737830035255df088f7be61R169 when #4085 and #3916 are merged in.

:+1: Thanks.


Update revisions  on EFR32BG22 Thunderboard to HWMv2.

The current HWMv2 encourages the use of revisions not as different boards. This commit updates the current port to align with the HWMv2 goals.

This is what was originally proposed in https://github.com/zephyrproject-rtos/zephyr/pull/69231 but was rejected by @jerome-pouiller

I wonder the reason to not have thunderboard revisions as proper A/B revisions... Took a look at the PR but didn't find the reason besides some comments on cleaning the boards tree later, is that it? Also, thanks for the response, I see that you also tried the same thing on your PR, sorry for not digging enough 😅

Underlying issue was posted on https://github.com/zephyrproject-rtos/hal_silabs/pull/58#discussion_r1499049643

In fact, I believe we should keep efr32bg22_brd4184a and efr32bg22_brd4184b as two separated boards and get rid of CONFIG_BOARD_REVISION.
For information, the full names of the boards with revision are brd4184a rev A01, brd4184a rev A02, brd4184b rev A01, etc... But until now, we didn't have to change any configuration between the revisions.

I see, in that case, doesn't the current docs kind of give the wrong impressions on revisions? Didn't got any mentions of those A01, A02..., and truly thought that that A/B where the true revisions. What do you think about that?
I wonder if since dts changes are only needed between A/B, keeping them as Zephyr board revisions (like the current documentation states) is a better choice than keeping them as separate boards. I guess it may be easier to maintain this way and more aligned with all the other boards.

I would prefer they used board revisions properly but at the end of the day it's up to vendors how they want their boards structured.

Yeah, that's what matters in the end, even when not the best option. I'll hope @jerome-pouiller take a second thought on this topic, at least for Thunderboard, these brd4184a and brd4184b with only minor DTS changes between them really feel like an anti-HWMv2 way of  representation.

The CI check fails are not related to the changes in this PR.

Updated with the upstream.

@wkhadgar, sorry for the delay.
In fact, boards have 3 components: product number, variant and revision, e.g. BRD4184, B, A01. We never separate product number and variant publicly. So, from HWMv2 point of view, BRD4184A and BRD4184B are different boards.
Furthermore, we do sell different variants of the same board product number in parallel. This is very common for radio boards, where the A, B, C, and D variants could have different sub-ghz matching for 434, 490, 868 and 915 MHz.
In this specific case, it is indeed a bit confusing because the A variant was discontinued when the B variant was released.
I would like to write this policy somewhere (with a copy of this table ). Do you think boards/silabs/index.rst would be the right place for that?

@kartben

do you think this "no public variant" policy could be dismissed? Or is there an underlying issue that prevents the variants from being explicit?

humm... I don't get your point. The variant is always explicit.

I think it would be great to have this table more accessible

I fully agree. I would be glad to review a such patch.

humm... I don't get your point. The variant is always explicit.

I mean to keep BG22 as a single board, and add A/B as variants from the HWMv2 point of view, instead of board revisions as I previously intended. We would get something like brd4184/efr32bg22//a and brd4184/efr32bg22//b

although in a slightly different way.

Quite smart way I would argue, didn't though about using the ``` slt` -/like naming to solve the inconsistency. (Even though if I ever did, I'm not sure if doing the full Silabs update to match this Thunderboard issue would be possible to me 😅)
Glad to see Silabs boards getting some attention and care! Thanks @asmellby for the big update!