compilation with debugging symbols very slow

First, thanks for this wonderful library. I am amazed at how fast it can match and isolate groups!
I was evaluating using ctre for some datetime parsing, like you have in the readme; however, I am finding that the compile times are extremely long when emitting debugging symbols. I have a file, which does have some other medium weight templates, but with only 3 regex literals in the file, the compilation time goes from less than a minute to 22 minutes. Without debugging symbols, it only takes 25 seconds, so I don't believe that it is due to slowness in the library itself.
I am compiling with gcc 9.1.0, and the 3 regular expressions I am using are:
(\\d{4})-(\\d{2})-(\\d{2})
(\\d{4})-(\\d{2})-(\\d{2})( |T)(\\d{2}):(\\d{2}):(\\d{2})
(\\d{4})-(\\d{2})-(\\d{2})( |T)(\\d{2}):(\\d{2}):(\\d{2})(\\.\\d{1,9})?

I would like to add many more formats, but I am waiting to implement that until I know what is going on with the compile times. This project is currently using C++ 17 and only gcc, so I am using the _ctre UDL. In testing, I have tried the C++20 cnttp version and noticed that it is a bit faster. I am not really able to reproduce this when I just compile the longest regex standalone, so I am wondering if there is a weird interaction with the existing code somewhere.
I would like to preserve debugging symbols if possible, and if needed I could try just moving all the ctre stuff to its own object without symbols, but I am wondering if there is something else to try? If it would help, I can see about getting the actual offending code to you on Monday.

The compilation time is really oddly big. I would like to see the offending code.

Hi all,
I believe I've created a minimal working example for this issue. The code indeed takes over a minute to build even without debug symbol. I did not go the extra mile to wait for over 25 minutes on my vm, though I might do just that tommorow.
I believe I pinned down the potential offender: forced inlining of code. I've temporarily changed the definitions of CTLL_FORCE_INLINE and CTRE_FORCE_INLINE & removed forced inlining. The benchmark results can be found here.
Of course it's easy to pinpoint the issue, though it does not mean that what I did is a correct way to handle long compile times - my comment is missing:

runtime benchmark of two versions.
precisely pinpointed cause of the issue - this is only something I can go after.

I suspect staying away from forced inlining is not an option.
Needless to say I might have done something incorrectly. Feel free to point out any issues.

Hi, I've spottedthis issue in latest MSVC 2019 (19.26.28806) now, except the debug compilation is fine, but in release (/Ox flag) the compilation never ends. Removing inlining indeed unblocks it.

@Archie3d does it happen for any pattern? if not, please provide your test case.

@hanickadot no, the shorter the pattern the faster it compiles. For this one it takes forever:
static constexpr auto pattern = ctll::fixed_string { "^([a-z]+)://(([\\w\\-\\.]+)(:([\\w\\-\\?&=]+))?@)?([\\w\\-\\.]+)(:(\\d+)+)?(/[\\w\\.\\-/\\?\\(\\)&=%~]*)?$" };

though when I remove the trailing groups the compilation goes faster (than my patience wears out :)
Compilation flags (MSVC2019):
/EHsc /std:c++latest /bigobj /Ox

clang does not seem to suffer though.

That's a problem of MVSC and their constexpr evaluator :( It's not forever only too long. It's definitely a different issue than #78, please create a new one.
This issue about MSVC creating a lot of debug symbols.

+1 for the patch provided by @osiewicz , it cut my build times down from 4 mins to 11 seconds with clang, and from 3 mins to 12 seconds with gcc.
I wonder if this could be merged with a macro to override the default inlining behaviour for better build times?


Attempted import error: 'useLayoutEffect' is not exported from 'react' (imported as 'useLayoutEffect').

I followed every step and I get this error on http://localhost:3000

I can not reproduce it atm. The only guess I have is the node version and it is more like a guess out of desperation. I would suggest checking node version, reinstalling the dependancies and check if there are any other error messages in the terminal.


[Google Map Support] Remove "Google Maps" when no API key is present

Currently, when no Google API key is inserted under user's or organizations profiles the Google Maps option is available under the basemap source selection but when selected a Google error is rendered on the map view.

As users will probably try to activate them but the visual feedback is not clear enough we should remove Google Maps source option when no API key is present.

To clarify... a map might have a Google Maps basemap and it's owner (user/org) might not have a valid API key. We can hide/disable the Google Maps option from the basemap selector, but the same error message will appear on the map in this case. This will force them to:

enter a valid Google Maps API key.
switch to a non-google-maps basemap.

I guess we could be more clever about this and point users in the right direction. For example, by:

Sharing some instructions about how to get and enter the Google Maps API key.
Giving them the option to fallback to one of the CARTO basemaps.

This will require a bit of work at BUILDER level tough.
Another option could be to replace the "Oops! Something went wrong" screen from Google, by our own one, and display it whenever we encounter a map with a Google Maps basemap and there's no valid API key.
cc: @xavijam @rochoa @jorgesancha (should we prioritise this or do you guys think it's a nice to have?)

But I think we have two different issues here:

If the user does not have an API key (independently of having a valid or invalid one), do not show Google Maps basemaps. This is what @noguerol is asking for, IIRC.
If the user has an invalid API key, have a better message for end users, if possible a custom error message that we can fully control. I don't know how feasible that is. BTW, this is an existing problem, just an example: http://srogers.carto.com/viz/81916204-c392-11e3-bcbf-0e230854a1cb/embed_map.

For 1.: I would say yes, we need to not display Google Maps basemaps as an option.
For 2.: I would postpone that as a future improvement.

Following our lets-not-brake-maps rule I would go even further and automatically change, at the time of rendering, for positron whatever map is broken because of a missing or invalid API key. This will fix n2 case. And as you suggest @alonsogarciapablo @rochoa push a warning notification to the user when opening the map in Builder.
If its technically feasible, shall we put the notification thing a as separate ticket?

Feel free to open another issue for case 2. But we need to evaluate other scenarios, like users building applications with cartodb.js, where we might not want to default their maps on the presence of an invalid key.


Weird link when ViewComponent is rendered

Hello,
Just upgraded to the latest version and I am running on DotNetCore 3.1. When the viewcomponent loads i end up with a url like "_content/NToastNotify/toastr.js?something" which obviously doesn't exist. Noticed that in my prod version the link is something like
src="/NToastNotify/js/dist/toastr.js?v=201908050838"
and the new version is
src= "_content/NToastNotify/toastr.js?something"
Any ideas?
Thanks

@grayniall I'm having a similar issue? Did you solve this somehow?


client-go flags show up in every command

Currently we rope in the default client-go flags into RootCmd. This causes every subcommand to always have all the default flags, even if they're not useful or necessary to the command.
We should instead set these flags only on commands that require them.

Going to take a stab at this.


background color is not precise

giving unexpected shade of color on selecting background.

please assign me this issue.

I want to work on this can u explain me the issue


Add memo support to ibc precompiles

Describe your changes and provide context
Adding memo field support for IBC precompiles
Testing performed to validate your change

unit test
functional local test with 2 chains and hermes up

Codecov Report
Attention: Patch coverage is 45.83333% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 61.33%. Comparing base (f985944) to head (e0d0021).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1662      +/-   ##
==========================================
- Coverage   61.50%   61.33%   -0.17%
==========================================
  Files         367      367
  Lines       26575    26602      +27
==========================================
- Hits        16345    16317      -28
- Misses       9137     9194      +57
+ Partials     1093     1091       -2

Files
Coverage Δ

precompiles/ibc/ibc.go
45.18% <45.83%> (-0.07%)
:arrow_down:

... and 1 file with indirect coverage changes


taxonID required even without extensions - please update guidelines

A GBIF checklist publisher noticed an issue with the guidelines stating that:

If extensions are being used, each record in the core data MUST have a unique identifier. The field for this identifier MUST be specified in an explicit  field in order to associate extension records with the core record.

In some cases, publisher might have records in their databases for uncertain names (in this case potential synonym) that cannot be resolved, and for which they cannot provide a taxonID. However, they get an error when the try to publish their dataset stating that every record should have a taxonID, even though they do not use any extensions.
Perhaps the cited text should should be:

Each record in the core data MUST have a unique identifier. The field for this identifier MUST be specified in an explicit  field in order to associate extension records with the core record.

to avoid confusion?

Thanks for reporting this @CecSve. I'm sorry, I overlooked the original notification and only just see this when @tucotuco assigned me.
I think in the time that has passed since this was opened, we've discussed and identified that this relates specifically to the implementation choices GBIF took in the IPT; namely that it enforces taxonID to be the same as the core record id, and that it must be present and unique even when no extensions are used if I understand correctly.
The intention behind the Text Guidelines when written was less restrictive aiming to accommodate the use of Darwin Core in lots of spreadsheet data. It's reasonable that someone may design a spreadsheet where taxonID is repeated across rows, depending on their need.
Given that this seems to be a GBIF-specific problem and that it introduces a restriction that hasn't been present before, my feeling is this would be better handled in the GBIF publishing guidelines, rather than the DwC Text Guide.
What do you think, please?

Sorry for my late reply and thank you for the clarification. I agree, it is more fitting in the publishing guidelines.


[bug] Selecting SystemTrayItem Not Working If Not Defined As Selected

Describe the bug
On Ubuntu 22, If a systemTray item is not defined as selected, it cannot not be set to selected on Click Event using the set_selected(true) method.
Reproduction
let show_hide = CustomMenuItem::new("show_hide", "Hide");

//...building tauri
    .on_system_tray_event(move |app, event| match event {
            SystemTrayEvent::MenuItemClick { id, .. } => {
                let item_handle = app.tray_handle().get_item(&id);
                let window = app.get_window("main").unwrap();

                match id.as_str() {
                    "show_hide" => {
                        item_handle.set_title("Show").unwrap();
                        item_handle.set_selected(true).unwrap();    //* This will not set it to selected (no tick icon before the title)
                    }
                   // ...
                }
           }
    }

Expected behavior
If a tray item is not defined as selected, a tick icon should be shown before its title when using set_selected(true).
NOTE: If the item is SELECTED when defiend (ie.
let show_hide = CustomMenuItem::new("show_hide", "Hide").selected();

),
it will correctly select and unselect regardless of using  set_selected(true) or  set_selected(false) on each click event.
Platform and versions
yarn run v1.22.19
warning ../../package.json: No license field
$ tauri info
Environment
› OS: Ubuntu 22.04 X64
› Node.js: 14.17.0
› npm: 8.1.1
› pnpm: Not installed!
› yarn: 1.22.19
› rustup: 1.24.3
› rustc: 1.61.0
› cargo: 1.61.0
› Rust toolchain: stable-x86_64-unknown-linux-gnu
Packages
› @tauri-apps/cli [NPM]: 1.1.1
› @tauri-apps/api [NPM]: 1.1.0
› tauri [RUST]: 1.1.1,
› tauri-build [RUST]: 1.1.1,
› tao [RUST]: 0.14.0,
› wry [RUST]: 0.21.1,
App
› build-type: bundle
› CSP: unset
› distDir: ["../dist","../preview.html","../icon.png"]
› devPath: http://localhost:3000/
› framework: React
App directory structure
├─ dist
├─ .git
├─ src-tauri
├─ node_modules
└─ src
Stack trace
No response
Additional context
No response

That's a known limitation of our current API and we are working on an improved menus API where there is a distinction between normal TextMenuItem and CheckMenuItem. It is however planned for tauri@v2 because we can't break the existing API for v1.


fix-#257: Implemented show/hide password functionality

Summary
Implemented the show/hide password functionality with state & react icons.
Description

Added a new state for passwordvisible and setpasswordvisible function to set the value true/false.
Included the state in type attribute of input field of password, which toggles the type from text to password according to the state's value.
Add new svg files of eye & eye-off in the assets folder.
And finally implement a button which toggles the state's value from false to true and vice-versa using SVG icons.

Images
passwordVisibility.webm
(it supports the mobile responsive also so no need to change any thing :) )
Issue(s) Addressed
Closes #257
Prerequisites

[x] Have you followed all the CONTRIBUTING GUIDELINES?

goog to go...! @krishnaacharyaa

Good to go.. @krishnaacharyaa ...!


Fixes in 3DCursorLibrary and SensorManager

Added check for valid ray from CursorController before performing picking in SensorManager.
Added transferIoDevice() call to enableSettingsCursor() so IoDevice is not disabled and re-enabled when using the settings cursor

Will test this tomorrow.

Tested this and it works great. Good job.
This one is good to go.


Created a Parser type to allow for non-global parser configuration

Added a new type Parser, which holds all the settings you might want to apply to the parser.  I'm wary of using global settings for a parser as it can limit usefulness or cause unexpected issues if the parser is used in multiple contexts.

Enables use of the json.Number type instead of float64.  See #96 #68
Enables users to define a set of valid encoding methods to avoid unexpected behavior
Backwards compatible.  jwt.Parse method simply uses the default Parser

Still needs tests

This is ready for review.  Anyone wanna have a look?  Thoughts?


[Doc Improvement][Upload file in Teams using Bot SBS Guide][2653003]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-file-handling-in-bot.yml
84
32
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f6e82c5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/sbs-file-handling-in-bot.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-file-handling-in-bot.yml
84
32
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-file-handling-in-bot.yml
84
32
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 008c1fd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/azure-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/ngrok-url_3.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/access-as-user_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-api-teams-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-a-scope_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-file-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/app-id-uri1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/appsettings-file_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/appsettings-json1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/AppStore1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/azure-bot-created_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/bot-id_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/client-id-mobile_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/client-web_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/configuration-web_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/copy-value_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/csproj-folder_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/deployment_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/expose-api_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/go-to-home_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/new-connection-setting_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/selection-of-resource_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/select-your-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/set-api_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/teams-file-upload_1.PNG
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-file-handling-in-bot.yml
84
32
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 417c3e1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/azure-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/ngrok-url_3.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/access-as-user_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-api-teams-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-a-scope_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-file-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/app-id-uri1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/appsettings-file_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/appsettings-json1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/AppStore1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/azure-bot-created_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/bot-id_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/client-id-mobile_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/client-web_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/configuration-web_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/copy-value_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/csproj-folder_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/deployment_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/expose-api_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/go-to-home_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/new-connection-setting_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/selection-of-resource_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/select-your-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/set-api_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/teams-file-upload_1.PNG
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 55a3827:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/azure-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/ngrok-url_3.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/access-as-user_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-api-teams-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-a-scope_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-file-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/app-id-uri1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/appsettings-file_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/appsettings-json1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/AppStore1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/azure-bot-created_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/bot-id_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/client-id-mobile_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/client-web_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/configuration-web_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/copy-value_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/csproj-folder_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/deployment_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/expose-api_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/go-to-home_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/new-connection-setting_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/selection-of-resource_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/select-your-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/set-api_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/teams-file-upload_1.PNG
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-file-handling-in-bot.yml
86
30
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 66ba22d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/azure-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/ngrok-url_3.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/access-as-user_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-api-teams-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-a-scope_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-file-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/app-id-uri1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/appsettings-file_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/appsettings-json1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/AppStore1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/azure-bot-created_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/bot-id_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/client-id-mobile_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/client-web_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/configuration-web_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/copy-value_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/csproj-folder_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/deployment_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/expose-api_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/go-to-home_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/new-connection-setting_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/selection-of-resource_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/select-your-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/set-api_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/teams-file-upload_1.PNG
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-file-handling-in-bot.yml
86
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-file-handling-in-bot.yml
86
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit fa23b3a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/azure-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/ngrok-url_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/access-as-user_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-api-teams-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-a-scope_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/add-file-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/app-id-uri1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/appsettings-file_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/appsettings-json1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/AppStore1_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/azure-bot-created_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/bot-id_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/client-id-mobile_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/client-web_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/configuration-web_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/copy-value_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/csproj-folder_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/deployment_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/expose-api_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/go-to-home_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/new-connection-setting_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/selection-of-resource_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/select-your-bot_1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/set-api_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/teams-file-upload_1.PNG
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

The content has been merged to PR #7077.


Recorded Footage not lining up with overlay

Hi, i hope you can help me, basically , after i have exported the frame time data from trdrop and put it in my editing software , the graph and fps counter doesnt line up with my video? is that normal? i have a attached a photo thank you. The top bar is the trdop overlay and the bar below it is my test footage.

Hello. This happens because the video editor interprets the sequence of images at 25fps, you should tell your video editor to interpret the sequence at 60 or 30 fps depending on the speed you have recorded.


Support array types in postgres.

Postgres varchar[] and text[] are not introspected correctly.

Is there any plan to support the array type?

Is there any plan to support the array type?


SCSS: Broken syntax highlighting for nested selectors

VSCode Version: 1.18.0
OS Version: macOS High Sierra (10.13.1) and Windows 7

Steps to Reproduce:
All SCSS files now have broken syntax highlighting for nested elements since the latest update. It's the same for everyone on my team, which are split between OSX and Windows. I've done a lot of searching but somehow can't find any mention of this elsewhere, which is odd since we're all on different setups here.

Reproduces without extensions: Yes

That's what I see in 1.18 with the Dark+ theme and no extensions installed.

Maybe there was a change in the theme that you use?

Am I missing something? It also seems to be broken in your screenshot. I'm assuming that P tag is a different colour if you take it out of that nest?
Also from my original post - "Reproduces without extensions: Yes"
I've tried without any extensions whatsoever, and like I said it's on multiple machines.

Sorry, I didn't realize you only meant the p. This one in now fixed in 1.19

Ah great, thanks. It was the P and the H4 in my original screenshot, but it pretty much does it for all element selectors that are nested in any of my scss.

Same issues
Not recognizing &-name as parent-selector-suffix

looks like parsing problems as in same file later got not recognized closing brackets but selector suffix is recognized properly

Not recognizing pseudo elements correctly and double semicolon (first one is treated as punctuation separator but second as meta property value) also opening bracket is treated as part of meta property value

Pseudo elements recognized as support.type.property-name same as all css properties

Treating entity.other.attribute-name.parent-selector-suffix as variable when starts with "--"

Treating "label" tag as support.type.property-name

Treating nested tags as meta.property-name and not as entity.name.tag

Problem with recognizing ending brackets

All looks like parsing problems switching to SASS syntax for same file and everything is ok

@bartech101 There was a grammar update for 1.19 that fixed most of the issues. 1.19 will be out in the coming days.

VSCode Version: 1.19.0
OS Version: Windows 10

Most of the issues are fixed in 1.19.0 but some still exists
'cursor' property is treated as entity.name.tag

BEM "&--modifier" recognized as variable

animation name with "-" not recognized properly


Add more checks in source validator

This PR adds more checks to the source validator as requested in #770.

Make sure that the namespace is properly commented (#768)
The check works, but all namespace checks are still disabled, until refactoring is finished (see #968)
Make sure that we don't have the prefix "include/" in our own #include's
PR also includes commit that fixes violating files.

The second request in #770 "Make sure that testing utility files follow the proper naming convention" is still missing. Also the checks are added to the source validator and not in the formatter.

@apavlo "Make sure that testing utility files follow the proper naming convention" is still missing. Can you tell me what to check here? Is it about file name/location or class naming?
This is what I found about naming conventions: https://github.com/cmu-db/peloton/blob/master/test/README.md

@tcm-marcel For starters, we could check that the class name and the individual tests follow the proper naming convention. Enforcing it for the filenames is a bit tougher.

Coverage decreased (-0.02%) to 75.747% when pulling ed8ba62075253db91540f79f48bd7b25922d8984 on tcm-marcel:cleanup/source_validator into 5409ea2f202b9c1fc3a199798dbf308e14083cf3 on cmu-db:master.

@tcm-marcel Can you add a check to ensure the namespaces are also closed properly? Brace, two spaces and double-slash comment in reverse namespace nesting order?
Another check would be sorted + partitioned includes, but that's probably a different PR.

@pmenon At the moment, I get a list of namespaces that should exist, and then check if a proper opening and closing exists for every namspace. I can add more logic to also check the order of the closings.
I don't check for "wrong" namespace tags so far, as there may exist more due to forward declarations.

@tcm-marcel I am moving this back to "In Progress". You can finish it when you get back from the mountains.


Spanish translation

Hi, i translated this plugin to Spanish. Thank you for this piece of software.

That is great. Thanks!


Support cuSPARSELt

This PR adds support for cuPARSELt (https://docs.nvidia.com/cuda/cusparselt/index.html).
cuSPARSELt can be downloaded from the following URL. https://developer.nvidia.com/cusparselt/downloads
cuSPARSELt can also be installed via conda as follows (thanks to @mnicely and @leofang !).
$ conda install -c conda-forge cusparselt

To enable cuSPARSELt, when you build CuPy from source, set the environment variables CFLAGS and LDFLAGS as follows.
$ export CUSPARSELT_PATH=/path/to/libcusparselt
$ CFLAGS="-I ${CUSPARSELT_PATH}/include" LDFLAGS="-L ${CUSPARSELT_PATH}/lib64" python setup.py install

Jenkins, test this please.

Jenkins CI test (for commit 2314ed935ca4890850b590dff357cf6ff6ba3d90, target branch master) succeeded!

LGTM!

Is there a plan to make using 2:4 sparse matmuls as simple as regular dense matmuls?
Seems like a lot of code needed for one matmul: https://github.com/cupy/cupy/blob/master/examples/cusparselt/matmul.py


Cannot enable CORS or

I tried to implement this plugin https://github.com/expressjs/cors
To Access-Control-Allow-Origin
However, it's not working.
I set it under addProdMiddlewares like following
const addProdMiddlewares = (app, options) => {
  const publicPath = options.publicPath || '/';
  const outputPath = options.outputPath || path.resolve(process.cwd(), 'build');
  app.use(publicPath, express.static(outputPath));

  app.get('*', cors(), (req, res) => {
    filesystem.readFile(path.resolve(outputPath, 'index.html'), (err, file) => {
      const ip = req.headers['x-forwarded-for'] || req.connection.remoteAddress;
      if (err) {
        res.sendStatus(404);
      } else {
        const compileStr = Mustache.render(file.toString(), { userIpAddress: ip, NODE_ENV: process.env.NODE_ENV });
        res.send(compileStr);
      }
    });
  });
};

I wonder does it need any special config to enable this option?
Please advise.

turns out those static files should be set in
 app.use(publicPath, express.static(outputPath));
closed.

@chaintng what do you mean the static file should be set in `app.use(publicPath, express.static(outputPath));
`? I'm still not able to get this to work...


Automatically repost chat links to slack

In order to save a record of links posted to twitch chat, resend them to slack so they can be archived and looked for later.

Added in v1.7.2


List issues only for starred repo

Feature Description
Hi
In issues page we can retrieve issue by all, attribution, mention , ... but we haven't any option to get issues related to starred projects.
Could be related also to #5427 idea to improve star features usage.
thanks
Screenshots
No response

Maybe watched?


ModuleNotFoundError: No module named 'torch.nn.attention'

I usually train models using instances on Vast.ai. my proess did not change I am used to instantiate instances with Torch 2.1.1 and/or 2.2.0 and CUDA 12.1. I am using an RTX 3090
As always i run in this case torch 2.1.1 the followinng:
!pip install --upgrade --force-reinstall --no-cache-dir torch==2.1.1 triton
--index-url https://download.pytorch.org/whl/cu121
!pip install "unsloth[cu121-ampere-torch211] @ git+https://github.com/unslothai/unsloth.git"
no issue or error during the requirements installation. Immediatelly after i run the first cell of the notebook (Gemma2):
from unsloth import FastLanguageModel
  File "/opt/conda/lib/python3.10/site-packages/unsloth/__init__.py", line 159, in <module>
    from .models import *
  File "/opt/conda/lib/python3.10/site-packages/unsloth/models/__init__.py", line 15, in <module>
    from .loader  import FastLanguageModel
  File "/opt/conda/lib/python3.10/site-packages/unsloth/models/loader.py", line 15, in <module>
    from .llama import FastLlamaModel, logger
  File "/opt/conda/lib/python3.10/site-packages/unsloth/models/llama.py", line 29, in <module>
    from ..kernels import *
  File "/opt/conda/lib/python3.10/site-packages/unsloth/kernels/__init__.py", line 36, in <module>
    from .flex_attention import HAS_FLEX_ATTENTION, slow_attention_softcapping
  File "/opt/conda/lib/python3.10/site-packages/unsloth/kernels/flex_attention.py", line 28, in <module>
    import torch.nn.attention
ModuleNotFoundError: No module named 'torch.nn.attention'

I have tried at least 5 different instances, as I said I successfully run the notebook a couple of days ago. I did not went through the recent commit but can someone help ?
many thanks

Just tried the same locally (RTX 3090) (conda install) and i am getting the same error

Apologies just fixed!


Fix FILE_ON_GPU preset

Opening some files in the app often result in this output:
Start Holovibes
[info ] [12:24:06.760] [1524] [main]  Compute settings loaded from : C:\Users\Domodekavkaz\AppData\Roaming\Holovibes\13.2.3\compute_settings.json
[info ] [12:24:06.764] [1524] [main]  path: C:\Users\Domodekavkaz\AppData\Roaming\Holovibes\13.2.3\user_settings.json
[info ] [12:24:06.765] [1524] [main]  Recording stopped
[info ] [12:24:06.766] [1524] [main]  Worker of type class holovibes::worker::InformationWorker started with ID: 12464
[error] [12:24:13.094] [1524] [main]  C:\Users\Domodekavkaz\AppData\Roaming\Holovibes\13.2.3\preset\FILE_ON_GPU.json is an invalid buffer settings
[error] [12:24:13.094] [1524] [main]  Exception caught in notifier: Unknown exception
[info ] [12:24:13.095] [1524] [main]  Recording stopped
[info ] [12:24:13.107] [1524] [main]  Worker of type class holovibes::worker::FileFrameReadWorker started with ID: 26412
[error] [12:24:13.149] [1524] [main]  Catch Pipe is not initialized
[info ] [12:24:18.294] [1524] [main]  Worker of type class holovibes::worker::ComputeWorker started with ID: 4968
[info ] [12:24:18.410] [1524] [main]  Holographic mode set

The issue was with the path of FILE_ON_GPU.json on debug mode. It's know working correctly.


[SPARK-36479][SQL][TEST] Improve datetime test coverage in SQL files

What changes were proposed in this pull request?

This PR adds more datetime tests in date.sql and timestamp.sql, especially for string promotion.
Why are the changes needed?

improve test coverage
Does this PR introduce any user-facing change?

no
How was this patch tested?

N/A

Test build #142326 has started for PR 33707 at commit 24c5352.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46835/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46835/

Test build #142334 has started for PR 33707 at commit a7db4c0.

Test build #142335 has started for PR 33707 at commit 3d0d780.

Test build #142338 has started for PR 33707 at commit 1cf8dd7.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46843/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142326/

Test build #142340 has started for PR 33707 at commit f4d9e05.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46846/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46847/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46847/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46843/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46843/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46846/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46849/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46846/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46849/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46849/

Test build #142335 has finished for PR 33707 at commit 3d0d780.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #142338 has finished for PR 33707 at commit 1cf8dd7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142338/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142335/

Test build #142340 has finished for PR 33707 at commit f4d9e05.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142340/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142334/

The GA failure is unrelated, I'm merging this to master/3.2, thanks for the review!
@gengliangwang let's fix the discovered bugs.


Compile error on Travis CI: missing binary operator before token "("

This is the error you get if you try to npm install fast-ratelimit on Travis
npm ci stdout:

><EMAIL_ADDRESS>install /home/travis/build/xyz/node_modules/hashtable-patch-valeriansaliou
> node-gyp configure build
make: Entering directory `/home/travis/build/xyz/node_modules/hashtable-patch-valeriansaliou/build'
  CXX(target) Release/obj.target/native/src/hashtable.o
make: Leaving directory `/home/travis/build/xyz/node_modules/hashtable-patch-valeriansaliou/build'
lerna ERR! npm ci stderr:
In file included from ../src/hashtable.cpp:1:0:
../src/hashtable.h:6:64: error: missing binary operator before token "("
 #if defined __APPLE__ && defined __has_include && __has_include(<tr1/unordered_map>)
                                                                ^
In file included from ../src/hashtable.h:15:0,
                 from ../src/hashtable.cpp:1:
../src/v8_value_hasher.h:7:64: error: missing binary operator before token "("
 #if defined __APPLE__ && defined __has_include && __has_include(<tr1/unordered_map>)
                                                                ^
In file included from ../src/hashtable.h:15:0,
                 from ../src/hashtable.cpp:1:
../src/v8_value_hasher.h: In member function ‘bool v8_value_equal_to::operator()(CopyablePersistent*, CopyablePersistent*) const’:
../src/v8_value_hasher.h:43:24: warning: ‘bool v8::Value::Equals(v8::Local<v8::Value>) const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:2481): Use maybe version [-Wdeprecated-declarations]
         if (a->Equals(b)) {          /* same as JS == */
                        ^
../src/hashtable.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE HashTable::Constructor(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/hashtable.cpp:50:43: warning: ‘int32_t v8::Value::Int32Value() const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:2478): Use maybe version [-Wdeprecated-declarations]
         int buckets = info[0]->Int32Value();
                                           ^
../src/hashtable.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE HashTable::Rehash(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/hashtable.cpp:231:42: warning: ‘int32_t v8::Value::Int32Value() const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:2478): Use maybe version [-Wdeprecated-declarations]
     size_t buckets = info[0]->Int32Value();
                                          ^
../src/hashtable.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE HashTable::Reserve(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/hashtable.cpp:249:43: warning: ‘int32_t v8::Value::Int32Value() const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:2478): Use maybe version [-Wdeprecated-declarations]
     size_t elements = info[0]->Int32Value();
                                           ^
../src/hashtable.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE HashTable::MaxLoadFactor(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/hashtable.cpp:266:39: warning: ‘double v8::Value::NumberValue() const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:2475): Use maybe version [-Wdeprecated-declarations]
         factor = info[0]->NumberValue();
                                       ^
../src/hashtable.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE HashTable::ForEach(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/hashtable.cpp:289:33: warning: ‘v8::Local<v8::Object> v8::Value::ToObject() const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:10046): Use maybe version [-Wdeprecated-declarations]
         ctx = info[1]->ToObject();
                                 ^
make: *** [Release/obj.target/native/src/hashtable.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/travis/.nvm/versions/node/v10.15.3/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:189:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
gyp ERR! System Linux 4.4.0-101-generic
gyp ERR! command "/home/travis/.nvm/versions/node/v10.15.3/bin/node" "/home/travis/.nvm/versions/node/v10.15.3/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "build"
gyp ERR! cwd /home/travis/build/xyz/node_modules/hashtable-patch-valeriansaliou
gyp ERR! node -v v10.15.3
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-gyp configure build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.

Hello. What’s your compiler version?
--
Valerian Saliou
CTO at Crisp

On 22 Apr 2019, at 7:47 AM, Guido García<EMAIL_ADDRESS>wrote:
This is the error you get if you try to npm install fast-ratelimit on Travis
npm ci stdout:

<EMAIL_ADDRESS>install /home/travis/build/xyz/node_modules/hashtable-patch-valeriansaliou
node-gyp configure build
make: Entering directory /home/travis/build/xyz/node_modules/hashtable-patch-valeriansaliou/build'   CXX(target) Release/obj.target/native/src/hashtable.o make: Leaving directory /home/travis/build/xyz/node_modules/hashtable-patch-valeriansaliou/build'
lerna ERR! npm ci stderr:
In file included from ../src/hashtable.cpp:1:0:
../src/hashtable.h:6:64: error: missing binary operator before token "("
#if defined APPLE && defined __has_include && __has_include(<tr1/unordered_map>)
^
In file included from ../src/hashtable.h:15:0,
from ../src/hashtable.cpp:1:
../src/v8_value_hasher.h:7:64: error: missing binary operator before token "("
#if defined APPLE && defined __has_include && __has_include(<tr1/unordered_map>)
^
In file included from ../src/hashtable.h:15:0,
from ../src/hashtable.cpp:1:
../src/v8_value_hasher.h: In member function ‘bool v8_value_equal_to::operator()(CopyablePersistent*, CopyablePersistent*) const’:
../src/v8_value_hasher.h:43:24: warning: ‘bool v8::Value::Equals(v8::Localv8::Value) const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:2481): Use maybe version [-Wdeprecated-declarations]
if (a->Equals(b)) {          /* same as JS == */
^
../src/hashtable.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE HashTable::Constructor(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/hashtable.cpp:50:43: warning: ‘int32_t v8::Value::Int32Value() const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:2478): Use maybe version [-Wdeprecated-declarations]
int buckets = info[0]->Int32Value();
^
../src/hashtable.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE HashTable::Rehash(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/hashtable.cpp:231:42: warning: ‘int32_t v8::Value::Int32Value() const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:2478): Use maybe version [-Wdeprecated-declarations]
size_t buckets = info[0]->Int32Value();
^
../src/hashtable.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE HashTable::Reserve(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/hashtable.cpp:249:43: warning: ‘int32_t v8::Value::Int32Value() const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:2478): Use maybe version [-Wdeprecated-declarations]
size_t elements = info[0]->Int32Value();
^
../src/hashtable.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE HashTable::MaxLoadFactor(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/hashtable.cpp:266:39: warning: ‘double v8::Value::NumberValue() const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:2475): Use maybe version [-Wdeprecated-declarations]
factor = info[0]->NumberValue();
^
../src/hashtable.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE HashTable::ForEach(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/hashtable.cpp:289:33: warning: ‘v8::Localv8::Object v8::Value::ToObject() const’ is deprecated (declared at /home/travis/.node-gyp/10.15.3/include/node/v8.h:10046): Use maybe version [-Wdeprecated-declarations]
ctx = info[1]->ToObject();
^
make: *** [Release/obj.target/native/src/hashtable.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/travis/.nvm/versions/node/v10.15.3/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:189:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
gyp ERR! System Linux 4.4.0-101-generic
gyp ERR! command "/home/travis/.nvm/versions/node/v10.15.3/bin/node" "/home/travis/.nvm/versions/node/v10.15.3/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "build"
gyp ERR! cwd /home/travis/build/xyz/node_modules/hashtable-patch-valeriansaliou
gyp ERR! node -v v10.15.3
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node-gyp configure build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
Running on Ubuntu 14.04.5 LTS (kernel version: 4.4.0-101-generic)

Hello there! I've fixed that in v3.0.0, using the JS-native Map object, which has as well be measured in my tests to be faster anyway. This new version does not compile any dependencies anymore, fixing this issue.


Invalid id 261, maximum id range exceeded error in Forge 1.10

Received the following error when trying to create a new world from existing config files.
http://pastebin.com/raw/FgHZEmwY

Please dis-regard this ticket, I think it was generated due to corrupt config files.


Random behavior with text rendering

Usually, on the first load ( and sometimes even after that ) - the website is not using the "Inter" font-family and uses the fallback "sans-serif" to render the text. But when we reload the page - the issue gets resolved.
To replicate this issue, Load the website in incognito, and check the font-family:

Then reload the page, and check again:

I believe this is a @next/font issue, if that's the case others will be running into it, too


Revamping Question area

The current question areas are very dull. I want to make it attractive by changing its position and adding the like and dislike button along with the share and bookmark buttons.
I am a participant in GSSOC 2021. I want to contribute to this issue and work on the same. Please could you assign me this issue as a part of GSSOC 2021?
Thank you

Which question area are you talking about?

Sir I'm talking about this question area. I will be working on designing it in a better perspective as I mention above

@shairanshrawat I think there's a little confusion here: the area you are talking about contains the tip of the day, and we don't need further revamps in it's design :smile:
However, if you have any other ideas for the homepage or for the tip of the day, you are most welcome to work on those!


Update documentation

Adds XML documentation.

BTW - Doxygen found some issues; these were from running  build_doc.bat in the <src>/documentation directory.  I've attached output.
doxyout.txt

It appears doxygen does not handle <see langword="">. I'll replace these with something it supports.


"Checkout remote branch as local" action is lost

Now, I can't find such action in branch management sheet.
https://github.com/divmain/GitSavvy/blob/master/docs/branch_mgmt.md#checkout-remote-branch-as-local-o

Sublime Text 3, build 3126

Please read https://github.com/divmain/GitSavvy/blob/master/messages/2.15.0.txt
I have forgotten to update the view and docs. I will do it today.

So, how to create a new branch from develop, e.g, now? Strange changes...


Android 4.4 support?

I'm looking into cheap wrist Android phones, like the DM98  or LEM4, but most come only with Android 4.4.
What's requiring Android 5.0+ in POnewheel?

I bet you could spend a fair amount of time optimizing it for the cheaper phones with lower battery capacity and slower CPU. Neat idea though!

Thanks kwatkins! I don't have the phone yet though: was investigating before i pull the trigger...
Are you suggesting I another option, ebabel?
I've developed in many languages, Java included, but I've never worked with Android. Should I expect a lot of difficulty? How long to get from zero to successfully compiling an APK you guys think?

Yeah for sure, the difficulty isn't in making your first app, its more about supporting old phones with BLE, or optimizing performance/battery drain. To be honest, its hard to say how our app would do on those phones, but I like @kwatkins's optimism!

Android 4.4 doesn't support BLE at all. Doc link This is mandatory method for application and it was added from android 5.0 (sdk 21)
https://github.com/ponewheel/android-ponewheel/blob/0799bf50e5174cc2c3afbe47daee120c4c14393e/app/src/main/java/net/kwatts/powtools/util/BluetoothUtilImpl.java#L427-L432
think current code which exists in master branch will crash at run-time on android 4.4. Need to test this before release. And revert minSdk 19->21 if it is true.

@kwatkins @ebabel What do you think?

Sounds good to me.
On Sun, Jul 8, 2018, 6:46 AM Audrius Karosevicius<EMAIL_ADDRESS>wrote:

@kwatkins https://github.com/kwatkins @ebabel
https://github.com/ebabel What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ponewheel/android-ponewheel/issues/67#issuecomment-403288891,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0Lrf_gtepay7mD7GdGW9vGJjRXBF-Rks5uEg0XgaJpZM4TNwJ6
.

Thanks for looking into that @audkar. I'm all for sticking with 21


Do locale resolution in embedders

Internal: b/146064414
There are many internal issues/questions/confusion around how Flutter does locale resolution. While we provide a way to override our basic resolution algorithm, developers want resolution behavior that is consistent with the underlying platform which is very tricky to achieve with x-plat code.
I have talked to @GaryQian and @jason-simmons about this and we sketched out a plan to provide additional information from embedders on each platform to Dart code. Currently, embedders provide only the user select system locale (if exists). In addition, we propose that embedders provide:

The list of locales that the application supports.
The list of ordered locales that the system recommends (a strict subset of the above).

Today, #1 is specified in Dart. However, it is also duplicated in Info.plist file on iOS. We need to figure out a way to pass a list of supported locales to embedder at build time. This will ensure we have a single source of truth for supported locales. pubspec is the current proposed way.

go/flutter-embedder-localization is the internal doc

CC @shihaohong

I am tentatively marking this as critical. Our customers are rolling their own (imperfect) solutions as we speak to unblock their launches. The sooner we do this, the easier it will be to migrate them.

[ ] Framework-side work (exposing new API, modifying algorithm)
[ ] Engine-side work (passing the locales from platform channels to app startup, supported locales passing)
[ ] Android embedder resolution implementation
[ ] iOS embedder resolution implementation

Should I add macOS to that checklist, or was it omitted deliberately?

This should be supported for all embedders. Notes on go/flutter-embedder-localization mentions MacOS.

https://github.com/flutter/engine/pull/17755 Includes engine side work that passes a new localization message through to dart.

Design doc: go/flutter-embedder-localization

Bring iOS supported locales in sync with android's format: https://github.com/flutter/engine/pull/18379

Send platformResolved locales from iOS Embedder: https://github.com/flutter/engine/pull/18519

https://github.com/flutter/flutter/pull/56167 Uses a l10n.yaml file to define localization arb configs. We can consider also using this file to become the canonical place to define supported locales, and use the gen_l10n tool to generate the necessary assets for each embedder/framework.

Note that internally we don't (intend to) use #56167. Build system is different.

https://github.com/flutter/engine/pull/18645 Passes supported locales down from Dart to embedder via the Engine and uses embedder specific API to obtain locale resolution.

https://github.com/flutter/engine/pull/19136 Cleans up old/unused/obsolete API

Android-side locale resolution algorithm: https://github.com/flutter/engine/pull/19266

https://github.com/flutter/flutter/pull/58482 Exposes window.ComputePlatformResolvedLocale which may be used in the custom locale resolution callback as an extra factor to consider.
We do not yet use the platform resolved locale in the default algorithm. This change would be breaking and it is debatable if it is even better than the current Flutter one.

@GaryQian Can this be closed? Are there other remaining work items?

This is done for Android and iOS. Still pending Web and Desktop, however, it is unclear if this is even applicable to those platforms, so I will close this!
I believe the current web implementation is to return null as this is not an applicable operation

Locale support is absolutely relevant to desktop. Comments above said that macOS was explicitly in scope, for example.

https://github.com/flutter/engine/pull/19597 begins desktop embedder implementation

Per offline discussion, I misunderstood what this was covering exactly. Passing an ordered list is in scope for desktop (and not currently done), but I'm not sure if any of the desktop platforms need the custom resolution callback.

In that case, we can leave the entrypoint into desktop embedders, and if need be, implement custom resolution in the future. I'll file an issue to do so and close this one as the primary platforms that need this are done.


After the latest update cross-seed isn't honoring the original paths !!!

After the latest update i noticed that cross-seed torrents doesn't honor the paths from the existing torrents.
I've in the the default save path /data/torrents/tv and in that folder i've subfolders hd and uhd
cross seed should honor the original path like it used to !
Example: using the latest release.

as you can see the original is using /data/torrents/tv-hd/
and the cross seed is using the /data/torrents/tv/
switched back to  mmgoodnow/cross-seed:version-3.3.0
and it works like it should.

Hope this can be fixed in the next update.

Please comment on #74 with your findings


GQSP: Implement complementary polynomial computation

theorem 4 of https://arxiv.org/abs/2308.01501
Still some debugging left to do:

[x] Computed Q satisfies the definitional constraints, but still produces incorrect GQSP circuits
[x] computing a polynomial from roots is inaccurate even for degree 30 or so. TODO check if this causes a problem.

After some debugging, I realized why complex polynomials were producing incorrect circuits:
https://github.com/quantumlib/Qualtran/blob/7c9f3a0af0705e8bf72e0297c7cd2ce2c9b94628/qualtran/bloqs/generalized_qsp.py#L120
the $\phi_j$ are computed as $arg(a / b)$, which is numerically unstable around 0 - really small non-zero values can have arbitrary angles. This isn't an issue for polynomials with real coefficients though, as thetas are computed correctly.


Create .appveyor-build-tags

This config should be used by the webots-tags appveyor project.
It is similar to .appveyor-build-tags, except for the first line.

I already updated the "webots-tag" appveyor project accordingly to use this YML file.
👍

Is it normal that the Do not build on "Push" events settings is enabled in the project?

No. I fixed that. Thanks for pointing this out.


[Question]: How to read resolution from VideoGear?

After setting up a stream object from VideoGear, how can I get the height and width of a frame?
self.stream = VideoGear(source="xxx.mp4").start()

@3togo It is same as in OpenCV
A. Through stream global parameter:
# import required libraries
from vidgear.gears import CamGear
import cv2

# open any valid video stream(for e.g `myvideo.avi` file)
stream = CamGear(source="myvideo.avi").start()

# get whatever you want similar to as in OpenCV
width = stream.stream.get(cv2.CAP_PROP_FRAME_WIDTH )
height = stream.stream.get(cv2.CAP_PROP_FRAME_HEIGHT )
fps =  stream.stream.get(cv2.CAP_PROP_FPS)

# safely close video stream
stream.stop()

B. Through frame dimensions:
# import required libraries
from vidgear.gears import CamGear
import cv2

# open any valid video stream(for e.g `myvideo.avi` file)
stream = CamGear(source="myvideo.avi").start()

# read frames from stream
frame = stream.read()

# get resolution
(height, width) = frame.shape[:2]

# safely close video stream
stream.stop()

many thanks

width = stream.stream.get(cv2.CAP_PROP_FRAME_WIDTH ) <--- won't work
I can't find "get" in dir(stream.stream)
vidgear.version =  0.3.1
dir(stream.stream) =  ['_CamGear__logging', '_CamGear__queue', '_CamGear__stream_read', '_CamGear__terminate', '_CamGear__thread', '_CamGear__thread_timeout', '_CamGear__threaded_queue_mode', '_CamGear__update', 'CamGear__youtube_mode', 'class', 'delattr', 'dict', 'dir', 'doc', 'eq', 'format', 'ge', 'getattribute', 'getstate', 'gt', 'hash', 'init', 'init_subclass', 'le', 'lt', 'module', 'ne', 'new', 'reduce', 'reduce_ex', 'repr', 'setattr', 'sizeof', 'str', 'subclasshook', 'weakref', 'color_space', 'frame', 'framerate', 'read', 'start', 'stop', 'stream', 'ytv_metadata']
type(cap.stream) =  <class 'vidgear.gears.camgear.CamGear'>

the following shall work
height, width = stream.stream.frame.shape

width = stream.stream.get(cv2.CAP_PROP_FRAME_WIDTH ) <--- won't work

@3togo Yes for VideoGear API you need to access stream attribute within class as follows:
stream.stream.stream.get(cv2.CAP_PROP_FRAME_WIDTH)

many thanks


Display customer metadata in customer details modal

Problem
Users can set custom metadata on their customers, but we currently don't display this information anywhere in the UI.
This is what we currently display:

Solution
Using this metadata field on the customer object:

Display these fields at the bottom of the customer details modal: https://github.com/papercups-io/papercups/blob/master/assets/src/components/customers/CustomerDetailsModal.tsx#L22
Questions, or need help getting started?
Feel free to ask below, or ping us on Slack :)
(You can also check out our CONTRIBUTING.md)

Hi @reichert621, I would be happy to work on this one 🙂

thanks @lukewaring!

Hi @reichert621 I am interested to contribute to Papercups. Can you suggest or assign me some work to start contributing towards?

hey @sohamsshah -- this should have some good guidance :)
https://github.com/papercups-io/papercups/blob/master/CONTRIBUTING.md

@reichert621 Thank you! Looking forward to be a part of this!

Hi. I was just playing around, and thought I'd do this one since there has been a week without activity. @lukewaring I hope I'm not intruding, and if you have made something more elegant, you can tell me and open a PR 🙂.
My PR is here #288


header manipulation in request interceptors

In the previous version, we couldn't have interceptors which manipulated headers of HTTP requests. I just added a 'headers' element to the config of the httpInterceptors' requests. With this, manipulation of headers is possible in the request interceptors.

Hi @masious could you add some unit tests to cover these scenarios? Thanks!

Hi,
What happened to this pull request? Will it ever be merged or is it declined?

Hi @atomcat1978 . The creator of the pull request never responded and nobody else in the community has brought this feature up before. Perhaps this needs to be revisited.

The functionality in this PR has been covered in the latest commit
and published in version 0.8.0


create_picture_plugin incompatible with djangocms-picture 2+

Hi,
according to https://github.com/django-cms/djangocms-picture/blob/master/CHANGELOG.rst#200-2016-09-08 djangocms-picture (specifically "Migrate model field image to FilerImageField and renamed to picture") I assume the current create_picture_plugin implementation does not work properly with djangocms-picture 2.0.0 or higher.
The current implementation sets pic.image = path but would need to set pic.picture = some_FilerImage_instance I assume. Do I miss something here or is my observation valid? If my observation is valid, is there interest in fixing this? If so I would create a pull request then.
Greetings

It would be great if you could fix that issue!

@leture Can I still interest you in crating this Pull Request? Would be awesome!

@fsbraun Sorry for the delay but I finally found the time to do it :-)


Add codebuild pipeline for eks-d

What would you like to be added:
Currently we do all builds via prow, pre and postsubmit.  We should consider adding a codebuild pipeline similar to eks-anywhere to support additional build options.
Why is this needed:
To support internal customers who require builds of EKS-D

@jaxesn What are the additional build options we're looking to support, or would this replace Prow with codebuild?

Updated description to answer my question.

Done as part of the Golang pipeline project.


Activating Windows Feature 'NET-Framework-Features' fails on Windows 2022

Description
Noticed today that building Windows 2022 image on main branch (commit: 1bbdd25a22dd003e3b720c77de25bb44ece8bc0e) is failing when trying to activate the NET-Framework-Features.
Log:
    vhd: Activating Windows Feature 'NET-Framework-Features'...
==> vhd: Install-WindowsFeature : The request to add or remove features on the specified server failed.
==> vhd: Installation of one or more roles, role services, or features failed. Error: 0x800f0950
==> vhd: At C:\Windows\Temp\script-634fff5a-37f1-8382-8f7c-bfbad1c37709.ps1:16 char:19
==> vhd: +         $result = Install-WindowsFeature @Arguments
==> vhd: +                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
==> vhd:     + CategoryInfo          : InvalidOperation: (@{Vhd=; Credent...Name=localhost}:PSObject) [Install-WindowsFeature],
==> vhd:     Exception
==> vhd:     + FullyQualifiedErrorId : DISMAPI_Error__Failed_To_Enable_Updates,Microsoft.Windows.ServerManager.Commands.AddWind
==> vhd:    owsFeatureCommand
==> vhd: Failed to activate Windows Feature 'NET-Framework-Features'
==> vhd: At C:\Windows\Temp\script-634fff5a-37f1-8382-8f7c-bfbad1c37709.ps1:24 char:9
==> vhd: +         throw "Failed to activate Windows Feature '$($feature.name)'"
==> vhd: +         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
==> vhd:     + CategoryInfo          : OperationStopped: (Failed to activ...ework-Features':String) [], RuntimeException
==> vhd:     + FullyQualifiedErrorId : Failed to activate Windows Feature 'NET-Framework-Features'

This is my first build of Windows 2022 image for this week. Last week it was working without issues - last build done, last week, was on Friday, 2022-10-14, on main branch  (commit: ac65b549ac1094005080fe0c0104376308940d1e).
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
We run packer build on custom VM.
main branch - commit: 1bbdd25a22dd003e3b720c77de25bb44ece8bc0e
Is it regression?
yes
Expected behavior
Activating Windows Feature NET-Framework-Features should succeed.
Actual behavior
Activating Windows Feature NET-Framework-Features fails.
Repro steps
Run Windows 2022 build.

Hello @manitua.
Windows Server 2022(20348.1131.221014) Azure image is broken. As a workaround you can rollback image version to "image_version": "20348.1129.221007" - https://github.com/al-cheb/virtual-environments/commit/408d5a88f94396fd3d28ed53aa2326a1248c25cd
Publisher               : MicrosoftWindowsServer
Offer                   : WindowsServer
Sku                     : 2022-datacenter
Version                 : latest
ExactVersion            : 20348.1131.221014

Hi @al-cheb,
Sorry for late reply - I have applied rollback workaround yesterday, it built runner image flawlessly :). Thank you!
I hope Microsoft will fix this in next Azure datacenter version of WindowsServer 2022.

This is still in issue with current build. Setting "image_version" to "20348.1129.221007" didn't work for me.

I can confirm this is fixed now with latest commit

Hey Y'all, some individuals may use our their own packer.json files that closely mimic the main branch but offer customizations such as private networking, shared image gallery, etc...
Make sure you don't miss this in the Packer builders section for Windows 22.
        "image_version": "20348.1129.221007",

Example a custom Packer Json Builders Section
 "builders": [{
        "name": "vhd",
        "azure_tags": {
           ...
        },
        "managed_image_name": "{{user `capture_name_prefix`}}",
        "managed_image_resource_group_name": "{{user `resource_group`}}",
        "type": "azure-arm",
        "client_id": "{{user `client_id`}}",
        "client_secret": "{{user `client_secret`}}",
        "subscription_id": "{{user `subscription_id`}}",
        "object_id": "{{user `object_id`}}",
        "tenant_id": "{{user `tenant_id`}}",
        "os_disk_size_gb": "256",
        "location": "{{user `location`}}",
        "vm_size": "{{user `vm_size`}}",
        "shared_image_gallery_destination": {
           ...
        },
        "shared_image_gallery_timeout": "8h",
        "temp_resource_group_name": "{{user `temp_resource_group_name`}}",
        "virtual_network_name": "{{user `virtual_network_name`}}",
        "virtual_network_resource_group_name": "{{user `virtual_network_resource_group_name`}}",
        "virtual_network_subnet_name": "{{user `virtual_network_subnet_name`}}",
        "private_virtual_network_with_public_ip": "{{user `private_virtual_network_with_public_ip`}}",
        "allowed_inbound_ip_addresses": "{{user `allowed_inbound_ip_addresses`}}",
        "os_type": "Windows",
        "image_publisher": "MicrosoftWindowsServer",
        "image_offer": "WindowsServer",
        "image_sku": "2022-Datacenter",
        "image_version": "20348.1129.221007",
        "communicator": "winrm",
        "winrm_use_ssl": "true",
        "winrm_username": "REDACTED"
    }],

@manitua, @conradj3 , @fady-azmy-msft - the new image version has been published. I have reverted image_version in this https://github.com/actions/runner-images/pull/6545 PR.


Login after verify

How do I login a user if they have verified their account?

Hi @advany,
could you explain it a little more?
In case you're using the verifyEmail route, the user should get logged in straigth after a successful verification.
Here is the call made to Accounts.verifyEmail for which you can read the official docs here

@splendido I saw that somehow the routes don't work.
I have them in my libs/routes.js
AccountsTemplates.configureRoute('signUp');
AccountsTemplates.configureRoute('signIn');
AccountsTemplates.configureRoute('changePwd');
AccountsTemplates.configureRoute('verifyEmail');
AccountsTemplates.configureRoute('forgotPwd');
AccountsTemplates.configureRoute('resetPwd');
This should be enough to verify the user right?

Found the problem. Somehow the url returned by Accounts.emailTemplates.resetPassword.html has an extra hashtag

See #266


typo fixing

Current coverage is 61.24%

Merging #563 into master will not affect coverage as of c37f0fc

@@            master    #563   diff @@
======================================
  Files           58      58
  Stmts         9201    9201
  Branches      1482    1482
  Methods          0       0
======================================
  Hit           5635    5635
  Partial        496     496
  Missed        3070    3070

Review entire Coverage Diff as of c37f0fc

Powered by Codecov. Updated on successful CI builds.

thanks!


[Index] Only index system modules in the SDK, not local ones

Indexing a module from the swiftinterface puts the swiftinterface-sourced swiftmodule in the cache. Subsequent builds don't see the adjacent swiftmodule file and use the cached one. This can break test clients that need the adjacent swiftmodule information. To avoid this scenario and get a more sound behavior, ensure that we only index system modules in the SDK, not local versions.
rdar://102207620

@swift-ci Please smoke test

Debugging test on Linux and Windows.
@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test Windows

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test macOS

Added a variable to make future changes to what we consider a distributed module cleaner.
@swift-ci Please smoke test

@swift-ci Please smoke test


:question: Add open and closed results toggle

Description
Add an on & off toggle to filter the results by open & closed pharmacies.
Related Issue

Motivation and Context

Reduce the number of people not finding open pharmacy information on evenings and weekends
Checklist

[ ] An ADR
[ ] New and/or updated tests
[x] Changes log in CHANGELOG

Fixed the version numbers & white space

This comment seems to have disappeared...

The version number in package.json needs reverting too please.


[Feature Request] Scan from file

Sometimes the QR code is not in person, but on the device itself.
It would be nice to have a config option to scann a file

Hi @Doomsdayrs, thanks for reaching out. Currently the focus of the library is the camera integration. But I will see if I can add some way to scan files in the future.

We can use InputImage.fromFilePath() to create an InputImage process it by using BarcodeScanner.

So, in QRCodeAnalyzer.kt there is a call to pass the captured image to the analysis engine:
barcodeScanner.process(imageProxy.toInputImage())
One might need to pass an image to a similar MLKit call in your own workflow (wherever the on-device image is sourced...)
I get a healthy part of the value of quickie is the proper MLKit configuration, so one could also explore reusing or exposing the ImageAnalysis of the library for a way to make this call yourself in your own code?
Alternatively, if you forked, one could create or extend a way to attach an image to an analyzer so it could be passed into the quickie image analysis object in QRScannerActivity.kt

hi, is there any updates?

hi, is there any updates?

Hi and sorry for not giving any updates about this feature request.🙏
I actually started implementing such a feature on a local branch, but it did not went well and felt kind of wrong for this library. The focus of quickie is about an easy integration with the camera and therefore UI focused. Calling native filepicker and sending the file uri to the scanner would require this library to decouple the barcode scanner from CameraX (which is currently not the case).
The part of the code which handles the ML Kit barcode scanner is honestly pretty small. So I would actually advice you to just follow the documentation about scanning files: Using a file URI
I am sorry but because of these reasons I will reject this feature request.😞


Take down Selenium Guidebook from Drip communication

When subscribing to Elemental Selenium there's a banner promoting Selenium guide book, which is not useful anymore.
This task is to take this banner out of the subscription confirmation.


Add time range to datetime filter on Dataframe Transformer

Description
Currently there's only date range of datetime filter on Transformer table, would be helpful if time range also be available as part of the datetime filter

Suggested solution
Sample datetime select widget as on Kibana

Alternative
No response
Additional context
No response

I am working on this


[client-keystone-auth] Refactor identity components to improve code climate

What this PR does / why we need it:
Refactor identity to make golangci-lint happy.
This PR includes the components client-keystone-auth and
k8s-keystone-auth, which both use pkg/identity.
Which issue this PR fixes(if applicable):
Relates to #1883
Special notes for reviewers:

Release note:

NONE

/lgtm

/approve


Fixed minor translation issues in zh_Hans for auth

Fixed zh_Hans translation for the invalid username&password message

Thanks for the report, however, translations are handled at Transifex.


Create dataset openiti

uid: openiti
type: primary
description:

name: OpenITI
description: A corpus of Arabic texts that collected from Islamic books from different websites.
homepage: https://zenodo.org/record/4075046
validated: True

languages:

language_names:

Arabic
ar-MSA

language_comments:
language_locations:

Southern Asia
Western Europe
Northern America
Pakistan
Austria
Germany
United States of America

validated: False

custodian:

name: Matthew Thomas Miller (University of Maryland, College Park), Maxim G. Romanov (University of Vienna), Sarah Bowen Savant (Aga Khan University—ISMC, London).
in_catalogue:
type: A university or research institution
location: United States of America
contact_name:
contact_email:
contact_submitter: False
additional: https://zenodo.org/record/4075046#.YaE8X7tRXEy
validated: False

availability:

procurement:

for_download: Yes - it has a direct download link or links
download_url: https://zenodo.org/record/4075046/files/OpenITI-v2020.2.3.zip?download=1
download_email:

licensing:

has_licenses: Yes
license_text: By exercising the Licensed Rights (defined below), You accept and agree to be bound by the terms and conditions of this Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International Public License ("Public License"). To the extent this Public License may be interpreted as a contract, You are granted the Licensed Rights in consideration of Your acceptance of these terms and conditions, and the Licensor grants You such rights in consideration of benefits the Licensor receives from making the Licensed Material available under these terms and conditions.
license_properties:

non-commercial use

license_list:

cc-by-nc-sa-4.0: Creative Commons Attribution Non Commercial Share Alike 4.0 International

pii:

has_pii: Unclear
generic_pii_likely:
generic_pii_list:
numeric_pii_likely:
numeric_pii_list:
sensitive_pii_likely:
sensitive_pii_list:
no_pii_justification_class: general knowledge not written by or referring to private persons
no_pii_justification_text:

validated: False

source_category:

category_type: collection
category_web:
category_media: books/book publisher
validated: False

media:

category:

text

text_format:

.CSV
.TXT

audiovisual_format:
image_format:
database_format:

.ZIP

text_is_transcribed: No
instance_type: book
instance_count:
instance_size:
validated: False

fname: openiti.json

DONE: https://huggingface.co/datasets/bigscience-catalogue-data/lm_ar_openiti
Sample:
{'text': 'البحر : وافر تام 1'}

https://huggingface.co/datasets/bigscience-catalogue-lm-data/lm_ar_openiti


Add GOMEMLIMIT envvar in our Helm charts & Armada Operator for Golang components

GOMEMLIMIT was introduced in go1.19 and it can increase reliability of Golang apps.
More info here - https://weaviate.io/blog/gomemlimit-a-game-changer-for-high-memory-applications
We should add it in our Helm charts and make it equal to the resource limits.
Armada Operator can handle this scenario a lot easier because GOMEMLIMIT expects a GiB (MiB, KiB...) format while Kubernetes uses the Gi, Mi, Ki... format
┆Issue is synchronized with this Jira Task by Unito

/assign


removed trailing commas in package json

npm couldn't handle the package json due to training commas. the json should now be valid, based on an online json syntax checker
partially resolves #71

forgot to mention, i tested with my own fork. this now works with npm install and the primelocale files show up in node_modules

nice!!!!


SO name is too volatile

Describe the bug
Building the library on Linux results in a library called libg3log-2.1.0-20 or similar. The problem is that every part of that is part of the SO name. This means that any change to the code at all results in a library that will not link with the previous library.
The result is that it is all but impossible to create binary packages for g3log. It is not feasible to distribute g3log in binary form over time.
To Reproduce

Build g3log on Linux
Run objdump -x libg3log.so | grep SONAME

The result is the entire version string.
Additional context
Traditionally, the SONAME should only change when introducing non-backwards compatible changes to the ABI. It should, likely, only include the major version number.
I've submitted a pull request #402 with precisely this change.

Hmm. This is the first time I have ever heard about this. I know for a fact that g3log has been packaged and distributed by literally hundreds of companies to date.  I'm not saying you are wrong, I'm saying I've never heard about this before and apparently other folks haven't found it an issue worth mentioning.
AFAIK the version number with Major.Minor.BuildVersion is the standard versioning recommendation
You should end up with
libg3log.so
libg3log-2.1.0-20.so which links to the above one.
Please provide some reference as to what the versioning build should be to back up the change.
Please also see the note I added as I don't find any reference so the SOFT_VERSION in Cmake documentation.

The reason you did not find SOFT_VERSION is that I made it up. I didn't want to completely eliminate the versioning in place. I may have missed something obvious.

SONAME is used to indicate ABI backwards compatibility. It should only be bumped when a change is introduce that prevents applications compiled with an old version of the library from working if linked with a newer version of the library.
https://en.wikipedia.org/wiki/Soname
It is entirely possible to use the SONAME as a full version information. The practical upshot of doing so is that applications will need to be compiled with the specific version they will later use at runtime. Even a minor deviation will result in linking error.
This makes it completely impractical to package a binary form of the library. What's the point, if I any upgrade to the library requires I recompile all the applications?
I believe that the linking scheme you are referring to is the one used by libtool. Libtool, indeed, uses a three number versioning scheme, and creates an SO with all numbers present in the file name, using symbolic links to bridge the difference. What I believe you are missing, however, is that not all three numbers are used in the SONAME.
https://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html#Libtool-versioning
I've created a project that demonstrates how this works.
So if I'm giving libtool the version info 12:57:3 (ABI version 12, backwards compatible 3 versions, this is the 57th iteration inside this version), libtool will create the following files:
-rw-r--r-- 1 shachar shachar 2718 Apr  5 07:27 libsoname.a
-rwxr-xr-x 1 shachar shachar  948 Apr  5 07:27 libsoname.la
lrwxrwxrwx 1 shachar shachar   19 Apr  5 07:27 libsoname.so -> libsoname.so.9.3.57
lrwxrwxrwx 1 shachar shachar   19 Apr  5 07:27 libsoname.so.9 -> libsoname.so.9.3.57
-rwxr-xr-x 1 shachar shachar 8320 Apr  5 07:27 libsoname.so.9.3.57

The SONAME, however, is 9:
$ objdump -x libsoname.so | grep SONAME
  SONAME               libsoname.so.9

To facilitate this, libtool generates a symbolic link from libsoname.so.9 to libsoname.so.9.3.57, which is the only link that matters. The .so link is only needed when I link against the library (i.e. - when I compile). In Debian, the .so.9 and .so.9.3.57 files would be packaged in a deb called libsoname9 (the package's name contains the SONAME, so that multiple versions of the ABI can be installed side by side). The .so file is packaged, along with the .a file and the .la files, in libsoname-dev. This one does not contain the SONAME in the package name, as you only really want to link against the latest version of the library.

I might be missing something obvious here.
I believe what we should strive for is the
VERSION being the full complete version number (as before).
The SOVERSION howevever should only be the MAJOR version part.
I.e. See also https://github.com/KjellKod/g3log/blob/c0ae589024e1f1fd851689c6825bbca48a097508/Build.cmake which is what I think is the SOVERSION line that is causing you this issue.
I think this blog explained the differences well: https://pusling.com/blog/?p=352

I think that change ^ would give you exactly what you need and this project would be more compliment with the gist of how VERSION and SOVERSION should be used

Sounds right. So a better change would be to set SOVERSION to MAJOR_VERSION, and leave VERSION as it is today. Do you need me to submit a revised PR?

Please do
Sent from my iPhone

On Apr 6, 2021, at 10:58 PM, Shachar Shemesh @.***> wrote:

Sounds right. So a better change would be to set SOVERSION to MAJOR_VERSION, and leave VERSION as it is today. Do you need me to submit a revised PR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

fully corrected in https://github.com/KjellKod/g3log/pull/404


how to add some class in the inline svg?

Hi,
I find the inputs of options don't have a way to modify style or class of insert svg node. this is intentional or ?

This is purely meant for inserting the SVG directly into the DOM. If the original SVG has styles or classes already, then that's great, but otherwise, you'll need to edit the original SVG.

I think the sense purely is very nice, but, I think if we have a interface to modify it is better. because svg element is very flexible at website, we can do more thing by the dynamic styles.

Sorry, that seems beyond the scope of what this directive is meant for. You can try using your own function to mutate the SVG using the onSVGInserted output callback.


feature: Keras BaseWandbEvalCallback for logging model predictions as W&B tables

Fixes WB-NNNN
Fixes #NNNN
Description
co-author: @soumik12345
This PR introduces BaseWandbEvalCallback  to be used as the base Keras callback as referenced in https://github.com/wandb/wandb/issues/4195.
This callback can be inherited to implement something like WandbClfEvalCallback (refer to test_keras_eval_tables_builder.py) for the classification task. This can also be used for object detection or segmentation tasks (we will create examples for them too).
Check out the data_table and the pred table logged.
Testing
This PR was tested manually, and we have added a basic yea test as well.
Checklist

Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

Hi @ayulockin, is it possible for us to log the evaluation tables directly on the workspace similar to this dashboard?

Hey @soumik12345, I tried this, but it didn't work correctly. Maybe we can have a quick sync on this.


Update phoenix_html version to 4.0

There is a new version of phoenix_html, but it will conflict with ex_fontawesome, can we update this library to that new version?

Hi @miguel-s  any updates on this ? 🙏