Internal Server Error's caused by missing module

Have been using linkding w/o issue for months now, and after seeing the recent SSO changes decided to update to the latest docker version. Unfortunately I can't get things to work now, getting "Internal Server Error" on every page load attempt, looking at the container logs I see this in the beginning when building a new container from the sissbruecker/linkding:latest image:
Traceback (most recent call last):
  File "/etc/linkding/manage.py", line 21, in <module>
    main()
  File "/etc/linkding/manage.py", line 17, in main
    execute_from_command_line(sys.argv)
  File "/opt/venv/lib/python3.10/site-packages/django/core/management/__init__.py", line 442, in execute_from_command_line
    utility.execute()
  File "/opt/venv/lib/python3.10/site-packages/django/core/management/__init__.py", line 416, in execute
    django.setup()
  File "/opt/venv/lib/python3.10/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/opt/venv/lib/python3.10/site-packages/django/apps/registry.py", line 91, in populate
    app_config = AppConfig.create(entry)
  File "/opt/venv/lib/python3.10/site-packages/django/apps/config.py", line 193, in create
    import_module(entry)
  File "/usr/local/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1004, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'django_generate_secret_key'

Health checks look like this:
[pid: 24|app: -1|req: -1/9] <IP_ADDRESS> () {28 vars in 306 bytes} [Sun Mar 17 01:41:45 2024] GET /health => generated 21 bytes in 0 msecs (HTTP/1.1 500) 2 headers in 83 bytes (0 switches on core 0)
--- no python application found, check your startup logs for errors ---

Any idea what I might be messing up here? ':D

I just gave it a try, and creating a new container works for me.
Looking at the logs it breaks when initializing the INSTALLED_APPS, which references the django_generate_secret_key library, which is not installed. That should not happen, the library has been removed, and the INSTALLED_APPS have been updated in the same commit: https://github.com/sissbruecker/linkding/commit/38204c87cf6fdd3d871a115d9786db73b17d1be6
Do you have any customizations for the container, like mounting a custom settings file? Something is causing the library to still be listed in your settings.

Closing as stale


Move finding toc.yml files logic to async method in Books

This addresses #6605.
Moved finding toc.yml files and setting bookOpened logic to async method to speed up extension startup.
Also found a module, fast-glob, that speeds up finding files. Fast-glob contains an option called 'deep' for limiting the number of subdirectories to search in. What would be a good number to limit to?

@lucyzhang929 should we also cut off the directory recursion at some depth?  If I open the root directory or a huge code base list SSMS it seems too much to scan the entire directory tree.
If not, I wonder if we should provide an option to turn off the TOC feature.  I think most users won't use this feature so I don't like the idea of this running all the time potentially consuming quite a bit of resources.

Yes, the module I'm using has an option called 'deep' that can limit the depth of directories to search. What do you think is a good number to cut the search off at?

@lucyzhang929 I would ask @kevcunnane or @ronychatterjee to clarify the intended use-case.  But I would think ~5 levels of recursion would be enough most the time IMO.  Ideally, you could you use logic to say something like "go n additional levels beyond the last found .TOC in each path" so you would keep crawling as long as you were finding more content.  Though since that may be a bit complex I would image some reasonably small N would handle the common cases we're trying to address which a huge perf hit.  Since you're making this async the depth could probably be a little larger than 5 without too much noticeable perf hit if necessary.

Just to chime in - 5 levels to me seems reasonable and then I would expose that as a config option so users can set it deeper if they want (with appropriate warning about possible perf hit).


writeAndFlush() doesn's work.

Expected behavior
I want to send a large Json (about 150kb) string to server_B.
My code is in server_C.
Actual behavior
It doesn's work.
logs for server_B
11:08:20.822 [nioEventLoopGroup-11-1] DEBUG io.netty.buffer.PoolThreadCache - Freed 1 thread-local buffer(s) from thread: nioEventLoopGroup-11-1
11:10:17.862 [nioEventLoopGroup-3-4] DEBUG io.netty.channel.nio.NioEventLoop - Selector.select() returned prematurely 3 times in a row for Selector io.netty.channel.nio.SelectedSelectionKeySetSelector@fe21d88.
MsgServer:/<IP_ADDRESS>:39954在线
MsgServer:/<IP_ADDRESS>:39954掉线
11:11:07.204 [nioEventLoopGroup-3-2] DEBUG io.netty.channel.nio.NioEventLoop - Selector.select() returned prematurely 4 times in a row for Selector io.netty.channel.nio.SelectedSelectionKeySetSelector@647f9c1d.
Steps to reproduce

In the code, the response can print,but the message cannot be sent.
Netty version
Netty 4.1.12.Final
JVM version
Jdk 1.8
OS version
CentOs 6.5

You are calling writeAndFlush and then immediately closing the channel (ctx.close()). You are also closing the channel after your write completes (.addListener(ChannelFutureListener.CLOSE)) ... I'm not sure what you are trying to do but waiting until the write completes typically makes more sense.
If you think there are more issues please provide a complete reproducer (that we can be run to reproduce the issue).

Thank you.
The problem is what you said. I solved.


The list of opportunities should support pagination

We currently fetch all available opportunities and their associated projects, this certainly won't scale.  To accomplish this we should implement basic pagination.

[ ] UI Changes
[ ] API Changes (#25)

I can take this one tonight and drop in scrivener if you want @doomspork

I want work on this.

@m13m myself and @sliu27 are currently working on this feature right now, but there is a lot more to do as well. I will ping you in the PR when we open it here in a moment.

@m13m would you be interested in working on #22 or #23?

that would be cool yes I'm interested working on #22

@m13m take a peek at what @ybur-yug and @sliu27 are doing with #25 and you should be able to get started.  If you want to fork and get a branch up, we can continue the discussion in #22 👍

@m13m we're also available in Elixir Slack's #elixirschool channel 😀

Re-opening for the UI portion.

Working on this. PR to follow shortly.


Support imcomplement for color/transparent images. Fixes #461.

See #461. CC @ararslan.

Coverage increased (+0.03%) to 75.318% when pulling b66fd7d4fe7aaa730e1b945b76f4e730a9d44348 on teh/imcomplement into e6af9e1497bad82306383d3a5035b5f4d2c53acf on master.


As a server admin, I want to be able to remove nodes and stop sharing with them.

For submission: verified. (We can remove them, but it does nothing because we don't even use them when we have them.

Definitely need to be able to do something with them


[Doc] Update "New Server" creation wizard docs

Description:
"server runtime environment" element is not available in EI Tooling Under "New Server" wizard. Need to update images of the link,
https://docs.wso2.com/display/EI600/Running+WSO2+Enterprise+Integrator+via+Tooling
according to the current pack.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Updated the "Running WSO2 Enterprise Integrator via Tooling" section in [1] with the correct instructions and screenshots.
[1] https://docs.wso2.com/display/EI6xx/Running+the+Product#RunningtheProduct-RunningWSO2EnterpriseIntegratorviaTooling


edit person urls

As a content editor, I want to add URLs to a person record so I can document the person's wikipedia URL or other relevant websites.

Hi! I added a URL to Richard Arlington's page to see if I could do that, but I'm having trouble deleting that URL now -- it seems like the only option it gives me is to delete all of Arlington, not just the URL. If I try to delete it and save again, it says that I've left the URL spot blank (which I did, since I got rid of it).

Hi @clmahoney. This one is a bit of a quirk in Django/Grappelli inlines.hted

I've highlighted the delete 'x' in an outline. Click that to mark that you want to delete the url, and then 'save' on the person record. It should then delete the any of them.
Sorry for any confusion on this.

When I do that I get this message and it worries me that I'm going to delete the whole thing:

But is that right?

Oh nevermind, I figured it out! I need to press the X and then save and continue!


Dynamic Routes

Changes in this PR

Screenshots of UI changes

Before
After
Next steps

 Dynamic routes

@peterdavidhamilton @EdwinKruglov @PiperS52
I've removed the dynamically generated routes block and replaced with a generic routing to Pages
I assume this will fix the issue we were seeing in docker!


Integrating Ollama with Microsoft Word

Thank you for this repo. I have integrated Ollama with Microsoft Word through a local Word Add-in (GPTLocalhost). It would be great if this Word Add-in can be listed in the following so that users have another way to utilize Ollama. Thank you for your consideration.

Community Integrations > Web & Desktop

Hey thank you for this! I love the work but is there a free tier for users to get started? I want to make sure this is a place for developers to list their projects.

Thank you for your interest. Currently, users can cancel their subscription within the 10-day trial period and re-subscribe to start another 10-day trial for free. Conceptually it's like a free tier. I may patch it in the future. The reason behind is that I'm aiming for a more self-sustaining business model, which would allow me to focus more on the product toward higher ends such as agents.


Add spotify default search

Hello, I came to ask for a new addition that you could put.
Add to music by default which could come from Spotify, I don't know if it's possible for you, thank you for your attention, have a good day.
Sincerely

Please open a forum on discord

Hello, can you tell me or create a forum because I don't quite understand the answer?

discord.gg/HV59Z3zEjt


Adding a Linter

Should we add a linter to Geocoder? (Raised by @randoum in #1494.)

With regard to Rubocop (and linters generally), in theory, they're great. However, Rubocop is going to find thousands of tiny offenses, and it's going to be tempting to replace every instance of unnecessary double quotes with single quotes, for example. While these changes do improve the code a tiny bit, they also pollute the Git history. IMO, in the case of Geocoder, the tradeoff isn't worth it. We need git blame to be as quick and useful as possible when tracking down bugs. (See also the reasons Rails won't merge cosmetic changes.)
That being said, it would be great to force all future PRs through a linter so we stop adding unnecessary double quotes (and lots of other sub-optimal code) to the repo. I'm certainly open to that.

Those points make perfect sense. And Godfrey's message you linked too.
Now I don't believe it would be possible to instruct Rubocop to work only on the modified lines of a PR. Or do you know a way?
Rubocop would search for offenses in the whole project. At best, it might be possible to make it run only on the modified files, but even though it will make lots of noise and confuse contributors.
It's all or nothing :) Take it or leave it! Ahahah, just kidding.
But yeah, I understand that it would be a mess to add a linter now.

I don't know a way, unfortunately. I was hoping you did. :)
I'm going to close this issue for now, but if anyone can suggest a helpful way of adding a linter, I'm open to the idea.

As an alternative solution, we could ignore the commit from git blame: https://akrabat.com/ignoring-revisions-with-git-blame/
I could fork and test that so we can see if it works as expected.

Very interesting. I had no idea that feature existed. Yes, why don't you go ahead and try that?

After few tries, I confirm that there is no way to ignore commit globally, only locally. Bummer.

@randoum Darn, that seemed promising. Well, thanks for looking into it.

While I agree with the idea of generally not merging cosmetic PRs, I don't think that necessarily needs to block any introduction of a linter.
Any project will need to make larger code base changes now and then. For example, when updating to support a new version of ruby.
 What chancancode talked about in the issue quoted above, is that they cannot regularly merge cosmetic changes.
If you look at the rails commit history there are many instances of larger refactoring or changes. For example this one that enables a few rubocop checks:
https://github.com/rails/rails/pull/32381/files
So in short, I wouldn't shy away from adding a linter and (when doing so) making a bunch of changes to the repo (I'd probably group them in multiple commits though, one per cop, at least the ones covering many files).

All of this said, rubocop has a functionality where you can run it on the current code base, and it will create a rubocop_todo.yml file, with all the current "errors". Basically grandfathering in all the past sins. Which is what you discussed above, in https://github.com/alexreisner/geocoder/issues/1496#issuecomment-797449195.
With this mode, you won't have to make any changes to existing code base, but would still help for new code (with some caveates).

Thanks @sandstrom for the thoughtful input. That all makes a lot of sense. I didn't know about the rubocop_todo file, and I think that's a great option. I'm going to re-open this for more thought/discussion.


Calculate md5 from struct

Toward https://github.com/giantswarm/giantswarm/issues/11337
Fixing helm 3 supported version, and later I would apply same to 0.13.x.

@tomahawk28 I like the direction but please verify it works with the problem data. This PR may help https://github.com/giantswarm/installations/pull/1278.

@giantswarm/team-batman-engineers Can we go with this?


Add syntax highlighting to Git graph output and clear selection

This PR adds syntax highlighting to graph output and removes selection.
I am not a ST3 developer so please correct me if I made any mistakes.

Credit: Inspired by https://github.com/chancancode/sublime-text-2-git

Thanks for this!  Just a couple of comments, and I'll merge this in.

Implemented your comments.
BTW, I noticed that some themes (one of my favourites - Tomorrow)  put constant.other together with regular foreground which means the branch names won't be different from foreground colour.
Where do you think the problem lies - should the graph use some other colour for branch names or should I turn to theme editor for a fix?

GitHub is showing a conflict and disabling Merge button, but I'm not sure where the conflict is.  I'll pull down this branch and merge into master manually.
Wrt the coloring, I'm not 100% sure of the best approach.  I've only been checking against Monokai, so this may need to be addressed broader than here in this view.  If you have time, would you mind opening a ticket with screenshots of the places where this is a concern?

Relates to #13.


[FEATURE] Add a new-line linter in the current CI workflow

Is your feature request related to a problem?
Coming from https://github.com/opensearch-project/OpenSearch/issues/2857. Add a new-line linter to make sure all files end with a single newline. This is a POSIX standard, read more https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
What solution would you like?
Can use https://github.com/fernandrone/linelint/releases for the workflow.
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.

I don't like that the linter complains about it but doesn't fix it.  Adding the line to spotless as suggested above would fix it (and also fail it on spotless check but with a more helpful message how to fix!)


[CMake] find_package() won't find packages installed via vcpkg

Apparently it's not as straightforward to use vcpkg-installed dependencies in a CMake project as the documentation suggests. I can't get find_package detect a vcpkg-installed dependency, it always fails with an error message like this:
  Could not find a package configuration file provided by "FFTW3" with any of
See also "D:/a/vcpkg-cmake-example/vcpkg-cmake-example/build/CMakeFiles/CMakeOutput.log".
  the following names:

    FFTW3Config.cmake
    fftw3-config.cmake

For demonstration purposes I've set up a minimal example repository here: https://github.com/Holzhaus/vcpkg-cmake-example
Here's the complete CMakeLists.txt for the project:
cmake_minimum_required(VERSION 3.18)
project(example)

find_package(FFTW3 CONFIG REQUIRED)

add_executable(example src/example.cpp)
target_link_libraries(example PRIVATE FFTW3::fftw3)

And here's the windows batch file that first installs the dependency and then builds the project:
git clone --depth=1 https://github.com/microsoft/vcpkg.git
call vcpkg\bootstrap-vcpkg.bat
.\vcpkg\vcpkg install fftw3:x64-windows-static
mkdir build
cd build
cmake -DCMAKE_TOOLCHAIN_FILE=..\vcpkg\scripts\buildsystems\vcpkg.cmake ..
cmake --build .

It always fails: https://github.com/Holzhaus/vcpkg-cmake-example/runs/1639882790?check_suite_focus=true#step:4:278
Is there a working example that uses vcpkg with a CMake project? I can't believe that this is such a rare use case that I'm the only one having this issue.

For static triplet, you also need to add -DVCPKG_TARGET_TRIPLET=x64-windows-static to cmake.
See documentation.

For static triplet, you also need to add -DVCPKG_TARGET_TRIPLET=x64-windows-static to cmake.
See documentation.

We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.


lighter internVL for contrastive use only

Hi,
I am student working on joint embedding representation learning of text and image. I came accross your model and I am trying to load it and run it.
However, the model is very heavy and i have trouble with my computational ressources (NVIDIA T4 x2) to load the model.
Is there a way to only load the encoders and QLLama (instead of the whole model including the LLM) or is it possible in some way to make the model smaller so that i can load it ?
Many Thanks !

May I ask are you trying to use this model weight: https://huggingface.co/OpenGVLab/InternVL-14B-224px

InternVL-14B-224px is the only CLIP-like model we have released so far, and there are currently no plans to develop a smaller CLIP model.
Since there hasn't been much activity for a while, I will close this issue. If you have any questions, please don't hesitate to open it again.


Generate Gateway API CRD only when kubectl exists

As current script generates the Gateway API CRD by kubectl kustomize,
it fails when kubectl does not exist.
E.g. "Update Deps and Codegen" in knative-sandbox/knobots misses the command as
https://github.com/knative-sandbox/knobots/runs/4408339616?check_suite_focus=true
So this patch changes to generate the CRD only when kubectl command exists.

I considered other approaches as:

Ask upstream to release CRD yaml from https://github.com/kubernetes-sigs/gateway-api/releases
Add kubectl download script to hack/update-codegen.sh

But just skipping the kubectl kustomize when it doesn't exist is enough, I think.

/cc @markusthoemmes @ZhiminXiang @carlisia


Add kOS-Astrogator.netkan

A kOS addon to Astrogator

ckan compat add 1.11

You can see the output of the validation scripts here:
https://github.com/KSP-CKAN/NetKAN/actions/runs/3153340680/jobs/5129731016
The most useful part is usually the list of installed files, which looks OK to me:
  Showing 8 installed files:
    - GameData/kOS-Astrogator
    - GameData/kOS-Astrogator/kOS-Astrogator-Changelog.cfg
    - GameData/kOS-Astrogator/kOS-Astrogator.netkan
    - GameData/kOS-Astrogator/kOS-Astrogator.version
    - GameData/kOS-Astrogator/LICENSE
    - GameData/kOS-Astrogator/Plugins
    - GameData/kOS-Astrogator/Plugins/kOS-Astrogator.dll
    - GameData/kOS-Astrogator/README.md

I added a compatibility override to the PR body to enable KSP 1.11, which your users will also have to do to install since kOS hasn't been marked compatible with KSP 1.12 yet:
https://github.com/KSP-CKAN/CKAN/wiki/User-guide#choosing-compatible-game-versions

I guess technically you don't need to install the .netkan file into GameData. That's purely a CKAN bot infrastructure thing. Astrogator has an "internal" .ckan file to auto-import its values into the metadata, but .netkans don't do that.

Wow, thanks for massaging this so it works. I copied a netkan file from another mod and adjusted it, hence the json style rather than yaml. I was driving a bit blind, but I now see the mod in ckan so 🎉


Add some logging to CustomViewState3dCreator

Main reason for adding this, is we saw an extremely long running getCustomViewState3d RPC operation. There were no daemon downloads going on, or any other logging. These log messages would atleast indicate to us if some specific query was taking a long time.

@mergifyio backport release/3.3.x


Fix zk-node leak of admin path

Signed-off-by: xiaolongran<EMAIL_ADDRESS>Fixes #12968
Motivation
When we run follow command:
bin/pulsar-admin tenants delete test2

the zk-node of /admin/partitioned-topics and /admin/local-policies wil not remove, casued by zk-node leak.
Modifications

clear tenant zk-node of /admin/partitioned-topics/
clear tenant zk-node of /admin/local-policies/
add test case

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Open URI error in examples

MacOS,
rust 1.14.0
I've built the app as per instructions, tests pass, setup the browser with authentication plugin (which works fine as far as I can tell), and i'm trying to run the auth or nfs examples. Both are rejecting similarly:
Trying to open request no 801035401 as safe-auth:AAAAAC--1IkAAAAAAAAAAAAAACJuZXQubWFpZHNhZmUuZXhhbXBsZXMubmZzUmVhZFdyaXRlAAAAAAAAAAAjTm9kZUpTIGV4YW1wbGUgQXBwIC0gTkZTIHJlYWQvd3JpdGUAAAAAAAAACE1haWRTYWZlAAAAAAAAAAACAAAAAAAAAAdfcHVibGljAAAAAAAAAAUAAAAAAAAAAQAAAAIAAAADAAAABAAAAAAAAAAMX3B1YmxpY05hbWVzAAAAAAAAAAUAAAAAAAAAAQAAAAIAAAADAAAABA==
Error ::  Error: Error occured opening safe-auth:AAAAAC--1IkAAAAAAAAAAAAAACJuZXQubWFpZHNhZmUuZXhhbXBsZXMubmZzUmVhZFdyaXRlAAAAAAAAAAAjTm9kZUpTIGV4YW1wbGUgQXBwIC0gTkZTIHJlYWQvd3JpdGUAAAAAAAAACE1haWRTYWZlAAAAAAAAAAACAAAAAAAAAAdfcHVibGljAAAAAAAAAAUAAAAAAAAAAQAAAAIAAAADAAAABAAAAAAAAAAMX3B1YmxpY05hbWVzAAAAAAAAAAUAAAAAAAAAAQAAAAIAAAADAAAABA== : -1
    at Object.openUri (/Volumes/Data/Projects/safe-dev/forks/safe_app_nodejs/src/native/_system_uri.js:24:11)
    at safeApp.initializeApp.then.then.res (/Volumes/Data/Projects/safe-dev/forks/safe_app_nodejs/examples/nfs_file.js:54:18)
    at process._tickCallback (internal/process/next_tick.js:103:7)
    at Module.runMain (module.js:607:11)
    at run (bootstrap_node.js:420:7)
    at startup (bootstrap_node.js:139:9)
    at bootstrap_node.js:535:3

@joshuef Unfortunately MacOS only allows you to register the URL if you have it specified in plist-file inside a bundle. While we are doing development, the beaker browser doesn't have that feature yet..

@gnunicorn aha. Okay fair enough! Any chance of a link to a repo that show's what you mean. I'd happily implement it locally to continue exploring the new APIs

What is the expected behavior here. Is the openUrl call supposed to pop the beaker browser open with this url? When I copy paste an auth url into the safe browser (after installing the safe authenticator plugin), it just says that the URL is malformed (which makes sense because I don't think it is standards compliant).

@ethanpailes , probably too late, but yes, the openUri function should open the browser and trigger the authenticator's popup. This is assuming you previously registered the authenticator's URI by launching the browser at least once beforehand.
I'm closing this as it's not an issue anymore, we've fixed our example electron apps and browser electron app to correctly register the URI on OS X platform.


Reconsider fields for address street field for Blair

Context
Current fields to get the street name is making the data messy since the only field we need is STN field.
Examples
Duplicate address number
i.e.
// Original fields
SAN: 305
STN: 305 60TH ST APT F
STS: ST

// Output field
Number: 305
Street: 305 60TH ST APT F ST

Duplicate address road type

i.e.
// original fields:
SAN: 5375
STN: 2141 A CLOVER CREEK RD
STS: RD

// output fields
Number: 5375
Street: 2141 A CLOVER CREEK RD RD

Changes

[x] Delete extra fields considered for address street property.

@ingalls

Whoa, that's some messy source data.  Lemme see if I can track down a county-hosted ArcGIS service.

@samely I tracked down at ArcGIS source at https://gis.blairco.org/arcgis/rest/services/Assessment/MuniVerificationParcels/MapServer/1.  The data looks to be much better quality than that cached .csv file.  Are you comfortable switching the source to this?  If not, I can do it.  I'd prefer we not merge this PR as-is since the data is incredibly dirty and not very useable no matter how the street conform is specified.

@trescube Thanks for taking a look, gonna take your offer about switching the sources. Thank you again!

:wave: @trescube question, when do you think you can get this ready? :pray:

Just submitted #4500, will close this when merged.

I merged #4500 but the data won't be available in the big distribution blob for a few days.  In the meantime, this is the working file:  https://s3.amazonaws.com/data.openaddresses.io/runs/625164/us/pa/blair.zip

thanks for getting new data @trescube!


yard gems results in [error]: The file `./docs/yard_plugin.rb' could not be loaded:

Steps to reproduce
I run yard gems and it gives the following error:
❯ yard -v
yard 0.9.28
❯ yard gems
[error]: The file `./docs/yard_plugin.rb' could not be loaded:
cannot load such file -- ./docs/yard_plugin.rb
I tried to reinstall ruby/yard/no-cache , and I looked up stackoverflow for the error but no leads at all, I am trying to make it work for Solargraph to provide intellisense for the gems
Thanks for the help

## Environment details:

- OS: MacOS Monterey 12.6
- Ruby version (`ruby -v`): 3.1.2
- YARD version (`yard -v`): 0.9.28
- Relevant software dependency/versions:
  only rbenv

me too.
I installed solargraph and not worked in VSCode. Solargraph manual said

Run bundle exec yard gems.
https://solargraph.org/guides/troubleshooting

and got your error.
I greped bundled files with 'yard_plugin.rb', and got line below
vendor/bundle/ruby/2.6.0/gems/reek-6.1.1/.yardopts

--load ./docs/yard_plugin.rb
https://github.com/troessner/reek/blob/master/.yardopts#L3

I deleted this line, and executed 'bundle exec yard gem', and got seems yard finished without errors(but much warnnings and solargraph not worked...).
I hope I can be of any help to you.

I’ve this exact same issue.

Given that this is only reproducible with rbenv, I feel like this should be reported upstream to that project.
YARD relies on the $LOAD_PATH and/or working directory(*) being set correctly such that file is visible to load(file) in load_script:
https://github.com/lsegal/yard/blob/e167846322cacdcecb12cbd438aee9e78c6873a2/lib/yard/cli/command.rb#L68-L74
In reality we're probably relying on the working directory here: YARD does actually switch the working directory when parsing a specific gem and thus ./docs/yard_plugin.rb should be correctly resolved per standard lookup rules, unless the load method was mangled by rbenv.
Now unfortunately due to a lot of internals about the way load path works (complicated by whether or not Bundler is involved, as well as different versions of rubygems etc), I'm not entirely sure what exactly is not getting set correctly, but based on the lack of reproduction with a standard Ruby install, it seems as though load('./docs/yard_plugin.rb') is indeed properly loading the relative Ruby script at runtime, and thus, this seems specific to rbenv's setting of pwd/LOAD_PATH/etc. The logic to load scripts in YARD dates back to ~2012 and has worked for a decade now, including (this is a guess) in rbenv builds prior to the current one, since is the first time this issue is being reported. I would suspect that either rbenv changed something, or Ruby 3.1 changed some base reality that rbenv was specifically relying on. In either case, This is working in a standard Ruby install.
That said, there are a few other workarounds you can glean from this: the easiest would be to use ruby -I./path/to/yard-gem -S yard gems to set your LOAD_PATH explicitly (you can use gem which yard to get that path). Fortunately once the .yardoc database is built for YARD, solargraph will skip it, so you technically can do this outside of your VS Code / IDE if this is meant to seed your solargraph database.
Another would be to cd into the directory above and type yard gems there. That should most certainly work.
Hope that helps!
(*): Understanding ruby load, require, gems, bundler and rails autoloading from the bottom up

FWIW, on macos with ruby 2.7.4 and rbenv,
❯ ruby --version
ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-darwin21]
❯ rbenv --version
rbenv 1.2.0
❯ yard --version
yard 0.9.28
❯ gem which yard
/Users/mgreenberg/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard.rb
❯ find  /Users/mgreenberg/.rbenv/versions -name yard_plugin.rb
❯  ########## nothing found ##########
❯ cd /Users/mgreenberg/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/yard-0.9.28
❯ yard gems
[error]: The file `./docs/yard_plugin.rb' could not be loaded:
cannot load such file -- ./docs/yard_plugin.rb

Even following the workaround above and recommendations here, still the same issue.
❯ ruby -I /Users/mgreenberg/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/yard-0.9.28 -S yard gems
[error]: The file `./docs/yard_plugin.rb' could not be loaded:
cannot load such file -- ./docs/yard_plugin.rb
❯ cd /Users/mgreenberg/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/yard-0.9.28
❯ touch docs/yard_plugin.rb
❯ ruby -I /Users/mgreenberg/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/yard-0.9.28 -S yard gems
[error]: The file `./docs/yard_plugin.rb' could not be loaded:
cannot load such file -- ./docs/yard_plugin.rb

FWIW, I use rvm and was having this same problem.
Using yard gems --verbose exposed that the reek gem was my problem, too. The error made me think the problem was global, not a specific gem.
Doing the same as @marvingreenberg worked for me:
➜ gem which reek
/Users/chipkragt/.rvm/gems/ruby-3.1.3/gems/reek-6.1.4/lib/reek.rb
➜ mkdir /Users/chipkragt/.rvm/gems/ruby-3.1.3/gems/reek-6.1.4/docs
➜ touch /Users/chipkragt/.rvm/gems/ruby-3.1.3/gems/reek-6.1.4/docs/yard_plugin.rb

After that, yard gems ran all the way through

I had this same problem, but for me it was with Shoulda Matchers.
I had to run:
rm -f $(bundle show shoulda_matchers)/doc_config/yard/setup.rb
touch $(bundle show shoulda_matchers)/doc_config/yard/setup.rb

These reports indicate third party issues that should probably be reported in the specific projects.

Marking this as closed.


Implement Browserify functionality

I'm curious to this, how much performant it will be

@TEugen
I don't know yet. Let me get back to you when I have checked this out.
There's a branch called modules in the repository, so if you want to work on this feature check it out. I'm taking the weekend off.


Handle Number out of representable range in Snowflake

https://openmetadata.slack.com/archives/C02B6955S4S/p1670412104326779

refer to 9197


Queued Job with Deleted Model

Imagine the situation. I have a delayed job to do something with the post model, but before the job process I delete the post.
Today I use the trait indicated in this discuss.
But now I'm thinking, this kind of exception should be treated in another place, for example in the failed method.
What do you think about this @taylorotwell and @GrahamCampbell?
namespace App\Jobs;

use App\Post;
use Illuminate\Bus\Queueable;
use Illuminate\Support\Facades\Log;
use Illuminate\Queue\{InteractsWithQueue, SerializesModels};
use Illuminate\Contracts\Queue\ShouldQueue;

class Example implements ShouldQueue
{
    use InteractsWithQueue, Queueable, SerializesModels;

    protected $post;

    public function __construct(Post $post)
    {
        $this->post = $post;
    }

    public function handle()
    {
        Log::debug($post->title);
    }

    // The idea sketch
    public function foo(Exception $e)
    {
        if ($e instanceof ModelNotFoundException) {
            // do something
        }
    }
}

There is another issue with a similar problem #9347, but with soft deletes.

Yeh, this is unfortunate, but is the expected behaviour.

If in your queue jobs you don't actually need to interact with the model, and just needed to read some properties, I'd suggest just passing through those properties instead of a model.

That's what I do for sending all my mail for example. makes it possible to send account deletion emails!

Thanks @GrahamCampbell.


DH_check() changes in 1.1.1 cause pyca cryptography external test failures

PR #9435 (commit  ddd16c2fe98)  made changes to DH_check() in the 1.1.1 branch. This seems to have caused Travis to fail on the pyca cryptography external tests.
After some digging I've managed to create a standalone C test program that replicates the python test and demonstrates the change in behaviour before and after  ddd16c2fe98.
#include <stdio.h>
#include <openssl/bn.h>
#include <openssl/dh.h>

int main(void)
{
    DH *dh = DH_new();
    BIGNUM *p, *g;
    int ret = 1;
    int errflags = 0;

    p = BN_new();
    g = BN_new();
    if (dh == NULL || p == NULL || g == NULL)
        goto err;

    if (!BN_set_word(p, 23) || !BN_set_word(g, 18))
        goto err;

    if (!DH_set0_pqg(dh, p, NULL, g))
        goto err;
    p = g = NULL;

    if (!DH_check(dh, &errflags))
        goto err;

    /* We expect errflags to be non-zero */
    if (errflags == 0)
        goto err;

    ret = 0;

 err:
    BN_free(p);
    BN_free(g);
    DH_free(dh);

    if (ret == 0)
        printf("Success\n");
    else
        printf("Failure\n");
    return ret;
}

Prior to the change this test program will print "Success", and after it, it prints "Failure".
It seems that before this change the errflags were being set to DH_UNABLE_TO_CHECK_GENERATOR, but are now not set to anything. The PR in question seems to have removed the generator checks completely. Why is this?
Possibly the pyca test needs to change because it assumes something about the internal implementation of DH_check() which is no longer true (i.e. that it is unable to check certain values of generator).

@bernd-edlinger @reaperhulk

Ah, well, is is unfortunate that we had all the time test failures so I really
had no chance to spot this eariler.
Yes, previously generators were

g=2 and p=11 mod 24
g=5 and p=3 or 5 mod 10

so what is exactly not state of the art i.e. order 2q.
since we change that to generate

g=2 and p=23 mod 24
g=3 and p=11 mod 12
g=5 and p=59 mod 60

we need to relax the rules what DH_check accepts
so currently any p that is safe prime, and g != 0, 1, p-1,
in order to interoperable with DH params generated by 3.0.0
Previously p=23, g=18 was rejected. now it is accepted by DH_check.
However I am not sure if we should check that p is min. 512 bits.
master we have now a lower limit of 512 bits for p.
But that is only checked in dh_builtin_genparams,
dh_generate_key and dh_compute_key.
However I forgot about adding that check in DH_check, or
better DH_check_params.

one thing is wrong in the test case:
when DH_check did return 1, we expect errflags to be zero:
    if (!DH_check(dh, &errflags))
        goto err;

    /* We expect errflags to be zero */
    if (errflags == 0)
        goto err;

that would pass both before and after that change.

Err, actually this would be invariant:
    if (!DH_check(dh, &errflags)) {
        /* We expect errflags to be non-zero */
        if (errflags == 0)
            goto err;
    } else {
        /* We expect errflags to be zero */
        if (errflags != 0)
            goto err;
    }

Hmm, #9796 adds check for allowed key-length to DH_check but it does not
seem to fix the pyca tests.

  assert backend.dh_parameters_supported(23, 5)
  assert not backend.dh_parameters_supported(23, 18)

for now I would suggest to change that to
assert not backend.dh_parameters_supported(23, 22)
for instance, since that creates a order 2 subgroup.
But I think we will raise the minimum bit length from 512 to 1024 soon.
So I would suggest using larger primes in the good test to be safe.

one thing is wrong in the test case:
when DH_check did return 1, we expect errflags to be zero:

That's not correct. errflags can be non-zero even if DH_check returns 1.

You are right, I mixed that up...
if it returns zero, something like out-of-memory may have happened, and then
errflags is still zero.

Can this result in situations where DH parameters generated by 1.1.1d would be rejected by 1.1.1c and earlier? If so, that's potentially a problem since users would generally assume a bugfix release wouldn't cause compatibility issues like that. pyca/cryptography can easily change the test though, so if there's no compat concern we'll just go ahead and make the change. Let us know :)

Yes, that could be possible.
While I think the change in DH_check need to stay (and DH_check is not really used often),
we could partially revert the change in dh_builtin_genparams for 1.1.1
I would not completely revert, since the change did also improve the performance quite
a lot.

See #9820

we'll just go ahead and make the change. Let us know :)

yes, please change the bad test to use something really bad, like prime, but not safe prime,
and please use 1024 bit primes, to be safe.

This seems to have been fixed up stream. We need to sync our external test submodule to the latest version.

Marking as inactive, to be closed at the end of 3.4 dev barring further input


format function on CodeWriter which returns String

Is your feature request related to a problem? Please describe.

JavaScript SDK team would like to reduce bundle size of JavaScript SDK v3 by removing unnecessary variables
One such way is to remove some local redundant variables like wrappedItem from ser-deser functions (code)

First part of this is using reusable function like getArrayIfSingleItem (commit)
The second part of it is to pass output pass call value returned by getArrayIfSingleItem to another function (experimental commit)

Describe the solution you'd like

CodeWriter exposes a function (say format) which returns formatted string.
This String can later be passed to

Existing write function: https://github.com/awslabs/smithy/blob/34d51e3f7f9c351ed0867a816e082ba3ac56cc4c/smithy-utils/src/main/java/software/amazon/smithy/utils/CodeWriter.java#L925-L945
This function can be as follows:
    public final CodeWriter write(Object content, Object... args) {
        String value = format(content, args);
        String[] lines = value.split(newlineRegexQuoted, -1);

        // Indent lines and strip excessive newlines.
        for (String line : lines) {
            currentState.writeLine(line + newline);
        }

        return this;
    }

    public final String format(Object content, Object... args) {
        return formatter.format(content, currentState.indentText, this, args);
    }

Describe alternatives you've considered

Using String.format instead which might surface bugs in future
Get around by writing complex CodeGen code using just the write method

Current example function in JavaScript SDK v3:
const deserializeAws_restXmlNestedStringList = (
  output: any,
  context: __SerdeContext
): string[][] => {
  const contents: any = [];
  (output || []).map((entry: any) => {
    const wrappedItem =
      entry["member"] instanceof Array ? entry["member"] : [entry["member"]];
    contents.push(deserializeAws_restXmlStringList(wrappedItem, context));
  });
  return contents;
};

The format function would be helpful to simplify it by removing variables contents and wrappedItem:
const deserializeAws_restXmlNestedStringList = (
  output: any,
  context: __SerdeContext
): string[][] =>
  (output || []).map((entry: any) =>
    deserializeAws_restXmlStringList(
      getArrayIfSingleItem(entry["member"]),
      context
    )
  );

I'm not convinced that exposing this is needed at this time. This TS code is generated from this Java code, which could be updated to remove the contents and wrappedItem vars.

Any suggestion on how writer.write can be removed from inside handleUnnamedTargetWrapping (code)
Requirement: The formatted output for wrappedItem needs to be passed to getMemberVisitor

The content that's being handled there is what you want to migrate behind the getArrayIfSingleItem call, so it shouldn't need to do anything other than remove the .write() call and return the function invoke to be used as the updated data source:
private String handleUnnamedTargetWrapping(GenerationContext context, Shape target, String dataSource) {
    if (!deserializationReturnsArray(target)) {
        return dataSource;
    }

    // The XML parser will set one K:V for a member that could
    // return multiple entries but only has one.
    // Update the target element if we target another level of collection.
    String targetLocation = getUnnamedAggregateTargetLocation(context.getModel(), target);
    return String.format("getArrayIfSingleItem(%s[\"%s\"])", dataSource, targetLocation);
}

Using String.format is what was tried in experimental commit and was explained under alternatives in issue description.
Is the recommendation to use String.format and replicate formatting for specific use cases over exposing formatter.format as an API on CodeWriter?

I don't think exposing format is a general purpose solution, and would expose some workflows that could leave the CodeWriter in an inconsistent state. The CodeWriter handles imports and dependency management for you. If you use stuff like String#format then it doesn't do any of that, so this doesn't seem like a good option. If you use CodeWriter#format, then it would add dependencies and imports to the CodeWriter, but unless you actually call write at some point, the dependencies and imports might not actually be needed.
Have you considered just delegating to other methods and mutating the CodeWriter rather than returning a value?

I don't think exposing format is a general purpose solution

I agree as CodeWriter is supposed to write code as per name, and not return something. This issue is cut to learn recommendation from Smithy team for this use case.

Have you considered just delegating to other methods and mutating the CodeWriter rather than returning a value?

The generic use case is ability to send output of formatter.format inside a method for further processing. How can delegation or mutation will help here?


Feature-Request: add the ability to use computed totals

Add an option to use a formula to compute the total of a column.
Example : I have the last column with a formula (1- (col2 / col1)) that computes a percentage and I would like to be able to compute the total with the same formula.
Actually, I have 151.8% as a total (because the total function is sum) instead of 1-15.9/938.47=98,3%.

Good idea

I don't promise, but I will try to add it to next release.

Thus, it is the #100 issue :)
It requires a special attention :)

Thanks, good news!
And I didn't pay attention to the number: it is an honour :)

wow this good idea, i had same problem,

I can confirm you that I have implemented the feature and so, it will be available in next release!

Hi,
Enhanced table plugin 1.9.0 is out with ‘use formula to compute total’ option in computed columns, and more features!
https://github.com/fbaligand/kibana-enhanced-table/releases/tag/v1.9.0

Hi
Thanks a lot!
Yann

You’re welcome 😉

i had install it, but i cannot find the compute total. can u demo how to do it?

Well, in the computed column editor, there is a checkbox “compute total using formula”


starship: 0.33.1 -> 0.34.1

Motivation for this change
https://github.com/starship/starship/releases/tag/v0.34.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This change is

nixpkgs-review failed with the following output:
builder for '/nix/store/ifsagdc7vcmb9zlqwk7rp3vqsphv08rf-starship-0.34.1.drv' failed with exit code 101; last 10 log lines:
  ...
  376 |         let node_dc = DirContents::from_path(&PathBuf::from(node.path()))?;
      |                                    ^^^^^^^^^ function or associated item not found in `context::DirContents`

  error: aborting due to 4 previous errors

  For more information about this error, try `rustc --explain E0599`.
  error: could not compile `starship`.
  warning: build failed, waiting for other jobs to finish...
  error: build failed
cannot build derivation '/nix/store/rz4ybw1h3nphk8pcfzpyy36viihfqsbb-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/rz4ybw1h3nphk8pcfzpyy36viihfqsbb-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79282
1 package failed to build:
starship

I got the same error.

Please try with v0.35.0 which should fix the problem.

Please try with v0.35.0 which should fix the problem.

v0.35.1 has also been released.

Did the update and added @filalex77 as co-author :)


Quick cleanup

DefaultInlineConstraintResolver has no need of a IServiceProvider

nits:

add doc comments for changed DefaultInlineConstraintResolver ctor
let VS add a dev server port to sample's .kproj
add debugSettings.json and .vs/ to .gitignore

/cc @rynowak

:shipit:

Commit c59366e8a7fcc61e759d13cd2f17fe1876597215


What is the content of the reference80true.mat file in /matlab_scripts/Extract_ToF?

The variable in reference80true.mat is named reference and is loaded by compute_tof_music.m. After that, you did the hadamard division to calibrate the CSI, so when you calibrate the ToF, you still need to calibrate the CSI, right?
And which pair of antennas does the reference belongs to? I can't find any information about the antennas pair you used for ToF estimation.

Hi,
You are right, we did not explain it on the paper. The idea is quite similar as the calibration in the UbiLocate paper Section 3.1 Extracting CSI. We aim to remove the echos that the CSI data contains, to do so we apply a deconvolution and that is why we use a hadamard division in the MATLAB code.
The CSI data where captured by a pair of ASUS routers connecting the first chains of both (the rightmost chains on the ASUS).

Okay, and is the rightmost chains correspond to antenna 1's chain in your device image?

Yes it does

okay, thanks.


Fix plan/apply run from different control nodes

When running the terraform plan/apply from different workstatons or build servers we found that the lambda filename attribute was still a fully qualified path that didn't always exist on each control node.  The fixes to use relative paths hadn't been applied to the state file for resources that had previously existed.  To resolve this we had to stop ignoring the filename attribute.  To get to that point it was easier to reason about the paths by removing the indirection on the file references.
Tested this across different workstations and we're getting the desired results now.  Subsequent runs also aren't resulting in any further changes.
In order to reliably carry out testing we've also added a test framework for the lambda along with instructions.  As part of this we needed to capture some incoming events, so the lambda now also has an option to log the raw incoming events.
The used python version has also been updated to 3.7 because it's available, considered stable, and works.
Please see individual commit messages for further details.

Please merge! :)

Conflicts resolved.  Let me know if there's anything I can do to help get this merged.

Big thanks @jinnko!
v2.6.0 has been released.


lua lazy_load not working

Consider the following minimal.lua file:
local fn = vim.fn

-- Ignore default config and plugins and define new dirs
local test_dir = '/tmp/nvim-minimal'
vim.opt.runtimepath:remove(fn.expand('~/.config/nvim'))
vim.opt.packpath:remove(fn.expand('~/.local/share/nvim/site'))
vim.opt.runtimepath:append(fn.expand(test_dir))
vim.opt.packpath:append(fn.expand(test_dir))

-- Install packer
local install_path = test_dir .. '/pack/packer/start/packer.nvim'
if fn.empty(fn.glob(install_path)) > 0 then
    packer_bootstrap = fn.system({
        'git',
        'clone',
        '--depth',
        '1',
        'https://github.com/wbthomason/packer.nvim',
        install_path,
    })
    vim.cmd([[packadd packer.nvim]])
end

-- Setup packer
local packer = require('packer')
packer.init({
    package_root = test_dir .. '/pack',
    compile_path = test_dir .. '/plugin/packer_compiled.lua',
})
packer.startup(function(use)
    use('wbthomason/packer.nvim')
    use({
        'L3MON4D3/LuaSnip',
        config = function()
            require('luasnip.loaders.from_lua').lazy_load({
                paths = { vim.fn.stdpath('config') .. '/snippets/' },
            })
        end,
    })
    if packer_bootstrap then
        packer.sync()
    end
end)

where  vim.fn.stdpath('config') .. '/snippets/'  is /home/pedro/.config/nvim/snippets/ and contains a python.lua snippet file with:
local ls = require('luasnip')
local s = ls.snippet
local t = ls.text_node

s('trigger', { t('Wow! Text!') })

Now, as in the GIF, do

Open nvim loading this minimal.lua file
Open a python file such as :e ~/Desktop/foo.py
Run :LuaSnipListAvailable -> no python snippets are avaiable
Run :lua require('luasnip.loaders.from_lua').edit_snippet_files() -> a python snippet file is parsed

So for some reason my snippets (in python.lua file) are not being parsed/seen by LuaSnip despite being registed by edit_snippet_files. Any pointers are greatly appreciated.

Could you switch to the branch logging, call require("luasnip.util.log").set_loglevel("warn") and follow the content of vim.fn.stdpath("log") .. "/luasnip.log"? (to verify logging works, there should be a short message on startup)

Hi! Thanks for the quick reply. I've modified the packer part of the minimal.lua file  like so:
    use({
        'L3MON4D3/LuaSnip',
        branch = 'logging',
        config = function()
            require('luasnip.util.log').set_loglevel('warn')
            require('luasnip.loaders.from_lua').lazy_load({
                paths = { vim.fn.stdpath('config') .. '/snippets/' },
            })
        end,
    })

but /home/pedro/.local/state/nvim/luasnip.log only shows the following:
INFO  | New session: Sun 09 Oct 2022 09:30:03 AM -03

Snippets are correctly loaded for you with my minimal.lua file? (i.e you cannot reproduce my issue?)

I should've read this bit more closely https://github.com/L3MON4D3/LuaSnip/blob/master/DOC.md#lua
Writing now my snippets like so
local ls = require('luasnip')
local s = ls.snippet
local t = ls.text_node

return {
    s('a_snippet', { t('Test') }),
}, {}

Makes everything work as expected. Closing. Thanks for the help

Ohh haha, I didn't even look at the file, I think I misunderstood what you meant with "it showed".
Glad it works :+1:


Can't use theme (or any props) in the css function

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
https://codesandbox.io/s/compassionate-kepler-zkvvp9?file=/src/App.tsx
Observe the typescript error showing that it ain't gonna work.
Current behavior 😯
There seems to be no way to use the theme prop, or any other props for that matter, when creating a set of styles using the css function with the intention of reusing it in multiple styled components.
Expected behavior 🤔
There has some some kind of way. I would definitely expect at least one of the two varieties in the linked example would work.
Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  System:
    OS: Windows 10 10.0.19045
  Binaries:
    Node: 18.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 9.6.7 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 114.0.5735.134
    Edge: Spartan (44.19041.1266.0), Chromium (114.0.1823.51)
  npmPackages:
    @emotion/react:  11.11.1
    @emotion/styled:  11.11.0
    @mui/base:  5.0.0-beta.4
    @mui/core-downloads-tracker:  5.13.4
    @mui/material:  5.13.5
    @mui/private-theming:  5.13.1
    @mui/styled-engine:  5.13.2
    @mui/styles:  5.13.2
    @mui/system:  5.13.5
    @mui/types:  7.2.4
    @mui/utils:  5.13.1
    @types/react:  18.2.0
    react:  18.2.0
    react-dom:  18.2.0
    typescript:  4.9.5

I'm using Firefox 114.

I found a workaround.
const baseStyles = ({ theme }: { theme: Theme }) => css({
  // some shared styles
});

const Component = styled(MuiLink)(baseStyles, ({ theme }) => ({
  // some specific styles
}));

Feels kind of jank, but it does work.


debugging: add entry size logs for directory listing

Issue: KBFS-2359

Do we need it in libdokan too or is this for a fuse specific issue?

We're only seen it on macOS so far, so I think libfuse is good enough for now.


[sourcekit] Send compile notifications when argument parsing files

When swift command-line argument parsing fails in sourcekit, make sure we can still send a compile notification including the diagnostic about the incorrect arguments.
rdar://39225180

@swift-ci please test


The creation of the cookie broke in the HA version 2023.8.0+

This integration no longer creates a cookie in the browser in HA versions 2023.8.0-3. It generates the key files at startup but doesn't work properly at login flow, for whatever reason.
There are no errors in the debug log.

Thanks, fixed in v0.0.2


Illegal hardware instruction

Hi,
I have compiled from source, but I get the following error when running
$ ./main 0 20 1 test.fastq
Reading from the fastq file and inserting in the QF
[1]    28352 illegal hardware instruction  ./main 0 20 1 test.fastq

I compiled with gcc-4.9. The following is the result of ldd main
    linux-vdso.so.1 =>  (0x00007ffe8a8f8000)
    libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fed2eee8000)
    libssl.so.1.0.0 => /lib/x86_64-linux-gnu/libssl.so.1.0.0 (0x00007fed2ec88000)
    libcrypto.so.1.0.0 => /lib/x86_64-linux-gnu/libcrypto.so.1.0.0 (0x00007fed2e8a8000)
    libboost_system.so.1.57.0 => /nfs/users/nfs_j/jl11/software/lib/libboost_system.so.1.57.0 (0x00007fed2e6a0000)
    libboost_thread.so.1.57.0 => /nfs/users/nfs_j/jl11/software/lib/libboost_thread.so.1.57.0 (0x00007fed2e480000)
    libstdc++.so.6 => /software/hgi/pkglocal/gcc-4.9.1/lib64/libstdc++.so.6 (0x00007fed2e170000)
    libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fed2de70000)
    libgcc_s.so.1 => /software/hgi/pkglocal/gcc-4.9.1/lib64/libgcc_s.so.1 (0x00007fed2dc58000)
    libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fed2d890000)
    /lib64/ld-linux-x86-64.so.2 (0x00007fed2f108000)
    libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fed2d688000)
    libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fed2d470000)
    librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fed2d268000)

Any ideas why this is happening?

Hey John,
Squeakr uses a CQF as the underlying data structure to count kmers. The CQF code uses two new instructions that were introduced in Intel Haswell (4th generation) line of CPUs.
I guess the machine you are using doesn't have a Haswell or newer CPU. That's why you are getting an "illegal hardware instruction" issue.

I will try to release a patch so that the code can use the C implementation of the new instructions if the underlying hardware doesn't support them.

Ah, thanks for the explanation. I'd appreciate the patch, if you're able to make it!

Hey John,
I have pushed a new commit for the code to work on older-than-Haswell CPUs. The REAMDE is also updated with instructions on how to build.
Thanks
Prashant

Thanks for that!
I'm now getting a compile error, which I guess is due to missing zlib includes?
In file included from main.cc:49:0:
reader.h:35:21: error: ‘gzFile_s’ has not been declared
    reader(FILE *in, gzFile_s *in_gzip, BZFILE *in_bzip2, int bzerror);
                     ^
reader.h:38:4: error: ‘gzFile_s’ does not name a type
    gzFile_s *in_gzip = nullptr;
    ^

I've got zlib.h in /usr/include which should be ok? I noticed some of the zlib stuff changed with the recent commit

Can you check the version of zlib and bzip2 on your machine?
Here is what I have:
$ apt-cache policy zlib1g-dev
zlib1g-dev:
Installed: 1:1.2.8.dfsg-2ubuntu4
Candidate: 1:1.2.8.dfsg-2ubuntu4
Version table:
*** 1:1.2.8.dfsg-2ubuntu4 500
500 http://ca.archive.ubuntu.com/ubuntu xenial/main amd64 Packages
100 /var/lib/dpkg/status
$ apt-cache policy bzip2
bzip2:
Installed: 1.0.6-8
Candidate: 1.0.6-8
Version table:
*** 1.0.6-8 500
500 http://ca.archive.ubuntu.com/ubuntu xenial/main amd64 Packages
100 /var/lib/dpkg/status

$ apt-cache policy zlib1g-dev
zlib1g-dev:
  Installed: 1:<IP_ADDRESS>.dfsg-3ubuntu4
  Candidate: 1:<IP_ADDRESS>.dfsg-3ubuntu4
  Version table:
 *** 1:<IP_ADDRESS>.dfsg-3ubuntu4 0
        500 http://www.mirrorservice.org/sites/archive.ubuntu.com/ubuntu/ precise/main amd64 Packages
        100 /var/lib/dpkg/status
$ apt-cache policy bzip2
bzip2:
  Installed: 1.0.6-1
  Candidate: 1.0.6-1
  Version table:
 *** 1.0.6-1 0
        500 http://www.mirrorservice.org/sites/archive.ubuntu.com/ubuntu/ precise/main amd64 Packages
        100 /var/lib/dpkg/status

Do you think the zlib version is too low?

Can you check if "gzFile_s" is declared in your "/usr/include/zlib.h"?
If not you should upgrade your zlib package.
Thanks
Prashant

Hi Prashant,
I have installed zlib 1.2.11, and now squeakr has compiled and runs correctly. Thanks so much for your help! I look forward to using the tool.
John


cargo new --bin[=NAME] should be allowed

e.g. (assuming #5431 )
cargo new --lib --bin --bin=hello crate
crate/
|_ Cargo.toml
\_ src/
   |_ lib.rs
   |_ main.rs
   \_ bin/
      \_ hello.rs

Hm, this definitely escalates.
It might be a nice idea to implement this as an external subcommand, cargo new-target --bin=hello, which adds bin/lib/test etc to existing target.

This would support both cargo new --lib --bin=crate crate and cargo new --lib --bin crate, is the idea.

Closing in favor of #5151


Minting

I went to mint tokens.
The 1st time I was successful, but when I went to mint 10 tokens at once I received an error.
I then went to mint 1 token and received an error.
There are funds in my wallet.
I used the same process all three times.

Fixed


Fix zplug trying to checkout in not-git repo directories

This fixes the error message such as:
[zplug] ERROR: pathspec 'master' (at tag) did not match (~/a.zsh)
[zplug] ERROR: pathspec 'master' (at tag) did not match (junegunn/fzf-bin)

This is done by blacklisting the from values that are not git repositories,
and avoiding running git checkout on those sources.

As far as I have reviewed your code, I prefer to take this way as against that way:
-    do_not_checkout=( local gh-r )
+    do_not_checkout=( "local" "gh-r" )

The keyword "local" is syntax highlighted because it is a reserved word in zsh.


Delegate methods to get player events

At least for play/pause/loading/fullscreen_on/fullscreen_off

While debugging unreliable player behaviour I was looking for a way to track its status. And was surprised to see this declaration in KinescopeVideoPlayer.swift:
    private weak var delegate: KinescopeVideoPlayerDelegate?

I see no reason to declare delegate as private property. How can I use it from application code?

It was really a mistake to make delegate private.
But anyway KinescopeVideoPlayerDelegate have very limited amount of methods implemented.
For debug purposes there is also KinescopeDefaultLogger exists which cover a lot more events in playerView and player itself.
Could you clarify, do you still need to listen some events through delegate? It would be great if you prepare a list of events to listen.

Fixed in https://github.com/kinescope/ios-kinescope-player/releases/tag/0.2
Now you can set KinescopeVideoPlayerDelegate or KinescopeAnalyticsDelegate


Altitude performance on 1.8 sometimes worse than on 1.7

Idea of Paul:
back to back testing on same hardware. Run 1.8 estimator on 1.7 and 1.8

➤ Thomas Gubler commented:
@Roman Bapst could you please provide the logs to paul?

➤ Paul Riseborough commented:
Relates to https://github.com/PX4/Firmware/issues/9740

The following logs were obtained with a similar vehicle to the one referred in https://github.com/PX4/Firmware/issues/9740#issuecomment-413448792 .
Altitude hold
v1.7.3
https://logs.px4.io/plot_app?log=f8cba56b-6eda-4ec0-8722-6dabc823f4c8
v1.8.0
https://logs.px4.io/plot_app?log=c4fddaa4-ef0f-4afb-bcb4-f9af3fcd396a
Position Control (No commands)
v1.7.3
https://logs.px4.io/plot_app?log=169ba77f-b011-4906-ad21-99a231776ab6
v1.8.0
https://logs.px4.io/plot_app?log=000b2a95-ef3e-40fe-8d82-4fcec21e7121

➤ Wrike Bot commented:
@Paul Riseborough All subtasks have been completed or deferred, you might want to complete this task as well.

I was able to compare the v1.7.3 and v1.8.0 logs and check the EKF baro lat innovations and the consistency of the output vertical velocity and vertical position derivative. Both metrics indicated that the ekf  in the 1.8.3 log was performing  better than in the 1.7.3 log.
v1.7.3 baro innovations

v1.7.3 baro innovations

v1.8.0 vertical velocity and vertical position derivative

v1.7.3 vertical velocity and vertical position derivative

@jfcisneros Plotting the baro alt and distance sensor data overlayed shows a significant inconsistency. Can you  please confirm your sensor calibration. If the baro has this much scale factor error, then it is pointless doing 1.7.3 vs 1.8.0 comparisons.
v1.7.3

v1.8.0

Could the Barometer be exposed to Downwash/Turbulence? I'm interested in this Issue since I have also seen rather large Oscillations of my F-450 Quad with a Pixracer, but now when I think of it, it is probably exposed to Downwash Effects (it does not have LIDAR/US Sensors)

That's possible. A hand held height change test without motors running will confirm if it is a sensor or aerodynamic issue.

Sorry for the delay. I just did the recommended testing without the motors running.
Both of the logs were recorded with v1.8.0
Hand Held Test
https://review.px4.io/plot_app?log=4c726610-db8d-472b-924f-2359e13b0f54

Altitude Hold
https://review.px4.io/plot_app?log=074083e5-d457-47fb-8f96-f16c36ace664

There seems to be a great effect in the baro scale factor while flying.
For our vehicle we have selected Range sensor as EKF2_HGT_MODE, and Range aid enabled for EKF2_RNG_AID. Wouldnt this set the EKF2 to use Range Finder height rather than height from the barometer?


fix(engine) Lookup contract name from the logic manager

Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>Changes

Fixes engine issue: confusing contract name with contract id

Coverage increased (+0.004%) to 95.092% when pulling 0309f6ee0b5ecdb371c89e14e6d6be5607e1f72e on jeromesimeon:js-alpha.5 into da1f88b278f447de290aea684f9f20e3c3c9b074 on accordproject:master.


Keeping frontend modules since the app.js checks whether or not the m…

This change allows the app to start on the docker container. If there's a reason this was there let me know and I can see if there's a better way to fix this

Ah, damn ... this is okay as a workaround. The underlying problem is that on Docker the npm install already happened and therefore the frontend/node_modules is no longer needed, as it's all packaged into frontend/dist already. Same issue would occur for pre-packaged ZIP files I presume... testing that now...

...and it does occur in the pre-packaged ones as well. Okay, the only sensible solution is to remove the corresponding check for the frontend dependencies being installed. I'll hotfix that asap.

Alright sounds good I'm pretty sure that's it cause I tried I think 8.4.1
and it worked for the docker image
On Tue, Apr 16, 2019, 1:30 PM Björn Kimminich<EMAIL_ADDRESS>wrote:

...and it does occur in the pre-packaged ones as well. Okay, the only
sensible solution is to remove the corresponding check for the frontend
dependencies being installed. I'll hotfix that asap.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bkimminich/juice-shop/pull/942#issuecomment-483769856,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEWeUjJEmBTff6leCGbFbiJv_KXMhBEjks5vhgi6gaJpZM4czLay
.

I can just close this one and re open if needed since you're going to do the other hotfix

Thanks for reporting this so quickly! :+1: ... v8.5.1 is on the way through the build pipeline and should fix this issue.

Glad to help we just went through this at my company and wanted to try it locally when I noticed this :)


Decrease the size of the "Give as a Guest" button

Acceptance Criteria

[ ] The "Give as a Guest" button should be smaller.

@IsaacHardy with us making this button smaller, I'm going to have to use a Chip instead of a Button in order to change its height. The thought then becomes what is the design supposed to look like on web? The form is currently constructed in a way so that the buttons are in a row. Changing the size of this makes that row not as aesthetically pleasing.


Remove trailing slash in urls automatically

Attempts to resolve:

https://github.com/jupyterhub/binderhub/issues/495

can't believe we hadn't gotten to this one yet - thanks so much for the patch :-)


NOMAD.jl Repo URL change

Hi Everyone,
I'd like to replace the old NOMAD package registered with mine. I'm in touch with jbrea who is the owner of the former package and he agrees to replace his with mine. As I was advised in https://github.com/JuliaRegistries/General/pull/3640 (I will close the old PR soon), I update the URL of the package to point to my repo.
Thanks for the help, fredrikekre !

@jbrea can you just confirm for the record that this is OK?

Yes, it's great that @ppascal97 has now an updated version of NOMAD.jl.


add  other  new  models

In this integrated model, can we replace the sample with other models that are not included in this model library for training? How should I proceed with this replacement? Could you provide some suggestions? Thank you.

Hi @wangluoWSG can you provide a bit more details regarding what you want to add?

yes new models should be added in segmentation models @qubvel

@adamjstewart


Supernovae skeleton with host galaxies.

In this PR, the option of a double Sersic profile for the source light has been implemented.

Hi @sibirrer, I have resolved all the comments!

Hi @sibirrer, all the comments have been resolved!

Thanks Narayan, it looks good! I'd like to see the final output of the simulated images, but when I view the notebook on my laptop it doesn't show that. (but we can talk about this more in today's meeting)

Hi @sibirrer , @jpierel14 , @Nikki1510 , @anasdm , I integrated justin's RandomizedSupernova class with source class. I have uploaded a notebook showing how to generate lensed supernovae population. You can review it now!

Hi @sibirrer , @jpierel14 , @Nikki1510 , @anasdm , I integrated justin's RandomizedSupernova class with source class. I have uploaded a notebook showing how to generate lensed supernovae population. You can review it now!

fyi, you can use this link to directly access the NBreview page with better presentation: https://app.reviewnb.com/LSST-strong-lensing/slsim/pull/130

@Nikki1510 @anasdm @jpierel14 I would like to have this PR merged soon as I am starting some developments that would be great having this PR merged soon. You can also comment and request changes later on on the notebook etc, but would be great if some of you could have a look. Thank you!

thanks you @nkhadka21! I think we can merge this PR for now and more inputs as people are getting to use this feature will be more than welcomed.


Improving the experience of phone and small screens  users

phone and small screens users need some adjustments

[x] phone and small screens users need some adjustments

Mostly done the experience now is way more better.


Audacity : Version issue

Hi,
Audacity is not working properly due to a poor version formatting :
2023-05-18 10:33:59 : INFO  : audacity : found app at /Applications/Audacity.app, version <IP_ADDRESS>
and :
2023-05-18 10:33:59 : INFO  : audacity : Latest version of Audacity is 3.3.2
2023-05-18 10:34:10 : INFO  : audacity : Downloaded version of Audacity is <IP_ADDRESS> on versionKey CFBundleShortVersionString, same as installed.
How can i solve this ?

Sorry if I was not clear, here is the log :
2023-06-02 14:55:08 : INFO  : audacity : App(s) found: /Applications/Audacity.app
2023-06-02 14:55:09 : INFO  : audacity : found app at /Applications/Audacity.app, version <IP_ADDRESS>, on versionKey CFBundleShortVersionString
2023-06-02 14:55:09 : INFO  : audacity : appversion: <IP_ADDRESS>
2023-06-02 14:55:09 : INFO  : audacity : Latest version of Audacity is 3.3.2
2023-06-02 14:55:09 : REQ   : audacity : Downloading https://github.com/audacity/audacity/releases/download/Audacity-3.3.2/audacity-macOS-3.3.2-universal.dmg to audacity-macOS-[0-9.]-universal.dmg
2023-06-02 14:55:12 : INFO  : audacity : ignoring blocking processes
2023-06-02 14:55:12 : REQ   : audacity : Installing Audacity
2023-06-02 14:55:12 : INFO  : audacity : Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.QFQeSj9b/audacity-macOS-[0-9.]-universal.dmg
2023-06-02 14:55:15 : INFO  : audacity : Mounted: /Volumes/Audacity
2023-06-02 14:55:15 : INFO  : audacity : Verifying: /Volumes/Audacity/Audacity.app
2023-06-02 14:55:21 : INFO  : audacity : Team ID matching: AWEYX923UX (expected: AWEYX923UX )
2023-06-02 14:55:22 : INFO  : audacity : Downloaded version of Audacity is <IP_ADDRESS> on versionKey CFBundleShortVersionString, same as installed.
Seems that when Installomator is checking for the latest version its getting a wrong number : 3.3.2 instead of 3.3.2**.0**

you did not really answer my question. Installomator considers 3.3.2 and <IP_ADDRESS> the same version, does it not? Is it an issue if it does? Or doesn't?

also, Audacity reports the version as 3.3.2 in the GitHub repo and as <IP_ADDRESS> in the app bundle. We have to work with what we get...

I've opened a case on their support forum… Well thanks anyway !

Working with what we got, I hear that. Why don't we use appCustomVersion in that case?

On the wiki, it is stated: "Installomator does not compare the version for being greater or lesser, but only for being different." On a technical level, x.y.z.0 and x.y.z.0 are different. As-is with 10.4 it does not match and still downloads it again, and only once it checks the downloaded file's version against the installed version does it match then quit. So it doesn't seem your zsh's is-at-least is compared for appNewVersion and appVersion before the download, or at least doesn't appear to work that way. See output below.
Why I care, is with tools like Patchomator that run through multiple labels I'd rather not download version after version of software it things needs updating, only to cancel after using bandwidth and time. With a 48MB file that isn't a problem for a wired gigabit connection, but not great for people on mediocre wi-fi, and possibly more labels.
I just wanted to chip away at labels that might be affected, and with an open issue that you tagged as . If you don't want people to jump in and offer help, why is that tagged that way? It should be left with only Waiting for Reply, or just close the thing.
Output:
sudo ./Installomator.sh audacity
Password:
2023-06-08 08:13:47 : REQ   : audacity : ################## Start Installomator v. 10.4, date 2023-06-02
2023-06-08 08:13:47 : INFO  : audacity : ################## Version: 10.4
2023-06-08 08:13:47 : INFO  : audacity : ################## Date: 2023-06-02
2023-06-08 08:13:47 : INFO  : audacity : ################## audacity
2023-06-08 08:13:48 : INFO  : audacity : BLOCKING_PROCESS_ACTION=tell_user
2023-06-08 08:13:48 : INFO  : audacity : NOTIFY=success
2023-06-08 08:13:48 : INFO  : audacity : LOGGING=INFO
2023-06-08 08:13:48 : INFO  : audacity : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2023-06-08 08:13:48 : INFO  : audacity : Label type: dmg
2023-06-08 08:13:48 : INFO  : audacity : archiveName: audacity-macOS-[0-9.]-universal.dmg
2023-06-08 08:13:48 : INFO  : audacity : no blocking processes defined, using Audacity as default
2023-06-08 08:13:48 : INFO  : audacity : App(s) found: /Applications/Audacity.app
2023-06-08 08:13:48 : INFO  : audacity : found app at /Applications/Audacity.app, version <IP_ADDRESS>, on versionKey CFBundleShortVersionString
2023-06-08 08:13:48 : INFO  : audacity : appversion: <IP_ADDRESS>
2023-06-08 08:13:48 : INFO  : audacity : Latest version of Audacity is 3.3.2
2023-06-08 08:13:48 : REQ   : audacity : Downloading https://github.com/audacity/audacity/releases/download/Audacity-3.3.2/audacity-macOS-3.3.2-universal.dmg to audacity-macOS-[0-9.]-universal.dmg
2023-06-08 08:13:51 : REQ   : audacity : no more blocking processes, continue with update
2023-06-08 08:13:51 : REQ   : audacity : Installing Audacity
2023-06-08 08:13:51 : INFO  : audacity : Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.oOfidXN6/audacity-macOS-[0-9.]*-universal.dmg
2023-06-08 08:13:55 : INFO  : audacity : Mounted: /Volumes/Audacity
2023-06-08 08:13:55 : INFO  : audacity : Verifying: /Volumes/Audacity/Audacity.app
2023-06-08 08:13:57 : INFO  : audacity : Team ID matching: AWEYX923UX (expected: AWEYX923UX )
2023-06-08 08:13:57 : INFO  : audacity : Downloaded version of Audacity is <IP_ADDRESS> on versionKey CFBundleShortVersionString, same as installed.
2023-06-08 08:13:57 : INFO  : audacity : App not closed, so no reopen.
2023-06-08 08:13:57 : REQ   : audacity : ################## End Installomator, exit code 0

I think you are confusing me for the original poster of the issue? Although I don't think their description "isn't working properly" was quite accurate, I did see the small conflict in versions and submitted the PR for that. I should have explained more plainly in my first message why I had submitted it.
Currently, I only see is-at-least used for OS checks, but if works as you describe then using it for the version checks sounds much better to do than changing the labels individually. We might have to add something to catch and compare versions with letters in them separately, but I'm not sure I'd able to set that all up- I'm more of a labels person for now, but maybe I'll try and practice another day.
You can use the Audacity PR or not, its not too important. Although I looked back and didn't see any mention or use of the 4th version digit and don't think they would, I think having the version comparison catching it would be better.


[backport] [FLINK-5073] Use Executor to run ZooKeeper callbacks in ZooKeeperStateHandleStore

Backport of #2815 for the release-1.1 branch.
Use dedicated Executor to run ZooKeeper callbacks in ZooKeeperStateHandleStore instead
of running it in the ZooKeeper client's thread. The callback can be blocking because it
discards state which might entail deleting files from disk.

Build passed locally: https://travis-ci.org/tillrohrmann/flink/builds/177725509. Merging this PR.


winPB: Make removal of speech mark in %PATH it's own task in Cygwin

ping @lumpfish
Currently, this task: https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/3143979688df2c97ea6b41347feaef8438809885/ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/cygwin/tasks/main.yml#L113
Will remove the stray speech mark in the Windows path before then adding cygwin's folder to the front of the path, however on some Windows systems this errors, with the following error message:
TASK [cygwin : Add c:\cygwin64\bin to front of %PATH%] *************************
fatal: [IP]: FAILED! => {"changed": true, "cmd": "setx /M PATH \"C:\\cygwin64\\bin;%PATH:\\\"=%\"", "delta": "0:00:00.218777", "end": "2020-06-17 01:27:23.008818", "msg": "non-zero return code", "rc": 1, "start": "2020-06-17 01:27:22.790040", "stderr": "ERROR: Invalid syntax. Default option is not allowed more than '2' time(s).\r\nType \"SETX /?\" for usage.\r\n", "stderr_lines": ["ERROR: Invalid syntax. Default option is not allowed more than '2' time(s).", "Type \"SETX /?\" for usage."], "stdout": "", "stdout_lines": []}

Running the command that is written in the task on the windows machine itself also didn't work, however running this manually did: set NEWPATH=%PATH:"=% && setx /M PATH "C:\cygwin64\bin;%NEWPATH%"  which can be 'ansibilised' as two separate tasks. This has the side benefit of being much clearer to read and understand what's going on.

I've found a solution that would fix this issue- as in split out the tasks, as this makes it more readable for people who aren't as familiar with cmd/ Windows functions. I confirmed this does remove the speech marks as intended.
- name: Remove speech mark from the Path
  win_shell: 'setx /M PATH "%PATH:\"=%"'
  args:
    executable: cmd
  tags:
    - cygwin

I'm happy to put it in, the problem is that the error message I posted above would suggest there was/is an issue with the setx syntax - possibly something with the speech marks in the command. It should be mentioned that the error occurred on a machine that has had the Cygwin task run on it before. I hypothesise the issue is because the syntax is correct when the speech mark is in the %PATH%, but then fails when it isn't - i.e. %PATH% has had the speech mark removed from the cygwin role running before.
EGiven that the path won't need to be 're-updated' if the cygwin installation is skipped, I'm also going to add when: (not cygwin_installed.stat.exists) to the tasks that change the path. This should stop issues occurring if the playbook is ran on a machine the second time.

ref: #796
Found out, my hypothesis is incorrect - it will fail if there IS a " in %PATH%.  Either way, the fix listed above should still stop the issue :-)


gltfpack: Sort bone influences by weight, not by index

This slightly regresses the compression ratio but the delta is not very significant -
it seems to be <~0.1% on most meshes and goes up to ~0.3% on some.
We can probably recoup some of the losses by sorting the skin joints in the future
by making the neighboring joints more spatially proximal wrt rigging.
With this change renderers that discard lower weights and renormalize the rest will
not have to sort the weights for glTF files packed by gltfpack in the future, even
though there's no way to indicate that in the file for now.

This partially reverts https://github.com/zeux/meshoptimizer/commit/b54af103ac8f509562a2a576b56514ad10341518


Generic Reconciliation function

What is missing?
There is a lot of duplication in our reconciliation logic. Would it be possible to create a ReconcileAllObjects function which takes a slice of different k8s API objects and brings them all into the desired state based on their name?

@Miles-Garnsey, could you elaborate a bit more on which parts of the code this change would touch?
Maybe this is a little too ambitious for our refactoring week and could be broken down into more specific steps? Which types of objects would be part of this refactoring?
I'm thinking that configmaps are clearly a great candidate, and also injecting/updating volumes, mounts and env variables into pod template specs.

Very quickly (and I have not thought this through or researched whether it will work), the intention is to build a function which rakes a list of client.Objects and reconciles them into the desired state.
How far we get towards hooking that in to the existing logic is an open question, but I'm hoping that we can make it work... At the worst, we might need reconcilers for each type (because Go's type system is... idiosyncratic...), which would make life more complicated but still may add value.

Could you spend a little bit of time investigating this a bit more tomorrow? We'd need a more accurate plan if we want to dive into this.
Keep in mind that this has to fit within a calendar week of work, so you may want to split this into multiple steps and we can follow up on our next refactoring.

So this function signature would be valid Go, I'll try to complete it and raise a prototype PR at least.
func ReconcileObject[G client.Object](ctx context.Context, obj G, client client.Client) result.ReconcileResult {

}

So having worked through this a little, I managed to arrive at the following set of interfaces and functions that get us some of the way there:
type Reconcilable interface {
	client.Object
	DeepCopy()
	DeepCopyInto(out *client.Object)
}

func ReconcileObject[G Reconcilable](ctx context.Context, desiredObj G, client client.Client, requeueDelay time.duration)
...
var currentObj &G
	err := client.Get(ctx, objectKey, currentObj)
	if err != nil {
...
}

This doesn't quite work. The problem is that I can't do var currentObj &G. We may need to provide instead:
func ReconcileObject[G Reconcilable](ctx context.Context, desiredObj G, currentObj G, client client.Client, requeueDelay time.duration) result.ReconcileResult {

This still doesn't get us the whole way there either. Maybe something to do with the new(G) function can be used to avoid the extra argument. But even when I try approaches around that, I hit more issues on the line desiredObj.DeepCopyInto(currentObj). That line throws me back cannot use currentObj (variable of type *k8sResource) as *client.Object value in argument to desiredObj.DeepCopyInto: *k8sResource does not implement *client.Object (type *client.Object is pointer to interface, not interface).
I'll play some more with this tomorrow, but I still can't say with certainty that what I'm proposing will work.

Hitting a new problem with the interfaces now. It looks like there is a problem when you try to express that an interface has a function which returns a type that fulfils an interface.
So for example:
type k8sResource interface {
	client.Object
	annotations.Annotated
	DeepCopy() *client.Object
	DeepCopyInto(out *client.Object)
}

Has a type DeepCopy() *client.Object which always returns types which fulfil *client.Object.
But when we try to use a corev1.ConfigMap{} as a k8sResource like so:
func Test_Reconcile_ObjectCreateSuccess(t *testing.T) {
        desiredObject := corev1.ConfigMap{}
	dc := testutils.NewCassandraDatacenter("test-dc", "test-namespace")
	fakeClient := testutils.NewFakeClientWRestMapper() // Reset the Client
	recRes := ReconcileObject(ctx, &desiredObject, currentObj, fakeClient, requeueDelay)
}

We get an error, because the compiler isn't smart enough to realise that ConfigMap fulfils client.Object and does indeed have a DeepCopy() *corev1.ConfigMap method.
cannot use &desiredObject (value of type *"k8s.io/api/core/v1".ConfigMap) as k8sResource value in argument to ReconcileObject: *"k8s.io/api/core/v1".ConfigMap does not implement k8sResource (wrong type for method DeepCopy)
		have DeepCopy() *"k8s.io/api/core/v1".ConfigMap
		want DeepCopy() *"sigs.k8s.io/controller-runtime/pkg/client".Objectcompiler[InvalidIfaceAssign](https://pkg.go.dev/golang.org/x/tools/internal/typesinternal#InvalidIfaceAssign)

Having done a bunch more research last night, It looks like the issues we have here are all to do with the fact that DeepCopy and DeepCopyInto are both methods with pointer receivers, there might be a solution as described here, I'll continue investigating. It does look like we'll need type parameters to make this work.

I can't progress this at the moment. I'll ask questions on Stack Overflow (oh the ignominy 😔) and see if someone external can helm me figure out why it isn't working.

I'm bailing on a completely generic reconciliation function for now. I can't get either generics or interfaces to behave the way I expect due to issues with pointer receivers and the like.
I will try to get a general configmap reconciler working in the short term, that will still eliminate a few hundred lines of code.


button/option to move files according to the group folder column

DB folder already supports to move files into folders when I change a value from within the database. However, when I manually change the property, I need to reselect the value of each file to move it to the specific folder. I do see the change in the database of course, but the file is then in the wrong group folder.
Describe the solution you'd like
It would be cool to have a button or command to update the grouping of files with one click.

Hi @ko13 . I think it's reasonable
Will be added to the roadmap


revised datagetter to accept more models matching to historical

<Please replace this paragraph by a description of what this PR does and alter the TODO-list below to what applies here. Please make a 'draft PR' to begin and then only mark it as ready for review once all the relevant points are done.>

[ ] Tests added
[ ] Documentation added
[ ] Example added (in the documentation, to an existing notebook, or in a new notebook)
[ ] Description in CHANGELOG.rst added (single line such as: (`#XX <https://github.com/benmsanderson/METEOR/pull/XX>`_) Added feature which does something)

@benmsanderson , I can't do a review apparently since I opend the PR, however, I've had a look. The code changes look ok. I am not entirely sure we would want that many input datasets laying around, but maybe we do?


Issue 62/file reorg

Attempt to solve https://github.com/rewin123/space_editor/issues/62
This branch extracts prefab and editor registry crates to a workspace containing crates folder. As a consequence, some other crates were created, like undo and shared.
Another significant change has been move all optional crates to a Modules folder in the workspace. Currently the only crate located in modules is bevy_xpbd_plugin.

I'm tempted to try<EMAIL_ADDRESS>to fix this lints 😬


[Bug] 无法使用双卡的显存来共同加载一个模型

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.

Describe the bug
我想用 2 张 4090 来部署 Qwen/Qwen2-72B-Instruct-AWQ 模型，在 Ollama 上大概 40 GB 显存就能跑，vLLM 上大概要 44 GB 以上，而 lmdeploy 似乎没有办法。
Reproduction
我已经尽量把所有参数都设成最小值了：
lmdeploy serve api_server Qwen/Qwen2-72B-Instruct-AWQ --model-format awq --tp 2 --max-batch-size 1 --cache-max-entry-count 0.01 --session-len 1 --cache-block-seq-len 1 --quant-policy 4

Environment
sys.platform: linux
Python: 3.11.9 (main, May  4 2024, 13:19:27) [GCC 11.4.0]
CUDA available: True
MUSA available: False
numpy_random_seed:<PHONE_NUMBER>
GPU 0,1: NVIDIA GeForce RTX 4090
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 12.4, V12.4.131
GCC: gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
PyTorch: 2.2.2+cu121
PyTorch compiling details: PyTorch built with:
  - GCC 9.3
  - C++ Version: 201703
  - Intel(R) oneAPI Math Kernel Library Version 2022.2-Product Build 20220804 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v3.3.2 (Git Hash 2dc95a2ad0841e29db8b22fbccaf3e5da7992b01)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - LAPACK is enabled (usually provided by MKL)
  - NNPACK is enabled
  - CPU capability usage: AVX512
  - CUDA Runtime 12.1
  - NVCC architecture flags: -gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_90,code=sm_90
  - CuDNN 8.9.2
  - Magma 2.6.1
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=12.1, CUDNN_VERSION=8.9.2, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -D_GLIBCXX_USE_CXX11_ABI=0 -fabi-version=11 -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOROCTRACER -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-stringop-overflow -Wsuggest-override -Wno-psabi -Wno-error=pedantic -Wno-error=old-style-cast -Wno-missing-braces -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=2.2.2, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=1, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF, USE_ROCM_KERNEL_ASSERT=OFF,

TorchVision: 0.17.2+cu121
LMDeploy: 0.5.0+
transformers: 4.42.4
gradio: 3.50.2
fastapi: 0.111.1
pydantic: 2.8.2
triton: 2.2.0

Error traceback
Fetching 21 files: 100%|███████████████████████████████████████████████| 21/21 [00:00<00:00, 14030.01it/s]
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
Convert to turbomind format:   0%|                                                 | 0/80 [00:00<?, ?it/s]Traceback (most recent call last):
  File "/home/ps/.pyenv/versions/lmdeploy/bin/lmdeploy", line 8, in <module>
    sys.exit(run())
             ^^^^^
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/cli/entrypoint.py", line 43, in run
    args.run(args)
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/cli/serve.py", line 310, in api_server
    run_api_server(args.model_path,
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/serve/openai/api_server.py", line 1197, in serve
    VariableInterface.async_engine = pipeline_class(
                                     ^^^^^^^^^^^^^^^
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/serve/async_engine.py", line 189, in __init__
    self._build_turbomind(model_path=model_path,
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/serve/async_engine.py", line 234, in _build_turbomind
    self.engine = tm.TurboMind.from_pretrained(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/turbomind/turbomind.py", line 342, in from_pretrained
    return cls(model_path=pretrained_model_name_or_path,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/turbomind/turbomind.py", line 144, in __init__
    self.model_comm = self._from_hf(model_source=model_source,
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/turbomind/turbomind.py", line 259, in _from_hf
    output_model.export()
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/turbomind/deploy/target_model/base.py", line 283, in export
    self.export_misc(bin)
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/turbomind/deploy/target_model/base.py", line 314, in export_misc
    self.export_weight(emb, 'tok_embeddings.weight')
  File "/home/ps/.pyenv/versions/3.11.9/envs/lmdeploy/lib/python3.11/site-packages/lmdeploy/turbomind/deploy/target_model/base.py", line 229, in export_weight
    torch_tensor = param.cuda().contiguous()
                   ^^^^^^^^^^^^
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 2.32 GiB. GPU 1 has a total capacity of 23.65 GiB of which 1011.56 MiB is free. Including non-PyTorch memory, this process has 22.64 GiB memory in use. Of the allocated memory 0 bytes is allocated by PyTorch, and 0 bytes is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)

Why do you want to set the cache-max-entry-count to 0.01?

Why do you want to set the cache-max-entry-count to 0.01?

To save memory. The weights will take about 90% of the memory, there isn't another 50% for the cache.

I found a solution from a video:
lmdeploy convert --model-format awq --group-size 128 --tp 2 qwen Qwen/Qwen2-72B-Instruct-AWQ

It's weird that lmdeploy convert is not documented.

It's weird that lmdeploy convert is not documented.

https://lmdeploy.readthedocs.io/en/latest/inference/load_hf.html#a-model-converted-by-lmdeploy-convert

It's weird that lmdeploy convert is not documented.

https://lmdeploy.readthedocs.io/en/latest/inference/load_hf.html#a-model-converted-by-lmdeploy-convert

However, it doesn't mention that the model needs to be converted using --tp 2. Other LLM serving engines can use a normal model when serving with --tp 2.

I tried this command to achieve maximum performance, and it is about 25% faster than vLLM.
lmdeploy serve api_server ./workspace --model-format awq --tp 2 --max-batch-size 32 --session-len 2048 --cache-max-entry-count 0.45 --quant-policy 8 --enable-prefix-caching

Using "--quant-policy 4" is about 30% faster than vLLM, but I haven't test its accuracy loss.
The disadvantage is the lack of eager mode. In order to serve long contexts like 8192 tokens, I have to reduce "--cache-max-entry-count" to 0.2, which results in poorer performance (almost the same performance as vLLM).
There is an option named "--max-seq-len-to-capture" in vLLM, so that when handling long contexts, it can fall back to eager mode to avoid OOM.

My initial human evaluation shows that Q8 quantization and Q0 quantization are almost identical in accuracy, while Q4 is slightly worse. However, in processing texts of around 1k tokens, Q4 is approximately 30% faster than Q8.

I will optimize the accuracy of KV Cache Int4 recently, please stay tuned.


Lowercase promise in README

This has got me for a while...

👍 Thanks for that! (and shame on me)


area() collider with rotate

So I know that rotate doesn't work with the area collider. I have a image of a sword and I am rotating it. I need to check for collisions with the sword and other game objects. Is there any other method of doing this (without using area collider). I need it badly for my game.

This is what I'm trying to achieve-
https://user-images.githubusercontent.com/66850133/138370994-d3149e59-834f-46e2-9eb1-3069f568e7b1.mp4

In the meantime, could there be a link from the docs for area() to the context on what doesn't work? It's off-putting to just see it "doesn't work" and not have any idea what will happen if you happen to need rotate and collide on the same object.
For instance, will the current behavior get close enough to what you'd want in some cases? It looks like Inspect mode will show you whatever collision area it's currently using, and https://github.com/replit/kaboom/issues/157#issuecomment-907729629 has some ideas for better collision detection?

I ended up using a custom collision function that basically gets a bunch of lines from the sword base to the sword tip, and checking them against the other enemies.