Cannot add Authorization header

It is impossible do define custom Authorization request header:
            HttpBuilder.configure {
                request.uri = url
                request.headers['Authorization'] = "Bearer ${token}".toString()
            }.put()

It seems problem is in underlying URLConnection: https://stackoverflow.com/q/2026260

If the problem is in the UrlConnection we probably won't be able to do anything about it. Can you use the Apache or OkHttp client implementation instead?

I have found out that the header is actually send, just URLConnection.getRequestProperties() does not return it so it is not logged by JavaHttpBuilder. Probably due to security reasons.


Emulator displays all of a turn's messages at the same time

Version
4.12.0
Describe the bug
When Emulator sends a request to the bot, it waits for an HTTP response before it updates the UI with all the messages the bot sent to the Emulator
To Reproduce

Run a bot that sends multiple messages in one turn with a delay between them
Connect to the bot in Emulator
Observe that the messages are all displayed at the same time

Here is some Python code that can reproduce the problem. Note that the problem is not Python-specific, and can be reproduced with any language.
async def on_message_activity(self, turn_context: TurnContext):
    start = time.time()

    elapsed = time.time() - start
    print(f"Message received after {elapsed:.1f} seconds")
    await turn_context.send_activity(f"Message received after {elapsed:.1f} seconds")

    await asyncio.sleep(2)

    elapsed = time.time() - start
    print(f"Finished after {elapsed:.1f} seconds!")
    await turn_context.send_activity(f"Finished after {elapsed:.1f} seconds!")

Expected behavior
Emulator should display messages immediately as it receives them, the same as any channel.
Screenshots
This is the problem in Emulator:

Here you can see that the print statements are displayed at the right time while the send_activity statements aren't:

This is the correct behavior in Web Chat (which can be seen in any other channel as well):

Additional context
Related Stack Overflow thread: https://stackoverflow.com/questions/67172737/botbuilder-display-message-while-waiting-for-blocking-function
[bug]

Related https://github.com/microsoft/BotFramework-Emulator/issues/2206


Namespaces

Ruby uses redis-namespace to partition a single redis store among multiple apps using the default queue. Technically namespaces are an anti-pattern because it's now possible to create many different queues; however, many companies (including the one I work for) is using redis-namespace with sidekiq. It's certainly a "if it ain't broke, don't fix it thing" so we haven't. Others too.
I think we can add this in two places:

Make this lib aware of namespaces and use a namespaced key for every redis operation. This works but it's a bit clunky.
Add support to rust redis for namespacing, or put a shim around the redis connection to be namespaced. This feels a bit heavy handed.

It would be easier to implement (1) but (2) would be preferred.

I think the best solution is going to be a custom redis connection wrapper. I can reimplement the bb8_redis crate in the sidekiq lib to wrap the common commands used and set a namespace for each key. This may cause more allocations but it should be fairly swappable. I have a pretty broken branch with this implemented, and I'll have a PR up soon. cc @justmark

This has been released, along with a bb8 upgrade, a new namespaced example, and a bunch more docs in the README in version 0.6.0.


requiring json file issue

The file comes in like:
import filename.json from './filename.json'
instead of
import filename from './filename.json'

Should be fixed


Implementing a new recipe

What are the modifications needed to be able to implement LSTM as an example ?

hidden_layer_type  : ['TANH', 'TANH', 'TANH', 'TANH', 'TANH', 'TANH']
#if RNN or sequential training is used, please set sequential_training to True.
sequential_training : False

You need to change hidden_layer_type as shown below:
hidden_layer_type  : ['LSTM', 'LSTM']
hidden_layer_type  : ['RNN', 'RNN']
hidden_layer_type  : ['RNN', 'RNN', 'LSTM', 'BLSTM']
hidden_layer_type  : ['TANH', 'TANH', 'LSTM', 'GRU']
hidden_layer_type  : ['TANH', 'TANH', 'SIGMOID', 'SIGMOID', 'SLSTM', 'BSLSTM']
(SLSTM is simplified LSTM for fast-training)

You need to set the variable sequential_training to True
sequential_training : True

Okay Thanks ronanki , i will try it now.

Are there any explanation in how to decide the number of layers and nodes?

No -- you can experiment with them.


Add docker-compose project to run all apps

With docker-compose we now setup it as startup project and run it from Visual Studio. It will spin up both apps todoapi and todo-web-server plus jaeger and prometheus.

I like the docker compose idea but there are a few things I don't like:

Why is there a specific open telemetry section instead of just using the config entries for individual providers as a signal that they should be turned on?
Why do we need 3 docker-compose.yaml, docker-compose override.yml, and docker-compose.dcproj. Can we make this work with a vanilla call to docker compose up without the VS tooling support in there?
Why is there a new launch settings file?
Why is Microsoft.VisualStudio.Azure.Containers.Tools.Targets a dependency at all? I'd like this to not be a part of the project.

Overall, I love the idea, but I'd like it to be a bit less VS specific.

@davidfowl, thanks for the inputs. Please see all my replies below.

Why is there a specific open telemetry section instead of just using the config entries for individual providers as a signal that they should be turned on?

I've fixed it —no reason for it to be there.

Why do we need 3 docker-compose.yaml, docker-compose override.yml, and docker-compose.dcproj. Can we make this work with a vanilla call to docker compose up without the VS tooling support in there?

Visual Studio created it. I've removed all the VS-specific ones and left a single vanilla docker-compose.yaml.

Why is there a new launch settings file?

This one was specific for the project docker-compose.dcproj. Visual Studio treats it like a csproj file.

Why is Microsoft.VisualStudio.Azure.Containers.Tools.Targets a dependency at all? I'd like this to not be a part of the project.

Removed. It was added by VS automatically when I added docker support.

This is looking pretty good! A few more questions!

You know I'm going to ask you to also do the same for tye.yml when you're done 😉

Does anyone know if it's possible to use Docker compose with the new .NET SDK integration for building docker images without a Dockerfile?
If this were possible with Docker Compose, it would maybe be great to use it here since it's so much simpler if you don't have to keep Dockerfiles up to date.

'm going to ask y

It'll be my pleasure!

Does anyone know if it's possible to use Docker compose with the new .NET SDK integration for building docker images without a Dockerfile?

Yes, it's possible. You will need to run dotnet publish --os linux --arch x64 /t:PublishContainer -c Release to build your local image first, then you can run your docker-compose file.
I might add this change to this PR.

@cwe1ss @davidfowl I've removed the docker files and updated the docker-compose to run both images created via dotnet publish.

@cwe1ss @davidfowl I finished all the pending changes. Please let me know if you are okay with the PR as it is now.

Amazing changes. Thanks @LuizFDS !


Wrap in UMD modules so AMD-reliant people can use this too

My work environment requires (pardon the pun) us to use a requireJS-style AMD loader.  Using UMD should allow CJS and AMD people to work with the same code.

@MikeMcElroy It's interesting that you're doing this in babelrc. Can you point me to some documentation about what this is actually doing?
I would've expected this to be in the webpack config instead?

Closing this unless I hear back from you.


[BUG]

Describe the bug
The following function call raised ValueError, see action
from diff_binom_confint import compute_confidence_interval

compute_confidence_interval(2, 2, conf_level=0.975, method='witting')

OS: Ubuntu 22.04.4
Python Version: 3.12.4
Numpy Version: 2.0.0
Numba Version (optional): 0.60.0

This error is not reproduced using the docker image built with the following Dockerfile
FROM ubuntu:22.04

ENV DEBIAN_FRONTEND=noninteractive

# check distribution of the base image
RUN cat /etc/issue

# check detailed system version of the base image
RUN cat /etc/os-release

RUN apt update && apt upgrade -y
RUN apt install software-properties-common -y
RUN add-apt-repository ppa:deadsnakes/ppa -y
RUN apt update
RUN apt install python3.12 -y
RUN apt install curl -y
RUN curl -sS https://bootstrap.pypa.io/get-pip.py | python3.12

RUN ln -s /usr/bin/python3.12 /usr/bin/python && ln -s /usr/bin/pip3.12 /usr/bin/pip

RUN python --version
RUN pip --version

RUN pip config set global.index-url https://pypi.tuna.tsinghua.edu.cn/simple

RUN python -m pip install numpy==2.0.0
RUN python -m pip install numba==0.60.0
RUN python -m pip install pandas deprecate-kwargs Deprecated scipy tabulate openpyxl

Test action with this potential error case also passed.

The witting method is stochastic, hence has a small probability to cause errors:
from diff_binom_confint._binom_confint import _pbinom_abscont, _pbinom_abscont

p, size = 0.975, 100000
x = size + 0.98
_qbinom_abscont(p, size, x)

will result in ValueError: f(a) and f(b) must have different signs from scipy.optimize._zeros._brentq, which can be checked by
_pbinom_abscont(x, size, 1) - p, _pbinom_abscont(x, size, 0) - p


Issue 288 javafx windows10

Updated README to mention JDK 11 instead of 8

Please remove the .idea directory that’s included in this PR and ignore it in .gitignore.

On Jun 10, 2019, at 07:21, Hector Salazar<EMAIL_ADDRESS>wrote:
Updated README to mention JDK 11 instead of 8
You can view, comment on, or merge this pull request online at:
https://github.com/oktadeveloper/okta-aws-cli-assume-role/pull/310
Commit Summary
updated to javafx
Removed reference to broken protocol handler
Fixed compile errors by updating Maven pom to use the openjavafx libraries without runtime scope
Bugfix: set the rolesArn's as key and principalArn's as value when parsing the available roles from the SAML token. The bug was that they were inverted and AWS STS refused the call because the role name was invalid.
Added IntelliJ idea build configurations.
previous logic was assuming that always was refreshing a previous session and cookies were in place.
Fixed crash if no command line options were provided after okta command
Created IntelliJ run configurations for list roles and sls commands
Fixed maven broken dependency on javafx pom
Disabled test tied to an specific AWS account
Fixed bug in roles list parsing after bugfix to set the role arn and name in the RoleOption entity for the roles selection menu.
Set openjdk11 in CI/CD
Updated documention to update JDK mentions to version 11 or later
File Changes
M .gitignore (55)
A .idea/.name (1)
A .idea/compiler.xml (13)
A .idea/encodings.xml (6)
A .idea/misc.xml (14)
A .idea/runConfigurations/ListOktaRoles_JDK11___list_roles.xml (18)
A .idea/runConfigurations/OktaSLS_JDK11.xml (17)
A .idea/runConfigurations/WithOkta_JDK11.xml (17)
A .idea/runConfigurations/WithOkta_JDK12.xml (11)
A .idea/vcs.xml (6)
M .travis.yml (2)
M Readme.MD (2)
M pom.xml (51)
M src/main/java/com/okta/tools/WithOkta.java (9)
M src/main/java/com/okta/tools/helpers/RoleHelper.java (2)
M src/main/java/com/okta/tools/io/LoginPageInterceptingProtocolHandler.java (31)
M src/main/java/com/okta/tools/io/SubresourceIntegrityStrippingHack.java (3)
M src/main/java/com/okta/tools/saml/AwsSamlRoleUtils.java (2)
M src/main/java/com/okta/tools/saml/OktaAppClientImpl.java (9)
M src/main/java/com/okta/tools/saml/OktaSaml.java (8)
A src/main/main.iml (11)
M src/test/java/com/okta/tools/RoleHelperTest.java (1)
A src/test/test.iml (12)
Patch Links:
https://github.com/oktadeveloper/okta-aws-cli-assume-role/pull/310.patch
https://github.com/oktadeveloper/okta-aws-cli-assume-role/pull/310.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@hecsalazar Please resolve conflicts in this PR.


Predicate Condition

Added predicate entity condition to check for predicates.

Turns out it's possible lol

Technically speaking, you could also add a predicate condition for blocks, damage, and items, but that's for another time


[MM-59823] Migrate BrowserView to WebContentsView

Summary
A while back, Electron implemented BrowserView as an experimental way of nesting sandboxed Chromium views inside of a main windows, replacing webview. However, for the longest time that functionality remained experimental and not fully supported.
This PR migrates us over to the new WebContentsView, introduced in Electron 30 which should be more stable and supported. It should also simplify resizing logic.
Ticket Link
https://mattermost.atlassian.net/browse/MM-59823
NONE

/update-branch

@enahum Gentle ping for review :) let me know if I need to re-assign

Sorry was not in my radar, I can give it a review in about 12h or so


Glitches in display when using arrow keys

[X] I am on the latest Hyper.app version

[X] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10

Hyper.app version: 1.0.0

The issue is reproducible in vanilla Hyper.app: Yes

Issue
When using the arrow keys to navigate a current command, hyper display is glitching from time to time, the code is correct though if you know where your cursor should actually be.

I've actually experienced a similar issue in the default Terminal.app...
this may be an issue with oh-my-zsh, i'd check their repo for possible duplicate issues

Related to #1174, #1180. Possibly fixed by https://github.com/Tyriar/pty.js/issues/10.

Hey there, please try again with the new Hyper v2 release and open a new issue if the problem stills exists. Thank you!


Use Google Analytics 4 (GA4) IDD

Contributes to #22

/cc @nate-double-u

This was achieved through the GA UA to GA4 migration process. So this could probably be closed.

This was achieved through the GA UA to GA4 migration process. So this could probably be closed.

Hi @erikbledsoe - no, this was part of the migration process, but it didn't get merged, and so the migration isn't complete.
The website has active GA4 tags in use (but not the CNCF tag), so either someone set them up or they were the ones that Google automatically created.
/cc @caniszczyk

@chalin Ah, my bad. Didn't realize that was the CNCF tag.
@edsiper can you merge this?

merged, thanks!

Thanks @edsiper and @erikbledsoe. As mentioned in

#22

... the docs also need to be updated to use G-93T2VC0VBC. The site is "powered by GitBook". Can one of you change the GA ID being used by that site?

@edsiper @erikbledsoe - the same is true of the pending task (relative to the GitBook docs subdomain) mentioned in:

https://github.com/fluent/fluentd-website/issues/243

Can you here there as well?

@chalin I just tried adding a second Google tag into the GitBook GA plugin (on the Fluent Bit site) and it seems not to work—it stopped sending any data. I couldn't find any documentation to suggest that it would (or wouldn't), but I thought I'd try.
Perhaps we could combine the two tags? I've never tried that; do you have experience with it?

@erikbledsoe - right, I'm not surprised that you couldn't add more than one site tag.
Yes, I can connect other site tags to the main CNCF one. I used that feature during GA4 migration to link back to UA properties.
Which IDs would you like me to connect to?

@chalin
G-GJ6DCMDH4N

Done: connected. Can you try again? Thanks @erikbledsoe


Refactor current location

This PR fixes #501 #502 and #503 along with a couple of other unreported bugs that the current location exhibited.
For the problems we were facing, refactoring to use Observables seemed like the right fit. Essentially we want the ability to stream location and permission updates in order to display the correct interface on the map. For example:

when location permission is restricted, we should not be displaying the moveToLocation icon.
when location permission is authorized, we should automatically retrieve it to avoid another round trip when the user triggers moveToLocation.
when location permission is denied or undetermined, we should prompt the user for their permission then stream location updates if authorized.

As a result I have created lib/geolocation which exposes passiveLocationStream and activeLocationStream to enable us to subscribe to a stream of LocationStatus values. LocationStatus can be one of the following:
Authorized + Awaiting
Authorized + Tracking(x, y)
Authorized + Error
Checking
Denied
Requesting
Restricted (only applies to Android users who request to never be asked)
Undetermined

passiveLocationStream automatically streams location updates if permissions allow this to be done without prompting the user. For example the output may be:
|-A---B---C---D---E

Where:
A = Checking
B = Authorized + Awaiting
C = Authorized + Tracking(1, 1)
D = Authorized + Tracking(1, 2)
E = Authorized + Error

activeLocationStream will prompt the user to authorize accessing location information. If authorized it will automatically stream location updates. For example the output may be:
|-A---B---C---D---E

Where:
A = Requesting
B = Authorized + Awaiting
C = Authorized + Tracking(1, 1)
D = Authorized + Tracking(1, 2)
E = Authorized + Error

The user is prompted between the A and B values.
Tester check-list

[ ] Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):

[ ] Galaxy S8 (Android 7.0/8.0)
[ ] Galaxy S7 (Android 6.0)
[ ] iPhone X (iOS 11.x)
[ ] iPhone 8 (11.x)
[ ] iPhone 7 (iOS 10.x)

Optional:

[ ] Google Pixel 2
[ ] Galaxy S8 Plus
[ ] Galaxy S7 Edge
[ ] Galaxy S6
[ ] iPhone 7+
[ ] iPhone 6

Accessibility Testing (If applicable)

[ ] Text-to-Voice (Android: Voice Assistant / iOS: Speak Selection)
[ ] Large Text (=<200%)
[ ] Landscape Screen orientation

Weak connection testing (If applicable)

[ ] Airplane mode
[ ] 2G/3G Network Settings

Installing the build after syncing with master fixed the empty settings issue.

My comments aren’t related to this PR as I’ve been able to reproduce them in master. This was my first time trying the location and the issues were quite jarring.

@markholland Would the following behavior do what you expect:
New app (no permission preference):
click location button
-> prompt for permission
-> user denies permission
-> location button disappears + Does not navigate to user

Existing app with denied permission
click location button
-> prompt for permission
-> user deny permission
-> location button disappears + Does not navigate to user

If so, when would you ever expect to be taken to the permission screen?

@RGBboy Why would the location button disappear?
Ok, I think I'm understanding the decision here. A pop up of our own before taking me to settings would be better though and obviously out of scope of this PR.
The main issue is that denying permission still takes me out of the app.

This is partly to do with the face that Android has an extra permission state, Restricted, that iOS doesn't. This is the value Android returns when a user chooses never to ask again.
I think we have a few options to make this better:

Transform the Denied message to a Restricted one when listening to the activeLocationStream. This would mean when a user denies access, the location button disappears and they will not be able to select it again. However, if the user navigates away from the map and back again, they will be presented the navigate to location button again. If they then click the navigate to location they would then be taken to the settings screen.

We remove taking iOS users to the settings screen. Instead, they would just be presented with the same option pop up when pressing the navigate to location button. Even if the user denies access, the button remains pressable.

A combination of the above. Remove taking iOS users to the settings screen and also map the denied to restricted for activeLocationStream. This would mean that users that deny the pop up will not be presented the button. However when they navigate away and back to the map it will show again, and present the pop up again if pressed.

Personally I think the last option is actually the better of the three. We only ask if they intended. And no longer take them away from the app.

Just been looking at this a but deeper and the behaviour on the two platforms has some further difficulties. On iOS, if a user has denied access, they will no longer see a pop up ever. Hence why we were navigating to the settings screen. Android however has three options, Authorized, Declined and Restricted. Authorized grants us access, declined means we need to ask again via pop up, and restricted means we never ask.

Hopefully I have addressed the major problem on iOS now. I have moved the Linking to settings screen into the geolocation lib. This will now happen if both the passiveLocationStream, and the activeLocationStream return denied (indicates that the user has denied access via pop up). This needs thorough testing on Android because some status remapping may affect that platform.

The behavior on iOS is what I would expect but the copy of the dialogue when not allowed could be better and include a indication of what needs to be done for it to work rather than "try again later" which will never help.

My latest changes address the copy in the dialog problem. We now present the user a choice to go to the settings screen if they have previously denied access. The other dialog will still show if the users location is authorized, but we can not get it for some technical reason and they click the navigate to location marker.


Allow all functions in a channel to see the socketId

Breaking change. Could be done in a none breaking way, by adding new operators to allow code to opt-in to see the socketId, but adds considerable complexity.
Added a SocketInfo record to wrap the SocketId, to allow more information about the socket to be added at a later date without a breaking change.

Awesome, thanks a lot


Error Code Explanation for unsupported /$value Calls

Solves #270

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: BirgitBoss:white_check_mark: sebbader-sap:x: monsieuremreYou have signed the CLA already but the status is still pending? Let us recheck it.

Why is it directly merged into main? It is V3.1, no? It should be IDTA-01002-3-1_preparation, no?

Why is it directly merged into main? It is V3.1, no? It should be IDTA-01002-3-1_preparation, no?

indeed!


Allow disabling messages at end of line

Is there any option to disable 'message' at end of line?
I would like to see just colored background and gutter icon. Text mixed into my code confuse me.
Message can be then displayed on mouseover on icon or li.

"workbench.colorCustomizations": {
    "errorLens.errorForeground": "#fff0",
    "errorLens.errorForegroundLight": "#fff0",
    "errorLens.warningForeground": "#fff0",
    "errorLens.warningForegroundLight": "#fff0",
    "errorLens.infoForeground": "#fff0",
    "errorLens.infoForegroundLight": "#fff0",
    "errorLens.hintForeground": "#fff0",
    "errorLens.hintForegroundLight": "#fff0",
}

OK, this can be done this, complicated, way. Thanks

Ok, closing then.


TypeError: Cannot use 'in' operator to search for '$ne' in 123

Hello:
in pouchdb-find/lib/adapters/local/utils.js in messageSelector
function massageSelector(input) {
...
    if (typeof matcher === 'string') {
      matcher = {$eq: matcher};
    } else if ('$ne' in matcher && !wasAnded) {
...
}

I receive the above error.  matcher is an integer in this case, 123--and it barks.  Tips?  Thanks!

Can you provide your code that caused the error?

// debuggins.js
'use strict';

var PouchDB = require('pouchdb');
PouchDB.plugin(require('pouchdb-find'));

var p = new PouchDB('./test');
p
    .post({a: 123})
    .then(function() {
        return p.find({selector: { a: 123 } });
    })
    .then(console.dir)
    .catch(console.dir);

Oh yeah, my bad. That's a bad bug.

fixed by b180b6fd904cc00b9ce9420d1cef33f827856766 and released in the latest version

:+1: !  when i first saw that pouch.query was moving to a plugin, I grumbled a bit, but in retrospect, i think this is a much cleaner interface!  much appreciated!

glad ya like it :)


Add TGI monitoring guide through Grafana and Prometheus

As per title. It is very useful.

@Narsil @drbh I lost the approval.
I updated the image and the recommended JSON, it's very nice, thank you! https://moon-ci-docs.huggingface.co/docs/text-generation-inference/pr_1908/en/basic_tutorials/monitoring


SWARM-1100: Swarmtool should support specifying additional dependencies

Motivation
Swarmtool supports specifying additional fractions. In the same vein,
it should support specifying additional dependencies for things
like JDBC drivers.
Modifications
Added a cmdline option -d/--dependencies to Swarmtool. The option takes
a list of Maven GAVs and adds each of them as a "declared dependency",
similarly to how Swarm Maven plugin works.
Result
Swarmtool is now able to produce uberjars that contain JDBC drivers
that are detected by Swarm.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you created a JIRA and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[x] Have you built the project locally prior to submission with mvn clean install?

ok to test


fix(generate): optional types are now set as pointers to prevent unused fields in data when using json

Description
When marshalling and unmarshalling json documents, fields with the tag omitempty were being instantiated and lingering in the document. In order to resolve this generate has been updated to add * indicating a pointer for all non-required fields.

fix(generate)!: now uses pointers for optional fields.

effects all existing types.
Ignores primitives.

Related Issue
#131
Type of change

[x] Breaking bug fix.

Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

Created test lula branch with the updates applied and tests passing as example of how the changes would effect lula.
https://github.com/defenseunicorns/lula/tree/test_go-oscal_pointers

Lula test PR: https://github.com/defenseunicorns/lula/pull/317

Reviewing this more and reading through a proposal that helps me understand the implications here and why pointers are required.

Bumping back to draft to handle #174 as part of this PR.


Dashboards disappeared

Description

DBeaver Version
23.1.3
Operating System
win10
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Verified


dart pub package is not up to date

I didn't see certain options available with the pub package that are available with the git repo, like the animation options. Just a heads up

+1

+1

Check it now, the package is updated


Move scipy dependency into scipy_utils to raise error properly

Signed-off-by: Kaiyuan Hu<EMAIL_ADDRESS>

Codecov Report

Merging #1236 (fa7c885) into main (9318682) will increase coverage by 0.00%.
The diff coverage is 60.00%.

:exclamation: Current head fa7c885 differs from pull request most recent head 0dd6ad9. Consider uploading reports for the commit 0dd6ad9 to get more accurate results

@@           Coverage Diff           @@
##             main    #1236   +/-   ##
=======================================
  Coverage   68.59%   68.60%
=======================================
  Files         253      254    +1
  Lines       12334    12338    +4
  Branches     2046     2046
=======================================
+ Hits         8461     8464    +3
- Misses       3342     3343    +1
  Partials      531      531

Impacted Files
Coverage Δ

towhee/utils/scipy_utils.py
50.00% <50.00%> (ø)

towhee/hub/builtin/operators/sklearn.py
84.74% <75.00%> (+2.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9318682...0dd6ad9. Read the comment docs.

/lgtm
/approve


Mirage not initialized on pre-RFC-232 test

The app has @ember/test-helpers installed, but uses RFC-232-style only for a small fraction of its tests.
There are lots of tests that look like
import { moduleFor, test } from 'ember-qunit'
import { getOwner } from '@ember/application'
import initializeMirage from 'my-app/initializers/ember-cli-mirage'

moduleFor('foo:bar', 'Integration: foo:bar test', {
  integration: true,
  beforeEach() {
    initializeMirage(getOwner(this))
    server.doSomething()
  }
})

On mirage 0.3.4, these tests work fine.
On mirage 0.4.7, in each such tests, server is undefined. As best I can trace the logic,

ember-test-helpers legacy test-module calls super
legacy abstract-test-module calls setContext
other stuff happens…
beforeEach calls the initializer
initializeMirage calls _shouldUseMirage
_shouldUseMirage calls getRfc232TestContext to see whether it can get an RFC-232-style test context
get-rfc-232-test-context calls require.has to determine whether @ember/test-helpers exist in the app. In this case, they do.
get-rfc-232-test-context calls getContext, returning the context from the initial setup

That is, I believe getRfc232TestContext() is not a valid proxy for is this test RFC-232-style?

Gotcha, so we need to make the initializer more intelligent about whether it's being run in an RFC 232 test or not, correct?

I looked into this and things seem to be working as expected. If you are able to change how you're manually starting Mirage in your integration tests to follow the cookbook entry in the guide
// tests/integration/components/your-test.js
import { startMirage } from 'yourapp/initializers/ember-cli-mirage';

moduleForComponent('your-component', 'Integration | Component | your component', {
  integration: true,
  beforeEach() {
    this.server = startMirage();
  },
  afterEach() {
    this.server.shutdown();
  }
});

then everything should work.
Could you try that and let me know how it goes? Also, do you remember where you got the initializeMirage(getOwner(this)) snippet example from? (I am planning on clarifying how to start Mirage in different test setups in the new version of the docs.)

Our current (pre-RFC-232, mirage 0.3.4) code is
// tests/helpers/setup-mirage-for-integration.js

import mirageInitializer from '../../initializers/ember-cli-mirage'

export default function setupMirage(container) {
  mirageInitializer.initialize(container)
}

We have 25 tests that use that like so:
beforeEach() {
  startMirage()
}

When I run these on mirage 0.4.7, I get
TypeError: Cannot read property 'register' of undefined
    at Object.initialize (http://localhost:4201/assets/my-app.js:5967:21)
    at setupMirage (http://localhost:4201/assets/my-app.js:33375:29)

We also have 21 tests that do this:
beforeEach() {
  startMirage(Ember.getOwner(this))
}

On 0.4.7, those yield
ReferenceError: server is not defined     at Object.beforeEach (http://localhost:4201/assets/tests.js:33614:23)

import { startMirage } from 'my-app/initializers/ember-cli-mirage works on 0.3.4 and 0.4.7. Thanks for the tip!

Wonderful!


feat(tests): Add tests for bookmark and data storage on the network.

@joshuef So odd, I can't tell why this issue didn't come up before. All tests in Travis failing.
Failing locally for me on Linux VM.
When I change, https://github.com/maidsafe/safe_browser/blob/master/e2e/lib/setupSpectronApp.js#L37, to args : [ isTestingPackagedApp ? '' : path.join( __dirname, '..' , '..', 'app' , 'main.js') ],, then the tests pass locally.
Must be the same reason for the chrome not reachable issue.

just FYi, @hunterlester this is still a WIP, so you don't need to test it / check it yet.
I've got a whole lot of rebasing to do to make these commits palatable 😄
I've just PRd to see how CI is and so you can see the code incase it helps with your tests 👍

@joshuef Here's a branch that I created for your reference: https://github.com/hunterlester/safe_browser/tree/try-out
I rebased BookmarkTestss onto master and then tweaked the first test in safe-bookmark-login-out.spec.js to get it to pass. Take a look at the second test where I made progress but am ending the evening in the middle of an error that the test is throwing:
An element could not be located on the page using the given search parameters.
Usually a fairly simple error to resolve but I haven't spotted it yet.
Using this comparison of files, https://github.com/maidsafe/safe_browser/compare/master...hunterlester:try-out, you'll see notes I've left for you starting with JOSH.

Resolves https://github.com/maidsafe/safe_browser/issues/388

@joshuef Wow! Nice man. A big undertaking. Everything looking good. Just the usual Travis timing issues.

Also resolved #324


Buttons not clickable

I am not able to get past play button unless i press enter and even after that I can't press any button to start playing the game. :(

Here is the video:
https://drive.google.com/file/d/1PXinyNRdnEn_5FuOR3iB5tpEz87VKwhe/view?usp=sharing

Really strange. Even if the button hitboxes are offset from the window because of some monitor scaling factor problem, on the second screen, you should've hit something moving around. If you resize the window, does it help anything? If not, I can add some debug statements to print where the mouse is, where buttons get placed, etc

Yeah try that too.
On Thu, Jun 25, 2020, 21:10 Dustin Carlino<EMAIL_ADDRESS>wrote:

Really strange. Even if the button hitboxes are offset from the window
because of some monitor scaling factor problem, on the second screen, you
should've hit something moving around. If you resize the window, does it
help anything? If not, I can add some debug statements to print where the
mouse is, where buttons get placed, etc
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dabreegster/abstreet/issues/105#issuecomment-649631788,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APQBUC3W2GGF5TS6VSD76UDRYNVWLANCNFSM4OIHJDYQ
.

Rishit, could you please also try this:
Get past the screensaver by pressing enter, then get into sandbox mode by pressing s. Then once you're at the map, try clicking and dragging it. Does anything in the map respond to your mouse at all, or is it just all of the menus and buttons?

Someone by email hit the same problem and said this worked for them:
-opening the program
-then right clicking the program in the task bar at the bottom of the screen
-clicking game.exe
-Clicking Run
I have no earthly idea what's going on if this is indeed a workaround.

Pressing 's' works. It works on the sandbox. Seems to be a problem with the
menu.
On Thu, Jun 25, 2020, 22:42 Dustin Carlino<EMAIL_ADDRESS>wrote:

Rishit, could you please also try this:
Get past the screensaver by pressing enter, then get into sandbox mode
by pressing s. Then once you're at the map, try clicking and dragging
it. Does anything in the map respond to your mouse at all, or is it just
all of the menus and buttons?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dabreegster/abstreet/issues/105#issuecomment-649709279,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APQBUC7WMMEXQ4LRLIT2LDLRYOAOTANCNFSM4OIHJDYQ
.

Someone by email hit the same problem and said this worked for them:
-opening the program
-then right clicking the program in the task bar at the bottom of the screen
-clicking game.exe
-Clicking Run
I have no earthly idea what's going on if this is indeed a workaround.

Yeah, this works /|
|

Is this fixed? Because I switched the PC so I can't test on that PC.

I haven't changed anything to fix this problem, but also I've never been able to reproduce it. Since there's nothing actionable to do, I'll close the bug. If somebody new comes along and can reproduce it and help debug, we can reopen. Thanks!


No-op to rebuild

Signed-off-by: Justin Kulikauskas<EMAIL_ADDRESS>

Um...this PR doesn't have anything. 😆

That means it must be bug-free!

Well. This is new.

/approve

Tide must have some logic to not provide approval to PRs that don't do anything...

Well, I can force it to merge, and we'll see if it does the post-submit job (if not, shouldn't be an issue)


Burned collection still visible

Artist burned collextions: and they are still visible

kusama/rmrk2
https://kodadot.xyz/ksm/u/FSJkXLHuWYfB8DYejjFKX4bkFjb7dMt9RvVpq6D5LUQLY6x?tab=collections

link:

kodadot/rubick#278
https://github.com/kodadot/rubick/issues/279#issuecomment-1860730067


Store: fix error handling on limits

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
I noticed from running Thanos Store in production that limits were being hit quite often and this triggered an alert based on percentage of failed requests. A deep investigation allowed me to identify that the grpc codes for requests hitting limits made no sense: they were mostly "Unknown" and "Aborted". This motivated me to fix such logic.

Removed a test implementation of the series and samples limiter factories used in a test to test its own behavior.
Now such test uses the real implementation of such limiters.
Fixed the error handling from the limiters, allowing a proper gRPC status code to be returned when limits are hit: ResourceExhausted.

Verification
E2E tests changed and passing.

As always I forget to goimports my files 😭
Fixed in https://github.com/thanos-io/thanos/commit/60cf9a024769b40931d0154ca97647b3147630d8.

@fpetkovski from what I checked just now, yes. I can follow up with a PR fixing things around the limitedStoreServer. 😃


Adding envsetup to boostrap development env

https://github.com/nimblehq/elixir-templates/issues/8
What happened
Adding the bin/envsetup.sh and docker-compose.dev.yml to help new developer could boostrap the development env easily
Insight
Just using docker-compose.
Proof Of Work
1/ Start docker container

2/ mix test

3/ mix ecto.create

Good to add Docker Compose.
As for bootrapping the app, since by default there is no bin folder (contrary to Rails), I think we should use a Makefile instead. It's more standard and would not introduce a non-typical directory.

I have changed it to Makefile in f3b89c6 @olivierobert

What happened
Adding the bin/envsetup.sh and docker-compose.dev.yml to help new developer could boostrap the development env easily

Please update the PR description


Inaccurate info in "/workshop/content/30-python/20-create-project/500-deploy.md"

:bug: Bug Report
What is the problem?
in the workshop content page: https://github.com/aws-samples/aws-cdk-intro-workshop/blob/master/workshop/content/30-python/20-create-project/500-deploy.md#lets-deploy
it's stated that:

This is warning you that deploying the app entails some risk. Since we need to allow the topic to send messages to the queue and we are also creating an IAM User and granting access to the new Buckets

which is not accurate. we are note creating any IAM user/role. only updating the the SNS topic's Access Policy (I believe)

Thank you for submitting this issue.  Only the Python workshop contains this error, but the other languages, while not incorrect, aren't very clear about what's going on. The explanation should be more clear about what's really going on for every description.


Laravel 8 Wepback API configuration problem

Bug report
Laravel 8 Wepback API configuration problem

What is the current behavior?
using "npm run dev" results in the error "Invalid configuration object. Webpack has been initialized using a configuration object that does not match the API schema. configuration.module.rules[10] has an unknown property 'loaders' "
If the current behavior is a bug, please provide the steps to reproduce.
Environment: Vagrant VM with Linux 20.04, accessed through an elevated command prompt in Windows 10.

Npm compiles the necessary files and assets, based on dependencies and provides a success message.

Other relevant information:
webpack version:  5.6.0
Node.js version: 10.19.0
Operating System: Windows 10, but VM is Vagrant build on Virtualbox manager
Additional tools:

using "npm run dev" results in the error "Invalid configuration object. Webpack has been initialized using a configuration object that does not match the API schema. configuration.module.rules[10] has an unknown property 'loaders' "

Fix, it, nothing to fix on webpack side or please open an issue in your boilerplate repo


Make sure the still mode can take snapshot with resource error..

Remove the throw in Map::renderStill to make sure the snapshot could success whit resource error.
Fixes #564

@alanchenboy I suggest to also fix the test case, in order to have a green build.


Add behavior to print deleted instance name

1.) Slight refactor to output pkg to rename the function that printed deleted binding (WriteDeletedBindingNam)  into a more generic function (WriteDeletedResourceName)
2.) Added conditional to cmd/svcat/instance/deprovision_cmd.go to print deleted instance on success
3.) Updated README.md to convert the sample deprovision command to a console block with output
Closes: #1805

I just kicked the tests off again as the error was unrelated to this change and appeared to be transient/timing related.

@jeremyrickard Nevermind, I think your rebase pulled in extra commits. Can you PTAL?

oops! i see that! sorry, will take a look


Proper handling of "Downloaded" requests

Is your feature request related to a problem? Please describe.
Petio currently cannot handle different meta-agents. Because of this, once a show is downloaded, it gets stuck in the admin request queue with the downloaded tag and is not cleared by the cronjob since it does not recognize that it has been processed by plex (through a different agent)
Describe the solution you'd like
A setting in the admin tab that makes petio delete the requests once they are marked as "Downloaded" and trigger all notification handlers (discord/email etc)
Describe alternatives you've considered
Adding support for other metadata agents (but this wont be feasible if there are changes in default behaviors anyway)
Additional context

All of these shows exist on my plex for several days

Same here.
Status can't be edited

Same problem for me with movies tvs-hows still finalizes when the are in plex but movies stays as downloaded even when the are in plex, dosent help to rematch them against tmdb.  Problem started about 2 weeks ago worked good before.

Status can now manually be set to "complete" which will trigger the usual event chain and archive the request. There is a limit with this though as Petio will still not actually see the movie / show so can't report that it is "available" in the frontend unless petio can match what is in plex to tmdb. It's kind of a half fix for now


Start using GitHub's new "Projects" interface for e.g. Django 1.10 upgrade

@pydanny, @audreyr, @luzfcb, @jayfk
The new GitHub "Projects" interface incorporates many great workflow improvements like Trello-like drag'n'drop backlog etc. type boards.  In a traditional "Agile" type workflow, bugs to be worked on in a "Sprint" go into a "backlog", get assigned, flagged as "Passes Tests", "100% Coverage", "Ready for code review", "Ready to merge",  "Done" type workflow and it makes it very clear what needs to happen next.
I do not have access to create one here, but I think that, in addition to the 'wip-migrate-to-django-1.10' type branches, it would be great to start using projects to make sure we all know what remains to be done to get to a particular goal.
In my opinion, that (combined with making some future assignable milestones like "Integrate Channels", with sub-projects therein) would be a huge step toward making it really easy for new (or old) contributors to know "what's next" to move the project forward to specific goals.
If we were to make sure that "low hanging fruit" was always in the "next milestone" then onboarding new contributors would be that much easier and, if nobody grabs it, would ensure that someone cleans up some of the little dangling nits to work toward getting "Issues" and "Pull Requests" cleared up and/or closed just before each new release.

I've created one here: https://github.com/pydanny/cookiecutter-django/projects/1
It's just horrible.

@jayfk Glad to hear you like it! ;-).
I think "Project" means something like "Update to Django 1.10", then you put tickets into the backlog that need to be done to get to "done" in that project.
Can't say I've used it a whole lot, I've actually been using the ZenHub for GitHub Chrome extension which has a whole bunch of extra improvements and is free for open source repos.


Added $neoPro Function

I added $neoPro function on this Pull Request.

nice

nice

Thanks. I will appreciate if you yolo and merge it. 😎

@LordexDuck3990 why not merging but adding the code by yourself? That’s weird.


more-dropdown-links: dropdown opens to wrong direction

Description
When clicking the repo navigation dropdown, it opens to the top instead of to the bottom, making most links to be inaccessible:

Note that:

The look and feel of this button was recently changed by GitHub.
The bug also appears with Refined GitHub disabled (on smaller screens), but
more-dropdown-links adds more links to the repo navigation dropdown, causing it to always be shown (also on large screens), making the bug much more obvious.

How to replicate the issue + URL

Go to https://github.com/refined-github/refined-github
Click on the repo navigation overflow button → it opens to the top instead of to the bottom

Extra steps:

Disable Refined GitHub
Reload → the button is not shown anymore
Resize the screen to make the button re-appear
Click on the repo navigation overflow button → it opens to the top instead of to the bottom

Extension version
23.11.23
Browser(s) used
Firefox 120

This is indeed a GitHub bug.

I'm gonna keep this open for discovery for now.

I think it has been fixed


[PSM interop] Enable custom_lb_test for CXX

Manual test run:

grpc/core/master/linux/grpc_xds_k8s_lb

@eugeneo FYI custom_lb test test failed:
Traceback (most recent call last):
  File "/tmpfs/tmp/tmp.hM6p0ES1S8/grpc/tools/run_tests/xds_k8s_test_driver/tests/custom_lb_test.py", line 98, in test_custom_lb_config
    method='UNARY_CALL')
  File "/tmpfs/tmp/tmp.hM6p0ES1S8/grpc/tools/run_tests/xds_k8s_test_driver/framework/xds_k8s_testcase.py", line 292, in assertRpcStatusCodes
    self.fail(f"Expected only status {status} but found status "
AssertionError: Expected only status 15 but found status 0 for method UNARY_CALL:
stats_per_method {
  key: "UNARY_CALL"
  value {
    result {
      key: 0
      value: 201
    }
  }
}

Test run: grpc/core/master/linux/grpc_xds_k8s_lb


rizin: 0.3.0 -> 0.3.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/rizin/versions.
meta.description for rizin is: "UNIX-like reverse engineering framework and command-line toolset."
meta.homepage for rizin is: "https://rizin.re/"
meta.changelog for rizin is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-pm had a zero exit code or showed the expected version
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-agent passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-gg passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-sign passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-find passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rizin passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-asm passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-test passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-diff passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-hash passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-ax passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-run passed the binary check.
/nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin/rz-bin passed the binary check.
12 of 13 passed binary check by having a zero exit code.
12 of 13 passed binary check by having the new version present in output.
found 0.3.1 with grep in /nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1
found 0.3.1 in filename of file in /nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
cutter
docbookrx
rizin

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A rizin https://github.com/r-ryantm/nixpkgs/archive/e6f7d88851f5160c2ad72dd80789a8a04c7fdb32.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1
ls -la /nix/store/5145lr51dvhb5kpblbkcaaj9g18w3mbv-rizin-0.3.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

cutter
rizin

Maintainer pings
cc @7c6f434c @makefu @mic92 for testing.

Ideally this should also update cutter in the same pr: https://github.com/rizinorg/cutter/releases/tag/v2.0.4


Put in loop

How to call put effect in loop correctly?
So i wanna do something like this:
function* dispatchAll (data) {
  yield put({
    type: 'TYPE',
    payload: data
  })
}

function* foo ({ payload }) {
  try {
    const data = yield R.map(api, payload) // R = ramda.js
    yield R.map(dispatchAllPosts, data)
  } catch (err) {
    //
  }
}

But while i call put in loop app is freezing. Any advices?

What does your main saga.run look like, and what does your .dispatch action that starts the whole thing look like?

@38Slava Maybe I am wrong but here const data = yield R.map(api, payload) you should yield array of effects but you yield array of API invocation results. Also it seems here yield R.map(dispatchAllPosts, data) array of undefined are being yielded (if as dispatchAllPosts you mean dispachAll) instead of array of effects.
Simple loop should look somthing like this:
for (let item of payload) {
  const data = yield call(api, item);
  yield call(dispatchAll, data);
}

or
const data = yield R.map(item => (call(api, item)), payload);
yield R.map(item => (call(dispatchAllPosts, item)), data);

if you want to yield multiple calls in parallel, use the snippet of @sergej-s; to put the results in parallel you can yield an array of put effects
yield R.map(item => put({type: '...', payalod: item}), data)

I'm late to the party here, but I'm having trouble getting this to work. If I have an array of actions, like:
const actions = [
{action: 'ACTION1', payload: {x: 1}},
{action: 'ACTION2', payload: {y: 2}}
]

...how can I iterate over that array to put each of those actions? I've tried this:
        yield actions.map ( (current) => {
          put(current)
          return true;
        })

...but the put doesn't trigger. If I put yield put([some action]) in the exact same place in my code, that triggers just fine.
If I try this:
        actions.map ( (current) => {
          yield put(current)
          return true;
        })

...then I get a JS error saying yield is a reserved word.
I've experimented a bit with all, but I haven't seen any examples where there is a put inside of an all (only call functions, which makes some sense, I think).
So, is it possible to do what I'm after here? Am I just not understanding something fundamental about how Redux Saga works?

answering my own question. It appears this does the trick:
        yield actions.map ( (current) => {
          return put(current)
        })

You have to explicitly return the put. I don't think I saw that in any examples or docs, though perhaps I just missed it.

Or simply: yield actions.map(put)

@ArtBIT yield actions.map(put) might not work, because put will be called with both action and index arguments. puts signature is function put(channel, action) { ... } so it would create wrong effect (or just throw when validating.
Also you should wrap this with all effect which is preferred way of starting parallel effects.
So the final code should look like this:
yield all(actions.map(ac => put(ac)))

@Andarist I stand corrected.


Less boilerplate for Path-Presenter-View sample

Problem
After adopting dagger 2 for mortar-flow sample, we accounted tons of boilerplate for a simple Path which is occurred due to Path-to-Presenter-to-View dagger bindings. Please take a look at solution and share your thoughts.
Solution

Use mortar's service to provide presenter to view;
Use presenter as inner class to get access to Path's arguments.

Solution Repo:
https://github.com/techery/mortar-flow-sample/commit/fc817835a8ba69d32d045c0ac62f2d25468cdf71
Path sample:

Caveats
Presenter uses dagger to inject deps into itself ondemand, it means one have to provide dagger component injection graph with presenters. We use separate interface, but we believe it's less hassle comparing to #128:
https://github.com/techery/mortar-flow-sample/blob/fc817835a8ba69d32d045c0ac62f2d25468cdf71/app/src/main/java/com/example/mortar/core/ScreenComponent.java

Yeah, mortar is confusing because of a lot of boilerplate code required for simple actions. We would like to hear other dev ideas about how to reduce this.

I am using a slight different approach, inspired from https://github.com/pyricau/dagger2-mortar-flow-experiment. I'm using a @WithComponent annotation, and it avoids the boilerplate in the Presenter class.
Here's a sample: https://gist.github.com/lukaspili/fc8d41d0dcd36e149695

@lukaspili We tried this approach but found it no less boilerplate, because of @Component you have to create for every presenter, and even more: an extra module to provide args from path to presenter. Details are here: #128

@almozavr I agree.
After having my fill of writing this boilerplate code, I made a pretty simple annotation processor that generates the boilerplate for me: https://github.com/lukaspili/mortar-mvp
It's still very experimental, but works for me so far. Would be cool if I can get your feedback on it, as I don't have many mortar users around me, unfortunately.


Updated config-template.json

Switched version from beta to stable.  The beta option causes issues when being run on MacOS as the beta version is usually not available for it.  Also, do we really want to start people out on beta?

👍


kail: 0.16.1 -> 0.17.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/boz/kail/releases.
meta.description for kail is: Kubernetes log viewer
meta.homepage for kail is: https://github.com/boz/kail
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.17.0 with grep in /nix/store/alg8y7nlgb74nxrbwvd5g6jvj17cfkgn-kail-0.17.0
found 0.17.0 in filename of file in /nix/store/alg8y7nlgb74nxrbwvd5g6jvj17cfkgn-kail-0.17.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
kail

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/alg8y7nlgb74nxrbwvd5g6jvj17cfkgn-kail-0.17.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A kail https://github.com/r-ryantm/nixpkgs/archive/8c6d5c96dd77360ffed683b2c5f9b01091d91a3c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8c6d5c96dd77360ffed683b2c5f9b01091d91a3c#kail

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/alg8y7nlgb74nxrbwvd5g6jvj17cfkgn-kail-0.17.0
ls -la /nix/store/alg8y7nlgb74nxrbwvd5g6jvj17cfkgn-kail-0.17.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

kail

Maintainer pings
cc @offlinehacker @vdemeester for testing.

Result of nixpkgs-review pr 264823 at 8c6d5c96 run on aarch64-darwin 1

1 package built successfully:

kail


Is that something I have to worry about?

https://containercve.com/ shows 36 vulnerabilities with some being Critical

This seems to be due to the outdated base image. I'll see if i can update it quickly

Thank you, keep me updated

I updated it but it am getting stuck on my local env. As my new image seems to be unable to access the volumes :(
But will keep you updated.
@PhiTux Do you perhaps know why this might happen when i use the dockerfile in the project?
I suspect it's quick for you to do but i would love to be able to help support this cool project.

Hi,
thanks for your recent information!
I'll try to look into it in the next days! Should be possible over the easter holidays ;)

Version 1.0.14 is now published.
Updating a project that you haven't worked on for several months is always quite a challenge 😅 I also had quite some trouble to get it working.
containercve.com does no longer show warnings now.


support data type coerced and decimal in INLIST expr

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to  the what)
When I apply the in list filter to the below table
❯ \d food
+---------------+--------------+------------+-------------+-----------------+-------------+
| table_catalog | table_schema | table_name | column_name | data_type       | is_nullable |
+---------------+--------------+------------+-------------+-----------------+-------------+
| datafusion    | public       | food       | a           | Decimal(10, 5)  | NO          |
| datafusion    | public       | food       | b           | Decimal(20, 15) | NO          |
| datafusion    | public       | food       | c           | Boolean         | NO          |
+---------------+--------------+------------+-------------+-----------------+-------------+

❯  select * from food where a in (1);
ArrowError(ExternalError(NotImplemented("InList does not support datatype Decimal(10, 5).")))

explain the query:
❯ explain select * from food where a in (1);
+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| plan_type     | plan                                                                                |
+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| logical_plan  | Projection: #food.a, #food.b, #food.c                                                                                |
|               |   Filter: #food.a IN ([Int64(1)])                                                                                |
|               |     TableScan: food projection=Some([a, b, c]), partial_filters=[#food.a IN ([Int64(1)])]                                                                                |
| physical_plan | ProjectionExec: expr=[a@0 as a, b@1 as b, c@2 as c]                                                                                |
|               |   CoalesceBatchesExec: target_batch_size=4096                                                                                |
|               |     FilterExec: a@0 IN ([CastExpr { expr: Literal { value: Int64(1) }, cast_type: Decimal(10, 5), cast_options: CastOptions { safe: false } }])                              |
|               |       RepartitionExec: partitioning=RoundRobinBatch(16)                                                                                |
|               |         CsvExec: files=[/Users/kliu3/Documents/github/arrow-datafusion/datafusion-cli/target/debug/aggregate_simple.csv], has_header=false, limit=None, projection=[a, b, c] |
|               |                                                                                |
+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
2 rows in set. Query took 0.007 seconds.

We need convert the data type of expr and list to the common data type.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I will file a PR to fix it.

blocked by this issue https://github.com/apache/arrow-datafusion/issues/2759


Multiple Categories

Hello,
is it currently possible to have multiple categories in one python file, which then outputs one tex and one XML file?

Hello,
No, this is not currently possible.
Technically, having a unique .tex as an output could be implemented. But it would require some decent amount of work, for a benefit which I think is not so worth it in comparison. So it is not in my todo list.
Having one unique XML file containing multiple categories would be great : this would mean having to interact less with Moodle's interface (only one import instead of multiple imports). But here I identify a technical difficulty : I do not think that Moodle can understand an XML file containing multiple category? I don't remember if I tried to test this, but the Moodle Import page tells that it is for importing "a" category, not multiple ones.
If you do some tests and prove me wrong on this, maybe I'll consider adding it to the todo list (and reopen the issue).


tests: improve integration tests for RemoteStateConfigToTerraformCode

@Jerazol this PR improves the integration tests for RemoteStateConfigToTerraformCode. The previous version was not covering all the cases.

@Jerazol this PR improves the integration tests for RemoteStateConfigToTerraformCode. The previous version was not covering all the cases.


Support MQTT-5 Conn-ACK with subscriptionIdentifiersAvailable and maximumPacketSize

Master Issue: #369
Motivation
Support MQTT-5 Conn-ACK with subscriptionIdentifiersAvailable and maximumPacketSize

[x] no-need-doc

Codecov Report

Merging #685 (ad31756) into master (617fba1) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #685      +/-   ##
============================================
- Coverage     78.20%   78.12%   -0.09%
+ Complexity      956      953       -3
============================================
  Files           108      108
  Lines          4084     4096      +12
  Branches        309      309
============================================
+ Hits           3194     3200       +6
- Misses          719      725       +6
  Partials        171      171

Impacted Files
Coverage Δ

.../streamnative/pulsar/handlers/mqtt/Connection.java
88.53% <100.00%> (+0.07%)
:arrow_up:

...sar/handlers/mqtt/messages/ack/MqttConnectAck.java
75.53% <100.00%> (+2.27%)
:arrow_up:

...s/mqtt/proxy/MQTTProxyProtocolMethodProcessor.java
77.97% <100.00%> (+0.07%)
:arrow_up:

...handlers/mqtt/restrictions/ServerRestrictions.java
60.00% <100.00%> (+10.00%)
:arrow_up:

...qtt/support/MQTTBrokerProtocolMethodProcessor.java
78.96% <100.00%> (+0.06%)
:arrow_up:

...pulsar/handlers/mqtt/MQTTCommonInboundHandler.java
77.94% <0.00%> (-5.89%)
:arrow_down:

...e/pulsar/handlers/mqtt/utils/PulsarTopicUtils.java
76.52% <0.00%> (-1.74%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617fba1...ad31756. Read the comment docs.


[incubator/gogs]

What this PR does / why we need it:
This enables the opportunity to configure the STATIC_ROOT_PATH of the gogs application
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #15314

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @obeyler

please initialize the new var or check the fact that this var exist before add it to configMap to avoid crash


Replace buy switch with new style

I know there are works on the profile, yet can we speed run this small switch?
otherwise profile will be not that ugly :)

mybb
https://github.com/kodadot/nft-gallery/assets/5887929/b91cd1f1-3113-4b10-a78d-7b7eac466205

closing, continue to

#6663


Restrict selectorContainer from being set for LB service/ Service Alias/ External Service.

Build from master- Oct 8
Currently we are allowed to set selectorContainer when creating LB service/ Service Alias/ External Service.
But containers which have matching labels do not get added to these services which is as expected.
In such cases , it would be better for API to throw an error when creating LB service/ Service Alias/ External Service with selectorContainer  set.

Tested with rancher-server build version - v0.41.0-rc1
Apis for creating LB service/ Service Alias/ External Service does not have selectorContainer anymore.


Add automatic access token rotation for workspace apps

Summary
With workspace apps comes the ability to use short-lived, expiring, tokens. This patch adds the ability for the client to automatically refresh access tokens after expiration and call your app's refresh callback to update said tokens in your app's datastore.

Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

my review from the last 2 days is complete and up to date with all the latest code changes. the only unresolved issue from the previous reviews is this one: https://github.com/slackapi/python-slackclient/pull/347#discussion_r215470972

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Roach:x: Rodney UrquhartRodney Urquhart seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


New Contributors?

Hi all,
I've recently taken a new job, and I'm no longer working much with CMake in my day job, so my interest in this project has, naturally, waned. That's unfortunate because I know there are lots of people out there who use Corrosion, and I'm proud to have gotten as many stars as I have on it!
I'm looking for some new contributors who can take on future maintenance and (if necessary) development. I'm happy to continue code reviewing from time to time and providing feedback, but I'm just not going to be able to continue working on Corrosion in any meaningful way.
If you're interested, please let me know - we can talk offline if you'd like and maybe have you complete a few issues before I give your admin access.
Thanks,
Andrew
cc @ogoffart @JBBgameich @kjeremy @westernmagic @onContentStop @humenda @surprized @bhush9 @Chaz6 @ratijas

Thank you for your work on Corrosion so far, it has become a very useful tool for me!
I will try to provide fixes for the limited subset of features I use, so mainly corrosion as an external package, on Linux (of course not breaking the other features). Due to only using a small subset, I think I'm not well suited as main developer. I'd also happily work with code review of course.

I would be happy to contribute one patch or the other, but am reluctant to
take over maintainership, due to tight time budgets. So any future maintainer:
you can count on contributors :).

I can also help with review and maintenance, as I'm relying on corrosion in a project.


feat: create extension settings page

This commit creates the extension's options.js/html files where the
imgix API key will be set/read. The extension settings can be set from
the chrome://extensions settings page. It will not open in a new tab
but, instead, it will open in a pop-up.

Current dependencies on/for this PR:

next

PR #256   (this PR)

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: 🔄 Waiting for checks to pass
This pull request is currently waiting for CI and mergeability checks to pass before being merged.
This comment was auto-generated by Graphite.

Job Reference: 6cwJaETgMG17vfBY88e2


fix(TFD-1326): correct elasticsearch test

What is the current behavior? (You can also link to an open issue here)
flaky test in elasticsearch component
What is the new behavior?
correct it
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:


Any way of doing a recurring schedule with seconds?

Ideal:
var sched = later.parse.text('every 30 mins starting on the 15th min 20th sec')
Workaround (that doesn't work):
var sched = later.parse.text('every 1800 sec on the 920th sec')
Any way of adding seconds to the recurring schedule that starts 15 min 20 sec past an hour and runs every 30 minutes?

I think this is what you are looking for:
var sched = later.parse.text('every 30 mins starting on the 15th min on the 20th sec');
later.schedule(sched).next(5)
[
  Tue Jun 09 2015 12:15:20 GMT-0700 (Pacific Daylight Time),
  Tue Jun 09 2015 12:45:20 GMT-0700 (Pacific Daylight Time),
  Tue Jun 09 2015 13:15:20 GMT-0700 (Pacific Daylight Time),
  Tue Jun 09 2015 13:45:20 GMT-0700 (Pacific Daylight Time),
  Tue Jun 09 2015 14:15:20 GMT-0700 (Pacific Daylight Time)
]

This is fantastic, thank you. The documentation is a bit lacking when it comes to adding seconds in.


Is it possible to get a TableName from model?

Hi!
I want to remove the constant TABLE_NAME from code. Is it possible in this case?
type Actor struct{
	Id int
	deleted bool
	LastName string
	FirstName string
	Patronymic string
	Birthday string
	CastingDate string
	Sex string
}

const TABLE_NAME  = "actor"

func (a *Actor) GetAllPagination(from, limit int64) ([]Actor, int64) {
	var actors []Actor
	q := db.Select().
		Limit(limit).
		Offset(from)

	err := q.All(&actors)
	if err != nil {
		println("Exec err:", err.Error())
	}
	q = db.Select("count(*)").From(TABLE_NAME)
	var total int64
	q.Row(&total)
	return actors, total
}

use dbx.GetTableName(model)


APPCRASH in HelloWorld C# Console Application

Creating an issue to keep track of log files. Conversation started here:
https://groups.google.com/forum/#!topic/dynamorio-users/RXXRxYa08QQ

log.0.1976.html.txt

Unfortunately it's not a straightforward decoder issue such as avx512 or something.  The win32 start address of the thread is bogus.  However, there is something strange here: this is the main thread (it's log.0.*), and default injection on Windows is much later than this.  What injection was used here?  Is this a child process where the parent was under DR control?
interp: start_pc = 0x00007ffd90b213cd
  0x00007ffd90b213cd  48 8b cf             mov    %rdi -> %rcx
  0x00007ffd90b213d0  ff d3                call   %rbx %rsp -> %rsp 0xfffffff8(%rsp)[8byte]
end_pc = 0x00007ffd90b213d2

Fragment 8, tag 0x00007ffd90b213cd, flags 0x1000030, shared, size 33:
        [KERNEL32.dll~BaseThreadInitThunk+0x1d,~TermsrvOpenRegEntry-0x43]
Entry into F8(0x00007ffd90b213cd).0x0000000b2b8a1158 (shared)

Exit from sourceless ibl: bb call*      []
 (target 0x0000000bab820000 not in cache)
fragment_add_ibl_target tag 0x0000000bab820000, branch 1, F0

...

interp: start_pc = 0x0000000bab820000
stack vs 0x0000000bab820000: official 0x0000000bab860000..0x0000000babc60000, esp 0x0000000babc5f788
new shared vm area: 0x0000000bab820000-0x0000000bab821000 ---- unexpected vm area HelloWorld.exe
  0x0000000bab820000  4d 5a                pop    %rsp (%rsp)[8byte] -> %r10 %rsp
  0x0000000bab820002  90                   nop
  0x0000000bab820003  00 03                add    %al (%rbx)[1byte] -> (%rbx)[1byte]
  0x0000000bab820005  00 00                add    %al (%rax)[1byte] -> (%rax)[1byte]
  0x0000000bab820007  00 04 00             add    %al (%rax,%rax)[1byte] -> (%rax,%rax)[1byte]
  0x0000000bab82000a  00 00                add    %al (%rax)[1byte] -> (%rax)[1byte]
SYSLOG_WARNING: Invalid opcode encountered
Invalid opcode @0x0000000bab82000c: 0xff0027
decode: invalid instr at 0x0000000bab82000c
  0x0000000bab82000c  ff ff...??           <INVALID>


Drop ScheduledTransactionTrace check

Suggested commit message:
Drop `ScheduledTransactionTrace` check (#788)

As well as any other references to New Relic.

:exclamation: Before merging this, we should validate that Datadog does indeed collect traces for @Scheduled transactions out of the box.

Before merging this, we should validate that Datadog does indeed collect traces for @Scheduled transactions out of the box.

While I didn't test this in production, the agent source code does have a test case for this. So I expect this'll work fine. If not, we'll review how to deal with that.


Signature not intact after signing with Google Cloud KMS HSM

Hello,
I'm using endesive==2.17.0.
Up until now, I have successfully been using the "simple" signing and certifying with a pkcs12 key+certs (ETSI 319 411-1 LCP = RGS * in France).
I had to upgrade to use a ETSI 319 411-2 QCP-l (RGS** in France) where the private key is on a Google Cloud KMS HSM, to obtain the AdES level with a trusted certificate chain.
The code in /examples/pdf-sign-cms-hsm-google.py is working well. I'm using exactly what's in there
dct = {
        'sigflags': 3,
        'contact'<EMAIL_ADDRESS>        'location': 'England',
        'signingdate': date.encode(),
        'reason': 'Test',
}

And everything else, I just added the digest_crc32c and signature_crc32c checks (as per https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/kms/snippets/sign_asymmetric.py but the result is the same without it).
No complaints from anywhere on execution.
However the final document seems to have a "broken" signature and the DSS validation (https://ec.europa.eu/digital-building-blocks/DSS/webapp-demo/validation) shows a "SIG_CRYPTO_FAILURE" (https://ec.europa.eu/digital-building-blocks/DSS/webapp-demo/apidocs/eu/europa/esig/dss/enumerations/SubIndication.html#SIG_CRYPTO_FAILURE) :

The signature validation process results into TOTAL-FAILED because the signature value in the signature could not be verified using the signer's public key in the signing certificate.

And Master PDF Editor (I'm on Linux, I have not been able to test on Adobe Reader yet) says :

The document has been altered or corrupted since the signatures was applied.

Here is an example you can use yourself on the DSS validation :
F-2024-02-15-M-4.pdf
F-2024-02-15-M-4_hsm_signed.pdf
I've read a lot of the code in cms/signer to try and understand what could be wrong but I have to admit I'm a little bit out of my depth here, regarding the internal structures of PDFs especially... :smiling_face_with_tear:
Has anyone been successful in this use-case ?
@Arbitrage0 maybe, since you wrote the Google HSM code ?
Does anyone has any ideas of what could be the problem, or ideas of thing to test further on my end ?
I'm pretty much stuck :disappointed:

OK some more info :
To be safe I've tried with the same private key to generate another x509 (as per the comment on the example code).

See my gist to find out how to create x509 certificates for
Google HSM-hosted keys: https://gist.github.com/Arbitrage0/de4e0defb20bc539d6db27e4334e0e67

The result is exactly the same with a SIG_CRYPTO_FAILURE, except I also now have "The result of the 'X.509 Certificate Validation' building block is not conclusive" error which is expected with this manually created and untrusted certificate.
BUT reading the code from verifier.py I saw something that made me think that the "signature_algorithm" was maybe the culprit...I created a new HSM key but this time with the algo "2048 bit RSA key PKCS#1 v1.5 padding - SHA256 Digest" (instead of "2048 bit RSA key PSS Padding - SHA256 Digest" for the first key).
I created another x509 manually and...The resulting PDF does not have SIG_CRYPTO_FAILURE !
The problem is that now I have issued the certificate for 3 years with the RSA PSS key so I would very much like to use it :cry:
Yeah I should have tried all that first, I did not think PSS would be a problem :disappointed:
I can see that the "pss" param in cms is forced to False. And if I try to force it to True, I now have a (logical) Exception :

File "/.../lib/python3.8/site-packages/endesive/pdf/cms.py", line 680, in sign
contents = signer.sign(
File "/.../lib/python3.8/site-packages/endesive/signer.py", line 160, in sign
salt_length = padding.calculate_max_pss_salt_length(key, hashes.SHA512)
File "/.../lib/python3.8/site-packages/cryptography/hazmat/primitives/asymmetric/padding.py", line 97, in calculate_max_pss_salt_length
raise TypeError("key must be an RSA public or private key")
TypeError: key must be an RSA public or private key

Because the key==None when you use an HSM.
Does anyone have an idea on how to modify the salt_length / calculate_max_pss_salt_length code to adapt to this use-case ?
Thanks !

I tried some more things :

a) Force pss = True in cms.py:689 and cms.py:774
b) Force salt_length = 256 (as per https://cloud.google.com/kms/docs/algorithms "For Probabilistic Signature Scheme (PSS), the salt length used is equal to the length of the digest algorithm. For example, RSA_SIGN_PSS_2048_SHA256 will use PSS with a salt length of 256 bits.") and key algo to "sha256" in signer.sign()

    if not pss:
        signer["signature_algorithm"] = algos.SignedDigestAlgorithm(
            {"algorithm": "rsassa_pkcs1v15"}
        )
    else:
        salt_length = 256
        key_algorithm = "sha256"
        signer["signature_algorithm"] = algos.SignedDigestAlgorithm(
            {
                "algorithm": "rsassa_pss",
                "parameters": algos.RSASSAPSSParams(
                    {
                        "hash_algorithm": algos.DigestAlgorithm(
                            {"algorithm": key_algorithm}
                        ),
                        "mask_gen_algorithm": algos.MaskGenAlgorithm(
                            {
                                "algorithm": algos.MaskGenAlgorithmId("mgf1"),
                                "parameters": {
                                    "algorithm": algos.DigestAlgorithmId(key_algorithm),
                                },
                            }
                        ),
                        "salt_length": algos.Integer(salt_length),
                        "trailer_field": algos.TrailerField(1),
                    }
                ),
            }
        )

But to no avail. I then tried

a) Same as 1.a
b) Put only the algo in signature_algorithm like for rsassa_pkcs1v15

    if not pss:
        signer["signature_algorithm"] = algos.SignedDigestAlgorithm(
            {"algorithm": "rsassa_pkcs1v15"}
        )
    else:
        signer["signature_algorithm"] = algos.SignedDigestAlgorithm(
            {"algorithm": "rsassa_pss"}
        )

Not working either.
Anyone knows the right config of what to put there ?
Or maybe the problem is later, in the hsm.sign() call or code ?

I made it work !!! :heart_eyes:
With pss = True and this code for the signer["signature_algorithm"] :
    if not pss:
        signer["signature_algorithm"] = algos.SignedDigestAlgorithm(
            {"algorithm": "rsassa_pkcs1v15"}
        )
    else:
        salt_length = hashes.SHA256.digest_size
        key_algorithm = "sha256"
        signer["signature_algorithm"] = algos.SignedDigestAlgorithm(
            {
                "algorithm": "rsassa_pss",
                "parameters": algos.RSASSAPSSParams(
                    {
                        "hash_algorithm": algos.DigestAlgorithm(
                            {"algorithm": key_algorithm}
                        ),
                        "mask_gen_algorithm": algos.MaskGenAlgorithm(
                            {
                                "algorithm": algos.MaskGenAlgorithmId("mgf1"),
                                "parameters": {
                                    "algorithm": algos.DigestAlgorithmId(key_algorithm),
                                },
                            }
                        ),
                        "salt_length": algos.Integer(salt_length),
                        "trailer_field": algos.TrailerField(1),
                    }
                ),
            }
        )

So in my case "salt_length" must be == 32 even though Google says

For Probabilistic Signature Scheme (PSS), the salt length used is equal to the length of the digest algorithm. For example, RSA_SIGN_PSS_2048_SHA256 will use PSS with a salt length of 256 bits.

The first part is correct but the second is not...I think you really need to read "use the digest size of the hash algo for the salt length", so for SHA256 it's 32 not 256 !
The rest of the endesive code is OK, except the two hardcoded "sha512" in the PSS parameters (I don't know why that is ?).
@m32 could I create a PR to use the hashalgo param instead of "sha512" (and the hashes.SHA512() further down for hsm == None and pss == True) in signer.py ?

I added a test: test_pdf_pss and the pss parameter in udct.
In the pss handling code I added code for selecting the appropriate hash function based on hashalgo.
Since I don't have the Google key, I can't check how it works, please check the Git versions with these corrections.

Hello @m32 !
Thank you very much for your edit ! Unfortunately it does not work as the code in signer.py:159 tries to calculate the salt length with a non-existing key. The private key is inaccessible in the HSM so the pdf.cms.sign() is made with Key==None :
salt_length = padding.calculate_max_pss_salt_length(key, md)
If I force the salt_length to md.digest_size like in my PR, everything else works as is !
        md = getattr(hashes, hashalgo.upper())
        if hsm is not None:
            salt_length = md.digest_size
        elif isinstance(key, keys.PrivateKeyInfo):
            salt_length = key.byte_size - md.digest_size - 2
            salt_length = md.digest_size
        else:
            salt_length = padding.calculate_max_pss_salt_length(key, md)
        signer["signature_algorithm"] = ...

Would you be able to release a new version with this change ?
Thank you again very much for your response and quick action.

I need to have an example and a test, an identical test for the case when Key!=None (current behavior), otherwise I don't know what repercussions it will have on the existing code. Please prepare an appropriate correction as (new) PR and we will know after testing.

Do you mean the case when hsm is None or key is None ?
Otherwise the key is known and the size of the salt can be calculated.

I mean when hsm != None so key == None.
I'm sorry but I don't see theses lines
if key is None: # <-- this line is important
        salt_length = md.digest_size

anywhere in the repo.
They would indeed make my case work, they are similar to my if hsm is not None:
Can you point me to where this code lives ?

change added and commited, next version is ready to publish, please confirm

Yes that last version commited indeed works great !
Just to clarify : My case is
key=None
hsm=Ghsm (like in pdf-sign-cms-hsm-google.py)

Yes that last version commited (634fff1238c8e9d105fc1abb25cbc693259dd879) indeed works great !
Just to clarify : My case is (like in pdf-sign-cms-hsm-google.py) :
datas = pdf.cms.sign(
        datau=datau,
        udct=dct,
        key=None,
        cert=None,
        othercerts=[],
        algomd='sha256',
        hsm=Ghsm,
    )

And the problem was (as you found out) earlier in the code (lines 154-162) than lines 337-
Thank you very much in advance for publishing the new version :pray:

published

2.17.2 tested and approved !
For future reference if anyone find this thread, Endesive works with both these Google Cloud KSM HSM key algos :
2048 bit RSA key PSS Padding - SHA256 Digest (with udct["pss"]=True)
and
2048 bit RSA key PKCS#1 v1.5 padding - SHA256 Digest (with udct["pss"]=False, default)
Just follow the example in /examples/pdf-sign-cms-hsm-google.py for the details.
Thanks again for everything @m32, keep up the good work with this great lib :smile_cat:
Cheers.


SchemeShard build vector index fix leftovers

Only after this PR:
https://github.com/ydb-platform/ydb/pull/9176

Merged as part of other PR
https://github.com/ydb-platform/ydb/pull/9176/commits/70d3ccd75d66ce8afc8de66c8ee1a7d02ed3094e


"jumpy" behavior with slidesPerView:'auto', centeredSlides and loop: true

I have a lot of swipers in my page, but one of them is baheving very weirdly. It look like it restart after every swipe the user does.
I'm using this configuration:
var a  = new Swiper('.slider-market-mobile', {
              slidesPerView: 'auto',
              spaceBetween: 20,
              loopedSlides: 1,
              centeredSlides: true,
              watchSlidesVisibility: true,
              parallax: false,
              loop: true,
              height: 'auto',
              paginationClickable: true,
              effect: 'slide'
            });

Swiper's default css and js are being added in codepen's settings, the version is 3.3.1.
This codepen is just a copy of my Drupal generated markup, so it's kind of a huge markup, but the behavior is very much isolated, so the error i'm getting in the website is the same in the pen.
To reproduce the error, follow the steps below:

Enter http://codepen.io/filipemerker/pen/PZMGNB
Use the cursor to drag and swipe the slides.
Note that it keep looping through the first and second slides.

Can't really see anything wrong. But for loop: true and slidesPerView: 'auto', loopedSlides parameter is mandatory! I can't see it code pen. Try adding loopedSlides: 10

is there any issue with loopedSlides as 1

loopedSlides should be more than you have maximum amount of visible slides per screen

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


python311Packages.aioaladdinconnect: 0.1.56 -> 0.1.57

Changelog: https://github.com/mkmer/AIOAladdinConnect/releases/tag/0.1.57
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 248094 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.aladdin_connect
python310Packages.aioaladdinconnect
python310Packages.aioaladdinconnect.dist
python311Packages.aioaladdinconnect
python311Packages.aioaladdinconnect.dist


Non zero mean scaling - Not working

I've used "lambda x: jnp.mean(x[x > 0])" in place of "jnp.mean"
media_scaler = preprocessing.CustomScaler(divide_operation=lambda x: jnp.mean(x[x > 0]))
It throws "NonConcreteBooleanIndexError: Array boolean indices must be concrete; got ShapedArray(bool[82])" error.
please help me out, how to do scaling only for non zero values in a column.
Also , how to change the axis (row/column) for scaling)?

Thanks a lot for flagging this! I just wanted to share a link to our new "support" section in the readme to give you some more information on how we can and cannot support such issues at the moment.
For this particular issue, the documentation for the NonConcreteBooleanIndexError has some potential workarounds you could try!

@msdhina This works for a single vector but wouldn't work if you pass multiple columns

I tried the code below by referring to the documentation @michevan suggested.
def nonzero_mean(arr):
    return jnp.nanmean(jnp.where(arr != 0, arr, jnp.nan))

media_scaler = preprocessing.CustomScaler(divide_operation=nonzero_mean)

In this way I first converted zero values to jnp.nan and calculated the mean excluding NaN values by jnp.nanmean()
I think this works but need someone to verify this since I'm not a good coder 😅

did anyone make it work?

Did it worked? Im trying to fix this, do you have any alternative for zero data

Did it worked? Im trying to fix this, do you have any alternative for zero data

I tried this solution and the scaling works but not the training, got a
ValueError: Normal distribution got invalid loc parameter.


Fixed a bug that caused an exception when reading an array.

What is the necessity of this update? What is updated?
Fixed a bug where an Exception would occur when restoring columns if there were no children in certain cases for Array types.
How did you do the test? (Not required for updating documents)
A unit test was added to reproduce the phenomenon that causes the bug.

LGTM


ECR-2714 [FE] Set proper Content-Type header when submitting binary txs

Overview
Set proper Content-Type header when submitting binary txs

See: https://jira.bf.local/browse/ECR-2714
Definition of Done

[ ] There are no TODOs left in the code
[ ] Change is covered by automated tests
[ ] The coding guidelines are followed
[ ] Public API has Javadoc
[ ] Method preconditions are checked and documented in the Javadoc of the method
[ ] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Coverage remained the same at 84.09% when pulling 5732a479c8b817cadaccf35b7a80054b513dce41 on KateNegrienko:ECR2714 into 7e078e1cd5fd3f21a2c0aece6bbd80eb9a1412fd on exonum:master.


Some cosmetic changes to reduce sequence/index confusion

Coverage decreased (-0.2%) to 67.716% when pulling cb54e24f2fac432081e529542795349cd2acf295 on log into 55301021fe29221fd7c025cf395167218b56f049 on master.

Coverage decreased (-0.07%) to 67.881% when pulling 8330dc02cc7b974aa527935531378dc15f844e66 on log into 55301021fe29221fd7c025cf395167218b56f049 on master.