Make filepaths autogenerated based on root location

so that the code can be run from any directory and works on any machine

implemented in #2

implemented in #2


add: ga4 compatible analytics

Description
small modifications to adapt to GA4 format

@johnsmith-gooddollar @sirpy
isLoggedIn param is actually never set. this is already the case on prod now
is that for a specific reason?

@L03TJ3  isLoggedIn is set to false by default in native, so thats not the problem.
The problem is that it is boolean while it seems firebase expects only strings.
What are all these changes you introduced? seems to me they should be reverted and only the mapValues be kept

@sirpy isLoggedIn was never defined on desktop
the two issue I thought were related but are totally separate
so 1 fix is to wait until isLoggedIn is set before initialized analytics
other fix is firebas


[SPARK-39394][DOCS][SS] Improve PySpark Structured Streaming page more readable

What changes were proposed in this pull request?
This PR proposes to improve the PySpark Structured Streaming API reference page to be more readable,
So far, the PySpark Structured Streaming API reference page is not-well organized so it's a bit uncomfortable to be read as below:

Why are the changes needed?
The improvement of document readability will also improve the usability for PySpark Structured Streaming.
Does this PR introduce any user-facing change?
Yes, now the documentation is categorized by its class or their own purpose more clearly as below:

How was this patch tested?
The existing doc build in CI should cover.

Merged to master.

@itholic mind creating a backporting PR to 3.3?

@HyukjinKwon Sure, I created a PR: https://github.com/apache/spark/pull/36797


Not working on Playstore Build

I have uploaded the App Bundle on playstore on which I am getting PARTNER_KEY_ERROR.
The same is working on production build APK

Hi @strmchsr
whenever you try to register your app you have to add SHA-1 key. So try to add
SHA-1 key which is generated by google play console.
After that you have partnerKey which is for only Playstore build.
I hope you get the solution.

Hello @ps6067966
when you register your app to truecaller it will ask you to add SHA-1 key in truecaller developer dashboard.
So after that it will give you partner key , so Use this partner key in your code. whenever you create apk or aab.
if you still not getting what you want ! feel free to ask.
Thanks.


Documentation for HTTP wrapper

I couldn't see the documentation for the HTTP wrapper although it is mentioned in the features list.  Would you mind pointing me in the right direction please?

Http server and client were on roadmap, that is primarily an interest of @techfort's. Is that what you are referring to?  I am not familiar with the existence of a loki HTTP wrapper.

@dukedougal as @obeliskos mentioned this is in the roadmap. There is an incomplete draft at https://github.com/techfort/snaptun which i only parked due to lack of available time but I am actively looking for contributors to get the project moving along. There has been a few requests for this so i might try to make that time available but with a 5 week old baby i can't make any promise :)

@techfort Did you also had in mind to add user auth etc. To the mix? I've not yet used loki actively but it does look promising. I was thinking trying it out for local networking apps and being able to spawn a master app which allows other networking instances to connect to the shared loki db would be nice. Furthermore I would maybe be able to help out with some things.

@johanneslumpe yes absolutely. My dream scenario is to create both a tcp and a http interface for LokiJS and include authentication. I'm aiming for the stars here by trying to get Loki as stable and full-featured as possible so the first pure-javascript stack (as far as I know LokiJS would be the first db server written in javascript). Contributions are really welcome as i'm seriously lacking time lately - what with a 3 month old baby and all.

Yeah I read that above - congrats by the way :)
I was thinking about keeping a dbusers collection which would only be queryable by users flagged as admin. My ideal scenario would be that people can log into an app and the same credentials can be used to query the db - yielding only access to collections which they have been granted access too (think about a single server which has multiple namespaced sets of the same collections). If everything uses https, then this might be be fine and there would be no need for tokens or anything. But keeping the connection open (tcp) would of course be better. It would also mitigate the username/pass issue and probably increase performance, with the downside of being more low level. Being able to just fire off a GET request would be great though, instead of having to manage the direct tcp connection, because we can just use normal status codes when returning results.

@johanneslumpe http and tcp both have "pro et contra", hence why i'm developing (or at least i was developing) them separately from Loki and from each other. TCP has turned out to be more painful, but I don't want to pose limitations on the usage one can imagine to do of LokiJS, On the other hand, a simple JSON based protocol transmitted over the wire as buffer works just fine so it's really not so bad. Any ideas are more than welcome!

@techfort True - supporting both would be great. For TCP it might be sensible to have 3 packages, like loki-message-formatter, loki-tcp-server and loki-tcp-client. The first being a dependency of the other two. Sending basic JSON messages works fine (I just tested that locally with a very basic setup). Things like $regex would require us to pre-parse the message for those occurrences and replace them with a `toString() version of the regex and then later instantiate a new regex again on the server.
The protocol could be as simple as { col: 'collection', query: { /* ... */ }, method: 'find', qId: 'someQueryId' } with individual messages terminated by a line-break or a custom sentinel value. Each method could have it's own parsing function which expects data in a certain way. We'd have parseFindQuery, createFindQuery, parseByQuery, createByQuery, etc. So the tcp client would basically have the same interface as a loki db instance, where each of the methods constructs the messages under the hood using the formatting methods and ships it off to the server. Those methods could return promises which get resolved when we get the result for our query.

hey @johanneslumpe have you taken a look at https://github.com/techfort/lokijs-server ? Pretty much the direction i have taken is not too far away from what you were describing. I would really be interesting in progressing this, if i have someone to give me a hand given the radical lack of spare time in this period. It will get better soon, hopefully.

@techfort Now I have! You are right, we're thinking about a similar solution. I personally would rather have a more "functional" approach, instead of newing stuff. Promises instead of callbacks (automatically async). I'm also a sucker for ES6/7 syntax. Using numbers to express the operations is a lot better than my crude string idea above.
In terms of an api for the tcp client I was thinking about something like this:
lokiClientInstance
  .getCollection('collection')
  .find({ name: 'Hel' })
  .then(data => { /* ... */ })
  .catch(err => { /* ... */ })

Internally this would be translated into a query message object and when find is executed we query the server and return a promise which will resolve with the result. Optionally we could add a isRequired flag to find, which would then reject the promise if no dataset is found. I didn't yet dive too much into the internals of loki, so I'm not sure whether things like sorting would be on the client or the server. But my gut tells me that if we do things like getCollection('users').sort('createdAt').skip(10).limit(5).find() it has to be sorted on the server.
Have you thought about the implications of multiple connections querying the same server? Event-loop blocking for example when someone queries against a collection with 100k rows and gets an initial result set of 30k and applies a sort over 3 fields.

@johanneslumpe 100% agree on a more functional approach. Amazing how things change in one year, i am a complete converted to ES2015 + FP, so yes, I'd go that way. I have not though about multiple connections - i guess i wanted to have a working prototype before i considered the performance implications. Any thoughts on your part?

@techfort One idea might be to split up a query into a "pipeline", where each of the parts is performed in a separate tick, allowing other actions to run in between. Or the server could automatically spawn a configurable number of workers which deal with the blocking things like sorting etc. Not sure how smooth it would be to push the data to those workers though because it would need to be serialized, which itself is a rather slow task.
How does loki handle sorting? If we take the above query as an example, where the users collection has 10k rows. If the createdAt field isn't indexed, loki has to fetch all rows, sort them in memory and then return result 11-15 right? If the field is indexed and the index is already sorted then the operation would obviously be a lot faster. Is this about right?
Another thing: what about mapReduce operations? If we allow functions to be serialized and then evald on the server we will have to make sure that they aren't exploiting the system. Some kind of parser/validator (filter out this/window/global etc., basically making sure that a function only uses the passed arguments)

@johanneslumpe i think the first solution you proposed looks very attractive. i'm also toying with the idea of saving huge sorted datasets to disk and utilizing I/O to "unblock" the process,, but it's still not clear in my head how to achieve this.
Sorting operations are by default placed after filters but before offset-limit conditions so to enable lazy fetching but @obeliskos can expand on this a little more.
Maybe before getting bogged into details of the implementation we could rewrite the wrapper in a more ES2015 + FP fashion, and start playing with multiple connections, replication etc. - and see how it goes? i'm all ears of course.

@techfort That makes sense yeah. Getting a solid base done which works well and upon which we can build. I will toy around with some ideas locally a little bit during this week and can post back here as soon as I pushed a first version, how does that sound? Just to get some ideas written out so we can discuss more about the direction using some actual code.

@johanneslumpe cool - do you want contributor rights on snaptun and lokijs-server? i'd be happy to do so.

@techfort let me first dabble a bit on my own repo and then if you like what you see we can merge/transfer stuff, ok?

@johanneslumpe sure - sounds good!

@techfort started to play around a bit: https://github.com/johanneslumpe/lokijs-tcp-server tell me what you think about that. It's in no way near perfect, but shows some direction.

@johanneslumpe this is awesome stuff, I love the direction you took! This is definitely promising stuff and i'd be more than happy to see this evolving into a fully fledged product. @obeliskos can you take a look too? we had an exchange last year about this so i'd like to hear what you have to say (i'm aware it's probably not your use case, but still..)

@techfort thanks, appreciate it! Let's see what @obeliskos will say :+1:

Pretty cool stuff, nice!  Feel free to pursue this however you (two) feel most comfortable with.  I can understand your pipeline reasoning as that provides you a level of scheduling in an otherwise synchronous query.  For different reasons your pipeline is very similar to collection transforms.
ES6 syntax and promise structures make for clean logic, and for a server I should think you could add any dependencies you want, so looks great to me.
I have only considered experimenting with loki along with express services but that would be mainly for personal use/learning.
Look forward to seeing what you guys come up with, if you need to ask me anything feel free :)  Otherwise I will monitor and chime in if I see anything.

hey @johanneslumpe - the tcp server implementation i had there was not even a draft, i'm happy to keep it for archive purpose but it would probably be a good idea to start a new repo from scratch. We need a codename (like the http wrapper for lokijs is called Snaptun) - any ideas? @obeliskos ?

@techfort Do your codenames follow a specific pattern?

Generally names related to Norse mythology or Loki himself.  Any ideas? If you need suggestions I have a few :)

@obeliskos I'm open for ideas :) I know some Norse mythology but I'm not really well versed in it. The pipeline could be Sleipnir, because of its eight legs maybe.

@johanneslumpe @obeliskos Sleipnir sounds good - as it's one of Loki's children :)

@techfort cool :) Then the pipeline package shall be named Sleipnir! We need a name for the tcp server itself too @obeliskos

Ah ok, well whoever works on it the most should get final call.  I was just going to recommend some general names like Bifrost (or heimdal) or maybe less categorical 'huginn or muninn' (Odin's ravens)... but spleipnir is good.  Or depending on how you break up your modules you could apply any of those.

@obeliskos I'm keeping muninn for the next in memory db, because as you
surely know, muninn means "memory" :-D
On Thu 21 Jan 2016 22:55 obeliskos<EMAIL_ADDRESS>wrote:

Ah ok, well whoever works on it the most should get final call. I was just
going to recommend some general names like Bifrost (or heimdal) or maybe
less categorical 'huginn or muninn' (Odin's ravens)... but spleipnir is
good. Or depending on how you break up your modules you could apply any of
those.
—
Reply to this email directly or view it on GitHub
https://github.com/techfort/LokiJS/issues/272#issuecomment-173742012.

@Techfort next as in loki 2.0 or a completely different thing?
Sent from my iPhone

On 22 Jan 2016, at 09:07, Techfort<EMAIL_ADDRESS>wrote:
@obeliskos I'm keeping muninn for the next in memory db, because as you
surely know, muninn means "memory" :-D
On Thu 21 Jan 2016 22:55 obeliskos<EMAIL_ADDRESS>wrote:

Ah ok, well whoever works on it the most should get final call. I was just
going to recommend some general names like Bifrost (or heimdal) or maybe
less categorical 'huginn or muninn' (Odin's ravens)... but spleipnir is
good. Or depending on how you break up your modules you could apply any of
those.
—
Reply to this email directly or view it on GitHub
https://github.com/techfort/LokiJS/issues/272#issuecomment-173742012.

—
Reply to this email directly or view it on GitHub.

@johanneslumpe a completely different thing i think.  I'm writing a nosql db for android, but i already named that sigyn, so who knows.

@techfort So basically Loki is already EOL?

@johanneslumpe not at all! when i talk about other in-memory dbs i am talking anything from a java db for android to a c++ stream processor - LokiJS will outlive the Ragnarok. Sorry for the confusion there :)

There can be only one loki.js!.. wait that's wrong mythology.  I think your safe from worrying about that for awhile.   Norse mythology on the other hand seems always in flux.

@techfort ah ok, wasn't sure about that - thanks for the update :) So should the whole tcp server be Sleipnir for now? And then later we refactor the pure pipeline part out into a separate repo, to be used with the http server?

@obeliskos @johanneslumpe yes let's name sleipnir the tcp server. I created
the repo already, i'll edit the description.
On Fri, Jan 22, 2016 at 12:28 PM, Johannes Lumpe<EMAIL_ADDRESS>wrote:

@techfort https://github.com/techfort ah ok, wasn't sure about that -
thanks for the update :) So should the whole tcp server be Sleipnir for
now? And then later we refactor the pure pipeline part out into a separate
repo, to be used with the http server?
—
Reply to this email directly or view it on GitHub
https://github.com/techfort/LokiJS/issues/272#issuecomment-173908001.

@techfort sorry for not yet committing anything - have some stuff to deal with right now. Will do it as soon as possible.

hey - no rush.
On Mon, Jan 25, 2016 at 12:22 PM, Johannes Lumpe<EMAIL_ADDRESS>wrote:

@techfort https://github.com/techfort sorry for not yet committing
anything - have some stuff to deal with right now. Will do it as soon as
possible.
—
Reply to this email directly or view it on GitHub
https://github.com/techfort/LokiJS/issues/272#issuecomment-174489363.


feat: enhance supersim visual cli with mprocs

Description
This PR introduces the first phase of improving the visual development experience in supersim when running multiple nodes. The initial implementation uses mprocs to run and display supersim nodes in parallel, providing a quick solution that centralizes logs in a single interface. While mprocs doesn’t support all the desired visual enhancements (such as log tagging, use of emojis and icons, and collapsible sections), it provides a useful structure for running multiple nodes in parallel and is a solid starting point.

Steps implemented in this phase:

Configuration of mprocs to launch supersim and multiple anvil nodes in parallel.
Redirecting logs to a persistent folder (supersim-logs) for easier access and future review.

Future steps to improve the visual experience:

Log tags: Categorize log messages (e.g., [TRANSACTION], [DEPOSIT], etc.) to better organize information.
Log coloring: Apply different colors to parts of log messages to enhance readability.
Collapsible sections: Allow developers to expand or collapse sections of long logs to view summaries.
Emojis and icons: Incorporate emojis to visually represent different types of events, such as ✅ for successful transactions or 🔄 for events in progress.

This initial phase establishes a functional foundation for parallel log visualization, with the possibility of further enhancement in later steps.
Tests

Verified that supersim and anvil nodes launch correctly in parallel using mprocs.
Manually validated that logs are saved in the supersim-logs folder.
No automated tests were added in this phase, as the functionality of mprocs is primarily visual and focuses on developer experience. Future planned visual enhancements may include additional tests.

Additional context
This PR represents the initial step towards an improved CLI for logs in supersim, where mprocs provides a provisional solution that simplifies parallel execution of multiple nodes. This initial phase offers a basic visualization while further specific features are developed to enhance the visual experience.
Metadata

#207
#80

Appreciate your contribution!
But this does not satisfy the requirements. The binary that people run is supersim and that won't bundle in the typescript tooling (node, pnpm, etc.). Also we shouldn't be adding pnpm/typescript dependencies here.
In order for people to use this, they now need to clone the supersim repo, which is not the way supersim is meant to be consumed.
I think what would be helpful is to implement a TUI directly into supersim. One framework is https://github.com/charmbracelet/bubbletea but there are others too.

Thank you for your feedback; let me review it to propose an implementation.

Hi @wolfcito! I'm reviewing open PRs for repo maintenance and wanted to check in. Are you planning to make changes to this PR or can it be closed? Thanks, please let me know!

Hi @wolfcito! I'm reviewing open PRs for repo maintenance and wanted to check in. Are you planning to make changes to this PR or can it be closed? Thanks, please let me know!

Hi @fainashalts , I’d really like to work on this. I’ll be working on it over the weekend. If I find the time is too tight, I’ll let you know to close it.


NO_ISSUE: use release shared library

Depends on:

apache/incubator-kie-kogito-pipelines#1206

Where release share pipeline library was added with gpg specific methods to import keys,etc.

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2064 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2064/1/display/redirect
Test results:

PASSED: 1613
FAILED: 1

Those are the test failures:

org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService
java.util.ConcurrentModificationException	at java.base/java.util.ArrayList.forEach(ArrayList.java:1513)	at org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService(EmbeddedJobsServiceTest.java:99)	at java.base/java.lang.reflect.Method.invoke(Method.java:568)	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:1013)	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:827)	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2064 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/apache_migration/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2064/2/display/redirect
Test results:

PASSED: 558
FAILED: 1

Those are the test failures:

org.kie.kogito.jobs.service.management.JobServiceInstanceManagerTest.heartbeatLeader
repository.heartbeat(    JobServiceManagementInfo[id=null, lastHeartbeat=2024-05-29T07:41:15.774Z, token=a6bef71b-eff9-4b44-87ef-eb692fdbf0db]);Wanted 1 time:-> at org.kie.kogito.jobs.service.repository.impl.DefaultJobServiceManagementRepository.heartbeat(DefaultJobServiceManagementRepository.java:52)But was 2 times:-> at org.kie.kogito.jobs.service.management.JobServiceInstanceManager.heartbeat(JobServiceInstanceManager.java:186)-> at org.kie.kogito.jobs.service.management.JobServiceInstanceManager.heartbeat(JobServiceInstanceManager.java:186)

PR job #5 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2064 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/apache_migration/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2064/5/display/redirect
Test results:

PASSED: 1664
FAILED: 1

Those are the test failures:

org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents
1 expectation failed.JSON path errors doesn't match.Expected: null  Actual: <[{message=Exception while fetching data (/UserTaskInstances[0]/schema) : Runtime service URL not defined, please review the kogito.service.url system property to point the public URL for this runtime., locations=[{line=1, column=85}], path=[UserTaskInstances, 0, schema], extensions={classification=DataFetchingException}}]>


Channel settings dialog locks up Kodi if TCP-based tuner is not available

Testing the channel settings dialog on OSMC (Matrix) revealed that if the addon is configured for a non-existent or otherwise unavailable TCP-based tuner it will lock up Kodi with no way to recover other than rebooting the system.  While Channel Add / Channel Settings aren't expected to be perfect anytime soon they do need to be able to gracefully handle situations like this.  This can't go "live" with a defect like this.

Implementing #23 may help with this.

re-tested on Matrix and main; works as expected.  The timeout is a bit long but that's intentional to allow for non-customized rtl-tcp that can take a long time to respond


Inconsistensies on AdashimaaTube

1.View replies arrow:
AdashimaaTube:

Wayback Machine Archive from March 22nd,2022:

2.Search bar has 1 or 2 px roundness on the old layout and the search text is off:
AdashimaaTube;

Old searchbar:

don't mind that it doesn't ruin your viewing experience.


perf: query fewer historical messages on reconnects

Implements smaller ?limit on recent message query upon reconnects, as suggested in #4989
Note: system_clock is used instead of a strictly monotonic clock in anticipation of the since query parameter https://github.com/robotty/recent-messages2/issues/286

The service at https://recent-messages.robotty.de now has a ?before and ?after parameter. Updated documentation can be found here.

Changes look good to me! thank you @pajlada and @RAnders00

I'm going to merge this in, but one thing I thought about is the use case for when someone puts their computer to sleep with Chatterino running. Will Chatterino only request 10-20 messages upon the computer waking up in this case?

To be honestly we could have skipped the entire ?limit parameter calculation. The before and after parameters do everything for us, and I don't need the ?limit for server performance, filtering by time range without limit or with a high limit is just as efficient, it's all about the number of messages returned.

I made https://github.com/Chatterino/chatterino2/issues/5009 to track any follow-up changes related to sleep

To be honest we could have skipped the entire ?limit parameter calculation. The before and after parameters do everything for us, and I don't need the ?limit for server performance, filtering by time range without limit or with a high limit is just as efficient, it's all about the number of messages returned.

even if we omitted limit, the sleep issue would remain since it's likely that markDisconnectedNow occurs after the computer wakes from sleep


Photoshop Auto Color

I would like to automatically optimize the color of images at channel level, like in Photoshop using the Auto Color function (possibly also Auto Contrast).
I tried it under sharp using normalize but the image is then optimized based on the luminance of all color channels, I need optimization at channel level (R, G, B separately).
Thanks for any help.

Hi, did you see #1066, which may provide something similar?


Cannot find module 'async'

Hi
We're using a module named "assemble" and this module uses this one. The modules are installed with a "--production" flag. When using the assemble module, the following error occurs:

Error: Cannot find module 'async'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:286:25)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/var/app/buildslave/jenkins/workspace/Team Awesom-O/APM/APM Frontend/APM Frontend - deploy DEV/node_modules/assemble/node_modules/assemble-core/node_modules/templates/lib/plugins/context.js:3:13)

It seems the context.js file uses the async-module, but according to the package.json, this should just be a devDependency. I believe that's where the problem is located.
If you need any more information, let me know.
Kind regards,
Yannick

Thanks for pointing this out. We'll get it fixed.

Fixed in 0.13.4. You should be able to reinstall assemble to get the latest.

@doowb Works like a charm, thx for the fast fix!


be PEP-8 compliant and use a consistent naming convention

the naming conventions like jobId in the Job class clash with modern python.

I assume this was fixed in pull request https://github.com/troeger/drmaa2-python/pull/5, so it can be closed?


docs: Update change log for Kamakura release

Signed-off-by: Leonard Goodell<EMAIL_ADDRESS>

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rfid-llrp-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[ ] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[ ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Codecov Report

Merging #85 (6701f8d) into main (ed3f6ad) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   41.08%   41.06%   -0.03%
==========================================
  Files          21       21
  Lines        9016     9016
==========================================
- Hits         3704     3702       -2
- Misses       4142     4144       +2
  Partials     1170     1170

Impacted Files
Coverage Δ

internal/retry/retry.go
91.60% <0.00%> (-1.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3f6ad...6701f8d. Read the comment docs.


CPG: Admin page language download

repo: cpg
page in app: admin
data tables we need: ethnologue, iso, glottolog
tasks:

add a function to pull data from hard-coded webpages to get language table data. for now it could be our server.
store data in the graph using the graph layer 3 table api shown here.
create function to read from the graph table and create/update a table for every table that exists in the graph. So if there is a 'table' node in the graph for 'ethnologue', you will create an actual table called 'ethnologue'. You'll add columns and rows based on the data stored in the graph.


fix(scroll-area): scroll-area is now displayed correctly in Safari

Closes #757
Description
The bug was that in Safari the scrollbar did not appear when type==="hover" and the scroll area was hovered, and not appear when type==="scroll" and the scroll area was scrolled. The cause of this issue is that Safari does not visually update the css of the page.
Current behavior (updates)
I had to force a re-render of the page, assure that the scroll position did not reset to 0 after the re-render and avoid infinite loops when type==="scroll".
New behavior
The scrollbar now behaves correctly in the Safari Browser
Is this a breaking change (Yes/No): No

Additional Information

The test is probably not going to work due to the new infinite-scroll-area class.  The new exports in react/src/index.ts should be removed in order for pnpm test to work.

The test is probably not going to work due to the new infinite-scroll-area class. The new exports in react/src/index.ts should be removed in order for pnpm test to work.

Thanks for contributing!
Please ignore the matter of pnpm test for now.


feat(frontend): validateConvertAmount util

Motivation
The util that will be used in ConvertAmountSource as customValidate function for the input. I extracted it from the component for the unit testing purposes.

@AntonioVentilii they are a few differences between them (mostly, in return types - one uses strings, and another one Error), but my idea was that they indeed can be standardised and reused in the future. I added a TODO comment for now.

@AntonioVentilii ready for another look


Prepare an archive with everything to build the macOS pkg. Add codesign.

Works fine. No more pop-up.

/retest

I rebuild the pkg and will ask to test the signing again.

/lgtm


feat: Add CEL kw.crypto.verifyCert() function

Description
Relates to https://github.com/kubewarden/cel-policy/issues/8.
Depends on https://github.com/kubewarden/policy-sdk-go/pull/74.

Fix https://github.com/kubewarden/cel-policy/issues/15.
feat: Add CEL kw.crypto.verifyCert() function.
Test

CI

Additional Information
Tradeoff

Potential improvement

Blocked, consuming https://github.com/kubewarden/policy-sdk-go/pull/74. Once there's a new SDK, It can move forward.

Ready for review.


Make sure symbols in annotation trees are fresh before pickling

In a nutshell: when mapping annotated types, we can currently end up with the same symbol being declared in distinct trees, which crashes the pickler as it expects each symbol to be declared in a single place. See https://github.com/scala/scala3/pull/19957#discussion_r1644920020 and https://github.com/scala/scala3/pull/19957#discussion_r1644921716 for more context.
This PR ensures that all symbols in annotation trees are different by creating fresh symbols for all symbols in annotation tree during PostTyper.
In my previous attempt which was discussed on #19957, I did it in Annotations.mapWith. Here, it's only done once in PostTyper, so this is more lightweight.
Fixes #17939, fixes #19846 and fixes (partially?) #20272.

Minimized failing test:
package json

trait Reads[A] {
  def reads(a: Any): A
}

object JsMacroImpl {
  inline def reads[A]: Reads[A] =
    new Reads[A] { self =>
      def reads(a: Any) = ???
    }
}


Symbol not found: _ZNK5boost16re_detail_10620031cpp_regex_traits_implementationIcE17transform_primaryEPKcS4

When I try to run run_mission.py, I get this error...
Traceback (most recent call last):
File "run_mission.py", line 20, in
import MalmoPython
ImportError: dlopen(/Users/Krista/Desktop/CS 270/Malmo-0.19.0-Mac-64bit/Python_Examples/MalmoPython.so, 2): Symbol not found: _ZNK5boost16re_detail_10620031cpp_regex_traits_implementationIcE17transform_primaryEPKcS4
Referenced from: /Users/Krista/Desktop/CS 270/Malmo-0.19.0-Mac-64bit/Python_Examples/MalmoPython.so
Expected in: /usr/local/opt/boost/lib/libboost_regex-mt.dylib
in /Users/Krista/Desktop/CS 270/Malmo-0.19.0-Mac-64bit/Python_Examples/MalmoPython.so
I'm working on a mac, and this is the version of python I'm using....
Python 2.7.13 (default, Jan 21 2017, 22:42:15)
[GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-8<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
pretty sure it's 64 bit. I also ran with /usr/bin/python run_mission.py

Also running into the same problem with the pre-built release with Mac 64 bit...

Also ran into this problem on macOS Sierra 10.2.2 (official).
Tried building from source after seeing #445, and it works for me.

Closing this as it is a duplicate of #445.


runtime: resync mesonbuild files with 1.1.1

Thanks.  I'll update the "last change" header of the syntax file.
And add an entry in the filetype test.
--
From "know your smileys":
¯_(ツ)_/¯   Shrug
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Updated heading to show Quickstart

Updated heading to show that this is part of the Quickstart series.

@AzureMentor : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@AzureMentor - thanks for the fix.

#sign-off


Resolution

I'd love to see the resolution limit mentioned here. Took ma a few days of trial and error and a post to the forums to find out, that using 4k resolution is not possible for UWP games right now. I didn't see this mentioned anywhere in the documentation. I also don't understand why this limit there in the first place.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cadac27a-0221-3d25-65a2-6f52cc1adf7f
Version Independent ID: 2c90b166-8a59-15b5-dd8a-63a840a34d88
Content: System resources for UWP apps and games on Xbox One - UWP app developer
Content Source: windows-apps-src/xbox-apps/system-resource-allocation.md
Product: windows
GitHub Login: @mtoepke
Microsoft Alias: mstahl

Thank you for taking the time to let us know about this issue. Apologies for the delayed response. Due to the volume of feedback in our content, we are currently prioritizing new issues.
If you believe your feedback still requires an update to the documentation, please let us know either directly in this thread, by filing a new issue, or by filing a Pull Request  with your recommended updates.
Though the Issue will be marked as closed, we will still receive replies and are able to reopen the issue if necessary.
Thanks again for taking the time to contribute.

Since this issue was 2 years old, I have no idea, if the 4K limitation still exists on UWP. If yes, it would still be good to know on that page.


Getting a warning because of Node.js version used

When using the action, I'm getting a warning in my runner:
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20<EMAIL_ADDRESS>For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
It might just be a question of using actions/checkout@v4 instead of actions/checkout@v3/

Thanks for reporting, should be fixed from version v0.2.15


Force array type on some properties to match API schema

The API schema specifies that an array is returned for uncertainInteractions, unsafeInteractions, dangerousInteractions and effects. When only one item is returned by MediaWiki, a single item is returned instead of an array with a single item. As a result, the GraphQL API returns null due to type mismatch. Example: dangerous interactions of LSD.
Alternative considered: Remove call to _flattenIfNeeded() here. However, seems to cause too many issues with other properties.

Thanks!

Deployed.


Mkirk/style fixups

side-by-side layout for elevation/route charts
IMO the elevation chart looked pretty bad blown up to full-width on desktop.
Arguably the route overview looked better at full width (before), but I think it's still legible enough, and overall worth the tradeoff.
before

after

fix chart style for mdbook
images we scale and crop to fit our layout, but we don't want to do that with charts. This was a bug introduced when porting to mdbook.
before

after

All 3 style changes LGTM!

I pushed up some additional changes since this is as-of-yet unmerged. If you'd prefer I can open a separate PR.
PTAL!

Fixed the typos, thanks!

http://abstreet.s3-website.us-east-2.amazonaws.com/0.2.51/abstreet.html?--dev&system/us/seattle/scenarios/arboretum/weekday.bin&--edits=broadmoor access  is now live


Get rid of unused classes.

Remove all unnecessary fields/classes.

dedicated effort to remove unused classes / resource files is done - the code now only contains essential classes, so ready for the initial release (#7)


Please Add AppImage version release of Sparrow Wallet.

Please Add AppImage version of Sparrow Wallet.
This would be great if a AppImage binary of Sparrow was available for TailsOS users, Live users, or users that would like to have and executable for Sparrow saved on another drive etc. Currently in Tails the sparrow "debian software package" .deb binary can't be persistently installed on Tails persistence storage. You have to run sudo dpkg -i sparrow_version_amd64.deb evertime. However you can persist the Configuration files that you choose so you don't have to input <IP_ADDRESS>:9050 or remote nodes each time by running this command then rebooting:
echo -e '/home/amnesia/.sparrow source=sparrow' | sudo tee -a /live/persistence/TailsData_unlocked/persistence.conf > /dev/null

Releasing a AppImage similair to Feather Monero Wallet that saves the wallet_data ie the config/settings/wallets etc.  next to the AppImage binary in the directory wherever it is saved instead of the /home dir would be the way to go.

Also noted Tails switched to Wayland to so it would need support for that. Which I believe it already does cause Sparrow has no issues launching/opening on Tails Version 5.8. Just no way to persist the install of it currently.

Duplicate of #1. While I appreciate this solution, I would rather put work into #372.
Note you can specify the Sparrow home folder with the -d flag.

For those interested in building AppImage, I've created a script for that.
In addition to creating AppImage it also can create and install Binary and Java packages.
Please find the script attached:
sparrow.sh.txt
@craigraw
Please consider adding AppImage build based on the script or the script itself somewhere in the tree.


line number (%Line) output is not right

git rev-parse HEAD output is:
f561c5e57575bb1e0a2167028b7339b3a8d16fb4
go version output is:
go version go1.8 linux/amd64
my test code is (test.go):
package main

import (
    "github.com/cihub/seelog"
)

func main() {
    log, err := seelog.LoggerFromConfigAsString(`<seelog type="sync">
        <outputs>
            <console formatid="fmt"/>
        </outputs>
        <formats>
            <format id="fmt" format="[%RelFile:%Line] [%Func] [%Lev] %Msg%n"/>
        </formats>
        </seelog>`)
    if err != nil {
        panic(err)
    }
    defer log.Flush()
    log.Debug("Test") // line 20
    log.Info("Test2") // line 21
}

but go run test.go output is:
[test.go:21] [main.main] [Dbg] Test
[test.go:22] [main.main] [Inf] Test2

I find the same, but this seems to be the line number returned by Go's standard library. Seelog is not introducing the off-by-one error. Perhaps this should be reported upstream?


Missing DataFiles (txt files)

Cave connections are hardcoded instead of being in a text file.
HighScore references "studentDataFile" but this file doesn't exist in the solution
Trivia doesn't reference a file at all (currently broken)

Trivia looks to be referencing a file, and the solution also has the file.
Commit: 2167d30ecd8496339f9c6ac450cfe14c531edce4

Cave text files got added here: 2552ef28b101b0199ca1bd4d2cc12951a49058b0
StudentDataFile got added here: 23d36f7e584f88e92f537dbfa96410d2ac147147


[python] adding Hive package to wrap BaseMetastoreTables/TableOperations

This adds a package for connecting to hive metastore to manage iceberg tables. Also, fixes one minor lint issue.

@rdblue @danielcweeks Can you take a look and see if this looks good?  If we can get this merged, I'll update the docs and push those today too.


Tooling request: use a large test corpus

We could run the resulting parser over all the git commit messages from a long-running OSS project such as the Linux kernel to identify parser bugs and performance issues. This parser shouldn't detect any errors since the commit messages are (by construction) valid.
Would you be interested in a PR with a script that could run this kind of fuzz/benchmarking test?

The commit messages themselves almost never have parse failures - errors tend to come from trying to parse the description in the comments. Those comments are dropped when performing the commit so we're left with just basic messages which are very easy to parse.
Tree-sitter grammar repositories for some programming languages have integration tests that clone some popular libraries and run the parser in test mode against those. I don't think it makes sense to do that for commit messages though since there aren't any really good examples with comments. It would be good to expand the unit tests though with more cases


Team create command is not working

Upon using the /teamcreate  command it returns this:

Issue has been noticed by several players

seems to be fixed awhile back


[incubator/ibm-blockchain-network] Add IBM Blockchain Network

Source code located in the following repository:

https://github.com/IBM-Blockchain/ibm-container-service

See comments on #2071.

@unguiculus, changes have been added.

@unguiculus, I've added the namespaces.

@unguiculus, the templates should be namespaced now.

@unguiculus, this PR should be up-to-date with the requested changes from https://github.com/kubernetes/charts/pull/2071.

Standard labels are still missing, label selectors point to missing labels, CircleCI still fails. Please study best practices and review guidelines!
https://github.com/unguiculus/charts/blob/master/REVIEW_GUIDELINES.md


No way to catch error in findUniqueOrThrow via middleware

Also their is no way to catch and massage the error (to change its message for example).
With findUniqueOrThrow, in a middleware result is null and params.action is findUnique:
prismaClient.$use(async (params, next) => {
  try {
    const result = await next(params);
    return result;
  } catch (error) {
    // nothing to see here
    throw error;
  }
});

With rejectOnNotFound, the un-exported error (treatable with error.constructor.name === 'NotFoundError' btw) was thrown inside.

Originally posted by @bbenezech in https://github.com/prisma/prisma/issues/14209#issuecomment-1180183113

@bbenezech this sounds like a separate issue for me, is that right? If that's the case, could you please open a separate GitHub issue for this to avoid any confusion, and, most importantly, avoid your report being lost, since the issue @PatrikValkovic refers to has already been fixed, and someone might close it without looking at your comment.

Originally posted by @aqrln in https://github.com/prisma/prisma/issues/14209#issuecomment-1183075537

Tracked in #16226


BUG: image-cri-shim does not support Kubernetes v1.28.0

Sealos Version
v4.3
How to reproduce the bug?
No response
What is the expected behavior?
No response
What do you see instead?
No response
Operating environment
- Sealos version: v4.3.1-rc1
- Docker version:
- Kubernetes version: v1.28.0
- Operating system: Ubuntu 20.04
- Runtime environment:
- Cluster size:
- Additional information:

Additional information
  --image-service-endpoint string                            The endpoint of container image service. If not specified, it will be the same with --container-runtime-endpoint by default. Unix Domain Socket are supported on Linux, while npipe and tcp endpoints are supported on Windows. Examples:'unix:///path/to/runtime.sock', 'npipe:////./pipe/runtime' (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.)

W0816 03:12:24.833338    3281 checks.go:835] detected that the sandbox image "sealos.hub:5000/pause:3.9" of the container runtime is inconsistent with that used by kubeadm. It is recommended that using "registry.k8s.io/pause:3.9" as the CRI sandbox image.
158

https://kubernetes.io/zh-cn/docs/reference/config-api/kubelet-config.v1beta1/

upgrating to 1.27.4


Upgrade com.google.guava:guava 31.1-jre -> 32.0.0-jre

This PR contains the following updates:

Package
Type
Update
Change

com.google.guava:guava
compile
major
31.1-jre -> 32.0.0-jre

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Guava 31.1-jre -> 32.0.0-jre


Kconfig: problems with using backslash-escapes in "default" value of "string" option

I'm trying to use following snippet in a Kconfig:
config SAMPLE_BIG_HTTP_DL_HASH
	string "Hash of downloaded file"
	default "\x33\x7c\x37\xd7\xec\x00\x34\x84\x14\x22\x4b\xaa\x6b\xdb\x2d\x43\xf2\xa3\x4e\xf5\x67\x6b\xaf\xcd\xca\xd9\x16\xf1\x48\xb5\xb3\x17"

However, zephyr/.config with that setting gets:
CONFIG_SAMPLE_BIG_HTTP_DL_HASH="x33x7cx37xd7xecx00x34x84x14x22x4bxaax6bxdbx2dx43xf2xa3x4exf5x67x6bxafxcdxcaxd9x16xf1x48xb5xb3x17"

When I try to used double-backslashes in Kconfig:
	default "\\x33\\x7c\\x37\\xd7\\xec\\x00\\x34\\x84\\x14\\x22\\x4b\\xaa\\x6b\\xdb\\x2d\\x43\\xf2\\xa3\\x4e\\xf5\\x67\\x6b\\xaf\\xcd\\xca\\xd9\\x16\\xf1\\x48\\xb5\\xb3\\x17"

I get in zephyr/.config:
CONFIG_SAMPLE_BIG_HTTP_DL_HASH="\\x33\\x7c\\x37\\xd7\\xec\\x00\\x34\\x84\\x14\\x22\\x4b\\xaa\\x6b\\xdb\\x2d\\x43\\xf2\\xa3\\x4e\\xf5\\x67\\x6b\\xaf\\xcd\\xca\\xd9\\x16\\xf1\\x48\\xb5\\xb3\\x17"

Complete reproducible case can be found in this branch: https://github.com/pfalcon/zephyr/commits/big_http_download-kconfigurable

@ulfalizer, Hopefully you can look into this.

We discussed this issue yesterday on Slack with @ulfalizer. Just to summarize it, the current situation is that you can't pass a string with a single backslash from Kconfig default value down to autoconf.h file generated by kconfiglib (indeed, autoconf.h is the real problem spot, as that's what gets included from C source, not .config). Currently, you can pass either 0 or 2 slashes, with 1 being gapped.
Based on @ulfalizer guidance thru the kconfiglib source, I came with the following patch which satisfies my concern:
--- a/scripts/kconfig/kconfiglib.py
+++ b/scripts/kconfig/kconfiglib.py
@@ -1488,7 +1488,7 @@ class Kconfig(object):

             elif sym.orig_type is STRING:
                 add('#define {}{} "{}"\n'
-                    .format(self.config_prefix, sym.name, escape(val)))
+                    .format(self.config_prefix, sym.name, val))

             else:  # sym.orig_type in _INT_HEX:
                 if sym.orig_type is HEX and \

With this change, things on the Kconfig side need to be extra-quoted, i.e. default "\\x33\\x7c\\x37" leads to #define CONFIG_SAMPLE_BIG_HTTP_DL_HASH "\x33\x7c\x37". This extra level of quoting is completely ok from my side, as long as the rules for quoting are consistent and monotonic (there's no random gaps between 0 and 2 number of slashes output).
One issue is that the change as presented above applies to the autoconf.h output and not .config output. This is again based on @ulfalizer's concern that .config is normally included in Makefile's, and they may have other quoting requirements than C. Another obvious concern is that this change may lead to a different behavior than the referece Kconfig implementation written in C (as used by Linux kernel, etc.).
My reply to the latter concern would be that it could be the case that processing backslash quotes may be not much used in the original kernel Kconfig, and thus not very well defined. It could be the case that being "bug-to-bug compatible" with the original Kconfig isn't really required and there can be more useful behavior proposed here.
I could also understand the position of being "bug-to-bug compatible", as after all, that simplifies testing, by allowing to just compare the outputs of 2 systems for exact matches under any input thrown at them. In this case, I would propose to add another value type with the desired behavior, e.g.:
config SAMPLE_BIG_HTTP_DL_HASH
	rawstring "Hash of downloaded file"
	default "\\x33\\x7c\\x37..."

Note the rawstring type. This would be an extension not used by Linux kernel, but which is useful for Zephyr and other project with deeper C integration needs (like, need to inject raw/binary C strings in the config, without relying that there will be any "frontend" on the application side which can accept human-readable representation as input and parse it internally).
All in all, recording these findings and ideas, and handing over to @ulfalizer for further analysis and decision-making. Thanks.

For reference, PR affected by this issue: https://github.com/zephyrproject-rtos/zephyr/pull/24124#issuecomment-609791549 , where I had to scale down originally configurability effort, and keep some hardcoded things as such.

In the meantime @pfalcon, does 0x<long number> work?

@carlescufi

In the meantime @pfalcon, does 0x work?

No, the talk here is about being able to specify arbitrary-length binary string, not limited-length binary number. (If you hint at being able to break down a long binary string into a number of integer-values options, like SAMPLE_BIG_HTTP_DL_HASH_INT_0, SAMPLE_BIG_HTTP_DL_HASH_INT_1, ... SAMPLE_BIG_HTTP_DL_HASH_INT_100, then apparently it's a pretty unbeautiful and not scalable workaround.)

@ulfalizer: Ping. It occurred to me that while we discussed this issue at length on the Slack, this ticket didn't receive any comment from you.


Bug Report: Kade engine not launching

Please check for duplicates, similar issues or closed issues with the same problem, as well performing simple troubleshooting steps (such as deleting the export folder if it's an issue with compiling, reinstalling Kade Engine) before submitting an issue.
If you are playing a downloaded version of the game, what operating system are you using?
Windows (x86), Windows (x86_64), Linux, or macOS? Specify below.
windows x64
What version of the game are you using? Look in the bottom left corner of the main menu.
i dont know
Have you identified any steps to reproduce the bug? If so, please describe them beloo
no
Please describe your issue. Provide extensive detail and images if possible.
I enter lime test windows, it gives me this and nothing happens. i followed this tutorial:https://www.youtube.com/watch?v=cZEnYCUSJ2E&t=104s&ab_channel=HippoBoii
the tutorial told me to wait after entering lime test windows so i did and nothing happens. what do i have to do

read the building.md


[SPARK-30812][SQL][CORE] Revise boolean config name to comply with new config naming policy

What changes were proposed in this pull request?

Revise below config names to comply with new config naming policy:
SQL:

spark.sql.execution.subquery.reuse.enabled / SPARK-27083
spark.sql.legacy.allowNegativeScaleOfDecimal.enabled / SPARK-30252
spark.sql.adaptive.optimizeSkewedJoin.enabled / SPARK-29544
spark.sql.legacy.property.nonReserved / SPARK-30183
spark.sql.streaming.forceDeleteTempCheckpointLocation.enabled / SPARK-26389
spark.sql.analyzer.failAmbiguousSelfJoin.enabled / SPARK-28344
spark.sql.adaptive.shuffle.reducePostShufflePartitions.enabled / SPARK-30074
spark.sql.execution.pandas.arrowSafeTypeConversion / SPARK-25811
spark.sql.legacy.looseUpcast / SPARK-24586
spark.sql.legacy.arrayExistsFollowsThreeValuedLogic / SPARK-28052
spark.sql.sources.ignoreDataLocality.enabled / SPARK-29189
spark.sql.adaptive.shuffle.fetchShuffleBlocksInBatch.enabled / SPARK-9853

CORE:

spark.eventLog.erasureCoding.enabled / SPARK-25855
spark.shuffle.readHostLocalDisk.enabled / SPARK-30235
spark.scheduler.listenerbus.logSlowEvent.enabled / SPARK-29001
spark.resources.coordinate.enable / SPARK-27371
spark.eventLog.logStageExecutorMetrics.enabled / SPARK-23429

Why are the changes needed?

To comply with the config naming policy.
Does this PR introduce any user-facing change?

No. Configurations listed above are all newly added in Spark 3.0.
How was this patch tested?

Pass Jenkins.

Note that I tried to list all the configs which break the policy from year 2019 rather than from Spark 2.0.

Test build #118364 has started for PR 27563 at commit 30d927f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23121/
Test PASSed.

Test build #118364 has finished for PR 27563 at commit 30d927f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
``

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118364/
Test FAILed.

Test build #118366 has started for PR 27563 at commit fd42674.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23123/
Test PASSed.

Test build #118366 has finished for PR 27563 at commit fd42674.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118366/
Test FAILed.

Test build #118369 has started for PR 27563 at commit 165fefa.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23126/
Test PASSed.

Test build #118369 has finished for PR 27563 at commit 165fefa.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118369/
Test FAILed.

retest this please

Test build #118384 has started for PR 27563 at commit 165fefa.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23141/
Test FAILed.

Oh, is this backward compatible, @Ngone51 ? I'm wondering all of these are new configurations added at 3.0.0.

@dongjoon-hyun We're targeting at configs added in 3.0 only without any backward compatible maintain in this PR.
I'll check them again for sure.

Test build #118384 has finished for PR 27563 at commit 165fefa.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118384/
Test FAILed.

Hi @dongjoon-hyun , I've checked again and attached all the related JIRAs.

also cc @cloud-fan

Test build #118388 has started for PR 27563 at commit dcb67b6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23145/
Test PASSed.

Test build #118388 has finished for PR 27563 at commit dcb67b6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118388/
Test FAILed.

Test build #118400 has started for PR 27563 at commit 56bc2c9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23157/
Test PASSed.

Test build #118400 has finished for PR 27563 at commit 56bc2c9.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118400/
Test FAILed.

Jenkins, retest this please.

Test build #118402 has started for PR 27563 at commit 56bc2c9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23161/
Test PASSed.

Test build #118402 has finished for PR 27563 at commit 56bc2c9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118402/
Test PASSed.

FYI I've open the PR to document naming guidelines: https://github.com/apache/spark/pull/27577

Hi @dongjoon-hyun , I've checked again and attached all the related JIRAs.

I've double-checked that; all the boolean options below are generated by running code in v2.4.5/master. I've checked that all the boolean configs in this PR are included in the list below;
// All the boolean SQL options newly added in v3.0.0
+--------------------------------------------------------------+
|_c0                                                           |
+--------------------------------------------------------------+
|spark.sql.adaptive.forceApply                                 |
|spark.sql.adaptive.optimizeSkewedJoin.enabled                 |
|spark.sql.adaptive.shuffle.fetchShuffleBlocksInBatch.enabled  |
|spark.sql.adaptive.shuffle.localShuffleReader.enabled         |
|spark.sql.adaptive.shuffle.reducePostShufflePartitions.enabled|
|spark.sql.analyzer.failAmbiguousSelfJoin.enabled              |
|spark.sql.ansi.enabled                                        |
|spark.sql.cbo.planStats.enabled                               |
|spark.sql.codegen.aggregate.map.vectorized.enable             |
|spark.sql.codegen.aggregate.splitAggregateFunc.enabled        |
|spark.sql.csv.filterPushdown.enabled                          |
|spark.sql.datetime.java8API.enabled                           |
|spark.sql.defaultUrlStreamHandlerFactory.enabled              |
|spark.sql.execution.arrow.sparkr.enabled                      |
|spark.sql.execution.pandas.arrowSafeTypeConversion            |
|spark.sql.execution.subquery.reuse.enabled                    |
|spark.sql.inMemoryTableScanStatistics.enable                  |
|spark.sql.jsonGenerator.ignoreNullFields                      |
|spark.sql.legacy.addDirectory.recursive.enabled               |
|spark.sql.legacy.allowNegativeScaleOfDecimal.enabled          |
|spark.sql.legacy.arrayExistsFollowsThreeValuedLogic           |
|spark.sql.legacy.bucketedTableScan.outputOrdering             |
|spark.sql.legacy.createHiveTableByDefault.enabled             |
|spark.sql.legacy.dataset.nameNonStructGroupingKeyAsValue      |
|spark.sql.legacy.exponentLiteralAsDecimal.enabled             |
|spark.sql.legacy.fromDayTimeString.enabled                    |
|spark.sql.legacy.integralDivide.returnBigint                  |
|spark.sql.legacy.json.allowEmptyString.enabled                |
|spark.sql.legacy.looseUpcast                                  |
|spark.sql.legacy.property.nonReserved                         |
|spark.sql.legacy.sessionInitWithConfigDefaults                |
|spark.sql.legacy.setCommandRejectsSparkCoreConfs              |
|spark.sql.legacy.timeParser.enabled                           |
|spark.sql.legacy.typeCoercion.datetimeToString.enabled        |
|spark.sql.optimizer.dynamicPartitionPruning.enabled           |
|spark.sql.optimizer.dynamicPartitionPruning.reuseBroadcast    |
|spark.sql.optimizer.dynamicPartitionPruning.useStats          |
|spark.sql.optimizer.expression.nestedPruning.enabled          |
|spark.sql.optimizer.serializer.nestedSchemaPruning.enabled    |
|spark.sql.orc.mergeSchema                                     |
|spark.sql.sources.ignoreDataLocality.enabled                  |
|spark.sql.sources.validatePartitionColumns                    |
|spark.sql.streaming.checkpoint.escapedPathCheck.enabled       |
|spark.sql.streaming.fileSource.schema.forceNullable           |
|spark.sql.streaming.forceDeleteTempCheckpointLocation.enabled |
|spark.sql.streaming.stopActiveRunOnRestart                    |
|spark.sql.streaming.ui.enabled                                |
+--------------------------------------------------------------+

@maropu Thanks for the double check.  It's awesome! Probably, we could add some missing configs from the list into this PR.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23367/
Test PASSed.

Test build #118614 has started for PR 27563 at commit 83fda3c.

Test build #118614 has finished for PR 27563 at commit 83fda3c.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118614/
Test FAILed.

retest this please

Test build #118617 has started for PR 27563 at commit 83fda3c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23370/
Test PASSed.

Test build #118617 has finished for PR 27563 at commit 83fda3c.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118617/
Test FAILed.

retest this please

Test build #118625 has started for PR 27563 at commit 83fda3c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23378/
Test PASSed.

Test build #118625 has finished for PR 27563 at commit 83fda3c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118625/
Test PASSed.

thanks, merging to master/3.0!

thanks all!!


Proposal: Add Homebrew support

Description
It is cumbersome to download an executable from GitHub and put it into /usr/local/bin whenever a new release comes out. Life would be a lot easier if I could download dtm by running brew install dtm and upgrade it by running brew upgrade dtm.
Describe the Proposal
Add a new formulae to Homebrew. See https://docs.brew.sh/Adding-Software-to-Homebrew
Has the Feature been Requested Before?
no
Describe the Alternatives You Have Considered
n/a
Additional Context
n/a

Thanks for this great proposal.
Please hold on for a moment; we probably need to fork homebrew into another org.

It seems like we can't put devstream to homebrew-core according to: https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae

Our policy is that formulae in the core tap (homebrew/core) must be open-source with an Debian Free Software Guidelines license

DevStream has Apache 2.0 license and it seems it's not DFSG-free.
I propose we maintain a new tap: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap
For now, please use this one https://github.com/devstream-io/homebrew-devstream and create a PR there. Thanks!

See https://github.com/devstream-io/homebrew-devstream/pull/1

Brew now is supported from version v0.3.1. Thanks for contributing.


Multistage Dockerfile support for docker-from-docker feature

Currently the docker-from-docker feature doesn't support multistage Dockerfiles
Relates to: Remote - Containers
It works well with the following Dockerfile
FROM python:3.10.5
RUN apt-get update -q \
    && apt-get install -q -y --no-install-recommends \
        sudo
# add non-root user with sudo access (sudo required by docker-from-docker feature)
RUN adduser vscode
RUN echo vscode ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/vscode \
    && chmod 0440 /etc/sudoers.d/$USERNAME
USER vscode

and the following .devcontainer.json file
        "dockerFile": "Dockerfile",
        "containerUser": "vscode",
	"features": {
		"docker-from-docker": {
			"version": "latest"
		}
	}

It actually works with a named stage in the Dockerfile like
FROM python:3.10.5 AS vscode_dev
RUN apt-get update -q \
    && apt-get install -q -y --no-install-recommends \
        sudo
# add non-root user with sudo access (sudo required by docker-from-docker feature)
RUN adduser vscode
RUN echo vscode ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/vscode \
    && chmod 0440 /etc/sudoers.d/$USERNAME
USER vscode

as long as the build target in not explicitly mentioned in the .devcontainer.json file
        "dockerFile": "Dockerfile",
	"build": { "target": "vscode_dev" }, <--- NOTE: works without this line!
        "containerUser": "vscode",
	"features": {
		"docker-from-docker": {
			"version": "latest"
		}
	}

I believe this is a bug, not a feature-request.
I'm having the same problem, but this has not always been the case. In older versions of either VS Code or the VS Code Remote - Containers extensions the docker-from-docker feature has been working as expected, even with multi-stage builds.
I have/had multiple devcontainers which was built before the summer, where the docker.sock is still mounted at /run/docker.sock, despite that build using multi-stage Docker builds. I tried rebuilding one of them and suddenly docker.sock is no longer mounted.
Minimum viable test example below. Remove the "build" row from devcontainer.json to get a functioning docker.sock link.
In both cases though, no matter if we add a target or not, both files are created under /tmp which shows everything is running. There is just something about suddenly specifying the target stage which breaks the docker.sock linking.
devcontainer.json
{     "name": "Test",     "dockerFile": "Dockerfile",     "features": { "docker-from-docker": "20.10" },     "build": { "target": "development" } // Remove this to make the linking of docker.sock work again }
Dockerfile
FROM debian:11-slim AS base RUN touch /tmp/test1.txt FROM base AS development RUN touch /tmp/test2.txt

I believe this is a bug, not a feature-request.
I'm having the same problem, but this has not always been the case. In older versions of either VS Code or the VS Code Remote - Containers extensions the docker-from-docker feature has been working as expected, even with multi-stage builds.
I have/had multiple devcontainers which was built before the summer, where the docker.sock is still linked/mounted at /run/docker.sock, despite that build using multi-stage Docker builds. I tried rebuilding one of them and suddenly docker.sock is no longer there.
Minimum viable test example below. Remove the "build" row from devcontainer.json to get a functioning docker.sock link. In both cases though, no matter if we add a target or not, both files are created under /tmp which shows everything is running. There is just something about suddenly specifying the target stage which breaks the docker.sock linking.
devcontainer.json
{
    "name": "Test",
    "dockerFile": "Dockerfile",
    "features": { "docker-from-docker": "20.10" },
    "build": { "target": "development" } // Remove this to make the linking of docker.sock work again
}

Dockerfile
FROM debian:11-slim AS base
RUN touch /tmp/test1.txt
FROM base AS development
RUN touch /tmp/test2.txt

A workaround to get docker-from-docker working again while keeping the multi-stage builds
In your Dockerfile, add the installation of the docker-ce-cli (NOT docker-ce, containerd.io etc, just the cli)
Below is basic example for Debian, follow the Docker installation instructions for the relevant distro if you are running something else, but make sure you don't install anything but the cli, since we want to run on our host machines docker.
RUN apt update
RUN apt install -y ca-certificates curl gnupg lsb-release
RUN mkdir -p /etc/apt/keyrings
RUN curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor -o /etc/apt/keyrings/docker.gpg
RUN echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/debian $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null
RUN apt update
RUN apt install -y docker-ce-cli

Add a postCreateCommand to devcontainer.json which links the /run/docker-host.sock to the /run/docker.sock.
Remember to keep the docker-from-docker feature, since that adds our docker-host.sock bind mount, which we need.
"postCreateCommand": "ln -s /run/docker-host.sock /run/docker.sock"

Rebuild the container. Everything should be working again.

This actually sounds like features may not be respecting the "target" property which I'd agree is a bug.  @chrmarti @jkeech @joshspicer @alexdima - you agree?  If so, we should probably raise this at https://github.com/devcontainers/cli

Continuing in https://github.com/devcontainers/cli/issues/120. Thanks.


Fix demo issue

Coverage remained the same at 28.137% when pulling 4824f51edfc8892ba78046d54bb45d08ba48595d on htynkn:master into 645efcf8fe561a99d564d3ff1bd29f626279d47a on tianqiujie:master.


Google doc got taken down

the google doc linkt to this page got taken down

true

Yeah I was inactive for awhile. I'm working on fixing stuff the next two weeks.

From: WithermaskScool @.>
Sent: Tuesday, February 27, 2024 12:13 PM
To: vidio-boy/Eaglercraft1.8.8 @.>
Cc: Subscribed @.***>
Subject: Re: [vidio-boy/Eaglercraft1.8.8] Google doc got taken down (Issue #1)
true
—
Reply to this email directly, view it on GitHubhttps://github.com/vidio-boy/Eaglercraft1.8.8/issues/1#issuecomment-1967202059, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5O7RWOTGHP63FJZRTPITZ3YVYH4TAVCNFSM6AAAAAA7SLQILCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXGIYDEMBVHE.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

the google doc linkt to this page got taken down

Done! It was easier than I thoght, I just needed to use the Wayback Machine.


Updated Wetlands CVS reference on CKAN

The CSV file for wetlands has been recreated on CKAN, creating a new document reference.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Who can update the production site?
It was a AWS S3 bucket last time I was at DPaW.  I don't have the credentials any more.

@serge-gaia OIM can update the production application, via change request from application custodian.


Use Perl's switch parsing argument to pass variables to scripts

This is in the same line as commit 7c4b4545c07e273a815135fc04c4d1ee3a140f1b.

I've been running this patch for a while now, but I'm not sure I have tested everything. Please look over the patch and let me know if you see any issues.

This is too much of a mess. I'm going to start over.


Add dummy rules highlighting

Rules, unreachable from the entry rule, called dummy rules. Currently they are useful and used to generate AST types, however, we are going to replace them for that use case by extending the grammar language with special type rules (discussion/91). This makes dummy rules useless, so we should highlight them for fast and simple detection and further embedding or removing.

Dummy rules are already marked as unused as of https://github.com/langium/langium/commit/ad265815d5f6a4df27dad7b708a528f8aad5af29:


This mod does not work with 1.21 in the curseforge app

Minecraft version
1.21.x
ToolSwap version
1.21-6.00
NeoForge version
forge-51.0.33
The latest.log file
N/A
Issue description
the app will not recognize that the mod will work with anything aside from 1.16.2 through 1.16.5.
Steps to reproduce
No response
Other information
No response

Which app? You should have provided a log file.

Through forge. It only works through forge for Minecraft versions 1.16.2-1.16.5. There is no log file because it won’t work with 1.20 it doesn’t even give the option to try.Sent from my iPhoneOn Aug 27, 2024, at 10:22 PM, MelanX @.***> wrote:
Which app? You should have provided a log file.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Ahh, the problem is that you use Forge, not NeoForge, I guess. At least if 1.21 is your version. Now, you said something about 1.20. Maybe you downloaded a 1.16 version? I have no idea with no exact info about everything you use exactly.


Include query URL in tracked_affected_email

Provides an easy way to get an updated list.
Fixes #87

Coverage decreased (-0.2%) to 47.715% when pulling 3aba708c885ad551d62ac176c853770acb400e54 on jcristau:include-query-url into bf87cf1f3c5f6e7ad4bcf22a0c7852613472ef9f on mozilla:master.


AWT canvas approach for LWJGL3

Currently, we still have LwjglCanvas for LWJGL2 backend, which gives us freedom to incorporate a LibGDX module anywhere to an AWT/Swing component based application. That's a really good option for any desktop application/tool that can benefit from java native GUI widget toolkit.
I see that Lwjgl3Graphics code is significantly different from LwjglGraphics and doesn't expect to work with anything but a window directly. So my question is if there are any plans to extend LWJGL3 backend with that sort of behavior, because seems like I'm really stuck with LWJGL2 forever with my desktop non-game related projects and see no easy way to utilize LWJGL3 backend for that case.

LWJGL3 uses GLFW which doesn't work well with AWT. I doubt it ever will but you should ask the LWJGL3 guys as this is outside of libgdx.
FWIW, due to LWJGL2 working poorly on OS X, Mario and I hacked up GLFW into a JGFLW backend that worked with AWT on OS X (the JGLFW backend has since been removed from libgdx, since it was really only useful for OS X, but could be dug out and made to work). Spine requires AWT for reasons and uses LWJGL2 on Windows and Linux and JGFLW on OS X. Like your app, Spine is unable to move to LWJGL3 (multi-window support would be great). Since we did manage to get GLFW working with AWT (though it required changes to GLFW which were submitted but not all were accepted into GLFW), it should be possible for LWJGL3 to do so also.

The problem is that LWJGL3 is fundamentally unfit to work with AWT/Swing. This is not something that can be fixed I'm atraid.

@NathanSweet thanks for the insight details. I really don't have any strong reason to move to LWJGL3 yet, but I guess it's just a matter of time before LWJGL2 backend is removed from LibGDX or at least LWJGL2 will become a way too outdated itself.
@badlogic Yep, I see it clearly now.
I've found this relatively fresh JGLFW repo. Is it what you're using for OS X, right? Does it have any real potential to be good universal desktop backend at all?

I doubt we'll remove LWJGL2 until LWJGL3 can support AWT, which may be never. gdx-tools relies on it (as does Spine).

Is it what you're using for OS X, right? Does it have any real potential to be good universal desktop backend at all?

Yep, and nope. I don't think any changes have been made to it since it was removed from libgdx. It is not for general use though, only for OS X (I had trouble on Linux so didn't bother making that work, but I think Windows was OK). To do it properly, LWJGL3 would be made to work with AWT on all OSes, then we'd have the best of all worlds.
Again, definitely pester the LWJGL3 guys and see if they will work on supporting AWT. It's possible since we use GLFW on OS X with AWT in Spine. We'd be happy to assist the LWJGL3 guys if that would help.

Seems there is progress in LWJGL https://github.com/LWJGLX/lwjgl3-awt


Support for template post install script

Summary:
Thank you all for the work you've put into this CLI, I really appreciate it! 👍
With this PR I want to add support for template post install scripts. Those scripts come in handy when there's some extra work needed to set up the new project.
For example in the TypeScript template some extensions to the Jest configuration in the package.json have to be made. Instead of a manual process, a post install script could take care of it.
Test Plan:
Went with the guide in the CONTRIBUTION.md document, installed Verdaccio, released a new version of React Native to it and used it to create a new project with a template that doesn't have a post install script and one that has it, to check if both scenarios will work.

Hey, thanks for submitting this PR.
Looks interesting as a workaround to solving some of the issues we have faced with current implementation of generators, such as removing extraneous fonts.
@Esemesek and @thymikee - let me know what you think.

We could merge it as a temporary solution, but we're going to change templates to just run yarn install, so postinstall scripts and alike will just work. So I lean towards closing this and move to generic solution that @Esemesek is working on.

I also think we need to whitelist that rn-post-install.js file here: https://github.com/react-native-community/react-native-cli/blob/c9c3ca3b7c5e6d42435d10eb8a140e371d280e1c/packages/cli/src/generator/templates.js#L92. Otherwise, it will get added onto user space, no?

@grabbou Good point, I added an entry to the ignorePaths.
@thymikee That would definitely be the cleaner solution 👍.
I'm closing this PR for now.


feature: remove useless project

Proposed changes
If a projection select all columns, we can eliminate it
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

why not use EliminateUnnecessaryProject and change it to support PhysicalProject?


selects form is broken, select_one_with_other won't return the right value

Software and hardware versions
Tables and survey development branch
Problem description
This is from the select formDef.json
{
  "clause": "if",
  "condition": "selected(data('color'), 'teal')",
  "_row_num": 42
},
{
  "comments": "selected function with arguement not included in choices.",
  "type": "acknowledge",
  "name": "confirmTeal",
  "display": {
    "prompt": {
      "text": "Teal birds are very unique.  Please confirm that you saw a teal bird."
    }
  },
  "hideInContents": true,
  "_row_num": 43
},
{
  "clause": "end if",
  "_row_num": 44
},

However no matter what you put in the box, lowercase, uppercase, etc.., the teal confirm prompt will never appear.
Steps to reproduce the problem
Add a new row to the select table using survey
Expected behavior
Asks me if I'm sure I really saw a teal bird

Looked into this. It does work, but the input field for "Other" is initialized to have a space. When the compare to "teal" is made, it doesn't trim spaces, and so the " teal" (not first deleting the space) that you would naively enter does not match "teal". The warning box should also have a required predicate so you can't navigate off the screen without acknowledging the presence of teal.

Opened a different issue about the spaces


fix: handle when auto updater receives a non-200 from GitHub API

This is a minimal fix to the crash reported in #350 - e.g. Github API returns a 403 or other non-200 error. (Github's API docs do not make it easy to find the response schema for errors, only successes, unfortunately.)
Fixes #350

thanks!


audioRate does not set playback speed

Bug description
When you create a new Wavesurfer instance with an audioRate, that value does not set the playback speed.
Environment

Browser: Chrome

Minimal code snippet
import WaveSurfer from<EMAIL_ADDRESS>
const wavesurfer = WaveSurfer.create({
  audioRate: 2,
  container: document.body,
  url: '/examples/audio/audio.wav',
})

wavesurfer.once('interaction', () => {
  wavesurfer.play()
})

Reproduce

Go to the Basic example on the Wavesurfer JS website (https://wavesurfer-js.org/examples/#basic.js)
Add the audioRate option (set it to anything other than 1)
Interact with the waveform
The audio does not play at the rate given in the constructor

Looks like it only works correctly after the audio has loaded sufficiently or is cached to begin with.


Feat/set status for amendments and revisions

ZH Card

@pbastia based on your comment here: https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/bcgov/cas-cif/1166
Do we need to commit the revision once the status has changed to Applied/Approved ?! if yes, do I need to add it to the AC of this card or make a new card for that?!


Contribution: I correct 1 crucial command "npx"

I correct 1 crucial command for starters or begginers,
always all commands must proceed with "npx" at the beggining.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@miguelgargallo Could you sign the CLA here https://github.com/prisma/prisma/pull/15125#issuecomment-1233353700
Let me know if you have any issue with it

@miguelgargallo Did you try signing the CLA? the status is not signed yet 🤔

Omg i am trying but i cant

Did I sign it? due to cache browser problems I had to format the computer

Thanks for catching this @miguelgargallo 🎉 we indeed want to encourage people to prefix all prisma command with npx as a best practice!

Thank you miguelgargallo
for signing the CLA!
We are now taking you back to GitHub

Team Prisma! My apologize, I fix my browser problem and could sign the CLA!!! My apologize!


build(deps-dev): bump react-router-dom  and react-router from 6.28.0 to 7.0.2 in /clients/ui/frontend

Description
Fixing dependabot PR here: https://github.com/kubeflow/model-registry/pull/627
We need to also upgrade react-router to keep aligned with react-router-dom.
How Has This Been Tested?
Run the tests and quick sanity check
Merge criteria:

All the commits have been signed-off  (To pass the DCO check)

[X] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work.
[X] Code changes follow the kubeflow contribution guidelines.

@Griffin-Sullivan @lucferbux @alexcreasy please let me know if we should bump react-router to a major version. We can also, as an option, stick with 6.x. I create this PR to fix the dependabot PR.

I say if react router 7 works let's go with it.

/lgtm


Avatar accessibility

Description
The img alt should ideally contain the user's name (or login, again, as a worstcase maybe?)
Testing Instructions
I'm unsure now with the name being null sometimes this is the best way, maybe just repeating login again, for accessibility/readability fallback, is the most bulletproof way?
Additional Notes
Or if this has more elegant or universal solution, just ignore this;) … it's more of an a11y note than a proper solution for it.

Thanks!


Contact Diary: Add new Entries from Edit View

Current Implementation

Current implementation of contact diary (cwa v1.10.1) has a menu to edit persons or locations (button with the three dots). This menu allows to edit entries, or to delete them, but not to add new entries.
Suggested Enhancement

This "Edit" view should get an additional button to add more entries to my list.
Please keep the current "Add" button in the daily view as an additional lightweight alternative.
Expected Benefits

Smoother workflow:

I can prepare a list of persons (or locations) in advance, and later just pick from this list.
I can add an entry directly to my list that I have accidentally deleted

Internal Tracking ID: EXPOSUREAPP-3034

Dear @ndegendogo,
Thanks for the suggestion. We have update ticket EXPOSUREAPP-3034 in the internal Jira system. Any further developments will be notified here in this Github issue.
Best wishes,
DS

Corona-Warn-App Open Source Team

Dear @ndegendogo,
Thanks for the suggestion. We have update ticket EXPOSUREAPP-3034 in the internal Jira system. Any further developments will be notified here in this Github issue.
Best wishes,
DS

Corona-Warn-App Open Source Team


val_loss not making sense with multiple outputs and weighted loss

System information

Have I written custom code (as opposed to using example directory):  Yes, custom Keras Sequence
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  Ubuntu 16.04
TensorFlow backend (yes / no):  yes
TensorFlow version:  1.14.0
Keras version:  2.3.0
Python version:  Python 3.6.8
CUDA/cuDNN version:  10.1
GPU model and memory:  ASUS Dual GeForce® RTX 2080 Ti  (2 pieces)

You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
You can obtain the Keras version with:
python -c 'import keras as k; print(k.version)'
Describe the current behavior
I have a model with multiple outputs, and hence there is loss for each of the output and an overall weighted loss. The weighted sum of all the validation loss of the different outputs doesn't add up to the overall validation loss, val_loss.
Describe the expected behavior
Expecting val_loss to be a weighted sum of all the validation loss of model output.
Code to reproduce the issue
input_score = Input(shape=(None, None, 3), name="regression_input")
input_class = Input(shape=(None, None, 3), name="classification_input")

model_base = ResNet50(weights="imagenet", include_top=False)
gap = GlobalAveragePooling2D()

shared_dense_1 = Dense(2048)
shared_bn_1 = BatchNormalization()
shared_relu_1 = ReLU()

shared_dense_2 = Dense(2048)
shared_bn_2 = BatchNormalization()
shared_relu_2 = ReLU()

x_score = model_base(input_score)
x_score = gap(x_score)

x_score = shared_dense_1(x_score)
x_score = shared_bn_1(x_score)
x_score = shared_relu_1(x_score)

x_score = shared_dense_2(x_score)
x_score = shared_bn_2(x_score)
x_score = shared_relu_2(x_score)

score_out = Dense(1, activation="sigmoid", name="regression_output")(x_score)

x_class = model_base(input_class)
x_class = gap(x_class)

x_class = shared_dense_1(x_class)
x_class = shared_bn_1(x_class)
x_class = shared_relu_1(x_class)

x_class = shared_dense_2(x_class)
x_class = shared_bn_2(x_class)
x_class = shared_relu_2(x_class)

class_out = Dense(1, activation="sigmoid", name="classification_output")(x_class)

with tf.device('/cpu:0'):
    model = Model([input_score, input_class], [score_out, class_out])

try:
    parallel_model = multi_gpu_model(model, gpus=gpus)
except:
    parallel_model = model

parallel_model.compile(optimizer=Adam(lr=0.0001),
              loss=[
                  "mse",
                  "binary_crossentropy"
              ],
              loss_weights=[
                  20,
                  1
              ],
              metrics={
                "regression_output": ["mse", "mae"],
                "classification_output": "acc"
              })
parallel_model.summary()

hist = parallel_model.fit_generator(dataset_train,
                    validation_data=dataset_test,
                    callbacks=callbacks,
                    workers=workers,
                    shuffle=True,
                    epochs=10,
                    initial_epoch=0)

Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Here are the 3 columns of data: val_loss, val_regression_output_loss, and val_classification_output_loss with weights [20, 1], 20 for val_regression_output_loss and 1 for val_classification_output_loss.
val_loss:
0.169534176588059
0.407849103212357
0.244819268584251
0.149829715490341
0.144160956144333
0.200807094573975
0.074971824884415
0.100794419646263
0.071464695036411
0.384763598442078
val_regression_output_loss:
0.004071841016412
0.004012452904135
0.004082964267582
0.004099677316844
0.004057640675455
0.004182121250778
0.004099731799215
0.004059502854943
0.004109856206924
0.004216863773763
val_classification_output_loss:
0.135637700557709
0.145183801651001
0.136177375912666
0.146444052457809
0.128644600510597
0.173463732004166
0.132748082280159
0.152826607227325
0.160107001662254
0.138926386833191

I replaced the parralel_model with conventional single GPU model and get the same irratic val_loss too. What could be the problem?

All this is run inside a docker container based on a custom Docker image based on
tensorflow/tensorflow:latest-gpu-py3-jupyter
FROM tensorflow/tensorflow:latest-gpu-py3-jupyter
RUN apt-get update
RUN apt-get install --yes nano vim
RUN apt-get install --yes python3-pip
# RUN apt-get install --yes nodejs npm
RUN apt-get install --yes libsm6 libxext6 libxrender-dev
# RUN apt-get install --yes git

# RUN npm install -g configurable-http-proxy

# RUN pip3 install jupyterhub
RUN pip3 install notebook
RUN pip3 install ipython
RUN pip3 install scipy
RUN pip3 install pandas
RUN pip3 install "dask[complete]"
RUN pip3 install seaborn
RUN pip3 install plotly
RUN pip3 install scikit-learn
RUN pip3 install xgboost
RUN pip3 install lightgbm
RUN pip3 install catboost
RUN pip3 install imbalanced-learn
RUN pip3 install keras
RUN pip3 install torch==1.0 torchvision
RUN pip3 install opencv-python
RUN pip3 install scikit-image
RUN pip3 install imgaug
#RUN pip3 install statsmodel
RUN pip3 install nltk
RUN pip3 install gensim

CMD ["/bin/bash"]

Training loss is ok, but val_loss don't add up. This is weirld...

Output of lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.6 LTS
Release:        16.04
Codename:       xenial

I am experiencing the same issue, with tf 1.13.1, 1.14.0, and 2.0. Also for me the training loss is fine but the val_loss doesnt add up:
loss: 0.3240 - regression_loss: 0.2500 - classification_loss: 0.0740 - val_loss: 8.6638e-07 - val_regression_loss: 0.3861 - val_classification_loss: 0.2899

This is giving me lots of confusion in my work projects. I just tried with replacing keras with tf.keras and it seems to work as expected. I guess Keras is being abandoned.

Hello,
I have the exact problem but I didn't understand how you solve it. Could you explain me?
Thankss in advance

Hello,
I have the exact problem but I didn't understand how you solve it. Could you explain me?
Thankss in advance

Try different combinations of TF + Keras, maybe TF 1.13.1 and Keras 2.2.4.
Or use tf.keras instead of keras.

Thanks for the fast response, the problem solved when I downgraded the keras to 2.2.5

Same problem here, solved by moving to tensorflow keras

I have the same problem. I've noticed that when passing a fixed validation set (as array) the losses sum up correctly. When using a generator for the validation (implemented with keras sequence), the overall loss doesn't make sense anymore (while it makes sense for the training set, implemented with the same generator)


v6.2.0

Minor version bump
Update changelog

A new version of the package @metamask/controllers (6.2.0) was published at 2021-03-23T18:09:22.698Z from
[redacted]. The shasum of this package was 13501d47e63366c74b06b21d98133bd7f53e6ea5.


RAMP demo questionnaire

Should we massage the questionnaire page to include the CSIC kit (#4) in the recommendations?

https://github.com/c0c0n3/kitt4sme.live/wiki/Nov-2021-demo

done during the Nov 2021 demo sprint.


Baseline<EMAIL_ADDRESS>performance?

Hi,
what is the<EMAIL_ADDRESS>performance of the used Faster R-CNN baseline?
Best
Karol-G

Hi,
You can find this on the node21 site at https://node21.grand-challenge.org/evaluation/challenge/leaderboard/ (you need to click on "show all metrics").  It is 0.5323 .
Best,
Keelin

Hi,
thanks for the reply! I don't see<EMAIL_ADDRESS>there if I click on "show all metrics". Does 'S (0.5 FP)' correspond to the<EMAIL_ADDRESS>performance as it has the value of 0.5323? And if yes why is it called differently and what does it stand for?
Best
Karol

Hi Karol,
Sorry for the late answer. We check the forum every day and answer the questions regarding the challenge, so it would be better if you post this type of question to the forum rather than here. (of course, if there is an issue in the baseline code, please post it here :) )
No, we do not calculate<EMAIL_ADDRESS>we calculate average sensitivity at different average FP rates. (0.5,0.25 etc, per image). Please see the details page, there is a section where we explain the evaluation metrics which are calculated for this challenge.
Best, Ecem


Why @sections inside @embed doesn't have access to global variables?

It is possible to make these variables accessible?
It is pain to write code like this
@embed('components.box', ['offices'=>$offices, 'labels'=>$labels, 'years'=>$years ......]  )

this is as intended. use @include otherwise.
or
@embed(´box´, compact(´offices´, ´labels´, ´years´))

Thanks.
@embed(´box´, compact(´offices´, ´labels´, ´years´)) doesn't work, I have already tried it..
Parse Error
syntax error, unexpected ';'  (line 18)
10:    stopSection(); ?>
11:
12:    startSection('content'); ?>
13:
14:        open('inspinia.box', compact('offices','years','quarters')->insert(<<<'EOT'
15:    )
16:
17:    EOT
18:            )->close(); ?>
19:


Update azure-web-apps-net-core.md, Change ApplicationInsightsAgent_EXTENSION_VERSION to ~3 for both Linux and Windows

Change ApplicationInsightsAgent_EXTENSION_VERSION to ~3 for both Linux and Windows
Description
It seems Windows also uses ApplicationInsightsAgent_EXTENSION_VERSION = ~3 now.
When creating an App Service (Windows .net 6) in Azure Portal, if Application Insights is also enabled, ApplicationInsightsAgent_EXTENSION_VERSION = ~3 will be set.
// Deployment Screen

// Application setting screen

@AaronMaxwell
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team