Less ambiguous jest.mock

🚀 Feature Proposal
The proposal is to allow to specify that jest.mock('my-module') should use __mocks__ or not.
Motivation
jest.mock is too magical, it's nearly always known if it's automocking or __mocks__ that is expected in a test. Silently switching between auto and manual mock in jest.mock('my-module') results in a undetermined behaviour that may not be evident and needs to be debugged.
A notable example is facebook/create-react-app#7539
Example
Uses manual mock if it exists, throws an error that contains full path to expected  __mocks__/my-module.js otherwise:
import myModule from 'my-module';
jest.mock('my-module', { manual: true })

Ignores __mocks__/my-module.js and does automocking:
import myModule from 'my-module';
jest.mock('my-module', { manual: false })

Pitch
Module mocking is core Jest feature and needs to be practical out of the box.

I second this. I have just spent an hour trying to debug why a manual mock isn't being used and this would be immensely useful.

The issue is still relevant.

The issue is still relevant.

The issue is still relevant.


Update gLAB

Fix 404 URL.
Move under "open source" tools since it's GPL/LGPL/Apache-licensed.
Add link to an unofficial mirror of source code: https://github.com/valgur/gLAB.

@valgur Thanks for this! Is there an official page for the source? I'd prefer to only reference official sources in this list.

Indeed, that's understandable. They unfortunately publish source code only as part of the downloadable archive for Linux, e.g. https://server.gage.upc.edu/gLAB/src/LINUX/gLAB_5.5.1_Linux.tgz, which is why I created a mirror for the source code to make it easier to access and find. I could add a mention of that instead of the link to the unofficial mirror, I suppose?

Yes, if you could update the pull request to point to the official archive, that would be great.


[BUG] Inline markdown formatting for Japanese (probably other languages too)

Describe the bug
Using markdown inline formatting doesn't always work as expected for Japanese.
To Reproduce

This is not an exhaustive list of cases, but put the following text in a file: test.md

1. **今日**は木曜日です。
2. **(きょう)**は木曜日です。
3. **（きょう）**は木曜日です。
4. **＜きょう＞**は木曜日です。
5. **きょう」**は木曜日です。
6. **きょう』**は木曜日です。
7. **きょう]**は木曜日です。
8. **きょう}**は木曜日です。
9. **きょう-**は木曜日です。
10. **きょう_**は木曜日です。
11. **きょう=**は木曜日です。
12. **きょう+**は木曜日です。
13. **きょう;**は木曜日です。
14. **きょう:**は木曜日です。
15. **きょう、**は木曜日です。
16. **きょう。**は木曜日です。
17. **きょう!**は木曜日です。
18. **きょう@**は木曜日です。

run python3 -m rich.markdown test.md

You will see that the 1st and 4th case is rendered as expected. Everything else is not. Usually Japanese is written without spaces. I suspect that some rules need to be appended for dealing with punctuation/characters within inline formatting.

Platform

Macos Catalina
iTerm2
Rich 9.0.1

This doesn't appear to be an issue with Asian characters. Any punctuation will cause the ** to be rendered as literals.
In fact, Github markdown does the same thing. Which makes this easy to demo. Here's the source:
**Hello**World
**Hello.**World

And here's the output:
HelloWorld
**Hello.**World
This only effects inline styles that are inside a word (i.e. not separated by spaces). Put a space between Hello and World and it renders as you would expect.
I suspect that the common mark spec just wasn't aware of this requirement for Japanese. One solution would be to insert a zero-width-joiner character in place of the space:
**Hello.**World

Hello.World
Which works, but it's not elegant. There may be a better solution I'm unaware of, you might want to read the Common mark spec.

Okay thank you! I didn't realize that's an actual spec feature for commonmark. I have a variety of things that render markdown and they're all a little different. I will close this.


Fix encoding issues

Should fix issues raised in #14

Get this merge and release a new version to npm?

I'll make sure I do this this weekend.


failed to bind to TCP address: listen tcp <IP_ADDRESS>:4000: bind: address already in use

2022-11-02T21:51:57-04:00 INF Setting up a DERPMap update worker frequency=86400000
2022-11-02T21:51:57-04:00 FTL ../home/runner/work/headscale/headscale/cmd/headscale/cli/server.go:26 > Error starting server error="failed to bind to TCP address: listen tcp <IP_ADDRESS>:4000: bind: address already in use"

@cnmeeia are you sure you are not running another instance?

What is the output of lsof -i :4000 when headscale is not running?

@cnmeeia are you sure you are not running another instance?

Thanks you

What is the output of lsof -i :4000 when headscale is not running?

Thanks


PI can't start Spy++

Dev Home version
0.1501.533.0
Windows build number
10.0.19045.4651
Other software
OS Build Version: 10.0.19045.4651.amd64fre.vb_release.191206-1406
.NET Version: .NET 8.0.5
Steps to reproduce the bug

Launch PI (not elevated)
Configure Spy++ (C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\Tools\spyxx_amd64.exe) as new tool
Try to launch Spy++

Expected result
Spy++ launched as expected
Actual result
Spy++ failed to launch with error 740 ERROR_ELEVATION_REQUIRED.
[2024/07/12 14:27:39.070 ERR] (ExternalTool) Tool launched failed
System.ComponentModel.Win32Exception (740): An error occurred trying to start process 'C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\Tools\spyxx_amd64.exe' with working directory 'C:\Windows\System32'. The requested operation requires elevation.
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at DevHome.PI.Helpers.ExternalTool.Invoke(Nullable`1 pid, Nullable`1 hwnd)

Included System Information
No response
Included Extensions Information
No response

@davidegiacometti thanks for this bug report.  PI's external tool integration is currently evolving, we'll be addressing some of these issues in the next monthly update of DevHome.  In the meanwhile you can launch PI elevated from the DevHome > Utilities page to avoid these issues.


custom fillMapper and relative samples

fillMapper is a new function parameter to allow to customize the way autoFill works. It is possible to specify a custom mapping function between (word, index) and the word color.
In the sample I used some scales from d3-scale-chromatic and allowed some interaction with main options:

Thanks for your contribution
P/s: the example part and testing part are what I haven't had time for. thank you


BUG: default value of property 'druid.selectors.coordinator.serviceName' do not honor property 'druid.zk.paths.base'

In my opinion, when we set
druid.zk.paths.base=/druid_xxx

in common property file.  MiddleManager's druid.selectors.coordinator.serviceName should be automatic setted to
/druid_xxx/coordinator

instead of default
/druid/coordinator

Although document says it's default value is /druid/coordinator, but I don't think it is a good default. Users uses customized druid.zk.paths.base may have their realtime task failed with this default.

not a bug.  I have misunderstanding on serviceName


WFLY-6791 Upgrade to Hibernate Search 5.5.4.Final

https://issues.jboss.org/browse/WFLY-6791

Hi @scottmarlow I believe this needs your blessing.
It's fully backwards compatible, I'd suggest to include it in all active branches.

@gbadner what do you think about this change?   :-)  I don't think that WildFly 10.1 is open for further changes at this point.  If I'm right, how about for WildFly 11.0?

@Sanne looks good to me, lets see what feedback @gbadner has on this change as well.

@Sanne, @scottmarlow this looks good to me.


[SDK] Test coverage

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR focuses on enhancing the thirdweb utility functions related to byte encoding and decoding. It introduces new tests and modifies existing functions to ensure proper functionality and error handling for various byte-related operations.
Detailed summary

Modified padBytes in to-bytes.ts to be exported for testing.
Added comprehensive tests for byteSize, assertSize, charCodeToBase16, and isHex in their respective test files.
Introduced tests for toBytes, boolToBytes, hexToBytes, numberToBytes, and stringToBytes in to-bytes.test.ts.
Enhanced error handling and boundary condition checks in several functions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#5316  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on  Graphite


CircleCI gotestsum permissions different in circleci/golang:1.11.4 vs 1.11.5

Thanks very much for the update here: https://github.com/circleci/circleci-images/pull/348!
It looks like the tool was only updated on circleci:golang:1.11.5 and not on 1.11.4 though. Also the permissions for the binary on 1.11.4 were circleci:circleci and on 1.11.5 it was root:root. This means if you all forget to update the tool in the future, I can't run the same curl and replace the binary (of course I can put it somewhere else though).

@dnephin Any idea why this may be? I have #418 open to update it again. Any other changes we need to make?

Okay I'm going to close this.
@alvin-huang

It looks like the tool was only updated on circleci:golang:1.11.5 and not on 1.11.4

That's how CircleCI Convenience Images work. Unless there's a major bug or security issue, older images won't get updated. Only a few recent point releases get updated. This is to prevent us updating older images that then break someone's long-time builds.
The user/group will remain the same for this tool. Please keep in mind that the circleci user in our containers has passwordless sudo so you still have access to update this binary during a build if you want.


Tp2000 1194  js linter

TP2000-1194 JS linter and pre commit

Why
As we hae code formating and standardisation for pyhton code we should have similar set up for Javascript code.
What

sets up an es lint configuration for JS, JSX and React
pre commit for prettier and es lint

Checklist

Requires dependency updates? - yes npm

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.11%. Comparing base (862d604) to head (a31c8bd).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
- Coverage   93.11%   93.11%   -0.01%
==========================================
  Files         582      582
  Lines       43964    44041      +77
  Branches     3170     3181      +11
==========================================
+ Hits        40938    41008      +70
- Misses       2412     2416       +4
- Partials      614      617       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[stable/jenkins] not creating ingress controller

Is this a request for help?: no

Is this a BUG REPORT or FEATURE REQUEST? (choose one): bug report

Version of Helm and Kubernetes:
helm
Client: "v2.7.2"
Server: "v2.7.2"
kubernetes
Client Version: "v1.8.4"
Server Version: "v1.8.2-gke.0"

Which chart: stable/jenkins
What happened: an ingress controller failed to create
What you expected to happen: an ingress controller to be created
How to reproduce it (as minimally and precisely as possible):

Values file is created with hopefully the correct information
Appropriate secret is installed into kubernetes containing the necessary TLS certificates for the ingress controller
helm install

Anything else we need to know:
My values file:
---

Master:
  ServiceType: ClusterIP
  Hostname: jenkins.example.com
  Ingress:
    Annotations:
      kubernetes.io/ingress.class: "gce"
      kubernetes.io/ingress.allow-http: "false"
    TLS:
      - secretName: jenkins-ingress-ssl
        hosts:
          - 'jenkins.example.com'
rbac:
  install: true

My Secret:
k describe secret jenkins-ingress-ssl
Name:         jenkins-ingress-ssl
Namespace:    default
Labels:       <none>
Annotations:  creationDate=Dec 12 17:50:51 2017 GMT
              expireDate=Dec 10 17:50:51 2027 GMT

Type:  Opaque

Data
====
tls.crt:  1224 bytes
tls.key:  1704 bytes

helm install dry-run and debug:
https://gist.github.com/jtslear/9e2b5135415de2f456d90b8b0708ea20

DISREGARD...............
HostName
Case sensitivity is really really difficult.


SOCKS Setup Command

EDIT: I streamlined the setup process more. The video has extra prompts that aren't there now (same functionality).
Introducing vtk socks setup. This command guides the user through setting up their machine with SOCKS access and configuring an always on SOCKS tunnel. That's right. No need to run vtk socks on anymore. And you can uninstall CoreTunnel.

To test, run rake build and then install via gem install pkg/vtk-0.8.0.gem

Alternatively, I believe bundle exec vtk socks setup will work from the project's directory.

rspec will need to be ran locally to test as CI doesn't have access to SOCKS.

I'm not sure if this is possible, but at the step where https://brew.sh is opened and you have to copy the command, could you just run the command instead of the user having to do a copy/paste?

I'm not sure if this is possible, but at the step where https://brew.sh is opened and you have to copy the command, could you just run the command instead of the user having to do a copy/paste?

Thanks for asking the question! I had already thought of it and tried it but, since you pointed it out and I couldn't remember the exact reason, I went digging.
The problem was using backticks (`command`) didn't allow shell interaction. But I found this handy chart which shows that using system() will allow for natural stdin/stdout/stderr without doing anything fancy. This allowed me to do ssh-keygen inline as well which I was almost certain was impossible. YAY!
So thanks again. I've streamlined this even more and now know how to implement interactive sub-processes in future development of other subcommands.

Do you want to add info to the README for SOCKS setup?

Also, don't forget to bump version.rb to 0.9.0


Update Grant-CsTeamsUpgradePolicy.md

Grammar fix

Docs Build status updates of commit 751b3b8:
:clock10: Full build: the average full build time is 14 min(s) 24 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 751b3b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Grant-CsTeamsUpgradePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Evidence Management

Twitter: Evild3ad79
Add Management for acquired evidence.

Finished, will be part of v0.6.3


BUG: Different timezones for DatetimeIndex versus elements of DatetimeIndex

Huge fan of Pandas.  Thanks for all the hard work!
I've noticed an inconsistency.  The following DatetimeIndex object reports a different timezone compared to its elements:
In [1]: import pandas as pd

In [2]: idx = pd.date_range("2015-01-01", "2015-01-03", freq="D", tz="US/Eastern")

In [3]: idx.tz
Out[3]: <DstTzInfo 'US/Eastern' LMT-1 day, 19:04:00 STD>

In [4]: [timestamp.tz for timestamp in idx]
Out[4]:
[<DstTzInfo 'US/Eastern' EST-1 day, 19:00:00 STD>,
 <DstTzInfo 'US/Eastern' EST-1 day, 19:00:00 STD>,
 <DstTzInfo 'US/Eastern' EST-1 day, 19:00:00 STD>]

In [6]: idx[0].tz == idx.tz
Out[6]: False

And here are my installed versions:
In [5]: pd.show_versions()

INSTALLED VERSIONS
------------------
commit: None
python: 2.7.8.final.0
python-bits: 64
OS: Linux
OS-release: 3.16.0-37-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_GB.UTF-8

pandas: 0.16.1
nose: 1.3.4
Cython: 0.21.2
numpy: 1.9.2
scipy: 0.15.1
statsmodels: None
IPython: 3.1.0
sphinx: 1.2.3
patsy: None
dateutil: 2.4.2
pytz: 2015.2
bottleneck: 0.6.0
tables: 3.1.1
numexpr: 2.4
matplotlib: 1.4.3
openpyxl: 1.8.6
xlrd: 0.9.2
xlwt: 0.7.5
xlsxwriter: None
lxml: 3.3.6
bs4: None
html5lib: 0.999
httplib2: 0.9
apiclient: None
sqlalchemy: None
pymysql: None
psycopg2: 2.5.3 (dt dec mx pq3 ext)

This is caused by pytz spec. In normal datetime case, tz must be localized to determine whether the date belongs to DST.
import pytz

# if not initialized
[pytz.timezone("US/Eastern")]
# [<DstTzInfo 'US/Eastern' LMT-1 day, 19:04:00 STD>]

# after localize
[pytz.timezone("US/Eastern").localize(datetime.datetime(2015, 1, 1)).tzinfo]
[<DstTzInfo 'US/Eastern' EST-1 day, 19:00:00 STD>]

However, DatetimeIndex can have dates beyond the DST boundary, it stores passed tz as it is. Thus, it holds uninitialized tz in your case. Workarounds are:
# once localize tz and pass it to date_range
tz = pytz.timezone("US/Eastern").localize(datetime.datetime(2015, 1, 1)).tzinfo
idx = pd.date_range("2015-01-01", "2015-01-03", freq="D", tz=tz)
[idx.tz]
# [<DstTzInfo 'US/Eastern' EST-1 day, 19:00:00 STD>]

# or use other pytz timezone works properly.
idx = pd.date_range("2015-01-01", "2015-01-03", freq="D", tz="EST5EDT")
[idx.tz]
# [<DstTzInfo 'EST5EDT' EST-1 day, 19:00:00 STD>]

Wonderful, thanks loads for the very quick reply and for explaining the issue :)
The solution I went for in the end works something like this (where start and end are tz-aware Timestamps in the US/Eastern timezone):
tz = None if start.tz is None else start.tz.zone
index = pd.date_range(
    start.tz_localize(None), end.tz_localize(None), tz=tz,
    closed='left', freq=freq)


Add caveats-like field for less important notes?

Over in #8915 we had to turn away a PR because @ndr-qef and @vitorgalvao agreed that caveats should be reserved for more critical notices about the install rather than helpful recommendations.
It seems to me that we should be able to welcome contributions with helpful recommendations for software use (provided the notes are not overly long or user-specific).
In my mind we have three options here. We could:

Agree to loosen the definition of what can go in caveats to accept stuff like this
Add a new field for recommendations or notes
Decide that we don't want recommendations of this nature in Casks

I don't feel incredibly strongly, so I'm willing to be convinced that any of these three is the best move. I wanted to have the conversation though. Thoughts?

My biggest issue with non-critical messages in caveats is the more messages we output, the more they all blend and the sooner they’ll start to be ignored. There are some messages that really need to be shown for the experience to not be broken, and if we start to blend many optional suggestions there, users will start to ignore the important ones as well.
I believe the sentiment when a caveat goes by and you missed it should be “wait, what was that? I should go back and check”, and never “wait, what was that? Meh, probably nothing important”.

Yeah that's a good point. Perhaps we could address that with display tweaking? Or maybe we just shrug and punt for now. Will wait for other @caskroom/maintainers to weigh in.

I feel that color coding would help mitigate the issue, but if there's a lot of output, that in itself may not be enough.
I know that Homebrew also has a lesser-used Warning field (which is red output and underlined). I think it's used internally by the Homebrew system and cannot be called from inside Formulae.
Lastly, I propose a flag or environment variable (or later, once a config file system is implemented, possibly a setting there) that toggles the verbosity of output (while we already have -v, it seems that a simple "on/off" switch for verbosity may not suffice). Or, if a new field for recommendations and what not is implemented, make it only show when -v is specified.

I don’t see much problem with that solution. Even if it is something you can set in HOMEBREW_CASK_OPTS, if you specifically have to do it then you’re likely the type of person that wants and reads everything anyway. Not sure it’s worth the extra complexity, but it definitely mitigates my concern.

I am fairly adamant that caveats should remain caveats: warnings to be heeded, lest woe betide you. It is good UX to distinguish the “must” from the “may.”
On the subject of usage recommendations, I feel conservative. The convenience is desirable, but they would be a blob of freeform information which:

we are expected to guarantee to some degree;
will invariably be inconsistent across casks;
may provide little benefit over a web search.

From the perspective of brew cask as a CLI utility, I worry that storing a compendium of facts in the caskbase would represent sprawl. Perhaps the concern of recommendations would be best addressed by an external command akin to Homebrew's brew-desc.

The worry about sprawl makes sense to me, the worry about consistency across Casks less so.
As for a theoretical interface for notes, consider a distinct verb instead of an option/environment var.  zap is just an uninstall that only runs when explicitly requested.  Similarly a notes stanza could be implemented as a caveats that only runs when you invoke brew cask notes.
Incidentally, I would have kept the specific caveat in #8915, because it is a soft dependency.  (It would be nice to support soft dependencies in the future along with a --with-extras flag.)  Though you are right that it is poor UX.  Maybe it should be better kept as a comment.

We should likely not focus on #8915 too much for this, though. All I can see when I look at it is :optional and :recommended, meaning there is a way better (and currently unimplemented) way to solve it. Current caveats I feel are relevant to this discussion include:

springy.rb and candybar (these could warrant a special caveat option, as it is not extremely uncommon — there are a few more cask which similarly have a free license, in caskroom/versions)
p4merge
jenkins (a section of)
diffmerge
dewdrop

Found a bunch more, but the ones not included seem to me to be so useless they should be outright removed. Will submit PRs for those.

Another example of a note or hack just turned up in https://github.com/caskroom/homebrew-cask/issues/8202#issuecomment-73874854 .
This particular item looks like it should not be a default, but it is darn helpful to include it somehow.

The worry about sprawl makes sense to me, the worry about consistency across Casks less so.

To be clear, my concern is not quality or quantity, but modes of action. I would not be overly fond of a CLI which intersperses explanatory text, shell commands, and links to be opened in a browser.


Validate collection names for SQLite handler

Description
Closes #2749.
This PR is a part of the issue, database validation will be handled in second PR.

Readiness checklist

[ ] I added/updated unit tests.
[x] I added/updated integration/compatibility tests.
[x] I added/updated comments and checked rendering.
[x] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

PR is not an issue

Let's wait until after v1.5.0


Add file:// to credentials option

Mesos master said: "Specifying an absolute filename
to read a command line option out of without using
'file:// is deprecated and will be removed in a future
release. Simply adding 'file://' to the beginning of
the path should eliminate this warning."

Thanks, is this change backward compatible?

Starting from the version 0.22 according to their git. It's almost a year old.

Ok, that shouldn't break existing installation, given the recommended incremental manner of upgrades. Release tagged as v0.8.0.


can't access my trinity wallet June 4 - PLEASE HELP -

I was not aware of a wallet change with IOTA, Apparently its now firefly, the problem is I don't have my seed for the iota trinity wallet to gain access to my account balance, transfer my iota to the new firefly wallet, and I cannot login to the old trinity wallet at all, I get errors : Node - blah blah blah and change settings, I did all of that, gone thru it all! I still cannot access the trinity wallet to access my seed. I don't even know what a seed looks like to find it. Please help, I have a lot of iota and would like to access

Wrong repository


When SDK raises an InvalidRequest exception, the reason is not always displayed

At least when the request is failing due to a validation error from the backend, the reason is not displayed:
    raise exceptions.InvalidRequest.from_request_exception(e)
substra.sdk.exceptions.InvalidRequest: 400 Client Error: Bad Request for url: http://substra-backend.node-1.com/traintuple/

The reason causing the failure was in the above example was:
{"compute_plan_id":["Ensure this field has at least 64 characters."]}

That's because the format returned by the backend is not always the same.
For example, the same error (InvalidRequest) returns me this error when I try to add a traintuple which doesn't contains 64-characters keys:
{"train_data_sample_keys": {"0": ["Ensure this field has at least 64 characters."], "1": ["Ensure this field has at least 64 characters."]}}
In the exception itself, we are trying to get the message attribute, which is not always specified in the response we get.

I had trouble understanding the issue until I realized this is an issue with the SDK and not the CLI. The CLI displays the full errors, although in a weird format (see #147) but the SDK doesn't display anything at all.
I tried running a script that would raise an error and here is the full output:
➜ python test.py
Requests error status 400: {"data_manager_key":["This field may not be null."],"compute_plan_id":["Ensure this field has at least 64 characters."],"train_data_sample_keys":["Ensure this field has at least 1 elements."]}
Traceback (most recent call last):
  File "/Users/jeremy/substra/substra/substra/sdk/rest_client.py", line 121, in __request
    r.raise_for_status()
  File "/Users/jeremy/.virtualenvs/substra/lib/python3.7/site-packages/requests/models.py", line 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://substra-backend.node-1.com/traintuple/

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "test.py", line 15, in <module>
    c.add_traintuple(traintuple)
  File "/Users/jeremy/substra/substra/substra/sdk/client.py", line 40, in wrapper
    return f(*args, **kwargs)
  File "/Users/jeremy/substra/substra/substra/sdk/client.py", line 447, in add_traintuple
    res = self._add(assets.TRAINTUPLE, data, exist_ok=exist_ok)
  File "/Users/jeremy/substra/substra/substra/sdk/client.py", line 185, in _add
    **requests_kwargs)
  File "/Users/jeremy/substra/substra/substra/sdk/rest_client.py", line 256, in add
    return self._add(name, exist_ok=exist_ok, **request_kwargs)
  File "/Users/jeremy/substra/substra/substra/sdk/rest_client.py", line 232, in _add
    return self.request('post', name, **request_kwargs)
  File "/Users/jeremy/substra/substra/substra/sdk/utils.py", line 170, in wrapper
    return f(*args, **kwargs)
  File "/Users/jeremy/substra/substra/substra/sdk/rest_client.py", line 187, in request
    **request_kwargs,
  File "/Users/jeremy/substra/substra/substra/sdk/rest_client.py", line 165, in _request
    return self.__request(request_name, url, **request_kwargs)
  File "/Users/jeremy/substra/substra/substra/sdk/rest_client.py", line 133, in __request
    raise exceptions.InvalidRequest.from_request_exception(e)
substra.sdk.exceptions.InvalidRequest: 400 Client Error: Bad Request for url: http://substra-backend.node-1.com/traintuple/

The very first line is only displayed thanks to the logging library, it's not part of the traceback (see rest_client.py, L130).
So the real goal here is to have the traceback display the error details.


picker buttons

There's 2 things I'm missing for date- and timepicker:

option to get rid of the clear button
add a cancel button to the datepicker

The docs at https://material.io/guidelines/components/pickers.html do not show clear-buttons at all.
Not sure where to best fit "cancel" with "today" in the datepicker, but I'll try to come up with a PR for this if nobody else beats me to it.

Added in d613187735a908b28682ed85ddcab91929d99d75


AutoSize?

I am exporting data to an excel spreadsheet using a script like below.  When I do that and open in excel the data column is showing the hash symbols.
`$obj_hash = [ordered]@{
"Date"							= "N/A"
"Name"             			    = "N/A"
"Random1" 	      				= "N/A"
"Random2"  	     				= "N/A"
}
$final_results =@()
$files = gci D:\ | sort lastwritetime -Descending
Foreach ($File in $files)
{
$Results=$null
$Results = New-Object PSobject -Property $obj_hash
    $Results.Date = $($file.LastWriteTime)
    $Results.Name = $($file.FullName)
    $Results.Random1 = "Random Text"
    $Results.Random2 = "Random Text"

    $final_results += $Results
}

$final_results | Export-Excel -path D:\test3.xlsx -WorkSheetname Test3 -AutoSize -ClearSheet -TableName Test3
`
I assuming that this is something that I have caused but I am not sure how to fix.  Any suggestions?

Yeah -Autosize tries it's best. When Excel renders the data when launched sometimes the content is still too wide to display.

I was able to "tweak" the process slightly as a way to get the date column to not show the HASHes.
$final_results | ConvertTo-Csv -NoTypeInformation | ConvertFrom-Csv | Export-Excel -path D:\test3.xlsx -WorkSheetname Test3 -AutoSize -ClearSheet -TableName Test3
Doing the little flip to csv then from csv make the date column appear better.

Cool, interesting.


brpc build failed in x64-linux

Describe the bug (描述bug)
I'm a member of vcpkg team, when I tried to update the version of brpc to 1.10.0, I got an error as below:
vcpkg/buildtrees/brpc/src/1.10.0-6977522ae8.clean/src/brpc/serialized_response.h:56:9: error: ‘int brpc::SerializedResponse::GetCachedSize() const’ marked ‘override’, but does not override
   56 |     int GetCachedSize() const override { return (int)_serialized.size(); }
      |         ^~~~~~~~~~~~~
vcpkg/buildtrees/brpc/src/1.10.0-6977522ae8.clean/src/brpc/serialized_response.h:74:10: error: ‘void brpc::SerializedResponse::SetCachedSize(int) const’ marked ‘override’, but does not override
   74 |     void SetCachedSize(int size) const override;
      |          ^~~~~~~~~~~~~

I found above issue occurs due to the version of protobuf in vcpkg was 4.25.1, which there is no corresponding virtual function in the base class.
I know from the brcp documentation that you are using protobuf version 3.0-3.25, so I'm not sure if you support version 4.25.1.
I am currently trying to add a patch in vcpkg to remove the override keyword from those two functions, and I would like to confirm with you if this is a feasible solution.
To Reproduce (复现方法)
Build brpc 1.10.0 with protobuf 4.25.1.
Expected behavior (期望行为)
No error.
Versions (各种版本)
OS: Ubuntu 23.10
Compiler: GNU 13.2.0
brpc: 1.10.0
protobuf: 4.25.1
Additional context/screenshots (更多上下文/截图)

Are there any other compilation errors?

No, only those two above.

I am currently trying to add a patch in vcpkg to remove the override keyword from those two functions, and I would like to confirm with you if this is a feasible solution.

It is best to refer to #1343 .

Thanks for your reply! I will modify my patch based on this PR.


Live reload does not work with class member variables

Operating system or device - Godot version:
OS: Windows 10
Godot version: 2.1.3
Issue description:

I have this bit of code and I was changing the value of the speed variable using the live reload feature. The script got reloaded but the the speed did not change:
var speed = 300;

func _fixed_process(delta):
	...
	var motion = move_direction.normalized() * speed * delta
	move(motion)

Steps to reproduce:
Link to minimal example project:

testgo.zip

There is a problem with this:

var object = null

func _ready():
	object = SomeObject.new()
	set_process(true)

func _process(delta):
	object.do_stuff()

What should happen if you hot-reload this script?
If you expect a member variable to reload, you will get object == null, and the script will crash.

If you do export var speed = 300 and change it via editor it works (if Sync Scene Changes is also active). For this particular case, I find it a better and more predictable workflow.

Make sense! Sorry I'm new to this engine and haven't gotten familiar with all the nuances. Thank you for the explanation and suggestions. I will make it visible in the editor instead :)


[OSD-22536] Add new routetables check for public subnets.

This checks that a subnet does not have a route to <IP_ADDRESS>/0 to an internet gateway. This usually denotes a public subnet.
Currently this keeps the old check for MapPublicIpOnLaunch as well if no IGW route is found.

Codecov Report
Attention: Patch coverage is 0% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 38.61%. Comparing base (bd0c856) to head (8fa7cf5).
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   39.59%   38.61%   -0.98%
==========================================
  Files          16       16
  Lines        1470     1507      +37
==========================================
  Hits          582      582
- Misses        849      886      +37
  Partials       39       39

Files
Coverage Δ

pkg/ocm/mock/ocmmock.go
48.48% <0.00%> (ø)

pkg/aws/mock/aws.go
59.30% <0.00%> (-0.70%)
:arrow_down:

pkg/networkverifier/networkverifier.go
46.59% <0.00%> (-1.65%)
:arrow_down:

pkg/aws/aws.go
0.00% <0.00%> (ø)

/retest

/retest

/lgtm


content not break line in IOS, android work fine

Can you create an example on https://snack.expo.io that reproduces this?

seems like there is a miscalculation of content height. You could maybe fix this problem by setting style of your text container to flex: 1


Typos and cleanup

Figured I'd go through and get any typos I found while going through the koans. What do you think?
Resolves #61

Awesome thanks!


Missing migrations

When I ran migrate I got a message about missing migrations for cmsplugin-filer. These are the missing migrations:
$ python manage.py makemigrations

Migrations for 'cmsplugin_filer_file':
  0005_auto_20160713_1853.py:
    - Alter field cmsplugin_ptr on filerfile
Migrations for 'cmsplugin_filer_image':
  0009_auto_20160713_1853.py:
    - Alter field cmsplugin_ptr on filerimage
Migrations for 'cmsplugin_filer_teaser':
  0003_auto_20160713_1853.py:
    - Alter field cmsplugin_ptr on filerteaser
Migrations for 'cmsplugin_filer_folder':
  0003_auto_20160713_1853.py:
    - Alter field cmsplugin_ptr on filerfolder
Migrations for 'cmsplugin_filer_link':
  0007_auto_20160713_1853.py:
    - Alter field cmsplugin_ptr on filerlinkplugin
Migrations for 'cmsplugin_filer_video':
  0003_auto_20160713_1853.py:
    - Alter field cmsplugin_ptr on filervideo

FYI django-oscar has a unittest that checks for missing migrations: https://github.com/django-oscar/django-oscar/pull/2063
This could help avoiding future problems.

I actually added a simple version of that test to django-filer recently: https://github.com/divio/django-filer/pull/880/files?diff=unified#diff-02518be55cb68ac739ce9ba80d88c944

Fixed by 5937e064ab1d841733b61b7e8bdefe696009f77f

Regarding migration tests, this is a great idea!
Thank you, I'll look into this for cmsplugin-filer and the rest of our addons :)


Bug/Feature: ESBuild Dynamic Require upgrade

Coming from this chat with @ryanflorence on Discord. ESBuild isn't set up to handle dynamic requires in npm packages.
The ESBuild dependancy is a little out of date to start with and could use an update.
Assuming that doesn't fix the following issue (I patched and it didn't seem to work), a simple reproduction step is:

npm init remix
npm install @slack/web-api
Add to the index route:

import { WebClient } from "@slack/web-api";

export default function Index() {
  const web = new WebClient();

  return (
    <div style={{ textAlign: "center", padding: 20 }}>
    </div>
  );
}

ESBuild probably just needs a config tweak or something after the update to accept the dynamic requires?

I believe this should be resolved in recent updates, but please let me know if not and I can take a look with a minimal reproduction!


rework box plots

color points by trends in precip (decreasing is brown, increasing is blue) then mark significance (either with a border or an alpha)

use total precip instead of mean precip


keybindings.json has a wrong command

{
    "key": "ctrl+[",
    "command": "editor.emmet.action.previousEditPoint"
},

the right command is  "  editor.emmet.action.prevEditPoint  "

Is this command inside default keybindings or yours?

I believe editor.emmet.action.previousEditPoint was the command id before the move to Emmet 2.0 that was made in the July release.
In the move, all the emmet actions were re-implemented and the command id got changed to editor.emmet.action.prevEditPoint
@zsedcbm You must have added the keybinding before the move and so it doesnt work anymore.
Sorry for the trouble.

@ramya-rao-a  @usernamehw   thanks.
I forgot when I set it up keybindings, There's no problem now. it's fine.


Update scalafmt-core to 3.8.0

About this PR
📦 Updates org.scalameta:scalafmt-core from 3.7.17 to 3.8.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f4176fd) 78.89% compared to head (5d3a16e) 78.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2833      +/-   ##
==========================================
- Coverage   78.89%   78.87%   -0.02%
==========================================
  Files         467      467
  Lines       15950    15950
  Branches     2586     2586
==========================================
- Hits        12583    12580       -3
- Misses       3367     3370       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


SIR Site has been down please restart it sir.

SIR Site has been down please restart it sir.
it been loading and not getting live

Thanks I'm debugging it ;_;

Fixed https://github.com/fjzzq2002/is-my-problem-new/commit/9e6feba786d86a9942d12ec0309d0adc2c00811d


Add URL key for Swift 4

Is the goal for this change to add the key for convenience? For example, in your code you'd like a new attribute to encapsulate some data when using the label?

Why not to add URL? URL is often used.
In the swift example, a standard URL attribute is used. Therefore a underline is added, which is not immediately clear how to remove it.


Search of MAC addresses

Issue type: Feature Request

Python version: 3.5
NetBox version: 2.1

Would like to see the ability to search for MAC addresses that are input into Netbox. After spending some time loading the MACs into the tool, it would be helpful to search them in case the need arises to see where a MAC address lives. Such as a script to map out without the use of CDP/LLDP based on the mac address table.

MAC address search is already supported. What specific functionality are you requesting?

Then perhaps I should change to a bug request. :(.
What I have done is go to a device that I have the MAC address for, copy the MAC address, then paste into the search bar. It comes back with no results found.  The search format is nn:nn:nn:nn:nn:nn that I am using to search.
Detailed python version is 3.5.2.

Netbox 2.1 / Python 2.7.5 (stock CentOS 7) here. Also can't find a way to search for MAC addresses, or interface descriptions. Couldn't find mention of interfaces in SEARCH_TYPES in netbox/netbox/views.py - is this included in global search at all?

@vanderaaj There's actually a way to search for MAC addresses, it's just not included in global search. MACs can be searched for on the Devices list. There is a dedicated input field on the bottom of the search box to the right of that page.
@jeremystretch Shouldn't MAC addresses, or other interface attributes like the description field, be included in global search? Personally I found it somewhat irritating that global search does not provide search results for interface attributes. What do you think?

I've enabled this functionality. It does introduce a noticeable delay when searching globally, but the query is only extended to look at MAC addresses if the given value is a valid MAC address, so it's probably fine. Searching using the dedicated MAC filter is much faster, of course.

Q: Is this functionality NOT in 2.2.1?
It doesn't appear to work for me -- the dcim/filters.py code looks quite similar, but slightly different -- wondering if anyone can assist/confirm.


Problem: Trying to Sign In on a Different Account

When I try to sign in, after I input my text verification code, i get the error "unknown response. Unable to login." I am able to login to the web app in my browser, so I don't think it's necessarily a problem connecting to EA. Any help is appreciated. Thanks!

I would verify your credentials and secret question answer and also make sure you are able to search players in the web app as well.

Hmm, I changed my password, and also checked my security question by logging into the companion app, and it still won't work. Web app is also fully functional, and it also works on the console. This problem started when I tried to swap over to a different account from my main one. I also tried deleting the autobuyer files and reinstalling, but that still didn't do it.

I think I may have found something that might be causing it. When I login to the web app, I immediately get a 500 internal service error. But when I refresh, it opens the web app just fine. This doesn't happen on my account that works with the autobuyer. Any thoughts on what could be causing this 500? Thanks!

https://www.easports.com/fifa/login_check?state=sxWBqCN4C5wjtkg7mPLQBOJgq6j99GsCkacGOfcHnHM&code=QUORAMF-Fpc8h88nyE6OH8DcFZIaloh9nlhV9UgmAQ  That's the URL when the error comes up, so it's clearly failing some login check...

This also happens to me with my secondary account. However, after trying on the web app i have the following message "Continue Playing FUT 17 On The PlayStation 4 To Unlock Access To The Transfer Market". Its weird since I am already on Division 8, so i played like 14 online games and 6 single player games. I thought it should be enough but apparently I need to keep playing.. perhaps you have the same thing, you need to try to buy a player using the web app.

@Daves10 - Buy a player or two from the transfer market on the console, and it should unlock the web app.

It seems that 20 is the magic number. After completing 20 matches I could finally unlock the web app. I had already bought and sold a couple of players in the console but it didn't do anything.

It takes 6-8 games in 2-3 days to unlock the webapp.

Like OP, I'm having this issue on a second account.


No Register button in Download and run script page

Page 'Download and run script' doesn't have a 'Register' button (anymore). Replaced: 'You can register these resource providers ahead of time, or while completing the steps in this quickstart.' by 'Please register these resource providers ahead of time.'. Removed:
5. On the Download and run script page, select the Register button to register the required resource providers in your subscription, if you haven't already done so.

Docs Build status updates of commit 8342d5f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/azure-arc/servers/learn/quick-enable-hybrid-vm.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add commands API

Codecov Report

Merging #18 into master will increase coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   98.93%   99.04%   +0.11%
==========================================
  Files           9       10       +1
  Lines          94      105      +11
  Branches       25       26       +1
==========================================
+ Hits           93      104      +11
  Misses          1        1

Impacted Files
Coverage Δ

src/index.js
100% <ø> (ø)
:arrow_up:

src/commands.js
100% <100%> (ø)

src/geckoProfiler.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ba981...c7de77d. Read the comment docs.


SHVDN v3 doxygen documentation.

Hi! I've noticed that this library doesn't have an web documentation beside the wiki so I took my time and created one with doxygen: You can find it here
I hope this is helpful but if for some reasons this looks wrong you can ask me to delete it.
Also feel free to do as you wish with the html generated which you can find on my github repo here

hey man i've added ur documentation to the wiki !
https://github.com/crosire/scripthookvdotnet/wiki#useful-links


[BACKEND] A stuff.php for collections needs to be done, as currently there is no way of listing collections for a certian user

Needs to be done for #185 to be done, might actually be done though, but with no documentation

:package:


Clean up and align all package.json files in root folder and subfolders

Right now we install different packages, dependencies, etc... in the root folder of this repo vs. the sub-task folders.
In addition, Microsoft docs state that it is possible to install dependencies on root-level of the extension, and re-use them within each task (this needs to be tried out though; probably need to include node_modules in the manifest).
Definition of done

[ ] package.json on root-folder is more stricter regarding versions (e.g., using ~ vs. ^)
[ ] package.json in all sub-tasks should have the same dependencies and versions, at least where possible
[ ] If possible, keep all needed dependencies on root folder package.json
[ ] Research whether we need/should add package-lock.json to the repo

already merged


Repo sync for protected CLA branch

The pull request is created from master637575618249178621 to master to fix git push error for protected CLA branch

@opbld16 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Reorganize ROS 1 Migration Pages

Addresses #3859. Mostly an organizational change with minimal content edits.
I considered moving Using ros1_bridge with upstream ROS on Ubuntu 22.04 under the new ROS 1 Migration folder. What do you think?

@mjforan Thank you very much for the review.  I've gone ahead and made changes based on your suggestions in 7e16a501ae3121aea917a7573df792ed2140c039.  Please take another look, and let me know what you think.

Thanks for the changes! One nit-pick I discovered is that your longer titles don't look great in the side bar:

My personal preference is to drop the repetitive "from ROS 1 to ROS 2" from those sub-pages, but it's not a big deal either way. If you choose to keep the longer titles, "Migrating Scripts" should be updated to "Migrating Scripts from ROS 1 to ROS 2".
Otherwise, I'm satisfied with this PR 👍


Generate RR serverside

Very simple implementation to generate RR packets serverside.
Related to: https://github.com/ging/licode/issues/683#issuecomment-270655247

As requested, here's a full implementation of rr generation. I tested it a few days and seems working very well.
I think that they have to be in the same place, as they're all stats computed serverside and they rely on each other.
And if we want to disable them, we can disable simultaneously and leave licode forwarding client's rtcp.
Let me know what do you think

thanks for the precious advices.
I'll do my best to re arrange everything in my spare time!


Cannot find the result files

Thank you for creating such a promising software and distributing it openly to the scientific community! I installed the software and dependencies successfully. I launched an analysis and it seems to have completed successfully. However, I cannot find the result files. Where are the .csv files saved by default?

Hi Maxence,
The .csv files are under the root directory of ECL-PF if you are using the cleavable searching module.

Hi Weichuan,
I am using the non-cleavable module and cannot find the .csv files under the root directory of ECL-PF. Are the .csv files from cleavable and non-cleavable searches saved under different directories?
Best,
M

M,
In the non-cleavable module, the final .csv files should be located within the input data directory (typically the directory where your .mzxml files are stored). If you're unable to find the .csv files, it's possible that the file path contains special characters that are causing issues. In such cases, you can try relocating your data to a simpler file path, like directly under the D: disk drive, and then run the module again.
If you still can't locate the .csv files after trying the above steps, please let me know and I'll provide further assistance. Additionally, if you could share a screenshot of the user interface (UI) page, I can better understand the issue and help you troubleshoot the problem effectively.
Chen Zhou
<EMAIL_ADDRESS>

Hi M,
I have fixed the bug in the non-cleavable searching mode in your case. You can refetch the repo and run your analysis again to see if it works. If you still cannot find the final file, we can further discuss the reason.
A correction to my last response (though I have deleted that response to avoid misleading to others) regarding the default path of your final .csv result, both cleavable and non-cleavable mode will return the final .csv file under the same directory as your input mzxml files.
Best,
Chen
<EMAIL_ADDRESS>


Get Postgres 11 working in Travis

Describe the bug
Webservcie Travis CI builds started failing on the integration-tests profile. Rolling back from Postgres 11 to Postgres 9 fixed the problem. An example -- it's running out of database connections.
To Reproduce
Tried running locally and it passed. Seems to fail only on Travis.
Additional context
Postgres 11 was implemented on Travis by running it in a Docker container, as Travis CI does not have easy "native" support for 11 like it does for 9. It's possible that's the problem, or part of the problem -- fixer could try running Postgres 9 in a Docker container as a datapoint.
There's an interesting article on how to detect connection leaks in unit tests, which would be a good thing to have regardless.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Sprint: Sprint 32 Grouper
┆Issue Number: DOCK-1284

Can also switch to postgres 10 first as another data point


Try to fix lr hydrostatic balance func for gpus

I think this might be all we need-- it won't be efficient, but I don't think it needs to be since it happens at initialization

Is this what you meant?

Yes, thanks for the suggestions. I think that branch was somewhat unfinished. I think this should work (although it won't be very performant). It's only done during initialization, so I think it should be fine. We could also split the CPU/GPU implementations so that the CPU doesn't suffer from this awkward pattern.

I think this is fine. As you mentioned it's only used during the initialization. Also it's only used in this one job.


KYLIN-4508 Add more unit tests to improve test coverage

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #1228 into master will increase coverage by 1.10%.
The diff coverage is 56.52%.

@@             Coverage Diff              @@
##             master    #1228      +/-   ##
============================================
+ Coverage     24.85%   25.96%   +1.10%
- Complexity     6266     6520     +254
============================================
  Files          1453     1453
  Lines         89225    89243      +18
  Branches      12456    12458       +2
============================================
+ Hits          22181    23173     +992
+ Misses        64869    63810    -1059
- Partials       2175     2260      +85

Impacted Files
Coverage Δ
Complexity Δ

...org/apache/kylin/metrics/lib/impl/RecordEvent.java
72.04% <0.00%> (+72.04%)
24.00 <0.00> (+24.00)

...pache/kylin/metrics/lib/impl/TimePropertyEnum.java
73.68% <ø> (+73.68%)
4.00 <0.00> (+4.00)

...pache/kylin/engine/mr/common/JobInfoConverter.java
60.29% <58.33%> (+31.61%)
23.00 <0.00> (+2.00)

...ache/kylin/metrics/lib/impl/BlockingReservoir.java
53.33% <66.66%> (+53.33%)
13.00 <2.00> (+13.00)

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
72.97% <0.00%> (-5.41%)
6.00% <0.00%> (-1.00%)

...org/apache/kylin/rest/util/QueryRequestLimits.java
35.71% <0.00%> (-4.77%)
5.00% <0.00%> (-1.00%)

...he/kylin/job/impl/threadpool/DefaultScheduler.java
74.41% <0.00%> (-2.33%)
12.00% <0.00%> (ø%)

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
63.84% <0.00%> (-2.31%)
0.00% <0.00%> (ø%)

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
69.30% <0.00%> (-1.83%)
7.00% <0.00%> (ø%)

...ache/kylin/engine/mr/common/AbstractHadoopJob.java
15.94% <0.00%> (+0.50%)
3.00% <0.00%> (+1.00%)

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7886a24...984dc81. Read the comment docs.

Merged by manual.


My Alexa Routes are not found (Laravel)

I am trying to get a "hello world" up and running

Laravel 5.5
i have configured aliases and providers as documented
the alexa.php config file is in my config.folder
regular routes work

in web.php I have included:
\AlexaRoute::launch('/your-app-uri', 'App\Http\Controllers\AnyController@anyMethod');
And created AnyController and anyMethod.
When I launch /your-app-uri I am getting a 404. Same when I post something against this URL using Postman. artisan route:list does not show your-app-uri as valid url.
Is this supposed to be like this? Did I miss anything to get the AlexaRouter working?

Maybe https://github.com/develpr/alexa-app/pull/41/commits/9423ec3e79ddcc239eebe6311110f90b3e48d9b4?
Sebastian

@luebbert42 Try registering following middleware and see the stacktrace in logs. Let us know what is in stacktrace. Here you can verify your each request and it's parameters.
<?php

namespace App\Http\Middleware;

use Closure;
use Illuminate\Support\Facades\Log;

class LogAfterRequest
{
    public function handle($request, Closure $next)
    {
        return $next($request);
    }

    public function terminate($request, $response)
    {
        Log::info('app.request', ['request' => $request->all()]);
        // Log::info('app.response', ['response' => json_encode($response->content())]);
    }

    private function getallheaders()
    {
        if (!is_array($_SERVER)) {
            return [];
        }

        $headers = [];
        foreach ($_SERVER as $name => $value) {
            if (substr($name, 0, 5) == 'HTTP_') {
                $headers[str_replace(' ', '-', ucwords(strtolower(str_replace('_', ' ', substr($name, 5)))))] = $value;
            }
        }

        return $headers;
    }
}

issue = bogus
Explanation:
The lib seems to return 404 if the request is not valid (I kind of expected another status code in this case).
I wanted to do a quick smoke test if I configured everything correctly and sent a simple "foo=bar" post request via Postman.
To do my smoke test I captured the alexa request using requestb.in and posted the JSON as raw request to my url using Postman. This worked.
Thanks for your support, guys, anyway :-)


Typo Found in Tailwind CSS AlertDialog Overlay Component

Problem Description
A typo has been identified in the stylesheet of the Overlay component using Tailwind CSS.
Extra spaces have been identified in one of the CSS, which may lead to inconsistent formatting or unexpected behavior.
Impact
While this is a minor issue, cleaning up these extra spaces can improve code readability and maintain consistency across the codebase.
Suggestion
Recommend removing the extra spaces to align with the standard coding conventions used in the project.

I've noticed the issue with the extra spacing in the Tailwind CSS configuration.
For keeping our code clean, I'm ready to address this issue and will submit a pull request with the corrected spacing soon.

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

I want to contribute to the project. Since it hasn't been corrected yet, I'm leaving a comment again. Thank you.


Unable to extract sequences

Hi! I'm having trouble extracting the sequences with nanopolish. It always gives me a empty output. This the command I used:
nanopolish extract -q -o ONT.fq ONT/reads/pass
I've tried changing the "type" parameter, extracting FASTA instead of FASTQ, using the recursive option and using the stdout, but I always get a empty output. I've also tried extracting the sequences with other tools and continuing with the nanopolish pipeline, but "eventalign" crashes because of a problem with the sequences and asks me to "re extract" them using extract.
Thank you for your help!

Generally speaking, in order to be usable with nanopolish, the fast5 files must contain certain types of data. Various settings of the ONT software pipelines might cause the fast5 files not to have all necessary data. To confirm this is indeed the problem, add --log-level debug to your nanopolish extract command line, and give it a single fast5 file (rather than a directory). In the resulting log (which is written to stderr), look for a line containing the string "preferred_groups". If there is nothing else listed on that line, that means there was no usable data in that fast5 file. Unfortunately, there is no easy fix for this, you have to rerun the ONT basecaller on your dataset with the correct settings.
In more details, nanopolish extract is looking for basecalled data (fasta/q) that also has associate event-level data. For example, the following fast5 groups must be available for nanopolish to use 2D basecalled data:
/Analyses/Basecall_2D_000/BaseCalled_2D/Fastq
/Analyses/Basecall_1D_001/BaseCalled_template/Events
/Analyses/Basecall_1D_001/BaseCalled_complement/Events

These are not filesystem paths, but internal indexes used inside fast5 files. To explore a given file, use, e.g., h5dump -n file.fast5.

Thanks for your answer! I don't have those groups in my fast5 data. It seems I'll have to rerun the basecalling or look for another way to correct my reads. Once again, thanks!

The fast5 library (used under the hood by nanopolish extract) incorporates the logic of looking for appropriate groups. So, the log message I mentioned first is a better indication that the files are unusable, rather than looking for those specific groups by hand.
The groups I mentioned are only an example, so you might have fast5 files that are still usable with nanopolish, but containing slightly different groups (e.g. .../Basecall_2D_000/... and .../Basecall_1D_000/..., the combinations vary depending on the ONT pipeline settings).

I just hit this same problem - no event information in my fast5 files. I can see nanopolish needs the event information for polishing, but why does it need it for extracting? It looks like it just uses the fast5 library to pull out the existing basecalled FASTQ. Would it be possible to skip the check for event information when just using extract?
Also, it would be great if nanopolish extract would output a warning if it didn't find any valid reads in a folder - ending silently was quite confusing. It even ended silently with --verbose switched on, and the --log-level option is undocumented.

I just made a PR that shows a counter at the end of a run with files seen and reads extracted. I also fixed -v to increase verbosity.
As for disabling the checks- The whole point of writing extract was to have a tool specifically for processing reads meant to be used with nanopolish. There are other tools out there that can extract fastq:

poretools

in the latest fast5 I added a program f5dump

with raw h5py:

import h5py
import sys
p = sys.argv[1]
for fn in sys.argv[2:]:
    f = h5py.File(fn)
    if p in f:
        print(f[p][()].strip())

Then, ./fqdump /Analyses/Basecall_2D_000/BaseCalled_2D/Fastq *.fast5 to get 2D data.

Thanks, the counter is very useful. I see it makes sense to keep extract for nanopolish use - it's just such a nice tool that we've drifted into using it even when we're not polishing... But the problem might go away anyway; we were dealing with locally-basecalled reads, which didn't contain event data, but it seems MinKNOW 1.3.24 will write events for each read. Thanks for your help!

Locally basecalled reads should contain events using the latest MinKNOW (released yesterday) so I think keeping the current behaviour is the right thing to do.

I need help...
I have a Basecalling 1D done with MinKNOW during sequencing. I used Albacore 1.0.3 to do the 2D Basecalling. When I use nanopolish extract, I obtain 0 read :
nanopolish extract -r -q -t 2d -v --log-level debug -o 2d_albacore103_run24.fastq ~/data/run24/albacore103/workspace/3/ct_39_20170313_FNFAF13217_MN16033_sequencing_run_sample_id_86066_ch399_read5433_strand.fast5
set default log level to: 3
= extract.2 nanopolish_extract.cpp:309 parse_extract_options paths: /home/equipe-cthermes/data/run24/albacore103/workspace/3/ct_39_20170313_FNFAF13217_MN16033_sequencing_run_sample_id_86066_ch399_read5433_strand.fast5
= extract.2 nanopolish_extract.cpp:310 parse_extract_options recurse: yes
= extract.2 nanopolish_extract.cpp:311 parse_extract_options read_type: 2d
= extract.2 nanopolish_extract.cpp:188 process_path /home/equipe-cthermes/data/run24/albacore103/workspace/3/ct_39_20170313_FNFAF13217_MN16033_sequencing_run_sample_id_86066_ch399_read5433_strand.fast5
= extract.3 nanopolish_extract.cpp:120 process_file /home/equipe-cthermes/data/run24/albacore103/workspace/3/ct_39_20170313_FNFAF13217_MN16033_sequencing_run_sample_id_86066_ch399_read5433_strand.fast5
= extract.3 nanopolish_extract.cpp:107 get_preferred_basecall_groups preferred_groups:
= extract.2 nanopolish_extract.cpp:139 process_file file [/home/equipe-cthermes/data/run24/albacore103/workspace/3/ct_39_20170313_FNFAF13217_MN16033_sequencing_run_sample_id_86066_ch399_read5433_strand.fast5]: no basecalling data suitable for nanoplish
[extract] found 1 files, extracted 0 reads
So, I understand, no usable data, but I see in my fast5 files, there are fastq data ! Mateidavid says :
"you have to rerun the ONT basecaller on your dataset with the correct settings". Ok but what are "correct settings" with Albacore for example. My problem comes from local basecaller or Albacore ?
Thanks a lot for any help,

Are you sure that particular file contains a 2D basecall group? With -t 2d, only 2D basecall groups will be considered. If, e.g., Albacore wasn't able to find 2D data in that particular file, then you wouldn't get any data from that file. Can you post the output of:
h5ls -r ~/data/run24/albacore103/workspace/3/ct_39_20170313_FNFAF13217_MN16033_sequencing_run_sample_id_86066_ch399_read5433_strand.fast5 | grep Dataset

Same here:
bec2-jcalvete@Bec2-jcalvete:~/Feina_Jordi/Minion/Bjararaca/Bjararaca_3/rawdata$ nanopolish extract -o prova.fasta test_10/ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5 --log-level debug
set default log level to: 3
= extract.2 nanopolish_extract.cpp:309 parse_extract_options paths: test_10/ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5
= extract.2 nanopolish_extract.cpp:310 parse_extract_options recurse: no
= extract.2 nanopolish_extract.cpp:311 parse_extract_options read_type: 2d-or-template
= extract.2 nanopolish_extract.cpp:188 process_path test_10/ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5
= extract.3 nanopolish_extract.cpp:120 process_file test_10/ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5
= extract.3 nanopolish_extract.cpp:107 get_preferred_basecall_groups preferred_groups:
= extract.2 nanopolish_extract.cpp:139 process_file file [test_10/ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5]: no basecalling data suitable for nanoplish
[extract] found 1 files, extracted 0 reads

So my question is: why does this error happen? I mean: I tried nanopolish with some archived Ecoli date and I had no problem. Then, with my own samples I found that no suitable data are available. Since we want to obtain some results, I used poretools but now I would like to polish the assembly with nanopolish_makerange.py but (obviously) I got the following error:
[fai_load] build FASTA index.
SquiggleRead: basecall group detection failed:
SquiggleRead: file name [pass_allfast5/ugm07_20170510_FNFAE31754_MN19775_sequencing_run_Bjar_1005_93698_ch192_read1068_strand.fast5]
SquiggleRead: read name [channel_192_64b5224f-fff2-4c0f-a20b-f6421410247f_template]
SquiggleRead: basecall group [1D_000]
SquiggleRead: read_type [0]
SquiggleRead: giving up; re-extract reads with 'nanopolish extract'

Do you think that the local basecalling with Albacore could be useful now? I mean, once I got the assembly and the bam alignment file?
More information about the sequencing run could be provided if necessary.
Thanks in advance

I suspect the 2D dataset names from albacore do not use the same convention as the old metrichor caller, which breaks nanopolish. Could someone provide an example fast5 by email?

uhmm.. actually we ran a 1D 48h script using Miknow. Attached you will find 10 f
test_10_nanopolish.zip
ast5 example files. I hope this helps.

Did you basecall with MinKNOW or albacore?

Sorry for the confusion: we performed the local basecalling with MinKNOW  i.e. attached fast5 files were obtained with MinKNOW.
However, since we have to carry out the basecalling again (we obtained a "giving up; re extract sequences with nanopolish extract" ) I was wondering if Albacore could be useful in order to use resulting fast5 files to polish an assembly previously obtained with the fasta files extacted using poretools. I hope this helps to clarify what has been done with data. Again, apologies.

extract now has an option to force it to use albacore basecalls. Could you try the -b albacore option?

Did you mean this?
nanopolish extract -b albacore ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5 --log-level debug

Resulting:
set default log level to: 3
= extract.2 nanopolish_extract.cpp:343 parse_extract_options paths: ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5
= extract.2 nanopolish_extract.cpp:344 parse_extract_options recurse: no
= extract.2 nanopolish_extract.cpp:345 parse_extract_options read_type: 2d-or-template
= extract.2 nanopolish_extract.cpp:346 parse_extract_options basecaller_name: albacore
= extract.2 nanopolish_extract.cpp:347 parse_extract_options basecaller_version:
= extract.2 nanopolish_extract.cpp:212 process_path ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5
= extract.3 nanopolish_extract.cpp:144 process_file ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5
= extract.3 nanopolish_extract.cpp:131 get_preferred_basecall_groups preferred_groups:
= extract.2 nanopolish_extract.cpp:163 process_file file [ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5]: no basecalling data suitable for nanoplish
[extract] found 1 files, extracted 0 reads

On the other hand it seems that minKNOW does not work better:
nanopolish extract -b minknow ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5 --log-level debug

set default log level to: 3
= extract.2 nanopolish_extract.cpp:343 parse_extract_options paths: ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5
= extract.2 nanopolish_extract.cpp:344 parse_extract_options recurse: no
= extract.2 nanopolish_extract.cpp:345 parse_extract_options read_type: 2d-or-template
= extract.2 nanopolish_extract.cpp:346 parse_extract_options basecaller_name: minknow
= extract.2 nanopolish_extract.cpp:347 parse_extract_options basecaller_version:
= extract.2 nanopolish_extract.cpp:212 process_path ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5
= extract.3 nanopolish_extract.cpp:144 process_file ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5
= extract.3 nanopolish_extract.cpp:131 get_preferred_basecall_groups preferred_groups:
= extract.2 nanopolish_extract.cpp:163 process_file file [ugm07_20170510_FNFAE31754_MN19775_mux_scan_Bjar_1005_85455_ch102_read12_strand.fast5]: no basecalling data suitable for nanoplish
[extract] found 1 files, extracted 0 reads

As mentioned above, since "get_preferred_basecall_groups preferred_groups" seems to be blank, the basecalling should be carried out again, shouldn't it?
Sorry for the inconvenience

Yes, that's what I meant. I'll take a look at your data and get back to you.

Ok, I see now, sorry for the confusion. The reads you provided only have MinKNOW basecalls and no event data. You'll need to re-basecall your dataset with albacore, then use nanopolish extract -b albacore to do the extraction.

Ok! That's exactly what I wanted to know. So, re-basecalled reads with albacore could be used in the following script??
python nanopolish_makerange.py Canu_assembly_contigs.fasta | parallel --results nanopolish.results -P 8 \ nanopolish variants --consensus=polished.{1}.fa -w {1} -r Sample_collapse.fasta -b Sample.contigs.sorted.bam -g Canu_assembly_Sample.contigs.fasta -t 8

i.e. extracted reads with poretools and assembled with Canu could be polished with new albacore basecalling?
Thank you very much

Yes but I suggest you extract with nanopolish extract rather than poretools to make sure all of the groups are set up correctly in the headers. Otherwise it looks fine.

Done! It worked! I performed again the basecalling with albacore and nanopolish extract returned (as expected) fasta sequences.
Thanks a lot Jared, your help was definitively helpful!

Thanks, glad to hear it.

Similar problems here using Albacore basecalled fast5 files.
Mac OS X Sierra with nanopolish 0.6.1 via Docker. nanopolish appears to be installed correctly however nanopolish extract -t 2d on individual (or directories of) .fast5 files reports:
[filename] is neither a fast5 file nor a directory
h5dump of [filename] appears OK, though no reference to albacore (should there be?)
We've also tried to force basecalling with nanopolish extract -b albacore but this reports that -b is an invalid option or
docker run adbailey4/nanopolish extract -b albacore --type 2d [filename]
extract: invalid option -- 'b'
= extract.0 nanopolish_extract.cpp:225 process_path path [albacore] is neither a fast5 file nor a directory

Installing nanopolish directly from github fails with clang and eigen issues which we've not managed to fix (due to our incompetence I suspect)
With thanks

Hi, I am getting errors in the last step where some of the contigs from makerange fail. This then inturn does not allow nanopolish to finish as parts of contigs are missing. I try to rerun that section of the original assembly contig and get the same error:
Error: could not find path to FAST5 for read 00001256-a822-49ff-bc72-f49bc3c8b5e3
Please make sure that this path is accessible
I then did some digging noticed you recommended using nanopolish extract, but I am not able to extract anything as none of the reads are suitable for nanopolish. I did an h5dump on a fast5 file and have the following:
{
FILE_CONTENTS {
group      /
group      /Raw
group      /Raw/Reads
group      /Raw/Reads/Read_4237
dataset    /Raw/Reads/Read_4237/Signal
group      /UniqueGlobalKey
group      /UniqueGlobalKey/channel_id
group      /UniqueGlobalKey/context_tags
group      /UniqueGlobalKey/tracking_id
}
}
I originally extracted the sequences using albacore 1.2.1
Please let me know if I need to change something or if I am doing something wrong. Thank you.


Upgrade to groovy 3.0 and spock 2.0 and junit 5

My attempt at fixing DAT-7666 as an alternative to #89

This PR is no longer valid


Oak Security Audit - Finding 7

As of now, there are no plans to change the code in response to this finding, as the transaction will fail at a later stage of execution if this scenario occurs, thus providing the same guarantees as catching the error earlier.


Update safely-drain-node.md

explanation on "kubectl drain" command

@tengqm is it fine now?

/remove-lifecycle stale

@Shubhdeep02 Please advise what's the status of this PR?


Remove Promises

This PR removes the Promises dependency and replaces it with Swift Concurrency (async/await)
Due to the nature of this PR it is breaking to the entire code base
my approach in this PR was to minimize other changes and focus on the Promises changes
[web3swiftEventloopTests.swift] has been disabled. It will require a full rewrite by someone

Now that 2.6.0 is out, please update this so it can be merged in as part of 3.0.

Please do test and let me know of issues you find. That test does need a total rewrite by someone, so I just disabled it for the PR. Good point on naming, I can resolve those 👍
All changes are related to the migration from Promises to Async/Await. For this round I intentionally focused on the migration leaving everything else in place. I have attempted no bug fixes. If there is code you would like me to revert leaving errors in compilation let me know.
Sent from my iPhone

On Apr 16, 2022, at 8:08 AM, mloit @.***> wrote:

@mloit commented on this pull request.
On first pass, I don't see any issues that stand out. Save for the one disabled test. I do want to spend some time with this in testing before I give my final approval.
On a more general comment, there do appear to be some structural/functional changes here that are unrelated, but interwoven, with the removal or promises. Avoid changes that alter the behaviour, code structure, or signature of the existing code that are not directly needed to support the purpose of the PR, even if a bug-fix (especially if a bug-fix!) Instead make these changes in a separate PR intended for that purpose. The one exception to this is cosmetic-only changes (in files you are already altering) for simple formatting related things and spotted typo's in comments. However given the scope of this PR, I'll give those changes a pass.
On another note, I wonder if the Promise directory (and files within) should be renamed, as we no longer use promises. Also by extension there are a number of xXxPromise() functions. Perhaps these should be reamed simply to xXx() or xXxAsync() since the promise name no longer makes sense?
In Tests/web3swiftTests/localTests/web3swiftEventloopTests.swift:

@@ -1,74 +1,41 @@
-//  web3swift
+////  web3swift
I'm not convinced this test should be disabled completely, but rather re-written.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.

That test does need a total rewrite by someone, so I just disabled it for the PR.

Generally you should never be disabling an existing test so you can pass. If it is necessary, comment the hell out of it to explain why, and add a TODO requesting a refactor. Also in cases like that, include mention of the disabled test in the top-level description of the PR. As by disabling a test, you are quite possibly side-stepping a bug you have introduced into the code that that test will catch.

All changes are related to the migration from Promises to Async/Await. For this round I intentionally focused on the migration leaving everything else in place. I have attempted no bug fixes. If there is code you would like me to revert leaving errors in compilation let me know.

There are some (not many) changes that were made, like converting a function call to a computed property, or consolidation of code/properties across multiple files. Yes these things were all altered because of the change, the overall structural change that you made was not a required part of implementing the PR. But as I said, given the scope of the PR, I'm going to give those changes a pass, and not request any changes.  They are still improvements, just unrelated.

I'm also thinking, that since we're in very beginning of the 3.0.0 path we're could ease a bit pr rules.
Speaking about async naming in wwdc video there're were introduced connive for that. But I need to view it once more to remember.
Also I'm willing to review available API calls available to lib users. So my point is that I'm thinking we're not ready now to crave in stone any 3.0.0 API yet

I'm also thinking, that since we're in very beginning of the 3.0.0 path we're could ease a bit pr rules.
Speaking about async naming in wwdc video there're were introduced connive for that. But I need to view it once more to remember.
Also I'm willing to review available API calls available to lib users. So my point is that I'm thinking we're not ready now to crave in stone any 3.0.0 API yet

In WWDC they suggest to convert something like
FetchGasPrice()
to something like
gasPrice()

Did you build and test this PR? There are several issues I have when trying to do so.
First was the issue in package.swift I outlined in my comment above, that was required to get SPM to build the repo. After making that change the build still fails a couple of tests.
Secondly, The XCode project was still expecting files that had been removed. It also still references PromiseKit, and the wrong MacOS version (this needs to be updated in a number of places)... all of those things need to be updated just to get it to build.
It's a bit of a pain, but you need to manage and validate both the SPM and XCode project separately.
The following tests are failing:
web3swiftBasicLocalNodeTests/testEthSendExampleWithRemoteSigning()
web3swiftPromisesTests/testSendETHPromise()

let web3 = try await Web3.new(URL(string: "http://<IP_ADDRESS>:8545")!)
let allAddresses = try await web3.eth.getAccounts()
is where they fail for me due to not having your test node setup. Can we put on the roadmap testing the Swift code and not the server response? ie Swift Best Practices are to not do network calls and instead mock or stub or swizzle

the Carthage Project still cannot find some frameworks on my local machine but are libraries still  dependencies for this project

let web3 = try await Web3.new(URL(string: "http://<IP_ADDRESS>:8545")!) let allAddresses = try await web3.eth.getAccounts()
is where they fail for me due to not having your test node setup. Can we put on the roadmap testing the Swift code and not the server response? ie Swift Best Practices are to not do network calls and instead mock or stub or swizzle

The local test node is just ganache. Run ganache with the quickstart for Ethereum, that's it, no additional setup is required. No setup is required for the remote tests.

the Carthage Project still cannot find some frameworks on my local machine but are libraries still dependencies for this project

For Carthage to work you need to have the Xcode project up to date. and then run the following from the command line to resolve the dependancies:
carthage checkout
and then build them:
carthage build --no-use-binaries --platform iOS Simulator --use-xcframeworks
note you can set the platform to other targets if you want (macOS, tvOS....) The above is recommended as that is what the automated tests basically use.

let web3 = try await Web3.new(URL(string: "http://<IP_ADDRESS>:8545")!) let allAddresses = try await web3.eth.getAccounts()
is where they fail for me due to not having your test node setup. Can we put on the roadmap testing the Swift code and not the server response? ie Swift Best Practices are to not do network calls and instead mock or stub or swizzle

Please take a look at the ci/cd pipeline for both Carthage and SPM building in ./.github/workflows/ci.yml, there's provied whole pipeline of building testing from scratch.
Also, please take a look at the Building from source chapter in readme.md.

added support to iOS 13 and macOS 10.15

I have updated the Carthage configurations however it is still giving errors

@pharms-eth github actions checks wouldn't pass on current ci/cd config you have. Please pull unstable branch to your to get new one, which is updated to work with your merge.


Store display name for sample and group

It can be useful to store unique ids for samples and groups while it makes more sense to store different ones for displaying in output
Add this to the Sample model

I will solve this in the report interface instead ;)


AWS Credentials and authentication

The app needs a way to obtain credentials and authentication to orchestrate the nescessary VMs.

[ ] Securely obtain AWS credentials upon start
[ ] Verify credentials and fail gracefully if not present

First, we need to define the AWS role that the application should inherit.

[ ] Create AWS role
The role should be able to:
List EC2 instances
Start EC2 instances
Stop EC2 instances
Remove EC2 instances


go: github.com/cosmtrek/air@latest: version constraints conflict:

Is this a problem with the tool or my system?  Thanks.
GNU Make 4.4.1
go version go1.23.3 windows/amd64
Windows 11
❯ make.exe init
â„¹ï¸  go: creating new go.mod: module gomake
C:/ProgramData/chocolatey/lib/make/tools/install/bin/make.exe deps
make[1]: Entering directory 'C:/Users/__redacted__/src/code/go/gomake'
ðŸ”¨ go mod download
go: no module dependencies to download
go: github.com/cosmtrek/air@latest: version constraints conflict:
<EMAIL_ADDRESS>parsing go.mod:
        module declares its path as: github.com/air-verse/air
                but was required as: github.com/cosmtrek/air
make[1]: *** [Makefile:528: deps] Error 1
make[1]: Leaving directory 'C:/Users/__redacted__/src/code/go/gomake'
make: *** [Makefile:220: init] Error 2

This is not a problem with your system. It was a URL that was incorrect.
Thank you for raising this.
It should be fixed by the latest commit.
Please let me know if can close this 😊

The error is gone.  Thank you.


Here's a new site I'd like you to consider blocking

Here's a new site I'd like you to consider blocking:
bsky.app
(please include any other relevant details)

I tried adding it to the custom blacklist, to no avail.

It's kinda all comments, like x, but I tried blocking replies. Let me know how it goes.

Hello,
Yes, I noticed it's completely different now.
Before the changes you made, the extension had no effect on BlueSky. Now, it has the desired behaviour, essentially the same as on X.
Regards!

Awesome, thanks for letting me know.


Objc cleanup

Reduce ObjC interface surface area. This cleans up the code and may improve build times.

Test failure looks like code sign BS.


Doesn't work on OBS Studio 27.0.1

Creates empty 44 byte file. No crashes or errors in log.
OBS log
Windows 10 20H2 19042.746
OBS Studio 27.0.1
Audio Writer Filter 1.4

Should be fixed with the new rebuild. https://github.com/ujifgc/obs-audio-writer-filter/releases/tag/1.27
Sorry for the inconvenience, this plugin is very dependent on internal OBS ABI so it has to be rebuilt for every time they change something major.

I see. It's a very useful tool and there's no alternative as far as I know. Maybe you could set up a CI using Github Actions to test and build automatically or have a manual workflow for convenience.


Tile component accessibility for preview & collection click actions & css fixes

As part of this PR,

Enabled Click action of Tile component through keyboard
Enabled Preview icon display & accessible through keyboard
Adjusted css according to the design of DAM collection & assets grid view

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.anupama-purus seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add support for Elastic Search as a store

Elastic search seems like an interesting choice for store technology.  Would give live access to the data in a queryable way.

Not sure what this might involve, but I would be interested in discussing it and seeing what sort of resources I might be able to provide (I work @ Elastic).

Great @markwalkom. I should not be that bad. Basically the store API as about 5-10 methods like upsert, get, list, ... all basic point or list queries.
What are you doing with ghcrawler and perhaps I can help guide.

I was looking at it as part of
the tool set that
Measure
 uses - https://github.com/MeasureOSS/Measure - and thought if we could
enable storage from this in Elasticsearch we can also leverage Kibana for
analytics :)
That'd also tie nicely into other tools like
https://github.com/morucci/repoxplorer and
https://wiki.linuxfoundation.org/chaoss/software
On 13 Mar 2018 2:30 p.m., "Jeff McAffer"<EMAIL_ADDRESS>wrote:

Great @markwalkom https://github.com/markwalkom. I should not be that
bad. Basically the store API as about 5-10 methods like upsert, get, list,
... all basic point or list queries.
What are you doing with ghcrawler and perhaps I can help guide.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/ghcrawler/issues/98#issuecomment-372535117,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADCYTj7_p0qXG--fQEFx4VVqHIkIsTbXks5tdz1DgaJpZM4N2p7m
.

Hi @markwalkom,
I have a basic implementation here: https://github.com/craigez/ghcrawler/commit/4540ca1283d30aa0483a9ca9adf398e0ba41772a
It's licensed under the MIT license, but I've been unable to get permission to sign the Microsoft CLA to get the contribution merged into the upstream 😢 . Additionally, we haven't really tested it much as we will probably go an alternate direction for our metrics, but we are still looking at options.

that's awesome, thanks @craigez! pity the licensing is causing problems though :(

It's not the licensing, MIT is fine, just the CLA to Microsoft.

I'll poke on this again and see if I can get it resolved soon.


Add 10 new typeguards and a small fix in WsFormattedMessage type hierarchy

Hi, I'd like to submit this pull request.
Contains two commits, more info provided in commit details
Cheers

Pushed new change. I can remove the class comment if it is not helpful ( about the file being organised by Typeguards message types) let me know

Also as a general observation/question, I wanted to create unit tests for these typeguards but I can't find a clean way to do that. The main issue I found is there does not seem to be a way to "bind" a typeguards with the types that they are supposed to guard for.
For example,  I can't see a good way to encode that WsMessageFuturesUserDataAccountUpdateFormatted is type guarded by isWsFormattedFuturesUserDataAccountUpdate.  If that makes sense..

Also as a general observation/question, I wanted to create unit tests for these typeguards but I can't find a clean way to do that. The main issue I found is there does not seem to be a way to "bind" a typeguards with the types that they are supposed to guard for. For example, I can't see a good way to encode that isWsFormattedFuturesUserDataAccountUpdate is "type guarding" WsMessageFuturesUserDataAccountUpdateFormatted. If that makes sense..

Regarding tests, I have mixed feelings here because these functions are not that complex. The main concern is functions used in many places (where breaking those functions will break other type guards as a side effect). I'd be tempted to throw a basic test at them...but at the same time, functions like isWsFormattedUserDataEvent aren't necessarily doing much either..
The other option is looking at integration tests rather than unit tests on the type guard itself. For example isWsFormattedUserDataEvent depends on the wsKey being provided by the ws client when it consumes and emits user data events. It'll be trickier to implement, but it would make this more robust (since the wsKey essentially must always contain that else the type guard is no longer valid).
The other option is end to end tests on these websockets. I've added the first generation of these to the bybit connector, although I'm not completely happy yet with how the test works it seems to add some extra safety around the ws client (at least more than without tests). Look at the ws*.test.ts files here if you're curious: https://github.com/tiagosiebler/bybit-api/tree/master/test/usdc/perpetual
End to end tests are still insufficient in my binance connector in my opinion, compared to my other connectors that have +100 of these making real api calls. It's unlikely to break unless I start doing low-level refactoring, but it's an extra safety net too (and I wouldn't start refactoring without them).
This is complicated a bit more too by the fact that binance blocked US IPs from making API calls (and CircleCI, used by this connector, is using US IPs). Not sure if github actions run on US IPs too (my other connectors use github actions), I did want to transition this connector to using github actions for tests too. Or I spin up a proxy and use the underrated proxying capabilities of axios via this connector. A few different approaches going forward that are currently on my mind...

Let me know once you've addressed the linting request (& if there's anything else you wanted to slip into this PR related to guards), otherwise I'm happy to merge after the linting. Thanks!

Thanks for the comments and pointers.  I have pushed the suggested changes now.
I did not know that Binance blocked US IPs, is it recent?  And is it complicated to migrate to github actions?

Thanks for the comments and pointers. I have pushed the suggested changes now. I did not know that Binance blocked US IPs, is it recent? And is it complicated to migrate to github actions?

It happened 1-2 weeks ago that they started blocking API calls from IPs in the US, quite frustrating. Migrating to github actions should be relatively easy, just need to move any secrets across and copy one of the build & test actions from my other connectors. Doesn't seem like it'll fix the US IP problem though without using a self-hosted runner or a proxy. Tempting to spin up a proxy (this would have the extra benefit of also verifying the proxying functionality is robust), but that's all for another PR.