Hello, can you provide us with the code you used to run tables 1 and 2 in the paper?

Hello, can you provide us with the code you used to run tables 1 and 2 in the paper?

Hi!
A group of students at UWashington have taken my code and cleaned it up and you can see it here: https://github.com/LoganMilandin/comp-gap-public
I haven't had a chance yet to fully review their code but the logic behind evaluating self-ask should be straightforward.
For least-to-most, just have two API calls:
First is for decomposition, and the prompt looks like:
Q: Who lived longer, Theodor Haecker or Harry Vaughan Watkins?
A: To answer the question "How old was Theodor Haecker when he died?", we need to know: "How old was Theodor Haecker when he died?", "How old was Harry Vaughan Watkins when he died?".

Q: Why did the founder of Versus die?
A: To answer the question "Why did the founder of Versus die?", we need to know: "Who founded Versus?", "Why did that person die?"

Q: Who is the grandchild of Dambar Shah?
A: To answer the question "Who is the grandchild of Dambar Shah?", we need to know: "Who is the child of Dambar Shah?", "Who is the child of of that person?".

Q: Are both director of film FAQ: Frequently Asked Questions and director of film The Big Money from the same country?
A: To answer the question "Are both director of film FAQ: Frequently Asked Questions and director of film The Big Money from the same country?", we need to know: "Who directed the film FAQ: Frequently Asked Questions?", "Who directed the film The Big Money?","What is the nationality of the director of the film FAQ: Frequently Asked Questions?","What is the nationality of the director of the film The Big Money?".

And then a second API call for doing the question answering, which looks like:
Who lived longer, Theodor Haecker or Harry Vaughan Watkins?

Q: How old was Theodor Haecker when he died?
A: Theodor Haecker was 65 years old when he died.
Q: How old was Harry Vaughan Watkins when he died?
A: Harry Vaughan Watkins was 69 years old when he died. The answer is Harry Vaughan Watkins.

Why did the founder of Versus die?

Q: Who founded Versus?
A: Gianni Versace.
Q: Why did that person die?
A: Gianni Versace was shot and killed on the steps of his Miami Beach mansion on July 15, 1997. The answer is shot.

Who is the grandchild of Dambar Shah?

Q: Who is the child of Dambar Shah?
A: Dambar Shah (? – 1645) was the king of the Gorkha Kingdom. He was the father of Krishna Shah.
Q: Who is the child of that person?
A: Krishna Shah (? – 1661) was the king of the Gorkha Kingdom. He was the father of Rudra Shah. The answer is Rudra Shah.

Are both director of film FAQ: Frequently Asked Questions and director of film The Big Money from the same country?

Q: Who directed the film FAQ: Frequently Asked Questions?
A: Carlos Atanes.
Q: Who directed the film The Big Money?
A: John Paddy Carstairs.
Q: What is the nationality of the director of the film FAQ: Frequently Asked Questions?
A: Carlos Atanes is Spanish.
Q: What is the nationality of the director of the film The Big Money?
A: John Paddy Carstairs is British. The answer is no.

Here you feed in your questions one by one.
Does this answer your question?

Hi, here's my question: in least-to-most, how does the second prompt use the output of the first stage? (In the second stage, if only one API call is needed, is that all sub-questions obtained from the first stage should be feeded into the second prompt at one shot? Should I append the output of first stage behind the inference-time question in the second stage?)

Thanks ! Are the prompts for different methods in your code the same?

Thanks ! Are the prompts for different methods in your code the same?

Nope, different methods (Chain-of-Thought, self-ask, least-to-most) each use a different prompt. To see the different prompts, please check our appendix in the PDF: https://ofir.io/self-ask.pdf

Hi, here's my question: in least-to-most, how does the second prompt use the output of the first stage? (In the second stage, if only one API call is needed, is that all sub-questions obtained from the first stage should be feeded into the second prompt at one shot? Should I append the output of first stage behind the inference-time question in the second stage?)

I am not an expert in LtM, if you have any specific questions you should ask the authors of that paper. As we detail in the paper, LtM takes two API calls per compositional question. IIRC the output of the first stage is not fed during the second stage, but I might be wrong, it's been a while.

Thanks ! In addition, I would like to know what the hyperparameter settings were in the experiment I mentioned above.

I think all the hyperparams are mentioned in the paper. Here's how our API calls looked:
cur_prompt = prompt[0] + '\n' + '\n' + 'Question: ' + question + '\n' + prompt[1]
ans = openai.Completion.create(
  model="text-davinci-002",
  max_tokens=256,
  stop=None,
  prompt=cur_prompt,
  temperature=0)

I've uploaded my code for running self-ask / direct prompting for 2Wiki/Musique here:
https://gist.github.com/ofirpress/4f85ea2fa6c4dbc02a6bbb138edb915d
It's messy but I think it might help you

I've uploaded my code for running self-ask / direct prompting for 2Wiki/Musique here: https://gist.github.com/ofirpress/4f85ea2fa6c4dbc02a6bbb138edb915d
It's messy but I think it might help you

Thanks, this really helps me

In addition, I would like to know what the specific evaluation matrics of the experiment are.

The paper describes the metrics we use. This runner has some more info:
https://gist.github.com/ofirpress/56946574e57ca6a09b678fd2dda1c254
But this will not be everything you need, further aggregation of these numbers is needed, but it's just averaging them IIRC.

Hi, since openai is currently shutting down access to the text-davinci-00x family of models, I replaced the backbone with gpt-3.5-turbo-instruct(successor to the GPT completion model).
We use the offical implementation codes and it performs extremely poorly on the musqiue dataset. It is only able to achieve a f1 about 16~17.

3.5 should do better than davinci, I would search the code for issues. Maybe look at some outputs to check that things look OK.


Error: Request failed with status code 500. "OSError: [Errno 28] No space left on device: '/tmp/tmp3b4hjt77/obj_train_data/frame_04268

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

When I wanted to download my own dataset in YOLO format, it always shows that no space left on the device '/tmp/tmp3b4hjt77/obj_train_data/frame_04268'. But there is still space on my Mac. So I am very confused. Hope somebody can help me out. Thank you.  Docker Swarm
Operating System and version (e.g. Linux, Windows, MacOS): MacOS
Code example or link to GitHub repo or gist to reproduce problem:
Other diagnostic information / logs:
Logs from `cvat` container

Next steps
You may join our Gitter channel for community support.

Hi,
It says you are run out of drive memory. Probably CVAT could not prepare data for dataset exporting because of the issue.
I would recommend to release some memory deleting extra files (maybe old tasks for example) or release memory on the host where docker volume is located.

I would recommend to release some memory deleting extra files (maybe old tasks for example) or release memory on the host where docker volume is located.

Boris, thanks for your quick response. But how could I check where the docker volume is located? From my docker-compose.override.yml, I guess my docker volume is located at my device, like "/Users/stonemo/Downloads/agots/data", right?

@stoneMo Hi, please run docker inspect cvat | grep "MergedDir" 'and free space on the device where the returned path is located. /tmp/tmp3b4hjt77/o` is not located on your volumes.

docker inspect cvat | grep "MergedDir"

Hello, do you mean that the returned path is located on the docker, not on my volumes? Here is my returned path. But how to free space on that path. Where could I log in to the docker server? I am a freshman to the docker.

The filesystem of the cvat container is just some folder on you host filesystem, so this folder is located on some partition that depends on your system configuration. You need to free space on this partition.

@azhavoro Hello, is there any way for me to find my system configuration to locate this partition?

Please refer to docker documentation:
https://docs.docker.com/docker-for-mac/space/

@stoneMo have you solved this issue?


Youtube embed support

I can't embed YouTube links.

I think that this method of attaching videos is deprecated for imageboards, so I didn't implemented this feature. Also many boards have its own method to attach these videos and also can support another services like vimeo, so implementation of this feature would take a lot of work.
You can just post a link.


Request for an outlined forward and backward icon s

Hi, it would be great if we could have outlined forward and backward icons like this (https://icon-icons.com/icon/back-button-circle/79559) . There are only non-outlined ones in https://next.material-ui.com/components/material-icons

@jie-chen the icons are imported from https://fonts.google.com/icons, we have no controls over them.


Tekken 7 system crash/lockup

im too noob, dont know how to use apitrace. yet.
so basically, witcher 3 works fine no problem with dxvk but Tekken 7 insta crash whole system or atleast locks it up completely. and picture is filled with weird pixels in purple and or all different colors.
picture link: https://i.imgur.com/F7sLmlu.jpg
Software information
Tekken 7
System information

GPU: Vega 64
Driver: mesa 18.0.0
Wine version: staging 3.5 (tried other version, wont even start game)
DXVK version: dxvk-bin 0.41-1 (also tried git version same problem)

Log files

d3d11.log:

info:  D3D11CreateDevice: Probing D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Using feature level D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Probing D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Using feature level D3D_FEATURE_LEVEL_11_0

dxgi.log:

info:  Enabled instance layers:
info:  Enabled instance extensions:
info:    VK_KHR_surface
info:    VK_KHR_win32_surface
info:  AMD RADV VEGA (LLVM 6.0.0):
info:    Driver: 18.0.0
info:    Vulkan: 1.0.57
warn:  DxgiFactory::QueryInterface: Unknown interface query
warn:  50c83a1c-e072-4c48-87b0-3630fa36a6d0
warn:  Vulkan extension VK_KHR_maintenance2 not supported
info:  Enabled device extensions:
info:    VK_KHR_descriptor_update_template
info:    VK_KHR_maintenance1
info:    VK_KHR_shader_draw_parameters
info:    VK_KHR_swapchain
info:  Enabled instance layers:
info:  Enabled instance extensions:
info:    VK_KHR_surface
info:    VK_KHR_win32_surface
info:  AMD RADV VEGA (LLVM 6.0.0):
info:    Driver: 18.0.0
info:    Vulkan: 1.0.57
warn:  DxgiFactory::QueryInterface: Unknown interface query
warn:  50c83a1c-e072-4c48-87b0-3630fa36a6d0
warn:  Vulkan extension VK_KHR_maintenance2 not supported
info:  Enabled device extensions:
info:    VK_KHR_descriptor_update_template
info:    VK_KHR_maintenance1
info:    VK_KHR_shader_draw_parameters
info:    VK_KHR_swapchain
warn:  DxgiSwapChain::QueryInterface: Unknown interface query
warn:  94d99bdb-f1f8-4ab0-b236-7da0170edab1
warn:  DxgiFactory::MakeWindowAssociation: Ignoring flags
info:  DxgiPresenter: Recreating swap chain:
Format:       VK_FORMAT_B8G8R8A8_SRGB
Present mode: VK_PRESENT_MODE_IMMEDIATE_KHR
Buffer size:  1920x1080
warn:  DxgiSwapChain: Display mode changes not implemented

ok will try.

tried mesa-git and it came with llvm 7. same problem.


Strange syntax parsing issue on a simple Java case

I am trying to parse a very simple Java code:
class A {
    private Button button;

    void onCreate() {}
}

function getTokenText(source, token) {
    if (token.text == null) {
        token.text = source.substring(token.startIndex, token.endIndex);
    }
    return token.text;
}

registry.loadGrammar('source.java').then(grammar => {
    var lineTokens = grammar.tokenizeLine(source);
    for (var i = 0; i < lineTokens.tokens.length; i++) {
        console.log(getTokenText(source, lineTokens.tokens[i]));
        console.log(JSON.stringify(lineTokens.tokens[i]));
    }
    console.log("parsing done.")
});

After tokenizing, I see " Button button" is considered as one single token.
...
private
{"startIndex":14,"endIndex":21,"scopes":["source.java","meta.class.java","meta.class.body.java","meta.method.java","storage.modifier.java"],"text":"private"}
 Button button
{"startIndex":21,"endIndex":35,"scopes":["source.java","meta.class.java","meta.class.body.java","meta.method.java"],"text":" Button button"}
;
{"startIndex":35,"endIndex":36,"scopes":["source.java","meta.class.java","meta.class.body.java","punctuation.terminator.java"],"text":";"}
...

The strange part about it is vscode itself has no problem parsing it:

Am I using this package wrong?
The complete repro case can be found here (oniguruma is not available on runkit.com):
https://runkit.com/felixhao28/vscode-syntax-parsing

I figured out after reviewing the source code of vscode. I should follow the tokenizing multiple lines guide. I misunderstood that part when I first read it and I thought it is just a way for you to do efficient incremental parsing. Now I see this is required for tokenizing code of multiple lines.


free_fleet_server_ros2 crashes

Bug report
Required information:

Operating system and version:

Ubuntu 20.04

OpenRMF installation type:

source

OpenRMF version or commit hash

main branch ros2

ROS distribution and version:

galactic

ROS installation type:

source

Description of the bug
After launch a ROS1 client, i launch a ROS2 server by ros2 launch ff_examples_ros2 fake_server.launch.xml, but the server node just informed as the following and it crashed

[INFO] [1638518022.483330172] [fake_server_node]: registered a new robot: [fake_ros1_robot]

[ERROR] [free_fleet_server_ros2-1]: process has died [pid 171912, exit code -11, cmd '/home/ngochuy/ros2_workspaces/multiRobot_ros2_ws/install/free_fleet_server_ros2/lib/free_fleet_server_ros2/free_fleet_server_ros2 --ros-args -r __node:=fake_server_node --params-file /tmp/launch_params_5f60anz4 --params-file /tmp/launch_params_y095tg1m --params-file /tmp/launch_params_5pjacfl9 --params-file /tmp/launch_params_mqlxvvgn --params-file /tmp/launch_params_sgoeuvs2 --params-file /tmp/launch_params_hea3pzog --params-file /tmp/launch_params_ppfoebdy --params-file /tmp/launch_params_p6v8acqt --params-file /tmp/launch_params_x50b77_d --params-file /tmp/launch_params_2x9dczw3 --params-file /tmp/launch_params_wjw0spop --params-file /tmp/launch_params_vvf4bnhq --params-file /tmp/launch_params_1jxnx647 --params-file /tmp/launch_params_w2jjb2z6 --params-file /tmp/launch_params_ihcizken --params-file /tmp/launch_params_rdikzrhe'].

Additional information
I have run the node free_fleet_server_ros2 directly, but the result was the same.

Hello @Ngochuy2137! Thanks for raising this up. I just built and tested these launch files and haven't been able to replicate the problem at the moment. Could you provide the full log of launching fake_server.launch.xml?
Just as a sanity check before we investigate further, could you try a fresh build?
rm -rf build install log
colcon build --packages-up-to ff_examples_ros2

Hello @Ngochuy2137! Thanks for raising this up. I just built and tested these launch files and haven't been able to replicate the problem at the moment. Could you provide the full log of launching fake_server.launch.xml?
Just as a sanity check before we investigate further, could you try a fresh build?
rm -rf build install log
colcon build --packages-up-to ff_examples_ros2

Hi @aaronchongth, this is the full log when I launch
ros2 launch ff_examples_ros2 fake_server.launch.xml

[INFO] [launch]: All log files can be found below /home/user/.ros/log/2021-12-03-17-32-47-946520-user-HP-Computer
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [free_fleet_server_ros2-1]: process started with pid [218250]
[free_fleet_server_ros2-1] Greetings from free_fleet_server_ros2
[free_fleet_server_ros2-1] ROS 2 SERVER CONFIGURATION
[free_fleet_server_ros2-1]   fleet name: fake_fleet
[free_fleet_server_ros2-1]   update state frequency: 20.0
[free_fleet_server_ros2-1]   publish state frequency: 2.0
[free_fleet_server_ros2-1]   TOPICS
[free_fleet_server_ros2-1]     fleet state: fleet_states
[free_fleet_server_ros2-1]     mode request: robot_mode_requests
[free_fleet_server_ros2-1]     path request: robot_path_requests
[free_fleet_server_ros2-1]     destination request: robot_destination_requests
[free_fleet_server_ros2-1] SERVER-CLIENT DDS CONFIGURATION
[free_fleet_server_ros2-1]   dds domain: 42
[free_fleet_server_ros2-1]   TOPICS
[free_fleet_server_ros2-1]     robot state: robot_state
[free_fleet_server_ros2-1]     mode request: mode_request
[free_fleet_server_ros2-1]     path request: path_request
[free_fleet_server_ros2-1]     destination request: destination_request
[free_fleet_server_ros2-1] COORDINATE TRANSFORMATION
[free_fleet_server_ros2-1]   translation x (meters): -4.117
[free_fleet_server_ros2-1]   translation y (meters): 27.260
[free_fleet_server_ros2-1]   rotation (radians): -0.013
[free_fleet_server_ros2-1]   scale: 0.928
[free_fleet_server_ros2-1] [INFO] [1638527568.460594656] [fake_server_node]: registered a new robot: [ros1_tb3_0]
[ERROR] [free_fleet_server_ros2-1]: process has died [pid 218250, exit code -11, cmd '/home/user/ros2_workspaces/multiRobot_ros2_ws/install/free_fleet_server_ros2/lib/free_fleet_server_ros2/free_fleet_server_ros2 --ros-args -r _node:=fake_server_node --params-file /tmp/launch_params_88h9wp2i --params-file /tmp/launch_params_dhs3frhr --params-file /tmp/launch_params_xhhefieu --params-file /tmp/launch_params_pnhqljtq --params-file /tmp/launch_params_bh4zxip6 --params-file /tmp/launch_params_85jjf7w7 --params-file /tmp/launch_params_7ionijp8 --params-file /tmp/launch_params_lzfhrx4f --params-file /tmp/launch_params_xhh3rdkq --params-file /tmp/launch_params__7o_iebg --params-file /tmp/launch_params_ygjb5mmr --params-file /tmp/launch_params_mmpe9kh --params-file /tmp/launch_params_alwxbek1 --params-file /tmp/launch_params_ks1gm7c9 --params-file /tmp/launch_params_37mz2yd4 --params-file /tmp/launch_params_fp1zsof1'].

I am still unable to re-create the issue, unfortunately. My apologies. These were the steps I took for my workspace, could you try them out and see if it still happens?
mkdir -p ~/ff2/src
cd ~/ff2/src
git clone https://github.com/open-rmf/free_fleet -b main
git clone https://github.com/open-rmf/rmf_internal_msgs -b main

cd ~/ff2
source /opt/ros/galactic/setup.bash
colcon build --packages-up-to ff_examples_ros2

source ~/ff2/install/setup.bash
ros2 launch ff_examples_ros2 fake_client.launch.xml

In another terminal,
source ~/ff2/install/setup.bash
ros2 launch ff_examples_ros2 fake_server.launch.xml

@aaronchongth I still haven't fixed the issue, I will try it later. Thanks for your help!

Hello! I get the same error from my side.
@Ngochuy2137 Were you able to solve it ?

Same issue here. I was working properly initially. And suddenly I started getting this issue.

thanks for bringing this up @veeraragav  and @Aridani3! Is it possible to dump these logs onto a github gist instead of a screenshot?
As a sanity check, does it happen consistently after registering a new robot?
Could you also provide me with the .repos file for your workspace,
go to your server workspace,
cd server_ws
vcs export src > server.repos --exact

this will give me the best chance of reproducing the error. Thanks!

Yes, it happened consistently after registering a new robot. Like how that issue appeared from nowhere, the issue has disappeared magically now. I hope it does not show up again.
server.repos.txt

Thanks for sharing it!
From your stack trace, it looks like it could be related to cyclonedds. I still have not been able to reproduce it as of now, but I will keep looking out for it.
For now, if it ever starts happening again, could you try switching the DDS implementation and trying again. This can help us determine if it was indeed related to cyclonedds

Sure. Thanks for the quick assistance!
On Thu, Jan 27, 2022 at 9:23 PM Aaron Chong @.***>
wrote:

Thanks for sharing it!
From your stack trace, it looks like it could be related to cyclonedds. I
still have not been able to reproduce it as of now, but I will keep looking
out for it.
For now, if it ever starts happening again, could you try switching the
DDS implementation
https://docs.ros.org/en/galactic/How-To-Guides/Working-with-multiple-RMW-implementations.html
and trying again. This can help us determine if it was indeed related to
cyclonedds
—
Reply to this email directly, view it on GitHub
https://github.com/open-rmf/free_fleet/issues/113#issuecomment-1023898140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNL4O4PNITX7ZN3D46OAD3UYIR5DANCNFSM5JJCBQ7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for sharing it!
From your stack trace, it looks like it could be related to cyclonedds. I still have not been able to reproduce it as of now, but I will keep looking out for it.
For now, if it ever starts happening again, could you try switching the DDS implementation and trying again. This can help us determine if it was indeed related to cyclonedds

Hello.
We are experiencing the  error mentioned in the OP on the ROS2 Foxy Distribution. Both with client and server. We have also tried running it with both FastRTPS and CycloneDDS, to no avail.
Any other solutions?

I solved this issue on my side. It was my mistake. I had two ROS2 workspaces. The first one had all the packages from open-rmf and the second one had free_fleet and rmf_internal_msgs. I later found out that rmf_internal_msgs was also installed in the first workspace but a different version. That created this conflict.

Hi @TijnLosekoot! Thanks for raising this up, sorry to hear about what you're facing. As a sanity check, could you perhaps try out the solution @veeraragav mentioned and see if you manage to get somewhere?
I would also suggest migrating to galactic, since it has many improvements over foxy, though the issue might still persist.
If not, could you please provide some more information so I can attempt to recreate the issue.

Thanks for sharing it!
From your stack trace, it looks like it could be related to cyclonedds. I still have not been able to reproduce it as of now, but I will keep looking out for it.
For now, if it ever starts happening again, could you try switching the DDS implementation and trying again. This can help us determine if it was indeed related to cyclonedds

Hello. We are experiencing the error mentioned in the OP on the ROS2 Foxy Distribution. Both with client and server. We have also tried running it with both FastRTPS and CycloneDDS, to no avail. Any other solutions?

Hi @TijnLosekoot , I had the same problem and i figured out it was the same reason as @veeraragav mentioned earlier so i solved it by removing the other workspaces that have anything to do with rmf then i did the following steps to get it working
`
$ mkdir -p ~/ff_ws/src
$ cd ~/ff_ws/src
$ git clone https://github.com/open-rmf/free_fleet -b main
$ cd ~/ff_ws
$ source /opt/ros/galactic/setup.bash
$ colcon build --packages-up-to ff_examples_ros2
`
As you can see I did not clone this package "git clone https://github.com/open-rmf/rmf_internal_msgs -b main" because if I am correct, rmf_internal_msgs is included by default if you install ros2 foxy or galactic via the Debian binaries (e.g ros-galactic-desktop). So If you clone rmf_internal_msgs into your workspace and build with colcon then you get warning messages
Then in a new terminal, I executed:
$ source ~/ff_ws/install/setup.bash $ ros2 launch ff_examples_ros2 fake_client.launch.xml
Then in a new terminal again I executed:
$ source ~/ff_ws/install/setup.bash $ ros2 launch ff_examples_ros2 fake_server.launch.xml
The result:

@spydatron solution works for me too

Good to know, thanks for confirming! I will close this issue now.


[PE-D][Tester E] No definition of unambiguous prefix provided

No definition of unambiguous prefix provided

Labels: type.DocumentationBug severity.Low
original: tahsinhasem/ped#5

Note to other members. Can include a quick example of an unambiguous prefix. (Though as of now there’s no ambiguous prefix lmao).

Not cosmetic (formatting) issue, just use severity.Low instead.

Isn't "r/s" example a quick example of unambiguous prefix?


Will pre-trained model be provided?

Yes, please provide checkpoints. It is great for other researchers and it also provides more evidence for your results.

@ALISCIFP @GKeppler I never thought about that sorry for inconvinience. I will upload several files that I have trained back in the days (because I can't have any time for re-train this)

https://drive.google.com/drive/folders/146ZFPZyFyRQejB8CBYZ_R26NEXEO4EjI?usp=share_link
Hi, I have shared pytorch model, but you should know that these files may need some minor modification in order to do proper inference (such as size modification).

@SangbumChoi Hi Dr. Choi, Thanks fo sharing for these. Can you specify which file corresponds to which experient configuration in your paper? I mean the correspondence between these pre-trained PyTorch models and experiment configurations.  Thanks!

@ALISCIFP I just uploaded random pth file that I have (I have more random ONNX, TF file also). So I'm not sure which one is the exact configuration of mine... You can re-run my train code.

@SangbumChoi Thanks so much! That's fine. Can you upload all the ONNX, and TF files, please?

https://github.com/PINTO0309/PINTO_model_zoo/tree/main/156_MobileHumanPose


: update documentation on jaguar vector store

Description: update documentation on jaguar vector store: Instruction for setting up jaguar server and usage of text_tag.
Issue:
Dependencies:
Twitter handle:

thanks @fserv!

thanks @fserv!

You are welcome. Thanks much @baskaryan !


tanhevg/posterior sampled emulated particle selection

this PR supersedes #50

Codecov Report

Merging #52 into master will increase coverage by 3.72%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   70.04%   73.77%   +3.72%
==========================================
  Files          18       17       -1
  Lines        1115      915     -200
==========================================
- Hits          781      675     -106
+ Misses        334      240      -94

Impacted Files
Coverage Δ

src/util/emulation_helpers.jl
85.07% <0%> (-3.09%)
:arrow_down:

src/abc/io.jl
77.77% <0%> (+54.86%)
:arrow_up:

src/gp/gp.jl
85.56% <100%> (+2.99%)
:arrow_up:

src/gp/kernels/abstract_kernel.jl
20% <0%> (-20%)
:arrow_down:

src/gp/kernels/scaled_squared_distance.jl
92.85% <0%> (-3.92%)
:arrow_down:

src/abc/summary_stats.jl
94.59% <0%> (-2.71%)
:arrow_down:

src/abc/simulation.jl
100% <0%> (ø)
:arrow_up:

src/gp/kernels/rbf_kernels.jl
100% <0%> (ø)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 822af93...ee8e5ac. Read the comment docs.


The app is Crashed when we go back screen in credit card screen

The app crashes when we use the camera to pick an image or only just open the camera without capturing it, after that when we go to the credit card screen and click the back button the app crashes.
we have tested it without opening the camera it does not crash when we click the back button in the Credit card screen of Paytabs but when we open the camera go the this specific screen (Credit Card) and click the back button the app completely crashes.

We will work on reproducing the crash and fix it very soon.

Unfortunately, we can't reproduce the issue from our side, so we need to collect more details about the issue, if you could share the configuration and a screen recording for the issue and send it to<EMAIL_ADDRESS>to investigate the issue and if we still can't reproduce it, they will request a technical call with you.

@MuhamedAdly @amr-Magdy-PT  @muhammadalkady @AdlyPayTabs
we successfully reproduced the issue.
SDK version : 2.6.16
Steps to Reproduce:
Initiate a payment using a debit or credit card.
Cancel the payment.
Expected Behavior:
The payment should be successfully canceled, and the user should be redirected to a confirmation page or returned to the previous step in the checkout flow.
Actual Behavior:
The app becomes unresponsive and remains stuck on the following page:

Please do not hesitate asking for more details.

Could you please contact<EMAIL_ADDRESS>to collect more details as we can't reproduce the issue from our side.


[BUG] @Output properties are displayed incorrectly in API docs

:bug: Bug report
Current Behavior
@Output properties are displayed incorrectly in API docs

They are nested inside the <tbody> of the previous @Input
Expected Behavior
Output properties should be displayed sibling to any other properties, not as a child property.
Minimal reproduction of the problem with instructions
View next.daff.io/docs/design/api/notification/DaffNotificationComponent
What is the motivation / use case for changing the behavior?

Environment

Daffodil version: X.Y.Z
Angular version: X.Y.Z

For Tooling issues:
- Node version: XX
- Platform:

Others:

We acknowledge that this bug is real, but the work to fix this is unnecessary and is being replaced by
https://github.com/graycoreio/daffodil/issues/3306


Only Movies

Description
Hey is there a way to list only movies section no series.
Desired Behavior
For all users, they can view and request only movies.
Additional Context
No response
Code of Conduct

[x] I agree to follow Jellyseerr's Code of Conduct

You can turn off request permissions for shows for all users. You can also edit the sliders on discover page and remove the series ones and leave the movies one only.

@Fallenbagel  yup checked that one. It's good but it would be better to have an option to disable it f from left pane and Trending cause even if we disable series in discover it's still accessible from left pane.

@Fallenbagel  yup checked that one. It's good but it would be better to have an option to disable it f from left pane and Trending cause even if we disable series in discover it's still accessible from left pane.

Yeah from the panel it is. But they can't request but yeah I get what you're saying c:

@Fallenbagel  no rush, if you ever find some spare time. btw thanks for the great effort

Partial duplicate of #163


Exceptions thrown inside of SubFlow don't cancel entire stream when using SupervisionStrategy.Stop

What happened?
Whenever an exception is thrown in a SubFlow (i.e. as a result of using splitAfter for creating sub flows based on time slice) it does not respect the configured actor supervision strategy which means instead of the stream being terminated (which is what you would expect), it just repeats itself indefinitely.
What did you expect to happen?
If an exception is thrown inside a SubFlow it should cancel the parent stream which should propagate and cancel all substreams.
What else do we need to know?
Upstream issue/comment is here https://github.com/akka/akka/issues/23066#issuecomment-1122289242

So it turns out it is possible to cancel the stream, its just that you need to use a custom SubstreamCancelStrategy (it defaults to .drain where as we want .propagate). Its kind of weird that for this specific Flowoperator it ignores theSupervisionStrategy` so an upstream ticket was created at https://github.com/akka/akka/issues/31394.


Doris does not create partition in dynamic partition table

Describe the bug
Doris supports the creation of dynamic partition tables, but the actual partitions have not been created successfully.
To Reproduce
Steps to reproduce the behavior:

admin set frontend config ("dynamic_partition_enable" = "false");
create dynamic partition table

CREATE TABLE dynamic_partition
    (
    k1 DATE not null,
    k2 INT,
    k3 SMALLINT,
    v1 VARCHAR(2048),
    v2 DATETIME DEFAULT "2014-02-04 15:36:00"
    )
    ENGINE=olap
    DUPLICATE KEY(k1, k2, k3)
    PARTITION BY RANGE (k1)
    (
    PARTITION p1 VALUES LESS THAN ("2014-01-01"),
    PARTITION p2 VALUES LESS THAN ("2014-06-01"),
    PARTITION p3 VALUES LESS THAN ("2014-12-01")
    )
    DISTRIBUTED BY HASH(k2) BUCKETS 32
    PROPERTIES(
    "storage_medium" = "SSD",
    "dynamic_partition.time_unit" = "DAY",
    "dynamic_partition.start" = "-3",
    "dynamic_partition.end" = "3",
    "dynamic_partition.prefix" = "p",
    "dynamic_partition.buckets" = "32",
    "replication_num" = "1"
     );

waiting for 10 minutes more, partition is not created.

Expected behavior
Forbidden creating dynamic partition table when dynamic_partition_enable is false.

The statement I wrote is as follows:
CREATE TABLE F_PO_DETAIL
(
...
SK_MONTH INT NOT NULL COMMENT "订货年月代理键",
PRODUCT_NO VARCHAR(30) NOT NULL COMMENT "产品代码键",
PO_TOT_AMT DECIMAL(27, 5) NULL COMMENT "销售额",
...
)
ENGINE=OLAP
DUPLICATE KEY(DM_ETL_TIME, DM_DC_TIME, SK_MONTH)
PARTITION BY RANGE(SK_MONTH)()
DISTRIBUTED BY HASH(SK_MONTH)
PROPERTIES
(
"dynamic_partition.time_unit" = "MONTH",
"dynamic_partition.prefix" = "p",
"dynamic_partition.buckets" = "10"
);
But it doesn’t meet my needs.
I saw the official document but the examples given are all for managing future data.
How to import historical data with dynamic partition？


Request detail page

Closes #219.

Coverage decreased (-0.5%) to 99.488% when pulling b4c1b10a9c97cbde77082e14091d88135c0b7f93 on 219_1.23_Anfragen_details_page into 7fecfe1c5012ca487e09cedc5df6979cfaebaa41 on dev.

Coverage decreased (-0.1%) to 99.872% when pulling c94c5d60c2d1647364f5cb9e7f913842b3b05e3c on 219_1.23_Anfragen_details_page into 7fecfe1c5012ca487e09cedc5df6979cfaebaa41 on dev.

Coverage remained the same at 100.0% when pulling 8b2b14324d10445945a907dea2a13df534ddbca7 on 219_1.23_Anfragen_details_page into 7fecfe1c5012ca487e09cedc5df6979cfaebaa41 on dev.

@bjrne What do you mean? I ran rake db:drop db:migrate and saw no changes to schema.rb.

@MasterCarl Weird. You created a migration that adds a column and still don't get a change in schema.rb? I don't know how that's possible. Do you have any idea @tom95?

@bjrne Looks like the schema changes are already on the dev branch...

Coverage remained the same at 100.0% when pulling 9b106dc587fd2b314a8254964a59ade747e89939 on 219_1.23_Anfragen_details_page into 2b67c8886b3c678089df3ae878746dd83efdc7ec on dev.

@MasterCarl true, it was you 😂 ba289f0.

@MasterCarl #336 removed the status line from the schema.rb in order to have the right schema. You should now be able (and forced) to add it here again.

Coverage decreased (-1.6%) to 98.365% when pulling 06e3ffa5f587b91c3e9469a9e5723382275efd4a on 219_1.23_Anfragen_details_page into 288b6f97c6ea3047ee3b76b1872f41074f2b3812 on dev.

Coverage remained the same at 100.0% when pulling abe7ca51f47accf5530a04f6398f228eb271be04 on 219_1.23_Anfragen_details_page into 288b6f97c6ea3047ee3b76b1872f41074f2b3812 on dev.

Coverage remained the same at 100.0% when pulling 809d5f1dae7cc02bf406babb58d93dc0d0dee4f9 on 219_1.23_Anfragen_details_page into 288b6f97c6ea3047ee3b76b1872f41074f2b3812 on dev.


Improved Container Support

Hi there,
I'm not sure if this is the way to go but I'd like to request the support of some containers where monitoring is not working in my environment:

plexinc/pms-docker (public tag)
tecnativa/docker-socket-proxy

I'm not sure what the issue is but I am getting a Unknow status for those two.

I am attempting to install in my environment. I currently have docker-socket-proxy setup and am hoping to use the socket proxy with MqDockerUp. Is there any support for this?


paper key notice takes me to "device page" and not "backup key page"

Keybase GUI Version: 1.0.40-20180205183337+269845275
This is extremely counter intuitive. A paper backup of my key has nothing to do with my devices. Everything about this interface indicates that clicking the notice has brought me to the wrong place.
I did not click the "add new" button, because I did not want to add a new device. It makes no sense that the paper backup system should be there.

This also completely confused me.


Upgrade to ElasticSearch 0.7.1

Upgrade to ElasticSearch 0.6.0.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 17 Apr 2010 at 10:46

Upgraded to ElasticSearch 0.7.1.

Original comment by<EMAIL_ADDRESS>on 25 May 2010 at 5:12

Changed title: Upgrade to ElasticSearch 0.7.1
Changed state: Fixed

Original comment by<EMAIL_ADDRESS>on 12 May 2010 at 3:00

Changed state: Accepted


Use camera height and FOV to draw image scale (e.g. 1m or 10m or 100m scale ruler) on thumbnails

I think these are the maths, but they deserve checking.
If we're given:

camera height δ
FOV α
Aspect ratio ρ

then the image width in distance is:


Add cmake support for C# netstd

This PR adds cmake support for the C# netstd implementation. The major changes are only in cmake and in the Visual Studio project files. The actual build is executed via dotnet (which has to be installed). cmake only orchestrates the build and can install the build artifacts.
A major change is that this PR fixes issue https://issues.apache.org/jira/browse/THRIFT-5143 for me. The required change is that the Thrift build for netstandard 2.0 can not be mixed and mingled with application builds for netstandard 2.0 or .net Framework, due to a missing dependency to reference assembly System.Threading.Tasks.Extensions, Version=<IP_ADDRESS>. This can be resolved by referencing the Thrift library artifact instead of the Thrift project file. See the Jira issue for a more detailed discussion.
I've tested the build on Windows, macOS and Linux successfully.

[ ] Did you create an Apache Jira ticket?  (not required for trivial changes)
[ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)

Full cmake support is in a single commit. There are two other, minor changes to C# code in two other commits in this same PR.

[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, add  [skip ci] at the end of your pull request to free up build resources.

+1 LGTM but not tested

The problem with the CI is not easily fixed for me. The issue comes from the fact that the autotools build does not resolve the dependency between tests and the Thrift library in the same way as I encoded it in cmake. A solution would be to encode these inter-dependencies in Thrift.sln.
But sadly I'm not knowledgeable enough in Visual Studio or autotools to fix either of these. Can someone help? If not, I guess this PR will need to wait...

.

Rebase still needed

It looks like broken the automake for C# netstd,too.

Updated to latest master, and various minor issues fixed.

I'm generally positive about using CMake so I can only repeat my +1.
PS: What does not make me happy is to maintain two build systems, but that's not really the topic here.


Make RawVal->Type checks only in debug/dev profile

Even in our own testing this has proven dangerous, all inputs should always be type validated.


Update _index.md

- Summary

- Test plan

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Starting to edit the default files of the site.


niimpy.preprocessing.location.ALL_FEATURE_FUNCTIONS does not need to be a dictionary

niimpy.preprocessing.location.ALL_FEATURE_FUNCTIONS is a dictionary where all items are empty dicts and keys are functions. I don't see a reason for this, it probably should be a list.

I see, this corresponds to the wrapper data format. I guess the wrapper needs a documentation page.


Add internal setting to use a custom privacy config url

Task/Issue URL: https://app.asana.com/0/488551667048375/1203562061687274/f
Description
This PR adds an internal setting to customize the privacy config URL.
Steps to test this PR

[ ] Install from the internal flavour, this should not be available in other flavour
[ ] Go to settings -> developer settings -> Override Privacy Remote Config URL
[ ] Toggle by default should be false
[ ] A message should say that the default url will be used either because the url is invalid or the toggle is not enabled
[ ] You should no be able to edit the edit field if the toggle is enabled.
[ ] Enable the toggle and enter a non-valid url
[ ] Message should still say the url is not valid or toggle is not enabled
[ ] Enter a valid URL
[ ] Mesage should be removed
[ ] Restart the app so the new config can be download
[ ] Check the new config has been saved

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2650   👈

This comment was auto-generated by Graphite.


Added medical GPT AI chatbot to analyse medical images

Added code using Medical GPT vision using OpenAI API key

The committed file is in submodule form. It should be visible with all files in it. Try to fix it.


Cloud Profile on the Base Class ??

I noticed that the Cloud profile has been added to the Base event class.  Under what circumstances would it be applied to every event class when it is also applied to specific event classes?

This change was pushed a few months ago I believe. cloud profile is not applied to specific event classes, it's only in the base event.
The reason being, logs in every event class that we have today or will have in future can be from cloud hosted system, hence  would require an object to store cloud attributes.(account_id, region, partition, provider etc).
For example, any system activity class can be used to map events emitted by a Windows system running on an EC2 instance in the cloud, the same goes for Network Activity classes, configuration/inventory classes, the upcoming Storage classes, so on and so forth.
Thus the idea to make cloud profile available in all the classes, and the simplest method of doing that is add it in the base_event, which every other class extends. Similar idea was used for the datetime profile.
Hope this helps.


Fix issue #80: Add @Valid annotation on request body

Proposal to fix issue #80

Good catch! Thanks


Update XPLA to v1.6.0

Thank you sir

Thank you, was out for a few days and did not see your last message until yesterday!


[Tracker] Tests failing because of device_info_plus

Hello,
This morning, tests fail because of this issue:
/opt/hostedtoolcache/flutter/stable-3.0.5-x64/.pub-cache/hosted/pub.dartlang.org/device_info_plus_windows-2.1.1/lib/src/device_info_plus_windows.dart:24:35: Error: Required named parameter 'userName' must be provided.
[203](https://github.com/openfoodfacts/smooth-app/runs/7721610124?check_suite_focus=true#step:8:204)
    final data = WindowsDeviceInfo(
[204](https://github.com/openfoodfacts/smooth-app/runs/7721610124?check_suite_focus=true#step:8:205)
                                  ^

The bug is from the device_info_plus dependency and an issue is already raised: https://github.com/fluttercommunity/plus_plugins/issues/1000

He and we are using version 3.x.x.
It could be fixed by using version 4. I had to upgrade it anyways in my PR to switch back to the official matomo version
https://github.com/openfoodfacts/smooth-app/pull/2740/files#diff-2febea6f4fe5f87d8e7061c53a42e132ccfd979c6e25770891ef4c654728de06R37

Merged and updated your PR, tests work again as well as local debug builds


OpenRGB Support

Describe the bug
I'm the developer of OpenRGB and my project supports the real Lighting Node devices.  I'd like to make sure it works with CorsairLightingProtocol as I would like to be able to recommend an Arduino running this project as a recommended controller for OpenRGB users.
Unfortunately, OpenRGB has trouble controlling an Arduino Pro Micro running CorsairLightingProtocol as a Lighting Node Pro.  A real Lighting Node Pro works correctly.  It may be that my implementation of the Corsair protocol doesn't exactly match iCue, but my code does work on a real Lighting Node Pro.
OpenRGB sends a keepalive (apply) message every 5 seconds as a real Lighting Node device will revert to the saved hardware effect mode after 20 seconds of bus inactivity.  It seems like CorsairLightingProtocol is applying changes on this keepalive rather than on the actual color update message.  After a few tries, it becomes unresponsive.
Here is my protocol documentation.  This is what I based my driver in OpenRGB on:
https://gitlab.com/CalcProgrammer1/OpenRGB/-/wikis/Corsair-Lighting-Node-Devices
I'm entirely open to the idea that I'm doing something wrong in OpenRGB.  This may not be CorsairLightingProtocol's fault.
OpenRGB issue link: https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/355
What works?
OpenRGB successfully detects my Arduino as a Lighting Node Pro.  I flashed the Lighting Node CORE sketch so I'm not sure why.  It shows up in Zadig/Device Manager/lsusb as a Pro.  Firmware version is correctly reported.
To Reproduce
Steps to reproduce the behavior:

Flash Arduino as Lighting Node Pro
Start OpenRGB
Resize channel 1 to number of LEDs (15 tested)
Click a color and Set Device

Expected behavior
Lights immediately change to selected color
Effect modes work
Actual behavior
Lights don't immediately change, sometimes apply set color on the 5s keepalive command.
Effect modes turn off the LEDs
System:

OS: Windows 10 and Debian Linux
Board: Arduino Pro Micro
IDE: Arduino IDE
Version: 0.13.0
Sketch: LightingNodeCORE

Code changes
None

I update the leds on the command 0x33 (WRITE_LED_TRIGGER) which is send by iCUE after a completed update to the configuration, so it guarantees a consistent state (some state is persisted on the Arduino). This is especially important with software playback, because the different colors (red, blue, green) are updated in a sequence of commands, so I can only update the leds after the sequence is complete. And currently this is indicated by the command 0x33. https://github.com/Legion2/CorsairLightingProtocol/blob/5d9594cdbc049c77699276960848117e601ea20b/src/LEDController.cpp#L23-L26

After a few tries, it becomes unresponsive.

What do you send as keepalive (apply) messages? You mean after some the keepalive messages the arduino becomes unresponsive?

Here is my protocol documentation.

The "Device Types" are actually the number of LEDs of that device, at least I have implemented it that way and it works.
I called the "Effect Configuration" LEDGroup:
https://github.com/Legion2/CorsairLightingProtocol/blob/5d9594cdbc049c77699276960848117e601ea20b/src/LEDController.cpp#L76-L95

My keepalive loop is a trigger (0x33, I called this CORSAIR_LIGHTING_NODE_PACKET_ID_COMMIT) message sent every 5 seconds.  I also send a commit after every command.
SendCommit: https://gitlab.com/CalcProgrammer1/OpenRGB/-/blob/master/Controllers/CorsairLightingNodeController/CorsairLightingNodeController.cpp#L258
My Effect Configuration function, it looks like my structure lines up with yours:
CORSAIR_LIGHTING_NODE_PACKET_ID_EFFECT_CONFIG    = 0x35,     /* Effect mode configuration packet     */
https://gitlab.com/CalcProgrammer1/OpenRGB/-/blob/master/Controllers/CorsairLightingNodeController/CorsairLightingNodeController.cpp#L303
The *10 on the count is probably an error.  I'm going to remove it.

The *10 on the count is probably an error. I'm going to remove it.

Don't remove it, it's the offset on the led strip for the effect. 10 is correct in case of corsair 10 LEDs strip, it should be the sum of all previous led_type. I use usb_buf[0x02] as offset and usb_buf[0x03] as length on the led strip for the effect and this works with iCUE(only uses offset 0) and SIV which can set multiple effects on a channel.

I can think of two possible problems (beside the *10) on my side.

There is a problem when 0x33 is received but there is nothing to commit
The keepalive packets are mixed with a sequence of other critical commands and cause some problem when committed in a dirty state.

I will look into these over the weekend.

I'm going to continue experimenting this weekend as well.  I added some sleeps between packet sends and that seems to have made it a bit more reliable, but it's only controlling the red channel in direct mode.  I haven't messed with the effect modes (built-in effects) yet.

I uncommented the save and it is still working fine.  The effect I set with OpenRGB is saved and starts back up if I unplug and reconnect it.
My guess is that there's something going on with the writes.  On the real LNP I don't need to do HID reads after each write, and in fact doing so seems to cause slowdowns and stalls.

Pushed a change to OpenRGB that gets it working with CLP as long as the 64->16 reply size change is implemented.


Update intro.md

Added a missing step (and some text) to the 'Add Razor Pages using Entity Framework (CRUD)' dialog:

@Rick-Anderson @scottaddie My first time incorporating someone else's changes. Let me know if I did it wrong or there's something else to do.

@the-wazz You did great! Thank you for fixing this issue in the doc.


Improvements aimed at increasing voting participation

Voting apathy is a serious vulnerability for the blockchain. It can be assumed that a lot of users don't vote because they don't realize that. These are simple changes that are aimed to alleviate this problem to some extent:
(1) If the system finds out that an account has a balance of e.g. 100k BTS (or more) and is not voting (i.e. no proxy set and there is no support for at least 10 witnesses), it should display a red warning in the footer (just as we have it for the wallet backup reminder).
(2) On the voting page there should be a clear instruction that the easiest way to vote is to select a proxy. To facilitate the choice of proxies a link to this forum board should be offered in the GUI:
https://bitsharestalk.org/index.php/board,104.0.html
(3) It's much easier to vote when you have a list to choose from (as we have it for worker proposals) instead of typing an account name. Currently we cannot compile a list of active proxies but a list of available accounts should be doable for witnesses and committee members.

Better to vote by select/click but not input. Currently only worker proposals are being voted this way.

@abitmore , very good point. I'll add it to the list above.

Voting needs a UX overhaul as well. I'll work on this.

Some suggestions in this post: https://bitsharestalk.org/index.php/topic,20962.0.html, too long and unfinished so haven't copy&pasted here.

Moved to bitshares-ui


Update removeAndRefundNodeRecord to also remove nodes from Approve list

Issue To Be Solved
Currently, removeAndRefundNodeRecord unstakes and removes staked access nodes, but if an access node was already on the approved list, it will not actually be removed from the record.
Suggest A Solution
Add a line to the method to also remove the specified node ID from the approve list if it exists there

Closing this because it was completed in #350


Integration of custom gulp tasks - formally build tasks

I did a quick check on the gulp tasks. From my point of view it is pretty much locked down and supports only some few options.
Let's say I have I like to use precompiled Handlebars during development I'm unable to extend the functionalities, because I don't have direct access to the gulp file.
My guess right now is that extensions like these are currently not supported. In future it will be great to have somehow an interface to inject custom build tasks in the overall build process.
Currently the only way is to use additional libraries via CDN.

Are you looking for customized tasks, or just improvements in how bundling libraries should work?
We are planning on doing a bunch of work documenting the build pipeline.  It is a plug-able system.  Adding in @nickpape-msft and @iclanton - who have done most of the work in this area.

I'm looking more into customized tasks. Let's stick with the handlebars example. I like to define a watch that compiles the HTML to a JavaScript add it, let's say in the Web Part Folder.
For the rest the normal bundelling should work.
Sure in additon those libraries should be bundled too.
So it's a mixture of both.

While it is possible to create your own gulp tasks, we don't have a way to inject steps into the build in tasks (ie, as part of gulp serve, do a, then build, then b).
We have some ideas on how to accomplish this, possibly by having specific phases that you can plug in to.  In all honesty though, it will likely be a while before we get to that step.

Meanwhile probably use another side project and gulp the compiled JavaScript source in. Just a workaround but should work.

Are you specifically trying to use *.hbs files in your bundle, and have them compile to JS as part of your build?
The easiest way to accomplish this is with a Webpack loader. There are a few existing Handlebars loaders. This one appears to be the most popular.
To use this approach to loading a *.hbs template, you need to do a couple of things:

Ensure *.hbs files are copied to the lib folder. To do this, you need to configure the copy-static-assets build task to copy *.hbs files. This is pretty simple - just add a copy-static-assets.json file to the config directory with the following contents:

{
  "includeExtensions": [
    "hbs"
  ]
}

Install the loader. Just run: npm install handlebars-loader --save-dev.

Reference your templates. This is all you need to do to reference a template:

const template = require('handlebars!./path/to/template.hbs');

To understand what's going on in this line, you need a little bit of background on how Webpack loaders work. Here's an article that goes into depth on the subject. Here's the TL;DR version - In a require statement, everything before the ! describes which loader Webpack should use to load the file. We predefine loaders to match certain extensions in our OOB config (like *.JS, *.PNG, *.JSON, *.CSS, and several others - this is something you'll be able to add to the Webpack configuration soonish. Keep an eye out for documentation), but you can specify the loader directly in the require call. Webpack allows certain shorthands for loader names (the most popular one is to call your loader <something>-loader) so webpack will take the name you specify (in our require('handlebars!./path/to/template.hbs') example, the loader name is handlebars) and look for modules with names that match a number of these patterns. It'll find the handlebars-loader and use that to load your template.
I realized that explanation rambled on for a bit, but hopefully it made sense.
Does that solve your problem?

So far the existing gulp build poses more problems than it solves.
It's all somewhere deep in node_modules, so in order to modify something I need to dig through 10 or 15 modules used during the build.
It would be much more useful to have a large gulp file which one could comprehend.
Otherwise it's not too different from what we had before with Visual Studio, it does everything for you but if you want to customize something - you're on your own.

The problem with modifying any of the existing files is that your changes will be overwritten should the tools update in the future. Also, given that node_modules is not stored in source control it would be hard to share the changes with a team.
It would be helpful to be able to plug into the build pipeline to include additional operations.

@vvolodin I don't agree, this way (and once the source for the generator is available) you have more customization options. But just as @waldekmastykarz  says - DO NOT overwrite or modify any default files, and do not even consider fiddling with the files in the node_modules directory. If you want to add a change to one of those modules, then get the correct module repo on github, propose a change (as a PR?) and wait for it to be correctly handled.

Well there are two points here to sum up.
@wictorwilen and @waldekmastykarz were at the dev kitchen and had early access to the SPFx. I guess this project had a proper gulp file that could be edited and extended with additional gulp tasks. Correct me if I'm wrong. :)
What @vvolodin is referring to that the current developer preview of SPFx that calls the build process directly from the node_modules. In order to inject something, the node_modules needs to be modified, which is never an option because the things in the node_modules shouldn't touched.
No offend here but but from my point of view the current state of the preview is a ready built visual stuido project generator based on nodejs and a pseudo yeoman generator that provision some files and install node_modules.
From my perspective it's no big deal right now because most people that currently use the generator are not that much into nodejs. It also gives a great insight on how we are able to customise build SharePoint Web Parts in future.
Overall the whole setup is a quite unusual for a yeoman generator. Normally you have a single gulp file that is editable and you are allowed to add custom build task to the already existing ones.
As Pat Mill mentioned on my inital comment I'm keen to see how this injection of custom gulp tasks will work in future. Right now lets get ourself familiar with the new kind of web parts and the work bench.
The worst option is to send a PR to a github repository to get your custom task in.

Totally with you on it @StfBauer with one little difference: to me it doesn't matter if I get to change SPFx standard build tasks or not as long as I can have the build process do everything I need to do. I can imagine, from the support point of view, it's easier to encapsulate standard build tasks to ensure that they are working as intended. To make it flexible, providing extension points that we could use would be sufficient for me. For advanced scenarios and opinionated developers, no matter which approach you choose, it won't be enough and you will end up building your complete pipeline yourself.
I agree that I haven't seen another project using Gulp the way its used in SPFx but it doesn't necessarily mean it's wrong. I'd love to hear the reasoning behind it. @chakkaradeep, @patmill care to chime in? 😄

@StfBauer thanks for expanding on my comment.
I don't mean to be overly critical but it just doesn't feel like I'm in control over my project and simple tasks take a lot of digging around transpiled typescript files to do. How to disable tslink, how to opt out of css-modules, how is webpack configured, how exactly my app part files are loaded by module loader, can I use react to build my settings panel. I realize of course that the project is at the early stage but this actually is a better time to make the build system more flexible in the future.

@vvolodin I guess it's twofold: on one hand there wouldn't be any harm in Microsoft exposing more of the build process and mechanics of the build process to us (like Webpack configuration). On the other hand if some of these tasks correspond to how the SharePoint Framework works in SharePoint (like loading modules) then it wouldn't make any sense in changing any of it in the dev tools, given that it wouldn't work after deploying your Web Part to SharePoint which would still use the original logic.

Oh, I just meant it would be useful to have some docs/understanding on how the stuff we're supposed to build is getting loaded. So far it's a bit too much of a black box thing - you just prepare your inputs, build it and observe the artifacts like manifest.json, stats.json, etc.
I like where this is going - local workbench, modules, webpack, live reload, but I'd like to have a possibility to build it without the generator as well.

Documenting the manifest and the different pieces would definitely be beneficial.

Injection of custom task currently works without any problem in one of my samples. Will write a blog post about it.

As someone who has lived in NodeJS for the last 9 months I just wanted to throw it out there that the way the current build system works is very non-NodeJSy  and I think anyone coming at this from a non-VS world will look at it and be like "wha?!"
Pros:  It does it's job and its simple.
Cons:  AFAIK no one else (in Node at least) does things this way and it will cause confusion.
My main concern is with how the gulp build pipe is all hidden away and for all intents and purposes not designed to be changed/modified (or at least that is how it looked to me). This is a problem for some of the reasons mentioned above.  If you want to add a much of pre-steps that integrate into the gulp build pipeline like adding source maps for example, or changing the TSC options etc... its not obvious how/where to do that.
Personally, I think if you have to document how your gulp build pipeline works and how to change it then there is something wrong. (no offense)
But that aside, I think the biggest issue is how people will view this when first looking. They will be expecting to open the gulp file and see how the project is built and be able to follow it easily.
Currently it looks like the approach has been like you would see in Visual Studio by hiding all the complexity, which isn't the norm in node projects.  Like i said, people expect to edit their build pipelines and add things they do as standard etc...
I personally think the current gulp build process could do with a design review with someone from the Node world who knows their stuff and would be able to consult on how to make it more approachable for that community. My 2c.

Problem solved by just using native gulp behaviour.
Before gulp executes all registered tasks will be evaluated and brought in the right order.
This fact allows to register task to any of the existing tasks.

I think it is suitable for many simple scenarious that precompiles files and puts them during a development process to a temp folder. In case fo SPFX it just put is to the web part folder.
Does it fell like a hack? Yes it does because of the missing gulp task in the gulp file.
On the other hand thats the way gulp actually is intended to work.
Wrote a more in depth blog post about it.
Use a custom gulp task in the new SharePoint Framework

I won't pretend I understand this, but I'm glad smart people are working on it. Maybe by the time I get around to finishing the "Hello World" walkthrough you'll have solved all the hard problems! :)

Closing this down now.

Is it possible to integrate custom build tasks now?

See here - https://github.com/Microsoft/web-build-tools/tree/master/core-build/gulp-core-build#defining-a-custom-task


Alignment function should give warning if compartments are selected

The alignment function should give a warning to the user of one or more compartments are selected.

For now, we have disallowed alignment when nodes from both inside and outside a compartment are selected


[Storage] Remove Encryption service support as feature team required.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
This change it used to remove Encryption Service enable/Disable support in New/set storage account, per the feature team required.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-python

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)
Command: profileBuilder -s preview -name preview
Finished with return code 127
and output:
/bin/sh: 1: profileBuilder: not found

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)
Command: profileBuilder -s preview -name preview
Finished with return code 127
and output:
/bin/sh: 1: profileBuilder: not found

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)
Command: profileBuilder -s preview -name preview
Finished with return code 127
and output:
/bin/sh: 1: profileBuilder: not found

@AutorestCI rebuild azure-sdk-for-python

Can one of the admins verify this patch?

@blueww this PR looks stale for about a year now. Please address comments and reopen if you are still willing to merge this.

Automation for azure-sdk-for-java

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-go

Automation for azure-sdk-for-node


zsh: command not found: dotnet

Problem encountered on https://dotnet.microsoft.com/en-us/learn/dotnet/hello-world-tutorial/install
Operating System: macos
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
zsh: command not found: dotnet

Hi, have you opened a new terminal session after installing dotnet SDK? The session needs to pick up the updated PATH variable.


Query parameters - Dictionary support?

Description
While am using this feature, I have this requirement where I need a parameter to be a Dictionary(key values list) for 'GET' query parameters.
Currently the GET operation seem to support only the following parameter types

String
Int
Enum
List[str] or List[int]
Kwargs(variable number of args in dictionary form)

Do you have any recommendations?. One suggestion I got is to use POST instead of GET and achieve the flexible query. Is that a good idea?

Can you add example of the url that you will be calling (including GET params) and expected result ?

Glad to give
I have a query like this
/s2/getNetwork?<>
Here I need to pass two parameters

One parameter is like this

location = [rack=r1, server=s2]

Second parameter is like this

timerange = [starttime=t1, endtime=t2]
Current implementation is like this.
@app.get(
"/s2/getNetwork",
tags=["s2Network"])
async def get_latency_metric(
location: List[str] = Query(
None,
alias="slice",
),
timerange: List[str] = Query(
None,
)):
My Requirements:.

First requirement is, I would like 'location' to be Dictionary so I can pass key, values inside it
i.e.
location = {{rack: r1}, {server:s2}}

Second requirement is, when specifying time as a parameter, in this example its timerange I need this parameter in time format so it helps to validate at client side before reaching server

I guess you can use Depends to achieve it:
import json
from typing import List
from fastapi import FastAPI, Query, Depends

app = FastAPI(debug=True)

def location_dict(locations: List[str] = Query(...)):
    return list(map(json.loads, locations))

@app.get("/test")
def operation(locations: List[str] = Depends(location_dict)):
    return locations

Thanks, it worked. However, am running into crash if I miss a parameter(say '{') at input
500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/uvicorn/protocols/http/httptools_impl.py", line 385, in run_asgi
result = await app(self.scope, self.receive, self.send)
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/uvicorn/middleware/proxy_headers.py", line 45, in call
return await self.app(scope, receive, send)
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/fastapi/applications.py", line 149, in call
await super().call(scope, receive, send)
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/starlette/applications.py", line 102, in call
await self.middleware_stack(scope, receive, send)
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/starlette/middleware/errors.py", line 181, in call
raise exc from None
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/starlette/middleware/errors.py", line 159, in call
await self.app(scope, receive, _send)
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/starlette/exceptions.py", line 82, in call
raise exc from None
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/starlette/exceptions.py", line 71, in call
await self.app(scope, receive, sender)
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/starlette/routing.py", line 550, in call
await route.handle(scope, receive, send)
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/starlette/routing.py", line 227, in handle
await self.app(scope, receive, send)
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/starlette/routing.py", line 41, in app
response = await func(request)
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/fastapi/routing.py", line 190, in app
dependency_overrides_provider=dependency_overrides_provider,
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/fastapi/dependencies/utils.py", line 510, in solve_dependencies
solved = await run_in_threadpool(call, **sub_values)
File "/Users/babu-s2/code/python/fastapis/ns/lib/python3.7/site-packages/starlette/concurrency.py", line 34, in run_in_threadpool
return await loop.run_in_executor(None, func, *args)
File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "./main.py", line 215, in location_dict
return list(map(json.loads, locations))
File "./main.py", line 215, in location_dict
return list(map(json.loads, locations))
File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/bdb.py", line 88, in trace_dispatch
return self.dispatch_line(frame)
File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/bdb.py", line 112, in dispatch_line
self.user_line(frame)
File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/pdb.py", line 259, in user_line
self.interaction(frame, None)
File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/pdb.py", line 342, in interaction
signal.signal(signal.SIGINT, Pdb._previous_sigint_handler)
File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/signal.py", line 47, in signal
handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
ValueError: signal only works in main thread
Is there a way to validate the values either at server side or else at openapi?
Thanks

you probably need to put
return list(map(json.loads, locations))
into try/except (to handle invalid json)

Thanks Vitalik. Thats what I thought so.
What about for timestamp, the second problem I mentioned? Is there a way to represent time val as parameter in time format?
Thanks

@vitalik How to make locations not required.

Hi, guys!
How to process parameters with names on the FAST API server:
field[0]=value0&field[1]=value1
like a dictionary:
field = {"0":"value0", "1":"value1"}
Thx!

Looking at starlette documentation today, I found that you can get a dict of query params  by using request like this
`from fastapi import FastAPI, Request
from pydantic import BaseModel
from typing import Optional
from datetime import date
app = FastAPI()
class Query(BaseModel):
msg: Optional[str] = None
page: Optional[int] = None
only_one: bool
when: date
@app.get('/')
async def home(req: Request, only_one: bool, when: date, msg: str = None, page: int = None):
query = Query(**req.query_params).dict(exclude_unset=True)
return query`

Take a look of #2230.

Hi,
I have similar issue when I have a param to accept dict type query
get_event(params: Dict[str, str] = Query(...))
I got error below. How do I have a param to accept dict type

  File "/home/gftea/.venv/eiffel/lib/python3.8/site-packages/fastapi/dependencies/utils.py", line 317, in get_dependant
    assert isinstance(
AssertionError: Param: params can only be a request body, using Body(...)


wip: restructure

This is just the first step to a restructure of the parser code.
It's still a work in progress and right now it's failing due to directory movements.
%!v(PANIC=Format method: runtime error: invalid memory address or nil pointer dereference)%!v(PANIC=Format method: runtime error: invalid memory address or nil pointer dereference)

Awesome stuff Ruben! I'm merging so we can continue from here. Thanks!


Pull request for python-pyside

For travis-ci/travis-ci#4452.
Ran tests and found no setuid bits.
See https://travis-ci.org/travis-ci/apt-whitelist-checker/builds/72066057

Sorry, but this test will have to be re-run. Will open a new one later.


[WIP] Started library implementation

As advised by you, I am creating a PR for #12 so that the you can review my code better. It is still unfinished, but I have made the changes you suggested.

@shonfeder I think I have implemented all the steps in #12. I apologise for my unordered commits, I am new to open source hence didn't understand all the git commands at the time. The PR works fine on my local setup when I run
dune test

So, I am not sure what is wrong with my work.

Thank you @shonfeder :)


Cls support for websockets

Problem statement

Summary: At the moment, there seems to be no way to get cls working for websocket communication. It would be great to have cls support for both, http and ws, within one application.
Background: I have a tenant interceptor for my websocket gateway that reads the tenant from the namespace of the websocket object. This information shall be used in the interceptor to do cls.set('tenant', tenant). This information will then be used by the custom logger to add tenant information for each log statement created in websocket context.

Solution
I'm not familiar with this repository, neither with cls nor the different NestJs communication protocols. Therefore, at the moment, I can't provide an ideas. From the perspective of a consumer of nestjs-cls, it would be great to extend the existing functionality in such a way, that cls for websockt context can be added by setting a property or by an additional import in the module that provides the websocket gateway.
Minimum reproduction

https://github.com/NilsLeger/typescript-starter
Details are described in the README file

Okay, so I've found the issue.
The problem is that Websocket Gateways don't respect globally bound enhancers (neither with app.useGlobal<Enhancer> nor with the APP_<ENHACER> provider (which is what nestjs-cls uses with the mount: true option)), which kind of makes sense now, since they're bound to the Express or Fastify apps.
To make CLS also work with Websockets, all you have to do is explicitly bind the Cls<Enhancer> to the Websocket Gateway like so:
@WebSocketGateway()
@UseInterceptors(/* interceptor */ ClsInterceptor, WsTenantInterceptor)
export class WebsocketGateway {
   // ...
}

or
@WebSocketGateway()
@UseGuards(/* guard */ ClsGuard)
@UseInterceptors(WsTenantInterceptor)
export class WebsocketGateway {
   // ...
}

I will update the README to reflect that, but Websockets are currently supported :)

@Papooch The docs further don't address that even if you set everything up the way you've described, handleConnection is not covered by Interceptors, Guards, or Middleware.
It's not a NestJS CLS problem, it's just something of a shortcoming in Nest:

https://stackoverflow.com/questions/66749867/nestjs-wss-handleconnectionsocket-socket-handshake-is-undefined-and-cannot-acc
https://github.com/nestjs/nest/issues/9231
https://github.com/nestjs/nest/issues/1254

It does appear this might be something they support in the future https://github.com/nestjs/nest/issues/882
A simple solution I've found for now is to inject the ClsService into my gateway, then do:
  async handleConnection(socket: Socket, incoming: IncomingMessage) {
    // handleConnection is not covered by NestJS Middleware, Guards, or Interceptors
    this.clsService.run(async () => {
       // Do stuff here
       const authToken = getAuthTokenFromIncomingMessage(incoming);
       this.clsService.set('request.authToken', authToken);
    }
 }

The rest of the incoming messages are covered by the interceptor as you mentioned. It may be obvious, but of course the CLS values won't persist between web socket messages since there's not any asynchronous context left to contain them. So, I've been storing the values I care about in a map I added onto the socket. Then, in the interceptor, I grab them off the socket and copy them into the real cls. My app has a mixture of HTTP and WS, and this lets my app only have to check one place, the cls, for these values which I think keeps it cleaner.

@peisenmann Thanks for the writeup, this might definitely help someone implementing the same!
As for the need to wrap the call to handleConnection in CLS, that's something that will be addressed in #19 in the future.

maybe it will help someone, I did it this way, in appmo AppModule I imported it globally
@Module({
	imports: [
		ClsModule.forRoot({
			global: true,
			guard: {
				mount: true,
				generateId: true,
				idGenerator: () => uuidv4(),
				setup: clsSetupHelper
			},
			interceptor: {
				mount: true,
				generateId: true,
				idGenerator: () => uuidv4(),
				setup: clsSetupHelper
			},
			middleware: {
				mount: true,
				generateId: true,
				useEnterWith: true,
				idGenerator: (req: Request) => req.headers['X-Request-Id'] ?? uuidv4(),
				setup: clsSetupHelper
			}
		})
  ]
})
export class AppModule implements NestModule {
	configure(consumer: MiddlewareConsumer): any {
		consumer.apply(ClsMiddleware).forRoutes('*');
	}
}

clsSetupHelper
export const clsSetupHelper = (cls: ClsService, context: ExecutionContext) => {
	try {
		let xUser: Record<string, any> | null = null;

		if (typeof context.getType !== 'function') {
			xUser = context.headers['x-user'] ?? null;
		} else if (context.getType() === 'http') {
			const request = context.switchToHttp().getRequest();
			xUser = request.headers['x-user'] ?? null;
		} else if (context.getType() === 'ws') {
			const request = context.switchToWs().getClient();
			xUser = request.handshake.headers['x-user'] ?? null;
		}

		cls.set('xUser', xUser);
	} catch (e) {
		console.error('clsSetupHelper ==>', e);
	}
};

works everywhere except handleConnection

Facing trouble implementing this. I have a NestJS project that uses websockets. I want to use cls inside the handleConnection method. I am expecting a websocket connection level context to be created, and not message level.
I tried using:
ClsModule.forRoot({
  global: true,
  middleware: { mount: true },
  interceptor: { mount: true },
}),

@UseInterceptors(ClsInterceptor)
@WebSocketGateway({
...

@UseCls()
async handleConnection(clientWs: WebSocket) {
  this.cls.run(() => {
  // code that tries to use CLS

I'm still getting the error:

No CLS context available, please make sure that a ClsMiddleware/Guard/Interceptor has set up the context, or wrap any calls that depend on CLS with "ClsService#run"

@arko7n Are you getting that error inside of the run callback? Where/when exactly is the error thrown?
It's hard to understand what the problem is based on just these code snippets. Please create a new issue and add as many details as possible, so I can try to assist you.


Replace deprecated getLocationSrv

What would you like to be added:
locationService should be added to the available Elements in the code blocks and getLocationSrv should be removed
Why is this needed:
getLocationSrv is deprecated.

Is this related to the examples on the website or does locationService not work?
https://gapit-htmlgraphics-panel.gapit.io/docs/references/#locationservice

Is this related to the examples on the website or does locationService not work? https://gapit-htmlgraphics-panel.gapit.io/docs/references/#locationservice

Yes, it works, but why is the old method still in the options? Why is it not replaced? So it does not have to be from the htmlGraphics and there is not deprecated method

I don't want the old panels using getLocationSrv to stop working. I might remove getLocationSrv once Grafana removes it. It's currently still supported on Grafana's latest release https://github.com/grafana/grafana/blob/401265522e584e4e71a1d92d5af311564b1ec33e/packages/grafana-runtime/src/services/LocationSrv.ts#L70

Ah okay. Yes, I understand.


remove the useless space in the schema.sql

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #594 (7c4c26a) into master (eb03b38) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #594      +/-   ##
============================================
+ Coverage     37.93%   38.00%   +0.07%
- Complexity      597      601       +4
============================================
  Files           198      198
  Lines          4669     4670       +1
  Branches        497      497
============================================
+ Hits           1771     1775       +4
+ Misses         2754     2750       -4
- Partials        144      145       +1

Impacted Files
Coverage Δ
Complexity Δ

.../java/org/dromara/soul/common/utils/DateUtils.java
90.00% <0.00%> (+1.11%)
7.00% <0.00%> (+1.00%)

.../soul/admin/service/impl/UpstreamCheckService.java
22.64% <0.00%> (+1.88%)
4.00% <0.00%> (+1.00%)

...mara/soul/admin/config/ZookeeperConfiguration.java
100.00% <0.00%> (+100.00%)
2.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb03b38...7c4c26a. Read the comment docs.


Remove invalid isDisabled key

Is the isDisabled serving any purpose? It's detected as invalid on GitHub.com and throwing errors (see github/linguist#3924 for further details).

Looks like it's safe to remove. Thanks!


FIX : Learn Kubernetes Basics button difficult to read when hovered

fixes #43396
I have made necessary hovering and transition changes to the button.

On hover:

@thisisharrsh kindly review my PR.

Okay, I'll fix this.

Deploy preview: https://deploy-preview-43422--kubernetes-io-main-staging.netlify.app/

@thisisharrsh fixed necessary changes. Please review it.

Can I send a new non conflicting PR?

Ya, surely you can but if you will do that then you will still face git related problems later on. So, it's better to learn git properly in this PR. Don't worry about its merge, just focus on your learning.

@thisisharrsh fixed necessary changes. Please review it.

Hi @Sakhi29, This PR has fixed the issue that we are addressing, but there are a lot of new issues that originated from the commits we have made.
As @aj11anuj  has suggested that this is full of unnecessary commits, it will be better if we could close this PR and try to fix the issue on a new one.

Okay, then I will close this PR and send a new one, if it is okay with you.

Okay, then I will close this PR and send a new one, if it is okay with you.

Yes, you can.


HDX-9713 Adding v1 version label to URLs

This PR adds a v1 version label to URLs whilst maintaining backwards compatibility with the unlabelled version. The legacy URLs are preserved but no longer appear in documentation (as a side effect the 3W endpoint is removed from the documentation leaving only /3w).
Also fixed a DepreciationWarnings from Fastapi and Pydantic and node.js depreciation warnings for one action
A naive search and replace of /api/ with /api/v1/ is not appropriate here since /api/ appears in one of the Alembic files and also in references to HDX.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.17%. Comparing base (fa132ee) to head (68abdf5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   95.13%   95.17%   +0.03%
==========================================
  Files         108      108
  Lines        2550     2569      +19
==========================================
+ Hits         2426     2445      +19
  Misses        124      124

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


0.3.0 Epic

[x] Implement a serializer for the post AT to a serialized format
[x] Package for distribution a DOM renderer (https://github.com/bustlelabs/mobiledoc-dom-renderer)
[x] Package for distribution a HTML renderer (https://github.com/bustlelabs/mobiledoc-html-renderer)
[x] Handle section modification, removal, addition en-masse (edits across sections)
[x] Don't create a section element during post render for editor
[x] Pass serialized payload to the editor for use (https://github.com/bustlelabs/content-kit-editor/commit/06def745078c52e79744531a4aee266b4cd13229)
[x] An inserted <span> or other ignorable element in the editor's HTML needs to be ignored properly so that you can delete to join two sections
[x] write serializer tests
[x] write acceptance tests against serializer output
[x] parse the serialized format into the AT for the editor ( https://github.com/bustlelabs/content-kit-compiler/commit/0db07a6058e9af19657808b5f2d6fb9f8dd047aa )
[x] Editor#destroy tears down listeners, cleans up after itself
[x] Assert correct command and UI behaviors of markup commands: (https://github.com/bustlelabs/content-kit-editor/pull/17)

[x] bold
[x] italic
[x] link

[ ] Assert correct command an UI behaviors for sections (these are all new section types)

[x] image (port image implementation to a card)
[x] embed (including embeds that hit the embed API for HTML) (port embed implementation to a card)
[ ] display of available cards in ContentKit punting this to the UI-focused work in 0.4.0
[x] quote
[x] headline
[x] subheadline

[x] remove remaining memory-leaked event listeners (Tooltip adds a mouseover listener, e.g., and there are a few others) (https://github.com/bustlelabs/content-kit-editor/pull/18)
[x] DOM renderer should know how to render a card
[x] HTML renderer should know how to render a card (should use a new bag of hooks called html)

Stretch

[ ] two-pass parse that avoids the previous-section and isGenerated nonsense
[x] make post AT nodes a linked list
[x] parse/rerender markers instead of sections
[x] serializer should serialize null values as a blank text node
[ ] IE 10 tests pass and demo works (blocked on lack of input event on contenteditable)

Yay, going to ship a 0.3.0 after @bantic lands a patch improving deletion/enter support.

Nah, going to wait until https://github.com/bustlelabs/content-kit-editor/pull/53 lands

0.3.0 published!


How to add some characters to prompt

I love the theme :) super simple, just what I wanted.
I was trying to mess with it a little to add an arrow and a dollar sign(I know, making it less simple which I just said I wanted ¯_(ツ)_/¯)
Basically I want it to be → my-dir $ some-command instead of my-dir some-command
The problem is when I add characters to the prompt the alignment gets all messed up. Any tips on how to do this from a fork of your repo?
Thanks!

I am really happy to hear that like my theme. :)
To customize the prompt edit the PROMPT variable in alien-minimal.zsh file and also in modules/async.zsh. This should do the job.
You can also use some config variables - for which I have some plans in mind. :)

Awesome! Thanks. The variables work like a charm.


Update the location of the pod files

Checklist

[x] documentation is added or updated

Description of change

Since 99d63d4 ("Move manpages to man[1357] structure.", 2016-10-26), the location
of the pod files has changed.

Do you agree that this is a trivial change?  Or can you sign our CLA?

I assumed that this was a trivial change, that's why I didn't include the CLA line in the PR.

Shouldn't this go to 1.1.0 as well?

Shouldn't this go to 1.1.0 as well?

Nope...1.1.0 still has the old locations.

Yeah, I realised that seconds after commenting...  d'oh

@bbolli Thanks; we need you to explicitly say that it's trivial so that we have a record of the author saying it.  Yes, it's too bad we have to do that.
But more importantly, thanks for helping improve openssl.  This was pushed as commit 663ece0.


Take advantage of csi_secret in CSI 1.0

CSI 1.0 decorates sensitive fields with csi_secret. Let's take advantage of this feature to programmatically ensure no sensitive fields are ever logged by this side car container.

PR open against external-provisioner: https://github.com/kubernetes-csi/external-provisioner/pull/171
Needs to be reviewed there and then could be copied into driver-registrar.


fix: defi withdraw status wrong copy

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #3474   👈

This comment was auto-generated by Graphite.


adding imagemin

what are your thoughts on adding options for optimization with something like imagemin?  similar to https://github.com/tcoopman/image-webpack-loader

I think you should separate those concerns and optimize the images before using them via this plugin.


ignore missing blob file for iterator

add key-only iter option
reproduce missing blob file when iterating
fix an issue about sample which affecting reproducing

PTAL again @yiwu-arbug @tabokie

PTAL again @yiwu-arbug @tabokie

Codecov Report

Merging #18 into master will increase coverage by 0.5%.
The diff coverage is 96.29%.

@@            Coverage Diff            @@
##           master      #18     +/-   ##
=========================================
+ Coverage   82.45%   82.96%   +0.5%
=========================================
  Files          42       42
  Lines        2377     2389     +12
=========================================
+ Hits         1960     1982     +22
+ Misses        417      407     -10


Matrix coefficient differences relative to ACES

Currently, MaterialX has the following, in libraries/stdlib/genglsl/lib/mx_transform_color.glsl:
#define M_AP1_TO_REC709 mat3(1.705079555511475, -0.1297005265951157, -0.02416634373366833, -0.6242334842681885, 1.138468623161316, -0.1246141716837883, -0.0808461606502533, -0.008768022060394287, 1.148780584335327)
It appears that this may have been calculated using the CAT02 chromatic adaptation transform rather than the Bradford transform used by ACES.  In other words, the above matrix will result in a slight difference between MaterialX's internal default color management system and what an OCIO ACES config would produce.  The coefficients that would match ACES are:
1.705050992658, -0.130256417507, -0.024003356805,
-0.621792120657,  1.140804736575, -0.128968976065,
-0.083258872001, -0.010548319068,  1.15297233287

Good catch, @doug-walker, and thanks for the detailed analysis!  Feel free to write up a pull request if you have the bandwidth; otherwise we'll address this on our side.

Thanks for reporting this, @doug-walker, and this issue has been addressed in #1163.


fix: fix error in merge_cubes if bands are unsortable

Closes #102

@LukeWeidenwalker I can confirm that this fixes this particular bug.
The overlap resolver is still not working, the error returned is:
Exception: Provided cubes have incompatible types. cube1: <class 'openeo_pg_parser_networkx.pg_schema.ResultReference'>, cube2: <class 'xarray.core.dataarray.DataArray'>

@LukeWeidenwalker I can confirm that this fixes this particular bug. The overlap resolver is still not working, the error returned is:
Exception: Provided cubes have incompatible types. cube1: <class 'openeo_pg_parser_networkx.pg_schema.ResultReference'>, cube2: <class 'xarray.core.dataarray.DataArray'>

Other issue fixed too in #109

@LukeWeidenwalker I'm still not able to use the overlap_resolver, code to test it with the latest main branch:
with overlap resolver:
from openeo.local import LocalConnection
local_conn = LocalConnection(['./openeo-localprocessing-data'])
cube = local_conn.load_collection('openeo-localprocessing-data/sample_netcdf/S2_L2A_sample.nc')
b04 = cube.band("B04")
b08 = cube.band("B08")
ndvi = (b08-b04)/(b08+b04)
ndvi = ndvi.add_dimension(name='bands',label='NDVI',type='bands')
merged = ndvi.merge_cubes(ndvi, overlap_resolver='add')
merged.execute()

error:
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
File ~\Miniconda3\envs\sap\lib\site-packages\openeo_pg_parser_networkx\graph.py:357, in OpenEOProcessGraph._map_node_to_callable.<locals>.node_callable(parent_callables, named_parameters, *args, **kwargs)
    355 try:
    356     # If this node has already been computed once, just grab that result from the results_cache instead of recomputing it.
--> 357     return results_cache.__getitem__(node)
    358 except KeyError:

KeyError: 'root-1aff0b40-63c7-46f2-aeb6-73e7b6ce37a7'

During handling of the above exception, another exception occurred:

Exception                                 Traceback (most recent call last)
Input In [12], in <cell line: 9>()
      7 ndvi = ndvi.add_dimension(name='bands',label='NDVI',type='bands')
      8 merged = ndvi.merge_cubes(ndvi, overlap_resolver='add')
----> 9 merged.execute()

File ~\Miniconda3\envs\sap\lib\site-packages\openeo\rest\datacube.py:2013, in DataCube.execute(self)
   2011 def execute(self) -> dict:
   2012     """Executes the process graph of the imagery. """
-> 2013     return self._connection.execute(self.flat_graph())

File ~\Miniconda3\envs\sap\lib\site-packages\openeo\local\connection.py:96, in LocalConnection.execute(self, process_graph)
     89 """
     90 Execute locally the process graph and return the result as an xarray.DataArray.
     91
     92 :param process_graph: (flat) dict representing a process graph, or process graph as raw JSON string,
     93 :return: a datacube containing the requested data
     94 """
     95 process_graph = as_flat_graph(process_graph)
---> 96 return OpenEOProcessGraph(process_graph).to_callable(PROCESS_REGISTRY)()

File ~\Miniconda3\envs\sap\lib\site-packages\openeo_pg_parser_networkx\graph.py:370, in OpenEOProcessGraph._map_node_to_callable.<locals>.node_callable(parent_callables, named_parameters, *args, **kwargs)
    362             arg_sub.access_func(
    363                 new_value=results_cache[source_node], set_bool=True
    364             )
    366         kwargs[arg_sub.arg_name] = self.G.nodes(data=True)[node][
    367             "resolved_kwargs"
    368         ].__getitem__(arg_sub.arg_name)
--> 370 result = prebaked_process_impl(
    371     *args, named_parameters=named_parameters, **kwargs
    372 )
    374 results_cache[node] = result
    376 return result

File ~\Miniconda3\envs\sap\lib\site-packages\openeo_processes_dask\process_implementations\core.py:82, in process.<locals>.wrapper(positional_parameters, named_parameters, *args, **kwargs)
     79 logger.warning(f"kwargs: {pretty_args}")
     80 logger.warning("-" * 80)
---> 82 return f(*resolved_args, **resolved_kwargs)

File ~\Miniconda3\envs\sap\lib\site-packages\openeo_processes_dask\process_implementations\cubes\merge.py:31, in merge_cubes(cube1, cube2, overlap_resolver, context)
     29     context = {}
     30 if not isinstance(cube1, type(cube2)):
---> 31     raise Exception(
     32         f"Provided cubes have incompatible types. cube1: {type(cube1)}, cube2: {type(cube2)}"
     33     )
     35 # Key: dimension name
     36 # Value: (labels in cube1 not in cube2, labels in cube2 not in cube1)
     37 overlap_per_shared_dim = {
     38     dim: Overlap(
     39         only_in_cube1=np.setdiff1d(cube1[dim].data, cube2[dim].data),
   (...)
     43     for dim in set(cube1.dims).intersection(set(cube2.dims))
     44 }

Exception: Provided cubes have incompatible types. cube1: <class 'openeo_pg_parser_networkx.pg_schema.ResultReference'>, cube2: <class 'xarray.core.dataarray.DataArray'>

without overlap resolver should also work, but again same error.


count 0 bot spawning in localhost

http://i.imgur.com/PPhES1j.png
and there is a syntax mistake in server.js line 19 "}" remove it

17:if (!!process.env.SLITHER_PER_PROXY) {
18:  perProxy = parseInt(process.env.SLITHER_PER_PROXY)
19: } <-- end of if . :)

I thign u need to set port in feeder.js to same like server port. ;p

it's the same port 3000 everywhere

and they don't spawn

Hmm.. I in user script same ?

yes
if (vps == 1) {
var socket = io.connect('ws://<IP_ADDRESS>:3333');
$("#mode").text('VPS');
} else {
var socket = io.connect('ws://<IP_ADDRESS>:3000');
$("#mode").text('LOCAL');
}
and i'm in localhost mode

emm... hmm..

i tried your old versions they works but the updated not ^^

I update now try now.

http://i.imgur.com/fXLZIlv.png
error

still no spawning

lol, u can't delete on " } " ? now is fixed.

i know but still no spawning

same as first screenshot

status: 0

lol, idk what u doing bad .. lol , for me everything is working good.

:/

Skype share screen ?

connect you

you can try on my vps i cloned your git

im having same issue it says status 0

:/

:/

maybe hes trolling us

no he tried to fix on my pc but not work

can we try fix it

does it work in vps

Guys i am gonna check new update later and if i make it run i will help you

ok

@Wartoz @kurama129 @yario-o
#45

Where is the problem? For me script working good.

@l3mpik for you it work because in your vps you use old bot.js(before merge with yario-o)... in the github is the merged bot.js

fixedd