Build fails when config includes redocusaurus and docusaurus-theme-search-typesense

Hi
I'm getting a build error when I compile with 2 plugins in the same config

redocusaurus 1.3.0
docusaurus-theme-search-typesense 0.7-0.0

I also wanted to note that I only run into this error when running npm run build if i do npm start everything works fine with both plugins available in the docusaurus config.
I've tried a mix of the following

rm -rf node_modules package-lock.json and reinstall
downgrading docusaurus to v2.0.1
upgrading to docusaurus v2.1.0

I've noticed that if I were to comment out the redocusaurus config in presets of docusaurus.config.js OR themes:['docusaurus-theme-search-typesense'] the build happens smoothly
docusaurus.config.js
  presets: [
    [
      '@docusaurus/preset-classic',
      /** @type {import('@docusaurus/preset-classic').Options} */
      ({
        docs: {
          sidebarPath: require.resolve('./sidebars.js'),
        },
        blog: false,
        theme: {
          customCss: require.resolve('./src/css/custom.css'),
        },
      }),
    ],
    [
      'redocusaurus',
      {
        specs: [
          {
            spec: require.resolve('./static/api_spec/open-api-spec.yml'),
            route: '/api',
          },
        ],
        theme: {
          primaryColor: '#2e8555',
          primaryColorDark: '#25c2a0'
        },
      },
    ],
  ],
  themes: ['docusaurus-theme-search-typesense'],

package.json
{
  "name": "json-api-docs",
  "version": "0.0.0",
  "private": true,
  "scripts": {
    "docusaurus": "docusaurus",
    "start": "docusaurus start",
    "build": "docusaurus build",
    "swizzle": "docusaurus swizzle",
    "deploy": "docusaurus deploy",
    "clear": "docusaurus clear",
    "serve": "docusaurus serve",
    "write-translations": "docusaurus write-translations",
    "write-heading-ids": "docusaurus write-heading-ids",
    "typecheck": "tsc"
  },
  "dependencies": {
    "@docusaurus/core": "^2.1.0",
    "@docusaurus/preset-classic": "^2.1.0",
    "@mdx-js/react": "^1.6.22",
    "clsx": "^1.2.1",
    "docusaurus-theme-search-typesense": "^0.7.0-0",
    "prism-react-renderer": "^1.3.5",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "redocusaurus": "^1.3.0"
  },
  "devDependencies": {
    "@docusaurus/module-type-aliases": "^2.1.0",
    "@tsconfig/docusaurus": "^1.0.5",
    "typescript": "^4.7.4"
  },
  "browserslist": {
    "production": [
      ">0.5%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "engines": {
    "node": ">=16.14"
  }
}

error message
[INFO] [en] Creating an optimized production build...
✔ Client
✖ Server
  Compiled with some errors in 15.89s

main:55529
                {}.DEBUG = namespaces;
                  ^

SyntaxError: Unexpected token '.'
[ERROR] Unable to build website for locale en.
[ERROR] Error: Failed to compile with errors.
    at .../json-api-docs/node_modules/@docusaurus/core/lib/webpack/utils.js:180:24
    at .../json-api-docs/node_modules/webpack/lib/MultiCompiler.js:554:14
    at processQueueWorker (.../json-api-docs/node_modules/webpack/lib/MultiCompiler.js:491:6)
    at processTicksAndRejections (node:internal/process/task_queues:78:11)
[INFO] Docusaurus version: 2.1.0
Node version: v16.14.2

I have the exact same issue. It would be great to be able to use both search and redocusaurus at the same time, but honestly I have no idea where to even start debugging it.

I made a minimal example to reproduce the bug, I hope it will help whoever can debug this:
https://github.com/balazsbotond/redocusaurus-typesense-bug-repro

Please note that @GalexyN also reported the same issue here: https://github.com/typesense/docusaurus-theme-search-typesense/issues/23
I've found a closed issue about the same problem in the debug.js project.
A PR which fixed this issue with minimal changes was rejected with the justification that "it wasn't the maintainers' job to fix other people's messes". Another PR which may fix this issue has been open for more than four years.
The original issue offers several possible workarounds by defining webpack plugins but I'm not sure these can be added to a Docusaurus project.
One of my coworkers suggested simply commenting out the offending line in the node_modules folder (node_modules/debug/src/node.js):
function save(namespaces) {
	const env = process.env;
	if (namespaces) {
		// env.DEBUG = namespaces;
	} else {
		// If you set a process.env field to null or undefined, it gets cast to the
		// string 'null' or 'undefined'. Just delete instead.
		delete env.DEBUG;
	}
}

Which, while being an incredibly hacky solution, is the one we currently use as part of our CI pipeline by running the following sed command after installing npm packages:
sed -i '/process.env.DEBUG = namespaces;/c\// process.env.DEBUG = namespaces;' ./node_modules/debug/src/node.js

Far from ideal, I know, but I hope it helps someone until the root cause is fixed.

defining webpack plugins but I'm not sure these can be added to a Docusaurus project.

This is very easy to do. We already do it here - https://github.com/rohit-gohri/redocusaurus/blob/main/packages/docusaurus-theme-redoc/src/index.ts#L20-L23
If some one can open a PR, I'll be happy to review and release it. Thanks @balazsbotond for the research on the issue!

Probably this is the culprit - https://github.com/rohit-gohri/redocusaurus/blob/45a314be01a4db4d8196be519d52ab61cf15b26f/packages/docusaurus-theme-redoc/src/index.ts#L29

I solved the problem by changing this in docusaurus.config.js
plugins: [
    ...
    async function customPlugin(context, opts) {
      return {
        name: 'custom-plugin',
        configureWebpack(config, isServer, utils, content) {
          // Modify internal webpack config. If returned value is an Object, it
          // will be merged into the final config using webpack-merge;
          // If the returned value is a function, it will receive the config as the 1st argument and an isServer flag as the 2nd argument.
          return {
            plugins: [
              new webpack.DefinePlugin({
                // IMPORTANT: To fix debug library‘s bug
                // {}.DEBUG = namespaces; // SyntaxError: Unexpected token '.'
                'process.env.DEBUG': 'process.env.DEBUG',
              })
            ]
          }
        },
      }
    }
  ],

@Sakura-pgh you made my day ⭐

I solved the problem by changing this in docusaurus.config.js
plugins: [
    ...
    async function customPlugin(context, opts) {
      return {
        name: 'custom-plugin',
        configureWebpack(config, isServer, utils, content) {
          // Modify internal webpack config. If returned value is an Object, it
          // will be merged into the final config using webpack-merge;
          // If the returned value is a function, it will receive the config as the 1st argument and an isServer flag as the 2nd argument.
          return {
            plugins: [
              new webpack.DefinePlugin({
                // IMPORTANT: To fix debug library‘s bug
                // {}.DEBUG = namespaces; // SyntaxError: Unexpected token '.'
                'process.env.DEBUG': 'process.env.DEBUG',
              })
            ]
          }
        },
      }
    }
  ],

@Sakura-pgh Thank you SO MUCH. You've helped me tremendously in 2024. I was already debugging this issue for 2 days before stumbling on your comment.


Updated compatibility matrix to include latest OpenSearch versions

Description
Updated compatibility matrix to include latest OpenSearch versions
Issues Resolved
Related to #759
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

We're not actually testing 2.14, add that?
https://github.com/opensearch-project/opensearch-py/blob/main/.github/workflows/integration.yml#L12

We're not actually testing 2.14, add that?
https://github.com/opensearch-project/opensearch-py/blob/main/.github/workflows/integration.yml#L12

@dblock, OpenSearch versions 2.12, 2.13, 2.14 are now included in integration tests see here.
Done in  PR #631

It's really odd that codecov shows a 1% difference.


This package gets vulnerable warning in nuget

Hi @sparkeh9
There is a problem with your great package. I got this warning from nuget today. Could you please check it and release new version if needed?

This package has at least one vulnerability with moderate severity. It may lead to specific problems in your project. Try updating the package version.

See https://github.com/advisories/GHSA-w393-h95m-f879


Report about Kong in the SLA reporting dashboard

Atlas recently added a new dashboard to report about our SLAs in this PR https://github.com/giantswarm/dashboards/pull/433/files.
We have SLAs on nginx and those should be added to this dashboard.
What we would like is for you to create a slo using sloth the expose the availability of the kong ingress controller that is optionally deployed in the clusters.
Here is an example of an slo alert https://github.com/giantswarm/sloth-rules/blob/5a0ee4a6c65dfdd849d197cd3b873d8fa342dec4/areas/kaas/teams/phoenix/apiserver/slos/availability.yaml
Feel free to ask @giantswarm/team-atlas for help to create the SLO rule and alert and to integrate the data in the dashboard

@weatherhog when do you expect your team to work on this?

Work for this issue will be done in https://github.com/giantswarm/roadmap/issues/3229#issuecomment-2044639452

@QuentinBisson I'm closing this because our solution is generic and it's only a matter of adding another configuration for another ingressClass in the ingress-sla-app
FTR more details about the solution can be found here https://github.com/giantswarm/roadmap/issues/3229#issuecomment-2066932261

Did you add the ingressClass in the ingress-sla-app?


Jetson Nano fw-env.config

I'm trying to get RAUC to work on the Jetson Nano, but only U-boot parameters for Jetson-TX1 dev kit is provided for the tegra210. How can i find the correct parameters for the Jetson Nano?

Doesn't look like the Nano supports saving the environment block with the stock U-Boot configuration. From the include/configs/p3450-porg.h file in the U-Boot source:
/* Environment s/b at end of SPI, fix it later */
#define CONFIG_ENV_IS_NOWHERE

I found this possible solution that i will try and recreate.

That solution will have RAUC resetting the u-boot environment every time there is an update. How can i make RAUC work with my system then, any ideas?

I'm not sure how RAUC works, but there are a few options. If you opt for the file in /boot approach that was mentioned in the thread you linked to, just make sure RAUC saves a copy of that file before updating the filesystem, then restores it to the known location before rebooting.  If it has to update U-Boot environment variables as part of the update process, some additional tweaks might be needed to ensure the file is in the expected location when it does so - or patch the U-Boot env tools to take an extra argument (or use an environment variable) to locate the file.
Another option would be to carve out space either on the on-board SPI flash or on the SDcard to hold the environment block.  For the SPI flash, you'd have to do some digging into how NVIDIA's boot code uses the flash so U-Boot doesn't overwrite something important, and you'd have to make sure that the flash device is accessible from Linux -- I'm not sure if the device tree already has an entry for it or not, but if not it should be relatively easy to add. Reserving space on the SDcard might be easier - you could even add a partition for it to ensure that it doesn't conflict with other uses.  Since U-Boot itself is loaded from the SDcard at boot time, that might make the most sense, but it depends on your use case - if you need all or part of the U-Boot environment to be retained even when swapping in a different SDcard, the SPI flash would be the best place.
My understanding is that production Nano modules have an on-board eMMC, and it sounds like later dev kits will be based on that module - so they may not include the SPI flash, since it wouldn't be necessary.  Bear that in mind if you need to support this functionality on both the current dev kits and production modules.

I will attempt to make a new partition for the env file like you mentioned. It seems like it is the most future friendly and easiest way to solve this issue.
As i can see from the other issue about TX partitioning, i made a bbappend file with
FILESEXTRAPATHS_prepend_tegra210 := "${THISDIR}/files:"
SRC_URI_prepend_tegra210 += " \
    file://flash_l4t_t210_custom.xml \
"

do_preconfigure_prepend_tegra210() {
    mkdir -p ${S}/bootloader/${NVIDIA_BOARD}/cfg/
    cp ${WORKDIR}/flash_l4t_t210_custom.xml ${S}/bootloader/${NVIDIA_BOARD}/cfg/
}

And put the additional partitions into the custom xml as well as edit the JetsonNano machine conf SDCARD_LAYOUT_TEMPLATE to point to the custom xml. As i understand with the Jetson Nano, I also made a bbappend to give a custom sdcard-layout.in:
FILESEXTRAPATHS_prepend := "${THISDIR}/files:"

SRC_URI = "file://sdcard-layout-custom.in"

Where i also add in the partitions i need that matches the custom xml file contents.

Right, if you go this route, you'll need to format the added partition with an ext4 filesystem and put an empty uboot.env file in it (although U-Boot may be able to create it if it's not present, I'm not sure).  For testing, you could do this manually.  Making it part of the build is a bit more complicated; it would mean creating/formatting a file with the ext4 filesystem in it and putting the name of that file in the XML and sdcard-layout files - use a real name.... then you'd add a tegraflash_custom_pre() function in your image recipe to copy that ext4 container file into the directory where the rest of the tegraflash content goes.
The config file with the uboot.env 0x0000 0x2000 should still go in ${sysconfdir}/fw_env.config in your rootfs.
The other approach would be to use CONFIG_ENV_IS_IN_MMC in U-Boot, so you don't have to format the partition.  The tricky part there is figuring out the correct offset to use, since you wouldn't be able to just reference the partition by number.

I see. I'm not really sure how i go about

creating/formatting a file with the ext4 filesystem in it

and

copy that ext4 container file into the directory where the rest of the tegraflash content goes.

but it's doable.
If I do go with the  CONFIG_ENV_IS_IN_MMC approach, do you know how i could figure out the offset? I found this:
#define CONFIG_ENV_SECT_SIZE    (8 * 1024)
#define CONFIG_ENV_SIZE         CONFIG_ENV_SECT_SIZE

#define CONFIG_ENV_IS_IN_MMC	1
#define CONFIG_ENV_OFFSET	(768 * 1024)

In a meta-freescale patch, you think this offset could be the case for me too? And if so, what would i put into the fw_env.config file?

I looked into this, and it was pretty simple to add the environment block to the SPI flash, so I went ahead and updated u-boot-tegra and the u-boot recipes in master to do that.
If you'd prefer to use CONFIG_ENV_IS_IN_MMC, you would compute CONFIG_ENV_OFFSET by multiplying the start sector for the partition you have added by the sector size (usually 512).  sgdisk --print /dev/XXX should provide you with both of those numbers once you have formatted the card.  Then in your fw_env.config file, use /dev/mmcblk0pN as the device (where N is the partition number), 0 as the offset, and 0x2000 as the size.

The SPI flash is working like a charm. But now that I am trying to make an mmc partition with the environment, i can't seem to specify the file for the partition correctly. No matter what i do, bitbaking my image fails with dd: failed to open 'uboot.env': No such file or directory when doing do_image_tegraflash.
Where and how do i specify the file i need in the partition via the meta-tegra layer?

You should just leave the partition empty - U-Boot will initialize it when you do your first saveenv.  So just use /dev/zero in place of the uboot.env file name you have in your modified partition-layout.in.

It appears when i write 14,ENV,196608,/dev/zero in the sdcard-layout.in and add
        <partition name="ENV" id="25" type="data">
            <allocation_policy> sequential </allocation_policy>
            <filesystem_type> basic </filesystem_type>
            <size> 196608 </size>
            <file_system_attribute> 0 </file_system_attribute>
            <allocation_attribute> 0x8 </allocation_attribute>
            <percent_reserved> 0 </percent_reserved>
            <filename> uboot.env </filename>
        </partition>

to my custom flash_l4t_t210_custom.xml file that the machine conf is pointing to, the last part of the bitbake do_tegraflash will take every single byte of space left on my disk (which is 800gb). It simply just goes on forever untill there is no more room left on the disk. The file /build/tmp/work/jetson_nano-poky-linux/image/1.0-r0/deploy-image-complete/image_*.sdcard were 327gb when i noticed and stopped the build. What did i do wrong here?

Nothing... that's my fault.  I thought I had tested that approach to having a null-filled partition, but I must have got it wrong - the dd command that copies the partition contents is not size-limited. I'll fix it so it works if you specify /dev/zero, or just use 14,ENV,196608, (with no file name at all), it does the right thing.

But if I were to actually specify a file for a new partition, how/where would i specify it in the meta-tegra layer?

In your image recipe, you would add a function called tegraflash_custom_pre to create or copy the file into the current working directory.  For example,
tegraflash_custom_pre() {
    dd if=/dev/zero of=uboot.env bs=196608 count=1
}

To create a zero-filled file of the size for your ENV partition.  Then you could specify uboot.env in your sdcard-layout.in file.

I've made a patch for the u-boot-tegra environment location:
diff --git a/include/configs/p3450-porg.h b/include/configs/p3450-porg.h
index 7be05f3..427fb60 100644
--- a/include/configs/p3450-porg.h
+++ b/include/configs/p3450-porg.h
@@ -34,12 +34,10 @@
 	func(PXE, pxe, na) \
 	func(DHCP, dhcp, na)

-/* Environment s/b at end of SPI, fix it later */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-/* 64KB at end of SPI flash is used, so position at 128K from end
-   in the padding area */
-#define CONFIG_ENV_OFFSET		(CONFIG_SPI_FLASH_SIZE-131072)
-#define CONFIG_ENV_SECT_SIZE		4096
+/* Env is located in it's own partition */
+#define CONFIG_SYS_MMC_ENV_DEV		1
+#define CONFIG_ENV_IS_IN_MMC
+#define CONFIG_ENV_OFFSET<PHONE_NUMBER>0

 /* SPI */
 #define CONFIG_SF_DEFAULT_MODE		SPI_MODE_0

Where the CONFIG_ENV_OFFSET is calculated from the gdisk -l /dev/mccblk0 output :
Number  Start (sector)    End (sector)  Size       Code  Name
   1           24576        12607487   6.0 GiB     8300  APP
   2            2048            2303   128.0 KiB   8300  TBC
   3            4096            4991   448.0 KiB   8300  RP1
   4            6144            7295   576.0 KiB   8300  EBT
   5            8192            8319   64.0 KiB    8300  WB0
   6           10240           10623   192.0 KiB   8300  BPF
   7           12288           13439   576.0 KiB   8300  TOS
   8           14336           14463   64.0 KiB    8300  EKS
   9           16384           17663   640.0 KiB   8300  LNX
  10           18432           19327   448.0 KiB   8300  DTB
  11           20480           20735   128.0 KiB   8300  RP4
  12           22528           22687   80.0 KiB    8300  BMP
  13        12607488        25190399   6.0 GiB     8300  APP_B
  14        25190400        25190783   192.0 KiB   8300  ENV

Where CONFIG_ENV_OFFSET = (25190400 * 512).
When I saveenv and print it I see the correct environment variables. But when i boot it states that the mmcblk0p1 (the first of the two rootfs):
Failed to mount ext2 filesystem...
** Unrecognized filesystem type **

And when i print the env with fw_print_env I don't see the same environment as in u-boot.
So i was wondering if these issues are because of incorrect CONFIG_ENV_OFFSET or if it could be something else?

If I decide i would want the env partition to be of ext4 format, how would I do this?

Looking at the U-Boot source (common/env_mmc.c), the offset is a 32-bit unsigned integer, so any offset over 4GiB isn't going to work very well.  You might need to rearrange the positions of the partitions so you can squeeze in the ENV partition at a smaller offset.

@madisongh  I am trying to make mender work on the jetson-nano and found your patch 990d978a86195597ac2 "enable env block storage in SPI flash". How do you update the SPI flash? Is it done using the usb connector of the jetson nano dev. kit? Up to now I only flashed SD cards, and didn't find online how to flash the SPI flash.

Yes, via USB.  See the "Preparing a Jetson Development Kit for Use" in the L4T Quick Start Guide for NVIDIA's docs on this, and some basic instructions here on the wiki.

Thanks @madisongh . Is there an advantage of storing the environment in the SPI flash? In the branch https://github.com/Trellis-Logic/meta-mender-community/pull/7 adding support for Mender to the jetson-nano, for which you'll probably get a pull request soon, the u-boot environment gets moved to a partition in the SD-card. Would you merge this, or do you want to keep it in the SPI flash?
Having it in the SD-card makes it easier to replace it with the rest of the software, and also I think when swapping modules you don't want to keep the u-boot environment state anyway, so you would have to replace the content of the SPI flash each time, which is an extra step / error-prone.

Keeping the U-Boot environment in the SPI flash means that it is retained across reboots regardless of what you've got on the SDcard you insert. That might be an advantage in some cases.  For Mender, it would depend on whether you want to retain the Mender settings regardless of the SDcard contents.  Some settings, like the machine ID, might be worth retaining; others, like the boot partition, maybe not.
Production Nano modules have on-board eMMC rather than the SPI flash/SDcard combination, so this choice only affects the development boards.


gpg key used to sign aptly releases has expired

The gpg key used to sign aptly releases appears to have expired:
$ apt-key list | grep -A2 2A19
pub   2048R/2A194991 2014-03-12 [expired: 2016-03-11]
uid                  Andrey Smirnov<EMAIL_ADDRESS>
This causes problems when trying to apt-get update:
W: GPG error: http://repo.aptly.info squeeze Release: The following signatures were invalid: KEYEXPIRED<PHONE_NUMBER> KEYEXPIRED<PHONE_NUMBER> KEYEXPIRED<PHONE_NUMBER>

I'm getting this too, the key has expired
http://keys.gnupg.net/pks/lookup?search=0x2A194991&op=vindex

sorry for the trouble, I'm going to update the key tomorrow morning

New key uploaded: https://groups.google.com/d/msg/aptly-discuss/Ny2NIqDgjHU/ZI6aNBeEAwAJ

Key has expired again!
apt-key list | grep -A2 9C7DE460
pub   2048R/9C7DE460 2016-03-15 [expired: 2018-03-15]
uid                  Andrey Smirnov<EMAIL_ADDRESS>

Getting this addressed, sorry #717


Add "repository" to Cargo.toml

This ensures that users can navigate to the GitHub repository from docs.rs or crates.io

Thanks @notgull!


Revert "Bump ytmusicapi from 1.7.0 to 1.7.3"

Reverts music-assistant/server#1341
@MarvinSchenkel

Oops. I thought dependabot could bump it properly


foscam stream is blank

Home Assistant release with the issue:

0.67.1
Last working Home Assistant release (if known):
0.60 (im not completly sure when the error was introduced)
Operating environment (Hass.io/Docker/Windows/etc.):

hasbian
Component/platform:

foscam
Description of problem:
The forcam camera is not showing the image when you open the the camera, the thumbnail is showing up but the full image is not. And it seems only to be a issue in Safari on both ios and macOS. Chrome and firefox it's working.
Additional information:
screenshot of the problem

still a problem in 0.68.1

Your issue looks the same as my issue which is described in this thread
https://github.com/home-assistant/home-assistant/issues/13995

I still have this problem. It's not working in Safari on both MacOs and iOs, and in subsequent does not work in the webapp. I have just updated to 81.6 and the problem still presist.
Could i please get somekind of response on this one?

I still have the issue as well in Safari on iOS.  The preview image displays but when I click on it for full size, the image is blank.

How do i get this issue unclosed because it's still a problem, and the part of it just being auto closed does not make sense, because im pretty sure that they don't want my to write every day "still do not work".

@joe248 i have created #18252 Can you comment on here.


FAQs:[CDS-94779]:FAQs for 5th April CD

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Purpose
What is the motivation for this PR? What changes does it include? Include as much or as little detail as needed.
If this submission relates to a Jira or GitHub issue, include the issue ID in the title.
Internal Harness contributors - Please edit this summary to include preview links after the preview build finishes.
Merge requirements

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6612f669b16054f6ec603f5f--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6613b5370b596177f22e3dd3--harness-developer.netlify.app


Colorpicker setting still displays with config: false set

I'm trying to move my Color Picker settings to a separate HTML settingsMenu window, but when I list config:false it still displays in the standard Foundry settings... the two Number settings were hidden properly with the same line added.
Example:
        //                                     module        key             options
        new window.Ardittristan.ColorSetting("custom-hotbar", "chbPrimaryColor", {
            name: "customHotbar.settings.chbPrimaryColor.name",      // The name of the setting in the settings menu
            hint: "customHotbar.settings.chbPrimaryColor.nameHint",   // A description of the registered setting and its behavior
            label: "Color Picker",         // The text label used in the button
            restricted: false,             // Restrict this setting to gamemaster only?
            config: false,                 // Disable display on the standard Foundry settings menu
            defaultColor: "#0000FF80",     // The default color of the setting
            scope: "client",               // The scope of the setting
            config: false,                 // Disable display on the standard Foundry settings menu
            onChange: (value) => {ui.customHotbar.render();}        // A callback function which triggers when the setting is changed
        })

This still displays in the settings menu, and I don't think it should:
Foundry 0.6.5, lib-color-settings 2.2.2

The html version does not use the ColorSetting object, it just puts the color code in a text field. That being said, there were a few bugs with the html that are fixed now. Thanks for the help @Norc!


[Help] Korepi doesn't work

[Startup.cpp:100] UserAssembly.dll isn't initialized, waiting for 2 sec.
Korepi won't start and crashes

"failed to detect any game version". Your game or app is out of date, look for the launcher or use the discord server to download new versions.

its already updated

then it's korepi, search the server for a new version

Do you mean a new version of Korepi?

yes, search for discord server


Fix bug with mutations queue

Found little bug in code. I'll continue to check code stability

Available as v1.2.4 on npm, thanks ^^


"State of Charge" is returning float

Describe the bug
The sensor in HA for "State of Charge" is always returning a float.
Example: 60.0%
Expected behavior
Looking at the data from the API, an int is always returned for "State of Charge". There is no reason to convert to float.
Expected value: 60%
Screenshots

Your Vehicle Details
Model: Q5
Year: 2021
Type (ICE/PHEV/BEV): Hybrid

Then maybe we should also change https://github.com/audiconnect/audi_connect_ha/pull/405/ as we do the same.


Spreading identical values with properties and indexers creates errors

Similar to #8178, but with an additional property. Spreading identical values with properties and indexers creates errors.
export type Trie<T> = {
  [string]: Trie<T>,
  _?: T,
};

const x: Trie<number> = { };
const y: Trie<number> = { };

const z: Trie<number> = { ...x, ...y };

Flow version: 0.117.0
Expected behavior
Two values with identical types should always be spreadable
Actual behavior
Error is thrown:
    11: const z: Trie<number> = { ...x, ...y };
                                           ^ Cannot determine a type for object literal [1]. `Trie` [2] cannot be spread because the indexer string [3] may overwrite properties with explicit keys in a way that Flow cannot track. Can you spread `Trie` [2] first or remove the indexer?
        References:
        11: const z: Trie<number> = { ...x, ...y };
                                    ^ [1]
        9: const y: Trie<number> = { };
                    ^ [2]
        4:   [string]: Trie<T>,
              ^ [3]

Link to Try-Flow or Github repo: tryflow

That's an unsoundness in generic checking.
I have work in the pipeline that allows this, but it exposes some nastier issue somewhere else in the type checker that makes it unshippable. Specifically, it creates an error in a library definition with no references to actual source code.

A similar bug makes it impossible to spread on indexed object into a literal object matching the same type.
tryflow 1
tryflow 2

This is expected behavior that we don't change


Add support for additional fields in Connection objects

Hi @a8m,
We need to add additional fields to generated connect objects by pagination template.
https://github.com/facebookincubator/ent-contrib/blob/master/entgql/template/pagination.tmpl
{{/* A template for adding additional fields to specific types. */}}
{{ define "model/fields/additional" }}
    {{- /* Add static fields to the "Card" entity. */}}
    {{- if eq $.Name "Card" }}
        // StaticField defined by templates.
        StaticField string `json:"static_field,omitempty"`
    {{- end }}
{{ end }}

Just like above if you can add support to override a template to add more fields to the connections object then it will help us to extend them as per our needs.
Thanks,
Dilip

Solved using a different approach so this is not needed at this moment.

Great @dilipkk-foyernet.
Feel free to share your workaround for future readers. Thanks 😊

// DeviceConnection is for constructing device search response
type DeviceConnection struct {
	*ent.DeviceConnection
	CountByType []*DeviceCountByType
}

I am extending ent connection object and adding custom fields.

@a8m if you have time then can you tell me what I am doing wrong here: https://github.com/facebookincubator/ent-contrib/pull/19, just for my understanding.


vaadin-text-field dependency needs to be updated

Right now the dep is at 2.3
"vaadin-text-field": "vaadin/vaadin-text-field#^2.3.0",

This creates bundling issues when using other vaadin components like vaadin-combo-box (since 5.0.1):
"vaadin-text-field": "vaadin/vaadin-text-field#^2.4.3",

webpack throws ye olde duplicates error because it needs to include both versions inteh bundles:
DOMException: Failed to execute 'define' on 'CustomElementRegistry': the name "vaadin-text-field" has already been used with this registry

@web-padawan I imagine this is a pretty straight forward update? There may be other components that need updating too I guess. These were just the two I found in conflict.

This should be generally not required, as long as both versions can be resolved to a latest one when performing a fresh npm install.
The duplicate dependencies problem rather happens randomly, i.e. when updating version of previously installed component, or installing a new component.

@web-padawan But it can't be resolved as the 2.4.x branch can't fulfill the the requirements for "vaadin/vaadin-text-field#^2.3.0". This is an issue with bundling via webpack/rollup/etc as both versions get included in the bundles.

Isn't there any way to resolve dependencies on the webpack side?

@DiegoCardoso Not one that works for web components. If this was just a js library, then it wouldn't be an issue as each conflicting version would reside in a different bundle.  OK, it's resolving properly now for some reason. Version 2.4.x will fulfill vaadin/vaadin-text-field#^2.3.0. I had removed my node_modules folder and done a yarn install yesterday, and it didn't work, but doing it again today worked fine! yarn can be very odd at time. This is what my lock file looked like:
-"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>-  version "2.3.8"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-BuEckLsr0Ezpwx8PspQB3e3cW6SlNENlc2620ufPl0HSkk4FsyZlTlITAtnwAXNRKR1xCyMUpti4/MwZUDoc7A==
-  dependencies:
-    "@polymer/polymer" "^3.0.0"
-    "@vaadin/vaadin-control-state-mixin" "^2.1.1"
-    "@vaadin/vaadin-element-mixin" "^2.0.0"
-    "@vaadin/vaadin-lumo-styles" "^1.2.0"
-    "@vaadin/vaadin-material-styles" "^1.2.0"
-    "@vaadin/vaadin-themable-mixin" "^1.2.1"
-
-"<EMAIL_ADDRESS>-  version "2.4.9"
-  resolved<EMAIL_ADDRESS>-  integrity sha512-tGR1UbF5CURFE1B6mTdseHu1uFCwBxDE20F4+DoLj0b0c3qIV8kHNSJ2qq4GCvxKRGHML8hGcmOs+y4VkWpRvw==
+"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>+  version "2.4.10"
+  resolved<EMAIL_ADDRESS>+  integrity sha512-JdXoIO2P4vYvBRWEmCNwzYlmyktIN0QFFA8royCFQMqxaXM2WxDIzLZ+1XtoHIjy8Bti4y1gwSzrqx20p510Hg==

Why it decided to go from having two versions to correctly having only one is beyond me really. I didn't change my package.json smh


View all (templates, users, etc) button should take user back to previous page

Currently, when I click to edit a user account, template, etc and then use the 'View all' button to go back to the main table it reloads the full table from page 1. Desired behavior is to have the 'View all' button take me back to the specific page I started from so I can view the updated/changed user, template, etc.
This may be a separate issue, but:
I would also expect to be taken back to the specific page I started from when I complete an action by clicking Save or Submit (e.g. Publish a template, save user or org profile details, etc). Current behavior for most of these actions reloads the full table from page 1 and I have to go searching to find the updated record.

this might be fixed after template refactoring. leaving here to test and verify before closing.

Closing out. Is fixed.

Just tested this on DMPOnline-Test, and I do not get this page caching behavior as detailed in  the ticket.
To reproduce:

Go to Admin Users Page
Visit page 5 and select a random user to Edit
Hit view all Users
You are returned to page 1, not page 5 which had the user you were editing

@sjDCC is this no longer desired, or do we want to re-open this?

When we tested this, it was working for templates which seemed more important as you need to return to the 'view all' page to publish. It wasn't working for users but we closed out nonetheless as we couldn't think of a case when you would need to view that specific user again. When you make any changes in the account the page is reloaded and saved changes are visible already before you click 'view all'.
If it's trivial we can re-open and implement so user is returned to the specific 'view all' page with content they were editing. That would ensure consistency. Happy to ignore though if it's not a quick fix. In your court to decide @xsrust


Apply setuptools version fix to v1.10.12 branch

As Airflow version v1.10.12 is still officially supported for MWAA, I think it would be good to ensure that the local runner for that version can still be built and used.
https://docs.aws.amazon.com/mwaa/latest/userguide/airflow-versions.html#airflow-versions-official
Currently, the build for this Airflow version fails with the error described in https://github.com/aws/aws-mwaa-local-runner/issues/72 too.
This PR applies the fix in https://github.com/aws/aws-mwaa-local-runner/pull/73 from @ivica-k to the branch for Airflow version v1.10.12.
Tested by successfully building the image for the v1.10.12 branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I should have done this when my PR landed in main; thank you for fixing that.


Wikilinks color bleeding over to adjacent letter

As shown in the screenshot, in [[future-proof]]ing where there is no space after the closing brackets, and the next letter gets the same color as the link.
Happens in both Live Preview and Reading Mode.

After further testing, I discovered this only happens with i and l which are the thinnest letters. The links are also clickable on that last letter, so this may not be an issue with the theme at all, and is instead aan Obsidian parsing issue.

Interesting bug! I'm glad you found out that it was a parsing issue. This would be a good bug to report on the forums!! Again, thanks for reporting 😄

So, this isn't a problem in the default theme. I narrowed it further to the font: DM Sans.
Removing 'DM Sans' from --font-sans-2 makes the issue go away.
I think it has to do with the glyphs. Notice how the i gets a little extra horizontal line added to connect it with the f when right next to it.

So ultimately, I don't think it's an Obsidian problem or an issue with this CSS theme, but a bug in the underlying browser renderer.


Tracing events proposal for KEB operations

Description
It is fairly difficult to figure out what is the status of a certain operation in KEB. Currently, the only way is to grep through the logs of KEB.
In this PR I would like to propose tracing events for KEB operations stored in the DB as a standalone table. This is an initial implementation supporting core concepts desired for tracing events:

configurable retention (72h)
different levels of events (info, error)

https://github.com/kyma-project/control-plane/pull/2094/commits/fee60b365865b2b6de3225e80ff614877ffd4d8c contains example usage of how to instrument code with these tracing events, sample output for provisioning operation can look similarly to:
                  id                  | level | instance_id |             operation_id             |                          message                          |          created_at
--------------------------------------+-------+-------------+--------------------------------------+-----------------------------------------------------------+-------------------------------
 27e222a3-2952-4050-ba3c-274ec3c21101 | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [Starting]                               | 2022-09-30 11:46:49.510205+00
 6c745efc-933b-415d-8e5b-1981c85e5890 | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [Provision_Initialization]               | 2022-09-30 11:46:49.523337+00
 2ae8aad7-2335-4013-ba2e-ef8005a57e78 | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [Resolve_Target_Secret]                  | 2022-09-30 11:46:49.588386+00
 473fbddb-570c-4200-bc03-d3d750861480 | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [AVS_Create_Internal_Eval_Step]          | 2022-09-30 11:46:49.669714+00
 acf1eaaf-290c-4a7f-97e3-3f4ca1f72b8e | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [EDP_Registration]                       | 2022-09-30 11:46:50.231342+00
 3c81840f-6b70-4691-9877-15b2924feb2b | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [Overrides_From_Secrets_And_Config_Step] | 2022-09-30 11:46:51.863725+00
 ce465c2c-c6b2-454f-9c6d-7ad90c34311a | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [BTPOperatorOverrides]                   | 2022-09-30 11:46:51.902614+00
 3b73fe12-eab7-4f77-8655-0427b3094ae4 | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [Create_Runtime_Without_Kyma]            | 2022-09-30 11:46:51.907771+00
 b4f7c258-843e-4e85-9cba-12e5d0748ad7 | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [Check_Runtime]                          | 2022-09-30 11:47:03.523715+00
 b35e18e2-61ba-43d7-9db7-c31eca412f63 | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [Get_Kubeconfig]                         | 2022-09-30 11:55:03.657566+00
 e02e5097-3f96-4e5a-ad23-315fe243396d | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [Create_Cluster_Configuration]           | 2022-09-30 11:55:03.780542+00
 45260849-fb72-469c-83e2-109fd96995bc | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [Check_Cluster_Configuration]            | 2022-09-30 11:55:03.970597+00
 3b8c808c-1e13-4b56-bc46-66c8593403e9 | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [AVS_Create_External_Eval_Step]          | 2022-09-30 11:59:34.092699+00
 061f808d-d00e-458b-a21c-eca44bd2bb89 | info  | test-jw229  | 04aaa84f-6d6b-4012-bda3-0206dbd99f0e | processing step: [AVS_Tags]                               | 2022-09-30 11:59:34.096158+00

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest-required

/retest

/retest

/retest

/retest


Fix typo 'router' to 'history' in v2.0.0 upgrade guide

That part is demonstrating what the old usage was.

@taion Yes, but the old signature is described as:
// v1.0.x
router.isActive(pathname, query, indexOnly)

which should be
// v1.0.x
history.isActive(pathname, query, indexOnly)

Oops, I misread. Thanks!

:smile:


I enabled qsv acceleration error when transcoding

Can't use qsv acceleration, it outputs such information
03_new_staxrip.log

QSVEnc is an encoder not an accelerator.
you want to x265 software encoder with QSVEnc Decoder enabled.


Publicly host SomeTrails

As we approach the interim release, it would be convenient to have a public site to show off our project. I already own the domain https://wrighs6.com, so we might as well host it at https://sometrails.wrighs6.com. I'll spin up a free server with Oracle Cloud and configure the DNS to point https://sometrails.wrighs6.com and https://api.sometrails.wrighs6.com to the server.

I diagnosed the memory issues as being caused by an automated package management process. Increasing the amount of swap space by switching to a ~6GB swap partition instead of a 2GB swap file seems to have solved all problems.


[SPARK-27202][MINOR][SQL]Update comments to keep according with code

What changes were proposed in this pull request?
Update comments in InMemoryFileIndex.listLeafFiles to keep according with code.
How was this patch tested?
existing test cases

Can you check PartitioningAwareFileIndex comments too?
This is pretty trivial, but OK.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

updated PartitioningAwareFileIndex

Test build #4645 has started for PR 24146 at commit a4dc63c.

Test build #4645 has finished for PR 24146 at commit a4dc63c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master


Corrections to privileged-access-workstations.md

Multiple corrections to privileged-access-workstations.md, Intro & Phase 1, to improve clarity and consistency:

Step 5. b. (iii), (i,ii) - Updated instruction to add Administrators group (excluding causes warning: "Administrators must be granted the logon local right."

Step 7. b. (iii) - Removed "DOMAIN\Administrators" from list (including causes warning: "You cannot deny all users or administrator(s) from logging on locally."

Corrected Group Policy Object name references where creation of GPOs, security groups, and OUs are mentioned in introduction to match instructions.

Updated "Restrict Server Logon" GPO instruction from "standard workstations" to "Tier 1 servers".

Updated "Restrict Workstation Logon" GPO instruction to include linking to Workstations OU.

Revised domain join PowerShell script from "DomainOrWorkGroupName" to "DomainName" as instructions refer to "domain name".

Multiple grammatical and punctuation fixes.

Various other fixes, indentation, phrase, and step corrections.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@aarontheadmin - Thanks, Aaron! We're reviewing this now.

Hi, Aaron - sorry for the delay. We've reviewed your proposed changes and will merge and publish them today.
Thanks!


[BEAM-14294] Worker changes to support trivial Batched DoFns

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python PreCommit

@robertwb I think this is largely ready. I added a new WindowedBatch implementation, HomogeneousWindowedBatch which is effectively a wrapper around WindowedValue, where we know the value is a batch. We now enforce that batches are partitioned by (timestamp, windows, pane_info) and only create HomoegeneousWindowedBatch instances.
The old implementation, ConcreteWindowedBatch isn't used, it's probably worth just backing that out and saving it for a future PR.
Other notes: I've added support for {Timestamp, PaneInfo, Window}Param on process_batch (and we validate only these are used at construction time). Other DoFn params that were discussed in https://s.apache.org/batched-dofns are not yet supported.

Thanks @robertwb I replied to all the questions I can off the top of my head. I'll take a pass at addressing the other comments  and let you know

Ok I need to call it a day, first thing tomorrow I'll work on tearing out ConcreteWindowedBatch and addressing the other open comments.

Ok, I think all of the major points are addressed @robertwb. I will come back for another pass tomorrow morning to clean up lint checks, populate the BEAM-XXX jiras, address any other nits, etc..

IT seems somehow I've introduced some flakiness in test_batch_pardo.

It looks like its a pre-existing issue related to passing a large input (order 1000 elements) through test_batch_pardo in order to trigger a flush. I can reproduce the flake in a pipeline that doesn't have a batched DoFn:
  def test_large_input_pardo(self):
    with self.create_pipeline() as p:
      res = (
          p
          | beam.Create(np.array(range(5000), dtype=np.int64)).with_output_types(np.int64)
          | beam.Map(lambda e: e * 2)
          | beam.Map(lambda e: e + 3))
      assert_that(res, equal_to([(i * 2) + 3 for i in range(5000)]))

It's worth noting I haven't seen the flake in a cython environment. Perhaps it's a bug in the "slow" stack which is often only tested with trivial inputs?
I don't think I'll be able to diagnose the existing issue today. A solution for this PR might be to skip the flush-triggering test in non-cythonized environments.

See 2067b13 for attempted resolution of the flake (we'll see how CI checks go). I separated out the flush-triggering test, and added a new element-wise DoFn test that also triggers the flake. Both of these are skipped when running with non-cythonized coder_impl.

If the flake is unrelated to batch, sounds fine to skip it to me (but please file a jira).

(Assuming we can also reproduce this flake without this PR.)

Yeah, I filed BEAM-14410 to track. Good point about reproducing without this PR. I'll add the new test in a separate PR and verify that it reproduces the flake there.

Portable_Python PreCommit has passed, but is not reflected in the GitHub UI: https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Commit/22208/
I'll go ahead and merge.


Error Handling

Refactors implementation to reject promises with semantically meaningful error messages.
Fixes bug where timeout option caused an extra request to fire.
Refactored tests to safety that expectations inside of promise then and catch blocks don't get lost.

:eyes:

:shipit:

:shipit:


API response bodies are empty when using active_model_serializers

I have a Rails 5 app in API mode using this gem and active_model_serializers. devise_token_auth's controllers renders plain hashes as responses but neither of all the 3 adapters from active_model_serializers seem to be able to render the hashes to JSON.
Versions:
Rails 5. (--api mode)
active_model_serializers: 0.10.2
devise_token_auth: 0.1.37 (tried 0.1.39, still the same)
Expected behavior vs actual behavior
curl -i -X DELETE http://localhost:3000/v1/auth/sign_out
Expected response body:
{  success: false, errors: ['User was not found or was not logged in.'] }
Actual response (with the default active_model_serializer adapter):
{}
With the active_model_serializer :json_api adapter:
NoMethodError (undefined method `read_attribute_for_serialization' for {:errors=>["User was not found or was not logged in."]}:Hash)
With the active_model_serializer :json adapter:
NoMethodError (undefined method model_name' for Hash:Class):`
I filled an issue over there https://github.com/rails-api/active_model_serializers/issues/1893 as well. I've read some other issues here that imply most devise_token_auth users are using active_model_serializers as well. What is the proper configuration (if any) between both gems?
I can provide a repo that reproduces this issue if needed.

@lynndylanhurley Sorry to specifically tag you on this but I've been stuck on this issue for about almost a week. Any idea on what would be causing this?


Cannot mkdir in Windows

I get the following error in Windows after selecting text fig/text, bringing up the command pallet, selecting  Super Figure: Insert vector figure as latex snippet and choosing the template ~/.config/super-figure/templates/template.svg which does indeed exist.
Could not copy template file 'C:\Users\[myusername]/.config/super-figure/templates/template.svg'. Os Error: Error: ENOENT: no such file or directory, mkdir '\\?\C:\c:\[path-to-my-project]\fig'
The only extension settings that I have changed are the paths to Inkscape and Gimp, which are "C:\Program Files\Inkscape\bin\inkscape.exe" and "C:\Program Files\GIMP 2\bin\gimp-2.10.exe", respectively.

Seems like the target image file is kinda messed up. Mind providing the log in the console > output > Super Figure?

I'm afraid I don't know how to do that.  Do you want me to run your extension on its own? Otherwise the debug console is set for tex.

Editing vector figure: fig/test
File 'fig/test.svg' doesn't exists, using template '~/.config/super-figure/templates/template.svg'
Copying from: 'C:\Users[myuserneame]/.config/super-figure/templates/template.svg' to: 'C:\c:[path-to-my-project]\fig\test.svg'
Could not copy template file 'C:\Users[myusername]/.config/super-figure/templates/template.svg'. Os Error: Error: ENOENT: no such file or directory, mkdir '\?\C:\c:[path-to-my-project]\fig'

Yeah, it looks like there are two references to C drive.  If I try to run this in a different drive, say G, then it'll give me a similar message:
Copying from: 'C:\Users\[myuserneame]/.config/super-figure/templates/template.svg' to: 'C:\g:\[path-to-my-project]\fig\test.svg'

I will have a look at it and test it on a Windows machine in a hour, maybe tomorrow

Good to go, tested on linux and windows. If you found any other problem let me know. Cheers, happy holidays!

Thanks for the quick fix!  I'm really enjoying using this.  RIP Castel!


Update project online 1.4.1

Q
A

Bug fix?
no

New feature?
no

New sample?
no

Related issues?
no

What's in this Pull Request?
Update to SPFx 1.4.1

thx Joel, appreciated.


 The PR aligns the definition of
insert_bmlov_*_freeze fault injectors between 6X and 7X. Fixes the
replacement with SIMPLE_FAULT_INJECTOR in 1502bef.

Commits in the PR shouldn't be squashed to preserve authorship.

Allure report https://allure.adsw.io/launch/83046

Allure report https://allure.adsw.io/launch/83260

Allure report https://allure.adsw.io/launch/83503

If the last commit is a cherry pick commit, then where are most of the tests?!

Why doesn't revert revert everything?!

Why doesn't revert revert everything?!

Because the test and the test in 7 and 6 are different. The test from 7 will not work in 6 without changes. If I revert everything, where will I get the changes that are in 6? Do I have to edit it manually?

Why doesn't revert revert everything?!

Because the test and the test in 7 and 6 are different. The test from 7 will not work in 6 without changes. If I revert everything, where will I get the changes that are in 6? Do I have to edit it manually?

I need to replace every "pg_switch_wal()" and others. What is the reason to re-edit the test manually if you have already made these changes?
diff 8accc02 1502bef
diff --git a/src/test/isolation2/sql/frozen_insert_crash.sql b/src/test/isolation2/sql/frozen_insert_crash.sql
index 97e6728e8e..89cf7fb2e7 100644
--- a/src/test/isolation2/sql/frozen_insert_crash.sql
+++ b/src/test/isolation2/sql/frozen_insert_crash.sql
@@ -15,18 +15,21 @@
 1: create table tab_fi(a int) with (appendoptimized=true) distributed replicated;

 -- switch WAL on seg0 to reduce flakiness
-1: select gp_segment_id, pg_switch_wal() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
+1: select gp_segment_id, pg_switch_xlog() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
+
+2: insert into tab_fi select generate_series(1, 1000);
+2: update tab_fi set a = 1 where a > 10;

 -- suspend right after the insert into gp_fastsequence during an AO table insert,
 -- but before freezing the tuple
 1: select gp_inject_fault('insert_fastsequence_before_freeze', 'suspend', ''/*DDL*/, ''/*DB*/, 'gp_fastsequence'/*table*/, 1/*start occur*/, 1/*end occur*/, 0/*extra_arg*/, dbid) from gp_segment_configuration where role = 'p' and content = 0;

-2>: insert into tab_fi values(1);
+2>: vacuum tab_fi;

 1: select gp_wait_until_triggered_fault('insert_fastsequence_before_freeze', 1, dbid) from gp_segment_configuration where role = 'p' and content = 0;

 -- switch WAL on seg0, so the new row gets flushed (including its index)
-1: select gp_segment_id, pg_switch_wal() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
+1: select gp_segment_id, pg_switch_xlog() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;

 -- inject a panic, and resume the insert. The WAL for the freeze operation is not
 -- going to be made to disk (we just flushed WALs), so we won't replay it during restart later.
@@ -58,23 +61,26 @@
 1: create table tab_fi(a int) with (appendoptimized=true) distributed replicated;

 -- switch WAL on seg0 to reduce flakiness
-1: select gp_segment_id, pg_switch_wal() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
+1: select gp_segment_id, pg_switch_xlog() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
+
+2: insert into tab_fi select generate_series(1, 1000);
+2: update tab_fi set a = 1 where a > 10;

 -- suspend right after freezing the tuple
 1: select gp_inject_fault('insert_fastsequence_after_freeze', 'suspend', ''/*DDL*/, ''/*DB*/, 'gp_fastsequence'/*table*/, 1/*start occur*/, 1/*end occur*/, 0/*extra_arg*/, dbid) from gp_segment_configuration where role = 'p' and content = 0;

-2>: insert into tab_fi values(1);
+2>: vacuum tab_fi;

 1: select gp_wait_until_triggered_fault('insert_fastsequence_after_freeze', 1, dbid) from gp_segment_configuration where role = 'p' and content = 0;

 -- switch WAL on seg0, so the freeze record gets flushed
-1: select gp_segment_id, pg_switch_wal() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
+1: select gp_segment_id, pg_switch_xlog() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;

 -- While we are on it, check the wal record for the freeze operation.
 -- One of the purposes is to guard against unexpected addition to the xl_heap_freeze_tuple struct in future.
 -- If this test failed due to WAL size, please check to see if the xl_heap_freeze_tuple struct
 -- has changed, and if we should initialize any new field in heap_freeze_tuple_no_cutoff().
-! seg0_datadir=$(psql -At -c "select datadir from gp_segment_configuration where content = 0 and role = 'p'" postgres) && seg0_last_wal_file=$(psql -At -c "SELECT pg_walfile_name(pg_current_wal_lsn()) from gp_dist_random('gp_id') where gp_segment_id = 0" postgres) && pg_waldump ${seg0_last_wal_file} -p ${seg0_datadir}/pg_wal | grep FREEZE_PAGE;
+! seg0_datadir=$(psql -At -c "select datadir from gp_segment_configuration where content = 0 and role = 'p'" postgres) && seg0_last_wal_file=$(psql -At -c "SELECT pg_xlogfile_name(pg_current_xlog_location()) from gp_dist_random('gp_id') where gp_segment_id = 0" postgres) && pg_xlogdump ${seg0_last_wal_file} -p ${seg0_datadir}/pg_xlog | grep freeze_page;

 -- inject a panic and resume in same way as Case 1. But this time we will be able to replay the frozen insert.
 -- skip FTS probe to prevent unexpected mirror promotion
@@ -126,7 +132,7 @@ $$ LANGUAGE plpgsql;
 1: create index tab_fi_idx on tab_fi using bitmap(b);
 1: insert into tab_fi values(1, 1);
 -- switch WAL on seg0 to reduce flakiness
-1: select gp_segment_id, pg_switch_wal() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
+1: select gp_segment_id, pg_switch_xlog() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;

 -- case 1: suspend and flush WAL before freezing the tuple

@@ -136,7 +142,7 @@ $$ LANGUAGE plpgsql;
 2>: insert into tab_fi values(2, 2);
 1: select gp_wait_until_triggered_fault('insert_bmlov_before_freeze', 1, dbid) from gp_segment_configuration where role = 'p' and content = 0;
 -- switch WAL on seg0, so the new row gets flushed (including its index)
-1: select gp_segment_id, pg_switch_wal() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
+1: select gp_segment_id, pg_switch_xlog() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
 -- inject a panic, and resume the insert. The WAL for the freeze operation is not
 -- going to be made to disk (we just flushed WALs), so we won't replay it during restart later.
 -- skip FTS probe to prevent unexpected mirror promotion
@@ -165,15 +171,15 @@ $$ LANGUAGE plpgsql;
 1: create index tab_fi_idx on tab_fi using bitmap(b);
 1: insert into tab_fi values(1, 1);
 -- switch WAL on seg0 to reduce flakiness
-1: select gp_segment_id, pg_switch_wal() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
+1: select gp_segment_id, pg_switch_xlog() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
 -- suspend right after freezing the tuple
 1: select gp_inject_fault('insert_bmlov_after_freeze', 'suspend', dbid) from gp_segment_configuration where role = 'p' and content = 0;
 2>: insert into tab_fi values(2, 2);
 1: select gp_wait_until_triggered_fault('insert_bmlov_after_freeze', 1, dbid) from gp_segment_configuration where role = 'p' and content = 0;
 -- switch WAL on seg0, so the freeze record gets flushed
-1: select gp_segment_id, pg_switch_wal() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
+1: select gp_segment_id, pg_switch_xlog() is not null from gp_dist_random('gp_id') where gp_segment_id = 0;
 -- While we are on it, check the wal record for the freeze operation.
-! seg0_datadir=$(psql -At -c "select datadir from gp_segment_configuration where content = 0 and role = 'p'" postgres) && seg0_last_wal_file=$(psql -At -c "SELECT pg_walfile_name(pg_current_wal_lsn()) from gp_dist_random('gp_id') where gp_segment_id = 0" postgres) && pg_waldump ${seg0_last_wal_file} -p ${seg0_datadir}/pg_wal | grep FREEZE_PAGE;
+! seg0_datadir=$(psql -At -c "select datadir from gp_segment_configuration where content = 0 and role = 'p'" postgres) && seg0_last_wal_file=$(psql -At -c "SELECT pg_xlogfile_name(pg_current_xlog_location()) from gp_dist_random('gp_id') where gp_segment_id = 0" postgres) && pg_xlogdump ${seg0_last_wal_file} -p ${seg0_datadir}/pg_xlog | grep freeze_page;
 -- inject a panic and resume in same way as Case 1. But this time we will be able to replay the frozen insert.
 -- skip FTS probe to prevent unexpected mirror promotion
 1: select gp_inject_fault_infinite('fts_probe', 'skip', dbid) from gp_segment_configuration where role='p' and content=-1;

You don't need to do anything manually, especially if it has already been done, just use the ready-made solution. Now you have a problem only in the design, not in the solution.

Should this be present after the revert?

Allure report https://allure.adsw.io/launch/83595

Allure report https://allure.adsw.io/launch/83602

change

Commit 1502bef introduced a new flaking test. The test expects a panic to occur

to
Commit 09742e9 introduced a new flaking test. The test expects a panic to occur

change

Commit 1502bef introduced a new flaking test. The test expects a panic to occur

to
Commit 09742e9 introduced a new flaking test. The test expects a panic to occur

Done

I think that it was necessary to first revert the commit 3d4cc61 before reverting the commit 1502bef.

Allure report https://allure.adsw.io/launch/83634

I think that it was necessary to first revert the commit 3d4cc61 before reverting the commit 1502bef.

No need. Reverting commit 1502bef undoes 3d4cc61's changes

I think that it was necessary to first revert the commit 3d4cc61 before reverting the commit 1502bef.

No need. Reverting commit 1502bef undoes 3d4cc61's changes

The reversion must be conflict-free!

The reversion must be conflict-free!

Revert 1502bef clearly describes the reversal of the relevant test cases involving commit 3d4cc61. Revert 3d4cc61 clutters the patch. Revert 1502bef has no major conflicts.

Allure report https://allure.adsw.io/launch/83674

Allure report https://allure.adsw.io/launch/83699

Allure report https://allure.adsw.io/launch/83714

Cherry picked from 8accc02

I'm not sure these words are appropriate here.

Cherry picked from 8accc02

I'm not sure these words are appropriate here.

Why? It's a cherry-pick

Cherry picked from 8accc02

I'm not sure these words are appropriate here.

Why? It's a cherry-pick

Cherry-picл is not formatted like this, it doesn't look like this, and most of the changes from the original commit are missing.

This is just a reference to the original commit. Is this a serious omission? Misleading?

Allure report https://allure.adsw.io/launch/83989

Allure report https://allure.adsw.io/launch/84001

Allure report https://allure.adsw.io/launch/84144


Fix for passthrough requests with empty responseText

Coverage remained the same at 96.714% when pulling e5649f8b3a20d071a38a786e675b1ef60718a9bf on fix-162 into abf84dd6683a4962544ef707af4706cbe8f08a24 on master.


Tilemap terrain occasionally not drawn when set via C# Task.Run

Godot version
v4.0 stable mono
System information
Windows 10, Vulkan
Issue description
I've been playing around with noise to create a large procedural world where I'm generating and clearing chunks of tiles to help performance. I've found that there are sizeable framerate drops when setting and clearing terrain using set_cells_terrain_connect. These drops can be easily avoided by calling the function from a different thread in C# using Task.Run. However, occasionally the terrain will not generate properly. This seems to only be happening when called from within Task.Run.
In the screenshots below you can see where Godot has attempted to generate terrain and has been successful to an extent (see the collision shapes for the correct tiles) but patches of the tile sprites are seemingly not drawn.

If I move the player far enough away to clear the tiles and then back again so that they are regenerated, the engine will generate the terrain fine. It seems to be very inconsistent about when it fails and there are no errors in the output.
Steps to reproduce
Define a region within code then within a separate function, loop through the cells in the region adding each one to a new collection then use that collection as an arg to set the terrain using set_cells_terrain_connect. Repeatedly call this function as part of a Task.Run and eventually you will see incorrect terrain.
using Godot;
using System.Collections.Generic;
using System.Threading.Tasks;

public partial class GenerateTerrain : TileMap
{
	[Export]
	public Vector2I Region { get; set; }

	private FastNoiseLite Noise { get; set; } = new FastNoiseLite();

	private RandomNumberGenerator RandomNumberGenerator { get; set; } = new RandomNumberGenerator();

	// Called when the node enters the scene tree for the first time.
	public override void _Ready()
	{
		Task.Run(() => this.DrawTerrain(new Vector2I(50, 50)));
	}

	// Called every frame. 'delta' is the elapsed time since the previous frame.
	public override void _Process(double delta)
	{
		if (Godot.Input.IsMouseButtonPressed(MouseButton.Left))
		{
			this.Clear();
			var fromPos = this.LocalToMap(this.GetLocalMousePosition());
			Task.Run(() => this.DrawTerrain(fromPos));
		}
	}

	private Task DrawTerrain(Vector2I fromPos)
	{
		var startPoint = fromPos - this.Region / 2;
		var endPoint = fromPos + this.Region / 2;

		var groundTerrain = new List<Vector2I>();

		for(int x = startPoint.X; x < endPoint.X; x++)
		{
			for(int y = startPoint.Y; y < endPoint.Y; y++)
			{
				var cell = new Vector2I(x, y);

				groundTerrain.Add(cell);
			}
		}

		var groundTerrainCells = new Godot.Collections.Array<Vector2I>(groundTerrain);
		this.SetCellsTerrainConnect(0, groundTerrainCells, 0, 0, false);

		return Task.CompletedTask;
	}
}

I've attached a minimal reproduction project. Run the Test scene and click around the window. Each click should generate a new 50x50 square of terrain. Keep on clicking and eventually, you will see terrain being generated that is incorrect. See attached gif below

Expected behaviour in the example project is to consistently generate a 50x50 square of terrain.
Minimal reproduction project
TerrainBug.zip

Or, wait, you are firing this several times at once, you're doing this each frame the mouse is held down, you need to do it just once when the mouse is pressed

Yeah good shout, I've changed the input now so it's IsActionJustPressed thats my bad, I'll update the reproduction project. The behaviour is still the same though. QueueRedraw does not seem to affect anything, unfortunately.  Awaiting the task and checking if it's still running will still produce the same effect.
public async override void _Process(double delta)
	{
		if (Godot.Input.IsActionJustPressed("Primary"))
		{
			if (this.DrawTerrainTask != null)
			{
				GD.Print("Task still running!");
				return;
			}

			this.Clear();
			var fromPos = this.LocalToMap(this.GetLocalMousePosition());
			this.DrawTerrainTask = Task.Run(() => this.DrawTerrain(fromPos));
			await this.DrawTerrainTask;
			this.DrawTerrainTask = null;
		}

		this.QueueRedraw();
	}

Does it happen if you don't await?

Yeah still happens without awaiting
public override void _Process(double delta)
	{
		if (this.DrawTerrainTask != null && this.DrawTerrainTask.IsCompleted)
		{
			GD.Print("Task completed!");
			this.DrawTerrainTask = null;
		}

		if (Godot.Input.IsActionJustPressed("Primary"))
		{
			if (this.DrawTerrainTask != null)
			{
				GD.Print("Task still running!");
				return;
			}

			this.Clear();
			var fromPos = this.LocalToMap(this.GetLocalMousePosition());
			this.DrawTerrainTask = Task.Run(() => this.DrawTerrain(fromPos));
		}

		this.QueueRedraw();
	}

Then it returns to the original question, is it thread safe to update a tile map, doesn't seem like it, most of Godot isn't thread safe unless it's explicitly stated

Setting a cell queues updating of the map, which since you're running on a thread can happen before you're done, and then won't fix it again as it's done, what you are doing is probably not thread safe

What happens if you call ForceUpdate()

Ahhh I see, that was gonna be my next question lol, why is this particular thing not thread-safe? I'm not super knowledgeable in the world of multi-threaded programming but it seemed like giving it enough time to run the function between calls wouldn't cause any race conditions or anything. However, what you've said makes sense I think. I suppose I could have queued an update from one thread and then got overwritten by the main thread? something like that.

ForceUpdate() seems to work! Calling it within the task caused it to crash. Calling it from the process function at the point where it checks to see if the task is complete seems to make it work
public override void _Process(double delta)
	{
		if (this.DrawTerrainTask != null && this.DrawTerrainTask.IsCompleted)
		{
			GD.Print("Task completed!");
			this.DrawTerrainTask = null;
			this.ForceUpdate(0);
		}

		if (Godot.Input.IsActionJustPressed("Primary"))
		{
			if (this.DrawTerrainTask != null)
			{
				GD.Print("Task still running!");
				return;
			}

			this.Clear();
			var fromPos = this.LocalToMap(this.GetLocalMousePosition());
			this.DrawTerrainTask = Task.Run(() => this.DrawTerrain(fromPos));
		}
	}

That forces it to recreate the textures and data, what probably happens is that it queues this update, and then marks that it's done, and won't do it again, because all the tiles changed between then are ignored
But simply most functionality isn't thread safe because it adds an overhead to do so, which makes it slower in all cases, I would suggest not using threading unless you can verify things are safe, and I'm not sure what you are doing is safe still, it could cause crashes in some cases or other weird bugs

It might be safe to remove the map from the tree (unparent it) and do the update while not in the tree, because it won't do some of the updates then, but I'm not sure

Interesting. I'm going to try and implement it in my actual project and see what happens but if it keeps on causing issues will likely abandon the procedural generation idea or at least try to find a better method of chunking that won't cause such big frame drops. Thanks very much for your help and insight into Godot @AThousandShips

No problem!
Consider tricks like separating the map into chunks which can be loaded before added to the tree, so you aren't affected by having to process it while not in the tree, that should be safe to do on a thread when I looked at the code (it won't do the update when outside the tree, and forces it to update when it enters, this should probably make things smoother as it won't wait for updates like that and won't refresh stuff until its ready)

I think this can be closed unless there's some issue remaining, it seems to be related to thread unsafe issues

I think this can be closed unless there's some issue remaining, it seems to be related to thread unsafe issues

Is there something we could better document in the page you linked?

Good question, I personally would say it makes it clear it's not thread safe, and suggests loading off the tree and then adding, but if someone else can chime in on that too, I'm relatively experienced on threading so might affect my perspective

I reported a few month ago the same behavior in #71388, sometimes the tiles aren't painted. In my case, was using GDScript


Cert https://agrosner.gitbooks.io/dbflow/content/ has expired

Das Zertifikat ist am 9. September 2018, 12:05:00 GMT+2 abgelaufen.
Die aktuelle Zeit ist 9. September 2018, 19:24.
Fehlercode: SEC_ERROR_EXPIRED_CERTIFICATE

btw @agrosner seams to have no interest anymore since end 2017
Everyone should make his own follow up task about this knowledge

I think that this library is replace by Android Room :)

carmas123, Room has some limitations, such as encryption

We use for encryption this https://github.com/commonsguy/cwac-saferoom in production, it's based on Room

hannesa2, This library is not ready for production just yet. The developers are experimenting with it.

https://dbflow.gitbook.io/dbflow/usage2 :) try this one.


HPA not scaling down using helm

helm version: 2.12
kubectl version: 1.17
Cloud Provider: AWS (cluster is built using Kops)
Horizontal pod autoscler is not scaling down resources when doing with helm , but its working when using declarative scrips directly.
It should scaledown if its less than target value
How to reproduce it (as minimally and precisely as possible: use the below script
################
{{- if .Values.hpa.enabled -}}
apiVersion: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
metadata:
name: {{ template "auth-server-helm.fullname" . }}
spec:
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: {{ template "auth-server-helm.fullname" . }}
minReplicas: {{ .Values.replicaCount }}
maxReplicas: {{ .Values.hpa.maxReplicas }}
metrics:
{{- if .Values.hpa.memory }}
type: Resource
resource:
name: memory
target:
type: Utilization
averageUtilization: {{ .Values.hpa.memory }}
{{- end }}
{{- end }}
################
Anything else we need to know?:
It scales down if we use declarative steps , but not with helm.
below is declartive script
apiVersion: autoscaling/v2beta1
kind: HorizontalPodAutoscaler
metadata:
name: document-mgmt-helm
namespace: default
spec:
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: document-mgmt-helm
minReplicas: 1
maxReplicas: 1
metrics:
type: Resource
resource:
name: memory
targetAverageUtilization: 98
Environment:
Kubernetes version (use kubectl version): 1.17
Cloud provider or hardware configuration: AWS
OS (e.g: cat /etc/os-release): Debian GNU/Linux 9
Kernel (e.g. uname -a):Linux ip-172-20-95-48 4.9.0-11-amd64 #1 SMP Debian 4.9.189-3+deb9u2 (2019-11-11) x86_64 GNU/Linux

Can you please test and confirm if this is an issue with the latest version of helm 2 or helm 3? 2.12 is very old.

Hi, @nirupbbnk - the latest Helm 2 is here: https://github.com/helm/helm/releases/tag/v2.16.8
And the latest Helm 3 is here: https://github.com/helm/helm/releases/tag/v3.2.3
Please let us know if you still see this behavior with a more recent version of Helm. Thanks!

Hi @bridgetkromhout ,
Thanks for the reply,
I tried to upgrade helm to latest version and tried, no luck.
Inserting the hpa template for your reference
`
{{- if .Values.hpa.enabled -}}
apiVersion: autoscaling/v2beta1
kind: HorizontalPodAutoscaler
metadata:
  name: {{ template "knowledge-base-helm.fullname" . }}
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: {{ template "knowledge-base-helm.fullname" . }}
  minReplicas: {{ .Values.replicaCount }}
  maxReplicas: {{ .Values.hpa.maxReplicas }}
  metrics:
  {{- if .Values.hpa.cpu }}
  - type: Resource
    resource:
      name: memory
      target: averageUtilization: {{ .Values.hpa.memory }}
  {{- end }}
{{- end }}

@nirupbbnk there are a few things you can do to try and figure this out.
Have you used the helm get manifest command to retrieve the manifest that was put into Kubernetes? Have you looked at the HPA using kubectl to see what it has?
When you use kubectl describe on the HPA does it note anything?
I see you are using the v2beta1 version of the API. Have you tried the v2beta2 version. I know it's supposed to work but it's worth trying. Note, the other YAML needs to change as well.

Hi, @nirupbbnk - hopefully the ideas above have helped you solve this. If problems remain, please let us know! Thanks for using Helm.


Minor tests improvements

Minor tests improvements:

Test if deleting a category also removes it's children
Test slug generation for common non-ASCII types of characters

:+1:


bug in forEachLayerAtPixel on mobile devices

I have implemented a tooltip function with popups with forEachLayerAtPixel function. It works fine on desktop PC's, but most of mobile devices not. The forEachLayerAtPixel works fine on icon and polygon but on images is founded the image layer not in correct place. If i click a little left-buttom near the image, then the layer is founded, so the place (founded layers on a pixel) is calculated wrong in case of images. (I think the difference, that icon and polygon are vector layers, but the image not.) After some analyse we have found, that it caused, when the css ratio is not 1 (window.devicePixelRatio <> 1).

at rotation (alt+shift+mouse) it works faulty also on desktop! The calculated place remaining somewhere on the original place, it's not moving with the picture.

I've attached a sample program:
popup-1.zip

What version of OpenLayers are you using? This issue should be fixed with v3.18.x. See #5731.

The problem comes with 3.18.1 too.

Oh, I see now you're using ol.layer.Image, not ol.layer.Tile. So it seems we're having the same issue there.

#5731 also did not fix the issue for tile layers.


addded some styles in navbar for small screen sizes

Title and Issue number
Title :Added style for navbar for small screen sizes.
Issue No. :#1381
Tech Stack : HTML, CSS ,JS
Close #1381

Type of PR

[ ] Feature enhancement
[ ] Documentation update

Video (mandatory)

https://github.com/user-attachments/assets/627629a1-c42c-4c04-bd7b-4aee8658884f
Checklist:

[x] I have mentioned the issue number in my Pull Request.
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have gone through the  contributing.md file before contributing
[ ] I have Starred the Repository.

Checklist:(In case of Adding New WEB3 project only)

[x] I have made my Commits(of new project) under the  Projects folder
[x] I have created a helpful and easy to understand README.md
[x] i have added the image of my project under asstes/img folder

Additional context (Mandatory )
Are you contributing under any Open-source programme?

[x] I'm a KWOC 2024 contributor

@apu52 plz check now


combined recv and parse flags in fix_session_recv, translation of libtrading recv flags to OS flags, rename some flags

related to #84 in order to pass parse flags to fix_session_recv need to implement flag translation

Looks OK to me.
@divaykin, do we really need FIX_RECV_FLAG_MASK/FIX_PARSE_FLAG_MASK?
It looks like we don't have to perform logical AND with these masks.

@mstanichenko thanks removed masks, logical ANDs were indeed redundant

@mstanichenko, does this look to you?

OK with me


[BUG] Polluting log entry regarding destination migration

What is the bug?
There is a specific log that keeps on appearing quite frequently on all OpenSearch clusters (even fresh installations). While it does not somehow harm the cluster, its consistent presence is quite annoying:
[INFO ][o.o.a.u.d.DestinationMigrationCoordinator] [my-node-name] Detected cluster change event for destination migration

I tracked this message on DestinationMigrationCoordinator.kt. I am not sure what is exactly wrong there, but something is.
There are couple of related threads already on the forums, like here and here.
And if you google "Detected cluster change event for destination migration", you'll see that it appears on many logs, for unrelated issues, so my guess is that it's just polluting logs.
How can one reproduce the bug?
Steps to reproduce the behavior:
Just bootstrap a new cluster and check the output logs.
What is the expected behavior?
Not to produce such a polluting log.
What is your host/environment?

OpenSearch: v2.9.0
OS: AlmaLinux 9.2
Plugins: all that come by default

Yeah, I met the same issue, such logs are very annoying. I can't even find out which components printed it from the source code.

still there in v2.11

closing in favor of #1356

version 2.13
the problem persists

Can confirm i see this all the time [in OS_2.16]
[2024-09-20T09:23:18,647][INFO ][o.o.a.u.d.DestinationMigrationCoordinator] [data_node_1] Cancelling the migration process.
[2024-09-20T09:23:42,440][INFO ][o.o.a.u.d.DestinationMigrationCoordinator] [data_node_1] Cancelling the migration process.
[2024-09-20T09:23:43,819][INFO ][o.o.a.u.d.DestinationMigrationCoordinator] [data_node_1] Cancelling the migration process.
[2024-09-20T09:23:43,920][INFO ][o.o.a.u.d.DestinationMigrationCoordinator] [data_node_1] Cancelling the migration process.

OS 2.17, messages still in log

@riysaxen-amzn could you please reopen this issue? Or shall we create a new one?
The original reported problem is not fixed by https://github.com/opensearch-project/alerting/pull/1356
btw, there is a suggestion there: https://github.com/opensearch-project/alerting/pull/1356#issuecomment-2355029957

Can report that it still happens in 2.16 - Is there a new issue for this?

we upgraded our cluster from 2.10.0 to 2.18.0 last week.  We see bunch of logs every often with message "Cancelling the migration process."  Is this a bug or issue with our upgrade?


Close file redirection issue

When closing a file,
user is redirected to:

instead of empty page:

in addition, when loading a big file, loader isn't displayed anymore


laravel-blade-directives very old version in package

In composer.json "appstract/laravel-blade-directives": "^0.4" of this package
but last realse of appstract/laravel-blade-directives is 1.1.0
Can you upgrate the version need for this package ?

You can create a PR for this :)


WIP: Feature/improve load performance

Summary
When running the ingestion process, starlake load all domains et schemas into memory. We restrict the loading to the current domain being accessed to improve performance.
PR Type: Bug Fix | Feature | Documentation
Status: WIP/Ready to review
Breaking change? Yes/No
Description
Solution
Instead of loading all file sin the folder, we only load the included domains in the command line.

👍🏼 I was considering this feature too

Can we apply the same concept for jobs ?

Done for domains
Still need to be done for jobs


webhook message not returned to user in feedback

We have useful webhook messages like activeBundle <%q> not present on cluster but these are not returned to the user.

Fixed


Carthage and shared frameworks!

Hi
I found this issue when I try to use carthage to build the framework.
Fetching BDBOAuth1Manager
*** Checking out BDBOAuth1Manager at "2.0.0"
*** xcodebuild output can be found in /var/folders/hj/xzndmnhx0613xb46m68cwtq40000gn/T/carthage-xcodebuild.T9TfYv.log
*** Skipped building BDBOAuth1Manager due to the error:
Dependency "BDBOAuth1Manager" has no shared framework schemes for any of the platforms: iOS
If you believe this to be an error, please file an issue with the maintainers at https://github.com/bdbergeron/BDBOAuth1Manager/issues/new
Please advise if BDBOAuth1Manager cannot be installed by carthage?
I try to install with different version of BDBOAuth1Manager and none of them are installed successfully.
thank you for response.

@gongzhen I don't see a Cartfile located in the repository so I don't believe it can be installed via Carthage. @bdbergeron do you have any plans to add Carthage support? If not, might I be able to create a branch to add this support?

@chrisdhaan thank you for your reply.  I will be looking forward this new feature.


Screen "jumping" (bouncing) after changes in 1.0.6 (1.0.5 and before is okay)

Describe the bug
In some older project that we are maintaining we were currently upgrading to latest flutter (3.24.3) and together we were bumping our dependencies. One of them is searchField and we went from 0.8.4 to 1.1.7. After the changes however (interestingly) one of the screens that is using searchField is bouncing when I am typing and some search results are present. I've been investigating and the breaking change is what happened between v1.0.5 and v1.0.6.
Unfortunately I cannot reproduce it on your example, although I've been trying very hard, so I cannot give you minimal reproducible code (just video). However playing around with your code I was able to figure out which line is causing the issue. Maybe you will be able to understand what could be happening. If you could cooperate with me on this, I would be very grateful.
See attached video:
https://github.com/user-attachments/assets/2bef5070-afa7-4306-8f7b-3039c90c9755
The change that was done was this (see here https://github.com/maheshj01/searchfield/issues/136):
if (searchResult.isEmpty) {
     selected = null;
}
/// IF I REMOVE THIS ELSE, THE BOUNCING STOPS
else {
    selected = 0;
}

To Reproduce
Unfortunately, I am not able to produce minimal reproducible code.
[✅ ] By clicking this checkbox, I confirm I am using the latest version of the package found on pub.dev/searchfield
Expected behavior
The bouncing should not happen.
Actual behavior
There is bouncing when searchItems contain something and selected = 0;

Hi @pavkoccino, thanks for filing the detailed issue, I will investigate it and update you on this.

@pavkoccino Meanwhile, Can you please share a code sample that reproduces this issue? Is this happening only when Searchfield is in a newly navigated page?

Hey @maheshj01, I am really sorry, but as I wrote in the original post, I am not able to reproduce it on some simple project (for example on your example project). So probably there needs to be things that are involved in this. However I am unable to post here the codebase from the project, where we have this issue as that is not open source.

Sure, I will investigate this issue. I bit occupied with some work, Probably take a look at it this weekend.

@maheshj01 sir when i close the keyboard all the suggestion showing from scratch not showing hat i have entered char in the textfield
https://drive.google.com/file/d/132iZYWgLzDNMllLGyOlkA15SayzkrcZe/view check this

Hello @pavkoccino,
I tried to  reproduce the bug, but I am unable to reproduce it, Can you try to reproduce it with the below code sample or Atleast Share Some code sample that I can take a look?
import 'package:example/demo.dart';
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter App',
      theme: ThemeData(
        colorSchemeSeed: Colors.indigo,
        useMaterial3: true,
        brightness: Brightness.light,
      ),
      darkTheme: ThemeData(
        colorSchemeSeed: Colors.blue,
        useMaterial3: true,
        brightness: Brightness.dark,
      ),
      home: SearchFieldSample(),
      debugShowCheckedModeBanner: false,
    );
  }
}

class SearchFieldSample extends StatefulWidget {
  const SearchFieldSample({Key? key}) : super(key: key);

  @override
  State<SearchFieldSample> createState() => _SearchFieldSampleState();
}

class _SearchFieldSampleState extends State<SearchFieldSample> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(title: Text('Searchfield Demo')),
        body: Padding(
          padding: const EdgeInsets.all(8.0),
          child: ListView(
            children: [
              ElevatedButton(
                  onPressed: () {
                    Navigator.of(context).push(
                        MaterialPageRoute(builder: (context) => DemoApp()));
                  },
                  child: Text('tap me')),
            ],
          ),
        ));
  }
}

import 'package:flutter/material.dart';
import 'package:searchfield/searchfield.dart';

class DemoApp extends StatefulWidget {
  @override
  _DemoAppState createState() => _DemoAppState();
}

class _DemoAppState extends State<DemoApp> {
  final List<String> _suggestions = [
    'United States',
    'Germany',
    'Canada',
    'United Kingdom',
    'France',
    'Italy',
    'Spain',
    'Australia',
    'India',
    'China',
    'Japan',
    'Brazil',
    'South Africa',
    'Mexico',
    'Argentina',
    'Russia',
    'Indonesia',
    'Turkey',
    'Saudi Arabia',
    'Nigeria',
  ];

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: ListView(
        children: <Widget>[
          Padding(
            padding: const EdgeInsets.all(8.0),
            child: SearchField(
              scrollbarDecoration: ScrollbarDecoration(thumbVisibility: false),
              suggestionItemDecoration: BoxDecoration(
                color: Colors.grey.withOpacity(0.2),
                gradient: LinearGradient(colors: [
                  Color(0xff70e1f5),
                  Color(0xffffd194),
                ], begin: Alignment.topLeft, end: Alignment.bottomRight),
              ),
              suggestions:
                  _suggestions.map((e) => SearchFieldListItem(e)).toList(),
              suggestionState: Suggestion.hidden,
              searchInputDecoration: SearchInputDecoration(
                floatingLabelBehavior: FloatingLabelBehavior.auto,
                labelText: 'SearchField',
                border: OutlineInputBorder(),
              ),
              hint: 'SearchField example 4',
              maxSuggestionsInViewPort: 6,
              suggestionDirection: SuggestionDirection.down,
              itemHeight: 45,
              onSuggestionTap: (x) {},
            ),
          ),
        ],
      ),
    );
  }
}

Hi @pavkoccino, I made a PR #191 which will probably fix this issue
v1.2.0 is now live on pub.dev see the Changelog for details. Please try it out and let me know if that fixes the issue.

Thank you, I am going to try it today and will let you know.

Unfortunately, after upgrading to 1.2.0 we can still observe the bouncing behavior :(

@pavkoccino Can you share a reproducible code sample?
See How to create a  minimal reproducible code sample?

I am little bit overwhelmed right now so I do not know when I could get to it.


fix: update all instances of unusual alpha

Sorry, I keep mistakenly opening a PR in this repo rather than my fork!


Spike: Support Marlowe's spike

Why

streamline, simplify, enable open-source contributions
that for, a potential IO internal user: Marlowe will be a guest and evaluate Hydra as a potential puzzle piece in running Marlowe contracts more efficiently
we want them to have experience and also ensure discovered things are to the benefit of future contributors

What

As a first step the Marlowe will

explore the repository
run the demo
hackily try to run a marlowe script inside a hydra head (by extending the demo case or so)

That for, the Hydra team will commit to respond on any questions on StackExchange, Discord or Slack within a 12 hour time frame.

Where it makes sense, StackExchange or Discord is prioritized for the benefit of the greater community (esp. SE could become a knowledge base)

Also, we will ensure that this first Marlowe spike produces a

solution design for one Marlowe use case on Hydra
any existing features needed for that use case are identifed
any missing features are tracked as idea items on our roadmap

How

[x] #404
[ ] Reflect on what documents were helpful and which were missing during this interaction

Hi @ch1bo, thanks a lot for nice intro. We are starting to scaffold something here.
This week we are going to migrate parts of this ticket to our project. The rest of the colab could be done using usual issue / PR flows and other communication channels as you suggested above.
Should we close this ticket then?

Hi @paluh
great to see you getting started! I think we should keep this ticket open for the first of your spikes and do the "reflect what was helpful and/or missing" part on our end. I expect that you guys will be time boxing the exploration and hacking spike on your end? That would allow for a definition of done on this one and not have it be the never-ending story ;)

After @paluh and @yveshauser had the opportunity working with Hydra from Marlowe, they have shared what resources they found helpful, outdated or missing. I am listing them here non-prioritized and with some ideas on follow-up actions:
helpful

The website is great and really helpful to do the first steps and run the demo application etc.
Clear codebase with clear namespaces and sub packages (choices like Hydra.Cardano.Api and not Hydra.Utils.Cardano without clear substructure).
Architecture decision records and how the decisions where taken (e.g. no effect systems) - keeping it simple. Would expose the ADRs even more.
-> Make them a top-level navigation entry on the website?
Examples / the TUI application

outdated

Project seems to be in good shape, we could think about dropping the -poc suffix
-> Let's do it

missing

In order to understand and implement our demo application we mostly explored source code - hoogle and haddock would be preferable, but are missing
-> Provide instructions how to setup repository using haskell.nix and withHoogle = true?

Differences differences between the paper and the current implementation.
-> Yes! #448

Were not sure how "hydra channel isomorphism" handles policy scripts and minting (it is not apparent from the paper).
-> Mentioned a bit in the FAQ and one feature; should write about it in the docs though!

Hydra client in PureScript/TypeScript
-> Sounds like a perfect future open-source contribution!


avoid unnecessary workers with sequential CombinedLoader

What does this PR do?
This PR relates to behavior exhibited when training with multiple validation dataloaders. In this scenario, Lightning wraps the multiple dataloaders with a CombinedLoader. This CombinedLoader currently initializes all of the dataloaders causing all of their workers to start up and prefetch data potentially introducing substantial overhead.

Fixes #17641

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Good catch! Can you add a test in tests/tests_pytorch/utilities/test_combined_loader.py. Also a "Fixed" entry in src/lightning/pytorch/CHANGELOG.md

Alright, I think I've addressed these.


Android: compile for x86 arch

Can you list which arch you need to support?

armeabi-v7a
x86

Fixed by 4887c6b27c51740a13467ee838d6c3af46a89b7d


How can I use CSS framework styles inside a storybook

Let's say that my application is basing on some CSS framework like Semantic UI, Bootstrap or something like that. How can I easily incorporate that styles inside a story book so that my components will display correctly?

Yes it is. Read here - https://github.com/kadirahq/react-storybook/blob/master/docs/setting-up-for-css.md
I that's not what you need, just reopen this.

Link is broken and I can't find it in the file in current master.

Check this: https://getstorybook.io/docs/configurations/custom-webpack-config

Thanks. An easier way was to add a head.html file in the ".storybook" directory with the  elements for Bootstrap og Semantic UI

Thanks head.html method works perfectly!

Would head.html also be the best way to go about it if the file for you are adding is not served through a URL but is instead hosted locally? how would that work?

Both links are broken.

Sorry for the broken links, this is unfortunately the result of our restructuring, The only way to find is by search.
What are you looking for / need help with @kirkstrobeck ? This issue is quite old and closed.
If you have a specific problem we can help you with, let us know 👍 .

I landed here trying to figure out how to integrate React Storybook into a real application where all of our styles are in scss files in app/assets/stylesheets

You'll need to extend our webpack config / provide your own custom webpack config.
In it you'll need to tell webpack what to do with the .scss-files. aka, you need to add the sass-loader.
Likely you already have this already setup for you app, and you can mostly copy-paste from it's webpack config?

found in documentation: https://storybook.js.org/configurations/default-config/#css-support

@arunoda would it possible remove above two links that have confused face I marked above? save time for others who enter this page in the future. Thanks!

The confused reactions are probably enough. I upvoted em’ too.

Just updated the comments with outdated links

Header file for story book is called preview-head.html Reference:
https://storybook.js.org/configurations/add-custom-head-tags/

Within my "main" app my global styles are defined within a JS file that exports a template string containing all the global CSS rules.
Is there a way to add a template string with CSS definitions to the iframe where the stories are rendered in?

@flavordaaave I think you'll want to use just inject the styles in a style-tag from config.js

@ndelangen So far all the possibilities of injecting global style (import './styles.css'; or via preview-head.html) don't allow me to inject styles with dynamic params.
My styles look something like this:
/* .storybook/config.js */

import theme from './theme'

export default `
html {
  font-family: Helvetica;
  background: ${theme.canvas_ground};
  ...
}
`

So for now I'm using the injectGlobal helper from react-styled-components as mentioned in my EDIT above.
/* .storybook/config.js */
...
import { injectGlobal } from 'styled-components'
import styles from '../src/styles'

injectGlobal`${styles}`
...

what injectGlobal does is basically this:
// create a  DOM element
const styleElement = document.createElement('style')
// put the text from styles variable between opening and closing