Bumped min numpy version to 1.18

Hello @manodeep! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file setup.py:

Line 561:80: E501 line too long (114 > 79 characters)

@lgarrison Will you please take a look that I didn't reduce the combinations of os/compiler/python/numpy too much? (really, we need to have a separate "does-this-even-compile-and-run-a-simple-thing" workflow and only run the tests on a smaller subset of hardware)
I have dropped python2 completely - so the next release should be a major release (and not a minor/patch release) - possibly even Corrfunc3.0.0. What do you think? Also, should we also take out the code for python2 within the CPython extensions?

Hmm - now that I think about it a bit more - may be I should drop py2 and numpy in CI first and release a patch version first (ie revert the change to setup.py)

@lgarrison Looks like there were plans to rename the package to corrfunc rather than Corrfunc for Corrfunc3.0. That also seems appropriate - what do you think?

I reverted the drop of py2 to create one final patch release with python2. Once the tests pass, I am going to merge the branch in and release 2.5.3.
I will then create a new branch to start the process for releasing Corrfunc3

How would we do a deprecation period? The biggest motivation to change the package name is to conform to the python convention - which might be required if we want to migrate to newer packaging methods (i.e., migrate out of setuptools).
If there is an import error, then the error handling would be done by python - I don't think we would be able to emit any message at all - right? Or could we add a dummy Corrfunc.py file within the new package and use that somehow to emit the info message?

Yeah, I was thinking of something like a warning period where import Corrfunc would work but emit a message telling people to switch to import corrfunc. I don't know the best way to do this off the top of my head; maybe a symlink of Corrfunc/ to corrfunc/ (with logic to check which path was used in the import) or maybe a Corrfunc.py.


UTC ISO-8601  timestamps

change format of dateCreated and dateUpdated to UTC ISO-8601  timestamp

would something like (new Date()).toISOString() work instead?

@thehenrytsai i have no idea why the CI linter check is saying i have extra spaces between curly braces. running npm run lint locally produces 0 errors


Wrong comments highlighting in styled components

In styled components we can comment the code with //
So comments should look like this:

Instead we get this:

fixed on master, and I created a release (0.20.0)


Resizable Workspace

How to make Blockly workspace be resizable? I tried to apply this logic, but it doesn't work. Seems size is applied on the next resize event.

It should be simpler with react-blockly-component, since both components expose a resize function.  If you have a way of accessing the component, you should be able to simply call .resize() on it.  (If you're embedding the editor component in another component, you should be able to use a ref to access it and then call this.refs.editor.resize() or whatever you called the ref.)

Thanks, tried to call resize(), but still it doesn't resize. Any specific requirements for the parent element for this to work?

I’m experiencing the same problem. I have react-blockly-component placed in a parent div with 300px width. If I trigger the size of the parent div to change to 100% react-blockly-component doesn’t scale to the width unless I manually resize the browser.
I’ve attached a modified version of the example public/index.html to exhibit this problem. Despite BlocklyEditor containing a resize(), an error is thrown when a call is attempted.
index.txt


unit test for pkg/misc/time.go

Is your feature request related to a problem? Please describe.
test func func FormatTimeMillis(tsMillis uint64) string  and func func FormatDate(tsMillis uint64) string
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hey guys, this one is merged, and when i want to git pull from dev branch, i could not get last updates for unit test for FormatTimeMillis, what is my bad? how could i git pull dev branch to last version to continue with other unit test issues

you can fetch upstream, follow these steps:
git remote add upstream  git@github.com:cectc/dbpack.git
git fetch upstream
git pull --rebase upstream dev
git push -f


Not getting any logs from "extended details"

Hi,
I've sat up the Puppet TA, generated the token, and configured the inputs on a Splunk HF. Most of them works fine, and we're getting data into Splunk, but for one of the inputs we're not getting any data. The faulty input is namely the one for "extended details".
I've looked through the internal logs, but cant find any help there. The only message I'm getting in the internal Puppet TA log is the following.
"timestamp" ERROR pid=12345 tid=MainThread file=base_modinput.py:log_error:307 | []
This error I'm getting from the source /opt/splunk/var/log/splunk/splunkta/forpuppetenterprise_puppet_enterprise_extended_details.log.
Any idea on why it fails just for this one input, and how I could get some more insightful error messages on the subject?

Can you provide what version of PE you are using?, so I can recreate the issue.

I am thinking about adding a factor filter what default one would you like to see ? Also Ill add the ssl ca cert option to make it easier to install.  Will update the docs.  I had it in version 1 and must have be a type.

I will check out what version of PE we're using. I can't check it myself, so I'll get back to you on that tomorrow.
About the factor filter; I'm not sure. I'm not a Puppet admin, so I don't know what information is the most relevant. That being said, I talked with a colleague of mine today, an he said the "factors" your talking about should probably be named "facts". Could this be correct, that this name is a typo in the app and TA?

The version of PE we're using is v2018.1.2.

I just installed the newest version of Puppet, will start working on this issue.

I have uploaded the latest version that is working on the latest version of Puppet Enterprise and Splunk. Should resolve some of these issues that you are having, you will need to reset your inputs.

@hettervik did you remove your inputs and recreate them via the Add-on?,  Number 3 can easily be fixed when you do "git clone https://github.com/domeger/SplunkTAforPuppetEnterprise.git ." while your in the /opt/splunk/etc/apps/ directory.
I had to modify a good chunk of the app to support multiple PE Master per customer request so that modified how each pull is done. I have tested this on the last three release so the extended should work fine if you reset the inputs.

I am also getting a lot of 307 errors in the splunktaforpuppetenterprise_puppet_enterprise_extended_details.log.
2018-09-27 08:27:00,327 ERROR pid=23709 tid=MainThread file=base_modinput.py:log_error:307 | []
2018-09-27 08:30:35,004 ERROR pid=25280 tid=MainThread file=base_modinput.py:log_error:307 | []
2018-09-27 08:32:00,244 ERROR pid=26508 tid=MainThread file=base_modinput.py:log_error:307 | []
2018-09-27 08:35:35,022 ERROR pid=28243 tid=MainThread file=base_modinput.py:log_error:307 | []
How are you handling timestamps with the extended events; or really all of the events sourcetypes from PE?  All the date/times from PE are in GMT so I think my events are getting ingested in the future; I need to verify.  Are you just letting splunk add the timestamps of when it's ingested?
-Archie

If you look at the checkpoint creation, this is based on Puppet Timestamp. There is an index time that is tagged to each pull but I am also using the Puppet timestamps to pull.
if ckpt_value == None:
old = now - datetime.timedelta(minutes=5)
#format the time
# This is a timestamp in UTC-based ISO-8601 format (YYYY-MM-DDThh:mm:ssZ)
start_time = old.strftime("%Y-%m-%dT%H:%M:%SZ")
#if it does exist then checkpoint value is start time
else:
start_time=ckpt_value
end_time=now.strftime("%Y-%m-%dT%H:%M:%SZ")

Our extended_events are in the future..  I traced one of our event all the way back to the host..
Here is the actual event in /var/log/messages on the agent..  Time are EST GMT-4.
Notice the catalog time of 156.11 seconds

Same event on Splunk: Note the report GUID : 986868821df1df769b233f326f285c0407e4064c

Event in PE console: (Same report GUID)

In PE, I notice when you mouseover the dates\times that are always shown in GMT, they will present the timezone offset of the actual time.  (I don't like how Puppet does this).
I would prefer to see my events in Splunk with my local timezone.  I am not seeing events that happen @now until 4 hours later.
-Archie

@archspangler - Will experiment and see what I can do to adjust this. I will also consult the puppet team and see if you can change the report times.

@mrzarquon That worked great!   Thanks for the PE tip!!
-Archie

Hi folks. Taking this thread back to the original question at hand. After doing quite some reverse engineering and troubleshooting, I think I've pinned down the root cause to why we're not getting any data from the extended details input.
In the bin catalog of the TA there is a script named input_module_puppet_enterprise_extended_details.py. It is this file that contains the actual query for the Puppet API. The query is supposed to ask for data in a given time interval, with a defined start time and end time. On initial startup of the TA the start time is sat to five mintes ago with the following code line; old = now_datetime.timedelta(minutes=5). From there on the start time is supposed to be sat to the time the last query ran, using the variable ckpt_value. The end time is always now.
I've had the TA ran for days without getting a single event from the extended details input, but when I tried setting the initial start time to a bigger value (old = now_datetime.timedelta(minutes=500)), and restarted the Splunk instance, then I got the events I was looking for. Apparantly there is something wrong with how the time intervals for the query is calculated and/or how the ckpt_value is sat. Perhaps is has something to do with the timezones? Perhaps if they are not "correct" the time calculations get stuck in a loop or something? I don't know, I haven't looked more into this as of yet. I'm not sure if my solution of setting the initial time to minus 500 minutes will work permanently, or if it will just work one time on initial startup. Any advice is much appreciated!

@hettervik - Good point, I made an assumption that everyone would be using GMT in their datacenter and environments. I historically used GMT to maintain consistency, but I like your approach, I can add a filter for the inputs to allow custom changes on interval pulls.

@domeger @mrzarquon ..  I attended your session at .conf 2018..   I am interested in the Puppet Alert actions..  How do I get them?

Hi. The extended logs input have been working fine after I edited the initial start time to look for events in Puppet to 500 minutes, not only just at initial startup, but consistently over time after that. Although it's a kind of "hacky" solution, it did solve my problem. I will close this issue.


WIP revC2

This pull request is intended to track the work on the revC2 of the hardware.
Main goals of this revision compared to revC1 is to improve DFM (Design For Manufacture). This includes:

modify and select footprints that are easier to place and reflow with automatic production machinery
allow the use of easier to source and lower cost (in quantity) parts where possible/reasonable
optimize for 100+ unit automated assembly production runs vs hand placed low unit count builds

Secondary goal is improvement of the design based on user feedback:

By popular request switch to USB-C connector
Replace parts for more capable ones that increase the usability of the hardware

Please refer to this pull request in issues that track change requests for revC2.
Do not merge yet. ;)

@marcan I did the layout for the new ADC. In my layout the new TVS diodes for the ADC (needed to keep the 36 Vmax capability of the ADC) aren't symmetric:

Is that ok with you or do you have a better idea how to place them?
I wanted to put them as near to the Vsense inputs as possible as this helps against ESD.

@whitequark thank you for the review.
I have used similar technique on another board and it worked fine. The thing to consider here is that the ground fill around the part is pretty small and does not connect to a larger ground plane that would act as a heat sink. So my assumption is that it is not a big problem when using a typical hot air rework station. It is necessary to use a hot air rework station due to the shield being soldered into the board in any case.
That said it is a very good point you are making here. I will test and film how hard it is to rework the USB-C connectors on the Glasgow. Then we can make an educated decision about it.

I will test and film how hard it is to rework the USB-C connectors on the Glasgow. Then we can make an educated decision about it.

Sounds good! I missed the fact that it is not connected to a ground plane. Since it is not I agree that the impact on rework is much smaller than what I have thought it is.

Shouldn't this be merged? Seeing as we have revC2's manufactured and shipped already.

I was waiting for you and @electroniceel to validate the design before I merge it. I did not want to make it seem like it is a "you can safely build this design for yourself" until you two had a chance to test things. If the new circuits are 100% confirmed to be working as intended, we can generate all the generated assets (gerber files and BOM) and then we can merge it. But if you rather have this in mainline already as is, I can rebase it and merge it if you want.

I talked to @electroniceel and we decided to hold off merging, even though this will result in some "revC2"s floating around that are not actually revC2-as-merged...

Here is the TODO list for me bore we can merge:

[ ] Check the mechanical drawing and tolerances of the LVDS connector alignment pins.
[ ] Test USB-C connector desolderability.
[ ] Test fit of the Molex Sync connectors and plugs (we had board clearance issues with the drop in replacement non Molex parts that I purchased... my bad)

I've just built some of these boards. Nice work on the DFM changes @esden!
Looks like the level shifters: U4,U6,U9-U11,U16-U18,U22-U29,U32 have been changed from SOT6 DRL package to SC70 DCK. It appears like the package suffix on these parts in the MPN field has not been changed, which will result in people ordering the level shifters in the wrong package.
If others make this mistake the parts do kind of fit, bit will require slight touch-up on the pins to ensure connectivity.

Looks like the level shifters: U4,U6,U9-U11,U16-U18,U22-U29,U32 have been changed from SOT6 DRL package to SC70 DCK. It appears like the package suffix on these parts in the MPN field has not been changed, which will result in people ordering the level shifters in the wrong package.

Oops. Sorry. Especially this package change was designed to make this board easier for others to make, we got several reports of the DRL package being difficult to work with. Unfortunately this made it even harder for you to get right.
Thank you very much for reporting this, I just fixed it in the revC2 branch.


fix(azure-devops): add support for teamid

Due to changes in azure devops' routing, a workspace is required now to be redirected to the correct screen

Pre-flight Checklist
Please ensure you've completed all of the following.

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I updated the version package Updating

Description of Change
Add teamid support for azure-devops recipe, since Microsoft changed something in the routing, and it will always go to the sales page of devops

I do not use azure devops, and so do not know if this change is valid. Can any of the other reviewers test and approve?

I will see if I can setup a test env in Azure DevOps so I can create a screen recording of this


Gatsby-image changes are not published on npm

Gatsby image addition is not reflecting when installing via npm.
The package version was updated before the merging the PR for
https://github.com/ashhitch/gatsby-plugin-wpgraphql-seo/commit/f0cbc6a5d6df1271d65a75165bdde526031436d5
As the version didn't change, looks like the package hasn't been updated.

Thanks for spotting this


Black Format Codebase

Reference Issues/PRs

Fixes #195
What does this implement/fix? Explain your changes.

 Furthermore, it introduces an ignoreRev file that can be used to locally configure your git to ignore the revisions made in the extremely large reformatting commit when looking at blame logs.
Files Formatted:
All .py files
Files added:
.git-blame-ignore-revs
Files Modified:
.pre-commit-config.yaml
Any other comments?
This is understandably a huge PR, more just implemented as a jumping off point, there may be specific black configurations that would be more desirable. Happy to refactor/reedit, or just leave as an example!
🧡 Thanks for contributing!

@klieret Here's another one, an attempt at sensibly introducing black formatting to the repository both retroactively and forwardly as a pre-commit hook. Let me know what you think!

Hi sorry @hminsky2002 , but I had assigned this issue to myself because I need to talk with the team again about this first. Also, such a PR will almost certainly merge conflict if not directly merged, so I'll have to close it (as it is more time to keep this updated).

you can see if someone was already assigned to an issue on the right side ;)

@klieret No sweat! Was a neat experience working with pre-commit hooks, and I should've checked to see if there were any current assignees(duh).


Mushroom Head Normally Open Momentary (HPB11M/VPB11M)

Is anyone already working on this? If not, I would like to take it up.


Add falcoctl, gcc to falco-no-driver image

On trying to load plugins(like k8smeta) as highlighted here, we are currently running into issues since falcoctl and gcc are not shipped as part of the image.

As part of a Chainguard effort to reduce code duplication and provide higher quality images, we have stopped accepting pull requests for changes to images in this repository. Due to this, we are closing all pull requests today in order to start fresh.
If you think this pull request was closed in error, please feel free to re-open this pull request or open an issue and we will try to help you out. Thank you!


Slices.{read/write} is broken

From @talex5
open Lwt

module Store = Irmin.Basic(Irmin_mem.Make)(Irmin.Contents.String)

let config = Irmin_mem.config ()
let task s = Irmin.Task.create ~date:0L ~owner:"User" s

let main =
 Store.create config task >>= fun t ->
 let t = t "test" in
 Store.update t ["key"] "value" >>= fun () ->
 Store.head t >>= function
 | None -> assert false
 | Some head ->
 Store.export t ~min:[] ~max:[head] >>= fun slice ->
 let buf = Cstruct.create (Store.Private.Slice.size_of slice) in
 let rest = Store.Private.Slice.write slice buf in
 assert (Cstruct.len rest = 0);
 let _slice2 = Store.Private.Slice.read (Mstruct.of_cstruct buf) in
 return ()

let () =
 Lwt_main.run main

I was expecting _slice2 to be the same as slice, but instead I get an
error during the read (even in native code):
Fatal error: exception Ir_hash.Invalid("lueB+��1d|E���O��<��key")

[ copying from mailling list ]
This is due to Irmin.Contents.String overriding the default serialisation:
https://github.com/mirage/irmin/blob/ae42dab34d8451395910eb4cd534ee887a6871a5/lib/ir_contents.ml#L143

The goal is to have the file contents (once expanded on the filesystem) serialised as the raw string, not at the string with a prefix.

While I agree that this breaks composability, I'm not sure how to fix it properly. I'd probably wrap the contents in Ir_slice.t into something that make bin-prot happy.


⚠ ClamAV has degraded performance

In afe81fa, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in a174acf.


Parser tests

closes #5

Codecov Report
Patch coverage: 88.46% and project coverage change: -18.96 :warning:

Comparison is base (c324922) 74.76% compared to head (66e0421) 55.81%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #13       +/-   ##
===========================================
- Coverage   74.76%   55.81%   -18.96%
===========================================
  Files           4        4
  Lines         107      129       +22
===========================================
- Hits           80       72        -8
- Misses         27       57       +30

Flag
Coverage Δ

unittests
55.81% <88.46%> (-18.96%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

enjoy_slurm/slurm.py
32.14% <0.00%> (-21.43%)
:arrow_down:

enjoy_slurm/utils.py
61.61% <95.83%> (-20.21%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Support for adding plugins to Slate

Thanks for a lovely framework and a nice job on the first video. Really hope you guys will get more traction soon 🤞 At least I'm recommending it to any client that will hear it.
Feature Request
I've found old commit messages (https://github.com/payloadcms/payload/search?q="slate-plugin"&type=commits) where apparently slate-plugins (https://github.com/udecode/slate-plugins) was working with PayloadCMS. They've been working hard over there and are now at their first 1.0.~ (although still alpha) release. I was wondering if we can bring back support for integrating them or opening up more ways to connect with the SlateJS editor instance, also f.e. to hook into event listeners.
Use-Case
See the examples at https://slate-plugins-next.netlify.app/?path=/story/docs-intro--page
Additional Detail
Wondering why the integration was removed? Adding a separate parameter for the plugins on the richText field (not on the element- or leaf-level) could really open up a lot of extra possibilities.
I believe the integration should be made into src/admin/components/forms/field-types/RichText/RichText.tsx. If there are no objections I might be able to send in a pull request.

Agreed, so far the rich text stuff has been pretty painful. We need a decent image plugin that integrates with the existing media library system. I want to do it myself but it takes more time than I have right now.

Hi @Ontopic! Thanks for the kind words and the suggestions regarding Slate plugins.
Our first Slate implementation did indeed rely on slate-plugins but we ultimately determined that we wanted to stick more closely to the slate core vs. jumping to an abstraction too quickly.
I will say that in no way are we against revisiting this though. We are totally interested in evaluating it again, especially if it were to be a simple and unobtrusive add vs. having to rearchitect our current approach entirely.
We would be THRILLED if you were to send in a PR. We would absolutely collaborate heavily as well.
@JarrodMFlesch helped implement slate-plugins in the first place and might have some weigh-in here as well.
@richardvanbergen we do have a media plugin, integrating with existing media libraries, on the way actually. I don't have a firm ETA but that is definitely something that will make its way into Payload itself very soon. Same with simple alignment options. Will do my best to push this up in priority as I also see its value for sure!
We also plan to release some helper components, along with documentation, that will ideally make it much easier and more straightforward to implement custom RTE elements / leaves on your own. The Rich Text editor is definitely going to be receiving some TLC over the next few weeks!

Thanks for your quick reply. As I've seen other devs write; it's refreshing how you guys approach things. CMS's used to be something dreadful, now it is (starting 🙃 ) to feel right.
I have a fork locally I could slowly try to incorporate in a pull-request ready format, but for now I think a quick win would already be to allow more access to the props being send to the SlateJS Editor instance, mostly the event handlers.
Another step we could also consider is making use of a render prop (https://reactjs.org/docs/render-props.html) to allow switching out the current Editor component for the slate-plugin's counter-part?

Absolutely. We've always wanted to work with a CMS with this approach and that's honestly what spawned Payload.
I'm definitely up for exposing as many props as necessary through the field's config to the Editable component. That should be fairly trivial to do really! Maybe like this:
{
  type: 'richText',
  admin: {
    editableProps: {
      // props go here
    }
  }
}

Then we could just spread the props. Boom.
As for a render function, at that point, it might make more sense to just provide your own component entirely for the field via our custom components API, as there would be a decent amount of custom wiring that you'd have to do within your render function and I'm not sure how clean that pattern would be after all is said and done. Not saying this definitively, just a thought that comes up for me.
All good stuff nonetheless. I like this convo.

A custom component is what I've been looking into, starting with your RichText component copy / past and import the modules I'm not touching it and wrap it. More props on the RichText component would already solve a lot. Abstracting away the actions needed by Payload to keep "in-touch" with Slate could be bundled in a singleton / service being send down to the custom component for the RichText field. That way you have the same as for other custom fields right now; if you wanna go wild, you're responsible for triggering the appropriate Payload events, like https://github.com/payloadcms/payload/blob/master/docs/admin/components.mdx#sending-and-receiving-values-from-the-form, except of course more actions would have to be called.
Just some wild thoughts though. A simple way to replace the component and add events would go a long way.

I think the main issue with using @udecode/slate-plugins specifically is that it requires a context provider and there's no way to wrap the editor with that context. Unless I'm misreading the documentation.


Aardvark graph view is ghosting

Viewing graphs of any complexity in the web interface results in ghosting of the graph after changes are made in the right panel. Typically I'm turning off Size by Connection and changing Search Depth and Labels.
The ghosting is most apparent if the graph area is zoomed in or out - then the copies of the graph are not directly on top of each other.  Without zooming you might notice a pixel / subpixel shift of labels.
Once the graph is ghosted - one copy remains active (can be zoomed, radial menus function) while the original graph remains static.
Seems easiest to reproduce if your first zoom happens after graph configuration changes are made and while the right panel remains open.  Just click on the graph behind the panel, use trackpad to zoom and the problem should become clear.
This is on Safari v11.0, Mac OSX 10.13, and both ArangoDB 3.2.3 and 3.2.6.
my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[ ] 3.1
[ X] 3.2
[ ] self-compiled devel branch

Mode:

[ ] Cluster
[ X] Single-Server

Storage-Engine:

[X ] mmfiles
[ ] rocksdb

this is a web interface-related issue:
I'm using the web interface with this browser:   Safari  running on this OS: OSX 10.13

Does not seem to occur in Chrome 67 under Windows 10. As soon as I change a dropdown field in the graph viewer settings, the change is applied immediately to the graph visualization. If I click Save, then the visualization is re-initialized it seems. Might therefore be an artifact in Safari (not clearing the background correctly?)

Tried reproducing on Windows 10 in Chrome 68: Ghosting seems to happen. In the third attempt, I could reproduce it.

Open GRAPHS and create one of the example graphs.
Click on the newly created Graph, open the right side panel and change one of the edit labels(Search Depth for example).
Save it and do not close the right side panel.

One copy seems active and other looks static with no labels.

Note: If we keep this graph for a while, for some reason the browser seems crashed.

Crashes may occur because of Sigma.js leaking memory over time, and eventually Chrome will run out of memory. At least that is what I remember seeing, and we even reported this problem upstream but no resolution so far AFAIK.

With ArangoDB 3.11 sigma.js has been replaced by vis.js. Hence closing this issue.


Fix nil logger specified by default with kv.Configuration

Coverage decreased (-0.02%) to 83.172% when pulling 35b65ba2e669d4addf4edeb566253593b2c478f5 on r/fix-default-nil-logger-kv-config into 6edd2de9c678c51ef4d4d91eb66d191e9d7190f5 on master.

Hey on my way to a soccer game now but this means any config that has no logger defined will use nillogger, which felt wrong, can you check with Xi for his logger use case on this? Probably it can be checked by the csclient and assign valid logger there


Machine-readable report

Feature request:
"It would be great if all the column names could be used as R variables
like, ReadsDeam(3term) is quite a challenge"

@bvernot for notifications :D

Yay!
On Thu, May 23, 2024, 17:33 Merlin Szymanski @.***>
wrote:

@bvernot https://github.com/bvernot for notifications :D
—
Reply to this email directly, view it on GitHub
https://github.com/mpieva/quicksand/issues/4#issuecomment-2127435880,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACHP64XVHZSBNUIHK5HS563ZDYD5BAVCNFSM6AAAAABIF46LJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXGQZTKOBYGA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Strange output from ASAN-enabled build

I have been experimenting with an ASAN-enabled build (using gcc) on Arch linux and getting output referring to memory leaks that I don't understand. I'm hoping someone can help me .
For example, here is an excerpt when running test_modeless.vim::
`=================================================================
==10741==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 760 byte(s) in 1 object(s) allocated from:
#0 0x7317bfcfd1aa in calloc /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:77
#1 0x7317bfa90c40 in _nc_setupterm (/usr/lib/libncursesw.so.6+0x40c40) (BuildId: 47a1c4fad4907f700970251886989a52e957fcc7)
#2 0x7317bfa911d5 in tgetent_sp (/usr/lib/libncursesw.so.6+0x411d5) (BuildId: 47a1c4fad4907f700970251886989a52e957fcc7)
#3 0x5a1b4e0499f2 in invoke_tgetent /home/john/vim_dev/linux/vim/src/term.c:2394
#4 0x5a1b4e0489c5 in set_termname /home/john/vim_dev/linux/vim/src/term.c:2019
#5 0x5a1b4dcd934c in did_set_term /home/john/vim_dev/linux/vim/src/optionstr.c:3838
#6 0x5a1b4dcdbf29 in did_set_string_option /home/john/vim_dev/linux/vim/src/optionstr.c:4552
#7 0x5a1b4dc81507 in do_set_option_string /home/john/vim_dev/linux/vim/src/option.c:2150
#8 0x5a1b4dc83522 in do_set_option_value /home/john/vim_dev/linux/vim/src/option.c:2409
#9 0x5a1b4dc85ff3 in do_set_option /home/john/vim_dev/linux/vim/src/option.c:2625
#10 0x5a1b4dc86870 in do_set /home/john/vim_dev/linux/vim/src/option.c:2705
#11 0x5a1b4dc7b4f5 in ex_set /home/john/vim_dev/linux/vim/src/option.c:1411
#12 0x5a1b4d8f1da3 in do_one_cmd /home/john/vim_dev/linux/vim/src/ex_docmd.c:2616
#13 0x5a1b4d8e599f in do_cmdline /home/john/vim_dev/linux/vim/src/ex_docmd.c:1028
#14 0x5a1b4e12a274 in call_user_func /home/john/vim_dev/linux/vim/src/userfunc.c:3201
#15 0x5a1b4e12be6f in call_user_func_check /home/john/vim_dev/linux/vim/src/userfunc.c:3374
#16 0x5a1b4e130c5a in call_func /home/john/vim_dev/linux/vim/src/userfunc.c:3998
#17 0x5a1b4e11dea6 in get_func_tv /home/john/vim_dev/linux/vim/src/userfunc.c:2038
#18 0x5a1b4e146c67 in ex_call_inner /home/john/vim_dev/linux/vim/src/userfunc.c:6227
#19 0x5a1b4e149d2d in ex_call /home/john/vim_dev/linux/vim/src/userfunc.c:6575
#20 0x5a1b4d8f1da3 in do_one_cmd /home/john/vim_dev/linux/vim/src/ex_docmd.c:2616
#21 0x5a1b4d8e599f in do_cmdline /home/john/vim_dev/linux/vim/src/ex_docmd.c:1028
#22 0x5a1b4d822176 in ex_execute /home/john/vim_dev/linux/vim/src/eval.c:7524
#23 0x5a1b4d8f1da3 in do_one_cmd /home/john/vim_dev/linux/vim/src/ex_docmd.c:2616
#24 0x5a1b4d8e599f in do_cmdline /home/john/vim_dev/linux/vim/src/ex_docmd.c:1028
#25 0x5a1b4e12a274 in call_user_func /home/john/vim_dev/linux/vim/src/userfunc.c:3201
#26 0x5a1b4e12be6f in call_user_func_check /home/john/vim_dev/linux/vim/src/userfunc.c:3374
#27 0x5a1b4e130c5a in call_func /home/john/vim_dev/linux/vim/src/userfunc.c:3998
#28 0x5a1b4e11dea6 in get_func_tv /home/john/vim_dev/linux/vim/src/userfunc.c:2038
#29 0x5a1b4e146c67 in ex_call_inner /home/john/vim_dev/linux/vim/src/userfunc.c:6227
...
`
There is more output like this but each report refers seems to stem from a call in term.c. Some reports talk about "Direct" leaks and others about "Indirect" leaks.
I am getting this type of output when running these tests:
test_modeless.vim
test_options.vim
test_paste
test_termcodes.vim
Do these reports need investigation or can they be ignored?
Thanks
John

That seems to come from libncursesw. We don't currently suppress this in lsan-suppress.txt. Hm, actually I am surprised, that it uses  libncursesw, we usually link against libtinfo, which is currently also included in the lsan-suppress file.
Note: there is also this comment in term.c: https://github.com/vim/vim/blob/91d26aa338224fd0370c75fac9dc062cdcd18470/src/term.c#L2392-L2393
so I suppose this might be expected and we don't need to worry about.


server should reconnect to it's XMPP server

The buddycloud-server should check if the XMPP server is still available and reconnect.
A pause between reconnect attempts would not be a bad idea (the server is quite agressive about reconnecting to the DB server)

Now that this is just implemented in node-xmpp...

Current version on crater.buddycloud.org is not reconnecting when the xmpp server is restarted.

buddycloud-server is not auto reconnecting when the XMPP server is restarted.

Is it node-xmpp 0.3.1? Give it up to 30s, there's a kind of exponential back-off.

Whatever is running when I restarted Prosody on crater last weekend.

Works for me on crater.


Uncaught TypeError: Cannot read property 'focus' of undefined

I met error when I use renderInputComponent API.
autosuggest.js:698 Uncaught TypeError: Cannot read property 'focus' of undefined
    at Object.onSuggestionClick [as onClick] (autosuggest.js:698)
    at Item._this.onClick (autosuggest.js:2941)
    at Object.ReactErrorUtils.invokeGuardedCallback (react-dom.js:9017)
    at executeDispatch (react-dom.js:3006)
    at Object.executeDispatchesInOrder (react-dom.js:3029)
    at executeDispatchesAndRelease (react-dom.js:2431)
    at executeDispatchesAndReleaseTopLevel (react-dom.js:2442)
    at Array.forEach (<anonymous>)
    at forEachAccumulated (react-dom.js:15423)
    at Object.processEventQueue (react-dom.js:2645)

Same here. Would be good if this can be fixed.

same error for me

renderInputComponent receives a ref in the component, this needs to be attached to your input component. I'm using MUI and this solves it:
const renderInputComponent = inputProps => {
  const { error, label, ref, ...rest } = inputProps

  return (
    <TextField
      error={!!error}
      label={label}
      fullWidth
      InputProps={{
        inputRef: node => {
          ref(node)
        },
      }}
      {...rest}
    />
  )
}

You can do this if you're using a basic HTML input tag:
<input ref={ref} />

same error for me. Downgrading to 9.4.2 fixed the issue but looking forward to a fix in the new version :)

`import React, { Component } from 'react';
import Radium from 'radium';
import './Person.css'
import styled from 'styled-components';
import Aux from '../../../hoc/Auxillary';
import PropTypes from 'prop-types';
// import Person from '../../../Persons/Person/Person';
import Auxillary from '../../../hoc/Auxillary';
class Person extends Component {
constructor(props){
super(props);
this.inputElementRef = React.createRef;
}
componentDidMount(){
this.inputElementRef.current.focus();
}
render() {
    return (
        //

        <Auxillary>

Hi,I am {this.props.name}! and I am {this.props.age} years old

{this.props.children}

            <input type="text"
            // ref = {(inputEle) =>this.inputElement=inputEle}
            ref={this.inputElementRef}
            onChange={this.props.changed}
            value={this.props.name} />
        </Auxillary>
        //

    )
}

}
Person.propTypes = {
name: PropTypes.string,
age: PropTypes.number
};
export default Person;`
Please help me someone
Advance Thanks for the HELP

const renderInputComponent = inputProps => {
const { error, label, ref, ...rest } = inputProps
return (
<TextField
error={!!error}
label={label}
fullWidth
inputRef={inputProps.inputRef}
{...rest}
/>
)
}

Use this

I get a typescript error when trying to use ref or inputRef:
property 'inputRef' does not exist on type 'InputProps

same issue for me . I get "Cannot read property 'focus' of undefined" error when I set focus on dropdown

     First define the object with the name of this.errorRef = {}; in constructor.

This is the textfield of Mui
<TextFieldInput
name='targetedAmount'
type='number'
required={true}v
alue={this.state.targetedAmount}
handleChange={(eventData) => {
this.setState({
[eventData.target.name]: Number(eventData.target.value)
})
}}
inputRef={input => (this.errorRef.targetedAmount = input)}
/>
And in your validate functioin use like this.
this.errorRef.targetedAmount.focus()

`import React, { Component } from 'react';
import Radium from 'radium';
import './Person.css'
import styled from 'styled-components';
import Aux from '../../../hoc/Auxillary';
import PropTypes from 'prop-types';
// import Person from '../../../Persons/Person/Person';
import Auxillary from '../../../hoc/Auxillary';
class Person extends Component {
constructor(props){
super(props);
this.inputElementRef = React.createRef;
}
componentDidMount(){
this.inputElementRef.current.focus();
}
render() {
    return (
        //

        <Auxillary>

Hi,I am {this.props.name}! and I am {this.props.age} years old

{this.props.children}

            <input type="text"
            // ref = {(inputEle) =>this.inputElement=inputEle}
            ref={this.inputElementRef}
            onChange={this.props.changed}
            value={this.props.name} />
        </Auxillary>
        //

    )
}

}
Person.propTypes = {
name: PropTypes.string,
age: PropTypes.number
};
export default Person;`
Please help me
Advance Thanks for the HELP

Material ui doesnot use the reference . It uses the inputRef.
this.inputElementRef = {} in constructor
and use this
inputRef = {(inputEle) =>this.inputElement=inputEle}

I got this error, but wasn't using any external library for the input.
What fixed it for me was adding focusInputOnSuggestionClick={false} to the AutoSuggest props. Seems like it's enabled by default and the component lost track of its own ref

@cameronblandford are you saying you're not using renderInputComponent at all? It doesn't matter whether it's an external library - this issue is usually caused by using renderInputComponent but not passing inputProps.ref correctly.
If you're not using renderInputComponent at all, can you please include some code demonstrating your issue? It's probably a separate problem, but it would be good to look into that.

I also encountered the same error in renderInputComponent, but I was able to avoid the error by using forwardRef.
🙅♂
const Input = (props: InputProps): JSX.Element => (
  <input {...props} />
);

🙆♂
const Input = forwardRef<HTMLInputElement, Omit<InputProps, "ref">>(
  (props: Omit<InputProps, "ref">, ref): JSX.Element => (
    <input {...props} ref={ref} />
  )
);


Selectors should contain an .inside() function

Description
Currently, it is only possible to determine whether an element occurs after or before a specific element. However, it is not easily possible to determine whether an element is "inside" a specific element.
For example, take the following document:
= Chapter 1 <C1>
This  is inside Chapter 1

== Section 1
This <OtherLabel> is inside Chapter 1 and Section 1, but not Section 2

== Section 2
And <YetAnotherLabel> is inside Chapter 1 and Section 2, but not Section 1

It becomes very difficult to determine whether an element is inside a chapter. This is especially true when combined with calls to state(), where one might be interested in seeing if a state update was made in a specific chapter or not.
Use Case
The primary use-case would be to determine whether or not an element is specifically inside another element. Take the following document as an example:
#let s = state("state", 0)

#let valueForChapter(chapter) = {
  locate(loc => {
    let tmp = query(selector(<StateUpdate>).after(chapter), loc)
    if tmp == () {
      // The chapter has no value associated. We'll return 0
      0
    }
    else {
      s.at(tmp.first().location())
    }
  })
}

Expected: 10 / Actual: #valueForChapter(
)

Expected: 0 / Actual: #valueForChapter(
)

Expected: 20 / Actual: #valueForChapter(
)

= H1

The value of H1 is 10
#s.update(10)
<StateUpdate>

= H2

This chapter does not have a value associated.

= H3

The value of H3 is 20
#s.update(20)
<StateUpdate>

With a .inside() method, it would become trivial to determine if H2 has a value associated to it or not. Without this method, one would need to use something like selector(<StateUpdate>).after(
).before(
), which in turn becomes problematic inside loops.

In principle, an .in() or .inside() method would theoretically only check whether or not something is displayed in place of the parent element. That is, I believe your use case doesn't really apply to selectors in general. What you're looking for is a selector that considers counter values, and I'm not sure if I'd call it "inside". More like counter equals, maybe? This'd need some thought, however.

@PgBiel Counter values would work for sections, but I think it would also be a nice generalization for when one element would be inside another (e.g. an element being inside a table)

I think inside would fit better to something that is actually inside the thing. E.g. when you have a heading with math
= Test $alpha$

$beta$

It would be nice to have a selector that could match the equation in the heading, e.g. to do things like
#show selector(math.equation).inside(heading): set text(font: "Something")

As far as I know this currently requires the more elaborate setup
#show heading: it => {
    show math.equation: set text(font: "Something")
    // set heading etc ...
}

I've opened a different FR to match specific list levels. That can of course be implemented by adding a list depth attribute to lists or something like that. But it can also be seen as an instance of this issue, although list nested inside list nested inside list not nested inside list: i. doesn't look quite nice, ii. allso requires a not nested selector.

Or perhaps this could be implemented like {n,m} in regular expressions, "lists that are exactly 2 times inside other lists", or "lists that are more than 2 times inside other lists", etc. selector(list).inside(heading, 2) or selector(list).inside(heading, (3, -1)). May be generalized to inside/outside as well as before/after, which can then be used to match things like "the third second level heading after the second first level heading" FWIW. Just thinking aloud, but it seems to me like a neat idea if it's not too crazy implementation-wise.


WIP: Switch to conda-forge

WIP to determine blockers for switching to conda-forge repo

[ ] Have you provided a meaningful PR description?
[ ] Have you added a test, reproducer or referred to an issue with a reproducer?
[ ] Have you tested your changes locally for CPU and GPU devices?
[ ] Have you made sure that new changes do not introduce compiler warnings?
[ ] If this PR is a work in progress, are you filing the PR as a draft?

It's impossible due to mismatch on linux headers of conda-forge stack (2.17) and dpcpp-llvm-spirv stack (2.28).


test-branch/execute-job/wrong-commit-sha-on-pr/5f1c7894-434e-4fb0-a057-be040bcb3733

PR for testing ef16890c4d2a5443159bbb2edf0a687c316df419

/canonical/self-hosted-runners/run-workflows 7ddef3959f187604fba5ae6db88ff44d9ebcdeeb


Add API method '/grid/session/info'

Add API method '/grid/session/info'. Returns session info( address, port, etc.) by session id

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   63.67%   63.67%
=======================================
  Files          21       21
  Lines         881      881
=======================================
  Hits          561      561
  Misses        277      277
  Partials       43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c918968...70820c4. Read the comment docs.

Merge pleas)

Merge pleas)
А ты сама не можешь? Только PR?

Спасибо! Да, мержить не могу, прав недостает)


ci: optimize glint

Signed-off-by: Long Dai<EMAIL_ADDRESS>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Use git diff to get all changed files.
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Is this work still ongoing?

Is this work still ongoing?

im in two minds about it
in ci its better that it checks all files - and this only runs in ci atm
that said - if we add this as a github hook then it becomes very useful - so i was leaving it on the back-burner for now

@daixiang0 @phlax can we decide to move forward or close this out? It's been 41 days stale, best not to park things that aren't going to be resolved soon.

sure.

@daixiang0 i think your change is broadly good here i just wanted to do some other things before landing it - ill reopen once i get to it


[QUESTION] 'Login failed for user' when using AD credentials

Question

We use mssql-jdbc-12.6.4 in Logstash to connect to MSSQL database, but we are facing authentication problem: Login failed for user 'domian\username'.
Here is the traceback:

Configuration with jdbc connection string:
input {
    jdbc {
        jdbc_driver_class => "com.microsoft.sqlserver.jdbc.SQLServerDriver"
        jdbc_driver_library => "/app/logstash/utils/jdbc/mssql-jdbc-12.6.4.jre11.jar"
        jdbc_connection_string => "jdbc:sqlserver://***:1433;databaseName=***;user=***\***;password=***;encrypt=true;trustServerCertificate=true;loginTimeout=30;"
        jdbc_user => "***"
        jdbc_password => "***"
        statement => "SELECT 1"
    }
}

We specify username in format <domain>\<username>.
We tried to connect to DB using sqlcmd util with the same parameters and authentication was successful:
sqlcmd -C -S "***:1433" -d "***" -U "***\***" -Q "SELECT 1"

Password:

------------
           1
(1 row affected)

Do you have any idea why authentication fails in case of using driver?
Thank you.

You'll need to use integratedSecurity=true, to login with the Windows account. And so, you'll need to logon to Windows using your domain user. Then you should supply a connection string that looks like the one below without the user/password.
jdbc:sqlserver://***:1433;databaseName=***;encrypt=true;trustServerCertificate=true;loginTimeout=30;integratedSecurity=true;.
OR you can also do the following below in your connection string to use your AD user to login. The connection string below uses NTLM and integratedSecurity=true:
jdbc:sqlserver://my-sql-server.mydomain.ad;integratedSecurity=true;authenticationScheme=NTLM;domain=mydomain.ad;user=domainUser;password=domainUserPassword;encrypt=false;trustServerCertificate=true;

Thank you for you answer. I tried your examples and in both cases behavior was the same: Message about failed logon is gone, but nothing happened then. After about 10 minutes of hanging I can see that "Connection reset by peer":

I also tried with authenticationScheme=JavaKerberos and result was the same.
I'm on linux and I have ticket granting ticket for user in klist. Domain controller port 88 (used for kerberos) is reachable as well as database port 1433.
Cannot really got why sqlcmd authenticates successfully (just providing to it user and password), but driver does not.

Could you grab me the SQL Server logs?
Also, just curious, does a basic SQL authentication work with the driver?
https://learn.microsoft.com/en-us/sql/relational-databases/performance/view-the-sql-server-error-log-sql-server-management-studio?view=sql-server-ver16

With basic SQL Authentication I got "Login failed for user '' ". Actually SQL Server belongs to customer, not us, but I'll try to ask them to provide the logs. Thank you for instruction.

While I'm waiting for the logs, I checked what network connections are established for the process that uses driver to figure out the reason of 10 minutes hanging. Using netstat -tupn | grep <PID> I can see that for the first ~ 1-2 minutes  it is connected to database to port 1433 and during all 10 minutes of hanging process has connection to domain controller / dns servers (it periodically changes) to port 53 using udp.
Port 53 of DC and DNS servers are all reachable (checked it with  telnet <server> <port>).
What it could be?
Tried with next jdbc string: jdbc:sqlserver://<ip>:1433;integratedSecurity=true;authenticationScheme=NTLM;domain=<mydomain>;user=<domainUser>;password=<domainUserPassword>;encrypt=false;trustServerCertificate=true;

For your connection attempts with the domain user, are you still setting the user in the format of <domain>\<username> still?
If you are, with the connection string below, try only doing <username> without the prepended domain.
jdbc:sqlserver://<ip>:1433;integratedSecurity=true;authenticationScheme=NTLM;domain=<mydomain>;user=<domainUser>;password=<domainUserPassword>;encrypt=false;trustServerCertificate=true;

Tried with and without prepended domain. Behavior is the same.

Any news on the server logs?

Here is log entries:
09/25/2024 11:07:02,Logon,Unknown,Login failed. The login is from an untrusted domain and cannot be used with Integrated authentication. [CLIENT: xx.xx.xx.xx]
09/25/2024 11:07:02,Logon,Unknown,SSPI handshake failed with error code 0x80090302<c/> state 14 while establishing a connection with integrated security; the connection has been closed. Reason: AcceptSecurityContext failed. The operating system error code indicates the cause of failure. The function requested is not supported   [CLIENT: xx.xx.xx.xx]

I was expecting a different error, because you were able to auth through sqlcmd and you mentioned you also had a successful klist.
Can you confirm again if your machine is properly domain joined (through some alternative command)? I'm guessing you already doubled checked further for domain problems after that log error message.

Yeah, checked this using kinit with same credentials and got TGT successfully. Do you have an idea how can I check it especially for NTLM authentication scheme?
Also I tried to grant all related permissions to JVM in security policy:
grant {
    // Permissions to access network resources
    permission java.net.SocketPermission "*", "connect,resolve";
    permission java.net.SocketPermission "*", "connect,resolve";

    // Permissions for NTLM or Kerberos authentication
    permission javax.security.auth.AuthPermission "doAs";
    permission javax.security.auth.AuthPermission "doAsPrivileged";
    permission javax.security.auth.kerberos.ServicePermission "*", "initiate";
};

This didn't help.

Do you have an idea how can I check it especially for NTLM authentication scheme?

No, I believe there isn't a way to check for that other than making a connection.
I'm wondering if it's a SPN issue. It shouldn't be because you're able to get TGT. Do you see the following in the SQL Server logs?
The SQL Server Network Interface library successfully registered the Service Principal Name (SPN)
OR
The SQL Server Network Interface library could not register the Service Principal Name (SPN)
We want it to say successfully registered the Service Principal Name (SPN).

Ok. Thank you. I asked customers about this messages.

Due to long delays in responses from the customer, I suggest to close this issue until new information comes from my side. Thank you for your assistance!

Hi, here is message from logs:
The SQL Server Network Interface library could not register the Service Principal Name (SPN) [ MSSQLSvc/SetverName:1433 ] for the SQL Server service. Windows return code: 0x200b, state: 15. Failure to register a SPN might cause integrated authentication to use NTLM instead of Kerberos. This is an informational message. Further action is only required if Kerberos authentication is required by authentication policies and if the SPN has not been manually registered.

hi @rnv812
Based on the error above it looks like @tkyc was right it's an issue with the SPN. Please make sure to register the SPN and verify in the logs that this was done successfully. . Then you will need to specify the SPN using the serverSpn connection property. Please see Setting the connection properties for a description of the property.
I would suggest using a standalone java app to test the connection here is an example of how to do that using NTLM.


css tweaks

I added some color and spacing tweaks to mostly Heading elements to make the sections on each page stand out a bit more, and might assist people in noticing content that is available on the site.

Looks good to me, if @gabek is fine with it, I'd merge this PR.

Looks good to me, if @gabek is fine with it, I'd merge this PR.

Looks good to me!

Looks good to me!


[Regression] Broken rendering on Need For Speed Carbon (demo)

Software information
Need For Speed Carbon demo version (also affect Street Racing Syndicate) at default settings.
System information

GPU: GTX 1050 Ti
Driver: 435.21
Wine version: 4.16-Staging
DXVK version: Job #893

Apitrace file(s)

Can't render apitrace on wine 4.16. But you can download NFS Carbon demo anywhere.

Log files

d3d9.log:
nfsc_demo_d3d9.log

dxgi.log: None

Issue
Need For Speed Carbon (tested on demo version) 3D rendering is broken with job #893. It's perfectly fine with job #891. This broken rendering is also happen in Street Racing Syndicate.

Please re-test.

It looks fine now.

Thanks.


doc: fix link in illegal markdown format

Rationale
The original document link is not a legal markdown format.
Detailed Changes
fix wrong format of link.
Test Plan
N/A

Thank you for your contribution. Merged.


Notify @clickot too

https://github.com/ungoogled-software/ungoogled-chromium-binaries/pull/401#issuecomment-1522153553

merci :)

Thanks, I'm currently a bit low on spare time :)


Disabling for local development

Is there a recommended system for disabling this plugin when running Gitbook locally? I only want to track analytics on the production/hosted version of my gitbook.
Thanks for the great plugin!

Eh... you'd better try this plugin:
https://www.npmjs.com/package/gitbook-plugin-analytics#config-contexts

Eh... you may try this plugin:
https://www.npmjs.com/package/gitbook-plugin-analytics#config-contexts


added zdf.de

Hey @LethalSnake1337 thanks for adding this :) looks good 👍 We recently added a new attribute to our unit tests today. Could you merge the latest master branch into your branch and run python -m scripts.generate_parser_test_files -p ZDF once again.

Hey @LethalSnake1337 thanks for adding this :) looks good 👍 We recently added a new attribute to our unit tests today. Could you merge the latest master branch into your branch and run python -m scripts.generate_parser_test_files -p ZDF once again.

Hey @MaxDall done 👍.

I added a summary selector and generated a new unit test


Moving shadow automation to LightShadow subclass

Just adding new ShadowLight ideas. More files to come.
SpotLightShadow is a subclass of LightShadow that reforms getter|setter for 'angle' to affect camera's fov on owner.
I not sure DirectionalLight needs it and maybe it's better to have only one AutoLightShadow for SpotLight.

Cleaning up this branch


Start on presence in sidebar

WIP towards #599
Subtasks:

[X] Define the new type for PresenceIndicator
[x] Dispatch an action when the presence updates
[x] Track the presence indicators on VZState
[ ] Implement the UI for the little circles

Hey @DaCatDude I got this mostly set up. Maybe you can take it from here with the UI! Good luck!

TODO from here:

[ ] Get the color to match
[ ] Get the presence circle to disappear when the user closes the file

V2

[ ] Get it to show for directories - if a user is in a file within a directory, show presence on that directory


Added NgrokConfiguration class

As discussed in #52
I additionally added 'lombok' to improve readability and avoid boilerplate. Its an compile-time annotation processor, if you don't know that already. I hope you are fine with that, when not I could remove it again. I not applied the given annotations everywhere, only in the classes I touched.
Let me know what you think about the code changes 😉

Sidenote: The NgrokRunnerWithConfigFileTest is failing on my side but I think this is not caused by my changes, or am I wrong?

Since I added a @ConditionalOnBean to the auto-configuration multiple MockTests are failing. I haven't already figured out how to fix them, they confuse me a bit.

Hi, fitst of all - big thanks for contribution 🙂 I think I managed to fix issues you were facing with, please check MR that I created into your fork (https://github.com/s-frei/ngrok-spring-boot-starter/pull/1). I put there also some explenations about what I did. If you will be ok with the changes please update this MR to kickoff CI and I will merge that and release new version 😁

Thanks again for your PR 😉 When contributing is always handled like this, I'm for sure willing to do more!
Where to discuss additional features? Should I just open an issue?
Sidenote: After merging your PR I applied Lombok where possible. Thought you would be fine with that since you haven't declined yet :)

One more time thanks for contribution! 😀 Glad to hear you are ready to help more, as you can already see, after diving into the code, there are things that can be improved 🙂 I just promoted new release v0.3.6 so your changes should be available in the central repository soon 😀 Regarding new ideas/features I think issues + MR would be enough.
And about this lombok, it's fine for me, I just didn't add it in the beginning and it stayed like this


Crashes - and crash reports / stack traces (Forms)

I have recently started seeing crashes, so I will post some crash reports / stack traces.

(BETA 37 on Simulator)

=================================================================
	Native Crash Reporting
=================================================================
Got a SIGSEGV while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.
=================================================================

=================================================================
	Native stacktrace:
=================================================================
	0x10a19f585 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_dump_native_crash_info
	0x10a193675 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_handle_native_crash
	0x10a1a6818 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_sigsegv_signal_handler_debug
	0x7fff5245b42d - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/usr/lib/system/libsystem_platform.dylib : _sigtramp
	0xc1100000bf800000 - Unknown
	0x113fc9676 - Unknown
	0x113cdda1f - Unknown
	0x10a1a9c39 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_jit_runtime_invoke
	0x10a2d7b67 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_runtime_invoke_checked
	0x10a2db4ce - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_runtime_invoke
	0x10a401ab2 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : xamarin_invoke_trampoline
	0x10a409cfb - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : xamarin_arch_trampoline
	0x10a40af02 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : xamarin_x86_64_common_trampoline
	0x7fff2599ef46 - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/GLKit.framework/GLKit : -[GLKView _display:]
	0x10a40b1ac - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : xamarin_dyn_objc_msgSendSuper
	0x113431b3a - Unknown
	0x10fe50056 - Unknown
	0x10a1a9c39 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_jit_runtime_invoke
	0x10a2d958e - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_runtime_try_invoke
	0x10a2db48f - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_runtime_invoke
	0x10a0571a8 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZL31native_to_managed_trampoline_50P11objc_objectP13objc_selectorPP11_MonoMethodj
	0x10a05bd84 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : -[__MonoMac_NSAsyncActionDispatcher xamarinApplySelector]
	0x7fff25781c30 - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/Foundation.framework/Foundation : __NSThreadPerformPerform
	0x7fff23bd4471 - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
	0x7fff23bd439c - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : __CFRunLoopDoSource0
	0x7fff23bd3b74 - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : __CFRunLoopDoSources0
	0x7fff23bce87f - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : __CFRunLoopRun
	0x7fff23bce066 - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : CFRunLoopRunSpecific
	0x7fff384c0bb0 - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices : GSEventRunModal
	0x7fff48092d4d - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/UIKitCore.framework/UIKitCore : UIApplicationMain
	0x1118aab1a - Unknown
	0x1112956c3 - Unknown
	0x1110f53e3 - Unknown
	0x10a1a9c39 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_jit_runtime_invoke
	0x10a2d7b67 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_runtime_invoke_checked
Thread started:  #35
	0x10a2ddfcc - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_runtime_exec_main_checked
	0x10a1098c2 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_jit_exec
	0x10a40919e - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : xamarin_main
	0x10a0c40d7 - /Users/tony/Library/Developer/CoreSimulator/Devices/A25E9696-1A38-42F9-A9C5-9D194A2D2135/data/Containers/Bundle/Application/84577257-CF3A-40A9-8D3A-0D848CF55247/HikeEmpire.iOS.app/HikeEmpire.iOS : main
	0x7fff5227ec25 - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/usr/lib/system/libdyld.dylib : start
	0x3 - Unknown

=================================================================
	Basic Fault Address Reporting
=================================================================
Memory around native instruction pointer (0x10ab61464):0x10ab61454  41 57 41 56 53 50 85 f6 b8 01 00 00 00 0f 4f c6  AWAVSP........O.
0x10ab61464  44 8b b7 30 11 00 00 41 29 c6 7e 67 49 89 ff 31  D..0...A).~gI..1
0x10ab61474  db 66 2e 0f 1f 84 00 00 00 00 00 90 49 8b 47 40  .f..........I.G@
0x10ab61484  8b 48 58 85 c9 7e 15 41 ff 8f 30 11 00 00 ff c9  .HX..~.A..0.....

=================================================================
	Managed Stacktrace:
=================================================================
	  at <unknown> <0xffffffff>
	  at SkiaSharp.SkiaApi:sk_canvas_restore_to_count <0x00135>
	  at SkiaSharp.SKCanvas:RestoreToCount <0x000a2>
	  at SkiaSharp.SKAutoCanvasRestore:Restore <0x000aa>
	  at SkiaSharp.SKAutoCanvasRestore:Dispose <0x00072>
	  at SkiaSharp.Views.iOS.SKGLView:DrawInRect <0x00c0e>
	  at <Module>:runtime_invoke_void__this___object_CGRect <0x0045e>
	  at <unknown> <0xffffffff>
	  at ObjCRuntime.Messaging:void_objc_msgSendSuper <0x000e9>
	  at GLKit.GLKView:Display <0x001c2>
	  at SkiaSharp.Views.Forms.SKGLViewRenderer:SetupRenderLoop <0x00216>
	  at SkiaSharp.Views.Forms.SKGLViewRendererBase`2:OnSurfaceInvalidated <0x000f8>
	  at SkiaSharp.Views.Forms.SKGLView:InvalidateSurface <0x000bf>
	  at Foundation.NSAsyncActionDispatcher:Apply <0x0006e>
	  at System.Object:runtime_invoke_void__this__ <0x000e5>
	  at <unknown> <0xffffffff>
	  at UIKit.UIApplication:UIApplicationMain <0x00259>
	  at UIKit.UIApplication:Main <0x000b2>
	  at UIKit.UIApplication:Main <0x00132>
	  at HikeEmpire.iOS.Application:Main <0x00092>
	  at <Module>:runtime_invoke_void_object <0x00198>
=================================================================
Thread started:  #36
Thread started:  #37
Thread started:  #38
Thread started:  #39

(BETA 37 - on Device (iPhone XS Max))

=================================================================
	Native Crash Reporting
=================================================================
Got a SIGSEGV while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.
=================================================================

=================================================================
	Native stacktrace:
=================================================================
	0x105b0dec4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZNK3AAT11FeatureName16get_feature_typeEv
	0x105b03d84 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZNK3AAT11FeatureName16get_feature_typeEv
	0x105b125f8 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_pmip
	0x19ebd7434 - /usr/lib/system/libsystem_platform.dylib : <redacted>
	0x105169f18 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x105169f18 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x1050624bc - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x10506fbb0 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x10506fadc - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x105012038 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x1014618c4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x105b15a20 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_pmip
	0x105bd45cc - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_pmip
	0x105bd7e5c - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_pmip
	0x100b54408 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x100babb2c - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x1c8b80da8 - /System/Library/Frameworks/GLKit.framework/GLKit : <redacted>
	0x105cfca98 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZN16XamarinCallState3selEv
	0x105cfba38 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZN16XamarinCallState3selEv
	0x105ce6fbc - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZN16XamarinCallState3selEv
	0x105ce7aa4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZN16XamarinCallState3selEv
	0x105ce76f4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZN16XamarinCallState3selEv
	0x105ce76f4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZN16XamarinCallState3selEv
	0x105ce6e6c - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZN16XamarinCallState3selEv
	0x105ce6e6c - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZN16XamarinCallState3selEv
	0x105ce6e6c - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZN16XamarinCallState3selEv
	0x105ce50a4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZN16XamarinCallState3selEv
	0x101489cd8 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x101524298 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x103634f74 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x1014618c4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x105b15a20 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_pmip
	0x105bd45cc - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_pmip
	0x105bd7e5c - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_pmip
	0x100b32f70 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x100b37c1c - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x19ebe4a4c - /usr/lib/libobjc.A.dylib : <redacted>
	0x19f2c5c00 - /System/Library/Frameworks/Foundation.framework/Foundation : <redacted>
	0x19ee4c108 - /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : <redacted>
	0x19ee4c05c - /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : <redacted>
	0x19ee4b7c8 - /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : <redacted>
	0x19ee46694 - /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : <redacted>
	0x19ee45f40 - /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation : CFRunLoopRunSpecific
	0x1a90d6534 - /System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices : GSEventRunModal
	0x1a2fd1580 - /System/Library/PrivateFrameworks/UIKitCore.framework/UIKitCore : UIApplicationMain
	0x103cb0ea0 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x10341bd6c - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x10341bbf4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x100bcbca4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x1014618c4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x105b15a20 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_pmip
	0x105bd45cc - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_pmip
	0x105bda888 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : mono_pmip
	0x105af39b4 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : _ZNK3AAT11FeatureName16get_feature_typeEv
	0x105ce36c0 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : xamarin_localized_string_format_9
	0x100bcbb78 - /private/var/containers/Bundle/Application/A61FF945-BAF6-4D34-BB5C-57DEDA54577D/HikeEmpire.iOS.app/HikeEmpire.iOS : (null)
	0x19ecc4e18 - /usr/lib/system/libdyld.dylib : <redacted>

=================================================================
	Basic Fault Address Reporting
=================================================================
Memory around native instruction pointer (0x106a16224):0x106a16214  fd 7b 02 a9 fd 83 00 91 3f 04 00 71 28 c4 9f 1a  .{......?..q(...
0x106a16224  09 30 51 b9 34 01 08 4b 9f 06 00 71 4b 04 00 54  .0Q.4..K...qK..T
0x106a16234  f3 03 00 aa 15 00 80 52 68 22 40 f9 09 59 40 b9  .......Rh"<EMAIL_ADDRESS>0x106a16244  29 05 00 71 2b 01 00 54 6a 32 51 b9 4a 05 00 51  )..q+..Tj2Q.J..Q

=================================================================
	Managed Stacktrace:
=================================================================
	  at <unknown> <0xffffffff>
	  at SkiaSharp.SkiaApi:sk_canvas_restore_to_count <0x00007>
	  at SkiaSharp.SKCanvas:RestoreToCount <0x0008b>
	  at SkiaSharp.SKAutoCanvasRestore:Restore <0x0008f>
	  at SkiaSharp.SKAutoCanvasRestore:Dispose <0x0005b>
	  at SkiaSharp.Views.iOS.SKGLView:DrawInRect <0x00997>
	  at System.Object:runtime_invoke_dynamic <0x00103>
	  at <unknown> <0xffffffff>
	  at ObjCRuntime.Messaging:void_objc_msgSendSuper <0x00022>
	  at GLKit.GLKView:Display <0x00062>
	  at SkiaSharp.Views.Forms.SKGLViewRenderer:SetupRenderLoop <0x00062>
	  at SkiaSharp.Views.Forms.SKGLViewRendererBase`2:OnSurfaceInvalidated <0x00026>
	  at <Module>:invoke_void_object_EventArgs <0x00086>
	  at SkiaSharp.Views.Forms.SKGLView:InvalidateSurface <0x00026>
	  at <Module>:invoke_void <0xffffffff>
	  at <unknown> <0xffffffff>
	  at System.Object:__interp_lmf_mono_interp_entry_from_trampoline <0x00007>
	  at Foundation.NSAsyncActionDispatcher:Apply <0x00023>
	  at System.Object:runtime_invoke_dynamic <0x00103>
	  at <unknown> <0xffffffff>
	  at UIKit.UIApplication:UIApplicationMain <0x00007>
	  at UIKit.UIApplication:Main <0x0002b>
	  at UIKit.UIApplication:Main <0x00043>
	  at HikeEmpire.iOS.Application:Main <0x000a3>
	  at System.Object:runtime_invoke_dynamic <0x00103>
=================================================================

I have more, but they are very similar!

hmm, there is no Mapsui involved at all.

What do you do when it happens?

These are on iOS. Do you have the same crashes on Android?

I pan around the map, zoom in and out.
I can try disabling all my custom layers, and see if that makes any difference ?

These are on iOS. Do you have the same crashes on Android?

I have not tested on Android - let me just make a few runs on an actual device!

I cannot crash the app on Android - so far so good :-)

Thanks for testing on Android. Since you use Forms this means our code is identical on iOS and Android, so this is hard to explain.

I can try disabling all my custom layers, and see if that makes any difference ?

Please do, we need to get to the bottom of this.
Possible causes:

We do some disposing in another thread that crashes the rendering.
Too much resources are used. Perhaps skia/opengl starts using resource reuse or other tricks to cope with the amount of resources used.
A bug in SKGLView iOS.
A combination of the above (Perhaps we use Dispose properly but it crashes because of a bug).

Saw this crash today too, but only when in debug mode. On release I didn't see it.

Morning. Started testing the crash with a much smaller route - its 3k points compared to the 83k points route I have tested on so far.
Sadly, I made the app crash again in the first try ....
iOS13, on iPhone XS Max, debug build

Could you please check release build too? Thanks.

I have had it crash in release build before, but yes - I will test in release build too 👍

Hello, I also started seeing those crashes recently - but on Android.
At first there was a segfault somehow related to Mono runtime when zooming/panning the map, but it could only occur in debug mode, because there was no such library in release build. However, I have seen multiple crashes in release build as well, not only the suspected Mono runtime crash (which might be happening in method in SkiaSharp with the same address), but also more SkiaSharp crashes (0x40 and 0x1110 addresses). I cannot locate the method with such address with addr2line tool.
There were no crashes in SkiaSharp 1.60.3, which was used previously in Mapsui, as far as I remember. Mapsui switched from canvas to SKGL renderers since beta35, which requires using SkiaSharp 1.68+ due to native Android support (missing draw event in 1.60.3).
You need to report those crashes to SkiaSharp developers - creating an issue. Then post the link here and I'm gonna add my reports to the issue as well.

I'm returning to SKCanvas in my fork until this is fixed, I can talk out of bad performance and/or do some scaling, but cannot present such common crashes to our customers. Right now, the app seems to crash around every 30 seconds, sometimes even a few seconds after it is started.

I'm returning to SKCanvas in my fork until this is fixed, I can talk out of bad performance and/or do some scaling, but cannot present such common crashes to our customers. Right now, the app seems to crash around every 30 seconds, sometimes even a few seconds after it is started.

Thanks for reporting this back, its very usefull info for me.
The crashes you see, do they occur even without panning/zooming or is only when using the app ?

My company has its own fork, because we had to add a lot of event handlers in Android MapControl to make it possible to make drawings in the map, so we don't have to rollback, we just change two lines in MapControl.cs on Android.
Yes, Forms always used SKGL. Have you seen such crashes before, or they started appearing since let's say beta33 or where the switch to higher SkiaSharp version was made? I haven't used Forms version since beta25 I guess and it was quite stable back then, only issue being some white glitches/flickering.
So my guess is, there is a problem with SKGL, which appeared in SkiaSharp 1.68+ and causes those crashes.

I started seeing them recently, so it makes sense that it might be the change in SkiaSharp version that is causing it 👍
I will try rolling back to an earlier version of the beta, and see if the crashes are disappearing.

Yes, it's beta 28.

I tested this evening with the SkiaSharp 1.68.2-preview.39 on iOS and Android and could not see any such crash. I always use the Forms implementation to test. Mostly with the release version, but with the debug version too. I moved 5 min around on iOS with my vector map, but get no crash.
So three suggestions:

I used a younger version of SkiaSharp, which hasn’t this problem.
The Forms implementation does something different from the normal version.
You make something else different.

I try in the next day to reproduce the problem here.

Preview 39 was by far the most crashing version for me.

<IP_ADDRESS> looks most stable, I got like one crash in half an hour when testing it on old Lollipop tablet today.

Canvas is not usuable with the Scale method, IgnorePixelScaling looks terrible, I hope it gets fixed sooner than later. Would file in the report tomorrow, hopefully you, Paul and this issue's author can confirm it, so they will be more likely to care.

I only test on Forms implementation - this is where I see the crash, only on iOS.
Yeserday I downgraded everything to beta 28 - was kind of a hastle, as Skiasharp was used in other packages too, but now I am running on the beta 28 version.
I have not seen some crashes yet, but will continue testing throughout the day 👍

https://github.com/mono/SkiaSharp/issues/1173
Please report your stack traces there as well.

My crashed are iOS only - you still think I should report them in that issue ?

Yes, but tell them it was iOS.

hi all, Friday is the day I usually have some time for Mapsui. Today it will be less because the children are at home (they are sneezing and are not allowed because of corona). There are several issues going on at the same time. We should be able to take them apart.
One thing. The next release of Mapsui Android will have the option to switch between SKCanvasVies and SKGLView during runtime. The iOS version will have to wait for the release after that.
The rasterlayer useses a lot of memory, this could be reduced.
The various versions of SkiaSharp might have different problems. I will upgrade to the latest and we should try to isolated the issues and report on it.

The corona thing is really triggering my anxiety disorder to the point where I'm almost unable to work, hope your children will be ok.
a) Good, we will give our users the ability to choose what they prefer.
b) Haven't used yet and probably won't use anyway.
c) 1.68.0 looks stable, didn't have a single crash till now (with my luck in recent days, it will crash the very moment I will try it next time :-D). I reported issues with <IP_ADDRESS> - last stable version. Preview39 version is the least stable at the moment, crashes about every 5 seconds.

I can report that I have been running/developing on beta 28 for over 1 day now, which means SkiaSharp 1.68.0 - and I have had NO crash since that, using primary rasterlayers.

Been running beta 28 for 4 days now, with absolutely NO crashes - GREAT - but not sure how I can progress from this - I cannot stay on beta 28 forever ?
@pauldendulk Any idea what I can do ?

I talked to SkiaSharp author and he said that they changed memory management in 1.68.1. it should be faster, but not very stable at the moment, as there are some random bugs and they are working on fixing them in new version. I recommend to switch Mapsui back to 1.68.0. Better slower than unstable.

Ok, so you recommend @pauldendulk to go back to SkiaSharp 1.68.0 ?
But I guess he must have upgraded for a reason, so it might not be that easy to roll back ...

No, i think the only reason to udpate is performance - 1.68.0 is much slower with rotated map.

Ohhh okay. But I agree with you "Better slower than unstable" 👍

You can see at https://github.com/mono/SkiaSharp/issues/1121 that we are not alone. It is a common known problem. Btw. in some of my tests I couldn’t reproduce the crash.
I need parts of 1.68.1, so I don‘t want to go back to 1.68.0.

Maybe it's getting fixed this week, looking at the 1121 issue.

Hi folks, I am looking at this issue now and I was just wondering if you know what platforms these re occurring on? I have a few reports, but it appears to be on the macOS and iOS platforms. The was a report of Windows, but that was just one and it looks a tiny bit different.
Do you know which platforms seem to have this issue?

Hi @mattleibow - that so GREAT news, thanks!
I have only seen this on iOS - it was very consistent, I could get it to crash within a few minutes again and again - when I then launched my Addroid version, which is same code (due to Xamarin.Forms) I did the same on the app, but no crashes.
Thanks for looking into this 👍

Not sure if @hajmajeboss did have any crashes on Android. Mapsui is not used on macOS.

Xamarin.Android version crashes with Skia 1.68.1+ about every 5 seconds to one minute.

Haven't seen any crash with.1.68.0

About downgrading. This is not something I want to spend my time on right now. Also it becomes really hard to keep track of bug reports with . What I can do is allow the option to use the non-GL canvas so users can just select that one (it will be the default). The non-GL version of 1.68.1 has been in prerelease for quite a while and there were no crash reports during that period.

OK, I'm staying with 1.68.0 and GL at the moment in my fork and hope for fix from SkiaSharp devs.

What I can do is allow the option to use the non-GL canvas so users can just select that one (it will be the default).

But this does not affect the Xamarin.Forms implementation, correct ?

Well. Perhaps we need to add it there too. But that will be a bigger change.

I don‘t want to do this. It seems to be a general problem with SkiaSharp, that @mattleibow is aware, so I would wait.
And @pauldendulk, you could use the Forms implementation on MacOS, even if I haven‘t tested it.

Just to keep you folks in the look. I have a PR that I am working on to fix this. I believe I have located the issue and got a solution - along with other improvements that I made when trying to find this issue.
I got a preview out for macOS, and the iOS fix is building on CI. My Android is just waiting on some local testing, but that is building as I am "confident". As soon as the build completes, I will push it to the preview feed and you folks can do some testing. Hopefully I have found the same issue that everyone is having and we can all be happy.

@mattleibow great. I can test as soon as it is out.

Just to keep you folks in the loop. I have a PR that I am working on to fix this. I believe I have located the issue and got a solution - along with other improvements that I made when trying to find this issue.

That is absolutely fantastic news - thank you @mattleibow  👍

@pauldendulk @tonyfonager  I have just published the PR (https://github.com/mono/SkiaSharp/pull/1180) NuGet (1.68.2-pr.1180.1) to the preview feed: https://aka.ms/skiasharp-eap/index.json
This contains the fixes for macOS, iOS and Android. More platforms coming soon.
Give that a go and let me know if it fixes the crashes.

Working on it. Having some trouble with downgrade errors but i will get there.

@tonyfonager @hajmajeboss @charlenni I pushed a branch with 1.68.2-pr.1180.4: https://github.com/Mapsui/Mapsui/tree/research/skiasharp-1.68.2-pr.1180.4
It solved the problem I ran into. Perhaps you can check if it solves yours?

I assume I should download and compile that branch of Mapsui myself, and then change my project to use Mapsui as a referenced project - instead of NuGet ?

I only change my Skia version, but our company has different nuspec.

I have issues compiling that branch :

Restoring NuGet package SkiaSharp.Views.Forms.1.68.2-pr.1180.4.
GET https://api.nuget.org/v3-flatcontainer/skiasharp.views.forms/1.68.2-pr.1180.4/skiasharp.views.forms.1.68.2-pr.1180.4.nupkg
NotFound https://api.nuget.org/v3-flatcontainer/skiasharp.views.forms/1.68.2-pr.1180.4/skiasharp.views.forms.1.68.2-pr.1180.4.nupkg 144ms
Unable to find version '1.68.2-pr.1180.4' of package 'SkiaSharp.Views.Forms'.
https://api.nuget.org/v3/index.json: Package 'SkiaSharp.Views.Forms.1.68.2-pr.1180.4' is not found on source 'https://api.nuget.org/v3/index.json'.

@tonyfonager
You have to add the feed to visual studio
https://aka.ms/skiasharp-eap/index.json
Tools -> Options -> Nuget Package Manager -> Package Sources ->Klik + top right -> Choose a name and add as Source: https://aka.ms/skiasharp-eap/index.json

Dohhh ofcourse - just assumed "aka.ms" was a shortcut for nuget.org, my mistake.
It works now - uhhhh, this is exiting .... 👍

Just want to add in a little "hurrraayyyyy" - I think we have a winner 🥇
I have only tested for 15-20 min now, but NO CRASH has happend so far ...

I don't want to jinx anything, but maybe a little yee is in order?

In these dark corona days, I think this qualifies as for a celebration 🎉

So to summarize, what is the solution? Does beta38 have the ability to disable the hardware rendering?

@spaddlewit beta.28 has a render mode voor Android (non-forms), which is default in software mode. There is no such switch for iOS (not enough time this week). A PR is welcome if it follows the same setup as Android.
Also, it might be a good idea to wait for the skiasharp release.

@spaddlewit @tonyfonager @hajmajeboss Mapsui 2.0.0-beta-39 is out with the new and fixed skiasharp version.

Thanks, will test it right away 👍

Upgrade went smoothly without any issues - thanks for the update, @pauldendulk 👍
I guess this update also includes the new "pixel perfect" rasterizing layer fix ?

Just an FYI, I pushed out a NuGet.org update for 1.68.2-preview.45 yesterday that should fix these GL crashes.

@mattleibow I got up at 6 this morning to publish a new release with preview.45 😁
https://www.nuget.org/packages/Mapsui/2.0.0-beta.39

I guess this update also includes the new "pixel perfect" rasterizing layer fix ?

Yes it does

Just an FYI, I pushed out a NuGet.org update for 1.68.2-preview.45 yesterday that should fix these GL crashes.

Wow, you have some really long, complex release labels going on there @mattleibow 😮 🎉

I have another, better fix (hopefully) that will actually address the underlying issue. What was happening before was the surface.Canvas was creating a new object, the GC would collect and then the drawing would create a new one. This resulted in the SKCanvas object sometimes being created during the GC. This caused issues when either the creation was immediately disposed, or the disposing the wrong object. This was all a result of a change that did not correctly lock the part between the search an then creation as well as the disposal/creation not being atomic operations.
The first fix (https://github.com/mono/SkiaSharp/pull/1180) just cached the canvas and others so that this would never happen.
The new fix (https://github.com/mono/SkiaSharp/pull/1200) now correctly locks the creation/disposal/search so that the first issue can't happen.
But, as a result of part 1 and part 2, we have better caching for the canvas, and a fix for the concurrency.

Hmm, I wonder if this also fixes #838  !

But, as a result of part 1 and part 2, we have better caching for the canvas, and a fix for the concurrency.

Will that make stuff faster ? ;-)

@pauldendulk said that the best option to make it faster is caching skia geometries. If he can elaborate more, what it means, I could try to implement it, because performance is biggest issue for our team right now - we will be rendering tons of polygons and labels and rasterizing is not the way I want to go, especially when I can see OpenLayers giving absolutely smooth experience with the same functionality on JS canvas. I'm willing to help with the optimization as long as my knowledge about Skia allows me to - and sadly, I have almost none at the moment, because I was more of a enterprise information systems guy before this project :-D) I also submited an issue to SkiaSharp repo, because I feel that preview45 is quite slower in compare with <IP_ADDRESS>, but I'm not absolutely sure that @mattleibow could reproduce it, because it's happening only on one of my phones.

The most time consuming part is to convert Mapsui geometries to Skia pathes. This is done each time, the feature is rendered. Perhaps it is possible to prerender or save the rendered path in Feature.RenderedGeometry. Perhaps this is a good place to start optimizations.

So RenderedGeometry is not used at the moment? I guess I should create an issue, try to work it out and do a PR, but I will definitely need some help.

Took a look at it - if I could somehow cache SkiaPath, then it will be quite faster, right? But that would also require to dump the RenderedGeometry once Geometry is changed and also caching features in my database provider, because recreating them everytime would still mean that there would be new SkiaPath created. It will be breaking change though, as there is only Geometry passed inside PolygonRenderer Draw method. But if that's it, then I'm doing it tomorrow at work.

Did you tried owner drawn styles and do the drawing by yourself?

I did try it, but only to rotate canvas and use label renderer then.

Hey folks, it has been a long time coming and thanks to all the folks with your repros, samples and stack traces I think we have finally managed to fix those pesky crashes - at least the ones we know about. I have just pushed 1.68.2-preview.50 to NuGet so let me know if this fixes all the crashes you have ever had 😄

@tonyfonager @hajmajeboss @mattleibow Release Mapsui 2.0.0-rc.2 with SkiaSharp preview 50. https://www.nuget.org/packages/Mapsui/2.0.0-rc.2

No further reports. Assumed fixed.


Core command subscribes to 3rd Party command requests and publishes requests to the appropriate device service via messaging

Core command to receive (subscribe) to 3rd party command requests via external MQTT subscription, transform the requests to internal message bus command requests to be given to a specific device service, and publish the message to the internal message bus topic to be consumed by the correct device service

resolved by #4153


APEXMALHAR-2354 Support for heuristic watermark

@davidyan74 @chinmaykolhatkar Please see.

@bhupeshchawda Can you please rebase your branch? There seems to be some conflict in the code.

@chinmaykolhatkar done

This looks good. I'll merge it shortly.


Create Sliding Window Maximum

Solution of leetcode question 239 Sliding Window Maximum

@Shweta2254
Great 🚀
You can follow  me and star this repo for further updates.
Have fun!