Failed to loat gazebo_ros_controll.dll

When I launch my launch file, error 'Failed to load gazbo_ros_control.dll' is occur.
There are 'gazebo_ros_control.dll' & 'gazebo_ros_control.lib' in "C:\opt\ros\melodic\x64\lib"
I confirmed that the package is in "C:/opt/ros/melodic/x64\share\gazebo_ros_contro"l using the command 'rospack find gazebo_ros_control'.
How can I fix this error?
Here is my launch file.

<group ns="/mrm">
    <!-- Robot Model-->
    <arg name="model" default="$(find mrm_description)/urdf/mrm.xacro"/>
    <arg name="x" default="0"/>
    <arg name="y" default="0"/>
    <arg name="z" default="0.5"/>

    <param name="robot_description" command="$(find xacro)/xacro $(arg model)" />

    <!-- Spawn the robot model -->
    <node name="mybot_spawn" pkg="gazebo_ros" type="spawn_model" output="screen"
        args="-urdf -param robot_description -model mrm -x $(arg x) -y $(arg y) -z $(arg z)"/>

    <!-- Load Controllers -->
    <rosparam command="load" file="$(find mrm_description)/config/joints.yaml"/>

    <!-- Controllers -->
    <node name="controller_spawner" pkg="controller_manager" type="spawner"
        respawn="false" output="screen" ns="/mrm"
        args="--namespace=/mrm
        joint_state_controller
        joint1_position_cotroller
        joint2_position_cotroller
        --timeout 60">
    </node>
</group>

and this is my xacro file

<!-- BGN - Robot Discription -->
<m_link_box name="${l00}"
            origin_rpy="0 0 0" origin_xyz="0 0 0"
            mass ="1024"
            ixx="170.667" ixy="0.0" ixz="0.0"
            iyy="170.667" iyz="0.0"
            izz="170.667"
            size="1 1 1" />

<m_joint name="${l00}__${l01}" type="revolute"
         axis_xyz="0 0 1"
         origin_rpy="0 0 0" origin_xyz="0 0 0.5"
         parent="${l00}" child="${l01}" />

<transmission name="trans_${l00}_${l01}">
    <type>transmission_interface/SimpleTransmission</type>
    <joint name="${l00}__${l01}">
        <hardwareInterface>hardware_interface/EffortJointInterface</hardwareInterface>
    </joint>
    <actuator name="motor_${l00}_${l01}">
        <hardwareInterface>hardware_interface/EffortJointInterface</hardwareInterface>
        <mechanicalReduction>1</mechanicalReduction>
    </actuator>
</transmission>

<m_link_cylinder name="${l01}"
            origin_xyz="0 0 0.2" origin_rpy="0 0 0"
            mass ="157.633"
            ixx="13.235" ixy="0" ixz="0"
            iyy="13.235" iyz="0"
            izz="9.655"
            radius="0.35" length="0.4" />

<m_joint name="${l01}_${l02}" type="revolute"
         axis_xyz="0 1 0"
         origin_rpy="0 0 0" origin_xyz="0 0 0.4"
         parent="${l01}" child="${l02}" />

<transmission name="trans_${l01}_${l02}">
    <type>transmission_interface/SimpleTransmission</type>
    <joint name="${l01}__${l02}">
        <hardwareInterface>hardware_interface/EffortJointInterface</hardwareInterface>
    </joint>
    <actuator name="motor_${l01}_${l02}">
        <hardwareInterface>hardware_interface/EffortJointInterface</hardwareInterface>
        <mechanicalReduction>1</mechanicalReduction>
    </actuator>
</transmission>

<m_link_cylinder name="${l02}"
            origin_xyz="0 0 0.4" origin_rpy="0 0 0"
            mass ="57.906"
            ixx="12.679" ixy="0" ixz="0"
            iyy="12.679" iyz="0"
            izz="0.651"
            radius="0.15" length="0.8" />
<!-- END - Robot Discription -->

<gazebo>
    <plugin name="gazebo_ros_control" filename="libgazebo_ros_control.so"/>
</gazebo>

Hi @OnesoulKang,
I'd like to reproduce this locally. Can you post the commands to setup a workspace? (including clone locations)
@seanyen-msft I don't recall - do we automatically remap Linux filenames to Windows? (I see a libgazebo_ros_control.so in the Xacro)

@OnesoulKang one way to debug it is to use process monitor to watch where does the gazebo looks for the DLL.
@ooeygui yes, the Gazebo does the trick to remap the so to dll internally if it is Windows system. My guess would be search path issue.

@ooeygui
I don't know much about this field, so I think it'd be nice if you could give me some more details on what I should tell you.
I usually use this commands to set my working environment.
c:\opt\ros\melodic\x64\setup.bat
c:\catkin_ws\devel\setup.bat

@OnesoulKang On a second look at your launch file, can you add something like below: You can see an example here:
  <env name="GAZEBO_PLUGIN_PATH" value="$(find gazebo_plugins)"/>

Gazebo honors %GAZEBO_PLUGIN_PATH% to search the plugin DLLs.

@seanyen-msft
Thank you for your answer.
but after I add the command, the same error still occurs.
The path I have identified by "rospack find gazebo_plugins" is "C:/opt/ros/melodic/x64\share\gazebo_plugins".
There are several files in the folder.

@OnesoulKang hmm, can you modify my example and add C:\opt\ros\melodic\x64\lib to GAZEBO_PLUGIN_PATH:
<env name="GAZEBO_PLUGIN_PATH" value="C:\opt\ros\melodic\x64\lib"/>

In general, plugin DLL paths need to be added in GAZEBO_PLUGIN_PATH.

@OnesoulKang No worries. In order for me to reproduce it locally, I need to setup a catkin workspace just like yours. For example, can you send me the git setup instructions?
For example, in our UR3 docs, we have this:
c:\opt\ros\melodic\x64\setup.bat
mkdir c:\catkin_ws\src
cd c:\catkin_ws\src
git clone https://github.com/ms-iot/universal_robot -b init_windows
git clone https://github.com/ms-iot/ur_modern_driver -b init_windows
echo > universal_robot\ur_gazebo\CATKIN_IGNORE
cd c:\catkin_ws
catkin_make
c:\catkin_ws\devel\setup.bat

It would be great to get something similar for your setup.

@seanyen-msft
I've tried the way you told me, but the same error still happens.
There is no DLL file (gazbo_ros_control.dll) in the folder. So I copy&pasted the file from another computer(with Ubuntu 14.04, ROS Indigo). But the file still cannot be found.
Error Message
[Plugin.hh:188] Failed to load plugin C:\opt\rosdeps\x64\lib\gazebo-9\plugins\gazebo_ros_control.dll: "C:\opt\rosdeps\x64\lib\gazebo-9\plugins\gazebo_ros_control.dll"
@ooeygui
c:\opt\ros\melodic\x64\setup.bat
mkdir c:\catkin_ws\src
cd c:\catkin_ws\src
and I downloaded a project from bitbucket.
https://bitbucket.org/theconstructcore/my-robotic-manipulator
catkin_make
c:\catkin_ws\devel\setup.bat
roslaunch mrm_description spawn.launch

@OnesoulKang
Thank for the information what repo you are using! Look like you are following the tutorials here?
After looking this demo, it seems to depend on simulation_gazebo, so I am assuming you are running both:
roslaunch simulation_gazebo main.launch
roslaunch mrm_description spawn.launch
And there are indeed Windows-specific bugs in ros_control related package, where I discovered some DLLs consumed by gazebo_ros_control.dll are not yet placed to the correct location. I made a few fixes and the next daily build should have it fixed. Can you try to do choco upgrade ros-melodic-desktop_full -y later?
(I will ping this thread again once the new build is released.)

@OnesoulKang The new build is out, please give it a try! (Run choco upgrade ros-melodic-desktop_full -y)

@seanyen-msft
The error is gone! I really appreciate your help!
I think now we can close this issue!
Thanks!


Last Testament Published On Connect

Hey Hey.
Not sure if this has to do with your lib, but when connecting with a will to ActiveMQ 5.11, the last testament gets published by the broker upon connection.
/c

NEVERMIND.
It works as expected.
Looking at screen too long.


Jitsu-cli extension create error: Cannot find module ‘JSON5’

Environment

Centos

Description
Cannot run command "npx jitsu-cli extension create --type destination"
error: Cannot find module ‘JSON5’
Steps to reproduce
N/A
Expected behavior
Run command "npx jitsu-cli extension create --type destination"
Actual behavior

I published a small fix - 0.7.4. Would you please try with npx<EMAIL_ADDRESS>

it work thanks


Cant create a wine flatimage

AS of today i cannot create a wine flatimage.
When the flatimage tries to create the wineprefix (which was broke the normal way) by clicking open regedit the command just fails
logfile:
Spawn command: /fim/static/fim_portal,/media/ade/Temp/Temp/build/wine.flatimage,fim-exec,/opt/wine/bin/wine.sh,regedit
I :: [o]: [wine.sh] Container   : ARCH
I :: [o]: [wine.sh] Session Type: wayland
I :: [o]: [wine.sh] $*          : regedit
I :: [o]: [wine.sh] USER        : gameimage
I :: [o]: [wine.sh] WINEDEBUG   : fixme-all
I :: [o]: [wine.sh] HOME        : /home/gameimage
I :: [o]: [wine.sh] WINEPREFIX  : /media/ade/Temp/Temp/build/RollerCoaster-Tycoon-3/opt/gameimage-games/RollerCoaster-Tycoon-3/wine
I :: [o]: [wine.sh] glxinfo log : /media/ade/Temp/Temp/build/RollerCoaster-Tycoon-3/opt/gameimage-games/RollerCoaster-Tycoon-3/wine/glxinfo.log
I :: [o]: [wine.sh] GPU Vendor  : nvidia corporation
I :: [o]: [wine.sh] GPU Device  : NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2
I :: [o]: [wine.sh] OpenGL      : 4.6.0 NVIDIA 555.58.02
I :: [o]: [wine.sh] Vulkan log  : /media/ade/Temp/Temp/build/RollerCoaster-Tycoon-3/opt/gameimage-games/RollerCoaster-Tycoon-3/wine/vulkan.log
I :: [o]: [wine.sh] /opt/wine/bin/wine
I :: [o]: [wine.sh] Wine version: wine-experimental.wine.8.0.20231019.r0.gd43c059eac4 ( TkG Plain )
I :: [o]: [wine.sh] Wine log  : /media/ade/Temp/Temp/build/RollerCoaster-Tycoon-3/opt/gameimage-games/RollerCoaster-Tycoon-3/wine/wine.log
I :: [o]: [wine.sh] /usr/bin/umu-run
I :: [o]: [wine.sh
I :: [o]: ] Using 'umu-run'
I :: [o]: [wine.sh] umu-launcher version 1.1.3 (3.12.7 (main, Oct  1 2024, 11:15:50) [GCC 14.2.1 20240910])
I :: [o]: [wine.sh] WARNING: Executable not found: regedit
I :: [o]: [wine.sh] steamrt is up to date
I :: [o]: [wine.sh] pressure-vessel-wrap[7081]: E: None of the supported CPU architectures are common to the graphics provider and the container (tried: x86_64-linux-gnu, i386-linux-gnu)

Thanks for the heads up @Blad3forc3 , will look into it.

Any update to this Ruan?

Hi @Blad3forc3, thanks for reporting this issue, it should be fixed in v1.5.0. I've disabled umu for now, until I can resolve some issues it is having. Try the default option instead.


Update pom.xml

Make it so assembly >> A typo error causing confusion.

Fixed a typo error.

Thank you for trying to fix 'typo' but I do not think it is a typo?

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

46m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4041/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4041

Optional Tests
dupname asflicense javac hadoopcheck xml compile

uname
Linux 40d7c7356af7 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4a94cfccc9

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-http U: hbase-http

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4041/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I agree with Duo's evaluation that this wasn't a typo. I also think the current phrasing in confusing.
@acgoliyan would you mind rephrasing this as something like "we do not want invocations of 'assembly:single' to do anything in this module."?


DS-3453 - OAI-PMH verb Identify doesn't work on Oracle

Port of PR #2112 (originally #1683) to master
Fixes #6806

@arvoConsultores : Could we get this updated on latest main?  If the conflicts can be resolved, I can make sure this gets reviewed sooner rather than later in order to get it fixed in 7.1.  Thanks!

Closing as Oracle Support was removed in #8822


Add with_clue support to test framework

Pull Request Description
Add Test.with_clue function similar to ScalaTest's with_clue.
This is useful for tests where the assertion depends on context which is not clear from it's operands.
Important Notes
Using with_clue changes State Clue which is extracted by the fail function.
The State is introduced by Test.specify when the test is not pending.
There should be no changes to the public API apart form the addition of Test.with_clue.
Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] All code conforms to the
Scala,
Java,
and
Rust
style guides.
All code has been tested:

[ ] Unit tests have been written where possible.

There are currently no tests for any of the testing framework. Should they be introduced?

[x] If GUI codebase was changed: GUI codebase was not changed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.mstramm seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@JaroslavTulach @jdunkerley @hubertp ping :)

@JaroslavTulach, @jdunkerley, @hubertp ping

I created a simple prototype of a meta-test suite testing our test suite.
Turns out originally with_clue would inherit all clues added in the current specification - that was not desirable so I fixed that so that now only the clues up the call-stack are applied. I also reversed their order to more closely reflect the order in which the clues appear in the source file.

Just wanted to add @diab0l that the original code was a very good baseline, it just needed a few adjustments to be able to integrate it (and also updating it to our codebase changes).

@radeusgd Thanks for moving the PR along!


Fixed Regex Issue

Fixed Regex Issue

Since this is the initial skeleton, I am approving it. But please remember to write the test cases and submit a new PR by Tuesday @agrawroh


⚠ ClamAV has degraded performance

In 37d35ab, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 194 ms

Resolved: ClamAV performance has improved in 153ff85.


support base64 encoding on evt.buffer

In sysdig you can use -b to enable base64 encoding on evt.buffer
how can we encoding buffer in falco ?

Fixed in https://github.com/falcosecurity/falco/pull/396, so closing.


Add x-retry-attempt header

The header value would the number of retry attempt (1 - 3 by default)

hello


Manually trigger file sync possible?

First of all thanks a ton for this addon! It works really well.
I have frigate nvr running on my machine and want to store exported clips on my onedrive automatically when I'm not home. (In case someone steals my server that would mean all the recordings of the breakin go missing too...)
So my idea was to save flagged recordings to a media folder and upload to onedrive.
File sync works great but the sync window is every 5 minutes I think?
This would theoretically leave a burglar 5 minutes in which to break in and cut the energy thus leaving me with nothing. (apart from a notification image sent)
So my question is:
Is there any way to manually trigger the file sync via service call or is there a way to lower the sync interval to say 1 minute?

Sorry, Missed this completely.
I understand your use case but I have no plans currently to allow this on a trigger.
I can maybe add to the settings an option to override the sync interval so you could lower it.


[Question] Not providing the AWS access key

Hello,
I am trying to use the unload-copy module and I can see that besides CONFIG_FILE and AWS_REGION, also AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY are needed. I assume the access key is needed to access KMS for decrypting the secrets, however, I can see that if I do not provide them then we have a problem here:
https://github.com/awslabs/amazon-redshift-utils/blob/ba5bcb588fa3d684e663aea0f2808b7e5c29dd81/src/UnloadCopyUtility/global_config.py#L154-L155
The thrown exception is due the fact that boto3 needs these parameters but my question is why is EC2 client needed? Is this for checking the region only?
I am asking these because my use case is to use this utility in an ECS task to migrate some data between 2 Redshift databases. I need to inject the secrets through environment variables from SSM, hence they are in plaintext in the container. I tried to generate the CONFIG_FILE internally and further provide it to bin/run-unload-copy-utility.sh. In this case there is no reason for storing the secrets encrypted in the config file since this is handled by SSM. Therefore I do not need the IAM access key but I am afraid that the current implementation forces me to do the opposite. Is there a way to use the utility as I specified - without the access key?
Thanks in advance!

Is there any reason you dont want to store the encrypted secrets in the config file? That seems like the most straightforward solution. You need to always have either the access key and secret key, or use the config file with encrypted values.


Variable Naming conflicts with core ESP32 Variables:

:\Users\user\Documents\Arduino\libraries\Ch376msc-master\src/CommDef.h:262:15: error: 'const uint8_t ERR_TIMEOUT' redeclared as different kind of symbol

 const uint8_t ERR_TIMEOUT = 0x02;

               ^

In file included from C:\Users\user\AppData\Local\Arduino15\packages\esp32\hardware\esp32\1.0.4/tools/sdk/include/lwip/lwip/pbuf.h:42:0,

                 from C:\Users\user\Documents\Arduino\libraries\AsyncTCP-master\src/AsyncTCP.h:30,

                 from C:\Users\user\AppData\Local\Temp\arduino_build_953027\sketch\webserver.h:1,

                 from C:\Users\user\Documents\OPENBUILDS-ENGINEER\PCB-Grbl-Touchscreen\PCB-Grbl-InterFace\Arduino Sketches\CapTouch_Beep_LEDs_with_LCD_GrblParser\CapTouch_Beep_LEDs_with_LCD_GrblParser.ino:16:

C:\Users\user\AppData\Local\Arduino15\packages\esp32\hardware\esp32\1.0.4/tools/sdk/include/lwip/lwip/err.h:69:3: note: previous declaration 'err_enum_t ERR_TIMEOUT'

   ERR_TIMEOUT    = -3,

   ^

https://github.com/djuseeq/Ch376msc/blob/efb8023364323fa2fa5e039e4be7d408f9cd0a66/src/CommDef.h#L262 from CommDef.h - can it be renamed to something else please ? It conflicts with https://github.com/espressif/arduino-esp32/blob/96822d783f3ab6a56a69b227ba4d1a1a36c66268/tools/sdk/include/lwip/lwip/err.h#L69
Can't compile (:  - and I think core files get preference (:

Hi. It's done! Hope this time will compile :) . Thanks for this feedback.


Phylogenetic tree viewer

Enabled the existing phyloview viewer to handle the patric feature level ids (patric_id). Currently, the phyloview viewer only handle the genome level trees.
Added the new archaeopteryx viewer in the workspace:

For nwk files, the archaeopteryx viewer shows the tree with the control0 panel. The control1 panel is not shown as there is no node properties included in the nwk file.
For phyloxml files, the archaeopteryx viewer shows the tree with the control0 panel and the control1 panel if the node properties included in the xml file. The control1 panel drop down lists are now built dynamically based on the node properties included in the xml file.
Added phyloxml file type in the workspace UI so that users can upload any phyloxml files to their workspace and display them in the archaeopteryx viewer.

Failed all the checks. @hyoo this PR should go against features/integration branch?

this is for reading tree objects from workspace with the new viewer (which already in develop). So, I think this should go to the develop. Lets wait until she finishes the lint errors.

The lint errors are fixed.


extract day should return date not day of year.

Signed-off-by Girjesh Rajoria<EMAIL_ADDRESS>

@galsalomon66 Please review this.

this is also the result of AWS?

this is also the result of AWS?

yes


Attack Info Missing on Displacer Beast

Hey, sorry to bother, but the detailed info on the Dispacer Beast is missing when you Run in Improved Initiative!

Looks like they don't have the stats for it. You'd need to talk to the maintainer(s) of Improved Initiative.


add docker and kubernetes

Description
Added dockerfile, docker compose and kubernetes config and readme.
Things to sort:
[ ] passwords/connection string for sql
[ ] Split restore and build in docker image?
[ ] Which projects actually need building?
[ ] can config be done using env vars?

Sorry - wrong fork!


second commit

Hello @Artath ,
Thanks for your contribution for webline GitHub community.
We reviewed your commits and found changes related to firebase google services and other typos.
It seems that relates to specific google account so for the security reason we are not going to merge this pull request into base branch.
Thanks.

Sorry, it's made by mistake


Update Concord

Game Title
Concord
Status of the Anti-Cheat
⭕ To be removed.
Details
Remove the game from the list as:
A) It’s no longer available for purchase on the steam store
B) it’s servers are shutting down on September 6th.
Proof of Mention
https://blog.playstation.com/2024/09/03/an-important-update-on-concord/

As much as I'd like to remove this game, I'm planning to add a new field for games on the manifest that detail if they're defunct or not. So I'd rather keep this entry around for historical accuracy, but rest assured, I will get around to this game.


Vertical align

Good day
I am working with slick ver. 1.5.9
Problem occurs with center vertical align of big div on the screen
when I use infinite loop.... everything are moving outside screen -  to the right - until loop is finished
after that he return to default point to left part of the screen
is there is a simple function in Slick slider to define vertical alignment?

Problem code

  <script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
  <script type="text/javascript" src="https://cdn.jsdelivr.net/jquery.slick/1.5.9/slick.min.js"></script>
  <link rel="stylesheet" type="text/css" href="https://cdn.jsdelivr.net/jquery.slick/1.5.9/slick.css">

centerverticalhorizontal

Please create a JSFiddle with your issue, and try to explain it a little better :)

http://jsfiddle.net/4qpejg98/2/

Slick doesn't support display: table; :)


can get output of activeTextEditor of vscode as html?

sorry guys but it's unanswered question , can you help me?
https://github.com/microsoft/vscode/pull/66418

/duplicate of your own question at https://github.com/microsoft/vscode/pull/66418#issuecomment-522332617
Please look for follow up there, and be patient.


[Feature][Flink] Support flow control in Flink

Purpose of this pull request

Check list
SubTask:https://github.com/apache/seatunnel/issues/5503

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

PTAL : @Hisoka-X @hailin0

Please offer the test cases for your change to verify it worked.

PTAL: @TyrantLucifer @hailin0 @Hisoka-X  thks


fix: do not error out on first ingestion failure (continue with next file)

It's already implemented this way


False positive CVE-2014-9152

Referred issue: #777
Unfortunately, using 2.0.1 release I stiil need the following entry in my suppressions.xml file in order to mute false positive:
<suppress>
        <notes><![CDATA[
        False positive: xxx-connector-main-1.0.0-SNAPSHOT.jar\META-INF/maven/org.glassfish.jersey.ext/jersey-metainf-services/pom.xml
        ]]></notes>
        <sha1>6068198479cb633219e07ccb3f4b1900bffba56c</sha1>
        <cve>CVE-2014-9152</cve>
    </suppress>

Enforcing newer (beta) jersey-metainf-services i.e.
<dependency>
    <groupId>org.glassfish.jersey.ext</groupId>
    <artifactId>jersey-metainf-services</artifactId>
    <version>2.26-b07</version>
</dependency>

did not help.

I'll look at this over the next few days.  I would point out a better way to create the suppression entries is using the new report which uses the Maven GAV as the base for the suppression rule instead of the SHA1.

I am unable to reproduce this issue. When using the following configuration:
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>test-project</groupId>
    <artifactId>test-project</artifactId>
    <packaging>jar</packaging>
    <version>1.0-SNAPSHOT</version>
    <dependencies>
        <dependency>
            <groupId>org.glassfish.jersey.ext</groupId>
            <artifactId>jersey-metainf-services</artifactId>
            <version>2.25.1</version>
        </dependency>
    </dependencies>
    <build>
        <plugins>
            <plugin>
                <groupId>org.owasp</groupId>
                <artifactId>dependency-check-maven</artifactId>
                <version>2.0.1</version>
                <executions>
                    <execution>
                        <goals>
                            <goal>check</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
        </plugins>
    </build>
</project>

Then running mvn verify a report is generated that contains zero known vulnerabilities:
- dependency-check version: 2.0.1
- Report Generated On: Jul 18, 2017 at 05:56:47 -04:00
- Dependencies Scanned: 13 (13 unique)
- Vulnerable Dependencies: 0
- Vulnerabilities Found: 0
- Vulnerabilities Suppressed: 0

Any chance you can share a copy of the generated report where you are seeing the FP?

If I comment our suppressed entry (here: CVE-2014-9152) and run dependency-check:aggregate I can see the following error in Maven log:
[ERROR] Failed to execute goal org.owasp:dependency-check-maven:2.0.1:aggregate (default-cli) on project acaas-administration-connector:
[ERROR]
[ERROR] One or more dependencies were identified with vulnerabilities:
[ERROR]
[ERROR] acaas-administration-connector-main-1.0.0-SNAPSHOT.jar\META-INF/maven/org.glassfish.jersey.ext/jersey-metainf-services/pom.xml: CVE-2014-9152
[ERROR]
[ERROR] See the dependency-check report for more details.

I am attaching screenshot of the relevant fragment of dependency report:

jersey-metainf-services is a transitive dependency of 'io.dropwizard:dropwizard-jersey:jar:1.1.1:compile'

Thanks - the problem was that the JAR was being identified within a shaded jar and the regex on the base suppression rule did not correctly cover that scenario. The fix will be included in the next release.


Nativescript BottomNavigation full screen issue on specific page

Environment
{
"nativescript": {
"id": "org.nativescript.mytest",
"tns-android": {
"version": "6.5.0"
},
"tns-ios": {
"version": "6.5.0"
}
},
"description": "NativeScript Application",
"license": "SEE LICENSE IN ",
"repository": "",
"scripts": {
"lint": "tslint "src/**/*.ts""
},
"dependencies": {
"@angular/animations": "~8.2.0",
"@angular/common": "~8.2.0",
"@angular/compiler": "~8.2.0",
"@angular/core": "~8.2.0",
"@angular/forms": "~8.2.0",
"@angular/platform-browser": "~8.2.0",
"@angular/platform-browser-dynamic": "~8.2.0",
"@angular/router": "~8.2.0",
"@nativescript/theme": "~2.3.3",
"nativescript-angular": "~8.21.0",
"reflect-metadata": "~0.1.12",
"rxjs": "^6.4.0",
"tns-core-modules": "~6.5.0",
"zone.js": "~0.9.1"
},
"devDependencies": {
"@angular/compiler-cli": "~8.2.0",
"@ngtools/webpack": "~8.2.0",
"codelyzer": "~4.5.0",
"nativescript-dev-webpack": "~1.5.1",
"node-sass": "^4.7.1",
"tslint": "~5.19.0",
"typescript": "~3.5.3"
},
"gitHead": "2250137db8c1e0bd0eb543e8e4563cb71480c00d",
"readme": "NativeScript Application"
}
Describe the bug
When navigated to a page unable to hide bottom navigation tab bar or show full screen page view.
To Reproduce
Create a basic native script angular tabs app by tns create

Home tab with items
2)Select an item navigates to next page.
Issue: Show Bottom navigation Tabs on item detail page (Unable to hide)

Expected behavior
Able to hide both Bottom navigation Tabs  ios and android. Expected functionality such way that we can hide and show bottom navigation.
Attached just source code
src.zip

Hey @simple-access
Make sure that you put BottomNavigation only where you need it. Not in the Main app.component.html.
You have putted it in the app.component.html and page router inside tab content item.
You are doing this(Putting   inside Bottom Navigation, so your parent is BottomNavigation, it will be everywhere)
BottomNavigation -> TabStrip -> TabContent -> page-router-outlet
Thats why every component has a BottomNavigation.
solution 1 : example code
https://github.com/iamabs2001/demo-code/blob/master/tns-bottom-navigation.html


Upgrade dependencies

Current coverage is 90.55% (diff: 100%)

Merging #2 into master will increase coverage by 4.68%

@@             master         #2   diff @@
==========================================
  Files            29         29
  Lines           184        180     -4
  Methods         176        180     +4
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            158        163     +5
+ Misses           26         17     -9
  Partials          0          0

Powered by Codecov. Last update d889c64...1bb3d11


microdude: init at 2.3

Description of changes
Add the microdude application: a GTK Python program that interfaces with the Arturia Microbrute analogue synth.
I'm new to nix and nixos, and have another open PR for a different audio program (shuriken).
This one works fine and connects to my Microbrute when run with the following:
cd pkgs/applications/audio/microdude/
nix-build -E 'let pkgs = import <nixpkgs> { }; in pkgs.python3Packages.callPackage ./default.nix {}'
result/bin/microdude

But fails when run from the root of nixpkgs with the following:
$ nix-build -A microdude
# lots of happy-looking build output
$ result/bin/microdude
Traceback (most recent call last):
  File "/nix/store/w03lfbrl2jasp75x16cqbbs1iz7j5nvy-microdude-2.3/bin/.microdude-wrapped", line 18, in <module>
    editor.main()
  File "/nix/store/w03lfbrl2jasp75x16cqbbs1iz7j5nvy-microdude-2.3/lib/python3.10/site-packages/microdude/editor.py", line 423, in main
    self.init_ui()
  File "/nix/store/w03lfbrl2jasp75x16cqbbs1iz7j5nvy-microdude-2.3/lib/python3.10/site-packages/microdude/editor.py", line 121, in init_ui
    self.main_window.connect(
TypeError: <Gtk.Window object at 0x7f7b882aef00 (GtkWindow at 0x1f66530)>: unknown signal name: delete-event

Have I done something weird with the GTK dependencies?
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I added --ignore-theme-index to the gtk-update-icon-cache invocation in the program's Makefile to avoid running into:
gtk-update-icon-cache /nix/store/5cqga13h540lc0n9vykwqpg2namrp3v5-microdude-2.3/share/icons
gtk-update-icon-cache: No theme index file.

After making the above changes, I now get:
$ nix-env -f . -iA microdude
# happy-looking build output
$ microdude
Traceback (most recent call last):
  File "/nix/store/pjcc8ibw1alwqj8640ji985wg6j0k2hr-microdude-2.3/bin/.microdude-wrapped", line 4, in <module>
    from microdude.editor import Editor
ModuleNotFoundError: No module named 'microdude'

I'm guessing this is now a lack of proper runtime environment setup?

Thanks so much for your help BTW!

After a bit more digging, it seems that, since I remove the call to python3 setup.py install (avoiding all sorts of distutils and setuptools chaos), I need to reinstate the behaviour of including the resources/* dir in the output, in order for the executable to be able to import its modules. How I do that is eluding me...

MicroDude includes a Python 3 module, which is installed via setuptools, and a few desktop related resources such as the desktop file, the application icon or the translations. As I didn't find a way to distribute these resources with setuptools, I decided to install them via Makefile and to reduce the amount of installation steps I decided to include a call to python3 setup.py install in the install target.
Here is the file for reference.
https://github.com/dagargo/microdude/blob/cc58e8e53919e6852131e1ea7a885a339e7dfb83/Makefile
But I discourage the packaging of MicroDude. I still need to add a warning to the project against its future usage. The reason is that Elektroid covers all the MicroDude functionality and much more. Elektroid is purely managed with autotools so packaging it would be easier.
Elektroid is already on Debian and includes installation instructions for other distributions.
Sadly, there is not an official Elektroid release including the compatibility with MicroBrute yet. But the master branch includes all the code and should work for everyone.
If you're interested, I can make the 2.5 release during the following days. (Some translations are missing.)

@dagargo ah great, I hadn't seen Elektroid, but it looks awesome. I'll close this PR and perhaps look at nixifying Elektroid.


[Feature request] Add documentation on the functional differences between the available pretrained models

As it stands there 6 pre-trained models availible for fine tuning:

MobileNetV2
InceptionV3
VGG16
VGG19
NASNetMobile
SimpleCnnModel

It is not however from that which I can see communicated within the webUI what the functional differences between these are, while broad inferences can be made based on the names there is possibly room for clearer communication of the pros and cons of each model.

As it stands there 6 pre-trained models availible for fine tuning:

MobileNetV2
InceptionV3
VGG16
VGG19
NASNetMobile
SimpleCnnModel

It is not however from that which I can see communicated within the webUI what the functional differences between these are, while broad inferences can be made based on the names there is possibly room for clearer communication of the pros and cons of each model.

Hi LexCybermac,
Thanks  for the feature request. I'm working on a different project right now but I will add what you say as soon as.


Segfault when switching to "4 views" with vector image

Configuration
Using nightly medInria-3.0-Fedora_25-x86_64.zip build from 07-Feb-2018 00:21 under Fedora 27.
Steps to reproduce

Open visualization workspace
Load vector image
Click the 4 icon

Attachments

logs (stderr and stdout)
Example MHA image provoking the issue

Solved by #324


Set calendar current date

How do you set the calendars current view date dynamically from controller. I want to be able to click a day in the month view and auto switch to that day in dayView.

+1

in the calendar ui config, attach the dayclick event:
dayClick: $scope.alertOnDayClick
in the event handler, you can switch view, and jump to the date:
       $scope.alertOnDayClick = function (date, jsEvent, view, resource) {            if (view.name !== 'month')                return;            uiCalendarConfig.calendars.myCalendar1.fullCalendar('changeView', 'agendaDay');            uiCalendarConfig.calendars.myCalendar1.fullCalendar('gotoDate', date );        }
myCalendar1 is the name of the calendar in the HTML:

Thanks Curtis Vayne. It works.


Fix unknown column name error when filtering ORC file with no names

https://github.com/rapidsai/cudf/pull/7624 recently exposed an issue in the plugin when handling an ORC file with no column names.  The plugin was filtering the stripes based on the columns being referenced but then asking for all columns in the original file schema.  After the recent cudf change, that caused an "Unknown column" exception to be thrown.
This updates the code to filter the requested columns to the referenced columns when dealing with a file that has no column names.  The existing no-column-name ORC test now passes with this change, so no new test was added.

This will need to be upmerged with #2005 before the CI build will pass.

build


Compiler warnings about bracket

Is it possible to disable these compiler warnings ?

warning: unnecessary braces around function argument
   --> demo/app/src/app/todo/mod.rs:256:37
    |
256 | ...                   { &comment.body }
    |                       ^^             ^^
    |
help: remove these braces
    |
256 -                                     { &comment.body }
256 +                                     &comment.body
    |

warning: unnecessary braces around function argument
   --> demo/app/src/app/todo/mod.rs:270:25
    |
270 |                         { list_view }
    |                         ^^         ^^
    |
help: remove these braces
    |
270 -                         { list_view }
270 +                         list_view
    |

warning: unnecessary braces around function argument
   --> demo/app/src/app/todo/mod.rs:278:25
    |
278 |                         { message }
    |                         ^^       ^^
    |
help: remove these braces
    |
278 -                         { message }
278 +                         message

Could you provide the code in question? Not sure what the context is.

Sure.
I have this repository: https://github.com/vertigo-web/vertigo
Branch: "builder"
https://github.com/vertigo-web/vertigo/blob/d81013550607cf7341c3b2c840c0c29543779104/demo/app/src/app/todo/mod.rs#L278
            ResourceComputed::Error(message) => {
                dom! {
                    <div>
                        "Error = "
                        { message }
                    </div>
                }
            },

This part of the program is reporting warnings to me:
warning: unnecessary braces around function argument
   --> demo/app/src/app/todo/mod.rs:278:25
    |
278 |                         { message }
    |                         ^^       ^^
    |
help: remove these braces
    |
278 -                         { message }
278 +                         message
    |

Looks like this might be a false-positive form the nightly compiler, similar to https://github.com/rust-lang/rust/issues/47775. Can't try with stable compiler since the crate depends on a nightly feature flag it seems.
Nice project, good luck with it!

Oh, and in terms of disabling those as a workaround, #[allow(unused_parens)] should do that trick, I guess.

Nice project, good luck with it!
thank you :)

Can't try with stable compiler since the crate depends on a nightly feature flag it seems.
I tried to switch. The effect is the same.

I guess it must depend on the macro somehow. The previous html macro is built using https://crates.io/crates/percy and there this problem does not occur :/

Ah, I see. It's probably your implementation of dom which generates unnecessary brackets around your generated code. I'd look at the expanded output with cargo-expand to see how exactly it looks like. Maybe it's just that you currently have a quote!{{ instead of just quote!{ somewhere.

I think you are right. I will try to solve the problem this way.

Sounds good. If it works out, feel free to close the issue. :+1:

        } else if child.node_type == NodeType::Block {
            // let block = child.value_as_block().unwrap();
            let block = child.value.unwrap();

            let stream = block.to_token_stream();
            println!("\n\n\nblock {stream}\n\n\n");

            out_child.push(quote! {
                .child(vertigo::EmbedDom::embed(#block))
            });

        } else {

It produces such a message:
block { message }

It appears that the variable block also contains these brackets:
let block = child.value.unwrap();

Yep, value_as_block gives you an ExprBlock, which itself contains the brackets. Using block.block.stmts instead might do the trick. Or if you want to keep the block fully intact, you could add an #[allow(unused_parens)] inside the quote!, since having an unused braces in this case seems ok.

I had to clear this block of brackets. This solved the problem completely.
fn convert_expresion_without_brackets(span: Span, expr: Option<Expr>) -> Result<TokenStream2, ()> {
    match expr {
        Some(Expr::Block(expr)) => {
            let mut stmts = expr.block.stmts;

            let first = stmts.pop();

            if stmts.len() > 0 {
                emit_error!(span, format!("one Stmt was expected"));
                return Err(());
            }

            if let Some(first) = first {
                return Ok(first.to_token_stream());
            } else {
                emit_error!(span, format!("one Stmt was expected"));
                return Err(());
            }
        },
        _ => {
            emit_error!(span, format!("Block was expected"));
            Err(())
        }
    }
}

Thanks for your help  :)

Dirty but creative! 😄 Personally I wouldnt operate directly on the stmts, but if it works for you, even better!

In the worst case it will not compile :D


[WIP] vars cleanups

We reverted this PR here because the end to end tests were breaking. We should find out what broke them and fix it.

The original PR also moved the dashboard pillar value from vars.sls to params.sls. The tests were failing because when we setup the development envorinment of velum, we override the vars.sls file in order to point all minions to the dashboard. After removing vars.sls from top.sls file that file is no longer used so the minions try to connect to "dashbord" domain name which is set here. If moving the pillar value from vars.sls is important we can find an other solution for the development environment (and the end to end tests). If not, lets merge this as it is.


Make players persistent across page loads

I'm not sure how easy/hard this is to do given that you're working with third-party players, but it would be pretty nice if the player persisted across page loads. This would mean you could start playing one new album and continue to browse other new albums. https://changelog.com/posts/why-we-chose-turbolinks shows how they did it, though they got to control the player.

Great idea! We'd have to build our own custom player (instead of using Apple Music/Spotify players) but long-term, definitely a great idea.


[ENH] allow scikit-base 0.7.X

This allows scikit-base 0.7.X in pyproject, and therefore fixes issues with deep_equals or set_config.

duplicate of https://github.com/sktime/skpro/pull/169


Minimum Node Version

Description

Module resolution fails on Node 16
Testing Instructions

Switch to node 16 and run npm run dev
Upgrade to node 18 and the error goes away

Workspaces is introduced in npm 7; its not related to nvm


Check protein properties

While working on #569 I noticed that the protein properties we show on the gene pages doesn't match the values in the PeptideStats.tsv file from PomBase V1.
There are many calculators on the web but they give quite different answers for some of the properties.  So I'm not sure our values are OK.
As an example, for SPAC3G9.09c we have:
Isoelectric point    6.42
Charge at pH 7	    -2.42

(Calculated using this Perl module: http://search.cpan.org/dist/BioPerl/Bio/Tools/pICalculator.pm )
This online calculator matches the values we have quite well (but not perfectly):
http://protcalc.sourceforge.net/
Estimated pI = 6.46
Estimated charge at pH 7.00 = -2.4

This one gives somewhat different values:
http://pepcalc.com/protein-calculator.php
Iso-electric point:	pH 6.03
Net charge at pH 7:	-3.5

This one:
http://isoelectric.ovh.org/
gives the iso-electric point as: 5.83

Maybe it would be  good to ask Steve (or someone else at biochemistry) which resource gives the best estimates? Some methods outperform other methods, but I don't know which one is regarded best/reliable.

Ask pombelist which one people would prefer ?

@Antonialock  maybe you needed to provide the options?

Also asked Steve's group

Let's just pick one, (top google hit?)

what are the options, we'll decide on the call

This paper compares different prediction methods: https://academic.oup.com/bioinformatics/article/32/6/821/1744386
They recommend an SVM based machine learning algorithm published here:
https://www.ncbi.nlm.nih.gov/pubmed/22326964

Pride

https://www.ebi.ac.uk/pride/help/archive

https://web.expasy.org/compute_pi/

document method used currently.


feat: add span processor

Idea: The SpanProcessor interface allows users to build frameworks like exporter/z-pages/etc. The SpanProcessor interface should allow intercepting Spans immediately after start and immediately after end.
OpenCensus contains the same kind of interface:
https://github.com/census-instrumentation/opencensus-node/blob/056523d83d21449e3bd888fec624d33c129951cc/packages/opencensus-core/src/trace/model/types.ts#L261-L266
This exist in java but aren't yet included in the spec.

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   98.74%   98.74%
=======================================
  Files          29       29
  Lines        1915     1915
  Branches      221      221
=======================================
  Hits         1891     1891
  Misses         24       24

Impacted Files
Coverage Δ

...kages/opentelemetry-scope-async-hooks/src/index.ts
100% <0%> (ø)
:arrow_up:

packages/opentelemetry-scope-base/src/index.ts
100% <0%> (ø)
:arrow_up:

packages/opentelemetry-scope-base/src/types.ts
100% <0%> (ø)
:arrow_up:

...ry-scope-async-hooks/src/AsyncHooksScopeManager.ts
96.49% <0%> (ø)
:arrow_up:

...s/opentelemetry-scope-base/src/NoopScopeManager.ts
100% <0%> (ø)
:arrow_up:

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   98.74%   98.74%
=======================================
  Files          29       29
  Lines        1915     1915
  Branches      221      221
=======================================
  Hits         1891     1891
  Misses         24       24

Impacted Files
Coverage Δ

...kages/opentelemetry-scope-async-hooks/src/index.ts
100% <0%> (ø)
:arrow_up:

packages/opentelemetry-scope-base/src/index.ts
100% <0%> (ø)
:arrow_up:

packages/opentelemetry-scope-base/src/types.ts
100% <0%> (ø)
:arrow_up:

...ry-scope-async-hooks/src/AsyncHooksScopeManager.ts
96.49% <0%> (ø)
:arrow_up:

...s/opentelemetry-scope-base/src/NoopScopeManager.ts
100% <0%> (ø)
:arrow_up:

I'd rather avoid event emitters if possible since I think they are Node-specific. @rochdev what are the use cases you have in mind for hooking into the other methods of Span? Could that be achieved by having a different tracer that returns a subclassed Span implementation?
I guess my thinking is that if the most common cases involve exporters that would operate on a span when it ends, then the extra code (JS bytes for the browser) and complexity of arbitrary hooks might not be needed in the basic Span implementation.

👍 This seems like a good start.
Maybe the wrong PR to discuss this on, but one of the main benefits of having hooks/event emitters for every span method is you can then stream to a sidecar rather than going through an exporter, eliminating all buffering and most span state in the application (you'd need to maintain the span context but that's it). An implementation like that though would probably replace the SDK.
@rochdev I'm also curious, are there any hook/event emitter examples you have in mind?

Per the SIG: we agreed that lifecycle hooks are valuable and should be implemented with a simple callback-based mechanism.

To give a bit more context, at Datadog we have many features outside of the capability of OpenTelemetry, and we need to be able to call specific methods that are vendor-specific at different times during the lifecycle of the tracer. This is also not limited to Span, as we need such hooks also for the scope manager for example.
By having hooks for every function available on every class of the tracer, it would allow us to support OpenTelemetry without requiring the user to choose between using OpenTelemetry with less features or not using it to get more features.


Auditlog is not output

http: //localhost/?param="><script>alert(1);</script>
http: //localhost/?union+select

Blocked when executing the above (normally so far)
・ It is recorded in error log.
・Not output to Auditlog.
Logs and dumps
Output of:

DebugLogs (level 9)
https://gist.github.com/nakacya/9614561b559cb04ac5d4edc35449621c
AuditLogs
no log
Error logs

2019/12/16 12:18:01 [error] 15769#15769: *1 [client <IP_ADDRESS>] ModSecurity: Access denied with code 403 (phase 2). Matched "Operator `Ge' with parameter `5' against variable `TX:ANOMALY_SCORE' (Value: `15' ) [file "/etc/nginx/modsecurity3/activated_rules/rules/REQUEST-949-BLOCKING-EVALUATION.conf"] [line "79"] [id "949110"] [rev ""] [msg "Inbound Anomaly Score Exceeded (Total Score: 15)"] [data ""] [severity "2"] [ver ""] [maturity "0"] [accuracy "0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-generic"] [hostname "<IP_ADDRESS>"] [uri "/"] [unique_id "157649868155.730577"] [ref ""], client: <IP_ADDRESS>, server: localhost, request: "GET /?param="><script>alert(1);</script> HTTP/1.1", host: "localhost"

If there is a crash, the core dump file.
None

Expected behavior
A clear and concise description of what you expected to happen.
Server (please complete the following information):

ModSecurity version (and connector): ModSecurity v3.0.3 (Linux) with nginx-connector v1.0.0
WebServer: nginx1.17.3
OS (and distro): amazon linux 2

Rule Set (please complete the following information):

Running any public or commercial rule set? [SpiderLabs public rules]
What is the version number? [e.g. Version 3.2.0]

Not all Auditlogs are out.
return code 200 is output normally
SecAuditEngine RelevantOnly
SecAuditLogRelevantStatus "^[0-9]+"
SecAuditLogParts ABCDEFGHIJKZ
SecAuditLog /var/log/modsecurity/modsec_audit.log
SecAuditLogType Concurrent
SecAuditLogStorageDir /var/log/modsecurity/es
SecAuditLogFormat JSON

400 series return code is also output in json, but the message part such as ruleid is missing

can you please post how this "partial" JSON looks like?

THX For reply
For example, this JSON is output but ruleid is not included.
{
  "transaction": {
    "client_ip": "xxx.xxx.xxx.xxx",
    "time_stamp": "Mon Dec 16 13:46:54 2019",
    "server_id": "f3cf3e49811aac12eb2fe60eec861eed40feb9af",
    "client_port": 53549,
    "host_ip": "<IP_ADDRESS>",
    "host_port": 80,
    "unique_id": "157650401449.074622",
    "request": {
      "method": "GET",
      "http_version": 1.1,
      "uri": "/wp-json/oembed/1.0/embed?=",
      "body": "",
      "headers": {
        "Host": "**.**.jp",
        "Connection": "keep-alive",
        "Cache-Control": "max-age=0",
        "DNT": "1",
        "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36",
        "Cookie": "wordpress_test_cookie=WP+Cookie+check; wordpress_logged_in_8626befbdd4025a3e929f4bffe6825ca=nakacya%7C1576299971%7CBpdVHllEtakd5vULPDOAFqr8yAsNOUqplrtDvWl9QOc%7C3f5920b03363c63257afc6683dc42fd124d378d3cf74e959761d9d33627bb114; wp-settings-time-1=1576127171",
        "Upgrade-Insecure-Requests": "1",
        "Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3",
        "Accept-Encoding": "gzip, deflate",
        "Accept-Language": "ja,en-US;q=0.9,en;q=0.8"
      }
    },
    "response": {
      "body": "",
      "http_code": 400,
      "headers": {
        "Access-Control-Allow-Headers": "Authorization, Content-Type",
        "Link": "<http://**.**..jp/wp-json/>; rel=\"https://api.w.org/\"",
        "Content-Type": "application/json; charset=UTF-8",
        "Allow": "GET",
        "Connection": "keep-alive",
        "X-Content-Type-Options": "nosniff",
        "Access-Control-Expose-Headers": "X-WP-Total, X-WP-TotalPages",
        "Date": "Mon, 16 Dec 2019 13:46:54 GMT",
        "X-Robots-Tag": "noindex",
        "Server": "nginx",
        "Vary": "Origin"
      }
    },
    "producer": {
      "modsecurity": "ModSecurity v3.0.3 (Linux)",
      "connector": "ModSecurity-nginx v1.0.0",
      "secrules_engine": "Enabled",
      "components": [
        "OWASP_CRS/3.2.0\""
      ]
    },
    "messages": []
  }
}

Hi @nakacya ,
I'm not certain whether this is your issue, but there was a bug fix in October (https://github.com/SpiderLabs/ModSecurity/commit/d4dc3dbf2a647942b9b315a413a99cacae90a484 ) that may be relevant.  For that bug, the details that you note as missing were being omitted when the disruptive action was 'deny'.
If you're using 3.0.3 either from a repo package or from the 3.0.3-tagged github commit (from Nov. 1, 2018), you might have your logging issue fixed if you move up to at least https://github.com/SpiderLabs/ModSecurity/commit/6395fe07ce397f85b14ce63f79cb124a9783c082

THX forreply @martinhsv
I checked, but it seems that the corresponding correction has been completed.
I was in trouble ...
git show
commit 6624a18a4e7fd9881a7a9b435db3e481e8e986a5 (HEAD -> v3/master, origin/v3/master, origin/HEAD)

ModSecurity - v3.0.3-114-g6624a18a for Linux

 Mandatory dependencies
   + libInjection                                  ....v3.9.2-30-gbf234eb
   + SecLang tests                                 ....c8cf2c5

 Optional dependencies
   + GeoIP/MaxMind                                 ....found
      * (MaxMind) v1.2.0
         -lmaxminddb  , -DWITH_MAXMIND
   + LibCURL                                       ....found v7.61.1
      -lcurl,  -DWITH_CURL_SSLVERSION_TLSv1_2 -DWITH_CURL
   + YAJL                                          ....found v2.0.4
      -lyajl  , -DWITH_YAJL
   + LMDB                                          ....disabled
   + LibXML2                                       ....found v2.9.1
      -lxml2 -lz -lm -ldl, -I/usr/include/libxml2 -DWITH_LIBXML2
   + SSDEEP                                        ....not found
   + LUA                                           ....not found

 Other Options
   + Test Utilities                                ....enabled
   + SecDebugLog                                   ....enabled
   + afl fuzzer                                    ....disabled
   + library examples                              ....enabled
   + Building parser                               ....disabled
   + Treating pm operations as critical section    ....disabled

Oh?
I tried accessing it with a browser.
Why is the content of auditlog being favicon.ico
 Is it?
“xmlrpc.php?rsd=%00” should have been rejected by modsecurity ...
curl doesn't require a favicon, so why don't it appear in the auditlog?
[modsecuritylog]
2019/12/17 01:29:39 [error] 12446#12446: *1 [client xxx.xxx.xxx.xxx] ModSecurity: Access denied with code 403 (phase -1). Matched "Operator `Ge' with parameter `5' against variable `TX:ANOMALY_SCORE' (Value: `16' ) [file ""] [line "0"] [id "0"] [rev ""] [msg "Inbound Anomaly Score Exceeded (Total Score: 16)"] [data "Restricted header detected: accept-language"] [severity "2"] [ver ""] [maturity "0"] [accuracy "0"] [hostname "<IP_ADDRESS>"] [uri "/xmlrpc.php"] [unique_id "1576546179"] [ref "o6,4o7,3v5,10o0,4v33,4o0,4v33,4t:lowercaseo0,10v56,10o0,10v56,10t:lowercaseo0,13v79,13o0,13v79,13t:lowercaseo0,3v104,3o0,3v104,3t:lowercaseo0,10v140,10o0,10v140,10t:lowercaseo0,6v473,6o0,6v473,6t:lowercaseo0,25v111,25o0,25v111,25t:lowercaseo0,6v274,6o0,6v274,6t:lowercaseo0,15v401,15o0,15v401,15t:lowercaseo0,15v432,15o0,15v432,15t:lowercase"], client: xxx.xxx.xxx.xxx, server: xxx.xxx.xxx.xxx.jp, request: "GET /xmlrpc.php?rsd=%00 HTTP/1.1", host: "xxx.xxx.xxx.xxx.jp

[auditlog]
xxx.xxx.xxx.xxx.jp xxx.xxx.xxx.xxx - [17/Dec/2019:01:29:39 +0000] "GET /favicon.ico HTTP/1.1" 200 0 http://xxx.xxx.xxx.xxx.jp/xmlrpc.php?rsd=%00 "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36"<PHONE_NUMBER> http://xxx.xxx.xxx.xxx.jp/xmlrpc.php?rsd=%00 /var/log/modsecurity/es/20191217/20191217-0129/20191217-012939-1576546179 0 1488.000000 md5:0f0dd73dcc81e942c0778d6e31b5c9d1

[JSON]
{
  "transaction": {
    "client_ip": "xxx.xxx.xxx.xxx",
    "time_stamp": "Tue Dec 17 01:29:39 2019",
    "server_id": "f3cf3e49811aac12eb2fe60eec861eed40feb9af",
    "client_port": 63996,
    "host_ip": "<IP_ADDRESS>",
    "host_port": 80,
    "unique_id": "1576546179",
    "request": {
      "method": "GET",
      "http_version": 1.1,
      "uri": "/favicon.ico",                  favicon.ico ?
      "body": "",
      "headers": {
        "Accept-Language": "ja,en-US;q=0.9,en;q=0.8",
        "Accept-Encoding": "gzip, deflate",
        "Cookie": "wordpress_test_cookie=WP+Cookie+check; wordpress_logged_in_8626befbdd4025a3e929f4bffe6825ca=nakacya%7C1576681028%7CWrIYDg4WSQcSksaZKClkmbQ0SGppMkOD0YGPPj8COsN%7C8a6b232e78e293b38d26d986e9df31012072917614c7c9a300530843c5720bc3; wp-settings-time-1=1576508468",
        "Referer": "http://xxx.xxx.xxx.xxx.jp/xmlrpc.php?rsd=%00",
        "Pragma": "no-cache",
        "Accept": "image/webp,image/apng,image/*,*/*;q=0.8",
        "Cache-Control": "no-cache",
        "DNT": "1",
        "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36",
        "Connection": "keep-alive",
        "Host": "xxx.xxx.xxx.xxx.jp"
      }
    },
    "response": {
      "body": "",
      "http_code": 200,                 Why return code 200?
      "headers": {
        "Server": "nginx",
        "Date": "Tue, 17 Dec 2019 01:29:39 GMT",
        "Content-Length": "43",
        "Expires": "Thu, 16 Jan 2020 01:29:39 GMT",
        "Content-Type": "image/gif",
        "Last-Modified": "Mon, 28 Sep 1970 06:00:00 GMT",
        "Connection": "keep-alive",
        "Cache-Control": "max-age=2592000"
      }
    },
    "producer": {
      "modsecurity": "ModSecurity v3.0.4 (Linux)",
      "connector": "ModSecurity-nginx v1.0.0",
      "secrules_engine": "Enabled",
      "components": [
        "OWASP_CRS/3.2.0\""
      ]
    },
    "messages": []
  }
}

Hi @nakacya ,
One thing I noticed that is a little unusual is your setting
SecAuditLogRelevantStatus "^[0-9]+"

This means you are telling ModSecurity to write to the audit log for transactions for any status code.  E.g. even if the HTTP Status Code is 200, that is considered 'Relevant' because of your setting, so log writing occurs.  But the "messages" portion of the log would be empty because ModSecurity has not populated it with anything because there is no information to convey.
A request for favicon.ico was likely sent by your browser (you can confirm this by using your browser's developer tools).  The favicon.ico request did not trigger any ModSecurity detections. The return code for that particular transaction was 200, but the transaction was written to the audit log anyway -- again, with an empty "messages" portion because there was no detection information to include.

THX Reply @martinhsv
I'm trying to change this setting now, but the audit log shows a return code 200.
In error log (modsecurity log), 403 is recorded normally, and 403 is also displayed in the page display, and there is no problem.
SecAuditEngine RelevantOnly
SecAuditLogRelevantStatus "^[4-5]+"

In the first place, /favicon.ico does not exist.

THX Reply @martinhsv
I'm sorry I made a mistake reading.
When I checked with the developer tool, I got the following three requests.
/xmlrpc.php?rsd=%00
/content.min.css
/favicon.ico
And xmlrpc.php was rejected. (As planned)
Others were loaded normally (this is also normal)
I think
Shouldn't Auditlog be issued only for xmlrpc.php rejection in this case?

If requests for /content.min.ss and /favicon.ico return HTTP Status 200, then, based on those settings (SecAuditLogRelevantStatus "^[4-5]+"), there will be no audit log entry for those two requests.
However, logging is also controlled other ways, including at the individual rule level.  For example you could intentionally set a rule to include 'log,pass' amongst its actions.  And other rules that are triggered, but are not intended to block may require a specific 'nolog' or 'noauditlog' action to prevent writing to the audit log.

When you get the following URL
http://xxx.xxx.xxx.jp/xmlrpc.php?rsd="

If requests for /content.min.ss and /favicon.ico return HTTP Status 200, then, based on those settings (SecAuditLogRelevantStatus "^ [4-5] +"), there will be no audit log entry for those two requests .

Yes, I understand this.
But why is there no audit log for rejected /xmlrpc.php?rsd=%00%22?
The error log (log) is output as follows.
[errorlog]
2019/12/17 23:33:53 [error] 14168 # 14168: * 3 [client xxx.xxx.xxx.xxx] ModSecurity: Access denied with code 403 (phase 2). Matched "Operator` Ge 'with parameter ` 5 'against variable `TX: ANOMALY_SCORE' (Value:` 8 ') [file "/etc/nginx/modsecurity3/activated_rules/rules/REQUEST-949-BLOCKING-EVALUATION.conf"] [line "79"] [id " 949110 "] [rev" "] [msg" Inbound Anomaly Score Exceeded (Total Score: 8) "] [data" "] [severity" 2 "] [ver" "] [maturity" 0 "] [accuracy" 0 " ] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-generic"] [hostname "<IP_ADDRESS>"] [uri "/xmlrpc.php"] [unique_id "15766256332.509958"] [ref ""], client: xxx.xxx.xxx.xxx, server: xxx.xxx.xxx.xxxjp, request: "GET /xmlrpc.php?rsd=%00%22 HTTP / 1.1 ", host:" xxx.xxx.xxx.xxxjp "

In crs-setup.conf, it is described as follows.
SecDefaultAction "phase: 1, nolog, auditlog, pass"
SecDefaultAction "phase: 2, nolog, auditlog, pass"

id: 949110 is set as follows.
SecRule TX: ANOMALY_SCORE "@ge% {tx.inbound_anomaly_score_threshold}" \
    "id: 949110, \
    phase: 2, \
    deny, \
    t: none, \
    log, auditlog, \
    msg: 'Inbound Anomaly Score Exceeded (Total Score:% {TX.ANOMALY_SCORE})', \
    tag: 'application-multi', \
    tag: 'language-multi', \
    tag: 'platform-multi', \
    tag: 'attack-generic', \
    severity: 'CRITICAL', \
    setvar: 'tx.inbound_anomaly_score =% {tx.anomaly_score}' "

In the case of setting above, it should be set that “id: 949110 is output to log and audit log”.
However, it is output to log but nothing is output to the audit log.
However, I tried changing the settings in various ways, but the situation is as follows.
・ Nolog does not work (always output)
・Auditlog is not output normally

I'm sorry but I cannot reproduce what you are seeing.  With current v3/master and the rule and configuration details that you have supplied above, I get content in the audit log including the "messages" section that specifies the rule id as 949110.
For that request (http://xxx.xxx.xxx.jp/xmlrpc.php?rsd="):
To clarify, when you say 'nothing is output to the audit log' do you mean that literally that no output at all is appearing in the audit log?  If so, that's quite different from what has been discussed so far.
If there is some content going to the audit log, and it's just missing some details like the rule id ('949110'), is the messages section present but empty? ( E.g. "messages":[]}} )?  Or is the messages section missing altogether?

Hi @nakacya ,
Although I wasn't able to reproduce what you were reporting, investigation related to your report did show a problem with the combination 'nolog,auditlog' that would affect output in some cases.
A fix for this may be available in v3/master soon-ish.  But, in the meantime my suggestion to you would be to try changing your SecDefaultAction lines to be 'log,auditlog'.

Hello @martinhsv,
I'm sorry to reply late at the end of Japan.
I understand the log.
When will you fix it?
I want to keep a schedule open if possible

Hi @nakacya ,
That fix for the 'nolog,auditlog' use case that I mentioned has been merged to v3/master.
Again, since I was not able to reproduce what you were reporting I cannot give assurance that that will fix your problem.
However, since you are using SecDefaultAction that includes 'nolog,auditlog', this newly-merged fix, might be of some help.

Hi, @martinhsv
Today I got a new repository and tested it.
After all the result did not change.
Basically, isn't the auditlog output for a deny rule?
The content of the test is as follows: The test conforms to rule: 949110, but is not output to auditlog.
1) http://www.mydomain/?Union+select
2) http://host_IP/?Param=“><script>alert(1);</ script>

I changed log, \ of rule: 949110 to log, auditlog, \ but no auditlog is output.
If deny of rule: 949110 is changed to block, auditlog is output but it cannot be protected.

Hi @nakacya,
Can you create a minimalist ruleset to test such functionality?


Fix/26888: New design when adding stop waypoint

Details
When users click Add Stop, we will redirect them to waypoint editor immediately
Fixed Issues

$ https://github.com/Expensify/App/issues/26888
PROPOSAL: https://github.com/Expensify/App/issues/26888#issuecomment-1714153645
Tests

Go to the distance request
Fill start point and finish point
Clicking Add Stop
Verify that the App redirects to the waypoint editor
Fill stop point
Verify that stop point display in the between of start point and finish point

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to the distance request
Fill start point and finish point
Clicking Add Stop
Verify that the App redirects to the waypoint editor
Fill stop point
Verify that stop point display in the between of start point and finish point

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/141406735/3d9ec44c-3dfc-47ef-afa5-3e5a04338bfb

Mobile Web - Chrome
https://github.com/Expensify/App/assets/141406735/899019f8-8210-4d48-a380-2c6930ecfc7b

Mobile Web - Safari
https://github.com/Expensify/App/assets/141406735/ee70f850-d007-4bef-959d-2ac65adb5124

Desktop

https://github.com/Expensify/App/assets/141406735/92bd9022-d6cd-4e79-a9ab-7d7273200f1d

iOS

https://github.com/Expensify/App/assets/141406735/47e8584e-215d-40d6-8caa-a6731bc7a8b9

Android
https://github.com/Expensify/App/assets/141406735/9e71a25c-4044-4411-9901-5ead49db3595

Not sure how this got assigned to me. I'm adding @thienlnam & @0xmiroslav since they are the CME & C+ for the related GH.

@0xmiroslav Bump

@0xmiroslav thanks for  this comment, why do you think it is a bug? And I see it isn't related to this PR. I am not sure but I remember that we had this bug before. If we decide to fix it on this PR we need to confirm if it is bug first to avoid regression

Thanks for lint fixing

@0xmiroslav Sorry, I miss it. I agree that we should disable next button if there is any empty waypoint.
I reproduced as your video in here and log waypoints

My suggestion is that we will disable next button if there is any empty waypoint

@0xmiroslav Could you help to last commit with the logic to disable button if there is any empty waypoint

@0xmiroslav I updated, help to check again

@0xmiroslav Updated.

We have another issue that addresses the handling for invalid waypoints - so we can just

consider onyx issue out of scope for this PR

@0xmiroslav I reverted

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.73-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Update s3, sdk-core, sqs to 2.17.149

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.143 to 2.17.149.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #450.


ZCS Azzurro 1PH HYD 6000 w/ edited sofar_g3hyd - frequent requesting or wrong registers lead to unavailability

Describe the bug
Problem is that using this integration  the inverter goes under pression and stops responding.
I hadn't had a single disconnect in the last year with the old solarman integration, while since this morning ( after migration ) I had quite a lot of them and the inverter also stopped responding to ping sometimes.
Attach the debug log
As a file or using the 'code' formatting.
2024-09-14 17:37:11.590 ERROR (MainThread) [custom_components.solarman.coordinator] Timeout fetching solarman data 2024-09-14 17:38:56.589 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Request failed. [Previous State: Disconnected (-1)] 2024-09-14 17:38:56.590 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Disconnecting from <IP_ADDRESS>:8899 2024-09-14 17:39:01.587 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Scheduling 8 query requests. #0 2024-09-14 17:39:01.588 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 ... 2024-09-14 17:39:01.588 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Connecting to <IP_ADDRESS>:8899 2024-09-14 17:39:31.590 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Request failed. [Previous State: Disconnected (-1)] 2024-09-14 17:39:31.590 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Disconnecting from <IP_ADDRESS>:8899 2024-09-14 17:39:31.590 DEBUG (MainThread) [custom_components.solarman.coordinator] Finished fetching solarman data in 30.004 seconds (success: False) 2024-09-14 17:39:36.588 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Scheduling 8 query requests. #0 2024-09-14 17:39:36.589 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 ... 2024-09-14 17:39:36.589 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Connecting to <IP_ADDRESS>:8899 2024-09-14 17:40:06.591 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Request failed. [Previous State: Disconnected (-1)] 2024-09-14 17:40:06.591 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Disconnecting from <IP_ADDRESS>:8899 2024-09-14 17:40:06.591 DEBUG (MainThread) [custom_components.solarman.coordinator] Finished fetching solarman data in 30.005 seconds (success: False) 2024-09-14 17:40:11.588 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Scheduling 8 query requests. #0 2024-09-14 17:40:11.589 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 ... 2024-09-14 17:40:11.589 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Connecting to <IP_ADDRESS>:8899 2024-09-14 17:40:41.590 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Request failed. [Previous State: Disconnected (-1)] 2024-09-14 17:40:41.591 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Disconnecting from <IP_ADDRESS>:8899 2024-09-14 17:40:41.591 DEBUG (MainThread) [custom_components.solarman.coordinator] Finished fetching solarman data in 30.005 seconds (success: False) 2024-09-14 17:40:46.588 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Scheduling 8 query requests. #0 2024-09-14 17:40:46.588 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 ... 2024-09-14 17:40:46.589 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Connecting to <IP_ADDRESS>:8899 2024-09-14 17:41:16.590 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Request failed. [Previous State: Disconnected (-1)] 2024-09-14 17:41:16.590 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Disconnecting from <IP_ADDRESS>:8899 2024-09-14 17:41:16.591 DEBUG (MainThread) [custom_components.solarman.coordinator] Finished fetching solarman data in 30.004 seconds (success: False) 2024-09-14 17:41:21.589 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Scheduling 8 query requests. #0 2024-09-14 17:41:21.590 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 ... 2024-09-14 17:41:21.590 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Connecting to <IP_ADDRESS>:8899 2024-09-14 17:41:51.591 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Request failed. [Previous State: Disconnected (-1)] 2024-09-14 17:41:51.591 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Disconnecting from <IP_ADDRESS>:8899 2024-09-14 17:41:51.591 DEBUG (MainThread) [custom_components.solarman.coordinator] Finished fetching solarman data in 30.005 seconds (success: False) 2024-09-14 17:41:56.586 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Scheduling 8 query requests. #0 2024-09-14 17:41:56.587 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 ... 2024-09-14 17:41:56.587 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Connecting to <IP_ADDRESS>:8899 2024-09-14 17:42:15.086 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 failed. [NoSocketAvailableError: Cannot open connection to <IP_ADDRESS>] 2024-09-14 17:42:15.287 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 attempts left: 4 2024-09-14 17:42:15.287 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Connecting to <IP_ADDRESS>:8899 2024-09-14 17:42:18.350 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 failed. [NoSocketAvailableError: Cannot open connection to <IP_ADDRESS>] 2024-09-14 17:42:18.751 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 attempts left: 3 2024-09-14 17:42:18.751 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Connecting to <IP_ADDRESS>:8899 2024-09-14 17:42:21.646 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 failed. [NoSocketAvailableError: Cannot open connection to <IP_ADDRESS>] 2024-09-14 17:42:22.247 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 attempts left: 2 2024-09-14 17:42:22.247 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Connecting to <IP_ADDRESS>:8899 2024-09-14 17:42:24.717 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 failed. [NoSocketAvailableError: Cannot open connection to <IP_ADDRESS>] 2024-09-14 17:42:25.519 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 attempts left: 1 2024-09-14 17:42:25.520 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Connecting to <IP_ADDRESS>:8899 2024-09-14 17:42:26.588 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Request failed. [Previous State: Disconnected (-1)] 2024-09-14 17:42:26.589 INFO (MainThread) [custom_components.solarman.api] [23984xxxxx] Disconnecting from <IP_ADDRESS>:8899 2024-09-14 17:42:26.589 DEBUG (MainThread) [custom_components.solarman.coordinator] Finished fetching solarman data in 30.004 seconds (success: False) 2024-09-14 17:42:31.587 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Scheduling 8 query requests. #0 2024-09-14 17:42:31.587 DEBUG (MainThread) [custom_components.solarman.api] [23984xxxxx] Querying 1028 - 1067 | 0x0404 - 0x042B # 040 ...
To Reproduce
Steps to reproduce the behavior:
Quite easy:  simply enable the integration and wait few minutes.
Expected behavior
Expected behaviour is that it does not hangs the stick .
Metadata:
Version:  24.09.08
Additional context
I'm not sure if the problem is the pression ( too much request ) or some register but as far as I can see there are not much differences  between old integration yaml I'm using and this one, after my cleaning.
I use sofar_g3hyd.yaml and remove every entity for the two phases no availables ( _S and _T )
I've added the screen of last update with the "hole" for the time I've had the integration.

Hi @Pigi-102, could you please provide log file from HA restart procedure? I need to see some state transition in the log to be able to determine the root cause of your issue and log snipped just contains dc period.
Thanks.

Hi, it seems similar to what I experienced and reported here https://github.com/davidrapan/ha-solarman/issues/21#issuecomment-2298052842. In my case after a couple of days the inverter was back online

Damn...
And did it ever happened to you again, @lcavalli?

@Pigi-102 have you thought to try zcs_azzurro-hyd-zss-hp.yaml for example? At first glance, it looks like a more suitable profile for your device. 😉

Hello, and sorry for the late reply.
As for the logs there is nothing more, in docker logs, than what I've put here.
At the moment I have reverted to solarman thus I can't get more info, but my understanding is that if on the solarman my yaml was fine, it should be a good starting point here, am I right ?
As I've told, at the start from your integration everything was fine and all the sensor from the yaml I'm using were "filled" and fine.
The only problem was that after some ( little ) time the inverter stopped answering to the query, but also to a simple ping.
Maybe I should try to increase the polling frequncy ( if there is a parameter in yaml ).
The solarman integration seems to poll the inverter every one minute, and is the same interval the inverter use to send data to their external servers. What is your frequency ? Is it possible to change ?

it should be a good starting point here, am I right ?

No, cause register values are always fetched dynamically. And bc you are using "wrong" profile it can try to read registers which are out of scope of your device and cripple it down.

Maybe I should try to increase the polling frequncy ( if there is a parameter in yaml ).

I'm like 99.99% sure it's not cause of that. 😉 But yes you can change it in the file.

As far as you can tell, can I have both integration installed and configured ?
I mean I would like to try the profile you say, but still I have some automation based on values from inverter that are working and would like to keep for now.
If I install this integration and configure the save inverter stick would it work ?

I will reply by my self: no ithey cannot be installed both. They have the same name in the custom_component directory.

You can install the integration manually in folder with different name.
You can transfer the data under new entity names https://github.com/davidrapan/ha-solarman/wiki/Naming-Scheme or more detailed guide is in #127.

But it's all up to you.
Have fun!

I have just now installed this integration but, just to be on the safe side, I have replaced every occurence of "solarman" with solarman_new so I should be able to catch any error I eventually get from this one and not from the "old" one.
I choosed the zcs_azzurro-hyd-zss-hp.yaml profile, as per your suggestion, but after few minutes I started to get the "became unknown" message and started loosing ping to it.

Moreover I'd like to say that on "my" ( my just because I've modified it :) ) profile, that starts from sofar_g3dhyd.yaml, I did a cleanup of every entity that reported "unknown" as state so all the register are fine, working, and with a value.  I think this "should" mean there are no register that could lead to some trouble on the stick ( if I'm correct ).
"My" sofar profile has 63 entities, while the zcs are 49 ( reading from the integration page )
In the HA logs there are no errors at the moment, after several "become unknown" message.
Do you want me to do some more tests ( or eventualy activate the debug ) ?
Let me know.

Hi, can you please also enable debug logging and try to catch the point when it becomes unavailable? It looks like it happenas rather quickly so maybe it won't be that hard? It would be really helpful!
Thanks!

home-assistant_solarman_new_2024-09-22T07-43-16.313Z.log
Here the log that tracks down completely a "disconnected" event.
The event started at 9.41.23 and ended at 9.41.28

Thanks! I'll look into it.
In a meanwhile could you try add into your custom profile requests_fine_control: right above the requests: so it looks something like this:
requests_fine_control:
requests:
  ...

That should restore the original behavior and could potentially reveal if the issue is cause of the wrong registers or not.

At the moment I'm not using my custom profile on your integration.
As per you suggestion I'm using zcs_azzurro-hyd-zss-hp.yaml.
Should I change to my custom and try again  ?

Best would be to try both to be honest.

Yes, cause zcs_azzurro-hyd-zss-hp.yaml does not have full request sets.

That was a bad call from me cause you would have to use that profile with full requests sets so do it with your custom one only. 😉

I think that when entity names are indentical, in different integrations, something weird happens.
I have renamed all enetity names in my custom sofar and restarted, just to be on the safe side.
I'll let you know what happen now.

It's funny how now it's working flawlessy.
I would give a try again by removing the "old" solarman, renaming the entities and getting this new one, but it will not happen before next w.e.

It seems that now it's well working.
It's four days i'm using the new integration and so far I haven't had the issue. I'll close this one.
I will eventually open a new one in case there are other problems. Thank you very much.


Could not build Objective-C module?

Hi, I am having an issue with SQLite. Ever since I have updated my version of XCode to version 6.3, I have been getting an issue saying that it cannot find the module SQLite3 when I try to import it into my files using import SQLite. As a result, I resorted to deleting the entire SQLite folder from my project and re-adding it to my project. However, now I am getting issues saying Header '/usr/include/sqlite3.h' not found and Could not build Objective-C module 'sqlite3. It was all working for me previous to this but now I have no idea and every time i re-add the folder to my project, I get this error or an error saying Coudl not build Objective-C module SQLite. Any help would be appreciated. Thanks!

Hm, that might be related to this commit:
https://github.com/stephencelis/SQLite.swift/commit/2bf90d49cc982589b6d7ed9585f3f8f41ccf3263
Can you try checking out the commit just prior and see if that solves your problem?
https://github.com/stephencelis/SQLite.swift/commit/213920b2f65d7ae92bb2c93cfa02a2e6e19f8ee9
(Here's a download link if you're not using git: https://github.com/stephencelis/SQLite.swift/archive/213920b2f65d7ae92bb2c93cfa02a2e6e19f8ee9.zip)

Ah that seems to work better but now I am getting an error saying Cannot load underlying module for 'XCTest'. Any ideas on how to fix this?

I'm also getting the same issue, after updating to commit: https://github.com/stephencelis/SQLite.swift/commit/2bf90d49cc982589b6d7ed9585f3f8f41ccf3263

Reverted that commit, so master should hopefully work fine now!
@schan93 As far as Cannot load underlying module for 'XCTest' goes, it means you're somehow linking against the test target. Please re-read the installation instructions and avoid any cases of SQLite Tests, etc.

"import Foundation" fixed it for me

this bug has been fixed right? I'm getting the "Could not build Objective-C module 'SQLite' "

I'm getting this as well, along with "Header 'SQLite-Swift.h' not found."

@clehew how do you integrate SQLite.swift into your project?

@jberkel  CocoaPods.  XCode 8.2, Cocoapods v1.1.1, pod 'SQLite.swift', '~> 0.11.1'

@clehew and Xcode installed in /Applications/Xcode.app?

@jberkel  yes

@jberkel  I moved it, still didn't work, then I uninstalled/reinstalled, still not working, same error

@clehew. hmm, weird. can you try if a minimal project via pod try SQLite.swift compiles ok?

@clehew Hi, I've had the same issue today(Xcode 8.2, pod 'SQLite.swift', '~> 0.11.1' ).
it's been fixed with moving Xcode to /Applications/Xcode.app and running this line in terminal:
sudo xcode-select --switch /Applications/Xcode.app

@ehsan-black thanks for the hint, will add it to the instructions

@jberkel  Sorry for the slow response, I have been away on vacation, but I'm still fighting this strange error.  I know now that is probably not Sqlite.swift.  I have managed to see the error change to SnapKit-swift.h on a few occasions and I was able to create a bare bones project that built fine.  this is the set of errors I'm getting if you have any ideas.
I'm at a loss at this point, I've event updated to the latest cocoapods beta because some people claimed that helped for another library.

@clehew I have no idea, but looks like a bigger config problem in your project. To troubleshoot I'd simplify the project (remove files which cause an error) until the project builds successfully.


SALEOR-4122: ExternalNotificationTrigger mutation

I want to merge this change because contain new mutation called externalNotificattionTrigger.

Impact

[ ] New migrations
[x] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[x] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[x] The changes are tested
[x] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-4122 Create ExternalNotificationTrigger mutation that allows apps to trigger notification events

Missing changelog.


[Feature]: Improve readability of selected items in

What problem does this feature solve?
Show selected items in <MultiSelect/> instead of summarizing the selection ("3 selected", see current version: https://www.tremor.so/docs/components/select). This improves accessibility / user-friendliness as selected items can be directly seen in the input field.
What does the proposed API look like?

Requirements:

Each selected item can be deselected via close button
global close button allows to deselected all items
Fixed width for selected items with truncate
Selected items are horizontally scrollable

Hi Christoph, I would like to be assigned for this feature.

Thank you both! Assigned it to @jzfrank because he was first, but feel free to tackle it together :)

https://github.com/tremorlabs/tremor/releases/tag/v3.7.0


Resolves #7 Dockerization

I'm reviewing this on https://gitpod.io/#https://github.com/pondersource/CYB/pull/8

@michielbdejong yes https seems to be problematic for horizon dashboard.
I try to solve it now.

Ah, horizon "thinks" it's running on http. See https://github.com/laravel/horizon/issues/631

Horizon assets fixed now :)
It will now probably break if you try to run it outside gitpod but then you will just see broken icons which will be less annoying than huge icons :)

@michielbdejong Nice! so there is the problem!
maybe we can fix it by providing an ENV variable inside PHP to instruct it which scheme to use, then we can tell our container if its on localhost or on gitpod by an ENV variable like:
-e HTTPS=ON

@yasharpm Can we merge this into main now?
Note that #10 was built on top of this, so the whole Dockerisation work was merged into the queue branch, but this is still not merged into main.


Split tags off into their own component, move tags to above author, restyle tags

Resolves

Hmm, the hashtag position above author seems unusual to me, what do yall think about this design?


Handle JSONParser#get_child_node for nested arrays

The changes are 👍 , but I'm wondering if there are any additional tests that are worth adding here. Can you also provide a little context about why the fix was needed?

This was admittedly a bit rushed, as I was feeling progressively worse yesterday (hence the lack of tests). The short version is that 'location' fields have a nested list [[{...}]]. The existing code couldn't handle this, as it would try to pass the field name to an array and fail on "No implicit cast String to Integer".
The change to #value is due to ChildDeclaration using it for comparison. nil would always match nil, leading to duplicate values.
There are probably improvements that could be made, and I'm happy to work on tests. Whether we want to wait, or push forward and clean up later is another question.

Sent @no-reply a Slack message about this and its relation to an issue we were troubleshooting last month.

@no-reply @anarchivist @moltude: I am taking over the fixes to this branch in order to get this merged today.

sorry @no-reply @anarchivist @moltude, please ignore that last comment. I'm just going to merge this after rebasing.

I am merging this with an additional commit that temporarily works around an issue with Travis. Please see the comment in https://github.com/dpla/KriKri/pull/267/commits/25288e3b0fa5be95140039c5dbcc16a7a42c5ebf


Properly Generate Variables of Reference Types

Fixes: https://github.com/microsoft/typespec/issues/3747

API change check
APIView has identified API level changes in this PR and created following API reviews.
Microsoft.Generator.CSharp


Create Modern Template option in document library

As mentioned in the Microsoft 365 doc https://github.com/MicrosoftDocs/microsoft-365-docs/blob/public/microsoft-365/syntex/content-assembly-modern-template.md
I am trying to create a modern template from document library, but couldn't find the option.

@dineshR86 Thank you for your feedback. It does show on my tenant and looks like this could be a bug. I'd recommend you contact support via the need help section on the admin center, so that our support engineer can fix or escalate if need be.
Hope this helps!
Thanks
Sri


hubspot form manual trigger set up, can now properly measure form sub…

…mits

additional changes done in GTM dashboard