fix: the connection must be closed in other states

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you! Could you please tell me under which circumstances this becomes a problem?

For example, when the connection is closed on the handshake. In this case, it does not close.

There are many different situations where the connection can be closed before setting the state STATE_CONNECTED

For example, when the connection is closed on the handshake. In this case, it does not close

Ah, yes, makes sense! Thanks.


Fix Graph Node close rect default position

The Graph Node has an optional close button that can be shown or hidden. When the close button is shown, it's positioned in a way where it visibly extends over the outer right edge of the node. This can be fixed by using theme overrides in the inspector, but by default, it's positioned awkwardly.
It would appear that the button is positioned so that its center aligns with the outer margin of the node when in reality, it should be the right edge of the button that's aligned with the right margin of the node.
Current default behavior:

New behavior:

This makes more sense as the default position than the current behavior. Having the close icon properly aligned means it won't have to be realigned by the user for every new node.

Upon further investigation, it would appear that there is a discrepancy between the visual shader graph nodes and the scene graph nodes in regards to the position of the close button

The in-engine visual shader nodes already have the close button properly aligned, so now my changes push it further to the left. Not sure why this difference exists in the first place.

I agree.

Thanks!

Cherry-picked for 4.0.1.


feat: add link to star project in menu

fix #369
Fixes Issue
My PR closes #369
👨💻 Changes proposed(What did you do ?)

added star the project link (GitHub button)
removed contribute to project link

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

Before

After

:tada: This PR is included in version 2.45.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


CustomDocument dispose() is not called on exit from vscode

I'm working on a custom editor for remote resources and it's important to me to close the edit sessions at the close of the editor. It seems that CustomDocument dispose() is not called on exit.
It can be reproduced in https://github.com/microsoft/vscode-extension-samples/tree/main/custom-editor-sample
If I'll open PawDrawDocument and close the vscode, a dispose method of PawDrawDocument is never called.

Ups, wrong repo, moved to https://github.com/microsoft/vscode/issues/128762


v4.6.0 breaks rspec controller tests

Environment

Ruby 2.4.5
Rails 4.2.7
Devise 4.6.0

Current behavior
I just updated to 4.6.0 (no other changes were made) and the rspec controller tests now return undefined method root_path after running a sign_in.
4.5.0 does not exhibit this behaviour.
Expected behavior
root_path should return a value.

Hi @philayres, thanks for the issue.
Could you provide more info about what is happening in your application? It could be an application that reproduces this issue in isolation or just the stacktrace.

This is the rspec example:
  describe "GET #new" do
    before_each_login_user

    it "assigns a new item as @var" do
      master_id = create_master.id
      get :new, {master_id: master_id}
      expect(assigns(object_symbol)).to be_a_new(object_class)
    end
  end

The error is:
  6) AddressesController behaves like a standard user controller GET #new assigns a new item as @var
     Failure/Error: get :new, {master_id: master_id}

     NoMethodError:
       undefined method `root_path' for #<Module:0x000055bff178b7f0>
     Shared Example Group: "a standard user controller" called from ./spec/controllers/addresses_controller_spec.rb:20
     # ./spec/support/standard_user_controller.rb:53:in `block (3 levels) in <top (required)>'

That error aligns with the rspec example. But in reality every similar example like this fails.
As soon as I rolled back to 4.5.0 the error went away.

Oh, and the method for logging in
  def before_each_login_user
    before(:each) do

      user, pw = ControllerMacros.create_user
      @request.env["devise.mapping"] = Devise.mappings[:user]

      res = sign_in user
      @user = user
    end
  end

I have both a user and admin entity working independently.

Could you also send the stacktrace? that would help find where it's breaking inside Devise.

That's the strange thing. In the console you have the full error that I have in the comment above (which is strangely short). In the test log, despite having changed logging level to :debug it still doesn't give me the error or any stack trace.
I'm assuming that there is something nasty happening low down the stack that is getting swallowed up without logging. I'll keep digging to see if I can find more info.

I have stepped through in a debugger and have narrowed it down to:
gems/devise-4.6.0/lib/devise/test/controller_helpers.rb around line 140:
def _process_unauthenticated(env, options = {})
        options[:action] ||= :unauthenticated
        proxy = request.env['warden']
        result = options[:result] || proxy.result

        ret = case result
        when :redirect
          body = proxy.message || "You are being redirected to #{proxy.headers['Location']}"
          [proxy.status, proxy.headers, [body]]
        when :custom
          proxy.custom_response
        else
          request.env["PATH_INFO"] = "/#{options[:action]}"
          request.env["warden.options"] = options
          Warden::Manager._run_callbacks(:before_failure, env, options)

          status, headers, response = Devise.warden_config[:failure_app].call(env).to_a

This final line is where it dies.
My guess, not knowing the internals of the code, is that this is forcing a redirection when a user is not logged in? But in previous versions my user would have been successfully logged in prior to this point. So I don't really understand either this error, or why I would have arrived here unauthenticated.
Of course, it is possible that I'm not understanding what is going on here.

Are you using Rails engine? The only this that I can think now that was released and could break the root_path is this PR: https://github.com/plataformatec/devise/pull/4700#issuecomment-456465399
We came up with this solution to check if the root_path is defined. Not sure if could be something here.
Are you able to reproduce this issue in new app?

Just to make sure, have you the root_path defined in your routes?

@philayres We were able to reproduce the issue with the following scenario: a Rails application that doesn't have a root defined and after an unsuccessful login attempt.
After the commit mentioned by @feliperenan, we started calling url_helpers.root_path, which is causing the failure now. We tried to prevent this by using #present? by now it's clear that it should have been a #respond_to? instead.
This is definitely a regression and we're going to push a fix as soon as we can. But, what concerns me the most about your report is that in your tests you're expecting the user to be logged in successfully, but right now the authentication is failing.
Can you point your application to the let-fix-root-path branch and test it again? This way we can remove this error and see whether there's another issue happening there.

Ok, I just checked out the branch you suggested. As you guessed, this helped, but did not solve all the problems. The following steps through where I have looked to identify the root cause. Sorry if some of it is irrelevant; I just want to make sure I don't miss something that could be meaningful.
Running the spec again I'm now getting different errors:
  1) AddressesController behaves like a standard user controller Ensure authentication returns a result
     Failure/Error: expect(response).to have_http_status(200), "Attempting #{@user}"
       Attempting<EMAIL_ADDRESS>     Shared Example Group: "a standard user controller" called from ./spec/controllers/addresses_controller_spec.rb:20
     # ./spec/support/standard_user_controller.rb:21:in `block (3 levels) in <top (required)>'

  2) AddressesController behaves like a standard user controller GET #index assigns all items as @vars
     Failure/Error: expect(assigns(objects_symbol)).to eq([item])

       expected: [#<Address id: 127, master_id: 1233, street: "7708 main st", street2: "apt #14", street3: "(rear of b...19-02-09 11:25:05", updated_at: "2019-02-09 11:25:05", country: nil, postal_code: nil, region: nil>]
            got: nil

       (compared using ==)
     Shared Example Group: "a standard user controller" called from ./spec/controllers/addresses_controller_spec.rb:20
     # ./spec/support/standard_user_controller.rb:32:in `block (3 levels) in <top (required)>'

Stepping through an authentication reveals an issue with the authentication.
Where I call sign_in user in the before block, the authentication doesn't work as expected (but does not fail with an exception). Stepping through, where I hit
`lib/devise.rb`
   480:         warden_config.serialize_into_session(mapping.name) do |record|
=> 481:           mapping.to.serialize_into_session(record)
   482:         end

and subsequently lib/devise/models/authenticatable.rb
   233:         def serialize_into_session(record)
=> 234:           [record.to_key, record.authenticatable_salt]
   235:         end

... I spot a problem. The record.authenticatable_salt returns nil, because record.encrypted_password is empty.
If I force a value with record.password = 'some password that works' and allow the rest of the example to run, it passes, where previously it was redirecting due to a lack of authentication.
Something must have changed in this area, where the encrypted_password was not previously required. I have recently added some code to my user model that nils the plain text password attribute after saving. This has the side effect it seems of making the encrypted_password attribute nil too. So either the test code around serialize_into_session is working differently in this version, or the encrypted_password is being cleared where it wasn't before.
It feels to me that it is the test code that has changed, since human testing in development runs fine.
I will keep digging to see if I can spot what has changed and where.

OK, easier to find than I expected.
Blame database_authenticatble.rb https://github.com/plataformatec/devise/blame/master/lib/devise/models/database_authenticatable.rb shows line 63 forces the encrypted_password to nil even when password is nil, which is a change from previously. This has the side effect I'm seeing that the spec test won't create the user session because my code has cleared the plain text password.
The reasoning for me clearing the plain text password after save in the user model is that I'm checking for actual password value change (encrypted_password_changed? doesn't work with BCrypt due to dynamic salts) and I was getting leakage of the plain text password into tests around this (among other things), and wanted belt and braces to avoid accidentally showing the password where I shouldn't... Or something like that anyway.
So from the point of view of Devise, the above change broke my tests (and maybe others will experience this). For now I'm going to dig some more to decide whether I adapt my code or propose a change in Devise.

Referencing #4245 / #4261 so I don't have to keep digging around to find out what broke things.

@tegon I didn't answer your previous question about the root_path. No, my application does not have it set. I have relied on an application_controller to redirect to specific paths under certain conditions. No reason why I couldn't set the root_path as a fallback though.

@philayres The root_path issue was regression so we're going to release it soon in the version 4.6.1.
About the encrypted_password being set to nil, we did it to keep it in sync with the password field and prevent possible security issues - e.g. before valid_password? would return true for a cleaned password.
As for your concern of leaking the password, Rails already replaces it with the value "[FILTERED]" in the logs via the config.filter_parameters option and we hide it when #inspect is called so that it's not presented on exceptions, for example.
irb(main):007:0> u = User.first
  User Load (0.4ms)  SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT $1  [["LIMIT", 1]]
=> #<User id: 2, email<EMAIL_ADDRESS>created_at: "2019-01-30 12:50:45", updated_at: "2019-01-30 13:03:57">
irb(main):008:0> u.password = '123'
=> "123"
irb(main):009:0> p u
#<User id: 2, email<EMAIL_ADDRESS>created_at: "2019-01-30 12:50:45", updated_at: "2019-01-30 13:03:57">
=> #<User id: 2, email<EMAIL_ADDRESS>created_at: "2019-01-30 12:50:45", updated_at: "2019-01-30 13:03:57">
irb(main):010:0> puts u
#<User:0x00007fe579b64f20>
=> nil

Also, Rails 6 will come with a feature called inspection_masks which will do a similar thing for models.
I'm not sure if those cover the cases you're worried about. If they don't, please let me know the exceptions.
Thanks.

The actual challenge I had was that my model forces password changes after first sign in, and these were breaking specs. For example, if I am running a series of controller tests like this:

a user / password is created
sign in is successful
the user is forced to change password (and the password is not the same as before)
perform some meaningful action that requires me to be authenticated
sign out

I have many combinations of these types of things to ensure the implementation in my application actually does both what Devise claims and what the auditors might check for.
The challenge was that in these series of model tests was that holding the plain text password between the steps above wouldn't allow for sensible checking whether a new password had been provided for sign in or to update the record, etc. My model code never knew if the password had changed (possibly a convoluted set of checks going on in my implementation) and could not fire callbacks consistently. Basically having the ability to clear the plain text password attribute automatically on save allowed complex test sequences to run without having to constantly reload the user record at every step, or worry that the password was being extracted from the user record in some other unrelated chunk of code. This is the leakage I mean; the password was leaking from one mode of use (creating the user) to another (testing authentication, checking for password change, validating password age, viewing user details etc)
Anyway, I can make the changes to allow my specs to run without clearing the password attribute after save, by reloading user records representing more how a series of web requests would actually run. It breaks things from previously, but maybe I can accept that.
I'm still not happy that the controller tests fail so obscurely when password is set to nil. The controller sign_in appears to work fine, but when it comes to actually using the authenticated controller you find out that actually you weren't signed in. Sign in doesn't provide any meaningful information in this regard. That could mean I have obscure tests that are looking to check that a sign_in where a user record has been manipulated will just fail without warning. Is this expected behaviour? Presumably it needs a separate issue to address it, which I'd be happy to create if you believe it is not expected behavious.
Thoughts?

By looking at this thread, I'm also having similar issues with v6.4.1
undefined method `root_path' for #<Module:0x007fb3415f0e50>

which points to this:
def root_path_defined?(context)
    defined?(context.routes) && context.routes.url_helpers.root_path.present?
end

I don't have a root_path defined. Will having a root_path defined will be something necessary from now on?

@rodrigo-puente Nope, that was fixed in version 4.6.1. Can you try to update and see if the error is gone?

@philayres I don't get exactly what the issues were to create your specs - if you want to create a sample application I can take a look at them and see if I can think of another solution. But when you said:

I can make the changes to allow my specs to run without clearing the password attribute after save, by reloading user records representing more how a series of web requests would actually run.

I understood that this issue is only for your test environment - please correct me if I got it wrong - when you test it manually in a browser everything works correctly? If that's the case, I'd say it's better to keep the specs as close to the reality as possible. It's a bummer when the tests are failing but the system is working fine due to differences from environments.

It breaks things from previously, but maybe I can accept that.

I know this is bad but the reason we released this change in a minor version is that we consider the old behavior a bug. We fixed and thought it wouldn't have those kinds of issues but it's hard to know how the code is being used throughout applications out there. We are sorry it's going to cause you trouble to update but we think it's the best way to go.

@tegon this is probably a good time for me to go back and DRY up my tests anyway. Things have got messy over time. Thanks for you thoughts and rapid response to this issue. I'll close it now.

Regarding nilifying #encrypted_password, I may missing something, but if, when I load a user model, #password  is blank(as it's defined merely by attr_reader),  won't any subsequent save of the user model cause encrypted_password to be cleared and persisted?

@erich-team Not sure if I understood correctly, is this what you mean?
❯ rails c
Running via Spring preloader in process 35300
Loading development environment (Rails 5.2.2)
irb(main):001:0> u = User.first
  User Load (0.5ms)  SELECT  "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT $1  [["LIMIT", 1]]
=> #<User id: 1, email<EMAIL_ADDRESS>created_at: "2019-02-21 19:05:54", updated_at: "2019-02-22 19:01:31">
irb(main):002:0> u.password
=> nil
irb(main):003:0> u.encrypted_password
=> "$2a$11$rHW3mrrB6nzBIjueG1rSgOy2Dt4vStVk.3QLA4yWJS8yR0/Y1Jjym"
irb(main):004:0> u.save # encrypted_password is not updated to nil here
   (0.3ms)  BEGIN
   (0.3ms)  COMMIT
=> true
irb(main):005:0> u.password
=> nil
irb(main):006:0> u.encrypted_password
=> "$2a$11$rHW3mrrB6nzBIjueG1rSgOy2Dt4vStVk.3QLA4yWJS8yR0/Y1Jjym"
irb(main):007:0>

The encrypted_password will only be set to nil after password is by calling password= directly.

The issue appears to be with strip_whitespace_keys.
This...
config.strip_whitespace_keys = [:email, :password, :password_confirmation]
... config/initializers/devise.rb, results in password= being called every time.
Obviously, the simplest solution is to not include password and password_confirmation, but it seems like this might be less than ideal.  I have a user base that isn't necessarily... adept ...adept at typing and have to do things like strip white-space from these attributes.

@erich-team I see 🤔
I'm not familiar with your user base or your application at all, but it seems to me that it's dangerous to change the password input in any way. I mean, theoretically, one could choose to deliberately include a white space on their password.
If you want to prevent them from including those spaces as mistakes, I think it would be better to add a validation for this and let them know that they've typed their password with an extra whitespace so that they can fix it. Does that make sense to you?

My user base is truck drivers. :)  Good people, not always the most
accomplished typists.  That said, we do have a work around.
On Thu, Feb 28, 2019 at 8:33 AM Leonardo Tegon<EMAIL_ADDRESS>wrote:

@erich-team https://github.com/erich-team I see 🤔
I'm not familiar with your user base or your application at all, but it
seems to me that it's dangerous to change the password input in any way. I
mean, theoretically, one could choose to deliberately include a white space
on their password.
If you want to prevent them from including those spaces as mistakes, I
think it would be better to add a validation for this and let them know
that they've typed their password with an extra whitespace so that they can
fix it. Does that make sense to you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/plataformatec/devise/issues/5021#issuecomment-468293945,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfbsCZvV9sMEeZc8lBtSU6ZVzOFCXpqVks5vR-iygaJpZM4awdbL
.

--
Erich L Timkar

@erich-team Since this broke a lot of existing applications like yours, we decided to roll back the original change. If you want to return to the original behavior you can update to version 4.6.2.
Thanks!


This is a very large commit that does the following:

Code was restyled for readability. Mostly this was line breaks so that code lines are generally shorter than 120 characters.
Added an argument --longitidunal. This argument flags that subject folders contain second level ses-xxx folders. This is a stop-gap until a more PyBIDS-styled daa grabber can be implemented.
Added an argument --session. This argument is for specifying the session to be run. Currently for longitudinal runs, this is required in order to select a session (e.g., Baseline). This is a string without the ses- portion
Added an argument --fmriprep. This allows the preprocessed T1s from fMRIPrep to be used. This currently requires mounting the fmriprep folder as :/fmriprep. For longitudinal datasets, this presumes that there are not relevant structural change son the T1-weighted imaging, so that the fMRIPrep averaged output is acceptable for all DWI sessions.
Updated documentation to describe these options.

Sorry I've not gotten around to getting through this earlier; this tool has unfortunately been pretty low on my priority list.
I think what I want to do here is split the single large commit out into multiple topics, and then address each separately. Particularly with the formatting changes incorporated, it makes the diff tough to assess.

I'm often lazy with this, and should do better. But my preferred syntax for reducing line widths is different to how you've formatted things here. So I think I'd prefer to do this myself at some point (shouldn't take me too long) simply so that my own code remains familiar and welcoming to me.

It feels really clumsy to necessitate to the user that they must specify that such data exist, rather than detecting the presence of such. Maybe it might be possible to fairly quickly write up something that will simply find, for each directory at the root of the input data, any sub-directory (at any level of nesting) that looks like a BIDS dataset, and run each of those in turn, duplicating the directory structure in the output path. So not actually a PyBIDS parsing, just looking for "anything that looks like an individual session", regardless of the parent directory structure.

In the case of 2., options --participant-label and --session simply become modifiers whenever a directory at any point in that nesting commences with sub- or ses-.

I've no experience with this, so will somewhat need to lean on your experience. Probably the main request I would make would be for the location of the fMRIPrep data to be an input to the command-line option rather than a fixed location. I've put a decent amount of effort into ensuring that this script can actually operate as a stand-alone executable outside of a container environment as along as all software prerequisites are met, so wouldn't want to break that.

No problem. I modified this to make it work for what I needed as a stop gap but as we've proven there were other things that clearly weren't working as intended. And I agree with breaking this into smaller chunks and I don't mind helping if you don't mind (once 0.5.0 gets merged, since there are some more sweeping structural changes in the script that would be hard to directly translate over).

Regarding syntax, I'm fine with whatever you want to do. I was just broadly aiming for PEP 8 compliance with tabs and line breaks.

I agree that something that detects the folder structure is far better as specification is clunky. Just so I'm understanding, you'd still keep the --participant and -session options so that specific participants and sessions can be run, you'd just be looking for the script to figure out that this is valid.

Agreed.

Understood. I'd have to think about how that works for the stand-alone version. For Docker this is easy because you mount the target fmriprep folder is a root-level folder. However, in the stand-alone command line version this equally easy because, for instance, I have derivatives/fmriprep-1.4.2/ and derivatives/fmriprep-1.5.0/ and could just tell it which one. I guess there could just be a --fmriprep option with a string to follow (e.g. fmriprep-1.5.0) and the whole derivatives folder gets mounted in Docker. I'll toy with it.

I've kind of gradually made small steps in that direction. Am never going to be fully PEP8 compliant as in MRtrix3 we've always used 2 spaces for indentation since before there was even any Python involved; it just carried over from our C++ convention and it's what we're accustomed to. In MRtrix3/mrtrix3#1449 (which this tool won't be updated to match until after the MRtrix3 release) the pylint testing becomes a bit more stringent w.r.t. things like variable / class / constant names and the like, but still not fully PEP8. I use the same pylint config file as the corresponding version in MRtrix3 for checking this script over.

I really should have a quick look at PyBIDS; there's every chance it might in fact be quite easy to integrate and solve the issue properly...

:+1:

Yep, all it should require is for --fmriprep to have one argument following it, being a string specifying the derivative input location; any docker run call would need to mount the data to the corresponding location.

Okay, hadn't realised the particular style you used here for breaking functions across lines is in fact the PEP8 preferred way. Adding in all the line breaks in order to reduce column widths then also makes four-space tabs vastly preferable to two. So I'll need to make a decision as to whether I want to converge the code style of this particular script away from the convention we're using in MRtrix3...

The ability to process longitudinal data & select sessions to process should be dealt with in a reasonably robust fashion in 63e0591. So the remaining item in here that would still be of interest would be the use of T1-weighted data from fMRIPrep. Ideally this would be implemented in a reasonably robust fashion, both exploiting the session identification structure from 63e0591 and doing a reasonable search in the filesystem for how such data may have been provided by the user, e.g. one image per subject or one per session. Combining data across sessions may not be desirable in every scenario (e.g. consider one subject but pre- & post-surgery), so I'd rather not have this to be fixed behaviour, and instead be based on the input data detected. As previously mentioned the path to the fMRIPrep derivatives directory needs to be specified in the use of the command-line option, rather than being a fixed path.

Is the "_desc-preproc" entity fixed & predictable from fMRIPrep output?

Is that image guaranteed to not be already skull-stripped, or is this a setting that could be changed in fMRIPrep (and hence this script would need to check the contents of a sidecar JSON)?

What are the actual processing steps applied to those data that make it desirable to make use of such rather than the raw T1-weighted data? Is it only the averaging of data across sessions? I'm guessing there's a bias field correction step in there as well given you're skipping that step? How does that perform compared to N4?

@araikes: The final outstanding feature requirement here, that of providing a pre-processed T1-weighted image from fmriprep, should be dealt with now in the dev branch following merge of #73 (option is called -t1w_preproc, since it could theoretically come from the derivatives of some other BIDS App).
Unfortunately with the way that the code paths diverged and I had to re-implement the features you wanted myself, it means that your commits here won't actually make it into the Git history. I will nevertheless be in contact with you when I eventually get around to creating a publication for this tool over and above the existing OHBM abstract, since your suggests here have helped to shape the software.
Cheers
Rob

Hi @Lestropie ,
No worries. I'm excited to see this software come to fruition. Let me know how I can help in the future.


[FAQ] Added FAQ related to ValueError in job failure

This PR is a part of the issue: Move FAQs to the GTN (Determining the job failure type) of the Galaxy Hub Repository
Kindly suggest any improvements or amendments.
Thanks to @jennaj for helping me with the content.

Great!! Note: we should consider creating a distinct FAQ category for this type of FAQ (an exact keyword match for the error metadata). Leaving it in this category is fine for now.

Sure, I can work towards it. Can you share the source link to refer to all the other error types!

I am getting some failed checks! Kindly help.


chore: move perfomance scale tests to other perf tests

Description
Move scale tests together with other performance tests.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
N/A
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

@janisz I would suggest separating the kube-burner and k6 tests. Maybe we can have a structure like this:
performance
|- load
|- scale

@mtodor Is it better now?


Assert error when constructing dist maps of ground truth

Thanks for your great work. I am really enjoy it.
I am trying to modify your code to work on my project which is a binary segmentation problem (C =2 ). When I attempt transforming the loaded image of shape wh to C distance maps with shape cwh, I got assertion error.
I follow your implementation below:
    dist_map_transform = transforms.Compose([
        lambda img: np.array(img)[np.newaxis, ...],
        lambda nd: torch.tensor(nd, dtype=torch.int64),
        partial(class2one_hot, C=n_class),
        itemgetter(0),
        lambda t: t.cpu().numpy(),
        one_hot2dist,
        lambda nd: torch.tensor(nd, dtype=torch.float32)
    ])

My code for transforming load image to dist maps is as follows:

mask is a (H, W) numpy array

mask_tensor = torch.tensor(mask, dtype=torch.int64)
mask_onehot = class2one_hot(mask_tensor, 2)
mask_distmap = one_hot2dist(mask_onehot.cpu().numpy())

Corresponding error is:

assert one_hot(torch.Tensor(seg), axis=0)
AssertionError

I found this error happened in one_hot2dist. It  seems that there is some wrong with mask_onehot. But I do use your code without any modification. Why would this happen? Could your please give me some suggestions ? Thanks al lot. I am really appreciate.
Best

Ah, yes, my bad.
Most of the utils works with shape bcwh, except one_hot2dist. And class2one_hot adds automatically an axis if needed:
def class2one_hot(seg: Tensor, C: int) -> Tensor:
    if len(seg.shape) == 2:  # Only w, h, used by the dataloader
        seg = seg.unsqueeze(dim=0)
    assert sset(seg, list(range(C)))
    assert len(seg.shape) == 3, seg.shape

    b, w, h = seg.shape  # type: Tuple[int, int, int]
    ...

This is why I added an itemgetter(0) in the transform. The code evolved in a weird way, and I also had to play around with utils expecting Tensor or np.ndarray
So what happens, and how to fix this (type hint won't work but useful to explain):
mask: np.ndarray[hw]
mask_tensor: Tensor[hw] = torch.tensor(mask, dtype=torch.int64)
mask_onehot: Tensor[chw] = class2one_hot(mask_tensor, 2)[0]  # because the res is bchw
mask_distmap: Tensor[chw] = one_hot2dist(mask_onehot.cpu().numpy())

I will probably change this behavior in the future ; this is too error prone right now. But at least the assertions makes it easy to catch it.

Thanks for your great work. I am really enjoy it.

Glad you find it useful!

Hi @HKervadec , thanks for your quick reply. I can run the code now; however, I encountered another problem. I have done something like this:
····python
region_loss = GeneralizedDice(idc=[0, 1])
surface_loss = SurfaceLoss(idc=[1])
for input_image, dist_maps in dataloader:
# input_image: bwh
# dist_maps: bcwh
optimizer.zero_grad()
output_logits = net(input_image)  # bcwh
output_softmaxes = F.softmax(output_logits, dim=1)  # bcwh

loss = region_loss(outputs_softmaxes, dist_maps, None)  + surface_loss(outputs_softmaxes, dist_maps, None)

loss.backward()
optimizer.step()

The region loss does not take the distance map as an input, but mask_onehot:
for input_image, dist_maps in dataloader:
    ...
    loss = region_loss(outputs_softmaxes, dist_maps, None) + surface_loss(outputs_softmaxes, dist_maps, None)
    ...

should be
for input_image, onehot_labels, dist_maps in dataloader:
    ...
    loss = region_loss(outputs_softmaxes, onehot_labels, None) + surface_loss(outputs_softmaxes, dist_maps, None)
    ...

But funny that the distance maps pass the simplex assertion in the GDL loss ; did not realize it could. I guess I should replace it with  one_hot (which is literally simplex and sset([0, 1])

Well, thanks for your generous help. I can train and evaluate now. But there are still something that I am not sure whether they are correct or not. e.g.,
After few epoch training, I get these results below:

contour_loss=0.01294, region_loss=0.55355, total_loss=0.56649 (training stage) --> jaccard: 0.00000
contour_loss=-0.00360, region_loss=0.42092, total_loss=0.41732 (training stage) --> jaccard: 0.60041
contour_loss=-0.01631, region_loss=0.23017, total_loss=0.21387 (training stage) --> jaccard: 0.62058
contour_loss=-0.01778, region_loss=0.23821, total_loss=0.22043 (training stage) --> jaccard: 0.63152
...

Why the contour loss will become negative? Is this negative contour loss correct or not? Thanks.
Best!

Is this negative contour loss correct or not

Yes. The distance map is signed ; negative inside the object, and positive outside of it. So a perfect segmentation will be multiplied only with negative distances: the optimal value is negative.

Should we stop training if it is negative? I trained on dice on a small dataset for 20 epochs and I then put your surface loss which started at around -0.7

Should we stop training if it is negative? I trained on dice on a small dataset for 20 epochs and I then put your surface loss which started at around -0.7
Edit: I did continue and with decreasing the learning rate I got a 0.2+ on my dice score :) . I saw the training procedure in your paper about decreasing alpha. Would like any insights to how dice and surface loss interact and any training advice for better optimization.
Thanks, good work

Actually forgot to reply before closing it.
Basically you stop once the loss function does not improve anymore (reaching convergence), and/or validation dice stopped improving. This does not differ on how you usually decide to stop a training.
The best achievable value for the boundary loss would be (- (distance(posmask) - 1) * posmask).mean(): there is a perfect overlap between the predicted object and the ground truth, so we are summing only negative distances inside the object. Notice that this optimal value will be different for each image.


Challenge: simple_queue

Basic data structure that follows the First-In-First-Out (FIFO) principle.

@ViktoriaBerestiana  I added this issue to the Collaborative Development Milestone and to the Collaboration Practice '24 project


Support for brokered service plan update

This PR provides ability for a brokered service plan update to cascade the plan update to backing services. See https://github.com/spring-cloud/spring-cloud-app-broker/issues/285 for more background around this use-case.
In the master branch, a brokered service update only triggers a backing service update if params were changed. I understand this is an optimization which avoid extra calls to CF
https://github.com/spring-cloud/spring-cloud-app-broker/blob/c32dd2b103ff691d762af082c30194f1774872b0/spring-cloud-app-broker-deployer-cloudfoundry/src/main/java/org/springframework/cloud/appbroker/deployer/cloudfoundry/CloudFoundryAppDeployer.java#L1061-L1066
Initial branch (available at https://github.com/orange-cloudfoundry/osb-cmdb-spike/tree/updateable-plans-not-optimized) discarded the optimization. I started updating the integration tests and failed to update the wiremock stub tests within a reasonable time.
Alternatives considered for preserving the optimization

store a previousPlan (String) in BackingService, so that org.springframework.cloud.appbroker.deployer.DeployerClient.updateServiceInstance() can optionally set the plan to non null in org.springframework.cloud.appbroker.deployer.UpdateServiceInstanceRequest
fetch backing service instance using GET /v2/service_instances/:instance_id and compare with UpdateServiceInstanceRequest. This systematic extra OSB fetch call defeats the optimization.

I then worked to preserve the optimization with approach 1 above

I started implementation of approach 1 above. The plan upgrade logic would check that a requested plan update to a brokered service only translates into a backing service plan update. In other words, brokered service plan update would be rejected if resulting brokered services differs in name or service definition, i.e.

new backing service creation
deleted backing service

Pseudo code would be:

previousBackingServices = list of backing services with previous plan;
candidateBackingServicesForUpdate = list of backing services with requested plan
Reject if number of elements differ in the two list
Iterate over one list and reject if there is not exactly matching element with same instance name and service definition

Unit testing this logic in the AppDeploymentUpdateServiceInstanceWorkflow is time consumming though because:

There are 6 collaborators with pretty strict mocked interactions. Required modifying mocks set up and assertion to introduce new feature
Uses private methods (updateBackingServices and updateBackingApplications) which can't be tested individually
AppDeploymentUpdateServiceInstanceWorkflow extends AppDeploymentInstanceWorkflow which provides private methods (such as getBackingServicesForService() or getBackingApplicationsForService() which can't be used in another service

Considered alternatives:

Don't unit test the plan upgrade validation logic, and keep it in AppDeploymentUpdateServiceInstanceWorkflow with only high level testing
Unit test the plan upgrade validation logic by making the suppporting method visible to unit test (protected or package protected visibility)
Introduce a new BackingServicesUpdateValidatorService to unit test the plan update logic

Refactor AppDeploymentInstanceWorkflow to extract logic into a BrokeredServicesFinderService bean
Duplicate brokered service helpers methods from AppDeploymentInstanceWorkflow
Modify AppDeploymentInstanceWorkflow  to compute candidateBackingServicesForUpdate  and previousBackingServices

Finally selected option 3iii.

Tests are now passing :-)
Here are improvements that this PR could use with more available time

Refine user-facing log messages when plan updates get rejected
Add tests for more edge cases (e.g. an UpdateServiceInstanceRequest with a previousPlan not resolving to any known backing service)
Simplify implementation of BackingServicesUpdateValidatorService with more idomatic functional styling
Change BackingService.previousPlan into a boolean flag such as  BackingService.planWasUpdated
Refactor AppDeploymentUpdateServiceInstanceWorkflow.updateBackingServices() to make it smaller
Simplify the unit tests (DeployerClientTest, AppDeploymentUpdateServiceInstanceWorkflowTest, CloudFoundryAppDeployerTest) to use less mocks or have more flexible stubbing/mocking assertions.
Refactor

When trying to implement this feature, the mocked collaborators were often making the test fragile, causing hard-to-diagnose false negatives and making the introduction of new behaviors harder. This feels like popular related discussions such as https://testing.googleblog.com/2013/05/testing-on-toilet-dont-overuse-mocks.html
The tests above could probably use a Fake or a simple impl for TargetService, *ParametersTransformationService instead of mocks.

Thanks for the contribution, would you mind rebasing this PR @gberche-orange? Thanks!

@Albertoimpl the PR was rebased against master and adapted to new checkstyles and pmd rules. I'm looking forward to your review.

Thanks @Albertoimpl for your review.
I've made some cosmetic changes to this PR. I realize however that preserving the update optimization (i.e. Leveraging the previousValues from the update service instance request) has the following impacts, and would not trigger expected updates when only metadata changes such as

maintenance_info for triggering security patches
context (such as space/org/instance renaming, or starting in 2.16 changes in annotations)

These updates as important to the osb-cmdb use-cases and likely also for some other SCAB use-cases.
The filtering of updates currently performed in https://github.com/spring-cloud/spring-cloud-app-broker/blob/76765d10775856930874badf430f70e8c3967614/spring-cloud-app-broker-deployer-cloudfoundry/src/main/java/org/springframework/cloud/appbroker/deployer/cloudfoundry/CloudFoundryAppDeployer.java#L1107-L1114 could be removed.
If this is valueable to SCAB, I could try again to update the integration tests (which I failed as mentionned in https://github.com/spring-cloud/spring-cloud-app-broker/pull/290#issue-336503901). This will likely require to simplify assertions made against the mocked objects which were preventing any change in behavior as reported in https://github.com/spring-cloud/spring-cloud-app-broker/pull/290#issuecomment-551311140  I may need some help/guideance there.

My osb-cmdb project is not requiring this app-broker use-case, and I unfortunately I won't be able to maintain the PR to get it merged in the short term. I'll reopen in the future, if I manage to get priority in my other projects to contribute this feature.
Thanks @Albertoimpl for your past support!


2.0.0 Task

fixes #163

Coverage decreased (-0.02%) to 96.379% when pulling 6bfcd3d4620c39c0df7781a70cf75097dfb00570 on 2.0.0 into 7c516db0fa965e99d32d855500090d2e5a259469 on master.


Merge breaks running transition

https://jsfiddle.net/Inversion/7vv898aq/
In this case when you hit "+ pro" button, 2 new items added with some delay and both should be added with slide transition.
Results are:
v0.7 — all works fine
v0.8, 0.9, edge — first transition jumps to end when second starts.
There is no such issue when you push to and render same array, but in my case rendered array should be sorted, so I use merge on every array change to support transitions.
This simulates situation when 2 new items are being added with very short time interval.
But I found this issue because my observer sometimes triggered twice instead once, so for me animation was missed at all.

This appears to be resolved as of 0.10.


Automated Package Upgrade

:tada: This PR is included in version 13.0.125 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix Gulp build process

Running gulp after a fresh git clone ... was failing. Several changes got things up and running again:

3 total files renamed using CamelCase
gulp-uncss added to package.json

Hey skubakdj  -- I screwed up while trying to pull/merge so I made the change manually and cleaned up a couple other things. Pushed live now. Thanks for taking the time to fix these issues!


add canceled result for input password operations

Need to add canceled result for input password operations

[x] -- keychain common
[ ] -- windows sec module
[ ] -- linux sec module
[x] -- macos sec module

via Hubstaff
User: Sinev Valentine
Project: Array.IO keychain - https://app.hubstaff.com/projects/471254
Date Range: 02/27/19 - 04/01/19
Work session total: 181:06:18
Grand total: 181:06:18


ListError [NotebookCellList] Invalid index -1

Error: ListError [NotebookCellList] Invalid index -1
at g.getAbsoluteTopOfElement in src/vs/workbench/contrib/notebook/browser/view/notebookCellList.ts:930:10
at we.createMarkupPreview in src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts:2503:30
at Object.ge [as callback] in src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts:1098:10
at <anonymous> in src/vs/base/common/platform.ts:232:17

Go to Errors Site

This one is from insiders actually.

@rebornix Was this already fixed by 1fcf6d942f21a1de5e2664cca109c919c7966f76?

It doesn't seem to be fixed via that commit.


ResMiCo on scaffolds?

Hi there,
Congrats for the tool and paper - I'm wondering if this would be applicable to scaffolds too?
Didn't catch any information on that possibility in the repo so far.
Thanks in advance!

Thanks @GeoMicroSoares !
We haven't trained/tested ResMiCo on scaffolds. It would be quite easy to simulate some ground-truth data (e.g., just insert N's into the test dataset on our public ftp server, or simulate some new data with ResMiCo-SM). Hopefully, we can test that soon, but feel free to test it yourself, if you'd like to know really soon.


feat(amqplib): censor URL password (#186)

Fixes #186

First PR here, please be kind.
Parsing out the password is hard. The most robust way would be the use new URL(), replace password field and then .toString(). This however:

might fail, e.g. url without protocol is considered invalid and throws an error
might serialize the URL in a different way, using various escape sequences, punnycode etc.

So I instead went with RegEx. This is still not ideal, the might be multiple occurences of : and @ further down the URL. But it still seems better to me to escape more than throw an error.

@blumamir Thank you very much for your feedback. Turns out I must have been really tired yesterday as I overlooked too many things. Nevertheless, I added the username/password env variables to the container and now all the tests are passing again.
The only thing I didn't manage is a non-password test. I am unable to create a connection with a missing password, obviously. Is it possible to generate a span with unsuccessful connection or to mock the connection is some way? Or maybe write a unit test just for the censoring function? What do you think?


Empty results

The local results folder is empty. There's also no link to the corresponding Firebase test run.
$ java -jar flank.jar app.apk test.apk com.example.ui.DeviceTest

No Local 'flank.tests' found. It's used to create shards with configurable durations.

Creating bucket: gs://apk-bucket-2017-05-25-12-35

Uploading: app.apk to bucket: gs://apk-bucket-2017-05-25-12-35

Uploading: test.apk to bucket: gs://apk-bucket-2017-05-25-12-35

2 shards will be executed on: Nexus6P

Executing shard 0:  com.example.ui.DeviceTest#displaysPageObjects

Executing shard 1:  com.example.ui.DeviceTest#checkAnimationsOff

Fetching results to: ~/code/tmp/results

Combined test execution time: 0 seconds

End time: 2017-05-25-12-35

I see the folder has been created but it's empty.

I see the apks get uploaded and then deleted. The empty folder remains on cloud storage.

Thanks for reporting this. What happens if you set debug-prints:true in the
properties file?
On Thu, May 25, 2017 at 10:16 AM, bootstraponline<EMAIL_ADDRESS>wrote:

I see the apks get uploaded and then deleted. The empty folder remains on
cloud storage.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TestArmada/flank/issues/3#issuecomment-304067569, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAKGpaWMwFftQR8buYllKabG_MUM5PSUks5r9bdcgaJpZM4Nmm32
.

here's the log:

https://gist.github.com/bootstraponline/962cbf17bce6f515b919e98d03d59b27

looks like there are a lot of issues

public static final String ROOT_FLANK_BUCKET = "gs://flank/";
This bucket name is already in use. Bucket names must be globally unique. Try another name.

I think this is one of the issues. ^

The apk-bucket-* convention will have the same issue as well. In the Firebase SDK they generate guaranteed unique bucket names. For example: 2017-05-25_16:51:20.616122_pHkM/

We thought that was the issue as well but we are not able to reproduce the
issue even when we are using different accounts. Are you able to run tests
through the Firebase console directly?
On Thu, May 25, 2017 at 12:02 PM, bootstraponline<EMAIL_ADDRESS>wrote:

The apk-bucket-* convention will have the same issue as well. In the
Firebase SDK they generate guaranteed unique bucket names. For example:
2017-05-25_16:51:20.616122_pHkM/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/TestArmada/flank/issues/3#issuecomment-304095192, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAKGpfqe-IOncJIVdevPNyNf0rWerDHDks5r9dA2gaJpZM4Nmm32
.

Yep. We are running on firebase directly with no issue.

We are able to reproduce your issue. This happens when the account and
project are not in sync. The project ID has to belong to the correct
Firebase account. If you do a:
gcloud config list
What do you see?
Please use:
gcloud auth login
To set gcloud to the correct google account.
Then please use:
gcloud config set project  //Make sure its the project ID
and not just the name
And then try again. Please let me know how it goes.
Best
Renas
On Thu, May 25, 2017 at 1:19 PM, bootstraponline<EMAIL_ADDRESS>wrote:

Yep. We are running on firebase directly with no issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/TestArmada/flank/issues/3#issuecomment-304113102, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAKGpQs8S_gyu02_PBRTcFmZ0InF2ewAks5r9eJlgaJpZM4Nmm32
.

Thanks. I'll try that tomorrow.

$ gcloud config list
[compute]
region = us-east1
zone = us-east1-b
[core]
account =<EMAIL_ADDRESS>disable_usage_reporting = True
project = delta-essence-114723

Your active configuration is: [default]

ERROR: (gcloud) Invalid choice: 'firebase'.

I updated my gcloud SDK and now the tests appear to be running correctly. The naming still seems like an issue though. For example gs://apk-bucket-2017-05-26-10-05/ will conflict with other runs that occur during that same minute.

Thanks for letting me know. We'll update the date stamp so it's unique.
On May 26, 2017 7:08 AM, "bootstraponline"<EMAIL_ADDRESS>wrote:

ERROR: (gcloud) Invalid choice: 'firebase'.
I updated my gcloud SDK and now the tests appear to be running correctly.
The naming still seems like an issue though. For example
gs://apk-bucket-2017-05-26-10-05/ will conflict with other runs that
occur during that same minute.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/TestArmada/flank/issues/3#issuecomment-304291676, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAKGpe4a-5Ur3P5O8fb-Vtz5CgVJN4U-ks5r9tz3gaJpZM4Nmm32
.

I am still getting errors. Here is the full log from my most recent run:

https://gist.github.com/bootstraponline/86f0aba2ac1f684b9e4aeb87b68e154e

Creating gs://flank/...
ServiceException: 409 Bucket flank already exists.
Copying file://flank.tests [Content-Type=application/octet-stream]...
/ [0 files][    0.0 B/  121.0 B]
AccessDeniedException: 403 Caller does not have storage.objects.create access to bucket flank.

The tests run now though and the results folder contains *.xml files.

Thanks will have a look.
On May 26, 2017 7:12 AM, "bootstraponline"<EMAIL_ADDRESS>wrote:

I am still getting errors. Here is the full log from my most recent run:

https://gist.github.com/bootstraponline/
86f0aba2ac1f684b9e4aeb87b68e154e
https://gist.github.com/bootstraponline/86f0aba2ac1f684b9e4aeb87b68e154e

Creating gs://flank/...
ServiceException: 409 Bucket flank already exists.
Copying file://flank.tests [Content-Type=application/octet-stream]...
/ [0 files][    0.0 B/  121.0 B]
AccessDeniedException: 403 Caller does not have storage.objects.create access to bucket flank.
The tests run now though and the results folder contains *.xml files.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/TestArmada/flank/issues/3#issuecomment-304292526, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAKGpcIE2wOFgfH0PWtZmrzrsoljdNipks5r9t3agaJpZM4Nmm32
.

The ServiceException has been fixed in 1.2.0.


Crypto not defined

Describe The Bug:
Issue with password - causes home bridge to shut down.
To Reproduce:
Install app and login with Spanet account
Expected behavior:

Logs:
Show the Homebridge logs here, remove any sensitive information.

[04/11/2023, 16:49:47] ReferenceError: crypto is not defined
at HomebridgeAPI. (/var/lib/homebridge/node_modules/homebridge-spanet/src/platform.ts:25:27)
at HomebridgeAPI.emit (node:events:525:35)
at HomebridgeAPI.signalFinished (/var/lib/homebridge/node_modules/homebridge/src/api.ts:275:10)
at Server.start (/var/lib/homebridge/node_modules/homebridge/src/server.ts:190:14)
[04/11/2023, 16:49:47] Got SIGTERM, shutting down Homebridge...
[04/11/2023, 16:49:47] AssertionError [ERR_ASSERTION]: Cannot generate setupURI on an accessory that isn't published yet!
at Bridge.Accessory.setupURI (/var/lib/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:994:11)
at Server.setServerStatus (/var/lib/homebridge/node_modules/homebridge/src/server.ts:155:45)
at Server.teardown (/var/lib/homebridge/node_modules/homebridge/src/server.ts:199:10)
at signalHandler (/var/lib/homebridge/node_modules/homebridge/src/cli.ts:93:12)
at process.emit (node:events:513:28)
at process.emit (/var/lib/homebridge/node_modules/homebridge/node_modules/source-map-support/source-map-support.js:516:21)
Plugin Config:
{
    "bridge": {
        "name": "Homebridge DF54",
        "username": "0E:BD:1D:F7:DF:54",
        "port": 51062,
        "pin": "190-99-900",
        "advertiser": "avahi"
    },
    "accessories": [],
    "platforms": [
        {
            "name": "Config",
            "port": 8581,
            "platform": "config"
        },
        {
            "name": "Nest",
            "googleAuth": {
                "issueToken": "REMOVED"
            },
            "platform": "Nest"
        },
        {
            "email"<EMAIL_ADDRESS>            "password": "REMOVED",
            "spaName": "Hot Tub",
            "platform": "SpaNETPlugin"
        }
    ],
    "disabledPlugins": [
        "@o-lukas/homebridge-smartthings-tv"
    ]
}```

**Environment:**

* **Plugin Version**: v2.0.0
* **Homebridge Version**: V1.7.0
* **Node.js Version**: v18.16.0
* **NPM Version**: <!-- npm -v -->
* **Operating System**: <!-- Raspbian  -->

<!-- Click the "Preview" tab before you submit to ensure the formatting is correct. -->

Thanks - will fix this small bug with 2.0.1 update in next couple hours


Editing a message topic doesn't move message from old topic

If you edit a message topic from a topic narrow, the message will then appear in two places: the new topic, and the old topic. This is incorrect, it should only display in the new topic.

Yeah. I think this is a manifestation of #2688 -- we have the same bug if it's not you but someone else who edits the topic.
That issue is a bit unclearly described and has some out-of-date details, so I'll go edit it some, and close this as a duplicate.


WMSCapabilities does not support 1.1.1

WMSCapabilities can't get SRS.  so i think you dose not support 1.1.1. Why don't you support 1.1 ？

Simply because no-one has implemented support for v1.1.1. If you want to contribute that feature, feel free to provide a pull request, or find a professional service provider who can implement it for you.

Simply because no-one has implemented support for v1.1.1. If you want to contribute that feature, feel free to provide a pull request, or find a professional service provider who can implement it for you.


Issue linking with --target=wasm32-wasip2-component

I'm trying to use --target=wasm32-wasip2-component as partially described in #426 to compile an empty C file with wasi-sdk 24.0 to a Wasi component, but it seems that it is having troubles finding the libraries for linking.
This is all the c file is:
int main()
{
    return 0;
}

These are the results of running clang on it:
$ /opt/wasi-sdk/bin/clang ./component/main.c  -o app.wasm --target=wasm32-wasip2-component -v
clang version 18.1.2-wasi-sdk (https://github.com/llvm/llvm-project 26a1d6601d727a96f4301d0d8647b5a42760ae0c)
Target: wasm32-unknown-wasip2-component
Thread model: posix
InstalledDir: /opt/wasi-sdk/bin
 "/opt/wasi-sdk/bin/clang-18" -cc1 -triple wasm32-unknown-wasip2-component -emit-obj -mrelax-all -dumpdir app.wasm- -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name main.c -mrelocation-model static -mframe-pointer=none -ffp-contract=on -fno-rounding-math -mconstructor-aliases -target-cpu generic -fvisibility=hidden -debugger-tuning=gdb -fdebug-compilation-dir=/home/kennan/programming/workbench-c -v -fcoverage-compilation-dir=/home/kennan/programming/workbench-c -resource-dir /opt/wasi-sdk/lib/clang/18 -isysroot /opt/wasi-sdk/bin/../share/wasi-sysroot -internal-isystem /opt/wasi-sdk/lib/clang/18/include -internal-isystem /opt/wasi-sdk/bin/../share/wasi-sysroot/include/wasm32-wasip2-component -internal-isystem /opt/wasi-sdk/bin/../share/wasi-sysroot/include -ferror-limit 19 -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -fcolor-diagnostics -o /tmp/main-c7559e.o -x c ./component/main.c
clang -cc1 version 18.1.2-wasi-sdk based upon LLVM 18.1.2-wasi-sdk default target wasm32-wasi
ignoring nonexistent directory "/opt/wasi-sdk/bin/../share/wasi-sysroot/include/wasm32-wasip2-component"
#include "..." search starts here:
#include <...> search starts here:
 /opt/wasi-sdk/lib/clang/18/include
 /opt/wasi-sdk/bin/../share/wasi-sysroot/include
End of search list.
 "/opt/wasi-sdk/bin/wasm-component-ld" -m wasm32 --wasm-ld-path /opt/wasi-sdk/bin/wasm-ld -L/opt/wasi-sdk/bin/../share/wasi-sysroot/lib/wasm32-wasip2-component crt1.o /tmp/main-c7559e.o -lc /opt/wasi-sdk/lib/clang/18/lib/wasip2/libclang_rt.builtins-wasm32.a -o app.wasm
wasm-ld: error: cannot open crt1.o: No such file or directory
wasm-ld: error: unable to find library -lc
error: failed to invoke LLD: exit status: 1
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Final goal is to compile a C file to component mode and import the Wasi clock and stdio dependencies, any help or direction would be greatly appreciated.

Thank you! wasm32-wasip2 works perfectly


Page loaded over HTTPS, but requested an insecure resource (HTTP)

Hi, I notice the weather API is using HTTP, maybe consider changing it to HTTPS so that the above error can be resolved? Thanks.

Hi! I implemented your request (commits 3ea6009 and 12eb460). Thank you for contributing!


renderer: round boxes

Fixes https://github.com/hyprwm/hyprlock/issues/534
wlr_matrix_project_box implicitly casted the box
    int x      = box->x;
    int y      = box->y;
    int width  = box->width;
    int height = box->height;

This brings it back explicitly fixing blurry textures.

or should I make sure we round in the widgets instead?


In OS X 10.10.2, I have to restart the Dock to see changes

For example, I did
dockutil --add /Applications/TextEdit.app

and the dock was automatically restarted, but TextEdit did not appear. I did killall Dock in the Terminal, and when the Dock restarted, TextEdit was there.
If I had to guess, I'd say that this probably has something to do with preferences caching, but I'm not sure.
dockutil v. 2.0.2

Thanks for reporting the issue.   This was probably fixed in one of the releases since then.  It is working for me now.


Control usage

Hi guys,
Thanks for the start of the API.
Can you elaborate more on a scenario for the control usage (PUT /api/loads/< id >/ctrl). In what case would we want to use this API instead of the target state ? It implies to do an action followed by a timer and another action.
I plan to use fully wiser in my new home in the following week and do all the client app myself, but 1 hardware limitation is pending on this decision: Dim for DALI..
I also wait on more API documentation
Thanks,
JJ

PUT /api/loads/< id >/ctrl is designed for user interfaces like this:
The load behaves the same way as you would control it with a button on the wall.
+-----+
| I/0 |
+-----+

+-----+  +-----+      +-----+  +-----+       +-----+  +-----+
|  +  |  |  -  |      |  ^  |  |  v  |       |  I  |  |  0  |
+-----+  +-----+      +-----+  +-----+       +-----+  +-----+

PUT /api/loads/< id >/target_state is designed for user interfaces like this:
For sliders or color pickers
           +-+
+----------| |-------------------+
|          | |                   |
+----------| |-------------------+
           +-+

DALI and more API documentation is currently under construction.


Move logic for platform selection to .h file.  Refs #23

Also fix compile for wave_player on Linux

This does look cleaner to me, I haven't tested for functionality on my system though.

I tested these changes on Windows, msys2, and they work fine. I did have to manually compile it though. -lasound fails and -lwinmm is required. Might be nice to update the makefile to be OS aware. You can see an example of that here:
https://github.com/AEFeinstein/Super-2024-Swadge-FW/blob/main/makefile

Added OS detection, I plan to merge in a few hours.


Remove DNFDataset as it doesn't exist in utils.

Fix for issue number 7
https://github.com/YichiCS/DNF/issues/7

Thank you for this.


2 mat-autocomplete boxes overlapping. second box unclickable

Reproduction
Steps to reproduce:

Place 2 mat-autocomplete elements underneath each other
Click the bottom mat-autocomplete and try to select an item
Item is not clickable and selects the autocomplete above.

Expected Behavior
Both autocomplete boxes should work independently.
Actual Behavior
The autocomplete box from the first element blocks the click function on the second box.

This visualisation shows the first box overlapping the second. Normaly you would not see this box but the "invisable" box will still interfere with the second box. So only Accum and Adalady are clickable.
Environment

Angular: 7.2.15
Ionic 4.9.1
CDK/Material: 7.3.7
Browser(s): Chrome/firefox (mobile and web)
Operating System: Windows 10

Experiencing this issue as well.  It appears to be a manifestation of the broken Chrome decision to ignore autocomplete='off'.   Note, this problem occurs even when generating random values, e.g. autocomplete='123564sdfdsk34r2isdfposiduf posdi' in ngOnInit().   I can also see that matAutocomplete is respecting the native attribute.   So this really looks like a Chrome bug.
See Issue 914451: Autofill does not respect autocomplete="off".

It seems to be working fine in this example https://stackblitz.com/edit/angular-r2e39d?file=src/app/autocomplete-simple-example.html what you're seeing is likely an issue with that app, not the autocomplete


how to show the specified position image?

thanks for your great work.
Now i want to show the specified position image.how can i do it?
source: imgs:[a.jpg,b.jgp,c.jpg]
now i want to show the b.jpg on the initialized page.

At the moment it is not possible, but let me see if it can be added

@jbasttdi added a property for starting index DKStartIndex, this is on the 0.1.3 tag/release

thanks.


Separate gobuster program/command line from core functionality

There is an idea i'm playing with where it would be useful to be able to use the core of gobuster from another program, though because it is currently all a single 'program', there is no way to import it.
This should separate the command-line parsing/'program'  aspect of it from the core engine/functionality, which I've called libgobuster out of laziness (naming is hard..)
Should still be able to compile with go get.. as before, and I don't believe it should make any functional difference to how anything runs; still compiles to a single binary, etc.

Just saw https://github.com/OJ/gobuster/pull/42, which might make this one obsolete


UI: Register Passkey

As an enduser I want to be able to register my user with passkey authentication, so I don't have to remember my password
Acceptance Criteria

[ ] The user has a description link to read more about passkey what it is and why it is useful
[ ] I am able to choose the authentication method when registering my user
[ ] I am able to either send password or passkey registration
[ ] When choosing passkey registration the user doesn't need to give a name for the passkey
[ ] I am also able to register both password and passkey so that I have the password as a backup authentication method
[ ] After login the user should be asked if he want to register passkey directely
[ ] The user is able to directly add the passkey after the login, the user is asked do you want to add passkey for easier login next time

@hifabienne please migrate issue to the typescript repo.


Updated Returning validation error message example

Updated Returning validation error message example

cc: @kengaderdus
GitHub Issue: https://github.com/MicrosoftDocs/azure-docs/issues/92357

@JamesTran-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@JamesTran-MSFT
If 409 really returned as an HTTP status code from the API? It is returned in the body as part of the JSON response. Additionally, Azure AD B2C wants it to be 409.

@kengaderdus
I've tested it and it works with anything 4xx, so it's wrong to say Must be 409. I've reached out to a PM just to confirm. I'll give you a signal.

@JamesTran-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@kengaderdus
Thank you!

#sign-off


 Goes to T2 vehicle as well. Seen on stream.

Unable to duplicate.

Suspect the streamer didn't have their mods properly enabled. Code looks good; testing looked good too.

Note that following the implementation of Uber Naval, Uber will no longer perform optimally on this map. This is an unavoidable part of its design and Uber Naval should be used instead,

Happy with this for now.


Add a name, contextual title and icon for the Java Project Explorer

Would it also be possible to add a name, contextualTitle, and icon? these would greatly benefit people who move the view into the Activity Bar like myself.
https://code.visualstudio.com/api/references/contribution-points#contributes.views
Originally posted by @tristan957 in https://github.com/microsoft/vscode-java-dependency/issues/372#issuecomment-723159772

Perfect thanks @jdneo

@jdneo in my effort to open similar issues across various extensions regarding this issue, I have become quite comfortable with this aspect of the VSCode API and would be more than happy to add a PR for this assuming there is some icon you would like me to use :). Not sure if one already exists within the context of the project.

I'll ask the team if we need a new contextual icon and let you know

The new icon looks really good. Thanks. I think that came in the new update 🤔 .

This task is not started yet. Did you mistake the icon of File Explorer to the contextual icon?

Hmm I saw the Maven logo in the Activity Bar and mistakenly assume that was the icon.


Add uniswap clm WETH-wstETH on base

@ying13 The position width of 50 is far too wide for this correlated pair, it should be around 15. For reference the width should follow this kind of rule:

Fee
Width

100
15

500
175

3000
60

10000
50

Could you please redeploy with an updated width?

@kexleyBeefy thank you. I just redeployed them and tested in UI.


suggest

show stars for every project
show lastupdate for every project

Is this possible via some embeddedable badge like thing?
Wouldn't want to manually update that for obvious reasons.

My suggestion is to have a script that parses current README.md file and generates A NEW ONE with the star and last update information added to each line.

Is there a service to generate a .svg with the number of stars/forks and the last update info from a url like https://example.com/github/fffaraz/awesome-cpp.svg

@fffaraz
https://shields.io/category/social

I suggest we should also have a C badge for pure C libraries so that C programmers can benefit from this list too.

We should add tags like [C89], [C18], [C++11], [C++14], ... to the description before the license tag.


Support Service Bus 2021-06-01-preview

Service Package Request
The specification for service bus at version 2021-06-01-preview supports parameter 'trustedServiceAccessEnabled' which would enable Terraform to support a parameter, e.g. allow_trusted_microsoft_services_bypass_firewall
https://github.com/hashicorp/terraform-provider-azurerm/issues/9740
Request to generate a servicebus package 2021-06-01-preview to support this feature

Hi @dylanmorley thanks for this issue!
Releasing a new package will require the service to submit a new SDK release request, I have added the label on this issue so that the corresponding service team could take this a look.
I also sent some internal emails to the contact of the corresponding service team about this.

@lirenhe This is also required for https://github.com/hashicorp/terraform-provider-azurerm/issues/13514. Would be great to have!

I think now available, from this PR https://github.com/Azure/azure-sdk-for-go/pull/15672 and available on v58

Close it as the package 2021-06-01-preview was released.


update build workflow

Differential Revision: D45282733

Codecov Report
Patch and project coverage have no change.

Comparison is base (96970a9) 64.56% compared to head (217824f) 64.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   64.56%   64.56%
=======================================
  Files         146      146
  Lines        9835     9835
=======================================
  Hits         6350     6350
  Misses       3485     3485

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Data Science with Python : Item Based Filtering System #1036

Description 📜
Made an Audio presentation.
Fixes #1036

Type of change 📝

[x] Audio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)

Domain of Contribution 📊

[x] Datascience with Python

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@prathimacode-hub , Can you please evaluate my PR mam.


[SPARK-33212][BUILD] Upgrade to Hadoop 3.2.2 and move to shaded clients for Hadoop 3.x profile

What changes were proposed in this pull request?

This:

switches Spark to use shaded Hadoop clients, namely hadoop-client-api and hadoop-client-runtime, for Hadoop 3.x.
upgrade built-in version for Hadoop 3.x to Hadoop 3.2.2

Note that for Hadoop 2.7, we'll still use the same modules such as hadoop-client.
In order to still keep default Hadoop profile to be hadoop-3.2, this defines the following Maven properties:
hadoop-client-api.artifact
hadoop-client-runtime.artifact
hadoop-client-minicluster.artifact

which default to:
hadoop-client-api
hadoop-client-runtime
hadoop-client-minicluster

but all switch to hadoop-client when the Hadoop profile is hadoop-2.7. A side affect from this is we'll import the same dependency multiple times. For this I have to disable Maven enforcer banDuplicatePomDependencyVersions.
Besides above, there are the following changes:

explicitly add a few dependencies which are imported via transitive dependencies from Hadoop jars, but are removed from the shaded client jars.
removed the use of ProxyUriUtils.getPath from ApplicationMaster which is a server-side/private API.
modified IsolatedClientLoader to exclude hadoop-auth jars when Hadoop version is 3.x. This change should only matter when we're not sharing Hadoop classes with Spark (which is mostly used in tests).

Why are the changes needed?

Hadoop 3.2.2 is released with new features and bug fixes, so it's good for the Spark community to adopt it. However, latest Hadoop versions starting from Hadoop 3.2.1 have upgraded to use Guava 27+. In order to resolve Guava conflicts, this takes the approach by switching to shaded client jars provided by Hadoop. This also has the benefits of avoid pulling other 3rd party dependencies from Hadoop side so as to avoid more potential future conflicts.
Does this PR introduce any user-facing change?

When people use Spark with hadoop-provided option, they should make sure class path contains hadoop-client-api and hadoop-client-runtime jars. In addition, they may need to make sure these jars appear before other Hadoop jars in the order. Otherwise, classes may be loaded from the other non-shaded Hadoop jars and cause potential conflicts.
How was this patch tested?

Relying on existing tests.

Test build #132548 has started for PR 30701 at commit a78ae6e.

Test build #132548 has finished for PR 30701 at commit a78ae6e.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132548/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37152/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37152/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37152/

Great! Is hadoop-aws tested manually, @sunchao ?

yes manually tested it and it looks good

Test build #132581 has started for PR 30701 at commit 66da95e.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37186/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37186/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37186/

Test build #132598 has started for PR 30701 at commit ace75c8.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37203/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37203/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37203/

Test build #132581 has finished for PR 30701 at commit 66da95e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132581/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132598/

Test build #133805 has started for PR 30701 at commit 17513d3.

Test build #133805 has started for PR 30701 at commit 17513d3.

Hadoop 3.2.2-rc5 became 3.2.2 on Jan 9, does this PR have a chance to merge into 3.1?

Hadoop 3.2.2-rc5 became 3.2.2 on Jan 9, does this PR have a chance to merge into 3.1?

Sorry, but it's too late for Apache Spark 3.1.1, @pan3793 .

Hadoop 3.2.2-rc5 became 3.2.2 on Jan 9, does this PR have a chance to merge into 3.1?

Sorry, but it's too late for Apache Spark 3.1.1, @pan3793 .

Hadoop 3.2.2-rc5 became 3.2.2 on Jan 9, does this PR have a chance to merge into 3.1?

BTW, @sunchao . Since Apache Hadoop 3.2.2 is out, shall we convert this from Draft to a normal PR?

BTW, @sunchao . Since Apache Hadoop 3.2.2 is out, shall we convert this from Draft to a normal PR?

@dongjoon-hyun yes will do that soon.

@dongjoon-hyun yes will do that soon.

@dongjoon-hyun updated the title and description, updated the PR and let's see how CI goes.

@dongjoon-hyun updated the title and description, updated the PR and let's see how CI goes.

Thank you for updating, @sunchao !

Thank you for updating, @sunchao !

Test build #134125 has started for PR 30701 at commit cccb021.

Test build #134125 has started for PR 30701 at commit cccb021.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38708/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38708/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38708/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38708/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38708/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38708/

Test build #134125 has finished for PR 30701 at commit cccb021.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134125 has finished for PR 30701 at commit cccb021.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134125/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134125/

Thanks @dongjoon-hyun for merging! @xkrogen I'll address your comments in a follow-up PR.

Thanks @dongjoon-hyun for merging! @xkrogen I'll address your comments in a follow-up PR.

Thanks @sunchao !

Thanks @sunchao !


Delete crashlytics.rb

Seems to be dead (integrated into another app that is behind a registration wall).

Merged as a89dd7884cc7dc981ee9184058a839c631125725.


Crash with BETWEEN inside CASE expression

Describe the bug
with
  p as (
    SELECT distinct
      s.id,
      case
        when s.end_date between (
          CASE
            WHEN CURRENT_DATE >= 12 THEN 13
          end
        ) and (
          CASE
            WHEN CURRENT_DATE >= 12 THEN 13
          end
        )  then year(current_date) + 1

      end as s_u,
    FROM
      table_name s
      )

Actual behavior
Crash:
token: {
    type: 'BETWEEN',
    raw: 'between',
    text: 'BETWEEN',
    start: 81,
    precedingWhitespace: ' '
  }
}

Usage
npx sql-formatter -l hive provoke.hql

Crash does not occur on 10.6.0
Exists in 11.0.2 and 12.0.0-beta.1

Looks like there's a difference on what sort of nesting of operators is allowed.
The above query produces a syntax error in MySQL, but works in e.g. Postgres and SQLite.
But yeah, definitely a bug. Will fix.

Unfortunately this is more complex problem than I had anticipated. It's very tricky to solve with our current parser architecture. I'm working on a longer-term solution, but that will take a whole lot of time to arrive.
For now the workaround is to wrap the between-expression inside parenthesis, like:
SELECT
  CASE
    WHEN (x BETWEEN 1 AND 10) THEN 1
  END
FROM
  tbl

@nene is this sql a reproduction of the same bug or something new?
SELECT something
FROM the_table
WHERE
    field BETWEEN $1 AND $2
    AND field_2 = $3

Produces the error:
An Unexpected Error Occurred
Parse error: Ambiguous grammar

Also fixed by changing it to be:
SELECT something
FROM the_table
WHERE
    (field BETWEEN $1 AND $2)
    AND field_2 = $3

@kbrownlees  This is duplicate of another bug: #534
Though, these two are somewhat related.

Hi, @nene
I noticed this line:  https://github.com/sql-formatter-org/sql-formatter/blob/58ac0fb4b2c802d4abdbc16e8888e417e894aa39/src/parser/createParser.ts#L42
May I known why ambiguous error should be thrown here?
When meet ambiguous grammar, can we just pick one of the parse results and carry on formatting process?

When an ambiguity is encountered, it's a sign that the grammar itself is faulty, which means the bug is really inside the formatter and not in the specific input.
If we were to ignore the problem with ambiguity, the bug will likely show up later when formatting the result, but then it will be much harder to diagnose what went wrong.
It's an unfortunate state of this library that this ambiguity bug hasn't been fixed for many years now. But wiping it under the rug is a fix that's an invitation for many other bugs.

Thank you very much sir!

The fix for this is now released in 13.0.3


Add FIPS mode secret and vendor in libpod/pkg/secret

Update cri-o to use the secrets package from libpod/pkg/secret,
which also brings in support for FIPS mode secret.
If the host is in FIPS mode (i.e /etc/system-fips exists) /run/secrets/system-fips
is created in the container so that the container can also run in FIPS mode.
Signed-off-by: umohnani8<EMAIL_ADDRESS>

LGTM
/test all

I don't understand why the mounts file is not being overridden in the tests by the --default-mounts-file flag. It definitely works manually, any ideas?
"$CRIO_BINARY" ${HOOKS_OPTS} --conmon "$CONMON_BINARY" --listen "$CRIO_SOCKET" --cgroup-manager "$CGROUP_MANAGER" --default-mounts-file "$TESTDIR/containers/mounts.conf"...

Look to see if this is the only time CRI_BINARY is called.

/test all

/test kata-containers

@mrunalp Kata containers seems to not be working.  Who do we ping to see what is going on?

/retest

/test all

Not sure why kata CI is failing. @mrunalp who should I talk to?

@sboeuf Can you take a look at why kata containers tests are failing?

@mrunalp nothing related to the PR. I have restarted the job since there is no reason for failure here.

/test kata-containers

/test kata-containers

Tests pass!

;)

Ok lets merge.


react-input-mask: children must be a function

I see this issue was close, unfortunately I am still facing it. What was the resolution behind closing this, if i may ask ?

@Darth-koder007
                            <InputMask
                                mask = '(999)-999-9999'
                                maxLength = '10'>
                                {(inputProps) => (
                                    <YourInputComponent
                                        { ...inputProps }

                                    />
                                )}
                            </InputMask>


Special characters

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2022.11.11 (update instructions) or later (specify commit)
[X] I've searched the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
VERBOSE OUTPUT NOT NEEDED; NOT A TECHNICAL ISSUE
Hello. Since an update to yt-dlp, I get these characters in video titles (This⧹is⧸a：video＊with？the＂symbols｜ [OORigQYUuoI].mp4). How can I disable them? (Ideal solution for me: replace with underscores, example: This_is_a_video_with_the_symbols_ [OORigQYUuoI]). I want to keep spaces. I only want to get rid of these characters. For me, they look wrong. [This is the video with the characters (uploaded by me as a test)]: (https://www.youtube.com/watch?v=OORigQYUuoI).
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

See pinned issues!

Thank you for showing me! I looked at least 3 times at the pinned issues, but I couldn't see it.

Do you have any suggestion for what I could change so you could have found it easier?


Payback Period of Solar Panels

As a [description of user]?
homeowner in BC,
I want to [functionality]
understand the payback period of installing solar panels,
So that [benefit]
determine if I wish to purchase and install them.
Additional context
Add any other context, attachments or screenshots
Acceptance Criteria
Agreed-upon confirmation of the requirements when done can be deemed as complete

duplicated by #92, closing


Make new relse for vol2bird

vol2bird is migrated to https://github.com/QCDIS/NaaVRE-flavors/blob/main/flavors/vol2bird/


support state storage

Storage allows to:

read / save settings
store process state
store downloads

Settings:

settings directory
state directory
downloads directory

Storage types:

in memory (good mostly for debug)
disk

done w/a settings and store types for a moment


K8SPXC-343 unify and beautify operator deployment

Test name
Status

big-data
passed

storage
passed

recreate
passed

haproxy
passed

scaling
passed

self-healing
passed

init-deploy
passed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

upgrade
passed

limits
passed

monitoring
passed

upgrade-consistency
passed

self-healing-advanced
passed

security-context
passed

demand-backup
failed

monitoring-2-0
passed

operator-self-healing
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

scheduled-backup
failed

What about cw-operator.yaml ?

fixed

PXC operator docker - perconalab/percona-xtradb-cluster-operator:PR-568-f8f9e032

Test name
Status

recreate
passed

storage
passed

scaling
passed

big-data
passed

haproxy
passed

scaling-proxysql
passed

init-deploy
passed

restore-to-encrypted-cluster
passed

upgrade
passed

limits
passed

self-healing
passed

upgrade-consistency
passed

monitoring
passed

demand-backup
passed

monitoring-2-0
passed

self-healing-advanced
passed

security-context
passed

affinity
passed

operator-self-healing
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

scheduled-backup
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

demand-backup-encrypted-with-tls
passed

tls-issue-cert-manager-ref
passed

Test name
Status

big-data
failed

haproxy
failed

recreate
failed

storage
failed

scaling
failed

init-deploy
failed

restore-to-encrypted-cluster
failed

self-healing
failed

scaling-proxysql
failed

limits
failed

self-healing-advanced
failed

demand-backup
failed

upgrade
failed

monitoring
failed

operator-self-healing
failed

scheduled-backup
failed

upgrade-consistency
failed

monitoring-2-0
failed

demand-backup-encrypted-with-tls
failed

security-context
failed

affinity
failed

one-pod
failed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

users
failed

tls-issue-self
failed

tls-issue-cert-manager
failed

tls-issue-cert-manager-ref
failed


Change http to https in Repository Description URL

A minor change: On the GitHub repository page for iOSDevDirectory, the website URL is http://iosdevdirectory.com, when it should be https://

Thanks, fixed 👍


Support custom helm release name

Describe the proposal
The default helm release name is "dapr" and all CLI commands depend on that. This proposal is to allow users to be able to specify a custom release name.
Release Note

RELEASE NOTE: ADD Option to manage custom Dapr helm release name

The release-namespace can be supplied with dapr init -k -n "xyz". During upgrade the namespace is read from existing cluster and thus not needed to be passes during upgrade as well.

@shubham1172 @pravinpushkar Is this resolved?


Swap filter() and map()

Before :

incidents.stream().filter(e-> e.getIncidentID().equalsIgnoreCase("123").map(Results::getIncdntId)

After :

incidents.stream().map(Results::getIncdntId).filter(e-> e.getIncidentID().equalsIgnoreCase("123"))

Hi @yeikel! I think there may be a typo in the After.
The map would return the values from Object#get(), so the filter can only act on the mapped objects.
So, in this case the filter should be e -> e.equalsIgnoreCase("123");
I'll add it to recipes wanted, and mark it for uses-dataflow.
Thanks!

Hi @yeikel! I think there may be a typo in the After.
The map would return the values from Object#get(), so the filter can only act on the mapped objects.
So, in this case the filter should be e -> e.equalsIgnoreCase("123");
I'll add it to recipes wanted, and mark it for uses-dataflow.
Thanks!

That's correct. I updated it
Thanks!


API link broken

Are the docs for warehouse live somewhere? Is it still in use?
Thank you

Hi,
You have link at the top of the landing github page:
JSON database https://hexo.io/warehouse/

I put in this PR to fix the links. There's a few links in it for docs and examples https://github.com/hexojs/warehouse/pull/12


why shim

I had an issue when deployed on AWS related to shim dependency, is there any reason we use it? can it be optional?

What was the issue? Maybe using aws-lambda component would be a better fit for you use case?
The shim doesn't do much, but it makes Lambda a bit more approachable since you only need to export a single mono function without having to worry about handlers, a lot like Micro.

@eahefnawy  I was tried to deploy a NestJS application and got an error when handling an API event, the error relates to shim.
The handler works well when I use native serverless with CloudFormation. So I think using shim should be configurable as well. That would be great. We don't need to worry about Micro when using NestJS

@hoang-innomizetech what was the error? It seems to be a bug.


maintenance / EOL policy?

Is there (or plan to be) a {release life cycle, maintenance branches, end of life (EOL), support version} policy?
On the release page (https://crystal-lang.org/releases/) we can watch which version was published and when (similar to Ruby https://www.ruby-lang.org/en/downloads/releases/) or even new version announcement on the blog.
But I didn't find any EOL announcement for some version branches (similar to ruby https://www.ruby-lang.org/en/downloads/branches/), saying which will receive bug or security patches and which is not supported anymore.
But maybe Crystal has some sort of cutting-edge rolling release policy, like Arch Linux, so only the very latest version is supported? But I didn't found a documentation page explaining that either.
So what's the maintenance / EOL policy of Crystal?

I brought this up in the past internally, and if I remember correctly we don't really have an established policy on it. Mainly since there hasn't been any major bug that would require issuing patch releases for past releases.
Bug fixes have always just been released for the latest minor and never really back ported, so IMO it's closer to Alpine's approach where only the latest version of a package is supported. But for a major bug/security issue its definitely not off the table backporting it to the last few releases.

Yeah there are some scattered bits about this in different discussion threads. But it makes sense to write it all down as public information.
In contrast to Ruby, our minor releases are not breaking backwards compatibility. So it should always be possible to upgrade to the latest release and we'll usually only release bug fixes for the most recent minor.
The equivalent to Ruby's release branches would be based on the major version only in Crystal. So the 1.x branch is currently in normal maintenance. All 0.x releases are EOL. When we reach Crystal 2.x, we might continue with that or immediately drop 1.x to security maintenance only (we'll figure that out once we get there).

Yeah there are some scattered bits about this in different discussion threads. But it makes sense to write it all down as public information.

Please do. With a written policy I would be able to PR to https://endoflife.date to add Crystal. It would help in integrate Cyrstal in many update tracking systems.

In contrast to Ruby, our minor releases are not breaking backwards compatibility.

I recently updated a project that was using Crystal 1.7.3, and when I read the 1.8.0 changelog, I saw a lot of (breaking-change) label.

The equivalent to Ruby's release branches would be based on the major version only in Crystal. So the 1.x branch is currently in normal maintenance. All 0.x releases are EOL. When we reach Crystal 2.x, we might continue with that or immediately drop 1.x to security maintenance only (we'll figure that out once we get there).

Totally makes sense.

Nice, I didn't know of https://endoflife.date 👍

when I read the 1.8.0 changelog, I saw a lot of (breaking-change) label.

Of course any change - even bugfixes - has a potential to break existing code. Maybe somebody depended exactly on that buggy behaviour 🤷 We're quite explicit about highlighting changes that have even a (slighly) heightened risk of breaking something.
It's not possible to exclude any and all breaking changes but we're commited to avoiding any explicit breakages and expect all well-defined Crystal code written for 1.0 to continue building for any future 1.x release.
Many of these breaking changes in 1.8.0 are just deprecations. The code will continue to work just fine but removal is exepected in the future, so we're already marking it as breaking now that the decision has been made. (Nowadays we're mentioning deprecations in their own section without the "breaking" label)
Other changes marked as "breaking" only apply to stdlib or compiler features which were not intended and documented for public use and thus we never promised stability. This is just an extra service to let people who still use these things on their own risk know about potential issues (and even those are typically just affect some edge cases).

@ysbaddaden Pointed me to https://hexdocs.pm/elixir/compatibility-and-deprecations.html which seems like a good template for a release policy page.
I'm not too fond about merging a list of specific deprecations because that's a different concern. (We should have that for Crystal as well, but as a separate document.

I posted a proposal at https://github.com/crystal-lang/crystal-book/pull/756

Resolved by https://github.com/crystal-lang/crystal-book/pull/756