UNAUTHENTICATED trying to autoscale bigtable nodes with app engine cron job

I'm using this metric-scaler example. When I get to the line that says response = metricServiceClient.listTimeSeries(projectName, filter, interval, TimeSeriesView.FULL); I get an unauth error and this stack trace:
com.google.api.gax.grpc.ApiException: io.grpc.StatusRuntimeException: UNAUTHENTICATED
	at com.google.api.gax.grpc.ExceptionTransformingCallable$ExceptionTransformingFuture.onFailure(ExceptionTransformingCallable.java:108)
	at com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:52)
	at com.google.common.util.concurrent.Futures$6.run(Futures.java:1764)
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:456)
	at com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:817)
	at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:753)
	at com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:634)
	at io.grpc.stub.ClientCalls$GrpcFuture.setException(ClientCalls.java:451)
	at io.grpc.stub.ClientCalls$UnaryStreamToFuture.onClose(ClientCalls.java:427)
	at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:419)
	at io.grpc.internal.ClientCallImpl.access$100(ClientCallImpl.java:60)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.close(ClientCallImpl.java:493)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.access$500(ClientCallImpl.java:422)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:525)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:102)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:295)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: io.grpc.StatusRuntimeException: UNAUTHENTICATED
	at io.grpc.Status.asRuntimeException(Status.java:526)
	... 15 more
Caused by: java.io.IOException: Could not get the access token.
	at com.google.auth.oauth2.AppEngineCredentials.refreshAccessToken(AppEngineCredentials.java:136)
	at com.google.auth.oauth2.OAuth2Credentials.refresh(OAuth2Credentials.java:149)
	at com.google.auth.oauth2.OAuth2Credentials.getRequestMetadata(OAuth2Credentials.java:135)
	at io.grpc.auth.GoogleAuthLibraryCallCredentials$1.run(GoogleAuthLibraryCallCredentials.java:95)
	... 7 more
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.google.auth.oauth2.AppEngineCredentials.refreshAccessToken(AppEngineCredentials.java:131)
	... 10 more
Caused by: com.google.apphosting.api.ApiProxy$CallNotFoundException: Can't make API call memcache.Get in a thread that is neither the original request thread nor a thread created by ThreadManager
	at com.google.apphosting.api.ApiProxy$CallNotFoundException.foreignThread(ApiProxy.java:844)
	at com.google.apphosting.api.ApiProxy$1.get(ApiProxy.java:183)
	at com.google.apphosting.api.ApiProxy$1.get(ApiProxy.java:180)
	at com.google.appengine.api.utils.FutureWrapper.get(FutureWrapper.java:93)
	at com.google.appengine.api.memcache.MemcacheServiceImpl.quietGet(MemcacheServiceImpl.java:28)
	at com.google.appengine.api.memcache.MemcacheServiceImpl.get(MemcacheServiceImpl.java:51)
	at com.google.appengine.api.appidentity.AppIdentityServiceImpl.getAccessToken(AppIdentityServiceImpl.java:300)
	... 15 more

Is there something special I have to do because I'm running this in app engine standard?

Could google-cloud-java/issues/2504 be relevant?

Looks like it! Doing this made it work:
    List<String> scopes = Arrays.asList("https://www.googleapis.com/auth/monitoring");
    AppIdentityService appIdentityService = AppIdentityServiceFactory
        .getAppIdentityService();
    // This has to be called:
    String access_token = appIdentityService
        .getAccessToken(scopes)
        .getAccessToken();
    CredentialsProvider credentialsProvider = FixedCredentialsProvider.create(
        GoogleCredentials.getApplicationDefault().createScoped(scopes));
    ChannelProvider channelProvider = MetricServiceSettings
        .defaultChannelProviderBuilder().setCredentialsProvider(credentialsProvider).build();
    MetricServiceSettings metricServiceSettings = MetricServiceSettings
        .defaultBuilder()
        .setChannelProvider(channelProvider)
        .build();
    metricServiceClient = MetricServiceClient
        .create(metricServiceSettings);

Does this code return the very latest cpu load metric, or does it return an average over the last five minutes?
  /**
   * Retrieves the latest value for the metric defined by {@link #CPU_METRIC}.
   * @return
   * @throws IOException
   */
  Point getLatestValue() throws IOException {
    // [START get_bigtable_cpu]
    Timestamp now = timeXMinutesAgo(0);
    Timestamp fiveMinutesAgo = timeXMinutesAgo(5);
    TimeInterval interval =
        TimeInterval.newBuilder().setStartTime(fiveMinutesAgo).setEndTime(now).build();
    String filter = "metric.type=\"" + CPU_METRIC + "\"";
    ListTimeSeriesPagedResponse response =
        metricServiceClient.listTimeSeries(projectName, filter, interval, TimeSeriesView.FULL);
    return response.getPage().getValues().iterator().next().getPointsList().get(0);
    // [END get_bigtable_cpu]
  }

I see it's doumented as retreiving the latest value. How should I modify this to get an average value?

The workaround no longer seems to work as we're seeing unauth-errors again. This should work without doing anything explicit with regards to authentication, right?

UNAUTHENTICATED issues can happen even if everything is set up correctly for long running systems.  I have a couple of suggestions:

We should recreate the metricServiceClient every invocation.  Hopefully that also gets a new auth token.
We should probably upgrade the example's version of google-cloud-monitoring, but that's not likely going to help with the UNAUTHENTICATED issue
A bug should be raised on the google-cloud-java GitHub project if the problem persists.

Thank you for taking the time to respond! :) About your first suggestion: Could I verify that that's a problem just by restarting the instance? New app -> new invocation -> new metricServiceClient -> auth should be ok?
What I thought I'd do when I get to work tomorrow is to:

Try using the latest versions of all dependencies. Right now I'm using the versions used in the example.
Look into using service accounts.

Yup, that's what I meant.  The metricServiceClient should also be closed.  Ideally, creating a new metricServiceClient also means creating a new auth token under the covers.
Service accounts may help, depending on how MetricServiceClients are set up.
FWIW, we've had issues with the Cloud Bigtable client relating to UNAUTHENTICATED, and came up with a custom solution to the problem.  Ideally, our team gets that change into google-cloud-java as well.

FYI, feel free to reach out offline.  My email address is on my profile.

A new MetricServiceClient is created each time the cron job is called, but maybe something is lingering? I'll try to confirm that I don't get the unauth error (the first time) after a new instance has been created..
A few minutes later: No unauth error on the next cron job execution. I'm guessing that's because a new instance of the app was created (I deleted the previous one).
After another 15 minutes: No unauth errors this time either. I'm guessing it'll take some time before the unauth error reappears after an access token has been created.
I'll send you an email tomorrow, after trying newer versions and perhaps a service account. Thanks!

This servlet has worked for about 24 hours now without any unauthenticated errors:
@WebServlet(name = "ScaleBigtable", value = "/bigtable")
public class ScaleBigtable extends HttpServlet {

  private static final Logger log = LoggerFactory.getLogger(ScaleBigtable.class);

  private static final String projectId = ***;
  private static final String instanceId = ***;
  private static final List<String> scopes =
      Collections.singletonList("https://www.googleapis.com/auth/monitoring");

  @Override
  public void doGet(HttpServletRequest request, HttpServletResponse response)
      throws IOException {
    String result = null;

    AppIdentityService appIdentityService = AppIdentityServiceFactory
        .getAppIdentityService();
    String access_token = appIdentityService
        .getAccessToken(scopes)
        .getAccessToken();
    CredentialsProvider credentialsProvider = FixedCredentialsProvider
        .create(GoogleCredentials.getApplicationDefault().createScoped(scopes));
    credentialsProvider.getCredentials().refresh();
    MetricServiceSettings metricServiceSettings = MetricServiceSettings
        .newBuilder().setCredentialsProvider(credentialsProvider).build();

    try(
        MetricServiceClient metricServiceClient = MetricServiceClient.create(metricServiceSettings);
        BigtableClusterUtilities bigtableClusterUtilities = BigtableClusterUtilities
            .forInstance(projectId, instanceId)
    ) {
      Cluster cluster = bigtableClusterUtilities.getSingleCluster();
      BigtableClusterName bigtableClusterName = new BigtableClusterName(cluster.getName());
      // Create MetricScaler
      MetricScaler metricScaler = new MetricScaler(
          bigtableClusterUtilities,
          bigtableClusterName,
          metricServiceClient,
          BigtableClusterUtilities.getZoneId(cluster),
          ProjectName.create(projectId)
      );
      // Scale
      result = metricScaler.doScale();
    } catch (StatusRuntimeException | IllegalStateException | GeneralSecurityException | InterruptedException e) {
      log.error("ScaleBigtable.doGet() exception: " + e.getClass().getName() + ": " +
          e.getMessage(), e);
      response.sendError(500, e.getMessage());
    } catch (Exception e) {
      log.error("metricServiceClient.close() failed: " + e.getClass().getName() + ": " +
          e.getMessage(), e);
      response.sendError(500, e.getMessage());
    }

    if (!response.isCommitted()) {
      response.setContentType("text/plain");
      response.getWriter().println(result);
    }
  }

}

The MetricScaler is very similar to the one in the example, just modified to simplify testing. The critical thing that solved unauth errors was credentialsProvider.getCredentials().refresh();. The only thing I've noticed are 2-3 warnings of the type com.google.cloud.bigtable.grpc.io.RefreshingOAuth2CredentialsInterceptor warn: Failed to refresh the access token. Falling back to existing token..


gflags_unittest.py does not respect TMPDIR

The tests in gflags_unittest.py rely on a hardcoded path in /tmp. This raises
sandbox violations when the build is performed in an isolated environment, and
has a collision potential when running tests for multiple Python
implementations in parallel.

The test should at least respect the TMPDIR environment variable. I'm attaching
a patch which uses tempfile.mkdtemp() to obtain an unique temporary directory,
respecting TMPDIR.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 16 Dec 2012 at 4:06
Attachments:

python-gflags-2.0-tests-respect-tmpdir.patch

Continuing clean-up. Applied.


Fix Chicago IL

Rolls Chicago into Cook County.

My PR from last night also attempts to address this issue. But the main focus of mine was to keep the URL for the .json file updated automatically.
https://github.com/lazd/coronadatascraper/pull/366/files
Related issues: https://github.com/lazd/coronadatascraper/issues/290 & https://github.com/lazd/coronadatascraper/issues/339


Fix popover arrow shifting to the left in message actions popover

When the message actions popover was invoked, the popover arrow seemed to be going left
which was because the topic length had no wrapper.
This commit removes the topic name altogether, from the list-item 'Mute the topic (topic)',
effectively making it 'Mute this topic' which solves the problem.
Fixes #4145.

@vinitS101 ready for primary review. Thanks.

Hi @ab1nash , the popover still seems to be shifting to the left in mobile browser view.

@vinitS101 thanks!
Thanks for pointing this out. Although I must say that it always positioned a bit towards the left.
One solution for this is to decrease the margin-right.
Should I go ahead and do that?

I actually noticed that on master as well. The chevron's tip and the popover's arrow aren't perfectly aligned even on wider screens. It's minor, but it's there.
If you could fix that as well then that'd be great.

Hi @ab1nash , the overall implementation looks great.
Although, the popover still seems to be shifting to the left in mobile browser view.

Could you mention the screen-width at which you took this screenshot?

@ab1nash The mobile browser view is basically the narrowest your browser can go (although, this happens for a little wider screen-width as well). I don't actually remember what width this was at, though.

@vinitS101 I have come up with a fix upto a minimum width of 300 px. I think it is safe to ignore further lower resolutions.

@vinitS101 kindly see

LGTM.
@rishig Can you please take a look at this?
Mobile browser view:

Medium Width:

Full screen:

small detail with the triangle here:

It has a line underneath it
It has some sort of box shadow that wasn't there before

But otherwise lgtm!

@rishig I looked into this. Seems like the CSS loading issue from before.
@vinitS101 thanks for the review! Could you please try reloading the page and checking if the shadows occur?
I am pretty sure it is the same problem that happened with my last issue where CSS didn't load properly at times.

Mid-sized screens

Mobile view

Web view

This is from CZO.

Reloading fixed it.

@timabbott please review. Thanks.

@ab1nash thanks for working on this, and sorry for the extremely slow review!  It works pretty well in my testing.  I wonder if there's a way to do it without duplicating all that code; since we close popovers on resize anyway, I think we could just put a conditional in the template rendering to determine which classes to include and whether to show the topic.
Can you try reworking it that way?

Also @vabs22 would this solution still work if we integrated your message list refactor?  It seems to rely on the message_top_line class existing.

@ab1nash thanks for working on this, and sorry for the extremely slow review! It works pretty well in my testing. I wonder if there's a way to do it without duplicating all that code; since we close popovers on resize anyway, I think we could just put a conditional in the template rendering to determine which classes to include and whether to show the topic.
Can you try reworking it that way?

@timabbott I removed all the duplicate code, and hence had to add a few variables in popovers.js, which are then used in the handlebars js template.
--removed duplicates from popovers.scss
--removed duplicates from actions_popover_content.hjs
I had to make a separate variable for the topic as  .. wasn't being rendered when passed through popovers.js
The relevant CSS for aligning the arrow wasn't altered, so it still works the way it was working before (removing the duplicates in the code-base).

Nice, this feels a lot cleaner.  The i18n isn't done properly (strings are extracted statically, not dynamically like your code assumes); you should just use i18n.t() in the JavaScript code to render the strings and pass that into the template.
See https://zulip.readthedocs.io/en/latest/translating/internationalization.html for details on how this all works.

Thanks for pointing that out Tim. Modified the strings to support i18n. Also fixed a lint error. Please check

I reworked this to do the i18n properly (different languages have different sentence order, so you can't handle arguments the way you described).
However, after looking at this, I think this is overall the wrong solution.  The changes to the message feed CSS are problematic, and we have a better solution we use for the popovers one gets from clicking on a user's avatar -- popping it up as a modal in phone-size views.

@ab1nash can you rework this to use that approach instead?  You should be able to borrow the existing positioning strategies around e.g. ``render_no_arrow_popover`.

@timabbott just for the mobile view right ? Sure, I can do that.

Yep!

@ab1nash can you rebase this and investigate the CI failures?

@timabbott I think this is an ES6 syntax issue. The test is passing when run individually and it also seems to be working on my dev environment. I'll try to look for a better alternative.

All tests passed. It was a syntax issue after all.

@timabbott I believe this PR is ready now. Please review.

[HELP] Tests are passing on my local copy (which was provisioned very recently as well)

Did you run casper tests locally?

Yes. Ran the full set of tests (./tools/test-all). I'll provision and run again.

Here's a screenshot of finding 'FAIL' on the output of ./tools/test-node-with-casper that yields no results

Okay, then it's probably an issue with Circleci. You should post this in #automated testing.

https://github.com/zulip/zulip/issues/4145#issuecomment-602066490> The thresholds are as follows:

Mobile view popover: <=320px
Narrow view : <=1165px
Normal view: >1165px
Test images:
Mobile view:

Narrow view:

Narrow view(a bit wider):

Normal view:

Unmute in narrow view:

This was fixed by the Tippy migration for that popover. See https://github.com/zulip/zulip/pull/23665.


Can I force all the URIs in the discovery doc to be SSL when I start identityserver on http?

Question
I run the service on my dev machine http://localhost:5001 and can access it through ngrok so I have a public SSL tunnel my test mobile can access. But when I access the discovery doc through ssl . https://004023d82ebf.ngrok.io/ .well-known/openid-configuration all the URIs in that doc are http not https. I guess since the service starts with http that’s the default. Is this something I can force to SSL?
Minimal working example
   // <code goes here>

Relevant parts of the log file
   <log goes here>

You need to enable the forwarded headers middleware, as you would with any reverse proxy:
https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/proxy-load-balancer?view=aspnetcore-3.1
:)


[Swift 3.0] Add Arbitrary instances for EVERYTHING

With the merger of SE-0075, we should be able to conditionally export new Arbitrary API for every module under the sun.  Off the top of my head

[ ] Foundation
[ ] UIKit
[ ] AppKit
[ ] CoreData

would be useful to start with.

I've already got some generators for CoreGraphics & UIKit that I'd be happy to contribute.

I've got some Foundation (pre-Swift 3) generators that need to be cleaned up, but I'd be happy to contribute, as well.

Do you think these would be better separated into different projects? It would keep the API footprint and code size small for SwiftCheck proper.

Now that it's been merged for real this time @kykim  do you still have those Foundation extensions?

I'll try to put together something w/ my CG & UIKit generators as well.

Fantastic!  It's going to be a bit awkward to work with an old toolchain on this stuff, but I have a feeling this is going to ship with 3.1 in January-ish so it shouldn't be that long!


Infra: tests run for 2 hours

We need to fix this before tests are useful.

https://github.com/webaverse/app/runs/4578753458?check_suite_focus=true

Closing as its completed


Fog to blend out skyboxes

Change fog to also cover skyboxes instead of only geometry.

This might however not actually be necessary, as you can change the skybox's colour to the same value as the fog.

We have fogdome for that.


Prevent to uncheck selected item with button group

for current version(1c480698ce0e881cbd28f1f0ddba95cee74ca834), selected button with ButtonGroup can be unchecked.

This PR will fix it.

note that 2.1.x doesn't have this problem.

Can't we count this as a feature? :) Or better make it optional by default being uncheckable=false.

Please make it an option, that behaviour is useful sometimes (e.g. when you provide sane defaults, and a person might like to not override them.)

Well I agree with @volzhs' change. Radio buttons are meant to be exclusive, you usually have to select one and can't select none. Check boxes on the other hand are non exclusive, and you can deselect or select multiple choices. That's how it works in most toolkits AFAIK.

I had faced this issue while trying to fix #8342.
Developer would expect one selected when using radio button (ButtonGroup).
I think developer needs to provide "Default" option in the list, if (s)he wants.

Well, yeah, I get the idea, but... what if I just want to make it possible to unselect all? More options is more options, and having to workaround the lack of that exact option would be a pain...

Well, yeah, I get the idea, but... what if I just want to make it possible to unselect all? More options is more options, and having to workaround the lack of that exact option would be a pain, in case it is needed...

Then you use check boxes, not radio buttons. :)

Can checkboxes be limited to only one option and make round shaped as radio buttons? This would solve the problem I think.

It can be done with Theme how it looks for checkbox.
and it's pretty easy to uncheck others when a checkbox clicked,
like doing for node in get_children(): node.queue_free() instead of having queue_free_children() remove_all_children() method.

If checkboxes can behave and look like radio buttons can't these two concept be merged into a single class? I always feel like they are variations of same thing while dealing with HTML. This would simplify code base IMO.

@hubbyist
Checkbox with ButtonGroup works as Radio button, like HTML.
what I meant was that... you can make radio button acting with checkbox + some codes, in HTML too, if it really need.

There is no more buttongroup node in 3.0
On Apr 11, 2017 11:26 AM, "volzhs"<EMAIL_ADDRESS>wrote:

@hubbyist https://github.com/hubbyist
Checkbox with ButtonGroup works as Radio button, like HTML.
what I meant was that... you can make radio button acting with checkbox +
some codes, in HTML too, if it really need.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/8343#issuecomment-293280307,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2xGSH2ScdP5RtUZYds2Ifv6gYMg3ks5ru42MgaJpZM4M4UuC
.

@reduz I mean that ButtonGroup instance at BaseButton in 3.0, not node. :smile:

IMO what @volzhs implements is how such GUI elements would be expected to work, so let's merge. If there's a use case for a different behaviour, it should likely be discussed in a new issue until we reach a consensus.


Overwrite image and audio cached assets when necessary

Currently we never overwrite image and audio cached assets, which can lead to outdated data in the viewer like here:
https://huggingface.co/datasets/ccmusic-database/instrument_timbre_eval/discussions/1
In particular we have overwrite=False here:
https://github.com/huggingface/datasets-server/blob/b84c8210ec023664c4780ab348b0232468afe116/libs/libapi/src/libapi/response.py#L36-L42
cc @AndreaFrancis @severo

It depends on the TTL for cached-assets (which is 1 day) so, the files will be refreshed after that time.
If we are forced to overwrite each time, it isn't worth having a CloudFront layer right?
If the dataset had a change in a lower interval than the TTL, I think we should recreate all related assets to each processing step:

first-rows should delete all the assets before processing (so that the obsolete files will be refreshed)
config-parquet should delete all the cached-assets before processing

I think first-rows is fine since it has overwrite=True:
https://github.com/huggingface/datasets-server/blob/b84c8210ec023664c4780ab348b0232468afe116/services/worker/src/worker/job_runners/split/first_rows_from_streaming.py#L283-L289
And yes config-parquet-metadata (which is the job that provides /rows) can take care of removing the outdated cached assets, good idea

Related to https://github.com/huggingface/datasets-server/issues/1823
Probably, if we recreate the dataset it won't work because https://github.com/huggingface/datasets-server/blob/main/services/admin/src/admin/routes/recreate_dataset.py#L61 is pointing still to the old cached-assets EFS but it should delete all files in S3.
Maybe I can add it as part of https://github.com/huggingface/datasets-server/pull/1976

https://huggingface.co/datasets/ccmusic-database/instrument_timbre_eval is now serving the correct files. What I saw is that there is a time period for CloudFront https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/Expiration.html
By default, each file automatically expires after 24 hours
So, if we change/update an S3 file in a lower time interval, for assets and cached-assets, we will have to invalidate the cache or something like this https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/Invalidation.html

If I understand correctly we can fix this issue by including the dataset revision hash in the cached asset path no ? It corresponds to "versioning file names" in the aws docs

Sound a great idea! I can work on it

Fixed in https://github.com/huggingface/datasets-server/pull/1988. However, we will still be having the issue with mixed cache that will be handled in https://github.com/huggingface/datasets-server/issues/1823


Sentry.captureMessage doesn't support passing additional data

Documentation for Raven at https://docs.sentry.io/clients/javascript/usage/#passing-additional-data states that it is possible to pass any desired additional data. However, this is not the case with sentry-electron. Is it intentional decision to drop support for passing additional data, or am I missing something?

Temporary solution:
setExtraContext({cause});
captureException(ex);
setTimeout(() => {
	setExtraContext({cause: null});
});

@dimitarnestorov, thanks for a workaround! However, I'm still curious about whether this feature is no longer supported or it's just not implemented yet and haven't been discontinued

Not implemented. Check out #74.

Good to know, thanks again, @dimitarnestorov!

Version 0.6.0 is on it's way.
You can achieve the same result with this:
Sentry.getDefaultHub().withScope(() => {
      Sentry.getDefaultHub().configureScope(scope => {
        scope.setExtra('details', 'This is some extra information.');
        Sentry.captureMessage('This is a sample message');
      });
});

We are still working on the documentation for the new SDKs.
While this approach seems to be more complicated than before it's also more powerful.
Hope this helps.

Why does so simple thing need extra 5 lines of code? I expected it to be something like
Sentry.captureException(error, { extra: { detailName: 'Detail value' } });

@alxmiron We changed the public API of our SDKs to make it more logical and less magical.
Before you were able to pass anything as a second arg, while this may seem convenient, many people were facing unexpected behavior since it was not clear what the limits are of what to pass.
We went with the approach I stated before which is more verbose but on the other hand, it's clear what's happening.

This syntax crazy and optimizes for Sentry, not customers. The whole idea of Sentry is to scatter simple bits of code throughout your app to capture important errors and conditions. 6 lines of code each time I want to do something simple really adds up. 1 line of code could be used.
You could support the shorter syntax for simplicity (95% of what users will be doing) and manage the "more powerful", "more verbose" syntax for the 5% of people who care about it (and how things work under the hood).
You don't want to be telling customers "Sentry is easy to use, it's only 6 lines of JavaScript any time you want to send an info message to us!"

An alternative idea...
Sentry.captureMessage('This is a sample message').setExtras({
  details: 'This is some extra information.',
  level: 'info',
});

I think the main thing I have beef with is these parts:
Sentry.getDefaultHub().withScope(() => {
      Sentry.getDefaultHub().configureScope(scope => {

That just seems like stuff that should be internal, not part of your API. It's fine to expose more powerful APIs but provide simple ones.

Following the latest doc, would not the new syntax for that be:
Sentry.withScope(scope => {
  scope.setExtra('details', 'This is some extra information.');
  scope.setLevel('info');
  Sentry.captureMessage('This is a sample message');
});

@HazAT ?
This seems much more reasonable, while still verbose.

@MonsieurV That's correct.
See:

https://github.com/getsentry/sentry-electron/issues/108#issuecomment-422291699
https://github.com/getsentry/sentry-electron/issues/115

We're using version 0.10.1 (and therefore sentry-javascript 4.x.x) and the syntax you mention works now.

I had the same issue with the api but @MonsieurV has the right approach regarding syntax. To expand upon it, I made a simple helper function to log errors:
function errorHandler(title, data, level) {
	level = level || 'info';
	data  = data  || {};
	Sentry.withScope(scope => {
		Object.keys(data).forEach((key) => {
			scope.setExtra(key, data[key]);
		});
	  scope.setLevel(level);
	  Sentry.captureMessage(title);
	});
}


[BUG] Monitoring is not coming up in 4.6.1

General information

OS: Linux
Hypervisor: KVM
Did you run crc setup before starting it (Yes/No)? Yes
Running CRC on: Laptop

CRC version
CodeReady Containers version: 1.18.0+bb304aa
OpenShift version: 4.6.1 (embedded in binary)

CRC status
 version: 1.18.0+bb304aa
DEBU OpenShift version: 4.6.1 (embedded in binary)
Checking file: /home/stavros/.crc/machines/crc/.crc-exist
DEBU About to run SSH command with hidden output
DEBU SSH command succeeded
DEBU About to run SSH command:
df -B1 --output=size,used,target /sysroot | tail -1
DEBU SSH command results: err: <nil>, output:<PHONE_NUMBER>0<PHONE_NUMBER>4 /sysroot
CRC VM:          Running
OpenShift:       Running (v4.6.1)
Disk Usage:      13.1GB of 32.72GB (Inside the CRC VM)
Cache Usage:     15.09GB
Cache Directory: /home/stavros/.crc/cache

CRC config
- cpus                                  : 8
- memory                                : 40960

Host Operating System
NAME=Fedora
VERSION="32 (Workstation Edition)"
ID=fedora
VERSION_ID=32
VERSION_CODENAME=""
PLATFORM_ID="platform:f32"
PRETTY_NAME="Fedora 32 (Workstation Edition)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:32"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f32/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=32
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=32
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation

Steps to reproduce

sudo rm -rf ~/.crc sudo rm -rf ~/.kube
crc cleanup
crc setup
crc config set memory 40960
crc config set cpus 8
crc config mem, cpus
crc start --log-level debug -p pull.txt
eval $(crc oc-env)
oc login -u .. -p ...
oc patch clusterversion/version --type='json' -p '[{"op":"remove", "path":"/spec/overrides/0"}]' -oyaml (0 is the right index)

Expected
Monitoring to be up according to docs.
Actual
oc get pods -n openshift-monitoring returns no pods.
Logs
https://gist.github.com/skonto/a720158a2c993acd72eed9d0b2e0ad54
Note: 4.5.9 works with no issues.

I noticed: level=debug msg="SSH command results: err: exit status 1, output: The connection to the server api.crc.testing:6443 was refused - did you specify the right host or port?\n" level=debug but as I said my setup works as expected on 4.5.9 so firewall etc is ok.

Maybe this was a transient failure? Otherwise would be useful to do  crc delete; crc cleanup; crc setup; crc start --log-level debug and provide logs.

@cfergeau the logs are in that gist above.

How can I re-enable monitoring after I patch clusterversion once?

@cfergeau the logs are in that gist above in the description ^^^^ here are the logs for 4.5.9. It should be transient because the same msg is in those logs too.

The occurrences I see in the logs are expected:
&{[-F /dev/null -o ConnectionAttempts=3 -o ConnectTimeout=10 -o ControlMaster=no -o ControlPath=none -o LogLevel=quiet -o PasswordAuthentication=no -o ServerAliveInterval=60 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null<EMAIL_ADDRESS>-o IdentitiesOnly=yes -i /home/stavros/.crc/cache/crc_libvirt_4.6.1/id_rsa_crc -i /home/stavros/.crc/machines/crc/id_rsa -p 22] /usr/bin/ssh <nil>}
level=debug msg="About to run SSH command:\noc get secret --context admin --cluster crc --kubeconfig /opt/kubeconfig"
level=debug msg="SSH command results: err: exit status 1, output: The connection to the server api.crc.testing:6443 was refused - did you specify the right host or port?\n"
level=debug
level=debug msg="error: Temporary error: ssh command error:\ncommand : oc get secret --context admin --cluster crc --kubeconfig /opt/kubeconfig\nerr     : exit status 1\noutput  : The connection to the server api.crc.testing:6443 was refused - did you specify the right host or port?\n - sleeping 1s"
level=debug msg="retry loop: attempt 1"
Using SSH client type: external
Using SSH private key: /home/stavros/.crc/cache/crc_libvirt_4.6.1/id_rsa_crc (-r--------)
Using SSH private key: /home/stavros/.crc/machines/crc/id_rsa (-rw-------)
&{[-F /dev/null -o ConnectionAttempts=3 -o ConnectTimeout=10 -o ControlMaster=no -o ControlPath=none -o LogLevel=quiet -o PasswordAuthentication=no -o ServerAliveInterval=60 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null<EMAIL_ADDRESS>-o IdentitiesOnly=yes -i /home/stavros/.crc/cache/crc_libvirt_4.6.1/id_rsa_crc -i /home/stavros/.crc/machines/crc/id_rsa -p 22] /usr/bin/ssh <nil>}
level=debug msg="About to run SSH command:\noc get secret --context admin --cluster crc --kubeconfig /opt/kubeconfig"
level=debug msg="SSH command results: err: exit status 1, output: The connection to the server api.crc.testing:6443 was refused - did you specify the right host or port?\n"
level=debug
level=debug msg="error: Temporary error: ssh command error:\ncommand : oc get secret --context admin --cluster crc --kubeconfig /opt/kubeconfig\nerr     : exit status 1\noutput  : The connection to the server api.crc.testing:6443 was refused - did you specify the right host or port?\n - sleeping 1s"
level=debug msg="retry loop: attempt 2"
Using SSH client type: external
Using SSH private key: /home/stavros/.crc/cache/crc_libvirt_4.6.1/id_rsa_crc (-r--------)
Using SSH private key: /home/stavros/.crc/machines/crc/id_rsa (-rw-------)
&{[-F /dev/null -o ConnectionAttempts=3 -o ConnectTimeout=10 -o ControlMaster=no -o ControlPath=none -o LogLevel=quiet -o PasswordAuthentication=no -o ServerAliveInterval=60 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null<EMAIL_ADDRESS>-o IdentitiesOnly=yes -i /home/stavros/.crc/cache/crc_libvirt_4.6.1/id_rsa_crc -i /home/stavros/.crc/machines/crc/id_rsa -p 22] /usr/bin/ssh <nil>}
level=debug msg="About to run SSH command:\noc get secret --context admin --cluster crc --kubeconfig /opt/kubeconfig"
level=debug msg="SSH command results: err: <nil>, output: NAME                       TYPE                                  DATA   AGE\nbuilder-dockercfg-5k8d5    kubernetes.io/dockercfg               1      17d\nbuilder-token-9lzgx        kubernetes.io/service-account-token   4      17d\nbuilder-token-vg5vg        kubernetes.io/service-account-token   4      17d\ndefault-dockercfg-qm6rt    kubernetes.io/dockercfg               1      17d\ndefault-token-84xb9        kubernetes.io/service-account-token   4      17d\ndefault-token-kzm8s        kubernetes.io/service-account-token   4      17d\ndeployer-dockercfg-sb62w   kubernetes.io/dockercfg               1      17d\ndeployer-token-68wmr       kubernetes.io/service-account-token   4      17d\ndeployer-token-krb5m       kubernetes.io/service-account-token   4      17d\n"
level=debug msg="NAME                       TYPE                                  DATA   AGE\nbuilder-dockercfg-5k8d5    kubernetes.io/dockercfg               1      17d\nbuilder-token-9lzgx        kubernetes.io/service-account-token   4      17d\nbuilder-token-vg5vg        kubernetes.io/service-account-token   4      17d\ndefault-dockercfg-qm6rt    kubernetes.io/dockercfg               1      17d\ndefault-token-84xb9        kubernetes.io/service-account-token   4      17d\ndefault-token-kzm8s        kubernetes.io/service-account-token   4      17d\ndeployer-dockercfg-sb62w   kubernetes.io/dockercfg               1      17d\ndeployer-token-68wmr       kubernetes.io/service-account-token   4      17d\ndeployer-token-krb5m       kubernetes.io/service-account-token   4      17d\n"

it failed the first 2 times, 3rd time api server was reachable, so this succeded. It tries several times as the api server is expected to be down initially.
In order to disable/reenable monitoring, I'd use crc delete to get a new cluster.

@cfergeau there is no other way? I mean if you have a cluster you need to kill the cluster to restart monitoring? I tried the above.

You can readd the monitoring-related stuff to .spec.overrides in cluster-version but I did not try that.

@cfergeau what do you mean by reading? I dont see anything in the docs on how to restart monitoring. Someone needs to patch the clusterversion and remove that entry or edit the resource on the fly and remove the entry in .spec.overrides.

Btw I get some resources created:
$ oc get svc -n openshift-monitoring
NAME                          TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)                      AGE
alertmanager-main             ClusterIP   <IP_ADDRESS>    <none>        9094/TCP,9092/TCP            22d
alertmanager-operated         ClusterIP   None             <none>        9093/TCP,9094/TCP,9094/UDP   22d
cluster-monitoring-operator   ClusterIP   None             <none>        8443/TCP                     22d
grafana                       ClusterIP   <IP_ADDRESS>    <none>        3000/TCP                     22d
kube-state-metrics            ClusterIP   None             <none>        8443/TCP,9443/TCP            22d
node-exporter                 ClusterIP   None             <none>        9100/TCP                     22d
openshift-state-metrics       ClusterIP   None             <none>        8443/TCP,9443/TCP            22d
prometheus-adapter            ClusterIP   <IP_ADDRESS>   <none>        443/TCP                      22d
prometheus-k8s                ClusterIP   <IP_ADDRESS>   <none>        9091/TCP,9092/TCP            22d
prometheus-operated           ClusterIP   None             <none>        9090/TCP,10901/TCP           22d
prometheus-operator           ClusterIP   None             <none>        8443/TCP,8080/TCP            22d
telemeter-client              ClusterIP   None             <none>        8443/TCP                     22d
thanos-querier                ClusterIP   <IP_ADDRESS>    <none>        9091/TCP,9092/TCP,9093/TCP   22d

However I get no pods and the node is ok with resources. Pods can be scheduled, I can run a busybox pod anywhere:
Allocated resources:
  (Total limits may be over 100 percent, i.e., overcommitted.)
  Resource           Requests      Limits
  --------           --------      ------
  cpu                2275m (30%)   0 (0%)
  memory             6941Mi (18%)  512Mi (1%)
  ephemeral-storage  0 (0%)        0 (0%)
  hugepages-1Gi      0 (0%)        0 (0%)
  hugepages-2Mi      0 (0%)        0 (0%)

Is this with a newly created cluster after modifying overrides in clusterversion? or is this still a cluster where you are trying to fix the monitoring stack? In general, it's supposed to be the job of the various operator to make sure everything is in order and start the pods as needed.

Is this with a newly created cluster after modifying overrides in clusterversion
yes

@cfergeau I tried the new release and monitoring and other operators in that overrides list dont come up. Something has changed in 4.6+?

This is being tracked in https://bugzilla.redhat.com/show_bug.cgi?id=1899459

Thanks a lot!

You should be able to work around this issue by running
oc delete validatingwebhookconfigurations prometheusrules.openshift.io before trying to enable monitoring.

OK cool let me try that, I guess that the webhook error prevented the deployment.

Actually you need both changes from that PR https://github.com/code-ready/snc/pull/277/commits/d43198dcc38609b1fe6eff0a2eccc8c8e2ce28ec so etcd changes are needed as well

How can I apply these changes in that PR? Build crc?

You can do it with oc on a running cluster:
$ oc edit clusterversion version
....
  - kind: Deployment
    group: apps/v1
    name: etcd-quorum-guard
    namespace: openshift-etcd
    unmanaged: true

(append these lines to the existing content)
$ oc scale --replicas=1 deployment etcd-quorum-guard -n openshift-etcd
$ oc delete validatingwebhookconfigurations prometheusrules.openshift.io

then you can follow the instructions as usual

It works now:
$ oc get pods -n openshift-monitoring
NAME                                           READY   STATUS    RESTARTS   AGE
alertmanager-main-0                            5/5     Running   0          58s
alertmanager-main-1                            5/5     Running   0          58s
alertmanager-main-2                            5/5     Running   0          57s
cluster-monitoring-operator-595888fddd-6pkl5   2/2     Running   0          89s
grafana-65454464fd-zwf6v                       2/2     Running   0          66s
kube-state-metrics-7cb89d65d4-7qn7k            3/3     Running   0          74s
node-exporter-2pk6l                            2/2     Running   0          74s
openshift-state-metrics-57969c7f87-sfpzg       3/3     Running   0          75s
prometheus-adapter-c87f6d6b4-74ttl             1/1     Running   0          69s
prometheus-adapter-c87f6d6b4-jhvtp             1/1     Running   0          69s
prometheus-k8s-0                               5/6     Running   1          57s
prometheus-k8s-1                               5/6     Running   1          57s
prometheus-operator-5d9964cccc-sk4k2           2/2     Running   0          74s
telemeter-client-79cb64ffc9-xfjxd              3/3     Running   0          71s
thanos-querier-5b54d44547-5bmhv                4/5     Running   0          67s
thanos-querier-5b54d44547-lsb2b                5/5     Running   0          67s

Feel free to close this.

tracked https://github.com/code-ready/crc/issues/1704 also.


Plugins and jQuery compatibility?

Because In use just some features and plugins of jQuery.
Are cash plugins available or (some) jQuery plugins compatible to cash?

Every jQuery plugin that doesn't use anything that's not implemented by cash should work, if it doesn't please open up an issue about that.
I'm trying to keep the project as close as jQuery in terms of behavior, but every once in a while I discover a way in which the two APIs behave differently and I fix that, so there might still be some (hopefully minor) incompatibilities.


about memory leaks in runtime decoder

Describe the bug
During debugging runtime version of decoder and checking memory leak using valgrind, a lot of memory leaks are founded.
==24650==    definitely lost: 22,168 bytes in 131 blocks
==24650==    indirectly lost: 738,712 bytes in 9,394 blocks
==24650==      possibly lost: 33,750,192 bytes in 103 blocks
==24650==    still reachable: 1,022,665 bytes in 14,729 blocks
==24650==                       of which reachable via heuristic:
==24650==                         multipleinheritance: 4,880 bytes in 63 blocks
==24650==         suppressed: 0 bytes in 0 blocks
Almost all of them are caused by libtorch_cpu.so
First leak is found when doing encoder chunk forward, after ‘forward_encoder_chunk’ is invoked.
auto outputs = model_->torch_model()
->get_method("forward_encoder_chunk")(inputs)
.toTuple()
->elements();
when doing batch test, there is also continuous growth of memory. E.g.
In the begining,  memory occupation is 74428kb. It increases to 609944kb after model is loaded, the amount of increase is approximately equal to the model size. Then decoding a list of audios, memory is continuously increasing, from initial 1717696kb to 2896672kb, and it still increased when decoding subsequent data.
When I searching solutions, someone said libtorch produces memory leaks during forward process if batch size of data used to compute is changed , it seems that libtorch using the method ‘forward_encoder_chunk’, which in practice using forward_chunk, I am not whether forward_chunk also has similiar probelms.
besides, I am not sure, does export_jit python script pack the model class including the forward_encoder_chunk, litorch just help c++ invoke python method? So to fix this solution, it needs to check forward method in python scripts, or is there any good solution for memory leaks problem?

据我了解 这不是内存泄漏，如果从model里拿到的tensor不主动release的话 libtorch的内存管理会delay清理l这些内存
如果可以的话 你找台内存大一些机器 比如16g 即使并发后 内存会稳定到一定范围

@mirajane0520 请问你解决这个问题了吗？
我也遇到了同样的问题，客户端连续调用两天，服务端的内存会一直缓慢增长

Got the same problem here, is there any update about this issue?


Avatar: Image too large

It should tell you the max image size.
I also think it would be good to allow large images. When you click on the profile picture, it would show you the large image with a button to change it.

I'll remove the size limit as it resizes to 256x256 anyways, which should be small enough. Also, we'll be moving to IndexedDB for storage so localStorage limits won't be an issue.


N95 language shows up twice in map filers

See screenshot:

I believe the correct fix is the second filter should be just surgical mask (no n95 language).

Correct, second filter should be "Surgical masks"

fix here, will merge as soon as translations come back: https://github.com/findthemasks/findthemasks/pull/366

Fixed for en, but I suspect I approved merges in the wrong order because Spanish (and other langs?) are not fixed.

Fixed in IT!


v1.11 backports 2022-08-12

#20885 -- iptables: skip NOTRACK rules deletion (@jibi)

Once this PR is merged, you can update the PR labels via:
$ for pr in 20885; do contrib/backporting/set-labels.py $pr done 1.11; done

/test-backport-1.11

Triage:

Cilium L4LB XDP (ci-l4lb-1.11) - Hit #19770
ConformanceAKS (ci-aks-1.11) - Hit https://github.com/cilium/cilium/issues/17907
gke-stable (test-gke) - Hit #20906
k8s-1.22-kernel-4.19 (test-1.22-4.19) - Hit #20907

These failures do not appear to be related to the change, merging.


model properties not mapped in formly gets deleted

is there any settings that I can enable so fields that are not in formly will still be in the model after an input change?
for example i got a model
{ columna : "a", columnb : "b"}
in formly i only set columna. when i change the value of columna formly then removes the columnb property in the model.

Hi,
could you please provide a reproduction, here is our stackblitz starter example:
https://stackblitz.com/edit/ngx-formly-ui-bootstrap
Thanks!


Make the joined node the master

So I synced up two nodes. First I created a node then a setup a second node to join the network and sync went fine but later when I deleted the first node. The second node is no longer forming blocks of it's own and hence a lot of pending transactions and transaction underpriced error comes up. Any help would be appreciated.

Sorry about this but where would I find the raftID for the concerning peer I would like to remove? Since that is passed as the argument to raft.removePeer?


Feature Request: Add a configuration API endpoint with initial admin and/or apikey setup

Hi,
by trying to automate the deployment of PowerDNS-Admin, I noticed some showstoppers in regards of API usage. I have a couple of suggegstions that would allow for a much easier setup.

Allow the API-key, created as in [1], to be used on all endpoints (either exclusively or parallel with the basic auth)
Allow user registration via a new API endpoint to allow a hands-free initial installation
Allow PDNS-Admin configuration via API (PDNS settings, Authentication, etc.)

As I am not a python developer, I think I can't contribute any actual code for this. If I can support in another way to help further this topic, please let me know.
KR, itbane
[1] https://github.com/ngoduykhanh/PowerDNS-Admin/blob/master/docs/API.md

Hello,
We have a plan to implement such things later. A configuration endpoint, and at least another one to create the initial admin.
I'm not quite sure if we want to allow the API Key for all endpoints (/powerdnsadmin) but we will decide it then.
Regards

Hello,
This request is stale for too long. Regarding our policy to cleanup this project, we are closing it. As this is a Feature Request, it will be listed in #1178
Regards
PowerDNS Admin Team
See #1153 for the policy


Hope dropdown has a small arrow just like Popover,  as a "Props"

This function solves the problem (这个功能解决的问题)
Hope dropdown has a small arrow just like Popover,  as a "Props"
Expected API (期望的 API)
and the documentation of "dropdown" has no description about "placement"

dropdown support popover props, maybe you can take a look at the popover documentation.

poppover props has "showArrow" props  but it does not work because it does not handle the situation when internalRenderBody has value with "showArrow" props  in PopOverBoby.


undefined symbol: uuid_unparse

After building from head, attempts to use the library produce the following error:
2017-05-12 14:41:20: mama_loadmamaPayload(): Could not open middleware bridge library [mamazmqimpl] [/build/share/OpenMAMA-zmq/master/lib/libmamazmqimpl.so: undefined symbol: uuid_unparse]

This doesn't happen with 1.0 branch.
When comparing the two builds, the 1.0 build reports the following:
$ readelf -d ./OpenMAMA-zmq-1.0/libmamazmqimpl.so | grep NEEDED

Dynamic section at offset 0xe688 contains 25 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libmama.so]
 0x0000000000000001 (NEEDED)             Shared library: [libuuid.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libzmq.so.3]
 0x0000000000000001 (NEEDED)             Shared library: [libevent-1.4.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

The master build reports the following:
$ readelf -d ./OpenMAMA-zmq/build/src/libmamazmqimpl.so | grep NEEDED

Dynamic section at offset 0x1d6a8 contains 25 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libmama.so]
 0x0000000000000001 (NEEDED)             Shared library: [libzmq.so.5.1.1]
 0x0000000000000001 (NEEDED)             Shared library: [libevent-1.4.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

Notice that libuuid.so.1 is listed as NEEDED for 1.0 branch, but not for master.
I'm not sure how the project can even build without libuuid, but it definitely won't run, at least in my environment.
Thanks for any help!

Erm, you build master with scons or cmake?

cmake

Thanks @btorpey just pushed in a change which looks to fix it on my end - try again now.

Thanks!  Looks to do the trick, will keep you posted.
P.S. Very nice piece of work here and I'm looking forward to playing with it.

Works like a charm -- thanks again!

Great news glad to see it getting some independent Tyre kicking :)


Add string renderer feature

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
✔

Fixed issues
#19

Questions:

Which string renderer should be default?
May be throws exception if string renderer not set?

How make events on before/after render string?

Current events and set $file as null
Current events, set $file as null and add $string property
New events with $string property
New events without $string property

I want rename TemplateRendererInterface to FileRendererInterface. It's good idea?

See issue about the reason for closing it.


Each Source class currently has a "publisher_name" variable. Is this needed?

Remove if not?

Mentioned in #42.
There might be uses for this in future, and it's a tiny thing to leave it / add to new ones so let's leave it for now until things become clearer. Closing.


Error on using composer to install package

Hi,
Upon using Laravel 5 and this package I have come across this error when doing composer install command:
composer require caouecs/sirtrevorjs
Please provide a version constraint for the caouecs/sirtrevorjs requirement: 1.4.11

then I press return and I get this:
  Problem 1
    - Installation request for caouecs/sirtrevorjs 1.4.11 -> satisfiable by caouecs/sirtrevorjs[1.4.11].
    - caouecs/sirtrevorjs 1.4.11 requires thujohn/twitter ~1.2.0 -> no matching package found.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

Read <http://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Can you help at all...?

I think it's same problem than #8

hi @caouecs how do I add this in? Do I add thujohn twitter in after composer install of this package?

No, this week-end, I will do two branchs, one for Laravel4 and one for Laravel5

@caouecs thats great, I will wait to see it come through. Cheers

Hello,
@mdunbavan I did a branch for Laravel 5, I don't test it yet. But you can test ;)
"caouecs/sirtrevorjs": "2.0.x-dev"

Hi @caouecs I still get the error:
roblem 1
    - Installation request for caouecs/sirtrevorjs 2.0.x-dev -> satisfiable by caouecs/sirtrevorjs[2.0.x-dev].
    - caouecs/sirtrevorjs 2.0.x-dev requires thujohn/twitter 2.0.*@dev -> no matching package found.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

same problem, but it seems it's good version for Laravel5

whats the best solution for this to work. It's now installed but I cannot publish config files to get correct paths for the CSS assets or js assets?

This evening, I will change the way to publish config and assets

cheers that would be awesome :)

now you can publish config

Cheers @caouecs please can you allow it to use the eventable.js and underscore? Its not adding it when I am using {!! SirTrevorJs::scripts() !!}. Its adding the source for sir trev but missing its dependancies

Hello @mdunbavan ,
sorry for the delay.
So, you can define the list of scripts in the config file.


Sort out how to do configuration

probably copy what we are doing with MDS to specify where server + db are.

Closing as this has been done via inserting strings into the configuration file via conda and installing conda packages of configuration data.
Closed by #53


How to disable small popup menu?

How to disable this pop up menu that shows when highlighting text, sometimes it gets in the way of UI elements or text I am highlighting for other reasons.

unselect all tools as below

@josStorer Thanks


[FEATURE] ImageUpdateAutomation: compare image tag timestamp before override

Problem
I would like to do the image tag substitution if and only if the timestamp of the newly discovered image is greater than the one that is found in yaml spec. I'm aware that the the ImagePolicies and ImageRepository can be configured to sort the tags in asc/desc numerical order but in my case, it is not enough and results in substitutions I don't want to be applied.
Question
Would it be possible to add an extra verification logic in place where we do the image substitution? I believe the actual setter logic is applied here.

Is it possible for you to tag the images with the timestamp?
The main complicating factor of implementing your request I think would be that Flux doesn't really store the image metadata for any images now. We depend on the tag to be sortable, as described in Sortable Image Tags because pulling the metadata is expensive, and pulling the timestamp can be rate limited.
The last example here:
https://fluxcd.io/docs/components/image/imagepolicies/#examples
is based on the tagging strategy used here (RFC-3339):
https://hub.docker.com/r/minio/minio
Does this help?

@kingdonb I indeed tag my images with the timestamp and use the sorting provided by ImagePolicies. The case is that from time to time I also make a manual change on the marked line with the image I build in my pipeline. Then after a moment, this change gets overriden by the IAC with the image whose tag is indeed the latest one according to my filterPattern policy but its timestamp is smaller than the timestamp of the image I put manually. Sorry if this seems confusing.

The main complicating factor of implementing your request I think would be that Flux doesn't really store the image metadata for any images now. We depend on the tag to be sortable, as described in Sortable Image Tags because pulling the metadata is expensive, and pulling the timestamp can be rate limited.

Hmm, I don't think we need to fetch metadata. We can just read the marked line, parse it to get the timestamp, compare that timestamp with the timestamp of the new value that came and only substitute if the new timestamp is greater than old one. Am I missing something?

if and only if the timestamp of the newly discovered image is greater than the one that is found in yaml spec

Very sorry I believe I misinterpreted your description here. Flux doesn't consider the image definition or the tag that is present in the cluster or in the git repository prior to reconciling the ImageUpdateAutomation, it is simply asserting the current latest version into the manifest.
If you are saying that you had a newer image in the cluster but Flux overwrites it with an older one, there are a few ways that I can think of this might happen, but in general it shouldn't be possible unless you are doing something odd.
The only way I can see that happening is if you are writing commits manually that IUA would have written sooner or later but you wrote them ahead because ImageUpdateAutomation is too slow. There are other mitigations for the slowness, you can increase the interval on ImageRepository without much performance impact for example.
I'm trying to get to the bottom of exactly what's happening here because this seems like it may be an "X-Y" problem. As in "I'm asking for X because I don't know that Flux can do Y" – to go with that information, you can also use a Receiver webhook through the notification-controller so that ImageRepository updates are processed immediately, if your image registry provider supports webhook delivery (which most should be supported by Flux!)
Could you provide some clarity about when Flux is overwriting your newer image tag commits with timestamps? Because in general I think this should not be possible, except for some weird edge cases; I'd rather not go through my list of guesses but just ask instead, maybe you can clarify exactly when this is happening, so I can help find the best approach to mitigate it.
Taking the prior tag content into consideration would be a major design change that would need to go through an RFC process and is unlikely to be accepted without strong justification. I don't understand how this issue bit you yet well enough to recommend such a change myself as it seems like it would be significantly more complicated comparing and parsing than just asserting the latest tag into the field like Flux does now.

@kingdonb thank you so much for your answer. Let me give you more detailed explanation of more less my case.

I have the image policy that is looking for all images with my naming schema of --- .
IUA controller works great.
Let's assume the latest tag found(and the substituted to my yaml) by IAU is service-main-sha-123.
I use the timestamp extract in asc numerical order.
Now I build a new image called e.g. manual-service-main-sha-124 and make a commit manually to the file.
Then IAU comes after a moment and it overrides this image with service-main-sha-123 which is an older image but it is the one that satisfies the ImagePolicy.

That is why I thought about comparing timestamps. Is this now clear @kingdonb ?

@leszczynskimikolaj Yes perfectly clear.
I would suggest rather than writing a commit manually ahead of IUA, you should set up a Webhook Receiver for your ImageRepository. This will ensure it reconciles immediately after a tag is pushed to the Image Repo. It is as I suspected – the ImageUpdateAutomation interval arrives before the ImageRepository interval does, and when it reconciles, it only reconciles itself – nothing reconciles "through" so the ImageRepo at this point may be stale, and this edge case is where you've described it.
I'm not certain if this behavior will be considered a bug or UX issue, or working as designed, but I have some docs to support this suggestion. From the Image Update Guide:
https://fluxcd.io/docs/guides/image-update/#trigger-image-updates-with-webhooks

You may want to trigger a deployment as soon as a new image tag is pushed to your container registry. In order to notify the image-reflector-controller about new images, you can setup webhook receivers.

Another alternative, instead of making the commit and pushing it (in case there's some reason in your environment that you cannot add a webhook, perhaps there is no access allowed to the cluster from outside) is to reconcile the Image Repository. You should get the same commit that you are looking for by running flux reconcile image repository <name>
Internally, Flux resources that connect to each other all communicate via Kubernetes API object subscription. If a GitRepository is referenced by a Kustomization in the spec.sourceRef then Kustomization will be notified and reconciled immediately as soon as the GitRepository is updated and a new artifact is ready to fetch from its service endpoint.
The same relationship exists between ImageUpdateAutomation and ImageRepository resources (via ImagePolicy) – when the ImageRepository receives its update, any ImagePolicy that it has attached will automatically receive an event as subscription and it will trigger any ImageUpdateAutomation in its namespace to reconcile immediately.
Webhook Receivers are different than the internal behavior because the physical resources (git repository, image repository, etc.) are actually located outside of Kubernetes and do not fall within the K8S API's scope of control, so they cannot be set implicitly through the API. So in order to get this subscription behavior, you have to set it up according to these guides.
If you didn't know about these features and now you do, will this perhaps make your life easier if you don't have to worry about pushing commits manually in any case?


Server controlled data pattern broken by merging useTableState and useTable

I have a case where the data is retrieved remotely, with the data paginated, filtered, and sorted as part of that api call.  Previously I could retrieve the sort order and the filter settings before retrieving the data and passing it on to the useTable call.
Now, the data is required before I can find out what parameters are required to retrieve it.
I'm really not sure how to address this.  Merging these two functions has made something that used to be rather trivial, and to my eye, made it impossible.  Sadly, the controlled examples are too trivial to really highlight the problem - try changing makeData to more closely mimic a real api and take page number, page size, sort order, and filter values, then you'll see what I mean.
I hate to suggest rolling back to separating these two functions again, but I'm a bit stumped.
How would you suggest addressing this issue?

@tannerlinsley Any suggestions here?  I feel that I must be missing something pretty fundamental here.

Just got back from vacation. I'll take a peek at this.

I think I'm also missing something in your issue. Could you elaborate with an example that shows the issue you're having?

OK, I take it back. It's not broken, it's just different.  Many things needed to be converted from simple state accessors to functions that get passed the instance later - functionally it's probably much the same, it's just somewhat more verbose code.
It was certainly convenient to be able to reference state before calling useTable, but in the end it does work like this.


Add openai feedback support

Overview
Add get_ai_message_ids api function to retrieve message ids to be used in the customer's ai feedback endpoint.

Codecov Report

Merging #942 (2e0abc3) into main (17cd48d) will increase coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is 82.77%.

@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
+ Coverage   81.77%   81.79%   +0.01%
==========================================
  Files         190      191       +1
  Lines       19581    19761     +180
  Branches     3401     3429      +28
==========================================
+ Hits        16012    16163     +151
- Misses       2589     2605      +16
- Partials      980      993      +13

Files
Coverage Δ

newrelic/config.py
73.87% <100.00%> (+0.04%)
:arrow_up:

newrelic/api/ml_model.py
64.51% <30.76%> (-24.38%)
:arrow_down:

newrelic/hooks/mlmodel_openai.py
86.58% <86.58%> (ø)

... and 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

This is looking good, will we have a separate PR for the new record_ai_feedback_event API?


Add notice that we're removing Basic Auth from EXO

Docs Build status updates of commit d4ce17b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/exchange-web-services/how-to-communicate-with-ews-by-using-the-ews-managed-api.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


gradio web demo

added easy to use web demo for sepformer on gradio hub

Hi,
thank you very much for this PR. After an internal discussion, we don't really want to add this in the main repo. This would force users to have gradio as a mandatory external dependency (which is something we are trying to minimize). It however good to keep the SpeechBrain interfaces on your website. We just ask you to add a clear link to the original repo.


Reg s

Number of shareholders
If the number of distinct shareholders has no bearing on the transfer of Reg S securities, we should remove the data and logic related to this quantity.
International status
What is the exact meaning of the isInternational flag on TheRegSToken?  It is not used anywhere.  Also, the ARegS restrictor contract maintains its own table of investors with international status.
Proposed Changes
It seems that we can get rid of RegSToken and 'TheRegSToken, if they do not need to keep track of any values like the shareholder count.  (We would use the RestrictedToken` contract for the issue.)

@GambolingPangolin We need to keep track of shareholder count because after 12 months, it can convert to reg D. I do agree isInternational can be removed, that was left in due to human error.

Merged into dev-0.1.1


improve test coverage

Pull Request Test Coverage Report for Build 939348077

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 81.834%

Files with Coverage Reduction
New Missed Lines
%

join/sax/src/jsonwriter.cpp
2
69.5%

Totals

Change from base Build 939300620:
0.0%

Covered Lines:
1446

Relevant Lines:
1767

💛  - Coveralls


图片九宫格不可用

如题

emmm, a bit embarrassed...  it's being a bug from Pixi official framework a long time ago... I'll try to fix this.

fixed in  356bf1a


ADD Member page with more info

Hi, i would like to have many case for my member : email, social media, function, phone number, (case we can edit with personnal id, for me instrument of music, and description.

Hello, with the new version of Bludit v4.0 rc1, I would like to close the old Github issues. If you feel that your issue is not resolved in the latest version, create a new ticket.

Help and Support use the Forum https://forum.bludit.org
Bugs and new requests here in Github https://github.com/bludit/bludit/issues


Iasaolu/order button

Resolves #22
Description

Implemented the Order page dialog that appears whenever the "Dialog" button is pressed
Type of change

Switched from using a TextField to using an Input. The reason why is Input allows the for the dollar sign
How Has This Been Tested?

I tested the feature as I developed it by trying various things
Screenshots

I removed unused variables


Unit test cycles are unnecessarily long

There are some opportunities to reduce turnaround time in our build-and-unit-test cycles, through a mix of build changes and test execution changes.

build step
dev, warm build cache
proposed changes, warm build cache
dev, not cached
proposed, not cached

git clean -dfx through make checkprogs -j4
0m45s
0m45s
2m43s
2m31s

touch EnergyEfficientRegion.[ch]pp and make checkprogs -j4
0m8s
0m7s
0m15s
0m11s

make check
1m29s
0m31s
1m28s
0m30s

Build changes:
Move gmock constructors/destructors to .cpp files. Right now they are in hpp files, either explicitly, or implicitly through the default implementations. Gmock tracks functions via members in the mock class. The constructors and destructors that handle all of those objects need to be generated by the compiler. Moving their implementations (even if stubs/defaults) to .cpp files ensures they are only generated once, instead of being generated for each test that includes the header.
The main offenders from a profiled build (-ftime-trace in clang 9) appear to be:

MockAgent
MockApplicationIO
MockComm
MockPlatformIO

And slightly less impact from:

MockFrequencyGovernor
MockPlatformTopo

Run changes:
Our current test driver runs a test binary once per test case. A large portion of test execution time is spend loading and linking each test program (hundreds of times).
A significant amount of time can be saved by running each test binary one time, letting the test's internal driver take care of aggregating and running all tests. The above measured time improvements are the result of doing just that. It will correctly report pass/fail state. But it will not report test counts correctly (each binary containing many tests will be counted as one test). To get parity with our current recording, we will need to make our test wrapper script ensure that the test output is in an expected automake test report format (documentation).
Additional places we might save time:

Sleep less in tests. shmem tests spend about 8 seconds sleeping
Run gtest and pytest as 2 parallel tasks. Or, keep these tasks serial, but configure their internal test drivers to do parallel test case execution. Git history shows that these tests were originally made serial due to complications with shared memory in some tests. Be cautious of that if going with this approach.
Evaluate whether any unnecessary #includes are present. E.g. Run include-what-you-use

Note that iwyu gives some wrong recommendations for the version of googletest we currently use (1.11.0). Version 1.12.0 of googletest adds iwyu annotations so that it will give appropriate recommendations.

Current top offending tests have embedded sleeps:

SharedMemoryTest::fd_check_shm 5000 ms
SharedMemoryTest::fd_check_file 5000 ms
TimeIOGroupTest::sample 2000 ms
SharedMemoryTest::invalid_construction 2000 ms
SharedMemoryTest::share_data_ipc_file 1001 ms
TimeIOGroupTest::read_signal_and_batch 1000 ms
TimeIOGroupTest::read_signal 1000 ms
SharedMemoryTest::share_data_ipc_shm 1000 ms


security updates multiple jdbc driver

some drivers provided with the current distribution have known security vulnerabilites reported by different scanner.
This PR updats the driver to the latest bugfix releases of the versions used.

snowflake-jdbc

CVE-2023-30535 (GHSA-4g3j-c4wg-6j7x)
SNYK-JAVA-NETSNOWFLAKE-5425048 (https://security.snyk.io/vuln/SNYK-JAVA-NETSNOWFLAKE-5425048)

sqlite-jdbc

CVE-2021-20227
CVE-2022-35737
CVE-2022-46908

mariadb-connector

no CVE assigned here but race condition in connection pooling, problems fetching catalog meta data for some setups and multiople ArrayIndexOutOfBounceExcetions as well as ozen other bugfixes...

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Stefan Seide seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank your for your PR. A lot of these are already in our pipeline and will be included in our release. However, I will confirm.

Many thanks, some updates like sqlite were outstanding for a  longer time, thats why i created the PR. But good to heare you are already planning these kind of updates.
Another thing - the license check does not recognize that i have already singed the CLA. Clicking on the CLA links above i get an "already signed" message from license/cla. Looking into my profile from license-assistant it does not list this CLA as one i have signed... And the commits email address is my accounts main address.

@sseide that's fine, I will go in manually with the CLA.
In regards to why the SQLite one has been outstanding, we normally have this pick this kind of thing up via a few automated process and for some reason they have no linked these issues to the driver. However, with your help and my own research I can see the issue and will update appropriately.


Start using posixpath where appropriate.

Since windows is broken, os.path on that platform uses \ instead of /

Only briefly tested reading data from hdfs using Anaconda2 (+ maybe a few libraries from http://www.lfd.uci.edu/~gohlke/pythonlibs/), but that seems to work now.


Unable to create project

Unable to create project. It stops in between and nothing happens after wards. It just sits there.

@prasyada this looks like an intermittent issue, could you please let us know which template you tried?

I tired terraform template

@prasyada could you please retry and check here

It worked this time. thanks.

@prasyada thank you.


Improve layout of word form search results

As a improvement of #205,  improve visual organization of standardized forms, lemmas, definitions, linguistic breakdowns, etc., as detailed in #224 and #232.

@kobexamoh, this one is for you, and is an extension of your current work.

Not enough detail in this issue, plus most of this has been fixed in #462; @aarppe, please reopen if you think otherwise. The linguistic breakdown is better documented in #266.

This has been subsumed by other issues, which have now been addressed there.


[FSPE-7567] Improve html blueprint documentation in search input component

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-28/1/. :white_check_mark:

You can check this PRs instance in https://1ff4329b1c9ebe3cbfd7b25ef92bb1a7e13bf419-chi-pr.enterprise.ctl.io


'influx user create' adds user to both 'owners' and 'members'

Steps to reproduce:
$ influx user create -n<EMAIL_ADDRESS>-o dev -skip-verify
ID			Name
08ca5fdf4c76d000<EMAIL_ADDRESS>$ curl --insecure -H "Authorization: Token $TOKEN" --request GET $URL/api/v2/orgs/$ORGID/members
{
	"links": {
		"self": "/api/v2/orgs/.../members"
	},
	"users": [
		{
			"role": "member",
			"links": {
				"self": "/api/v2/users/08ca5fdf4c76d000"
			},
			"id": "08ca5fdf4c76d000",
			"name"<EMAIL_ADDRESS>			"status": "active"
		}
	]
}

$ curl --insecure -H "Authorization: Token $TOKEN" --request GET $URL/api/v2/orgs/.../owners
{
	"links": {
		"self": "/api/v2/orgs/.../owners"
	},
	"users": [
		{
			"role": "owner",
			"links": {
				"self": "/api/v2/users/08ca215f1576d000"
			},
			"id": "08ca215f1576d000",
			"name": "orgdfd3ced56dbd2ae7-user-11618",
			"status": "active"
		}
	]
}

Two things:

the UI appears to default to member when the user id is in both members and owners which is read-only and not the expected UI experience
the name in owners is wrong. I tested this against a remocal (cloud 2) test deployment, but it is odd that the name is correct in members and wrong in owners

This can be worked around with influx org members remove --member 08ca5fdf4c76d000 --id $ORGID after creating the user.
Assuming that adding the new user to owners by default is desirable, it may make sense to add a --member switch to influx user create so that users can opt into changing that behavior. Also see https://github.com/influxdata/influx-cli/issues/353

Is it the same user in both members and owners? The name is different, but also the user ID is different.
We've gotten this question from OSS users quite a bit, and the workaround requires adding the user as an org owner, and removing them as a member, so I wonder if there is a server-side difference? See: https://community.influxdata.com/t/creating-admin-users-in-influxdb-2-oss/19754
Running a similar set of commands on OSS I get this:
influx user create -n<EMAIL_ADDRESS>-o dev -skip-verify
ID			Name
08ce9235bbcb7000<EMAIL_ADDRESS>
curl --insecure -H "Authorization: Token $TOKEN" --request GET $URL/api/v2/orgs/$ORGID/members
{
	"links": {
		"self": "/api/v2/orgs/0dd41d155f728187/members"
	},
	"users": [
		{
			"role": "member",
			"links": {
				"self": "/api/v2/users/08ce9235bbcb7000"
			},
			"id": "08ce9235bbcb7000",
			"name"<EMAIL_ADDRESS>			"status": "active"
		}
	]
}

{
	"links": {
		"self": "/api/v2/orgs/0dd41d155f728187/owners"
	},
	"users": [
		{
			"role": "owner",
			"links": {
				"self": "/api/v2/users/08c7d22929c16000"
			},
			"id": "08c7d22929c16000",
			"name": "wbaker",
			"status": "active"
		}
	]
}

Note that the org owner is a different user than the org member - and the org member is actually my operator account that I used to create the organization.

Hrmm, I can confirm the behavior you are seeing. The user was only added to members and not owners. I must've done something weird locally and then was too hasty in writing my reproducer. Thanks for double-checking and sorry for the noise. Closing.

I could see it happening if you create an org with a user, and then add that same user as a member to the org. It would then be both a member and an owner. Haven't tested that though, so maybe it doesn't work.


[WIP] Ibc work

Implement IBC tuning compilation and parsing
Still tbd

method block count utilization
generics testing

(Also my most recent changes introduced some sort of subtle bug, but I wanted to get this out for initial code review from the folks in Europe.)

method block count utilization

I think it would make the code review more meaningful if we don't add any more scope to this. If anything, it would have helped if this was doing just production or just consumption.

I have a series of continuing work to finish up work with IBC, but as @MichalStrehovsky notes, this is already really big. Please review this as is.

I've some more stuff to do for the rest of the day, so I'll just wait on @MichalStrehovsky's feedback overnight/tomorrow morning.


fix: network filter

Fixes # .
Changes proposed in this pull request:

Changed route query param q at line 15 to network
Also I've rename this variable to network for more consistency =)

@sarmatdev this is breaking the search.

@sarmatdev this is breaking the search.

Fixed, maybe the fix is not the most concise, but now the search works correctly🤔


Fix indentation in readme example

Thanks for the project! This fixes the indentation in the example in the readme.

great, thanks!


Running npm run dev overwrites test/index.js

Expected behavior
running npm run dev should not alter the files in the project
Current behavior
test/index.js gets overriten.
Reproducible sample
run npm run dev
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
No response
chart.js version
current master
Browser name and version
No response
Link to your project
No response

https://github.com/jlmakes/karma-rollup-preprocessor/issues/75

@LeeLenaleee FYI we had the same issue in chartjs-plugin-annotation and chartjs-adapter-luxon. We backed to previous version of preprocessor: npm i<EMAIL_ADDRESS>--save-dev


feat: enable builds with Fedora 39

An experiment to see how much we need to change for Fedora 39.
The images are now being pushed to Quay for base and silverblue.
I am not expecting many packages to build.  This is just an experiment.

Hopefully just a matter of negativo17 and rpmfusion supporting 39

Hopefully just a matter of negativo17 and rpmfusion supporting 39

Yup. Though, I'd like to move towards only depending on fedora upstream, rpmfusion, and COPRs which we have some control over, if possible.


Add Storybook(-like) instead of a demo?

This way we could also partly solve a "how to see the spec" issue.
layout/
   background/
     color
     url
  content/
    ...

@xaviervia I personally don't really like Storybook from a tech perspective, but is there any decent alternatives?

There is no need to use anything. A simple page done manually will do.
We just need to set some style to it so it looks good. I can draft something on Sketch.

Also, let’s build it and publish it to Github pages.

Here. Consider these to be wireframes. There is no suggestion of fonts or colors in these ones, just layout.

Wdyt?

Cool, I can start writing the react components for it and we can nail the details of the design later.

Overrides #4 since the documentation will be in the demo instead of the README


Error when including AssessmentsQueryHelper from the console

Description
No JIRA ticket associated
Change AssessmentsQueryHelper#format to #format_for_frontend so as not to conflict with Kernel#format when including AssessmentsQueryHelper from the console.
(Bugfix) How to Replicate
drop into rails c
include AssessmentsQueryHelper
app/helpers/assessment_query_helper.rb:71:in `format': wrong number of arguments (given 2, expected 1) (ArgumentError)

(Bugfix) Solution
Change the method name

Make sure to create a ticket for this

Make sure to create a ticket for this

Done: https://tracker.codev.mitre.org/browse/SARAALERT-1348


error in version numbering?

Hello,
I am Phd candidate working with Benjamin Boudon.
Your latest version 1.0.2 is on same commit as the version 1.0.1. Is there any error in this numbering?
I downloaded the latest version and tested on Dymola, the relative path for TorqueCommand.txt is corrected, but the RealOut connectors are still present in poseMux models.
And also, the Dymola recognizes the new latest version as 1.0.1 not 1.0.2 when I imported it.
Thank you for revising this issue.
Best regards,
Hyunjun BAE
<EMAIL_ADDRESS>

Sorry, I had a fix in the repo on my PC and I forgot to push it on GitHub before making the release. 1.0.2 should now have the connector fix.


Eject command for customization

Currently customizing the jest config is a manual process. Add an eject command to:

Simplify customization
Make explicit that this kind of customization may be incompatible with future updates to the test runner

Todo:

[ ] Add comments to the config file explaining the "smarts"
[ ] Re-eject to get the most up-to-date config & diff against your previous changes

implemented in #54


short-form function 'tonum' is undefined

tonum is in the documentation but it's not defined in the code.

It shouldn't have been in the documentation.
Fixed in v2.2.1.
Thanks very much for the report.


Old branch - needs completion/merging? testing

I'm just having a tidy through old branches, and noticed this branch with a fair amount of work but doesn't look as though it's been merged. @anchit-chandran is this still current and if so what needs to be done to prepare it for PR?
https://github.com/rcpch/digital-growth-charts-react-client/tree/testing

@anchit-chandran do you have any updates on this?

Hey i actually can't remember! The branch was for implementing testing for the client. Can have a look once I'm back after uni workload has died down, 3-4 weeks


Please invite me to the GitHub Community Organization

  I want to join this organization!

  Once you submitted this issue, the GitHub Actions bot will send you an email invitation.
Please kindly accept to join our organization :smile:

Thank you for you email .
On Fri, Feb 23, 2024, 2:28 PM github-actions[bot] @.***>
wrote:

Assigned #395
https://github.com/Your-First-Open-Source-Project/start-here/issues/395
to @Pritirekha23 https://github.com/Pritirekha23.
—
Reply to this email directly, view it on GitHub
https://github.com/Your-First-Open-Source-Project/start-here/issues/395#event-11901004908,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYPENI2VU5ME2JI3T54VI5DYVBK33AVCNFSM6AAAAABDWLHFNKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHEYDCMBQGQ4TAOA
.
You are receiving this because you were assigned.Message ID:
<Your-First-Open-Source-Project/start-here/issue/395/issue_event/11901004908
@github.com>


Back to top

Need to add elements to documentation

Needs design specs, best practices on mobile v. web versions


feat: add support for smart picker

Adds support for the smart picker used within mail, text app, notes, office and talk.
I haven't tested any of the AI features since I don't have that setup

Thank you!


add cell value example

Hi @dfinke
I looked around the example folder, and it seems there is no add cell value example there, I need to manipulate excel sheet, like add value to specific cells individually or recursively, something like that.
Thanks for your help.
Thanks
Eric Xin

Please provide a repro example, with data, script and xlsx

$basepath = '\<IP_ADDRESS>\csv\rpaonly\archive\shosalesorder'
$ext = '.xlsx'
$basename = 'template'
$chgname = 'CEB113-CHN0362_CMCMEL_C02' #input parameter
Copy-Item $basepath$basename$ext $basepath$chgname$ext
if (Test-Path $basepath$chgname$ext){
$ExcelData = Open-ExcelPackage $basepath$chgname$ext
$Data = $ExcelData.Workbook.WorkSheets[1].Cells
$rows = 10

$headers = for ($i = 2; $i -le $rows; $i++) {
    $Data[$i,1].Value = "item name"   #style is input parameter
}

$headers = for ($i = 2; $i -le $rows; $i++) {
    $Data[$i,2].Value = "item color desc" #color name is input parameter
}

$headers = for ($i = 2; $i -le $rows; $i++) {
    $Data[$i,3].Value = "item color" #color code is input parameter
}

Close-ExcelPackage $ExcelData

}
Add cell value I think I have come up a ps1 file, and tested it well. But I am curious whether I can set the same value to a cell range, but to a cell one by one, right now I am using "for" to write a value to a cell range.
Please help.
Thanks
Eric Xin

$Data["A2:B5"].Value = 'Test'
You'd need to figure out the Excel range letters etc.
I'm leveraging the Excel Object Model there.
Off the top of my head $Data[1,1,2,2].Value = 'Test' may be supported.
I think it may be startRow, startCol, EndR, EndC.

Got it, thanks.


No keyboard controls in IE10

I have found that when using IE10, the user is only able to open the calendar but cannot navigate via keyboard. I was able to reproduce the same issue on the plugin examples. Is this a known issue?

There are also no keyboard controls in Firefox 35.0.1, and Safari 8.0.5. The span to open the calendar controls cannot be selected via tabbing from the input field, and none of the keyboard controls apply.
The keyboard commands seem to get focus to the control in Chrome only.

Based on this stackoverflow post I was able to use the keyboard controls with Safari 8.0.6 when using option-tab to navigate between elements with the keyboard on the demo.
Still not sure about Firefox (38.0.5)


FhirModel.cs issue in STU3 - pre

After removing DSTU2 and adding STU3, I was able to resolve most issues except for FhirModel.cs
public IEnumerable<SearchParameter> FindSearchParameters(string resourceName)
{
return SearchParameters.Where(sp => Equals(sp.Base, GetResourceTypeForResourceName(resourceName)) || sp.Base == ResourceType.Resource);
}

If I remove this, will I break anything?
sp.Base == ResourceType.Resource

It won't find the generic search parameters like _id and lastupdated anymore, since they are defined on Resource.


Azure Devops - Could not setup API to Code Review

Report
What did you do?
Ran bundle exec danger on pipeline script
What did you expect to happen?
Run Dangerfile without issues
What happened instead?
ℹ Please replace this with of what happened instead.
Could not set up API to Code Review site for Danger

For Danger to run on this project, you need to expose a set of following the ENV vars:
 - GitHub: DANGER_GITHUB_API_TOKEN
 - GitLab: DANGER_GITLAB_API_TOKEN
 - BitbucketServer: DANGER_BITBUCKETSERVER_USERNAME, DANGER_BITBUCKETSERVER_PASSWORD, DANGER_BITBUCKETSERVER_HOST
 - BitbucketCloud: DANGER_BITBUCKETCLOUD_USERNAME, DANGER_BITBUCKETCLOUD_PASSWORD
 - LocalOnly: DANGER_LOCAL_ONLY
 - VSTS: DANGER_VSTS_API_TOKEN, DANGER_VSTS_HOST

Found these keys in your ENV: BUILD_SOURCEBRANCH, SYSTEM_TEAMFOUNDATIONCOLLECTIONURI, SYSTEM_TASKDEFINITIONSURI, SYSTEM_JOBATTEMPT, AGENT_VERSION, SYSTEM_PULLREQUEST_SOURCECOMMITID, BUILD_QUEUEDBY, SYSTEM_COLLECTIONURI, SYSTEM_HOSTTYPE, SYSTEM_JOBPARALLELISMTAG, BUILD_REPOSITORY_GIT_SUBMODULECHECKOUT, NVM_CD_FLAGS, ANDROID_HOME, CONFIGURATION, CHROMEWEBDRIVER, SHELL, BUILD_STAGINGDIRECTORY, APPLE_CERTIFICATE_KEYCHAIN, AGENT_MACHINENAME, TMPDIR, SYSTEM_WORKFOLDER, COMMON_TESTRESULTSDIRECTORY, AGENT_JOBNAME, MSDEPLOY_HTTP_USER_AGENT, RCT_NO_LAUNCH_PACKAGER, JAVA_HOME_8_X64, AGENT_OSARCHITECTURE, CERTIFICATE, BUILD_SOURCEVERSIONAUTHOR, BUILD_REQUESTEDFOREMAIL, NUNIT_BASE_PATH, RUNNER_PERFLOG, AGENT_READONLYVARIABLES, SYSTEM_STAGEATTEMPT, AGENT_ACCEPTTEEEULA, NUNIT3_PATH, LC_ALL, SYSTEM_DEFINITIONNAME, GIT_TERMINAL_PROMPT, SYSTEM_CULTURE, JAVA_HOME_11_X64, RUNNER_TOOL_CACHE, BUILD_REPOSITORY_PROVIDER, BUILD_REPOSITORY_CLEAN, AGENT_TEMPDIRECTORY, BUILD_SOURCEBRANCHNAME, NVM_DIR, USER, SYSTEM_JOBIDENTIFIER, SYSTEM_TEAMFOUNDATIONSERVERURI, TF_BUILD, AZURE_HTTP_USER_AGENT, SYSTEM_TASKDISPLAYNAME, BUILD_QUEUEDBYID, APPLE_CERTIFICATE_SIGNING_IDENTITY, SYSTEM_STAGENAME, AGENT_DISABLELOGPLUGIN_TESTRESULTLOGPLUGIN, INSTALLAPPLECERTIFICATE_SIGNINGIDENTITY, SSH_AUTH_SOCK, VSTS_PROCESS_LOOKUP_ID, SYSTEM_TEAMPROJECTID, AGENT_ROOTDIRECTORY, __CF_USER_TEXT_ENCODING, HOMEBREW_NO_AUTO_UPDATE, AGENT_HOMEDIRECTORY, SYSTEM_TEAMPROJECT, AGENT_TOOLSDIRECTORY, BUILD_REPOSITORY_ID, BUILD_SOURCEVERSIONMESSAGE, agent.jobstatus, SYSTEM_PULLREQUEST_TARGETBRANCH, SYSTEM_JOBDISPLAYNAME, BUILD_REPOSITORY_LOCALPATH, SYSTEM, BUILD_REASON, AGENT_BUILDDIRECTORY, SYSTEM_PIPELINESTARTTIME, BUILD_SOURCESDIRECTORY, AGENT_OS, SDK, PATH, SYSTEM_PHASEATTEMPT, SYSTEM_ISSCHEDULED, _, SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI, PERFLOG_LOCATION_SETTING, SYSTEM_PULLREQUEST_ISFORK, BUILD_BUILDURI, EDGEWEBDRIVER, PWD, CONDA, DOTNET_ROOT, SYSTEM_DEFINITIONID, JAVA_HOME, SYSTEM_STAGEID, AGENT_DISABLELOGPLUGIN_TESTFILEPUBLISHERPLUGIN, JAVA_HOME_12_X64, JAVA_HOME_7_X64, SYSTEM_ENABLEACCESSTOKEN, LANG, SYSTEM_TASKINSTANCENAME, APPLE_PROV_PROFILE_UUID, SYSTEM_PHASEDISPLAYNAME, BUILD_REPOSITORY_NAME, SYSTEM_SERVERTYPE, XPC_FLAGS, BUILD_REPOSITORY_URI, PIPELINE_WORKSPACE, BUILD_DEFINITIONNAME, AGENT_WORKFOLDER, SYSTEM_JOBNAME, BUILD_REQUESTEDFOR, XPC_SERVICE_NAME, GECKOWEBDRIVER, SYSTEM_ARTIFACTSDIRECTORY, SYSTEM_TIMELINEID, AGENT_ID, HOME, SHLVL, AGENT_RETAINDEFAULTENCODING, SYSTEM_JOBPOSITIONINPHASE, BUILD_ARTIFACTSTAGINGDIRECTORY, BUILD_BINARIESDIRECTORY, BUILD_REQUESTEDFORID, BUILD_BUILDID, SYSTEM_TASKINSTANCEID, PROVISIONING, LOGNAME, BUILD_SOURCEVERSION, LC_CTYPE, INSTALLAPPLECERTIFICATE_KEYCHAINPATH, JAVA_HOME_13_X64, DANGER_VSTS_HOST, SYSTEM_DEFAULTWORKINGDIRECTORY, SYSTEM_PULLREQUEST_PULLREQUESTID, SYSTEM_JOBID, ANDROID_NDK_HOME, SYSTEM_TOTALJOBSINPHASE, SYSTEM_PULLREQUEST_SOURCEBRANCH, AGENT_NAME, SYSTEM_STAGEDISPLAYNAME, XCODE_11_DEVELOPER_DIR, SYSTEM_PULLREQUEST_PULLREQUESTITERATION, BUILD_DEFINITIONVERSION, SYSTEM_PLANID, SYSTEM_PHASEID, INSTALLAPPLEPROVISIONINGPROFILE_PROVISIONINGPROFILENAME, AGENT_JOBSTATUS, SCHEME, SYSTEM_COLLECTIONID, DANGER_VSTS_API_TOKEN, INSTALLAPPLEPROVISIONINGPROFILE_PROVISIONINGPROFILEUUID, TASK_DISPLAYNAME, ENDPOINT_URL_SYSTEMVSSCONNECTION, SYSTEM_PHASENAME, BUILD_BUILDNUMBER, BUILD_CONTAINERID, BUNDLER_ORIG_BUNDLE_BIN_PATH, BUNDLER_ORIG_BUNDLE_GEMFILE, BUNDLER_ORIG_BUNDLER_VERSION, BUNDLER_ORIG_GEM_HOME, BUNDLER_ORIG_GEM_PATH, BUNDLER_ORIG_MANPATH, BUNDLER_ORIG_PATH, BUNDLER_ORIG_RB_USER_INSTALL, BUNDLER_ORIG_RUBYLIB, BUNDLER_ORIG_RUBYOPT, BUNDLE_BIN_PATH, BUNDLE_GEMFILE, BUNDLER_VERSION, RUBYOPT, RUBYLIB, GEM_PATH, GEM_HOME, MANPATH.

Failing the build, Danger cannot run without API access.

Your Environment

Which CI are you running on? Azure Devops Pipelines
Are you running the latest version of Danger? Yes
What is your Dangerfile?

# Sometimes it's a README fix, or something like that - which isn't relevant for
# including in a project's CHANGELOG for example
declared_trivial = github.pr_title.include? "#trivial"

# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"

# Warn when there is a big PR
warn("Big PR") if git.lines_of_code > 500

# Don't let testing shortcuts get into master by accident
fail("fdescribe left in tests") if `grep -r fdescribe specs/ `.length > 1
fail("fit left in tests") if `grep -r fit specs/ `.length > 1

Notes
I have added the two VSTS environment variables that it asks for, and it does recognise them in the list of my environment variables

Weird, perhaps if they were empty this would fail?


Add "Local File to Embed" tag

Create a .md file in /tags with the following content inside:
f = discord.File("some_file_path", filename="image.png")
e = discord.Embed()
e.set_image(url="attachment://image.png")
await messagable.send(file=f, embed=e)

# Note that the filename in the File constructor and the filename in the URL must match.

Docs: https://discordpy.readthedocs.io/en/latest/faq.html#how-do-i-use-a-local-image-file-for-an-embed-image

This question is frequently asked in the discord.py channel, so having a tag would make a lot of sense, and save a lot of time.

Greetings, human @ChiliPy.
I approve of this idea of creating a discord.py tag for attaching an image within an embed, but I fear it is not giving a proper explanation of what's going on.
I'd suggest including what's in the docs, and maybe adding some information on top of it, if you'd like. Doesn't have to be a clone of the doc's description of what's going on, it can be in your own words.
We can shuffle all this around in a PR if you decide to make one, or if you'd prefer someone else to do it.


attempt to fix

This doesn't completely solve your problems, but it's interesting.
I couldn't get all of the packages to compile, because it looks like you're half way through a refactor. But I think I got the rsa/ package to compile.
But... the circumstances under which I can get it to compile are strange:
I made the Nargo.toml point to path dirs. I.e. locally checked-out branches of:

bignum, main branch.
rsa, but this fork (https://github.com/iAmMichaelConnor/noir_rsa/blob/mc/update-to-0.4.0/lib/) with a local tweak to its Nargo.toml to point to the local bignum main branch too.

Nargo v0.37.0 or nightly worked.
If I tried to actually point any of the dependencies to proper GitHub urls (even if they're identical to the local branches), I started getting the error: Expected type RuntimeBigNum<_, _>, found type RuntimeBigNum<_, _> error that you're seeing.
I wonder if nargo is somehow getting confused between two identical types which get routed through differing dependencies?

Thanks! It does seem to solve the problem. Strange issue. I'll merge this and try to fix the other issues I encounter


Vulnerability roundup 90: luajit-2.0.5: 1 advisory [7.5]

search, files

[ ] CVE-2020-15890 CVSSv3=7.5 (nixos-20.03)

Scanned versions: nixos-20.03: b50d55871fb. May contain false positives.
Cc @andir
Cc @grwlf
Cc @thoughtpolice
Cc @vcunat

For reference, upstream doesn't consider this to be a security bug.


Add chip component

Warning
Heavily WIP

Description
Heavily WIP but wanted to show something as a possible implementation for Chips.
It's far for being perfect since I haven't spent too much time on it. Just tried quickly to get back what we developed for our Tags component at Orange and to tweaked it (not very well) to Bootstrap style.
Just would like your opinion on starting from that or do you prefer to start from scratch?
Type of changes

[x] New feature (non-breaking change which adds functionality)

Checklist

[x] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
[x] My change introduces changes to the documentation
[x] I have updated the documentation accordingly
(NA) I have added tests to cover my changes
[x] All new and existing tests passed

Live previews

https://deploy-preview-37846--twbs-bootstrap.netlify.app/docs/5.3/components/chip/

Related issues
Closes #31033

I've seen in https://deploy-preview-36309--twbs-bootstrap.netlify.app/docs/5.3/examples/badges/ that maybe a chip would be a badge?

Could be! Those snippets are far from perfect, and might not make sense to repurpose for a new overall component, but maybe they could! Let's think on it ahead of starting v6 :).