Document “container runtime” concept

This is a Feature Request

What would you like to be added

Add a new page to the Concepts section that explains container runtimes
Make the container runtime glossary page reference the new concept page

Why is this needed
Kubernetes supports multiple container runtimes. Readers can expect to find a page that explains the concept.
Comments
The existing glossary entry has a broken link to /docs/reference/generated/container-runtime
/priority important-longterm

Container Runtime is considered as one of Kubernetes terminology and is explaned in page docs/reference/glossary.
It has a link https://kubernetes.io/docs/reference/glossary/?fundamental=true#term-container-runtime
with explanation like below:
The container runtime is the software that is responsible for running containers.[-]
Kubernetes supports several container runtimes: Docker, containerd, cri-o, rktlet and any implementation of the Kubernetes CRI (Container Runtime Interface).

Is the new page like https://github.com/kubernetes/community/blob/master/contributors/devel/sig-node/container-runtime-interface.md?

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-node/container-runtime-interface.md explains what CRI is, rather than what a container runtime is. There's overlap between the two and it would be OK to copy from [container-runtime-interface.md]9https://github.com/kubernetes/community/blob/master/contributors/devel/sig-node/container-runtime-interface.md](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-node/container-runtime-interface.md) when writing the new concept page.
I'd expect that a new concept page on container runtimes would also hyperlink to other relevant docs such as https://kubernetes.io/docs/setup/production-environment/container-runtimes/

/remove-lifecycle stale
/help

Still worth documenting
/remove-lifecycle stale

/remove-lifecycle stale


Omitting duplicate definition of properties on object deconstruction

Search Terms
deconstruct parameter

Suggestion
Add any syntax convenience for deconstructing a value object (or just for function parameters) without specifying each property.

Use Cases
For example, currently, when we need to define a function with something like a settings object (without an existing interface or type alias defined, for it should be where it belongs to), we must either access the properties like foobar.foo, foobar.bar with repeatedly a lot of foobar., or deconstruct it like
({ foo, bar, baz }: { foo: string, bar: number, baz: boolean }) => {
    //...
}

But property names are duplicately specified, which is very painful and ungraceful especially when there are a lot of properties with long names.

Examples

({ ... }: { foo: string, bar: number, baz: boolean }) => {
    //...
}

which should extract all properties from the argument (which may depend on the type definition instead of the enumeration of keys, for not breaking the guidelines)

({ foo as string, bar as number, baz as boolean }) => {
    //...
}

actually using ":" instead of "as" would be  but it already means alias naming.

Checklist
My suggestion meets these guidelines:

[ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[ ] This wouldn't change the runtime behavior of existing JavaScript code
[ ] This could be implemented without emitting different JS based on the types of the expressions
[ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[ ] This feature would agree with the rest of TypeScript's Design Goals.

See #29526


Update StateMachine.cpp

this->_isRemoving = false; is moved to line 30
if _isRemoving is true and stack is empty, then _isRemoving won't be updated to false

Thank you for contributing towards this repository.


⚠ Secret Website 3 has degraded performance

In a532ce0, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 15908 ms

Resolved: Secret Website 3 performance has improved in 1c1faa2 after 14 minutes.


Project admission

Should we set a minimum number of stars for new GitHub projects added ? Like at least 10 or 20 or whatever
cc @vsouza

Hmmmm, I don't think so. It's all about quality in Awesome-iOS

Ok how do you evaluate quality ?

It's difficult, but by looking to the Readme, you can see what is good and what is garbage. Sometimes I also download and test if it's a plugin or UI

I believe that good documentation is the key, not the number of stars or whatever.
Usually, good projects have good documentation.

Thanks for your feedback

totally agree!!!
Sent from my iPhone

On Nov 18, 2015, at 9:52 AM, Miguel Araújo<EMAIL_ADDRESS>wrote:
I believe that good documentation is the key, not the number of stars or whatever.
Usually, good projects have good documentation.
—
Reply to this email directly or view it on GitHub.

sorry for delay. I agree with @miguelarauj1o, good documentation is enough. Number of stars is very relative.


Change color on load

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I have looked in the documentation, but I am unable to find the setting.
Expected behaviour
I want the house to change color to the solor where the power comes from.
Ex.. my solar panel color are orange, so if my solar panels are supplying the house load the color of the house has to be orange.
And also if I draw my house current from grid then, the house color changes to the grid color.
And last if I drwa my load from solar battery, then the house color need to change to the battery color.
It would be great if it where possible to mix the colors, so the hose has the % of color from the loads.
Possible Solutions
Make some color settings :)
Mode
lite
Context / Reason
It would look great.
The card power-flow-card-plus has this option to change color, but it is not as great as sunsynk-power-flow-card

Nice idea. Let me see what I can do

Great, I am looking forward to try it, if it's possible :)

I've added this to 3.17.0. Give it a try 😄

Is working GREAT! :)

Thanks !

I have just seen this in my dashboard. What a great idea.


Hamming generate tests

hamming exercise:

added an example generator
regenerated the tests with it

make test is failing with the following error:
  1) Failure:
HammingTest#test_disallow_first_strand_longer [/tmp/hamming.BsRYhY7oVw/hamming_test.rb:61]:
ArgumentError expected but nothing was raised.
  2) Failure:
HammingTest#test_disallow_second_strand_longer [/tmp/hamming.BsRYhY7oVw/hamming_test.rb:65]:
ArgumentError expected but nothing was raised.

Is the solution updated to raise an argument error?

Sorry, I didn't think of it.
Now, I've committed a further change which changed the example implementation accordingly.

Awesome!
@markijbema @henrik I know we've been back and forth on whether or not we should have an error case. I'm back to wanting to explicitly handle the error.
In particular, the reason that I wanted to not handle the error, is that this is the first exercise. But now we're about to add "hello world" as the first exercise, so that's not going to be a problem any more.
Thoughts?

Was this ever the first exercise? Thought that was Bob?
Is it a goal of Exercism to have a progression from easier to more challenging exercises? Or to at least have that for the first few exercises?
I like about the error case that it introduces another special case to be handled, perhaps making your beautiful solution less so. Just like the real world ;) But I can see that we should skip it if that helps with this progression.

This has been the first exercise for a while. It's simpler than Bob, because there's no state in Hamming.

Thanks @r11runner -- the Hello World exercise went live yesterday, so this is ready to go.

Thx, great :)

In my opinion, hamming has no meaning for strands of different lengths. So it depends on whether you see this as a standalone program which checks user input, or an internal method (which should be confident) which can just crash by assuming equal lengths. Personally I'm in favour of not checking, but I don't care too much either way.

I've gone back and forth, and have ended up leaning more towards the error checking (treating it like a stand-alone library). I think that a good argument can be made either way, and I like the slightly added complexity of having to think about the errors.

I think the most important risk is that people write 'insecure' code (as in opposite of what @avdi talks about in confident code). Since the examples never get large the difference between checking internally and externally isn't really visible. Maybe an exercise where this difference is clear is useful, but I wouldn't really know how to do that without making it large.

I wouldn't really know how to do that without making it large.

Same here.


TabBar Indicator animation dosen't match with TabBar

Current behaviour
After upgraded Expo version to 40, when I scrolling tabbar then indicator dosen't match with Tabbar and press tab indicator position is move wrong position.
It's ok not use scrollEnabled, but using
Expected behaviour

Scrolling Tabs, indicator also scroll too.
Press tab, indicator moving correct position

Code sample
import React, { useState } from "react";
import { SafeAreaView, View } from "react-native";
import { TabBar, TabView } from "react-native-tab-view";

export default function App() {
  const [index, setIndex] = useState(0);
  const [routes] = useState([
    { key: "popular", title: "TAB1" },
    { key: "bookmark", title: "TAB2" },
    { key: "end", title: "TAB3" },
    { key: "recent", title: "TAB4" },
    { key: "reward", title: "TAB5" },
  ]);

  const renderScene = () => (
    <View style={{ backgroundColor: `rgb(${Math.random()*255},${Math.random()*255},${Math.random()*255})`, width: "100%", height: "100%" }} />
  );

  return (
    <SafeAreaView style={{flex:1}}>
        <View style={{flex:1}}>
          <TabView
            navigationState={{ index, routes }}
            renderScene={renderScene}
            onIndexChange={setIndex}
            renderTabBar={(props) => <TabBar {...props} scrollEnabled/>}
            lazy
          />
        </View>
    </SafeAreaView>
  );
}

Screenshots (if applicable)

What have you tried
I think it's related with react-native-reanimated. because it was correct positioning before upgrade expo to v40
Your Environment

software
version

ios or android
ios

expo
40.0.0

react-native
0.63.2

react-native-tab-view
2.15.2

react-native-gesture-handler
1.8.0

react-native-reanimated
1.13.2

node
10.17.0

npm or yarn
yarn 1.22.5

there's still an issue

I have used  @react-navigation/material-top-tabs, so used tab view indirectly and faced an similar problem. But after upgrading tab view to v3, the problem disappeared.

I had same problem, finally fixed by adding tabStyle as prop ofTabBar, width should be the same your custom renderLabel (or/and TabBarItem if you have any) and that of the indicator (via indicatorStyle)
const renderTabBar = (props) => {
    return (
       <TabBar
          tabStyle={{width: 123} //<----This aligns indicator scroll position according to custom tab button width
          scrollEnabled={true}
          indicatorStyle={{width: 123} //<---same width as tab button
          {...props}
          renderLabel={({ route, focused, color }) => (
            <View style={{width: 123}> //<--also same width as tab button
              <Text
                {yourTabLabelHere}
              </Text>
            </View>
          )}
        />
    )
}


fix https://github.com/microsoft/vscode/issues/116094

This PR cherry-picks the fix for #116094 for the 1.53.x release

Thanks!


Allow running unit tests with podman

Which feature do you think can be improved?
make test
How can it be improved?
docker in unit tests is basically used to: pull an image, create, export and rm a container.
It should be possible to run unit tests using podman, if the Docker daemon is not installed / running.

ack @marcov - I think this has vaguely been thought about before, but nobody has had time to look into it.

Adding it is some trivial, just try to use podman if docker version returns an error. I'll have a look at this.


Bug: Wrong security scan count on security pagination

📜 Description
Wrong security scan count on security pagination
👟 Reproduction steps

Go to security tab and check security scan count. Actual security scans are different from the number shown on pagination.

👍 Expected behavior
There should correct counting of security scans.
👎 Actual Behavior
Count of security scans is not correct on pagination.
☸ Kubernetes version
EKS 1.25
Cloud provider

AWS

🌍 Browser
Chrome
🧱 Your Environment
No response
✅ Proposed Solution
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#3936


Multiple client IPs in X-Forwarded-For

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
It's possible that X-Forwarded-For contains multiple IPs when going through multiple proxies. This means this function could return something like: <IP_ADDRESS>, <IP_ADDRESS>. Looking at https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For it probably makes the most sense to select the left most IP (the first one). I spotted this as I was setting up https://hub.crowdsec.net/author/timokoessler/configurations/uptime-kuma-logs which fails to parse with the log like this. E.g.
2022-10-04T12:49:23.029Z [AUTH] WARN: Incorrect username or password for user asd. IP=<IP_ADDRESS>, <IP_ADDRESS>
I'm happy to raise a PR if this is something you agree is a bug.
👟 Reproduction steps
Using Cloudflare proxying with Traefik.
👀 Expected behavior
The returned client IP should be the correct IP address.
😓 Actual Behavior
A comma delimited list is returned instead.
🐻 Uptime-Kuma Version
1.18.2
💻 Operating System and Arch
Debian 11
🌐 Browser
Firefox
🐋 Docker Version
20.10.18
🟩 NodeJS Version
No response
📝 Relevant log output
No response

Yes, I think it is a bug, getClientIP() should return the first IP only (<IP_ADDRESS> in your example).


feat(ChatInputInteractionOptions): option types

Add the other option types, using .resolved

Gonna remake this PR, but much cleaner


Problem with TiSelectedCellBackgroundView and ARM64 architecture

Hi,
Thanks for your job @mpociot !
When i try to compile for 64bit devices i have an error :
Titanium SDK vers : 3.5.0.GA and Module version 2.0
"_OBJC_CLASS_$_TiSelectedCellBackgroundView", referenced from:
objc-class-ref in libde.marcelpociot.collectionview.a(DeMarcelpociotCollectionviewCollectionItem.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I tried to add "Ti.UI.createRefreshControl({});" but i have the same problem...
Ti.UI.createRefreshControl({});

I can't distribute my application ...
Thanks for your help.
François

It seems the problem only occurs on device. It works well in simulator.

Well it's hard for me to reproduce this issue.
I'm using my module in an iPad app, that is already used in production, without having this issue.
So my guess would be that it somehow relates to the UI that is used.
It would be great if someone could provide me with some code to reproduce the bug.

I have pushed the following test project (which is basically the test app using vers 1.2.0 of the module). It even fails on my simulator with Titanium 3.5.1.GA.
https://github.com/TheBrousse/collectiontester
Hope this helps

I dont know if this is a requirement. But Author i.e.  Marcel Pociot should register this module at Appcelerator Marketplace and obviously we'd like if its available for free. It is possible that at the end step of xcodebuild while packaging/publishing the app, its connecting to internet and validating each module's validity and in such case if module is not present, it may be throwing some error. its just a hunch but i'm not sure that registering this module at Appcelerator Marketplace would fix it, but since author is unable to reproduce the error, may be this would be a start.

Seems very old, please reopen if needed


Where is the action for 'Higher Jump'?

In many games, there are controls such as:
B: Jump
B (hold): Higher Jump
However, when looking at retro/cores/snes9x.json, there is no control for B (hold).
I tested this in a game by changing
"actions": [
[[], ["UP"], ["DOWN"]],
[[], ["LEFT"], ["RIGHT"]],
[[], ["A"], ["B"], ["X"], ["Y"], ["A", "B"], ["B", "Y"], ["Y", "X"], ["X", "A"], ["A", "B", "Y"], ["B", "Y", "X"], ["Y", "X", "A"], ["A", "B", "Y", "X"]],
[[], ["L"], ["R"], ["L", "R"]]
]
to
"actions": [
[[], ["B"]]
]
and sure enough, the agent doesn't ever High Jump. Is there a solution to work around this? The reason my agent gets stuck in a specific location is because he can't jump over it because he doesn't know how to.

"B (hold)" isn't a button. It's just keeping B as the action for enough frames in a row.

Ah, that makes sense, thanks!

@endrift Hi, as you say holding as the action for enough frames in a row. How can I make enough frames? With repeating B?


Feature request: Create release(s) and notes for informing user of changes made to the integration

Currently the integration is maintained by releasing a new version (hacs commit id upgrade) when an new change is merged to the master branch.
The last change that was merged (for #36) contained a breaking change that required users to re-add the integration after upgrading.
It would be nice for end-users if the release notes were to inform them of the required action to get the integration working after upgrade.
So that end-users won't have to search / open issues in order to get everything working again.
Furthermore, this would also allow end users to better determine whether to upgrade at that time and what new features they could try out

Completely understandable :) .
it's not the most fun thing to do (speaking from experience).

First release is a fact!


Fix tests

/cc @Rich-Harris

@eventualbuddha

Thanks for the prod @TrySound :grinning:

@Rich-Harris My pleasure. Don't forget to enable CI

It's enabled – one of the tests is failing though :frowning:

@Rich-Harris Give me access please. I'll try to fix.

@TrySound awesome, thanks – have added you to the team, you should have access to this repo and probably various others in the Rollup organisation. Shout if it didn't work

@Rich-Harris Thanks.


Add "node-eval" package to 'Miscellaneous' section

Please read and adhere to the contributing guidelines.


Pkgconfig -> pkg-config

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build

@GrahamcOfBorg build

Why does it complain about tangranm??
https://gist.github.com/GrahamcOfBorg/2f7d2ee6a76622b59c34a45dba757dd0

Why does it complain about tangranm??
https://gist.github.com/GrahamcOfBorg/2f7d2ee6a76622b59c34a45dba757dd0

Why does it complain about tangranm??
gist.github.com/GrahamcOfBorg/2f7d2ee6a76622b59c34a45dba757dd0

An old PR got merged. Fixing it right now.

Why does it complain about tangranm??
gist.github.com/GrahamcOfBorg/2f7d2ee6a76622b59c34a45dba757dd0

An old PR got merged. Fixing it right now.

@ofborg eval

@ofborg eval


Refactor Trainer & add development.md & update yaml.md

新增了二次开发的介绍 & 优化了yaml的文档

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: MrChengmo:x: rootroot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Backend: Add route for getting todos from db

The shell of this route is created but the rest of it needs to be set up.


raise exceptions from balancedconsumer threads

This pull request causes the BalancedConsumer's public API to raise any exceptions encountered during threaded execution. These exceptions can occur either on the zookeeper checker thread or during threaded execution of zookeeper watch callbacks. The logic used is identical to that of the SimpleConsumer, making the case that Simple and Balanced should share code somehow. I'm still considering whether a subclass, utility function, or mixin makes the most sense, but that doesn't have to block this PR. Thoughts welcome.

I think it would probably make things really tidy as a mixin, but I totally agree there's no need to do that right now - should we make a tag "refactoring" so that we can throw it on the issue tracker backlog for a quiet week?
This all looks good to me. I was going to just hit "merge" but will leave it to you just in case you wanted to refactor first after all.


Final paper edits

Final edits based on preview generated here: http://preview.biohackrxiv.org/papers/048b4ccc-375d-4fde-9a72-f127e5a25953/paper.pdf

Thanks @matuskalas
If you make those edits, I can create a final preview and then submit.

@paulzierep - what do you think about the toolshed reference?

I'm doing the needed edits in the .bib, which will be a separate, non-conflicting PR. So this one can in my opinion be merged.
The only question I have left here, and it is not important (It's more my own curiosity): Should the ToolShed article be cited (also) as usesDataFrom? Or do we in fact not use any data from it, only from the repos with wrappers?

The Tool Metadata Extractor does not use the ToolShed at all. As an explanation: currently it is not really useful for us since we cannot get the metadata we want via the API, that's why we scrape the wrapper code directly. So I think the current reference is fine.

Should we discuss the author's order?


What are Business Rules? It's not this.

https://www.youtube.com/watch?v=FbYcIqVmGRk

Trivial Validation

Business Rules

Summary

Trivial validation is concerned with getting your inputs into a valid state so you can ATTEMPT to perform a domain action that may or may not succeed based on some state.


Move batchSize to cli-level, create new overrideExecCmd argument on save-cli level

We need new modified logic to support it in SAVE-cloud:

We need to move batchSize option on save.properties level, because there is no need in that on plugin level (no need to overcomplicate it)
we need to introduce a new option overrideExecCmd specially for SAVE-cloud, as discussed with @nulls - it will be the only SAVE-cloud workaround in save-cli

as idea: introduce evaluated-tool.toml and move all properties are related to executing a tool to this file:

execCmd
execFlags
batchSeparator

This file should support groups [fix] and [warn] to customize execution run for different type of plugins
It allows to store such files in private repositories for test and provide them as external file for public tests


Added license information to classifiers in pyproject.toml

First PR in github, so please pardon me if I missed something.
This added the common license classifiers which should hopefully help with license detection by 3rd party tools.

Thanks! :)


Label has different vertical spacing in exported release vs in editor

Godot version
v4.0.beta11.mono.official [91713ced8]
System information
Windows 10, RX 6600, 10400
Issue description
Label has different unwanted vertical spacing when in a Exported Release.
Preview

Exported Release

Editor

Editor In-Game
Including some logs below in case it helps.
Export Logs

Exported Release Verbose Logs
verbose logs.txt
Additional Notes
This isn't specific to beta 11 this has been happening in previous versions as well. Beta 10 for sure.
Steps to reproduce

Clone https://github.com/Valks-Games/sankari
In case the project does not run in the future because perhaps I committed something that broke the game by accident, this is the commit that I tested this issue on
Export a release for windows
Run the game

Minimal reproduction project
I was not able to reproduce this issue in a blank Godot project.
Here is my project that I tested this issue on, sankari.zip

Still happening in beta 17

Still happening in RC3

Can you still reproduce this in 4.0.3-stable and 4.1-beta3 or later?

Issue reproduced on v4.1.beta3.mono.official [ada712e06]

I tested the project but couldn't get it to compile in 4.1-beta3, with either the zipped version from Jan 12 or the current Git main.
But the project is huge, so it's really not practical for debugging. To be able to properly debug the issue and see why this difference happens, we'd really need a proper minimal reproduction project. You could attempt to extract the specific scene / overlay and theme where the issue can be seen, with only the minimal dependencies to make it run.

I can't commit to something like that right now. I've never come across this issue in any of my other projects so I wouldn't mind if this issue was closed.

I'd keep it open since you can reproduce it still, even if we don't know exactly how.

Possibly the same issue as #74351

Possibly the same issue as #74351

Note that additional MRPs can be found in that issue.

This started happening to me after pulling my project from github. I think it has to do with the "core.autocrlf" setting. From what I've read it should be set to false by default, but it was set to true in my config file despite not touching it.
I fixed this issue for my project by changing the setting to "input", nuking my local files (Commit important changes first!) then doing a hard reset.
For some reason, just doing the reset without deleting all the files doesn't work.
I'm not sure if this is the intended behavior for CRLF, with CR behaving like a new-line.

Issue can be reproduced by using Stringbuilder.AppendLine() when setting label.Text in C#.
This causes two new lines to appear instead of one in exported builds (Win64).
Reproduced on Godot 4.2.1
My easy workaround is just using Append("myText\n");

Issue can be reproduced by using Stringbuilder.AppendLine() when setting label.Text in C#.
This causes two new lines to appear instead of one in exported builds (Win64).
Reproduced on Godot 4.2.1
My easy workaround is just using Append("myText\n");

In my case, I only got the issue when I’m setting %SomeRichTextLabel.text = a_variable_with_line_breaks_in_it. In that specific case, I get normal spacing in the editor, and large spacing (2 or even 3 × bigger than normal) in all exported builds (Web, Linux, Windows, MacOS).
When the text of a RichTextLabel was set directly in the inspector, then the spacing is normal and consistent between the editor and the exports.
The labels all have BBCode enabled.

The workaround I've come to is by appending my string with just a "\r" rather than System.Environment.NewLine, "\r\n", or "\n" (Windows 11 64bit, 4.2.1 mono). Works in both editor and exported project. However I'm not sure if that's a portable solution and I can't test it on Linux/MacOS for now.


[Ubuntu] Remove apt-key from GCP installer

Description
apt-key is deprecated
Related issue: https://github.com/actions/virtual-environments-internal/issues/3808
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

.merge


Throw Exception in Android and IOS when the Permissions necessary are missing

It looks like that would be possible and helps new people to waste time.
It could be done where the instance is created.
related to #539

I'm only using this library on iOS at this moment. I think it would be better to have specific methods to check if permission is granted or not. At this moment the isOn method both checks the permission and if bluetooth is enabled or not. Which makes it impossible to differentiate & notify the user correctly.
Regarding the iOS permission, i'm also wondering if it's possible to not trigger it once the app starts up, but trigger it with a method, only when you want it to trigger.

There is actually a lib for that:
permission_handler: ^4.2.0+hotfix.3

@ride4sun permission_handler only works for non-Bluetooth permissions, see here: https://github.com/Baseflow/flutter-permission-handler/issues/177
Also note that Android 10 requires ACCESS_FINE_LOCATION instead of ACCESS_COARSE_LOCATION.
Regarding the Bluetooth permissions, I also think that delaying the initialization of BluetoothCoreManager so that it can be triggered at a well-defined point in the App workflow would make much more sense than permission request pop up uncommented at App start.

I noticed there's a PR for not requesting permissions until the app actually uses BLE: https://github.com/pauldemarco/flutter_blue/pull/599


[DRAFT] Converted project to typescript and added documentation for inputs.

Converted project to typescript. This will allow for the google closure compiler to be used on the project in the future to
increase the speed the code runs as.
Will be implementing some missing methods and adding documentation for others.
There are a couple of readme's with commented code that did not logically work. If you see them i would love some feedback on how they were intended to work to make sure i didn't miss anything.

Sorry, this project is not going to be typescript.
No cross-compilers.

What do you mean? The output will be js, so anyone using the library would be using it in the same way as you currently use it. No compilation is needed by the end user. Regardless, i can also export ES6 js files for your use, but i will only continue to contribute if i can use TS.

If you look at the examples, you can see the usage hasn't changed at all. The examples should still work with my proposed solutions.


Simple TypeScript API Review Feedback

Review Function Types exported by Common and remove if we don't need them anymore - I decided to remove them entirely, they aren't really necessary and create a false sense of equivalence between different events

IConnection.send should be string | ArrayBuffer - I also changed the onreceive event

Add IConnection.start overload

Add HubConnection.invoke<T>

Add HubConnection.stream that returns Observable<any>

Just add LogLevel.Debug and do a quick scan to change some Traces to Debugs - I changed most of the connection-level events from Trace to Debug. Message-level events stayed at Trace

Don't export ConsoleLogger (use LogLevel.[level] instead) or NullLogger - I left NullLogger but made it's constructor private and used a static instance field

Remove LoggerFactory and just inline logger creation

Rename Observable<T> and Observer<T> to Stream<T> and StreamSubscriber<T> and make them classes so people can attach things to the prototype (including a conversion to Rx Observable) - Not so sure about making these classes, it makes some of the code awkward. I did it and you can kinda see the awkwardness in the tests

Note Not merging until we release/2.1 re-opens. Will rebase when that happens.
Still some other API review items to come, details in #1963

As part of this double check and fix any of the JS samples that have broken. They definitely use the console logger.

btw signalR.TransportType needs to be renamed to signalR.HttpTransportType. I needed to fix that to get some of the sample apps working

:up: :date: samples updated

Any concerns @davidfowl ?

Talked to @davidfowl . We're going to go back to an interface for StreamResult and friends


Is llamaindex supports conversationBufferMemory?

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Is there any chat memory keeping functionality in llamaindex like that in langchain?
Eg:
from langchain.memory import ConversationBufferMemory

https://github.com/jerryjliu/llama_index/issues/1386

Our agents and chat engines have very basic chat history support (just an array of messages). You can manually manipulate this as needed.
We are pushing for more advanced stuff soon (I know I know, Jerry said the same thing in May, but for realsies this time)

Our agents and chat engines have very basic chat history support (just an array of messages). You can manually manipulate this as needed.
We are pushing for more advanced stuff soon (I know I know, Jerry said the same thing in May, but for realsies this time)

looking forward to it!

is the conversational memory implemented?

Is this implemented yet?

A basic chat buffer is implemented (and it's the default for all agents and chat engines)
https://github.com/jerryjliu/llama_index/blob/main/llama_index/memory/chat_memory_buffer.py


Python binding: Add doxygen documentation contents to python doc strings

(This is a suggestion, so I took the freedom to erase all the bug related template code.)
The code below was tested with binding version <IP_ADDRESS> and the source code example was from git HEAD.
Currently the doc string only contains a terse syntax description. E.g.
import cv2
print cv2.setUseOptimized.__doc__
setUseOptimized(onoff) -> None

But if you look at the h-file declaration for the corresponding function you have:
/** @brief Enables or disables the optimized code.

The function can be used to dynamically turn on and off optimized code (code that uses SSE2, AVX,
and other instructions on the platforms that support it). It sets a global flag that is further
checked by OpenCV functions. Since the flag is not checked in the inner OpenCV loops, it is only
safe to call the function on the very top level in your application where you can be sure that no
other OpenCV function is currently executed.

By default, the optimized code is enabled unless you disable it in CMake. The current status can be
retrieved using useOptimized.
@param onoff The boolean flag specifying whether the optimized code should be used (onoff=true)
or not (onoff=false).
 */
CV_EXPORTS_W void setUseOptimized(bool onoff);

I suggest to add to the python wrapper generator parsing of the entire doxygen string and conversion of its text to standard python strings. This will simplify interactive work as it will not be necessary to turn away from ipython (or any other doc sensitive IDE) in order to look up a description of what a function or method does.

Looks like a duplicate of #4286.


Parameter handler

See #880 #881

@tipsy @TobiasWalle awaiting Feedback.
Also documentation should be added after the review.

Thanks @28Smiles - It's a bit overwhelming to me that all of this is needed to extract some annotations. I will try to dig into it in the weekend.

For Kotlin it is not, but for java we are only able to extract the target method of a reference with the data provided by the serialized interface. The more -less large additions came from implementing interfaces for generic usage.

I was away from my computer all weekend, will try again next one!

Okay, I'll try to dig through this now. If we look back the issue was

While implementing an interface containing my own spec for a controller I encountered a problem. Up on casting the controller to its corresponding interface, the OpenAPI plugin is not able to pick up the annotation anymore.

So, your annotations were lost when casting. You fixed this in https://github.com/tipsy/javalin/pull/880, but this new PR also removes the special handling for CrudHandler (?).
I'll spend some time on it now, but this is hundreds of lines of code that modify code that I myself haven't written, so I'm not sure I'll be able to finish. My initial reaction is that this is A LOT of code 🤔

There appears to still be a dependency on the OpenApi plugin in CrudHandler.java (import static io.javalin.plugin.openapi.handler.ParameterHandlerHelpers.parameterHandler;)

Let me see if I can extract the OpenAPI stuff from CrudHandler.

It's tempting to just remove the resouceId from the CrudHandler 😬

I think the first thing we should do is make a PR which just untangles the OpenAPI plugin and the CrudHandler, then we should take it from there.

Okay, I'll try to dig through this now. If we look back the issue was

While implementing an interface containing my own spec for a controller I encountered a problem. Up on casting the controller to its corresponding interface, the OpenAPI plugin is not able to pick up the annotation anymore.

So, your annotations were lost when casting. You fixed this in #880, but this new PR also removes the special handling for CrudHandler (?).
I'll spend some time on it now, but this is hundreds of lines of code that modify code that I myself haven't written, so I'm not sure I'll be able to finish. My initial reaction is that this is A LOT of code 🤔

the large additions are souly from the java side of the api, since java lambda references are not reflectable by default.

I think the first thing we should do is make a PR which just untangles the OpenAPI plugin and the CrudHandler, then we should take it from there.

As you wish. I can try to further untangle the plugin from the core.

I just want to let you know that I am pretty busy this month, so unfortunately I won't have any time to review this PR.
But if you are still working on it in April, I am happy to help.


add dhtm

add Thuongmai University

@hoangminh99vp Please provide us with:

the school official website URL, if different from the domain you are submitting
an URL of a page on the official website where an IT-related long-term (>1 year) course is offered by the school
an URL of a page or another proof (.pdf or a screenshot are OK) showing that the school recognizes the domain which you are submitting as an official email domain for the students.

https://tmu.edu.vn/
https://vi.wikipedia.org/wiki/Trường_Đại_học_Thương_mại_(Việt_Nam)
[image: image.png]
On Tue, 9 Jun 2020 at 21:33, Philip Torchinsky<EMAIL_ADDRESS>wrote:

@hoangminh99vp https://github.com/hoangminh99vp Please provide us with:

the school official website URL, if different from the domain you
are submitting
an URL of a page on the official website where an IT-related
long-term (>1 year) course is offered by the school
an URL of a page or another proof (.pdf or a screenshot are OK)
showing that the school recognizes the domain which you are submitting as
an official email domain for the students.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/8423#issuecomment-641337257, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AK2IEKHNVETQ2MTDSICV7ULRVZB4BANCNFSM4NX5R3YQ
.

@hoangminh99vp I am sorry, could you please insert the image using GitHub web interface, otherwise it strips the image out of your comment?

@hoangminh99vp You might miss my previous comment. Please react.

@hoangminh99vp I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for the understanding!


Add audit log rate limit category and make rate limit category getter public

When calling https://api.github.com/rate_limit, the endpoint returns a audit_log rate limit category as well. This is used for /audit-log endpoints:

https://docs.github.com/en/enterprise-cloud@latest/rest/orgs/orgs?apiVersion=2022-11-28#get-the-audit-log-for-an-organization
https://docs.github.com/en/enterprise-cloud@latest/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/using-the-audit-log-api-for-your-enterprise#using-the-audit-log-api

This PR adds this new rate limit category.
I have a use case where I need to know the rate limit category before making the request so as to not reimplement what's already done in go-github, I made this logic public. Other users could also benefit of this change.
If you think it's not reasonable and it should be kept private, I will revert this change.

@gmlewis could you take a look at this when you have some time? 🙏 (I'm notifying you as you seem to review the recent PRs, sorry if you are not the correct person for that).
Let me know if I need to clarify some things.
Not sure as well why the codecov is failing here, I thought I added all the necessary tests related to my changes but maybe I missed some

Thank you, @rpelliard !
Merging.


POC Pipeline resource interface

why: Trying to unify different types of pipeline resource when processing input/ output resources.
what:

Resource interface defines list of container definitions to download
and list of container definitions to upload as well.
Removed git from build source and add the functionality similar to other resources.

Hopefully this should get us a step closer to having a better resource interface
cc @bobcatfish @pivotal-nader-ziada

cc @pivotal-nader-ziada @bobcatfish @tejal29

great improvement to the interface 👍
/lgtm


Update _bootstrap-colorpicker.twig

The following changes have been made

Updated to bolt3 html structure
Readded component feature as in old version

Tested with these options for the component version. The rest should work to but would need to know specific config to test.
        color:
            type: bootstrapcolorpicker
            class: 'colorpicker-component'
            label: Farbe
            inline: false
            hidden: false
            component: true

LGTM, Thanks! :+1:


Luckperms-bungee doesn't close threads properly

When moving players from one server to another Luckperms appears to be opening threads which are then not closed or not closed within a long time at least.
My test has been the following:

Open all servers and let players join the hub server.
Let players join the queue to the main server which starts sending them over as it is currently empty.
Using watch -n1 "ps huH p <pid of waterfall server> | wc -l" I can see the number of threads increase dramatically from the normal level of around 150 to several thousands.
With a very large amount of players it sometimes goes up to around 10 000 threads at which point the operating system will no longer allow any more threads to be opened and all applications crash.

When Luckperms is removed this no longer happens and the thread count stays at a normal level of about 100-200 threads at a time.
There is no such issue with the Bukkit versions.
The server is running Waterfall 282 and LuckPerms-bungee 4.4.17

Can you generate a java thread dump please. :)

Oh and it wasn't even just one plugin, apparently Plan has the same issue too.


SWEET Ontology Alignments

Idea
The Semantic Web for Earth and Environmental Terminology (SWEET) Ontology SWEET is a highly modular ontology suite with ~7000 concepts in 225 separate ontologies covering Earth system science. Under community development and governance at the ESIP Semantic Technologies Committee, there are a number of ongoing ontology alignment activities for which a significant degree of work has still to be done. To this end we are looking to engage in addressing both open issues as well as new ontology alignments with other Semantic Web resources in a bid to grow the usefulness of SWEET as a primary earth system science knowledge resource.
Skills Needed
XML, Turtle, Protege, Semantic Web
Mentors
Lewis John McGibbney, NASA JPL

I can't get good reading content on ontology alignment. Any other resources available?

Hi @malgamves thanks for your interest sorry about lack of response. In short, yes, please see the SWEET Alignment Manager. Also in terms of literature, you have a wealth of information available at the ontology matching workshop as well as Ontology Matching 2017 which is held every year beside the International Semantic Web Conference.

Thanks a ton! Looking forward to this actually.

Hi lewismc, I know I am late but if possible can you please clarify the problem statements?

I have downloaded SWEET ontology from this "link https://sweet.jpl.nasa.gov/download" and I am using version "SWEET 2.3". Am I looking into correct ontology?
Because in "SWEET Alignment Manager", under "alignments", there is entity "http://sweetontology.net/matrEquipment/Communication". Which I can not find in "SWEET 2.3", but I can find "http://sweet.jpl.nasa.gov/2.3/matrEquipment#Communication".

In "SWEET Alignment Manager", under "target" there are
datasetontology.ttl
instruments.ttl
platforms.ttl (this is missing in "alignments", I guess because it only contains labels)
prov-o.ttl
sciencekeywords.ttl
sosa.ttl

Are these the targets we have to deal with the scope of the project?

Under "alignments" in some targets, the output has similar properties(object property, data property) and in some has similar concepts(class). Are these both(property alignment and concept alignment) come under the scope of the project?

You mentioned about "AML", in the project proposal. Is it mandatory that our proposal has to be aligned with "AML" or we can propose any other idea based on some recent papers?

@malgamves are you still interested in this? The documentation above provides all of the prerequisite reading resources.

@jaydeepchakraborty

I have downloaded SWEET ontology from this "link https://sweet.jpl.nasa.gov/download" and I am using version "SWEET 2.3". Am I looking into correct ontology?

No, look at the above hyperlink for SWEET... it links to https://github.com/ESIPFed/sweet

Are these the targets we have to deal with the scope of the project?

Some of them yes... there are several other ones as well, which again are documented above at https://github.com/ESIPFed/sweet/issues

@lewismc , thank you for replying back.
I am writing a proposal for this project, is there any way I can share with you please?

Yes @jaydeepchakraborty  please share with me a GDoc hyperlink. Thanks

@lewismc  , I have one more question. Do you have any corpus of Earth and Environmental Terminology?

@jaydeepchakraborty can you elaborate?

Yes @lewismc I am still interested, I've added them to my reading list.. my proposal is in the works.

@lewismc  Sorry for the confusion. I was looking for a corpus(documents) which has information about the concepts, properties, and instances of SWEET ontology(at least used those concepts, properties, and instances in documents) and same for target ontologies.

@malgamves OK

@jaydeepchakraborty in all honesty no... the concepts, properties, and instances contained within the SWEET ontology suite are derived from across the while of Earth and environmental terminology.
As part of your proposal it would be nice for your select a number of alignment resources and then undertake the prerequisite literature review. This is the best information I can give you at this stage. There is no manual for this... we make it up as we go.

@lewismc I have an experience of working in the Ontology Development and Ontology Alignment. Looking forward to the discussion.

Thanks @Gautamshahi

Even if it's 'too late', here is information I thought worth including in the thread. There is a group, described below, that has been gathering information about reconciling parameter names, and has had quite a few webinars (recorded) of different teams presenting their own approaches to parameter names. I am watching the Pangaea presentation, it's quite interesting. These would form a great basis for investigating how and to what to map SWEET.
The Research Data Alliance (RDA, https://rd-alliance.org) Vocabulary and Semantic Services Interest Group (VSSIG, https://www.rd-alliance.org/groups/vocabulary-services-interest-group.html) has a working group called Harmonizing Measurement Parameters. These working groups don't necessarily have home pages, but you can see more in column AB of https://docs.google.com/spreadsheets/d/1gQ5FK7LXmdE5VdXMnDBP8uSJ3Ca-B5MqArro1yWI7K8/edit#gid=0), and see more about how to sign up at the Document Overview at
https://docs.google.com/spreadsheets/d/1gQ5FK7LXmdE5VdXMnDBP8uSJ3Ca-B5MqArro1yWI7K8/edit#gid=837330156.


Please develop jWeek parameter in startOf()

Please develop jWeek parameter in startOf() and endOf()
Thanks

hi,
Thank you
Its available now in version 3.0.8.
you could also use week instead of jweek as the following code
m = moment("2017-12-14 07:10:20")
m.locale('fa').startOf('week');


SelectionArea does not vibrate on Android

When I select text on my Android, for every single character my phone vibrates. I tried to show it my video. If you make the sounds really loud, you can hear the vibrations a bit.
https://user-images.githubusercontent.com/24459435/170141105-11719308-51fa-4c91-aa2d-5977852ec803.MOV
I would expect the behavior for the SelectionArea in my Flutter App.
I used Pixel 4a with Android 12.
I also tried it on my iPhone 13 but there are no vibration when selecting text in a native iOS (but I'm also not 100% sure if I maybe disabled it - if it's possible)

My app
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// This example shows how to make a screen selectable..

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      // You need to add the "SelectionArea" to make the text selectable.
      home: SelectionArea(
        child: Scaffold(
          body: Padding(
            padding: const EdgeInsets.all(16),
            child: Center(
              child: Column(
                mainAxisSize: MainAxisSize.min,
                children: <Widget>[
                  Text(
                    'Fast',
                    style: Theme.of(context).textTheme.titleLarge,
                  ),
                  const Text(
                    'Flutter code compiles to ARM or Intel machine code as well as JavaScript, for fast performance on any device.',
                  ),
                  ElevatedButton(
                    onPressed: () {},
                    child: const Text('Try it in DartPad'),
                  )
                ],
              ),
            ),
          ),
        ),
      ),
    );
  }
}

cc: @chunhtai

there is also a magnify glass when you select text in Android as well. Yes this is also in my radar.
cc @justinmc this may also apply to text field and the magnify glass project

there is also a magnify glass when you select text in Android as well.

Indeed. Didn't notice it 😅  I will create a separate issue to track this better 👍

there is also a magnify glass when you select text in Android as well. Yes this is also in my radar.
cc @justinmc this may also apply to text field and the magnify glass project

@justinmc Do you know if there are already open tickets for these two behaviors? We need one ticket for the magnifying glass and one for the vibrations when selecting. I tested it and the TextField does not have both. If there are no tickets, let me know - I can then create two tickets.

For the magnifying glass I found the ticket https://github.com/flutter/flutter/issues/17617 👍

I am able to reproduce this on the current version of master. Along with that, selection on Android is very buggy as seen in the video below.
Note: this was tested using a production build (flutter build web) of the sample code
and served locally using python3 -m http.server --directory build/web.
Video showing buggy selection
https://user-images.githubusercontent.com/50555895/170282071-cbcde796-cfab-4c88-8f49-2a75ec01619f.mp4

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      title: 'Multiline text copy demo',
      home: HomePage(),
    );
  }
}

class HomePage extends StatelessWidget {
  const HomePage({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Multiline text copy demo')),
      body: SelectionArea(
        child: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: [
              Text(
                'This is a title',
                style: Theme.of(context).textTheme.headline6,
              ),
              const SizedBox(height: 20),
              const Text(
                'Lorem ipsum dolor sit amet, consectetur adipiscing elit. '
                'Fusce gravida sollicitudin.',
              ),
            ],
          ),
        ),
      ),
    );
  }
}

flutter doctor -v (Master)
[✓] Flutter (Channel master, 3.1.0-0.0.pre.897, on macOS 12.4 21F79 darwin-arm, locale en-US)
    • Flutter version 3.1.0-0.0.pre.897 at /Users/nabeelparkar/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 680a8192b0 (2 hours ago), 2022-05-24 21:23:09 -0700
    • Engine revision 7274f79325
    • Dart version 2.18.0 (build 2.18.0-149.0.dev)
    • DevTools version 2.13.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/nabeelparkar/Library/Android/sdk/
    • Platform android-32, build-tools 32.1.0-rc1
    • ANDROID_SDK_ROOT = /Users/nabeelparkar/Library/Android/sdk/
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Brave Browser.app/Contents/MacOS/Brave Browser

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Ultimate Edition (version 2022.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 67.1.4
    • Dart plugin version 221.5591.58

[✓] VS Code (version 1.67.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (3 available)
    • iPhone 13 Pro Max (mobile) • 16B8F156-111C-489F-A6E5-2D79142036B4 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-5 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)               • chrome                               • web-javascript • Brave Browser <IP_ADDRESS>

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

FYI https://github.com/flutter/flutter/issues/104603 and https://github.com/flutter/flutter/issues/104620 @nilsreichardt

@nilsreichardt There's also another magnifying glass issue for iOS: https://github.com/flutter/flutter/issues/9507.
I'm not aware of any issues about the vibration thing.


Add bolide-pancake-blid-usdt to bsc_pools

bolide-pancake-blid-usdt
Vault: 0x0bF3CEf168Ed6B2A43d18ee66DE3ae3a401C00CB
Strategy: 0x9106fdC580c57874A977Dc3d38C0b25A0D134b7A
Want: 0x12C35ed2405bc70721584594723351bf5Db6235C

there are some validation problems that are existed before my changes

do I have to do any else to pass this merge?

nice try. this is old v1 app, new vaults accepted in v2 repo.
before accepting you need to

provide due diligence report and validate it in our discord with @Strategist.
like this https://docs.google.com/document/d/19sP4tsS2N7fASXkfbbqdS589iJ_eu8Egg8pBdKm2rrQ/edit
can find more examples in api repo:
https://github.com/beefyfinance/beefy-api/pull/675
next you need to build APY data in beefy-api

after 1) and 2) you can send vaults to beefy-v2


Allow multiple auth

Uses reset token in cache key (access token). This allows to work with multiple oAuth connections.

Hi, you can pass a refresh token to the client, your application should be responsible for passing this instead I think.
Orders(refresh_token=....).get_orders()

Hi, you can pass a refresh token to the client, your application should be responsible for passing this instead I think.
Orders(refresh_token=....).get_orders()

Hi, you can pass a refresh token to the client, your application should be responsible for passing this instead I think.
Orders(refresh_token=....).get_orders()

yes, but not Access token. It overwrite accecss token cached when ttl expired. And withuot this PR it always used "access token" key name. So when working with multiple refresh tokens, all of them uses single access token.

Hi, you can pass a refresh token to the client, your application should be responsible for passing this instead I think.
Orders(refresh_token=....).get_orders()

yes, but not Access token. It overwrite accecss token cached when ttl expired. And withuot this PR it always used "access token" key name. So when working with multiple refresh tokens, all of them uses single access token.

Yes, I've seen it after I commented... Sorry for that, it is now merged - thanks a lot!

Yes, I've seen it after I commented... Sorry for that, it is now merged - thanks a lot!


Ubuntu 16.04.1 LTS not recognized by install script

Issue Description
If the current version of Linux is one of these flavors but it is
not recognized, please open a support ticket and include the version.
Reproduction Steps

Start King Phisher install script
sudo tools/install.sh
Failed to detect the version of Linux

Environment Details
cat /etc/*-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.1 LTS"
NAME="Ubuntu"
VERSION="16.04.1 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.1 LTS"
VERSION_ID="16.04"

It's actually determined based on the contents of /etc/issue. Could you please post the contents of that file as well?

well damn vmware's fault, will try a normal install and report back
cat /etc/issue

VMware Easy Install
PLEASE WAIT! VMware Tools is currently being
installed on your system. Depending on the
version of Ubuntu you are installing, you may
log in below and use the system during the
installation. Otherwise, please wait for the
graphical environment to launch. Thank you.

@xillwillx have you successfully gotten King Phisher to install?

sorry for the delay , was able to successfully install on ubuntu and ubuntu server vm's. after configuring ubuntu vm in vmware, would need to remove the easy install iso before powering up the vm for the first time. not sure why it overwrites etc/issue

Good to know that vmware quick install overwrites etc/issues, and can be correct by removing the easy install iso before powering up the vm for the first time.


Allow kubevirt:edit role to get,list kubevirts

Kubevirt resource is in category all.
kubectl get all fails if the user don't have the permissions to list Kubevirt resource.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4888
Special notes for your reviewer:
Release note:
NONE

Looks good to me in general. Is there a chance we can verify this with a unit test?

I don't see any unit tests in this area. Do you suggest creating them?

/approve

Looks good to me in general. Is there a chance we can verify this with a unit test?

I don't see any unit tests in this area. Do you suggest creating them?

Yes, if that is worthwhile. And IMHO it always is, as the turnaround on refactoring and changes is much faster. But I leave that to your judgement if it makes sense or not.

Looks good to me in general. Is there a chance we can verify this with a unit test?

I don't see any unit tests in this area. Do you suggest creating them?

Yes, if that is worthwhile. And IMHO it always is, as the turnaround on refactoring and changes is much faster. But I leave that to your judgement if it makes sense or not.

While I agree with you, I don't think it applies to this part of the code. I can later add a functional test that verifies that the user associated with this role will be able to perform/or not the actions we expect.

I would also like to see some kind of a test, but I don't want to delay this fix.

@xpivarc OK then, please create an issue so we don't lose track of the work to be done, thanks!
/lgtm


FW-1512

Two components are in a single file but only one of them was Redux connected.
Error triggered when filtering by shared resources where a nonexistent this.props.intl is called

Thanks @gmcauliffe!


Is it expected that Larastan requires a .env file and a database?

Larastan Version: 2.2.0
--level used: max

Description
I've recently setup GitHub Actions to run my existing PHPStan config which includes Larastan in order to check a Laravel application.
Whilst doing this I found that I require .env to exist (so I run cp .env.example .env) and a database connection (but it can be an empty database).
Is this expected? I didn't have to do this for Rector which also makes use of PHPStan. I have my CI passing but having to create an empty database just for Larastan seems unnecessary.
This is the only related issue I found: https://github.com/nunomaduro/larastan/issues/656
These are the 2 errors that are thrown:
// When .env does not exist
Dotenv\Exception\InvalidPathException thrown in C:\vendor\vlucas\phpdotenv\src\Store\FileStore.php on line 68 while loading bootstrap file C:\vendor\nunomaduro\larastan\bootstrap.php: Unable to read any of the environment file(s) at [C:\.env].

// When the database does not exist
Doctrine\DBAL\Driver\PDO\Exception thrown in C:\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDO\Exception.php on line 18 while loading bootstrap file C:\vendor\nunomaduro\larastan\bootstrap.php: SQLSTATE[HY000] [1049] Unknown database 'forge'

Hello Jonathan! 👋🏻
Thank you for your report.
Larastan still boots up the framework.
https://github.com/nunomaduro/larastan/blob/82d98695c097086717205f19f08e38b8b0542a63/src/ApplicationResolver.php#L37
Could you temporary deactivate your service providers?

You can take a look at the stack trace with --debug

Thank you @szepeviktor - found the culprit. A Schema::hasTable call in AppServiceProvider.php. I can change this to check ! $this->app->runningInConsole().
Also, the only variable that needs to be defined in the .env file is APP_KEY, which makes sense.

APP_KEY

it is needed for cryptography

You can avoid creating .env
APP_KEY="blablabla..." vendor/bin/phpstan


encrypted keyring

From @arnottcr on February 5, 2015 8:12
like the title says, give the user the option to encrypt symmetric keys and private keys so that a password is required for access
Copied from original issue: winhowes/grd.me#21

From @winhowes on February 13, 2015 6:30
How long would access be granted? Per-open popup, Per-browsing session (not sure how that would work off-hand, but I could figure it out), Till they click "log out" (or some derivation)?

From @winhowes on February 13, 2015 6:30
How long would access be granted? Per-open popup, Per-browsing session (not sure how that would work off-hand, but I could figure it out), Till they click "log out" (or some derivation)?

I would say that it should definitely be an option, disabled by default as with textsecure. Most gpg implementations allow a user set timeout. But allowing per browser sessions would also be useful.

From @winhowes on March 13, 2015 0:29
A problem with this is that the user's password is stored in memory, and if they do some sort of unexpected behavior, there may be a chance that the password could be cleared from memory and it wouldn't be able to encrypt (nothing confirmed here, just speculation). How I've done the basic implementation is you click "Encrypt Keychain" when you want to encrypt, and you enter a password then (allows for changing passwords - otherwise we'll have to build that in) and then whenever you want to decrypt, there's a box for you to enter that password in. Idk what do you think about that approach?

From @winhowes on March 13, 2015 0:29
A problem with this is that the user's password is stored in memory, and if they do some sort of unexpected behavior, there may be a chance that the password could be cleared from memory and it wouldn't be able to encrypt (nothing confirmed here, just speculation). How I've done the basic implementation is you click "Encrypt Keychain" when you want to encrypt, and you enter a password then (allows for changing passwords - otherwise we'll have to build that in) and then whenever you want to decrypt, there's a box for you to enter that password in. Idk what do you think about that approach?

I would say that it should definitely be an option, disabled by default as with textsecure. Most gpg implementations allow a user set timeout. But allowing per browser sessions would also be useful.

I have two thoughts, I think I prefer the first:

use a key-encryption-key model
_a) startup
__1) generate encryption keyfile
__2) encrypt grd.me default key with keyfile
__2.5) [prompt user to generate new message encryption key, then encrypt with keyfile]
__3) prompt user to either set password or skip [no password]
___a) encrypt keyfile with password [use kdf], prepend with 1 bit, for encrypted
___b) prepend keyfile with 0 bit, for decrypted
__4) write modified keyfile to disk
__5) flush original keyfile from memory
_b) upon new keyshare, new key generation, message encryption or decryption
__1) fetch keyfile from disk
__2) check first bit
__3) if necessary, prompt for password and decrypt
__4) either:
___a) decrypt pertinent key for message decryption or encryption
___b) encrypt new key with keyfile and save new encrypted key to database
__5) flush keyfile from memory
_c) upon password change
__1) with old password
___a) have user enter old password and new password twice
___b) decrypt keyfile on disk
___c) re-encrypt keyfile with new password, save to disk
__2) without old password
[this will be an expensive operation for large databases, and while we could use the same keyfile instead of generating a new one, it seems like a bad idea to assume that you can securely delete a key that was written to disk; at the same time, this should not be a frequent operation]
___a) generate new keyfile
___b) prompt user for new password
___c) encrypt keyfile with password [use kdf], prepend with 1 bit, for encrypted
[we need some way to recover from this operation being interrupted, I think have both keys in database till encryption is done is best, and we will need to keep track of what has been processed and not]
___d) read old keyfile into memory
___e) re-encrypt database with new keyfile
only encrypt on request
_a) startup
__1) prompt user to set password
___a) if no password [skip]
____1) write 0 bit somewhere to indicate unencrypted
___b) if password
____1) generate keyfile and encrypt with password [use kdf], write to disk
____2) write a 1 bit somewhere to indicate encrypted keyring
____2.5) [prompt user to generate new message encryption key, then encrypt with keyfile]
____3) write encrypted keyfile to disk
____4) flush decrypted keyfile from memory
_b) if not encrypted
__1) upon password change
___a) generate new keyfile
___b) prompt user for new password
___c) encrypt keyfile with password [use kdf], write the 1 bit somewhere, for encrypted
[we need some way to recover from this operation being interrupted, and we will need to keep track of what has been processed and not]
___e) encrypt database with new keyfile
_c) if encrypted
__1) upon new keyshare, new key generation, message encryption or decryption
___a) fetch keyfile from disk
___b) prompt for password and decrypt
___c) either:
____1) decrypt pertinent key for message decryption or encryption
____2) encrypt new key with keyfile and save new encrypted key to database
___d) flush decrypted keyfile from memory
__2) upon password change
___a) with old password
____1) have user enter old password and new password twice
____2) decrypt keyfile on disk
____3) re-encrypt keyfile with new password, save to disk

I have two thoughts, I think I prefer the first:

use a key-encryption-key model
_a) startup
__1) generate encryption keyfile
__2) encrypt grd.me default key with keyfile
__2.5) [prompt user to generate new message encryption key, then encrypt with keyfile]
__3) prompt user to either set password or skip [no password]
___a) encrypt keyfile with password [use kdf], prepend with 1 bit, for encrypted
___b) prepend keyfile with 0 bit, for decrypted
__4) write modified keyfile to disk
__5) flush original keyfile from memory
_b) upon new keyshare, new key generation, message encryption or decryption
__1) fetch keyfile from disk
__2) check first bit
__3) if necessary, prompt for password and decrypt
__4) either:
___a) decrypt pertinent key for message decryption or encryption
___b) encrypt new key with keyfile and save new encrypted key to database
__5) flush keyfile from memory
_c) upon password change
__1) with old password
___a) have user enter old password and new password twice
___b) decrypt keyfile on disk
___c) re-encrypt keyfile with new password, save to disk
__2) without old password
[this will be an expensive operation for large databases, and while we could use the same keyfile instead of generating a new one, it seems like a bad idea to assume that you can securely delete a key that was written to disk; at the same time, this should not be a frequent operation]
___a) generate new keyfile
___b) prompt user for new password
___c) encrypt keyfile with password [use kdf], prepend with 1 bit, for encrypted
[we need some way to recover from this operation being interrupted, I think have both keys in database till encryption is done is best, and we will need to keep track of what has been processed and not]
___d) read old keyfile into memory
___e) re-encrypt database with new keyfile
only encrypt on request
_a) startup
__1) prompt user to set password
___a) if no password [skip]
____1) write 0 bit somewhere to indicate unencrypted
___b) if password
____1) generate keyfile and encrypt with password [use kdf], write to disk
____2) write a 1 bit somewhere to indicate encrypted keyring
____2.5) [prompt user to generate new message encryption key, then encrypt with keyfile]
____3) write encrypted keyfile to disk
____4) flush decrypted keyfile from memory
_b) if not encrypted
__1) upon password change
___a) generate new keyfile
___b) prompt user for new password
___c) encrypt keyfile with password [use kdf], write the 1 bit somewhere, for encrypted
[we need some way to recover from this operation being interrupted, and we will need to keep track of what has been processed and not]
___e) encrypt database with new keyfile
_c) if encrypted
__1) upon new keyshare, new key generation, message encryption or decryption
___a) fetch keyfile from disk
___b) prompt for password and decrypt
___c) either:
____1) decrypt pertinent key for message decryption or encryption
____2) encrypt new key with keyfile and save new encrypted key to database
___d) flush decrypted keyfile from memory
__2) upon password change
___a) with old password
____1) have user enter old password and new password twice
____2) decrypt keyfile on disk
____3) re-encrypt keyfile with new password, save to disk

From @winhowes on March 14, 2015 6:59
Okay, so a few questions/thoughts:

I don't store their password anywhere, so what is the point of asking them to change their password for when they go to encrypt their keychain I must ask for their password then anyways?  Or are you suggesting I store their password in memory somewhere?
All those disk read/writes sound expensive. What do you think of my approach below/what are the direct improvements that can happen on top of it?
Regarding interrupts - Firefox guarantees "atomic" operations for all of this, so we don't really have to worry about them.
I've stored the "flag" bit separately rather than prepending because
a. I can fetch that separately rather than fetch the entire encrypted keychain and check
b. It's just easier through Firefox's and Chrome's sdk
I'm not following 1.c.2 - if we're encrypting the old keyfile under a new key without decrypting the old keyfile won't that just mess the user up (require them to decrypt with multiple passwords sequentially) or is the old key file stored unencrypted on disk (in which case it seems the same as my current approach below)

My current approach:

startup (installation)
_a) Do nothing - the default key is unencrypted and stored that way.
If not encrypted (flag is currently set to 0)
_a) They take no action
__1) store flag of 0 indicating it is not encrypted
_b) They click "Encrypt Keychain"
__1) Prompt for password
__2) Encrypt with password (AES-256 using kdf)
__3) Write encrypted file to disk
__4) Flush unencrypted keychain from memory
__5) Flush password from memory
__6) Store a flag of 1 indicating that it is encrypted
If encrypted (flag is currently set to 1)
_a) They take no action
__1) Keychain remains encrypted
__2) Messages cannot be decrypted (password to decrypt keychain is unknown)
__3) Grd Me keyboard shortcuts don't do anything (they can't encrypt)
__4) They are unable to search key server through Grd Me extension
__5) They are unable to add new keys to keychain
__6) Flag remains set to 1
_b) They follow prompt to decrypt keychain
__1) They enter password
__2) Attempt keychain decryption
___a) Failure
____1) Prompt for decryption password
___b) Success
____1) Decrypted keychain written to disk and memory
____2) Encrypted keychain flushed from disk and memory (this operation is atomic with the above)
____3) All features re-enabled
____4) Set flag to 0 indicating keychain is unencrypted

Once they've decrypted the keychain they have to re-encrypt it. To me this model seems to represent the behavior of logging in/logging out except that both actions require a password. A benefit of this is that they can switch their password as much as they like just through this log in/log out process. A downside is that I currently don't require them to confirm their password. Thoughts on this:

It is a hassle for the user to write their password twice every time they would like "log out".
There is room for typos and thus losing their keychain
A possible solution: Store the hash of their most recent password and if the password they enter does not match the hash I ask them to confirm their password. That keeps things hassle-ish free when they're logging out, yet reduces chances of typos causing loss of keychain

what do you think about the note on 1.c.2)? I think that it is a bad idea to reuse a key that has been written unencrypted to disk, SSDs and all, but that is the one major advantage of 1), if you always have the data encrypted, then you never need to worry about a costly encryption round, also password changes are trivial, no re-encryption necessary

what do you think about the note on 1.c.2)? I think that it is a bad idea to reuse a key that has been written unencrypted to disk, SSDs and all, but that is the one major advantage of 1), if you always have the data encrypted, then you never need to worry about a costly encryption round, also password changes are trivial, no re-encryption necessary

From @winhowes on March 14, 2015 6:59
Okay, so a few questions/thoughts:

I don't store their password anywhere, so what is the point of asking them to change their password for when they go to encrypt their keychain I must ask for their password then anyways?  Or are you suggesting I store their password in memory somewhere?
All those disk read/writes sound expensive. What do you think of my approach below/what are the direct improvements that can happen on top of it?
Regarding interrupts - Firefox guarantees "atomic" operations for all of this, so we don't really have to worry about them.
I've stored the "flag" bit separately rather than prepending because
a. I can fetch that separately rather than fetch the entire encrypted keychain and check
b. It's just easier through Firefox's and Chrome's sdk
I'm not following 1.c.2 - if we're encrypting the old keyfile under a new key without decrypting the old keyfile won't that just mess the user up (require them to decrypt with multiple passwords sequentially) or is the old key file stored unencrypted on disk (in which case it seems the same as my current approach below)

My current approach:

startup (installation)
_a) Do nothing - the default key is unencrypted and stored that way.
If not encrypted (flag is currently set to 0)
_a) They take no action
__1) store flag of 0 indicating it is not encrypted
_b) They click "Encrypt Keychain"
__1) Prompt for password
__2) Encrypt with password (AES-256 using kdf)
__3) Write encrypted file to disk
__4) Flush unencrypted keychain from memory
__5) Flush password from memory
__6) Store a flag of 1 indicating that it is encrypted
If encrypted (flag is currently set to 1)
_a) They take no action
__1) Keychain remains encrypted
__2) Messages cannot be decrypted (password to decrypt keychain is unknown)
__3) Grd Me keyboard shortcuts don't do anything (they can't encrypt)
__4) They are unable to search key server through Grd Me extension
__5) They are unable to add new keys to keychain
__6) Flag remains set to 1
_b) They follow prompt to decrypt keychain
__1) They enter password
__2) Attempt keychain decryption
___a) Failure
____1) Prompt for decryption password
___b) Success
____1) Decrypted keychain written to disk and memory
____2) Encrypted keychain flushed from disk and memory (this operation is atomic with the above)
____3) All features re-enabled
____4) Set flag to 0 indicating keychain is unencrypted

Once they've decrypted the keychain they have to re-encrypt it. To me this model seems to represent the behavior of logging in/logging out except that both actions require a password. A benefit of this is that they can switch their password as much as they like just through this log in/log out process. A downside is that I currently don't require them to confirm their password. Thoughts on this:

It is a hassle for the user to write their password twice every time they would like "log out".
There is room for typos and thus losing their keychain
A possible solution: Store the hash of their most recent password and if the password they enter does not match the hash I ask them to confirm their password. That keeps things hassle-ish free when they're logging out, yet reduces chances of typos causing loss of keychain

From @winhowes on March 14, 2015 8:53
I've implemented my possible solution for password confirmation described in my earlier message ^

From @winhowes on March 14, 2015 8:53
I've implemented my possible solution for password confirmation described in my earlier message ^

From @winhowes on March 16, 2015 4:1
Added the chrome only tag, as this seems implemented in FF, until I hear otherwise?

From @winhowes on March 16, 2015 4:1
Added the chrome only tag, as this seems implemented in FF, until I hear otherwise?

From @winhowes on March 16, 2015 6:54
I'm gonna go ahead and close this one as the implementation exists. Feel free to reopen if we need to change the implementation.

From @winhowes on March 16, 2015 6:54
I'm gonna go ahead and close this one as the implementation exists. Feel free to reopen if we need to change the implementation.


add an option to allow base58 in keytool show

Description
Add an option --base58-no-key-scheme-flag to print the base58 encoded pub key.
Test Plan
tested locally

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

I feel a bit hesitant (security-wise) to approve base58 of private key material for two reasons: a) our base58 implementation might not be constant_time (while our base64 library was specifically chosen to be). This is one of the main reasons the industry prefers base64 for key material (ie the whole TLS space with certs etc). b) base58 is expensive in large inputs, if this will work for multi-sig too, then it might take a while.
What is the main reason we need to also print in base58?

tagged you offline

We converted display of key material to base64 so we can close this


Create 2024-11-03-linux-load-average-myths-and-realities.md

This blog needs to somehow be linked to the site. I don't know how to do this.
@Ancairon can you help?
Then we can merge it.

@ktsaou what do you mean by "linked"? I don't own the website, I think @netdata/product @kapantzak and @Aliki92 work on that


Icon size and loading animation changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Scrape only 1st page

Hi, is it possible to scrape more than 20 products?
I suppose that right now the code can scrape only the 1st page of the search, right?

The part_search method takes a keyword argument limit, if you wish to scrape more than the first page just set the limit to >20 (there are 20 parts on each search page). The library will handle it for you.


Add new date format, url encode document id

I add a pair of date formats to the date parsing.
When editing an object, url encode the object id, which helps if your object id contains url special characters.

@davidlandry93 looks good to me 👍
Thanks for the contribution.


Unable to clear country value

A recent change in the Combobox Strapi design system makes it so that the clear callback needs to be defined, else the clear icon doesn't show up and it's impossible to unset the value of the field.
I fixed the issue by adding this function inside the CountrySelect component:
(...)
const isValidValue = !value || parsedOptions.hasOwnProperty(value);

const handleClear = () => {
  onChange({
    target: {
      name: name,
      value: '',
      type: attribute.type,
    },
  });
};
(...)

...and by linking it to the Combobox component clear attribute:
(...)
<Combobox
    placeholder={placeholder && formatMessage(placeholder)}
    aria-label={formatMessage(intlLabel)}
    aria-disabled={disabled}
    disabled={disabled}
    value={isValidValue ? value : null}
    onChange={countryCode => onChange({ target: { name, value: countryCode, type: attribute.type }})}
    onClear={handleClear}
>
(...)

@ChrisEbert could you check this?
@julesrenaud Did you fix this?

Fixed with v1.0.3


created get routes for /users and /favorites

You can now use insomnia to do a get request for "localhost:3001/api/users" and "localhost:3001/api/favorites" and get a list of those two tables.

Looks great!


Association inheritance

If you add the association feature, we can expect to manage inheritance between associations. ..like in UML.

@erikgollot Please elaborate. Code suggestions would be perfect. Thanks!

More insight...
                                      MyAssociation
        ClassA 1,1 myRoleA---------------------myRoleB 0,* ClassB
		                                    |
ClassAChild1     ClassAChild2      |            ClassBChild1      ClassBChild2
     |                                                   |                  |
     --------------------------------------------------
	                     MyAssociationChild

MyAssociationChild inherits from MyAssociation, meaning that into the myRoleB of a ClassAChild, you can only put ClassBChild objects.
You can expect to have the following code
class ClassAChild1{

@Association(name="MyAssociationChild", lower=1,upper=1,parent="MyAssociation")
public Collection<ClassBChild1> myRoleB;

}

class ClassBChild1 {

@Association(name="MyAssociationChild", lower=1,upper=1,parent="MyAssociation")
public ClassAChild1 myRoleA;

}

**or**

class ClassAChild1 {

@Association(name="MyAssociation", role.my.lower=0,role.my.upper=-1,role.other.lower=1,role.other.upper=1,other=ClassBChild1.myRoleA,parent="MyAssociation")
public Collection<ClassBChild1> myRoleB;

}

class ClassBChild1 {

public ClassAChild1 myRoleA;

}

Hope it's more clear  ?

@erikgollot
What sort of constraints and/or functionality would that introduce? I do not understand the outcome.
Can you please rewrite the code snippets to a real world abstraction like books or cars? I think it is quite hard to grasp a new concept which you apparently are trying to explain when the names are meaningless like ClassAChild1.

This issue is linked to issue 81

@erikgollot it looks rather difficult to understand for me too... Please elaborate with a simpler example.

@erikgollot I believe it's not relevant anymore, since we don't have types in EO

@erikgollot I believe it's not relevant anymore, since we don't have types in EO


sms_sending_script | Python

Script Title - Sms sending to mobile CLI script in python
python script.py <mobileNO.>

what will change -
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed
add your program name & Author name in main readme

Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language

[x] Python

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server  - https://discord.gg/FXyh2S3
Happy Coding,

Assign it to me @codePerfectPlus

[x] Assigning the task to @rexdivakar

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Happy Coding

Just for the curiousness one need to use an external api, and i dont have a one which provide free service

yes, i have been trying something with free service but SMS needs a paid API, if u wish i can change to a mailing service !! What do u say @shivam-S-bisht

Yea, i totally agree. But some services like fast2sms provide a month for free, but this will go temporarily. So you can switch this project to an email service which will be a permanent solution.

Let me know the Subject, Body message and recipient mail id so i can work on it

Oh yes, you can make an simple api in flask and hit it with the credentials like subject, body and message and recipient email id, which is really scalable and good.


Read and write compressed CSVs to S3

https://github.com/pandas-dev/pandas/pull/35129 was recently merged into pandas-dev:master.

fixes #22555: some compression algorithms did not set the mode to be writeable for file handles. Together with the re-factoring in the second commit, it is now possible to write to binary file handles with compression!

The comment below is unclear and makes it seem as if the feature were removed from pandas instead of that the feature will soon be available in pandas (and hopefully therefore in wrangler):

By now Pandas does not support in-memory CSV compression. https://github.com/pandas-dev/pandas/issues/22555 So the compression will not be supported on Wrangler too.

Anyways, hoping this would be on your roadmap. Thanks for the great tool!

@JasonSanchez good to know about this PR, for sure it is something we have interest. We will add support for it as soon Pandas 1.2.0 became available.
P.S. If we have a new Wrangler's release before it, we will update/fix the comment mentioned.
Thanks!

As pandas 1.2.0 has been released, has there been any updates to when awswrangler will be able to write compressed CSVs directly to S3?

As pandas 1.2.0 has been released, has there been any updates to when awswrangler will be able to write compressed CSVs directly to S3?

Hi @gvermillion @JasonSanchez
We've added support to it in the PR above 👆 .
Could you give it a try before the official release? You can install that directly from the dev branch:
pip install git+https://github.com/awslabs/aws-data-wrangler.git@write-compressed-text

Hi @gvermillion @JasonSanchez
We've added support to it in the PR above 👆 .
Could you give it a try before the official release? You can install that directly from the dev branch:
pip install git+https://github.com/awslabs/aws-data-wrangler.git@write-compressed-text

Hey, @igorborgest. Thanks for the quick response!
I'll give this a go later this afternoon when I get pandas updated.

Hey, @igorborgest. Thanks for the quick response!
I'll give this a go later this afternoon when I get pandas updated.

@igorborgest ,
It appears to working if I just read/write a gzip-compressed CSV directly to S3. However, I was following this notebook you authored to attempt to do a CSV partition (literally replaced [to,from]_parquet with [to,from]_csv). When I attempt to read in the partition with a filter, I lose header information and the formatting is not as it was when I call .to_csv(). This is the case both with and without compressions=gzip.
I'm not sure if this later bit is expected behavior or not. I have not used CSV partitions before.

@igorborgest ,
It appears to working if I just read/write a gzip-compressed CSV directly to S3. However, I was following this notebook you authored to attempt to do a CSV partition (literally replaced [to,from]_parquet with [to,from]_csv). When I attempt to read in the partition with a filter, I lose header information and the formatting is not as it was when I call .to_csv(). This is the case both with and without compressions=gzip.
I'm not sure if this later bit is expected behavior or not. I have not used CSV partitions before.

Hi @gvermillion , thanks for testing it.
Actually it is not related with the compression itself, it was a limitation in the CSV Datasets implementation that didn't support CSV headers. But I've just updated the branch adding support for that.
I also update the two tutorials that I recommend you to take a look:

CSV Datasets (Last 3 paragraphs)
Flexible Partitions Filter (Last paragraph)

Could you give it another try?
p.s. Uninstall the previous installation explicitly (pip uninstall awswrangler) before install again. We are keeping the same version number, so pip will not update it automatically.

Hi @gvermillion , thanks for testing it.
Actually it is not related with the compression itself, it was a limitation in the CSV Datasets implementation that didn't support CSV headers. But I've just updated the branch adding support for that.
I also update the two tutorials that I recommend you to take a look:

CSV Datasets (Last 3 paragraphs)
Flexible Partitions Filter (Last paragraph)

Could you give it another try?
p.s. Uninstall the previous installation explicitly (pip uninstall awswrangler) before install again. We are keeping the same version number, so pip will not update it automatically.

Hello @igorborgest ,
The updates worked as expected for me. Is there any estimate for when this update will be released?
Thanks for the quick turnaround and addressing my follow-up question!

Hello @igorborgest ,
The updates worked as expected for me. Is there any estimate for when this update will be released?
Thanks for the quick turnaround and addressing my follow-up question!

It should be released on version 1.3.0 next week.

It should be released on version 1.3.0 next week.

Great. Thanks so much!

Great. Thanks so much!

Released on version 2.3.0 🚀

Released on version 2.3.0 🚀


[Industry Core KIT] Links to OpenAPI specification for Unique ID Push API are broken

Current Behavior
Both links to the OpenAPI specification of the Unique ID Push API are broken on page https://eclipse-tractusx.github.io/docs-kits/kits/Industry Core Kit/Software Development View/Digital Twins Development View Industry Core Kit#backend-data-service-to-process-unique-id-push-notifications. After clicking on these links you land on the "Page Not Found" page.
Expected Behavior
Both links should forward you to the corrent OpenAPI specification in the Industry Core "openapi" folder. These should be the correct links:

Link to 2.0.0: https://eclipse-tractusx.github.io/docs-kits/kits/Industry Core Kit/openapi/unique-id-push.yaml
Link to 2.1.0: https://eclipse-tractusx.github.io/docs-kits/kits/Industry Core Kit/openapi/unique-id-push_2-1-0.yaml

Or something like that. Not sure how openapi and yaml files are published on the eclipse-tractusx Website.
Steps To Reproduce

Navigate to page https://eclipse-tractusx.github.io/docs-kits/kits/Industry Core Kit/Software Development View/Digital Twins Development View Industry Core Kit#backend-data-service-to-process-unique-id-push-notifications (Industry Core KIT, Release 24.05).
Click on one of the two links in section "The standardized version of this API is 2.0.0. Version 2.1.0 is not (yet) standardized, but backwards compatible, and extends v2.0.0 with the Connect-to-Child feature."

Link to 2.0.0: https://eclipse-tractusx.github.io/openApi/industrycore/unique-id-push.yaml
Link to 2.1.0: https://eclipse-tractusx.github.io/openApi/industrycore/unique-id-push_2-1-0.yaml

You will land on the "Page Not Found" page.

Links are fixed and will work in the upcoming release (24.08).


squid:S1066 - Collapsible "if" statements should be merged

This pull request is focused on resolving occurrence of Sonar rule
squid:S1066 - Collapsible "if" statements should be merged.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1066
Please let me know if you have any questions.
George Kankava

@gssiyankai
You want to check it out?

@lemire
I am not in favor of enforcing this Sonar rule. I agree that it sometimes increases code readability. But sometimes it does not.
What do you think ?

@gssiyankai  Indeed, in this instance, when I look at the code after and before, it is not obvious that the after code is more readable.

@georgekankava
I think we are unconvinced by this particular PR. Do you have any arguments?

No if you don't prefer this rule it is up to you.

@georgekankava  I think we appreciate very much you work, but I am going to close this particular PR without merging as the benefits are unclear.


Fix Cython and Numpy deprecations and match modern usage

Original report by Joseph Fowler (Bitbucket: joe_fowler, ).

Tell Cython to use Python 3 as its target.
Numpy has deprecated the numpy symbols int, float, and bool, which have long been synonyms for the Python builtins.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Removing milestone: v0.7 (automated comment)

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

See https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations for info on the Numpy deprecation.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Fixed by PR 159.


Pretty up the example dashboard, use docker compose v2

Maybe fixes - https://github.com/grafana/xk6-output-influxdb/issues/8.. but could still be further improved of course.
What
Pretty up the example dashboard
use docker compose v2
Adjust example test
Why
Example dashboard needed some pizzaz
docker-compose (v1) is deprecated in favor of compose v2 plugin: https://docs.docker.com/compose/
30 second run gives a slightly nicer set of datapoints than 10 seconds

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Tony Scott seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.