[Fea] Poor native support for existing CMake projects

see problem https://github.com/vector-of-bool/vscode-cmake-tools/issues/618

VScode has no clear roadmap about integration of existing CMake projects . My worksation is Ubuntu 18.04 and I use clang and modular Cmake system. The most important feature of an editor is files indexing and visual editing. And VScode cannot handle it correctly if the target is an existing CMake project.
By importing CMake projects into the space, there is no clear way about how to configure a taks.json and c_cpp_properties.json. Indexing always broken, even though my cmake projects works very well.
Compared to experiences in Xcode (MacOS), one single instruction, everything will be done. Xcode brings much better experiences in CMake projects integration. Universal usage must not mean ubiquitously cumbersome. I hope a concrete work flow for CMake users provided provided that vscode is intended to support c++.
@bobbrow  @sean-mcmanus

I think the VS Code team will want this to be reported at https://github.com/Microsoft/vscode-cpptools/issues . I don't think the VS Code team plans to add any support for CMake projects.

As @sean-mcmanus mentioned, please report those issues to the extensions you are using.


Random crashes with encrypted realm.

How frequently does the bug occur?
ALL THE TIME
Description
Application constantly crashes in random transactions.
Stacktrace & log output
2022-02-26 15:47:15.802 6088-6465/packageAPP E/REALM: uncaught exception in notifier thread: N5realm5_impl17TransactLogParser14BadTransactLogE: Bad transaction log
2022-02-26 15:47:15.807 6088-6465/packageAPP E/libc++abi: terminating with uncaught exception of type realm::_impl::TransactLogParser::BadTransactLog: Bad transaction log
2022-02-26 15:47:15.811 6088-6465/packageAPP A/libc: Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 6465 (packageAPP), pid 6088 (packageAPP)

Can you reproduce the bug?
Yes, always
Version
10.10.1
Are you using encryption?
Yes, using encryption
Platform OS and version(s)
ANDROID 12
Build environment
tools.build:gradle: 7.1.2
kotlin-gradle-plugin: 1.6.10

@yul13th Out of curiosity, did you find the root cause for this?

https://github.com/realm/realm-java/issues/7652

https://github.com/realm/realm-java/issues/7652


Add ability to pull any TeamCity build parameters

A lot of TeamCity build parameters are stored in files.
There is an environment variable which points to configuration (and also file pointers within the files to other files!)
The key parameter I would like to access is the build branch.
But it would be nice to have access to any parameter by the parameter key.

@BlythMeister Perhaps we can repurpose this one instead? https://github.com/cake-build/cake/issues/2967
I suggested parsing TeamCity's .properties file, and your PR is parsing the .xml instead which is fine.

:facepalm: yep...that's exactly what I have done....


Transparent gif displays frames at background.

I have been using your gif code snippet. Problem is its displaying the older frames at background.
Is this a known issue or do we have any solution for this. See attachment image.
Thanks
Original Gif:

After loading via your code:

Yes, you are right..  can you try something on this ?

Sorry, I cannot change Movie's behavior.


Update Composer dependencies (2022-03-05-00-02)

Visual regression test passed!
View the visual regression test report


Request: UI Improvement in the Challenge Creation Screen Mandatory Fields

Please consider making the start and end times more obviously mandatory. Now, it's not obvious the fields are mandatory until the user selects Next.

thanks!  we'll huddle with our design team on this one

@termaatFlipside note Madison's suggestion: Quick fix to this would be adding an asterisk to all required fields.


App version missing after upgrade from 2.1.2 to 2.3.1

As the title says. After upgrading our RN project from 2.1.2 to 2.3.1, we're no longer seeing any data for the "App Version" property. As seen in the screenshot below, our latest release is listed under "Not set".

hi @AdamGerthel , we have fixed this issue in v2.4.1. Closing this one now, please reopen if the problem exists.


Modify complete filter

Coverage increased (+0.02%) to 89.559% when pulling bd3e45499c7dd4560d258e45d43155beaf1942f6 on modify-complete-filter into 0c47e0aa50b3d0fb162bf2071a68e047276f45ab on master.


unable to start talkingbot frondend

followed the guidelines mentioned here:
https://github.com/intel/intel-extension-for-transformers/tree/main/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot
process failed during dependencies
npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition. sass provides its own type definitions, so you do not need this installed.
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please use @jridgewell/sourcemap-codec instead
npm ERR! code 1
npm ERR! path /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/node_modules/@sveltejs/kit
npm ERR! command failed
npm ERR! command sh -c node postinstall.js
npm ERR! file:///home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/node_modules/@sveltejs/kit/postinstall.js:7
npm ERR!        const cwd = process.env.INIT_CWD ?? process.cwd();
npm ERR!                                          ^
npm ERR!
npm ERR! SyntaxError: Unexpected token '?'
npm ERR!     at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18)
npm ERR!     at async link (internal/modules/esm/module_job.js:42:21)

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/intel/.npm/_logs/2024-04-26T07_31_20_839Z-debug-0.log

Hi, could you please confirm your node version? I'm using the latest node [node: v20.11.1, npm: 10.1.0], and it runs smoothly. It seems the issue might be due to version incompatibility. Would you consider upgrading your node version to see if the problem persists? Versions 18 and above should all be compatible.

@WenjiaoYue, upgrading the npm version solve dependency problem.
Now, I have started the server, but it doesn't start any communication.
For example, I am using the default template and starting the voice record but it doesn't return any response.
npm version:

server output:
 1:10:12 PM [vite-plugin-svelte] /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/components/talkbot/bot-template-card.svelte:26:11 Bot_template_card has unused export property 'knowledge'. If it is for external reference only, please consider using `export const knowledge`
8/3/2023 --- CollectionType {
  '0': 'Custom',
  '1': 'Library',
  '2': 'TemplateCustom',
  '3': 'TemplateLibrary',
  Custom: 0,
  Library: 1,
  TemplateCustom: 2,
  TemplateLibrary: 3
} 0

╭── 🌼 daisyUI 3.9.4 https://daisyui.com
│
├── 2 themes are enabled. How to add more themes:
│   https://daisyui.com/docs/themes
│
╰── ⭐ Star daisyUI project on GitHub: https://github.com/saadeghi/daisyui

1:10:19 PM [vite-plugin-svelte] /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/components/talkbot/bot-template-card.svelte:26:11 Bot_template_card has unused export property 'knowledge'. If it is for external reference only, please consider using `export const knowledge`
1:10:19 PM [vite] ✨ new dependencies optimized: svelte-notifications
1:10:19 PM [vite] ✨ optimized dependencies changed. reloading
1:10:20 PM [vite-plugin-svelte] /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/components/talkbot/bot-template-card.svelte:26:11 Bot_template_card has unused export property 'knowledge'. If it is for external reference only, please consider using `export const knowledge`
1:10:20 PM [vite-plugin-svelte] /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/components/talkbot/bot-template-card.svelte:26:11 Bot_template_card has unused export property 'knowledge'. If it is for external reference only, please consider using `export const knowledge`
8/3/2023 --- CollectionType {
  '0': 'Custom',
  '1': 'Library',
  '2': 'TemplateCustom',
  '3': 'TemplateLibrary',
  Custom: 0,
  Library: 1,
  TemplateCustom: 2,
  TemplateLibrary: 3
} 0
1:10:57 PM [vite-plugin-svelte] /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/modules/chat/chat-message.svelte:83:1 Unused CSS selector "audio::-webkit-media-controls-panel"
1:10:57 PM [vite-plugin-svelte] /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/modules/chat/chat-audio.svelte:23:11 Chat_audio has unused export property 'right'. If it is for external reference only, please consider using `export const right`
1:10:57 PM [vite] ✨ new dependencies optimized: sse.js, nanoid
1:10:57 PM [vite] ✨ optimized dependencies changed. reloading
1:10:58 PM [vite-plugin-svelte] /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/components/talkbot/bot-template-card.svelte:26:11 Bot_template_card has unused export property 'knowledge'. If it is for external reference only, please consider using `export const knowledge`
1:10:58 PM [vite-plugin-svelte] /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/modules/chat/chat-message.svelte:83:1 Unused CSS selector "audio::-webkit-media-controls-panel"
1:10:58 PM [vite-plugin-svelte] /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/modules/chat/chat-audio.svelte:23:11 Chat_audio has unused export property 'right'. If it is for external reference only, please consider using `export const right`
8/3/2023 --- CollectionType {
  '0': 'Custom',
  '1': 'Library',
  '2': 'TemplateCustom',
  '3': 'TemplateLibrary',
  Custom: 0,
  Library: 1,
  TemplateCustom: 2,
  TemplateLibrary: 3
} 0
1:11:03 PM [vite-plugin-svelte] /home/intel/ritu/talkingBot/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/components/talkbot/bot-template-card.svelte:26:11 Bot_template_card has unused export property 'knowledge'. If it is for external reference only, please consider using `export const knowledge`

Now it works fine. The reason for the unresponsive was that browsers only allow microphone and camera access on HTTPS websites by default. You can add the current IP to the "Insecure origins treated as secure" list. After reloading, the browser will prompt to allow microphone access.
https://stackoverflow.com/questions/52759992/how-to-access-camera-and-microphone-in-chrome-without-https

It looks like there might be some issues with the backend return values. Maybe Liang could help you confirm.


Research code highlighter, performance

I recently found a really big performance issue with client-side highlighting: https://github.com/mapbox/playground/pull/49
Since we use highlighters often, maybe it's time to look into other options or implementations.

We use https://github.com/mapbox/rehype-prism for most server-side syntax highlighting. This library achieves the task, but I don't think we need the level of granularity that it provides. Ultimately, we use syntax highlighting to help make code blocks easier to read and scan - having just a few keywords highlighted would accomplish this.
I'm going to start researching some lightweight syntax highlighters.
This first one I found is: https://larsjung.de/lolight/ and it provides really basic highlighting: https://larsjung.de/lolight/latest/demo.html


oe-core switched to mickledore [1]

[1] https://git.openembedded.org/openembedded-core/commit/?id=57239d66b933c4313cf331d35d13ec2d0661c38f
Signed-off-by: Thomas Perrot<EMAIL_ADDRESS>

Thank you very much.
I need to modify my GitHub Actions workflow.
Merge this pull request.


Fix vm_flags access violation in linux >= 6.3

Issue:

vma->vm_flags is marked as const in linux >= 6.3. vm_flags_set is introduced for modifying vm_flags.
See https://github.com/torvalds/linux/commit/bc292ab00f6c7a661a8a605c714e8a148f629ef6.

This PR:

declares vm_flags_set when compiling with linux < 6.3.
always uses vm_flags_set to modify vm_flags.

Presubmit Testing:

On an x86-64 machine with linux kernel 5.13.0-30-generic and 6.3.5.

hopefully the upstream patch will not be back ported to distro kernels


Remove suse.RancherDesktop 0.7.1 to SUSE.RancherDesktop 0.7.1

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/rancher-sandbox/rancher-desktop/releases/download/v0.7.1/Rancher.Desktop.Setup.0.7.1.exe
Status Code: 200
(Automated message - build 896)


Add LICENSE and CONTRIBUTING documents

Signed-off-by: Maciej Szlosarczyk<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from maciej-szlosarczyk after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: maciej-szlosarczyk
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [maciej-szlosarczyk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 80d5c27d622ba1d392b5323627625a981af90388

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: maciej-szlosarczyk, zacaaron
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [maciej-szlosarczyk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: maciej-szlosarczyk, tslim, zacaaron
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [maciej-szlosarczyk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


feat(curriculum): migrate certs to yml

@RandellDawson I just changed the extensions of the Chinese certs, so they'll need syncing with Crowdin before they work.

@RandellDawson, @raisedadead this seemed like the PR to remove the old parser, but if you'd rather I do that later I can split those off into another PR.

That's fine, @RandellDawson I think you could now get this setup with Crowdin.


Renewing certificates crashes IIS

Issue description
We are experiencing the scheduled renewal of certificates causing the IIS to crash. Letsencrypt itself does not actually give an error message, but successfully renews the first certificate. Afterwards, the IIS is non-responsive and requires a restart while the renewal job is stuck with "Scanning IIS site bindings for hosts".
Thus, only one certificate gets renewed at a time, and requires manual restarting the IIS to get back online.
As WIN-ACME does not yet support wildcard certificates, we have quite a large number of certificates that needs renewal, so manually renewing each certificate and restarting the IIS is not an option.
We have been using win-acme for the better part of a year now without problems. The issue started occurring about a week ago, and we are suspecting a windows update to be the cause, but have not seen any other users with similar issues.
Please advice.
Best,
Mathias
Steps to reproduce
Please include the command line and/or manual input, relevant details about the IIS bindings, your scripts, etc.
Command:
letsencrypt.exe --renew --warmup --verbose --accepttos --emailaddress @.com --baseuri https://acme-v01.api.letsencrypt.org/
Client version:  1911.2.6726.40690 (RELEASE)
Windows version: Windows Server 2012 R2 Standard - Version 6.3.9600 Build 9600
Relevant part of log file:
[DBUG] Config folder: C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org
[VERB] Settings SettingsService {ConfigPath="C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org", ClientNames=["win-acme", "letsencrypt-win-simple"], RenewalDays=55, HostsPerPage=50, ScheduledTaskRandomDelay=00:00:00, ScheduledTaskStartBoundary=09:00:00, ScheduledTaskExecutionTimeLimit=02:00:00}
[VERB] .NET Framework >=4.7 detected
[INFO] A Simple ACME Client for Windows (WACS)
[INFO] Software version 1911.2.6726.40690 (RELEASE)
[INFO] IIS version 8.5
[INFO] ACME server https://acme-v01.api.letsencrypt.org/
[INFO] Please report issues at https://github.com/PKISharp/win-acme
[VERB] Verbose mode logging enabled
[DBUG] Renewal period: 55 days
[VERB] Store renewals in registry HKEY_CURRENT_USER\Software\letsencrypt-win-simple\https://acme-v01.api.letsencrypt.org/
[VERB] Checking renewals
[INFO] Renewing certificate for au.surveybee.net
[DBUG] Scanning IIS site bindings for hosts
[DBUG] Loading signer from C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\Signer
[DBUG] Getting AcmeServerDirectory
[DBUG] Send GET request to https://acme-v01.api.letsencrypt.org/directory
[DBUG] Loading registration from C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\Registration
[INFO] Authorize identifier: ..net
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-authz
[INFO] Cached authorization result: valid
[DBUG] Certificate folder: C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org
[DBUG] Certificate store: WebHosting
[DBUG] RSAKeyBits: 2048
[INFO] Requesting certificate ..net 2018/7/24 8:49:52 AM
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-cert
[INFO] Saving certificate to C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org
[VERB] Converting private key...
[DBUG] Set private key exportable
[INFO] Installing certificate in the certificate store
[DBUG] Opened certificate store WebHosting
[INFO] Adding certificate ..net 2018/7/24 8:49:52 AM to store WebHosting
[VERB] CN=..net - CN=Let's Encrypt Authority X3, O=Let's Encrypt, C=US (1FF1CFA5DEB20C39A8B3F4DF3659B033903DAE0F)
[VERB] CN=Let's Encrypt Authority X3, O=Let's Encrypt, C=US - CN=DST Root CA X3, O=Digital Signature Trust Co. (E6A3B45B062D509B3382282D196EFE97D5956CCB) to CA store
[VERB] CN=DST Root CA X3, O=Digital Signature Trust Co. - CN=DST Root CA X3, O=Digital Signature Trust Co. (DAC9024F54D8F6DF94935FB1732638CA6AD77C13) to AuthRoot store
[DBUG] Closing certificate stores
[INFO] Installing with IIS...
[INFO] Updating existing https binding ..net:443
[INFO] Committing 1 https binding changes to IIS
[INFO] IIS will serve the new certificates after the Application Pool IdleTimeout has been reached.
[INFO] Renewal for ..net succeeded
[INFO] Next renewal scheduled at 2018/9/17 8:49:55 AM
[INFO] Renewing certificate for ***.com
[DBUG] Scanning IIS site bindings for hosts
For bug reports, please reproduce the bug with the --verbose parameter and copy the relevant part of the log file.

That's pretty annoying, especially that IIS becomes unresponsive because of this. Can you give an indication of how many sites and bindings you have running on this instance? Did those numbers increase a lot recently? Are there a lot of stopped sites? Lot of unusual bindings? (e.g. FTP,

I hope the issue resolved itself!


[FEATURE REQUEST] save contractions

Is your feature request related to a problem? Please describe.
Generated *.csv graph has't contraction edges actually.
I think we have to add option flag 'do_contraction=true/false' for some purposes (well, if you have really big graph you do not want to do contraction every time, just do it once and save it...)
Describe the solution you'd like and provide pseudocode examples if you can
Add flag.
If it is true => generate contraction hierarchies (call PrepareContracts())
Default value should be false.
Describe alternatives you've considered and provide pseudocode examples if you can
nope
Additional context
nope

Done https://github.com/LdDl/osm2ch/pull/5


Podman

Package Name
Podman is already in the upstream-repositories of Debian and Ubuntu, however with a rather old version.
Since podman is also distributed via Github Releases, would you be willing to accept a PR to add podman to the repository, so we get the latest version?
Package Component
No response
Package Description
Podman: A tool for managing OCI containers and pods.
Project URL
github.com/containers/podman/

Hello,
Why not, last time we checked it seemed complicated though, maybe that was before they published a static release.
Have to tried to install it from the release page and do you know which dependencies we need to make it fully functionnal?

It seems that it's not as easy as just downloading the binary and running it, see: https://podman.io/getting-started/installation.html
So I'm not really sure if this is a useful addition since there are many different ways to install a current podman.

Indeed.
Lets close the issue for now, it would be nice to have podman in the project but we would need to carefully check that all features work properly on supported distributions.


Improve / simplify UI providers usage.

Currently, the app has to wrap the generic UI provider to hydrate it will the callbacks/apps logic and then use this 'custom UI provider' in order to keep the app file usable. Also, each provider has to set its
There are three things that need improvement:

Have a simpler way to have this provider hydrated instead of creating a brand new custom provider which extends/hydrates the one provided in the UI project.

Cleanup app usage of providers, group them by context (ui/non-ui/auth/store).

Good to have: Each provider has the same logic to set service implementation under a useEffect. We need to find ways to reuse this logic throughout all providers.

@dannyrb this will be closed by #1264. This will simplify providers usage. 👍


Build broken when switched to grpc 1.31.0

Although source code includes grpc++/grpc++.h and it worked correctly on previous versions.
But on 1.31 build broke with an error:
 error: ‘ServerAsyncWriter’ in namespace ‘grpc’ does not name a template type
             ::grpc::ServerAsyncWriter< REPLY > m_writer;

and could only be fixed by further including
#include "grpcpp/grpcpp.h"
#include "grpcpp/impl/codegen/async_stream.h"

in the source code. Is this the intended behaviour or a bug indeed?

@abb3r Can you provide more information on your case such as os, compiler version, build tool, so on?

I moved to version grpc 1.31 form 1.26
cmake version 1.17.0
gcc version 8.3.1 20191121 (Red Hat 8.3.1-5) (GCC)
To make it clear the build broke of my application against grpc lib but not the grpc build itseltf.

@abb3r If this happened to your application, can you make a small reproduction case so that I can build it myself?

Sorry for coming back late.
The issue has already been fixed in version 1.33.1. I see there was experimental namespace grpc_impl introduced in version 1.31 and 1.32 which has been reverted in newer version and fixed my problem.

fixed in grpc v1.33.1

Thanks for the confirmation!


3 modes: (side-by-side, code, wysiwyg)

Some markdown editors function with 3 modes

2panes: "code" and "render" side-by-side (sometimes "code" and "wysiwyg" side-by-side)
1pane: "code"
1pane: "wysiwyg"

Where:

"code" is the editable source code. read-write
"render" is the rendered version (code rendered into html, rendered by browser). read only.
"wysiwyg" is like "render", but also supports editing. (What You See Is What You Get).

May be nice if:

peer-pad supported these
we had a button (and keyboard shortcut) to switch between these 3 modes.

(Some of the old wireframes show some of this, i think)

There are some little code/render buttons in the header ... they are easy to overlook:

Code mode:

Render mode:

You can also create a "Read-Only Link", but the resulting link still gives you both panes with the button:

There's no wysiwyg, but I did encounter a CodeMirror flavour that does that:
https://laobubu.net/HyperMD/#README.md
Seems to have support for emojis. :-)
The author of CodeMirror also has done ProseMirror which is quite awesome. https://prosemirror.net/


Fixes get_method_list function to return a correct info about custom functions

This PR is for progress made on https://github.com/godotengine/godot/issues/33624.
I am working on contributing to an open source project for a class assignment and don't have enough time to track down some of the TODOs I added.  I plan on continuing work on this issue once I have more free time.
Please let me know of any advice or recommendations for changes I should to make.

@Dbeckett23 Is this still desired? If so, it needs to be rebased on the latest master branch. Also, the above feedback needs to be addressed.
If not, abandoned pull requests will be closed in the future as announced here.

@Dbeckett23 This needs to be rebased on the latest master branch and the above feedback needs to be addressed.
If not, abandoned pull requests will be closed in the future as announced here.

Is this fix going to be merged? jw

Is this fix going to be merged? jw

This needs a rebase and addressing vnen's feedback above, so not yet.

We can just close this, it has been nearly 2 years with no response and the author is not active on GitHub anymore.


feat: Add cache util to cache pipelines

Fixes issue #6

Codecov Report

Merging #8 (5cfc66b) into main (fc66a5f) will decrease coverage by 12.50%.
The diff coverage is 65.51%.

:exclamation: Current head 5cfc66b differs from pull request most recent head d8418e1. Consider uploading reports for the commit d8418e1 to get more accurate results

@@             Coverage Diff              @@
##              main       #8       +/-   ##
============================================
- Coverage   100.00%   87.50%   -12.50%
============================================
  Files            2        3        +1
  Lines           51       80       +29
============================================
+ Hits            51       70       +19
- Misses           0        8        +8
- Partials         0        2        +2

Flag
Coverage Δ

macos-latest
87.50% <65.51%> (-12.50%)
:arrow_down:

ubuntu-latest
87.50% <65.51%> (-12.50%)
:arrow_down:

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

util/cache.go
65.51% <65.51%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


(Create) Enforcing RBAC Doc

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: _____
Previous doc did not have enough information and was not easily located by customers.  Since this is a security item, additional information and pictures were added to the documentation so it is a separate article
Jira/GitHub Issue numbers (if any): ________ https://harnesssupport.zendesk.com/agent/tickets/71782
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6719c273e416374a5cd8fe76--harness-developer.netlify.app


Step out of current function call

Wasn't able to find "Step out of current function call"
Analog of this in chrome javascript debugger:

You're looking for the finish command.
Regards.


Multiplication bug in calculator when using period instead of comma

Microsoft PowerToys version
0.61.1
Running as admin

[ ] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Alt Space to run PowerToys Run
Enter: 6700 * 0.03
✔ Expected Behavior
The result would be 201
❌ Actual Behavior
PowerToys returns 2010, probably because of the period usage in place of comma.
6700*0.03 = 2010
6700*0,03 = 201
I think it's a bug because 6700*0.1 returns correct answer, but going lower doesn't
Other Software
No response

Hello and thanks for your message. What are your (Windows) regional settings? And there's a check-box in PowerToys Settings dealing with regional format (. or ,)
I think the leading zeros - after the decimal - get trimmed off. We've seen this issue before 😟

Hello, thanks for the reply.
Region: Russia, Regional format: Russia (Russia).
Found the checkbox, thanks.
I guess it's a duplicate issue of a leading zero getting trimmed off then. Do I need to close this?

FWD @crutkas I thought this was supposed to be fixed already?

Hello,
Can confirm, bug still exists:  9.9 * 1.005 = 14.85 and 9.9 * 1.05 = 14.85 too.
Windows regional settings : France , Français (France)
Checkbox in Run settings indeed does fix this: 9.9*1.005=9,9495
Thanks for the info  @Jay-o-Way

My own results; local decimal is a comma ,:

[ ] Use English notation for input (unchecked)
=6700*0.03 → 20100 ❌
=6700*0,03 → 201 ✔
=9.9*1.005 → 99495 ❌

[x] Use English notation for input (checked)
=6700*0.03 → 201 ✔
=6700*0,03 → 20100 ❌
=9.9*1.005 → 9,9495 ✔

Looking at this, I think that for the input that is not matching the local delimiter, all the . are simply ignored. 0.03 becomes (00)3.

@crutkas we rrreally should do something about this

Maybe it came too late for 0.65.0, as it's not listed in the "Known Issues" of that release.
But just for protocol, 0.65.0 is still affected by this issue.
For the next release I'd suggest to at least include this unexpected behavior in the list of "Known Issues" if no fix for it can be done by that time.

@crutkas @stefansjfw @jaimecbernardo we rrreally need to do something about this

My own results; local decimal is a comma ,:

[ ] Use English notation for input (unchecked)
=6700*0.03 → 20100 ❌
=6700*0,03 → 201 ✔
=9.9*1.005 → 99495 ❌

[x] Use English notation for input (checked)
=6700*0.03 → 201 ✔
=6700*0,03 → 20100 ❌
=9.9*1.005 → 9,9495 ✔

Looking at this, I think that for the input that is not matching the local delimiter, all the . are simply ignored. 0.03 becomes (00)3.

This is exactly how it should work:

Setting checked: A dot is expected.
Setting uncheck: The character definded in culture settings of windows is expected.

If you use the wrong delimiter it is interpret as thousand separator instead of decimal separator. And then all trailing zeros are removed because 001 is the same as 1.

If you use the wrong delimiter it is interpret as thousand separator instead of decimal separator.

Thanks, with that mention of the thousand separator I finally could understand what's going on. It never even crossed my mind because although I work with numbers on a quite regular basis a thousand-separator is used absolutely never.
Also I now checked where the all those settings are and how they work together.
I understand from a technical perspective that the handling is "correct", but at least from my practical experience this is really unexpected and very confusing (esp. when regularly also switching between english and eg. german formats).
I have no real suggestion how it could be improved for the multi-national userbase of the Run plugin, but for me personally I'd prefer a (default-on) setting to not interpret thousand-separators (whatever it is) at all instead of toggling the meaning of "." and ",".
(So only interpret one of "." or "," but give an error on the other one instead of treating it silently.)

This bug is still present in the latest version.
PowerToys v0.68.1
Windows regional settings : France , Français (France)
When I'm using the DOT key on the numpad, this will give a "." instead a ","
The windows regional settings is not taken in account in the entry field of the PowerToysRun.
Fortunately, I enabled "Use US format" calculator option as a workaround.

Linking #2265

/dup https://github.com/microsoft/PowerToys/issues/2265


immutability

https://youtu.be/dM_NUMEO69k
Check out the code at minutes 3.00 of the video. Maybe the idea there is helping you...

Thanks for the tip. Closing in favor of existing immutability issue :)


Standardized customer and supplier commands

Fix bugs to make information and ingredients supplied optional for add supplier command. Standardized both add customer and add supplier commands to make only the name and phone number field compulsory. I have fixed another bug to ensure that both add customer order and add supply order commands will only accept phone number contacts that are customers or suppliers respectively.

LGTM


findMany with include/select many-to-many relation results in empty array (bigint)

Bug description
I have a table Place and a table PlaceCategory with a _PlaceToPlaceCategory as relation table. When using the findMany with include/select: { categories: true } , the categories are empty (categories: []) for most of the records (for some of them is working as expected), even if they are linked in the relation table.
If I change the findMany options and I set the id: number in the where clause, categories are correctly extracted, also works with findUnique/findFirst:

Output:

How to reproduce
Create a table with a many-to-many relation and call findMany including the relation
Expected behavior
No response
Prisma information
My tables are defined as below:
model Place {
  id             BigInt              @id @unique(map: "id") @default(autoincrement()) @db.UnsignedBigInt
  address        String?             @db.VarChar(255)
  phone          String?             @db.VarChar(255)
  websiteUrl     String?             @db.VarChar(255)
  googlePlaceId  String?             @db.VarChar(255)
  creationDate   DateTime            @default(now()) @db.Timestamp(0)
  publishedDate  DateTime            @default(now()) @db.Timestamp(0)
  organisationId BigInt              @db.UnsignedBigInt
  authorId       BigInt?             @db.UnsignedBigInt
  archived       Boolean             @default(false)
  email          String?             @db.VarChar(255)
  mobilePhone    String?             @db.VarChar(255)
  onDemand       Boolean?
  title          String?             @db.VarChar(255)
  content        String?             @db.LongText
  attachmentId   BigInt?             @db.UnsignedBigInt
  isChanged      Boolean?
  favorite       Boolean             @default(false)
  targetType     String?             @db.VarChar(100)
  thumbnail      Attachment?         @relation(fields: [attachmentId], references: [id], onUpdate: Restrict, map: "Place_ibfk_6")
  author         User?               @relation(fields: [authorId], references: [id], onUpdate: Restrict, map: "Place_ibfk_5")
  organisation   Organisation        @relation(fields: [organisationId], references: [id], onDelete: Cascade, onUpdate: Restrict, map: "Place_ibfk_4")
  attachments    AttachmentToPlace[]
  openings       Opening?
  position       PlaceCoordinates?
  translations   PlaceLang[]
  editors        User[]              @relation("PlaceToEditor")
  categories     PlaceCategory[]

  @@index([authorId], map: "authorId")
  @@index([organisationId], map: "organisationId")
  @@index([attachmentId], map: "thumbnail")
}

model PlaceCategory {
  id                      BigInt                      @id @unique(map: "id") @default(autoincrement()) @db.UnsignedBigInt
  iconId                  Int?
  iconName                String?                     @db.VarChar(100)
  color                   String?                     @db.VarChar(7)
  organisationId          BigInt                      @db.UnsignedBigInt
  authorId                BigInt?                     @db.UnsignedBigInt
  parentId                BigInt?                     @db.UnsignedBigInt
  colorContrast           String?                     @db.VarChar(4)
  order                   Int?
  title                   String?                     @db.VarChar(255)
  author                  User?                       @relation(fields: [authorId], references: [id], onUpdate: Restrict, map: "PlaceCategory_ibfk_5")
  organisation            Organisation                @relation(fields: [organisationId], references: [id], onDelete: Cascade, onUpdate: Restrict, map: "PlaceCategory_ibfk_4")
  parentCategory          PlaceCategory?              @relation("PlaceCategoryToPlaceCategory_parentId", fields: [parentId], references: [id], onDelete: Cascade, onUpdate: Restrict, map: "PlaceCategory_ibfk_6")
  children                PlaceCategory[]             @relation("PlaceCategoryToPlaceCategory_parentId")
  channels                PlaceCategoryChannel?
  translations            PlaceCategoryLang[]
  subscriptionPreferences PlaceCategorySubscription[]
  place                   Place[]

  @@index([authorId], map: "authorId")
  @@index([organisationId], map: "organisationId")
  @@index([parentId], map: "parentId")
}

and this is my relation table:

Environment & setup

OS: Mac OS 11.6
Database: MySQL 5.7.26
Node.js version: v14.19.2

Prisma Version
3.14.0

Have the same problem. Execution results cannot be trusted when trying findMany whith include. Some items has an empty array.
How to reproduce
Schema
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "sqlserver"
  url      = env("DATABASE_URL")
}

model Workcenter {
  id   BigInt @id @default(autoincrement())
  name String
  operations SpecificationOperation[]
  @@unique([name])
}

model SpecificationOperation {
  id   BigInt @id @default(autoincrement())
  name String
  allowedWorkcenters Workcenter[]
  @@unique([name])
}

seed.ts
import { PrismaClient } from '@prisma/client';

const prisma = new PrismaClient();

async function main() {
  for (let i = 0; i < 3; i += 1) {
    await prisma.workcenter.create({ data: { name: `wc_${i}` } });
  }
  for (let i = 0; i < 3; i += 1) {
    await prisma.specificationOperation.create({
      data: {
        name: `op_${i}`,
        allowedWorkcenters: { connect: [{ id: 1 }, { id: 2 }, { id: 3 }] },
      },
    });
  }
}

main()
  .catch((e) => {
    console.error(e);
    process.exit(1);
  })
  .finally(async () => {
    await prisma.$disconnect();
  });

Run in cmd
node
const p = new (require('@prisma/client')).PrismaClient();
await p.specificationOperation.findMany({ include: { allowedWorkcenters: true } });

Result
[
  { id: 1n, name: 'op_0', allowedWorkcenters: [] },
  { id: 2n, name: 'op_1', allowedWorkcenters: [] },
  {
    id: 3n,
    name: 'op_2',
    allowedWorkcenters: [ [Object], [Object], [Object] ]
  }
]

Expected result
[
  {
    id: 1n,
    name: 'op_0',
    allowedWorkcenters: [ [Object], [Object], [Object] ]
  }
  {
    id: 2n,
    name: 'op_1',
    allowedWorkcenters: [ [Object], [Object], [Object] ]
  }
  {
    id: 3n,
    name: 'op_2',
    allowedWorkcenters: [ [Object], [Object], [Object] ]
  }
]

Thoughts
I found that prisma generates this three queries when I get the wrong result on this data:
SELECT [dbo].[SpecificationOperation].[id],
    [dbo].[SpecificationOperation].[name]
FROM [dbo].[SpecificationOperation]
WHERE 1=1

SELECT [dbo].[_SpecificationOperationToWorkcenter].[A],
    [dbo].[_SpecificationOperationToWorkcenter].[B]
FROM [dbo].[_SpecificationOperationToWorkcenter]
WHERE [dbo].[_SpecificationOperationToWorkcenter].[A] IN (1,2,3)

SELECT [dbo].[Workcenter].[id],
    [dbo].[Workcenter].[name]
FROM [dbo].[Workcenter]
WHERE [dbo].[Workcenter].[id] IN (1,2,3,1,2,3,1,2,3)

Pay attention to last WHERE clause with (1,2,3,1,2,3,1,2,3). With other data, when numbers in braces 'IN (...)' are unique, there is the correct result.
Maybe this will prompt a solution.

I can confirm this. Looks like a problem in SQL generation indeed.

This error raises not only when using sql server, but with at least postgres too. And the problem is critical I think.
Please, change the label.
Checked on:

Prisma Client JS version: 3.14.0
Query Engine version: 2b0c12756921c891fec4f68d9444e18c7d5d4a6a

FOUND!
Error raises when using BigInt as id in schema! When using Int there is an expected behavior.
But I have to use BigInt.

@pantharshit00
Since this is a pretty sever issue, could we have an estimation when this issue could be solved ?
Just to now if we have to find a workaround or if I can wait.
Thx a lot for your work !

I got same error with Mysql. But interestingly, it generates empty array if relations has many objects. For example company, customer relations works if a use findfirst. And findmany also works with limited customers (in my case below 200). But with 1000 customers, findmany dont works. I tested 3 company and 1000 user each. Result is always empty array.

This problem was fixed with https://github.com/prisma/prisma-engines/pull/3006 and it will be released with the new version of Prisma really soon.


Tray not opening until next tab rotation

Chrome Version: Chromium 61.0.3163.100 (Official Build) Built on Ubuntu , running on Ubuntu 16.04 (32-bit) (Actually, using an armhf build).
Arguments: -kiosk --no-sandbox --disable-session-crashed-bubble --disable-infobars
Operating System: Ubuntu 16.04.
Platform: Raspberry Pi 2.

When hovering over the tray activator, nothing happens. However, if you keep the mouse pointer over it and wait for transition, a wiggle will normally make the tray pop up. Once disappeared, you have to repeat the process again.

Tried this on a Windows workstation running Windows 7 64-bit using the same version of Chrome and same arguments, and I cannot reproduce the issue.

Chrome Version: Chromium 62.0.3202.62 (Official Build) (64-bit)
Arguments: -kiosk --no-sandbox --disable-session-crashed-bubble --disable-infobars
Operating System: Mint 18.2 Sonya.
Platform: 64-bit OS Virtualisation.
No problems. Works as intended.


IsSupported is verified, but an error is still raised

Describe the bug
IsSupported is verified, but an error is still raised.I really can't understand why there are still errors even though the judgment has been made
Code snippets
// Check if the 'Name' property is supported for both 'lastItemUser' and 'lastItemText'
if (lastItemUser.Properties.Name.IsSupported && lastItemText.Properties.Name.IsSupported)
{
string user = lastItemUser.Properties.Name;
string text = lastItemText.Properties.Name;
if (!string.IsNullOrEmpty(text) && !string.IsNullOrEmpty(user))
{
    // Trigger keywords for the accounting function (symbols), TODO: can be configured as custom options
    List<string> AllinstructList = new List<string>() { "+", "-", "/", "~" };

    // TODO: If the user switches too quickly, it may cause errors and program crashes

    // Check if the first character of the text content is a trigger keyword (symbol) and the sender is the user
    if (AllinstructList.Contains(text[0].ToString()) && user == FlaUIAutomation.GetUserName())
    {
        // After relevant logical checks, pass the obtained text as a parameter to the relevant method for processing
        FlaUIAutomation.GetUserInstruction(text);
    }
    else
    {
        // TODO: Write error logs
        return;
    }
}

}
Additional context
The code throws an exception of type "FlaUI.Core.Exceptions.PropertyNotSupportedException" with the message "The requested property 'Name [#30005]' is not supported". The exception occurred in the FlaUI.Core.dll but was not handled in the user code.

After my trace test, I found that when the error occurs, the false value will indeed be output, but the code will still run down, why


Bug: Ecto 3 breaks prefix support for associations using join

Environment

Elixir version (elixir -v): 1.7.4
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): PostgreSQL 10.0
Ecto version (mix deps): 3.0.0
Database adapter and version (mix deps): postgrex 0.14.0
Operating system: macOS 10.14 (Mojave)

Current behavior
I have a multi tenant application that has User and UserRole schemas where a user has_many user roles. After updating to Ecto 3, when querying using the following:
MyApp.User
|> join(:inner, [user], ur in assoc(user, :user_roles))
|> Repo.all(prefix: prefix)

I get this error message:
** (Postgrex.Error) ERROR 42P01 (undefined_table) relation "user_roles" does not exist

It looks like the join is happening on the public schema instead of using the prefix as was the previous behavior. I've taken a look at the docs and it does look like there was a prefix option added to Ecto.Query.join. However, when I attempt to use that option with a dynamic value, like so:
MyApp.User
|> join(:inner, [user], ur in assoc(user, :user_roles), prefix: prefix)
|> Repo.all(prefix: prefix)

I get this error message:
(Ecto.Query.CompileError) `prefix` must be a compile time string, got: `prefix`

Include code samples, errors and stacktraces if appropriate.
Expected behavior
The prefix option on the Ecto.Repo.all callback should carry over to all other query fragments unless otherwise stated as was done previously.

Yes, the prefix in the query should win. Can you please post the SQL query
being logged?
José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

Or rather, the prefix  in the query should be used as the fallback if no
other is specified.
José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

an exception was raised logging %DBConnection.LogEntry{call: :prepare_execute, connection_time:
12000, decode_time: nil, params: [], pool_time: 836000, query: %Postgrex.Query{cache: :reference,
columns: nil, name: "ecto_1411", param_formats: nil, param_oids: nil, param_types: nil, ref: nil,
result_formats: nil, result_oids: nil, result_types: nil, statement: "SELECT u0.\"id\", u0.\"username\",
u0.\"password_hash\", u0.\"used_password_hashes\", u0.\"reset_password_token\",
u0.\"reset_password_expires_at\", u0.\"failed_attempts\", u0.\"unlock_token\", u0.\"locked_at\",
u0.\"sign_in_count\", u0.\"current_sign_in_at\", u0.\"last_sign_in_at\", u0.\"current_sign_in_ip\",
u0.\"last_sign_in_ip\", u0.\"finished_sign_up_at\", u0.\"encryption_version\", u0.\"inserted_at\",
u0.\"updated_at\" FROM \"tenant-3ae976e6-140b-483c-929d-07745a1407c8\".\"users\" AS u0 INNER
JOIN \"user_roles\" AS u1 ON u1.\"user_id\" = u0.\"id\"", types: nil}, result: {:error,
%Postgrex.Error{connection_id: 22371, message: nil, postgres: %{code: :undefined_table, file:
"parse_relation.c", line: "1180", message: "relation \"user_roles\" does not exist", pg_code: "42P01",
position: "470", routine: "parserOpenTable", severity: "ERROR", unknown: "ERROR"}, query: "SELECT
u0.\"id\", u0.\"username\", u0.\"password_hash\", u0.\"used_password_hashes\",
u0.\"reset_password_token\", u0.\"reset_password_expires_at\", u0.\"failed_attempts\",
u0.\"unlock_token\", u0.\"locked_at\", u0.\"sign_in_count\", u0.\"current_sign_in_at\",
u0.\"last_sign_in_at\", u0.\"current_sign_in_ip\", u0.\"last_sign_in_ip\", u0.\"finished_sign_up_at\",
u0.\"encryption_version\", u0.\"inserted_at\", u0.\"updated_at\" FROM \"tenant-3ae976e6-140b-483c-929d-07745a1407c8\".\"users\" AS u0 INNER JOIN \"user_roles\" AS u1 ON u1.\"user_id\" =
u0.\"id\""}}}: ** (ArgumentError) argument error

Wait, why are you getting "an exception was raised logging"? Instead of a proper exception? :)

I have no idea, that's just what I get when running the query with iex -S mix. I've just cut & paste exactly what has been spit out to the terminal. I also found that to be suspicious, but it looks like this is not the only case where that error is showing up in my app after the upgrade. Any thoughts on what might be going on?

Perhaps there is an error in version 2 of db_connection?

If you call Application.start(:telemetry), what does it return?
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

:ok

So it means telemetry is not started. Please make sure to include ecto_sql
in your list of applications dependencies. :)
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

Ah, that makes sense. Should we update the changelog to state that this is now necessary?  Prior to this phoenix apps did not require you to include :ecto in the applications list. I'm certain that I won't be the only person to run into this issue. If you want, I can write up a quick PR.

Yes, let’s say in the CHANGELOG, when we talk about the split, that if you
have an :applications key, you should list ecto_sql there (but it is not
necessary if you have :extra_applications).
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

I'm facing this issue now. I can't pass the join prefix dynamically.


Feature - Composite Image Filters

This PR contains all the changes from #8 (committed as 78c9bd6f418ceb0b616462b72656c3eef9f6d281) as well as more robust rounded corner control through the divideRadiusByImageScale parameter in the rounded corners UIImage extension and image filters (committed as e9e68dd00b441d873ae2a9e7485c89b5cf6a4053).

@damienrambout could you take a look at this PR for me to make sure everything looks solid? I feel really good about these changes, but always appreciate another pair of eyes.

@cnoon it looks pretty good to me! The optional parameter is something I've been thinking about to solve this issue, so I'm gland you came to the same conclusion :) I think it's the best way to do it without annoying most users about screen scale issues.

Sweet. Thanks for the feedback!


[UF-403] Fork and Mirror

The goal is to have the possibility to fork any git repository inside the niogit directory.
To complete the goal we need:

Separate git repositories into different directories. Those directories are named like the Organizational Units.
Create a Fork command that copy all the content of the repository to fork and add the reference to the internal path of the origin repository.
Write information about fork so we can track where those forks are, how many forks has those repositories, etc.

Please note this PR appears to cause test failures in drools-wb (and I suspect ``kie-wb-common). This was evidenced by (the now closed) [PR](https://github.com/droolsjbpm/drools-wb/pull/288). Can I please request you test compile (with tests) at least kie-wb-commonanddrools-wb- although other repositories containing "indexing tests" may equally be affected (e.g.jbpm-designerandoptaplanner-wb```). Thank-you.

@manstis sure, I'm going to check what happened and I will let you know

@manstis please, check if compilations worked, I fixed some stuffs. Thanks!

@adrielparedes I'll be away for 1 week. Meanwhile, talk with @csadilek about this PR!

@ederign np, I will talk with him. Have fun!

I have revert some changes to have the original behavior but adding the possibility to migrate a repository. To do the migration you have to declare a environment variable at the creation of a new file system. In that variable you set the URI of the repository you want to migrate.
If the old repository exists and the new repository doesn't, it will migrate the old repo to the new one.
If the old repository doesn't exists, it will just create the new one.
And if the new repository exists it will not do any migration.

PluginsFileSystemBuilder.java
public static final String OLD_SYSTEM_PLUGINS = "default://plugins";
public static final String DEFAULT_SYSTEM_PLUGINS = "default://system/plugins";
...
try {
            return ioService.newFileSystem( URI.create( DEFAULT_SYSTEM_PLUGINS ),
                                            new HashMap<String, Object>() {{
                                                put( "init", Boolean.TRUE );
                                                put( "internal", Boolean.TRUE );
                                                put( "migrate-from", URI.create( OLD_SYSTEM_PLUGINS ) );
                                            }} );
        } catch ( final FileSystemAlreadyExistsException e ) {
            return ioService.getFileSystem( URI.create( DEFAULT_SYSTEM_PLUGINS ) );
        }

@porcelli @ederign @csadilek

+1, if not already done, the WB needs to be smoke tested with these changes before the merge. Thanks.

@porcelli @adrielparedes @csadilek I suspect this change has broken some things: https://kie-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/kie-wb-distributions/1403/testReport/ Since this PR was merged there are 22 failing integration tests relating to null "origin" (in presumably the Repository class). Could you please investigate?

@porcelli @adrielparedes @csadilek I am also unable to clone any repository due to the following error:
java.lang.IllegalArgumentException: Parameter named 'origin' should be not null!
	at org.uberfire.commons.validation.PortablePreconditions.checkNotNull(PortablePreconditions.java:119)
	at org.guvnor.structure.repositories.impl.metadata.GitMetadataImpl.<init>(GitMetadataImpl.java:53)
	at org.guvnor.structure.repositories.impl.metadata.GitMetadataImpl.<init>(GitMetadataImpl.java:41)
	at org.guvnor.structure.backend.repositories.git.GitMetadataStoreImpl.write(GitMetadataStoreImpl.java:63)
	at org.guvnor.structure.backend.repositories.RepositoryServiceImpl.createRepository(RepositoryServiceImpl.java:229)

@manstis I found the error, let me create a new PR with the fix after I do the correct smoke test


GitBook is moving away from CLI toolchain

We've been using GitBook to host our documentation at denysdovhan.com/spaceship-prompt. There are some notable changes with their new release.

GitBook is moving away from static site generator model and no longer use gitbook CLI toolchain
External GitBook plugins are no longer supported.

https://github.com/denysdovhan/spaceship-prompt/blob/fbe6ec5f090baa696b884228b4063c874b8c3a1a/book.json#L4

I'm disappointed 😟

We can use GitBook as long as it doesn't break our builds, Closing this now.


MSFT_xNetBios: Corrected style and formatting to meet HQRM guidelines - Fixes #300

Pull Request (PR) description
Convert xNetBios to meet HQRM guidelines and improve integration testing and test coverage.

Corrected style and formatting to meet HQRM guidelines.
Updated tests to meet Pester v4 guidelines.
Converted exceptions to use ResourceHelper functions.
Improved integration tests to preserve system status, run in more
scenarios and more effectively test the resource.
Changed to report back error if unable to set NetBIOS setting.

This Pull Request (PR) fixes the following issues:

#300

Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[x] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[x] Examples appropriately updated?
[x] New/changed code adheres to Style Guidelines?
[x] Unit and (optional) Integration tests created/updated where possible?

@Johlju - if you get time, would you mind reviewing this one for me? Unless @tysonjhayes gets a moment?

This change is

Codecov Report

Merging #303 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff          @@
##            dev   #303    +/-   ##
====================================
+ Coverage    98%    98%   +<1%
====================================
  Files        25     25
  Lines      1805   1810     +5
====================================
+ Hits       1769   1774     +5
  Misses       36     36

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


README.md updated and Improved

WHAT DOES IT DO ?

Fixes minor typos
Uniformity maintained throughout (dots removed)
Links to github and npm added

References issue #93
Please review :-)
Thanks!

Coverage remained the same at 100.0% when pulling aa0ca7038ab5387142a52824569fd1ac7da48ff6 on gupta-meghna64:IssueSolve into 85e09462647de0c10e4fda4ce814708cd9247a8b on alexjoverm:master.

@coveralls what does that mean ?

Coverage remained the same at 100.0% when pulling dd21fa2a5a4dd0b5e3b6c52fbebec11be8ce0252 on gupta-meghna64:IssueSolve into 231079d296ca270045c16a392426fc474fbcec19 on alexjoverm:master.

Thanks @kutyel !


Invitation to web standards meeting about a Screen Reader Automation API on 28th February 2022

Hi @coryrylan,
I came across web-test-runner-voiceover on GitHub while looking for projects that automate screen readers. I’m part of a web standards group called ARIA-AT that  is also looking into automating screen readers, for the purpose of conformance testing.
We're trying to standardize a new API to programmatically control screen readers that we hope will be implemented by vendors to unlock new functionality and to more reliably test the behavior of screen readers.
We’d like to include the input of tooling authors like you. If you're interested in participating in this effort, you're very welcome to attend the next ARIA-AT Automation meeting on February 28 at 12pm PT / 3pm ET. See details here:
https://github.com/w3c/aria-at/issues/622
Thank you!

Sounds great, I will be sure to try to attend. Thanks!

There has been a change of plans since we need some more time to prepare. The new tentative date is March 28. See https://github.com/w3c/aria-at/issues/622#issuecomment-1049760383
Apologies for the late change, and thanks for understanding.


change xml.etree to lxml.etree

Seems as simple as replacing the import statement (at this early state of dev).

Resolves #10.


Expose WatchEvents on demand

A couple of options, not sure what's the nicest interface yet:

On demand events since last "reconcile"
Events as they occur through callbacks

First is easy to do, just queue up, then pop and return on demand.
Latter would probably block the polling thread/owner (since that's the thing that runs the watcher).

We now cache the events in the Reflector as well. So it should be possible to build a reconcile fn. Ideally, call it from the thread that owns the Reflector. Same loop is an easy start.
kube = { git = "https://github.com/clux/kube-rs", rev = "6cd8bfe4f8159036055c7d0cabcdf0d41c300b04" }

See https://github.com/clux/kube-rs/blob/6cd8bfe4f8159036055c7d0cabcdf0d41c300b04/examples/pod_reconcile.rs#L36-L64 for example usage.

Discussion still to be had about the best way to expose it #6 - but initial feature is available in 0.4.0.


desynk on short scroll

Now I've noticed that if you scroll only a little, they desynchronize with the amount you scrolled. I managed this while trying to simple tap, but dragged the finger a little, about 5-15dp. Android 4.4
Also it crashes but I haven't found a pattern yet. Something to do with adding and removing elements. I'll open another issue if I see the pattern.
Best of luck!

Have you reproduced that desync you talk about in the sample app? I can't seem to do so.

yes, on the updated sample app. try tapping rapidly with minimal dragging. if you want i can make a video

Alright, I got to reproduce it once now. Not like it's any easy to pop it up, but it's definitely there. It doesn't come straight to mind why it happens, but I might be able to put up a bit of time together to research on it in a few days. Please keep me posted if you gather any further information.

I haven't connected it to the debugger, but if i do and notice something,
i'll let you know. I manage to reproduce this quite easily though :)
On 24 Oct 2015 14:57, "Jorge Antonio Díaz-Benito Soriano" <
<EMAIL_ADDRESS>wrote:

Alright, I got to reproduce it once now. Not like it's any easy to pop it
up, but it's definitely there. It doesn't come straight to mind why it
happens, but I might be able to put up a bit of time together to research
on it in a few days. Please keep me posted if you gather any further
information.
—
Reply to this email directly or view it on GitHub
https://github.com/stoyicker/RecyclerViewSyncDemo/issues/3#issuecomment-150802588
.


Add ImGui Vulkan extensions

I saw that in ticket #978 it was mentioned that there was a WIP for Vulkan extensions but it was not ready so not shipped. Is there a timeframe/roadmap for when they might be ready? I really love the concept of the Silk.NET but as it stands the only APIs I am currently interested is Vulkan and DX12 and ImGui is pretty much king of simple and easy to use GUIs.

it will be released when someone finishes it

Take a look at this .
Helped me a lot to get imgui working in my project

do not use projects in the lab as a starting point, they are only experiements and do not reflect the code quality we require in the main codebase

do not use projects in the lab as a starting point, they are only experiements and do not reflect the code quality we require in the main codebase

sure, but i think in this case it's fine because that's pretty much just a translation of the original imgui vulkan backend, writing an imgui backend for vulkan is usually a custom task anyways (for me there is almost non of the original code left) and if he's using vulkan he probably knows what he is doing :)
but you should of course not just copy that code and put it in your project like this

this would be huge. I'm a contributor on the Tooll3 project which currently uses SharpDX + DearImGUI.Net and we would love to make the switch to Silk.Vulkan in a properly supported way, as we're hoping to be cross platform and enable embedding in other engines like Godot

this would be huge. I'm a contributor on the Tooll3 project which currently uses SharpDX + DearImGUI.Net and we would love to make the switch to Silk.Vulkan in a properly supported way, as we're hoping to be cross platform and enable embedding in other engines like Godot

We would love to accept a PR containing a finished one, it's an interest of the team, but not something we are actively working on at the moment

this would be huge. I'm a contributor on the Tooll3 project which currently uses SharpDX + DearImGUI.Net and we would love to make the switch to Silk.Vulkan in a properly supported way, as we're hoping to be cross platform and enable embedding in other engines like Godot

We would love to accept a PR containing a finished one, it's an interest of the team, but not something we are actively working on at the moment

I know there is an experimental package - is there any documentation on what it needs to be considered complete? (aside from QA)

I got this one working, video as proof
It seems like the only thing that was stopping it was some unsupported validation mode being requested ("VK_Layer_KHRONOS_validation") on my machine.  Requesting the validation layers I DO have available causes Vk.CreateInstance to fail, but requesting no validation succeeds and works just fine. Not sure which validation layer is failing, though im running on Nvidia with Windows 10
What's left in getting this completed and supported? I wasn't able to get things running the correct silk-contributor way, but symlinking the project directory into my own solution and replacing the csproj relative-file-style dependencies with their nuget dependencies

I fixed the device features validation warning by retrieving the PhysicalDeviceFeatures, but it's no use if we're not actually using those features. What is the minimal subset of features required that we would want to check for?

update: aside from the code quality issues, so far I've found a couple of things that need work -

Custom fonts don't seem to work at all - totally garbled
the actual draw example isn't working off of a shader a user could reasonably expect to replace without setting up the compilation themselves?
related to 2, the general shader loading portion of the code needs finishing/cleaning
the ImGuiController class doesn't match the functionality or "interface" of the same class in the OpenGL implementation, which can cause confusion

Question - how do we feel like using Dynamic Rendering with Shader Objects by default? As far as vulkan templates go, this is probably the most new-user-friendly mode of operation anyway. This is more or less how I'm attempting to set up the pipeline for tooll3, and I'd be happy to share the result if/when I succeed


Add increment code

Description
This adds some of the increments class methods needed for data assimilation (DA) to orca-jedi and updates the increments unit test to test this.
This PR doesn't including all the increments methods needed for DA in particular I left out the (netcdf) writing code, I'll put this in a later PR. I have also attempted to minimise the changes to other parts of the code in this PR. I'm hoping this means it is not too big to review.
FYI my draft list for PRs below

Changes to increment (this PR)
Changes to state, nemo field writer/reader
Changes to interpolator / add dirac test (delta function test)
Implement Saber / error covariance training  including changes to geometry needed for this.
3dvar executable/test
+++ Multiprocessing / Nemovar / Multiple variables / Linear balance ....

Currently this code only works for single processor runs. I was hoping to leave implementing multiprocessing for a future PR.
Also I am aware that both the increments methods and state methods operate on atlas fieldsets so there is the possibility of calling generic methods for both increment and state using a generic fields class. I note this approach is used by lfric and also oops/l95 and probably other code in JEDI. Let me know your thoughts on this. It might be nice to do this in orcajedi too, but ideally not this PR. I think it would be helpful to get the increment test (along with my initial code) in place first.
Issue(s) addressed
N/A
Dependencies
N/A
Impact
There is no impact on other code as far I am aware.
Checklist

[ x ] I have updated the unit tests to cover the change
[  ] New functions are documented briefly via Doxygen comments in the code (I've attempted to follow the existing style which doesn't seem to have comments of this type)
[ x ] I have linted my code using cpplint (I've run the coding_norms test and it passes)
[ x ] I have run the unit tests (all the orca-jedi ctests have run and passed)
[  ] I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments

Hi Dan, the doxygen comments are something we are adding as we make changes to the code, so it is in some places but not everywhere. For examples see OOPS or this recent change for example:
https://github.com/MetOffice/orca-jedi/blob/01cf8be4610fb0800e077ee20a934acdca2dc182/src/orca-jedi/nemo_io/ReadServer.cc#L29
It is good to have this stuff in as it can be unclear why a method has been added, what need it fulfills. However having said that I would expect Increments method descriptions to be very straight forward.
I am not sure about the ci issue, I am looking into it. In the mean time, could you please provide a cylc review link to a run of mo-bundle? To run the build and test inside a workflow you can use bin/bbb ctest <workflow-name>.

That ought to be correct. For more details you can check docs here:
https://github.com/MetOffice/mo-bundle?tab=readme-ov-file#rose-stem-workflow-usage
Have you introduced any new dependencies? I am not sure why you would see an MKL error. Either it is there on develop or something to do adding saber would be my guess?

Closing this PR. See PR #88 for continuation.


Does not work android platform

Module is required without error, but while calling any function, procedure does not go ahead. It is just stuck there.
For example, in following execution step 2 is never logged.
console.log('step 1')
let osInfo = await si.osInfo()
console.log('step 2')

Tested with node v12.
Edit : Just realised that docs clearly lists supported OS which does not include android. This is not actually bug but would like to explore how to make it supported for android. Thank you for great lib.

Duplicate of https://github.com/sebhildebrandt/systeminformation/issues/211


devon/refactor → develop

I suppose this maybe deserves a version bump?

I shouldn't have been able to approve this PR by myself lol.
@GitNickProgramming I think branch protection settings need to be fiddled with some more.


SourceKit: Refactor Kinds UIDs to ProtocolUIDs.def. NFC

"Kind" is a frequently appearing concept in SourceKitD. This patch
refactor the definitions of these "Kinds" and their associated values
into the single protocol file. Ideally, we should structurally define Kinds instead of this
flat list.

@swift-ci please smoke test


Parsing response body with error description is not accurate

I created a card with in-eligible PAN<PHONE_NUMBER>111237 according to the doc
Request gist
And as expected I got in-eligible error:
{
	"path": "/tokenizations",
	"status": 400,
	"summary": "PAN ineligible",
	"description": "The credit card number provided is not eligible for this service.  Please contact your card issuer for assistance.",
	"details": "Card not eligible",
	"created": "2018-05-16T13:46:42.365Z"
}

but the code from NSDataExtensions.swift doesn't support this body format
    var errorMessages: [String]? {
        var messages: [String]? = []

        guard let dict: [String: Any] = self.dictionary,
            let errors = dict["errors"] as? [[String: String]] else {
                return messages
        }

        for error in errors {
            if let message = error["message"] {
                messages!.append(message)
            }
        }

        return messages
    }

@SergeyKovalenko Can you post the code you are using to try and get errorMessages?

I have this code for creating a credit card:
  public func create(card: CardInputData, for user: User) -> Observable<Card> {
    return shared { observer in
      user.backedUser
        .createCreditCard(pan: card.pan,
                          expMonth: card.expMonth,
                          expYear: card.expYear,
                          cvv: card.cvv,
                          name: card.name,
                          street1: card.street1,
                          street2: card.street2,
                          street3: card.street3,
                          city: card.city,
                          state: card.state,
                          postalCode: card.postalCode,
                          country: card.country) { (card, error) in
                            card.map {
                              observer.onNext(Card(with: $0))
                              observer.onCompleted()
                            }
                            error.map { observer.onError(FitPayRestErrors.fitPayError($0)) }
      }
      return Disposables.create()
    }
  }

here I use completion handler to retrieve error or result
/**
    Completion handler

    - parameter creditCard: Provides credit card object, or nil if error occurs
    - parameter error:  Provides error object, or nil if no error occurs
    */
   public typealias CreditCardHandler = (_ creditCard: CreditCard?, _ error: NSError?) -> Void

The card:  CardInputData I used to simulate the case is next:
Printing description of card:
▿ CardInputData
  - pan : "9999311111111237"
  - expMonth : 11
  - expYear : 2018
  - cvv : "123"
  - name : "Serge Kovalenko"
  - street1 : ""
  - street2 : ""
  - street3 : ""
  - city : ""
  - state : ""
  - postalCode : ""
  - country : ""

and when I print out the error I see:
(lldb) e error!.description
(String) $R1 = "Error Domain=RestClient Code=400 \"(null)\""

Here is my stack trace http://take.ms/YG3uI


Fix deep link routes for sub-report pages

Details

This PR fixes an uncovered edge case for https://github.com/Expensify/App/pull/14669, where we're getting navigating to the reportID when we should've navigated to its sub-report page (/settings, /details, etc.).
Fixed Issues

$ https://github.com/Expensify/App/issues/14994
Tests

Enter in the browser a sub-report page, e.g.:
https://staging.new.expensify.com/r/1242891003599332/details
https://staging.new.expensify.com/r/1242891003599332/participants
https://staging.new.expensify.com/r/1242891003599332/settings

On web just paste the URL in the browser (e.g: http://localhost:8080/r/1242891003599332/details for dev) and click on open this link in your browser
On desktop also paste the URL in the browser but click on Open Electron from the alert dialog
(Dev) On Android open the deep link from Terminal: npx uri-scheme open new-expensify://r/1242891003599332/details --android
(Dev) On iOS also open the deep link from Terminal: npx uri-scheme open new-expensify://r/1242891003599332/details --ios

Verify the correct chat is opened

[ ] Verify that no errors appear in the JS console

Offline tests

N/A since the behavior is the same as online if the app already loaded the chat reports into Onyx
QA Steps

Same steps from the Test section

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/6829422/217917223-7730e16e-9229-47c3-98ee-2eef0e70ab2d.mov

Mobile Web - Chrome

https://user-images.githubusercontent.com/6829422/217918949-2c121755-c290-4df7-ba00-3e3ccb531b7e.mov

Mobile Web - Safari

https://user-images.githubusercontent.com/6829422/217918721-31646b7b-7d27-4ee5-bdba-cb30640baed2.mov

Desktop

https://user-images.githubusercontent.com/6829422/217920517-6bf0c02f-7ed1-4932-956d-0406f9510269.mov

iOS

https://user-images.githubusercontent.com/6829422/217919943-5050f251-48d0-4b2a-870c-13a68b560578.mov

Android

https://user-images.githubusercontent.com/6829422/217920003-cc1654a7-dbd2-45f9-aef1-4c3a100031bd.mov

@mollfpr @youssef-lr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

There's an issue with navigation when pressing the back button from participants, or settings are not taking the route back to the details page, but I believe that will be addressed in the navigation issue.

Hi @mollfpr, I tried to reproduce it, but it's working fine for me:
https://user-images.githubusercontent.com/6829422/218605888-e7eb22a1-ed73-4e8e-912b-88b30c3f4ffc.mov

@marcochavezf go to the /participants or /settings from the deep link then press the back button.

@marcochavezf Try this, go to the /participants or /settings from the deep link then press the back button.

Ah I see, this happens with chat rooms. Yeah, this is not part of the regression, and I think we should address it in the navigation project because we'd need to manipulate the navigation history to push the room chat and its details page before the /participants or /settings page, so that when the user press the back button ("pops" the current view) the next view (details page) is shown.
@youssef-lr all yours :)

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.2.74-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.2.74-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Schedules for Non-Learning Rate Hyper-parameters

Is it possible to have schedules for hyper-parameters such as momentum?
For example, onecycle momentum from this paper: https://arxiv.org/abs/1708.07120. There are also benefits to using schedules for parameters like epsilon (as a trust-region / damping parameter), highlighted by this blog post: http://zna.do/epsilon.

Most of the current optimizers keep a step count in their state, so adding a schedule to their hyper-parameters would be straightforward. The signature for Adam, for example, could be changed from:
def scale_by_adam(b1: float = 0.9,
                  b2: float = 0.999,
                  eps: float = 1e-8,
                  eps_root: float = 0.0) -> GradientTransformation:

to
Schedule = Callable[[int], Union[float, jnp.ndarray]]

def scale_by_adam(b1: Union[float, Schedule] = 0.9,
                  b2: Union[float, Schedule] = 0.999,
                  eps: Union[float, Schedule] = 1e-8,
                  eps_root: Union[float, Schedule] = 0.0) -> GradientTransformation:

Then, within update, we would just need to do something like:
def update_fn(updates, state, params=None):
  count_inc = _safe_int32_increment(state.count)
  if callable(b1): b1 = b1(count_inc)
  if callable(b2): b2 = b2(count_inc)
  if callable(eps): eps = eps(count_inc)
  if callable(eps_root): eps_root = eps_root(count_inc)
  ...

I'd be happy to try contributing this if it seems reasonable.

Another option is to store the hyperparameters in the optimizer state, similar to this new proposed optimizer API for Flax, so users can explicitly change them as needed in the training loop. This has the added benefit of making logging these hyperpameters (e.g. to tensorboard) much easier.

Another possibility is to create a wrapper, like below:
class ScheduledTransformState(NamedTuple):
    count: jnp.ndarray  # shape=(), dtype=jnp.int32
    hparams: Dict[str, Any]
    inner_state: Any

def scheduled_transform(inner, **schedule):
    def schedule_fn(step):
        return {k: f(step) for k, f in schedule.items()}

    def init_fn(params):
        count = jnp.zeros([], jnp.int32)
        hparams = schedule_fn(count)
        return ScheduledTransformState(
            count=count,
            hparams=hparams,
            inner_state=inner(**hparams).init(params))

    def update_fn(updates, state, params=None):
        count_inc = _safe_int32_increment(state.count)
        hparams = schedule_fn(count_inc)
        updates, inner_state = inner(**hparams).update(
            updates, state.inner_state, params)
        return updates, ScheduledTransformState(
            count=count_inc,
            hparams=hparams,
            inner_state=inner_state)

    return GradientTransformation(init_fn, update_fn)

Example usage:
import optax

optimizer = optax.scheduled_transform(
    partial(optax.sgd, nesterov=True),
    learning_rate=optax.exponential_decay(...),
    momentum=optax.piecewise_constant_schedule(...))

This is much less intrusive (don't need to change existing transformations), easier to test, and more general than the other ideas above.

Any thoughts on this wrapper @mtthss?

I think the scheduled_transform wrapper probably should accept also fixed hypers without having to partial them
E.g. we could easily change it so that your example above would just become:
optimizer = optax.scheduled_transform(
    optax.sgd,
    nesterov=True,
    learning_rate=optax.exponential_decay(...),
    momentum=optax.piecewise_constant_schedule(...))

We would probably want to find a better name than scheduled_transform though :)

@avital

I agree with 2. I think supporting this behaviour is as simple as checking whether the argument is callable in schedule_fn:
def schedule_fn(step):
    return {k: (f(step) if callable(f) else f)
            for k, f in schedule.items()}

I agree with 3 as well, names are not my forté 😅 (the alternative name i was thinking of was optax.schedule, though this is not a particularly good name either since we now accept fixed hyper-parameters as well).
I think the name partial is interesting. My only reservation is that normal partial application accepts a Callable[..., ReturnType] and returns a Callable[..., ReturnType], whereas here we accept a Callable[..., GradientTransformation] and return a  GradientTransformation. I think if optax.partial returned a Callable[..., GradientTransformation], partial would be a more fitting name. What do you think?


Management of namespace names

Andy's current opinion: There will be so few namespace names that letting there be a kind of self-organizing governance of them seems fine.
For example, Python module names have a HUGE number of developers.  If there isn't chaos there, why is there no chaos?  Any articles linked to in comments on this issue would be welcome there.
We can perhaps encourage namespaces created by a company or individual to have a common prefix in its full name, e.g. 'intc_' for those published by Intel Corporation, or 'com.intel.'.  But it should be OK to have namespace names with no such prefix, too, e.g. 'stdheaders'.
It should be OK for full namespace names to be relatively long, since as long as we have the ability to create short local aliases for those long names in our P4 programs via statements like import <long_namespace_name> as lns; lets P4 developers use prefixes like lns. in their source code, and have those names have an explicit representation in their program what they mean "globally".

We could make the recommendation for reverse DNS names extremely strong by having namespaces like org.p4.core, org.p4.v1model, and org.p4.psa as some of the first ones.

The real question is not about what namespaces a developer uses, the question is about how the compiler looks for modules on the filesystem. If both you and I create a namespace X it is fine if the user can use both by having them in different places on the filesystem and importing them. You cannot separate the notion of module from the notion of filesystem organization.

The simplest effective approach here, I believe, is to have a P4PATH environment variable, and/or a command line argument, that defines an ordered list of directories, similar to an include path.  This path would be used for searching for modules on the local file system.


Improving usage of Sentry

Background

Proposed user journey

Approach

Questions / Assumptions

Acceptance Criteria

[ ] Enter text
[ ] Enter text
[ ] Enter text
[ ] Enter text

Reference
How to write good user stories

Stale aged out


Kubernetes-master - wait for apiserver to come up FAILED

When running ansible-playbook -e @security.yml mantl.yml
TASK: [kubernetes-master | wait for apiserver to come up] *********************
failed: [adam-mantl-control-02] => {"elapsed": 300, "failed": true}
msg: Timeout when waiting for <IP_ADDRESS>:8085
failed: [adam-mantl-control-01] => {"elapsed": 300, "failed": true}
msg: Timeout when waiting for <IP_ADDRESS>:8085
failed: [adam-mantl-control-03] => {"elapsed": 300, "failed": true}
msg: Timeout when waiting for <IP_ADDRESS>:8085

FATAL: all hosts have already failed -- aborting

Ansible Version (1.9.6)
Cloud Environment: vSphere
Terraform version (v0.6.16):

@adammy123 What do you see in the kubernetes logs?
sudo journalctl -u kubelet --no-pager

Jul 26 09:04:59 adam-mantl-control-01 kubelet[27954]: could not init cloud provider "vsphere": no vSphere cloud provider config file given
Jul 26 09:04:59 adam-mantl-control-01 systemd[1]: kubelet.service: main process exited, code=exited, status=1/FAILURE
Jul 26 09:04:59 adam-mantl-control-01 systemd[1]: Unit kubelet.service entered failed state.
Jul 26 09:04:59 adam-mantl-control-01 systemd[1]: kubelet.service failed.
Jul 26 09:05:09 adam-mantl-control-01 systemd[1]: kubelet.service holdoff time over, scheduling restart.
Jul 26 09:05:09 adam-mantl-control-01 systemd[1]: Started Kubernetes Kubelet.
Jul 26 09:05:09 adam-mantl-control-01 systemd[1]: Starting Kubernetes Kubelet...
Jul 26 09:05:09 adam-mantl-control-01 kubelet[27991]: E0726 09:05:09.919303   27991 server.go:286] Failed running kubelet: could not init cloud provider "vsphere": no vSphere cloud provider config file given

Just tons of these

@adammy123 Is this latest master? This looks like https://github.com/CiscoCloud/mantl/issues/1740

@adammy123 Does it look like https://github.com/CiscoCloud/mantl/pull/1743 is present in your environment?

@siddharthist how do i update it to the latest master?

@siddharthist oops, yes that solves it. thanks!


Perspective camera update

Add a listener on container resize for perspective camera update

 All committers have signed the CLA.


estimate_area doesn't indicate cases

It doesn't seem estimate_area-like functions indicate when no circle is found. That would be a nice addition. Happy to contribute with a little guidance here.
Assuming enum in common.hpp with additional return in fit_circle implementations would do.
https://github.com/charliebudd/torch-content-area/blob/e3b6254d4ee7d70ee84782d91ecae224ac8836f8/src/torchcontentarea/csrc/source/fit_circle_cpu.cpp#L162

The "confidence" in the found circle is returned with the circle parameters. Note this isn't a probability, I found 0.06 to be a solid value for the cut-off point. My intention was to default to returning the confidence for the user to implement the cut-off point. I do however currently pass a cut-off point down to the cpp extension, it's just currently ignored.

See here the horrible hardcoded cut-off value in the performance test

A nother note is that an edge confidence threshold is also passed down to the cpp extension, joined in a tuple with the circle threshold. This is made use off for discarding invalid points.

Hm okay will investigate that a little keeping these aspects in mind.


File exchange

Hi,
Is there any example demonstrating file exchange using PeerKit? Stackoverflow is almost empty concerning PeerKit unfortunately.
Thanks.

Hi,
No help about that?


Can't shim 'bin\octave.bat'

It seems to be this bug is related to #2534
I'm trying to install octave, and here what do I get:
scoop install octave
Installing 'octave' (5.1.0) [32bit]
octave-5.1.0-w32.zip (447,1 MB) [=============================================================================] 100%
Checking hash of octave-5.1.0-w32.zip ... ok.
Extracting octave-5.1.0-w32.zip ... done.
Linking ~\scoop\apps\octave\current => ~\scoop\apps\octave\5.1.0
Creating shim for 'octave'.
Can't shim 'bin\octave.bat': File doesn't exist.

I assume, as previously they have moved from bin\octave.exe to bin\octave.bat, now they have moved even further somewhere... Not sure, maybe bin\octave-cli.exe.

Introduced by 1e00b5f76148f5e646f5e79d50aac18fe4c9f9ef

It's moved to mingw32\bin\octave.bat or mingw64\bin\octave.bat now according to post-install.bat

Thanks! I was not sure where to look, but now I can try to create PR for that.