Questions that actual documentation does not answer...

Hi, I am using this module as a component in a migrator. I have a few questions:
If I want to pass a variable as an argument to the lexer is it possible? How?
From the documentation I think I understood how start conditions are used but I am missing something: suppose I have two sets of rules in the same lexer, when one set is alive the other is sleeping, and then there is a token that triggers the switch and I want put the sleeping set alive, how do I do that in code?
TIA
jcr

Sorry, one more question, how do I have access to the parts of the string that matched marked parts of the regular expression?
Example, consider the following RegExp: /\def:([a-z][a-z]+)=(.+);/
I want to manipulate strings that matched ([a-z][a-z]+)  and (.+)
I could use start conditions and split the RegExp but other languages and tools let me use $1, $2, …, to access parts.
Can I do it with your tool?
TIA
Jose Carlos Ramalho
Dep. Informatics
University of Minho
http://www.di.uminho.pt/~jcr

On 17 Jan 2018, at 04:34, Aadit M Shah<EMAIL_ADDRESS>wrote:
Yes, it should be in the documentation. Must have slipped my mind. I'll add it in. Anyway, if your lexer needs to query some local variable then it should be defined in the context of that local variable. This can be done using a lexer factory as follows:
function lexerFactory(dataStructure) {
var lexer = new Lexer;
lexer.addRule(someRegex, function (lexeme) {
    // do something with dataStructure
});

return lexer;

}
Now, when you get access to your local data structure you can create a new lexer that uses it as follows:
function innerContext() {
var dataStructure = /* initialize new data structure */;
var lexer = lexerFactory(dataStructure);

// use lexer, return it or whatever

}
There's no good reason to pass a variable as an argument to the lexer because that creating tight coupling https://en.wikipedia.org/wiki/Coupling_(computer_programming) between the lexer module and the module using the lexer. Instead, if the lexer needs to use some variable then it should simply be defined in the context of that variable. Hopefully, this answers your second question too. If the lexer is going to use some variable then initialize that variable before defining the lexer.
When the end of the input is reached, calling lexer.lex returns undefined. Hence, when lex returns undefined simply call the function you want. Oh, and I'd be happy to see the coding exercises for your compiler construction class.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/aaditmshah/lexer/issues/17#issuecomment-358194522, or mute the thread https://github.com/notifications/unsubscribe-auth/AHC71wyuaVGRqHZl7HE-kpHOnY2_Y555ks5tLXhqgaJpZM4RbdaW.


Bug Report: @foo in message doesn't tag someone

If you send a message with @lukepighetti.bsky.social hello! with bluesky_cli it will not actually link, it just comes in as plain text

Hey @lukepighetti !
Interestingly, it does not interpret automatically like Twitter or Mastodon! We need to set facet parameter to make the mentions work, but this CLI does not support this param yet.
https://github.com/bluesky-social/atproto/blob/main/lexicons/app/bsky/feed/post.json
https://github.com/bluesky-social/atproto/blob/main/lexicons/app/bsky/richtext/facet.json
I will support it with other parameters soon, but if you want to try it out right away, please use the Bluesky  package! :)
https://pub.dev/packages/bluesky

Or, I would automatically extract the mentions from the text and tie them to the profile. Perhaps this is easier to use :)

Hi @lukepighetti ,
Fixed to automatically extract and resolve mention and link from text, and already released as v0.1.2 :)


Failed to use fixed version "python3.4 -m pip-review"

Console says “No module named pip-review”.
Installed log:
python3.4 -m pip install pip-review
Collecting pip-review
  Using cached pip-review-0.4.tar.gz
Installing collected packages: pip-review
  Running setup.py install for pip-review ... done
Successfully installed pip-review-0.4

(I edited your post for better formatting. Use triple backticks to format multiline code. Thank you.)
Python 3 is still unsupported, unfortunately. However, it is on my wish list.

$ which pip-review
/Library/Frameworks/Python.framework/Versions/3.4/bin/pip-review
Mar:2.7 Tension$ python2 -m pip list
gfwlist2pac (1.1.3)
pip (8.1.2)
pip-review (0.4)
setuptools (20.9.0)
$ python2 -m pip-review
/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python: No module named pip-review
$ pip2 --version
pip 8.1.2 from /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages (python 2.7)

I have multi-version python installed. I can't use pip-review like pip with "pythonx.x -m package-name".
It can be a package which can be executed.

As of version 0.5, pip-review is also installed as a module under the name pip_review (note the underscore instead of the dash).


eliqonline library upgrade

Description:
Non critical update of dependency
(the only change in new version of library is the API endpoint URL, but the old URL will still be alive for a while)
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

From the PR description:

Of course, sorry!


Fix tooling model caching when tooling API build action may run tasks

Fixes #?
Context
This allows the feature to be used with Android Studio and IDEA.
This PR changes the configuration cache layout to store task graphs and models in separate files. It also tweaks the build lifecycle to ensure that the "configure successful" banner is logged when a model is reused from the cache.
Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

OK, I've already triggered a build for you.


python310Packages.babel: 2.10.3 -> 2.11.0

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Thank you for doing this. I noticed that tests on darwin were disabled in https://github.com/NixOS/nixpkgs/commit/e3065afa4434bf19fd61e89f05145b5a868310b6 three years ago, but they pass locally for me on my aarch64-darwin machine. If you have bandwidth, could you try enabling them again? If not, I can work on it after this is merged.

enabled the tests again


Promotions / Enhancements

Promotions could do with a round of enhancements.  This ticket is a work in progress to gather notes on things to do.
Notes:

There is a banner.html template that doesn't seem to be used.  Also there's JS trying to initialise it.

Tasks:

[ ] Make product lookups use AJAX and autocomplete in single product and multi-product dashboard forms
[ ] Add support for banners
[ ] Add support for countdown blocks
[ ] Ensure promotions render correctly in sidebars
[ ] Add support for tabbed blocks
[ ] Review templates to ensure there isn't duplication that could be solved with partials.

Closing this, since promotions being extracted into the separate package in terms of #2215


Opening a modal from an action sheet is broken

Title says it all.
I'm able to resolve this issue by adding return false; to the handler, but that's inconvenient for the user since they would have to close down that action sheet manually every time.
Opening the modal does add it to the DOM, it just messes up it's properties so it's not visible. I am only able to interact with that invisible modal once it's opened, I can't click on anything that I actually see.
Here's a GIF without a return false;

Here's another GIF with return false;

Steps to reproduce:

Create an action sheet
Set the action of one of the options to open a modal

2.0-beta.8
http://plnkr.co/edit/xpW62L9RJGIO13eqhj89?p=preview

Dismissing And Async Navigation

Thank you @xr0master !

Little fix
goToPage1() {
	  let actionsheet = ActionSheet.create({
	    title: 'Options',
	    buttons: [
	      {
	        text: 'click me',
	        handler: () => actionsheet.dismiss().then(() => this.nav.present(Modal.create(Page1)))
	      }
	      ]
	  });
	  this.nav.present(actionsheet);
	}

Thanks :D !

Thanks @xr0master. this fix my issue. I don't have this issue on chrome or recent phone, but ONLY on old phone (KitKat 4.4). On old phone, we can see that the modal is "stuck" during the transition (like 90% transparent).
I have many issues with low-end phones and I feel like ionic2 is not meant to work on low-cost devices (but more of 50% of users have low-end devices....)

Hello @Geoffrey-D ! Have you given crosswalk a try? This will give you a fast, modern chrome webview even on devices running older versions of Android. We've seen huge performance increases on older android devices with it. Also if you have a lower end device that is running Android 5.0 and up you will automatically have the latest chrome webview as it gets updated separate of Android itself. Thanks for using Ionic!

Hey @jgw96, I know that crosswalk would fix many issues. But this icrease a lot the app size. Is ionic 2 supposed to work with low end devices (like 2GB RAM, Android 4.4)?! Because if the solution to work with the 50% of the users is to use crosswalk, it should me mentionned on the ionic 2 website. I know it is still an alpha, but I am a bit afraid to see that we need to do tricky stuff to support (not that) old devices.

@Geoffrey-D Definitely understand your concerns! Actually, the above solution is not just the solution for older android devices, instead that is the proper way to do navigation in Ionic 2 no matter what device it is running on. Sorry for any confusion on that! Also we talk about our browser support here in our docs, although im talking to the rest of the team to see if we can make this more visible and easier to find. Finally, we are currently in beta (beta.11) and not alpha. Thanks for using Ionic!

@jgw96 thx for that answer. I will give crosswalk a try and see what improvement it gives :) anyway thx for that very nice tool!

No problem! 😃


Support wider range of slurm ids

Is your feature request related to a problem? Please describe.
When submitting a job array, slurm gives the job the id 123456_1, 123456_2...
Describe the solution you'd like
Widen the supported types of job id from integer to string. Should still be a UUID as slurm outputs the ids.
Describe alternatives you've considered
Not supporting these jobs
Additional context
May need to rework if the full id is not immediately available. e.g. slutil submit --batch ...

Package this up into a later release adding support for array jobs


feat: calculate FunctionSelectors and EventSelectors during comptime

Please read contributing guidelines and remove this line.

Benchmark results
Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,388 (+81%)
avm_simulation_time_ms (Token:mint_public): 468 (+853%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 46.6 (-90%)
avm_simulation_time_ms (FPC:prepare_fee): 77.8 (-61%)
avm_simulation_time_ms (Token:transfer_public): 27.6 (+97%)
avm_simulation_bytecode_size_in_bytes (Token:transfer_public): 10,812 (-50%)
protocol_circuit_proving_time_in_ms (undefined): 109,672 (+26%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,756
1,563
716
744 (-2%)
774

proof_construction_time_sha256_30_ms
11,472
3,098
1,378 (-1%)
1,429
1,467 (+1%)

proof_construction_time_sha256_100_ms
44,187
11,872
5,494 (+1%)
5,535 (-2%)
5,650

proof_construction_time_poseidon_hash_ms
78.0
34.0 (-3%)
34.0
59.0
87.0 (-2%)

proof_construction_time_poseidon_hash_30_ms
1,527
422
204
224 (-3%)
268

proof_construction_time_poseidon_hash_100_ms
5,643
1,514
679 (+1%)
737 (+3%)
747 (+1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
4,356
7,876
14,884

l1_rollup_calldata_gas
50,232
92,996
178,144

l1_rollup_execution_gas
843,051
1,576,711
3,361,915

l2_block_processing_time_in_ms
252
447
809 (-1%)

l2_block_building_time_in_ms
11,222 (+1%)
22,059
43,935 (+1%)

l2_block_rollup_simulation_time_in_ms
11,221 (+1%)
22,058
43,935 (+1%)

l2_block_public_tx_process_time_in_ms
9,576 (+1%)
20,388
42,234 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
2,968 (-2%)
3,955 (+1%)

node_database_size_in_bytes
12,607,568
16,658,512

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
simulation_time_in_ms
witness_generation_time_in_ms
input_size_in_bytes
output_size_in_bytes
proving_time_in_ms

private-kernel-init
78.6 (+6%)
385 (+1%)
21,391
44,898
N/A

private-kernel-inner
156 (-2%)
681 (+1%)
72,372
45,020
N/A

private-kernel-reset-tiny
294 (-1%)
706 (-3%)
65,097
44,886
N/A

private-kernel-tail
160 (+1%)
133 (+2%)
50,608
52,921
N/A

base-parity
5.55 (-1%)
N/A
160
96.0
N/A

root-parity
35.2 (+1%)
N/A
73,948
96.0
N/A

base-rollup
3,083 (+4%)
N/A
189,193
664
N/A

block-root-rollup
41.2 (+1%)
N/A
58,205
2,448
N/A

public-kernel-setup
82.5 (+1%)
N/A
105,085
71,222
N/A

public-kernel-app-logic
94.5
N/A
104,899
71,222
N/A

public-kernel-tail
844
N/A
390,582
16,414
N/A

private-kernel-reset-small
297
N/A
66,341
45,629
N/A

private-kernel-tail-to-public
:warning: 1,388 (+81%)
595 (+1%)
453,751
1,825
N/A

public-kernel-teardown
82.4 (+3%)
N/A
105,349
71,222
N/A

merge-rollup
20.1
N/A
38,174
664
N/A

undefined
N/A
N/A
N/A
N/A
:warning: 109,672 (+26%)

Stats on running time collected for app circuits

Function
input_size_in_bytes
output_size_in_bytes
witness_generation_time_in_ms

ContractClassRegisterer:register
1,344
11,731
347 (+2%)

ContractInstanceDeployer:deploy
1,408
11,731
18.1

MultiCallEntrypoint:entrypoint
1,920
11,731
402 (+1%)

FeeJuice:deploy
1,376
11,731
393 (+2%)

SchnorrAccount:constructor
1,312
11,731
62.6 (+1%)

SchnorrAccount:entrypoint
2,336
11,731
370 (-1%)

FeeJuice:claim
1,344
11,731
36.3 (+1%)

Token:privately_mint_private_note
1,280
11,731
75.7 (-3%)

FPC:fee_entrypoint_public
1,344
11,731
26.7 (-1%)

Token:transfer
1,312
11,731
213 (-1%)

Benchmarking:create_note
1,344
11,731
74.6 (-1%)

SchnorrAccount:verify_private_authwit
1,280
11,731
29.9 (+13%)

Token:unshield
1,376
11,731
506 (+1%)

FPC:fee_entrypoint_private
1,376
11,731
663 (-10%)

AVM Simulation
Time to simulate various public functions in the AVM.

Function
time_ms
bytecode_size_in_bytes

FeeJuice:_increase_public_balance
44.6 (-2%)
2,431

FeeJuice:set_portal
14.6 (+11%)
2,930

Token:constructor
80.2 (+7%)
15,813

FPC:constructor
47.8 (-4%)
9,720

FeeJuice:check_balance
36.8 (-1%)
2,357

Token:mint_public
:warning: 468 (+853%)
5,011

Token:assert_minter_and_mint
:warning: 46.6 (-90%)
3,155

AuthRegistry:set_authorized
36.6 (+4%)
924

FPC:prepare_fee
:warning: 77.8 (-61%)
4,245

Token:transfer_public
:warning: 27.6 (+97%)
:warning: 10,812 (-50%)

FPC:pay_refund
46.1 (+10%)
5,195

Benchmarking:increment_balance
1,203
3,496

Token:_increase_public_balance
40.1 (+5%)
2,408

FPC:pay_refund_with_shielded_rebate
54.3 (+4%)
5,195

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.155 (+1%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.13 (-1%)
3.88 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.111
0.109
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.0
17.5
30.5 (+1%)
59.6 (-1%)
112 (-1%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.106
0.102
0.0995 (+1%)
0.102 (-1%)
0.100

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.2
25.2 (-2%)
43.1 (+1%)
82.3 (-1%)
158 (-2%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
108
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.109
0.101 (-1%)
0.101 (-2%)
0.102 (-1%)
0.0999 (-1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
16.5
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
132
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.106
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
64,838
668,997

Transaction size based on fee payment method
| Metric |  |
| - |  |

Bravo!


#666 support css variables

This is most likely unacceptable as far as size goes, but I wanted to get the process started.
Note that PhantomJS does not support cssText with custom properties in it. No idea what to do about this other than to drop css vars from that test.
fixes #666

Coverage remained the same at 100.0% when pulling 8a8e6852d6b3260baecafde395f876e055474d9f on tkh44:666-support-css-variables into 0dea3b77ee0677987815347c1e6bd23821728aa2 on developit:master.

Awesome.
Regarding the testing, it's probably a good time to switch the default launcher to be Headless Chrome, I don't really use Phantom for Preact anymore since the performance numbers are unreliable.

Coverage remained the same at 100.0% when pulling 7273c8106e852e5ba45286487651207268bcae18 on tkh44:666-support-css-variables into 0dea3b77ee0677987815347c1e6bd23821728aa2 on developit:master.

the bundle size thing didn't kick in, but it looks like this goes from 3444 -> 3482 (+38b).  Honestly that's not too bad, and I really want CSS variables support.

do you think style.setProperty('--foo', '') would work like style.removeProperty('--foo')?

It works fine. According to the spec this should work style.setProperty('--foo'), but it errors in chrome. style.setProperty('--foo', '') works fine though.

Coverage remained the same at 100.0% when pulling b98bc18008991b8c726d55a5cec54dd4e6bac9b9 on tkh44:666-support-css-variables into 0dea3b77ee0677987815347c1e6bd23821728aa2 on developit:master.

Coverage remained the same at 100.0% when pulling 7cbcc0d48052fb80e51b976297b8ada68a882c7f on tkh44:666-support-css-variables into 56455738e5550d493cb9a32588ac724730dc3d55 on developit:master.

What about using the ternary operator ?
	 ~i.indexOf('-')
		 ? node.style.setProperty(i, value[i])
		 : node.style[i] = typeof value[i]==='number' && IS_NON_DIMENSIONAL.test(i)===false
			? (value[i]+'px')
			: value[i];

@tkh44 Do we need the if checks at all? I removed the if statements (shown below) and the PR size was reduced by 17 bytes, so its size is now only +9 bytes on top of master. All tests pass. I quickly checked in a handful in browsers and I think this should work. It appears setProperty doesn't throw an error on invalid property names (which will happen if a component defines something like backgroundColor like you've pointed out).
if (value && typeof value==='object') {
	if (typeof old!=='string') {
		for (let i in old) if (!(i in value)) {
			node.style.setProperty(i, '');
			node.style[i] = '';
		}
	}
	for (let i in value) {
		node.style.setProperty(i, value[i]);
		node.style[i] = typeof value[i]==='number' && IS_NON_DIMENSIONAL.test(i)===false ? (value[i]+'px') : value[i];
	}
}

@andrewiggins that should work. There was a bug in the older code that I just realized.
typeof value[i] ===
				'number' &&
				IS_NON_DIMENSIONAL.test(i) === false ? (value[i] + 'px') : value[i])

needs to be in both the setProperty and the assignment.
abstracting it would look like
function a(b) { typeof b ===
				'number' &&
				IS_NON_DIMENSIONAL.test(i) === false ? (b + 'px') : b)

Not sure where this puts us in terms of bytes.

Closing, we finally have support for css variables in Preact X 🎉💯


Implement management of autocmds via legendary.nvim

Resolves #23

@tsyroid I'd love some feedback on how to make the README.md updates better/more clear

going to go ahead and merge this, opened #28 for better docs


[FEA] Link Top-k evaluation to ItermRetrievalModel blocks.

🚀 Feature request

Compute ranking metrics during the evaluation of ItermRetrievalModel.
We need to retrieve the candidates embeddings from the item-block of the ItermRetrievalModel in order to use them as implicit negatives for top-k ranking metrics.

Motivation

The objective is to be able to track the validation metrics after each epoch of training and use these metrics for Hyper-tuning and research experiments.

Your contribution

closed by #189


Update jobs.md

Fixed broken links

I signed it
On Wed, Aug 10, 2016 at 3:00 AM googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the
company's name.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes.github.io/pull/1005#issuecomment-238728966,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaGY_GEz1amKbzYRguHC2fQxKt1qA5Uks5qeRSkgaJpZM4JgpFi
.

LGTM

Thanks for the contribution @ronniemaor!


Ability to exclude routes/route-sections from SSR

Summary
The ability to exclude routes/route-sections from SSR (and instead have them function as a normal SPA).
Basic example
api.createPages(({ createPage }) => {
   createPage({
      path: '/:userId/settings',
      component: './src/templates/UserSettings.vue',
      ssr: false
   })
})

Motivation
A Gridsome project I'm working on that is having quite a number of Webpack hydration issues in an "authenticated-only" section of the site (noticed after solving quite a number of build issues related to the same problems). In my mind, this "authenticated-only" section should function as a traditional SPA. All of the data in this section is fetched at runtime (since it needs to be 100% up-to-date) and the routes are 100% dynamic. Unless I'm missing something, trying to SSR these pages is only bringing headache. Being able to fully exclude these routes from SSR (and have them function as a normal SPA) would be wonderful. Am I missing anything here? Would others not also find this useful?
Other issues that would potentially be solved by this:
https://github.com/gridsome/gridsome/issues/731#issuecomment-539509318
https://github.com/gridsome/gridsome/issues/616

How are you fetching data in ./src/templates/UserSettings.vue? Gridsome should be able to generate minimal markup for it if you only do client-side fetching in the mounted hook.
But having the possibility to not generate markup for some routes could be useful in some use cases.

The data is coming from a Vuex store (using mapState).
Essentially, I have an accountSettings layout that a handful of templates use. An account has a user and a user belongs to multiple teams. In the accountSettings layout there's navigation to the currently-selected team (and the ability to change the currently-selected team). Thus, the links in this navigation are dynamic (this is one of the areas that's causing hydration issues).

There's guidance for users of plugins that need an SSR override now in the documentation: https://gridsome.org/docs/assets-scripts/#without-ssr-support

Same need here. I'm doing a JAMStack app where public & marketing pages need SEO/SMO but where app pages are all authenticated and do not need pre-rendering at all since they are authenticated. Adding them to the generation, especially on large apps will just add more build time for nothing. It would be very interesting to have an exclude option in the gridsome.config.js
Somthing similar to: https://nuxtjs.org/api/configuration-generate#exclude
Also, what's query's options here: https://gridsome.org/docs/pages-api/#findandremovepagesquery


Usage model update needed

API changes this year included usage model updates. There are two new ones and we need to edit this page accordingly. In the GET usage models API call, we will return only the 2 “new” usage models: READ_ONLY and READ_WRITE. The old usage models will still be accepted, but will not appear in the list.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 875b7110-ade0-1937-3119-2ea1953f34d4
Version Independent ID: 66b3b8d4-13b8-f4e2-edd7-2b5432467442
Content: Azure HPC Cache usage models
Content Source: articles/hpc-cache/cache-usage-models.md
Service: hpc-cache
GitHub Login: @ekpgh
Microsoft Alias: rohogue

@aeb5005
Thanks for your feedback! We will investigate and update as appropriate.

Changes pushed today. Changes should be visible in the next 12-24 hours.

Updates are now live.
https://learn.microsoft.com/azure/hpc-cache/cache-usage-models

@aeb5005
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation


update meson build files

I'm going to update meson build files acc to v0.10, are there any extra files excluding those of src folder that I need to take care of?

They are in src yes. Is it possible to move that meson file out of the src folder? No big deal but it would be nice to only have sources there.

I will try tomorrow and see if it's possible. should be or otherwise I'll use some glob pattern over the directory for all *.cpp files 👍

The following code inside echo example -
#include <uWS.h>

int main()
{
    uWS::Hub h;

    h.onMessage([](uWS::WebSocket<uWS::SERVER> ws, char *message, size_t length, uWS::OpCode opCode) {
        ws.send(message, length, opCode);
    });

    h.listen(3000);
    h.run();
}

used to wait for incoming connections. Now it just exists... is this intentional?

h.listen() might return true if the listen failed, then it will just fall through just as before. The diff is that you are not getting an exception thrown now so I guess you just missed the error checking.

Well, I wrote it so, I missed to check for error :sweat_smile:

h.listen() might return true if the listen failed

wait.. true for error? shouldn't it be false?
And I tried wrapping whole code into a try{}catch(...){} block but it didn't throw any exceptions. Ofcourse changing port to something random worked 😄

This version doesn't throw any exceptions. The return code of everything follows the zlib/OpenSSL/Unix model of returning false (aka 0) on success and true (aka not 0) on error.

Well, maybe I messed up the return of listen, I don't know. Cannot keep track of it anymore. But yeah it should follow the Unix model. Will have to fix that up.

So, like process exit codes, from what I'm understanding. If so, that makes sense, as you could "customize" the error codes.

They still don't throw true as in 1 for error, usually they have some global variable which is set as -ve numbers for errors. You might need to document that explicitly because listen throwing false in case of success seems slightly confusing at first haha.

Huh? Exit code 1 is a catch-all exit code... or are we not talking about the same thing?

I wasn't talking about unix process as such but unix methods involving networking? eg socket() or bind() call? Process exit code shouldn't really apply to method exit codes I guess, and that method returns bool so 0 or 1.

$ man 2 bind

BIND(2)
NAME
       bind - bind a name to a socket

[...]

RETURN VALUE
       On success, zero is returned.  On error, -1 is returned, and errno is set appropriately.

Yes that's what I'm saying, on success 0 and on error some -ve number with global set.

Ah, you had me confused for a bit about -ve, you meant negative number. I see.

@alexhultman I would still recommend reconsidering if not all but some methods for their return values, eg if I had to modify that original program to exit with 1 in case of listen fails, it would look like this -
#include <uWS.h>

int main()
{
    uWS::Hub h;

    h.onMessage([](uWS::WebSocket<uWS::SERVER> ws, char *message, size_t length, uWS::OpCode opCode) {
        ws.send(message, length, opCode);
    });

    if(h.listen(3000)){
       return -1;
    }

    // or

    auto res = h.listen(3000);
    if(res){
       return -1;
    }

    h.run();
}

Even if I change res to fail as -
auto fail = h.listen(3000);
    if(fail){
       return -1;
    }

it will definitely confuse new user since why would h.listen() return fail at first. Rest I respect your choice though previous interface with exceptions was my fav 😸

Just my 2 cents.  I much prefer code that never throws exceptions.
As for what the return codes should be,  I'm ambivalent as long as they are
consistent and intuitive.
On Oct 5, 2016 10:36 PM, "Abhinav Gauniyal"<EMAIL_ADDRESS>wrote:

@alexhultman https://github.com/alexhultman I would still recommend
reconsidering if not all but some methods for their return values, eg if I
had to modify that original program to exit with 1 in case of listen fails,
it would look like this -
#include <uWS.h>
int main()
{
uWS::Hub h;
h.onMessage([](uWS::WebSocket<uWS::SERVER> ws, char *message, size_t length, uWS::OpCode opCode) {
    ws.send(message, length, opCode);
});

if(h.listen(3000)){
   return -1;
}

// or

auto res = h.listen(3000);
if(res){
   return -1;
}

h.run();

}
Even if I change res to fail as -
auto fail = h.listen(3000);
if(fail){
return -1;
}
it will definitely confuse new user since why would h.listen() return
fail at first. Rest I respect your choice though previous interface with
exceptions was my fav 😸
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/uWebSockets/uWebSockets/issues/267#issuecomment-251791979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGQZ0nDmHV2gZUE-s0hf_klsvYRFzGVKks5qxApegaJpZM4KO4AY
.

Ha, current implementation is correct imo, listen returns true for success and not false - https://github.com/uWebSockets/uWebSockets/blob/master/src/Hub.cpp#L62

Lol I need to swap that then. Hub::listen should return like Node::listen aka 0 for success and anything else for failure.

okay.


[Program]: Write a Kotlin program to print number to words

Description
Write a Kotlin program to print number to words
Input  : 123456789
Output : One Hundred Twenty Three Million Four Hundred Fifty Six Thousand Seven Hundred Eighty Nine

How to contribute

Save the solution in program/program/print-number-to-words/program/PrintNumberToWords.kt file

!assign


Texts are broken with buffered tiles

Migrated from @jaakla original https://github.com/tangrams/tangram-es/issues/1674:

Use vector tiles which have buffer, e.g. OpenMapTiles or Mapbox mbstreets.
Try to render texts
You'll see that texts which are in buffer (outside tile borders) are rendered in seemingly random places outside tiles (maybe tile center?). We see even country names here far away from the real object borders ("Eesti"=Estonia is in Lithuania and Belarus).

RESULT:

EXPECTED RESULT:
No wrong placement and duplicated texts.
ENVIRONMENT:
Tangram Play, CARTO vector tiles with OpenMapTiles schema and buffers. See yml in screenshot.
Data source:
sources:
    carto:
        type: MVT
        url: https://cartobase-1.global.ssl.fastly.net/vectortiles/carto.streets/v1/{z}/{x}/{y}.mvt
        max_zoom: 14

OTHER:
Tried varying buffer: parameter for texts, it affects texts renderings, but does not fix or even improve it really.
Same issue was also mentioned in comment of #1580 and commented by @nvkelso . Added this here as separate issue, as it makes base map rendering with Tangram and none-mapzen tiles impossible in practise.

@nvkelso said:
I agree this is a separate issue than #1580, thanks for filing!

@bcamper said:
Thanks - it looks like this specific issue references JS/Tangram Play, so would be better to track as a Tangram JS issue under https://github.com/tangrams/tangram.
That said, what geometry type is in the places you are labelling? Labels applied to polygons will render in the polygon centroid, which (unfortunately) for tiled data, often means... the center of the tile. We generate explicit point geometries for labelling where necessary in Mapzen tiles. Is this possibly happening here, or have I misunderstood?
Is the rendering substantially different if buffer: 0px, or when rendering the same data on non-buffered tiles?

@nvkelso said:
It'd also be helpful to see your YAML file, or at least your sources block and the places layer block drawing those text labels.

Then @jaakla commented in the old issue again (whoops):
The geometry is Point, not polygon. I think the Point is in different tiles, but in one of them it is within bounds (0..4096 pix), but in the others it is probably repeated in the "outside buffer", i.e. with coordinates <0 or >4096. As result Tangram seems to try to render somewhere within that tile, maybe center, but always in some very wrong location.
Changing buffer from 0px looks quite different, but still very wrong. See video: https://drive.google.com/file/d/0B3Rm1qU6KnySVW9lWFZPR1ExRXc/view?usp=sharing
The YAML:
sources:
    carto:
        type: MVT
        url: https://cartobase-1.global.ssl.fastly.net/vectortiles/carto.streets/v1/{z}/{x}/{y}.mvt
        max_zoom: 14
place:
        data: { source: carto}
        filter: {class: country, $zoom: {min: 3}}
        draw:
            text-blend-order:
                priority: 1
                text_source: name
                buffer: 1px
                font:
                    size: [[13, 9px], [14, 10px], [15, 11px], [16, 12px], [17, 13px]]
                    fill: global.med_text
                    family: Montserrat
                    weight: normal
                    stroke: { color: global.minor_halo, width: 2 }

@jaakla I suspect this is a JS versus ES difference. Have you tried the same style on ES, does it just work?
There is a Tangram JS only property that may help preview on ES here:
https://mapzen.com/documentation/tangram/draw/#move_into_tile
That defaults to true, set it to false and see if you get better results?
I tried your sample YAML (adding missing layers: block intro) but it does't load for me at all in Tangram Play :\

Thanks, it seems that adding move_into_tile: false did help! Not sure about side-effects, as we don't have more labels in the style yet, but that's very promising.
p.s. I'm not sure how we can easily test with ES; should create we create a native app with it, or is there simpler way?

@matteblair probably has tips.
You can probably download the OS X demo app from http://ios.mapzen.com/tangram-osx-latest-debug.zip and then open your scene file YAML in the app (either File > Open or drag and drop the YAML file into the app window).

The OS X demo that Nathaniel linked is the best place to start. We also have instructions for building the desktop demo on OS X (https://github.com/tangrams/tangram-es/tree/master/platforms/osx) and Ubuntu (https://github.com/tangrams/tangram-es/tree/master/platforms/linux).

Just discovered that to get proper labels also buffer has to be adjusted, otherwise some country names are lost. With trial and error strange value -10 seems to give best results at least on zoom 6 and country names. See https://drive.google.com/open?id=0B3Rm1qU6KnySQ1JXc0dFSEE5WEE for video. Did not try with ES yet. Full YAML of the style attached.
cartotest.yaml.txt

Are the country labels that come into view at -10 and -20 the ones in the
buffer or the core part of the vector tile?
On Wed, Oct 4, 2017 at 11:51 PM, Jaak Laineste<EMAIL_ADDRESS>wrote:

Just discovered that to get proper labels also buffer has to be adjusted,
otherwise some country names are lost. With trial and error strange value
-10 seems to give best results at least on zoom 6 and country names.
See https://drive.google.com/open?id=0B3Rm1qU6KnySQ1JXc0dFSEE5WEE for
video. Did not try with ES yet. Full YAML of the style attached.
cartotest.yaml.txt
https://github.com/tangrams/tangram/files/1358244/cartotest.yaml.txt
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tangrams/tangram/issues/602#issuecomment-334374978,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0EO3hBofNkqKyzETxzJaP6Fhs30zmZks5spHyLgaJpZM4Pt4_K
.

Tangram JS (currently) does label collision on a per-tile basis, so it is not really able to support labels that are in the tile buffer region (since they can overlap with labels in adjacent tiles, without Tangram being aware).
Tangram ES does not have this issues, because collision is done in screen-space; we hope to move Tangram JS to this model eventually as well.
This is why Tangram JS has the move_into_tile option, which tries to pull the label to the closest point inside the tile bounding box (not ideal, but acceptable for some labels of larger areas). For tiles with text labels in a tile buffer region, it sounds correct to turn this off with move_into_tile: false.
Related, a negative value for buffer should likely not be allowed and will probably produce unexpected results. The buffer is applied to the sides of the collision box to expand it, but shrinking the collision box is not well defined. So a negative buffer is an oversight and we should remove this for consistent behavior.


Add cmd ut

Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Base: 17.11% // Head: 17.22% // Increases project coverage by +0.11% :tada:

Coverage data is based on head (e9d8117) compared to base (f462d7a).
 Consider uploading reports for the commit b491b44 to get more accurate results

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/reconstruct-run    #1760      +/-   ##
===========================================================
+ Coverage                    17.11%   17.22%   +0.11%
===========================================================
  Files                           58       58
  Lines                         5312     5312
===========================================================
+ Hits                           909      915       +6
+ Misses                        4275     4269       -6
  Partials                       128      128

Impacted Files
Coverage Δ

cmd/sealer/cmd/utils/cluster.go
6.74% <0.00%> (+6.74%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I found that "[feature/reconstruct-run]" had been merged into "main". Maybe you need to file a new pull request to main directly?

I found that "[feature/reconstruct-run]" had been merged into "main". Maybe you need to file a new pull request to main directly?

ok,no problem！

I found that "[feature/reconstruct-run]" had been merged into "main". Maybe you need to file a new pull request to main directly?

ok,no problem！


Value error when running DQN.fit

I tried teaching AI how to play breakout but my code crashes when I try to teach DQN model.
``
import gym
import numpy as np
import tensorflow as tf
from rl.agents.dqn import DQNAgent
from rl.policy import LinearAnnealedPolicy, EpsGreedyQPolicy
from rl.memory import SequentialMemory
from keras.layers import Dense, Flatten, Convolution2D
env = gym.make('ALE/Breakout-v5', render_mode='rgb_array')
height, width, channels = env.observation_space.shape
actions = env.action_space.n
episodes = 10
for episode in range(1, episodes + 1):
env.reset()
done = False
score = 0
def buildModel(height, width, channels, actions):
model = tf.keras.Sequential()
model.add(Convolution2D(32, (8, 8), strides=(4, 4), activation='relu', input_shape=(3,height, width, channels)))
model.add(Convolution2D(64, (4, 4), strides=(2, 2), activation='relu'))
model.add(Convolution2D(64, (3, 3), activation='relu'))
model.add(Flatten())
model.add(Dense(512, activation='relu'))
model.add(Dense(256, activation='relu'))
model.add(Dense(actions, activation='linear'))
return model
def buildAgent(model, actions):
policy = LinearAnnealedPolicy(EpsGreedyQPolicy(), attr='eps', value_max=1., value_min=.1, value_test=.2, nb_steps=10000)
memory = SequentialMemory(limit=1000, window_length=3)
dqn = DQNAgent(model=model, memory=memory, policy=policy,
enable_dueling_network=True, dueling_type='avg',
nb_actions=actions, nb_steps_warmup=1000)
return dqn
model = buildModel(height, width, channels, actions)
DQN = buildAgent(model, actions)
DQN.compile(tf.keras.optimizers.Adam(learning_rate=1e-4), metrics=['mae'])
DQN.fit(env, nb_steps=1000000, visualize=True, verbose=1)
scores = DQN.test(env, nb_episodes=1000, visualize=True)
print(np.mean(scores.history['episode_reward']))
``
Error: ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

I'm also getting error trying dqn.fit. ValueError: setting an array element with a sequence. It seems like it comes keras/backend.py. But this repo seems dead so I doubt there is any hopes for fixes.


Need More Example to Test

Hi,
I've tried to check your exapmle from repo. But it was empty. Can you guide me more info to complete it in my app? Many thnks!

I may try to tests some of the method channels. Examples or testing of billing can be read in apple's and google's docs.


Update Repo for Secure Cadence

Issue To Be Solved
Secure Cadence is coming. Need to upgrade the dependencies to make sure all contracts are working properly.
Also, do some more cleanup
Suggest A Solution

Update to latest Secure Cadence Version
Add flow.json
Update the contract files to use the correct syntax for imports
Update the transactions and scripts as well
Update the templates package to use these imports as replacements instead.
Can use what was used in the NFT repo as a starting point: https://github.com/onflow/flow-nft/blob/master/lib/go/templates/templates.go
Clean up some tests

I'm almost done with a draft for this one


See Also: no newline required

velin wants to put a newline after : in the See Also section.
The style guide,
https://numpydoc.readthedocs.io/en/latest/format.html#see-also
however, recommends a newline only if the line is too long.
Can this behavior of velin be changed, or should an option/configuration be given to ignore this?

Probably. See also is one of the things I want to change, there is also poor support when there are many items, to correctly wrap when the see also is a list of multiple items.


update to API section

Updated the API section and added link to the CSOM API details

@pwmather, Thank you for the update!


Support entity query execute dynamic return type whether it is a count query or not

\Drupal\Core\Entity\Query\QueryInterface::execute return type depends whether it is a count query or not.
/**
   * Execute the query.
   *
   * @return int|array
   *   Returns an integer for count queries or an array of ids. The values of
   *   the array are always entity ids. The keys will be revision ids if the
   *   entity supports revision and entity ids if not.
   */
  public function execute();

For the moment only chaining the methods is supported, i.e
\Drupal::entityTypeManager()->getStorage('node')
        ->getQuery()
        ->accessCheck(TRUE)
        ->execute()

I hope to find a way to support cases like another day:
$query = \Drupal::entityTypeManager()->getStorage('node')
    ->getQuery()
    ->accessCheck(TRUE);
$query->execute();

While looking at this, I feel like part of the trick is to also have a dynamic return type on Entity\QueryInterface::count which flags something so we're aware that the parent object type (the query) is a count

@brambaud can you review my push? I ended up rewriting the dynamic return type extension. I added a new custom object type. When we encounter a count method, we alter the return type to be this new custom object type. It allows us to check the type and know if it was a count query. Like if the method returned a different interface.

@mglaman I'll try to work on phpstan-drupal at least Friday or this weekend so I'll check that at this moment!
Nice idea for the custom type! I had it too but for #239 😛

Looks great!
It's true \Drupal::entityQuery exists too! I'm so used to dependency injection that I forget these static methods exist! 😅
About the todo, should we wait #239 to be finished and work on this to avoid false positive for config entities?

@brambaud I think we can handle the config entity storage as a follow up. Technically it's not a regression either way. So we could merge this or that and then address config entity oddities later

@mglaman Ok! I'll handle the follow up then :)


Config schema versions to maintain cross version parity for packs

The option to provide a 'Schema version' (there's probably a better name) for Terra packs, such that in the event of an update changing the way things are configured, a warning will be thrown if the pack's schema version does not match the plugin's schema version. This will allow for packs to maintain parity between old and new versions, and notify people in the case that a pack hasn't been updated to match any changes to the way things are configured.

Implemented with 6.0's version dependencies


New command: spo tenant commandset list

Usage
spo tenant commandset list
Description
Get a list of ListView Command Sets that are installed tenant wide.
Options
Only global
Examples
Retrieves a list of ListView Command Sets.
m365 spo tenant commandset list

Default Properties
The defaultProperties of the response to show in text mode: title, clientComponentId, listType
Additional Info
Returns the list items from the tenant wide extensions list.

Can I work on this?

@nanddeepn, sure! 👍 thanks


Mod plays creative music in multiplayer survival even when it is toggled off

It works fine in singleplayer though (I also ran into issue with skipping or playing new music via hotkeys but I think it should be addressed in another issue)
https://youtu.be/7_nok-E30XQ

Wow, thanks for letting me know! it might be easier if we talk abt the issues on the discord server just bc its better for messaging.


The graph is not accurate

The graph is not accurate

This is the dataset

1st array is the red line,
2nd is the green line
Originally posted by @BrightonWeBill in https://github.com/indiespirit/react-native-chart-kit/issues/37#issuecomment-442839205

The graph is not accurate


A unit test was broken by a recent PR

A recent PR, #1884 seems to break one unit test in current master 5e56c6620166ec95e81e95f192645ade69e26ee0. The test should be changed to Assert::IsFalse for all three zones.

Yes. We are tracking it in https://github.com/microsoft/PowerToys/issues/1977


Invisible invalid characters in player name

Player names are sometimes added like: "ChipÂ esq". The player is successfully created and the special character is invisible, but updates do not work, and the link to official Jagex hiscores is the only way to see this special character.
Rendering to URL appears to show: "Chip%C2%A0esq" (%A0 should be an acceptable space, but not sure what %C2 is)
Player.find_player "Chip esq"  also was able to find this player.

Perhaps we can force some way to clean all URL's of the %A0 characters.

Should be fixed by PR #55


Question: are you using ng-packagr for building your angular lib?

Select one ...  (check one with "x")
[ ] bug
[ ] feature request
[ ] enhancement
[x] question out of curiosity

Expected behavior
  "build:angular": "ng-packagr -p ng-package.json",

in package.json on master branch
Are you using ng-packagr for building your angular lib?
Actual behavior
Are you crazy? 🎃  😂
Reproduction of behavior
Yeah yeah, see above 🍤
Environment details

Clarity version: master

Hi @dherges - Thanks for creating  such a useful tool. Yes, it is being used to build Clarity.
Are you seeing any issues with how its been used in the project?

No not all. It's good news! :basketball_woman:
I'll have a lightning talk at angular connect. Introduction slide is going to be "Let's componentize our brand in Angular!" and from there the motivation to build a component library - may I use clarity as an example for that? Also the clarity logo and/or website on a slide?

@dherges
That would be great, thanks! Let us know if you need a logo or anything.


Add note for recent kubectl version

Description

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit 3703d8ff7463a4dd424c4a535265201aa5bd251b
https://deploy-preview-3476--calico.netlify.app


UI Help Documentation

Export Tool requires a Help section that gives the user a gist of how to use the tool.
For now, the Help documentation has been divided into three sections: Create new, Export and Store.
Here is the link to the document:
https://docs.google.com/document/d/1xcxZxNt9ofl3vXA6rKso2_braSQMWwVrzO8XVXNwbng/edit?usp=sharing

https://docs.google.com/document/d/1AxIW0okCjuOZhn8GFmGNM5l3fYIOsiKk7e9aXkxYydQ/edit?usp=sharing

Help documentation added.


Updating virtual card charge expenses does not create activities

Who is your user?
Viewer of an expense
What are they trying to achieve?
When I view an expense I want to see status updates posted in the comment feed so that I can understand what's happened with it over time.
E.g I just went and added a receipt to this expense but it doesn't show that in any way when viewing it. I expected it to have a date stamped status update saying "Alanna edited this expense" if not more detail like "Alanna uploaded a receipt". I think it does record such actions when editing other aspects of an expense?
How well understood is this problem?

[ ] Surfacing: if you feel this is a seed of an idea that needs to be researched.
[ ] Understanding: if you've done some research and feel it is already well understood and ready for shaping.
[ ] Shaping:  if you feel a solution is clearly defined and can be made into a pitch (read more about shaping)
[x] Pitching: if you feel that it is ready to be presented for prioritisation (read more about pitching)

This seem to happen only with virtual card charges, I'm looking at it


Duplicate IPs due to IP reconciler cleaning up reservation of a newly created pod

We are seeing that IP reconciler is cleaning up IP reservation of a newly created POD on a cluster with large number of pods. And later this freed IP gets allocated to different POD resulting in duplicate IPs for the PODs.
This is the sequence of events that might have happened -

ip-reconciler fetches list of pods
while ip-reconciler is fetching pods, pod X gets created and reserves an IP in ip-pool
ip-reconciler fetches ip reservations and sees IP allocated to pod X
ip-reconciler cleans up reservation for pod X since it didn't find it in step (1)

Howdy @rthakur-est .
Now that #208 was merged, can we close this issue ? (should have requested you to add a Fixes:  clause ... )


Redesign Navbar

Use vanilla html/css/js with bootstrap to make the navbar

can i work on this issue

Sure.


webview very slow on android

Bug description:
I have whole app in  webview. It loads in 3-4 seconds on ios, but loads 40 seconds on android. It is not normal. What can be the problem? On mobile browser on android it loads in 3-4 seconds
Environment:

OS: Android;
OS version: 11;
react-native version: 0.71.4
react-native-webview version: 11.26.0
"expo": "^48.0.0",

Hi @sGabunia , do you use renderLoading  props?

@batuhanorhanakinon

Hi @sGabunia , do you use renderLoading props?

Yes


[Bug]: CommonVoice/self-supervised-learning/wav2vec2 - not implemented for NumPy arrays

Describe the bug
While testing recipes, an error occured.
TypeError: Concatenation operation is not implemented for NumPy arrays, use np.concatenate() instead. Please do not rely on this error; it may not be given on all Python implementations.
Expected behaviour
Either a clearer restriction of when this recipe can be used, or an adjustment of dependencies (so there is no error).
To Reproduce
No response
Versions
No response
Relevant log output
File "speechbrain/recipes/CommonVoice/self-supervised-learning/wav2vec2/train_hf_wav2vec2.py", line 111, in fit_batch
    predictions = self.compute_forward(batch, sb.Stage.TRAIN)
...
  File "transformers/models/wav2vec2/modeling_wav2vec2.py", line 285, in _sample_negative_indices
    sampled_negative_indices[batch_idx] += batch_idx * sequence_length
TypeError: Concatenation operation is not implemented for NumPy arrays, use np.concatenate() instead. Please do not rely on this error; it may not be given on all Python implementations.

Additional context
No response

This is a transformer issue. transformmers==4.15 should be added to the extra requirements (you cleaned it with the csv recipe PR)

Yeiks, this is on us. Here's a patch file for the fix (will be uploaded with other PR 1600 edits).
diff --git a/speechbrain/lobes/models/huggingface_wav2vec.py b/speechbrain/lobes/models/huggingface_wav2vec.py
index d412430f..6775fcca 100644
--- a/speechbrain/lobes/models/huggingface_wav2vec.py
+++ b/speechbrain/lobes/models/huggingface_wav2vec.py
@@ -411,7 +411,7 @@ class HuggingFaceWav2Vec2Pretrain(nn.Module):

         sequence_length = self.model._get_feat_extract_output_lengths(
             raw_sequence_length
-        )
+        ).item()

         # 1. Compute the indices that will be masked
         mask_time_indices = _compute_mask_indices(

We were giving as input arguments for (batch_size, sequence_length) a (2, tensor(157)) mix. It worked when using .item() on a previous variable, so the input argument is (2, 157) instead.


code update

Upload the tag_identify code and Stanford Named Entity Recognizer package.
The code is good to work on tag_identify from csv file, it can write the identified data into file automatically.

Is there a run-able file?
When I called the function manually, I got an error because I was missing a Java command line dependency. I think spacy is a better model because the model can be downloaded via a python command and there's no java dependency.
Typically these models detect entities based on context, but the data in the cells doesn't have context the same way a sentence would. I think applying the model in this way is not the expected use case and may cause weird errors.
Chase's implementation in #6 seems to work pretty well just using pattern matching.

This is a run-able file, I can run it without mistake on PyCharm with anaconda 3 environment, I don't know why you got a error. I have try the spacy, it also a useful tool, I can fix the code with spacy.
I don't think there are any different between data in cell and sentence. For the first step of of these model to identify, we need get the string, it would not difficult for us to transfer data to string.
Chase's method is clever and clear, it can work on our data very good. But I think it has a limtation about accuracy, especially when work on complex data.

I had to add the filename of the csv to the script to run it.
I think the issue is a system level dependency on Java to run the model. Python is only used to call the java functions.
It's not about the datatype in the cell. The content of the sentence gives context to the word, but the words in the cells have little to no grammatical meaning, so it can't read the context. My guess is the model is basically doing a dictionary lookup for names rather than entity recognition on sentence context like intended.
Yeah Chace's method won't generalize to all patterns, but it seems to work well in the 5000 cases we have. Maybe take a look at his code and try to correct any errors or make it more generalizable.


Label handling in PR Describe section

What type of PR is this?
/kind feature
What this PR does / why we need it:
Add Lable handling from PR descrbe section

@m1093782566 , did the fix for comment given, Please have a review and merge. Once it merged will be deployed to kubeedge .


Auditing against schemas

This PR lets you pass either a file path to a .json schema or a flattened pandas DataFrame during initialization of a Pipeline object or creation of a file view. Any keys specified in the schema will be included when creating the file view. The schema will also be stored and referenced later when trying to push the file view back up to Synapse. If there are any inconsistencies, the program will warn the user.

Looks good!


How can we pause and resume recording?

It is a question or a feature request.

@sagarpatel288 unfortunately this is not currently supported. You'll have to start and stop the recording. Thanks

Thanks for the reply @michhyun1

Chime SDK team has launched a new service to provide meeting capture capabilities with original video resolution and frame rate. You will not need to provision your own container infrastructure. Instead, just call the API from AWS SDK and provide a prepared S3 bucket to receive the artifacts.
To know more, please check out the blog:
https://aws.amazon.com/blogs/business-productivity/capture-amazon-chime-sdk-meetings-using-media-capture-pipelines/


Standardise all UG/DG images

With respect to the size and cropping

maybe we need to change the screenshots that include the tags like 'family' and 'friends' as these tags don't seem logical in this context

Ye good catch, added another issue for that for now #117

Closed by https://github.com/AY2425S1-CS2103T-F14b-3/tp/pull/187


use SNAPSHOT version for development

@xscript,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #50   +/-   ##
======================================
  Coverage    79.8%   79.8%
======================================
  Files          38      38
  Lines        1203    1203
  Branches      129     129
======================================
  Hits          960     960
  Misses        190     190
  Partials       53      53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e41b20...9200e6b. Read the comment docs.


Some PDFs display blank white page

I cant seem to work out what is causing this, but some PDFs that get fed to it are displaying as blank white pages. If I take those PDFs and re-save them in something like Preview, then it works, so I"m guessing it's something to do with the way in which they were exported.
Has anyone come across this? Not sure how to troubleshoot as I cant reliably replicate 🤔

@tomlongo
I had the same problem with a couple of PDFs there were created with an old version of Ghostscript (which had a documented bug).
The only way I found to overcome the problem has been to use a recent version of gs to re-save them, e.g. gs -sDEVICE=pdfwrite -oCorrect_PDF.pdf Problematic_PDF.pdf .
That said, I can't understand why Preview, iBooks and iOS 11 PDFKit (which I'd prefer not to use for my particular app because of the way the thumbnail bar behaves) all can correctly open the original PDFs.

@Alua-Kinzhebayeva Any solution for this?

@Alua-Kinzhebayeva Any updates on this issue?

This seems to be related with this one.
I've changed changed the rotation code blocks with the following on PDFDocument & TiledView.
 // Flip the context so that the PDF page is rendered right side up.
context.translateBy(x: 0.0, y: scaledPageRect.height)
context.scaleBy(x: 1.0, y: -1.0)
let transform = page.getDrawingTransform(CGPDFBox.mediaBox, rect: scaledPageRect, rotate: 0, preserveAspectRatio: true)
context.concatenate(transform)

These changes seems to fixed the issue in my case.


View  route issue

When the filter is applied, the address for the browse button should look like http://site.com/admin/city/edit/10?ref=city-grid but instead it is formed like this http://site.com/admin/city/edit?name=Boston&city=1&ref=city-grid. At this route for removal it is formed correctly irrespective of use of the filter or sorting.
Rule in web.php look like this
Route::match(['get','post'], '/city/edit/{id}', ['uses' => 'Admin\CityController@edit', 'as' => 'city.edit']);

I looked at how routes are formed for viewing and deleting in the file RendersButton.php.
For view:
'url' => function ($gridName, $item) {                 return $this->getViewUrl([                     $gridName => $item->{$this->getDefaultRouteParameter()}, 'ref' => $this->getId()                 ]);             },
For delete:
 'url' => function ($gridName, $item) {                 return route($this->getDeleteRouteName(), [                     $gridName => $item->{$this->getDefaultRouteParameter()}, 'ref' => $this->getId()                 ]);             },
Added this code to configureButtons() method
'url' => function ($gridName, $item) {                 return route($this->getViewRouteName(), [                     $gridName => $item->{$this->getDefaultRouteParameter()}, 'ref' => $this->getId()                 ]);             },
The problem was solved, but I do not think that this is the right way.


ORM failed to Load

I am using sails-cbes with sails and getting this error.
error: A hook (orm) failed to load!
error: Error: Failed to connect to the Couchbase/ElasticSearch clients { [Error: failed to connect to bucket] code: 25 }

Hi,
The error tells you that it can't connect to the couchbase bucket. Maybe
the couchbase server is down or the bucket doesn't exist. Same, the adapter
configuration could be wrong.
Please check your config/connections.js and have a look at the
documentation (how to configure)
https://www.npmjs.com/package/sails-cbes#configuration
and
http://sailsjs.org/#!/documentation/reference/sails.config/sails.config.connections.html
Best regards!
Luigi
On Wed, Jun 17, 2015 at 1:15 PM, jahanzaibaslam-vteams <
<EMAIL_ADDRESS>wrote:

I am using sails-cbes with sails and getting this error.
error: A hook (orm) failed to load!
error: Error: Failed to connect to the Couchbase/ElasticSearch clients {
[Error: failed to connect to bucket] code: 25 }
—
Reply to this email directly or view it on GitHub
https://github.com/aronluigi/sails-cbes/issues/2.

Thanks Luigi for the update.
I am done once again with all connection configuration guide lines but still facing the same issue.  here is my connections.js file
// config/connections.js
  cb: {
    adapter: 'sails-cbes',
    host: '<IP_ADDRESS>',
    port: 8091,
    user: 'Administrator',
    pass: 'word2pass',
    operationTimeout: 60 * 1000, // 60s
    bucket: {
        name: 'default',
    }
  }

NOTE: It would be great if you share  a sample project link where sails-cbes is working fine with sails.

Hi,
Make sure that you have couchbase and elastic search installed and
configured on your system/server.
Please modify the config below and put it inside your config/connections.js
Have a nice day!
Luigi
module.exports.connections = {
sailsCbes: {
adapter: 'sails-cbes',
cb: (function () {
if (process.env.NODE_ENV == 'production') {
return {
host: '<IP_ADDRESS>',
port: 8091,
user: 'cluster admin user',
pass: 'password',
operationTimeout: 1000 * 60,
bucket: {
pass: '',
name: 'Production BUCKET NAME'
}
};
} else {
return {
host: '<IP_ADDRESS>',
port: 8091,
user: 'cluster admin user',
pass: 'password',
operationTimeout: 1000 * 60,
bucket: {
pass: 'BUCKET_PASSWORD if not let it empty',
name: 'BUCKET_NAME'
}
};
}
})(),
    es: (function () {
        if (process.env.NODE_ENV == 'production') {
            return {
                host: ['<IP_ADDRESS>:9200'],
                log: 'error',
                index: 'YourProductionIndex',
                numberOfShards: 5,
                numberOfReplicas: 1
            };
        } else {
            return {
                host: ['<IP_ADDRESS>:9200'],
                log: 'error',
                index: 'YourDevIndex',
                numberOfShards: 5,
                numberOfReplicas: 1
            };
        }
    })()
}

}
On Wed, Jun 17, 2015 at 3:04 PM, jahanzaibaslam-vteams <
<EMAIL_ADDRESS>wrote:

Thanks Luigi for the update.
I am done once again with all connection configuration guide lines but
still facing the same issue. here is my connections.js file
// config/connections.js
cb: {
adapter: 'sails-cbes',
host: '<IP_ADDRESS>',
port: 8091,
user: 'Administrator',
pass: 'word2pass',
operationTimeout: 60 * 1000, // 60s
bucket: {
name: 'default',
}
}
NOTE: It would be great if you share a sample project link where
sails-cbes is working fine with sails.
—
Reply to this email directly or view it on GitHub
https://github.com/aronluigi/sails-cbes/issues/2#issuecomment-112792462.


Cannot read property 'startswith' of undefined

Hi, I am trying to show images in the image viewer using 'react-native-image-zoom-viewer' library do we have to supply images array like given in the example (url: ...)?
When I user images array looks like below I get this error.

Please help!!

ImageViewer is actually expecting an array of objects, not strings. Your array should be:
[{ url:"https://firebase...}, {url:"https://secondUrl"}].
you can use the map function to fix your array.
images.map( (imageUrl) => { return { url: imageUrl } })

So Sorry for late reply I got it working thank you...


Functionality that pulls the Conjur configuration from Windows registry / WinCred should be migrated to the Conjur Ruby client

At current, the Conjur Puppet module supports a few ways of providing Conjur with its configuration:

Hardcoded in the manifest (consistent with other integrations and with standard Ruby client instantiation)
Written to config files (also a supported method for Conjur clients)
Written to Windows registry / WinCred

The third method should be supported by the Ruby client and leveraged by this module, rather than being implemented and fully tested as part of this module. In this card, the functionality should be migrated to the Ruby client and the Puppet module should be updated to invoke the new version of the Ruby client that includes this functionality. The tests around this flow can largely move to the Ruby client as well, and the integration tests here can validate a subset of the flows work end-to-end.
Note: Given the amount of work required to do this, it is a small epic, not a single task.

This won't be possible - we cannot use a third-party gem in this way as a dependency of a puppet module. As far as I can tell, only other modules can be used as dependencies so I'll close this issue unless I hear otherwise.

😞 bummer. would be nice to use our Ruby lib here, for example.


chore(CI): check images are stored in lfs

PRs don't indicate whether images were uploaded using lfs or not.
This checks the images and gif are uploaded using lfs.

We should also add instructions in the developer docs on how to upload images using lfs.

Yeah that'd be nice. I'm thinking of adding them in https://github.com/ratatui-org/website/issues/259. But I'm far from specialist in git lfs


width of decoration is half sized on first render

the last time onRender is called when a decoration is first added, its element has the wrong dimensions (about half sized). The next time refresh is called (if you type anything or scroll), it's fixed
the results in the left-margin, which factors in the element's dimensions, getting incorrectly calculated.

Bug is better illustrated here - the time onRender is called, it gets the wrong dimensions. The next time refresh is called (if you type anything or scroll), it's fixed

I think I know what's happening here - we listen to onRenderedBufferChange and onDimensionsChange and I believe the first (incorrect) dimensions are happening before onDimensionsChange has been fired. We should probably create the listener to onRenderedBufferChange the first time refresh is triggered via dimensions changing

happens because we can’t provide a non-integer multiplier for the width so on creation, the element has the wrong size. so display needs to be none until the embedder tells xterm otherwise I think
or after on render is fired, then can unset display hidden in decorations service to give embedders time to resize

This was happening because the element's size was getting factored into the margin calculation. When it's first created, the size isn't quite right.


How to make payment method to paypal

how can i set payment type to paypal so users will pay it from paypal and get me response back

switch the payament method


⚠ Bofrost.lu has degraded performance

In 6fa1155, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2601 ms

Resolved: Bofrost.lu performance has improved in bda38d4 after 20 minutes.


Create huy.cpp

Describe your PR, what does it fix/add?
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?

tytrytr

wtf


Problem with some letters that are cut by the UIView

How we can solve that?

Thank you in advance.

Hello @ConradoMateu
I am uploading version 0.3.1 fixing it.I have noticed that the CATextLayer frame needs about 20% more height than the font size in order to render all letters correctly.
Thank you for the catch!

Same problem on 0.3.5

I have just spotted where the problem is. Thank you for pointing it out. Uploading a new version soon.

Yes, i have seen this in code:
let frameHeightCorrectionFactor: CGFloat = 1.2
,but changing this property unfortunately has no effect =(

The problem is in private func styleDidChange() , the placeholderLayer.frame gets a new frame but the frameHeightCorrectionFactor it is not applied. I have just fixed. Uploading the changes now.

Great! Anyway, I have already changed "Login" to "Username", so i fixed it like a true hacker =))

👏


Link to FAQ to find test centers (EXPOSUREAPP-8086)

Implementation

Note:
The image on the side is not perfectly aligned as in the mockups but this would require a refactoring of this cards, this also affects the already implemented cards. To bring it a little bit closer to the mockups I changed the navigation colors.

You prefer opening FAQ over directly jumping to the map? As a fallback reason in case map service is interrupted/terminated? But TSI could provide a message on their site then. Like this it takes one click more effort to get to the map.
But nice to implement it in general 👍

You prefer opening FAQ over directly jumping to the map? As a fallback reason in case map service is interrupted/terminated? But TSI could provide a message on their site then. Like this it takes one click more effort to get to the map.
But nice to implement it in general 👍

@vaubaehn the FAQ entry contains multiple links and we want to be able to adjust the links without releasing a new app version :)

@harambasicluka
Thanks, I simply forgot about the PCR tests, which are not necessarily included in the map. Also, the link to @Ein-Tim 's list is also worth to jump to FAQ :)

@harambasicluka
Thanks, I simply forgot about the PCR tests, which are not necessarily included in the map. Also, the link to @Ein-Tim 's list is also worth to jump to FAQ :)
Edit: why are you laughing about Android 6 emulator? It's important!! 😉

It was more like an internal joke, because it's my first implementation in a while :)

Will this fix Internal Tracking ID: EXPOSUREAPP-7204?

Will this fix Internal Tracking ID: EXPOSUREAPP-7204?

@DerVogel2020 Yes! You can already check the URL: https://www.coronawarn.app/de/faq/#where_can_i_get_tested


Update example forms to remove form class, avoid 404s

Remove non-existent form class from forms.
Update form tags to GET the same example – the forms currently POST to a non-existent URL which results in the example iframe 404’ing:

You can preview this change here:
Built with commit 4a86ff4079d18f533f0dc0a09001043f2437a818
https://deploy-preview-199--govuk-design-system-preview.netlify.com

Going to split this work out – will open a PR to remove the classes and we can revisit the form submission issue later.

Recorded the form handling issue here:
https://trello.com/c/A2N92zjA/806-handle-form-submissions-in-the-question-page-examples-in-the-design-system


Textarea is displayed in the page

The text area isn't hidden... And i don't know if the other frame is a bug / feature

maybe a loading problem of the page?

It can not happen because its display:none;. Might occour while the page is loading, but it is normal.


[5.0.2 regression] unused type guard result erroneously changing inferred type of variable

Bug Report

🔎 Search Terms
control flow analysis type guard narrowing widening no-op
🕗 Version & Regression Information

This changed between versions 4.9.5 and 5.0.2

⏯ Playground Link

Playground Link
💻 Code

type FooNode = {
    kind: 'foo';
    children: Node[];
};

type BarNode = {
    kind: 'bar';
}

type Node = FooNode | BarNode;

type Document = {
    kind: 'document';
    children: Node[];
};

declare function isNode(node: unknown): node is Node;
declare function isBar(node: Node): node is BarNode;

export function visitNodes<T extends Node>(
  node: Document | Node,
  predicate: (testNode: Node) => testNode is T,
): void {
  // Spooky action at a distance: this no-op statement causes the compiler to reject the assignment
  // guarded by the conditional, below. Comment it out to fix the failure.
  isNode(node) && predicate(node);

  if (!isNode(node) || !isBar(node)) {
    // This line should compile fine!
    const nodes: Node[] = node.children;
  }
}

The original code that turned this issue up was a bit more indirect and looked like:
const shouldYield = isNode(node) && predicate(node);
if (shouldYield) {
  yield node;
}

const hasChildren = !isNode(node) || !isBar(node);
if (hasChildren) {
  yield* yieldAll(node.children);
}

I was able to work around the issue by inlining the guards directly into the if rather than using an intermediate value.
🙁 Actual behavior
The assignment const nodes: Node[] = node.children; fails, complaining that
Property 'children' does not exist on type 'FooNode | Document | T'.
  Property 'children' does not exist on type 'T'.(2339)

but only if the unused type guard at the beginning of the function is present. Commenting the dead code out fixes the issue, and the compiler correctly narrows the type of node to just FooNode | Document.
🙂 Expected behavior
The unused type guard/dead code has no effect on the inferred type of the value.

A good workaround would be to write
export function visitNodes<T>(node: Document | Node, predicate: (testNode: Node) => testNode is (T & Node)): void {
  // Spooky action at a distance: this no-op statement causes the compiler to reject the assignment
  // guarded by the conditional, below. Comment it out to fix the failure.
  isNode(node) && predicate(node);

  if (!isNode(node) || !isBar(node)) {
    // This line should compile fine!
    const nodes: Node[] = node.children;
  }
}

(you may also keep the constraint if desired)

This one is interesting. The issue is actually a pre-existing defect in subtype reduction that happens to be revealed by the 5.0 improvements to narrowing with user defined type predicates.
In the code
export function visitNodes<T extends Node>(node: Document | Node, predicate: (n: Node) => n is T): void {
    node;  // Document | Node
    isNode(node) && predicate(node);
    node;  // Document | Node | T
}

the type of node isn't properly reduced back to Document | Node following the type predicate calls, even though T is a subtype of Document | Node. This is the case in both 4.9 and 5.0. The reason this reduction doesn't happen is that subtype reduction only removes union constituents that are subtypes of another individual constituent. This potentially misses type parameters with union constraints because they can be subtypes of some union, but not subtypes of the individual constituents of that union. For example, a type parameter T extends A | B is a is subtype of A | B, but not a subtype of just A or just B. In the issue here, T is a subtype of FooNode | BarNode, but not a subtype of just FooNode or just BarNode, and subtype reduction therefore doesn't remove T from Document | Node | T. We need to fix subtype reduction to handle such cases.

What I’m curious about is how a statement like foo(x) && bar(x); affects the type of x in the first place.  Neither one is an asserts call so my expectation would be that no CFA node is created at all.

@fatcerberus The statement foo(x) && bar(x); is really no different than an if statement with an empty body from a CFA point of view. There may be no effects to x after the statement, but there are most certainly effects on x within the statement (i.e. foo(x) narrows the x observed in bar(x)). The control flow analyzer doesn't really reason in terms of statements, rather it looks at flows of control through the possible conditional branches of the code and tracks their effects on the types of variables. When branches join (e.g. following an if statement) we union the observed types and that's where subtype reduction sometimes comes in.
Now, it so happens that the issue reported here only shows up when the type predicate calls occur in an expression statement (and not an empty if statement), but that's for unrelated reasons having to do with the exact shape of the control flow graphs.


External Clickhouse config issue

Hello. I am having an issue with externalClickhouse setup.
I dont think externalClickhouse custom cluster value is being passed down.
I am using a cutom cluster name which I can see in the dry run but I am getting an error as follows
2023-11-09T06:32:04.043Z	info	exporter@v0.79.0/exporter.go:275	Stability level of component is undefined	{"kind": "exporter", "data_type": "metrics", "name": "clickhousemetricswrite"}
time="2023-11-09T06:32:04Z" level=info msg="Executing:\nCREATE DATABASE IF NOT EXISTS signoz_metrics ON CLUSTER cluster\n" component=clickhouse
2023/11/09 06:32:04 Error creating clickhouse client: code: 701, message: Requested cluster 'cluster' not found

Its still using the default value cluster. I tried to look at the code but I could not find any trace of CLICKHOUSE_CLUSTER env var you are passing to the collector. Please help with this.

Hi @sarsony1 , how are you configuring the cluster currently? are you setting some env likeCLICKHOUSE_CLUSTER?

We have recently changed the way we run migrations and accept the cluster variable
We run migrations in a separate k8s job now, can you try doing the following?

Add --cluster-name arg followed by your cluster name here https://github.com/SigNoz/charts/blob/c8486fabd02e107c13b21a2f04563c5df7e4fb90/charts/signoz/values.yaml#L1151
the section should look something like

args:
  - --cluser-name
  - <your-cluster-name>

Will add a section about this in the readme

otelCollector has the same error - Requested cluster 'cluster' not found.
How can I fix this?


fix: dev: #243: Schedule validators on same thread to avoid overlap

By supplying the same single-threaded executor to both validators, each validator will still be correctly scheduled, but will no longer be running concurrently with another validation.

Codecov Report

Merging #244 into master will decrease coverage by 0.24%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   22.43%   22.19%   -0.25%
==========================================
  Files          59       59
  Lines        2857     2861       +4
  Branches      307      307
==========================================
- Hits          641      635       -6
- Misses       2177     2187      +10
  Partials       39       39

Impacted Files
Coverage Δ

.../com/qubole/rubix/bookkeeper/HeartbeatService.java
0% <0%> (ø)
:arrow_up:

.../rubix/bookkeeper/validation/CachingValidator.java
0% <0%> (ø)
:arrow_up:

...ole/rubix/bookkeeper/validation/FileValidator.java
0% <0%> (ø)
:arrow_up:

...rc/main/java/com/qubole/rubix/spi/ClusterType.java
0% <0%> (-46.16%)
:arrow_down:


Failing when run Mocha Chai testing

Describe the bug
Trying to use pass a simple test asserts with Mocha & Chai throws an error
TypeError: Failed to fetch dynamically imported module: file:///home/projects/node-um3w4m/test/appTest.js
The same code exactly in a local machine works fine.
Maybe is a problem when the dependecies was installed.
Link to the blitz that caused the error
https://stackblitz.com/edit/node-um3w4m?file=package.json
Steps to reproduce

Run npm run test

Expected behavior
Just execute the test and run correctly.
Screenshots
No response
Platform
Browser name  = Chrome
Full version  = 93.0.4577.82
Major version = 93
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.82 Safari/537.36
performance.memory = {
  "totalJSHeapSize": 77403542,
  "usedJSHeapSize": 71116946,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Hash = fa2fa735bbb029186c23972eb56445ed5c5fdef5

Additional context
No response

It works with:
ENABLE_CJS_IMPORTS=true npm test

This is due to a "legacy" CommonJS file trying to use dynamic import(). This works but you need to opt in through an environment variable. Please check https://github.com/stackblitz/webcontainer-core/issues/281 for more info.


[QUERY] How are public IP addresses attached to a NAT Gateway?

Library name and version
Azure.ResourceManager.Network 1.0.0-beta.7
Query/Question
I'm having trouble figuring out how to attach/associate a public IP address to a NAT Gateway using the SDK.
I'm trying to attach an existing public IP address to a new NAT gateway with code line this:
natGateway = (await natGatewayCollection.CreateOrUpdateAsync(WaitUntil.Completed, natGatewayName, natGatewayData)).Value;

var publicAddressCollection = resourceGroup.GetPublicIPAddresses();
var publicAddress           = (await publicAddressCollection.GetAsync("my-address")).Value;

publicAddress.Data.NatGateway = natGateway.Data;
publicAddress                 = (await publicAddressCollection.CreateOrUpdateAsync(WaitUntil.Completed, "my-address", publicAddress.Data)).Value;

These operations complete OK but publicAddress.Data.NatGateway == null after the operation and Azure portal reports that the NAT Gateway has no attached addresses.
I've been searching this repo for alternate ways to attach/associate IP addresses or prefixes to a NAT Gateway but haven't found anything yet.  I thought that NatGatewayData.PublicIPAddresses might work but that's a read-only array property.
Environment
.NET SDK (reflecting any global.json):
Version:   6.0.300
Commit:    8473146e7d
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19044
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\6.0.300\
Host (useful for support):
Version: 6.0.5
Commit:  70ae3df4a6
.NET SDKs installed:
3.1.419 [C:\Program Files\dotnet\sdk]
5.0.407 [C:\Program Files\dotnet\sdk]
5.0.408 [C:\Program Files\dotnet\sdk]
6.0.101 [C:\Program Files\dotnet\sdk]
6.0.105 [C:\Program Files\dotnet\sdk]
6.0.300 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 3.1.24 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.25 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.16 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.17 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.24 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.25 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.16 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.17 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.24 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 3.1.25 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.16 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.17 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.4 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.24047309,Service Bus:0.09440465,Search:0.05794773'

Never mind, I figured it out.  The answer is to add the public IP ID to NatGatewayData.PublicAddresses before creating or updating the gateway.
I'm not sure how I thought that this property was a read-only array.


Reference comments in po files are parsed incorrectly

We have a .po file like this:
#: attributes/address/composer.php:8 attributes/address/form.php:7
msgid   "Address 1"
msgstr  ""

Currently the po parser do a simple split with ':'.
In this case we'd have that we have that we call addReference with:

$filename == attributes/address/composer.php
$line == 8 attributes/address/form.php

Furthermore, under Windows, we may have references like this one:
C:/Users/Me/Documents/foo.php:1
The above split function will result in:

$filename == C
$line == /Users/Me/Documents/foo.php

We'd need a better reference parser...

Thank you for the feedback. I didn't know a comment can contain more than one reference.
Fixed using a regex.

Great, thank you!


Make systems configuration more fluent

Things like this is hard to write and understand:
useCost(action: PLAY_ACTION, res: MANA, value: MANA_COST, whoPays: "player")

Make the entire systems setup easier.

Current line of thought is to refactor the entire setup section, rename it to rules instead.
Inside the rules section:

use an init section for stuff that happens before, or when, game is started. This can be pure code
always section that specifies some systems that are always present, such as removeDead, LimitedHandSize...
turnStart and turnEnd sections that describe what happens when a turn/phase starts or ends.
action sections, one for each action name, that describe those actions. Requirements for being allowed, and what to do when performing the action.

Example init:
init {
    game.players.each {
        it.deck.createFromConfig('Deck')
        it.deck.shuffle()
        it.drawCards(5)
    }
    mulliganIndividual()
}

Example turnStart:
turnStart {
    apply {
        you.drawCard(1)
        you.mana_max = Math.min(1 + (int) you.mana_max, 10)
        you.mana = you.mana_max
        you.battlefield.forEach {
            it.attack_available = 1
            if (it.sickness > 0) {
                it.sickness--
            }
        }
    }
}

Example turnEnd:
turnEnd {
    apply {
        you.battlefield.forEach {
            it.health = it.max_health
        }
    }
}

Example action:
action('Enchant') {
    allowFor {
        zone 'Hand'
    }
    targets 1 of {
        zone 'Battlefield'
        creatureType 'Bio'
        ownedBy you
    }

    cost SCRAP value card.scrap_cost to card.owner
    cost MANA value card.mana_cost to card.owner
    perform {
        targets.forEach {
            it.attack += card.attack
            it.health += card.health
            it.max_health += card.health
        }
        effectAction()
        destroy()
    }
}

I like that a lot, I think going in that direction would make the Game that much easier to mod!

parts of this issue depends on there having been some progress at least to #242


Prometheus enters blocked state when the pod churns

Bug Description
Title says it all
To Reproduce

deploy prometheus-k8s
kubectl delete pod prometheus-0

Environment
juju: 2.9.25-ubuntu-amd64
microk8s: v1.23.3
os: Ubuntu 20.04.4 LTS
Relevant log output
prom/0*   blocked   idle   <IP_ADDRESS>         Failed to load Prometheus config

Additional context
No response

Also happened to me while scaling up 1 --> 4 units.

Ok. Tried to reproduce it today with latest beta release (revision 20) using both ways described above but failed to reproduce it. Tried the delete pod way a couple of more times. Does this happen every time ?

I thought it did. It also happens when you reboot the microk8s node (on prometheus built from main).
Additionally, I noticed that Prometheus remains with that status but is in fact running at that point. I think this likely implies that this is a bug with ordering of hooks not setting active status correctly.

By "reboot the microk8s" do you mean microk8s stop and then microk8s start ?

@dstathis Is this issue still reproducible. I have previously tried to reproduce this and failed to do so. Have you seen it recently ? Shall we close this ticket ? Shall we try to reproduce it again ?

I tried to reproduce this with Prometheus from edge and was not able to.


Issue 29: Export naming

Codecov Report

Merging #44 into master will decrease coverage by 2%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   77.33%   75.32%   -2.01%
==========================================
  Files           3        3
  Lines         150      154       +4
  Branches       24       26       +2
==========================================
  Hits          116      116
- Misses         34       38       +4

Impacted Files
Coverage Δ

src/testla.js
57.77% <0%> (-2.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940ef69...06de705. Read the comment docs.


Sometimes reaper doesn't move

They should always walk up to the obstruction, even if they can't get past it

Looks like the issue is in calcdist_ai(), since that always uses IS_MOB_AI() to determine whether it can move to a tile. The original code does this, but if it fails to find a candidate step tries again ignoring mobs. If it fails that, it tries a third time just using distance. I tried this out but it ends up being really slow when it occurs. Maybe there's something more clever we can do here.