feat(toolbar): support vertical dividers through mat-divider

Bug, feature request, or proposal:
Bug
What is the expected behavior?
It should be possible to display a divider in a mat-toolbar per the spec:

What is the current behavior?
Placing <mat-divider [vertical]="true"> creates a 0 x 1 pixel element.
What are the steps to reproduce?
In this StackBlitz, you can see the top toolbar has the divider but it's not visible, while the bottom toolbar manually styles the divider to show up correctly.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Latest everything, as far as I can tell.
Is there anything else we should know?
In the StackBlitz, I have to guess at the pixel height of the divider because I can't find exactly how tall the line is supposed to be in the spec, even though they do call out the spacing between the line and the icons on either side of it.  I think it's a blind spot in the spec, since neither the Structure nor the Toolbars section actually mentions the use of dividers to logically group controls.

Another approach: https://stackblitz.com/edit/angular-material2-issue-ec8ueb

In your example, the spacing is wrong between the divider and the adjacent buttons.  If I'm going to manually style stuff anyway, I don't think I'd want to add extra wrapping elements like the div you used.  The point of the issue is that <mat-toolbar><button/><mat-divider/><button/></mat-toolbar> should lay out according to the spec without manual styling, and right now it does not.

So I think the issue is two-fold: the styles for the elements inside the toolbar is wrong, and the style for the divider is wrong. It should be something like this (though the sibling CSS might be wrong, it's the intention):
.mat-toolbar > * + .mat-divider {
	margin-right: 16px;
}

.mat-toolbar > .mat-divider + * {
	margin-left: 24px;
}

.mat-toolbar > .mat-divider {
	margin-left: -1px;
}

Does this look right to you? I'm not going to comment on the internal sizing of the button in relation to the spec, mostly because it's not defined in that example. So while it looks like it should be smaller, since it's not defined, I think it's fine.

I'm not a CSS expert but I'm not clear on why the sibling element style would be changed -- shouldn't the divider just contribute its own margin and trust the siblings to make up the rest?  What if a toolbar element wants to set its own margin for whatever reason?  It looks like the spec doesn't work that way, but that bothers me for some reason.

The facts remain that this is how the spec is defined. If someone wants to override the spec margins, they are free to do so. The important thing about sibling selectors is that you don't want errant margins showing up in case someone puts a divider first or last.
I'll put together a PR and hopefully the Material Design team can comment on it with the internal guidelines on this.

was this ever fixed ? I've just hit the same problem

@devversion any chance this is going to be fixed? I'm hitting it as well.

Hitting it too

any updates on this problem? pretty frustrating @google-admin

@devversion

any update? @devversion

Closing this since we don't have any plans to implement this feature. The toolbar is in fact unfortunately named (based on the 2014-era Material Design spec), and doesn't actually correspond to the role="toolbar" interaction pattern, where having vertical dividers like this would make more sense. The <mat-toolbar> is really just meant to be a container for titles- it's not much more than a glorified div with a background color.

The spec is kind of a mess, briefly mentioning desktop in the density section then otherwise pretending it doesn't exist.  Are toolbars-as-actual-toolbars just totally unsupported now?  Do we have to figure out our own?  Seems like a pretty big gap.


Improve the driver protocol spec

As of the time of this writing, it's here -- https://github.com/rethinkdb/rethinkdb/blob/mlucy_proto_docs/src/rdb_protocol/ql2_json.md, but will be on the site soon.
Here are some things that need to be improved:

[ ] Section 2 (the query) needs to be expanded. Right now it's as long as section 1 (the handshake), but the mechanics are significantly more complicated, and we let people guess a lot. In particular, we should have a few more progressively more complex examples (start with r.expr(1) and show how to use lambdas and such), and explain how the json protocol related to protobufs a bit better. For example, we link to the protobuf spec, but don't even say that you're supposed to use the integer values defined there explicitly.
[ ] Add a section at the end that gives people some friendly notion on how to get started. For example, we should explicitly link to the official drivers, and a few community drivers source code.

Unassigning myself because I'm not sure what I'm supposed to be doing on this issue.  I think this eventually made it onto the site, right?

Yes, this is on the site. We should write a separate tutorial at some point that walks people step by step on how to create a sample driver.

From what I can see @neumino's comments from here https://github.com/rethinkdb/docs/pull/358/files are still not reflected in the docs. So we should keep this open.
Another thing I've just noticed is that we don't link to the new document from http://rethinkdb.com/community/ (not sure if this is going to be redone anyway for 2.0? @mglukhovsky?).

Write a new driver — no ReQL driver for your favorite language? Help write one! Hop on the mailing list or #rethinkdb on freenode, and we'll walk you through the driver protocol API.

still just links to the ql2.proto file.
http://rethinkdb.com/docs/install-drivers/ links to the right document (http://rethinkdb.com/docs/driver-spec/) correctly. I think the Community page should also link to that.

Agreed. The community page is being reworked, but you're correct that we should link to that document.

These have been improved a lot in the meantime.


Users view has inconsistencies with secondary userstores

Describe the issue:
Getting the option to create a user when readonly userstore is selected from the userstore drop down.

Search and Filter bars disappear once you select the user store that doesn't have any users
How to reproduce:
Create a new readonly userstore that doesn't have users
goto users view and select the respective userstore from the drop down
Expected behavior:

Search and Filter bars should be available in the screeen
For readonly userstore the description should not say to add new users.

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

When the user select a userstore without any user, the ideal experience would be to display the search and filter segment without the search bar.

I think

The user store filter should be there for both of the user stores regardless user exists or not
"Add a new user" description and the "Add user" button should not be there for the read-only user store.
Search bar display depends on whether there are user exist or not.

This issue will be resolved through PR https://github.com/wso2/identity-apps/pull/5437 for both the users and groups sections. When there are no users in the selected user store, search and filter options will be disabled, while the user store dropdown will remain functional. If the user store is read-only, the add user text and related actions will be removed. Refer to the following videos.
Without users
https://github.com/wso2/identity-apps/assets/74205483/6280e5c0-2f94-47e5-999d-64508feb1d07
With users
https://github.com/wso2/identity-apps/assets/74205483/34c21d7a-27a3-4e23-ad1e-efe206df5091


Makes InMemoryFileSystem threadsafe to address flaky unit tests

Uses a single lock per file system, which results in suboptimal performance but is not a problem in practice:  all of InMemoryFileSystem is unoptimized and is only used in unit tests in practice.
Existing unit tests cover all the functionality, and should make tests such as FileSystemTests.testInMemoryFileSystemFileLock pass reliably now.

@swift-ci please test

@tgymnich This should fix the flakiness of the test resulting from https://github.com/apple/swift-tools-support-core/pull/152.  It looks as if InMemoryFileSystem was never thread-safe, and so the unit test that uses it was inherently racy.

Probably best to look at diffs with whitespace disabled — most of this is just a simple implementation wrapping everything with a withLock.  In two cases I had to split out the non-locked implementation into separate functions to avoid deadlock where one API function called another API one.  Not going for elegance here, but just to make it robust.

@tgymnich Not able to add you to list of reviewers for some reason, but would appreciate a look since you've looked at this code more than I have.

@swift-ci please test

Doing a bunch of checks after each other since this is a flaky one.  If there's still a problem hopefully one of them will fail.

@swift-ci please test

@swift-ci please test

@swift-ci please test

Makes sense.  Actually, we have two unit tests that hammer the APIs here concurrently, and those were the ones that were flaky due to race conditions.  This PR should make those unit tests no longer flaky.  I don't think adding another unit tests that tests the concurrency would add anything of value, but having our unit tests run with TSAN enabled is definitely something we should do.  @neonichu is that something that can be done with our own configuration, or would we need Mishal to make changes?

@swift-ci please smoke test

@swift-ci please smoke test

@swift please test


Invalid Hex Characters when creating Receive Block

Hello. First of all, great library, thank you. I tried to receive 0.001 XNO but the Blok.CreateReceiveBlock() throwed an "invalid hex characters" error.
await rpcClient.UpdateAccountAsync(account);
var receiveBlock = Block.CreateReceiveBlock(account, "PENDING_BLOCK_HASH", Amount.FromNano("0.001"), "POW_NONCE");
await rpcClient.ProcessAsync(receiveBlock);

Also tried the send block example and I got the following error:
Nano.Net.RpcException: 'RPC call returned error. Message: Block is invalid'
I followed the code from example changing only: Amount.FromRaw("1") to Amount.FromNano("0.001")
var receiveBlock = Block.CreateReceiveBlock(account, "PENDING_BLOCK_HASH", Amount.FromNano("0.001"), "POW_NONCE");

Hey, I'm not able to reproduce the issue you're having.
I'm assuming you're replacing "PENDING_BLOCK_HASH" and "POW_NONCE" with the correct values, correct? If you are, please send more details about the error.

So here is the code in vb.net for receive:
Dim acc As Account = Account.FromPrivateKey(txtSeeds.Text)
Dim rpc As New RpcClient(NODE_ADDR)
Await rpc.UpdateAccountAsync(acc)
Dim receiveBlock As Block = Block.CreateReceiveBlock(acc, "PENDING_BLOCK_HASH", Amount.FromNano("0.001"), "POW_NONCE")
Await rpc.ProcessAsync(receiveBlock)

And here is for send:
Dim acc As Account = Account.FromPrivateKey(txtSeeds.Text)
Dim rpc As New RpcClient(NODE_ADDR)
Await rpc.UpdateAccountAsync(acc)
'Creates a block and automatically sign it. The PoW nonce has to be obtained externally.
Dim sendBlock As Block = Block.CreateSendBlock(acc, txtWallet.Text, Amount.FromNano("0.001"), "POW_NONCE")
'Publish the block to the network.
Await rpc.ProcessAsync(sendBlock)

Btw, where can i find list of available commands and explanations for "POW_NONCE" and "PENDING_BLOCK_HASH" ?

"POW_NONCE" and "PENDING_BLOCK_HASH" are simply placeholders for their values.
You need to replace PENDING_BLOCK_HASH with the hash of the block you're trying to receive and POW_NONCE with the proof of work nonce you've generated for this block.

Oh I see. Now everything make sense. However, how do I obtain the PENDING_BLOCK_HASH for pending transaction  and also the POW_NONCE? I read the comment about getting the POW_NONCE externally, how to do that?

You can create an RpcClient object and use its PendingBlocksAsync method to fetch pending blocks for an account. You can find the block hash in the hash property of a ReceivableBlock object.

I read the comment about getting the POW_NONCE externally, how to do that?

About this part, there are multiple ways to do this, but the easiest one would be running nano-work-server (you'll need a GPU or a decent CPU), create a new RpcClient object with its address and calling the WorkGenerateAsync method. You could also run a node or use a 3rd party service.
For more information about work generation you should check https://docs.nano.org/integration-guides/work-generation/ and if you need further help with nano itself I recommend you join the official Discord server.

Great, thank you for your explanation !

Btw, I am using public node api that support 'work_generate'. I can get the pending hash and I tried to get the nonce with:
workResponse = Await rpc.WorkGenerateAsync(rcvBlock.Hash)
Then I call:
Dim receiveBlock As Block = Block.CreateReceiveBlock(acc, rcvBlock.Hash, Amount.FromRaw(rcvBlock.Amount), workResponse.Work)
Await rpc.ProcessAsync(receiveBlock)
but I got:
'RPC call returned error. Message: Block work is less than threshold'
Is it correct to put workResponse.Work into "NONCE_POW" field?

I tried the following difficulties: "fffffe0000000000", "ffffffc000000000" and "fffffff800000000", all not working. I tried to google the error message but still can't get any solution. Can you please help? Below is full receive code:
    Dim acc As Account = Account.FromPrivateKey(txtSeeds.Text)
    Dim rpc As New RpcClient(NODE_ADDR) 'https://mynano.ninja/api/node

    'Check for pending blocks
    Dim response As ReceivableBlocksResponse
    Dim rcvBlock As ReceivableBlock
    Dim workResponse As WorkGenerateResponse

    Await rpc.UpdateAccountAsync(acc)

    response = Await rpc.PendingBlocksAsync(acc.Address)

    If response.PendingBlocks.Count > 0 Then
        For Each kvp As KeyValuePair(Of String, ReceivableBlock) In response.PendingBlocks
            rcvBlock = kvp.Value

            workResponse = Await rpc.WorkGenerateAsync(rcvBlock.Hash)

            Dim receiveBlock As Block = Block.CreateReceiveBlock(acc, rcvBlock.Hash, Amount.FromRaw(rcvBlock.Amount), workResponse.Work)

            Await rpc.ProcessAsync(receiveBlock)

        Next
    End If

Sorry, I've only seen this comment now, and I think others have already helped you in the nano server.
Also, this is not the right place to get support for issues that are related to the protocol itself. You should ask about these things in the nano server after looking through the docs.

it's ok. I got it all resolved. thanks and great library ! :)


Building packages from AUR using python provided by asdf-vm fails

Provide environment information
OS:
Linux FX505DT 6.7.0-arch3-1 #1 SMP PREEMPT_DYNAMIC Sat, 13 Jan 2024 14:37:14 +0000 x86_64 GNU/Linux

SHELL:
GNU bash, version 5.2.26(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

BASH VERSION:
5.2.26(1)-release

ASDF VERSION:
v0.13.1-0586b37

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=/home/ferret/.asdf
ASDF_DIR=/home/ferret/.asdf
ASDF_CONFIG_FILE=/home/ferret/.asdfrc

ASDF INSTALLED PLUGINS:
bun                          https://github.com/cometkim/asdf-bun.git main e503786
nodejs                       https://github.com/asdf-vm/asdf-nodejs.git master c5b7c40
python                       https://github.com/danhper/asdf-python.git master 5e277e2

To Reproduce

Use arch based linux system
Use global latest python from asdf-vm.
Install packages that depend on python, like tlpui from AUR
Build will fail

Describe the Bug
tlpui build fails.
==> Starting build()...
/home/ferret/.asdf/installs/python/3.12.1/bin/python: No module named build
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: tlpui-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
tlpui - exit status 4

To be honest, I do not know if this is asdf related, if I did not configure asdf properly or if this is an tlpui bug.
Expected Behaviour
tlpui build should not fail.

Seems like I needed to set python to system version because otherwise it would not see the dependencies installed through pacman. This can be done with the command asdf global python system.


Colocate table stays unstable when a large number of be restarts frequently

Describe the bug
When colocate table balance, if multiple be down, the tablets will be distributed to the existing machines, but if the existing machine disk is not enough to accommodate these tablets, and the balance must wait for the migration of these tablets to complete,  The strategy will fall into an endless loop.

fix in #4936


Broken images cause PDF export to fail

Describe the Bug

When an image is broken, it causes the complete PDF export to fail
Steps to Reproduce
https://integreat.app/testumgebung/de/test-broken-photo-pdf
https://cms.integreat-app.de/testumgebung/de/wp-json/ig-mpdf/v1/pdf?url=%2Ftestumgebung%2Fde%2Ftest-broken-photo-pdf
Expected Behavior

We should ignore the image or show a placeholder, but generate the PDF
Actual Behavior

An internal server error occurs
Additional Information

Traceback
Jul 23 22:12:01 WARNING integreat_cms.cms.utils.pdf_utils - The file 'https://integreat.app/dortmund
/wp-content/uploads/sites/187/2017/11/calendar60-1.png' is not inside the static directories '/stati
c/' and '/media/'.
Jul 23 22:12:03 WARNING xhtml2pdf - Error in handling image
'<img class="alignnone wp-image-589" src="https://integreat.app/dortmund/wp-content/uploads/sites/187/2017/11/calendar60-1.png" alt="" width="15" height="15" dir="rtl"/>'
Traceback (most recent call last):
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/xhtml2pdf/xhtml2pdf_reportlab.py", line 323, in __init__
  self._image = self._read_image(self.fp)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/xhtml2pdf/xhtml2pdf_reportlab.py", line 353, in _read_image
  return PILImage.open(fp)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/PIL/Image.py", line 3298, in open
  raise UnidentifiedImageError(msg)
PIL.UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x7fcde76a5360> fileName=<_io.BytesIO object at 0x7fcde76a5360>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/xhtml2pdf/tags.py", line 354, in start
  img = PmlImage(
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/xhtml2pdf/xhtml2pdf_reportlab.py", line 467, in __init__
  img = self.getImage()
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/xhtml2pdf/xhtml2pdf_reportlab.py", line 528, in getImage
  img = PmlImageReader(imgdata)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/xhtml2pdf/xhtml2pdf_reportlab.py", line 342, in __init__
  raise RuntimeError("{0} {1} {2}".format(et, ev, tb))
RuntimeError: <class 'PIL.UnidentifiedImageError'> cannot identify image file <_io.BytesIO object at 0x7fcde76a5360> fileName=<_io.BytesIO object at 0x7fcde76a5360> <traceback object at 0x7fcde7fd5c00>

I decided to fix this problem in the upstream library:
https://github.com/xhtml2pdf/xhtml2pdf/pull/723
It will take a while until we can profit from this change, since updating is blocked at the moment (see  #2047), but eventually we will get there :smile:


feat: custom actions for user maintenance and debug triggers

This provides user maintenance triggers to either kick users from the system or login as any user. This feature is only available for "root" users.
The PR enables to use translate()-objects in adminInfos as well.

Just as hint, the adminInfo can be subclasses this way now to inherit the actions:
class User(User):

    adminInfo = User.adminInfo | {
        "columns": ["lastname", "firstname", "name", "responsibility"],
        "filter": {"orderby": "lastname"},
        "disabledActions": [
            "add",
            "clone",
            "delete"
        ],
    }

@sveneberth I've implemented your recommendations and merged, updated and tested against current develop.
Can we now merge?


Add Tinkerbell label selector and configure disk type in the template…

Description of changes:
In this PR, I have added Tinkerbell label selector in the cluster config file and configured disk type in the template config field.

/override codecov/patch


Refine CopyScheduler.fileCompare

Currently, CopyScheduler will compare local file and remote file according file length and checksum. But, segments comparison based on checksum is not well designed. @duzhen1996

Out of date. Issue closed.


add delete group functionality

Depends on https://github.com/mitre/caldera/pull/244/files for operations view to work smoothly


gramma

not sure if that's grammatically correct
"This feature triggers brings the primary server down and initiates the failover workflow in which the standby promote operation is performed."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 517e4390-b753-b794-f705-a3a995247917
Version Independent ID: 7f28cd80-7ffa-ba7a-ed87-2cab1764f49a
Content: Overview of zone redundant high availability with Azure Database for PostgreSQL - Flexible Server
Content Source: articles/postgresql/flexible-server/concepts-high-availability.md
Service: postgresql
GitHub Login: @sr-msft
Microsoft Alias: srranga

Hi, @AwdotiaRomanowna Thanks for your feedback! We will investigate and update as appropriate.

Hi @kabharati Can you please provide your input.

@GeethaThatipatri-MSFT - I agree this appears the be a typo error. Let me fix it

#reassign @kabharati
thank you.

seems complete.

#please-close


Crash when TMDB is not reacheable

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

📝 Description
Application seems to crash if TMDB is not reacheable.
thread 'main' panicked at src/trakt.rs:130:22:
TMDB API call failed: Transport(Transport { kind: Io, message: None, url: Some(Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("api.themoviedb.org")), port: None, path: "/3/tv/106379/season/1/images", query: Some("api_key=21b815a75fec5f1e707e3da1b9b2d7e3"), fragment: None }), source: Some(Custom { kind: HostUnreachable, error: Transport(Transport { kind: Io, message: Some("Error encountered in the status line"), url: None, source: Some(Os { code: 65, kind: HostUnreachable, message: "No route to host" }) }) }) })

🪜 Steps To Reproduce

Start the app
Have it running without issues for a while
TMDB has some hiccup and it crashes

ℹ System Info
OS: Darwin (MacOS 14.4.1)
Project: 1.5.0.

📸 Screenshots
No response

Fixed in #125


Added from a slave

Fixes #.
Description of the changes:

How changes were validated:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mouna-slave sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


v2.0.45 Settings backup not writing a settings.txt file

Not sure if it's an issue specific to my machine, but the previous release saved the settings backup with no issue. Latest release gives the usual message that a settings.txt file was saved, but it's not in the folder.

Did you use the Backup button or the Save button? With Backup, I get a settings.txt file in the directory.  Another possibility, does the directory require Administrator privilege?

Definitely clicking backup. Admin privileges for the folder could well be it. Will double check.

I've never quite understood how the whole admin thing works in Windows when you try to write to something that you don't have privilege to. I think a lot of apps fail silently. Is there a failure notification that happens at the application level?  If it does, it would be really nice for ioSender to notify the user - could make it easy to solve related problems.

It is a bit strange because I don't recall changing the program folder permissions for the previous release, and it's in the same place.


VFL: in-each function

I known one of your big points in GSS is source-order independence, but most markup is relational (e.g. sibling nodes should appear adjacent to one another).  Consider the following markup:

            Title of something!

            More info about something!

            Title of something else!

            More info about something else!

            Title of a third thing!

            More info about a third thing!

It would be awesome if I could write something like:
@v |
   -
   [h4]
   -
   [p]
   -
   |

   gap(16)
   in-each(li);

To have it iterate over each li and then apply that VFL scoped to just its children.

li {
    @v |-[p]-[h4]-| gap(16);
}

Selectors are now locally scoped by default, so the following would do what you originally requested:
li {
    @v |-(h4)-(p)-| gap(16);
}


refactor(robot-server): add maintenance runs to the router

Overview
closes https://opentrons.atlassian.net/browse/RSS-199.
Test Plan
Create an empty run via postman.
Post run commands with no intent.
The run should play along the commands as they are dispatched.
Changelog

Added maintenance_runs to the main router.
Added maintenance_runs router and add base_router and commands_router.

Review requests
@sanni-t:
still need to add integration tests and labware_router.
we might need to rename the files with a maintenance prefix. I changed some of them but not all.
engine_store change can be done in a separate pr.
Risk assessment
Medium. more to smoke test after engine_store change but for now just added a new router for maintenance runs.

This work was continued in a new branch RSS-199-add-a-maintenance-run-route. Opened PR #12462 on that branch.


Fix typo guid -> instance_id

...to make the section self-consistent.

There sre other spots,did you want to fix those too?

Actually, yes, I missed one

LGTM

LGTM

LGTM

LGTM

LGTM


Start-Process in new window does not work on macOS

The documentation for Start-Process mentions that executing the child process in a separate window is the default behavior, and the -NoNewWindow parameter exists to prevent it. Indeed, this is how it behaves on Windows.
The same documentation also contains a note that on Linux, the -UseNewEnvironment should be used to achieve the same behavior. There is no explicit mention of macOS.
I'm building a cross-platform solution where a requirement is for the new window behavior to be consistent across both Windows and macOS, but based on my testing so far, the child process is always executed within the current terminal window on macOS.
Steps to reproduce
One of the following:
Start-Process pwsh-preview -WorkingDirectory ~/Temp -ArgumentList "-File .\SomeScript.ps1" -Wait
Start-Process pwsh-preview -WorkingDirectory ~/Temp -ArgumentList "-File .\SomeScript.ps1" -UseNewEnvironment -Wait

Expected behavior
The external script SomeScript.ps1 should be executed in a new terminal window.

Actual behavior
The external script SomeScript.ps1 is instead executed in the same terminal window.

Environment data
Name                           Value
----                           -----
PSVersion                      7.0.0-preview.6
PSEdition                      Core
GitCommitId                    7.0.0-preview.6
OS                             Darwin 19.0.0 Darwin Kernel Version 19.0.0: Wed Oct 23 18:29:05 PDT 2019; root:xnu-6153.41.3~44/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I think it is docs issue
From https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.createnowindow?view=netcore-3.0

.NET Core does not support creating windows directly on Unix-like platforms, including macOS and Linux. This property is ignored on such platforms.


Fighting underwater monsters causes crashes

i usually get a few hits in, between 3 to 10, but the game always crashes. some of the monsters also just don't take damage, even with 5 star+ weapons

update - even just pulling their aggro can cause the game to crash

this still happens, going underwater guarantees a crash and you don't even have to do anything - if a mob gets aggressive with u the game crashes and some of them don't take damage. however i've noticed that this doesn't happen in the first hours of gameplay with a new character, the issue appears after playing with the same character for a long time

Hi, so i found out whats the problem, its the mod6 in the pack, if u ingame and type in /mod 6 0 and restart the game it will change back your world to its original form, because this mod makes oceans out of lands and thats why the game keep crashing, u are got hit "under land" and the mod cant handle that, so u will be fine in the original generated oceans.


Removes quarantine label from tests 1015 4643

What this PR does / why we need it:
Removes quarantine label from tests 1015 and 4643
Did not see failure since merging the CIDR/Calico fixes to kubevirt.
Original issues where the tests were found as flaky:
https://github.com/kubevirt/kubevirt/issues/4961
https://github.com/kubevirt/kubevirt/issues/4939
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/cc @fgimenez
/cc @mhenriks

/approve


Error when updating to Brixton SR2

Hello,
I have a gateway microservice implementation in a Spring Boot Application using Zuul that redirects Oauth2 authenticated requests to other microservices using Eureka.
I'm using the resource server token relay how is indicated in the documentation with the only difference of using Ribbon load balancer:
@LoadBalanced
@Autowired
private OAuth2RestOperations restTemplate;

@RequestMapping("/relay")
public String relay() {
    ResponseEntity<String> response = restTemplate.getForEntity("http://OTHER-SERVICE-REGISTERED-IN-EUREKA/bar", String.class);
    return "Success! (" + response.getBody() + ")";
}

It was working properly in Spring Cloud Brixton M5 but when updating to Spring Cloud Brixton SR2 I'm getting the following exception:
java.lang.NoSuchMethodError: org.springframework.cloud.netflix.zuul.filters.ProxyRequestHelper.setTraces(Lorg/springframework/boot/actuate/trace/TraceRepository;)

I could check that the setTraces method has been recently removed and to reproduce the error only is required to include the spring-cloud-starter-oauth2 dependency:
<dependency>
    <groupId>org.springframework.cloud</groupId>
    <artifactId>spring-cloud-starter-oauth2</artifactId>
</dependency>

Is this a bug? a kind of breaking compatibility? or I'm missing something?
Thanks

could you post the full stack trace?

Duplicates https://github.com/spring-cloud/spring-cloud-security/issues/97

Yes, It's the same issue. Sorry I couldn't find it.
Thank you guys.


Dropdown component value format property updates fail to save in dataTable

After attempting to modify the value format of a dropdown component within the DataTable, changes fail to save. For instance, updating the default value from 'simple item value' to 'reference list item' . Upon revisiting configurations, the value reverts back to the default setting
Steps to reproduce the behavior:

Go to 'https://function-adminportal-test.shesha.dev/shesha/forms-designer?id=7c46835d-4b02-401d-98d8-04c90574e99c'
Click on 'dataTable'
Scroll down to 'membershipStatus'
Click on configure button on edit/create component property
Update value format value to any of the options available
Save your changes
Refresh the page
Navigate back to your configurations and check the value format you've updated
Actual Results: The value format has reverted back to the default value

Expected behavior
When you update value format, the changes should be saved successfully and not revert back to the default value
Related item
#1039

Hi @AlexStepantsov , I've re-open this item. After the implementation of this item: https://github.com/shesha-io/shesha-framework/issues/1056, the changes you added have been reverted back
Here's a new link: https://function-adminportal-test.shesha.dev/shesha/forms-designer?id=9230268b-aaf4-433c-8c1c-82a1b079a1c0

Dropdown in the DataTable works only in Simple mode due to validation limetation
We will improve this if there are corresponding requirements in real use


Scroll Left to Right

Hi,
Thanks for sharing this library.
I use the MarqueeText.ino example.
How do I scroll from left to right. (I use Arabic.)
I made a few changes but I didn't succeed.
Thanks.

Hi,
This example has been created by one of the contributors and they basically created all the logic with right-to-left in mind. The complex solution is to try to invert all the loops (drawing characters, drawing on the display).
The simple solution is to invert the whole display in x axis, then pixel column 0 will be on the right.
To invert the display pass INVERT_DISPLAY_X in the constructor of the object:
https://github.com/bartoszbielawski/LEDMatrixDriver/blob/master/examples/MarqueeText/MarqueeText.ino#L15
Use:
LEDMatrixDriver lmd(LEDMATRIX_SEGMENTS, LEDMATRIX_CS_PIN, INVERT_DISPLAY_X);
Of course latin letters will be inverted but I guess you need to provide your own letters anyway.
Let me know if this helped.
Bartosz

Thanks for the quick reply
But I get the following error:
MarqueeText: 15: 59: error: 'INVERT_DISPLAY_X' was not declared in this scope
 LEDMatrixDriver lmd (LEDMATRIX_SEGMENTS, LEDMATRIX_CS_PIN, INVERT_DISPLAY_X);
                                                                                ^
exit status 1
'INVERT_DISPLAY_X' was not declared in this scope

My bad. I forgot the constant lives in the class. Try this:
LEDMatrixDriver lmd (LEDMATRIX_SEGMENTS, LEDMATRIX_CS_PIN, LEDMatrixDriver::INVERT_DISPLAY_X);

My bad. I forgot the constant lives in the class. Try this:
LEDMatrixDriver lmd (LEDMATRIX_SEGMENTS, LEDMATRIX_CS_PIN, LEDMatrixDriver::INVERT_DISPLAY_X);

I tested. Unfortunately this method does not work.

Well, if you can tell me what doesn't work I can suggest a solution. You can always write your own code from scratch. The library doesn't really care about texts, it cares only about pixels.

Well, if you can tell me what doesn't work I can suggest a solution. You can always write your own code from scratch. The library doesn't really care about texts, it cares only about pixels.

Thanks Bartosz,
I used the original code.
According to you, I made the following change to the code and output was the same as the video below:
LEDMatrixDriver lmd (LEDMATRIX_SEGMENTS, LEDMATRIX_CS_PIN, LEDMatrixDriver::INVERT_DISPLAY_X);
Demo

I'm sorry for late replies, for some reason I get no notifications.
Also the vimeo link doesn't work...
If I find time I may try myself at home later today.

I'm sorry for late replies, for some reason I get no notifications.
Also the vimeo link doesn't work...
If I find time I may try myself at home later today.
Thanks,
I changed the video link.

Ah, I see the problem. Now segments are inverted as well. Try this one:
LEDMatrixDriver lmd (LEDMATRIX_SEGMENTS, LEDMATRIX_CS_PIN, LEDMatrixDriver::INVERT_DISPLAY_X | LEDMatrixDriver::INVERT_SEGMENT_X);
And let me know if it helped.

You can also try to modify this example:
https://github.com/bartoszbielawski/LEDMatrixDriver/blob/master/examples/AFGFXMarquee/AFGFXMarquee.ino
It uses a different approach. First it renders text into a buffer and then only copies it to the display.
It may be that making this one work needs only inverting a counter or two.

Ah, I see the problem. Now segments are inverted as well. Try this one:
LEDMatrixDriver lmd (LEDMATRIX_SEGMENTS, LEDMATRIX_CS_PIN, LEDMatrixDriver::INVERT_DISPLAY_X | LEDMatrixDriver::INVERT_SEGMENT_X);
And let me know if it helped.

Thanks, Everything is okay but apparently the text is mirrored. Please see the video.

You can also try to modify this example:
https://github.com/bartoszbielawski/LEDMatrixDriver/blob/master/examples/AFGFXMarquee/AFGFXMarquee.ino
It uses a different approach. First it renders text into a buffer and then only copies it to the display.
It may be that making this one work needs only inverting a counter or two.

I'll examine this example. Of course, because I made the font, I need a function like setpixel(x, y) to display.

I solved the problem.
Replace lines 110 to 112 with the following code:
  #ifdef L2R
  //Scroll left to right
    if( ++x > LEDMATRIX_WIDTH ){
    x = -len*8;
    }
  #endif
  #ifdef R2L
  //Scroll right to left
    // Advance to next coordinate
  if( --x < len * -8 ) {
    x = LEDMATRIX_WIDTH;
  }
  #endif

Only un-comment one of the lines below. (Insert these lines at the beginning of the code.)
#define L2R
//#define R2L

Would you care to make a pull request with your changes? Some other people could benefit from the improved example.

Would you care to make a pull request with your changes? Some other people could benefit from the improved example.

I will do.

Thank you. Can I close the issue or do you have more questions?


Update QuickstartBasicToolkit.md

It seems that the init_trainer is integrated into set_device

@shaydeci can you approve?


[Linux] radios and switches have wrong accessibility roles

Orca Screen Reader considers radios and switches as checkboxes because anything checkable or toggleable has the "checkbox" accessibility role.
Steps to Reproduce

Turn on the screen reader (Settings -> Accessibility -> Screen Reader)
Execute flutter run on the code sample
Press Tab to navigate around

Expected results:
Match the behavior with GTK:

Radio buttons are read as "radio buttons"
Switches are read as "toggle buttons"

Actual results:
Checkboxes, radio buttons, and switches are all read as "checkboxes".

Code sample

import 'package:flutter/material.dart';

void main() {
  final checked = ValueNotifier<bool>(true);

  runApp(
    MaterialApp(
      home: Scaffold(
        body: ValueListenableBuilder<bool>(
          valueListenable: checked,
          builder: (context, value, _) {
            return Column(
              children: [
                Checkbox(
                  value: value,
                  onChanged: (v) => checked.value = v!,
                ),
                Radio<bool>(
                  value: value,
                  groupValue: true,
                  onChanged: (v) => checked.value = v!,
                ),
                Switch(
                  value: value,
                  onChanged: (v) => checked.value = v,
                )
              ],
            );
          },
        ),
      ),
    ),
  );
}

Logs

[✓] Flutter (Channel master, 2.13.0-0.0.pre.393, on Ubuntu Jammy Jellyfish (development branch) 5.15.0-25-generic, locale en_US.UTF-8)
    • Flutter version 2.13.0-0.0.pre.393 at /home/jpnurmi/Flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 94fefaa49d (5 hours ago), 2022-04-06 17:17:34 +0530
    • Engine revision 45bedbe841
    • Dart version 2.17.0 (build 2.17.0-266.0.dev)
    • DevTools version 2.12.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /home/jpnurmi/Android/Sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_SDK_ROOT = /home/jpnurmi/Android/Sdk
    • Java binary at: /home/jpnurmi/Android/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 14.0.0-1ubuntu1
    • cmake version 3.22.1
    • ninja version 1.10.1
    • pkg-config version 0.29.2

[✓] Android Studio (version 2020.3)
    • Android Studio at /home/jpnurmi/Android/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code
    • VS Code at /snap/code/current
    • Flutter extension version 3.38.1

[✓] Connected device (1 available)
    • Linux (desktop) • linux • linux-x64 • Ubuntu Jammy Jellyfish (development branch) 5.15.0-25-generic

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Fix available: https://github.com/flutter/engine/pull/32454

Hi @jpnurmi, thanks for filing the issue. I ran your code sample with a screen reader enabled (orca screen reader) on the latest stable and the master channel. But the screen Reader doesn't read anything at all. Tried changing the state of widgets with the mouse and keyboard. The screen reader only mentions the keys pressed, But nothing about the widget or its state. Verified on the Desktop and the web.

flutter doctor -v (Linux)
[✓] Flutter (Channel stable, 2.10.4, on Ubuntu 20.04.4 LTS 5.13.0-30-generic, locale en_GB.UTF-8)
    • Flutter version 2.10.4 at /home/mahesh/Development/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (12 days ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /home/mahesh/Android/Sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /home/mahesh/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2020.3)
    • Android Studio at /home/mahesh/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio
    • Flutter plugin version 63.2.1
    • Dart plugin version 203.8452
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.64.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.38.1

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Ubuntu 20.04.4 LTS 5.13.0-30-generic
    • Chrome (web)    • chrome • web-javascript • Google Chrome 98.0.4758.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 2.13.0-0.0.pre.392, on Ubuntu 20.04.4 LTS 5.13.0-30-generic, locale en_GB.UTF-8)
    • Flutter version 2.13.0-0.0.pre.392 at /home/mahesh/Development/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 120b3deb18 (20 minutes ago), 2022-04-06 10:59:37 +0200
    • Engine revision 45bedbe841
    • Dart version 2.17.0 (build 2.17.0-266.0.dev)
    • DevTools version 2.12.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /home/mahesh/Android/Sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /home/mahesh/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2020.3)
    • Android Studio at /home/mahesh/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio
    • Flutter plugin version 63.2.1
    • Dart plugin version 203.8452
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.64.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.38.1

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Ubuntu 20.04.4 LTS 5.13.0-30-generic
    • Chrome (web)    • chrome • web-javascript • Google Chrome 98.0.4758.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Let me know if I am missing anything?

There might be several issues in the game (*) but I'm trying to focus on the button roles in this bug report. :smile: Here's a recording with the latest Flutter master on Ubuntu 22.04.
https://user-images.githubusercontent.com/140617/162153311-61abe9f4-fa98-41a5-a227-04428df4b3ef.mp4
*) The Orca screen reader tends to have strange issues with Flutter apps. Sometimes it gets in a state that it starts somehow ignoring Flutter apps/widget even though other non-Flutter apps are read fine.

I see, On my machine orca doesn't seem to read the futter widgets at all
output from stable
https://user-images.githubusercontent.com/31410839/162206570-e31f0670-2a55-4c2d-9e7c-15055581b6f6.mp4
While on the master channel it only reads "Tab" I am using orca 3.36.2
Labeling this issue for further insights from the team.

Update: I modified orca settings to read components under the mouse and  I can see that all three widgets are read as checkboxes.
Unmute the video for audiovisual output
https://user-images.githubusercontent.com/31410839/162213449-9424c2e4-127b-4451-9ea0-5921202782ee.mp4

flutter doctor -v (Linux)
[✓] Flutter (Channel stable, 2.10.4, on Ubuntu 20.04.4 LTS 5.13.0-30-generic, locale en_GB.UTF-8)
    • Flutter version 2.10.4 at /home/mahesh/Development/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (12 days ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /home/mahesh/Android/Sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /home/mahesh/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2020.3)
    • Android Studio at /home/mahesh/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio
    • Flutter plugin version 63.2.1
    • Dart plugin version 203.8452
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.64.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.38.1

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Ubuntu 20.04.4 LTS 5.13.0-30-generic
    • Chrome (web)    • chrome • web-javascript • Google Chrome 98.0.4758.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 2.13.0-0.0.pre.392, on Ubuntu 20.04.4 LTS 5.13.0-30-generic, locale en_GB.UTF-8)
    • Flutter version 2.13.0-0.0.pre.392 at /home/mahesh/Development/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 120b3deb18 (20 minutes ago), 2022-04-06 10:59:37 +0200
    • Engine revision 45bedbe841
    • Dart version 2.17.0 (build 2.17.0-266.0.dev)
    • DevTools version 2.12.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /home/mahesh/Android/Sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /home/mahesh/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2020.3)
    • Android Studio at /home/mahesh/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio
    • Flutter plugin version 63.2.1
    • Dart plugin version 203.8452
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.64.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.38.1

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Ubuntu 20.04.4 LTS 5.13.0-30-generic
    • Chrome (web)    • chrome • web-javascript • Google Chrome 98.0.4758.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!


Figure out org.jruby.embed.InvokeFailedException from InvocationTargetException: Fix #943

It was the cause of #943. JRuby's InvokeFailedException can be thrown inside InvocationTargetException.
Can you have a look? @muga @sakama
The class ScriptingContainerDelegate intentionally has some code clones so that Exceptions are explicitly created at the error points, not in utility methods.

Thanks. Merging!


cordova-plugin-ionic-webview,tips:"Unable to load app"

If there are multiple ios projects generated by ionic on the phone, when they start separately, they will appear Unable to start. I have tested cordova-plugin-ionic-webview plugin. I hope to fix the bug of this plugin. Thank you...

you can try it..

the plugin version my used is 2.2.3..

To avoid collision between apps you have to use a different port on every app with the WKPort preference like <preference name="WKPort" value="8089" />.
Or use <preference name="UseScheme" value="true" /> which won't use the web server.

I added the above method in the config.xml file, but it did not take effect. Was the location I added wrong? ...

To avoid collision between apps you have to use a different port on every app with the WKPort preference like <preference name="WKPort" value="8089" />.
Or use <preference name="UseScheme" value="true" /> which won't use the web server.

I tried both of the above methods, but they didn't seem to work. I added and built the project in the config.xml file.


Valid location with bukkit location is broken.

In Exact destination, use else if not just if.

Please submit a pull request to fix this.

I see that you submitted a pull request. Please describe in the pull request or issue exactly what this fixes. What is the problem that occurs without this change? Be descriptive.

done and done:  https://github.com/Multiverse/Multiverse-Core/pull/1580

You see, in the Class Exact location, You have the method setExactLocation(Location location).
the contents now are as follows:
       if (location != null) {
            this.location = location;
            this.isValid = true;
        }
        this.isValid = false;

because the statement this.isValid = false is outside the if block, there is no wway to set a valid location  with this method.
I added an else{} branch after the if containing the this.isValid statement. This makes the location setting once again possible via Bukkit locations.

updated pull request

I understand the code itself. I'm wanting to know what isn't actually working right in the plugin.

"there is no way to set a valid location with this method."
basically the entire method is useless as of now,

I disagree. If the location isn't null, it sets the location to whatever you provided and specifies that the location is valid.

Even if the method is useless, what is the BUG this is causing in the plugin?

then, it sets location.isValid to false , no matter the parameter. whenever you call this method, the boolean variable isValid will always turn to false.

Ah, I was missing the fact that isValid = false was already there. In any case, what is the problem this is causing in the plugin?

It's more the API than the plugin, I was developing a plugin that allows players to built multiverse portals the same way nether portals are built, and because this method is broken I cannot set a valid location for the portal.

Makes sense now. I didn't merge your pull for formatting issues but I credited you in the commit message.


Cannot find type definition file for

Hi, guys!
Something broke after the update. I don't know where to look for the problem

Could you please check which version introduced this regression?

@so1ve For me it's only on 1.8.1 trying to npm run build
reverting back to 1.8.0 solves the issue.

Could you please check which version introduced this regression?

i doubt it is vue-tsc. Most likely some kind of dependency.
I had "vue-tsc" version: "^1.6.5"
Since the last update of package-lock.json it has been working.
Now if I just delete package-lock.json and node_modules and run npm install with version "vue-tsc": "^1.6.5" , this kind of error appears

Tried 1.8.3, still getting the same error:
error TS2688: Cannot find type definition file for ''.
  The file is in the program because:
    Entry point for implicit type library ''

Found 1 error.

Here's my dependencies, in case this is caused by incompatibilities with certain package(s).

Dependencies
"dependencies": {
  "@headlessui/vue": "^1.7.14",
  "@sentry/vue": "^7.57.0",
  "axios": "^1.4.0",
  "clipboard-copy": "^4.0.1",
  "date-fns": "^2.30.0",
  "dompurify": "^3.0.4",
  "easymde": "^2.18.0",
  "firebase": "^9.23.0",
  "highcharts-vue": "^1.4.2",
  "pinia": "^2.1.4",
  "radash": "^11.0.0",
  "sortablejs": "^1.15.0",
  "sortablejs-vue3": "^1.2.9",
  "v-money": "^0.8.1",
  "v-money3": "^3.24.0",
  "vue": "^3.3.4",
  "vue-cropperjs": "^5.0.0",
  "vue-router": "^4.2.2",
  "vue3-easymde": "^1.0.1"
},
"devDependencies": {
  "@gradin/tailwindcss-scrollbar": "^3.0.1",
  "@gradin/tailwindcss-skeleton-screen": "^1.0.2",
  "@types/dompurify": "^3.0.2",
  "@types/node": "^20.3.3",
  "@types/vue-cropperjs": "^4.1.2",
  "@typescript-eslint/eslint-plugin": "^5.60.1",
  "@typescript-eslint/parser": "^5.60.1",
  "@vitejs/plugin-vue": "^4.2.3",
  "autoprefixer": "^10.4.14",
  "eslint": "^8.44.0",
  "eslint-plugin-import": "^2.27.5",
  "eslint-plugin-simple-import-sort": "^10.0.0",
  "eslint-plugin-vue": "^9.15.1",
  "postcss": "^8.4.24",
  "postcss-import": "^15.1.0",
  "rollup-plugin-visualizer": "^5.9.2",
  "stylelint": "^15.9.0",
  "stylelint-config-standard": "^33.0.0",
  "tailwindcss": "^3.3.2",
  "typescript": "^5.1.6",
  "vite": "^4.3.9",
  "vue-tsc": "^1.8.0"
}

And how does your tsconfig.json look like?

@rchl does it matter?
Is there a breaking change between 1.8.0 to 1.8.1 involving the tsconfig?
Here's mine:
{
  "compilerOptions": {
    "target": "ESNext",
    "module": "ESNext",
    "useDefineForClassFields": true,
    "moduleResolution": "Node",
    "strict": true,
    "jsx": "preserve",
    "sourceMap": true,
    "resolveJsonModule": true,
    "isolatedModules": true,
    "esModuleInterop": true,
    "forceConsistentCasingInFileNames": true,
    "lib": [
      "ESNext",
      "DOM"
    ],
    "skipLibCheck": true,
    "baseUrl": "./src",
    "paths": {
      "@/*": [
        "*"
      ]
    },
    "typeRoots": [
      "./node_modules/@types",
      "./src/types"
    ]
  },
  "vueCompilerOptions": {
    "jsxTemplates": false,
    "narrowingTypesInInlineHandlers": true
  },
  "include": [
    "src/**/*.ts",
    "src/**/*.d.ts",
    "src/**/*.tsx",
    "src/**/*.vue"
  ],
  "references": [
    {
      "path": "./tsconfig.node.json"
    }
  ]
}

i doubt it is vue-tsc. Most likely some kind of dependency.
I had "vue-tsc" version: "^1.6.5" Since the last update of package-lock.json it has been working.
Now if I just delete package-lock.json and node_modules and run npm install with version "vue-tsc": "^1.6.5" , this kind of error appears

@gewisser
in package.json, having "^1.6.5" and do npm install will install the latest v1, which is 1.8.1, or now it's 1.8.3
unless you change it to just "1.6.5", then it will install 1.6.5 exactly.

tsconfig.json configuration affects everything that Volar does.
Providing as much information as possible can help in figuring out what the issue is.
Even better if you would provide a repo that reproduces.

Tried to figure out the file / config that causes this issue.
Found out the issue is using typeRoots property on tsconfig.json
npm run build using<EMAIL_ADDRESS>  works
npm run build using<EMAIL_ADDRESS>error
Here is the reproduction https://github.com/christhofer/repro-vuetsc-issue-3317
git clone https://github.com/christhofer/repro-vuetsc-issue-3317.git
cd repro-vuetsc-issue-3317
npm install
npm run build

i doubt it is vue-tsc. Most likely some kind of dependency.
I had "vue-tsc" version: "^1.6.5" Since the last update of package-lock.json it has been working.
Now if I just delete package-lock.json and node_modules and run npm install with version "vue-tsc": "^1.6.5" , this kind of error appears

@gewisser in package.json, having "^1.6.5" and do npm install will install the latest v1, which is 1.8.1, or now it's 1.8.3 unless you change it to just "1.6.5", then it will install 1.6.5 exactly.

+
Then the last version that works for me is 1.7.14
tsconfig.json
{
  "compilerOptions": {
    "baseUrl": "./",
    "target": "ESNext",
    "useDefineForClassFields": true,
    "module": "ESNext",
    "moduleResolution": "Node",
    "strict": true,
    "jsx": "preserve",
    "sourceMap": true,
    "resolveJsonModule": true,
    "esModuleInterop": true,
    "lib": ["ESNext", "DOM"],
    "skipLibCheck": true,
    "paths": {
      "~/*": ["src/*", "./src/*"],
      "~shared/*": ["src/common/shared/*"],
      "~common/*": ["src/common/src/*"]
    }
  },
  "include": [
    "src/**/*.ts",
    "src/**/*.d.ts",
    "src/**/*.vue",
    "node_modules/**/*.d.ts"
  ],
  "references": [{ "path": "./tsconfig.node.json" }]
}

tsconfig.node.json
{
  "compilerOptions": {
    "composite": true,
    "module": "ESNext",
    "moduleResolution": "Node",
    "allowSyntheticDefaultImports": true
  },
  "include": ["vite.config.ts"]
}

I'm encountering the same issue after upgrading Nuxt from v3.6.5 to v3.7.1
Node: v18.17.1
OS: Ubuntu 22.04
vue-tsc: 1.8.10
Typescript: 5.1.6

Interesting! Tried yarn and pnpm, they don't have this issue. Seemed this issue is npm-specific

Is it because you have typeCheck disabled? Anyway I found more details?

@aoor9 No, I just run the build script. PNPM and Yarn works, but npm fails.

Something wrong with my tsconfig.json?
{
  "extends": "./.nuxt/tsconfig.json",
  "compilerOptions": {
    "strict": true,
    "skipLibCheck": true,
    "typeRoots": ["./@types", "./node_modules/@types"],
    "baseUrl": "./"
  },
  "exclude": ["node_modules"],
  "ts-node": {
    "esm": true,
    "experimentalSpecifierResolution": "node"
  }
}

Interesting! Tried yarn and pnpm, they don't have this issue. Seemed this issue is npm-specific

Nope, also have same issue with pnpm 8.10.2.


About RoutePlanner gps normalization

Hi -- thanks for all your work in releasing this code and that for the baselines. I noticed that in the RoutePlanner you have a mean and scale that is used to normalize the gps from the sensor.
It seems to have 2 values for 2 versions of carla. Where did you get this normalization information from? I'm trying to use this with a different version of carla (9.13) so I'm trying to find the equivalent.
        # self.mean = np.array([49.0, 8.0]) # for carla 9.9
        # self.scale = np.array([111324.60662786, 73032.1570362]) # for carla 9.9
        self.mean = np.array([0.0, 0.0]) # for carla 9.10
        self.scale = np.array([111324.60662786,<PHONE_NUMBER>45]) # for carla 9.10

Thanks!

check https://github.com/autonomousvision/transfuser/issues/48#issuecomment-1054376659


Compiling library for python in 32 bit system

I'm trying to follow the instruction below on my 32 bit Windows:

cd c:\
git clone --recursive https://github.com/dmlc/xgboost
cd xgboost
git submodule init
git submodule update
cp make/mingw64.mk config.mk make -j4

But I get such error:
$ cp make/mingw64.mk config.mk; make -j4
g++ -m64 -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/learner.o src/learner.cc >build/learner.d
g++ -m64 -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/logging.o src/logging.cc >build/logging.d
g++ -m64 -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/common/common.o src/common/common.cc >build/common/common.d
g++ -m64 -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/c_api/c_api_error.o src/c_api/c_api_error.cc >build/c_api/c_api_error.d
cc1plus.exe: sorry, unimplemented: 64-bit mode not compiled in
cc1plus.exe: sorry, unimplemented: 64-bit mode not compiled in
cc1plus.exe: sorry, unimplemented: 64-bit mode not compiled in
Makefile:97: recipe for target 'build/logging.o' failed
mingw32-make: *** [build/logging.o] Error 1
mingw32-make: *** Waiting for unfinished jobs....
Makefile:97: recipe for target 'build/common/common.o' failed
mingw32-make: *** [build/common/common.o] Error 1
cc1plus.exe: sorry, unimplemented: 64-bit mode not compiled in
Makefile:97: recipe for target 'build/learner.o' failed
mingw32-make: *** [build/learner.o] Error 1
Makefile:97: recipe for target 'build/c_api/c_api_error.o' failed
mingw32-make: *** [build/c_api/c_api_error.o] Error 1

Please add support for 32 bit windows or how can I install the library other way?

@Diyago - can you try using the TDM-GCC compiler with OpenMP enabled to build the library instead of MingW?
Follow this link - http://dnc1994.com/2016/03/installing-xgboost-on-windows/

You can removed -m64, in the mingw64.mk.

-m64 means compile using 64bit mode

I deleted that line and started to get another error:
$ $ cd xgboost; make -j4
bash: $: command not found
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/logging.o src/logging.cc >build/logging.d
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/learner.o src/learner.cc >build/learner.d
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/common/common.o src/common/common.cc >build/common/common.d
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/c_api/c_api.o src/c_api/c_api.cc >build/c_api/c_api.d
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c src/common/common.cc -o build/common/common.o
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c src/logging.cc -o build/logging.o
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c src/learner.cc -o build/learner.o
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c src/c_api/c_api.cc -o build/c_api/c_api.o
In file included from include/xgboost/./base.h:10:0,
                 from include/xgboost/logging.h:13,
                 from src/logging.cc:7:
dmlc-core/include/dmlc/omp.h:9:17: fatal error: omp.h: No such file or directory
 #include <omp.h>
                 ^
compilation terminated.
Makefile:97: recipe for target 'build/logging.o' failed
mingw32-make: *** [build/logging.o] Error 1
mingw32-make: *** Waiting for unfinished jobs....
In file included from c:\users\****\minigw\lib\gcc\mingw32\4.9.3\include\c++\cmath:44:0,
                 from c:\users\sbt-ashrapov-ir\minigw\lib\gcc\mingw32\4.9.3\include\c++\random:38,
                 from src/common/./random.h:10,
                 from src/common/common.cc:6:
c:\users\****\minigw\include\math.h: In function 'float hypotf(float, float)':
c:\users\***\minigw\include\math.h:635:30: error: '_hypot' was not declared in this scope
 { return (float)(_hypot (x, y)); }
                              ^
In file included from include/xgboost/./base.h:10:0,
                 from include/xgboost/logging.h:13,
                 from src/learner.cc:7:
dmlc-core/include/dmlc/omp.h:9:17: fatal error: omp.h: No such file or directory
 #include <omp.h>
                 ^
compilation terminated.
Makefile:97: recipe for target 'build/learner.o' failed
mingw32-make: *** [build/learner.o] Error 1
Makefile:97: recipe for target 'build/common/common.o' failed
mingw32-make: *** [build/common/common.o] Error 1
In file included from include/xgboost/./base.h:10:0,
                 from include/xgboost/data.h:15,
                 from src/c_api/c_api.cc:3:
dmlc-core/include/dmlc/omp.h:9:17: fatal error: omp.h: No such file or directory
 #include <omp.h>
                 ^
compilation terminated.
Makefile:97: recipe for target 'build/c_api/c_api.o' failed
mingw32-make: *** [build/c_api/c_api.o] Error 1

Using  TDM-GCC leads to another type of error:
$ make -j4
g++  -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude                                                                                -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT                                                                                build/learner.o src/learner.cc >build/learner.d
g++  -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude                                                                                -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT                                                                                build/logging.o src/logging.cc >build/logging.d
g++  -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude                                                                                -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT                                                                                build/common/common.o src/common/common.cc >build/common/common.d
g++  -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude                                                                                -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT                                                                                build/c_api/c_api.o src/c_api/c_api.cc >build/c_api/c_api.d
g++  -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclu                                                                                de -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c s                                                                                rc/common/common.cc -o build/common/common.o
g++  -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclu                                                                                de -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c s                                                                                rc/c_api/c_api.cc -o build/c_api/c_api.o
g++  -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclu                                                                                de -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c s                                                                                rc/logging.cc -o build/logging.o
g++  -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclu                                                                                de -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c s                                                                                rc/learner.cc -o build/learner.o
In file included from rabit/include/rabit/./internal/../serializable.h:11:0,
                 from rabit/include/rabit/./internal/engine.h:10,
                 from rabit/include/rabit/rabit.h:28,
                 from src/./common/sync.h:11,
                 from src/logging.cc:9:
rabit/include/rabit/./internal/.././internal/utils.h: In function 'FILE* rabit::                                                                                utils::FopenCheck(const char*, const char*)':
rabit/include/rabit/./internal/.././internal/utils.h:158:38: error: 'fopen64' wa                                                                                s not declared in this scope
   std::FILE *fp = fopen64(fname, flag);
                                      ^
In file included from rabit/include/rabit/./internal/../serializable.h:11:0,
                 from rabit/include/rabit/./internal/engine.h:10,
                 from rabit/include/rabit/rabit.h:28,
                 from include/xgboost/learner.h:11,
                 from src/learner.cc:8:
rabit/include/rabit/./internal/.././internal/utils.h: In function 'FILE* rabit::                                                                                utils::FopenCheck(const char*, const char*)':
rabit/include/rabit/./internal/.././internal/utils.h:158:38: error: 'fopen64' wa                                                                                s not declared in this scope
   std::FILE *fp = fopen64(fname, flag);
                                      ^
Makefile:97: recipe for target 'build/logging.o' failed
mingw32-make: *** [build/logging.o] Error 1
mingw32-make: *** Waiting for unfinished jobs....
In file included from rabit/include/rabit/./internal/../serializable.h:11:0,
                 from rabit/include/rabit/./internal/engine.h:10,
                 from rabit/include/rabit/rabit.h:28,
                 from include/xgboost/learner.h:11,
                 from src/c_api/c_api.cc:4:
rabit/include/rabit/./internal/.././internal/utils.h: In function 'FILE* rabit::                                                                                utils::FopenCheck(const char*, const char*)':
rabit/include/rabit/./internal/.././internal/utils.h:158:38: error: 'fopen64' wa                                                                                s not declared in this scope
   std::FILE *fp = fopen64(fname, flag);
                                      ^
src/c_api/c_api.cc: At global scope:
src/c_api/c_api.cc:707:12: warning: 'XGBOOST_LINK_RABIT_C_API_' defined but not                                                                                used [-Wunused-variable]
 static int XGBOOST_LINK_RABIT_C_API_ = RabitLinkTag();
            ^
Makefile:97: recipe for target 'build/c_api/c_api.o' failed
mingw32-make: *** [build/c_api/c_api.o] Error 1
In file included from dmlc-core/include/dmlc/registry.h:14:0,
                 from include/xgboost/./gbm.h:11,
                 from include/xgboost/learner.h:16,
                 from src/learner.cc:8:
src/learner.cc: At global scope:
dmlc-core/include/dmlc/./parameter.h:254:43: warning: 'xgboost::__make__LearnerM                                                                                odelParamParamManager__' defined but not used [-Wunused-variable]
   static ::dmlc::parameter::ParamManager &__make__ ## PType ## ParamManager__ =                                                                                \
                                           ^
src/learner.cc:107:1: note: in expansion of macro 'DMLC_REGISTER_PARAMETER'
 DMLC_REGISTER_PARAMETER(LearnerModelParam);
 ^
dmlc-core/include/dmlc/./parameter.h:254:43: warning: 'xgboost::__make__LearnerT                                                                                rainParamParamManager__' defined but not used [-Wunused-variable]
   static ::dmlc::parameter::ParamManager &__make__ ## PType ## ParamManager__ =                                                                                \
                                           ^
src/learner.cc:108:1: note: in expansion of macro 'DMLC_REGISTER_PARAMETER'
 DMLC_REGISTER_PARAMETER(LearnerTrainParam);
 ^
Makefile:97: recipe for target 'build/learner.o' failed
mingw32-make: *** [build/learner.o] Error 1

I am having the same issue. @Diyago: have you solved this?

My error message may be different from yours:
`In file included from dmlc-core/include/dmlc/registry.h:14:0,
from include/xgboost/./gbm.h:11,
from include/xgboost/learner.h:16,
from src/cli_main.cc:12:
dmlc-core/include/dmlc/./parameter.h:254:43: warning: 'xgboost::make__CLIParamPa
ramManager' defined but not used [-Wunused-variable]
static ::dmlc::parameter::ParamManager &make ## PType ## ParamManager__ = \
                                       ^

src/cli_main.cc:151:1: note: in expansion of macro 'DMLC_REGISTER_PARAMETER'
DMLC_REGISTER_PARAMETER(CLIParam);
^`

@wxlwang nope( I have installed on 64bit Windows, but eventually have started to use it on Linux


Pull in latest master and fix compiler errors

Compiler fixes for Android 4.9:

Remove variable templates and replace with templated sturct. Although, that particular variable template is no longer in use elsewhere.
Remove noexcept specification with default constructors for SparseSet since that caused a mismatch when being deduced from default.

@chri7325  Is it okay to directly update the master branch as well or is that a separate PR?


Amazon Music?

Hello!
Just found this project, got it installed correctly, and love it!
Had a question though:
I have seen people who have been able to listen to Amazon Music songs from theirs, and wanted to do the same thing.
Is it still possible?

https://github.com/alexa-pi/AlexaPi/wiki/Q&A-(FAQ)#does-alexapi-support-amazon-music


MRG: Set env vars in set_config

Closes #3274.
Changes set_config(..., set_env=True) in 0.14, so that setting config updates os.environ, too, by default.

LGTM
please rebase and merge
thx @Eric89GXL

[Current coverage][cc-pull] is 86.71%

Merging [#3439][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master      #3439   diff @@
==========================================
  Files           339        339
  Lines         58388      58400    +12
  Methods           0          0
  Messages          0          0
  Branches       8886       8889     +3
==========================================
+ Hits          50628      50640    +12
  Misses         5079       5079
  Partials       2681       2681

[][cc-pull]

Powered by Codecov. Last updated by [96765bb...3a23c44][cc-compare]
[cc-base-branch]: https://codecov.io/gh/mne-tools/mne-python/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/mne-tools/mne-python/compare/96765bbd30d3de2a50de2c699046fc33cedb176c...3a23c4446aaa45fdf1b11b0395a3a91dcc919a31?src=pr
[cc-pull]: https://codecov.io/gh/mne-tools/mne-python/pull/3439?src=pr

Thanks for the quick review @agramfort


This adds a new callback to remap APIs: TSRemapConfigReload

The purpose of this is to send a notification to every remap plugin
(if they implement this callback) that a remap.config is about to
be reloaded. This can be useful for some plugin that needs to know
that it's about to get instantiated one or numerous times.
This new callback is optional, so this should be a compatible
change. It takes no arguments, and has no return value.
Once this has landed, I'll update the s3_auth plugin with an example
how this new callback can be useful. But tldr; this plugin has a
little config state cache, which has to be reset whenever the remap
rules are reloaded.

[approve ci autest]

I am kind of curious - in your use case, suppose the reload fails. Your plugin will have released resources it now needs to perform because the new version wasn't instantiated. Or is the callback invoked only after the parsing has proceeded sufficiently to guarantee success?

No, that's not how it works. The instance data is associated with the currently loaded remap.config, which is properly ref-counted. The data I need to "clear" here are essentially pointers pointing into the currently loaded remap.config. But without this new callback, I have no way of knowing that those pointers are no longer relevant. It doesn't release anything, and you shouldn't do so either.
It's essentially just a way to reset "config parsing state" to a known state just before you actually start parsing configs.

[approve ci autest]

Why would you just test that it loads?  Why not actually test the new API function?
A side issue is that I had weird problems trying to run traffic manager in Autest, so you might run into the same.

@ywkaras That's what the example that you showed me did, no?

@zwoop No it tests API calls https://github.com/apache/trafficserver/blob/master/plugins/test_cppapi/test_cppapi.cc

[approve ci icc]


pkg/core/session: Add WithReceiveTimeout ControlSessionOpt

Current code does not retry enough time on receive (hard-coded to 1s)
and some devices (for example Intel SSDPE2KX040T8O) operation
such as "PSID Revert" takes ~15s.
This results always in a timeout error:
"method call timed out waiting for a response"
Exposing ContolSessionOpt to override default 100*10ms polling
for receive will allow calling code to override these defaults.

@ChriMarMe please review

Awesome changes. Thank you very much. Really appreciate the changes/additions. :+1:


no podspec for macos

when running pod install i get
[!] No podspec found for `flutter_meedu_videoplayer` in `Flutter/ephemeral/.symlinks/plugins/flutter_meedu_videoplayer/macos`

seems like gitignore settings issue from the plugin side?

when running pod install i get
[!] No podspec found for `flutter_meedu_videoplayer` in `Flutter/ephemeral/.symlinks/plugins/flutter_meedu_videoplayer/macos`

seems like gitignore settings issue from the plugin side?

working on a fix, sorry for that
duplicate of https://github.com/zezo357/flutter_meedu_videoplayer/issues/38


Calling .fit_transform in CatBoostEncoder doesn't work

I'm putting CatBoostEncoder in a pipeline just before a RandomForestClassifier, but I'm getting an error in the RF due to all the values being NaNs. If I manually call .fit(X, y) and then .transform(X) then all works. But if I try to call .fit_transform(X, y) then the output is all NaNs.
Expected Behavior
A successfully trained RF classifier.
Actual Behavior
ValueError: Input contains NaN, infinity or a value too large for dtype('float32').
Steps to Reproduce the Problem
Fully reproducible example:
import category_encoders as ce
from sklearn.ensemble import RandomForestClassifier
from sklearn.pipeline import Pipeline

X = ['a', 'a', 'b', 'c']
y = [1, 1, 1, 0]

cb = ce.CatBoostEncoder()
rf = RandomForestClassifier()

print('Using .fit() and then .transform()')
cb.fit(X, y)
X_tr = cb.transform(X)
rf.fit(X_tr, y)
print('Success!\n')

print('Using .fit_transform()')
rf_pipeline = Pipeline(steps=[
    ('preprocesser', cb),
    ('classifier', rf)
])
rf_pipeline.fit(X,y)

Output:
Using .fit() and then .transform()
Success!

Using .fit_transform()
Traceback (most recent call last):
...
ValueError: Input contains NaN, infinity or a value too large for dtype('float32').

Specifications

Version: 2.2.2
Platform: Windows-10-10.0.18362-SP0
Subsystem: Python 3.7.3 | packaged by conda-forge | (default, Jul  1 2019, 22:01:29) [MSC v.1900 64 bit (AMD64)]

For anyone else, quick fix in your own code:
import category_encoders as ce

class CatBoostEnc(ce.CatBoostEncoder):
    def fit_transform(self, X, y):
        return super().fit(X, y).transform(X)

cbe = CatBoostEnc()

There you have your encoder with a working .fit_transform().

I can't reproduce this.  Has something been fixed in the meantime?


Make Periodic Table Reference Guide

All the elements, in one easy reference tool.
Display interactive details about elements on the periodic table, including atomic number, symbol, and key facts.

Please assign this issue to me @sumanth-0 .


Module openstack.config_template.config_template

Some roles call the module openstack.config_template.config_template, but it looks like a typo?

I was just about to post about this, I'm getting the same issue when running rolling_update.yml
Trying to update from pacific to quincy
ansible: 2.12.10
.git/HEAD: refs/heads/stable-7.0
Error:
ERROR! couldn't resolve module/action 'openstack.config_template.config_template'. This often indicates a misspelling, missing collection, or incorrect module path.

The error appears to be in '/opt/ceph-ansible/roles/ceph-config/tasks/main.yml': line 110, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

- name: "generate {{ cluster }}.conf configuration file"
  ^ here
We could be wrong, but this one looks like it might be an issue with
missing quotes. Always quote template expression brackets when they
start a value. For instance:

    with_items:
      - {{ foo }}

Should be written as:

    with_items:
      - "{{ foo }}"

@jeevadotnet it was cephadm-ansible, my bad: https://access.redhat.com/documentation/en-us/red_hat_ceph_storage/5/html-single/installation_guide/index#registering-the-red-hat-ceph-storage-nodes-to-the-cdn-and-attaching-subscriptions_install
dnf install cephadm-ansible

Some roles call the module openstack.config_template.config_template, but it looks like a typo?

it's not a typo and it's part of the collection requirements [1] so it's likely because you didn't install those [2]
[1] https://github.com/ceph/ceph-ansible/blob/main/requirements.yml#L4-L6
[2] https://docs.ceph.com/projects/ceph-ansible/en/latest/#ansible-collections
[3] https://opendev.org/openstack/ansible-config_template/src/tag/1.2.1/plugins/action/config_template.py

Cheers


identity child path

In purescript-markdown-halogen, the demo is a component that has a single child. In this case, it is helpful to have a child path like this:
identity = ChildPath id id id

Like this https://github.com/slamdata/purescript-halogen/pull/178/files#diff-2820d2461f2c8fcf310110695d9cb5b1R36? :smile:

Agh, can't believe I didn't see that! Thanks :smile:

@garyb Oh, heh, it's in a PR. OK, :+1:!

Well, it's not merged yet, so it's probably not in the version you were looking at - but actually, there are none-ChildPath'd versions of all the functions, so generally I don't think you need this anyway?
I added it as a convenience for when you know you're going to be setting up a multi-children component but are starting off with a single child first.

Oh, you're right... I didn't realize that it would work to use the non-child-path'd versions in my code, but it does! Thanks.


Fix distribution names in the VAE tutorial write-up

Fixing a typo in the write-up of the VAE tutorial (the observation model is Bernoulli)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Allow plugins to walk build graph backward (from child to parent)

There is a chance this feature may not be what we want, see the context section for more information on what we are trying to achieve. This issue may also be a bug in Gradle given the current behaviour is so strange.
Expected Behavior

Given the following included builds:
settings.gradle
includeBuild 'A'

A/settings.gradle
includeBuild 'B'

A/B/settings.gradle
includeBuild 'C'

It should be possible to access successively each of its parent build, e.g. C build can access the B build which can access the A build which can access the root build.
Current Behavior

Typically, we would use Gradle#getParent() for this purpose, but it behaves strangely. For implicit builds, e.g. buildSrc, correctly returns its parent build. However, for composite builds, it will return the root build. Any A, B, or C build will always return the root build.
Context

In cases where a whole set of plugins is developed to extend Gradle (i.e. Nokee to support native development), we need a bridge plugin that will serve as a deep integrator to fake the plugin being deeply integrated with Gradle. For this purpose, we want to align the plugin versions throughout the composite builds (buildSrc included). An init script could work but the integration with Gradle is horrible. A settings plugin works great if we can look into the parent build to find out what version was used by the other build for the plugins. We use a shared service to communicate the version. Basically, a child build will find a parent build with the shared service and pull the version for there. It's safe to do so since the parent builds are configured first.
An alternate solution could be to inject parent service into the nested build which would also solve the issue given parent builds are resolved first.

Sorry for the late reply.
This feature request is in the backlog of the relevant team and is prioritized by them.

releates to

https://github.com/gradle/gradle/issues/28899


Fails in file uploading

I'm using an  in my code and, although the navigator for selecting the files is opened, if I choose a file it ignores the selection and navigator is just opened once per app execution.
This is my complete  in case it helps:
<input type="file" font-family: monospace; id="inputFileToLoad" align="center" accept=".jpg,.jpeg,.png" onchange="read(this);" width="48"/>

same issue

same issue me too

Thanks!
I guess the font-family: monospace; in the original post doesn’t actually belong there, right?
What about some absolutely basic <input type="file" id="avatar" name="avatar"> without extra attributes such as accept or onchange? Can you reproduce the same problems with that syntax?
And what Android versions are you experiencing these problems on?

the same problem, my app open gallery app once selected an image it's close nothing selected in the browser and open chooser at once per execution. I check the link with chrome browser it works fine only problem in my app browser.

Please see the newer https://github.com/delight-im/Android-AdvancedWebView/issues/285 now


Markdown Preview output is not rendered when exporting to PDF

When exporting a note to PDF in Obsidian, the output is not printed to the PDF. Instead the codeblock is printed to the PDF.
To Reproduce
Steps to reproduce the behavior:

Add Todoist codeblock to a note
Check if output is shown correctly in Markdown preview mode.
Export the note to PDF
See codeblock printed on PDF instead of the markdown output

Expected behavior
The Markdown Preview output printed to the PDF
Screenshots
Editor:

Markdown Preview

Rendered in exported PDF

Desktop (please complete the following information):

Plugin v1.7.0
Obsidian v0.11.0

Additional context
I inquired in the Obsidian forum: https://forum.obsidian.md/t/plugin-output-from-codefence-not-rendered-in-pdf-export/13497
The moderator asked me to submit a ticket here.

As far as I'm aware, plugins cannot modify the PDF rendering output. At least, there doesn't seem to be any references to it in the plugin API.
Obsidian would need to expose hooks for that process before I can implement this.

Here's a tip from Licat:

The PDF export "waits" for some async tasks to execute. If the plugin author didn't properly return the async task, then we won't wait for them to render their portion, so nothing gets rendered. Specifically for the todoist plugin, they should mark this function as async and wait for the query to execute so that we can properly render the PDF: https://github.com/jamiebrynes7/obsidian-todoist-plugin/blob/be86a3b6035f0693f0eecbb81032e318c0f2f6aa/src/queryInjector.ts#L22

Hi Jamie, +1 for this feature.

Going to leave this one open @frvkl, as it seems you're not the only one that might want this.


[MM-25903] fix avatar for dms in search

Summary
searching with the in: modifier would display the wrong avatar for the user in the dm.
Ticket Link
MM-25903

@Willyfrog Can we get a before/after screenshot?

One is community showing the problem and the other is my local machine with the fix


Equipping Utility Belt Causes Server To Crash

After installing on my fabric server, when you try to equip the belt it crashes the server. If you restart the server and then try to log back into it, the server crashes again.
2024-06-29-4.log.gz
2024-06-29-3.log.gz

crash-2024-06-29_15.42.47-server.txt
crash-2024-06-29_15.44.27-server.txt

Thanks for reporting, should be fixed in next release


Merge conflicts in CP PRs are not handled well

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create a PR with changes in a given file.
Give the PR the CP Staging label.
Merge the PR.
Create another PR with changes in the same file (to ensure that there will be conflicts on staging).
Give the PR the CP Staging label.
Merge the PR.
The CP PR created for the second PR will be created but not automerged, due to conflicts.

Expected Result:

The CP PR should be auto-assigned to the author of the original (second) PR.
PR checks (lint, test, etc...) should run on the CP PR.

Actual Result:

The PR was not auto-assigned.
PR checks did not run on the CP PR, even after manually pushing new code to the PR.

Workaround:
n/a
Platform:
GitHub only
Version Number: 1.0.77-2
View all open jobs on Upwork

@parasharrajat this is a test, please ignore this message

Will work on this next week

I haven't been able to work on this. I'll return this to the pool as I'm going to be OOO for a few days. I'll gladly pick it after that again as I'll have less workload.

It's still free so I'll pick it again 😄

I've been looking through the marketplace of actions to see if there was one to assign people to PRs. All I've found is related to self-assigning when a user creates a PR. Unless someone knows an action to assign someone to a PR, I'll take a look at the API tomorrow, it's probably easier to build our own, and we already have everything set up for that.

We use other actions-ecosystem actions and they seem to be pretty good. The maintainer is responsive and has merged a couple of my PRs.

Oh! That looks to be the one, great 😄

I'm not sure about this PR checks (lint, test, etc...) should run on the CP PR.. I think there's no way to trigger the PR checks from a GitHub Action. More info: https://github.community/t/manually-triggering-checks-for-a-pr/134054

🚀 Deployed to staging by @pecanoro in version: 1.0.92-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


add beforeDestroy hook

Resolves #9931

Thats what I thought but when I looked at the plugins hook section it only showed render diagrams for the inialization, update, render and event prosses.
Did I miss a place in the docs where all the hooks get described because I couldnt find it, also not with the search bar?
Or do you suggest adding an extra diagram for destroying the chart on that plugin section?

@LeeLenaleee let me ask you if makes sense to you to change also the destroy hook in afterDestroy (of course moving the notification after delete of instance). Maybe in this way it could be consistent with the other plugin hooks.
But I know, this would be a breaking change.

Did I miss a place in the docs where all the hooks get described because I couldnt find it, also not with the search bar?

docs/developers

We could add the afterDestroy already and leave the destroy hook to be removed in V4.
@etimberg thoughts?

That works for me. We can just deprecate the destroy hook but leave it in until v4

I saw that the destroy hook was called before the deletion of the chart instance from the instances object. Shouldnt the destroy and afterDestroy hooks be called after this deletion happend at the very end of the destroy function?

Shouldnt the destroy and afterDestroy hooks be called after this deletion happend at the very end of the destroy function?

As user, I'd expect after the deletion from the instances. But this is just my personal opinion.

Seems I coppied the flow diagram in wrong state, current code had correct version:


ModelNotFoundException thrown when unserializing an unsaved eloquent instance

When SerializesModels unserializes an eloquent instance which does not exist in storage, a ModelNotFoundException is thrown.
$user = new User;
$user->email =<EMAIL_ADDRESS>
$this->dispatch(new SendReminderEmail($user));

[Illuminate\Database\Eloquent\ModelNotFoundException]
No query results for model [App\User].

Maybe during the __sleep process we should check if the QueueableEntity instance exists (has an identifier), e.g. by checking the exists property of the eloquent model instance before creating a new ModelIdentifier.

Yes, this is the expected behaviour. If you've deleted the model in the db you can't access it again.

When you delete a model, the exists property is set to false, but the
identifier is still set. In that case this behavior makes sense.
It's not the same as an instance that has not been saved yet. There is no
id so it shouldn't try to find it in the db.
On Jun 11, 2015 3:06 PM, "Graham Campbell"<EMAIL_ADDRESS>wrote:

Yes, this is the expected behaviour. If you've deleted the model in the db
you can't access it again.
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/9196#issuecomment-111108236.


Remove IVIS

Nobody uses it and it's another dependency that can get removed.

Dependencies are getting to me and when I originally designed the API I thought we'd have transformers that might add embeddings. I no longer think this is true and we basically only use embeddings that are sklearn compatible. I've decided to relay the responsibility to the user.
Related: https://github.com/RasaHQ/whatlies/issues/276

Removing everything would be too drastic. Keeping Umap around but turning it into an optional dependency.


refactor: remove code smells from JavaRenderer

Description
This PR fixes/resolves 3 code smells from JavaRenderer.ts.
Signed-off-by: Kanwal Singh<EMAIL_ADDRESS>Related issue(s)

Fixes #235

Pull Request Test Coverage Report for Build 936202839

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.95%

Totals

Change from base Build 929965017:
0.0%

Covered Lines:
1192

Relevant Lines:
1222

💛  - Coveralls

Awesome @Blakelist7 tada Only one comment, please use camelcase for variable names slightly_smiling_face

We use camelCase, right?

We use camelCase, right?

yes 😄


LNG FCE slide merge with Natural gas FCE slide

As discussed and agreed in https://github.com/quintel/etmodel/issues/1953 , the two FCE slides for LNG and natural gas will be merged into the latter. In that slide, there will be a distinction between the (interface) group pipeline natural gas and liquefied natural gas. The old LNG FCE slide will be deleted.
This pull request adds translations for the new interface groups and removes the old fce_lng slide's translations.

Merged. Will you make the changes to the database, @RobTerwel ?

Yes, right now!


Style/ClassMethods gets singleton methods wrong

    UNDEFINED = Object.new # :nodoc:

    def UNDEFINED.inspect # :nodoc:
      "UNDEFINED" # again with the rdoc bugs... :(
    end

Could you elaborate on the nature of the problem? This code should be ignored by Style/ClassMethods.

Inspecting 14 files
..C...........

Offenses:

lib/minitest/assertions.rb:19:9: C: Use self.inspect instead of UNDEFINED.inspect.
    def UNDEFINED.inspect # :nodoc:
        ^^^^^^^^^

Sorry, I should have included the output.

Ah, I think I get it now. We're currently walking through all static method definitions inside the bodies of classes and modules and check if their names are prefixed with a constant (but we don't care what that constant is as we've assumed it's the class/module name). We should actually check if that constant is the name of the containing class/module.