protoxform: Use an aspect to build protoxform test

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message:
Additional Description:
This just adds/make use of an aspect, in a follow up i will shift the test to bazel and clean up this test file further
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/retest


Create field "Name" #12

Description
Create the field "Name"

Expected outcome
The field "Name" to search by this parameter employee.

Actual outcome

Steps to reproduce

Client environment

Resolved by #16


Update README.md

updated to reflect correct product taxonomy. dotnet-core slug deprecated

@yorek Can you merge this?


Changed os.rename() to shutil.move() to fix cloning errors where /tmp is in a separate file system.

On certain Linux flavors like EndeavorOS, /tmp is mounted to a separate file system than /home. This causes os.rename() to throw OSError: [Errno 18] Invalid cross-device link: 'enron.csv' -> '/tmp/tmpah9csemy/enron.csv' while doing the Dagshub tutorial. shutil.move() handles this edge case.
"If the destination is on the current filesystem, then os.rename() is used. Otherwise, src is copied to dst using copy_function and then removed."

Thank you very much for catching this and providing a fix!


Add unit tests for tuning/data/tokenizer_data_utils.py

Is your feature request related to a problem? Please describe.
Add unit tests for the tuning/data/tokenizer_data_utils.py module.
Describe the solution you'd like
If possible, each function should have test cases in the file tests/data/test_tokenizer_data_utils.py
and pass test with the command pytest tests/data/test_tokenizer_data_utils.py
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the feature request here.

lower priority- can be in backlog


Overlapping text display on the browser

Hello maintainers,
Thanks for developing BulkVis! I'm trying to use it to visualize the NA12878 direct RNA Notts Run 1 data, and the display looks messed on my browser. I'm wondering what can be done? I tried both Firefox and Chrome, and they are behaving the same. Here attached the screenshot.

Thanks,
Chen

By the way, I also tried to give FASTQ header as input, but it doesn't respond.


fix: break only when role match is found

Summary

While checking permission for channel posting we iterate through roles but break on first iteration.
It seems that it works in most situations as "channel_user" role is first in a roles array. But if that is not the case a user would not be able to write to the channel.
I move break statement to an if where we really find the role so that we iterate through all the available roles.
Ticket Link

Related Pull Requests

Has server changes (please link here)
Has mobile changes (please link here)

Screenshots

Release Note

NONE

Hello @vdvukhzhilov,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

Context for this issue is here: https://github.com/mattermost/mattermost-webapp/pull/5337#issuecomment-1230168100
It seems like the original PR had the break statement in the wrong place since it stops the loop from working entirely

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/242966

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/243012

One last time, thanks for the PR! This'll probably make it in for our next Cloud release next week


[e2e]: go schedule main adversarial-binary-upload slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2738047918
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.adversarial-binary-upload.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.adversarial-binary-upload.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Jul 26 08:27:04 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2738047918
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.adversarial-binary-upload.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.adversarial-binary-upload.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Jul 26 20:50:39 UTC 2022
Tests are passing now. Closing this issue.


How to generate client_secret in PHP?

How to generate client_secret in PHP?
Thanks.

Try this example: https://gist.github.com/patrickbussmann/877008231ef082cc5dc4ee5ca661a641


Add unit testing for AWS SD

Proposal
It seems we’ve been relying on manual testing by maintainers and the community. I'm lacking context regarding this.
I don't think I need to explain the necessity of unit tests, but if they’re easy to implement, it’ll give us much more confidence when reviewing related PRs, especially when we’re not familiar with the API.
This will involve some research and discussions regarding the needed test utils (mocks etc.).
If aws-sdk-go-v2 provides better utils and makes testing easier than the currently used v1, we might have to wait until we migrate to v2 (v1 is expected to reach EOL in approximately 1 year).

Hi @machine424, I noticed that this issue has been labeled with help wanted and I'd like to contribute to this

I started to work on it but only for a minimal amount of time, so if @chamodshehanka wants to take this over then it is fine by me.
All I did is to changed to the ec2iface.EC2API interface which is implemented by the ec2.EC2.
I think we should create the unit tests now for the v1 so the v2 migration later will be less painful.

I started to work on it but only for a minimal amount of time, so if @chamodshehanka wants to take this over then it is fine by me. All I did is to changed to the ec2iface.EC2API interface which is implemented by the ec2.EC2. I think we should create the unit tests now for the v1 so the v2 migration later will be less painful.

Awesome!

See https://github.com/prometheus/prometheus/pull/14364


Align modal screens

Description
Currently the modal screens have got different styles. They should get aligned.
Acceptance criteria

Tasks

[ ]

Looks like it got finished in #977, thanks a lot @taleldayekh 🙏

All modals are now aligned 🥳


Less/Sass support

It will be better if you can add less/sass support. It looks grunt file needs to be adjusted to add this.
If possible, coffeescript support will be great as well.
Thank you!

Hi @ezburg , I won't add it in this version of the project. In the next version there will be support for sass. Closing the issue for now. :)


Move probes tests to network package

Signed-off-by: Or Mergi<EMAIL_ADDRESS>
What this PR does / why we need it:
Following #5170 #5167 move probes tests to network package
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

I think especially the probe tests are tricky to decide where they fit best. We only support networking probes right now, but there exist other  probe types (we think for instance for a long time about guest-agent-probes), further I see most of the complexity with  them on the kubevirt-composition level with kubernetes. That networking needs to work is of course a precondition, but I don't see it as the main complexity-driver on these tests. What do you think?

I think especially the probe tests are tricky to decide where they fit best. We only support networking probes right now, but there exist other probe types (we think for instance for a long time about guest-agent-probes), further I see most of the complexity with them on the kubevirt-composition level with kubernetes. That networking needs to work is of course a precondition, but I don't see it as the main complexity-driver on these tests. What do you think?

My intent was to move probes tests that related to network, since there are no others kind of probes that we test I moved it as is.
When we will test other kind of probes, e.g guest-agent-probes, we could extract the common code to another package and reuse it for other tests.
I will change the file name and the Describe block to reflect that.
What you think?

/cc @fgimenez @phoracek @EdDev @AlonaKaplan

/retest

/approve

Did you run sig-network lane ? at least once if not couple times ?
I don't see it
/hold
feel free to remove hold once you are ready

Did you run sig-network lane ? at least once if not couple times ?
I don't see it, the lane is currently still manual / periodic
/hold
feel free to remove hold once you are ready

Ohh, right! We need to see 10 successful runs with it before we merge.

/test pull-kubevirt-e2e-k8s-1.19-sig-network

/test pull-kubevirt-e2e-k8s-1.19-sig-network

/test pull-kubevirt-e2e-k8s-1.19-sig-network

/test pull-kubevirt-e2e-k8s-1.19-sig-network

/test pull-kubevirt-e2e-k8s-1.19-sig-network
/test pull-kubevirt-e2e-k8s-1.19

/test pull-kubevirt-e2e-k8s-1.19-sig-network

/test pull-kubevirt-e2e-k8s-1.19-sig-network

Ohh, right! We need to see 10 successful runs with it before we merge.

Done, all green
/unhold

/retest


python312Packages.west: 1.2.0 -> 1.3.0

Changelog: https://github.com/zephyrproject-rtos/west/releases/tag/v1.3.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 353140

aarch64-darwin

:white_check_mark: 4 packages built:

python311Packages.west
python311Packages.west.dist
python312Packages.west
python312Packages.west.dist


Check out Mist Wallet on Test Net for Saving Circles and...

For smart contract check out the / a "bank smart contract"

Caitlin to create the concept of how this would work for community savings circles


Add section about using as a Git pre-commit hook

overcommit is a fully configurable and extendable Git hook manager that
includes out-of-the-box support for running golint as a Git pre-commit
hook.

No thanks. As per the text higher in the same file, golint is not suited for automatic use in this kind of way.

Cool, no worries. Thanks for considering it.
I'm not much of a Go developer, and I haven't really been involved with the golint overcommit integration (that was mostly @sectioneight and @jawshooah), but I'd like to make sure I understand what you mean. Are you referring to this text?

...this tool is not, and will never be, trustworthy enough for its suggestions to be enforced automatically, for example as part of a build process.

That and all that surrounds it, yes.

I have read the entire document a number of times now and I am still having a difficult time understanding how running golint as a Git pre-commit hook is any different than integrating it with your editor. Will you help me understand?


LiveSplit atomic timing and TAI

Forwarding this to here since its worth considering:
On Tue, 1 Nov 2022 16:56:40 +0000
opal hart<EMAIL_ADDRESS>wrote:

Hi,
I don't have a GitHub account so I can't open an issue on either the
livesplit or livesplit-core repositories, but I wanted to run this past
you before deciding whether to implement it and mail a patch.
If you are unaware of TAI (which is completely understandable as it
receives little attention outside of cryptography circles and
"djb-like" software), basically it's a time-storage format and a
library that is strictly monotonic (only goes forward in time), does
not take into account leap-seconds or any other "natural" time
phenomena, and is thus suitable for a stopwatch such as is used in
livesplit. Bernstein compares TAI to UTC as well as "UNIX time" [1] and
gives an exact specification for the TAI64(NA) datatypes [2]. Laurent
Bercot has a C implementation of a library that handles TAI times [3],
and it seems there is a tai64 crate available for Rust as well [4]
although I have not vetted its source yet.
[1]: https://cr.yp.to/proto/utctai.html
[2]: https://cr.yp.to/libtai/tai64.html
[3]: https://skarnet.org/software/skalibs/libstddjb/tai.html
[4]: https://docs.rs/tai64/latest/tai64/
For livesplit-core this change would be fairly trivial to make; just
switch the core timing logic to use TAI64N as its representation and
make calls to the library to get, store, and manipulate these
timestamps. livesplit-core does no syncing with NTP; I personally argue
that it should stay this way, but I understand that LiveSplit targets
systems that may not be properly managed, systems where ntp or another
time synchronisation mechanism may not be run, systems where the clock
skew may be prominent enough to warrant a separate sanity check. I
don't believe that TAI addresses clock skew at all; its primary
guarantee is monotonicity, but that is more than enough to qualify it
over storing UTC timestamps.
Please let me know if you have any additional consideration, if you
think this is a fair task to work on, and if necessary, you may
re-distribute this message verbatim as a GitHub issue to prompt further
discussion on the matter.

Personally I think this might be worth doing, but we will need to consider how this will affect the splits format if it will even do so at all.

TAI is definitely something I'm well aware of. UTC is indeed not quite the correct format, but we already don't use UTC when timing runs anyway, we use Rust's Instant, i.e. a non-calendar based monotonic timer. So this really only because relevant once we intend to synchronize with an atomic clock where ideally we should indeed use TAI over UTC.

The tai64 crate seems to just provide some "notation" for TAI time stamps and it doesn't actually do any calculation with it. In fact it converts to UTC by doing absolutely nothing... which completely disqualifies this crate. I looked into how to do proper TAI handling on the various operating systems and it seems like:

No operating system provides functionality for converting from / to TAI.
Windows has a registry entry for leap seconds since 2018 (yes it's quite new), which is also completely empty atm because there haven't been any leap seconds since then.
Linux has the best support by providing functionality querying TAI directly and there's a file on the file system you can parse for all the leap seconds.
macOS has absolutely no support for TAI or leap seconds.

Here's a little prototype I wrote based on the time crate that provides a TaiDateTime:
https://github.com/CryZe/time-tai/blob/master/src/lib.rs
This could potentially be turned into a PR for the time crate.


Fix options mutation

Fix: #165, #162

Hi,
Are there any plans to merge this soon? Our build is broken on the latest release, but with this branch it is fixed. 😄

@vio Thank you for making this PR!
@zachmullen sorry for the delay.

Thanks @mzgoddard !

@zachmullen just published as 2.5.1


fix: remove AWS token depletion

Amazon AWS tokens are used for API throttling. Every call to an API endpoint
costs us one token. Before this commit, our listAllInstancesAttribute
exhausted all our available AWS tokens, this lead to AWS throttling us.
The new function does only ONE request instead of one request for every token.
In this request we gather a maximum of 1000 results for a 2hour timeframe.
This should be enough for us to handle CHGM alerts

I tested this PR with my stage cluster. Seems to work:
Sending CHGM ServiceLog...
Silencing Alert...
Attaching Note Is user authorized: 'false'

UserName : 'osdManagedAdmin'

The amount of non running instances is: '10'

Instance IDs: '[i-027e2812159da23c3 i-071042c56fed3d97c i-07e8483f620d8471e i-0b3118cac5080ffd1 i-0af8a031839a0f355 i-0cda8c163b538777b i-031b382f293de53c4 i-0f02e908d6b5f9611 i-073e50fda81bcac08 i-038f64ed09e107bb5]'

ServiceLog Sent: 'Action required: cluster not checking in'

Seems indeed a good idea to let AWS do the loop internally rather than doing it ourself.
Also from a scalability perspective it looks fine to limit the output.

/lgtm


Extension API docs have broken links

Description:
I checked several extensions from within the main Siddhi Documentation page, and most of the
extensions have inaccessible pages for explaining the functionality.
For example, if I wanted to check how the File extension works,

I go to the Siddhi extensions page at https://siddhi.io/en/v5.0/docs/extensions/
I click the siddhi-io-file link, which takes me to https://siddhi-io.github.io/siddhi-io-file/
To check how the file sink works, I click "file (Sink)", which takes me to https://siddhi.io/documentation/siddhi-5.x/query-guide-5.x/#sink (404)

Affected Siddhi Version:
5.0
OS, DB, other environment details and versions:
All
Steps to reproduce:
Please see above
Related Issues:
https://github.com/siddhi-io/siddhi-execution-time/issues/46

Thanks for reporting the issue Gokul. We are in the process of revamping the extension github-io pages. We'll fix them soon.

Thanks @mohanvive. Is there a way I can refer to the docs in question in the meantime?

https://siddhi.io/documentation/siddhi-5.x/query-guide-5.x/#sink will take you to on how sink works
you can refer this via https://siddhi.io/en/v5.0/docs/query-guide/#sink

Above issue is fixed. Redirection links are working fine now...


Possibility to configure RBAC

What problem are you facing?
I'm trying to use provider-kubernetes to create Kubernetes Jobs, however the RBAC settings for the used ServiceAccount won't allow it.
I can specify a ServiceAccount to use but then I also need to manually add the RBAC settings for my resources as well as the CRDs from this package.

How could Crossplane help solve your problem?

Ability to somehow configure RBAC settings for the provider without having to create an extra ServiceAccount.
I suppose it would also be okay if the created ServiceAccount was deterministic (for example by specifying the name).
Then we could just add extra Roles on top of the pre-existing ones.

@ONordander Trying to understand your problem. Is it the RBAC for the service account that is needed for the Job that you create by using this provider, or you are referring the RBAC for the provider itself? It would be good to give some concrete example.

Hey @morningspace, thanks for responding.
I'm talking about RBAC for the provider itself. The provider "suffers" from the same problem that the other providers do, they use a generated ServiceAccount name which makes it more difficult to set correct permissions.
For example if I want to give the provider the permission to create secrets I can do that declaratively by creating a new ServiceAccount, however that ServiceAccount will not have the correct permissions to handle the provider objects itself e.g.
providerconfigs.kubernetes.crossplane.io
So I have to add that myself, which is not very user-friendly.
I would like to use a custom ServiceAccount and be able to add only my own additions on top and get the needed permissions for the provider out of the box.
I hope that makes sense, and we can probably draw inspiration from similar discussions in the other providers.

Hey @morningspace, thanks for responding.
I'm talking about RBAC for the provider itself. The provider "suffers" from the same problem that the other providers do, they use a generated ServiceAccount name which makes it more difficult to set correct permissions.
For example if I want to give the provider the permission to create secrets I can do that declaratively by creating a new ServiceAccount, however that ServiceAccount will not have the correct permissions to handle the provider objects itself e.g.
providerconfigs.kubernetes.crossplane.io
So I have to add that myself, which is not very user-friendly.
I would like to use a custom ServiceAccount and be able to add only my own additions on top and get the needed permissions for the provider out of the box.
I hope that makes sense, and we can probably draw inspiration from similar discussions in the other providers.

Ah, the provider uses sa where the name is something randomly generated, right? IIRC, that logic comes from crossplane core, so that's not something we can address at provider level, and that's a common issue across all providers. Have you got chance to raise it in crossplane/crossplane?
cc: @turkenh for any comment on that.

I understand, I'll see if I can find any open issues in the main Crossplane repository first.
FWIW, here's the same request for provider-aws https://github.com/crossplane/provider-aws/issues/607.
Thanks again!

Currently, the best solution we have is something like this: https://github.com/crossplane-contrib/provider-kubernetes/blob/main/examples/provider/config-in-cluster.yaml#L5
You can also pass an alternative SA via controller config<EMAIL_ADDRESS>There is also a related PR: https://github.com/crossplane/crossplane/pull/2880

@turkenh
https://github.com/crossplane/crossplane/pull/2880 seems to be what I'm looking for, and as I understand if that is merged it will propagate to provider-kubernetes as well, if so I think we can close this.

Sadly https://github.com/crossplane/crossplane/pull/2880 has not been merged, so it might make sense to re-open this. It would definitely be great to have!


Sometimes submitting a claim is "stuck" at multiple images upload

Sometimes when submitting a claim with several images, the process seems stuck at an image upload dialogue (e.g "Uploading photo 1/2"). At the same time all images are successfully uploaded to the server and claim is completely available.
IMO this happens due to asynchronous nature of network calls so that image "1" may be actually uploaded after image "2". Since counter is used in a condition to check that all images were uploaded to proceed with the flow, this can easily cause the "done" dialogue to be shown before the "uploaded image 1" dialogue and be overlapped.
Refer to this:
https://github.com/badparking/badparking-android/blob/develop/app/src/main/java/ua/in/badparking/ui/fragments/ClaimOverviewFragment.java#L283
https://github.com/badparking/badparking-android/blob/develop/app/src/main/java/ua/in/badparking/ui/fragments/ClaimOverviewFragment.java#L247

@renka can you make uploading of photo's sequential, not in parallel?

As an alternative you could drop the counter and use some kind of a map between file and upload status. Then check completeness based on all map values being "true". This would allow to keep the upload parallel.

@excieve yeah, but will it be faster in parallel? I think phone's 3G connection is bottle neck anyway?

Depends on file size and current bandwidth. In the worst case it's about the same as sequential. In the best case... let's say 2Mbps can completely upload two 125K files in a second. So really it depends on how much we're compressing the files.

ok, I see, then counter/map is the way to go. Can you add that @renka ?

Yes


Fix refresh_token cookie

fix #129

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@55e29e0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master   #135   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?     17
  Lines             ?    256
  Branches          ?     28
=======================================
  Hits              ?    256
  Misses            ?      0
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e29e0...34c0115. Read the comment docs.


docs(release information): add more information to our release description

Description
This PR adds more information about our releases, including phases, milestones, and timelines. The idea is not to provide the information redundant to the working model, but to provide a minimal set of information.

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[ ] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[X] Copyright and license header are present on all affected files

DEPENDENCIES will be checked tomorrow


Added sync.Map to benchmarks

This is an interesting comparison. I'll leave updating the readme to you.
GOMAXPROCS=4 go test github.com/VictoriaMetrics/fastcache -bench=. -benchtime=10s
goos: darwin
goarch: amd64
pkg: github.com/VictoriaMetrics/fastcache
BenchmarkBigCacheSet-4              2000      10263033 ns/op       6.39 MB/s     4660370 B/op           6 allocs/op
BenchmarkBigCacheGet-4              3000       6929140 ns/op       9.46 MB/s      630875 B/op      131074 allocs/op
BenchmarkBigCacheSetGet-4           1000      16040092 ns/op       8.17 MB/s     5046744 B/op      131083 allocs/op
BenchmarkCacheSet-4                 5000       3299233 ns/op      19.86 MB/s        4474 B/op           1 allocs/op
BenchmarkCacheGet-4                10000       2094759 ns/op      31.29 MB/s        2237 B/op           0 allocs/op
BenchmarkCacheSetGet-4              2000       6498307 ns/op      20.17 MB/s       11187 B/op           4 allocs/op
BenchmarkStdMapSet-4                2000      11397262 ns/op       5.75 MB/s      268414 B/op       65537 allocs/op
BenchmarkStdMapGet-4                5000       2900110 ns/op      22.60 MB/s        2563 B/op          13 allocs/op
BenchmarkStdMapSetGet-4<PHONE_NUMBER>9 ns/op       1.93 MB/s      324790 B/op       65547 allocs/op
BenchmarkSyncMapSet-4               1000      23698289 ns/op       2.77 MB/s     3417219 B/op      262277 allocs/op
BenchmarkSyncMapGet-4              10000       1337885 ns/op      48.98 MB/s        1273 B/op          39 allocs/op
BenchmarkSyncMapSetGet-4            2000       8980098 ns/op      14.60 MB/s     3412536 B/op      262210 allocs/op

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   94.32%   94.32%
=======================================
  Files           1        1
  Lines         141      141
=======================================
  Hits          133      133
  Misses          4        4
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06915e3...b2c42a0. Read the comment docs.

@WIZARDISHUNGRY , thanks for the added benchmark. I'll update README.md shortly


Fix: use of AxisName as abbreviated child NameTest Step

Fixes use of child (and other AxisName strings) as a NameTest (as an abbreviated child axis test Step).
Nearly all of this change is tangentially related:

53c0a91 escaping < and > in XForm DSL attribute values, so the fix will actually show up in a passing scenario test (and 721c82c updating another test that would have passed otherwise). I believe this is a reasonable adjustment. Making the change in the engine would mean supporting malformed XML, and I think that would be a snake pit of complexity and potential source of bugs.

7c219a3 removing the "E2E" tests in @getodk/tree-sitter-xpath. These tests had some value early in the project for demonstrating A) how the grammar could be consumed downstream and B) a sense of how we might perform syntactic analysis on XPath expressions. Neither has been especially valuable for a while since, and the latter is especially moot after #166. Note that these test were not impacted in any way by the fix, this just felt like an opportune time to clean up some dead weight.

78d1a92 adding parse grammar tests specific to the change, starting with the expression causing an actual failure in scenario, a few variants on that, and then a test of every AxisName-as-NameTest

The actual substantive change achieving the fix: 03305c1. Not much to note here, other than the fact that nothing downstream needs to change to benefit from this fix. It just ensures that expressions like /child are handled the same way as expressions like /notchild. (And 0afb4a2 is the scenario test newly passing with the change.)

Some of the vocabulary used in the description of this PR and commit messages goes over my head, I probably need to go through the xpath spec.

Probably a good idea at some point! Even if only to get familiar with the grammar and the names used for various parts of syntax. I've found it really helpful to be familiar with these, both in implementing the xpath evaluator and in being able to describe particular kinds of expressions/sub-expressions with precision.

But I understand the problem this change-set fixes i.e. xpath parser was not correctly parsing expression that contained any axis name as step (node name).

Right. And if you want to see the impact of the fix, you can compare the results of yarn workspace @getodk/tree-sitter-xpath test on 78d1a92 and after. What you'll see before is that every case where a Step references an element by name which could be an AxisName, you'll see a bunch of (node_test) where (node_test (unprefixed_name)) should be.

One thing I noticed that we don't have any scenario that uses child::anything like expression, is it worth adding such a scenario 🤷♂ ? I can't imagine anyone using child axis explicitly.

That's sort of in the opposite direction of this PR, but a good question to raise nonetheless! You can see that there are tests for evaluation in xpath. If we were to introduce scenario tests exercising expressions using that explicit (non-abbreviated) syntax, I would expect it to break dependency tracking, causing any downstream computation update to fail. That's something that we could cover either in #166 or in a followup building on the abstractions introduced there.


Mark P2P-protocol targets as optional

Closes #2877 and fixes #2922 by ensuring that projects that do not
define GetNativeManifest and GetNativeManifest targets (such as the
"outer" build of a multitargeting SDK project) are referencable with
ReferenceOutputAssembly=false (or other means of avoiding the
TargetFramework-compatibility check).
Includes updates to the ProjectReference Protocol documentation.

I'm so confused; the link to the macOS job says it passed.
@dotnet-bot test OSX10.13 Build for CoreCLR please


NativeScript 7 Support

Could you please add support for NativeScript 7?
https://nativescript.org/blog/nativescript-7-for-plugin-authors/
https://nativescript.org/blog/nativescript-7-compatible-plugins/

Oops, I didn't see https://www.npmjs.com/package/@nativescript/local-notifications


[feat]: Event Calendar

Feature description
A component that can visualise events according to various views (e.g. month, week, day, list). Similar to https://github.com/fullcalendar/fullcalendar

Affected component/components
No response
Additional Context
Additional details here...
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues and PRs

@shadcn Please approve PR. I know there are lots of best components, but PRs are pending for those.
Like Multi select and stepper.
I like this UI Library. Free wheel to change any component.
Thanks @shadcn.

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


Initialized value of md-select is not displayed

Bug, feature request, or proposal:
Bug
What is the expected behavior?
When the value of md-select is set in the constructor, the initialized value should be displayed in the pulldown list.
What is the current behavior?
The initialized value is not displayed in the pulldown list.
What are the steps to reproduce?
Please refer to this plunk: https://plnkr.co/edit/sxC4c3CgKmmARF6Jq9XA
In this example, the selectedValue is initialized to 3 (Steak), but "Steak" is initially not shown in the pulldown.
Only after the user explicitly selects "Steak" is it shown.
What is the use-case or motivation for changing an existing behavior?
It should be possible to display an initial value for md-select.
Which versions of Angular, Material, OS, browsers are affected?
Angular: 2.4.8
Material: 2.0.0-beta.2
Is there anything else we should know?
No.

If you want an option to be selected, its value has to equal the value of the ngModel. In your example, your option value is "3" while ngModel value is 3.  Binding to the value property should conserve the type. See updated plunker here.


programmatically create a commit through Github REST API

programmatically create a commit through Github REST API
Sample code and some info links here:
https://plebnetdev.notion.site/octokit-js-885ecc4b852445b2956d7bb55a568ffd

The above example can be useful for many applications where we need to update a website github repo through a form (e.g. add a nostr or lnurlp entry)


Why score_loss = torch.mean((lambda_t[:, None, None, None] * st + eps) ** 2)?

Could you elaborate why this equation standard?
why not use Eq 8:

Saw it in Eq20, close the issue now


Error report:  NFT cannot be bridged from Katla to Holesky

Describe the bug
If an NFT is originally created on Katla chain, it cannot be bridged to Holesky chain.  The Bridge-APP keeps saying: Unknown error--An unexpected error has occurred. Please try again.
If an NFT is bridged from Holesky to Katla, then it can be bridged back to Holesky successfully.
Steps to reproduce
Create an NFT on Katla chain on nfts2.me or thirdweb.com. Claim it. Try to bridge the NFT to Holesky. It can be approved  but fail to  be bridged.

Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

Reach on on discord, this is due to the NFT generator not following the standard.


Support for standard

Since standard (https://github.com/testdouble/standard) uses Rubocop under the wood, it would be nice for ruumba to inherit the rubocop rules from StandardRB.

Thanks for this! 100% agree; I've mentioned this to Searls and I plan to support Standard soon-ish. (Please feel free to make a pull request if you have time/bandwidth/interest/&c).


First drop: Hub metrics collector feature

install Metrics Without Addon

install Metrics Without Addon

refactor

add reconcile check for hub collector resources

lint

make sure mco reconciles when resources for hub metrics collection are missing

cleanup

test failures

fix test

cleanup logs

fixt test

lint errors

delete endpoint when mco is deleted

fixt test

cleanup logs

delete metrics collector when mco is deleted

collector naming

test cert

test cert

test metrics push

create correct CSR

cert

test

lint

add User and Organization to CSR

set Subject Alternative Name to observability-controller.addon.open-cluster-management.io

fix build

comment

rebase

change key usage to UsageDigitalSignature

add watch logic for hubs metric collection resources

add reconcile check for hub collector resources

watch delete of hub metrics collection resources

watch delete of hub metrics collection resources

add watch for server ca when deleted

remove logs

/retest

/test pr-image-mirror-multicluster-observability-operator

/retest


App menu shows strange text for Sidecar display name

Before opening the issue, have you...?

[X] Searched for existing issues
[X] Looked through the wiki
[X] Updated MonitorControl to the latest version (if applicable)

Describe the bug
Please see the screenshot below. It looks like Korean, but my macOS system, the iOS on the iPad, and the iPad's name are all in English.
Steps to reproduce
I don't know if you can reproduce it, but I can do whatever necessary to help pinpoint the issue.
Expected behavior
The menu should probably just say Sidecar (since only one sidecar display is allowed anyway), or the name of the iPad running Sidecar? Definitely not some Korean text.
Anything else?

Environment Information (please complete the following information)
- macOS version: 12.2.1 (21D62)
- Mac model: Mac mini (2018)
- MonitorControl version: 4.0.2 build 6965
- Monitor(s): Main monitor is LG 4K over DisplayPort. Sidecar display is on an iPad Air 3.
- Apple Silicon/M1 (yes or no): no

Hi, the display names are taken from the relevant dictionary by factoring the Locale.current.identifier into account. This is probably the same as the terminal command defaults read -g AppleLocale which you can check. It is probably set to Korean?

What is it supposed to show? The name of the iPad running Sidecar?
Maybe there's a misconfigured locale mapping somewhere?
$ defaults read -g AppleLocale
en_CN

The current locale is not Korean.

It shows simply Sidecar for me. But the name should be locale specific. If it really annoys you, why don't you just rename it? Click on the name under Displays in the app Preferences. Hopefully this feature works with virtual displays (like Sidecar) properly, this use case wasn't tested. :)

Sorry, it shows Sidecar Display Probably the stuff there stands for Display in some language.

Good news is that renaming works well and the name is remembered after reconnect so the implementation is fine. :)

Hmmm… I think it's actually a bug here. Repeatedly clicking the Reset settings button right to the Custom Name field will rotate the name in different languages.
https://user-images.githubusercontent.com/22984/156924820-d881f7f9-a1bb-4457-af8a-1029b156f29d.mov

Well, in today's multicultural environment I think we should consider this a feature, not a bug. :)

All right, the same issue came up at BetterDisplay and we found the root cause. This should be fixed in MonitorControl as well.
https://github.com/waydabber/BetterDisplay/issues/1047


[EXTERNAL] Changing cell type doesn't work

If you create a cell in one language, then use the language switcher to choose a different language, the submission is still treated as the original language.

Failing to execute FSharp for me. Also, a cell configured for FSharp when saved, closed, reopened, appears as a CSharp cell instead.

It really thinks it's CSharp:

FSharp cell rendered as CSharp after save, close, open:


Add ASYNC102, probably blocking os call in async function

I tried looking through the os methods and figure out which ones are bad to use in an async context, but that turned out trickier than I thought. There's probably a bunch of methods that are perfectly fine that just looks at data that python has cached, but best way I had of figuring that out was reading the description of them (which only worked in a few cases + there's a lot of them), or reading the source (which is more cumbersome when a bunch of them are implemented in c). If you have any good ideas on how too proceed @Zac-HD do let me know, or you can at least run it against your large codebases and find false positives before merging.

OK, notes from scanning through the os module docs:

os.fdopen() - this is similar to open(), but takes an integer file descriptor; mostly no async equivalent - though you can wrap the result in e.g. trio.wrap_file() and it'll then be async.  Which is true for all sync filesystem operations, actually 🤔
Lots of things involving file descriptors are explicitly low-level enough that we probably shouldn't recommend an alternative anyway.
File and directory operations like os.listdir(), os.stat(), etc. could in principle be async, but again there's not a consistent way to do that.

I think I'm inclined to omit those from the check as being too error-prone, and just check for:

os.popen(), os.spawn[vl]p?e? family, os.system() - generally replaced by async process alternatives
os.wait.*() - waiting for processes to complete should definitely be done async

makes sense. Opted to add *wait* to async101 and the process ones to a new async102. You can open a new issue in flake8-trio if you want a trio-specific version of this.


No ARM64 build in the 12.8.4 release

Question
There is no arm64 build at  https://github.com/tsenart/vegeta/releases/tag/v12.8.4
There are several more architectures at https://github.com/tsenart/vegeta/releases/tag/v12.8.3
Could you please re-add the arm64 build for the new releases ? Or add an entry to the README how to build it ourselves
Thank you!

GOOS=linux GOARCH=arm64 go build

Seems to be fixed in the recent - 12.9.0, 12.10.0 - releases and can be closed.

@Elnadrion: There are arm64 releases in https://github.com/tsenart/vegeta/releases/tag/v12.11.1.

Oh no, I didn't clicked on this button
Sorry, I'm so ashamed 😅


feat: add sonner 1.7.0 features

@xiaoluoboding  🙌
There is a bug that is not present in other sonner ports when you fast switch/click between positions like
top-right, top-left, and other positions and then fast hover/mouseenter on toasts, you can see offset is not calculated properly, I tried to fix it but couldn't find the problem

Removed :where pseudo-class
Only two things left for review

onUnmounted or onBeforeUnmount

the offset bug on switch position


Please add new TuYa TV02-Zigbee Thermostat support.

@stas-demydiuk Thank you. I uploaded again.

Thanks!

Thanks!


CG Vulnerabilty fix for IISWebAppDeploymentOnMachineGroupV0

Task name: IISWebAppDeploymentOnMachineGroupV0
Description:
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] node make.js build --task IISWebAppDeploymentOnMachineGroupV0
[x] node make.js test --task IISWebAppDeploymentOnMachineGroupV0
[x] Checked that applied changes work as expected

/azp run


< with adjacent character and no space in between is parsed incorrectly inside text interpolation {{ a<v }}

Version
2.6.10
Reproduction link
https://codepen.io/laden666666/project/full/ZJbvRg
https://template-explorer.vuejs.org/#

{{a < v-c > 2}}<%2Fdiv>

{{a <v-c > 2}}<%2Fdiv>
    <%2Fdiv>
Steps to reproduce
<template>

{{a < v-c > 2}}

{{a <v-c > 2}}

</template>

What is expected?
false
false
What is actually happening?
false
{{a 2}}

I added a template repro.
Please, provide editable versions when providing a repro

I think it's expected because <v-c > would be parsed as a valid start tag. We need to parse HTML first then go through interpolation for text nodes. If you really want to use < and > in the interpolation expression, just escape them into < and >.

I think it's expected because <v-c > would be parsed as a valid start tag. We need to parse HTML first then go through interpolation for text nodes. If you really want to use < and > in the interpolation expression, just escape them into < and >.

I don't agree, because there is no difference between the above two codes except for one more " ". < and > is even more disagreeing, because there is no mention in the documentation that escaping is needed.
In fact, this bug should be solved by the compiler.

I don't agree, because there is no difference between the above two codes except for one more " ".

Not true. According to HTML spec, a start tag starts with a < character and followed immediately by a tag name. And tag names cannot contain whitespaces. So <v-c > is a valid start tag but < v-c > is not. Vue's HTML parser works exactly the same as that of Chrome in this case:

< and > is even more disagreeing, because there is no mention in the documentation that escaping is needed.

Escaping < and > in HTML text is required beyond Vue. We can safely use JavaScript expressions inside an attribute when we use quotations but it will also be problematic without them. It only works reliably if you escape these special characters.
Basically, we handle interpolation after parsing HTML, as I mentioned earlier. It's just how HTML works and I don't think it's a bug of Vue and should be “fixed”. But I do agree that our documentation should cover more for such cases.

I still think this is a bug. The jsx of react will not have such a problem.

{a < v-c > 2}
  =
{a <v-c > 2}

But I also understand what you mean, Vue supports DOM declarative rendering, so Vue's compiler must first compile the template as a browser.