System Pods not on Calico Network

We are trying to setup a Kubernetes Cluster with Calico on-premise.
As we want to automize the whole setup we have create some Ansible playbooks for that.
The Cluster should have 3 Master and 5 Worker/Minions.
After the first master is configured, we run
$ KUBECONFIG=secrets/admin.conf kubectl apply -f https://docs.projectcalico.org/v3.2/getting-started/kubernetes/installation/hosted/etcd.yaml
$ KUBECONFIG=secrets/admin.conf kubectl apply -f https://docs.projectcalico.org/v3.2/getting-started/kubernetes/installation/rbac.yaml
$ KUBECONFIG=secrets/admin.conf kubectl apply -f https://docs.projectcalico.org/v3.2/getting-started/kubernetes/installation/hosted/calico.yaml

after that, master 2 and 3 is getting setup.
For setting up first master we use following config
ApiVersion: kubeadm.k8s.io/v1alpha3
kind: ClusterConfiguration
kubernetesVersion: stable
imageRepository: google-containers
apiServerCertSANs:
- "vmamradd04.gfklctx.local"
controlPlaneEndpoint: "vmamradd04.gfklctx.local:6443"
etcd:
  local:
    extraArgs:
      listen-client-urls: "https://<IP_ADDRESS>:2379,https://<IP_ADDRESS>:2379"
      advertise-client-urls: "https://<IP_ADDRESS>:2379"
      listen-peer-urls: "https://<IP_ADDRESS>:2380"
      initial-advertise-peer-urls: "https://<IP_ADDRESS>:2380"
      initial-cluster: "vmkubei01.gfklctx.local=https://<IP_ADDRESS>:2380"
    serverCertSANs:
      - "vmkubei01.gfklctx.local"
      - "<IP_ADDRESS>"
    peerCertSANs:
      - "vmkubei01.gfklctx.local"
      - "<IP_ADDRESS>"
networking:
    # This CIDR is a Calico default. Substitute or remove for your CNI provider.
    podSubnet: "<IP_ADDRESS>/16"
---
apiVersion: kubeadm.k8s.io/v1alpha3
kind: InitConfiguration
nodeRegistration:
  kubeletExtraArgs:
    pod-infra-container-image: "google-containers/pause:3.1"

After the playbook is finished, all Master and Worker seams to be up correctly.
[root@vmkubei01 ~]# kubectl get nodes -o wide
NAME                      STATUS     ROLES    AGE     VERSION   INTERNAL-IP    EXTERNAL-IP   OS-IMAGE                KERNEL-VERSION               CONTAINER-RUNTIME
vmkubei01.gfklctx.local   Ready      master   4m25s   v1.12.2   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   3.10.0-862.14.4.el7.x86_64   docker://18.6.1
vmkubei02.gfklctx.local   Ready      master   2m50s   v1.12.2   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   3.10.0-862.14.4.el7.x86_64   docker://18.6.1
vmkubei03.gfklctx.local   Ready      master   74s     v1.12.2   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   3.10.0-862.14.4.el7.x86_64   docker://18.6.1
vmkubep01.gfklctx.local   NotReady   <none>   12s     v1.12.2   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   3.10.0-862.14.4.el7.x86_64   docker://18.6.1
vmkubep02.gfklctx.local   NotReady   <none>   13s     v1.12.2   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   3.10.0-862.14.4.el7.x86_64   docker://18.6.1
vmkubep03.gfklctx.local   NotReady   <none>   13s     v1.12.2   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   3.10.0-862.14.4.el7.x86_64   docker://18.6.1
vmkubep04.gfklctx.local   NotReady   <none>   12s     v1.12.2   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   3.10.0-862.14.4.el7.x86_64   docker://18.6.1
vmkubep05.gfklctx.local   NotReady   <none>   12s     v1.12.2   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   3.10.0-862.14.4.el7.x86_64   docker://18.6.1

On the pods, we see that the system pods are running on host ip's and not on calico network
[root@vmkubei01 ~]# kubectl get pods -o wide -n kube-system
NAME                                              READY   STATUS    RESTARTS   AGE     IP               NODE                      NOMINATED NODE
calico-etcd-6hvqk                                 1/1     Running   0          2m24s   <IP_ADDRESS>     vmkubei03.gfklctx.local   <none>
calico-etcd-d8ldn                                 1/1     Running   0          6m      <IP_ADDRESS>     vmkubei01.gfklctx.local   <none>
calico-etcd-jgwdz                                 1/1     Running   0          3m53s   <IP_ADDRESS>     vmkubei02.gfklctx.local   <none>
calico-kube-controllers-757fbf57c9-l4mqq          1/1     Running   0          6m12s   <IP_ADDRESS>     vmkubei01.gfklctx.local   <none>
calico-node-5rwf4                                 2/2     Running   2          4m54s   <IP_ADDRESS>     vmkubei02.gfklctx.local   <none>
calico-node-62mkm                                 1/2     Running   3          2m18s   <IP_ADDRESS>     vmkubep02.gfklctx.local   <none>
calico-node-6mhft                                 2/2     Running   3          2m17s   <IP_ADDRESS>     vmkubep05.gfklctx.local   <none>
calico-node-bzjn2                                 2/2     Running   1          6m12s   <IP_ADDRESS>     vmkubei01.gfklctx.local   <none>
calico-node-lfsch                                 2/2     Running   2          3m18s   <IP_ADDRESS>     vmkubei03.gfklctx.local   <none>
calico-node-pbr2z                                 1/2     Running   0          2m18s   <IP_ADDRESS>     vmkubep03.gfklctx.local   <none>
calico-node-rsnkr                                 1/2     Running   1          2m17s   <IP_ADDRESS>     vmkubep04.gfklctx.local   <none>
calico-node-wld7m                                 1/2     Running   0          2m17s   <IP_ADDRESS>     vmkubep01.gfklctx.local   <none>
coredns-598b4954b9-g8jrv                          1/1     Running   0          6m12s   <IP_ADDRESS>   vmkubei01.gfklctx.local   <none>
coredns-598b4954b9-xzp99                          1/1     Running   0          6m12s   <IP_ADDRESS>   vmkubei01.gfklctx.local   <none>
etcd-vmkubei01.gfklctx.local                      1/1     Running   0          5m10s   <IP_ADDRESS>     vmkubei01.gfklctx.local   <none>
etcd-vmkubei02.gfklctx.local                      1/1     Running   0          4m53s   <IP_ADDRESS>     vmkubei02.gfklctx.local   <none>
etcd-vmkubei03.gfklctx.local                      1/1     Running   0          3m8s    <IP_ADDRESS>     vmkubei03.gfklctx.local   <none>
kube-apiserver-vmkubei01.gfklctx.local            1/1     Running   0          5m36s   <IP_ADDRESS>     vmkubei01.gfklctx.local   <none>
kube-apiserver-vmkubei02.gfklctx.local            1/1     Running   0          4m13s   <IP_ADDRESS>     vmkubei02.gfklctx.local   <none>
kube-apiserver-vmkubei03.gfklctx.local            1/1     Running   0          2m46s   <IP_ADDRESS>     vmkubei03.gfklctx.local   <none>
kube-controller-manager-vmkubei01.gfklctx.local   1/1     Running   1          5m14s   <IP_ADDRESS>     vmkubei01.gfklctx.local   <none>
kube-controller-manager-vmkubei02.gfklctx.local   1/1     Running   0          4m20s   <IP_ADDRESS>     vmkubei02.gfklctx.local   <none>
kube-controller-manager-vmkubei03.gfklctx.local   1/1     Running   0          2m46s   <IP_ADDRESS>     vmkubei03.gfklctx.local   <none>
kube-proxy-55ntz                                  1/1     Running   0          2m17s   <IP_ADDRESS>     vmkubep04.gfklctx.local   <none>
kube-proxy-6dspq                                  1/1     Running   0          2m18s   <IP_ADDRESS>     vmkubep02.gfklctx.local   <none>
kube-proxy-86flc                                  1/1     Running   0          6m12s   <IP_ADDRESS>     vmkubei01.gfklctx.local   <none>
kube-proxy-dkvzd                                  1/1     Running   0          2m17s   <IP_ADDRESS>     vmkubep01.gfklctx.local   <none>
kube-proxy-dl5qs                                  1/1     Running   0          4m54s   <IP_ADDRESS>     vmkubei02.gfklctx.local   <none>
kube-proxy-fswqt                                  1/1     Running   0          2m17s   <IP_ADDRESS>     vmkubep05.gfklctx.local   <none>
kube-proxy-h9ptm                                  1/1     Running   0          3m18s   <IP_ADDRESS>     vmkubei03.gfklctx.local   <none>
kube-proxy-lzqxx                                  1/1     Running   0          2m18s   <IP_ADDRESS>     vmkubep03.gfklctx.local   <none>
kube-scheduler-vmkubei01.gfklctx.local            1/1     Running   1          5m35s   <IP_ADDRESS>     vmkubei01.gfklctx.local   <none>
kube-scheduler-vmkubei02.gfklctx.local            1/1     Running   0          4m11s   <IP_ADDRESS>     vmkubei02.gfklctx.local   <none>
kube-scheduler-vmkubei03.gfklctx.local            1/1     Running   0          2m46s   <IP_ADDRESS>     vmkubei03.gfklctx.local   <none>
[root@vmkubei01 ~]#

When deploying for example kubernetes dashboard we see that the new pod is getting calico ip, but it's not able to access himself and so on.
what are we doing wrong?

Is the setting with hostNetwork: true korrekt?
Regarding Kubernetes dashboard, please see attached screenshot

The mentioned IP is the Calico IP of the pod

@Joerg-L that looks like a kubelet liveness probe, meaning the host is trying to access the pod at that IP/port.
If you look at the host's routing table, do you see a route to that IP? Can you ping it?
Another thing to check would be to see if the the dashboard is actually serving on that port.

Is the setting with hostNetwork: true korrekt?

Yep, that's expected.

@caseydavenport thanks for your feedback.
I have made a resetup today by not using build in etcd but an external one.
I also have used the preferred calico setup yml.
Now, Kubernetes dashboard is working fine and can be accessed.
I think for now this issue can be closed. Thanks for your help.


Update creating-a-composite-run-steps-action.md

Why:
I added it because there is no description about private action only in the Composite action document.

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@KeisukeShima Thanks so much for opening a PR! I'll get this triaged for review :zap:

@ramyaparimi Thanks for your comment.
Let me explain this PR.
Below are links to testing Javascript Action and Docker Action.
There are Private Action and Public Action in these, and the user can choose either one.
However, the Composite Action documentation does not have this description, and users may misunderstand that they cannot choose Private Action.
In fact, I also read the docs and thought that Composite Action couldn't create a Private Action.
However, in reality, any Action can be tested in the same way. Therefore, the appearance of the document should be the same.
https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action#testing-out-your-action-in-a-workflow
https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#testing-out-your-action-in-a-workflow

I'm not a native English speaker, so corrections are welcome.

👋 Thanks so much for this PR @KeisukeShima! There was a lot of work recently done on the composite actions docs. Let us know if the information you're looking for isn't in the new docs!
We appreciate your interest and passion in improving the GitHub docs 💖


Create randsfk.thedev.me.json

Fix the email format.
Add a little more detail in the description field.
You can't have a domain as an A record.
Please review and fix.

By the way, A records are IPs (For example, Codeberg uses <IP_ADDRESS>)


Add Documentation for PowerDNS Plugin

Adding the required configuration settings to use the new PowerDNS Plugin.

Coverage remained the same at 59.261% when pulling 7dac0e1dd8978c055a6201d80e67a5cb30525362 on powerdns_doc_update_01 into a4475ad2a3befd83632366dc3fe800b642237bd8 on master.


Missing "customer.delete_unuesd_guests" scheduled task

With <IP_ADDRESS> there was integrated an scheduled_task for deleting unused guest customers periodically.
[https://github.com/shopware/shopware/blob/trunk/changelog/release-6-4-7-0/2021-11-04-added-delete-unused-guest-customer-command-and-task.md|https://github.com/shopware/shopware/blob/trunk/changelog/release-6-4-7-0/2021-11-04-added-delete-unused-guest-customer-command-and-task.md|smart-link]
This task is missing in newer versions.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-39402
[created from NEXT-39402, comment 509263]

[public]

Status Change: Open

This issue is ready for implementation.
[created from NEXT-39402, comment 509299]

[public]

Status Change: In Progress

Work on this issue has started. It is now being implemented.
[created from NEXT-39402, comment 509300]

[public]

FixVersion Change: <IP_ADDRESS>

This issue will be / was solved in Shopware version <IP_ADDRESS>.
[created from NEXT-39402, comment 509301]

[public]

Status Change: In Review

Work on this ticket is complete and is now pending review.
[created from NEXT-39402, comment 509312]

[public]

Status Change: Resolved

The ticket has been successfully completed; the solution is implemented and verified.
[created from NEXT-39402, comment 509373]


Pod networking is broken after antrea-ovs container restarts

Describe the bug
It's observed that in a scale cluster, some Pods' networking is broken on some Nodes (4-5 nodes out of 1000 Nodes after running some time).
It's because the antrea-ovs containers in antrea-agent Pods on those Nodes were restarted for reason that is unknown yet, which looks like they were killed because of liveness probing failures but there were no events claiming them.
  - containerID: docker://34f49ebf372540b09c10235b6a6ad925bd4bdc33b4980d1e3f2b1043de8683b3
    image: antrea/antrea-ubuntu:v0.2.0
    imageID: docker-pullable://antrea/antrea-ubuntu@sha256:c12efa83dfc9c5c13f668a58d26fbee26d2799f4d6a5434db1fe6259c53b3733
    lastState:
      terminated:
        containerID: docker://802733a210834a26a30995facefeab1bc423b6e93a131a99cf5dd34966da9356
        exitCode: 137
        finishedAt: 2019-12-26T11:03:08Z
        reason: Error
        startedAt: 2019-12-25T21:55:44Z
    name: antrea-ovs
    ready: true
    restartCount: 1
    started: true
    state:
      running:
        startedAt: 2019-12-26T11:03:09Z

The point is, all pods on those nodes can't work properly because the flows were lost and antrea-agent doesn't resync flows on disconnection. Regardless of the real reason of the restarting, antrea-agent should take care of such conditions and do a full sync once out-of-sync is detected.
This is antrea-agent log when it detects ovs disconnection:
I1226 10:45:09.799465       1 networkpolicy_controller.go:183] Stop watching AppliedToGroups, total 0 items received
I1226 10:45:09.799491       1 networkpolicy_controller.go:173] Start watching AppliedToGroups
I1226 10:50:38.405390       1 networkpolicy_controller.go:289] Stop watching NetworkPolicies, total 0 items received
I1226 10:50:38.405423       1 networkpolicy_controller.go:279] Start watching NetworkPolicies
I1226 10:55:57.372468       1 networkpolicy_controller.go:236] Stop watching AddressGroups, total 0 items received
I1226 10:55:57.372495       1 networkpolicy_controller.go:226] Start watching AddressGroups
time="2019-12-26T11:03:07Z" level=warning msg="InboundError EOF"
time="2019-12-26T11:03:07Z" level=info msg="Closing OpenFlow message stream."
time="2019-12-26T11:03:07Z" level=warning msg="Received ERROR message from switch 00:00:ba:ea:c9:dd:c0:4e. Err: EOF"
I1226 11:03:07.990286       1 ofctrl_bridge.go:177] OFSwitch is disconnected: 00:00:ba:ea:c9:dd:c0:4e
time="2019-12-26T11:03:07Z" level=info msg="/var/run/openvswitch/br-int.mgmt is disconnected, connecting..."
time="2019-12-26T11:03:07Z" level=error msg="Failed to connect to /var/run/openvswitch/br-int.mgmt: dial unix /var/run/openvswitch/br-int.mgmt: connect: connection refused, retry after 1 second."
time="2019-12-26T11:03:08Z" level=error msg="Failed to connect to /var/run/openvswitch/br-int.mgmt: dial unix /var/run/openvswitch/br-int.mgmt: connect: connection refused, retry after 1 second."
time="2019-12-26T11:03:09Z" level=info msg="Connecting to socket file  /var/run/openvswitch/br-int.mgmt"
time="2019-12-26T11:03:09Z" level=info msg="New connection.."
time="2019-12-26T11:03:09Z" level=info msg="Received Openflow 1.3 Hello message"
time="2019-12-26T11:03:09Z" level=info msg="Received ofp1.3 Switch feature response: {Header:{Version:4 Type:6 Length:32 Xid:9637} DPID:00:00:ba:ea:c9:dd:c0:4e Buffers:0 NumTables:254 AuxilaryId:0 pad:[0 0] Capabilities:79 Actions:0 Ports:[]}"
time="2019-12-26T11:03:09Z" level=info msg="Openflow Connection for new switch: 00:00:ba:ea:c9:dd:c0:4e"
I1226 11:03:09.992804       1 ofctrl_bridge.go:157] OFSwitch is connected: 00:00:ba:ea:c9:dd:c0:4e

To Reproduce
Kill antrea-ovs container, it should restart automatically, then all openflows will be lost.
Expected
Openflows should be re-synced after ovs is restarted and Pod networking should recover.
Actual behavior
The flows were lost and Pod networking is broken.
Versions:
Please provide the following information:

Antrea version (Docker image tag).
0.2.0
Kubernetes version (use kubectl version). If your Kubernetes components have different versions, please provide the version for all of them.
Container runtime: which runtime are you using (e.g. containerd, cri-o, docker) and which version are you using?
Linux kernel version on the Kubernetes Nodes (uname -r).
If you chose to compile the Open vSwitch kernel module manually instead of using the kernel module built into the Linux kernel, which version of the OVS kernel module are you using? Include the output of modinfo openvswitch for the Kubernetes Nodes.

@antoninbas @wenyingd I think you were aware of the issue, I think we should prioritize the fix as it affects all Pods on a Node once it happens, and it's likely to happen on a scale cluster because of CPU/memory pressure.

I believe we have all the infrastructure required to support this (notification mechanism + roundID / cookie support). The re-connection should trigger an empty message to be sent on a Go channel used to notify the OF Client (https://github.com/vmware-tanzu/antrea/blob/master/pkg/ovs/openflow/ofctrl_bridge.go#L167). Right now, the message is discarded (https://github.com/vmware-tanzu/antrea/blob/master/pkg/agent/openflow/client.go#L211), but it should not be too big of a change to replay all the flows upon receiving it.
@wenyingd are you already looking at this? Otherwise I can take a stab at it.

Hi @antoninbas , I think @wenyingd hasn't worked on it yet and she is on leave , please feel free to take it.

I'm on leave until the 6th as well, but I should have some time this week to look at this. I see 2 options:

"restart" the entire agent when we are notified of a disconnection
do not restart the agent, only replay the flows

1- is the simplest, but may be a bit of an overkill. In a large cluster, an agent restart can be quite expensive in terms of CPU & memory (and if as you said CPU / memory pressure is a possible reason for the OVS container to have been killed, then it's not ideal). 2- probably requires more work; we may need to add an extra RW lock in the OF Client so that the goroutine doing the flow replay can have exclusive access.
@tnqn @jianjuns a preference?

I would go for the 2nd approach. Could we stop the goroutines, and do reconciliation of all flows?

I think the ability to "pause" or stop the goroutine would be quite intrusive. We would need to introduce some pause channel, select statements... I believe the same is achieved by adding a read-write lock to the OF Client while keeping all the changes in one place. Only the reconciliation needs exclusive access, regular flow operations can still happen concurrently.

@wenyingd I spent time working on this today and made some good progress. Hoping to open a PR soon. I got stuck for a while at some point because I didn't realize right away that stored ofFlow objects are no longer valid after a reconnection because of a stale table pointer. I used the following workaround...
func (f *ofFlow) Add() error {
	f.Flow.Table = f.table.Table // <--- HERE
	f.Flow.UpdateInstallStatus(false)
	err := f.Flow.Next(f.lastAction)
	if err != nil {
		return err
	}
	f.table.UpdateStatus(1)
	return nil
}

Let me know if you think of something better.

@antoninbas Personally, I would prefer to add a specific function in ofFlow to resetTable or add function in ofTable like AddFlows, but not change ofFlow.Add function. I think the function is also needed after we change to use Bundle messages.

@wenyingd I'll add a function to ofFlow as you suggested, we can always adjust later


minimap2-coverage.c:565:9: error: implicit declaration of function 'compute_reliable_region' is invalid in C99

Hi, I'm new to this, but im currently working with fast5 files generated by minion
trying to install longQC in my Mac, I get run ´LongQC/minimap2-coverage && make´ I get the following error
´minimap2-coverage.c:565:9: error: implicit declaration of function 'compute_reliable_region' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
compute_reliable_region(v, fopt.min_coverage, &regs, &mregs);
^
1 error generated.
make: *** [minimap2-coverage.o] Error 1´
can anyone help me on this?
Thank you

hi @sanaek,
Which OS you currently use? I mean Mac OS version such as 10.xx.xx.
also, can I ask you to share output for below commands?
clang -dumpversion
gcc -dumpversion
Y.

hi @sanaek,
Which OS you currently use? I mean Mac OS version such as 10.xx.xx.
also, can I ask you to share output for below commands?
clang -dumpversion
gcc -dumpversion
Y.

Hello @yfukasawa thank you for your answer
I recently updated to Mac 11.1 BigSur
the output of the commands is the following:
clang -dumpversion 12.0.0 gcc -dumpversion 12.0.0
Sanae

Hello @yfukasawa thank you for your answer
I recently updated to Mac 11.1 BigSur
the output of the commands is the following:
clang -dumpversion 12.0.0 gcc -dumpversion 12.0.0
Sanae

Hi Sanae,
Thanks for sharing details - it helped. There seems to be some changs between clang11 and clang12, and the code hit this change.
I added a quick fix, and could you please download the latest codes from the repo and try again?
If there are still issues, kindly let me know. Thanks!
Y.

Hi Sanae,
Thanks for sharing details - it helped. There seems to be some changs between clang11 and clang12, and the code hit this change.
I added a quick fix, and could you please download the latest codes from the repo and try again?
If there are still issues, kindly let me know. Thanks!
Y.

Hi @yfukasawa
Thank you for your help, that worked great!
I had issues latter with edlib installed via conda, but resolved installing via pip the version 1.3.8 (if anyone has this issue)
I'll close this now, thank you for your work!

Hi @yfukasawa
Thank you for your help, that worked great!
I had issues latter with edlib installed via conda, but resolved installing via pip the version 1.3.8 (if anyone has this issue)
I'll close this now, thank you for your work!


Typo fix for peer-list in pxc-entrypoint.sh

Test name
Status

storage
failed

recreate
passed

haproxy
passed

big-data
passed

scaling
passed

scaling-proxysql
failed

init-deploy
passed

restore-to-encrypted-cluster
passed

limits
passed

monitoring
failed

demand-backup
passed

self-healing
passed

self-healing-advanced
passed

scheduled-backup
passed

upgrade
passed

upgrade-consistency
passed

operator-self-healing
passed

security-context
passed

monitoring-2-0
failed

demand-backup-encrypted-with-tls
passed

affinity
failed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

Test name
Status

scaling
passed

storage
failed

recreate
passed

big-data
passed

haproxy
passed

scaling-proxysql
failed

init-deploy
passed

restore-to-encrypted-cluster
passed

limits
passed

monitoring
failed

demand-backup
passed

upgrade
passed

self-healing
passed

upgrade-consistency
passed

scheduled-backup
passed

security-context
passed

self-healing-advanced
failed

monitoring-2-0
failed

demand-backup-encrypted-with-tls
failed

operator-self-healing
passed

affinity
failed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed


Stages running on parallel

How many stages can an agent run? I've tried to run 2 deployment stages with both hosted and self-hosted agents, and they can only run one stage at the time... is there something I can do for them to run more stages in parallel?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43799c5d-2f13-cc76-a1c0-a3f850e16d4e
Version Independent ID: 97a5b73f-faf7-f9c0-9269-fc79984616d6
Content: Deploy an Azure Pipelines agent on Windows - Azure Pipelines
Content Source: docs/pipelines/agents/v2-windows.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

@WongSSJ -- thank you for your question.  You may find answers here:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow

@steved0x -- please look into this potential documentation issue.

@WongSSJ You should be able to run stages in parallel, check the troubleshooting guide to see if one of these may be causing your issue:

Parallel jobs not running

Each agent can run 1 job at a time, so if you have 1 self hosted agent you can run 1 job at a time. To run multiple jobs in parallel you need more than 1 self-hosted agent, or you need more parallel jobs for Microsoft-hosted agents. See Run Parallel jobs for more details on running multiple items in parallel.


Add override-able OAuth credentials from environment variables

Fix #15
Signed-off-by: Gavin Reynolds<EMAIL_ADDRESS>

Hi @gsreynolds,
Thanks for the suggestion here - this approach makes sense during local development and if any organisation decides to host this using npm directly.
I'll merge this in and update the develop branch with this addition.


Mongo authentication and authorization.

YAWIK must support connecting to mongo databases with authentication and authorization enabled.

It does now, and it apparently has done it always. It just need to be configured correctly:
for example:
[
  'doctrine' =>  [
    'connection' =>  [
      'odm_default' =>  [
       'connectionString' => 'mongodb://user:pass@server:27017/db?authSource=authdb',
      ],
    ],
  ],
];


helm: cilium kvstore clustermesh failing without clustermesh-apiserver-remote-cert in 1.15

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
After upgrade from 1.14.8 to 1.15.3 Cilium  is failing to connect to remote etcd with:
level=info msg="Waiting for all etcd configuration files to be available" error="open /var/lib/cilium/clustermesh/common-etcd-client-ca.crt: no such file or directory" subsys=kvstore

Possible cause:

common-etcd-client-ca.crt is supposed to be included via clustermesh-secrets from clustermesh-apiserver-remote-cert:

https://github.com/cilium/cilium/blob/a758d21bbae09ab0c4a8cd671e05e043a8c1ea5a/install/kubernetes/cilium/templates/cilium-agent/daemonset.yaml#L863-L893

clustermesh-apiserver-remote-cert is created only when clustermesh.useAPIServer is set to true

https://github.com/cilium/cilium/blob/a758d21bbae09ab0c4a8cd671e05e043a8c1ea5a/install/kubernetes/cilium/templates/clustermesh-apiserver/tls-provided/remote-secret.yaml#L1-L5

Since after the 1.15.x upgrade kvstore can't be used together with clustermesh.useAPIServer, otherwise helm chart is failing with:

Helm upgrade failed for release kube-system/cilium with chart<EMAIL_ADDRESS>execution error at (cilium/templates/validate.yaml:85:7): The clustermesh-apiserver cannot be enabled in combination with .Values.identityAllocationMode=kvstore. To establish a Cluster Mesh, directly configure the parameters to access the remote kvstore through .Values.clustermesh.config

This change seems to be introduced in: https://github.com/cilium/cilium/pull/28763

As result, Cilium agent can't join remote etcd because of missing tls certs

Cilium Version
1.15.3
Kernel Version
NA
Kubernetes Version
N/A
Regression
1.14.8
Sysdump
No response
Relevant log output
level=info msg="Creating etcd client" ConfigPath=/var/lib/cilium/clustermesh/cluster-2 KeepAliveHeartbeat=15s KeepAliveTimeout=25s ListLimit=256 MaxInflight=100 RateLimit=100 subsys=kvstore
level=info msg="Creating etcd client" ConfigPath=/var/lib/etcd-config/etcd.config KeepAliveHeartbeat=15s KeepAliveTimeout=25s ListLimit=256 MaxInflight=100 RateLimit=100 subsys=kvstore

Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @taraspos,
You need to manually specify through the dedicated section the TLS key/certificate used to connect to the kvstore in remote clusters when running Cilium in kvstore mode, as those cannot be automatically managed by Cilium.

@giorio94 What's the takeaway? Does the upgrade documentation need to be improved? Sounds like this is a bit of a breaking change.

Hey @giorio94, thanks for the reply!
Our configuration works in 1.14.8, but we had useAPIServer set to true with replicas scaled down, that was a workaround because some resources were not created otherwise.
After upgrading to 1.15 useAPIServer=true can't be used together with kvstore, so I had to disable it and to face current issue. I will take a look at the tls configuration section you provided when attempting 1.15 upgrade somewhere later.

What's the takeaway? Does the upgrade documentation need to be improved? Sounds like this is a bit of a breaking change.

Hmm, specifying the clustermesh configuration through helm in combination with Cilium running in kvstore mode had never been supported properly, and required using the trick of enabling the clustermesh-apiserver, but then scaling the replicas to 0.
That was addressed by https://github.com/cilium/cilium/pull/28763, which also added an explicit validation to prevent running the clustermesh-apiserver when Cilium is running in kvstore mode. Indeed, this combination does not work correctly and is not supported by design, and allowing them to be enabled at the same time caused confusion to several users in the past.
@taraspos Could you please provide some more details about your clustermesh setup, and in particular about how the TLS certificates are configured for the external kvstores? The reason for not automatically creating the TLS certificates when the clustermesh-apiserver is disabled is that they wouldn't be trusted by the external kvstore, except in the very specific case in which the same CA is configured there as well (which I guess it could be the case for you).


Unique host constraint is not enforced during rolling upgrade of app

I have web servers that listen on a fixed port. I used marathon to launch these servers, and set a "hostname:UNIQUE" constraint to ensure that theses servers don't run on the same host and end up with port collision.
I had been using Marathon's rolling upgrade feature to upgrade these servers. It was working very smooth. Servers of the newer version are started in nodes that have no existing servers.
However, in recent Marathon versions, I found that such unique-host constraint is no longer enforced during rolling upgrade. New servers are being started side-by-side to old servers and failed with port collision.
This issue can be reproduced with following App JSON:
{
  "id": "/test-server",
  "cmd": "python -m SimpleHTTPServer 10101",
  "cpus": 0.1,
  "mem": 32,
  "disk": 0,
  "instances": 6,
  "constraints": [
    [
      "hostname",
      "UNIQUE"
    ]
  ],
  "portDefinitions": [],
  "upgradeStrategy": {
    "minimumHealthCapacity": 0.8,
    "maximumOverCapacity": 0
  }
}

Try triggering an upgrade, e.g. by increasing the CPU share, then likely some Marathon tasks would fail.
Marathon shows that multiple tasks are are running on the same host

The Marathon app's DEBUG page shows "TASK_FAILED", and the Mesos task's stderr shows that the task failure is due to multiple servers running on same host:
I0119 10:56:06.241583 68112 exec.cpp:162] Version: 1.1.0
I0119 10:56:06.243521 68122 exec.cpp:237] Executor registered on agent 367af7e4-ea29-470a-9b13-e7c5e9e9a768-S3
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib64/python2.7/SimpleHTTPServer.py", line 220, in <module>
    test()
  File "/usr/lib64/python2.7/SimpleHTTPServer.py", line 216, in test
    BaseHTTPServer.test(HandlerClass, ServerClass)
  File "/usr/lib64/python2.7/BaseHTTPServer.py", line 595, in test
    httpd = ServerClass(server_address, HandlerClass)
  File "/usr/lib64/python2.7/SocketServer.py", line 419, in __init__
    self.server_bind()
  File "/usr/lib64/python2.7/BaseHTTPServer.py", line 108, in server_bind
    SocketServer.TCPServer.server_bind(self)
  File "/usr/lib64/python2.7/SocketServer.py", line 430, in server_bind
    self.socket.bind(self.server_address)
  File "/usr/lib64/python2.7/socket.py", line 224, in meth
    return getattr(self._sock,name)(*args)
socket.error: [Errno 98] Address already in use

I am running Marathon 1.3.6. Did a brief searching, and found that the issue may be related to the fix in
https://github.com/mesosphere/marathon/issues/3624
which removes that constraint checking against tasks of an earlier version.
I think the constraint should be maintained throughout the rolling upgrade if it is not changed.

Interesting edge case. Probably the change should be done here to include all running instances with different version if constraints are equal. Can you think about any case that could break after this change?

I think it would suit most cases, but further improvement would be:

apply new constraints to the set of new tasks
apply unchanged constraints to the set of all tasks

The real solution for your issue you described (port collision) is to required static port in the app definition ("requirePorts":true) or to use network containerize.
Applying only unchanged constraints to deployment will cause a situation when you can't deploy application because it can't meet it's constraints e.g. UNIQUE HOST for 3 instances of application while you have only 3 nodes.

I am aware of network containerization. However, if I map the container port to the same host port, then I end up with the same problem. On the other hand, if I map to an assigned host port, I can use Marathon-lb to forward requests. But Marathon-lb/haproxy may forward requests from one server to another, which may waste significant network bandwidth.

Why you can't use "requirePorts":true?

Indeed related to #3624 where the current behavior was introduced, which sounds correct to me. If Marathon would consider old instances for matching constraints during upgrades, it would likely end up in situations where it cannot launch new instances. See the example @janisz described with N instances on N nodes and a hostame:UNIQUE constraint – if the upgradeStrategy doesn't allow taking down running instances before launching new ones, it could never finish a deployment.
@albertcsm Your app definition must make sure that the ports used are declared so that Marathon can consume those resources when launching an instance. If you define the app with no information about used ports, Marathon cannot consume them when launching an instance, and cannot make sure that new instances are launched on agents that actually offer that port.


Release errorprone-checks with log4j 2.17.0

We have updated log4j to 2.17.0. However, we don't know the release process for https://github.com/ConsenSys/errorprone-checks
@usmansaleem this one is waiting for you when you come back! :D

Created in wrong repo


sql: disable table renames across schemas

PR: https://github.com/cockroachdb/cockroach/pull/51433
From release notes:

Added a deprecation notice for the use of ALTER TABLE .. RENAME with a qualified name. [#51433][#51433] {% comment %}doc{% endcomment %}

Duplicate of #8129


fix: Multiple Selects UI

Hey, I just made a Pull Request!
In the Select component, I fixed the behaviour of the X button.
When clicking the X button, it popped up the list of all options instead of deselecting the selected option. This behaviour was inconsistent with the expected behaviour. To resolve this, I identified that the issue was caused by the default behaviour of the chip component, which triggered the parent component's onClick method.
To fix this, I added a custom delete component where I stop propagating the click event to the parent component. Additionally, I prevented the default action of the click event. This modification ensures that the X button deselects the selected option as expected and doesn't trigger unwanted actions in the parent component. I implemented the fix by adding a custom delete component that handles the click event appropriately, preventing unwanted behaviour.
Note: I used a custom icon for the delete button to avoid adding any unwanted libraries to the project.
Closes #20588
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@benjdlambert @tudi2d could you please look into this PR?

@tudi2d It make sens. As we have existing functionality in the code. We can remove the delete feature from chip and only print it as chip(label).
Just to clarify, once we remove this if someone uses this plugin they have to open the select module every to unselect the data they have choosen. Is this expecte behaviour?
This is the bahavior we wanted after changes, is that correct. Select with Chip

if yes, i can remove that and commit new changes.

@tudi2d any update on this??

Sorry for letting this sit around - will take a look today!


Making subclassing simpler; optimizing CallbackRegistry

The following is changed in the proposed pull request:

CallbackRegistry is reworked to avoid long-spanning synchronization blocks with mutex; instead, AtomicReference holding State + immutable data structures is used; "upgrade-state" and "fire-callbacks" responsibilities are divided between different inner classe hierarchies inside CallbackRegistry
SimpleCompletionStage and CompletionStageFactory are refactored a bit to make sub-classing easier:
a) SimpleCompletionStage becomes public (was package-protected)
b) SimpleCompletionStage get a factory as a constructor parameter to create nested stages
c) SimpleCompletionStage internals is modified to operate only with CompletableCompletionStage interface rather than concrete implementation
d) Visibility of certain methods/fields in SimpleCompletionStage and CompletionStageFactory classes are changed to "protected"

Cool, thanks a lot, I will take a look at it in next few days.

Sorry -- my fault. Eclipse-specific settings are removed and .gitignore is modified

Lukáš, sorry for commits after pull request -- I had to remove JEE-related classes while they need more thorough work. I were testing them in my internal application, and there are some issues with propagating context (completed vs non-completed cases behave differently). So it's a topic for another pull request.

It's all right, I will take a look at it over the weekend

I really like your change in CallbackRegistry. I did not have time to deep dive into your commit, but I have one questions anyway. What's your motivation for sub-classing? By making it extensible we would make future refactoring more complicated or impossible so I am just interested why is it needed.

That's why I were pushing my JEE extension so hard into this pull request. 😁
In the case with ManagedCompletionStage I need a subclass to override addCallbacks and wrap Consumer-s with
http://docs.oracle.com/javaee/7/api/javax/enterprise/concurrent/ContextService.html
Moreover, all next stages created in pipilene should be ManagedCompletionStage rather than SimpleCompletionStage - hence the factory parameter.
This attempt is not yet complete, but please take a look here instead:
https://github.com/vsilaev/java-async-await/tree/master/com.farata.lang.async.examples/src/main/java/com/farata/concurrent
This is what everyone is asking for on StackOverflow - composable and cancellable  RunnableFuture+CompletionStage that is possible to execute, say, on ThreadPoolExecutor. Please take a look what class CompletableTaskImpl extends - I need a workaround even for simplest case. Otherwise it was dead simple to implement this atop of your lib!
Btw, in my future plans there are wrapper for JAX-WS async WebService ports, wrapper for Jersy AsyncInvoker (REST) and Ning AsyncHttpClient - and I plan to use your lib here too.

Cool, I see you have big plans. I will take a look at your code tomorrow and if I realize that it's too complex for me, I will just give you commit rights to the repo so I do not slow you down.

I have picked your commits without CallbackRegistry refactoring, did cosmetic cleanup and put it to branch https://github.com/lukas-krecan/completion-stage/commits/extensible. If you agree, I will merge the branch to master.

CompletionStageFactory does not implement CompletableCompletionStageFactory interface, and you use labmda in
public  CompletableCompletionStage createCompletionStage() {
return new SimpleCompletionStage<>(defaultAsyncExecutor, this::createCompletionStage);
}
I guess it would be ok to directly implement interface an pass self reference:
public  CompletableCompletionStage createCompletionStage() {
return new SimpleCompletionStage<>(defaultAsyncExecutor, this);
}
Regarding reverting CallbackRegistry -- no problem with reverting it back. Though, I would like to repeat tests on my own. First, random is known for it's problematic performance characteristicts, not sure about "noise" it adds to results. Second, I see only uncontended synchronization scenario (no async calls at all).
But for now I would be more than happy if you merge the branch (probably with revisiting CompletionStageFactory hierarchy as mentioned) and I will work on CallBack registry tests separately.

I did some force pushes to the branch since I did not know you are online. Sorry for that. I have implemented the change you have proposed. If you need anything else, please let me know, I am still trying to wrap my head around your enterprise use cases.

Some commit merged into master in https://github.com/lukas-krecan/completion-stage/pull/5


Copy Without Syntax Highlighting

There is tow entries in menu to copy:

Copy ctrlc
Copy With Syntax Highlighting

Both have the same effect.
Can you add a "Copy Without Syntax Highlighting" entry"?

It quite surprised me that copying with formatting is the default.
Sure, there are sometimes it is nice to copy with the syntax highlighting etc (inserting snippets into documentation maybe), but the general expectation for light-weight editors like this is that copy-pasta is plain text and I for one would want the latter effect most of the time.

Closed in favor of https://github.com/Microsoft/vscode/issues/21071#issuecomment-418887276


Update to k8s 1.18.8 api version

Why is this PR needed?
also includes a bump of crypto and json library versions to bugfixed/security fixed versions.
Fixes https://github.com/SUSE/avant-garde/issues/1907
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

@dirkmueller Do you have the issue number or bsc for this? If there is none, could you create one? We need it for planning the releases. Thanks.

@dirkmueller Do you have the issue number or bsc for this? If there is none, could you create one? We need it for planning the releases. Thanks.

not specifically, but I consider it part of https://github.com/SUSE/avant-garde/issues/1907 . it is more a tech debt cleanup than anything else. we shouldn't hardcode outdated dependencies, even in a "shift left" paradigm.

We have merged this PR https://github.com/SUSE/skuba/pull/1413 that already covers the version, I will close this PR.


Revert changes in BasicApps/Tee

Commit 38c4d3 (initial vguest app, packets are transmitted) made changes in basic_apps/Tee that broke packetblaster app. This patch reverts the implementation of Tee back to master, which fixes packetblaster.
It's not possible to revert the patch because the commit changes other files too.

LGTM.


Update readme.md

Removed test comment.

Thanks! You can now delete your fork, https://github.com/jweeks2023/csci-1301.github.io/tree/patch-1


Improve changelog check for pre-release branches

Forgot about this PR but found better solution here https://github.com/RasaHQ/rasa/pull/12442. Closing this.


'URL bucket doesn't match' error appears if to create an unpublish request for some conversations

Log on staging env via admin (Auth0) (use 1Passoword to find admin credentials)
In Organization section hover over the folder 'VB + DK folder in the change path' > click on three dots > click on Unpublish
Type any name for the request ( at the top left corner on the pop-up) and click on Send request button
-> error appears

The same issue appears for the following conversations:

Note: As the owner of VB + DK chat I can say that I used standard flow to publish the chat:

created echo, attached file. The file is stored here:

while publishing new folder in Change path was created:

Approved by Admin. No any specific actions were done

@VolhaBazhkova
The request to unpublish the conversation contains resource to a private file. So there is something wrong with request data or how the file came to the conversation.
Core replaces links to files in the conversation provided from publish request.

Reported the ticket on chat side https://github.com/epam/ai-dial-chat/issues/2004

It turned out the front-end has a defect in encoding resourceUrl in the publish request.
A special symbol + is not encoded properly.
See https://github.com/epam/ai-dial-chat/issues/2004


fixed the broken property table and fixed the snippets in README.md

Thanks, I had those changes already applied together with a lot of all other changes but not pushed yet.


Confirm that we may use logos in client section

I don't have consent of these entities, but we probably should double check. Providing them backlinks as I have done should be sufficient, but sometimes businesses can be touchy about this.

Checking in with Ecumen

Ecumen confirmed.

Rejoice Contacted.

Rejoice Ecstatic! "Hey Dan!  Love your website!  Awesome!  I say, thanks for mentioning Rejoice!
"


Refactor KMeans benchmark

This PR enables spark-bench to support KMeans benchmark for both Scala and Java implementations. All three related parts (Implementations, driver scripts and documentation) have been refactored in this initial commit.

@lm4limin, this PR is ready for review. I did a light test on our production cluster. It works for both versions. Thanks!


[Enterprise] Check gdrive tokens on organisation accounts

From: SB/4776590

This error appears in the pop-up window. Sometimes before selecting an account and sometimes before selecting and account, but user never was able to connect the account finally
I have checked the synchronization_oauths table and is empty for the user. I was able to set in that account a test Google account and it worked. The sync_oauth was added correctly and then removed correctly when I revoked the access.
The user has tried from several Internet connections and says that is able to connect the google account in a CartoDB account outside the organisation.
cc @Kartones @juanignaciosl

Closing. This error happened when the same Google account is tried to be used in more than 1 CartoDB account. Google will just give a token for the CartoDB service so the next attempt won't return a token.


dacrane tutorial

User Story
Developers would like a tutorial to help them learn how to use Dacrane the first time.
Acceptance Criteria
(TBD)

The cost of document maintenance will be too high if the specification is not stabilized, and will be addressed in 0.1.0 or higher.


helm: make gRPC and metrics address/port configurable

This patch makes the gRPC address and port configurable in helm and adds a similar option
to configure the metrics address. Fixes #40.
Signed-off-by: William Findlay<EMAIL_ADDRESS>

i'll review this today i have a couple of suggestions 🙏

@michi-covalent I fixed up the changes you suggested, thanks.


EOFError: Compressed file ended before the end-of-stream marker was reached

I installed it the following way and got an error on Ubuntu16.04 Desktop.
installation method：
sudo add-apt-repository ppa:boltgolt/howdy
sudo apt update
sudo apt install howdy

At the last step, an error occurred:
Traceback (most recent call last):
  File "/var/lib/dpkg/info/howdy.postinst", line 146, in <module>
    tf.extract(item, "/tmp")
  File "/usr/lib/python3.5/tarfile.py", line 2038, in extract
    numeric_owner=numeric_owner)
  File "/usr/lib/python3.5/tarfile.py", line 2108, in _extract_member
    self.makefile(tarinfo, targetpath)
  File "/usr/lib/python3.5/tarfile.py", line 2156, in makefile
    copyfileobj(source, target, tarinfo.size, ReadError)
  File "/usr/lib/python3.5/tarfile.py", line 241, in copyfileobj
    buf = src.read(BUFSIZE)
  File "/usr/lib/python3.5/gzip.py", line 274, in read
    return self._buffer.read(size)
  File "/usr/lib/python3.5/_compression.py", line 68, in readinto
    data = self.read(len(byte_view))
  File "/usr/lib/python3.5/gzip.py", line 480, in read
    raise EOFError("Compressed file ended before the "
EOFError: Compressed file ended before the end-of-stream marker was reached
dpkg: error processing package howdy (--configure):
 subprocess installed post-installation script returned error exit status 1
Setting up dh-strip-nondeterminism (0.015-1) ...
Setting up debhelper (9.20160115ubuntu3) ...
Processing triggers for bamfdaemon (0.5.3~bzr0+16.04.20160824-0ubuntu1) ...
Rebuilding /usr/share/applications/bamf-2.index...
Processing triggers for libc-bin (2.23-0ubuntu10) ...
Errors were encountered while processing:
 howdy
E: Sub-process /usr/bin/dpkg returned an error code (1)

@boltgolt

I installed it the following way and got an error on Ubuntu16.04 Desktop.
installation method：
sudo add-apt-repository ppa:boltgolt/howdy
sudo apt update
sudo apt install howdy

At the last step, an error occurred:
Traceback (most recent call last):
  File "/var/lib/dpkg/info/howdy.postinst", line 146, in <module>
    tf.extract(item, "/tmp")
  File "/usr/lib/python3.5/tarfile.py", line 2038, in extract
    numeric_owner=numeric_owner)
  File "/usr/lib/python3.5/tarfile.py", line 2108, in _extract_member
    self.makefile(tarinfo, targetpath)
  File "/usr/lib/python3.5/tarfile.py", line 2156, in makefile
    copyfileobj(source, target, tarinfo.size, ReadError)
  File "/usr/lib/python3.5/tarfile.py", line 241, in copyfileobj
    buf = src.read(BUFSIZE)
  File "/usr/lib/python3.5/gzip.py", line 274, in read
    return self._buffer.read(size)
  File "/usr/lib/python3.5/_compression.py", line 68, in readinto
    data = self.read(len(byte_view))
  File "/usr/lib/python3.5/gzip.py", line 480, in read
    raise EOFError("Compressed file ended before the "
EOFError: Compressed file ended before the end-of-stream marker was reached
dpkg: error processing package howdy (--configure):
 subprocess installed post-installation script returned error exit status 1
Setting up dh-strip-nondeterminism (0.015-1) ...
Setting up debhelper (9.20160115ubuntu3) ...
Processing triggers for bamfdaemon (0.5.3~bzr0+16.04.20160824-0ubuntu1) ...
Rebuilding /usr/share/applications/bamf-2.index...
Processing triggers for libc-bin (2.23-0ubuntu10) ...
Errors were encountered while processing:
 howdy
E: Sub-process /usr/bin/dpkg returned an error code (1)

@boltgolt


[log] broken up UA string

Log service returns this in the headers section:
    "User-Agent": [
          "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML",
          "like Gecko) Chrome/51.0.2704.103 Safari/537.36"
        ],

because you are processing headers values (seems to me you are splitting on commas and ignoring semi-colon-ed sections - judging by the look of accept-language).
Expected: return a string
Overall, I think you should let the header values untouched (or maybe your http wrapper is doing that on its own?).

Workaround-ed in tsygan.


Update online architecture diagram

Change to SVG format and providing labels for architecture components

Do we explain anywhere what the letters A-D mean? :)

Do we explain anywhere what the letters A-D mean? :)

will add it

Will be updated later


[ Work-In-Progress ] Add methods for catalog/delta tables

Associated issue:
https://github.com/awslabs/aws-data-wrangler/issues/1055
Aim is to add two methods for creating a table using Delta lake. Link:
https://delta.io/
I've called the methods legacy (open to naming suggestions) since these are intended for systems which don't support Delta natively. These include:

Redshift Spectrum
Athena

These rely on a manifest for specifying which files the client needs to process and processes them like normal Parquet files. See:
https://docs.delta.io/latest/presto-integration.html
https://docs.delta.io/latest/redshift-spectrum-integration.html
Native implementations would include Spark for example which is able to read the Delta metadata and is not supported by this code as of yet.
This is very much a work in progress (no tests etc). Will let you know when it's ready for review.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 63e6dfe097cf04311e8d63327e77a1e5da4b8f9a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 7713254b058e3468ab72baa2015240b98a7748fd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: b44b2026f778230d7511f012bdfc455bc9ccbbb3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 5adc8d9c9d046555ecf7a41ec343ef05c0167856
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 530d1aa428b93d5e4302518133d81c5f57445368
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 1c2082cdcdc7e516b19c19245429b54ad64376ba
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 7f597bc25de80e9a106f833cb132c0f9dd9df378
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 811a1bdd8147a1619acfd3974393be8dfab1663c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: ca1b646c07d387815ce4aec1c41f399dbc0887ff
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: ca1b646c07d387815ce4aec1c41f399dbc0887ff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Closing due to inactivity.


Add Dockerfile for building on Docker hub

This is the first part for #65.
You can see the image here: https://hub.docker.com/r/robinst/tarpaulin/
You can try it out in a repository where you want to calculate coverage using this command:
docker run --security-opt seccomp=unconfined -v "$PWD:/volume" robinst/tarpaulin

If you want more options, you have to run it like this:
docker run --security-opt seccomp=unconfined -v "$PWD:/volume" robinst/tarpaulin cargo tarpaulin --ignore-tests --out Xml

If you want to run multiple commands, you have to use a shell like this:
docker run --security-opt seccomp=unconfined -v "$PWD:/volume" robinst/tarpaulin sh -c "cargo build && cargo tarpaulin"

After merging this (or even before), you can set up an automated build in your account using "Create Automated Build" on Docker hub:

You will be able to configure when it should be built automatically, e.g. only build tags or also build master. You probably want to remove automatic building of all branches.
Once that's done I can raise another PR to add the instructions to the README :).

Why ever the beta and nightly builds fail is likely a separate issue entirely. Everything looks good so I'm going to merge this in and set up dockerhub, thank you :+1:

I saw that you tried building the tag here: https://hub.docker.com/r/xd009642/tarpaulin/builds/bgvliskm2842x9ygyglbamm/
That's not gonna work until the next tag which will contain the Dockerfile. For now, can you set it up to build master, until we want to release this?

Yeah I've currently got a docker image built called latest which is based on the most recent commit on master https://hub.docker.com/r/xd009642/tarpaulin/builds/bggdjcshcsh6dgp2bhpgbhk/ if you want to start the PR for the updates to the readme/documentation that would be helpful :smile:


feat: retries if default port is occupied

Yay, first PR to abell. More to come :)
What type of PR is this?

[x] Feature
[ ] Bug Fix
[ ] Refactor
[ ] Documentation Update

Description
Closes https://github.com/abelljs/abell/issues/61
This PR recursively find the next available port if default port is used until 3 levels. It doesn't run this for non-default ports as user has explicitly specified the port there.
Screenshots:
Port 5000 is avaliable

Port 5000 taken

Port 5000, 5001 and 5002 taken

Port 5000, 5001, 5002 and 5003 taken(case which exceed the max retries)

Open questions:

[ ] Should we prompt the user instead of doing this by default. Creating a prompt will require additional effort as we don't have one already in the project.

Added unit tests?

[ ] No, I want help in writing tests.
[ ] No, I want someone else to write tests.
[ ] No, The addition does not need tests.
[x] Yes

(I will add them tomorrow, too sleepy right now)
[optional] Random GIF to +1 someone's day
Here is my dog's picture(name is Arrow :) )

I will add tests soon then this we ready for merge

Should we prompt the user instead of doing this by default. Creating a prompt will require additional effort as we don't have one already in the project.

No, I think this way is much better than having a prompt.

P.S. Arrow is suchaa cutieeeee!!! When you all celebrate his birthday or any other day for him, is it called Arrow Function :p ?

Re P.S. : haha, his birthday is on 7th July
My brother actually named him from the TV series Arrows. First time I have linked him with is arrow fns because of you 😅.

Hold up, we have no tests for dev server 😅

oh yes lol forgot. Here https://github.com/abelljs/abell/issues/35

I will test this code manually tomorrow and we can write tests for dev-server after that. Any idea on how we can test it though?

@saurabhdaware I will add test for the whole deal, don't worry now. This one is on me now

Woah! That will be huge help 🎉

Ok, this is ready for review now. I have added tests for http server and the retry logic.

Opened https://github.com/abelljs/abell/issues/72 for adding tests for wss


Feedback: minimum order value with in3 as payment method

in3 has a minimum order value of 100 euro, otherwise Mollie will throw the following error:
Error executing API call (422: Unprocessable Entity): The amount is lower than the minimum.
This should be documented in the docs of the plugin, or there should be automatically a rule created that has a minimum cart value of 100 and assigned to in3

hi
thanks
this is a great idea,
at the moment we do not focus on building all these rules, because a merchant might already have rules that he needs to touch again instead of using a different prepared rule
and yes, I'm struggling a bit with rebuilding the documentation that mollie already has :D
but you are totally right, that should be added to the plugin WIKI at least, thanks for this

added to the docs
thx again


Generic parameters

Putting this up to get some feedback. Second PR contains all the major changes.

Add grammar for trait bounds and type parameters (and uses it for trait objects) based on the grammar from @brauliobz's branch, as well as nikomatsakis's parser and jorendorff's grammar.
Gives lifetime parameters some recognition
Documents HRTB (breifly)

cc #256

Comments addressed, I think?

rebased, but CI still can't build mdbook.

Is it possible to rerun CI?

Pushed another commit, CI hasn't changed.

The tests are passing on my computer, and TravisCI is acting weird, so merging as is.


Set Up and Generate a New SAP Fiori App Project

Tutorial URL: https://developers.sap.com/tutorials/fiori-tools-generate-project.html
Please specify the step you are referring to
In "Step 5: Preview app with real backend data"

My backend is ES5. I tested that I can connect.

After "npm start" in terminal.
I got this URL from Chrome Inspector. It is red (error).
http://localhost:8080/sap/opu/odata/sap/SEPMRA_PROD_MAN/$metadata?sap-value-list=SEPMRA_PROD_MAN.SEPMRA_C_PD_ProductPriceRangeType%2FPriceClassification%2CSEPMRA_PROD_MAN.SEPMRA_I_ProductCategoryType%2FMainProductCategory&sap-language=EN
From the error, I think the problem lies with the metadata definition.
You get the below XML when viewing the above URL in browser.
<error xmlns="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata">
<code>/IWFND/CX_SODATA_EDM_PROVIDER/</code>
<message xml:lang="en">Value-List SEPMRA_PROD_MAN.SEPMRA_C_PD_ProductPriceRangeType/ not found in Metadata</message>
<innererror>
<application>
<component_id>BC-SRV-NWD-FRA</component_id>
<service_namespace>/SAP/</service_namespace>
<service_id>SEPMRA_PROD_MAN</service_id>
<service_version>0001</service_version>
</application>
<transactionid>B9E0A2A100BE0040E005EFCF1C2B79D7</transactionid>
<timestamp>20200703033858.4680560</timestamp>
<Error_Resolution>
<SAP_Transaction>For backend administrators: run transaction /IWFND/ERROR_LOG on SAP Gateway hub system and search for entries with the timestamp above for more details</SAP_Transaction>
<SAP_Note>See SAP Note 1797736 for error analysis (https://service.sap.com/sap/support/notes/1797736)</SAP_Note>
</Error_Resolution>
<errordetails/>
</innererror>
</error>

Hi @amosang
Yes you are right. I see some issues with the service but this should not prevent you from completing your tutorial.
Internally, I will follow up with my colleagues who are maintaining the ES5 demo system to see if the service can be updated.
Thanks,
Sushant

@theStiggySpd Thanks for your reply and followup with your backend colleagues. Perhaps you can close this issue when that's done?
Meanwhile, "this should not prevent you from completing your tutorial" -> what is the workaround?

Hi @amosang ,
Are you stuck due to this error showing up in console?
As long as you can run the app using npm start, you should be good to go.
Let me know if you are not.
Thanks,
Sushant

Hi Sushant,
Well technically one can start the app with "npm start", but it was not very useful seeing absolutely no data records.
I've tried "Preview in Browser" for the test folder as well, but same outcome.

I supposed one can move on to other tutorials, if no data records are shown. Thanks anyway.

Hi @amosang

Well technically one can start the app with "npm start", but it was not very useful seeing absolutely no data records.

Did you press the "Go" button and you don't see the list of Products?

Sorry my bad. Clicking the "Go" button loads data from locally, but only for the MockServer.
Appreciate your help :)

This has been fixed on the non-MockServer as well.
I am impressed :)


Update index.html

:star: PR built and available in a preview environment tatami-live-tatami-test-pr-1 here


Godot launcher fails to open in most recent builds from Calinou

Godot version:
3.2 Dev, April 5 and April 6 from Calinou's site. I can't get the hash because the launcher fails.
OS/device including version:
Win10 64 bit, April Update. Ryzen 2700X CPU, GTX 1060 6GB GPU.
Issue description:
New Godot builds over the last two days fail to launch. The console appears then disappears, the launcher fails to run. I have a build from April 3 and that runs just fine.
Steps to reproduce:
Download the daily build from here.
https://hugo.pro/projects/godot-builds/
Just double-click the icon and see if anything shows up.
EDIT: Accidentally typed the wrong Win10 revision.

I can't get the hash because the launcher fails.

You should be able to run the executable with --help from a command-prompt to see the build hash.

Well, the day's commits usually stop early in the evening in my Timezone, and the newest build's date was around 8:30 PM, so I assume this was the latest commit it had.
https://github.com/godotengine/godot/commit/de825df1210089b4f8427618bb758101d5ad379b
The only real big commit I can recall over the past couple of days is the inclusion of the assimp library (as my newest working build has the fake 3D effect from Juan).

I will also add, the console closes before anything is even printed. It stays blank and no errors are given.

I can confirm it is not working on windows 10.

The x64 not working, the x32 does work.

@Ace-Dragon sorry for the late reply, i was compiling from source myself, I will check later if  calinous build still fails

i just compiled https://github.com/godotengine/godot/commit/07b76c0376eef34fcbf52ecc21074c5084f980f5
and it works.
i downloaded @Calinou latest win x64 and same error. the "godot.exe --help" does not even show a sign of life. usually information would appear but nothing.

The last Calinou build was from the 8th of April (I can tell because the modified date of the Godot.exe reflects the time it was built rather than the time I downloaded and unzipped it).
Sometimes his buildbot fails for a day or so, it could be more likely right now since big changes are coming in.

@Ace-Dragon I ran a new build this evening, try downloading it again.

@Ace-Dragon I ran a new build this evening (as yesterday's build failed indeed), try downloading it again.

Sorry but still won't work for me :P

@Ace-Dragon I ran a new build this evening (as yesterday's build failed indeed), try downloading it again.

Still nothing for the 64 bit build, the console still opens and closes with no errors or prints.

Same problem with me. It wont open.

You all have issue with @Calinou's builds IIUC? Do you get the same issue with @fire's nightly builds? https://ifiregames.itch.io/stern-flowers-chibifire-com-godot-engine

You all have issue with @Calinou's builds IIUC? Do you get the same issue with @fire's nightly builds? https://ifiregames.itch.io/stern-flowers-chibifire-com-godot-engine

Good find, the build works perfectly, even though it might take more than one try to actually get the launcher. It really does seem now it's due to Calinou's build process.
I didn't pay for the access, but I will make sure not to download every day to help him save bandwidth. :-)

@Calinou @fire Can you share your respective build options for Windows (toolchain, use of LTO, etc.)?

@Ace-Dragon Bandwidth is not the issue, the system to build the setup is the expensive part.
@akien-mga Here's the windows editor build:
scons platform=windows target=release_debug use_static_cpp=yes -j`nproc` use_lto=no use_llvm=yes gdnative_wrapper=yes deprecated=no

I can also send you the entire file by message.

@fire So you're using LLVM for Windows build? Or is this just a stray argument from your Linux build?

These are the flags used for my 64-bit editor build:
# Build Windows editor
scons platform=windows bits=64 tools=yes target=release_debug use_lto=yes debug_symbols=no progress=no

Maybe link-time optimization is causing the issue (since it's not used on 32-bit)?

I just pushed a new commit that disables LTO for my Windows builds, check back in a few hours when the build is finished.

@Calinou @fire It would still be good to know the exact toolchain that you're using (I assume MinGW, but what GCC version?). The binutils version would also be useful as it impacts LTO.

I am also using fedora 29, but I don't have the exact versions. Currently busy with work.

@Calinou ; I noticed your new build works as expected, now I can use things like the VSE additions :-)

I just tried the windows 64 bit ZIP version and still not working. Starts and quits without a message.

Works for me now. :)

still no luck for me.... 32 bit version works though.. So I'm on Windows 10 and trying the 64 bit version coming from the Zip archive .

Anyone who still has trouble with Calinou's builds should give Fire's builds a shot. If they still don't work, then it would help to know system information such as the Windows 10 version.

Fire's build, works for me.

Fire's build, works for me.

What is the status of this issue?

@Ace-Dragon Can you still reproduce this with the latest builds?

Your builds have worked like a charm for a couple of months now.

I haven't got a response from @plucian, so I'll close this. Thanks for reporting it :slightly_smiling_face:


[Request]Modify Villager/Merchant trades

Villagers are infuriating when they sell a tool or item that the tweaker tried to make unobtainable, Especially trades added in by mods that sell redundant items that had their oredict and recipes removed.

LootTweaker deals exclusively with loot tables. Villager trades do not use loot tables, hence this is out of scope for LootTweaker and will not be added.
A quick CurseForge search turned up Villager Trade Tables, which looks like it should suit your needs.


Compile failure in react project.

Tried the sample:
ERROR in<EMAIL_ADDRESS>26013:40-53
Module not found: Error: Can't resolve 'fs' in 'C:\repo\my-react-project\node_modules\@kusto\language-service'

webpack compiled with 1 error and 1 warning
No issues found.

Could you please give us a minimal sample for projects created with create-react-app?
System configuration
monaco-kusto version: 10.0.7
monaco-editor version: 0.44.0
Browser:
OS:

I believe there is a bug in @kusto/language-service/bridge.js
requrie("fs") should be changed to __non_webpack_require__("fs").
https://stackoverflow.com/questions/52581441/ignoring-specific-requires-in-webpack

If you're trying to get the esm version working then esm-webpack-react is the closest example.
That example configures webpack to ignore the import:

I'm not aware of any way to get Create React App to have this behavior without either ejecting or using something like craco^1 to customize the config.
I agree that this is a bug in @kusto/language-server, but I'm afraid I don't expect to see it fixed anytime soon.
I agree that the require call in the

Created an issue to track this: #388


Build -prod Mangles CSS

Running ng build -prod runs minification on CSS, which removes units from rules with values such as 0px or 0%. This is not always desirable behavior, as browsers will handle these unit-less values differently, in some cases breaking the intended layout of the page.
Versions
Angular CLI: 1.5.4
Node: 7.9.0
OS: darwin x64
Angular: 5.0.3
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic, router

@angular/cdk: 5.0.0-rc.2
@angular/cli: 1.5.4
@angular/material: 5.0.0-rc.2
@angular-devkit/build-optimizer: 0.0.33
@angular-devkit/core: 0.0.21
@angular-devkit/schematics: 0.0.37
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.8.4
@schematics/angular: 0.1.7
typescript: 2.4.2
webpack: 3.8.1

Repro steps

Create a new project with CLI.
Add a div with class of foo to a component.
In the associated component CSS, add a style of width: 0%; to the foo class.
Run ng serve.
Using Chrome Debugger Tools, inspect the div element's style. Notice that it shows width: 0% as it was defined in code.
Now, run ng serve --prod.
Using Chrome Debugger Tools, again inspect the div element's style. Notice that it now shows width: 0.

Observed behavior
The styles output from the production build do not include units on CSS rules with values of 0.
Desired behavior
The styles output from the production build should include the specified unit on CSS rules with values of 0. Ideally, this should be configurable as not everyone will want this as default behavior.
Justification
I understand that in an ideal world we would prefer to use standard, well-formed CSS to style our applications. However, in practice we often run into situations where we have to work around various browser implementations to provide cross browser support. Sometimes this means implementing some very specific CSS hacks.
In most cases it is desirable to drop the units from 0 value rules for a more compressed file, but sometimes we need to force the browser into reading these values as certain units, specifically when using flex rules.
https://stackoverflow.com/questions/47040371/why-flex-container-flex-1-0-0px-collapses-on-chrome
https://github.com/philipwalton/flexbugs#flexbug-4

This particular issue still appears on IE 11, which we will be stuck supporting for some time, so as much as I would like to, I don't think we can pull the "it's a browser bug" card.
It seems there is a PostCSS plugin which can fix some flex box issues (though not quite all of them it seems): https://github.com/luisrudge/postcss-flexbugs-fixes.
We should look into integrating that plugin into the pipeline. We'll need to go through proper vetting so more research needs to be done, but it seems promising so far. Needs more investigation to validate the plugin.

Closing since IE 11 support is deprecated. While we still support it, we shouldn't add additional features and tools to increase IE 11 support.


[W5.7][W10-2]Low Yew Woei(Aiden)

Request to add Sort Command feature that prints out everything in the addressbook by alphabetical order.

Nice work! Follow the original syntax and coding standard.
Sorry for the late comment and really appreciate your help today. Thanks so much!

As before, please close the PR after viewing comments.


Correction Timecodes

YouTube now offers corrections timecodes, I just tried adding one for this video:
https://thecodingtrain.com/tracks/pixels/pixels/painting-with-pixels
I manually added it to the YT description:
Corrections:
02:40 This old example is not using classes in JavaScript. Check the accompanying code for an updated version!

Maybe we should consider adding this to the JSON for each video as well as the description generator?

Would this need to be implemented on the website as well? YT doesn't seem to show the pop-up inside embeds.

Would this need to be implemented on the website as well? YT doesn't seem to show the pop-up inside embeds.

I don't think it needs to be no, but since I generate the descriptions from the JSON, I'd love to have it there for safe-keeping and consistency.We could render it to another "tab" like references, videos, etc. "Corrections" also.
This is pretty low priority as I only just used it for the first time on this one video... and don't know if I really plan on adding it to more places in the future. In theory, though, it's a great feature to be able to annotate mistakes and things that have changed.

Can we close this issue since #1282 was merged?

Yes! Thanks for the reminder!


why html tags hiding

https://plnkr.co/edit/gWFKX34woucJRgDrJCdd?p=preview
It is hiding html paragraph tags in text box.
How can I show them.

This is not how things work in Angular. The model is your source of truth. Any data initialization should be done there. E.g. you should set name to the value you want and the input field would be updated accordingly (not the other way around). [Updated plnkr]
--
That said, this repository is reserved for bug reports and feature requests.
Please, use one of the appropriate channels for general support questions (such as this).
Thx !


Support default branch syntax in GitHub UrlReader

Feature Suggestion
The GitHub discovery processor currently supports using - in place of the branch name to represent the default branch. For example: https://github.com/myorg/service-*/blob/-/catalog-info.yaml
The - is resolved into the actual name of the default branch by the discovery processor before it creates the child location in the catalog, which will then be used for reading the target YAML. This means that the entity location URL will in the end be set to for example https://github.com/myorg/service-foo/blob/master/catalog-info.yaml. This then triggers a conflict if you ever rename the default branch, since for example https://github.com/myorg/service-foo/blob/main/catalog-info.yaml is considered a different location. You then need to delete the original entity before the new location is picked up, as discussed in #9030.
I think we can solve this by keeping the - in place in the location URL, and instead power up GithubUrlReader.readUrl to support that syntax.
Possible Implementation
We think this is a good first issue and would be happy if anyone from the community wants to pick this up! ❤
On the UrlReader side it should be enough to switch out this to not pass any ref query param if the ref is '-'.
In the discovery processor it should be enough to remove this logic and pass through the - in the URL instead. It is probably best to keep the check that makes sure that the repository has a default branch when using - as well.
These are pretty small changes, but we'd want to spend some time verifying that this all works as intended, allowing switching out the default branch and so on. One important thing to verify and possibly work around is to make sure that this doesn't have a negative impact on existing catalogs that currently use GitHub discovery.
Context
#9030

Noting that if this all works as expected it could be something to implement for the other discovery providers and discovery processors as well.

Hi, I'm looking at this issue. Couple questions.

Is there a typo in here?

This means that the entity location URL will in the end be set to for example https://github.com/myorg/service-foo/blob/master/catalog-info.yaml. This then triggers a conflict if you ever rename the default branch, since for example https://github.com/myorg/service-foo/blob/master/catalog-info.yaml is considered a different location.

Shouldn't the 2nd url be different than the first, e.g:
https://github.com/myorg/service-foo/blob/main/catalog-info.yaml

It looks like having - in the url prevents parseGitUrl from fully parsing the file (ref, filepath and filepathtype are all empty ''). Example:

parseGitUrl('https://github.com/a/b/blob/-/path/to/ref-convention-example.yaml');

// result:
    {
      protocols: [ 'https' ],
      protocol: 'https',
      port: null,
      resource: 'github.com',
      user: '',
      pathname: '/a/b/blob/-/path/to/ref-convention-example.yaml',
      hash: '',
      search: '',
      href: 'https://github.com/a/b/blob/-/path/to/ref-convention-example.yaml',
      query: [Object: null prototype] {},
      token: '',
      toString: [Function (anonymous)],
      source: 'github.com',
      git_suffix: false,
      name: 'blob',
      owner: 'a/b',
      commit: 'path',
      ref: '',
      filepathtype: '',
      filepath: '',
      organization: 'a/b',
      full_name: 'a/b/blob'
    }

@devth good catch, thanks, updated :grin:
And alright thank you for the heads up! Being able to properly parse the URL would be part of implementing this as well then. Can say that we're aiming to move away from git-url-parse though (#9095)

Sounds good! I'll look into the git-url-parse issue later. I could wait till that's resolved, or let me know if there's help wanted on that too.

Hi, I'm simon and i'm looking to find ways to contribute to backstage.
I was looking at this issue, just wondering if your still planning on doing it @devth cos if not, I thought it may be a good first issue for me. I've had a look at some of the github discovery code so i'd be interested to try an help out with this one?
do lmk, Thanks!

Hi @shimmieblum, go for it!

Best of luck @shimmieblum!

Thanks!

Hi, 1) apologies for the delay

Hi, i've submitted a pr for this on my work account: https://github.com/backstage/backstage/pull/11399

@shimmieblum did you get a round to looking at this? Otherwise I can re-assign to someone else if they want to pick it up? :pray:

I work on another change there and getting to what is needed here would be just a minor additional step


Create Binary sorting in java

Hope you will merge this it will give help to open source repositories and me as well thanku

Plzzz add topic hactoberfest in about section according to new update of hactoberfest to give contribution to hactoberfest


installing plugins from directory missing

It should be possible to install plugins existing in directories outside of dita installation directory:
Proposal:
./dita -install /path/to/existing/plugin/directory

Such command should not cause plugin to be copied to the plugin directory, but 'register' it and make it simply available.
Niether neccessity of putting them in to dita-otX.Y.Z/plugins/ directory, nor using intermediate ZIP files for that operation seems to be conventient.

You can already add additional plugins root directories with plugindirs property. Closing as won't fix to avoid feature creep in dita command.


Removed unnecessary word

Removed the word "executes" from "The CPU executes tries to write to 0xdeadbeef, which causes a page fault."

Thanks!


[Ray] Reconstruct worker

What do these changes do?

Add the ClusterAPI.reconstruct_worker API.
Implement ClusterAPI.reconstruct_worker for ray.
New ray actor pool states: INIT, POOL_READY, SERVICE_READY.

Add test_rerun_subtask_describe case.
Log exceptions in monitor_sub_pools instead of stop monitoring silently.
Fix one slot may be assigned more than one subtask when rerun subtask.

Related issue number

Besides all these comments, I'm wondering who is the caller of reconstruct_worker. I don't think it is for the user end as it is not possible to ask an end user to interfere an individual worker in the cluster.

The caller of reconstruct_worker should be a monitor logic in the supervisor. it's an API to operate the cluster worker, so I think it can be placed next to the request_worker and release_worker.


NPM registry via proxy

We are using the plugin within a docker container which requires a proxy to get access to the internet. This results in 404 errors when trying to download NPM assets. Our workaround is to replace the protocoll in the URL within NpmRepository.php with http:// ([similar to this] (http://stackoverflow.com/questions/11773509/npm-behind-a-proxy-fails-with-status-403))
Would it be possible to introduce an option within composer.json to either set the URL or enable/disable SSL for the registries?

This functionality is not related to the plugin, but Composer. I never tested with a Proxy, but I suggest you look at the doc of Composer for Proxy. Hope this can help you.

Thanks for your answer. Adding registry.npmjs.org to the no_proxy variable had the same effect. I'll have to see if this is a viable option for us, but thanks nonetheless!

The plugin simply create VCS Repositories, it connects on the registries of NPM and Bower, but also the URLs (API Github for example) for each repository. I do not know if you need to add them anyway.
After you can force Composer to use the Sources with the option --prefer-source, in this way, Composer will use GIT preferably, if it available.
If you find the solution, made me a feedback. I will include in the doc (or make a PR directly, if you prefer).

We are actually using the plugin with Satis, so we can't use that option. Furthermore using no_proxy could be problematic in the future as our servers require a proxy to communicate with the internet.


Renaming a certain directory causes disk corruption with 2.5.0a3

Renaming a certain directory causes disk corruption with 2.5.0a3

BUG

2.5
Description

This is a bit of strange issue, and I have been having trouble nailing it down completely.  At present I can only make it happen on an HDD partition.  I am trying to reproduce this using GSPort rather than a real physical Apple II, but I can try on real hardware later if needed.
The issue is with renaming a particular directory.  This occurred on an HDD Image renaming the directory VISICALC.ADV, which contains the files copied from the 800k image of Visicalc Advanced found on Asimov
Renaming this directory using BASIC.SYSTEM RENAME trashes the directory so that the BASIC CAT command can no longer list the contents.  Strangely, it still looks OK in Bitsy Bye but any attempt to launch a SYSTEM file in the directory using Bitsy Bye silently fails.
I tried the same steps in ProDOS 2.4.2 without any problems.  This seems to be an issue introduced in 2.5.0.
I also nailed this down to one particular file HELP.TEXT.FILE.  If I create a directory with just that file in it and then rename it in BASIC under 2.5.0a3, the directory is corrupted.
MR.FIXIT.Y2K can fix the damage.  It complains about the directory length I think.
Expected Behavior

Rename shouldn't corrupt the disk!
Actual Behavior

Renaming a directory with this particular file causes corruption.
Possible Fix

Steps to Reproduce

Download the Visicalc Advanced 800k disk image.
On an HDD image, create a directory and copy the files from the floppy there.

Context

Wanted to rename my directory :)
Your Environment

GSPort version v0.31 on Ubuntu 19.04
Hardware:

Emulated Apple II GS with ROM03.
ProDOS8 version:
2.5.0a3
Non-Operating System release software being used:
Visicalc Advanced floppy - don't need to run it, just need the file(s).

I wasn't successful in an attempt to reproduce this on an 800K floppy image, by the way.

I had this happen again today, on a MicroDrive/Turbo volume, and I have some additional snippets of information.  I renamed the directory using the Aztec C64 SHELL.SYSTEM this time, just to mix it up a bit ;)
I did the following cd /h1, then mv prodos.2.5.0a3 prodos.2.5.0a31.  Following that the catalog of the renamed directory seemed to be totally messed up when viewed using the ls command of Aztec C.  The same file appeared for each of the expected entries (ie: I think it was the same number as the actual number of entries in the catalog, but the name was actually the directory name replicated for each entry.)
Quit from Aztec C shell and went and had a look using Bitsy Bye.  Surprise!  The catalog looks fine.  How odd?
Ran MR.FIXIT.Y2K and it fixed the corruption.  The report was: "Entry length fixed" and "Entries/block fixed".
So there is something fishy with renaming directories.

Please see if you can make a repro case for this with 2.5.0a4.
https://drive.google.com/open?id=1DNFFd2BLIXL3krPbGWvfu8E0m9fwZiRP

I have confirmed that this still happens on 2.5.0a4.  I am able to reproduce this on a hard drive partition (32MB partition on MicroDrive/Turbo) but I can't make it happen on a 143K Disk II floppy.
Steps to reproduce using BASIC:
prefix /h1 -- HDD volume
create mydir
create mydir/a
create mydir/b
create mydir/c
cat mydir -- Everything looks fine.
rename mydir,mydir2
cat mydir2 -- Catalog is empty.

Doesn't seem to happen in alpha 5.


Allow localhost loopback is required also for Custom Functions

Hi,
recently we had issues with Custom Functions Runtime (CFR), it was not sending xhr/fetch requests and after some research we found out that actually the root cause is that CFR is UWP app like sandbox (at least that is what we think) and as a result the custom functions is not working on the same machine where actual addin service is hosted. Developer must enable the localhost loopback and it is not mentioned anywhere except this page where it is in context of side-loading in Office Online using edge! Please add more details about this localhost loopback and custom functions in appropriate sections. Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ab35128-1e97-c6ad-babc-f696f2e7b0fe
Version Independent ID: cd1bacb1-14d7-a38d-321c-ebc2a526e03b
Content: Sideload Office Add-ins in Office Online for testing - Office Add-ins
Content Source: docs/testing/sideload-office-add-ins-for-testing.md
Product: non-product-specific
GitHub Login: @o365devx
Microsoft Alias: o365devx

@4tti thanks for providing this feedback; we'll look into incorporating this information into the custom functions docs as you've suggested.
(@mscharlock and @davidchesnut FYI, assigning this to you.)

Hi @4tti - Thanks for the feedback, as @kbrandl mentioned we will integrate this into our custom functions docs. In the meantime, you might want to look at this support article which addresses this problem.

Thanks.

Hi @4tti - our team has included a note about local loopback exceptions into our custom functions docs and it should be up on our site tomorrow. Since the information is the same as the info from the link to the support article, I'm going to close this issue. Happy to reopen if you have other questions though! Thanks.


Add VersionIRI to released ontologies

From<EMAIL_ADDRESS>on September 15, 2011 18:07:28
Algorithm:
For any ontology
<a href="http://purl.obolibrary.org/obo/<ontId>.owl" rel="nofollow">http://purl.obolibrary.org/obo/<ontId>.owl

Generate a versionIRI

<a href="http://purl.obolibrary.org/obo/<ontId>/YYYY-MM-DD/<ontId>.owl" rel="nofollow">http://purl.obolibrary.org/obo/<ontId>/YYYY-MM-DD/<ontId>.owl

For any ontology that does not conform to the obo-foundry recommended URI above, do not add a versionIRI.

If the ontology already comes with a versionIRI, do not override, use the supplied version

See:
http://www.obofoundry.org/id-policy.shtml
Original issue: http://code.google.com/p/owltools/issues/detail?id=13

From<EMAIL_ADDRESS>on September 19, 2011 16:24:22
committed the relevant code for adding file specific versions to owl files.
Also the release manager now tries to read the version information from owl files during the release process.
But there is currently no active code in obo2owl to map the date information into the version.

From<EMAIL_ADDRESS>on September 22, 2011 13:58:22
Issue 10 has been merged into this issue.

From<EMAIL_ADDRESS>on September 22, 2011 14:26:52
Status: Fixed


Remove confusing slide on ADL consequences

Related to: #287

Sounds good to me. Let's drop it. Why id this still draft ?

Sounds good to me. Let's drop it. Why id this still draft ?

I wanted to leave some time before we merge it, so maybe someone who knows why we have the slide could react. But ok, time's up :)


added 2021 ford explorer engine ecu fingerprint

Car
Ford Explorer Limited 2021
Route
Route
Test Route Using Fork
Test Route

@nromsdahl Try switching to master-ci, your car should fingerprint now after https://github.com/commaai/openpilot/pull/31195 was merged


Links are white

let attributes = CMTextAttributes()
attributes.linkAttributes = [
NSForegroundColorAttributeName: UIColor.redColor()
]
Will render white links if the window.tintColor property is set...
Aside from that the code above actually doesn't work at all. Starting to think the external tints colors are causing this issue?
Any solid explanation why?

I am also seeing a similar issue, but my links are always blue, even when setting
        CMTextAttributes *cmAttrs = [[CMTextAttributes alloc] init];
        cmAttrs.linkAttributes = @{NSForegroundColorAttributeName: [UIColor fp_pink]};

@ryang1428 I ended up ditching this library no point. Just load bootstrap CDN into a WKWebView. Way better experience for the user.

@ryang1428 not to mention that the author's don't give a crap to respond.

@adamdahan While I wish I could resolve every issue in a timely manner, I realistically cannot when I have other things to prioritize. I don't have any obligation or incentive to put this ahead of anything else. It's open source for a reason: you can read, extend, and modify the code on your own to suit your purposes rather than waiting on me to fix it for you.
@ryang1428 It looks like this may be an issue with a behavioural change in UIKit, I will investigate soon.

To anyone who still struggles with this issue - try setting NSTextView/UITextView linkTextAttribues to an empty dictionary and set all the needed attributes through CMTextAttributes linkAttributes.
In my case the link always stayed blue. It appears as though the view overrides attributed string's attributes.

@anton-barkov Thanks for the tips! Any idea how to do the same for NSTextField?

@ianbytchek I'm not sure that links will work properly with NSTextField, you should probably consider using NSTextView. See this thread.

@anton-barkov They work perfectly fine. The only issue is they are always displayed in blue while the attributed string specifies a different color.

The conclusion here seems to be that the view being used to render the attributed string seems to override attributes that are set by CocoaMarkdown when generating the attributed string. Since this is a UIKit problem and not an issue with CMAttributedStringRenderer, I am closing this issue.