Add linux-gpu profile to enable GPU support

This is probably the solution of this issue: #62.
I added some deploy resources to allow GPU access of service llm-gpu. For now, I have created a new profile linux-gpu associated with llm-gpu service as if there is no GPU, the stack can't start.

Nice! I can't test this myself so pinging @slimslenderslacks and @mchiang0610 to have a look.

Not working on Ubuntu 22.04
(base) midea@G4:~/genai-stack$ docker compose --profile linux-gpu up
WARN[0000] The "OPENAI_API_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_PROJECT" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_API_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_ACCESS_KEY_ID" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_SECRET_ACCESS_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_DEFAULT_REGION" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_PROJECT" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_API_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_ACCESS_KEY_ID" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_SECRET_ACCESS_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_DEFAULT_REGION" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_PROJECT" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_API_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_ACCESS_KEY_ID" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_SECRET_ACCESS_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_DEFAULT_REGION" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_PROJECT" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_API_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_ACCESS_KEY_ID" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_SECRET_ACCESS_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_DEFAULT_REGION" variable is not set. Defaulting to a blank string.
[+] Running 7/7
 ✔ Container genai-stack-database-1    Running                                                                                0.0s
 ✔ Container genai-stack-pull-model-1  Recreated                                                                                0.1s
 ✔ Container genai-stack-bot-1         Recreated                                                                                0.6s
 ✔ Container genai-stack-loader-1      Recreated                                                                                1.0s
 ✔ Container genai-stack-api-1         Recreated                                                                                1.2s
 ✔ Container genai-stack-pdf_bot-1     Recreated                                                                                0.8s
 ✔ Container genai-stack-front-end-1   Recreated                                                                                10.4s
Attaching to genai-stack-api-1, genai-stack-bot-1, genai-stack-database-1, genai-stack-front-end-1, genai-stack-llm-gpu-1, genai-stack-loader-1, genai-stack-pdf_bot-1, genai-stack-pull-model-1
Error response from daemon: could not select device driver "nvidia" with capabilities: [[gpu]]

GPU and cuda
(base) midea@G4:~/genai-stack$ nvidia-smi
Tue Nov  7 15:01:19 2023
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.113.01             Driver Version: 535.113.01   CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  Quadro P620                    Off | 00000000:01:00.0  On |                  N/A |
| 41%   55C    P0              N/A /  N/A |    392MiB /  2048MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A      2002      G   /usr/lib/xorg/Xorg                          116MiB |
|    0   N/A  N/A      2142      G   /usr/bin/gnome-shell                        100MiB |
|    0   N/A  N/A   1462607      G   ...irefox/3290/usr/lib/firefox/firefox      146MiB |
|    0   N/A  N/A   1464832      G   gnome-control-center                          1MiB |
+---------------------------------------------------------------------------------------+

To use GPU capabilities inside Docker, you need to have the nvidia-container-toolkit package installed on your machine: https://docs.docker.com/config/containers/resource_constraints/#gpu
I forgot to add it in the readme.md, adding "ensure that you have nvidia-container-toolkit package installed" would do it.

I have installed nvidia-container-toolkit, still cannot select.
(base) midea@G4:~/genai-stack$ which nvidia-container-runtime-hook
/usr/bin/nvidia-container-runtime-hook
(base) midea@G4:~/genai-stack$ docker compose --profile linux-gpu up
WARN[0000] The "LANGCHAIN_PROJECT" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_API_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_ACCESS_KEY_ID" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_SECRET_ACCESS_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_DEFAULT_REGION" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_PROJECT" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_API_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_ACCESS_KEY_ID" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_SECRET_ACCESS_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_DEFAULT_REGION" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_PROJECT" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_API_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_ACCESS_KEY_ID" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_SECRET_ACCESS_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_DEFAULT_REGION" variable is not set. Defaulting to a blank string.
WARN[0000] The "OPENAI_API_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_PROJECT" variable is not set. Defaulting to a blank string.
WARN[0000] The "LANGCHAIN_API_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_ACCESS_KEY_ID" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_SECRET_ACCESS_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "AWS_DEFAULT_REGION" variable is not set. Defaulting to a blank string.
[+] Running 2/0
 ✔ Container genai-stack-pull-model-1  Created                                                                                0.0s
 ✔ Container genai-stack-database-1    Running                                                                                0.0s
Attaching to genai-stack-api-1, genai-stack-bot-1, genai-stack-database-1, genai-stack-front-end-1, genai-stack-llm-gpu-1, genai-stack-loader-1, genai-stack-pdf_bot-1, genai-stack-pull-model-1
Error response from daemon: could not select device driver "nvidia" with capabilities: [[gpu]]

Does this command return the nvidia-smi output sucessfully?
docker run -it --rm --gpus all ubuntu nvidia-smi

Does this command return the nvidia-smi output sucessfully?
docker run -it --rm --gpus all ubuntu nvidia-smi

Thanks, worked after systemctl restart docker

Returning 200 with no answer

From the results of nvidia-smi on your computer: 392MiB /  2048MiB, I suppose that you don't have enough room for the model to be loaded on the GPU. Thus, the answer will be quite slow.
I don't see where the bot service is outputting a 200 answer, don't confuse the api health check output with the output of bot.
My guess is that if you wait long enough, you will have a result.


Applications are not displayed in Manage Subscriptions section of API

Description:
Application names are empty in the Manage Subscriptions section of the API

Steps to reproduce:

Create an API in Publisher and publish
Go to Dev portal and create an application and subscribe the API
Go to Publisher and click on the API created
Go to the Subscription page.

Why have we put these info icons under subscriber? Can we put the subscriber name instead?

Affected Product Version:
v4.0.0-alpha
Environment details (with versions):

OS: Windows server 2019
Browser : Chrome 88.0.4324.190 (Official Build) (64-bit)

First issue is not reproducible for me.

For the latter one, +1 add the name of the subscriber along with the Info icon. Info Icon shows additional details of the user profile.

@malinthaprasan FYI I have executed this test in Windows. Maybe that's why this wasn’t reproducible

First issue is not reproducible for me.
It's already fixed :)

https://github.com/wso2/product-apim/issues/10049

For the latter one, +1 add the name of the subscriber along with the Info icon. Info Icon shows additional details of the user profile.

The first issue already fixed :) . Let's keep this open until fixing the latter part.


Issues on write characteristics request in android

Issues on write characteristics request in android. Writing around 800 bytes of data but data received on sever side (1st ATT 511 bytes and 2nd ATT 97) which is partial (2nd chunk ATT) in android and after that it was disconnected.
In iOS case it has received complete data and also has processed the data. (tested withAndroid 9)
We tested with combination of MTU sizes and chunks of data but it did not work. As MTU max size is 512 for iOS and Android, we have configured for the same size (512).
Following are the code :
//RequestMtuAsync
RequestMtuAsync(512);
========
//write type default
characteristic.WriteType = Plugin.BLE.Abstractions.CharacteristicWriteType.Default;
//writing characteristics
Device.BeginInvokeOnMainThread(async () =>
await characteristic.WriteAsync(Encoding.ASCII.GetBytes(RequestParameterJSON));
);

Hi @nileshsulbhewar,
I'm the friendly issue checker.
It seems like (100.00 %) you haven't used our issue template :cry: I think it is very frustrating for the repository owners, if you ignore them.
If you think it's fine to make an exception, just ignore this message.
But if you think it was a mistake to delete the template, please close the issue and create a new one.
Thanks!


fix: broken IS NULL and IS NOT NULL operator

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
#9556 introduced a regression in the SQLA model which broke the IS NULL and IS NOT NULL operators.
TEST PLAN
Tested locally
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

Codecov Report

Merging #9613 into master will increase coverage by 4.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9613      +/-   ##
==========================================
+ Coverage   65.65%   70.34%   +4.68%
==========================================
  Files         574      182     -392
  Lines       30131    17681   -12450
  Branches     3066        0    -3066
==========================================
- Hits        19782    12437    -7345
+ Misses      10165     5244    -4921
+ Partials      184        0     -184

Flag
Coverage Δ

#javascript
?

#python
70.34% <100.00%> (-0.17%)
:arrow_down:

Impacted Files
Coverage Δ

superset/connectors/sqla/models.py
88.37% <100.00%> (+2.29%)
:arrow_up:

superset/views/database/mixins.py
58.92% <0.00%> (-21.43%)
:arrow_down:

superset/utils/cache.py
45.83% <0.00%> (-20.84%)
:arrow_down:

superset/db_engine_specs/postgres.py
80.00% <0.00%> (-15.00%)
:arrow_down:

superset/db_engine_specs/mysql.py
78.26% <0.00%> (-13.05%)
:arrow_down:

superset/views/database/api.py
83.90% <0.00%> (-3.45%)
:arrow_down:

superset/models/core.py
84.47% <0.00%> (-2.39%)
:arrow_down:

superset/security/manager.py
88.77% <0.00%> (-0.35%)
:arrow_down:

superset/views/core.py
75.01% <0.00%> (-0.23%)
:arrow_down:

...src/explore/components/controls/SpatialControl.jsx

... and 392 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcbffed...dc1279f. Read the comment docs.


Checkbox issue on auth page

- after the click to checkbox on auth page, we have an error page.
You can check it here:

https://enterprise.awes.io/login

➤ Ilya Kitayev commented:
fixed in form-builder v1.6.6


Request for assistance

Thanks very much for this package
It seems that the hotX and hotY do not work when creating an asset from a PNG image. Is this correct or is there a way around this?
Many Thanks
Garth Waters

I was not aware of a problem with hotX,Y and PNG images.   Could you provide more details about the platform, etc and how/why you are seeing this ?

The example for the web platform at
https://timmaffett.github.io/custom_mouse_cursor/#/
has a variety of different PNG w/HotX/Y settings examples.  Click on any colored row and then you can test the cursor at the bottom of the page, long with the hotspot.   (You can see where the line draws from the hotspot)
This is the example from the package source.

Thanks for the response.
I solved it by creating an svg file and used the icon feature to create the mouse cursor

Thats good Garth, can I ask what platform you were using when you saw the PNG problem ?
I would still like to fix the bug...

@garth-waters  I am going to close this issue as there is nothing else I can do without the PNG file in question,


Replace travis with github actions; optimize Yaml.embed

Changes

replace travis with github actions.

Taking into account recent issue with installing crystal on travis runners github actions is much more flexible and reliable option

remove nested macro evaluation for I18n::Backend::Yaml.embed and add simple test
fix unnecessary adding already existing locale in src/i18n/backend/i18n_embed.cr

We can do it. Also in this case we should drop support for crystal versions before 0.35.0 (currently we have >= 0.29.0)


i18n.js getLocalizedBio(bio) can receive undefined from screens/Player.js

https://github.com/Chattahooligans/hooligan-hymnal-app/blob/2fbedb0b2ef2dfcde95d58d161909e7f50a5e2f5/src/screens/Player.js#L286
App was crashing out when bio was undefined or null.  Validating the attribute is present on the player object, and adding an empty string if it's missing prevents this.

I have a commit with the fix for this in it already, but I need to get permission to publish before I can make a PR for review.


Create initial CV node for gate task

Create a CV node with camera or video file input that outputs the pixel locations of the center of the gate at each frame. Have input of configurable frame rate and an enum or string denoting which target to look for

Completed.


Compatibility with d3-selection

d3 has moved to a modular setup,, but use of d3-selection isn't compatible with venn.js, so this is requesting it be updated to work.

Issue was that event was removed/replaced and after accounting for that, things are working again

Issue was that event was removed/replaced and after accounting for that, things are working again


Recommended changes resulting from automated audit

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.
We encourage you to make the following modifications:

[ ] You are currently referencing Cake.Core 0.26.0. Please upgrade to 0.28.0
[ ] The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />
[ ] Your addin should target netstandard2.0. Please note that there is no need to multi-target, netstandard2.0 is sufficient.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.

Resolved in v0.4.1


111 Fiat price sometimes changes shortly after the dialog is up

https://github.com/PayButton/paybutton/issues/111

possibly addresses https://github.com/PayButton/paybutton/issues/105 as well.


Docker inside?

I have to say (again), this is fantastic. I would love to use this as my primary CI/CD.
The only challenge is that I have containers everywhere. Because I want dev/staging/prod parity, I do all of my builds and tests inside docker.  And, yes, I saw the ECS integration. But still would be really great.

@deitch if it's a limitation of Lambda, it's a limitation of LambCI – the ECS integration is exactly what you want here

it's a limitation of Lambda, it's a limitation of LambCI

Yeah, I know. I was kind of hoping it would lead to some cool new way to make it happen. I guess not. Lambda just isn't built for that, is it?


paper.csv is too large to save in my computer

When I tried to run the pipeline, paper.csv was generated from Miner-Papertxt (about 2.2G). And the paper.csv file was too large (exceeded 1.7T) but my computer has only about 2T storage space. So it failed each time I run the project. Do you know how to fix this?

I'm surprised it's so big. I didn't catalog file sizes, but I don't remember anything being even close to 1T in size. IIRC, I was able to store everything on a machine with only 500G. It's been a while though, so I may be misremembering.
You could try modifying the code that writes the file to compress it first. I think pandas supports writing in compressed formats via extra kwargs.


Expandable table does not show expand/collapse icon with latest version (9.1.0).

I updated to the latest version from 8.0.0 and all of a sudden the collapsable/expandable icon has disappeared.
I have reverted.
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
Collapsable/Expandable icon not shown.
Expected behavior
Collapsable/Expandable icon displayed.
Reproduction of the problem
Just load the table.
Please tell us about your environment:
Angular 4, Firefox/Chrome/IE broswers.

Table version: 9.1.0

Angular version: 4.0.x

Browser: [Chrome XX | Firefox XX | IE XX ]

Language: [all | TypeScript X.X | ES6/7 | ES5]

css class names were changed in the latest release. You probably need to prefix the expand/collapse css classes with "datatable-"

Fixed 👍

Hi can you provide example code....I used latest version in which names are already prefixed by "datatable-" but still icons are not shown.
I really want to use this data table but due to these issues, I am not able to use it.
Please help.


Add a command to open an app in the browser

Is your feature request related to a problem? Please describe.
Opening an app URL in the browser requires clicking or copy/pasting a link.
Describe the solution you'd like
It'd be great if I could open an app in the browser directly from the terminal using a ddev command like ddev launch [appname] or ddev browse [appname], launching the current active app if no name is provided.
Additional context
Most (all?) operating systems provide a utility that can be provided a URL (and more), determine the user's default browser, and launch the page.  For example:

darwin: open http://wikipedia.org
linux: xdg-open http://wikipedia.org
windows: start http://wikipedia.org

A prototype of this functionality using ddev launch can be experimented with here.

Somewhat related to #375.

Maybe have a list of choices?
ddev launch
OR ddev launch --browser=firefox

1. http://example.com/
2. https://example.com/
3. http://<IP_ADDRESS>/
4. http://<IP_ADDRESS>/

$Enter the URL you want to launch [1]: 2
Launching https://example.com/

I was just thinking about how this would be a great command to have. I often find myself doing the following:

ddev describe
Crtl-click on the URL, then click "Open Url" (on Mac OS X)

I think it would be pretty great to just be able to do something like ddev launch that opens the default URL (https) in the user's default browser. @jigarius's idea of using switches to change URL and/or browser is a nice addition, but for me, simple and clean work best.
-mike

This is such a simple custom command. Time to just add it in that way.


Lookup not working on win client- link to issue #1601 (Closed)

Issue #1601 is closed but not fixed.
Lookup is showing in web client but not in windows.
I have tried to put lookup on page and on table trigger i get the same result.
Code:

Web client:

Windows:

My bad it is working, windows client lets you lookup even if page is not editable and web does not.
Thing is that you can put cursor in lookupfield and it looks like it is editable, but you cannot write.


Error getting SSID iOS 13.1 on Release Build

Hi
getting this below error in Release Build on Debug its working fine.
Check-WiFI[742:190311] [] nehelper sent invalid result code [1] for Wi-Fi information request

iOS 13.1 beta 4 working here.
Please provide more details on how to reproduce it.


Fix/expressive modal role wc

Related Ticket(s)
#4742
Description
Adds the dialog role to the expressive-modal web component which will allow screen readers to announce the modal properly.
Changelog
New

dialog role added to dds-expressive-modal

Closing, resolved in #4392


Rewrite branch logic to allow base branches other than master

As a consequence of how it now works, it can no longer be run on non-pull_request events.
Fixes #2.

ping @13rac1

ping @13rac1

Sorry it took a whole year to reply 😳

@jplatte Can you update the commit message to answer "why?" to "As a consequence of how it now works, it can no longer be run on non-pull_request events."

Is this better?

Is this better?

Yes! Thank you :D

Yes! Thank you :D

@13rac1 Mind publishing a new version?

@13rac1 Mind publishing a new version?


feat: skip exporting data into subdirectories

Linux distributions have a large number of releases and products. Exporting each release into a subdirectory wastes a lot of memory and reduces exporter performance. Skipping the exporting of these subdirectories and keeping one directory for each ecosystem will improve exporter performance.
This PR will be merged after the weekly release, and performance will be tested on the test instance. If all looks good, an announcement email will be sent before moving this into production.

LGTM, can you also update the documentation of our exports?

I will test the performance on a test instance first and update it in a follow-up PR after verifying the results.


[BUG] Error signing jar:  Error in signer materials using KeyVaultJcaProvider

Describe the bug
I have an issue using signing jars with the com.azure.security.keyvault.jca.KeyVaultJcaProvider provider using a certificate with a non-exportable key
Exception or Stack Trace
Using the jarsigner cli tool I get the following error
jarsigner: unable to sign jar: java.security.InvalidKeyException: No installed provider supports this key: com.azure.security.keyvault.jca.implementation.KeyVaultPrivateKey

From the coded solution
Error signing jar: Error in signer materials
java.lang.RuntimeException: jdk.security.jarsigner.JarSignerException: Error in signer materials
	at uk.arqit.support.service.SignerService.signJar(SignerService.kt:28)
	at uk.arqit.support.SignerCommand.run(SignerCommand.kt:25)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at io.micronaut.configuration.picocli.PicocliRunner.run(PicocliRunner.java:137)
	at io.micronaut.configuration.picocli.PicocliRunner.run(PicocliRunner.java:114)
	at uk.arqit.support.SignerCommand$Companion.main(SignerCommand.kt:30)
	at uk.arqit.support.SignerCommand.main(SignerCommand.kt)
Caused by: jdk.security.jarsigner.JarSignerException: Error in signer materials
	at jdk.jartool/jdk.security.jarsigner.JarSigner.sign(JarSigner.java:564)
	at uk.arqit.support.service.SignerService.signJar(SignerService.kt:25)
	... 13 more
Caused by: java.security.InvalidKeyException: No installed provider supports this key: com.azure.security.keyvault.jca.implementation.KeyVaultPrivateKey
	at java.base/java.security.Signature$Delegate.chooseProvider(Signature.java:1303)
	at java.base/java.security.Signature$Delegate.engineInitSign(Signature.java:1388)
	at java.base/java.security.Signature.initSign(Signature.java:684)
	at java.base/java.security.Signature$1.initSign(Signature.java:147)
	at java.base/sun.security.util.SignatureUtil.initSignWithParam(SignatureUtil.java:189)
	at java.base/sun.security.util.SignatureUtil.autoInitInternal(SignatureUtil.java:372)
	at java.base/sun.security.util.SignatureUtil.fromKey(SignatureUtil.java:364)
	at java.base/sun.security.pkcs.PKCS7.generateNewSignedData(PKCS7.java:750)
	at jdk.jartool/jdk.security.jarsigner.JarSigner.sign0(JarSigner.java:848)
	at jdk.jartool/jdk.security.jarsigner.JarSigner.sign(JarSigner.java:554)
	... 14 more

To Reproduce
Following the steps documented in https://github.com/backwind1233/AzureDocs/blob/main/AzureJavaSDK/JCA/integrate_keyvault_JCA_provider_with_jarsigner.md
jarsigner -verbose -J-Djava.security.debug=jar \
-keystore NONE \
-storetype AzureKeyVault \
-signedjar appsigned.jar app.jar "redacted" \
-storepass ' ' \
-sigalg SHA256withRSA \
-tsa http://timestamp.entrust.net/rfc3161ts2 \
-providerName AzureKeyVault \
-providerClass com.azure.security.keyvault.jca.KeyVaultJcaProvider \
-J--module-path="/home/grant/projects/cosign/azure-security-keyvault-jca-2.8.1.jar" \
-J--add-modules="com.azure.security.keyvault.jca" \
-J-Dazure.keyvault.uri=redacted \
-J-Dazure.keyvault.tenant-id=redacted \
-J-Dazure.keyvault.client-id=redacted \
-J-Dazure.keyvault.client-secret=redacted

I'm using the SHA256withRSA signature algorithm
See the same issue in JDK 17 and 21
I see the same error with the coded solution (snippet below).
Debugging this code, it would appear that the KeyVaultPrivateKey is not a supported key type. The method supportsKeyClass inside the java.security.Provider module of the JDK expects keys to implement one of the following interfaces
interface java.security.interfaces.RSAPrivateKey
interface java.security.interfaces.RSAPublicKey
Code Snippet
Test code
@Singleton
class SignerService(private val keyVaultClient: KeyVaultClient) : ISignerService {
    override fun signJar(alias: String, inputFilePath: String, outputFilePath: String) {
        val privateKey = keyVaultClient.getKey(alias, null)
        val certificate = keyVaultClient.getCertificate(alias)

        val jarSigner = JarSigner.Builder(KeyStore.PrivateKeyEntry(privateKey as PrivateKey, arrayOf(certificate)))
            .digestAlgorithm("SHA-256")
            .signatureAlgorithm("SHA256withRSA")
            .build()

        try {
            val inZip = ZipFile(inputFilePath)
            val outputStream = FileOutputStream(outputFilePath)
            jarSigner.sign(inZip, outputStream)
        } catch(e: Throwable) {
            println("Error signing jar: ${e.message}")
            throw RuntimeException(e)
        }
    }
}

Expected behavior
I would expect KeyValutPrivateKey to be recognised as a valid key class and for signing inside the key vault to be actioned.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: Ubuntu 22.04 (WSL)
IDE: Intellij / bash console
Library/Libraries: com.azure:azure-security-keyvault-jca:2.8.1
Java version: Tested with 17 and 21
App Server/Environment: N/A
Frameworks: Micronaut in test code

Additional context
N/A
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

In addition, the keytype I am testing with in the vault is RSA-HSM. Have re-run CLI and code solution tests again with RSASSA-PSS sign algorithm as per README.md, but am seeing the same outcome.

Hi,
We ran into the same problem today. Will this be fixed in the near future?
Thanks!

Sorry for the late response.
I use the following code and it sign successfully:
        KeyVaultJcaProvider provider = new KeyVaultJcaProvider();
        Security.addProvider(provider);
        String alias = "signer240727";
        PrivateKey privateKey = (PrivateKey) keyVaultClient.getKey(alias, null);
        Certificate certificate = keyVaultClient.getCertificate(alias);

        JarSigner jarSigner = new JarSigner.Builder(new KeyStore.PrivateKeyEntry(privateKey, new Certificate[]{certificate}))
            .digestAlgorithm("SHA-256")
            .signatureAlgorithm("SHA256withRSA")
            .build();

        ZipFile inZip = new ZipFile("C:\\Users\\rujche\\Work\\problem-investigation\\jca\\unsigned.jar");
        OutputStream outputStream = new FileOutputStream("C:\\Users\\rujche\\Work\\problem-investigation\\jca\\signedJar.jar");
        jarSigner.sign(inZip, outputStream);

With out the following 2 lines, I faced this error: No installed provider supports this key: com.azure.security.keyvault.jca.implementation.KeyVaultPrivateKey.
KeyVaultJcaProvider provider = new KeyVaultJcaProvider();
Security.addProvider(provider);

Hi @rujche,
I am still running into the same Problem. We have an Azure Key Vault with an older certificate + key pair which works completely fine. A few weeks ago we got a new, keyless certificate. This one still works with the AzuerSignTool but not anymore with the jarsigner.
I am using this command: jarsigner -keystore NONE -storetype AzureKeyVault \  -signedjar C:\Users\generic\Desktop\testjar_after.jar C:\Users\generic\Desktop\testjar.jar "REDACTED" \  -verbose -J-Djava.security.debug=jar \  -storepass "" -sigalg SHA256withRSA \  -providerName AzureKeyVault \  -providerClass com.azure.security.keyvault.jca.KeyVaultJcaProvider \  -tsa http://timestamp.globalsign.com/tsa/r6advanced1 \  -J--module-path="C:\utl\java\azure-security-keyvault-jca-2.8.1.jar" \  -J--add-modules="com.azure.security.keyvault.jca" \  -J-Dazure.keyvault.uri=REDACTED \  -J-Dazure.keyvault.tenant-id=REDACTED \  -J-Dazure.keyvault.client-id=REDACTED \  -J-Dazure.keyvault.client-secret=REDACTED
Which yields: jarsigner: unable to sign jar: java.security.InvalidKeyException: No installed provider supports this key: com.azure.security.keyvault.jca.implementation.KeyVaultPrivateKey
Any advice would be greatly appreciated.

As show above, this is a bug which will be fixed by this commit in https://github.com/Azure/azure-sdk-for-java/pull/41303

Hi, @rujche Thanks so much!

Any ETA on merging this?
jarsigner is unable to sign anything with non-exportable keys without this fix
Thanks,


After fine-tuning the original model with other languages, I can no longer speak Chinese and English properly when reasoning in both languages. However, my newly tuned language is becoming more and more similar. I want to keep both Chinese and English with my newly added language. Did I do something wrong?

Checks

[X] This template is only for question, not feature requests or bug reports.
[X] I have thoroughly reviewed the project documentation and read the related paper(s).
[X] I have searched for existing issues, including closed ones, no similar questions.
[X] I confirm that I am using English to submit this report in order to facilitate communication.

Question details
After fine-tuning the original model with other languages, I can no longer speak Chinese and English properly when reasoning in both languages. However, my newly tuned language is becoming more and more similar. I want to keep both Chinese and English with my newly added language. Did I do something wrong?
BTW The audio I used is 16000Hz, and the tokenizer I selected is custom. I don't know if this has any impact.

@0x1001u You could keep some English and Chinese data while finetuning, do such a mixed training would help mitigate catastrophic forgetting problem

will close this issue, feel free to open if further questions~


Catch Exceptions in ParseResult.fromParser, and fix Content-Type so it doesn't throw

Fixes an issue found in https://github.com/http4s/http4s/pull/4787#issuecomment-846633626.

+1 for finding and fixing the urgent bug, but a couple improvements that I'm happy to take on in a follow-up.

:+1: I'm out of time for the day, and it'll be a couple days before I find time again, FYI.

No problem.  Appreciate the efforts today.  I'll either clean this up, or we can clean it up after the fact.  I think we got enough already to support an RC that can support Rho.


Publish the types on JSR

We sould also publish the types on JSR, a new NPM registry build from the creators of Deno.
Reasons:

This registry is runtime-independent and all runtimes are allowed, including GJS
TypeScript first
JSR handles generating API docs, would be great to get a good GJS API documentation very easily
ESM only

This could be a problem for us: About "slow types"


added dragBackFirst and ScrollComplete callbacks

added dragBackFirst support: a callback for implementing logic upon dragging back the first item (for example, scroll to refresh)
added scrollComplete(int) support: a callback for getting the current selected card upon scrolling (to implement card item specific logic).

Good stuff. I'm just going through the PR now and adding additional documentation, etc. I have a question for you though: How did you pass in a callback? My linter is not liking the typedef:
The argument type 'void Function(ScrollEventType, {int index})' can't be assigned to the parameter type 'void Function(ScrollEventType, {int currentIndex})?'.
My example project has been changed to add the following:
...

        onScrollEvent: _handleCallbackEvent,
        builder: (BuildContext context, int index) {
          return Container(
            color: colors[index],
            child: Center(
              child: Text(
                '$index',
                key: Key('$index-text'),
                style: const TextStyle(fontSize: 48, color: Colors.white),
              ),
            ),
          );
        },
      ),
    );
  }

  void _handleCallbackEvent(ScrollEventType type, {required int index}) {
    print("Scroll callback received with data: type: $type, and index: $index");
  }
...

I can't get past this no matter what I try.

Not to worry. It was simpler than I thought - the named parameter in the callback I provided didn't match.


DNXCore support?

Dear Team,
Just trying to nuget SharpZipLib.Portable into my PCL (targeting UWP, NET46, and ASP.NET Core 1.0), then I got error msg like this:
SharpZipLib.Portable <IP_ADDRESS> is not compatible with DNXCore,Version=v5.0.
Some packages are not compatible with DNXCore,Version=v5.0.
SharpZipLib.Portable <IP_ADDRESS> is not compatible with DNXCore,Version=v5.0 (win7-x86).
Some packages are not compatible with DNXCore,Version=v5.0 (win7-x86).
SharpZipLib.Portable <IP_ADDRESS> is not compatible with DNXCore,Version=v5.0 (win7-x64).
Some packages are not compatible with DNXCore,Version=v5.0 (win7-x64).

Any plan to extend the support?

Dong,
The package you are using is currently a fork of SharpZipLib by @ygrenier at https://github.com/ygrenier/SharpZipLib.Portable
At the moment I am focused more on cleaning up the existing code and bug fixing, rather than adding new features. Hopefully soon, we can take a look at incorporating those features into our project.
-Neil

Thanks for clarify that. And I'll take the chance here to edit a bit my request: once you finish the spring clean, it will be great to able to support coreclr/corefx (or the new name they call it: netstandard). :)

I too would like to add a vote for netstandard support, are there any plans for adding support for it?

+1 for netstandard support.
@xied75 rename issue please (there is no more dnx, dotnet and netstandard are released)

Shall I propose a mini hackathon to get this going? I'm sure Neil is pretty much occupied by his work, if nobody volunteers then this would never happen.

@xied75
Would it make more sense to integrate the SharpZipLib.Portable fork into the main repository first, or would you rather start from the main repository first?
-Neil

@McNeight Thanks for asking.
From my understanding, Yan Grenier @ygrenier mentioned in his fork Readme, that he did "remove" a bunch of things from base when he did his port. My feeling is that to merge these back wouldn't be a simple task and also it serves no purpose anymore, since his port is not netstandard ready as well. Unless we are thinking about very rare legacy requirements, having the main stream to retro support the port seems unnecessary. (I could be wrong)
Now talking about the main repo and netstandard, what I gathered is that Microsoft think given native zlib is everywhere where dotnet will be, the related classes in corefx will only wrap around calling zlib. They also mentioned in the past they have a pure managed implementation to fall back on where zlib is absent, I'm not sure where that part of source code is.
So in my opinion SharpZipLib can target to be the best performing Pure Managed Implementation, without touching native zlib at all, and leave that to corefx.
Going forward I would like to see:
1, we can remove anything Java (legacy code, idiom, weird stuff)
2, we can continue to improve performance
3, we can utilize new features in dotnet (e.g. System.Buffers to avoid alloc very often, etc.)

+1 netstandard support would be fantastic

+1 dotnet core

The .NET Core team is currently looking into popular repositories which have potential for netstandard targeting. I forked the repository and migrated to netstandard1.3. There were a few lines of code that are wrapped around and #if net45 statement but I didn't really saw its usage anywhere? The migration went flawlessly, did I miss something or is the entire code already netstandard ready?
If support for net45 is critical than multi targeting would be an option. In that case assemblies for netstandard1.3 and net45 would be created. If support for net45 isn't that necessary than I would recommend to only target netstandard1.3, as net46 and above is supported in that case. More on that here: https://blogs.msdn.microsoft.com/dotnet/2016/09/26/introducing-net-standard/
The test library is currently written in net45 and could be converted to net46 or to netcore2.0. The advantage of netcore2.0 would be, that the entire solution could be cross plattform. netcore1.1 isn't possible as BinarySerializer isn't supported < netcore2.0. The only problem with that is that nunit CURRENTLY does not support netcore. See here: nunit/dotnet-test-nunit#91.
@McNeight how should be proceed? You might want to contact me per mail, so that we can fasten up communication

@ViktorHofer When you say

looking into popular repositories which have potential for netstandard targeting

you meant help to get the repo work under netstandard is that right?
Something else you might also be able to offer help on? This repo is in the middle of switching license to MIT, https://github.com/icsharpcode/SharpZipLib/issues/103, from what I see there, it's not complete 100%, suppose those people who contributed 1 line never turn up, how should this proceed legal-wise? Surely one line of code shouldn't tie the whole thing to GPL forever? You probably have access to legal people on this which we all lack.
nunit people is still in the middle to get runner work for netstandard, with all duly respect, I think switching to xunit is much easier than workaround, I can try to PR on this if you guys agree.
@McNeight here too with all respect, with some borrowed courage, I felt that this project probably can set up a Tech committee and involve more people with merge rights (as the Apache model goes, e.g. jgit, or maven), so that the wheel can turn a bit faster?

@xied75 regarding nunit: I would have also made the suggestion switching from nunit to xunit as it is used by huge repositories like corefx and coreclr but as their are a LOT tests written in nunit I thought the migration would take to much effort. Still if you would take the time for that I would definitely be happy. But who am I to decide? ;)
regarding your licensing concerns, maybe @danmosemsft can help?

@xied75 design by committee sounds like a bad idea. But more maintainers: yes. That's what we definitely want once the redesign is done (relicensing I think is complete @McNeight).

.NET Core 2.0 added the support for referencing .NET Framework libraries and NuGet packages.
I try to reference v0.86 to .netcoreapp2.0 project.    Creating and unpacking zip works well.
It just needs to add a line of code
ZipConstants.DefaultCodePage = Encoding.UTF8.CodePage;

netstandard1.3 is now officially supported

What version of the library do we need to run on .NET Core 3?
thanks - dave

The .NET Standard 2.0 build should work, so 1.0 or newer I think.


Bower Code does not match master branch.

I was testing lodash 3.3.1 against backbone.stickit from bower and found that it broke. There are _.rest functions used in the bower package code that were replaced in the master branch. Please update bower package. Thank you.
Update: Just noticed that the last release is a tag but there hasn't been any activity in this project. Is there going to be an update at any time?
Thanks for reading.

Sure, we haven't cut a release in quite a while. Send me a reminder here next week and we'll make sure to do it.
(sent from my phone)

You got it. Thanks for the response.

Bumped. Give that a try and let me know if it breaks anything for you.

It looks like, for my use, it is in the clear. Thank you for the update. I greatly appreciate it.


Routing miscalculates the ShortestPath when one border has zero length

Dear FZI,
I have cases where a lanelet is a junction lane. Say we are turning right at a junction. Right border is just one point (or a line with two equal points), while left border is a curve. In those cases the lanelet2.routing.RoutingGraph.shortestPath() does not take that lane into account, and calculates the path passing by other roads.

This case is very frequent (for junctions or corner roads). Can this be fixed ?

I think you can workaround this problem by adjusting the border to a very small line:

yea that's what I have done. I just ask them if it should be an issue or not

Hm, that looks like a bug. I'll try to find the time to look into it this week. Thanks for reporting!

This is probably due to miscalculation of the orientation of boundaries.
You cannot calculate signed distance against a point(linestring with length 0).
https://github.com/fzi-forschungszentrum-informatik/Lanelet2/blob/46fd46ca2bbb755bf1f2e8ea21994fdae89c93d7/lanelet2_core/include/lanelet2_core/geometry/impl/LineString.h#L747

That shouldn't be the reason. This function checks which of the two linestrings of the lanelet has nonzero length and uses that for the signed distance calculation to the other boundary. There is even a unittest that covers this case. This kind of problem should also be visible in the debug routing graph.
But you are right in that it is most probably related to the problem that it is hard to determine neighborhood relationships for linestrings with zero length. Its not impossible, but hard to get right.

@poggenhans

This function checks which of the two linestrings of the lanelet has nonzero length and uses that for the signed distance calculation to the other boundary.

Are you referring to this line?
  if (!rightOfLeft && left.size() > 1) {
    left = left.invert();
  }

What it is checking is the size of the linestring, not the length.
If the boundary has multiple points with the same location, then this error could happen.

I see. Linestrings that have duplicated points are not allowed in general. There are too many algorithms (also in boost::geometry) that rely on this. We should update or docs to reflect that. Linestings that have one single point are allowed however.

@amastrobera can you confirm that this problem is solved by using a single-point-linestring?
I tried to reproduce your issue and with my test cases everything worked fine with them.

@poggenhans yes I tried it just now. LineString3d of 1 point for border makes the path planning work.

Ok, thanks for checking. We have updated the doc and added a new validator to lanelet2_validation for this case.

How do you generate a "single-node"-way in josm?

Afaik, its not possible directly within JOSM. If you remove the second-last node from a way, the way will be deleted as well. But at least JOSM will not remove existing single node ways from loaded OSM files.
To create one, you would have to create it directly within lanelet2 or modify the osm file by hand.


Feature: Energy Usage of Journey

Hello.
I have been using this addon for a week and it's great. It shows lots of parameters of the car 👍
I would like to request a sensor which could provide the energy used in the journey. There are already sensors with the Energy Usage of the Day and Energy Usage since Last Charge, Mileage of Journey, but not the Energy Used of Journey.
Please, if it possible, provide it.
Thanks!

Unfortuntaly those are not stored by the API so we cannot implement directly.
It is also tricky to compute those from e.g. the step integral function of the power (W) used by the car due to the poor temporal resolution of the data.


ARROW-8058: [Dataset] Relax DatasetFactory discovery validation

This PR aims to improve the latency of the discovery process. Notably, it selects "fast" defaults over "safe" defaults.

Add InspectOptions which limits the number of fragments inspected to infer the schema, it defaults to one fragment.
Add FinishOptions which toggles if validation of the optional schema and also controls the number of fragments it validates with. It defaults to disabling validation.

This gives a noticeable speedup when the fragments have a uniform schema.

I don't think the c/glib failure is related.

This still needs more detailed Python (and R) bindings, right?

That was my understanding from when we discussed Monday as well.

Opened an issue for that https://issues.apache.org/jira/browse/ARROW-8221 (at least for the Python side, R probably needs a similar one?)

Still some questions about this:

What happens if you put fragments=0? Then the dataset has no known schema? (or is that only possible when specifying a schema manually?)
The number of fragments (fragments option) is used to determine how many fragments to use for both when inferring the schema as when validating the schema, right? (but, this number is only used for validating when validate_fragments is set to True)

Still some questions about this:

What happens if you put fragments=0? Then the dataset has no known schema? (or is that only possible when specifying a schema manually?)

You get no schema, or only the one in the partitioning if there's one.

The number of fragments (fragments option) is used to determine how many fragments to use for both when inferring the schema as when validating the schema, right? (but, this number is only used for validating when validate_fragments is set to True)

For FinalizeOptions.inspect_options yes. When the schema is not specified, there's no need to validate since the Inspect does some validation while trying to unify.


Add licenceCode method in the to es_ES person provider

Added licenceCode method in the en_Es person provider, that generates a random valid Spain licence code

Thanks!


Updating and systematising NDArray typing

Description
This PR makes the NDArray typing across the project systematic:

Changes NDArray[np.float32] to NDArray[np.float64]
Changes bare NDArray to the appropriate type (99% NDArray[np.float64], 1% NDArray[np.datetime64])
Updates a couple of .astype(np.float32)
Imports numpy in a couple of modules as needed

Fixes #334
Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

Are we happy with the idea that people now will be instructed not to pass ints into functions doing ordinary arithmetic or array ops? For most functions, integers will work fine.

I think that depends on what we mean by people? Since the typing is static, this change doesn't actually stop users from passing in integer arrays to those arguments (or indeed anything that isn't explicitly blocked by downstream input checking!), but it does indicate to developers that something is expecting to work with floats. We could expand the typing to make it explicit that these are "numeric" rather than implicitly allowing integers but I think that only affects developers.

This is incredibly pernickety.
Do we care if we pass values as ints into a function that requires a float. Examples of this in the code are at line  92 in pmodel_environment.py where we call bounds_checker and pass in -25 and 80 as ints, when the function args are type hinted as floats.

I think that depends on what we mean by people? Since the typing is static, this change doesn't actually stop users from passing in integer arrays to those arguments (or indeed anything that isn't explicitly blocked by downstream input checking!), but it does indicate to developers that something is expecting to work with floats. We could expand the typing to make it explicit that these are "numeric" rather than implicitly allowing integers but I think that only affects developers.

It might make sense to just have np.number rather than float64. This is tidy for developers and docs, plus allows use of decimal, fractions etc.

I don't think we do care if int gets passed in. We don't test for it and they'll get converted (unless I guess someone passes in really long integers that can't be represented in np.float64?).  I guess I'm inclined to leave it as is for now.


Rfc simplify plugin maintenance

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.006%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6275

Relevant Lines:
8366

💛  - Coveralls


[processBridge]: Error: ENOENT: no such file or directory, open 'MYHOME/.vscode/extensions/anseki.vscode-color-0.1.9/node_modules/electron-prebuilt/path.txt'

The color picker does not wrok and throw an error like this "[processBridge]: Error: ENOENT: no such file or directory, open 'MYHOME/.vscode/extensions/anseki.vscode-color-0.1.9/node_modules/electron-prebuilt/path.txt'"

Hi @xjchan, thank you for the report.
It seems that this is a duplicate of https://github.com/anseki/vscode-color/issues/7.
Try to do my recommendation in that issue, and please comment to that issue about this issue.


Add support for Ubuntu 18.04.

Closing and reopening to trigger a rebuild. travis-ci seems to fail on installing chef, so it's unrelated to my PR.

@yevgenko Can you merge or comment on this? It's fairly trivial, and adds support for the upcoming Ubuntu 18.04.

thank you @leegarrett 👍

@yevgenko, you're welcome! Is there any ETA when there's a new release? I don't mind the issue as I use a checkout of the cookbook, but it would be great if others could benefit from this (and many other) fixes since the release last year.


Add Decorator definition to IModule

angularjs/angular.d.ts
to author(@diegovilar) could you review this PR?
check list

[ ] pass the Travic-CI test?

@dimasty thanks mate!


add QuadratureFunction

Hi,
This pr adds a QuadratureFunction algorithm that allows the user to pass in a function that returns nodes, x, and weights, w, and computes sum(w .* f.(x)). This could serve as a backend for other integration algorithms we would like to support, such as the trapezoidal rule and FastGaussQuadrature.jl rules.

This looks great. Only some bikeshedding on the naming and I think this is good to go.

Would it be good to also support vector-valued integrands? Right now you assert nout==1 in the evalrule function.


Add is_dataset_config

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (566279a) 100.00% compared to head (9d2a3f9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #296   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          316       316
  Lines         9913      9916    +3
  Branches       961       961
=========================================
+ Hits          9913      9916    +3

Impacted Files
Coverage Δ

src/gravitorch/data/datasets/__init__.py
100.00% <100.00%> (ø)

src/gravitorch/data/datasets/factory.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix Warnings and Enable Warnings as Errors

Enable Warnings-as-Errors
I enabled HandleLLVMOptions in the top-level cmake project and used imported cmake option LLVM_ENABLE_WERROR to do the heavy lifting of setting compiler options correctly across compiler versions.
Fixed Warnings
I built triton-mlir with both GCC and Clang/LLVM and fixed all the result warnings. Most were harmless but i did find a couple of real issues during this work

signed/unsigned comparisons and unused code were the most common warnings
i fixed a couple of incorrect usages of std::move that were resulting in extra copies
replaced usage of tmpnam (unsafe) with built-in LLVM functionality
fix a place where code was checking if the success function existed rather than if a function returned success due to a typo.

@ptillet please let me know what you think.

is warning-as-errors something you'd like to see?
is HandleLLVMOptions disabled on purpose? My team takes advantage of this for a few things and would generally like to see it enabled.
I suspect some of the "dead" code i removed is there for future use... let me know if you'd like me to "fix" that warning in other ways

Did you find these problems just by enabling compiler warnings as errors? Seems good to me.
Fixing warnings was on my todo list but you've done most of it.

Did you find these problems just by enabling compiler warnings as errors? Seems good to me.

That's exactly what i did.

Yep that all sounds good to me too!

Updated to latest fixed a few new warnings. Should be ready to merge now.

I noticed that the cpp code style check is failed, you'd better use a clang-format to reformat the modification code.

I noticed that the cpp code style check is failed, you'd better use a clang-format to reformat the modified code.

Formatted and merged with latest.

It seems like the latest pybind11 has warnings :o

It seems like the latest pybind11 has warnings :o

Unfrotuante.
I Presume the pybind update isn't merged yet though? i didn't see any new warnings in my local build.
We can disable warnings around pybind inclusion if we need to. Happy to do it if you point me at a branch with the changes.

Pybind11 version was updated in https://github.com/openai/triton/pull/797

Pybind11 version was updated in #797

I looked at the build failures, and they didn't look like warnings, but instead looked like errors i was seeing locally if python environment wasn't set up correctly. I've pushed a PR that ensures python environment matches what cmake sets up. This gets me clean build locally, so hopefully it addresses the issue that showed up in the CI.
As to why this happens? not sure.. but possibly enabling HandelLLVMOptions changed something slightly that requires this, at least that's my best guess

My python environment magic didn't work here... :(
Is there any chance i can get a VM with this environment?
    ld: library not found for -lPython.framework/Versions/3.10/Python
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [bin/FileCheck/FileCheck] Error 1
    make[1]: *** [bin/FileCheck/CMakeFiles/FileCheck.dir/all] Error 2

We can't share access to our CI VM, unfortunately. But looking at the diff, it seems like this PR is trying to link against Python in the CMakeLists.txt? Maybe you could try removing that and see if this helps

We can't share access to our CI VM, unfortunately. But looking at the diff, it seems like this PR is trying to link against Python in the CMakeLists.txt? Maybe you could try removing that and see if this helps

I'm not sure exactly what you mean... the new lib was supposed to fix the link errors i was seeing (and did for my local build). Unfortunately, somehow the path must be wrong on MacOS. I've pushed a change to the branch that should print out the python environment on failure which may help me debug.

Okay @ptillet here's what i've discovered.
I still don't know why my change prevents the build from automatically finding the python lib, but alas it does (pulling in LLVMHandleOptions is still my suspicion, but i really want to pull this in)
But... i have the fix. I have two options for you if you're still okay moving forward with this.

We remove the python discovery code from the python file and use the CMAKE discovery code instead
Check-in the crazy logic i added to the Python file to find the correct python lib.

#2 is implemented right now. I'd prefer #1, though i know previously you preferred the python logic.
Please let me know if one of these makes sense (or neither).

@ptillet ... tag above didn't work

I'm actually still a bit confused. If I remember correctly link symbols are resolved at runtime for python modules (e.g. when they're imported), so the build system shouldn't need to link against -lPython (or find it), which is why there was no link_libraries(${PYTHON_LIBRARIES}) before

Yes, I thought so as well. There seems to be some confusion about this on the web. I can dig in more, but I'm kind of ready to throw in the towel and just make the tools happy
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Philippe Tillet @.>
Sent: Friday, October 28, 2022 11:55:01 AM
To: openai/triton @.>
Cc: Ian Bearman @.>; Author @.>
Subject: Re: [openai/triton] Fix Warnings and Enable Warnings as Errors (PR #794)
I'm actually still a bit confused. If I remember correctly link symbols are resolved at runtime for python modules (e.g. when they're imported), so the build system shouldn't need to link against -lPython (or find it), which is why there was no link_libraries(${PYTHON_LIBRARIES}) before
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenai%2Ftriton%2Fpull%2F794%23issuecomment-1295345702&data=05|01||77bdaafcc00a4376a06808dab915eb4a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638025801033444144|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=0lESZSXjdRK316VYQTWAaapcI48BJ5PYBcZV7aN8Q2A%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF7M3YQ6DPNGUMEPL4BDBPDWFQOQLANCNFSM6AAAAAARMO2VNQ&data=05|01||77bdaafcc00a4376a06808dab915eb4a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638025801033444144|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Qei8%2FLaB5lGj6qOyMKCehTsmkiNC%2Fz59fxKuy%2FzJDsA%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

I'm ok with merging that and trying to resolve the link issue separately

I'm ok with merging that and trying to resolve the link issue separately as I can access the CI server directly

Thanks! I created https://github.com/openai/triton/pull/817 which repros the problem without warnings enabled.


construct_runtime: support for expanding the macro code

Support for expanding the generated code from construct_runtime  macro into the source file which is included. Allows for better macro debugging (error points to the particular line in expanded source files).
Based on: https://github.com/paritytech/substrate/pull/13573
Setting FRAME_EXPAND environment variable enables feature.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2989448

bot merge


feat: improve design of danger buttons in dark mode

Destructive buttons like for plant deletion do no more look disabled in dark mode.
Closes #1029

Basics

[x] I added a line to changelog.md
[x] The PR is rebased with current master.

[x] References to issues, e.g. close #X, are in the commit messages and changelog.
[x] The buildserver is happy.

Checklist

[ ] I have installed and I am using pre-commit hooks
[ ] I fully described what my PR does in the documentation
[ ] I fixed all affected documentation
[ ] I fixed the introduction tour
[ ] I wrote migrations in a way that they are compatible with already present data
[ ] I fixed all affected decisions
[ ] I added automated tests or a manual test protocol
[ ] I added code comments, logging, and assertions as appropriate
[ ] I translated all strings visible to the user
[ ] I mentioned every code or binary not directly written or done by me in reuse syntax
[ ] I created left-over issues for things that are still to be done
[ ] Code is conforming to our Architecture
[ ] Code is conforming to our Guidelines
[ ] Code is consistent to our Design Decisions
[ ] Exceptions to any guidelines are documented

Review

[ ] I've tested the code
[ ] I've read through the whole code
[ ] I've read through the whole documentation
[ ] I've checked conformity to guidelines

Needs rebase. Watch out to not self-conflict in the changelog :ghost:.

Thx :heart:


minor login flow updates

#796  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jlewitt1 and the rest of your teammates on  Graphite


Service Container disposes twice

Lets say MyService which implements IService and IDisposable and is registered in the following way:
services.AddSingleton<IService, MyService>()
services.AddSingleton<IInitializable>(c => c.GetRequiredService<IService>());

Because you have an initialization system and another class that uses IService.
Then Dispose might be called twice. I think it would be good to just replace this list:
https://github.com/aspnet/DependencyInjection/blob/dev/src/DI/ServiceLookup/ServiceProviderEngineScope.cs#L14
With a hashset.

Let's fix it.

Double dispose should always be allowed and be treated as a no-op by the thing being disposed. Is it worth making a change because of bad disposables?

There is no guarantee and I just remember some articles about nested using statements and streams.

I'm with @Eilon on this one
https://docs.microsoft.com/en-us/dotnet/api/system.idisposable.dispose?view=netframework-4.7.2

If an object's Dispose method is called more than once, the object must ignore all calls after the first one. The object must not throw an exception if its Dispose method is called multiple times. Instance methods other than Dispose can throw an ObjectDisposedException when resources are already disposed.

Especially considering the fix is more involved than changing Dictionary to HashSet

Marking this bug as a doc bug and punting to Backlog per the discussion.

So no need to re-do the PR at aspnet/DependencyInjection#661?


Modified aux basis set name

Change the

aux = psi4.core.BasisSet.build(mol, fitrole="JKFIT", other="aug-cc-pvDZ")

to
aux = psi4.core.BasisSet.build(mol, fitrole="JKFIT", other=basname)

in order to fit more basis sets.

The JK_builder can be called by import core

Please fix the Travis failing issues.

@ZhangJunQCC Any status updates?


WebContainers are in beta now for Safari

Recent macOS update (13.3) bumped Safari to 16.4 which on WebContainers Browser Support page isn't described as lacking some features anymore but now as "in beta".
WebContainer's landing page demo now successfully runs on Safari with webcontainer_any_ua in LocalStorage being set to any non-empty value

I haven't though tested "learn"s code with removed user-agent matching codepath. Maybe there are some parts of WebContainers functionality which "learn" uses and which still don't work. If there are, maybe it would be smart to change check from user-agent to these specific function(s). At least we're getting close

Feature-detection rather than UA sniffing would be ideal, yeah, though the docs aren't quite clear on how to do the feature detection (the 'such as' makes me nervous):

I've opened a request for a) boot() to throw in unsupported environments and/or b) the ability to know ahead of time if the environment is supported: https://github.com/stackblitz/webcontainer-core/issues/1021

Great, thank you for opening that request! Should I close then this one and watch there or leave this as is for now?

Let's leave this open, as we'll still need to do some work on our end if/when they make any changes on theirs

For those who really wants to learn.svelte.dev in Safari even before this resolves:

it's possible in macOS 13.3 (or if you got Safari 16.4 in some other way),
make Safari pretend it's (for example) Chrome (in Dev menu)
tick "Disable Cross-Origin Restrictions" (in Dev menu too)

WebContainers team choose now to enable demo on their landing page for Safari by default. Here's the check they used in code. Maybe it's be good enough for learn too?

According to this document, older Safari does not support Atomics.waitAsync and therefore cannot run Webcontainer.
https://webcontainers.io/guides/browser-support#safari
According to caniuse.com, I see that Safari has supported Atomics.waitAsync since 16.4, so this could be used to check for Webcontainer support, as a temporary workaround.
https://caniuse.com/mdn-javascript_builtins_atomics_waitasync.

I have tried learn.svelte.dev on iPhone XS MAX and iPhone 13 Pro and it crashes. (On iPad Air (4th gen), it crashes rarely, but shows 'OUT OF MEMORY').
So again, I read the code in the docs of webcontainers.io and found that for mobile Safari, it is hidden by CSS.
https://github.com/stackblitz/webcontainer-docs/blob/369dd58b2749b085ed7642f22108a9bcbcd68fc4/docs/.vitepress/theme/components/Examples/WCEmbed/WCEmbed.vue#L133-L140
Stackblitz shows the following for mobile Safari:

...then if you click the Run this project button on the iPhone XS MAX and iPhone 13 Pro, it crashes.
So I will improve the check logic to make it unavailable for Safari on iOS.


link_to produces a link with no link text if the name passed to the helper is nil

The expected functionality is that the following:
link_to nil, root_url

...will produce
http://www.example.com

But in reality, bh's link_to helper produces the following:

The bh link_to helper should maintain parity with the Rails helper that it overrides where possible.

thanks! I'll look into this!

@mgoggin Are you sure that link_to nil, root_url is supposed to produce that output in Rails?
I tried in a normal Rails view, and I got the output with nothing between the  tags.
Maybe what you intended to write is link_to root_url instead?

I have tested this on a newly generated Rails 4.2 app.
index.html.erb
<%= link_to nil, root_url %>
<%= link_to root_url %>

This is what is produced:
http://localhost:4000/
http://localhost:4000/

When including bh in the Gemfile, this is what is produced:

http://localhost:4000/

@mgoggin Thanks for the clarification! You found a bug :sweat: my bad!
I fixed it and I'm about to release 1.3.2 with the bug fixed.
Before I do that… do you mind referencing the fix-link-to-without-caption branch of bh in your project, and then try again to check if I've actually 100% fixed the bug?
Simply, in your Gemfile, replace
gem 'bh'

with
gem 'bh', github: 'Fullscreen/bh', branch: 'fix-link-to-without-caption'

and tell me if it's okay! Thanks

I can confirm that the bug is fixed on the fix-link-to-without-caption branch.

Perfect!
Thanks again for your feedback.


wasm-pack-init (1).exe does not show init instructions

When i download new version wasm-pack, my browser saved it as wasm-pack-init (1).exe.
wasm-pack-init (1).exe does not show init instructions and work as wasm-pack.exe
Maybe run all the files with name start from "wasm-pack-init" as init-file?

@danwilhelm or @Mblkolo - i've started a branch in #550 with a solution to this- i'm not entirely sure what if any way we should test it- could one of you test it manually for now and/or leave your comments on the PR? thanks so much!


Is there any demo ?

Maybe you can create demo service ?

Sure, in description above: https://bvn13.tk/

but without administration

What are tech specs of the server on which the blog works?

$ lscpu
Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               23
Model name:          Pentium(R) Dual-Core CPU       T4500  @ 2.30GHz
Stepping:            10
CPU MHz:             1200.000
CPU max MHz:         2300,0000
CPU min MHz:         1200,0000
BogoMIPS:            4590.83
L1d cache:           32K
L1i cache:           32K
L2 cache:            1024K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx lm constant_tsc arch_perfmon pebs bts rep_good nopl aperfmperf eagerfpu pni dtes64 monitor ds_cpl est tm2 ssse3 cx16 xtpr pdcm xsave lahf_lm dtherm

4 Gb RAM, HDD

should I close this issue?

Oh sure =)


Trying to run the iOS example project

I have followed few instructions given in the docs for mopro dir, and have wasmer installed with snarkjs on global.
While trying to run the app using simulator iPhone 15 pro, it stops unexpectedly without error and just shows cancelled.

did you run the prepare.sh or prepare_ci.sh script?
and also build_ios.sh?

did you run the prepare.sh or prepare_ci.sh script? and also build_ios.sh?

I ran the prepare.sh and build_ios.sh script.

No error while running the prepare script, but still says -
Script did not finish successfully!

No error while running the prepare script, but still says -
Script did not finish successfully!

Here I saw the circom installation successful -
    Updating git repositoryhttps://github.com/arkworks-rs/circom-compat.git`
`

Oh then you should install circom here
https://docs.circom.io/getting-started/installation/

@shreyaspapi did that work?
Thanks for https://github.com/oskarth/mopro/commit/4c8cfe5eb305aa6aecffb74a60ea83c40c8f02f2 @vivianjeng

Hey @oskarth it did work, unfortunately I didn't have time to work on top of it at the hackathon so had to pivot.

Ok, please let us know if you ran into any other issues! Easiest would be TG chat. Closing this issue as main issue was resolved.


Feature/app

Summary of this PR:

Create api endpoints for greeting.
Integrate with the react project.
No linters error.

Note

Open the rails app in port 3000 with the localhost url.
Open the React app in port 3001 with the localhost url.

Hello @M-Anwar-Hussaini, you have used the wrong Gitflow for this project, please kindly change your base branch to develop.

Hello @M-Anwar-Hussaini, you have used the wrong Gitflow for this project, please kindly change your base branch to develop.

Hi @topeogunleye. Thanks for mentioning that point. I have fixed it.


Constaints does not updated

I tried to hide navigation bar and tab bar, it's works but there is blank spot when navigation bar and tab bar is hidden.
Does anyone solved it ?

I have a same problem too. It seems the AutoLayout is not working. At the moment, I use this method to update manually, hidingNavigationBarManagerDidUpdateScrollViewInsets in HidingNavigationBarManagerDelegate. I think it's bad practical. Does anyone have any solutions for this issue?

@danhhgl can you share your code for updating the constraints ?


Adding lights and shadow casting

Hi, there're many lighting methods for the gaussian splatting recently, do you plan to add lights to this project (like shadow casting, changing environment light conditions)?

Hi!
Yes would be great. Do you have any links to examples?
Thanks

Hi!
Yes would be great. Do you have any links to examples?
Thanks

Hi, this blog has some clues: https://andrewkchan.dev/posts/lit-splat.html;
And these two papers:
https://nju-3dv.github.io/projects/Relightable3DGaussian/
https://asparagus15.github.io/GaussianShader.github.io/
I think if we can render depth map of gaussians, it would be easy to apply shadow mapping like in traditional CG in this viewer.


Wrong link for parallel builds

In Gird view, click on the parent build should open page for its child builds. Currently, instead of child builds, it shows empty page
I suspect we set wrong id in ResultSummary.jsx

FYI @OscarQQ


UI Enhancement

I would like to add a footer, include a star symbol for the GitHub stars on the homepage, and improve the UI

@iuliaturc Would like to work on this

Thanks for the clarification! Just to confirm, will this be included in the Dev Fest open source contributions? I’d love to contribute to the README in that context

If the contribution to the README is meaningful, I'm happy to tag your pull request with "hacktoberfest-accepted".


fix out of range panic

Signed-off-by: Harold Carr<EMAIL_ADDRESS>This adds a test case that expects InvalidPresentationData when someone tries to create a range proof with a value that is outside the required range.
Without the fix, it panics:
thread 'out_of_range_panic' panicked at 'attempt to add with overflow', src/presentation/range.rs:147:38
This PR adds a check for out of range in presentation/range.rs in RangeBuilder.commit.

w00t!! :-).  Thanks!    Looks like there are some lint issues in the code — can you fix, please?  They are specific to your addition — details are here.
Darn — I see it got merged already.
BTW - if you are using the git command line — git commit -s -m “commit comment” gets the DCO sign-off — the -s option on the commit.

@swcurran : since it was already merge, could you make the format change?
BTW: thanks for the tip - I use emacs/magit

It's no different if I do it vs you. I'd rather give you the credit


feat: image preprocessor

Implements the preprocessor described in https://github.com/sveltejs/kit/issues/241. Please read both the description of that issue and the README in this PR for more details.
Together with with the dynamic solution in https://github.com/sveltejs/kit/pull/10323 this is most of what we need to handle images. This pair of PRs would replace https://github.com/sveltejs/kit/pull/9787.
Package setup
I named it @sveltejs/enhanced-img, which is updated from @sveltejs/image in the earlier PR since this one is focused on the static case and we'll have a dynamic one as well
This makes vite-imagetools a dependency. vite-imagetools includes sharp, which is a bit heavy and platform-specific, so we wouldn't want to include it for the dynamic case. However, for the static case, this means users don't need to add two packages to their package.json as in the earlier PR, which required installing vite-imagetools as well.
However, if we have a dynamic preprocessor as well it will have to live in a separate package. This means that users could end up having to install @sveltejs/enhanced-img and @sveltejs/dynamic-img and instantiate both of them. I.e. one possible idea would be to combine this PR with the getImage PR, to have an option to transform

to:

This could be a little more natural for the user to write.
Performance
Inserting picture markup for each individual image could bloat the HTML-creation JS. E.g. this REPL outputs 42 lines of code in Svelte 5 today while this REPL outputs 67 lines of code. Compare this to a component-based approach where you have 19+89 lines of output for a single image and 22+89 lines of code for two images.
We should be able to optimize the template creation such that a single image would output something like this and two images would output something like this. However, I'll note that it seems like even in this case there's still some optimization that can be done in the Svelte 5 compiler as I'd expect these to output an identical number of lines.
For these optimizations to work, it may turn out that we need the preprocessor to call the Vite plugin's load function to insert the results rather than using an import - this would obviate the need for special import handling in the Svelte compiler and allow more advanced optimizations there since it would change the ordering of the import resolution from after the Svelte compiler runs to before it. Also note that I somewhat took a shortcut route and just inserted an each block, but it'll probably be better to unroll that either in the Svelte 5 compiler or here in the preprocessor.
It should be noted that the preprocessor also has the advantage of not needing to ship getWidths to the client, which saves about another 25 lines of code.
Passing transformed image imports to non-transformed
Right now this only has vite-imagetools transform images with the enhanced-img query parameter to avoid taking over existing imports. We have the preprocessor add this automatically. You must add it manually when you want to dynamically choose an image, but that's probably infrequent enough that it's okay.
The other way of dealing with this would be to transform all imported images by default and users can opt-out with ?url. I think it's pretty rare that you'd want to import an image and not transform it and can't really think of when you'd want to do that, so that option does have an appeal, but it could be unexpected. If we went this route it would be more important to work on our error messages as noted below.
It's an error if you pass a transformed img to a standard img tag. The error message right now isn't great and can be slightly hard to diagnose. It ends up generating HTML that looks like  which then makes a request giving the error message:
Error: Not found: /[object%20Object]
    at resolve (packages/kit/src/runtime/server/respond.js:483:13)
    at resolve (packages/kit/src/runtime/server/respond.js:277:5)
    at Object.handle (sites/kit.svelte.dev/src/hooks.server.js:19:9)
    at Module.respond (packages/kit/src/runtime/server/respond.js:274:40)

I can think of a few ways we might be able to detect this:

have the Svelte runtime check when setting an img src attribute in DEV mode that it's being passed a string
opt all img tags with a mustache src into preprocessing in DEV mode and then add a check that it's being passed a string
check for /[object%20Object] as URL in our 404 handling and suggest you might have forgotten a  and should view-source: to see where needs to be updated
run a check after SSR for src="[object Object]" in the generated page source and print a warning similar to the one above

If there's someplace a user was using an imported image other than an image tag most of these checks wouldn't save us, but that seems less likely to happen. The only thing I can think is if they were trying to output some sort of meta data via {@html}.
Configuring
For now, the preprocessor doesn't take any options. This keeps the API smaller and make it easier to land this PR. We'll probably have to add some options in the future, but it's not necessary to get an initial usable version out.
There are some options like deviceSizes that we may want to share with the dynamic implementation and have live in the Svelte config. I think the dynamic approach needs to advance a bit more before we can say what it should look like though
We could have the user add another instance of vite-imagetools for anything custom they want to do. However, this could be very frustrating because you'd be forced to create an Image component to use with it, which would be not only cumbersome, but would reintroduce the problems we're trying to avoid here by having a preprocessor rather than a component (i.e. event handling and usage of :global for styling). It might also force you to setup svelte-preprocess-import-assets yourself. Exposing defaultDirectives in some manner would probably be quite appreciated

For reference, here are all the options in vite-imagetools

include/exclude - it might be better for us to have our own filter or we might want to apply these filters to the URLs we find in img tags to decide whether to process that tag
defaultDirectives - could be useful. we would want to ensure correct as directive is used (as=picture unless there's a single format). there aren't too many directives you'd want to set on every image (background, flatten, grayscale, lossless might be some of the most likely). but some are useful - e.g. background plus flatten would further reduce file size. you may also want to create your own presets
extendTransforms - a common use case is the low quality placeholder discussed in the next bullet. could also be useful in other advanced cases, but seems uncommon
extendOutputFormats - it seems the main use case for this is the low-quality placeholder. i'm not sure this would be possible for users to do with this package without us explicitly adding support for it
resolveConfigs - this is pretty niche and not too likely to be used
removeMetadata - leaving metadata on optimized could be useful, but I expect uncommon. I think this should be made a directive instead of an option in vite-imagetools

Including in the default SvelteKit template
For now, this is not included in the default template. However, after we've released the dynamic one and let this bake for a little while, I think it would be nice to add it.
Todo

Fix TODOs regarding type imports - help would be much appreciated!
Check what happens if only one of width/height is supplied

Soon

Better filtering of URLs (../ should be allowed. better checking of vite aliases
Probably need to load the image for performance. This looks a bit tricky because I would also first need to resolveId to pass into load. After Paolo's PR in Svelte 5 is merged it will result in highly optimized output

Later

Allow configuring
A bunch of possible imagetools improvements:

Investigate whether we can merge imagetools-core into vite-imagetools without breaking astro-imagetools
Caching (https://github.com/JonasKruckenberg/imagetools/issues/522). Sync with Arnaud about build caching in Vite #contributors channel
Figure out if we want to support low quality placeholders (https://github.com/JonasKruckenberg/imagetools/issues/86)
SVG support

Just a thought but would enhanced:img be easily confused with use:enhance? Should this be a concern?

Hey, you got a new more memorable username! I won't have to type @s and wait for autocomplete now :laughing:
Great minds think alike!

We had considered it, but no one felt strongly enough to object to it. And perhaps more importantly, there weren't any other name options that we could agree on...

Great work on this!
@benmccann @Rich-Harris I'm slightly late on this, but a recent thought on naming:
If this were named enhance:img (present tense), it'd mirror use:enhance that exists for forms and remove the need for devs to recall whether past tense or present tense should be used in one situation or the other.


Release of 3.10.0

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Certainly! I always squash but I like having the history in place for discussion.


(PA-4486) Update Networking Facts test

In GCE the VMs we use can have a networking.netmask of <IP_ADDRESS>.
This causes failure in the networking_facts.rb test, this PR updates the regex
to allow for such an IP.

@cthorn42 I think you'll need to cherry-pick to main since we don't auto mergeup (as the 3.x and main code bases are so different)


Cross compile error (on mac for linux)

When I try to compile sample app natively on macos it's all ok:
$ cd $GOPATH/src/github.com/lazywei/go-opencv/samples
$ go build -o ./hello-mac hellocv.go
$ ls -lh hello-mac
-rwxr-xr-x  1 user  user   2.3M Apr 24 16:42 hello-mac

But when I try to compile linux binary on my mac I get error:
$ cd $GOPATH/src/github.com/lazywei/go-opencv/samples
$ GOOS=linux GOARCH=amd64  go build -o ./hello-linux hellocv.go
# command-line-arguments
./hellocv.go:24: undefined: opencv.LoadImage
./hellocv.go:30: undefined: opencv.NewWindow
./hellocv.go:44: undefined: opencv.WaitKey

What I doing wrong?

Hi @matyunin the problem here is when using cgo as this package does you still need to compile/link  against the target libs for the particular arch & OS. See https://github.com/lazywei/go-opencv/blob/master/opencv/cv.go#L7-L11
If there was a pure Golang implementation of an OpenCV-like library, then you would be able to cross-compile using the normal Golang compilation toolchain. But at least for the foreseeable future, you will need to compile on the target platform.


How to search collection with keyword?

What is the equivalent function to search from the collection?
For example Select name from tbl_users where name like '%adam%' in mysql
How to do like on this mquery?

https://masteringjs.io/tutorials/mongoose/find#regular-expressions


fix assign_to_source

Hi!
This is just a very small change to plugins/XYLike::assign_to_source, Line 227-229. The way line 229 currently is written makes it so I cannot assign a source to my XYLike object later on if I did not assign a source during construction. I don't think that's the intended behavior, maybe a typo?
The test should be
        if self._likelihood_model is not None and source_name is not None:

            assert source_name in self._likelihood_model.sources, "Source %s is not contained in " \
"the likelihood model" % source_name

Instead of
        if self._likelihood_model is not None:

            assert self._source_name in self._likelihood_model.sources, "Source %s is not contained in " \
"the likelihood model" % source_name

The change in line 227 would make it possible to 'un-assign' XYLike from any source.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0f884cd). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master     #245   +/-   ##
=========================================
  Coverage          ?   75.98%
=========================================
  Files             ?      136
  Lines             ?    14634
  Branches          ?        0
=========================================
  Hits              ?    11120
  Misses            ?     3514
  Partials          ?        0


Android perfomance?

Any plans to improve Android perfomance. It's still little bit janky and on some phones has a delay of even few seconds when taking picture and opening the camera.
Will the new  android.hardware.camera2 help with the perfomance on devices with api lvl 21 or more? https://developer.android.com/reference/android/hardware/camera2/package-summary.html

+1

+1

+1

location metadata maybe?


Refactor network configuration

Move network configuration from main function into network package.
Make underlying network functions non-exported.

https://git.glasklar.is/system-transparency/core/stboot/-/tree/main/


contrail-agent kernel not supported vrouter

$ sudo contrail-status
Pod      Service  Original Name           State       Id            Status
vrouter  agent    contrail-vrouter-agent  restarting  b892df54d769  Restarting (134) 55 seconds ago
vrouter  nodemgr  contrail-nodemgr        running     ffd682536781  Up 19 minutes
vrouter kernel module is PRESENT
== Contrail vrouter ==
nodemgr: active
agent: inactive
=================
$ sudo docker logs b892df54d769
...
INFO: Kernel version does not support vrouter to vrouter encryption - Not adding decrypt0 to vrouter
Config file </etc/contrail/contrail-vrouter-agent.conf> parsing completed.
contrail-vrouter-agent: controller/src/vnsw/agent/vrouter/ksync/ksync_memory.cc:107: void KSyncMemory::Mmap(bool): Assertion `0' failed.
/entrypoint.sh: line 398: 1879970 Aborted                 (core dumped) $@
Is there a special kernel we should be using?
$ uname -a
Linux arnolt 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Such error we saw when free memory is low on host.

Thanks Andrey.  I can redeploy with higher memory constraints.

This issue does not exist on baremetals.


Error occurred while opening the properties dialog for login

Type: Bug
This occurs when right-clicking a database login in Security->Logins and choosing Properties (Preview). "SERVER\GROUPNAME" is the login that is right-clicked. The error occurs on all servers and logins.

An error occurred while opening the properties dialog for login: SERVER\GROUPNAME. An exception occurred while executing a Transact-SQL statement or batch. ---> Cannot execute as the server principal because the principal "SERVER\GROUPNAME" does not exist, this type of principal cannot be impersonated, or you do not have permission.

Azure Data Studio version: azuredatastudio 1.46.1 (ba29842b81dec01177415e53948ca2168e69c3f8, 2023-10-02T18:14:38.547Z)
OS version: Darwin x64 22.6.0
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
Apple M1 Max (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
3, 3, 3

Memory (System)
32.00GB (0.62GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

admin-pack
Mic
0.0.2

admin-tool-ext-win
Mic
0.1.3

agent
Mic
0.49.0

dacpac
Mic
1.14.0

import
Mic
1.5.5

profiler
Mic
0.14.0

sql-search
Red
0.4.1

vscodeintellicode
Vis
1.2.1

poor-sql-formatter
WSR
0.1.0

@corivera can you check if this is something that should be in the November milestone?

Disregard that, I was able to get a repro.


How do i send data in a certain order(Eg ascending)

, example ascending, descending i tried sorting and it doesn't work , Anyone with sample code please share to help me as example

Hi. Sorting does work in this package. When you say "it doesn't work" - what do you actually mean? What problem are you encountering/

Closing this due to lack of information. Feel free to re-open with more specific information if needed.


go to subdomain nuxt-link

Hello, how can I go to a subdomain using a nuxt-link without knowing whether I am on a localhost or on a server?More precisely, how can I switch from a domain to a subdomain what write - go to sub

You can't switch directly, for that you'll need to use anchor tags, we need to work on core and it's not possible in the current version to implement this feature.
Even for my own site, I'm using anchor tags,
Can you try visiting home and blog from here , is this the same you are trying to implement?


fix #479 [codeReview] redis registry code format parseInt

Signed-off-by: slievrly<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
[codeReview] redis registry code format parseInt
Ⅱ. Does this pull request fix one issue?
fix #479 [codeReview] redis registry code format parseInt
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #480 into feature_registry_redis will decrease coverage by <.01%.
The diff coverage is 0%.

@@                     Coverage Diff                      @@
##             feature_registry_redis     #480      +/-   ##
============================================================
- Coverage                     28.07%   28.06%   -0.01%
  Complexity                      646      646
============================================================
  Files                           192      192
  Lines                          7438     7439       +1
  Branches                        907      907
============================================================
  Hits                           2088     2088
- Misses                         5132     5133       +1
  Partials                        218      218

Impacted Files
Coverage Δ
Complexity Δ

...r/discovery/registry/RedisRegistryServiceImpl.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d2f41f...79e1ea4. Read the comment docs.


Update README.md

Very important PR

Finally I can see something getting merged to this repo.

Excuse my OCD :)


⚠ ClamAV has degraded performance

In dbf3794, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 74 ms

Resolved: ClamAV performance has improved in 13bea28.


docgen - working with templates - solidity-docgen: 0.6.0-beta.22

Hello,
👁 Context
I am trying to see the possibility of creating my own template.
I have applied the last version solidity-docgen: 0.6.0-beta.22 that fixed the last issue I opened here: https://github.com/OpenZeppelin/solidity-docgen/issues/402
I checked this directory looking for examples
💻 System setup

OS: Windows 10
node: v18.2.0
npm 8.9.0
solidity-docgen: 0.6.0-beta.22

🔁 Reproduction
Repository: https://github.com/PedroReyes/ethernaut/tree/docgen
❌ Problem
The very first problem I want to solve is rather simple. I have the next contract.hbs with the next content:
{{h}} {{name}}.sol

Just testing

However, I am getting the next output in the markdown generated files when running npx hardhat docgen:
# Solidity API

## Greeter.sol

Just testing

👉 Problem 1 - # Solidity AP
It seems that no matter what I put in there, # Solidity API is placed at the top instead of my fixed string.
I want the name of the contract to appear at the top so when I use a markdown site generator, the name of the content is obtained from the very first line of my markdown.
👉 Problem 2 - H index
How do I control the index of the title so instead of ## Greeter.sol  I have # Greeter.sol
Thanks in advanced for your help @frangio .
Best regards,
Pedro Reyes.

You should override the page.hbs template.


Create a setup.log file to help us debug other users build issues

I think its a good idea to take the terminal output of the setup.sh script and save it as a log file so when people are having build issues we can ask them to upload it or send it to us so we can see.

this was Rolled into the machine learning demo branch

fix is in master


Support build with Bazel

Support build and run tests through Bazel so developers from Bazel community can reuse scripts, as is discussed in Issue 284

As I mentioned above, please remove cert/key files and make them auto-generated.

"This PR almost look good to me. But one concern is: do we have a better way to unify the cmake and bazel? otherwise they are hard to maintain."
It is true that Bazel may use rules_foreign_cc to compile directly. But doing so would undermine dependency management, rendering automatic dependency version resolution infeasible.
As a matter of fact, glob is used while defining nuraft artifact. It would be a rare case when there is a need to modify bazel script in the future.

Is there any update?

@greensky00 If there is no more update, how about merging this PR and then we're refining it in the next PR?
I'm looking forward this feature to integrate it to our repo in bazel building toolchain.