Eliminated duplicative HA/DR guidance documents and incorporated unique content into other documents.

@alexbuckgit,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/mspnp/architecture-center, working directory: W:\t31r-s, target branch: master, target branch commit: 57a3336d13868272f4959349b758c22e3a72d823, source branch: abuck-drha, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/aws-professional/index.md
:white_check_mark:Succeeded
View

docs/best-practices/caching.md
:white_check_mark:Succeeded
View

docs/best-practices/monitoring.md
:white_check_mark:Succeeded
View

docs/checklist/availability.md
:white_check_mark:Succeeded
View

docs/checklist/dev-ops.md
:white_check_mark:Succeeded
View

docs/checklist/resiliency.md
:white_check_mark:Succeeded
View

docs/guide/pillars.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-high-availability-azure-applications.md
:white_check_mark:Succeeded

docs/resiliency/high-availability-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/high-availability-checklist.md
:white_check_mark:Succeeded

docs/resiliency/index.md
:white_check_mark:Succeeded
View

docs/resiliency/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/aws-professional/index.md
:white_check_mark:Succeeded
View

docs/best-practices/caching.md
:white_check_mark:Succeeded
View

docs/best-practices/monitoring.md
:white_check_mark:Succeeded
View

docs/checklist/availability.md
:white_check_mark:Succeeded
View

docs/checklist/dev-ops.md
:white_check_mark:Succeeded
View

docs/checklist/resiliency.md
:white_check_mark:Succeeded
View

docs/guide/pillars.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-high-availability-azure-applications.md
:white_check_mark:Succeeded

docs/resiliency/high-availability-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/high-availability-checklist.md
:white_check_mark:Succeeded

docs/resiliency/index.md
:white_check_mark:Succeeded
View

docs/resiliency/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/aws-professional/index.md
:white_check_mark:Succeeded
View

docs/best-practices/caching.md
:white_check_mark:Succeeded
View

docs/best-practices/monitoring.md
:white_check_mark:Succeeded
View

docs/checklist/availability.md
:white_check_mark:Succeeded
View

docs/checklist/dev-ops.md
:white_check_mark:Succeeded
View

docs/checklist/resiliency.md
:white_check_mark:Succeeded
View

docs/guide/pillars.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-high-availability-azure-applications.md
:white_check_mark:Succeeded

docs/resiliency/high-availability-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/high-availability-checklist.md
:white_check_mark:Succeeded

docs/resiliency/index.md
:white_check_mark:Succeeded
View

docs/resiliency/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/resiliency/toc.yml
:warning:Warning
View
Details

docs/aws-professional/index.md
:white_check_mark:Succeeded
View

docs/best-practices/caching.md
:white_check_mark:Succeeded
View

docs/best-practices/monitoring.md
:white_check_mark:Succeeded
View

docs/checklist/availability.md
:white_check_mark:Succeeded
View

docs/checklist/dev-ops.md
:white_check_mark:Succeeded
View

docs/checklist/resiliency.md
:white_check_mark:Succeeded
View

docs/guide/pillars.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-high-availability-azure-applications.md
:white_check_mark:Succeeded

docs/resiliency/high-availability-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/high-availability-checklist.md
:white_check_mark:Succeeded

docs/resiliency/index.md
:white_check_mark:Succeeded
View

docs/resiliency/toc.yml

[Warning] Invalid file link:(~/resiliency/disaster-recovery-high-availability-azure-applications.md).
[Warning] Invalid file link:(~/resiliency/high-availability-checklist.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/aws-professional/index.md
:white_check_mark:Succeeded
View

docs/best-practices/caching.md
:white_check_mark:Succeeded
View

docs/best-practices/monitoring.md
:white_check_mark:Succeeded
View

docs/checklist/availability.md
:white_check_mark:Succeeded
View

docs/checklist/dev-ops.md
:white_check_mark:Succeeded
View

docs/checklist/resiliency.md
:white_check_mark:Succeeded
View

docs/guide/pillars.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-high-availability-azure-applications.md
:white_check_mark:Succeeded

docs/resiliency/high-availability-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/high-availability-checklist.md
:white_check_mark:Succeeded

docs/resiliency/index.md
:white_check_mark:Succeeded
View

docs/resiliency/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/aws-professional/index.md
:white_check_mark:Succeeded
View

docs/best-practices/caching.md
:white_check_mark:Succeeded
View

docs/best-practices/monitoring.md
:white_check_mark:Succeeded
View

docs/checklist/availability.md
:white_check_mark:Succeeded
View

docs/checklist/dev-ops.md
:white_check_mark:Succeeded
View

docs/checklist/resiliency.md
:white_check_mark:Succeeded
View

docs/guide/pillars.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/disaster-recovery-high-availability-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/high-availability-azure-applications.md
:white_check_mark:Succeeded
View

docs/resiliency/high-availability-checklist.md
:white_check_mark:Succeeded
View

docs/resiliency/index.md
:white_check_mark:Succeeded
View

docs/resiliency/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


How do you use useFont without a require for WithSkiaWeb web env?

Description
Examples here use require https://shopify.github.io/react-native-skia/docs/text/fonts/
I believe require comes with node.js, react-native and expo only.
What to do in a non expo app?

@wcandillon Actually I think the font resource loads without error, but it doesn't display this way.
(I was working on a big block of code before which had other issues preventing me from visualising).

this sounds interesting can you share a small code snippet of what you are trying to achieve and the current problem you are facing? (I lost of bit of context here).

May take me a little time to prepare a webpack/js version as my current example is in clojurescript 😆
https://github.com/dmg46664/problems/blob/main/0009_portfolio_skia_render/src/app.cljs#L21

Made it work 😭 😄 !
useFont("http://localhost:8080/my-served-font.ttf", SIZE)

Seems like the font didn't show if I didn't give it a size!
Without size worked on the emulator, but not in browser.

gosh I realize now that you are not using typescript 😅 Is there some sort of typechecking possible in clojurescript?
I'll close the issue as the resolution here would be to document on imperative APIs automatically but already have another issue for that. Sounds fair? :)

I don't think it's about the documenting of imperative APIs.
It's more about why not specifying the size has different results on different platforms.
The font in question is the FiraCode Regular ttf. https://fonts.google.com/specimen/Fira+Code
Of course it's possible that the reason for that is buried in expo-font.
If you're happy for this slight discrepancy, then feel free to close (others struggling can search closed font issues as I did unsuccessfully).


merging cover profiles with the same files doesn't add to coverage

When running coverage doing an integration tests (e.g. generating coverage for other packages in my project that get covered when a test runs).
Using go test -coverpkg=pkgA,pkgB,pkgC -coverprofile=profile.cover ./subpackage
I think it's because the same go files are represented in the merged cover profile and the last entry counts, it should be calculating the total aggregate coverage if it processes files of the same name.

This should work. Can you give a more exact example, perhaps the generated coverprofile files and the arguments you are passing to gocovmerge to merge them?
You should be outputting to multiple -coverprofile files and then passing them as arguments to gocovmerge like:
go test -coverpkg=pkgA,pkgB,pkgC -coverprofile=profile1.cover ./subpackage1
go test -coverpkg=pkgA,pkgB,pkgC -coverprofile=profile2.cover ./subpackage2
gocovmerge profile1.cover profile2.cover

Is this how you are using it?

Actually I think my issue was I was using go list -f to generate the -coverpkg=... and was forgetting to put in the package itself e.g.
# Generates package dependencies of pkga
go list -f '{{range $i, $f := .Deps}}{{if eq (printf "%.26s" $f) "github.com/legit/woodhouse" }}{{$f}},{{end}}{{end}}'` pkga

I needed to also include the package itself:
# Generates package dependencies of pkga including a to pass to -coverpkg
go list -f '{{range $i, $f := .Deps}}{{if eq (printf "%.26s" $f) "github.com/legit/woodhouse" }}{{$f}},{{end}}{{end}}{{.ImportPath}}'` pkga

Ah, that makes sense. I'll go ahead and close this issue then as it sounds like you resolved it.


Make user creation and deletion idempotent

Resolves #454

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@jenkinsadmin what's the status of this PR?

Hi. Thanks for raising this PR, but I'm going to close it due to inactivity. Please reopen it if you're still interested in getting this merged.


mist 1.8 not compatible with Mojave

% mist list -b
Library not loaded: /System/Library/Frameworks/CryptoKit.framework/Versions/A/CryptoKit
Referenced from: /usr/local/bin/mist
Reason: image not found
zsh: abort      mist list -b
There is no CryptoKit.framework in /System/Library, only CrytoTokenKit.framework

mist version 1.8 requires macOS Catalina 10.15, as the downloadTaskResumeData instance property I am using (for resuming downloads) was only introduced in macOS Catalina 10.15.
Bit of a trade-off, but I can live with supporting the latest 3 operating systems (soon to be 4).
mist version 1.7 will continue to run on macOS Yosemite 10.10 and later

Mist 1.8.pkg has been updated to fail when installing on macOS 10.14 Mojave or older.
The README.md and release notes have also been updated to reflect this change.
All future releases of Mist will also incorporate this logic: https://github.com/ninxsoft/Mist/commit/e1572addc4483a98c9333eccf7197b4572d45270


[HOLD for payment 2023-12-28] [$500] Expense report header is missing the three dots icon

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1701391916879549
Action Performed:
Go to an expense report, look at the top  header area
Expected Result:
The header area should have a three dots (ellipsis overflow) menu in the top right. In this menu, there should at least be a pin and call option)
Actual Result:
There is no overflow ellipsis menu here
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01896b1282e560a2b7
Upwork Job ID:<PHONE_NUMBER>328407040
Last Price Increase: 2023-12-10
Automatic offers:

aimane-chnaif | Reviewer | 28037783
mkhutornyi | Contributor | 28037784

Proposal
Please re-state the problem that we are trying to solve in this issue.
Three dots menu on header is missing when open expense request.
What is the root cause of that problem?
missing 3 dots handler on MoneyReportHeader so when the component load, header doesn't read the condition
What changes do you think we should make in order to solve the problem?
Send props to MoneyReportHeader and also the condition to show the 3 dots.
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
the 3 dots menu is missing in expense request header
What is the root cause of that problem?
You miss the handler of 3 dots. After the component loads, the header does not render the 3 dots.
What changes do you think we should make in order to solve the problem?
you need to add handler to pass the In MoneyReportHeader components, pass threeDotsMenuItems, shouldShowThreeDotsButton, threeDotsAnchorPosition props
      // Shows border if no buttons or next steps are showing below the header
                shouldShowBorderBottom={!(shouldShowAnyButton && isSmallScreenWidth) && !(shouldShowNextSteps && !isSmallScreenWidth)}
                threeDotsMenuItems
                shouldShowThreeDotsButton

What alternative solutions did you explore? (Optional)

<--

Format:
Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://upwork.com/freelancers/~014da6f632ff8ea73b

-->

Updated proposal
when showing GBR/RBR on the pinned report, the pin should be hidden.
Just a note: My proposal is the first one that suggest do display pin option in three dots and Context menu of LHN Row

I did mention all from first.

ok cool, let's add the pin/unpin buttons too as we discussed that again here https://expensify.slack.com/archives/C049HHMV9SM/p1702323529445349?thread_ts=1685772909.333819&cid=C049HHMV9SM

Hi @aimane-chnaif please complete the checklist above when you can!

Bump @aimane-chnaif

Ah ok, I can open the issue for you, but can you write down the contents please?

Nice, is that a new test? I thought we needed to update one and if so, do you happen to know which?

Ohh there's a link here did not see it 👍

Created it here https://github.com/Expensify/Expensify/issues/355542

@kevinksullivan ?

regression test here and payments made


Repo Index

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/component kudoctl
/kind feature
What this PR does / why we need it:
This feature adds the ability to create an index file for a folder of operator tarballs.
Which issue(s) this PR fixes:
Fixes #622
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
`kudo repo index` will create an index file for the group of operators.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kensipe
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kensipe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I looked into rebasing... but it was too painful.  which stems for this PR being built of a PR which took an significant amount of time (hence a significant deviation from master).

@kensipe: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

test
04a49e19737820a6dc707fd64d01d061bf80f9e4
link
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hey @kensipe, I will review this by Wednesday evening. Currently traveling.

@kensipe: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

test
429157dbca6a037f8e2faacceb6df020ea98254f
link
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gerred, kensipe
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [gerred,kensipe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


License changes

Changes to license headers. Makes it easier to compare with upstream

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: tmgstevens:x: HScarbtmgstevens seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@tmgstevens can you resolve the conflict on this? Thanks!

Now superseded


SPDT 2 position switch component missing

Hello,
I am not able to find the switch SPDT with 2 positions in the "Add Component" window. I noticed there is a symbol in the library but no component.
Would it be possible to add it?

Good point, will be added in #144.

Should be there in a few moments, just update the base library from the library manager then.

Thank you very much. This is a wonderful project.


Implement method groupBy and alternative version viewBy

See issue #42.

Hi @LPTK!
Sorry for the delay, I was busy on other things, but groupBy is one of the next things to do, now that Maps are implemented (well, we still miss mutable Maps), so I think it’s time to review this PR.
The numbers you posted in #42 are nice but there are several differences between viewBy and groupBy. I think that would be interesting to know the performance improvement brought by each change.
Also, in the discussion of #42, we mentioned another variant that performs an aggregation operation on each group. I think it would be nice to include it. And we should try your suggestion that consists of adding a new parameter to groupBy but with a default value to not break source compatibility.
Finally, there are still some discussion points:

What should be the type of the collection returned by groupBy? A Map[K, ?], an Iterable[(K, ?)] or the same collection type? I don’t think returning the same collection type would make sense, especially with ordered collections, I have a slight preference for returning Map, though I would be interested in knowing precisely if it has a cost over returning an Iterable.
What should be the type of the groups? Here I think it makes sense to keep the same collection type (again, think of ordered collections).

So, my preference would be to have something like so:
trait IterableOps[+A] {
  def groupAndAggregate[K, V](key: A => K, value: A => V, aggregate: (V, V) => V): Map[K, V]
}

trait IterablePolyTransforms[+A, +C[X]] {
  def groupBy[K, V](key: A => K, value: A => V = a => a): Map[K, C[V]]
}

What do you think? Would you be interested in working on that, @LPTK?

groupBy's use-case signature should not change.  If we want something similar that retains the original collection type we should give it a new name (e.g. mapGroups(key: A => K)(f: (K, CC[A]) => B): CC[B]).

@LPTK What’s the status of this PR?

@julienrf I think this was more or less superseded by https://github.com/scala/collection-strawman/pull/253, so I'm closing.


[BUG] Examples method list_examples not returning all examples from a given playbook

When using the Examples class, the list_examples method is not returning all the examples for the provided playbook. Some playbooks that have 20+ examples are returning only a handful, or even none at all.
Expected Behavior

The expected behaviour is that all the examples present in a given playbook are returned by the list_examples method.
Current Behavior

Current behaviour is that not all examples (and sometimes none of the examples) in a given playbook are returned by the list_examples method.
Possible Solution

Steps to Reproduce

Have a DFCX agent containing a playbook which itself contains multiple examples
Call list_examples with that playbook's ID
The returned list of examples is not the complete list of examples present in the web console

Code I used to test that it isn't returning all of the examples:
dfcx_pb = Playbooks(creds=credentials, agent_id = agent_id)
dfcx_ex = Examples(creds=credentials, agent_id = agent_id)
playbooks_list = dfcx_pb.list_playbooks()
for playbook in playbooks_list:
  print(str(len(dfcx_ex.list_examples(playbook.name))) + " examples in playbook " + playbook.display_name)
(it's unclear to me if this is always the case, it was the case for all 20+ playbooks in the agent I am working in)
Context (Environment)

The issue has prevented me from being able to export the data for all the examples present in a given playbook. I'm looking to ensure they are all configured correctly with the necessary input parameters for this client's use case.

Detailed Description

Possible Implementation

Ok I figured this one out after some digging.
It's a bug in the core library so I have filed a bug with the Engineering team directly.
I'll keep this issue open for public tracking until the internal issue is resolved and then I'll report back here.
TLDR
Try list_examples(playbook_id, language_code="undetected") to find your missing examples.
Details
The Examples service in Playbooks / Agent Builder attempts to auto-detect the language_code that the example is written in.
A byproduct of this is that if the language code is unclear or if the auto detect fails for some reason, the example is stored with language_code=undetected like this:

By default, when you call list_examples() it uses language_code=en.
So it's finding all the Examples that it marked as en but failing to return any examples marked as undetected.
This would happen the same for other lang codes like es, fr, etc.
Workaround
A workaround for now is to call list_examples() twice:

1x for your lang_code
1x for undetected as the lang_code

Filed 361766559 for internal tracking.

Fix for this is now applied in prod.
Closing this issue as no change is need on the SCRAPI side of things since this was a product side bug.


Enhance game issue#44 issue#84

Resolved Issue#44 and Issue#84
New Features:

Issue#84: Expanding the WORLD_SIZE to be doubled in the size. We assigned a new variable WHOLE_WORLD_SIZE.

To be more realistic, this feature requires increment in:
- Number of Hills.
- Number of Clouds.
- Number of Trees.

Issue#44: display clouds in Multiple layers [18,22,24,26].

Tests:

Added test cases to cover the new scinarios about multi-layer clouds.
updated Existing test cases that were using previous WORLD_SIZE variable and switch it with WHOLE_WORLD_SIZE.

Embedded Design Documentation:

Included comments and issue numbers (Issue#44), (Issue#84) for each functions were used.

In principle, I like the changes where we're using the constant of WHOLE_WORLD_SIZE and WORLD_SIZE.
However, I think the approach taken here isn't quite right in my opinion. In theory, all we need to do is update the value of WHOLE_WORLD_SIZE in utilities.py and things will resize appropriately.

You are right. However, since this line was exist: n = 80  # 1/2 width and height of world which presents the WORLD_SIZE as 1/2 size of the world, so based on that I made this variable.
But good point, I changed it in to the original variable name in all files.

I took a screenshot of the test code result.
I ran the command: poetry run pytest --cov and it shows the following:


Show a spinner while waiting after tapping FB or Google register

JIRA: https://openedx.atlassian.net/browse/MOB-1684

@hanningni please review

Merging so we can make a build for QA, but still needs to be reviewed


51 feature authorization authentization support

Solves #51 and #13 .

@istvan-satmari Hi, try it out. This one breaks few things, details as https://grips.semantic-web.at/x/6CaLB . Also there are few options added at the end of sti.properties in config. Mainly SMTP configuration (do not forget that KolejNet blocks other servers than host smtp.kolej.mff.cuni.cz with ports set to 25) and some user managements parameters...
The one thing I would like you too really look at are the example confirmation link templates under keys cz.cuni.mff.xrg.odalic.users.signup.url and cz.cuni.mff.xrg.odalic.users.reset.url. Please rewrite them to the form that your Angular-powered web client will support (is serving by webserver necessary when the hashes are used needed in order to access the token parameter?) and commit to this branch.
Please report any bugs or problems.
When you OK this and modify the UI to work with it, let me know and I will merge it to the develop.


Nagios [Epic Task 3]: Upgrade Nagios host to Ubuntu 22.04 in prep for new installation

Part of https://github.com/adoptium/infrastructure/issues/2445
Will involve attempting to bring the server up-to-date, ensuring the apache front-end and access control still works as well as the letsencrypt SSL certificate update process (Likely to hit same issues as the jenkins server did)

Apparently it has an uptime of over 1000 days:
 11:20:58 up 1032 days,  2:56,  3 users,  load average: 0.09, 0.50, 0.46

Failure in javascript-common. Unclear why it's used for so I've removed it for now:
Setting up javascript-common (11) ...
dpkg: error processing package javascript-common (--configure):
 installed javascript-common package post-installation script subprocess returned error exit status 1
Errors were encountered while processing:
 javascript-common
E: Sub-process /usr/bin/dpkg returned an error code (1)

apt-autoremove also run to clear up older things

Now on bionic 18.04.6 LTS and running another do-release upgrade ...

do-release-upgrade gave me There is no development version of an LTS available.. But do-release-upgrade -d is attempting to bring me up to the correct level.


Show popup when clicking on an individual clustered graphic

I've just come across this awesome repo (I can't believe it still isn't core functionality!) and have only looked your demo so far, not the raw code.
When clicking on a cluster icon, the individual markers in that cluster are shown, and when hovering over an individual marker you see its tooltip ("Red Rock" in this example):

I was hoping to see a popup when I click on the Red Rock graphic, similar to that seen when you click on a non-clustered graphic:

Is it possible to show the full popup when clicking on a clustered graphic? Thanks

Hey man, yeah I'm pretty sure it is possible to do. Didn't do it before as the flare graphics may also represent multiple points and the graphics are temporary. They get fully destroyed when the cluster is deactivated.
I'm doing some work on this again to make it work with v4.12, so I'll take a look at implementing this while I'm in there. Can't give a time frame though sorry.

@nickcam thank you for updating to the latest version...
If I make an interesting online system, I will share it with you first.

Other mouse-events like mouse-scrolling (probably for the same reason) also don't work. You can reproduce this by opening the https://flareclusterlayer.azurewebsites.net/index_v4.html sample, zooming in a bit on australia so that lots of screen space if occupied by the bubbles/circles and then try to zoom in/out on the map using mouse scrolling.

Yeah from memory all mouse (pointer) events are disabled over the cluster graphics. There was a good reason for this but I can't remember what is was right now. Will have to take a look when I get a chance.

@nickcam +1 for this. I also would like to show popup similar to ArcGIS 3.x Implementation Can you give some pointers, how to do that ? I will is if I can make required changes.

Finally got around to looking at this. The pointer events are only disabled over the text svg elements, so a click event on the flares works fine.
I added an event emitter to the layer that will emit an event with a Flare object as the argument. Subscribe to the event on the layer like this -
clusterLayer.on("flare-clicked", function (flare) {
   console.log('flare clicked', flare);
});

Any time you click a flare this will then get hit get. All of the data you need to make a popup appear should be in the Flare object that's passed in. If it's a flare representing only one point, then the Flare object will contain a property called singleData. This is your data object. You can use the existence of this property to test if you want to create a popup or not.
It's a bit of a cop out not creating the popup within the layer (certainly is easier), but this is bit more flexible so you can anything you want on any flare click.

Hi @apaleja, no worries - added a cluster-clicked event as well. Use it the same way as the flare-clicked event.
clusterLayer.on("cluster-clicked", function (cluster) {
    console.log('cluster clicked', cluster);
 });

@nickcam Thank very much for for quick turn around.


Collapse searchview on back pressed

Great job with this library! Very useful!
Is there a way to do this without any mess?

I sincerily don't know how it works, could you tell me something about that?
I think that you should use a custom back pattern and close the searchview if it is open.

I was thinking about that cause it's the general solution, but it says "you must not override onBackPressed method, because the library implement it on its own".

yes, Library use onBackPressed for imlement the back pattern.
Check the wiki

got it! Feel free to close this issue

Plus, can you add some feature to add the scrimm to the drawer header background?

sorry, could you explain the word 'scrimm' ?

my fault, scrim*

Well, I think that is better to keep the scrim external to this activity. You can apply it using another library or make your own scrimmer.


Demo Evaluation by Tutor

Hi Guys,
I just evaluated your demo. I am impressed :)
Great job in all the aspects: designing coherent features, features for a target user and aligning it with the value proposition and awesome UI. Kudos to the entire team. I really liked it as a whole product.
Thanks
Rrubaa

Thank you for your kind words, our team has put in a lot of effort into this project and we appreciate your encouragement. :)


Data availabiltiy

Hi @t-kuculo, @sgottsch
Is the preprocessed data available somewhere?

Hi @thak123. Yes, we have made the data publicly available on Zenodo. You can find the interface to QuoteKG and the link to the  .ttl file by following the QuoteKG link in the repository Readme. This is the Zenodo link where you can download the data:
https://zenodo.org/record/5770516


[Discussion] Keep yarn as package manager?

The project uses yarn by default. Do we want to keep yarn or do we want a consistent package-management across the @webstone ecosystem

I'm fine if we keep yarn. Ideally, we don't have to modify this gluegun fork often.


[App] Table not updating it at each call of log

I have a code for which I want to log some metadata at each step. I thought I could log this metadata in a Table, unfortunately the table is not updated on the app after the first call to log.
My code is something like
metadata = [["I love my phone", "1", "1"]]
table = wandb.Table(data=metadata, columns=["Text", "Predicted Label", "True Label"])
wandb.log({"metadata": table})

run = wandb.init(**config)
with run:
    for step in steps:
        ## some code
        table.add_data(*metadata)
        run.log({"examples": table})

On the app, I can only see the initial table with data no rows are added to it.
Note that the corresponding artifact is also not updated. Maybe this is due to wandb assigning the same identity to initial and updated table and not logging it again?

Hi @oumarkaba, can you share a link to the artifact where this is happening?

Here it is : https://wandb.ai/movie-recs-team3/movie-recs/artifacts/run_table/run-19tmgyz5-metadata/2c18e2476e1d0e420924

A work around I've just found is creating a new instance of a Table which contains the same columns and data as the old one, and logging that.
new_table = wandb.Table(
    columns=self.wandb_table.columns, data=self.wandb_table.data
)
self.wandb.log({"predictions": new_table}, commit=False)

Before doing this, it would only create a single json for the table in the RUN_DIR/files/media/table folder, but now it's making one for each time this command is run.
Maybe this can help narrowing down the problem?

Hi @amitkparekh is this one of tables that weren't updating properly?

Hi @amitkparekh is this one of tables that weren't updating properly?

Sorry, no it isn't the same tables.
On my own project, I've been having the same issue where after logging an instance of wandb.Table once, all future "wandb.log's" are ignored.
I am following the same logic outlined above by @oumarkaba: creating a table at the start, then adding data and logging it each epoch.
It seems that after the first time you log a table, logging that same instance of the table, with or without any data changes does nothing. Looking within the local files for the run, no new table artifacts are created after the first logging, so it might be something in the client-side code preventing it from being updated?
Using the workaround, where I just log a newly created wandb.Table instance using the same columns and data from the table within the state, it works properly — creating the local table artifact files and updating the dashboard as expected.

For completeness, I am using allennlp and have extended their WandBCallback. This is the full module of the callback I am using.

I'm creating the wandb.Table instance on start
I update the table at the end of each epoch
I create a new instance of the table and log the new instance, just as in the the above workaround, and then discard the new instance to save on memory.

import logging
from typing import Any

import wandb
from allennlp.training import GradientDescentTrainer
from allennlp.training.callbacks import TrainerCallback, WandBCallback

logger = logging.getLogger(__name__)

def get_training_stage_from_key(key: str) -> str:
    if key.startswith("training"):
        return "training"
    if key.startswith("validation"):
        return "validation"
    return "unknown"

@TrainerCallback.register("alt_wandb")
class AltWandBCallback(WandBCallback):
    def on_start(
        self,
        trainer: GradientDescentTrainer,
        is_primary: bool = True,
        **kwargs: Any,
    ) -> None:
        if not is_primary:
            return None

        super().on_start(trainer, is_primary, **kwargs)

        # Create prediction table
        columns = ["epoch", "stage", "task", "prediction", "target"]
        self.wandb_table = wandb.Table(columns=columns)

    def on_epoch(
        self,
        trainer: GradientDescentTrainer,
        metrics: dict[str, Any],
        epoch: int,
        is_primary: bool = True,
        **kwargs: Any,
    ) -> None:
        if not is_primary:
            return None

        self._log_predictions_table(metrics, epoch)

        filtered_metrics = {
            name: metric for name, metric in metrics.items() if "__" not in name
        }

        super().on_epoch(trainer, filtered_metrics, epoch, is_primary, **kwargs)

    def _log_predictions_table(self, metrics: dict[str, Any], epoch: int) -> None:
        prediction_metric_keys = {"training__predictions", "validation__predictions"}

        for key in prediction_metric_keys:
            if key not in metrics.keys():
                continue

            stage = get_training_stage_from_key(key)

            for task_prediction in metrics[key].values():
                logger.info(f"Adding data for {task_prediction}")
                self.wandb_table.add_data(epoch, stage, *task_prediction)

        new_table = wandb.Table(
            columns=self.wandb_table.columns, data=self.wandb_table.data
        )

        self.wandb.log({"predictions": new_table}, commit=False)

Hi @amitkparekh @oumarkaba ,
I was curious about the nature of this bug, does the table not log at all after the first call to log, or does it eventually end up uploading (e.g. from the call to finish)?
Thanks,
Ramit

So after the first log, any future logs do not do anything.
It's like for the given instance of table, it will only ever be uploaded once.
That's why my workaround solution was to continue adding rows to the table as described in the help, but I log a brand new instantiation of Table using the columns and data from the old one.
It's quite a bit of an overhead but I guess it's the best solution for now?

Thanks for the explanation! This seems to be a bug our end then. I was hoping that the call to finish would sync everything up, since finish is generally responsible to sync up larger data objects in order to not slow down the model's training.
I'm going to make an internal ticket regarding this. In the meanwhile, would using add_data instead of logging repeatedly and then having a single call to log at the end of your program work with your use case? I realize that you will not be able to visualize the table during training, but this should significantly improve the overhead and you should be able to still view the table once your training job is over.
Thanks,
Ramit

I experienced the same problem.
It turns out that the tables are being updated when I look at the artifacts section - there is a new version under the artifact, and I can view the table by going to Files --> {path_to_table} --> {table_name.json}.
But for some reason it is not updating in the UI.

Hello! I am also experiencing the same issue. In the first log call, the table is logged, but any future log calls with an updated table (updated via add_data) does not display the updated data in the UI. I also do not find any of the updated rows in the artifacts section.

I am also experiencing this issue.

I tested this; table.add_data(...) does NOT change the table data at all after the initial call.

@ramit-wandb just wanted to check if there was any update to this issue! Thanks a lot.

Hi! We are still working on this issue - this requires a large refactor to our logic of how we handle tables due to which this is something which has not been implemented yet. I'll post back here once I have some some good news about the progress of this feature!

Got it- maybe the blog post/docs here should be updated if this feature doesn't work for now, then?

The documentation here also caused me to believe that add_data did something.
And here https://docs.wandb.ai/guides/data-vis/log-tables#log-a-table-to-a-run
Please do fix the doc if the actual fix is going to take time.

The specific use-case of interest to me is to log ~100 numbers (layer statistics, say) per minibatch.

Hi Just to chime in:
I found this page because I'm trying to use the Embeddings Projector but am noticing that my embeddings aren't updating as my model trains (unlike all the other graphs & media I log). Instead only the first set of embeddings is displayed. And unlike the Audio media, there's no "Step=" slider under the embedding graph.
In my case, I'm using PyTorch Lightning's WandB logger, which ...as I say.. I able to log Audio and various graphs that all change.  (Thus this seems like it could be more a WandB problem than a Lightning problem.)
In my code, I just add to the big log_dict that is getting pushed to wandb every n epochs...
           # add Audio media to log_dict...

           # create my df  table of embeddings

          # and then add the table to the log dict
            log_dict[f'embeddings'] = wandb.Table(columns=df.columns.to_list(), data=df.values)

           # log to wandb
            trainer.logger.experiment.log(log_dict, step=trainer.global_step)

Any updates on this 6 months later?

Following - i'm facing this same error

Still same issue. Why is it not resolved yet?

I noticed if you call print(table.data) the values there have actually been updated.

This is still a problem. And same with confusion matrices. I really don't understand how this hasn't been fixed yet -_-

@khasmamad99 Doing this will come with a lot of network communication, and sending the whole table each time to wandb?
I also have this issue...

Doing this will come with a lot of network communication, and sending the whole table each time to wandb?

That's true. Why is that a problem?
This is all hacky but you can add a counter and log only every so many times. What else you can do is, you can "empty" the table every so many times and start logging with a new id.

Also facing this issue.

Same here

I am surprised this is still not fixed over a year after being raised.
The docs here are quite misleading, as they give the impression that it's possible to incrementally log text during training. However, it's not possible to do that with weights and biases at the moment. Having to set up the workarounds for this adds an annoying amount of friction when setting up WandB logging for training with LLMs.

faced with the same issue, would be nice to have a fix

Still facing the same issue.

faced with the same issue!!!!

A work around I've just found is creating a new instance of a Table which contains the same columns and data as the old one, and logging that.
new_table = wandb.Table(
    columns=self.wandb_table.columns, data=self.wandb_table.data
)
self.wandb.log({"predictions": new_table}, commit=False)

Before doing this, it would only create a single json for the table in the RUN_DIR/files/media/table folder, but now it's making one for each time this command is run.
Maybe this can help narrowing down the problem?

As of March 14, 2024, this is THE MOST correct trick.
Although this trick seems to require repeated copies of memory and writes to files.  But believe me, it's the best solution "right now".

Here are some explain of why above tricks works.
in the file wandb/sdk/data_types/utils.py:143

when you first call wandb.log(table), it will

What happened when we call table.add()   wandb.log(table) twice?
Here is what happened:

After the file creation, payload[key] records the file path, ncols, nrows ....., but in the picture we can see that the nrows=2 but the table_key_0_28...table.json only contains 1 row.
Which means there is no further file update except the first time we call wandb.log(table).

A work around I've just found is creating a new instance of a Table which contains the same columns and data as the old one, and logging that.
new_table = wandb.Table(
    columns=self.wandb_table.columns, data=self.wandb_table.data
)
self.wandb.log({"predictions": new_table}, commit=False)

Before doing this, it would only create a single json for the table in the RUN_DIR/files/media/table folder, but now it's making one for each time this command is run.
Maybe this can help narrowing down the problem?

As of March 14, 2024, this is THE MOST correct trick.
Although this trick seems to require repeated copies of memory and writes to files. But believe me, it's the best solution "right now".

This can be combined with table concatenation so that each time you log you only log a single row (which creates n tables) but then concatenate the results into a single table.
The above code snippet can be modified to:
...
 your_table = wandb.Table(columns=your_column_names)
...
in your training loop:
    do stuff...
    your_table.add_data(<your_data_2_add>)  # add the single row

    # reinit the table without the data ready for next loop
    your_table = wandb.Table(columns=results_table.columns)

The concatenation can be done using the weave snippet provided by @scottire
runs[0].loggedArtifactVersions.map((row, index) => row.file("{table key>.table.json"))
Noting to update the <table key>
Upside of this work around is only need to update data for a single row rather than duplicating the entire table, downside is you get n tables
It would be nice to have a run.log_row(table_row) function which appends a single row to a single table.

Here are my 2 cents...
Despite @Junyi-99's and @podgorki's implementations do create n tables, @podgorki's suggestion creates n tables with a length of one row. However, @Junyi-99's implementation creates n tables with incremental size (accordingly if you are logging a new row per loop). This approach can be more memory-efficient for large datasets since it avoids storing duplicate data for previously logged rows.

Just a side note, besides logging a new table each iteration (or epoch) with the same name, I had to create a new "Query" panel as discussed above. I could not just rely on the default "Table" section that would appear, since that would have lots of duplicate tables, presumably one each time a new table is logged under the same name. But when I created a query with, e.g. run.summary.["my_table"], it only shows the table once. Each run logs its best results to "my_table" each epoch, and all runs show up in that query as expected.

How is this still an issue? The feature was first proposed back in 2021, and it's already 2024! Is it really such a difficult problem for the WandB team to solve?

Here is how I fix it:
global_table = wandb.Table(...)

for i in range(iterations):
     # create a new table copied from old table
     current_table = wandb.Table(columns=global_table.columns, data=global_table.data)
     current_table.add_data(...)
     wandb.log('table', current_table)
     # manually pass the latest table to the global table
     global_table = current_table

works for me with python=3.11.10 and wandb=0.18.7


update GBD to 1.3.0

https://github.com/alphagov/paas-docker-cloudfoundry-tools/issues/115

I see this was already merged in. Disregard


Memory and mavlink problems pixhawk v2

I noticed that my pixhawk v2 was having some problems, so I hooked up the console in telem 4/5.
What I see at random are different problems:

Memory problems: this warning comes out "WARNING   WARNING   WARNING!
Revision A has a silicon errata:
This device can only utilize a maximum of 1MB flash safely!
https://docs.px4.io/en/flight_controller/silicon_errata.html" but I havn't found any way to fix it.
And it's not only a warning because later this happens:

"nsh: mount: mount failed: Out of memory
nsh: mkfatfs: mkfatfs failed: Out of memory"

Mavlink problems: I have a custom "extras" script to launch mavlink instances. In particular the script is the following:

mavlink stop-all
#ESP
#mavlink start -r 20000 -b 921600 -d /dev/ttyS0
#USB
mavlink start -d /dev/ttyACM0 -b 1000000 -m custom
mavlink stream -d /dev/ttyACM0 -s HEARTBEAT -r 2
mavlink stream -d /dev/ttyACM0 -s ATTITUDE_QUATERNION -r 50
mavlink stream -d /dev/ttyACM0 -s ATTITUDE -r 10
mavlink stream -d /dev/ttyACM0 -s HIGHRES_IMU -r 50
mavlink stream -d /dev/ttyACM0 -s GPS_RAW_INT -r 5
mavlink stream -d /dev/ttyACM0 -s GLOBAL_POSITION_INT -r 50

what happens sometimes at random is this error:
"INFO  [mavlink] all instances stopped
INFO  [mavlink] mode: Custom, data rate: 50000 B/s on /dev/ttyACM0 @ 1000000B
ERROR [mavlink] could not open /dev/ttyACM0
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
"
I really don't know where to start fixing it. Can it be all related to memory issues? Why isn't it able to open /dev/ttyACM0 sometimes?
PS: I tried to update the bootloader with https://docs.px4.io/v1.9.0/en/advanced_config/parameter_reference.html#SYS_BL_UPDATE without any success.

You're running out of RAM. You need to either stop some modules (unused mavlink instances for example), or get newer hardware with more RAM (e.g Pixhawk 4)
The Silicon Errata warning is about Flash, and is unrelated to the issues you're seeing.

But it's standard px4 1.9.2 code.
There should be a warning that it is unusable on pixhawk v2.

BTW "free" returns:
nsh> free
total       used       free    largest
Umem:       238064     170320      67744      64576

Can you post logs from before and after your extras script runs?
@dagar FYI

Case 1 (happening at random, can't open ACM0):
FMUv2 ver 0x8 : Rev 0 V2
[boot] Fault Log info File No 4 Length 3177 flags:0x01 state:1
[boot] Fault Log is Armed
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
HW arch: PX4_FMU_V2
HW type: V2
HW version: 0x00090008
HW revision: 0x00000000
FW git-hash: 106905871d374c125730fe675266d67c7f869469
FW version: Release 1.9.2 (17367807)
OS: NuttX
OS version: Release 7.28.0 (119275775)
OS git-hash: 423371c7d4012e725ac4ca51323a18df64e581b3
Build datetime: Jul  9 2019 13:47:06
Build uri: localhost
Toolchain: GNU GCC, 7.2.1 20170904 (release) [ARM/embedded-7-branch revision 255                          204]
PX4GUID:<PHONE_NUMBER>00313235333432470a00280019
MCU: STM32F42x, rev. A

WARNING   WARNING   WARNING!
Revision A has a silicon errata:
This device can only utilize a maximum of 1MB flash safely!
https://docs.px4.io/en/flight_controller/silicon_errata.html

[hardfault_log] Fault Log is Armed
INFO  [tune_control] Publishing standard tune 1
INFO  [param] selected parameter default file /fs/mtd_params
Board defaults: /etc/init.d/rc.board_defaults
rgbled on I2C bus 1 at 0x55 (bus: 100 KHz, max: 100 KHz)
nsh: rgbled_ncp5623c: command not found
nsh: rgbled_pwm: command not found
nsh: blinkm: command not found
Board sensors: /etc/init.d/rc.board_sensors
HMC5883_I2C on I2C bus 1 at 0x1e (bus: 100 KHz, max: 400 KHz)
nsh: lis3mdl: command not found
nsh: ist8310: command not found
WARN  [hmc5883] no device on bus 2 (type: 1)
WARN  [mpu6000] no device on bus #3 (SPI1)
MPU6000 on SPI bus 1 at 4 (1000 KHz)
WARN  [mpu6000] no device on bus #5 (SPI4)
INFO  [mpu9250] Bus probed: 3
WARN  [mpu9250] probe failed! 104
WARN  [mpu9250] no device on bus 3
INFO  [mpu9250] Bus probed: 5
WARN  [mpu9250] probe failed! 0
WARN  [mpu9250] no device on bus 5
L3GD20 on SPI bus 1 at 1 (11000 KHz)
LSM303D on SPI bus 1 at 2 (11000 KHz)
MS5611_SPI on SPI bus 4 at 3 (20000 KHz)
WARN  [ms5611] no device on bus 4
MS5611_SPI on SPI bus 1 at 3 (20000 KHz)
nsh: bst: command not found
ERROR [param] Parameter SENS_EN_BATT not found
ERROR [param] Parameter SENS_EN_MB12XX not found
ERROR [param] Parameter SENS_EN_PGA460 not found
ERROR [param] Parameter SENS_EN_SF1XX not found
ERROR [param] Parameter SENS_EN_TRANGER not found
ERROR [param] Parameter TRIG_MODE not found
ERROR [param] Parameter UAVCAN_ENABLE not found
INFO  [mavlink] mode: Config, data rate: 800000 B/s on /dev/ttyACM0 @ 57600B
Starting Main GPS on /dev/ttyS3
Starting MAVLink on /dev/ttyS1
INFO  [mavlink] mode: Normal, data rate: 1200 B/s on /dev/ttyS1 @ 57600B
INFO  [px4io] default PWM output device
INFO  [init] Mixer: /etc/mixers/quad_x.main.mix on /dev/pwm_output0
INFO  [init] Mixer: /etc/mixers/pass.aux.mix on /dev/pwm_output1
ERROR [param] Parameter CAM_CAP_FBACK not found
ERROR [param] Parameter WEST_EN not found
px4flow [370:100]
INFO  [px4flow] scanning I2C buses for device..
Addons script: /fs/microsd/etc/extras.txt
INFO  [mavlink] waiting for instances to stop
.INFO  [mavlink] exiting channel 0

INFO  [mavlink] all instances stopped
INFO  [mavlink] mode: Custom, data rate: 50000 B/s on /dev/ttyACM0 @ 1000000B
ERROR [mavlink] could not open /dev/ttyACM0
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
WARN  [mavlink] mavlink for device /dev/ttyACM0 is not running
ERROR [param] Parameter UAVCAN_ENABLE not found
INFO  [logger] logger started (mode=all)

NuttShell (NSH)

Case 2 (happening at random, out of memory):
FMUv2 ver 0x8 : Rev 0 V2
[boot] Fault Log info File No 4 Length 3177 flags:0x01 state:1
[boot] Fault Log is Armed
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
HW arch: PX4_FMU_V2
HW type: V2
HW version: 0x00090008
HW revision: 0x00000000
FW git-hash: 106905871d374c125730fe675266d67c7f869469
FW version: Release 1.9.2 (17367807)
OS: NuttX
OS version: Release 7.28.0 (119275775)
OS git-hash: 423371c7d4012e725ac4ca51323a18df64e581b3
Build datetime: Jul  9 2019 13:47:06
Build uri: localhost
Toolchain: GNU GCC, 7.2.1 20170904 (release) [ARM/embedded-7-branch revision 255204]
PX4GUID:<PHONE_NUMBER>00313235333432470a00280019
MCU: STM32F42x, rev. A

WARNING   WARNING   WARNING!
Revision A has a silicon errata:
This device can only utilize a maximum of 1MB flash safely!
https://docs.px4.io/en/flight_controller/silicon_errata.html

nsh: mount: mount failed: Out of memory
INFO  [tune_control] Publishing standard tune 16
nsh: mkfatfs: mkfatfs failed: Out of memory
INFO  [tune_control] Publishing standard tune 2
INFO  [param] selected parameter default file /fs/mtd_params
Board defaults: /etc/init.d/rc.board_defaults
WARN  [dataman] Could not open data manager file /fs/microsd/dataman
ERROR [dataman] dataman start failed
rgbled on I2C bus 1 at 0x55 (bus: 100 KHz, max: 100 KHz)
nsh: rgbled_ncp5623c: command not found
nsh: rgbled_pwm: command not found
nsh: blinkm: command not found
Board sensors: /etc/init.d/rc.board_sensors
HMC5883_I2C on I2C bus 1 at 0x1e (bus: 100 KHz, max: 400 KHz)
nsh: lis3mdl: command not found
nsh: ist8310: command not found
WARN  [hmc5883] no device on bus 2 (type: 1)
WARN  [mpu6000] no device on bus #3 (SPI1)
MPU6000 on SPI bus 1 at 4 (1000 KHz)
WARN  [mpu6000] no device on bus #5 (SPI4)
INFO  [mpu9250] Bus probed: 3
WARN  [mpu9250] probe failed! 104
WARN  [mpu9250] no device on bus 3
INFO  [mpu9250] Bus probed: 5
WARN  [mpu9250] probe failed! 0
WARN  [mpu9250] no device on bus 5
L3GD20 on SPI bus 1 at 1 (11000 KHz)
LSM303D on SPI bus 1 at 2 (11000 KHz)
MS5611_SPI on SPI bus 4 at 3 (20000 KHz)
WARN  [ms5611] no device on bus 4
MS5611_SPI on SPI bus 1 at 3 (20000 KHz)
nsh: bst: command not found
ERROR [param] Parameter SENS_EN_BATT not found
ERROR [param] Parameter SENS_EN_MB12XX not found
ERROR [param] Parameter SENS_EN_PGA460 not found
ERROR [param] Parameter SENS_EN_SF1XX not found
ERROR [param] Parameter SENS_EN_TRANGER not found
ERROR [param] Parameter TRIG_MODE not found
ERROR [param] Parameter UAVCAN_ENABLE not found
INFO  [mavlink] mode: Config, data rate: 800000 B/s on /dev/ttyACM0 @ 57600B
Starting Main GPS on /dev/ttyS3
Starting MAVLink on /dev/ttyS1
INFO  [mavlink] mode: Normal, data rate: 1200 B/s on /dev/ttyS1 @ 57600B
ERROR [mavlink] DM_KEY_MISSION_STATE lock failed
ERROR [mavlink] offboard mission init failed (-1)
INFO  [px4io] default PWM output device
INFO  [init] Mixer: /etc/mixers/quad_x.main.mix on /dev/pwm_output0
INFO  [init] Mixer: /etc/mixers/pass.aux.mix on /dev/pwm_output1
ERROR [param] Parameter CAM_CAP_FBACK not found
ERROR [param] Parameter WEST_EN not found
px4flow [350:100]
INFO  [px4flow] scanning I2C buses for device..
ERROR [param] Parameter UAVCAN_ENABLE not found
INFO  [logger] logger started (mode=all)
INFO  [logger] log root dir created: /fs/microsd/log

NuttShell (NSH)

What's on you SD card? Can you format it and try again?

What's on you SD card? Can you format it and try again?

There are only extras and logs.
Formatted it now with no luck.

All the errors involve the sdcard. What size is it? How is it formatted? Do you have another you can try?

nsh: mount: mount failed: Out of memory
mkfatfs: mkfatfs failed: Out of memory
WARN  [dataman] Could not open data manager file /fs/microsd/dataman
ERROR [dataman] dataman start failed

All the errors involve the sdcard. What size is it? How is it formatted? Do you have another you can try?

nsh: mount: mount failed: Out of memory
mkfatfs: mkfatfs failed: Out of memory
WARN  [dataman] Could not open data manager file /fs/microsd/dataman
ERROR [dataman] dataman start failed

It's a Kingstone 4Gb that ships with pixhawk.
BTW I switched it with a newer one 16 Gb, and it seems solved.
I'll keep you updated if it happens again. Thanks for the input.

mmm I said hurray too early. The problem is still there. It worked 3 reboots and now again at random.
I'm starting to think it's some hardware failure on the pixhawk.

@tuloski can you see the log output when it fails?

@tuloski can you see the log output when it fails?

In the SD?

No, that would be with a console connected: https://dev.px4.io/en/debug/system_console.html

Yes, actually what I wrote in Case1 and Case2 are console outputs. Also when it fails I see it.

Oh, sorry I missed that.

Adding some usleep of 0.5s here and there in the extras.txt seems to solve the issue.
Still not clear what the real issue is.

Adding some usleep of 0.5s here and there in the extras.txt seems to solve the issue.
Still not clear what the real issue is.

That's odd though because when it fails it doesn't even mount the SD card (from what I see in the log above).


bathymetrically, authoritarians

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[a,b]

/trunk merge


VariantParser issue: layout and snap/grid settings not loaded on startup.

Currently happening in  be1f2a0 , but the error started a couple days ago. The position of the inspector (which I usually move to the same space as filesystem to form two tabs and free space to the right) is reset every time the project is opened, where it will return to its default position at the right of the 2D/3D/Script editor components.
While only a minor near-cosmetic issue, it used to remember the setting before, so I assume something went wrong with the recent config file changes?
EDIT: It seems some other settings like snap/grid settings aren't getting saved either. Should this be renamed to a general config file thing?

The docks issue is a duplicate of #3186. It seems to be a bug with the new VariantParser, so renaming it to specify the general problem makes sense.

Hm, seems the other issue doesn't mention snap/grid settings, so I'll put some emphasis on that. If it's preferred, I can comment on that issue about the snap/grid settings and close this one.

i think this is fixed now, please test

I just tested it, it is fixed!

Doesn't work for me. At least, not entirely. One of my scenes will start with grid and snap but no pixel snapping, while the main scene will always start without grid, snap or pixel snapping. Setting them and restarting has no effect.
I double checked in case my build was wrong, since I still get a couple of supposedly fixed bugs, but it's apparently current with no git or build errors.

I double checked in case my build was wrong, since I still get a couple of supposedly fixed bugs, but it's apparently current with no git or build errors.

Maybe check that you run the binary in bin/ that corresponds to the target you build? I often found myself running an older release_debug or debug binary when trying to test a new commit.

Yeah, made sure to run "scons platform=x11 bits=64 target=release_debug -j4 -c" first, and the binary's modified date is from minutes ago. The process is automated in my system, but since neikeq says it's fixed, that made me question it, and that's why I double-checked.
Actually, where are these settings saved? I don't seem to find them in editor_settings.xml or engine.cfg, are they scene settings? That might explain why, even if the setting is not currently remembered, a few scenes have grid+snap while others don't. Although none seems to be remembering pixel snap regardless.

Reopening while we investigate.

Thank you. Let me know if there's something I can/must do for debugging.

Just checked again and it remembers the options fine for me. However, it doesn't remember options in the Transform menu of the 3D view (could be a separated issue though).
These settings seems to be saved in (unix) ~/.godot/config/ProjectName-md5path/scene_file-editstate-md5path.cfg
Example with the Platformer 2d demo:
~/.godot/config/platformer-md5path/stage.xml-editstate-md5path.cfg
[editor_states]

2D={ "ofs":Vector2( -1159.71, 491.491 ), "snap_grid":true, "snap_offset":Vector2( 0, 0 ), "snap_pixel":true, "snap_relative":false, "snap_rotation":false, "snap_rotation_offset":0, "snap_rotation_step":0.261799, "snap_show_grid":true, "snap_step":Vector2( 64, 64 ), "zoom":0.397214 }
3D={ "ambient_light_color":Color( 0.15, 0.15, 0.15, 1 ), "default_light":true, "default_srgb":false, "deflight_rot_x":0.942478, "deflight_rot_y":0.628319, "fov":45, "show_grid":true, "show_origin":false, "viewport_mode":1, "viewports":[ { "distance":18.6438, "listener":true, "pos":Vector3( 0, 0, 0 ), "use_environment":false, "use_orthogonal":false, "x_rot":0.575, "y_rot":-0.3625 }, { "distance":4, "listener":false, "pos":Vector3( 0, 0, 0 ), "use_environment":false, "use_orthogonal":false, "x_rot":0, "y_rot":0 }, { "distance":4, "listener":false, "pos":Vector3( 0, 0, 0 ), "use_environment":false, "use_orthogonal":false, "x_rot":0, "y_rot":0 }, { "distance":4, "listener":false, "pos":Vector3( 0, 0, 0 ), "use_environment":false, "use_orthogonal":false, "x_rot":0, "y_rot":0 } ], "zfar":500, "znear":0.1 }
Anim={ "visible":false }

Interesting. My default scene is named debug.xscn, and there's no config for it with the rest, and ...
Wait, I lie. Settings seem to be created when saving the scene, despite being marked as unchanged, meaning you can touch those settings and close the scene without it being considered a "change", therefore it doesn't get saved. After forcing a save of the scene it does seem to be properly applied.
Has this changed since before? It feels those used to be more global settings (like, once you enabled pixel snap once, you didn't need to set it again for other scenes), but my memory is spectacularly bad. Since my default scene didn't have a config until now, I assume those were globally applied...? It did have grid+snap+pixel snap until the original bug happened.
Anyway, I digress. Seems the bug is actually fixed, just with that odd caveat of requiring a save to create config files. Perhaps they should count as a change in the scene?

IMO it's fine to have to save the scene for such changes to be taken into account. You rarely open a scene just to change its snapping behaviour and then close it :) And it's important to be able to have different settings for all scenes, as you might have a scene with a 10x10 grid and another one with 64x32 for example.

Yeah, can't argue against that. Although I think it might be a good idea to consider it a change in the scene so it's always clear that it needs to be saved for it to stick. Other than that, the issue is fixed indeed.
Thanks for your help, everyone.


Implement checker for images and videos

Checking:

is image exists
if image is too big notify admin by TG


need another version of mbedtls_x509_crt_ca_cb_t for verify cert only

Description

Type: Feature Request

Enhancement\Feature Request
Justification - why does the library need this feature?
we have to bundle a hardcode CA list in app which is too bigger (200KB+)
because we can't read system root cacerts on iOS currently
Suggested enhancement
provide another version callback for ca, for example
typedef int (*mbedtls_x509_crt_ca_cb_t)( void *p_ctx,
                                         mbedtls_x509_crt const *child);

when cert is verified, return 0.
callback is only input certs and output verify result.
just like openssl's verify_callback
we can use it to wrapper ios API for verify ca with system's cacerts without bundled cacerts

Hi @okhowang,
The CA callback was introduced precisely to handle situations like the ones you describe, in which storing the set of trusted CAs in the linked list format used by Mbed TLS isn't acceptable.
Instead, you can now use the callback
typedef int (*mbedtls_x509_crt_ca_cb_t)( void *p_ctx,
                                         mbedtls_x509_crt const *child,
                                         mbedtls_x509_crt **candidate_cas );

to offload the search for a CA signing a given certificate. The verification itself is still done in Mbed TLS, which is intentional.
Please consider using this feature to search through your 200Kb+ of CA CRTs and only return the only that is deemed suitable to sign the given child CRT.
There are two further alternatives, which both involve more work and are more error prone:

Use optional verification and verify yourself. This should be the last resort.
Stick to mandatory verification, but don't register any trusted CAs and instead use the verification callback concept (https://github.com/ARMmbed/mbedtls/blob/development/include/mbedtls/x509_crt.h#L664-L670) to manually search for a trusted CA for the top of the CRT chain after Mbed TLS has completed its verification.

Cheers,
Hanno

typedef int (*mbedtls_x509_crt_ca_cb_t)( void *p_ctx,
                                         mbedtls_x509_crt const *child,
                                         mbedtls_x509_crt **candidate_cas );

using this callback has a condition that we HAVE certs. but on iOS, there is no way to get system's root certs. so we must hardcode some third-party root certs (like mozilla's) in out program. It's a little different with Apple's.
It can be resolved if there is a callback for verify peer cert only(not provide root certs for mbedtls to verify peer cert).

Hi @okhowang,
Have you considered the other options I mentioned?
Regards,
Hanno

the other options means this?

Use optional verification and verify yourself. This should be the last resort.

does it means that I will do as below ?

connect tls with authmode MBEDTLS_SSL_VERIFY_OPTIONAL
after handshake, call mbedtls_ssl_get_peer_cert to get peer cert
call system's cert verify function with peer cert from mbedtls_ssl_context

In general questions like this should be asked on the list (https://lists.trustedfirmware.org/mailman/listinfo/mbed-tls). Given Hanno has not responded for 10 days, I'm closing here.


Manage ownership properly

[x] Only auto-run migration for GM.
[x] Only allow editing of PDF if owner of the associated actor.

All fields are disabled if not owner of displayed Document

Implemented in 0.18.0


lodash@latest can break projects using yarn since yarn lockfile is not being maintained

If lodash releases a major version that breaks any API changes that this repo relies on, consuming repos that use yarn will cause this library to break.
Can a yarn lock file get added to the project? An alternative would be to just lock the lodash version in the package.json itself.
You will otherwise see an error message like the one below if using yarn and other dependencies that rely on lodash:
warning Pattern ["lodash@latest"] is trying to unpack in the same destination "/root/yarn-cache/v1/npm-lodash-4.17.5-99a92d65c0272debe8c96b6057bc8fbfa3bed511" as pattern ["lodash@^4.17.4","lodash@^4.17.4","lodash@^4.2.0","lodash@^4.17.4","lodash@^4.2.0","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.14.0","lodash@^4.13.1","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.17.4","lodash@^4.17.4","lodash<EMAIL_ADDRESS>This could result in non-deterministic behavior

Also, lodash is not so useful since source code only uses isFunction function.

Closing because I didn't realize yarn doesn't actually use the lockfile for dependencies.


IsoBands Part-2: Add support in Contour Layer.

For #2180
NOTE: stacked on top of #2429

Background

Add support in ContourLayer for rendering Isobands using SolidPolygon layer. (CPU)
Update contour utility methods to generate polygons for Isobands.
Update API and update documentation. (non breaking API change)
Add rendering tests and add new examples layer-browser.

Change List

IsoBands Part-2: Add support in Contour Layer

Not in this PR: maybe add a bench test for performance?

Yeah sure, once GPU version is ready.


Update a link to updated REST API from Viewing a project's contributors

Why:
Closes #19099
Probably follows up the restructure of REST API documentation noticed as below:

We've recently moved some of the REST API documentation. If you can't find what you're looking for, you might try the new Branches, Collaborators, Commits, Deploy Keys, Deployments, GitHub Pages, Releases, Metrics, Webhooks REST API pages.

What's being changed (if available, include any code snippets, screenshots, or gifs):
Link source

Link target

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Signed-off-by: Takuya Noguchi<EMAIL_ADDRESS>

@tnir Thanks so much for opening a PR and linking it to your issue! I'll get this triaged for review :zap:


Standalone localized time ago statements

I’d like Time from now and Time to now to have a standalone flag.
in a day
a few seconds ago

would be
In a day
A few seconds ago

Couldn't you just apply the casing yourself?
FWIW, it wouldn't be valid English to capitalize like that, since they are not complete sentences.

I don’ know the capitalization rules of every language
I didn’t assert that it needs to be grammatically correct.

See also #2710 (opposite problem with .calendar()), #2192 (similar discussion), #1201 (long similar discussion, though again about .calendar()).
I'll say three things:

We don't know the capitalization rules for all languages either.
The conclusion of #1201 was that this wasn't a good idea.
Given those, this lower case setup seems best

Unless @ichernev has changed his mind since #1201, we wouldn't even accept a PR that did this. But if he has changed his mind, then we'd need a PR that a) added a way to capitalize differently in different in different languages and b) an implementation of it for every locale we support.
Since none of that seems likely, I'm closing this.


Unable to save variant, #1843

Correction of #1843 :
When Save (SPOS) is pressed, make the controls invisible (abapGit HTML), before the system displays the program variant screen.
Before the selection screen is displayed (after leaving the program variant screen), make the controls visible again.

Thanks 👍
closing, fixed with https://github.com/larshp/abapGit/pull/1855 instead


Let CLI help messages accord to the guidelines

There are guidelines how usage strings on the CLI should be formatted: https://en.wikipedia.org/wiki/Command-line_interface#Command_description_syntax
Tanka does not accord to them, but should.
Somebody might want to grep -R "Use: the project and reformat all Use messages accordingly.
Help is welcome!

If you don't mind i am on it


Rate limiting or priority control to restrict the resource consumption while restart the whole pulsar cluster

Suppose on some corner-cases, the operators need to restart the whole cluster while the consumers and the producers are still working.  Can I set come configs to prevent loading all the topics that may take a big bite of the resource pool and also do the harms to the most important service that should be restart asap?
It might potentially be useful that add a mechanism which could limit the rate of the topics in the loading stage, and a priority queue to guarantee the most import topics to be loaded as fast as there is enough resource.

Closed as stale. Please create a new issue if it's still relevant to the maintained versions.


[Support] Move Victor AWS Account to use Cloudbank

The Freshdesk ticket link
https://2i2c.freshdesk.com/a/tickets/1369
Ticket request type
Other
Ticket impact
🟨 Medium
Short ticket description
Victor now has money from cloudbank, and wants to use it. This works by having the AWS Account move into the cloudbank organization, and we no longer have to handle their billing. This is how we manage a lot of other AWS accounts, but we haven't performed a 'move' before.
(Optional) Investigation results
This is doable in AWS: https://repost.aws/knowledge-center/organizations-move-accounts.
However, this requires that Cloudbank doesn't have any additional restrictions on IAM or elsewhere. I've asked them to check with cloudbank and let us know. Cloudbank is going to be doing more of these for other communities we are serving (conceptually we can think of that as similar to working with NASA SMCE but for NSF), so it would be helpful to have a clear process here.

Looks like victor can get a cloudbank account, and there aren't any real restrictions on them. They're going to try and then get back to us.


[SPARK-40538] [CONNECT] Improve built-in function support for Python client.

What changes were proposed in this pull request?
This patch changes the way simple scalar built-in functions are resolved in the Python Spark Connect client. Previously, it was trying to manually load specific functions. With the changes in this patch, the trivial binary operators like <, +, ... are mapped to their name equivalents in Spark so that the dynamic function lookup works.
In addition, it cleans up the Scala planner side to remove the now unnecessary code translating the trivial binary expressions into their equivalent functions.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT, E2E

R: @hvanhovell @cloud-fan @HyukjinKwon @amaliujia

Can you also improve the Scala side testing coverage as you have update the SparkConnectPlanner?

Can one of the admins verify this patch?

Can you also improve the Scala side testing coverage as you have updated the SparkConnectPlanner?

I'll figure out to add more. Interestingly the work here is already covered by your previous patch on the where clause. Because we rely on the unresolved function call. But I'll add a negative test case.

@amaliujia it would be great if you could have another look. I added additional tests on the planner side to iron out the issue with the name parts.
Thanks

Merged to master.

late LGTM


Javascript freezing the browser

I have a weird problem - when I play around in the back end, the javascript becomes unresponsive and I can’t do anything
it got t the point that when I was updating a few articles, I had to use the quick search in 1 browser, get the edit url, open that url in a different browser, edit the article, then close the tab and start again.
Can anyone suggest a solution or the best way I can track it down - never come across this kind of problem before!

I noticed admin was freezing up today, I'm on Ghost(Pro) so I'm running the latest stable release.

thanks for the info @nuclearpengy nice to know its not just me :)

that was where I noticed the majority of freezing coming from - using the search box

that was where I noticed the majority of freezing coming from - using the search box

Freezing too sometimes, after searchbox use

Hey guys, this definitely sounds like it's an issue for some people so would you mind providing a bit more info about your setups and what the exact symptoms you experience are? We have a template for bug reports that may be useful.
Additional to what's in the bug report template it would be handy to know how many blog posts, tags, and users you have in your blog as that may be a source of the slowdown.
At the moment the auto-complete search is a rather naive client-side only approach that's not suited to very large blogs or memory constrained clients - something we're definitely aware of and that will change once we have server-side search availability.

Kevin, it's looking like the search engine start to search from the first char, and if your blog is full of posts, going to freeze for a X time.
Maybe start to search after thirt char can be a good solution.

I think we have about 137 posts

Me over 400 at this moment. But search a single char it's always a bad job.

I've located the main culprit and implemented a fix in #6285 - it would be great if any of you are able to test against that PR using a copy of your production data.

Tested right now. Working great. No freeze anymore ;-)
Thank you !

@Faber73 would you mind detailing the process you've used to test that PR branch and exactly what issue you are seeing and which interactions cause it whilst you test?
I'm currently testing against a blog with 273 posts and 49 tags and have been unable to reproduce the freezing behaviour with the mentioned fix in place but it's possible I'm still not testing against enough data or we're looking at different issues.

I've add your modification manually and lunch the grunt after it, restart cache services (I used nginx with varnish), close browser, open back, clean all data, open only the ghost admin interface, going on "Content" try to do a search, working fine. Try again with another search and working great (before start to freeze from the second search). Change page, going on General, come back to Content click on search bar, all frozen for few minutes, afetr it I'm able again to do a search.

Which grunt task are you running? From the description of the problem you are seeing it sounds as though the change isn't being picked up.

I working on my ghost code sometimes, I use it in development enviroment.
`
grunt --development
Running "shell:ember:dev" (shell) task
DEPRECATION: Node v0.10.41 is no longer supported by Ember CLI. Please update to a more recent version of Node
undefined
version: 1.13.13
BuildingBuilding.Building..Building...BuildingBuilt project successfully. Stored in "dist/".
Done, without errors.
`

To run Ghost in development the command is grunt dev which will build and launch the server in development mode. The --development flag will be ignored as it's not tied to anything, instead the default grunt task will be run which just builds the development JS files.
It sounds as though you may be building the dev files but using the production files when going through nginx. How are you booting the ghost instance that nginx talks to?

Oh mhhh maybe you right. I start ghost with a init.d script and I see now that have a "production" enviroment set into it.
Let me to set it right and test again.

Yeah ! My fault. Working great, sorry

No problem, glad the fix is working for you now :smile:

This did not fix my issue unfortunately. Even without touching the search box, I can cause it to freeze, by just playing around, no specific action I can see that is starting it. Jumping around articles in the editor is doing it too.

@brightbits could you use something like licecap to make a quick screencast showing what you're seeing? Sounds like it may be a second, separate issue and any help you can provide in tracking it down would be awesome :+1:

I've found a reproducible case when you have a lot of posts loaded in the infinite scroll list. With ~270 posts loaded, navigating between posts in the content list causes a noticeable freeze - I'm looking into what's causing that.
If the content list has a lot of loaded articles going back to the content screen from another screen also causes a momentary freeze. I think this is a rendering issue, it would be solved by using a better pagination system that only renders part of the list and re-uses dom elements on scroll.

@ErisDS I just spent a while trying to keep causing it some more, click around randomly and stuff.. it does seem to happen either directly after touching auto complete, or at some point after while clicking on other things.. I'm starting to become confident its all related to it.

@kevinansfield that sounds exactly like what was happening to me. I was reviewing some older posts. My workflow was basically, scroll right down to the bottom(oldest) of the list, open post, implement change, save, go back to content screen, scroll down to second oldest post and repeat the cycle.


Assign empty body if data is falsey.

For subsequent requests, the opts.body is set to the previous request if data is falsey. If data exists, set to stringified data otherwsie set it to empty string.

Potential fix for #9


Fixed #3487 Provide precision and scale for currency database datatype and H2.

Impact

[X] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Fixes #3487.
As explained in the companion issue, as of H2 2.0.202, the DECIMAL datatype without parameters has scale 0, thus it cannot hold any value after the decimal point.
Liquibase maps the CURRENCY database type to DECIMAL with no precision and scale for H2, which causes the values to be stored as whole numbers rather than decimal numbers.
The proposed changes include such as precision and scale.

Initial review:
Changes make sense to me and is isolated to h2
Things to be aware of:

Nothing

Things to worry about:

Nothing

You are welcome @MalloD12 Daniel, my pleasure. And thank you very much for providing the unit tests for the changes proposed in the PR.

Test harness execution started here: https://github.com/liquibase/liquibase-test-harness/actions/runs/4853288812

Thank you very much for merging this functionality.

@jccampanero
hello,  I am wondering why 18,4 not 18,2 precission ?

@jccampanero
hello, I am wondering why 18,4 not 18,2 precission ?

Thank you for the question @marwin1991 Peter.
I asked myself the same when I was implementing the change.
Initially I thought a precision of 2 would be indeed the right choice because a great amount of currencies, US dollar, euro, pound, to name some of them, have two fractions digits, i.e., they use cents or pence.
But in the end I used 4 because I think it could fit a broader amount of currencies such as cryptocurrencies.
In addition, in Liquibase other databases such as DB2 and Firebird use 4 as the default precision.
In any case, 2 is a perfect solution as well.


Bug: not enough room

I'm getting this error when I press % if the corresponding block is out of the viewport.

sounds like https://github.com/neovim/neovim/issues/19464


Add code examples to lib.rs

Problem
We got feedback from @spacejam that it would be nice to add more detailed documentation and code examples to the top level lib.rs file to improve what people are shown when they hit the create on docs.rs: https://docs.rs/pinecone-sdk/latest/pinecone_sdk/index.html
Solution
I'm still pretty new to Rust and getting my bearings with a lot of things. Any feedback around best practices for presenting code or information through the crate and rustdoc, please let me know.

Added some minimal code examples to the top level lib.rs file focused on some of the basic operations that can be done with the client.
The README.md code examples were a bit out of date with some changes we've made - also did some clean up in there.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Infrastructure change (CI configs, etc)
[X] Non-code change (docs, etc)
[ ] None of the above: (explain here)

Test Plan
I tested all of the code added to lib.rs in a local project, so I at least know it runs and compiles.

This is good cleanup. A benefit to having the examples in lib.rs is you can actually run the examples and add assert! statements to them as a part of cargo tests. That way they never get out of date.
The README.md shows up on crates.io: https://crates.io/crates/pinecone-sdk
The lib.rs docs show up on docs.rs: https://docs.rs/pinecone-sdk/latest/pinecone_sdk/
We might want to consider just linking to docs.rs in the README for most of the code examples and keep the example code docs in lib.rs as a part of the CI cargo tests to ensure the examples continue to work.
A good example might be axum:

axum lib.rs rendered on axum docs.rs
axum readme rendered on axum crates.io

Good cleanup. See previous comment for consideration.

Appreciate the callouts, I agree regarding following up and moving our code examples into the lib.rs explicitly. Created a ticket for tracking.


Try to require jsdom in a way that does not spook webpack and browserify

:+1:

Remind me to craft a release and make more people collaborators when in back at a non-phone


[BUG] cs_wallet locks not held when calling 'masternode outputs'

When giving the cli command masternode outputs, the client crashes due to locks on cs_wallet not being held.
To Reproduce

Compile a wallet with --enable-debug
Ensure you should have 20k masternode blocks in the wallet
With the cli, call masternode outputs
Result:

$ ion-cli -testnet=1 masternode outputs
Assertion failed: lock cs_wallet not held in wallet.cpp:3943; locks held:
error: couldn't connect to server

Desktop (please complete the following information):

OS: Ubuntu 18.04
Compiled from cevap/ion master commit a5d4c61ee7003f3b2e7338ca829d6167b86ee6d1
Version [e.g. 22]

Additional context
The following locks are asserted but not set in SelectCoinsMasternode():
void CWallet::LockCoin(const COutPoint& output)
{
    AssertLockHeld(cs_wallet); // setLockedCoins
    setLockedCoins.insert(output);
}

void CWallet::UnlockCoin(const COutPoint& output)
{
    AssertLockHeld(cs_wallet); // setLockedCoins
    setLockedCoins.erase(output);
}

I cant reproduce this bug, ubuntu bionic 18.04. Masternode outputs work as it is supposed to be used. I made the test only on main as testnet is unlaunched/noCoins.
Please test release binaries, I will compile in the evening master with "--enable-debug", to see if I can reproduce this bug

2 downloads, one of them my, the other from @ckti , please test it https://github.com/cevap/ion/issues/125 and other binaries too, like I said, I cant reproduce it for now with release binaries.

I tried with those gitian compiled binaries and that does not produce that error - which makes sense, because they are not compiled in debug mode. The assertion is only made in debug mode.
However, the issue remains: either the assertion isn't necessary, or the lock needs to be set before the assertion is made.

I close this issue,  #127  , open please if not resolved


[Feature] Add Engineering Cut Off Calculator

Description
Engineering admissions in Tamil Nadu are based on TNEA cut-offs. In this calculator, with the student's scores, the cut-off will be calculated. Please assign labels and assign me this issue under GSSOC 24.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Go ahead @dharshini2022

Pls provide your PR @dharshini2022

@Rakesh9100 Can you pls give 2 days. I'll submit within a couple of days

Ok but try to but complete ASAP @dharshini2022

Will close the issue by tomorrow if PR is not up @dharshini2022

Sorry for posting the PR late. I had University exams. Please review my pull request and if any changes to be made, I'm happy to work on them. It was great working on your project! Thanks for providing me with this opportunity @Rakesh9100 .


add PCT/VPR as dps

pwetty pwease make pct and vpr dps and not just random gray bars

Hey, it's already been updated. Are you using kalilistic.github.io/klondike?

oooh no i think i was using a diff one when we were having issues a few weeks ago. Removed and re-added and its there now ty <3


[KYUUBI #2281] The RenewDelegationToken method of TFrontendService should return SUCCESS_STATUS by default

Why are the changes needed?

fix #2281
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @zhouyifan279 @pan3793

Codecov Report

Merging #2286 (03caa96) into master (0ee5371) will increase coverage by 0.00%.
The diff coverage is 80.00%.

:exclamation: Current head 03caa96 differs from pull request most recent head 83a9393. Consider uploading reports for the commit 83a9393 to get more accurate results

@@            Coverage Diff            @@
##             master    #2286   +/-   ##
=========================================
  Coverage     62.26%   62.27%
  Complexity       69       69
=========================================
  Files           349      353    +4
  Lines         16723    16771   +48
  Branches       2261     2270    +9
=========================================
+ Hits          10413    10444   +31
- Misses         5354     5364   +10
- Partials        956      963    +7

Impacted Files
Coverage Δ

.../apache/kyuubi/client/KyuubiSyncThriftClient.scala
87.55% <66.66%> (-0.41%)
:arrow_down:

...a/org/apache/kyuubi/service/TFrontendService.scala
93.35% <100.00%> (ø)

.../kyuubi/credentials/HadoopCredentialsManager.scala
94.77% <100.00%> (+1.64%)
:arrow_up:

...g/apache/kyuubi/session/KyuubiSessionManager.scala
79.48% <0.00%> (-15.39%)
:arrow_down:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
75.72% <0.00%> (-6.80%)
:arrow_down:

...ache/kyuubi/operation/KyuubiOperationManager.scala
94.11% <0.00%> (-1.97%)
:arrow_down:

...ache/kyuubi/engine/spark/SparkProcessBuilder.scala
86.27% <0.00%> (-0.99%)
:arrow_down:

...ugin/spark/authz/ranger/RangerSparkExtension.scala
100.00% <0.00%> (ø)

.../plugin/spark/authz/ranger/RangerSparkPlugin.scala

...gin/spark/authz/ranger/RangerSparkAuthorizer.scala

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee5371...83a9393. Read the comment docs.

cc @zhouyifan279  @pan3793

we shall still override this at kyuubi server for keep the old behavior

@jiaoqingbo PR title should also be changed. Besides, I think we should backport this PR to branch 1.5 as the bug causes other Kyuubi engine to fail to launch. @yaooqinn @pan3793 WDYT?

Sorry, my mistake.  Branch 1.5 does not have this bug.

thanks, merged to master


[Bug] Free Shops And Chests

Both free shops and free chests don't work. The result appears only after I reboot the game.

Didn't work


AttributeError: 'Pose' object has no attribute 'pose'

In the panda_base_grasping_controller.py:
self.best_grasp.position.z = max(self.best_grasp.pose.position.z - 0.01, 0.026)
AttributeError: 'Pose' object has no attribute 'pose'
Shouldn't be without pose? like this: self.best_grasp.position.z = max(self.best_grasp.position.z - 0.01, 0.026)
I get similar error for self.pc.set_gripper(self.best_grasp.width, wait=False) because there is no width.
Am I missing something?

Can you tell me which scripts you are running? I assume that it's expecting best_grasp to be a Grasp type message, which does have all of those attributes.

Thank you! The error is not any more valid since I fixed _velo_control_loop.


dialect/sql/schema: ensure consistency of NotCleanError

For https://github.com/ariga/atlas/pull/1454

Thank you @blukai for submitting this PR. Once the Atlas one is merged, can you update the go.mod to point to the latest Atlas master together with this changes?

yup, but in a separate pr.
pr https://github.com/ariga/atlas/pull/1454 cannot be merged sooner than this one. atlas depends on ent, ent is returning NotCleanError value (not a pointer) in dialect/sql/schema.

yup, but in a separate pr. pr ariga/atlas#1454 cannot be merged sooner than this one. atlas depends on ent, ent is returning NotCleanError value (not a pointer) in dialect/sql/schema.

Ah, got it.


🚑 update peer deps to gatsby v3

Description
gatsby-plugin-netlify-identity-gotrue won't work with Gatsby V3 bc it lists v2 as a peer dependency.
Updating to Gatsby V3 should hopefully just be a matter of updating the peer deps in the package repo.
Gatsby3.0 Migration docs
Updating dependencies

Please update peer deps and let us know what else we can do to help. 👍
Fixes # (issue)
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/gatsby-plugin-netlify-identity-gotrue
npm ERR!   gatsby-plugin-netlify-identity-gotrue@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Type of change
Please delete options that are not relevant.

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

I was just looking at this and ran into the same error with a fresh Gatsby install.
Currently can't get it to install with Gatsby 3.x