[SPARK-37981][PYTHON] Add note for deleting Null and NaN

What changes were proposed in this pull request?
This is for SPARK-37981 Deletes columns with all Null as default.
This preserve columns with all values with NaN or Null to be deleted when saved to JSON.
Why are the changes needed?
This is the same behavior as pandas user are used to.
Does this PR introduce any user-facing change?
Yes, the document for to_json function is changed.
Default ignoreNullFields have been set to False as default to prevent columns with only NaN or Null to be deleted during saving to JSON.
How was this patch tested?
The linter and doc build test should be passed.

Thank your proposal @bjornjorgensen.
First of all, some formalities:

Could you enable GitHub actions  in your fork,
It would be better to have JIRA ticket that specifically targets documentation update, as the one you linked doesn't even use pyspark.pandas.

Regarding the change ‒ as-is, this doesn't really describe the actual behavior:

If path is not provided, to_json  delegates transformation to pandas, so fields with NULL are preserved.
If path is provided, standard writer is used, so the same rules apply (in particular ignoreNullFields keyword option or spark.sql.jsonGenerator.ignoreNullFields config are respected).
In both cases, behavior doesn't depend on the number of null values in the column.

Finally, you have a typo ‒ "The column well be deleted"  -> "The column will be deleted."

cc @HyukjinKwon @ueshin  FYI

Thank you for your proposal @bjornjorgensen.
First of all, some formalities:

Could you enable GitHub actions  in your fork,
It would be better to have JIRA ticket that specifically targets documentation update, as the one you linked doesn't even use pyspark.pandas.

Regarding the change ‒ as-is, this doesn't really describe the actual behavior:

If path is not provided, to_json  delegates transformation to pandas, so fields with NULL are preserved.
If path is provided, standard writer is used, so the same rules apply (in particular ignoreNullFields keyword option or spark.sql.jsonGenerator.ignoreNullFields config are respected).
In both cases, behavior doesn't depend on the number of null values in the column.

Finally, you have a typo ‒ "The column well be deleted"  -> "The column will be deleted."

Maybe something like this?

If path is provided, writer omits missing values by default. This behavior can be controlled using ignoreNullFields option.

Can one of the admins verify this patch?

I think maybe we have something for "Does this PR introduce any user-facing change?" and "How was this patch tested?" section in the PR description.
For example,
** Does this PR introduce any user-facing change? **
Yes, the document is changed.
** How was this patch tested? **
The linter and doc build test should be passed.

Added a new post at jira.
Github actions is now enabled.

Let's fix up PR title/description too with making it ready for a review. Then I think it's good to go.

Yes, about testing the only test I find for IO in pandas is for testing csv. I was thinking about making a test where I use shape function to test a file before and after writing and write. But there are another problem pandas prints a tuple with rows, columns pandas_df_json2.shape (6, 4). While pandas on spark print dataframe, columns pandas_api.shape (1, 4).

@ueshin @HyukjinKwon We should create a new ticket for this, that actually matches the problem that is solved, or at least rewrite and reopen one, to which this PR points to. I'll leave decision to you.

Yes, about testing the only test I find for IO in pandas is for testing csv. I was thinking about making a test where I use shape function to test a file before and after writing and write.

One shouldn't really depend on schema inference and reader behavior to test writer for formats which, like JSON lines, provide no schema and / or are less expressive than Spark SQL types. In general case, irrespective of options, the following
spark: SparkSession
df: DataFrame
path: str

df.write.json(path)
assert spark.read.json(path).schema == df.schema

is not, and cannot be, guaranteed.

Yeah, technically we should create a new JIRA or edit the existing JIRA.

@zero323 This PR won't have any impact on your first example because there is at least one value that is not None.  In your second example it will be without this PR.
`df = ps.DataFrame.from_dict({"id": [1, 2], "val": [np.nan, np.nan]})
df
id val
0 1 NaN
1 2 NaN
df.to_json("testdf.json", num_files=1)
df2 = ps.read_json("testdf.json/*")
df2
id val
0 1 None
1 2 None
df2.to_json("testdf2.json", ignoreNullFields=True, num_files=1)
df3 = ps.read_json("testdf2.json/*")
df3
id
0 1
1 2`
I will change what we agree on, but for now I think this has something to do with None values.

@zero323 This PR won't have any impact on your first example because there is at least one value that is not None.  In your second example it will be without this PR.

It seems like there is still some confusion regarding actual impact of the changes that are proposed here.
So let's start with establishing simple fact ‒ Spark uses row-oriented JSON lines format when JSON (that includes to_json) is used. ignoreNullFields option, by default set to true controls writer behavior when missing values are encountered:

If it is set to true,  then field is omitted in the output for a given row.
>>> import tempfile
>>> path_true_some_null = tempfile.mktemp()
>>> df_some_null = ps.DataFrame.from_dict({"id": [1, 2], "val": [None, 1]})
>>> df_some_null.to_json(path_true_some_null, ignoreNullFields=True)
>>> for x in spark.read.text(path_true_some_null).collect():
...     print(x.value)
{"id":2,"val":1.0}
{"id":1}

If it is set to false, then field is emitted with JSON null (untyped) value.
>>> for x in spark.read.text(path_false_some_null).collect():
...     print(x.value)
{"id":1,"val":null}
{"id":2,"val":1.0}

Decision is made on row-by-row basis, and is not affected by presence of missing values for the same field in any other row.
Your PR changes default behavior for pyspark.pandas JSON writer, from the former (missing values are omitted) to the latter (missing values are preserved). This impacts output, as long as there is any missing value in any field in any row. Furthermore, it can have significant (proportional to N * M, for N rows and M columns) impact in case of sparse datasets (IO cost, storage cost) in case of sparse datasets.
Finally, counting columns in the re-read dataset is simply misleading and your PR doesn't and cannot affect reader behavior (it just affects what reader "sees") and, as mentioned before, explicitly writing missing values cannot resolve the problem of properly restoring original schema. Consider the following:
>>> import numpy as np
>>> df_all_null = ps.DataFrame.from_dict({"id": [1, 2], "val": [np.nan, np.nan]})

If you write it with ignoreNullFields set true, it omits the missing values same as in the case where some not missing values are present.
>>> path_true_all_null = tempfile.mktemp()
>>> df_all_null.to_json(path_true_all_null, ignoreNullFields=True)
>>> for x in spark.read.text(path_true_all_null).collect():
...     print(x.value)
{"id":2}
{"id":1}

but there is no trace that other column was ever there.
>>> ps.read_json(path_true_all_null)
   id
0   2

Setting ignoreNullFields set false
>>> path_false_all_null = tempfile.mktemp()
>>> df_all_null.to_json(path_false_all_null, ignoreNullFields=False)
>>> for x in spark.read.text(path_false_all_null).collect():
...     print(x.value)
{"id":1,"val":null}
{"id":2,"val":null}

writes JSON nulls explicitly (same as in case of  (df_some_null), and by doing so, provides enough information for the reader to infer that some column should be present.
>>> df_all_null_read_with_false = ps.read_json(path_false_all_null)
   id   val
0   1  None
1   2  None

So, does it restore the original schema?
It doesn't. The original contained double values:

>>> df_all_null.to_spark().printSchema()
root
 |-- id: long (nullable = false)
 |-- val: double (nullable = true)

and restored one cannot make any assumptions about the types, so it defaults to strings:
>>> df_all_null_read_with_false.to_spark().printSchema()
root
 |-- id: long (nullable = true)
 |-- val: string (nullable = true)

If user requires specific schema for the frame, schema should be provided on read, which will give the same result independent of specific fields being present in the output or not
>>> ps.read_json(path_false_all_null, schema="id long, val double").to_spark().printSchema()
root
 |-- id: long (nullable = true)
 |-- val: double (nullable = true)

This is standard approach in production pipelines and, on top of consistency, provides significant performance improvements on realistic size data.
So to re-iterate:

This PR affects the output, as long as dataset contains at least one missing value, and can have significant impact on performance and storage costs.
Observed impact on reader behavior is more incidental and doesn't guarantee correct schema of the loaded data.

What this PR really achieves, is making output of to_json(some_path)
>>> path_pr_all_null = tempfile.mktemp()
>>> df_all_null.to_json(path_pr_all_null)
>>> for x in spark.read.text(path_pr_all_null).collect():
...     print(x.value)
{"id":2,"val":null}
{"id":1,"val":null}

roughly equivalent to the output to_json()
>>> df_all_null.to_json()
'[{"id":1,"val":null},{"id":2,"val":null}]'

and pandas equivalents.
I wouldn't bother with pointing all of that out, but I have enough experience with users making incorrect assumptions about Spark behavior and nature of fixes, based on misleading JIRA tickets.

@zero323 Thank you

Merged into master.
Thanks everyone!


Workflow changed and add some missing patches

Missing patches that not affected to vanilla behavior:

Jettpack: reduce allocs
Jettpack: some entity micro opts

Using gradle.properties to get version and minecraft version instead of using constants in workflow.
And please use squash commit - merge method!

This PR will ready for review after the test workflow finished

Thanks for the PR, and boy you really need to go to sleep rn


Added links to Table of Contents for Part-01

Have completed Issue #80 and have added the required links to the table of contents. It now correctly navigates to the required section on click. Also added an additional Item in Table of Contents for "Introduction"

Thank you !

Closed #80

Sorry for accidentally closing the PR, new to github


quic_multistream_test: fix undefined symbol snprintf with VS2010

As snprintf is not available everywhere, use BIO_snprintf instead.
Fixes:
        IF EXIST test\quic_multistream_test.exe.manifest DEL /F /Q test\quic_multistream_test.exe.manifest
        "link" /nologo /debug setargv.obj /subsystem:console /opt:ref  /nologo /debug @V:\_tmp\nm4.tmp
quic_multistream_test-bin-quic_multistream_test.obj : error LNK2019: unresolved external symbol _snprintf referenced in function _helper_init test\quic_multistream_test.exe : fatal error LNK1120: 1 unresolved externals NMAKE : fatal error U1077: '"E:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\link.EXE"' : return code '0x460'

This PR is part 1/3 of https://github.com/openssl/openssl/pull/24326 which has been split.
Build and run tested:

Windows 2003 x64, Windows 2003 x86, Visual Studio 2010
Windows 11 21H2, Visual Studio 2019
Ubuntu 22.04.4 LTS
macOS 14.4.1 Intel
FreeBSD-13.2-p11

@t8m @nhorman @tom-cosgrove-arm @viruscamp @levitte @paulidale @mattcaswell @hlandau
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

This pull request is ready to merge

Merged to the master, 3.3 and 3.2 branches. Thank you for your contribution.

Thanks for the help and guidance.


Updates Danger dependency to 4.x

Ensures we're green, update danger ref in bundler. bumps the version.


Error when trying to run containers on bridge network

I'm new to docker and I am trying to connect my front-end (also running in a docker container) to strapi. To do so I believe they should run on the same docker network. I've tried adding network_mode: bridge to both my services in the docker-compose.yml file to run them in the same network as my front-end.
However for some reason I now get the following error:
api_1  | [2019-08-19T19:54:51.976Z] debug ⛔ Server wasn't able to start properly. api_1  | [2019-08-19T19:54:51.976Z] error Make sure your MongoDB database is running... api_1  | Make sure your MongoDB database is running...
the logs of db_1 don't show an error and I see: waiting for connections on port 27017.
All containers are running (docker ps) and if i inspect my bridge network i do see all three services.
I'm not sure why running the db on a different network prevents it from starting, is this a bug or am I perhaps missing something else? If I run it without network_mode: bridge it runs just fine but my front-end container can't connect.
my docker-compose.yml file:

services:
  api:
    build: .
    image: strapi/strapi
    environment:
      - APP_NAME=strapi-app
      - DATABASE_CLIENT=mongo
      - DATABASE_HOST=db
      - DATABASE_PORT=27017
      - DATABASE_NAME=strapi
      - DATABASE_USERNAME=
      - DATABASE_PASSWORD=
      - DATABASE_SSL=false
      - DATABASE_AUTHENTICATION_DATABASE=strapi
      - HOST=localhost
    ports:
      - 1337:1337
    volumes:
      - ./strapi-app:/usr/src/api/strapi-app
      #- /usr/src/api/strapi-app/node_modules
    depends_on:
      - db
    restart: always
    network_mode: bridge

  db:
    image: mongo
    environment:
      - MONGO_INITDB_DATABASE=strapi
    ports:
      - 27017:27017
    volumes:
      - ./db:/data/db
    restart: always
    network_mode: bridge

Try to move db service/container as the first service and api service as the second

HI,
We just released a full rebuild of our docker image 🎉
We are closing the issues and open PRs to start fresh.
If you feel like something is missing or want to add things feel free to open new PRs ! 💯


How to get hold of subterms deep inside a Prop?

I would like to prove the following:
import data.set
namespace function
section
open set
variables {A B : Type}
definition bijective (f : A → B) := injective f ∧ surjective f
lemma injective_eq_inj_on_univ (f : A → B) : injective f = inj_on f univ :=
  begin
    esimp [injective, inj_on, univ, mem],
  end
end
end function

After esimp the goal is now:
⊢ (∀ (a₁ a₂ : A), f a₁ = f a₂ → a₁ = a₂) = ∀ ⦃x1 x2 : A⦄,
    true → true → f x1 = f x2 → x1 = x2

I can use true_imp
theorem true_imp (a : Prop) : (true → a) ↔ a

Is there a way to do it without manually breaking down the structure (with propext, iff.intro, assume ......)?

This works:
lemma injective_eq_inj_on_univ (f : A → B) : injective f = inj_on f univ :=
  begin
    esimp [injective, inj_on, univ, mem],
    apply propext,
    apply iff.intro,
      intro Pl a1 a2,
        rewrite *(propext !true_imp),
        exact Pl a1 a2,
      intro Pr a1 a2,
        assert Ptrue : true, apply true.intro,
        exact Pr Ptrue Ptrue
  end
end

I am wondering if there is a better way.

Here is a smaller one:
lemma injective_eq_inj_on_univ₃ (f : A → B) : injective f = inj_on f univ :=
  begin
    esimp [injective, inj_on, univ, mem],
    apply propext,
    repeat (apply forall_congr; intros),
    rewrite *(propext !true_imp)
  end

BTW, I've just implemented an extension that uses propext automatically in the rewrite tactic. That is, it will allow us to write rewrite true_imp instead of rewrite (propext !true_imp). I will push as soon as I finish testing it.
This kind of problem will be perfect for the bottom-up simplifier that will have in Lean. This simplifier automatically applies forall_congr and funext to go inside of binders.

I pushed the new feature.
Here is the new version for the lemma above
https://github.com/leanprover/lean/blob/master/tests/lean/run/tut_104.lean#L41-L48

Great! Good to learn repeat (apply forall_congr; intros) too. Thanks!


Adding black-parrot-subsystems

This PR adds a BlackParrot subsystem for AXI. Depends on #28 and https://github.com/black-parrot-hdk/black-parrot-subsystems/pull/2

I have confirmed this PR works with the addition of: https://github.com/black-parrot-hdk/zynq-parrot/pull/30, including booting Linux on hardware (Pynq Z2), for unicore designs.


Improve Authenticator and Provisioning Connector Metadata response display names

Describe the issue:
Display names and display names of the properties in the authenticator and provisioning connector metadata responses can be improved in ways such as,

Using camel case
Using spaces where required
etc.

How to reproduce:
Observe display names in the aforementioned metadata responses.
Expected behavior:
Proper display names should be available for better UX.

Following Authenticators Remain to be fixed:

FacebookAuthenticator
"displayName": "facebook",
TwitterAuthenticator
 "displayName": "twitter",
PassiveSTSAuthenticator
"displayName": "passivests"
SAMLSSOAuthenticator
"displayName": "samlsso"
OpenIDConnectAuthenticator
"displayName": "openidconnect"

Following Provisioning Connectors Remain to be fixed:

SCIM Provisioning Connector
"displayName": "scim"
Salesforce Provisioning Connector
"displayName": "salesforce"
Google Provisioning Connector
 "displayName": "googleapps"

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Windows x64 Image broken when attempting to use commands provided by git bash

Describe the bug
If an agent is attempting to run a bash script, and that script tries to run 'find', it attempts to run the Windows version of 'find' instead of that bash version of 'find'. This fails since those two commands take very different parameters. It results in the following output:
FIND: Parameter format not correct

I believe this a result of this PR #211
This started happening on Jan 10, 2020 after 5:45p EST
I was able to add a step to add those paths back to the PATH and my pipeline works again.

This also broke our runner builds.
I think the fix is as simple as adding a path to PATH

apologies for the delay on this, the fix is in but the rollouts have been delays for multiple unrelated reasons. We're pushing to get the latest updates out there as soon as possible!

@alepauly Is it necessary to add the directories to the PATH outside of git-bash as well? It seems my pull request has been reverted which will break chocolatey MinGW builds again. Can we solve this by adding the paths only when in git bash or do the tools have to be available outside of git-bash as well?

@DaanDeMeyer I'm guessing you're referring to #304? We kept the other cleanup you added (thanks) but adding the Git folder back addresses the issue of using the proper tools in the proper context. See @al-cheb's comment here: https://github.com/actions/virtual-environments/pull/304#issuecomment-577259228
Do you think that will still break those builds?

My bad, I must have been looking at an old version of the file. #304 seems like the perfect solution that allows both git-bash and MinGW builds to work.

Hello, @jtpetty
Could you check that the issue's been fixed?

@al-cheb - It does appear to have been resolved. Thanks!

Thanks for the helpful report and the information on this issue.

Hi,
There is still issues with git core commands.
Need to add C:\Program Files\Git\mingw64\libexec\git-core to the path as well.
For example git submodule command fails without it in the path


[ArgMax][Resize][RNNBase] Use builder based interface to generate Krnl loops

[LRN][Pooling][Loop] Use builder based interface to generate Krnl loops (Only partially done)
Signed-off-by: Whitney Tsang<EMAIL_ADDRESS>

Jenkins Linux amd64 Build #4982 [push] [ArgMax][Resize][RNNBase... started at 10:02

Jenkins Linux ppc64le Build #4119 [push] [ArgMax][Resize][RNNBase... started at 11:06

Jenkins Linux s390x Build #4998 [push] [ArgMax][Resize][RNNBase... started at 11:02

Jenkins Linux s390x Build #4998 [push] [ArgMax][Resize][RNNBase... passed after 52 min

Jenkins Linux ppc64le Build #4119 [push] [ArgMax][Resize][RNNBase... passed after 59 min

Jenkins Linux amd64 Build #4982 [push] [ArgMax][Resize][RNNBase... passed after 1 hr 4 min


Running Magic on other environment

Hello and thank you for your code.
I'd like to run MAGIC on other Gym based multi-agent environments.
After checking the code, I realized that we need to write a wrapper for the environments and overload action space, observation space, reset, step, etc. However, I have a doubt. Since MAGIC is a communication-based method. Do we also need to modify the environment to allow some sort of communication between agents?
Best regards,
Rza

Hi Rza,
Thanks for your interests in our work and codebase!
To run MAGIC on a new environment, there is no requirement to revise the environment (e.g., changing the observation or action space) to facilitate communication among agents. The communication protocol is integrated with and handled by the policy network of our method.
Having said that, you might still consider environment settings that are related to partial observability and communication, such as the permissible range of observation or allowed range of communication (which can impose a mask on the learned communication graphs).
Please let us know if you have further questions on applying MAGIC to your new environment.
Best regards,
Yaru

Thank you for your Response Yaru.
Would you please clarify what the self.stat['success'] variable does? and does it have any effect on the training of the model?
Best regards,
Reza

Hi Reza,
self.stat[''success] is used to calculate the success rate of the task (in GRF/TJ) to monitor and evaluate the model's performance, while it will not affect the model training. Please refer to get_stat, merge_stat, and run_batch to understand how the data is utilized and processed.
Best regards,
Yaru


Help Understanding StandardRTLSAnchor Code

Step 1: What do you want?

Improve code (and need help).

Step 3: Describe the problem
I'm new to GitHub, please let me know if there was a better place to ask this question. I'm working on setting up a system of these DW1000 chips to perform TWR localization. I'm struggling to understand how the anchors initially interact with one another, as I follow the code, I can't find where any of the anchors initiate communication with the others. Any idea what I'm missing here?

Affected file(s) or example(s):

StandardRTLSAnchorMain_TWR
StandardRTLSAnchorB_TWR
StandardRTLSAnchorC_TWR

Observed Results:

Using these files and three DW1000 chips, the anchors don't seem to communicate with one another. However, the Main anchor will communicate with and locate a tag

Expected Results:

The anchors communicate with one another. Evidence of this is seeing some Serial output beginning with "Range from: " from the main anchor

I dug in a bit deeper and I realize now that Anchors B and C won't send anything to main until they have a distance from the Tag. However, I'm still not getting anything from the main anchor other than the distance to the tag.

Hi @johntylerrupert,
If I have understood well your question, you should get a look at the RTLS ISO/IEC 24730-62 standard. Those examples are based on it. The same for the used methods( transmitRangingInitiation, anchorRangeAccept , etc).
Use  anchorRangeAccept to change the Anchor by which the Tag performs the ranging action. The second input parameter in Main and B anchors is the next Anchor (B in Main and C in B). Anchor C does not have a next anchor, then close the loop with NextActivity:: ACTIVITY_FINISHED as first input in anchorRangeAccept method.

Yep, that answered my question, thank you.

hey @Sonic0
where can i find this document RTLS ISO/IEC 24730-62 standard, wanted to read it.
Also what other documents do you suggest reading to be able to understand this library and be able to add more features to it.
Thank you

@Yashvardhan001109 the ISO/IEC 24730-62 standard document isn't public and you need to buy it.


High-Level Plan Training: Adapting Code for Human Play Data

Hello, this is really impressive work.
I have been able to replicate the simulation part of training the high and low level planner using play data. I am currently focusing on training a high-level latent plan using human play data. To this end, I have successfully generated an HDF5 file containing all the relevant information from the human play data extracted from the provided videos. However, I have encountered a hurdle in adapting the existing code for training the high level planner to utilize my generated HDF5 file. The current training code appears to be tailored for simulation data, leading to errors when I attempt to integrate my dataset. Any guidance or direction you could offer would be immensely helpful.
Thank you!

Hello, my goals and progress are the same as yours. I've found that learning from human data requires some code modifications. After recording dual-view operation videos, the h5 file obtained by running demo_mp4.py still needs to extract the trajectory of the end-effector (here, the hand). Before that, modify the target key names in scripts/dataset_extract_traj_plans.py, and add a num_samples attribute,: (the lengths of 'done' and 'action' are one less than obs)
for i in range(0, DEMO_COUNT):
    # Extract the hand location data
    hand_loc = f[f'data/demo_{i}/obs/hand_loc'][...]

    # Calculate the future trajectory for each data point
    future_traj_data = np.array([get_future_points(hand_loc[j:]) for j in range(len(hand_loc))])

    # Create the new dataset for future trajectory
    f.create_dataset(f'data/demo_{i}/obs/hand_loc_future_traj', data=future_traj_data)

    # Add the 'num_samples' attribute to the demo (specifically for human play data)
    f[f'data/demo_{i}'].attrs['num_samples'] = len(hand_loc) - 1

Correspondingly, the high-level JSON configuration file also needs to have the observation key names modified:
"observation": {
    "modalities": {
        "obs": {
            "low_dim": [
                "hand_loc",
                "hand_loc_future_traj"
            ],
            "rgb": [
                "front_image_1",
                "front_image_2"
            ],
            "depth": [],
            "scan": []
        },
        "goal": {
            "low_dim": [],
            "rgb": [
                "front_image_1",
                "front_image_2"
            ],
            "depth": [],
            "scan": []
        }
    },
}

In addition, mimicplay/algo/mimicplay.py also needs the following corresponding lines modified to match the new observations (hand_loc_future_traj, front_image_1, and front_image_2):
del self.obs_shapes['robot0_eef_pos_future_traj']

batch["goal_obs"]["agentview_image"] = batch["goal_obs"]["agentview_image"][:, 0]

log_probs = dists.log_prob(batch["obs"]["hand_loc_future_traj"])

The end of last line should be ["hand_loc_future_traj"].reshape(-1,40), and I think it's also possible to modify the shape of the data recorded in dataset_extract_traj_plans.py. Also modify the dimension number in the corresponding JSON file to match the dim:
"highlevel": {
    "ac_dim": 40,
},

Since human play data doesn't have a train-validation split, set it not to validate:
"experiment": {
    "validate": false,
}
"train": {
    "hdf5_filter_key": null,
    "hdf5_validation_filter_key": null,
}

This could also be addressed by modifying demo_mp4.py and make a split. Given the amount of code involved, I guess renaming keys in human data to match those in the code might be a better solution. In any case, the above modifications were sufficient for me to train a high-level model (but no way to verify the correctness), and I hope I haven't missed anything!
Compared to play data provided in simulation environment, the model trained with my collected data saw the Train/Policy_Grad_Norms parameter begin to rise from a decline around 20 epochs, far less than the ~400 epochs for the former, which also coincided with the best validation results for the former. It would be helpful if the authors could provide guidance on data collection or training.

Hello, this was extremely helpful. Thank you! While I found the guidance immensely helpful, I'm still a bit confused with how to replace the line batch["goal_obs"]["agentview_image"] = batch["goal_obs"]["agentview_image"][:, 0]. Additionally, I am encountering an error. Any insights or assistance you could provide would be greatly appreciated. Thanks again!
PlaydataSequenceDataset (
	path=scripts/human_playdata_process/demo_hand_loc_1_new.hdf5
	obs_keys=('front_image_1', 'front_image_2', 'hand_loc', 'hand_loc_future_traj')
	seq_length=1
	filter_key=none
	frame_stack=1
	pad_seq_length=True
	pad_frame_stack=True
	goal_mode=nstep
	cache_mode=low_dim
	num_demos=1
	num_sequences=144
)
0%|          | 0/100 [00:00<?, ?it/s]
run failed with error:
Expected 3D (unbatched) or 4D (batched) input to conv2d, but got input of size: [32, 1, 3, 76, 76]
Traceback (most recent call last):
  File "scripts/train.py", line 376, in main
    train(config, device=device)
  File "scripts/train.py", line 199, in train
    step_log = TrainUtils.run_epoch(model=model, data_loader=train_loader, epoch=epoch, num_steps=train_num_steps)
  File "/home/interaction/kaddy/kaddy/robomimic/robomimic/utils/train_utils.py", line 559, in run_epoch
    info = model.train_on_batch(input_batch, epoch, validate=validate)
  File "/home/interaction/kaddy/kaddy/robomimic/robomimic/algo/bc.py", line 137, in train_on_batch
    predictions = self._forward_training(batch)
  File "/home/interaction/kaddy/kaddy/MimicPlay/mimicplay/algo/mimicplay.py", line 178, in _forward_training
    dists = self.nets["policy"].forward_train(
  File "/home/interaction/kaddy/kaddy/MimicPlay/mimicplay/models/policy_nets.py", line 228, in forward_train
    out = MIMO_MLP.forward(self, return_latent=return_latent, obs=obs_dict, goal=goal_dict)
  File "/home/interaction/kaddy/kaddy/MimicPlay/mimicplay/models/obs_nets.py", line 584, in forward
    enc_outputs = self.nets["encoder"](**inputs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/interaction/kaddy/kaddy/MimicPlay/mimicplay/models/obs_nets.py", line 445, in forward
    self.nets[obs_group].forward(inputs[obs_group])
  File "/home/interaction/kaddy/kaddy/MimicPlay/mimicplay/models/obs_nets.py", line 235, in forward
    x = self.obs_nets[k](x)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/interaction/kaddy/kaddy/robomimic/robomimic/models/obs_core.py", line 172, in forward
    return super(VisualCore, self).forward(inputs)
  File "/home/interaction/kaddy/kaddy/robomimic/robomimic/models/base_nets.py", line 482, in forward
    x = self.nets(inputs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/container.py", line 217, in forward
    input = module(input)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/interaction/kaddy/kaddy/robomimic/robomimic/models/base_nets.py", line 482, in forward
    x = self.nets(inputs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/container.py", line 217, in forward
    input = module(input)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/conv.py", line 460, in forward
    return self._conv_forward(input, self.weight, self.bias)
  File "/home/interaction/kaddy/.local/lib/python3.8/site-packages/torch/nn/modules/conv.py", line 456, in _conv_forward
    return F.conv2d(input, weight, bias, self.stride,
RuntimeError: Expected 3D (unbatched) or 4D (batched) input to conv2d, but got input of size: [32, 1, 3, 76, 76]

Also I wanted to confirm if there are any changes to be made in these sections of train.py
shape_meta = FileUtils.get_shape_metadata_from_dataset(
        dataset_path=config.train.data,
        all_obs_keys=config.all_obs_keys,
        verbose=True
    )

model = algo_factory(
        algo_name=config.algo_name,
        config=config,
        obs_key_shapes=shape_meta["all_shapes"],
        ac_dim=shape_meta["ac_dim"],
        device=device,
    )

# load training data
    trainset, validset = load_data_for_training(
        config, obs_keys=shape_meta["all_obs_keys"])

I changed it to:

batch["goal_obs"]["front_image_1"] = batch["goal_obs"]["front_image_1"][:, 0]
batch["goal_obs"]["front_image_2"] = batch["goal_obs"]["front_image_2"][:, 0]

I believe this was due to not making the change in 1, [:, 0] should remove the dimension of length 1.

I didn't modify the part related to shape_meta, and it seems to be working fine:

============= Loaded Environment Metadata =============
obs key front_image_1 with shape (128, 128, 3)
obs key front_image_2 with shape (128, 128, 3)
obs key hand_loc with shape (1, 4)
obs key hand_loc_future_traj with shape (10, 4)

But I indeed missed the part about disabling env_meta:
# env_meta = FileUtils.get_env_metadata_from_dataset(dataset_path=config.train.data)
 env_meta=None

Thanks @destroy314 for the nice guidance. I'm searching among scripts in our original codebase and will update this repo soon after I find it.

Hi @destroy314 @kadambaribhujbal, we've updated the script for building your own human data and saved it in a hdf5 format (with env_args) that can be directly used for training a high-level policy:
python scripts/train.py --config configs/highlevel_human.json --dataset 'PATH_TO_HDF5_FILE

Feel free to check it out.


CON-2911 Adjust error message for failed login

Coverage decreased (-0.0006%) to 1.711% when pulling 9cd4ad8861a12acf17bd36bfde4266a8b60eceb5 on CON-2911-Adjust-error-message-for-failed-login into 3ac69a28d42b9d5f64c271ac2277ba6675312600 on master.


tjson: Implement datetime

This task is a part of #683 epic.
🎯 The goal of the task is to implement datetime type for tjson.
Tigris' schema offers support for date-time presented according to RFC-3339.
Substasks:

[x] Support datetime storing it as Tigris' date-time format.

To Do:

[ ] Add unit tests

[ ] Dedicated tests for datetime (like in the fjson package)
[ ] Add datetime fields to one of the test cases in the document_test.go file.

[ ] Port integration tests

For integration tests: https://github.com/FerretDB/FerretDB/blob/443b0e32802eae181eac1ae8a6023f43e93770c0/integration/shareddata/shareddata.go#L50, also look for TODO.


replace pimp with 'rich', 'enrich', 'extension method'

(this was called to my attention on the “LGBTQ in Tech” Slack)

you could wait till a major release when binary compatibility isn't as much as a concern?

We don't anticipate ever having to make such release so far though - compatibility is this libs strongest asset by now

We could keep the old methods but mark them deprecated which would leave this change binary compatible and good-will showing

he who lives in MiMa-less houses shouldn't throw bincompat stones :-)

revised version — that also adds MiMa to the build — ready for review
Travis says:
[info] spray-json: found 0 potential binary incompatibilities while checking against io.spray:spray-json_2.10:1.3.3
[info] spray-json: found 0 potential binary incompatibilities while checking against io.spray:spray-json_2.11:1.3.3
[info] spray-json: found 0 potential binary incompatibilities while checking against io.spray:spray-json_2.12:1.3.3

Merging this, FYI @jrudolph

Great, thanks, @SethTisue for taking care of it.

I see. @ktoso, do you want to add something about it to the 1.3.4 release notes? (I'd do it myself but I don't have admin powers here.)

Yeah I'll add such note. It's only with the specific by name import of previous method that breaks AFAICS

Added a note


Drag and drop inside subviewport not working.

Godot version
4.0.2
System information
Windows 10/EndeavourOS (Arch Linux)
Issue description
I made some code to drag and drop inside a hboxcontainer. This seems to work fine when I use this in the main viewport. However, when I add this to a subviewport I can start the drag operation, but I can't confirm for a drop. Cancelling the drag and the drop operation works as expected.
I run the .net version of Godot; but I don't think the issue is language related.
To clarify, this worked in 3.*.
Steps to reproduce
See the minimal reproduction project. The drag and drop in the main viewport works and the it fails in the greenish subviewport.
I will see if I have the time to create a GDScript, specific version if necessary.
Minimal reproduction project
DragAndDrop.zip

Duplicate of: In-game Drag and Drop between viewports does not work #28522

No, this worked in 3.* for me. Only after migrating I see this behaviour. I added this to the description now.

#67531?

Not precisely, but it might be related. I don't want to drop between the main vieport and subviewports.

I have installed .net, recompiled Godot with #67531 and can confirm, that it fixes the problem of this MRP. Feel free to close this issue.

Duplicate of https://github.com/godotengine/godot/issues/28522


CLOUD-51251 separate mybatis and app related migration SQLs

@keyki please review

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2111/


Webcam version?

Is there a webcam version of this MotionBERT model?
I would like to have it work in real-time on webcam image inputs. :)

Hi, did you manage to have it work in real-time?


ADAM method error

Thank you for the solution.
I tried it  optimizer = optimizers.Adam(alpha=args.alpha)where alpha=0.001  but got the same error.
Thank you

Thank you for reporting.
It looks the same issue as #3214. Could you take a look at it (and the answer at StackOverflow) and see if it helps?

Thank you for the solution.
I tried it  but got the same error.
from chainer.optimizers import Adam
optimizer = Adam(alpha=0.001)
Thank you

I see.
Could you give the full stack trace?
(Also, I think you edited the first post by mistake. Could you revert it?)

Thank you detailed information.
I have not tested, but it seems the problem is that the script you are using evaluates optimize.lr before the first update of the optimizer (https://github.com/mitmul/ssai-cnn/blob/master/scripts/train.py#L312).
Could you remove that line and check if it solves the problem?

Excellent, it is working now.
Thank you niboshi

You're welcome!


enum not in API requirements

enum not in API requirements

Fixed the requirements list — it should work now.


Bug report with oncoplot

Describe the issue
When I use oncoplot to plot a MAF object containing GISTIC results, the parameter top=25, the CSMD1 gene alteration rate is 62%, ranking second; but when I choose top=20, CSMD1 is not even in the top 20.
Thank you for your time.
Command
Please post your commands and the output (errors or any unexpected output)
oncoplot(maf = maf_with_gistic, top = 25, colors = col, bgCol	= 'gray90', borderCol = 'white', writeMatrix = T)

oncoplot(maf = maf_with_gistic, top = 20, colors = col, bgCol	= 'gray90', borderCol = 'white', writeMatrix = T)

Session info
Run sessionInfo() and post the output below
R version 3.6.1 (2019-07-05)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19043)

Matrix products: default

locale:
[1] LC_COLLATE=C
[2] LC_CTYPE=Chinese (Simplified)_China.936
[3] LC_MONETARY=Chinese (Simplified)_China.936
[4] LC_NUMERIC=C
[5] LC_TIME=Chinese (Simplified)_China.936

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods
[7] base

other attached packages:
 [1] data.table_1.12.6 forcats_0.4.0     stringr_1.4.0
 [4] dplyr_0.8.3       purrr_0.3.3       readr_1.3.1
 [7] tidyr_1.0.0       tibble_2.1.3      tidyverse_1.2.1
[10] ggplot2_3.3.5     maftools_2.2.0

loaded via a namespace (and not attached):
 [1] zip_2.0.4          Rcpp_1.0.2         cellranger_1.1.0
 [4] pillar_1.4.2       compiler_3.6.1     RColorBrewer_1.1-2
 [7] tools_3.6.1        digest_0.6.22      zeallot_0.1.0
[10] lubridate_1.7.4    jsonlite_1.6       lifecycle_0.1.0
[13] gtable_0.3.0       nlme_3.1-141       lattice_0.20-38
[16] pkgconfig_2.0.3    rlang_0.4.11       openxlsx_4.1.2
[19] Matrix_1.2-17      cli_1.1.0          rstudioapi_0.11
[22] haven_2.1.1        xml2_1.2.2         httr_1.4.1
[25] withr_2.1.2        hms_0.5.2          generics_0.0.2
[28] vctrs_0.2.0        grid_3.6.1         wordcloud_2.6
[31] tidyselect_0.2.5   glue_1.3.1         R6_2.4.0
[34] readxl_1.3.1       survival_3.2-11    modelr_0.1.5
[37] magrittr_1.5       scales_1.0.0       backports_1.1.5
[40] splines_3.6.1      rvest_0.3.4        assertthat_0.2.1
[43] colorspace_1.4-1   labeling_0.3       stringi_1.4.3
[46] munsell_0.5.0      broom_0.5.2        crayon_1.3.4

Hello! You are using a significantly older version of the package. Could you please update it and let me know if you can still see the discrepancy?

When I use maftools_2.8.05 in R version 4.1.1 (2021-08-10), the problem still occurs.
I provide you with the input file, hope it helps to clarify the problem.
maf_with_gistic.zip

Hi,
Okay I understand it now. The thing the rows are ordered by mutational frequency (not considering CNV events).
If you look at the top 25 mutated genes, CSMD1 is at the 22nd position. On the plot with top=25 it gets to the top because overall it has more events due to CNVs (93 samples)
> getGeneSummary(maf_with_gistic)[1:25,.(Hugo_Symbol, MutatedSamples, AlteredSamples)]
    Hugo_Symbol MutatedSamples AlteredSamples
 1:         APC             95            115
 2:        TP53             82             82
 3:         TTN             67             67
 4:        KRAS             58             77
 5:       SYNE1             36             36
 6:      PIK3CA             36             36
 7:       MUC16             35             35
 8:        FAT4             27             27
 9:        SDK1             25             25
10:       ZFHX4             23             23
11:       LRP1B             22             22
12:        RYR2             21             57
13:       DNAH5             21             21
14:       SPTA1             20             56
15:       USH2A             20             56
16:       OBSCN             19             55
17:         NEB             19             19
18:       MUC5B             19             19
19:        RYR1             19             19
20:       CSMD3             19             19
21:      DNAH11             19             19
22:       CSMD1             19             93
23:         FLG             18             55
24:       DNAH8             18             57
25:       HYDIN             18             18
    Hugo_Symbol MutatedSamples AlteredSamples

If you would like to draw the plot with sorting by overall events, use the argument altered = TRUE

Thank you for your explanation, now I understand.
Thank you for developing such an outstanding tool.


Support sub-nanosecond precision on Cargo benchmarks

In https://github.com/rust-lang/rust/pull/124774, Rust changed the output of benchmarks to contain sub-nanosecond precision. This was first published in nightly-2024-05-11 which started breaking CI that used github-action-benchmark since it couldn't find any benchmarks in an output file.
https://github.com/benchmark-action/github-action-benchmark/pull/243#issue-2292982944

released in v1.20.2


[Breaking change] Change inputs from GitHub Action

ref: https://github.com/yutailang0119/action-ktlint/issues/187

FAIL __tests__/main.test.ts
  ✕ test runs (97 ms)

  ● test runs

    Command failed: node /home/runner/work/action-ktlint/action-ktlint/lib/main.js

      11 |     env: process.env
      12 |   }
    > 13 |   console.log(cp.execSync(`node ${ip}`, options).toString())
         |                  ^
      14 | })
      15 |

      at Object.<anonymous> (__tests__/main.test.ts:13:18)

Error: Input required and not supplied: xml-path
Error: Input does not meet YAML 1.2 "Core Schema" specification: follow-symbolic-links%0ASupport boolean input list: `true | True | TRUE | false | False | FALSE`

Re https://github.com/yutailang0119/action-ktlint/pull/188#issuecomment-915158745
resolve by https://github.com/yutailang0119/action-ktlint/pull/246


Find not work

System information:

Operating system (distribution) and version: Windows 10
DBeaver version: <IP_ADDRESS>005171753
Java version: <IP_ADDRESS>
Additional extensions

Connection specification:

I use sqlserver 2012

Describe the problem you're observing:
Steps...
Ctrl + F, insert text e tecle
Erro: "String Not Found"
If I use Ctrl + K, OK, String searched.

@ricgavira Why did you close it? Did you find what's wrong or you're just OK with Ctrl+K?

Eventually the search does not work with Ctrl + F. You try to find a string and accuse it as not found, then you press Ctrl + K and then the string is found.

@ricgavira Ha! Ctrl + F actually does work. You just have to be connected to a DB. Not sure if that's the actual cause, but it started to work when I connected.

Hello. It may be that the connection dropped at that moment, in case it happens again I will inform you again.


Update highlights.json format

Closes #146

@mauricioaniche

Are we going to use this? Is the weblab team going to implement support for it?

Yes, they said they're working on it.

Great!
On Tue, Jan 3, 2023 at 11:02 AM Martin Mladenov @.***>
wrote:

@.**** commented on this pull request.
In andy/src/test/java/unit/writer/weblab/WebLabResultWriterTest.java
https://github.com/cse1110/andy/pull/150#discussion_r1060430837:

@@ -19,7 +19,7 @@
import static org.assertj.core.api.Assertions.allOf;
import static org.assertj.core.api.Assertions.assertThat;
import static unit.writer.standard.StandardResultTestAssertions.;
-import static unit.writer.weblab.WebLabHighlightsJsonTestAssertions.;
+import static unit.writer.weblab.WebLabEditorFeedbackJsonTestAssertions.*;

public class WebLabResultWriterTest extends StandardResultWriterTest {
I don't think so. I don't think there's any reasonable bug that could
occur which would cause false data to be generated and written to the file
if no such data is provided to the writer. And we already have tests that
check that the writer doesn't throw an exception in this case.
—
Reply to this email directly, view it on GitHub
https://github.com/cse1110/andy/pull/150#discussion_r1060430837, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYTTC7QZLG2DFCY5MFFNDWQP2LFANCNFSM6AAAAAATILVI7Y
.
You are receiving this because you were mentioned.Message ID:
@.***>


disableClickPropagation

If there is some event, for example, when editing a track on the map - adding a point, then when editing mode is enabled, when clicking on the full-screen button, a new point will be added in the place of this button.
This fixes it.
The application code is also slightly simplified: L.Dom Event.stop

Nice catch, thx a lot :)


[SPARK-15981][Fixed bug and added tests

What changes were proposed in this pull request?

Fixed bug in Python API of DataStreamReader
Reduced code duplication between DataStreamReader and DataFrameWriter
Added missing Python doctests

How was this patch tested?
New tests

@zsxwing Can you please take a look.

Test build #60632 has started for PR 13703 at commit ac5df18.

Test build #60632 has finished for PR 13703 at commit ac5df18.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ReaderUtils(object):
class DataFrameReader(ReaderUtils):
class DataStreamReader(ReaderUtils):

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60632/
Test FAILed.

Test build #60634 has started for PR 13703 at commit b7952d3.

Test build #60634 has finished for PR 13703 at commit b7952d3.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ReaderUtils(object):
class DataFrameReader(ReaderUtils):
class DataStreamReader(ReaderUtils):

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60634/
Test PASSed.

Better title? neither this nor the JIRA say what the problem is.

@srowen My bad. Was in a hurry. Updated PR description and JIRA.

@zsxwing @brkyvz Can you take a look.

LGTM. Nice unit tests! Merging to master and 2.0.


Fixes ReferenceError: crypto is not defined, Initiates Variables

The initial variables crypto, request, querystring, url, and xrds are never initiated. This can cause a ReferenceError: crypto is not defined, as seen:
ReferenceError: crypto is not defined
at Object.<anonymous> (C:\Node\xxxxx\node_modules\openid\openid.js:30:12)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:456:32)
at tryModuleLoad (module.js:415:12)
at Function.Module._load (module.js:407:3)
at Module.require (module.js:466:17)
at require (internal/module.js:20:19)
at Object.<anonymous> (C:\Node\xxxxx\node_modules\passport-openid-node6support\lib\passport-openid\ind
at Module._compile (module.js:541:32)

I have changed line 29 from var Buffer = require('buffer').Buffer; to var Buffer = require('buffer').Buffer, - this allows the variables following it to be initiated using var from the buffer initialization.
I have also updated the version to 2.0.6.

Thanks for this. If you could remove the package version update commit, I'll pull.

Should be done. I've got no idea why git includes the wrong message in the latest commit - blame GitHub Windows.

Um, this got messy quickly. :)
The simplest thing to do now is to just withdraw this PR and issue a new one with just the original commit (or a new version of it from upstream).
Otherwise, you could rebase to remove the package.json commit and the revert commit, and then force push.
Either way, it's just a simple comma switch...

Yeah, sorry haha. I'll withdraw this and issue a new one.


Makedirs instead of mkdirs

It is makedirs not mkdirs. This typo makes the script output nothing (Python crash => only stderr).

Good catch! It looks like Jekyll was creating it for me before that ran. That could be specific to my very weird Jekyll deployment setup though. Thanks!

I found it by luck. There is a bigger problem: no message is printed when python crashes, it makes errors hard to find.
Sent from my iPhone
On 14 janv. 2012, at 23:28, Greg<EMAIL_ADDRESS>wrote:

Good catch! It looks like Jekyll was creating it for me before that ran. That could be specific to my very weird Jekyll deployment setup though. Thanks!

Reply to this email directly or view it on GitHub:
https://github.com/xdissent/jekyll-rst/pull/1#issuecomment-3495535


Download data Too Slow

I got download batch on sif like members , so Downloading speeds too Slow but Have good Wifi speed

It should be fixed like 12 hours ago as the cdn server for the game data was switched.


OWLS-68695 Move load-balance setup to separate helm chart

Move load balancer related manifest from the domain chart to a new chart loadBalancer-per-domain.
Provide  a shell script to install IngressController for Traefik and Voyager with helm chart.
Modify the integration tests accordingly.
Use an env variable LB_TYPE to control load balancer type in the integration tests. We support four types: NONE, APACHE, TRAEFIK and VOYAGER.

One behavior change is that in integration tests before this change we create a Traefik IngressController for each domain. With this change only one Traefik IngressController created for all domains and use different host names to route to different domains.
jenkins jobs passed:
LB_TYPE=TRAEFIK: http://wls-jenkins.us.oracle.com/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/177/.
LB_TYPE=VOYAGER: http://wls-jenkins.us.oracle.com/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/178/.
LB_TYPE=APACHE: http://wls-jenkins.us.oracle.com/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/183/.
LB_TYPE=NONE: http://wls-jenkins.us.oracle.com/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/180/

Do you have a wercker run that passed with these changes?

What is the relationship between this pull request and Simon's sample apache load balancer pull request - https://github.com/oracle/weblogic-kubernetes-operator/pull/426 ?
Also, the helm chart in in this change isn't following the conventions that the operator helm chart uses (e.g. for validating inputs) - the domain .tpl files that this change removed did follow those conventions.
Overall, I'm a bit confused about the requirements (e.g. Simon's sample chart v.s. this one seems to
be part of the operator), and whether this is just a temporary chart or if it's in the final form for 2.0.

Do you have a wercker run that passed with these changes?

No. Can you inform me how to trigger a wrecker run with a branch?

It is automatically triggered when you push to the repo. Your latest run https://app.wercker.com/Oracle/weblogic-kubernetes-operator/runs/build/5bb06e045e7eac00074e67bf?step=5bb06e23f07af0000750a21c shows unit test failures, because the unit tests in question are no longer relevant, and should be deleted.

On Oct 7, 2018, at 10:50 PM, Lily He<EMAIL_ADDRESS>wrote:
Do you have a wercker run that passed with these changes?
No. Can you inform me how to trigger a wrecker run with a branch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/oracle/weblogic-kubernetes-operator/pull/430#issuecomment-427710417, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL7YI2a59Jg11VcCE1dFCYBj0ErrOVwks5uir1vgaJpZM4XA16f.

What is the relationship between this pull request and Simon's sample apache load balancer pull request - #426 ?

This change is to focus on moving LB-related manifest from domain chart to a separate loadBalacner chart. And when Simon's apache chart is ready, we can move apache-related manifest from the loadBalancer chart to that apache chart.

Also, the helm chart in this change isn't following the conventions that the operator helm chart uses (e.g. for validating values.yaml) - the domain .tpl files that this change removed did follow those conventions.

Can you explain more about the chart conventions? or any doc/wiki about it?

Overall, I'm a bit confused about the requirements (e.g. Simon's chart is a sample v.s. this one seems to be part of the operator), and whether this is just a temporary chart or if it's in the final form for 2.0.

I'm working on move the  loadBalacner chart to sample.

It is automatically triggered when you push to the repo. Your latest run https://app.wercker.com/Oracle/weblogic-kubernetes-operator/runs/build/5bb06e045e7eac00074e67bf?step=5bb06e23f07af0000750a21c shows unit test failures, because the unit tests in question are no longer relevant, and should be deleted.
…

Thanks, Russ. Why the jenkins run didn't catch the UT failures? I think this need to be fixed.

Do you have a link to the Jenkins run?

On Oct 8, 2018, at 12:44 AM, Lily He<EMAIL_ADDRESS>wrote:
It is automatically triggered when you push to the repo. Your latest run https://app.wercker.com/Oracle/weblogic-kubernetes-operator/runs/build/5bb06e045e7eac00074e67bf?step=5bb06e23f07af0000750a21c https://app.wercker.com/Oracle/weblogic-kubernetes-operator/runs/build/5bb06e045e7eac00074e67bf?step=5bb06e23f07af0000750a21c shows unit test failures, because the unit tests in question are no longer relevant, and should be deleted.
… x-msg://5/#
Thanks, Russ. Why the jenkins run didn't catch the UT failures? I think this need to be fixed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/oracle/weblogic-kubernetes-operator/pull/430#issuecomment-427720805, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL7YGALXXRKTga8Nnc67b-guyO1s6Hgks5uitgngaJpZM4XA16f.

Do you have a wercker run that passed with these changes?

jenkins jobs passed:
LB_TYPE=TRAEFIK: http://wls-jenkins.us.oracle.com/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/177/.
LB_TYPE=VOYAGER: http://wls-jenkins.us.oracle.com/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/178/.
LB_TYPE=APACHE: http://wls-jenkins.us.oracle.com/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/183/.
LB_TYPE=NONE: http://wls-jenkins.us.oracle.com/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/180/
But somehow the server is down today.

I remove all apache manifest from this change and disable apache test for now. I assume Simon's PR #426 will enable the apache test and make it pass.

@moreaut The ingress-per-domain is very simple. Its only has two template yaml, one for traefik and one for voyager.
I can see some benefits to use your pattern, input validation etc, but the downside is that it will increase the complexity of the chart. It make it difficult to understand and maintain without deep understanding of the Helm template language.
I'd prefer to leave the simple ingress-per-domain as it is.

I agree with Russell - at the very least, you should temporarily add @Ignore to the tests that are failing instead of disabling all of the tests.

It would be helpful if we could have a README to show the steps that the user needs to take to start up a load balancer of each type. We have been asked to provide README for other new sample scripts.


Fix CAS2 application status copy

good spot! But I think this is now redundant as that initial "pseudo-status" should not be listed in our reference data... See https://github.com/ministryofjustice/hmpps-approved-premises-api/pull/1150

good spot! But I think this is now redundant as that initial "pseudo-status" should not be listed in our reference data... See #1150

Aha, yes! Will close now.


Update misode changelog to full release

The full release URL displays a combination of all the changes in this cycle

Okay it looks like you did it yourself in 0ed9dc90e64d0560f8b09c29069a907930038923


Error, can't save simple dictionary field

This is my code:
Template:
<template name="homePage">
  <div class="container">
    {{ dict 'site.desc' 'No description' }}
  </div>
</template>

JS:
Meteor.startup(function () {
  orion.dictionary.addDefinition('desc', 'site', {
    type: String,
    label: 'Description'
  });
});

Error:
I20150703-09:31:19.137(-7)? Exception while invoking method '/dictionary/update' TypeError: Cannot read property '_firstLevelSchemaKeys' of null
I20150703-09:31:19.137(-7)?     at Object.orion.dictionary.deny.insert (packages/orionjs:dictionary/dictionary.js:21:1)
I20150703-09:31:19.137(-7)?     at packages/nicolaslopezj:roles/roles.js:146:1
I20150703-09:31:19.137(-7)?     at Array.forEach (native)
I20150703-09:31:19.137(-7)?     at Function._.each._.forEach (packages/underscore/underscore.js:105:1)
I20150703-09:31:19.137(-7)?     at Object.Roles.helper (packages/nicolaslopezj:roles/roles.js:144:1)
I20150703-09:31:19.137(-7)?     at orion.dictionary.deny.update (packages/orionjs:dictionary/dictionary.js:63:1)
I20150703-09:31:19.138(-7)?     at packages/mongo/collection.js:1045:1
I20150703-09:31:19.138(-7)?     at Array.some (native)
I20150703-09:31:19.138(-7)?     at Function._.some._.any (packages/underscore/underscore.js:233:1)
I20150703-09:31:19.138(-7)?     at [object Object].Mongo.Collection._validatedUpdate (packages/mongo/collection.js:1043:1)

Got it, JS belongs in lib/ folder.


added material-ui and semantic-ui

Have you used both an like them?

Used Material-UI in the two projects, everything is fine. But it seems with version 15.3 React started swearing at Custom HTML Props, It's possible to have corrected.
With Semantic, too, all is well in my experience
On the Semantic made a couple of presentations, all comfortable and beautiful
Griddle not tried it, but they say great

Then I’d suggest to remove Griddle ;-) And I don’t know where to put Spectacle, not even sure it’s in the scope of the list — it’s called “React Components Catalog” by the way.

okey, Griddle is deleted.
Spectacle provides to the various components, such as Slide, Quote, CodePane, Tables, List etc.
If you are on this, I move it to the "Miscellaneous"

If you are on this, I move it to the "Miscellaneous"

Sound good ;-)


Client for testing?

I got that cool project to run on my IdP, but I don't have any client to test it yet. How do you guys test it? any recommendations?

We have been testing it via: https://github.com/mmoayyed/simple-web-app
Note the fork.

We are also going through conformance tests with openid.net, you could try there but you'd have to know your way around the config. Start with the simple webapp first.

I'll try that, thanks!


Remove optional on description

When building it throws

Removing it fixes the build error. I personally don't have a lot of experience with typescript and react so there is probably a better way to fix this.

Sorry for the wait. I don't think this is a real problem? Looks like some eslint misconfiguration. I also can't reproduce it on my end.

Thanks for your reply.  I didn't change any eslint config that I'm aware of. The steps I took to get to the error:

Clone repository
yarn install
yarn build

OS: windows 10
node: 14.15.0
yarn: 1.22.10 & 1.23.0-20210103.1434

But think most people just download the .zip therefore they don't hit this problem.

Thanks for your contribution. I set up a new environment and managed to reproduce the error.


use correct id property, fileid is not used by the desktop client

tested with owncloudcmd ... i refactored that away ... turns out the current owncloud client uses id ... not fileid .... hmmmm but phoenix might use file id ... should we make phoenix use the id?
yuck they have different meaning ... fileid is the oc10 numeric fileid ... id is a unique string.

Codecov Report

Merging #248 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   76.92%   76.92%
=======================================
  Files           7        7
  Lines         299      299
=======================================
  Hits          230      230
  Misses         64       64
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aef081...91948dc. Read the comment docs.

Let's stick to the protocol: https://github.com/cernbox/smashbox/blob/master/protocol/protocol.md
The field should be oc:id instead of oc:fileid
OC-FileId is only used in headers

well ... fileid is used by phoenix ... maybe they can default to id. for now phoenix seems to handle fileid as string just fine.
however I don't know it it is used to tell the ocs sharing api to share files. if so, phoenix just seems to send back to us what we sent. and it is our job to work with the file id ...
We are bending the rules of the osc sharing api here ... oc 10 won't be able to handle that. and phoenix is intended  to work with oc10 as well.
I would always render the string, either as id or fileid, depending on what was requested.` Which is what this PR now does.


List item events not working inside virtual list

Hello,
I tried to add @click event to f7-list-item inside of t7-template and virtual list and it's not worked.
Note: Searchbar not working in fiddle, but working on my local.
You can check from: https://jsfiddle.net/ungnjpz8/3/
When i add @click event to normal list-item (not inside of virtual list and t7-template) it works.
So problem related with virtual list or t7-template. I don't know how i can check t7-template or virtual list without t7-template.

Update:
I found a way for test template7 standalone and i tested.
I found 1 problem: When using @click like events in your template7 make like this: @click="alert('test')" not like this: @click="'alert(\'test\')'". Second returns error.
You can check the fiddle for result:
https://jsfiddle.net/tu4252r7/2/
Unfortunately it's not working with last update too.

I found answer: #8
Closing issue...


[rancher-compose] Use same storage for creditials like rancher-cli

Currently compose can be configurable only by environment variables and parameters. Will be much simpler to use if user will not take care of it because it can use existing config file created by rancher config, so user will just select environment (if default is not enough).

rancher-compose is slowly being replaced by therancher cli. I suggest using rancher instead of rancher-compose. It will have the focus of our development. It should be capable of doing anything that you were doing with rancher-compose.
Feel free to reopen if this doesnt fully address you're needs.

Great!
Will be nice to write it somewhere visible on presentation pages about Rancher Compose.
Honza Pobořil
https://honza.poboril.cz

2017 v 18:12, Craig Jellick<EMAIL_ADDRESS>

rancher-compose is slowly being replaced by therancher cli. I suggest using rancher instead of rancher-compose. It will have the focus of our development. It should be capable of doing anything that you were doing with rancher-compose.
Feel free to reopen if this doesnt fully address you're needs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/rancher/rancher/issues/8690#issuecomment-299913383, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlfWHbtQWhtTwMubwG548774Y8EIaYIks5r3z7VgaJpZM4NS69r.


[TW#28654] Ethernet emac_main.c stack to small

i'm currently on idf 3.1.1 but this problem exists with all previous versions as well. I have a lan8720 connected to the esp32. When the lan board is connected everything works fine. When the lan8720 board is not connected and i try to initialize ethernet, a stack overflow will happen in emacT. Increasing the stacksize in components/ethernet/emac_main.c from 2048 to 3072 solves the problem.
The problem does not happen with the ethernet sample. Within my code, this happens at various places. I have added a ps command to find the free stack of each runnig task. After changing the emac stacksize to 3k i get a free stack space of 600 bytes for the emac task. So there is more needed than the 2k currently in emac_main.c:
evse> ps
task name       cpu  prio  min stack free   run time count
------------------------------------------------------------------
main              0     1           11120           468527   0.03%
IDLE              1     0<PHONE_NUMBER>99  46.72%
IDLE              0     0<PHONE_NUMBER>74  49.57%
....
emacT           any    20<PHONE_NUMBER>   0.30%

when the board is connected, the needed stacksize is much lower, this is the ps output with 3k emacT stack and a connected lan8720 board
evse> ps
task name       cpu  prio  min stack free   run time count
------------------------------------------------------------------
main              0     1           10928           326231   0.40%
...
emacT           any    20            2328            14452   0.02%

So, in case the board is not connected, the needed stacksize grew by 1728 bytes. Could this be related to the ESP_LOG* routines called to output errors ? (i have set "Default log verbosity" = Warning)
this is the fix in emac_main.c (esp_eth_init_internal)
xTaskCreate(emac_task, "emacT", 3072, NULL, EMAC_TASK_PRIORITY, &emac_task_hdl);

Development Kit:      ESP32-DevKitC or my own board with ESP32-WROOM-32 + Waveshare LAN8720
Module or chip used:  ESP32-WROOM-32
IDF version 3.1.1 or any previous version
Build System:         Make
Compiler version 5.2.0
Operating System:     Linux
Power Supply:         USB or external 5V

sdkconfig.zip

Thanks for your analysis. I will look into it later.
BTW, since IDF v3.2, the stack size has been configurable.


feat(wmg): Filter Analytics

Reason for Change

#4534

Changes

add
remove
modify

Testing steps

Either list QA steps or reasoning you feel QA is unnecessary
Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
"Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Notes for Reviewer

@ashin-czi is this ready for review or still a draft 😄 ? Thank you!

@ashin-czi just wanted to check the status on this PR given that it hasn't seen any movement for a few weeks. Thanks!

https://github.com/chanzuckerberg/single-cell-data-portal/issues/4534#issuecomment-1728091274 closing for now


Editor dry run adds a status to repos that were not edited

such as SDMs

This needs a fix in automation-client-ts to improve the behavior of EditMode.afterPersist

This isn't easy as the afterPersist callback gets invoked after the commit and push has been made, so the repo looks clean.


:sparkles: add pooling methods

Adding mean, max, and min pooling methods for torch tensors.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.33%. Comparing base (5434baf) to head (f8d5149).

Additional details and impacted files
@@             Coverage Diff              @@
##           release_061      #96   +/-   ##
============================================
  Coverage        63.33%   63.33%
============================================
  Files               65       65
  Lines             2122     2122
============================================
  Hits              1344     1344
  Misses             778      778

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thank you @GasserElbanna , it looks great. do you mind also adding some unit tests, please?


⚠ Bofrost.fr has degraded performance

In 6a1ddf9, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1723 ms

Resolved: Bofrost.fr performance has improved in 378c4fc after 8 minutes.


libceres-dev missing cmake module

quoting @mikepurvis from the buildsystem sig:
"Looks like another upstream packaging snafu— previous to Xenial, ceres-solver was imported into packages.ros.org from Mike Ferguson's PPA:
https://github.com/ros-infrastructure/reprepro-updater/blob/master/config/ceres.upstream.yaml
But now it's in upstream, yay: http://packages.ubuntu.com/xenial/libceres-dev
Except the upstream package is missing its CMake find module, fail: https://bugs.launchpad.net/ubuntu/+source/ceres-solver/+bug/1596296
The problem is in the yakkety deb too. The sid version is the same too: https://packages.qa.debian.org/c/ceres-solver.html
Do we want to patch this in a PPA and pull in the patched package? Ship the module in cmake_modules? Something else?"

Now that it's upstream I'd rather not be repackaging it. It will be just adding the files, but maintaining full compatibility is always a challenge and very hard to verify.
Two options I see:

One is to inject a small package and add it to the rosdep rule which installs the Find Module on top.
Two is to add the rule to the cmake_modules package.

The cmake_modules is a more generic solution and will work on more platforms. However it looks to me like this is a debian packaging issue and that libceres has the appropriate find rules in the upstream sources thus this should not be a problem on the other platforms. Thus I would advocate for approach one. It also has the advantage of being able to be phased out easily once the upstream is fixed to include the find modules. (As I don't expect that to be backported...)

Issue is in the install manifest:
$ dget http://archive.ubuntu.com/ubuntu/pool/universe/c/ceres-solver/ceres-solver_1.11.0~dfsg0-2.dsc
$ cat ceres-solver-1.11.0~dfsg0/debian/libceres-dev.install
include/ceres usr/include
usr/lib/lib*.so

So I could add another package for just the module, and then you can pull only that one deb into packages.ros.org.

So I could add another package for just the module, and then you can pull only that one deb into packages.ros.org.

Yeah, that's my thought. And we'll modify the rosdep rules to pull both the upstream package and the modules package on the affected distros.

PPA: https://launchpad.net/~mikepurvis/+archive/ubuntu/ceres
Diff: https://launchpadlibrarian.net/271806013/ceres-solver_1.11.0~dfsg0-2_1.11.0~dfsg0-2cmakefix0.diff.gz
Testing now, will post when all clear. You'll probably want a yakkety package too, eh?

It's worth noting that the Debian packages provided by that PPA still do not work because they don't include the header ceres/internal/config.h.  Trying to include ceres.h will result in an compilation error like so:
In file included from /usr/include/ceres/types.h:42:0,
                 from /usr/include/ceres/internal/variadic_evaluate.h:38,
                 from /usr/include/ceres/internal/autodiff.h:148,
                 from /usr/include/ceres/autodiff_cost_function.h:132,
                 from /usr/include/ceres/ceres.h:37,
                 from main.cpp:15:
/usr/include/ceres/internal/port.h:37:35: fatal error: ceres/internal/config.h: No such file or directory

This bug is also tracked on launchpad here: https://bugs.launchpad.net/ubuntu/+source/ceres-solver/+bug/1595692

Sorry for hijacking but, where do you put in requests for this sort of thing for updated packages in ubuntu releases?
I want to nudge the next Ubuntu LTS to have an up to date version of libraries that are highly used but they might not update unless given a reason.
examples:
cmake, boost, eigen3, ceres-solver, opencv, opencv-contrib, protobuf, flatbuffers, suite-sparse, (other blas libs), zeromq, bullet, googletest, spdlog, openni2.

For Xenial Yakkety and Zesty, we now provide debs for ceres-solver 1.12.0 on packages.ros.org. Looks like the only remaining platform with a faulty ceres-solver package is Debian Jessie. The upstream package on Debian Stretch works fine and didnt need to be repackaged.
@ahundt AFAIK The best way to get a package in the next ubuntu version (LTS or not) is to have it in debian sid at the time ubuntu imports all debian packages for a distribution (I don't know what that date is for ubuntu 18.04). I can't tell for each of the packages you are referring to but looking at the status of these packages on debian sid and helping the Debian maintainers to package the version you want seems the best way to go.

The release schedule for Ubuntu 18.04 has not been defined yet. But I expect it will follow the 17.04 one relatively closely, just a year later plus or minus a week or two. So the import freeze is in February. But I'd definitely suggest starting asap if there are specific things out of date.
Since we have ceres 1.12 for all Lunar targets. And we're close on Kinetic but Jessie is blocked by dependency issues I'm going to close this as resolved for Lunar and stop tracking this for a backport to earlier rosdistros. If someone can resolve the dependency issues for the backport to Jessie, we can then support Kinetic releases too. Since high enough versions appear to be upstream, it shouldn't be an issue going forward.


Adding ".DS_Store" .gitignore file?

Had a quick question about the note about the .gitignore file of a recent pull request I made, please look below for quote and link to original PR.
"Also .gitignore is ignoring for ignoring the file from the repo, not for another tool to exclude the file. I don't expect you to have anything in .gitignore (I pretty much only gitignore: config/environment/ide files and libs/build files/binaries)."
Originally posted by @umer936 in https://github.com/umer936/umer936.com/issues/1#issuecomment-2273524337
So when developing with a Mac computer, one of the files that usually appears are ".DS_Store" files that contain metadata about folder contents/views, similar to temp folders generated by windows/linux (different names across different OS).
My questions are:

Would these metadata files fall under "config/environment/ide files and libs/build files/binaries" as stated in the comment?
If so, would you like the .gitignore file under a particular folder (parent/child) for placing the contents?

Feel free to provide any additional details or format from different repository as example.

Oh that's right. Yeah that's definitely a metadata file and so .DS_Store should not be committed.
Just don't commit that file.
If we had more people working on the repo, then I would say to add in a .gitignore, but it's just you and I committing here.
For reference, this is how I make a .gitignore file: https://gitignore.io
You put in all the tool/frameworks/etc names that you're using (e.g. like OSX, PHPStorm, etc) and it spits out the file.


Use relative positions when aligned a Track vertically

An old issue that before didn't generate a bug just because Timegraph
position was (0,0). VerticallyMove into a Track need to use a relative
position since its aligned a Track into the respective container.
We are basically solving 2 issues, both moving a track and jumping to a
timer was aligned at (0,0) and not a TrackContainer position.
http://b/220682817
Test: Load a capture, see that moving tracks and jumping to timers works
as expected.

LGTM, thanks for fixing this.

Sad I didn't realize it when testing moving tracks in 1.75


Error requiring resque/scheduler/tasks file

After upgrading ruby to 3.1.2, I'm getting the following error on resque-scheduler 2.5.1:
`require': cannot load such file -- resque/scheduler/tasks
I've tried uninstalling and re-installing resque and resque/scheduler, still getting the same error.

Do you mind sharing the solution? I get the same error in 4.10.0


Improve submission error docs

I was having a hard time finding the documentation on what the difference between the field name and the _error prop for SubmissionError. This adds the language used from the onSubmit documentation about SubmissionError

Codecov Report

Merging #2873 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2873   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          67      67
  Lines        1395    1395
======================================
  Hits         1395    1395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50362b7...5f1cb82. Read the comment docs.


Translate rollback daemonset to Bahasa Indonesia

This PR is part of #22296, localizing /docs/tasks/manage-daemon/rollback-daemon-set page
/language id
/cc @irvifa
/cc @wahyuoi

Hi @girikuncoro... the build is failed due to a missing glossary for "control-plane"

@ariscahyadi I've addressed all comments, let me know if there is anything else

@ariscahyadi I've addressed all comments, let me know if there is anything else

Hi @girikuncoro ... for me, it is good to go!

Thanks @ariscahyadi !
Can you help approving the this @irvifa ?

Thanks!
/lgtm
/approve


No longer expect a Registrar ID from whois.audns.net.au

Regarding #20
To minimise breakage in apps using this gem I thought it would be best to populate the registrar ID attribute with the registrar name instead of removing it. Happy to revise if you'd prefer otherwise.

Honestly, I'd prefer to remove it completely. The reason is because the breakage already happened at AUDNS.
Let's assume that you previously stored an ID foo for the Foo Company registrar. If we pass the name as an ID, then you'll get a new Foo Company id that would be a duplicate entity referencing the same original one.
Unfortunately, there is no guarantee that there will always be an ID.
Also, how did you update the whois fixture? Did you regenerate it, or have you simply removed the field?

Removed id attribute
Whois fixture re-generated
Updated tests to match fixture.

Merged, thank you!


Add shortcut for lazy fixtures

Add short similar to pytest-lazy-fixture. So that there won't be a need to import it every time.
Also update dev deps.
https://github.com/TvoroG/pytest-lazy-fixture/blob/18ec85edb5e27c933733f748c685b2fd083198d7/pytest_lazyfixture.py#L13

@dev-petrov pretty please


Drivetrain

pulling changes we made in drivetrain into pheonix-6. Then we should be able to merge it to main for everyone else to pull the stable drivetrain into

Reviewing the code I believe we can just delete drivetrain. I have pulled relevant changes in already


CI-test that exec_done implies tries have a running time in monitoring

Running time is set on a try row through a different mechanism than the other columns
in a try row, because it comes from a wrapper around the executing task rather than
from the submit site.
The code that sets this has been very fragile in the past, so it warrants an explicit
test.
Type of change

Testing

@ZhuozhaoLi this had a merge conflict with #1877 which I have resolved. Please re-approve.

@ZhuozhaoLi this had a merge conflict with #1877 which I have resolved. Please re-approve.


AdditionalFilesToRemoveFromTarget feature isn't removing files

This feature doesnt appear to remove any files from the webroot
Configuration can be found here https://github.com/muso31/Helixbase/blob/master/src/Website/code/Properties/PublishProfiles/Local.pubxml#L21

Just to clarify before I dive into this, AdditionalFilesToRemoveFromTarget only removes files if they aren't going to get published (ie. it's an old, since-renamed, assembly). It also won't work with publishUrl being a URL.
Based on the above, do you think the feature itself is still an issue?

Providing AdditionalFilesToRemoveFromTarget is a webroot clean... I've got the publishUrl set to a path. If I rename a binary in the webroot and then publish with hpp the assembly still exists in the webroot even though it should be caught in the wildcard in Directory.build.props

Example is...
Path config: https://github.com/muso31/Helixbase/blob/master/src/Website/code/Properties/PublishProfiles/Local.pubxml#L12
Wildcard: https://github.com/muso31/Helixbase/blob/master/src/Website/code/Properties/PublishProfiles/Local.pubxml#L22
Unless it should be Website\bin\Helixbase.*.dll I believe it could be a defect

No, bin\Helixbase.*.dll is correct. Sounds like a bug.
(I'm assuming you haven't run your rename script, right? That wouldn't catch the old file name)

Yep all vanilla, no rename!

I'll take a look. Btw, if you set define a  EnablePackageProcessLoggingAndAssert property as true, the files to be removed will be emitted to AdditionalFilesToRemoveFromPublish.txt in the obj\Release\Package\Logs (from memory) directory

It doesn't work. I also tried to set EnablePackageProcessLoggingAndAssert to true, but the file AdditionalFilesToRemoveFromPublish.txt is missing after publishing.

@rkeitel What version of HPP are you using, and what is your publishing target (package, filesystem, etc)?

@rkeitel Also, is DeleteExistingFiles set to true in your publish profile? HPP's remove additional files functionality only runs if WPP isn't going to just nuke everything (as there's be no point).


util/time out of the core

The util package (that contains the time file) has been moved out from the core package for two reasons:

The utilities can be used by the core package, but also by the profiles and by the user directly.
The utils can be platform dependent (as time). This break the core purposes by two reasons:

The core must not contains platform dependent code.
The user can not touch any of core package. Only can create its own profiles or edite some of them (like a transport for a new platform).

CI failed: http://ci.intranet.eprosima.com:8080/job/MicroRTPS-Client Manual/68/
↪ 2018-10-15 lun 16:15, Luis Enrique Muñoz Martín<EMAIL_ADDRESS>
Assigned #31 to @richiware.
--
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub:
https://github.com/eProsima/Micro-XRCE-DDS-Client/pull/31#event-1904215806


Wrong Example: .$on('query'), query is not a valid argument

This example is reported but only beforeExit is allowed
prisma.$on('query', (e) => {
  console.log('Query: ' + e.query)
  console.log('Params: ' + e.params)
  console.log('Duration: ' + e.duration + 'ms')
})

Did you enable logging of queryies in your Prisma Client constructor?

tried as string and object ye

s

After 5 min delving in, I found a way to make it work. You can do this like below.
export const prisma = new PrismaClient<Prisma.PrismaClientOptions, 'query'>({
  log: [
    {
      emit: 'stdout',
      level: 'query',
    },
  ],
});

I think the typing of PrismaClient should support the code in the document.
And before doing that, the document should notice that the code raises TSError and provide a solution to make it work.

Great, Thank you!

Might be fixed in https://github.com/prisma/prisma/pull/24133


mo.image(): visualize NumPy array, torch.tensor, scipy.sparse matrix

Closes out https://github.com/marimo-team/marimo/issues/629
Note that this plots the exact size, but it might be OK to sanity-check datasets or something.
I think this is a fair tradeoff though since you really should be using matplotlib if you want more control

I have read the CLA Document and I hereby sign the CLA

recheck

No problem,
Looks like I'm missing the pillow and pillow type deps? Do those just go in project.toml?

@dmadisetti our type-checking is a bit finicky for optional dependencies. you'll want to add # type: ignore[import-not-found,import-untyped,unused-ignore] # noqa: E501 in most places where you import optional deps

The type checking and tests work locally, but I did have to install those


docker-compose reaches EOL in June

Is your feature request related to a problem? Please describe.
docker-compose v1 reaches EOL end of june 2023. Additionally the syntax changes: instead of docker-compose new versions add compose as subcommand to docker, so it is docker compose instead.
Describe the solution you'd like
Support docker-compose if available and the newe syntax docker compose.
Describe alternatives you've considered
...
Additional context
Official announcement: https://docs.docker.com/compose/reference/

I have been using docker compose V2 and the new syntax docker compose up for some time now and have not encountered any problems. Example at https://github.com/front-matter/docker-invenio-rdm

@karkraeg I used invenio-cli to build the docker images used in my Docker Compose setup.

@fenekku @ppanero I modified my Fork to use docker compose instead of docker-compose v1: https://github.com/inveniosoftware/invenio-cli/commit/8d77c22dd207ad385e50df29a44e8327526b0336
Would this change be of interest as a Pull Request?
docker-compose's last release was more than two years ago: https://docs.docker.com/compose/migrate/#will-i-still-be-able-to-use-compose-v1-if-i-really-want-to
This would alter the installation dependencies for invenioRDM.

@karkraeg Yes that would be great! You can make a PR on this repo and associate it with the "PR Community" project (I will be on the lookout for it anyway if there are logistical issues).
What I am thinking is that we could either have a transition period where both are supported  (recent versions of docker install a docker-compose pass-through anyway) or make a clean break especially for upcoming v12.
Clean break is probably easier and installing most recent version of docker is possible in any OS (we were initially a holdout because we didn't think our setup could support it, but it can!).

Any updates on this?

Any updates on this?

Hi, I'm currently on vacation, I will look into whats missing to merge the PR on the 24th of July or perhaps next week, but can't promise

Thanks for the update. Docker-compose V1 has reached EOL in June, so there is some urgency to resolve this.


Powertoys crahes when graphics tablet is plugged in

Microsoft PowerToys version
"0.60.1"
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce
Plug in a Huion H610pro v2 (with no driver installed)
PowerToysReport_2022-07-21-17-31-31.zip
)
✔ Expected Behavior
nothing should happen
❌ Actual Behavior
powertoys creates multiple error popups stating that a bug should be reported.
Powertoys Run does not work anymore (what I mainly use)
tried to Ctrl+C to copy error message for title here, which created another error popup, and not much later all popups disappeared (crashed?)
Other Software
No response

/reportbug

System.DllNotFoundException: Unable to load DLL 'PenIMC_cor3.dll' or one of its dependencies: The specified module could not be found. (0x8007007E)
   Source: PresentationCore
   TargetAssembly: PresentationCore, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35
   TargetModule: PresentationCore.dll
   TargetSite: Boolean CreateResetEvent(IntPtr ByRef)
   at MS.Win32.Penimc.UnsafeNativeMethods.CreateResetEvent(IntPtr& handle)
   at System.Windows.Input.PenThreadWorker..ctor()
   at System.Windows.Input.PenThreadPool.GetPenThreadForPenContextHelper(PenContext penContext)
   at System.Windows.Input.PenThreadPool.GetPenThreadForPenContext(PenContext penContext)
   at System.Windows.Input.StylusWisp.WispTabletDeviceCollection.UpdateTabletsImpl()
   at System.Windows.Input.StylusWisp.WispTabletDeviceCollection.UpdateTablets()
   at System.Windows.Input.StylusWisp.WispLogic.OnTabletAdded(UInt32 wisptisIndex)
   at System.Windows.Input.StylusWisp.WispLogic.HandleMessage(WindowMessage msg, IntPtr wParam, IntPtr lParam)
   at System.Windows.SystemResources.SystemThemeFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Duplicate of #16975

/dup https://github.com/microsoft/PowerToys/issues/16975


Can't Capture tokens from GET request headers

Trying to capture cookies from header value of GET request for path 'users/sign_in' set using 'Cookie' header. However evilginx just captures the value of the first 'Cookie' header it comes across ignoring the path completely. I don't see these cookies set anywhere using 'Set-Cookies' header so if can't get to work will have to capture searching body of http response.
auth_tokens:
domain: 'site.com'
path: '/users/sign_in'
name: 'Cookies'
header: 'Cookie'
type: 'http'

telegram ? :)))

telegram ? :)))

thanks bros i'm good

Warning: This individual is suspected of being a scammer. Do not make any purchases from them without using a secure escrow service or obtaining solid proof that they own the code they are offering for sale.
Please be careful when writing my name on Telegram. Many scammers create profiles similar to mine by altering letters in the username. My only official Telegram profile is https://t.me/blackdatabase. Always double-check the spelling: @B L A C K D A T A B A S E. If the spelling differs, it's not me.
The real developer of this project is [Insert Real Developer's Name or Alias], and they can be contacted directly at [Insert Developer's Contact Info, e.g., email or Telegram handle].
Stay vigilant to avoid fraud, and if you are unsure, confirm the identity before proceeding with any transactions.


bug(cdk stepper test): Test error by using cdk stepper

Reproduction
Steps to reproduce:

get code source from here: https://github.com/mainawycliffe/ng-cdk-stepper-example
npm install
npm run test

Expected Behavior
No error by running test
Actual Behavior
MyStepperComponent > should create TypeError: Cannot read property 'content' of undefined     at <Jasmine>     at MyStepperComponent_Template (ng:///MyStepperComponent.js:72:58)     at executeTemplate (http://localhost:9877/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:12169:1)     at refreshView (http://localhost:9877/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:12008:1)     at refreshComponent (http://localhost:9877/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:13458:1)     at refreshChildComponents (http://localhost:9877/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:11729:1)     at refreshView (http://localhost:9877/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:12064:1)     at renderComponentOrTemplate (http://localhost:9877/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:12142:1)     at tickRootContext (http://localhost:9877/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:13665:1)     at detectChangesInRootView (http://localhost:9877/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:13699:1)     at RootViewRef.detectChanges (http://localhost:9877/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:15408:1)
Environment

Angular: 9.1.6
CDK/Material: 9.2.3
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows WSL 2 - Ubuntu

I tried following the reproduction instructions, but they failed with this error which seems unrelated:
ERROR in src/app/app.component.spec.ts:22:16 - error TS2339: Property 'title' does not exist on type 'AppComponent'.

22     expect(app.title).toEqual('ng-cdk-stepper-forms-example');

Closing the issue, because there hasn't been any new information in a long time.


[PE-D][Tester A] Wrong validation prompt for creating a client contact

I tried creating a new contact using "c -src -cn Alice Baker -e<EMAIL_ADDRESS>-mn". In this case, the source and mobile number is empty. However, the validation error prompt was invalid email which might be incorrect?
Edit: I did further testing and tried doing  "c -src River -cn Alice Baker -e<EMAIL_ADDRESS>-mn" but there is no difference. Could possibly be something wrong with the mobile validation?

Labels: severity.Medium type.FunctionalityBug
original: Irminrics/ped#3

Duplicate of #245


Cannot find module 'babel-core

The code for the API seems to rely on Babel: https://github.com/crisboarna/national-geographic-api/blob/master/src/api/api.js#L6
But the production dependencies don't mention this dependency. When I try to use this package, I get the error:
Error: Cannot find module 'babel-core'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (D:\Dev\Sites\Node\start\node_modules\national-geographic-api\dist\api\api.js:15:18)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)

Hi @HarveyWilliams ,
Sorry for that issue, I have since updated the codebase and released v2.0.0 which removes any reference to babel and uses Typescript.
Hope you find it useful :)

Closing issue due to it being fixed and no more activity on it.