Interactive mode for odo create with experimental mode should populate default namespace

/kind bug

How did you run odo exactly?
▶ odo create
Experimental mode is enabled, use at your own risk

? Which devfile component type do you wish to create java-spring-boot
? What do you wish to name the new devfile component java-spring-boot
? What namespace do you want the devfile component to be created in

Actual behavior
When using odo create in interactive mode with experimental enabled. It asks for the namespace, but in reality, we should populate it with a default value (the current namespace)
Expected behavior
Populate with the default namespace.
Any logs, error output, etc?
N/A

I think we already support default namespace (currently active namespace) in interactive mode, by design in interactive mode, we provide an option to let user specify namespace, but if user doesn't want to specify namespace odo create will uses the currently active namespace as namespace.
Below is the UI of specifying namespace in interactive mode
? What namespace do you want the devfile component to be created in (default)

We display the currently active namespace which is default to user, user can either specify namespace or use the currently active namespace directly by hitting the enter key.

@GeekArthur What version are you trying against?
This does not actually populate for me, see below:
~/openshift/springboot-ex  master ✔                                                                                125d
▶ odo create
Experimental mode is enabled, use at your own risk

? Which devfile component type do you wish to create java-spring-boot
? What do you wish to name the new devfile component java-spring-boot
? What namespace do you want the devfile component to be created in

That doesn't look right, I am using the latest master, you can check my gif below:

I can see the default component name is pop up in your terminal, so can confirm there is no issue on your terminal configuration/environment.
I think I know why. Can you run odo preference view to check your PushTarget? One issue I can think of is if you set PushTarget to docker you might hit that weird issue as there is no default namespace (docker scenarios doesn't need cluster/namespace) but we still display that option to user, that's a known issue: https://github.com/openshift/odo/issues/2978

@cdrage Let me know if the root cause is what I describe above, then we can prioritize the known issue or do more investigation.

@GeekArthur Heck. You're right. It was set to Docker :(
I'm going to close this for now.


BUG: No highlight of current line if selected any word in this line

Does this issue occur when all extensions are disabled?: Yes

Version: 1.93.1 (user setup)
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Type: Bug
STR with screenshots:

We can see current line highlight

Select word and highlight of current line disappears:

@alexdima will it be fixed soon?


Training would be failed after choosing the third option on the "Advanced data options->Validation data" tab.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-22H2
ML.Net Model Builder 2022: <IP_ADDRESS>6301 (Main Build)
Microsoft Visual Studio Enterprise: 2022(17.4.5)
.Net: 6.0
Describe the bug

On which step of the process did you run into an issue:
Training would be failed after choosing the third option on the "Advanced data options->Validation data" tab.

TestMatrix
https://testpass.blob.core.windows.net/test-pass-data/wikipedia-detox-250-line-data.tsv
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio start window.
Choose the C# Console App (.NET Core) project template.
Add model builder by right click on the project.
Select any scenario.
Go to the Data page, choose the data source then click the "Advanced data options..." link.
Go to the "Validation data" tab, choose the third option and browse the file like below.

On the Train page, click "Strat training" button, then you will see the training is failed.

Expected behavior
Training should be successful after choosing the third option on the "Advanced data options->Validation data" tab.
Screenshot

Additional context

The bug has been fixed on the latest main build <IP_ADDRESS>6701.


[New Port Request] yojimbo

Library name: yojimbo
Library description: A network library for client/server games written in C++
Source repository URL: https://github.com/networkprotocol/yojimbo/tree/master/vcpkg/ports/yojimbo
Project homepage (if different from the source repository):
Anything else that is useful to know when adding (such as optional features the library may have that should be included):
There is already a port in the main repo. What could be done to make this available in the official vcpkg registry?

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


Update the powershell script to handle window closures for MFA login

During the IE login using an account that is MFA enabled I found that the script did not extract the authorization code. I found out that following line did not catch any urls after MFA login:
$urls = (New-Object -ComObject Shell.Application).Windows() | Where-Object {($.LocationUrl -match "(^https?://.+)|(^ftp://)") -and ($.HWND -eq $ie.HWND)} | Where-Object {$_.LocationUrl}
because ($_.HWND -eq $ie.HWND) condition was not working as $ie was null when the window restarted.
The IE window in the end still hangs around some times after the code is extracted.

Thanks for your contribution!

Just saw your auto reply,  all the best for your next gig.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Shawn Tabrizi<EMAIL_ADDRESS>Sent: Sunday, September 23, 2018 8:17:42 PM
To: shawntabrizi/Azure-AD-Authentication-with-PowerShell-and-ADAL
Cc: Anshul Dube; Author
Subject: Re: [shawntabrizi/Azure-AD-Authentication-with-PowerShell-and-ADAL] Update the powershell script to handle window closures for MFA login (#1)
Thanks for your contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshawntabrizi%2FAzure-AD-Authentication-with-PowerShell-and-ADAL%2Fpull%2F1%23issuecomment-423858734&data=02|01|Anshul.Dube%40microsoft.com|d3e115b22e78473e417908d621b32571|72f988bf86f141af91ab2d7cd011db47|1|0|636733450644424059&sdata=HxWS%2BUnq6CXGEt2sJ3fjZGsLmbPDhM%2B5p%2FCTzFqzuhY%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAoOpmNiIdj8ViUM-V2IYRw4koAOypZwaks5ueCSmgaJpZM4Wuau5&data=02|01|Anshul.Dube%40microsoft.com|d3e115b22e78473e417908d621b32571|72f988bf86f141af91ab2d7cd011db47|1|0|636733450644434063&sdata=2gtDT%2F2ve2id53NWDavk2bAE3%2F6hglH17%2BhdVRjasA4%3D&reserved=0.


hovering on the slider causes increase in video window size

Environment:

TeslaCam Version 0.0.955
Windows 10 Home
Windows Version 1809
Browser Edge 44.17763.1.0
Tesla Model 3 Firmware 2019.24.4

Steps:

Set default browser to Edge
Open TeslaCam Browser
If first time running choose TeslaCam source folder using Open Button
Click Browse to open TeslaCam in Edge
Select an event to playback in Edge
Attempt to use slider to advance through the video

Unexpected result:
The video layout increases in size.
Impact on user:
After some use of the slider the user is unable to see the videos as they have enlarged past the edge of the screen.
Reason for using Edge:
Seems to allow videos from 2019.24.4 to play

@JJeng Thanks for the detailed bug report mentioning #34 in here as well to link them even though we should make sure it probably works in Edge (then again they are killing it off for ChromeEdge).


Fixed the cache issue for BigNumber (#6375)

fixed the cache issue for bignumber

(cherry picked from commit 8e2d28dd6e057a16cd621bdf32c4798a2dd7ef61)
@timifasubaa @graceguo-supercat

Codecov Report

Merging #127 into airbnb-master will not change coverage.
The diff coverage is 100%.

@@              Coverage Diff               @@
##           airbnb-master     #127   +/-   ##
==============================================
  Coverage          76.91%   76.91%
==============================================
  Files                 47       47
  Lines               9373     9373
==============================================
  Hits                7209     7209
  Misses              2164     2164

Impacted Files
Coverage Δ

superset/viz.py
80.97% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52fcdd...6755b69. Read the comment docs.


Hector CO2 is still too low

In line with the "calibrated-Hector" parameters (below), I updated my model parameters to attempt and raise Hector CO2 to match historical output.
    BETA      Q10_RH   NPP_FLUX0  AERO_SCALE         ECS DIFFUSIVITY
    0.160000    1.519490   55.911591    0.500000    2.724023    2.393617

My changed parameters:

Param
Old distribution
New distribution

Beta
0.54 +/- 0.03 (Keenan et al 2016)
0.28 +/- 0.1 (Jones et al 2018)

Q10
2.0 +/- 1.0 (Davidson and Janssens, 2006)
1.5 +/- 1.0

AERO_SCALE
1.01 +/- 0.23 (Smith et al 2020)
0.5 +/- 0.23

I tried varying one at a time, and implementing all three. Despite best efforts, only one run made it through the filtering step on all four attempts...
Here is the most recent graph, with all three new parameter values implemented. Note that the CO2 output from 1950 on was slightly higher with the original AERO_SCALE and Q10, but 1850-1950 will not budge.

Not sure what the next steps here are. @bpbond: Help would be appreciated - thanks!

@leeyap I am sitting here with @kdorheim and here are some ideas:

What if we looked at growth in atmospheric CO2 instead of absolute values? (I.e., the diff of each time series)
What about if we say we're only using Mauna Launa record, i.e. ~1960 onward?

We might have some other suggestions too, but these are both simple to do and don't require you re-running anything model-wise. Could you try these two alternative filters?

Just looking at the Mauna Loa record, that let more runs through, but now (as one might expect) future temperature is really high. These runs are still falling within the bounds of the CMIP max, but are much higher than they were before.

Thanks for the quick look. Huh. This surprises me given @kdorheim 's v3 analysis results; Kalyn, thoughts?

as one might expect

Why? 😕 Sorry if I'm being dense.

Oh sorry, I just meant that since we cranked up the CO2, it makes sense to me that temperature is higher now!

It sounds like you and @kdorheim got a chance to talk about next steps?

@bpbond Yep, still trying out a few things.


s/aws-alb/kubernetes-nginx and s/fargate/managedNodeGroups

Why nginx:

well known/maintained
kubernetes-maintained nginx controller is better documented than the AWS ALB ingress controller
we don't need an L7 balancer with WAF support, request inspection and deep integration with AWS services, a Network Load Balancer such as nginx is more performant, more common and doesn't lock us down in AWS-land (can basically be re-used as is)

Why no more fargate:

Network Load Balancers are not supported by fargate (https://github.com/aws/containers-roadmap/issues/617), this makes it impossible to use cert-manager to get certs from let's encrypt because cert-manager spawns an nginx ingress to respond to the let's encrypt challenges. There is support for TLS termination with AWS ALB controller if you deep integrate with route 53 and have your DNS managed by amazon, honestly it's not worth the added complexity, you can't beat let's encrypt on simplicity.
We were actually getting much lower utilization on fargate and it was spawning a crazy bunch of nodes for no good reason.  I picked the t3.small instance type that has 2vCPUs and 2GiB of RAM. It costs $0.0209 an hour which is 15$ per month, I'm running two of those so the cost of the cluster is now 2*15+74(master at 0.1$/h) ~= 100$/month.
I let it scale up to 5 nodes max for now I don't expect that we'll need much more really, even then that'll cost 150$/month.
cluster is now defined in a cluster config file to be consistent with how other kubernetes resources are defined.

I'll tear-down the healthmapidha cluster in favor of the ghdsi one once I have confirmed that everything is working fine, notably https.

 expose https endpoints on aws

Yes I suspect the ALB is also costlier because we had to run two balancers whereas here we only have one.
Good call on adding Spencer, done.


Add files via upload

Thank you for your contribution. Please provide the details requested below.
ISSUE NUMBER
#128
SHORT DESCRIPTION
This is the solution for project 21 of Project Euler
TESTING
Just run the code and you'll get the answer

@prateekiiest , can you please have a look at this? This is the code for Project Euler's 21st problem


Unicode Decode Error

I haven't changed anything, all I did is download and set up the code.
I checked the char and it seemed to be a whitespace so I replaced it with " ", but then I just got an error in another position. This time the char was a "3".
Any idea?

ything, al
you may add encoding='utf-8'  when you read a file

I haven't changed anything, all I did is download and set up the code.
I checked the char and it seemed to be a whitespace so I replaced it with " ", but then I just got an error in another position. This time the char was a "3".
Any idea?

you may add encoding='utf-8' when you read a file.

For any future reader experiencing environment issues, the fix is always the same

switch to a unix environment (use a docker container if you have windows and use an interactive session)
use python 3 (python 3 default encoding is utf-8)


feat(locale): add language support: Traditional Chinese.

I'm trying to add Chinese(Traditional) support. It should be a easy fix...

@eggheadgames I'm just confused with the CircleCI error. How could I fix that? I'm willing to do the work. 🥰

@samuelchou Sorry for the slow response. My guess is that the CircleCi configuration needs to be updated for their version 2. I.e. similar to this change:
https://github.com/eggheadgames/android-about-box/commit/127b89b2c086fb90cd859b74a8862b11be7e0b75#diff-f3e9d251e83fc546f51aa7cfc8ae605d64f20c232423c4b4eaf968f227b09ac6
If you have some time to do that, it is much appreciated!

Interesting...CircleCI failed at.... uh, unexpectedly.
FAILURE: Build failed with an exception.

* What went wrong:
Could not determine java version from '<IP_ADDRESS>'.

If that was what I think, gradle source seems to be out-dated...?

Ok...there are more gradle problems than I expected. I'll fix it by the way.
1: Task failed with an exception.
-----------
* What went wrong:
A problem occurred evaluating project ':library'.
> Failed to apply plugin [id 'com.github.dcendents.android-maven']
   > Could not create plugin of type 'AndroidMavenPlugin'.
      > Unable to determine constructor argument #1: missing parameter of type Factory, or no service of type Factory<LoggingManagerInternal>.

2: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring project ':library'.
> compileSdkVersion is not specified. Please add it to build.gradle

When I tried updating android-maven , problem shows up in Android Studio:
Caused by: org.gradle.api.plugins.UnknownPluginException: Plugin with id 'findbugs' not found.

And it seems that findbugs is removed: https://stackoverflow.com/a/59102723/9735961
I don't know man, the fix seems like a HUGE work to the code, and it might be inappropriate to be done in this pull request...?
Please let me know if you have any thought @mikemee .

Since spotbugs wasn't function correctly, I just removed the tasks temporarily to fix other problems. I can add it back if needed.
Also, I fix several bugs Circle CI detected. But bugs seem to be endless...
I now feel it's a disaster to upgrade gradle... 😭

@samuelchou Sorry for the hassle. I went through most of this same stuff with the https://github.com/eggheadgames/android-about-box/ when I updated it to work with current versions of Android Studio and new releases of Android. There may be some clues there, as the projects were started around the same time and set up the same way.
Unfortunately, I don't use Siren in my Android apps any longer, so I wasn't forced to update it at the same time.
It looks like you're making steady progress. You might want to check the android-about-box project to see what version of Gradle I used there and also the upgrade PR: https://github.com/eggheadgames/android-about-box/pull/52


Update UBI minimal base image & add security-compliance tag trigger

Update UBI minimal base image to be 1107 as base as well as adding a tag trigger for the security-compliance branch.
## Secure Coding Practices Checklist GitHub Link
- https://github.com/RedHatInsights/secure-coding-checklist

## Secure Coding Checklist
- [ ] Input Validation
- [ ] Output Encoding
- [ ] Authentication and Password Management
- [ ] Session Management
- [ ] Access Control
- [ ] Cryptographic Practices
- [ ] Error Handling and Logging
- [ ] Data Protection
- [ ] Communication Security
- [ ] System Configuration
- [ ] Database Security
- [ ] File Management
- [ ] Memory Management
- [ ] General Coding Practices

Looks good!


Adding note promoting survey

Although the survey's been up for a few days and we've had around 20k views, there's no answers to the survey. In talking with Erika, we think the reference to the survey is very subtle and one solution would be to give it some more attention.
Proposed changes
Adding a "Give feedback" note and possibility of entering swag lottery.
Related issues (optional)
#15494

Closing this as we are planning to implement a feedback mechanism.


Evaluate parallel boolean operations in OCCT 6.8.0

From<EMAIL_ADDRESS>on November 27, 2014 15:17:41
Boolean ops are very slow in occt. These are parallelized since 6.8.0 when compiling with intel TBB.
Check, how good the process scales and if we should ship tigl with tbb.
Original issue: http://code.google.com/p/tigl/issues/detail?id=115

Times for the simple test with belly fairing fusing:

about 15 s with 6.7.0
about 8 s with 6.8.0 (parallel boolean ops)

More tests required, but this looks promising.

Duplicate to #184, closing this issue


Detailed documentation on workflow for async packages

I would really appreciate if we could have a sample test for InitializeAsync() for AsyncPackage. I could not find a way to initialize package asynchronously with a ServiceProvider- one similar to IVsPackage.SetSite()
It'd also be great if we could get more documentation on how packages are loaded asynchronously - eg. - AsyncPackage implements one interface with name IAsyncLoadablePackageInitialize. Implementation of its method "Initialize" does the important initializations before the InitializeAsync. It'd be really helpful to see under the hood on when this method is called, and from where.

Is there any update on this?

@manjeetsingh02 -- please provide additional context regarding your feedback, such as a topic page link.


Add a code of conduct doc.

Adding a code of conduct to help avoid issues over moderation and behavior. This will spell out what is and what isn't acceptable to help foster a better environment and prevent infighting on how moderation should be handled.

Interesting approach.
So we should really only be interested in this Code of Conduct insomuch as how we might be able to use it to restrain your behavior.  By your own indication.  Yes?  That's why you linked to the report of your misbehavior, correct?
I am concerned by the report of your editing the comments of other users (I didn't even know Github provided that tool).  Play the game of saying what you mean and apologizing by editing afterwards if you like.  Enforcing edits on others and hiding the evidence is a closed, hamfisted approach guaranteed to stir up trouble.
I will of course be keeping a copy of this comment for comparison.

So we should really only be interested in this Code of Conduct insomuch as how we might be able to use it to restrain your behavior. By your own indication. Yes

It's more to iron out what is acceptable and what is not. The link was to give context. Others may have a different bar/criteria for moderation. Having a code of conduct helps set that bar and outlines what is acceptable behavior.

I am concerned by the report of your editing the comments of other users (I didn't even know Github provided that tool). Play the game of saying what you mean and apologizing by editing afterwards if you like.

I tend to side more with stopping the derailing of threads and keeping nonconstructive bits out. Again though a CoC will set the expectations of behavior and conduct. The one I've provided is what I've used for other projects.

It's a sad day that something like this may even be needed, IMHO.

I tend to side more with stopping the derailing of threads and keeping nonconstructive bits out.

My email begs to differ :P

It's a sad day that something like this may even be needed, IMHO.

Code of conducts are a good thing.

My email begs to differ :P

It's unfortunate that disagreements and spats happen but they are usually dealt with and corrected in back channel or cleaned up after cooler heads prevail. Public bickering doesn't serve the good of the project.

I think we all participate in these projects to make things better.

Code of conducts are a good thing.

I'm not sure of any great open source project that originated from a code of conduct. Code of conducts always come after a sad day, whether experienced first-hand or not. They are good insofar as there are, sadly, folks who need them.

I think we all participate in these projects to make things better.

No doubt, thank you for your contributions!!

I'm not sure of any great open source project that originated from a code of conduct. Code of conducts always come after a sad day, whether experienced first-hand or not.

I guess I disagree. A code of conduct is a win for moderators and the community.
I think @thealphanerd can expand a bit more on that.

A code of conduct is a win for moderators and the community.

:+1:
editing peoples comments because of bickering
:-1:
If a maintainer edited someones comment because it was noise / bickering I would say that would be in violation of the CoC and would be terms for removal from the project.
+1 to merge

(just to be extra clear I appreciate everyones time and work that they put into this project, my above comment only aims to support a healthy community on both sides of the proverbial fence here)

I'm cool with it. I think clarification and outlining things is a good thing.

:+1: to a code of conduct, discussion on specific scenarios that violate it are probably out of scope for this issue though. Although I do find it pretty ironic that the one pushing for a CoC is the one being accused of violating it.

Although I do find it pretty ironic that the one pushing for a CoC is the one being accused of violating it.

It's my hope that it clears things up for the future.

It's a sad day that something like this may even be needed, IMHO.

It is really unfortunate you feel that way. I'm not 100% of the situation that has brought this up, but I can give some thoughts based on the experience with a CoC and moderation policy form the Node.js core team.
Having a CoC is a baseline, although it often gets brought up during a time of turmoil.  There really is not a valid reason to not want to protect individuals from harassment.
That being said, a CoC is completely useless without

A clear moderation policy
Buy in from the collaborators

A clear moderation policy allows collaborators to moderate appropriately and not get stuck bike shedding about process. This has been experienced first hand in the node project when we had a CoC without clear moderation policies, and we spent days figuring out how to deal with a situation while members of our community were being actively harassed.
Our moderation policy can be found here
The code of covenant comes with a paragraph outlining that moderation may happen, but it is not clear about how to moderate, or how to document the process. The node project has a different process for moderating content from a collaborator vs. a non-collaborate, it sounds like being explicit about this might be important for this project.
It is sad that CoC's and moderation policies often come up after an unfortunate instance makes it seem necessary, but that does not mean that having a CoC itself is toxic. Having a clear CoC and moderation guideline will reduce the odds of these types of events happening in the first place.
We use linters to make sure our code fits within the agreed upon standards of a project. We use a CoC to make sure our behavior does as well.
It seems to me like @megawac @akre54 @michaelficarra are the ones mostly merging code ATM... if we do not have buy in from these individuals a CoC is worse than useless.
If anyone has questions about this type of stuff they are not comfortable asking in the open please feel free to DM me. Individuals with power in the world have a duty to empower and protect those who do not.

First off, I'm in favor of CoCs generally for most if not all projects.
And to be further clear, I don't believe I have the "full story" (nor am I interested in knowing it) and certainly entertain the notion that multiple parties have taken damaging actions.
One can imagine your (@jdalton) using a code of conduct to excuse editing others' comments.  It would be an act of deep political cynicism to use a conflict whose creation is at least partially your responsibility to pass a code of conduct that would allow you greater leeway in resolving conflict in your favor.  It would be unfortunate if people got this impression.
Since that is not what's happening here, you're presenting the code of conduct as a means of considering action against yourself or one contributing to conflict in a similar manner as yourself in a future situation.  I am reading this correctly, right?
In that case a good way to build the argument for a Code of Conduct would be for you to apply that code to the preceding situation or some abstract of it.
Some person with admin powers uses those powers in a way that makes another contributor feel unwelcome and generates more conflict (as witnessed by your link).  The community recourse would be to contact jashkenas and jashkenas would then be enabled by the code of conduct to boot you that admin from further responsibility, or otherwise limit moderation privileges.
Ths is a slight improvement over the various privilege/permission wars I've heard of, in passing, between you and jashkenas, I agree!

It's my hope that it clears things up and prevents issues in the future.

I do not think you have done a very good job explaining why this is your hope with the specifics of this project.

First off, I'm in favor of CoCs generally for most if not all projects.

:clap:

Some person with admin powers uses those powers in a way that makes another contributor feel unwelcome and generates more conflict (as witnessed by your link).

This was a squabble between a few core contributors and the tweet was one side of that squabble. I don't care to turn this into a TMZ event so rather start the process to help prevent things like this in the future.
A code of conduct and a moderation policy is a good start.

You haven't even demonstrated the capacity to work on things like this in the present.

You haven't even demonstrated the capacity to work on things like this in the present.

Over the last four years I've contributed bug fixes, api design, triaged issues, started the merge discussions, and have worked with and incorporated several core into semi daily discussions on libs, utils, projects to make things better for developers. And now I'm working on this.

It's not easy for sure and sometimes there's bumps but over the years things trend in a positive direction.

Starting a pull request for a CoC does not disavow you of responsibility for the circumstances that you directly linked to as justification for the CoC.  If you did not wish to bring them up and consider them you should not have brought them up.
Your overall actions as a contributor to open source is (was) not up for consideration.

Starting a pull request for a CoC does not disavow you of responsibility for the circumstances that you directly linked to as justification for the CoC

I'm fine with folks having a different opinion on how to best moderate. I think we can both agree that outlining a CoC and moderation policy is a good thing.

Your overall actions as a contributor to open source is (was) not up for consideration.

Oh that was contributions to Underscore. But ok.

My mistake.  I am more or less a bystander.
As a bystander, my impression of your involvement with the underscore project is overwhelmingly that you are someone that stirs up trouble.  Certainly you and jashkenas have had your differences.  Certainly you are not entirely to blame for dramatic happens.
It does not help your case, in my opinion, to confine your demonstration of authority to the Underscore repository.  I preferred thinking of you as resting on your authority as the maintainer and core collaborator of Lo-dash.  (Not that I think that helped, either, of course.)
As far I'm concerned, this very topic is an instance of your inability to de-escalate conflict.  In fact I think you have no small ability to propagate it, which would be much better handled if you could acknowledge that, and act as a humble human being under the judgment of any code of conduct you might have proposed.
I began this conversation with bewilderment.  I don't understand you.  Or I understand you perfectly.  There's not a lot of ambiguity in this conversation on my end.
You've settled on the CoC as a perfect middle ground that no one can contest, and having claimed it, you can't be attacked.  You should perhaps consider that you do damage to the credibility of CoCs when you initiate them in such a strange way.

Guys, can we not start an argument in the PR for a CoC?
This a positive change, I'm in favor. @TheAlphaNerd's comment seems particularly relevant:

The node project has a different process for moderating content from a collaborator vs. a non-collaborate, it sounds like being explicit about this might be important for this project.

That'd make this even better.

Obviously it is not my place, as a non-contributor, and only a long-time user of Underscore and Lodash, to stop a CoC from being instated.  I would not want any of my comments to be read as such.

Anyway, I'm :+1: for the COC in general.

The code of covenant comes with a paragraph outlining that moderation may happen, but it is not clear about how to moderate, or how to document the process. The node project has a different process for moderating content from a collaborator vs. a non-collaborate, it sounds like being explicit about this might be important for this project.

I agree due to the circumstances prompting this

@koglerjs

As a bystander, my impression of your involvement with the underscore project is overwhelmingly that you are someone that stirs up trouble. Certainly you and jashkenas have had your differences. Certainly you are not entirely to blame for dramatic happens.

The daily ins and outs are much more mundane.

It does not help your case, in my opinion, to confine your demonstration of authority to the Underscore repository. I preferred thinking of you as resting on your authority as the maintainer and core collaborator of Lo-dash. (Not that I think that helped, either, of course.)

It's certainly a tricky position to be in. Being 100% isolated is hard and doesn't help folks wanting to make plugins or projects that can leverage either project. It takes a lot of cross-lib collaboration on APIs, behaviors, compat paths. And sometimes lines get blurred and toes get stepped on but as I've written earlier I think we all participate in these projects to make things better.
@jridgewell @megawac

This a positive change, I'm in favor. @TheAlphaNerd's comment seems particularly relevant:

:+1:

@jridgewell @megawac
I'm :+1: on the moderator policy. Would that be more approp for a separate PR for core to hash out?

The daily ins and outs are much more mundane.

I'm sure they are.  Something I had typed out but did not commit: months of steady sailing do not make up for the destruction of a mast.

(Which wouldn't matter if you were not here talking about building masts.)

It is what it is. I'm not throwing in the towel just yet.

We'll work through it and end up in a better place.

These are vagaries.  Say something real?

These are vagaries. Say something real?

There are plenty of places to help out if you want to make things better too. From docs, to improving test coverage, to ironing out a release changelog, to identifying first-time PR issues, etc.

Yes, you are within your right to defer me to participation invitation.
I like to help out by providing incidental political clarification.  (Or lack thereof.)

@megawac I'm not sure the wisdom of employing the very comment moderation policy we're debating in this thread. None of the removed posts appear to be especially egregious.
Deleting or editing "off topic" or "unconstructive" comments is a really slippery slope. Not least because it's incredibly subjective.

I suppose, however this thread was getting lengthy at 25 posts in one day and none of the 8 posts I deleted (after providing a warning that posts off topic from the COC topic would be deleted) discussed the topic of the thread. I wanted to avoid further derailment.
Anyway now -- yay or nay for a COC? Any changes to the proposed COC?

I think the points raised are important to discuss because they provide context. Particularly for something as nuanced as a Code of Conduct, it's important to get the details right.

A code of conduct isn't a magic bullet. We're talking repeated and flagrant violations of respectful tone and unwillingness to handle disagreements.

A Code of Conduct isn't a magic bullet.

That plus a moderation policy seems like a start.

We're talking about repeated and flagrant violations of respectful tone and unwillingness to handle disagreements

I think most core will agree you've done your part to stir up trouble. Having a code of conduct will help outline what's accepted and what's not and a moderation policy will help with the moderation of core and users.

I suppose, however this thread was getting lengthy at 25 posts in one day and none of the 8 posts I deleted (after providing a warning that posts off topic from the COC topic would be deleted)

Uh, you edited your warning in and I didn't notice until after the comments were suddenly gone.
Github's tools for this are terrible.
I don't mind particularly that my comments were removed.

Though I do think it was hamfisted, overbearing moderation.  As akre54 noted, it's a little subjective; why is it that jdalton was given the last word even though his comment was after the cutoff?  These are the questions and criticisms you open yourself up to; conflict could escalate if this were done to someone who cared a little more.
The point I'm trying to make is that a really good moderator policy won't help if the tools don't support it.  And there we might be stuck.

@jdalton: It is what it is. I'm not throwing in the towel just yet.

@koglerjs: These are vagaries.  Say something real

Those are both full comments. Who really cares who gets that last word in that conversation? That's not acceptable.

I wouldn't repost deleted comments.  jdalton and I have let them lie.
My point isn't that there's any disastrous miscarriage of justice here.  It's that justice requires a lot of thought.
Also I didn't want to sound down on a moderation policy; I'm for one, just a little cynical of Github.

Let's please please please keep this discussion about the content of the PR and not previous violations of a to-be-defined code of conduct. I believe @jdalton when he says he has good intentions with the introduction of a CoC, and I think he now realises how the community has been affected by his actions.
I agree with @TheAlphaNerd that we need to be careful to outline a moderation policy, though maybe one that is not as formal as node's. In fact, I think that will be the most important outcome of this effort. I have personally stuck to the following guidelines when moderating in the past:

edits to your own comment (besides typographical/formatting fixes) after someone has responded should be append-only and clearly marked using edit:
deletions of your own comment are only allowed before someone has responded
edits of someone else's comment are only allowed

to edit out violations of the CoC (clearly marked with edit:, moderator's username, timestamp, and rationale)
when it is used to direct future readers to a relevant point later in the conversation, usually the resolution (append-only, clearly marked with edit:, moderator's username, and timestamp)

deletions of someone else's comments are never okay

@megawac Yes. See the point above that about editing someone else's comments.

I may of corrected the formatting or something within 5 minutes of posting the warning but thats it.

In an active thread that's enough.  Not a big deal, seriously!  Just a point of order that I was not intentionally ignoring your warning or something.
I too agree strongly with @michaelficarra's guidelines.  It might be worth saying that any edit, no matter how close to the original post time, should be noted, with some discretion w.r.t typos.  And a moderator proclamation might deserve its own comment.

@michaelficarra: That sounds fine to me.

Seems reasonable. Are all Code of Conduct violations subject to editing or only egregious abuses (i.e. hate speech, threats of violence, etc)?

I would like to add that deletions of comments whose entire content is either "+1", ":+1:", or "me too" is perfectly fine by me :smiley:.
@akre54 I don't see why any CoC violation is more serious than another. If that is the case, maybe a CoC shouldn't restrict the "less serious" content. The only difference I can see in the severity of response would be a one-time offense versus repeat offenses.

Self editing a comment after it has been read is important. In node we often give a person a heads up that they  should consider self moderating, and that often involves going back and deleting / modifying comments to be on track and non derailing.
If an individual refuses to self moderate, or the comments are really offensive (which has happened more than once) than we delete the comments and keep a screen cap of the text. We maintain a private moderation repo where we keep track of all moderation instances.
If certain threads are really active / toxic (as was the case with the chakra PR) we assigned an individual to monitor the thread who moderated / deleted comments without much hesitation.
People do not have an inherit right to take part in an open source project. it is a privilege. People also don't have an inherit right to start airing personal derailing opinions or philosophy in a thread and expect to not be moderated. The way in which this was handled in this thread for example was very much inline with this, a stern warning was given with an opportunity to self moderate, followed by moderation when the individual did not comply.
If a comment is deleted and an individual feels their voice is being "silenced" they have every opportunity to find a new way of expressing their ideas in a way that does not violate the CoC or general decency. if they find themselves unable to find a way to do so, they will find themselves moderated and potentially banned.

I would like to add that deletions of comments whose entire content is either "+1", ":+1:", or "me too" is perfectly fine by me :smiley:.

Sounds good to me :+1:

In node we often give a person a heads up that they should consider self moderating, and that often involves going back and deleting / modifying comments to be on track and non derailing.

This is a great idea. Does node have a policy for repeat offenders?

they have every opportunity to find a new way of expressing their ideas in a way that does not violate the CoC or general decency

Not that I'm disagreeing but "general decency" is a really, really subjective thing. I think we should try to be courteous towards each other and always try to assume good faith, but leaving moderation by intent / "general decency" up to a fallible moderator is asking for trouble.

The way in which this was handled in this thread for example was very much inline with this, a stern warning was given with an opportunity to self moderate, followed by moderation when the individual did not comply.

This is not at all what happened.  I was not the only one off topic, I wasn't warned effectively, and there was no 'encouragement' to 'self moderate.'  Trying to hold this thread up as an example of what good moderation might look like weakens the case for these otherwise sensible rules.
Bootstrapping the moderation policy like this might be a good idea, but let's not pretend it was somehow retroactively effective, especially by stretching the interpretation of events.

but "general decency" is a really, really subjective thing
¯_(ツ)_/¯

Totally is. That being said we've found it is better to trust the judgement of those who we collaborate with. Things are documented, and if we believe someone was being hasty we definitely call them out on it. Then we improve moving forward.
It is also worth mentioning that we do not often opt to delete, especially when things have a troll like tone. We have had more than one instance in the past where we have take the time to talk the individual down, and eventually they self moderated (many hours later). This is to avoid feeding trolls, making people feel marginalized, or potentially increasing the potential for abuse.
@koglerjs I've been trying really hard to not engage with you, but I'm going to say this much. You do not come across as someone acting in good faith. You are consistently derailing this thread, playing devil's advocate, and generally not offering constructive feedback. I want to believe that you have good intentions, but you should be aware that you come off very toxic to me, and likely others. I strongly encourage you to take a look at what you are doing, and consider how you could express yourself in a constructive way that will work towards a meaningful solution. Contributing and taking part in open source is a privilege, not a right, and repeated derailing behavior is an easy way to marginalize your voice and ostracize yourself from communities

You do not come across as someone acting in good faith. You are consistently derailing this thread, playing devil's advocate, and generally not offering constructive feedback.

I strongly disagree. With the exception of a few minor squabbles in the middle of the thread (since deleted), I think he's been totally fair given the circumstances. Again, subjective. What in what he said do you see as derailing?

@akre54 I'm going to avoid derailing this thread myself... I likely should not have even engaged the way I did. I apologize for not holding myself to a higher standard.

Thank you for self-moderating, and setting a good example. I am curious to hear your thoughts off-thread, either in Gitter or via email.

I likely should not have even engaged the way I did

You are too right.  Thank you, sincerely, for publicly indicating as such, it allows me to shorten this comment and keep its combativeness low.
I will note that you do not address my criticism of your use of this thread's moderation as an example, and have instead chosen to make an assessment of me generally, which I will of course consider.
I promise this is on topic: the course of events is that JDD suggests bringing in a Code of Conduct, referencing incidences of his reported/alleged misbehavior.  He summons @TheAlphaNerd, who, acting initially as a reference for similar communal management, eventually puts on his moderator attitude rather strongly towards me.  I don't take it personally, I assure you.
But how amusing is it that I end up on trial, at the close of this topic!  I would say that I had played the politics poorly, except I am not really a community member (just an interested party) and cannot really fear my voice being 'marginalized.'
If this is meant to be a demonstration of how the community should function under a Code of Conduct with moderation rules, how successful has it been?  You have conveniently ignored the actions of your friend jdalton, @TheAlphaNerd, and the way you swiveled from considering my argument to evaluating my toxicity as a person makes me think that maybe every user starts looking like a troublemaker to a moderator, except of course for those that are politically aligned with the moderator.
You are even more of an outsider to this community than I am, so far as I can tell.
My toxicity is direct and impersonal.  I know I was pushing @jdalton.  I wanted to see what he had to say for himself.  If he had been able to say something like "This CoC could have been used to limit some of my recent behavior"--anything approaching willingness to express some public awareness of his own responsibility!--I would have been much less aggressive in my inquiry and appreciative that the proposal was in good faith.  My line of reasoning had a purpose, and I'm not really sorry about it (for that reason I'm also not at all bothered by the deletion).
I'm still in favor of the CoC on principle and the moderation rules because they would have helped this topic.  But I don't think they make moderation easy or successful.
This will be my last post; I'll read and consider responses but feel like I've said what I needed to say.  Apologies for any remaining stepped-on toes I may have clomped on.

Alright @koglerjs that's far enough. He apologized. Please trim your comment down.

First off, I'm writing this in an attempt to help move things forward. If this comment does not succeed at this, feel free to delete it.
It seems to me the main reason for Underscore's presence here on GitHub is to evolve and continuously improve the quality of the underscore project. While this thread does not deal with code, it does deal with the quality of this project. As such, it saddens me to see that - imho - most of the conversation has been people trying not to devolve into bickering, but failing.
When a pull request with some code changes is not quite ready to be merged, you don't point at the developer, you point at parts of the code that could use improvement and make your case. Improving community guidelines has equally much to do with evolving and improving the quality of the project as writing cleaner code or better tests.
Let's treat the task at hand the same way this community would treat a code commit and focus on converging towards something that makes underscore better.
I would like to suggest that one of the powers that be draft a few moderation rules and / or propose changes to the CoC if needed? I think a serious and constructive attempt to materialize some concrete rules may help regain some focus here.

I think CONTRIBUTING.md should link to the code of conduct.

Building on that it might be a good idea to reference it is the Readme

@megawac @jridgewell Is this PR good to merge with the idea of follow ups for moderation policy and any cross referencing?

Good with me, but I'll wait for another :+1:.

So concretely, what are we agreeing to here by merging this?

So concretely, what are we agreeing to here by merging this?

For this PR that the code of conduct outlined is acceptable.

At the time of creating the PR I wasn't aware that moderation policies were a thing so that's something for a follow up PR (but really should be hashed out by core contribs).

Right but concretely what does that mean. Most of the language in this change is about attempting to create a safe space and limiting harassment in the project. If we don't have clear definitions of trolling or harassment, what have we gained?

At the time of creating the PR I wasn't aware that moderation policies were a thing

No codified policy, but a generally accepted standard of behavior the core contributors have tried to moderate by. In the past bad behavior has been called out and dealt with on a case-by-case basis. (I believe comment editing / deletion was brought up in 2013). Is the idea to formalize these policies into a document, rather than just calling out bad faith and underhanded comments in the thread itself?

Right but concretely what does that mean.

I believe @TheAlphaNerd covered that above.

Is the idea to formalize these policies into a document, rather than just calling out bad faith and underhanded comments in the thread itself?

Yes. When I opened the PR I thought the code of conduct could perform double duty. As the thread progressed a moderation policy was mentioned as something more appropriate for outlining core and contributor moderation (Node's was used as a reference). As Underscore core continues to grow (2 added in the last week) and with the lead away at the moment, formalizing these things can help prevent issues before they start.

That's not to say I don't think a code of conduct is needed. I think the PR is merge ready.

I'll leave it to Adam  to handle this PR. He seems to be the one still with reservations. I think we should also include Michael's suggested changes in the COC. I'm indifferent if that is done now or in the future

I think we should also include Michael's suggested changes in the COC

I think a follow up commit to tweak to core taste would be appropriate or else it would just be me guessing at the exact wording or phrasing you all would prefer.

The code of covenant comes with a paragraph outlining that moderation may happen, but it is not clear about how to moderate, or how to document the process.

Couldn't we just formalize the moderation policy here in this thread like @michaelficarra has done above? I think being explicit that substantively changing the content of your post or others is out of line? Especially when it reframes the debate to look like one that didn't actually take place.
I'm in weak support of this pull request, but I almost feel like this isn't much better than having nothing at all. I'd like to wait for one of the Underscore OGs to weigh in (@jashkenas, @tgriesser, @braddunbar) but I'm fine merging if everyone else is.

I'm fine with merging this as long as we immediately follow it up with a PR that adds my suggested moderation policy (as a separate document I guess?).

I'm fine with merging this as long as we immediately follow it up with a PR that adds my suggested moderation policy (as a separate document I guess?).

:+1:

I'm a :+1: on the pull because I think outlining these things explicitly is a good idea. That said, I'm uncertain that it will be of assistance in the specific scenarios mentioned here.  ¯\_(ツ)_/¯

I'm fine with merging this as long as we immediately follow it up with a PR that adds my suggested moderation policy (as a separate document I guess?).

Great idea. Having the moderation policy in a PR is something that can be referenced while it is being fleshed out. Better to not push things through that are not quite ready

I was planning on drafting a PR with a moderation policy as a show of good faith and alignment with the CoC, even before this topic reopened.  (Probable plan: copy-paste @michaelficarra's proposal and make some minor suggestions on some modifications.)  I won't be able to get to it until late tonight and if anyone else wanted to take initiative that's fine by me.

:shipit:?

Apologies to those waiting on a moderation policy; I've begun the process but it is more than I can finish tonight.

@koglerjs Don't worry about it. I've created https://github.com/jashkenas/underscore/pull/2463.


Fix keyboard navigation for opt group options (#154)

Using lookupItems allows use of keyboard navigation for optgroup options while retaining keyboard navigation on non-optgroup dropdown.
Issue #154

Current coverage is 100% (diff: 100%)

Merging #156 into master will not change coverage

@@           master   #156   diff @@
====================================
  Files           1      1
  Lines         372    372
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits          372    372
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 2cbffd9...368b40f


Drop core2 requirement

This is a followup to  #2066 which drops the core2 requirements. Its blocked on secp256k1 and hex-conservative dropping their core2 requirements.

I can't see a core2 dependency in secp256k1. FWIW the changes to hex-conservative to use the new io crate are trivial - WIN!
diff --git a/Cargo.toml b/Cargo.toml
index 681f988..6e2348c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -25,7 +25,7 @@ std = ["alloc"]
 alloc = []

 [dependencies]
-core2 = { version = "0.3.2", default_features = false, optional = true }
+io = { package = "bitcoin_io", version = "0.1" }

 [dev-dependencies]

@@ -40,3 +40,6 @@ name = "wrap_array_display_hex_trait"

 [[example]]
 name = "wrap_array_fmt_traits"
+
+[patch.crates-io.bitcoin_io]
+path = "../rust-bitcoin/io"
diff --git a/src/iter.rs b/src/iter.rs
index f8f6d5b..59cfa26 100644
--- a/src/iter.rs
+++ b/src/iter.rs
@@ -4,11 +4,6 @@

 use core::iter::FusedIterator;
 use core::str;
-#[cfg(feature = "std")]
-use std::io;
-
-#[cfg(all(feature = "core2", not(feature = "std")))]
-use core2::io;

 use crate::parse::HexToBytesError;


webshareapi

Feature suggest : can I use web share api ? http://caniuse.com/#search=web-share-api
https://developers.google.com/web/updates/2016/10/navigator-share

duplicate : https://github.com/Fyrd/caniuse/issues/3162

kindly close this issue since my pr is merged
https://github.com/Fyrd/caniuse/pull/3368#issuecomment-301329488

here https://caniuse.com/#feat=web-share 👏🏼


Intercept <a href> navigation

I have a note taking app where users can take notes containing links that get converted to <a href>.
The default behavior of any desktop Blazor app (Photino, MAUI, WPF, WinForms) using any kind of webview is to open the link in the same webview window, but I want external links to open in the default browser.
Adding target="_blank" rel="noopener noreferrer" to <a href> opens the link in a new webview window, which is not what I want.
For:
Microsoft.AspNetCore.Components.WebView.Maui.BlazorWebView
Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView
which wrap
Microsoft.UI.Xaml.Controls.WebView2
Microsoft.Web.WebView2.Wpf.WebView2
Microsoft.Web.WebView2.WinForms.WebView2
it is possible to intercept <a href> navigation in MAUI Blazor hybrid and open it in the default browser like so:
public MainPage()
{
    InitializeComponent();
    blazorWebView.UrlLoading += OnUrlLoading;
}
private void OnUrlLoading(object? sender, UrlLoadingEventArgs e)
{
    Uri uri = e.Url;
    if (!uri.Host.Contains("<IP_ADDRESS>"))
    {
        e.UrlLoadingStrategy = UrlLoadingStrategy.CancelLoad;
        Browser.OpenAsync(uri, BrowserLaunchMode.External);
    }
}

and in WPF like so:
public MainWindow()
{
    InitializeComponent();
    blazorWebView.UrlLoading += OnUrlLoading;
}
private void OnUrlLoading(object? sender, UrlLoadingEventArgs e)
{
    Uri uri = e.Url;
    if (!uri.Host.Contains("<IP_ADDRESS>"))
    {
        e.UrlLoadingStrategy = UrlLoadingStrategy.CancelLoad;
        Process.Start(new ProcessStartInfo(uri.ToString()) { UseShellExecute = true });
    }
}

I would like to do the same in Photino, even if only on Linux.

I'm facing the same issue, except that any link with a target won't open, not even in the same window. I've also tried using onclick="window.open...", but no luck.

Photino is not designed to fire up an external browser. You can spin up a new process in C# to open a browser, but spinning up a new process is not something we're looking at doing in Photino.

What I am asking in this issue is not to

fire up an external browser

or

spin up a new process in C#

I am asking to intercept the <a href> click, which I believe is within the scope of this library.
It is also something that is supported in

class BlazorWebView in namespace Microsoft.AspNetCore.Components.WebView.Wpf
class BlazorWebView in namespace Microsoft.AspNetCore.Components.WebView.WindowsForms
class BlazorWebView in namespace Microsoft.AspNetCore.Components.WebView.Maui

with blazorWebView.UrlLoading += OnUrlLoading;
So I think that my request is not unreasonable. This feature could be used for many things beside spinning up a new process.

@Jinjinov I'm confused. You said, "The default behavior of any desktop Blazor app (Photino, MAUI, WPF, WinForms) using any kind of webview is to open the link in the same webview window, but I want external links to open in the default browser." If that's not what you want to do, can you explain your use case in more detail? If you want to intercept the click on the link, you can add an event handler in JavaScript. Or you could use a custom scheme for the URL to handle the click in C#.

The code examples I provided explain exactly what I want - an event on the main Blazor window which triggers when the user clicks on <a href>.
The point of Blazor is to use C# instead of JS wherever possible. Yes, I can use JS to handle clicks on <a href>, but even if they are hardcoded the solution requires unnecessary extra work.
But in my case the <a href> are not known at compile time, because they come from the Markdown when users write their notes which are saved in my app.
Right now I am using code that slows down the conversion from Markdown to Html to add JS to <a href> when users save their Markdown notes and I display them as Html.
Subscribing to <a href> clicked event would simplify and speed up my app. This can be used to for any number of useful features, including opening an external browser.


Incorrect ip_dict when using multibank Alveo memories

PYNQ version (e.g. v2.6): 2.7.1
Board name (e.g. Pynq-Z2): Alveo U280
Description:

ip_dict is incorrect when multiple memory banks are attached to one kernel AXIMM interface, e.g. for HBM[0:5] the ip_dict will indicate HBM[5]

Hi @quetric,
What would you expect the dict to report?

Hi @mariodruiz
The "memory" entry for the AXIMM interface/register should say HBM[0:5] indicating that all banks from 0 to 5 are connected to that interface. I think this is preferable since it corresponds to the vitis configuration setting that was used to make the connection. Alternatively the dictionary entry could have a list of banks e.g. "memory": ["HBM[0]", "HBM[5]" etc]


How to set release name when using upload_to_play_store?

In play console when you create a release it is possible to provide a release name. But when using upload_to_play_store command i cannot see a parameter to provide a custom release name when pushing the apk, but takes the version name as the release name. How is it possible to achieve it?
Please find an Image attached below which explain what release name is.

Question Checklist

[x] Updated fastlane to the latest version
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Is this feature pretty new to the Play Console? If so, it is very possible this is not implemented yet or even not possible with the API the action is using in the background. Still, sounds like a reasonable feature to implement of course (if possible).


Task is never up-to-date and corrupts the output of the build

The issue can be seen in the Gradle repository itself, when converting from a project that uses GroovyCompile to JavaCompile. The result of compilation is corrupted by GroovyCompile task, which is never up-to-date: it will delete the result of the JavaCompile task, because they share the same output directory (which is bad, but hey). Deleting the task history cache fixes the problem (delete .gradle).
Expected Behavior
When a task has no source, but that files are deleted (state cleanup), we should write a new entry in the task history to make sure that the next time the task is up-to-date. It would not fix the inconsistency for the first run, though, because it would still delete the result of the compileJava task for the 1st time, but subsequent runs would be ok.
Current Behavior
When the :ide:compileGroovy task is executed, in org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter, we see that some files have been removed, so it deletes the result of the compileJava task, which happens to execute before. The deleted flag is set to true, and the task outcome is set to EXECUTED. However, it seems that the task history is never updated, probably because the task will never be executed because it has no source. So the next time we run the build, files are again missing, and we delete the result from the compileJava task again. It's an infinite loop until we delete the .gradle directory, or disable explicitly the compileGroovy task.
Context
Migrating from a project with Groovy sources to a project with Java sources, while keeping the groovy plugin for test sources (so, a GroovyCompile task still exists).
Steps to Reproduce (for bugs)
On the Gradle build:

./gradlew ide:compileGroovy
edit subprojects/ide/ide.gradle and comment out the 2 sourceSets lines. This should effectively disable Groovy compilation because it doesn't have sources anymore. Only Java compilation should remain, which is fine because we only have src/main/java.
./gradlew ide:compileGroovy. See that the task is not up-to-date.
./gradlew ide:compileGroovy. See that the compileJava task is executed again because its output has been deleted by the compileGroovy cleanup. Then see that compileGroovy is executed, and deletes the output of compileJava.
delete .gradle
./gradlew ide:compileGroovy : no-source, everything is back to normal

Warning: the fact the compileGroovy task is not up-to-date is confusing. It doesn't execute any task action. So you can add whatever you want in a doFirst or doLast, it will never be executed, because the task has no sources! The only reason it says it has done some work is because it cleaned up the output of the compileJava task...

Does this mean, the output cleanup is only done if the task was run before according to task history? I'd consider that a bug actually. If you built before, then delete all input files and delete .gradle because of some other problem, the cleanup will not be done which is the original problem again that the cleanup should have solved.
Maybe I might suggest a different solution:

Make compileJava and compileGroovy (and others that would also be affected) compile to dedicated directories
Always wipe these directories if there is no source files, no matter if execution history exists for the task or not
Have an additional task that Syncs the dedicated directories to the currently common output folder

Does this mean, the output cleanup is only done if the task was run before according to task history?

No, the problem is that the cleanup does not update the task history. So next time it's gonna think it needs to clean up again.
I'm wondering though why the GroovyCompile task is doing stale cleanup at all. I thought we had moved this responsibility to the stale output cleaner which runs before all tasks. @bmuschko @wolfs can you shed some light on this?

Make compileJava and compileGroovy (and others that would also be affected) compile to dedicated directories

That's the long term fix, but a breaking change.

@oehme We are not at the point of cleaning up stale output files in a generic manner. There is still some work to be done for that epic. See https://github.com/gradle/gradle/issues/821#issuecomment-280004256.

Does this mean, the output cleanup is only done if the task was run before according to task history?

No, the problem is that the cleanup does not update the task history. So next time it's gonna think it needs to clean up again.

But why does then deleting .gradle work as a workaround here?
As far as I understood here, .gradle contains the task history and deleting it stops the task from cleaning up, no?

Make compileJava and compileGroovy (and others that would also be affected) compile to dedicated directories

That's the long term fix, but a breaking change.

I see.

It works because after deleting .gradle the task no longer thinks that it used to have sources.

So the question to my question is yes, isn't it?
The cleanup is only done if the task knows it had input before.
The task know it had input before because it was executed before with sources.
If the task history is deleted because of some reason, the cleanup will never be done and the original problem is present again.

If the history is lost the new build scoped stale file clean up will kick in. That's why I thought we had removed the task scoped one. But apparently that story is not completely done.

Ah, I see, that's nice then, thanks for the clarification. :-)

The reported problem has been fixed, since we now have different output directories for compileJava and compileGroovy. There may be a problem with detecting what the output files for a task are when having overlapping outputs.
I will close this issue. If there are some other use case where the problem manifests again, please create a new issue or reopen this one.


PHPDoc param is multitype

Laravel Version: 8.52.0
PHP Version: 8.0
Database Driver & Version: not relevant

Description:
Enhance type of param in Illuminate/Cache/Repository.php
    /**
     * Retrieve an item from the cache by key.
     *
     * @param  string  $key
     * @param  mixed  $default
     * @return mixed
     */
    public function get($key, $default = null)
    {

In get function, $key param must be declared as dual typed string|array
The same issue in put method.
Proposal
Change the @param to list the allowed types:
    /**
     * Retrieve an item from the cache by key.
     *
     * @param  string|array  $key
     * @param  mixed  $default
     * @return mixed
     */
    public function get($key, $default = null)
    {

The current types are correct and adhere to the PSR simplecache interface.

The current types adhere to the PSR simplecache interface, so it's ok, but I don't fully agree that the types are correct, at least according to the function's code. The real behavoir of the function's code accepts and handles 'array' as the first param, therefore there will be client code that invoques it with an array as first param and will fire PHP linters issues.
Obviously it's not an easy question to solve: Adhere to the PSR or make the real code work with linters. It seems to me as a convention clashing, because right param specs are also a conventional use.


New remote invoker & fixes

Added new remote invoker
Fixed issue when using IAM #237
Fixed python 3.7 Dockerfile #235
Changed default global timeout to None #209

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@JosepSampe does this PR include adding a 10min timer for each action? so get_result() won't wait forever for actions that got OOM

@JosepSampe does this PR include adding a 10min timer for each action? so get_result() won't wait forever for actions that got OOM

No, with current invoker it is not easy to do so. I need to think how to do it with the minor number of changes

a minor suggestion - it is much more convenient to get information about actions that got "global" timeout (of get_result()) , can you insert prints of activations that aren't done? (instead of print only the number of undone activations)

@JosepSampe a minor suggestion - it is much more convenient to get information about actions that got "global" timeout (of get_result()) , can you insert prints of activations that aren't done? (instead of print only the number of undone activations)

Do you mean to print also activation IDs?

@JosepSampe yep

@JosepSampe is it ready to merge?

@gilv Yes ;)


Very WIP support for discrete functions containing constructs such as if statements

Codecov Report
Base: 84.75% // Head: 84.64% // Decreases project coverage by -0.10% :warning:

Coverage data is based on head (44786f2) compared to base (caf0f1a).
Patch coverage: 77.55% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   84.75%   84.64%   -0.11%
==========================================
  Files           8        9       +1
  Lines         433      469      +36
==========================================
+ Hits          367      397      +30
- Misses         66       72       +6

Impacted Files
Coverage Δ

src/backends/dict.jl
76.08% <0.00%> (+1.61%)
:arrow_up:

src/backends/pruned_aggressive.jl
80.76% <0.00%> (-0.37%)
:arrow_down:

src/finite_infinitesimals.jl
100.00% <ø> (ø)

src/general_rules.jl
83.84% <72.72%> (-3.79%)
:arrow_down:

src/backends/pruned.jl
87.93% <100.00%> (+1.49%)
:arrow_up:

src/prelude.jl
100.00% <100.00%> (ø)

src/stochastic_triple.jl
73.77% <100.00%> (+2.58%)
:arrow_up:

src/discrete_randomness.jl
93.00% <0.00%> (-0.14%)
:arrow_down:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Invalid Mouse Over events on NC raw events

What does the pull request do?
When the user resizes a window it looks like we get a mouseover on a weird window's positions. This can result in the user acting on a window (e.g. activating tooltips, flyouts, etc.) which is disturbing.
We shouldn't notify the window about mouse events when he/she is resizing the window.
What is the current behavior?
When you resize a window you will get all kinds of mouse events as if the user was moving the mouse over the window (but in the wrong position).
What is the updated/expected behavior with this PR?
Users will get mouse move notifications only if they really move the mouse above the window.
How was the solution implemented (if it's not obvious)?
Code around mouse move events is not entirely consolidated. On this line
https://github.com/AvaloniaUI/Avalonia/compare/master...ltetak:feature/mouse_over_events?expand=1#diff-ac4f971803c43a9eb47a48db84d4c676d2678cb67d7cb60303b888cf49af4244R152
we remember the position of a mouse event in a class field and this value is then used on SceneInvalidated event. I don't understand the full reasoning but this fails if the position is not correct. I think the only situation is when the raw event is NonClient event (tested on both PC and Mac). The mouse position is still the old one. We can safely ignore it in this case.
Breaking changes
I don't think anybody could rely on these events because they are not distinguishable from other pointer-events and the position is clearly wrong.
Fixed issues
Fixes: https://github.com/AvaloniaUI/Avalonia/issues/7748

You can test this PR using the following package version. 0.10.999-cibuild0019296-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


Nio skip container check

Resolves #23929

API changes have been detected in com.azure:azure-storage-blob-nio. You can review API changes here
API changes
+         public static final String AZURE_STORAGE_SKIP_INITIAL_CONTAINER_CHECK = "AzureStorageSkipInitialContainerCheck";
+         public static AzurePath fromBlobUrl(AzureFileSystemProvider provider, String url) throws URISyntaxException


Add basic maintenance mode page

Need to perform a quick database operation that will require downtime, but want to get a page up that wasn't a complete failure for now. It might make sense to extend the URLs here, as this is just the base to get static files served in local development.
Going to merge this in ahead of time, I only need this enabled for a few minutes.

This is merged into branch rel now as a hotfix, still pending merge to master.

Also, this requires override of INTERNAL_IPS, as localhost host in the list triggers a bypass of the maintenance mode, because the forwarded host isn't detected.

I'm not sure if a maintenance mode that requires Django running is the best option. IMO maintenance mode should work with only the webserver up. nginx allows you to serve a static HTML page on 502 Gateway errors. That way you can shut down Django and have the site in maintenance mode automatically.

I agree catching this at nginx would be better, I'd like to bring down instances completely. Preferably, I'd like to have separate messaging for "things are down, we're doing maintenance" and "things are down, shit's broke". If there is a good solution here, I'd be +1 on scrapping this PR for that method.

The "things are down, we're doing maintenance" could be triggered by:

Create a file called maintenance_mode in the readthedocs checkout on the server
bring down the gunicorn server
nginx sees a 502 and servers a maintenance page if the maintenance_mode file exists
do stuff
bring gunicorn back up
delete the maintenance_mode file

If the file is not in place, nginx serves the 'please wish us luck' page for 502ers.

Agreed, this could be handled better in nginx. File based trigger for maintenance mode would always work, there might be another way to trigger this mode as well. Closing this PR here


Make argname normalization robust and exit 1 if invalid arg

The existing code doesn't handle passing outpath nor some other args at the command line and the code for normalizing capitalization is brittle. This PR makes these both programmatic. Also, it exits with exitcode 1 (error) if the argname is invalid.

Thanks @randallpittman !


Write Parquet file with custom schema

Hello,
is that possible to produce parquet files whose schema is not known at compile time? I'm trying like in the example below but getting NULL in all fields in each row.
package main

import (
	"os"

	"github.com/parquet-go/parquet-go"
)

func main() {
	file, err := os.Create("test.parquet")
	if err != nil {
		panic(err)
	}
	defer file.Close()

	s := parquet.NewSchema("Record", parquet.Group{
		"Text": parquet.Optional(parquet.String()),
	})
	w := parquet.NewGenericWriter[any](file, s)
	_, err = w.WriteRows([]parquet.Row{{
		parquet.ByteArrayValue([]byte("Hello")),
	}})
	if err != nil {
		panic(err)
	}

	err = w.Close()
	if err != nil {
		panic(err)
	}
}

The schema generated is
Metadata for file: test.parquet

version: 1
num of rows: 1
created by: github.com/parquet-go/parquet-go version 0.0.0(build bb12c19a1110)
metadata:
message Record {
  OPTIONAL BYTE_ARRAY Text (STRING);
}

And when I output content of the produced file
#################################################
File: test.parquet
#################################################

{Text: null}

Hey @workanator ,
It is possible but you will be using deprecated API .  You also uncovered a bug , unfortunate it is on the deprecated API so I won't be fixing it .
You can use something like this
	file, err := os.Create("test.parquet")
	if err != nil {
		panic(err)
	}
	defer file.Close()

	s := parquet.NewSchema("Record", parquet.Group{
		"Text": parquet.String(),
	})
	conf, err := parquet.NewWriterConfig()
	if err != nil {
		t.Fatal(err)
	}
	conf.Schema = s
	w := parquet.NewWriter(file, conf)
	if err != nil {
		panic(err)
	}
	_, err = w.WriteRows([]parquet.Row{
		{
			parquet.ValueOf("hello"),
		},
	})
	if err != nil {
		t.Fatal(err)
	}
	err = w.Close()
	if err != nil {
		t.Fatal(err)
	}

Note that I removed parquet.Optional from the field. For some reason WriteRows writes incorrect data when the fields are optional , I checked it with other data types as well.
I recommend you use GenericWriter.

Thank you @gernest!
I confirm that works but all NULLs (parquet.NullValue()) converted into zero values. :(
I would like to use a typed GenericWriter, that is a cool feature and I love it, but unfortunately in my project input schema is unknown, it varies with almost each input file, so I have to compose the output schema on the fly.

You are welcome. I'm closing this , please feel free to reopen if I didn't properly answer your question.

You answered my question Geofrey. Thank you! Though I still need to write optional values. Maybe you can give me a clue where I can start digging for the bug which does not allow writing optional values when GenericWriter is not used?


Update README.md

Just to prevent some unnecessary confusion when following this step-by-step README.

Glad to help. Looking forward to the workshop! ✌


Concurrency issue in SAML2IdentityProviderMetadataResolver

I am building a SAML SP using pac4j and in the load tests, found that whenever  saml2client is shared across requests , the following exception is intermittently seen in the logs.
net.shibboleth.utilities.java.support.component.UninitializedComponentException: Component 'org.opensaml.saml.metadata.resolver.impl.DOMMetadataResolver' has not yet been initialized and cannot be used.
at net.shibboleth.utilities.java.support.component.ComponentSupport.ifNotInitializedThrowUninitializedComponentException(ComponentSupport.java:106)
at org.opensaml.saml.metadata.resolver.impl.AbstractMetadataResolver.resolveSingle(AbstractMetadataResolver.java:164)
at org.opensaml.saml.metadata.resolver.impl.AbstractMetadataResolver.resolveSingle(AbstractMetadataResolver.java:62)
at org.pac4j.saml.metadata.SAML2IdentityProviderMetadataResolver.getEntityDescriptorElement(SAML2IdentityProviderMetadataResolver.java:171)
at org.pac4j.saml.metadata.SAML2IdentityProviderMetadataResolver.getEntityId(SAML2IdentityProviderMetadataResolver.java:143)
at org.pac4j.saml.context.SAML2ContextProvider.addContext(SAML2ContextProvider.java:143)
at org.pac4j.saml.context.SAML2ContextProvider.addIDPContext(SAML2ContextProvider.java:134)
at org.pac4j.saml.context.SAML2ContextProvider.buildContext(SAML2ContextProvider.java:97)
at org.pac4j.saml.client.SAML2Client.retrieveCredentials(SAML2Client.java:247)
at org.pac4j.saml.client.SAML2Client.retrieveCredentials(SAML2Client.java:76)
at org.pac4j.core.client.IndirectClient.getCredentials(IndirectClient.java:187)
On looking at the possible reason, I built a local version of pac4j-saml, by making the field idpMetadataProvider, a local var in the resolve method.
My tests show that this resolves the issue seen and concurrent requests for SAML request generation / assertion processing works fine.

Here is the commit id in my fork : https://github.com/jayaramsankara/pac4j/commit/751402f9acec1bfbaf1873cf970622c9c341c0a9

Thanks for reporting.
Indeed, it seems to strange to initialize the object property: idpMetadataProvider in each call to the resolve method.
Would you mind pushing a PR?
@mmoayyed : what do you think?

Yes, definitely. A local var sounds much better. I am not sure if the client is meant to be threadsafe, is it? And why are you calling the resolve method on every request? Shouldnt that only happen once during init?

Yes, the client is meant to be thread-safe, you should have only one SAML 2 client.

Thanks.  Shall I send a PR with the change?

Of course. All help is welcome :)


[BUG] Index Selector in Data Source Per Document Monitor Shows As Editable Once Selected Although Not

What is the bug?
A clear and concise description of the bug.
Given that a user selects a per document monitor, when selecting the index from data sources, then the selection from the dropdown should reflect that it is a single entry and not show a text cursor indicating that it is editable.
How can one reproduce the bug?
Steps to reproduce the behavior:

Go to per document monitor
Click on index within data sources
Select an index from the dropdown
Note that a text cursor is next to the dropdown selection, but the user cannot type as it is a dropdown selection

What is the expected behavior?
If it is a dropdown selection, a text cursor should not be present.

Longer term, we should change the component to make it so that one can edit the selection if desired since document level monitoring only supports one index.

What is your host/environment?
NA
Do you have any screenshots?

Do you have any additional context?
None

Closing this in favor of https://github.com/opensearch-project/oui/issues/137


FLAKE: "pthread_mutex_lock failed" crash on MacOS (seen in many tests)

I've seen this in a number of tests lately.  The most recent one is here:
https://source.cloud.google.com/results/invocations/34d2f278-60b4-40fc-b50c-0243d5463ec9/targets/github%2Fgrpc%2Frun_tests%2Fcpp_macos_dbg_native/tests
Could this be related to the recent absl synchronization change?

I'm looking out on this since https://github.com/grpc/grpc/pull/25841 and thank you for the report. It doesn't appear that the flakiness changed significantly after the PR merged but it's worth looking at this particular failure.


terraform-provider-platformsh

Thanks for (finally) creating a Go CLI, but can that please be extended to provide a Terraform Provider for Platform.sh? Benefits include being able to construct and fully, and centrally, manage projects and their resources as config rather than a series of shell scripts.
I'd went ahead and created my own, internally, using native Golang HTTP requests rather than embedding PHP, and it is working fine as a POC stage, but would be nice if there was something more official (even if it did embed PHP, although large binaries are an unfortunate side effect).
Reference https://developer.hashicorp.com/terraform/tutorials/providers-plugin-framework

Thanks @OneCricketeer for your feedback, that's greatly appreciated!
Could you please elaborate what you'd expect in such an integration? Would you have any snippets in mind?


Please depend on formal releases

Please always stick to semantic releases of vendored dependencies.
For instance opencontainers/spec and opencontainers/runc use semantic versioning so it is important to respect their release process and refrain from bundling unreleased snapshots to avoid needless maintenance overhead downstream.
Thanks.
See also

http://semver.org/
https://en.wikipedia.org/wiki/Software_versioning
Debian Upstream Guide

FYI @crosbymichael

The main reason this happens is because of bugs downstream that require us to depend on the fix. But yes, this does add unnecessary maintenance overhead for distros (something that we hit quite a lot at SUSE).

Well, semantic versioning is there for good reasons and it is ridiculous when one released(!) project depends on unreleased snapshot of a versioned(!) library.
This should stop because this is just wrong on so many levels...
Is it really that hard to coordinate release process?
You are free to use whatever versions of dependency libraries in "master" but once formal release is tagged it important to stick to official releases. Sometimes you may have to wait. What's unnecessary is to rush and break proper release process and cause all the problems downstream...

@onlyjob Out of interest, how does Debian deal with vendored Go libraries?

We package dependencies separately and reuse 'em. Vendoring is generally discouraged.

This is resolved now.  we are depending on and tagging the releases for containerd and runc


Can't export data to excel on kom>reksama

This issue only exists on reksama page

It seems that buttons plugin cannot handle null value.
Reksama indeed contains null value, so the solution is change the query to use NVL to suspected field


Change the generated job and request location within the module instead of domain

Change the generated job and request location within the module instead of domain

PR approved


New version: JetBrains.PHPStorm.EarlyAccess version 223.8617.27

Result: Installation Failed

Manifest
Add/Remove Programs

Name
PhpStorm (EAP)

Version
223.8617.27

Publisher
JetBrains s.r.o.

ProductCode

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 5512
Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run


Implement companion files

The problem the component solves
As per this comment in #11, mailbag must be able to include companion metadata files. These will be packaged in the source format subdirectory and the original arrangement must be maintained.
Currently, the parsers use glob to only package files matching the input extension. We should add an optional argument such as --companion_files. When this is used we should package all files in the directory provided in the source format subdirectory. For example, mailbagit parent_dir -i pst -d pdf -m mailbag_name --companion_files should accept:
/parent_dir/office1/account1.pst
/parent_dir/office1/account1.csv
/parent_dir/office1/account2.pst
/parent_dir/office1/account2.csv
/parent_dir/office2/account1.pst
/parent_dir/office2/account1.csv

Which will become:
/mailbag_name/data/pst/office1/account1.pst
/mailbag_name/data/pst/office1/account1.csv
/mailbag_name/data/pst/office1/account2.pst
/mailbag_name/data/pst/office1/account2.csv
/mailbag_name/data/pst/office2/account1.pst
/mailbag_name/data/pst/office2/account1.csv

Relevant part of mailbag spec?
TBD
Type of component

[ ] Core
[X] Input
[ ] Attachments
[ ] Derivatives conversion
[ ] Reporting/Exporting
[ ] GUI
[ ] Distribution

Expected contribution

[x] Pull Request
[ ] Comment with proposed solution

Major challenges or things to keep in mind

Implemented by #178


feat: add greetings mod plus enhance type and scope mod

So far, a bug where pages will displayed in the wrong order has been fixed.

Task linked: CU-862krk8qe feat: add greetings mod plus enhance type and scope modu


Update folder.rb

fixing the issue for history directory so that recursive folder path can be specified

done

The test have not failed due to the change, how can the build be fixed?

Thanks for the PR. This has now been released in v4.2.3.


Snapshop documentation linked incorrectly?

I noticed this was linked from the main page https://github.com/Swagger2Markup/swagger2markup
http://swagger2markup.github.io/swagger2markup/1.0.1-SNAPSHOT/
in the reference documentation. Is that the intention?

No. I have to fix the github-pages upload. Thx.
But the documentation is still valid.


Add shortcuts methods for request on self

As discussed in #61 this add shortcuts methods for call on self.
This enable more fluent calls like:
resource.$putSelf(payload)
instead of
resource.$put(null, null, payload) or resource.$put($halConfiguration.self, null, payload)

Could you also write a very simple test for that functionality?

Sure, I'll do that soon.

Thank you very much.

You're welcome, thanks for this lib.


BUG:The contents in more section navbar are misplaced

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

These contents from the more section on the navbar are misplaced . I will make sure to make this contents to align properly in navbar . Please assign this task to me
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR and include the issue number.
Also, please star the repo before working on it. Happy open-source contributing!


Switch to ExpressJS 4.x

ExpressJS 4.x provides a few novelties that could help make the code cleaner and easier to read/maintain.
https://github.com/strongloop/express/wiki/New-features-in-4.x

Done in commit 460ded6f46d75824e8d3af28790b8985e120cd3f


Confusion in GT Disparity Map

Hi authors,
Thank you so much for providing the code for your paper. I have a query regarding the GT Disparity map that you generate using ./preprocessing/generate_disp.py
I downloaded the GT Disparity that you provided. However, it looks more like a LIDAR point cloud than a disparity image. Is this how it is supposed to be? I plotted the below GT using matplotlib

RGB image for the above GT disparity map is given below

Please let me know. Thank you!

Hi Rishi,
Yes, The disparity is correct. This disparity map is generated by LiDAR point cloud, that is the reason it looks very sparse.


[Bug]: Broken Service Integration error is displayed while buying airtime for Equity bank

Description
A Broken Service Integration error is displayed on the buy airtime screen after clicking continue while buying airtime using Equity bank
Steps to reproduce

Open the Stax app
Tap the Buy airtime icon on the home screen
Select Pay With Equity on the send money screen
Select Recipient Network as Safaricom
Enter Contact Phone Number
Enter Amount in the Amount text box and tap Continue
Tap Connect now and pay attention to the error message displayed and the screen.

Expected result
The transaction to buy airtime successfully continues to completion after taping continue
Actual result
A Broken Service Integration error is displayed on the buy airtime screen after clicking continue while buying airtime using Equity bank
Link to screenshots/screen recordings
https://drive.google.com/file/d/1jIxqjZQQYKyqK1Pt6FhMZn2rDXOjAVnr/view?usp=drivesdk
Device name
Samsung Galaxy A32
Android OS
12
Is your phone dual SIM or single SIM?
Dual SIM
Which telco are you using for this test?
Safaricom
Stax device ID or email address
bc34b750f5749d4a

This has been fixed with the new release that we will be putting out early next week.


Remove the empty std.digest.digest site

https://dlang.org/phobos/std_digest_digest.html
std.digest.digest was moved to std.digest in https://github.com/dlang/phobos/pull/5013

Oh it seems like the deprecation warnings have never been added. I also added this to this PR and opt-ed for 2.084 as it already has been part of the changelog in 2.076 and the documentation hasn't been existent since 2.076.
https://github.com/dlang/phobos/pull/5013
https://dlang.org/changelog/2.076.0.html#std-digest-package


Follow up with Chris on desired components

Chris says:

For component three (high/medium priority log count) a count makes more sense than displaying the most recent logs themselves
Additionally, add counts for Errors and Warnings along with high/medium priority counts
Also, make these counts clickable which would load the Log Events screen with the same criteria that used for the count


Documentation could be more accurate on some points

Hi, great plugin 👍, easygoing instructions, but maybe you should precise a couple of things, as some of us are just starting out with v4 (I struggled with these at first):

Precise the configuration snippet has to be place inside a plugin.js file under the config folder.
Precise we have to rebuild the admin first before seeing changes (you used the development mode from your screenshot, but it’s likely we’ll just use the normal dev mode).
Precise we need to toggle the publicationState API parameter to preview when querying the content, otherwise, the draft will never be part of the response.

Also, not related to the issue but, unless I am mistaken, I noticed it's not working for single types, only collection types, right?

Precise we need to toggle the publicationState API parameter to preview when querying the content, otherwise, the draft will never be part of the response.

What do you mean? How do I do this?
Thanks

The "publicationState" parameter is part of the Strapi API.
If we want to get the draft version from the api response, it's mandatory to set it to "preview".
As we don't want to get the enabled all the time, I guess we should use a conditional depending if we are on a preview state or not.  Eg:
const postRes = await fetchAPI('/post', {
    publicationState: context.preview ? 'preview' : 'live',
    /// ...

The documentation needs a revision. Unfortunately, there are missing crucial information. E.g. where to place the config file?

Also, not related to the issue but, unless I am mistaken, I noticed it's not working for single types, only collection types, right?

Correct, but check again 🙂. The plugin has very recently been updated to support single types 👍🏻

When it comes to configuring a plugin in Strapi, I did not include those specific details in the plugin README because those guides can already be found in the Strapi docs - https://docs.strapi.io/developer-docs/latest/setup-deployment-guides/configurations/optional/plugins.html
This plugin does not have a public API so if you are querying the API for draft/live versions, that is not related to the functionality of this plugin. Details on querying draft/live states can be found in the Strapi docs - https://docs.strapi.io/developer-docs/latest/developer-resources/database-apis-reference/rest/filtering-locale-publication.html

@mattmilburn I have tested the latest version and successfully used it for a single type, so thanks for this important support! 👍
Regarding the install instructions, nothing mandatory of course but I think it's never too much to precise things, especially as v4 is still relatively new in the game.
Here are some examples found across other marketplace plugins:

Same for regarding draft/live, nothing mandatory but it helps and avoid potential struggles to have this check in mind before using the package.
I close the issue as it's not critical, all the best for this package!

Documentation absolutely confused to implement. Any other guide to follow? Thank you.

This plugin does not have a public API so if you are querying the API for draft/live versions, that is not related to the functionality of this plugin. Details on querying draft/live states can be found in the Strapi docs - https://docs.strapi.io/developer-docs/latest/developer-resources/database-apis-reference/rest/filtering-locale-publication.html

thanks @mattmilburn I'm still very new to Strapi. I thought that everything could be done via GraphQL but it seems getting draft content can only be done on REST. I wish I read this 3 days ago :)


Uncaught TypeError: Cannot read property '0' of undefined

Uncaught TypeError: Cannot read property '0' of undefined
Atom Version: 0.155.0
System: Mac OS X 10.10.1
Thrown From: color-picker package, v1.2.1
Steps To Reproduce

...
...

Stack Trace
At /Users/kamilahjenkins/.atom/packages/color-picker/lib/ColorPicker-view.coffee:99

TypeError: Cannot read property '0' of undefined
  at ColorPickerView.module.exports.ColorPickerView.open (/Users/kamilahjenkins/.atom/packages/color-picker/lib/ColorPicker-view.coffee:99:38)
  at Object.module.exports.open (/Users/kamilahjenkins/.atom/packages/color-picker/lib/ColorPicker.coffee:102:23)
  at atom-workspace.<anonymous> (/Users/kamilahjenkins/.atom/packages/color-picker/lib/ColorPicker.coffee:19:69)
  at atom-workspace.handler (/Applications/Atom.app/Contents/Resources/app/src/space-pen-extensions.js:112:34)
  at atom-workspace.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4681:9)
  at atom-workspace.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4359:46)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:243:29)
  at CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:3:61)
  at CommandRegistry.module.exports.CommandRegistry.dispatch (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:156:19)
  at [object Object].jQuery.fn.trigger (/Applications/Atom.app/Contents/Resources/app/src/space-pen-extensions.js:64:23)
  at Ipc.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:70:67)
  at Ipc.emit (events.js:110:17)
  at process.<anonymous> (/Applications/Atom.app/Contents/Resources/atom/renderer/api/lib/ipc.js:22:29)
  at process.emit (events.js:118:17)
  at Ipc.sendSync (/Applications/Atom.app/Contents/Resources/atom/renderer/api/lib/ipc.js:39:29)
  at Ipc.sendChannelSync (/Applications/Atom.app/Contents/Resources/atom/renderer/api/lib/ipc.js:47:28)
  at BrowserWindow.RemoteMemberFunction [as emit] (/Applications/Atom.app/Contents/Resources/atom/renderer/api/lib/remote.js:110:29)
  at ContextMenuManager.module.exports.ContextMenuManager.showForEvent (/Applications/Atom.app/Contents/Resources/app/src/context-menu-manager.js:169:33)
  at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:138:33)
  at HTMLDocument.handler (/Applications/Atom.app/Contents/Resources/app/src/space-pen-extensions.js:112:34)
  at HTMLDocument.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4681:9)
  at HTMLDocument.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4359:46)

/cc @atom/core

Hi! Please update both Atom and the color-picker package and try again.


Provider tags must be provided if pending pacts are enabled

When using the pending pact feature in provider tests, with something like the following:
PactSource
    .PactBrokerWithSelectors(PactBrokerUrl)
    .withConsumerVersionSelectors(ConsumerVersionSelectors.mainBranch)
    .withPendingPacts(true)

We get the error Provider tags must be provided if pending pacts are enabled.
This can be solved easily by providing tags directly or by using .withPendingPactsEnabled(tags) which explicitly asks for tags.
But, the concept of tags in Pact is deprecated for some time already (in favour of branches especially) and I don't find any reason in the documentation that states tags must be set for pending pacts to work.
Should we remove this check and allow usage of the "pending pacts" feature without tags?
I'll be happy to provide a PR for this.

For reference the check is done in https://github.com/jbwheatley/pact4s/blob/17f48624d8c88904315e2e36fd242522cd596708/models/src/main/scala/pact4s/provider/PactSource.scala#L196

Pending Pacts work for branches, yes. You’re right, that restriction should be lifted to support provider branch as an alternative constraint.