Updated dipmex

No libdip.m can be found in the dir.

Is it only this commit you intended to submit a PR for?
For the next time, please reset your fork to match the current status of this repository, so that the PR shows only relevant commits. It is a lot easier for me to merge your PR if its clean. Thank you!

I've pushed the change here: d10cb36c2a38dd37f1f2a2f2e95b927408d4df4d
Will push to master in the next few days.

Got it. Sorry for the inconvenience!
Yan
On Wed, Jun 17, 2020 at 5:19 PM Cris Luengo<EMAIL_ADDRESS>wrote:

Is it only this commit
https://github.com/DIPlib/diplib/pull/60/commits/19a5984bdcbc98dfc744db562383f3e3cd663b7e
you intended to submit a PR for?
For the next time, please reset your fork
https://stackoverflow.com/questions/9646167/clean-up-a-fork-and-restart-it-from-the-upstream/39628366
to match the current status of this repository, so that the PR shows only
relevant commits. It is a lot easier for me to merge your PR if its clean.
Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DIPlib/diplib/pull/60#issuecomment-645440146, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJNQ4T5R7EBAPA4KXJAXTQTRXDNHJANCNFSM4OAIUNJA
.


use build generated through npm run build:prod

Depends on PR #41

This change is

@kwk Please review this. It depends on PR #41

I have added the same change into PR #41


Dead man's switch

About the PR
Adds ReleaseSignaller component & system, and the Dead Man's Switch item.
Screenshots

https://user-images.githubusercontent.com/45957058/184096219-6502d58c-d2f1-459c-b458-32b182dfe97f.mp4
Changelog

:cl:

add: Added the Dead Man's Switch, a device that activates when you let go of it when armed.

i literally do not know why this is failing tests

addressing change requests now

maybe one day i'll resurrect this when i'm not being beaten by exams


[9.x] Adds whereIn helpers for querying relations

Adds additional whereIn helpers for simplified relation querying.
Example:
// Before
User::whereHas('posts', function ($query) {
    $query->whereIn('status', ['live', 'draft']);
})->get();

// After
User::whereRelationIn('posts', 'status', ['live', 'draft'])->get();

Helpers Added:
Model::whereRelationIn();
Model::orWhereRelationIn();

Model::whereRelationNotIn();
Model::orWhereRelationNotIn();

Model::whereMorphRelationIn();
Model::orWhereMorphRelationIn();

Model::whereMorphRelationNotIn();
Model::orWhereMorphRelationNotIn();

Rather than creating additional helper methods, which would have been a large amount of redundant code, the existing methods were refactored to consolidate the implementation of simplified relation querying.
Although methods have been removed, there are no breaking changes to affordances or backwards compatibility as they have been re-implemented via dynamic magic methods.
Contributors: @Orrison @jrseliga

+1

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


updated README.md with details

fork & pull example test

hello! thanks for help with practice tests! :1st_place_medal:


Slow SQL query: getYearlyIncome

https://github.com/opencollective/opencollective-api/blob/master/server/models/Collective.js#L2150
To be optimized or cached.


Add examples

This library is currently lacking documentation. A good step will be to add simple examples (with multiple domains) for each data structures that could serve as tutorial.
More complex examples would also be great, in particular for testing purposes.

Hey I'd like to take this up.
I've been going through the MS queue paper and I have a fair of that and other lockfree structures now.
Where should the examples go? The README or a separate examples/ directory?

Hey @nikochiko, thanks for your interest! MSQueue is a good one to start with. The examples can go to a new examples directory.

This has been done in recent PR for all data structures.


Possible bug: Conflict with pyim candidate display

As per above image, there should be the first candidate of pyim "删除" displayed on the buffer, but current it displays the copilot suggestion and it hides pyim's candidate, this is not an issue when the candidate is only one or two Chinese character, but if we are inputing a very long sentence, then hide the whole candidate will be an issue.

Is it ok to disable Copilot completion temporarily if there are any candidates from pyim (or any incomplete input)?
If so, I recommend you to custom copilot-disable-predicates to solve the problem.

I am not a pyim user, but I took a look at pyim source code.
A possible solution (untested):
  (customize-set-variable 'copilot-disable-predicates
                          '((lambda ()
                              (and (boundp 'pyim-preview-overlay)
                                   pyim-preview-overlay))))

Actually, it is not a bug. The reason behind the problem is that both pyim and copilot.el use overlays to provide inline previews, so they may overwrite each other. And I believe temporarily disabling Copilot when pyim is using overlay is the best solution.

copilot-disable-predicates only works in copilot-mode. See readme for more information.

After trying with pyim, I found another problem: post-command-hook is not called when inputting with pyim, so the copilot overlay can't be cleared timely.

Another possible solution is to disable copilot whenever pyim is enabled:
(customize-set-variable 'copilot-disable-predicates '(pyim-process-input-chinese-p))

Thanks :) I have applied this fix and is testing the behaviour

After trying with pyim, I found another problem: post-command-hook is not called when inputting with pyim, so the copilot overlay can't be cleared timely.

So I use advice to clear copilot overlay when typing in pyim.
(advice-add 'pyim-self-insert-command :after 'copilot-clear-overlay)


test: Quarantine Istio test for CI triaging

Disable Istio test for now to see if anything else is wrong with the CI.
Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

test-backport-1.8

test-backport-1.8

Closing in favor of https://github.com/cilium/cilium/pull/15750


MM 18912 Migrate 'utils/filter_users.js' and associated tests to TypeScript

Summary
Migrated utils/filter_users.jsx and associate test files to type script
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/12491
JIRA Link: https://mattermost.atlassian.net/browse/MM-18912

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Hey @MathewtheCoder, let us know if you have any questions about feedback from @devinbinnie? We'd be happy to clarify. Thanks for your contribution! :)

Sorry for not following up with the PR. I will look into the comment and fix the lint error.

@MathewtheCoder Gentle reminder to fix the merge conflict.

@hanzei Sorry for the slow response. I have fixed the merge conflicts and pushed the changes.

/update-branch

Thanks for returning back to this PR @MathewtheCoder :tada:


New path for data.ms?

Since v0.24.0, MeiliSearch runs using the meili users in the docker container. This involves a change regarding the path of the data.ms folder by default. It's now /home/meili/data.ms instead of /data.ms
Shouldn't we change the lines here according to the new path? I'm really asking, I don't know the answer, you have to check @alallema 😄
https://github.com/meilisearch/meilisearch-kubernetes/blob/9551441e118d8a391656357970aef38c46a850a9/charts/meilisearch/values.yaml#L60-L75
Related to: https://github.com/meilisearch/MeiliSearch/issues/1969

@curquiza, I'm not sure either but I think this path is where it will be mounted.
I will check that.

I think the path needs to be changed, because currently persistence is not working, after my pod is shut down, there is no data left

Hi @thanhtoan1196,
Sorry about this and thank you for letting us know.

In v0.25.0, the path of data.ms will be back to / and not /home/meili. More detail here to know why: https://github.com/meilisearch/MeiliSearch/issues/2051

I think we can close this issue @alallema then

I would like to check if the persistence works well with the v0.25.0 before.

Hi @thanhtoan1196,
Did you solve your problem? I just tested persistence with v0.1.26 if I shut down my pod it restarts with all the data.

I closed this issue because it is no longer relevant and no problems have been reported since.


Missing SPID number information in query window

SQL Operations Studio Version:

Steps to Reproduce:

Right Click on Server and select New Query.
At the bottom , i do see my SQL Server Instance name : database to which i am connected Line number,Column  Spaces UTF-X CRLF SQL  bu ti can not see the SPID number that has been established for this.

Thanks
Gauravdeep Singh
<EMAIL_ADDRESS>

@gajuneja closing this issue as a dup of https://github.com/Microsoft/sqlopsstudio/issues/229.  This is something that we plan to improve in an upcoming release.


Issue with setting a phonecall format field in UCI

Hi,
I am having difficulties trying to setvalue for single line of text fields on a CRM form which have a format other than Text. Example if you look at telephone1 field on a form i keep getting the following error when trying to set it
Details: invalid element state: Element is not currently interactable and may not be manipulated
(Session info: chrome=75.0.3770.100)
(Driver info: chromedriver=74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Windows NT 6.1.7601 SP1 x86_64)
all im doing is trying to set it normally and the field is active on the form
xrmApp.Entity.SetValue("telephone1", "12345678");
Anyone experienced this? i habe also tried on a field having a duration format and whilst i could actually set that i couldnt get rid of the --- that now shows up on the form when there is no value so the format threw an exception.

Thanks
Charmaine

Thanks @chfarr for raising this. I'll quick setup a repro and assuming no issues getting it reproduced, will let you know once a fix is made available.
Warm Regards,
Tyler


Header repeated every 30 mins when Serilog configured to rollOnFileSizeLimit

A Header is being incorrectly added to a log file at exactly 30 min intervals when Serilog is configured to roll a log file when reaching a file size limit.  Our Serilog initialisation code is shown below:
// Assemble the file header that's written when the log is created and repeated at the top of each log file. header.AppendLine(new string('*', 120)); header.AppendLine(string.Format("Application started at {0} {1}", startTime.ToShortDateString(), startTime.ToShortTimeString())); header.AppendLine(String.Format("Executable: {0}. Version {1}.{2} Build {3}.", System.Reflection.Assembly.GetExecutingAssembly().Location, System.Diagnostics.FileVersionInfo.GetVersionInfo(System.Reflection.Assembly.GetExecutingAssembly().Location).FileMajorPart, System.Diagnostics.FileVersionInfo.GetVersionInfo(System.Reflection.Assembly.GetExecutingAssembly().Location).FileMinorPart, System.Diagnostics.FileVersionInfo.GetVersionInfo(System.Reflection.Assembly.GetExecutingAssembly().Location).FileBuildPart)); header.AppendFormat("Environment: Host = '{0}'; Operating System = '{1}', Region = '{2}'; Installed UI Culture = '{3}'.", Environment.MachineName, Environment.OSVersion, culture.EnglishName, culture.Name);
Log.Logger = new LoggerConfiguration()
	.Enrich.FromLogContext()
	.Enrich.WithThreadId()
	.Enrich.WithThreadName()

	.MinimumLevel.ControlledBy(levelSwitch)

	.WriteTo.File(FileName,
		buffered: false,
		fileSizeLimitBytes: Size * 1048576,  // Convert to Bytes
		retainedFileCountLimit: Retain,
		rollOnFileSizeLimit: true,
		outputTemplate: "{Timestamp:dd/MM/yyyy HH:mm:ss.fff} {Level:u3} [{ThreadId} {ThreadName}] {Message:lj}{NewLine}{Exception}",
		hooks: new HeaderWriter(header.ToString,true))

 .CreateLogger();

I've been able to replicate this. As I thought, it's an issue in the Serilog File Sink, rather than this extension - I'll go ahead and open an issue in that repo, linking it back to here.

Thanks for following up. I’ve had a look at the issue you’ve logged for the serilog-file-sink and will watch that with interest.

I have experienced the same issue with Serilog when using rollOnFileSizeLimit.
The log header is repeated every 30 minutes, which seems to be an unexpected behavior.
Any updates on a fix or workaround for this?

@Yassiinee this is a known issue with the Serilog file sink, but I never did find time to get a working fix in place. If you'd like, please feel free to have a go at a fix: https://github.com/serilog/serilog-sinks-file/issues/157


chore: replace to github app token for actions

Description

Uses the github app token rather than the bot account token for actions permission.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


use new machine-readable octez-node snapshot info for snapshot engine metadata

Starting with v15 of octez, it is possible to do octez-node snapshot info --json.
example:
nochem@peck ~/workspace/tezos () $ ./octez-node snapshot info limanet.full  --json
{ "snapshot_header":
    { "version": 5, "chain_name": "TEZOS_LIMANET_2022-10-13T15:00:00Z",
      "mode": "full",
      "block_hash": "BLza26ixZkD85YZz5beXnjjP4KstPnrG3QxK1jgcD5M4v2ewqRC",
      "level": 315393, "timestamp": "2022-12-11T02:05:45Z",
      "context_elements": 237547 } }

add a check in the snapshot maker job that the level, timestamp and hash correspond to what we are expecting.
add context_elements and version to the snapshot metadata, with version renamed to snapshot_version.

https://www.jsonschemavalidator.net/
{ "$schema": "http://json-schema.org/draft-04/schema",
"title": "Tezos Snapshots",
"description": "List of all available Tezos Snapshots",
  "type": "array",
  "items":
  {
    "type": "object",
    "description": "A single Tezos Snapshot",
    "Properties":
    {
      "block_hash": {
        "type": "string",
        "description": "A reference for a block in the Tezos blockchain.",
        "examaples": [
          "BMHv8Rmx2QQtN786bUCuAxxemTmdJxaonbmUALifMYtivT13Hxg"
        ]
      },
      "block_height": {
        "type": "string",
        "description": "The number of blocks preceding this one in the blockchain",
        "examaples": [
          "438782"
        ]
      },
      "block_timestamp": {
         "type": "YEAR-MONTH-DAYHOURS:MINUTES:SECONDS Timestamp of the current block UTC" ,
         "description": "",
         "examaples": [
          "2023-01-02T08:17:20Z"
         ]
      },
      "filename": {
        "type": "string",
        "examaples": [
          "tezos-limanet-rolling-tarball-438782.lz4"
        ]
      },
      "url": {
        "type": "string",
        "description": "Reference to this file on the web",
        "examaples": [
          "https://limanet-v15.xtz-shots.io/tezos-limanet-rolling-tarball-438782.lz4"
        ]
      },
      "sha256": {
        "type": "string",
        "description": "Unique 64-bit value identifying this file",
        "examaples": [
          "7961409dad2b8ff917551eea4a5178c1a6d95a21f807f1020a34e3acedaaad4c"
        ]
      },
      "filesize_bytes": {
        "type": "string",
        "examaples": [
          "53963264"
        ]
      },
      "filesize": {
        "type": "string",
        "description": "Size of file in kilobytes (K), megabytes (M), gigabytes (G) or terabytes (T)",
        "examaples": [
          "6G",
          "51M"
        ]
      },
      "tezos_version": {
        "type": "string",
        "description": "Tezos version running on the node this data is from",
        "examaples": [
          "763259c5 (2022-12-01 10:20:58 +0000) (15.1)"
        ]
      },
      "chain_name": {
        "type": "string",
        "description": "Name of Tezos blockchain- mainnet, or testnet.",
        "examaples": [
          "mainnet",
          "ghostnet"
        ]
      },
      "history_mode": {
         "type": "string",
         "description": "Type of chain data contained in snapshot",
         "examaples": [
          "rolling",
          "archive"
         ]
        },
      "artifact_type": {
        "type": "string",
        "description": "Tarball or Tezos Snapshot",
        "examaples": [
          "tarball",
          "tezos-snapshot"
        ]
      },
      "snapshot_version": {
        "type": "string",
        "description": "Version of Tezos snapshot engine (.snapshot). Tarball will not have a snapshot_version.",
        "examples": [
          "5",
          "4",
          ""
        ]
      },
      "context_elements": {
        "type": "string",
        "description": "Number of references to each preceding block's ledger state.",
        "examples": [
          "38984460"
        ]
      }
    }
  }
}

Includes new tezos_version.
{
  "$schema": "http://json-schema.org/draft-04/schema",
  "title": "Tezos Snapshots",
  "description": "List of all available Tezos Snapshots",
  "type": "array",
  "items": {
    "type": "object",
    "description": "A single Tezos Snapshot",
    "Properties": {
      "block_hash": {
        "type": "string",
        "description": "A reference for a block in the Tezos blockchain.",
        "examples": [
          "BMHv8Rmx2QQtN786bUCuAxxemTmdJxaonbmUALifMYtivT13Hxg"
        ]
      },
      "block_height": {
        "type": "string",
        "description": "The number of blocks preceding this one in the blockchain",
        "examples": [
          "438782"
        ]
      },
      "block_timestamp": {
        "type": "string",
        "description": "ISO 8601 timestamp of the current block UTC",
        "examples": [
          "2023-01-02T08:17:20Z"
        ]
      },
      "filename": {
        "type": "string",
        "examples": [
          "tezos-limanet-rolling-tarball-438782.lz4"
        ]
      },
      "url": {
        "type": "string",
        "description": "Reference to this file on the web",
        "examples": [
          "https://limanet-v15.xtz-shots.io/tezos-limanet-rolling-tarball-438782.lz4"
        ]
      },
      "sha256": {
        "type": "string",
        "description": "Hashed sum of file contents for checking data integrity.",
        "examples": [
          "7961409dad2b8ff917551eea4a5178c1a6d95a21f807f1020a34e3acedaaad4c"
        ]
      },
      "filesize_bytes": {
        "type": "string",
        "examples": [
          "53963264"
        ]
      },
      "filesize": {
        "type": "string",
        "description": "Size of file in kilobytes (K), megabytes (M), gigabytes (G) or terabytes (T)",
        "examples": [
          "6G",
          "51M"
        ]
      },
      "tezos_version": {
        "type": "object",
        "description": "Tezos version running on the node this data is from",
        "Properties": {
          "version": {
            "type": "object",
            "major": {
              "type": "integer"
            },
            "minor": {
              "type": "integer"
            },
            "additional_info": {
              "type": "string"
            }
          },
          "network_version": {
            "type": "object",
            "Properties": {
              "chain_name": {
                "type": "string"
              },
              "distributed_db_version": {
                "type": "integer"
              },
              "p2p_version": {
                "type": "integer"
              }
            }
          },
          "commit_info": {
            "type": "object",
            "commit_hash": {
              "type": "string"
            },
            "commit_date": {
              "type": "string"
            }
          }
        },
        "chain_name": {
          "type": "string",
          "description": "Name of Tezos blockchain- mainnet, or testnet.",
          "examples": [
            "mainnet",
            "ghostnet"
          ]
        },
        "history_mode": {
          "type": "string",
          "description": "Type of chain data contained in snapshot",
          "enum": ["archive", "rolling"]
        },
        "artifact_type": {
          "type": "string",
          "description": "Tarball or Tezos Snapshot",
          "enum": ["tarball", "tezos-snapshot"]
        },
        "snapshot_version": {
          "type": "string",
          "description": "Version of Tezos snapshot engine (.snapshot). Tarball will not have a snapshot_version.",
          "examples": [
            "5",
            "4",
            ""
          ]
        },
        "context_elements": {
          "type": "string",
          "description": "Number of references to each preceding block's ledger state.",
          "examples": [
            "38984460"
          ]
        }
      }
    }
  }
}

so are we leaving block_height and context_elements as string? both are number in octez-node snapshot info --json, I think we should match that

Didn't we decide to not include "network_version"?
also, chain_name example in
"chain_name": {
          "type": "string",
          "description": "Name of Tezos blockchain- mainnet, or testnet.",
          "examples": [
            "mainnet",
            "ghostnet"
          ]
        },

is wrong/gives wrong idea, chain name is what Tezos RPC reports, like "TEZOS_ITHACANET_2022-01-25T15:00:00Z", not a config alias recognized by octez-client

the way schema is written above, looks like everything is optional; there's probably a set of properties without which snapshot metadata is not useful/usable, those should be required.

@itkach This is all very helpful thank you!

so are we leaving block_height and context_elements as string? both are number in octez-node snapshot info --json, I think we should match that

Yes thanks for bringing this up again. Sorry about the repetition- I am working on getting the basic format through our workflow and validating it and then I was going to finalize the values.

Didn't we decide to not include "network_version"?
also, chain_name example in
"chain_name": {
"type": "string",
"description": "Name of Tezos blockchain- mainnet, or testnet.",
"examples": [
"mainnet",
"ghostnet"
]
},
is wrong/gives wrong idea, chain name is what Tezos RPC reports, like "TEZOS_ITHACANET_2022-01-25T15:00:00Z", not a config alias recognized by octez-client

Awesome- will correct this! Thanks.

the way schema is written above, looks like everything is optional; there's probably a set of properties without which snapshot metadata is not useful/usable, those should be required.

This is VERY helpful. I couldn't figure out why I was only getting JSON validation and not actual schema validation. Turns out this is why. Everything is optional! Doh


Build with Bazel and Pants

This could come up being handy to be able to be able to build this project with Bazel and/or Pants.
@pcj tried once: https://github.com/google/cargo-raze/issues/64

/cc @Quarz0


Fix panic with 'stuck spinlock' during crash recovery tests

Fix panic with 'stuck spinlock' during crash recovery tests
Problem:
Isolation crash recovery tests (for example, uao_crash_compaction_column,
crash_recovery_dtm, etc.) failed with 'stuck spinlock' panic with very low
reproduction rate.
Cause:
Problem happened in the following case:

During the test, a backend process was forced into a panic (according to test
scenario).
At the very same moment, the background writer process called
'SIMPLE_FAULT_INJECTOR("fault_in_background_writer_main")', he did it regularly
from the loop in 'BackgroundWriterMain'. The bg writer acquired the spinlock
inside the fault injector, but before it released it...
Postmaster started to send the SIGQUIT signal to all child processes.
Background writer process received SIGQUIT and halted its execution without
releasing the spinlock.
In the background writer process, a handler for the SIGQUIT signal was
invoked - 'bg_quickdie'. And 'bg_quickdie' called
'SIMPLE_FAULT_INJECTOR("fault_in_background_writer_quickdie");'. As the spinlock
was not released, 'bg_quickdie' hanged on the spinlock.
Postmaster failed to wait child processes completion. And after timeout it
tried to check 'SIMPLE_FAULT_INJECTOR("postmaster_server_loop_no_sigkill")' and
hanged on the same spinlock as well.
Finally, both postmaster and 'bg_quickdie' failed with 'stuck spinlock'
panic.

Fix:
The general rule would be that it is NOT allowed to access the fault injector
from the postmaster process or from any SIGQUIT handler of child processes when
the system is resetting after the crash of some backend. It is so because during
reset postmaster terminates child processes, and it might terminate some process
when the process has acquired the spinlock of the fault injector, but hasn't
released it yet. So, subsequent calls to the fault injector api from postmaster
or any SIGQUIT handler will lead to deadlock. Only 'doomed' processes can still
call the fault injector api, as they will soon be terminated anyway. According
to written above, following changes are made:

Access to the fault injector during a reset is removed from 'bg_quickdie' and
postmaster's ServerLoop.
The fts_segment_reset test and related code are redesigned. Now, instead of
sleeping for a delay defined by the test in 'bg_quickdie', postmaster sends
SIGSTOP to the bg writer, and starts a timer for the delay. Once the delay
elapses, the timer handler sends SIGCONT and SIGQUIT to the bg writer. This
logic is triggered if the postmaster detects the new fault
"postmaster_delay_termination_bg_writer" (which is a replacement for
"fault_in_background_writer_quickdie" and "postmaster_server_loop_no_sigkill").
This fault is checked only when the postmaster is in the PM_RUN state. So it
should be safe to check for it.

New tests specific to this issue are not added because of the unstable nature of
the problem.

Allure report https://allure.adsw.io/launch/67342

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1200047

Allure report https://allure.adsw.io/launch/67375

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1200320

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1200321

Allure report https://allure.adsw.io/launch/67528

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1209547

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1209548

Given we stop the Postmaster from killing children with SIMPLE_FAULT_INJECTOR("postmaster_server_loop_no_sigkill"), why are we encountering the deadlock? Can you explain this point in the description?

Refer to the comments just above the place where the SIMPLE_FAULT_INJECTOR("postmaster_server_loop_no_sigkill") was:
		/*
		 * If we already sent SIGQUIT to children and they are slow to shut
		 * down, it's time to send them SIGKILL.  This doesn't happen
		 * normally, but under certain conditions backends can get stuck while
		 * shutting down.  This is a last measure to get them unwedged.
		 *
		 * Note we also do this during recovery from a process crash.
		 */

So by this time all child processes should be terminated (refer to reaper). If someone hangs, postmaster killd it with SIGKILL from here.
But that is something we do not want for the test. Thus "postmaster_server_loop_no_sigkill" prevented sending SIGKILL to the bg writer during the test.

Allure report https://allure.adsw.io/launch/67581

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1211760

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1211761

So by this time all child processes should be terminated (refer to reaper). If someone hangs, postmaster killd it with SIGKILL from here.

So the main point is that the Postmaster's SIGQUIT can be received while Fault Injector's lock is still taken, leaving it locked forever. But in the description, it is stated that Postmaster "kills", which is slightly confusing. The PR description should be reworded to clarify how SIGQUIT and SIGKILL work together in this context.
Additionally, the "Reason: " in the "Fix: " paragraph should be a separate title, judging by the other titles. The "Fix: " and "Solution is following: " sections can be merged to make description more concise. In "Solution is following: ", points 1, 2, 4 may be omitted, due to being easy to find in the PR diff.
When reading the description, it should be easy to understand which behavior was incorrect and has been corrected, and which behavior is correct and remains unchanged. One way to differentiate this could be using past and present tense to indicate this distinction:
may fail with 'stuck spinlock' panic --> would fail with 'stuck spinlock' panic;
'SIMPLE_FAULT_INJECTOR_WITH_PARAM' was added --> 'SIMPLE_FAULT_INJECTOR_WITH_PARAM' is added;

So the main point is that the Postmaster's SIGQUIT can be received while Fault Injector's lock is still taken, leaving it locked forever. But in the description, it is stated that Postmaster "kills", which is slightly confusing. The PR description should be reworded to clarify how SIGQUIT and SIGKILL work together in this context.
Additionally, the "Reason: " in the "Fix: " paragraph should be a separate title, judging by the other titles. The "Fix: " and "Solution is following: " sections can be merged to make description more concise. In "Solution is following: ", points 1, 2 may be omitted, due to being easy to find in the PR diff.
When reading the description, it should be easy to understand which behavior was incorrect and has been corrected, and which behavior is correct and remains unchanged. One way to differentiate this could be using past and present tense to indicate this distinction: may fail with 'stuck spinlock' panic --> would fail with 'stuck spinlock' panic; 'SIMPLE_FAULT_INJECTOR_WITH_PARAM' was added --> 'SIMPLE_FAULT_INJECTOR_WITH_PARAM' is added;

Updated the description, please check

Allure report https://allure.adsw.io/launch/67764

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1220815

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1220816

Allure report https://allure.adsw.io/launch/68415

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1244812

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1244813


[FEATURE] Allow to add a [skip ci] for  cog commit

currently implementation of skip ci only works for  bump command.  e.g., cog bump --skip-ci <string>
I like to use this for normal commits as well. for example, don't want my CI to run jobs for commits I know it is a waste of time.
# assume I have  skip_ci = "[skip ci]" in cog.toml
cog commit docs "added cli options" cli --skip-ci

@oknozor In my opinion this would be a good addition :) Since I implemented this feature I can also work on this issue starting next week if you want ! ;)
@xmlking As you said It would be just like the bump command, by either giving the string in the CLI or the cog.toml, with priority on the CLI argument.
Wassim.

This feature really help skipping  unnecessary vercel builds and GitHub Actions   for commits we know not required to run CI actions.

Hey @xmlking,
I just saw your message in the previous skip-ci issue and like you said, if we want to add the skip-ci feature in the cog commit command, it would be better to configure skip_ci in the cog.toml and let the --skip-ci option be a boolean that would juste append the skip_ci configuration to the end of the (bump) commit.
Having the possibility to override the skip_ci with the CLI doesn't add any value since the pattern is the same across all commits on a Git Platform, and if we are working on multiple Git Platforms we could just have it in the cog.toml.
However this would be a breaking change :/ @oknozor if you have some time I'd be interested to hear your opinion on this

Hey @xmlking,
I just saw your message in the previous skip-ci issue and like you said, if we want to add the skip-ci feature in the cog commit command, it would be better to configure skip_ci in the cog.toml and let the --skip-ci option be a boolean that would juste append the skip_ci configuration to the end of the (bump) commit.
Having the possibility to override the skip_ci with the CLI doesn't add any value since the pattern is the same across all commits on a Git Platform, and if we are working on multiple Git Platforms we could just have it in the cog.toml.
However this would be a breaking change :/ @oknozor if you have some time I'd be interested to hear your opinion on this

it would be better to configure skip_ci in the cog.toml and let the --skip-ci option be a boolean that would juste append the skip_ci configuration to the end of the (bump) commit.

I think it would be better to have both the ability to just use a boolean flag whenever the the skip ci pattern is configured in cog.toml and to specify the pattern (--skip-ci "[skip ci]"), either when its missing from the cog.toml config or, to override the current one.
Doing it like so provides more flexibility and avoid the breaking change I guess.
To summarize we have the following use cases:
cog commit --skip-ci # works if `skip_ci` pattern is set in cog.toml
cog commit --skip-ci # fails if `skip_ci` pattern is not set in cog.toml
cog commit --skip-ci "[skip-ci]" # always work, override the current pattern if set

And cog bump should behave like this as well.

Good option yeah :) I'll be working toward this solution then ! I'll keep you guys in touch

Can we also set [skip ci] pattern as default if nothing set in cog.toml ?
This pattern is default for GitHub , Jenkins , Gitlabs and more

Hey guys,
Currently working on it, there is still one last point that needs to be clarified : what would happen if someone has skip_ci set in their cog.toml, but doesn't use the --skip-ci option in their bump or commit command, e.g :
cog bump --auto # has skip_ci = "[skip-ci]" in cog.toml

Should it add the skip_ci to the end of the commit ? IMO yes since it would be the only way to avoid breaking change, but it's kind of confusing with the --skip-ci sometimes acting as a boolean, and as a way to pass a string.
Wassim.

Should it add the skip_ci to the end of the commit ?
Skip-ci should never be used implicitly so, no.

IMO yes since it would be the only way to avoid breaking change, but it's kind of confusing with the --skip-ci sometimes acting as a boolean, and as a way to pass a string.

How would this be a breaking change ?

Because the current behavior automatically detects the  skip_ci in the cog.toml without having to add the --skip-ci option. Now we control everything through the --skip--ci option

The idea behind this is that we would have the same behavior between the bump and the commit command

Hey @oknozor, any favourite approach for this issue ?

@ABWassim keep following  behavior for both commit and bump or any other future commit like commands...
if bump not doing like below, it is a bug. this is what typical uses expect.
cog commit --skip-ci # works if `skip_ci` pattern is set in cog.toml
cog commit --skip-ci # fails if `skip_ci` pattern is not set in cog.toml
cog commit --skip-ci "[skip-ci]" # always work, override the current pattern if set

cog bump --skip-ci # works if `skip_ci` pattern is set in cog.toml
cog bump --skip-ci # fails if `skip_ci` pattern is not set in cog.toml
cog bump --skip-ci "[skip-ci]" # always work, override the current pattern if set

@xmlking So it would be a breaking change, since the current behavior is to apply the skip_ci pattern without having to use the the --skip-ci option.
What do you think @oknozor ?

Let's go for the breaking change :)

Hi again,
Any idea of how i could make the argument behave as a boolean and something that takes a string ? I'm kind of struggling finding the cleanest way of doing this 😆

Let’s say skip-ci command line argument  type is string, if it’s value it empty/nil , then it is considered false, otherwise it’s value it the value used passed

@Wassim-AB  https://github.com/clap-rs/clap/discussions/5183

Thanks for the support guys, really appreciate ;)

Wow you're really fast 😆 I left a comment in the PR :)

Hey @xmlking, PR just got merged !
skip-ci now acts as a boolean that will add the string defined in the cog.toml, or defaults to [skip ci]. The skip-ci-override argument takes a string that will take precedence. No need to define both :
cog <bump|commit> --skip-ci # works, adds default [skip ci] or cog.toml defined string to the commit
cog <bump|commit> --skip-ci-override [ci-skip] # works, adds [ci-skip] to the commit

Kudos to @ABWassim this is now available in v6


Refactor repairnator.json generation

This PR adds the implementation for the generation of repairnator.json according to the new schema (PR #711). As a result, the classes Metrics and MetricsSerializerAdapter will be deleted, and also the method JobStatus.writeProperty.

@surli, I have test failures here because of the property projectMetrics.numberLines. The result from cloc is 0. I don't know how to fix that. In the last case, I will put this property as to be ignored in the test.

Ok for ignoring the property, put a comment why you do that in the test then.

@surli, the info on the machine is recorded only when the pipeline is ending. However, the freeMemory should not be calculated when it's starting? For each step, it's the same thing: the freeMemory is recorded after the execution, but it should not be before?

Pull Request Test Coverage Report for Build 2094

70 of 105 (66.67%)  changed or added relevant lines in 17 files are covered.
8 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-1.3%) to 52.524%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repairnator/repairnator-core/src/main/java/fr/inria/spirals/repairnator/serializer/SerializerType.java
0
1
0.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/pipeline/Launcher.java
0
1
0.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/step/WritePropertyFile.java
4
5
80.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/inspectors/properties/projectMetrics/ProjectMetrics.java
2
3
66.67%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/inspectors/JobStatus.java
12
14
85.71%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/serializer/InspectorTimeSerializer.java
0
2
0.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/step/paths/ComputeSourceDir.java
3
6
50.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/inspectors/properties/machineInfo/MachineInfo.java
9
13
69.23%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/inspectors/ProjectInspector.java
19
28
67.86%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/serializer/PropertiesSerializer.java
0
11
0.0%

Files with Coverage Reduction
New Missed Lines
%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/inspectors/properties/reproductionBuggyBuild/ProcessDurations.java
1
87.5%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/pipeline/Launcher.java
1
0.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/step/CloneRepository.java
1
75.0%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/step/checkoutrepository/CheckoutRepository.java
1
85.71%

repairnator/repairnator-pipeline/src/main/java/fr/inria/spirals/repairnator/process/inspectors/properties/repository/Repository.java
4
40.91%

Totals

Change from base Build 2069:
-1.3%

Covered Lines:
2757

Relevant Lines:
5249

💛  - Coveralls

For each step, it's the same thing: the freeMemory is recorded after the execution, but it should not be before?

Not necessarily as long as we keep the same behaviour everywhere.

@surli, this PR seems just fine for me, you can start review it if you want, but the build should break because of the check branches. I will now generate the testing branches again.

@surli, the testing branches are updated. Now it's really to wait for Travis. If you would like to have a look in the new repairnator.json, you can find an example here: https://github.com/fermadeiral/test-check-branches/tree/surli-failingProject-208897371-20170308-060702

@surli, I have no idea why the last build is failing.

It's again related with the previous bug. So let's ignore that test with a strong comment for future fixing.

Once this PR is merged, I start the release process. It might take time so I prefer to begin it early.

Will it be still possible for me to change the commit messages while you start the release process?

Will it be still possible for me to change the commit messages while you start the release process?

Start a new PR by creating a new branch from this one. A do the change on the commit msg now.


Parser cannot parse val named ->

You can see this when running scalariformFormat on akka/akka#19936:
[warn] Scalariform parser error for akka-actor/src/main/scala/akka/actor/FSM.scala: illegal start of simple pattern: Token(RARROW,->,11268,->)

This issue was moved to scala-ide/scalariform#203


Add files to req.files instead when falcon is ready for that

Once falconry/falcon#493 has been merged, lets add files into req.files instead of in the params as it is now, and add non files keys to req.form.

The issue to follow is now https://github.com/falconry/falcon/issues/953

falconry/falcon#418


bug: I have a problem with a checkbox into a modal. It cant modify the variable boolean of the controller.

Type: bug
Platform: desktop browser
 http://codepen.io/josemadev/pen/ojYKWp?editors=101

Greetings @josemadev!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Modified your codepen, basically the problem was that you bound your shared variable directly to the scope.
http://codepen.io/anon/pen/zvNOGR?editors=101
For detailed information check back here: https://egghead.io/lessons/angularjs-the-dot

Thanks!


Restarting etcd proxy instance - fails to start (unknown wal version in data dir)

Hi,
Running version 2.0.5 of etcd (and originally experienced the issue on 2.0.3). One of my proxy nodes was rebooted and did not come online, with the following message:
Mar 18 09:56:05 ip-10-0-1-113.ec2.internal writer_process[1105]: 2015/03/18 09:56:05 etcd: unknown wal version in data dir /opt/etcd
It appears this issue previously existed in #1899 and was fixed in #1913 for 0.50.
I can confirm as per the original issue, deleting the proxy folder results in it starting successfully.

This should be fixed by https://github.com/coreos/etcd/pull/2526. Next release will include this fix.

Closing as a duplicate of #2529. Thanks.


Line Series bound Y Axes not displayed after data template swap.

How to reproduce?
This issue occurs after a switch of DataTemplate's which each show different LiveChart displays.
On the first DataTemplate there is a Cartesian Chart which displays numerous LineSeries which have a bound 'AxisY' collection to the View Model, this Axis Collection is build up in the View Model from the different Line Series data sources. At first the Y Axes are displayed correctly:

But if I switch to another DataTemplate to display other data and switch back to the original view the Y Axes are not displayed:

Currently I build each of the Y Axes like so:
new LiveCharts.Wpf.Axis
 {
    DataContext = this,
    MaxValue = axisModel.Max,
    MinValue = axisModel.Min
 };

And add them to the collection like so:
this.axes = new AxesCollection();
this.axes.Add(dataSliceViewModel.LineSeries.YAxis.Axis);

I am binding to the AxesCollection in xaml like so:
AxisY="{Binding Path=Axes}"

It should be noted that this behavior only occurs if the AxisY is bound to a collection on the View Model. If I simply have a Y Axis and bind it's Max and Min values it will be correctly displayed between switching of the Data Templates.
Extra notes
I would expect that the Graph would be correctly build after the switch of Data Templates especially if no changes were made to the underlying Axes after the Data Templates were swapped.
As said this only appears to occur if the AxisY is bound to a collection, and does not occur if the Axes are pre-configured.
I am using

Live-Charts version
0.7.13

.Net Version
4.6.2

Windows
7

Hello, thanks for the report, I was not able to reproduce with latest, maybe it got fixed with a previous commit.
Am I doing it right?
namespace LiveChartsTesterGuy
{
    /// <summary>
    /// Interaction logic for MainWindow.xaml
    /// </summary>
    public partial class MainWindow
    {
        public MainWindow()
        {
            InitializeComponent();
        }

        private void ButtonBase_OnClick(object sender, RoutedEventArgs e)
        {
            if (ContentControl.ContentTemplate == null)
            {
                ContentControl.ContentTemplate = (DataTemplate) Grid.FindResource("Template1");
            }
            else
            {
                ContentControl.ContentTemplate = null;
            }
        }
    }

    public class Template1Vm
    {
        public Template1Vm()
        {
            AxesCollection = new AxesCollection
            {
                new Axis(),
                new Axis(),
                new Axis()
            };
        }

        public AxesCollection AxesCollection { get; set; }
    }
}

<Grid Name="Grid">
        <Grid.Resources>
            <DataTemplate x:Key="Template1">
                <lvc:CartesianChart AxisY="{Binding AxesCollection}">
                    <lvc:CartesianChart.DataContext>
                        <local:Template1Vm></local:Template1Vm>
                    </lvc:CartesianChart.DataContext>
                    <lvc:CartesianChart.Series>
                        <lvc:LineSeries Values="1,6,2" ScalesYAt="0"/>
                        <lvc:LineSeries Values="30,50,70" ScalesYAt="1"/>
                        <lvc:LineSeries Values="20,30,20" ScalesYAt="2"/>
                    </lvc:CartesianChart.Series>
                </lvc:CartesianChart>
            </DataTemplate>
        </Grid.Resources>
        <ContentControl Name="ContentControl"></ContentControl>
        <Button Click="ButtonBase_OnClick" VerticalAlignment="Top" HorizontalAlignment="Left">ToggleTemplate</Button>
    </Grid>

I am closing this issue since I am not able to reproduce.
Thanks for the report.


Structured logs for relayer logic

Closes: #1537
Description

For contributor use:

[ ] Added a changelog entry, using unclog.
[ ] If applicable: Unit tests written, added test to CI.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

Post-merge artifact that might need our attention: when we encounter an account sequence number mismatch error, we see the following error message missing any tracking id:
2022-01-10T13:45:14.341974Z WARN ThreadId(1723) task PacketWorker(ibc-1:transfer/channel-0 -> ibc-0) encountered ignorable error: link errror: failed with underlying error: gRPC call failed with status: status: InvalidArgument, message: "account sequence mismatch, expected 86, got 85: incorrect account sequence: invalid request", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc"} }

@adizere The problem with that tracing entry is that it is produced higher up in the call stack than the specific task that creates the tracking id.

Mikhail and I had one more sync. session on this PR and we're both in agreement that this is ready for merging. It's a great first step in making the relayer's logs less grating on the eyes (and the codebase more idiomatic). The last nit is the changelog.
Cool stuff.


Rename or merge GO:0015563 uptake transmembrane transporter activity and children

Following up on #14322

GO ID
Term
Action

GO:0015563
uptake transmembrane transporter activity
Merge into GO:0022857 transmembrane transporter activity (No annotations, no InterPro mappings)

GO:0005274
allantoin uptake transmembrane   transporter activity
rename allantoin secondary transmembrane   transporter activity

GO:0080138
borate uptake transmembrane   transporter activity
merge into GO:0046715 borate   transmembrane transporter activity (since protein annotated by TAIR   @tberardini - annotated to both terms)

GO:0015088
copper uptake transmembrane   transporter activity
merge into GO:0005375 copper ion transmembrane transporter activity - EXP annotations: SGD:S000006328; SGD:S000004403; SGD:S000001218; TAIR	TAIR:locus:2049113; CGD	UniProtKB:Q59NP1; TAIR	TAIR:locus:2133965; SGD	SGD:S000000855; RGD	RGD:620059; MGI	MGI:MGI:1333843; FlyBase	FB:FBgn0062413; FlyBase	FB:FBgn0062412; EcoCyc	UniProtKB:P0A8H3; CGD	CGD:CAL0000196962

GO:0015639
ferrous iron uptake transmembrane   transporter activity
merge into  GO:0015093 ferrous iron transmembrane transporter activity - single EXP annotation P49281 (Swiss-Prot)

GO:0015659
formate uptake transmembrane   transporter activity
merge into GO:0015499 formate transmembrane transporter activity Single annotation Slc26a6 MGI

GO:0015092
high-affinity ferric iron uptake   transmembrane transporter activity
Renamed high-affinity ferric iron transmembrane transporter activity - Removed x-reference to http://www.tcdb.org/search/result.php?tc=9.A.10.1.1 as this entry does not mention iron transport - No annotations

GO:0061840
high-affinity ferrous iron uptake   transmembrane transporter activity
Renamed remove uptake - Single annotation Pombase fip1, also annotated to BP iron import

GO:0000006
high-affinity zinc uptake   transmembrane transporter activity
Renamed remove uptake - 3 EXP annotations ZRT1 SGD:S000003224, Zrt1 PomBase:SPBC16D10.06, ZnuB UniProtKB:P39832	 EcoCyc

GO:0015318
inorganic solute uptake   transmembrane transporter activity TO DO: request to obsolete

GO:1901549
malonic acid uptake transmembrane   transporter activity
merge into GO:1901239 malonate(1-) transmembrane transporter activity - Single annotation Pombase mae1

GO:0015638
microcin uptake transporter activity
Rename microcin transmembrane transporter activity & fix definition - Single annotation sbmA P0AFY6 EcoCyc

GO:0015513
nitrite uptake transmembrane   transporter activity
Renamed high-affinity secondary active nitrite transmembrane transporter activity based on existing parent (secondary active) and annotations (to proteins named high-affinity transporter) & Fixed logical definition - EXP annotations to 8 proteins: AspGD:ASPL0000073089 (AspGD), AspGD:ASPL0000056693 (AspGD), AspGD:ASPL0000060467(AspGD), AspGD:ASPL0000056693   (AspGD),  UniProtKB:Q5AST3 (AspGD), UniProtKB:P22152 (AspGD), UniProtKB:G5EB18  (AspGD), UniProtKB:P10903 (EcoCyc), UniProtKB:P0AC26 (EcoCyc).

GO:0015558
p-aminobenzoyl-glutamate uptake transmembrane transporter activity
Merge parent     GO:0015569   p-aminobenzoyl-glutamate transmembrane transporter activity (no annotation) into GO:0015558 Single annotation P46133 EcoCyc - See https://github.com/geneontology/go-annotation/issues/1672, renamed secondary active p-aminobenzoyl-glutamate transmembrane transporter activity, added missing parent and updated definition

GO:0015544
phenyl propionate uptake uniporter   activity
No annotations, rename phenyl propionate uniporter activity

GO:0015388
potassium uptake transmembrane   transporter activity
Merge into GO:0015079 potassium ion transmembrane transporter activity - 4 EXP annotations:  PomBase:SPAC3F10.02c, UniProtKB:P0AFZ7 EcoCyc,  UniProtKB:P23849	(CACAO + EcoCyc). Consider annotating to the BP     GO:1990573  potassium ion import across plasma membrane

GO:0015541
secondary active cyanate uptake   transmembrane transporter activity
No annotations. Renamed remove uptake

GO:0015636
short-chain fatty acid uptake   transporter activity
1 EXP annotation Q8IVM8 Swiss-Prot Merge  parent     GO:0015635   short-chain fatty acid transporter activity (No annotations) into GO:0015636 &   rename TM transporter activity

GO:0015344
siderophore uptake transmembrane   transporter activity
TO DO Merge into parent GO:0015343 siderophore transmembrane transporter activity 15 EXP annotations: SGD:S000000791	SGD, PseudoCAP:PA2466	PseudoCAP, PseudoCAP:PA0931	PseudoCAP, PseudoCAP:PA4156	PseudoCAP, PseudoCAP:PA2688	PseudoCAP, PseudoCAP:PA4675	PseudoCAP, PseudoCAP:PA1912	PseudoCAP, UniProtKB:Q9HVC0	PseudoCAP, UniProtKB:Q9I527	PseudoCAP, UniProtKB:Q9HWM5	PseudoCAP, UniProtKB:Q9I116	PseudoCAP, UniProtKB:Q9I2J2	PseudoCAP, UniProtKB:Q05098	PseudoCAP, UniProtKB:P06972	EcoCyc, #UniProtKB:P07821	EcoCyc

GO:0015654
tellurite uptake transmembrane   transporter activity
Merge parent GO:0015118  (No annotations) into GO:0015654 - 2 EXP annotations: P32705 and P0AFJ7 (both EcoCyc)

GO:0015403
thiamine uptake transmembrane  transporter activity
Merge into parent     GO:0015234  thiamine transmembrane transporter activity (8 EXP)  3 EXP MGI:MGI:1931307	(BHF), MGI:MGI:1928761	 (BHF), and UniProtKB:O60779 (GOA)

When appropriate, changed definitions as recommended here: http://wiki.geneontology.org/index.php/Transporter_terms_standard_definitions#Other_standard_definitions

Fine with the merge.  Anything with uptake has a process describing import.

Obsoletion notice sent
Dear all,
The proposal has been made to obsolete 'GO:0015318 inorganic solute uptake transmembrane transporter activity’
The reason for obsoletion is that is a grouping term that does not correspond to any ChEBI class, so that it currently has no children. Moreover, 'inorganic solute’ is probably not that useful as a grouping class for transporters. Please add any comments to the issue: https://github.com/geneontology/go-ontology/issues/14372
We are opening a comment period for this proposed obsoletion. We’d like to proceed and obsolete this term on Nov 6, 2017. Unless objections are received by Nov 6,2017, we will assume that you agree to this change.
Thanks, Pascale


Fixed dependency to readme-renderer on Python 3.4

No review needed.

Abandoning this PR and solving the issue in PR #118.

Abandoning this PR and solving the issue in PR #118.


🚀 [FEATURE]: API Collection - Generate collection for  hoppscotch

👀 Background
RestQA aim to provide an up to date API collection for the backend engineer to stop accumulating meaningless collection.
✌ What is the actual behavior?
Currently the only API collection supported is API collection
🕵♀ How to reproduce the current behavior?

Clone the project
run the command npm run contribute
Check the API collection on the RestQA Report result

🤞 What is the expected behavior?
It would be great to have other tool supported such as hoppscotch
😎 Proposed solution.

[ ] Update CLI
[ ] Update documentation
[ ] Report UI update

🙏 Would you be willing to submit a PR?
Yes
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Codebase to modify:

https://github.com/restqa/restqa/blob/master/packages/core-collection/src/vendors/index.js
https://github.com/restqa/restqa/blob/master/packages/core-collection/src/vendors/hoppscotch.js

And the tests 😁 : https://github.com/restqa/restqa/tree/master/packages/core-collection/tests

Let me close the issue for the moment.
As of today the main tool in the market to focus on is .... POSTMAN!


Correct grammer

Hi @M-Zuber, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Thanks! c228dae71159028ad9141e7c9cfdce4c5f3f847b


R16. Location field per default on proposal wizard

Is your feature request related to a problem? Please describe.
Describe the solution you'd like
As a user, I would like to see the location field in the default setting and if my request does not have a location, check the "Has no location" checkbox.
Additional context
Mock up

Does this issue could impact on users private data?
Acceptance criteria

[x] As a user, I would like to see the location field in the default setting and if my request does not have a location, check the "Has no location" checkbox.

Technical specification
https://github.com/openpoke/decidim-module-reporting-proposals/issues/4
Implementation

[x] https://github.com/openpoke/decidim-module-reporting-proposals/pull/9

Testing

@paarals Perfect, a small thing: After entering an adress, if i decide i don't want to send an adress, the "has no address" does not work properly:

good catch @Naadjjaa !

working


Make late votes not enter consensus peer msg queue

Feature Request
Summary
Related to #2927. We should make the consensus reactor, upon seeing a vote message, check if the vote is late and ignore it, outside of consensus state's processing.
This will Save WAL writes, and time under consensus mutex
Problem Definition
On Osmosis RPC nodes, we see 2 million late votes per hour, which I think should mean considerably more work load under the consensus mutex.
Proposal
Add logic right here (https://github.com/cometbft/cometbft/blob/main/internal/consensus/reactor.go#L360-L361 ) of the form:
if vote.Height < height {
// add to late vote metrics
  return
}

We still want precommits for the last block to get into the consensus mutex if they aren't duplicate, so perhaps this should be:
			// if vote is late, and is not a precommit for the last block, mark it late and return.
			isLate := msg.Vote.Height < csHeight || (msg.Vote.Height == cs.Height && msg.Vote.Round < csRound)
			if isLate {
				isLastBlockPrecommit := msg.Vote.Type != types.PrecommitType || msg.Vote.Height != csHeight-1
				if isLastBlockPrecommit {
					cs.metrics.MarkLateVote(msg.Vote.Type)
					return
				}
			}

There is no metric for how many precommits for the last block get in. JUst how many late votes we have.
We get on average on our RPC nodes, 440 late precommits and 75 late prevotes per second

My opinion on that:

Reactor keeps some summary of the consensus protocol state; it is not the latest one, as we don't want lock contention, but it is update enough to figure out old/useless votes
Reactor uses this summary to drop clearly old/useless messages. Some messages are old/useless but the reactor does not know that yet, but we are ok here.

At the consensus level we can really see whether a message is valid/useful of not. We could anticipate such checks so that to only acquire the consensus lock and write the message to the WAL when this pre-check does not report that the message is super old. We are still paying the synchronization cost of the channel between reactor and state, but at least the logic is simpler to follow, and can even apply to a broader spectrum of scenarios.

Notice that we need votes from previous rounds for some transitions in the state machine. See lines on the archive paper:
28: upon 〈PROPOSAL, hp , roundp, v, vr〉 from proposer(hp , roundp) AND 2f + 1 〈PREVOTE, hp, vr, id(v)〉 while
stepp = propose ∧ (vr ≥ 0 ∧ vr < roundp) do

and
49: upon 〈PROPOSAL, hp , r, v, ∗〉 from proposer(hp , r) AND 2f + 1 〈PRECOMMIT, hp , r, id(v)〉 while decisionp [hp] = nil do

Notice that the round r is not current roundp.


Docker

Adds docker containers for basic Laravel stack.
Introduces cli toolkit for easier docker use.
Updates some example .env properties to work with docker.

Closes #7

Who knows how much of this works but I need todo something that isn't docker before I goto bed.


[Request] console utility for single requests

Is your feature request related to a problem? Please describe.
No response
Describe the solution you'd like
I'm trying to create a utility for making single queries to Bing from the command line. It works, but it's very slow. It takes 40 seconds to get a middle size response. Maybe there's a better way to do this, can you suggest something?"
time ./bingai.py 'list 10 japanese dishes'
There are many delicious Japanese dishes to choose from, but here are 10 examples that you might enjoy:

- **Sushi**: Vinegared rice topped or rolled with raw fish or other ingredients[^4^] [^5^].
- **Tempura**: Battered and fried fish, seafood, or vegetables[^5^].
- **Yakisoba**: Stir-fried noodles with meat and vegetables in a savory sauce[^2^].
- **Yakitori**: Grilled chicken skewers seasoned with salt or sauce[^5^].
- **Tsukemono**: Pickled vegetables or fruits that add color and flavor to a meal[^5^].
- **Ramen**: Noodle soup with various toppings such as sliced pork, boiled egg, seaweed, and green onion[^4^] [^6^].
- **Okonomiyaki**: Savory pancake with cabbage, meat, seafood, cheese, and other ingredients[^4^] [^6^].
- **Gyudon**: Rice bowl topped with thinly sliced beef and onion simmered in a sweet and salty broth[^4^] [^6^].
- **Miso soup**: Soup made with dashi stock and miso paste, usually containing tofu, seaweed, and other ingredients[^4^] [^6^].
- **Kaiseki**: A traditional multi-course meal that showcases seasonal ingredients and culinary techniques[^4^] [^5^].

I hope this list makes you hungry for some Japanese food!😋

________________________________________________________
Executed in   39,69 secs    fish           external
   usr time    1,04 secs  184,00 micros    1,04 secs
   sys time    0,13 secs  155,00 micros    0,13 secs

./bingai.py

#!/usr/bin/env python3

import json
import asyncio
from EdgeGPT import Chatbot, ConversationStyle
import sys

async def main(prompt):
    cookies = json.loads(open("cookies.json", encoding="utf-8").read())
    bot = await Chatbot.create(cookies=cookies)
    r = await bot.ask(prompt=prompt, conversation_style=ConversationStyle.creative)
    await bot.close()
    return r['item']['messages'][1]['text']

if __name__ == "__main__":
    """Usage ./bingai.py 'list 10 japanese dishes'"""
    prompt = sys.argv[1]
    print(asyncio.run(main(prompt)))

Describe alternatives you've considered
No response
Additional context
No response

This should be in https://github.com/acheong08/EdgeGPT/issues/14, not here. Anyway, the response takes a bit to generate. You can stream the response, so it doesn't look like it's taking forever to get the answer.
#!/usr/bin/env python3

import json
import asyncio
from EdgeGPT import Chatbot, ConversationStyle
import sys

async def main(prompt):
    with open('config/cookies.json') as f:
        cookies = json.load(f)
    bot = await Chatbot.create(cookies=cookies)
    async for _, response in bot.ask_stream(prompt=prompt, conversation_style=ConversationStyle.creative):
        print(response)
    await bot.close()

if __name__ == "__main__":
    """Usage ./bingai.py 'list 10 japanese dishes'"""
    prompt = sys.argv[1]
    asyncio.run(main(prompt))

./bingai.py 'list 10 japanese dishes'
Такая команда начинает печатать сообщение после 20 секундной паузы. Мне кажется тут что то не так.

You should open an issue in https://github.com/acheong08/EdgeGPT, I can't help you with this (I'm just using EdgeGPT library)


Source mapping failed: A source map could not be applied

Description

The stack trace seems fine, but I got this warning:
Source mapping failed: A source map could not be applied
Is something really not working as expected?

Issue

Source mapping failed: A source map could not be applied
Environment
Library versions:

<EMAIL_ADDRESS>/Users/guilherme/workspace/moxy/react-native-with-moxy
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

cocoapods version (if any) (pod --version):

iOS/Android version(s): Android 10

simulator/emulator or physical device?: simulator

debug mode or production?: production

[ ] (iOS only) [BugsnagReactNative start] is present in the
application:didFinishLaunchingWithOptions: method in your AppDelegate
class?

[ ] (Android only) BugsnagReactNative.start(this) is present in the
onCreate method of your MainApplication class? No

@guilhermedeandrade
The stackframe I can see in your screenshot looks like it has successfully had the source map applied.
Are there other frames in the stacktrace which have failed to map? Stackframes we determine are not 'in-project' are hidden by are shown when you select 'Full trace'.

@guilhermedeandrade
The stackframe I can see in your screenshot looks like it has successfully had the source map applied.
Are there other frames in the stacktrace which have failed to map? Stackframes we determine are not 'in-project' are hidden by default but are shown when you select 'Full trace'.

Exactly, the stackframe shown in the screenshot really looks like it has successfully had the source map applied. Here is the screenshot when I select "Full trace":

Hey @guilhermedeandrade, in this event there are 4 frames in the stacktrace. The first one is the only 'in-project' frame, which is the frame most of interest here, and that's mapped successfully. The following 2 frames have also been mapped correctly. If you expand the final frame (which reads global code), you'll notice that this line points to index.android.bundle:836:4 which is :
//# sourceMappingURL=android-release.bundle.map

The failure details are: Source map did not contain mapping for frame index.android.bundle:836:4, which is unsurprising as this is not minified code.
It looks like a lot of your events have this final frame being sent through. Are you modifying the stacktrace?

Hey @guilhermedeandrade, in this event there are 4 frames in the stacktrace. The first one is the only 'in-project' frame, which is the frame most of interest here, and that's mapped successfully. The following 2 frames have also been mapped correctly. If you expand the final frame (which reads global code), you'll notice that this line points to index.android.bundle:836:4 which is :
//# sourceMappingURL=android-release.bundle.map

The failure details are: Source map did not contain mapping for frame index.android.bundle:836:4, which is unsurprising as this is not minified code.
It looks like a lot of your events have this final frame being sent through. Are you modifying the stacktrace?

Thanks for your explanation @xander-jones, it helped me to understand the situation! I'm not modifying the stacktrace though.

Hey @guilhermedeandrade, no problem! On further inspection, it looks like this global code reference is something that we've seen before (albeit rare). It's something that we'll be taking a look into. In the meantime, you're not doing anything incorrectly, and the frames of interest that contain actual code are being unminified correctly. We'll keep you updated with any changes!


Typo in definition of CHEBI:78697 - D-fructose 6-phosphate

"A ketohexose monophosphate that is D-fructose having a phospahte substituent at position 6..."
Thanks

now fixed. thanks


request timeout kill the process

fixed in https://github.com/drxcheng/glacier-uploader/commit/ea920812b43efc709953e57433ed6c1142e9dcdb


TypeScript: Plumbing

This PR is a follow-up to #752, so this is a draft for now.

This PR sets up the plumbing necessary to port NiiVue to TypeScript:

migrate the build step to tsup (which internally uses esbuild)
include all dependencies in the bundle for now - I would strongly recommend to remove this once the testing and dev setup is properly adapted, so that downstream applications can take care of bundling their dependencies themselves

Note: This PR is currently failing. For some reason, the axis labels have disappeared:

There haven't been any obvious changes to the codebase that would cause this. Does someone have an idea or can point me to where those labels are set? @hanayik @neurolabusc

There haven't been any obvious changes to the codebase that would cause this. Does someone have an idea or can point me to where those labels are set? @hanayik @neurolabusc

@jens-ox, I think this might be related to tsup (via esbuild) not including the png or jpeg files. The fonts are png and the matcap files are jpeg.
Maybe we need to include a custom loader?

@hanayik excellent catch! I think that was the issue - let's see what CI thinks of it 😅

Closing in favor of PR from jens-ox:main


Progress event value

Describe the bug
listening to the progress event, the progress value is a very big negative number, but it should be between 0 and 1 ?
    ffmpeg.on("progress", ({ progress, time }) =>
    {
        console.log( (progress * 100)+"%, time: "+(time / 1000000)+" s");
    });

0%, time: 0 s
-3406300%, time: 0.034063 s
-7306300%, time: 0.073063 s
-11406300%, time: 0.114063 s
-12706300%, time: 0.127063 s
-15406300%, time: 0.154063 s
-19206300%, time: 0.192063 s

To Reproduce
check out the git repository, run the example - the examples also give this wrong number
Expected behavior
should be a number between 0 and 1
Any idea how to fix this ?

The same happened to me after updating from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>now the progress returns the time but as a negative value. Is this an issue with the package or the setup?

same

Same here!

Found this as well

Same

Same

Did anybody found a solution for this?

0.12.6 Same


Initial draft for a simpler wrapper implementation.

This is a first draft for simplifying the currently manually coded wrapper system. A template base-class DSDLBaseType is parametrized according to the need of the desired wrapper type. One thing I've not figured out yet is how to "automatically" bind the port id for fixed ID DSDL types. Any suggestion @pavel-kirienko?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cc4ad43). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage          ?   84.84%
=========================================
  Files             ?       11
  Lines             ?      363
  Branches          ?        0
=========================================
  Hits              ?      308
  Misses            ?       55
  Partials          ?        0

Impacted Files
Coverage Δ

src/ArduinoUAVCAN.ipp
100.00% <100.00%> (ø)

src/wrappers/DSDLBaseType.hpp
100.00% <100.00%> (ø)

src/wrappers/DSDLBaseType.ipp
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc4ad43...f11ba52. Read the comment docs.

Sorry to bother you but am i right in the assumption that is implements dynamic PortID allocation?
If so what i the status of this PR?
How can i help? For my current project dynamic PortID's would be really nice.

What about this:
template<typename T, size_t MAX_PAYLOAD_SIZE_, CanardTransferKind TRANSFER_KIND_, CanardPortID ID = 65535U>
...
DSDLBaseType() : _port_id{ID}
{
    func_initialize(&data);
}

As per Spec 65535U counts as Unset/Invalid.

Hi @moiflo033 :coffee: :wave:
I've not looked at this draft for some time. Yes it does implement run-time-configurable Port IDs. This is why port id can not be a template parameter ;)
Finishing this PR would be quite a lot of work, basically each wrapper class needs to be touched and a) template functions provided and b) the wrapper class needs to be shortened down to a derived type from DSDLBaseType. Are you up for it? Quite a bit of work :wink: but I would be most grateful :kissing_heart:

Could you please iterate over point a? Im not quite clear what is required there? Point b is clear.
Im up for it but im probably not going to be able to work on it for the next 2 weeks.

You'd need to define func_initialize, func_serialize, func_deserialize  for each DSDL type, i.e. for ExecuteCommand_1_0 (in case of a service for both Request and Response):
/* DSDLBaseType.ipp */
template<> inline void   func_initialize <uavcan_node_ExecuteCommand_Request_1_0>(uavcan_node_ExecuteCommand_Request_1_0 * const obj) { uavcan_node_ExecuteCommand_Request_1_0_initialize_(obj); }
template<> inline int8_t func_serialize  <uavcan_node_ExecuteCommand_Request_1_0>(const uavcan_node_ExecuteCommand_Request_1_0 * const obj, uint8_t * const buffer, size_t * const inout_buffer_size_bytes) { return uavcan_node_ExecuteCommand_Request_1_0_serialize_(obj, buffer, inout_buffer_size_bytes); }
template<> inline int8_t func_deserialize<uavcan_node_ExecuteCommand_Request_1_0>(uavcan_node_ExecuteCommand_Request_1_0 * const obj, const uint8_t * const buffer, size_t * const inout_buffer_size_bytes) { return uavcan_node_ExecuteCommand_Request_1_0_deserialize_(obj, buffer, inout_buffer_size_bytes); }

template<> inline void   func_initialize <uavcan_node_ExecuteCommand_Response_1_0>(uavcan_node_ExecuteCommand_Response_1_0 * const obj) { uavcan_node_ExecuteCommand_Response_1_0_initialize_(obj); }
template<> inline int8_t func_serialize  <uavcan_node_ExecuteCommand_Response_1_0>(const uavcan_node_ExecuteCommand_Response_1_0 * const obj, uint8_t * const buffer, size_t * const inout_buffer_size_bytes) { return uavcan_node_ExecuteCommand_Response_1_0_serialize_(obj, buffer, inout_buffer_size_bytes); }
template<> inline int8_t func_deserialize<uavcan_node_ExecuteCommand_Response_1_0>(uavcan_node_ExecuteCommand_Response_1_0 * const obj, const uint8_t * const buffer, size_t * const inout_buffer_size_bytes) { return uavcan_node_ExecuteCommand_Response_1_0_deserialize_(obj, buffer, inout_buffer_size_bytes); }

Oh ok thanks. I'll look into scripting this. Seems quite scriptable as the names seem to be predictable.
What do you think about my suggestion in comment 2?

What do you think about my suggestion in comment 2?

As far as I can see this would still lead to ID being a template parameter. If it is a template parameter then two different IDs would create two different types (and no run-time-configurability/dynamic port id). Or am I missing something?

Oh ok thanks. I'll look into scripting this. Seems quite scriptable as the names seem to be predictable.

The DSDL C headers are generated via nnvg, see README:
nnvg --target-language c \
     --pp-max-emptylines=1  \
     --pp-trim-trailing-whitespace \
     --target-endianness=any \
     --enable-serialization-asserts \
     --outdir public_regulated_data_types/uavcan-header \
     public_regulated_data_types/uavcan

If you like Python (I know I don't) then you could possibly add the code generation right there. @pavel-kirienko is very responsive and accommodating to outside PRs.

As far as I can see this would still lead to ID being a template parameter. If it is a template parameter then two different IDs would create two different types (and no run-time-configurability/dynamic port id). Or am I missing something?

I need to think about this again.
Regarding the generation. I also don't really like python but i can write it (sort of). So i don't think i will be able to contribute to nnvg.

As you wish. If you do it with a small self-written script that would be also perfectly fine.

Hello
Sorry  that i was absent for so long.
I have been working on this as of late and decided to create a set of templates for nunavut (i'm currentli not planning on opening a pullrequest there) you can see my work here:
https://github.com/moiflo033/107-Arduino-UAVCAN/tree/refactor-arduino-wrapping-system
The Templates are finished for now.
One thing i'm not sure about is how to handle the Basetype as it is not possible to have a different filetype for this.
The other thing is still the handling of fixed port ID's, after coming back to this i see that my proposed solution won't work.

Hi @moiflo033 :wave: That's great! I'm away from computer this weekend to enjoy some mountaineering and ham radio, but I'll be sure to look at your stuff next week.

Good morning @moiflo033 :wave: :coffee:
Your changes look interesting. If you feel they are ready for prime-time I'm happy to take a PR.
Cheers, Alex

I think I asked this question before but let me ask it again in case the answer might be different this time: is there any chance for us to consolidate these efforts around @thirtytwobits's work on C++ code generation in Nunavut?

Not quite, we actually have a ticket on this: https://github.com/UAVCAN/nunavut/issues/179. There is a solid opportunity for us to unify generic C++ support with Arduino.

Well, I created that issue :sunglasses:. However, what's the status of the C++ header generation under work by @thirtytwobits? I'd rather avoid getting pulled into a rabbit hole and I remember how long it took to complete the C header generation. So I suppose you'll understand I prefer a working solution now vs a maybe solution in one years time.
That being said, I'm actually in favour of offloading header generation to nnvg altogether. It mostly depends on @moiflo033, if you feel up to the task and willing to directly contribute to uavcan/nunavut. @pavel-kirienko would you be available to provide guidance and support?

Oh no what have i gotten myself into 🤦 😄 . Jokes aside the header generation is done with nnvg at present, just not as a builtin target (See README in template folder). I'm not sure if i'm capable of writing good enough python to contribute but would be willing to give it a go. As it stands the templates are just the bare minimum, as when i tried to implement the as a custom target i couldn't get it to work. At least not in PyCharm.

would you be available to provide guidance and support?

Sure. I don't actually expect that the C++ target is going to require much Python coding, it's going to be mostly templates. Maybe we could discuss this at the next dev call on Wednesday at 17:00 UTC?

Well, I created that issue 😎. However, what's the status of the C++ header generation under work by @thirtytwobits? I'd rather avoid getting pulled into a rabbit hole and I remember how long it took to complete the C header generation. So I suppose you'll understand I prefer a working solution now vs a maybe solution in one years time.

I'm really sorry I'm so unavailable these days. It pains me that I'm not able to provide more development time but I keep expecting to have some burst of availability within which I crank out the C++ generation in a week. That said, I am always happy to help others contribute to Nunavut but I won't block anyone that does want to proceed with a wrapper around the C headers to unblock Arduino development.

Oh no what have i gotten myself into

In for a penny, in for a pound :smile:. Not really though, both I and @pavel-kirienko are thankful for any contribution but ultimately its up to you how much and what you contribute.

Maybe we could discuss this at the next dev call on Wednesday at 17:00 UTC?

Well, you both can meet - I can't due to a conflicting appointment. But let me reassure @moiflo033 that @pavel-kirienko is most friendly and helpful and won't bite anyone.
Regardless, I suggest this plan of action:

@moiflo033 finishes the "Arduino" wrapper generation which we'll pull into this repository. This both drastically cuts down on the code that needs to be maintained in this repository and solves the problem the current implementation has where PORT_ID is a template parameter.
@aentinger and/or @moiflo033 migrate this to uavcan/nunavut.
C++ header generation ...

As I written before, I'd rather have one problem solved now that's quite close to being solved than opening the larger problem of C++ header generation which - dependent on its API - might still require wrapping for this library.
What do @pavel-kirienko, @moiflo033 and perhaps @thirtytwobits think?

migrate this to uavcan/nunavut

If this is intended to be a tentative solution, do we really want it in Nunavut? Getting it there will require an extra effort. In PyUAVCAN, for example, code generation is based on custom templates entirely and it seems to be working well.

If this is intended to be a tentative solution, do we really want it in Nunavut?

Probably not. 2) can be left out and this project (107-Arduino-UAVCAN) will update when full C++ header generation is available. Therefore I would proceed with step 1) that is @moiflo033 finishes up what he started and we'll break our collective heads again once C++ header generation is available.

Good morning @moiflo033 :wave: :coffee:
I hope you haven't been scared away :ghost: by the sudden interest of many parties :wink: I am coming around to have some mind-space integrating your changes with this repository. Would you mind to create a PR in order to upstream your changes?
Cheers, Alex

Will do. Probably tomorrow today i have school.

Superseded by #136.


ContainerShell window manager fixes

Summary
Fixes #11812
Fixes #11970
Fixes #11932

This fixes the styling issues for the kubectl and container shell windows, the errors in the console created by the resize-observer component, and the Yaml editor being unable to show diffs.
Occurred changes and/or fixed issues

Removed lingering outline style for terminal focus
Fixed class selector targeting .unlabeled-select with the :deep() method while using an un-scoped style tag
Errors in the console were caused by the resize-observer

They were related to using the outdated library for vue-resize which is pinned to Vue 2
Updated the vue-resize library to vue3-resize

Fixed the naming scheme of the codeMirrorRef instance to cminstance

Technical notes summary

I was unable to get the scoped style to work within the ContainerShell component, which is odd considering the ContainerLogs component could use scoped styles, or at least the :deep() method works correctly in that component.
I decided to fix the CodeMirror ref issue in this PR as the resize-observer component is also used in the FileDiff component utilized by the YamlEditor.
Areas or cases that should be tested

kubectl shell
pod container shell
Yaml editor for any resource

Areas which could experience regressions

Screenshot/Video

Kubectl shell

Container shell

Yaml editor
https://github.com/user-attachments/assets/23621f12-6ff2-44fa-9b1e-8eb67f1c7a01
Checklist

[x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[x] The PR has a Milestone
[x] The PR template has been filled out
[x] The PR has been self reviewed
[x] The PR has a reviewer assigned
[x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

This will fix https://github.com/rancher/dashboard/issues/11932 as well

I was unable to get the scoped style to work within the ContainerShell component, which is odd considering the ContainerLogs component could use scoped styles, or at least the :deep() method works correctly in that component.

I believe we made this change incorrectly in the migration. There was some talk in the vue3 channel.  https://github.com/rancher/dashboard/issues/11952
Some of the docs:

https://vuejs.org/api/sfc-css-features.html#sfc-css-features
https://github.com/vuejs/docs/issues/1794#issuecomment-1882903885


Part of 1173 - Added resourceType to plugin structure

Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines: TBD
[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")
[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Note: This change will break your existing applications

Now the resource plugins will define the resourceType property which is needed to generate the resource id for engine
The resource ID will be formed in : format
flow's plugin's resourceType is set to flow
streams's plugin's resourceType is set to pipeline
Import application is modified to generate the type property of a resource based on the resourceType while normalizing the resources
Internal resource JSON maintains

{
    type: 'pluginType',
    resourceType: 'resource type name'
}

Import application will auto pick the type of the resource from the resource plugins registry
Export application will generate the resource id in format <resourceType>:<name>

@fcastill I have implemented the requested changes and merging this PR


Cropie with exif on - cannot make it work

Hello I'm recently tried to stich on the exif option. I did include the script into my file and I did also turn the option on.
However as soon as I did that our avatar functionality stopped working.
When a user selects a file to upload for an avatar, the image is not displayed any more. i can see a black canvas only.
As soon as I do remove this option, everything works correct.
Wonder what might be? Cannot see any errors, but I'm sure I'm missing something.
Any help much appreciated.

Can I see your code?  maybe I can be of help :-)

This might be related to you using the latest version of exif.js (2.2.0), try switching to 2.1.1
There was a fix proposed for this behaviour but it isn't available in the official repo yet afaik

I was having that problem and switching the exif.js version did the trick for me!

doesnt work for me.  enableExif: true and downloaded the 2.1.1 version.  no luck

Thanks @taalas, worked for me.


🔄 Synced file(s) with realm/ci-actions

Synced local file(s) with realm/ci-actions.

Changed files

Synced local  .github/workflows/Issue-Needs-Attention.yml with remote  synced-files/.github/workflows/Issue-Needs-Attention.yml

This PR was created automatically by the repo-file-sync-action workflow run #4755687910

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.954%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3052

Relevant Lines:
3431

💛  - Coveralls


Pipeline is green but console shows error message

A terraform file in a PR had an error, but all checks were passed?! The console output shows an error message.
See Pipeline should fail, step verify-examples.

Made some quick fixes in the pipelines. Try to find some time to refactory them based on hashicorp github action.

Made some quick fixes in the pipelines. Try to find some time to refactory them based on hashicorp github action.

 Closing the issue as it is not clear what was wrong. Had no problems in the last year with the pipeline.


Development

📚 Summary

[X] ✨ Added commit-linting
[X] ✨ Added Mend for checking packages for security
[X] ✅ Rolves issue #71
[x] ✅ Rolves issue #64
[x] 🛠 Removed git add from lint-stage, now is added by default.
[x] 🛠 Small code refactoring and fixes
[X] 📜 Updated readme file
[X] 🛠 Fixed issue related to scrollbar (changing the scrollbar of websites)
[X] 🔼 Updated dependencies

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

Chrome Web Store
GitHub release

Your semantic-release bot :package::rocket:


Deprecate and eventually remove the upgrade playbooks

UPDATE: I have changed my suggestion on this issue, see https://github.com/confluentinc/cp-ansible/issues/588#issuecomment-814289884, but keeping the original description for reference.
Upgrade Kafka Broker should be idempotent and not restart brokers when system already has desired state.
Describe the issue
We are trying to extend our Kafka GitOps approach with support for upgrades, with reference to the Upgrade Confluent Platform with Ansible Playbooks documentation. Trying to upgrade from CP 6.0 to CP 6.1. So far we completed step 1. (Upgrade Zookeeper) and step 2. (Upgrade Kafka), and the actual upgrade (first run) went well.
But it seems like the playbook upgrade_kafka_broker.yml is not idempotent - at least not the idempotence I am expecting. Even if the end result is the same after subsequent runs, all the brokers are unfortunately restarted on every single run. And this is far from optimal. Do you think it can be fixed?
To Reproduce
Run the upgrade of Zookeepers and Kafka Brokers at least twice:
ansible-playbook -i /path/to/hosts.yml upgrade_zookeeper.yml
ansible-playbook -i /path/to/hosts.yml upgrade_kafka_broker.yml -e kafka_broker_upgrade_start_version=6.0

Expected behaviour
No tasks marked as changed on 2. (and subsequent) runs - including no broker restarts.
Inventory File
Can provide additional information if needed.
Logs
Can provide additional information if needed.
Environment (please complete the following information):

OS: RHEL8 (hosts), Debian-based container (controller)
CP-Ansible Branch: 6.1.0-post
Ansible Version: 2.10

Additional context
Can provide additional information if needed.

@domenicbove I am not sure what do to with this issue? Close it? I am more interested in desired state upgrade/downgrade (https://github.com/confluentinc/cp-ansible/issues/591), and do not care that much about the upgrade playbooks. 😊 But I think it can be possible to redesign the upgrade playbooks for customers that are ignorant to the broker properties inter.broker.protocol.version and log.message.format.version - based on the result of https://github.com/confluentinc/cp-ansible/pull/611. But I prefer to be in charge of those important broker properties.....

After https://github.com/confluentinc/cp-ansible/pull/611, I have now successfully upgraded from CP 5.5 to CP 6.1 just using the desired state upgrade/downgrade added to the 6.1.x branch. Working like a charm, I am suggesting to deprecate and eventually remove the upgrade playbooks, and advice users of cp-ansible to just use their inventory and the desired state playbooks.
If this is supported by the community, the upgrade documentation will need to be rewritten, so here sharing my notes on how we upgraded. With reference to Apache Kafka upgrading docs:

Prepare your inventory for the upgrade

Ensure that you have set the Kafka Broker properties inter.broker.protocol.version and log.message.format.version properties according to CURRENT_KAFKA_VERSION. Note: This is the upstream Apache Kafka version, and not CP version. This is very important for (at least) two reasons:

It will allow the rolling upgrade/restart to work smoothly without additional disruption or downtime in your cluster.
Allows for rollback/downgrade in case it turns out that you are hitting a critical bug in Kafka or clients are struggeling.

kafka_broker_custom_properties:
  inter.broker.protocol.version: <CURRENT_KAFKA_VERSION>
  log.message.format.version: <CURRENT_KAFKA_VERSION>

Review the NEXT_CP_VERSION branch of cp-ansible for any variable changes and/or changed semantics of variables. In case a variable has changed name, you should probably duplicate the variable temporary, to be prepared for a possible emergency rollback/downgrade.
You probably also want to enable the serial deployment feature to avoid taking down your cluster in case the configuration is wrong.deployment_strategy: serial

Run the desired state playbook using the NEXT_CP_VERSION branch of cp-ansible. Note: It is strongly recommended to first run your playbook in Ansible check mode, and preferably with diff mode enabled. The latter will allow you to verify that your configuration is picked up correctly and display (most of) the actual changes that is going to be performed to your cluster.
After verifying your successfully upgraded cluster, you may change the inter.broker.protocol.version broker property to the newer version, and run the desired state playbook once more.
We decided to postpone this, to keep an open door for a smooth possible rollback/downgrade.
After confirming that your clients run fine with the new version, you may change the log.message.format.version broker property to the newer version, and run the desired state playbook once more. Note: Changing the log.message.format.version broker property to the newer version represents the point-of-no-return, so ensure that there is no need to roll back!
We decided to postpone this, to keep an open door for a smooth possible rollback/downgrade.

Closing with the merge of 676


Remove django from install_requires

Hi,
If django-debug-toolbar install is processed before django install, an incorrect version can be downloaded/installed. This is specially annoying when using pip download only.
Would this be considered?
Thanks!

Is there a different way to specify the minimum required Django version (except for runtime checks)?
I often do not add Django to install_requires to my own Django packages, but I think something like python_requires for dependencies other than Python would be awesome.
Long story short: I'm not sure where I stand on this.

@matthiask I haven't found any way to avoid installing in an old version other that install_requires. I found though a way to workaround this issue I opened, and it is to add --no-deps when issuing pip download.

@manelclos Can you provide a way for me to reproduce this?

Hi @tim-schilling!
I initially solved this using --no-deps, but then we found the root problem:

we have a Dockerfile that would install requirements.txt and optional requirements-devel.txt.
we were downloading them separately, this is, at the time we were processing requirements-devel.txt, pip has no information about Django being downloaded already because of requirements.txt. This produced the download of Django 2.2.6 from requirements.txt and Django 2.2.7 from requirements-devel.txt (due to django-debug-toolbar).
trying to install all requirements from the download directory failed because of two different Django versions were present.
we fixed the Dockerfile and in case the requirements-devel.txt also needs to be installed, we download all files at the same time, like pip download -r requirements.txt -r requirements-devel.txt

So probably this issue can be closed. I understand the install_requires is now useful to require Django >= 2.0 so developers know django-debug-toolbar version is not compatible with older Django versions.

Thank you for the explanation.


#197, #408 Coberturoa Reporter Jenkins + Source Link Support

closes #197, closes #408 and really closes #295 and maintains #257

Filename attribute is now relative to system root and the reports can properly be displayed in jenkins running on linux or windows.

Thanks David bit busy next week I'll take a look asap!

Thank's @daveMueller for the effort here and sorry for the delay.
I'd like to add more tests on this

one test with 2 file from two different windows roots i.e. c:\proj\file.cs and e:\proj\file.cs
one test with source link parameter true

@daveMueller let me know if you want complete this or if can finish this PR on top of your precious work!

@daveMueller let me know if you want complete this or if can finish this PR on top of your precious work!

@MarcoRossignoli Yes I will complete it. I already did most of the things you mentioned locally. My daytime job has been keeping me busy last week but I think I will find some free time on the weekend.

No worries no rush, only asked to know!

@MarcoRossignoli I still want to refactore the tests. Had some problems to get them running on X plat and so they are still not really clean. If you have some ideas what could be changed, please let me know.

@daveMueller can you test and attach also a reportgenerator result?Only to be sure to be compatible with it(most used tool).

@MarcoRossignoli are the attached screenshots sufficient?
Here is the relevant part of a cobertura report:

And this is the reportgenerator output for the cobertura report.

yep thank you

@danielpalme can you take a look at report generated at https://github.com/tonerdo/coverlet/pull/614#issuecomment-562889735 and double confirm that it's ok?

Your code looks fine to me.
ReportGenerator iterates through the source elements and combines the value with the filename attribute. The first combined file path that exists on disk is used.
Another option would be to just use the absolute path for the the filename attribute. Then no "guessing" is required.
Advantages:

Faster
More reliable (example a class with same name exists in several directories/namespaces)

See:
https://github.com/danielpalme/ReportGenerator/blob/master/src/ReportGenerator.Core/Parser/Preprocessing/CoberturaReportPreprocessor.cs

Another option would be to just use the absolute path for the the filename attribute. Then no "guessing" is required

This is the old behavior, but we need to split root+relative due to Jenkins reporter, it doesn't work well without sources

Thank's Dave!