Fill positions in NgramTokenizer

I am looking into ways to make searches including non-ASCII characters. I want to search all documents that contain the query string as a substring, regardless of the word delimiter position.
For this purpose, I tried to use NgramTokenizer and PhraseQuery.  However, it did not work as I expected. The order of the tokens seems to be ignored. I looked into the cause and found that Position was changed to all zeros in commit e75bb1d6a13f22d559072b682f9fcfac0e1ef965.
To be honest, I don't properly understand the reason for this change, but if this change was not necessary for the consistency of the specification or something, why not set the value of position?
So, I made a patch to fill "where the token starts, in terms of characters (not bytes)" in positions.
There may be a more appropriate way to do this and/or there may be something I've missed, but I would appreciate it if you could take a look.
As a supplement, I've used the following code to check the overall behavior:
// main.rs

use tantivy::collector::TopDocs;
use tantivy::query::QueryParser;
use tantivy::schema::*;
use tantivy::tokenizer::NgramTokenizer;
use tantivy::{doc, Index, IndexWriter, ReloadPolicy};

fn main() -> tantivy::Result<()> {
    let mut schema_builder = SchemaBuilder::default();

    let text_options = TextOptions::default()
        .set_stored()
        .set_indexing_options(
            TextFieldIndexing::default()
                .set_index_option(IndexRecordOption::WithFreqsAndPositions)
                .set_tokenizer("ngram"),
        )
        .set_stored();

    schema_builder.add_text_field("text", text_options);
    let schema = schema_builder.build();

    let index = Index::create_in_ram(schema.clone());
    let mut index_writer: IndexWriter = index.writer(50_000_000)?;

    let tokenizer = NgramTokenizer::new(1, 1, false)?;
    index.tokenizers().register("ngram", tokenizer.clone());

    let text = schema.get_field("text").unwrap();

    // This is the only document in the index
    index_writer.add_document(doc!(
    text => "本日は晴天なり", // 本日は晴天なり: Today is a fine day
    ))?;
    index_writer.commit()?;

    let reader = index
        .reader_builder()
        .reload_policy(ReloadPolicy::OnCommitWithDelay)
        .try_into()?;
    let searcher = reader.searcher();

    let query_parser = QueryParser::for_index(&index, vec![text]);

    // ✅ Work as expected
    let query = query_parser.parse_query(r#""本日は""#)?; // 本日は: Today is
    println!("Query: {:?}", query);
    let top_docs = searcher.search(&query, &TopDocs::with_limit(10))?;
    for (_score, doc_address) in top_docs {
        let retrieved_doc: TantivyDocument = searcher.doc(doc_address)?;
        println!("Matched (as expected): {}", retrieved_doc.to_json(&schema));
    }

    // ❌ Should not return any results
    println!();
    let query = query_parser.parse_query(r#""日本は""#)?; // 日本は: Japan is
    println!("Query: {:?}", query);
    let top_docs = searcher.search(&query, &TopDocs::with_limit(10))?;
    for (_score, doc_address) in top_docs {
        let retrieved_doc: TantivyDocument = searcher.doc(doc_address)?;
        println!(
            "Matched (but not expeced): {}",
            retrieved_doc.to_json(&schema)
        );
    }

    Ok(())
}

@darashi I think removing the 0 in position seems good, but I'm not sure what would be best in terms of spec.  position is expressed in number of tokens, but the number of tokens in case of NgramTokenizer is ambiguous.
    /// Position, expressed in number of tokens.
    pub position: usize,

It would be good to know how Lucene handles this, the docs here are a little unclear to me. Instead of Position increment I'd be interested in the absolute position emitted.
https://lucene.apache.org/core/9_11_1/analysis/common/org/apache/lucene/analysis/ngram/NGramTokenizer.html
What do you think? Can you check what tokens Lucene emits?

Thanks for checking. Unfortunately they emit positionIncrement, so it's still unclear what they use for position as absolute value.

If I'm not mistaken, it looks like startOffset indicates the absolute position offset in characters. Regardless of the presence of non-ascii characters, the same values are returned in both cases, namely [0, 0, 1, 1, 2, 2, 3, 5].

In tantivy we use byte offsets, maybe they use something else?
Can you add tests for ngram with different settings with phrase queries?
I think the regular PhraseQuery is quite wasteful as it will match all tokens


Adding convenience functions for ATT Calculation

Hi lewisbails,
I recently leveraged your CEM package in a project and thought I'd try to give something back. I implemented two functions to calculate the ATT impact via Weighted Least Squares (leveraging statsmodels) and Weighted Means.
Are you open to accepting contributions? I haven't done any kind of testing yet but just wanted to include the code modifications for you to take a look at first before putting more time in here. If you think this is a good change and are happy to accept I'll also add some test cases and make sure it passes.
Regards,
-Qichao

Hi Qichao, I'm flattered you used my package in your research. I'm very open to contributions. As you can see this project has gone a bit stale as of late. I'll add a few comments to your commit and let's go from there!

LGTM, is it ready to merge?


[Bug Report] Both dockerfiles for 22.04 and 20.04 are incorrectly sequenced

Describe the bug
For 20.04 and 22.04 Dockerfiles, where Clang-17 is trying to be installed on a directory that doesn't exist yet. Additionally for the 22.04 dockerifle, when you look at dockerfile/ubuntu-20.04-amd64.Dockerfile it set the environment variables and steps before before copying requirements from the tt-metal folders but in the 22.04 file that entire step seems to be out of place randomly.
Error
 => [tt-metal-patch 15/24] COPY /docs/requirements-docs.txt /opt/tt_metal_infra/tt-metal/docs/.                                                                                0.1s
 => [tt-metal-patch 16/24] COPY /tests/sweep_framework/requirements-sweeps.txt /opt/tt_metal_infra/tt-metal/tests/sweep_framework/.                                                                                0.1s
 => [tt-metal-patch 17/24] COPY /tt_metal/python_env/* /opt/tt_metal_infra/tt-metal/tt_metal/python_env/.                                                                                0.1s
 => [tt-metal-patch 18/24] RUN python3 -m pip config set global.extra-index-url https://download.pytorch.org/whl/cpu     && python3 -m pip install setuptools wheel                                                                0.6s
 => ERROR [tt-metal-patch 19/24] RUN python3 -m pip install -r /opt/tt_metal_infra/tt-metal/tt_metal/python_env/requirements-dev.txt                                                                                0.6s
------
 > [tt-metal-patch 19/24] RUN python3 -m pip install -r /opt/tt_metal_infra/tt-metal/tt_metal/python_env/requirements-dev.txt:
0.506 ERROR: Could not open requirements file: [Errno 20] Not a directory: '/opt/tt_metal_infra/tt-metal/tt_metal/python_env/requirements-dev.txt'
------
failed to solve: process "/bin/sh -c python3 -m pip install -r ${TT_METAL_INFRA_DIR}/tt-metal/tt_metal/python_env/requirements-dev.txt" did not complete successfully: exit code: 1

For https://github.com/tenstorrent/tt-metal/issues/10469

Thank you for the contribution!


Consider adding webpage repo to the contributor graph

@awvwgk @fortran-lang/admins @fortran-lang Should we consider adding the new repo of webpage in the contributors graph on community section of the site.
Thanks and Regards,
Henil Shalin Panchal

Preview of the resultant graph can be found here : Contributor Graph

@awvwgk It seems that the old site at appears to be broken due the old configured site.baseurl , I think we must change it to https://fortran-lang.github.io/fortran-lang.org .
Thanks and Regards,
Henil Shalin Panchal


Air temp and road temp swapped

On line 31-32 in pytrafikverket/pytrafikverket/trafikverket_weather.py air and road temp has been swapped.

Sorry, must have missed notifcations on this repo..
Fixed in package 1.5.9 that is available in pypi now.
If you use home assistant the latest package version will be utilized when this PR is merged and released. https://github.com/home-assistant/home-assistant/pull/22139


Added blog 'Subnetting in Azure Bicep'

Added my latest blog post about "Subnetting in Azure Bicep"

Thanks for your contribution!


Python 3.12 wheels

Hi @nmwsharp - this package looks awesome and I'm hoping to use it for something, but noticed there are no Python 3.12 wheels available.
I think the version of cibuildwheel you are using https://github.com/nmwsharp/robust-laplacians-py/blob/dd58b70da324ef8fb8554f91ad37f0eed4d85c2c/.github/workflows/build.yml#L61
did not build for 3.12 by default, but newer ones will https://cibuildwheel.pypa.io/en/stable/changelog/#v2150
Wondering if you're open to bumping cibuildwheel to something newer, and rerunning the github action? I'm happy to open a PR or otherwise facilitate this.

Yes, absolutely, I just haven't updated this lib since the 3.12 wheels were supported. I'd certainly appreciate a PR if you're interested to give it a try. Fair warning there is a ~50% chance that something we'll break and we'll need to put out a fire to get the builds to succeed after bumping cibuildwheel.

great, just opened #20 - agree with your guess that it'll break something else, but happy to try to help with that if so

Ok got the builds to succeed, kicked off a publish job now. If nothing goes wrong it should be on pypi in a few hours. Thanks! Feel free to reopen if anything seems wrong.

it looks like the build succeeded but the publish to pypi failed https://github.com/nmwsharp/robust-laplacians-py/actions/runs/11938379378/job/33280576553
at a glance it looked like some issue with trusted publishers? let me know if I can help at all, but probably would be difficult for me without access to the repo

Yep you got it right, forgot to set the trusted publisher :) Plus there was another small problem with having subfolders for the upload. Fixed now!

Looks like it is working for me, I was able to install with numpy 2 and python 3.12 on a Mac.
Many many thanks for getting this set up! I am using this for representation learning on neuron meshes

and this is letting me avoid some annoying mesh fixing routines that don't work very well in practice, so it will be very useful for my research :)
P.S. I will of course cite you! thanks again

Glad to hear it, so cool!!! Can't wait to see the research when it goes live :)


Startup Landmarks

Would be great to have a specific landmark or a set of landmarks (perhaps randomly selected if more than 1) where people appear in the scene.  It could have a static name or be defined similar to how we manage screenshare in scene config.  (sorry if this is a repeat)

We have added this to scenes before and it's really useful. Do we have a document published anywhere that shows how to do this?
I could start gathering lists of techniques like this for our docs site.

There is sort of overlap now with startPosition# entities, it currently selects one at random. However, starting positions are not listed as landmarks
Perhaps if we refactor startPosition into a component-system, then we could attach it to landmarks as well?

And also maybe add random radius

Yeah, refactor it into a component-system is a good idea.

This is now WIP via #276


fix: check if the port is ready to serve

fix: check if the port is ready to serve
Description
CheckPortReady checks if a service is ready on the specified port by making an HTTP GET request.
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

Related Issue(s)
closes #68

Hi @harkiratsm,
Thanks for opening a PR to resolve the issue.
A couple of notes from my side:

Please drop the lint commit as it introduces a lot of file changes out of scope of this PR. We will soon enforce linting before commiting so that will be handled.
Please refer to my comment on the issue at hand. An arbitrary timeout is not a good solution for this. I would suggest implementing a waiting strategy in the ForwardPort function that will wait for the port to be ready before returning from the function itself.

Got it. I added a function to check the port's readiness every 0.5 seconds. Once it's ready, we open the URL in the browser.

@harkiratsm one more thing,
Please read our CONTRIBUTING guidelines and open a separate PR where you will add yourself as a contributor. (example PR)

@harkiratsm, we just updated our policy to contribute to the repo.
This change requires all commits to be signed off with your name and email. You can find out more about the change in this commit.
Please read through the change, squash your commits and sign them like this:
git rebase -i HEAD~X where X is the number of commits
git commit --amend --signoff

Signoff will automatically include the signature required to be a contributor to Daytona.
Let me know if you have any questions about this process or need any help.

All of my commits are signed off with my name and email in this PR.

@harkiratsm, the PR looks great, but I'll have to ask you to change the name in your signature.
As per the DCO requirements, the signature does not necessarily need to be your full name, but something that provides enough identification for us to contact you if need be.
I suggest using your first and last name as it makes it easier and removes any ambiguity from our side.


Changed how external adapters are added to factory

Change how external adapters are added to instrument adapter factory
This PR should turn green with next release of qilib.

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1

See the complete overview on Codacy


beginnings of strings shouldn't be considered in commented code

Consider this:
! please don't delete this subroutine
subroutine example()
    implicit none

end subroutine

fortls seems to think everything starting from 't delete is a string, even though the quote is inside a comment.

Thanks for the report. What is the symptom you are seeing? When I include this in a module it seems to work just fine in Atom (shows up in outline, autocomplete, etc.).

This is what I get:

It seems to work fine if the comment is inside a subroutine, however.
(BTW, I got the VS2017 extension running, just needs a couple of more tweaks to be publishable.)

Syntax highlighting isn't provided by the language server so the display issue must be related to the syntax highlighting definition in your extension or whatever extension is providing syntax highlighting in VS2017. Do you see any issues related to autocomplete or other language server functionality?

Oh I see. I'm sorry, I had realised this before, but forgot about it meanwhile.
It's a bug in the TextMate grammar file I included with my extension.
I will try to get that fixed.


JS -- String.prototype.repeat() spec. inconsistency

Description
On http://www.codewars.com/, the String.prototype.repeat() function do not follow ES6 spec.
The bug occures when -1 is passed to the method.
Steps to reproduce

Go on http://www.codewars.com/ (on others sites, String.prototype.repeat() works fine)
In the JS console, "a".repeat(-1) returns "". Negative numbers should raise a RangeError instead.

SPEC http://www.ecma-international.org/ecma-262/6.0/#sec-string.prototype.repeat

We can look into this the next time BabelJS/Node is updated on the runner image.

Node v6 confirms to the spec and throws RangeError: Invalid count value.
Node v0.10 with or without Babel doesn't have .repeat.

 Negative numbers should raise a RangeError instead.

Is this "JS console" browser's developer console? If so, I just tried and confirmed.
"a".repeat(-1); //=> ""
String.prototype.repeat + ''; //=> "function (e){return Array(e+1).join(this)}"

Viewing the minified /assets/application.js, I found many modifications to native types.

@jhoffner changing builtin methods unconditionally like this will cause many issues and they're really hard to debug. These modifications might also cause issues using libraries.
I'd suggest not to do this (String.prototype.repeat is widely supported now and others can be written as simple functions). If not, at least test for the existence before overwriting:
if (typeof String.prototype.repeat != 'function') String.prototype.repeat = function(n) {};

This shouldn't break anything unless the code relies on behaviors against the spec.

Yes, the "JS Console" was the browser's developer console, I update the description

I'm closing this because this doesn't affect submitted code (we don't run JavaScript on your browser).


Error After Install

Grafana Version 6.6.0
Got error after installing in /var/lib/grafana/plugins/
i was able to look at the error in /var/log/grafana/grafana.log
"lvl=eror msg="Failed to start plugin" logger=plugins.backend pluginId=mtanda-aws-cloudwatch-logs-datasource error="fork/exec /var/lib/grafana/plugins/mtanda-aws-cloudwatch-logs-datasource/src/aws-cloudwatch-logs-plugin_linux_amd64: no such file or directory" "
Also, the Grafana Front end displayed the following error.
"Error: Unexpected token '<' Evaluating http://MyHost/public/plugins/mtanda-aws-cloudwatch-logs-datasource/module.js Loading plugins/mtanda-aws-cloudwatch-logs-datasource/module"
Kindly help.

I guess it is file path issue. Please try install by following command.
grafana-cli --pluginUrl=https://github.com/mtanda/grafana-aws-cloudwatch-logs-datasource/releases/download/1.0.5/grafana-aws-cloudwatch-logs-datasource-1.0.5.zip plugins install grafana-aws-cloudwatch-logs

Thanks  Mitsuhiro Tanda.
On Tue, 21 Apr 2020, 14:10 Mitsuhiro Tanda<EMAIL_ADDRESS>wrote:

I guess it is file path issue. Please try install by following command.
grafana-cli --pluginUrl=https://github.com/mtanda/grafana-aws-cloudwatch-logs-datasource/releases/download/1.0.5/grafana-aws-cloudwatch-logs-datasource-1.0.5.zip plugins install grafana-aws-cloudwatch-logs
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mtanda/grafana-aws-cloudwatch-logs-datasource/issues/21#issuecomment-617040357,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMSA3KRHWU3SLSYMSD673ILRNVLYJANCNFSM4KRMKTZQ
.


fix potential null dereference in ext_authz

Commit Message: fix potential null dereference in ext_authz
Additional Description:
Previously, if ext_authz had emit filter state stats set to true and another filter added filter state under the ext authz filter's name, it would result in a null dereference. The member logging_info_ would not be set in initiateCall after seeing there was already data there. Later, we would dereference logging_info_ to update the stats as if it were initialized already.
I've added a check for a null logging_info_ and added logging & a stat for when there's a filter state naming collision.
I also made some readability improvements to the ext_authz test.
Risk Level: low
Testing: unit tested
Docs Changes: none
Release Notes: none
Platform Specific Features: none

those are real test failures, don't waste too much time looking at this yet.


Can't build docs

I get this error
CMake Error at CMakeLists.txt:143 (add_subdirectory):
  The source directory

    /home/ubuntu/DroneCore/third_party/gtest

  does not contain a CMakeLists.txt file.

@hamishwillee can you try:
git submodule update --init --recursive
git submodule sync --recursive
git submodule update --init --recursive

Actually I just recreated my build computer and this just magically worked. Old one was deleted, so can't do your fix.


Hijack Native Screenshots

An idea: do like Dropbox on macOS and hijack the native shortcuts. It will be a bit hard to do but I believe it's doable. If there is no npm package for this, I'll work on one which will need to be a native module in C++... Well... But we can do it and I think it's a great idea. Then, see if it's possible on Windows.
What do you think?
/cc @olizilla @fsdiogo

This reveals ti be more challenging than I thought. I created a Gist with the code I wrote so far. The main issue is that everything is running on the same thread and it seems the callback for the notifications is not being called. This would be easier written in Swift in a Native App. I'm wondering if it is worth it to keep working on this feature.
I find it funny I can't find anything in the web about integrating Obj-C in Node.js native modules. What do you think? The feature would be awesome, but to integrate it with Node.js doesn't seem to be straightforward.

If it would be easier, a keyboard shortcut to just upload whatever's currently in the clipboard would be incredibly handy alternative to this. I take all my screenshots to the clipboard anyways so it'd just be one extra thing to do to share it if I needed to, and then it could be applied to other files as well, uploading copied stuff from the Finder, or even adding text in the clipboard to a txt file and uploading that.

@JonahAragon uuh, that's a great idea! I like it 💡 What do you think @olizilla?


for #410

added series in astypr

[ ] Closes #xxxx (Replace xxxx with the Github issue number)
[ ] Tests added: Please use assert_type() to assert the type of any return value

Thank you sir


Touch is not working on top of all views

I am facing this issue from the initial release, it also exists in your sample app.
In all scroll views RecyclerView, ScrollView any, if we scroll up till the material viewpager changed to tabs and then the touches won't work on top on all views. In the photo below i highlighted the area check it.

Same issue

i m facing same issue

I am also facing this exact issue.
My header is about 300dp in height, so there is a lot of screen space not functioning.

Bump.
Anybody got any news on this? Been trying to look through the source code, but all I can come up with is that the touch is lost in the space occupied by the "headerBackground".

Any update for this issue so far?

No looking for a solution still

So I have some news, but I don't know how much it will help.
I have managed to get the area to react to scrolling. But the way I did that was not something I would recommend.
If you set the "pagerTitleStripContainer" visibility to GONE, the touch area will work.
The page strip seems to be the thing that 'consumes' the touch event. I will continue to look for a solution.
But I have to say that I have now cloned the whole library and I'm working on a pretty custom version on my end. Good luck to all.

I hope your version will be more stable and recently updated.

So I have finally made my version work. Kinda.
I was having a couple of different issues, specially touch and click issues.
I haven't been able to fix the issue mentioned here, but simply guessing, I can say that the "pagerTitleStripContainer" is being TranslateAnimation (moved) to another position. But TranslateAnimation simply moves pixels on the screen, not the actual object. Therefore the touch listeners for the "pagerTitleStripContainer" remain, while the actual pixels get moved up. (This is my guess anyway.)
Someone should be able to fix this either by making sure the actual "pagerTitleStripContainer" is moved, not simply pixel-moving, or by trying to intercept touch events and passing them to the correct view.
I have made lots of custom changes to my clone to fit exactly what I am looking for (such as replacing the RecyclerAdapterWrapper and so on), that I don't believe it will help anyone looking to fix this issue. But I will attempt to comment, cleanup and push within a couple of days.

@Mithrandir21 snx God, you made this)

@Ashok-Varma @antoxa2584x @umesh34 @Mithrandir21
By using the sample of MaterialViewPager I have meet the same issue. and I fixed the problem by

Go to material_view_pager_layout.xml (this layout in available at MaterialViewPager/materialviewpager/src/main/res/layout/material_view_pager_layout.xml)

Delete android:clickable="true" in RelativeLayout which have id android:id="@+id/toolbar_layout"

Hopefully it will help you
Following the below is the layout that's work for me ^_^

<android.support.v7.widget.Toolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:fitsSystemWindows="true"
android:minHeight="?attr/actionBarSize"
<EMAIL_ADDRESS>app:navigationIcon="?attr/homeAsUpIndicator"
tools:background="#3FFF" />

@florent37  please fix this issue.
@araurangel i will change that and then test it.

How is this problem going. I am still having this issue.

Thanks araurangel, I have managed to make it work without editting that xml file. Simply do this in your code:
toolbarLayout = (RelativeLayout) findViewById(R.id.toolbar_layout);
toolbarLayout.setClickable(false);

@araurangel  your solution is permanent and useful for people who imported the project.
@qknguyendev  i still have to check that but i am sure it i will work, since it's same as @araurangel  solution. But your solution provides great advantage for people who use compile time dependency.
Thankyou both

Same issue


Add property names to _TimeTaggedCoords

This PR allows for _TimeTaggedCoords classes to specify the name of their property in the CZML. If the property name is defined it will be used in the dumped CZML, otherwise the values passed will be used.
This fixes https://github.com/poliastro/czml3/issues/107 and allows for bypassing similar bugs (as described in the issue) in Cesium.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.24%. Comparing base (7f24f78) to head (c58cae9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   99.23%   99.24%
=======================================
  Files          12       12
  Lines         784      791    +7
=======================================
+ Hits          778      785    +7
  Misses          6        6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Crash after open

I can open program, but every time I click on anything, program crash. Some times I can add video (CTRL+F), but mostly it crash after any interaction. Run as administrator do not help.
My PC:
R9 3900X + RX 5700XT + 32GB RAM 3200Mhz CL16 + (NVME) SSD, Windows 10 and drivers updated.

Can you open the program from the command line please? Maybe there is some sort of error message which helps to pinpoint the problem.
Do you have the most current version of trdrop v1.1.1?

Can you open the program from the command line please? Maybe there is some sort of error message which helps to pinpoint the problem.
Do you have the most current version of trdrop v1.1.1?

Program open, but crash anyway, no error message.
I hade same problem before and after Windows reinstall. Before reinstall I had previous version of program (there was no possible to export as video), now I have latest version.

Program open, but crash anyway, no error message.
I hade same problem before and after Windows reinstall. Before reinstall I had previous version of program (there was no possible to export as video), now I have latest version.

Ok, that's very strange. Can you please remove the installation directory and make a clean re-install of trdrop if you didn't already?
Otherwise it seems to me that it has to be something hardware specific, or at least something specific to your hardware/software setup as it works for me and most other people.

Ok, that's very strange. Can you please remove the installation directory and make a clean re-install of trdrop if you didn't already?
Otherwise it seems to me that it has to be something hardware specific, or at least something specific to your hardware/software setup as it works for me and most other people.

Nothing help. It is weird.

Nothing help. It is weird.


minor fixes to elemental release 1.2.0

minor fixes to elemental release 1.2.0 (forgot about the icon and missing an annotation)

Thanks @richard-cox ! 🙏


there is a problem when running

I want to use gn into CNN , and meet a prolem:
ailed to convert object of type <class 'list'> to Tensor. Contents: [Dimension(None), 2, Dimension(14), Dimension(28), Dimension(32)]. Consider casting elements to a supported type.
this is the code:
def groupnorm(x,gamma,bate,G,eps=1e-5):
x=tf.transpose(x,[0,3,1,2])
N,C,H,W =x.get_shape().as_list()
G=min(G,C)
print('x:',x)
x=tf.reshape(x,[N,G,C//G,H,W])
mean,var = tf.nn.moments(x,[2,3,4],keep_dims=True)
x=(x-mean)/tf.sqrt(var+eps)
gamma=tf.get_variable('gamma',[C],initializer=tf.constant_initializer(1.0))
bate=tf.get_variable('bate',[C],initializer=tf.constant_initializer(1.0))
gamma=tf.reshape(gamma,[1,C,1,1])
bate=tf.reshape(gamma,[1,C,1,1])
x=tf.reshape(x, [N, H, W, C])
output=x*gamma+bate
output=tf.transpose(output,[0,2,3,1])
print('a:',a)
return output

give me some information more ...

what is the shape of x ?
last line, you used print(a), what is the 'a' ?

thanks your reply.this  when input x ,the x is Tensor("add_4:0", shape=(?, 28, 28, 32), dtype=float32), and the  I can get the a .it  can not work in tihs code"x=tf.reshape(x,[N,G,C//G,H,W])",and meet a prolem:
ailed to convert object of type <class 'list'> to Tensor. Contents: [Dimension(None), 2, Dimension(14), Dimension(28), Dimension(32)]. Consider casting elements to a supported type.

I think
Maybe it's because the batch size is set to None.
please set the batch size to an exact value other than None.
or try this
code change
N,C,H,W =x.get_shape().as_list()

->
N = tf.shape(x)[0]
C = tf.shape(x)[1]
H = tf.shape(x)[2]
W = tf.shape(x)[3]

it works.I found the problem ,according to your suggestions.thanks again


samples: fs: enable littlefs sample for LPC55S69

LPC55S69 flash requires all writes be in multiples of 512 byte blocks. Configure littleFS sample for these requirements when building targeting the LPCXpresso55s69 EVK.
Signed-off-by: Daniel DeGrasse<EMAIL_ADDRESS>

@de-nordic Added the LPC55S69 to twister, thanks for the reminder


HACS - custom repository failed

Can't add keatontaylor/alexa_media_player (1.3.0) to HACS respository

URL "https://github.com/keatontaylor/alexa_media_player/"
failed with error message "keatontaylor/alexa_media_player/ is not a valid format correct format is 'https://github.com/DEVELOPER/REPOSITORY' or 'DEVELOPER/REPOSITORY'."
URL "https://github.com/keatontaylor/alexa_media_player"
failed with error message "Could not add https://github.com/keatontaylor/alexa_media_player at this time, check the log for more details."
---log---
2019-06-23 12:05:52 [custom_components.hacs.hacs] keatontaylor/alexa_media_player - No acceptable js files found 2019-06-23 12:05:53 [custom_components.hacs.hacs] keatontaylor/alexa_media_player - Could not register.
---log---

all working perfect here...

when adding the link did you select Type: integration?

The issue is the / at the end of "https://github.com/keatontaylor/alexa_media_player/"
Use https://github.com/keatontaylor/alexa_media_player or keatontaylor/alexa_media_player and it will be valid.

The problem was in the "integration". Solved. Thanks for your help and I'm going to close this issue.


Integrate Engine with decoupled Translog interfaces

Signed-off-by: Bukhtawar Khan<EMAIL_ADDRESS>Description
The PR aims to Integrate Engine with decoupled Translog interfaces introduced in #3638  . This is the second part of introducing new interfaces and implementation as a part of decoupling. The overall proposal can be reviewed at https://github.com/opensearch-project/OpenSearch/pull/3471
Breaks down the main decouple PR into https://github.com/opensearch-project/OpenSearch/pull/3471 Pluggable translog work
Issues Resolved
https://github.com/opensearch-project/OpenSearch/issues/3241
Check List

[x] New functionality includes testing.

[ ] All tests pass

[x] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check

start gradle check

One general question. Is the point of having TranslogManager as an interface because we want to be able to create other translog managers (e.g., kafka manager)?

Thanks @nknize
The idea was to free Engine of the translog responsibilities and create NoOpTranslogManager to be able to create an Engine which doesn't support translog operations. The first part of the PR was https://github.com/opensearch-project/OpenSearch/pull/3638 where we introduced newer interfaces. For remote extensions(kafka) we have #3242 which is being worked upon. The idea there is to decouple TranslogWriter from it's underlying store. I will be raising that PR soon.

Hi @Bukhtawar
Gradle check fixed. Sorry for confusion.
I rebased your branch and pushed so PR re-run checks now, thanks.

Is the point of having TranslogManager as an interface because we want to be able to create other translog managers (e.g., kafka manager)?

The idea was to free Engine of the translog responsibilities and create various flavours

so, yes? :smile:

For remote extensions(kafka) we have #3242 which is being worked upon.

I presume this will create a new KafkaTranslogManager?
I'm trying to glean from this incremental PR if the implementation design is to have 1:1 concrete TranslogManager implementations per translog mechanism. So if a user wants to use Kafka as the Translog we, OpenSearch, would provide a KafkaTranslogManager for handling the kafka specific logic?

I'm trying to glean from this incremental PR if the implementation design is to have 1:1 concrete TranslogManager implementations per translog mechanism. So if a user wants to use Kafka as the Translog we, OpenSearch, would provide a KafkaTranslogManager for handling the kafka specific logic?

The idea is definitely to support streaming stores like kafka and other blob stores to start with. At this point honestly, I am still contemplating if we should introduce a new low level abstraction or continue with TranslogManger as the abstraction itself.
I'll be shortly putting forth a proposal and open up a discussion


feat: add schema option UseOneofFields

When set, if the message contains any oneof fields, a BigQuery STRING field will be created
for each oneof group. It will then contain the name of the oneof that is set. This gives
support for having oneof groups where one of the fields in the group is an empty message.
This commit also fixes the behavior of InferSchema to skip fields that are empty messages
since that is not supported by BigQuery.

Codecov Report

Merging #55 (0a61b32) into master (325746c) will increase coverage by 2.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   58.37%   60.48%   +2.10%
==========================================
  Files           7        7
  Lines         788      830      +42
==========================================
+ Hits          460      502      +42
  Misses        262      262
  Partials       66       66

Impacted Files
Coverage Δ

encoding/protobq/marshal.go
62.96% <100.00%> (+0.87%)
:arrow_up:

encoding/protobq/schema.go
79.59% <100.00%> (+3.40%)
:arrow_up:

encoding/protobq/unmarshal.go
53.45% <100.00%> (+3.03%)
:arrow_up:

@odsod Thanks for the feedback! Very nice bug catch you did there. Added a test case for both marshal and unmarshal, but it only required changes for marshal.


Add a link to your article on Digital Twin

Hi Charles,
I am new to the Digital Twin Concept, but I am researching the topic.
It would help future readers of this module, with a link to your Digital twin article.
https://www.sciencedirect.com/science/article/pii/S2405896322014057
br
Andreas

Hi Andreas,
thank you for the idea! I will be adding the link to our latest paper on this project:
https://ieeexplore.ieee.org/document/9921499
Please let me know if there is anything else I could improve.
BR,
Charles.


changes of closing the stream on ioexception

The followUpRequest IOException is catch and the streamallactor is closed and the exception is re throws the IOException

@yschimke  ok sure. let me add a test

Do you need any help with the test?

This PR can be closed as of #3971


Price Predictor

Is there an existing issue for this?

[x] I have searched the existing issues

Feature Description
Car Price Prediction
Car Specifications
Make: Manufacturer of the car (e.g., Toyota, Ford).
Model: Specific model of the car (e.g., Camry, Mustang).
Year: Year the car was manufactured.
Mileage: Total miles the car has been driven.
Engine Size: Volume of the car’s engine (e.g., 2.0L).
Transmission: Type of transmission (e.g., manual, automatic).
Fuel Type: Type of fuel the car uses (e.g., gasoline, diesel, electric).
Use Case
Dealership Pricing: Help car dealerships set competitive prices for new and used cars.
Consumer Pricing: Provide buyers with estimated fair market values to negotiate better deals.
Insurance Premiums: Assist insurance companies in determining premiums based on car values.
Loan and Lease Valuation: Help financial institutions set appropriate loan and lease terms.
Benefits
Using a car price predictor offers several benefits:
Accurate Pricing: Ensures fair and competitive pricing.
Market Insights: Reveals trends and price fluctuations.
Inventory Management: Optimizes pricing for better turnover.
Insurance Premiums: Helps set fair insurance rates
Priority
High
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[ ] I'm willing to provide further clarification or assistance if needed.

Please assign the label.
I would like to work on this please assign this to me.

please label the issue gssoc and level so I can be assigned and solve the issue
I agree to follow this project's Code of Conduct
I'm a GSSOC contributor
I'm willing to provide further clarification

i want to work on this issue please asssign it.
i will be using various Learning algorithms and compare their metrics for model improvement.

No We are working on the stackoverflow the above has no relations , I have raised few other issue maybe you can work on the same.

Please assign me another issue so I can used my Machine learning knowledge. I didn't able to see issue which you raised @sanjay-kv


CASSCF orbital energies for both spin channel

Dear PySCF developers,
I am trying to obtain the orbital energies for an O atom from CASSCF,
see minimal example below
from pyscf import gto, mcscf
mol = gto.M(
atom = 'O 0 0 0',
basis = 'pc-1',
spin = 2
)
myhf = mol.UHF()
myhf.kernel()
mycas = mcscf.CASSCF(myhf, 13, (5,3))
mycas.kernel()
print(mycas.mo_energy)
However, upon printing the mo_energy I always only end up with the spin-up channel (5 occupied orbitals).
[-20.67136201  -1.2503043   -0.27449597  -0.27449597  -0.56553371
1.01464001   1.01464001   1.00839961   1.433521     2.45877544
2.45877545   2.47128126   2.47128126   2.462906  ]
Is there any way to get the orbital energies of the other spin channel?
Best,
Kai

I think these orbital energies correspond to molecular orbital energies [not spin up/spin down]. You are starting with UHF, where you will see the spin-up & down orbital energies and occupancy. Using UHF as the initial guess in CASSCF, PYSCF is taking one of spin as the initial guess, but CASSCF will produce results in the MO basis.
You can use the " mycas.nat_orb = True " to see the occupancy of orbital, which might be helpful as that will tell you which orbitals are doubly/singly occupied.

I see. Thank you for your comment.
It appears that -20.67136201 -1.2503043 -0.56553371 are double-occupied, and  -0.27449597 -0.27449597 are single-occupied.
Now I am just wondering how "good" these orbital energies really are.
Looking at the highest occupied Hartee-Fock orbitals, it has an
energy of about -14.2 eV (reasonably close to the ionization potential of O, which is 13.6 eV).
However, according to the MO energies from CASSCF we get a highest occupied orbital of -7.5 eV,
much worse than Hartree-Fock. Would one expect the orbital energies in CASSCF to be "better" than Hartree-Fock?
Or can we not make such an assessement due to the fact that CASSCF only uses one of the spin-channels?

The IP for O atom which is around -14.2 eV at UHF is based on Koopman's theorem.  However I am not sure how applicable is this theorem for  CASSCF orbitals or Multi-reference orbitals, because these orbitals are being optimized under different condition.
In case if you are interested in calculating the IP using CASSCF you have to do two calculations
O  and O+ ion and difference of that will be the IP.

CASSCF doesn't have "orbital energies". The mo_energy acquired from CASSCF object is just the expectation values of fock operator of MOs, not really orbital energies.

Ok thank you for clarifying.


Add Adafactor optimizer

Relevant information

Are you willing to contribute it: Not at this time.
Are you willing to maintain it going forward? Yes
Is there a relevant academic paper? https://arxiv.org/abs/1804.04235
Is there already an implementation in another framework? https://github.com/tensorflow/tensor2tensor/blob/master/tensor2tensor/utils/adafactor.py
Was it part of tf.contrib? No

Which API type would this fall under (layer, metric, optimizer, etc.)
This is a new optimizer.
Who will benefit with this feature?
Users using optimizers with adaptive learning rate and looking to reduce the memory usage.

I will give this a try tomorrow

I talked with @guillaumekln and we decided that we will drop the experimental quantization flag of the t2t  implementation to avoid implementing all the dependencies for now.
It looks like Keras will add quantization functionality as discussed in here, so we can add the flag back into the function once it is released. @seanpmorgan @WindQAQ are you okay with that approach?

I talked with @guillaumekln and we decided that we will drop the experimental quantization flag of the t2t implementation to avoid implementing all the dependencies for now.
It looks like Keras will add quantization functionality as discussed in here, so we can add the flag back into the function once it is released. @seanpmorgan @WindQAQ are you okay with that approach?

I am fine with this :smiley:

Checking in on this issue; it looks like something that would be useful for the external community. Has there been any progress on adding Adafactor as an optimizer?

@Smokrow I remember you were not far from completing the development. Are you still interested in opening a PR with this optimizer?

Hey there. It is basically finished. I got stuck on the testing part since I am not quite sure what is a valid way to test this thing. Sorry for the delay. Work got a little bit busier in the last few months :grimacing:

Hi! Checking in as to whether anyone has updates on getting Adafactor into a TF release (or in add-ons). I've been using a version adapted from the original Tensor2Tensor repo but it's a bit quirky and doesn't play well with tf.keras LR schedules (I know Adafactor has an internal adaptive LR and the paper says you shouldn't need an external LR schedule, but empirical evidence seems to suggest it would be helpful).

@mathemakitten Hi! It does not seem anyone is working on this at moment. It mostly means the community is not interested that much in this optimizer. Are you interested in making a PR?

I have a TF Adafactor implementation that I had to modify to work well with keras's lr schedulers and I know that it works well on TPUs. It probably needs to be cleaned up, but the code is here if anyone's interested:

Adafactor and warmup + linear decay scheduler: https://github.com/bkkaggle/lm-training-research-project/blob/master/optimizers_tf.py#L11-L452
example of how I'm using it: https://github.com/bkkaggle/lm-training-research-project/blob/master/train_tfrecords.py#L228

It will be very nice to have the adafactor. It will save memory a lot for NLP models. We do not have a common TF2 implementation now.
Is Adafactor planned for the future release of addons?

Hey @guillaumekln happy to make a PR, or @bkkaggle would you like to do it? My implementation is very similarly adapted out of the T2T implementation like yours. I've added support for compatibility with external LR schedule objects, and weight decay (and excluding weights from weight decay by name).

My implementation is pretty messy so go ahead and merge your implementation in if you want!

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


Fixed issue with running function remotely

Fixed the following error when attempting to run the function remotely.
Unable to make a connection to . Error was:
The response content cannot be parsed because the Internet Explorer engine is not available, or Internet Explorer's first-launch configuration is not complete. Specify the UseBasicParsing parameter and try again.

Does -UseBasicParsing return the same set of objects that the call without it returns? Otherwise it could be problematic if it is trying to use a JSON element that doesn't exist. I think last time I played with it the DOM returned by the basic parsing was somewhat different than the full notation without it.

I try to make a habit of passing this switch because I might be running an arbitrary command remotely, so IE doesn't really behave properly because it wasn't designed to be invoked on an OS without a GUI, the remote server might not even have IE installed, and it takes more resources to start an instanced of IE. :-)

Hi There! I'm closing this issue because after #234 its sort of not valid anymore. Is there any chance you can let me know if you can still see this behavior in 0.6.0? If that's the case I'll do something about it to honor the time you took on this PR (huge thanks for that and sorry I didn't merge it before).

No problem. Thanks for taking a look.


What web browser engine this use?

Gecko? WebKit ? Just wondering, thanx.

From PhantomJS site:

PhantomJS is a headless WebKit scriptable with a JavaScript API.

Thanx


[CODEGEN] Fix alignment generation

Alignment for load/store wasn't generated properly in the previous version due to bug introduced by a refactor. Added test cases to prevent it from happening again

cc @yzhliu


Why ~/.vim/plugged instead of the widely used ~/.vim/bundle?

Since all the other major plugin managers store plugins in "bundle" directory, you might want to pass it to plug#begin() if you do not wish to reinstall plugins.

— https://github.com/junegunn/vim-plug/wiki/faq#migrating-from-other-plugin-managers
Why not just only use ~/.vim/bundle?

Using the same directory implies that vim-plug is compatible with the others. For now, it is true, but it wasn't so in the past. And with no promise of compatibility, I can freely try different things in the future


attempt to index local 'buffer'

Hello, im using this code: self.nextSound = CurTime() + (NewSoundDuration(sound) or 0) * 1.5
But i get this error after the line is getting called:
[____an_preset_shit] gamemodes/skeleton/plugins/an_core/libs/sh_soundduration.lua:108: attempt to index local 'buffer' (a nil value)
  1. unknown - gamemodes/skeleton/plugins/an_core/libs/sh_soundduration.lua:108
   2. NewSoundDuration - gamemodes/skeleton/plugins/an_core/libs/sh_soundduration.lua:197
    3. PlayAlert - gamemodes/skeleton/plugins/an_core/entities/entities/alarm.lua:148
     4. func - gamemodes/skeleton/plugins/an_core/entities/entities/alarm/shared.lua:392
      5. unknown - addons/____an_preset_shit/lua/autorun/server/net_message_logger_init.lua:45

Line 108 is this one:
if buffer:Read(3) == "ID3" then

What is sound set to in your code? It would seem there's no file to be read there

I did some testing and found out that the problem is that there is no "sound/" at the beginning of my sound name, so my mistake xd


Use kustomize for installer concourse pipeline

Since it is the preferred way to install a demo scenario.

I consent

@kramerul Do you consent?

I consent

Sorry about the CLA bot


Make quoting character configurable

Hello there!
Firstly I want to thank you for this project. It helped me to solve one localization issue on ppc64le architecture. It seems everything is working flawlessly.
I want to request one more feature from you: configurable quotation mark. Right now I have to use other third-party CSV parser library which is abandonware but still has freedom to choose which quotation mark to use. So my project now contains two CSV parser libraries (which is DRY violation, but I have no other choice right now :)
Thank you.

Hello!
Yes, this sounds like a reasonable request. Will take a look at this.

Hi, support for custom quote character has been added in above commit.
Example usage from https://github.com/d99kris/rapidcsv/blob/master/tests/test090.cpp
    rapidcsv::SeparatorParams separatorParams;
    separatorParams.mQuoteChar = '\'';
    rapidcsv::Document doc(path, rapidcsv::LabelParams(-1, -1), separatorParams);


Emtpy implementation for reactor.core.scala.publisher.ParallelFlux

I see some inconsistency between between reactor.core.publisher.ParallelFlux and reactor.core.scala.publisher.ParallelFlux. Scala ParallelFlux is empty.
Do you have plans to add some methods to this class ?
Thanks

Hi,

Do you have plans to add some methods to this class ?
Yes, of course. I just don't have the use case yet. If you have the use case, I can add it.

Hi.
Ideal case for me would be to add all methods from Java ParallelFlux and add public method toJava (convert to Java ParallelFlux; currently I even can't convert it to java version because it is marked as private).
But if it is not possible, would be good to add common method: runOn, subscribe, map, filter, flatMap, concatMap, reduce, sequential.

Thanks for your feedback.
I'll release a version with a method to convert to Java for now so you can access its underlying ParallelFlux.
In the meantime, I'll update it with the common methods as you said.
If you could also gives me a list of methods that you used, that'll be a good use case for me.

Many thanks @sinwe !
I use runOn operator to specify scheduler, then filter to filter inputs, then map to run heavy computation, and then sequential to merge the results.

Does it mean you don't care whether the end result is computed out of
sequence than the input?
On Tue, 5 Mar 2019 at 05:54 Denys Horman<EMAIL_ADDRESS>wrote:

Many thanks @sinwe https://github.com/sinwe !
I use runOn operator to specify scheduler, then filter to filter inputs,
then map to run heavy computation, and then sequential to merge the
results.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/reactor/reactor-scala-extensions/issues/21#issuecomment-469437010,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZqz5HxQcUpnugFI8fFrTj1YBYrmGUfks5vTZYTgaJpZM4baewG
.

--
Regards,
Winarto

No, I need to use sequential in order to pass computed results to other operators like scan.


collections should be sorted by number of stars

Some collections are sorted in order of entry addition, some collections are sorted alphabetically. Still none of this is a correct/fair/unbiased way to advertise the projects inside them as it would advantage either the time when it was entered or the first letters from the alphabet.
One less biases way to display entries is based on the number of stars these projects have, something that is already working well for topics.
We need the same for collections, as nobody expects to keep sorting order manually updated.
I am afraid that this change request requires some server-side changes on the way collections are displayed.

Nice idea but we have no plans to implement this currently.

So there are no plans to address the biased approach, which advantages those that were added first? This means that even a 5 stared listing that may be unmaintained will have better visibility than >1000 star one? 🤔

Yes. Stars are not the sole measure of popularity.


Add remove/edit option

🎇 Description
add remove record and edit record option so that if by mistake someone adds wrong details they can edit or delete it
🖼 Screenshots
No response

please assign this issue to me

Sure, please proceed.😇


Runtime deploy, support env variables in manifest.yaml

wskdeploy supports setting ${MYENV} in the manifest.yaml file
It would be great to have the same feature for aio runtime deploy
In the meantime, here is a dirty workaround to replace all ${ENVNAME}s with their content. Then one can run MYENV=myenv aio runtime deploy -m newmanifest.yml :
const manifest = yaml.safeLoad(fs.readFileSync('manifest.yml', 'utf8'))
const manifestString = yaml.safeDump()
  .replace(/'(\${.*}?)'/g, a => {
  const envName = a.match(/\${(.*?)}/)[1]
  return process.env[envName]
})
fs.writeFileSync('newmanifest.yml, manifestString)

Actually sorry env variables are supported with the $MYENV syntax.
But ${MYENV} is breaking although it works with wskdeploy.
So closing this one and opening a bug fix issue


Fix if-let when-let and add put-in (assoc-in)

There seems to be some problem with ast-unwrap(1) and recursion. It seems that subsequent calls and changes the argument of ast-unarwap doesn't work but i have not a clear mind right now. I might test it later.
I added a put-in (it took me more that expected to implement it due to if-let).
Before you push your implementations of array literals, maybe we could use [] to  avoid (tuple ...) when writing macros? I think it would be very convenient.

As you may have noticed, arguments to macros maybe wrapped in an abstract type parse.ast, which contains source mapping information. This is a a result of implementation, ideally, we would have a clojure-like metadata attribute for all values, but this is inefficient (it requires boxing primitives to support pointer equality).
ast-unwrap1 simply gets the data inside the parse.ast. ast-unwrap does the sam but then recursively unwraps data structures as well (arrays, tuple, structs, tables).

Before you push your implementations of array literals, maybe we could use [] to avoid (tuple ...) when writing macros? I think it would be very convenient.

It would be convenient, but I don't think it is a good idea for a number of reasons

It would mean square brackets could not be used for fn forms, let, etc.
Dst syntax would have that much more "magic"

What I think would be even nicer is syntax quoting and unquoting, which can be implemented via macros.
I also don't see put-in in the changed files.

I see. Ok yes Rich Hickey must have new what he was doing with clojure macro implementation :P
I created a new file examples/core.dst, which apparently is gitignored :S I renamed  it to util.dst again

Ok yes Rich Hickey must have new what he was doing with clojure macro implementation :P

Yeah :P. In thoughts.md, one of the topics is how to remove parse.ast while still retaining the ability to do source mapping with macros. I think it's possible, but will require some changing of the compiler.

About the metadata.  Clojure supports metadata on symbols and data structures, symbols are not primitives so a presume  (I don't have good knowledge of the jvm or vm's anyway) that are already boxed and stored to the heap? On the other hand lua's (and yours) vm is registered based, and all data structures are  stored in registers?

In the JVM, everything is an object except primitives, which all have corresponding boxed representation. When the clojure parser parses source code, it uses these boxed representations of integers, doubles, booleans, nil, strings, etc. This allows every form to be a unique instance, and so the meta information can just be kept in an external data structure that takes any Object as a key and returns its metadata (I’m just guessing here, but it seems likely). In dst, the parser returns numbers in an unboxed form, so after parsing, two instances of the same number are completely identical - when generating bytecode source mapping for a number, symbol, or Boolean, the compiler has no way to tell where in the source code that particular primitive was created, unless we pass around the source mapping information with said primitive (hence the parse.ast wrapper).
There are ways around this, for example only keeping track of source mapping information for data structures (arrays, tuples, structs, tables), and being slightly less precise when mapping each bytecode instruction to a source code location. I would like to try and make this change in the compiler and see if I can remove the parse.ast abstraction.
While source mapping is not currently seen in the repl when errors occur, if you disassemble the bytecode of a function in boot.dst (using disasm), you should hopefully see that there are a pair of byte offsets (start and end offsets) for each bytecode instruction that indicate which form in the source file emitted that instruction during compilation.

I see, so we should be able to add metadata to function arguments, for example but not to the symbols. Would too much of an overhead if you added the metadata to symbols, like in clojure? (of course you have already thought of that but i would like to understand the motivation on the decisions)

Symbols are all interned for speed, as they are also used like keywords. This causes the same problem as adding metadata to primitives like numbers.
For a more concrete example, see the following snippet:
(defn fun [x y]
  (if x x y))

In the above snippet, there are 3 instances of the symbol x. Because symbols are interned, after parsing, all x symbols are simply pointers to one location, 0x1234; they are identical. When the current compiler is compiling an 'x' symbol, there is no way of telling where in the source this X symbol came from because macros can freely transform the source code, and all x's are exactly the same, so they cannot have unique metadata without a wrapper.
To allow metadata, each symbol would need to be a pointer to a unique location, say 0x2222, 0x3333, and 0x4444, and equality checking suffers a little bit. It wouldn't be too much overhead, but I would rather not as this would require many changes to the runtime. I think there is a better solution to source mapping that I will pursue.


EasyRTC sdk for react native

@hthetiot buddy how soon can we expect easyrtc sdk for react native.

Simply you need to learn JavaScript and stop creating issue "he I need React native support", no you dont. Just learn JavaScript and you can do anything you want in TypeScript and/or React Shit.
Note: The word "Native" in "React Native" does not mean shit, it's not Native anyway.
You want Native learn Swift or JAVA or C.

Sorry if i offended you.

@syedMSohaib you did not offended me. Only me could have offended you and that was not my goal, sorry if i did.
You are right in what you say, but that the way I am :) I can be really nice if the comment or issues is pertinent.

Its k :) , 20 Years of JS, thats great, i have just started my career so much to learn. Will follow your advise too.


Computer Crash Down

When training with 4 Titan Xp GPUs, the code crashed down for many times. Any bugs there?just add following code,
device_ids = [0,1,2,3]
if args.cuda:
net = torch.nn.DataParallel(ssd_net, device_ids = device_ids)
cudnn.benchmark = True

The code made my computer crash down and reboot


Why can't layoutParams be called inside of init functions?

frameLayout{ layoutParams(matchParent, matchParent)}
vs the recommended
frameLayout{ }.layoutParams(matchParent, matchParent)
I see doing it the first way only works partially, some attributes do not work like margins.  I think the required way really hurts the readability of the layout it would be preferable to put it inline.

http://blog.jetbrains.com/kotlin/2015/04/announcing-anko-for-android/#comment-33273

Yeah I'm having a really hard time understanding how this works. I am having lots of issues with getting layoutParams to even compile a lot of the time it tries to goto the val View.layoutProperties helper instead. At runtime I get exceptions because my dsl is trying to add the incorrect layout params to the view.

I don't understand a problem mentioning View.layoutProperties . Could you provide an example?

Sure inside a support Fragment the following won't compile because layoutParams for swipeRefreshLayout is scoping to public var android.view.View.layoutParams: android.view.ViewGroup.LayoutParams? inside of Properties.kt
        UI {
            swipeRefreshLayout = swipeRefreshLayout{
                setColorSchemeResources(R.color.primary, R.color.primary_light, R.color.accent, R.color.primary_dark)
                setOnRefreshListener(this@RecyclerFragment)
                recyclerView = customView {
                    layoutParams = RecyclerView.LayoutParams(matchParent, matchParent)

                }
            }.layoutParams(matchParent, matchParent)

        }

Setting a RecyclerView.LayoutParams to the view that is inside a SwipeRefreshLayout container is what you want to do?

I just simply want both views to match parent rather than wrap content. If I had margins and stuff to set it would be a big problem but for now I just put the layoutParams call inside of the swipeRefreshLayout instead, like I'm doing for the recyclerView.  The recyclerView also has the same problem and I can not call layoutParams in the suggested way.

The problem should be fixed with the DslMarker annotation support from Kotlin 1.1 (#300).
Starting from Anko 0.10, you simply can't apply the wrong lparams since no candidates other than the direct parent ones are available.
If you have some another problem with the recommended syntax, please feel free to file the new issue.


Fix/render updates

Hi! I was trying to perform updates using D3's enter(), update() and exit() methods but was stuck because the mixin currently create the faux node each time connectFauxDOM is called. I've made a minor change to simply return the stored node if it exists, instead of overwriting it. I also added an example to showcase the new functionality. Hope this can be useful.

@Olical: about breaking changes, some users might implicitly rely on the fact that the faux node is recreated from scratch at each connectFauxDOM call. I had not considered it previously. I could leave this API untouched and add another one that implement the new behaviour, something like reconnectFauxDOM. Then the first call to reconnectFauxDOM would be equivalent to connectFauxDOM but subsequent calls would be update-friendly. What do you think? I think it is a safe option and would mean a feature bump (v3.1.0?).

PR rebased on master

@Olical any feedback on reconnectFauxDOM?

I think it'll be okay as it is, it was wrong before. I doubt anyone was relying on the recreation directly. If they are, that's essentially a bug anyway, they can stick on the old version if required.

@Olical makes sense, and I prefer a simpler API! If you have no additional review I think we're good to merge :)

Yep, it's cool. I'll merge and deploy it tonight, sorry about the slowness, it was a holiday weekend here in the UK :smile:


feat(mapper): expose MapperFlush(All)?::new

It looks like there is no way to create an instance of these types.
Fixes: #295

I think this PR can be closed per https://github.com/rust-osdev/x86_64/issues/295#issuecomment-902480504

@toku-sa-n you should also rebase this on latest master, that should fix an CI issues.


Optional params/zero-length rest routes

Via this Stack Overflow question. It would be nice if there was a way to do optional parameters — e.g. /foo, /fr/foo and /ca/fr/foo all resolving to the same page component (where fr is a named lang parameter and ca is a named country parameter).
@Timer from the Next.js team had a neat idea — we could mark optional parameters with double brackets: routes/[[country]]/[[lang]]/foo.svelte
At the same time, it might be nice if routes/[...parts]/foo.svelte matched all those pathnames. At present it will match /fr/foo and /ca/fr/foo but not /foo.

Rest parameters can now have zero length (i.e. /foo/[...bar]/baz will match /foo/baz), so I'll close this


Pyro

Leveled branch pyro with master

Ok sorry I don't see that you have already done ;)

@persuader72 I can not really test the pyro branch tough but I try to put in the stuff if possible.


Use the Hub API to spawn users

TODO list (mostly for min):
We should create a NullAuthenticator and use the Hub API to spawn users with tokens, rather than tmpauthenticator

[x] demonstrate that this works (https://github.com/jupyterhub/jupyterhub/pull/1383)
[x] create NullAuthenticator, which doesn't allow logging in at all
[x] use the Hub API to spawn servers and retrieve tokens instead of redirect to /tmplogin
[x] support deleting users in cull_idle_servers, rather than just stopping servers https://github.com/jupyterhub/jupyterhub/pull/1380
[x] take a pass on errors on the JupyterHub side (#91 covers lots of errors on the binderhub side, but not failure to run after the fact)
[x] add token for binder to the Hub via (non-managed) services config
[x] validate images by running jupyterhub-singleuser --version after build

Most of these have just been deployed!

#135 / #142 deals with failure to launch by including launch errors in the event stream. The image validation is also less significant, since now we only assume that the image is a web server, and not anything else.

We do this now!


Merge package partition.graph to SANSA

Add rdf graph partition algorithms to SANSA-RDF

Hi @CescWang1991
many thanks for your work and since we check all statuses to pass before we merge, could you please fork the exact branch (develop) and then create PR.
Will wait for your update.

We are going to close this PR without merging it since there is a new PR where all checks pass.


Update conference section

Moved "Bitcoin Only Meetup" which was organized in India on 22-23 Feb 2020 to "looking back" section and linked to meetup info website

Closing this and will make another PR
Need to change the link


Error in make_patches if patchsize in config.ini is equal to patchsize and no mask was specified.

Error in make_patches if patchsize in config.ini is equal to tilesize of ROI and no mask corresponding mask is provided.
Error reproduced in PS v5.8.
Traceback from PatchSorter.
ERROR: Traceback (most recent call last):
File "./approaches/make_patches/make_patch_database.py", line 251, in 	rows, cols = np.unravel_index(idx_out, idxs.shape)
File "<__array_function__ internals>", line 5, in unravel_index
TypeError: only int indices permitted
Issue arises from line 245:
           idxs = np.asarray(range((imgshape_orig[0] - patchsize) * (imgshape_orig[1] - patchsize))).reshape(
                np.asarray(imgshape_orig)[0:2] - patchsize)

Patchsize gets subtracted from imgshape_orig but idxs should be equal to the unpadded image and padding is added to idx later on. Further, if imgshape is equal to patchsize this will result in an empty array leading to a type error in np.unravel_index.
Fix replace line 245-246:
idxs = np.asarray(range((imgshape_orig[0] ) * (imgshape_orig[1] ))).reshape(
np.asarray(imgshape_orig)[0:2])

yea!! good eye, thanks!


📈 Document a Process for registering and sharing a Database/Table/Column from Ireland APDP to London APC using Lake Formation

User Story
In order to keep the scope of the QuickSight MVP small, we have agreed to limit the initial implementation to a handful of pre-selected datasources. However, participants might want to add additional ones over the course of the testing, so to aid in that, we need a fully defined, documented process (manual or scripted) to share a resource from Ireland analytical-platform-data-production to London analytical-platform-compute
Value / Purpose
Documenting this would allow us to easily expand the scope of our MVP to new users and new datasets if required.
Useful Contacts
@julialawrence @michaeljcollins @jamesstott
User Types
Data Engineers
Hypothesis
If we implement this, we can be more flexible with the scope of our MVP testing, expanding it if it appropriate to do so.
Proposal
Document and test the process to do the following:

Register a data location in anaytical-platform-data-production in Lake Formation in hybrid mode.
Share resources from Ireland APDP into analytical-platform-compute Ireland.
Share resources from Ireland APC to London APC
Identity a data engineering user to be the admin of the shared datasource
Assign them grantable permissions over the shared resource to allow them to continue managing access and grant it to others via the new UI.

Additional Information
https://docs.google.com/document/d/1Xwbvc8ipI2m6nlK3et-TUcrksjhV9MmNqEVFtVbtkOQ
Assume the sharing is done via named resources.
Definition of Done

[x] Sharing process documented and tested
[] Instructions published as a playbookl - No longer required team decision to use lakeformation terraform module for ease of use
[x] Another team member has reviewed

Document for testing sendong a lakeformation resource from AP Dev(ireland) -> AP Data Dev(ireland) then AP data dev(ireland) to AP data dev(London)
https://docs.google.com/document/d/1bMk5onKLs1RC8oOXjLhlmAu84ZilAdxanvd7AAWqDRY/edit

Closing as document reviewed by team - decision to implement terraform module for lake formation as main usecase going forward due to ease of use


add GHA for release

Addressing #154.

I will let you do the honors of merging.

@jGaboardi what should I do with the Changelog.md if I want to cut a release? With these actions, it is not updated automatically. Shall I make a manual PR with the changes (not ideal as it will be out of sync with release notes)? I can't update changelog based on the generated notes after tagging as it would mean that changes are not documented in the package itself.
I wanted to check how it is done in spaghetti but the changelog there hasn't been updated since 1.5.0 :D.

@jGaboardi what should I do with the Changelog.md if I want to cut a release? With these actions, it is not updated automatically. Shall I make a manual PR with the changes (not ideal as it will be out of sync with release notes)? I can't update changelog based on the generated notes after tagging as it would mean that changes are not documented in the package itself.
I wanted to check how it is done in spaghetti but the changelog there hasn't been updated since 1.5.0 :D.

LOL. whoops. In spaghetti I am treating the release notes as the changelog since 1.5.0. As for here in splot, I have no strong opinion. However, it would be super nice in general if we could tie changelog updates in with the release action. For now maybe you could do the manual PR for change updates just prior to triggering the release action so that it is included with the package?

However, it would be super nice in general if we could tie changelog updates in with the release action

That is not possible, you need to update the changelog before we assign a tag. So you would need the release action to have a different trigger than a tag and git tag should be then part of then action after a push to the changelog. None of it sounds idea. Let's discuss it later today during the call.


forge fmt: Additional formatting features

Component
Forge
Describe the feature you would like
Hey folks from Maple here, we would like to switch to using forge fmt, currently we're doing everything manually so this would save us alot of time and we're sure others could benefit too. Also happy to help with implementing!
Here are a list of options we would like in the formatter to make the switch:

A new line at the top and bottom of top level declarations

interface interfaceName {

    code;
    code;
    code;

}

contract contractName1 {

    code;
    code;

}

Ignore section headers (as they currently get reformatted)

/**************************************************************************************************************************************/
/*** Helpers                                                                                ***/
/**************************************************************************************************************************************/

For assertions of the same type, the parameters must be aligned so that the second set of parameters are left justified for each code block (this can be focussed around test helpers to start with)

assertEq(mockToken.balanceOf(address(treasury)), 0);
assertEq(mockToken.balanceOf(address(mpl)),      100);
assertEq(mockToken.balanceOf(address(holder1)),  0);
assertEq(mockToken.balanceOf(address(holder2)),  0);

assertEq(token.fundsBalance(),   60_000);
assertEq(token.pointsPerShare(), expectedPointsPerShare);

Align the assignment operator for code blocks

function increaseCustodyAllowance(address custodian, uint256 amount) external override {
    uint256 oldAllowance      = custodyAllowance[msg.sender][custodian];
    uint256 newAllowance      = oldAllowance.add(amount);
    uint256 newTotalAllowance = totalCustodyAllowance[msg.sender].add(amount);

    PoolLib.increaseCustodyAllowanceChecks(custodian, amount, newTotalAllowance, balanceOf(msg.sender));

    custodyAllowance[msg.sender][custodian] = newAllowance;
    totalCustodyAllowance[msg.sender]       = newTotalAllowance;
}

Add a space after the opening and before the closing bracket of a tuple

( , , uint256 foo, uint256 bar, , uint256 baz, , , ) = functionName();
( success, ) = functionName();

Left justify align state variables by longest type for each code block

uint256 internal nextDelegateOriginationFee;
uint256 internal nextDelegateServiceFee;

uint256 internal start;

// Helper mapping to assert differences in balance
mapping(address => uint256) internal partialAssetBalances;

Asset        internal collateralAsset;
Asset        internal fundsAsset;
Globals      internal globals;
PoolDeployer internal deployer;

FeeManager        internal feeManager;
LoanManager       internal loanManager;
Pool              internal pool;
PoolDelegateCover internal poolCover;
PoolManager       internal poolManager;
WithdrawalManager internal withdrawalManager;

Align imports by the furthest 'from' keyword in each code block

import { Address, TestUtils } from "../modules/contract-test-utils/contracts/test.sol";

import { MockERC20 as Asset } from "../modules/erc20/contracts/test/mocks/MockERC20.sol";

import { MapleGlobals as Globals } from "../modules/globals-v2/contracts/MapleGlobals.sol";
import { NonTransparentProxy }     from "../modules/globals-v2/modules/non-transparent-proxy/contracts/NonTransparentProxy.sol";

import { Liquidator }            from "../modules/liquidations/contracts/Liquidator.sol";
import { LiquidatorFactory }     from "../modules/liquidations/contracts/LiquidatorFactory.sol";
import { LiquidatorInitializer } from "../modules/liquidations/contracts/LiquidatorInitializer.sol";

import { MapleLoan as Loan }                       from "../modules/loan-v400/contracts/MapleLoan.sol";
import { MapleLoanFactory as LoanFactory }         from "../modules/loan-v400/contracts/MapleLoanFactory.sol";
import { MapleLoanFeeManager as FeeManager }       from "../modules/loan-v400/contracts/MapleLoanFeeManager.sol";
import { MapleLoanInitializer as LoanInitializer } from "../modules/loan-v400/contracts/MapleLoanInitializer.sol";

Additional context
No response

Open to all of these! Would recommend doing 1 PR per, and thinking about "what does the config look like" for these, as Maple has a pretty unique formatting style which some may not want to use.

Yup agree a separate PR for each. In terms of config had the following suggestion for each:

top_level_spacing: bool
ignore_section_headers: bool
assertion_alignment: bool (could be further extended with different options later)
assignment_alignment: bool
tuple_spacing: bool
state_variable_alignment: bool
import_alignment: {false, "left_justify_from"} (I can foresee options being added here so being specific would help)

@0xfarhaan my recommendation is to delay 2. since #3786 refactors comment handling. otherwise, these requests fall into two categories - spacing and alignment. spacing most likely would have to be handled on-site - embedding logic into visiting tuples and function calls. as for alignment, there could be a nice abstracted helper method for doing this, dunno yet 💭

Hey all, going to make individual issues to discuss these and provide diff examples so we can prioritize and revive this awesome future feature!

Marking as duplicate considering the majority of the issues raised have been split out into individual tickets:

https://github.com/foundry-rs/foundry/pull/4212
https://github.com/foundry-rs/foundry/issues/5074
https://github.com/foundry-rs/foundry/issues/5074

@0xfarhaan please create individual tickets for each case not covered by this and you would like to see implemented


linux_session: Make allow_other mount option optional

The allow_other mount option typically requires root user permissions unless configured otherwise on the machine. It would be nice if this was configurable to allow for unprivileged mounting.
For non-root users to use this option the system must have 'user_allow_other' set in /etc/fuse.conf.

MacOS failures seem unrelated.

MacOS failures seem unrelated.

Yes, it's independent of this PR and just get fixed.

Yes, it's independent of this PR and just get fixed. Could you please help to rebase?

Done.


[Builtins] Factor causes out of the builtins machinery

Returning an ErrorWithCause from the builtins machinery was a mistake from day 1.
This PR fixes that by attaching the cause of an actual failure (not a potential one
like before) to the error message at the call site.

/benchmark plutus-benchmark:validation


build: update package versions

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Codecov Report

Merging #472 (6e09198) into master (c345124) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #472   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           89        89
  Lines         3236      3236
  Branches       555       555
=========================================
  Hits          3236      3236

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Implement standardized linting and formatting procedures.

Codebase needs to use clang-format for formatting and clang-tidy for linting. Uses the standard .clang-format file.
An automated script will be added for simplicity into the makefile with this commit, this is the main change to be made.
This adds the clang compiler as a developer dependency* -> create/update guide/prereqs,md with that.

Issue superceded by #9


twitter-text says tweet is valid but fails to post with error 32: "Could not authenticate you."

When a tweet starts with an asterisk, twitter-text says it is valid, but Twitter sends back an error: "Could not authenticate you." (code 32)
Twitter::Validation.tweet_invalid?("*TEST* Does this work?") # returns false

client.update("*TEST* Does this work?") # raises Twitter::Error::Unauthorized: Could not authenticate you.

client.update("TEST Does this work?") # works

Closing old ticket. Doesn't seem to be related to this library.


MeshService deeper integration

Description
Policy attachment/inspect api should be usable from the GUI.
MeshGlobalService (or whatever this related to). MeshHostnameGenerator and other things like this.
TODO complete this issue with precise things to integrate with @jakubdyszkiewicz and @michaelbeaumont

Triage: another option is to just not show HostnameGenerator at all

Not super clear what (if anything) is to be done here at this point in time.
https://github.com/kumahq/kuma-gui/issues/2469 is covering basic list/summary/detail and covers this part of @michaelbeaumont s comment above:

Service view - select services by type
Dropdown selector for service type
OR button per service type

(we went for button per service type)
I think

Policy attachment/inspect api should be usable from the GUI.
MeshHostnameGenerator and other things like this.

Are still work in progress from the backends perspective, and could be better to close this issue and create two new ones for these two points once its clear what's to be done.

I'm going to take this one out of 2.9.
Theres an issue to cover:

Policy attachment/inspect api should be usable from the GUI.

for 2.9 (https://github.com/kumahq/kuma-gui/issues/2880)
And I don't believe we are aiming for GUI support HostnameGenerator for 2.9.
But let me know if this still needs to be in 2.9, we can add back the milestone


2.6.1 download is missing

There is a GitHub tag for 2.6.1 but no download at https://tls.mbed.org/download/mbedtls-2.6.1-apache.tgz
What is the status of 2.6.1? Is it a real release?

Hi @ilovezfs,
If you have a look at Mbed TLS 2.6.1, as you can see from this diff,  it contained a single fix to do with renegotiation. The release was done for Mbed, but we didn't consider this to merit a full release on the Mbed TLS website as most customers would be unlikely to encounter the issue. You only encounter the issue if SHA-1 is disabled which isn't the default configuration and limits interoperability.
Hope this answers the question! Assuming this is sufficient, I'm closing the issue, but feel free to reopen it or follow up with more questions.


Is there a way to "clean" Astronomy objects?

When I fetch objects from the database, there's a lot of extra Astro fields attached to them besides just my own data fields. Does Astronomy have a way to clean these? The extra fields are causing problems with Redux.

The best solution I've found is to do this:
const o = someAstroObject._original; // o = plain JSON object, no Astro properties

You can do doc.raw() to get clean object.

Awesome tip!! Thank you.


[RC-163] Apply GitHub issue <-> Linear sync

It seems the syncline is broken. Needs to let GitHub issue and linear sync.
https://synclinear.com/
From SyncLinear.com | RC-163

After turning off the Linear's GitHub issue integration, the synclinear work!


Deployment Script Fails

While deploying the app, it creates the SP site but fails at what looks like List creation. The path to the XML is not long nor contains double quotes like most of the issues I see. I've deleted the site and rerun the script several times. I've also re-registered the PNP app accepting all permissions. Running as a global admin. What next?

@tjackson-bcg, Thank you for reporting this.
Can you please confirm if you are in GCC or GCCH tenant?
If its GCCH tenant you will have to run provisioning script for GCCH which will ask for PNP App Client ID which you have registered as mentioned.
Please do let us know if this helps.

We have a GCC tenant, not GCCH.

@tjackson-bcg,
We hope you are running the script with SharePoint Administrator user.
Can you please confirm which version of PnPPowershell you are using?

When we are prompted for Azure login, we are specifying a global admin user which will have Sharepoint permissions by default. We are using version 2.2.114 of the PnP.PowerShell module in Powershell

@tjackson-bcg ,
Request you to kindly update the PnP version. Please run below commands and then try to run provisioning script again.
Uninstall-Module -Name PnP.PowerShell -AllVersions -Force
Install-Module PnP.PowerShell -RequiredVersion 1.12 -Force
Please let us know if this help.

Downgraded PnP to 1.12 and re-ran the script. Same issue occurs. I was also using Powershell 7 originally and am now using Powershell 5.2. There is a slightly different error now.


Make Web Components usage optional

In certain scenarios built-in elements might not fit at all and generally no Web Components might be use (for instance, React or Angular app).
For such cases would be nice to have option to avoid loading completely following elements:

Web Components polyfills
any HTML imports
Polymer
Polymer behaviors and patches

Also the rest of code should be aware that window.Polymer might not be what is expected (like calling Polymer.updateStyles()).
In administration interface (and for CleverStyle theme in general) Web Components will be used without alternative.
Option should only be available for advanced users, since it WILL break most of existing modules.

Implemented in 2066368


Prevent inputs ending up off screen or obscured by keyboards when linking from the error summary to inputs within a large fieldset

Only scroll from error summary to legend if the input is a radio or checkbox, or the input would end up in the top half of the screen.
This is to prevent linking to inputs which then end up either off the bottom of the screen or obscured by a software keyboard.
Fixes #1544

For reference there's also 'IntersectionObservers' which have concepts of thresholds, I bit overkill for this I think since we're only doing it once per link click but worth sharing: https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API

@nickcolley happy with this changelog entry?

@36degrees 👍 looks peng mate


feat: add support for browser-based theme config file (docusaurus.theme.js)

Motivation
Add support for a new browser docusaurus.theme.tsx file to declare the Docusaurus theme config.
Using a browser-based file unlocks many other features, including the ability to pass unserializable data such as React components and callbacks.
Some features it unlocks, or improves the DX:

https://github.com/facebook/docusaurus/issues/7227
https://github.com/facebook/docusaurus/issues/4389
https://github.com/facebook/docusaurus/issues/2968
https://github.com/facebook/docusaurus/issues/4542
https://github.com/facebook/docusaurus/issues/9611

This feature is designed to be v3 retro-compatible and easy to adopt incrementally. The new theme config gets merged into the old serialized siteConfig.themeConfig and it's possible to slowly migrate your theme config to the new file.
Test Plan
unit tests + dogfood + preview
Test links
https://deploy-preview-9619--docusaurus-2.netlify.app/

I'm not sure if this is the right design, but I also don't know if I have much to say.
We have always said "all config files you write are server-side; client-side customizations are to be done through swizzling and custom CSS". And indeed, I don't see how announcement/footer items can't be done through safe swizzling. This just seems like one extra way to do things.

Here this is not only theme customizations but also theme extensions. You shouldn't need to swizzle to provide custom mdx components, navbar items, or simply use callbacks to enable/disable navbar items.
Too often we encounter limits due to unserializable configs.
Swizzle remains the way to customize existing theme components, but here the goal is not really to customize existing components.
This design is already widely used by other tools, for example: https://nextra.site/docs/docs-theme/theme-configuration

Okay, fair enough. One or two years ago, our plan was still to provide "dummy components" that one could swizzle and inject additional logic, but maybe this is fine too.


No podspec found for mark922_flutter_lottie in .symlinks/plugins/mark922_flutter_lottie/ios

mark922_flutter_lottie: ^0.2.1
ERR0R on ios

 -> Fetching podspec for `mark922_flutter_lottie` from `.symlinks/plugins/mark922_flutter_lottie/ios`
    [!] No podspec found for `mark922_flutter_lottie` in `.symlinks/plugins/mark922_flutter_lottie/ios`

..........

Finished with error: Error running pod install

Hey @CameronStuartSmith and @kaina404
This problem is happening here too and the reason for that is the plugin name. When you add the plugin in the Flutter project, it has the mark922_flutter_lottie name. Then, when you try to build the iOS project, Flutter looks for the .podspec of the Plugin inside the following path: flutter/.pub-cache/hosted/pub.dartlang.org/mark922_flutter_lottie-0.2.1/ios. If you check, the .podspec is there but with a different name, thus Flutter is not able to find the file and this error is thrown.
Follow the steps to fix:

Change the .podspec name in the path above to mark922_flutter_lottie.podspec
Inside the .podspec, change the s.name value to mark922_flutter_lottie
In the same path, open Classes/FlutterLottiePlugin.m and change the second import:
From:

#import "FlutterLottiePlugin.h"
#import <flutter_lottie/flutter_lottie-Swift.h>

To:
#import "FlutterLottiePlugin.h"
#import <mark922_flutter_lottie/mark922_flutter_lottie-Swift.h>

4. Have fun using Lottie for iOS

@arctouch-matheusromao Repo updated.


allRowsAlignment value confusion (raise an assertion when it shouldn't)

I'm trying to follow the example for creating a PDFTable so
I'm creating the table with the needed size
var table = PDFTable(rows: 3, columns: 4)
setting the content
table.content = data //an array matching the size provided earlier
Setting the alignments
table.rows.allRowsAlignment = [.left, .left, .left, .right]
An assertion is raised and in prod. an exception with a crash
it says "Can not access more rows than available"
now my expectation from the last line is that I'm getting the rows and I'm setting the alignment to each cell in that each row
so the count of the alignments array should match the columns count
in my case this correct the alignments array matches the columns count (still an error)
I looked at the code behind that setter (which might be better as a function since it doesn't have a getter) and it says newValue.count <= rows.count which make me feel that my understanding might be wrong because it's checking the count of the rows instead of the columns (or the rows cells)
Could you please confirm if this is a bug or try to explain how this works if it's not
thank you in advance
TPPDF Version used 2.3.0

Hi there, this looks like a copy-paste bug on my side.
I created a branch 233-fix-all-rows-alignment for the WIP. Maybe you can take a closer look.
About changing it to a function: When I created this interface, I wanted a universal access using subscripts or close to subscripts = setters. Now, I think this would probably be smarter, as we could use more verbose names, rather than allRowsAlignment.
I am open for recommendations, but unfortunately I am currently having busy times therefore I can't work on it too much, PR's are welcome

I merged the progress for now, so the assertion errors don't occur anymore.
I guess we should improve the subscript methods maybe even replace them with methods at some point, at least for now I won't follow it, but feel free to create a PR/text how we could optimize them (in a new issue please).
Thanks


Wrong exception when input string ends without completing JSON

If the input string is
{"hello":"worl

an IndexOutOfRangeException is thrown. This should be anticipated and translated to a JsonSyntaxException.

This is resolved as of v3.2.1


Support for GoIsilon v1.1.0

This patch adds support for the GoIsilon v1.1.0 release, enabling support for custom volume paths and enhanced NFS export security settings.
Note: This update does break backwards compatibility for the Isilon driver's volumePath configuration key. This key's value used to be appended to the base path /ifs/volumes, but that's no longer the case. The value of the volumePath key is now considered to be absolute. If it is not provided or empty, the value /ifs/volumes will be used. But if a value is specified for the key, that is the value used for the volume path, sans any prefix.
Related to #244, #245, #246.

Current coverage is 26.04% (diff: 100%)

Merging #250 into master will not change coverage

@@             master       #250   diff @@
==========================================
  Files            39         39
  Lines          2419       2419
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            630        630
  Misses         1721       1721
  Partials         68         68

Powered by Codecov. Last update 3daf75b...f13e8f9

Replaced with #252


Document additional bugfix in 2.4.0

Support for spaces in attribute selector values was added in 2.4.0 (PR #427) but was not documented in the changelog.  It took me a while to sort out why my selectors option[value="by Alice"] were working in 2.4.1 but not 2.3.0 (see my gradual realization here).  I'm recommending this get added to the changelog to save others some time.

lgtm

Thanks!


Rest swagger specification : meta information

There are fields in the swagger file to mention the license, contacts and terms of service. Should we put something in these ? (and what ?)

I don't mind the license as long as it is one of the main open source ones. Unless someone has an issue, I suggest GPL 3. We could create a CARMIN google group for contact information.

Personally, I am in favor of a more permissive license. For instance LGPL
or MIT. In Python, it is an options to directly embedd the Swagger YAML in
a web server source code in order to automatically generate dynamically a
part of the web services (e.g. URL routes). If the API is GPL, I believe
the whole server will have to be GPL :(

MIT is fine with me.

This was already implemented.


Log-in forbidden when username contains non alphanumeric chars.

For users where username is an e.mail the validation of the username on the login from prevents logging in completely because the username contains '@' and '.'

I'm not sure what are the actual validation requirements re the username. ATM they seem to restrict usernames to 'lowercase', 'letters and numbers' and '4-30 in length'.

Maybe a whitelist of accepted characters should be used.

I don't think DockerHub allows email for username? your username should be whatever you used for DockerHub.

Then I think the error is on dockerhub. I just logged in using both<EMAIL_ADDRESS>and "username". Thanks for the quick response.

username is the preferred way - Interesting that DockerHub allows you to login with both.


Http2 keywords v4

Replaces #383 with added check for http.stat_msg keyword
needs next version of OISF/suricata#5668

Can you do a new version of this that works on all branches now that https://github.com/OISF/suricata/pull/5875 is merged? It seem the alert http1 rule file additions cause the failures.

Replaced by https://github.com/OISF/suricata-verify/pull/452
I think alert http1 should indeed fail for versions 6... let's check


Fix Wording in HTML Template (Incorrect English)

HtmlTestRunner version: 1.1.2
Python version: 3.6.2
Operating System: macOS High Sierra (v10.13.3)

Description
Change the wording in the HTML template from "Total Test Runned" to "Total Tests Run".
What I Did
Installed HtmlTestRunner and ran the example from the docs.

thanks


Load double tests to create a task

To create a task, Classroom load tests again and again.
It is necessary to empty input always that load modal to create task.

https://github.com/euodeionomedeusuario/classroom/commit/402c3a6fc57879abe129069de1cc8e4974d510af


[SPARK-40445][PS] Refactor Resampler for consistency and simplicity

What changes were proposed in this pull request?
Refactor Resampler to make it consistent with GroupBy
Why are the changes needed?
for consistency (more like GroupBy) and simplicity
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing UT

cc @HyukjinKwon

Merged into master, thank you @itholic @HyukjinKwon