pydantic_core._pydantic_core.ValidationError: 1 validation error for typed-dict embeddings.llm.api_version

Describe the bug
🚀 Reading settings from ragtest\settings.yaml
Traceback (most recent call last):
  File "C:\python-3.10.11\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\python-3.10.11\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\repos\graphrag\myenv\lib\site-packages\graphrag\index\__main__.py", line 68, in <module>
    index_cli(
  File "C:\repos\graphrag\myenv\lib\site-packages\graphrag\index\cli.py", line 92, in index_cli
    pipeline_config: str | PipelineConfig = config or _create_default_config(
  File "C:\repos\graphrag\myenv\lib\site-packages\graphrag\index\cli.py", line 222, in _create_default_config
    parameters = _read_config_parameters(root, reporter)
  File "C:\repos\graphrag\myenv\lib\site-packages\graphrag\index\cli.py", line 253, in _read_config_parameters
    return create_graphrag_config(data, root)
  File "C:\repos\graphrag\myenv\lib\site-packages\graphrag\config\create_graphrag_config.py", line 70, in
create_graphrag_config
    InputModelValidator.validate_python(values, strict=True)
  File "C:\repos\graphrag\myenv\lib\site-packages\pydantic\type_adapter.py", line 142, in wrapped
    return func(self, *args, **kwargs)
  File "C:\repos\graphrag\myenv\lib\site-packages\pydantic\type_adapter.py", line 373, in validate_python
    return self.validator.validate_python(object, strict=strict, from_attributes=from_attributes,
context=context)
pydantic_core._pydantic_core.ValidationError: 1 validation error for typed-dict
embeddings.llm.api_version
  Input should be a valid string [type=string_type, input_value=datetime.date(2024, 5, 13), input_type=date]
    For further information visit https://errors.pydantic.dev/2.8/v/string_type
⠋ GraphRAG Indexer

Steps to reproduce
Here is my settings.yaml file

encoding_model: cl100k_base
skip_workflows: []
llm:
  api_key: ${GRAPHRAG_API_KEY}
  type: openai_chat # or azure_openai_chat
  model: gpt-4-turbo-preview
  model_supports_json: true # recommended if this is available for your model.
  # max_tokens: 4000
  # request_timeout: 180.0
  # api_base: https://<instance>.openai.azure.com
  # api_version: 2024-02-15-preview
  # organization: <organization_id>
  # deployment_name: <azure_model_deployment_name>
  # tokens_per_minute: 150_000 # set a leaky bucket throttle
  # requests_per_minute: 10_000 # set a leaky bucket throttle
  # max_retries: 10
  # max_retry_wait: 10.0
  # sleep_on_rate_limit_recommendation: true # whether to sleep when azure suggests wait-times
  # concurrent_requests: 25 # the number of parallel inflight requests that may be made

parallelization:
  stagger: 0.3
  # num_threads: 50 # the number of threads to use for parallel processing

async_mode: threaded # or asyncio

embeddings:
  ## parallelization: override the global parallelization settings for embeddings
  async_mode: threaded # or asyncio
  llm:
    api_key: ${GRAPHRAG_API_KEY}
    type: azure_openai_chat
    model: gpt-4o
    api_base: https://souradip123.openai.azure.com/
    api_version: 2024-05-13
    # organization: <organization_id>
    deployment_name: demotrial
    # tokens_per_minute: 150_000 # set a leaky bucket throttle
    # requests_per_minute: 10_000 # set a leaky bucket throttle
    # max_retries: 10
    # max_retry_wait: 10.0
    # sleep_on_rate_limit_recommendation: true # whether to sleep when azure suggests wait-times
    # concurrent_requests: 25 # the number of parallel inflight requests that may be made
    # batch_size: 16 # the number of documents to send in a single request
    # batch_max_tokens: 8191 # the maximum number of tokens to send in a single request
    # target: required # or optional

chunks:
  size: 300
  overlap: 100
  group_by_columns: [id] # by default, we don't allow chunks to cross documents

input:
  type: file # or blob
  file_type: text # or csv
  base_dir: "input"
  file_encoding: utf-8
  file_pattern: ".*\\.txt$"

cache:
  type: file # or blob
  base_dir: "cache"
  # connection_string: <azure_blob_storage_connection_string>
  # container_name: <azure_blob_storage_container_name>

storage:
  type: file # or blob
  base_dir: "output/${timestamp}/artifacts"
  # connection_string: <azure_blob_storage_connection_string>
  # container_name: <azure_blob_storage_container_name>

reporting:
  type: file # or console, blob
  base_dir: "output/${timestamp}/reports"
  # connection_string: <azure_blob_storage_connection_string>
  # container_name: <azure_blob_storage_container_name>

entity_extraction:
  ## llm: override the global llm settings for this task
  ## parallelization: override the global parallelization settings for this task
  ## async_mode: override the global async_mode settings for this task
  prompt: "prompts/entity_extraction.txt"
  entity_types: [organization,person,geo,event]
  max_gleanings: 0

summarize_descriptions:
  ## llm: override the global llm settings for this task
  ## parallelization: override the global parallelization settings for this task
  ## async_mode: override the global async_mode settings for this task
  prompt: "prompts/summarize_descriptions.txt"
  max_length: 500

claim_extraction:
  ## llm: override the global llm settings for this task
  ## parallelization: override the global parallelization settings for this task
  ## async_mode: override the global async_mode settings for this task
  # enabled: true
  prompt: "prompts/claim_extraction.txt"
  description: "Any claims or facts that could be relevant to information discovery."
  max_gleanings: 0

community_report:
  ## llm: override the global llm settings for this task
  ## parallelization: override the global parallelization settings for this task
  ## async_mode: override the global async_mode settings for this task
  prompt: "prompts/community_report.txt"
  max_length: 2000
  max_input_length: 8000

cluster_graph:
  max_cluster_size: 10

embed_graph:
  enabled: false # if true, will generate node2vec embeddings for nodes
  # num_walks: 10
  # walk_length: 40
  # window_size: 2
  # iterations: 3
  # random_seed: 597832

umap:
  enabled: false # if true, will generate UMAP embeddings for nodes

snapshots:
  graphml: false
  raw_entities: false
  top_level_nodes: false

local_search:
  # text_unit_prop: 0.5
  # community_prop: 0.1
  # conversation_history_max_turns: 5
  # top_k_mapped_entities: 10
  # top_k_relationships: 10
  # max_tokens: 12000

global_search:
  # max_tokens: 12000
  # data_max_tokens: 12000
  # map_max_tokens: 1000
  # reduce_max_tokens: 2000
  # concurrency: 32

and my  .env contains
GRAPHRAG_API_BASE=Azure_openai_endpoint
GRAPHRAG_API_VERSION=2024-05-13
GRAPHRAG_API_KEY='AZURE OPEN AI KEY'

Hi @Souradip121
The lib is pulling this value GRAPHRAG_API_VERSION=2024-05-13 and when parsing the API version it is interpreting it as a date.
Can you please try surrounding it by quotes? like GRAPHRAG_API_VERSION="2024-05-13"

raise ValueError("Columns must be same length as key")\nValueError: Columns must be same length as key\n", "source": "Columns must be same length as key", "details": null}
Now I am getting this error

Here are my deployment details

Can you please share your logs?
Also, check the entity extraction cache, it can be related to faulty entity extraction, resulting in an empty graph.


can't train because torch incompatible with python version

/home/france1/.local/lib/python3.9/site-packages/torch/distributed/launch.py:178: FutureWarning: The module torch.distributed.launch is deprecated
and will be removed in future. Use torch.distributed.run.
Note that --use_env is set by default in torch.distributed.run.
If your script expects `--local_rank` argument to be set, please
change it to read from `os.environ['LOCAL_RANK']` instead. See
https://pytorch.org/docs/stable/distributed.html#launch-utility for
further instructions

  warnings.warn(
WARNING:torch.distributed.run:*****************************************
Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.
*****************************************
Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/france1/arXiv2020-RIFE/train.py", line 140, in <module>
Traceback (most recent call last):
  File "/home/france1/arXiv2020-RIFE/train.py", line 140, in <module>
  File "/home/france1/arXiv2020-RIFE/train.py", line 140, in <module>
    torch.cuda.set_device(args.local_rank)
  File "/home/france1/.local/lib/python3.9/site-packages/torch/cuda/__init__.py", line 264, in set_device
    torch.cuda.set_device(args.local_rank)
  File "/home/france1/.local/lib/python3.9/site-packages/torch/cuda/__init__.py", line 264, in set_device
    torch.cuda.set_device(args.local_rank)
  File "/home/france1/.local/lib/python3.9/site-packages/torch/cuda/__init__.py", line 264, in set_device
    torch._C._cuda_setDevice(device)
    RuntimeErrortorch._C._cuda_setDevice(device):
CUDA error: invalid device ordinal
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
RuntimeError: CUDA error: invalid device ordinal
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
    torch._C._cuda_setDevice(device)
RuntimeError: CUDA error: invalid device ordinal
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 1 (pid: 651166) of binary: /usr/bin/python3
Traceback (most recent call last):
  File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/france1/.local/lib/python3.9/site-packages/torch/distributed/launch.py", line 193, in <module>
    main()
  File "/home/france1/.local/lib/python3.9/site-packages/torch/distributed/launch.py", line 189, in main
    launch(args)
  File "/home/france1/.local/lib/python3.9/site-packages/torch/distributed/launch.py", line 174, in launch
    run(args)
  File "/home/france1/.local/lib/python3.9/site-packages/torch/distributed/run.py", line 689, in run
    elastic_launch(
  File "/home/france1/.local/lib/python3.9/site-packages/torch/distributed/launcher/api.py", line 116, in __call__
    return launch_agent(self._config, self._entrypoint, list(args))
  File "/home/france1/.local/lib/python3.9/site-packages/torch/distributed/launcher/api.py", line 244, in launch_agent
    raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
***************************************
            train.py FAILED
=======================================
Root Cause:
[0]:
  time: 2021-09-30_17:35:27
  rank: 1 (local_rank: 1)
  exitcode: 1 (pid: 651166)
  error_file: <N/A>
  msg: "Process failed with exitcode 1"
=======================================
Other Failures:
[1]:
  time: 2021-09-30_17:35:27
  rank: 2 (local_rank: 2)
  exitcode: 1 (pid: 651167)
  error_file: <N/A>
  msg: "Process failed with exitcode 1"
[2]:
  time: 2021-09-30_17:35:27
  rank: 3 (local_rank: 3)
  exitcode: 1 (pid: 651168)
  error_file: <N/A>
  msg: "Process failed with exitcode 1"
***************************************

   ~  python -m torch.device("cuda")                                                                                 1 ✘
zsh: number expected
   ~ 

It seems that the latest version of torch is not compatible with the old version of the launcher. Would you mind using torch between 1.3 and 1.8 to try again?

Well, wich version do i have?
If you could explain how I can install it, yes
A problem is that the modules aren't in the requirements... Could you add them to the list or... whatever

@debian-user-france1
I modified requirement.txt, please see https://github.com/hzwer/arXiv2020-RIFE/blob/main/requirements.txt
You can use this command:
pip3 install torch==1.6.0 torchvision==0.7.0

@debian-user-france1 You may use pip with too old version. Please try:
python3 -m pip install --upgrade pip

There was no message that pip is outdated

I tried to upgrade pip but it was already the newest version...
If we look at that:
ERROR: Could not find a version that satisfies the requirement torch==1.6.0 (**from versions: 0.1.2, 0.1.2.post1, 0.1.2.post2, 1.7.1, 1.8.0, 1.8.1, 1.9.0, 1.9.1**)
We see wich versions are compatible with Python 3.9.7

@debian-user-france1 You may try 1.7.1. I hope it will work.
pip3 install torch==1.7.1

did u find solution for this issue ? FutureWarning: The module torch.distributed.launch is deprecated
and will be removed in future. Use torchrun.
Note that --use-env is set by default in torchrun.
If your script expects --local-rank argument to be set, please
change it to read from os.environ['LOCAL_RANK'] instead. See
https://pytorch.org/docs/stable/distributed.html#launch-utility for
further instructions
warnings.warn(
usage: train.py [-h] [--cfg CFG_FILE] [--num_workers NUM_WORKERS] [--stamp STAMP] [--imsize IMSIZE] [--batch_size BATCH_SIZE]
[--train TRAIN] [--resume_epoch RESUME_EPOCH] [--resume_model_path RESUME_MODEL_PATH]
[--multi_gpus MULTI_GPUS] [--gpu_id GPU_ID] [--random_sample]
train.py: error: unrecognized arguments: --local-rank=0
[2023-11-03 12:23:37,197] torch.distributed.elastic.multiprocessing.api: [ERROR] failed (exitcode: 2) local_rank: 0 (pid: 1206070) of binary:
in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
src/train.py FAILED
Failures:
<NO_OTHER_FAILURES>
Root Cause (first observed failure):
[0]:
time      : 2023-11-03_12:23:37
host      : jupitor
rank      : 0 (local_rank: 0)
exitcode  : 2 (pid: 1206070)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html


window.cancelAnimationFrame is not a function

I was testing nuxt with jsdom and it does not work anymore because of vue-meta and it's use of requestAnimationFrame, futhermore it is not supporter in IE < 10
What do you think to polyfill it with https://www.npmjs.com/package/raf?

But this will do the work as well: https://gist.github.com/paulirish/1579671

@Atinux aware of the issue - I'm not keen on including an entire polyfill just for the sake of a utility function. Polyfills belong in user-land - what if my polyfill overwrites another polyfill in some other random library being used on the same webpage? Things would break.
I am happy however to just fallback on setTimeout:
// uncomment this to see that it still works
// window.cancelAnimationFrame = undefined
// window.requestAnimationFrame = undefined

const stopUpdate = window.cancelAnimationFrame || window.clearTimeout
const startUpdate = window.requestAnimationFrame || ((cb) => window.setTimeout(cb, 0))

function batchUpdate (id, callback) {
  stopUpdate(id)
  return startUpdate(() => {
    id = null
    callback()
  })
}

var id = null
var i = 0
var len = 100

for (; i < len; i++) {
  id = batchUpdate(id, () => {
    console.log('foo')
  })
}

// "foo" is logged once

I will be back in full force on this tomorrow - I know I said today, but I've been experiencing downtime on many sites here in SA, Github included

It's even better to fallback with setTimeout 👍🏻


Add plotting of time series

Add a Plot1D function using the Plots package or the Makie one

on-going development on the branch 'draft' (see Plot1D function)

to do:

give x-y coordinates of a node
test node number validity


Byte modified optimization

My usage included very large lists of byte modified which reduced performance and made the program VERY slow.
So I made the following changes to improve that. Reducing the number of loops and nested loops to minimum.

Thank for support project

Please check, your update are not support ByteDeleted ;)


Replace damping field with subdomain support for BC's in examples and tutorials

Supersedes issue #231

Duplicate of #606


[3.2.3] Compiling for Mono iOS is giving a lot of errors on XCode

Godot version:
3.2.3 stable_mono_osx
OS/device including version:
MacOS Catalina 10.15.7
Xcode 12.3 beta
Mono <IP_ADDRESS> (latest from brew install)
Issue description:
I created a workflow in my GitHub repository that compiles a module for AdMob, there are two workflows, they compile and send the compiled files to a new tag, one is for the stable version and the other is for mono stable.
Both are working perfectly, the problem is that when you change the original files to those compiled files only in the mono version those errors appears:

this error does not happen just as I put the module I created to compile, it also happens when I do it without the module, which makes me think I am doing some wrong step.
Steps to reproduce:

Clone mono version <IP_ADDRESS> git clone --branch mono-<IP_ADDRESS> https://github.com/mono/mono.git
Install dependencies brew install autoconf automake libtool
Clone master godot-mono-builds git clone https://github.com/godotengine/godot-mono-builds.git
Building mono for iOS, COMMANDS
Download and unzip stable Godot version source code https://github.com/godotengine/godot/archive/3.2.3-stable.zip
Import necessary certificates for NuGet, COMMANDS

(NOW THE PART THAT I THINK IAM MISSING SOMETHING)

Compiling the source code: COMMANDS

        scons p=osx tools=yes module_mono_enabled=yes mono_glue=no mono_prefix="/Library/Frameworks/Mono.framework/Versions/Current"

        ./bin/godot.osx.tools.64.mono --generate-mono-glue modules/mono/glue

        scons p=iphone tools=no target=release arch=arm module_mono_enabled=yes mono_glue=yes mono_prefix="$HOME/mono-installs/ios-arm64-release"
        scons p=iphone tools=no target=release arch=arm64 module_mono_enabled=yes mono_glue=yes mono_prefix="$HOME/mono-installs/ios-arm64-release"
        lipo -create bin/libgodot.iphone.opt.arm.a bin/libgodot.iphone.opt.arm64.a -output bin/libgodot.iphone.release.fat.a
        mkdir -p bin/ios
        mkdir -p bin/ios/iphone-mono-libs
        # The Mono libraries for the interpreter are not available for simulator builds
        lipo -create bin/libmono-ee-interp.iphone.arm64.a -output bin/ios/iphone-mono-libs/libmono-ee-interp.iphone.fat.a
        lipo -create bin/libmono-icall-table.iphone.arm64.a -output bin/ios/iphone-mono-libs/libmono-icall-table.iphone.fat.a
        lipo -create bin/libmono-ilgen.iphone.arm64.a -output bin/ios/iphone-mono-libs/libmono-ilgen.iphone.fat.a

Export the Game project to iOS on Godot
Change the compiled libgodot.iphone.release.fat.a to your_project_name.a
Replace all '.a' to the compiled:

libmono-native.iphone.arm64.a
libmonosgen-2.0.iphone.arm64.a

libmono-ilgen.iphone.fat.a
libmono-ee-interp.iphone.fat.a
libmono-icall-table.iphone.fat.a

Except this: libmonoprofiler-log.iphone.arm64.a, due wasnt found on exported project
Minimal reproduction project:
You can try use this project: https://github.com/Poing-Studios/Godot-AdMob-Android-iOS/tree/master/example

If theres something unclear please let me know, but I think that's it, thank you.

lipo -create bin/libmono-ee-interp.iphone.arm64.a -output bin/ios/iphone-mono-libs/libmono-ee-interp.iphone.fat.a
lipo -create bin/libmono-icall-table.iphone.arm64.a -output bin/ios/iphone-mono-libs/libmono-icall-table.iphone.fat.a
lipo -create bin/libmono-ilgen.iphone.arm64.a -output bin/ios/iphone-mono-libs/libmono-ilgen.iphone.fat.a

Missing 32-bit .arm libs for the mono libs.

scons p=iphone tools=no target=release arch=arm module_mono_enabled=yes mono_glue=yes mono_prefix="$HOME/mono-installs/ios-arm64-release"

If it's 64-bit mono, it's probably won't work with 32-bit build.
Last 32-bit iOS device was iPhone 5, there's not many reasons to support it at all. Just use 64-bit libs only without lipo and arch=arm build.
Also, official builds have mono_static=yes in the scons build command.

@bruvzg , i updated the workflow as you said, but the error continues:

These was the changes:
        scons p=osx tools=yes mono_static=yes module_mono_enabled=yes mono_glue=no mono_prefix="/Library/Frameworks/Mono.framework/Versions/Current"

        ./bin/godot.osx.tools.64.mono --generate-mono-glue modules/mono/glue

        scons p=iphone tools=no mono_static=yes target=release arch=arm64 module_mono_enabled=yes mono_glue=yes mono_prefix="$HOME/mono-installs/ios-arm64-release"
        mkdir -p bin/ios
        mkdir -p bin/ios/iphone-mono-libs
        # The Mono libraries for the interpreter are not available for simulator builds
        lipo -create bin/libmono-ee-interp.iphone.arm64.a -output bin/ios/iphone-mono-libs/libmono-ee-interp.iphone.fat.a
        lipo -create bin/libmono-icall-table.iphone.arm64.a -output bin/ios/iphone-mono-libs/libmono-icall-table.iphone.fat.a
        lipo -create bin/libmono-ilgen.iphone.arm64.a -output bin/ios/iphone-mono-libs/libmono-ilgen.iphone.fat.a

I also replaced the .a files because i want to compile the AdMob to iOS, but i dont know for sure if i need to replace all these .a files. I knot 100% of sure i need to replace libgodot.iphone.release.fat.a to your_project_name.a

Do you build Mono and Godot from source? If so you can try with this branch. You may also need these two PRs: https://github.com/godotengine/godot-mono-builds/pull/40, https://github.com/godotengine/godot-mono-builds/pull/39

@neikeq hey! I will test this on this weekend, thank you


Document confusion fix in MinConcurrentDecisionTaskPollers

What changed?
Have changed the description of MinConcurrentDecisionTaskPollers.

Why?
It was confusing to understand.

How did you test it?
Just a documentation change

Potential risks
None

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.MrBoss276 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Episode idea: 延时队列的设计和实现

Describe a topic you want to learn (required)
Pulsar中延时队列是如何设计和实现的。
Why do you want to learn this topic? (required)
Pulsar中延时队列是如何设计和实现的。适用于那些场景，不适用于那些场景。精度和异常场景的可靠性是如何保证的
Reference (optional)

@Shoothzj Here is the TGIP-CN registration page: https://www.slidestalk.com/m/333. Welcome to join us.

Thanks, Expecting


Utilize oneof in the protobuf

Due to historical reasons, we are implementing our own oneof in coprocessor. For example, the coprocessor::Request protobuf message contains a data: Vec<u8>, which is the serialized message data for different kind of requests.
By using oneof, we can avoid deserialize two times (1 for message in Request and 1 for message in Request.data), which can eliminate memory copies and make code simpler.
Note:

To complete this task, you need to update TiDB as well.
Because this is a breaking change, we may not merge the PR immediately. Instead it may be deferred to our 3.0 release.

/cc @coocood PTAL

... two times ...

Actually it's either deserialized by the library or by ourself.

@BusyJay Yes, I mean, there is extra byte copies.

Considering our protocol changing a schema cost too much, while advantage is only cleaner code base. Close it for now.


MB-8148 Show roles not deleted

Description
This PR fixes a bug that the soft deleted roles were being populated in the session. The soft deleted roles don't show anymore after logging out and back in.
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?

Caveat is that the deleted roles will still be in the session while the user is still logged in. After logging out and back in, the user roles will be properly populated.
The model Role being used in the User model is actually suppose to use UsersRoles. Role is meant to reference the actual roles we have that exists while the UsersRoles references what roles the user is tied to. I'll make a new story to capture this.

Setup
Add any steps or code to run in this section to help others prepare to run your code:
make db_dev_e2e_populate
make server_run
make office_client_run

Test with local sign-in (works with Login.gov too!)

Open up both the office app and admin app in separate tabs

Office app (http://officelocal:3000)

In the office app, log in as a multi-role user<EMAIL_ADDRESS>Click Change user role link at the top left corner
Note the current roles: TOO, TIO, and Services Counselor

Admin app (http://adminlocal:3000)

Switch to the admin app and log in as the admin
Navigate to office users queue by clicking on the left tab Office Users
Search office user<EMAIL_ADDRESS>Click on user
Click Edit
De-select any user role that's checked

Office app (http://officelocal:3000)

Back to Office app tab
Log out
Log back in with same user
Click on Change user role and note the difference

Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-8148

  Generated by :no_entry_sign: dangerJS against eb88ad27b2a28b6818c783994e7eb5f9b97f97d0


VS 15.6.7 empty list in Test Explorer

Steps to Reproduce
Open tests project (.net 4.5 or .net 4.6.1) in Visual Studio Community 2017 Version 15.6.7
Fixie 1.0.3
Expected Behavior
tests are shown in list
Actual Behavior
tests aren't shown in list

Delete everything found within %TEMP%\VisualStudioTestExplorerExtensions resolved the issue
thanks


Use goroutines to get more than 6x the performance (M3 CPU)

By using goroutines, which is part of the Go syntax, I get a good speedup here.
New benchmark:
❯ hyperfine -w 1 -r 2 ./main
Benchmark 1: ./main
  Time (mean ± σ):     248.7 ms ±   2.8 ms    [User: 2773.8 ms, System: 7.2 ms]
  Range (min … max):   246.7 ms … 250.6 ms    2 runs

Previous benchmark:
❯ hyperfine -w 1 -r 2 ./main
Benchmark 1: ./main
  Time (mean ± σ):      1.655 s ±  0.014 s    [User: 1.644 s, System: 0.004 s]
  Range (min … max):    1.645 s …  1.665 s    2 runs

Thanks. It should be moved in this folder:
https://github.com/jabbalaci/SpeedTests/tree/master/_parallel

Thanks for reviewing and merging!

Thanks, it was added.


Ability to switch Tab's orientation based on tailwind resolution prefix

Description
It would be awesome if there was a way to change between horizontal and vertical orientation of the Tab component using tailwind's sm: md: lg:
Example:
<UTab orientation="vertical md:horizontal"></UTab>
Additional context
No response

I think the classes and styles of the orientations would need to be applied differently, but sounds like a cool concept.
The component uses useResizeObserver to resize the marker. Maybe something simillar would be sufficient to change orientation: https://stackblitz.com/edit/nuxt-starter-ry3twf?file=app.vue

The only way for now to achieve this would be to use https://vueuse.org/core/useBreakpoints/#usebreakpoints and pass a ref to orientation prop.


Blind Search

Hi @achantavy, I have finally configured cartography and got access to the my clouds graph.
I have seen you create an index per label mainly on the id fields.
I am trying to query the graph using a blind search, for example:
MATCH (n) WHERE ANY(x in keys(n) WHERE n[x] =~ '(i?){some expression goes here}*') RETURN n
Meaning that given a word/expression, I want to go over all nodes and relations and their properties and if I find my pattern, return the relevant subgraph.
Is there any best practice doing it?

I have finally configured cartography and got access to the my clouds graph.
I have seen you create an index per label mainly on the id fields.

Awesome!

Meaning that given a word/expression, I want to go over all nodes and relations and their properties and if I find my pattern, return the relevant subgraph. Is there any best practice doing it?

I'd recommend against doing a query that doesn't have labels because if you have a large enough graph (as low as more than ~100k nodes), queries will run extremely slowly. For best performance, it's best to query with node label + an indexed field (although if the field is not indexed you'll probably be okay unless your graph is like in the millions and you have a special use case).

I totally understand your point @achantavy, but what if I don't know the parameter? I am looking for some expression/pattern and my user doens't really know what is the label and parameter. What would be the best practice in such case from your experience?

Since your query example is a regular expression, I'm assuming you're wishing to match against strings only.
This could possibly be a use case for Neo4J full-text search (FTS). I have not touched Neo4J FTS in some time, but it looks to be better supported now and easier to set up and use. Take a look at the documentation: https://neo4j.com/docs/cypher-manual/current/indexes-for-full-text-search/
IIRC, the biggest issue I had with Neo4J FTS is that it created a very large index that bloated the database size substantially. I do not know the performance implications of adding/removing nodes that are related to an FTS index. It could be that a CREATE or DELETE executes more slowly when part of an FTS index.

@trodery thanks for your answer, did you manage to find a best practice how to use it? Can you please share an example?


Lora Info dialog does not work with read-only data stores

When the storage that the Lora is on is read-only (in my case, a read-only NFS share), rgthree will just stay at 'Loading..' indefinitely.
I am guessing this is because it can't create the cache file,but this shouldn't be required for it to function (if the cache cannot be used, it should just generate the data every time). In theory, this would also be seen on any Loras with a filename that is close to the filesystem limit (which I also have) as creating the cache file would fail due to the cache filename being longer, but I haven't tested this explicitly.

Not ignoring this, it's an interesting case. Right now rgthree-comfy makes extensive use of the filesystem to both store the data, but also cache things like the civitai info responses, etc. While I could store it all in memory for the session, that seems less than ideal.
I could probably allow the user to specify where the info is stored, allowing to chose a writable destination...


How to test models without json?

I want to create structs with default constructor in tests, without creating testing json files. Can I do that? Or if I implement Unboxable protocol, I can use only init(unboxer: Unboxer) constructor?

Sure, all you have to do to make the default constructor still generated by Swift is to implement Unboxable in an extension, like this:
struct User {
    var name: String
    var age: Int
}

extension User: Unboxable {
    init(unboxer: Unboxer) {
        self.name = unboxer.unbox("name")
        self.age = unboxer.unbox("age")
    }
}

Awesome! Thanks!


404 at /desktop/windows/instally/

I found a broken link : https://docs.docker.com/desktop/windows/instally/

@Dehget, thanks for sharing the issue. Where did you find this link?
The information you're probably looking for is here, https://docs.docker.com/desktop/install/windows-install/

Closing as stale.


Standard Realm Workflow Tool

MVP AC

Real T&C's
IDIR/Github only
Landing Page (Minimum content)
* Needs design complete
* Needs implementation
Support page

Links to online content only

Admin Notifications (Github)
Customer Notifications - Decision point: no customer notifications in MVP -- just a dialog when they submit telling them to come back.

Update public-facing documention

Give customer a choice on confidential or public client

ISSUE (Resolved)
Do customers need to be notified that their request is complete/approved?
OPTIONS:

Build email notification capability
Manually send email copying email address from somewhere?
This one -> In context information explaining they need to check back periodically

Next Release

Notification Slide-Out
Support page

Form

addressed in MVP released in September 2021


Changes to enable messages api requests & number insight

In send_message if a message api body is found in params the messages api request is performed instead of the sms api
Adding the async request when callback is detected for number insight. (enabling newly merged number insight code snippets to work)
Adding create, check and get report methods.

Coverage decreased (-2.3%) to 97.692% when pulling 058886edc74f97cb8a25b185a64a47a4212eee6f on superdiana:master into 9248fb40e15ed8107a9b506e669c033e1adf9ccf on Nexmo:master.

Could we remove the messages API code from this PR? We’re not ready to add it to the SDKs yet

Also a question from me about the reports API since that is also Beta at this point - should that be included?

Good spot! Reports shouldn't be in here either

Going to close this PR for now, as Messages isn't ready for GA or to go into the SDK at this point.


Fixed tag descriptions in samples

I believe the swagger-ui e2e tests are going to look for the text that used to be there (irrespective of order).  Can you please keep the same text values for now?

Then just don't merge or close it for now. The problem is that the descriptions are wrong and they look funny in the online petstore sample.
I can look into the swagger-ui e2e tests too, though it may be too late with the weekend release.

Just change the descriptions to what they should be, swapping the tag name so they're correct.  Push that and the PR should update.


Resolve postgres double free

PR Overview
Pin OpenSSL to avoid a bad interaction with PostgreSQL which was breaking the nightly builds.
PR Checklist

[ ] Merge the most recent version of the branch you are merging into (probably dev).
[ ] All CI checks are passing. Run tests locally to debug failures
[ ] Make sure you've included good docstrings.
[ ] For major data coverage & analysis changes, run data validation tests
[ ] Include unit tests for new functions and classes.
[ ] Defensive data quality/sanity checks in analyses & data processing functions.
[ ] Update the release notes and reference reference the PR and related issues.
[ ] Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

And why the heck is pip unable to install PUDL on RTD?
INFO: pip is looking at multiple versions of catalystcoop-pudl to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement openssl!=3.2.0,>=3.1.4 (from catalystcoop-pudl) (from versions: none)
ERROR: No matching distribution found for openssl!=3.2.0,>=3.1.4

Replaced by #3135


Conflate null and undefined

Like undefined, null should be treated as NULL.

Current coverage is 67.23% (diff: 100%)

Merging #750 into develop will increase coverage by 0.02%

@@            develop       #750   diff @@
==========================================
  Files             1          1
  Lines          9803       9803
  Methods        1029       1029
  Messages          0          0
  Branches       2926       2926
==========================================
+ Hits           6589       6591     +2
+ Misses         3214       3212     -2
  Partials          0          0

Powered by Codecov. Last update 22f6bcc...9fcfd3d

Thank you :)


Let the user resume a schema at the last page they where at

Description
In v3, the frontend was able to remember the last page that a user was on and send them there directly when resuming (when using the same browser). We would like this functionality in v4 as well since our surveys consist of many pages, and having to navigate, say 12 pages, already filled out is cumbersome.
I believe this worked for both our statefull and stateless apps.
I.e the user navigates to page 3, closes the browser, then later in the day resumes the schema in the same browser, the user would be sent directly to page 3.
Additional Information
No response

We need to decide on how we want to solve this. The functionality in v3 was sub-optimal, and it had multiple drawbacks:

It only works for the browser you used. Moving to fill out using another device leaves you stranded again.
Yes, it used to work for stateless apps as well. Traditional stateless apps will only keep the data model in-memory in the browser, so navigating you back to the same page you were on might break expectations again - if you refresh the page and see 'page 5' again, what you filled out in the previous 4 pages will now have been cleared. For apps such as brg/anonym-oppstartsveilederen you might end up the last page which was supposed to show you a conclusion, but all the data you filles in was lost. I suspect you are fetching the data model content from you own API in some way, thereby letting the user continue after refreshing?
The purpose of the functionality in v3 was to let you refresh the page without forgetting which page you were on. The reason we removed in in v4 was that the current page is now in the URL, so the browser will remember it that way.

One alternative suggestion might be to look at the current data model after loading the form and inform the user that they might want to jump straight to page 5 since data has been filled out up until that page. However, having that as a generic feature in our frontend might cause massive confusion for apps with prefills in their data models. Another option is having a functionality to store the last page the user was on in the data model and use that instead.


you killed my keys :(

I needed to reinstall the wireguard and without warning all the keys were demolished: ( This is bad!
At least about this you need to ask the user additionally.

then it still needs to be changed:
        source /etc/wireguard/params
        manageMenu
else
        installWireGuard
fi```

for example this:

`wg > /dev/null 2>&1 && source /etc/wireguard/params && manageMenu || installWireGuard`

then it still needs to be changed:
        source /etc/wireguard/params
        manageMenu
else
        installWireGuard
fi```

for example this:

`wg > /dev/null 2>&1 && source /etc/wireguard/params && manageMenu || installWireGuard`


deserialization perf improvement

I've done a deserialization perf benchmark with JMH and I've found that most of the time is consumed in LittleEndianInputStream#readUTF. With this PR, I notice a ~15% improvement.

Instead of creating a new decoder each time, cache & reuse in StaticBuffers (the main improvement)
There is always an underflow at the end of the decode. If len == 0, do not compact as it is not useful (and avoid a system array copy and a byte array allocation)
LittleEndianInputStream is only used in BsonParser, that is not thread safe. So it seems reasonable to cache StaticBuffer in the stream and avoid a ThreadLocal call for each string deserialization (except the first one).

HTH

Thanks for the PR. It looks very promising. I would like to make some experiments myself before merging it. I'll get back to you as soon as possible.

By the way, a 15% improvement is a lot. Do you have a test script or a test dataset, so I can probably reproduce the benchmark?

My benchmark targets KMongo :  CodecRegistryBenchmark & KMongoBenchmark, and is copied from Jongo benchmark
You can see in this first result that for "jacksonFriend" the score is 123775 (current bson4jackson version). With the patch, I get ~142000

Thanks for the test data. I made my own benchmarks (with your test data) and was able to achieve an improvement of at most 2%-3%. Sometimes I didn't see any improvement at all or it was within the error margin. This is probably due to the way we tested. I didn't use a benchmark framework - I just used a for loop and measured the ms elapsed.
Anyway, I'm still thinking about the implications of the change. Since you're caching StaticBuffers in LittleEndianInputStream, it may behave differently in a multi-threaded environment. In practise, this should not make a difference, since it's an internal class, but you never know who uses it where and for what purpose. So, I'm wondering if this is a breaking change and if it's worth the improvement (if there is any at all).
Here's my benchmark code so you can reproduce my tests:
@Test
public void parseFriend() throws Exception {
  long start = System.currentTimeMillis();
  for (int i = 0; i < 100000; i++) {
    ByteArrayInputStream bais = new ByteArrayInputStream(FRIEND_AS_BYTE);
    BsonFactory fac = new BsonFactory();
    ObjectMapper mapper = new ObjectMapper(fac);
    fac.setCodec(mapper);
    Map<?, ?> m = mapper.readValue(bais, Map.class);
  }
  System.out.println((System.currentTimeMillis() - start));

  start = System.currentTimeMillis();
  for (int i = 0; i < 100000; i++) {
    ByteArrayInputStream bais = new ByteArrayInputStream(FRIEND_AS_BYTE);
    BsonFactory fac = new BsonFactory();
    ObjectMapper mapper = new ObjectMapper(fac);
    fac.setCodec(mapper);
    Map<?, ?> m = mapper.readValue(bais, Map.class);
  }
  System.out.println((System.currentTimeMillis() - start));

  start = System.currentTimeMillis();
  for (int i = 0; i < 100000; i++) {
    ByteArrayInputStream bais = new ByteArrayInputStream(FRIEND_AS_BYTE);
    BsonFactory fac = new BsonFactory();
    ObjectMapper mapper = new ObjectMapper(fac);
    fac.setCodec(mapper);
    Map<?, ?> m = mapper.readValue(bais, Map.class);
  }
  System.out.println((System.currentTimeMillis() - start));

  start = System.currentTimeMillis();
  for (int i = 0; i < 100000; i++) {
    ByteArrayInputStream bais = new ByteArrayInputStream(FRIEND_AS_BYTE);
    BsonFactory fac = new BsonFactory();
    ObjectMapper mapper = new ObjectMapper(fac);
    fac.setCodec(mapper);
    Map<?, ?> m = mapper.readValue(bais, Map.class);
  }
  System.out.println((System.currentTimeMillis() - start));
}

Maybe I did something wrong and my tests are useless? :) Let me know, what you think.

I think there is an issue with your test. In a real app, you have usually only one ObjectMapper for the app as it is thread safe and costly to instantiate. Here, you measure more the ObjectMapper instantiation cost than the bson deserialization perf.
For my point of view, a more accurate test would look like this:
   @Test
    public void parseFriend() throws Exception {
        BsonFactory fac = new BsonFactory();
        ObjectMapper mapper = new ObjectMapper(fac);
        fac.setCodec(mapper);

        long start = System.currentTimeMillis();
        for (int i = 0; i < 1000000; i++) {
            ByteArrayInputStream bais = new ByteArrayInputStream(FRIEND_AS_BYTE);

            Map<?, ?> m = mapper.readValue(bais, Map.class);
        }
        System.out.println((System.currentTimeMillis() - start));

        start = System.currentTimeMillis();
        for (int i = 0; i < 1000000; i++) {
            ByteArrayInputStream bais = new ByteArrayInputStream(FRIEND_AS_BYTE);
            Map<?, ?> m = mapper.readValue(bais, Map.class);
        }
        System.out.println((System.currentTimeMillis() - start));

        start = System.currentTimeMillis();
        for (int i = 0; i < 1000000; i++) {
            ByteArrayInputStream bais = new ByteArrayInputStream(FRIEND_AS_BYTE);
            Map<?, ?> m = mapper.readValue(bais, Map.class);
        }
        System.out.println((System.currentTimeMillis() - start));

        start = System.currentTimeMillis();
        for (int i = 0; i < 1000000; i++) {
            ByteArrayInputStream bais = new ByteArrayInputStream(FRIEND_AS_BYTE);
            Map<?, ?> m = mapper.readValue(bais, Map.class);
        }
        System.out.println((System.currentTimeMillis() - start));
    }

And with this fixed test I get better results :)
Without the patch:
6745
5836
5792
5688
With the patch:
5506
4804
4847
4871
Let's me know if you get the same results

@michel-kraemer do you reproduce the perf improvement with the updated test? I plan to publish a benchmark soon and it would be great to have this improvement included (if you think it makes sense of course).

Yes, I was able to reproduce it, but as I said I'm still worried about the possible implications of caching StaticBuffers in LittleEndianInputStream.
I did some experiments and noticed that caching the CharsetDecoder matters the most. The other changes improve performance almost unnoticeable (if at all). So, I just pushed 32d2ab3. Please have a look at it.


taking rewriting rules seriously

one reason why arules was so slow is that act and rwrules are kept separately (which is also bad for cache locality in the long run). We might consider creating
struct RewrtitingRule{W<:AbstractWord}
    lhs::W
    rhs::W
    active::Bool
    ....
end

to keep the information closely packed together; the drawback is the size (8 bytes per Bool), the advantage (besides locality of information) is that BitArrays are not thread-safe:
help?> BitArray
search: BitArray

  BitArray{N} <: AbstractArray{Bool, N}

  Space-efficient N-dimensional boolean array, using just one bit for each boolean value.

  BitArrays pack up to 64 values into every 8 bytes, resulting in an 8x space efficiency
  over Array{Bool, N} and allowing some operations to work on 64 values at once.

  By default, Julia returns BitArrays from broadcasting operations that generate boolean
  elements (including dotted-comparisons like .==) as well as from the functions trues and
  falses.

  │ Note
  │
  │  Due to its packed storage format, concurrent access to the elements of a
  │  BitArray where at least one of them is a write is not thread safe.

rendered invalid by #51


Grammatical Error Corrected

Grammatical error corrected in keras/backend.py
Instead of this,
Session keyword arguments are not support during 'eager execution.'
Correcting the grammatical error,
Session keyword arguments are not supported during 'eager execution.'

@googlebot I signed it!


SPARKC-542: SPARKC-503 Backport

Requires increasing the driver target, all other changes
merge cleanly.

Build against Scala 2.10 finished with failure

Build against Scala 2.11 finished with success

Build against Scala 2.10 finished with failure


CSS styling does not work with ToolkitProvider

When I use ToolkitProvider, table styling does not work at all.  I specified "striped" and "bordered", but it doesn't work. I tried applying my own custom rowStyle as well, but it doesn't work. It's as if the CSS doesn't exist. Search bar styling does not work either. Here is my code:
import React, { Component } from 'react'
import 'react-bootstrap-table-next/dist/react-bootstrap-table2.min.css'
import 'react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css'
import dataArr from './data/dataArr'
import ToolkitProvider, { Search } from 'react-bootstrap-table2-toolkit'
import BootstrapTable from 'react-bootstrap-table-next'
import paginationFactory from 'react-bootstrap-table2-paginator'

class IndexTable extends Component {
  constructor (props) {
    super(props)
    this.state = {
      data: dataArr
    }

    this.formatImage = this.formatImage.bind(this)
  }
...
...
...
render () {
    const { SearchBar } = Search
    const columns = [ ....... ]
    ...
    ...
    return (

        <ToolkitProvider
          keyField="id"
          data={this.state.data}
          columns={columns}
          bootstrap4
          striped
          bordered
          search
        >
          {
            props => (

                <SearchBar {...props.searchProps}
                  placeholder="Search..."
                />

                <BootstrapTable pagination={paginationFactory()} { ...props.baseProps } />

            )
          }
        </ToolkitProvider>

    )
  }
}

I'm running versions:
react-bootstrap-table-next: 1.4.1
react-bootstrap-table2-paginator: 1.0.4
react-bootstrap-table2-toolkit: 1.1.1
Thank you!

The reason striped and bordered are not working is because you have to pass them to the <BootstrapTable/> component not the <ToolkitProvider/> like so:
<BootstrapTable striped bordered { ...props.baseProps }/>
As per the documentation you only need to move keyField, data, columns and bootstrap4 props to <ToolkitProvider/>
I tested the <SearchBar/> placeholder and it's working fine, and you didn't provide any code for the rowStyle. I could test the styling if you provide the code :)

I tried it that way but it didn't work.
What I ended up doing is adding "import 'bootstrap/dist/css/bootstrap.css'"
before the table2 CSS. Now it appears to work.
Thanks!
On Tue, Nov 13, 2018 at 4:38 PM Yassien<EMAIL_ADDRESS>wrote:

The reason striped and bordered are not working is because you have to
pass them to the  component not the
like so:
<BootstrapTable striped bordered { ...props.baseProps }/>
As per the documentation
https://react-bootstrap-table.github.io/react-bootstrap-table2/docs/toolkits-getting-started.html
you only need to move keyField, data, columns and bootstrap4 props to

I tested the  placeholder and it's working fine, and you
didn't provide any code for the rowStyle. I could test the styling if you
provide the code :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/react-bootstrap-table/react-bootstrap-table2/issues/662#issuecomment-438447560,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7LL09qIw3eRvccSlQPw4TtvVxEQen6ks5uuzvXgaJpZM4YYMbQ
.

Good to know you got it sorted. Out of curiosity, are striped and bordered working on <ToolkitProvider/> or did you have to move them to <BootstrapTable/> :stuck_out_tongue:

Seems to work fine in
Now that I have this working, I must say you've done a great job with
react-bootstrap-table2. It has saved me a lot of time; I love it!
On Tue, Nov 13, 2018 at 4:57 PM Yassien<EMAIL_ADDRESS>wrote:

Good to know you got it sorted. Out of curiosity, are striped and bordered
working on  or did you have to move them to
 😛
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/react-bootstrap-table/react-bootstrap-table2/issues/662#issuecomment-438453640,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7LLx-xDxd833TKE0ksrJprtSJE_RXoks5uu0BdgaJpZM4YYMbQ
.

@AllenFang is the creator of react-bootstrap-table2 not me. I'm just helping around :)

Oops! But thank you too for your help. :-)
On Tue, Nov 13, 2018 at 5:48 PM Yassien<EMAIL_ADDRESS>wrote:

@AllenFang https://github.com/AllenFang is the creator of
react-bootstrap-table2 not me. I'm just helping around :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/react-bootstrap-table/react-bootstrap-table2/issues/662#issuecomment-438468107,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7LL_hWoDwJu24s2QQa98sOFM3fSqkRks5uu0wugaJpZM4YYMbQ
.

Hi experts,
I  got silimar issue, the searchbar, clearSearchButton and csvExportButton cann't show normally, could you help to take a look plz? Put the code as below.
import React from 'react';
import  BootstrapTable from 'react-bootstrap-table-next';
import ToolkitProvider, { Search, CSVExport } from 'react-bootstrap-table2-toolkit'
import 'react-bootstrap-table-next/dist/react-bootstrap-table2.min.css'
import 'bootstrap/dist/css/bootstrap.css'
const { SearchBar, ClearSearchButton } = Search;
const { ExportCSVButton } = CSVExport;
const products = [
{
id: 0,
name: 'test',
price: '2100'
},
{
id: 1,
name: 'test',
price: '2100',
test: 'aa'
},
{
id: 2,
name: 'test',
price: '2120',
}
];
const columns = [{
dataField: 'id',
text: 'Product ID'
}, {
dataField: 'name',
text: 'Product Name'
}, {
dataField: 'price',
text: 'Product Price'
}];
export default class CustomTable extends React.Component {
render() {
return (

<ToolkitProvider
keyField="id"
data={ products }
columns={ columns }
search
>
{
props => (

<SearchBar { ...props.searchProps }/>
<ClearSearchButton { ...props.searchProps } />
<BootstrapTable
{ ...props.baseProps }
/>
<ExportCSVButton { ...props.csvProps}/>

)
}

)

}
}

@jasonusdid In the future please place the code in code tags (between ``) or preferably create a working example on https://codesandbox.io with your issue, this makes it easier to help and reduces syntax errors. Your code has some critical problems, not really related to this issue:

The <ToolkitProvider> element is not closed. This element accepts a function as a child, this function should return a react element.
The render function can only return one react element. If you want to return multiple elements you can wrap them in a <React.Fragment> or a

You should read more about render props here, you should also use this project's storybook for examples
Here is a working example, tailored for bootstrap4:
https://codesandbox.io/s/musing-feather-4wy9vlo0x4

Hi @YassienW , Thanks a lot for your help.
The syntax errros are caused by something wrong when coping the code. and the btn style issue is due to the initial code without no className specified as below.
export default class CustomTable extends React.Component {
render() {
return (

<ToolkitProvider
bootstrap4
keyField="id"
data={ products }
columns={ columns }
search
>
{
props => (

<SearchBar { ...props.searchProps }/>
<ClearSearchButton className="btn-secondary" { ...props.searchProps } />
<BootstrapTable
{ ...props.baseProps }
/>
<ExportCSVButton { ...props.csvProps}/>

)
}

)
}
}
Thanks again for your help. It's really helpful.

it's strange that the code cannot be copied with some keywords for example  ...
Anyway, Thanks again @YassienW  for help

I am unsure whether the buttons are supposed to be unstyled by default or not, perhaps you should open a new issue
Also, using 3 ticks sorts the code out ```code```
import React from "react";
import ReactDOM from "react-dom";
import BootstrapTable from "react-bootstrap-table-next";
import ToolkitProvider, {
  Search,
  CSVExport
} from "react-bootstrap-table2-toolkit";
import "react-bootstrap-table-next/dist/react-bootstrap-table2.min.css";
import "bootstrap/dist/css/bootstrap.css";

const { SearchBar, ClearSearchButton } = Search;
const { ExportCSVButton } = CSVExport;
const products = [
  {
    id: 0,
    name: "test",
    price: "2100"
  },
  {
    id: 1,
    name: "test",
    price: "2100",
    test: "aa"
  },
  {
    id: 2,
    name: "test",
    price: "2120"
  }
];

const columns = [
  {
    dataField: "id",
    text: "Product ID"
  },
  {
    dataField: "name",
    text: "Product Name"
  },
  {
    dataField: "price",
    text: "Product Price"
  }
];

export default class CustomTable extends React.Component {
  render() {
    return (
      <ToolkitProvider
        bootstrap4
        keyField="id"
        data={products}
        columns={columns}
        search
      >
        {props => (
          <React.Fragment>
            <SearchBar {...props.searchProps} />
            <ClearSearchButton
              className="btn-secondary"
              {...props.searchProps}
            />
            <BootstrapTable {...props.baseProps} />
            <ExportCSVButton className="btn-primary" {...props.csvProps}>
              Download CSV
            </ExportCSVButton>
          </React.Fragment>
        )}
      </ToolkitProvider>
    );
  }
}
const rootElement = document.getElementById("root");
ReactDOM.render(<CustomTable />, rootElement);

Have this or kinda alike issue on Export CSV btn:

import 'bootstrap/dist/css/bootstrap.min.css';
import 'react-bootstrap-table-next/dist/react-bootstrap-table2.min.css';
import 'react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css';
// ...
<ToolkitProvider keyField="id" data={employees} columns={columns} bootstrap4 exportCSV>
  {({ baseProps, csvProps }) => (

      {/* eslint-disable-next-line react/jsx-props-no-spreading */}
      <ExportCSVButton {...csvProps}>Export CSV</ExportCSVButton>

      <BootstrapTable
        /* eslint-disable-next-line react/jsx-props-no-spreading */
        {...baseProps}
        filter={filterFactory()}
        filterPosition
      />

  )}
</ToolkitProvider>


Question: Process documentation and Docker images source code

Hi, I have a couple questions.
Where is the EOS development process documented? ( There's no contributing.md in the main repo btw )
What is exactly the difference between eosio/eos and eosio/eos-dev docker images, where's the source code?

I am aware of this https://github.com/EOSIO/eos/tree/master/Docker
However there's no documentation on Docker Hub.
I could assume that eosio/eos is the latest tag and eosio/eos-dev the latest commit on master, I want to be sure.

Ok, I missed out this folder I missed out this folder https://github.com/EOSIO/eos/blob/master/Docker/dev/Dockerfile
Now I can tell where is eosio/eos-dev and can see the Dockerfile of both images.
However better documentation on docker hub would be nice. IMHO images should have readmes on docker hub.
I have more questions now, by looking at the source of the Dockerfiles I can really tell why the different steps, I would really nice to have this documented

Due to the fact that the eosio/eos image does not contain the required dependencies for contract development (this is by design, to keep the image size small), you will need to utilize the eosio/eos-dev image. This image contains both the required binaries and dependencies to build contracts using eosiocpp.

https://github.com/EOSIO/eos/tree/master/Docker


Add "common" shuffles

The shuffle API in #62 can handle nearly any hardware shuffle, but it's a bit clumsy to use (and the API requires full const generics).
A few common cases of shuffles should be provided as a simpler API:

[x] reverse
[x] rotate
[ ] shift (like rotate but insert 0s)
[ ] align (or maybe rotate2?) see #78
[x] interleave/deinterleave

If the shift amount is a constant, then it should be possible to implement these as const functions that output the corresponding array to passe into shuffle's const parameter.
As an example, it's possible to implement alignr (x86 doesn't have an alignl) with
const fn alignr<const LANES: usize>(shift: usize) -> [u32; LANES] {
    let mut indices = [0; LANES];
    let mut block = 0;
    while block < LANES {
        let mut idx = 0;
        while idx < 16 && idx < LANES {
            // x86 chunks its vectors into 16 byte chunks for alignr
            let offset = if shift + idx >= 16 {
                LANES + (shift + idx) % 16
            } else {
                shift + idx
            };
            indices[idx + block] = (offset + block) as u32;
            idx += 1;
        }
        block += 16;
    }
    indices
}

After some testing, LLVM does appear to recognize the array that results as an alignr and simplifies it down.

I wonder if there's any point adding shift and align?  They can both be implemented manually, or they can be implemented via rotate and select, which I would think the compiler could optimize.  They're not the most obvious functions, so it might actually be clearer manually implementing them than having to reference the docs.


Where to download updated apks from the jenkin builds

where to get the artifacts from daily builds?
http://ci.tensorflow.org/job/tensorflow-master-android/

It's in our README: https://github.com/tensorflow/tensorflow#installation.


feat: complete capital provider integration in bot

Before submitting this PR, please make sure:

[ ] Your code builds clean without any errors or warnings
[ ] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing:

For this PR to be considered, it needs rationale for adding this feature along with an approved PRP: https://hummingbot.org/governance/proposals/#pull-request-proposals


Graphics holds onto a lot of resources even after the NativeEngine is disposed

When I load a big model or something (where memory usage is most noticeable), after the NativeEngine is disposed, a lot of memory is still in use. If I do some hackery to manually call bgfx::shutdown, most of the resources are released. We should dig into this more and make sure most resources are released when the NativeEngine is disposed.

AFAIK, bgfx::shutdown doesn't destroy resources except clear quad and framebuffers. If you don't have leaks reported by bgfx, then it might be something else.
Do you know the amount of memory still in use? or the type of resources? Any thing reported by bgfx leak check?

It was a lot (I want to say like 100mb after loading an 80mb model that was mostly vertex data). I don't think I did enough analysis to know what type of resources were released after I forced a call to bgfx::shutdown. My hacks to test this out are in this branch: https://github.com/ryantrem/BabylonReactNative/commit/4eadcf7d5854ccd65ebc7356c4435b8257b7b8ad

Also can you try to call bgfx::frame() after calling dispose on the engine. Maybe the destructions are pushed on the command buffer and would really be destroyed until the frame is happening.

This has been addressed by https://github.com/BabylonJS/BabylonNative/pull/506 and https://github.com/BabylonJS/BabylonReactNative/pull/120.


Title and tabsets: convert remaining ivars to helpers

@owner_naming and the filtered help tooltip.

coverage: 93.693% (+0.002%) from 93.691% when pulling 992f17168eee4d2af802aa3282178b8004475b24 on nimmo-rubric into df4ccd2ae8bc4d30ea5222aff0e92a48c98feec7 on main.


Update COMMUNITY-PROJECTS.md - ipfsUploader

@rej156 thanks for submitting this awesome project and PR. Would you mind also adding your keys to this list? After you do that I'll merge them in! 👌

Done and done
@michaelsena
https://github.com/uport-project/3box-js/pull/103

Merged @rej156 :+1:


D8-221/234 - Querying images from Database for Henna/Wedding Sign

Querying images from Database for Henna/Wedding Sign Showcase
shop-images.js api file for pulling images from database
NOTE: If you do not have a shop table with values populated into it, your henna and wedding sign showcase page will be empty

looks nice


composer.phar require "rhumsaa/uuid=~2.8" is not proper

Then running
composer.phar require "rhumsaa/uuid=~2.8"

said:
Package rhumsaa/uuid is abandoned, you should avoid using it. Use ramsey/uuid instead.

so should change it to
composer.phar require "ramsey/uuid=~2.8"

Changes Unknown when pulling 19f7a257aac4612c6740716c0de0aa9f989be782 on suzuken:2.8 into ** on ramsey:2.8**.

Thanks!


Replace CSP & FP var names with hash

Newer sites use a hashed domain value, older sites have a more verbose var name which chews up more Nginx resources.

Done and done.


https://central.xero.com/s/question/0D58V00009JNs4uSAD/officialquickolutionhow-do-i-contact-kraken-support-akkraken

Aka.ms link name
https://central.xero.com/s/question/0D58V00009JNs4uSAD/officialquickolutionhow-do-i-contact-kraken-support-akkraken
Category (Optional. Select None to auto-select)
None

to fix your trouble check this fix, i see it in another issue,
https://github.com/Jostino/RimWorld-it/releases/tag/fix
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


formula_installer: improve install/upgrade message

If you brew install a formula that's already installed you get:

Warning: ripgrep-0.5.1 already installed

If you brew install an outdated formula that's installed you get:

Error: ripgrep-0.5.1 already installed. To install this version, first brew unlink ripgrep

Instead, suggest that the user should brew upgrade in this case. If the formula isn't outdated use the previous  message.
CC @ilovezfs for thoughts.
Fixes #2543.

Thanks you rock!


Support for Beaglebone devices running 4.1 kernel.

Since the new capemgr has now been included in the latest 4.1 kernel, I was wondering if there was a plan to support it?
linux repo: https://github.com/beagleboard/linux/tree/4.1
overlay repo: https://github.com/RobertCNelson/bb.org-overlays
As far as I can see the major changes are in the file path
slots:
/sys/devices/platform/bone_capemgr/slots
I assume the BB foundation will be moving towards this kernel in the near future, so just interested in finding out if this lib will support it?

I can see you have also commented on OctalBoneScript. Yes, we are planning to support it and it will take a few months for us to upgrade OBS code.


feat(cmake): make BUILD_SEPARATE_LIBS work with BUILD_MERGED_PLUGINS

create separate libraries by module, and an optional rime-plugins library.

@hchunhui Please have a look.
The *-objs target doesn't work well in macOS build, I couldn't create individual dylibs for plugins, and had to use a work-around (adding an empty .cc file) to create the merged librime-plugins.dylib.

@lotem I can't reproduce the issue in Linux (CMake 3.13.4).
I have passed four build modes (switch on/off two flags), after I delete plugins/plugins.c.
So I think it is a macOS specific issue. Maybe we should keep the workaround.

@hchunhui That's true. I also tested in Linux, different results.
Another difference is: in Linux there's no need to target_link_libraries(a-plugin rime rime-dict ...)
but it is a link error if rime is not in its deps in macOS build.

@hchunhui That's true. I also tested in Linux, different results.
Another difference is: in Linux there's no need to target_link_libraries(a-plugin rime rime-dict ...)
but it is a link error if rime is not in its deps in macOS build (not sure if it's because the BUILD_STATIC=ON option or because of different CMake implemetation (i saw many .sh scripts created by CMake on macOS, but was Makefiles in case of Linux)).
because of this, I have to repeat ${rime_library} ... in both target_link_libraries() and add_dependencies(). the latter alone works for Linux build.

I see. The reason is that you use static build.
I can fix the issue.

I need some time to recall the solution.
Maybe I will commit tomorrow.

No worries. I'll working on it.

By the way, while experimenting with the librime-legacy plugin, I'm also working to change the for-Linux Makefile as follows:

add a target merged-plugins that creates a release build that merges any existing plugins/*
the default release target set BUILD_MERGED_PLUGINS=OFF, with two considerations:

releaser (to linux distros) of the librime package doesn't have to change the build rules to avoid including any plugin code in the binary package;
every plugin can be built as a separate binary and make a package of its own; build instructions stay simple:
cd librime; git checkout plugins/x; make && make install which installs both librime.so and x.so

In CMakeFile.txt, (and in contrast to building for release purposes,) BUILD_MERGED_PLUGINS is by default ON so it's easy to integrate plugins easily.

Merged.

FYI
I updated the sample plugin and wrote some notes in sample/README.md.


HARP-7814: Tune the internal discrete scaling functions.

Increase the reference zoom level used by "world-discrete-ppi-scale"
to convert pixels to world units.
Signed-off-by: Roberto Raggi<EMAIL_ADDRESS>

Codecov Report

Merging #1290 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #1290   +/-   ##
=======================================
  Coverage   52.97%   52.97%
=======================================
  Files         260      260
  Lines       23378    23378
  Branches     5170     5170
=======================================
  Hits        12385    12385
  Misses      10993    10993

Impacted Files
Coverage Δ

...-datasource-protocol/lib/operators/MapOperators.ts
28.2% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1745ea...d4e43fb. Read the comment docs.


Adjusted default value for the supported Net frameworks versions where "None" is incompatible.

Fixes https://github.com/dotnet/MQTTnet/issues/1347.
However, I don't know whether NetStandard or UWP or something is concerned here, too.

I think .net 4.7 is affected, please see the issue for detail.

I gave this a bit more thought; please bear with me.
The current proposal will make OLDER .net versions MORE SECURE in that they sport a more modern set of allowed protocol(s), i.e. TLS 1.2  only at the moment. Newer .net will yield to schannel, which in case of Windows 11 will happily connect using TLS 1.0. I think this is quite confusing.
I see two non-confusing options:

Use SslProtocol.None as a moniker to use SslStream overload without explicit SslProcol argument. Being a "mere" library, this yields the burden of choice to the current .net+schannel mashup the developers of a given solution should already know how to work with or against. On an older .net, this means outdated defaults (only 1.0 and 1.1), and newer .net will fall back to 1.0. On the upside, no .net version compiler black magic.

Let MQTTnet make a deliberate, well-documented default of TLS 1.2+TLS1.3. This is 2022, and you still have the option to specify weaker protocol. 4.6 could do 1.2 only, or use a numeric enum definition (I tested this in another setting).

I think you should rather choose from these two options.

In my opinion option 2 ist best because it is explicit and no implicit knowledge or lots of comments are required to explain why certain (empty) constructors etc. must be used.

2. Let MQTTnet make a deliberate, well-documented default of TLS 1.2+TLS1.3. This is 2022, and you still have the option to specify weaker protocol. 4.6 could do 1.2 only, or use a numeric enum definition (I tested this in another setting).

Er, okay.
Is this meant to look somehow like this or did I understand this completely wrong (I didn't have the time yet to check how the integer value should be set)?
#if NET452 || NET46 || NET461 || NET462 || NET47
            var sslProtocols = _webSocketOptions?.TlsOptions?.SslProtocol ?? SslProtocols.Tls12 | (SslProtocols)13;
#else
            var sslProtocols = _webSocketOptions?.TlsOptions?.SslProtocol ?? SslProtocols.None;
#endif

@SeppPenner Basically, yes.
But the expression _webSocketOptions?.TlsOptions?.SslProtocol ?? SslProtocols.None MAY never hit because SslProtocol is not an optional enum (not SslProtocol?).
I would suggest to just change the ctor assignment in the tls options. That way None is still an option users can set, plus the default becomes visible in the debugger. AFAICT there is no need to change other code.
On .net 4.6 and below, you may want to use SslProtocols.Tls12|(SslProtocols)0x00003000 /*Tls13*/ instead of the symbols. (4.7.0 should already have the Tls13 Symbol).

Oh, sorry I misread your  example!
Option 2) means SslProtocols.None is not a default any more. The new default for all targets would be Tls12|Tls13 (or whatever), and target discrimination ideally only serves compiler compatibility, i.e. no or only 'expected' semantic changes.

@SeppPenner  Can I support here? I want to start with 4.0 beta releases which should include this change.

(4.7.0 should already have the Tls13 Symbol).

Nope: https://docs.microsoft.com/en-us/dotnet/api/system.security.authentication.sslprotocols?view=netframework-4.7
As far as I have seen it, only Net6.0, Net5.0, NetCore3.0 and 3.1 and NetFramework4.8 support the name. Please check my changed pull request :)

@SeppPenner Can I support here? I want to start with 4.0 beta releases which should include this change.

It should be alright now (I hope) 😄

Thanks!
One nit: I suggest to special-case the older versions requiring the numeric enum. A new .net 7 is much more likely than .net 4.9 ;)


Fix(?) spurious smoketest failures

During CI tests pods can get stuck on registry related errors

Usually Unauthorized or Not Found
These appear to be race conditions with the setup of the ImageStreams

In each case, deleting the affected pod leads to recovery
This "fix" adds a 10m timeout to our rollout checks

After timeout, the relevant pod is killed

In cases where rollout is proceeding smoothly, this add NO extra delay
In cases where rollouts are failing, delays in multiples of 10m are possible

But much higher probability that the rollout will eventually complete

I'm going to wait for the two :heavy_check_mark: to appear before inviting anyone to the PR ;)

So what you're saying is that I shouldn't blindly accept this? :)

All I'm saying is that when I put up a PR to "fix" the CI tests, the CI tests had better pass or I'm gonna be pretty embarrassed.


batch 4 addons per build to stay under 256 total builds

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Does this PR require documentation?

This is why this needed to be bumped, for posterity


[Feature Request]: Default Prometheus Stats

Feature Description
We should expose default prometheus stats.
It should be as easy as:
from llama_index import PrometheusTracer, start_grafana_dashboard;

start_grafana_dashboard(prometheus_port=3003,grafana_port=3002) # e.g. subprocess.popen(...)
service_context.add_callback_handler(PrometheusTracer("localhost:3003"))

Tables:

tbd

Note that prometheus is better for monitoring service continuously as a whole, as opposed to tracking individual runs. However, several summary information that strips away the run_id can be beneficial. Such as tokens/run, cost/run etc.


ALE would clear location list that create from other plugin

Information
VIM version
NVIM v0.3.2-462-gf2b555c9e
Build type: Release
Operating System: MacOS
What went wrong
https://github.com/w0rp/ale/blob/aa5c82b1718f44d04f6dd11bc63f6eeed2089d9d/autoload/ale/engine.vim#L764
Ale is clearing location list when it doesn't find any lint to work for the buffer,  the location list or quickfix list should not be cleared unless it's created by ale, alt could check that by using title in setloclist or setqflist
Reproducing the bug

Disable ale for current filetype, eg: vuelet g:ale_linters = {
\   'vue': [],
\}

Create a location list by using setloclist
Trigger ale by type something
The location list would be empty

This is to be expected. ALE has to clear the list when you find problems and then find no problems again. You can't use ALE with another plugin which is populating the same list at the same time.

@w0rp But I didn't set any linter to that buffer, ale should ignore that buffer when clearing location list or ale should be able to clear location list that created by ale only, the current behavior would cause unexpected empty location list when using other plugin that use location list at the same time.

ALE does not support running any other tools that modify loclist at all while ALE is enabled. Either disable ALE's loclist setting for that buffer, or disable that other plugin for that buffer.

@w0rp But how could I disable ale's location list for some filetypes or a specific buffer? There's only g:ale_set_loclist I can find.

We'll have to implement some more buffer-local versions of the options.


Don't force a trailing slash on file extensions

If you force the trailing slash on https://www.example.com/example/index.html, the curled page 404s, and you scan the 404 page instead of the desired page.
This could also allow for scanning css and js files down the line.

Hi Dan,
Thanks for this addition.
Regards,
B!


Babel plugin not running on ^4.3.0

Not sure if I'm missing something but seems like I can't get babel-plugin-styled-components to run with rollup-babel-plugin.
It seems to work fine using 4.2.0 and below, but anything after 4.3.0 seems to behave differently.
Here is a repo https://github.com/deini/rpb-debug master branch is on 4.3.3 and there is a 4.2.0 branch. There are two directories for rollup-output and babel-output. You can see the difference in the output from @babel/cli vs rollup and how similar they are on the 4.2.0 branch.

I believe this is the same issue as the one investigated here: https://github.com/rollup/rollup-plugin-babel/issues/320#issuecomment-566757103 and it should be reported to styled-components team. Sorry that you had to wait for an answer for so long.


Constant And Special Field example makes empty chart

Looking at http://brunel.jupyter.ninja:9080/brunel-service/docs/ Constant and Special Fields.
Clicking on the
bar x(state) yrange(winter, 58.2) + bar x(state) yrange(summer, 58.2)
example yields a chart with both axes and no visible bars.

This is now working with newly updated docs:  http://brunel.mybluemix.net/docs/


payment_service_for and Rails 3 form_tag helper

Hi,
I'm adding a new Integration for a local payment gateway and having a problem with making it work on rails 3.
Rails 3 form_tag helper automatically inserts an utf8 hidden field to the form. This creates a problem when the payment gateway includes this field in calculating the secure signature hash which wouldn't match with the provided value by my integration helper.
Any suggestion on how to fix this? How about build the form in payment_service_for manually without using form_tag?
Thanks.

Agreed this field shouldn't be be passed to external services; I'll gladly merge a PR to fix the issue if it still exists. Thanks!


Broken version (?)

Hi,
Thanks for creating this tool, super useful!
I am running into an unexpected problem with the version flag:
git spr --debug version
> git rev-parse --show-toplevel
Config : {
  "Repo": {
    "GitHubRepoOwner": <redacted>,
    "GitHubRepoName": <redacted>,
    "GitHubHost": "github.com",
    "RequireChecks": true,
    "RequireApproval": true,
    "GitHubRemote": <redacted>,
    "GitHubBranch": <redacted>,
    "MergeMethod": "merge"
  },
  "User": {
    "ShowPRLink": true,
    "LogGitCommands": true,
    "LogGitHubCalls": true,
    "StatusBitsHeader": true,
    "StatusBitsEmojis": true,
    "CreateDraftPRs": false,
    "PreserveTitleAndBody": false,
    "Stargazer": false,
    "RunCount": 47
  }
}
dev : unknown : dversion

I installed from source on July 21 (i.e., a week ago).
Thanks!

Hi Itai,
The version is currently set by the build tool (go releaser) through link flags.
I think if you build it yourself from source you won't get these.
If you have goreleaser installed, you can try make bin and I think you should get a valid version.


Bring Jenkins up to date

Arbitrary file read vulnerability with Credentials Binding Plugin 1.13 or newer```
We should aim to upgrade again (!) once this vulnerability is addressed


user configurable event buffer size

resolves # No ticket-- follow on to #4358
Description
Add new global cli flag EVENT_BUFFER_SIZE to control the number of events buffered in memory during operation.
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change

@nathaniel-may @jtcohen6 -- Is there anything else additional I need to do to document the new flag?  I'm not sure of the SOP for new ones.

good question. I'm not sure. Maybe @leahwicz knows?

I'm not sure but let's merge this PR and we can always open another PR for docs

main.py has the help string


Script to extract function signatures from compiled data

Fixes: https://github.com/runtimeverification/firefly/issues/563

This script should live over in runtimeverification/firefly.

This will be moved over to runtimeverification/firefly.


BigQuery: add code snippet for CMEK table loading. [DO NOT MERGE]

Also, removes assert for state == 'RUNNING' from snippets, as this is flaky for small jobs that complete very quickly.
The key used is one that I've created which is accessible to all users. This means anyone can still run the system tests.
Based on https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4845

/cc @vitaliili


AdditionalSearchTerms not working for Page Extensions

Dear Team,
AdditionalSearchTerms is not working for Page Extensions. It is possible to set the parameter in the object but after Publish and Install Extension (even after restart service) the Additional Search is not working.
Steps and to reproduce the behavior:

Create Page Extension for Customer List
Add Parameter AdditionalSearchTerms (see screen)
Publish the App

Expected behavior
It depends on the classification:

If it should be possible to add AdditionalSearchTerms to Page Extensions - should be possible to search
If it should not be possible to add AdditionalSearchTerms to Page Extensions - AdditionalSearchTerms should not be possible to add on the object in AL

Screenshots

Versions:

AL Language: al-3.0.106655
Business Central: bcsandbox and newest BC on-prem

As a note, we also have #4569 related to search from extensions.

AdditionalSearchTerms support fixed for PageExtensions in 2019 Wave 2 (version 15) CU1.


Add basic benchmark workflow

The benchmark workflow is implemented as Argo workflow, and should consist of config retrieving, benchmark running, and reporting steps.

/assign xyhuang


RESTRICT_BY_USER is broken in 5.3.0

TypeError at /ckeditor/upload/
getattr(): attribute name must be string
site-packages/ckeditor_uploader/views.py in get_upload_filename, line 28
--
5.3.0 looks like this:
        try:
            user_prop = getattr(user, RESTRICT_BY_USER)
        except AttributeError:
            user_prop = getattr(user, 'get_username')

which throws an uncaught TypeError
It looks like it is fixed in master but the released version doesn't include this.
django-ckeditor==5.3.0

https://pypi.python.org/pypi/django-ckeditor/5.3.1 is available

Oh good. Sorry I missed noticing that.
On Fri, Oct 27, 2017, 11:47 Piotr Maliński<EMAIL_ADDRESS>wrote:

https://pypi.python.org/pypi/django-ckeditor/5.3.1 is available
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/django-ckeditor/django-ckeditor/issues/443#issuecomment-339926377,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANWcthtxTQPjnWOc1coyTDfsKG7igPoks5swabNgaJpZM4QIrQm
.


Sync Teleport Branch with Upstream

Resolve some conflicts and rebased on master of cert-manager in order to sync us back up with upstream.
Fixes dependabot issues.

Think I'm going to want to try and reset this since the changes are correct but the commits are not so it shows a large divergence from upstream master to teleport branch.


Feature/example

Move govuk-react-example in to monorepo.
Closes #119

Closing, waiting for better support from CRA for workspaces: https://github.com/facebook/create-react-app/issues/1333


Add url to take to microsoft site in README.md

This PR fixes #

Minor edit in README.md

How much value does this change really add?

This doesn’t feel like a meaningful addition


Phil Sayer for serveral downwards voice

Newcrainghall played as Newport(Wales)
Newhaven Harbour played as Newhaven Town
Newhaven Town played as Norbury
Norbury and Newcastle voice are not able to play with error message
For reference:
Norbury
e80164b2250f4bbb90f6825315f93cc4
Newcastle
6eca8ca2aef140b5881311d8222e8c27

Thanks for this. They're all transcription errors and will be fixed in https://github.com/Rail-Announcements/ketech-llpa-announcements and ported over here.

Should be fixed now


Error while creating cluster | tags/v1-23-eks-5

What happened:
[ec2-user@ip-172-31-3-34 kops]$ ./create_cluster.sh
✔ AWS_REGION=me-south-1
✔ AWS CLI authenticated
✔ KOPS_STATE_STORE=s3://h-kops-state-store
✔ KOPS_CLUSTER_NAME=ex-test-eks.test.co
Error: error building complete spec: error reading tag file "https://distro.eks.amazonaws.com/kubernetes-1-23/releases/7/artifacts/kubernetes/v1.23.9/bin/linux/amd64/kube-apiserver.docker_tag": unexpected response code "403 Forbidden" for "https://distro.eks.amazonaws.com/kubernetes-1-23/releases/7/artifacts/kubernetes/v1.23.9/bin/linux/amd64/kube-apiserver.docker_tag":
AccessDeniedAccess DeniedJ7N3NHS1S30H31MQT+VNCMcZ/XHdwcSzvVwO2SSnnH6b14FEmfhlt/gOc7MUXAjB/LoweuWQmkK6q1AMdX4ibmIC1zk=
What you expected to happen:
Cluster should be created.
How to reproduce it (as minimally and precisely as possible):
Checkout tag: v1-23-eks-5
Follow: https://distro.eks.amazonaws.com/users/install/kops/
Anything else we need to know?:
Environment:

EKS Distro Release Channel:
EKS Distro Release: v1-23-eks-5

Thanks for submitting this @jeenadeepak.
The default value for RELEASE_ENVIRONMENT is set to development, which results in it trying to pull the artifacts at 7 which is latest dev release. It fails because those don't exist for production.
Before running the kOps script, try setting RELEASE_ENVIRONMENT to production and it should reference 1.23-5 as expected.

Closing this out. If you still run into trouble we can reopen it.


Backslash for old ie causing problems with cleancss

Running cleancss against theme.css
.jsgrid-load-panel {
    padding-top: 1.5em \ ;
}
.jsgrid-load-panel:before {
    display: none \ ;
}

gets converted into (note removed ; at the end of each block)
.jsgrid-load-panel{padding-top:1.5em \}.jsgrid-load-panel:before{display:none \}
What browsers does \ target? Is \9 the intended hack?

Changing \ to \9 does fix the problem.

Thanks for the report and fix!

:+1:


Use Task.CompletedTask to reduce allocations

What issue does this PR address?
Very simple change to reduce memory allocations.
Does this PR introduce a breaking change?
No impact on existing codebase.
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[x] Unit Tests for the changes have been added (for bug fixes / features) No unit tests for AspNetIdentity project

Other information:
Created simple benchmarks project to test my change using BenchmarkDotnet.
Here are the results:

Method
Mean
Error
StdDev
Gen 0
Gen 1
Gen 2
Allocated

WithTaskCompleted
1.146 us
0.0222 us
0.0197 us
0.2155
-
-
680 B

WithTaskFromResult
1.181 us
0.0188 us
0.0157 us
0.2384
-
-
752 B

Yes, looks good. Thanks.


Reconfigure tasks

Q
A

Issue Type
Feature Request

Deployer Version
4.0.2

Local Machine OS
N/A

Remote Machine OS
N/A

Description
It would be useful if there was an API to reconfigure existing tasks. Right now if one wants to e.g. limit execution of a task from a recipe to a limited set of servers, one has to do something like this:
desc('Limit foo task to selected servers');
task('config:foo:bar', function() {
  $deployer = Deployer::get();
  $task = $deployer->tasks->get('foo:bar');
  $task->onlyOn([
    'server1',
    'server2',
  ]);
});
before('foo:bar', 'config:foo:bar');

I could imagine an API like this instead:
task('foo:bar')->onlyOn([
  'server1',
  'server2',
]);

(Same goes for all other methods of the Task class.)
This would mean that the $body of task() would become optional. If called with only the task name, the Task object would be returned if present.
What do you think?

I think reconfiguring tasks on runtime is bad idea. Why you need it for?

I gave an example above: a task bundled with a recipe should only be executed for a selected list of servers (or stages). To be specific its a task which should clear the PHP opcode cache and that doesn't work on all of our servers. Thus we limit the task to the servers where it works. Yes, the original issue is the broken servers but sometimes we don't have a choice and thus try to work with it as good as possible.
And yes, I understand that reconfiguring tasks at runtime can have bad side effects.
Do you have another idea how we could solve our (and similar) issues?

I think API like this task('foo:bar') is okay. Need to think a little bit more about corner cases.
Also did you try this?
task('foo:bar:part', ['foo:bar'])->onlyOn([
  'server1',
  'server2',
]);

Using group tasks for this?

Your suggestion sounds useful and would at least reduce the visual overhead, I'll try that.

I will add this solution to docs later.

@elfet I just notice that this is not possible actually since group tasks cannot be configured like this.
Do you think it would be possible to allow this for group tasks? Otherwise I'd have to stick to my original attempt, unless task reconfiguration is added.

@mbrodala can you describe when you want to configure tasks? At what point and based on what data?

@elfet I think I made this clear by now. ;-) We have some tasks (e.g. PHP Opcache reset) which are included from recipes but should only run on a few selected servers since e.g. reset does not work on the other servers.

Ok, so this kind of API will be usable here:
task('deploy:opcache')->onlyOn([
  'server1',
  'server2',
]);

Yeah, that's my suggestion. I can add a PR if you think this could go in.

Yes, i think lest give it a try)

@elfet @mbrodala guys, I guess the issue can be closed, doesn't it?

True

task('deploy:opcache')->onlyOn([
  'server1',
  'server2',
]);

got following error:
PHP Warning:  Missing argument 2 for Deployer\task(), called in

@torinaki There is no release of Deployer which includes this change yet.

@mbrodala but offical documentation already contains this changes:

https://deployer.org/docs/tasks

Yeah, because there is only one branch (master) in that repository. @elfet Maybe this should be changed?

Yes, i really wan't to do something with this, maybe have two branches, published and master.


Comment counter testing - Student B

In this milestone, I implemented the following as per the project requirements:

Added unit tests for the comment counter function & make sure that tests have been added for all edge cases.

General requirements checklist.

No linters error.
Used the correct Gitflow workflow.
documented work professionally.
Followed the best practices of HTML, CSS, and JavaScript.

Status:Approved 🟢 🟢
Your project is complete! There is nothing else to say other than... it's time to merge it : ship it:
Congratulations! 🎉
Highlights
The app works great💯
Descriptive pull request summary👍
Meaningful commit messages🟢 👍
No linter errors 💯
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Sign in with Discord

Review API integration document for ease of implementation.

Sign in with discord
Use credentials to check guild membership
Use credentials to check for membership role in guild
Return auth status/payload
Store payload in the UI/UX store library (zustand)

APIs from autocode
Steps 1,2 & 3 can be implemented and reduced to a single auth function


Script error Left operand of 'is' was already freed which may cause memory leak

Probably this is caused because argument and returned value points to exactly same variable and due script error later code will not execute and cause memory leak

Looks that latest CI run of Goost works now fine - https://github.com/goostengine/goost-fuzzer/actions
I added CI to check removed items and tomorrow I will check if anything broke.


Plaid exit after onSuccess

I'm trying to forcefully exit plaid as soon as onSucess is fired. I have used a standard react implementation without hooks, and I don't intend on using hooks in this application anytime soon.
<PlaidLink                   linkCustomizationName="..."                   publicKey={plaidAuthentication.key}                   apiVersion={plaidAuthentication.apiVersion}                   onSuccess={onSuccess}                   className={styles.plaid}                   onEvent={onEvent}                   onExit={onExit}                   // how do I get this to work? exit={this.exit()}                 >
The reason I want to forcefully exit plaid is because I don't want the users to see the login successful screen of plaid as attached. Can anyone help me with how to use the exit or destroy functions? Thank you.

hi @PraveenPuvvula sorry if I am misunderstanding something here, but can't you just un-render the PlaidLink component? When that component unmounts it destroys Link. I tested this out like so and it appears to work fine.
import React from 'react';

import { PlaidLink } from 'react-plaid-link';

const App = (props) => {
  const onExit = (error, metadata) => console.log('onExit', error, metadata);
  const onEvent = (eventName, metadata) =>
    console.log('onEvent', eventName, metadata);
  const onSuccess = (token, metadata) =>
    console.log('onSuccess', token, metadata);

  const [showLink, setShowLink] = React.useState(true);

  return (
    <>
      <button onClick={() => setShowLink(!showLink)}>toggle link</button>
      {showLink && (
        <PlaidLink
          token={props.token}
          onExit={onExit}
          onSuccess={onSuccess}
          onEvent={onEvent}
        >
          Open Link and connect your bank!
        </PlaidLink>
      )}
    </>
  );
};

export default App;


core: save/restore FPU registers in VM entry/exit

Guest OS kernel/app might use SSE instruction and registers.
When Guest OS VM exits, these registers should be saved, or else
it might be corrupted by host OS/app. In next time guest VM
enter, guest's SSE registers context might be corrupted.
Guest app segfault and kernel panic were reported
which should be related with this issue.
This change is to remove is_fpu_used flag so guest FPU registers
could be saved in VM exit and restored in VM entry unconditionally.
Fixes #39, fixes #74.

A new warning is generated.
core/vcpu.c Ln 2168: unused variable 'cr0'


Ignore specific parts of UI on per URL basis

Suggestion: https://twitter.com/pgchamberlin/status/523874975691046912

@DaveBlooman could you help me understand how #189 solves this?


Add an error message if the configmap has incorrect type.

Thiis PR adds the foolowing error message if any of the configmaps loaded in the load_profiels funciton is of incorrect type (commonly caused by mistakes in the yaml structure):
Ignoring CM <name> - content must be object, not list.
Please review configuration documentation for the
jupyterhub-singleuser-profiles library.

lgtm


use correct unsubscribe method for channel_listener data type

fixes https://github.com/elastic/logstash/issues/5222

LGTM


BiG ISSSUEEEE!!!!

Hello, There is no controller available to open-cell at any index with swipeController however there is an option to close-all-cell, how can I close the cell without opening it !!!

You should open the cell with your finger....

please try 2.0.8 version


Stack Plots includes unwanted variables

Stack plot of a simulation with PWL variables plots the PWL variables.

this is fixed in commit 3f9e638a8560c485585da84c45be6e9c60670ae2 as well


IMU-Camera Synchronised Triggering

This PR adds support for triggering of external cameras (e.g PointGrey Firefly MV) using the FMU auxillary pins as GPIOs.
For now,
nsh> fmu mode_gpio
nsh> camera_trigger start

Will start the triggering system on AUX 1 with default polarity ACTIVE_LOW. Parameters need to be adapted to different cameras. Currently set to sensible defaults for Firefly MV.
TODO:

[ ] Rewrite app to C++
[ ] Set a bitmap which by default enables some FMU pins as GPIOs, and some as PWM as required. during startup.
[ ] Use command instead of parameter for trigger enabling or disabling.
[x] Add mavlink message for CAMERA_TRIGGER with a sequence field and a timestamp for the image frame. ( https://github.com/mavlink/mavlink/pull/368/ )
[ ] Add mavlink stream for CAMERA_TRIGGER using the camera_trigger topic.
[ ] Use hrt_call_every instead of work_queue

@LorenzMeier I'm beginning to think if we should use a command to enable/disable the trigger, since a parameter doesn't seem quite right for this application?
We'd want the companion system to enable/disable the trigger at will. Ideally, it would enable the trigger once the cameras + driver is initialised and ready. Then assuming that we don't lose the first frame, it would be possible to synchronise the IMU and camera streams and accordingly compensate for lost image frames (by enabling the image sequence feature on the camera itself)

Nice! Could you rebase against master please?

Upon closer inspection this driver should at least run in the HP work queue, and most likely it should run as HRT callback, as the jitter and timing will be much better in that case. Since that concept is quite similar to a work queue, I recommend doing the change now as it should be fairly easy:
Starting:
https://github.com/PX4/Firmware/blob/master/src/drivers/mpu6000/mpu6000.cpp#L1478-L1479
Stopping:
https://github.com/PX4/Firmware/blob/master/src/drivers/mpu6000/mpu6000.cpp#L1482-L1486
Trace the _call variable in the driver to get a feel for what's required. Note that you can't use printf / warns in interrupt context, but you can use orb_publish() and orb_copy().

I'll get this re-written to C++ which should make everything to much easier. Will take some time though.

@LorenzMeier This isn't working out. Closing for now.


Is println bad?

The default scalastyle config that's provided with it has println flagged as a warning in both the token and regex rules:
 <check class="org.scalastyle.file.RegexChecker" level="warning" enabled="true">
  <parameters>
   <parameter name="regex"><![CDATA[println]]></parameter>
  </parameters>
 </check>

Is this just an example that isn't meant for production use, or is println considered bad?

It is just an example. There is nothing wrong with println.
However, for production code, there are better solutions, for example slf4j or log4j. So, a number of project that I have been involved with discourage the use of println. See, for example http://stackoverflow.com/questions/2750346/logger-vs-system-out-println

@matthewfarwell Thanks.  Good advice.

It is just an example. There is nothing wrong with println.
However, for production code, there are better solutions, for example slf4j or log4j. So, a number of project that I have been involved with discourage the use of println. See, for example http://stackoverflow.com/questions/2750346/logger-vs-system-out-println

There is PrintStream in the standard Java library, it has println in its methods and this check complains about it too. I updated the regular expression for my project:
 <check level="warning" class="org.scalastyle.file.RegexChecker" enabled="true">
  <parameters>
   <parameter name="regex"><![CDATA[(?<!\.)println]]></parameter>
  </parameters>
 </check>

Probably it should be in the scalastyle default configuration: the warning appears only for "bare" println call.