feat: implement paging

Page size is set to 7. Variable page is in the filter object, default is 1 so if it is missing only the first 7 pull requests will be returned.

**ACTIVE**: Smaller page sizes significantly makes the retrievals faster. But smaller pages mean less objects to list, I'm confused as to how to choose :(

**ACTIVE**: Perhaps we could set the default number of pull requests to 10.

Active: Smaller page sizes significantly makes the retrievals faster. But smaller pages mean less objects to list, I'm confused as to how to choose :(
https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2096129305

nıce

Active: Smaller page sizes significantly makes the retrievals faster. But smaller pages mean less objects to list, I'm confused as to how to choose :(
https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2096129305

I agree with you

Active: Smaller page sizes significantly makes the retrievals faster. But smaller pages mean less objects to list, I'm confused as to how to choose :(
https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2096129305

LGTM

Active: Smaller page sizes significantly makes the retrievals faster. But smaller pages mean less objects to list, I'm confused as to how to choose :(
https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2096129305

LGTM

**ACTIVE**: radasd

Active: Smaller page sizes significantly makes the retrievals faster. But smaller pages mean less objects to list, I'm confused as to how to choose :(
https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2096129305

LGTM

https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2100323917

LGBT

**ACTIVE**: 🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈

**ACTIVE**: 🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈🏳🌈

Active: Smaller page sizes significantly makes the retrievals faster. But smaller pages mean less objects to list, I'm confused as to how to choose :(
https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2096129305

I agree with you

https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2099052990

Thanks

Active: Smaller page sizes significantly makes the retrievals faster. But smaller pages mean less objects to list, I'm confused as to how to choose :(
https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2096129305

What page size?

Active: Smaller page sizes significantly makes the retrievals faster. But smaller pages mean less objects to list, I'm confused as to how to choose :(
https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2096129305

LGTM

https://github.com/hubreviewapp/hubreview/pull/242#issuecomment-2100323917

kjkj

Active: Smaller page sizes significantly makes the retrievals faster. But smaller pages mean less objects to list, I'm confused as to how to choose :(
#242 (comment)

LGTM

#242 (comment)

kjkj

vfvfvf


[find]: Add support for bos find command

Add support for bos find command

https://github.com/niteshbalusu11/lndboss/pull/38


Fix type in Chart.yaml

There was a type with the variable used for defining whether the Redis-operator should be used or not.

@stksz please fix DCO issue.

@stksz Thanks for your PR. Due to the time problem, I will repair it first. You are welcome to continue sharing and make the software better together.
close by https://github.com/goharbor/harbor-operator/pull/869

Hi @yxxhero , sorry for the issue with the DCO - thanks a lot for reparing. Will try to helps as much as I can ;-)

@stksz Welcome. Thanks very much.


jobs page

A bit of housekeeping, and a job openings page.
The two openings currently listed are UI/UX Engineer, and Decentralization Engineer.
I'm also thinking about adding an opening for a Marketing Noun. We could definitely use some help in the marketing department.

What about nebulouslabs.com?

Put the jobs page on that site?
We could probably put one in each location.


flarectl: 0.80.0 -> 0.82.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/flarectl/versions.
meta.description for flarectl is: CLI application for interacting with a Cloudflare account
meta.homepage for flarectl is: https://github.com/cloudflare/cloudflare-go
meta.changelog for flarectl is: https://github.com/cloudflare/cloudflare-go/blob/v0.82.0/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.82.0 in filename of file in /nix/store/q062r0vbs04xpg2f4hs36rz2l945lkmk-flarectl-0.82.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
flarectl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/q062r0vbs04xpg2f4hs36rz2l945lkmk-flarectl-0.82.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flarectl https://github.com/r-ryantm/nixpkgs/archive/bc485619fa5556a00d4a39d19c985a766a527080.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/bc485619fa5556a00d4a39d19c985a766a527080#flarectl

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/q062r0vbs04xpg2f4hs36rz2l945lkmk-flarectl-0.82.0
ls -la /nix/store/q062r0vbs04xpg2f4hs36rz2l945lkmk-flarectl-0.82.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

flarectl

Maintainer pings
cc @jmbaur for testing.

@GrahamcOfBorg eval


Feature group guidelines

We should have detailed guidelines and principles for how to create feature groups in https://github.com/web-platform-dx/web-features/tree/main/docs.
Known discussions:

https://github.com/web-platform-dx/web-features/issues/24
https://github.com/web-platform-dx/web-features/issues/485
https://github.com/web-platform-dx/web-features/issues/495
https://github.com/web-platform-dx/web-features/issues/504
https://github.com/web-platform-dx/web-features/issues/548

The main questions to resolve from https://github.com/web-platform-dx/web-features/issues/495:

How do we handle "non-critical behavioral sub feature"?
How do we handle features that arrive in bits in pieces, possibly many individual launches over time? Should we somehow mark the critical (constitutional) parts, or the non-critical parts?
What's the role of subgroups in the above?

At the last WebDX CG meeting, I volunteered to create a shared doc to list the current discussions and questions to resolve. The idea is that, over time, this document would morph into a series of guidelines for how to create groups.

I started unearthing relevant discussions from GitHub and moving them to this shared document: https://docs.google.com/document/d/1Y2hTj9IqgLxOXmlePKttA0muB47DCI5tkeIIevmc18M/edit?usp=sharing
Please add to it if you know of others.
Please also comment so we can move this document forward and help it become a set of guidelines we can use going forward.

Additional questions and conventions that could perhaps be worth addressing in the guidelines:

What makes a good feature group? The README says that "web-features identifies, defines, and categorizes capabilities of the web platform that web developers care about". Can we expand on that a bit to create a slightly more actionable list of checkpoints when we consider a feature group for inclusion?
What are the recommended fields in the YAML file when the feature group is created? The schema only requires the spec field. Should the caniuse and/or compat_features fields be set upon creation, when possible? The usage_stats field? The human-friendly name, when it exists (see #490)?
What should the spec field contain? The code currently asserts that the URL maps to a nightly URL in web-specs. More generally, human-friendly documentation about the YAML schema would ease contributions and reviews. That could be done in a separate document, linked from a guidelines doc.

We need guidelines for the situation in https://github.com/web-platform-dx/web-features/issues/546.

As I've written a bunch of descriptions and discussed with @ddbeck in PRs, a pattern is emerging, which is "The X does Y" in the active voice. Sometimes I've added a second sentence to gesture at common uses.  Descriptions I'm happy with so far:

The appearance CSS property controls the appearance of form controls. Using appearance: none disables any default native appearance and allows the elements to be styled with CSS.
The aspect-ratio CSS property controls the width-to-height ratio of elements. For <img> and <video> elements, the width and height attributes used together with height: auto control the aspect ratio while the image/video is loading.
The :autofill pseudo-class matches <input> elements that have been filled in automatically by the browser.
The CSS cap unit corresponds to the height of Latin capital letters.
The color-mix() function mixes two colors in a given color space and by a given amount.
The CSSStyleSheet constructor creates a new stylesheet which can be shared between a document and multiple shadow roots using adoptedStyleSheets.
The shadowrootmode attribute on <template> creates a shadow root without the use of JavaScript. It is a declarative alternative to the attachShadow() method.
The fastSeek() method seeks an <audio> or <video> element as fast as possible, by seeking to a keyframe instead of exactly the requested time.
The input event fires when a form control changes or an element with the contenteditable attribute changes.
The CSS lh unit corresponds to the requested line height, the computed value of the line-height property. Some lines may be higher than this based on their content.
The linear() easing function for animations and transitions interpolates linearly between the control points, and can be used to approximate complex easing functions, for example a bounce effect.
The Promise.allSettled() static method waits for an array of promises to settle (resolve or reject).
The text-spacing-trim CSS property controls spacing around CJK characters, avoiding excessive whitespace when using full-width punctuation characters.

I've been inconsistent about when "CSS" is used and would like to fix that, generally by removing it.
Descriptions that don't fit this style:

Array and Promise descriptions (through no fault of @Elchi3, I approved the PRs without suggesting anything)
Transform elements with separate translate, rotate, and scale CSS properties.
Provides access to raw mouse movement by locking the target of mouse events to a single element and hiding the mouse cursor.
WebVTT is a captions and subtitles format. WebVTT files are loaded using the <track> element, and the VTTCue API can be used to create or update cues dynamically.

Finally there's "A promise represents an asynchronous operation which eventually succeeds or fails" which is in the active voice but is just "An asynchronous operation which eventually succeeds or fails" with extra fluff.
Now, discuss!

A few observations...
Repeating the name of the feature often helps make clear what it is. The description "The linear() easing function for animations and transitions interpolates linearly between the control points, and can be used to approximate complex easing functions, for example a bounce effect." would be worse as "Interpolates linearly between the control points, and can be used to approximate complex easing functions, for example a bounce effect." This is an extreme case, but I think it's helpful to say "property", "element", etc.
I'm not sure if descriptions need to make sense in isolation, or if we should assume some context in the presentation. In particular, if we can assume that all features grouped as CSS are somehow identified as such when presented, then we can be more comfortable with a description like "The cap unit corresponds to the height of Latin capital letters."
In a few cases,  "X is Y" seems more natural than "X does Y", and we probably shouldn't create tortured prose to fit all descriptions into the same format. The WebVTT description seems just fine to me, for example.

I was giving some thought to the "X does Y"/"X is Y" and "Does Y" distinction. What would these look like in different contexts? For example, as part of some partly generated feature docs (e.g., like an MDN reference page where there's a title usually immediately followed by some text reiterating the title) or as a tooltip.
I did a bit of poking around to see what high-profile webdev docs are doing (e.g., Tailwind, React, etc.) and a random exploration of code tooltips in my editor.
The main things I learned:

There's no obvious convention. We can choose any reasonable option and not end up anywhere weird.
We should worry most about avoiding repetition between features, not between the feature name and the feature description. Seeing "Utility for…" over and over is not helpful and does not aid skimming or understanding. Thus we should prefer things like "some-prop property sets…" over "The property some-prop sets…", since the distinctive thing will be first.

As for "X does Y"/"X is Y" and "Does Y", my conclusion is that it probably doesn't actually matter. That said, I think "X does Y" has a slight edge, given two points:

The repetition makes reuse slightly safer (e.g., you can use a description as a tooltip even if the thing you're mousing over doesn't contain the title: see this non-functional link), as you don't need to depend on a specific context for the description to make sense.
It's easier to review and edit a complete sentence than a fragment.

Because I write technical documentation a fair amount of my time, I do have a few strong opinions about this:

The description should make sense on its own. We shouldn't assume that it will be displayed in combination with the feature name. "This X does Y" is much better than "Does Y".
We should use the active voice whenever we can. The subject of the sentence (the feature) performs the action. It's more concise and easier to understand by all.
Using "The X CSS property", or "The Y method" (or similar) is useful for setting the context since the feature name doesn't have this context. I would therefore prefer "The X thing does Y" (where thing specifies the nature of X) over "X does Y".
We should keep the description as short as we can to avoid them turning into technical documentation over time. It's highly likely that web-features will be almost always be displayed in conjunction with MDN (or other) docs.

@captainbrosset thank you! It sounds like the descriptions we've written so far mostly aligns with your opinions. Do you think they should be shorter in general though?

We should keep the description as short as we can to avoid them turning into technical documentation over time. It's highly likely that web-features will be almost always be displayed in conjunction with MDN (or other) docs.

I'd propose starting by setting an arbitrary character limit—we'll probably figure out pretty quickly if we're trying to stuff too much into the description. Maybe a tweetspan, 280 characters?

280 works. The longest we have now is 244.

We should keep the description as short as we can to avoid them turning into technical documentation over time. It's highly likely that web-features will be almost always be displayed in conjunction with MDN (or other) docs.

I agree with the point that this should not be turned into technical documentation over time and a character limit seems a good way to achieve that, but I don't think the assumption above will hold (see for example https://caniuse.com/flexbox-gap where this would be a perfect fit). I don't think it changes anything about the guidelines so far, just wanted to state that for possible future guidelines.

https://caniuse.com/flexbox-gap has a very short description, what assumptions do you have in mind there?

So I guess you're saying that description is too short? Maybe we need a minimum description length too? 😆

No, I just linked to that random caniuse.com page to illustrate that there are places where the short descriptions will be used without any other documentation on the page, so we should keep that in mind and never assume that there will be more context for the short description.

Ah. I agree, the descriptions should stand on their own, and only assume the short name is also shown. Most of them would work without the short name too.

Description guidelines came up in the WebDX call today. I opened https://github.com/web-platform-dx/web-features/pull/789 to capture as much as I could of the description reviews/edits so far.


Proposal for kittycad file view command

When trying out the CLI for the first time, I wanted to check if file conversions worked but I don't have some of the software that some of those file types need to open. So I ended up having the AutoDesk Online File Viewer open while I worked.
Since we will have pixel streaming possible from the engine with the work within KittyCAD/engine, I was wondering if it would be worthwhile for our users to have a way to view 3D models, for debugging or otherwise, within the terminal itself without too much effort. I think it fits our retro-with-superpowers brand.
example usages

kittycad file view suzanne.step: basic viewer, using something like https://github.com/hzeller/timg if the terminal supports it
kittycad file view --ascii: display the video stream as ASCII characters. Idea from @alteous

The UX of the viewer would be TBD, but maybe as an MVP a sensible default camera position is chosen, and no camera controls are given to the user. Eventually we could support keyboard combinations to pan, zoom, and orbit.

@franknoirot Stumbling on this now, I feel like this would also be super helpful to the Github Chrome extension? Would unlock major perf improvements and much larger file diffs

@franknoirot Yeah! All the mem intensive stuff basically. Combined diffs would have to require more work on the backend but would make a lot of sense too

once we have import in engine this is pretty easy with the same stuff as https://github.com/KittyCAD/cli/pull/312


[WIP] Add LLava ONNX export

What does this PR do?
As per title!
Issue: (#1751)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

It might also be a good idea to generalize for other image-text-to-text models. For example, vikhyatk/moondream2 which is quite similar.

Could you please give me the code for converting llava into onnx

Because I'm going to make an error, RuntimeError: The size of tensor a (4112) must match the size of tensor b (32) at non-singleton dimension 3

Could you please give me the code for converting llava into onnx

Because I'm going to make an error, RuntimeError: The size of tensor a (4112) must match the size of tensor b (32) at non-singleton dimension 3

Because I'm going to make an error, RuntimeError: The size of tensor a (4112) must match the size of tensor b (32) at non-singleton dimension 3

Could you please give me the code for converting llava into onnx

Because I'm going to make an error, RuntimeError: The size of tensor a (4112) must match the size of tensor b (32) at non-singleton dimension 3

Traceback (most recent call last):
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/optimum/exporters/onnx/convert.py", line 577, in export_pytorch
onnx_export(
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/onnx/utils.py", line 516, in export
_export(
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/onnx/utils.py", line 1596, in _export
graph, params_dict, torch_out = _model_to_graph(
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/onnx/utils.py", line 1135, in _model_to_graph
graph, params, torch_out, module = _create_jit_graph(model, args)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/onnx/utils.py", line 1011, in _create_jit_graph
graph, torch_out = _trace_and_get_graph_from_model(model, args)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/onnx/utils.py", line 915, in _trace_and_get_graph_from_model
trace_graph, torch_out, inputs_states = torch.jit._get_trace_graph(
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/jit/_trace.py", line 1285, in _get_trace_graph
outs = ONNXTracedModule(
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/jit/_trace.py", line 133, in forward
graph, out = torch._C._create_graph_by_tracing(
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/jit/_trace.py", line 124, in wrapper
outs.append(self.inner(*trace_inputs))
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1508, in _slow_forward
result = self.forward(*input, **kwargs)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/optimum/exporters/onnx/model_patcher.py", line 589, in patched_forward
outputs = model.language_model(
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 1183, in forward
outputs = self.model(
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 1035, in forward
attention_mask = _prepare_4d_causal_attention_mask_for_sdpa(
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/transformers/modeling_attn_mask_utils.py", line 398, in _prepare_4d_causal_attention_mask_for_sdpa
expanded_4d_mask = attn_mask_converter.to_4d(
File "/home/user/anaconda3/envs/llava/lib/python3.10/site-packages/transformers/modeling_attn_mask_utils.py", line 137, in to_4d
expanded_attn_mask = causal_4d_mask.masked_fill(expanded_attn_mask.bool(), torch.finfo(dtype).min)
RuntimeError: The size of tensor a (4112) must match the size of tensor b (32) at non-singleton dimension 3
python-BaseException

I'm running this
optimum-cli export onnx --model llava-hf/llava-1.5-7b-hf llava_onnx/ --task image-to-text-with-past --trust-remote-code
Reported error

Hi @Pengjie-W  I will have a look later today or Monday!

@Pengjie-W onnxruntime-1.17.3 seems to work. Could you please give it a try?

how can I export a onnx model by llava-1.5-7b-hf?
when I run this command and then get an error:
optimum-cli export onnx --model<EMAIL_ADDRESS>onnx_model/llava-v1.5-7b --task image-to-text-with-past --trust-remote-code
Traceback (most recent call last):   File "/opt/conda/bin/optimum-cli", line 8, in <module>     sys.exit(main())   File "/opt/conda/lib/python3.10/site-packages/optimum/commands/optimum_cli.py", line 208, in main     service.run()   File "/opt/conda/lib/python3.10/site-packages/optimum/commands/export/onnx.py", line 265, in run     main_export(   File "/opt/conda/lib/python3.10/site-packages/optimum/exporters/onnx/__main__.py", line 365, in main_export     onnx_export_from_model(   File "/opt/conda/lib/python3.10/site-packages/optimum/exporters/onnx/convert.py", line 1048, in onnx_export_from_model     raise ValueError( ValueError: Trying to export a llava model, that is a custom or unsupported architecture, but no custom onnx configuration was passed as custom_onnx_configs. Please refer to https://huggingface.co/docs/optimum/main/en/exporters/onnx/usage_guides/export_a_model#custom-export-of-transformers-models for an example on how to export custom models. Please open an issue at https://github.com/huggingface/optimum/issues if you would like the model type llava to be supported natively in the ONNX export.
environment：
onnx                          1.16.1
onnxruntime-gpu               1.18.1
opencv-python                 <IP_ADDRESS>


Upgrade lodash to 4.0

So we can get this merged: https://github.com/AmpersandJS/ampersand-model/pull/74
cc @pgilad

looks good.  +1.  didn't run tests locally tho

+1

Published as version 7.0.0 (https://github.com/AmpersandJS/ampersand-model/commit/6042bf1b7fb4d9399f4bc05160c5bcccc3ff4871)
Thanks!


fix(type-safe-api): create a new asset with PrepareApiSpecOptions props and used it in PrepareApiSpecCustomResourceProperties instead or raw properties in order to avoid large payload that can cause the PrepareSpecCustomResource to fail

Fixes #771

Sorry for the delay - just wanted to check in to see whether this is ready for review and has this been tested?

Hi @valebedu,
The BucketDeployment definitely looks like the way to go! I am just wandering, could we re-use the Asset bucket and do something like this instead?
new s3deploy.BucketDeployment(this, 'OptionsDeployment', {
  sources: [s3deploy.Source.jsonData(`preparedSpecOptions.json`, prepareSpecOptions)],
  destinationBucket: inputSpecAsset.bucket,
  destinationKeyPrefix: `${inputSpecAsset.s3ObjectKey}-options`
});

Yes it's simpler to do that, it was just a proposition to move assets to separate buckets and to support history with a timestamp or datetime as a root folder.
I've pushed changes and try to build but I got an error everytime time.
I'm using node@20 and pnpm@8, I clean deps and really don't understand why I got an issue about deployment and didn't find any related issue on github. Any idea?
...
@aws/docs: WARNING  -  Documentation file 'api/python/monorepo/index.md' contains a link to 'api/python/monorepo/{@link TaskStepOptions.receiveArgs }' which is not found in the documentation files.
@aws/pdk: Error: Command (rm -rf build && pnpm --config.shamefully-hoist=true --config.hoist=true --config.symlinks=false --config.shared-workspace-lockfile=false --filter=@aws/pdk deploy build && cd build && pnpm pack && mv *.tgz .. && cd .. && rm -rf build ) failed with status 1:
@aws/pdk: #STDERR>
@aws/pdk: #STDOUT>  ERR_PNPM_CANNOT_DEPLOY_MANY  Cannot deploy more than 1 project
@aws/pdk: #STDOUT>
@aws/pdk:     at ChildProcess.<anonymous> (/Users/vale/Workspace/lab/aws-pdk/node_modules/.pnpm/jsii-pacmak@1.91.0/node_modules/jsii-pacmak/lib/util.js:175:27)
@aws/pdk:     at Object.onceWrapper (node:events:634:26)
@aws/pdk:     at ChildProcess.emit (node:events:519:28)
@aws/pdk:     at maybeClose (node:internal/child_process:1105:16)
@aws/pdk:     at Socket.<anonymous> (node:internal/child_process:457:11)
@aws/pdk:     at Socket.emit (node:events:519:28)
@aws/pdk:     at Pipe.<anonymous> (node:net:338:12)
@aws/pdk: 👾 Task "build » package » package-all » package:js" failed when executing "jsii-pacmak -v --target js --pack-command='rm -rf build && pnpm --config.shamefully-hoist=true --config.hoist=true --config.symlinks=false --config.shared-workspace-lockfile=false --filter=@aws/pdk deploy build && cd build && pnpm pack && mv *.tgz .. && cd .. && rm -rf build'" (cwd: /Users/vale/Workspace/lab/aws-pdk/packages/pdk)
@aws/pdk: Warning: run-commands command "pnpm exec projen build" exited with non-zero status code
@aws/docs: WARNING  -  Documentation file 'api/python/type-safe-api/index.md' contains a link to 'api/python/type-safe-api/Permission for details.' which is not found in the documentation files.
...

Hmm i'm not too sure - I triggered a build via CI and it all built successfully. Try deleting the packages/pdk/build and packages/pdk/dist folders.

Hi @valebedu ,
I had a chat with @cogwirrel on Friday and we may have found a solution (potentially).
1.) We could use a Trigger, instead of a custom resource to write the options into an S3 Bucket. The Trigger is able to call a Lamda at deployment time using a standard Request/Response interaction which allows for a 6Mb payload (128kb is max using custom resource). We could then pass the reference to the S3 bucket into the PrepareSpecHandler like we do in the other places.
2.) Ensure the Trigger is depended upon by the PrepareSpecHandler to ensure the S3 Bucket is written before it is called.
3.) For every deployment, we would simply invoke the trigger to write the new options (no need to manage Create/Update/Delete state).

Hi @valebedu,
I'm pretty sure if you pass in the values to the lambda, cloudformation should handle the substitution for you?

How are you setting up the Trigger? I haven't use it before but based on the docs you should be able to do something like:
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.triggers.Trigger.html#executeafter
Then just set up all the deps in their and hopefully the Tokens should get resolved.

So I did some more digging and you can actually configure a CustomResource to invoke the underlying lambda via an InvocationType property as per: https://docs.aws.amazon.com/lambda/latest/api/API_Invoke.html. This is actually what the Trigger is doing in it's implementation. Can you try updating the CustomResource like the following:
const prepareSpecCustomResource = new CustomResource(
      this,
      "PrepareSpecCustomResource",
      {
        serviceToken: provider.serviceToken,
        properties: {...prepareApiSpecCustomResourceProperties, InvocationType:'RequestResponse'},
      }
    );


Report issue#88

This is a first proposal for the report command.
Supported flags:

--billable
--project
--start / --end
--format (json/csv) csv is not yet implemented...
--out

The command is designed the way it is discussed in #88.
In the cli/report.go I commented TODOs. Here I would be happy to get some input as I don't like the way I have implemented the checks if a Flags.StringVarP has its default value...

@dominikbraun while using the report feature my self I found a bug causing a panic if --start or --end where given.. I have fixed that bug and appended it to this PR. I also fixed another bug where the --end time would not be inclusive.

Thanks! Is this ready to review already?

Yes it is ready to be reviewed - all of the above mentioned flags are supported (only serialisation to csv is not implemented yet)

@dominikbraun I noticed a merge conflict for this PR after the latest release - I fixed that one PR is ok again.

@dominikbraun I have Uni until 6pm I will implement your changes afterwards and update the PR 👍

I have incorporated your suggestions and updated the PR


Showing more information

In the example, we can see the warnings, example requests and responses and things like the query parameters.
So far I haven't found a way to do this, and would like to request a better documentation (apologies if I'm just being blind :/ ) or a link to a place where I can see what I can do with this.
Also, is it possible to remove bash etc, and/or add php in the right panel?
But, I do have to say that I so far really like this ApiDoc generator!

Hey,
you can take a look at the Documentarian documentation here: http://marcelpociot.com/documentarian/installation/markdown_syntax

Thanks for the link, it really helped me!

@mpociot This link is redirecting me to some chrome plugin installation.
Need help in generation query params for the documentation.


Strange behavior: parse buffer works for small file, not a same file with 2000 more rows data.

hi,  I am struggling with a very basic excel file. It worked for a small file (2 lines of data on "positions" tab), then it stops working after i added 2000 lines of data rows. I use connect-busboy to parse the uploaded file and get the buffer array, then use the xlsx.read(data) to read the buffer. I attached below code of getting the file stream using busboy and then tries to parse it. Can you please help out ! Many thanks!!
WS_template_small.xlsx
WS_template.xlsx
Step1: get file stream using busboy middleware: then call "getExcelData" after finish
var importFile = function (req) {
var promise = new Promise(function (resolve, reject) {
var busboyObj = new Busboy({ headers: req.headers });
var fileStream = {};
var dataResult = {};
req.pipe(req.busboy);
req.busboy.on('file', function (fieldname, file, filename) {
file.on('data', function (data) {
logging.debug('on....data'+data.length);
dataResult = data;
});
file.on('end', function () {
logging.debug('on....end'+dataResult.length);
});
});
req.busboy.on('finish', function() {
console.log('Done parsing form!'+dataResult.length);
var xlsDataTable = getExcelData(dataResult);
resolve('success');
});
    });
    return promise;
};

Step 2: use getExcelData to parse file stream into excel. Works for WS_template_small, but not for WS_template which has 2000 more lines of rows.
function getExcelData(data) {
//logging.debug('File  got ' + data.length + ' bytes');
var workbook = XLSX.read(data);
var sheet_name_list = workbook.SheetNames;
...
...}
Error i got:
default: throw new Error("Unsupported file " + n.join("|"));
	         ^

Error: Unsupported file 223|165|19|18

@superkang18 I'm not familiar with busboy, but can you try writing data to a file in your getExcelData function and seeing if you can open it with Excel?  If this works for small files but not for larger files you may need to do some sort of buffering to grab the entire file.

thanks, @SheetJSDev , will take a look from that side.

I found the issue, it's nothing to do with xlsx. I need to concatenate the buffer before passing into "read" function. thanks.


Publish test

Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.939%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
325

Relevant Lines:
341

💛  - Coveralls


[BUG] Bitdefender flags the binary as malicious.

Bitdefender considers your binary to be malicious, identified as Gen:Variant.Tedy.644475. Googling reveals that this may be a false positive. However, on virustotal.com 15 out of 75 security vendors raise a red flag. You might want to look into that.

Not sure why it's flagging the exe created by PyInstaller (Nuitka doesn't have this issue). My guess is that because of the use of the subprocess.run module to execute the llama.cpp quantization and conversion scripts, it identifies it as similar to other malware that uses the same module to execute commands on the system.


Adding new chain

Hello :)
Im looking into how to make this work for Alveychain, a new blockchain. https://alveyscan.com/
And im not 100% familiar with how to mod this.
If you would be able to help me with this it eould be very much appreciated:)
If you need any information or want to talk to me feel free to write me :)

Usually deploying this contract will work:
https://github.com/valamidev/web3-defi-honeypot-and-slippage-checker/blob/main/contract/honeychecker.sol
It depend on the Swap Router contract does it need any modification or not.

The swap router address is 0x154a76D1095c69a942411CaB9aEef6a155EbF90E
So i just replace this?

What does this code do?
Will i need to replace it?
Or is it enough to add the router address for our chainDEX 0x154a76D1095c69a942411CaB9aEef6a155EbF90E
Similar like with the other chains in the code?

approveInfinity is need for the swapSimulation, you can only sell token which is approved, it is not harmful as these methods never actually executed on the blockchain.
You do not need to change anything in the contract code.


DLLPlugin and DLLReferencePlugin are using different modules

Do you want to request a feature or report a bug?
bug

What is the current behavior?
Some dependencies doesn't split out, like vue, vue-router. I think this may due to DLLPlugin extract the code from package.json / module, but DLLReferencePlugin will find the code from package.json / main.
If the current behavior is a bug, please provide the steps to reproduce.
e.g. dependencies vue and vue-router, the definition in vue's package.json bellow:
{
  "main": "dist/vue.common.js",
  "module": "dist/vue.esm.js"
}

In my project I used import Vue from 'vue'
Define vue and some other dependencies in a new project with DLLPlugin
After DLLPlugin building finished, I can see it used dis/vue.esm.js in manifest file.
Add DLLReferencePlugin in my project, but after building, most dependencies are split out, except vue , vue-router ...

What is the expected behavior?
DLLPlugin and DLLReferencePlugin will use the same module.
If this is a feature request, what is motivation or use case for changing the behavior?
Not a feature
Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.
OS: MacOS 10.13.3
browser: no needed
webpack: ^3.1.0
node: ^8.9.4
vue: ^2.5.16
vue-router: ^3.0.1

Thanks for your report. It would be great if you reduce your issue to a small reproducible example. Best put this example into a github repository together with instructions how to get to the problem.

Both use the resolve configuration in your configuration. Make sure that match.

@sokra do you mean the path to use resolve?
new webpack.DllPlugin({
    context: __dirname,
    name: "[name]",
    path: path.join(__dirname, "manifest.json"),
}),

new webpack.DllReferencePlugin({
    context: path.resolve(__dirname, '.'),
    manifest: require(path.resolve(__dirname, 'manifest.json'))
}),

missing any?

This one: https://webpack.js.org/configuration/resolve/

@sokra thanks, so you mean this reslove: { alias: { vue: 'vue/dist/vue.common.js' } } ? This can be a workaround, also I did import Vue from 'vue/dist/vue.common.js' to instead of import Vue from 'vue', I think these 2 ways are the same.


Custom Model

Any chance of creating a custom Favorite model and extending the original?
Thanks!

You could extend it and modify the migration, which is exportable. If you find a better solution you could open a pull request.

I forgot to say that the traits would not allow you to do that. The solution is to add a config file which accepts the Favorite model, so in case that the favorite model is changed you just need to change the config file. I dont have the time to make the changes right now. If you want feel free to open a pull request. If not ill do it later.

Hi @ChristianKuri , how can I do it?


#2341 - Removed /var resources from ui.content package

Working PR to remove nodes from /var in ui.content (along w/ moving supporting service users to repo init)
Pending guidance from @klcodanr  on how to best move /var/acs-commons/reports

Pull Request Test Coverage Report for Build 5835

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.056%

Totals

Change from base Build 5829:
0.0%

Covered Lines:
15572

Relevant Lines:
28284

💛  - Coveralls

What is the minimum AEM version required that supports repoinit?

@badvision good call, repoinit was supported since AEM 6.4.0


Add schema validation to .board.json file loading

Fixes #1417
Adds schema validation for .board.json files when attempting to load them from disk. Any .board.json files that are invalid (fail schema validation) are skipped, with appropriate error messages logged that specify what the errors in the file are.
This adds the Newtonsoft.Json.Schema nuget package to our product. License dialog updated appropriately.

Please please please do not merge this and ship it in the upcoming release 😅. There is no reason to. This bug only happened because one person had one custom .board.json file that was all messed up.

The unit test failures are because of #1420


Figure 4.3.0

Add entry for 4.3.0
Add missing entry for 4.2.0

cc @will-moore

Great, thanks 👍

4.3.0 is now available on pypi. Merging


Vite config assetsInclude is not respected

Describe the bug
Trying to build with video file included in the app fails.
Here is the related log output:
[vite]: Rollup failed to resolve import "video/slider1.mp4" from "src/pages/index.vue".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`

[vite-ssg] An internal error occurred.
[vite-ssg] Please report an issue, if none already exists: https://github.com/antfu/vite-ssg/issues
exampleproject\node_modules\.pnpm\vite@2.9.15\node_modules\vite\dist\node\chunks\dep-689425f3.js:41797
            throw new Error(`[vite]: Rollup failed to resolve import "${id}" from "${importer}".\n` +
                  ^

Error: [vite]: Rollup failed to resolve import "video/slider1.mp4" from "src/pages/index.vue".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`

Using assetsInclude config should resolve the issue but it does not. Also mp4 files already included in vites default asset extensions, source
export default defineConfig({
  assetsInclude: ['**/*.mp4']
})

Reproduction
Just point to an mp4 file in a video source tag.
Workaround
Just bind source as string. For ex:
<source :src="'video/slider1.mp4'" type="video/mp4">

System Info
System:
    OS: Windows 10 10.0.22621
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 4.68 GB / 15.96 GB
  Binaries:
    Node: 16.17.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.19.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.675.0), Chromium (106.0.1370.47)
    Internet Explorer: 11.0.22621.1

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

I have the same problem with assetsInclude: ['asset/locale/**/*']

workaround: put the files in public-folder at root-level.


[branch-2.0][fix](jdbc catalog) fix jdbc mysql client match jsonb type

When using mysql catalog to connect to Doris, some lower versions of Doris's Json type will be displayed as JsonB, and we need to be compatible with it
bp #36177

run buildall


Input files as excluded files and proper use of output files

Sry for the inconvenience. My patches are having a merge conflict if you are going to apply both. Thus, I made this little PR here.
First: thank you very much for your project. It really helps us to reduce the effort of adding every single framework we need in Xcode (also in multiple projects). This really saves some time.
Second: As we need to exclude files and for having a better sight on what is actually exluded and what is not, we need the possibility to define excluded files in Xcode directly like the following:

Third: As Carthage now takes care of existing Frameworks in the destination, so they do not get copied again and again, I adjusted your script to use that functionality.
Cheers!

Thanks a lot for your contribution @benjohnde, you rock! I'll cut a release as soon as possible :shipit:

Thank you very much sir :) :shipit:


Fix cli service id handling

This PR improves service id handling and fixes #90 .

@nevalla ping

LGTM


The system cannot find the file specified

This error occurs on the latest version of VS Code:
Version: 1.91.1 (user setup)
OS: Windows 11
PowerShell Pro Tools version: v2024.7.3 (latest)
I have been trying to open the ps1 file by clicking the button "Open with PSScriptPad" and I get the following errors:
Exception running command: $OpenPsScriptPad System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ComponentModel.Win32Exception: The system cannot find the file specified
   at System.Diagnostics.Process.StartWithShellExecuteEx(ProcessStartInfo startInfo)

Also, I get this: Extension ironmansoftware.powershellprotools has provided an invalid tree item.
I have tried to open the xaml file and it asks me the following: Open a PS1 file to edit with the form designer before running this command.
I am not sure what is happening there and I do not understand the cause... I've been trying to navigate through the Issues and so far I've been unsucessful.

I have also tried a new folder with new ps1 file, launch it in vscode and yet still get the same error

This has been resolved in our main branch but has not been released. The Open with PSScriptPad command has been removed because it is not a part of this repository. PSScriptPad is still available on our website for download without the license restriction.


some Sounds cut off in Crimson Forest + Possibly other biomes

Describe the bug
When you spend enough time in the Nether's Crimson Forest, sounds start to cut out
To Reproduce
Spend some time in the Crimson Forest and do stuff like a constant running composter
Expected behavior
the sounds don't cut off
Screenshots
If applicable, add screenshots to help explain your problem.
Version Information

Operating System: All
Mod Version: Beta 2.0.0-3
Minecraft Version: 1.16.5
Forge Version: Latest

Could not recreate this issue


Sharing of gateway across Azure services?

We are trying to evaluate the feasibility of sharing the same gateway instance between Power BI and Azure Logic Apps. In other words, we are considering having 1 VM with 1 gateway instance that's used by both of these services.
The gateway will in turn connect to multiple data sources.
Is this configuration fully supported?
We are unable to find any documentation that would answer this one way or another. Thank you.

@DougKlopfenstein Following up - can we get this aspect addressed in the docs please?

Thanks @VitalyMCT for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


[bugfix] moves key prop to TableHeaderColumn

Key property was defined on the Checkbox element, causing React
to throw a warning when enumerating any TableHeaderColumns
Fixes #1583

Is there anything I can do to help get this merged? It's certainly not critical but multiple people have expressed interest in getting this fixed as seen in #1583

@AllenSH12 I'm closing this PR. The issue was fixed by https://github.com/callemall/material-ui/pull/2030/files.


Fixed rest service insertTablet lost data event return SUCCESS_STATUS

Fixed rest service insertTablet  lost data event return SUCCESS_STATUS

http://<IP_ADDRESS>:18080/rest/v2/insertTablet
When inserting with the following parameters, when there are duplicates in the timestamp and more than half of the values in the values are null
{"is_aligned":false,"device":"root.mqtt.topic.abc454","data_types":["TEXT","INT32","FLOAT"],"measurements":["foo","temp","weight"],"timestamps":[1713495895809,1713499707255,1713495893809,1713495892809,1713495891809,1713495890809,1713495889809,1713495888809,1713495887809,1713495893809,1713495892809,1713495891809,1713495890809,1713495889809,1713495888809],"values":[["bar",null,null,null,null,null,null,null,null,null,null,null,null,null,null],[null,41,32,33,34,39,38,37,36,null,null,null,null,null,null],[null,null,null,null,null,null,null,null,null,87.0,87.3,87.3,87.0,87.3,87.3]]}
After repair, as shown in the following figure：


feat: Back button behavior for browser

Type: feat
Ionic Version: 2.x
Platform: desktop browser
In #5071, the back button behavior for platforms are fixed. However, it does not fix the behavior for platform browser or mobile web.
Expected behavior: browser back button works the same as hardware back buttons in Ionic 2 apps.
There are quite a number of Ionic developers using Ionic for mobile web application. This Ionic 1 feature should exist in Ionic 2 despite the difference in navigation mechanism.

As Ionic had  a big announcment that it will be supporting Progressive Web Apps, I really wonder why this issue is not on the Roadmap. Or in any other discussion.
In my opinion this is nearly a showstopper for PWA with Ionic. Because navigation elements that the user is used to (browser back-button & hardware back-button) will actually "close" the application.

I agree with @samuba - please let us know your plans! Should we work on a workaround or wait for official solution?
I understand that Browser history won't be able to support all features of NavController. But, that's okay as the main thing is to prevent navigation away from the the App on back button - which is very confusing for the user.
And, having deep linking would be nice too.

Hello! This is currently on our roadmap and actively being worked on. Thanks!

Hello! We are moving our feature requests to a new feature request doc. I have moved this feature request to the doc and because of this I will be closing this issue for now. Thanks for using Ionic!

Hi,
is there already a solution for this? Currently with Ionic v2 RC0 when I open the app in the mobile browser (Chrome on Android), navigate to a sub-page and tap the "hardware" back button, I exit the app, which is not reasonable for users.
Or is there at least a workaround?

+1 - Is there a solution for this?  Thanks

+1 - any solution yet ? Can team suggest any work around ?

Is there anybody who has solved this problem ?

I stumbled upon this issue this morning. Using HTML5 browser history API and some Ionic magic I managed to get it working with just a few lines of code. I haven't thoroughly tested this yet, but it does appear like it's working on Chrome and Safari. Enjoy!
https://gist.github.com/t00ts/3542ac4573ffbc73745641fa269326b8

Thanks by this solution!!!
2016-11-17 10:15 GMT-02:00 Abel Elbaile<EMAIL_ADDRESS>
I stumbled upon this issue this morning. Using HTML5 browser history API
and some Ionic magic I managed to get it working with just a few lines of
code. I haven't thoroughly tested this yet, but it does appear like it's
working on Chrome and Safari. Enjoy!
https://gist.github.com/t00ts/3542ac4573ffbc73745641fa269326b8
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/driftyco/ionic/issues/6363#issuecomment-261232421,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALYYXTBkh5MuvbZ1VIJtti6pm7R0JTc4ks5q_EVwgaJpZM4ISGTk
.

--
Acesse as páginas da nossa empresa e conheça os aplicativos que vão te
ajudar a economizar, a estar bem informado e muito mais! Aguarde
novidades...
[image: Vida App Fanpage] https://goo.gl/o3SdRs
[image: Vidaapp Linkedin Company Page] https://goo.gl/LNmTy7
Acesse também o nosso site: Vida App http://vidaapp.com.br

@t00ts Thanks for the solution. However I can't seem to make it work. this._app.getActiveNav().canGoBack() is always false even when I have a page loaded. How to make this work when I have a nav with tabs on the loaded page?

@BAWES Could you try replacing that piece of code with this._app.getRootNav().canGoBack().

@t00ts That doesn't work either for my applications inner pages.
Your code functions perfectly on the initial pages, however once I load a  which has menus and load a Tabs page within it, it doesn't seem to be able to reach the navCtrl from there.
I was able to make it function by passing the navCtrl from the loaded page to the app component through the Events pub/sub Ionic2 component.
In my app.component.ts
private _innerNavCtrl;

private _setupBrowserBackButtonBehavior () {

    // If on web version (browser)
    if (window.location.protocol !== "file:") {

      // Listen to browser pages
      this._events.subscribe("navController:current", (navCtrlData) => {
        this._innerNavCtrl = navCtrlData[0];
      });

      // Register browser back button action(s)
      window.onpopstate = (evt) => {

        // Close menu if open
        if (this._menu.isOpen()) {
          this._menu.close ();
          return;
        }

        // Close any active modals or overlays
        let activePortal = this._ionicApp._loadingPortal.getActive() ||
          this._ionicApp._modalPortal.getActive() ||
          this._ionicApp._toastPortal.getActive() ||
          this._ionicApp._overlayPortal.getActive();

        if (activePortal) {
          activePortal.dismiss();
          return;
        }

        // Navigate back on main active nav if there's a page loaded
        if (this._app.getActiveNav().canGoBack()){
          this._app.getActiveNav().pop();
        };

        // Navigate back on subloaded nav if notified
        if(this._innerNavCtrl && this._innerNavCtrl.canGoBack()){
          this._innerNavCtrl.pop();
        }

      };

      // Fake browser history on each view enter
      this._app.viewDidEnter.subscribe((app) => {
        history.pushState (null, null, "");
      });

    }
  }

Then in my actual loaded page:
ionViewDidEnter() {
    this._events.publish("navController:current", this.navCtrl);
  }

Its messy but working for now until I figure out the nav scoping issue im facing.

@almothafar because the reactions were made with 👍 to remove those annoying +1's ;)

@samvloeberghs but thumb down made even without +1, and it's not only +1 but question too ! it's not StackOverflow ... !

@jgw96 The deeplinker link appears to be broken? Can you verify a solution for this?

I was able to use this to accomplish what I need for now.
`import {Component, ViewChild, Injector} from '@angular/core';
import {Platform, MenuController, Nav, App, IonicApp, NavController} from 'ionic-angular';
import {StatusBar} from '@ionic-native/status-bar';
import {SplashScreen} from '@ionic-native/splash-screen';
import {InvitesPage} from "../pages/invites/invites";
import {RewardsPage} from "../pages/rewards/rewards";
import {ConnectionsPage} from "../pages/connections/connections";
import {MessagesPage} from "../pages/messages/messages";
import {ResourcesPage} from "../pages/resources/resources";
import {SignoutPage} from "../pages/signout/signout";
import {DashboardPage} from "../pages/dashboard/dashboard";
import {AccountPage} from "../pages/account/account";
import {HomePage} from "../pages/home/home";
import {TriviaPage} from "../pages/trivia/trivia";
import {Events} from "ionic-angular/util/events";
@Component({
templateUrl: 'app.html'
})
export class MyApp {
@ViewChild(Nav) nav: NavController;
// make HelloIonicPage the root (or first) page
public rootPage: any; //if logged in, go to dashboard.
public pages: Array<{title: string, component: any}>;
public user: any;
public routeHistory: Array;
constructor(public platform: Platform,
public menu: MenuController,
public statusBar: StatusBar,
public splashScreen: SplashScreen,
private _app: App,
private _ionicApp: IonicApp,
private _menu: MenuController,
protected injector: Injector,
public _events: Events) {
this.initializeApp();

// set our app's pages
this.pages = [
  {title: 'My Account', component: AccountPage},
  {title: 'Dashboard', component: DashboardPage},
  {title: 'Invites', component: InvitesPage},
  {title: 'Rewards', component: RewardsPage},
  {title: 'Connections', component: ConnectionsPage},
  {title: 'Messages', component: MessagesPage},
  {title: 'Resources', component: ResourcesPage},
  {title: 'Trivia', component: TriviaPage},
  {title: 'Sign Out', component: SignoutPage}

];

this.routeHistory = [];
this.user = {firstName: ''};

}
initializeApp() {
this.platform.ready().then(() => {

  this._setupBrowserBackButtonBehavior();

  let self = this;
  if (sessionStorage.getItem('user')) {
    this.user = JSON.parse(sessionStorage.getItem('user'));
    self.rootPage = TriviaPage;
  } else {
    self.rootPage = HomePage;
  }

  this.routeHistory.push(self.rootPage);
  // Okay, so the platform is ready and our plugins are available.
  // Here you can do any higher level native things you might need.
  this.statusBar.styleDefault();
  this.splashScreen.hide();
});

}
openPage(page) {
// close the menu when clicking a link from the menu
this.menu.close();
// navigate to the new page if it is not the current page
this.nav.setRoot(page.component);
//store route history
this.routeHistory.push(page.component);
}
private _setupBrowserBackButtonBehavior() {
// Register browser back button action(s)
window.onpopstate = (evt) => {

  // Close menu if open
  if (this._menu.isOpen()) {
    this._menu.close();
    return;
  }

  // Close any active modals or overlays
  let activePortal = this._ionicApp._loadingPortal.getActive() ||
    this._ionicApp._modalPortal.getActive() ||
    this._ionicApp._toastPortal.getActive() ||
    this._ionicApp._overlayPortal.getActive();

  if (activePortal) {
    activePortal.dismiss();
    return;
  }

  if (this.routeHistory.length > 1) {
    this.routeHistory.pop();
    this.nav.setRoot(this.routeHistory[this.routeHistory.length - 1]);
  }

};

// Fake browser history on each view enter
this._app.viewDidEnter.subscribe((app) => {
  if (this.routeHistory.length > 1) {
    history.pushState(null, null, "");
  }

});

}
}
`

@judsonmusic Thanks for posting this. I was able to use this as a foundation and add in a nav controller pop to still maintain the integrity of ionViewCanLeave() implementations on pages and state when possible.
import { Component, ViewChild } from "@angular/core";
import { Nav, Platform, MenuController, IonicApp, App } from "ionic-angular";
import { SplashScreen } from "@ionic-native/splash-screen";
import { StatusBar } from "@ionic-native/status-bar";
import * as moment from "moment";

import { environment } from "../environments/environment";
import { IdleService, RedirectService, SessionService } from "../core";
import { HomePage, LoginPage, PageA, PageB } from "../pages";

@Component({
    templateUrl: "app.html"
})
export class MyApp {
    @ViewChild(Nav) nav: Nav;

    private version = environment.deployDateTime;

    public rootPage: any = LoginPage;
    public pages: Array<{ title: string, component: any }>;
    public routeHistory: Array<any>;

    constructor(
        public menu: MenuController,
        public platform: Platform,
        private ionicApp: IonicApp,
        private idleService: IdleService,
        private redirectService: RedirectService,
        private sessionService: SessionService,
        private splashScreen: SplashScreen,
        private statusBar: StatusBar) {

        this.routeHistory = [];

        this.initializeApp();

        // used for an example of ngFor and navigation
        this.pages = [
            { title: "Home", component: HomePage },
            { title: "Page A", component: PageA },
            { title: "Page B", component: PageB }
        ];

        this.setRootPage();

        this.redirectService.redirectToLogin$.subscribe(() => { this.nav.setRoot(LoginPage); });
    }

    public setRootPage(): void {
        const token: string = this.sessionService.accessToken();
        const tokenExpiration: Date = this.sessionService.expires();

        const currentUtcDate: Date = moment(new Date()).utc().toDate();

        if (token == null || token.length === 0 || tokenExpiration == null || tokenExpiration < currentUtcDate) {
            this.rootPage = LoginPage;
        } else {
            this.rootPage = HomePage;
            this.idleService.startIdleWatch();
        }
    }

    public initializeApp(): void {
        this.platform.ready().then(() => {
            this.setupBrowserBackButtonBehavior();
            this.statusBar.styleDefault();
            this.splashScreen.hide();
        });
    }

    public openPage(page: any): void {
        // reset the content nav to have just this page
        // we wouldn't want the back button to show in this scenario
        this.nav.setRoot(page.component);
    }

    private pushRouteHistory(page: any): void {

        let component: any = page;

        if(page.component) {
            component = page.component;
        }

        if(
            this.routeHistory.length === 0 ||
            this.routeHistory.length > 0 && this.routeHistory[this.routeHistory.length - 1] !== component) {

            this.routeHistory.push(component);
        }
    }

    private setupBrowserBackButtonBehavior(): void {
        window.onpopstate = (event) => {

            console.log("<- Back Button Pressed");

            if(this.menu.isOpen()) {
                this.menu.close();
                return;
            }

            if(this.ionicApp) {
                let activePortal: any =
                    this.ionicApp._loadingPortal.getActive() ||
                    this.ionicApp._modalPortal.getActive() ||
                    this.ionicApp._toastPortal.getActive() ||
                    this.ionicApp._overlayPortal.getActive();

                if(activePortal) {
                    activePortal.dismiss();
                    return;
                }
            }

            if(this.routeHistory.length > 1) {

                this.routeHistory.pop();

                if(this.nav.canGoBack()) {
                    this.nav.pop().catch((reason) => {
                        console.log("Unable to navigate back:" + reason);
                    });
                } else {
                    this.nav.setRoot(this.routeHistory[this.routeHistory.length - 1]);
                }
            }
        };

        this.nav.viewWillEnter.subscribe((page) => {
            this.pushRouteHistory(page);
        });

        this.nav.viewDidEnter.subscribe((app) => {
            if(this.routeHistory.length > 1) {
                history.pushState(null, null, "");
            }
        });
    }
}

Thanks for the posted solutions, but at the first sight, it seems kind of hacky to me.
Is there some official way to do it recommended by Ionic @jgw96 ?
No offense but the "everything is solved by the deeplinker" (plus the link you provide is now dead) is a too simple answer. Is there any official example to follow?
Thanks.

@ddahan looks like they're working on updates to navigation this past release and next. Most likely why documentation disappeared and they went dark.
https://github.com/ionic-team/ionic/blob/master/CHANGELOG.md#350-2017-06-28

Odd, the link is not present for version 3.x, but it is present for version 2.x:
https://ionicframework.com/docs/2.3.0/api/navigation/DeepLinker/

Page is no longer available. I found some docs about deeplinks here: http://ionicframework.com/docs/native/deeplinks/

I tried the code in this repository https://gist.github.com/t00ts/3542ac4573ffbc73745641fa269326b8
While it actually closes the modals, it makes a mess when I navigate inside tabs, I get a sort of loop.
I ended removing
this._app.viewDidEnter.subscribe((app) => {
history.pushState (null, null, "");
});

so now the modal closes but the whole page goes back which is still better than the original behaviour where the underneath page goes back and modal remains open!
This is a very misleading behaviour for the user. Probably for now, the only thing to do is to totally avoid modals and keep pushing pages, it would means to rewrite a large part of my PWA...
Is there any official solution, news, work arounds?


Create dev tool for better debugging

Blind debugging is hard my friend :cry:

Try this for profiling:
https://github.com/EmbarkStudios/puffin


1.13.1 Data Forwarding Settings toggle is misaligned

Description:
"Send also location coordinates of this device" toggle is misaligned under Data Forwarding Settings
The whole page feels a little bit cramped too, I think it's because there is no empty space under the Test data forwarding button.

QA passed


feat: Introduces a dev profile

This:

makes running tests go from 2180 to 528s on my machine,

The rest of the dev profile is unchanged:
debug = true
debug-assertions = true
overflow-checks = true
panic = 'unwind'
incremental = true
rpath = false

See doc

@porcuquine See the above link for an example of the occasional failures we observe on CircleCI (the tooling isn't found, which I suspect to be a cache irretrievability)

Note: This makes cargo build significantly slower, so I would recommend people use cargo check for debugging and/or rust-analyzer

@samuelburnham See rust-analyzer.cargo.buildScripts.overrideCommand In https://rust-analyzer.github.io/manual.html: I believe cargo check is the default. With rls being deprecated, is there still something using  cargo build in interactive environments?


Move MOTD reader out of readLoop() and into connect()

Simply return motd from connect() instead of awaiting the readLoop().
Rename readLoop() to run()

Fixed in commit 369043dc8f152b4d7559fa0bd72436a600f10378


Column Formatting schema still missing Title attribute (despite being allowed)

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
The title property under element attributes should be in the Column Formatting schema (https://developer.microsoft.com/json-schemas/sp/column-formatting.schema.json). Something like:
"title": {
  "description": "Specifies the title attribute",
  "anyOf": [
      {
        "$ref": "#/definitions/expression"
      },
      {
        "type": "string"
      }
  ]
}

Observed Behavior
The title property under element attributes is not listed in the schema (despite being whitelisted and allowed by column formatting). This causes this field to be flagged in VS Code as invalid.
Steps to Reproduce
Open the person-roundimage-format sample in VS Code and observe this error:

Now apply it to a person field and see that the title attribute is successfully added anyway.

Thanks for reporting.  We will update the schema soon.

Thx @thechriskent, it does help if you merge stuff to the right branch to get it out... well - that was stupid of me, but not the first time. Files are now out. Notice also that we moving to versioned URLs - old ones will work for now, but will be soon removed. New URLs are as follows. We will be updating docs etc asap.
• SP2019 supported one - https://developer.microsoft.com/en-us/json-schemas/sp/v1/column-formatting.schema.json
• SPO supported one - https://developer.microsoft.com/en-us/json-schemas/sp/v2/column-formatting.schema.json
View formatting under v2. Can you please also confirm these changes, so that we can close this. Thx.

I see the changes to the standard and can see v1 (without the changes). However, v2 isn't resolving just yet.
In the meantime, I am all for versioning! I think it's a great idea, but I'm a little confused by the proposed versions and perhaps I'm just missing something:

Moving View Formatting to v2 with no v1 seems confusing and inaccurate
If adding title to Column Formatting were a feature change, then I think a v2 of the schema would make sense. However, title has been working for a long time it just wasn't in the schema so really this is just a bug fix as there isn't a version of CF that doesn't include title (including the SP2019 version). So, I don't think moving to v2 makes sense just yet
The main difference between SPO Column Formatting and SP2019 Column Formatting is the use of Excel-style expressions (which aren't reflected in the schema)

Here are my conclusions:

Schema versioning only needs to increment when there are changes that require you to target different versions

List Formatting doesn't look at the schema at all (as far as I can tell) and there isn't a way in SPO to target previous versions
So only Column Formatting for SP2019 needs to have a fixed schema version (which is currently the same for SPO since both support title)

Here are the schema URLs I would propose

https://developer.microsoft.com/json-schemas/sp/column-formatting.schema.json
https://developer.microsoft.com/json-schemas/sp/column-formatting-2019.schema.json
https://developer.microsoft.com/json-schemas/sp/view-formatting.schema.json

Note the removal of en-us
The 2 column-formatting schemas would be identical for now, but all the AST versions in the samples library could be updated to use the 2019 schema to make it more obvious why they exist and isolate them from future enhancements/changes in SPO

As a side note, I think these schema files could be FAR more useful than they are. It's slightly outdated now, but please take a look at this extended schema I put together: https://gist.github.com/thechriskent/2e09be14a4b491cfae256220cfca6310
By providing the actually supported values for things like style properties (since these WILL be different between SP2019 and SPO) you can indicate far more to users. Right now, unless you crack open the code, there is no way to know a style property isn't supported until it isn't applied since these are whitelisted.


Sometimes yt.title doesn't work.

sometimes yt.title is output YouTube.
Also download file is same name like YouTube.mp4.
it's not exactly title.
I don't know why.
Did I ban for a lot of access?
How do I solve this problem?

See https://github.com/nficano/pytube/issues/632

Thank you so much. I think It worked.

anyone found the solution or any update have come

See https://github.com/nficano/pytube/issues/632

@ValkyreQueen


User Experience Testing

Epic concerning all tasks about User Experience Testing.

Closing this because it is a duplicate of Epic (#15)


qBit loads slowly

Environment
Docker
Version
latest
Describe the problem
First of all thank you for Homarr, it works great.
I currently have the issue that qbit is very slow with loading the torrent pages. Is there something I can do to make this faster?
For example, NZBGet loads instantly.
https://i.imgur.com/YX15r3X.gif
Additional info
No response
Please tick the boxes

[X] You've read the docs
[X] You've checked for duplicate issues
[X] You've tried to debug yourself

You're right it's slow. I'll look into it, can you tell me the average réponse time of the requests ?

You're right it's slow. I'll look into it, can you tell me the average réponse time of the requests ?

I'm sorry but how do I do that ?

You're right it's slow. I'll look into it, can you tell me the average réponse time of the requests ?

I'm sorry but how do I do that ?

Press CTRL + SHIFT + I or use this context menu option when right clicking on the page:

Click on Network:

Press F5 and wait until most responses have been retrieved
Click on XHR / Fetch, since this is what Homarr uses:

Send us a screenshot of the content with all requests (mine as an example):

Thanks for explaining.
I made it a gif because as you can see it keeps on going  so I'm not sure what part to screenshot.
https://i.imgur.com/Pp5BRBQ.gif

Can you check if 0.11.2 improved performance?

Is this still the case in 0.11.4?
If not, please close this issue.

Closing, as this issue is stale. Please reopen if this occurs again.


Add search for mobile (feature request)

How to add search in mobile view.. thank

hello, did you get this feature?
if possible, please share


⚠ ClamAV has degraded performance

In 7ca2b37, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 455 ms

Resolved: ClamAV performance has improved in acd6485 after 6 minutes.


The default layouts prop is being modified (ResponsiveGridLayout)

ResponsiveGridLayout modifies the layouts prop object directly, which is an issue if one hasn't been provided by the user causing the default layouts prop to be used. Since default props are shared across component instances, this will make all subsequentially mounted responsive layouts to use the same layouts object which may cause strange issues. The issue can be worked around by supplying an empty layouts object for the grid.
Tested with version 0.13.1.

https://github.com/facebook/react/pull/7449 :tada:

That's interesting. Thanks for this report!

Thank you for posting this, you have resolved several hours of frustrating debugging.
In my particular case I was unmounting a ResponsiveGridLayout, making other state changes, and then remounting it with the layouts saved. However any other subsequent unmount -> other actions -> remount would have the same layout as the first unmounting.


feat(class): user/student class eligibility

Notion ticket link

If user is logged in determine they are eligible for class

https://user-images.githubusercontent.com/44826218/136488879-9db6688d-6a6b-41b5-95bb-5b49127be4ef.mp4
Full classes section:

Volunteer view:

Implementation description

If user (parent) is logged in determine their children are eligible for class. If they are not, the class badge should be grayed out and clicking on the class will prompt user that they are not eligible. If at least one of the children are eligible, the badge should be blue
Divide class list into two parts (full and non-full) via filtering on availability
Add volunteer specific view

Steps to test

Test the flow in the implementation description as parent with many cases
a. 0 child
b. 1 child eligible for 1 class
c. multiple children eligible
c. multiple children not eligible
Test as non-logged in user
Test as logged-in volunteer

What should reviewers focus on?

Design: Look and feel of class ineligibility flow
Design: Flow difference between parent/non-parent users
Dev: New unstated-next usage for state management
Dev: Logic of eligibility
Dev: Code style
Dev: DB changes

Checklist

[x] My PR name is descriptive and in imperative tense
[X] I have run the linter
[X] I have requested a review from the PL, and/or other devs who have background knowledge on this PR or who will be building on top of this PR

@bekahma @vedantdsn Sorry, can I get another stamp? I added two new things that I would like you guys to look at 👀

Full class section
Volunteer view


Binary is not getting build.

I got the below issue when trying to build the k6-kafka binary.
 But this did not create the k6 binary. (Previously(few months back) this worked for me without any issue. I was able to build the binary)
can you please help to solve this issue?

Hey @sper1008,
Update your Go to 1.22 and then update xk6 to its latest version. Then try again to see if things work or not.

Hey @mostafa ,
This worked after updating Go to 1.22. Thank you


[Extensibility Enhancement] Add "Package No." to PK in table 307 "Inventory Buffer"

Hi, I need a change in the key of table 307 "Inventory Buffer", adding "Package No." to the primary key:
Original:
keys
    {
        key(Key1; "Item No.", "Variant Code", "Dimension Entry No.", "Location Code", "Bin Code", "Lot No.", "Serial No.")
        {
            Clustered = true;
        }
        key(Key2; "Location Code", "Variant Code", Quantity)
        {
            SumIndexFields = Quantity;
        }
    }

Modified:
keys
    {
        key(Key1; "Item No.", "Variant Code", "Dimension Entry No.", "Location Code", "Bin Code", "Lot No.", "Serial No.","Package No.")
        {
            Clustered = true;
        }
        key(Key2; "Location Code", "Variant Code", Quantity)
        {
            SumIndexFields = Quantity;
        }
    }

This is due to the procedure in report 790 "Calculate Inventory", we have an event but to use the find that way to filter + fill fields all the fields must be in the key, we already had "Lot No." and "Serial No." in the key with the addition of "Package No." we could divide by all the tracking fields:
local procedure RetrieveBuffer(BinCode: Code[20]; DimEntryNo: Integer): Boolean
    begin
        with TempQuantityOnHandBuffer do begin
            Reset();
            "Item No." := "Item Ledger Entry"."Item No.";
            "Variant Code" := "Item Ledger Entry"."Variant Code";
            "Location Code" := "Item Ledger Entry"."Location Code";
            "Dimension Entry No." := DimEntryNo;
            "Bin Code" := BinCode;
            OnRetrieveBufferOnBeforeFind(TempQuantityOnHandBuffer, "Item Ledger Entry");
            exit(Find());
        end;
    end;

Change of primary key is not possible, you need to build you own code here.


Error when generating migrations

With the wepay-rails gem installed, I get an error every time I run "rails generate migration":
/Users/Sacha/.rvm/gems/ruby-1.9.2-p180/gems/wepay-rails-0.1.114/lib/wepay-rails.rb:48:in `<class:Gateway>': uninitialized constant WepayRails::Payments::Gateway::HTTParty (NameError)

Any idea why that's happening? I'm quite new to Rails, so it's entirely possible that I've made a mistake somewhere, but as far as I can tell all I did was install the gem.

Hi SachaG,
I wanted to let you know that I completely rewrote this gem and it's now complete. The best and latest version is 2.1.0. I hope you have a better time getting the latest version running. If you need anything, let me know.
Adam

Thanks! In the end I didn't use WePay at all because it doesn't support non-US accounts. But I'll keep your gem in mind if they ever change their policy. Thanks for your hard work!


Make expenses database created by default for "sqrl init"

All requirements are met and implementation is all correct. I committed a change for some small cleanup. Feel free to merge after seeing my changes. Thanks!

For future reference, better to include more details in the commit message (and merge request) than only the ticket number. I'd even say don't bother including the ticket number in the commit. I usually only name my feature branch with the ticket number (such as "dev-cb62")


Fix SVG Upload

Previously:
Uploading an SVG made the API crash

Reason:
The svgContainsJavaScript check was moved to the new FileValidationService in https://github.com/vivid-planet/comet/pull/1279. The method was now executed in fileFilter() within the DamUploadFileInterceptor. However, at this moment file.path is undefined because the file is only saved to disk after fileFilter() is done. Meaning, in fileFilter(), we don't have access to the file content.

Now:
svgContainsJavaScript was moved back into its own FileValidationInterceptor. The upload works as expected

that was my fault, sorry.
Why not move the whole validation (using fileValidationService) to the second interceptor? Then the FileValidationService itself could stay as it is.

Have you tried achieving the validation using file.buffer instead of file.path, which should be the complete file in memory?

multer can be configured with different storage backends, but we have a temporary file backend.
The multer typings do not (or can not) know the backend. Generally I dislike multer (after working only a little bit with it).

Have you tried achieving the validation using file.buffer instead of file.path, which should be the complete file in memory?

@johnnyomair I don't know how. file.buffer is also undefined in fileFilter(). That has probably something to do with the backend as @nsams commented

@thomasdax98 sorry, I haven't thought about my suggestion long enough: We're not using an in-memory storage for file uploads (which wouldn't work for large files anyway), so it's not possible to do this validation in memory

Why not move the whole validation (using fileValidationService) to the second interceptor? Then the FileValidationService itself could stay as it is.

I forgot another option. I could call the fileValidationService in DamUploadFileInterceptor similar to how I did it here: https://github.com/vivid-planet/comet/pull/1235/commits/9d521e9941af1c94120487521b2f13036a260c24#diff-05b672fd11239f5186690b84570f5f43773a6c48b9660af26972e0387da71d21R85-R115
Moving all the validations to the second interceptor feels wrong to me, because when it's executed, the file was already saved to a temporary location. fileFilter() (apparently) works solely with the metadata before the file is saved to disk.

Why not move the whole validation (using fileValidationService) to the second interceptor? Then the FileValidationService itself could stay as it is.

Wouldn't this result in uploading large files to the temporary storage before validating it?

Why not move the whole validation (using fileValidationService) to the second interceptor? Then the FileValidationService itself could stay as it is.

Wouldn't this result in uploading large files to the temporary storage before validating it?

This is probably still prevented by https://github.com/vivid-planet/comet/blob/8ed9698122b8bf9eb011672fd6253d7fc1fae71b/packages/api/cms-api/src/dam/files/dam-upload-file.interceptor.ts#L38-L40 but I'm not 100% sure in which order these functions/configs are applied

Maybe split validation into validateFileMetadata and validateFileContents?

Wouldn't this result in uploading large files to the temporary storage before validating it?

I'm assuming we delete this temporary file.
Basically it's a performance optimisation with unknown impact vs. code organized on a contral place
I'm fine with both ways

@nsams How about this solution?


Update to netty-tcnative 2.0.0.Beta2

Motivation:
A new version of netty-tcnative is out.
Modifications:
Update to netty-tcnative 2.0.0.Beta2
Result:
Use latest release.

Cherry-picked into 4.1 (9c03d49) and 4.0 (df081f6)

yay!


Total time updaters

Changelog / Overview

Mobject.add_updater has a new parameter pass_relative_times determining if the updater should get passed relative or absolute time values.
Updaters can now have arbitraty named second parameters instead of requiring dt.
call_updater=True no longer causes an error with non-time-based updaters.
Renamed Mobject.update to Mobject._apply_updaters and deprecated update.

Motivation
From time to time you don't need the time difference since last updater call, but the total time... Now you without a problem.
Closes #321
Includes parts of the feature requested in #851
Explanation for Changes
Documentation Reference

Checklist

[x] I have read the Contributing Guidelines
[x] I have written a descriptive PR title (see top of PR template for examples)
[x] I have written a changelog entry for the PR or deem it unnecessary
[x] My new functions/classes either have a docstring or are private
[x] My new functions/classes have tests added and (optional) examples in the docs
[x] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[x] The PR title is descriptive enough
[x] The PR is labeled correctly
[x] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

Hi, are you still planning on working on this?

We will come back to this with a fresh view if the issue get's relevant again. This PR is already linked in the original issue

https://github.com/ManimCommunity/manim/issues/321

So i will close this for now. Feel free to open this PR again or a new PR which fixes the issue if you want to work on it again!


Apollo version R1.0.0 在vps上编译失败

Ubuntu 20.04
Apollo version R1.0.0
ram 512m
1 cpu
build过程失败 提示删除 log后重新编译  再次编译则会出现死机
请问 1.是否是服务器性能不足导致
2.Apollo系统配置最低要求是怎样呢
3.可否部署在云端服务器上以便于远程协同调试

Hi @tianrking,

It seems from your description that the issue was caused by insufficient memory.

For Apollo 6.0+ and master, the recommended system configuration was:

A machine with a 8-core processor and 16GB memory minimum
NVIDIA Turing GPU is strongly recommended

NVIDIA Ampere GPU was only supported in Apollo master.

Would you please specify your idea of cloud deployment of Apollo in a more detailed way?

Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


Ignoring empty cells

From<EMAIL_ADDRESS>on September 04, 2012 16:40:43
Found in most recent versions of Chrome and Firefox.
To reproduce:  $.csvEntry2Array("1,2,,4"), which results in ["1", "2", "4"], when ideally we want ["1", "2", "", "4"].
I wrote a patch that works well for me. Here's the patch, but maybe the developer would like to reinclude this as an option, there might be someone who wants empty cells discarded.
--- a/inc/jquery.csv-0.61.js
+++ b/inc/jquery.csv-0.61.js
@@ -92,6 +92,8 @@ RegExp.escape= function(s) {
output.push(m1.replace(reDelimiterUnescape, delimiter));
} else if(typeof m2 === 'string' && m2.length) { // Fix: eval
output.push(m2);

 } else if(typeof m0 === 'string' && typeof m1 === 'undefined'

   output.push("");
 }
 return '';

});

Original issue: http://code.google.com/p/jquery-csv/issues/detail?id=8

From<EMAIL_ADDRESS>on September 04, 2012 16:41:39
Oops, my copy/paste missed the scroll. Here is the correct paste:
--- a/inc/jquery.csv-0.61.js
+++ b/inc/jquery.csv-0.61.js
@@ -92,6 +92,8 @@ RegExp.escape= function(s) {
output.push(m1.replace(reDelimiterUnescape, delimiter));
} else if(typeof m2 === 'string' && m2.length) { // Fix: evaluates to false for both empty strings and undefined
output.push(m2);

 } else if(typeof m0 === 'string' && typeof m1 === 'undefined' && m0 === separator) {

   output.push("");
 }
 return '';

});

From<EMAIL_ADDRESS>on September 05, 2012 00:09:56
@-Ryan.Txanson Thank you for the fix. If you would attach the actual .patch file that will make life a little easier.
As soon as the patch is applied and the remote origin is updated, I will post an update here.

From<EMAIL_ADDRESS>on September 05, 2012 03:47:57
This conflicts with the fix I submitted. If anything, I think we're both being too conservative, and that else if { ... } should actually just be else {...}
There's simply no case where it should fail to output a value. That's clear from both standard and usage.

From<EMAIL_ADDRESS>on September 05, 2012 03:48:48
(I'm referring to the patches I submitted with #5).

From<EMAIL_ADDRESS>on September 05, 2012 10:58:28
@-Ryan.Txanson I'm pretty sure this issue was fixed in bug 5 .
I'm not exactly sure why but your fix actually re-breaks it. You can pull the latest from the repository to verify whether or not there's still an issue. Otherwise, if there's no existing issue I'd like to close this out and move on.

From<EMAIL_ADDRESS>on September 05, 2012 14:05:16
Ah, indeed. I just tested with the latest revision checked out from git, and the problem is not there, everything works in Chrome and Firefox. I didn't think to actually check out the source, and instead was using 0.61, the latest stable revision, which was the one I applied the fix to. You can close the issue. :)

From<EMAIL_ADDRESS>on September 05, 2012 14:10:46
@-Ryan.Txanson The code was actually just fixed last night. The other patch fixed this issue as a side effect. If it hadn't, your code would still be relevant.
Thanks anyway for your help. Every little bit that people contribute helps to make this a more robust and versatile library.

From<EMAIL_ADDRESS>on September 05, 2012 14:12:04
It helps to have a good test runner. Otherwise I'd probably be applying your patch to code that isn't broken. ;)

From<EMAIL_ADDRESS>on September 05, 2012 14:12:21
Status: Verified

From<EMAIL_ADDRESS>on September 05, 2012 14:14:59
Haha, yes. I just put the last git revision into production as well, and everything works as before. So, hurray!

From<EMAIL_ADDRESS>on October 10, 2012 21:07:45
Owner<EMAIL_ADDRESS>


Update Readme

Update README to have more info on how to build the project and info about the project in general.

Yeah, we should add some information about how to run it. I had to review your changes and I couldn't remember how to run it! So... we have to add harp server at somewhere of the README file

Same! Had to do some documentation digging and guessing...


Secret stash refractor

About the PR

Added some additional functionality to the secret stash system and also removed the PottedPlantHide stuff because it is now redundant. Mainly the changes are mostly related to adding verbs to the system!
Why / Balance

Three main reasons:
1.) Adding the verbs allows you to now insert items that are used to close the stash inside of the stash.
2.) If there is ever some overlap with clicking, adding the verbs will always allow the stash to be accessible.
3.) This system allows more flexibility for some other things I want to add!
Technical details

Two things for whoever reviews this:
1.) Make sure what I did in FoodSystem makes sense. It makes sense to me (You are destroying the item) but I'm worried this is not quite how the event is supposed to be used.
2.) The UtensilSystem that an incorrect handled boolean (I think) that was messing up with the stash so I fixed it.
Media

https://github.com/space-wizards/space-station-14/assets/107373427/5b698632-e3b9-4162-a76f-481bfa4977a3
https://github.com/space-wizards/space-station-14/assets/107373427/8dbc8753-3603-42cb-aa4d-8257f5bb77bb
I can't show any more on video, my computer will stop recording after 13 seconds (No idea why?) and its painful...

stash prying can also be moved to its own component (ToolOpenable e.g.) in the far far future doors might use it

Delta I'm not sure that using the openable component is the correct approach! I've looked at it and many of the functions are related to drinking specifically, and I would also have to basically disable like 90% of is uses (Verbs, OnActivated, examine stuff, etc...) just so the ToolOpenableSystem will be able to use the TryOpen and TryClose functions (Or have tool openable make an event or something).
I could totally be wrong here but I feel like the better approach would be to just make the toolOpenableSystem independent from the openableSystem. Let me know what you think!

OK I "Resolved" the issues but I didn't get a response so I'm not sure if this is the right way. This is 100% better than before and a lot cleaner but maybe not quite what ya'll want!

Its starting... The evil merge conflicts 😭


Loss of input fire curve in g4s when the thermal analysis finished.

Hi,
When I run the 2d thermal analysis with user-defined fire curve, I found that I have to modify the g4s file again and again as long as the previous analysis was finished.
For example:
Before the analysis, the definition of the physical curve in g4s file is:
Curve - Frontier Constraint(Physical Curve 32) = {
Temperature : User-defined
File for Temperature : fire.txt
}
when the analysis is finished, it will change to
Curve - Frontier Constraint(Physical Curve 32) = {
Temperature : User-defined
}
so I have to modify this file every time when I want to resubmit my job in the gmsafir.
attached are my fire curve and geo and g4s files. (I changed their suffix to .txt for uploading.)
w1631grider - copy.txt
w1631grider - copygeo.txt
fire.txt

I just fixed a bug. Please download the new version

thanks very much, but this bug still exists.

I am on it to fix it, hopefully still before end of the year

Check with new updated version, problem shall be fixed

thanks very much, in the newest version, it has been fixed.


fix: allow for relative paths to installed mocha for finding, running,…

… and debugging tests

This change is

Please see pull-request #127 . Which solves exactly this problem.
However it is still open and next steps are not clear to me.

Tks for your PR I'll try to merge it soon

Hey, great!
Awesome extension, by the way.  I've just needed to tweak a few things to
use it on projects I'm working on, particularly the path calculation for
mocha.  I also increased a timeout value for tests reporting back because I
have a large suite and it was giving up before they finished.
I ended up simplifying the path calculation for mocha a bit more because it
seemed like vscode update broke the logic for require maybe?  Not totally
sure, but I pushed a slightly different fix.
A couple other things I wanted to dig into was it seems I can't run my full
test suite with it (I have hundreds of tests) but can run individual
groups.  I also don't see real-time updating of tests running (spinning
circles) and wanted to see if I could figure out that.
-Jeff
On Thu, Nov 15, 2018 at 9:03 PM Cube<EMAIL_ADDRESS>wrote:

Tks for your PR I'll try to merge it soon
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/maty21/mocha-sidebar/pull/140#issuecomment-439275097,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADOA3gV7c7LB_U64DZeiJ8kShU9bWQ6Eks5uvjj7gaJpZM4WgQta
.

Nice great to here contoribution are more than welcome if you need any help on understanding something just pm me . If you fixing/adding different things split it to different PRs so it will be easy to merge it
Thanks a lot


In two-month mode, the calendar view jumps

When selecting a date in January while December and January are visible at the same time, the calendar jumps from December|January to January|February view.
Repro link:
https://codepen.io/christophdubach/full/PoJbdPo
Bring the calendar to a state in which December is the visible month on the left-hand side and January on the right-hand side.
Then select a date in January.
Environment

flatpickr version used: 4.6.9
Browser name and version: Google Chrome 96.0.4664.93, Firefox 94.0.2, Safari 15.1 (176<IP_ADDRESS>.20)
OS and version: macOS 12.0.

https://user-images.githubusercontent.com/7314751/145803300-84c70a68-9795-4508-bb3d-ed8f30f4a878.mp4

Did you ever find a fix for this?