Vue 3 does not work well with iframes

Version
3.0.2
Reproduction link
https://codesandbox.io/s/unruffled-northcutt-cmndl?file=/public/iframe.html
Steps to reproduce

Have an app that shows an iframe
Create a teleport that will place it's content inside the iframe
Add an event like click to the teleport content
Immediately after the irame loads, try to click on the teleported element

What is expected?
The click event should fire immediatelly
What is actually happening?
The click is not working until the event.timestamp ( that is generated by the iframe dom ) gets higher than the attached timestamp from the parent window.

More info can be found here ( https://github.com/vuejs/vue-next/blob/ea5f92ae051be511558569eaf4c2afa2839c3e4d/packages/runtime-dom/src/modules/events.ts#L114 here, inside the iframe the event.timeStamp which is calculated based on the iframe timestamp is lower than the initial invoker.attached = getNow() that is calculated based on the parent frame ). Due to this, events are not firing for the time difference it takes the iframe to load

I'm in a similar boat, not sure how much it's related to OP but it sounds very similar. I've a Vue.js app with an iframe, which loads a different Vue.js app. Sometimes, click events weren't registering in the nested app, uncommenting the line highlighted in OP helped. It's weird because it didn't happen every time and both machines are running the same version of browser.

From what you experience, this is the same issue

@yyx990803 Looking at the source code, I noticed this comment accompanied the "fix" that introduced the problem above:
        // attached to outer element during patch, and triggered again. This
        // happens because browsers fire microtask ticks between event propagation.
        // the solution is simple: we save the timestamp when a handler is attached,
        // and the handler would only fire if the event passed to it was fired
        // AFTER it was attached.```

I have made some tests using the reproduction template provided in the initial ticket (  https://github.com/vuejs/vue/issues/6566 ) with Vue 3 and it seems that the problem mentioned there is not reproducing anymore if I comment out the timestamp check.

Are there other issues that involved that fix?

I have the same problem. Is there a solution now？

I have the same problem. Is there a solution now？

I have the same problem. Is there a solution now？the reproduce

I have the same problem in 3.0.7. Is there a solution now？the reproduce

Render only once，we cant control iframe's node

I have the same problem in 3.0.7. Is there a solution now？the reproduce

raise by the iframe's event.timeStamp. need to wait until the iframe's creation time longer than clickEvent's creation time.

I have the same problem in 3.0.7. Is there a solution now？the reproduce

raise by the iframe's event.timeStamp. need to wait until the iframe's creation time longer than clickEvent's creation time.

It's not a solution.🙁

Is there any solution to fix this problem yet? Every time, I mounted an iframe without reloading the page, @click handler of element inside iframe won't work anymore

The "solution" we are using in production is to manually modify a vue file and disable this ( runtime-dom.esm-bundler.js in our case ), however, I do not recommend doing so as other problems may appear.
The changes we've made:
https://gist.github.com/zauan/a3488a9feb799242df607c983de9c5b7
We have this modification in a live product ( zionbuilder.io ) and didn't encounter any side effects so far. I also tested the initial bug that introduced this modification and I cannot reproduce it in Vue 3 ( with the timestamp check disabled ), so, I am not sure if the initial problem is still valid in Vue 3.

The "solution" we are using in production is to manually modify a vue file and disable this ( runtime-dom.esm-bundler.js in our case ), however, I do not recommend doing so as other problems may appear.
The changes we've made:
https://gist.github.com/zauan/a3488a9feb799242df607c983de9c5b7
We have this modification in a live product ( zionbuilder.io ) and didn't encounter any side effects so far. I also tested the initial bug that introduced this modification and I cannot reproduce it in Vue 3 ( with the timestamp check disabled ), so, I am not sure if the initial problem is still valid in Vue 3.

Thank you so much, I will try with a new fork 👍

I also tested the initial bug that introduced this modification and I cannot reproduce it in Vue 3 ( with the timestamp check disabled ), so, I am not sure if the initial problem is still valid in Vue 3.

@zauan Here's a demo of the behaviour this check is meant to protect against, simulated with a custom directive (which leaves event handling to your vanilla JS adn thus doesn't contain this check:
https://jsfiddle.net/Linusborg/tc1aksvx/
But you could still be right theoretically that the problem doesn't persist with actual v-on events with your modification, haven't had the time to properly test this.

Yes, this works on smaller projects, however, this cannot be implemented in larger projects like Zion Builder as it increase the code base and there are many places were events are used. Also, can you please also add the removeEventListener on the 'beforeUnmount' hook to your code so that the event gets removed when the component gets unmounted ( in case someone wants to use you workaround and just copies and pastes the code )

Sure, I edited the code.

This issue is a nightmare for big projects. Adding events manually doesn't work for elements with v-if conditions. I hope this bug will be fixed soon.

I confirm that the problem is still here, is there any update on that?

For anyone else attempting @zauan's fix in Vite, here's what I needed to do-

Update<EMAIL_ADDRESS>as per his gist file
Clear out all files from /node_modules/.vite
npm run dev

I am also encountering this issue when mounting a component into an empty iframe.
The first click events are ignored. It can last a few seconds before click events are finally emitted.
Since the time check fix concerns only rare edge cases and introduces bugs in other cases, it might be interesting to allow disabling this check, either via a global application config, or locally per component (and its children).

FYI, I am working on a solution to allow opting out of the timestamp check.
I hope to be able to submit a pull request very soon.

related issue : https://github.com/vuejs/core/issues/3933

Really struggling with this one. None of the workarounds above seem to work reliably and @semiaddict 's pull request has been sitting there unmerged for over 6 months.
Is there any updates?

@Hyperblaster this was the only thing that worked for me.
    /*
    * This fixes the current issue with event timestamps when running vue in a window or iframe.
    * */
    let ua = window.navigator.userAgent;
    Object.defineProperty(window.navigator, 'userAgent', {
        get: () => {
            let s = new String(ua);
            s.match = function (re) {
                // only care about this particualr match call.
                if (re.toString() === '/firefox\\/(\\d+)/i') {
                    return [, 53];
                }
                return ua.match(re);
            };
            return s;
        },
    });

I can't remember who posted it originally, but it was on another ticket on this repo.

I wouldn't recommend overriding the userAgent as this can have side effects within and outside of Vue.
I've personally been patching Vue 3 with the changes in my pull request   using patch-package without issues.
I just hope someone in the Vue team will get the time to look into the pull request soon.

@LinusBorg,
@yyx990803,
Any chance of getting the pull request reviewed?
I'm totally open on working on a different solution if for any reason the one proposed in the pull request doesn't quite fit the Vue coding practices.
Thanks in advance.

@semiaddict  @Kyon147 the source of this snippet is from here
https://github.com/vuejs/core/issues/3933#issuecomment-1157259673
and it doesn't override the user-agent, it actually overrides the match() call of the userAgent
to minimize impact, and target the check vue does.

@lidlanca thanks so much! This helped me solve my issue. Adding the script into the head (before vue is initialised) seemed to do the trick. I tried all kinds of things in onMounted hooks and nothing seemed to work.
Hopefully this can be merged and fixed in core soon

hai , swipe is not working in iframe tag   ,
scenario : iframe tag have advertisement if i click src naviagte another page back to same Ad only
but now if i add pointer events:none handle swipe is working fine but but not able to click the Ad

Has anybody come across this issue with Vue 3 using the Options API? Any idea if it's been resolved yet at all?

+1 @miainchambers
We're about to starting building a Vue application for a client but have been informed that it may need to be placed inside an iframe for 3rd party sites using the app; what problems do we need to be aware of with this in 2023?

Thanks @miainchambers, that would be much appreciated

@miainchambers I'm using Vue 3 with the comp api but I still have that "fix" in place and don't want to remove it until there is an official fix in place...


9471 - Remove hyperlink on file download where date has expired.

This PR ...
If a file has expired and a user clicks on the file to download, the file does not download and a console error is thrown which notifies Dev Ops.
Do not allow the user to download the file when the date has expired.
Test Steps:

Log into RS
Navigate to Daily Data
If the date has expired in the row, the file should not be a hyperlink.

Changes

Checklist
Testing

[x] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[x] (For Changes to /frontend-react/...) Ran npm run lint:write?
[x] Added tests?

Linked Issues

Fixes #9471

Discussed Etans concerns and regarding existing functionality/poor design. DeliveriesTable will be replaced in the near future with an improved version which will cover the above mentioned comments.


Firebase not work

why on pure lua everything works and in NEXT-no. maybe there are some ways to stabilize a pressing issue and not one I encounter

CC @posva

I'm sorry I don't understand anything 😅


nameof for field of record

The nameof expression produces a string constant that matches the name in source for nearly any F# construct in source.

What about the field of a record?  Is it possible to use nameof with that construct?  Is so, could an example of this be added to this documentation?  (I can't figure out how to do this.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7e313948-0ecb-7c3c-1e1f-3c56a3045a41
Version Independent ID: 254fda6f-2502-c076-a63d-221f3474ceb0
Content: Nameof - F#
Content Source: docs/fsharp/language-reference/nameof.md
Product: dotnet-fsharp
GitHub Login: @cartermp
Microsoft Alias: phcart

@cartermp Could you answer this question about record fields?

It's possible to take the name of a record label with an instance of the record.
let f (r: R) =
	printf $"{nameof r.Label}"

But not unqualified, which is what I expect you're asking about.

I see.  I don't have an instance of the record in my use case.  Here is how I would write it.
nameof Unchecked.defaultof<MyRecord>.MyField

Can a section about record fields be added to documents?  It could include both our code examples.  I am willing to contribute a PR that makes this addition.

It's not specific to records. F# doesn't allow resolving items that don't come from an instance unless they are static. A small section about that in the remarks could work.


Fix eslint errors and auth error

title: Issue # | Fix auth type error

Discord Username: @
What type of PR is this? (select all that apply)

[ ] 🍕 Feature
[X] 🐛 Bug Fix
[ ] 🚧 Breaking Change
[ ] 🧑💻 Code Refactor
[ ] 📝 Documentation Update

Description

when you try to contribute project and run npm run pr-precheck command, you were seeing a type error related with next-auth at type-check step, now its gone and everything okay.
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

UI accessibility concerns?

Added/updated tests?

[ ] 👍 yes
[X] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Relaxed

@devhiko you have some issues

yeah code changed a lot since i pushed this PR.

failing tests

Ahaha, this merge will last to eternity :D cuz i changed eslint rules and all files have errors now !


Add Virtual-CNS Navigation/Beacon Receiver for radio navigation

Add Virtual-CNS Navaid support for radiol navigaiton (like ILS, VOR, DME)

[x] Navigation Receiver
[ ] Beacon Receiver

I meet some prefomce issues when add Beacon Receiver...
Game forzen when Becaon was trigged.
see https://github.com/Misaka-L/VAU320/tree/becon_marker_receiver


We only check the chain id when challenging/conclude/etc

Describe the bug
Currently, there's only one check on the chainId, and it occurs in the contract when it computes a channelId.
I think there are two changes here:

The wallet should probably check the chainId on incoming channels against the chainId the wallet knows about
A require statement could be added to _requireValidProtocolTransition on the contract to check the chain id.

A require statement could be added to _requireValidProtocolTransition on the contract to check the chain id.

@geoknee does that sound reasonable?

A require statement could be added to _requireValidProtocolTransition on the contract to check the chain id.

@geoknee does that sound reasonable?

The main reason I want to add to that is so the javascript check can mirror the solidity code. Perhaps that's overkill and a simple sanity check in the wallet is enough.

@lalexgap I had quite a long think about this and my preferred solution is here statechannels/statechannels#3324


package.json doesn't allow installation of Angular version 8 prerelease

Steps:
Take a 7.x project with Material installed.
ng update @angular/core @angular/cli --next
What is the expected behavior?
Angular is updated and Material is left at 7.x
What is the current behavior?
ng update @angular/cli @angular/core --next
                  Package "@angular/material" has an incompatible peer dependency to "@angular/animations" (requires ">=7.0.0", would install "8.0.0-beta.6").
                  Package "@angular/material" has an incompatible peer dependency to "@angular/common" (requires ">=7.0.0", would install "8.0.0-beta.6").
                  Package "@angular/material" has an incompatible peer dependency to "@angular/core" (requires ">=7.0.0", would install "8.0.0-beta.6").

Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Material 7.x
Is there anything else we should know?
https://jubianchi.github.io/semver-check/#/>7.0.0/8.0.0-beta.0
The comparison in package.json to >7.0.0 doesn't match 8.0.0-beta.0 of Angular :(

I know it's wonky, but maybe ^7.0.0 ^8.0.0-0 ^9.0.0-0might match the versions we want?

@StephenFluin could you explain, why is it is a bug ?

I feel this is a bug because developers who want to try out Angular 8.0.0-beta via ng update are prevented from doing so by the mismatched package versioning if they use material.

@StephenFluin I believe that ng update have to be used to update old version to latest not for update to "beta, alpha etc", You can check available versions here for update https://update.angular.io/

Closing as this state is out of date and we have updated how we define our package.json going forward

Hmm..
Fetching dependency metadata from registry...
                  Package "@angular/material" has an incompatible peer dependency to "@angular/animations" (requires "^8.0.0 || ^9.0.0-0" (extended), would install "8.2.0-next.2").
                  Package "@angular/material" has an incompatible peer dependency to "@angular/forms" (requires "^8.0.0 || ^9.0.0-0" (extended), would install "8.2.0-next.2").
                  Package "@angular/flex-layout" has an incompatible peer dependency to "@angular/core" (requires ">=8.0.0-rc.5", would install "8.2.0-next.2").
                  Package "@angular/flex-layout" has an incompatible peer dependency to "@angular/common" (requires ">=8.0.0-rc.5", would install "8.2.0-next.2").
                  Package "@angular/flex-layout" has an incompatible peer dependency to "@angular/platform-browser" (requires ">=8.0.0-rc.5", would install "8.2.0-next.2").

Regression ?


wire-desktop: fix linux build

autopatchelf currently fails. adding libxshmfence was included in
https://github.com/NixOS/nixpkgs/pull/168636, but missing in
https://github.com/NixOS/nixpkgs/pull/168317.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Do we want to Backport? We usually Backport wire-desktop releases to the stable channel

yeah, sgtm! Please send a PR backporting these two PRs.

Shall I backport as a single PR?

backported to 21.11 in https://github.com/NixOS/nixpkgs/pull/168818.


As a regular user, I should not be able to see that an activity is on a draft pathway

When you view an activity record, it's currently showing that it's on a path and even shows you that it's a draft pathway, but you just shouldn't see it at all.

https://learningcurator.ca/activities/view/647


https://aistudio.google.com/app/prompts?state={"ids":["14WQzOLiiz0dFKiVGQ2y3WQifZSdjW4ww"],"action":"open","userId":"109116126150763630254","resourceKeys":{}}

https://github.com/Ag2279122/Workday/pull/2/Gemini/wd5.myworkday.com/Similar/https://aistudio.google.com/app/prompts?state={"ids":["14WQzOLiiz0dFKiVGQ2y3WQifZSdjW4ww"],"action":"open","userId":"109116126150763630254","resourceKeys":-<EMAIL_ADDRESS>

@Ag2279122,
We see that the issue template has not been filled, could you please do so as it helps us analyze the issue [SDK version, steps followed before you ran into this error or stand alone code/colab gist to reproduce the issue faced and reopen this issue. Thanks!


Try to auto-merge before running checks in PRs.

If it can't merge cleanly, then it should abort the change.
This might work on Windows -- it seems that Powershell v7 added
pipeline-chain operators:
https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_pipeline_chain_operators?view=powershell-7.1

Hm, so, it does look like it is merging properly, per the number of tests that are being run. I think I still want to add kolmafia/kolmafia as a remote explicitly so this works for external contributors.


BUG: Solo Adventures Page Not Found

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

"When I click on 'Solo Adventure', nothing opens."
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Now this is added successfully


[Misc] remove the block.py in vllm

Since this file is no longer referenced, it can be removed from the project.

@youkaichao
hope you can review this PR at your convenience.

To add some additional context, the teo classes defined in this file:

PhysicalTokenBlock only used in block.py and only referenced in comments in core/evictor.py
BlockTable also defined in vllm/core/block/block_table.py and is only every imported from the latter file

LGTM, I also don't see these classes used in code anywhere.

PhysicalTokenBlock only used in vllm/block.py (the file being removed) and only referenced in comments in vllm/core/evictor.py

The comments vllm/core/evictor.py should be updated to reflect the removal of this class.

You're right, the new class to reference is Block which is defined in vllm/core/block/interfaces.py


Add babel plugin for module tagging

Add babel-plugin-react-server to the react-server-cli webpack loader and
babel-preset-react-server.  Factor out react-server-module-tagger from
react-server-gulp-module-tagger to share module tagging format between
gulp and babel, and add tests to ensure prevent regressions.  As discussed in #276; fixes #12 and #247

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: gigabo:white_check_mark: doug-wade:x: invalid-email-address

This has gotten unwieldy, so I'm breaking it into multiple prs (see #300, #294, and #297, with more to follow)


kubenetes & docker network

hi, i have a problem, i do like this "docker run -it images bash" in the worker host.  I find this container can not connect to kube-system containers, can I change some configurations to connect to kube-system?

Could you please tell us what you'd like to see after running this command? What is your use case?

@mordebites I have solved this problem, docker run image with "host" network mode.


Adding new tvchannels

I would like to contribute to this repo by posting spanish TV channels where the World Cup is going to be broadcasted. And I was thinking that maybe it would be interesting to enrich tvchannels data in order to specify the country in a more easily readable way (for parsing purpose), something like this:
{
"id": 3,
"name": "Cuatro",
"icon": "https://upload.wikimedia.org/wikipedia/commons/f/f8/Logotipo_de_Cuatro.svg",
"country": "Spain"
}
That way it could be easily read by humans and printable on screen, if browsing in english. It would
be even better if we could add the associated iso2 as you did in teams so devs could even use it to display a flag (most "flag-libraries" use css classes with the iso2 two chars).
But it could also be interesting to add the language of the broadcast (ISO_639-1), some countries have more than one official language. In Spain we have more than one but the Wold Cup will be broadcasted just in spanish. Maybe most of the times iso2 and language would have the same value.
With all these proposals each tvchannel could be as follows:
{
"id": 3,
"name": "Cuatro",
"icon": "https://upload.wikimedia.org/wikipedia/commons/f/f8/Logotipo_de_Cuatro.svg",
"country": "Spain",
"iso2": "es",
"lang": "es"
}
Yes, they are probable too many properties so, what do you think? Which properties should be added, if any? Just let me know and I will PR having your decision into account.
And thanks for this repo btw.

Hey man, you think this is a good source to get the channels broadcasting the world cup https://en.wikipedia.org/wiki/2018_FIFA_World_Cup_broadcasting_rights
Thanks for sharing.

Interesting!
In the case of Spain, however, Mediaset is not a TV channel but a set of different companies in the business of media. So I would still prefer to know the TV channels where the WC is going to be broadcasted. Cuatro and Telecinco are part of Mediaset Spain and will broadcast the whole WC (all the 64 games). Games with Spain playing will be broadcasted by Telecinco (and probably the inaugural and final games) and the rest will be broadcasted by Cuatro.

You are right. Thanks!

@arkabide About the tv channel format, that is actually a good idea.
I would stick with the second one
{
"id": 3,
"name": "Cuatro",
"icon": "https://upload.wikimedia.org/wikipedia/commons/f/f8/Logotipo_de_Cuatro.svg",
"country": "Spain",
"iso2": "es",
"lang": "es"
}

Because I like having the iso2 format, so it can use the same format as the teams country code, so flags can be the same.
I will update my deploy test script.

Great. I just PR (#11) spanish TV channels with this format.

So if country has more than one language like US has, here we have two different channels broadcasting in English and Spanish   iso2 has to change, Can you clarify please?
EXAMPLE:
{
"id": 1,
"name": "English channel",
"icon": "*.svg",
"country": "US",
"iso2": "en",
"lang": "en"
}

then
{
"id": 2,
"name": "Spanish channel",
"icon": "*.svg",
"country": "US",
"iso2": "es",
"lang": "es"
}

iso2 refers to the country of the TV channel while lang refers to the language of the emission.
iso2 allows the code to be used to obtain the translation of the country (from i18n files), for CSS stuff (for example to show the flag of a country, typically we have CSS classes like 'flag-us', 'flag-en', ...), and for standardization issues.
country is added just to follow the same structure as teams where we find the name of the country in english and its iso2 code.

Got it! Learned something new, thanks man!

True lang should be an array
I know that US are using a lot of those red, blue, green buttons on the tv remote for something useful (I havent been in any country in europe, where those buttons are actually used)
But I know in US you can change spoken language with those buttons, so the same TV channel can have both english and spanish, with just a press of one of the color buttons on the remote, am I right @gioalo ?

Yes. I'm not sure about the color coded buttons maybe I've seen it before in cable TV remote control, still you can always enable the audio in the settings or with a button if is available for the TV broadcast which is not always true for many TV programming. BTW this system is a standard SAP (second audio program) here in US, Canada and Mexico.  Thanks @lsv

@arkabide should we change the lang code to an array?
(I will do it on already existing channels)


bug: batch query dropped table may get wrong result

Describe the bug
As mentioned in https://github.com/risingwavelabs/risingwave/issues/5446

Batch query when dropping
Similar to the above, we may be able to scan the dropped table whose data is being cleaned-up by the storage, due to asynchronous updates of catalog deletion in this frontend. This may cause wrong results or even break some assumptions in batch executors.

To be specific,

The state clean compaction filter is allowed to delete dropped table's KVs once drop_streaming_jobs has succeeded.
Frontend may query table that has already been dropped by another frontend, due to asynchronous notification.
"associate notification version with epoch" doesn't help when frontend uses an old epoch earlier than the drop table epoch.

For example:

The frontend_1 drops MV_1 and succeeds.
A storage compaction removes partial KVs of MV_1.
The frontend_2 doesn't receive any notification due to network issue. Neither its pinned epoch nor catalog is updated.
The frontend_2 queries MV_1 with an old epoch earlier than the drop table epoch. It will get wrong query results.

To Reproduce
No response
Expected behavior
No response
Additional context
No response

@Li0k @Little-Wallace @hzxa21
I don't see any mechanism to prevent this issue in current codebase. Please correct me if I'm wrong.

After discussing with zheng, some points were summarized

we have discussed that the filter also takes watermark into account when compacting to avoid the problem that the data accessed in the above example has already been managed. But this is not easy to do. In lsm's storage engine, we reserve at least one version of each key to serve. And it relies on the assumption that the dropped table data will not be accessed again, and the state_clean is done by filtering the table_id. Therefore, when we consider watermark in the state-clean, we will keep at least one version of the key under all conditions. In other words, state-clean cannot be implemented and the data will be retained permanently unless we show it deleted.  So it is difficult to introduce watermark in compact to solve the above problem.
Inspired by TTL, we discuss whether we can specify min_epoch to prevent external access to the deleted data.However, the above bug is not caused by using the wrong epoch, but by accessing the data corresponding to a non-existent table, so the above solution cannot be applied directly. According to zheng's analysis, the bug occurs after drop_strema_job, i.e., the local_state_store corresponding to the table should have been deleted. I think the data accessed by batch_query is from committed_version instead of local_state_store, so we can try to check read_version_mapping to determine if the table exists before read_request to avoid the above bug.

It seems neither frontend nor compute node has a deterministic way to tell a table has been dropped. :neutral_face:

Can we store the list of table ids in hummock version and update the list atomically on table creation/drop? In this way, we know what tables are visible in every version/snapshot.

Can we store the list of table ids in hummock version and update the list atomically on table creation/drop? In this way, we know what tables are visible in every version/snapshot.

One problem with this solution is,

Firstly compute node uncommitted data is removed when dropping table,
However, the new hummock version generated after step 1, which contains the latest table id list, is delayed for arbitrary long time before received by compute node.
Then, build_read_version_tuple cannot reject batch query over this dropped table, because its old hummock version's table id list still contains it. Meanwhile, it actually performs a committed read unexpectedly, because uncommitted data has been removed in step 1, i.e. user may find monotonic reads is broken in two consecutive read in one session.

Link #8796

Link #8796

Why is this related to #8796?

Link #8796

Why is this related to #8796?

Sorry, should be #7002, misclick


Cannot find name 'RTCEncodedVideoFrame'

Describe the bug
What is happening:
After npm install and ng serve, this is the error I got (tested multiple apps):
`Error: node_modules/livekit-client/dist/src/e2ee/utils.d.ts:4:100 - error TS2304: Cannot find name 'RTCEncodedVideoFrame'.
4 export declare function isVideoFrame(frame: RTCEncodedAudioFrame | RTCEncodedVideoFrame): frame is RTCEncodedVideoFrame;
`
Reproduction
npm install livekit-client
ng serve
Logs
No response
System Info
<EMAIL_ADDRESS><EMAIL_ADDRESS>
Severity
blocking all usage of LiveKit
Additional Information
Testing with the sample seems to work, but the package is broken.

+Adding the flag allows the lib to work properly:
"skipLibCheck": true

Which typescript version are you using in your project?

Hi @lukasIO, currently using<EMAIL_ADDRESS>

this type seems to have only landed in the TS DOM lib in 4.7 (see https://github.com/microsoft/TypeScript/blame/main/src/lib/webworker.generated.d.ts)
Is it possible for you to upgrade to 4.7?

closing due to missing feedback


FRONTEND - Vi/frontend navigation

First frontend PRRRRRRRR
some cleanup
some default css stuff
navigation bar #95
and empty tabs! (well.. with a title..)
closes #95

Curiousity question... Why do we have 7 of the pong images? I could only find two of them being used in frontend/public/site.webmanifest
Thanks for setting up the template for the frontend, feels like 80% of the project is now done 🤓😬🤫

Most of those images are automagically selected by the browser/device that wants them
This is all generated by realfavicongenerator and I just copy paste the files etc from there :)


[Service Bus] Unable to run samples using source code

In the examples/typescript folder for service bus folder, update samples to point to ../../../lib instead of @azure/service-bus in order to use the source code to run the samples
Run npm run build-samples to build the samples

Below errors are found:

The error is due to this line: https://github.com/Azure/azure-sdk-for-js/blob/master/packages/%40azure/servicebus/data-plane/examples/tsconfig.json#L5
@HarshaNalluru I recall this got added when you added the javascript samples. Do you remember the reason for this?

Unable to run the ts samples with @azure/service-bus
error TS2705: An async function or method in ES5/ES3 requires the 'Promise' constructor. Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your --lib option.
Removing that thing fixed the issue when running with the source code ?

This was when you were trying to run the samples using @azure/service-bus from the folder inside our repo?
Our general instructions are for people to copy the sample to their own folder and run npm install @azure/service-bus in their folder and then run the sample

"lib": ["es2015"] is needed both for running the samples inside and outside the repo using @azure/service-bus library.

@bterlson Anybody using our library in typescript will see the error
error TS2705: An async function or method in ES5/ES3 requires the 'Promise' constructor. Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your --lib option
This is probably because we are targeting es6.
https://azuresdkspecs.z5.web.core.windows.net/TypeScriptSpec.html does indeed suggest es6, but this also causes users to go through one extra step of targeting es2015 lib. Thoughts on this?

TypeScript's default lib setting when targeting ES5 won't work out of the box, but service-bus requires ES6 Map and Promise to run so requiring a lib of at least es2015 seems reasonable to try to enforce this (if it's documented in the readme 😬).
Otherwise, we can make the error go away for consumers targeting ES5 by including this in index.d.ts:
/// <reference lib="es2015.Collection" />
/// <reference lib="es2015.Promise" />

They would still have to run in an environment with Map and Promise built-in or polyfilled or they'd get runtime errors. Since we document Node 6 as the min requirement maybe this is fine?
I lean toward the safer approach, but am fine with adding the lib references too. Any thoughts?

Fixed with #1259
Debugging the samples will now run a prelaunch task that will update the @azure/service-bus reference to local lib


Add RFQ buy offer

This PR enhances the RFQ (Request for Quote) system by integrating new capabilities for managing asset buy offers. Key updates include:

A new BuyOffer RFQ offer type for improved screening of sell quotes.
Adjustments to integration tests to pre-register buy offers, aligning with realistic transaction sequences.
The negotiator RFQ service now verifies the presence of suitable buy offers when processing sell requests.

These changes mirror the existing SellOffer code.

Should there be a case in the itest to test for a missing buy offer when a sell request is received?

@jharveyb I've been told to not do too much on the RFQ service before we actually start using it. It might be revised considerably. So I think we should skip adding anything further that's non-essential.

I've added a commit which fixes this problem that @jharveyb identified: https://github.com/lightninglabs/taproot-assets/pull/861#discussion_r1544795064


uWebsocket won't work on 18.0.0 node version?

My node version is 18.0.0?

Not sure what i should do?

What does the French mean?

You posted a french message. I don't read french, and you don't seem interested in figuring out


Sort resource in Resources View not working properly

link to discussion

Implemented here - https://github.com/BlueBrain/nexus-web/pull/1479


login_check with Content-Type application/json not working

Hi guys,
When i send a post request on login_check with application/json content-type, it keeps returning me a 401 "Bad credentials", whereas if i use application/x-www-form-urlencoded everything is working perfectly.
I can see with logs that when using application/json it acts like there was no username provided :
doctrine.DEBUG: SELECT t0.username AS username_1, [...] WHERE t0.username_canonical = ? LIMIT 1 ["none_provided"] []
Any idea ? Did i miss something ?

The symfony form_login listener is not meant to handle JSON encoded requests. You should have a look at json_login (introduced in symfony 3.3, see http://symfony.com/doc/current/security/json_login_setup.html).


Adapt SNESGSS source code for the latest version of bass

Branched off of #3.
Currently the last version that can be used to compile the SPC700 side is bass v10 (v11r08 couldn't be tested on my end, and v12r03, the last one that had the align command, outputted a zero byte binary file but did not error out).

In regards to the invalid identifier for defines.  I'm pretty sure the fix is just an equals sign inbetween the name and the value.  This seemed to work for me.


provide option for storing offsets in s3 instead of zookeeper

Storing offsets in S3 may not be a great idea due to the lack of strong consistency, and could result in the  same offset being vended multiple times.

The person that brought it up had mention they were looking to use http://docs.basho.com/riakcs/latest/references/apis/storage/s3/ as way to plug it in. I don't think we would do this but providing the plugable interface for zookeeper both for consensus and offset storage is important. Probably after siesta gets tested to replace sarama.


[5.6.0] privacy & cookie policy state that they are for IS 5.5.0

On a locally-running instance of WSO2 IS 5.6.0, both the pages at authenticationendpoint/cookie_policy.do and authenticationendpoint/privacy_policy.do state that they are the policies for 5.5.0 in multiple places.  5.5.0 is hardcoded in both the cookie policy & privacy policy code rather than retrieving the current server version.

Closing issue as Product version is no longer maintained [1] in cookie policy
[1] [https://github.com/wso2/carbon-identity-framework/commit/c92b534c60a183741713beea379c5a5bb4260b51]

Thanks for the contribution @dewniMW.


Fix in-pattern without body

@palkan Thanks for your contribution, this change is released as unparser-0.5.5. Cheers.


XLSX files failing to import/export on azure web apps due to the default font.

Which version of Skybrud.Umbraco.Redirects.Import are you using? (Please write the exact version, example: 4.0.1)
4.0.1
Which version of Skybrud.Umbraco.Redirects are you using? (Please write the exact version, example: 4.0.15)
4.0.17
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
10.7.0
Bug description
When running an import or export with an excel file it's throwing an error when running in azure web apps.

I believe this is due to the default font Calibri that is trying to be used not being installed on the server, so I can imagine this extends to other servers as well.
https://docs.closedxml.io/en/latest/tips/missing-font.html#missing-font
There are some solutions outlined within the link above primarily being to search for installed fonts on the server to use as a fallback https://docs.closedxml.io/en/latest/tips/missing-font.html#use-already-installed-font or bundling in a font for ClosedXML by default instead.
I can imagine for imports having any fallback font selected isn't an issue as it's just grabbing the information but on export I don't imagine it's as straight forward if the user doesn't have the font on their device?

I think this is an issue that requires some more research. According to the documentation, ClosedXml will look for the Calibri font, and if not found, look for Microsoft Sans Serif. So in your case, loading the XLSX file probably fails because neither of the two fonts are present in the host operating system.
The solution may be to include a fallback font instead. According to your link, the Carlito font may be a good substitute that can be embedded with my package. The font license also seems to allow this. But like mentioned, I need to research and test this to be sure, so I'll save this for later when I have some more time.

We are having the same error on Azure.
Our Azure App Service Plan is using Operating System Linux
@jawood1 Is your app service plan using Windows or Linux?

Hi @lm-chpa I have the same issue for Linux and Windows based app services plans.
The issue being that fonts aren't installed on app services so when it's attempting to retrieve a font for generating the excel it can't.
It seems as suggested that the solution should perhaps include a open source font as per the documentation to get around this issue.
@abjerner just a thought on this, though it requires further investigation perhaps including the Carlito for instance as standard and if possible give developers the options to configure their own font as well?

Understood @jawood1 I thought the it would help us, changing to Windows App Service plan.
I guess it would possible to replicate the issue on mac OS or Ubuntu. I think I will try that out

just a thought on this, though it requires further investigation perhaps including the Carlito for instance as standard and if possible give developers the options to configure their own font as well?

This might be the way to go, but I haven't head the time to look any further into this.
The way I understood the issue, it's because ClosedXml uses the font for calculating the size of the text, but not so much for reading the actual text value. We don't really need the size of the text for the import, so a solution could also be to disable this part if possible in ClosedXml.
Another approach could be to simply use the first available font on the host system, assuming that there is at least one font available. Again, we don't really care about the size or how the text is rendered, so I think this should be fine as well.


Bug: addAccount() hangs indefinitely when popup is true

Expected Behavior

When useAccountManager() has the prop popup = true, the sign-in process should successfully occur in a popup window

Current Behavior

When useAccountManager() has the prop popup = true, the sign-in window opens (if browser is not full-screen on a mac) and you can enter credentials and click sign-in, but the application hangs indefinitely after that point
Appears to get stuck on createAccountObject() -> dSession.getUser() within loginOAuth2
If you wait a period of time before finishing the login after the popup opens, the login occasionally succeeds as normal

Steps to Reproduce (for bugs)

Pass in options = {popup: true} into useAccountManager()
Observe that logging into a new account results in a popup window that only successfully opens if you are not fullscreen on a mac
Add credentials and click "log in"
Observe as the application hangs and the account is not authenticated or added to local storage

Context + Screenshots

I noticed this while testing for another issue (#481), but I do not have a direct need for popup = true at this moment

Your Environment

Version used: Calcite-React 0.61.0
Browser Name and version: Chrome Version 91.0.4472.114 (Official Build) (x86_64)
Operating System and version (desktop or mobile): macOS Catalina Version 10.15.7

Further testing has revealed the erroneous behavior outlined in this issue may have originated from an outdated environment. I have been unable to reproduce on fresh installs of Arcgis-Assistant, so I am closing for now.


Set initial color uniform for fog enabled groups (Fix for Three r104)

This change fixes fog that PR https://github.com/mrdoob/three.js/pull/15467 broke. Since color is now copied instead of being forcibly applied, a THREE.Color default value is necessary.

Can you please merge this fix and also publish an updated npm module?

On my list!

Thanks @titansoftime!

Quick note: I won't publish a new NPM version until #135 is merged. Might as well bunch these two together.


Adds a new package: @microsoft/jest-sarif

This is an uncharacteristically large PR, which is not the norm. It's largely added in one PR due to the fact that it's ported from a separate project (Checkupjs), and as such was mostly implemented already.
This PR adds:

@microsoft/jest-sarif package
A general Jest matcher

toMatchSarifLog

A mechanism to build dynamic matchers based on SARIF schema fragments.

Please see the README for a comprehensive view of what's included.
Ultimately, this will form the basis for the test infrastructure in the forthcoming sarif-builder package, as this will allow us to create a powerful test infrastructure that can exercise testing SARIF schema fragments building.

I realize this is a port, but since I'm reviewing anyways, should we add some explicit type annotations where some of the inference breaks down?

@jeffersonking sounds good to me. I usually lazily ignore specific inference that can be resolved via my editor/IDE, but it does result in more complexity when reading code on Github, etc.

@scalvert Very  much agree. It would only be in places where inference isn't working. I'll add a few and we can see if we like it.

Have we considered naming it toBeValidLog and toBeValidResult?
Intuitively, when named toMatchSomething(rhs), it feels odd not to have a RHS.
Note: I have also been dropping the "Sarif" prefix on names. Just a preference but the prefix proliferates very quickly.


🫖 ApiChai

Placeholder for a tool that will standardize API integration best practices

Can you also install appraisals and define Appraisal's for (at least) rails 6.1 and rails 6.0?

@xjunior done. This is just a placeholder for now, but the appraisal stuff will be nice to have once we start setting up this gem in earnest


Xnero: Watch +447398297978

Xnero requests the watch of the watch_number +447398297978. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Jeff Schaller in Charcoal HQ


Development: Refactor LTI configuration management

[!WARNING]
ONLY DEPLOY TO TS11 WHERE LTI PROFILE IS ENABLED & CONTAINS MIGRATION!

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[x] I documented the Java code using JavaDoc style.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I followed the coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context

In the current system, each online course requires a separate LTI configuration. This means that for each new course added to the LMS, a new LTI configuration is necessary, even if the external tool is the same. This PR refactors LTI 1.3 Dynamic Registration flow to be done per Artemis instance. This means LTI configuration needs to be configured once and all online courses will be using the same configuration details for communicating with external LMS (e.g. Moodle).
Description

New LTIPlatformConfiguration database table and entity are added. Since this change only covers LTI 1.3 dynamic registration flow, only LTI 1.3 relevant properties (registrationId, clientId, issuer, authorizationUri, jwkSetUri, tokenUri) are added. These properties are removed from the OnlineCourseConfiguration database table and relevant entity and model classes. LTI 1.0 relevant properties (LtiKey and LtiSecret) remain the same. LTI 1.0 is still configurable for each online course.
View for LTI 1.3 Configuration in Course Management is removed, and a new view for single configuration information is added to the Server Administrator navbar which only Admins can access. After this PR is merged, a new follow-up PR will be implemented where online course instructors can select which LTI configuration they want to configure for this course.

Steps for Testing

PLEASE ONLY DEPLOY TO TS11 WHERE LTI IS ENABLE & CONTAINS MIGRATION!!!
Prerequisites:

1 Instructor
1 Student

Login Artemis TS11 as student. (i.e. artemis_test_user_1)
Navigate to Moodle: https://moodle.ase.in.tum.de/
Login using the same student test user credentials you used to login to Artemis TS11.
Select the "Lti Testing Course".
Scroll down to "Single Configuration Tests" topic
Navigate to "Hello World Programming Exercise" under "Single Configuration Tests" topic.
Confirm that you can view the Artemis page within the Moodle frame.
Initiate the programming exercise participation.
Submit your solution.
Navigate to the Moodle grades page (https://moodle.ase.in.tum.de/grade/report/user/index.php?id=8).
Confirm that your submission result is visible.
Go back to  "Lti Testing Course" Moodle course page.
Select a "Patterns Text Exercise" under  "Single Configuration Tests" topic and participate to exercise.
Open an incognito browser tab and login as Instructor (i.e. artemis_test_user_11).
Go to "LTI Single Configuration Test" course on Artemis and grade your text exercise. (https://artemis-test11.artemis.in.tum.de/course-management/27/assessment-dashboard)
Check the Moodle grading page (normal tab where you are logged in as student) if the grade and feedback is visible. (https://moodle.ase.in.tum.de/grade/report/user/index.php?id=8)

Please also repeat steps with the following users to Artemis newly generated user: (Please check if you test with one of the below users)

[x] username: joey_read password: use same password for artemis_test_user_1
[x] username: barney_young password: use same password for artemis_test_user_1

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

[x] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[x] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[x] Code Review 1
[x] Code Review 2

Manual Tests

[x] Test 1
[x] Test 2

Test Coverage

Client

Class/File
Line Coverage
Confirmation (assert/expect)

edit-lti-configuration.component.ts
96.66%
✅

lti-configuration.component.ts
79.41%
✅

lti-configuration.service.ts
71.42%
✅

course-lti-configuration.component.ts
100%
✅

edit-course-lti-configuration.component.ts
100%
✅

online-course-configuration.model.ts
100%
✅

lti13-dynamic-registration.component.ts
100%
✅

navbar.component.ts
88.81%
✅

Server

Class/File
Line Coverage
Confirmation (assert/expect)

LtiPlatformConfiguration.java
92%
✅

OnlineCourseConfiguration.java
100%
✅

Lti13ClientRegistration.java
83%
✅

LtiPlatformConfigurationRepository.java
42%
✅ ❌

OnlineCourseConfigurationRepository.java
not found (modified)
❌

OnlineCourseConfigurationService.java
93%
✅

Lti13Service.java
91%
✅

LtiDynamicRegistrationService.java
100%
✅

CourseResource.java
94%
✅

LtiResource.java
not found (deleted)
❌

AdminLtiConfigurationResource.java
89%
✅

Screenshots

For such a large PR, please get more than 3 approvals before setting this PR to ready to merge


proposal: decide what to do about existing container/* packages

With type parameters coming in Go 1.18, the question of how to adapt existing standard library packages is becoming pressing. In particular, type parameters are designed to allow for generic container types, so one wonders what to do with existing standard library containers. It's probably best to let 1.18 out the door before making final decisions about exactly what to add or deprecate, but OTOH, there should probably also be a framework for decision making. I don't see another issue or discussion for the general topic, so I'm opening one.
Compare #47619 (generic sort) and #47632 (generic heap).

My personal preference is:

Deprecate container/list and container/ring
Add generic container/set (#47331) and container/deque
Add a generic slice based implementation to container/heap

But I could be talked into something else.

We can't "decide" what to do with the packages without some concrete proposal about what to actually do to them; and then having such proposals, naturally part of the proposal process is to decide on them. I don't see any tangible outcome that would result from either accepting or rejecting this proposal?

Closing for https://github.com/golang/go/discussions/48287.


feat: add kemono.party support

maybe update .env.example as well? tell me if you need a pull request.

maybe update .env.example as well? tell me if you need a pull request.

Feel free to open a PR.


Make error handler public

Fixes https://github.com/Azure/azure-sdk-for-net/issues/24672

Can we test this?

Added a test

/azp run net - servicebus - tests


adapter wont work on ps2

BlueRetro firmware version
24.04
BlueRetro firmware specification
HW1
BlueRetro firmware variant
Universal
BlueRetro hardware type
External adapter with detachable cord
Manufacturer
blue retro gaming store
System used
Sony PlayStation 2
Bluetooth controller brand & name
xbox series X/S controller
What is problem? (only list ONE problem per report)
i have a ps1 5000 and a ps2 slim 70000. i testes on the ps1 and works fine but when try on the ps2, lights dosent turn on. if i press en button a green light apears (for reboot blueretro) , if press the other buton to change to pair mode nothings happen.
console works fine with wired controllers so not a problem of the ports
What did you expect to happen?
works fine on ps2
Attach files like logs or Bluetooth traces here
No response

Sorry to answer you instead of the devs, but, are you sure your controllers port are providing 8v? Do your joysticks rumble when they are supposed to? I had a similar problem in my ps1, and it turned out it was the 8v fuse inside the console (Im still waiting for the fuse to arrive from china).


StyleCop Analyzers rules are not being picked up during build

I am facing some difficulty. My configuration is as follows

[ ] StyleCop.Analyzers version 1.0.2
[ ] Microsoft.CodeAnalysis.FxCopAnalyzers version 2.6.2
[ ] Visual Studio Enterprose 2017 version 15.8.9
[ ] .NET Standard Library 2.0

Following lines were added to configure the ruleset and stylecop.json
  <PropertyGroup>
    <CodeAnalysisRuleSet>..\..\..\References\CodeAnalysis\Sample.ruleset</CodeAnalysisRuleSet>
  </PropertyGroup>
  <ItemGroup>
    <AdditionalFiles Include="..\..\..\References\StyleCop\stylecop.json" />
  </ItemGroup>

While I build the project, I don't see all the rules are being picked up and shown as errors or warnings. I have set up all the stylecop rules to be addressed as Error in the ruleset.
As a temporary solution, I added StyleCop.MSBuild and  StyleCop.Error.MSBuild. After adding these two nuget packages, I started getting the errors. I am not sure why do I need to add the above two nuget packages to show all the errors.
Looking for help to know how to show the errors/warnings(during build) as set up in ruleset file, without adding StyleCop.MSBuild and  StyleCop.Error.MSBuild.

I was trying to get SA1600 without turning on the xml output. Once I turn on xml output, it starts working.


Igonchar/tdi 43912 remove bnd to spring bean name generator

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://jira.talendforge.org/browse/TDI-43912

Pull request test result: success :star:
Sonar results


Updated the IP firewall rules limit to 256

@Peter-Msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@VanMSFT
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"

@rohitnayakmsft - Hey Rohit, can you please review these changes?

@Peter-Msft have you confirmed this change with the Sql Connectivity team? AFAIK the limit is unchanged

@Peter-Msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@rohitnayakmsft - The change is confirmed by connectivity team.

#sign-off

@rohitnayakmsft: I'm sorry - only the author of this article, @VanMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@VanMSFT - Can you sign this off? Thanks

#sign-off


#84: Accessibility page

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #84
Test URLs:
USA:

Before: https://develop--24petwatch--hlxsites.hlx.page/drafts/miweis/accessibility
After: https://84-accessibility--24petwatch--hlxsites.hlx.page/drafts/miweis/accessibility

Canada:

Before: https://develop--24petwatch--hlxsites.hlx.page/drafts/miweis/ca/accessibility
After: https://84-accessibility--24petwatch--hlxsites.hlx.page/drafts/miweis/ca/accessibility

after updating with the latest develop branch, no additional code changes are needed for these pages
closing this PR


feat: introduce filters page

Sort of minor, but I'd expect to see the active state to be on the right side of the switch https://material-components.github.io/material-components-web-catalog/#/component/switch

Yep, both would be valid approaches https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Switch_role#Result
Will be easy enough to change once we see the designs.


Failed to create a contract object by obtaining the ABI through the API.

Describe the bug
A clear and concise description of what the bug is.
Failed to create a contract object by obtaining the ABI through the API.
To Reproduce
Steps to reproduce the behavior
`export const claim = async (address, privateKey) => {
const starkKeyPair = ec.getKeyPair(privateKey);
const starkKeyPub = ec.getStarkKey(starkKeyPair);
const account = new Account(provider, address, starkKeyPair);
// initialize contract using abi, address and provider
const contractAddress = "0x00630eb5544172af8716956ff6b8f382b17b8d67f11bf1d8e9e7c8e10e31a2ac"
const contractClassHash = "0x03bc24c464f6904a8a678ae03ca4d922dd4879392a438078989ad203157d957f"
const contractClass = await provider.getClassAt(contractAddress);
if (contractClass.abi === undefined) { throw new Error("no abi.") };
const contract = new Contract(contractClass.abi, contractAddress, account)
// make contract call
const result = await contract.airdrop_amount(address)
console.log("claim", address, result)
return result
}
`
Expected behavior
A clear and concise description of what you expected to happen.
The contract can be called normally after obtaining the ABI.
Screenshots
If applicable, add screenshots to help explain your problem.
TypeError: Cannot read properties of undefined (reading 'length')
Desktop (please complete the following information):

Browser & version [e.g. chrome, safari, webworker]
Node version [19.8.1"]
"starknet": "^4.22.0"
Network [mainnet-alpha]

Additional context
Add any other context about the problem here.

Hello!
I guess your issue is because you call this contract  which is a Cairo 1 contract, but starknet JS 4.22.0 doesn't support Cairo 1 contracts.
Please try with v5 : npm install starknet@next
And check the guides for changes in v5: https://www.starknetjs.com/docs/next/guides/migrate


Create SECURITY.md

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.72%. Comparing base (7c14308) to head (fac6dc5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   48.72%   48.72%
=======================================
  Files          52       52
  Lines        3368     3368
=======================================
  Hits         1641     1641
  Misses       1583     1583
  Partials      144      144

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


addImage createDataURIFromElement/getImageDataFromElement canvas image format

Hello, I noticed something with the version 1.5.3 in addImage createDataURIFromElement where the format parameter is ignored if the nodeName is canvas. In 1.4.1 the format was set depending on this parameter.
Now in recent updates: #2374 the format parameter has been removed which removes the ability to define what format you'd like to specify for the data.
I am working on trying to get a reproducible code snippet but it's proving difficult as the use case is kind of hard to isolate. However I do think this regresses the behaviour from 1.4.1. What do you think?

Well, what is the benefit?

@arasabbasi I think that if a thing that previously worked stops working, it should not be removed in later versions, I have the feeling that it has been omitted by mistake when updating from one version to another, or some commit has been lost or crushed. I had to go back to version 1.4.1, to be able to use jsPDF with images through URL.
Thanks for your work.

@es11400
Well,  That feature-removal was accidently removed. But I streamlined and refactored the the image-processing and it should work again.
My question was more what the benefit is to set the canvas as png or jpeg as it is for me no difference, but anyhow... I reactivated the feature... well i think I did... didnt tested it. See #2416

You're right, I do not see difference either, I look at # 2416 and try. Thank you

I could show you a before and after on Monday when I get a chance but it does make a difference. As I said it's a probably a pretty unique use case so it may not be obvious how it matters.

@arasabbasi It does not work with a url, it returns the same error, with version 1.5.3, do I need to update something?
Add ScreenShoot, it is the same error as in the example

Re-opening in the interest of @es11400
I had applied a patch a few weeks ago to my copy of jspdf so I know it works for my use case.

clone project locally
npm run-script build
npm start
open in browser http://localhost:8000
Do it again.

Thanks in local works well.
When will it be available to everyone? with yarn add jspdf does not work, when I deploy my project in production it stops working.

@es11400
This Tuesday MrRio wrote me that today is the day (of release) and I responded, that I found a huge bug (pages lose orientation when starting with landscape mode) and that I want to fix that. Tbh, last release was kind of emberassing. So I want to have a good version this time.
But I am now kind of sure, that most of the bugs are fixed.

As it is solved and I like to close issues ;)


Activate submenu without clicking "+"

Is it possible for the submenu to show by clicking the entire parent row/label? Currently the "+" must be clicked to show it. Would be nice if the entire row is clickable.
Also, would be possible to remove/change the word "Menu"?

Hi suscurio,
There are many menus in the market that already function that way. What makes Stellarnav unique is the ability to click on the parent menu. For instance, if you have an "About Us" page with content and it's a top level item on the nav, you would want users to be able to click on that page. Therefore it's important for the submenu to show only when clicked on the "+" button.
To remove the word "menu", you can add this to your custom scripts:
jQuery('.stellarnav.mobile .menu-toggle').text('').append('');
To change the word "menu" to "navigation" or something else you can use the same concept:
jQuery('.stellarnav.mobile .menu-toggle').html(' Navigation');

@suscurio if you need this behaviour, you can slightly modify stellarnav.js. Something like this:
		// adds toggle button to li items that have children
			nav.find('li a').each(function() {
				if ($(this).next().length > 0) {
					$(this).addClass('dd-toggler');
					$(this).parent('li').addClass('has-sub').append('');
				}
			});

			// expands the dropdown menu on each click
			nav.find('li .dd-toggler').on('click', function(e) {
				e.preventDefault();
				e.stopPropagation();
				$(this).parent('li').toggleClass('hover');
				$(this).parent('li').children('ul').stop(true, true).slideToggle(250);
				$(this).parent('li').toggleClass('open');
			});

Brilliant, @suscurio.   Just what I needed.    Incidentally, I double the suggestion that this be a top-level option!  Cheers jb


Fix for quit button alignment #185

This resolves the issue #185 with the quit button being not in left alignment with the other buttons in the on/off "Application" panel.

hi @SBero! +5


Error When Compiling 119.0.6045.159-1.1

I was able to compile 119.0.6045.123-1.1 without any issues but when I try the latest release it gives me ModuleNotFoundError: No module named 'httplib2' I did pip install httplib2 and it seems to have compiled, I was wondering if there was a better solution to this? Also does Ungoogled Chromium still require pypiwin32 to compile?

httplib2 is required since we switched to a new method to acquire the source code. Seems like I forgot to update the README with the new dependency. Thanks for the hint!

I was also wondering, is there a way to remove this?

I have same error

I had installed httplib2

but when i run python build.py ( I use python because my python3 is in v3.11) and I have this error

This is an old issue, that didn't show much activity recently and probably lost its significance — closing.
If you have any more information to add, let us know.


Upgrade python client deps

Closes #56
Closes #55

TODO

[x] Upgrade everything
[ ] Fix for multipart uploads

Object of type SerializationIterator is not JSON serializable Looks like pydantic model_dump is converting the file objects to SerializationIterator from pydantic core. Not sure how to actually get the value out of the thing
https://github.com/pydantic/pydantic/issues/8907

Hi guys!
Any recent updates regarding this PR? It would be awesome to support the use of Pydantic 2.0.

Hey @edugmes, this is currently blocked by https://github.com/pydantic/pydantic/issues/8907. Due to that issue, Pydantic 2.0 breaks multipart uploads

👋🏽  @benogle -- we're grateful for your work with Anvil and are sorry to see that it seems Pydantic isn't able to prioritize the update. Anvil is blocking the upgrade across the core monolith at an Org I'm working with. This is going to be a bigger issue as pydantic 1.1X.xx has more issues with Python 3.13.
I want to suggest an approach that we can remove once the issue is eventually fixed that will check for the Pydantic version and special case handling in versions after 1.
I can put in a PR, but wanted your perspective of whether you'd be open to this approach to unblock your community from upgrading to Pydantic 2 and beyond.
Note this isn't final code, just a technical suggestion.
from typing import Any, Union
from io import BufferedReader
import warnings

try:
    from pydantic import BaseModel as PydanticBaseModel
    from pydantic.version import VERSION as PYDANTIC_VERSION
    IS_V2 = not PYDANTIC_VERSION.startswith('1')
except ImportError:
    from pydantic.v1 import BaseModel as PydanticBaseModel
    IS_V2 = False

class FileCompatBaseModel(PydanticBaseModel):
    """
    Base model that maintains Pydantic V1 behavior for file objects when using model_dump()
    """
    def model_dump(self, *args, **kwargs):
        """
        Override model_dump to extract file objects from SerializationIterator in V2
        """
        data = super().model_dump(*args, **kwargs)
        return self._extract_file_objects(data)

    def _extract_file_objects(self, data: Any) -> Any:
        """
        Recursively process dictionary to extract file objects from SerializationIterator
        """
        if isinstance(data, dict):
            return {k: self._extract_file_objects(v) for k, v in data.items()}
        elif isinstance(data, list):
            return [self._extract_file_objects(v) for v in data]
        elif str(type(data)).endswith('SerializationIterator'):
            # Access the underlying file object from SerializationIterator
            try:
                return data.iterator
            except Exception:
                warnings.warn(
                    "Failed to extract file object from SerializationIterator. "
                    "This might cause issues with file handling."
                )
                return data
        return data

Hey @cyrusradfar, I'm open to anything that works around the issue. If you can make multipart uploads work with pydantic, I'm all ears :)

Hey @cyrusradfar, I'm open to anything that works around the issue. If you can make multipart uploads work with pydantic, I'm all ears :)

Thank you, I'll work on a solution that's totally not a hack...


Add capability to declare "before" ordering and make -t clean work

Enable folding --clean tasks in with other tasks and change --clean to just be an alias of -t clean.

/azp run Build - client packages


Adivse :  Rembeber GIT LFS

In the README, I think it would be helpful to mention the need to use Git LFS, at least for the dependencies in lightweightvk\third-party\deps\src\ktx-software. This is necessary and could save someone from a lot of headaches. Thank you very much for all the work you do, best regards.

https://git-lfs.com


Create linode.js file and add all Linode docs in the README.md to the file

Follow this structure to know where you will create your file:

awesome-oss-docs/awesome-oss-docs/src/constants/docs/orderByAlphabet

Add all Linode docs to the file you created,. Each docs are added in this format:

{
title: 'Airflow Docs',
description:
'A platform to programmatically author, schedule, and monitor workflows.',
projectUrl: 'https://airflow.incubator.apache.org/docs/',
githubUrl: 'https://github.com/apache/airflow/tree/main/docs',
owner: 'Community Owned Documentation',
},
For better insight of how the file should look like check out the Apache File

After adding all docs, Go to the index.js file in the docs folder, create an import of the file you added and put the name in the export default array

Can you please describe the issue? I would like to work on it.

hello kindly assign me to this... thanks

Solved #166


Add support for mssql instances.

Mssql can have multiple instances on one server. In that case every instance waiting for connections on its own port and you can determine port you need via 1434/udp port.
"github.com/denisenkom/go-mssqldb" driver support this feature, but when i try
usql "ms://user:pass@mssql-server\INSTANCENAME/dbname"
I got error: could not connect to database: parse ms://user:pass@mssql-server\INSTANCENAME: invalid character "\\" in host name.

I just pushed a change to dburl which is the related package used by xo and usql to parse database URLs. Unfortunately, the Sql Server Browser is not supported by the Linux version of SQL Server, and so I cannot test this easily, as I don't have SQL Server installed anymore on a VM to test with.
If you built this from source, you can simply do:
go get -u github.com/knq/dburl

And then:
go install github.com/knq/usql

(or go build or whatever)
Please test this, and let me know if this fixes the issue. The syntax I chose for the URLs is the following:
sqlserver://user:pass@host:port/instance/dbname

Where the /instance portion is optional. If you could try this locally, I'd greatly appreciate it. I'm getting usql into a point where I will also include vendored versions of the few dependencies used (which includes dburl), so I'd like to test this. Your feedback would be greatly appreciated!

Also, for anyone else coming across this issue, please see this page for documentation on what URLs work with dburl (and subsequently usql): https://github.com/knq/dburl

Thanks!
Looks like everything works good.


Use custom property names for select

Is it possible to use custom property names for a select.
For example I have the following array:
[
  {
    id: 1,
    name: "blaat"
  },
  {
    id: 2,
    name: "another blaat"
  }
]

And define in the metadata to use id and name as respectively value and name?

@Alber70g I have added this to the Material repo and I will try to find time to add it to the Bootstrap one also, but as of right now it doesn't give you the option, you would have to parse it on load. I am not sure if the dynamic select add-on can do it or not, may be worth checking that one.


mathematica: Refactor install process with autoPatchelfHook

Motivation for this change
The current fixup procedure uses brittle heuristics for distinguishing executables and shared libraries which often results in unpatched executables (e.g. bundled Java compiled as a PIE).
Replacing the bespoke patching script with autoPatchelf greatly simplifies the derivation and makes supporting external links such as CUDALink trivial (will open PR if this is merged).
Some additional deps were added to maximally fulfill autoPatchelf. Some deps remain unsatisfied (mostly related to CUDALink and RLink) and will require future work.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Built on NixOS unstable (22.05), with flakes, and both with and without CA derivations.
Tested with Mathematica versions 13.0.0 and 12.3.1.

Thanks. It is a pretty considerable change. I will try it out here in the following days, and let us discuss it later.

Sorry for the delay. I was a bit overloaded recently. I am okay with the changes.
However, I have an additional idea to discuss. I tried to add a group of automated tests through nixosTests during the verification process. Unfortunately, the attempt failed because an activated Mathematica was needed to execute scripts. Without activation, the execution of commands like math -script some-script.m always fails with "No valid password found."
Considering that you will adjust the derivation further, and we will also definitely have other updates in the future, I think it is worthy to curare a test suite of some form here, even if it can only be used by an activated installation. Personally, I have done such things several times, we may need to standardize it, albeit it will not be integrated to NixOS's automated process.
What do you think?

@herberteuler You could add some tests referencing mathematica to mathematica.passthru.tests, and then at least people who have access to the license can run those.

That was exactly my attempt. But the tests are run in a qemu virtual host, where we always get a fresh, unregistered version.

Sorry, I missed your point. I suppose the license key could be supplied via some definition in ~/.config/nixpkgs like config.mathematica.license_key.

There is currently no such option yet. But I see a potential solution from your inspiration. Let me try it.

@veprbl I just got the reply from Wolfram:

Thank you for contacting Wolfram Technical Support. A virtual machine will have its own machine ID (MathID) which should have its unique activation key to activate Mathematica or other Wolfram products installed on it. If you would like to do a system transfer, please see:
https://support.wolfram.com/12412

It seems to me that the only way to test would be doing them on the host. I intend to add some test facilities, perhaps independent from the existing testing framework. What do you think?

The DRM is quite hostile. Plus, I assume, it won't be possible to test the GUI via the command line interface. I appreciate your efforts in testing these updates, but if it doesn't lend itself to systematic testing, it may not be worth it.

As far as I know, it is possible to run tests via the CLI math --script. However, I agree with your point on systematic testing, so let's accept this as a pity.


follow up for final tuple classes – scala/scala#5257

 /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.5/project-builds/twitter-util-3ecf6d03ea63cea0a4fd70085fc0a7dee036c0ca/
util-core/src/main/scala/com/twitter/concurrent/ConcurrentMultiMap.scala:12:
illegal inheritance from final class Tuple2
   extends Tuple2[K, Option[V]](k, v) [twitter-util]

ref scala/scala#5257

this is being handled at https://github.com/twitter/util/issues/174 — we should be able to unfork very soon

unforked!


golangci/golangci-lint v1.37.0 released

https://github.com/golangci/golangci-lint/releases/tag/v1.37.0

refs #232

refs #232


Questions

is there any reference documentation for adding custom IP core?...like aes, hmac examples at sw/device/tests/. if I've my custom component in verilog/system verilog in hw/ip/ and corresponding software implementation at sw/device/lib or at sw/vendor/ (like crypto).
Is there any 32bit linux support available for opentitan?

Please have a look at our [comportability
The software story is a bit more in flux.  The general idea is that we want to separate out a baremetal, low level library that other pieces of software can build upon.  I've added a few people who can better answer that question.
I do not believe anyone has tried porting linux to opentitan thus far.

Please have a look at our [comportability
The software story is a bit more in flux. The general idea is that we want to separate out a baremetal, low level library that other pieces of software can build upon. I've added a few people who can better answer that question.
I do not believe anyone has tried porting linux to opentitan thus far.

OpenTitan doesn't have an MMU, no XIP-capable external memory bus, and a very small amount of RAM.  I think it might be possible to get it running, but we don't have any plans to do that work at this point.

@Avani8 would adding a SoftCPU on the same FPGA help?
This way you could have CPU running Linux in parallel of OpenTitan, but then you will also hit the issue of memory isolation.
@gkelly just for the test, it should be possible to add some small footprint SoftCPU and fit it on the Artix-7 FPGA together with the OpenTitan?

@tomoveu .sure, adding SoftCPU on the same FPGA helps, but we are planning on ASIC implementation with our custom component and opentitan. Our work does not require full Linux support. But supporting coreboot  or ecos is what we might try eventually.
@tomoveu I saw your FR regarding PCR like register implementation. We are also interested in that feature. and thanks for explaining things in https://github.com/lowRISC/opentitan/issues/1112(URL)

I guess all questions have been answered, closing. Please open a new issue if you have further questions.


Add a known lemma ingester for post-correction

Currently, you can't add unknown lemma for post correction. Just add one

@mikekestemont Is post-correction taking into account in the current training system ?

It's an option in the config file: if postcorrect is set to True, the generated tokens will be convert to their closest Levenshtein neighbor. It should be relatively easy to manipulate to known lemma list which is stored as plain text under the model dir. You can do this already manually right now before reloading the model but we could also add an option for this.


Cargo should pass -W unstable=allow when building examples, tests and benches

Tests, examples and benches are written against a library. If this library's functions are marked as unstable (which should be the case during the library's development process), compiling them will produce lots of warnings which don't really make sense.
This will be even worse when unstable will switch from warn to deny. You will be forced to add #[allow(unstable)] in every single test, bench or example.

Due to https://github.com/rust-lang/rfcs/blob/master/text/0507-release-channels.md and the clear indication that stability attributes aren't intended for third-party libraries right now, I don't think that Cargo wants to do this.
In a theoretical system that Cargo does grow, however, this would most certainly be a concern!


[PE-D][Tester B] Not enough visuals for command?

The only screenshot I see in the User Guide is at the Quick Start. I thought it would be better if you provided screenshots for all commands, so that the reader have a easier time reading and visualizing and understanding the commands
I would like to quote from the textbook:
These are considered UG bugs (if they hinder the reader):
Use of visuals
Not enough visuals e.g., screenshots/diagrams

Labels: severity.Medium type.DocumentationBug
original: UnwilledTangent/ped#7

Closed by UG updates


Missing expires_in in token response

Although I see expires_in being checked in tests, I do not see it returned with the access token.
Is this an oversight?

Could you please provide file and line numbers where you see both the tests for it and where you think it is missing?
Sent from my iPhone

On Jun 18, 2015, at 7:14 AM, Matt Miller<EMAIL_ADDRESS>wrote:
Although I see expires_in being checked in tests, I do not see it returned with the access token.
Is this an oversight?
—
Reply to this email directly or view it on GitHub.

I just run into this issue using resource owner password credentials. I check the other flows and it seems to affect them as well. I tracked the source to the lib/exchange/passwords.js file line 113
var tok = {};
tok.access_token = accessToken;
if (refreshToken) { tok.refresh_token = refreshToken; }
if (params) { utils.merge(tok, params); }
tok.token_type = tok.token_type || 'Bearer';

var json = JSON.stringify(tok);
res.setHeader('Content-Type', 'application/json');
res.setHeader('Cache-Control', 'no-store');
res.setHeader('Pragma', 'no-cache');
res.end(json);

As you can see there is no 'expires_in' property attached in the token creation. In the tests in the test/exchange/password.test.js file line 166 there is a test like this
it('should respond with body', function() {
    expect(response.body).to.equal('{"access_token":"s3cr1t","refresh_token":"blahblag","token_type":"foo","expires_in":3600}');
});

This time the token contains a expires_in property. I know is silly to implement your own token expiration logic but I think this should be documented somehow.

I found the solution for my case - the library allows you to pass a params hash into the done call, see https://github.com/jaredhanson/oauth2orize/blob/c59aefd14b0fb98f97e3419b8d611c0fb4255c69/lib/exchange/password.js#L27 for example.
This is where you pass the expires_in value, as is done is tests: https://github.com/jaredhanson/oauth2orize/blob/c59aefd14b0fb98f97e3419b8d611c0fb4255c69/test/exchange/password.test.js#L13
Implementing your own logic for expires_in is fine and makes the library more flexible, but I agree it would be nice to add this to the readme or examples.

Yes, I also used the params hash and implemented my own custom expiration logic but tokens almost always inform the client when they will expire so implement this in the examples and explain in the readme that oauth2orize does not make decitions about this by default can save you a lot of time and headaches.


[AutoPR] cosmos-db/resource-manager

Created to accumulate context: cosmos-db/resource-manager

(message created by the CI based on PR content)

Codecov Report

Merging #2556 into master will increase coverage by 0.3%.
The diff coverage is 40.42%.

@@            Coverage Diff            @@
##           master    #2556     +/-   ##
=========================================
+ Coverage   55.25%   55.56%   +0.3%
=========================================
  Files        6490     6494      +4
  Lines      142522   144312   +1790
=========================================
+ Hits        78756    80183   +1427
- Misses      63766    64129    +363

Impacted Files
Coverage Δ

azure-mgmt-cosmosdb/azure/mgmt/cosmosdb/version.py
100% <100%> (ø)
:arrow_up:

...ure-mgmt-cosmosdb/azure/mgmt/cosmosdb/cosmos_db.py
100% <100%> (ø)
:arrow_up:

...mt-cosmosdb/azure/mgmt/cosmosdb/models/__init__.py
100% <100%> (ø)
:arrow_up:

...osmosdb/operations/database_accounts_operations.py
59.15% <12%> (-6.67%)
:arrow_down:

...mosdb/azure/mgmt/cosmosdb/models/error_response.py
63.63% <63.63%> (ø)

...b/azure/mgmt/cosmosdb/models/error_response_py3.py
63.63% <63.63%> (ø)

.../mgmt/cosmosdb/models/region_for_online_offline.py
71.42% <71.42%> (ø)

...t/cosmosdb/models/region_for_online_offline_py3.py
71.42% <71.42%> (ø)

...ces/search/entitysearch/models/lodging_business.py
69.23% <0%> (-5.77%)
:arrow_down:

...s/search/entitysearch/models/food_establishment.py
69.23% <0%> (-5.77%)
:arrow_down:

... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf982e...52d7d5c. Read the comment docs.