Django integration: You cannot access body after reading from request's data stream

How do you use Sentry?
Sentry Saas (sentry.io)
Version
2.0.1
Steps to Reproduce
Environment info:
django=5.0.4
djangorestframework=3.15.1

Add sentry integration to django app:

if ENV != "development":
    sentry_sdk.init(
        dsn="https://....ingest.sentry.io/6010199",
        integrations=[
            DjangoIntegration(
                transaction_style="url",
                middleware_spans=True,
                signals_spans=True,
                cache_spans=False,
            )
        ],
        debug=DEBUG,  # This is true in this case
        send_default_pii=True,
        environment=ENV,
    )

`logger.exception("This is an exception")
See traceback

Expected Result
Either the exception is successfully logged to Sentry, or it's not sent to Sentry at all since it's a log entry and not an unhandled exception.
Actual Result
# Traceback for the `logger.exception` call goes here

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/sentry_sdk/integrations/django/__init__.py", line 555, in parsed_body
    return self.request.data
           ^^^^^^^^^^^^^^^^^
AttributeError: 'ASGIRequest' object has no attribute 'data'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/sentry_sdk/integrations/django/asgi.py", line 56, in asgi_request_event_processor
    DjangoRequestExtractor(request).extract_into_event(event)
  File "/usr/local/lib/python3.12/site-packages/sentry_sdk/integrations/_wsgi_common.py", line 96, in extract_into_event
    parsed_body = self.parsed_body()
                  ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sentry_sdk/integrations/django/__init__.py", line 557, in parsed_body
    return RequestExtractor.parsed_body(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sentry_sdk/integrations/_wsgi_common.py", line 142, in parsed_body
    return self.json()
           ^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sentry_sdk/integrations/_wsgi_common.py", line 154, in json
    raw_data = self.raw_data()
               ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/sentry_sdk/integrations/django/__init__.py", line 538, in raw_data
    return self.request.body
           ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/django/http/request.py", line 328, in body
    raise RawPostDataException(
django.http.request.RawPostDataException: You cannot access body after reading from request's data stream

Hi @Audiopolis, I attempted to reproduce your issue using this code, but I did not observe the error message that you reported.
Can you please clarify how exactly you encountered this issue? If possible, please share a reproduction with me (you can also do so by opening a PR on my reproduction repo and sharing a link to the PR here).

@szokeasaurusrex Thanks for trying. I will try to create a reproduction. In the meantime, I'll clarify how I encountered the issue:
We send an email from a Django view using Resend. In this environment, Resend does not recognize the domain, so it throws an error. We catch that error and use logger.exception(...) instead, where logger = logging.getLogger(__name__). The view returns a 201 response. Then, the exact traceback I added to this issue description is printed.
The original request is automatically converted from an ASGIRequest (no data attribute, and can only read body once) to a RES framework Request (has a cached data property) by REST framework. I don't know how Sentry gets the original ASGIRequest instead of the DRF Request, but since it does, it makes sense that 'ASGIRequest' object has no attribute 'data' and You cannot access body after reading from request's data stream. I will have to analyze the situation more closely and provide a reproduction.

Same error is also happening inside Sentry with SDK 2.1.1:
  File "/usr/local/lib/python3.11/site-packages/sentry_sdk/integrations/django/__init__.py", line 555, in parsed_body
    return self.request.data
           ^^^^^^^^^^^^^^^^^
AttributeError: 'WSGIRequest' object has no attribute 'data'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/sentry_sdk/integrations/django/__init__.py", line 486, in wsgi_request_event_processor
    DjangoRequestExtractor(request).extract_into_event(event)
  File "/usr/local/lib/python3.11/site-packages/sentry_sdk/integrations/_wsgi_common.py", line 96, in extract_into_event
    parsed_body = self.parsed_body()
                  ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/sentry_sdk/integrations/django/__init__.py", line 557, in parsed_body
    return RequestExtractor.parsed_body(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/sentry_sdk/integrations/_wsgi_common.py", line 142, in parsed_body
    return self.json()
           ^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/sentry_sdk/integrations/_wsgi_common.py", line 154, in json
    raw_data = self.raw_data()
               ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/sentry_sdk/integrations/django/__init__.py", line 538, in raw_data
    return self.request.body
           ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/http/request.py", line 328, in body
    raise RawPostDataException(
django.http.request.RawPostDataException: You cannot access body after reading from request's data stream", "level":"error", "name":"sentry_sdk.errors"}

Can be seen here: https://cloudlogging.app.goo.gl/yfAdqBdmA8iER8ZQ8 (retricted link)

So just to expand on what was already written here, the way DRF works is that it wraps the native Django WSGIRequest (or ASGIRequest) in its own Request. The wrapper class adds some stuff on top and proxies everything else to the underlying Django request.
We capture the data here. Basically, self.request.data is only expected to be there if this is a DRF Request; otherwise we essentially fall back to self.request.body (that's what RequestExtractor.parsed_body(self) eventually looks at). Reading the body on a Django request should be fine but in some cases the body has already started being read and we hit this.
The quick "fix" would be to capture RawPostDataException when we try to access request.body and just give up on reading the body ourselves and return None. However this doesn't address the underlying problem of why request.data is not there in the first place (it indeed looks like we're working with the Django request instead of the DRF one).
Wasn't able to repro this yet -- @Audiopolis What does the request look like in your app? I assume it's a POST? Does it contain any form data, uploaded files, etc.? Do you access anything on the request in the view?


Video link in README is not accessible

The following link is not accessible: https://msit.microsoftstream.com/video/d8c50840-98dc-a27a-806a-f1ed2daa33a9
Is it possible to upload video to Youtube?

Hi @azhozhin, this video is currently internal accessible for Microsoft accounts.


Add linting for short codes

Add linting for short codes to ensure the open and closing tags match up. This will help us prevent potential build failures.
reference: https://github.com/pulumi/registry/pull/2229

This would be awesome! Do you know any linting tool that handles Hugo shortcodes?


Update bedrock-autoloader.php

Call load_plugins() method on construct instead of the plugins_loaded hook
The mu-plugins are actioned before normal plugins in the action order. Some mu plugins are required
The bedrock-autoloader mu-plugin seems to fulfil two purposes. it a) allows the use of composer to make mu-plugins dependancies by running mu-plugins from within directories. b) allows normal plugins to act like mu plugins. However by running the mu-plugins further down the action order list, neither mu-plugins or plugins are behaving exactly as standard mu-plugins do as standard in wordpress. This could be important if the mu-plugin you are requiring via composer does some setup that normal plugins will then use. In the current implementation it will be loaded after the normal plugins.

@swalkinshaw just realised the description for this plugin is out of date since this change, could that be updated too?

@christiansherry good catch, just updated it.


[Bug] Automated User Block unlimited ExpOrbs

Minecraft version & Mod Version:
MC 1.12.2
Cyclic-1.12.2-1.12.1
Modpack: All the Mods 3
Single player or Server:
Multiplayer Server
Describe problem (what you were doing / what happened):
I use the block to right click Solidified Experience from Actually Additions.
I piped those items into it and disconnect all cables to it.
The block was filled with Solidified Experience and started to use them. After 63 items they will no longer be used up. The block still generates the Experience Orbs, but does not consume any more items.
This allows you to create infinite experience.
This is the status in which the block creates infinite experience.

Btw, you can also easily turn the block on and off via Redstone Input Settings.

Yep it leaves 1 remaining item and doesnt consume.  Very weird, when its something like Eggs, it does consume the last.

https://minecraft.curseforge.com/projects/cyclic/files/2542723


Problems with modals

I don't know what is the best way of implement a .modal, but this is my code:
<template name="List">
    {{# if showModal}}
    <div class="ui modal new">
        ...
    </div>
    {{/ if}}
</template>

Template.List.onRendered(function () {
    Session.set("showModal", false);
});

Template.List.helpers({
    showModal: Session.get("showModal")
});

Template.List.events({
    "click .button.new": function () {
        Session.set("showModal", true);
        $('.ui.modal.new').modal({
            onHide: function () {
                Session.set("showModal", false);
            }
        }).modal('show');
    }
});

But .modal is moved to the end of the body tag, outside the {{#if ...}.
Any suggestions?

Modals will detach themselves from DOM and position themselves as children of body. This is to reduce reflows caused by animations (modals are notoriously bad performers)
You can disable this behavior by specifying detachable: false in init
http://semantic-ui.com/modules/modal.html#settings


Auxiliary constructors with configured codecs

Following code does not compile with Circe 0.11.1. It is the existence of the auxiliary constructor which triggers the issue, removing it makes the code working fine.
The issue is only with generic.extra codecs (semiauto or auto), normal generic codecs work fine.
import io.circe._
import io.circe.parser._
import io.circe.syntax._
import io.circe.generic.extras.Configuration
import io.circe.generic.extras.auto._

object AuxConstructors extends App {
  implicit val customConfig: Configuration = Configuration.default.withSnakeCaseMemberNames.withDefaults

  case class Foo(i: Int, s: String = "") {
    def this(s: String) = this(0, s) // remove or comment out this line to make it work
  }
  val foo = Foo(0)

  val json = foo.asJson.spaces2
  println(json)

  val decodedFoo = decode[Foo](json).right.get
  println(decodedFoo)

}

The error is:

Error:(15, 18) could not find implicit value for parameter encoder: io.circe.Encoder[AuxConstructors.Foo]
val json = foo.asJson.spaces2

The issue was also mentioned in this Stack Overflow question, but I cannot find it reported properly.

This seems to be a Shapeless bug:
scala> case class Qux()
defined class Qux

scala> case class Foo(i: Int)
defined class Foo

scala> case class Bar(i: Int) { def this() = this(0) }
defined class Bar

scala> shapeless.Annotations[Qux, Foo]
res0: shapeless.Annotations[Qux,Foo]{type Out = None.type :: shapeless.HNil} = shapeless.Annotations$$anon$1@577d35bc

scala> shapeless.Annotations[Qux, Bar]
<console>:16: error: could not find implicit value for parameter annotations: shapeless.Annotations[Qux,Bar]
       shapeless.Annotations[Qux, Bar]
                            ^

We could probably work around the bug here by using the null default value trick for the Annotations instance. I'm not sure I'll be able to get around to this, but I'm happy to review.
Someone could also try opening a Shapeless issue (at a glance there doesn't seem to be one).

Closing in cleanup run, If anyone cares about this, please comment and I'll reopen.

This bit me too.  I filed a shapeless ticket:  Auxiliary constructors with configured codecs #1372.


Make how Qt packages are found more convinient

This change allows users to specify Qt5_DIR or Qt6_DIR and then the rest of the components are automatically found. Prior to this, since find_package() was called for each component of Qt, CMake configuring would fail with each component not found. So you would have to specify all the paths at once.
I'm not sure if find_package(Qt${ARGS_QT_VERSION}${base_component} REQUIRED COMPONENTS Private) is needed, but if so I can add it back in. From my testing, things worked as expected.

Thanks, Paul!


“Go there, find that thing, and then click on the link” – just provide a link, it's easier

I'm a Perl 5 programmer. Where is a list of differences between Perl 5 and 6?

See the pod with the 5to6- prefix under https://docs.perl6.org/language.html

Let's just say “See language/5to6-nutshell”.
However, we should also provide a link to https://docs.perl6.org/language/rb-nutshell, perhaps requires some rewording in the question.
Now, this does not really tell about other 5to6 documents. I think that 5to6-nutshell page itself should provide these links on the top, so that we can point any Perl 5 user to that page and eventually he/she will find everything needed.

718e0584f571d4a5147894abed6f341638d233f0


Bumping golangci-lint, making related fixes

What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
This fixes golangci-lint and the related presubmit.
Does this PR introduce a user-facing change?:
NONE

/lgtm


Implementation of Delete Button in Frontend (REACT)

Consume API From
Delete Motorcyle (Backend) #4

This task is assigned to Victor


Restore/Create Wallet: Add new confirmation boxes

When restoring or creating wallet, we should be show user a bottom sheet dialog with 5 confirmation boxes.
Use keys from #742

https://zpl.io/V4OmJlp

@rafaelekol also add dark mode style


Enable libvirt GetDomainStats on paused VMs

What this PR does / why we need it:
Metrics for paused VMs are not being exported. In this PR, we add a libvirt flag to also get domain stats for paused VMs
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2172544
Special notes for your reviewer:
Release note:

Enable libvirt GetDomainStats on paused VMs

@machadovilaca I think a functest is worth this case, WDYT?

/retest

Thank you @machadovilaca
/lgtm


Python3 support

We're much of the way to full Python3 support but aren't completely compatible (see failing integration tests). Figure out why and fix

Resolved with #265, #271, #272, and #274


start and stop spinner automatically when page is loading

Is it possible to active spinner when page is loading and after loading finished , spinner change to stop without using start stop function for each action in controller?

Hi @mohammad6006 ,
Thanks for opening the issue
Which page loading you mean? $http resources loading or router loading?
For router loading (when navigating between views) you can use $routeStart/Sucess events depends on the route you're using (ng-router/ui-router) - And this difference of routers give the responsibility on the developer to extend this
For $http request, trust me you don't want to link them (or most of them) with this, because good systems do a background job (in case you link this into $httpInterceptors you'll have so many flushing spinners for every background request!)
Feel free to reopen the issue if I misunderstood


fix(es/minifier): Abort sequential inliner on unresolved reference

Description:
Related issue:

Closes #7749

@Austaras Can you take a look? Do you have any idea for improvement?

The problem is very difficult to find a proper solution. Current solution is wrong consider following code
let depth = 0;

export function visit() {
    console.log(depth)
}

function foo(n) {
  depth += 1;
  let k = visit(n);
  depth -= 1;
  return k;
}

blackbox(foo)

let depth = 0;

export function visit() {
    console.log(!depth) // not expected

    // console.log(depth) expected
}

function foo(n) {
  depth += 1;
  let k = visit(n);
  depth -= 1;
  return k;
}

blackbox(foo)

Unary expr access not expected, don't know if there are more edge cases

let depth = 0;

export function visit() {
    console.log(!depth) // not expected

    // console.log(depth) expected
}

function foo(n) {
  depth += 1;
  let k = visit(n);
  depth -= 1;
  return k;
}

blackbox(foo)

Unary expr access not expected, don't know if there are more edge cases

What unexpected?

What unexpected?

Acess depth directly (console.log), the output code is expected.
Acess bang depth, the output code is unexpected

What unexpected?

Acess depth directly (console.log), the output code is expected.
Acess bang depth, the output code is unexpected

Can you provide detailed error log? It seems to work fine in playground, other than issue #7749

Playground
Origin issue: visit cannot be analyzed as it is from global, so dont know if it has effects.
The "unexpected" I meant here:
console.log(depth), the depth is used in visit, so the output remains the right order.
console.log(!depth), the depth is used in visit, however the output is wrong.

It's the same issue, but that case may also lead to more optimization as well.


Port to CMake

Currently the list of files to be installed is hardcoded in both the rockspec and the rpm spec. This should not happen. Instead, the package should be installed with 'make install'.
Please port the build script from Makefile to CMake, and implement packing for debian (now absent)

Blocks like this one:
https://github.com/tarantool/metrics/blob/760caa4bd803450f39c14f8c54f45c1c27cedd9a/rpm/tarantool-metrics.spec#L27-L32
Can be replaced with just:
%files
    %{luapkgdir}/metrics

(Yep, without %{dir}.)
A rockspec can use 'make' build type (and don't list lua files), so if you don't need cmake for various cross-platform stuff, you're free to avoid it.

@vasiliy-t Is there a way to at least protect some issues from this bot? I still think that it is meaningless for managing 20-30 issues (see here), but excluding some issues will at least solve the problem for tasks that I'm interesting in.

Port to cmake is done


Database isn't dropped in distributed mode

CREATE DATABASE remote:<IP_ADDRESS>/testdatabase root root plocal graph
DROP DATABASE remote:<IP_ADDRESS>/testdatabase root root
CREATE DATABASE remote:<IP_ADDRESS>/testdatabase root root plocal graph

Creating database [remote:<IP_ADDRESS>/testdatabase] using the storage type [plocal]...
Database created successfully.
Current database is: remote:<IP_ADDRESS>/testdatabase

Disconnecting from remote server [remote:<IP_ADDRESS>/testdatabase]...
Database 'remote:<IP_ADDRESS>/testdatabase' deleted successfully

Creating database [remote:<IP_ADDRESS>/testdatabase] using the storage type [plocal]...Cannot create the remote storage: testdatabase
com.orientechnologies.orient.core.exception.ODatabaseException: Cannot create database 'testdatabase'
    at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.create(ODatabaseDocumentTx.java:439)
    at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.create(ODatabaseDocumentTx.java:352)
    at com.orientechnologies.orient.core.db.ODatabaseFactory$1.create(ODatabaseFactory.java:108)
    at com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.createDatabase(OBinaryNetworkProtocolAbstract.java:273)
    at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.createDatabase(ONetworkProtocolBinary.java:980)
    at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.executeRequest(ONetworkProtocolBinary.java:290)
    at com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.execute(OBinaryNetworkProtocolAbstract.java:220)
    at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:69)
Caused by: com.orientechnologies.orient.core.exception.ODatabaseException: Cannot open database
    at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.open(ODatabaseDocumentTx.java:276)
    at com.orientechnologies.orient.server.OServer.openDatabase(OServer.java:674)
    at com.orientechnologies.orient.server.hazelcast.OHazelcastPlugin.installDbClustersLocalStrategy(OHazelcastPlugin.java:1093)
    at com.orientechnologies.orient.server.hazelcast.OHazelcastPlugin.onOpen(OHazelcastPlugin.java:418)
    at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.callOnOpenListeners(ODatabaseDocumentTx.java:336)
    at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.open(ODatabaseDocumentTx.java:270)
    at com.orientechnologies.orient.server.OServer.openDatabase(OServer.java:647)
    at com.orientechnologies.orient.server.OServer.openDatabase(OServer.java:613)
    at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.initDatabaseInstance(ODistributedWorker.java:161)
    at com.orientechnologies.orient.server.hazelcast.OHazelcastDistributedDatabase.unqueuePendingMessages(OHazelcastDistributedDatabase.java:264)
    at com.orientechnologies.orient.server.hazelcast.OHazelcastDistributedDatabase.configureDatabase(OHazelcastDistributedDatabase.java:209)
    at com.orientechnologies.orient.server.hazelcast.OHazelcastPlugin.onCreate(OHazelcastPlugin.java:382)
    at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.create(ODatabaseDocumentTx.java:429)
    ... 7 more
Caused by: java.lang.IllegalStateException: Database testdatabase is already open
    at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.open(ODatabaseDocumentTx.java:237)
    ... 19 more

Error: com.orientechnologies.orient.core.exception.OStorageException: Cannot create the remote storage: testdatabase

Error: com.orientechnologies.orient.core.exception.ODatabaseException: Cannot create database 'testdatabase'

Error: com.orientechnologies.orient.core.exception.ODatabaseException: Cannot open database

Error: java.lang.IllegalStateException: Database testdatabase is already open

NOTE: The same problem occurs when using the console or the studio.

OrientDB version: 2.0.4

Tested with 2.0.5 and works. Remember to drop the database from the server you want to be dropped.

MacBook-Pro:draper luca$ ./orientdb-1/bin/console.sh "DROP DATABASE remote:localhost/test root password"

OrientDB console v.2.0.6-SNAPSHOT (build UNKNOWN@r; 2015-03-16 21:13:00+0000) www.orientechnologies.com
Type 'help' to display all the supported commands.
Installing extensions for GREMLIN language v.2.6.0

orientdb> DROP DATABASE remote:localhost/test root password

2015-03-16 22:52:37:697 INFO  Dropped database 'test' [ONetworkProtocolBinary]
2015-03-16 22:52:37:765 WARNING [node1] Shutdown asynchronous queue worker completed [ODistributedStorage$2]
Disconnecting from remote server [remote:localhost/test]...
OK

Database 'remote:localhost/test' deleted successfully

Just tested this with 2.0.5. The database supposedly drops without any errors on the server side, but when you try to create a database with the same name then there are errors:
Setup two nodes <IP_ADDRESS> and <IP_ADDRESS>
CREATE DATABASE remote:<IP_ADDRESS>/testdatabase root root plocal graph
# Creating database [remote:<IP_ADDRESS>/testdatabase] using the storage type [plocal]...
# Database created successfully.
# Current database is: remote:<IP_ADDRESS>/testdatabase

Wait for database to sync to secondary node (<IP_ADDRESS>)...
DROP DATABASE remote:<IP_ADDRESS>/testdatabase root root
# Disconnecting from remote server [remote:<IP_ADDRESS>/testdatabase]...
# Database 'remote:<IP_ADDRESS>/testdatabase' deleted successfully
DROP DATABASE remote:<IP_ADDRESS>/testdatabase root root
# Disconnecting from remote server [remote:<IP_ADDRESS>/testdatabase]...
# Database 'remote:<IP_ADDRESS>/testdatabase' deleted successfully

Then try to create a database with the same name on either of the nodes...
CREATE DATABASE remote:<IP_ADDRESS>/testdatabase root root plocal graph

Results in the following error on server 1:
2015-03-17 00:10:19:110 SEVERE Internal server error:
java.lang.IllegalStateException: Database onlineplatforms is already open [ONetworkProtocolHttpDb][core-4]<-[core-3] error on executing distributed request 35: deploy_db
com.orientechnologies.orient.core.exception.ODatabaseException: Database 'plocal:/opt/orient/databases/onlineplatforms' is closed
   at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.checkOpeness(ODatabaseDocumentTx.java:2590)
   at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.rollback(ODatabaseDocumentTx.java:2425)
   at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.rollback(ODatabaseDocumentTx.java:2420)
   at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.onMessage(ODistributedWorker.java:304)
   at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.run(ODistributedWorker.java:121)

And the following error on server 2:
2015-03-17 00:09:44:313 WARNING [core-1] Shutdown asynchronous queue worker completed [ODistributedStorage$2][core-1]<-[core-3] error on executing distributed request 35: deploy_db
com.orientechnologies.orient.core.exception.ODatabaseException: Database 'plocal:/opt/orient/databases/onlineplatforms' is closed
   at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.checkOpeness(ODatabaseDocumentTx.java:2590)
   at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.rollback(ODatabaseDocumentTx.java:2425)
   at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.rollback(ODatabaseDocumentTx.java:2420)
   at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.onMessage(ODistributedWorker.java:304)

I was mainly using this for doing tests on the database, so not really intended to be used in production, but thought it might be a bug anyway.

OrientDB version 2.0.5

You should drop the database from each servers, otherwise will still be there. That's why on other servers give errors.

Yeh I dropped the database on all of the connected servers, before trying to create the database again. The last comment was using just 2 connected servers, but it's the same with 3,4,5 servers in distributed mode.
Successful DROP DATABASE on both nodes:
DROP DATABASE remote:<IP_ADDRESS>/testdatabase root root
# Disconnecting from remote server [remote:<IP_ADDRESS>/testdatabase]...
# Database 'remote:<IP_ADDRESS>/testdatabase' deleted successfully
DROP DATABASE remote:<IP_ADDRESS>/testdatabase root root
# Disconnecting from remote server [remote:<IP_ADDRESS>/testdatabase]...
# Database 'remote:<IP_ADDRESS>/testdatabase' deleted successfully

but this won't work on either server afterwards...
CREATE DATABASE remote:<IP_ADDRESS>/testdatabase root root plocal graph

Hi @lvca
I have exactly the same error on my distributed OrientDB instances with 2 nodes.
The database mydb was created on the "slave" instance.
After a drop database via OrientDB studio, on the slave then on the master, impossible to create a new database with the same name. I reproduce the same error by dropping the database from console.sh.
I was obliged to erase physically the database with a sudo rm -rf /opt/orientdb/databases/mydb on both instances to be able to create a new mydb.
OrientDB version: 2.0.6

Yep this is still happening on 2.0.5, 2.0.6, 2.0.7.
#3947 is probably the same issue

drop and recreate of database distributed is not supported. Try sync database FULL_REPLACE command

Been trying to reset (drop and create a new database) a distributed database too.
the sync command is not available from orientdb console (2.1.3)
I'm using it through the java api but haven't figured out how to use to reset a database.
Anyone got this working?
Thanks

@lvca how should we use the sync database FULL_REPLACE command? Can this be done from the console? And if not, how do we go about dropping / resetting / replacing a distributed database from the console?


Added fix for colors in Directory

Added fix for hard to see colors in Directory

Thanks for your PR! The code should actually go inside dark.styl. dark.css is generated from that. I went ahead and used your code as a guide to fix the directory text. I also fixed the hover background color.


Chapter03 Logging issue

I seem to be having trouble getting the unhappy path to log an error for the simplequestion exercise in Chapter03.
In an effort to help it timeout & see similar logging to the unhappy path shared in the book
[Worker $] - worker-text-a: DONE!
[Manager$] - text-a read by worker-text-a
[Worker $] - worker-text-b: DONE!
[Manager$] - text-b read by worker-text-b
[Manager$] - parsing text-c' has failed with [Ask timed out on
[Actor[akka://example-ask-without-content/user/manager-1/
worker-text-c#-1664156553]] after [3000 ms]. Message of type
[ask.simple.Worker$Parse]. A typical reason for
`AskTimeoutException` is that the recipient actor
didn't send a reply.
[Worker $] - worker-text-c: DONE!
[DeadLetterActorRef] - Message [ask.simple.Worker$Done$]
to Actor[akka://example-ask-without-content/deadLetters]
was not delivered. [1] dead letters encountered. If this is
not an expected behavior then
Actor[akka://example-ask-without-content/deadLetters] may have
terminated unexpectedly. This logging can be turned off or
adjusted with configuration settings 'akka.log-dead-letters'
and 'akka.log-dead-letters-during-shutdown'.

I reduced the Timeout within the Manager.setup & added some logging. I also reduced the random range for the Random.between & printed out from within fakeLengthyParse to try better understand why it is not working. I tried to create a branch to share but don't have access, here is the patch
diff --git a/chapter03/src/main/scala/simplequestion/Manager.scala b/chapter03/src/main/scala/simplequestion/Manager.scala
index 97ecb35..8659ed3 100644
--- a/chapter03/src/main/scala/simplequestion/Manager.scala
+++ b/chapter03/src/main/scala/simplequestion/Manager.scala
@@ -17,7 +17,9 @@ object Manager {

   def apply(): Behavior[Command] =
     Behaviors.setup { context =>
-      implicit val timeout: Timeout = Timeout(3, SECONDS)
+      implicit val timeout: Timeout = Timeout(1, SECONDS)
+      context.log.info(
+        s"Logging info from Manager with timeout: $timeout")

       Behaviors.receiveMessage { message =>
         message match {
diff --git a/chapter03/src/main/scala/simplequestion/Worker.scala b/chapter03/src/main/scala/simplequestion/Worker.scala
index 87e967e..3c3c056 100644
--- a/chapter03/src/main/scala/simplequestion/Worker.scala
+++ b/chapter03/src/main/scala/simplequestion/Worker.scala
@@ -27,8 +27,10 @@ object Worker {
     }

   private def fakeLengthyParsing(text: String): Unit = {
-    val endTime =
-      System.currentTimeMillis + Random.between(2000, 4000)
+    val random = Random.between(1000, 1500) // will always exceed 1 SECOND timeout
+    val endTime = System.currentTimeMillis + random
+    println(
+      s"Logging the random value ($random) & the associated text ($text)")
     while (endTime > System.currentTimeMillis) {}
   }
 }

Here is some sample logs after my changes
[info] running simplequestion.SimpleQuestionApp
press ENTER to terminate
2023-10-17 10:19:35,450 INFO  [Manager$] - Logging info from Manager with timeout: Timeout(1 second)
Logging the random value (1488) & the associated text (text-a)
Logging the random value (1265) & the associated text (text-b)
Logging the random value (1234) & the associated text (text-c)
2023-10-17 10:19:35,452 INFO  [CoordinatedShutdown] - Running CoordinatedShutdown with reason [ActorSystemTerminateReason]
[success] Total time: 2 s, completed 17 Oct 2023, 10:19:35
[IJ]2023-10-17 10:19:36,686 INFO  [Worker$] - worker-text-c: done
2023-10-17 10:19:36,717 INFO  [Worker$] - worker-text-b: done
2023-10-17 10:19:36,939 INFO  [Worker$] - worker-text-a: done

I have tried a few attempts but still cannot get it to log an error & kill the proxy intermediate actor between the Worker & the Manager - so thought this would be the best way to reach you. Apologies if not, I am new to this.

I did make an effort to check on the live book discussion but couldn't see anything relating to the code snippets just the text that seemed to have been acknowledged.


Link https://github.com/rroller/dahua/archive/dahua-main.zip doesn't work?

I wanted to test the current version first but the Link doesn't work?
Dahua integration: 0.9.26
HA: core-2021.12.7
Dahua SD49225T-HN, Dahua SD1A203T-GN-W, Amcrest AD110
Logger: homeassistant.helpers.entity
Source: helpers/entity.py:549
First occurred: 16:54:05 (43 occurrences)
Last logged: 16:54:06
Entity camera.ad110_door_main (<class 'custom_components.dahua.camera.DahuaCamera'>) implements device_state_attributes. Please report it to the custom component author.
Entity switch.dahuahof_motion_detection (<class 'custom_components.dahua.switch.DahuaMotionDetectionBinarySwitch'>) implements device_state_attributes. Please report it to the custom component author.
Entity switch.dahuaeinfahrt_motion_detection (<class 'custom_components.dahua.switch.DahuaMotionDetectionBinarySwitch'>) implements device_state_attributes. Please report it to the custom component author.
Entity switch.ad110_door_motion_detection (<class 'custom_components.dahua.switch.DahuaMotionDetectionBinarySwitch'>) implements device_state_attributes. Please report it to the custom component author.
Entity switch.dahuaschuppen_motion_detection (<class 'custom_components.dahua.switch.DahuaMotionDetectionBinarySwitch'>) implements device_state_attributes. Please report it to the custom component author.

`

This was fixed in https://github.com/rroller/dahua/commit/1287a0891bf4e12e31c9648e0c1f289446613c76
Seems you are pulling an old version?
Try this version https://github.com/rroller/dahua/releases/tag/0.9.30

FYI, the link in the main README still points to this value for the manual install, so following those instructions does not work.


Add support for JSON Schema draft v4

From http://json-schema.org/documentation.html

The latest IETF published draft is v3. However, a newer version of the specification is being prepared for submission in early 2013.

It would be great to get support for v4 as there seems to be quite a lot of changes.
Thanks!

Hi,
Is there any plan for this one? I am also stuck with the "required" key...
Here is a simple unit test if it can save some time :)
https://github.com/sebfz1/jackson-issues/tree/master/issue-09
Thanks & best regards,
Sebastien

@sebfz1 I think this is something that needs discussion on user and/or dev lists. Alas, I don't recall much feedback on v3 versus v4 compatibility...

Hi Tatu,
Here is a list of changes between v3 and v4:
https://github.com/json-schema/json-schema/wiki/ChangeLog
Would you like me to open a thread in user@ ?
Thanks & best regards,
Sebastien

@sebfz1 I think that would make sense. I would like to see progress here (given how this is highly requested), but I don't use JSON Schema for anything myself, so my role is more advisory. I can of course make minor fixes that are pointed out, help with complications, but am not the driver.

Heh. Looks like a wholesale rewrite.
I wonder if what is needed might actually be a separate JSON Schema v4 module, keeping this module v3. Or possibly vice versa.

Hi Tatu,
Thank you very much for digging into this...
IHMO, I would better keep dual implementations (draft-3 & draft-4) into the same module. Because the question will raise again on draft-5/v1...
This way you can have common (eventually abstract) classes and the best... auto-detect the version given the $schema property, ie:
"$schema": "http://json-schema.org/draft-03/schema#"
or
"$schema": "http://json-schema.org/draft-04/schema#"
My 2 cents :)
Best regards,
Sebastien

It's easier said than done. I may be wrong, but it doesnt seem like JSON Schema authors cared deeply about compatibility between versions, and as such intermingling code for producing both can produce pretty nasty result.
Regardless, whoever works on this (if anyone) gets to decide. If it can be done without split, all the better.
As to v5, at some point specification needs to become stable enough that changes really are minor, and single codebase can support variants. Or ideally so that new one is a strict superset.

It's easier said than done.

I definitely can understand this!
Btw the way, if Jackson is already about Json, maybe the new artifact name could simply be jackson-schema or jackson-module-schema or eventually jackson-json-schema (as there already is a jackson-json-schema-plugin). That's not the most important here, but still...
Maybe if you create the project with the prerequisite (ie: dependencies), it could motivate someone to begin implementing it... If I have some spare time (we never know) I can have a look to see if I have a brilliant idea...

Hey, I'm currently working with some code that is tied up with jackson but needs schema v4. If we make some decisions on how to support v4 I can start contributing code to that end. Does anyone have ideas about this?

@kag0 I think that the easiest thing would be to fork the code to a new project, and once it works well enough, we can figure out whether it should live as a separate project, or whether this project should be changed to multi-Maven-module set up.
Either way, I think that the artifact id should be different so that existing module keeps its name, but the new module uses new name. This way backwards compatibility remains 100%.
There are other ways we could use, for example try to use Maven qualifiers. But I haven't really had good experience in trying to make things work that way.
I can help with git/maven project conversion; I think that should be done for Jackson 2.7.
But the new external project could be released for 2.6, if things go quickly -- all that is needed is to produce jars.
As to name to use... while including version numbers in names is not a good practice in most cases, here we could just go with
json-module-json-schema-v4

This would also alllow getting rid of camel-case "jsonSchema" which IMO should not have been used (I didn't specify it, but didn't catch early enough).
@sebfz1 I actually prefer keeping "json" in the name just because there are other relevant dataformat schemas for other formats: Avro and protobuf have their own schema languages (which are conceptually different from JSON schema, but... well, use term "schema"); and XML schema might be supported in some form as well. module is bit redundant, but I'd want to keep that just because it helps in grouping various Jackson extensions. But if a better qualifier is thought of, I would be open to using that instead (currently we have "dataformat", "datatype" with reasonable definitions, and "module" for "anything else").
But we could maybe consider jackson-schema-json? The main question there being just that it would be a category with just one instance, for now. And all other schema support is related to actual dataformat module now, and for foreseeable future.
On the other hand, this module currently only handles generation of JSON Schema. But I guess that's ok.

I'd be curious to know the status of the JSON Schema v4 support, @cowtowncoder.
At my company, we were looking at the RAML API definition format, which mandates JSON Schema v4, and we would like to be able to use Jackson.
Has there been any progress on this issue?
Thanks.

@glaforge :+1: I'd like to keep using Jackson (are there alternatives?)  but we too have strict v4-draft requirements.

I didn't have time to work on this, just wrote a hack to translate v3 to v4. So don't count on any code coming from this direction any time soon :disappointed:

Unfortunately - and even if I'm still interested - I also didn't found any single minutes to work on this... :-/

Consider also that v4 is three years old and v5 is coming soon (see json-schema/json-schema/issues/167).

@cowtowncoder any news on support for v4 ? I'm stuck with the "required" key issue

@mcadi I am not aware of anyone actively working on that unfortunately. May make sense to try to revive this on jackson-dev mailing list.

I was thinking about this the other day. Looking at the changelogs for the JSON Schema core and validation schemas, the differences between v3 and v4 seem to be in representation rather than in actual semantics, so I wonder whether this issue could be resolved by providing v3 and v4 Serializer and Deserializer implementations? As far as I can see, the Jackson model needn't change, just be augmented by a few new properties here and there.
WDYT?

@mrpotes In general I do like the idea of pluggable backends over hard fork, but in this particular case I think a bigger rewrite would actually be beneficial. This because there are some areas where current handling appears to be wrong and change would be backwards incompatible.
In addition I think that once v4 support works, there will be less and less need to maintain v3.
With that I think a follow-up question is whether to create a separate repo, or change this repo to be multi-module (maven). Latter seems better to me, from release perspective.

I'm currently writing a new jsonSchema-generator using Jackson (https://github.com/mbknor/mbknor-jackson-jsonSchema). It writes v4 schemas and supports Polymorphism used like this:
@JsonTypeInfo(
        use = JsonTypeInfo.Id.NAME,
        include = JsonTypeInfo.As.PROPERTY,
        property = "type")
@JsonSubTypes({
        @JsonSubTypes.Type(value = Child1.class, name = "child1"),
        @JsonSubTypes.Type(value = Child2.class, name = "child2") })
public abstract class Parent {

    public String parentString;
}

It is not done yet, but works for us. Maybe someone would check it out and contribute.

And what about draft 6 ?

What the progress?

@Hronom @denis111
https://github.com/mbknor/mbknor-jackson-jsonSchema Is working quite nice for Draft 4.
It is used in production many places.
Feel free to send PR with support for 6 and 7 (if they exists?? :) )- I'm not using it myself in any current projects at the time, so I'm not going to implement it.

@mbknor I'm start using your project, but I was interested how the progress with official support of this standard in jackson. JSON schema needed for many cases.

@mbknor
Well, currently I'm also not using it :) But v7 exists https://json-schema.org/ ;)

@denis111 :)
Any comments, @cowtowncoder ?

I would be happy to End-of-Life this module, if and when it supports functionality needed by users, as I trust @mbknor 's implementation to already be superior to this module.
EOL would probably occur between 2.x and 3.0, meaning that this module can remain for pre-v4 (as I recall, there was no practical way to have v3-and-v4 support with one codebase).
Having said that, it might be time to see if Jackson 3.0 could expose better introspection functionality, fix some of oddities and limitations there. 2.x mechanism is... not very good. But it is the main mechanism for a few other modules too, like dataformats' schema generation (CSV, protobuf, Avro, Properties at least).

@cowtowncoder maybe you provide rights to the @mbknor to be a so-maintainer on this module?
So this module will be in official family.


Feature maintenance page

Closing - has been replaced by https://github.com/Civil-Service-Human-Resources/identity-service/pull/113


Unable to build pyWPS

Description
I am unable to build pyWPS inside a Docker.  The error is:
The 'jsonschema' distribution was not found and is required by pywps

Environment

operating system: Ubuntu 16.04
Python version: 2.7
PyWPS version: 4.0
source/distribution
[x] git clone
[ ] Debian
[ ] PyPI
[ ] zip/tar.gz
[ ] other (please specify):
web server
[ ] Apache/mod_wsgi
[ ] CGI
[x] other (please specify):  nginx

Steps to Reproduce

Ran the following steps inside the Docker:

RUN apt-get -y update && apt-get -y upgrade && apt-get install -y \
    nginx-full \
    gunicorn \
    build-essential \
    libgdal-dev \
    gdal-bin \
    python \
    python-dev \
    python-setuptools \
    python-magic \
    python-lxml \
    python-gdal \
    python-flufl.enum

RUN git clone https://github.com/geopython/PyWPS.git; \
    cd ./PyWPS; \
    python setup.py install

Error trace:
Searching for jsonschema
Reading https://pypi.python.org/simple/jsonschema/
Best match: jsonschema 3.0.0a3
Downloading https://files.pythonhosted.org/packages/47/e1/afd760aa29665e61142811ef6ea8b8f79e43574ac8427473a11f6e918a10/jsonschema-3.0.0a3.tar.gz#sha256=dfd8426040892c8d0ef6da574085f282569f189cb24b70091a66c21c12d6705e
Processing jsonschema-3.0.0a3.tar.gz
Writing /tmp/easy_install-iSgbeL/jsonschema-3.0.0a3/setup.cfg
Running jsonschema-3.0.0a3/setup.py -q bdist_egg --dist-dir /tmp/easy_install-iSgbeL/jsonschema-3.0.0a3/egg-dist-tmp-q6_h16
/usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'use_scm_version'
  warnings.warn(msg)
warning: install_lib: 'build/lib.linux-x86_64-2.7' does not exist -- no Python modules to install

zip_safe flag not set; analyzing archive contents...
Moving UNKNOWN-0.0.0-py2.7.egg to /usr/local/lib/python2.7/dist-packages
Adding UNKNOWN 0.0.0 to easy-install.pth file

Installed /usr/local/lib/python2.7/dist-packages/UNKNOWN-0.0.0-py2.7.egg
error: The 'jsonschema' distribution was not found and is required by pywps

Additional Information

It may be the issue that PyWPS has chosen to use the 3.0 alpha release of jsonschema rather the current stable release (2.6.0 at time of writing)?

@gamesbook I usually use a conda environment for pywps and I didn't have troubles with conda.
I tried your example in a docker container and run into the same issue. I can't say what has gone wrong. But I installed jsonschema manually, and it worked after that:
$ easy_install pip
$ pip install jsonschema==3.0.0a3
$ python setup.py install

@cehbrecht Thanks, I ended up doing the same myself. I used
pip install jsonschema==2.6.0

And it worked.  Ideally, I should not be building my project with a dependency on this git repo (which could be unstable), but from a stable release.  Unfortunately, the last release to PyPi was nearly 2 years ago ...


7227 : Prohibit Non Final Static Field

Fixes #7227
Prohibit Non-Final Static Field
Add annotation if required static fields  @SuppressWarnings("SSBasedInspection")

This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths.
[ ] added integration tests.
[x] been tested in a test Druid cluster.

Key changed/added classes in this PR

MyFoo
OurBar
TheirBaz

Please update the PR description (e.g., first line should be "Fixes #7227.", remove placeholder text, etc.).

@ccaominh Thanks for quick comments changed, please review now

@leventov can you please review this also.

@leventov thanks for the review, made changes based your suggestions.

@leventov made changes

@leventov "Inspections: pull requests (Druid) — TeamCity build failed" is not related to PR.

@leventov fixed

@leventov looks like a code inspection issue, which is not related to this PR. verified the code I don't see any duplicate code.

There are violations in SimpleTestIndex.java

@leventov inspection failure from
SeekableStreamSupervisor.java (4) 175: TaskGroup() Optional<DateTime> used as type for parameter 'minimumMessageTime'

There are 7 related errors:

https://teamcity.jetbrains.com/viewLog.html?buildId=2590045&tab=Inspection&buildTypeId=OpenSourceProjects_Druid_InspectionsPullRequests

@SandishKumarHN can you see these errors yourself here, or there is some sort of access problem that prevents your (a non-admin user) from seeing these problems?


Go fmt has been ran on secretless project dir

There were many outstanding style issues, as go
fmt has not been ran on the entire project until now.
This change was caused by running go fmt ./... from the
top level directory of the project.

@BradleyBoutcher Can you split out into a different commit (or remove) the changes to go.sum?

Done!

it's nice when things move in this direction on a PR! 🍾


Deprecate make-host-app-editable command

The use of the make-host-app-editable command has been discouraged in the docs in favor of the tool owning the .android and .ios directories.  Custom platform code should be written as plugins or in the host app.
It's also not well tested, and has caused compatibility issues like https://github.com/flutter/flutter/issues/51097.
See also:
https://github.com/flutter/flutter/issues/32989
https://github.com/flutter/flutter/issues/52496
https://github.com/flutter/website/pull/3926
https://github.com/flutter/flutter/issues/23956#issuecomment-567254225

@xster Not sure if this needs to be tracked separately from https://github.com/flutter/flutter/issues/32989.

Now that it's been about a quarter since it's out there and we haven't heard of any blocker issues related to this, I'd close https://github.com/flutter/flutter/issues/32989 with this and add some documentations around https://github.com/flutter/flutter/issues/52496 once we remove this.

To be removed in https://github.com/flutter/flutter/issues/59220.


SSLSocketFactory

Hi! I need test my app on my local server without cert, I try find how off SSL trust and find same as
`fun instance() {
var manager: X509TrustManager = object: X509TrustManager {
        override fun checkClientTrusted(chain: Array<X509Certificate?>?, authType: String?) {
        }

        override fun checkServerTrusted(p0: Array<out X509Certificate>?, p1: String?) {
        }

        override fun getAcceptedIssuers(): Array<X509Certificate> {
            return arrayOf()
        }
    }
    val trustAllCerts: Array<TrustManager> = arrayOf<TrustManager>(manager)
    val sslContext = SSLContext.getInstance("SSL")
    sslContext.init(null, trustAllCerts, null)
    val sslSocketFactory = sslContext.socketFactory
    val builder = OkHttpClient.Builder()
    builder.connectionSpecs(listOf(ConnectionSpec.COMPATIBLE_TLS))
    builder.socketFactory(sslSocketFactory)
    builder.hostnameVerifier(HostnameVerifier { s, sslSession -> true })
    _client = builder
        .addInterceptor(AuthorizationInterceptor())
        .build()`

but when i started app i see exception
Caused by: java.lang.IllegalArgumentException: socketFactory instanceof SSLSocketFactory
at okhttp3.OkHttpClient$Builder.socketFactory(OkHttpClient.kt:723)
at com.admin.panel.newvr.common.api.NetworkService.instance(NetworkService.kt:75)

There is sslSocketFactory, call that instead of socketFactory


Suggested changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: kripajoym:x: vishalhcl-5960You have signed the CLA already but the status is still pending? Let us recheck it.


[Feature] add a configuration to control shuffle data flush

What changes were proposed in this pull request?
Add a configuration to control which kind of shuffle buffers should be flushsed
Why are the changes needed?
To reduce potential small I/Os to local persistent storages. This should close #419
Does this PR introduce any user-facing change?
End user: No
Shuffle Server: a new configuration
How was this patch tested?
add UT

Codecov Report

Merging #445 (f62494d) into master (9635d7a) will decrease coverage by 0.69%.
The diff coverage is 92.00%.

@@             Coverage Diff              @@
##             master     #445      +/-   ##
============================================
- Coverage     58.69%   58.00%   -0.70%
+ Complexity     1635     1427     -208
============================================
  Files           198      177      -21
  Lines         11132     9346    -1786
  Branches        986      831     -155
============================================
- Hits           6534     5421    -1113
+ Misses         4211     3577     -634
+ Partials        387      348      -39

Impacted Files
Coverage Δ

...he/uniffle/server/buffer/ShuffleBufferManager.java
82.82% <86.66%> (+0.07%)
:arrow_up:

...a/org/apache/uniffle/server/ShuffleServerConf.java
99.26% <100.00%> (+0.01%)
:arrow_up:

...rg/apache/uniffle/server/ShuffleDataReadEvent.java
90.00% <0.00%> (-10.00%)
:arrow_down:

...he/uniffle/server/storage/LocalStorageManager.java
88.35% <0.00%> (-2.89%)
:arrow_down:

.../org/apache/uniffle/server/ShuffleTaskManager.java
74.66% <0.00%> (-2.57%)
:arrow_down:

...pache/uniffle/storage/common/LocalStorageMeta.java
74.28% <0.00%> (-1.45%)
:arrow_down:

...pache/uniffle/server/ShuffleServerGrpcService.java
0.80% <0.00%> (-0.01%)
:arrow_down:

...ava/org/apache/spark/shuffle/RssShuffleHandle.java

...e/spark/shuffle/reader/RssShuffleDataIterator.java

...pache/hadoop/mapreduce/task/reduce/RssFetcher.java

... and 23 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM, let @zuston take another look.

Gently ping @zuston

Seems @zuston is busy.. I will wait this PR for tomorrow.

Sorry, I'm suffering from covid-19 and don't have much time to review this.

Gently ping @zuston

Seems @zuston is busy.. I will wait this PR for tomorrow.

Sorry, I'm suffering from covid-19 and don't have much time to review this.

Bless


missing LICENSE file for the project

It looks like the LICENSE file is missed out in the project source code tree.
cc @toddr

The original code was written by Larry Wall so It's going to be same as the Perl license.

Thanks @toddr!


fix: RDS integration test failures

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 44ae32eb92f1299b940b0d96bd563e0abd82885f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: fbeca748105f409125afa5b7112606f6eebe9579
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 44ae32eb92f1299b940b0d96bd563e0abd82885f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: fbeca748105f409125afa5b7112606f6eebe9579
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: fbeca748105f409125afa5b7112606f6eebe9579
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: fbeca748105f409125afa5b7112606f6eebe9579
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

The remaining failures are related to Redshift Spectrum

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: fbeca748105f409125afa5b7112606f6eebe9579
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Receiving an answer from the user for a specific question?

Question
An app for donations presents a user with a choice of donation sizes plus an Option called 'Custom' where he can enter his own value to donate.
How can I ask the question and also receive the Response to that question for processing?
If a user simply enters a value, say the value 12, how can I process this value knowing that this is the answer to a specific question that was asked, in this case how much the user wishes to donate.
So far, I am using inline_keyboards presenting the user with fixed values, but I also wish to give the user the Option to enter his own custom value.
I wish to know how to link to present the user from entering such a custom value and also for the System to catch that Response, knowing it is the answer to that specific question and not just see it as a random message.
Below is the inline_keyboard I'm presenting the user, but I don't know what code to use in the callback_query for the 'Custom' button:
const opts = {
reply_markup: {
inline_keyboard: [
[
{
text: '0.5',
callback_data: JSON.stringify({
'command': 'charity',
'amount': '0.5'
})
},
{
text: '1',
callback_data: JSON.stringify({
'command': 'charity',
'amount': '1'
})
},
{
text: 'Custom',
callback_data: JSON.stringify({
'command': 'charity',
'amount': 'custom'
})
}
]
]
}
};  // opts
telBot.sendMessage(msg.chat.id, 'How much do you wish to give to charity?', opts);
});  // charity

I know how to catch the callback_query in General and to test what value the user has selected from that inline_keyboard, but don't know what to do when the user selects 'Custom'.

See in this issue

Thanks for your quick reply today; I appreciate it.
I have responded to your original post.  Thanks for assisting.


Update http dependency

This updates the http dependency to 1.1, and bumps the crate version.

Thanks for the PR! Would it be enough to require http = "1" instead of 1.1? It doesn't look like this is using an of the additions of the .1 release, and it would give a bit more compatibility if we included 1.0.

Sure, that sounds good

Thanks for your patience; 0.4.0 has been published.


[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M2:enforce

Prerequisites
windows 7 64bit
java 1.8
What version of pinpoint are you using?
master/v1.7.3/
Describe your problem**
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M2:enforce
What have you done?
Steps you have taken to trigger the problem, for example:

run command      ./mvnw install -Dmaven.test.skip=true

Logs
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.315 s
[INFO] Finished at: 2019-06-11T16:31:38+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M2:enforce (enforce-pinpoint-build-requirements) on project pinpoi
nt: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

http://cwiki.apache.org/confluencee/display/MAVEN/MojoExecutionException
I have read the website but don't get the any solution usefully

hi @carlgan
You can get more detail information using the method shown in the error log.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.

And I recommend that you view whole log, not just the last log.
thanks.

http://cwiki.apache.org/confluencee/display/MAVEN/MojoExecutionException
I have read the website but don't get the any solution usefully

I have encountered the same problem. The link you gave has expired, who can help me.

Hi,Do you have resolve this problem?I got this question too

@madalion
You have to explain the environment of Maven in detail so that I can give you help.
If possible, it would be best if you could explain the situation that can be reproduced.
thanks :)

报这个错是这个插件强制做了配置检查
<plugin>                 <groupId>org.apache.maven.plugins</groupId>                 <artifactId>maven-enforcer-plugin</artifactId>                 <version>${plugin.enforcer.version}</version>                 <executions>                     <execution>                         <id>enforce-pinpoint-build-requirements</id>                         <phase>validate</phase>                         <goals>                             <goal>enforce</goal>                         </goals>                         <configuration>                             <rules>                                 <requireMavenVersion>                                     <version>3.5</version>                                 </requireMavenVersion>                                 <requireJavaVersion>                                     <version>1.8</version>                                 </requireJavaVersion>                                 <requireEnvironmentVariable>                                     <variableName>JAVA_HOME</variableName>                                 </requireEnvironmentVariable>                                 <requireEnvironmentVariable>                                     <variableName>JAVA_6_HOME</variableName>                                 </requireEnvironmentVariable>                                 <requireEnvironmentVariable>                                     <variableName>JAVA_7_HOME</variableName>                                 </requireEnvironmentVariable>                                 <requireEnvironmentVariable>                                     <variableName>JAVA_8_HOME</variableName>                                 </requireEnvironmentVariable>                                 <requireEnvironmentVariable>                                     <variableName>JAVA_9_HOME</variableName>                                 </requireEnvironmentVariable>                             </rules>                             <fail>true</fail>                         </configuration>                     </execution>                 </executions>             </plugin>
配置上java各版本的环境变量
export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home
export JAVA_6_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home
export JAVA_7_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home
export JAVA_8_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home
export JAVA_9_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home

yes that's right.  It got rid of the maven error by deleting this plugin in the pom.xml

报这个错是这个插件强制做了配置检查 <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-enforcer-plugin</artifactId> <version>${plugin.enforcer.version}</version> <executions> <execution> <id>enforce-pinpoint-build-requirements</id> <phase>validate</phase> <goals> <goal>enforce</goal> </goals> <configuration> <rules> <requireMavenVersion> <version>3.5</version> </requireMavenVersion> <requireJavaVersion> <version>1.8</version> </requireJavaVersion> <requireEnvironmentVariable> <variableName>JAVA_HOME</variableName> </requireEnvironmentVariable> <requireEnvironmentVariable> <variableName>JAVA_6_HOME</variableName> </requireEnvironmentVariable> <requireEnvironmentVariable> <variableName>JAVA_7_HOME</variableName> </requireEnvironmentVariable> <requireEnvironmentVariable> <variableName>JAVA_8_HOME</variableName> </requireEnvironmentVariable> <requireEnvironmentVariable> <variableName>JAVA_9_HOME</variableName> </requireEnvironmentVariable> </rules> <fail>true</fail> </configuration> </execution> </executions> </plugin>
配置上java各版本的环境变量
export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home export JAVA_6_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home export JAVA_7_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home export JAVA_8_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home export JAVA_9_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home


net/textproto: prevent test from failing with nil pointer dereference

The variable err could have nil value when we call err.Error(),
because after we check it for nil above we continue the test
(t.Errorf doesn't stop the test execution).
Updates #30208

I opened a new pull request that contains changes from this one.
#30226
Current request can be closed (rejected). Doing this as requested here:
https://github.com/golang/go/issues/30208#issuecomment-463359517


implement readU32LE and readU32BE && update use of enum WindowMode in Kore

Hey, those enum fixes are wrong, you fixed my fix, probably used an older Kore version. Can you revert that?


Research: Alternative/Additional config format

At the moment we only use/support KEY=VALUE settings in our config files.
Especially with lists this is extremely limited.
A good alternative could be https://en.wikipedia.org/wiki/TOML

A first testcase for the new config value format can be tested with the tor2ip bridge persitence: #1194
Also bash scripts would need to be able to easily read and import the config data.

I had a look at these two files that we are writing:

/home/admin/raspiblitz.info
/mnt/hdd/raspiblitz.conf

Unfortunately this format is not directly compatible with toml. Here some examples lines:
network=bitcoin
chain=test
autoNatDiscovery=off
runBehindTor=on
touchscreen=1
lcdrotate=1
lndExtraParameter='--accept-keysend'

If I change it so that the all strings are enclosed with single quotes then I can directly parse it with toml and it still valid and the same in bash scripts.
network='bitcoin'
chain='test'
autoNatDiscovery='off'
runBehindTor='on'
touchscreen=1
lcdrotate=1
lndExtraParameter='--accept-keysend'

How to test:
apt-get install python3-toml
python -c "import toml; print(toml.load('/mnt/hdd/raspiblitz.conf'))

Trying to use source in  a shell scripts (on a toml native config file) fails even if only strings and numbers are used a toml by convention uses key = value. But a simple sed enables this (this might fail if there are more complex keys):
source <(sed 's/ = /=/' /tmp/foobar.toml)

This is a toml sample from https://github.com/toml-lang/toml
# This is a TOML document.

title = "TOML Example"

[owner]
name = "Tom Preston-Werner"
dob = 1979-05-27T07:32:00-08:00 # First class dates

[database]
server = "<IP_ADDRESS>"
ports = [ 8001, 8001, 8002 ]
connection_max = 5000
enabled = true

[servers]

  # Indentation (tabs and/or spaces) is allowed but not required
  [servers.alpha]
  ip = "<IP_ADDRESS>"
  dc = "eqdc10"

  [servers.beta]
  ip = "<IP_ADDRESS>"
  dc = "eqdc10"

[clients]
data = [ ["gamma", "delta"], [1, 2] ]

# Line breaks are OK when inside arrays
hosts = [
  "alpha",
  "omega"
]

I think to have it for mnt/hdd/app-data/subscriptions.subscriptions.toml at the moment is fine.
@frennkie this renminds me now that we get more and more py-scripts that also use TOML we need to install this correctly so that also admin & root user can use the scripts without a vertual env ... lets discuss this shortly in video chat if possible

toml lib is now part of raspiblitz global pip - virtual env for standard scripts not needed anymore


messages disappear within 3 seconds

hi, I do not see my messages, it first appear - then disappear abruptly.
thanks

Please provide more information.  What platform is this on?

Please provide more information. What platform is this on?

benawad/vsinder

iPhone, Android, VScode?

iPhone, Android, VScode?

iPhone

iPhone, Android, VScode?

iPhone

when I delete old matches- new messages from users appear

This might be related to #173, how many matches do you have?

This might be related to #173, how many matches do you have?

Yes, probably. I have 149-150 matches

Closing in preference of existing report.  Thank you for your input.


no way to disable sourceMaps

They are slow/broken in dev, they don't serve much purpose but regardless, respecting the build configs sourcemap.enabled should be fixed.

duplicated of: #546


Contributions page user not found message - bad link on page

If you try and search for a user that does not exist, the resulting error message has a link that is bad, the Contribute button links to a url that does not exist. For example
http://www.missingmaps.org/users/#/notarealuser

The "contribute" link in the header also goes to a page that doesn't exist (http://www.missingmaps.org/contribute/).

needs to be /learn/ or /validate/ (nav headers on the user profiles and leaderboard pages are built differently from the rest of the site and weren't updated when the /contribute/ page was changed)

I fixed the 404 link error with #384


Replace existing value in timescale

Hello,
Is there a way to replace an existing value in timescale ?
Use case :
Every 5 minutes, we compute the value of several metrics for the current day and we want to store it by day.
For example : we are the 2021-02-17 at 15h00.
So we sum all the data of metric1, metric2, metric3 from the 2021-02-17 at 00h00 to the 2021-02-17 at 15h00 and send the result to promscale : 2021-02-17T00:00:00.000Z res my_result_metric{}
Then at 15h05 :
we sum all the data of metric1, metric2, metric3 from the 2021-02-17 at 00h00 to the 2021-02-17 at 15h05 and send the result to promscale : 2021-02-17T00:00:00.000Z res my_result_metric{}
But currently promscale doesn't insert the metric if it already exists so we can't do that :/
Regards

That is currently not possible but we will keep this open as a feature request.

closing this issue, as it doesn't align with the roadmap of Promscale, and haven't heard this kind of metric use-cases from a broader audience.


Update internal header snapshots

Fixes

Fixes #2473 by @sarayourfriend
Description

This PR

updates flaky snapshots, actually showing the difference in logo size
removes unused snapshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

The initial diff also showed a small difference in the fonts that I don't know how to debug. It has to be pretty rare because it's the first time I've seen this type of difference.

It has to be pretty rare because it's the first time I've seen this type of difference

IIRC @obulat Had to deal with something around this in the past that had to do with how Ubuntu (the Playwright container's base image) loads fonts.


Replace references to 'NameSpace' with the correct 'Namespace'

Cleanup PR that changes refs to NameSpace with the correct Namespace
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@Monkeyanator: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
17410f310cbe89e120bd9308c48cc12cd8a948c3
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
261fc19d3d9641a500aa756cff9ba688db781134
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
261fc19d3d9641a500aa756cff9ba688db781134
link
/test integ-new-install-k8s-tests_istio

integ-mixer-k8s-tests_istio
261fc19d3d9641a500aa756cff9ba688db781134
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


chore(main): release uniform 0.11.1

:robot: I have created a release beep boop
0.11.1 (2024-11-27)
Bug Fixes

deps: update dnd-kit monorepo (a17f1c6)
pixels: refactore tabs and tab stories (bb444bb)
uniform: position debug button always on bottom right corner (cc5e3b2)
uniform: update @dnd-kit/core to v6.2.0 + update snapshots (c696723)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

uniform-v0.11.1
:sunflower:


Correction for raw affiliation CIRAD, UMR ABSYS, Jakarta, Indonesia;

Correction needed for raw affiliation CIRAD, UMR ABSYS, Jakarta, Indonesia;
raw_affiliation_name: CIRAD, UMR ABSYS, Jakarta, Indonesia;
new_rors: 00zrhqg94;00n2c0309
previous_rors: 00zrhqg94
works_examples: W4312203073
contact: 938db5d9b26d05cbbd3e535bc88a5e7f:b20193d3e5acd97d47ef6c1653faa33d59e1 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_9c60f0ee-2c38-414d-8675-c720949ec78e/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_9c60f0ee-2c38-414d-8675-c720949ec78e.git

Docs Build status updates of commit 80e33d7:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-BuildPermissionInsufficientError] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the account, e2ebd1, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master) and then retry the build.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Missing C# compiler warning CS8634

id: CS8634
title: The type cannot be used as type parameter in the generic type or method. Nullability of type argument doesn't match 'class' constraint.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc586192-534e-0108-d265-c4f2f6947c57
Version Independent ID: 4d39f536-5d78-335b-3525-d4b581c28fdc
Content: C# Compiler Errors
Content Source: docs/csharp/language-reference/compiler-messages/index.md
Product: dotnet-csharp
Technology: csharp-diagnostics
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

@tdykstra Why was this closed "as completed" when there still isn't any documentation page for CS8634?
The documentation lookup link (used by VS) for this code gives me a HTTP 404 error: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS8634)
Screenshot proof:

Fixed in #30045


Improved r2t fit

The "read temperature" function baked into the hardware for the Sequent RTD hat works by reading the resistance of the RTD, then converting that resistance to temperature, using a linear fitting equation of temperature as a function of resistance.
This fit is actually quite reasonable for the middle, most common range of the PT100 detector, roughly for temperatures in the range of [0, 100] degrees centigrade.  However, it does begin to degrade as the temperatures get much outside that range.  Here is a graph showing the raw (temperature, resistance) measured data for PT100 detectors, and the Sequent linear fit:

It's not a bad fit.  It just begins to degrade at the high/low ranges.
To address this issue, a few years ago I had developed some improved polynomial fits, that give very good accuracy across the entire range of temperatures [-200C, 660C], in a project documented in https://github.com/ewjax/max31865.
This pull request adds the 5th order polynomial fits from that effort into the C and Python software source code.  It leaves the current "read temperature" functions intact, so there is no change to the default behavior, but adds an additional function to perform the 5th order polynomial fit of temperature vs resistance.  The polynomial fit could actually be used across the entire range of temperatures if desired, as the fit accuracy is quite good, showing a maximum error of 0.13 degC across the range [-200, 660], but I decided to leave it as an "extra" feature and not as a "replacement" feature.

Hi,
If is easy for you to increase the version to 1.3.0, will be nice ( I was missing that). I will not switch to the polynomial fit yet but I will ask for my collogue from the marketing  to make an update abut this improvement. Thanks again for the effort and for appreciations.
Alex.


function order by support

function order by support
PostgreSQL ordered aggregates
SELECT array_agg(s ORDER BY b) FROM t
https://www.postgresql.org/docs/current/sql-expressions.html#SYNTAX-AGGREGATES

Coverage decreased (-0.03%) to 88.75% when pulling 7f85fab5e33bb9bc7076c33e24111bed49c01b50 on tvar:fun_order into d7b468a651ab966d529edc4f7b2376883a58d854 on JSQLParser:master.

Coverage decreased (-0.03%) to 88.75% when pulling 7f85fab5e33bb9bc7076c33e24111bed49c01b50 on tvar:fun_order into d7b468a651ab966d529edc4f7b2376883a58d854 on JSQLParser:master.

please correct conflicts

fixed


Replaced strong etags with HTTP ETags

Fixes #1730.

Hi @sarthakforwet does this PR intend to close #1730? If so please link them. See https://github.blog/2013-05-14-closing-issues-via-pull-requests/

but this is probably pervasive in all the changes.

I also had the thought of changing the phrase according to surroundings but thought that it was necessary to add complete "HTTP ETag". Corrected now.


Syntax for quantum function tensor product

Maybe * to indicate the product:
q0, q1 = (h*x)(q0, q1)
# equivalent to:
q0 = h(q0)
q1 = x(q1)

Alternatives:

, comma like BRAT, but confusion with tuples
|
@ usually matrix multiplication so confusion with composition rather than product

q1 = h(q1)

you mean x(q1), right?
Are unicode symbols such as ⊗ completely out of scope?

you mean x(q1), right?

yes, edited

@ usually matrix multiplication

It is?

Having a look at this this hack week (19th-23rd)


Confusing error message when local gems have invalid gemspec

First I want to say :+1: for enforcing gemspecs to be valid before bundler will install the gems.
I just upgraded to ruby 2.3.0 and installed the latest version of bundler and when I ran bundle install I received the following message:
$ bundle install
The gemspec at /lib/rails_admin_devise_invitable/rails_admin_devise_invitable.gemspec is not valid. The validation error was '"FIXME" or "TODO" is not an author'
The gemspec at /lib/rails_admin_devise_invitable/rails_admin_devise_invitable.gemspec is not valid. The validation error was '"FIXME" or "TODO" is not an author'
Fetching gem metadata from https://rubygems.org/.......
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
Could not find gem 'rails_admin_devise_invitable' in source at `lib/rails_admin_devise_invitable`.
Source does not contain any versions of 'rails_admin_devise_invitable'

The error message is confusing because I thought it was unable to find the gem once I corrected the errors in the gemspec everything worked as expected.
My suggestion would be that the error message should inform the user to correct the specified gemspec file(s) then run bundle install again.

Thanks for the report, @dbslone. Are you able to share the failing project with us to help reproduce the issue? Is it open source?

@TimMoore Unfortunately the app isn't open source but I should have some time over the weekend to create new rails app that reproduces the error that I can share

@dbslone what would you have expected error message wise ? Something along the lines of:
$ bundle install

Gem::InvalidSpecificationException: The gemspec at /lib/rails_admin_devise_invitable/rails_admin_devise_invitable.gemspec is not valid. Please fix the gemspec.

@RochesterinNYC Yeah I think that error message is clearer and would inform users that once the gemspec is corrected operations should proceed as expected.

Closed by https://github.com/bundler/bundler/pull/4250.


skipper.Data.SetPath not working with multiple path components

This works:
data.SetPath(frontends, "transformed_thomas_tcp_frontends")
While this does not:
data.SetPath(frontends, "transformed", "thomas", "tcp_frontends")

@lukasjarosch fixed that a while back in https://github.com/lukasjarosch/skipper/pull/70


grape-jdk support mac

What do these changes do?
Add GRAPE-jdk support for mac os. Including m1 chipset.

Related issue number
#1763

Fixes

For reviews:

ENABLE_JAVA_SDK turned on by default.
Detect mac Darwin in CMakeLists.
Turn off ld.lld off on mac, since not supported
Install openjdk@11 from brew on mac Darwin.
Fixed hard-coded jni library loading.

Please evaluate the necessity of turning enable_java_sdk=on by default, thanks.

Codecov Report

Merging #1774 (14e3686) into main (9abea6d) will decrease coverage by 11.33%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1774       +/-   ##
===========================================
- Coverage   76.13%   64.79%   -11.34%
===========================================
  Files          89       89
  Lines        9798     9798
===========================================
- Hits         7460     6349     -1111
- Misses       2338     3449     +1111

Impacted Files
Coverage Δ

...aphscope/tests/kubernetes/test_resource_builder.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...on/graphscope/tests/kubernetes/test_demo_script.py
0.00% <0.00%> (-91.75%)
:arrow_down:

python/graphscope/tests/unittest/test_download.py
20.00% <0.00%> (-80.00%)
:arrow_down:

python/graphscope/deploy/kubernetes/utils.py
11.90% <0.00%> (-58.58%)
:arrow_down:

python/graphscope/dataset/ppi.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/cora.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/ogbl_ddi.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/ogbn_mag.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/ogbn_arxiv.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/ogbl_collab.py
31.25% <0.00%> (-56.25%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abea6d...14e3686. Read the comment docs.


work offline

It is hoped that each version can be tested offline for availability.
for example,
In an environment without Internet,
kotlin-dsl Searched in Gradle Central Plugin Repositiories in the build.gradle.kts file of buildSrc,
gradle init converts the maven project using https://repo.maven.apache.org and init.d/init.gradle is not effective.

Duplicate of #19884


Support a configurable expiry grace period

Feature Request
Right now, the expiry grace period is hardcoded: https://github.com/twurple/twurple/blob/450b0c71665bac91799a9e19921a3d1d3cea2890/packages/auth/src/AccessToken.ts#L44
It would be nice to be able to configure this. Specifically, I want to set it to a value dynamically calculated every time the expiration is checked.
We have two servers both using twurple/auth and if the expiry grace period is reached, they race each other and one ends up storing an invalid auth token. A simple way to mitigate this is to set the expiry to a fixed value + a random delay, that way it's unlikely the two race each other.

If this was random per request, it wouldn't prevent the race condition, it would just make it rarer.
The proper way to fix this kind of race condition would be a custom AuthProvider implementation that communicates between the servers, for example by storing some or all state (including some kind of lock for mutating operations like refreshes) in a shared storage like Redis.