HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 17s
master passed

+1 :green_heart:
compile
8m 49s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m  5s
root in master failed.

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m  6s
root in the patch failed.

-1 :x:
compile
0m  5s
root in the patch failed.

-0 :warning:
javac
0m  5s
root in the patch failed.

-0 :warning:
whitespace
0m  0s
The patch 2 line(s) with tabs.

-1 :x:
xml
0m  5s
The patch has 1 ill-formed XML file(s).

-1 :x:
hadoopcheck
0m  3s
The patch causes 12 errors with Hadoop v3.1.2.

-1 :x:
hadoopcheck
0m  6s
The patch causes 12 errors with Hadoop v3.2.1.

-1 :x:
hadoopcheck
0m  9s
The patch causes 12 errors with Hadoop v3.3.0.

_ Other Tests _

+0 :ok:
asflicense
0m 21s
ASF License check generated no output?

17m 22s

Reason
Tests

XML
Parsing Error(s):

pom.xml

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3310

Optional Tests
dupname asflicense javac hadoopcheck xml compile

uname
Linux dba965a5ca56 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 19fd42b1dc

Default Java
AdoptOpenJDK-1.8.0_282-b08

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-compile-root.txt

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-compile-root.txt

whitespace
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/whitespace-tabs.txt

xml
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/xml.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-javac-3.3.0.txt

Max. process+thread count
126 (vs. ulimit of 30000)

modules
C: . hbase-common hbase-shaded hbase-shaded/hbase-shaded-client U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 54s
master passed

+1 :green_heart:
compile
2m 33s
master passed

+1 :green_heart:
shadedjars
8m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 57s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m  6s
root in master failed.

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m  6s
root in the patch failed.

-1 :x:
compile
0m  6s
root in the patch failed.

-0 :warning:
javac
0m  6s
root in the patch failed.

-1 :x:
shadedjars
0m  4s
patch has 12 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m  6s
root in the patch failed.

-0 :warning:
javadoc
0m  6s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m  6s
hbase-shaded in the patch failed.

-0 :warning:
javadoc
0m  6s
hbase-shaded-client in the patch failed.

_ Other Tests _

-1 :x:
unit
0m  6s
root in the patch failed.

21m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3310

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fe073420444f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 19fd42b1dc

Default Java
AdoptOpenJDK-1.8.0_282-b08

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt

shadedjars
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-root.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-shaded.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-shaded_hbase-shaded-client.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/testReport/

Max. process+thread count
132 (vs. ulimit of 30000)

modules
C: . hbase-common hbase-shaded hbase-shaded/hbase-shaded-client U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 51s
master passed

+1 :green_heart:
compile
3m 17s
master passed

+1 :green_heart:
shadedjars
8m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 58s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m  5s
root in master failed.

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m  6s
root in the patch failed.

-1 :x:
compile
0m  5s
root in the patch failed.

-0 :warning:
javac
0m  5s
root in the patch failed.

-1 :x:
shadedjars
0m  3s
patch has 12 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m  6s
root in the patch failed.

-0 :warning:
javadoc
0m  5s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m  6s
hbase-shaded in the patch failed.

-0 :warning:
javadoc
0m  5s
hbase-shaded-client in the patch failed.

_ Other Tests _

-1 :x:
unit
0m  5s
root in the patch failed.

25m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3310

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a0bd6513624d 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 19fd42b1dc

Default Java
AdoptOpenJDK-11.0.10+9

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt

shadedjars
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-shaded.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-shaded_hbase-shaded-client.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/testReport/

Max. process+thread count
125 (vs. ulimit of 30000)

modules
C: . hbase-common hbase-shaded hbase-shaded/hbase-shaded-client U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  1s
master passed

+1 :green_heart:
compile
8m 43s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
8m 42s
the patch passed

+1 :green_heart:
javac
8m 41s
the patch passed

-0 :warning:
whitespace
0m  0s
The patch 2 line(s) with tabs.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
23m 25s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

_ Other Tests _

+1 :green_heart:
asflicense
0m 45s
The patch does not generate ASF License warnings.

60m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3310

Optional Tests
dupname asflicense javac hadoopcheck xml compile

uname
Linux 6b23e93b9c79 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 19fd42b1dc

Default Java
AdoptOpenJDK-1.8.0_282-b08

whitespace
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/2/artifact/yetus-general-check/output/whitespace-tabs.txt

Max. process+thread count
126 (vs. ulimit of 30000)

modules
C: hbase-common hbase-shaded hbase-shaded/hbase-shaded-client . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 18s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 40s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  7s
master passed

+1 :green_heart:
compile
3m 50s
master passed

+1 :green_heart:
shadedjars
9m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 50s
the patch passed

+1 :green_heart:
compile
3m 25s
the patch passed

+1 :green_heart:
javac
3m 25s
the patch passed

+1 :green_heart:
shadedjars
9m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
261m 31s
root in the patch passed.

313m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3310

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ef7135fac355 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 19fd42b1dc

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/2/testReport/

Max. process+thread count
4517 (vs. ulimit of 30000)

modules
C: hbase-common hbase-shaded hbase-shaded/hbase-shaded-client . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
master passed

+1 :green_heart:
compile
2m 32s
master passed

+1 :green_heart:
shadedjars
8m  5s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 57s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 40s
the patch passed

+1 :green_heart:
compile
2m 34s
the patch passed

+1 :green_heart:
javac
2m 34s
the patch passed

+1 :green_heart:
shadedjars
8m 20s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 54s
the patch passed

_ Other Tests _

-1 :x:
unit
344m 24s
root in the patch failed.

383m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3310

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux db8deca69390 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 19fd42b1dc

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/2/testReport/

Max. process+thread count
5056 (vs. ulimit of 30000)

modules
C: hbase-common hbase-shaded hbase-shaded/hbase-shaded-client . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 34s
master passed

+1 :green_heart:
compile
2m 39s
master passed

+1 :green_heart:
shadedjars
8m 15s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
2m 44s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 53s
the patch passed

+1 :green_heart:
compile
2m 41s
the patch passed

+1 :green_heart:
javac
2m 41s
the patch passed

+1 :green_heart:
shadedjars
8m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 57s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 16s
root in the patch failed.

42m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3310

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d2afb4bc4adb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 19fd42b1dc

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/3/testReport/

Max. process+thread count
345 (vs. ulimit of 30000)

modules
C: hbase-common hbase-shaded hbase-shaded/hbase-shaded-client . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 52s
master passed

+1 :green_heart:
compile
8m 17s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
2m 44s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 52s
the patch passed

+1 :green_heart:
compile
8m 26s
the patch passed

+1 :green_heart:
javac
8m 26s
the patch passed

-0 :warning:
whitespace
0m  0s
The patch 2 line(s) with tabs.

+1 :green_heart:
xml
0m  6s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
21m  1s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

_ Other Tests _

+1 :green_heart:
asflicense
0m 56s
The patch does not generate ASF License warnings.

59m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3310

Optional Tests
dupname asflicense javac hadoopcheck xml compile

uname
Linux bd4dad11171a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 19fd42b1dc

Default Java
AdoptOpenJDK-1.8.0_282-b08

whitespace
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/3/artifact/yetus-general-check/output/whitespace-tabs.txt

Max. process+thread count
141 (vs. ulimit of 30000)

modules
C: hbase-common hbase-shaded hbase-shaded/hbase-shaded-client . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 39s
master passed

+1 :green_heart:
compile
3m 19s
master passed

+1 :green_heart:
shadedjars
9m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 56s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 47s
the patch passed

+1 :green_heart:
compile
3m 19s
the patch passed

+1 :green_heart:
javac
3m 19s
the patch passed

+1 :green_heart:
shadedjars
9m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
258m  7s
root in the patch passed.

304m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3310

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f87b88d3538a 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 19fd42b1dc

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/3/testReport/

Max. process+thread count
4540 (vs. ulimit of 30000)

modules
C: hbase-common hbase-shaded hbase-shaded/hbase-shaded-client . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


fix displaying JoinedArray break

Description
Changes proposed in this pull request:

fix displaying joinedArray break.

Related issue(s)

/retest


Add Stockton Junior High School

@tbolandconroeisd First stage of verification passed, official domain for Stockton Junior High School is conroeisd.net as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@tbolandconroeisd Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


(PDB-4271) query for fact expiration

Adds an "expires" field to the node response, that contains two embedded
fields: "facts" and "facts_updated"
If "facts" is true (the default), the node is subject to garbage
collection and expiration. If the value is set to false, the node is
excluded from the garbage collection procedure. If this value has been
explicitly set via a command, the facts_updated field will be a
timestamp representing when the field was set.

This is going to need a rebase - it's based on @rbrw's change that adds the table to the database

Test PASSed

CLA signed by all contributors.

Test PASSed

Test FAILed

Test PASSed

Test PASSed


Compilers warnings

Just to notice some compilers warning when using the  -Wall flag with Clang 3.7 :

warning: suggest braces around initialization of subobject [-Wmissing-braces]
CASE("test")
lest.hpp:115:5: note: expanded from macro 'lest_CASE'
proposition, [VA_ARGS]( lest::env & $ )

and with the  -pedantic  flag GCC 5.2 tells :

warning: ISO C++11 requires at least one argument for the "..." in a variadic macro
CASE("test")

with the  -pedantic flag Clang says lots of warnings of the type :

lest.hpp:172:27: warning: '$' in identifier [-Wdollar-in-identifier-extension]
lest::report( $.os, lest::got_none( lest_LOCATION, #expr ), $.testing ); \

We also get some warnings with  Weffc++  flag
Thank you for this work I really enjoy it !

Resolved by pr #19.


[SPARK-12837][CORE] Do not send the name of internal accumulator to executor side

What changes were proposed in this pull request?
When sending accumulator updates back to driver, the network overhead is pretty big as there are a lot of accumulators, e.g. TaskMetrics will send about 20 accumulators everytime, there may be a lot of SQLMetric if the query plan is complicated.
Therefore, it's critical to reduce the size of serialized accumulator. A simple way is to not send the name of internal accumulators to executor side, as it's unnecessary. When executor sends accumulator updates back to driver, we can look up the accumulator name in AccumulatorContext easily. Note that, we still need to send names of normal accumulators, as the user code run at executor side may rely on accumulator names.
In the future, we should reimplement TaskMetrics to not rely on accumulators and use custom serialization.
Tried on the example in https://issues.apache.org/jira/browse/SPARK-12837, the size of serialized accumulator has been cut down by about 40%.
How was this patch tested?
existing tests.

cc @rxin @davies @andrewor14

Test build #75672 has started for PR 17596 at commit 67044b3.

Test build #75672 has finished for PR 17596 at commit 67044b3.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75672/
Test FAILed.

BTW a potential, better way to solve this is to combine all the metrics into a single accumulator.

The approach I took for this was slightly different.

Create a bitmask indicating which accumulators are required in TaskMetrics - that is, have non zero values, and emit this first.
Instead of relying on default serialization, simply do custom serialization for all internal accumulators - directly emit the long's (based on the bitmask for writing/reading).
Encode long/int's so that they take less than 8/4 bytes (currently this is sitting inside graphx iirc - essentially same code as from kryo for optimizePositve)

For 1.6, this brought down the size from 1.6k or so average down to 200+ bytes

@mridulm I actually have the same plan, I think it's an overkill to implement TaskMetrics with accumulators, we don't need to merge the accumulator updates at driver side for TaskMetrics accumulators.
One thing I'm not 100% agree with you is about the bitmask. According to my experiment, most of the task metrics will not be 0, so the bitmask may not be very useful.

My comments were based on a fix in 1.6; actually lot of values were actually observed to be 0 for a lot of cases - just a few were not (even here it is relevant - resultSize, gctime, various bytes spilled, etc). The bitmask actually ends up being a single long for the cardinality of metrics we have - which typically gets encoded in a byte or two in reality.
In addition, things like input/output/shuffle metrics, accumulator updates, block updates, etc (present in 1.6 in TaskMetrics) - can all be avoided in the serialized stream when not present.
When present, I used read/write External on those classes to directly encode the values.
IIRC this is relevant not just for the final result, but for heartbeats also - so serde saving helped a lot more than initially expected.

Test build #75777 has started for PR 17596 at commit ca84b12.

@mridulm ok I agree with you, we should have a bitmask. I updated this PR to only avoid sending accumulator names, which is a very simple change but cut down the size a lot. I'll work on the custom serialization of TaskMetrics later.

Test build #75777 has finished for PR 17596 at commit ca84b12.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75777/
Test FAILed.

Test build #75789 has started for PR 17596 at commit 7609259.

Test build #75790 has started for PR 17596 at commit 36840ee.

Test build #75789 has finished for PR 17596 at commit 7609259.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75789/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75790/
Test FAILed.

Test build #75803 has started for PR 17596 at commit d1f42e1.

Test build #75803 has finished for PR 17596 at commit d1f42e1.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75803/
Test FAILed.

seems this breaks python accumulator.... anyone know how python accumulator works?

Test build #75896 has started for PR 17596 at commit a3e1d78.

Test build #75896 has finished for PR 17596 at commit a3e1d78.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75896/
Test PASSed.

cc @mridulm any more comments on this PR?

Test build #76017 has started for PR 17596 at commit e8633f9.

Test build #76017 has finished for PR 17596 at commit e8633f9.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AccumulatorMetadata(id: Long, countFailedValues: Boolean) extends Serializable

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76017/
Test FAILed.

Merged build finished. Test FAILed.

Test build #76036 has started for PR 17596 at commit 3b0c770.

Test build #76036 has finished for PR 17596 at commit 3b0c770.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AccumulatorMetadata(id: Long, countFailedValues: Boolean) extends Serializable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76036/
Test FAILed.

Test build #76134 has started for PR 17596 at commit 0616716.

Test build #76136 has started for PR 17596 at commit 7f41155.

Test build #76134 has finished for PR 17596 at commit 0616716.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76134/
Test PASSed.

Test build #76136 has finished for PR 17596 at commit 7f41155.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76136/
Test FAILed.

Merged build finished. Test FAILed.

retest this please.

Test build #76157 has started for PR 17596 at commit 7f41155.

Test build #76169 has started for PR 17596 at commit 4df95f2.

Test build #76157 has finished for PR 17596 at commit 7f41155.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76157/
Test FAILed.

Test build #76169 has finished for PR 17596 at commit 4df95f2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76169/
Test FAILed.

Merged build finished. Test FAILed.

Test build #76173 has started for PR 17596 at commit 4fcee4f.

retest this please

Test build #76178 has started for PR 17596 at commit 4fcee4f.

Test build #76173 has finished for PR 17596 at commit 4fcee4f.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76173/
Test FAILed.

Test build #76178 has finished for PR 17596 at commit 4fcee4f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76178/
Test PASSed.

Test build #76209 has started for PR 17596 at commit 0f028b1.

Test build #76209 has finished for PR 17596 at commit 0f028b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76209/
Test PASSed.

Merged build finished. Test PASSed.

LGTM - merging to master/2.2


Pasting after rather than before current character

First of all, thanks a ton for this plugin, I've been using it for a while and on a daily basis -- and it works brilliantly!
However, there is one pet peeve I have, namely that the entries seem to be pasted before rather than after the current letter (so in functionality it's like vim's P rather than p). Can we change this or make it configurable? I almost always use p to paste things and the one other text inserting Telescope function I use (Telescope symbols) also does a p pasting.
I think the behaviour is because you've opted for
vim.api.nvim_put({entry}, "", false, false)
vim.api.nvim_feedkeys("la", "n", true)

rather than
vim.api.nvim_put({entry}, "", true, true)
vim.api.nvim_feedkeys("a", "n", true)

By setting the third parameter to true, p-type pasting is employed. (I've also set the fourth parameter to true, which means the l in the second line isn't needed).
I think p-type pasting is what people generally expect, but if you think otherwise, that's of course fine. I think I should be able to somehow override the default behaviour although I do find telescope configuration a little daunting.

Thanks for pointing this out. I also think that p-type is the way to go. I use the plugin mostly in insert-mode while writing and there I did not notice this. I think I had the 3rd and 4th parameters set differently from what they are now and changed it for some reason (I do not remember why, but I can check).
I plan on working on some issues this weekend and since this is very straight forward, this will be on my radar as well. In the same step I want to put the user back into the mode they called the plugin from, so this goes in a similar direction.

I implemented this in #27. Let me know if you notice any issues :)


Added Examples for Request Header Fields

Signed-off-by: Adithya Krishna<EMAIL_ADDRESS>Description
This PR fixes #2448
Notes for Reviewers
The examples added for Performance Test's Request Header Fields are,

Request Headers: "host":"bookinfo.meshery.io"
Request Cookies: "yummy_cookie=choco_chip"
Content Type:  "application/json"
Response Body: {"method":"post","url":"http://bookinfo.meshery.io/test"}

Signed commits

[x] Yes, I signed my commits.

Hey @utkarsh-pro
Could you please review this ? 👀

I've signed the DCO 👀

Great work @adithyaakrishna! :smile:


Change method siganture to ToTraceID and ToSpanID

This update to the Trace Identifiers RFC addresses issues identified in the last round of exploration. It changes the method signatures from TraceID and SpanID to ToTraceID ToSpanID. A small additional clarification on future formats is also included.
Why ToTraceID instead of TraceID?
The method names ToTraceID and ToSpanID were chosen over TraceID and SpanID for two reasons:

To avoid conflicts with tracer implementations, which often use TraceID and SpanID to expose their identifiers in their native format.
To communicate to the user that a format conversion may be occuring, and thus there may be some cost to calling these methods.

@tedsuo there were also discussions on some PRs about the range of values returned from those methods, like having them to be a hex string, or being URL-safe. I don't think we had a detailed discussion about that.
Arguments for hex string - the premise of this whole RFC was the agreement reached at W3C WG between all vendors that they should be able to express their trace/span IDs as opaque, 16 and 8 byte arrays respectively. This was different from the original design of SpanContext when there was no such agreement and there as a concern that some vendors wouldn't be able to expose the IDs (btw maybe worth adding this explanation to the RFC). So given the W3C agreement as a premise, why not follow its format recommendation as well and be more prescriptive about the outputs of ToTraceID/ToSpanID ?

@yurishkuro I think that is an interesting point. Do existing systems all conform to the new W3C standard for identifiers format?
There are separate design decision around adding direct access to W3C Trace-Context data. It would require at least the following:

Tracers actually adopting these headers and running in Trace-Context mode.
A library implementing Trace-Context which all tracers share, in order to avoid silly conversions and type mismatches.
More thought into versioning. If the Trace-Context spec versions, what happens to the OT interface?

My suggestion would be that we add ToTraceID and ToSpanID as loosely defined as possible. That could still mean setting a maximum expected length and defining a character set. But if we want to expose the Trace-Context data format specifically, it should be a separate RFC, as the requirements for that are very different.
I'm fine with adding this interface now, and a second one later. But if we want to instead drop this RFC in favor of just having a TraceContext accessor, we should move very quickly on making a proposal for that.
In any case, I would suggest keeping this PR tightly scoped to just updating the naming convention, since that's a separate issue which I feel we have resolved. We can make a follow up PRs discussing content restrictions on the returned value, etc.

So my concern was not about adopting W3C proposal, but about setting the expectations on the output values. These expectations may take the form of a recommendation, rather than a requirement. For example, one of the reasons people want trace IDs is to log them. Logs are often formatted in JSON. So if suddenly the output value of ToTraceID is a string with a double-quote in it (for the sake of argument), then it makes JSON more difficult.
If the output format is only recommendation, consumers still need to take appropriate measures to encode the values properly in whatever medium they are serializing them (e.g. URL-encoding, etc.) But at least a recommendation of a hex string makes the encoding no-op in most cases, and even allows straightforward conversion to binary. Once W3C finalizes the proposal (and it doesn't seem likely that hex format will be overturned there), most OT tracers will be already exposing IDs in the compatible format.
Anyway, I am fine with not prescribing any string format at this stage.


Fix table/@frame="none" in PDF2

Signed-off-by: Toshihiko Makita<EMAIL_ADDRESS>Description
Update the @colsep/@rowsep processing that implements the DITA CALS table requirement.
Motivation and Context
This pull request fixes the bug reported in #3303.
How Has This Been Tested?
Using DITA-OT 3.7 release in Windows 11 environment.
The build result for reported example in #3303
[Before this fix]

[After this fix]

I have attached the test result:
pdf2-test-result-2022-01-22.zip
The test data archive:
test-data-2022-01-21.zip
Type of Changes

Bug fix (non-breaking change which fixes an issue)

Documentation and Compatibility
None
Checklist

My code follows the code style of this project.

https://github.com/dita-ot/dita-ot/wiki/Java-Coding-Conventions
https://github.com/dita-ot/dita-ot/wiki/XSLT-Coding-Conventions
https://github.com/dita-ot/docs/wiki/coding-guidelines

I have updated the unit tests to reflect the changes in my code.

We need to add an XSpec test for table stylesheet.

Cherry-picked in 7d9e1cf4f58b9cb271a2e60897d4a3f66cf2d812


Adding list of reviewers.

A typo in that first line:
"This books introduces you ..." ==> "This book introduces you ..."  ;-)

Thanks for including me in the list!
Take care,
-Tuck
On Fri, Dec 18, 2020 at 3:12 PM Gustavo A. Hoffmann <
<EMAIL_ADDRESS>wrote:

@gusthoff https://github.com/gusthoff requested your review on: #474
https://github.com/AdaCore/learn/pull/474 Adding list of reviewers..
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/AdaCore/learn/pull/474#event-4131315754, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AANZ4FOTDAVZJLLU5OBKX7LSVOZT7ANCNFSM4VBUFNQQ
.


More Providers in CCDA exporter

We've received a request to support multiple providers in CCDA.
Currently the CCDA exporter is very limited in the provider information it exports -- only a patient's preferred ambulatory provider is exported, in the top-level author and custodian fields.   Additionally encounters, procedures, medications, and other entries do not refer to the associated provider. (Compare to the FHIR exporters, which include resources for each encounter and provider, and each health record resource is linked to both)

closing as a dup of #413


Debug: Open Link created chrome config when only msedge is installed

Testing #191545
I don't have Chrome installed, but Edge. If Open Link would detect which browsers are available, this would have worked out-of-the-box.

Open Link will use Edge if that's set to the default browser. Otherwise, it'll use Chrome. What's your default browser and operating system?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


how to train livox dataset on object detection task

hi @Livox-SDK, do you know how to train the livox dataset with tf or pytorch?

Hi, rockzhan,
There are a lot of helpful resources online you could accessing.These two links are what I found directly from google, hope it helps .
TensorFlow: https://www.tensorflow.org/tutorials/customization/custom_training_walkthrough
Pytorch:  https://pytorch.org/tutorials/beginner/blitz/cifar10_tutorial.html

Hi, rockzhan,
There are a lot of helpful resources online you could accessing.These two links are what I found directly from google, hope it helps .
TensorFlow: https://www.tensorflow.org/tutorials/customization/custom_training_walkthrough
Pytorch: https://pytorch.org/tutorials/beginner/blitz/cifar10_tutorial.html

Livox - SDK, hello! Here is my questiones:
(1)How do you reuse livox_DATA for pre-training?I want to test the AP of the detection , so I want to repretrain the model, How can I get a pretrained model.
(2)what does the " is_obj_list"mean? I found this value followed by the class in rviz. Is this a score?
Looking forward to your reply!


Issues with 401 handling

authenticate always seems to call next() - even though it sets the response status to 401. Is this on purpose?

It could be great to use an express error handler as documented here : http://expressjs.com/en/guide/error-handling.html


Escape dots in GCP OIDC regular expression

Thanks, CodeQL! 😅

going test run this branch through my test.


Objects with "No Depth Test" gets drawn behind the Sky. GLES3

Godot version:

3.1.1 stable
OS/device including version:

Ubuntu 18.04. RTX Quadro 5000, Driver Version: 418.67
Issue description:

Objects with "No Depth Test" gets drawn behind the sky. Can be avoided by either checking "Transparent" or setting the environment to a color.
https://youtu.be/YnBT_Qykjzk
Steps to reproduce:

Open a fresh project
Make two MeshInstances occluding each other.
Create SpatialMaterial, check "No Depth Test" flag
Set the appropriate render priority (1 for the object with the material).

This was annoying when I made a gun that should always render on top of everything.


Opening windows color settings from inside powertoys doesn't work

ℹ Computer information

PowerToys version: 0.31.2
PowerToy Utility: All
Running PowerToys as Admin: yes
Windows build number: 1909-18363.1256

📝 Provide detailed reproduction steps (if any)

Clicking Windows color settings button inside powertoys doesn't do anything
…
…

✔ Expected result
Windows color settings should open
❌ Actual result
Windows color settings doesn't open
📷 Screenshots

@hichemfantar
thank you for reporting the issue.

Note to dev: the current way the Windows Settings page is opened is causing to prompt this dialog:

there are three places where this is done:
https://github.com/microsoft/PowerToys/blob/f0600f17257d3f6a05f36b846a4eb3822813571f/src/settings-ui/Microsoft.PowerToys.Settings.UI/Views/ShortcutGuidePage.xaml#L110
https://github.com/microsoft/PowerToys/blob/1364f78b30c0b1377fe2f2b0178603267392a9ab/src/settings-ui/Microsoft.PowerToys.Settings.UI/Views/GeneralPage.xaml#L109
https://github.com/microsoft/PowerToys/blob/f0600f17257d3f6a05f36b846a4eb3822813571f/src/settings-ui/Microsoft.PowerToys.Settings.UI/Views/PowerLauncherPage.xaml#L175
we should replace the XAML HyperlinkButton element with a button that invokes:
Process.Start(new ProcessStartInfo("ms-settings:settings:colors") { UseShellExecute = true });

that will open the settings page without prompting the pointless dialog and might also fix this bug.

@enricogior
The described problems sounds like duplicate of #7651 and #7652.

@htcfreek
thanks for pointing that out. The proposed changed will fix #7652 as well.

@hichemfantar
we are not sure the fix will solve your problem, but since we changed the way we open the Windows Settings page, we mark this issue as resolved for now. If 0.33 will still not work for you, we will reopen the issue.

Why does the prompt say "Applications"?

Why does the prompt say "Applications"?

As I know it's a xaml-islands bug.

I see MS recommends using LaunchUriAsync, would that not be better?
bool result = await Windows.System.Launcher.LaunchUriAsync(new Uri("ms-settings:privacy-webcam"));

@Jay-o-Way
the fix for this issue has already been committed.

Great news!  This was resolved in the newly released 0.33 version of PowerToys!  Head to https://aka.ms/installpowertoys to grab latest.


API isn't working

This API isn't working now . Please look into this .

I think they removed the deployment. So, you need to deploy on your server.

How to deploy it can you help me out ??

I have worked with Vercel so, I can help you to deploy it to Vercel.
So, what are u using for your app?

Can I get your insta/mail/whatsapp for communication ??

Any update on this @sumitkolhe

Can I get your insta/mail/whatsapp for communication ??

Discord :- ANØNYMØÜ$#9330

@r3dm4st3r i'm refactoring the codebase, you can find a WIP deployment at https://saavn.vercel.app, but if you need something stable then either wait a few days or please deploy the main branch on your personal vercel account

@r3dm4st3r the api should be working now at https://saavn.me. Some endpoints have changed, do check out the updated docs at https://docs.saavn.me

@sumitkolhe awesoem man!  Many new things added, appreciated work.
Meanwhile when your API was under your refactoring, I put my hands on to make one based on laravel.


verify network navigation using to/from nodes

This may not apply to current code but posting to help you avoid an issue that I ran into in past efforts.
If using From/To Nodes provided by NHDPlusV2 I picked up on an issue where a node was duplicated across drainages causing network navigation issues when working with the national dataset.  Not sure if this was ever addressed in newer versions, but if doing national or regional efforts and queries you might consider building in a test to verify this isn't an issue.
Specific example Node 50233399 was in Snake River watershed (e.g. comids=23949489) and different drainage (e.g. comid=24559117)

Really? That would certainly cause some issues in my "prep_nhdplus" function where I generate "toCOMIDs" from the nodes.
Were you using the National Seamless or an amalgam of regional datasets?

I just verified that the Snake River issue still exists in "NHDPlusV21_NationalData_Seamless_Geodatabase_Lower48_07".  If I recall correctly I originally noted this from a regional compilation.  This specific issue is a big one that was very noticeable.  I haven't had time to fully investigated the rest of the database other than comparing from V1 results to V2.
Here is how I've dealt with this in the past, assuming upcomidv2 is a table with 2 fields of comid and associated upstream comid.
SQL : delete from upcomidv2 where (comid=24561351 and upcomid=22227020) OR (comid=24561351 and upcomid=23949489)

Wow — you’re right. FromNode is supposed to be "Unique identifier for the point at the top of the NHDFlowline feature”.
Down on page 105 of the users manual I see this:

Within Drainage Area (DA), each node is given a unique number beginning with 1. The numbers are made unique across DAs by multiplying the node number by nn0000000, where nn is unique to each drainage area. For example, DA 17 nodes are multiplied by 170,000,000.

In this case, we have two nodes — one in region 17 and one in region 18. I’m not going to attempt the math, but apparently some of the region 17 nodes overall the region 18 nodes.
After a little investigation I’m finding that it isn’t isolated to 17 and 18 but there are very few problem catchments. The investigation (reprex below) shows that there is duplication across hydro-regions but not within hydro-regions.
I think the thing to do is to only join fromNode to toNode to get “toCOMID” within a given group of TerminalPathIDs. I already require that in the prepare_nhdplus() function where I work with these data so it won’t be hard to add in.
I've got a fix implemented and will push it up soon.

Unroll for details of investigation
``` r
library(dplyr)
#>
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#>
#>     filter, lag
#> The following objects are masked from 'package:base':
#>
#>     intersect, setdiff, setequal, union
library(sf)
#> Linking to GEOS 3.8.0, GDAL 2.4.1, PROJ 5.2.0
library(nhdplusTools)
#> USGS Support Package: https://owi.usgs.gov/R/packages.html#support
flines <- readRDS("~/Documents/Data/nhdp/NHDPlusNationalData/nhdplus_flowline.rds")
check_nodes <- select(st_drop_geometry(flines), "ToNode", "REACHCODE") %>%
mutate(region = substr(REACHCODE, 1, 2))
regions <- unique(check_nodes$region)
unique_nodes <- lapply(regions, function(x, check_nodes) {
nodes <- filter(check_nodes, region == x)
unique(nodes$ToNode)
}, check_nodes = check_nodes)
names(unique_nodes) <- regions
non_unique <- lapply(regions, function(x, unique_nodes) {
other_nodes <- do.call(c, unique_nodes[names(unique_nodes)[!names(unique_nodes) %in% x]])
unique_nodes[[x]][unique_nodes[[x]] %in% other_nodes]
}, unique_nodes = unique_nodes)
names(non_unique) <- regions
lengths(non_unique)
#> 01 04 02 03 05 06 07 08 11 09 10 17 12 13 15 14 16 18
#>  2  0  2  2  3  2  2  8  6  0  2  2  0  0  1  0  1  1
non_unique
#> $01
#> [1] 200031842 200031813
#>
#> $04
#> numeric(0)
#>
#> $02
#> [1] 200031813 200031842
#>
#> $03
#> [1] 350106071 350100767
#>
#> $05
#> [1] 430008238 510057566 430008220
#>
#> $06
#> [1] 430008238 430008220
#>
#> $07
#> [1] 550015694 510057566
#>
#> $08
#> [1] 350009316 350009787 350042978 350042975 390084143 350106071 350100767
#> [8] 390069418
#>
#> $11
#> [1] 350009316 350009787 350042978 350042975 390069418 390084143
#>
#> $09
#> numeric(0)
#>
#> $10
#> [1] 590001708 550015694
#>
#> $17
#> [1] 590001708  50233399
#>
#> $12
#> numeric(0)
#>
#> $13
#> numeric(0)
#>
#> $15
#> [1] 720055883
#>
#> $14
#> numeric(0)
#>
#> $16
#> [1] 720055883
#>
#> $18
#> [1] 50233399
any_dup <- lapply(regions, function(x, unique_nodes) {
any(duplicated(unique_nodes[[x]]))
}, unique_nodes = unique_nodes)
unlist(any_dup)
#>  [1] FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE
#> [13] FALSE FALSE FALSE FALSE FALSE FALSE

Created on 2020-01-05 by the [reprex package](https://reprex.tidyverse.org) (v0.3.0)

Thanks for following up on that.  Good to know it isn't an isolated issue, I'll have to consider that in my Python solutions as well.


How to set an API key on the fly

I show that the this feature was added 8 months ago to set the setApikey(), but there is no documentation for it. I have many api keys (many customers) how do I activate that account and then add subscribers to a list in that account?
where do I put the setApikey()?
$mc = $this->get('hype_mailchimp');
$mc->setApikey('xxxxxxxx-us11');
$data = $mc->getList()
->setListId('xxxxxxxx')
->subscribe('email@email.com');
var_dump($data);

yup, that would work


HTTPError: 400

Hi, I tried to evoke gpt-commit.py and got the following error:
Traceback (most recent call last):
File "./gpt-commit/gpt-commit.py", line 85, in
summaries = summarize_added_modified() + "\n\n" + summarize_deleted(
File "./gpt-commit/gpt-commit.py", line 59, in summarize_added_modified
[summarize_diff(get_diff(file)) for file in modified_files])
File "./gpt-commit/gpt-commit.py", line 59, in
[summarize_diff(get_diff(file)) for file in modified_files])
File "./gpt-commit/gpt-commit.py", line 35, in summarize_diff
return complete(DIFF_PROMPT + "\n\n" + diff + "\n\n")
File "./gpt-commit/gpt-commit.py", line 28, in complete
response.raise_for_status()
File "/mnt/users/adot/CondaEnvs/py_drit/lib/python3.8/site-packages/requests/models.py", line 960, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.openai.com/v1/completions
I have added OPENAI_API_KEY. Do I need any more settings about OpenAI?

Setting OPENAI_API_KEY should suffice. Could you print and look at the headers and body in complete?

fixed with https://github.com/markuswt/gpt-commit/pull/5

I got the same when my commit contained binaries.

Fixed this now


Option to disable preflight.

I'm developing a single component that will be part of a larger web app. How can I disable the preflight CSS normalisations and just generate the classes which I actually use? Thank you.

currently that is not supported. I add this as an enhancement to the roadmap

Thank you.

will go live the next days with v4. 3151e05b4aa48b65b98d8bd7fe8c01481aad1094
docs will be at integration guide


chore(test): update wallaby configuration

Description:
This PR updates wallably configuration to use newly migrated mocha test runner.

Merged with 141b356.


tag can not be set in setting

updated to 1.2.2
I set #review in setting and when I reopen the setting the tag disappears. I have tried several times.
Then when I do the review,it alerted " Please tag the note appropriately for reviewing."

Hello,
Is there an error on the console? (CTRL + SHIFT + I)

My guess is that this is occuring since the tag setting was not available in previous versions. Try uninstalling and reinstalling the plugin.

I deleted the plugin folder and reinstalled the plugin.Now it seems ok

Now that its fixed, I'll close this issue


Update progress in toggleScroll

From the comment by @jayjoshi123:

toggleScroll() function needs to be updated

OLD Function:

toggleScroll: function () {
    this.params.scrollParent = !this.params.scrollParent;
    this.drawBuffer();
},

UPDATED Function:

toggleScroll: function () {
this.params.scrollParent = !this.params.scrollParent;
this.drawBuffer();

    //Progress percentage should also be defined
    this.drawer.progress(this.backend.getPlayedPercents());
},

The issue notes was that when the waveform changed from full to scroll and vice-versa on toggleScroll, the progress kept jumping to an incorrect location.
We used a button to toggleScroll()  and a large audio.
the fix below solved the issue in wavesurfer.js
toggleScroll: function () {
this.params.scrollParent = !this.params.scrollParent;
this.drawBuffer();
//Progress percentage should also be defined
this.drawer.progress(this.backend.getPlayedPercents());
},


Production mode build fails with experiments.outputModule: true together with optimization.runtimeChunk: 'single'

Bug report

What is the current behavior?
Running webpack-cli prints the following error:
ERROR in runtime.js from Terser
'return' outside of function [runtime.js:130,9]

If the current behavior is a bug, please provide the steps to reproduce.
Reproduction repository: https://github.com/ludofischer/webpack-outputmodule-bug

Create this webpack.config.js:

module.exports = {
    experiments: {outputModule: true},
    mode: 'production',
    optimization: {
      runtimeChunk: 'single'
    }
}

Install webpack and webpack-cli
Place your source in src/index.js
run npx webpack

What is the expected behavior?
I think either:

output just the minified application code in dist/
output the minified application code and a minified webpack runtime
give an error message saying  runtimeChunk: 'single' is useless with outputModule: true

I am not sure about the expected behaviour because I don't know whether the webpack runtime is ever needed with outputModule: true.

Other relevant information:
The code builds if we change mode: production to mode: 'development' in webpack.config.js.
I see that without runtimeChunk: 'single', the runtime is not included in the bundle .
webpack version:  5.11
Node.js version: v14.15.1
Operating System: Fedora 33
Additional tools: none

Also seeing this - also, when using this experiment, I'm not seeing any difference in output. I've gotten around the reported bug by disabling minification to inspect the final output. It looks just the same as not using the setting. Maybe I'm missing something?

Also seeing this - also, when using this experiment, I'm not seeing any difference in output. I've gotten around the reported bug by disabling minification to inspect the final output. It looks just the same as not using the setting. Maybe I'm missing something?

Yes, it is bug, we need to fix it

Yes, it is bug, we need to fix it


ModuleNotFoundError: No module named 'FreeCAD'

Python 3.10.4
cqparts installed via pip (0.2.1)
Python 3.10.4 (main, Mar 23 2022, 23:05:40) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from cqparts.params import ParametricObject, Float, Int
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/torsten/.local/lib/python3.10/site-packages/cqparts/__init__.py", line 77, in <module>
    from .component import Component
  File "/home/torsten/.local/lib/python3.10/site-packages/cqparts/component.py", line 2, in <module>
    from .constraint import Mate
  File "/home/torsten/.local/lib/python3.10/site-packages/cqparts/constraint/__init__.py", line 12, in <module>
    from .mate import Mate
  File "/home/torsten/.local/lib/python3.10/site-packages/cqparts/constraint/mate.py", line 3, in <module>
    from ..utils.geometry import CoordSystem
  File "/home/torsten/.local/lib/python3.10/site-packages/cqparts/utils/__init__.py", line 18, in <module>
    from .geometry import CoordSystem
  File "/home/torsten/.local/lib/python3.10/site-packages/cqparts/utils/geometry.py", line 6, in <module>
    import FreeCAD
ModuleNotFoundError: No module named 'FreeCAD'

Same here


Add Superstruct

By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖
⬆⬆⬆⬆⬆⬆⬆⬆⬆⬆
Name: superstruct
GitHub: https://github.com/ianstormtaylor/superstruct
Yarn: https://yarnpkg.com/package/superstruct
NPM: https://www.npmjs.com/package/superstruct
Stars: 4.6k
Downloads: 733.3k / mo
Superstruct makes it easy to define interfaces and then validate JavaScript data against them. Its type annotation API was inspired by Typescript, Flow, Go, and GraphQL, giving it a familiar and easy to understand API.
But Superstruct is designed for validating data at runtime, so it throws (or returns) detailed runtime errors for you or your end users. This is especially useful in situations like accepting arbitrary input in a REST or GraphQL API. But it can even be used to validate internal data structures at runtime when needed.
import { assert, object, number, string, array } from 'superstruct'

const Article = object({
  id: number(),
  title: string(),
  tags: array(string()),
  author: object({
    id: number(),
  }),
})

const data = {
  id: 34,
  title: 'Hello World',
  tags: ['news', 'features'],
  author: {
    id: 1,
  },
}

assert(data, Article)
// This will throw an error when the data is invalid.
// If you'd rather not throw, you can use `is()` or `validate()`.

I've used this in the past. It's great. 👍🏻


OAuth Server-to-Server App Builder Error

Describe the bug
App Builder action is making a call to get an IMS token via OAuth Server-to-Server
When invoking an app builder action which has been deployed using aio app run  making a call to get an IMS token via OAuth Server-to-Server the script returns the below error:
{   "error": "An error has occurred: IMSLibError: [IMSSDK:CANNOT_GENERATE_TOKEN] Cannot generate token because no plugin supports configuration:\n[plugin:jwt]: [IMSJWTSDK:MISSING_PROPERTIES] JWT not supported due to some missing properties: client_secret,meta_scopes,private_key" }
When the same action is run locally via node ./action/action-name/index.js the action works as expected and a token is returned.
Code being used:
const { context, getToken, getTokenData } = require('@adobe/aio-lib-ims');

async function main(params) {
  const config = {
    client_id: '_redacted_',
    client_secrets: ['_redacted_'],
    ims_org_id: '_redacted_',
    scopes: ['AdobeID', 'openid', 'read_organizations', 'additional_info.projectedProductContext', 'additional_info.roles', 'adobeio_api', 'read_client_secret', 'manage_client_secrets', 'event_receiver_api'],
    technical_account_email: '_redacted_',
    technical_account_id: '_redacted_',
  };
  await context.set('imsToken', config);

  const token = await getToken('imsToken');
  const tokenDecoded = getTokenData(token);
  console.log(token, tokenDecoded);
  return { token, tokenDecoded };
}
exports.main = main;

To Reproduce

Create action which uses @adobe/aio-lib-ims to get a token using OAuth Server-to-Server
Deploy action via aio app run
Invoke aciton via aio rt action invoke *action name* --result
Observe error above

Expected behavior
A token is returned

Seems to be related to the WEBPACK_ACTION_BUILD condition. When removing the conditional include of the oauth package the code adove works as expected
https://github.com/adobe/aio-lib-ims/blob/d45606dec20577ba953b3968aa0ae1e518ab3855/src/token-helper.js#L32

@shazron can you confirm if moving the oauthSTS KVP to https://github.com/adobe/aio-lib-ims/blob/d45606dec20577ba953b3968aa0ae1e518ab3855/src/token-helper.js#L25 and the conditional require on https://github.com/adobe/aio-lib-ims/blob/d45606dec20577ba953b3968aa0ae1e518ab3855/src/token-helper.js#L36 to the head is the fox, this is what I've done in a private patch and appears to resolve the issue.

Thanks @arobsco! This is now fixed and will be released soon.
Had you sent a pr we would have happily accepted it. We ended up not doing it exactly as you did, but your workaround helped isolate the issue.

Great stuff, thanks @purplecabbage. I know you guys have internal repos and what not so wasn't sure if it was worth PRing or not! Know for the future!


Multiple browser windows open occasionally

VSCode Version: Code - Insiders 1.16.0-insider (1c6f2f9a8012565adcc50616c3aa90cb444e8797, 2017-08-23T05:10:58.701Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

beautify
Hoo
1.1.1

html-snippets
abu
0.1.0

jshint
dba
0.10.15

vscode-icons
rob
7.12.0

open-in-browser
tec
1.1.0

vscode-preview-server
yui
0.7.0

vscode-preview-server works well apart from with certain pages,  2 will open in Chrome (default) and even when closed sometimes will re-load the page being worked on in VS. Doesn't seem to happen when using view in side panel just view in browser. May well have to do with pages where there is a JSCript timer that has run?

Steps to Reproduce:

Load page in browser with CTRL-SHIFT-L
2.Closing page

Reproduces without extensions: Yes/No

You will need to create an issue against the extension. I'm guessing it's this one? https://github.com/YuichiNukiyama/vscode-preview-server


Why is fine-tuning so slow?

InternLM2-xcomposer has the same size of LLM as LLaVA-1.5 and the same CLIP. However, the fine-tuning time is almost 3.5 times slower than LLaVA-1.5. What's causing it?

Can I know how many gpu you use?

8 x A100 80G

Our model is designed for high-resolution and long-context inputs/outputs. You can adjust the fine-tune hyper-parameters, e.g., hd_num, max_len to accelerate.


Detailed information when downloading from Azure blob

Currently, we only see the throughput displayed when we download a file from a blob.
If we add the option --output=json, it adds a bit more information but that is not readable from an end user perspective.
We would need to have the size of the file being downloaded, the time remaining, the size remaining, etc.

Hi @AlexBlain, thanks for reaching out!
To clarify, the JSON output is not meant to be read by the end user; it's for applications that spawn AzCopy to easily parse the output.
Could you please clarify what the expected behavior is? Did you mean you wanted to see the throughput in the JSON?
The real time throughput can be easily computed with the fields Timestamp and TotalBytesTransferred. In fact, that's how the throughput was calculated when --output=text: throughput = (current TotalBytesTransferred - previous TotalBytesTransferred)/(current Timestamp - previous Timestamp).
Remaining bytes is equal to TotalBytesEnumerated - TotalBytesTransferred.


Force Widen Terminal Window

The printed board if the console doesn't fit the columns amount is buggy, and it keeps being badly printed after resizing the window, unlike having the right size from the beginning (that requires the user to resize the console window asap after opening vry).
Maybe there's something that scales the board to the window size but it seems like it just breaks the board, even more after rescaling the window to a higher surface.
I could provide screenshots if it's not enough clear, but it can be easily reproduced, just enable all columns available (and even one more in immortal if the guy is on the leaderboard) without resizing the console after launch, and see the result on match 😅

Making terminal wider is bad solution instead I found a way to expand it to max size without resizing terminal, will come in next update.

Fixed in 188a3f0.


Fix examples

Fix some examples.

Codecov Report

Merging #222 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   62.22%   62.22%
=======================================
  Files          19       19
  Lines        1260     1260
=======================================
  Hits          784      784
  Misses        476      476

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f66ecb...3e1e9be. Read the comment docs.


feat: Geojson marker has the onPress functionality now

Does any other open PR do the same thing?
I could not find any other PR to do the same thing.
What issue is this PR fixing?
#3727
How did you test this PR?

I tested this PR on both Android and iOS.
Tested on both simulator and real devices

Related to https://github.com/react-native-maps/react-native-maps/pull/3499

@WrathChaos This looks great! One last request. Could you update the docs to include the onPress prop? https://github.com/react-native-maps/react-native-maps/blob/master/docs/geojson.md

@christopherdro I updated the doc as well :)

@christopherdro  thank you! When do you think it is available on the new release?

@WrathChaos It might take some time because we currently have 0.28.0 pending release so these changes will probably land in the release after that. I'd suggest cherry-picking this commit if you need to immediately in your project or patch the package with these changes.

@christopherdro sorry to bug, may I know if we have exact eta for this to be deployed ? :-)


iOS popup fix

Fixes #19

Hi @PeterStaev
I've checked in a fix for the popup dismissal. Also enableLocationRequest now returns Promise. Please test it and if everything works as expected I will push it to npm.
Thank you for your contribution.

@hshristov , works great!


Fix compile warnings and move some conversion methods to std::convert trait impls

Leaving this open for discussion since  std::convert seems to be controversial.
cc @eddyb

From and AsRef seem pretty awesome, they clean code a lot.

Oh man, the new From<T> thing is great!

Any updates on this?

Since @eddyb hasn't commented on this, I guess it's good to merge?


[Table] All option demo display wrong text

When select All option in table pagination(with -1 value) the display text shown 1--1 of x instead of 1-x of x

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Display wrong number( -1 ) when select ALL option.
Expected Behavior 🤔

Should display 1-x of x when x is the number of rows
Steps to Reproduce 🕹

Steps:

go to example in https://material-ui.com/components/tables/#custom-pagination-options
select All option in pagination
the text become 1--1 of 13

Context 🔦

Trying to get correct data
Your Environment 🌎

https://material-ui.com/components/tables

@hswimmer Thanks for the report. It looks like we can fix the demo:
diff --git a/docs/src/pages/components/tables/CustomPaginationActionsTable.tsx b/docs/src/pages/components/tables/CustomPaginationActionsTable.tsx
index 974475210d..7bd0e7a2c7 100644
--- a/docs/src/pages/components/tables/CustomPaginationActionsTable.tsx
+++ b/docs/src/pages/components/tables/CustomPaginationActionsTable.tsx
@@ -186,7 +186,7 @@ export default function CustomPaginationActionsTable() {
         <TableFooter>
           <TableRow>
             <TablePagination
-              rowsPerPageOptions={[5, 10, 25, { label: 'All', value: -1 }]}
+              rowsPerPageOptions={[5, 10, 25, { label: 'All', value: rows.length }]}
               colSpan={3}
               count={rows.length}
               rowsPerPage={rowsPerPage}

Do you want to work on a pull request? :)

@oliviertassinari
I have an issue with the suggested solution:
I want to keep the selected rowsPerPage for displaying this numbers of rows in next use.
When I keep the -1 option and use this number in next view - I always see all rows.
but if I use rows.length and the number of rows was changed from last view - everything is get messy:  the first option is marked as selected, only "prev rows.length " rows are shown.
To avoid this wrong behavior we can add a workaround in our code,
but maybe you can add the next change -:

@hswimmer Thanks for looking into but it's already handled in #23280

but if I use rows.length and the number of rows was changed from last view - everything is get messy: the first option is marked as selected, only "prev rows.length " rows are shown.

Ok, this sounds fair. We could restore the support of -1, with a test case and description of its support in the prop this time. @JoaoJesus94. What do you think? We could do the same for the prop count, where -1 means "unknown". For rowsPerPage it could mean "all".

Ok, this sounds fair. We could restore the support of -1, with a test case and description of its support in the prop this time. @JoaoJesus94. What do you think? We could do the same for the prop count, where -1 means "unknown". For rowsPerPage it could mean "all".

@oliviertassinari It seems that the changes that @hswimmer suggested will fix it.
Regarding prop count I think we don't need to touch it. -1 already means "unknown"

@JoaoJesus94 Sounds great, we would only need to add a test case to avoid a regression in the future (like we already had) :)


[DOC] - Migration guide for existing users

Preliminary Checks

[X] This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/nebari-dev/nebari/discussions

Summary

How does the QHub -> Nebari renaming affect existing users
What are the steps they need to take to update their instances

Steps to Resolve this Issue
n/a

Note -- we need to add a link to this migration guide in faq#how-do-i-migrate-qhub-to-nebari which was added in #115

xref: https://github.com/orgs/nebari-dev/discussions/1604

I think this PR covers this topic for migrating from pre 0.4 to 0.4+


Update docker image

Docker image is outdated now

@LinkinStars tag missing on docker https://hub.docker.com/r/answerdev/answer/tags


[Bug]: Drawer Bar Not Fully Scrollable in Normal Screen Mode

Contact Details
No response
What happened?
The drawer bar on the website is not scrollable to the end, causing content to be inaccessible. However, when viewing the website in full-screen mode you can see all options. Additionally, the chat option covers some of the content, making it impossible to read the text underneath.
Steps to reproduce:

Open the website in a browser.
Navigate to the Account page ( click in your image in the right of the screen)
Click on preferences.
Check the drawer in the left of the screen and attempt to scroll to the end of the drawer bar content.
Enter full-screen mode.
Observe that the content is cut off and cannot be accessed.
Notice that the chat option covers part of the content, making it unreadable.

This image shows how you can't scroll down the drawer when the screen is on normal mode

This image shows how the chat option covers the text.
What browsers are you seeing the problem on?
Others
Relevant log output
Expected Behavior:
The drawer bar should be fully scrollable to access all content, even in normal-screen mode.
The chat option should not obscure any content on the page.
Actual Behavior:
The drawer bar is not scrollable to the end, and the chat option covers part of the content, making it inaccessible.
Environment:

Browser: [Opera and Google Chrome]

Are you interested in contributing?

[X] I'd like to work on this issue

Code of Conduct

[ ] I have used the search function to check if an issue already exists
[X] I agree to follow this project's Code of Conduct

Hey @namnoum, what's the screensize?

Hey @namnoum, what's the screensize?

It's 14"

Hey @namnoum, what's the screensize?

It's 14"

https://viewportsizer.com/what-is-my-screen-size/

Hey @namnoum, what's the screensize?

It's 14"

https://viewportsizer.com/what-is-my-screen-size/

1211 × 588

Thanks for pointing this out. Assigned

@youssefjaziri456 is currently working on this issue

@pranshugupta54 I would like to work on this issue if no one is working, I want to work under gssoc24

@holopin-bot @namnoum bug-hunter


Remove code duplication in reduce ops

Proposed changes
Switch the reducer operations to a template to avoid duplicating the loop logic for min/max/sum.
The change is covered by existing tests.
Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING document
[x] I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have updated the necessary documentation (if needed)

I think this is a good change but I have a proposal to make that will simplify more.

Thank you very much! This is indeed much better!


Add render block controller

For now, we are rendering block through the Twig function. I think that making it with a custom controller would be more flexible as it can have an optional template parameter. Sometimes the default CMS Block templates are not enough. What I would like to achieve is I want it to be rendered like this: {{ render(path('bitbag_cms_render_block', {'code' : 'homepage_slide_1', 'template' : '@App/Cms/homepageSlide.html.twig'})) }} instead of {{ bitbag_render_block('homepage_slide_1') }}.  Maybe it would be also a nice idea to allow an optional parameter to the bitbag_render_block function for a template.

@bitbager thanks to the ResourceController this is already possible by simple adding:
bitbag_shop_partial_block_index_by_code:
    path: /by-code/{code}
    methods: [GET]
    defaults:
        _controller: bitbag.controller.block:indexAction
        _sylius:
            template: $template
            repository:
                method: findOneByCode
                arguments:
                    - $code

and then in your template you could render a block with:
{{ render(url('bitbag_shop_partial_block_index_by_code', {'code': 'my_image_block', 'template': '@BitBagCmsPlugin/Shop/Block/imageBlock.html.twig'})) }}

Implemented ✅


Revert some breaking changes to the containerService API

@amarzavery

This change is

 https://github.com/Azure/azure-sdk-for-node/pull/1950

 https://github.com/Azure/azure-sdk-for-ruby/pull/526

 https://github.com/Azure/azure-sdk-for-python/pull/836


Can not load shimadzu lcd file

I can not open or convert this lcd file, please someone help!

LOAD ERROR LCD file.zip

Is it IT-TOF? That's not supported, only QTOF and QQQ.


cross-env eats backslashes

cross-env version: 5.1.3
node version: 8.9.4
npm (or yarn) version: 5.6.0

Relevant code or config, in package.json
{
  "name": "test-cross-env",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test1": "cross-env TEST=foo node main.js",
    "test2": "node main.js"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "cross-env": "^5.1.3"
  }
}

main.js
console.log(process.argv.join(' '));

What you did:
passed \\someshare\somefolder through cross-env
What happened:
cross-env ate a backslash

C:\Users\gregg\temp>npm run test1 \\someshare\somefolder

><EMAIL_ADDRESS>test1 C:\Users\gregg\temp
> cross-env TEST=foo node main.js "\\someshare\somefolder"

C:\Program Files\nodejs\node.exe C:\Users\gregg\temp\main.js \someshare\somefolder

C:\Users\gregg\temp>npm run test2 \\someshare\somefolder

><EMAIL_ADDRESS>test2 C:\Users\gregg\temp
> node main.js "\\someshare\somefolder"

C:\Program Files\nodejs\node.exe C:\Users\gregg\temp\main.js \\someshare\somefolder

Reproduction repository:
see above
Problem description:
cross-env eats backslashes. Not going through cross-env the backslashes make it into the program being excecuted
You can't even escape them with more backslashes
C:\Users\gregg\temp>npm run test1 \\\\someshare\somefolder

><EMAIL_ADDRESS>test1 C:\Users\gregg\temp
> cross-env TEST=foo node main.js "\\\\someshare\somefolder"

C:\Program Files\nodejs\node.exe C:\Users\gregg\temp\main.js \someshare\somefolder

Normally, you pass args to npm scripts via --, as shown in the npm docs here:
https://docs.npmjs.com/cli/run-script
Otherwise, you're just passing the args to npm, not your script. If they make it through somehow, then you probably got lucky.
Have you tried the documented way like this?:
> npm run test1 -- \\someshare\somefolder

Sorry, there was a typo in my original message. Why don't you actually try it and you'll see the bug

Yes, looks like it's probably a legit bug. Feel free to make a pull request to fix this :)

@greggman LOL at the thumbs down for trying to give you legitimate advice for the code you actually posted. Your 'typo' makes a huge difference in the behavior, but I guess we're supposed to read your mind instead of your text.

sorry I tried to helpful. won't bother next time

@rob3c, that tone was unappreciated. Thank you both for trying to be helpful in general.


Error when running drone from deb - 0.3.0-alpha-1423116857

On drone installed via deb on an ubuntu 14.10 machine, deb version 0.3.0-alpha-1423116857, visiting the site results to:
2015/02/05 10:30:53 http: panic serving <IP_ADDRESS>:40439: read /usr/local/bin/droned: bad file descriptor
goroutine 36 [running]:
net/http.func·011()
	/usr/local/go/src/pkg/net/http/server.go:1100 +0xb7
runtime.panic(0xa997c0, 0xc20809b500)
	/usr/local/go/src/pkg/runtime/panic.c:248 +0x18d
github.com/GeertJohan/go%2erice.(*Box).MustBytes(0xc208111a10, 0xbf7090, 0xa, 0x0, 0x0, 0x0)
	/var/cache/drone/src/github.com/GeertJohan/go.rice/box.go:298 +0xc0
main.func·001(0x7f40b6d7ba10, 0xc208044c80, 0xc208108820)
	/var/cache/drone/src/github.com/drone/drone/server/main.go:133 +0x3d
net/http.HandlerFunc.ServeHTTP(0xc2080362a0, 0x7f40b6d7ba10, 0xc208044c80, 0xc208108820)
	/usr/local/go/src/pkg/net/http/server.go:1235 +0x40
net/http.(*ServeMux).ServeHTTP(0xc208022930, 0x7f40b6d7ba10, 0xc208044c80, 0xc208108820)
	/usr/local/go/src/pkg/net/http/server.go:1511 +0x1a3
net/http.serverHandler.ServeHTTP(0xc208005c20, 0x7f40b6d7ba10, 0xc208044c80, 0xc208108820)
	/usr/local/go/src/pkg/net/http/server.go:1673 +0x19f
net/http.(*conn).serve(0xc208050980)
	/usr/local/go/src/pkg/net/http/server.go:1174 +0xa7e
created by net/http.(*Server).Serve
	/usr/local/go/src/pkg/net/http/server.go:1721 +0x313

The same machine used to run an older 0.3.0 alpha just fine. Also tried it on a new machine.

Yeah same for me, it was working fine on the previous version

Something wrong with serving the static files. Note that
Running packaging/root/usr/local/bin/droned from the build output yields the same error for static files. API calls work fine.

In particular the rice commit GeertJohan/go.rice@9fe3e28736b95 seemed to have broken it. Reverting rice to an earlier version fixes drone. Since I don't go, I'm not certain if this is a problem with drone or rice.

@jvliwanag definitely seems to be an issue with go.rice. Can you see if it is just the index.html? Or does it also fail to load other static files like /static/styles/drone.css? Just trying to get more details so I can open an issue with the go.rice team. Unfortunately I'm not on my laptop, so my ability to troubleshoot today is limited :/

/static/styles/drone.css is served fine. But those at the root: index.html, favicon.png, favicon.ico don't work.

Sorry, scratch that. /static/favicon.png, /static/favicon.ico are ok. It's just index.html.

OK thanks, good to know! The index.html file is the only one that we manually write to the response:
http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
	w.Write(assets.MustBytes("index.html"))
})

This tells me something changed with the MustBytes and allows me to log a more targeted issue with the go.rice authors.

Ran into this problem as well. It has me wondering what the best practice is for version pinning in golang for github commits/releases, or if it's possible.
nodejs's package.json allows: "github.com/user/project#commit"

There is no official solution for versioning, however there are some third party tools that allow you to either a) vendor dependencies and b) lock revisions:
https://code.google.com/p/go-wiki/wiki/PackageManagementTools#Revision_Locking
We tried vendoring dependencies (Godep) a while back and it seemed to cause more problems than it solved. At the time, however, none of the revision locking solutions existed. So I definitely think there are some new options worth exploring

Fixed. Thanks for helping diagnose

Good to know, thanks for the overview.