FlowListView not scrolling to show all the content when contained in a ScrollView...

Hi,
So I have a FLV, which is defined something like:
                `<flv:FlowListView
                    Grid.Column="1"
                    SeparatorVisibility="None"
                    HeightRequest = 500
                    HasUnevenRows="True"
                    FlowColumnCount="2"
                    FlowItemsSource="{Binding LatestHolidayDeals}">
                    <flv:FlowListView.FlowColumnTemplate>
                        <DataTemplate>
                            <Grid Padding="4">
                                <ffimageloading:CachedImage
                                    HeightRequest="200"
                                    Aspect="AspectFill"
                                    DownsampleToViewSize="False"
                                    Source="{Binding ThumbnailUrl}">
                                </ffimageloading:CachedImage>
                            </Grid>
                        </DataTemplate>
                    </flv:FlowListView.FlowColumnTemplate>
                </flv:FlowListView>'

It is contained in a Grid with other content next to it, and the Grid is contained in a root ScrollView for the page. There are 6 items in the list and my expectation is that the FLV would internally scroll if the overall content height becomes bigger than the FLV, but this is not happening. It gets cut off instead with no scrolling within the FLV occurring. The root ScrollView in the page takes over, but you are not able to see all the content in the FLV with the last row of images being cut off at the end.  Removing the FLV HeightRequest makes no difference in this case. I am testing this in Landscape mode on a Android phone. Any ideas what I doing wrong?
EDIT: So just tested this same code on iOS (and UWP), and it works as expected, i.e. the internal scroll of the FLV works along side the ScrollView for the page. So this is something related to only Android.

https://stackoverflow.com/questions/6210895/listview-inside-scrollview-is-not-scrolling-on-android/6211286#6211286
The same thing applies to a standard Xamarin.Forms ListView too.


Add R CLI tools

Tool information

Tool name: R
Tool license: GNU
Add or update? Add
Desired version: latest 3.x and 4.x versions
Approximate size: 150MB
If this is an add request:

Brief description of tool: R is a language and environment for statistical computing and graphics. R provides a wide variety of statistical (linear and nonlinear modelling, classical statistical tests, time-series analysis, classification, clustering, …) and graphical techniques, and is highly extensible.
URL for tool's homepage: https://www.r-project.org/

Area for Triage:
Scripting and command line
Question, Bug, or Feature?:
Feature
Virtual environments affected

[x] macOS 10.15
[x] Ubuntu 16.04 LTS
[x] Ubuntu 18.04 LTS
[x] Ubuntu 20.04 LTS
[x] Windows Server 2016 R2
[x] Windows Server 2019

Can this tool be installed during the build?
Yes, though specifying specific versions can be tricky across platforms. Basic installations are:
### Windows
choco install R.Project
choco install rtools

### Ubuntu
sudo apt-get install -y r-base

### macOS
brew install r

Tool installation time in runtime
Windows: ~4 minutes
Ubuntu: ~1 minute
macOS: ~1 minute
Are you willing to submit a PR?
No
cc @margaretmeehan @jeremydelacruz

Hello, thank you for your request.
We have added this issue to our backlog and will handle it soon

There is also an action that installs a requested R version, and it is cross platform: https://github.com/r-lib/actions/tree/master/setup-r#setup-r

Is there any chance of reconsidering this? The versions of R available via the platform package managers are generally quite old, so they are often not useful in CI settings.
In addition the version of R installed by homebrew is not generally the best for macOS, rather installing the CRAN binary from the cask would be preferred, e.g. brew cask install r. There are some details on why this is preferred at https://rstats.wtf/set-up-an-r-dev-environment.html#what-about-homebrew.
Having an existing R on the PATH causes our setup-r action to avoid installing R, which breaks builds relying on it.
It seems there are more than 4000 workflows using this action (https://github.com/search?q=path%3A.github+"setup-r"&ref=opensearch), so this is a fairly severe issue.
We will change the action to unconditionally install R and workaround this issue. But generally I think it would be better for the R community not to have any R version installed by default on the images.

Hello @jimhester , thank you for your feedback.
We are trying to use package managers as much as possible because they provide easiest and convenient way to install tools and usually they provide actual versions of software.
If it is wrong for R, we definitely should reconsider it.

Windows: looks like choco provide actual version so I think it is okay to continue using it
MacOS: we will switch to brew cask install r
Ubuntu: looks like apt-get provide very outdated version 3.x, what is your suggestion for Ubuntu installation?

https://cloud.r-project.org/bin/linux/ubuntu/README has instructions on obtaining newer R releases on ubuntu, perhaps that could be used here.

Hello, I'm excited to see that this is being added to the images!
I wanted to ask a few questions about this. Will multiple versions of R be installed on each build agent? What would the available R versions be? If multiple versions are to be installed, will they be available in the hosted tool cache?
Thanks!
cc @fnocera @margaretmeehan

Hello @jeremydelacruz , currently, we don't have plans to support multiple versions due to maintenance concerns.
Our images are updated on weekly basis and contain the latest version always.
If your use-case requires to use multiple versions and freeze old versions, I suggest to look at [setup-r](https://github.com/r-lib/actions/tree/master/setup-r#setup-r action).

FWIW the setup-r action could benefit from R versions being available in the hosted tool cache. We use tool-cache in the code, but because the R versions are not hosted on GitHub there is no real benefit to it. If we could host them there then likely builds would become faster than they already are.

Hello, thank you for your response. Changes were added to all images and R version 4.0.2 is available. Feel free to raise additional threads if any.

Thanks so much for adding to all images so quickly, it is much appreciated! @dmitry-shibanov @maxim-lobanov


ServerPlayerEntity#cameraPosition and others are misleading

I believe that the naming of the following attributes/methods/parameters are misleading:

ServerPlayerEntity#cameraPosition (and associated getter and setter)
ServerChunkManager#updateCameraPosition
ThreadedAnvilChunkStorage#updateCameraPosition
ThreadedAnvilChunkStorage$EntityTracker#updateCameraPosition (both)
The parameter useCameraPosition in ThreadedAnvilChunkStorage#getChebyshevDistance

Here's my reasoning:
Starting with ServerPlayerEntity#cameraPosition, the only time this is updated is within ThreadedAnvilChunkStorage#updateCameraPosition, where it is set to the ChunkSectionPos that the ServerPlayerEntity is currently in. This position is stored so that when the ServerPlayerEntity changes ChunkSectionPoss, chunks within the range of this but not within the range of the ServerPlayerEntity's current chunk position can be unloaded (this is my understanding). It isn't related to ServerPlayerEntity#cameraEntity, only the ServerPlayerEntity itself.
Next with ServerChunkManager#updateCameraPosition, ThreadedAnvilChunkStorage#updateCameraPosition, and both ThreadedAnvilChunkStorage$EntityTracker#updateCameraPositions; the only argument given to these methods is a ServerPlayerEntity. Within the methods, the ServerPlayerEntity#cameraEntity is never queried. Instead, the ServerPlayerEntity's chunk position is used (or in the case of ThreadedAnvilChunkStorage#updateCameraPosition where ServerPlayerEntity#cameraPosition is also used... see above regarding that attribute).
Finally with the useCameraPosition parameter in ThreadedAnvilChunkStorage#getChebyshevDistance, this boolean is used to determine if ServerPlayerEntity#cameraPosition should be used instead of the ServerPlayerEntity's current chunk position. If ServerPlayerEntity#cameraPosition is renamed, this should be also.
I feel that names for these attributes/methods/parameters would be better if they were focused around the player instead of some "camera." While it could be thought that the camera referenced in these places is more of a "server camera" where chunk loading and unloading takes place, I still feel that the name conflicts with ServerPlayerEntity#cameraEntity as it reads that the position of this and ServerPlayerEntity#cameraPosition should be equivalent, but this is not the case.
I'd like to become more involved with the development of Yarn mappings, so I wouldn't mind submitting a PR with different names, but I'd rather get the community's feedback on this first. Also, if there are other attributes/methods/parameters within this part of the code that bear similar names and I missed, please let me know. Thanks!

Very likely that matcher matched those in minecraft updates incorrectly.

Hmm, it's from here https://github.com/FabricMC/yarn/pull/576/files#diff-8ce52bd08b24691684887c72b113c8da5e7901e5cd679ededc78c9914cea8926. Dunno what was really the original reason that it's named cameraPosition.

Looking at it, this is like a general chunk section position for the player, used by entity tracking (updating) than for any specific "camera" purpose or alike.

Looking at it, this is like a general chunk section position for the player, used by entity tracking (updating) than for any specific "camera" purpose or alike.

Primarily, ServerPlayerEntity#cameraPosition is used for chunk unloading as I understand it. The entity tracking done in ThreadedAnvilChunkStorage$EntityTracker#updateCameraPosition only uses the chunk position from the ServerPlayerEntity itself. Still, you are correct in that it doesn't pertain to any camera.

Ah, I think I find why it's called "camera". Because if the player has a camera entity, this updateCameraPosition is called every tick. This is more like a chunk section position from which the player and the client watches the entity.

Ah, I think I find why it's called "camera". Because if the player has a camera entity, this updateCameraPosition is called every tick. This is more like a chunk section position from which the player and the client watches the entity.

That would make sense as to why it was named that originally. However, it is also called in ServerPlayerNetworkHandler once in onVehicleMove and twice in onPlayerMove when the client sends the server one of these movement packets, so I still think that "camera" is a bad name for it to have as it is called even if this.cameraEntity == this.
As you've self-assigned this, are you planning on making a PR? Totally fine by me... I'm just wondering if I should ask for name feedback in Discord or wait for your PR. (I was hoping there'd be more name suggestions before I started work on it.) 🙂

Yes. I am planning to call this watchingPosition, as the field and getter/setter in server player entity is related to chunk loading and unloading (called watching chunks from clients, I think). Meanwhile, the entity tracker ones will be renamed to updateTrackedStatus as they are a different system (2 systems only happened to be updated together from the same call path)


Hyprland unexpectedly closing popup on Thunderbird

Regression?
No
System Info and Version
 System/Version info
Hyprland, built from branch main at commit 9e781040d9067c2711ec2e9f5b47b76ef70762b3  (props: bump version to 0.41.1).
Date: 2024-06-13
Tag: v0.41.1, commits: 9e781040d9067c2711ec2e9f5b47b76ef70762b3

flags: (if any)

System Information:
System name: Linux
Node name: elitebook
Release: 6.9.6
Version: #1-NixOS SMP PREEMPT_DYNAMIC Fri Jun 21 12:40:40 UTC 2024

GPU information:
c3:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Phoenix1 [1002:15bf] (rev c4) (prog-if 00 [VGA controller])

os-release: ANSI_COLOR="1;34"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.11.20240622.a71e967"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.11 (Vicuna)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.11 (Vicuna)"
VERSION_CODENAME=vicuna
VERSION_ID="24.11"

plugins:

======Config-Start======

Config File: /home/mikilio/.config/hypr/hyprland.conf: Read Succeeded
exec-once = /nix/store/y29cbwfiwb9nyi4db4apk9dgylzdjm1v-dbus-1.14.10/bin/dbus-update-activation-environment --systemd --all && systemctl --user stop hyprland-session.target && systemctl --user start hyprland-session.target
$mod=SUPER
animations {
  bezier=myBezier, 0.05, 0.9, 0.1, 1.05
  animation=windows, 1, 5, myBezier
  animation=windowsOut, 1, 7, default, popin 80%
  animation=border, 1, 10, default
  animation=fade, 1, 7, default
  animation=workspaces, 1, 6, default
  animation=specialWorkspace, 1, 6, default, slidefadevert 20%
  enabled=true
}

binds {
  allow_workspace_cycles=true
}

decoration {
  blur {
    brightness=0.800000
    contrast=0.900000
    enabled=true
    new_optimizations=on
    noise=0.010000
    passes=2
    popups=true
    size=6
  }
  col.shadow=rgba(1e1e2e99)
  dim_inactive=false
  drop_shadow=yes
  shadow_range=8
  shadow_render_power=2
}

device {
  name=at-translated-set-2-keyboard
  kb_layout=us,eu
  kb_options=grp:alt_caps_toggle
  kb_variant=,eurkey-cmk-dh-iso
  resolve_binds_by_sym=1
}

device {
  name=semico---usb-gaming-keyboard-
  kb_layout=us,eu
  kb_options=grp:alt_caps_toggle
  kb_variant=,eurkey-cmk-dh-ansi
  resolve_binds_by_sym=1
}

device {
  name=mosart-semi.-2.4g-wireless-keyboard
  kb_layout=de
  kb_options=grp:alt_caps_toggle
  resolve_binds_by_sym=1
}

dwindle {
  no_gaps_when_only=1
  preserve_split=true
  pseudotile=true
}

general {
  col.active_border=rgb(89b4fa)
  col.inactive_border=rgb(45475a)
}

group {
  groupbar {
    col.active=rgb(89b4fa)
    col.inactive=rgb(45475a)
    text_color=rgb(cdd6f4)
  }
  col.border_active=rgb(89b4fa)
  col.border_inactive=rgb(45475a)
  col.border_locked_active=rgb(94e2d5)
}

input {
  accel_profile=flat
  float_switch_override_focus=2
}

misc {
  background_color=rgb(1e1e2e)
  disable_autoreload=true
  vrr=1
}

xwayland {
  force_zero_scaling=true
}
bind=SUPER, s, exec, /nix/store/anjymykfcbv9ckgjg7l5bb9vhz4m9s8l-hyprscratch-0.4/bin/hyprscratch "Spotify Premium" "[float;size 70% 80%;center] spotify" onstart special
bind=SUPER, t, exec, /nix/store/anjymykfcbv9ckgjg7l5bb9vhz4m9s8l-hyprscratch-0.4/bin/hyprscratch Telegram "[float;size 70% 80%;center] telegram-desktop" onstart special
bind=SUPER, m, exec, /nix/store/anjymykfcbv9ckgjg7l5bb9vhz4m9s8l-hyprscratch-0.4/bin/hyprscratch "Teams for Linux" "[float;size 70% 80%;center] teams-for-linux" onstart special
bind=SUPER, d, exec, /nix/store/anjymykfcbv9ckgjg7l5bb9vhz4m9s8l-hyprscratch-0.4/bin/hyprscratch Discord "[float;size 70% 80%;center] vesktop" special
bind=SUPER, e, exec, /nix/store/anjymykfcbv9ckgjg7l5bb9vhz4m9s8l-hyprscratch-0.4/bin/hyprscratch Element "[float;size 70% 80%;center] element-desktop" special
bind=SUPER, o, togglespecialworkspace, OBS
bind=CTRL ALT, R, exec, systemctl --user restart kaizen.service
bind=ALT, Tab, focuscurrentorlast
bind=CTRL ALT, Delete, exit
bind=SUPER, Q, killactive
bind=SUPER, F, togglefloating
bind=SUPER, Z, fullscreen
bind=SUPER, M, fakefullscreen
bind=SUPER, R, layoutmsg, togglesplit
bind=SUPER, up, movefocus, u
bind=SUPER, down, movefocus, d
bind=SUPER, right, movefocus, r
bind=SUPER, left, movefocus, l
bind=SUPER, bracketleft, workspace, r-1
bind=SUPER, bracketright, workspace, r+1
bind=, code:195, workspace, r+1
bind=, code:194, changegroupactive, f
bind=, code:193, togglegroup
bind=, code:192, changegroupactive, b
bind=, code:191, workspace, r-1
bind=SUPER SHIFT, bracketleft, movetoworkspace, r-1
bind=SUPER SHIFT, bracketright, movetoworkspace, r+1
bind=SUPER CTRL, up, resizeactive, 0 -20
bind=SUPER CTRL, down, resizeactive, 0 20
bind=SUPER CTRL, right, resizeactive, 20 0
bind=SUPER CTRL, left, resizeactive, -20 0
bind=SUPER ALT, up, moveactive, 0 -20
bind=SUPER ALT, down, moveactive, 0 20
bind=SUPER ALT, right, moveactive, 20 0
bind=SUPER ALT, left, moveactive, -20 0
bind=SUPER, 1, workspace, 1
bind=SUPER, 2, workspace, 2
bind=SUPER, 3, workspace, 3
bind=SUPER, 4, workspace, 4
bind=SUPER, 5, workspace, 5
bind=SUPER, 6, workspace, 6
bind=SUPER, 7, workspace, 7
bind=SUPER, 8, workspace, 8
bind=SUPER, 9, workspace, 9
bind=SUPER SHIFT, 1, movetoworkspace, 1
bind=SUPER SHIFT, 2, movetoworkspace, 2
bind=SUPER SHIFT, 3, movetoworkspace, 3
bind=SUPER SHIFT, 4, movetoworkspace, 4
bind=SUPER SHIFT, 5, movetoworkspace, 5
bind=SUPER SHIFT, 6, movetoworkspace, 6
bind=SUPER SHIFT, 7, movetoworkspace, 7
bind=SUPER SHIFT, 8, movetoworkspace, 8
bind=SUPER SHIFT, 9, movetoworkspace, 9
bindl=,XF86AudioPlay,    exec, /nix/store/gwq9wkd1fd0srg1xchffg0h6zd7ga0qk-playerctl-2.4.1/bin/playerctl play-pause
bindl=,XF86AudioStop,    exec, /nix/store/gwq9wkd1fd0srg1xchffg0h6zd7ga0qk-playerctl-2.4.1/bin/playerctl pause
bindl=,XF86AudioPause,   exec, /nix/store/gwq9wkd1fd0srg1xchffg0h6zd7ga0qk-playerctl-2.4.1/bin/playerctl pause
bindl=,XF86AudioPrev,    exec, /nix/store/gwq9wkd1fd0srg1xchffg0h6zd7ga0qk-playerctl-2.4.1/bin/playerctl previous
bindl=,XF86AudioNext,    exec, /nix/store/gwq9wkd1fd0srg1xchffg0h6zd7ga0qk-playerctl-2.4.1/bin/playerctl next
bindl=,XF86AudioMicMute, exec, /nix/store/ia9aqrh0w4vlgkjpzqrrgamscna7kzgx-pulseaudio-17.0/bin/pactl set-source-mute @DEFAULT_SOURCE@ toggle
bindl=,switch:off:Lid Switch,exec,hyprctl keyword monitor "eDP-1, preffered, auto, 1"
bindl=,switch:on:Lid Switch,exec,hyprctl keyword monitor "eDP-1, disable"
bindle=,XF86MonBrightnessUp,   exec, /nix/store/2jzm4kd83c27ssk78bc7c38hxm25swid-brightnessctl-0.5.1/bin/brightnessctl set +5%
bindle=,XF86MonBrightnessDown, exec, /nix/store/2jzm4kd83c27ssk78bc7c38hxm25swid-brightnessctl-0.5.1/bin/brightnessctl set  5%-
bindle=,XF86AudioRaiseVolume,  exec, /nix/store/ia9aqrh0w4vlgkjpzqrrgamscna7kzgx-pulseaudio-17.0/bin/pactl set-sink-volume @DEFAULT_SINK@ +5%
bindle=,XF86AudioLowerVolume,  exec, /nix/store/ia9aqrh0w4vlgkjpzqrrgamscna7kzgx-pulseaudio-17.0/bin/pactl set-sink-volume @DEFAULT_SINK@ -5%
bindm=SUPER, mouse:273, resizewindow
bindm=SUPER, mouse:272, movewindow
bindr=$mod, SPACE, exec, pkill anyrun || run-as-service anyrun
exec-once=/nix/store/anjymykfcbv9ckgjg7l5bb9vhz4m9s8l-hyprscratch-0.4/bin/hyprscratch clean
monitor=desc:Chimei Innolux Corporation 0x1435,preferred,auto-down,1.2
monitor=,preferred,auto-up,auto
windowrule=float, ^(org.gnome.Calculator)$
windowrule=float, ^(org.gnome.Nautilus)$
windowrule=float, ^(pavucontrol)$
windowrule=float, ^(nm-connection-editor)$
windowrule=float, ^(blueberry.py)$
windowrule=float, ^(org.gnome.Settings)$
windowrule=float, ^(org.gnome.design.Palette)$
windowrule=float, ^(Color Picker)$
windowrule=float, ^(xdg-desktop-portal)$
windowrule=float, ^(xdg-desktop-portal-gnome)$
windowrule=float, ^(transmission-gtk)$
windowrule=float, ^(com.github.Aylur.ags)$
windowrulev2=float,initialTitle:^(Spotify Premium)$
windowrulev2=float,initialTitle:^(Telegram)$
windowrulev2=float,initialTitle:^(Discord)$
windowrulev2=float,initialTitle:^(Element)$
windowrulev2=float,initialTitle:^(OBS)$
windowrulev2=float,initialTitle:^(Teams for Linux)$
windowrulev2=size 70% 80%,initialTitle:^(Spotify Premium)$
windowrulev2=size 70% 80%,initialTitle:^(Telegram)$
windowrulev2=size 70% 80%,initialTitle:^(Discord)$
windowrulev2=size 70% 80%,initialTitle:^(Element)$
windowrulev2=size 70% 80%,initialTitle:^(OBS)$
windowrulev2=size 70% 80%,initialTitle:^(Teams for Linux)$
windowrulev2=center,initialTitle:^(Spotify Premium)$
windowrulev2=center,initialTitle:^(Telegram)$
windowrulev2=center,initialTitle:^(Discord)$
windowrulev2=center,initialTitle:^(Element)$
windowrulev2=center,initialTitle:^(OBS)$
windowrulev2=center,initialTitle:^(Teams for Linux)$
windowrulev2=workspace special:Discord silent ,initialTitle:^(Discord)$
windowrulev2=workspace special:OBS silent ,initialTitle:^OBS.*?$
windowrulev2=workspace special:OBS silent ,initialTitle:^Mumble.*?$
windowrulev2=float,class:^(org.wezfurlong.wezterm)$
windowrulev2=tile,class:^(org.wezfurlong.wezterm)$
windowrulev2=noshadow, floating:0
windowrulev2=opacity 0.0 override 0.0 override,class:^(xwaylandvideobridge)$
windowrulev2=noanim,class:^(xwaylandvideobridge)$
windowrulev2=nofocus,class:^(xwaylandvideobridge)$
windowrulev2=noinitialfocus,class:^(xwaylandvideobridge)$
windowrulev2=rounding 0, xwayland:1, floating:1
windowrulev2=keepaspectratio,class:^(firefox)$,title:^(Picture-in-Picture)$
windowrulev2=noborder,class:^(firefox)$,title:^(Picture-in-Picture)$
windowrulev2=fakefullscreen,class:^(firefox)$,title:^(Firefox)$
windowrulev2=fakefullscreen,class:^(firefox)$,title:^(Picture-in-Picture)$
windowrulev2=pin,class:^(firefox)$,title:^(Firefox)$
windowrulev2=pin,class:^(firefox)$,title:^(Picture-in-Picture)$
windowrulev2=float,class:^(firefox)$,title:^(Firefox)$
windowrulev2=float,class:^(firefox)$,title:^(Picture-in-Picture)$
windowrulev2=float,class:thunderbird,title:^(?!Mozilla*)

======Config-End========

Description
This bug was noticed by installing following extension  to Thunderbird.
This plugin opens a browser window in a popup to login, which unexpectedly closes immediately. This issue does not happen in e.g. KDE and seems to be related to setting some kind of window state.
I filed an issue there, and you can read on the debugging process if needed.
To make it easier for you, I summarized the findings:

The window disappears on when running the following line: https://github.com/mozilla/releases-comm-central/blob/2e0cd2b03bea7839120f79db06476733e964e5ae/mail/components/extensions/parent/ext-mail.js#L1551
The log from the IPC socket during the disapperance is:

urgent>>1e3cb1e0
closewindow>>1e3cb1e0

How to reproduce

Install Thunderbird
Run Thunderbird
Add ThunderAI from Mozilla Marketplace
Use it in any way to trigger the browser window popup to login.
Watch closely

Crash reports, logs, images, videos
https://github.com/user-attachments/assets/6d3f2a87-8015-48ce-9d1c-ab8dfb7d36f4

I posted this issue on the github for the ThunderAI extension: https://github.com/micz/ThunderAI/issues/137
The author implemented a workaround for the issue of the newly opened window closing immediately. I think there might still be an underlying issue.
Now there is a new issue with this extension. The popup menus it draws are being rendered without any contents. I have no other extensions running in Thunderbird.

Seems to be a thunderbird issue


DBZ-4537 Organize properties of Db2 connector

https://issues.redhat.com/browse/DBZ-4537

@ani-sha Good start! Could you please take a look at the following tasks that might need to be added?

[ ] Could you please check SqlServerConnectorConfig for cross-reference?
[ ] Please pay attention to excluding part
[ ] Also please check the config params definition there and add withGroup calls to DB2 connector config

Thanks a lot

@ani-sha, could you perhaps try and print out the entries of the ConfigDef before and after the change, so to see whether it's still the same?

@gunnarmorling I quite didn't follow. Should I list the fields here in the comments?

@ani-sha, what I am after is some validation that properties don't look different than before due to this change, which should be a refactoring purely. So you might print out the config defs before and after the change and compare them locally. You can share the output in a comment here, but if you say they are the same I trust you, so no need for strictly speaking. Alternatively, you could create a test which asserts the contents of the config def and which passes without modifications before and after this change.

@gunnarmorling Here is the list of fields
Before change: database.hostname, database.port, database.user, database.password, database.server.name, database.dbname, snapshot.mode, database.history.kafka.bootstrap.servers, database.history.kafka.topic, database.history.kafka.recovery.attempts, database.history.kafka.recovery.poll.interval.ms, database.history, table.whitelist, table.include.list, table.blacklist, table.exclude.list, column.blacklist, column.exclude.list, snapshot.select.statement.overrides, table.ignore.builtin, heartbeat.interval.ms, heartbeat.topics.prefix, source.struct.version, event.processing.failure.handling.mode, poll.interval.ms, max.batch.size, max.queue.size, snapshot.delay.ms, snapshot.fetch.size, decimal.handling.mode, time.precision.mode
After change: database.server.name, database.hostname, database.port, database.user, database.password, database.dbname, event.processing.failure.handling.mode, max.batch.size, max.queue.size, poll.interval.ms, max.queue.size.in.bytes, provide.transaction.metadata, skipped.operations, snapshot.delay.ms, snapshot.include.collection.list, snapshot.fetch.size, snapshot.max.threads, retriable.restart.connector.wait.ms, query.fetch.size, decimal.handling.mode, time.precision.mode, snapshot.lock.timeout.ms, snapshot.mode, binary.handling.mode, incremental.snapshot.chunk.size, incremental.snapshot.allow.schema.changes, database.history, database.history.skip.unparseable.ddl, database.history.store.only.monitored.tables.ddl, database.history.store.only.captured.tables.ddl, database.history.kafka.bootstrap.servers, database.history.kafka.topic, database.history.kafka.recovery.attempts, database.history.kafka.recovery.poll.interval.ms, converters, sanitize.field.names, tombstones.on.delete, source.struct.version, heartbeat.interval.ms, heartbeat.topics.prefix, signal.data.collection, transaction.topic, column.whitelist, column.include.list, column.blacklist, column.exclude.list, table.whitelist, table.include.list, table.blacklist, table.exclude.list, table.ignore.builtin, message.key.columns, snapshot.select.statement.overrides, column.mask.hash.([^.]+).with.salt.(.+), column.mask.with.(d+).chars, column.truncate.to.(d+).chars, include.schema.changes, include.schema.comments, column.propagate.source.type, datatype.propagate.source.type, internal.snapshot.scan.all.columns.force, heartbeat.action.query

Ok, any idea where those additional ones are coming from? There shouldn't be any change really.

This is the net diff
> binary.handling.mode
> column.include.list
> column.mask.hash.([^.]+).with.salt.(.+)
> column.mask.with.(d+).chars
> column.propagate.source.type
> column.truncate.to.(d+).chars
> column.whitelist
> converters
> database.history.skip.unparseable.ddl
> database.history.store.only.captured.tables.ddl
> database.history.store.only.monitored.tables.ddl
> datatype.propagate.source.type
> heartbeat.action.query
> include.schema.changes
> include.schema.comments
> incremental.snapshot.allow.schema.changes
> incremental.snapshot.chunk.size
> internal.snapshot.scan.all.columns.force
> max.queue.size.in.bytes
> message.key.columns
> provide.transaction.metadata
> query.fetch.size
> retriable.restart.connector.wait.ms
> sanitize.field.names
> signal.data.collection
> skipped.operations
> snapshot.include.collection.list
> snapshot.lock.timeout.ms
> snapshot.max.threads
> tombstones.on.delete
> transaction.topic

From my PoV the problem is that Db2 connector was most not kep up-to-date with new common configuration options.

Agree @jpechane, Since we have reused the HistorizedRelationalDatabaseConnectorConfig it explains the extra fields.

Ok, so that explains the difference, thanks. Next question then is, are all these additional fields actually supported for the Db2 connector, or do we have to exclude some. This entails two aspects:

Testing: ideally, there are tests for Db2 using each of the properties; it's not black-or-white, if we have good testing in core for framework features that's good too; but we must be reasonable sure that every exposed property actually works
Documentation: each exposed property must be documented for this connector (i.e. not the internal. ... and the deprecated such as whitelist ones)

@ani-sha, can you try and take the lead for this and verify we have testing and docs? If there's tests missing for something, please work with Jiri to decide what to do (have sufficient testing elsewhere and it's fine to expose that prop, or exclude it for now and log a Jira issue as a follow-up)?
To avoid scope creep, I'd suggest to exclude all props without reasonable testing for now and log a follow-up issue. If there is testing and only docs are missing, let's add those docs as part of this effort here.
Lastly, what is converters? This doesn't look like a property name we'd use?

@gunnarmorling See io.debezium.config.CommonConnectorConfig.CUSTOM_CONVERTERS

Ah, I see. So I suppose that'd fall into the "works but needs documentation" category?

IMHO it is documented only centrally - https://debezium.io/documentation/reference/1.8/development/converters.html#_configuring_and_using_converters

Yeah, and it should definitely be covered in the individual connector docs. So what should happen is this:

Add a section "Customizing type mappings" to the "Data type mappings" section of all the connector docs (as seems to be missing in general); this should spend a sentence a long the lines of "If the provided type mappings are not sufficient for your use case, you may consider implementing a custom type converter. See "link to the page on converters" to learn more about this.
Add the property to the table with all connector options, also linking to that central page

@jpechane @gunnarmorling Out of the extra fields, the following fields are supported by db2 as mentioned in the doc but were not mentioned previously.
> column.mask.hash.([^.]+).with.salt.(.+)
> column.mask.with.(d+).chars
> column.propagate.source.type
> column.truncate.to.(d+).chars
> datatype.propagate.source.type
> include.schema.changes
> incremental.snapshot.chunk.size
> max.queue.size.in.bytes
> message.key.columns
> provide.transaction.metadata
> sanitize.field.names
> signal.data.collection
> skipped.operations
> snapshot.lock.timeout.ms
> tombstones.on.delete
> transaction.topic

@ani-sha PLease see io.debezium.relational.RelationalDatabaseConnectorConfig.SNAPSHOT_FULL_COLUMN_SCAN_FORCE. It is an internal property so nothing to be documented.

the following fields are supported by db2 as mentioned in the doc but were not mentioned previously.

I don't quite make sense out of this. Not mentioned previously where?

I don't quite make sense out of this. Not mentioned previously where?

I mean it wasn't a part of the previously defined db2 config.

@gunnarmorling I have excluded the fields that are not mentioned in the docs/not supported now and will log an issue to test and add the excluded fields if needed. Does this work for now?

@ani-sha, ok, so the effectively exposed set of properties now is exactly the same as before? If so, yes that's fine for now. Just please log a follow-up issue with capturing the state of your investigation, i.e. documenting for each of the excluded properties what you know about (test missing, docs missing, both missing). Thx!

@ani-sha Applied, thanks a lot!

@jpechane, do we have that follow-up issue discussed above?

@gunnarmorling Yes, we do https://issues.redhat.com/browse/DBZ-4588


How can I set currency?

Hi
is there any way to set currency used, so far only dollars work and forcing a locale does not work.
is this the known issue and what would you recommend then for currency formatting.
We heavily use multiple currencies in our app, since it handles international billing and I would love to hear good suggestion. Yahoo's library does not support ReactNative
Thanks

Looking at https://github.com/fnando/i18n-js/blob/master/app/assets/javascripts/i18n.js#L616-L640
I think you can use unit option to set the currency displayed?

Have you set number.currency.format.unit? For me I18n.toCurrency(1000); gives "1 000,00 kr" as defined in my I18n locale.

@espen how do you set number.currency.format.unit?

Set it in your locale file @sospedra ? It's a default entry in the Rails i18n-files: https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/en.yml#L163

how we can set in React native ?

I know nothing about React native so I am afraid I can't provide anything specific to it
I can only say use unit option in I18n.toCurrency
https://github.com/fnando/i18n-js/blob/v3.6.0/app/assets/javascripts/i18n.js#L779-L785


make test fails on Mac OSX Yosemite

I was able to cmake, then make without issue.  When I ran "make test" I got the following:
[ 62%] Built target neural2d-core
[ 75%] Preparing images/digits/...
[100%] Built target neural2d
Creating layer input, one moment...
Creating layer layer1, one moment...
Creating layer output, one moment...
Checking for neurons with no sinks:
neuron(0x7fd9cb01a200) on input
5000 training samples initialized
Unsupported image file format in ../images/digits/test-6.bmp
libc++abi.dylib: terminating with uncaught exception of type NNet::exceptionInputSamplesFile: std::exception
make[3]: *** [CMakeFiles/test] Abort trap: 6
make[2]: *** [CMakeFiles/test.dir/all] Error 2
make[1]: *** [CMakeFiles/test.dir/rule] Error 2
make: *** [test] Error 2

Hi @bradfc, thanks for the report. This might be the first time someone has tried neural2d on a Mac.
That error message comes from neural2d-core.cpp at around line 195 when you try to input data from an unreadable image file. Double check that the file path "../images/digits/test-6.bmp" refers to a readable image file on your local hard drive relative to the path where the executable is run. If that file doesn't exist, then there may be a problem in the Makefile for the Mac. When you run "make test", the Makefile rules are supposed to automatically expand the archive images/digits/digits.zip and you should get a bunch of image files in the image/digits/ subdirectory. If that ZIP file did not get unzipped, then you may need to unzip it manually for now, and we may need to modify CMakeLists.txt, around line 87, to give it the correct command for unzipping a ZIP file on a Mac.
However, if the image file "../images/digits/test-6.bmp" is indeed there and if it is readable by your usual Mac image viewers, then there's some sort of Mac-specific issue in ImageReaderBMP::getData() in imageReaderBMP.cpp that causes it to return a zero size. In that case, you could use your favorite debugging techniques to see where it fails in getData(). Let us know what you find out.

David,
Thanks for your note.
The file in question is indeed there in the right place, and I can review it Mac Preview, along with adjacent test-5.bmp, etc., which have the same file size.
I haven’t had a lot of time to spend on this, but…
I put in a lot of cerr commands in imageReaderBMP.cpp for when getData returned {0,0}, but I got no output before the exception was thrown.  I then deleted all the bmp files in images/digits, and deleted test-6.bmp from the zip file, but when I ran test it repopulated the bmp files (presumably unpacked the zip file) and gave me the same error message (involving test-6.bmp), even though that file was no longer in the folder nor the zip file.  Out of time for now…
Brad

On Feb 28, 2017, at 3:13 PM, David R. Miller<EMAIL_ADDRESS>wrote:
Hi @bradfc https://github.com/bradfc, thanks for the report. This might be the first time someone has tried neural2d on a Mac.
That error message comes from neural2d-core.cpp at around line 195 when you try to input data from an unreadable image file. Double check that the file path "../images/digits/test-6.bmp" refers to a readable image file on your local hard drive relative to the path where the executable is run. If that file doesn't exist, then there may be a problem in the Makefile for the Mac. When you run "make test", the Makefile rules are supposed to automatically expand the archive images/digits/digits.zip and you should get a bunch of image files in the image/digits/ subdirectory. If that ZIP file did not get unzipped, then you may need to unzip it manually for now, and we may need to modify CMakeLists.txt, around line 87, to give it the correct command for unzipping a ZIP file on a Mac.
However, if the image file "../images/digits/test-6.bmp" is indeed there and if it is readable by your usual Mac image viewers, then there's some sort of Mac-specific issue in ImageReaderBMP::getData() in imageReaderBMP.cpp that causes it to return a zero size. In that case, you could use your favorite debugging techniques to see where it fails in getData(). Let us know what you find out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/davidrmiller/neural2d/issues/34#issuecomment-283148620, or mute the thread https://github.com/notifications/unsubscribe-auth/AY4nuO0SNwIRgRMFkkgMdKK-wsf6Aosbks5rhIAEgaJpZM4MOq4N.

addendum: make test appears to work on a Raspberry Pi running Debian (Jessie) Linux, haven’t tried anything else yet.

On Feb 28, 2017, at 3:13 PM, David R. Miller<EMAIL_ADDRESS>wrote:
Hi @bradfc https://github.com/bradfc, thanks for the report. This might be the first time someone has tried neural2d on a Mac.
That error message comes from neural2d-core.cpp at around line 195 when you try to input data from an unreadable image file. Double check that the file path "../images/digits/test-6.bmp" refers to a readable image file on your local hard drive relative to the path where the executable is run. If that file doesn't exist, then there may be a problem in the Makefile for the Mac. When you run "make test", the Makefile rules are supposed to automatically expand the archive images/digits/digits.zip and you should get a bunch of image files in the image/digits/ subdirectory. If that ZIP file did not get unzipped, then you may need to unzip it manually for now, and we may need to modify CMakeLists.txt, around line 87, to give it the correct command for unzipping a ZIP file on a Mac.
However, if the image file "../images/digits/test-6.bmp" is indeed there and if it is readable by your usual Mac image viewers, then there's some sort of Mac-specific issue in ImageReaderBMP::getData() in imageReaderBMP.cpp that causes it to return a zero size. In that case, you could use your favorite debugging techniques to see where it fails in getData(). Let us know what you find out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/davidrmiller/neural2d/issues/34#issuecomment-283148620, or mute the thread https://github.com/notifications/unsubscribe-auth/AY4nuO0SNwIRgRMFkkgMdKK-wsf6Aosbks5rhIAEgaJpZM4MOq4N.

It looks like the program can’t open the file (though it exists):
modified code in imageReaderBMP.cpp:
FILE* f = fopen(filename.c_str(), "rb");

if (f == NULL) {
  cerr << "NULL problem" << endl;
    return { 0, 0 };

I also put a cerr command to output the file name and the return output from imageReader.
**
run output:
Built target neural2d
Creating layer input, one moment...
Creating layer layer1, one moment...
Creating layer output, one moment...
Checking for neurons with no sinks:
neuron(0x7f85b2818000) on input
5000 training samples initialized
file: ../images/digits/test-6.bmp size: 0
NULL problem
file: ../images/digits/test-6.bmp size: 0
Unsupported image file format in ../images/digits/test-6.bmp
libc++abi.dylib: terminating with uncaught exception of type NNet::exceptionInputSamplesFile: std::exception
So
(1) For some reason test-6.bmp is the first file that the program attempts to open (not, say, test-1.bmp).
(2) The file open request fails.
I then removed test-6.bmp from the inputData.txt file, and the program now terminates at test-7.bmp.
By way of background…I’m a physicist, have good numerical programming experience with C++.  I have a good overview of what machine learning and deep learning do, but wanted to work through some programmed examples.  Many such packages are written in Python (such as TensorFlow), which would represent another learning curve for me.  Yours is one of the simplest packages I’ve found that allows one to build up networks one by one.  [There’s another one from Carnegie Mellon that relies upon a large number of other software packages that I would have to install.]  I have somewhat limited bandwidth for this but am hoping that I can get it to work on a Mac.
Best wishes,
Brad

Bradley D. Keister
Deputy Division Director
Physics Division, 1015N
National Science Foundation
4201 Wilson Blvd.
Arlington, VA  22230
703 292-7377
On Feb 28, 2017, at 3:13 PM, David R. Miller <notifications<EMAIL_ADDRESS>wrote:
Hi @bradfchttps://github.com/bradfc, thanks for the report. This might be the first time someone has tried neural2d on a Mac.
That error message comes from neural2d-core.cpp at around line 195 when you try to input data from an unreadable image file. Double check that the file path "../images/digits/test-6.bmp" refers to a readable image file on your local hard drive relative to the path where the executable is run. If that file doesn't exist, then there may be a problem in the Makefile for the Mac. When you run "make test", the Makefile rules are supposed to automatically expand the archive images/digits/digits.zip and you should get a bunch of image files in the image/digits/ subdirectory. If that ZIP file did not get unzipped, then you may need to unzip it manually for now, and we may need to modify CMakeLists.txt, around line 87, to give it the correct command for unzipping a ZIP file on a Mac.
However, if the image file "../images/digits/test-6.bmp" is indeed there and if it is readable by your usual Mac image viewers, then there's some sort of Mac-specific issue in ImageReaderBMP::getData() in imageReaderBMP.cpp that causes it to return a zero size. In that case, you could use your favorite debugging techniques to see where it fails in getData(). Let us know what you find out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/davidrmiller/neural2d/issues/34#issuecomment-283148620, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AY4nuO0SNwIRgRMFkkgMdKK-wsf6Aosbks5rhIAEgaJpZM4MOq4N.

I think there was some confusion in making the build.  I started from scratch per your site instructions, and the test works OK.
Sorry for my confusion…now time to learn something!
Brad

It looks like the program can’t open the file (though it exists):
modified code in imageReaderBMP.cpp:
FILE* f = fopen(filename.c_str(), "rb");

if (f == NULL) {
  cerr << "NULL problem" << endl;
    return { 0, 0 };

I also put a cerr command to output the file name and the return output from imageReader.
**
run output:
Built target neural2d
Creating layer input, one moment...
Creating layer layer1, one moment...
Creating layer output, one moment...
Checking for neurons with no sinks:
neuron(0x7f85b2818000) on input
5000 training samples initialized
file: ../images/digits/test-6.bmp size: 0
NULL problem
file: ../images/digits/test-6.bmp size: 0
Unsupported image file format in ../images/digits/test-6.bmp
libc++abi.dylib: terminating with uncaught exception of type NNet::exceptionInputSamplesFile: std::exception
So
(1) For some reason test-6.bmp is the first file that the program attempts to open (not, say, test-1.bmp).
(2) The file open request fails.
I then removed test-6.bmp from the inputData.txt file, and the program now terminates at test-7.bmp.
By way of background…I’m a physicist, have good numerical programming experience with C++.  I have a good overview of what machine learning and deep learning do, but wanted to work through some programmed examples.  Many such packages are written in Python (such as TensorFlow), which would represent another learning curve for me.  Yours is one of the simplest packages I’ve found that allows one to build up networks one by one.  [There’s another one from Carnegie Mellon that relies upon a large number of other software packages that I would have to install.]  I have somewhat limited bandwidth for this but am hoping that I can get it to work on a Mac.
Best wishes,
Brad

Bradley D. Keister
Deputy Division Director
Physics Division, 1015N
National Science Foundation
4201 Wilson Blvd.
Arlington, VA  22230
703 292-7377
On Feb 28, 2017, at 3:13 PM, David R. Miller <notifications<EMAIL_ADDRESS>wrote:
Hi @bradfchttps://github.com/bradfc, thanks for the report. This might be the first time someone has tried neural2d on a Mac.
That error message comes from neural2d-core.cpp at around line 195 when you try to input data from an unreadable image file. Double check that the file path "../images/digits/test-6.bmp" refers to a readable image file on your local hard drive relative to the path where the executable is run. If that file doesn't exist, then there may be a problem in the Makefile for the Mac. When you run "make test", the Makefile rules are supposed to automatically expand the archive images/digits/digits.zip and you should get a bunch of image files in the image/digits/ subdirectory. If that ZIP file did not get unzipped, then you may need to unzip it manually for now, and we may need to modify CMakeLists.txt, around line 87, to give it the correct command for unzipping a ZIP file on a Mac.
However, if the image file "../images/digits/test-6.bmp" is indeed there and if it is readable by your usual Mac image viewers, then there's some sort of Mac-specific issue in ImageReaderBMP::getData() in imageReaderBMP.cpp that causes it to return a zero size. In that case, you could use your favorite debugging techniques to see where it fails in getData(). Let us know what you find out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/davidrmiller/neural2d/issues/34#issuecomment-283148620, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AY4nuO0SNwIRgRMFkkgMdKK-wsf6Aosbks5rhIAEgaJpZM4MOq4N.

Congrats on getting it to work, and thanks for the report -- I'm glad we can now confirm that neural2d works on a Mac. Best of luck with the research.

David,
Sorry to bother you again,  but I’m having trouble getting the program to run with a simple example:
topology.txt:
input size 2x2
output size 2 from input
linear
inputData.txt
{1.0 0.0 0.0 -1.0} 0.0 1.0
{-1.0 0.0 0.0 1.0} 1.0 0.0
output:
Topology config has improperly connected layers. Check the from parameters
libc++abi.dylib: terminating with uncaught exception of type NNet::exceptionConfigFile: std::exception
Abort
I can’t see what’s improperly connected.  If I remove the ‘linear’ parameter, then the program hangs at
Creating layer input, one moment...
Creating layer output, one moment...
Checking for neurons with no sinks:
I’m sure I’m missing something basic.
Brad

On Mar 1, 2017, at 12:13 PM, David R. Miller<EMAIL_ADDRESS>wrote:
Congrats on getting it to work, and thanks for the report -- I'm glad we can now confirm that neural2d works on a Mac. Best of luck with the research.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/davidrmiller/neural2d/issues/34#issuecomment-283405201, or mute the thread https://github.com/notifications/unsubscribe-auth/AY4nuOOksrJzH4qklkwrk-wVAnAyiJWlks5rhaczgaJpZM4MOq4N.

So close -- if you use the optional parameter "tf linear", it goes on the same line, e.g.:
input size 2x2
output size 2 from input tf linear
And I think you've just exposed a bug in the program. The program fails for me too using your exact inputData.txt file, but it works for me if I insert a space between the digits and the curly braces, e.g.:
{ 1.0 0.0 0.0 -1.0 } 0.0 1.0
{ -1.0 0.0 0.0 1.0 } 1.0 0.0
The program shouldn't be that picky about whitespace, so I'll look into improving that. Thanks for reporting this.


backport of #1580 to stable 3815

backport of #1580 to stable 3815
In January Kai fixed a bug in handling Omaha responses with self-hosted packages (sysexts) in an airgapped environment (#1580) but the fix was tied to ue-rs which isn't in stable yet. The same bug exists in stable and prevents clients in such environments from updating to 3815. Backport a fix to this issue in the non-ue-rs flatcar-postinst script.
The fix is in https://github.com/flatcar/update_engine/pull/39.
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

[x] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
[ ] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Build testing here: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/3524/cldsv/

Build was green


Release 1.8: prepare the release notes and upgrade notes

Later on, I will update the release notes with the command
GITHUB_TOKEN=$(lpass show -p github.com) START_SHA="$(git rev-list --reverse --ancestry-path $(git merge-base v1.7.0 master)..master | head -1)" END_REV="master" BRANCH="master" RELEASE_VERSION="1.8.0" release-notes --repo-path=cert-manager --org=cert-manager --repo=cert-manager --required-author=jetstack-bot --output /tmp/release-notes-1.8.0.md

The reason I am doing this so early is that I wish to review each changelog entry "from the start" and as early as possible, instead of doing it at the last moment.
If I need to reformulate one of the changelog entries, I usually also update the release-note block in the original PR description. It is not the best workflow, but at least any subsequent run of release-note will pick up the changes.

Note: I created a branch on cert-manager/website instead of on my fork. 😬 My apologies!

/assign @SgtCoDFish

I've rebased this onto the current release-next branch, removing the mistaken commits from this PR and leaving this clean. To do so I gave myself temporary access to forcepush to this branch, then removed it again afterwards.

It's worth noting that if the website refresh goes in before 1.8, this PR won't be usable as-is, and in fact we'll need to be careful with how we handle release-next more generally post-refresh. That's not really a topic for this PR, more of a heads up that things will change!

Closing in favor of https://github.com/cert-manager/website/pull/878 (I could not force push since I had created the branch on cert-manager/website)


Composite primary keys not yet implemented?

1:n example from docs/relations.md mentions how to map composite primary keys:
model User {
  first_name  String  @id
  last_name   String

  @@id([ first_name, last_name ])
}

model Post {
  id         Int @id
  author     User
}

prisma2 lift save -n init results in:
Error:
error: Attribute not known: "@id".
  -->  datamodel file, line:66
   |
65 |
66 |   @@id([ first_name, last_name ])
67 | }
   |

Is this already implemented? Couldn't find any related issues.
Versions: 2.0.0-preview-9.1, 2.0.0-preview-10

This hasn't been implemented yet. It will get implemented over the coming weeks.

This should be fixed in docs then, only spec should contain future functionality.


How to listen for the 'submit' event or implement handleSubmit?

Howdy - I have been unable to figure out how to finish using the library.
I can get the form to show up and listen to the change event.   The example shows a handleSubmit function being passed to ng-submit but I can't seem to set it up right.    I try passing arguments to it, but it doesn't really give me anything.
Reading the stripe documentation, it says I am supposed to set up a listener for the submit event, but that doesn't seem to "catch'.  https://stripe.com/docs/stripe-js/elements/quickstart
For example:
	element.on('submit', handleSubmit);
	function handleSubmit(e) {
		console.log(e);
	}

The event doesn't seem to show in the console.
Then doing this doesn't seem to yield the 'card' element.
	ctrl.handleSubmit = function($event) {
		console.log(ctrl.element);
	};

Any help would be greatly appreciated, thank you!

Hi Taylor!
I'm not sure I have all the information necessary to be able to help you.
Is there any way you could share more of your app's code?
In the meantime, I suggest you check out the example folder in this repository and compare it with your code to make sure there's nothing missing.
Let me know!


Show a dialog if WebGPU isn't available or there's an error

This won't catch JS exceptions in the middle of the actual sample, but it at least shows a nice message when WebGPU is not available for some reason, or there's a validation error (usually because the browser doesn't support the sample).
I would like to catch JS exceptions but it would be a bit more complicated. Thinking of just registering an onunhandledrejection handler and wrapping each sample in a (async () => { ... })() but that's a bit silly.
Anyway what do you think of this - is the DOM stuff too heavy handed for a sample util?

I'm not against this but my gut says this seems further from showing WebGPU?
What about something like
const adapter = await navigator.gpu?.requestAdapter();
const device = await adapter?.requestDevice();
if (!device) {
  showWebGPUIssues(adapter, device);  // from util.ts
}

Then the code shows more straight forward WebGPU in the example. You can still check if navigator.gpu is null, and/or if adapter was null, and/or if device was null or lost in showWebGPUIssues
That won't handle the case when asking for limits, features though.

100% agree, I had some similar thoughts in the evening after I posted this. I think I can come up with something but it will have to wait a little bit.

Finally revised this - PTAL

does it need a button?
The user clicks 'OK' for what purpose? I'm not saying to remove the button. Maybe the fact that it has one makes them more likely to read the message.

Not really, but sometimes there will be an error yet the sample keeps working - for example the reversedZ sample does this in Firefox right now. Also if some error comes up in an interactive demo like samplerParameters, it could be useful to dismiss it and change the settings back to the mode that didn't have an error.

not getting an adapter doesn't technically mean WebGPU is not available on this system. Compat for example, and in the future fl2. I can't think of a simple message though it's probably best as is.

Good point, I'll tweak it a little.


Suricata

Operating System Version: Windows 10
Provider (VirtualBox/VMWare): Virtualbox
Vagrant Version: 2.2.2

Description of the issue:
When running any sort of attack on the environment, suricata is receiving no logs in fast.logs, http.log, tls.log. I am mostly concerned with fast.log. Here is what my fast.log looks like --

If there is any other logs I can get you please let me know and thank you in advance! You have put alot of time in this lab and I greatly appreciate it!

Hey @jsecurity101 - not sure I fully understand the issue. eve.json contains json formatted alerts, and I ran curl testmyids.com on the logger host and see this alert:
root@logger:/var/log/suricata# tail -1 fast.log
02/01/2019-07:49:35.688758  [**] [1:2100498:7] GPL ATTACK_RESPONSE id check returned root [**] [Classification: Potentially Bad Traffic] [Priority: 2] {TCP} <IP_ADDRESS>:80 -> <IP_ADDRESS>:41612

I'm going to mark this as closed because I don't think there's an actual problem here, but feel free to re-open if I'm misunderstanding something.


job_id is null when using matrix strategy

This action works perfectly well when we have a single workflow. However, when I try to use this action with matrix strategy to kick off a workflow, the job_id ends up null.
   strategy:       fail-fast: false       max-parallel: 1       matrix:          var: [values]       uses: other workflow.yml

How about specifying job_name like job_name: build-and-deploy (${{ matrix.ros-distro }}, ${{ matrix.arch }})?
https://github.com/Tiryoh/docker-ros2-desktop-vnc/blob/8115cc026c9123c7c98c5e50207c8d60905c1775/.github/workflows/deploy.yml#L99-L104
job_name must be named the same as the list of jobs in the actions summary page.

Feel free to re-open this issue when you have any updates.


Skip button doesn't appear

I'm trying to setup a linear vast (preroll) video. It works fine overall, but I can't manage to activate the (default) skip button. It just doesn't show up, not even with display:none.
"#skip_button_" is just not there.
To find the error I even put a console.log() into the "addSkipButton" function (within fluidplayer.js) to see wether its called, but it isn't.
These are my options...
	{
	autoPlay:           true,
	mute: 				true,
	keyboardControl: 	false,
	preload: 			true,
	primaryColor: "#28B8ED",
	controlBar: {
			autoHide: true, // Default false
			autoHideTimeout: 2, // Default 3
			animated: true // Default true
		}
	},
vastOptions:
	{
		adText: 'Werbung',
		adList :	[{	roll: 'preRoll', vastTag: vast	}],
		skipButtonCaption: 'Wait [seconds] more second(s)',
		skipButtonClickCaption: 'Watch main video '
	}

Due to the fact that the skip button is default, it should show up, right?
What am I doing wrong? o.O

Can be closed, if I'm the only one with the issue.
Surprisingly I did not need the feature for my purpose.


Update linter to check if file exists before trying to lint it.

What caused this?

not sure if this is still an issue, closing for now.


Can this support Bluetooth 4.2 version?

Hi there, I was wondering can noble support up to bluetooth 4.2 version? I am using my internal built-in bluetooth inside my laptop but I could not get it working. It is keeping loading and no responding at all when I run node index.js or node test.js. Please help.

@gyloh9210 should be fine, I suggest you try one of the examples in the examples folder.

@sandeepmistry I am actually trying to get it working with Raspberry PI 3 Model B+ which by default is now 4.2.  My code works fine with 4.0 Bluetooth but when we try on 4.2 it doesn't work


Add attributes to headers and query parameters in RAML

The following attributes are not being used to generate RAML:
enum
pattern
minLength
maxLength
minimum
maximum
repeat
default
This is because apidescriptor class may not have these values, but it would be worth looking into to see if we can pull these values from another source, XML documentation, reflection, attributes or otherwise.  See how we can accomplish this.

this also applies to uri parameters

Weird, query string parameters and uri parameters in Web API help pages are the same.


laser_mapper.launch file not working

Hi all,
i am trying to  roslaunch laser_mapper.launch
[laser_mapper-2] restarting process
process[laser_mapper-2]: started with pid [4741]
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1108 15:35:18.640985  4741 segmatch.cpp:18] Do not forget to initialize SegMatch.
F1108 15:35:18.656913  4741 common.hpp:133] Check failed: loop_closure_noise_model.size() == kNoiseModelDimension (0 vs. 6)
*** Check failure stack trace: ***
[laser_mapper-2] process has died [pid 4741, exit code -6, cmd /home/t450-14/aaa_ws/devel/lib/laser_mapper/laser_mapper_node __name:=laser_mapper __log:=/home/t450-14/.ros/log/5de4a75c-c457-11e7-87e0-1002b5e35684/laser_mapper-2.log].
log file: /home/t450-14/.ros/log/5de4a75c-c457-11e7-87e0-1002b5e35684/laser_mapper-2*.log
Thanks in advance.

Hi @ytgcljj It looks like the parameters (in the .yaml file) did not load properly. I would recommend that you have a look at the demonstrations page
What you can try to run is: $ roslaunch laser_mapper kitti_localization.launch

thank you rdube
I'm downloading the BAG file and trying again ，The following mistakes are reported
I1108 17:54:34.732282 16121 common.hpp:135] Loading cloud: /home/t450-14/aaa_ws/src/segmatch/laser_mapper/demonstration_files/kitti/drive27_target_map.pcd.
[player-4] process has died [pid 16122, exit code 1, cmd /opt/ros/indigo/lib/rosbag/play -r 1 -s 333 --clock --pause /home/t450-14/aaa_ws/src/segmatch/laser_mapper/demonstration_files/kitti/2011_10_03_drive_27.bag __name:=player __log:=/home/t450-14/.ros/log/d298adc4-c46a-11e7-86c4-507b9de082e4/player-4.log].
log file: /home/t450-14/.ros/log/d298adc4-c46a-11e7-86c4-507b9de082e4/player-4*.log

thank you rdube
i can run roslaunch laser_mapper kitti_localization.launch but do not run  roslaunch laser_mapper.launch
t450-14@t45014-ThinkPad-T450:~/aaa_ws/src/segmatch/laser_mapper/launch$ roslaunch laser_mapper.launch
... logging to /home/t450-14/.ros/log/6ae0c770-c4ec-11e7-9247-507b9de082e4/roslaunch-t45014-ThinkPad-T450-18624.log
Checking log directory for disk usage. This may take awhile.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.
started roslaunch server http://t45014-ThinkPad-T450:43402/
SUMMARY
PARAMETERS

/laser_mapper/icp_configuration_file: /home/t450-14/aaa...
/laser_mapper/icp_input_filters_file: /home/t450-14/aaa...
/rosdistro: indigo
/rosversion: 1.11.21

NODES
/
laser_mapper (laser_mapper/laser_mapper_node)
auto-starting new master
process[master]: started with pid [18636]
ROS_MASTER_URI=http://localhost:11311
setting /run_id to 6ae0c770-c4ec-11e7-9247-507b9de082e4
process[rosout-1]: started with pid [18649]
started core service [/rosout]
process[laser_mapper-2]: started with pid [18653]
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1109 09:22:15.089155 18653 segmatch.cpp:18] Do not forget to initialize SegMatch.
F1109 09:22:15.105399 18653 common.hpp:133] Check failed: loop_closure_noise_model.size() == kNoiseModelDimension (0 vs. 6)
*** Check failure stack trace: ***
[laser_mapper-2] process has died [pid 18653, exit code -6, cmd /home/t450-14/aaa_ws/devel/lib/laser_mapper/laser_mapper_node __name:=laser_mapper __log:=/home/t450-14/.ros/log/6ae0c770-c4ec-11e7-9247-507b9de082e4/laser_mapper-2.log].
log file: /home/t450-14/.ros/log/6ae0c770-c4ec-11e7-9247-507b9de082e4/laser_mapper-2*.log
[laser_mapper-2] restarting process
process[laser_mapper-2]: started with pid [18706]
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1109 09:22:15.460724 18706 segmatch.cpp:18] Do not forget to initialize SegMatch.
F1109 09:22:15.480417 18706 common.hpp:133] Check failed: loop_closure_noise_model.size() == kNoiseModelDimension (0 vs. 6)
*** Check failure stack trace: ***
[laser_mapper-2] process has died [pid 18706, exit code -6, cmd /home/t450-14/aaa_ws/devel/lib/laser_mapper/laser_mapper_node __name:=laser_mapper __log:=/home/t450-14/.ros/log/6ae0c770-c4ec-11e7-9247-507b9de082e4/laser_mapper-2.log].
log file: /home/t450-14/.ros/log/6ae0c770-c4ec-11e7-9247-507b9de082e4/laser_mapper-2*.log

@ytgcljj you cannot solely launch laser_mapper.launch as information will be missing. Take a look at what is inside kitti_localization.launch to see what needs to be launched & loaded. I will look at the other issue mentioned above.

@ytgcljj did you get the demo running with $ roslaunch laser_mapper kitti_localization.launch ?

@rdube i run the demo with $ roslaunch laser_mapper kitti_localization.launch  is OK

i run roslaunch laser_mapper.launch。Do you need to turn on the lidar?

@ytgcljj it is not sufficient to launch only laser_mapper.launch. You need to launch either kitti_localization.launch or kitti_loop_closure.launch which will play the bag, load parameters, launch the mapper and more. See where the mapper is launched here:
https://github.com/ethz-asl/segmatch/blob/master/laser_mapper/launch/kitti/kitti_localization.launch#L35
If this is not clear I would recommend looking into the ros tutorials, particularly the following one, section 2.2:
http://wiki.ros.org/ROS/Tutorials/UsingRqtconsoleRoslaunch

@ytgcljj I will assume that the use of kitti_loop_closure.launch is clear by now and will close this issue.


 This extension provides a convenient and accessible way to enjoy Pac-Man without needing to visit external websites or download additional software. The extension will be available for installation from the Chrome Web Store.
Fixes:  #498
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[ ] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@thevijayshankersharma it's cool but there is one suggestion when Game Over or User Won the Game there is no Play Again Button. Please also add that Play Again Button when Game Ends.

Should I raise another issue after merging it ??

@thevijayshankersharma No,
Firstly raise an Issue and then here mention a issue no. Which you fixes that's it. If that will work properly then we will merge it.


Road map for 1.0.0 release.

If there is anything you want to implement before the 1.0.0 release, please add it!
General

[ ] No breaking change for the code (needs more unit test)

New Rule

adding rule [use-unit-value]

Props Order

[ ] https://github.com/Monchi/eslint-plugin-chakra-ui/issues/15
[ ] Reserved props

Props Shorthand

[ ] #17

@no-yan Could you create a detailed issue for use-unit-value? You mean prefer m="4" instead of m="1rem"?


exceed the token limitation: This model's maximum context length is 32768 tokens

An error occurred: Error code: 400 - {'object': 'error', 'message': "This model's maximum context length is 32768 tokens. However, you requested 32796 tokens in the messages, Please reduce the length of the messages.", 'type': 'BadRequestError', 'param': None, 'code': 400}
i was using lightrag_openai_compatible_demo.py

model: vllm qwen2.5:3b
embedding: bge-m3
dont known why ? anyone help ?

finally, i fix it with


ISSUE-928 Integrate Travis CI as Streamline's CI

This closes #928
Please refer https://travis-ci.org/HeartSaVioR/streamline/builds/276819474 to see the build result.
I've seen an intermittent failure from Travis CI build but addressing that looks like out of topic and we can see how many it is occurring and fix that.
At least one of us needs administrator privileges to enable Travis CI on this repo.

+1


Restore the missing initrd artifact.

This reverts only the path-related changes in b3a9893.

mmm, the test failure seems to be in the kernel headers tests - I'l have to poke around a little

I thought that was odd, so I set up my own Drone instance to see if I could reproduce it. I can't get the tests to run successfully to completion, with or without this change, so it must be related to my environment. :(

looks to me like its a docker pull timeout issue - I get it passing by changing the sleep 15to sleep 60 :(


upgrade-assistant: init at 0.5.820

Things done
https://github.com/dotnet/upgrade-assistant

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352011

x86_64-linux

:white_check_mark: 1 package built:

upgrade-assistant

aarch64-linux

:white_check_mark: 1 package built:

upgrade-assistant

x86_64-darwin

:white_check_mark: 1 package built:

upgrade-assistant

aarch64-darwin

:white_check_mark: 1 package built:

upgrade-assistant


NoMethodError on import

Hyrax 3 and bulkrax-fc06a85ead75 show NoMethodError on imports.  Here is a screen grab of the error from sidekiq.

It doesn't seem to affect the content imported.

I have additional information on this.  It is documented in zizia issue #75.  This problem is caused by a bulkrax importer somehow calling a zizia method FileSetAttachedJobPrepends::action and causing an error here.  Because this method expects a deduplication_key and bulkrax does not use them, it causes this error.
Even though the content seems to be imported correctly, this causes lots of jobs to be queued up and retried due to this error.  This slows things down and uses up precious resources.  I don't know if there any other adverse consequences.


Implement fee schedule selection for transactions on Ethereum

This is a feature request to let the user choose the transaction "processing speed" (fee level, really) for ETH and Ethereum-based token transactions, as already implemented for BTC.
Thank you so much for this unique wallet!

Thank you for the request, this is on our roadmap for a future version.

In 4.4.4, the fee selector was added for ETH and ERC20 transfers in the same way as Bitcoin.

Wonderful, thank you a lot! May I ask what service you use for gas price estimations?


Test that multipart resource indicator of the leader becomes a space if it is invalid

Acceptance criteria:

[ ] Modify marc_with_invalid_leader.xml fixture object to have an invalid value in position 19 of the leader
[ ] Write a test demonstrating that after leaderfix is executed on this fixture record, position 19 has become a space character

See https://www.loc.gov/marc/bibliographic/bdleader.html

Closed by #54.


Intellisense very slow with Jedi

I found some duplicates but most of them are closed with no suitable solution.
The only solution I found was to switch the Server Language from Jedi to Microsoft, which is not a suitable solution.
I also tried "python.analysis.cachingLevel": "Library" without success.
Environment data

VS Code version: 1.48.2
Extension version (available under the Extensions sidebar): 2020.8.106424
OS and version: OSX 10.15.4 (MBP 13" 2016)
Python version (& distribution if applicable, e.g. Anaconda): 3.7.2 64-bit
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: All heavy ones (pandas, numpy, etc.) but also simple ones
Relevant/affected Python-related VS Code extensions and their versions: N/A
Value of the python.languageServer setting: Jedi

Expected behaviour
Few ms to load tooltip.
Actual behaviour
Few seconds to load tooltip (> 5 seconds)
Steps to reproduce:
import pandas as pd
pd.

Jedi is slow with large codebases too on VS Code. But it works almost perfectly on Vim on the same (large) codebase.

#11995 Should help with Jedi performance.
As for Microsoft Language server substitute, can you try pylance? It is a performant language server, which likely solves these issues you are reporting. You can download Pylance from the marketplace and install it alongside the core Python extension. Because our team's development efforts have shifted to support the new language server, we'd encourage you to try it out.

I'm not sure to understand the solution given by #11995. Could you be more specific please?
I've checked pylance before submitting this issue but like I said it's not a suitable solution to switch from jedi to microsoft or pylance.
Also tbh I don't really like the decision of making it as a closed source, and the reviews are not very good.
I'll give it a chance if I don't find any suitable solution for Intellisense with Jedi and in a few more months.

@alcpereira #11995 is something that we (python extension) need to do to improve jedi's performance. Currently we consume jedi in the extension in a way that is not ideal (use old APIs). So We do plan on changing the approach, and that should improve this case.

Thanks, it is clear now. So I guess this should stay open and use an alternative (like microsoft or pylance) until #11995 is done?

@alcpereira That is correct.

Same problem.
Microsoft seems to work for me though.


Path consistency for custom cards

Version of HACS
0.12.1
Describe the bug
Path for custom Cards is not consistent, its displaying "community-plugins" for path to add to the configuration, but is actually just "community"

This is not correct.
/community_plugin/ is the correct endpoint for this.

uhm... for me it installed to www/community/XY
anyway, if its community_plugin, then the text above should be changed

No, you are mixing to different things.
The location on the filesystem is www/community/, but the URL (endpoint you use) is /community_plugins/

ohhhhhh now i see, my cache did hold the old versions, therefore it didnt fail for me after reinstalling. okay, sry, then everything is fine :) nice work! thx


Request: No limit to abilities in Creative Mode

Basically, I don't want to have rejection or loss of life in Creative Mode with this.

Essence is still present in Creative Mode, but you won't die or lose health or anything. None of the damage done by the mod is effective in creative.

Is there any creative behavior currently that you'd like changed? Otherwise I'll close this.

Now that I think of it, there should be an infinite Essence if you have a Creative Capacitor installed, even if in Survival Mode.


Fix the annoying vulnerability Github report about spring-core

So, Simple Java Mail doesn't actually do anything with Spring, except for playing nice with a range of versions by being able to translate Spring-read properties to Simple Java Mail configuration. It is also an optional dependency, so users don't have to use Spring at all.
As it is an optional dependency, it is not pulled in transitively by other projects. This in turn means other projects are free to use any version of Spring. The solution then is simple: simply upgrade the optional dependency version from 4.3.11.RELEASE to 4.3.18.RELEASE.

Released in 5.0.8.


Secure read failed. Cloud logging error

GaxError: GaxError(RPC failed, caused by <_Rendezvous of RPC that terminated with (StatusCode.UNAVAILABLE, {"created":"@1483127097.850480734","description":"Secure read failed","file":"src/core/lib/security/transport/secure_endpoint.c","file_line":157,"grpc_status":14,"referenced_errors":[{"created":"@1483127097.850427988","description":"EOF","file":"src/core/lib/iomgr/tcp_posix.c","file_line":235}]})>)

Probably similar to this: https://github.com/grpc/grpc/issues/7804

What language is this?

Fixed by #11154


Implementing threaddump endpoint

The PR implements the /management/threadump endpoint in order to match the JHipster upstream metrics pages.
It permits to not maintain a custom implementation of the metric pages

LGTM

LGTM


securityContext is not applied when runAsRoot is set to true

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Hi,
When deploying Istio GW using the runAsRoot=true , no securityContext is applied at all. Is there any reason to keep whole securityContext block out of the container? What are the parameters in the securityContext that can be set even though we want Istio GW to run with "runAsRoot=true" option?
Version
client version: 1.17.2
control plane version: 1.18-dev
data plane version: 1.18.3 (3 proxies)

Additional Information
No response

I use the customized version of Gateway's Helm Chart and take the securityContext out of the {{- if not .Values.runAsRoot }}{{- end}} block in the container level.
So it became
containers:
    - name: istio-proxy
  ...
      securityContext:
        allowPrivilegeEscalation: false
        capabilities:
          drop:
          - ALL
        privileged: false
        readOnlyRootFilesystem: true
        runAsNonRoot: true

instead of
containers:
    - name: istio-proxy
  ...
      {{- if not .Values.runAsRoot }}
      securityContext:
        allowPrivilegeEscalation: false
        capabilities:
          drop:
          - ALL
        privileged: false
        readOnlyRootFilesystem: true
        runAsNonRoot: true
     {{- end }}

Then I have created a values file that will modify the ServiceMesh Gateway target ports to the ports below 1024 and added one more port 88 just to test it:
gateways:
  istio-ingressgateway:
    name: istio-ingressgateway
    labels:
      app: istio-ingressgateway
      istio: ingressgateway
    ports:
    ## You can add custom gateway ports in user values overrides, but it must include those ports since helm replaces.
    # Note that AWS ELB will by default perform health checks on the first port
    # on this list. Setting this to the health check port will ensure that health
    # checks always work. https://github.com/istio/istio/issues/12503
    - port: 15021
      targetPort: 15021
      name: status-port
      protocol: TCP
    - port: 80
      targetPort: 80
      name: http2
      protocol: TCP
    - port: 443
      targetPort: 443
      name: https
      protocol: TCP
   - port: 88
      targetPort: 88
      name: http
      protocol: TCP

After that, I deployed istio with "runAsRoot=true" , run an httpbin service inside mesh and applied following Gateway and VirtualService resources
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: httpbin-gateway
spec:
  selector:
    istio: ingressgateway # use istio default ingress gateway
  servers:
  - port:
      number: 443
      name: https
      protocol: HTTPS
    tls:
      mode: SIMPLE
      credentialName: httpbin-credential # must be the same as secret
    hosts:
    - "*"
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: httpbin
spec:
  hosts:
  - "*"
  gateways:
  - httpbin-gateway
  http:
  - route:
    - destination:
        port:
          number: 80
        host: httpbin

When I send curl request to the ingress gateway I can get reply.
So applying securityContext did not change any functionality when running GW with "runAsRoot=true" mode, although I was expecting it the gateway either crash or does not send the traffic. Because now gateway binds envoy process to the port 443, which is below 1024.
So my question is that this has been resolved in some envoy (or istio?) changes at some point? Or is it possible that it is an environment problem?


BUGFIX: fixed pnetcdf issues

Fixes #647.
Several fixes needed to get pnetcdf build working. @DennisHeimbigner please glance at the code and tell me if you think it is correct WRT the options_maskp argument. (I surmise that you took that out of the parameters and now pass it in with params in the HDF4 code?)
Also had to add the new nc_def_var_filter() function to the dispatch table for pnetcdf.
@WardF please make this PR a priority since my pnetcdf CI build will be broken until this is merged. I believe there is no other pnetcdf CI build at the moment.

Mine is also broken...

With respect to NOTNC4 stuff, you can look at the corresponding
code in libsrc to get an idea of how to handle it. I added a change
to deal with the parameters for NCP_inq_var_all.

@gsjaardema do you use pnetcdf through netCDF? Or do you use pnetcdf directly?

I use it through NetCDF


PHOENIX-6538 4.x builds broken for HBase 1.3 profile

LGTM
Thanks for fixing it Istvan.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
18m 12s
4.x passed

+1 :green_heart:
compile
1m 48s
4.x passed

+1 :green_heart:
javadoc
1m  5s
4.x passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
9m 44s
the patch passed

+1 :green_heart:
compile
1m 45s
the patch passed

+1 :green_heart:
javac
1m 45s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m  3s
the patch passed

_ Other Tests _

-1 :x:
unit
149m 24s
root in the patch failed.

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

189m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1296/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1296

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux 45781aa2de7e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / b8af202

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1296/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1296/1/testReport/

Max. process+thread count
5749 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1296/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


On release version grammarly.login returns an error

I am running latest version of code and release version of the Grammarly extension.  When I run grammarly.login I see the browser open, verify that I am logged in, and click to link.  This error appears in code:
https://developer.grammarly.com/docs/error-explainer?code=8&args=vscodium%3A%2F%2Fznck.grammarly%2Fauth%2Fcallback%3FwindowId%3D1&trace=Error%0A++++at+https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A60282%0A++++at+Generator.next+%28%3Canonymous%3E%29%0A++++at+bt+%28https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A26642%29%0A++++at+o+%28https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A26846%29%0A++++at+https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A26907%0A++++at+new+Promise+%28%3Canonymous%3E%29%0A++++at+https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A26786%0A++++at+https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A90543%0A++++at+t.SDK.handleOAuthCallback+%28https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A90565%29%0A++++at+%2Fhome%2Fdroscigno%2F.vscode-oss%2Fextensions%2Fznck.grammarly-0.22.1-universal%2Fdist%2Fserver%2Findex.nod...

Reverting back to the pre-release version allows me to connect my Grammarly account.

+1

+2

same here

3

This is also happening with the pre-release version

For anyone looking... changing the extension to the pre-release version and refreshing the VSCode windows (Quit and restart VSCode also works) makes the login to work


Add pre-commit for easier development

Use pre-commit to check for common problems before committing.

added in #18


Block account linkedin

I used it for 1 week and linkedin added a notification notice,
warning that it was not to use these types of automation mechanics, is there a more invisible way to do this?

When you say:

I used it for 1 week

how exactly were you using it during that week? Using it to pull your own profile's data? Or repeatedly using it download data from other people's profiles? Did you use it just a few times, or hundreds?
To be clear, this tool is meant for personal use, to export your own profile, not as a general purpose data scraper or profile harvester.
And even if I was unscrupulous, to answer your question, no, there is not really a more "invisible" way to do this.


chore: unnecessary use of fmt.Sprintf

What this PR does:
remove unnecessary use of fmt.Sprintf
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #592 (d0533b9) into master (367e2dd) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   37.08%   37.08%
=======================================
  Files         172      172
  Lines       11616    11616
=======================================
  Hits         4308     4308
  Misses       6944     6944
  Partials      364      364


Allow adding labels to environment namespace

When testing SinkBinding, we need to make sure to include the label bindings.knative.dev/include: true so that the test works in both inclusion and exclusion selection mode.
https://knative.dev/docs/eventing/custom-event-source/sinkbinding/create-a-sinkbinding/#optional-choose-sinkbinding-namespace-selection-behavior

/cc @mgencur @maschmid


error when add new relay: ex infura

hey,
is there any way to change the relay to my local node or infura?

getting error wss://mainnet.infura.io/socket.io/?EIO=3&transport=websocket when i add relay url: https://mainnet.infura.io
thanks

This setting is for configuring Loopring relay url， not the ethnode address.
For now, Only Loopring Foundation runs relay that you saw in the default config.

if i run my geth node, then i start websockets it should work right?

No, it does not work.  Loopring Relay NOT equal eth node. Please take a look at http://loopring.org/documents.html  for a reference.


Spelling

This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/spark-on-k8s-operator/commit/e647fad39f81bdcf6d78584eb0382f554ac74866#commitcomment-49714646
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/spark-on-k8s-operator/commit/fd4491d57de99355c86d8784a28180965e8c6294

Thanks for fixing those!


SMTP USERNAME ERROR

To Use GMAIL SMTP email while adding username as email id its give error that " The SMTP USERNAME field cannot contain invalid characters."

Error fixed. Just make a copy of the repository again.


feat(gh-actions): add workflows & semantic release conventions

Signed-off-by: AmitKumarDas<EMAIL_ADDRESS>

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Eval results for kitti

Sir, thank you for excellent work!
I am not able to get results for kitti, what can be a reson.
Thank You in advance

I had encountered the same problem, please check.
Thank you for your help.

I also encountered the same problem, and I am not sure if this is related to the directory structure of the dataset.
 Thanks♪(･ ω･) ﾉ

@justbuyyal @Arunsuchi
Hi, I just encountered this problem, but I have solved it.
There is an error in the directory structure of the dataset. In addition to the depth annotation files provided in bts, we also need raw files. Specifically, after decompressing the raw file, merge the annotated files into it, and the final directory structure contains five date named folders.
Please don't hesitate to let me know if it is not resolved.


Bug fix. Can not get TNS alias

DBCE, Oracle. Can not get TNS alias in feature "Execute in SQL*Plus".
C:\program\oracleIC\instantclient_19_6\sqlplus.exe test/test@null
Task 'Oracle SQL*Plus script' started at Wed Jun 16 11:18:47 CST 2021
SQL*Plus: Release <IP_ADDRESS>.0 - Production on Wed Jun 16 11:18:47 2021
Version <IP_ADDRESS>.0
Copyright (c) 1982, 2019, Oracle.  All rights reserved.
ERROR:
ORA-12154: TNS:could not resolve the connect identifier specified

Thanks for the fix 👍
Probably it will be included in version 21.1.3 after test.

Verified


Fix ssw-py issues

Hi @rawagiha
Thank you for the indelpost---really nice piece of software!
We are extensively using indelpost in our pharmacogenomics suite Aldy. However, we have received lots of bug reports regarding the ssw-py dependency. ssw-py is quite hard to install, does not support newer Python versions, and is not compatible with ARM/M1 machines.
Here I integrated ssw-py directly into the indelpost tree and cleaned up various build issues with. ARM/M1 is also supported. We are using this version internally for now, and it would be great if you are able to merge it into the master branch.

@ inumanag Thank you so much for your contribution. This is really helpful to alleviate the cumbersome installation issue.


Add yarn file

Get that yarn hype going

🎈

If you wanna change the language in the readme to use yarn over npm thats cool, happy to use Yarn over NPM now


What is the reason for this_ Resource file missing in _nuxt dir?  请问什么原因会导致发布后_nuxt下资源文件丢失？

Discussed in https://github.com/nuxt/nuxt.js/discussions/9488

Originally posted by AbyssWang June 27, 2021
It's like this:
At present, I have two servers, one can directly connect to the Internet, the other intranet server can not directly connect to the Internet, so I need to forward through the Internet server for Internet connection access.
My project is deployed on the Internet server and can be accessed normally by using the domain name. When my project is deployed on the intranet server, the access is abnormal. I use the chrome developer panel to view the sources of the two and find that the_ All the resource folders in the “_nuxt" directory are lost, without fonts and img folder

情况是这样子的：
目前我有两台服务器，一台可以直接连接互联网，另一台内网服务器无法直接连接互联网，需要通过互联网服务器转发来进行互联网连接访问。
我的项目部署在互联网服务器上，使用域名可以正常访问，而当我的项目部署在内网服务器上的时候，访问异常，我使用Chrome开发者面板查看二者的Sources，发现内网服务器的"_nuxt"目录下的资源文件夹全部丢失，没有fonts，没有img，请问这个可能是什么原因造成的？

Closing in favour of the discussion.


New Sheet Metal Task: Compare model and flatmodel volume

@o_o ....码
https://community.sw.siemens.com/s/question/0D54O000087hZFQSA2/how-to-determine-whether-the-sheet-metal-flatpattern-model-is-completed-under-order-modeling-through-apiive-found-that-sometimes-the-order-feature-doesnt-work

Done


Windows Support

This probably already works, but I have not yet tried it myself. This issue is a reminder for the future.
First thoughts of course are file paths.

Still a nice to have. Will address this if there's external interest


Calculated fields

Concept to implement https://github.com/reform-org/reform/issues/175

Hope that UIAttribute -> UIBasicattribute does not lead to major conflicts with the other open PR


custom gMSA not functioning as expected, it assigns more permissions on Root Domain Level while running wizard leveraging custom gMSA account | Bug?

While configuring Microsoft Entra Provisioning Agent with custom gMSA Account, I have observed that it doesn’t honor custom gMSA account permissions, rather it stamps additional permissions on Domain Root Level.
As part of testing and pilot we assigned below permissions to one TestOU and found after installation it added new ACEs on Domain Root.

ACE added by gMSA account on Domain Root Level

It also says in Configuration GUI that ‘Creating group managed service account’, although it doesn’t create new gMSA, validated whencreated AD attribute of this gMSA account.

Wondering Are these known issues, bugs or expected results ?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 88fc98f5-0c60-1f46-2f02-3dad22b6632a
Version Independent ID: 4d2ce2cc-94dd-6073-f145-5a0694e9b542
Content: Prerequisites for Microsoft Entra Cloud Sync in Microsoft Entra ID - Microsoft Entra ID
Content Source: docs/identity/hybrid/cloud-sync/how-to-prerequisites.md
Service: entra-id
Sub-service: hybrid-cloud-sync
GitHub Login: @billmath
Microsoft Alias: billmath

@vamdevmishra
Thanks for your feedback! We will investigate and update as appropriate.

@vamdevmishra
I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1)
Thank you for your time and patience throughout this issue.