Predicates lost during optimization of TPC-H Q17

Describe the bug
- id: tpch_q17
  before:
    - create_tables
  sql: |
    select
      ROUND(sum(l_extendedprice) / 7.0, 16) as avg_yearly
    from
      lineitem,
      part
    where
      p_partkey = l_partkey
      and p_brand = 'Brand#13'
      and p_container = 'JUMBO PKG'
      and l_quantity < (
        select
          0.2 * avg(l_quantity)
        from
          lineitem
        where
          l_partkey = p_partkey
      );
  logical_plan: |
    LogicalProject { exprs: [RoundDigit(($0 / 7.0:Decimal), 16:Int32)], expr_alias: [avg_yearly] }
      LogicalAgg { group_keys: [], agg_calls: [sum($0)] }
        LogicalProject { exprs: [$6], expr_alias: [ ] }
          LogicalFilter { predicate: ($18 = $2) AND ($21 = 'Brand#13':Varchar) AND ($24 = 'JUMBO PKG':Varchar) AND ($5 < $27) }
            LogicalApply { type: LeftOuter }
              LogicalJoin { type: Inner, on: always }
                LogicalScan { table: lineitem, columns: [_row_id#0, l_orderkey, l_partkey, l_suppkey, l_linenumber, l_quantity, l_extendedprice, l_discount, l_tax, l_returnflag, l_linestatus, l_shipdate, l_commitdate, l_receiptdate, l_shipinstruct, l_shipmode, l_comment] }
                LogicalScan { table: part, columns: [_row_id#0, p_partkey, p_name, p_mfgr, p_brand, p_type, p_size, p_container, p_retailprice, p_comment] }
              LogicalProject { exprs: [(0.2:Decimal * ($0 / $1))], expr_alias: [ ] }
                LogicalAgg { group_keys: [], agg_calls: [sum($0), count($0)] }
                  LogicalProject { exprs: [$5], expr_alias: [ ] }
                    LogicalFilter { predicate: ($2 = CorrelatedInputRef { index: 18, depth: 1 }) }
                      LogicalScan { table: lineitem, columns: [_row_id#0, l_orderkey, l_partkey, l_suppkey, l_linenumber, l_quantity, l_extendedprice, l_discount, l_tax, l_returnflag, l_linestatus, l_shipdate, l_commitdate, l_receiptdate, l_shipinstruct, l_shipmode, l_comment] }
  optimized_logical_plan: |
    LogicalProject { exprs: [RoundDigit(($0 / 7.0:Decimal), 16:Int32)], expr_alias: [avg_yearly] }
      LogicalAgg { group_keys: [], agg_calls: [sum($0)] }
        LogicalProject { exprs: [$1], expr_alias: [ ] }
          LogicalFilter { predicate: ($0 < (0.2:Decimal * ($2 / $3))) }
            LogicalProject { exprs: [$5, $6, $27, $28], expr_alias: [ ,  ,  ,  ] }
              LogicalAgg { group_keys: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26], agg_calls: [sum($27), count($27)] }
                LogicalProject { exprs: [$0, $1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17, $18, $19, $20, $21, $22, $23, $24, $25, $26, $27], expr_alias: [ ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ,  ] }
                  LogicalJoin { type: LeftOuter, on: ($28 = $18) }
                    LogicalJoin { type: Inner, on: always }
                      LogicalScan { table: lineitem, columns: [_row_id#0, l_orderkey, l_partkey, l_suppkey, l_linenumber, l_quantity, l_extendedprice, l_discount, l_tax, l_returnflag, l_linestatus, l_shipdate, l_commitdate, l_receiptdate, l_shipinstruct, l_shipmode, l_comment] }
                      LogicalScan { table: part, columns: [_row_id#0, p_partkey, p_name, p_mfgr, p_brand, p_type, p_size, p_container, p_retailprice, p_comment] }
                    LogicalProject { exprs: [$1, $0], expr_alias: [ ,  ] }
                      LogicalFilter { predicate: always }
                        LogicalScan { table: lineitem, columns: [l_partkey, l_quantity] }

Note that the following is only in logical_plan but not optimized_logical_plan:
($18 = $2) AND ($21 = 'Brand#13':Varchar) AND ($24 = 'JUMBO PKG':Varchar)
To Reproduce
In the following test case, add a dummy logical_plan section and run ./risedev do-apply-planner-test.
https://github.com/singularity-data/risingwave/blob/abd2f989440333ef8278cf1225b11b0d9ede5d80/src/frontend/test_runner/tests/testdata/tpch.yaml#L952
Expected behavior
The optimized_logical_plan should include a LogicalFilter including 'Brand#13':Varchar and 'JUMBO PKG':Varchar, and the LogicalJoin { type: Inner, on: always } should have an equality (p_partkey = l_partkey) as its condition.
Additional context

Q2 also lost predicate p_type like '%TIN' and some equalities that are necessary to enable HashJoin.


COO-356: remove link to rhobs-handbook.netlify.app

The page isn't really up-to-date. Also removed sthaha from the list of maintainers.

/cc @danielmellado

This seems to have a trivial conflict in the csv version, @simonpasquier mind rebasing this? I'll get it in afterwards ;)

rebased

rebased again

/lgtm


A simple question about camera and coordinate system.

Hi, I have a simple question about ROMP. I have been struggling putting people into their correct relative position, but is it really possible using the root-aligned SMPL meshes without predicting their transl? (And if we have camera param K, will it be possible? )

What is the coordinate system of the vertices that are used for rendering? I think we are predicting camera coordinate system points but root-aligned, correct?

Following Q1, before rendering verts onto image, there is a trans added to verts ('cam_trans in projection.py') What is it? and what is estimate_translation actually doing? Is this estimating root's position?
https://github.com/Arthur151/ROMP/blob/e30b7d17f13089fa9fa114df494192e31b0f43ed/romp/lib/visualization/visualization.py#L61

I tried to replace the verts +trans in Q2 with GT mesh, so verts=GT_verts, without any other changes to your code, but the results are not correct, I expect it to be fully matched the person on the image but there are always shifts, and I also can't use the same FOV otherwise it would be a very small mesh on the image.

Sorry if I understand anything wrong. I think rendering is the final part I didn't understand in your code. Looking forward you for your answer!
Zhengdi

This is an interesting question.
I also want to ask about the coordinates of the camera and its settings. @Arthur151
The bottom line is that I converted the model to ONNX, got 2 tensors - center_maps and params_maps. I want parse the result and display 2d points from ONNX model (see image)

It seems that the recognition result is correct, but the camera view is from a different angle.
The backbone is the same for ONNX and .pkl file - ResNet50 (from repo)
The Image (512*512) is same for ONNX test and .pkl test (via romp.predict.image)
But pj2d is different (and cam_trans at least). Furthermore, pj2d not in between [-1; 1].  What I do wrong?
Code to parse ONNX result:
    # Prepare CenterMaps
    with open('/usr/src/app/dummies/ResNet50ExistThreePersons/ResNet50_CenterMaps.txt') as f:
        center_maps_str = f.readline() # Just string with values
    center_maps = tensor_from_str(center_maps_str, delimiter=' ').cuda()
    center_maps = center_maps.reshape([1, 1, 64, 64])

    # Prepare ParamsMaps
    with open('/usr/src/app/dummies/ResNet50ExistThreePersons/ResNet50_ParamsMaps.txt') as f:
        params_maps_str = f.readline() # Just string with values
    params_maps = tensor_from_str(params_maps_str, delimiter=' ').cuda()
    params_maps = params_maps.reshape([1, 145, 64, 64])

    # Start parsing
    outputs = {'center_map': center_maps.float(), 'params_maps': params_maps.float()}
    demo_cfg = {'mode': 'parsing', 'calc_loss': False}
    meta_data = {
        'offsets': torch.Tensor([[512., 512.,   0.,   0.,   0.,   0.,   0.,   0.,   0.,   0.]])
    }
    result_parser = ResultParser()

    outputs, meta_data = result_parser.parse_maps(outputs, meta_data, demo_cfg)
    smpl = SMPLWrapper()
    outputs = smpl(outputs, meta_data)

    points = outputs['pj2d'].cpu().detach().numpy()
    result = []
    for i, subpoints in enumerate(points):
        result.append((subpoints+ [1,1]) / 2 * [512, 512])
    return result

Thanks.

Hi, Zhengdi, @ZhengdiYu
I'm glad to finally know your "name". Ha~
About your question:
1 & 2. In ROMP, it only estimate the scale of people  and their x-y translation in image plane. I use PnP algorithm to estimate the corresponding 3D translation via estimate_translation. PnP algorithm solves the 3D translation of a perspective camera via exploring the mapping function between root-aligned 3D pose and its corresponding 2D pose.
3. Please check whether your GT mesh is aligned in root like the predicted mesh. https://github.com/Arthur151/ROMP/blob/e30b7d17f13089fa9fa114df494192e31b0f43ed/romp/lib/models/smpl.py#L335

@ArtiX-GP ,
Hi, Nikita G.,
I guess maybe you overlooked this:
https://github.com/Arthur151/ROMP/blob/e30b7d17f13089fa9fa114df494192e31b0f43ed/romp/lib/models/modelv1.py#L48
B.T.W., we promote the onnx model in simple-romp, please refer to
https://github.com/Arthur151/ROMP/tree/master/simple_romp
--onnx

您好，请问一下romp能够得到人的相机空间中的坐标吗，我发现输出的fbx他的根部都是（0，0，0）对齐的
刚刚接触这个方面，希望您能稍微解答一下~

是可以的，请参见这里
https://github.com/Arthur151/ROMP/blob/e30b7d17f13089fa9fa114df494192e31b0f43ed/romp/exports/convert_fbx.py#L247
和
https://github.com/Arthur151/ROMP/blob/e30b7d17f13089fa9fa114df494192e31b0f43ed/romp/exports/convert_fbx.py#L172
如果不去减pelvis_position，就是绝对空间位置了。

Hi,
I mean that I replaced the predicted mesh + cam_trans with GT_Mesh + its own GT transl but can't get equivalent results.
As I understand, the predicted mesh and GT_Mesh are both aligned by root, if there is no gt_transl and cam_trans.  I think gt_transl is used to move the root-algined mesh to its true camera coordinate, so I thought the estimated cam_trans is also doing the same thing. So I thought the coordinates you used to rendering is in its true coordinate system But it seems not.
So, What is the difference between the estimated cam_trans and GT transl? and, What is the mesh's coordinate system after verts=root_aligned_verts+estimated_cam_trans

Hi, @Arthur151
In ROMP model https://github.com/Arthur151/ROMP/blob/master/simple_romp/romp/model.py this line commented with description not supported by tensorRT
#cam_maps[:, 0] = torch.pow(1.1,cam_maps[:, 0]) # not supported by tensorRT

Does it really turn out that the model cannot be converted to ONNX? :(

@ZhengdiYu , Zhengdi,
Please check this function:
https://github.com/Arthur151/ROMP/blob/704a5ea7f0e8e5041782622b5fc305dbed9733c3/romp/lib/utils/projection.py#L39
Camera coordinate system is defined by the proj_mat in this function. Therefore, if you want to get the predicted translation is GT Camera coordinate system, you just need to provide the right proj_mat, which is commonly called extrinsic & intrinsic camera matrix / camera projection matrix.
If you understand estimate_translation, you will know it can transform the 3D translation from our pre-defined camera space to the target one, like GT Camera coordinate system you want here.

ONNX

@ZhengdiYu , Zhengdi, Please check this function:
https://github.com/Arthur151/ROMP/blob/704a5ea7f0e8e5041782622b5fc305dbed9733c3/romp/lib/utils/projection.py#L39
Camera coordinate system is defined by the proj_mat in this function. Therefore, if you want to get the predicted translation is GT Camera coordinate system, you just need to provide the right proj_mat, which is commonly called extrinsic & intrinsic camera matrix / camera projection matrix.
If you understand estimate_translation, you will know it can transform the 3D translation from our pre-defined camera space to the target one, like GT Camera coordinate system you want here.

Thanks! I will look into this, I do have the camera intrinsic.

@ArtiX-GP
Come on! You just need to put it in post-processing. We don't have to put it in model.
B.T.W, I have make it. Yes, I got the TensorRT model. Don't be ....

Thanks a lot! I will try :)

@Arthur151
Finally, so verts+cam_trans is actually not in the true camera coordiante system, right?
If I still want to project the GT mesh onto the image while keepoing the rendering code the same as yours, instead of GT_Mesh + its own GT transl, what should I use to replace verts = verts+cam_trans? Is there a way to do so or should I change the FOV camera?

verts+cam_trans is in our predefined camera space.
You can use estimate_translation to convert it back from GT to our camera space.
I suggest to use our new renderer in simple-romp, which is much better.
https://github.com/Arthur151/ROMP/blob/704a5ea7f0e8e5041782622b5fc305dbed9733c3/simple_romp/romp/main.py#L167
Defined in https://github.com/Arthur151/ROMP/blob/master/simple_romp/vis_human/main.py

是可以的，请参见这里
https://github.com/Arthur151/ROMP/blob/e30b7d17f13089fa9fa114df494192e31b0f43ed/romp/exports/convert_fbx.py#L247
和
https://github.com/Arthur151/ROMP/blob/e30b7d17f13089fa9fa114df494192e31b0f43ed/romp/exports/convert_fbx.py#L172
如果不去减pelvis_position，就是绝对空间位置了。

谢谢您的指导！我按照您的方式尝试了，root节点的位置是绝对空间位置了
但是root节点是一直锁定的，并不会随着移动
就像这样：他在yuan原视频中是沿着箭头方向向右走动的
但是blender中他只被锁定在了根节点

verts+cam_trans is in our predefined camera space.
You can use estimate_translation to convert it back from GT to our camera space. I suggest to use our new renderer in simple-romp, which is much better.
https://github.com/Arthur151/ROMP/blob/704a5ea7f0e8e5041782622b5fc305dbed9733c3/simple_romp/romp/main.py#L167
Defined in https://github.com/Arthur151/ROMP/blob/master/simple_romp/vis_human/main.py

Got it ! Thanks so much for clarification~

e...想要root跟着动，把这句解注释就可以了吧

您好，非常感谢您的解答！
还想请问您一些问题，可能有一些理解不对的地方：

我发现您的论文中采用了弱透视相机，请问这样的话能估计出每个人在相机坐标系的深度嘛（好像弱透视相机采用的是平均深度，这样的话每个人的深度是不是一样的呢）
我如果想采用已知相机内参，那我应该如何对代码进行改动，来获得人在相机坐标系中的绝对位置呢，是否需要重新训练呢
再次感谢您的解答～

1.如果要求深度的话，请用我们最新开源的BEV, 采用的预定义的透视投影方案。会输出更好的深度信息。
2.不需要重新训练。可以参见上面我和Zhengdi的讨论，已经说明了采用已知相机内参求得对应相机空间的3D translation的方式，如果有不明白的地方可以再问我。

谢谢您的解答，我去尝试一下！
我用了您的romp后，发现也有深度信息，他是通过scale求出来的嘛～

谢谢您的解答，我去尝试一下！
我用了您的romp后，发现也有深度信息，他是通过scale求出来的嘛～

Hey! I'm confused. Why don't I have the 'cam_trans' that you are talking about? Is it an equivalent to 'cam'?
>>> data[0][0].keys()
dict_keys(['params', 'centers_pred', 'centers_conf', 'verts', 'joints', 'smpl_face'])
>>> data[0][0]['params'].keys()
dict_keys(['cam', 'global_orient', 'body_pose', 'betas', 'poses'])

Hi, @sylyt62
Could you please provide the code/command that you run to get the results?

I followed the instruction：
romp --mode=video --calc_smpl --render_mesh  --input=.\demo\videos\camela1.mp4 --save_path=.\demo\videos\camela1_virtual2\results.mp4

pip install --upgrade simple-romp
This could be a missing from old verson before 0.1.0

Indeed! I got it, thx~


FR: Folder to ignore Examples and Functional Extensions Needed

An example of Folder to ignore is needed.
Also, it would be nice to set a folder that does not lint when

For example I don't want linting to happen where I use it as a template folder.
But when I run full file lint
Lint also runs inside the generated template folder.
Handling exceptions in tagged template files is also not a good idea.
Templates are created so that they can be applied elsewhere.
If you use a template, the file that uses the template is automatically an exception.
i.e. what I need is
I want to be able to set which files to exclude when running full lint.

I am not sure that I fully grasp your use case. But it does sound like you want to ignore a specific folder. If that is the case, you can specify the folder to not lint in that rule. If you want to specify which files not to lint, you can do that by adding the following in their YAML frontamtter: disabled rules: [ all ]. Note that this will not affect custom rules as they are not able to be disabled at this time. But all if not most of the other rules should be able to be disabled in this manner.
Does this satisfy your use case?

no..
I wrote this in the above article.
Adding a text to the front matter will also move tags that you deactivated when adding templates to other notes.
I don't want the lint to disappear in other notes to apply the template.
And I want these things to go on automatically.

I guess I am not sure what you are looking for then. The Linter doesn't let you specify a list of file names to ignore. Trying to do that would be the equivalent of adding the value to the front matter minus the custom rules being run.
So I don't think I understand what you are proposing would be used to identify which files to ignore.

I plan to close this at the the end of the week if I do not hear some more specifics on the desired functionality additions. I am not sure I am understanding what has been provided here and cannot do anything with it at this time. If I better understand this, then I may be to implement it.

sorry for coming late
The template function is used a lot in Obsidian.
Due to the nature of Obsidian, templates are also included in one vault.
If I use lint all files in the vault lint goes in the templates folder as well
I am using auto-modify, create-date create lint

There is a folder level exclusion option called Folders to Ignore.

yes... However, I was lost because there was no example of how to write it.

Here is how I ignore them in the setting:

It is the folder name on its own line in the text area

Does that screenshot provide you what you were looking for @mineclover ? If not, what else are you looking for?

I was ignored when I did it this way

However, this method failed to ignore the Template folder.

What is your folder structure like? The name of the folders is relative to the base of your Obsidin directory.
This could be a bug around the use of Chinese characters in the file path. Can you provide a small example of this for me to test out what is wrong (for example a folder within another folder like what you are doing with those Chinese characters so I can test this myself and see if it is a bug)?
I am not sure what a guide would look like for this as most of the time the template folder or other folders ro ignore are at the root of the service. I would need to check the exact logic, but a relative path should still work.

00-지식관리/001-옵시디언/Template
This path is the path from vault to Template

It looks like I need to test https://github.com/platers/obsidian-linter/blob/master/src/main.ts#L294 with nesting and just make sure it works.

And the code you sent is a code that returns true when file starts with the input path.
It seems that the logic cannot use relative paths.
What I was wondering about was solved
I also found out by testing to separate arrays with enter.

what i was wondering
If you want to use folder ignore

Create a path to ignore as an absolute path based on the vault
If you want to ignore additionally, separate with enter

this
yes good

Ok. I will address the 2 points where possible and see if you have any suggestions.

Create a path to ignore as an absolute path based on the vault

This is relative to the base of the Obsidian data directory so no absolute paths. This is the general way this is done in Obsidian plugins, but if we need to we can add some kind of clarification in the UI. I would be open to having that info added, but I would need to know what that would look like in terms of additional wording.

If you want to ignore additionally, separate with enter

This is kind of mentioned in the rule description which says put newlines between folders. I am open to suggestions on how to make this clearer.
Any ideas around these 2 things?
Here is the current info mentioned for Folder Ignore:
Folders to ignore when linting all files or linting on save. Enter folder paths separated by newlines

Yes.. that's a great summary
It would be nice if you could show me a simple example like any other code.
I solved it... but got lost before I could even solve it.

+1 that an example of setting up folders to ignore would be nice. My vault has the following folder structure: journals/daily, journals/monthly, etc. My goal is to ignore all folders under journals/, but I couldn't seem to make it work. I tried the following in the ignore field, but linter still applies to the files under the daily folder:
daily
journals/daily
journals

I am not sure that any of those are invalid folder paths. It may be that trying to escape nested folders is not working, but ignoring a folder should escape all nested folders.

I will see about adding a folder to ignore example. I am not sure it has been tested really well, but I can see about adding an example or 2.

I will also need to see about converting the ignore option to a folder path packer. Hopefully that will happen this coming release, but we will see how things pan out.

It has been a little while, but I am finally revisiting this. I did not like the approach I was taking before so I scrapped part of it and swapped to something more akin to the custom commands suggester. It however just applies to existing folders. I believe it is good to go. However I do need to update the documentation for this for when the next release happens and finish up the word choice. Once I add those 2 things. I will push up the settings changes and close this PR with it getting merged.
Sorry about the delays along the way.

The new setup should look like the following and hopefully be more intuitive:

This change should now be on master and go out with the next release. Please let us know if you have any questions around it or if there are any issues.


BC-36 # only extract String values into files

Fixed

BC-36: only extract String values into external files (@jokeyrhyme)

avoids a mysterious "TypeError: Expected a plain object" when trying to extract null

HelpDesk: 3691-FKCN-9070

LGTM 👍


need to be able to wait on multiple RPCs

I'm currently dealing with this issue and not sure how to properly deal in this situation. From the given issue closure description and the code from the first release I assume nothing was done about it?
I made a separated Peer::Call function which creates ClientRPC on stack which isn't referenced by the Peer class member. Currently I spawn new thread for each RPC call via Peer. Any second thoughts? Performance is my main concern.

Currently each thread in LogCabin executes at most one RPC at a time, so there was no need for a single thread to wait on more than one RPC. I'll reopen this issue for the ongoing discussion and leave it as "invalid" until proven valid.
What are your Peer RPCs doing? Can you have a single long-lived thread? Or a fixed number?
And is performance actually an issue? I was pleasantly surprised by Linux's ability to context switch fairly quickly between threads in a single process, though I didn't look into it very thoroughly.

Oh, the general idea of single threaded RPC is fine with me and has proven valid in the past few years I would assume :)
I was mistaken by the Peer capability which can't handle multiple RPC calls with current design. If a call happens twice before the first one receives a response the latter will crash in case it received a response of a different type. Can reproduce a code if needed.
I made a workaround by simply creating a RPC on stack without being referenced by the Peer class member. Shame it took me 3 days to figure out the issue :) My Peer RPCs are broadcasting requests to the cluster for crosschecking purposes. Broadcast spawns a thread for each RPC call via Peer, the number is fixed according to cluster settings. Will consider using thread pool such as ThreadDispatchService is using.
With performance I think the main problem is that consensus lock has to be held when dealing with Peer, but that's a totally different problem which can also be solved. Have in mind I'm still learning how to handle multi threaded application so my assumptions can be wrong, but I rather ask and might as well help someone else with the question in the future. Is the consensus lock even an issue if the session is already created, will it block anything?
Anyway, to wrap it up, the Peer itself isn't capable of handling multiple RPCs which is entirely different issue so this one can be re-closed.

@krizajb sorry I forgot to reply to this. I don't remember having any problem with multiple RPCs in a single peer in the past: https://github.com/logcabin/logcabin/blob/nasty-thesis-wip/Server/RaftConsensus.h and https://github.com/logcabin/logcabin/blob/nasty-thesis-wip/Server/RaftConsensus.cc . I never merged that code back in, but it did seem to function.


Revise per review, and some assorted other fixes.

Follow-up to #15676.

@swift-ci Please smoke test and merge.

Ooops, that MetadataValues change was not supposed to be part of this patch.

@swift-ci Please smoke test.


Updating input values in Composed components

Hi,
I created a simple test with a TestFormManager which contains a TestForm child component with an input.
I simply want to change the input value so the state in TestFormManager is updated.
The problem is that I can't change the value in the input at all. Even when debugging the handler (setPersonState) is raised and receives the key pressed in the Input, the value is not propagated to the child. So the initial state "Test" is always displayed and can't change it.
This test runs fine in react without typescript
TestFormManager:
import * as React from 'react';
import TestForm from './TestForm';

interface Person {
  name: string;
}

export interface FormManagerProps {}

export interface FormManagerState {
  person : Person;
}
class AccountManager extends React.PureComponent < FormManagerProps, FormManagerState > {
  public state : FormManagerState;
  constructor() {
    super();
    this.state = {
      person: {
        name: 'Test',
      }
    };
    this.setPersonState = this.setPersonState.bind(this);
  }
  setPersonState(event: React.FormEvent<HTMLInputElement>) {
    var field = event.currentTarget.name;
    var value = event.currentTarget.value;
    var currentState = this.state.person;
    currentState[field] = value;
    return this.setState({person: currentState});
  }

  render() {
    return (<TestForm person={this.state.person} onChange={this.setPersonState}/>);
  }
}

export default AccountManager;

And the TestForm
import * as React from 'react';

interface Person {
  name: string;
}

export interface TestFormProps {
  person: Person;
  onChange: (event: React.FormEvent<HTMLInputElement>) => void;
}

class TestForm extends React.Component < TestFormProps, {} > {
  render() {
    return (

        <form>

Person Details:

          <input type="text" name={this.props.person.name} className="form-control" placeholder="Set the name"
            ref={this.props.person.name} value={this.props.person.name} onChange={e => this.props.onChange(e)}/>

          <input type="submit" value="save" className="btn btn-default" />
        </form>

    );
  }
}

export default TestForm;

Have you tried to log field in setPersonState?
Looks like you are using wrong value for input name in TestForm component
<input type="text" name={this.props.person.name}
And you will add new keys into state with current field value, however it must be name to update state correctly.
Also ref containing field value isn't good idea - not needed here.If you are using previous state value - better to use setState with callback function and not this.state directly


Scanner crashes whenever I try to scan

I do all the steps then I leave the game and its at the start game screen. I scan but nothing happens then the app crashes, idk what im doing wrong. If soemone could help me figure this out it would be much appreciated :).

I had this happen to me and it was because even thoug i chagend the resolution to 720p i was coming from borderless fullscreen. If you are start the game from the actual launcher, it will take away the borderless.

I got the same issue.

Click scan
Window switched to the game
It opens Paimon Menu
Cursor move to the account name
App crashed

It seems like the issue has been resolved so I am closing it.


MSID: 98292 Version: 1 DOI: 10.1101/2<IP_ADDRESS>7893

MSID: 98292
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>7893
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=98292
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>7893

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/98292v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>7893
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/98292/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Queried author for missing citation

'()' has been updated to '(see Bacteria and cultures)' - may need to do this for subsequent versions


VS incorrectly identifies Python 3.7 as 2.5 or earlier, prevents debugging

In VS, when selecting Python 3.7 or a 3.7 virtual environment as my python environment, I cannot debug my python scripts.  I get the error message "Debugging is not supported for Python 2.5 and earlier".
I do not (and never had) python 2.5 or earlier installed on this machine.
I have installed both python 2.7 (first) and python 3.7 (later).  I believe I installed 3.7 after PTVS.

I just noticed that the "Properties" panel for Python 3.7 shows "Version 0.0" for Python 3.7.  I'm sure it's probably related.

Could you please check the version of VS in the About Box? If you're not on 15.8.x, then it's possible the that Python 3.7 support wasn't all in yet.
A workaround for incorrectly detected environments is to add them as custom environments. You can set the language to 3.6 for a close enough approximation.

the same is happening for python 3.8 in VS 15.9.23

@KonssnoK , does switching to python 3.6 needs me to install python 3.6 on top of python 3.8?

@deepika45 i had it already available,
I guess it's the Standard visual studio installation (looking at paths)
C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\
Python 3.8 was the one installed over 3.6 in my case :)
C:\Programs\Python38-32

@deepika45 i had it already available,
I guess it's the Standard visual studio installation (looking at paths)
C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\
Python 3.8 was the one installed over 3.6 in my case :)
C:\Programs\Python38-32

Worked for me. Thnx!

Still seen in VS2017 15.9.24 / Python 3.8.1. VS environment for Python 3.8 won't work, have to create custom and label it as 3.6 while pointing to 3.8 binaries. can you fix this??


Support for setting Load Balancer Listener timeout

Support setting the idle_connection_timeout when deploying a Load Balancer
Currently the SLZ override.json file supports setting several properties of the Load Balancer (see this section of the override.json file).
The ibm_is_lb_listener terraform module supports the idle_connection_timeout. Please see: https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/is_lb_listener#idle_connection_timeout
Please support the ability for the user to add a property in the override.json file which will set the idle_connection_timeout.
New or affected modules
Load Balancer:  https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi/blob/main/load_balancer.tf#L82

Included in https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/releases/tag/v5.1.0


Metrics should be optional with an argument and stored in $HOME

Metrics default settings should be stored in the user $HOME similar as git etc.
And to avoid CI integrations problems it should exists a --non-interactive or similar option for de cli.
I don't think that forcing people to store files in their projects is the best solution for this settings.
Thanks!

Nice idea!

We can't use $HOME because people have many Capistrano projects, and concurrent (cross platform) file access is a harder problem to solve than it ought to be.
Regardless, closing because the metrics will go away soon enough, use an old(er) version of Capistrano if you can't work around this.
To address this point:

And to avoid CI integrations problems it should exists a --non-interactive or similar option for de cli.

Your CI is lying to Capistrano if you are still being prompted about it's stdin being a tty, this problem is endemic of bad CI systems (yeah, essentially all of them), and poor understandings of the what POSIX was supposed to be.


Remove weak/node-gyp dependency

When running Phantom on a Windows box it defaults to requiring node-gyp. However, this is not required; please see https://github.com/amir20/phantomjs-node/tree/v1#use-it-in-windows. This should also address an old issue #2.

Coverage remained the same at 99.441% when pulling 093a911fa39a90e2f4f887d5bc28290bc0c7dafe on swim:remove-weak-dep into 4ae680b84ffb40bc0b5ee70b00a955ea5368bc18 on ruipgil:master.

You can pass an object with those functions, when you're instantiating a dynamic scraper. I feel that this is unnecessary to be baked in. Maybe a note in the readme.


json-type to TypeScript

[x] Implement function which converts json-type schema to TypeScript types.
Maybe use AST builder to generate a proper AST?

Although it is not sensible to use it on the Web.

[x] Convert json-type to custom TypeScript AST.
[x] Output JSDoc comments.
[ ] Generate TypeScript for services.
[ ] Generate TypeScript for RPC methods.

:tada: This issue has been resolved in version 6.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix for unrealistic falling of bodies under gravity when bound together by a MotorJoint

In the scenario where a user sets up a MotorJoint binding two dynamic bodies which are under the influence of gravity, they fall in an unrealistic way.
Need to update the math of the MotorJoint to accurately include the linear offset.

Fixed in 8f488ec023a5fcf845845b6b22f90ca1b6edcddb


Pivot / multiple Pages

Hi,
thanks for that useful Module. But on my Mirror in Pivot mode it works only if there ist one page. With multiple Pages tha map is empty an on the top of the Module is a smal strip where i can see the rain.
Any hints what i can do?
Thanks

Same here :(

Same here :(


Interfacing WIFI with BeagleBone Black

what issues did you or others might face with connecting the wifi module to the BBB in terms of hardware and software?
how did you resolve them?
how to use the cell phone's data instead of wifi for internet connectivity purposes?

Answer 1: - Connecting the wifi module/adapter with the beaglebone black is quite easy we didn't find any problems for that what there was one change we can do to receive good wifi signal if we are using an adapter.
Answer 2: - Those changes are by adding extension cable to increase the difference between the HDMI port and Wifi adapter or better connectivity or Disable the HDMI port by editing boot file. Because HDMI port is a right blown USB port which interfaces with wifi signal and we get reduced wifi signal.
Answer 3: - By turning on the mobile hotspot option we can use mobile phone as a wifi modem. Which we will connect with our beaglebone as  secondary or backup wifi option in case our main on is down.
connecting it easy

sudo connmanctl
enable wifi
services
connect
quite

WIfi is connected


System.ArgumentException: An item with the same key has already been added.

ChocolateyGUI 0.13.2 crashes when the following is done:

Start ChocolateyGUI

The app freezes, then throws the following error:
Last performed upgrade last night.
ChocolateyGui crashes during startup with attached exception (.txt added to allow upload to github)
Chocolatey.gui.log.txt
Tried with both v0.13.2 and 0.14.0-unstable0002

I have the same problem : https://i.imgur.com/CSY2Yw8.png
Version 0.13.2

I have the exact same problem on v0.13.2, but I can assure that it is fixed for me when building from the development branch (currently 6bc0fb8fe291f54885b215b7e9258f3e553729c7).


contrib a simple single-node terraform deploy script

goal: add a simple aws terraform deployment script

[ ] assume package (eg wasabi.rpm) is built local
[ ] instantiate single ec2 node, reasonably locked down and durable storage not required
[ ] yum install: java, cassandra, mysql (may not need runit)
[ ] rpm install wasabi
[ ] start wasabi
[ ] open external port
[ ] test via % ./bin/wasab.ish -e IP:8080 test
[ ] destroy instance
[ ] commit as a contrib project

Closing this, #80 was merged.


Example configuration for File type token signing cert.

Under the Deploy To Production section, it would be nice to include an example configuration for using a "Type": "File" for signing tokens.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 21cb7455-3305-9316-5440-bdc22947a82d
Version Independent ID: 137d4b94-7b26-3911-b22d-42c754a95fc1
Content: Introduction to authentication for Single Page Apps on ASP.NET Core
Content Source: aspnetcore/security/authentication/identity-api-authorization.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @javiercn
Microsoft Alias: scaddie

Moved to Container issue: Authentication and authorization for SPAs #16406


JAMES-3639 Allow use PEM keys for SSL

In this tread we discuss enhancements to the IMAP/POP3/SMTP cryptography<EMAIL_ADDRESS>The need of supporting non-keystore PEM files makes James SSL configuration
more in line with the non-java world.

It's a POC :-P

I added those tests.

Rebased to fix conflicts and squashed

Objections towards merging this?

Tested with LE certs in Kubernetes.


Add title to the document

Add title so that user can know what is the page about and solve #24

Since all agree, then I merge ok?

Ok

Ok, merge it

Ok,agree


Delete .DS_Store

@jyapurv we might want to consider creating a .gitignore file

@jyapurv we might want to consider creating a .gitignore file
We do have one inside the Project folder, I will reposition it to the root for future releases. Thanks for the catch. I'm merging the pull request.


Dealer: Rework context retrieval

This resolves the issue that a context with multiple pages couldn't be completely shuffled. I had to rework most of the context resolving part, because resolving the entire context at once wasn't an option. Pretty much blocked the entire main loop for like ~1-30sec depending on the context. Which blocked all processing of commands and or events.
Each context is now requested independently so that commands can fit between requests :D
additional fixes:

metadata of an context is applied again (did seem to have broken it at some point)

does influence the displayed context name, for most contexts it was broken

simplified some match blocks
adjusted playback_speed according to previously mentioned here https://github.com/librespot-org/librespot/pull/1356#issuecomment-2513907580
tried to reduce some state updates

this isn't done for all update, because some have a valid reason to be instantaneously

I will let it stay in draft for some days, so I can still test it a bit more during the day. And maybe someone else even wants to try it^^

When finishing a context it does seem to reset the current track correctly, but doesn't update the next tracks correclty.
probably wrong:

missing queue revision update
no reset of the context-index, or wrong fill_up_context

Quickly pausing and seeking to beginning (just pressing prev) afterwards can update the state incorrectly. Seems to be a no consistent behavior tho.

Log Snippet
[2024-12-12T09:54:10Z TRACE librespot_core::dealer] dealer request hm://connect-state/v1/player/command
[2024-12-12T09:54:10Z TRACE librespot_core::dealer::protocol] message was send with gzip encoding
[2024-12-12T09:54:10Z TRACE librespot_core::dealer::protocol] websocket request: Object {
        "command": Object {
            "endpoint": String("pause"),
            "logging_params": Object {
                "command_id": String("c718c865dfe6ca6e212f56cd54c27750"),
                "device_identifier": String("9c905a62c8859ea4c546520f668ea11d72f601c3"),
            },
            "options": Object {},
        },
        "message_id": Number(977946890),
        "sent_by_device_id": String("9c905a62c8859ea4c546520f668ea11d72f601c3"),
        "target_alias_id": Null,
    }
[2024-12-12T09:54:10Z DEBUG librespot_connect::spirc] handling: 'endpoint: pause' from 9c905a62c8859ea4c546520f668ea11d72f601c3
[2024-12-12T09:54:10Z DEBUG librespot_core::dealer::manager] replying to ws request: Success
[2024-12-12T09:54:10Z DEBUG librespot_playback::player] command=Pause
[2024-12-12T09:54:10Z TRACE librespot_playback::player] == Stopping sink ==
[2024-12-12T09:54:10Z DEBUG librespot_connect::state] updated connect play status playing: true, paused: true, buffering: true
[2024-12-12T09:54:10Z DEBUG librespot_connect::state] update position to 2:14 at 9:54:10.459
[2024-12-12T09:54:10Z DEBUG librespot_core::http_client] Requesting https://gew4-spclient.spotify.com:443/connect-state/v1/devices/7c28ab8a5c9512e4266ac7cb756312c82ee43d7e?product=0&country=DE&salt=3851948888
[2024-12-12T09:54:10Z TRACE librespot_core::dealer] dealer request hm://connect-state/v1/player/command
[2024-12-12T09:54:10Z TRACE librespot_core::dealer::protocol] message was send with gzip encoding
[2024-12-12T09:54:10Z TRACE librespot_core::dealer::protocol] websocket request: Object {
        "command": Object {
            "endpoint": String("seek_to"),
            "logging_params": Object {
                "command_id": String("fefb91696c47f00d05dd575ee3963b83"),
                "device_identifier": String("9c905a62c8859ea4c546520f668ea11d72f601c3"),
            },
            "position": Number(0),
            "value": Number(0),
        },
        "message_id": Number(977947441),
        "sent_by_device_id": String("9c905a62c8859ea4c546520f668ea11d72f601c3"),
        "target_alias_id": Null,
    }
[2024-12-12T09:54:10Z DEBUG librespot_connect::spirc] handling: 'endpoint: seek_to' from 9c905a62c8859ea4c546520f668ea11d72f601c3
[2024-12-12T09:54:10Z TRACE librespot_connect::spirc] seek to SeekToCommand { value: 0, position: 0, logging_params: LoggingParams { interaction_ids: None, device_identifier: Some("9c905a62c8859ea4c546520f668ea11d72f601c3"), command_initiated_time: None, page_instance_ids: None, command_id: Some("fefb91696c47f00d05dd575ee3963b83") } }
[2024-12-12T09:54:10Z DEBUG librespot_core::dealer::manager] replying to ws request: Success
[2024-12-12T09:54:10Z DEBUG librespot_playback::player] command=Seek(0)
[2024-12-12T09:54:10Z TRACE librespot_connect::spirc] ==> Paused
[2024-12-12T09:54:10Z TRACE librespot_connect::spirc] ==> Playing
[2024-12-12T09:54:11Z DEBUG librespot_connect::state] updated connect play status playing: true, paused: true, buffering: true
[2024-12-12T09:54:11Z DEBUG librespot_connect::state] update position to 2:14 at 9:54:11.078
[2024-12-12T09:54:11Z DEBUG librespot_core::http_client] Requesting https://gew4-spclient.spotify.com:443/connect-state/v1/devices/7c28ab8a5c9512e4266ac7cb756312c82ee43d7e?product=0&country=DE&salt=673088253

Currently the initial transfer is not as smooth as it was before these changes. I will fix that, and afterwards remove the draft state. Will probably be a small fix.

Now, just as I have written the comment, I realized that it is no longer possible to select another song to play from the liked songs playlist when shuffle is enabled. xD
If selecting a track, it always jumps to the beginning of the playlist or to the beginning of the currently played song...

Now, just as I have written the comment, I realized that it is no longer possible to select another song to play from the liked songs playlist if shuffle is enabled. xD
If selecting a track, it always jumps to the beginning of the playlist or to the beginning of the currently played song...
It works when shuffle is off.

see here https://github.com/librespot-org/librespot/pull/1414#issuecomment-2553370569 hehe

Don't know if this belongs in this PR or if I should rather create an issue: I discovered that when playing a search result with autoplay, then sometimes the same song is played again when skipping to the next song. Sometimes it is not played directly again but after like 2-4 songs:

I also encountered that Problem and didn't think much about it. But seems to be a Problem of the current solution/branch. I think I already know where the problem lies heh. So that shouldn't be much of a problem to solve.
As always thanks for testing this branch. Helps a lot :D

see here #1414 (comment) hehe

Now I feel stupid, completely overlooked that xD

Wait I take that back... I have a track where it behaves like that and another's where it doesn't... the hell

Yup. Now to make it more confusing, it isn't even always the first track after skipping, as I described above (example: Feliz Navidad, at least for me). Will test your recent changes tomorrow.

I look at "Feliz Navidad" and there is another "Feliz Navidad" in the autoplay context, but with a different uid and uri... so that's impossible to filter out... I will investigate it a bit more, might be that we just need to adjust to the autoplay request or so.

This should "fix" the weird behavior, as we now provide all recently played songs, in which the current track will also be contained, and by that should be not included anymore in the autoplay tracks. But thats for spotify to decide in the end^^

I added another fix around is_playing and is_paused, as is_playing was reported incorrectly because of the weird expectations of the connect devices. I had the fix on a different branch, but it seems more fitting to resolve the issue in the current context.

And another small fix that adjusts the setting of the options only as provided by the SpircLoadCommand and from the dealer.


feat: separate between Serbian with latin letters and cyrillic

@alexva22 do you know the Cyrillic alphabet, or do you know anyone who does?
I just used Google translate for the Cyrillic version now, and have no good way of verifying that these translations are correct.


Media: Add isMuted property to getVideoResource

Context

Summary
Add isMuted property to getVideoResource, so mute icon shows while video is transcoding / uploading.
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Drag video ( that has no audio ) into editor.
See preview uploading, have muted icon.

UAT

[x] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #

Mind filling out the PR template accordingly with QA instructions, checkboxes, labels, etc?
Apart from that LGTM 👍

Verified in QA


The scroll bar of the Metro4 website navigation menu disappeared.

There is no vertical scroll bar in the left navigation pane of the Components section in the website. Therefore, you cannot scroll down to the bottom of the list on non-touch devices. I checked it in Firefox and Chrome.

Use the mouse wheel to scroll the menu. If you use docs site as template for self site, you can add attribute data-menu-scrollbar="true" to show scroll bar.

Of course I always scroll through the pages with the mouse wheel, but suddenly this stopped working in your navigation panel, and I thought it was a Metro bug.
Now I remember and you are right, there has never been a scroll bar there.
Apparently it is an Ubuntu issue, because it occurs in both Chrome and Firefox. When I roll the wheel down it does nothing. When I move it up, the panel shifts about an inch and "bounces."
Thanks Olton for your reply and excuse me for using your time. I will continue to investigate.

My problem has nothing to do with Metro, it also happens in other places and in the Thunderbird mail client.


AST debug

Create an AST pretty printer

The tree structure view should be better, but it seems good enought for debugging ;)


feat: state_class (#30)

Introducte state_class for Sensor entities

Possibility to define state_class for Sensors
Currently only the Sensor mileage is defined with state_class="total_increasing",

#333

I've tested your code in combination with the validator discussed and it works well. I can add the validator to this if you want, but dont want to overstep either.
It would also be good to add device_class for these so we can work on those where needed. I can do that in a separate PR, or you can add to this one.
Let me know.

Please feel free to contribute. You may even edit my PR if you like. I plan being offline from Pc during weekend.

Maybe device_class distance could be useful for some sensors.
Need to check at Pc if others would also make sense:
https://developers.home-assistant.io/docs/core/entity/sensor/
But Prio low from my side currently.

I agree it will be useful to update some of the sensors with device_class when we have time. Figure if we rock this in now we can easily go in and update values whenever later.
Thanks for this PR!

Awesome thanks for doing this!!

I'm not sure if this PR but with latest source and my patch branch in combination: https://github.com/Kolbi/audi_connect_ha/releases/tag/v2.0.0a7 I don't get any entities anymore....

hmm thats odd, I've had them running for morning without issue. Around the time you commented this though, it started failing to login to the Audi Connect servers...

Argh again API issues. Then it must have been bad timing then older version worked again some minutes later.

Yeah idk, I rolled into another version and I log in now but still no data from the cloud. Idk if I'm just testing too much or what but the API has been awful this past week for me.

Argh again API issues. Then it must have been bad timing then older version worked again some minutes later.

I set the audi_api timeout to 30 instead of 10 and it eventually pulled the data. Getting some serious latency of the data request... Thinking maybe we should build in an increase in the timeout with each retry.

If latency why not just increase the timeout overall?  A retry plus longer timeout increases total time and increases call count.

If latency why not just increase the timeout overall?  A retry plus longer timeout increases total time and increases call count.

Yeah I'm fried, I need a vacation haha was thinking timeout was a sleep. Different.
I think increasing timeout would make sense. This has happened a bunch recently, and I'm seeing similar latency in the Audi app at the same time. But the Audi app succeeds because longer timeout where HA fails.

Updated to latest master - charging complete time entity works all other entities are deactivated. But can only continue on Monday sadly. But I moved to the old identifier with using the master so maybe that could cause the issue on my side currently.

Seemed to be an issue on my side. Deleted whole integration and readded and all is working again. Still curious why in combination with my changes it was not working. But maybe because of the API issues.


sometimes i see huge reallocs during objectdump.

i ran using_rbkit.rb for 4 hours. then i requested for obj snapshot.
i had put traces for *allocs, and i could see this:
malloc size 14860e90:8
realloc size 2c456000:268435456
realloc size c4b3000:137281241

so, at one point rbkit is requesting for 268mb of memory. maybe we should look into fragmenting object dump.

Fixed by #77


Add "Enum" IntelliSense for "oneOf" and similar

🙋 feature request
It would be awesome if the extension scanned "oneOf" types in props, to provides IntelliSense with Enumeration-like propositions (like TypeScript ones).
🤔 Expected Behavior

For these propTypes, when entering "size=" it should start displaying 'small', 'medium' and 'large' for example similar to this one :

😯 Current Behavior
Currently it doesn't do anything on the value side of things.
💁 Possible Solution
Probably in the VSCode extension API ;)
🔦 Context
When having a component that require a certain set of values in props, it is really useful to know what can they be, instead of checking into the component manually.
💻 Examples
Look in the upper sections.

+1


Components not updating when click categories?

In side menu, when I clicked on categories in the first, Components will loaded data. But when I clicked categories in the second then Components not updating. Please, Can you help me?

thanks.

Hey @phuongit0301!
I believe it's not a component issue. Most probably, you don't pass any data about selected category to the menu component, but it's hard to say without looking into your code. Please, consider open a Stack Overflow question instead asking you question here. It's great service to ask this kind of question. We consider using github issues only for the component bugs. Therefore, I close this one.


feat:  add lemma CFC.sqrt_eq_zero_iff

Added the simple lemma that for nonnegative elements the square root of an element equals zero iff the element equals zero (all in nonunital continuous functional calculus).

Thanks! Please wait for CI to finish before merging.
bors d+

bors r+


Search doesn't appear to support field filters

The Spotify query API permits for field filters, which allow you to key a search down to return more specific results:

Field filters: By default, results are returned when a match is found in any field of the target object type. Searches can be made more specific by specifying an album, artist or track field filter. For example: The query q=album:gold%20artist:abba&type=album returns only albums with the text “gold” in the album name and the text “abba” in the artist name.

https://beta.developer.spotify.com/documentation/web-api/reference/search/search/
If you try to construct a query to the generic search() function and pass in a filter as part of your q parameter, the call to request() will URI encode it rather than treat it as additional parameters, mangling the query.

I found a workaround that I didn't think previously worked, due to a typo. You can use the q parameter in the generic search() function to compose the filter yourself. For example:
q set to "steambreather artist:mastodon" will work.
I previously ruled this out by trying to compose it like "steambreather&artist:mastdon"
Functions could be added to support this so that the end user doesn't have to compose the filter himself, however, as currently this workaround makes the consumer responsible for making some Spotify-API-specific code himself.

Yes everyone is free to build custom queries. A first step could be to document how to write a query in the spotipy doc.


Add a custom run to Sandmark nightly

@avsm has a request to add a custom run to sandmark nightly. Let's add this to turing and navajo for sequential and parallel runs.

Compiler variant https://github.com/avsm/ocaml/tree/openbsd-mmap-stack
It would be helpful to have a configure option added: --enable-mmap-map-stack and --disable-mmap-map-stack

Linking to https://github.com/ocaml/ocaml/pull/10875 as the upstream issue.

The results have been shared based on the custom run at https://github.com/ocaml/ocaml/pull/10875#issuecomment-1029838604. Hence, closing this issue.


Login with no creds

If I've been previously logged in and I log out, I can then go to the login page and click the login button, the app then logs me in with no creds.

@AmoDinho  It's been a long time since I looked at this. I now assume that I had a cookie or a JWT token on my machine and that's why I was able to get back in without logging in.

@erichodges  Cool, I will continue to work on it till I have found a work around and share it 🥇

@AmoDinho I don't think there is a work around. This is often how auth is setup, so that the user does not have to log in every time. You might want to look around for when the token expires or the cookie expires.

@erichodges You're 100% right, according to the docs it seems we would need to call client.clearStore() in the onClick()  handler of the logout button which will clear the store. Which might be another solution 🤷♀

@AmoDinho Ok, cool. That might be good for a logout button :-).

Thanks @erichodges for opening this issue 😄. It should be working now. Closing this, please, feel free to re-open this issue if you cannot make it work!


Re-order of fields on Vendor list export

If possible, can we reorder the fields in the vendor export to be:
Registered
Shopify ID
Business   Name
Contact   Name
Email
Phone   Number
Bank   Account
Click   and Collect
Date   Accepted Terms

@dwdowns Where would you like InternalTag? After Date Accepted Terms?

Yes thanks
www.downwithcancer.nzhttp://www.downwithcancer.nz/
Check out my book here: www.mildtouch.nzhttp://www.mildtouch.nz/
Check out my TEDx talkhttps://www.ted.com/talks/david_downs_don_t_humour_the_tumour_beating_cancer_with_science_and_optimism.
From: John Downs<EMAIL_ADDRESS>Sent: Friday, 24 April 2020 8:26 PM
To: johndowns/soscafe<EMAIL_ADDRESS>Cc: David Downs<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [johndowns/soscafe] Re-order of fields on Vendor list export (#71)
@dwdownshttps://github.com/dwdowns Where would you like InternalTag? After Date Accepted Terms?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/johndowns/soscafe/issues/71#issuecomment-618877486, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG37V5I4OQNADXIVJWTOQRDROFEK5ANCNFSM4MPUFCPQ.

Ok, this is done but I'll merge tomorrow alongside the other changes.

Thank you
www.downwithcancer.nzhttp://www.downwithcancer.nz/
Check out my book here: www.mildtouch.nzhttp://www.mildtouch.nz/
Check out my TEDx talkhttps://www.ted.com/talks/david_downs_don_t_humour_the_tumour_beating_cancer_with_science_and_optimism.
From: John Downs<EMAIL_ADDRESS>Sent: Friday, 24 April 2020 8:55 PM
To: johndowns/soscafe<EMAIL_ADDRESS>Cc: David Downs<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [johndowns/soscafe] Re-order of fields on Vendor list export (#71)
Ok, this is done but I'll merge tomorrow alongside the other changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/johndowns/soscafe/issues/71#issuecomment-618890760, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG37V5PGFZRAEXMXPUKIGF3ROFHWRANCNFSM4MPUFCPQ.


filter_if: Option?

Laravel validation has a required_if:field,value... Is there any option like that for the filters?
(The use case here has to do with postal codes. I want to run a custom ZIP validator I wrote only if the country = 'USA', but I can't think of a way to do this.
If there is no option for something like this, is there a way to pass another field to a custom filter? Then I could pass the country and just do an if there...

It would be of great help if this could be possible.


FreeLibrarySafeHandle.Null uses the wrong pointer value

I'm trying to call the method LoadIcon. The first parameter is documented to be null if you want a system resource.
However if I call it with the following:
var handle = PInvoke.LoadIcon(FreeLibrarySafeHandle.Null, resource_name);

I'll get an access violation exception, because it sets the pointer to -1 which becomes 0xffffffff.
The workaround is to set it to the correct pointer value for a null:
var handle = PInvoke.LoadIcon(new FreeLibrarySafeHandle(IntPtr.Zero), resource_name);

It seems to me the Null should be using 0 instead of -1.

@AArnott Thanks!
That confirms my suspicion that the same problem was appearing with CloseHandleSafeHandle and DestroyMenuSafeHandle, since you fixed it on their common baseclass.

@AArnott Thanks!
That confirms my suspicion that the same problem was appearing with CloseHandleSafeHandle and DestroyMenuSafeHandle, since you fixed it on their common baseclass.


Whisk object in Swift 3 container

Fixes Issue #1705 where Whisk object was failing to invoke actions and triggers in the Swift 3 container. Blue PG 871.  This fix:

now parses for the protocol prefix in the __OW_API_HOST environment variable
refactors how we wait for the async call to return.  We leave the dispatch group at the end of the post function call instead of in the callback passed to the post function call.

I also added a URLSession based function that can replace the KituraNet implementation.  Its more limited right now (can't handle self-signed certificates because URLCredential is not completely implemented in the Linux-based Foundation) so this function is unused right now.

GCD change may just be stylistic - root cause is the protocol addition.  Will update code to use Swift 3 defer structure to provide single exit point for async function calls instead of exiting group in the callback.

Updated code to use defer.  PG Blue #884


Optimize validation of the license when a single valid identifier is passed

:+1:

@alcohol I suggest tagging 1.1.1 with this performance optimization

I am about to :-)


[WIP] Use cached chainer wheel on CI

make chainer wheel and push to gs with git commit id, use it next time when the commit id is same.

/test

/test


Fix facebook social login problems

Description
Fix bugs on Facebook social login
Checklist

[x] Fix bugs related to background color
[x] Modify condition of error message
[x] Redirect to signin page when Facebook account doesn't have an email account

[x] Add useRouter in client-side to catch the url query string errors from Facebook

#35
Resolved #44

수고하셨습니다 ㅎㅎ 👍


Resolve deprecated features for django3.2

I think there's only one deprecated item - that is easy to fix.
Will also need to update tox to include tests for django3.2 and python 3.8 / 3.9
Consider removing support for python2.x, < python3.7, <django2.2 ?
I am assembling a pull request - let me know if you'd like me to include removing support for unsupported versions, otherwise I'll just add support for django3.2 and python3.8, 3.9

One challenge: dependency persisting_theory may be abandoned?  It also needs a few tweaks...

I'll handle persisting_theory myself, likely next week, I'll keep you updated here :)

@powderflask I've bumped a new version of persisting_theory (https://code.agate.blue/agate/persisting-theory), it should be compatible with python 3 without any warning, do you mind giving it a try?

@agateblue  this works great!  thanks!


kube-cert-manager not listening on port 8080 for HTTP challenges

I am using v0.3.1 of kube-cert-manager and running GKE on a 1.6.4 k8s cluster.
When I set up my ingress to proxy requests from /.well-known/acme-challenge/* to my kube-cert-manager-service and create a new certificate, LetsEncrypt fails to communicate with the server and find the challenge.
On the Providers Section of the docs, it says that you have to route all connections from /.well-known/acme-challenge/ to the port 8080 for kube-cert-manager.
These are my k8s files:
Deployment
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  labels:
    app: kube-cert-manager
  name: kube-cert-manager
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: kube-cert-manager
      name: kube-cert-manager
    spec:
      containers:
        - name: kube-cert-manager
          image: palmstonegames/kube-cert-manager:0.3.1
          args:
            - "-data-dir=/var/lib/cert-manager"
            - "-acme-url=https://acme-staging.api.letsencrypt.org/directory"
          volumeMounts:
            - name: data
              mountPath: /var/lib/cert-manager
        - name: kubectl-proxy
          image: palmstonegames/kubectl-proxy:1.4.0
      volumes:
        - name: "data"
          gcePersistentDisk:
            pdName: kube-cert-manager
            fsType: ext4

Service
apiVersion: v1
kind: Service
metadata:
  name: kube-cert-manager-service
spec:
  selector:
    app: kube-cert-manager
  type: NodePort
  ports:
    - name: http
      protocol: TCP
      port: 80
      targetPort: 8080

Ingress
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: cachet-stage-ingress
  annotations:
    stable.k8s.psg.io/kcm.enabled: "true"
    stable.k8s.psg.io/kcm.provider: "http"
    stable.k8s.psg.io/kcm.email<EMAIL_ADDRESS>    kubernetes.io/ingress.global-static-ip-name: "cachet-stage-ip"
    kubernetes.io/ingress.class: "gce"
spec:
  # tls:
  # - hosts:
  #   - status-stage.example.com
  #   secretName: status-stage.example.com
  rules:
  - host: "status-stage.example.com"
    http:
      paths:
      - path: /.well-known/acme-challenge/*
        backend:
          serviceName: kube-cert-manager-service
          servicePort: http
  backend:
      serviceName: cachet-stage-service
      servicePort: http

same here, you can see from a netstat within the container that the port 8080 is not open. port 8001 is but does not seem to be usable.
/ # netstat -anlp
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 <IP_ADDRESS>:8001          <IP_ADDRESS>:*               LISTEN      -
tcp        0      0 <IP_ADDRESS>:41412         <IP_ADDRESS>:8001          TIME_WAIT   -
tcp        0      0 <IP_ADDRESS>:53810         <IP_ADDRESS>:443          ESTABLISHED -
tcp        0      0 <IP_ADDRESS>:53800         <IP_ADDRESS>:443          ESTABLISHED -
tcp        0      0 <IP_ADDRESS>:40766         <IP_ADDRESS>:8001          ESTABLISHED 1/kube-cert-manager
tcp        0      0 <IP_ADDRESS>:41332         <IP_ADDRESS>:8001          TIME_WAIT   -
tcp        0      0 <IP_ADDRESS>:41492         <IP_ADDRESS>:8001          ESTABLISHED 1/kube-cert-manager
tcp        0      0 <IP_ADDRESS>:53806         <IP_ADDRESS>:443          ESTABLISHED -
tcp        0      0 <IP_ADDRESS>:8001          <IP_ADDRESS>:40768         ESTABLISHED -
tcp        0      0 <IP_ADDRESS>:8001          <IP_ADDRESS>:41492         ESTABLISHED -
tcp        0      0 <IP_ADDRESS>:40768         <IP_ADDRESS>:8001          ESTABLISHED 1/kube-cert-manager
tcp        0      0 <IP_ADDRESS>:8001          <IP_ADDRESS>:40766         ESTABLISHED -

I found that configuring an ingress path to the kube-cert-manager-service does not work (I am on IBM Bluemix container service). I am quite new to Kubernetes so I might be mistaken in that point.
Since I am running a Rails and Puma application with a Nginx reverse proxy (=rails+nginx containers in one pod), I configured my nginx containers to forward the path .well-known/acme-challenge/ to the kcm-service. The corresponding part of the nginx.conf looks like this:
location ~ ^/.well-known/acme-challenge/ {
          proxy_pass http://kube-cert-manager-service;
          proxy_set_header Host $host;
          proxy_set_header X-Real-IP $remote_addr;
          proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        }

I suppose only proxy_pass and the Host header are really necessary.
Using KCM version 0.5 from image iosphere/kube-cert-manager:c8443d4.
@ferrerluis not entirely sure, but in order for a Kubernetes service to work properly, don't you have to open port 8080 in your deployment?


Fix cannot get editing buffer-local commands in cmdwin

Problem
In cmdwin, we cannot complete editing buffer-local commands.
This behavior is different from cmdline completion's behavior but it should be the same.

Also the result of execute('command') becomes different between in cmdline and cmdwin, but it should be the same.
The following is a sample code to reproduce this problem.
command! -buffer Test echo 'test-command'

let s:cmds = []
function! StoreUserCmds() abort
  call add(s:cmds, execute('command'))
  return ''
endfunction
function! CheckResult() abort
  call assert_equal(s:cmds[0], s:cmds[1])
  return v:errors
endfunction

cnoremap <expr> @ StoreUserCmds()
nnoremap <expr> @ StoreUserCmds()

let s:script = ":@\<CR>" . "q:@\<C-c>\<C-c>" . ":echomsg CheckResult()\<CR>"

call feedkeys(s:script)

" The output is:
" ['function CheckResult line 1: Expected ''\n    Name              Args Address Complete    Definition\nb   Test              0\[  occurs 24 times]echo ''''test-command'''''' but got ''\nNo user-defined commands found''']

Solution
Use data of the cmdwin's alternative buffer for listing user-defined commands.

Thanks for looking into this.
The test passes without including the fix.  Thus it's not testing the right thing.

The test passes without including the fix.

!!!! I didn't notice...

Thus it's not testing the right thing.

I'm sorry, that's right.  I'm making a new test now. Please wait a minute.

Hmm...
Surprisingly, this test code didn't failed:
func Test_compl_in_cmdwin2()
  func CheckCompletion()
    call assert_equal('hoge', 'fuga')
    return ''
  endfunc
  nnoremap <expr> @ CheckCompletion()
  call feedkeys("q:@", 'x')
  nunmap @
  delfunc CheckCompletion
endfunc

And the following test code fails
func Test_compl_in_cmdwin3()
  com! -buffer TestCommand call setline(1, 'TestCommand')
  execute "normal! q:iT\<C-x>\<C-v>\<C-y>\<CR>"
  call assert_equal('TestCommand', getline(1))
  delcom TestCommand
  % delete _
endfunc

func Test_compl_in_cmdwin4()
  com! -buffer TestCommand call setline(1, 'TestCommand')
  call feedkeys("q:iT\<C-x>\<C-v>\<C-y>\<CR>", 'x')
  call assert_equal('TestCommand', getline(1))
  delcom TestCommand
  % delete _
endfunc

with this message:
Found errors in Test_compl_in_cmdwin3():
Caught exception in Test_compl_in_cmdwin3(): Vim(<):E488: Trailing characters @ function RunTheTest[40]..Test_compl_in_cmdwin3, line 2
Found errors in Test_compl_in_cmdwin4():
Caught exception in Test_compl_in_cmdwin4(): Vim(<):E488: Trailing characters @ function RunTheTest[40]..Test_compl_in_cmdwin4, line 2

That's why, I don't have a good idea to test the completion...  Do you have any good ideas?

Hmm...
Surprisingly, this test code didn't failed:
func Test_compl_in_cmdwin2()
  func CheckCompletion()
    call assert_equal('hoge', 'fuga')
    return ''
  endfunc
  nnoremap <expr> @ CheckCompletion()
  call feedkeys("q:@", 'x')
  nunmap @
  delfunc CheckCompletion
endfunc

And the following test code fails
func Test_compl_in_cmdwin3()
  com! -buffer TestCommand call setline(1, 'TestCommand')
  execute "normal! q:iT\<C-x>\<C-v>\<C-y>\<CR>"
  call assert_equal('TestCommand', getline(1))
  delcom TestCommand
  % delete _
endfunc

func Test_compl_in_cmdwin4()
  com! -buffer TestCommand call setline(1, 'TestCommand')
  call feedkeys("q:iT\<C-x>\<C-v>\<C-y>\<CR>", 'x')
  call assert_equal('TestCommand', getline(1))
  delcom TestCommand
  % delete _
endfunc

with this message:
Found errors in Test_compl_in_cmdwin3():
Caught exception in Test_compl_in_cmdwin3(): Vim(<):E488: Trailing characters @ function RunTheTest[40]..Test_compl_in_cmdwin3, line 2
Found errors in Test_compl_in_cmdwin4():
Caught exception in Test_compl_in_cmdwin4(): Vim(<):E488: Trailing characters @ function RunTheTest[40]..Test_compl_in_cmdwin4, line 2

That's why, I don't have a good idea to test the completion...  Do you
have any good ideas?

Have a look at src/testdir/test_cmdline.vim, it tests various kinds of
completion.
--
Did Adam and Eve have navels?
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Adding a new test and fixing a bug have done.
Thank you for giving me the advice ;)

Codecov Report

Merging #4711 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4711      +/-   ##
==========================================
+ Coverage   81.38%   81.39%   +<.01%
==========================================
  Files         114      115       +1
  Lines      145243   145286      +43
==========================================
+ Hits       118205   118250      +45
+ Misses      27038    27036       -2

Impacted Files
Coverage Δ

src/usercmd.c
94.87% <100%> (+0.17%)
:arrow_up:

src/ex_getln.c
76.55% <0%> (-0.16%)
:arrow_down:

src/window.c
87.3% <0%> (-0.07%)
:arrow_down:

src/terminal.c
81.25% <0%> (-0.04%)
:arrow_down:

src/userfunc.c
88.16% <0%> (-0.01%)
:arrow_down:

src/misc1.c
80.64% <0%> (ø)
:arrow_up:

src/version.c
91.89% <0%> (ø)
:arrow_up:

src/screen.c
82.21% <0%> (ø)
:arrow_up:

src/viminfo.c
76.16% <0%> (ø)

src/syntax.c
82.62% <0%> (ø)
:arrow_up:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61343f0...646c942. Read the comment docs.

Thank you!


When mode is per-module, index.html will insert some text at the start after build

reproduction link

I think #1265 brought this problem.
So now I have to implicitly set
exclude: [/\.html$/]


Youtube videos slightly desaturated [Notable when full screening]

When your watching videos in Youtube you can tell some colors are off just by switching to full screen and back. Any way to fix this? Not a major issue but sure is an improvement.

This is any video, not just YouTube. Videos should not be shaded. Also Google images and Flickr... these image services should not be shaded either. Where the media is the focus, it should not be shaded.

20% shade was removed from reverted blocks.


170 stack recursion rendering docs

Fixed MediaType#describe to include the correct string representation of its identifier.

LGTM


Broken External Windows

Describe the Bug
The camera external windows are not working as expected if they are open the camera is enabled.
On master the window remains black when the camera is enabled, on develop Webots crashes when the camera is enabled.
Steps to Reproduce

Open the 'samples/devices/camera' simulation in pause mode.
Open the camera overlay in an external window.
On develop: enable the ambient occlusion on the camera with the Camera.ambientOcclusionRadius field.
Start the simulation

Expected behavior
The camera image should be visible even if the external window is open before the simulation starts.
Screenshots
master:

System

Operating System: Linux Ubuntu 16.04
Graphics Card: NVIDIA GeForce GTX 970

Stack on develop
#0  0x00007fffe6e69956 in ?? ()
   from /usr/lib/nvidia-384/libnvidia-glcore.so.384.130
#1  0x00007fffe6e7b91c in ?? ()
   from /usr/lib/nvidia-384/libnvidia-glcore.so.384.130
#2  0x00007fffe6a3a14e in ?? ()
   from /usr/lib/nvidia-384/libnvidia-glcore.so.384.130
#3  0x0000000000bb1e14 in wren::StaticMesh::render (this=0xfe43210,
    drawingMode=4) at StaticMesh.cpp:1565
#4  0x0000000000ba356a in wren::Renderable::setupAndRender (this=0xfe6a220,
    program=0xfe42df0) at Renderable.cpp:217
#5  0x0000000000ba2996 in wren::Renderable::render (this=0xfe6a220,
    program=0x0) at Renderable.cpp:80
#6  0x0000000000bc22e1 in wren::Scene::renderToViewport (this=0x60fe4f0,
    culling=true) at Scene.cpp:367
#7  0x0000000000bc19f9 in wren::Scene::renderToViewports (this=0x60fe4f0,
    viewports=std::vector of length 1, capacity 1 = {...}, culling=true)
    at Scene.cpp:266
#8  0x0000000000bc15e4 in wren::Scene::render (this=0x60fe4f0, culling=true)
    at Scene.cpp:223
#9  0x0000000000bc467a in wr_scene_render (scene=0x60fe4f0, material_name=0x0,
    culling=true) at Scene.cpp:862
#10 0x0000000000a7a222 in WbWrenWindow::renderNow (this=0x5c426d0,
    culling=true) at gui/WbWrenWindow.cpp:229

Same problem on Windows, the controller crashes (with the same stack) even if the ambientOcclusionRadius field is not changed.


metamask invalid sig on post short ntoes

the weird thing is that comment and long-form works fine...

seem it is because the chain_id/eth_account/password one of these three changed so it gen differernt private key -> basically a different nostr account, and when posting on home page, the event is pre-filled with the original pubkey while in the other input we didn't do that so when posting other place it doesn't trigger the invalid signature error.

we should save the chain_id/eth_account/password all in the local-storage and only left password in user's mind. also we should check if the signing key is matched with the current signed-in pubkey in all the input place so we can let users know that if there is account changed


Define "Assembly"

Type of issue
Missing information
Description
The term "assembly" is used in this article, but isn't defined.
Page URL
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/internal
Content source URL
https://github.com/dotnet/docs/blob/main/docs/csharp/language-reference/keywords/internal.md
Document Version Independent Id
4926fa62-f791-dc1a-7c09-7b268180d20e
Article author
@BillWagner
Metadata

ID: ac43c546-b79a-a4cb-6b59-7037334b83e0
Service: dotnet-csharp
Sub-service: lang-reference

Hi @BillWagner  What definition do you mean? I can see a link to assemblies definition in the article

Hi @bigboybamo
First, that link should be made more prominent when the term "assembly" is first used. We should add an informal definition for an "assembly" as "An assembly an executable or dynamic link library (DLL) produced from compiling one or more source files."

Hi @BillWagner
I opened a Pull Request https://github.com/dotnet/docs/pull/40228

Fixed in #40228


changeEditorInterface fails when used with editContentType

If I create a new Content Model with a migration like the one below, then changeEditorInterface works and the migration goes through.
module.exports = function(migration) {
    const genricModel = migration.createContentType('genericModel', {
        name: 'Generic test model',
        description: 'Testing the migration API'
    });
    genricModel.createField('region', {
        name: 'Country',
        type: 'Symbol',
        required: true,
        validations: [{'in': ['SE', 'DK', 'NO']}]
    });
    genricModel.changeEditorInterface('region', 'radio');
};

But if I run this migration on an already existing Content Model, the actual field is created but the changeEditorInterface throws an error and the migration halts, but the field has been created with the default editor interface.
module.exports = function(migration) {
    const genricModel = migration.editContentType('genericModel');
    genricModel.createField('region', {
        name: 'Country',
        type: 'Symbol',
        required: true,
        validations: [{'in': ['SE', 'DK', 'NO']}]
    });
    genricModel.changeEditorInterface('region', 'radio');
};

The migration above givs this error
The following migration has been planned

Update Content Type genericModel

  Create field region
    - name: "Country"
    - type: "Symbol"
    - required: true
    - validations: [{"in":["SE","DK","NO"]}]

Publish Content Type genericModel
Update editor interface for Content Type genericModel
  - Field region: radio
? Do you want to apply the migration Yes
 ✔ Update Content Type genericModel
 ❯ Update editor interface for Content Type genericModel
   ✖ Making requests (1/1)
     → Batch failed
🚨  Migration unsuccessful
Batch failed

Error: {"status":"Conflict","message":"","details":{},"url":"https://api.contentful.com:443/spaces/space-id-anonymized/environments/master/content_types/genericModel/editor_interface"}

and produces the following log, I've removed project path and space id
VersionMismatch: {
  "status": 409,
  "statusText": "Conflict",
  "message": "",
  "details": {},
  "request": {
    "url": "https://api.contentful.com:443/spaces/space-id-anonymized/environments/master/content_types/genericModel/editor_interface",
    "headers": {
      "Accept": "application/json, text/plain, */*",
      "Content-Type": "application/vnd.contentful.management.v1+json",
      "X-Contentful-User-Agent": "app contentful.migration-cli/0.6.0; sdk contentful-management.js/4.1.2; platform node.js/8.9.4; os macOS/17.4.0;",
      "Authorization": "Bearer ...e61aa",
      "user-agent": "node.js/v8.9.4",
      "Accept-Encoding": "gzip",
      "X-Contentful-Version": 15,
      "Content-Length": 144
    },
    "method": "put",
    "payloadData": "{\"controls\":[{\"fieldId\":\"title\",\"widgetId\":\"singleLine\"},{\"fieldId\":\"paragraph\",\"widgetId\":\"markdown\"},{\"fieldId\":\"region\",\"widgetId\":\"radio\"}]}"
  },
  "requestId": "f067c3e7f1013ce64ae867a5741fcf1f"
}
    at errorHandler (/project-path-anonymized/node_modules/contentful-management/dist/contentful-management.node.js:693:15)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

My workaround at the moment is to run the createField in one migration and then changeEditorInterface in a second.

Thanks for opening as a new issue 👍
As written in https://github.com/contentful/migration-cli/issues/57#issuecomment-372265906 I got it reproduced and aim for fixing it first and only then release the feature.

Fixed in https://github.com/contentful/migration-cli/pull/89


docs(noRestrictedImports): update version notice

Summary

Changed the version number from v1.6.0 to v2.0.0 to reflect the correct introduction version of the no-restricted-imports rule.
Issue mentioned in https://github.com/biomejs/biome/issues/4750
Test Plan

This doesn't look right. The options have changed in 2.0. The rule has been there since 1.6.0.

Thank you for the review. I reviewed this pull request and am wondering how users can access configuration documentation for previous versions. Do we need to retain the old docs here, considering that v2 hasn't been released yet?

Yes, we should probably retain the old docs. Go ahead and add them alongside the new docs here in the rule, and make sure to label it with the version it applies to.


GRPC exporter for web clients

NB: Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue on opentelemetry-specification first.
Is your feature request related to a problem? Please describe.
The problem I'm facing is that @opentelemetry/exporter-trace-otlp-grpc states that it for web, but when I have tried to make it work it just throws a bunch of errors in my frontend client. After doing some research it appears as though it shouldn't suggest it is for web because it uses: @grpc/grpc-js which is for node-js and rather it should be using grpc-web.
Describe the solution you'd like
Ideally I'd like to be able to have my traces sent to my collector using a GRPC exporter in my frontend client.
Describe alternatives you've considered
Alternatives are currently to use https.
Additional context
None that I know of.

Hmm sorry for the incorrect docs. The OTLP/HTTP exporter works in the web and exports using JSON over HTTP.

No worries, that's why I made this a feature request to see if a grpc-web exporter could be made, if not please feel free to close this.

If i'm not mistaken there is no way of using the official grpc client in the browser ? There are alternatives (https://github.com/improbable-eng/grpc-web or https://github.com/grpc/grpc-web) but this would requires making new exporters i believe

Yes that is the ask of this feature request, to make a new exporter library using the grpc-web dependency.

Do we have any way to use grpc web trace exporter?

This would make sense to have, as there are collectors only supporting grpc.
https://github.com/dotnet/aspire/issues/3688


Build as an alias for primary artifact seems wrong

E.g. Build.BuildNumber - it's nothing to do with a build here, just artifact.  (The artifact may have come from a build, or may not)
Artifact.Version would seem like a nicer variable name.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 611642f0-881f-10b9-ae94-3c562001d1f0
Version Independent ID: 41efb94b-4c7a-64a3-b23b-70c8634ae727
Content: Release variables and debugging - Azure Pipelines
Content Source: docs/pipelines/release/variables.md
Product: devops
Technology: devops-cicd
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

Thanks for the feedback. Due to the nature of artifacts being of types build, repo, package and container we cannot have a standard variable format that works for all. We are working on documentation to make it clear about what variables are valid for each of the first class artifact sources.

@bluebirdtech, thank you for your feedback, and @ashokirla for your response.
I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


Kafka consumer takes long time to receive message

From producer sending messages to consumers receiving messages for more than 1 second, the delay is long.why?

I do not have nearly enough information to be able to answer this question. 1 second is not an unreasonable total time from producer to consumer since there are at least two complete network round-trips in that flow and possibly more depending on replication.
What version of Sarama (and Kafka) are you using? What configuration values? Can you provide logs?

you can close it,thanks.


Chat Room

Chat Room and  #1966

Close #1966

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md

@shubhisingh184 Give meaning full commit messages and also would like to know how you created the whole project in one commit?

Okay, I'll take care of that next time. Actually, when this issue is assigned to me, I started working on this project and test it locally,  then I simply add that part and done in single commit because I've already tested everything locally on my system.

@shubhisingh184 ideal way of development is to make a commit at each major step completion, it helps you to revert code to a previous commit if something goes wrong. Hope this helps.

Yeah, I got it. Thankyou so much for mentioning every detail that I can improve next time. It's been great to contribute and learn from you. Again, thanks a lot.


Feedlist position is not always updated with show-read-feeds false

Newsboat version (copy from newsboat -v): r2.10.1-110-g7f11
As reported by @polyzen in #70:

Disable show-read-feeds
Enter the feed at the bottom of the feed list
Mark its articles as read
Go back to the feed list
Enter the bottom feed (that was second from the bottom previously) while it's still highlighted
The feed that you had just marked as read is shown instead

Other info you think is relevant:
My asciinema cast that shows the steps, but not the results. This was shot with STFL 0.22.
I now reproduced this with STFL 0.24. Couldn't reproduce with STFL 0.23 (behaviour is the same as with 0.22).

@polyzen, I think you'll have to revert back to STFL 0.23 for now. I'll try to find time to take a look at what changed in STFL between 0.23 and 0.24 to see if I can submit a patch upstream.

Note that this only affects the bottom feed, so fairly minor, but I've downgraded nonetheless. :)

There was only a handful of patches between 0.23 and 0.24, and two of them had to do with "pos_name" attribute, which was ostensibly broken and then fixed. Apparently, not completely fixed.
But after looking at the code for a bit, I think I'd rather figure out a way to move off libstfl to something maintained, than work on fixing the library itself.

@polyzen this library seem to provide ready-made dialogs rather than widgets that we can use to build our own UIs. We have a separate issue for STFL work, #232; please see my comment there.

This is caused by a bug in stfl (description: https://github.com/dennisschagt/stfl/issues/3).
I've created a fix for it in my own fork of stfl (PR: https://github.com/dennisschagt/stfl/pull/4).
@Minoru: Is it useful to mention this in the changelog?

Is it useful to mention this in the changelog?

Absolutely! You can mark this issue closed from the commit that adds a changelog entry; there's nothing more that we can do here. Thanks for investigating and developing a fix!
Re-tagging as "invalid" since the bug isn't with Newsboat itself.


Add yaml info in KFServing install #1464

What this PR does / why we need it:
In https://www.kubeflow.org/docs/components/serving/kfserving/#kfserving-installation-using-kubectl,  add info about the yaml file so that user can install KFServing without cloning the Github repo.
Which issue(s) this PR fixes :
Fixes #1464

This change is

/assign @jinchihe

/lgtm
/approve


POM version fix

Description
pom versioning bugfix
Tests
N/A
People To Reivew
@pujav65
@meiercaleb
@DLotts

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/703/


New version: Ryujinx.Ryujinx.Ava version 1.1.1112

Pull request has been created with Komac v1.11.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

@wingetbot run

Automatic Validation ended with:

Exception during executable launch operation System.InvalidOperationException: No process is associated with this object.

(Automated response - build 642.)

@wingetbot waivers Add Validation-Executable-Error


UI enhance

Describe your changes
Including the option for a "dark mode" theme for the unit conversion extension to make it more usable.
New styles added to the popup css style sheet to include dark mode customizations, "toggle switch" added to the popup html page so user can switch between dark/light themes, and event listener updated in the popup js file to switch styles if the toggle switch is activated.
Issue number and link
#1
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] If it is a core feature
[x] I have added thorough tests

This branch solves issue #10 by including the toggle theme functionality.


compile error " sr_get_changes"

Hi!
I've got an error when start to build this:
_[vmware@srv-01 build]$ make
[  5%] Building CXX object CMakeFiles/sysrepo-cpp.dir/src/Connection.cpp.o
[ 11%] Building CXX object CMakeFiles/sysrepo-cpp.dir/src/Enum.cpp.o
[ 16%] Building CXX object CMakeFiles/sysrepo-cpp.dir/src/Session.cpp.o
/home/vmware/sysrepo-cpp-master/src/Session.cpp: In member function ‘std::optional sysrepo::Session::getPendingChanges() const’:
/home/vmware/sysrepo-cpp-master/src/Session.cpp:217:20: error: ‘sr_get_changes’ was not declared in this scope; did you mean ‘sr_has_changes’?
217 |     auto changes = sr_get_changes(m_sess.get());
|                    ^~~~~~~~~~~~~~
|                    sr_has_changes
/home/vmware/sysrepo-cpp-master/src/Session.cpp: At global scope:
/home/vmware/sysrepo-cpp-master/src/Session.cpp:573:2: warning: extra ‘;’ [-Wpedantic]
573 | };
|  ^
make[2]: *** [CMakeFiles/sysrepo-cpp.dir/src/Session.cpp.o] Error 1
make[1]: *** [CMakeFiles/sysrepo-cpp.dir/all] Error 2
make: *** [all] Error 2
_
Can you please help with this issue?

On a release devel is merged into master so in both, currently.