Added prometheus metrics to the diagnostics script

[!warning]
This is a public repository, ensure not to disclose:

[x] personal data beyond what is necessary for interacting with this pull request, nor
[x] business confidential information, such as customer names.

What kind of PR is this?
Required: Mark one of the following that is applicable:

[x] kind/feature
[ ] kind/improvement
[ ] kind/deprecation
[ ] kind/documentation
[ ] kind/clean-up
[ ] kind/bug
[ ] kind/other

Optional: Mark one or more of the following that are applicable:

[!important]
Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

[ ] kind/admin-change
[ ] kind/dev-change
[ ] kind/security
[ ] kind/adr

What does this PR do / why do we need this PR?

Adds the possibility to query prometheus metrics using the diagnostics script.

Fixes https://github.com/elastisys/ck8s-issue-tracker/issues/285

Information to reviewers
Do we want more metrics?

Here is an example output
❯ ./bin/ck8s diagnostics sc --with-metrics-since 1day
[ck8s] Running diagnostics...
[ck8s] Validating sc config
[ck8s] Using unencrypted kubeconfig /home/elias/Documents/environments/coffee-brewer-dev/.state/kube_config_sc.yaml
------------------------------------------------------------------------------------------------------------------
Querying fluentd output error rate.
Fluentd output error rate over 0 on the dates:
ons 14 aug 2024 03:02:00 CEST
ons 14 aug 2024 08:44:00 CEST
ons 14 aug 2024 08:45:00 CEST

------------------------------------------------------------------------------------------------------------------
Querying dropped packages.
Found dropped packages going to pod: "fluentd-aggregator-0" on dates:
ons 14 aug 2024 08:44:00 CEST
ons 14 aug 2024 08:45:00 CEST

Found dropped packages going from pod: "fluentd-forwarder-j54f2" on dates:
ons 14 aug 2024 08:42:00 CEST
ons 14 aug 2024 08:43:00 CEST
ons 14 aug 2024 08:44:00 CEST
ons 14 aug 2024 08:45:00 CEST

Found dropped packages going from pod: "fluentd-forwarder-kh98r" on dates:
ons 14 aug 2024 08:42:00 CEST
ons 14 aug 2024 08:43:00 CEST
ons 14 aug 2024 08:44:00 CEST
ons 14 aug 2024 08:45:00 CEST

Found dropped packages going from pod: "fluentd-forwarder-qlbjq" on dates:
ons 14 aug 2024 08:42:00 CEST
ons 14 aug 2024 08:43:00 CEST
ons 14 aug 2024 08:44:00 CEST
ons 14 aug 2024 08:45:00 CEST

Found dropped packages going from pod: "fluentd-forwarder-svtsz" on dates:
ons 14 aug 2024 08:42:00 CEST
ons 14 aug 2024 08:43:00 CEST
ons 14 aug 2024 08:44:00 CEST
ons 14 aug 2024 08:45:00 CEST

Found dropped packages going from pod: "thanos-query-query-frontend-85f8d59458-fhthk" on dates:
tis 13 aug 2024 16:54:00 CEST
tis 13 aug 2024 16:55:00 CEST

Found dropped packages going to pod: "thanos-query-query-frontend-85f8d59458-fhthk" on dates:
tis 13 aug 2024 16:54:00 CEST
tis 13 aug 2024 16:55:00 CEST

Found dropped packages going from pod: "hnc-controller-webhook-57777c7778-8gxv7" on dates:
tis 13 aug 2024 16:42:00 CEST

------------------------------------------------------------------------------------------------------------------
Querying uptime.
The target "fluentd" was down on dates:
ons 14 aug 2024 08:44:00 CEST
ons 14 aug 2024 08:45:00 CEST

------------------------------------------------------------------------------------------------------------------
Querying Opensearch cluster status
Opensearch is in "yellow" state!

Checklist

[x] Proper commit message prefix on all commits

Change checks:

[x] The change is transparent
[ ] The change is disruptive
[x] The change requires no migration steps
[ ] The change requires migration steps
[ ] The change upgrades CRDs
[ ] The change updates the config and the schema

Metrics checks:

[ ] The metrics are still exposed and present in Grafana after the change
[ ] The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
[ ] The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)

Logs checks:

[ ] The logs do not show any errors after the change

Pod Security Policy checks:

[ ] Any changed pod is covered by Pod Security Admission
[ ] Any changed pod is covered by Gatekeeper Pod Security Policies
[ ] The change does not cause any pods to be blocked by Pod Security Admission or Policies

Network Policy checks:

[ ] Any changed pod is covered by Network Policies
[ ] The change does not cause any dropped packets in the NetworkPolicy Dashboard

Audit checks:

[ ] The change does not cause any unnecessary Kubernetes audit events
[ ] The change requires changes to Kubernetes audit policy

Falco checks:

[ ] The change does not cause any alerts to be generated by Falco

Bug checks:

[ ] The bug fix is covered by regression tests

I've not yet looked into the specifics, but this looks more and more like we are starting to export everything which we usually get access to by having access to the clusters and the dashboards themselves. It does not sounds feasible that we continue down this road as eventually we will make a complete data export of everything just to be able to debug customer clusters.
Could this be solved differently? VPN access? Customer OPS training?
Ping @cristiklein @llarsson @elastisys/sme

I've not yet looked into the specifics, but this looks more and more like we are starting to export everything which we usually get access to by having access to the clusters and the dashboards themselves. It does not sounds feasible that we continue down this road as eventually we will make a complete data export of everything just to be able to debug customer clusters.
Could this be solved differently? VPN access? Customer OPS training? Ping @cristiklein @llarsson @elastisys/sme

Thanks @simonklb. Actually, we discussed this in a meeting before summer, the meeting notes are linked in the issue (please let me know if you don't have access to it). Generally speaking, we aim to be able to support customers even those who are running air-gapped environments, and some of them might need to limit our access. That's why we are trying improve diagnostic script in such way.

If yes, can you make sure that we have proper documentation in public docs and/or in usage script?

As it is now, it is always enabled if thanos is enabled. Thought it was such a small thing anyways. Should I change that?

If yes, can you make sure that we have proper documentation in public docs and/or in usage script?

As it is now, it is always enabled if thanos is enabled. Thought it was such a small thing anyways. Should I change that?

I'm not sure about the impacts that it might have on our security promises. Do you have any input on this @cristiklein?

I'm not sure about the impacts that it might have on our security promises. Do you have any input on this @cristiklein?

For some context, you need the ServiceAccount token in order to get access by the kubernetes API. Which means the person running the diagnostics scripts needs access to describe secrets in the thanos namespace in order to even get past kube api. So in my opinion I did not feel it opened up any new security issues.

Right, I was mainly thinking about  creating SA (I believe it's a quick procedure), and then get the data and then delete the created resources when calling diagnostic script. The main idea is to close everything unless you need it.
But I see your point, it might not have any drastic impact. But I would love to see what @OlleLarsson and @cristiklein think about it.

Changed to separate commands.
Changed token to oidc-login and removed the SA/rbac chart.
PTAL


Archlinux 登录服务器日志显示不存在的用户

Please read the instruction and answer the following questions before submitting your issue. Thank you.
Please answer all the questions with enough information. All issues not following this template will be closed immediately.
If you are not sure if your question is truely a bug in V2Ray, please discuss it here first.

What version of V2Ray are you using (If you deploy different version on server and client, please explicitly point out)?
last version

What's your scenario of using V2Ray? E.g., Watching YouTube videos in Chrome via Socks/VMess proxy.
vmess ws tls nginx

What did you see? (Please describe in detail, such as timeout, fake TLS certificate etc)
安卓v2ray ng win客户端 全部都能使用，但是archlinux用同样的config.json 连不上！服务器端显示 不存在的用户

What's your expectation?

Please attach your configuration file (Mask IP addresses before submit this issue).

Server configuration:
    // Please attach your server configuration here.

Client configuration:
    // Please attach your client configuration here.

Please attach error logs, especially the bottom lines if the file is large. Error log file is usually at /var/log/v2ray/error.log on Linux.

Server error log:
    // Please attach your server error log here.

Client error log:
    // Please attach your client error log here.

Please attach access log. Access log is usually at '/var/log/v2ray/access.log' on Linux.

    // Please attach your server access log here.

Other configurations (such as Nginx) and logs.

If V2Ray doesn't run, please attach output from --test.

The command is usually /usr/bin/v2ray/v2ray --test --config /etc/v2ray/config.json, but may vary according to your scenario.

If V2Ray service doesn't run, please attach journal log.

Usual command is journalctl -u v2ray.
Please review your issue before submitting.

server
2019/12/22 09:34:26 [Info] [1556717838] v2ray.com/core/app/proxyman/inbound: connection ends > v2ray.com/core/proxy/vmess/inbound: invalid request from <IP_ADDRESS>:40974 > v2ray.com/core/proxy/vmess/encoding: invalid user 2019/12/22 09:34:27 [Info] [2092320435] v2ray.com/core/app/proxyman/inbound: connection ends > v2ray.com/core/proxy/vmess/inbound: invalid request from <IP_ADDRESS>:40976 > v2ray.com/core/proxy/vmess/encoding: invalid user 2019/12/22 09:34:27 [Info] [1231521234] v2ray.com/core/app/proxyman/inbound: connection ends > v2ray.com/core/proxy/vmess/inbound: invalid request from <IP_ADDRESS>:40980 > v2ray.com/core/proxy/vmess/encoding: invalid user 2019/12/22 09:34:31 [Info] [1571260656] v2ray.com/core/app/proxyman/inbound: connection ends > v2ray.com/core/proxy/vmess/inbound: invalid request from <IP_ADDRESS>:41008 > v2ray.com/core/proxy/vmess/encoding: invalid user 2019/12/22 09:34:31 [Info] [2413321782] v2ray.com/core/app/proxyman/inbound: connection ends > v2ray.com/core/proxy/vmess/inbound: invalid request from <IP_ADDRESS>:41034 > v2ray.com/core/proxy/vmess/encoding: invalid user 2019/12/22 09:34:54 [Info] [828792322] v2ray.com/core/app/proxyman/inbound: connection ends > v2ray.com/core/proxy/vmess/inbound: invalid request from <IP_ADDRESS>:41078 > v2ray.com/core/proxy/vmess/encoding: invalid user 2019/12/22 09:34:54 [Info] [2889290407] v2ray.com/core/app/proxyman/inbound: connection ends > v2ray.com/core/proxy/vmess/inbound: invalid request from <IP_ADDRESS>:41080 > v2ray.com/core/proxy/vmess/encoding: invalid user 2019/
019/12/22 09:37:38 <IP_ADDRESS>:41236 rejected v2ray.com/core/proxy/vmess/encoding: invalid user 2019/12/22 09:37:38 <IP_ADDRESS>:41238 rejected v2ray.com/core/proxy/vmess/encoding: invalid user 2019/12/22 09:37:55 <IP_ADDRESS>:41242

client
failed to process outbound traffic > v2ray.com/core/proxy/vmess/outbound: connection ends > v2ray.com/core/proxy/vmess/outbound: failed to read header > v2ray.com/core/proxy/vmess/encoding: failed to read response header > websocket: close 1000 (normal) 2019/12/22 09:34:00 [Warning] [1978316095] v2ray.com/core/app/proxyman/outbound: failed to process outbound traffic > v2ray.com/core/proxy/vmess/outbound: connection ends > v2ray.com/core/proxy/vmess/outbound: failed to read header > v2ray.com/core/proxy/vmess/encoding: failed to read response header > websocket: close 1000 (normal) 2019/12/22 09:34:00 [Warning] [3363322375] v2ray.com/core/app/proxyman/outbound: failed to process outbound traffic > v2ray.com/core/proxy/vmess/outbound: connection ends > v2ray.com/core/proxy/vmess/outbound: failed to read header > v2ray.com/core/proxy/vmess/encoding: failed to read response header > websocket: close 1000 (normal) 2019/12/22 09:34:00 [Warning] [3069663252] v2ray.com/core/app/proxyman/outbound: failed to process outbound traffic > v2ray.com/core/proxy/vmess/outbound: connection ends > v2ray.com/core/proxy/vmess/outbound: failed to read header > v2ray.com/core/proxy/vmess/encoding: failed to read response header > websocket: close 1000 (normal) 2019/12/22 09:34:00 tcp:<IP_ADDRESS>:51338 accepted tcp:lh3.googleusercontent.com:443 [out-0] 2019/12/22 09:34:00 tcp

换成安卓客户端 日志如下
ot@m:~# tail /var/log/v2ray/access.log
2019/12/22 09:41:13 <IP_ADDRESS>:41680 accepted tcp:app-measurement.com:443 [direct]
2019/12/22 09:41:14 <IP_ADDRESS>:41684 accepted tcp:aweme-swan.snssdk.com:443 [direct]
2019/12/22 09:41:15 <IP_ADDRESS>:41688 accepted tcp:szshort.weixin.qq.com:80 [direct]
2019/12/22 09:41:15 <IP_ADDRESS>:41690 accepted tcp:<IP_ADDRESS>:80 [direct]
2019/12/22 09:41:16 <IP_ADDRESS>:41696 accepted tcp:www.google.com:80 [direct]
2019/12/22 09:41:17 <IP_ADDRESS>:41700 accepted udp:<IP_ADDRESS>:443 [direct]
2019/12/22 09:41:26 <IP_ADDRESS>:41702 accepted udp:<IP_ADDRESS>:53 [direct]
2019/12/22 09:41:26 <IP_ADDRESS>:41704 accepted tcp:adash.man.aliyuncs.com:80 [direct]
2019/12/22 09:41:48 <IP_ADDRESS>:41712 accepted udp:<IP_ADDRESS>:53 [direct]
2019/12/22 09:41:48 <IP_ADDRESS>:41714 accepted tcp:www.google.com:443 [direct]

windows 下测试也是正常的 搞不明白archlinux 哪里不对

时间

时间

好的 那我搞个ntp 试试

closed
把时间搞了下来就一切正常了 ！忽视这个问题了！坑死我了！


[Feature Request] colorize styles target

Context

[X] This issue is not a bug report. (please use a different template for reporting a bug)
[X] This issue is not a duplicate of an existing issue. (please use the search to find existing issues)

Description
I am using monaco.editor.colorize to colorize text and set the result to an element in iframe (I tried monaco.editor.colorizeElement but it fails for nodeValue is null, so I just need to pass innerText instead and set innerHTML with the result).
The colorization seems to set monaco-colors style on the document the script is called from, however, I need it to apply to the iframe where I use the colorized HTML.
I suggest that either a document instance can be passed to the API to which the styles will be added, or the styles are returned as a part of the API result.
My current workaround is to take the monaco-colors style element inside the promise handler from the call-site document and insert it in the iframe document.
Monaco Editor Playground Link
No response
Monaco Editor Playground Code
No response

Looks like #3627 might be related


Fix Japanese translation of update message

This PR has fixed the Japanese translation of the update message.
"check-updates" and "update-all" were reversed, so I fixed it.

@ibuki2003 Thanks for your contribution 🙇🏻♂


No function to select source in Samsung Soundbar MS650

Until a few days ago everything worked fine. Thank you for the great integration.
Unfortunately, the "select source" function has now been lost.
It is also not possible to choose the source with a service.

Logger: homeassistant.helpers.entity
Source: custom_components/smartthings_soundbar/api.py:43
First occurred: 23:25:18 (127 occurrences)
Last logged: 23:49:24

Update for media_player.soundbar fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 278, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 474, in async_device_update
    raise exc
  File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/smartthings_soundbar/media_player.py", line 76, in update
    SoundbarApi.device_update(self)
  File "/config/custom_components/smartthings_soundbar/api.py", line 43, in device_update
    device_source = data['main']['inputSource']['value']
KeyError: 'inputSource'

This looks exactly like the problem I reported a bit earlier:
https://github.com/PiotrMachowski/Home-Assistant-custom-components-SmartThings-Soundbar/issues/6
If it used to work, and stopped working recently, could this be a result of the recent security changes that was implemented in regards to custom components?

This looks exactly like the problem I reported a bit earlier:
https://github.com/PiotrMachowski/Home-Assistant-custom-components-SmartThings-Soundbar/issues/6
If it used to work, and stopped working recently, could this be a result of the recent security changes that was implemented in regards to custom components?

I will close this issue as a duplicate of #6.
No, it seems to be a change in SmartThings API

I will close this issue as a duplicate of #6.
No, it seems to be a change in SmartThings API

I have inspected data sent by @am1ter and it seems that it is now missing mediaInputSource capability. You can try removing your device from SmartThings and adding it again.
Expected capabilities:
['ocf', 'execute', 'refresh', 'switch', 'audioVolume', 'audioMute', 'audioTrackData', 'mediaInputSource', 'mediaPlayback', 'audioNotification', 'samsungvd.groupInfo']

Actual capabilities:
['ocf', 'execute', 'refresh', 'switch', 'audioVolume', 'audioMute', 'mediaPlayback', 'audioNotification']

I have inspected data sent by @am1ter and it seems that it is now missing mediaInputSource capability. You can try removing your device from SmartThings and adding it again.
Expected capabilities:
['ocf', 'execute', 'refresh', 'switch', 'audioVolume', 'audioMute', 'audioTrackData', 'mediaInputSource', 'mediaPlayback', 'audioNotification', 'samsungvd.groupInfo']

Actual capabilities:
['ocf', 'execute', 'refresh', 'switch', 'audioVolume', 'audioMute', 'mediaPlayback', 'audioNotification']

@PiotrMachowski thank you for analyze. I tried to remove and add soundbar to SmartThings but it didn't help. Such functions as turnon/turnoff, mute, source selection don't work.
Looking at all MS650 users should wait update of smart things api.
So I found another custom component based on samsung multiroom technology, forked it and made some fixes for my soundbar.

@PiotrMachowski thank you for analyze. I tried to remove and add soundbar to SmartThings but it didn't help. Such functions as turnon/turnoff, mute, source selection don't work.
Looking at all MS650 users should wait update of smart things api.
So I found another custom component based on samsung multiroom technology, forked it and made some fixes for my soundbar.

@am1ter you can also try to combine different media_player entities using universal media player

@am1ter you can also try to combine different media_player entities using universal media player

Any change on this soundbar?


az ssh gives error NoneType object has no attribute name

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az ssh vm Extension Name: ssh. Version: 1.1.3.
Errors:
Paste here the error message you have received. Make sure to remove all sensitive information,
such as user name, password, credential, subscription ID, etc.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az ssh vm --port {} -n {} -g {} {}

Expected Behavior
Environment Summary
Linux-5.4.0-137-generic-x86_64-with-glibc2.31, Ubuntu 20.04.5 LTS
Python 3.10.10
Installer: DEB

azure-cli 2.47.0

Extensions:
ssh 1.1.3

Dependencies:
msal 1.20.0
azure-mgmt-resource 22.0.0

Additional Context

Thank you for opening this issue, we will look into it.

@sudeeprp Thanks for reaching out to us and reporting this issue. Could you please run the same command with--debugparameter and share the complete error output ? Awaiting your reply.

Same error on MacOS 13.3 with version 2.47.0 installed with brew
CMD-LOG-LINE-BEGIN 23149 | 2023-04-05 09:20:21,907 | INFO | az_command_data_logger | command args: ssh vm --resource-group {} --vm-name {} --debug CMD-LOG-LINE-BEGIN 23149 | 2023-04-05 09:20:21,988 | INFO | az_command_data_logger | extension name: ssh CMD-LOG-LINE-BEGIN 23149 | 2023-04-05 09:20:21,988 | INFO | az_command_data_logger | extension version: 1.1.2 CMD-LOG-LINE-BEGIN 23149 | 2023-04-05 09:20:22,573 | ERROR | az_command_data_logger | The command failed with an unexpected error. Here is the traceback: CMD-LOG-LINE-BEGIN 23149 | 2023-04-05 09:20:22,579 | ERROR | az_command_data_logger | 'NoneType' object has no attribute '__name__' Traceback (most recent call last):   File "/opt/homebrew/Cellar/azure-cli/2.47.0/libexec/lib/python3.10/site-packages/knack/cli.py", line 233, in invoke     cmd_result = self.invocation.execute(args)   File "/opt/homebrew/Cellar/azure-cli/2.47.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute     raise ex   File "/opt/homebrew/Cellar/azure-cli/2.47.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially     results.append(self._run_job(expanded_arg, cmd_copy))   File "/opt/homebrew/Cellar/azure-cli/2.47.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job     result = cmd_copy(params)   File "/opt/homebrew/Cellar/azure-cli/2.47.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__     return self.handler(*args, **kwargs)   File "/opt/homebrew/Cellar/azure-cli/2.47.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler     return op(**command_args)   File "/Users/omar/.azure/cliextensions/ssh/azext_ssh/custom.py", line 65, in ssh_vm     _do_ssh_op(cmd, ssh_session, op_call)   File "/Users/omar/.azure/cliextensions/ssh/azext_ssh/custom.py", line 154, in _do_ssh_op     op_info.ip = op_info.ip or ip_utils.get_ssh_ip(cmd, op_info.resource_group_name,   File "/Users/omar/.azure/cliextensions/ssh/azext_ssh/ip_utils.py", line 17, in get_ssh_ip     network_client = client_factory.get_mgmt_service_client(cmd.cli_ctx, profiles.ResourceType.MGMT_NETWORK)   File "/opt/homebrew/Cellar/azure-cli/2.47.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/client_factory.py", line 83, in get_mgmt_service_client     client, _ = _get_mgmt_service_client(cli_ctx, client_type, subscription_id=subscription_id,   File "/opt/homebrew/Cellar/azure-cli/2.47.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/client_factory.py", line 220, in _get_mgmt_service_client     logger.debug('Getting management service client client_type=%s', client_type.__name__) AttributeError: 'NoneType' object has no attribute '__name__' CMD-LOG-LINE-BEGIN 23149 | 2023-04-05 09:20:22,579 | INFO | az_command_data_logger | exit code: 1

@sudeeprp I see that you are using an older version of the ssh extension. Could you please update to the most recent version  (1.1.5) by running the below command and check again ?

az extension update -n ssh

@sudeeprp I see that you are using an older version of the ssh extension. Could you please update to the most recent version (1.1.5) by running the below command and check again ?

az extension update -n ssh

that solved my problem


Restore compatibility of Log4j API

This restores backward compatibility of log4j-api from a user's perspective and adds comments to classes that should not have breaking changes.
I have checked all the types in org.apache.logging.log4j and those reachable through inheritance or signature of public methods in other packages:
org.apache.logging.log4j.message.EntryMessage
org.apache.logging.log4j.message.ExitMessage
org.apache.logging.log4j.message.FlowMessage
org.apache.logging.log4j.message.FlowMessageFactory
org.apache.logging.log4j.message.Message
org.apache.logging.log4j.message.MessageFactory
org.apache.logging.log4j.spi.LoggerContext
org.apache.logging.log4j.spi.ExtendedLogger
org.apache.logging.log4j.spi.LoggerContextFactory
org.apache.logging.log4j.spi.LoggerRegistry
org.apache.logging.log4j.spi.StandardLevel
org.apache.logging.log4j.spi.ReadOnlyThreadContextMap
org.apache.logging.log4j.util.BiConsumer
org.apache.logging.log4j.util.ReadOnlyStringMap
org.apache.logging.log4j.util.StringMap
org.apache.logging.log4j.util.StringBuilderFormattable
org.apache.logging.log4j.util.Supplier
org.apache.logging.log4j.util.TriConsumer

The only breaking changes I found are Logger#entry/exit and in MarkerFactory. I believe we should restore them and have a 100% binary compatibility with 2.x, rather then breaking BC for almost nothing.
This PR also adds forRemoval to all the classes that where deprecated in 2.x, but not removed in 3.x.
Part of #2163

I have removed the two deprecated MarkerFactory#getMarker methods, since they were deprecated in April 2014, i.e. before the release of 2.0. IMHO we should treat them as if they never existed in the 2.x branch.


Don't force babel usage everywhere

For debugging, babel is a problem since the generated code is sometimes not relatable to the original one and makes debugging very difficult.

How easy is to disable it in your local environment?

On top of that, unit test times have increased from 3.7 seconds to 13.6 seconds

We have removed babel from build:dev

This is still happening when using build:watch and in gh-pages

@davidmanzanares:

build:watch just uses the development mode, without babel, as it was before (PR https://github.com/CartoDB/carto-vl/pull/1044 reverted that AND also fixed devtool param with 'source-map'). what's the error it presents?
with "gh-pages" do you refer to ghpublish task? it uses inside yarn build which launches both dev and min builds... what is expected from the build:dev?

Hmu...
Maybe I was in an outdated branch that didn't get your commits yet, sorry.


Disabled date off by 1 month

If you go to the example page, https://amsul.ca/pickadate.js/date/ it gives the example of
$('.datepicker').pickadate({
disable: [
[2015,3,3],
[2015,3,12],
[2015,3,20]
]
})
Yet if you click on the date picker it shows that April (the 4th month of the year) not March (the 3rd month of the year) date's are disabled. What's the deal with this?!?! I am having the same issue with my code, if I input [2019,8,19] it displays Sept 19th 2019 as disabled.

Closing as this is documented and excepted.


LANG and LC_CTYPE env variables cause many issues with unicode chars

Hyperterm sets LANG variable in app/session.js, but the way we are doing it creates some problems.
Since LC_CTYPE inherits from LANG variable, if the locale name returned by app.getLocale() is not an XPG syntax described by gnu.org here (LANGUAGE_TERRITORY.CHARSET) and it's not found in locales list locale -a, shell will fail with some unicode special chars, causing issues like #183, #597, #441 and probably #589.
I also noticed that, if locale is not set correctly like described above, alt key is used as metakey, despite hterm 'alt-sends-what' is set to 'browser-key' here.
A temporary workaround is to manually set the right locale for you in your .bashrc/.zshrc: for me it's export LANG=it_IT.UTF-8.
Hope it helps 😄

The workaround solves my issue #589.
I have set the LANG-Variable to de_DE.UTF-8 in my fish config (was de.UTF-8) and it helped.

A temporary workaround is to manually set the right locale for you in your .bashrc/.zshrc: for me it's export LANG=it_IT.UTF-8.

Not fully worked for me with locale ru_RU.
Hyper version 0.8.3.
I checked the locale:
$ locale
locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: ?????????? ?????????? LC_ALL ? ?????? ?? ?????????.: ??? ?????? ????? ??? ????????
LANG=ru_RU.UTF-8
LANGUAGE=ru_RU
LC_CTYPE=ru.UTF-8
LC_NUMERIC="ru_RU.UTF-8"
LC_TIME="ru_RU.UTF-8"
LC_COLLATE="ru_RU.UTF-8"
LC_MONETARY="ru_RU.UTF-8"
LC_MESSAGES="ru_RU.UTF-8"
LC_PAPER="ru_RU.UTF-8"
LC_NAME="ru_RU.UTF-8"
LC_ADDRESS="ru_RU.UTF-8"
LC_TELEPHONE="ru_RU.UTF-8"
LC_MEASUREMENT="ru_RU.UTF-8"
LC_IDENTIFICATION="ru_RU.UTF-8"
LC_ALL=

I saw that the variable LC_CTYPE is set incorrectly.
So for me, a working version was like this:
export LANG=ru_RU.UTF-8
export LC_CTYPE=ru_RU.UTF-8

Put this to your .bashrc or .zshrc

Works for me as well had locale errors when using ssh client

Hi guys, I had the same issue, here's what I did to fix it (no é, è, à, ù, etc characters were well displayed) :
Made sure my library language is installed: sudo install language-pack-fr-base (for french)
Then, allowed Ubuntu to automatically configure it: sudo dpkg-reconfigure locales
Finally: export LC_ALL="fr_FR.utf-8"
Hope it helps!

this also causes problems with ssh tab-completion.


security_context: do not rely on /etc/hosts

It depends on runtime and CNI plugin used when testing. This patch uses
/etc/passwd which should be always available instead.
@feiskyer @Random-Liu @mrunalp @sameo  PTAL
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

:+1:

You really should rely on /, which is the only thing guaranteed to be in the container.  :^)

You really should rely on /, which is the only thing guaranteed to be in the container. :^)

changed to / - thanks Dan

lgtm

@runcom LGTM. Thanks for the fix.


Update Gitignore

@assyahid Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

build was already ignored.


ExecutionEffort and Computation is not the same in the stable cadence emulator

Instructions
Please fill out the template below to the best of your ability and include a label indicating which tool/service you were working with when you encountered the problem.
Problem
Feed decuted event looks like this
Fields: map[string]interface {}{
        "amount": 1e-05,
        "executionEffort": 2.9e-07,
        "inclusionEffort": 1.0,
      },

so 29 effort
Meters reported looks like this

map[string]interface {}{
  "computationIntensities": map[string]interface {}{
    "1001": 5.0,
    "1003": 5.0,
    "1025": 2.0,
    "1026": 96.0,
    "1080": 250.0,
    "2005": 1.0,
    "2011": 1.0,
    "2014": 1.0,
    "2015": 1.0,
    "2016": 1.0,
    "2020": 2286.0,
    "2022": 1.0,
    "2026": 270.0,
    "2034": 3.0,
    "2036": 1.0,
  },
  "computationUsed": 31.0,
  "ledgerInteractionUsed": 97269.0,
  "memoryEstimate": 149745.0,
  "memoryIntensities": map[string]interface {}{
    "1": 7.0,
    "100": 6.0,
    "102": 5.0,
    "103": 694.0,
    "105": 376.0,
    "106": 2.0,
    "107": 244.0,
    "108": 30.0,
    "109": 13.0,
    "11": 1.0,
    "110": 8.0,
    "111": 11.0,
    "112": 8.0,
    "115": 20.0,
    "116": 24.0,
    "117": 27.0,
    "119": 8.0,
    "12": 2.0,
    "120": 4.0,
    "127": 9.0,
    "128": 1.0,
    "129": 1.0,
    "13": 1.0,
    "130": 8.0,
    "131": 4.0,
    "133": 12.0,
    "137": 5.0,
    "138": 1.0,
    "139": 4.0,
    "14": 3.0,
    "140": 4.0,
    "147": 4.0,
    "148": 7.0,
    "149": 1.0,
    "15": 8.0,
    "151": 2.0,
    "153": 108.0,
    "154": 23.0,
    "155": 38.0,
    "156": 2.0,
    "158": 1.0,
    "159": 19.0,
    "16": 5.0,
    "162": 1.0,
    "165": 3.0,
    "166": 1.0,
    "17": 1.0,
    "172": 29.0,
    "173": 1.0,
    "174": 2.0,
    "176": 8.0,
    "177": 2236.0,
    "178": 1176.0,
    "179": 2.0,
    "18": 8.0,
    "180": 12.0,
    "181": 8.0,
    "182": 9.0,
    "187": 5.0,
    "19": 5.0,
    "23": 5.0,
    "24": 0.0,
    "25": 161.0,
    "30": 2.0,
    "31": 2.0,
    "32": 8.0,
    "34": 2.0,
    "39": 3.0,
    "4": 88.0,
    "41": 8.0,
    "5": 6.0,
    "7": 5.0,
    "8": 4.0,
    "9": 1.0,
    "94": 1034.0,
    "95": 5.0,
    "96": 284.0,
    "97": 11.0,
    "98": 2.0,
  },
}

so this reports 31
These should be the same should the not?
Steps to Reproduce
Run a transaction against the emulator with the relevant version
github.com/onflow/flow-emulator v0.59.1-0.20231218185945-9116c416533f
Acceptance Criteria
Effort and computation are the same.
Context
I am trying to update overflow to this code and I see that the emulator is reporting different numbers for FeesDeducted and computationUsed, is that exepected? because it has not been like that before this versio

I see the same in 0.59.0 of emulator

I'm trying t understand this better and I'm replicating the scenario, but I'm missing something.

I got the emulator at commit 9116c41
run it with go run ./cmd/emulator --transaction-fees=true --verbose
send a tx with flow transactions send <(echo """transaction{prepare(s : &Account){ var i = 0;while i < 10000 {i=i+1}}}""") --signer emulator-account
the resulting event has executionEffort (UFix64): 0.00000478
which matches the emulator output: DBG ⭐  Transaction executed                      computationUsed=478 memoryEstimate=25369033 txID=b5b11e587630d03db246596381739b35cafff3a147e84fb6497e397b6f96cd0a

But I'm not sure at which point the meter output.

never mind, figured out whats going on after I manually enabled logging the computation intesities. Yeah https://github.com/onflow/flow-emulator/pull/543 will fix this.


chore: re-implementing pod circ dep fix

chore(pod): re-implementing pod circ dep fix
Reimplementing a pod circular dependency fix that was accidentally removed during a previous merge conflict resolution.  This deletes an unused method and gets rid of
import { PodCommandFactory } from "./PodCommandFactory";

Pull Request Checklist
If this is your first time submitting a pull request to Dendron, copy and paste the full Dendron Review Checklist into this request and check off each item as necessary.
This template contains the short checklist which is used by the Dendron core team.
Testing

[ ] Write Tests
[ ] Confirm existing tests pass
[ ] Confirm manual testing
[ ] If your tests changes an existing snapshot, make sure that snapshots are updated
[ ] If you are adding a new language feature (graphically visible in VS Code/preview/publishing), make sure that it is included in the test workspace

Docs

[ ] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Analytics

[ ] if you are adding analytics related changes, make sure the Telemetry docs are updated

pkg.plugin-core.t.pods.ref.export-pod

Good catch - updated!


Fix scroll up button

scroll up button loaded a lot like a bug

fixed the location not dynamically generating


[FEATURE] Combat Items

Description
In the current state of the game no weapons and buffs/debuffs exist for players, enemies and the game environment. As a team we need to design and implement the basic functionality of weapons and buffs/debuffs for players, enemies and the game environment. For sprint one we aim to design the basic level of weapons and it buffs/debuffs for a player and its enemies. For the environment we aim for the weapon and its buff/debuff to be able to be dropped and picked up. This feature will involve multiple combat items for the player, NPCs and the environment. Combat items will consist of but will not be limited to weapons, buffs/debuffs, relics and runes. These items are essential and will play a role in determining whether the player wins or loses and contribute to game progression. Weapons should be able to be picked up by players and dropped by players. Should players wish to be more creative, they are able to craft their own combat items provided they have enough available resources. Buffs/debuffs, relics and runes will also be added as they provide necessary variety to the game. This makes the game more versatile and encourages continuous learning in an engaging and interactive manner.
SubFeature/component (optional)
Weapons

Melee weapons, each weapon will have different stats like damage, cooldown and weight.

Basic Dagger
Basic Trident
Basic Sword

These weapons are ‘Level 1’ or basic, which are the weakest weapons in the evolution tree; dealing less damage.
Enemies weapon design will be created in collaboration with the enemies team
Weapons can be dropped and picked up in the environment.
Buffs (icons and animation) to

Additional strength to the weapon
Attack Speed
Damage inflicted on player over time

Debuffs

Slowed attacks
Reduced Damage

Examples (optional)

Player wishes to interact with a sword that has been dropped onto the ground. As they hover over the item, an active description of the sword appears showing a brief description of it. Within the description, it displays how the sword should be utilised as well as the status of it specifically regarding any DPS and any buffs that has applied to that weapon. Lastly, there will be a brief description of the background story of the combat item for further immersion of the game environment.

Dependencies
In the creation of our features, we will need to consult with the following teams/classes:

Enemies

Discuss with enemy team whether they will have a drop combat item on death effect or if they will even include an inventory for the enemies; consult with design of enemies

Player

Interaction with player class will be required as we will need to consider when/if curses are created

Map/ Environment

Items spawning into the game will require our design

Our class will most likely rely on classes such as the enemy class since enemies have the capability of dropping items on death. As for the map and environment dependencies, it will impact the way ranged items are being utilised within our class.
Note: The design needs for enemies and players there needs to be significant differentiation between their items.
Milestones
List of sub-features you intend to have done, and in Main, before the end of the sprint.

[ ] Designs completed for all 3 weapons (Due: 21st of August)
[ ] Designs completed for buffs and debuffs (Due: 23rd of August)
[ ] Design completed for aurora around weapon (Due: 26th August)
[ ] Create weapon class and appropriate subclasses (Due: 23rd of August)
[ ] Create aura (buffs, debuffs, curses) class with the appropriate subclasses (Due: 17th of August)
[ ] Integrate graphics/GUI (Due: Sun 27th)
[ ] Successful integration of graphics into the game  (Due: 26th of August)
[ ] Successful push of compilation of local code into main branch repository (Due: Sun 27th)

Completion Deadline: Aug. 30
Extras (optional)
Extra components that you may implement if you get the time

[ ] Animations
[ ] Curses (A buff plus debuff) -> inside Alchemist/potion?
[ ] Weapon Skins (flashy animations/ effects - probably sprint 2 or 3 item?)

Documentation
Coming soon
Members
Lachlan Benson, @LachlanBenson
Caleb Ang, @PurrplePandaa
Nisha Vashist, @NishaVashist0
Madi Feddema, @madifeddema
Eugene Chong, @eugene2341

@BozenX @notalie

looks good!


Updated dockerfile to fix build failure

Updated Dockerfile to fix build failure.

This issue is fixed with bitnami/tomcat version.
Able to build docker image without making any changes to dockerfile


Test and extract create player from SolGame

This PR moves player creation out of SolGame. The current class does still do a bit too much but at least it is tested and easier to understand.
Sidenotes for review:

I added assertj for assertions, if we don't want to add this dependency I can replace the fluent assertions with old assertEquals.
I had to remove final from HullConfig as the class alone is not instanciable and with final not able to mock. The cleaner solution would be to replace the class access with an interface and keep the backing up class final. This would involve chaning all calling places (~130) to the new interface which is something I did not want to include in this PR. The class as-is is still immutable however it could be extended and then break but that may be a bit esotheric depending how often we extend in destsol :)
Can be reviewed commit-wise. I prepared the method for extraction first without changing the controlflow, then put it under test and refactored everything after the tests were in place without touching the tests again. Also did a short manual test session with respawn, reload and hiring a mercenary then reloading with him.

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

I'd like to move forward with merging this commit-epic PR, any objections or review desires? :-)

Hooray Jenkins reported success with all tests good!

I have resolved the merge conflicts and am merging this now :)


Possible to add a space in a custom Pattern State name?

For readability's sake, it'd be nice to have it say "In QA", vs "inqa". Nit picky, I know, just thought I'd ask.

Nevermind, I just answered my own question. Looks like miraculously it doesn't bork when you add a space! My custom styling isn't working as expected, but that's okay, I'm just happy I get my spaces. :)


add getattribute to gf.Component

This is without a doubt the grossest hack I probably ever did in a public repo.
Probably should use https://github.com/jayphelps/git-blame-someone-else
@joamatab
@tvt173

If we do something like this, wouldn't it be cleaner to just implement it as a property?

If we do something like this, wouldn't it be cleaner to just implement it as a property?

If we were to do that, we would have to handle each property on it's own afaik. And the setter also as otherwise c.xmin=5 will set it to 0.005um but getter will report 0.005.
So I think for migration purposes the getattribute is cleaner.

Maybe properties on Instance would make more sense, but I am not sure.  But this would work on Instances as well now.

Added migration script used with
gf migrate --migration 7to8 <input_folder/file> <output_folder/file> to write to a new folder
gf migrate -i --migration 7to8 <input_folder/file> or gf migrate --inplace --migration 7to8 <input_folder/file> for in-place migration

looks great! thank you Sebastian!


chore(release): v0.8.2 🎉

:robot: I have created a release beep boop
0.8.2 (2024-07-27)
Bug Fixes

practs: bump practs to latest best (18937d9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ehmpathy/sql-dao-generator/releases/tag/v0.8.2 :sunflower:


Make the navigation bar sticky at the top.

I would like to work on this issue.

@Pranav016 My marks for this issue is not reflected at JWOC leaderboard.

@Pranav016 My marks for this issue is not reflected at JWOC leaderboard.

Ok, I'll look into it


Fix timings in e2e tests

Motivation
Fix flaky tests in activation/e2e. Test would randomly fail with the NIPostBuilder failing to fetch a poet proof.
Changes

ensure that the spawned PoET and the nipost builder use the same genesis time instead of time.Now()
update PoET config to ensure that there is enough time to fetch a proof from PoET and retry in case PoET is slightly slow to generate the proof and the first request by NIPostBuilder fails

Test Plan
n/a
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge


JCSDA/soca develop not up to date with JCSDA-internal/soca develop

I noticed that JCSDA/soca develop branch hasn't been updated since November 5.
For other repos we have some hooks that were set up by Mark to keep develop up-to-date between JCSDA and JCSDA-internal. I wonder if that wasn't turned on for soca.

Thanks for letting us know @shlyaeva .

I think this is resolved now; closing.


ES+ Types

I'm curious if there is an interest in adding support for Symbol in check.primitive as well as types enabled by Symbol, like iterator.

Sure, not a bad idea, but hard to test across multiple Node versions though

Wouldn't check.primitive just become:
function primitive(value) {
    var type = typeof value;
    return type === 'number' ||
      type === 'boolean' ||
      type === 'string' ||
      type === 'symbol';
  }

Yup, but testing it?

A conditional test should work (may even work with a polyfill at this level):
if (typeof Symbol === 'function') {
  la(check.primitive(Symbol('test')), 'symbol');
}


[SPARK-25556][SPARK-17636][SPARK-31026][SPARK-31060][FOLLOWUP][3.0] Fix build error due to conf version

What changes were proposed in this pull request?
This fixes the build error.
Why are the changes needed?
branch-3.0 doesn't have conf version.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Passing the GitHub Action is enough.

Test build #120461 has started for PR 28046 at commit 62201b0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25168/
Test PASSed.

cc @cloud-fan , @dbtsai , @HyukjinKwon

Thank you, @cloud-fan .
Since GitHub Action passed, I'll merge this to branch-3.0.

LGTM thanks @dongjoon-hyun for resolving the conflicts.

Test build #120461 has finished for PR 28046 at commit 62201b0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120461/
Test PASSed.

Thanks @dongjoon-hyun !!!


added RIN logo

Added RIN token
Contract Address: 0xd1508328e81d275e526c215697469c2c060f7ae3
Token Name: RIN
Token Symbol: RIN
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwallet.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp

For some reason, the contract address had to be changed from 0xd1508328e81d275e526c215697469c2c060f7ae3 to this 0x4bF62424385ddcD858535cAa1878e512314a9Aeb
What can we do to stop the old token from appearing in search?

Do you have a public note of changing contract address, to make sure we do not delist active contract?

https://twitter.com/ReliableIndex/status/1100109411094274049
Here is the public note

Thank you, we will delist it today.


Ability to get an Azure data center location from a subscription based on specific region

Subscription.getLocationByRegion(Region)

Can one of the admins verify this patch?


Implement gitignore for Plugins

Potentially we should also add a method or step to initialize a git repo.

Shouldn't the .gitignore be taken from the fastlane repo is some way, so that we don't have to maintain 2 files?

@KrauseFx I guess so, I guess add that to the scaffolding script? Know where in the code it should be added ?

This should be copied from the fastlane .gitignore, so we don't have to have duplicates 👍


Sometimes teleport image and loading images are displayed at the same time.

@marcosnc it's fixed in master

Can I close the ticket? do we need to link it in the next release?

fixed on this release #1672


Using an existing Github App

Hi,
Can an existing Github app be used for authentication instead of requiring a new app each time for different runners? Github imposes a limit of 20 apps per organization, and we have already reached it.
We want to provision several types of runners, i.e., AMD64/EC2, ARM64/EC2, and Fargate-based. However, it appears as if each runner-type stack requires its webhook and its keys.
Is it possible to re-use an existing Github App for multiple runners? Are there any workarounds or patterns that I might be missing?
Thanks for the great project and your assistance!

You can reuse the same app as long as it has a webhook per instance of GitHubRunners. But it should be much simpler to define all providers with the same GitHubRunners instance.

You can reuse the same app as long as it has a webhook per instance of GitHubRunners

I'm not sure if I understood your comment 100%, but I don't know if that's possible with GithubApps. As far as I can tell, Github apps can only have one webhook URL per App.

But it should be much simpler to define all providers with the same GitHubRunners instance.

Oops! Now that I read the documentation and my code in light of your comment, I don't know why I didn't see this before!!
Thank you so much for the quick response and for your assistance!

I'm not sure if I understood your comment 100%, but I don't know if that's possible with GithubApps. As far as I can tell, Github apps can only have one webhook URL per App.

Good point. You should be able to create normal non-app webhooks though. They should work as well.

Oops! Now that I read the documentation and my code in light of your comment, I don't know why I didn't see this before!!
Thank you so much for the quick response and for your assistance!

Perfect. Glad I could help.
FWIW I have never tried it or even considered, but it should technically be possible to define providers in different stacks to be used by the same GitHubRunners. I'm sure it's going to blow up in some spectacular manner I haven't thought of, but it might be an easy fix too.


[Build] Failed to minify

Step to Produce
~ npm run build

Actualy Happend
Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

        ./node_modules/react-mapbox-gl-draw/lib/index.js:6

i can't build my project

Hey, thanks for the issue!
I suppose your are using create-react-app, is that correct? If yes, which version of react-scripts? If no, can you paste your webpack config?
I just tried with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>and I can build without problem.

Not reproducible, closing. Please open again if this problem persists.


email

hi, yufeng:
I send a email to<EMAIL_ADDRESS>(Is this email accessible?) on 29, June， whose title is I M Avatar.  can you answer my question when you are free？
Thanks for your time!

replied.


Include guidelines for textareas

There are no visual examples of textareas on http://govuk-elements.herokuapp.com/form-elements/. As a result different services have included their own custom textarea styles for width and height resulting in inconsistencies across applications.
A standard textarea with class form-control inherits the 50% width desktop, 100% width mobile as per text inputs, but they seem to only be high enough to show 2 lines

There are visual examples of textareas here: http://govuk-elements.herokuapp.com/form-elements/example-form-elements/
Our recommendation would be to ensure that the textarea is sized according to the response required - so rather than make these a default recommended height - they can vary in height to best fit the response.
I'll ensure this guidance is added to the main form elements page, thanks for suggesting it.

Fab, thanks for getting back to me so quickly! I must have missed that page


CSS Font Family & Color

Choose a font family and text color

Font family and text color set. Also linked to Google Fonts in HTML.


Fix selection of application classes from test directory in native mode

Summary
QE TS daily build in native fails following FW bump. It's consequence of Quarkus Maven plugin build strategy where I didn't take into consideration that app classes selected via annotation (e.g. @QuarkusApplication(classes = ClassicResource.class)) can also come from src/test/java and not only src/main/java
Please check the relevant options

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[ ] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[x] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

run tests

OCP runs are green. I will merge it.


Filtering actions throw "too much recursion"

Issue Type
Bug report
Description
Every time the user clicks on the table header to sort the data, or writes something in the filter box (in the filterRow), or tries to apply a filter, an error saying "too much recursion" is thrown (tested in Firefox).
Steps to Reproduce
The simple interaction with filters.
Current Behavior
Every filter interaction throws the exception.
Expected Behavior
The normal filtering behaviour.
Demo
Stackblitz interactive demo
Local simple parcel-bundler demo
Environment Details

devextreme version: 18.1.6
devextreme-react version: 18.1.6-alpha.11
react version: 16.5.2

Hi,
As far as I understand, we addressed this issue in the context of the DataGrid - All the filtering actions throw "too much recursion" in React thread
Feel free to reactivate that thread in case of further difficulties.


Implement the base layouts in the wall

The base layouts are:

list: linear, similar to search results
masonry: a stacked view in which tweets are arranged in a brick like structure
centre of attraction with tweet stream: the latest tweet occupies a large area of the screen, with a smaller section for older tweets

Linear Layout:

Need to find a way to isolate the view.

@aneeshd16 Looks great so far, How about a small change, put the main hashtag in the center and the event name to the left side and put something like Powered by Loklak in the blue area at the right side with a smaller text, that'd give a beautiful UI UX when the sidebar is collapsed, Also, At the same time keep the right side of the grid like
| col-lg-8 | col-lg-4 |

We'll try to put up live visualizations over there to make the wall more attractive.

@sudheesh001 , i want to remove the sidebar and topbar altogether for the wall. It is not required when the wall is on.

@aneeshd16 I think opening this page with the sidebar collapsed by default should do well, the 3 bar icon is what many users know as menu and it'd be great to have the navigation there itself than to clutter the top navigation, Lets keep the top nav bar for the user profile and different other settings or notifications.
The default collapsed view would be perfect for organizations using our tweet wall to serve as an actual wall. This way we don't have to isolate or remove components, we'd be just using it in a different way, what do you think about that ?

I was basically aiming for this

Having a clean view without navigational links. When running in kiosk mode, on a big screen, navigation is not really necessary and adds some clutter. What do you think?

@sudheesh001 @aneeshd16 Let's think about the use case: The wall should work for logged in user and for anonymous users. You can have an event with several walls in different rooms and you want your tweet wall to be displayed everywhere. It is not necessary to login. How can we make this unique? How do others do this? On tweetwall.com they do a subdomain for example e.g. xyzevent.tweetwall.com. What can we do? How do we implement the configuration of the wall?

@mariobehling , since we are starting with only anonymous users, (Authenticated users are in milestone 2), I propose we put all the parameters in the URL.
/wall/display?eventName=abcd&mainHashtag=loklak...
The URL would look very messy, but since it will be running in full screen, it wont be visible.

@aneeshd16 That's exactly how I wanted it to be too. the right side instead of leaderboard lets have piecharts / other visualizations.
@mariobehling I think using /wall?event=fossasia&hashtag=fossasia would serve this purpose.
How about providing the wall with the functionality from the authenticated user to control the wall settings or use different widgets, One great plugin most conferences need is the Next speaker or Next Event/Workshop So yes, we need to decide on who controls the view of that page in case we wish to implement this, I suggest that the same wall have 2 seperate routes, one authenticated and one public, spewing out the same results to the end user but with differences of being authenticated.
/wall?event=fossasia&hashtag=fossasia for the wall thats being projected and a panel at wall/manage/?event=fossasia&hashtag=fossasia so that changes can be made. This probably aligns with @Orbiter in one of the discussions we were having on loklak_server on profanity filtering where he suggested that this option be given to the user/manager of the wall.

@aneeshd16 This is a nice feature, but how can I go back later and change the wall? I can do it in the URL, but most users won't be aware and know how to do it. Maybe something like an autohiding top bar would be good and a link "Wall Preferences".

Exactly. On the same page, there will be maybe a gear icon somewhere, which will lead back to the configuration screen.

@sudheesh001 Yes, we want widgets to choose from on the leaderboard. That is the idea. Regarding anonymous and logged in users. The wall is already defined through the URL. For logged in users we can have the option "save wall" and provide them with a shorter URL, that they can share.
So, for the question "who controls the view", it does not matter, cause it is defined in the URL.

so @aneeshd16 Are you suggesting that we offer the gear option for preferences for the application to any of the authenticated users or owner to one specific user ? Are we going to dedicate a specific /wall to a user so that only he/she can make the preference changes ?
Why not going for this instead ? /username/wall?
That way the wall can be accessed by the username and is registered to them whereas the same publicly can be accessed to /wall?event=

@aneeshd16 In the URL maybe instead of the eventname, we should have a unique ID number here. Also, we can also imagine a wall for other use cases, not just events. Think of advertising, company walls, sports etc.

Both authenticated and anon users will get the same wall and same url. Only difference will be that authenticated users will be able to save that URL with their account. How's that sound?

@aneeshd16 sounds good to me. And a future feature is a unique URL they can save as well.

@mariobehling , the string "Event Name" will not be displayed on the wall. Users can enter whatever they want in the eventName and even leave it blank.

For eg: If i enter "This is my wall" in eventName, it wont be displayed as
Event Name: This is my wall
It will be displayed only as
This is my wall.
In this way, the eventName field can contain the name of a brand, product, company or any other random string.
The field eventName should be renamed to something more intuitive to facilitate this.
2)For authenticated users, we can perhaps have a short url that redirects to the main url. For eg:
/wall/display?id=some_id will redirect to /wall/display?eventName=abcd&mainHashtag=loklak...

@aneeshd16

The question is then what is the unique URL? There must be one unique identifier in the URL. The unique identifier should be a number, that is generated in the system. Several different events, brands, products can have the same name in different countries. So the name should not be the unique identifier. I also prefer to avoid "eventName" as we are not only targetting events. If possible, just name it "name" or "id", please.
Is a feature, we should think in a separate thread. This can be a pro-feature as well.

Why do need an unique URL? If all the parameter fields are same, then the same wall will be displayed, irrespective of who creates it. And that is the desired result, I guess.
I think I am missing your point on this though :)

I was following other thoughts - that you generate an id based on the name of the event. Ok, got it now. Ok, good idea, excited to see the result!

Added a full screen button that toggles full screen view.
The wall config modal can be directly opened from the display page: https://github.com/loklak/loklak_webclient/issues/71#issuecomment-112652698

Can we close this? This has been solved by https://github.com/loklak/loklak_webclient/pull/191


test: unable to build bitbox01 emulator on Ubuntu 21.10

./setup_environment.sh --bitbox01
+ mkdir -p work
+ cd work
+ [[ -n '' ]]
+ [[ -n '' ]]
+ [[ -n '' ]]
+ [[ -n 1 ]]
+ '[' '!' -d mcu ']'
+ git clone --recursive https://github.com/digitalbitbox/mcu.git
Cloning into 'mcu'...
remote: Enumerating objects: 4950, done.
remote: Total 4950 (delta 0), reused 0 (delta 0), pack-reused 4950
Receiving objects: 100% (4950/4950), 4.07 MiB | 25.10 MiB/s, done.
Resolving deltas: 100% (3384/3384), done.
Submodule 'secp256k1' (https://github.com/digitalbitbox/secp256k1_patch.git) registered for path 'src/secp256k1'
Submodule 'src/yajl' (https://github.com/digitalbitbox/yajl.git) registered for path 'src/yajl'
Submodule 'hidapi' (https://github.com/digitalbitbox/hidapi.git) registered for path 'tests/hidapi'
Cloning into '/home/dev/HWI/test/work/mcu/src/secp256k1'...
remote: Enumerating objects: 4553, done.
remote: Total 4553 (delta 0), reused 0 (delta 0), pack-reused 4553
Receiving objects: 100% (4553/4553), 1.93 MiB | 17.18 MiB/s, done.
Resolving deltas: 100% (3175/3175), done.
Cloning into '/home/dev/HWI/test/work/mcu/src/yajl'...
remote: Enumerating objects: 2345, done.
remote: Total 2345 (delta 0), reused 0 (delta 0), pack-reused 2345
Receiving objects: 100% (2345/2345), 979.24 KiB | 549.00 KiB/s, done.
Resolving deltas: 100% (1339/1339), done.
Cloning into '/home/dev/HWI/test/work/mcu/tests/hidapi'...
remote: Enumerating objects: 2013, done.
remote: Total 2013 (delta 0), reused 0 (delta 0), pack-reused 2013
Receiving objects: 100% (2013/2013), 2.73 MiB | 9.98 MiB/s, done.
Resolving deltas: 100% (1177/1177), done.
Submodule path 'src/secp256k1': checked out '052b89166a8198f0310708ef4ece6b765b0000ea'
Submodule path 'src/yajl': checked out '1707633f0e479095765cef18691cb31b3e089613'
Submodule path 'tests/hidapi': checked out 'a6a622ffb680c55da0de787ff93b80280498330f'
+ cd mcu
+ mkdir -p build
+ cd build
+ cmake .. -DBUILD_TYPE=simulator -DCMAKE_C_FLAGS=-Wno-format-truncation
-- The C compiler identification is GNU 11.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found Git: /usr/bin/git (found version "2.32.0")
--

=============================================
--             - General -
-- MCU version:            v7.1.0-2-gab799dc
-- CMake version:          3.18.4
-- System:                 Linux-5.13.0-28-generic
-- Processor:              x86_64
--              - Build -
-- Compiler version:       GNU 11

-- Compiler:               /usr/bin/cc
-- Linker:                 /usr/bin/ld
-- Archiver:               /usr/bin/ar
--             - Options -
-- Build type:             simulator
-- Monotonic fw version:   34
-- Verbose:                FALSE
-- Documentation:          OFF  (make doc)
-- Coverage flags:         OFF
-- Debug symbols:          OFF
-- SECP256k1 library:      libsecp256k1
--
=============================================

-- C Flags:          -Wno-format-truncation -std=c99 -Os -Wextra -Wall -Wpedantic -Werror -Wstrict-prototypes -Wmissing-prototypes -Werror-implicit-function-declaration -Wpointer-arith -std=gnu99 -ffunction-sections -fdata-sections -Wchar-subscripts -Wcomment -Wformat=2 -Wimplicit-int -Wmain -Wparentheses -Wsequence-point -Wreturn-type -Wswitch -Wtrigraphs -Wunused -Wuninitialized -Wunknown-pragmas -Wfloat-equal -Wundef -Wshadow -Wbad-function-cast -Wwrite-strings -Wsign-compare -Waggregate-return  -Wmissing-declarations -Wformat -Wmissing-format-attribute -Wno-deprecated-declarations -Wpacked -Wredundant-decls -Wnested-externs -Wmultichar -Wformat-nonliteral -Winit-self -Wformat-security -Wold-style-definition -Wmissing-include-dirs -Wswitch-default -Wattributes -Wcast-qual -fstack-protector-all -Wno-unused-function -Wno-missing-field-initializers -Wno-long-long -Wno-expansion-to-defined
-- C link flags:

-- Configuring done
-- Generating done
-- Build files have been written to: /home/dev/HWI/test/work/mcu/build
+ make
Scanning dependencies of target bitbox
[  2%] Building C object src/CMakeFiles/bitbox.dir/aes.c.o
[  5%] Building C object src/CMakeFiles/bitbox.dir/cipher.c.o
[  7%] Building C object src/CMakeFiles/bitbox.dir/base58.c.o
[ 10%] Building C object src/CMakeFiles/bitbox.dir/base64.c.o
[ 12%] Building C object src/CMakeFiles/bitbox.dir/pbkdf2.c.o
[ 15%] Building C object src/CMakeFiles/bitbox.dir/bip32.c.o
[ 17%] Building C object src/CMakeFiles/bitbox.dir/commander.c.o
/home/dev/HWI/test/work/mcu/src/commander.c:177:50: error: argument 1 of type ‘const uint8_t[64]’ {aka ‘const unsigned char[64]’} with mismatched bound [-Werror=array-parameter=]
  177 | int commander_fill_signature_array(const uint8_t sig[64], uint8_t recid)
      |                                    ~~~~~~~~~~~~~~^~~~~~~
In file included from /home/dev/HWI/test/work/mcu/src/commander.c:34:
/home/dev/HWI/test/work/mcu/src/commander.h:40:51: note: previously declared as ‘const uint8_t *’ {aka ‘const unsigned char *’}
   40 | int commander_fill_signature_array(const uint8_t *sig, uint8_t recid);
      |                                    ~~~~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors
make[2]: *** [src/CMakeFiles/bitbox.dir/build.make:160: src/CMakeFiles/bitbox.dir/commander.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:142: src/CMakeFiles/bitbox.dir/all] Error 2
make: *** [Makefile:103: all] Error 2

Building the ColdCard emulator did work, which suggest my system it at least somewhat sane.

I've been able to resolve this by adding -Wno-array-parameter to CMAKE_C_FLAGS. I guess the version of gcc we use in CI doesn't emit an error for that yet.

That did the trick.

No, we don't have a BitBox02 emulator (which also means no tests...)


Add option to config, so bots never disconnect

I tried to figure out why I´m having problems connecting a lot of bots (over 25). It looks like all bots that are limited (5$-Limitation) disconnect automatically and for some reason unlimited accounts also disconnects. Why don´t disconnect? You can farm cards with limited accounts too, but you can´t get an API-Key for limited accounts until you added 5$/5€. Also I figured out that you can connect more then 25 accounts by checking that there is no corrupt sentry-file. Maybe the missing API-Key is the reason for disconnects? I just saw bots coming online and disconnect after some time. (10 seconds) All at once.
Edit: Now I figured out the bot can´t read the badge-page without the API-Key - so you can´t farm cards on limited accounts. :/

You don't need API key to read badge page.

Okay. Back to topic - we need an option to let bots stay connected. I tested again with 40 bots/configs and only 20 bots stayed connected. The highest amount of connected bots I saw today were ~80 bots. All of these 20 connected bots didn´t farmed any game - tested with Debian and Windows.

Connected with https://github.com/JustArchi/ArchiSteamFarm/issues/10.


Update branding to 2.1.10

@aspnet/brt looks like the following is another release/2.1 flaky test. May also be an off-by-one error 😈
  [xUnit.net 00:00:16.72]     LargeUpload(maxRequestBufferSize: 5242880, connectionAdapter: True, expectPause: True) [FAIL]
  Failed   LargeUpload(maxRequestBufferSize: 5242880, connectionAdapter: True, expectPause: True)
  Error Message:
   Assert.InRange() Failure
  Range:  (5238785 - 20971519)
  Actual: 20971520
  Stack Trace:
     at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.MaxRequestBufferSizeTests.LargeUpload(Nullable`1 maxRequestBufferSize, Boolean connectionAdapter, Boolean expectPause) in /_/src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs:line 152
  --- End of stack trace from previous location where exception was thrown ---
  Test Run Failed.
  Results File: F:\vsagent\20\s\artifacts\logs\Sockets.FunctionalTest-netcoreapp2.1-20190306.64.trx

  Total tests: 601. Passed: 598. Failed: 1. Skipped: 2.
  Test execution time: 1.0567 Minutes
F:\vsagent\20\.dotnet\buildtools\korebuild\2.1.7-build-20190110.2\modules\vstest\module.targets(136,5): error : Test group Sockets.FunctionalTest/netcoreapp2.1 failed with exit code '1'. [F:\vsagent\20\.dotnet\buildtools\korebuild\2.1.7-build-20190110.2\KoreBuild.proj]

https://github.com/aspnet/AspNetCore/issues/8054


Empty lines at the bottom of the scrolled area break the mirroring

(Hi. Thank you for putting all these interesting articles together.)
I believe there's an issue with the mirroring from the first article, and this issue find its way in the next parts as well.
Although you're setting the scrollTop of the mirrored div to the scrollTop of the textarea on scroll, it's still going out of sync for some reasons once one or more empty new lines are entered at the bottom of the textarea.
Here's a screenshot of the issue:

I just typed a few more "you\n\n"s so that the area gets a scrollbar, and then I scrolled up a bit.
I don't know why this is happening yet, but it's obviously not expected.
I've encountered and reproduced this in my own code too, when I was trying your first article (just doing the mirroring). I just used a red color (any color other than transparent works as well) instead of transparent, and it's in sync on scroll, however, as soon as I entered a newline at the last line, it went out of sync.

Hello, i have same issue, i don't know how to fix it. I hope you can help! I tried to play with style, but it don't help

Hi, have the same issue, any updates ?


GET All Test Cases XAPTC-43

Added Log statements and now returning multiple objects in Get All Test


Day84

Resolves #177.

Pull Request Test Coverage Report for Build 354

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 347:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


A composable that requires access to the Nuxt instance was called outside of a plugin

Problem
I need to make two calls to OpenAPI in a nuxt plugin, and it's impossible to do with nuxt-open-fetch, as the second call crashes with: A composable that requires access to the Nuxt instance was called outside of a plugin, Nuxt hook, Nuxt middleware, or Vue setup function. This is probably not a Nuxt bug. Find out more at https://nuxt.com/docs/guide/concepts/auto-imports#using-vue-and-nuxt-composables.
Reason
In Nuxt, there is a clear separation: useFetch is a composable, and $fetch is a function which is not coupled to Nuxt component render loop (it's essentially a renamed ofetch).
In nuxt-open-fetch, $clientFetch repeats $fetch contract but in fact it internally depends on Nuxt instance.
There problem is here:
https://github.com/enkot/nuxt-open-fetch/blob/d67634a23f6ae95fb55623cbb0319901fccb81ff/src/runtime/clients.ts#L118-L120
and here, which calls useNuxtApp:
https://github.com/enkot/nuxt-open-fetch/blob/d67634a23f6ae95fb55623cbb0319901fccb81ff/src/runtime/clients.ts#L101-L104
I suppose instead of doing const { $openFetch } = useNuxtApp() it should be looking up useRuntimeConfig().public.openFetch.clients[arg] directly; moreover, I believe it should be doing that once in createOpenFetchClient (not once per $clientFetch invocation).

@IlyaSemenov Could you please provide an example of your plugin?

Had a discussion here https://discord.com/channels/473401852243869706/897487139888062506/1162448006088511518 regarding this problem and currently working on another approach for $[client]Fetch.

Good point, I over-generalized the problem. In a plugin itself, double $clientFetch works fine.
The problem appears in a plugin like this:
export default defineNuxtPlugin(async () => {
  const auth = useAuth()
  await auth.init()
  return {
    provide: { auth },
  }
})

where useAuth is a pinia/nuxt store:
import { defineStore } from "pinia"

export const useAuth = defineStore(
  "auth",
  () => {
    async function init() {
      await $clientFetch("/user/profile/").catch(() => {})
      await $clientFetch("/user/profile/").catch(() => {})
    }

    return {
      init,
    }
  },
)

I'll try to come up with a Stackblitz repro if needed.

@IlyaSemenov Starting from 3.0 we should get clients from the useNuxtApp(), so we never access the Nuxt instance inside $clientFetch.
import { defineStore } from "pinia"

export const useAuth = defineStore(
  "auth",
  () => {
    const { $clientFetch } = useNuxtApp()

    async function init() {
      await $clientFetch("/user/profile/").catch(() => {})
      await $clientFetch("/user/profile/").catch(() => {})
    }

    return {
      init,
    }
  },
)


https://share.bitdefender.com/s/9D4bBE7H8XTdYDB.     can not open

Don't use the dot at the end please, it looks like it is working https://share.bitdefender.com/s/9D4bBE7H8XTdYDB (I don't know if there were any other connectivity problems recently with the sharing platform). Thank you!


Fixed #34007 -- Updated classification of UniqueConstraint validation errors

Fixes #34007
Notes:

I've only updated the one instance that fixes this discrepancy – should we update all ValidationError raised from UniqueConstraint.validate() to use code="unique"?
I've updated the docs clarifying how unique constraint errors are classified - I can't see any other reference in the docs wrt the terminology "field-error" vs "non-field-error" other than the attr NON_FIELD_ERRORS 🤷♂ but I'm sure it will get corrected before merging 😊

Getting a bunch of test failures. I tested locally with python 3.10 & postgres 15. Investigating…

@charettes Cheers, thanks for the final review & guidance.  @felixxm mentioned to me on IRC this patch is being backported so I'm assuming he may not want too many changes in this PR - I'll await his say on this before moving forward. I think trawling through expressions for both unique & check constraints is a good idea and would be happy to open a separate PR for it 👍
This does lead into another discussion I wanted to start on the ML about how to customise constraint error messages in forms using the error_messages dict so I might start that now.

Yep might as well seeing as it's no longer a backport item 👍

Yep might as well seeing as it's no longer a backport item +1

Do you have time to keep working on this?

@felixxm $job has just wrapped up for the year so that frees up my time now 👍

@shangxiao oops this completely dropped off the radar when we went on summer holidays. I can work on this now 👍


Update the docs on ACL tag's owners and OAuth client scopes

I'm trying to setup Tailscale on Github Actions according to this docs: https://tailscale.com/kb/1276/tailscale-github-action
However, it's missing what the OAuth token scopes should be and what the tag owners for tag:ci should be
According to some issues here in this repo, we only need devices:write for OAuth token and "tag:ci": [] and I will try it, but it's still better to update these in the docs

Would be nice if this was added to the docs!


Aligning xclim function with ETCCDI definition.

A request from CCDP PWG:
Two wet day indices on ClimateData.ca (XClim) use > rather than >= (ETCCDI) in the definition.
Would it be possible to change the default option in xclim such that the definition is consistent with ETCCDI?

In xclim, the wetdays indicator already uses >=. On thredds, I randomly checked 2 netCDF files in the cccs_portal folder, for r1mm et r20mm. Both have metadata saying that >= was used.
I might have missed something, but it might also be that the documentation on the portal is not exact?

@aulemahal @Zeitsperre  Thanks, I think this is probably a case where the website data descriptions have simply not identically followed the metadata fields.  @lpcaron I will close the issue here and we can follow up with the CCDP project collaborators


used psr-4 autoloading namespace

Changes in Database/Seeders the PermissionTableSeeder, RoleTableSeeder, DepartmentsTableSeeder & their respective MasterTableSeeder

corrected the namespace

Hi @mrezauli , @ChileNetwork
I apologize for the extremely delayed reply! Here, I have refactored the package and have big plans to add more functionality.
please contribute in the refactored package :)  thank you
weprodev/larapanel-framework
Best,
Michael


Upgrade to mpfr 4

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf Any reason we shouldn't do this upgrade?


Move hickeyma to emeritus

Ref email: https://lists.cncf.io/g/cncf-helm/message/491

@hickeyma thanks so much for your work.


Handle when the ICO file isn't present

PR Summary

Bump rcedit version used
Check if ICO file exists before running rcedit

PR Context
rcedit is failing to set icons in CI scenarios because the ICO doesn't exist in the package.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@TylerLeonhardt Does new version work? Can we merge?

This needed more work because apparently the actual issue is that the ICO doesn't exist. I'm tracking down why, but this change is nice because setting the ICO isn't too important.
cc @adityapatwardhan

Setting of the icon should be done in packaging instead

Changes should be done here: https://github.com/PowerShell/PowerShell/blob/d1aa11e367581736ffea570722cee93815c07a41/tools/packaging/packaging.psm1#L1618

If we take this type of fix, I think we should do something more temporary like:  https://github.com/PowerShell/PowerShell/pull/13078/files

Closing this in favor of #13123


[Suggestion] Support for DaemonSet Deployment Method for Log Collector

Detailed Description: The log collector currently used in the project only supports the Sidecar deployment mode, which to some extent increases resource consumption. To improve the utilization rate of resources, it is suggested that the development team consider supporting the DaemonSet deployment method.
The DaemonSet mode can uniformly deploy the log collector across the entire Kubernetes cluster, reducing redundancy and lowering resource occupancy. Additionally, if possible, it is suggested to open source an Operator that supports the DaemonSet deployment method, so that the community and users can customize and extend it.
Expected Outcome:
Support for the log collector using the DaemonSet deployment method.
Open sourcing an Operator for the log collector based on the DaemonSet deployment method.

we are committed to supporting this feature in the future and plan to open-source an operator that facilitates the DaemonSet deployment method. This initiative is firmly on our roadmap.


needsSystemUpdate fix for AnchorSystem

Fixes https://github.com/Volumetrics-io/mrjs/issues/296
Related to https://github.com/Volumetrics-io/mrjs/pull/298#discussion_r1464313627

closing in favor of https://github.com/Volumetrics-io/mrjs/pull/274


Issue #88 Recurring Donation Updates

Critical Changes
Add comments to each section of the template
Add comment at top with command to run the script
Add comment that this recipe is specifically for Enhanced Recurring Donations (not legacy!)
Use syntax that's more in-line with Salesforce API names (i.e. LastName instead of last_name, etc.)
Changes
#88
Issues Closed
#88

`[{"_table": "Account", "id": 1, "Name": "Hammond-Wiley", "RecordType": "Organization"},
{"_table": "Contact", "id": 1, "FirstName": "Hayden", "LastName": "Ray"},
{"_table": "npe03__Recurring_Donation__c", "id": 1, "npe03__Amount__c": 268, "npsp__Day_of_Month__c": 23, "npsp__DisableFirstInstallment__c": 1, "npsp__StartDate__c": "2020-12-18", "npsp__InstallmentFrequency__c": 1, "npe03__Installment_Period__c": "1st and 15th", "npsp__RecurringType__c": "Open", "npsp__Status__c": "Paused", "npe03__Contact__c": 1, "Name": "RD for Hayden Ray"},
{"_table": "npe03__Recurring_Donation__c", "id": 2, "npe03__Amount__c": 292, "npsp__Day_of_Month__c": 16, "npsp__DisableFirstInstallment__c": 1, "npsp__StartDate__c": "2020-09-15", "npsp__InstallmentFrequency__c": 1, "npe03__Installment_Period__c": "Monthly", "npsp__RecurringType__c": "Fixed", "npsp__Status__c": "Lapsed", "npe03__Organization__c": 1, "Name": "RD for Hammond-Wiley"}]
'
sample sql

Thanks @eehjunggnujhee for making these updates, and your ongoing great documentation ideas (both the comment structure and the inclusion of the Snowfakery output in your comment).
One question, why reduce the recipe to only generate one recurring donation per example?

Hello @acrosman
A good question! I think there is a bug on Snowfakery on random_number.
I am going to investigate more and file a bug report. I also think that the recipe needs a condition to varied the result based on Open and Fixed. Please postpone the merge.

Hi @prescod
I am at snowfakery 1.12 and it seems random_number is buggy. It only assigns 1 from min regardless of the assigned value. 2 generates 1 for example.

Hello @acrosman  okay, I am a free human now.
Please review the SQL data from the original file. There are multiple installment plans assigned to an account or a contact record. As the installment plan creates multiple opportunities based on the plan details. creating 1 installment plan per account or contact is appropriate as it is intended. If this too complicated, please stop me from doing it. I always ask myself for more work.
Please do postpone the merge, I may rush into the push. I will try to set conditional statements to appropriate fields when a recurring donation is open or fixed.
@prescod   sorry about the false bug report. I got two integer fields confused.

I made the update. please review: https://github.com/SFDO-Community-Sprints/DataGenerationToolkit/pull/119/commits/52c57380b7912563af54c36d3d65e0c2071e8aa8


text inside divider

How about having text inside the divider? <Divider>Text</Divider>
Result would be like this:

sample code:
<>

      Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed nonne merninisti licere mihi ista
      probare, quae sunt a te dicta? Refert tamen, quo modo.

    <Divider>Text</Divider>

      Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed nonne merninisti licere mihi ista
      probare, quae sunt a te dicta? Refert tamen, quo modo.

    <Divider orientation="left">Left Text</Divider>

      Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed nonne merninisti licere mihi ista
      probare, quae sunt a te dicta? Refert tamen, quo modo.

    <Divider orientation="right">Right Text</Divider>

      Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed nonne merninisti licere mihi ista
      probare, quae sunt a te dicta? Refert tamen, quo modo.

  </>

just like ant design has: https://ant.design/components/divider/#header

@liesislukas I was tracking this feature in https://trello.com/c/7RLugLrH/1963-divider-add-children-support

https://semantic-ui.com/elements/divider.html
https://ant.design/components/divider/#header
https://arc.dev/signup?service=codementor&to=https%3A%2F%2Fwww.codementor.io%2Fuser-onboarding

What about we bring it as a new component, like DividerTypograhy?

The intuition for me says it should not be a separate component and just get it as children

I think that this should be an attribute for current <Divider/>
<Divider title={'some text'} />
and
<Divider title={'some text'} titlePosition={'right'} />
or it could be just a child but position would still be the attribute
<Divider titlePosition={'left|right|center|inherit'}>text</Divider>
but i think i would go with attributes for title and position. To stay consistent and not introduce extra requirement of child. Not sure if some other component that use divider would expect divider to have a child.
p.s. trello link needs login

@liesislukas Well, if the overhead for implementing the title prop is small. Why not. My guess would be that if people are Divider over a border CSS property, they aren't that sensitive in the first place about the bloat concern.

I find Divider more explicit, that's why i personally tend to use it. And was using ant design for some projects and i liked the way to segment sections with that extra text inside divider. So that's the story why i creates this issue :)
I think for someone who is used to the codebase of material-ui it should not be a big task to implement something like this 🤗

@oliviertassinari @liesislukas is this ticket up for grab? I have implemented this in a storybook using Divider children.

Yes, exploration on the problem is welcome.

@oliviertassinari can you take a look at this code? It is in rough form and many things are still missing, but is this good approach?

@ShehryarShoukat96 It looks like a great start. I think that we could:

add more spacing around the text
support vertical mode

Feel free to open a pull request :)

is this ready to be used? I can't find the documentation for it.

@lsqproduction You can find the documentation in https://next.material-ui.com/components/dividers/#dividers-with-text.


Toast on iOS is under Modal

Toast on iOS (Also existed in previous versions.) is rendered under react-navigation modal

I found that the presentation option of react-navigation Modal must be containedModal or containedTransparentModal, otherwise the modal is on top of everything, I think this is an issue about react-navigation, so just close it.

I ask you to add the following parameter and try it, if the solution is provided, let's add this code
toast.js
    zIndex:99999
  toast: {
    position: 'absolute',
    width: '100%',
    alignSelf: 'center',
    borderRadius: 0,
    shadowColor: defaultBackgroundColor,
    alignItems: 'center',
    shadowOffset: {
      width: 0,
      height: 2,
    },
    shadowOpacity: 0.25,
    shadowRadius: 3.84,
    elevation: 5,
    flexDirection: 'row',
    borderWidth: 0,
    zIndex:99999
  },

I ask you to add the following parameter and try it, if the solution is provided, let's add this code
toast.js
 zIndex:99999
  toast: {
    position: 'absolute',
    width: '100%',
    alignSelf: 'center',
    borderRadius: 0,
    shadowColor: defaultBackgroundColor,
    alignItems: 'center',
    shadowOffset: {
      width: 0,
      height: 2,
    },
    shadowOpacity: 0.25,
    shadowRadius: 3.84,
    elevation: 5,
    flexDirection: 'row',
    borderWidth: 0,
    zIndex:99999
  },

zIndex has no effect, the modal is over everything, there should be a solution on react-navigation side, if I find it, I'll update this issue.

Hi @sekizlipenguen
I found a solution at https://github.com/software-mansion/react-native-screens/issues/525
and use the fullwindowoverlay wrapped the Toast instance in Root.js can display toast on top of the native modal on iOS.
import React, {Component} from 'react';
import {Dimensions} from 'react-native';

import PropTypes from 'prop-types';
import Popup from './Popup';
import Toast from './Toast';
import SPSheet from './SPSheet';
import { FullWindowOverlay } from 'react-native-screens'    // <= added

const {width, height} = Dimensions.get('window');

class Root extends Component {
    render() {
        return (
            <>
                {this.props.children}
                <Popup
                    ref={c => {
                        if (c) {
                            Popup.popupInstance = c;
                        }
                    }}
                />
                <FullWindowOverlay>      // <= added
                    <Toast
                        ref={c => {
                            if (c) {
                                Toast.toastInstance = c;
                            }
                        }}
                    />
                </FullWindowOverlay>
                <SPSheet
                    ref={c => {
                        if (c) {
                            SPSheet.spsheetInstance = c;
                        }
                    }}
                />
            </>
        );
    }
}

Root.propTypes = {
    style: PropTypes.oneOfType([
        PropTypes.object,
        PropTypes.number,
        PropTypes.array
    ])
}

export default Root


Audio Visualizer

Problems with setting up a analyzer node, because SIP.js already has a MediaStream set up on the same audio element.
From SIP.js:
An audio element is needed to play the audio received from the
remote end of the call. Once the call is established, a `MediaStream`
is attached to the provided audio element's `src` attribute.

Found a way to get the audio tracks.
https://github.com/onsip/SIP.js/issues/492 (from https://github.com/TECH7Fox/HA-SIP/issues/33)


📝 Update README.md with improved badge formatting and enhanced docume…

Description
Enhances the README.md with improved grammar, clarity, and technical accuracy:

Refines technical terminology and explanations
Improves document structure and readability
Updates feature descriptions for better clarity
Standardizes formatting and language usage
Enhances installation and usage instructions

Changes

Rewrites introduction for better project description
Improves key features section with clearer terminology
Updates installation section with better organization
Enhances development and production environment descriptions
Refines technical architecture section
Improves best practices guidelines
Updates resource links with more professional terminology

Type of Change

Documentation update (README.md improvements)
No code changes

Thanks for the interest, but the README is currently as intended, this changes many things that I don't consider necessary, and sadly I suspect it's AI-generated, so I'll pass on this one. :coffee:


Excluded users from ListUsers response

Checklist

[X] I agree to the terms within the OpenFGA Code of Conduct.

Describe the problem you'd like to have solved
When making ListUsers queries against models that express type-bound public access (e.g. user:*) and negation (but not), it may be misleading to return user:* as a result without also indicating that there are terminal users that are excluded from that public access.
Example:
model
	schema 1.1

type user

type document
	relations
		define viewer: [user,user:*] but not blocked
		define blocked: [user]

User
Relation
Object

user:*
viewer
document:1

user:jon
blocked
document:1

Calling ListUsers(user_filter=[user], viewer, document:1) will return ["user:*"]. While this is technically true and validated by calling Check(user:*,viewer,document:1) it is misleading because it suggests that all users have access when user:jon does not have the viewer relation for document:1.
Describe the ideal solution
There are to main ways of communicating exclusions:
1. Flattened list per-request
{
  users: ["user:*"],
  excluded_users: ["user:jon"]
}

2. List per-result
{
  users: [
    {
       user: "user:*"
       excluded: ["user:jon"]
    }
  ]
}

Alternatives and current workarounds
The main workaround is to fully understand the implications of a type-bound public access result (e.g. user:*) in the context of ListUsers. This is currently documented in Perform a ListUsers Call.
Additional context
Besides type-bound public access, there may be other situations where it might be useful to indicate exclusions. One such example is nested negated usersets:
model
    schema 1.1

type user

type group
    relations
       define member: [group#member, user]

type document
    relations
        define viewer: [group#member] but not blocked
        define blocked: [group#member]

User
Relation
Object

group:A#member
viewer
document:1

group:B#member
blocked
document:1

group:B#member
member
group:A

Calling ListUsers(user_filter=[group#member],viewer,document:1) today would return ["group:A#member"]. Given that group:B#member is a member of group:A but is also blocked from document:1, it may be useful to indicate that it is excluded from group:A#member. However, it could also be argued that by omitting group:B#member from the response that it could be inferred that it is excluded. These use cases and the problems they solve still need to be understood more.

@willvedd Does the excluded list only need to response when there are public access type or users present in the user list?
I have made a draft PR on it.

Does the excluded list only need to response when there are public access type or userset present in the user list?

@lalalalatt That still needs to be determined based on feedback from users. It may be possible that excluded users are only useful for negations of public wildcards. It is also possible that other exclusion scenarios exists. Do you have a use case that requires retrieval of excluded users?


Pasting a timerange breaks navigation history

After pasting a time range in the TR picker control, it appears the foward/backward buttons no longer works.

Could not reproduce; closing for now


Concepts - Introduction page should use less technical language

The introduction page uses language which is likely unfamiliar to someone new to modules and bundling. It also could do with some front-loading of important info in each section.
Some examples of technical language:

"dependencies" should be initially referred to as "input files and libraries"
"bundle" should be referred to as "output file"
the concept of a "dependency graph" could possibly be addressed in less technical terms

Examples of front-loading important info:

"The entry describes the file that webpack should process first. There may be more than one entry file."
"The output describes the file which should be produced by webpack. There is generally one output file produced for each entry."
"A loader describes how files of a certain type should be processed."
"A plugin adds custom functionality to the webpack bundling process."

I think it would be great to reword this page so that it's more beginner friendly.
I can take a stab at it if you like!

@TheDutchCoder you still interested in looking into this one? I saw you already had a related branch open... #1386 wouldn't be nearly as bad as #1258 if you have any time to get the ball rolling on it. The sections already fairly well organized, I think just a quick review and maybe some sorting should do the job.
@tanyagray are you still interested in working on the Concepts section as well?
I'm going to keep trying to hit the few other content-related ones that are left and then really try to dig into the dev cleanup work so it would be great if someone could take the lead on the Concepts work.

@skipjack Yeah sorry, life's a bit hectic right now with the little one coming, but I think I can make some time to finish this up.
I'll take a look at the other ones as well when I'm working on this one.

I created a PR for this, so if you can take a look and provide some feedback, then that would be awesome!
https://github.com/webpack/webpack.js.org/pull/1673


Ecr terraform module documentation

This documentation is part of bullet point:
These instructions have been read and tested for clarity and correctness by a third party (not the developer or reviewer).
of issue
https://github.com/ministryofjustice/cloud-platform-reference-app/issues/29
This document should cover all terraform code within the terraform directory of this repo, however to keep the focus of the issue https://github.com/ministryofjustice/cloud-platform-reference-app/issues/29 it is only centered in the ECR credentials part of it, outlining only the structure for future documentation of other parts.
this document covers instructions for cloud platforms team to create ecr credentials for other teams when requested

The content reads ok. I'm just not sure that there is a clear "why" or "conditions when" a user would need to do this? This may be a context thing and be related to other guidance but from here I can't tell.

a context was added why this is nedded


Parser updates for bg-brawl

Priority should be ensuring these won't be uploaded as logs to the cloud
Need a test log and examples for:
start event
end event
scoring/score update events (eg ctf captures)
Need to also monitor memory use for the larger files

Missing parses for:
SPELL_CREATE
SPELL_INSTAKILL
SPELL_EMPOWER_START
SPELL_EMPOWER_END
SPELL_EMPOWER_INTERRUPT
SPELL_HEAL_ABSORBED
EMOTE```
from sample log

https://storage.googleapis.com/spires-log-files/bg_blitz.txt
Example log


Problem: we don't have any tests for malicious strings

Solution
Use a parameterized test that fuzzes over a library of potentially hazardous strings. I'm using the 'big_list_of_naughty_strings', which includes some nice sql-injections, some crazy unicode sequences, and some invocations to elder gods... This up shot is, the work of maintaining the 'naughty strings' is off-loaded, and the test file generates individual tests for each string, so we should stay compliant if any new attack vectors open up.
Issues Resolved
Contributing as part of the stability push for release of beta
BEPs Implemented
NA

@z-bowen Why was this PR closed?


Update NOTICE.txt

Updating based on https://community-release.mattermost.com/core/pl/8qqawdk8sids9yoimhjbibmyce. The other ones on the list are Dev Dependencies and not needed here.

/release-note-none

@Willyfrog I don't have merge permissions here, so I assigned this to you.

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
fatal: No such remote 'upstream'

+++ Returning you to the master branch and cleaning up.


snapshot related docs fixes

(Start point was 0.53 branch)
Documentation tweaks and corrections.

Can you open a new PR against master with these changes?

@mfussenegger Are the features and thus docs now in the master branch?