_WD_UpdateDriver() check _WD_DownloadFile() result

Fix for: https://github.com/Danp2/au3WebDriver/issues/197

@mlipok I'm going to assume that your fix is good since both you and @seadoggie01 tested it. Only issue I can see is that _WD_DownloadFile returns an error code of $_WD_ERROR_NotFound, which is not listed in the header for _WD_UpdateDriver. Either the header needs to be updated or the error code should be set via something like $iErr = $_WD_ERROR_GeneralError instead of $iErr = @error

Is that all now ?

AFAIK. Out of curiosity, I see $_WD_ERROR_NoMatch in the header. Do you happen to know under what conditions this would be triggered?

Do you happen to know under what conditions this would be triggered?

interesting.... there was a bug in
Func _WD_DownloadFile($sURL, $sDest, $iOptions = Default)
	..........
	Local $sData = InetRead($sURL, $iOptions)
	If @error Then $iErr = $_WD_ERROR_GeneralError

	If $iErr = $_WD_ERROR_Success Then
		Local $hFile = FileOpen($sDest, $FO_OVERWRITE + $FO_BINARY)

		If $hFile <> -1 Then
			FileWrite($hFile, $sData)
			FileClose($hFile)

			$bResult = True
		Else
			$iErr = $_WD_ERROR_GeneralError
		EndIf
	Else
		$iErr = $_WD_ERROR_NotFound
	EndIf
	..........
EndFunc   ;==>_WD_DownloadFile

as in current _WD_DownloadFile implementation $_WD_ERROR_NotFound will never happen.

I'm thinking about this kind of change:
Func _WD_DownloadFile($sURL, $sDest, $iOptions = Default)
	..........
	Local $sData = InetRead($sURL, $iOptions)
	If @error Then $iErr = $_WD_ERROR_NotFound

	If $iErr = $_WD_ERROR_Success Then
		Local $hFile = FileOpen($sDest, $FO_OVERWRITE + $FO_BINARY)

		If $hFile <> -1 Then
			..........
		Else
			$iErr = $_WD_ERROR_GeneralError
		EndIf
	EndIf
	..........
EndFunc   ;==>_WD_DownloadFile

as in current _WD_DownloadFile implementation, the $_WD_ERROR_NotFound error will never happen.

Actually, doesn't it first assign $_WD_ERROR_GeneralError and then subsequently assign $_WD_ERROR_NotFound when the If evaluates to False?
AFAICS, your proposed change should be fine. Still curious about $_WD_ERROR_NoMatch. 😉

Actually, doesn't it first assign $_WD_ERROR_GeneralError and then subsequently assign $_WD_ERROR_NotFound when the If evaluates to False?

Oh. I missed it. You're right.

AFAICS, your proposed change should be fine.

Take a look: $_WD_ERROR_NotFound fix

Still curious about $_WD_ERROR_NoMatch. 😉

?

Out of curiosity, I see $_WD_ERROR_NoMatch in the header. Do you happen to know under what conditions this would be triggered?

^ This is what I originally wrote above, but you didn't address it. To be clear, I was referring to the header for _WD_UpdateDriver

This could also happen as a result of _WD_GetBrowserVersion or _WD_GetWebDriverVersion

This could also happen as a result of _WD_GetBrowserVersion or _WD_GetWebDriverVersion

Those functions return $_WD_ERROR_NotFound, which is different from $_WD_ERROR_NoMatch
Am I missing something?!

Yeah.
That I am tired today and needed a little more time to understand what you were asking for.

Out of curiosity, I see $_WD_ERROR_NoMatch in the header. Do you happen to know under what conditions this would be triggered?

Was trigered last time here: https://github.com/Danp2/au3WebDriver/commit/a3b1a894eb7238d1e127aba4224dccd57760e1ba#r66697914


Implement autoload (if required)

After writing the nexus file GDA will write the filename to both:

${gda.beamline.var}/dials_image_viewer_file.txt
${gda.beamline.var}/adxvAutoload.txt

Presumably for analysis software to know where these files are.
Acceptance Criteria

Discuss with analysis people why these files exist - why can we not do everything through zocalo? (@graeme-winter, could you provide background on this?)
Either implement this in Artemis, if required, or document why not required

@graeme-winter, @rjgildea and @neil-i03. We're not doing this in Artemis, is it something we need to do or is it a bit of legacy GDA we can drop?

Not required for UDC. It was for the in-person collection image viewing icons in the mx-launcher. Not even sure we use the adxv one any more as autoload runs via a Mark script. I suspect by the time artemis goes beyond I03 then it will have been replaced by something better.

I'm pretty sure neither of these files are used by data analysis.


Is there a 1.12.2 version?

no

can I help make one?

there's plenty of bases for 1.12.2

theres one for 1.12.2 now


bug: missing DocVecProto in NodeProto

Probably this will create a problem with nested DocVec. Need to investigate

I modified the proto here to enable DocVec inside of DocVec, but I did not touch the definition of NodeProto.
I did not see any issues.
Does NodeProto still need to be modified? I am not 100% sure about its usage. @samsja do you know?

I think it will still be a problem no ?
If I have
class MyDoc(BaseDoc):
     images: DocVec[Image]

then we cannot close, this will not work


Feature/fix zipkin spans alternate

Fixing CAMEL-16509
Cleaner way of implementing copy safe properties on ExtendedExchange

Can you work on the other tracer components to let them use safe copy too?

Can you work on the other tracer components to let them use safe copy too?

@davsclaus  I will take a look at opentracing next. However is it okay if I backport this? We are currently working with 3.7.3 and a fixed zipkin implementation will be very helpful.

ok you can do that


Update/Add Helix Core CLI

Tool name
Helix Core CLI (P4)
Tool license
P4/P4API
Add or update?

[X] Add
[ ] Update

Desired version
latest
Approximate size
22.4MB
Brief description of tool
Perforce cli tool for interacting with a perforce server.
I searched for history on this tool, it surprises me that it isn't included in the images by default. My assumption is that the P4/P4API license is unacceptable? I made this issue regardless so there can be a record of acceptance/rejection.
Here's the incomplete p4 specific portion of the license regarding distribution:
P4/P4API License
    -----------------------
    Copyright (c) 1995-2023, Perforce Software, Inc.
    All rights reserved.

    Redistribution and use in source and binary forms, with or without
    modification, are permitted provided that the following conditions are met:

        Redistributions of source code must retain the above copyright notice,
        this list of conditions and the following disclaimer.

        Redistributions in binary form must reproduce the above copyright
        notice, this list of conditions and the following disclaimer in the
        documentation and/or other materials provided with the distribution.

There is a full license which includes the license pieces of all distributed software used by perforce.
It can be acquired by p4 help legal.
URL for tool's homepage
https://www.perforce.com/products/helix-core-apps/command-line-client
Provide a basic test case to validate the tool's functionality.
p4 -V

Platforms where you need the tool

[X] Azure DevOps
[X] GitHub Actions

Runner images where you need the tool

[ ] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] Windows Server 2019
[X] Windows Server 2022

Can this tool be installed during the build?
https://www.perforce.com/manuals/v15.1/p4guide/chapter.install.html

Tool installation time in runtime
No response
Are you willing to submit a PR?
No response

Hello @Zageron .  With small installation time (1-2 min) would not like to pre-install the tool into the image also because of maintenance concerns. Please install provided tool in runtime. I am closing this issue for now, but if have any additional questions feel free to ask.


More TypeScript samples

Describe the solution you'd like
More of these https://github.com/microsoft/BotBuilder-Samples/tree/master/samples/javascript_nodejs in TypeScript
[enhancement]

We'll track the request with this issue.  That said, we won't make any progress on this for the remainder of the calendar year.


Changing imports removes comment at the top of a file

Given a Go source file with a comment at the top of the file (not a package comment):
// Copyright 2022 ...

package main

import (
	"cmd/internal/edit"
)

func main() {
	_ = edit.Buffer
}

and a patch to modify the imports:
@@
var randomIdentifier identifier
@@
-import "cmd/internal/edit"
+import "github.com/foo/bar/internal/edit"

edit.randomIdentifier

the comment at the top is removed by gopatch, resulting with the following file:
package main

import "github.com/foo/bar/internal/edit"

func main() {
	_ = edit.Buffer
}

The respective testdata file:
-- in.patch --
@@
var randomIdentifier identifier
@@
-import "cmd/internal/edit"
+import "github.com/foo/bar/internal/edit"

edit.randomIdentifier

-- comment.in.go --
// Copyright 2022 ...

package main

import (
	"cmd/internal/edit"
)

func main() {
	_ = edit.Buffer
}

-- comment.out.go --
// Copyright 2022 ...

package main

import "github.com/foo/bar/internal/edit"

func main() {
	_ = edit.Buffer
}

This returns:
$ go test .
--- FAIL: TestIntegration (0.04s)
    --- FAIL: TestIntegration/replace_import_with_top_level_comment (0.00s)
        --- FAIL: TestIntegration/replace_import_with_top_level_comment/comment (0.00s)
            e2e_test.go:127:
                        Error Trace:    e2e_test.go:127
                        Error:          Not equal:
                                        expected: "// Copyright 2022 ...\n\npackage main\n\nimport \"github.com/foo/bar/internal/edit\"\n\nfunc main() {\n\t_ = edit.Buffer\n}\n"
                                        actual  : "package main\n\nimport \"github.com/foo/bar/internal/edit\"\n\nfunc main() {\n\t_ = edit.Buffer\n}\n"

                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1,3 +1 @@
                                        -// Copyright 2022 ...
                                        -
                                         package main
                        Test:           TestIntegration/replace_import_with_top_level_comment/comment
FAIL
FAIL    github.com/uber-go/gopatch      0.047s
FAIL


Made working with PHP8.0

I report what I indicated in the description of the commit:

In PHP 8.0 it is not possible to access a class quickly if it is not static

I also took the liberty of modifying the "welcome" function to make it more configurable.
Now you can use it like this:
$class = new \Keylogic\Popcatwrapper\Main();
$image = $class->welcome('https://... avatar ...', 'FoxWorn3365', $class->makeServer('A good server', true), 255);
// But we can also do this:
$image = $class->welcome('https://... avatar ...', 'FoxWorn3365', 'Welcome to THE server!', 255);

PR has been left for over 7 months, closing now.


Add an avoidTransition parameter to Navigator#resetTo

I think it's important to be able to reset the route stack without visual transition.
Test plan
navigator.resetTo(route, true)

Sorry, just realized it can be done with Navigator#immediatelyResetRouteStack([route])


Move sql-sync README from docs

Codecov Report

Merging #169 (fe77605) into main (57b7982) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head fe77605 differs from pull request most recent head 3db9ccf. Consider uploading reports for the commit 3db9ccf to get more accurate results

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   42.65%   42.65%
=======================================
  Files          23       23
  Lines         966      966
=======================================
  Hits          412      412
  Misses        554      554

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b7982...3db9ccf. Read the comment docs.


Environment variables can't be used in config files

What kind of changes does this PR include?

New or updated content

Description
We closed #785 as the corresponding feature was closed, but the note about Astro being unable to load env variables is still important information, even if we don't have a workaround. This PR restores that note and adds a corresponding one to the environmental variables change.
I could see us only wanting one of those two messages, or rather wanting this to be in Troubleshooting. Let me know!
@natemoo-re, if there's currently a workaround to access env variables in Astro, let me know.

No, import.meta.env is a Vite thing and the config is evaluated in a standard Node environment before Vite is running.

Added a section on setting variables with the CLI.
I moved the caution in Environment Variables to the overview. It really is an overview, not an introduction, and import.meta.env is already brought up by that point.
I wasn't sure whether to document process.env in Environment Variables or Configuring Astro. I chose the later because Configuring Astro seems to want to be comprehensive, but I could see other possibilities:

I could do the opposite where I just have a section in Environment Variables that has all the info, and don't change Configuring Astro.
Or I could have a caution in Configuring Astro that links to Environment Variables, where the info actually lies.

More comments as requested by @Jutanium (to be added to this PR or tackled later at his discretion).

Opening paragraph:

Astro uses Vite for environment variables

I’d probably rewrite to something like

Astro relies on Vite’s built-in environment variable support

Or even rewrite the whole opening sentence:

Astro lets you use any of Vite’s methods to get and set environment variables.

“Default environment variables” section
Totally a nit but in the first list item I’d write either “development | production” or “development or production” but not use the | outside of <code>.

“Supported file names” code snippet
Could probably considered a nit, but might reformat as a table or list. At first glance I read it as a continuation of the .env file example above it.

“Getting environment variables” section
The browser support tip seems excessively noisy in this context. I’d roll that content into the opening paragraph.

Thanks @delucis! This page could use a broader reworking (including explaining what Environment Variables actually are), but I made minimal changes for now to address your points.
I removed the .env files snippet entirely as it was copy-pasted from Vite docs - I linked to that instead. I also removed the the tip rather than moving it, as we made this point clear as soon as we talked about client-side code in the intro.


Expose public URLs for wrangler dev

💡 Feature request
Enable public access of wrangler dev workloads.
Describe the feature
This feature request is the opposite of cloudflare/wrangler#1820 (and any other "run workers locally" requests): I love that wrangler dev runs workloads on edge servers, but it's unclear if accessing those workloads publicly is possible. Being able to use those workers at an auto-generated, public URL would be ideal.
The specific use-case: most/all of my development work is not done locally, so exposing dev workloads on localhost is incompatible with the way I work across distributed services in the cloud and across providers. Even more specifically, I'd really like to be able to more easily work on workers that are themselves webhook endpoints for other services (like e.g. Stripe).
Describe the alternatives
My current workaround is to either publish the thing to a specific subdomain and then tail the logs or, more often, to spin up something like localtunnel to use as a temporary webhooks endpoint. The first solution is much slower than I expect an equivalent wrangler dev would be. The second solution is both cumbersome and somewhat silly conceptually, since wrangler dev is already tunneling from the edge to localhost and my tunnel is sending that data right back into the public realm through yet-another-network.
Skipping that extra hop altogether and enabling publicly-accessible workloads during dev would improve my Workers workflow considerably!
It's also entirely possible that I'm mis-reading the documentation. If it's already possible to access dev workloads publicly, then consider this a feature request for updated and clarified docs.

A solution in the meantime for anyone who's looking for one is to use Cloudflare Tunnel. There's somewhat of a roundabout way to use a dashboard-managed Tunnel that can be activated on demand. Here's instructions (make sure you install cloudflared first):

Run cloudflared tunnel create NAME on your local device that you are testing on. If you skip this step and create a Tunnel via the dash you cannot activate on-demand (it's always on), so make sure you create it this way. Pick a name and substitute NAME for your Tunnel name.
Go to the Zero Trust dashboard, and find the Tunnel in the Tunnels menu on the right. Click Configure then Migrate (ignore all warnings, t doesn't matter that your config will be lost because you don't have any yet :smile:).
Add any hostnames you want under Public Hostnames, and point them to whatever local services you want (for example, laptop.example.com -> http://localhost:3000/)
When you are ready to use your Tunnel, run cloudflare tunnel run NAME on your local device. Note that when this command is not running your Tunnel will not work: this helps protect against accidently leaving your Tunnel running and exposing a service by mistake.
You can now access your local services on the Public Hostname you entered! 🎉

I do this pretty much every time I set up a local dev project - would be very convenient for wrangler to expose a public url (with optional consistent naming, similar to tunnel create or tunnel --name).


OpenShift Nightly Job Failing

Bug description: OpenShift nightly job has been failing the e2e_statesfulsets_test.
Affected area (please mark with X where applicable):

Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [X]
Demo                       [ ]
CI System                  [X]

Expected behavior: OpenShift nightly job should pass all e2es.
Steps to reproduce the bug (as precisely as possible):
How was OSM installed?:
Anything else we need to know?:
Bug report archive:

Environment:

OSM version (use osm version):
Kubernetes version (use kubectl version):
Size of cluster (number of worker nodes in the cluster):
Others:

OpenShift nightly job is now failing the e2e_certmanager test, need to debug.

Seems to be an intermittent issue due to: https://cert-manager.io/docs/concepts/webhook/#webhook-connection-problems-shortly-after-cert-manager-installation


Follow relative references

Add an option --merge to merge the input definition files to one binding.

This is a breaking change; previously --merge was the default behavior.

Add an option --follow-relative-references to generate bindings for relevant files at once.

It will follow all the relative imports and reference directives and load them at once.

Will --follow-relative-references produce multiple files matching relative references?

@Lupus Yes, it will just work as you run ts2ocaml for each file. The previous behavior (merging everything to one file) is not a default behavior anymore and must be enabled with --merge.


Update ciris to 3.2.0

About this PR
📦 Updates is.cir:ciris from 3.0.0 to 3.2.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "is.cir", artifactId = "ciris" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "is.cir", artifactId = "ciris" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #139.


movine: init at 0.11.0

Motivation for this change
We want movine packaged upstream.
Things done
Packaged movine to be merged upstream.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Trying to compile this locally doesn't work, you have to add another commit maintainers: add <real name/username> to add yourself as a maintainer in maintainers/maintainers-list.nix

Trying to compile this locally doesn't work because you aren't in the maintainer list, you have to add another commit maintainers: add <real name/username> to add yourself as a maintainer in maintainers/maintainers-list.nix

I've added myself to the maintainers-list here, in an open PR.
What's the etiquette in this situation? Just do it again here?

I'd wait for the other one to be merged, as there could be merge conflicts otherwise, and having the same commit twice is dumb.

I'd wait for the other one to be merged, as there could be merge-conflicts otherwise, and having the same commit twice is dumb.

Seeing as this PR should presumably be merged before the aforementioned one (we're waiting for sozu v0.12.0 to be released), I'll remove the commit from that and move it here. Would that be alright?

If you do it correctly (maybe with git-cherry-pick, and remove it from the other PR) I don't see why not.

Whoops misclick 😅

Result of nixpkgs-review pr 120754 run on x86_64-linux 1

1 package built:

movine

Result of nixpkgs-review pr 120754 run on x86_64-linux 1

1 package built:

movine

I'll try to run a nixpkgs-review on my Darwin machine this evening. If that passes too, LGTM.


Apply-Damage Ballistic Armor Not working

See below: character is using a ballistic weapon but armor calculation isn't working correctly

Tracked this issue down looks like there's a typo on apply-damage.js#220.
Just need to replace healthSys._useBallistic; with healthSys.useBallistic; tested this locally, it works.
Sidenotes:  Woulda made a PR, buuuuuuut couldn't figure that out. Maybe I'm a fool but whether it's permissions or my lack of github finesse, but I couldn't create a branch to make this a PR (keep gettin permission errors). Maybe add a contributor's guide? I don't have much js experience, but for things like this it'd be great to just help ya out

Good catch!  The next release will add this fix :-)
I am also not familiar with PR from Github as well... I'll learn it and add a contributor's guide, as you suggested. Cheers!


feat: subscribe to all CUSTOM streaming events (event types are automatically discovered)

This is a usability improvement.
Currently we have these 2 features:

Subscribe to all streaming events (event types are automatically discovered).
Subscribe to and unsubscribe from specific streaming events with a user-friendly UI.

When you have many custom platform events (say 20), subscribing to all of them is always tedious. Either you subscribe to all events and have to manually unsubscribe from all standard platform events (which are a lot and you have to do it one by one) or you manually subscribe to each custom platform event one by one, which is also very time consuming.
Ideally we could have these features:

Subscribe to all streaming events (event types are automatically discovered).
Subscribe to all custom streaming events (event types are automatically discovered). ==> NEW FEATURE
Subscribe to and unsubscribe from specific streaming events with a user-friendly UI.

Hi @juanlu-github, thanks for the great suggestion. I added this kind of filter in the latest release.


meta: delay deletion of compacted slices

close #1521
TODO:

[ ] Provide a way to manually clean up slices: maybe add a new option in gc or do it with --delete
[x] Dump & Load: need a new struct DumpedDelSlice

better not load the delSlices, because the whole sliceRefs is rebuild when loading entries, and it's dangerous to further decrease any of the refs. Instead we can just run gc --delete command after loading to clean up the leaked slices.

[x] Unit tests
[x] SQL: need a new table: delslices{chunkid, ts, blob}
[x] TKV: Lcccccccctttttttt -> blob

Codecov Report

Merging #1790 (02c1504) into main (c76cf44) will decrease coverage by 0.16%.
The diff coverage is 59.92%.

@@            Coverage Diff             @@
##             main    #1790      +/-   ##
==========================================
- Coverage   61.90%   61.74%   -0.17%
==========================================
  Files         135      135
  Lines       23011    23227     +216
==========================================
+ Hits        14246    14342      +96
- Misses       7171     7262      +91
- Partials     1594     1623      +29

Impacted Files
Coverage Δ

pkg/meta/base.go
69.58% <38.70%> (-2.11%)
:arrow_down:

pkg/meta/redis.go
72.79% <55.04%> (-0.45%)
:arrow_down:

pkg/meta/sql.go
67.17% <66.19%> (+0.12%)
:arrow_up:

pkg/meta/tkv.go
76.12% <70.31%> (-0.35%)
:arrow_down:

pkg/sync/sync.go
45.17% <100.00%> (+0.19%)
:arrow_up:

pkg/fuse/context.go
56.75% <0.00%> (-10.82%)
:arrow_down:

pkg/vfs/reader.go
80.29% <0.00%> (-4.38%)
:arrow_down:

pkg/chunk/cached_store.go
76.05% <0.00%> (-2.20%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d77807...02c1504. Read the comment docs.


Use new template utils for inspect policy also

The new templating helpers were introduced in #1631. I want to use the same technique in some older templating.
This required a little refactor of the helpers because we want to be able to use io.Writer directly rather than write to a buffer.
Also add some extra unit tests.

Codecov Report
Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.81%. Comparing base (5585270) to head (f6555f3).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
+ Coverage   80.14%   86.81%   +6.67%
==========================================
  Files          65       76      +11
  Lines        4779     5128     +349
==========================================
+ Hits         3830     4452     +622
+ Misses        949      676     -273

Flag
Coverage Δ

acceptance
72.06% <47.05%> (?)

generative
80.13% <88.23%> (-0.01%)
:arrow_down:

integration
80.13% <88.23%> (-0.01%)
:arrow_down:

unit
80.13% <88.23%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

internal/opa/output.go
92.30% <75.00%> (-3.53%)
:arrow_down:

internal/utils/templates.go
56.89% <92.30%> (+3.95%)
:arrow_up:

... and 41 files with indirect coverage changes


Provide Badges

How about providing badges the project can add to ther README.md?
That would help the project finding helpers, as well as codetriage to become more popular.

@schneems I know that can be hard, but would even be nicer to have a setup file to the amount of issues and colors.  Like:
.triage.yml
red: 0
orange: 1-2
yellow: 5-10
....

To be decided:

Would we create/serve the SVG's dynamically (run time)? Or redirect to shield.io service?
Will we use a setup file on the "client" repository to setup this?

If you decide yourselves soon I can work on a pull request.

@BanzaiMan sorry to weave you in, but given you've deal with badges for Travis CI, how did you all end up handling it? Is there some prior art we should just use?

Actually, I haven't. I didn't really touch this stuff.
What I do know is that we have a set of SVG files (in https://github.com/travis-ci/travis-api/tree/master/public/images/result) and serve them up from API (a Sinatra app) according to the status.

@BanzaiMan awesome, thanks for the knowledge!

@parndt that wouldn't be the best choice here, since we need to show numbers. We really need a SVG generator, to create dynamic stuff like:

I reckon Code Climate or Coveralls would have some insight into how to do such a thing.


fix(migration): metadata migration was incorrect

Description
this pr fixes an issue in which ibc was migrating metadata but not setting the values of the denom units, this has been breaking indexers and causing issues across users
closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

There is some failing unit tests, I will try to look into later today if you don't have time

Is there a bug report we could link to this pr? I am having a hard time understanding the exact issue and the solution to it

I have tested an e2e chain upgrade to ensure our migration code works as expected (specifically when existing metadata with denom units > 1 are stored in x/bank state).
I will link below code diffs and outline for anyone who would like to sanity check this.
Steps to reproduce:

Prep a docker image of ibc-go/v7 code which sets denom metadata pre-upgrade.

The following diff from my branch edits the v7.8.x release branch to store denom metadata on RecvPacket (with two denom units for the IBC token denom) ref
Checkout the branch (damian/e2e-denom-metadata-migration-v7)
Build a docker image: docker build -t ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e . --build-arg IBC_GO_VERSION=latest

Run an e2e upgrade test from ibc-go/v7 to ibc-go/v8, which will run the automatic transfer migration.

See the test diff here: https://github.com/cosmos/ibc-go/compare/damian/e2e-denom-metadata-migration-test?expand=1
Checkout branch (damian/e2e-denom-metadata-migration-test)
cd e2e && mkdir dev-configs
Drop the e2e config file pasted below into dev-configs and run make e2e-test from the e2e directory.
You will be prompted by fzf to select your config file. Search for TestV7ToV8ChainUpgrade
The config below is configured to run from the docker image we built in step 1 and upgrade to ibc-go:v8.5.0

E2E chain upgrade config
---
chains:
  # the entry at index 0 corresponds to CHAIN_A
  - chainId: chainA-1
    numValidators: 1
    numFullNodes: 1
    image: ghcr.io/cosmos/ibc-go-simd # override with CHAIN_IMAGE
    tag: v7.8.0-dev-e2e # override with CHAIN_A_TAG
    binary: simd # override with CHAIN_BINARY

    # the entry at index 1 corresponds to CHAIN_B
  - chainId: chainB-1
    numValidators: 1
    numFullNodes: 1
    image: ghcr.io/cosmos/ibc-go-simd # override with CHAIN_IMAGE
    tag: v7.8.0-dev-e2e # override with CHAIN_B_TAG
    binary: simd # override with CHAIN_BINARY

activeRelayer: hermes # override with RELAYER_ID
relayers:
  - id: hermes
    image: ghcr.io/informalsystems/hermes
    tag: "1.10.0"
  - id: rly
    image: ghcr.io/cosmos/relayer
    tag: "latest"
  - id: hyperspace
    image: ghcr.io/misko9/hyperspace
    tag: "20231122v39"

cometbft:
  logLevel: info

debug:
  # setting this value to true will force log collection even if the test passes.
  dumpLogs: false
  # settings this value to true will keep the containers running after the test finishes.
  keepContainers: true

# Required only for upgrade tests.
# Chain A will be upgraded the specified tag.
# The plan name must be registered as an upgrade handler in the given tag.
upgrade:
  planName: "v8" # override with CHAIN_UPGRADE_PLAN
  tag: "v8.5.0" # override with CHAIN_UPGRADE_TAG

Test passes successfully.

Test output
make e2e-test
./scripts/init.sh
using config file at /Users/damiannolan/.ibc-go-e2e-config.yaml for e2e test
./scripts/run-e2e.sh
Using configuration file at /Users/damiannolan/development/ibc-go/e2e/dev-configs/denom-metadata-migration.yaml
2024/11/04 13:47:47 proto: duplicate proto type registered: ibc.lightclients.wasm.v1.MsgStoreCode
2024/11/04 13:47:47 proto: duplicate proto type registered: ibc.lightclients.wasm.v1.MsgStoreCodeResponse
2024/11/04 13:47:47 proto: duplicate proto type registered: ibc.lightclients.wasm.v1.MsgRemoveChecksum
2024/11/04 13:47:47 proto: duplicate proto type registered: ibc.lightclients.wasm.v1.MsgRemoveChecksumResponse
2024/11/04 13:47:47 proto: duplicate proto type registered: ibc.lightclients.wasm.v1.MsgMigrateContract
2024/11/04 13:47:47 proto: duplicate proto type registered: ibc.lightclients.wasm.v1.MsgMigrateContractResponse
2024/11/04 13:47:47 proto: duplicate proto type registered: ibc.lightclients.wasm.v1.ClientState
2024/11/04 13:47:47 proto: duplicate proto type registered: ibc.lightclients.wasm.v1.ConsensusState
2024/11/04 13:47:47 proto: duplicate proto type registered: ibc.lightclients.wasm.v1.ClientMessage
=== RUN   TestUpgradeTestSuite
    testsuite.go:168: Setting up chains: TestUpgradeTestSuite
    setup.go:168: Keeping containers - Docker cleanup skipped
{"level":"info","msg":"Using embedded configured chains"}
{"level":"error","msg":"Failed to pull image","error":"Error response from daemon: manifest unknown","repository":"ghcr.io/cosmos/ibc-go-simd","tag":"v7.8.0-dev-e2e"}
{"level":"error","msg":"Failed to pull image","error":"Error response from daemon: manifest unknown","repository":"ghcr.io/cosmos/ibc-go-simd","tag":"v7.8.0-dev-e2e"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys add faucet --coin-type 118 --keyring-backend test --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-eqrwdt","container":"TestUpgradeTestSuite-eqrwdt"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys add faucet --coin-type 118 --keyring-backend test --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-xesnvq","container":"TestUpgradeTestSuite-xesnvq"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys show --address faucet --home /var/cosmos-chain/simapp-a-1 --keyring-backend test","hostname":"TestUpgradeTestSuite-trpgst","container":"TestUpgradeTestSuite-trpgst"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys show --address faucet --home /var/cosmos-chain/simapp-b-2 --keyring-backend test","hostname":"TestUpgradeTestSuite-dydcyz","container":"TestUpgradeTestSuite-dydcyz"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd init chainB-1-val-0-TestUpgradeTestSuite --chain-id chainB-1 --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-inmoky","container":"TestUpgradeTestSuite-inmoky"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd init chainB-1-fn-0-TestUpgradeTestSuite --chain-id chainB-1 --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-fwvjov","container":"TestUpgradeTestSuite-fwvjov"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd init chainA-1-val-0-TestUpgradeTestSuite --chain-id chainA-1 --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-eycryq","container":"TestUpgradeTestSuite-eycryq"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd init chainA-1-fn-0-TestUpgradeTestSuite --chain-id chainA-1 --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-vtbysp","container":"TestUpgradeTestSuite-vtbysp"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys add validator --coin-type 118 --keyring-backend test --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-mppsru","container":"TestUpgradeTestSuite-mppsru"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys add validator --coin-type 118 --keyring-backend test --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-rtjkeu","container":"TestUpgradeTestSuite-rtjkeu"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys show --address validator --home /var/cosmos-chain/simapp-a-1 --keyring-backend test","hostname":"TestUpgradeTestSuite-pifxyy","container":"TestUpgradeTestSuite-pifxyy"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys show --address validator --home /var/cosmos-chain/simapp-b-2 --keyring-backend test","hostname":"TestUpgradeTestSuite-dgypqo","container":"TestUpgradeTestSuite-dgypqo"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-evobbw","container":"TestUpgradeTestSuite-evobbw"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-hfhlbg","container":"TestUpgradeTestSuite-hfhlbg"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1elnraxcsq3vm3kwsclamqfmy3gvn299f5xdlyx<PHONE_NUMBER>0000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-mltuwl","container":"TestUpgradeTestSuite-mltuwl"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos14aa7y9vd8nkh8060hdw5fhtrekcjgzndtks4s7<PHONE_NUMBER>0000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-rpuxqe","container":"TestUpgradeTestSuite-rpuxqe"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-zbhnvg","container":"TestUpgradeTestSuite-zbhnvg"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-xybboh","container":"TestUpgradeTestSuite-xybboh"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd gentx validator<PHONE_NUMBER>000atomb --gas-prices 0.00atomb --gas-adjustment 1.3 --keyring-backend test --chain-id chainB-1 --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-cmcpcf","container":"TestUpgradeTestSuite-cmcpcf"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd gentx validator<PHONE_NUMBER>000atoma --gas-prices 0.00atoma --gas-adjustment 1.3 --keyring-backend test --chain-id chainA-1 --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-qbdmyz","container":"TestUpgradeTestSuite-qbdmyz"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-fetgzn","container":"TestUpgradeTestSuite-fetgzn"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-qbwtcl","container":"TestUpgradeTestSuite-qbwtcl"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1z0276xxzsxq6ykhmveccpcty7wrr44dz8vvpdh<PHONE_NUMBER>00000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-gbyfws","container":"TestUpgradeTestSuite-gbyfws"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1ryjcpa086cqyrmwapv7jmpnutpneshq0mjfqyj<PHONE_NUMBER>00000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-pyznva","container":"TestUpgradeTestSuite-pyznva"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-caeeoz","container":"TestUpgradeTestSuite-caeeoz"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-ransqf","container":"TestUpgradeTestSuite-ransqf"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1uqzjc2882d0qgan8q8mtt6m2cmy3lxkpsyh5az<PHONE_NUMBER>000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-tgbxbe","container":"TestUpgradeTestSuite-tgbxbe"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1evq9jvax7xz98xaazrxp5pagj66n00lvrtntku<PHONE_NUMBER>000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-tztqfl","container":"TestUpgradeTestSuite-tztqfl"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-torlct","container":"TestUpgradeTestSuite-torlct"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-fsbusd","container":"TestUpgradeTestSuite-fsbusd"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1vlh5gtrc5m46xa2uvd4mxt5q4ark77njkdxsu7<PHONE_NUMBER>000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-rvdoql","container":"TestUpgradeTestSuite-rvdoql"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1wqf9w45p5kzntfqfl00gwuk5jr5gj4m67xjy45<PHONE_NUMBER>000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-vemedb","container":"TestUpgradeTestSuite-vemedb"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-xgnaxj","container":"TestUpgradeTestSuite-xgnaxj"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-sdjllj","container":"TestUpgradeTestSuite-sdjllj"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1attswsgnqza223zgnyrtn7ljzqqf28cexfdypw<PHONE_NUMBER>000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-tysygw","container":"TestUpgradeTestSuite-tysygw"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1lvune9evr5hgxwxtk8u2pdsdl5crkplnytsv6k<PHONE_NUMBER>000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-gwpnre","container":"TestUpgradeTestSuite-gwpnre"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-dctsup","container":"TestUpgradeTestSuite-dctsup"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-tonaoy","container":"TestUpgradeTestSuite-tonaoy"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1ua2m5dtqxtkk4zzek48hve7nhsa4fptcj57t7v<PHONE_NUMBER>000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-mpwkih","container":"TestUpgradeTestSuite-mpwkih"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-xaoxct","container":"TestUpgradeTestSuite-xaoxct"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos14q6lj29s5dupraqmkgjpp7v8wtv40gh9ux2j4l<PHONE_NUMBER>000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-fgjkjg","container":"TestUpgradeTestSuite-fgjkjg"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos12cwwafs0te66lt3fw66x759kk5u84a4g9gqxh3<PHONE_NUMBER>000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-owpohj","container":"TestUpgradeTestSuite-owpohj"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-iwqpuk","container":"TestUpgradeTestSuite-iwqpuk"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-pwarus","container":"TestUpgradeTestSuite-pwarus"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1euznuna85xqu6qenwlmnlqm93sykczwe9e84r9<PHONE_NUMBER>000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-rwdrif","container":"TestUpgradeTestSuite-rwdrif"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1pz9vea7xhqmy50ykj3sx34a3muxunt6f5p94t4<PHONE_NUMBER>000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-mzuywf","container":"TestUpgradeTestSuite-mzuywf"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-xjyiud","container":"TestUpgradeTestSuite-xjyiud"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-jdnvxx","container":"TestUpgradeTestSuite-jdnvxx"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1k9083nwhua0zpmv2xzt3w7hjk8y8e8ecuvwzlk<PHONE_NUMBER>000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-phkltf","container":"TestUpgradeTestSuite-phkltf"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1xctx225drderp84raukxa9q92u9c7wl6cd3qa8<PHONE_NUMBER>000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-bhgahr","container":"TestUpgradeTestSuite-bhgahr"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-weczsk","container":"TestUpgradeTestSuite-weczsk"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-itwdhl","container":"TestUpgradeTestSuite-itwdhl"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1ar62ng0p6kxmdvv5dkn7zlff7m6wmusmckzpww<PHONE_NUMBER>000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-snrqld","container":"TestUpgradeTestSuite-snrqld"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1jl8jmel24enjx6y75jssr6stay93xcz9kuxxmr<PHONE_NUMBER>000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-yxjeyb","container":"TestUpgradeTestSuite-yxjeyb"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-xidfjn","container":"TestUpgradeTestSuite-xidfjn"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-onyusd","container":"TestUpgradeTestSuite-onyusd"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1ayhtc6s339tgj7w7vv24fhqf0vj8t9mmfh34hc<PHONE_NUMBER>000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-rbflns","container":"TestUpgradeTestSuite-rbflns"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1wcfgxqdprt5axkk6j329f0stt5acwttyfqxg22<PHONE_NUMBER>000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-zkgbfs","container":"TestUpgradeTestSuite-zkgbfs"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-rxjant","container":"TestUpgradeTestSuite-rxjant"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-qgugoq","container":"TestUpgradeTestSuite-qgugoq"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos199zerg6kk4atnpvyyu5s5z73a9u7pjuw4yxq2a<PHONE_NUMBER>000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-xhxchx","container":"TestUpgradeTestSuite-xhxchx"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos1z74gs9c4ygnq4srzh44y0vam3kyzp634cd2ny0<PHONE_NUMBER>000atomb --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-jgyysf","container":"TestUpgradeTestSuite-jgyysf"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-kxvxel","container":"TestUpgradeTestSuite-kxvxel"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-flbrdz","container":"TestUpgradeTestSuite-flbrdz"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd add-genesis-account cosmos18gtaxedu6q0adj4388km59s4823asjs6kg356e<PHONE_NUMBER>000atoma --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-yfvbsy","container":"TestUpgradeTestSuite-yfvbsy"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd collect-gentxs --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-dmhgll","container":"TestUpgradeTestSuite-dmhgll"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd genesis --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-rnqoru","container":"TestUpgradeTestSuite-rnqoru"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd collect-gentxs --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-kpxmvo","container":"TestUpgradeTestSuite-kpxmvo"}
{"level":"info","msg":"Genesis","chain_id":"chainB-1","test":"TestUpgradeTestSuite","hash":"075DC15AC8A5E4486E45B56CA6ECAB7F343E3B8291D669ECB15A56862F510164"}
{"level":"info","msg":"Genesis","chain_id":"chainB-1","test":"TestUpgradeTestSuite","hash":"075DC15AC8A5E4486E45B56CA6ECAB7F343E3B8291D669ECB15A56862F510164"}
{"level":"info","msg":"Will run command","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","container":"chainB-1-fn-0-TestUpgradeTestSuite","command":"simd start --home /var/cosmos-chain/simapp-b-2 --x-crisis-skip-assert-invariants"}
{"level":"info","msg":"Will run command","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","container":"chainB-1-val-0-TestUpgradeTestSuite","command":"simd start --home /var/cosmos-chain/simapp-b-2 --x-crisis-skip-assert-invariants"}
{"level":"info","msg":"Peering","chain_id":"chainB-1","test":"TestUpgradeTestSuite","host_name":"chainB-1-val-0-TestUpgradeTestSuite","peer":"02393ee44d113da5854633427ce0b27797b99263@chainB-1-val-0-TestUpgradeTestSuite:26656","container":"chainB-1-val-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Peering","chain_id":"chainB-1","test":"TestUpgradeTestSuite","host_name":"chainB-1-fn-0-TestUpgradeTestSuite","peer":"3811fc5ab7927fa83c7675e3bbbd44716a82dd8d@chainB-1-fn-0-TestUpgradeTestSuite:26656","container":"chainB-1-fn-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Starting container","container":"chainB-1-val-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Starting container","container":"chainB-1-fn-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Container started","container":"chainB-1-fn-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Container started","container":"chainB-1-val-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Genesis","chain_id":"chainA-1","test":"TestUpgradeTestSuite","hash":"8218AEEEF499525EA9F4DDF1C236802CF93760651EA01273C26158936B0168F4"}
{"level":"info","msg":"Genesis","chain_id":"chainA-1","test":"TestUpgradeTestSuite","hash":"8218AEEEF499525EA9F4DDF1C236802CF93760651EA01273C26158936B0168F4"}
{"level":"info","msg":"Will run command","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","container":"chainA-1-fn-0-TestUpgradeTestSuite","command":"simd start --home /var/cosmos-chain/simapp-a-1 --x-crisis-skip-assert-invariants"}
{"level":"info","msg":"Will run command","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","container":"chainA-1-val-0-TestUpgradeTestSuite","command":"simd start --home /var/cosmos-chain/simapp-a-1 --x-crisis-skip-assert-invariants"}
{"level":"info","msg":"Peering","chain_id":"chainA-1","test":"TestUpgradeTestSuite","host_name":"chainA-1-val-0-TestUpgradeTestSuite","peer":"df5126af43aee94e96faae5e5b49b575263fa3f1@chainA-1-val-0-TestUpgradeTestSuite:26656","container":"chainA-1-val-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Peering","chain_id":"chainA-1","test":"TestUpgradeTestSuite","host_name":"chainA-1-fn-0-TestUpgradeTestSuite","peer":"8b146c1f355bb502ef35426d02cf8a718bfaef3b@chainA-1-fn-0-TestUpgradeTestSuite:26656","container":"chainA-1-fn-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Starting container","container":"chainA-1-val-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Starting container","container":"chainA-1-fn-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Container started","container":"chainA-1-fn-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Container started","container":"chainA-1-val-0-TestUpgradeTestSuite"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-ffvbke","container":"TestUpgradeTestSuite-ffvbke"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainA-1 --mnemonic-file /home/hermes/chainA-1/mnemonic.txt --key-name chainA-1","hostname":"TestUpgradeTestSuite-xzuste","container":"TestUpgradeTestSuite-xzuste"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-sioggw","container":"TestUpgradeTestSuite-sioggw"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainB-1 --mnemonic-file /home/hermes/chainB-1/mnemonic.txt --key-name chainB-1","hostname":"TestUpgradeTestSuite-gascku","container":"TestUpgradeTestSuite-gascku"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-qfccmy","container":"TestUpgradeTestSuite-qfccmy"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainB-1 --mnemonic-file /home/hermes/chainB-1/mnemonic.txt --key-name chainB-1","hostname":"TestUpgradeTestSuite-epodbf","container":"TestUpgradeTestSuite-epodbf"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-rpeiqp","container":"TestUpgradeTestSuite-rpeiqp"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainA-1 --mnemonic-file /home/hermes/chainA-1/mnemonic.txt --key-name chainA-1","hostname":"TestUpgradeTestSuite-gusyxt","container":"TestUpgradeTestSuite-gusyxt"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-yconre","container":"TestUpgradeTestSuite-yconre"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainA-1 --mnemonic-file /home/hermes/chainA-1/mnemonic.txt --key-name chainA-1","hostname":"TestUpgradeTestSuite-sztptz","container":"TestUpgradeTestSuite-sztptz"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-sjhqqd","container":"TestUpgradeTestSuite-sjhqqd"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainB-1 --mnemonic-file /home/hermes/chainB-1/mnemonic.txt --key-name chainB-1","hostname":"TestUpgradeTestSuite-zpvkro","container":"TestUpgradeTestSuite-zpvkro"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-znppuc","container":"TestUpgradeTestSuite-znppuc"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainA-1 --mnemonic-file /home/hermes/chainA-1/mnemonic.txt --key-name chainA-1","hostname":"TestUpgradeTestSuite-abdmsu","container":"TestUpgradeTestSuite-abdmsu"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-ibxahl","container":"TestUpgradeTestSuite-ibxahl"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainB-1 --mnemonic-file /home/hermes/chainB-1/mnemonic.txt --key-name chainB-1","hostname":"TestUpgradeTestSuite-mmnsnb","container":"TestUpgradeTestSuite-mmnsnb"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-pqsuxu","container":"TestUpgradeTestSuite-pqsuxu"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainA-1 --mnemonic-file /home/hermes/chainA-1/mnemonic.txt --key-name chainA-1","hostname":"TestUpgradeTestSuite-gwtpok","container":"TestUpgradeTestSuite-gwtpok"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-tdbgnv","container":"TestUpgradeTestSuite-tdbgnv"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainB-1 --mnemonic-file /home/hermes/chainB-1/mnemonic.txt --key-name chainB-1","hostname":"TestUpgradeTestSuite-rmffzc","container":"TestUpgradeTestSuite-rmffzc"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-rmmqnb","container":"TestUpgradeTestSuite-rmmqnb"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainA-1 --mnemonic-file /home/hermes/chainA-1/mnemonic.txt --key-name chainA-1","hostname":"TestUpgradeTestSuite-uulldy","container":"TestUpgradeTestSuite-uulldy"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-kvlhah","container":"TestUpgradeTestSuite-kvlhah"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainB-1 --mnemonic-file /home/hermes/chainB-1/mnemonic.txt --key-name chainB-1","hostname":"TestUpgradeTestSuite-dxflwr","container":"TestUpgradeTestSuite-dxflwr"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-ztecpy","container":"TestUpgradeTestSuite-ztecpy"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainB-1 --mnemonic-file /home/hermes/chainB-1/mnemonic.txt --key-name chainB-1","hostname":"TestUpgradeTestSuite-izyxap","container":"TestUpgradeTestSuite-izyxap"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-yxaxie","container":"TestUpgradeTestSuite-yxaxie"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainA-1 --mnemonic-file /home/hermes/chainA-1/mnemonic.txt --key-name chainA-1","hostname":"TestUpgradeTestSuite-hvogwg","container":"TestUpgradeTestSuite-hvogwg"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-ffcmwk","container":"TestUpgradeTestSuite-ffcmwk"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainB-1 --mnemonic-file /home/hermes/chainB-1/mnemonic.txt --key-name chainB-1","hostname":"TestUpgradeTestSuite-rkwjln","container":"TestUpgradeTestSuite-rkwjln"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-pxwzhl","container":"TestUpgradeTestSuite-pxwzhl"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainA-1 --mnemonic-file /home/hermes/chainA-1/mnemonic.txt --key-name chainA-1","hostname":"TestUpgradeTestSuite-gfqoce","container":"TestUpgradeTestSuite-gfqoce"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-dbmpzr","container":"TestUpgradeTestSuite-dbmpzr"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainA-1 --mnemonic-file /home/hermes/chainA-1/mnemonic.txt --key-name chainA-1","hostname":"TestUpgradeTestSuite-uozmng","container":"TestUpgradeTestSuite-uozmng"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-nbdtxd","container":"TestUpgradeTestSuite-nbdtxd"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainB-1 --mnemonic-file /home/hermes/chainB-1/mnemonic.txt --key-name chainB-1","hostname":"TestUpgradeTestSuite-ybwcvu","container":"TestUpgradeTestSuite-ybwcvu"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-yrbepb","container":"TestUpgradeTestSuite-yrbepb"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainA-1 --mnemonic-file /home/hermes/chainA-1/mnemonic.txt --key-name chainA-1","hostname":"TestUpgradeTestSuite-svgqfh","container":"TestUpgradeTestSuite-svgqfh"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --config /home/hermes/.hermes/config.toml config validate","hostname":"TestUpgradeTestSuite-wkeumc","container":"TestUpgradeTestSuite-wkeumc"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes keys add --chain chainB-1 --mnemonic-file /home/hermes/chainB-1/mnemonic.txt --key-name chainB-1","hostname":"TestUpgradeTestSuite-ozqkvs","container":"TestUpgradeTestSuite-ozqkvs"}
=== RUN   TestUpgradeTestSuite/TestV7ToV8ChainUpgrade
    testsuite.go:208: Setting up path for: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade
    testsuite.go:239: establishing path between chainA-1 and chainB-1 on path path-1
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --json create client --host-chain chainA-1 --reference-chain chainB-1","hostname":"TestUpgradeTestSuite-wctnnf","container":"TestUpgradeTestSuite-wctnnf"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --json create client --host-chain chainB-1 --reference-chain chainA-1","hostname":"TestUpgradeTestSuite-zzahfi","container":"TestUpgradeTestSuite-zzahfi"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --json create connection --a-chain chainA-1 --a-client 07-tendermint-0 --b-client 07-tendermint-0","hostname":"TestUpgradeTestSuite-lydrjy","container":"TestUpgradeTestSuite-lydrjy"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --json create channel --order unordered --a-chain chainA-1 --a-port transfer --b-port transfer --a-connection connection-0 --channel-version ics20-1","hostname":"TestUpgradeTestSuite-ythred","container":"TestUpgradeTestSuite-ythred"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --json query channels --chain chainA-1 --show-counterparty --verbose","hostname":"TestUpgradeTestSuite-hmkavb","container":"TestUpgradeTestSuite-hmkavb"}
{"level":"info","msg":"About to start container","image":"ghcr.io/informalsystems/hermes:1.10.0","test_name":"TestUpgradeTestSuite","command":"hermes --json query channels --chain chainB-1 --show-counterparty --verbose","hostname":"TestUpgradeTestSuite-cqeqiz","container":"TestUpgradeTestSuite-cqeqiz"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys add TestUpgradeTestSuite/TestV7ToV8ChainUpgrade-chainA-1-psr --coin-type 118 --keyring-backend test --home /var/cosmos-chain/simapp-a-1","hostname":"TestUpgradeTestSuite-ofulye","container":"TestUpgradeTestSuite-ofulye"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys show --address TestUpgradeTestSuite/TestV7ToV8ChainUpgrade-chainA-1-psr --home /var/cosmos-chain/simapp-a-1 --keyring-backend test","hostname":"TestUpgradeTestSuite-vabxaz","container":"TestUpgradeTestSuite-vabxaz"}
{"level":"info","msg":"About to start container","chain_id":"chainA-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd tx bank send faucet cosmos1xsl7844zh96zsnaq95t9dqp6deckppjn5pls4q<PHONE_NUMBER>00atoma --gas-prices 0.00atoma --gas-adjustment 1.3 --from faucet --keyring-backend test --output json -y --chain-id chainA-1 --home /var/cosmos-chain/simapp-a-1 --node tcp://chainA-1-val-0-TestUpgradeTestSuite:26657","hostname":"TestUpgradeTestSuite-urzoqz","container":"TestUpgradeTestSuite-urzoqz"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys add TestUpgradeTestSuite/TestV7ToV8ChainUpgrade-chainB-1-uew --coin-type 118 --keyring-backend test --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-nvarij","container":"TestUpgradeTestSuite-nvarij"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys show --address TestUpgradeTestSuite/TestV7ToV8ChainUpgrade-chainB-1-uew --home /var/cosmos-chain/simapp-b-2 --keyring-backend test","hostname":"TestUpgradeTestSuite-xvkbyu","container":"TestUpgradeTestSuite-xvkbyu"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd tx bank send faucet cosmos1fy7l0gygsl8wrz5wxp2cg2nndvl2y5vgjd48ke<PHONE_NUMBER>00atomb --gas-prices 0.00atomb --gas-adjustment 1.3 --from faucet --keyring-backend test --output json -y --chain-id chainB-1 --home /var/cosmos-chain/simapp-b-2 --node tcp://chainB-1-val-0-TestUpgradeTestSuite:26657","hostname":"TestUpgradeTestSuite-jtptyq","container":"TestUpgradeTestSuite-jtptyq"}
=== RUN   TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/transfer_native_tokens_from_chainA_to_chainB
=== NAME  TestUpgradeTestSuite/TestV7ToV8ChainUpgrade
    tx.go:78: blocks created on chain chainA-1
=== RUN   TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/tokens_are_escrowed
=== RUN   TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/start_relayer
{"level":"info","msg":"Will run command","image":"ghcr.io/informalsystems/hermes:1.10.0","container":"hermes-path-1-qgcts","command":"hermes --config /home/hermes/.hermes/config.toml start"}
{"level":"info","msg":"Container started","container":"hermes-path-1-qgcts"}
=== RUN   TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/packet_is_relayed
=== RUN   TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/assert_ibc_denom_metadata
=== RUN   TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/upgrade_chain
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys add TestUpgradeTestSuite/TestV7ToV8ChainUpgrade-chainB-1-vzk --coin-type 118 --keyring-backend test --home /var/cosmos-chain/simapp-b-2","hostname":"TestUpgradeTestSuite-mjmdlq","container":"TestUpgradeTestSuite-mjmdlq"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd keys show --address TestUpgradeTestSuite/TestV7ToV8ChainUpgrade-chainB-1-vzk --home /var/cosmos-chain/simapp-b-2 --keyring-backend test","hostname":"TestUpgradeTestSuite-ujvlau","container":"TestUpgradeTestSuite-ujvlau"}
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd tx bank send faucet cosmos16h8v8e8akwqa4v5u8rprs6r5heptyfzv2jxref<PHONE_NUMBER>00atomb --gas-prices 0.00atomb --gas-adjustment 1.3 --from faucet --keyring-backend test --output json -y --chain-id chainB-1 --home /var/cosmos-chain/simapp-b-2 --node tcp://chainB-1-val-0-TestUpgradeTestSuite:26657","hostname":"TestUpgradeTestSuite-vyukmw","container":"TestUpgradeTestSuite-vyukmw"}
=== NAME  TestUpgradeTestSuite/TestV7ToV8ChainUpgrade
    tx.go:78: blocks created on chain chainB-1
{"level":"info","msg":"About to start container","chain_id":"chainB-1","test":"TestUpgradeTestSuite","image":"ghcr.io/cosmos/ibc-go-simd:v7.8.0-dev-e2e","test_name":"TestUpgradeTestSuite","command":"simd tx gov vote 1 yes --gas auto --gas-prices 0.00atomb --gas-adjustment 1.3 --from validator --keyring-backend test --output json -y --chain-id chainB-1 --home /var/cosmos-chain/simapp-b-2 --node tcp://chainB-1-val-0-TestUpgradeTestSuite:26657","hostname":"TestUpgradeTestSuite-uyzkay","container":"TestUpgradeTestSuite-uyzkay"}
{"level":"info","msg":"Will run command","image":"ghcr.io/cosmos/ibc-go-simd:v8.5.0","container":"chainB-1-val-0-TestUpgradeTestSuite","command":"simd start --home /var/cosmos-chain/simapp-b-2 --x-crisis-skip-assert-invariants"}
{"level":"info","msg":"Will run command","image":"ghcr.io/cosmos/ibc-go-simd:v8.5.0","container":"chainB-1-fn-0-TestUpgradeTestSuite","command":"simd start --home /var/cosmos-chain/simapp-b-2 --x-crisis-skip-assert-invariants"}
{"level":"info","msg":"Container started","container":"chainB-1-fn-0-TestUpgradeTestSuite"}
{"level":"info","msg":"Container started","container":"chainB-1-val-0-TestUpgradeTestSuite"}
=== RUN   TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/assert_ibc_denom_metadata_is_unchanged_post_upgrade
=== RUN   TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/IBC_token_transfer_from_chainA_to_chainB,_to_make_sure_the_upgrade_did_not_break_the_packet_flow
=== NAME  TestUpgradeTestSuite/TestV7ToV8ChainUpgrade
    tx.go:78: blocks created on chain chainA-1
=== RUN   TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/packets_are_relayed
=== NAME  TestUpgradeTestSuite
    testsuite.go:644: test passed, not uploading logs
    setup.go:168: Keeping containers - Docker cleanup skipped
--- PASS: TestUpgradeTestSuite (298.17s)
    --- PASS: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade (251.62s)
        --- PASS: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/transfer_native_tokens_from_chainA_to_chainB (12.65s)
        --- PASS: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/tokens_are_escrowed (0.00s)
        --- PASS: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/start_relayer (20.06s)
        --- PASS: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/packet_is_relayed (0.00s)
        --- PASS: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/assert_ibc_denom_metadata (0.00s)
        --- PASS: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/upgrade_chain (95.28s)
        --- PASS: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/assert_ibc_denom_metadata_is_unchanged_post_upgrade (0.00s)
        --- PASS: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/IBC_token_transfer_from_chainA_to_chainB,_to_make_sure_the_upgrade_did_not_break_the_packet_flow (13.49s)
        --- PASS: TestUpgradeTestSuite/TestV7ToV8ChainUpgrade/packets_are_relayed (0.00s)
PASS
ok  	github.com/cosmos/ibc-go/e2e/tests/upgrades	298.928s

in testing it seems this is not where the issue is coming from


Documentation link

Hi,
In a page
https://material.angular.io/components/datepicker/overview
in "Troubleshooting" subchapter
there is a broken link "Choosing a date implementation"
https://material.angular.io/#choosing-a-date-implementation-and-date-format-settings.
I think a valid address would be
https://material.angular.io/components/datepicker/overview#choosing-a-date-implementation-and-date-format-settings.

The anchor link works okay in the markdown file in this folder structure. I think when it gets compiled into the website, it causes the error anchor.


Setting TextInput 'focused' sometimes does not work

Problem description
A TextInput should get focused when the UI containing it has gets shown. This does not work in the case when the focused TextInput has been appended to a page, which is opened later.
Expected behavior
In the snippet below, the TextInput should get focused when its page gets opened.
Environment

Tabris.js version: 2.x-nightly
Device: iPad Air
OS: iOS 10.3

Code snippet
const {Page, NavigationView, TextInput, ui} = require('tabris');

let navigation = new NavigationView({
  left: 0, top: 0, right: 0, bottom: 0
}).appendTo(ui.contentView);

let page = new Page();

new TextInput({
  top: 20, left: '20%', right: '20%',
  message: 'Type here, then confirm',
  focused: true
}).appendTo(page);

page.appendTo(navigation);

This snippet is working properly as of 2.5.1. Tested on iOS 11.4. Closing.


Possible Issue about duplicated book names

Hi Mutlu,
There can be different books written by different authors but having the same titles. That may result in data loss. Can you check it, please?

Hi Kazım,
I have solved that problem with book ISBN number and I am saving cover photos in
[book name]-[book isbn].jpg format :)


Custom emoji support

:tada: This PR is included in version 1.29.0-dev.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Automatic Filling of Sign in/Register Form when clicking on either

On signing in or registration, we can currently click on either of the options and the respective form is loaded for filling details. But the cursor doesn't automatically go to the first form field for you to start filling in. You have to first scroll down and then fill the details which should be automatic when you click on sign in/register.
This would help in improving the user experience.

agreed, these pages need a redesign and this issue should be addressed

rename to 'Auto focus ..', maybe better

Completed in #650

Resolved in Resolve bugs #718


chore: adding support for x86_64-darwin

What kind of change does this PR introduce?
Minimum basis for supporting x86_64-darwin build

Do we need to build the artifacts as part of the CI builds? Having support for being able to do it sounds good though

It does help us to run these builds/checks. Usually a true full build only happens when something has changed in the source, otherwise it is passed over. Then, when some source is changed, the build for that part will happen, the results will be cached into our binary cache, and so then 90% of the rest of the builds will be able to deterministically refer to and use the cached version. In the case of this build, adding a new system did trigger a full build, but that is also what we needed to test, and achieve.
So it is typical practice in nix based systems to run both builds and checks like this in ci. It should actually trigger a full build only in the small minority of cases. And in those cases, you almost always want to test the build, and cache it if it succeeds.


[HUDI-4355] Bulk insert As Row: Should also repartiiton records if populateMetaFields is false

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
When populateMetaFields is false, NonSortPartitionerWithRows will be selected, but this partitioner actually not be used in the prepareHoodieDatasetForBulkInsertWithoutMetaFields
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

ping @yihua, Hi, Can we merge this now?

Close it since it's no longer needed


[BACKEND] Init values before load to avoid ptxas issues

I worry these kinds of small change overtime will decrease performance in ways we won't be able to track. Can we at least keep track of those by adding some TRITON_DISABLE_PTXAS_WORKAROUND environment variable?

I worry these kinds of small change overtime will decrease performance in ways we won't be able to track. Can we at least keep track of those by adding some TRITON_DISABLE_PTXAS_WORKAROUND environment variable? A compiler option would be even better actually

Yeah, I do understand the worry, but I'm afraid that it is not a "workaround" but something we have to do essentially to following PTX's specification. Otherwise, we could run into errors without reasonable explanations.

Yeah, I was not aware that ptxas actually planned to treat undefined register reads as undefined behavior in the whole compiler ... good to know!


Request for adding MTLNovel.

The thing is, I have realized that not all mtl is equal. As the translation quality varies a lot when comparing sites.
The site requested for adding to grabs.
https://www.mtlnovel.com/
Thank you.

From what I can see, the chapter list will require headless to get but the chapter body can be done the normal way. Will be in 2.8.1

Great!
Thanks.

Check out 3.0.0


incorrect type for ParExpression (re: type constructors)

A ParExpression node may be assigned a Type that is a type constructor despite its wrapped expression not being a type constructor.
In both examples below, the ParExpression is assigned the type <T> => T(T), whereas their wrapped expressions (FunctionArgument and IfExpression respectively) have type Integer(Integer):
    // example 1
    (<T>(T t) => t)(10);

    // example 2
    (if (1==1)
        then (<T>(T t) => t)
        else (<T>(T t) => t))(10);

|  |  |  |  |  +  [InvocationExpression] (2:4-2:22) : Integer
|  |  |  |  |  |  + () [ParExpression] (2:4-2:18) : <T> => T(T)
|  |  |  |  |  |  |  +  [FunctionArgument] (2:5-2:17) : Integer(Integer)
...
|  |  |  |  |  +  [InvocationExpression] (4:4-6:32) : Integer
|  |  |  |  |  |  + () [ParExpression] (4:4-6:28) : <T> => T(T)
|  |  |  |  |  |  |  + if [IfExpression] (4:5-6:27) : Integer(Integer)

It's an artifact of how type argument inference works, I suppose.


Update bots.md

Corrected markdown syntax for Covid19India Stats & News section.

I'm sorry, we are not maintaining related projects section anymore.


Implement group name restrictions

When they have been determined. Initial thoughts are 32 characters restricted to ASCII 0x21 through 0x7E.

Are we concerned about people with international keyboards who might be using a different keycode set by default?
Or just force everyone into ACSII and deal with one-offs as complaints?

This was a question I had on that other thread, what level of internationalization does the Minecraft client support? Keep in mind the DB table is set to latin1 so the current support is ASCII only.

Well, modifying the DB table is ... relatively easy, so I'm not too worried about that. Minecraft chat supports a fair amount of internationalization, and definitely supports a lot wrt signs. I'd have to do some more research to see the exact extent of that support, but I'd expect that since it's Java based, we're just dealing with UTF-8.

"relatively easy" Yes, it is. I was just mentioning that the current limitations force people to ascii already.
I thought there was a character glyph sheet in the resource pack...  shrug  I've never looked into it.

https://github.com/Civcraft/NameLayer/commit/f6107e33b3c8cce91b0b8b5b803d56da4e727e4b
https://github.com/Civcraft/NameLayer/commit/a07ac34b1bd412c06855152f3e1bec2bd34afbe9

Nice.


TAJO-1138 TestKillQuery.testKillQueryFromInitState fails occasionally

Simple fix ignoring exception thrown when starting scheduler in stage of KILL_WAIT or KILLED state.

TAJO-1138 was fixed by TAJO-1279, please close this PR


StatusBar should support snapping to top

I have an app where a menu doesn't make sense, but a legend of hotkeys does.
Because StatusBar tracks to bottom, and on some terminals (namely cmd.exe, Curses, and Net) don't (seem to) support terminal resizing console apps correctly, it is not an ideal control.
There are two ways of addressing my underlying ask:

Make MenuBar be able to act like a StatusBar with shortcuts, titles, and actions. This can be partially addressed (I have a PR in progress) by supporting MenuItems at the top-level of MenuBar. But not completely, because MenuBar doesn't support ctrl keys as shortcuts (as far as I can tell).

Make it so if an app doesn't want a MenuBar it can place a StatusBar at the top.

I have a PR with a modified StatusBar that almost does this ready. However, late in testing, I discovered that a bunch of core.cs has hard dependencies on both MenuBar and StatusBar (e.g. TopLevel.HasStatusBar).
So, to do #2 correctly that all needs to be refactored. I have half-a-mind to do this by refactoring both MenuBar and StatusBar on top of a base class TopBotttomBar that can address all the stuff core.cs needs to place things around them correctly. This would let MenuBar also work on the bottom if (god forbid) anyone ever wanted to do that. I would also enable folks to build additional controls.

The hotkeys for menu is Alt key. Alt + F open the File menu. I agree that both the menu and the status bar can be arranged at the top, button, left or right. I had to create the properties for HasMenuBar and HasStatusBar because the movement of the windows does not exceed the upper and lower limits. But everything can be redone, as long as it is to improve.

Here's my terminology. It may not be right and it may be overly influenced with my history in Windows:

Accelerator Keys - A way of accelerating access to menus. Almost always involve using the Alt key. E.g. Alt to open the menu, Alt-F to accelerate to the File menu). Accelerator keys enable navigating menus via keyboard. Some accelerator keys lead to direct invocation of commands, but this is rare.
Shortcut keys - A way of bypassing the menu altogether with simple keystrokes. E.g. Ctrl-C to copy, F1 for help. Shortcut keys invoke commands.

Right now gui.cs mixes and matches these concepts leading to confusion and inconsistent CX.
I'd like to work (over-time, not breaking things, always simplifying, always improving) towards greater consistency in gui.cs.

@tig you cannot trust in the Action Application.OnLoad because it is static and only the last invocation to it is called. Thus its use in the StatusBar contructor is never called because it is invoked later in the Demo.

I don't really believe this is needed anymore. Closing.