Functions should require callable instead of closures

I like using invokable objects, but these are not possible to use with Amp functions, like \Amp\async and so on without casting. Can we relax \Closure type requirement to callable instead?

We chose Closure for a few reasons:

The callable type in PHP is scope-dependent. What is callable in one scope may not be callable when attempting to invoke it from another scope (Luckily this problem will go away in PHP 9: https://wiki.php.net/rfc/deprecate_partially_supported_callables)
callable cannot be used as a class property (largely due to the above), so is more cumbersome to use.
First-class callable syntax makes it easy to create closures. [$this, 'method'] being a "callable" has always been strange IMO. $this->method(...) is far superior, clearly indicating that a closure is being created.
Using Closure does allow us to widen the type to callable at a later time without BC breaks

Invokable objects unfortunately suffer because of this decision. First-class callable syntax does work with invokable objects. async($object(...)) is clear that the intention is to pass a closure to be called. async($object) may be be confused for passing the object to be manipulated or a mistake if $object were not an invokable object.
I'm willing to consider changing Closure to callable in the future, but for the near term I think I'd like to keep Closure.

Fair enough, although I don't see how any of those 2 disadvantages are a factor for util functions. First one is more for authors of callables (me), second one for classes, while amp util functions are not classes. But of course, my position is purely from trying to have slightly nicer syntax. $object->method(...) looks fine in such trivial example, but what about multi line calls?  With callables accepted, I could do
with callables accepted, I could do
async(new Responder(
    $logger,
    $bufferer,
    $output,
    $this->customHttpHeaders,
    new ResourceInputStream(fopen($bufferer->filePath, 'rb')),
    $newConnDefer
));

without them, I have to do either
async((new Responder(
    $logger,
    $bufferer,
    $output,
    $this->customHttpHeaders,
    new ResourceInputStream(fopen($bufferer->filePath, 'rb')),
    $newConnDefer
))(...));

or
$responder = new Responder(
    $logger,
    $bufferer,
    $output,
    $this->customHttpHeaders,
    new ResourceInputStream(fopen($bufferer->filePath, 'rb')),
    $newConnDefer
);
async($responder(...));

and I'm not a fan of either. But again, it's something we all can live with, just adding my suggestion for minor improvement.

async(fn () => new Responder(
    $logger,
    $bufferer,
    $output,
    $this->customHttpHeaders,
    new ResourceInputStream(fopen($bufferer->filePath, 'rb')),
    $newConnDefer
));

Indeed, I think that one is good enough. Alright let's close then :)

Actually, in my cases I also need to pass arguments to Responder so above wouldn't work. with callable support I would be able to do
async(
  new Responder(
    $logger,
    $bufferer,
    $output,
    $this->customHttpHeaders,
    new ResourceInputStream(fopen($bufferer->filePath, 'rb')),
    $newConnDefer
  ),
  $socket,
);

but with arrow functions it would be
async(
  fn($arg) => (new Responder(
    $logger,
    $bufferer,
    $output,
    $this->customHttpHeaders,
    new ResourceInputStream(fopen($bufferer->filePath, 'rb')),
    $newConnDefer
  ))($arg),
  $socket,
);

which doesn't bring benefit over
async(
  (new Responder(
    $logger,
    $bufferer,
    $output,
    $this->customHttpHeaders,
    new ResourceInputStream(fopen($bufferer->filePath, 'rb')),
    $newConnDefer
  ))(...),
  $socket,
);

What in the hell are you talking about?

https://3v4l.org/dO0Me

Yes but that's arguably worse than https://3v4l.org/ZePLZ (desired) or https://3v4l.org/GZ5C8 ((...) syntax)

Stop trying to code other people's libraries for them.

Well, this doesn't look like it's going to be a productive discussion. Sorry that my fresh feedback from amp 2.x -> 3.x update experience bothered you. I was used to pass callable to asyncCoroutine, but this is no longer accepted. All I'm saying is I would prefer if I could still pass callables, because it's more flexible and has nicer syntax, that's it.

I also prefer to use callable, in amp v2, I have lots of code like call([$target, 'wakeup']),  but in php8.1, first-class callable syntax is acceptable as an alternative async($target->wakeup(...)).
In your example, a callable object implement __invoke is useful, but it's not commonly used.
class CallableThing {

    public function __invoke()
    {
    }

}

$callableThing = new CallableThing();
$callableThing();

So, for now, I think you should accept first-class callable syntax or use closure fn().


Improve CatBoost Pipeline

Currently for CatBoost pipelines we only allow most_frequent to be used with Simple Imputer because CatBoost natively handles categorical data and we need the imputer to as well. Should we keep this pipeline structure and this behavior. Or should we rethink this and remove the comment associated within the pipelines?

Closing, since I believe this was addressed by our change from SimpleImputer to Imputer.


Parsing of some post form data fails on empty fields

Some post form data containing empty field values fail to be parsed correctly, even though they are parsed successfully with other frameworks like python cgi or multiport. The problem is with such data (multiline for legibility):
--foo\r\n
Content-Type: text/plain; charset="UTF-8"\r\n
Content-Disposition: form-data; name=empty\r\n
\r\n
--foo\r\n
Content-Type: text/plain; charset="UTF-8"\r\n
Content-Disposition: form-data; name=text\r\n
\r\n
Some Text\r\n
--foo--

The field "empty" is indeed left empty. It's unclear from the RFC if it should be followed by 1 or 2 CRLF before the next field. Browsers usually use 2 CRLF, but the Google App Engine uses only 1 for data posted internally. The code below shows the difference between cgi, multipart and werkzeug in this case.
from io import BytesIO
from werkzeug.formparser import parse_form_data
import cgi
import multipart

data = b'--foo\r\nContent-Type: text/plain; charset="UTF-8"\r\nContent-Disposition: form-data; name=empty\r\n\r\n--foo\r\nContent-Type: text/plain; charset="UTF-8"\r\nContent-Disposition: form-data; name=text\r\n\r\nSome Text\r\n--foo--'

environ = {'CONTENT_LENGTH': str(len(data)),
        'CONTENT_TYPE': 'multipart/form-data; boundary="foo"',
        'REQUEST_METHOD': 'POST',
        'boundary': b'foo'}

print('### werkzeug')
environ['wsgi.input'] = BytesIO(data)
stream, form, files = parse_form_data(environ)
for k, v in form.items():
    print({'field': k, 'value': v})
print('###')

print('### cgi: ')
stream = BytesIO(data)
print(cgi.parse_multipart(stream, environ))
print('###')

print('### multipart')
environ['wsgi.input'] = BytesIO(data)
(form, files) = multipart.parse_form_data(environ)
for k, v in form.items():
    print({'field': k, 'value': v})
print('###')

Output:
### werkzeug
{'field': 'empty', 'value': '--foo\r\nContent-Type: text/plain; charset="UTF-8"\r\nContent-Disposition: form-data; name=text\r\n\r\nSome Text'}
###
### cgi:
{'text': ['Some Text'], 'empty': ['']}
###
### multipart
{'field': 'empty', 'value': ''}
{'field': 'text', 'value': 'Some Text'}
###

As you can see, werkzeug thinks that the value of the empty field is the boundary and what follows as it apparently expects 2 CRLF. Other frameworks correctly return both values, empty and not empty.
Environment:

Python version: 3.11
Werkzeug version: 2.2.3

but the Google App Engine uses only 1 for data posted internally

Sounds like a bug that should be reported to App Engine.

I did report the issue, but I kind of expect the same answer: "it works with all other frameworks, sounds like a bug in werkzeug".

If there are relevant details, such as a linked issue report in another project, be sure to actually link to it in the issue description.

Issue with the Google App Engine: https://github.com/GoogleCloudPlatform/appengine-python-standard/issues/77
(note the quote from the RFC may not be a definite answer as it talks about absence of headers, not absence of data).

I'll look into supporting this, I think the CRLF is optional given body-part := MIME-part-headers [CRLF *OCTET] hence the [] part is optional.


Can other body parts be controlled?

It's the part that a lot of people want

yes,Possible.
Specifically, the fingertips can be controlled by attaching electrodes to the wrist.
However, because of the complex structure of human limbs, it is difficult at this stage to use this system for delicate tasks.
Also, walking on the feet is nearly impossible because of the difficulty in manipulating the major leg muscles from the surface.
This is a video of an electrically controlled finger.
As shown here, movements such as bending the fingers to roughly grasp an object or push a button are possible.
https://youtube.com/shorts/DI06kOiP-q8?feature=share

I mean the third leg

OK, I understand.
The only part of the body that can be controlled is the area where the muscles are located.

Put electrodes on Pe**s ? what an odd thought.

@Sologala  I think it is a good idea!!!


Integration with Django

I made an integration with django that doesn't interfere with the code or with the tables already created in the database.
An auxiliary table is created to insert the new data, and it is possible to perform queries and CRUDs by Django Admin.

Why ????

Oh, i just looked, I thought you re writed the bot in python but no

Hey, just wondering what benefits will integrating with Django bring?
I don't really see a need for a webserver so I'm just asking this (especially non-node stack).

Moved to ./django/ in the last push

If query is needed, you can always run an external database and connect directly to it along with the bot. For any other direct bot interactions and callbacks, I can create a much less complicated REST API/webhook (Express) or Message Queue (AMQP) System.
I like the feature, but it's just adding too much complexity to the codebase without knowing if other users will actually use this. As always, if @Sayrix is okay with this, we can add it.

The way I did it, I don't think it's the best, but since I didn't want to interfere with the bot's operation and I don't have much knowledge in javascript, I ended up doing this "workaround" lol

I had changed some files by mistake, now they must be with the changes you made.

Moved the readme into the Django folder

[ ]  Hey, mind cleaning up .gitignore a bit?
I feel like not all of the files/directories that's listed will be generated when running the Django.
If I'm wrong, let me know.

I was using the .gitignore python template, now it should be just the essentials

[ ]  DJANGO.md and django/README.md seems to be a duplicate file

I removed the DJANGO.md

[ ]  django/trigger.py seems to have print("aaaaa"), not sure if you accidently left it there during development.

This was a print used for debugging that I ended up forgetting to delete

[ ]  Both django/tickets/tests.py and django/tickets/views.py are incomplete. if no test will be written, you can go head and delete it.

They are standard Django files, but as they won't be needed I removed them


Send Security Hub Findings to reletive account

Hi,
This is only a question. I wonder if there's a way that I can  filter findings based on account IDs and send them to the right accounts based on their account IDs?
Thanks
Ali

@devalibvr , I'm not sure if you are referring to this recurring email solution or something else?
For this email solution you could customize the custom insights for specific accounts.  Depending on the amount of accounts you have that could be a lot of custom insights to manage.
If you mean for solution that sends a notification when the finding is discovered, one solution could be to setup an eventBridge rule with SNS to notify an account holder of a new or changed Security Hub finding - https://repost.aws/questions/QUJu7GM_ltS_unhhrEVleKCg/how-to-receive-email-alert-when-compliance-status-changes-to-failed-for-particular-test-in-security-hub


chore(main): release 0.0.10

:robot: I have created a release beep boop
0.0.10 (2024-08-23)
Bug Fixes

embedding structs related to validationrule.Interface (#135) (166aece)

Other

assert that PluginSpec is implemented (#133) (e280094)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.10
:sunflower:


Add documentation to customize APIcast

With the new modular architecture, it'd be good to create some documentation which explains how to add custom behavior to the gateway by creating a module.
cc @andrewdavidmackenzie

This is good use case for an example. We have examples folder with common customizations that people can execute.

Also how to add ssl https://github.com/3scale/apicast/pull/141 and how to build a docker image with customizations https://github.com/3scale/apicast/pull/144. Also making sample module in #140.


[DOC] Code cells are not copyable easily

What were you looking for/trying to do?:
Often when working through examples in the documentation we want to copy code any play with it.
What was missing from the docs or not clear enough?:
However the way code cells are currently rendered there is no easy way to do a copy (we can literally type things out, or copy the whole thing over and then get rid of the line numbers and ... etc).
How could the docs be improved? Additional examples, different wording, etc.
Renderering copyable code cells would be great, one example is here: https://m2lines.github.io/L96_demo/notebooks/L96-two-scale-description.html (which was achieved by @IamShubhamGupto). Wondering if doing the switch is easy?

Hey @dhruvbalwada
I would be happy to help you out with this. I just glanced over XGCMs code blocks and they seem to have line numbers enabled, and have input output on the same block. This makes it hard to copy paste the code.
I did not see a similar setup the L96_demo where we had a _config.yml. Im guessing some setting file would be similar to achieve what youre looking for.
cc @jbusecke if maybe you can point us in the right direction

@jbusecke bumping this up in notifications

@dhruvbalwada @jbusecke

Some progress today after setting up the docs locally, we need to setup the data locally too if we're going to compile during build
Please help me find the data used by all tutorials, thanks

I achieved this by making 2 changes

updated sphinx to the latest version - don't think this helped
changed all cells to code block and told nbshphinx to always execute

Thanks for all the work here @IamShubhamGupto.
Can you make a PR with these changes to the repo so we can discuss the changes in more detail? I believe RTD should generate a preview of the docs on PRs so we can check how your changes would affect the actual outcome.

Some progress today after setting up the docs locally, we need to setup the data locally too if we're going to compile during build

If you could add the way you set this up locally to our contributor guide that would be very helpful.

@jbusecke it'll be ready in the next couple of days, from my experiments, I cannot execute code with separated code blocks like in https://m2lines.github.io/L96_demo/intro.html from rst files.
It might be a limitation of documentation type. Instead I will be converting them to .ipynb files.
Also could you help me find ../datasets/mitgcm_example_dataset_v2.nc used by grid_metrics?thanks

Also could you help me find ../datasets/mitgcm_example_dataset_v2.nc used by grid_metrics?
I think you might have caught a long standing bug here (quick look up makes me think that the dataset is the same as in https://xgcm.readthedocs.io/en/latest/xgcm-examples/02_mitgcm.html). But this exposes a bigger issue:
We actually do not execute our code on build, but we clearly should.

I cannot execute code with separated code blocks like in https://m2lines.github.io/L96_demo/intro.html from rst files.

I am fairly sure that you can do that with sphinx somehow (maybe it requires an extension). But maybe your intuition is right here, more on that below. In general we should be able to provide a mix of notebooks, md, rst files and have them all execute code?

Instead I will be converting them to .ipynb files.

I am not 100% sure if converting the entire docs page to notebooks is the right way forward (yet), but your suggestion of modernizing the docs would certainly be very welcome! I suggest we start with an issue that enumerates all the docs related past issues and then think about a way forward? To set expectations a bit. I think this is a larger project since there are likely a bunch more of these (#573 for example) hiding in the docs.
Again thank you so much for putting in the time here, I really appreciate this!

Hey @jbusecke I experimented with the following packages hoping to execute python same as Jupyter notebooks do it, unfortunately none gave the desired result

I am fairly sure that you can do that with sphinx somehow (maybe it requires an extension). But maybe your intuition is right here, more on that below. In general we should be able to provide a mix of notebooks, md, rst files and have them all execute code?

https://pypi.org/project/sphinx-autorun/
https://yongrenjie.github.io/sphinx-exec-directive/ - looked promising, but just did not render any of the code blocks in the final html
doctest

I might be hyper focused here and might have missed something so I'll retry after some time.
Converting to ipynb is not the most elegant solution, its just something im familiar with.

Instead I will be converting them to .ipynb files.

I am not 100% sure if converting the entire docs page to notebooks is the right way forward (yet), but your suggestion of modernizing the docs would certainly be very welcome! I suggest we start with an issue that enumerates all the docs related past issues and then think about a way forward? To set expectations a bit. I think this is a larger project since there are likely a bunch more of these (#573 for example) hiding in the docs.

Ill debug this for now and come back issue to this soon


Outdated supermarket.io

Hi,
On supermarket.io, the last update of this library was 0.1.4 from Updated December 4, 2014. Since this code is now at 0.1.8 already, could you publish this library again? Thanks!
Best regards.

Updated.

Thank you!


Empty ERROR message

Describe the bug
When typescript check option is  true always getting this message

 ERROR
[TypeScript] Found 0 errors. Watching for file changes.

I tried to debug it and added log with *** action to the main.js plugin source  file.

And since this action treaded as an Error on line 182 we just added prefix ERROR.

Reproduction
in vite config
import checker from 'vite-plugin-checker'
...
plugins: [
    checker({ typescript: true })
]

Expected behavior
Action {   type: 'console',   payload: '\n[TypeScript] Found 0 errors. Watching for file changes.' } should't be logged as an Error
System Info
System:
    OS: macOS 13.3.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 1.87 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.14.0 - ~/.nvm/versions/node/v18.14.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.14.0/bin/yarn
    npm: 9.3.1 - ~/.nvm/versions/node/v18.14.0/bin/npm
  Browsers:
    Chrome: 113.0.5672.126
    Safari: 16.4
  npmPackages:
    vite-plugin-checker: 0.6.0 => 0.6.0

### Additional context

_No response_

### Validations

- [X] Read the [docs](https://github.com/fi3ework/vite-plugin-checker#readme).
- [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Any progress on this? Seems like the only option is to revert to 0.4.9

Actually, the acuse seems to have been introduced in 0.5.6

Error: no errors were found.

IM GONNA REEEE

Happening for me with nuxt 3.8.2 on a fresh install/setup

Same for me? Any workaround for this?

Actually, the change seems to have been introduced in 0.5.6

I figured out where the problem got introduced, but there's been no addressing of it thus far

This line looks like it might be the root of the issue. https://github.com/fi3ework/vite-plugin-checker/commit/8dd49159bddd7e3e23dfa479323322808094d8b9#diff-7c457428fc11687ac503085166d754dc2dbdaa3df69069d3027272bda149ba5cR189
I found that while trawling through the diff between v0.5.5 and 0.5.6 https://github.com/fi3ework/vite-plugin-checker/compare/vite-plugin-checker%400.5.5...vite-plugin-checker%400.5.6

@james-yeoman I'm seeing the same.  Unsure why it would log if Checker.logger is empty, maybe an oversight?

So the logger comes from Vite itself. I wonder why this plugin isn't receiving the logger from Vite... https://github.com/fi3ework/vite-plugin-checker/commit/8dd49159bddd7e3e23dfa479323322808094d8b9

Ok, so vite-plugin-checker is receiving the logger from vite, I'm just a dunce...
The actual problem, is that Checker.logger is never populated, and the colouring of diagnostics and summaries are already handled by diagnosticToTerminalLog and composeCheckerSummary in vite-plugin-checker/src/logger.ts.
There's currently no way of differentiating between an error, a warning, and a checker summary.
This is beyond what I can justify spending time on during work, but hopefully my findings help someone who can spend more time on open source to fix this

As a workaround, I've got a fork that I've added a bypass to in order to avoid erroring on an empty summary. It's not the cleanest, but it allows me to adopt the ESLint Flat Config without too much problem

:/ I use yarn and so can't reference the fork since this plugin uses pnpm...
guess I'm back to using yarn patches instead...

So, no solution to this so far?
lol

Hey so I had the same problem and I managed to implement a workaround:
Vite offers the functionality to customize the logs: https://vitejs.dev/config/shared-options.html#customlogger
So I converted some errors from vite-plugin-checker to an info:
import { defineConfig, createLogger } from "vite";
import os from 'node:os'

const logger = createLogger()
const loggerErr = logger.error

logger.error = (msg, options) => {
    if (msg.match(/.*\[ESLint\] Found 0 error and 0 warning.*/)) {
        logger.info(msg, options)
        return
    }

    if (msg.match(/.*\[TypeScript\] Found 0 errors. Watching for file changes.*/)) {
        logger.info(msg.replace(os.EOL, ""), options)
        return
    }

    loggerErr(msg, options)
}

export default defineConfig({
    customLogger: logger
});

With those changes my output looks like this:

Hope this helps someone.

@fi3ework could this patch be merged into this repo? still happening on the latest version


Integration of Cambridge Semantics AnzoGraph DB in LangChain community (graphs and chains)

[x] PR title: "community: add integration to AnzoGraph DB"

[x] PR message:

Description: To support the integration of the AnzoGraph DB graph database system, we included Python modules and modified Python files within LangChain's GraphQA chains and LangChain Community graphs. We developed two modules and modified one init.py file and one prompts.py module to enable support for Cambridge Semantics' AnzoGraphDB. One langchain_community init.py file was modified to include the path for the AnzoGraph DB graph module. The prompts.py file (located in langchain_community/chains/graph_qa) was modified to incorporate AnzoGraph DB prompt templates.
Dependencies: pip install rdflib and pip install sparqlwrapper (included in pyproject.toml and poetry.lock)
Twitter handle: @MarcCorrAI

[x] Add tests and docs:

Unit test for testing the integration file is included in folder <langchain\docs\docs\integrations\graphs>, accompanied by the foaf ontology file to perform the test locally.
Both integration files were added, as requested:
anzograph.ipynb (path in LangChain website: components/graphs/AnzoGraphDB), for inclusion at  https://python.langchain.com/v0.1/docs/integrations/graphs/
and anzograph.mdx (path in LangChain website: providers/AnzoGraphDB) for inclusion at   https://python.langchain.com/v0.1/docs/integrations/providers/

[x] Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/
"Make tests" were run (test, format_diff, lint_diff, spell_fix). One pytest and unittest is included in the directory "langchain/libs/community/tests/unit_tests/graphs".

I can not view the Build Status of this failed deployment.
I ask for support to analyze if some changes I promoted are breaking the Vercel deployment.
In https://github.com/langchain-ai/langchain/actions/runs/9184543771 I have the warning:
This workflow is awaiting approval from a maintainer in https://github.com/langchain-ai/langchain/pull/22012
I am encountering a challenge with our CI/CD process on Vercel.
Unfortunately, I am unable to access the deployment log files for the recent builds.
This issue is preventing me from diagnosing and resolving errors that have occurred during the deployment process.

I reviewed/rebuilt the two poetry.lock and pyproject.toml.
Please try to merge it.
@baskaryan

I'm passing all the tests except for some tricky ones on date formats. However, I don't use these modules and I'm not sure what that means.
Could you please help resolve this issue?
Thank you

@baskaryan

I'm passing all the tests except for some tricky ones on date formats. However, I don't use these modules and I'm not sure what that means. Could you please help resolve this issue?
Thank you
@baskaryan

@baskaryan @hwchase17
Hi everyone,
We've been waiting for support on this issue for a while. Even after running make test on an updated master branch, the assertion errors remain. We believe it is a condition that is out of our control.
We'd like to ask you to review this issue regarding the failing unit tests mentioned below:
FAILED tests/unit_tests/chat_loaders/test_imessage.py::test_imessage_chat_loader_upgrade_osx11 - AssertionError: date failed to parse
FAILED tests/unit_tests/chat_loaders/test_imessage.py::test_imessage_chat_loader - AssertionError: date failed to parse
Thank you!


Componentarray

Codecov Report

Merging #12 (dfaa0b9) into main (e6e6c7e) will decrease coverage by 8.28%.
The diff coverage is 88.42%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   98.43%   90.15%   -8.29%
==========================================
  Files           6        9       +3
  Lines         128      264     +136
==========================================
+ Hits          126      238     +112
- Misses          2       26      +24

Impacted Files
Coverage Δ

src/MTKHelpers.jl
100.00% <ø> (ø)

src/util.jl
100.00% <ø> (+7.14%)
:arrow_up:

src/abstractproblemparsetter.jl
66.66% <66.66%> (ø)

src/util_componentarrays.jl
71.73% <71.73%> (ø)

src/problemparsetter.jl
95.31% <94.91%> (-4.69%)
:arrow_down:

src/problemparsetter_sym.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e6c7e...dfaa0b9. Read the comment docs.


Multi bot fixes

Prevent errors when threads are more than accounts
Fix multi bot not running as it should be on Mac
Fix proxies not properly set on certain platform (Please raise an issue if your platform is not supported)
Fix bot not exiting when it should. (Example: When level reached)
Keyboard interrupts now able to stop the bot

👍


Upgrade rustls to 0.23

With rustls 0.23 there is no longer a dependency on ring, allowing easier compilation for various targets.
Not super confident with my updates to ServerCertVerifier and Der of certificates (is this being tested?), needs review.

Version 0.21 has also other issues...
Crate:     rustls
Version:   0.21.7
Title:     `rustls::ConnectionCommon::complete_io` could fall into an infinite loop based on network input
Date:      2024-04-19
ID:        RUSTSEC-2024-0336
URL:       https://rustsec.org/advisories/RUSTSEC-2024-0336
Severity:  7.5 (high)
Solution:  Upgrade to >=0.23.5 OR >=0.22.4, <0.23.0 OR >=0.21.11, <0.22.0

Apologies for the substantial mess this caused!
When making this PR it allowed some android target to build where I was having substantial trouble with ring. It has broken many other targets however and this was not readily apparent.
I think in the future I should take more time to test across other targets?
Big thanks for your work resolving this @thunderbiscuit


[#SUPPORT] Add IP from MOJ digital and technoogy to access

What?
As per ticket #3714 [1], add the IP of MOJ to the whitelist to access
the API endpoints.
[1] https://gaap.deskpro.com/agent/#app.tickets,t:3714
How to review
Code review
Who?
Anyone but @keymon

I can confirm that the IP is same as in the ticket.

LGTM. Merging.


Apply custom fonts to header title, date and month

I need to apply custom fonts to header title , date and month.
Also i want to reduce spacing between month of days.
Thanks in advanced !!

https://github.com/prolificinteractive/material-calendarview/pull/582

Now in the build: https://github.com/prolificinteractive/material-calendarview/pull/782


fix(versions): update Activiti/example-runtime-bundle versions into master

UpdateBot pushed helm dependency: common to: 1.1.6

UpdateBot commands:
updatebot push-version --kind helm common 1.1.6

UpdateBot commands:
updatebot push-version --kind helm common 1.1.7


tf.random.categorical overflow before OOM on GPU

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04 LTS
TensorFlow version (use command below): 2.2.0 and 2.1.0
Python version: 3.x
CUDA/cuDNN version: 10.1
GPU model and memory: V100 32GB

Describe the current behavior
When running the tf.random.categorical with a large num_samples on a V100 with 32GB we get the following crash:
2020-07-15 21:58:02.621909: F ./tensorflow/core/util/gpu_launch_config.h:129] Check failed: work_element_count > 0 (-2099511296 vs. 0)
Aborted (core dumped)

This looks like an overflow before raising the OOM error.
Here a minimalist code which reproduces the aborted (core dumped) on the V100 with 32GB:
import tensorflow as tf
probs = tf.random.uniform((2 ** 15,), dtype=tf.float64)
probs = probs / tf.reduce_sum(probs)
logits = tf.math.log(probs)
samples = tf.random.categorical(logits[tf.newaxis], 70000, dtype=tf.int64)[0]

Here some tests on different cards:

V100 32GB, cuda 10.1, tf2.2 and tf2.1: Aborted (core dumped)
V100 16GB, cuda 10.1, tf2.1: OOM
TitanV 12GB, cuda 10.2, tf2.2: OOM
RTX2080TI, 12GB, cuda 10.2, tf2.2: OOM

This issue only happens on V100 with 32GB.
Describe the expected behavior
The code should raise a Resource Exhausted OOM error instead of being aborted.

@amahendrakar, good idea, thanks.
If I limit the V100 32GB to use just 16GB then I get the OOM error, as expected.
However, if I increase the memory to 18GB, then I get the usual Aborted (core dumped).

@scarrazza Sorry for the late response. I tried reproducing it with recent TF2.4rc3 in colab but didn't see OOM or coredump. Here is the gist for reference.
Can you please check and let us know whether the error still persists in recent TF version? Thanks!

@jvishnuvardhan I have tested your gist on Colab, however tensorflow-gpu==2.4rc3 doesn't seem to detect the GPU (check the tf.config.list_physical_devices() on your notebook), your code is running on CPU.
I also tried to install 2.4rc3 on other machine with larger GPU memory however also there it doesn't detect the GPU device, so I can't test.

I have tried this using TF 2.5 version ,please check this gist here..Thanks !

Closing this issue as it is fixed in latest version of TensorFlow. Please feel free to reopen the issue if you still have a concern. Thanks!


sys.version is not set in hosted runtimes

Description
In the latest source, the sys.version property is not set when running in a runtime created programmatically (as opposed to ipy.exe)
Steps to Reproduce

Using LINQpad (or .net project) add source and run:

var code =
@"
import sys
print sys.version";

var _engine = IronPython.Hosting.Python.CreateEngine();

var runtime = _engine.Runtime;
var scope = _engine.CreateScope();

var source = _engine.CreateScriptSourceFromString(code, SourceCodeKind.AutoDetect);
source.Execute(scope);

Expected behavior: [What you expected to happen]
2.7.10a1 (<IP_ADDRESS>1)\n[.NETFramework,Version=v4.5 on .NET Framework 4.7.3324.0 (64-bit)]
(or similar) is shown
Actual behavior: [What actually happened]
None
is shown
Versions
2.7.10a1 (<IP_ADDRESS>1)\n[.NETFramework,Version=v4.5 on .NET Framework 4.7.3324.0 (64-bit)]
(appears to be anything after #622 )

Thanks! This one should be fixed by https://github.com/IronLanguages/ironpython2/pull/670


Translate readme to brazilian portuguese

Description
This PR create a doc folder to receive translations of all important files in other languages. Improving for more people access of all this knowledge. Starting with brazilian portuguese.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

Thanks for the contribution. It's not really feasible for us to maintain the readme in different languages, though.


solve amop bug

Codecov Report

Merging #137 into dev will increase coverage by 1.01%.
The diff coverage is 34.55%.

@@             Coverage Diff              @@
##                dev     #137      +/-   ##
============================================
+ Coverage     16.03%   17.05%   +1.01%
+ Complexity      793      653     -140
============================================
  Files           452      411      -41
  Lines         15296    12208    -3088
  Branches       1629     1419     -210
============================================
- Hits           2453     2082     -371
+ Misses        12601     9905    -2696
+ Partials        242      221      -21

Impacted Files
Coverage Δ
Complexity Δ

...java/org/fisco/bcos/sdk/abi/ABICodecException.java
0.00% <ø> (ø)
0.00 <0.00> (?)

...src/main/java/org/fisco/bcos/sdk/abi/Constant.java
75.00% <ø> (ø)
1.00 <0.00> (?)

...main/java/org/fisco/bcos/sdk/abi/EventEncoder.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

.../main/java/org/fisco/bcos/sdk/abi/EventValues.java
0.00% <ø> (ø)
0.00 <0.00> (?)

.../org/fisco/bcos/sdk/abi/FunctionReturnDecoder.java
0.00% <ø> (ø)
0.00 <0.00> (?)

.../main/java/org/fisco/bcos/sdk/abi/TypeDecoder.java
40.67% <ø> (ø)
17.00 <0.00> (?)

.../main/java/org/fisco/bcos/sdk/abi/TypeEncoder.java
51.64% <ø> (ø)
18.00 <0.00> (?)

...a/org/fisco/bcos/sdk/abi/TypeMappingException.java
0.00% <ø> (ø)
0.00 <0.00> (?)

...ain/java/org/fisco/bcos/sdk/abi/TypeReference.java
0.00% <ø> (ø)
0.00 <0.00> (?)

...bi/src/main/java/org/fisco/bcos/sdk/abi/Utils.java
0.00% <ø> (ø)
0.00 <0.00> (?)

... and 612 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b5338...2468cad. Read the comment docs.


Make sure tf cache is enabled

Description
2 small changes.

Rename CldCtlConfig to ArcCtlConfig so it makes more sense.
Make sure tf plugin cache is actually enabled.

Closes issue
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Enable logging with export TF_LOG=debug and then run up in verbose mode. You can see it hits the cache and then you can also go look at ~/.config/arcctl/tf-cache and see the contents of the folder exists.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

@mueschm want to update this PR to make tests pass so we can merge it in?


OU-379: Add datasource parameter to handle metrics from custom datasources

This PR:

Adds support for metrics to fetch data from a custom datasource registered using the console-dashboards-plugin
Adds a datasource URL param with the name of the custom datasource, so when clicking on a dashboards that contains a custom datasource the metrics are loaded form the correct backend

/jira refresh

/cherry-pick release-4.15


replaced list with tolist

Fixes an issue with list function no longer being available.
Terraform version 1 reported issue:
Call to function "list" failed: the "list" function was deprecated in Terraform v0.12 and is no longer available; use tolist([ ... ]) syntax to write a literal list.

replaced some depreciated functions


Tri-tri intersect returns unreasonable intersection segment when tris have shared edge.

I've run into an issue with:
Volume_08/Number_1/Guigue2003/tri_tri_intersect.c
See the Matlab code below that will create this figure:

t0 = [-2.000000000000000000000000e+02 -7.661661997582373651027865e+00 1.107006972331142975463081e+02; % A
      -2.000000000000000000000000e+02 -1.532332399516475796019677e+01 1.214013944662285808817614e+02; % B
      -2.000000000000000000000000e+02 -1.041705198583709623960658e+01 1.221265882878931563482183e+02; % C
      -2.000000000000000000000000e+02 -7.661661997582373651027865e+00 1.107006972331142975463081e+02];

t1 = [-2.000000000000000000000000e+02 -1.532332399516475796019677e+01 1.214013944662285808817614e+02; % D
      -2.000147534839701108921872e+02 -5.208525992918542790732772e+00 1.110632941439465781741092e+02; % E
      -2.000000000000000000000000e+02 -1.041705198583709623960658e+01 1.221265882878931563482183e+02; % F
      -2.000000000000000000000000e+02 -1.532332399516475796019677e+01 1.214013944662285808817614e+02];

e0 = [-2.000000000000000000000000e+02 -1.148161784440646755456328e+02 1.066954011562485078457030e+02; %G
      -2.000000000000000000000000e+02 -1.041705198583709623960658e+01 1.221265882878931563482183e+02]; % H
figure( 2 );
plot3( t0(:,1), t0(:,2), t0(:,3) )
hold on;
plot3( t1(:,1), t1(:,2), t1(:,3) )
plot3( e0(:,1), e0(:,2), e0(:,3), '-o' )
hold off;
axis equal;
axis off;

For these two triangles, points B and D are congruent and points C and F are congruent.  I.e. they share an edge.
In this case, one of the intersection end points comes back as one of the endpoints of the shared edge.  I would expect the other intersection end point to come back as the other endpoint of the shared edge.  However, instead it is a point located far away.
Point H is at point C/F.
Point G is far away.
All intersection points should lie on/within both triangles.

Sorry, just noticed this (I finally fixed my GIthub notifications so they work correctly). I've written the first author and hope for a response.

Hi,
This problem results from a rounding error issue similar to the one detected in https://github.com/erich666/jgt-code/issues/9 ,
that is,  in some edge cases and because of the limited precision of IEEE floating point arithmetic, some coplanar triangles' vertices are not detected as they should be.
To use the proposed fix (https://github.com/erich666/jgt-code/pull/12) you just have to set the USE_EPSILON_TEST macro to true in the code (it is set to false by default).
The new EPSILON value is set to 1e-16 in the PR to cover the case above, the greater computed faulty determinant being evaluated to about 6.93e-18.

Hopefully this fix (merged) addresses this bug. Let us know, @ramcdona, if it doesn't.

Thanks for the patch, I'll give it a shot.
I had moved away from Thomas Möller's version exactly because of this epsilon test and the hope that this code would be more robust to floating point issues.
I've gone a ways down the rabbit hole of tri-tri intersection codes in the literature.  I've found a few that claim to be provably robust (using robust geometric predicates for all conditionals).  Unfortunately, they don't seem to have a publicly released implementation.
It would seem that despite this being a 'solved problem', there is perhaps need for yet another solution.


Use semver for handlebars in package.json

I see this package was recently updated to use<EMAIL_ADDRESS>-- but in order to continue picking up bugfixes, shouldn't it be versioned as ^3.0.0 in package.json?
https://docs.npmjs.com/misc/semver#caret-ranges-1-2-3-0-2-5-0-0-4

no. I dislike this approach because handlebars can introduce subtle changes even for minor versions that will break code. Safest is to use a specific version and upgrade as needed. Caret ranges are bad for module use over the longer term.
If you want to use a newer handlebars we can do a PR (if there is a specific feature or fix) or you can specify your own version for hbs to use iirc.


Does Malayalam really require ZWS ?

Can we use ZWNJ instead of ZWS ?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/3611944-does-malayalam-really-require-zws?utm_campaign=plugin&utm_content=tracker%2F493413&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F493413&utm_medium=issues&utm_source=github).

This is a really old issue. Closing it. Feel free to re-open if you still want this modification.


Interpreter shown in the status bar is not the selected one on MacOS

Environment data

VS Code version: 1.57.0-insider commit 54d33cf14c
Extension version (available under the Extensions sidebar): 2021.5.821509413-rc
OS and version: macOS Big Sur 11.2.3
Python version (& distribution if applicable, e.g. Anaconda): 3.10.0a5 (global), 3.6.9 venv
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Relevant/affected Python packages and their versions: N/A
Relevant/affected Python-related VS Code extensions and their versions: N/A
Value of the python.languageServer setting: Pylance

Expected behaviour
Interpreter shown in the status bar should be the selected interpreter.
Actual behaviour
Interpreter shown is whatever the extension could find (it's not even the interpreter I use in python.defaultInterpreterPath and I opted into all experiments), in this case /usr/local/bin/python3.
Notes:

Opening a new terminal will activate the correct interpreter.
Selecting a different interpreter in the quickpick will update the status bar to the correct one.
Opening another Python file will also update the status bar.

Note the difference between the interpreter in the bottom left, and the current interpreter in the quickpick:

Steps to reproduce:

Open a Python project, install the extension, reload the window and wait for the extension to activate
Notice that the interpreter shown in the status bar is not the one selected for the project

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

User belongs to experiment group 'All'
Python interpreter path: /usr/local/bin/python3
Error 2021-05-10 12:03:52: The .project file inside environment folder: /Users/kimiguel/.local/share/virtualenvs/hello-pipenv-two-dcBnVr68 doesn't contain a valid path to the project
Error 2021-05-10 12:03:52: The .project file inside environment folder: /Users/kimiguel/.local/share/virtualenvs/pipenv-two-KgBt83I1 doesn't contain a valid path to the project
Error 2021-05-10 12:03:53: The .project file inside environment folder: /Users/kimiguel/.local/share/virtualenvs/pipfile_hello_world-9fihYaKL doesn't contain a valid path to the project
Error 2021-05-10 12:03:53: The .project file inside environment folder: /Users/kimiguel/.local/share/virtualenvs/pytest-libfaketime-ChaRi4Fc doesn't contain a valid path to the project
Error 2021-05-10 12:03:53: The .project file inside environment folder: /Users/kimiguel/.local/share/virtualenvs/upper_level_project-hGd-hSjF doesn't contain a valid path to the project
Error 2021-05-10 12:03:53: The .project file inside environment folder: /Users/kimiguel/.local/share/virtualenvs/vscode_multi_workspace_bug_repro-mhhNtleX doesn't contain a valid path to the project
Starting Jedi language server.
Error 2021-05-10 12:03:53: Failed to check if file needs to be fixed EntryNotFound (FileSystemError): Unable to read file '/Users/kimiguel/Documents/Sandbox/simple-bot/.vscode/settings.json' (Error: Unable to resolve non-existing file '/Users/kimiguel/Documents/Sandbox/simple-bot/.vscode/settings.json')
    at _handleError (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:87:156604)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at y.readText (/Users/kimiguel/.vscode-insiders/extensions/ms-python.python-2021.5.821509413-rc/out/client/extension.js:9:344717)
    at p.doesFileNeedToBeFixed (/Users/kimiguel/.vscode-insiders/extensions/ms-python.python-2021.5.821509413-rc/out/client/extension.js:59:581560)
    at /Users/kimiguel/.vscode-insiders/extensions/ms-python.python-2021.5.821509413-rc/out/client/extension.js:59:580687
    at async Promise.all (index 1)
    at p.getFilesToBeFixed (/Users/kimiguel/.vscode-insiders/extensions/ms-python.python-2021.5.821509413-rc/out/client/extension.js:59:580633)
    at p.updateTestSettings (/Users/kimiguel/.vscode-insiders/extensions/ms-python.python-2021.5.821509413-rc/out/client/extension.js:59:580260) {
  code: 'FileNotFound'
}
Python interpreter path: ./.venv37/bin/python

Not sure if this is helpful, or what additional information I can provide, but I am experiencing this exact behavior on Windows 10.
When I first open a workspace the interpreter shown is a random interpreter VSCode found (it's not set for any of my workspaces). Opening another file then updates to display the correct interpreter, set for my workspace. From that point on (in the session) everything is fine.
Thanks,
Steve

Yep it is! Thanks for confirming that it doesn't happen only on macs @stevetwist!

Introduced by https://github.com/microsoft/vscode-python/pull/15971

Could be related: https://github.com/microsoft/vscode-python/issues/16291. Can anyone confirm if this only happens when in DeprecatePythonPath experiment?

Happens when not in the DeprecatePythonPath experiment:
User belongs to experiment group 'pythonDiscoveryModule'
User belongs to experiment group 'pythonDiscoveryModuleWithoutWatcher'
User belongs to experiment group 'pythonaacf'
User belongs to experiment group 'pythonTensorboardExperiment'
User belongs to experiment group 'CollectLSRequestTiming - control'
User belongs to experiment group 'CollectNodeLSRequestTiming - experiment'

@stevetwist Unfortunately I'm unable to reproduce this on Windows when not in deprecate python path exp. Can you try https://github.com/microsoft/vscode-python/issues/16291#issuecomment-847448305 and see if it helps?

@karrtikr I can confirm that opting out of the 'DeprecatePythonPath' experiment fixed this issue for me, on Windows.
Thanks,
Steve

@kimadeline It seems this issue is only on Mac then so I cannot reproduce this. https://github.com/microsoft/vscode-python/pull/16391 has just been merged which could potentially fix it, can you check if you can repro this on main?

Happens when not in the DeprecatePythonPath experiment:

I'm observe that for some reason we no longer log if the user is in DeprecatePythonPath - experiment, maybe it's a bug with the old framework. So we can't rely on logs to figure out which experiments user is in.

I can't reproduce it using Insiders version 2021.6.916495917-dev 🥳
Since this is fixed in Insiders @stevetwist you can either set up the Python extension to use one of our Insiders release channel with the python.insidersChannel setting (either weekly or daily should work), or you can wait for the next stable release of the Python extension later this month, which will include this fix.
Thank you!


2 tests fail on IBM Power Linux (ppc64le)

Description
The environment is ppc64le/UBI 8.3 (RHEL 8.3 based container environment) and the build completes successfully after using the system libpng that is configuring it with "cmake -DITK_USE_SYSTEM_PNG:BOOL=ON -DBUILD_TESTING:BOOL=ON ../SimpleITK/SuperBuild/". However, there are two test failures

The following tests FAILED:
433 - BasicFilters.SLICImageFilter (Failed)
509 - CXX.Example.ImageRegistrationMethodDisplacement1 (Failed)
Steps to Reproduce
Build and execute the unit tests
ctest .

Expected behavior
All tests should pass (confirmed that is the case on Intel / UBI 8.3 container

Actual behavior
2 test failures are seen on ppc64le

Reproducibility
100%

Versions
Master (latest)

Environment
Linux 8f0595016844 3.10.0-1127.10.1.el7.ppc64le
NAME="Red Hat Enterprise Linux"
VERSION="8.3 (Ootpa)"
cmake version 3.11.4

Additional Information

debug.log

attaching the output of  ctest -VV --rerun-failed ., while I look into the issue more, any pointers help would be great, thanks in advance!!

Re-Creating this issue with SimpleITK community


Search-guard does not handle failing trying to load Searchguard ACL gracefully as ES starts up

@floragunncom I've seen this behaviour a few times.  My process has been the following using ES 1.5 and Java 8:

Install Search-guard
Start ES with
2.a: searchguard.ssl.transport.http.enabled: false
2.b: allow_all_from_loopback: true
2.c: network.host: <IP_ADDRESS>
Use curl to seed my initial ACL
Stop ES
Start ES without the configurations in step 2
Observe the following exception until I see that ES has started up successfully and recovered all indices:
[com.floragunn.searchguard.service.SearchGuardConfigService] [foo-bar] Try to refresh security configuration but it failed due to org.elasticsearch.action.NoShardAvailableActionException

I am starting and stopping ES because this is being provided within a container that may have a different cluster name, so seeding when building the container isn't an acceptable solution.
Is there a way to have search-guard handle this in a more graceful way than writing a stack trace?
E.g.

printing out a Warning message (no stack trace) that there aren't any shards yet available
checking that ES has started up and loaded all shards before trying to read the ACL writing an Error afterwards if not available.

This was covered by PR #66


TypeError: chalk_1.default.Instance is not a constructor

Screenshot

Description
I get this error often:

TypeError: chalk_1.default.Instance is not a constructor

The complete error:
TypeError: chalk_1.default.Instance is not a constructor
    at Object.<anonymous> (~/twitter-api-v2-3-legged-login-using-next-connect/node_modules/@nexus/logger/src/chalk.ts:9:22)
    at Module._compile (node:internal/modules/cjs/loader:1109:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
    at Module.load (node:internal/modules/cjs/loader:989:32)
    at Function.Module._load (node:internal/modules/cjs/loader:829:14)
    at Module.require (node:internal/modules/cjs/loader:1013:19)
    at require (node:internal/modules/cjs/helpers:93:18)
    at Object.<anonymous> (~/twitter-api-v2-3-legged-login-using-next-connect/node_modules/@nexus/logger/src/filter.ts:2:1)
    at Module._compile (node:internal/modules/cjs/loader:1109:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)

I don't know what to make of it. I did perform npm ls @nexus/logger & I got the following:
twitter-api-v2-3-legged-login-using-next-connect
└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>
which means it comes from setset which is dependency of nexus-prisma
Repro Steps/Link
I have a repro commit that will reproduce this error → https://github.com/deadcoder0904/twitter-api-v2-3-legged-login-using-next-connect/commit/b2bc0574eb6818f92cd7602afe823c70c096432c
Would love to know what this error is & what's causing it as I've seen it more than 10 times now?

Another simpler reproduction → https://github.com/deadcoder0904/codegen-error

Thanks for the repro @deadcoder0904
Can you remove the nextjs stuff, I don't think its needed.
I'll try to get this fixed soon.

Can you remove the nextjs stuff, I don't think its needed.

What Next.js stuff? I basically start every project nowadays with Next.js by default since it's just 1-line of code & everything is ready-made for you.

Anything to make the repro small the better. Deps, files, everything.

I have simplified it a lot https://github.com/jasonkuhrt/codegen-error.
If I remove this dep and trigger a lock rebuild it fixes the issue https://github.com/jasonkuhrt/codegen-error/commit/9852704b78b9711cf36e9e890ad2cbbe11c95bff.
I don't understand the issue at this time. I believe the issue is somehow in the project. I've seen similar issues in our stacks and the issue is generally not at the library level.
If you can reproduce off my fork in a way that isn't about the lock file then please re-open.

yeah, i was confused whether it is in graphql-codegen or nexus-prisma under setset. i'll have to see that again but i'm currently using nexus-plugin-prisma again as i couldn't get nexus-prisma to work with my setup & i waited way too long.
i'll probably try nexus-prisma again when it's stable & re-open the issue if it still happens with my setup 👍

I'm also having this issue using 0.35.0 with prisma 3.10.0.
Downgrading to nexus-prisma: 0.34.0 works.
node_modules/floggy/dist-cjs/chalk.js


Add Support for Compose V2

The new docker compose command integrates docker-compose into the main docker command. See https://docs.docker.com/compose/cli-command/ for details.
I realize this is asking for basically a whole other application to be integrated, so this might not be worth the effort, but discovered this when I installed this module today.

Thank you for your comment. I am considering adding support for Compose V2, but it is still pre-release version. Its 1st release candidate has just been published a few days ago. Let me wait and see please🙂

New version published: DockerCompletion 1.2010.1.211002
In this version, the new docker compose command, GA announcement on Sep 30 2021, is supported.
Thank you for waiting @allout58


Very Long Actor Name Issue

When using a very long actor name, the actor freezes in join().
When the actor is called alone, works ok, but when is called in conjunction with other actor methods, it freezes.
I have a example with the helloworld here:
https://github.com/quilombodigital/orbit/tree/longnameissue

I've downloaded your branch.
There is something happening there.
I just don't think it has anything to do with the length of the names.
I tested it with smaller names and the problem remains.
There are a few more thing to test. I'll work on it.

It seems to be the suffix "*Tests".
Test it your self.
It might be related to JUnit... It needs more tests :p

Happened with IOnlyIfActivatedExample and IOnlyIfActivatedExampleActor

Fixed. Found a problem with the class path search.
The name of the class was related to the problem but not its size.
I've submitted a quick fix and will work more on it later.

Great work! Thanks!


[Storage] The encryption key parameters are missing from storage account update command.

Three parameters are missing from az storage account update command, which impacts the storage customer managed key scenario.
    --encryption-key-name   : The name of the KeyVault key.
    --encryption-key-vault  : The Uri of the KeyVault.
    --encryption-key-version: The version of the KeyVault key.

This is a regression introduced during knack conversion.

Thanks for helping fix this Troy.


Add metric for monitoring the size of the queue

It would be interesting to have the size of the current queue (merge train) as a per project Prometheus metric, using the already existing endpoint.

@OpsBotPrime merge and tag


Update base images device types page

Connects-to: #1902
Dynamically generate content from api v6/device_type endpoint
Change-type: patch
Signed-off-by: Trong Nghia Nguyen<EMAIL_ADDRESS>

Please make sure to read the CONTRIBUTING document before opening the PR for relevant information on contributing to the documentation. Thanks!

@balena-ci rebase


Cooker w/ Carrot & Potato Dish issue

Minecraft: 1.10.2
Forge: <IP_ADDRESS>2
Aqua Munda: 0.1.1 beta
First of all, thank you for all your amazing mods!
I tested Aqua Munda, no crashes so far (therefore no log or crash report) and it fits perfectly in the early and mid stage of my mod pack. I found an issue and I’m not sure if it’s a bug or if I’m derping.
I can’t take a potato or carrot out of the cooker with a bowl in my hand, the soup works fine.
Step by step description: I put down sticks on cobble, set them on fire with a flint & steel, set up the Cooker, put in a bucket of fresh water, wait till the temperature has reached 100 (maximum) (or put them in before, I tried both) and put in the carrot/potato. After the bar of „One Probe“ is filled up, I try to take the then cooked carrot or potato out with a bowl, but nothing happens. If I break the cooker, I get a cooked potato or carrot.

That's as intended. The cooked potato/carrot are meant to be taken out directly. The bowl is only for the soup


Update font-inconsolata-dz-for-powerline to latest

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Merged as 534bc6c25e26357a55b24d972735d607b9c030ff.


Updated Package.json Information

Fixes #99

:+1:  hehe

Hey there!
Anything I need to add to get this accepted?


[WIP] Add support for partial indexes

MongoDB 3.2 adds support for partial indexes. This PR adds support for adding partialIndexExpression options to the index specification.
Examples:

YAML:

  indexes:
    index1:
      keys:
        username: desc
      options:
        unique: true
        dropDups: false
        partialFilterExpression:
          version: { $gt: 1 }
          discr: { $eq: 'default' }

XML:

<indexes>
    <index unique="true">
        <key name="username" order="desc" />
        <option name="dropDups" value="false" />
        <partialFilterExpression>
            <field name="version" value="1" operator="gt" />
            <field name="discr" operator="eq" value="default" />
        </partialFilterExpression>
    </index>
</indexes>

Annotations:

/**
 * @ODM\Indexes(
 *     @ODM\Index(keys={"username"="asc"},dropDups=true,partialFilterExpression={"counter"={"$gt"=5}})
 * )
 */

List of TODOs:

[ ] Figure out how to properly map $and in XML
[ ] Ensure SchemaManager::isMongoIndexEquivalentToDocumentIndex() works properly
[ ] You can always add more tests

Long time no see, I've updated the XML mapping. The example in the comment above outlines the straight-forward mapping. For more complicated mappings, there are additional possiblilities. You can either check properties of embedded documents (checking only those properties mentioned):
<partialFilterExpression>
    <field name="nested">
        <field name="count" operator="gt" value="0" />
        <field name="test" value="foo" />
    </field>
</partialFilterExpression>

Or check a document for equality (ensuring that a document looks exactly like what's provided):
<partialFilterExpression>
    <field name="object" operator="eq">
        <field name="property" value="foo" />
        <field name="count" value="bleh" />
    </field>
</partialFilterExpression>

With this it's also possible to use the $and operator. MongoDB supports this operator only at the root level:
<partialFilterExpression>
    <and>
        <field name="nested">
            <field name="count" operator="gt" value="0" />
            <field name="test" value="foo" />
        </field>
    </and>
    <and>
        <field name="object" operator="eq">
            <field name="property" value="foo" />
            <field name="count" value="bleh" />
        </field>
    </and>
</partialFilterExpression>

When using and, you cannot add any field mappings at the root level. You also can't nest the and operator in a field mapping.

I think we should have tests for expression with and since XML driver has a check on that?

@malarzm Good idea, I'll add a few extra documents to be safe.

@malarzm Added tests for various filter expressions being loaded via XML and YAML to ensure they are the same. Invalid filter expressions will only be fixed by the XML driver as YAML and annotations are schemaless and will just let the database throw a fit if the expression is invalid.

:+1:


Variable types corrected

Not sure if this issue is because of glm version, but I think this changes could be helpful to avoid some castings.

Did you check if the samples work as intended with the glm version from the repo? Some of the odd looking casts, esp. those related to quaternions, were necessary to make things work.

Did you check if the samples work as intended with the glm version from the repo? Some of the odd looking casts, esp. those related to quaternions, were necessary to make things work.

Not really, I haven't had enough time to test the app. The glm I used was the current available version in OpenSUSE Leap 15.2. I'll give it a try and will come to you with the answer

@SaschaWillems everything looks fine after the changes using the glm version in the repo and the changes included into this pull-request.


JSX element type 'NumberInput' is not a constructor function for JSX elements. Types of property 'setState' are incompatible.

Using<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Stacktrace:
(99,21): error TS2605: JSX element type 'NumberInput' is not a constructor function for JSX elements.
  Types of property 'setState' are incompatible.
    Type '{ <K extends never>(f: (prevState: void, props: NumberInputProps) => Pick<void, K>, callback?: ()...' is not assignable to type '{ <K extends never>(f: (prevState: {}, props: any) => Pick<{}, K>, callback?: () => any): void; <...'.
      Types of parameters 'f' and 'f' are incompatible.
        Type '(prevState: {}, props: any) => Pick<{}, any>' is not assignable to type '(prevState: void, props: NumberInputProps) => Pick<void, any>'.
          Types of parameters 'prevState' and 'prevState' are incompatible.
            Type 'void' is not assignable to type '{}'.

How I used it:
<NumberInput
    required
    hintText="Rate ($/hour)"
    floatingLabelText="Rate ($/hour)"
    strategy="warn"
    min={0}
    errorText={this.state.rateError}
    fullWidth
    value={this.state.rate}
    onChange={(e: React.FormEvent<HTMLInputElement>, value: string) => this.setState({ rate: value })}
    onValid={valid => this.setState({ validRate: valid })}
    onRequestValue={value => this.setState({ rate: value })}
    onError={this.onError}
/>

I believe this happened on upgrade from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>Love the component!

I'm really busy until 12th of july and have no time to fix it ... But I'll accept Pull Request for it.

Added a PR for whenever you have time to check over it.

For posterity, in case anyone comes across a similar problem elsewhere... I think this was the result of a typescript update, not a material-ui types update. The fix was just to change void to {} in certain places that referenced state, such as here:
export class NumberInput extends React.Component<NumberInputProps, void> {

changed to
export class NumberInput extends React.Component<NumberInputProps, {}> {

Maybe typescript became more strict on the way they expect empty props or state to be represented. In any case, this seems to fix it.

Do you know when the update will be published to npm?

I just publish it, sorry for the delay was really busy ....


Release 1.1

Merge shows conflicts that need to be addressed.

Created pull request into develop to resolve


Add ECK-based K8S env scaffolding for example

Signed-off-by: lloydmeta<EMAIL_ADDRESS>

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   72.68%   72.68%
=======================================
  Files          12       12
  Lines         681      681
=======================================
  Hits          495      495
  Misses        144      144
  Partials       42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada49ee...0f096e3. Read the comment docs.


Add pricelabel to overlay

Describe the bug
Hi, How can i add pricelabels to overlays other than the main overlay? and how do i change the pricelabel text color?
Iv'e tried
 stockchart, {
     colors: {
     textcolor: rgba(255, 255, 255, 1),
     color: rgba(255, 255, 255, 1),
     text: rgba(255, 255, 255, 1),
}
}

Best / F
Reproduction

Steps to reproduce
No response
Javascript Framework
no-framework (vanilla-js)
Logs
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a NightVision issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

Figured it out, Looks at the candles.navy and noticed:
valueTracker(x) => {     show: $props.showValueTracker,     symbol: $props.scaleSymbol,     line: true,     value: Number($core.data[0].avgPx),     color: 'rgba(255, 0, 0 , 1)', }
This adds a pricelabel to my custom overlay.
One thing that would be nice is to be able to add text to the label ex 'value | text' ex '27500 | SL'.
Also still cant figure out how to change the text color.  I would assume "back:" sets the background color and that color sets text color. that does not seem to be the case and i can only change the background color via the color: key.


[TRUNK-12396] update cli to work with the new apis

This updates the quarantine flow to work with the new APIs

I would highly recommend to use log::error only to log errors. Test failure is not an error, it's expected output.


Onedrive提示：This item might not exist or is no longer available

why？i like this contents very much!

onedrive不可用了

You can use BTsync just like the Blogger said.

This issue can be closed. Thanks.


Upgrading to ng2-translate to use angular rc-5 causes breaking changes

I have experienced peer dependency issues like:
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>Sorry if the issue is just me, but it appears having your module upgrade to rc5 should've resulted in a 3.0.0 semver change, not a 2.x.x change

Well it seems that you don't have angular 2 rc5 dependencies installed, which means that this version's peer dependencies are not satisfied.
I've only updated the minor version because the code in itself still works with rc4, I didn't want to release a new major version just yet as I have some big changes planed and I will release a new major soon.
Did you get this problem because you use the version number with a ^ at the beginning ?

Yeah I'm depending on this:
   "ng2-translate": "^2.2.2",
And you're right I haven't upgraded to angular 2 rc5.
I'm trying to find the version of ng2-translate that depends on rc4 by looking on this repo now...

The last version is 2.2.2 :)
Also you're probably using npm 2.x, because in 3.x the peer dependencies wouldn't cause an error, just a warning

Correct again sir!  I'm on npm 2 because that was what came with node 4 LTS (I don't like to live on the bleeding edge all the time :P )
Peer dependencies are garbage so I'm considering updating to npm 3.  Thank you, looks like there is a resolution to my issue, I wouldn't fight ya if you closed this.

ok :)


Wasm: Make class fields immutable at the Wasm level

Currently, all class fields are mutable at the Wasm level: the genFunctionID.newDefault function creates a class instance with fields initialized to their zero values, and then the constructor initializes them (by Assign at the IR level).
https://github.com/scala-js/scala-js/blob/4c9494e424e0e8b60b6a198e461320897c6e8806/linker/shared/src/main/scala/org/scalajs/linker/backend/wasmemitter/ClassEmitter.scala#L351-L358
Fields being mutable means that accessing a field is an impure operation at the Wasm level, causing us to miss some optimization opportunities.
In fact, making itables immutable has improved performance in some benchmarks, as seen in https://github.com/scala-js/scala-js/pull/5038.
We may want to "merge" the genFunctionID.newDefault function with the constructor: The fused constructor would:

Set up the vtable (virtual method table) and itable (interface table)
Initialize the fields

Instead of filling fields with zero values, the wasmemitter would transform the RHS of field Assign nodes to become the initial values of the fields.

Execute struct.new for instantiation (as newDefault currently does)

Alternatively, should we modify the IR structure somehow? It appears that these Assign operations in the constructor originate from Scala compiler, not from GenJSCode🤷. In this case, making changes at the IR level seems introduce more complications than it solves.

Doing that is not always possible. During the constructor, and during the call to the super constructor, fields are actually mutable, and mutated.
In order to call the super constructors, we must already have an instance whose fields are initialized to the zero of their types. Usually, it is only after the super constructor call returns that we actually assign fields. This is by spec. Doing it any other way would break semantics.
That means that, at least, changing the IR is not possible for this. Under separate compilation, we cannot know what the super constructors will do. Moreover, unless the class is final, we cannot know what the sub constructors will do either.
In the linker, we may be able to do something for final classes whose constructors have been completely flattened through inlining of the super constructors. If there is no more super constructor call after inlining, it may be possible to statically analyze the final value of (some) immutable fields. Those could be made immutable at the Wasm level.
For fields in non-final classes, this is probably a lost cause.

During the constructor, and during the call to the super constructor, fields are actually mutable, and mutated. ...
In the linker, we may be able to do something for final classes whose constructors have been completely flattened through inlining of the super constructors. If there is no more super constructor call after inlining, it may be possible to statically analyze the final value of (some) immutable fields.

Ah, right, that makes sense. Thank you for the explanation :+1:
found that the JS backend does a somewhat related optimization by inlining the init into the JS constructor (https://github.com/scala-js/scala-js/pull/3074), while we need to go a bit further, to making fields immutable in Wasm


add php 8 support

Waiting PHP-CS-Fixer to be compatible with php 8.0

Could you at least for now allow PHP 8 version in composer.json so I can update my application?

Is this PR breaking for some users (php 8 users or PHP 7 users)? 🙂

We don't use any feature of php 8, so php 7 user can still use the package and we don't use any deprecated feature removed by php 8 it should be good.

Thanks @shokme! 👍


add CPython 3.7 to tox envlist and CI configs

Issue #, if available: #151
Description of changes:
CPython 3.0 was released last month. We should start testing it.
I also realized after merging #150 that I forgot to point the pyversions badge at the correct repo..so this fixes that too.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hold on this...I should have looked at Travis's behavior on my branch first...looks like it can't find 3.7 :/

Ok; now it's just failing as expected on the pylint checks, fixed in #152

rebased on top of #152


Replace WINDOWS_UWP with NETSTANDARD1_3 to support UWP10 shared libraries

Right now NLog cannot be used by any shared NetStandard14-library that wants to support UWP10. See also #2440
I guess the easy solution would be isolating the logger-interface into a separate assembly, but that is for NLog 6.0.

do we need a new RC for this, or just add it to the RTM?

First need to fix this PR to handle the changes in #2599
Sent from my Samsung device
-------- Original message --------
From: Julian Verdurmen<EMAIL_ADDRESS>Date: 05/03/2018 12:17 (GMT+01:00)
To: NLog/NLog<EMAIL_ADDRESS>Cc: Rolf Kristensen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [NLog/NLog] Replace WINDOWS_UWP with NETSTANDARD1_3 to support   UWP10 shared libraries (#2597)
do we need a new RC for this, or just add it to the RTM?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/2597#issuecomment-370388226, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnJCnFCZUyt8Umj4WTruxeiytBQO-ks5tbR68gaJpZM4SVeI-.

OK, let me know when I can merge this one, thanks!

@304NotModified It has been fixed.

:+1:

@304NotModified And the build-server have become stable enough to complete the build.

Merged, thanks!
Think a rc7 is wise for this change

Think a rc7 is wise for this change

Requires that you find some UWP developers willing to test it, since everyone else is using net45 or netstandard20


Improve Demystify LV Objects Presentation

-Add animations to slides with a lot of text.
-Add sections.
-Correct images that don't correspond.
-Add more information in shapes scenario that is used as example in slide 18.
-Add slide to explain dynamic dispatch.
-Add a quiz to review learned concepts.

Solved with #90


refector: change deprecated "terminal" to "term"

What this PR does
Change deprecated "golang.org/x/crypto/ssh/terminal" to "golang.org/x/term"
reference: https://pkg.go.dev/golang.org/x/crypto/ssh/terminal

Fixes #11316
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

Thanks
Note please that the ref issue includes more action items and will be closed once this PR is merged
so not sure if it is correct to ref it as fixed
/ok-to-test

@oshoval
There was an opinion that PR had become too big to solve many problems and that it would be good to divide it. Should I remove the link from the ref issue first?

@oshoval There was an opinion that PR had become too big to solve many problems and that it would be good to divide it. Should I remove the link from the ref issue first?

yes please i think it is better
once all the action items are closed we can close the issue manually (we can just ref the issue on the relevant PRs
without "Fixes")

/ok-to-test

It worth please to squash the commits in this case

@oshoval Thanks your advice☺

/ok-to-test
Thanks
lets just see all pass and then it is lgtm

/ok-to-test

did we remove /ok-to-test ?
/lgtm
Thanks

Thanks
/lgtm

@oshoval
While I was resolving other issues in this project, an error occurred in 'pull-kubevirt-verify-go-mod' after RP. I took a hint from your advice and ran '/make deps-sync', but an error occurred in go mod vendor. Can I get a hint?

@oshoval While I was resolving other issues in this project, an error occurred in 'pull-kubevirt-verify-go-mod' after RP. I took a hint from your advice and ran '/make deps-sync', but an error occurred in go mod vendor. Can I get a hint?

is the error you see is as in this PR 'pull-kubevirt-verify-go-mod' ?
https://github.com/kubevirt/kubevirt/pull/11348#issuecomment-1970793410
if so it is something global, not just on the PR

@oshoval
Oh... that's right... 'pull-kubevirt-verify-go-mod' is the same as the local command result...
Then, it's clearly a problem with 'pull-kubevirt-unit-test-arm64'... Actually, I'm not familiar with testing for this project, so I'm having a hard time... Thank you, I'll do more research!
p.s. The test for this project just now failed... I'm scared of this place now...😭

@oshoval Oh... that's right... 'pull-kubevirt-verify-go-mod' is the same as the local command result...
Then, it's clearly a problem with 'pull-kubevirt-unit-test-arm64'... Actually, I'm not familiar with testing for this project, so I'm having a hard time... Thank you, I'll do more research!
p.s. The test for this project just now failed... I'm scared of this place now...😭

Don't be scared, and you don't need to handle it all, of course when it is a global problem
Thank you for your contributions

@oshoval
Thanks for the encouragement. The project's reviewer just said that an error occurred, so I have to go back to studying!

Do you mean the failure here ?
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/11351/pull-kubevirt-goveralls/1763174958747357184
It is just bootstrap problem, it is not related to the PR
We can wait until pull-kubevirt-goveralls is globally fixed and then continue as it isn't related to this PR

@oshoval
Sorry for confusing you. I mentioned two failures in this conversation.

The error you mentioned is the one I mentioned in the previous conversation p.s. This is the error mentioned in . You're helping me so well here, so I don't have to worry. https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/11351/pull-kubevirt-goveralls/1763174958747357184

Another error I need to study is #11348. I guess I'll have to try until someone gives me a hint.
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/11348/pull-kubevirt-unit-test-arm64/1762871293239103488

About [2]
please see
https://github.com/kubevirt/kubevirt/pull/11321#issuecomment-1957064347
It is a flake, not related to your PR, so not need to be addressed on your PR, unless you want to :)
Thanks

@oshoval
'lgtm' was released due to rebase. Should I request it again?

sure thanks
once you doing a chance, please add information on what you did, it helps and also
will triggers the reviewers to review again
/lgtm


Internal Server Error when sending multiple PDFs in conversation

Description
When attempting to have a conversation that includes multiple PDF documents with Claude, the API returns a 500 Internal Server Error. The error occurs specifically when trying to send a second PDF after receiving a response for the first one.
Steps to Reproduce

Initialize a conversation with Claude API
Send first message containing:

PDF document (base64 encoded)
Text prompt ("1줄 요약")

Receive assistant's response
Send second message with:

Different PDF document (base64 encoded)
Text prompt ("1줄요약")

API returns 500 Internal Server Error

Code Example
message2 = client.beta.messages.create(
    model="claude-3-5-sonnet-20241022",
    betas=["pdfs-2024-09-25"],
    max_tokens=1024,
    messages=[
        {
            "role": "user",
            "content": [
                {
                    "type": "document",
                    "source": {
                        "type": "base64",
                        "media_type": "application/pdf",
                        "data": base64_string
                    }
                },
                {
                    "type": "text",
                    "text": "1줄 요약"
                }
            ]
        },
        {
            "role": "assistant",
            "content": message.content[0].text
        },
        {
            "role": "user",
            "content": [
                {
                    "type": "document",
                    "source": {
                        "type": "base64",
                        "media_type": "application/pdf",
                        "data": base64_string2
                    }
                },
                {
                    "type": "text",
                    "text": "1줄요약"
                }
            ]
        }
    ]
)

Error Message
InternalServerError: Error code: 500 - {'type': 'error', 'error': {'type': 'api_error', 'message': 'Internal server error'}}

Environment

Python SDK Version: (version number)
Claude Model: claude-3-5-sonnet-20241022
Beta Features: ["pdfs-2024-09-25"]

Expected Behavior
The API should handle multiple PDF documents in a conversation, allowing for sequential analysis of different documents.
Additional Context

The first PDF upload and response works correctly
The error occurs specifically when trying to send a second PDF in the conversation
Using the latest beta PDF feature as indicated in the betas parameter

Questions

Is there a limitation on the number of PDFs that can be processed in a single conversation?
Is there a specific way to handle multiple PDF documents in a conversation that I'm missing?
Could this be related to the beta status of the PDF feature?

I am also seeing this error by calling the REST API


Feature: Move a Request to Top (Having ConcurrentLimit = 1)

It would be nice to have a function to move a valid and existing request to fornt of the queue, Meaning, if there is an active download it would be paused (with queued status) and would be dowloaded normally after the one that had been pushed to top id finished.

@Mahan3340 Fetch downloads Request based on time created and the priority set. You can use the  update request method  to update the initial request. Does that not work well?

assume there is request-1 in the queue and is being downloaded (all with same priority), the user clicks another download to start (this request for this download might not exist yet, probably first time), so I will enqueue the new request but it has to wait for the earlier one to be completed, I can't use priority because there are infinite downloads and even after request-2 there might a request-3 come that has to be downloaded sooner and so on. what you say is that I enqueue and then immediately call update request, will that work ? will that update the time and pause the current download and starts this one ?

Fetch currently works like this :
High -> earliest -> next -> next
Normal ->  earliest -> next
Low ->  earliest -> next -> next
All high priority will be downloaded first. Once there are no more high priority downloads, the normal ones are downloaded based on the earliest and then low queue is handled.
Mhm is see what you trying to do in terms of promoting a download. Let me brain storm and I will post back.

the policy works fine if the priorities are different, but when one request with high priority arrives It won't stop current request with also HIGH priority. it would be great if  there was an option to enable this behavior. thanks for your time

Still looking into this.

@Mahan3340 new version of Fetch 3.0.2 with new method for changing the way the priorirty queue sorts by timestamp.
eg:
  final FetchConfiguration fetchConfiguration = new FetchConfiguration.Builder(this)
                .enableRetryOnNetworkGain(true)
                .setDownloadConcurrentLimit(1)
                .setPrioritySort(PrioritySort.DESC) //default is PrioritySort.ASC
                .build();

Let me know if this works well.

@tonyofrancis Thank you so much I will try it and let you know


URL hash collide when different subsections have the same title

Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Doesn't matter
Steps to Reproduce
Try any markdown file
# foo
## baz

# bar
## baz

Maybe baz-1. for the second one is good enough? No way to guarantee the titles from not clashing, since you might actually have a title called baz 1
Expected Behavior
Not sure
Actual Behavior
In this case, both baz will render to html with anchor baz, so my-page#baz points to the first one always.

@chenglou We fixed this in the nuclide.io docs with the old template. We can see what we can do here. Thanks!

Hi, all
@JoelMarcey, is there any updates with this issue? I would like to try to submit a PR with fixes.
What kind of fix was on nuclide.io? I've noticed, that an anchor also inherits the anchor of a parent title, e.g.:
# Foo -> #foo
## Bar -> #foo-bar

This behavior will fix the bug from issue description, but will not help in rare case, when user will have two same headers on the same level, e.g.:
# Foo -> #foo
## Bar -> #foo-bar
## Bar -> #foo-bar

Probably the second one should be named #foo-bar-1?

Another issue (this is why I so interested in anchor related issues) is handling of cyrillic characters:
# Привет из Украины -> #(empty string)

I think, the correct anchor should be #привет-из-украины


Updating the name of "APNS Pusher" to "Knuff" in Readme.

Thanks for the mention! :)

Thanks for the PR @blommegard :metal: CI failed for some reason. I restarted it. I'll merge this in as soon as we're green (there is no reason your PR would break CI).

Thank you for catching that!  We're big fans of Knuff - thanks! 🍻

Obv this PR doesn't affect the specs, so I propose we merge, and w/ the travis fix in there, the next PR should be green.

Or, @blommegard, if you merge / rebase onto master, you should get the fixes to .travis.yml that I pushed up.

All done!

Gonna go ahead and merge this, we'll save taming travis for another day.


Fixed compilation with boost 1.84

Thanks!
Is invoke_swap available in older boost versions as well?

Is invoke_swap available in older boost versions as well?

No, it's available since 1.84. Here is corresponding Boost MR: https://github.com/boostorg/core/pull/149

Ah, oof. Any chance you could wrap the new function in a BOOST_VERSION check then so the source stays compatible with Boost releases from before 2024?

Perfect, thanks!


4 Functions

Hi all, we can use this issue to state which functions you would like to implement. Feel free to edit the table below:

Name
Function

Rohit
Create a line chart presenting COVID total new cases verses another metric within a time period

Rong
Create a line chart presenting specific country/countries COVID information within a time period

Thomas
Get Covid data as pandas dataframe based on date range and location provided

TZ
Summary plotting function for categorical variables within a date range

I tried to plot monthly new cases VS positivity rate to see any relationship between the two.
Also, fairly simple to download data.
covid_df = pd.read_csv('https://covid.ourworldindata.org/data/owid-covid-data.csv')

I was thinking of making a simple function to output a summary plot by countries or other categorical factors by a date range, like this:

Hi all,
Sorry that I was engaged with some other stuff this week and I will catch up the work tonight and tomorrow morning. Meanwhile, for my function, I would like to create one which returns contents as a json format based on the options chosen.
For example, we can input (country, 7-day-rolling, date) and it returns the average confirmed cases in past 7 days. I will try to put some meaningful statistics there - that aims for developers to easily access summarized data.

Believe we don't need a specific function to download - I can embed the data download into my function .
For other functions we can do a simple check if the file exists in local drive. Does that sound good?

Given that the file is updating, I feel like we should always re-download the data, so all the functions should embed the data download I believe.

Wondering if we could share the name of our function now so we are on the same page? I am thinking of mine as plotspec, does that sounds ok? And btw, are we all going to use Altair for python to do the plotting?

We can perhaps try using _ to separate words in function, as suggested in PEP 8

Function names should be lowercase, with words separated by underscores as necessary to improve readability.

I guess my function could be plot_summary or something

Due to the constraints of the four functions only, I will change my function to only return a df of the downloaded data. I think we can't even write a class too? If yes, then at least I can put the df download into the class while it's being initialized....

Closed the issue as the spec of all functions are merged.


Load Floskell configuration

Changes

Respect floskell configuration file that can be found according to floskell's rules.

LGTM


gitversion: add darwin and windows platforms

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Was there a solution for https://github.com/NixOS/nixpkgs/pull/289799#issuecomment-1986943493 ?

Was there a solution for #289799 (comment) ?

About this ?
kernel: (AppleSystemPolicy) ASP: Security policy would not allow process: 26376, /nix/store/y25a08bdkd43qfwi4rgczz2r8iv2dkgg-dotnet-gitversion-5.12.0/lib/dotnet-gitversion/dotnet-gitversion

Yeah, I understood that this was an issue when running on Darwin.

Yeah, I understood that this was an issue when running on Darwin, I can not verify as I only have Linux systems, tho remembered that there was something raised

I have tried to compile and run it under my macos sonoma (mac book pro m3) and it works wonderfully


Issue with headphones

when i play a song with speakers on and connect the headphones after that, the app crashes in RingBuffer.mm on line number 212.
outData[i*stride] = mData[whichChannel][idx];
debugging showed that its happening when whichchannel = 1, i tried to hardcord whichchannel = 0 when headphones are connected and the code stopped crashing but then i was getting the audio in really distorted way.
furthermore if we start novocaine with headphones on and play a song and then plug/unplug the headphones, theres no issue there!

Hmm, this is still unrelated to NVDSP though! Have you tried updating the bundled Novocaine files (such as the RingBuffer.mm) to the latest version from the Novocaine github page?
I will close this for now since RingBuffer.mm is not part of NVDSP but of Novocaine. Please let me know what happens when you update Novocaine and all its files (such as the RingBuffer) though.


Updating ChakraCore version to 1.4.3

@MSLaguana,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


MyCharactristicCallback causing esception when from client

I am using two callbacks simultaneously. one for characteristic and one for a server. the server callback is working fine but when I am trying to write from the client and using characteristic callback for it, it is causing exception
here is my code
   `
         class MyCharacteristicCallback: public BLECharacteristicCallbacks

         {
             void on  Write(BLECharacteristic* pCharactristic){

            std::string getValue = pCharacteristic->getValue();

             Serial.println(getValue.c_str());

              if(getValue.length()> 0){
                    clientWrite =true;
            }
           }
        };`

getting this exception
`
Guru Meditation Error: Core  0 panic'ed (LoadProhibited). Exception was unhandled.
Core 0 register dump:
PC      : 0x40171da3  PS      : 0x00060430  A0      : 0x800d5cee  A1      : 0x3ffd7d90
A2      : 0x3ffd7df4  A3      : 0x00000074  A4      : 0x3ffd5eb0  A5      : 0x00000000
A6      : 0x00000000  A7      : 0x7f000001  A8      : 0x3ffd7dfc  A9      : 0x3ffd7d30
A10     : 0x00000000  A11     : 0x3ffd6008  A12     : 0x3ffd6098  A13     : 0x00000001
A14     : 0x00060220  A15     : 0x00000000  SAR     : 0x00000010  EXCCAUSE: 0x0000001c
EXCVADDR: 0x00000074  LBEG    : 0x4000c2e0  LEND    : 0x4000c2f6  LCOUNT  : 0xffffffff
        Backtrace: 0x40171da3:0x3ffd7d90 0x400d5ceb:0x3ffd7db0 0x400d23d8:0x3ffd7dd0
        0x400d133e:0x3ffd7df0 0x400d2742:0x3ffd7e30 0x400d2c25:0x3ffd80e0
         0x400d5069:0x3ffd8100 0x400d5491:0x3ffd8150 0x400d4879:0x3ffd8170
         0x400d364d:0x3ffd81b0 0x400e1f7d:0x3ffd81d0 0x400dd2ce:0x3ffd8210

        Rebooting...
        ets Jun  8 2016 00:22:57

         rst:0xc (SW_CPU_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
         configsip: 0, SPIWP:0xee
         clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
         mode:DIO, clock div:1
         load:0x3fff0018,len:4
         load:0x3fff001c,len:952
         load:0x40078000,len:6084
         load:0x40080000,len:7936
         entry 0x40080310
   `

Hi @vbshightime
yes, we are having some issues with read/write operations from callback. I didnt check it with my latest changes yet, but if you wish you can see how it works. Its branch features from this repo or zip file from this post for arduino:
https://github.com/nkolban/esp32-snippets/issues/717#issuecomment-440858956

be me
having the same issue on a totally different repo that used this one code
????
they changed a lot
says to go here to ask questions even though the project is dead lol

Who sent you here and why?
This repo is dead indeed, because arduino-esp32 is now maintaining own version. Also there is plenty forks.
Anyway, it is hard to help when you just write i have the same problem on issue which has been solved long time ago.

oh nevermind it was from the arduino-esp32 readme but I figured it out I forgot to pass the reference to the BLE characteristic in a function i made lol
uint8_t BLUETOOTH_CONTROL::update_characteristic(uint8_t & in_value, uint8_t &  value, BLECharacteristic *&c_chara)     {                 uint8_t rc = 0;                 uint8_t * data;                  data = c_chara->getData();                 int current_value = 0;                 current_value = *data;                 if(current_value != in_value)                     {                         if(value != current_value)                             {                                 in_value = current_value;                                 value = in_value;                                 rc = 1;                             }                         else                             {                                 value = in_value;                                 c_chara->setValue((uint8_t*)&in_value,4);                             }                     }                 return(rc);     }


Added string case-insensitive contains '*=' symbol to filter language

Title.

Hello @NoahSaso, thank you for your contribution! We're looking into it. In the meantime, can you update the error message translation in meilisearch-core/src/error.rs:42?

@MarinPostma, I found a use case in my own project and thought it could be helpful! Updated translation.

Hey @NoahSaso,
First of all, thank you for your work! That is really clean!
I am wondering if this is a feature we want to add to the engine:

It could impact the speed of the search too much.
We will release facetted searching (aggregations) that will solve the use case you probably have.
Introducing a new operator is probably not that good.

Anyway, I would like too ear more about the use case you have, please, just to see if another feature could fit you.