SQLite Query: Guid literals are wrong

This works on SQL Server, but not on SQLite.
public class GuidKey
{
    [DatabaseGenerated(DatabaseGeneratedOption.None)]
    public Guid Id { get; set; }

    public string Foo { get; set; }
}

public class FindContext : DbContext
{
    public DbSet<GuidKey> GuidKeys { get; set; }
}

[Fact]
public virtual void Find_guid_key()
{
    using (var context = new FindContext())
    {
        context.Add(
            new GuidKey
            {
                Id = new Guid("{3FDFC4F5-AEAB-4D72-9C96-201E004349FA}"),
                Foo = "Smokey"
            });

        context.SaveChanges();
    }

    using (var context = new FindContext())
    {
        var entity = context.GuidKeys.FirstOrDefault(
            e => e.Id == new Guid("{3FDFC4F5-AEAB-4D72-9C96-201E004349FA}"));

        Assert.Null(entity); // Not found

        entity = context.GuidKeys.ToList().FirstOrDefault(
            e => e.Id == new Guid("{3FDFC4F5-AEAB-4D72-9C96-201E004349FA}"));

        Assert.NotNull(entity); // Found by LINQ to Objects
    }
}

PRAGMA foreign_keys=ON;

SELECT "e"."Id", "e"."Foo"
FROM "GuidKey" AS "e"
WHERE "e"."Id" = '3fdfc4f5-aeab-4d72-9c96-201e004349fa'
LIMIT 1

Note that this works, but only because it is client-evaluated:
var entity = context.GuidKeys.FirstOrDefault(
    e => e.Id.ToString() == new Guid("{3FDFC4F5-AEAB-4D72-9C96-201E004349FA}").ToString());

Related to https://github.com/aspnet/Microsoft.Data.Sqlite/issues/191

@natemcmaster Related maybe, but in this case the database was created by EF and the query is fully in the form of Guid objects, not strings.

That literal is wrong. It should be x'f5c4df3fabae724d9c96201e004349fa'. Anywhere else we inline Guid values is also broken.

There's another instance of of this on StackOverflow: How to linq filter on multiple GUID at once generating an appropriate sql where clause


Update question.js

This is for building Friends Trivia skill for Alexa

Trying this out for the first time

Please discard this request. I am just learning on how to use github projects.


upower: 0.99.7 -> 0.99.9, lock down service

Replaces earlier PR, still uses release tarballs uploaded to gitlab
(so not problematic gitlab auto-generated ones, but awkward URL+less official looking)

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)

[X] Works on my machine (https://blog.codinghorror.com/content/images/uploads/2007/03/6a0120a85dcdae970b0128776ff992970c-pi.png)

[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: upower
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: upower
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/14bsip6847shn9jr7g4v9kz8xz5ry4pn-upower-0.99.9
shrinking /nix/store/14bsip6847shn9jr7g4v9kz8xz5ry4pn-upower-0.99.9/bin/upower
shrinking /nix/store/14bsip6847shn9jr7g4v9kz8xz5ry4pn-upower-0.99.9/libexec/upowerd
shrinking /nix/store/14bsip6847shn9jr7g4v9kz8xz5ry4pn-upower-0.99.9/lib/libupower-glib.so.3.0.1
gzipping man pages under /nix/store/14bsip6847shn9jr7g4v9kz8xz5ry4pn-upower-0.99.9/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/14bsip6847shn9jr7g4v9kz8xz5ry4pn-upower-0.99.9/lib  /nix/store/14bsip6847shn9jr7g4v9kz8xz5ry4pn-upower-0.99.9/libexec  /nix/store/14bsip6847shn9jr7g4v9kz8xz5ry4pn-upower-0.99.9/bin
patching script interpreter paths in /nix/store/14bsip6847shn9jr7g4v9kz8xz5ry4pn-upower-0.99.9
checking for references to /build in /nix/store/14bsip6847shn9jr7g4v9kz8xz5ry4pn-upower-0.99.9...

Success on x86_64-linux (full log)
Attempted: upower
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sa36wlyjnbcd77ff2a568nk64sawgr0m-upower-0.99.9
shrinking /nix/store/sa36wlyjnbcd77ff2a568nk64sawgr0m-upower-0.99.9/libexec/upowerd
shrinking /nix/store/sa36wlyjnbcd77ff2a568nk64sawgr0m-upower-0.99.9/bin/upower
shrinking /nix/store/sa36wlyjnbcd77ff2a568nk64sawgr0m-upower-0.99.9/lib/libupower-glib.so.3.0.1
gzipping man pages under /nix/store/sa36wlyjnbcd77ff2a568nk64sawgr0m-upower-0.99.9/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sa36wlyjnbcd77ff2a568nk64sawgr0m-upower-0.99.9/lib  /nix/store/sa36wlyjnbcd77ff2a568nk64sawgr0m-upower-0.99.9/libexec  /nix/store/sa36wlyjnbcd77ff2a568nk64sawgr0m-upower-0.99.9/bin
patching script interpreter paths in /nix/store/sa36wlyjnbcd77ff2a568nk64sawgr0m-upower-0.99.9
checking for references to /build in /nix/store/sa36wlyjnbcd77ff2a568nk64sawgr0m-upower-0.99.9...

:heavy_check_mark: 0.99.9 does fix the regressions introduced in 0.99.8
:question: the source tarball linked here is an upload associated to the tag so I'm 95% sure this can be considered stable (like assets on GH), but not much of a Gitlab expert so I might be wrong


Update parent to formal version 1

Not sure why unit test failed, but I don't think it is caused by this version change because it does not change any quarkus stuff. Merged and will fix it later.


Kruskal Wallis out of range

Error with a vector of two vectors, one of length 4752 and one of length 1974: Statistics.Types.mkPValue: probability is out if [0,1] range.

Here is a simple example:
Stat.kruskalWallisTest [(U.fromList [0,0,0,0,0]), U.fromList [0,0,0,0,0]]


Some Entra Beta commands use types for parameter definition that couldn't be found

The following commands type cast parameters to types that couldn't be found:
Add-EntraBetaScopedRoleMembership
Get-EntraBetaPasswordSingleSignOnCredential
New-EntraBetaAdministrativeUnitMember
New-EntraBetaApplicationFromApplicationTemplate
New-EntraBetaDirectoryRoleDefinition
New-EntraBetaDirectorySetting
New-EntraBetaFeatureRolloutPolicy
New-EntraBetaObjectSetting
New-EntraBetaPasswordSingleSignOnCredential
Remove-EntraBetaPasswordSingleSignOnCredential
Set-EntraBetaDirectoryRoleDefinition
Set-EntraBetaDirectorySetting
Set-EntraBetaFeatureRolloutPolicy
Set-EntraBetaObjectSetting
Set-EntraBetaPasswordSingleSignOnCredential
Set-EntraBetaPrivilegedRoleAssignmentRequest
Set-EntraBetaPrivilegedRoleSetting

Types are:
Unable to find type [Microsoft.Open.AzureAD.Model.RoleMemberInfo].
Unable to find type [Microsoft.Open.MSGraph.Model.PasswordSSOObjectId].
Unable to find type [Microsoft.Open.MSGraph.Model.AssignedLabel].
Unable to find type [Microsoft.Open.MSGraph.Model.ApplicationTemplateDisplayName].
Unable to find type [Microsoft.Open.MSGraph.Model.DirectoryRoleDefinition].
Unable to find type [Microsoft.Open.MSGraph.Model.DirectorySetting].
Unable to find type [Microsoft.Open.MSGraph.Model.MsFeatureRolloutPolicy+FeatureEnum].
Unable to find type [Microsoft.Open.MSGraph.Model.PasswordSSOCredentials].
Unable to find type [Microsoft.Open.MSGraph.Model.AzureADMSPrivilegedSchedule].
Unable to find type [Microsoft.Open.MSGraph.Model.AzureADMSPrivilegedRuleSetting].

To repro, run for example Get-Command Add-EntraBetaScopedRoleMembership -Syntax.

Thank you, @alexandair. You are right. I have managed to repro the bug.
We have queued this for fixing in the upcoming release.

Reopening the issue since some types were missed.

I have done tests on a freshly installed box and confirmed the issue as fixed.


Better integration of ranchervm containers with rancher web gui?

An integration of ranchervm web gui with rancher web gui would be great.
Is an integration planned?
Use create, delete, start, stop and console ranchervm features inside of rancher web gui? For example as an additional tab "virtual machines". rancher should use container machine name instead of a random generated name.

Right now there's no plan to do a deep integration between Rancher and RancherVM web UI. We'll consider it depending on user interest.

Will the ranchervm web gui improved with additional features (networking, routing? multiple vms in a own subnet?).
I like the way to use RancherOS with containers and vms.

I think RancherVM UI will stay relatively simple as a reference. Over time Rancher networking will get more sophisticated and we'll be able to leverage that to run RancherVM.

RancherVM UI is simple, but works fine. So it's ok :)

Over time Rancher networking will get more sophisticated and we'll be able to leverage that to run RancherVM.
I hope some network improvements will be added in the (near) future, because some MVs could need dedicated network cards (bridged to a second host interface or VLANs for example).


Letters appearing when the shouldn't on non-card images

I got the same one (Tom Williams: R)

Also


⚠ SceneTime has degraded performance

In 0f5fde7, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 26444 ms

Resolved: SceneTime performance has improved in d82fdf4 after 5 minutes.


Something is wrong with the testing system

@joeblau, something is wrong with the testing system, old Pull requests are still hanging not-checked. Please, manage it.
TYIA

We've caught up on PRs and are checking them regularly now.


Feature: Send pre-populated checkout link rather than portal

Add a "lite-mode" of sorts, that instead of hosting a web portal for solving captchas, just sends a full cart checkout link that the user can confirm on their own browser if they're logged in already. This may be preferred for users, since their local device's browser likely has better trust and lack of captchas compared to the automation.
This could also just be deployed once and placed on a public notification service (e.g. a Discord server), for all users to consume without deploying anything. The one caveat being how Epic Games behaves when you have previously-owned items in your checkout cart.
This would remove the dependency on Chrome screencast, and could allow for 32-bit ARM devices (#170) to be supported again by using Firefox (#242) for the web API interaction.
The best implementation for v4 would likely be a "lite" image alternative that uses Puppeteer Firefox. Playwright could be considered for a v5, but it may not have puppeteer-extra plugin support for the portal plugin.

If you really intend to include all game content in one shopping cart.
Then is it possible to have the program, automatically add the DLC that is free at the time as well.
If I choose manual mode, I hope I achieve the most perfect result directly

Sad story, that it won't be working anymore, as we are all used now, but hey, it was a great ride as long as it lasted and we're all very thankful for the work you did and that you've allowed us to use this tool.

That looks like a good workaround. After it failed this week I "bought" the game manually to see what happened on my regular browser and I didn't even get a captcha !
So it seems like a direct link to the cart would be much more efficient than a "detected as bot" buying script.


Add a new social images for the article

Use this tool, https://github.com/harlan-zw/nuxt-og-image, in order to easily create images (and to play with)

Does not work well with nuxt content.


The confirmation dialog appears twice when deleting one leased blob container

Storage Explorer Version: 1.8.1_20190605.4
Platform/OS: Linux Ubuntu/macOS High Sierra/Windows 10
Architecture: ia32/x64
Commit: a7b2b07e
Regression From: Previous release 1.8.1
Steps to reproduce:

Expand one normal account -> 'Blob Containers' node.
Right click one blob container -> Select 'Acquire Lease'.
Try to delete the leased blob container -> The confirmation dialog will pop up.
Click 'Yes' on the dialog.

Expect Experience:
It will show an error dialog indicates that the blob container cannot be deleted.

Actual Experience:
The confirmation dialog pops up again.

More info:

The error dialog shows well after clicking 'Yes' on the second confirmation dialog.
This issue doesn't reproduce on latest master build.

I don't see this repro'ing on master, and the build is from the settings branch.
@craxal I'll move it to your milestone, and you can close it once you can confirm it is fixed there
@v-xuanzh can you confirm that it doesn't repro on master

Definitely a feature branch bug only. Problem here was any error caught in executeAction was being passed to the main host when only ProviderNotFound errors should lead to that.


Meteor-Jasmine Karma runaway process

I'm not sure whether this is appropriate as an issue, but I'll post it in case you can help. I have Jenkins running Meteor-Jasmine client unit tests on every commit. It's only been active for a couple days, but it has generally worked until tonight, when the build failed four times in a row and left a runaway Karma process afterwards. I tried running it again and was not able to reproduce the problem.
I'm hoping:

you see something here that can help me debug it
you can suggest modifications so that if it happens again, there will be more useful information for debugging
you can be aware of this in case it affects other users of the tool or it inspires any architectural changes in the tool

Any help you can provide would be much appreciated!
Here is the runaway process before I killed it:
jenkins@staging:~/workspace/sm_meteor$ ps -ef | grep karma
jenkins  19864     1  0 05:29 pts/1    00:00:27 /opt/google/chrome/chrome --user-data-dir=/tmp/karma-49289440 --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate  http://localhost:43752/?id=49289440
jenkins  19875 19864  0 05:29 pts/1    00:00:00 /opt/google/chrome/chrome-sandbox /opt/google/chrome/chrome --type=zygote --user-data-dir=/tmp/karma-49289440
jenkins  19876 19875  0 05:29 pts/1    00:00:00 /opt/google/chrome/chrome --type=zygote --user-data-dir=/tmp/karma-49289440
jenkins  19885 19876  0 05:29 pts/1    00:00:00 /opt/google/chrome/chrome --type=zygote --user-data-dir=/tmp/karma-49289440
jenkins  19907 19864  0 05:29 pts/1    00:00:03 /opt/google/chrome/chrome --type=gpu-process --channel=19864.0.1223439909 --user-data-dir=/tmp/karma-49289440 --supports-dual-gpus=false --gpu-driver-bug-workarounds=1,15,38 --disable-accelerated-video-decode --gpu-vendor-id=0x0000 --gpu-device-id=0x0000 --gpu-driver-vendor --gpu-driver-version --user-data-dir=/tmp/karma-49289440
jenkins  19916 19885  0 05:29 pts/1    00:00:10 /opt/google/chrome/chrome --type=renderer --enable-deferred-image-decoding --lang=en-US --force-fieldtrials=Prerender/PrerenderEnabled/UMA-New-Install-Uniformity-Trial/Control/UMA-Session-Randomized-Uniformity-Trial-5-Percent/group_14/UMA-Uniformity-Trial-1-Percent/group_66/UMA-Uniformity-Trial-10-Percent/default/UMA-Uniformity-Trial-100-Percent/group_01/UMA-Uniformity-Trial-20-Percent/group_02/UMA-Uniformity-Trial-5-Percent/group_14/UMA-Uniformity-Trial-50-Percent/default/ --user-data-dir=/tmp/karma-49289440 --enable-offline-auto-reload --enable-offline-auto-reload-visible-only --enable-delegated-renderer --enable-impl-side-painting --num-raster-threads=1 --disable-accelerated-video-decode --channel=19864.1.1221645282
jenkins  21463 19703  0 07:48 pts/1    00:00:00 grep karma

Here is the log of the build run that I believe (but am not certain) generated the runaway process:
Started by GitHub push by keywonc
[EnvInject] - Loading node environment variables.
Building remotely on staging in workspace /var/lib/jenkins/workspace/sm_meteor
 > git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
 > git config remote.origin.url git@github.com:lab80/sm_meteor.git
Fetching upstream changes from git@github.com:lab80/sm_meteor.git
 > git --version
 > git fetch --tags --progress git@github.com:lab80/sm_meteor.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit}
Checking out Revision xxxx (origin/master)
 > git config core.sparsecheckout
 > git checkout -f xxxx
 > git rev-list xxxx
 > git tag -a -f -m Jenkins Build #17 jenkins-sm_meteor_staging__deploy-17
[EnvInject] - Executing scripts and injecting environment variables after the SCM step.
[EnvInject] - Injecting as environment variables the properties content
DISPLAY=0:0

[EnvInject] - Variables injected successfully.
[sm_meteor] $ /bin/sh -xe /tmp/hudson4669178989601509159.sh
+ bash -c make sm_meteor_staging__deploy
# deploy the server to sm_meteor directory
git submodule update --init
JASMINE_BROWSER=Chrome JASMINE_SINGLE_RUN=1 meteor --test
[[[[[ ~/workspace/sm_meteor ]]]]]

=> Started proxy.
=> Started MongoDB.
I20141127-05:05:19.519(0)? [velocity] chokadir watching /var/lib/jenkins/workspace/sm_meteor/tests
I20141127-05:05:20.474(0)? [velocity] chokadir watching /var/lib/jenkins/workspace/sm_meteor/tests
I20141127-05:05:20.483(0)? [velocity] chokadir watching /var/lib/jenkins/workspace/sm_meteor/tests
I20141127-05:05:20.491(0)? [velocity] chokadir watching /var/lib/jenkins/workspace/sm_meteor/tests
I20141127-05:05:21.556(0)? INFO [karma]: Karma v0.12.24 server started at http://localhost:47396/
I20141127-05:05:21.629(0)? INFO [launcher]: Starting browser Chrome
I20141127-05:05:24.101(0)? WARN [watcher]: Pattern "/var/lib/jenkins/workspace/sm_meteor/tests/jasmine/client/unit/**/*-{stub,stubs,mock,mocks}.{js,coffee,litcoffee,coffee.md}" does not match any file.
I20141127-05:05:28.129(0)? Not migrating, already at version 9
=> Started your app.

=> App running at: http://localhost:3000/
I20141127-05:05:52.904(0)? INFO [Chrome 39.0.2171 (Linux)]: Connected on socket oyx8tRMp6YacC8XYo6pc with id 64730445
I20141127-05:06:10.845(0)? WARN [Chrome 39.0.2171 (Linux)]: Disconnected (1 times), because no message in 15000 ms.
I20141127-05:06:10.850(0)?
Build timed out (after 5 minutes). Marking the build as aborted.
Build was aborted
Finished: ABORTED

I think this is fixed. Reopen please if there is still a problem with it.


are.na filtering and validation lib

macarena and arentv heavily rely on block type filtering and url validation/sanitization. assuming tools in the toolkit will as well, I'm starting to write a general purpose 'library' to make this less of a headache.
here's an example config:
const config = {
  whitelist: {
    source: ['youtube', 'vimeo', 'upload', 'soundcloud'],
    fileType: ['mp3', 'flac', 'wav'],
    blockType: ['attachment', 'media'],
  },
  validation: {
    internalValidators: {
      isValidHref: true,
      HTTPSonly: false,

    }
    externalValidators: {
      reactPlayer: (item) => reactPlayer.canPlay(item),
      imageIntegrity: (item) => validateImageIntegrity(item),
    }
  },
  sanitization: {
    forceHttps: false,
    fillTitle: true,
  }
}

the pipeline goes something like this. ideally this is lazy and only runs validation / regex etc on items that cannot be easily rejected according to blockType
get channel contents |>
does blockType pass? append with message |>
getURL |>
decide if the URL is valid and sanitize, append with message|>
any other external validators (reactPlayer), append with message |>
superficial sanitization (fill untitled blocks etc |>
return copy of contents with messages

i propose it is appropriate to append messages about this process to the block itself in the following fashion:
{
  ...contents,
  validation: {
    source: {
      pass: true,
      isOfType: 'YOUTUBE',
      message: '',
    },
    fileType: {
      pass: false,
      isOfType: 'NO_FILE'
      message: '',
    },
    blocktype: {
      pass: true,
      isOfType: 'MEDIA'
      message: '',
    },
// external validators ( idk ? )
    reactPlayer: {
      pass: true,
      isOfType: 'CANPLAY'
      message: '',
    }
  }
}

The final Q is – should this be a node module?

So great. Within the Toolkit, I was thinking modules like this could be loaded once, and then provide a global interface for other tools. As a node module, this model would imply one import, rather than a separate import for each tool. I'm open to other strategies, but I think this will reduce page weight and complexity in the long run.

One piece of related functionality that's also worth mentioning is a "block fetch" module. Once block data has been validated and the block type determined, it would be quite useful to retrieve specific data from those objects.
Examples
MP3: parse ID3 metadata & return non-empty fields
jpeg: parse embedded metadata + determine file size
http: navigate to url, return , attempt return of body text
pdf: title / author / number of pages

single load sounds good to me. each validator should just be plug and play, so each tool can provide it's own custom validation methods if necessary.
and yes, i think this is where the tinyAPI parser from mac.are.na would be a good fit

https://github.com/gavinpatkinson/validate-arena
heres a first pass

ok after building /prototyping this a little i have a thought about how general this can/should/wants to be:
rn we have a config as follows:
const validatorConfig = {
    whitelists: {
      class: ['Attachement', 'Media'],
      providerName: ['YouTube', 'Vimeo', 'SoundCloud'],
      extension: ['mp3', 'flac', 'wav'],
      state: ['available'],
    },
    sanitizers: {
      cleanURL: block => cleanURL(block),
      fillTitle: block => fillTitle(block.title),
    },
    validators: {
      reactPlayerValidator: block => reactPlayerValidator(block),
    },
}

BUT what we could do instead is:
const validatorConfig = {
    whitelists: {
      block.class: ['Attachement', 'Media'],
      block.source.provider.name: ['YouTube', 'Vimeo', 'SoundCloud'],
      block.attachment.extension: ['mp3', 'flac', 'wav'],
      block.state: ['available'],
      channel.whatever.something.heck: ['yadda'],
    },
    sanitizers: {
      cleanURL: block => cleanURL(block),
      fillTitle: block => fillTitle(block.title),
    },
    validators: {
      reactPlayerValidator: block => reactPlayerValidator(block),
    },
}

this way the lib becomes more of a general purpose object validator which is p cool.


Vectorizer improvements

This PR introduces a few improvements to the vectorizers module:

Raises ValueErrors when the wrong input type is not passed in.
Updates the methodology for fetching the output dimensions of the embedding model.

Codecov Report

Merging #44 (533e56a) into main (29bb39a) will decrease coverage by 0.90%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   87.70%   86.80%   -0.90%
==========================================
  Files          13       13
  Lines         602      614      +12
==========================================
+ Hits          528      533       +5
- Misses         74       81       +7

Files Changed
Coverage Δ

redisvl/vectorize/text/openai.py
81.63% <60.00%> (-6.18%)
:arrow_down:

redisvl/vectorize/text/huggingface.py
80.76% <71.42%> (-5.60%)
:arrow_down:

redisvl/__init__.py
100.00% <100.00%> (ø)

redisvl/vectorize/base.py
79.31% <100.00%> (ø)

... and 1 file with indirect coverage changes


Book class

In this Pull request i:

Create the Book class
Add methods for a book class

Thank you @ibr5500 for the code review


TST/ENH: have the parameterize decorator generate descriptive ids

pytest.mark.parametrize generates descriptive IDs for the parameters provided.
This PR provides similar behavior for the cupy.testing.parameterize decorator.
Prior to the present PR, this decorator justt enumerates the parameters as "_param_0", "_param_1", etc.
A concrete example:
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_0.test_cupy_array ✓                20% ██▏
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_1.test_cupy_array ✓                22% ██▎
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_2.test_cupy_array ✓                23% ██▍
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_3.test_cupy_array ✓                24% ██▌
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_4.test_cupy_array ✓                25% ██▌
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_5.test_cupy_array ✓                27% ██▋
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_6.test_cupy_array ✓                28% ██▊
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_7.test_cupy_array ✓                29% ██▉
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_8.test_cupy_array ✓                30% ███
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_9.test_cupy_array ✓                31% ███▎
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_10.test_cupy_array ✓               33% ███▍
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_11.test_cupy_array ✓               34% ███▍
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_12.test_cupy_array ✓               35% ███▌
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_13.test_cupy_array ✓               36% ███▋
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_14.test_cupy_array ✓               37% ███▊
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy_param_15.test_cupy_array ✓               39% ███▉

after this PR, more decriptive ids are generated
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[True-0-numpy].test_cupy_array ✓          20% ██▏
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[True-0-cupy].test_cupy_array ✓           22% ██▎
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[True-1-numpy].test_cupy_array ✓          23% ██▍
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[True-1-cupy].test_cupy_array ✓           24% ██▌
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[True-2-numpy].test_cupy_array ✓          25% ██▌
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[True-2-cupy].test_cupy_array ✓           27% ██▋
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[True-3-numpy].test_cupy_array ✓          28% ██▊
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[True-3-cupy].test_cupy_array ✓           29% ██▉
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[False-0-numpy].test_cupy_array ✓         30% ███
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[False-0-cupy].test_cupy_array ✓          31% ███▎
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[False-1-numpy].test_cupy_array ✓         33% ███▍
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[False-1-cupy].test_cupy_array ✓          34% ███▍
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[False-2-numpy].test_cupy_array ✓         35% ███▌
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[False-2-cupy].test_cupy_array ✓          36% ███▋
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[False-3-numpy].test_cupy_array ✓         37% ███▊
tests/cupy_tests/creation_tests/test_from_data.py::TestArrayCopy[False-3-cupy].test_cupy_array ✓          39% ███▉

I find this useful when testing to more quickly determine which cases are failing.

 I was not sure any cases in CuPy would make use of these, but if they are of interest, we restore them.

Oh this is handy!

Thank you for your work!
Actually we have a similar code to include parameters in test class names in Chainer. As cupy/testing is a fork of chainer/testing, I'd like to pull this feature from Chainer.
https://github.com/chainer/chainer/blob/959eb4866525bf7d2e90af5ef3ae628fbbf6ca56/chainer/testing/parameterized.py#L33-L101

Okay, that should work too. Do you recommend I copy that code over in this PR then?

For reference, I also made an upstream PR to pytest to allow the __name__ attribute to be used on any object (rather than just functions or classes): pytest-dev/pytest#6152. That is useful for getting the names of "numpy" or "cupy" to show up in that name if modules are used as parameters.

Do you recommend I copy that code over in this PR then?

Yes, please. (Lot of changes has been made in Chainer repo since fork, so the region I quoted may not be sufficient)

For reference, I also made an upstream PR to pytest to allow the name attribute to be used on any object (rather than just functions or classes): pytest-dev/pytest#6152. That is useful for getting the names of "numpy" or "cupy" to show up in that name if modules are used as parameters.

Great!

closing in favor of #2633


End Portal Parallax changes with Y

While the feature states that it might not be entirely accurate, this is a thing that I believe is just a rendering/shader error and can be corrected.
When moving up and down, or crouching or flying or anything, the starfield appears to shift and morph, which is very much distracting.
It looks as though the starfield is plastered on the surface of the block, only minimally changing its perspective based on your height, rather than appearing as an actual drop in to the void.
Aside from that, and what seems like a tendency towards a deeper blue versus original blueish green, it's very nice to see this back in any capacity. It was one of the small things they changed which had a big impact on the look and feel of the game, and it's unfortunate that it appears a bug prompted them to give up on the old render and change to this cutout.
Log: There is no crash, and no direct error, so I don't know what to do about that.

Looking at it closer, it seems that the layers of the starfield are being distorted towards -X -Z the closer to the surface of the block the camera gets.
It seems like the layers also get closer together, instead of maintaining their depth?
I don't know if that helps debugging it, but I'm trying!

There's also a lot of jitter in the effect the closer you get to it, most visible by Spectator-ing right up to the surface of the portal and moving/looking around.

I tried specifically to not do this, and suspect it's related to #529. Does this still happen in 3.0.1? That's before that was merged.

it's not related to 529

Here's a video demonstrating the problem:
https://www.youtube.com/watch?v=cXDY-G6nh9Y

#531 should fix this.

Fixed by #531


Add to Homebrew Cask

It would be helpful to MacOS users if we could install DBGlass with brew cask install dbglass
https://caskroom.github.io/
Thanks for this, it's beautiful!

@groteworld Thank you, we'll create a brew package

Thanks very much, I would prefer a brew formula instead of a brew cask one. Having 30 Electron frameworks and 30 nodejs installed is not the most proper usage of disk space.

@cbertelli brew is really only for binaries and frameworks that are command-line based like node, git, and grep. brew cask is for graphical programs like atom, google-chrome, spotify and in this case dbglass.

@groteworld You are right, but DBGlass is based on frameworks that are already installed by brew and are big enough to make me hope they are not multiplied by cask into each installed app. Look inside the Framework folder: Electron weights 107 MB, Mantle is almost 192 MB. DBGlass in itself is lean and whippy: three helper apps (around 10 KB each), the main command, 8 KB; the heaviest thing are the languages in Resouces (around 18 MB). Anyway getting it installed by brew cask is very convenient.

I hear the pain, it's a problem with all electron apps.

I've just installed DBGlass by running brew cask install dbglass, so I guess this issue can already be closed, am I right?
Thanks!

Yes, it runs smoothly. You may close it.
Thanks for checking it out.
c
On Wed, Mar 15, 2017 at 4:15 PM, Edu Saborit<EMAIL_ADDRESS>wrote:

I've just installed DBGlass by running brew cask install dbglass, so I
guess this issue can already be closed, am I right?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/web-pal/DBGlass/issues/14#issuecomment-286773721, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIobxIYMce3KTQTSz91CXrlmuattXaoEks5rmAB5gaJpZM4KTT0b
.

--
Carlo A. Bertelli
Charta servizi e sistemi per il territorio e la storia ambientale srl
Dipendenze del palazzo Doria,
vc. alla Chiesa della Maddalena 9/2 16124      Genova (Italy)
tel./fax +39(0)10 2475439  +39<PHONE_NUMBER>  mobile:+39<PHONE_NUMBER>
e-mail<EMAIL_ADDRESS>http://www.chartasrl.eu

https://github.com/web-pal/DBGlass/issues/46


Fix: Fix sqlx lifetime over streaming functions

Fixes https://github.com/mbuczko/hugsqlx/issues/8
Hi, as mentioned in the issue above, here are my fixes. In addition to the changes to hugsqlx-core. I've also shuffled around the examples directory and added a few more runnable examples to ensure that the compiles can go through.
These examples should contain most of the possible permutations of query types supported in this crate for postgres, mysql and sqlite but do let me know if I have missed out anything.
Cheers

Changes released in 0.3.0


Please improve description for direction_of_sea_water_velocity standard name

The description for the direction_of_sea_water_velocity standard name doesn't clearly state that it's a "to" direction. I assume it follows oceanographic convention, but think it needs to be stated explicitly.  Wind and wave direction variables have _from and _to options, with clear descriptions of what this means.  I think we can do better for direction_of_sea_water_velocity.
Thanks!

I don't see direction_of_sea_water_velocity in the current SN table, only sea_water_to_direction and sea_water_from_direction. Did this issue get reopened by accident?

I am closing this issue because it refers to an alias of the current name sea_water_velocity_to_direction. The issue is resolved by the name change.


Tidy up eiger when pin too long

When the scan is invalid we do not correctly tidy up the eiger as it's asynchronously arming in the background. This may be fixed by https://github.com/DiamondLightSource/python-artemis/issues/765, we should test this

Testing https://github.com/DiamondLightSource/python-artemis/pull/765 on the beamline showed this doesn't quite work as we get an error waiting for the Eiger to get all the images. We should implement a stop that doesn't wait


Allow custom agent directories

Describe the bug

Currently if you name the agent directories manually it messes up new agent creation
Agent creation gets stuck at a number and does not go up
This is because generate_agent_id doesn't check for the existence of the folder

e.g. would keep getting "agent_4" over and over if your directory structure looks like:
 % ls ~/.memgpt/agents
agent_1         agent_4         bill_gates

3 total agents, 3 -> 4, but agent_4 already exists. This gives you the following output:
% memgpt run

? Would you like to select an existing agent? No

🧬 Creating new agent...
->  🤖 Using persona profile 'sam_pov'
->  🧑 Using human profile 'basic'
🎉 Created new agent 'agent_4'

Which makes you think a new agent was created, but instead it's tied to the old one (archival memory will be shared).

@sarahwooders is this by design? regardless we should patch generate_agent_id to prevent confusion even if the user edits agent folder names while not allowed

This bug also seems to happen if an agent folder is missing:

[ ] Try to repro with below

agent_1
agent_2
...
agent_13

rmdir agent_1
agent_2
...
agent_13

Now memgpt run should always create a new agent "agent_13", even though it already exists.


Main Menu

[x] Press Start.
[x] Main menu: New Game. Load Game. Options. Credits. Exit.

Press Start.
Main menu: New Game. Load Game. Options. Credits. Exit.
Options: Resolution. Full screen. General volume. Muisc volume, effects. Quality.

Final result in https://github.com/azsumas/HorrorShooter/commit/b2a8b434ec6511978024798b5b123d0ef8ceb557 commit.
Previous and new version.


Switch OAuth2 HTTP surface to use builder pattern

Add inner Builder class to each data container type classes
Update tests

TODO: Switch the rest of the auth lib to builder pattern

PTAL @garrettjonesgoogle

@garrettjonesgoogle Travis failed with unrelated issue:
Error: JAVA_HOME is not defined correctly.
We cannot execute /usr/lib/jvm/java-7-oracle/bin/java
Can we bypass this check?

We should turn off the oraclejdk7 build in Travis altogether (we already did in gax-java and google-cloud-java)

https://github.com/google/google-auth-library-java/pull/124


tf Ros_humble gz no frame_id, child_frame_id or header being populated.

Environment

OS Version:  Ubuntu 22.04
ROS version : Ros2 humble
gazebosim/ros_gz: Tried with ros2(rolling rosdep?) and humble branch

Description

Expected behavior:  /tf data to have frame_id and child frame just like gazebo

Actual behavior:  tf in ros2 humble to have missing headers and child_frame_id

Steps to reproduce

Write launch description as below
try not to cry

def generate_launch_description():
  tf_bridge = Node(
    package='ros_gz_bridge',
    executable='parameter_bridge',
    # topic@ros_type@gazebo_type
    arguments=[
        f'/world/my_world/model/my_model/joint_state<EMAIL_ADDRESS>        f'/world/my_world/pose/info<EMAIL_ADDRESS>    remappings=[
        (f'/world/my_world/model/my_model/joint_state', '/joint_states'),
        (f'/world/my_world/pose/info', '/tf')
        ],
    output='screen'
    )

  return LaunchDescription([
    tf_bridge
  ])

Hi all,
Any news on that issue? I have the same problem.
Could you provide some hints to try to debug that and potentially fix the issue "by hand" for the moment?

Hi all, Any news on that issue? I have the same problem. Could you provide some hints to try to debug that and potentially fix the issue "by hand" for the moment?

Dont think they have solved it yet. As you can see, the issue is sent to a TODO in core development. We just kinda have to wait patiently.
The workaround would be have all the poses in a single file. Which kinda defeats the purpose of an include. Any include will cause the tf to not get published correctly.

It's best to use the PosePublisher system for working with tf (eg. https://github.com/gazebosim/ros_gz/blob/ros2/ros_gz_sim_demos/launch/tf_bridge.launch.py). The pose/info  topic is published by the SceneBroadcaster system, which is meant to be used by the GUI.


[WIP][SPIKE] Design Byzantine Network Simulator

Objective
Conduct research and create a design document for a Byzantine Network Simulator for LocalNet that allows for arbitrary configurations and the ability to introduce complex network topologies, as well as various types of actors in the system. This design document should outline how the simulator will be integrated with performance monitoring metrics and have the capability to run stress and chaos tests in our Kubernetes environment.
Origin Document
This ticket is based on the scope outlined in #583, which aims to implement network simulation. The purpose of this ticket is to address the design of that scope in a well-defined and well-documented manner
Goals

Conduct research on existing Byzantine Network Simulators and related technologies
Outline a design for a Byzantine Network Simulator that can be smoothly integrated with DevNet and LocalNet
Explore chaos testing integration possibilities (e.g., https://chaos-mesh.org/)
Define any relevant metrics for performance monitoring

Deliverables

[ ] A comprehensive design document detailing the proposed Byzantine Network Simulator, including:

[ ] Architectural overview
[ ] Tooling for starting a LocalNet with Byzantine actors and the ability to configure complex network topologies
[ ] Functionality to trigger actions for Byzantine actors manually or programmatically for testing purposes
[ ] Integration with performance monitoring metrics
[ ] Chaos testing possibilities and integration

Non-Deliverables

Direct implementation of the Byzantine Network Simulator
Design that changes how LocalNet fundamentally works
Design that breaks the DevNet integration

General issue deliverables

[ ] Update the appropriate CHANGELOG
[ ] Update any relevant READMEs (local and/or global)
[ ] Update any relevant global documentation & references
[ ] If applicable, update the source code tree explanation
[ ] If applicable, add or update a state, sequence or flowchart diagram using mermaid

Testing Methodology

[ ] All tests: make test_all
[ ] LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @jessicadaugherty

Hey @dylanlott could you ptal when you have a chance? ty!

For posterity, document is available here: https://www.notion.so/pocketnetwork/Byzantine-Network-Simulator-fd9002b599aa44e98eb94ec400d5e6ef?pvs=4


My original png got fked. So i replaced it with the correct version.

This was added in 35246f2171947c94c16f03abc42dec0edb3b7787 thanks!


fix: Waring CS0618 ListItemAutomationPeer

What does the pull request do?

Warning	CS0618	'ItemContainerGenerator.IndexFromContainer(Control)' is obsolete: 'Use ItemsControl.IndexFromContainer'	Avalonia.Controls (net6.0)	src\Avalonia.Controls\Automation\Peers\ListItemAutomationPeer.cs	67	N/A

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

You can test this PR using the following package version. 11.0.999-cibuild0029469-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0029487-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Public dosumentation lpc 02

Public documentation for "EOS S3" SoC application with embedded "LPC Peripheral" implementation in Verilog. Finished not reviewed.

@mgabryelski1  Integrated into: https://github.com/lpn-plant/lpntpm-docs/pull/29
There is no point in creating second MR for the same content. Especially, if there is already some ongoing review in the first one.


Add CheckStyle

In addition I have put CheckStyle in travis.

@CoXier It is my fault that didn't mention max line length in the project.


AMP articles with unicode in their attributes don't get detected

At present the amp path function only detects articles with the word amp inside their html elements attributes. Per the AMP spec you can either use amp or a lightning bolt emoji to inform the cache that the document you're serving is an amp article.

Resolved this bug with a simple string replace.


Pressing Esc to return to lighttable only works when canvas has focus

Steps to reproduce:

open an image in darkroom
click somewhere in the right area with histogram and slider, press Esc without clicking anywhere else before
nothing happens
click somewhere in the image canvas, press Esc without clicking anywhere else before
UI returns to lighttable

yes that was by design once because some controls might be active and want to do something else with the esc/circle input. will need to carefully go through the ui controls and see if that is still the case. i agree that using a global esc to exit would be better.


Pandas copy warning

Updated iloc assignement in function group_significant_layers.
This avoids a SettingWithCopyWarning

@maarten-betman thanks for the contribution! can you remove the "merge commits"? If you do a git rebase instead of a git merge you will not have those comments.

LGTM! As last thing maybe you can squash the 2 commits in 1 commit, since they are both changing the same line and only the last one is valid. You can do that with an interactive rebase: git rebase -i HEAD~2 (https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history), then do a git push --force-with-lease @ritchie46 can you merge if you agree?

@martinapippi You were a bit to quick for me. I did the re-base incorrectly (never rebased before so still need to get the gist of it). The original suggetion is now merged df_group.iloc[-1, 2] = depth
The new commit now contains the correct change. Appologies for any inconvenience caused.


Ability to treat semi-structured fields as maps instead of structs

It is common to have map type data in a kafka stream with a large (potentially unbounded) set of keys. Currently, this can result in struct type columns with a large number of fields which is problematic.

I also hope that feature..!
related issue: https://github.com/tabular-io/iceberg-kafka-connect/issues/141


Emmet: Accessing a resource scoped configuration without providing a resource is not expected

This only appears in the exthost.log of our integration tests:
[2022-08-15 23:14:14.190] [exthost] [warning] [vscode.emmet] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'emmet.includeLanguages', provide the URI of a resource or 'null' for any resource.

This issue should be fixed now
There was a separate PR/issue where I removed the resource scope from that setting since I didn't implement adding on that scope properly anyway.


Fix always enabled Windows Shell Extension installation

Fixes #349

@mwestphal

Nice !

Does this fix the "automatically open files with certains extensions with F3D" issue too ?


Checkpoints

Hey! read the paper and im super excited to play around with this model, are you planning on releasing the checkpoints soon?
Thank you for your work!

That's a good point. Due to some recent time crunch I haven't had time to release the encoder checkpoints we use.
The current code released in not 100% complete, but is intended to give people a broad idea of how we do things.
I will release the following this summer:

Checkpoints
Brain masks for each brain region
A jupyter notebook for easy experimentation


Bugfix/android disablefocus audio

Provide an example of how to test the change
Test by playing music from a different app. Letting it play in the background, and open your app with different videos set to "disableFocus" true and false on different views in your app on an Android device. You will notice that the videos with true will allow the background music to play, while the ones set to false will stop the background music.
Describe the changes
This PR makes it so the requestAudioFocus method never gets called before the props get set from the react native component. I noticed that the disableFocus was false at first and would change to true, so I thought it best to also stop it if there was no srcUri as well.

I warmly welcome this PR, and I hope it gets merged soon. :)

What's the current status on this?

Since this still needs to be merged, I just wanted to also confirm that I was having the same issue with the disableFocus prop and this got it working.

This works exactly as expected 👌

I can confirm this fixed my issue. It's really annoying stopping other app's sound when start app(my app has a landing video).

I can also confirm that this fixes the issue on Android. Can this merged and added to the next release?

It would be great if this could get merged, would avoid me needing to fork it :). Thanks RN Community team!

For me it is approved, so a good candidate for next release.

Hey @KurtMakesWeb just wanted to thank you for putting in this fix and if it's not too much to ask: could you please resolve the merge conflicts so that it can me merged? I'm working on a project that needs this and I would rather not have to create a fork for this purpose alone.

related: https://github.com/react-native-community/react-native-video/issues/1462#issuecomment-504999168

@pouyaemami I've fixed the merge conflicts. All should be good now


Add UpdatePartition and UpdatePartitions interface.

This allows caller to update the Name, ID, and GUID on a partition type.
Previously to accomplish this, caller would have to delete the partition
and add a new one with the updated info.
For now, the size of the partition is not updated.

My suggested changes are at https://github.com/anuvu/disko/pull/111
Please review that and see what you think.


implement PCI/PCIe capabilities used in QEMU

PCI:

PCI_CAP_ID_HT
PCI_CAP_ID_SATA
PCI_CAP_ID_SHPC? (hw/pci/shpc.c)
PCI_CAP_ID_SLOTID? (hw/pci/slotid_cap.c)

Ignored:

hw/pci-bridge/pcie_pci_bridge.c
hw/vfio/pci.c
hw/xen/

PCIe (hw/pci/pcie.c and hw/pci/pcie_aer.c):

PCI_EXT_CAP_ID_ARI
PCI_EXT_CAP_ID_DSN
PCI_EXT_CAP_ID_ATS
PCI_EXT_CAP_ID_ACS
PCI_EXT_CAP_ID_ERR

Ignored

hw/vfio/pci.c

See also #183, #87

See also #183, #87

Existing devices in QEMU won't be reimplemented as libvfio-use devices, therefore this issue is low priority.


Release v1.9.8

Release v1.9.8
@runcom @rhatdan PTAL
We will need new rpms after this merged.

LGTM

cc: @lsm5


:seedling: Bump golang from 4b1fc02 to 6b3fa4b

What kind of change does this PR introduce?
This is a PR to update the golang docker images in one swoop instead of 7 PRs.

[X] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
What is the new behavior (if this is a feature change)?**

[ ] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes
Fixes #3179
Fixes #3183
Fixes #3184
Fixes #3185
Fixes #3186
Fixes #3187
Fixes #3188

Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

@dependabot rebase

@dependabot merge


Completions not working with lifetimes

struct Foo;
impl Foo {
	fn f1<'a>(self) {}
	fn f2(self) {}
}

fn main() {
	let mut x = Foo;
	x.
}

Completion doesn't work if <'a> is present in this code.

Hi @krzat, Thanks for the bug report
I fixed this last night but forgot to push, oops! The single-quote string masking code was getting confused with lifetimes, it should work now

Cool, thanks. Completion vector takes like 5 seconds though. I will think
about caching maybe, it should be pretty easy to do per file and using last
modified date to keep it fresh.

Hi @krzat. Wow that sounds like a long time. Is this on a release build? (cargo build --release).
How long does this take on your machine?
let v = Vec::new();
v.<tab>

Caching may be the solution, but I'd like to profile first; I suspect racer is doing some unnecessary work in the area of following glob imports.
(N.B. I don't think caching is as easy as you think because racer doesn't parse/type-infer whole files)

Yep, I didn't notice it was debug build. On release it's not bad:
real 0m1.135s
user 0m0.501s
sys 0m0.607s
I will think about the caching, for example when you do let src =
racer::load_file(&m.filepath); it seems like a good occasion to cache
everything necessary, so you don't have to open it again (unless it
changes).


Disable Shutter sound when taking Photo

@Awalz
Is it possible to disable the shutter sound when the takePhoto method is called?
In my usecase, while user is recording, at some point I also takePhoto.  That way at output I have both a video and a thumbnail photo. But I dont want the take photo sound to go off.

It is not possible to disable the shutter sound manually. Such attempts result in a rejection from the app store due to this section in App Store Guidelines:
Section 3.3.8 : Any form of user or device data collection, or image, picture or voice capture or recording (collectively “Recordings”), and any form of data, content or information collection, processing, maintenance, uploading, syncing, storage, transmission, sharing, disclosure or use performed by, through or in connection with Your Application must comply with all applicable privacy laws and regulations as well as any related Program Requirements, including but not limited to any notice or consent requirements. In particular, a reasonably conspicuous audio, visual or other indicator must be displayed to the user as part of the Application to indicate that a Recording is taking place.
However, the shutter sound should not go off while video is recording. If you call the takePhoto() function while video is being recorded, the shutter audio should not be played. I just tested on the demo project
Andrew

@Awalz
I think its my implementation. I use a tapGesture on the circleButton which interpolates into a 10 second animated circle counter because I force users to take exactly 5 second videos. Sometimes I hear the shutter, sometimes I dont. Perhaps I should get a frame from the resulting video URL instead.
 func swiftyCam(_ swiftyCam: SwiftyCamViewController, didBeginRecordingVideo camera: SwiftyCamViewController.CameraSelection) {
        self.cameraActivity(state: .start)
        Timer.after(0.2) {
            self.takePhoto()
        }
    }

This is currently my code I just used to test. I wrote a delay function which takes a photo 0.2 seconds after video begins recording.I did get any shutter sounds:
func swiftyCam(_ swiftyCam: SwiftyCamViewController, didBeginRecordingVideo camera: SwiftyCamViewController.CameraSelection) {
       // UI animations from demo project
        print("Did Begin Recording")
        captureButton.growButton()
        UIView.animate(withDuration: 0.25, animations: {
            self.flashButton.alpha = 0.0
            self.flipCameraButton.alpha = 0.0
        })

        delay(delay: 0.2) {
            self.takePhoto()
       }
}

func delay(delay:Double, closure:@escaping ()->()) {
    DispatchQueue.main.asyncAfter(deadline: .now() + delay) {
        closure()
    }
}

Andrew

@Awalz This is also another very random occurance. Alot of times I wont get the shutter either but also I'll get it abit from time to time.
I just find another method to get a thumbnail photo from the video


Fixed signup command to use proper params

The params must be named "ns", "db", "sc" (or same in all caps), see:
https://github.com/surrealdb/surrealdb/blob/c2dce39f91e0f0cc60c6d059156f455fd13c3964/src/iam/signup.rs#L14
Also, the object constructed needs to be actually passed :)

Realized same issue ought to be fixed in signin but I haven't had time to
get there :)
Regards, Göran
On Fri, 13 Jan 2023, 17:27 Duhan BALCI, @.***> wrote:

Merged #12 https://github.com/duhanbalci/surrealdb_flutter/pull/12 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/duhanbalci/surrealdb_flutter/pull/12#event-8222442943,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAVUHWZUROGILG227DU7ITWSF7AZANCNFSM6AAAAAAT2MSUOY
.
You are receiving this because you authored the thread.Message ID:
@.***>


rave: cell size flag

As the cell size for programs ran by Rave is fixed to 32-bits (for now), some programs just can't be ran.
I'll take on implementing a switch allowing to change the bitness tomorrow.

Solved recently (crappy workaround, will get to implement something better)


fix(firefox): fix cookies in default browser context

This patch adds tests and fixes the nodejs part of the problem.
The issue will be fixed once we roll a new version of Firefox.
References #4470

When we can expect the release with this fix? Thanks!


Add a filter to hide the points that aren't tagged

This makes a few changes:

Add a filter (["==", ["get", "@type"], "node"]) that hides untagged points on the map
Interpolate the line width and point size by zoom so that it's easier to see what's going on at lower zooms
Switch to a tileset that has a wider zoom range (z7-z13)

Ah sorry, I forgot to make a branch and my main branch fork stuff is leaking into this PR.

These all seem like very welcome edits! happy to take a look whenever.


RTSP/WebRTC Stream Freezing

Which version are you using?
v0.22.0
Which operating system are you using?

[ ] Linux amd64 standard
[x] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
We're trying to stream a screen capture from a windows VM in Azure. We use ffmpeg and gdigrab to capture the desktop content and send it over rtsp to an rtsp-simple-server running on docker in another VM (also on azure). When we then try to view the stream using the built-in WebRTC player, the stream mostly works, but it periodically freezes. It usually freezes for 5-10s at least every 2 minutes. Is there perhaps a way to reduce this? Or do you know how we could analyze this further? Any help you can provide would be greatly appreciated :)
Describe how to replicate the issue

set up two VMs:

Windows-VM:/home/wetter/Work/remote-control/RemoteControl/poc/rtsp-simple-server-poc/github-issue/diff.yml

Azure "Standard D4s v3 (4 vcpus, 16 GiB memory)"
Windows Server 2022 Datacenter Azure Edition

Ubuntu-VM:

Standard DS3 v2 (4 vcpus, 14 GiB memory)
Ubuntu 22.04

Start RTSP Simple Server with the following docker compose config and server configuration:

docker-compose.yamlversion: '3.8'
services:
rtsp-simple-proxy:
    image: aler9/rtsp-simple-server:latest
    # networks:
    #  - original
    volumes:
    - /home/azure_user/video-proxy/mount:/mount
    - /home/azure_user/video-proxy/config/rtsp-simple-server.yml:/rtsp-simple-server.yml
    restart: always
    ports:
        - 8554:8554
        - 1935:1935
        - 8888:8888
        - 8889:8889
        - 8189:8189
        - 8322:8322
    expose:
    - 8554
    - 8322
    - 1935
    - 8888
    - 8889
    - 8189

rtsp-simple-server.yml (these are just the differences to the default values):# Timeout of read operations.
readTimeout: 40s
# Timeout of write operations.
writeTimeout: 40s
protocols: [tcp]
hlsEncryption: yes
#### hlsServerKey: server.key
hlsServerKey: ./mount/server.key
# Path to the server certificate.
#### hlsServerCert: server.crt
hlsServerCert: ./mount/server.crt
hlsAlwaysRemux: yes
hlsSegmentDuration: 300ms
hlsPartDuration: 100ms
paths:
  all:
    # If sourceOnDemand is "yes", readers will be put on hold until the source is
    # ready or until this amount of time has passed.
    sourceOnDemandStartTimeout: 40s
    # If sourceOnDemand is "yes", the source will be closed when there are no
    # readers connected and this amount of time has passed.
    sourceOnDemandCloseAfter: 40s
    rpiCameraDenoise: 'off'
    # Readers will be put on hold until the runOnDemand command starts publishing
    # or until this amount of time has passed.
    runOnDemandStartTimeout: 40s
    # The command will be closed when there are no
    # readers connected and this amount of time has passed.
    runOnDemandCloseAfter: 40s

Start FFMPEG stream with following command:

ffmpeg -r 10 -f gdigrab -i desktop -pix_fmt yuv420p -vcodec libx264 -b:v 1024k -maxrate 2058k -bufsize 2058k -profile:v main -preset ultrafast -tune zerolatency -bf 0 -f rtsp rtsps://<SOMEUSER>:<SOMEPASSWORD>@<UBUNTU_VM_IP>:8322/<STREAM_NAME>

View Stream at WebRTC address and wait for freezing

https://<UBUNTU_VM_IP>:8889/<STREAM_NAME>/
Freezing seems more common when the streamed video is more dynamic (like a video with changing scenes)

Did you attach the server logs?
yes
shortlogs.txt
Did you attach a network dump?
no, we did analyze the network traffic with wireshark, but found no changes in the traffic as the freezes were occurring. If its still necessary we can still find the tcpdump and provide it here.

I have this problem too when sourcing an RTSP from my ip camera.
Opening the camera directly there's no freezes.
But opening via mediamtx freezes at least once every 2 minutes.
I have tried udp/tcp and changing readBufferCount to 65536. No difference.
PS: It freezes at the same time on RTSP and WebRTC. So the issue probably isn't in the server protocol.

I have this problem too.
I have tested with some pre-recorded mp4 file, and found that it freezes the same play position.
I hope this information can help you fix this bug.
With this 1 and half minute mp4 file, it freezes at 54:09 and 1:21:19.
Here is my console command for this test.

ffmpeg -stream_loop -1 -re -i rtmp.mp4 -an -c:v copy -f flv rtmp://<IP_ADDRESS>/spark

Here is the mp4 link.
https://1drv.ms/v/s!Ah_4wJEkmvj6rX7kUF0Ik1LG0Q6y?e=Rt9AsI

I'm also facing this problem with mp4 h264 files streamed to WebRtc clients in a
ffmpeg rtsp -> mediamtx -> browser
setup.
On some video files, despite explicitly removing any fancy h264 stuff (baseline profile) to ensure full browser webrtc compatibility, the stream freezes for a second or two, always at the same timestamps.
When I use mediamtx to "provide" the rtsp stream to another go-based webrtc server (that does no reencoding either), the freezing does not occur, so there's something specific about the way mediamtx handles the video/webrtc that amplifies this issue.
Sadly this is very vague since I cannot provide the example videos for legal reasons, but I can try to provide any file/meta information that could be helpful.

A complete explanation on why this bug happens is here: https://github.com/Glimesh/janus-ftl-plugin/issues/101


Update mgmt SDK to track2

Update resource mgmt SDK from track1 to track2.
@qiaozha for notification.

@diberry Can you help take a look at this PR ? Thanks


Homogenise two setup methods (+ fixes)

Assuming that we want to keep the less automated method, couple of things need to be addressed:

[ ] Rename this (it's always CMake) and improve sectioning logic
[ ] Fix the install dir to use bin/

And in the automation script build_tsmp2.sh (Quick start section):

[ ] Either give a better name to cmake_install_dir or make it an actual directory and write out the -D cruft when it is used
[ ] Same for cmake_compiler (combine with fixing typo in 186!)

I suppose that having -D cruft in there is a design choice; maybe forget about the last two improvements then.


Suggestion Backlog Slog, 3/13/2017

#13890 JSX.ElementType to define the type of <Tag /> expressions
#13847 Enforce generator functions to contain at least one yield
#12600 Discriminated unions of non-unit-type-discriminated unions
#12410 Allow operator + on string|number-constrained T ?
#13231 [Proposal] External Module Type
#2607 Generic decorators - could they receive some default type arguments?
#11774 Distinguish declaration file and js file when the option “Keep comments in TypeScript compiler output" is turned on
#14600 abstract static in classes
#14548 keyof t should be a subtype of string
#14267 Quoted vs unquoted property names
#13955 Narrowing of type parameters extending unions
#13904 Resetting narrowing after operations with side effects
#13778 Flag to include undefined in index signatures
#14094 ^ operator to create disjoint types

#13890 JSX.ElementType to define the type of <Tag /> expressions

e.g. type JSXElement<T> = T;
What does this framework look like?
Ryan to investigate

#13847 Enforce generator functions to contain at least one yield

What does this code actually do?

...

It is valid
Not true that all generators must yield

This is, sort of, how you would write an empty iterator

Suspicious to have a return but no yield return
Who is writing this and why?
:+1: cannot have return without yield return

put a yield return in an unreachable position if you really intended to do this

#12600 Discriminated unions of non-unit-type-discriminated unions

It'd be great
Let's do it
Adds complexity, especially in switch statements with complex labels
Assigning to Anders, tentative 2.4?

#12410 Allow operator + on string|number-constrained T ?

For T extends string, T + T should be string
For T extends number, T + T should be number

And for other arithmetic ops here as well

For T extends string | number, T + T is still an error
:+1:

#11774 Distinguish declaration file and js file when the option “Keep comments in TypeScript compiler output" is turned on

--preserveDeclarationComments ?
Could compile twice, or remove comments from a JS file with any number of tools
If you care about size, you're already minifying
:-1: Flag Soup

#14600 abstract static in classes

Sidebar discussion on substitutability of static side of classes
Are abstract methods callable?

... only indirectly?
wat
So it's useless?

AMF

#14548 keyof t should be a subtype of string

Real issue: A mapped type over a string-keyed thing should be assignable to the base type
:+1:

#13778 Flag to include undefined in index signatures

Would be enormously painful... why?
Would need special logic for for/of
What code to people intend to write?
Another flag? --allArraysAreDangerous
Allow overwriting / overriding of index signatures?
This just doesn't seem palatable
What happened when they hacked the lib.d.ts?
AMF

Out of time

#2607 Generic decorators - could they receive some default type arguments?
#13231 [Proposal] External Module Type
#13904 Resetting narrowing after operations with side effects
#13955 Narrowing of type parameters extending unions
#14094 ^ operator to create disjoint types
#14267 Quoted vs unquoted property names


Add generic quad airframes for 250, 450, and 650 size quadrotors and set PWM_OUT in rc.mc_defaults.

Describe problem solved by the proposed pull request
This PR adds a range of generic quadrotor airframes to advance PR #9849.
Additional context
See PR #9849 and PR #12506.
@dagar , would you let me know if you'd like to see anything different in this PR or if it is no longer of interest?  Thanks!

From a user perspective I like this idea in theory, but I think the question is if the tuning is actually going to be valid across all the other variables (battery size, motors, ESCs, props, etc) for the same frame.
With that in mind maybe some vaguely defined generic small, medium, large sizes as a rough starting point, but not get carried away?
@MaEtUgR @bresch what do you think?

I've reduced the number of generic quad airframes previously added down to 250, 450, and 650 and moved the contents of 4050_generic_250 to 4250_generic_quad_250 (sans those values that are defaults).  Last, I've moved set PWM_OUT 1234 to the rc.mc_default file, removed it from all of the other quadrotor airframe files that call rc.mc_defaults, and attended to 4013_bebop which was the single exception requiring set PWM_OUT none.
Let me know if you have any other suggestions I could attend to with this PR.  Thanks!

@dagar, @MaEtUgR , and @bresch , it fits in flash for the moment... ;)

@dagar, if we don't go ahead with this one, what do you think about closing out this PR and #9849?

Closing this; it can be revisited in the future.  Thanks for your reviews!


Create New Version with fixes

Fix on Copy commands
Fix on env var reading
Using lib to get env urls for every endpoint
Remove unused images from public folder
Remove env files not used
Changed copy command on docker file
Upgrade version on charts and project

Thanks for the changes @fabiodmota


Fixed extra R in variable name.

Description:
Fixed a typo in a variable name.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Hi @cyberplant,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Sorry, this patch won't work as you based it off the master branch. Please base it off the dev branch.

Roger!


Use single quotes for JSON string

This means that the double quotes in the JSON string don't need to be
escaped.
Before: AbortionError(code=..., details="{"created":...
After:  AbortionError(code=..., details='{"created":...

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.


vscode-reasonml doesn't recognize graphql_ppx_re

When using vscode-reasonml plugin it shows an merlin error saying Uninterpreted extension 'graphql' when using the ppx. Also type hinting for resulting module doesn't work. Tested on both bucklescript 5.2.1 and 7.0.1. However, mhalin/graphql_ppx seems to work fine.
To reproduce just create empty project with graphql_ppx and any graphql_schema.json and try to use it. Project builds just fine, but the plugin keeps complaining.

I have the same issue !
Good to fix it

I have the same issue too! Bump Up.

Thank you for reporting the issue. I'll investigate.

Note that vscode-reasonml is unmaintained. reason-language-server is the recommended replacement, but it doesn't seem to work well with this ppx either.

@baransu any news ?

@kamilkuz Could you provide more detailed information? I'm using reason-language-server on a daily basis and have no issues with graphql_ppx_re. Have you tried that extension?

@baransu Hey, thanks for quick response. I have used reason-language-server in the past, but after some update it stopped working for me (ctrl + click code navigation wouldn't work) so I changed it to vscode-reasonml which works fine. Since then I've tried few times with different versions but I can't get it to work on Linux.
Also, what version of bucklescript do you use? I think they recently changed something with PPXes in 6 or 7 so it also may be related.

I'm using bs-platform 7 and 5.2 across different projects.

This is also a problem with emacs, merlin (3.3.3), and graphql_ppx_re (0.4.6), bs-platform(7.0.1): Uninterpreted extension 'graphql'.
Looking into why now.

AFAK this works now


Implement Grafana metrics provided by DG in slack thread

https://neo4j.slack.com/archives/D8XNV94NT/p1538409560000200

Majority were implemented in 0.4.0 but there are some to go.

Closing this for now pending more specifics.  Discussing with Ship and others what's missing and what to add.


Release nginx ingress controller 0.9-beta.7

This change is

Coverage remained the same at 46.573% when pulling 6563330d2be68da7519015dbfdb7ae1643e421a1 on aledbf:fix-beta-6 into cc1a5605851c1fa9c25e6700e04fa35f36271528 on kubernetes:master.

What about #774. Is that good to merge?

@nicksardo I need to test that PR (and is a new feature)

@aledbf Imaged pushed.

@nicksardo thanks!
The published image works fine


Added Hello World in Spanish

What does the program do ?
prints ("Hello, World!") in Spanish
In what programming language it is written?
Python

This pull request do not contains files in specific folders. Please fix it and reopen


limit set username block usage frequency

via the set username block i was able to make a script to upload items in a list as different user for each item user data_storage  and then with little effort make it upload a low poly hd  image (which was slow but a good speed for being a scratch project )        which was clearly bigger than whatever the data limmit is  so in order to avoid that i would limit the times a ip adress can set username to 1 per secound / slower   if configurired

via the import button on lists you can import images to a list for clarification i was using turbowarp as IDE  and the image had about 2052 list items

Thank you for reporting this issue. I will see what I can do to mitigate this issue.

Trying to fix in #28


Update sbt-scoverage to 1.7.3

Updates org.scoverage:sbt-scoverage from 1.7.2 to 1.7.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

labels: sbt-plugin-update, semver-patch

Codecov Report

Merging #137 (e9abc68) into master (6c72e08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   87.13%   87.13%
=======================================
  Files          28       28
  Lines         832      832
  Branches       31       31
=======================================
  Hits          725      725
  Misses        107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c72e08...e9abc68. Read the comment docs.


Classify parser errors and use them

Currently, many of the errors in the parser use  simple_syntax_error( or skip_and_throw_syntax_err).
This causes almost all errors to generate invalid syntax error, making them difficult to understand.
This lets you know how invalid syntax is.
In addition, add doc comment.
Changes proposed in this PR:
Define specify error
Use following errors
Internal error(parser bug)
It is a high possibility of the parser bug if it coccus

parser_bug
feature_error
unexpected_none
failed_to_analyze_block
unexpected_token_error

Invalid/unintended syntax error
syntax error of parsing

invalid_to_convert
failed to convert from to to
invalid_token_error
expect: ...
but found: ...
invalid syntax
invalid_seq_elems_error
invalid sequential elements declaration
invalid_record_element_err
only var or def can be used in record
different record type element declarations
invalid_syntax_after_at_sign
invalid syntax after at-sign
invalid syntax
invalid_class_definition
invalid Class definition
invalid_class_attr_def
failed to define a Class attribute
invalid_data_pack_definition
expect: record
but found: ...
contents of data class are different
expect_keyword_error
keyword is not specified
invalid_non_default_parameter
:= should be added
non-default argument follows default argument
expect_dict_key
colon should be added
invalid declaration of dict type
invalid_dict_value
colon should be added
failed to declare Dict type
invalid_type_specified_error
cannot declare type specified by Tuple Type element
expect_type_specified
please specify the type
invalid type specification
unclosed_error
type is not closed with a bracket
expect_method_error
expect: method
but found: ...
class method definitions are needed
expect_accessor
expect accessor
invalid syntax
invalid_acc_chain
expect: method, NatLit, attr, array
no_indent_error
invalid the place indent
indent should be added

Minor adjustment

When next_expr()/line() are used, put log!()

@mtshiba

Could you please check the translation again when this PR is ready from the draft?
@C-BJ

OK

对不起，这个PR仍在进行中
我建议你先不要翻译它，因为我正在做破坏性的修改
能否请你在这份PR从草稿中准备好后再检查一下翻译
@C-BJ

oh, sorry. I read it wrong.

70% of the work has been done

Refine the error messages a bit more
to have the translation checked

The parser seems to erase class attributes.
C = Class {x = Int;}
C.
    x = 1 # no-linebreak

at 16:02:16 ❯ cargo r -- --mode parse test.er
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
     Running `target\debug\erg.exe --mode parse test.er`
C =
    ::Class:
        {::x =
    ::Int; }

Please ask me to review the translation again when it is finished @GreasySlug

Please ask me to review the translation again when it is finished @GreasySlug

I have finished writing the error messages, so if there are any translation errors or good translations in the Chinese ones please correct them, @C-BJ

Congrats & thank you so much!


Error when conditionally generating Tabs and TabPanels

If you use a ternary condition to return a null instead of a Tab react-tabs you get a "Uncaught TypeError: Cannot read property 'ref' of null".
Example

  <Tabs>
    { shouldShowTabA ? <Tab>Tab A</Tab> : null }
    { shouldShowTabB ? <Tab>Tab B</Tab> : null }
  </Tabs>
  { shouldShowTabA ? <TabPanel>{contentForA}</TabPanel> : null }
  { shouldShowTabB ? <TabPanel>{contentForB}</TabPanel> : null }

The assumption here is of course that at least one of the tabs will be displayed. I am not sure what will happen if you don't define any Tab elements.

I get a similar error when I try to add/remove tabs on the fly. Is there a way to do that?

This was indeed an error where we were trying to render null. It is working now, and I have added a new example that you can check out https://github.com/rackt/react-tabs/blob/master/examples/conditional/app.js

Thanks a lot! Any estimate on when you will publish a new version including this fix. This is off-topic, but it would be great if we could get the className prop evaluation for components as well. I seem to remember the disabling of the basic styles having been added already too.

Just released.

Awesome :+1:

This still breaks if you do something like

  <Tabs>
    { shouldShowTabA ? <Tab>Tab A</Tab> : null }
    { text && <Tab>Tab B</Tab>}
  </Tabs>
  { shouldShowTabA ? <TabPanel>{contentForA}</TabPanel> : null }
  { text && <TabPanel>{text}</TabPanel> }

IOW if the child is falsy, like an empty string, react-tabs still crashes. How about replacing https://github.com/reactjs/react-tabs/blob/master/src/components/Tabs.js#L186 with if (!child)?


Add timestamps to log output and configuration

I would like the debug output to show timestamps just like the tracing logger on my server.
Example output from the server:
Sep 29 02:03:01.290 DEBUG server: Tracing initialized.
Sep 29 02:03:01.302  INFO server::server: Starting Server
Sep 29 02:03:07.758 DEBUG server::server: Websocket connection request
Sep 29 02:03:07.763 DEBUG server::server::websocket::connections: Opening Websocket connection 0

Current output by the wasm module (in the browser console):
DEBUG src/client/mod.rs:33
Tracing initialized. package.js:406
DEBUG src/client/mod.rs:45
Host: localhost:8000 package.js:406
DEBUG src/client/mod.rs:73
Root update package.js:406
DEBUG src/client/websocket.rs:91
Root update package.js:406
DEBUG src/client/websocket.rs:94
WebSocket opened package.js:406
DEBUG src/client/chart.rs:60
Subscriber received message

Something like this would be desirable:
Sep 29 02:03:06.612 DEBUG src/client/mod.rs:33
Tracing initialized. package.js:406
...

It would probably be best to rely on the tracing crate for this. I did some research and looked into how the tracing_subscriber::fmt::Subscriber in my server prints the timestamp. And I have found SubscriberBuilder::with_timer which is implemented when the inner fmt::Layer contains a Format event as its fmt_event field. Then Format stores a Timer and uses it to write the time in its FormatEvent::format_event implementation.
So basically we should use a tracing_subscriber::fmt::Layer and initialize it with_timer? There is tracing_subscriber::fmt::time::time() to get a SystemTime timer. However that one might not work on wasm32. In that case we could use the tracing_subscriber::fmt::time::FormatTime trait to implement a timer that works on wasm32.

Since this crate does not already build on some common tracing Subscriber, it was simpler to just get the local time using chrono and formatting it into the log output like everything else. It might not be the most ambitious solution but the simplest.


Parquet reference files from git with simplecache

Hi,
I thought it might be a good idea to put the lazy Reference parquet files into git. Using this data directly from git is somehow not possible - e.g. our gitlab server also do not allow byte-range requests which are required at some point, I guess.
So I thought I could add a simplecache:: in the URL and ended up with a catalog which contains entries configured like this:
  pressure-level_analysis_daily:
    args:
      chunks: auto
      consolidated: false
      storage_options:
        lazy: true
        remote_protocol: http
      urlpath: reference::simplecache::{{CATALOG_DIR}}/disk/E5pl00_1D/combined.parq
    driver: zarr

I thought that this triggers downloads of required reference files first before opening it. For opening (getting metadata and coordinates) it seems to work. But for getting the real variable data, it seems like the caching is not fast enough or not syncronized correctly. Especially if I use it with dask, I get a lot of OS errors or incomplete parquet errors when accessing it the first time. When accessing it a third time, it usually works then - as if the caching has only finished then.
Is there a way to configure the process to wait for the caching before using the parquets? Or am I on the wrong track here?
Btw I also tried simplecache::reference:: but then all data that is used and referenced in the reference files is also cached. I only want to cache the reference parquets however...
Thanks and best,
Fabi

My guess is, that you have multiple threads on the worker (or multiple workers that see the same filesystem). Since simplecache really is simple, it assumes that if a file is present, it is the whole cached file. So if one thread starts to download and another tries to open the file before that finishes, it will read the partial file on disk. That would account for what you see. I haven't yet thought of how you can solve this...
It may be worth opening an issue on fsspec, whereby the cacher downloads to a different filename and moves to the final destination when done (which may result in some files downloading multiple times, but that's not too bad).


helm show values may use existing chart in cache directory

Currently, when provided with <repo>/<chart>, helm show values will download the chart file from remote repository and extract values from it. We may speed up this to use the cache stored in helm env HELM_REPOSITORY_CACHE, to use the already downloaded chart to extract values.yaml.
Although to some extent helm supports extracting from cached chart by directly providing the path: helm show values /path/to/cached/chart.tgz, supporting the feature described in this issue will make third-party tools like vscode-kubernetes to benefit from it when clicking Fetch values on the specific chart in the extension panel.

@gjenkins8 Seems https://github.com/helm/helm/pull/13213 already deals with this issue?


Fix sql error conversion

What changed?
Fix some sql error conversion previously forgotten in https://github.com/uber/cadence/pull/4178

Why?
refer to https://github.com/uber/cadence/pull/4178

How did you test it?
existing integration tests

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 88f04410-3dbb-4c28-afbb-6e8ea3f3b045

2 of 12 (16.67%)  changed or added relevant lines in 3 files are covered.
79 unchanged lines in 14 files lost coverage.
Overall coverage increased (+0.005%) to 59.889%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/persistence/sql/sqlExecutionManagerUtil.go
0
1
0.0%

common/persistence/sql/sqlExecutionManager.go
0
2
0.0%

common/persistence/sql/sqlHistoryManager.go
2
9
22.22%

Files with Coverage Reduction
New Missed Lines
%

common/types/shared.go
1
28.72%

host/signalworkflowTest.go
1
95.53%

service/history/queue/timer_queue_processor_base.go
1
79.5%

common/persistence/executionStore.go
2
73.86%

common/persistence/historyStore.go
2
66.41%

common/persistence/statsComputer.go
2
95.64%

host/archivalTest.go
2
97.81%

service/history/execution/mutable_state_builder.go
2
69.85%

service/history/task/transfer_active_task_executor.go
2
69.18%

common/types/mapper/thrift/shared.go
6
71.15%

Totals

Change from base Build 2d1bf20d-621b-488a-9f2c-40b14a5bb0e0:
0.005%

Covered Lines:
88139

Relevant Lines:
147170

💛  - Coveralls


Add support for fake llm provider in operator as well

Description
Adding fake_provider as one of supported provider, which will be helpful for load testing.
Type of change

[x] Refactor
[x] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Closes # https://issues.redhat.com/browse/OLS-687?filter=-1

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing
Tested and verified in local and CI tests went through.

/lgtm
@xrajesh @raptorsun seems straightforward to me, anything missing?

We need to update the bundle artifacts to keep CSV file ins sync @vishnuchalla . run make update-bundle-catalog and include the bundle artifacts.

/lgtm

/approve

/retest

/retest


Smokables update

About the PR

Changes Cigarette Machine catalog. Ports 3 cm13 cigarette packs. Ports zippo. Corrects matchbook visuals. Tarbacks tarbacks tarbacks. Organizes smokables. Ports matchbox. Ports cigar case. Tarback cigars tarback cigars tarback cigars.
Why / Balance

Inspired after smoking chunghwa
Technical details

Media

https://github.com/user-attachments/assets/3299cd54-f06b-40de-8c38-f3639cb05825

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

500 cigarettes.

Thanks for the PR! The ones with golden W's or other references to copyrighted material need to have those references removed

Question, just saying We-Ya is fine, right?

Question, just saying We-Ya is fine, right?

Yes


DataArray.from_dict: convert docstring code to doctest

What happened?
This test is passing in a str for dims:
https://github.com/pydata/xarray/blob/60754fdbc4ecd9eb3c0978e82635c6d43e8d485b/xarray/tests/test_dataarray.py#L3074-L3078
dims should be a tuple. I suspect the intent was to specify d = {"dims": ("t",)}  when the test was written.
This is small issue, but tests that call functions using the kind of data that would be used in "live" will improve quality of tests. Would be a shame for bug to affect users because tests use a str while in userspace a tuple is used.
What did you expect to happen?
code to be  d = {"dims": ("t",)}
Minimal Complete Verifiable Example
No response
Relevant log output
No response
Anything else we need to know?
I'm happy to make a PR to fix this
Environment
NA

This tests checks if the appropriate error is raised if the passed dict misses the key "data". So it does IMHO not really matter what is passed as dims.

this does indeed look like a typo (even though as @mathause says that value will not be checked because the absence of data is checked first) but in any case it is valid to pass a str: dims="t", dims=["t"] and dims=("t",) mean the same thing to the DataArray constructor for 1D data. Maybe we should just remove the parens to make this clear? I would have hoped that black takes care of something like that...
We also have the same issue in the docstring of DataArray.from_dict, which by the way would really benefit from converting the code block to a doctest-style example (it will fail right now).

I will make a PR to remove the paren to make the intent clearer :+1:
Regarding black: worth also considering something like this to automatically highlight issues like this during PR :)

I updated the title of the issue to reflect the new state after #6139.

I have done an update to the docstring https://github.com/pydata/xarray/pull/6140
But note it is a minimal change rather than converting to doctest-style because I don't actually download or install xarray locally - I'm a bot that runs on AWS lambda to do static analysis checks on codebases for bugs. This repo was one of the 666 repos we run against when validating testing our new checkers.
As I do not have xarray setup locally I dont want to push larger code changes that have not been manually ran before I push, as there would be no confidence in the quality of the change :)


[Experimental] Add cardinality argument to GroupBy.aggregate

Adds an optional cardinality argument to GroupBy.aggregate:
"""
cardinality : float or "infer", optional
    Approximate ratio of aggregated data size with respect to the
    initial data size. If specified, this ratio will be used to override
    the defaults for ``split_every``, ``split_out``, and ``shuffle``.
    If ``"infer"`` is specified, the first non-empty partition will be
    used to estimate the global cardinality ratio.
"""

This PR is related to the discussion in #9406 (on setting good defaults automatically). Note that the specific heuristics used to set split_every and split_out in this PR may need to be tweaked - More benchmarking is necessary.

[ ] Tests added / passed
[ ] Passes pre-commit run --all-files

Closing this for now.