Limit the number of active FQDNs beyond the TTL to --tofqdns-endpoint-max-ip-per-hostname

Commit f6ce522d55d5 ("FQDN: Added garbage collector functions.")
introduced a per-host limit on the number of IPs to be associated in the
DNS cache, but at the time we did not support keeping FQDN entries alive
beyond DNS TTL ("zombie entries"). These were later added in commit
f6293725867c ("fqdn: Add and use DNSZombieMappings in Endpoint"), but at
that time no such per-host limit was imposed on these zombie entries.
Commit 5923dafd88be ("fqdn: keep IPs alive if their name is alive")
later adjusted the zombie garbage collection to allow zombies to stay
alive as long as any IP that shares the same FQDN is marked as alive.
Unfortunately, this lead to situations where a very high number of DNS
cache entries remain in the cache beyond the DNS TTL, simply because one
IP for the given name continues to be used.
In the case of something like Amazon S3, where DNS TTLs are known to be
low, and IP recycling high, if an app constantly made requests via
ToFQDNs policy towards names hosted by this service, this could lead to
thousands of stale FQDN mappings accumulating in the cache. For each of
these mappings, Cilium would allocate corresponding identities, and when
this is combined with a permissive pod policy, this could lead to
policymaps becoming full, and error messages in the logs like:
msg="Failed to add PolicyMap key" ... error="Unable to update element for map with file descriptor 67: argument list too long"

This could also prevent new pods from being scheduled on nodes, as
Cilium would be unable to implement the full requested policy for the
new endpoints.
In order to mitigate this situation, extend the per-host limit
configuration to apply separately also to zombie entries. This allows up
to 'ToFQDNsMaxIPsPerHost' FQDN entries that are alive (ie below DNS TTL)
in addition to a further 'ToFQDNsMaxIPsPerHost' zombie entries
corresponding to connections which remain alive beyond the DNS TTL.
Fixes: 5923dafd88be ("fqdn: keep IPs alive if their name is alive")
Fixes: #13914
Improve garbage collection for resources allocated by ToFQDNs policy for services which rotate IP addresses frequently such as Amazon S3

/test

Failures:

ConformanceAKS: Failed with #19472, seems like the policy was not effective before running the test. Same test should be running in the other CI 3.0 jobs and there's nothing AKS-specific here, so it seems like it's a flake.
k8s-1.21-kernel-5.4:

Suite-k8s-1.21.K8sPolicyTestExtended Validate toEntities KubeAPIServer Allows connection to KubeAPIServer: Another variation on https://github.com/cilium/cilium/issues/16928 , level=warning msg="JoinEP: Failed to load program" containerID= datapathPolicyRevision=0 desiredPolicyRevision=1 endpointID=2563 error="Failed to replace Qdisc for lxcb18c1baa780c: Link not found" file-path=2563_next/bpf_lxc.o identity=44748 ipv4= ipv6= k8sPodName=/ subsys=datapath-loader veth=lxcb18c1baa780c.
Suite-k8s-1.21.K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master hit #18873

runtime:

Suite-runtime.RuntimePrivilegedUnitTests Run Tests: Hit https://github.com/cilium/cilium/issues/18958
Suite-runtime.RuntimePolicies Tests EntityNone as a deny-all and (Suite-runtime.RuntimePolicies TestsEgressToHost Tests egress with CIDR+L4 policy to external https service)[https://jenkins.cilium.io/job/Cilium-PR-Runtime-net-next/1910/testReport/junit/(root)/Suite-runtime/RuntimePolicies_TestsEgressToHost_Tests_egress_with_CIDR_L4_policy_to_external_https_service/]: Could not connect to <IP_ADDRESS>. Everything in the sysdump looks fine, could the VM have lost internet connectivity or something? No clear link to the changes being made in this PR given that this is specific to FQDNs policy, and there is no such policy in these failures.

/ci-aks

/test-1.21-5.4

/test-runtime

RuntimePrivileged test run timed out again. I'm running them locally to see if I can identify any reason for this.

I've opened https://github.com/cilium/cilium/pull/19487 to mitigate the test timeout issue since this PR has hit it twice in a row now.

PR https://github.com/cilium/cilium/pull/19487 is now merged, rebasing to pick up that change and re-running test-runtime tests. All other tests had passed.

/test

Runtime test now passing. Rest failed due to breakage on master, should now be addressed by #19523. Rebasing & rerunning tests.

/test

k8s-1.21-kernel-5.4 hit #16852, and also non-required jobs ConformanceAKS and External workloads failed. The latter two had trouble with steps that do not validate Cilium behaviour, so I don't see any way that this PR interacts with them. There is also ongoing discussion about addressing the failures for those jobs so that we can again mark them as required.
No CI blockers, reviews are in, time to :ship: .


JS injection can't access global variables / objects

Hello folks,
I am using the most recent version of nativefier:
> nativefier --version 45.0.0

When I inject a JS file like this one:
(function () {

    function disableTracking() {
        odoo.session_info.user_context.tracking_disable = true;
    };

   disableTracking();

})();

and build the app with the following command:
nativefier --name "<APP_NAME>" --conceal --single-instance --inject test.js --lang en <APP_URL> .local/share/nativefier-apps

The console of the app tells me, that the global variable odoo is not defined:
Error encoutered injecting JS files ReferenceError: odoo is not defined
    at disableTracking (VM128 inject-c5c0b1.js:4)
    at VM128 inject-c5c0b1.js:7
    at Object.<anonymous> (VM128 inject-c5c0b1.js:9)
    at Object.<anonymous> (VM128 inject-c5c0b1.js:10)
    at Module._compile (VM43 loader.js:1078)
    at Object.Module._extensions..js (VM43 loader.js:1108)
    at Module.load (VM43 loader.js:935)
    at Module._load (VM43 loader.js:776)
    at Function.f._load (VM70 asar_bundle.js:5)
    at Function.o._load (VM75 renderer_init.js:33)

From the documentation I expect that this variable should be available:

Note about JS injection: injected JS is loaded after DOMContentLoaded, so you can assume the DOM is complete & available.

I also tried various manual checkings in the JS file for a loaded DOM, all with the same result. The variable is available in the applications console tough:
> odoo
{csrf_token: "f630ede6b4ccdd28d4b51879292f2e06be7bdb71o", session_info: {…}, testing: false, debug: true, remaining_jobs: Array(0), …}
csrf_token: "f630ede6b4ccdd28d4b51879292f2e06be7bdb71o"
debug: true
define: ƒ ()
log: ƒ ()
process_jobs: ƒ (jobs,services)
remaining_jobs: []
session_info: {session_id: "145d5d94b26f8426bc57829a4ac44bed5e0f31f9", uid: 44, is_system: true, is_superuser: false, user_context: {…}, …}
testing: false
__DEBUG__: {didLogInfo: {…}, get_dependencies: ƒ, get_dependents: ƒ, get_waited_jobs: ƒ, get_missing_jobs: ƒ, …}
_modules: (126) ["base", "web", "web_editor", "web_planner", "bus", "web_tour", "mail", "portal", "website", "product", "account", "payment", "website_payment", "sales_team", "sale", "account_invoicing", "sale_management", "wk_appointment", "website_appointment", "website_seo_pro", "calendar", "contacts", "crm", "project", "barcodes", "stock", "hr", "hr_timesheet", "hr_holidays", "website_partner", "website_form", "website_crm", "hr_attendance", "document", "hr_recruitment", "hr_expense", "account_bank_statement_import", "account_bank_statement_import_ofx", "account_cutoff_base", "date_range", "report_xlsx", "account_financial_report", "account_lock_date_update", "account_reversal", "archeti_external_layout_clean", "archeti_website_appointment", "attachment_large_object", "attachment_preview", "auth_jwt", "auth_signup", "base_import", "board", "contract", "crm_timesheet", "currency_rate_update", "customer_outstanding_statement", "knowledge", "document_page", "document_page_approval", "document_page_reference", "document_url", "email_template_qweb", "git_webhooks", "iap", "knowsystem", "knowsystem_multilang", "l10n_ca", "mail_activity_creator", "mail_inline_css", "mail_outbound_static", "mail_tracking", "web_kanban_gauge", "mass_mailing", "mail_tracking_mass_mailing", "mass_editing", "meeting_ida", "web_widget_color", "mis_builder", "survey", "oh_appraisal", "partner_sector", "payment_paypal", "payment_transfer", "portal_task_kanban", "sale_timesheet", "project_report_task_overview", "project_stage_state", "project_task_add_very_high", "project_task_default_stage", "project_task_dependency", "web_timeline", "project_timeline", "project_timeline_hr_timesheet", "project_timeline_task_dependency", "rating", "sale_stock", "web_ir_actions_act_multi", "web_ir_actions_act_view_reload", "timesheet_force_on_change_state", "web_diagram", …]
__proto__: Object

So what am I doing wrong? Is something special needed to access global variables?
Any help would be very much appreciated.
Thanks in advance!

It seems to be fixed with https://github.com/nativefier/nativefier/commit/ca7d25f4327d353d940cb51b0e419d15df8b655b#diff-60366959d6497ad3a50fdc7b32dd59c76eb35ab6c0ea18f0e700b15c03b67b12R151 in v45.0.6.

It seems to be fixed with ca7d25f#diff-60366959d6497ad3a50fdc7b32dd59c76eb35ab6c0ea18f0e700b15c03b67b12R151 in v45.0.6.

@insolite wheee! Thanks for the precise report. With that, closing.


Idea: A "ruby only" core version of this library

Hello again! Thanks a ton for this library (again). I've got another bit of a question. Would you consider porting over this codebase to not rely on enumerable-statistics?
Here's my context:

I maintain derailed_benchmarks and added unicode_plot support for histograms
I needed some feature that enumerable-statistics cannot give me, so I made mini_histogram
I want derailed_benchmarks to support Ruby 2.2+, but because it relies on this library and this library relies on enumerable-statistics and that's locked to 2.4+ I cannot.

Example Proposal
I took the liberty of forking this lib to see what removing enumerable-statistics would look like. This ended up being the commit:
https://github.com/zombocom/mini_unicode_plot/commit/18c0242f653a856374a6b6cacbf90a2db6027387
Essentially we can get rid of this dependency by only removing two plot types (box plot and histogram plot). Before I fork and try to maintain my own plotting library that duplicates all this functionality. I wanted to ask if you had any interest in porting over unicode_plot to have some kind of "ruby only" core and then keep this library to have extensions with enumerable-statistics? I don't want to duplicate your efforts if possible.
The other change I would like to make is to increase backward compatibility to Ruby 2.2. This would require a few cases of not using &. syntax and porting over the tests to circle-ci as GitHub-actions do not have a Ruby version that goes back that far.
What do you think?

Supporting Ruby 2.2 is good to me. Could you make a pull-request that consists of only changes related to increase backward compatibility?
Depending on the different libraries for single feature is not good. I think what we should do is not making mini_histogram, but letting enumerable-statistics support platforms other than CRuby.  I will prioritize the work to do that, so please give me some time.

Supporting Ruby 2.2 is good to me. Could you make a pull-request that consists of only changes related to increase backward compatibility?

The only thing I needed to do was move away from using &. calls. Here's an example https://github.com/zombocom/mini_histogram/commit/e17782d7f11976073dd47e8cc03d38ae90ad5ec3. But enumerable-statistics is still locked ro Ruby 2.4+ which is the bigger issue preventing supporting older versions. I do not know what difficulties enumerable-statistics face to support older Rubies.

@schneems OK. I’ll try to let enumerable-statistics support Ruby 2.2, too.

@schneems OK. I’ll try to let enumerable-statistics support Ruby 2.2, too.

That is exciting! It sounds like a large project. Thank you! For running on CI, Puma also supports 2.2. Here's their Github actions https://github.com/puma/puma/blob/master/.github/workflows/puma.yml#L28-L31
I think I can close this proposal as "not accepted" but it sounds like you have action items generated from this discussion.


feat(analytics): add monthly active users in highlights

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Marking as draft as some more changes need to be done which will require more testing. Will mark as ready for review once those changes are done.


added bcmath and soap

It took a little time but as mentioned in #15 I added bcmath and soap.

Hi @Nemo64 ! Thank you so much for your contribution! I'll take a look at your PR in a few hours to get it merged as soon as possible.

Travis build has failed due to #13. I'm retrying manually the jobs that did fail or error.


Incorrect parsing of anchor links

Describe the bug
When processing a list of tasks containing anchor links, Time Ruler identifies part of the link as a tag.
If you mark a task as completed, its description is distorted. A new tag appears and the link is broken.
An example can be seen in the attached file and on the screenshot.
To Reproduce
Steps to reproduce the behavior:

Create a list of tasks with a anchor links. (Time Ruler does not show the description correctly)
Mark the task as completed.

Expected behavior
The system must correctly identify references as described in the documentation.
https://help.obsidian.md/Linking+notes+and+files/Internal+links#Link+to+a+heading+in+a+note
Screenshots

Test file
Test.md
Obsidian Version:

Obsidian Desktop 1.5.11
Time Ruler 2.2.0

Additional context
I corrected the value of the regular expression TAG_SEARCH = /#[\p{Letter}\/\d_-]+/gu to TAG_SEARCH = /(?<!((\[[^(\])]*)|(\[[^\]]+\]\([^\)]*)))#[\p{Letter}\/\d_-]+/gu and the representation of the task in Time Ruler became correct.
After the task execution the anchor link remained correct, but in the task description there was a new tag that should not be there. (#Description tag on the screenshot)

Maybe I'm missing something in the parser code...

Thanks for pointing this out—I'll check. To be honest there's a bug in Dataview that recognizes anchor links as tags which complicates the matter. I'll fix in the upcoming release!


up/down keys not working in ui settings

Version: 1.34.0 (user setup)
Commit: a622c65b2c713c890fcf4fbf07cf34049d5fe758
Date: 2019-05-15T21:59:53.881Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT ia32 10.0.10586

Does this issue occur when all extensions are disabled?: No

I need you to explain exactly what the issue is, please be very specific.

I need you to explain exactly what the issue is, please be very specific.

thanks for your reply.
when we are in the ui settings we must use scroll to go to up/down settings. it is very hard when there are a lot of settings. currently is not possible to move the page slowly with up/down key in the ui settings page. currently the up/down key don't do anything in the settings ui. and i should use tab key for this and it isnt good choose for me

Ok, yes I am tracking that here: https://github.com/microsoft/vscode/issues/66237


Send email report after creating the webpages

because I'm sick of getting 404 when I click on the email links too soon

https://osg-sw-submit.chtc.wisc.edu/tests/20211115-1137/packages.html


fixing ref bug for flyTo and thumbnail

This branched out from react-leaflet-v3-test to fix ref bug for flyTo and thumbnail. Also made a story to test them at web-components:
In the story, flyTo delay is intentionally set to be a bit long (2000 ms) to better check out if it is working fine. A screenshot to show thumbnail is as follows. Note that map and thumbnail sizes are not set to be actual ones as it is a demo purpose and large thumbnail takes too much time to decode.

Just for an information.
TL;DR (@dmfalke? 😄)
In react-leaflet v2 we have used useRef() hook to access map for flyTo, thumbnail, etc. However, in v3, ref is not supported so a new method is required. Basically there are two ways to replace useRef().
a) use MapContainer's whenCreated prop, e.g.,
const [mapRef, setMapRef] = useState(null);
...
<MapContainer
  ...
  whenCreated={setMapRef}
  ...
/>

In this manner, mapRef becomes map instance so we can use it for accessing map. thumbnail fix in this PR utilizes this approach.  A caution is that some users commented that the use of whenCreated may not be consistent, though I did not notice it in this case.
b) use child component and a new useMap() hook introduced in v3, e.g.,
function MapVEu(props) {
  ...
  return (
    <MapContainer>
      <PerformFlyToMarkers>
    </MapContainer>
  );
}

function PerformFlyToMarkers(props) {
   const mapRef = useMap();       // now map can be accessed via mapRef
   mapRef.fitbounds(bounds)       // fitbounds()
   ...
   return null;
}

It works well as I used this approach for flyTo functionality. Some notes are: a) useMap() cannot be used in the component that returns  (in this example, MapVEu component). Thus, a child component is needed to utilize useMap() like above example code; b) if forwardRef() is necessary, e.g., at , it means that forwardRef should be used twice in this case, like forwardRef(MapContainer) and forwardRef(PerformFlyToMarkers).

Thanks for the details, @moontrip. Either approach seems fine to me, assuming whenCreated has consistent behavior.

Thanks for the details, @moontrip. Either approach seems fine to me, assuming whenCreated has consistent behavior.

@dmfalke As I mentioned earlier, it seems to fine for our application. I saw a user's comment concerning inconsistent behavior at react-leaflet when using whenCreated, but it might have been revised since then as v3.2.5 (the latest v3) dealt with something regarding whenCreated - don't know details though, just looked at change log.

Unrelated to the fly-to functionality - I am seeing new compiler warnings when building/launching storybook
DA/web-components/node_modules/comma-separated-tokens/index.js[BABEL]
Note: The code generator has deoptimised the styling of /home/maccallr/Desktop/EDA/web-components/node_modules/mapbox-gl/dist/mapbox-gl-unminified.js as it exceeds the max of 500KB.

This seems to happen for many different modules

I couldn't find an obvious issue with BoundsDriftMarker - the error message suggested that in the code there was something like
  return <Foo ...> </Foo>;

where Foo is undefined.  Could possibly be a problem with npm-pack-here, but everything else works.  It's a mystery.  @dmfalke or @jtlong3rd would you be able to test/diagnose this please?  (EDA main branch with npm-pack-here pulling in  web-components/react-leaflet-v3-ref  then try to make a map viz in SCORE Seasonal...)

This looks good and the story works for me too.
I tried npm-pack-here in the latest EDA and got a runtime error when adding a variable to the map visualization.
Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports. Check the render method of `BoundsDriftMarker`.

Has the interface to BoundsDriftMarker changed? I can't see in this particular PR. So I'll approve this PR and then look at the main draft PR. All the other visualizations seem to work fine!

@bobular Thank you for your review and tests! 👍 Certainly there was some changes on BoundsDriftMarker component as noted in the parent PR's comment #314, react-leaflet-drift-marker: replacing leaflet-drift-marker.
Off the top of my head... When I was implementing v3, I have removed the following:
const FixedDriftMarker = DriftMarker as React.ComponentClass<
  ExtractProps<typeof DriftMarker> & LeafletMarkerProps
>;

and used ReactLeafletDriftMarker directly (from react-leaflet-drift-marker package):
i.e., instead of <FixedDriftMarker>, used <ReactLeafletDriftMarker>
Since the relevant story file (AnimatedMarkers.stories.tsx) seemed to work fine, I thought it would be alright without that. So, just in case please check if that is the case.
p.s. Any specific configuration you did with npm-pack-here? I couldn't make it before with a compiling error in my case: kind of can't find MapContainer error which the MapContainer replaces Map component in v3. So it means that the compiler tried to to find that component via v2, not v3.

Hmm, so node_modules/react-leaflet/package.json should not show 2.8.0 as the version, right?
I didn't do anything special with npm-pack-here, just
npm-pack-here --target ../web-components
yarn add -D file:local_modules/@veupathdb/components
yarn install --check-files

I'm seeing
web-eda/node_modules/<EMAIL_ADDRESS>   "react-leaflet": "^2.7.0",

which doesn't look good. What's @veupathdb/eda? I'll try removing node_modules and start again

@bobular thank you for your information: basically that is what I did and failed to compile :(
I remember that Dave made a comment on that stuff showing new and older versions at the same time, concerning npm-pack-here at our dev call.
Regarding What's @veupathdb/eda? Please see Jamie's great explanation https://github.com/VEuPathDB/web-eda/pull/1117#issuecomment-1116436946

Thanks I will read that. In the meantime...
yarn why v1.22.11
[1/4] Why do we have the module "react-leaflet"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "@veupathdb#components" depends on it
   - Hoisted from "@veupathdb#components#react-leaflet"
info Disk size without dependencies: "6.98MB"
info Disk size with unique dependencies: "7.2MB"
info Disk size with transitive dependencies: "7.2MB"
info Number of shared dependencies: 1
=> Found "<EMAIL_ADDRESS>info Reasons this module exists
   - "@veupathdb#eda#@veupathdb#components" depends on it
   - Hoisted from "@veupathdb#eda#@veupathdb#components#react-leaflet"

So... @veupathdb/eda is the package exported by the web-eda repo.
To build the dev react server from web-eda, we shouldn't need to import this module.
But... we do import @veupathdb/web-common as a devDependency
After some hunting, @veupathdb/web-common is the npm module exported from https://github.com/VEuPathDB/EbrcWebsiteCommon/tree/master/Client, which has peer and devDependencies for @veupathdb/eda
So I guess that's the circular dependency that @jtlong3rd mentioned in the link from DK, because @veupathdb/eda has a dev dependency for @veupathdb/components
I have a feeling it would work if I checked out web-common, and npm-pack-here'ed web-components into it, and then npm-pack-here'ed web-common into web-eda... Let's see

Damn, that doesn't work
npm-pack-here -t ../../web-components
EbrcWebsiteCommon/Client$ yarn add -D file:local_modules/@veupathdb/components
error An unexpected error occurred: "expected hoisted manifest for \"@veupathdb/components#react-leaflet\"".

out of my depth now!

I just saw that web-eda has a devDependency for @veupathdb/eda which is ITSELF.
The reason for this is that web-common's
https://github.com/VEuPathDB/EbrcWebsiteCommon/blob/master/Client/src/WorkspaceRouter.tsx
does this:
export { WorkspaceRouter as default } from '@veupathdb/eda/lib/workspace/WorkspaceRouter';

And not sure this is my area of expertise ;-)

And not sure this is my area of expertise ;-)

But I soldiered on anyway. I think I found a way to get around the eda->eda circular dependency with npm-pack-here.
But then I got into some parsing issues. @moontrip, did you say the new react-leaflet was a using a different version of ES or something?

@bobular As far as I know, the v3 targets ES2019. I did not experience a specific issue at web-components for compiling, except one case, nullish coalescing operator issue - had to change some configurations that are listed at https://github.com/VEuPathDB/web-components/pull/314#issue-1160644278.
Not quite sure what the parsing issues you meant. Anyway sounds great if you found the way 👍

Yes @moontrip it was a nullish coalescing operator thing.
I think see how to fix it on the EDA side.
Now I will try to repeat (and document) how to test this PR in EDA!

I'm looking into the general issues with testing this. Specifically: circular dependency and newer syntax.

I was able to get things working by doing to following:

I tried to test Dave's change on the package.json (web-eda) with the npm-pack-here yesterday. It worked fine without specific error I noticed. By doing this so, only react-leaflet v3 is shown in the web-eda so my issue not to retrieve a component from v3 was resolved.
From my tests, mapViz mostly worked fine for me and the ref stuffs such as flyTo and thumbnail seemed to function correctly  as well.

Thanks to Dave's magic yarn, I've done some quick testing.
For me, the background tile selection is not being screenshotted or remembered in the saved analysis.

Thanks to Dave's magic yarn, I've done some quick testing.
For me, a non-standard background tile selection (e.g. satellite) is not being screenshotted or remembered in the saved analysis.

@bobular as far as I know it is not a parameter we keep tracking of, like mouse mode (mouse too) that has a ticket. If you want, I can also try to address it while I am working on the mouse mode stuff https://github.com/VEuPathDB/web-eda/issues/971

@bobular I have extensively tested the case you commented, tile layer thumbnail stuff. Actually what I found is two-fold: first, there exists a bug on the current map (react-leaflet v2) that some tile layers are not working well with the thumbnail/screenshotter . Will figure it out the reason why; b) for v3 (current PR), yes I could confirm that it is somehow not working correctly with tile layers except the default one. Will also look into this.
Thank you for finding the bug which also led to identifying other issue 👍

@bobular I have extensively tested the case you commented, tile layer thumbnail stuff. Actually what I found is two-fold: first, there exists a bug on the current map (react-leaflet v2) that some tile layers are not working well with the thumbnail/screenshotter . Will figure it out the reason why; b) for v3 (current PR), yes I could confirm that it is somehow not working correctly with tile layers except the default one. Will also look into this.
Thank you for finding the bug which also led to identifying other issue +1

Is it possible the thumbnail is generated before the layer has been fully rendered?

@dmfalke Thank you for your comment. FYI, I think that I fixed the issue for the current mapViz that use v2 (not v3). https://github.com/VEuPathDB/web-components/pull/355
I did not look into v3 case yet as I am off today: will check it out next Monday

@bobular bugs are fixed: a) onViewportChange is removed from v3 so it did not work correctly with mapViz. I have added two cases as map events to deal with viewport change, zoomend and moveend. It seems to work fine for me; b) now thumbnail seems to work correctly. Main issue, among others, was that change of baselayer was not recognized, thus it is now configured as another map event.
It would be great if you can test them, when you are available 👍

I have updated this branch with the latest changes at web-components, resolve conflicts, and fix bugs. All stories are working fine from my tests. Noticed some issues with MapViz but they are fixed except one case.
The only issue I could not resolve is that thumbnail is not made for the initial map (after creating new MapViz for the first time): actually it worked fine with screen shoter but with the domToImage it didn't work. If changing zoom, layer, and panning with the initial empty map, then thunbmail is made correctly. Looks like the map/map ref is not ready when creating thumbnail: honestly I have no idea how to deal with this. @dmfalke and/or @jtlong3rd?

The only issue I could not resolve is that thumbnail is not made for the initial map (after creating new MapViz for the first time): actually it worked fine with screen shoter but with the domToImage it didn't work. If changing zoom, layer, and panning with the initial empty map, then thunbmail is made correctly. Looks like the map/map ref is not ready when creating thumbnail: honestly I have no idea how to deal with this. @dmfalke and/or @jtlong3rd?

@moontrip we have a similar situation with PlotlyPlot where the plot might not be ready when we attempt to make the initial screenshot. You can check https://github.com/VEuPathDB/web-components/blob/640d8f7cf3b2101b49d01a39c36cdfa1def80406/src/plots/PlotlyPlot.tsx for how this is handled. Specifically, see how sharedPlotCreation is used. I think a similar approach will work for MapVEuMap.

The only issue I could not resolve is that thumbnail is not made for the initial map (after creating new MapViz for the first time): actually it worked fine with screen shoter but with the domToImage it didn't work. If changing zoom, layer, and panning with the initial empty map, then thunbmail is made correctly. Looks like the map/map ref is not ready when creating thumbnail: honestly I have no idea how to deal with this. @dmfalke and/or @jtlong3rd?

@moontrip we have a similar situation with PlotlyPlot where the plot might not be ready when we attempt to make the initial screenshot. You can check https://github.com/VEuPathDB/web-components/blob/640d8f7cf3b2101b49d01a39c36cdfa1def80406/src/plots/PlotlyPlot.tsx for how this is handled. Specifically, see how sharedPlotCreation is used. I think a similar approach will work for MapVEuMap.

@dmfalke Thank you for your suggestion. Actually I thought of that too but not quite sure if it would work for map case. I will check it out 👍

I'm happy to take a whack. Just let me know.

I'm happy to take a whack. Just let me know.

Thanks @dmfalke! 👍 It would be great if you can take a look at it. For your convenience, I made a draft PR implementing sharedPlotCreation used in PlotlyPlot component, but did not work. Please see my comment in there too, which may be helpful for you.
https://github.com/VEuPathDB/web-components/pull/379

updated this branch with the latest changes, e.g., mouse tool work, etc.

As noted in https://github.com/VEuPathDB/web-components/pull/379, @dmfalke resolved the issue of initial thumbnail so the PR is merged into this PR for consistency

updated this react-leaflet-v3: resolved conflicts, fixed bugs, etc

Hi @moontrip - I tried to do some testing in web-eda with relative-deps.  Is there a corresponding web-eda branch or PR? I can't find one.
The only way I can get the EDA to run is if I manually install the correct versions as (temporary) direct dependencies of web-eda after installing ../web-components with relative-deps.
  yarn add<EMAIL_ADDRESS><EMAIL_ADDRESS>
Before that I tried various combinations of yarn cache clean and nuking node-modules with no luck.
Whatever I did, yarn why react-leaflet always told me it was hoisting v2.8.0 from @veupathdb#components#react-leaflet
EVEN THOUGH<EMAIL_ADDRESS>was asking for 3.2.5 in its dependencies.
As far as I can tell, this is a simple one-step transitive dependency. I can't see anything else asking for<EMAIL_ADDRESS>unless it's the relic of leaflet-drift-marker which seems to be hanging around (with react-leaflet 3 we use a different npm: react-leaflet-drift-marker. relative-deps seems to be failing (at least for me)
I even started wondering if our version of yarn is too old. It seems to be an old-ish version of "yarn classic". Migration to yarn 2.x or 3.x seems non-trivial. Didn't look to far into that. @dmfalke
I guess it will work fine once we publish to npm.
Also on the plus side I've done a fair amount of testing (full screen, regular viz, thumbnails) and everything seems to be working great!
$ yarn why react-leaflet
yarn why v1.22.11
[1/4] Why do we have the module "react-leaflet"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "@veupathdb#components" depends on it
   - Hoisted from "@veupathdb#components#react-leaflet"
info Disk size without dependencies: "1.84MB"
info Disk size with unique dependencies: "2.82MB"
info Disk size with transitive dependencies: "2.98MB"
info Number of shared dependencies: 8

@bobular thank you for your great interests, tests, etc.! 👍
Actually there is no specific web-eda PR because there is no change at web-eda part for react-leaflet-v3. I have used npm-pack-here and it worked just fine without installing any libraries at web-eda side. And yarn why also detecst react-leaflet-v3 correctly. If I remember correctly, there has been a circular dependency issue but it was resolved before by either Dave or Jamie.
Can you please try npm-pack-here instead and see if it work? I will also check if there is a specific setting I have missed.

@bobular so for test purpose, I just tried to redo all steps at web-eda with npm-pack-here, as listed below

removed node_modules and local_modules directories

git stash (remove anything I had at web-eda)

yarn cache clean

git pull and yarn install
(at this stage, yarn why react-leaflet shows v2.8.0 only)

yarn build-npm-modules: at a web-components directory where you have react-leaflet-v3-ref branch (please update your local branch, git pull origin react-leaflet-v3-ref)

npm-pack-here --target /home/dk/github/react-leaflet-v3-test/web-components (this directory path varies per one's env)

yarn add file:local_modules/@veupathdb/components

yarn install --check-files

After these steps, yarn why react-leaflet shows v3.2.5 only. Personally I prefer npm-pack-here as I am often confused with relative-deps behavior.
Hope this would be helpful for you.

Thanks @moontrip - those steps work for me perfectly.
I wonder if yarn install --check-files is the secret sauce for relative-deps? Anyway, I'm not going to try that now.
Just want to repeat that everything seems to be working, so let's merge soon after the b60 release!

@bobular glad it works for you too! :Thank you for your extensive tests 👍

I wonder if yarn install --check-files is the secret sauce for relative-deps? Anyway, I'm not going to try that now.

Unfortunately, that won't work. Jamie made a fork and attempted to add that capability to relatative-deps, but it didn't work. This is part of the motivation to move to a monorepo. It will allow us to centralize dependency version management.

This PR is closed as https://github.com/VEuPathDB/web-components/pull/445 is merged


deps: upgrading pubsub dependnecy in the parent pom.xml

Temporary fix of misbehaving Linkage Monitor (https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1958) by upgrading the pubsub library versions.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #570 ☕

"ci / dependencies (8)" failed:
2021-02-25 21:34:59 Diff found. See below:
2021-02-25 21:34:59 You can also check .diff.txt file located in ./google-cloud-asset.
0a1
> [INFO]    com.google.android:annotations:jar:<IP_ADDRESS>:runtime
19a21
> [INFO]    com.google.code.gson:gson:jar:2.8.6:compile
26a29
> [INFO]    com.google.protobuf:protobuf-java-util:jar:3.15.0:runtime
27a31,32
> [INFO]    commons-codec:commons-codec:jar:1.15:compile
> [INFO]    commons-logging:commons-logging:jar:1.2:compile
39a45
> [INFO]    io.perfmark:perfmark-api:jar:0.23.0:runtime

9fa7243 : Linkage Monitor succeeded but "dependencies" (above) and "Kokoro - Test Samples" (below) failed.
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] error reading /root/.m2/repository/com/google/guava/guava/30.1-android/guava-30.1-android.jar; zip file is empty
[ERROR] error reading /root/.m2/repository/com/google/guava/guava/30.1-android/guava-30.1-android.jar; zip file is empty
[ERROR] /tmpfs/src/github/java-asset/proto-google-cloud-asset-v1/src/main/java/com/google/cloud/asset/v1/FeedName.java:[23,30] package com.google.common.base does not exist
[ERROR] /tmpfs/src/github/java-asset/proto-google-cloud-asset-v1/src/main/java/com/google/cloud/asset/v1/FeedName.java:[24,33] package com.google.common.collect does not exist
[ERROR] /tmpfs/src/github/java-asset/proto-google-cloud-asset-v1/src/main/java/com/google/cloud/asset/v1/ProjectName.java:[21,30] package com.google.common.base does not exist
[ERROR] /tmpfs/src/github/java-asset/proto-google-cloud-asset-v1/src/main/java/com/google/cloud/asset/v1/FeedName.java:[57,15] cannot find symbol
  symbol:   variable Preconditions
  location: class com.google.cloud.asset.v1.FeedName
[ERROR] /tmpfs/src/github/java-asset/proto-google-cloud-asset-v1/src/main/java/com/google/cloud/asset/v1/FeedName.java:[58,12] cannot find symbol
  symbol:   variable Preconditions
  location: class com.google.cloud.asset.v1.FeedName
[ERROR] /tmpfs/src/github/java-asset/proto-google-cloud-asset-v1/src/main/java/com/google/cloud/asset/v1/FeedName.java:[65,14] cannot find symbol
  symbol:   variable Preconditions
  location: class com.google.cloud.asset.v1.FeedName
[ERROR] /tmpfs/src/github/java-asset/proto-google-cloud-asset-v1/src/main/java/com/google/cloud/asset/v1/FeedName.java:[66,12] cannot find symbol
  symbol:   variable Preconditions
  location: class com.google.cloud.asset.v1.FeedName
[ERROR] /tmpfs/src/github/java-asset/proto-google-cloud-asset-v1/src/main/java/com/google/cloud/asset/v1/FeedName.java:[73,20] cannot find symbol
  symbol:   variable Preconditions
  location: class com.google.cloud.asset.v1.FeedName
[ERROR] /tmpfs/src/github/java-asset/proto-google-cloud-asset-v1/src/main/java/com/google/cloud/asset/v1/FeedName.java:[74,12] cannot find symbol
  symbol:   variable Preconditions
  location: class com.google.cloud.asset.v1.FeedName

The failing "dependencies" check compares the original pom and the flattened-pom. Somehow the test dependencies affect the generation.
https://gist.github.com/suztomo/97945182d40fa01b5ca54ed462efddae


[Diag] Create a serialized format for Localized Diagnostics

Introduces a serialized file format and create a tool for converting the diagnostic file from .yaml to .db

cc @xedin

@swift-ci please build toolchain

macOS Toolchain
Download Toolchain
Git Sha - bc4ff41da4bed49605c94a2b63a32e78b0b7b672
Install command
tar -zxf  swift-PR-33022-587-osx.tar.gz --directory ~/

@swift-ci please build toolchain

@swift-ci please build toolchain

@swift-ci please build toolchain macOS platform

@xedin why did the build failed? https://ci.swift.org/job/swift-PR-toolchain-osx/lastBuild/console

CI issue, let's try again.

@swift-ci please build toolchain macOS platform

@swift-ci please build toolchain macOS platform

@shahmishal Looks like there is a problem with github auth on one of the machines.

Should be fixed, please try again

@swift-ci please build toolchain macOS platform

@shahmishal Thanks, looks like it worked!

macOS Toolchain
Download Toolchain
Git Sha - 87d2d15f0cfa469c570e6e54d9ee4c35d54de7a9
Install command
tar -zxf  swift-PR-33022-593-osx.tar.gz --directory ~/

Great! Looks like we got .db in the toolchain now, I can make it so everything is placed into the share/swift/diagnostics and copied from there

@swift-ci please clean build toolchain

@swift-ci please build toolchain

@swift-ci please build toolchain

@swift-ci please test

@swift-ci please build toolchain

@swift-ci please asan test

Build failed
Swift Test OS X Platform
Git Sha - bc4ff41da4bed49605c94a2b63a32e78b0b7b672

Build failed
Swift Test Linux Platform
Git Sha - bc4ff41da4bed49605c94a2b63a32e78b0b7b672

@swift-ci please ASAN test

@shahmishal Both toolchain builds were successful but none updated their state :/

Ok, both toolchains look good now. Let's wait for the tests to run and we'll be good to go with this.

ASAN failure is in GSB and is unrelated to these changes.


Modules do not install from WebUI

When installing Modules via the WebUI, the Download progress shows and states the installation is successful however, the new menu options do not appear however installing via fwconsole at the CLI does work.

try restart apache server, it helped me
docker exec -it freepbx-app /bin/bash
/etc/init.d/apache2 restart

try command in docker

fwconsole moduleadmin list
I installed backup & filestore by the WebUI and WebUI shows that they are installed, but there is no WebUI specific to these modules
I executed the commands in docker:
docker exec -it freepbx-app /bin/bash
fwconsole moduleadmin list

And the WebUI specific to these modules appeared

It sounds as if with the latest changes to Freepbx something is not being refreshed/restarted. I'm curious - If you install a module via WebUI and then restart container, does it appear?

I have a problem with a restart, the docker freepbx-app does not see the mysql why I don’t know.
docker-compose up/down not change the system WebUI until execute comand fwconsole moduleadmin list

I will take that command and make it execute upon container startup and consider making a cron entry to execute it every 15 minutes.
The MySQL database not appearing after restart sounds something of concern - Best for a seperate issue (it may already be open) but it seems many people are having more issues than ever seen before with some of the recent updates related to the FreePBX Framework.

I don't think you need to add a command to cron, plugins are not often installed. I think this is a bug in WebUI. Maybe there is some WebUI API to add a command to it

Has anyone found a workaround for this?

Problem was related to upstream, now resolved with tiredofit/freepbx:15-4.0.0


do not inject self in namespace

Back to back with https://github.com/ipython/ipython/pull/7273

upstream have this patch for 3 weeks now, merging.


Updating the twitter logo

Updating the twitter logo in footer section.

@Arghadip-Chatterjee @sethshivam11 pls assign me this

Ok, @pani2004 I am Assigning this to You. Thank You !!

@pani2004 the issue is still not resolved. The bird icon is still there and not the X.


It refuses to do anything, it is completely and utterly useless, I have no idea what changed but it didn't used to act like this.

Copilot Chat Extension Version:
VS Code Version:
OS Version:
Logs:

Steps to Reproduce:

Ask it to analyze a text file with a selection of network packets from a Wireshark pcapng file
It just says "Sorry, I can't assist with that."

I am trying to use it to see if it can notice a needle in a haystack, I'm having network issues and I can't manually read 1,512 packets, it's worked for me before so I have no idea why it isn't now.

Could you please provide files to reproduce? Possibly, files are large and fill up context window


Add missing options to the bistro command

Some of the opam submit specific options weren't allowed to be passed to the default command, preventing it from being used for releases to custom repositories among other use cases.
This should help with #362 !

Looks good! There are also a couple of other flags from other commands such as distrib that are missing in bistro. See #357.


Using pre-trained embeddings?

Hi, cool paper!
Could you please indicate to me how to use your embeddings parameter?
I'm currently trying to make it work (on a forked version), but so far no luck.
Best,

For those interested, I fixed the issue. Just go to my fork, it supports pre-trained embeddings. So far, I tested using glove.


Add composite circuit definition when calling circuit.qasm()

Summary
Fixes #3416. Displays the qasm definition of a composite circuit that is included as an instruction within the main circuit.
The example from the original issue:
from qiskit import QuantumCircuit, QuantumRegister

rinv_q = QuantumRegister(1, name='q')
rinv_gate = QuantumCircuit(rinv_q, name='rinv')
rinv_gate.sdg(rinv_q)
rinv_gate.h(rinv_q)
rinv_gate.sdg(rinv_q)
rinv_gate.h(rinv_q)
rinv = rinv_gate.to_instruction()

qr = QuantumRegister(1, name='qr')
circuit = QuantumCircuit(qr, name='circuit')
circuit.append(rinv, [qr[0]])

print(circuit.qasm())

will now output:
OPENQASM 2.0;
include "qelib1.inc";
gate rinv q0 {sdg q0; h q0; sdg q0; h q0; }
qreg qr[1];
rinv qr[0];

Details and comments
This fix only handles composite circuits whose definition would be valid qasm code. For example, if the composite circuit includes a measurement or classical bits, then those will not be handled correctly. Currently it would just ignore the classical bits altogether, and the measurement would be written as measure q0;. I am not sure how we want to handle those cases, but maybe having a warning stating that those are not valid within the qasm definition so users at least understand that the definition printed out is not a valid representation would suffice.
I am also not sure if my method for determining if an instruction is a composite circuit or not is the best way to go about it (it relies on the Gate vs Instruction types and if other operations are added as type Instruction in the future then this could break). If someone has a suggestion for a better way of doing it, I'll gladly implement that instead.

Thanks a lot for taking this one @Matt-Stypulkoski
if you add the custom gate twice, the qasm definition will be there twice. For example, if you run the following code to your example:
...
circuit.append(rinv, [qr[0]])
print(circuit.qasm())

gate rinv q0 {sdg q0; h q0; sdg q0; h q0; }
gate rinv q0 {sdg q0; h q0; sdg q0; h q0; }
qreg qr[1];
rinv qr[0];
rinv qr[0];

It seems like the circuit should have a register of the defined gates and skip it printing it again if it was already there.

When you say "a register of the define gates", do you mean something like this:
custom_gates {
    gate rinv q0 {sdg q0; h q0; sdg q0; h q0; }
}
qreg qr[1];
rinv qr[0];
...

Or was there a different structure you were thinking of?

When you say "a register of the defined gates", do you mean something like this:

No. That's not valid QASM. I was using "register" not in the Quantum/Classical register meaning, but as a list that the circuit.qasm() method needs to hold so can track that rinv was already defined, and a new definition should not be included in the final string.

Ok, so a name check of the instruction within the method to see if it was added already. That makes sense, I'll add that in. Thanks for the clarification.

Considering the following example:
from qiskit import QuantumCircuit, QuantumRegister

h_q = QuantumRegister(1, name='q')
h_gate = QuantumCircuit(h_q, name='h')
h_gate.h(h_q)
h = h_gate.to_instruction()

qr = QuantumRegister(1, name='qr')
circuit = QuantumCircuit(qr, name='circuit')
circuit.append(h, [qr[0]])

QuantumCircuit.from_qasm_str(circuit.qasm())

QasmError: "Duplicate declaration for gate 'h' at line 3, file .

I see two possible approaches.

raise when h_gate is declared (at .qasm() time) because there is already a gate with that name
if a gate is already in scope, rename it to something like <name>_<number>.

Similarly, the repetition might happen because the user, not only because of qelib1.inc :
from qiskit import QuantumCircuit, QuantumRegister

my_gate = QuantumCircuit(1, name='my_gate')
my_gate.h(0)
my_gate_inst1 = my_gate.to_instruction()

my_gate = QuantumCircuit(1, name='my_gate')
my_gate.x(0)
my_gate_inst2 = my_gate.to_instruction()

qr = QuantumRegister(1, name='qr')
circuit = QuantumCircuit(qr, name='circuit')
circuit.append(my_gate_inst1, [qr[0]])
circuit.append(my_gate_inst2, [qr[0]])

print(circuit.qasm())

OPENQASM 2.0;
include "qelib1.inc";
gate my_gate q0 {h q0; }
qreg qr[1];
my_gate qr[0];
my_gate qr[0];

Whatever is the selected approach, here should happen the same.

I would think the best solution to this would be to provide a warning stating that a gate with this name already exists, and that we renamed the gate being created to <name>_<num> like you suggested.
As for how to do this, I was originally thinking that I could fill the list I was using to check for duplicate composite gates with the already existing gates, though I'm not sure of an efficient way to do this.
I would add the renaming logic after the check in the .qasm() method.

I would think the best solution to this would be to provide a warning stating that a gate with this name already exists, and that we renamed the gate being created to <name>_<num> like you suggested.

Sounds good to me.


Web socket times out after 1 minute of inactivity

On the public sandbox, I was noticing that the websocket client was exiting while trying to listen to messages.  By default there is a 1 minute timeout and the connection will close if no messages are sent/received over this period.

Sent pull request.  Closing this issue.


Doesn't work exactly like in the README

I couldn't get the IDE to fully adapt the theme without deleting any UI.png, UI_2.png, or UI_4.png files it had generated, then manually copying psd/UI_4.psd to the bin/themes/SimplyDark directory, then loading the theme.

I am gonna look into that

Should be fixed


Optimize truncation from beginning

rather than looping through unwanted elements, we skip them.

I didn't know you could do that with Rust's iterators! Nice one.


Can't display correctly Decimal Places of local variables in page extension

Dear Team,
I am making a customization to Blanket Purchase Order Subform Page.
In VS Code, I added 3 local variables to the extension of this page, and set AutoFormatExpression as below.

then the result is like this

You can see that 2 variables "Total Amount to Receive" and "Total Remaining Amount" are displayed with decimal places 0:0.
It seems that AutoFormatExpression of these 2 variables did not get the right value.
Expected value is EUR but in fact, it was blank so decimal places of local currency JPY (decimal places 0:0) was used to display these 2 variables.
I tried the same thing in NAV2018 CU13,  it worked correctly.
Setup:

Result:

Do you think that I missed something
or do you have any idea why my source code in page extension did not work?
Please kindly tell me if you have any idea. I really appreciate your help.
Thanks & Best Regards

@bachtruong can you try this code on the latest preview https://freddysblog.com/2019/07/31/preview-of-dynamics-365-business-central-2019-release-wave-2/ ? Does it still repro?

@atoader Thanks for your reply. I will try on 2019 release wave 2, but it is going to take time a litle bit because actually I don't have experience with Docker ^^. I will tell you the result after that. Thanks.


Puzzle x14188

URL

[ ] Image
[ ] Type
[ ] Defaults
[ ] Connections
[ ] Description
[ ] Verify

https://www.youtube.com/watch?v=oLp_Zav56J0 8:00


Contributor Nomination - Łukasz Majewski (OA TC6 driver)

Background
The TSC Project Roles defines the main roles for the Zephyr Project, including
Maintainer, Collaborator, and Contributor.
By default anyone that contributes code or documentation is a Contributor, but
with the lowest GitHub Permission Level of Read. For example, Contributors
with Read permission do not have the permission to add reviewers to a pull
request.
Use this template to nominate a GitHub user for the Contributor role with
Triage permission level, which allows the user to add reviewers to a pull
request and be added as a reviewer by other users.
Nomination
GitHub User
Provide the following information about the GitHub user:

Łukasz Majewski
lmajewski
Denx Software Engineering

Supporting Documents
https://github.com/zephyrproject-rtos/zephyr/pull/65507
https://github.com/zephyrproject-rtos/zephyr/pull/63614
https://github.com/zephyrproject-rtos/zephyr/pull/40704
https://github.com/zephyrproject-rtos/zephyr/pull/33772
https://github.com/zephyrproject-rtos/zephyr/pull/33914
https://github.com/zephyrproject-rtos/zephyr/pull/27620

@aescolar @MaureenHelm @carlescufi  Gentle ping on this issue.

https://github.com/zephyrproject-rtos/zephyr/invitations


Provide react-live recommendation

It would be great to have a pros and cons, use cases section in the README for react-live vs component playground. This ticket can serve as a place to refine ideas about how to actually communicate that.

How I'd currently describe it is:

component-playground uses babel-standalone, react-live uses bublé (I might make this customisable soon)
component-playground has a larger bundle, but uses a more familiar editor setup, compared to react-live (custom editor around prism)
react-live is more modular/customisable and has a smaller bundle size, component-playground is easier/faster to set up
component-playground is not server-side renderable, react-live is
component-playground might have more predictable error handling than react-live in some cases (due to react-dom, see above; this might change with React 16 though)

I think those are the main points for comparison, right?

@philpl @kenwheeler -- I've taken a first stab at a README section draft based on Phil's bullet points at https://gist.github.com/ryan-roemer/155b204a420ec78d8e275f7e3d6de1b3
Love to hear suggestions / edits / additions!

@ryan-roemer This looks great! 🌟 It should help everyone to make an informed decision and I think every consideration is covered 👍


need market loading screen if user nav directly to market

There is a case when user navs directly to a market and the market shows "market does not exist" while it's loading.
Need to show loading screen.

@bthaile do you need design on this from @matt-bullock ?

A skeleton loader already exists for this. I remember Phoebe making it


Better formatting of Packet curl command

A continuation of https://github.com/coreos/docs/pull/561. Just making the format of the curl command a bit nicer (no escapes, consistent capitalization, etc).

LGTM


Improve timeout logic for docsum/search invokers

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Fail early on timeout.


BindingSpec.secretName shouldn't be required to be set by the user

While creating a binding I got an error message saying that I had to specify a secretName. I seem to recall that we agreed to default to the bindingName for this to minimize the amount of things users had to specify.

Well, it's a required field, but we can default it.

We may actually want to force them to give us a secretName if we split out PodPreSet from the Binding because then we're asking people to do more manual wiring of things than we originally intended - which means implicitly naming things could cause confusion for people.


Buggy tab complete for group messages

If sending a message to multiple people whose names start with the same letters (and case), the tab completion cuts off the first person's name.
https://user-images.githubusercontent.com/30316407/164911342-c155c8d6-c4a7-45a1-8068-9c05cc10ce53.mp4

Does this effect the message being sent the other account?


Inconsistent search results

Hello there.
When I have a query like https://developer.aiven.io/search.html?q=prometheus+kafka+metrics I only get Getting Started with New Relic from the “help center”, but if I search via https://help.aiven.io/en/?q=prometheus+kafka+metrics I get many more results including Kafka metrics through Prometheus integration.

Is dev portal search index somewhat outdated or something went wrong?
Could be related to #122
Ty.

I can't reproduce this now, and we shipped a bunch of improvements this week so I'm closing for now, let's re-open if we spot another situation where things don't seem quite right. Thanks @z0r1k for the original bug report!


feat: streamswap proto

Ref: #2333
What is the purpose of the change
Brief Changelog
Proto definitions (and generated protobuf go code) for Streamswap module
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? yes
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?  let's discuss
How is the feature or change documented? (not applicable   /   specification (x/<module>/spec/)  /  Osmosis docs repo   /   not documented)
not documented

Review comments solved. Please make the next review.


Is there any guide to add page transitions?

Like astro's <ViewTransition />
Like astros   `

^ man idk how it happened tag got totally removed here

Not yet. However, page transitions will be a core part of the system. They are so important piece of the end-user experience.  Focusing on this one after the design system and templates. Thanks!

There is now. It's very simple and standards based. Two examples:
https://sofa-company.nuejs.org/
https://aimee-app.nuejs.org/
Just a few lines of CSS can do it:
https://github.com/nuejs/create-nue/blob/master/sofa-company/global/sofa-company-design.css#L69-L72

https://caniuse.com/mdn-css_selectors_view-transition-old
Only works for chromium based browsers. The view transition api is not (yet) implemented for Safari and Firefox.


feat: make Opus.Application Sendable

This resolves #36 and is a requirement for this project to build with swift 6 mode turned on. I didn't however turn on swift 6 mode for the project yet though. I will leave that to a future PR

Can you rebase?

Done!


Use CuPy default memory pool

Please merge cupy/cupy#472 first.
CuPy provides default memory pool in cupy/cupy#472.
So, this PR uses CuPy default memory pool.

Jenkins, test this please.

@mitmul Test was passed. Cloud you merge this PR?

LGTM


use zig to compile RocksDB

Removes our dependency on Make and their build system.
This uncovered an assertion that all column families are destroyed, which led me to find multiple bugs in this iterator, and in the Sig test suite were iterators weren't being dented.

It seems the authors knew that this align function was UB, we will need to add ROCKSDB_UBSAN_RUN C macro
https://github.com/facebook/rocksdb/blob/295326b6ee3c895b5f093d1fd44e09c23050ea72/util/crc32c.cc#L513C8-L520


[BACKLOG-7186] - Metadata Injection for Metadata Injection step

@bmorrise please review

http://wingman.pentaho.com:8080/job/wingman/38/

http://wingman.pentaho.com:8080/job/wingman/40/

http://<IP_ADDRESS>:8080/job/wingman/49/

Build Commands:
Build:

ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml clean-all resolve jacoco && ant -Dpentaho.coding.standards.version=1.0.4 -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/src/org/pentaho/di/trans/steps/metainject/MetaInject.java
engine/src/org/pentaho/di/trans/steps/metainject/MetaInjectMapping.java
engine/src/org/pentaho/di/trans/steps/metainject/MetaInjectMeta.java
engine/src/org/pentaho/di/trans/steps/metainject/MetaInjectOutputField.java
engine/src/org/pentaho/di/trans/steps/metainject/messages/messages_en_US.properties
engine/test-src/org/pentaho/di/core/injection/BaseMetadataInjectionTest.java
engine/test-src/org/pentaho/di/trans/steps/metainject/MetaInjectMetaInjectionTest.java
engine/test-src/org/pentaho/di/trans/steps/metainject/MetaInjectMetaTest.java
Unit test coverage change:
org.pentaho.di.job.entries.sql.JobEntrySQL:

Instruction Change :  + 1.64%
Line Change :  + 1.94%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

Branch Change :  + 1.64%
Complexity Change :  + .69%
Instruction Change :  + 2.43%
Line Change :  + 3.70%

org.pentaho.di.trans.step.StepMeta:

Instruction Change :  + .19%
Line Change :  + .27%

org.pentaho.di.trans.steps.metainject.MetaInject:

Instruction Change :  + .09%
Line Change :  + .13%

org.pentaho.di.trans.steps.metainject.MetaInjectMapping:

Complexity New Coverage : 100.00%
Instruction New Coverage : 100.00%
Line New Coverage : 100.00%
Method New Coverage : 100.00%

org.pentaho.di.trans.steps.metainject.MetaInjectMeta:

Branch Change :  + 6.72%
Complexity Change :  + 11.93%
Instruction Change :  + 5.79%
Line Change :  + 7.67%
Method Change :  + 21.41%

org.pentaho.di.trans.steps.metainject.MetaInjectOutputField:

Complexity Change :  + 33.33%
Instruction Change :  + 20.00%
Line Change :  + 22.73%
Method Change :  + 33.33%

org.pentaho.di.trans.steps.metainject.MetaInjectOutputField.DataTypeConverter:

Complexity New Coverage : 50.00%
Instruction New Coverage : 50.00%
Line New Coverage : 50.00%
Method New Coverage : 50.00%

org.pentaho.di.trans.steps.randomvalue.RandomValueMeta:

Branch Change : -2.17%
Complexity Change : -2.17%
Instruction Change : -.15%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta:

Instruction Change :  + .18%

Integration test coverage change:
org.pentaho.di.trans.steps.metainject.MetaInject:

Instruction Change :  + .07%
Line Change :  + .10%

org.pentaho.di.trans.steps.metainject.MetaInjectMeta:

Branch Change : -.32%
Complexity Change : -1.81%
Instruction Change : -1.16%
Line Change : -1.12%
Method Change : -1.92%

Checkstyle violations:
See: https://github.com/pentaho/pentaho-coding-standards
File /home/buildguy/project/engine/test-src/org/pentaho/di/trans/steps/metainject/MetaInjectMetaTest.java

Message: '>' is followed by whitespace. at Line: 116 Column: 91

@bmorrise the violation was fixed.


adding frame_id information to depth controller node

Added a new field to SetDepth.srv: frame_id. This addition was necessary so that we could pass frame_id as a parameter to ros service. Ros service can now be called by;
rosservice call /taluy/set_depth "target_depth: 5.0 frame_id: 'taluy/base_link/imu_link'"
Updated the function targetdepthhandler to take frame_id into account and transform the target_depth accordingly. The function now checks whether any frame_id is provided, and makes the appropriate transformation if we have one. If none, it passes the target depth directly.

Output of depth_controller_node, passed the above argument.

emin@emin  ~  rosrun auv_control depth_controller_node.py
[INFO] [1730549202.232636]: DepthControllerNode has started.
[INFO] [1730549202.348437]: Published cmd_pose with target depth: 0.0
[INFO] [1730549202.448895]: Published cmd_pose with target depth: 0.0
[INFO] [1730549202.548592]: Published cmd_pose with target depth: 0.0
[INFO] [1730549202.648865]: Published cmd_pose with target depth: 0.0
[INFO] [1730549203.548702]: Published cmd_pose with target depth: 0.0
[INFO] [1730549203.648719]: Published cmd_pose with target depth: 0.0
[INFO] [1730549203.748993]: Published cmd_pose with target depth: 0.0
[INFO] [1730549203.848313]: Published cmd_pose with target depth: 0.0
[INFO] [1730549203.948296]: Published cmd_pose with target depth: 0.0
[INFO] [1730549204.048224]: Published cmd_pose with target depth: 0.0
[INFO] [1730549204.148642]: Published cmd_pose with target depth: 0.0
[INFO] [1730549204.190259]: Received SetDepth request with target depth: 5.0 and frame_id: taluy/base_link/imu_link
[INFO] [1730549204.192819]: Transform from taluy/base_link/imu_link to taluy/base_link obtained successfully.
[INFO] [1730549204.194964]: Translation: x=-0.199, y=0.0, z=-0.0108
[INFO] [1730549204.197106]: Rotation: x=0.0, y=0.0, z=1.0, w=6.123233995736766e-17
[INFO] [1730549204.199998]: Target depth transformed to base frame: 4.9892
[INFO] [1730549204.248530]: Published cmd_pose with target depth: 4.9892
[INFO] [1730549204.348178]: Published cmd_pose with target depth: 4.9892
[INFO] [1730549205.749011]: Published cmd_pose with target depth: 4.9892
[INFO] [1730549205.848305]: Published cmd_pose with target depth: 4.9892
^C[INFO] [1730549205.948610]: Published cmd_pose with target depth: 4.9892

Hi, made some changes. Looking forward to hear from you @senceryazici

Looks good, I'm curious about the hardware tests though.

Looks good, I'm curious about the hardware tests though.
We will be testing the features of the new implementation in the next pool test.


Allow setting schema in postgres to redshift jobs.

See https://clever.atlassian.net/browse/INFRA-667 for the motivation.

lgtm


Restructure initialisation to match other XRInterfaces

This is absolutely a nitpicking issue and I'll find an hour somewhere to polish this up. Just recording this as something to remind me :)
The design of the XRServer is such that XRInterfaces are registered early, and the initialize/uninitialize function build up/tear down the system. For TiltFive its the other way around.

Part of the reason for this is that there is information passed into the T5 initialization functions, such and application ID and version. (Not 100% sure why but I expect it's for logging and customer support.) I was setting these up in scene nodes.  I could see putting this info into some sort of custom resource that could be loaded on startup. This would help in fixing this.

This is absolutely a nitpicking issue and I'll find an hour somewhere to polish this up. Just recording this as something to remind me :)
The design of the XRServer is such that XRInterfaces are registered early, and the initialize/uninitialize function build up/tear down the system. For TiltFive its the other way around.

Part of the reason for this is that there is information passed into the T5 initialization functions, such and application ID and version. (Not 100% sure why but I expect it's for logging and customer support.) I was setting these up in scene nodes. I could see putting this info into some sort of custom resource that could be loaded on startup. This would help in fixing this.

Part of the reason for this is that there is information passed into the T5 initialization functions, such and application ID and version. (Not 100% sure why but I expect it's for logging and customer support.) I was setting these up in scene nodes. I could see putting this info into some sort of custom resource that could be loaded on startup. This would help in fixing this.

We already store some of this information in the project settings and can retrieve it from there. I still need to look into the version number however because that is specified in export settings.
I'll take care of this one when I have a free moment :)


kfserving tensorflow flowers-sampleprediction through curl not working in kubeflow-v1.0.2 in GKE

/kind bug
What steps did you take and what happened:
Kfserving tensorflow flowers-sample prediction through curl command not working in kubeflow-v1.0 in GKE
Followed steps in https://github.com/kubeflow/kfserving/tree/master/docs/samples/tensorflow
flowers-sample in kubeflow v1.0
But error got through curl command to predict data
Error :

Connected to X.X.X.X port 31380 (#0)

POST /v1/models/flowers-sample:predict HTTP/1.1
Host: flowers-sample.anonymous.example.com
User-Agent: curl/7.58.0
Accept: /
Content-Length: 16139
Content-Type: application/x-www-form-urlencoded
Expect: 100-continue

< HTTP/1.1 100 Continue

We are completely uploaded and fine
< HTTP/1.1 404 Not Found
< x-powered-by: Express
< content-security-policy: default-src 'none'
< x-content-type-options: nosniff
< content-type: text/html; charset=utf-8
< content-length: 172
< date: Sun, 26 Apr 2020 17:04:37 GMT
< x-envoy-upstream-service-time: 0
< server: istio-envoy
<

Error

Cannot POST /v1/models/flowers-sample:predict

* Connection #0 to host X.X.X.X1 left intact
What did you expect to happen:
flowers-sample curl command to predict the result
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Istio Version: default version comes with kubeflow 1.0
Knative Version: default version comes with kubeflow 1.0
KFServing Version: default version comes with kubeflow 1.0
Kubeflow version: v1.0
Kubernetes version: (use kubectl version): 1.14.10
OS (e.g. from /etc/os-release): ubuntu

@prem0912 Can you get the full output of inference service status?

@yuzisun You mean logs of  flowers-sample inference service or kfserving-control-manager or logs of  pods in  knative-serving namespace...
One more update kfserving is working in the installation of kubeflow V1.0,  which I have done before a month.
But kfserving not working  where kubeflow is installed past a week.

I have the same issue with sklearn example:

i ran into similar issue and turned out i used incorrect istio gateway selector for forwarding

I can reproduce the issue with sklearn example as well:

I am running into the same problem. I'm on KFServing v0.3.0 and Knative v0.11.2, using Knative with Istio v1.3.1.
After some digging, I found that the url returned by my inference service routes to the cluster-local-gateway and not to the kubernetes service as created by knative:
Virtual Services:
$ kubectl get virtualservices.networking.istio.io -n my-namespace
NAME                          GATEWAYS                                                                          HOSTS                                                                                AGE
test                          [knative-ingress-gateway.knative-serving knative-serving/cluster-local-gateway]   [test.my-namespace.example.com test.my-namespace.svc.cluster.local]                                                                                46m
test-predictor-default        [knative-serving/cluster-local-gateway knative-serving/knative-ingress-gateway]   [test-predictor-default.my-namespace test-predictor-default.my-namespace.example.com test-predictor-default.my-namespace.svc test-predictor-default.my-namespace.svc.cluster.local]   46m
test-predictor-default-mesh   [mesh]                                                                            [test-predictor-default.my-namespace test-predictor-default.my-namespace.svc test-predictor-default.my-namespace.svc.cluster.local]                                                                                46m

Virtual service:
$ k get virtualservices.networking.istio.io -n my-namespace test -o yaml
...
spec:
  gateways:
  - knative-ingress-gateway.knative-serving
  - knative-serving/cluster-local-gateway
  hosts:
  - test.my-namespace.example.com
  - test.my-namespace.svc.cluster.local
...
    route:
    - destination:
        host: cluster-local-gateway.istio-system.svc.cluster.local
        port:
          number: 80
      headers:
        request:
          set:
            Host: test-predictor-default.my-namespace.svc.cluster.local
      weight: 100

Since I don't have the cluster-local-gateway enabled, my predictions don't return anything.
However, predictions do work on test-predictor-default.my-namespace.example.com. Can anyone verify this?

@larssuanet We currently depend on local gateway, can you get that installed ?

I encountered the same problem as well. I followed the instructions in setting up Kubeflow in Minikube running on a Linux VM. This is the KFDef that I used.
$ MODEL_NAME=flowers-sample
$ export<EMAIL_ADDRESS>$ CLUSTER_IP=$(kubectl -n istio-system get service istio-ingressgateway -o jsonpath='{.spec.clusterIP}')
<IP_ADDRESS>
$ SERVICE_HOSTNAME=$(sudo -E kubectl get inferenceservice ${MODEL_NAME} -n bjmrevilla -o jsonpath='{.status.url}' | cut -d "/" -f 3)
flowers-sample.bjmrevilla.example.com

$ curl -v -H "Host: ${SERVICE_HOSTNAME}" http://$CLUSTER_IP/v1/models/$MODEL_NAME:predict -d $INPUT_PATH

*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80 (#0)
> POST /v1/models/flowers-sample:predict HTTP/1.1
> Host: flowers-sample.bjmrevilla.example.com
> User-Agent: curl/7.58.0
> Accept: */*
> Content-Length: 16201
> Content-Type: application/x-www-form-urlencoded
> Expect: 100-continue
>
< HTTP/1.1 100 Continue
* We are completely uploaded and fine
< HTTP/1.1 404 Not Found
< x-powered-by: Express
< content-security-policy: default-src 'none'
< x-content-type-options: nosniff
< content-type: text/html; charset=utf-8
< content-length: 172
< date: Thu, 14 May 2020 14:57:01 GMT
< x-envoy-upstream-service-time: 0
< server: istio-envoy
<
<!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot POST /v1/models/flowers-sample:predict

* Connection #0 to host <IP_ADDRESS> left intact

Virtual Services:
$ kubectl get vs -n bjmrevilla
NAME                                    GATEWAYS                                                                          HOSTS                                                                                AGE
flowers-sample                          [knative-ingress-gateway.knative-serving]                                         [flowers-sample.bjmrevilla.example.com]                                                                                67m
flowers-sample-predictor-default        [knative-serving/cluster-local-gateway knative-serving/knative-ingress-gateway]   [flowers-sample-predictor-default.bjmrevilla flowers-sample-predictor-default.bjmrevilla.example.com flowers-sample-predictor-default.bjmrevilla.svc flowers-sample-predictor-default.bjmrevilla.svc.cluster.local]   68m
flowers-sample-predictor-default-mesh   [mesh]                                                                            [flowers-sample-predictor-default.bjmrevilla flowers-sample-predictor-default.bjmrevilla.svc flowers-sample-predictor-default.bjmrevilla.svc.cluster.local]                                                           68m

$ kubectl get vs flowers-sample -n bjmrevilla -o yaml
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"serving.kubeflow.org/v1alpha2","kind":"InferenceService","metadata":{"annotations":{},"name":"flowers-sample","namespace":"bjmrevilla"},"spec":{"default":{"predictor":{"tensorflow":{"storageUri":"gs://kfserving-samples/models/tensorflow/flowers"}}}}}
  creationTimestamp: "2020-05-14T13:54:37Z"
  generation: 1
  name: flowers-sample
  namespace: bjmrevilla
  ownerReferences:
  - apiVersion: serving.kubeflow.org/v1alpha2
    blockOwnerDeletion: true
    controller: true
    kind: InferenceService
    name: flowers-sample
    uid: ec37509c-d032-4935-bef8-6b0145971ed2
  resourceVersion: "5998"
  selfLink: /apis/networking.istio.io/v1alpha3/namespaces/bjmrevilla/virtualservices/flowers-sample
  uid: fd9c1d91-fd02-4251-be41-9614712a0ced
spec:
  gateways:
  - knative-ingress-gateway.knative-serving
  hosts:
  - flowers-sample.bjmrevilla.example.com
  http:
  - match:
    - uri:
        prefix: /v1/models/flowers-sample:predict
    route:
    - destination:
        host: kfserving-ingressgateway.istio-system.svc.cluster.local
        port: {}
      headers:
        request:
          set:
            Host: flowers-sample-predictor-default.bjmrevilla.example.com
      weight: 100

$ kubectl describe inferenceservice flowers-sample -nbjmrevilla
Name:         flowers-sample
Namespace:    bjmrevilla
Labels:       <none>
Annotations:  kubectl.kubernetes.io/last-applied-configuration:
                {"apiVersion":"serving.kubeflow.org/v1alpha2","kind":"InferenceService","metadata":{"annotations":{},"name":"flowers-sample","namespace":"...
API Version:  serving.kubeflow.org/v1alpha2
Kind:         InferenceService
Metadata:
  Creation Timestamp:  2020-05-14T13:54:26Z
  Generation:          5
  Resource Version:    5999
  Self Link:           /apis/serving.kubeflow.org/v1alpha2/namespaces/bjmrevilla/inferenceservices/flowers-sample
  UID:                 ec37509c-d032-4935-bef8-6b0145971ed2
Spec:
  Default:
    Predictor:
      Tensorflow:
        Resources:
          Limits:
            Cpu:     1
            Memory:  2Gi
          Requests:
            Cpu:          1
            Memory:       2Gi
        Runtime Version:  1.14.0
        Storage Uri:      gs://kfserving-samples/models/tensorflow/flowers
Status:
  Canary:
  Conditions:
    Last Transition Time:  2020-05-14T13:54:37Z
    Status:                True
    Type:                  DefaultPredictorReady
    Last Transition Time:  2020-05-14T13:54:37Z
    Status:                True
    Type:                  Ready
    Last Transition Time:  2020-05-14T13:54:37Z
    Status:                True
    Type:                  RoutesReady
  Default:
    Predictor:
      Host:  flowers-sample-predictor-default.bjmrevilla.example.com
      Name:  flowers-sample-predictor-default-4wd4q
  Traffic:   100
  URL:       http://flowers-sample.bjmrevilla.example.com/v1/models/flowers-sample
Events:      <none>

@bjmrevilla there is an issue unfortunately in kubeflow manifests v1.0.2 https://github.com/kubeflow/manifests/issues/1142, either you can fall back to v1.0.0 or use manifest from v1.0 branch/master.

This is fixed in upcoming kubeflow 1.1, however you can still configure to use kubeflow gateway to fix the issue if you are using 1.0.2. There are two places which need to configure:

Configure knative config-istio to use the kubeflow gateway
Configure kfserving inferenceservice-config to use the kubeflow gateway

Hi, @yuzisun I tried the above configuration as you have mentioned on kubeflow v1.0.2, but now the inference service fails to deploy. I did some debugging and found that the underlying knative route is not ready due to IngressNotConfigured. I am posting the status of a kubectl describe on the route below. But I saw that the revisions are ready, any idea what else could be missing?
Status:
  Address:
    URL:  http://sk-iris-predictor-default.seldon.svc.cluster.local
  Conditions:
    Last Transition Time:  2020-07-10T11:17:20Z
    Status:                True
    Type:                  AllTrafficAssigned
    Last Transition Time:  2020-07-10T11:17:20Z
    Message:               Ingress has not yet been reconciled.
    Reason:                IngressNotConfigured
    Status:                Unknown
    Type:                  IngressReady
    Last Transition Time:  2020-07-10T11:17:20Z
    Message:               Ingress has not yet been reconciled.
    Reason:                IngressNotConfigured
    Status:                Unknown
    Type:                  Ready
  Observed Generation:     1
  Traffic:
    Latest Revision:  true
    Percent:          100
    Revision Name:    sk-iris-predictor-default-v6fhc
  URL:                http://sk-iris-predictor-default.seldon.example.com
Events:
  Type     Reason         Age   From              Message
  ----     ------         ----  ----              -------
  Normal   Created        11s   route-controller  Created placeholder service "sk-iris-predictor-default"
  Normal   Created        11s   route-controller  Created Ingress "sk-iris-predictor-default"
  Warning  InternalError  11s   route-controller  failed to update Ingress: Operation cannot be fulfilled on ingresses.networking.internal.knative.dev "sk-iris-predictor-default": the object has been modified; please apply your changes to the latest version and try again

@SachinVarghese you want to give a shot with kubeflow 1.1 RC0?

this has been fixed in kubeflow 1.1
/close

this has been fixed in kubeflow 1.1 /close

this problem still exists in 1.5 and 1.4
[root@dev-master kfserving]# curl -v -H "Host: ${SERVICE_HOSTNAME}" -H "Cookie: authservice_session=${SESSION}" http://${CLUSTER_IP}/v1/models/${MODEL_NAME}:predict -d ${INPUT_PATH}
* About to connect() to <IP_ADDRESS> port 80 (#0)
*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80 (#0)
> POST /v1/models/sklearn-iris:predict HTTP/1.1
> User-Agent: curl/7.29.0
> Accept: */*
> Host: sklearn-iris.kubeflow-user-example-com.example.com
> Cookie: authservice_session=MTY0OTQwNzgyOXxOd3dBTkVaQ1ZqWlpTazFFVlVVMU56TkxWRTQyV0ZkV1ZVTllWMWRCVEZGQldFTXpNamRMUjFoVE56SmFTVmMyVGpWTVMwVk9VRkU9fKa7dC36g3eCJjrZakMOkJOEvoouLi190z06UrDWWjQZ
> Content-Length: 88
> Content-Type: application/x-www-form-urlencoded
>
* upload completely sent off: 88 out of 88 bytes
< HTTP/1.1 404 Not Found
< x-powered-by: Express
< content-security-policy: default-src 'none'
< x-content-type-options: nosniff
< content-type: text/html; charset=utf-8
< content-length: 170
< date: Fri, 08 Apr 2022 08:55:50 GMT
< x-envoy-upstream-service-time: 2
< server: istio-envoy
<
<!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot POST /v1/models/sklearn-iris:predict

* Connection #0 to host <IP_ADDRESS> left intact

this has been fixed in kubeflow 1.1 /close

this problem still exists in 1.5 and 1.4
[root@dev-master kfserving]# curl -v -H "Host: ${SERVICE_HOSTNAME}" -H "Cookie: authservice_session=${SESSION}" http://${CLUSTER_IP}/v1/models/${MODEL_NAME}:predict -d ${INPUT_PATH}
* About to connect() to <IP_ADDRESS> port 80 (#0)
*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80 (#0)
> POST /v1/models/sklearn-iris:predict HTTP/1.1
> User-Agent: curl/7.29.0
> Accept: */*
> Host: sklearn-iris.kubeflow-user-example-com.example.com
> Cookie: authservice_session=MTY0OTQwNzgyOXxOd3dBTkVaQ1ZqWlpTazFFVlVVMU56TkxWRTQyV0ZkV1ZVTllWMWRCVEZGQldFTXpNamRMUjFoVE56SmFTVmMyVGpWTVMwVk9VRkU9fKa7dC36g3eCJjrZakMOkJOEvoouLi190z06UrDWWjQZ
> Content-Length: 88
> Content-Type: application/x-www-form-urlencoded
>
* upload completely sent off: 88 out of 88 bytes
< HTTP/1.1 404 Not Found
< x-powered-by: Express
< content-security-policy: default-src 'none'
< x-content-type-options: nosniff
< content-type: text/html; charset=utf-8
< content-length: 170
< date: Fri, 08 Apr 2022 08:55:50 GMT
< x-envoy-upstream-service-time: 2
< server: istio-envoy
<
<!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot POST /v1/models/sklearn-iris:predict

* Connection #0 to host <IP_ADDRESS> left intact

I face to same issue with kubeflow 1.3 , have you solve this problem ? @nicozhang

this has been fixed in kubeflow 1.1 /close

this problem still exists in 1.5 and 1.4
[root@dev-master kfserving]# curl -v -H "Host: ${SERVICE_HOSTNAME}" -H "Cookie: authservice_session=${SESSION}" http://${CLUSTER_IP}/v1/models/${MODEL_NAME}:predict -d ${INPUT_PATH}
* About to connect() to <IP_ADDRESS> port 80 (#0)
*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80 (#0)
> POST /v1/models/sklearn-iris:predict HTTP/1.1
> User-Agent: curl/7.29.0
> Accept: */*
> Host: sklearn-iris.kubeflow-user-example-com.example.com
> Cookie: authservice_session=MTY0OTQwNzgyOXxOd3dBTkVaQ1ZqWlpTazFFVlVVMU56TkxWRTQyV0ZkV1ZVTllWMWRCVEZGQldFTXpNamRMUjFoVE56SmFTVmMyVGpWTVMwVk9VRkU9fKa7dC36g3eCJjrZakMOkJOEvoouLi190z06UrDWWjQZ
> Content-Length: 88
> Content-Type: application/x-www-form-urlencoded
>
* upload completely sent off: 88 out of 88 bytes
< HTTP/1.1 404 Not Found
< x-powered-by: Express
< content-security-policy: default-src 'none'
< x-content-type-options: nosniff
< content-type: text/html; charset=utf-8
< content-length: 170
< date: Fri, 08 Apr 2022 08:55:50 GMT
< x-envoy-upstream-service-time: 2
< server: istio-envoy
<
<!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot POST /v1/models/sklearn-iris:predict

* Connection #0 to host <IP_ADDRESS> left intact

I face to same issue with kubeflow 1.3 , have you solve this problem ? @nicozhang

this has been fixed in kubeflow 1.1 /close

this problem still exists in 1.5 and 1.4
[root@dev-master kfserving]# curl -v -H "Host: ${SERVICE_HOSTNAME}" -H "Cookie: authservice_session=${SESSION}" http://${CLUSTER_IP}/v1/models/${MODEL_NAME}:predict -d ${INPUT_PATH}
* About to connect() to <IP_ADDRESS> port 80 (#0)
*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80 (#0)
> POST /v1/models/sklearn-iris:predict HTTP/1.1
> User-Agent: curl/7.29.0
> Accept: */*
> Host: sklearn-iris.kubeflow-user-example-com.example.com
> Cookie: authservice_session=MTY0OTQwNzgyOXxOd3dBTkVaQ1ZqWlpTazFFVlVVMU56TkxWRTQyV0ZkV1ZVTllWMWRCVEZGQldFTXpNamRMUjFoVE56SmFTVmMyVGpWTVMwVk9VRkU9fKa7dC36g3eCJjrZakMOkJOEvoouLi190z06UrDWWjQZ
> Content-Length: 88
> Content-Type: application/x-www-form-urlencoded
>
* upload completely sent off: 88 out of 88 bytes
< HTTP/1.1 404 Not Found
< x-powered-by: Express
< content-security-policy: default-src 'none'
< x-content-type-options: nosniff
< content-type: text/html; charset=utf-8
< content-length: 170
< date: Fri, 08 Apr 2022 08:55:50 GMT
< x-envoy-upstream-service-time: 2
< server: istio-envoy
<
<!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot POST /v1/models/sklearn-iris:predict

* Connection #0 to host <IP_ADDRESS> left intact

I face to same issue with kubeflow 1.3 , have you solve this problem ? @nicozhang

check this https://github.com/kserve/kserve/issues/2138#issuecomment-1117426374 ,may be helpful

Hi @nicozhang , @namlh16, @yuzliu I'm also facing same issue and not able to resolve.

Trying :8080...
TCP_NODELAY set
Connected to  () port 8080 (#0)

POST /v1/models/iris-kf-auth-project:predict HTTP/1.1
Host: iris-kf-auth-project.ajkj.example.com
User-Agent: curl/7.68.0
Accept: /
Content-Length: 76
Content-Type: application/x-www-form-urlencoded

upload completely sent off: 76 out of 76 bytes
Mark bundle as not supporting multiuse
< HTTP/1.1 404 Not Found
< content-type: text/html; charset=UTF-8
< referrer-policy: no-referrer
< content-length: 315
< date: Thu, 23 Jun 2022 13:50:32 GMT
< x-envoy-upstream-service-time: 62
< server: envoy
<

404 Not Found
# Error: Not Found
## The requested URL `/v1/models/iris-kf-auth-project:predict` was not found on this server.
* Connection #0 to host left intact
Are you guys able to resolve?

The problem is caused by the sklearn version.  The version of training model is diff from the version in kfserving image, so the model can not be load correctly. Try the same version sklearn .


Error on TSON.is(): no transform has been configured

Question
I continue to get the error message related to the transformer in tsconfig.json. I've followed the setup setup.  Could you lmk what I've done wrong here:
<EMAIL_ADDRESS>many thanks!

You configured property name as transforms.
Changed it to transform.

Hey @samchon thank you for your quick response.  My apologies, but actually that extra 's' must've been something that got accidentally added after I posted here.  The 's' wasn't originally there, and I've removed it now, you can see,  I still get the same error without the proper spelling.  Sorry about the confusion.

Build through ttsc command, then it would be. Please read the README again.

i ran into a similar issue, and put together a minimal reproduction here. tried building through ttsc and ts-node -C ttypescript, wasn't able to get either one working

@jasonnnc3 remove below line, then it works fine:
{
  "ts-node": {
    "swc": true
  }
}

https://github.com/jasonnnc3/ts-json-debug-example/blob/5c786e926cf74929017ee122b8b993c032d94bab/tsconfig.json#L20-L22

works great, thanks for helping out


#1166 - Fixed issues w/ clientlibs (and broken Quickly filter)

Coverage remained the same at 31.847% when pulling b67d7d0cea78599b8edef382c1c311ed83a95ad0 on davidjgonzalez:feature/1166 into fea9000873e620da5cf07c3e79c860de541eaa5c on Adobe-Consulting-Services:master.

Coverage remained the same at 31.847% when pulling b67d7d0cea78599b8edef382c1c311ed83a95ad0 on davidjgonzalez:feature/1166 into fea9000873e620da5cf07c3e79c860de541eaa5c on Adobe-Consulting-Services:master.

can you fix the thing codeclimate is complaining about?

Coverage remained the same at 31.847% when pulling 924e405640fdf76c910b94bdac2fbcb2455b63aa on davidjgonzalez:feature/1166 into fea9000873e620da5cf07c3e79c860de541eaa5c on Adobe-Consulting-Services:master.


Add picture function don't work correctly

Steps to reproduce the issue:
1.add some picture into different rows
2.change other pictures on the file!!
3.multi sheet excel file
Hello.
when  i want to add some picture in one xlsx file multi sheet(in for loop) they don't set correctly and one or 2 image only set .
also 1 picture that was in template file also change!

        f, err := excelize.OpenFile("./FORM_EXCEL.xlsx")
	if err != nil {
		return  err
	}
	err = f.AddPicture("sheet1", "C10", "."+"/images/82018600.png", `{"autofit": true }`) //picture
	err = f.AddPicture("sheet1", "C11", "."+"/images/82018601.png", `{"autofit": true }`) //picture
	err = f.AddPicture("sheet1", "C12", "."+"/images/82018602.png", `{"autofit": true }`) //picture
        f.save()

3 pictures are different but you see this ...👆👆👆👆👆👆

Thanks for your feedback, could you show us a complete, standalone example program or reproducible demo? Which version of the Excelize are you using, please gave a try the master branch code. And provide your input file attachment without confidential info if you can.

It seems still not have enough info of code and attachments to reproduce this issue, so I'll close this issue, if you have any questions, please let me know to reopen this anytime.


Query params are required as params of create method

For some reason it requires to provide the query params in object provided to create method, but it accepts only values "true" or 1.

@JanCizmar see issue and reason here https://github.com/ajaishankar/openapi-typescript-fetch/issues/28#issuecomment-1124881585

Then I would recommend to specify it in docs. But I still don't know, why the library needs to know it in the create method before calling the actual fetch?


[Feature idea] Ability to change OPL/OPN emulation core

Currently, there is no way for that, it uses ADL/OPNMIDI default it seems, while:
ADLMIDI supports three usable emus: Nuked 1.8, DOSBox and JavaOPL3;
OPNMIDI has Nuked OPN2, MAME YM2612, Genesis Plus GX MAME fork, and OPNA FM cores from MAME and Neko Project 2.

This possibility has just been added in 5b4f83a
Here are emulators and respective settings values.
    {"dosbox", ADLMIDI_EMU_DOSBOX},
    {"nuked", ADLMIDI_EMU_NUKED},
    {"nuked 1.7", ADLMIDI_EMU_NUKED_174},
    {"opal", ADLMIDI_EMU_OPAL},
    {"java", ADLMIDI_EMU_JAVA},

    {"mame", OPNMIDI_EMU_MAME},
    {"mame2612", OPNMIDI_EMU_MAME},
    {"nuked", OPNMIDI_EMU_NUKED},
    {"gens", OPNMIDI_EMU_GENS},
    {"gx", OPNMIDI_EMU_GX},
    {"neko", OPNMIDI_EMU_NP2},
    {"mame2608", OPNMIDI_EMU_MAME_2608},
    {"pmdwin", OPNMIDI_EMU_PMDWIN},

What is the difference between mame and mame2612?

No difference, this is only an alias.


Docs for Beginners...

I wasn't sure how to get the server working... here's where I'm at:
Struggled with PowerShell (first time using PS_ISE):
When I opened a file in PS-ISE I didn't notice that I still needed to navigate to the working directory in order to load the other files.
Server started, what should be expected?
When I started the server, as expected, things froze. Wasn't sure what to do next... so opened a chrome tab and went to http://<IP_ADDRESS>:8080 (nothing loaded). Messed around in the code and eventually figured out I could navigate to: http://localhost:8081/workbook/Sheet1 (pleasing results, I see JSON)...
Deleting the lock file:
When I delete the lock file the server still spins its wheels for a while, if (after deleting the lock file) I refresh my browser on this page: http://<IP_ADDRESS>:8080 Excel becomes responsive almost instantly (otherwise it remains unresponsive).
This is awesome!

The lock file workaround will be removed some day, as I figured out a way to have the sockets "less-blocking" in a different project, but I didn't come around to actually port this over to webxcel yet. The reason it stays unresponsive after deleting the lock file is because it's still stuck at the accept() call, which will be over as soon as you try to reload the page from your browser - which initiates a new connection, yielding a socket handle in the accept() call. This is badly written currently, but a fix is technically feasible.
As for the PowerShell confusion: maybe we need a better documentation, the readme is maybe not the best place to explain how to get started. Thanks for taking the time to type up these docs though :+1:
Depending on how you started your server, the index.html should be picked up when appropriately configured. Again, this requires some documentation, as it's not obvious that FileSystemWebController supports this.

The lock file workaround will be removed some day, as I figured out a way to have the sockets "less-blocking" in a different project

Care to elaborate so others can perhaps contribute?


Reuse the eodash/eodash_catalog

To avoid double development.
One thing to consider is that eodash v4 depends on template links on collection level, while eodash v5 uses rendered links on item level (we should try to generate both in all cases if possible)

being done in https://github.com/eurodatacube/eodash-catalog/pull/180


travis: PHP 7.0 nightly added + few improvements

force container based builds
make phpunit run explicit

please also enable the directory cache for $HOME/.composer/cache/files so that we have a change to reuse cached downloads between builds

@stof Done

great, thanks!

@dbu :+1:


Confirming the max score possible per round

Opening this as issue, hopefully you don't mind, but other than Saliens Discord it's the easier place for me to communicate, but can someone verify if $Score * 120 (for hards) is the absolute maximum you can get from idling?
I remember that I got 2440 that got through (no error refreshing the game) when playing through browser without any scripts (switching tabs so the monsters don't attack), but maybe it's just my mind failing me. I originally tried chancing it for + $Score before submitting #6 but I got no progress reports assuming it's not working, but maybe it was me that did something wrong, especially as it was a middle of the night.
Others have mentioned of 2400.02 which seems like a float rounding error that might not actually add up, but if it does, then it'll add up on 24/7 idling over time.

I wouldn't trust what the client displays. What matters is what the server accepts. 2400 is max because there's 120 seconds and you get 20 points per second.


Saving config always needs to do a restart? [feat]

It seems that any config change (and clicking save on the bottom of the config page) does a full restart and all nodes go back to RefreshFromCache / through the startup process - which can take some time.
Is it always necessary to do a restart?
For example when adding a new gateway config item. Even a simple change seems to need a restart to take affect. For example changing the retain setting (with the new feature - great thanks).

@chrish987 Checking all config changes and apply them when possible and rtestart only in some conditions is really difficult to handle and also could cause many inconsistence problems. BTW you shouldn't need to modify those settings very often so the effort to implement such feature wouldn't be so useful


Make it possible to persist autocomplete settings

KeyboardKit 8.8 will replace the recently added settings types by adding data persistency to the various contexts.
This will make it possible to automatically persist any changes made to the autocomplete context, and to bind the context to SwiftUI toggles and pickers.

The new persistency capabilities can be tested in the master branch.
KeyboardKit Pro 8.8 will use these capabilities to add autocomplete settings to the new settings screen.


'Git Credential Manager Core' doesn't prompt authentication in dev container

VSCode Version: 1.59.1
Local OS Version: Windows 10 10.0.19042 (and macOS 11.4)
Reproduces in: Remote - Containers
Name of Dev Container Definition with Issue: custom

Steps to Reproduce:

here is github gist with dockerfiler devcontainer: https://gist.github.com/soccerjoshj07/e2986a9c901d34f7292a5f1194eefc9c
devcontainer.json file: https://gist.github.com/soccerjoshj07/f9ed032256527e0cddc07f68aa8d6da0
Run terraform init using a terraform solution with terraform modules stored in private Azure DevOps git repository
location; vs code prompts for username/password
Same thing occurs when running git clone

The old git credential manager seems to prompt, although slightly buggy (it prompts for azure devops username/password via the credential manager UI, but VS code also prompts for username / password).
Anything I'm missing to get Git Credential Manager Core to work with Dev Containers? I have tested in Windows 10 and macOS.

Did you install GCM in the dev container? By default it should be forwarded to your host machine in Remote - Containers.
/cc: @chrmarti


Residual and Skip connections are not padded, not causal?

Hi magenta! Thanks for making this public! I was looking over the code below and realized that the 1x1 residual and skip connections have no padding! Shouldn't these connections be padded by kernel size - 1 such that they are causal ? The link to the code is below
https://github.com/tensorflow/magenta/blob/master/magenta/models/nsynth/wavenet/h512_bo16.py#L282

The padding happens inside the convolution function: https://github.com/tensorflow/magenta/blob/master/magenta/models/nsynth/wavenet/masked.py#L148