Swarm/k8s : Catalogue Software update 4.0.0

Update:

added Rating and Databroker Verticles.
updated images tag
respective update in Examples values
Updated configs

@pranavv0 please also include necessary changes for swarm based deployment for catalogue

Update readme with new values @pranavv0

Integrate profanity check deployment to  cat hem repo


onagre: 1.1.0 -> 1.1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/onagre-launcher/onagre/releases.
meta.description for onagre is: General purpose application launcher for X and wayland inspired by rofi/wofi and alfred
meta.homepage for onagre is: https://github.com/onagre-launcher/onagre
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.1.1 with grep in /nix/store/lqxqzqpahi5qywdcfy667wqjp4f17092-onagre-1.1.1
found 1.1.1 in filename of file in /nix/store/lqxqzqpahi5qywdcfy667wqjp4f17092-onagre-1.1.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

onagre

Instructions to test this update (click to expand)

Either download from the cache:
nix-store -r /nix/store/lqxqzqpahi5qywdcfy667wqjp4f17092-onagre-1.1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A onagre https://github.com/r-ryantm/nixpkgs/archive/c87e3321daa3b1e0b62dd99d690eebe7d5285107.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/c87e3321daa3b1e0b62dd99d690eebe7d5285107#onagre

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lqxqzqpahi5qywdcfy667wqjp4f17092-onagre-1.1.1
ls -la /nix/store/lqxqzqpahi5qywdcfy667wqjp4f17092-onagre-1.1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

onagre

Maintainer pings
cc @jfvillablanca @ilya-epifanov for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368126

x86_64-linux

:white_check_mark: 1 package built:

onagre

@NixOS/nixpkgs-merge-bot merge


wrong url

https://github.com/PaddlePaddle/InterpretDL/blame/ae200116fc31e4ffeff24c5d16dbfc565172ed48/interpretdl/evaluate_interpreter/perturbation.py#L28

It seems correct. In page 6.

Now it is working. Maybe my mistake, but it is better to put the paper name
as well.
On Thu, Oct 5, 2023 at 10:22 AM Li Xuhong @.***> wrote:

It seems correct. In page 6.
—
Reply to this email directly, view it on GitHub
https://github.com/PaddlePaddle/InterpretDL/issues/68#issuecomment-1747836728,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQRQ3EJ4GWQ62OMZ6GVJHDX5X4SZAVCNFSM6AAAAAA5SBYJOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBXHAZTMNZSHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


📖 Add kcp, Space object-vs-physical distinction to glossary

Summary
This PR makes two enhancements to the glossary.  One is add some material on kcp.  The other is to distinguish between "physical space" and "space object".
Related issue(s)
Fixes #

@eaepstein
/cc @ezrasilvera
/cc @dumb0002
/cc @francostellari

The force-push to ac9964f0 updates the description of "Space Object" in response to the review remark above.

what is 'physical' about a 'physical space'?

The force-push to f1bdc0c1 responds to @ezrasilvera's review above.

/lgtm
/approve


Remove and merge extraOutputSubroutines.f90, temperature.f90, zenith.f90

I have moved the subroutines in modelConfiguration/extraOutputSubroutines.f90 to outputFunctions.f90 and utilityFunctions.f90
The files temperature.f90 and zenith.f90 have been merged with utilityFunctions.f90. The Makefile has been updated accordingly but there is a reference to extraOutputSubroutines.f90 in tools/facsimileToFortranMechanismConverter.py that has to be dealt with (although that script does not exist anymore).

This looks great. It has some conflicts that will need resolving, but I am away all this coming week, and probably won't have a chance to sit and fix those conflicts. If that's ok, I'll leave this until I'm back.
In the meantime, feel free to keep adding pull requests. One thing I'd strongly suggest is to use branches rather than the main branch for pull requests. In that way, you can always continue on the master branch without having the complications of the other changes around.
In particular, it might be helpful for you in the coming week to move these changes onto a branch, so that you can use the master branch again as before.
How I'd do this is the following (if you're happy to do this, that's great - if not, leave it for now):
making sure you're on the master branch, do:
git branch name_of_new_branch
git reset --hard HEAD~3
git checkout name_of_new_branch
git push (will ask you to set the upstream as usual)
open a pull request with this branch (stick identical comment in)
leave this PR for now
git checkout master
git pull upstream master
git push origin master
That should leave you in the state where a new PR has been opened for this, but your master branch is updated to the latest version, leaving you free to make more branches that will less likely need a complicated merge at the end.
Hope that's ok - feel free to leave it as it is if you're not going to want to make other changes next week.

Cancel PR. See PR #38.


Flags enums are not serialized when multiple flags are set

Hi,
I've encountered an issue with Flags enums. When multiple flags are set the enum value is serialized as null. Works fine with only one flag.
Code to repro:
        [Test]
        public void FlagsEnumSerializationWorks()
        {
            var config = new ConfigurationContainer();
            var serializer = config.Create();

            var input = new FlagsEnumContainer(LogMessageSeverity.Debug | LogMessageSeverity.Informational);
            var clone = Clone(input, serializer);

            Assert.AreEqual(input.Value, clone.Value);
        }

        public class FlagsEnumContainer
        {
            public LogMessageSeverity Value { get; set; }

            public FlagsEnumContainer()
            {
            }

            public FlagsEnumContainer(LogMessageSeverity value)
            {
                Value = value;
            }
        }

        public enum LogMessageSeverity
        {
            Debug = 0b1,
            Informational = 0b10,
            Critical = 0b100
        }

        public T Clone<T>(T objectToClone, IExtendedXmlSerializer serializer)
        {
            using var stream = new MemoryStream();
            serializer.Serialize(stream, objectToClone);
            stream.Seek(0, SeekOrigin.Begin);
            return serializer.Deserialize<T>(stream);
        }

Given the above example, the code:
var input = new FlagsEnumContainer(LogMessageSeverity.Debug | LogMessageSeverity.Informational);
string serialized = serializer.Serialize(new XmlWriterSettings {Indent = true}, input);

produces incorrectly
<?xml version="1.0" encoding="utf-8"?>
<SerializationTests-FlagsEnumContainer xmlns="clr-namespace:AutoSliceAndView.Core.Tests;assembly=AutoSliceAndView.Core.Tests">
  <Value xsi:nil="true" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" />
</SerializationTests-FlagsEnumContainer>

while this snippet works
var input = new FlagsEnumContainer(LogMessageSeverity.Debug);
string serialized = serializer.Serialize(new XmlWriterSettings {Indent = true}, input);

<?xml version="1.0" encoding="utf-8"?>
<SerializationTests-FlagsEnumContainer xmlns="clr-namespace:AutoSliceAndView.Core.Tests;assembly=AutoSliceAndView.Core.Tests">
  <Value>Debug</Value>
</SerializationTests-FlagsEnumContainer>

Ah!  Indeed, @jhranac ... nice find.  I've committed a fix that (hopefully 😁) addresses this issue.
Here are the instructions to try it out:
https://github.com/ExtendedXmlSerializer/home/pull/387#issuecomment-616658240
Please let me know of any issues that you find and/or questions you might have and I'll do my best to help you out. 👍

With the new version I'm getting another type of an issue:
System.InvalidCastException : Specified cast is not valid.
   at ExtendedXmlSerializer.ContentModel.Conversion.EnumerationConverters.Converters.Converter.Format(Enum instance) in C:\projects\extendedxmlserializer\src\ExtendedXmlSerializer\ContentModel\Conversion\EnumerationConverters.cs:line 37
   at ExtendedXmlSerializer.ContentModel.Content.ContentWriter.Write(IFormatWriter writer, Object instance) in C:\projects\extendedxmlserializer\src\ExtendedXmlSerializer\ContentModel\Content\ContentWriter.cs:line 12
   at ExtendedXmlSerializer.ContentModel.Content.Enclosure`1.Write(IFormatWriter writer, T instance) in C:\projects\extendedxmlserializer\src\ExtendedXmlSerializer\ContentModel\Content\Enclosure.cs:line 29
   at ExtendedXmlSerializer.ContentModel.Members.MemberWriter.Write(IFormatWriter writer, Object instance) in C:\projects\extendedxmlserializer\src\ExtendedXmlSerializer\ContentModel\Members\MemberWriter.cs:line 26
   at ExtendedXmlSerializer.ContentModel.Members.MemberListWriter.Write(IFormatWriter writer, Object instance) in C:\projects\extendedxmlserializer\src\ExtendedXmlSerializer\ContentModel\Members\MemberListWriter.cs:line 18
   at ExtendedXmlSerializer.ContentModel.Content.Enclosure`1.Write(IFormatWriter writer, T instance) in C:\projects\extendedxmlserializer\src\ExtendedXmlSerializer\ContentModel\Content\Enclosure.cs:line 29
   at ExtendedXmlSerializer.ExtensionModel.Xml.Write.Execute(Writing parameter) in C:\projects\extendedxmlserializer\src\ExtendedXmlSerializer\ExtensionModel\Xml\Write.cs:line 21
   at ExtendedXmlSerializer.ExtensionModel.Xml.Serializer.Serialize(XmlWriter writer, Object instance) in C:\projects\extendedxmlserializer\src\ExtendedXmlSerializer\ExtensionModel\Xml\Serializer.cs:line 19
   at ExtendedXmlSerializer.ExtensionModel.Xml.InstanceFormatter.Get(Object parameter) in C:\projects\extendedxmlserializer\src\ExtendedXmlSerializer\ExtensionModel\Xml\InstanceFormatter.cs:line 33
   at ExtendedXmlSerializer.ExtensionMethodsForSerialization.Serialize(IExtendedXmlSerializer this, Stream stream, Object instance) in C:\projects\extendedxmlserializer\src\ExtendedXmlSerializer\ExtensionMethodsForSerialization.cs:line 54

I've just found out that the enum we're using does not have int as a base type (it's referenced from a different library). It uses uint which can't be typecasted to int without loss of data.
I'd suggest utilizing
Enum.GetUnderlyingType(typeof(LogMessageSeverity))

to get specific enum value-type. The only type you have to check should be the ulong/UInt64. Everthing else can be converted to Int64 without any loss of data - but it can't be done using typecasting. Instead use the .net Convert class.

Weird @jhranac it would seem there's something wrong with the versioning here.  The callstack points to a converter class that was in the first release but removed in the 2nd release yesterday.
I have created a new release with a passing test on an uint enumeration type.  You can find that here:
https://github.com/ExtendedXmlSerializer/home/pull/387#issuecomment-617018114
Let's see if that treats you better. ✌

Yup, this works! Thanks for the quick fix.

Sweet!  I'll merge this in and see if we can get this posted to NuGet in the next week or so, depending on if other issues are reported.  In the meantime feel free to use the preview build. I will update once posted. 👍

Welp, tried to post but have run into yet another GitHub Actions issue:
https://github.community/t5/GitHub-Actions/Yet-Another-Broken-Build/m-p/56016#M9717
"Brittle" is my impression of this tech.  Should have simply stuck with AppVeyor.  Waiting to hear back to resume.  Please stick with the preview build for now.

Alrighty!  We are live.  Thank you for contributing and improving the quality of ExtendedXmlSerializer!
https://www.nuget.org/packages/ExtendedXmlSerializer/


Images not optimized when inlined with url-loader

When images get inlined by url loader they do not get minimized. With the image-webpack-loader they do get minified inline. Should have it inlined under 10KB atleast
Stats:
original: 37KB
not inline with imagemin-webpack-plugin: 5.7KB
inline with imagemin-webpack-plugin and url-loader: 37KB
inline with image-webpack-loader: 27KB

I didn't even think about inlined images!
I'll take a look at this. It should be fairly easy, but it's going to require some special handling.
Would you be able to point me to a repo that uses both this plugin and url-loader in this way that I can test on?
It's no big deal if you can't, but it would speed things up a bit.

I don't but this can be added to one of your own builds:

const ImageminPlugin = require('imagemin-webpack-plugin').default
const imageminMozjpeg = require('imagemin-mozjpeg')

new ImageminPlugin({
    test: /\.(jpe?g|png|gif|svg)$/i,
    optipng: {
        optimizationLevel: 7,
    },
    pngquant: {
        quality: '65-90',
        speed: 4,
    },
    gifsicle: {
        optimizationLevel: 3,
    },
    svgo: {
        plugins: [{
            removeViewBox: false,
            removeEmptyAttrs: true,
        }],
    },
    jpegtran: {
        progressive: true,
    },
    plugins: [
        imageminMozjpeg({
            quality: 65,
            progressive: true,
        }),
    ],
}),

{
    test: /\.(gif|png|jpe?g|svg)$/i,
    loader: 'url-loader',
    query: {
        limit: 50000,
        publicPath: '../',
        name: 'dist/images/bundle.[name].[hash:7].[ext]',
    },
},

Ugh, this is gonna be a lot harder than it looked, maybe impossible for a plugin to do.
url-loader doesn't add anything to the assets array when it inlines an image. So they never even reach this plugin to have me test or anything to them.
I'm still looking into if there are any options here, but it's not looking good...
Just kind of "thinking out loud here":

I might be able to hook to another even and grab these images before url-loader gets them, but that would really screw up things for other people which need this to run later in the pipeline (like when used with copy-webpack-plugin). This is pretty much a non-starter.

I could do the above, and add an option to choose which event you want it to hook on (or maybe let you pick both if you want). While this would work, it would be complicated, messy, and it's not really a solution I want to implement...

I can see if I can make a change to image-webpack-loader to give it a similar option to not imagemin any images above a specific size, then you could use both this plugin, and image-webpack-loader both for different images. It's messy, it requires more work on the person who is adding these plugins/loaders to their project, but it might be the best technical solution. This is my favorite option right now...

I can see if there is some easy way to "extract" any inlined images from other assets, have imagemin work on them, then plug them back into the other asset in their optimized form. While the thought of this makes my skin crawl, if it's possible to implement consistently and without breaking all kinds of other stuff (like mucking with random base64 strings in the source), it would be ideal.

Let me know if you have any thoughts on the above options. I'm going to look into url-loader's code and see if there is anything there that can help.

Okay, after looking into a few things, I think i've got an idea here.
I might be able to add my own "loader" to the pipeline using the normal-module-factory event, use that loader to optimize images before url-loader gets to them, and hopefully mark the assets I optimize so that when I run on the emit event I don't double-optimize assets which were hit by the loader.
I'm not sure if im abusing the hell out of the webpack pipeline here or not, but either way I'm gonna walk away from this for a while and think about it and play with some stuff.
Sorry, but don't expect this to be added today.

I'm going to be giving up on this for the forseeable future.
I'll leave the issue open, and if anyone comes along that is able to implement something to help solve this i'd be more than happy to work with them, but I just don't have the time to rewrite such a large part of this plugin to do a multi-pass optimization like that.
I recently added the option to optimize images only over a specific size, so as a "hacky" fix you can set this plugin to only apply to images over a given size, then use image-webpack-loader inline to minify those images specifically.
It's not ideal, but I just won't be able to realistically implement this correctly any time soon.


Feature request: Accordions

It would be really nice if we could have fields inside accordions. Here's an example:

What do you guys think?
Maybe an idea for a premium control :-)

This feature is planned, but only after v4.0 is released so it can be built as a separate package. The v4.0 rewrite is already underway on https://github.com/aristath/kirki/pull/2083 and is scheduled for the end of April.

Great news, thank you


Force request context to initialize beforing incepting protocol

Fixes #2384.

AWS is down, ignoring the failed specs.

This fixed the problem, thanks @zcbenz !


Release for ES 7.7.0

Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/7.7/release-notes-7.7.0.html

https://github.com/vvanholl/elasticsearch-prometheus-exporter/releases/tag/<IP_ADDRESS>


PERF-#6332: don't materialize axes in concat operation

What do these changes do?

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #6332
[x] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date

lgtm!
is it possible to add a test (similar to this) verifying that we don't trigger any computation for basic pd.concat() scenarios?

will add

@dchigarev ready for review


Exposed SearchText property and added Action SearchTextChanged

Hi,
Maybe it will be useful to someone as it was useful to me.
Exposing SearchText and SearchTextChanged Action

@enchev - thank you,
one question: how often You're updating demo page? I'm asking, because on example tab https://blazor.radzen.com/dropdown-filtering my changes are not visible yet, but on tab `Edit source' are visible.


readme: update requirements

Overview

I fixed a typo
We use links from beta-docs instead

@noradomi PTAL


Add initial Kueue integration

This PR is to optionally enable Kueue for LMEvalJob by implementing the Kueue's GenericJob interface. It still needs some other functionalities so I want to broke it down a little bit:
1. Kueue requires LMEvalJob  to have Spec.Suspend. We need to handle these 3 suspend cases in the LMEvalJob reconciler:

Spec.Suspend(=true) upon LMEvalJob creation. This means the job is created but pods are running.
Spec.Suspend(=true) while the LMEvalJob is running. This means delete the pods owned by the job.
Spec.Suspend(=false) while the LMEvalJob is in suspended state. This means re-create the pods owned by the job.
See PR#317

2. Get the PodSpec from the LMEValJob.  Currently PodSpec is not stored in the LMEvalJob object.
Kueue needs to admit the job as a kueue.x-k8s.io/v1beta1/Workload. So the Workload can represent the resources (cpu/memory) requirements for the job.
We need the  PodSpec from the LMEvalJob object to create a PodSet for Workload. See PR#323
3. Node Affinity (Need to verify)
Implement these runWithPodInfo and restoreWithPodInfo.
Extract node affinity from from the PodSetInfo object and then overwrite the LMevalJob PodSpec spec affinity. Need to create  another PR to introduce Pod.Spec.NodeAffinity  into LMevalJob

Hi @tedhtchang this is looking great, thanks!
Just a question, we cannot guarantee that Kueue is installed on the cluster. Would enabling Kueue support for LM-Eval (and not having Kueue installed) be a problem?

@ruivieira @yhwang Can you guys change the PR to merge to main branch Or I can close & open a new PR?

Hi @tedhtchang this is looking great, thanks!
Just a question, we cannot guarantee that Kueue is installed on the cluster. Would enabling Kueue support for LM-Eval (and not having Kueue installed) be a problem?

@ruivieira We can start the operator without the job_mgr_controller if Kueue is not enabled. It shouldn't be a problem.

/cc @ruivieira @yhwang Use the controllers/job_mgr/README.md to setup env and test this PR.

Hi @tedhtchang , is this PR rebased on main? If not, is it ok to rebase it? Thank you!

@ruivieira You should merge the PR first because my PR was based on it. After you merged it, I will rebased the main into my PR. Then you should be able to merged mine.

@tedhtchang ack, thanks for the heads up. I've approved https://github.com/trustyai-explainability/trustyai-service-operator/pull/340 now.

@ruivieira @yhwang I rebased and resolved conflicts from main and update-lmevaljob-pod branches.

@ruivieira The controller-test failure was fix. Not sure about the smoke test error. Does it  always fail ?

@ruivieira I saw no difference in go.sum  after go mod tidy. I rebase PR anyway.
however @yhwang found mismatched go.sum in the main branch. This is the output:
go mod tidy
go: downloading golang.org/x/mod v0.12.0
go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.15.2

/retest


⚠ RPC server - Harmony has degraded performance

In f7a577f, RPC server - Harmony ($HARMONY_RPC_URL) experienced degraded performance:

HTTP code: 0
Response time: 0 ms

Resolved: RPC server - Harmony performance has improved in 6710853.


SAA-1467: Auto-remove waitlist applications on released event

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (62568e4) 86.73% compared to head (4b76fd9) 86.73%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #745   +/-   ##
=========================================
  Coverage     86.73%   86.73%
  Complexity     3474     3474
=========================================
  Files           359      359
  Lines         11882    11884    +2
  Branches       1003     1003
=========================================
+ Hits          10306    10308    +2
  Misses         1101     1101
  Partials        475      475

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix(Switch): fixed Switch controlled and borderRadius

Description
Fixed Switch controlled and borderRadius.
Type of change
Please select the relevant option.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Codecov Report

Merging #175 (8bf82ce) into main (e7bb378) will decrease coverage by 0.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   90.77%   90.21%   -0.56%
==========================================
  Files         155      146       -9
  Lines        7386     6503     -883
  Branches     2031     1834     -197
==========================================
- Hits         6705     5867     -838
+ Misses        560      515      -45
  Partials      121      121

Impacted Files
Coverage Δ

packages/tuya-panel-utils/src/index.ts

packages/tuya-panel-utils/src/color.ts

packages/tuya-panel-utils/src/json.ts

packages/tuya-panel-utils/src/temperature.ts

packages/tuya-panel-utils/src/ratio.ts

packages/tuya-panel-utils/src/string.ts

packages/tuya-panel-utils/src/core.ts

packages/tuya-panel-utils/src/time.ts

packages/tuya-panel-utils/src/number.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7bb378...8bf82ce. Read the comment docs.


No access to Windows Drive

Describe the bug
The explorer will not show drive C:\ in the drives list, the related option in Settings is grayed out, and trying to type the path manually returns an "Access Denied" error.
To Reproduce
Steps to reproduce the behavior:

Go to Files UWP
Click on the path bar
Type "C:" and press Enter
See error

Expected behavior
Drive C:\ opens up and I can see the files.
Screenshots
C:\ will not appear:

Option grayed out:

Access Denied Error:

Desktop (please complete the following information):

OS Version: [e.g. Windows 10 1809 17763.1098]
App version: v<IP_ADDRESS>

Additional context
The problem is persistent, the only thing I have not attempted is restarting the machine.

Let me also add that I am the computer administrator, and the computer does not belong in a domain/network, so no special security policies apply.

 Great job :)


Excellent work, let's collaborate (contributing.md missing)

This is a really cool idea, would love to talk to you. I've been working on adjacent concepts and I'd love to chat with you.
Reach out<EMAIL_ADDRESS>

Thank you for your interest. I plan to write a contributing.md file, which will include information and guidelines on how to best contribute and collaborate on this project. 🚀


@broskoski => Deprecate some RSVP functionality(!)

Removes RSVP csv link and replaces it with the informative note linking to Looker/Jenkins. I've shown these to Catherine H and she's comfortable with the flow and is able to pull what she needs.
Also makes the email optional via a UI label (that backend update to silently be chill with that was already live earlier today).

👍


half plots start on lower half of domain away from scalar

Make the plot start spot variable so we can have different plot numbers, ignore first row of plots. use lower half of domain to allow the scalar adequate room to mix

depends on #2


Allow anonymous users to browse public repositories

I think it would be a good idea to allow anonymous users to display the list of public repositories on the home page, instead of asking to login.
Also, I noted that repositories with the "Anonymous" option checked can't be seen in the browser.
I started to work on this feature on this branch :
https://github.com/glacasa/Bonobo-Git-Server/tree/anonymous-listing
but I'm not sure I'm doing it the right way.

Duplicate of #77


Fix registration of agent as event log source

What does this PR do?
Fixes agent regisration.
Motivation
Agent event logs were coming out with the following message instead of the actual
message in the event log:

The description for Event ID 4 from source DatadogAgent cannot be found. Either the component that raises this event is not installed on your local computer or the installation is corrupted. You can install or repair the component on the local computer.

Additional Notes
Anything else we should know when reviewing?

LGTM But maybe we should let someone else review it too.


minor updates

Changes:

add everything that was imported as a dependency (including but not limited to, react, deepmerge, globals, most @chakra-ui components
set up eslint
fixed the rollup missing dependency errors
fixed minor TS type errors
version updates
added CI for ESlint

@LegendaryNaix Could you please explain what is the whole deal with data-sourcepos? The code provides no clues for it (apart from the fact it is an unknown any type).
ESlint requires all types to be specified. I am asking this question due to lack of knowledge and context. What type should data-sourcepos be? What even is GetCoreProps?


Polish main view

There are some issues with main view, notably:

[x] it sometimes gets too wide causing horizontal scrollbar to appear
[x] there are scaling issues when using layout.css.devPixelsPerPx or changing font size in options
[ ] sources list items have variable height depending on badge existence

while I can reproduce first two problems I still can't figure out the reason

currently font size up to 150% and layout.css.devPixelsPerPx up to 1.5 seem to behave properly, setting layout.css.devPixelsPerPx to 2.0 still breaks (but there's not enough place to fit the layout any way so I think such high values can't be supported)

#18 fix for 1st item list

for future reference: Flexbox' min-height and min-width by default equals to the size of content, to allow it to shrink properly these properties have to be overridden


Added multiple answers in Linux section

Thanks @Win32Sector keep doing the  good work :+1:  :100:

@all-contributors please add @Win32Sector  for Interview Question Section


performanceMeasurement.startMeasurement is not a function Error in Type script sample

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
1.4.9
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.4.9
Public or Confidential Client?
Public
Description
Getting issue with type script sample  path for sample download  :microsoft-authentication-library-for-js-dev\samples\msal-react-samples\typescript-sample, cloud not able to proceed further with type script sample , dont know how to fix this error
Error Message
error details Uncaught TypeError: performanceMeasurement.startMeasurement is not a function
at PerformanceClient.startMeasurement (PerformanceClient.ts:123:1)
at BrowserPerformanceClient.startMeasurement (BrowserPerformanceClient.ts:46:1)
at ClientApplication.acquireTokenPopup (ClientApplication.ts:328:1)
at PublicClientApplication.loginPopup (PublicClientApplication.ts:84:1)
at handleLogin (SignInButton.tsx:18:1)
at onClick (SignInButton.tsx:47:1)
at HTMLUnknownElement.callCallback (react-dom.development.js:4164:1)
at Object.invokeGuardedCallbackDev (react-dom.development.js:4213:1)
at invokeGuardedCallback (react-dom.development.js:4277:1)
at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:4291:1)
Please let me know how to fix this issue as soon as possible
Msal Logs
n/a
MSAL Configuration
auth: {
        clientId: "clientId",
        authority: "https://login.windows-ppe.net/common",
        redirectUri: "",
        postLogoutRedirectUri: "/"
    }

Relevant Code Snippets
n/a

Reproduction Steps
n/a
Expected Behavior
n/a
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Chrome
Regression
@azure/msal-browser": "^2.30.0"
Source
Internal (Microsoft)

Facing the same issue. Kindly let us know when can this be fixed or any other workarounds.

Having the same issue with my Angular app (@azure/msal-browser": "^2.28.0)
TypeError: c.startMeasurement is not a function     at n.startMeasurement (main.170c67012d4545f5.js:1:1231498)     at t.startMeasurement (main.170c67012d4545f5.js:1:1436828)     at t.<anonymous> (main.170c67012d4545f5.js:1:1369813)     at f (main.170c67012d4545f5.js:1:379297)     at Object.next (main.170c67012d4545f5.js:1:379402)     at main.170c67012d4545f5.js:1:378337     at new E (polyfills.17058541d81afe21.js:1:18860)     at _n (main.170c67012d4545f5.js:1:378072)     at t.getDiscoveredAuthority (main.170c67012d4545f5.js:1:1369584)     at t.<anonymous> (main.170c67012d4545f5.js:1:1368368)

Just updated my angular app and got the same problem.
File header of PerformanceClient.js says: /*! @azure/msal-common v9.1.0 2023-01-18 */

is there going to be any fix for this? or a workaround?

Should we roll back a version here?

Found this here: https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/5582

"@azure/msal-browser": "^2.30.0", "@azure/msal-react": "^1.5.2"
We did a rollback and app is running fine.

For Angular I used those two versions to make it work again:
"@azure/msal-angular": "^2.5.2" and "@azure/msal-browser": "^2.32.1"

In React we did a rollback in "@azure/msal-common": "9.1.0" to "@azure/msal-common": "9.0.2" and it works like a charm.
The msal-browser we use : "@azure/msal-browser": "2.32.2"

In React we did a rollback in "@azure/msal-common": "9.1.0" to "@azure/msal-common": "9.0.2" and it works like a charm. The msal-browser we use : "@azure/msal-browser": "2.32.2"

Thank you! Been banging my head against the wall 😅

The issue was really caused by us using the non explicit versioning for msal-browser. 2.32.2 seems to be the culprit so using 2.32.1 with "@azure/msal-react": "^1.5.2".
Just remember to use explicit versioning and target version "@azure/msal-browser": "2.32.1" WITHOUT the "^" symbol in conjunction with the version number.
Most likely the cause that is making this issue emerge.
The faulty MSAL version gets released, pipeline runs, faulty version gets deployed and the issue occurs.
Thanks for all the help in this thread!

@jo-arroyo it seems you updated PerformanceClient but it didn't fixed yet please confirm

@jo-arroyo whats the status on this issue?
Obviously broken and still unconfirmed?

@jo-arroyo it seems you updated PerformanceClient but it didn't fixed yet please confirm

@jo-arroyo whats the status on this issue? Obviously broken and still unconfirmed?

Doesn't look like the PR has been merged yet if you look at #5589

For me the following versions worked in Angular.
"@azure/msal-angular": "2.5.1",
"@azure/msal-browser": "2.32.1",

Hi all, yes this is a confirmed bug that we are working on fixing. Please downgrade until the next release is available.
@pascalgross @mohd7469 @kotacode

First a breaking defect in the App Insights SDK and then this...
Were all the Azure JS testers part of the layoffs this week?

Thank you all for your patience. Msal-common v 9.1.1 has been released. Please upgrade and let us know if you continue to see issues.

Closing as msal-common v9.1.1 release addresses these issues. Please open a new issue if you continue to see errors.


patch: adding epsagon lib version to traces

:tada: This PR is included in version 1.20.1 :tada:
The release is available on:

GitHub release
v1.20.1

Your semantic-release bot :package::rocket:


MB-3098 Switch all stories from the storiesOf format to the CSF format

Description
This branch switches the stories files in the project over to CSF (Component Story Format), as the storiesOf format is being depreciated eventually.
Reviewer Notes
I adjusted any .stories.jsx file I came across. If there is one you worked on that I messed up in some way, let me know!
Setup
yarn install
yarn storybook

Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
CSF format spec documentation explains more about the approach used.

Screenshots
N/A

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-3098

  Generated by :no_entry_sign: dangerJS against d88ffef3e819660892a939877bda1d5259c7f57f

The only thing we might want to make the switch to is using the forward slash/ to separate component names eventually as that's the default https://storybook.js.org/docs/basics/writing-stories/#story-hierarchy.  Seems like the TOO/TIO grouping would be in conflict with this.

The only thing we might want to make the switch from using the | to using the forward slash/ to separate component names eventually as that's the default https://storybook.js.org/docs/basics/writing-stories/#story-hierarchy. Seems like the TOO/TIO grouping would be in conflict with this.

If the forward slash is more in line, we could rename TOO/TIO to be TXO to get around the conflict, which is the term we've been using in planning artifacts when we're referring to both things. I think that started being used sometime after we started doing work in storybook.


Remove stabilized alloc feature gate.

Metadata
related to: #1038
required rustc version bump: from v1.31 to v1.36
Content
The alloc feature got stabilized in rustc v1.36 and it is therefore possible to remove the feature gate and compile the crate with alloc feature enabled with the stable toolchain.
... fixes #1038

this will go in nom 6 since it raises the minimum Rust version

wait, as you said in https://github.com/Geal/nom/issues/1038#issuecomment-558131986 this would only afect nightly Rust versions, so it should be safe to remove the feature gate

This is blocking me

thanks!


Additional Viewer Enhancements

Adding simple distance measurement ability to the 3D view of the Viewer:

Addressed code review comments and added some extra functionality -

Finally found and fixed heap corruption on viewer close
SHIFT allows to continue measuring more than one segment
Measuring a closed loop will calculate and display area
Ctrl+Z can be used to undo changes
A bit improved mouse control, to avoid confusion during pan and zoom and highlight selected points & line segments


[Question] How to add new font ?

By default Decker comes with three fonts. It seems new fonts needs to be added from other decks containing (there is an example deck available in the distribution) using File -> Resources.
a. Is there a way to add system fonts easily inside Decker ? What is the preferred way ?
b. For every font size is it required to add a new font?

a) There is no way to directly import system fonts into Decker; Decker has its own format for bitmapped fonts. See the discussion in this forum post for details.
b) Every decker font consists of a collection of glyphs with one size.


Nvidia cuda vs Conda cuda

Hi, why do this library requires cuda installed on the machine, and not use the cuda installed on anaconda?

Hi,
nndet uses CUDAExtension from PyTorch to build the CUDA code in this repository. According to this the conda package only contains a subset of the official CUDA installation. E.g. it does not provide the nvcc compiler that will be used to compile the CUDA code (there is a guide from pytorch).
Best,
Michael

Thanks for your answer, this means that in a cluster where no nvidia cuda is installed (only conda cuda), the code can not be compiled?

At least I'm not aware of a way to use it with conda cuda right now, sorry. Generally speaking, the docker setup of nnDetection is probably the most straightforward one since it already packs all the CUDA requirements and only requires compatible Nvidia GPU drivers (requires docker support on the cluster though).


Touch controls on Android not functioning when built properly

Android touch controls don't function seemingly at all when used in a finished apk.
To reproduce:
Single scene in the build settings, containing a camera with an ortho view and a near clipping plane of 0, and a single sprite with the following hook on update:
(defn box-hook
  [this]
  (when (> (count Input/touches) 0)
    (set! (.position (.transform this)) (.ScreenToWorldPoint
                                         Camera/main
                                         (let [pos (.position (first Input/touches))]
                                           (Vector3. (.x pos) (.y pos) 0))))))

Building is done while connected to the device in developer mode after ensuring the android build post-process does not occur in arcadia, and the following code is run in the repl:
(use 'arcadia.compiler)
(aot-namespaces "Assets/Compiled" '[clojure.core game.core])

The resulting .apk should be send to the android device just fine, and run as well, but any touch controls will not function.
NOTE: The above setup works perfectly when using unity remote, touch controls are received properly and can be manipulated any way desired.

Not sure if this is an android specific issue. It might be related to #323 which we have confirmed is happening. Its likely that hooks are being dropped before export as well, resulting in scenes with no clojure code in the exported game.
I tested first on the desktop with
(ns issue-248
  (:import [UnityEngine Input Vector3 Camera])
  (:use arcadia.core))

(defn box-hook-mouse [this k]
  (set!
    (.position (.transform this))
    (.ScreenToWorldPoint Camera/main
                         (let [pos Input/mousePosition]
                           (Vector3. (.x pos) (.y pos) 10)))))

with box-hook-mouse attached to a cube. It replicated the posed code above but uses a mouse as input. The game builds, launches and runs without error, and the hooks disappear in the inspector.
On Android I tested with
(ns issue-248
  (:import [UnityEngine Input Vector3 Camera])
  (:use arcadia.core))

(defn box-hook [this k]
  (when (> (count Input/touches) 0)
    (set!
      (.position (.transform this))
      (.ScreenToWorldPoint Camera/main
                           (let [pos (.position (first Input/touches))]
                             (Vector3. (.x pos) (.y pos) 10))))))

with a similar setup as on desktop. Again, everything built and ran without errors, and adb logcat was clean.

This is actually looking like a compiler bug. With #323 fixed, running the above code on Android throws the following in adb logcat
2018-12-07 17:29:26.237 1278-1300/? E/Unity: ArgumentException: The specified path is not of a legal form (empty).
      at System.IO.Path.InsecureGetFullPath (System.String path) [0x00025] in <f2e6809acb14476a81f399aeb800f8f2>:0
      at System.IO.Path.GetFullPath (System.String path) [0x00000] in <f2e6809acb14476a81f399aeb800f8f2>:0
      at System.AppDomainSetup.GetAppBase (System.String appBase) [0x00041] in <f2e6809acb14476a81f399aeb800f8f2>:0
      at System.AppDomainSetup.get_ApplicationBase () [0x00000] in <f2e6809acb14476a81f399aeb800f8f2>:0
      at System.AppDomain.get_BaseDirectory () [0x00006] in <f2e6809acb14476a81f399aeb800f8f2>:0
        at (wrapper remoting-invoke-with-check) System.AppDomain.get_BaseDirectory()
      at clojure.lang.RT+<GetFindFilePathsRaw>d__424.MoveNext () [0x00038] in <138b9d0b0b3f4982b42abdb2b77eda11>:0
      at System.Linq.Enumerable+DistinctIterator`1[TSource].MoveNext () [0x00028] in <10ab7516b28e47f29e5315b70b0be54c>:0
      at clojure.lang.RT.FindFile (System.String fileName) [0x00021] in <138b9d0b0b3f4982b42abdb2b77eda11>:0
      at clojure.

The full thing is here

As of 0689ff6af6772ffbe111b530f6bca45583708699 the android code I posted above exports and functions as expected


Add support to angular 6.0.0-alpha

Because ng_bootstrap 1.1.1 depends on angular ^5.1.0 and no versions of ng_bootstrap match >1.1.1 <2.0.0, ng_bootstrap ^1.1.1 requires angular ^5.1.0.
So, because app depends on both ng_bootstrap ^1.1.1 and angular ^6.0.0-alpha, version solving failed.

Any release date?

I'm working on it, please check this branch:
https://github.com/dart-league/ng_bootstrap/tree/upgrade-ng-6.0.0-alpha

solved by #130


2.17.0 upgrade

WIP upgrade.

Closing this in favor of branch 2.17.0-update, too many whitespace issue.


Redirecting to /undefined when option is selected

Hey! I have a simple select-picker:
<select name="nome" id="nome" class="select-picker form-control" data-live-search="true">
       <option selected disabled>Selecione um cliente</option>
        <option value="a"> Angelica Rodrigues</option>
        <option value="a"> Carlos Santos</option>
        <option value="a"> Debora Goettems</option>
        <option value="a"> Ricardo Goettems</option>
        <option value="a"> Vitor Régis</option>
   </select>

And i'm simply starting select-picker in the end of the doc.
$('.select-picker').selectpicker();
I'm using bootstrap 4.1 and jquery 3.2.1
In a isolated test case it's working correctly, i'm searching for a few hours and i just dont have idea why is that ocurring.
I've already tryied to create my on prevent redirecting but it's not working.
$('a[role="option"]').click(function(e) {
  e.preventDefault();
  e.stopPropagation()
});

But when i click on a option, its redirect to /undefined. Anyone knows why?

What browser? What version of bootstrap-select? If you inspect the elements in the menu, is the href attribute somehow set on the  elements?

Version: 1.13.5
Browser: Chrome
Has HREF Property: No, there isnt that propert.

What's different between your isolated test case and your actual usage? Are you using using a framework like Angular, Ember, or Vue?

No. I just tryied an isolated case because the rules of opening an issue asked to try it.

And it works correctly if bootstrap-select is disabled? Without a way to view a demo of the issue, I won't be able to help.

Hi Casey,
I have a problem like this, I checked all of my files and i can't find something wrong. Most probably an other js file causing this problem.
I can give a demo link for you. Could you look it for the solution?
Link: click

@ilkerkocatepe It has to do with something else you're loading. As a test, try just adding:
Click Here

If you click that link, the page redirects to undefined. That is not normal behavior. Also, unrelated, but you have an open


Explanation of "named parameters" for arguments input

The documentation for the arguments: input for the bash task is as follows:

(Optional) Arguments passed to the Bash script. Arguments passed to the shell script. Either ordinal parameters or named parameters

I understand that ordinal parameters would be parsed by the bash script as $1, $2, etc., but what is meant by named parameters?
I assume this might mean passing in something like environment="dev", but as far as I know bash doesn't support this type of argument natively - I would normally use environment variables with the env: input for that, or would have to write extra logic into the script.
Can you clarify how named parameters are supported or expected to be used?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 450ac349-5c33-6cdf-1ecd-6eb989a00334
Version Independent ID: a7119c1a-59b2-3081-a241-e93aa0d6b4b9
Content: Bash task - Azure Pipelines
Content Source: docs/pipelines/tasks/utility/bash.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @vtbassmatt
Microsoft Alias: macoope

Whoops. Looks like a copy-paste from some other task that definitely doesn't belong. Thanks!


Question about format_query_value()

Hello.
I have a question: Why function format_query_value() wraps a result to quotes ''? This behaviour makes it impossible to make complex queries with optional (empty) WHERE parts. Is it possible to change format_query_value() to make return result without quotes?
Thank you.

Do you have some sample code and the query that is incorrectly formatted?  That function is only used in format strings and for SQLAlchemy, so avoiding it should be possible.

@genzgd
Something like this:
ch.query(
            """
            SELECT
                formatDateTime(started_at, '%%m/%%d/%%Y', %(time_zone)s) AS date,
                formatDateTime(started_at, '%%I:%%M:%%S %%p %(time_zone)s', %(time_zone)s) AS time,
                format('{}path/link?name={}&sn={}', %(portal_url)s, label, camera_sn) AS url,
                camera_name,
                description
            FROM recordings
            WHERE
                stack = %(stack)s
                %(where_company)s
                %(where_camera)s
                %(where_reviewed)s
                %(where_started_at)s
            ORDER BY started_at ASC
            """,
            {
                'time_zone': time_zone,
                'portal_url': 'http://example.com/',
                'stack': 'example',
                'where_company': f"AND company_id = '{company_id}'" if company_id != settings.DEFAULT_COMPANY else '',
                'where_camera': f"AND camera_sn = '{camera_id}'" if camera_id else '',
                'where_reviewed': "AND reviewed = true" if reviewed else '',
                'where_started_at': f"AND started_at BETWEEN {from}/1000 AND {to}/1000" if (from and to) else '',
            },
        ).result_set

There are next problems:
formatDateTime(started_at, '%I:%M:%S %p 'UTC'', 'UTC') AS time,
and
WHERE
    stack = 'example'
    ''
    ''
    ''
    'AND started_at BETWEEN<PHONE_NUMBER>123/1000 AND<PHONE_NUMBER>123/1000'
ORDER BY started_at ASC

The format_query_value function is intended to format single values to ClickHouse SQL from native Python datatypes (that's why strings are quoted).  It has very simple logic and isn't designed for nesting or server side parameterization.
For a complex query like that I would suggest formatting everything but single values ClickHouse values in your application code before sending to the driver.
Is there another tool you use (perhaps from another database) where that kind of formatting works?  I would certainly be open to expanding the query substitution functionality but I wouldn't even know where to start with the source query you have.  If there was some logic from another tool we could take a deeper look.

If I format a complex server-side query into a single SQL query with no parameters, this will lose the SQL injection protection from the clickhouse_connect library.

You can still format the query with parameters, they just have to be a single Python value.  And it is safe to build and format a complex query as long as you don't include any unsanitized user input when building the query.  The key is to sanitize your user input -- i.e., validate that the time_zone value is a valid timezone, validate that the company_id and camera_id values are valid values (either by parsing the string or comparing against a lookup table, etc.) and not weird SQL phrases.
It is NOT safe to assume that passing your query through the finalize_query function will protect you from SQL injection attacks.  (In fact, the main protection it offers is escaping strings and putting them in quotes, the behavior you don't like).  ClickHouse Connect is a low level driver library that does no independent SQL validation and merely formats SQL that ClickHouse itself will parse.
Also unlike other databases, ClickHouse itself has no built in support for prepared statements and query statements/plans are not persisted on the server. Accordingly, with ClickHouse Connect (and most other ClickHouse libraries), it remains the responsibility of the application developer to ensure that only safe queries are sent to the ClickHouse server.
ClickHouse does have support for passing parameters via the query itself -- see https://clickhouse.com/docs/en/interfaces/http/#cli-queries-with-parameters.  Those are safe on the server side, but

ClickHouse Connect does not currently implement that functionality directly (it is planned for a future release)
Like the format_query_value, those parameters can only be used for a single ClickHouse column value, they do not work inside other text strings  (like your formatDateTime argument), and cannot be used to replace an entire SQL phrase.

Also see this issue in the popular native protocol based Python driver:  https://github.com/mymarilyn/clickhouse-driver/issues/13.  That driver uses essentially the same parameterization approach as ClickHouse Connect.  As discussed above, it is not 100% foolproof, but it does prevent most basic SQL Injection attacks.


Package react-scripts is installed as not a dev dependency

Is this a bug report?
Yes

Can you also reproduce the problem with npm 4.x?

Yes
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

node -v: 8.0.0
npm -v: 5.0.3
yarn --version (if you use Yarn):
npm ls react-scripts (if you haven’t ejected): 1.0.10
create-react-app --version: 1.3.3

Then, specify:

Operating system: macOS Sierra
Browser and version (if relevant):

Steps to Reproduce

nvm use 8
npm install --global create-react-app
create-react-app test-app
cd test-app
cat package.json

Expected Behavior

Package react-scripts should appear in devDependencies section
Actual Behavior

Package react-scripts appears next to react-dom in dependencies section.
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

This is intentional and was made in v1.0.8. See #2657

This is intentional as your application relies on polyfills provided by the package, warrantying a dependency.
As a side effect, deploying to Now and Heroku is easier.

@gaearon, what was the reasoning for this change? I found it pretty confusing (so I opened the ticket) since it's expected behavior after 6+ years of using NPM.

It fixes deployment issues on some hosting providers that assume only dependencies are needed for the build. The line is also very thin in frontend development. None of them are "runtime" dependencies because we don't have a server and they all get bundled into a single file. So if we were pedantic then we would have to declare everything as devDependencies, including React itself. I just figured that it's not worth conceptual overhead anyway since distinction is largely arbitrary. For example polyfills could be categorised as either.

It fixes deployment issues on some hosting providers that assume only dependencies are needed for the build.

Couldn't it be done as just a part of Deployment/Troubleshooting part in README then?

Sure, but we generally try for more things to work out of the box.
This is a good example of an issue that can be debated endlessly because there's very little technical arguments for and against. I've made a choice there and if you disagree, you can always move those few lines.

The polyfills should be moved out to a "react-polyfills" package, then. "scripts" does not imply polyfills.

What technical problem are you having?

Semantics.

You can move it in your package.json and then there is no problem.
Again, unless you’re building a Node.js app, the most correct semantics would be to put everything into devDependencies including react and any libraries you’re using. But there are practical reasons why this is undesirable so we just went with the opposite approach.

react is a dependency because it is included in the final build. A polyfill, such as one for something like <details> would be treated the same. Something like babel is not, and is therefore a devDependency. I'd put something like babel-polyfill in devDependencies. With that, react-scripts belongs there too.

If you are using npm, run this command will move all packages except React into devDependencies.
$ npm i voy -g && voy mg '^(?!react)'


error while creating first snapshot

ubuntu@ip-172-31-24-161:~/keras-fashion-mnist$ datmo snapshot create -m "creating my first snapshot"
Creating a new snapshot
An exception occurred: Commit ref given does not match a git commit within the tree: 992a942e2a3393922991907e222440f6b9a0c973

seems like this has been fixed once a user has created a file, however it seems like an anomalous line "fatal: your current branch 'master' does not have any commits" is still shown in the output. see below
Creating a new snapshot
fatal: your current branch 'master' does not have any commits yet
INFO: Successfully saved requirements file in /Users/anandsampat/Downloads/datmotest/requirements.txt
Created snapshot with id: ba6d7dd5455c47055b9d6f788954a96e80bb7cf1

9312d9d : all stderr and stdout for git code driver is piped to outputs that can be manipulated in the code using subprocess.Popen. the errors from the subprocesses are only displayed if we raise an error. we can change that functionality as needed.

fixed with PR #115


Tutorials to load any relational database

Does relbench provide support for loading a custom relational database? or we can play around only with the two datasets available in the datasets library?

Tutorials on working with custom datasets and tasks have been added. Please see README.


MySQL events are not recorded in mysql_events table for Java

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
I deployed a java application connecting the MySQL database in Azure. I initially verified with this go application and it successfully recorded events in the tables. The Java application code is as below
import java.sql.*;

public class App {
    static final String DB_URL = "jdbc:mysql://<host>:3306/pixie";
    static final String USER = "<user>";
    static final String PASS = "<password>";
    static final String QUERY = "SELECT * FROM Persons";

    public static void main(String[] args) {
        // Open a connection
        try(Connection conn = DriverManager.getConnection(DB_URL, USER, PASS);
            Statement stmt = conn.createStatement();
            ResultSet rs = stmt.executeQuery(QUERY);) {
            // Extract data from result set
            while (rs.next()) {
                // Retrieve by column name
                System.out.print("PersonId: " + rs.getInt("PersonId"));
                System.out.print(", FirstName: " + rs.getString("FirstName"));
                System.out.print(", LastName: " + rs.getString("LastName"));
                System.out.println(", Address: " + rs.getString("Address"));
                System.out.println(", City: " + rs.getString("City"));
            }
        } catch (SQLException e) {
            e.printStackTrace();
        }
    }
}

Expected behavior
MySQL events should be recorded in mysql_events
Screenshots
If applicable, add screenshots to help explain your problem. Please make sure the screenshot does not contain any sensitive information such as API keys or access tokens.
Logs
Please attach the logs by running the following command:
[pixie_logs_20220705161453.zip](https://github.com/pixie-io/pixie/files/9045679/pixie_logs_20220705161453.zip)

App information (please complete the following information):

Pixie version 0.7.13+Distribution.8209092.20220615085155.1
K8s cluster version - v1.25.2
Node Kernel version
Browser version Version 103.0.5060.53

When I disable the tls connection, the mysql_events table was populated. I think the issue is with the secured connections.

@LakshanKarunathilake from the sample code you shared it's not clear to me that tls is being used. Can you explain how you are disabling it?
I ask because I'm curious what tls library your code is using. If it's based on netty the work I'm doing in #407 could make this possible (although it's not complete yet).

@ddelnano I used the ?useSSL=false


CORS enabled but IPFS station still says that node is not running

my daemon is set to listen on 8082 and 5001, so I set ports accordingly in settings.

My fault.


Made some changes to the application.scss file

Solves the issue #815 .
@mariobehling  @aayusharora
Here is the link to the gh-pages
https://princu7.github.io/websiteTest/speakers.html

Current coverage is 42.58% (diff: 100%)

Merging #833 into development will not change coverage

@@           development       #833   diff @@
=============================================
  Files                6          6
  Lines              735        735
  Methods             74         74
  Messages             0          0
  Branches           118        118
=============================================
  Hits               313        313
  Misses             422        422
  Partials             0          0

Powered by Codecov. Last update c740389...2753484

The result of this change is, that in normal view the width of the dropdown speaker info is reduced. There is no reason to reduce the width in larger resolutions.

Larger width as right now is fine (see below).

A problem I see in this dropdown box is also that the line around the box is missing at the corners.

@mariobehling Thanks for pointing out the issues. I will correct them right away.

I made some changes. Please have a look at my gh-pages and review it. Thanks.
https://princu7.github.io/websiteTest/speakers.html

Thank you. On the top right and bottom right, the corner lines are still not completely closed. Is is possible to fix this?

@mariobehling I am sorry. I tried hard to look for the cause of it but couldn't find it.  I have updated my pull request to the previous point( having the changes you mentioned). Suggest further course of action.

@aayusharora Can this PR be merged?

Merging. Let's follow up on open questions in future PRs.


Added Signup api

Related Issuse
#17

Info about Issue or bug
successfully added signup API and it is working fine, after this sign in API is also ready
Closes: #17(1st task is done)

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

@maw1a Please review this pr

Just return the token in the response.

okay

This seems fine. Good work 👍
Just add the JWT in the returning response.
Maybe you can create issues for integration of Storage bucket and about profile picture (u mentioned this in the User Schema)

yes, in the future I would love to work not the integration of more features but for now, this project is it's initial phase, so I think it is enough for now. Thanks :)


Should we use numerical prefix ordering only for documentation pages?

Consider if we should use numerical prefix ordering only for documentation pages (does it offer value in other places, docs are especially hierarchical)

Based on the code provided, I'll analyze whether numerical prefix ordering should be limited to documentation pages only. Here's my analysis:
Current Implementation
The numerical prefix ordering feature is currently implemented globally and works for both documentation pages and regular pages. Key evidence:
### Numerical Prefix Sidebar Ordering

HydePHP v2 introduces sidebar item ordering based on numerical prefixes in filenames. This feature works for the documentation sidebar.

This has the great benefit of matching the sidebar layout with the file structure view. It also works especially well with subdirectory-based sidebar grouping.

```shell
_docs/
  01-installation.md     # Priority: 1
  02-configuration.md    # Priority: 2
  03-usage.md            # Priority: 3
```

As you can see, Hyde parses the number from the filename and uses it as the priority for the page in the sidebar, while stripping the prefix from the route key.

This shows the feature is documented for documentation pages specifically.
    public function testFlatMainNavigationOrdering()
    {
        $this->setupFixture([
            '01-home.md',
            '02-about.md',
            '03-contact.md',
        ]);

        $this->assertOrder(['home', 'about', 'contact']);

The tests show it's implemented for both main navigation and documentation sidebar.
Benefits of Current Approach

Consistency across the site
Single implementation that works everywhere
Flexibility for users who want ordered navigation anywhere

Why Documentation Pages are Different

Documentation is inherently hierarchical and ordered
Documentation often needs strict ordering for learning progression
Documentation commonly uses nested directories for chapters/sections
The sidebar navigation is more prominent and important for docs

Evidence of Documentation-Specific Usage
```shell
_docs/
  01-installation.md     # Priority: 1
  02-configuration.md    # Priority: 2
  03-usage.md            # Priority: 3
```

The example shows how numerical prefixes are particularly useful for documentation organization.
Recommendation
I recommend keeping numerical prefix ordering available globally but:

Only actively document and promote it for documentation pages
Add a configuration option to scope it to documentation pages only
Consider making it documentation-only by default in a future major version

Proposed config addition:
// config/hyde.php
'numerical_page_ordering' => [
    'enabled' => true,
    'documentation_only' => true, // New option
],

Rationale

Documentation is where the feature provides the most value due to:

Need for strict ordering
Hierarchical nature
Learning progression importance
Prominence of sidebar navigation

Regular pages rarely need strict ordering since:

Main navigation is typically simpler
Order is often less critical
Front matter priorities work well enough
Navigation menus are usually flat

Keeping but scoping the feature:

Maintains backward compatibility
Provides flexibility when needed
Reduces potential confusion
Better aligns with principle of least surprise

This approach would simplify the mental model while preserving flexibility for edge cases where numerical ordering might be useful outside documentation.

Based on the provided code, I'll analyze whether numerical prefix ordering should be limited to documentation pages or kept for all page types. Let me break this down:
Current Implementation
The numerical prefix ordering feature is currently implemented for both documentation pages and main navigation items, as seen in:
## Numerical Prefix Navigation Ordering

HydePHP v2 introduces navigation item ordering based on numerical prefixes in filenames. This feature works for the primary navigation menu.

This has the great benefit of matching the navigation menu layout with the file structure view. It also works especially well with subdirectory-based navigation grouping.

Benefits of Current Approach (All Pages)

Consistency: Using the same ordering system across all page types provides a consistent mental model for developers.

File Structure Matching: As mentioned in the documentation, it matches the navigation menu layout with the file structure view.

Test Coverage: The feature is well-tested for both documentation and main navigation scenarios, as shown in:

    public function testFlatMainNavigationOrdering()
    {
        $this->setupFixture([
            '01-home.md',
            '02-about.md',
            '03-contact.md',
        ]);

        $this->assertOrder(['home', 'about', 'contact']);
    }

    public function testReverseOrderOfFlatMainNavigation()
    {
        // This is just a sanity check to make sure the helper is working, so we only need one of these.
        $this->setupFixture(array_reverse([
            '01-home.md',
            '02-about.md',
            '03-contact.md',
        ]));

        $this->assertOrder(['home', 'about', 'contact']);
    }

    public function testGroupedMainNavigationOrdering()
    {
        $this->setupFixture([
            '01-home.md',
            '02-about.md',
            '03-contact.md',
            '04-api' => [
                '01-readme.md',
                '02-installation.md',
                '03-getting-started.md',
            ],
        ]);

        $this->assertOrder(['home', 'about', 'contact', 'api' => [
            'readme', 'installation', 'getting-started',
        ]]);
    }

Case for Documentation-Only

Natural Hierarchy: Documentation pages inherently have a more hierarchical structure that benefits from numerical ordering:

```shell
_docs/
  01-installation.md     # Priority: 1
  02-configuration.md    # Priority: 2
  03-usage.md            # Priority: 3
```

Common Use Case: The examples and tests show this feature being particularly valuable for documentation organization:

```shell
_docs/
  01-getting-started/
    01-installation.md
    02-requirements.md
    03-configuration.md
  02-usage/
    01-quick-start.md
    02-advanced-usage.md
  03-features/
    01-feature-1.md
    02-feature-2.md
```

Complexity vs Value: Regular pages (like blog posts, landing pages) typically don't require such strict ordering, and their navigation is often simpler.

Recommendation
I recommend limiting numerical prefix ordering to documentation pages only for the following reasons:

Focused Purpose: Documentation is where this feature provides the most value due to its inherently hierarchical nature.

Reduced Complexity: Limiting the feature reduces cognitive load for users who don't need this functionality for regular pages.

Better Defaults: Most sites don't need complex ordering for their main navigation, and can use simpler priority settings when needed.

Documentation Focus: The feature seems to have been primarily designed with documentation in mind, as evidenced by the extensive documentation and test cases focused on documentation scenarios.

Implementation Suggestion
To implement this change:

Modify the NumericalPageOrderingHelper to only process numerical prefixes for DocumentationPage instances.
Update the documentation to clarify this feature is specific to documentation pages.
Keep the configuration option numerical_page_ordering but make it only affect documentation pages.

This would make the feature more focused and easier to maintain while preserving its most valuable use case.
Would you like me to provide specific code changes to implement this recommendation?

I agree with the last analysis, I want to really limit the cognitive load here.

To be honest, do we actually need the config option for numerical page ordering? Is there a scenario where the user would want to use numerical prefixes and not have them sorted by that?

That's a really good point! Let me analyze this:
Current Use Cases for Disabling the Feature

Looking through the codebase and tests, there's no clear use case where someone would want numerical prefixes but not use them for ordering
The config option seems to exist mainly as an escape hatch, following the "customizable when you need it" principle
The only scenario might be if someone migrated content with numerical prefixes but didn't want to reorder their navigation - but they could just remove the prefixes

Arguments Against Having the Config Option

Principle of Least Surprise: If a file has a numerical prefix, it's reasonable to expect it to affect ordering
Reduced Complexity: Removing the config option simplifies the codebase
Clear Intent: The presence of numerical prefixes in filenames clearly signals the intent to order them
Documentation Simplification: One less configuration option to document and maintain
Testing Reduction: We can remove tests checking the disabled state

Code Impact
Here's how we could simplify the NumericalPageOrderingHelper:
<?php

declare(strict_types=1);

namespace Hyde\Framework\Features\Navigation;

use Hyde\Pages\DocumentationPage;
use Illuminate\Support\Str;

class NumericalPageOrderingHelper
{
    /** @var array<string> The delimiters that are used to separate the numerical prefix from the rest of the identifier. */
    protected const DELIMITERS = ['-', '_'];

    /** Check if the page is a documentation page. */
    public static function enabled(string $pageClass = null): bool
    {
        return $pageClass !== null && is_a($pageClass, DocumentationPage::class, true);
    }

    // ... rest of the methods remain unchanged
}

Recommendation
I recommend removing the config option because:

It follows the principle of least surprise
Reduces complexity in the codebase
Makes the feature's behavior more predictable
If users don't want numerical ordering, they can simply not use numerical prefixes

Fixed by https://github.com/hydephp/develop/pull/1997


Support passing pkg-config a triple-specific env variables

It should mimic cargo use of triples for the compiler env.

Do you have some examples how this would be used in practice?

in rav1e we tripped in a situation in which an user sets PKG_CONFIG_PATH to a cross-build path and somehow it trips since our build.rs that requires to link host stuff.
In would be good to have a mean to have different search paths per target to avoid the or even just have a HOST_/TARGET_ split.

Ideally you would invoke pkg-config yourself with the right env vars, instead of having pkg-config understand build / host etc. This also allows you to extend the same to other dependency search tools like cmake and qmake. This is exactly what meson does: --build.pkg-config-path --build.cmake-prefix-path vs --pkg-config-path --cmake-prefix-path.

even just have a HOST_/TARGET_ split.

Looks like pkg-config-rs, used by system-deps already support HOST/TARGET env variables. Would this do or what are you looking for exactly?

Probably it does, I opened the issue to forward the concern a rav1e user had.

Hit the same issue - how about https://github.com/termux/termux-packages/pull/20209 ?


segfault due to missing path due to boost

In a docker container it's common to run with / as base directory and without any /home at all.
In that case, lightgbm segfaults, sometimes saying why like this:
import numpy as np
import pandas as pd
import lightgbm as lgb
X1= np.repeat(np.arange(10), 1000)
X2= np.repeat(np.arange(10), 1000)
np.random.shuffle(X2)
y = (X1 + np.random.randn(10000)) * (X2  + np.random.randn(10000))
data = pd.DataFrame({'y': y, 'X1': X1, 'X2': X2})
lgb_params = {'learning_rate'    : 0.1,
                   'boosting'         : 'dart',
                   'objective'        : 'regression',
                   'metric'           : 'rmse',
                   'feature_fraction' : 0.9,
                   'bagging_fraction' : 0.75,
                   'num_leaves'       : 31,
                    'bagging_freq'     : 1,
                   'min_data_per_leaf': 250, 'device_type': 'gpu', 'gpu_device_id': 0}
cv = lgb.cv(lgb_params,
                   lgb_train,
                   num_boost_round=100,
                   early_stopping_rounds=15,
                   stratified=False,
                   verbose_eval=50)

output:
[LightGBM] [Info] This is the GPU trainer!!
[LightGBM] [Info] Total Bins 20
[LightGBM] [Info] Number of data: 8000, number of used features: 2
[LightGBM] [Info] Using GPU Device: TITAN X (Pascal), Vendor: NVIDIA Corporation
[LightGBM] [Info] Compiling OpenCL Kernel with 16 bins...
  This seems bad practice in general to need to write to disk, although this seems to be how boost works.
Question is whether lightgbm has way to tell boost which cached path to use so there is sufficient control.  Also, lightgbm segfaulting in this case is pretty bad.

https://boostorg.github.io/compute/boost_compute/getting_started.html
Looks like the option BOOST_COMPUTE_USE_OFFLINE_CACHE can be set to 0 to avoid these caches, and for large data compiling the kernel doesn't take a long time (1 second).

https://github.com/Microsoft/LightGBM/blob/master/src/treelearner/gpu_tree_learner.h#L25
But by default it seems lightgbm forces disk cache to be used.

ping @huanzhang12 to follow up

The path for Boost.Compute path is hard coded in the library and cannot be easily changed. I think we can mention this issue in document, and encourage the user to unset BOOST_COMPUTE_USE_OFFLINE_CACHE when observing problem with Boost library. Another benefit of doing so is that by disabling the compute cache, Boost.Compute will not depends on Boost.FileSystem and Boost.System any more, avoiding issues like #1508.

The path is determined here:
https://github.com/boostorg/compute/blob/master/include/boost/compute/detail/path.hpp#L31-L48
Ideally, we should submit pull requests to Boost.Compute upstream and make these functions more robust, i.e., disable the cache automatically and don't crash if the filesystem goes wrong.


variable.py as_compatible_data: allow DataArrays too

[ ] Closes #4483
[ ] Tests added
[ ] Passes isort . && black . && mypy . && flake8
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

It works on the minimal example I had in #4483, but I didn't check further if it breaks things

I'm sorry for taking so long to review.
We discussed this a bit in #4529, and I now think the fix should be moved to as_variable. Also, as per https://github.com/pydata/xarray/issues/4529#issuecomment-715369738 it is probably better to raise an error for putting a DataArray object into the tuple syntax, and to ask the user to convert using .data.

@chunhochow, would you have the time to make this raise an error? I think that's more sensible than casting a DataArray, especially since changing (("x", "y"), ds.foo[1:, :]) to (("x", "y"), ds.foo[1:, :].data) is not that much more to write.

@keewis something like this? I'm not sure how to remove the DataArray import though if I need to typecheck on it. Go ahead and squash the commits when you finally finish the pull request.

yes, exactly, thanks for the update, @chunhochow. We still should move this to the part of as_variable that deals with tuple typed arguments, though (this would fix the failing CI).
Also, I would use a different error message, e.g. "Using a DataArray object to construct a variable is ambiguous, please extract the data using the .data property". I'm not entirely sure if that's entirely accurate, but I would expect the error message to explain why this fails and to point the user in the right direction. Any suggestions, @pydata/xarray?
Other than that this looks good to me and is only missing a entry to doc/whats-new.rst in the "Bug fixes" section.

If it's a breaking change to this extent, should this raise a DeprecationWarning or etc for now (if such warnings exist/are used in xarray), instead of directly raising a TypeError?

If it's a breaking change to this extent, should this raise a DeprecationWarning or etc for now (if such warnings exist/are used in xarray), instead of directly raising a TypeError?

https://github.com/pydata/xarray/blob/a2b1712afd957deaf189c9b1a04e469596d853c9/xarray/tests/test_dask.py#L1236
I think if we change to x.y.data this should work?
I agree, perhaps we nee to raise DeprecationWarning for a couple of releases.

https://github.com/pydata/xarray/blob/a2b1712afd957deaf189c9b1a04e469596d853c9/xarray/tests/test_dask.py#L1236
I think if we change to x.y.data this should work?
I agree, perhaps we nee to raise DeprecationWarning for a couple of releases.

The TypeError is changed to a DeprecationWarning .

The TypeError is changed to a DeprecationWarning .

This change looks good to me, but it would be nice to add a test verifying that the DeprecationWarning is raised, e.g., with pytest.warns.

this should be ready for a final review now

great. Thanks for the PR, @chunhochow. Welcome to xarray!


Fix internal test failure caused by PR 31550

We observe a few timeout failure for our internal test suites. This PR is going to fix such timeout by setting a deadline for the request. Also fixed a missing scenario when we need to check if we need to fire the warning.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @damccorm

I'll merge after checks complete


figure out how to proxy Mexico and Non-US/BR/MX user experience

related to #5001

[ ] Mexico user
[ ] non-US/BR/MX user

@mshmsh5000 I think the easiest route is to sign up for a month to month account on TorGuard. Their VPN services are available in a lot of countries, and we can mimic a lot using their services. They're one of the more trusted VPN services, and give us a lot of flexibility. If you want to setup an account and add the credentials to LastPass, or I can have Gleb set this up on his CC, this should solve this problem for us.

:+1:

@namimody @mshmsh5000 @mikefantini @angaither @blisteringherb
Wiki link: https://github.com/DoSomething/phoenix/wiki/VPN-Server-for-Testing-International-Sites


Configure Azure Pipelines

[Configure Azure Pipelines]
This pipeline configuration builds the application and produces a build for the Release configuration.

@microsoft-github-policy-service agree


Fix ExactMatch export

FYI I invalidated one of the API Keys hence the tests failing -- unrelated to this change


Server crash with Essentials 2.6 and client bugs

Information

Minecraft Version: 1.16.1
Fabric API Version: 0.9.0 - build 204-1.16.1
OS: Windows 10
Other installed mods: image

Describe the issue
1.Crashes server on latest release when player joins
2.when player joins server with latest version on client side and last version on server side then player skin fails to load, tab menu becomes empty and other players dont render
Crash/Error logs
Server crash log
To Reproduce

install Essentials 2.6 on client

install Essentials 2.5 on server

broken

install Essentials 2.6 on server

broken

Expected behavior
server will crash when Essentials 2.6 is isntalled
Client will be buggy on servers with Essentials 2.6 installed while the server has 2.5

Same crash. Essentials 2.6 with all modules. When Player with or without essentials joins world the server crashes.

A new version of module-utilities has been uploaded to fix this.


Correctly parse atlas community version

Motivation
The atlas-terraform-provider (v0.8.0) fails with the following error when using the Community version of atlas with it:
╷
│ Error: Check atlas version failure
│
│   with provider["registry.terraform.io/ariga/atlas"],
│   on main.tf line 26, in provider "atlas":
│   26: provider "atlas" {
│
│ unexpected output format
╵

The implementation of the version check is delegated to the atlas-go-sdk which cannot parse the output of atlas version when using a community version. This PR fixes the issue.

Thanks for your quick reply @a8m!
Since the non-community version is a strict superset of the community version, I guess it is natural that some functions simply fail when the community version is installed. I would argue that checking for a non-community version becomes the responsibility of the SDK user though.
With that in mind, should we maybe just add a Community flag to the Version struct to allow SDK users to check for it?
I'd appreciate if this could be moved forward in the near future as this would fix the Terraform provider for my use case (and for the atlas binary published to conda-forge, c.f. https://anaconda.org/conda-forge/atlasgo). If you don't have enough capacity to think about this at the moment, I respect that, of course :pray:

I modified my proposal accordingly, I think this adds some value :smile:

@a8m I just realized that https://github.com/ariga/atlas/pull/2740 made the situation in builds of v0.23.0 even worse. There is now no way to use a community build with the SDK due to the introduction of the word "unofficial" in the version string. As a result, I would really like to move forward with this PR. This would likely entail introducing yet another flag, namely Official bool (or the reverse, i.e. Unofficial bool). It is a little unclear to me why this additional distinction is necessary though, the "community" flag should already imply that the build is "unofficial".

Unfortunately, I have to say that finding out about above's PR left a bit of a bad taste in my mouth. I love atlas's functionality but I do find the timing of the above-linked PR a little odd (exactly one day after the conda-forge build was published)... it seems to me as if the goal would be to force all users of atlas to the "official", closed-source build. In case this assessment is accurate, I would appreciate if this intent was communicated accordingly 😅
In case the knock-on effects of the above change were, in fact, inadvertent, I will patch the conda-forge build to remove the word "unofficial" from the version string to not break integration with existing tools.

To give some context on why one would want to use a build of the community version in the first place:

There are obvious security concerns to use closed-source builds of a tool when interacting with production databases
There is no way to use the "latest" official build without introducing strange non-deterministic errors due to the use of canary releases
Using plain download URLs doesn't allow for easy integration with established tools (e.g. conda) to lock tools' versions and periodically update those

I hope this provides some insights why, I believe, there should exist an open-source build of atlas that integrates with all atlas-related tools. Personally, I would expect that this would increase adoption of the tool which I would love to see.

It is a little unclear to me why this additional distinction is necessary though, the "community" flag should already imply that the build is "unofficial".

We also release community builds (Apache2 license) twice a day. The other builds that compile Atlas from source are out of our control, might contain a modified version, and I prefer communicate this correctly to our users (paid and unpaid ones).

Unfortunately, I have to say that finding out about above's PR left a bit of a bad taste in my mouth. I love atlas's functionality but I do find the timing of the PR a little odd (exactly one day after the conda-forge build was published)...

I am not aware of this tool/build-system.
If you are on our Discord server, you'll notice that many of my support there in the last year suggest users to install Atlas correctly (after they hit some limitation) because they install the incorrect ones (mostly via brew/nixos). That's actually even worse when our Enterprise users accidentally install these. Since the external builds (and there are multiple of them out there) use the name atlas, it's important to emphasize that these were not made by the Atlas team - I don't have plans to start reviewing these biuilds one by one.

I would argue that checking for a non-community version becomes the responsibility of the SDK user though.

I just saw this comment. It's easy to say this from the perspective of a user, but in practice, it's different. It's our responsibility to ship correct and stable software, and support our users. My experience is just different from managing two big communities (ent and atlas).
I understand the impact and the limitation it brings, but since our capacity is limited, this is going to be on hold at this stage, as it requires our time to make all flows compatible (and safe to use) with the community builds.

Thanks for your answer @a8m, I see that you have put in quite some thought into this and I don't expect anything to happen here. I still want to leave some additional comments here.

We also release community builds (Apache2 license) twice a day.

Even with that being the case, they are closed-source builds (afaict they are not built via GitHub Actions or any other public CI system) and, even worse, I still can't use official community builds with this SKD.

I am not aware of this tool/build-system.

conda is a cross-platform package manager with conda-forge hosting almost 25,000 packages. Even if it isn't widely used in the Go ecosystem, it is a popular way of installing single-binary CLI tools.

If you are on our Discord server, you'll notice that many of my support there in the last year suggest users to install Atlas correctly (after they hit some limitation) because they install the incorrect ones (mostly via brew/nixos)

I do understand that this is annoying but the distinction between official and unofficial distributions is also largely unclear in the documentation. Homebrew, in particular, is listed as one of the installation options (cf. https://atlasgo.io/getting-started/). It seems strange to expect users to know to not install atlas via brew then.

It's our responsibility to ship correct and stable software, and support our users.

I'm wondering if you could achieve this by making it abundantly clear in the documentation that support is only available for versions of atlas installed via XXX. This way, you wouldn't prevent the usage of atlas for expert users who prefer a different way of packaging and installing atlas. After all, compiling a Go binary is no rocket science...


⚠ Bofrost.be has degraded performance

In f4a3477, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1546 ms

Resolved: Bofrost.be performance has improved in 1c9b577 after 6 minutes.


Add distro.__version__attribute

Use the version supplied to setuptools as a single source of truth. On
newer Pythons, can use importlib.metadata to acquire the version.
https://docs.python.org/3/library/importlib.metadata.html
Fixes #265

Maybe __name__ instead of "distro" redundant litterals ? @jdufresne


Failed to generate when changing player character

Version
3.0.1 (412b94e)
Seed
R730-ZVE8-LTHHAHMZ9YE00NRPJV61V0XK1HH0ZZZZWJZ
Scenario
RE 3 (Jill)
What happened?
When trying to change to any character, no matter the seed, it always fails to generate. It works fine for RE 1 & 2
This is what the log says:

BioRand 3.0.1 (412b94e)
Seed: R730-ZVE8-1THHAHMZ9YC00NRPJV61V0XK1HH0ZZZZWJZ
Player: 0 Jill
Scenario: A
Randomizing Player:
jill.re3 becomes kendo.re2r
Exception: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource)
at System.Collections.Generic.List`1.set_Item(Int32 index, T value)
at IntelOrca.Biohazard.VabFile.SetSampleFromPCM(Int32 index, Byte[] data)
at IntelOrca.Biohazard.RE3.Re3Randomiser.SwapPlayerCharacter(RandoConfig config, RandoLogger logger, String actor, FileRepository fileRepository)
at IntelOrca.Biohazard.RE3.Re3Randomiser.ChangePlayerCharacters(RandoConfig config, RandoLogger logger, GameData gameData, FileRepository fileRepository)
at IntelOrca.Biohazard.BaseRandomiser.GenerateRdts(RandoConfig config, IRandoProgress progress, FileRepository fileRepository)

log_pl0.txt

It looks like your version of RE 3 is different to what biorand expects. Where did you get your version from, is it possible for me to get the same version?

Believe I got my version from the official RE speedrun discord. Which they had a link to a video about it. They use the Taiwan version. Although, when I got it, all three games shared the server. Then patched it with the sourcenext 1.1.0 patch to use the classic REbirth patch
Here is the RE 3 speedrun server. But the original link I got it from was taken down
https://discord.gg/yM6pQMf

Closing due to incompatible version


[5.7] fixed doc block for handleQueryException;

changed first argument from \Exception to \Illuminate\Database\QueryException since we called tryAgainIfCausedByLostConnection with \Illuminate\Database\QueryException

This is a breaking change; anyone can call handleQueryException to handle any type of exception that have occurred during querying, or perhaps wrap the exception in another exception of another type. There are no guarantees that all derived implementations always work with QueryException here.

@sisve , in case, if someone calls this method with other exception then they got a fatal error.
Because handleQueryException is called tryAgainIfCausedByLostConnection,
tryAgainIfCausedByLostConnection is :
    /**
     * Handle a query exception that occurred during query execution.
     *
     * @param  \Illuminate\Database\QueryException  $e
     * @param  string    $query
     * @param  array     $bindings
     * @param  \Closure  $callback
     * @return mixed
     *
     * @throws \Illuminate\Database\QueryException
     */
    protected function tryAgainIfCausedByLostConnection(QueryException $e, $query, $bindings, Closure $callback)
    {
        if ($this->causedByLostConnection($e->getPrevious())) {
            $this->reconnect();

            return $this->runQueryCallback($query, $bindings, $callback);
        }

        throw $e;
    }

Not if I have overridden the handleQueryException method to accept other exceptions, and handle them accordingly.

@sisve , than you will override the phpDoc also

Do you accept that phpdocs are part of the method signature?
If it says that it @return string, and you change it to @return int, do you agree that you've changed the method signature?
And do you agree that changing method signatures are breaking changes?

Do you consider this a acceptable special case just because it calls tryAgainIfCausedByLostConnection?

I understand what you're getting at, but it highlights another problem. The implementation (content of the method) does not match the contract (the method signature). The method signature states that we allow any types of exceptions, but this is obviously a lie. This is something that would have been seen in tests if we had tests that invoked the method with the parameters it claims to accept and support.
I am agreeing with you on these changes; the method's name indicates that it should only accept a QueryException. I would love to see more php7 typehints instead of phpdocs, but that is besides the point.
I am only saying that these things, changing a method signature, is a breaking change. It makes sense to do these changes in the 5.7 release, since it is highly improbable (but not impossible) that someone has override with a different exception support while still conforming to the contract. But everyone that has their own implementation of the code need to update the contract/phpdocs accordingly, and in worst-case, stop calling the method with non-QueryException exceptions.

Sorry, I don't really see a point in changing this one.


Contact Me Section

I include a contact me section which contains a form

Pair programming partner added button to my form


Content blocking integration tests

Reviewer: Chris
Asana: https://app.asana.com/0/414709148257752/427082503331144
Description:
Add simple integration tests for content blocker counts. Note I have intentionally removed these from the main test suite so that they run manually. Once the content blocker work is complete and these tests pass we will add them again so that they run with CI.
Steps to test his PR:

Switch to the Integration test scheme
Run the Integration tests
Ensure that the python mock server is launched and the tests run. Only one test will pass - the others will fail until the content blocking work is complete. I have however validated that they pass on the spike branch.

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR DRI Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications (Database connections, Grafana stats, CPU)

Cheers, thanks for the review and scripting feedback @brindy!


[0.9.27 regression] Parser gets confused by aref assignment

Create the following file foo.rb:
module Foo
  a = {}

  # Earlier assignment
  a[:b] = 1

  # This constant fails to parse correctly
  X = a[:b]
end

Run yardoc with this file, using yard 0.9.27 on Ruby 3.0.3. It results in an exception similar to the following:
[error]: Exception occurred while generating 'Foo.html'
[error]: NoMethodError: undefined method `[]' for nil:NilClass
[error]: Stack trace:
	/Users/dazuma/opt/asdf/installs/ruby/3.0.3/lib/ruby/gems/3.0.0/gems/yard-0.9.27/lib/yard/templates/helpers/method_helper.rb:69:in `format_constant'
	/Users/dazuma/opt/asdf/installs/ruby/3.0.3/lib/ruby/gems/3.0.0/gems/yard-0.9.27/templates/default/module/html/constant_summary.erb:15:in `block (2 levels) in _erb_cache_18'
	/Users/dazuma/opt/asdf/installs/ruby/3.0.3/lib/ruby/gems/3.0.0/gems/yard-0.9.27/templates/default/module/html/constant_summary.erb:11:in `each'
	/Users/dazuma/opt/asdf/installs/ruby/3.0.3/lib/ruby/gems/3.0.0/gems/yard-0.9.27/templates/default/module/html/constant_summary.erb:11:in `block in _erb_cache_18'
	/Users/dazuma/opt/asdf/installs/ruby/3.0.3/lib/ruby/gems/3.0.0/gems/yard-0.9.27/templates/default/module/setup.rb:148:in `groups'
	/Users/dazuma/opt/asdf/installs/ruby/3.0.3/lib/ruby/gems/3.0.0/gems/yard-0.9.27/templates/default/module/html/constant_summary.erb:4:in `_erb_cache_18'

I've tracked this down as far as determining that the value for the constant node for X is empty due to the node having an invalid source_range where the ending position is less than the beginning. The ending position is actually coming from the previous aref from the line a[:b] = 1. The parser doesn't seem to consume that aref when it is on the LHS of an assignment operator, so when the X = a[:b] line gets parsed in RipperParser#on_aref, it's getting the ending position from the previous instance.
This appears to be a regression in 0.9.27. It does not happen in 0.9.26.
Ruby 3.0.3.
2019 Macbook Pro running Monterey 12.1, although I doubt that matters.

I am encountering this as well. without really grokking this code:
https://github.com/lsegal/yard/blob/v0.9.27/lib/yard/parser/ruby/ruby_parser.rb#L373
I tried flipping the shift to a pop, since the correct entry of @map[:aref] was in the last position, which resolved my errors.
but I see this change was made in https://github.com/lsegal/yard/pull/1389 and the test added there fails when it is a pop.
some other fix is needed.

👋 I'm the author of the PR that caused the regression, thanks for flagging it @notEthan.
 I'll take a look and see if I can land a fix things up.