Missing vcruntime140_1.dll

Summary
I'm getting the following exception during the initialization of my JavaFX based application causing its crash :
java.lang.RuntimeException: java.lang.UnsatisfiedLinkError: C:\****\jre\bin\glass.dll: Can't find dependent libraries
	at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.startup(QuantumToolkit.java:290)
	at javafx.graphics/com.sun.javafx.application.PlatformImpl.startup(PlatformImpl.java:288)
	at javafx.graphics/com.sun.javafx.application.PlatformImpl.startup(PlatformImpl.java:160)
	at javafx.swing/javafx.embed.swing.JFXPanel.lambda$initFx$1(JFXPanel.java:224)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.UnsatisfiedLinkError: C:\****\jre\bin\glass.dll: Can't find dependent libraries
	at java.base/java.lang.ClassLoader$NativeLibrary.load0(Native Method)
	at java.base/java.lang.ClassLoader$NativeLibrary.load(ClassLoader.java:2442)
	at java.base/java.lang.ClassLoader$NativeLibrary.loadLibrary(ClassLoader.java:2498)
	at java.base/java.lang.ClassLoader.loadLibrary0(ClassLoader.java:2694)
	at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2648)
	at java.base/java.lang.Runtime.loadLibrary0(Runtime.java:830)
	at java.base/java.lang.System.loadLibrary(System.java:1873)
	at javafx.graphics/com.sun.glass.utils.NativeLibLoader.loadLibraryInternal(NativeLibLoader.java:163)
	at javafx.graphics/com.sun.glass.utils.NativeLibLoader.loadLibrary(NativeLibLoader.java:53)
	at javafx.graphics/com.sun.glass.ui.Application.loadNativeLibrary(Application.java:110)
	at javafx.graphics/com.sun.glass.ui.Application.loadNativeLibrary(Application.java:118)
	at javafx.graphics/com.sun.glass.ui.win.WinApplication.access$000(WinApplication.java:39)
	at javafx.graphics/com.sun.glass.ui.win.WinApplication$1.run(WinApplication.java:101)
	at javafx.graphics/com.sun.glass.ui.win.WinApplication$1.run(WinApplication.java:82)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at javafx.graphics/com.sun.glass.ui.win.WinApplication.<clinit>(WinApplication.java:82)
	at javafx.graphics/com.sun.glass.ui.win.WinPlatformFactory.createApplication(WinPlatformFactory.java:39)
	at javafx.graphics/com.sun.glass.ui.win.WinPlatformFactory.createApplication(WinPlatformFactory.java:36)
	at javafx.graphics/com.sun.glass.ui.Application.run(Application.java:144)
	at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.startup(QuantumToolkit.java:280)

Looking at glass.dll dependencies I see that vcruntime140_1.dll is not installed on the targeted system.
Steps to reproduce

build the following Snippet (Snippet-missing-dll-vcruntime140_1.zip)

MyApp.java:
import javafx.stage.*;
import javafx.application.*;
public class MyApp extends Application {
    public static void main(String[] args) {
        System.out.println("Hello from main");
        launch(args);
    }
    @Override
    public void start(Stage stage) {
        System.out.println("Hello from openjfx app");
    }
}

pom.xml:
<project xmlns="http://maven.apache.org/POM/4.0.0"
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
	<modelVersion>4.0.0</modelVersion>
	<groupId>Snippet-missing-dll-vcruntime140_1</groupId>
	<artifactId>Snippet-missing-dll-vcruntime140_1</artifactId>
	<version>0.0.1-SNAPSHOT</version>
	<dependencies>
		<dependency>
			<groupId>org.openjfx</groupId>
			<artifactId>javafx-controls</artifactId>
			<version>16</version>
		</dependency>
	</dependencies>
	<build>
		<sourceDirectory>src</sourceDirectory>
		<plugins>
			<plugin>
				<artifactId>maven-compiler-plugin</artifactId>
				<version>3.8.1</version>
				<configuration>
					<release>11</release>
				</configuration>
			</plugin>
			<plugin>
				<groupId>org.openjfx</groupId>
				<artifactId>javafx-maven-plugin</artifactId>
				<version>0.0.6</version>
				<configuration>
					<mainClass>MyApp</mainClass>
				</configuration>
			</plugin>
		</plugins>
	</build>
</project>

Execute with java -jar

Expected results
The application should run without installing additional software (seems Microsoft Visual C++ 2017 or 2019 provide this lib).
Actual results
See above
Triaging info
Java version:
openjdk version "11.0.11" 2021-04-20
OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+9 (build 11.0.11+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed mode)
With OpenJFX 16 integrated (jlink)
What is your operating system and platform?
Windows 10 Enterprise version 1909 on x86-64
How did you install Java?
Binary archive.
Did it work before?
Works if OpenJFX 11.0.2.
Did you test with other Java versions?
No Java11 (LTS) is required.
Findings / Analysis
AFAIU OpenJFX build has been migrated to VS 2019 since openjfx15 (https://bugs.openjdk.java.net/browse/JDK-8242507), then backported to openjfx11.0.9 (https://bugs.openjdk.java.net/browse/JDK-8252334).
This induced https://bugs.openjdk.java.net/browse/JDK-8242468, fixed in OpenJDK15, but not backported yet to OpenJDK11 (LTS).

That backport would have to be done upstream.  As we don't ship OpenJFX ourselves it's unlikely that there will be a volunteer from this community.  You may want to ask on the OpenJFX mailing list.

The fix for this issue could be covered by https://bugs.openjdk.java.net/browse/JDK-8282655 (to be confirmed)

Looks like this was backported to JFX11.0.15 in https://github.com/openjdk/jfx11u/commit/2f2a07a96dc4d739faa63183b4d800e01030b494 - Closing


Use GitHub App's token or PAT for the update-contributors workflow

What would you like to be added:

as title.

Why is this needed:

Due to the following spec of GitHub Actions, the update-contributors workflow does not trigger other workflows, so checks cannot be finished. (PR: https://github.com/pipe-cd/pipecd/pull/4974)

https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run.

create-pull-request's 5 workarounds:
https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs

Workarounds to trigger further workflow runs
There are a number of workarounds with different pros and cons.

Use the default GITHUB_TOKEN and allow the action to create pull requests that have no checks enabled. Manually close pull requests and immediately reopen them. This will enable on: pull_request workflows to run and be added as checks. To prevent merging of pull requests without checks erroneously, use branch protection rules.

Use a repo scoped Personal Access Token (PAT) created on an account that has write access to the repository that pull requests are being created in. This is the standard workaround and recommended by GitHub. However, the PAT cannot be scoped to a specific repository so the token becomes a very sensitive secret. If this is a concern, the PAT can instead be created for a dedicated machine account that has collaborator access to the repository. Also note that because the account that owns the PAT will be the creator of pull requests, that user account will be unable to perform actions such as request changes or approve the pull request.

Use SSH (deploy keys) to push the pull request branch. This is arguably more secure than using a PAT because deploy keys can be set per repository. However, this method will only trigger on: push workflows.

Use a machine account that creates pull requests from its own fork. This is the most secure because the PAT created only grants access to the machine account's fork, not the main repository. This method will trigger on: pull_request workflows to run. Workflows triggered on: push will not run because the push event is in the fork.

Use a GitHub App to generate a token that can be used with this action. GitHub App generated tokens are more secure than using a PAT because GitHub App access permissions can be set with finer granularity and are scoped to only repositories where the App is installed. This method will trigger both on: push and on: pull_request workflows.

https://github.com/pipe-cd/pipecd/pull/4974#issuecomment-2181838890

a. Manually close the PR -> reopen the PR (cf. https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs)
b. Update branch manually

As the above comment, the following 2 workarounds are best for the time being.


Manager is not element

Avoid ParameterMgr inheritance to Element
Allows to avoid tree structure guess work

Coverage decreased (-0.16%) to 69.98% when pulling cc344d60c4c35bd328a7be5cc63b77f0dca73209 on clero:manager_is_not_element into 5ab361dc2a67f583194be553c7227d6015d0bba3 on 01org:next.

@dawagner @krocard please review

Coverage decreased (-0.16%) to 69.98% when pulling fd2ebe35bf8084867abe3a7178a1723502f5ae7a on clero:manager_is_not_element into 4f6171c80ff3dfa11c8d0b87b5f48f52293c31c1 on 01org:next.

the decrease in coverage is only related to dead getKind() methods that can't be removed yet.

Please resubmit against the master branch :) ok for me after once you fix the minor coding style issue in parameter/ParameterType.cpp.
Thanks a lot, @clero.
@OznOg Please review.

Coverage decreased (-0.16%) to 69.98% when pulling c080eb48d849564817db613ec7059d17bf47b898 on clero:manager_is_not_element into 0428220bf0236ab8245d1308a73ebdede505f1a3 on 01org:next.

closed for master submission

@dawagner  in fact maybe it can be good to send it on next branch as it already has been updated to the new log API
Let me know if you still prefer a submission on master branch.

Coverage decreased (-0.16%) to 69.98% when pulling c080eb48d849564817db613ec7059d17bf47b898 on clero:manager_is_not_element into 0428220bf0236ab8245d1308a73ebdede505f1a3 on 01org:next.

getKind must be removed from ParameterMgr!

Coverage decreased (-0.14%) to 70.0% when pulling 44713bbacfcf86bd60f5f67ab3e60cb0e866e1c2 on clero:manager_is_not_element into 0428220bf0236ab8245d1308a73ebdede505f1a3 on 01org:next.


Change name of sigmoid_cross_entropy_with_logits to log_loss

Hi folks. This name sigmoid_cross_entropy_with_logits struck me as strange. In addition to being a mouthful, we're calling it cross_entropy when it really is just binary cross_entropy calculated separately on every node.
The more intuitive name I would give to this function would be log_loss or mean_log_loss (if normalized). I think this would be both easier to write, and easier to understand.

The name may not be the best one, but we probably want to avoid saying "loss" in the function (since it's use it not necessarily restricted to being used a loss).

Good point. Similarly, it's not restricted to being used with sigmoid units. Maybe better to call it binary_cross_entropy?

Sounds good to me. @sherrym, I'll assign you for summary judgment.

Following your points on naming, maybe a better name for nn.l2_loss is nn.l2_norm.

@zackchase , sigmoid_cross_entropy_with_logits actually is restricted to being used with sigmoid units, in the sense that it only gives you the cross entropy if you are using such units. It is the op for binary cross entropy when the binary probability is produced by applying the sigmoid function to one argument. You could imagine other ways of getting binary probabilities, like thresholding the argument to the interval [0,1], or taking softplus(x)/(1+softplus(x)) instead of sigmoid, etc.

Closing since changing the name is too little benefit for the large amount of required work.


French translation

Updated the French translation!

Thanks for submitting these translations, @forthommel!

My pleasure, @micahflee ! Many thanks for your amazing work!


Rework author noting inherent mock and stagelight config

This PR moves the mock of author noting before the kick_off_authorship inherent checks. We have a new chain in which we only run the author noting inherent but not the kick_off_authorship inherent, which would fail before this PR. This should not affect any of the other chains as we are only mocking the storage that verifies on_finalize that the inherent has run.
Additionally, I added a new config for the new chain, which we are calling stagelight. this is for now just the stagenet version of a testnet that will be launched in a couple of weeks, once we launch it I will make a PR putting the testnet config file

There needs to be some check so we don't create a storage change for other chains. I suggest leaving current implementation untouched and do this inside return []

I can check if the inherent exists before doing the storage change, would that be ok?

@ermalkaleci is the CI test failing because of this changes? I dont see anythng where I could have affected it

@ermalkaleci is the CI test failing because of this changes? I dont see anythng where I could have affected it

no, it's RPC timed out


Missing autocomplete for type Literal[...] | str

Environment data

Language Server version: 2023.11.10 (pyright 088ebaa5)
OS and version: Win 11
Python version (& distribution if applicable, e.g. Anaconda): 3.12.0

Code Snippet

from typing import Literal, Any, LiteralString, AnyStr

OptionStr = Literal["a", "b", "c"] | str
OptionAny = Literal["a", "b", "c"] | Any
OptionLit = Literal["a", "b", "c"] | LiteralString
OptionAnyStr = Literal["a", "b", "c"] | AnyStr

def func(*, o1: OptionStr, o2: OptionAny, o3: OptionLit, o4: OptionAnyStr):
    ...

func(o1="")
func(o2="")
func(o3="")
func(o4="")

Expected behavior
All o1, o2, o3, and o4 should have type hints for the Literal["a", "b", "c"]

Actual behavior
o2, o3 and o4 prompt autocomplete as expected.
o1 (Literal["a", "b", "c"] | str) does not prompt autocomplete.

@erictraut Thanks for the response, your guess is correct. While I agree that it is atypical, it is still a valid type and therefore the server should still provide the completion suggestions regardless. I can name a few use cases for this:

A parameter accepts "latest", "development", "staging", "production", and any arbitrary version number.
A parameter accepts a list of frequent options, the list of options may grow over time, this would prevent a sudden type check error until the new option is added.

it is still a valid type

I agree it's a valid type, but you're relying on the tenuous assumption that the type evaluator won't immediately simplify the type. This would be justified given that the simplified version of the type is the same as the more complex type. The type evaluator doesn't currently perform this simplification in this case, but it does in other cases. This could change in the future. Even if the language server were to add support for this, it could easily break in the future as the underlying type evaluator evolves.
A more robust approach is to use an overload:
@overload
def func(*, o1: Literal["a", "b", "c"]) -> None:
    ...

@overload
def func(*, o1: str) -> None:
    ...

def func(*, o1: str) -> None:
    pass

This also has the added benefit of working with the current completion provider logic.

@erictraut Understandable, using @overload is indeed the more robust approach, my issue is that I have more than 50 functions relying on such argument typing, doing 50+ overloads is not going to look great. I have found out that Literal[] | AnyStr works, and based on your reply, it's not simplifying this type since AnyStr includes byte strings, so I will be coping with that instead in the meantime.

I don't think you want to use AnyStr. This is a type variable, which means that OptionAnyStr = Literal["a", "b", "c"] | AnyStr defines a generic type alias. When this type alias is used, it requires you to supply a type. If you omit the type argument (OptionAnyStr), a type checker will assume you mean OptionAnyStr[Any], which is probably not your intent. If you really do intend for your function to be generic and it accepts bytes arguments, you could specify OptionaAnyStr[AnyStr], but I'm guessing that's inconsistent with your implementation. An @overload is the proper tool for this job. I agree it's somewhat verbose, but if you're looking for a correct and robust solution, that's what I recommend.

Thanks, I'll consider it


Well Typed Recursive object not supported

A basic structure like
Message: {
Replies:[{Message},..]
};
cannot be supported.  There is no way to create a typed child which has a default of NULL of the same type being created (to stop the infinite recursion) or to create a child attribute that is a collection of the type being created.

Well, the good news is that it can be supported, and even will look reasonably well. Function defaults' body can be used to make recursive type references. Some work is required, though.
Will make it a part of the next major release.

Even easier. I will just add pre-declarations. It will resolve all problems with circular dependencies. Will look like this:
var M = Model.extend();
M.define({
// actual definition
});

'.define' can be called several times, and will have the semantic of mixin. May be, I will call it '.mixin'.

Any update on this issue?

Got a solution in 'develop' branch, seems to work ok. Need to add unit test and merge it to 'master'.
On the next week you'll have it.

Thanks you very much.

Hi again,
Please let me know how I can use new feature.


Automate building external libraries

This PR provides automation around building external libraries based on options selected.
Additions

Adds options

NGEN_WITH_EXTERN_SLOTH
NGEN_WITH_EXTERN_TOPMODEL (Dependent on NGEN_WITH_BMI_C)
NGEN_WITH_EXTERN_CFE (Dependent on NGEN_WITH_BMI_C)
NGEN_WITH_EXTERN_PET (Dependent on NGEN_WITH_BMI_C)
NGEN_WITH_EXTERN_NOAH_OWP_MODULAR (Dependent on NGEN_WITH_BMI_FORTRAN)
NGEN_WITH_EXTERN_ALL: enables all models if the dependency is enabled, i.e. sets NGEN_WITH_EXTERN_CFE=ON if NGEN_WITH_BMI_C=ON.

Adds cmake/ExternalSubdirectory.cmake which provides the add_external_subdirectory function. This is a simple convenience function wrapping add_subdirectory that can auto-update git submodules (GIT_UPDATE), and ensures a given target is imported (IMPORTS).
Automates building test BMI libraries when a dependent option is enabled, i.e. NGEN_WITH_BMI_C means testbmicmodel will be built.
Adds a Fortran compiler configuration step in the ngen-build action.

Changes

Updates build summary output to include new options and C/CXX flags set.
Modifies ngen_add_test to allow DEPENDS arguments, which are dependent targets for that test. This differs from REQUIRES and LIBRARIES in that DEPENDS are simply dependent targets, and otherwise have no relation/linkage to the target.
Modifies CMake listfile for noah-owp-modular, iso_c_bmi, and testbmifortran to better handle building in conjunction with NGen, or independently.
Modifies the Docker container used for an example run of NGen.

Removals

Removes the deprecated option -DPACKAGE_TESTS since this conflicts with SLoTH when auto-building.
Removes FindBMI_FORTRAN_ISO_C module since this PR removes the need for it.

TODO

[x] Resolve including git submodules in new ngen.dockerfile.
[x] Resolve CFE BMI sanitizer error.

Checklist

[X] PR has an informative and human-readable title
[X] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[X] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[X] Any change in functionality is tested
[X] New functions are documented (with a description, list of inputs, and expected output)
[X] Placeholder code is flagged / future todos are captured in comments
[X] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:

Target Environment support

[x] Linux
[x] macOS

The to-do left here is to update the version of cfe we test against to incorporate https://github.com/NOAA-OWP/cfe/pull/101 and see it pass the tests, right?

#664 already has that CFE update in progress

The to-do left here is to update the version of cfe we test against to incorporate NOAA-OWP/cfe#101 and see it pass the tests, right?

That is correct.

#664 has been merged.

Let's mention this on the stand-up tomorrow, and merge if no one wants to hold it for their own review.

@PhilMiller Is there anything else needed for this? Otherwise, I think we're good to merge now.


Json.Of migration

closes #27

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.
If this PR solves a todo from the code, please don't forget to remove it.

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-06-28T11:39:03.995839.
You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.
Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

since, JsonProcessing exception cannot be thrown in jackson version > 2.1, test can not be introduced

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Add message that project is unmaintained.

I am no longer actively developing gluster-subvol, nor am I testing on current versions of kubernetes.
The flexvol driver is still in-use, so I'm not ready to archive the repo yet. But once that system is decomissioned, I plan to archive unless there is additional interest and contribution.

@amarts FYI

Thanks @JohnStrunk. This is helpful.


Compile and run OpenAI Triton on NV machine

Please document your steps and any difficulties you encountered.

Compile-Triton-RTX6000.md

@prathams417 thanks for documenting the steps to compiler and test Triton on a NV GPU. Can you please add the documentation to the https://github.com/intel/intel-xpu-backend-for-triton/wiki, then we can close this work item. Thanks.

https://github.com/intel/intel-xpu-backend-for-triton/wiki/Compile-and-run-OpenAI-Triton-on-NV-machine-from-scratch


Prevent unintended folders from being ignored

Reasons for making this change:
I'm not sure of the best way to fix this (would rather flag it as an issue than suggest this solution get merged), but keeping this in causes any folder in a any project with the name "Icon" to be ignored. I use GitHub for Mac and couldn't figure out why any folder I named "icon" (for front-end assets on a web app) kept disappearing from my code editor (Atom). It's because of this line.
Looking at the history, I understand it was added to prevent custom Finder icons from being included, but is there a way to make this exclusion less general?
Sorry if this is the wrong place – please point me towards where I should raise this as an issue.

@maban this is the right place - this repository gets used in a few places, including GitHub for Mac.
Unfortunately this rule is an annoying artefact of history - the \r\r suffix is how the file is formatted on disk, and unfortunately editors do get confused about this and eagerly change the line ending to be incorrect :metal:.
Unfortunately it seems to catch a lot of people out, and others have proposed solutions in the past that don't quite work, but I'm not sure I'm ready to drop this rule.

Thanks for the clarification! I was stumped for a solution (hence commenting the line out, as I couldn't raise an issue about it).
Given this is bundled with tools and not installed explicitly, I'd like to see this removed. It did catch me out and if I didn't have a more persistent colleague who wanted to figure it out (thanks, @joshje), I wouldn't have known why any folder I named icon disappeared from Atom. And I think the type of people who might use GitHub for Mac over the terminal (it's popular with designers) are more likely to be naming folders that.
Or, would it be better to raise an issue with Atom so that it formats line endings correctly?
I'll amend this PR with the change you suggest, but I'll understand if you want to close it rather than merge it – you know the implications of this change much better than I do.


usePropagateHeaders interface is too strict

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

[ ] 1. Link to code
[ ] 2. A failing test has been provided
[ ] 3. A local solution has been provided
[ ] 4. A pull request is pending review

Describe the bug
usePropagateHeaders expects currently this response Record<string, string> | void | Promise<Record<string, string | null | undefined> | void>; this unfortunately means that one cannot return multiple header values with the same name. Common use case is set-cookie for example but not only.
Expected behavior
Change the interface to accept Record<string, string|string[]>, or HeadersInit
Environment:

NodeJS:

Additional context

simplest option for the minimal fix
diff --git a/esm/plugins/usePropagateHeaders.js b/esm/plugins/usePropagateHeaders.js
index 13e2140f22c2028d925ba5050aaa5c7a8999c8b3..fab0e26430d1a2a27b6631c39e8e7e3dc392c001 100644
--- a/esm/plugins/usePropagateHeaders.js
+++ b/esm/plugins/usePropagateHeaders.js
@@ -42,7 +42,13 @@ export function usePropagateHeaders(opts) {
                 for (const key in headers) {
                     const value = headers[key];
                     if (value) {
-                        response.headers.set(key, value);
+                        if (Array.isArray(value)) {
+                            for (const v of value) {
+                                response.headers.append(key, v);
+                            }
+                        } else {
+                            response.headers.set(key, value);
+                        }
                     }
                 }
             }
diff --git a/typings/plugins/usePropagateHeaders.d.ts b/typings/plugins/usePropagateHeaders.d.ts
index 780cd99fed2e4f06dd90186911d94e78d4c7469a..47c24c77d2d1690c34076ea3daf75eb846a36830 100644
--- a/typings/plugins/usePropagateHeaders.d.ts
+++ b/typings/plugins/usePropagateHeaders.d.ts
@@ -8,8 +8,8 @@ interface FromSubgraphsToClientPayload {
     subgraphName: string;
 }
 export interface PropagateHeadersOpts {
-    fromClientToSubgraphs?: (payload: FromClientToSubgraphsPayload) => Record<string, string> | void | Promise<Record<string, string | null | undefined> | void>;
-    fromSubgraphsToClient?: (payload: FromSubgraphsToClientPayload) => Record<string, string> | void | Promise<Record<string, string | null | undefined> | void>;
+    fromClientToSubgraphs?: (payload: FromClientToSubgraphsPayload) => Record<string, string | string[]> | void | Promise<Record<string, string | string[] | null | undefined> | void>;
+    fromSubgraphsToClient?: (payload: FromSubgraphsToClientPayload) => Record<string, string | string[]> | void | Promise<Record<string, string | string[] | null | undefined> | void>;
 }
 export declare function usePropagateHeaders<TContext>(opts: PropagateHeadersOpts): GatewayPlugin<TContext>;
 export {};

Good catch!
Would you send a PR to fix it?

if you are happy with the approach above i can send a quick PR ofc

Looks good to me. But my only concern is to use append there.
When multiple headers are given, it will keep the existing headers in response.headers.
But when a single header is given, it will override the existing header.
Do you see my point?

Looks good to me. But my only concern is to use append there. When multiple headers are given, it will keep the existing headers in response.headers. But when a single header is given, it will override the existing header. Do you see my point?

agree, we should always aggregate and "append". if the same header is retuned from multiple subgraphs. no matter if it is retuned as array or single entity.

Created a quick PR for the subgraph-to-client code path https://github.com/ardatan/graphql-mesh/pull/7822
Sending headers to subgraphs also needs to change, but it starts to get a bit wider and needs more changes. so its better to split the problem into 2 i think. MeshFetch has specifically headers overridden to only support string, so i assume there is a reason for it :(

fixed in https://github.com/graphql-hive/gateway/pull/46


Apply legacy plugin last, and declare capabilities for old plugins

fixes #964 using the solution suggested by @ljacomet at https://github.com/GradleUp/shadow/issues/964#issuecomment-2345532565
Tested to fix the issue (bring behavior back to how it was before 8.3.1/with the old plugin), and to give an error when both the current and old plugin are on the classpath.
Something else that came to mind regarding the legacy plugin is that if someone puts the new plugin on the classpath, but then applies the legacy plugin id, nothing will happen, which could be confusing. But resolving that is likely better addressed in a separate PR (if at all).
> Could not resolve all files for configuration ':build-logic:compileClasspath'.
   > Could not resolve com.gradleup.shadow:shadow-gradle-plugin:8.3.3-SNAPSHOT.
     Required by:
         project :build-logic
      > Module 'com.gradleup.shadow:shadow-gradle-plugin' has been rejected:
           Cannot select module with conflict on capability 'com.github.johnrengelman:shadow:8.3.3-SNAPSHOT' also provided by [com.github.johnrengelman:shadow:8.1.1(apiElements)]
   > Could not resolve com.github.johnrengelman:shadow:8.1.1.
     Required by:
         project :build-logic
      > Module 'com.github.johnrengelman:shadow' has been rejected:
           Cannot select module with conflict on capability 'com.github.johnrengelman:shadow:8.1.1' also provided by [com.gradleup.shadow:shadow-gradle-plugin:8.3.3-SNAPSHOT(apiElements)]

[x] CHANGELOG's "Unreleased" section has been updated, if applicable.

CC @ljacomet

And thank you @jpenilla for taking care of fixing my mistake!

I'm planning to release this in 8.3.4, WDYT?


Reconfigure RDWatch CLI to get BBoxes directly

This PR will reconfigure the RDWatch CLI to get bboxes directly instead of trying to convert to tiles and stitching the area together.
Using the argument --tile will use the old behavior of returning a very large image using the tile method of getting pixels.  Without that argument, it will default to using the bounding box instead.

I refactored the requests for bbox/tiles for S2/L8 and worldview to utilize the same function.  Let me know if you think there should be an alternative way to do this.


Removed wrong code name from documentation

The Route::module('yourPluralModuleName}'); is a typo it should be Route::module('yourPluralModuleName');.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


bot stuck at "Next egg incubates in ..." at start

Expected Behavior
bot continues
Actual Behavior
bot stuck at "Next egg incubates in ..." at start
bot relog every ~30mins and repeat
ex.
[06:40:23] Starting bot...
[06:40:23] Received level up reward: []
[06:40:23] Next egg incubates in 2.00 km
Your config.json (remove your credentials and any other private info)
{
"tasks": [
{
"type": "HandleSoftBan"
},
{
"type": "CollectLevelUpReward"
},
{
"type": "IncubateEggs",
"config": {
"longer_eggs_first": true
}
},
{
"type": "RecycleItems",
"config": {
"run_interval": 60,
"item_filter": {
"Pokeball": {
"keep": 35
},
"Greatball": {
"keep": 70
},
"Ultraball": {
"keep": 100
},
"Masterball": {
"keep": 0
},
"Potion": {
"keep": 0
},
"Super Potion": {
"keep": 0
},
"Hyper Potion": {
"keep": 5
},
"Max Potion": {
"keep": 5
},
"Revive": {
"keep": 0
},
"Max Revive": {
"keep": 5
},
"Razz Berry": {
"keep": 80
}
}
}
},
{
"type": "EvolvePokemon",
"config": {
"evolve_all": "Pidgey,Rattata,Zubat,Weedle,Drowzee,Spearow,Venonat,Caterpie,Krabby,Paras,Jigglypuff,Sandshrew,Vulpix,Meowth,Psyduck,Mankey,Tentacool,Ponyta,Slowpoke,Magnemite,Doduo,Seel,Voltorb,Horsea,Goldeen,Staryu,Ekans",
"first_evolve_by": "cp",
"evolve_above_cp": 0,
"evolve_above_iv": 0,
"logic": "or",
"evolve_speed": 1,
"use_lucky_egg": false,
"run_interval": 180
}
},
{
"type": "TransferPokemon",
"config": {
"run_interval": 180
}
},
{
"type": "MoveToFort",
"config": {
"lure_attraction": true,
"lure_max_distance": 2000,
"ignore_item_count": true
}
},
{
"type": "SpinFort",
"config": {
"ignore_item_count": true
}
},
{
"type": "CatchVisiblePokemon"
},
{
"type": "CatchLuredPokemon"
}
],
"map_object_cache_time": 5,
"forts": {
"avoid_circles": true,
"max_circle_size": 500
},
"websocket_server": false,
"walk": 80,
"action_wait_min": 0,
"action_wait_max": 1,
"debug": false,
"test": false,
"health_record": false,
"location_cache": false,
"distance_unit": "m",
"reconnecting_timeout": 15,
"evolve_captured": "NONE",
"catch_randomize_reticle_factor": 1.0,
"catch_randomize_spin_factor": 1.0,
"catch": {
"any": {
"always_catch": true
}
},
"release": {"any": {"release_below_cp": 0, "release_below_iv": 0.95, "logic": "or"}
},
"vips": {
"any": {
"catch_above_cp": 1200,
"catch_above_iv": 0.9,
"logic": "or"
},
"Lapras": {},
"Moltres": {},
"Zapdos": {},
"Articuno": {},
"Mewtwo": {},
"Dragonite": {},
"Snorlax": {},
"Mew": {},
"Arcanine": {},
"Vaporeon": {},
"Gyarados": {},
"Exeggutor": {},
"Muk": {},
"Weezing": {},
"Flareon": {}
}
}
Steps to Reproduce
python pokecli.py
Other Information
OS: Windows 10 64bit
Git Commit: 0c3c4c004d5081b91ffe278850d1b1821e4f63b4
Python Version: Python 2.7.12

@rlllam check #3432

@Nik0lashka I relaunched like 90times and its still the same...
Also tried the bot on a brand new account and the problem is still there

I got the same problem, and when i play on my phone there is no pokestop, gym or anything. Help pleasee

apparently they modified the server so that your ip would get banned if you're running too many bots
the max bots/ip is 2 now i think


The short version day of the week are incorrect in Korean

long and short versions day of the week is same.
It's incorrect
It need to be short

Thanks for the report, however, translations are handled at Transifex.


Hiding the calendar completely isn't documented / working

Hi,
thanks or this great software :)
But - I haven't found a way to hide it completely (I'm using MMM-ProfileSwitcher and MMM-OnScreenMenutogether, withMMM-ProfileSwitcher` using a timer to switch back to the default view) ...
MMM-CalendarExt2 ignores being hidden (which it shouldn't, imho!) and also doesn't really allow scenes that don't have any views in them (which would be an alternative).
CSS allows some way of accomplishing this, but that still means the DOM contains all objects and all calendar fetchers etc are running, all rendering is happening, etc ...
I think that if the module is hidden none of that should happen.
Thanks!
count

Hmmm.. This module also respect .hide() and .show() convention of MM.
https://github.com/eouia/MMM-CalendarExt2/blob/b05ab5293d221aef191da196d248e85656ac2004/MMM-CalendarExt2.js#L245-L259
so by just calling hide(), all views could be hidden. If not work, As far as I experience, most cases were lockstring priority issues.
To hide/reveal specific views per page or profile(if status could be detectable by notification), you can compose scenes per page then rotate them by notification.

Hmm. How can I figure out/debug logstring issues?
I've tried using Notifications, but something is going wrong there, at least when using timers per https://github.com/tosti007/MMM-ProfileSwitcher#configuring-timers -
  modules: [
    {
      module: 'MMM-ProfileSwitcher',
      config: {
        enterMessages: false,
        leaveMessages: false,
        timers: {
          'Calendar': {},
          'Control': {},
        }
      }
    },
[..]
    {
      module: "MMM-CalendarExt2",
      config: {
        calendars: [
          {
            icon: 'calendar',
            name: 'Mirror',
            url: 'http://REDACTED/mirror.ics',
          },
          {
            icon: 'calendar-times',
            name: 'Feiertage',
            url: 'https://calendar.google.com/calendar/ical/de.german%23holiday%40group.v.calendar.google.com/public/basic.ics'
          },
        ],
        views: [
          {
            name: "week",
            mode: "week",
          },
          {
            name: "none",
            mode: "daily",
            slotCount: 0,
          },
        ],
        scenes: [
          {
            name: "Calendar",
            views: ["week"],
          },
          {
            name: "Control",
            views: ["none"],
          },
          {
            name: "default",
            views: ["none"],
          },
        ],
        notifications: {
          "CHANGED_PROFILE": {
            exec: "changeSceneByName",
            payload: (payload) => { console.log("XXX"); console.log(payload.to); console.log("YYY"); return payload.to }
          }
        },
      },
      classes: 'Calendar'
    },
[..]
    {
      module: 'MMM-OnScreenMenu',
      position: 'bottom_right',
      config: {
        touchMode: true,
        menuItems: {
          /*
          notify0: {  title: "Default",
                                    icon: "undo",
                                    notification: "CURRENT_PROFILE",
                                    payload: "default" },
          */
          notify1: {  title: "Calendar",
                                    icon: "calendar",
                                    notification: "CURRENT_PROFILE",
                                    payload: "Calendar" },
          notify2: {  title: "Control",
                                    icon: "calculator",
                                    notification: "CURRENT_PROFILE",
                                    payload: "Control" },
          openDevTools: {  title: "DevTools",
                                    icon: "crosshairs"},
          refresh: { title: "Refresh MagicMirror", icon: "refresh", source: "ALL" },
        },
        enableKeyboard: true,
      },
      classes: 'default everyone'
    },

It seems like https://github.com/eouia/MMM-CalendarExt2/blob/master/CALEXT2_Scene.js#L17 is being called twice when the automatic timer hits and sends back to the "default" profile, maybe that's causing trouble?
How would I debug lockstring issues?

Personally I'm not using ProfileSwitcher and OnScreenMenu.
I'll try to install ProfileSwitcher and inspect what happens.

Thanks for the assistance :) I have limited experience with the MMM code (yet), and keep on tossing in console.log() mostly ;)

console.log is real magic tool. I'm also dependent to it.
Anyway, I've installed https://github.com/tosti007/MMM-ProfileSwitcher now then tried this configuration.
{
  module: 'MMM-ProfileSwitcher',
  config: {
    defaultTime: 10000,
    timers: {
      'default': {
        profile: "Calendar"
      },
      'Calendar': {
        profile: 'default',
      },
    }
  }
},

Set clock as default and CALEXT2 as Calendar. (Not test OnScreenMenu, I have no touch input at this moment, but I think enough to prove the module's working.)

Hm. I wonder what's different in my setup.
I can switch to the Calendar view (and see the calendar), and the automatic switch back doesn't remove the calendar. No idea whether enterMessages: false, leaveMessages: false, make a difference.
You can use the OnScreenMenu via Keyboard, use the key left of the right ctrl key to open and then the cursor keys and return.
I wonder what oddity I configured there 🤔 ..
If you say show/hide should be respected anyway - how can I debug why it isn't?

Hmmm....
{
    module: 'MMM-OnScreenMenu',
    position: 'top_left',
		classes: "default everyone",
		config: {
        touchMode: true,
        menuItems: {
            refresh: { title: "Refresh MagicMirror", icon: "refresh", source: "LOCAL" },
        },
        enableKeyboard: true,
    }
},

I don't know this is your wants but anyway, I can get these screens.

Can you try:

a default screen without calendar
menu item that allows you to switch to a screen with a calendar
a timer that switches you back to the default screen

.. in my case, the calendar then stays active.

https://www.dropbox.com/s/d7vikdwcsruszmd/temp.mov?dl=0
I made 3 pages (default -> another -> calendar -> back to default) then I tried in default page activate the menu. screen jumps to calendar directly then back to default without issue.

Super odd.

I've sent you something per Mail directly. If you've got any idea how to debug further, any ideas are welcome. I might have to try and get to a minimal config that exposes the bug, or it might be an artifact of the specific revisions I'm running (but should be :latest and master in all cases, no dev versions).

hi, I found a bug with CExt2 hidding/showing.
maybe it's a MagicMirror Core bug ...
@eouia is working around, please wait ;)

ok maybe its related to my post here
Im trying to find an answer but cannot find a solution... @eouia can you please check that out and see if its related (config on my posts) im not a coder and im learning by myself
thanks so much in advanced

This is issue is gone in the latest version! \o/


Revert #96 but keep the test

#96 was a work-around for Ray 1.2.0 to support torch.Sequential. @ConeyLiu 's fix in ray is included in Ray 1.3.0, thus we no longer need this. But the unit test is kept.

thanks.


Router === null on SSR

Just when I activate the module federation on the webpack config.
The value router from const router = useRouter(); in my _app.tsx comes up as null
Any idea what could be happening?
Thanks in advance!

Im having the same issue!
Im using internalisation as recommended in the Next JS documentation. See here: https://nextjs.org/docs/advanced-features/i18n-routing
And as soon as I integrated the Module Federation in the next.config.js file, the router from useRouter() came as null in my _app.tsx as well.
It would be great to have an answer to this!

Hi @gl0gl0 @Sofialp , the last Next.js release (v10.0.5) fixed this issue.

Hi @gl0gl0 @Sofialp , the last Next.js release (v10.0.5) fixed this issue.

Hi @noreiller ! Thanks for getting back!
I've just upgraded to v10.0.5 but still getting the error.
My code:
import React from 'react';
import { AppProps } from 'next/app';
import { IntlProvider } from 'react-intl';
import { useRouter } from 'next/router';
....

const AppComponent = ({ Component, pageProps }: AppProps): React.ReactElement => {
  const router = useRouter();
  console.log('AppCompoenent');
  console.log(router); // router null here
  const { locale, defaultLocale, pathname } = router;
  ....

  if (pathname.match('/login')) {
    // No layout
    return (
      <>
        <AuthProvider>
          <IntlProvider locale={localeIntl} defaultLocale={defaultLocale} messages={messages}>
            <GlobalStyles></GlobalStyles>
            <Component {...pageProps}></Component>
          </IntlProvider>
        </AuthProvider>
      </>
    );
  }

  // On any other part of the app, use general layout
  return (
    <AuthProvider>
      <IntlProvider locale={localeIntl} defaultLocale={defaultLocale} messages={messages}>
        <SiteLayout>
          <GlobalStyles></GlobalStyles>
          <Component {...pageProps}></Component>
        </SiteLayout>
      </IntlProvider>
    </AuthProvider>
  );
};

AppComponent.getInitialProps = async ({ ctx }) => {
  try {
    const cookies = nookies.get(ctx);
    const { pathname } = ctx;
    // Check for user token, if it doesn't exist then is not yet authenticated
    if ((cookies.token === undefined || cookies.token === '') && pathname !== '/login') {
      throw new Error('User is not authenticated');
    }
    return {
      props: {},
    };
  } catch (err) {
    ctx.res.writeHead(302, { Location: '/login' });
    ctx.res.end();
    return { props: {} as never };
  }
};

export default AppComponent;

Do you know if there's anything I'm missing?
I'm using Next v10.0.5, Webpack v5.16.0, @module-federation/nextjs-mf v0.0.2
Thanks!

Hi @noreiller ! Thanks for getting back!
I've just upgraded to v10.0.5 but still getting the error.
My code:
import React from 'react';
import { AppProps } from 'next/app';
import { IntlProvider } from 'react-intl';
import { useRouter } from 'next/router';
....

const AppComponent = ({ Component, pageProps }: AppProps): React.ReactElement => {
  const router = useRouter();
  console.log('AppCompoenent');
  console.log(router); // router null here
  const { locale, defaultLocale, pathname } = router;
  ....

  if (pathname.match('/login')) {
    // No layout
    return (
      <>
        <AuthProvider>
          <IntlProvider locale={localeIntl} defaultLocale={defaultLocale} messages={messages}>
            <GlobalStyles></GlobalStyles>
            <Component {...pageProps}></Component>
          </IntlProvider>
        </AuthProvider>
      </>
    );
  }

  // On any other part of the app, use general layout
  return (
    <AuthProvider>
      <IntlProvider locale={localeIntl} defaultLocale={defaultLocale} messages={messages}>
        <SiteLayout>
          <GlobalStyles></GlobalStyles>
          <Component {...pageProps}></Component>
        </SiteLayout>
      </IntlProvider>
    </AuthProvider>
  );
};

AppComponent.getInitialProps = async ({ ctx }) => {
  try {
    const cookies = nookies.get(ctx);
    const { pathname } = ctx;
    // Check for user token, if it doesn't exist then is not yet authenticated
    if ((cookies.token === undefined || cookies.token === '') && pathname !== '/login') {
      throw new Error('User is not authenticated');
    }
    return {
      props: {},
    };
  } catch (err) {
    ctx.res.writeHead(302, { Location: '/login' });
    ctx.res.end();
    return { props: {} as never };
  }
};

export default AppComponent;

Do you know if there's anything I'm missing?
I'm using Next v10.0.5, Webpack v5.16.0, @module-federation/nextjs-mf v0.0.2
Thanks!

I think you should use the router prop from AppProps.

I think you should use the router prop from AppProps.

Yeah, so as I turn-around that's what I'm doing, and wrapping it with hoc.
import { withRouter } from 'next/router';
const AppComponent = ({ Component, pageProps, router }: AppProps): React.ReactElement => {
  const { locale, defaultLocale, pathname } = router;
  ...
};

export default withRouter(AppComponent);

But documentation on Next, does advise to use the hook: https://share.getcloudapp.com/llunrprp
And if I remove module-federation the hook does work properly.

Yeah, so as I turn-around that's what I'm doing, and wrapping it with hoc.
import { withRouter } from 'next/router';
const AppComponent = ({ Component, pageProps, router }: AppProps): React.ReactElement => {
  const { locale, defaultLocale, pathname } = router;
  ...
};

export default withRouter(AppComponent);

But documentation on Next, does advise to use the hook: https://share.getcloudapp.com/llunrprp
And if I remove module-federation the hook does work properly.

Your example doc is for a page. Here, you try to get the router from _app. It's in the _app render props, so I would use it. This way, you don't have to use the hoc.
import { Component } from 'react';
import { AppProps } from 'next/app';

class MyApp extends Component<AppProps> {
  render() {
    const { Component, pageProps, router } = this.props;

    return (...);
  }
}

Your example doc is for a page. Here, you try to get the router from _app. It's in the _app render props, so I would use it. This way, you don't have to use the hoc.
import { Component } from 'react';
import { AppProps } from 'next/app';

class MyApp extends Component<AppProps> {
  render() {
    const { Component, pageProps, router } = this.props;

    return (...);
  }
}

Ohh I see... Makes sense, yeah, it's working like that :)
Thank you very much! 🥇

Ohh I see... Makes sense, yeah, it's working like that :)
Thank you very much! 🥇

I'm also getting this issue wether using withRouter or useRouter inside sub components, I can get the props at App level as described above but would rather not have to prop drill to every component that needs them
Running next 1.0.4, 10.0.5 or 10.0.6
I'll update as I investigate further

@csi-lk I'm seeing the same with next 10.0.5 and nextjs-mf 0.0.2. Did you find a solution to what you were seeing?

ive updated this plugin, it may help with the latest changed next made


tests: kernel: Add description for test case

Add description to test case in tests/kernel/fatal
Signed-off-by: Ajay Kishore<EMAIL_ADDRESS>

Codecov Report

Merging #8760 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8760   +/-   ##
=======================================
  Coverage   52.36%   52.36%
=======================================
  Files         195      195
  Lines       24713    24713
  Branches     5136     5136
=======================================
  Hits        12940    12940
  Misses       9699     9699
  Partials     2074     2074

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cf4937...c267f99. Read the comment docs.


Fix: remove deprecated rand

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:
that need a specific result sequence should use NewRand(NewSource(seed))

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm


Impossible to delete

Impossible to delete, translate issue?

This is probably due to your ImGui style having excessive spacing, so the confirmation button that appears below the delete button is getting cut off.  I changed the info pane window to automatically expand to fit the buttons instead of being a fixed size, but haven't made a release with that yet.  I'll try to finish up the other things that I was working on and see if I can get a release out Tuesday or Wednesday that fixes this.

The layout issues that caused this should be fixed as of version <IP_ADDRESS>.  Please let me know if you still have this problem after updating the plugin.

Yes fixed, ty ^^


[EPIC]: Update Folder Structure

Epic Description
Currently source files are on the root. Move them to an src folder
features, Tasks and/or Bugs

[x] Move files to src
[x] Update json config
[x] Make sure nothing else is broken
...

Considerations

Security:
Performance:
Accessibility:
Extensibility:
Scalability:
Usability:
Testability:
Maintainability:

The change has been made and everything is still working


[Hypersonic] Couldn't connect to Notion database

Extension
https://www.raycast.com/reboot/hypersonic
Description
I successfully connected hypersonic to my Notion account (see screenshot attached).

But hypersonic still cannot access my Notion database:

Error log attached:
APIResponseError: Could not find database with ID: db18f25f-xxxxxxxxxxxxxxxxxxxx. Make sure the relevant pages and databases are shared with your integration.     at sz (/Users/xxxxxx/.config/raycast/extensions/baa4a90b-xxxxxxxxxxxxxxxxxxxx/index.js:1:4348)     at Yi.request (/Users/xxxxxx/.config/raycast/extensions/baa4a90b-xxxxxxxxxxxxxxxxxxxx/index.js:1:324073)     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)     at async _P (/Users/xxxxxx/.config/raycast/extensions/baa4a90b-xxxxxxxxxxxxxxxxxxxx/index.js:39:77082)     at async IT.initialData (/Users/xxxxxx/.config/raycast/extensions/baa4a90b-xxxxxxxxxxxxxxxxxxxx/index.js:39:77542)
Steps To Reproduce
No response
Current Behaviour
No response
Expected Behaviour
No response

Hey @tson1111,
Do you have Full access permissions on the workspace?

Yes, I’m the owner of the workspace.

I have a similar issue, although Hypersonic does not present an error message. I gave Hypersonic access permissions to duplicate a template database to my Notion account, which it did successfully when I look inside Notion itself. However, in Raycast > My Tasks, I cannot find any database. This is what I see:

Hey @tson1111,
I would need more details to troubleshoot the issue. Could you DM me on Raycast Slack's at Ivan G.
Thanks!

Hey @DaltonThompson, same thing. I would need more details on your case. Could you DM me on Raycast Slack's at Ivan G.
Thanks!


Update build_rom.sh

Please don't build part of rom in server.. Use #failed instruction from telegram group for this


Analyzer should not accept a typedef that refers to itself via bound

The following program is accepted by the analyzer but rejected by the CFE:
typedef F<T extends F<Null>> = T Function();

main() {}

The CFE's error message is: Error: The typedef 'F' has a reference to itself.
I believe the analyzer should reject this program, because of the following spec text (from the "Type Aliases" section):

Any self reference in a type alias, either directly or recursively via another type declaration, is a compile-time error.

We will probably want to fix this issue either before or during our work on analyzer support for non-function type aliases.

After further experimentation it seems that the analyzer and the CFE have a number of differences in how they check for circularities.  I've filed a language issue, and I'll postpone further work on this until that language issue is resolved: https://github.com/dart-lang/language/issues/1261

@eernstg do we have a resolution for this?

I've proposed an update to the language specification in https://dart-review.googlesource.com/184460 which specifies the strict approach (where both body dependencies and bound dependencies give rise to a cyclicity error). This allows us to relax the rule later on (to allow bound dependencies), which would be a non-breaking change.
I've added a language test in https://dart-review.googlesource.com/c/sdk/+/186290, covering areas that weren't already covered for this topic.
The example here is flagged as an error by both the analyzer and the CFE today.
The new test causes a crash in the CFE, cf. https://github.com/dart-lang/sdk/issues/45085, but the analyzer already passes the new test (and the existing ones), so there is no implementation effort associated with the language rule itself.

This seems to be fixed.


unknown generation error while consuming using consumer group

Versions
Sarama Version:1.21.0
Kafka Version: 1.1.0
Go Version:1.12
Configuration
		cfg.Consumer.Group.Session.Timeout = 20 * time.Second
		cfg.Consumer.Group.Heartbeat.Interval = 6 * time.Second

Logs
ERRO[0051] kafka: error while consuming <topic-name>: kafka server: The provided member is not known in the current generation.

Problem Description
We have a library that provide some abstraction over sarama consumer group. while using the library I see lots of above ^^ errors. I have already looked at session timeout values, but no help. @dim can you please help me understand this error and point towards some steps?

@bai have you seen this error ever?

Possibly related? https://github.com/bsm/sarama-cluster/issues/29

Thanks Bai, that's helpful.

Hey @dim I think I need your help here. I have tried bunch things but still getting below error in sarama logs.
ERRO[0098] kafka: error while consuming ewr.kessel-run.mt-raw.1/8: kafka server: The provided member is not known in the current generation.  offset=-3 partition=-1 topic=unknown type=kafka
ERRO[0098] kafka: error while consuming ewr.kessel-run.mt-raw.1/1: kafka server: The provided member is not known in the current generation.  offset=-3 partition=-1 topic=unknown type=kafka
ERRO[0098] kafka: error while consuming ewr.kessel-run.mt-raw.1/4: kafka server: The provided member is not known in the current generation.  offset=-3 partition=-1 topic=unknown type=kafka

Here is my consumer side config -
		cfg.Consumer.Group.Session.Timeout = 20 * time.Second
		cfg.Consumer.Group.Heartbeat.Interval = 6 * time.Second
		cfg.Consumer.MaxProcessingTime = 500 * time.Millisecond

@varun06 sorry, I have been slightly distracted recently :) My apologies, but I am not 100% sure how to help. Generation errors only happen when a member tries to commit offsets after the session has been closed server side. I assume you are not stopping your consume loop quickly enough after a rebalance is triggered. The broker is then starting a new session with a new generation and giving up on the previous one. I would try to increase the Session.Timeout and see if that makes a difference.

Thanks @dim I have been playing with timeouts and they have helped, so errors are very sporadic now, I am sure it is the way we committing the offsets, we commit them in batch and that code has some oddities as you mentioned.

@varun06 can you please describe and share your timeout values with us? We have the same problem with Sarama.

@1995parham
cfg.Consumer.Group.Session.Timeout = 20 * time.Second
cfg.Consumer.Group.Heartbeat.Interval = 6 * time.Second
cfg.Consumer.MaxProcessingTime = 500 * time.Millisecond


Climate (A/C) shows off state on HA when temperature is reached

Using latest SmartIR version with Broadlink. Everything is fine with this very configuration:
smartir:
switch:

platform: broadlink
host: <IP_ADDRESS>
mac: '00:00:00:00:00:00'

climate:

platform: smartir
name: Office AC
unique_id: office_ac
device_code: 1000
controller_data: <IP_ADDRESS>
temperature_sensor: sensor.temperature
humidity_sensor: sensor.humidity
power_sensor: binary_sensor.ac_power

but if I set, for example, 25 as target temperature, when the ambient temperature (from sensor.temperature) is reached climate entity switches to off status (I mean that HA don't send the off code - it's just a matter of the entity state) while of course the A/C is still on. If the target temperature is not reached, everything works fine and the entity stays on "cool".
Is that an issue or am I missing something?

closed


Update precommit

This updates the precommit to use the latest JuliaFormatter precommit, and excludes the templates from the toml and yaml checkers.

The worst part is that I knew this, but somehow just looked at the latest release on github and moved on with my life...

The worst part is that I knew this, but somehow just looked at the latest release on github and moved on with my life...

Right, it is confusing that it still shows that as the latest tagged release on the Github page.

Thanks!


refactor(goal_planner): reduce call to isSafePath

Description
depends https://github.com/autowarefoundation/autoware.universe/pull/8795
Related links

CompanyName internal link

How was this PR tested?
https://evaluation.tier4.jp/evaluation/reports/98dbc36e-c79a-53f0-a930-5aac27de1c95?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

I applied suggestions


cheat: 4.0.0 -> 4.0.2

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/cheat/versions.
meta.description for cheat is: "Create and view interactive cheatsheets on the command-line"
meta.homepage for cheat is: "https://github.com/cheat/cheat"
meta.changelog for cheat is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 4.0.2 with grep in /nix/store/2anrg2njc9fnlzvjywlzwnra41vglnfh-cheat-4.0.2

directory tree listing: https://gist.github.com/f01d08b6d6b7b4056b3f05b70b80d323

du listing: https://gist.github.com/4870f2ecc6816dfd2a623b8adec82da9

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
cheat

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2anrg2njc9fnlzvjywlzwnra41vglnfh-cheat-4.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cheat https://github.com/r-ryantm/nixpkgs/archive/870081decf593efb0eac0299a7213aac87fc5b66.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2anrg2njc9fnlzvjywlzwnra41vglnfh-cheat-4.0.2
ls -la /nix/store/2anrg2njc9fnlzvjywlzwnra41vglnfh-cheat-4.0.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

cheat

Maintainer pings
cc @mic92 @kalbasit for testing.

Result of nixpkgs-review pr 94371 1

1 package built:
- cheat


Add "--narrow" option for more details in case of frameskips present

Please see arguments for "--narrow" option in this posting:
https://forums.raspberrypi.com/viewtopic.php?p=2171665#p2171665
"--narrow" allows for avoiding frameskips dominate y-axis resolution:

@naushir I did the changes you requested, and followed instructions regarding git commit --amend:
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message
I got into trouble with merge conflicts, but finally got problems resolved.
The new hash shows both requested changes, to commit message and line 73 of timestamp.py:
https://github.com/Hermann-SW/rpicam-apps/commit/0fe3a4209c96fa62e23d22a45e5c0fbb0d55af14

Thanks for the updates.  I'll squash these changes and merge them manually now.


TEMP: Delete 0MQ tests to check if they are hanging Travis.

Indeed, the 0MQ tests were the issue. See #982.


[KEP-3973]: docs for DeploymentPodReplacementPolicy

add docs for DeploymentPodReplacementPolicy feature

https://github.com/kubernetes/kubernetes/pull/123430
https://github.com/kubernetes/enhancements/issues/3973

Heads up that dev-1.31 branch is created now, if you choose to reopen this for the new release.

Hello @atiratree :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

Hi @atiratree, please move this PR from Draft to ready-for-review, if it is ready to be reviewed, thank you!

Hi @atiratree, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

Hi @atiratree, reminder that today is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before today at 18:00 PST.

I am sorry for the delay, the PR is ready for review.

the main PR is still not merged yet
/hold

Hi @atiratree, I will close this Doc PR since the associated KEP did not meet the code freeze deadline and the exception request was not approved. Feel free to reopen, target the next milestone, when it is created, or ping me if anything changes. Thank you!
/close


Use of imprecise data types bool instead of bool?

Among other things I am using the this component to convert between the different API versions and representations.
The reason is that some properties are currently modelled as bool instead of bool? it cannot be differentiated, if a value was set before or not. In the writer-Source it is solved by hardcoding default-values and ommitting the write step if the boolean value and the default value are equal. While this works well for the writer this information gets lost in the global objects and cannot be used in other tools. Or the hard-codings have to be re-done.
It would be much nicer to replace the bool by bool? and add a function for getting the default value, if not set. This way the default values need only to be implemented once and the information is not lost. It is even possible to create a backwards-compatible version returning a bool with the default value if the bool? is null...
For example in OpenApiSchema bool? is used several times like with UniqueItems
Only bool is used at least for the following properties:
OpenApiParameter.AllowReserved
OpenApiParameter.AllowEmptyValue
OpenApiParameter.Deprecated
OpenApiParameter.Explode
OpenApiParameter.Required

OpenApiHeader.AllowReserved
OpenApiHeader.AllowEmptyValue
OpenApiHeader.Deprecated
OpenApiHeader.Explode
OpenApiHeader.Required

OpenApiRequestBody.Required

OpenApiSchema.AdditionalPropertiesAllowed
OpenApiSchema.Nullable
OpenApiSchema.Deprecated
OpenApiSchema.ReadOnly
OpenApiSchema.WriteOnly

Hey @AP-G thanks for raising this issue.  How about if we implemented IsXXXDefault functions for all properties that have a non-null default?


ARROW-5260: [Python] Fix crash when deserializating from components in another process

Trying to debug an AppVeyor failure...

@wesm Can you reproduce the issue I'm having on AppVeyor? I really don't understand what is happening:
https://ci.appveyor.com/project/pitrou/arrow/builds/24370752/job/kgelhsewticqkfdt

I think I managed to fix the AppVeyor issue.


Multi-root VS Code workspace

This doesn't seem to work in a multi-root VS Code workspace.
node --inspect-brk ${workspaceRoot}/node_modules/.bin/jest -i "-t sendMessageTest"
➜  functions git:(task-notifications) ✗ node --inspect-brk ${workspaceRoot}/node_modules/.bin/jest -i "-t sendMessageTest"
Debugger listening on ws://<IP_ADDRESS>:9229/a8018417-3540-46de-b81e-25c8a7090175
For help see https://nodejs.org/en/docs/inspector
Debugger attached.
module.js:538
    throw err;
    ^

Error: Cannot find module '/node_modules/.bin/jest'
    at Function.Module._resolveFilename (module.js:536:15)
    at Function.Module._load (module.js:466:25)
    at Function.Module.runMain (module.js:676:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3

an easy way to resolve this would be:
i could check if the addon finds jest in the workspace e.g. '/node_modules/.bin/jest' if not use the global jest version.
of course this would require a globally installed jest version.
what do you think ?
best regards
Tristan

Yea that would definitely work. Before you do anything I'll dig around a little.
workspaceRoot has been deprecated for workspaceRootFolder. But I think it's still going to yield the same results. There's got to be an API to get the workspace project name and then do a ${workspaceRootFolder:project} as a compound per https://code.visualstudio.com/docs/editor/multi-root-workspaces
That's just me quickly looking at this though.

hey sir,
i have found out i should now use ${workspaceFolder}
furthermore i added a jestPath config varialbe where you can define the absolut path to jest.
because if you ran run Jest im running jest from terminal and can't even use this vscode variables e.g ${workspaceFolder}
can you check how this works out for vscode workspaces ?

Sweet. Yea the jestPath worked well.
But I'm still getting an error with the default config. Definitely looks like it should be working.
➜  functions git:(task-notifications) ✗ node --inspect-brk=17060 --inspect-brk ${workspaceFolder}/node_modules/.bin/jest -i -t sendMessageTest
Debugger listening on ws://<IP_ADDRESS>:17060/5a5d99b0-5210-4695-bfca-719489b5a37d
For help see https://nodejs.org/en/docs/inspector
Debugger attached.
module.js:538
    throw err;
    ^

Error: Cannot find module '/node_modules/.bin/jest'
    at Function.Module._resolveFilename (module.js:536:15)
    at Function.Module._load (module.js:466:25)
    at Function.Module.runMain (module.js:676:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3

${workspaceFolder}/node_modules/.bin/jest seems correct per https://code.visualstudio.com/docs/editor/variables-reference#_variables-scoped-per-workspace-folder
Debugging
I'd debug this myself, but getting set up to debug an extension seems like more time than I have today or tomorrow. Multi-root workspaces are super easy to create if you have tried it.

But I certainly don't mind helping out. If you assign this over to me I might have some time this weekend.

Great extension by the way. vscode-jest is also great, but it was a little too obtrusive for me. Got annoyed with it after a few minutes.

changed it again to always to the first workspace folder
https://github.com/firsttris/vscode-jest-runner/blob/master/src/extension.ts#L21
(for run & debug)
let me know how this works


Hey, can the extension close itself when I copy a value?

Hello Team 👋
Describe the feature that you want see
If you need more details, feel free to ask :D

Hey @vhoyer 👋 this is really a nice idea 👍 On the other hand I think it will be a bit confusing for new users so I think it's time to implement a settings page 🚀

Hey @vhoyer 👋 this is really a nice idea 👍 On the other hand I think it will be a bit confusing for new users so I think it's time to implement a settings page 🚀


ci(release): fix naming in release config

Self explanatory

Codecov Report

Merging #52 (559c6ce) into main (46d2e40) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   83.62%   83.62%
=======================================
  Files           5        5
  Lines         116      116
=======================================
  Hits           97       97
  Misses         19       19

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update Backend Documentation

Description
Updating documentation for the backend project.
Checklist

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation

 Test Endpoints HTTP & Update Backend Documentation


Added option to override the channel

I've added the option to override the channel that is notified on a per project basis, mostly copy/pasted from the functionality that already exists in your Slack plugin.

Thanks!

👍 Can we have a release, in order to be able to update from the built-in plugin manager.


Add script for add code/api snippets into docs.

This script will go through the markdown documentation and inserts code examples and api docstrings into the docs.
This code needs to import mesop, so your terminal needs to have mesop imported via pip.
It does not seem to work when .cli.venv is loaded.
python transform_markdown.py
python transform_markdown.py --cache_files_list
python transform_markdown.py --use_cached_files_list

You can use the cached_files list to create a block list to ignore specific files that are not relevant.
This script is not integrated with the existing workflow yet.

It fails to find:

mesop.components.select.select.SelectOpenedChangeEvent
mesop.components.progress_bar.progress_bar.ProgressBarAnimationEndEvent

These two classes do not seem to be imported in the init.py file in Mesop, so I can look the inspect the classes. Not sure if that's intentional or not.

This script will go through the markdown documentation and inserts code examples and api docstrings into the docs.
This code needs to import mesop, so your terminal needs to have mesop imported via pip. It does not seem to work when .cli.venv is loaded.
python transform_markdown.py
python transform_markdown.py --cache_files_list
python transform_markdown.py --use_cached_files_list

You can use the cached_files list to create a block list to ignore specific files that are not relevant.
This script is not integrated with the existing workflow yet.
It fails to find:

mesop.components.select.select.SelectOpenedChangeEvent
mesop.components.progress_bar.progress_bar.ProgressBarAnimationEndEvent

These two classes do not seem to be imported in the init.py file in Mesop, so I can look the inspect the classes. Not sure if that's intentional or not.

We should export those two classes since they're part of our public API. I think it was just an oversight

Ok.

Exported the progressbar end event and the select opened change event to the mesop init object.
Also added a check for enabling both flags at the same time (I had left it as is since I think it would be a noop in that situation. Would just end up overwriting the existing file with the same cached elements, but I think easy enough to add a check)


update

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

update


Can this be somehow used to smart-detect background image and replace it in realtime?

Can this be somehow used to smart-detect background image and replace it in realtime?

You want something like what zoom or skype offer? I mean to retain the face unaltered but replace the background with a custom image? I suppose you tried the wasm version...

@esimov yea, exactly, did not try anything yet, first thing that came to my mind when I saw this lib, was can I do smart background replacement with it :)
I know it can be done using python, but I like that this is golang lib :)


openscapes: Fix extraVolumeMounts being overriden

Follow-up to https://github.com/2i2c-org/infrastructure/pull/3388, which otherwise basically just didn't mount home directories at all!
Fixes https://github.com/2i2c-org/infrastructure/pull/3388

Merging this as otherwise openscapes prod folks could lose data. Currently I manually deployed from my laptop to prevent that.


WP/DeprecatedParameters: add support for PHP 8.0+ named parameters

Adjusted the way the correct parameter is retrieved to use the new PHPCSUtils 1.0.0-alpha4 PassedParameters::getParameterFromStack() method.
Verified the parameter name used is in line with the name as per the WP 6.1 release.
WP has been renaming parameters and is probably not done yet, but it doesn't look like those changes (so far) made it into changelog entries.... sigh.
It also looks like in the past, deprecated parameters were being renamed to $deprecated on deprecation. This practice should be strongly discouraged in the context of named parameters, but that's a different discussion and outside of the scope of this commit.
For the purposes of this exercise, I've taken the current parameter name as the "truth" as support for named parameters hasn't officially been announced yet, so any renames after this moment are the only ones relevant.
Adjusted the error message/data determination to take named parameters into account.

Name verification notes:

Removed the comments_link() function.
Per the changelog, the previously deprecated fourth parameter is now being used for something else since WP 5.4.0....
Far from best practice, but it is what it is, so I've removed the listing for that function.

What has not been done: a scan of the WP Core codebase to find newly deprecated parameters.
Includes additional unit tests and updating one existing test to ensure the code logic is properly covered.

Note: I thought of updating the error message to no longer refer to the position of the parameter, but to use the parameter name instead (with a "Found: %s" for displaying value), as in:
# Current:
The parameter "$variable" at position #2 of wp_new_user_notification() has been deprecated since WordPress version 4.3.1. Instead do not pass the parameter.

# Variation:
The $deprecated parameter of the wp_new_user_notification() function has been deprecated since WordPress version 4.3.1. Instead do not pass the parameter. Found: $variable

... but as WP renamed all deprecated parameters to $deprecated, this wouldn't necessarily be more descriptive than it is now.
Along the same lines, I considered updating the error code to refer to the param name instead of the position, but aside from it not making things more descriptive as things are, that would also constitute a BC-break which I don't think is warranted.
Opinions appreciated.

Along the same lines, I considered updating the error code to refer to the param name instead of the position, but aside from it not making things more descriptive as things are, that would also constitute a BC-break which I don't think is warranted.

If there are no noticeable benefits I don't think we need to change the error codes.


Implement a new JWT Token Issuer

The following rfc [1] supports for JWT tokens as OAuth2 access tokens. This task is to track and implement a new JWT Token Issuer based on that specification.
[1] https://datatracker.ietf.org/doc/html/rfc9068

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Crashes on Mac

VS Code keeps crashing. I was trying to open a file and i noticed that it doesn't open. Tried again with terminal even without extensions but same. It opens and crashes immediately.

GPU Status:       2d_canvas:                     enabled
flash_3d:                      enabled
flash_stage3d:                 enabled
flash_stage3d_baseline:        enabled
gpu_compositing:               enabled
multiple_raster_threads:       enabled_on
native_gpu_memory_buffers:     enabled
oop_rasterization:             disabled_off
protected_video_decode:        unavailable_off
rasterization:                 enabled
skia_deferred_display_list:    disabled_off
skia_renderer:                 disabled_off
surface_synchronization:       enabled_on
video_decode:                  enabled
viz_display_compositor:        disabled_off
webgl:                         enabled
webgl2:                        enabled
CPU %	Mem MB	   PID	Process
2	    41	  3574	code main
0	     0	  3579	   gpu-process
0	    25	  3581	   window (index.html — CSSCalc)
0	     0	  3584	     extensionHost
0	     0	  3591	       /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/json-language-features/server/dist/jsonServerMain --node-ipc --clientProcessId=3584
0	     0	  3592	       electron_node tslintServer.js
0	     0	  3623	       electron_node tsserver.js
0	     0	  3629	         electron_node typingsInstaller.js typesMap.js
0	     0	  3628	       /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/html-language-features/server/dist/htmlServerMain --node-ipc --clientProcessId=3584
0	     0	  3585	     watcherService
8	    16	  3586	   shared-process
0	     0	  8956	     /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
Workspace Stats:
|  Window (index.html — CSSCalc)
|    Folder (CSSCalc): 2 files
|      File types: js(1) html(1)
|      Conf files:
Steps to Reproduce:

Close VS Code
Reopen it

Does this issue occur when all extensions are disabled?: Yes

Update: restarting mac fixed the issue. but still worth checking


Order modal show price

Fixes #391
This PR adds the fuctionallity propsed by @SchrodingersGat in #391 in 2019.
In the part-order-modal the price of each supplier-part (based on the entered quantity) is displayed. A custom submit button enables reloading the supplier-part selection screen to update the prices.

Still seeing the error, not sure what I'm doing wrong, this part has prices set for multiple suppliers as shown in the first screenshot.

@SchrodingersGat right. I could reproduce and fix it with the fixtures loaded. Will start doing that instead of using my own testing database. Should work now.

@matmair still having some issues:
Firstly, I definitely have supplier pricing set:

However when I click the "order" button (on the same page):

Also, when I hit "Update Prices" I get the following screen:

Note that this part is marked as purchasable:

Also, the "Update Prices" button seems to persist on other modals once it is drawn:

Looks like these extra modal buttons need to be explicitly reset

@matmair that's fixed the zero-pricing issue, nice work.
However the extra button still persists on the next modal you launch after closing that one:

@SchrodingersGat I found a few other problems while debugging this, will ping you when I ironed out everything.

I fixed the button always appearing but still working on another the quantity-zero issue and on errors not finished multi-part modals reappear.

ok no worries, let me know when you are again ready for review.

Also, when I hit "Update Prices" I get the following screen:

@SchrodingersGat turns out that dropping all parts with a quantity of zero is no bug but hardcoded behaviour. I think that makes sense. The question is if the start-quantity should be 1 by default (currently 0) to prevent confusion.

Fair enough, this makes sense. Thanks for your work on this.


Table Chart: Emit filters for metric

The table chart is able to emit filters when you click on a cell. For example a cell with 2007 in the year column.
However when you click on a cell from a metric column nothing happens. This PR adds the ability to click on a metric and emit a filter for every column of the row which contributes to the chosen metric.

ho for sure, this is for upstream. However we can now build this try it out and use it right away before waiting for branch of superset 1.4 or 1.5.


MSBuild doesn't find targets if parentheses in solution folder names

When I try to build V8 for ArangoDB, two solution files are generated by gyp(?). If I try to build the projects/targets v8, v8_libbase or v8_libplatform by build script or manually, msbuild will fail because it can't find the targets:
> msbuild all.sln /t:v8
error MSB4057: the target package "v8" does not exist in the project

The projects clearly do exist, but they are (for whatever reason) nested in solution folders like this:
(tools)
    |_ (gyp)
           |_ v8

Note the brackets () in the folder names. If I remove them, msbuild all.sln /t=tools\gyp\v8 will work!
So nesting is generally supported, but parentheses cause trouble. I couldn't find a way to escape them, and I don't know how to change the sln generator to not nest projects. If I remove the solution folders entirely, msbuild all.sln /t:v8 will also work.
Solution file: https://dl.dropboxusercontent.com/u/39101475/BugReports/all.sln
Maybe somewhere around here escaping or I don't know what needs to be done:
https://github.com/Microsoft/msbuild/blob/master/src/XMakeBuildEngine/BackEnd/Components/RequestBuilder/TargetBuilder.cs#L171

A workaround:
Use %28 as the escape of ( and %29 as the escape of ).


Remove Assignment to Variable without use

Summary of the Pull Request

References

PR Checklist

[] Applies to #xxx
[] CLA signed. If not, go over here and sign the CLA
[] Tests added/passed
[] Requires documentation to be updated
[] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@sqrlmn, we're going to close these.  As with all PRs, Style chances and refactoring work should be discussed before anything is done as they are large PRs and have downstream impact on large work items being done.


Core dump occurs sometimes when drop Shared memory.

When I use bytes to parse HTTP2 request headers, I sometimes get a coredump, but I don't know what the possible cause is. I'm not sure if the latest version will have this problem yet.
Bytes version: 0.5.4
h2 version: 0.2.4
The GDB trace is as follows:
#0  0x000055f2e19380d4 in bytes::bytes_mut::shared_v_drop () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#1  0x000055f2e18e351d in h2::hpack::decoder::Decoder::decode () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#2  0x000055f2e18f5d28 in h2::frame::headers::HeaderBlock::load () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#3  0x000055f2e13de55c in <h2::codec::framed_read::FramedRead<T> as futures_core::stream::Stream>::poll_next () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#4  0x000055f2e0f65de3 in h2::proto::connection::Connection<T,P,B>::poll () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#5  0x000055f2e100cbda in <futures_util::future::poll_fn::PollFn<F> as core::future::future::Future>::poll () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#6  0x000055f2e14c4910 in <futures_util::future::select::Select<A,B> as core::future::future::Future>::poll () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#7  0x000055f2e108f923 in <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#8  0x000055f2e0f4865d in tokio::task::core::Core<T>::poll () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#9  0x000055f2e0d3fb22 in tokio::task::harness::Harness<T,S>::poll () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#10 0x000055f2e18fe187 in tokio::runtime::thread_pool::worker::GenerationGuard::run_task () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#11 0x000055f2e18fd96b in tokio::runtime::thread_pool::worker::GenerationGuard::run () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#12 0x000055f2e1905809 in std::thread::local::LocalKey<T>::with () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#13 0x000055f2e18fd807 in tokio::runtime::thread_pool::worker::Worker::run () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#14 0x000055f2e1906f67 in tokio::task::core::Core<T>::poll () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#15 0x000055f2e191b2c3 in tokio::task::harness::Harness<T,S>::poll () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#16 0x000055f2e19009eb in tokio::runtime::context::enter () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#17 0x000055f2e191ac07 in std::sys_common::backtrace::__rust_begin_short_backtrace () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#18 0x000055f2e18ffa58 in core::ops::function::FnOnce::call_once{{vtable-shim}} () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154
#19 0x000055f2e1978033 in <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/alloc/src/boxed.rs:1854
#20 <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once () at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/alloc/src/boxed.rs:1854
#21 std::sys::unix::thread::Thread::new::thread_start () at library/std/src/sys/unix/thread.rs:108

(gdb) disassemble
Dump of assembler code for function _ZN5bytes9bytes_mut13shared_v_drop17hde8cf96771c42cfaE.llvm.13582749843687747861:
   0x000055f2e19380d0 <+0>: push   %rbx
   0x000055f2e19380d1 <+1>: mov    (%rdi),%rbx
=> 0x000055f2e19380d4 <+4>: lock subq $0x1,0x20(%rbx)
   0x000055f2e19380da <+10>: jne    0x55f2e1938107 <_ZN5bytes9bytes_mut13shared_v_drop17hde8cf96771c42cfaE.llvm.13582749843687747861+55>
   0x000055f2e19380dc <+12>: mov    0x8(%rbx),%rsi
   0x000055f2e19380e0 <+16>: test   %rsi,%rsi
   0x000055f2e19380e3 <+19>: je     0x55f2e19380f3 <_ZN5bytes9bytes_mut13shared_v_drop17hde8cf96771c42cfaE.llvm.13582749843687747861+35>
   0x000055f2e19380e5 <+21>: mov    (%rbx),%rdi
   0x000055f2e19380e8 <+24>: mov    $0x1,%edx
   0x000055f2e19380ed <+29>: callq  *0x8d867d(%rip)        # 0x55f2e2210770
   0x000055f2e19380f3 <+35>: mov    $0x28,%esi
   0x000055f2e19380f8 <+40>: mov    $0x8,%edx
   0x000055f2e19380fd <+45>: mov    %rbx,%rdi
   0x000055f2e1938100 <+48>: pop    %rbx
   0x000055f2e1938101 <+49>: jmpq   *0x8d8669(%rip)        # 0x55f2e2210770
   0x000055f2e1938107 <+55>: pop    %rbx
   0x000055f2e1938108 <+56>: retq

It would be very useful to know if this is a bug that has already been fixed in a newer version of bytes or not. You may be able to use cargo patch to use the new bytes without upgrading the other crates. There are not very many breaking changes between the versions (you can see the list in our changelog), so I don't think it would be that difficult to adjust bytes or your other dependencies to work with bytes v1.

Thanks for your reply!
I read the change history of bytes from v0.5.4 to 1.1 and found no updates that might be relevant to this problem.
I tried to upgrade bytes, but bytes is so basic that many crates rely on it. During the upgrade of bytes, I encountered crate compilation problems due to dependencies such as http2, hyper, tokio, and tokio-util. This is mainly caused by the name switch of the bytes() function and the change of the UninitSlice structure. After the above compilation problem is solved, there are still compilations due to other dependencies. this problem occurs in earlier versions, so the upgrade scheme is completely unworkable for me.
My project uses a lot of crate, and this problem only occurs in a single production environment, which is difficult to debug. So I asked the community for help on possible directions.

Thanks for your reply!
I read the change history of bytes from v0.5.4 to 1.1 and found no updates that might be relevant to this problem.
I tried to upgrade bytes, but bytes is so basic that many crates rely on it. During the upgrade of bytes, I encountered crate compilation problems due to dependencies such as http2, hyper, tokio, and tokio-util. This is mainly caused by the name switch of the bytes() function and the change of the UninitSlice structure. After the above compilation problem is solved, there are still compilations due to other dependencies. this problem occurs in earlier versions, so the upgrade scheme is completely unworkable for me.
My project uses a lot of crate, and this problem only occurs in a single production environment, which is difficult to debug. So I asked the community for help on possible directions.

@Darksonn What suggestions do you have for the problem of @Chengwch

I'm not able to determine what the issue is from what's written here.  I have already spent a long time looking at the implementation for other purposes, and unless there's a PR fixing the issue in a newer version, then I didn't spot the issue when doing so.
If you're able to create a small example that triggers the problem, then that would be useful, but I realize that this is not easy either.


Spotify pauses itself when ad is muted

As title says, when the first ad starts losing up, adfree begins playing my music, then Spotify pauses itself.
I also have my music set to play until end of song. When my song ends, next ad properly plays while muted, my local song starts again, but the 2nd ad was shorter so after a short time, I have a muted Spotify song playing as well as my local song.
Also, is it possible to have my local song just play at whatever volume I was last on? I don't want to "set" a specific music playback volume. Just have it play at what it was before adfree kicked in.
Pixel 7 Pro
Spotify version <IP_ADDRESS>0
com.spotify.music
versionCode 108008228
targetSdk 34
minSdk 21
Just recently discovered this app and finding it quite interesting and cool.
Thank you.

thanks for reaching out. the audio player is difficult to troubleshoot as it relies on device-specific behavior. while it works fine on my developer phones, addressing your particular issue may require access to a pixel phone to trouble shoot. i suggest using the mute plugin as an alternative.
if possible, consider creating a screen recording illustrating the coordination issue between ads and playback. this may help me to troubleshoot your issue. solely based on your description, it's challenging to take a meaningful action otherwise.
thanks and cheers

Ok will do.
Pixel BT has always been kind of wonky.
For 7 Pro, this seems to only happen on BT headphones.
Tested on Pixel Buds Series-A, original Wyze Headphones (not the newer gaming headphones, probably discontinued), Galaxy Buds Live, and Anker Soundcore Liberty Air (aptX capable).
The really strange thing is that this works perfectly on my car BT. That's strange because all my Pixel phones have an audio delay when watching YT in my car and always have (2017 Subaru with upgraded Harman Kardon system).

Regarding Bluetooth, there is a workaround for a Bluetooth issue. maybe this helps you as well: https://github.com/abertschi/ad-free/issues/64


Add "no-op" record mode ?

We have a test suite which, when run againts real servers, generates very different HTTP responses (with cookies, E-tags, misc tokens, dates.......).
So it'd be handy to be able to bypass vcr-marked tests when used against live server, so that existing Cassetes are neither used nor overwritten with different responses.
Thus VCR would be used only for sandbox (continuous integration), with "none" record mode, after having been updated once with "all" record mode.
What's your opinion about this evolution ?

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale and we have a lot of old tickets that need to be groomed, I'm closing this for now to make it easier to see what is still relevant.
However if it is still needed, please feel free to re-open or create a new ticket.
Thanks! 🙏


Angular 6 PWA wont loads in OS X and iOS browsers

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [x ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
OS: Mac High Sierra
iOS: 11.3
Node: 9.2.0
Angular: 6.0.8
Repro steps
navigate to https://supportchatdev.herokuapp.com on any iOS or MAC Browser
The log given by the failure

No Visible errors in console
Desired functionality
I would like to run ng serve on my MAC and test my Angular PWA.
Mention any other details that might be useful
I deployed an Angular app to Heroku and when testing the site above in the repro steps I was able to access the app just fine on any Windows browser except IE which I know I dont have the polyfills for.
When I went to that site on my iPHONE or on my MAC, the site would not load . I do not get any error other than a generic timeout from the browser (as if I was not connected to the internet). I cloned the same repo I use on my windows machine onto my mac and when I run ng serve the app builds and compiles no problem, but when I navigate to a browser (Safari, Chrome, Firefox) I just get a generic browser timeout and nothing useful in the console. If I turn WIFI off, I can access the site (localhost:4200), but the moment I turn wifi back on i get to the same timeout
I am not sure which files would be useful for people to see, so I can show those upon request.
I know the error information sucks (as I dont get any error from the console) but just wondering if there might be a solution to the problem.
Thanks for any help or insight

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

was solved? how??

@alan-agius4 I am not able to recreate the issue. When I download the initial repository from https://github.com/luixaviles/socket-io-typescript-chat I am able to run it no problem. It is not until I added my own packages that it stopped working. I will need to figure this one out some other way. Thanks

was solved? how?? i have the same problem...

@cezaraf
I have not solved it yet. Still trying

I'm sorry, but we can't reproduce the problem following the instructions you provided.
Remember that we have a large number of issues to resolve, and have only a limited amount of time to reproduce your issue.
Short, explicit instructions make it much more likely we'll be able to reproduce the problem so we can fix it.
If the problem persists, please open a new issue following our submission guidelines.
A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.