cli: add tilt kubectl, a command to run Kubectl commands with Tilt's go-client

Hello @landism, @jazzdan,
Please review the following commits I made in branch nicks/fork-kubectl:
4ef7398b1939c8391a4183107c7fffa2de044b29 (2019-08-08 19:00:02 -0400)
cli: add tilt kubectl, a command to run Kubectl commands with Tilt's go-client
b00fea6bf5348aeb9a417ee82fad4408e09a3d12 (2019-08-08 18:53:08 -0400)
vendor: downgrade kustomize to match kubernetes-1.15.0

all the important bits of this PR are in this file:
https://github.com/windmilleng/tilt/blob/4ef7398b1939c8391a4183107c7fffa2de044b29/internal/cli/kubectl.go


Bump images to track with upstream

Also add comments to note where upstream versions can be found
Pull Request Checklist

[x] Any new images or tags consumed by charts has been added here
[x] Chart version has been incremented (if necessary)
[x] That helm lint and pack run successfully on the chart.
[ ] Deployment of the chart has been tested and verified that it functions as expected.
[x] Changes to scripting or CI config have been tested to the best of your ability

Types of Change
version bump
Linked Issues

Additional Notes
After the PR is merged
Once the PR is merged, typically upon a new release, the necessary teams will be notified via Slack hook to perform the RKE2 Charts and RKE2 changes. Any developer working on this issue is not responsible for updating RKE2 Charts or RKE2.

There are new CPI versions v1.25.2 and v1.24.5 but they are 2-3 weeks new and are not in image-mirror yet so can be bumped to the next release. Relevant issue here!


Bug: Moderation view - the hover moderation actions hide quickly

These actions should stay visible the entire time the mouse is over a message card

clip of the bug


Feature Request : Allow users to import eclipse/xml color themes to VSCode

Currently there is no way of editing a color theme or importing one from a xml file. Instead, users have to rely on extensions and built-in themes. The Eclipse Color Themes extension for the Eclipse IDE allow users to make their own themes simply by editing and importing an user-friendly xml file. Allowing users to import such themes as xml's would be a great addition to the IDE, IMO. I don't know if the eclipse format is in itself compatible with how VSCode manages it's themes (would be really nice if it would), but anything close to just editing an xml file will already be a huge improvement over the current system.
Let me know what you think, and thanks in advance!

We'd rather not have a second theme definition file. But one could write an extension that lets you import an Eclipse theme and tune it. VSCode themes have many more colors which are specific to VScode and, in the end, all need to work together.
https://code.visualstudio.com/api/extension-guides/color-theme
https://code.visualstudio.com/api/references/theme-color


add --continue flag to resume/reconnect to a running conformance test

If the cluster is too weak or the network too flaky, it can happen that hydrophone loses connection to the test Pod. This currently means the test is basically dead and you have to start over.
This PR adds a new --continue flag which will simply skil the Pod creation and then connect to the existing Pod, effectively resuming the test and allowing the user to recover.

/lgtm
/approve
I would like to think how we can test this automatically. Not required but I am trying to have a test for different flags. Easier said than done :)


[RFR] Allow to display the listView even with missing references

[x] Do the job
[x] make the code look better

Fixes #346

Switching to RFR

bumps, tests are green locally.

Review applied

Green and reviewed


Add support for scanning Github projects

I had a requirement to scan remote Github projects to try and find their license.
So I took inspiration from the filesystem implementation (Licensee::Projects::FSProject) and built one which uses the Github API to resolve each of the files just in the root directory.
Is this something you might be interesting in having in the main library? If so, I can add some tests, error handling and probably a better HTTP adapter that can make requests in parallel. It would definitely be worth considering what the public interface would look like (I'm currently just using this gem from within another Ruby application, not sure if/how the CLI would change).

@nickcampbell18 Nice! I like it. FYI, we also have script/git-repo which performs a shallow clone of the Git repository, but think this could be more efficient for debugging.
If you're interested in getting this PR merged, I'd suggest taking a look at Octokit, which should have helper functions for all the endpoints we'd need.
If I'm reading correctly, it looks like we'll want to make one call to get the list of root files, and then another for each file's contents that we need, which shouldn't be too bad (and we can include instructions for passing an API key as well).

Thanks! I've made the changes and updated the usage instructions with an example of how you might want to run this, does this make sense to you? If so I'll push on and write the tests & add some better error handling.

I'd suggest taking a look at Octokit

I wasn't sure about bringing in a dependency for just this one API call, but it does make the code a bit more readable!

Thanks, I've made those changes and added tests, worth another look whenever you're ready!

A few very minor stylistic comments on the tests that were easy enough to implement. Really excited for this @nickcampbell18! Thank you!


Why many-to-many relationship not supported for Tumbling window?

Is many-to-many relationship for Tumbling window not possible or not supported now?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3d564675-f719-57fc-a406-6aec51d26b29
Version Independent ID: 84124e8f-efad-274f-c2eb-40a04748296c
Content: Pipeline execution and triggers in Azure Data Factory
Content Source: articles/data-factory/concepts-pipeline-execution-triggers.md
Service: data-factory
GitHub Login: @sharonlo101
Microsoft Alias: shlo

@ravikiran-srini Thanks for trying out azure data factory. We are investigating into your concern and will update you shortly.

@ravikiran-srini Tumbling window triggers are a type of trigger that fires at a periodic time interval from a specified start time, while retaining state. Tumbling windows are a series of fixed-sized, non-overlapping, and contiguous time intervals
Tumbling window trigger: Supports a one-to-one relationship. Only one pipeline can be triggered.
Schedule trigger: Supports many-to-many relationships. Multiple triggers can kick off a single pipeline. A single trigger can kick off multiple pipelines.
Hope this helps.

@ravikiran-srini We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


document ignore_errors

The old raven library had this functionality, implemented for Django by declaring a list of names of errors in the settings file.
This kind of functionality is necessary to control error reporting spam.

There is a ignore_errors options.

Could you please link to the documentation for this feature?  I have been finding the updated documentation for the new library frustratingly scant in its cross linkings, and laking in details that the older, mature raven library's documentation did contain.

@biblicabeebli we will add this. I'll keep this issue open as reminder

@biblicabeebli FWIW we decided not to stabilize ignore_errors for now, in the sense that you can still use it right now but we want to encourage people to use before_send for this instead: https://docs.sentry.io/learn/filtering/?platform=python#before-send
Concretely we eventually want to use the same syntax for ignore_errors that you can use in the project settings on sentry.io, such that it works the same everywhere.

I understand the urge to centralize an inherently scattered feature - integration with every framework/library requires a custom blob of code to extract the configuration correctly - but I strongly disagree with what sounds like a decision to drop probably the most basic necessary feature beyond "does it work" in an error reporting/monitoring framework.
Asking someone to write their own code to handle this particular issue is silly.  This is an error reporting platform.  The literal first thing we encountered was "oh, error X is garbage and for Capital-R Reasons we can't disable or squash it, but we don't want that particular one spamming us, how do I disable it..."  This cannot possibly be an edge case.
The above should be sufficient reason to stabilize the feature, but if its not...
This is an error reporting and monitoring framework.  If I can't block a thing at its source - because sometimes its just not possible to block a thing in the Sentry website's UI because it varies just slightly too much - then cannot use the service to monitor my servers.  Too many false negatives.  I'm going elsewhere.

what sounds like a decision to drop probably the most basic necessary feature

There is no decision yet. Stabilizing ignore_errors is in our internal backlog, but we don't know how important it is to people. In that sense, thanks for your feedback.
In any case we should come up with something that works the same across SDKs. Meanwhile you can do the same thing with before_send (for people who come across this issue from Google)
import sentry_sdk

def before_send(event, hint):
    if 'exc_info' in hint:
        exc_type, exc_value, tb = hint['exc_info']
        if isinstance(exc_value, (IgnoredErrorFoo, IgnoredErrorBar)):
            return None
    return event

sentry_sdk.init(before_send=before_send)

because sometimes its just not possible to block a thing in the Sentry website's UI because it varies just slightly too much

I mean, generally this seems like an issue on its own: That sentry is generating multiple issues for a thing you consider to be a single issue.
Just mentioning this for completeness, since it generally seems to be an underused feature: If that's the only reason why you can't send those events in the first place, consider setting a custom fingerprint for that error class (using before_send). Then those errors are grouped together and you can snooze/ignore that one issue. The nice(r) thing about this is that it doesn't require a deploy, can be undone, the data is still always there if you need it.
Sure, if you'd be over quota with those events then it's not an option and you need to block the data before.

Just arrived here since I was looking for this feature.
Will use the before_send, however it is indeed more error prone and less friendly.
Please prioritize the ignored_errors solution!

In agreement with @biblicabeebli . This is the first thing I want to configure after getting Sentry set up.
Thanks for the work-around with before_send. More flexible, not as friendly. I would have been happy if this feature, and its function in the context of ignoring exceptions, were better documented, and I'm sure I speak for other users as well.

"Stabilizing ignore_errors is in our internal backlog, but we don't know how important it is to people. In that sense, thanks for your feedback."
It's very important, imo. As others have said, please prioritize this implementation! We are using the before_send fix for now.

If I may put my two cents in, I'd say that ignore_errors/before_send seems like a positive case of scattered functionality if there may ever be one. It seems to me that the most user-friendly way to implement this would be to disallow simultaneous usage of these options and have ignore_errors be the shortcut for writing a before_send with a conditional return None. Just an idea for you guys :relaxed:

I used the workaround of before_send provided in my Flask app. But it didn't work for me as I did not get 'exc_info' in the hint.
Here is event variable data:
'logentry': {'message': '400: error: app_code key is missing: None', 'params': ()}

Please help!

Sorry for the tangent but this came up in a Google search

FWIW we decided not to stabilize ignore_errors for now, in the sense that you can still use it right now but we want to encourage people to use before_send for this instead: https://docs.sentry.io/learn/filtering/?platform=python#before-send

It's not in the documentation, but to get the same effect as ignore_errors, you instead of return event, make your before_send do return None
https://github.com/getsentry/sentry-python/blob/d25fba854956f61d67164f4056f26e58420851a4/sentry_sdk/client.py#L152-L155

Is there any working example of how to ignore a single error? The old SDK implemented this very basic functionality just fine, I don't get why it got dropped, I feel the new SDK is a huge step back compared to the previous one (since it just dropped functionality but didn't add anything new).
The documentation says:
import sentry_sdk

def strip_sensitive_data(event, hint):
    # modify event here
    return event

sentry_sdk.init(
    before_send=strip_sensitive_data
)

However, the "modify event here" code is unknown, and we're left to guess it. The event and hint parameters are not documented anywhere, so we have to reverse engineer the SDK to figure out how it works (if we're supposed to use this method, please document its parameters).
There's another example in the docs which just won't work because it references entries that the hint dictionary doesn't have:
hint dict:
{'log_record': <LogRecord: py.warnings, 30, /usr/local/lib/python3.8/warnings.py, 109, "%s">}

Also, this doesn't have the exc_info set (the library that's raising the warning is simply not including it):
>>> hint['log_record'].exc_info == None
True

Meanwhile, the event dictionary is about 32k of data which I can't make heads of tails out of. It seems to include all the runtime information about my app.
Can we have a working example of how to ignore a single type of event based on the exception/warning class?

@WhyNotHugo This issue is about ignoring exception classes while you seem to want to ignore a warning class. To my knowledge the Raven SDK did not provide any simple configuration option to ignore warnings by class. It doesn't really help that Django has logger names such as DisallowedHost that look like exception classpaths, but this is nothing new and has little to do with Sentry.
I am really curious as to what's going on here, as it seems that you have configured the SDK to send each warning log as event to Sentry, possibly using the API documented as part of the logging integration. That seems generally excessive and is certainly not the default of the SDK.
I would encourage you to open a new issue about this as the idea of ignoring a warning class is very different from what we're discussing here and there seems to be more going on here than what fits into either feature request.

Also feel free to hop onto the Discord linked in the README as you've opened a couple of issues in the SDK that indicate you're having a especially bad time migrating. I would be curious as to how your Raven configuration looked and what kind of errors you were used to get.

Aren't warning/errors handled pretty much the same?
Or are they having different behaviours for me due to how I have sentry set up?
I am indeed logging warnings, since I generally want to be aware of any that might occur on production.
init_sentry(
    attach_stacktrace=True,
    before_send=before_send,
    integrations=[
        CeleryIntegration(),
        DjangoIntegration(),
        LoggingIntegration(event_level=logging.WARNING),
    ],
    release=version,
    in_app_exclude=["logging"],
)

The two questions "error vs warning" and "exc_info vs not" are completely orthogonal:
# Sentry error event without stacktrace or exception
# "exc_info" not in hint
# hint["log_record"].exc_info is None
logging.error("random error logged, but no exception")

try:
    1/0
except:
    # Sentry "warning" event with an exception and stacktrace attached
    # hint["log_record"].exc_info is not None
    # hint["log_record"].exc_info is hint["exc_info"]
    logging.warning("failed to divide by zero", exc_info=True)

This data model is part of the logging library and, for lack of a better word, not Sentry's fault. By default only the error is sent as event, and we make that decision purely based on the event_level.
Full acknowledgement that hints are poorly documented.

Oh, many of my warnings are actually warnings.warn("deprecated", DeprecationWarning..., so there is an actual exception class.
However, since they're third part libs (or even stdlib), I can't jump in and add exc_info=True.

Okay we don't regard that as exception though. I think this would be a good addition though, to be able to filter by warning class

I have def calculate. How to ignore this is errors ValidationError('Invalid value') . I mean where these exception getting thrown? you catch the exception there and process. Thanks
def calculate(x, y):
   try:
       return int(x / y )
   except ValueError:
       # What are the handling steps here to eliminate this error event from occurring ?
       raise ValidationError('Invalid value')

i have used def before_send and ignore_errors in sentry_sdk.init, but i dont want to have to define the generalizations when all the errors happen. I want  handle when catch the exception there and process.
def check_error_before_send(event, hint):
    # modify event here
    return event

sentry_sdk.init(
    before_send=check_error_before_send
    ignore_errors=[ .. ..... .... ]
)

@gotedkid195 please read the thread first. your question is answered in it.

you mean use
import sentry_sdk

def strip_sensitive_data(event, hint):
    # modify event here
    return event

sentry_sdk.init(
    before_send=strip_sensitive_data
)

to reslove my issue.


feat: Added latest_restorable_time to ignore_changes

Ignore latest_restorable_time property
Description

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply":

  # module.xxx.module.db.module.db_instance.aws_db_instance.this[0] has been changed
  ~ resource "aws_db_instance" "this" {
        id                                    = "xxx"
      ~ latest_restorable_time                = "2021-09-20T18:59:05Z" -> "2021-09-20T19:04:05Z"
        name                                  = "xx"
        tags                                  = {
            "Environment" = "staging"
            "Name"        = "xxxx"
            "Owner"       = "xxx"
        }
        # (57 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

Motivation and Context

I would rather not see the outside change of lastest_restorable_time on every apply.
Breaking Changes

None
How Has This Been Tested?

[ ] I have tested and validated these changes using one or more of the provided examples/* projects

Hi @FieryCod is there any chance you could fix this PR so it's in a mergeable state? I would really love to see it, this change on lastest_restorable_time is really annoying to me as well :)

@drmaciej done.

@FieryCod thanks much!
let's now hope the maintainers can review this soon 🤞

I agree. Objects have changed outside of Terraform type of errors are rather painful (20 open issues mentioning it).
Let's fix the CI and it will be ready to merge.

can we please merge this ?

This PR is included in version 3.5.0 :tada:

awesome, unfortunately it doesn't work though
i forked and tried the change, it doesn't change anything

i forked and tried the change, it doesn't change anything

could you elaborate? the lifecycle ignore is intended to ignore any future changes so if that is happening then it does work. if latest_restorable_time is still showing up in diffs, then its not working
just a few more words/details makes a world of a difference 😉

I have tested this and found that this PR doesn't have the desired effect.
I updated to 3.5.0 and ran terraform apply -refresh-only. After waiting 10 minutes, running terraform plan shows drift again from latest_restorable_time.
I don't think that ignore_changes works the way that we'd want it to for this case, see https://github.com/hashicorp/terraform/issues/28803#issuecomment-951209299 for more info on this.

This issue has been resolved in version 4.0.0 :tada:


polish wikidatasparqlexamples README

Confirm that they all still execute, that the ones that should return zero results actually return zero, that the ones that should be non-zero are still non-zero, etc.

I think it makes sense to move all of the example sparql queries onto a sub-page of our ProteinBoxBot Wikidata account. See example here.
Pros

Each sparql query is written in a template which automatically gives you syntax highlighting, pulls out the items and properties used in the query along with their labels, which makes the query easier to read (as you can see what the IDs mean)
Because the queries are put into this template, it makes them easily "extractable" from the page (if we want to check them with an external or internal tool)
There exist tools such as ListeriaBot which can automatically run the queries and add the results table to the page (live!). See the 2nd query for an example.
We can expand this into a full testing page by: 1) Expand the SPARQL2 template to accept a "validator" argument. 2) Write a Lua module that runs all of the sparql queries within these templates and passes the results to a validator, then updates the page
Anybody can edit it

Cons

Anybody can edit it

Pros far outweigh the con, IMO.  Not even sure that con is a con...

Moved all here. All execute and return what they claim to return


promote ASTR back XCMs

That PR new destination from Astar network for ASTR to:

Acala
Bifrost Polkadot
HydraDX
Moonbeam
Parallel

All back directions were added in previous PR, except:
Pralalel ASTR -> Astar
Also, it adds Statemint USDT> Astar

Tested by:

Astar -> Moonbeam
https://astar.subscan.io/xcm_message/polkadot-6dfb4dae1c58b70b01abfe43d2fd083e36ad60cf
Asset Hub -> Astar
https://astar.subscan.io/xcm_message/polkadot-dd09b637d86a8cb0e11d64b52e533da844a8b5fb
Astar -> Acala
https://astar.subscan.io/xcm_message/polkadot-25ffeda4f21afbb4b159a4f7b6c01bb4bbcd8d56
Astar -> Bifrost
https://astar.subscan.io/xcm_message/polkadot-918e779923af491b1bd29729871047e2984151f0
Astar -> HydraDX
https://astar.subscan.io/xcm_message/polkadot-dc1b8c9f5ec9b84930297b5388725bad191418bd


How could we allow the developer to style the board?

Well, we can have something like "laneClasses", but that seems pretty ugly, maybe having a @flow or typescript type, and give the users the capabilities to pass a Lane Component to the board, what do you think?

My workaround is to write vanilla css and import it.
If you inspect the element, you will find that these lanes and card have same classes.
For example I'm building a scheduler based on this library and need to style it nicely.
Here are some of the css that works for me:
Note class names might be different from machine to machine bcause the class names look like very random
.sc-VigVT {
    /*  timetable wrapper  */
    width: 100%;
}

.sc-VigVT,
.sc-VigVT * {
    box-sizing: border-box !important;
}

.sc-jTzLTM {
    /*  timetable  */
    width: 100%;
    display: grid;
    grid-template-columns: auto auto auto;
    grid-gap: 10px;
    padding: 10px;
}

.sc-htpNat:first-child {
    /*  staging area  */
    grid-column: 1/4;

}

.sc-htpNat {
    /*  card inside timetable  */
    margin: 0;
}

@lourenci Shouldn't this issue be closed?

This gonna be closed as soon as the branch beta gets merged.

My main concern was scrolling and height-limiting. I'm using this for a drag-n-drop playlist editor (inside a primarily Material-UI app, but with the renderX methods I'm able to keep my material consistency).
I know this beta will hopefully handle this, but if you can't wait for that, here's a temp alternative that's working for me.  Putting the Board inside a wrapping component with .board-space selector, you can use "> div" to control the selectors to the immediate children. In my case I have a controlled board, so the last column child is the cardlist container, not the add button; you'd need an nth-of-type otherwise.  This I placed in my index.css file from CRA.
.board-space > div {
  /* wrapper */
}

.board-space > div > div {
  /* draggable root */
}

.board-space > div > div > div {
  /* whole-column */
}

.board-space > div > div > div > div:first-child {
  /* column header wrapper */
  /* background-color: green; */
}

.board-space > div > div > div > div:last-of-type {
  /* card list - since not rendering the add button */
  /* background-color: yellow; */
  max-height: 600px;
  overflow: scroll;
}

Hi, @acroyear. Is it bad for you to change your repo to use the beta release? We need some feedback here.
As for the reliability concern, the beta is being released in the same workflow of the main release, so it has specs, code coverage and the same bug fixes of the main release.

I just didn't know if it was npm-published  yet (now i do).  I see how to install the beta via yarn/npm, so maybe tomorrow I'll pull that in and do it differently.  For now i want to keep moving forward with the mechanics of the project having finally gotten a kanban system that works well (react-trello has quite a few bugs, plus has redux stuck in it as well as mostly react15 code styles).

not sure if you want this as bugs or feedback here.  I'm still having to do div:first-child stuff right now for the header and the card list portions.
.react-kanban-column {
/* this came up with no styling at all - totally transparent.  i need to go back to the master demo to find the original styles to put in here or am i missing something in the docs to keep the column defaults from the master version? */
  width: 275px;
  background-color: #dddddd;
  padding: 5px 5px 5px 5px;
  margin: 5px 5px 5px 5px;
}

.react-kanban-column > div:first-child {
  /* column header wrapper */
  /* background-color: green; */
}

.react-kanban-column > div:last-of-type {
  /* card list - since not rendering the add button */
  /* background-color: yellow; */
  max-height: 600px;
  overflow: scroll;
}

i don't know if that's because i have my own renderers in the code, but even if i do, it would be nice if the wrapping layer from the library still provide a classname to identify it.

I just didn't know if it was npm-published yet (now i do).

Yep. We are working on the docs too. You can find it on the beta branch. Don't forget to read the installation section too, since we are getting rid of styled-components, the dependencies has changed a little bit.

not sure if you want this as bugs or feedback here.

I prefer to get your feedback from the beta release. Those classes have changed a little bit on that branch.
Thanks for that.

oops.  "import<EMAIL_ADDRESS>- makes a bit of a difference, that. :D


Various config options aren't supported

There are various config options which aren't currently supported by next-on-pages, including:

rewrites
and
redirects

We should ideally support all the configs present in the next.config list of properties but as a first step we need to at least document which we support and which we don't (so that both we can see which need work and also users of the package can check)

Assigning this to myself as I am documenting the missing options
I think that after documenting them this issue can be closed (since it will be properly documented anyways)


Change democratic-republic-of-the-congo slug in overseas-passports

Trello card: https://trello.com/c/i1GJOLKF
Motivation
A next-node not found error was raised in errbit for overseas-passports: https://errbit.publishing.service.gov.uk/apps/533c35ae0da1159384044f5f/problems/5807ef5765786313be491e00
overseas-passports matches the country that the user has selected to the country slugs passport_data.yml.  The list of countries and their slugs (first question) is populated from Whitehall admin. Recently the slug for Democratic Republic of the Congo changed from democratic-republic-of-congo to democratic-republic-of-the-congo, but we had not updated our own country list in passport_data.yml.
We need to change every occurrence of democratic-republic-of-congo in overseas-passports to democratic-republic-of-the-congo.
Factcheck
Not required - This is a live bug.
overseas-passports
Expected Changes
URL on GOV.UK
Before

After

👍
Thank for fixing my lint error.
LGTM


Making behaviour of child validators within a ruleset more predictable

Hello,
I'm new to FV and loving it thus far, except one thing (sorry!). My team hit the issue described in the first comment of each of #177, #194, #278.
Essentially it doesn't appear obvious that in order for a child validator to be executed, it needs to have the same ruleset name defined as its parent.
One option around this is described in #194 with a custom IValidatorSelector, necessary to avoid breaking existing behaviour.
Could another option be to add an overload to SetValidator() where the ruleset name is specified?
Or possibly add an option to Validate() for child validators to try the default ruleset first?
Thanks for reading :smile:

Hi,
Thanks for the suggestions. The way to do this is with the custom validator selector (as you already saw) but you can also set this as a global, default behaviour by using the ValidatorOptioms.ValidatorSelectors property. Here you can set which selectors are used by default, and processing rule sets is one of those options.
No plans to add any other ways to do this at the moment.
Hope that helps

It does help a great deal. Is this what you mean?
var validationContext = new ValidationContext<Vehicle>(vehicle, new PropertyChain(),
    ValidatorOptions.ValidatorSelectors.RulesetValidatorSelectorFactory(new[]
    {
        nameof(ValidateVehicleUse), "default"
    }));
var result = this.Validate(validationContext);

You don't need to do that- just call Validate(obj, rueSet: "foo") as normal. The selector will automatically be picked up.

...provided the selector has been set once in your app startup routine.

Great, I now call Validate() as before and ended up with this to change the ruleset selector:
ValidatorOptions.ValidatorSelectors.RulesetValidatorSelectorFactory = rulesets =>
{
    var rulesetIncludingDefaultFallbackForChildProperties =
        rulesets.Union(new[] {"default"}).ToArray();
    var rulesetValidatorSelector = new RulesetValidatorSelector(rulesetIncludingDefaultFallbackForChildProperties);
    return rulesetValidatorSelector;
};

There is no app startup routine as such - the validation lives in a domain model project which has no dependencies on anything (except FluentValidation). Also, there are no dependencies on FluentValidation in any other projects as helper methods extract the validation error details that we need and return them in a collection.
Hence, I've put this in a static constructor for the validator we're currently working on. I don't think this will cause threading issues if we have additional validators that need to perform the same operation. Do you know if there should be a lock around it?

You should really be putting it in your app startup (either Application_Start for a web app on Main for a Windows app), that way it's guaranteed to only be called once. It also means it's in place before any validators are instantiated. By using a static constructor it's possible that a different validator will be instantiated first, and then you'll get inconsistent results at different times. You will of course need to reference FV from your startup project but there's really nothing wrong with this....trying to hide it away just adds unnecessary complexity.

Yes I understand what you're saying. If only it was that simple... there are competing priorities.
Thanks for your time, advice, and this project - greatly appreciated!


speedup request using threads pool

Why use thread pools when __async__and await are now part of the language?  https://aiohttp.readthedocs.io/en/stable/client_quickstart.html

Because I just want to speed up it without change the http part code.

Just so you know, if you add *.txt to gitignore, then that means that requirements.txt will be ignored as well.

Does #3 superseded this pull request?  That was recently merged into the main line.

Why use thread pools when async and await are now part of the language? https://aiohttp.readthedocs.io/en/stable/client_quickstart.html or
https://pypi.org/project/aiohttp-requests

Hi @cclauss , author of PR #3 here. As stated in that PR, it seems like Visual Studio Build Tools 14 is required on Windows for most async libraries in python. This greatly reduces the ease-of-use of installing this program.
I prototyped with aiohttp-requests, but that has the same dependency. Let me know if you're able to get async working on windows without Build Tools, it has stumped me!
Furthermore, users of this program have the ability to specify TOR-based requests. I'm not sure how that would pan out with aiohttp because it defines it's own request session. The current library torrequest works via a request session as well.

I bit the bullet and prototyped single-threaded, asynchronous requests! Code is viewable in this branch of my fork.
Note this is a prototype and breaks a lot of extra functionality! Definitely not PR ready anytime soon
Additionally, I believe this required Visual Studio Build Tools 14 (due to dependency aiohttp). Can someone confirm this? I don't know how to check whether a python library requires Build Tools, I just noticed aiohttp was pre-compiled on this list.
Benchmarks
Here is a comparison between multi-threaded and single-threaded async requests. To be honest, I don't understand why single-threaded requests was slower than the multi-threaded environment. I expected there to be less overhead... Any thoughts @cclauss?
For reference, this is my laptop:

Intel® Core™ i7-8550U (1.8 GHz base frequency, up to 4 GHz with Intel® Turbo Boost Technology, 8 MB cache, 4 cores)

Single-threaded Asynchronous Requests (prototype): 5.071 seconds
Multi-threaded Requests (PR #3): 3.50564 seconds
Synchronous Blocking Requests (Before PR #3): 40.5665 seconds

Close is welcomed because of PR #3


Fix scan swallow NotFoundError

bumped to 0.3.1
fixes scan.scroll_id returns self._scroll_id, fixed related tests
removed silent swallow NotFoundError during scrolling, comes when search context do not exists anymore or scroll was explicitly cleared, added corresponding test
removed surrogatepass, it was back-ported from upstream, which has reverted it in master
refactor docker es runner to bind on random ports, added ability to run it on MacOS ;)
test_elastic_default_loop must do not run inside coroutine, otherwise it will find loop anyway

will find linux somewhere and fix docker later

docker.api.inspect_container(container.id)['NetworkSettings']['IPAddress']

is so tricky, if ports map not to None, it will return docker internal network like docker0
what about just set host to <IP_ADDRESS> ???

Codecov Report

Merging #43 into master will decrease coverage by 1.38%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   98.85%   97.47%   -1.39%
==========================================
  Files           7        7
  Lines         436      435       -1
  Branches       76       76
==========================================
- Hits          431      424       -7
- Misses          2        7       +5
- Partials        3        4       +1

Impacted Files
Coverage Δ

aioelasticsearch/helpers.py
98.82% <100%> (-0.02%)
:arrow_down:

aioelasticsearch/__init__.py
90.47% <100%> (-9.53%)
:arrow_down:

aioelasticsearch/transport.py
97.29% <100%> (-0.55%)
:arrow_down:

aioelasticsearch/connection.py
94.91% <0%> (-5.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb9763...ca2d043. Read the comment docs.

I used binding to random local ports and found the solution is not reliable.
Docker container takes time to start, port could be acquired by other process.
As result tests was fail very often.
Running on container on separate IP completely solves the problem.
If it doesn't work on Mac well we could try different docker network settings, e.g. bridge setup.

Regarding docker for mac
https://docs.docker.com/docker-for-mac/networking/

I cannot ping my containers

Unfortunately, due to limitations in macOS, we’re unable to route traffic to containers, and from containers back to the host.`

There is no docker0 bridge on macOS

Because of the way networking is implemented in Docker for Mac, you cannot see a docker0 interface in macOS. This interface is actually within HyperKit.

Per-container IP addressing is not possible

The docker (Linux) bridge network is not reachable from the macOS host.
As I understand there is no way to bridge configuration...
Formatting comments were fixed

Another problem that it is impossible to combine pytest fixture + scopes due https://github.com/pytest-dev/pytest/issues/519 , right now tests make each time new elasticsearch container

Formatting comments were fixed

Previously tests for test_scan_equal_chunks_for_loop were silently making new container, which was extremely slow and actually hidden.
As well if tests were failing hard, container hasn't been removed
So, container will be removed only on atexit, as well it prevent "hard" to create containers with same session_id
added option --local-docker to run on new port , as well default just new host


File and CloudinitConfig resources are deprecated

The File and CloudinitConfig Resources are deprecated. They are legacy shims from before terraform supported the concept of Data Sources.
I'd PR to just remove them but then tfbridge emits warnings that Resources are missing. Is there a way to tell tfbridge to explicitly ignore resources?
https://github.com/pulumi/pulumi-terraform-template/blob/adc4bf573a2363ffd9d65275b6904b701d7a11bc/resources.go#L75

I'd PR to just remove them but then tfbridge emits warnings that Resources are missing. Is there a way to tell tfbridge to explicitly ignore resources?

I don't believe that there is, no. I've filed https://github.com/pulumi/pulumi-terraform/issues/233 to track that feature.


Please specify the cv2 version

face_recognition version:--
Python version:3.5
Operating System:Windows

Description
I have installed successfully all the prerequisites for my windows 64-bit, with python 3.5 64-bit version. Now when i import the face_recognition module, its throwing an error no module named cv2.
What I Did
``I think your opencv version is different to mine. So please help me in this regard.

face_recognition doesn't depend on cv2. I'm assuming you ran one of the webcam examples that uses cv2. I used OpenCV 3.2 with the Python extensions installed.


Ensure width of table is not wider than console #6

Addressing #6
Adding a possibility to align table on the output canvas

Hi Tom,
Sorry for a delay, I have been pretty busy. But I managed to travel more than I originally planned and I can only say that Finland and Estonia are lovely in the winter, but Ukraine is nicer in the summer. But back to business.
I tried to address everything from your review and even when I am not 100% sure whether not having default CanvasWidth set to console width is a good idea or not, I've removed it. In the program.cs everyone can see how to correctly set it up to work in console, so hopefully that's enough. I also addressed what was originally a corner case and now is a default value - having CanvasWidth = 0. All confirmed with new tests.
One more thing, I found another test that did not work in Danish locale settings (decimal comma) - so I fixed the test in the same matter as I fixed the ones before. 😉
Looking forward for new challenges raised by review comments! 😅
Marek

Oh, one more thing. I am not sure about the workflow here. If I have to address review comments one by one with code snippets, let me know and I'll do it.

Hi @zumo-sk,
Thanks for these changes. Sounds like you've given it plenty of thought. I'll review them properly ASAP. I'm at a conference this week, but might get a chance at the airport? We'll see! In the grand scheme of things, this is great timing, as I was planning on tackling #46 myself soon and can see how it might layer on top of your work.
Sounds like you've been busy travelling. Work? Or holidays? Do you enjoy snow sports at all? Skiing is one of the things I really miss about Europe.
Tom

We'll see. In worst case you'll request some more changes and I'll try to implement them faster this time. 😄
Finland and Estonia were holidays, Ukraine was work (and I expect some more work related traveling soon). None of them included sports, but I would understand why would anyone go skiing there - there was plenty of snow and it was not crowded by tourists. I was never a ski person, but my wife was, and she's missing skiing and snowboarding since we moved to Denmark few years ago (you know, in a country with highest peak called Sky Mountain being 147m high, it's not very ski friendly). This time, the travels were mostly to enjoy local food (reindeer stew, anyone?), visit local board game cafes and to learn something about the countries we didn't really know that much of. And I have to say, mission was successful.
When did you actually moved to Australia? And was it because you missed poisonous animals, crazy temperatures,, or did you have other motivation? 😃

Well @zumo-sk - these changes are really nice. I'm going to merge them now. I still plan on rolling these changes into v2, which may be some time away, but I'll put out another preview release in the meantime. I spend a long time this evening playing with all the different options and I have to say I really like this functionality. Great job!
We moved to Australia last (northern-hemisphere) summer. I blogged about it here, but to answer your question: no, it was certainly not for the poisonous animals. In fact, the main motivation was for my wife's work. Your holiday sounds lovely - I hope you had a relaxing time!

Preview is up on NuGet: https://www.nuget.org/packages/ConTabs.tdwright/2.0.0-preview2
Thanks again @zumo-sk!


Ripple effect

What would you like to be added:
Buttons with Ripple effect
Why is this needed:
Strong identity for Material Design
For which Platform:

[x] UWP
[x] iOS
[x] Android
[x] WebAssembly

Anything else we need to know?
Could look at how MaterialDesignInXaml did in WPF for inspiration
https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/blob/master/MaterialDesignThemes.Wpf/Ripple.cs

In Button Overview, on "TEXT" button there is no border, however the ripple effect does get cut off and shows a border

On WASM, when clicking a button, the ripple effect is only displayed for the first click (for each button), and not the following clicks.

In Button Overview (Android), on "TEXT" button there is no border, however the ripple effect does get cut off and shows a border

This occurs on every platform since this is a button... Do you want a bigger ripple to see the side borders as well.

@MatFillion What is the expected behavior as the button does not have a visible border?

As close as possible to what's specified on material.io 😃 @StewartPolsky

Looking at https://material.io/design/interaction/states.html#pressed it seems both having a ripple that goes outside it's container and a ripple that stays within the bounds (even if no border) is OK. I think the current implementation show in your gif is correct..
For the wasm bug, we should have a github issue to track it. (if not already)

@MatFillion Can we close this, since it is implemented.
@StewartPolsky If any of the bugs here are still valid, we can open a separate issue for them.


Adding geneve support in p4_ovs

Added tunnel_type field to identify tunnel type.

@satish153 please sign off your commit for DCO check to pass


Unable install package with svelte 5.0

I thinks Svelte 5.0 has many change in syntax code ...
npm install three @threlte/core
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/svelte
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer svelte@">=4" from<EMAIL_ADDRESS>npm ERR! node_modules/@threlte/core
npm ERR!   @threlte/core@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/maitrongtue/.npm/_logs/2023-12-19T12_34_49_531Z-eresolve-report.txt

Hi @tuemaytinh1981, Svelte 5 support will necessitate a major rewrite. The Svelte 5 API is not yet stable, so our efforts are limited currently. Stay tuned for updates!
I will close this issue, we'll open a separate issue once Svelte 5 is stable and our efforts get serious. 🙂


data retention across reload: move replay of saved ops from runtime to container

Move replay of saved ops from runtime to Container.
Fix AB#1387
Fix AB#1901
Description
Previously, runtime would save enough information to apply stashed ops at their reference sequence number, and Container would just save its state at the time of closeAndGetPendingLocalState(). However, this meant container-level ops were not replayed, and quorum state was not the same when ops were replayed. To solve this issue, replay of saved ops has been moved to Container.
SerializedSnapshotStorage has been rolled into ContainerStorageAdapter since they do essentially the same thing.
Draft PR since changes to IRuntime in container-definitions will be necessary.

can you provide a quick refresher on how pending ops works. specifically, does it store all ops from base summary to the local tip, both remote and local?

can you provide a quick refresher on how pending ops works. specifically, does it store all ops from base summary to the local tip, both remote and local?

Yes, so stashed ops can be applied at their reference sequence number

can you provide a quick refresher on how pending ops works. specifically, does it store all ops from base summary to the local tip, both remote and local?

Yes, so stashed ops can be applied at their reference sequence number

do we do an pruning of this data? like on acknowledging of local ops? or summary op?

do we do any pruning of this data? like on acknowledging of local ops? or summary op?

No, that's in phase 4 in the design doc


not working when updated Sketch Version 69.1 (107496) !!!

Fixed it in follow plugin.
Also add some features by myself.
C-Measure.sketchplugin.zip

super thanks!!

super thanks!!

enjoy the work~

Hi, again! Plug in is working perfectly!
Only one thing is distracting the stakeholders when they see the html exported and is the blue light/shadow the pages have. They are afraid the devs might implement it as part of the web. Is there a way of turning it off?
Thanks again!


Updated Dockerfile - Create image from current directory irrespective of branch/changes

Improvements :

Only once we will be cloning the repository
Copying the once cloned repository files inside the container rather than cloning again
Creating a docker image from current directory irrespective of branch or changes made

Coverage remained the same at 95.701% when pulling b809ca721a13efc6b59e11587c582f6ba4b11587 on coolboi567:master into c74b3d03c8f11df3b75cf43cb67709e02cf7064d on thisismyrobot:master.

@thisismyrobot Cool !!


Is it safe to mark rxjs_v5.0.x.js as @flow strict?

Pardon my lack of knowledge, what do you mean by "@flow strict"?

Thanks for the quick response @gantoine! See https://github.com/facebook/flow/issues/5776#event-1460714659

Yeah I don't really think I can give you a good answer. @AndrewSouthpaw thoughts?

¯_(ツ)_/¯
I'd leave it out until it gets properly documented, unless there's a compelling need to make it strict right now.

@andrewsouthpaw What does “properly documented” mean - like comments and stuff, or a comb through to verify typings?

What I mean is I've not seen any documentation about the meaning of @flow strict in the Flow docs, so it'll be hard for others to know what's going on.
Is there a use case for adding @flow strict to this libdef?


Numeric.LinearAlgebra.Static

Excellent comparison, @pechersky! I might try to add in the staticly typed hmatrix bindings later, but I'm pretty backlogged so I wanted to bring it to your attention in case I don't get around to it in a timely manner. It's an experimental module with horrendous documentation (in hmatrix >= <IP_ADDRESS>), but it lets you do type-safe linear algebra -- which I think is a huge selling point to the haskell ecosystem.

Thanks for the feedback!
Absolutely, the statically typed versions would be great examples,
especially for the more-in-depth documentation of the numpy functions.
Adding those examples is a matter of prioritization -- fill out the rest of
the docs, or further elaborate existing examples with hTensor, static
HMatrix, repa, accelerate, etc.
On Wed, Mar 22, 2017 at 11:00 AM, Sam Stites<EMAIL_ADDRESS>wrote:

Excellent comparison, @pechersky https://github.com/pechersky! I might
try to add in the staticly typed hmatrix bindings later, but I'm pretty
backlogged so I wanted to bring it to your attention in case I don't get
around to it in a timely manner. It's an experimental module with
horrendous documentation (in hmatrix >= <IP_ADDRESS>), but it lets you do
type-safe linear algebra -- which I think is a huge selling point to the
haskell ecosystem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pechersky/haskell-numpy-docs/issues/1, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AFGDhhPE0nI24wUP9eq8mQ991pi4S5xZks5roTeSgaJpZM4MlVat
.

Just a heads-up, I copied over hmatrix.hs to a hmatrix/static.hs and am at example 100 out of the original 233.


Update rust to 1.68.1 and tarpaulin to 0.25.1

What this PR does / why we need it:

Updates rust toolchain to 1.68.1
Updates Tarpaulin to 0.25.1

Special notes for your reviewer:

New rust version suggests to replace .into_iter().filter().collect() with .retain()
Comments cannot have <> or else it fails cargo doc

If applicable:

[ ] this PR has an associated PR with documentation in akri-docs
[ ] this PR contains unit tests
[ ] added code adheres to standard Rust formatting (cargo fmt)
[x] code builds properly (cargo build)
[ ] code is free of common mistakes (cargo clippy)
[x] all Akri tests succeed (cargo test)
[ ] inline documentation builds (cargo doc)
[ ] all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Just need to fix the inline docs issue of using <Action> (that is causing the failing Rust Check action) and then LGTM. Also, would be great to follow this up with a PR to akri docs like this one project-akri/akri-docs#41

Thanks! Created a PR to update doc https://github.com/project-akri/akri-docs/pull/65


Added Hello World in German

My account number: 36846b3d4bfdfbeee3b66f6a5b8cc671b3b92e7c4dc5203b0ab941a953945cc1

ISO Incorrect ❌ (GE is for Georgia) Source: https://www.iban.com/country-codes
Spellings Correct ✅
Changes Required

Changed ISO for German

ISO Correct ✅
Spellings Correct ✅
Approved


JComboBoxes' raw type

This PR ONLY adds Generics, and ONLY to JComboBoxes (was hard to restrain myself from even just adding generics to other nearby types).
<?> for when we can't tell (it's a parameter, and we're just passing it on)
<String> for when it's only fed strings (most of them)
<Object> for when it's a mix of strings and something else (sadly...)

Nope.
Even if we could, these are only in methods for which it doesn't matter, meaning it would only be detrimental for the future (if someone else wanted to use that method, they'd have to match the generic we narrowed it down to, even though they shouldn't have to)

So there is no requirement whatsoever from the generic. Hmm.. I wonder if that would be clearer then if we made it <? extends Object> explicitly or something. That way someone looking at it would not assume it was just lazy, as <?> might otherwise look. Just musing on it.

This looks good to me, although I'll let @gausie make the decision on merging it, since I totally missed that he had started the review process earlier.

Well, to be fair, the only two instance of <?> that are left are of this exact scenario:

  protected boolean isValidEvent(final ActionEvent e) {
    if (e == null || e.getSource() == null) {
      return true;
    }

    if (e.getSource() instanceof JComboBox) {
      return ((JComboBox<?>) e.getSource()).isPopupVisible();
    }

    return true;
  }```

Since we're casting from a non-generic type, trying to turn them into
```java

  protected boolean isValidEvent(final ActionEvent e) {
    if (e == null || e.getSource() == null) {
      return true;
    }

    if (e.getSource() instanceof JComboBox) {
      return ((JComboBox<? extends Object>) e.getSource()).isPopupVisible();
    }

    return true;
  }```
would have the compiler complain about an unchecked cast...


Add PyPortal Titano plus fallback Fs reinit and repeated serial if Halted

Tested on FunHouse (secrets file persisted between reboots)
@tyeth  could you bump the library version and then merge+release?


TP2000-919: Add ability to end date and delete definition periods

TP2000-919: Add ability to end date and delete definition periods

Why

Users need to be able to end date and delete future quota definition periods

What

Adds the required edit and delete forms
Shows edit links next to definition periods
Only shows the delete link for definition periods that are in the future and not yet active

Codecov Report
Patch coverage: 91.75% and project coverage change: +0.02 :tada:

Comparison is base (1b85069) 92.54% compared to head (e05e9da) 92.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
+ Coverage   92.54%   92.56%   +0.02%
==========================================
  Files         432      433       +1
  Lines       30338    30544     +206
  Branches     2309     2317       +8
==========================================
+ Hits        28075    28273     +198
- Misses       1805     1811       +6
- Partials      458      460       +2

Impacted Files
Coverage Δ

quotas/urls.py
100.00% <ø> (ø)

quotas/models.py
87.50% <63.63%> (-3.30%)
:arrow_down:

common/querysets.py
100.00% <100.00%> (ø)

quotas/forms.py
96.06% <100.00%> (+0.41%)
:arrow_up:

quotas/tests/test_views.py
100.00% <100.00%> (ø)

quotas/views.py
98.65% <100.00%> (+0.22%)
:arrow_up:

... and 19 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Trying out M1 runner

M1 runners are available, let's see if it runs and passes.

Turns out they're not free... billed at 0.16$/minute. Closing.


Otel trace: compaction run (7m 21s)

Description
I caught a compaction run taking 7m 21s.
Version
moonray: v1.30.3 rev 729, chaos deployed
go: go1.22.5
sqlite: 3.40.0 (compiled), 3.40.0 (linked)
dqlite: 1.14.0 (compiled), 1.14.0 (linked)
libuv: 1.48.0 (compiled), 1.48.0 (linked)

Recorded Trace

Possibly related:
These traces have been recorded around the time of this rogue compaction:
Invalid compaction range & non-5min compaction interval: https://github.com/canonical/k8s-dqlite/issues/146
logstructured.delete 10.77s https://github.com/canonical/k8s-dqlite/issues/147
Note: We are not seeing any traces from current revision/ get compact revision instead the first span is delete_revision.

Addressed by https://github.com/canonical/k8s-dqlite/pull/149


DateTime inconsistency between js and dart

the following snippet makes 2 dates equal on the web but not when run in a terminal, I assume the js has no micro second information.
void main() {
  final now = DateTime.now();
  final now2 = DateTime.fromMillisecondsSinceEpoch(now.millisecondsSinceEpoch);
  print(now == now2);
  print(now.isAtSameMomentAs(now2));
  print(now);
  print(now2);
}

Correct. When compiled to JavaScript, Dart uses the JavaScript Date type to represent DateTime, and that does not have microseconds.
If you want to create a new object with the same time (which you shouldn't need, you can just can use the same object, since it's immutable), use DateTime.fromMicrosecondsSinceEpoch(now.microsecondsSinceEpoch).
Since the API has microseconds, your code should be prepared for them, even if they are sometimes always zero.
The code can also print true on native, but only with a 1:1000 chance (when the microseconds are a multiple of 1000), so being equal is not wrong. It's just (much!) more likely to happen on the web.

For future readers, It can make serialization tests fail
This works in dartpad but not in terminal:
import 'dart:convert';

void main() {
  final house = House(DateTime.now());
  final serialized = house.toJson();
  final deserialized = House.fromJson(serialized);
  print(house.creationDate == deserialized.creationDate);
}

class House {
  final DateTime creationDate;

  House(this.creationDate);

  Map<String, dynamic> toMap() {
    return {
      'creationDate': creationDate.millisecondsSinceEpoch,
    };
  }

  factory House.fromMap(Map<String, dynamic> map) {
    return House(
      DateTime.fromMillisecondsSinceEpoch(map['creationDate']),
    );
  }

  String toJson() => json.encode(toMap());

  factory House.fromJson(String source) => House.fromMap(json.decode(source));
}

Agree. Always use microsecondsSinceEpoch to represent the precise value as an integer, not the potentially truncated milliseconds.


The package classes are not visible

I added the package to my project, inserted "import web3swift", but none of the package classes was visible in my code:
Cannot find type 'CodableTransaction' in scope
Cannot find 'web3' in scope
and so on.
Did I forget something in settings?
I got it in Xcode 13.2, deployment target 13.0, MacOS 11.6.3

did you use cocoapods or the package manager

Try import Core in addition. Also web3 now replaced with Web3 watch the capital W.

Also I'm not sure that 11.* is supporting required swift toolchain.

I added the source files to the project directly, and it worked out!

This is even more curious, because even inside the lib code itself we've required to do import Core for now, since it's separate target. So even by adding sources into your project manually wouldn't let you to skip this import, unless you're writing your code in Core/ directory, but this is too much.
So yet I'm assuming that this solution that you did take are rather both redundant and inappropriate.
The main reason for such for now is that it's made updating it to new version are impossible, while lib yet are in active development, just for now there's two very important PR with bug fixes are pending, so you'll have to update this lib quite soon when you'll face with those bugs whether want it you or not, but you'll be unable to do it without refactoring your project from the ground up.

Thank you for the detailed explanation!
I quite understand all the pitfalls of my approach and will try to resolve them.


TextBlock text in AppBarButton.Flyout cannot be selected

Describe the bug
TextBlock text in AppBarButton.Flyout cannot be selected

Steps to reproduce the bug
<AppBarButton Content="Click me">
    <AppBarButton.Flyout>
        <Flyout>
            <TextBlock Text="The text cannot be selected" IsTextSelectionEnabled="True" />
        </Flyout>
    </AppBarButton.Flyout>
</AppBarButton>

Expected behavior
With IsTextSelectionEnabled="True", the text in textblock should be able to be selected.
Version Info
WinUI: 2.4
NuGet package version: Microsoft.UI.Xaml 2.4.3

Windows app type:

UWP
Win32

Yes
Not tested

Windows 10 version
Saw the problem?

Insider Build (20197)
Yes

May 2020 Update (19041)
Not tested

November 2019 Update (18363)
Not tested

May 2019 Update (18362)
Not tested

October 2018 Update (17763)
Not tested

April 2018 Update (17134)
Not tested

Fall Creators Update (16299)
Not tested

Creators Update (15063)
Not tested

Device form factor
Saw the problem?

Desktop
Yes

Xbox
Not tested

Surface Hub
Not tested

IoT
Not tested

Additional context

@hez2010 can you try setting the AppBarButton's AllowFocusOnInteraction property to True?

@YuliKl I've verified and it works. Thanks!

Sounds like the issue is resolved. Closing.


Feature: Option to disable only Access Logs.

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
I think a boolean option too disable access logging would be amazing, or maybe access logging should use a different logger with its own logger object.
Feature code example
import logging
from faststream import FastStream, Logger
from faststream.nats import NatsBroker

my_logger = logging.getLogger("my_logger")

broker = NatsBroker("nats://localhost:4222/", logger=my_logger, disable_access_logs=True)
# or
# broker = NatsBroker("nats://localhost:4222/", logger=my_logger, access_logger=None)

app = FastStream(broker)

@broker.subscriber("in")
@broker.publisher("out")
async def handle_msg(user: str, user_id: int, logger: Logger) -> str:
    logger.info("testing")
    return f"User: {user_id} - {user} registered"

Additional context
I think this would help anyone that have limits with their logging storage or does not want to have too much unnecessary logs

@ericsouza I have no reason to add this feature. For now, you already have an ability to filter access log messages from your log storage in a 2 ways:

downgrade access log message level with Broker(log_level=logging.DEBUG). As an example, structlog doesn't create log message for disabled levels at all. Also, if you using syslog to transfer logs to your storage, not printed logs doesn't transfered to the storage too
You can disable broker logger, but set it to context manually:

from faststream import ContextRepo, FastStream, Logger
from faststream.log import access_logger
from faststream.rabbit import RabbitBroker

broker = RabbitBroker(logger=None)
app = FastStream(broker)

@broker.subscriber("test")
async def handler(msg, logger: Logger):
    logger.info(msg)

@app.on_startup
def set_logger(context: ContextRepo):
    context.set_global("logger", access_logger)

@app.after_startup
async def t():
    await broker.publish("test", "test")

But, this way you are losing default FastStream log formating (but you can also setup it manually by getting access to context.get_local("log_context")

@Lancetnik Oh, this will do the job. Thanks!!
By the way, faststream is an amazing project. Thanks for all the work done by the team!!


Is artillery-plugin-aws-sigv4 being maintained any longer?

Although there a bot updates and recommended code changes for bugs, there hasn't been any activity to pull in these changes and release a new version since 0.0.5 (Sept 17th, 2020).  If this plugin is no longer maintained, is there an alternative to this plugin? It's a really useful plugin so I'm hoping we can get a few more contributors added to keep it going.

Hi @RJKeane2000 , did you find any alternative ?

Hi @gabor386. I have not. I have a really hacky way of getting it to work though. I downloaded Richard Seig's fix and added the file to my test directory. Then before I execute the test, I overlay the aws-sigv4.js file that comes with the latest version of artillery-plugin-aws-sigv4 with the fixed version. So my package.json scripts command looks like this:
{
   "scripts": {
      "performance-test": "cp ./aws-sigv4.js ./node_modules/artillery-plugin-aws-sigv4/lib & npx artillery run performance-test.yml -o performance-results.json"
    }
}

I'm just kicking the can down the road though. I love how easy it is to set up a performance test with Artillery but long term I have to move away from this plugin. I've been watching the main artillery.io project to see if new features would make this plugin obsolete.

@RJKeane2000 Thank you for your response.  Did you face with this error message before ? https://github.com/Nordstrom/artillery-plugin-aws-sigv4/issues/41

I'm not seeing that error. I'm running on Node 18 alpine, with the 2.0.0-27 of artillery. Something that may help you figure out what's happening is this:
export DEBUG=http,http:capture,http:response

Good luck!

Hi, I have the same problem as @gabor386  here. If you have any news about how to solve this it would be very useful.

Hello,
Is the plugin in usable state?
I get this error-
WARNING: Could not load plugin: aws-sigv4 warn
WARNING: Plugin aws-sigv4 specified but module artillery-plugin-aws-sigv4 could not be found (MODULE_NOT_FOUND) warn
installing the npm package globally did not help..


Fix Max Height on calculateHeight

Fixes https://github.com/casesandberg/react-bounds/issues/9

Thank you, that was a good catch. Going to be putting in tests to make sure it doesnt happen in the future, but the fix is live now with<EMAIL_ADDRESS>


Unable to Find Function App with Multi-Subscription SPN

It seems when the service principal has multiple subscriptions available, the function app is not found if it is not in the default subscription.
The action should search all subscriptions, support specifying a subscription ID, or have the documentation state the limitation and workaround with az acount set --subscription.

@nerddtvg Did you create service principle using the recommended steps in README?

@patelchandni These are existing service principals that have defined subscriptionId values in the JSON already as required by other tasks that also only search the default subscription. I can't change that value. Hence why I think it would be ideal if this task (and those others) allowed us to specify a subscription ID or search across all available subscriptions if that is provided. The simplest way is specifying the subscription as an optional parameter, otherwise searching across all subscriptions could end up with duplicates or ARM API request quota issues.
Or it could be mentioned in the documentation that using az account set --subscription as a command prior to running this task, you can specify something different. Just for completeness sake.


Add support for entitlements

I suppose not all apps have an entitlement file (I think it comes with things like push notifications). Will it fall through fine is this URL doesn't exist?

Also related: https://github.com/junedomingo/react-native-rename/issues/12

Yes!. Thanks


Add profile

@vedantpople4 Why you change the name of the file from label.yml to labeler.yml ?

@vedantpople4 Why you change the name of the file from label.yml to labeler.yml ?

I was getting error I the actions check. Found this relative solution :
https://github.com/actions/labeler/issues/16

Thanks, so does it always give error ?

@vedantpople4 Please wait while @Susmita-Dey give you her review

Thanks, so does it always give error ?

Yes, See the closed pull requests

Hey @vedantpople4
If you want to a readme file for your github profile or you have one please add your own changes here: https://github.com/Programming-School-Pro-Coding/Programming-School-Pro-Coding and then create a pull request for the changes


vagrant: log stderr when vagrant shell command fails

Continuation of #536 (inlined description below) but PR'd to master instead of paper and moved log lines to callsite as proposed.

With logs, we can (try to) figure out why the Vagrant provider is "unavailable", "unable to boot", etc. without adding one-off debugging code and/or running commands outside of Quilt.

cc @kklin @ejj

@kklin Fixed.

Overall series looks good.  Three super tiny nits.  Fix them and I'll merge.

@ejj fixed nits


Add the Pokemon Theme Song

Make the pokemon theme song play in an invisible template in the background when the user clicks through all the lyrics in the registration.
Priorities people. :+1:

Implemented in 3c94a39a45d2632de31cb49e159fd0a16b6702e9


#61 - add flush to IOperation

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.53%. Comparing base (e49b8d9) to head (9352ce9).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   93.53%   93.53%
=======================================
  Files          58       58
  Lines        1052     1052
  Branches      109      109
=======================================
  Hits          984      984
  Misses         38       38
  Partials       30       30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Investigate usage of pebble notices for admin UI syncing

Enhancement Proposal
When the admin UI makes some change in the configMaps used to create the kratos config, we need to wait for the kratos charm to re-render the config file. This will happen when an event is fired (update-status), the problem is that we can't be sure when that is going to be fired. We need to find a way to make the changes applied faster.
Ideally we should look into using pebble notices. Since we can't trigger a pebble notice from the admin UI app on the kratos charm (need to verify this), we will need to trigger a pebble notice from the admin UI app that will cause the admin UI charm to change something in a relation with the kratos charm which will cause the charm to re-render the config file.
Another approach would be to create a go script (or python), that we would inject in the kratos container. This script would watch for changes in the providers or identity_schemas configmap and it would trigger a pebble notice to notify the charm to re-render the config file. This will save us the trouble of having to use juju integrations, but it is hacky.
As a stopgap solution we can just implement an action in the kratos charm that would re-render the config file and apply it in the kratos container. The admin UI will have to simply show the user a pop-up saying that they should run this action to make kratos peek up the changes.

Might be useful

answer
viper.OnConfigChange


Docker images amount restriction

ENV_DEFAULT_REPOSITORIES_PER_PAGE=20
Open UI. We have more than 100 images in repo. Clicking "Show All" at the bottom of the page:
Expected behavior
Expected listing of all images.
Actual behavior
Only 100 are displayed.
Specifications
Docker:
Client:
Version:      1.8.2
API version:  1.20
Package Version: docker-1.8.2-7.el7.x86_64
Go version:   go1.4.2
Git commit:   bb472f0/1.8.2
Built:
OS/Arch:      linux/amd64
OS RHEL 7:
3.10.0-327.10.1.el7.x86_64
docker-registry-frontend:
Commit

Short answer as I'm in a hurry but I ll edit this afternoon when I have more time.
It is basically because of the implantation of the Docker Registry.
See the implementation (https://github.com/docker/distribution/blob/master/registry/handlers/catalog.go)
But maybe we should let the user know that the maximum is up to 100 by request.

'last' parameter should be used as described in the API spec to go page by page.

+1 on @mnarusze comment :
when provisionning data, if show all is selected, it should call the api in loop /v2/_catalog?n=&last=<100thRepoFound> with the last item found from previous search until no results are found

I can't really test it from work. If sometone with the issue can check with that PR, it would be nice.

@drallieiv any updates on this?

just tripped up on this myself, setting the number to something high works around the issue e.g. ...repositories/99999
, but it would be nice to have the 'all' limit working as designed.


Add license file and move contribution docs

Yes, I'm fine with Apache 2.0. I was not sure. Should we add the license header to all files or do you prefer to just keep it in the README?

Just the readme imo since it's less hassle. What do you think?
On Sat, 16 Sep 2017 at 23:23, Jonas Fonseca<EMAIL_ADDRESS>wrote:

Yes, I'm fine with Apache 2.0. I was not sure. Should we add the license
header to all files or do you prefer to just keep it in the README?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/scalameta/metadoc/pull/70#issuecomment-329998422, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABV8XY_tMHFCpN3aaBOIrwLVL0jlOMVOks5sjEp9gaJpZM4PZcjN
.

Works for me. I put a single copyright for now since markdown formats it wrong otherwise.


[release/1.6] vendor<EMAIL_ADDRESS>

Issue
release/1.6 is showing warnings from indirect dependency gopkg.in/square/go-jose/v2 with no recommendation to resolve.
Description
This change vendors<EMAIL_ADDRESS>which updates its dependency on square/go-jose/v2 (deprecated) to go-jose/go-jose/v3 (recommended) to resolve warnings for https://pkg.go.dev/vuln/GO-2024-2631.
With 638b474c81cefa7d498d00c30ae689a285e383a3, containerd/imgcrypt was temporarily removed in main, so there would not be a commit to cherry-pick for this change.
full diff: https://github.com/containerd/imgcrypt/compare/v1.1.4...v1.1.8
Signed-off-by: Austin Vazquez<EMAIL_ADDRESS>

Rebased.


Feat/virtual joystick

New feature added: Basic Virtual Joystick
Hi, I decide implement this feature because it appears to be in high demand. Hope you find interesting.
Description:

Joystick can be activated by button on bottom (see picture)
For resolutions less than 650px wide it's active by default
When resolution ir less than 650px and chat is active, joystick is hidden because it interferes with the chat

For implement this, I use this component: https://github.com/elmarti/react-joystick-component
Note: This feature will conflict with this PR:  https://github.com/kevinshen56714/SkyOffice/pull/62
I can take care of resolving conflicts
Related issues:

https://github.com/kevinshen56714/SkyOffice/issues/23
https://github.com/kevinshen56714/SkyOffice/issues/60

This is awesome! Thanks for your contribution, please feel free to reach out if any of the comments are unclear or if you don't agree on any of them!

@DaxChen Hi, thanks for the review. I just uploaded a new commit with the changes. Anything else let me know 😊👍

Oohh, Sounds great! As soon as this PR is resolved I'll pull the project with this feature.

@DaxChen Hi, thanks again for your review. I've applied all the changes you have commented. If you see anything else feel free to let me know.


There are some validation rules that should be made clear

Namely, that the State and Effort fields cannot be included on new records. As currently implemented, if you are importing workitems from another system you must first import the workitems as New and without effort attached. You'll then need to export the workitems to get the ID's, and ReImport the items with the updated State and Effort.
It would be nice if the import would accept these fields and fast-forward the workitems into the appropriate state, but since it currently doesn't these sorts of validation requirements should be made clear here. It took me quite some time to figure this out.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4296d1cc-f211-9d17-d97f-2b0858fdea7d
Version Independent ID: cc66dfee-adde-cdfb-b3f5-5d58d89d3c81
Content: Import work items from a csv file through the web - Azure Boards
Content Source: docs/boards/queries/import-work-items-from-csv.md
Product: devops
Technology: devops-agile
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@crmckenzie - Thank you for the feedback. I will update the topic to reflect the limitation that all work items imported start with the New state.

@KarthrynEE  it would be good that it is made clear that custom created field are alsno not applicable for updating when making new work items


Jobs list view problems

Slow to update.
Looses track of selected items in pick list
Cancel of jobs didn't work.

The slow to update and looses track of selected items in pick list are both UI related and should be entered under the scale-ui repository.
More detail than just "didn't work" should be provided when entering issues. Did it give a 500 error? Did it just do nothing? Moving the first two items to the ui repo, and closing this one in favor of a more specific Cancel Jobs issue.


Step 2 should state that "Apply" needs to be clicked

I've lost count how many times I've visited this page looking for service principals, then remember I have to choose "all applications" and I forget to click apply.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c1ef3583-67cc-685f-fb2e-09b64f682bf2
Version Independent ID: 8e441ecd-4771-8620-4423-8c40d8cce192
Content: View service principal of a managed identity in the Azure portal - Azure AD
Content Source: articles/active-directory/managed-identities-azure-resources/how-to-view-managed-identity-service-principal-portal.md
Service: active-directory
Sub-service: msi
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@oising
Thanks for your feedback! We will investigate and update as appropriate.


[Bug] Max length of Endpoint ID in trace and log tables is too short (JDBC storage)

Skywalking-oap 9.2 error on column endpoint_id

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
OAP server (apache/skywalking)
What happened
Hello, I have the skywalking-oap version at 9.2.0 and my java-agents have 8.12.0 with mysql.
I'm having this error that it's releated to this one https://github.com/apache/skywalking/issues/6262, can you help me?

What you expected to happen
Generate an script to modify this table to solve the error
How to reproduce
This error came from agents that have endpoints longer than the table can support
Anything else
No, thank you
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Unless you could tell which ID, I am afraid I don't know what is going on.
Like https://github.com/apache/skywalking/issues/6262 mentioned, we had fixed the issue we had known.

You submit an empty title and only an error stack. I have to close this as you don't pay enough attention to request help from a community.
For open-source, you should debug first, and try to locate the root cause.

OK. I think I know what is going on. Some columns are locked as 200.

Please remember to keep the title of the issue completed. Otherwise, we would continue the process in next time.

I found for example this is the way that the agents send info into skywalking-oap
PG5hbWVhcHB3ZXJ5bG9uZz5iYXNlNjQ6IGVudHJhZGEgaW52w6FsaWRhCg==
I modify it to not show the pod name
When I decode it i can see this result:
base64: entrada inválida
When this info came from a pod that have a longer name or the info that want to send to skywalking-oap is bigger than the capacity of the column.
Hope it will be helpfull

Should be fixed by https://github.com/apache/skywalking/pull/9947


Add QR code support

The PhoneGap Mobile App redesign includes the ability to scan a QR code as an alternative to using the IP address. This means that both the CLI and Desktop app need the ability to display a QR code and IP address when serving an app.

There is no deadline set at the moment, but an estimate would be end of 2016
We can reuse the QR code node library used by node-phonegap-build

@mwbrooks this is specifically QR code support for the serve command, yes?


Make action behaviour to fail configurable

By default this action sets a failed state when it does not find any linked issues, however we may have a use-case where we only need to be notified via a comment on the PR and not fail the workflow.

We post a comment on the target PR suggesting to link issues (and perhaps include the suggestion to link it via PR desc just to reiterate the limitation that linking via UI doesn't trigger our workflow)
We add an input say mode which can accept notify or enforce as values that'd indicate whether the workflow will set failed status or not when it finds no linked issues
We may want to consider implementing this behavior via check runs (I don't know if it really makes sense but just to research it really) From https://github.com/nearform/github-action-check-linked-issues/pull/1#discussion_r779421452

we may have a use-case where we only need to be notified via a comment on the PR and not fail the workflow.

I can't see this being useful in a real world scenario. The purpose of this action is "to enforce traceability" so you can only do that by set the step to fail. Regarding a configuration to add a comment, yeah I agree! I think it could be useful.

@nuragic @salmanm  In regard to add comment on the target PR, should we always add a comment right after the workflow starts or it would be better just when it fails?

I think that only when it fails. We should also edit (or remove) that comment once the PR is updated and an issue has been linked.

I agree, if it passes theres no need to suggest to link the issue.


chore: update multidict

update multidict, which prevents the need for c++ build tools on windows
Fixes #378

@aorumbayev Yeah good idea


Add "primary key" flag

From the discussion started in chaise#338:
"It would be nice to have some sort of "primary key"-esque flag in ermrestjs so that we don't duplicate the code to find this shortest key in multiple Chaise apps. Maybe it could be something along the lines of table.[uniqueId | uniqueKey].get(). If not, we could also abstract it away to the common/ folder, but it feels strange to put this kind of key-finding operation in Chaise."
Tagging @robes to get his take on whether this is a good idea.

I am in favor of the idea. @karlcz maybe this can be solved by a simple heuristic:

if a table has only one simple key, it must be the primarykey
if a table has more than one simple key, then pick the first one and declare it the primarykey
we could add an annotation tag:...:primarykey to ermest's recommendations to override this behavior

Then as @howdyjessie suggests, the api would be table.primarykey which would just be an instance of the Key class.

Sorry I missed this the first time around and just heard about it in conversation...  I think it is a mistake to talk about "primary key" as a concept in ERMrest and Chaise as it is a SQL concept that doesn't really surface in our catalog model.  For most purposes, every key that is exposed in ERMrest model introspection is equally meaningful and particularly if it's constituent column(s) are constrained as not-null, then they really are equivalent from a data manipulation perspective.
The reason to choose one key over another is largely aesthetic and requires some use-case information. If Chaise has a need to choose a key for record-linking or other tasks, I think that should be implemented client-side in Chaise and/or ermrestjs as a simple hueristic to choose among the available keys on the table.  For example, you might just sort the keys based on several criteria:

Put all non-nullable keys before nullable, i.e. always use a non-nullable key if available
Put shorter key tuples before longer key tuples, i.e. prefer simple keys instead of composite
Order keys by their first constituent column position in table definition? Modelers often put their "important" keys first when defining tables...

The preferred key would be the first key in the sorted key list. The non-nullable part is the only part that really matters.  The others are just possible tie-breakers that might make for nicer URLs etc.
If simplicity of the URL matters and if making this decision for a single known record, you might even make a dynamic decision based on row values!  Any non-null value is equally valid as a key, regardless of whether the schema allows a null to appear.  And shorter text values, values without special characters, and/or smaller integer values might make for simpler/prettier URLs...

This is probably a 'wontfix' issue for the time being, at least not in the way it was originally posed. We have done this sorting approach in the Chaise level BTW, and if its useful its something we should consider pushing down to ermrestjs.


Cleanup code scanning warnings

Most seem simple syntax clean ups but under security code scanning theres about 20+ currently existing.


Research jakarta.jms.Connection.createSession() in both Dispatch and Inbound.

Applications running in the Jakarta EE web and EJB containers must not attempt to create more than one active (notclosed) Session object per connection. If this method is called in a Jakarta EE web or EJB container when anactive Session object already exists for this connection then a JMSException may be thrown.

Review done. No action needed.


[Feature request]Validation String extension

validation extension is also concept?
like this
extension EmailValidator on String {
  bool isValidEmail() {
    return RegExp(
        r'^(([^<>()[\]\\.,;:\s@\"]+(\.[^<>()[\]\\.,;:\s@\"]+)*)|(\".+\"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$')
        .hasMatch(this);
  }

  bool isValidHoge() {
     // blah-blah-blah
  }

  // ....
}

If it is. I will do pull-request.

@shinriyo I like the idea. What else could we validate? Emails, URLs, ...

@leisim both of them.
and telephone numbers also

@shinriyo Phone numbers are super complicated to validate. I think this should be a separate package (see github.com/google/libphonenumber)

@leisim Thank you. I checked the URL's contents. but, there are not dart languages though it is google official language.

We should avoid adding too many extensions on String. Strings are widely used and most don't represent a phone number or an email address.
For such cases I suggest creating new packages, like an email validator which could also contain validation logic.
final String mailAddress = json["email"] as String;
final EmailAddress email = EmailAddress.tryParse(mailAddress);
if (email != null) {
  print("Email is valid");
}

Side note: Email validation is as tricky as phone number validation. Probably impossible to cover in a single regex. I'd be happy if there is a package with like 100 tests for it 😉


net: mdns: add capability of providing records in runtime

Current implementation of mDNS responder does makes it mandatory to have all the records set at compile time. It is not suited well for applications that have to publish/unpublish or change records in runtime, e.g. data received from the network.

Current implementation of mDNS responder does makes it mandatory to have all the records set at compile time.

Technically, that's not exactly the case, it only requires the pointers to memory for DNS records to be set at compile time (and subsequently the number of records).

It is not suited well for applications that have to publish/unpublish or change records in runtime, e.g. data received from the network.

The memory that each record points to can be runtime modifiable today.
In any case though, dns_sd is definitely ripe for improvement.

cc @pdgendt

Hello @cfriedt,
Thank you for your comments

The memory that each record points to can be runtime modifiable today.

That was my first idea. However, it's not possible because the text_size field of dns_sd_rec is not a pointer so it would have a fixed value and cannot be modified: https://github.com/zephyrproject-rtos/zephyr/blob/e544bdb5e2ba254c4357c8835f26405b05c370d2/include/zephyr/net/dns_sd.h#L233
Moreover, such approach would be enough for a small number of records. With this approach the user can provide a pointer to a static array, memory slab, heap allocated memory, etc.

@cfriedt @ssharks @tbursztyka, sorry for bothering you but it seems that this PR could be closed with an additional approval, could you please look at it? Thanks in advance.

The only thing I observe: Is it clear to the users that the mdns_responder_set_ext_records knows it have to make the data stay at that location instead of providing a stack variable?

@ssharks, Thank you for the question, I think that providing a stack variable is perfectly fine as long as the scope is prolonged - e.g. we can have an array of dns_sd_rec in the main() function with while (true) loop. Another example - delegating k_work to publish records only once for some time (e.g. for 5 minutes after initialization) where there is no point to occupy the RAM for whole time. These are not common use cases and of course one can use other solutions but I believe there is no need of enforcing protection from this (+ it feels like a common sense, like not returning pointers to stack variables).

@jukkar I am sorry for the delay. There is no problem with addressing the comments regarding the code. However, I had tried to write a test case for my change and I found that with the current implementation it's quite hard to do. Unfortunately, at the moment I will not be able to provide a proper test implementation.

@konradderda will you return to this before the 3.6 merge window closes this week?

ping @konradderda, are you able to continue with this? The needed changes look rather small and it would be nice to get this merged as this has been pending for a long time. It would be also nicer to get this in at the beginning of the 3.7 release cycle than at the end.

The needed changes look rather small

Hmm, I missed the fact that unit tests would need changes too so the amount of work is bigger.

@jukkar @MaureenHelm I had finally got some time and prepared a test for this change with a foundations for implementation of new test cases in the futute. Also, I have applied last remarks from @cfriedt .


tar: Option --xattrs is not supported on OS X el Capitan

When I try building an image on an OS X El Capitan host, the following error is thrown once the squash step is reached:
2016/09/01 23:52:01 ▶ Loading export from /tmp/habitus-export-527359243 using /tmp/docker-squash612669813 for tempdir
2016/09/01 23:52:02 ▶ Loaded image w/ 18 layers
2016/09/01 23:52:02 ▶ Extracting layers...
2016/09/01 23:52:02 ▶   -  /tmp/docker-squash612669813/036fc864e6c7d0b6f75fe523e4a1a852f72115062e76f0a9d14877989948eb4a/layer.tar
tar: Option --xattrs is not supported
Usage:
  List:    tar -tf <archive-filename>
  Extract: tar -xf <archive-filename>
  Create:  tar -cf <archive-filename> [filenames...]
  Help:    tar --help

2016/09/01 23:52:02 ▶ Build for step carrier failed due to exit status 1

I am fairly sure this line is causing the problem however I am not knowledgeable enough in this area to actually resolve the problem.
Related issue on docker-squash
Dirty work-around, I have tested and this does work however it feels like there should be a neater solution to this problem

I am fairly sure this line is causing the problem however I am not knowledgeable enough in this area to actually resolve the problem.

hi jim. because there is more information stored in the image layers, we need the --xattrs parameter. we can't create a switch in the code saying... if mac_ox_s don't use --xattrs. It feels a bit a like hack indeed. but we must blame Apple not to include a better version of Tar ;-)

hi @jmversteeg! check this page https://github.com/cloud66/habitus/blob/gh-pages/gnu-tar.md


Filter NodeObservability with name 'cluster' only

Checks resource name within reconcile loop and sets status Ready to false+reason=InvalidName when name is not cluster

Fixes all NodeObservability resources (in README, csv, tests) to respect this rule

Fixes all NodeObservabilityRun.spec.NodeObservabilityRef to use NodeObservability called cluster

Fix CSV empty image

Fix request limits on kube-rbac-proxy container

Fix securityContext

This makes the NodeObservabilityRef useless. Planning to remove it

/label tide/merge-method-squash

/cc @darshan-nagaraj

/assign @alebedev87
/assign @darshan-nagaraj

/lgtm

/retest

/lgtm

/docs-approved

/label docs-approved
on behalf of @darshan-nagaraj

/label qe-approved
/label px-approved


System Assigned Managed Identities not removed

Hello,  I created a couple test Azure Automation accounts with System Assigned Managed Identities.  After deleting the automation accounts, the identities are still showing in Azure AD and on the subscription with the RBAC role I assigned to it.  I waited several hours and the have not been removed.
Thanks,
Travis

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1120c9a-3914-9d67-514b-9fc31f03c781
Version Independent ID: 10f55706-5cab-a9ac-c89d-122f2cfca249
Content: Disable your Azure Automation account managed identity (preview)
Content Source: articles/automation/disable-managed-identity-for-automation.md
Service: automation
Sub-service: process-automation
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

Hello,
In my recent experience, following the steps in the article did not remove the System Assigned Managed Identity from Azure AD.  It looks like I need to manually delete the identities from Azure AD after removing the Automation account.
I understand that this is in preview and not fully integrated yet, I just wanted to raise awareness that my experience was different from what was outlined in the article.  Feel free to close this issue.
Thanks for your help!
Travis
From: Matt Goedtel @.>
Sent: Friday, April 23, 2021 12:09 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Travis Roberts @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] System Assigned Managed Identities not removed (#74282)
@tsrob50 https://github.com/tsrob50  - Support for a system-managed identity is in preview currently for an Automation account, and the only supported method to disable/delete the managed identity is by following the two methods described in this article. At this time, it is not fully integrated with the Automation account where the managed identity is created while creating the Automation account or removing when deleting the account.
If I have misunderstood your scenario, please clarify and I'll do my best to respond.
—
You are receiving this because you were mentioned.
Reply to this email directly,  https://github.com/MicrosoftDocs/azure-docs/issues/74282#issuecomment-825795735 view it on GitHub, or  https://github.com/notifications/unsubscribe-auth/AGP6T73K4BM27O57VIJGXSLTKGSRVANCNFSM43OY5BHA unsubscribe.  https://github.com/notifications/beacon/AGP6T77QRL47VVGK5DWZCALTKGSRVA5CNFSM43OY5BHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGE4KJFY.gif

Thanks for providing feedback that helps improve our documentation. This issue has been resolved and we are closing the issue. #please-close


some fixes to return links

so i was away and didn't have much time to test #1003
this one work perfectly

Thanks @mikalauskas!

Thanks @mikalauskas!