Refactor DistinctTable to use PriorityQueue based algorithm

Currently DISTINCT query is solved the same way as GROUP-BY queries,
which is not necessary (consume much more memory and CPU) and does
not guarantee accuracy of the result.
Instead, DISTINCT query can be solved by a set and a heap efficiently
(similar to SelectionOrderBy but unique records need to be tracked).
The new DistinctTable does not implement the Table interface because
the table interface is designed mostly for the GROUP-BY queries, and
is not efficient for DISTINCT. If in the future we want to use Table
interface to uniform all the input/output, we can redesign the Table
interface to make it suitable for all types of queries.

@siddharthteotia Addressed all the comments


Clustering Polylines and Polygons

Is it possible to extend the Polygon and Polyline classes to create clusterable shapes in similar way as with JS Leaflet (see snippet)? Just inserting the following snippet gives an unsurprising

Property clusterableX does not exist on type 'typeof L'

L.ClusterablePolyline = L.Polyline.extend({
    _originalInitialize: L.Polyline.prototype.initialize,

    initialize: function (bounds, options) {
        this._originalInitialize(bounds, options);
        this._latlng = this.getBounds().getCenter();
    },

    getLatLng: function () {
        return this._latlng;
    },

    // dummy method.
    setLatLng: function () {
    }
});

L.ClusterablePolygon = L.Polygon.extend({
    _originalInitialize: L.Polygon.prototype.initialize,

    initialize: function (bounds, options) {
        this._originalInitialize(bounds, options);
        this._latlng = this.getBounds().getCenter();
    },

    getLatLng: function () {
        return this._latlng;
    },

    // dummy method.
    setLatLng: function () {
    }
});

This is a typescript error. If you want to do this, you'll need to either create typings that extend the L namespace to have CluterableX interfaces/classes or cast L to any and then do your operations:
let L_any = L as any;
L_any.ClusterablePolyline = L.Polyline.extend(...);

Thank you for your advice!
I tried the let L_any = L as any;  but his just creates a new error:

ERROR TypeError: this.callInitHooks is not a function
at Object.NewClass [as ClusterablePolyline]

I remember coming across this error earlier when I was experimenting with pure JavaScript and I resolved it by declaring the variables earlier in source code. In Angular I have tried declaring them in ngOnInit and onMapReady but both of them produce the TypeError. I also tried to create them outside the prementioned functions but no cigar. I am out of ideas as it is.

If I had to guess, I'd say it has something to do with the interplay between the way that leaflet's extension works, how you're referencing 'this', and how Typescript interprets and compiles all of that.
It's probably resolving this to the scope of the L.ClusterableX definition. Which means, this is not what you expect it to be.

I'm gonna close this though, it isn't really an issue with the ng2 wrapper.
You can check out the @asymmetrik/leaflet-d3 project for an example of writing/publishing a leaflet plugin for consumption by a Typescript project (it includes an example d.ts file).
This would allow you to package your Clusterable Poly classes and include them in an angular project without having to write them in Typescript (which I'm not sure there's a good way to do).
Thanks for checking out this project, and hopefully this helps you!

Just to check in that I got it working!
I declared the new variables in onMapReady function by using the following code:
(L as any).ClusterablePolyline = L.Polyline.extend({
      _originalInitialize: (L as any).Polyline.prototype.initialize,

      initialize: function (bounds, options?) {
        this._originalInitialize(bounds, options);
        this._latlng = this.getBounds().getCenter();
      },

      getLatLng: function () {
        return this._latlng;
      },

      // dummy method.
      setLatLng: function () {
      }
    });

    (L as any).clusterablePolyline = function (latlngs, options?) {
      return new (L as any).ClusterablePolyline(latlngs, options);
    };

    (L as any).ClusterablePolygon = L.Polygon.extend({
      _originalInitialize: (L as any).Polygon.prototype.initialize,

      initialize: function (bounds, options?) {
        this._originalInitialize(bounds, options);
        this._latlng = this.getBounds().getCenter();
      },

      getLatLng: function () {
        return this._latlng;
      },

      // dummy method.
      setLatLng: function () {
      }
    });

    (L as any).clusterablePolygon = function (latlngs, options?) {
      return new (L as any).ClusterablePolygon(latlngs, options);
    };

Has there been any improvement on this or is @K0ntrol 's way the only way to achieve this?
Thanks!

@K0ntrol also interesed if this is something that can be "supported" by the plugin or there is a elegant solution for this.

@xigolle I did not look further into this after getting it to work with the aforementioned not-so-elegant snippet.


Unable to login and view dashboard

Hey guys,
I've followed all the steps from the setup tutorial (https://thingsboard.io/docs/pe/mobile/getting-started/) accurately. If I set the endpoint to the ThingsBoard cloud (https://thingsboard.cloud/) then the app works perfectly, but if I set the endpoint to my ThingsBoard PE server instance, then I can't login to the app. On the server, under audit logs, it does indicate a successful login however nothing changes on the app. Has anyone experienced this problem or could they advise on a solution? Thanks

Same problem here. I can't even login to thingsboard cloud let alone my PE server. Did you use<EMAIL_ADDRESS>as username and tenant as password?

No, for the cloud I created an account first and then used that credentials to login on the app.

Ok after some time, I think that the ThingsBoard client library in the latest app code is for ThingsBoard PE version 3.4.2. So I've used an older commit from April (https://github.com/thingsboard/flutter_thingsboard_pe_app/tree/6bbe02b932f48e47d90698b2990af8706dbf3443) and after a few hours of fixing errors it works. I recommend perhaps using this commit instead.

@vvlladd28 please take a look

Hello @MM-06,
I will close this issue since a significant amount of time has passed since your initial query. However, if the issue is still relevant, please feel free to reopen it and provide additional information, such as the mobile app console output.
Thanks!


How to resume from a partial result?

I ran the script successfully but along the lines, there was an error and the script halted. I would very much like to start from the point it stopped working instead of starting from 0 again. How can I do that?
The error for reference is:
🔍 Searching ...:  35%|█████████████▉                          | 182/522 [12:07:04<1081:46:41, 11454.12s/it]Traceback (most recent call last):   File "/home/red/ChatGPT-API/ChatGPT-API-Leakage/main.py", line 352, in <module>     main(from_iter=args.from_iter, check_existed_keys_only=args.check_existed_keys_only)   File "/home/red/ChatGPT-API/ChatGPT-API-Leakage/main.py", line 321, in main     leakage.search(from_iter=from_iter)   File "/home/red/ChatGPT-API/ChatGPT-API-Leakage/main.py", line 217, in search     self._process_url(url)   File "/home/red/ChatGPT-API/ChatGPT-API-Leakage/main.py", line 124, in _process_url     self.driver.get(url)   File "/home/red/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 356, in get     self.execute(Command.GET, {"url": url})   File "/home/red/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 347, in execute     self.error_handler.check_response(response)   File "/home/red/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py", line 229, in check_response     raise exception_class(message, screen, stacktrace) selenium.common.exceptions.TimeoutException: Message: timeout: Timed out receiving message from renderer: 288.007   (Session info: chrome=126.0.6478.61) Stacktrace: #0 0x5556c728f6aa <unknown> #1 0x5556c6f720dc <unknown> #2 0x5556c6f59456 <unknown> #3 0x5556c6f59035 <unknown> #4 0x5556c6f56f76 <unknown> #5 0x5556c6f575ef <unknown> #6 0x5556c6f67f17 <unknown> #7 0x5556c6f7e46e <unknown> #8 0x5556c6f83b6b <unknown> #9 0x5556c6f57d3a <unknown> #10 0x5556c6f7e2ee <unknown> #11 0x5556c70008f6 <unknown> #12 0x5556c6fe1613 <unknown> #13 0x5556c6fb14f7 <unknown> #14 0x5556c6fb1e4e <unknown> #15 0x5556c725587b <unknown> #16 0x5556c7259921 <unknown> #17 0x5556c724136e <unknown> #18 0x5556c725a482 <unknown> #19 0x5556c7225ccf <unknown> #20 0x5556c727f0a8 <unknown> #21 0x5556c727f280 <unknown> #22 0x5556c728e7dc <unknown> #23 0x7f050a1d2ac3 <unknown>

Try this
python3 main.py --from-iter 182

Although at the moment it stopped, it was validating the keys and --from-iter makes it starts the crawling process to gather keys, thank you for the help. Most people don't even try to help like you did so instantly,


Meals listing: bring back the "hover" for peeking at menus

This was a popular feature
Originally created by Willie Northway at 2015-09-03 23:39, migrated from redmine-#3037

Tracker changed from Bug to Feature

Priority changed from 4 to 5

Deb Kraus and Malcolm Sickels have asked for it so far.
By Willie Northway at 2015-09-04 04:27


Mojito arrow os marsellinus

Don't do pr, you have push access. Use proper method by creating branch

I can't create a branch in here ROM-builders/temporary so I pulled


Ticket file upload

Another that is missing is the ability to add files to a ticket, from my point it's a very useful thing to have it.

You will have an option to see the attached files and upload others.

Another that is missing is the ability to add files to a ticket, from my point it's a very useful thing to have it.

You will have an option to see the attached files and upload others.

Yes totally agree, I am planning to add this feature to the next release, I am already working on it in my local.

The last release (1.1.7) contains the Attachments tab

The files are stored separately in a folder with the name of the ticket code


Use Arg module for better CLI usage/reporting

What
This allows running commands like:
lonac workspace --target swift --workspace examples/test --output examples/generated/test/swift
This also adds a help menu and better invalid option reporting.
This update should be 99% backwards compatible, e.g. positional arguments will still work, but they won't be recommended in the help menu. The only things that are different are --debugConstraints and --generateCollectionView, which no longer require a value, since they're booleans.
cc @mathieudutour this shouldn't break the docs/sketch plugin, but if a command stops working I wouldn't be surprised if it was due to this.
The help menu:
The Lona compiler generates code from a Lona workspace (a directory with a lona.json manifest file).

The following commands are available:

  workspace
  component
  colors
  textStyles
  shadows
  types
  config
  version

Type `lonac [command]` to see which options are required for that command. The following options are available:

  --target {js|swift|xml}
                               Output language
  --workspace [path]           Workspace directory path
  --output [path]              Output directory path
  --input [path]               Input file path (for commands that take an input file)
  --filterComponents [pattern] Only generate components matching this string (converted to a regular expression)
  --framework {uikit|appkit|reactdom|reactnative|reactsketchapp}
                               UI framework
  --swiftVersion {4|5}
                               Swift version
  --debugConstraints           Generate constraint IDs for easier debugging
  --generateCollectionView     Generate experimental UICollectionView subclass that renders LonaModels as cells
  --typePrefix [prefix]        Generated type prefix
  --styleFramework {none|styledcomponents}
                               Style framework
  --styledComponentsVersion {3|latest}
                               styled-components library version
  --minimumIeSupport {none|11}
                               Minimum version of IE supported
  -help                        Display this list of options
  --help                       Display this list of options

when looking at git for example, it doesn't list the options when showing the help for git. It only shows them when looking at the help for a specific command.
If the number of options starts to grow, we might want to take a similar approach

that's a good idea, and the only reason I didn't was cause the Arg API makes it kind of hassle 😢, but we can do it another time


Update notification for PowerShell

Summary of the new feature/enhancement
Currently PowerShell does already show update notifications. Seen this on Windows Terminal, might also apply in classic Windows console (not tested)
Proposed technical implementation details (optional)
Option 1 (as-is)

Option 2 (might feel intrusive)
Toast notification for updates
https://gist.github.com/dend/5ae8a70678e3a35d02ecd39c12f99110
Option 3 (might feel most intrusive, easy UX for non devs)
Updater

refer implementation of PowerToys, I find theirs pretty good.
Checking for updates
update notifcation, uninstall, install and progress notification
improvements over PowerToys: uninstall / install could be silent as it is MSI, but they do not use silent switch for MSI atm

things that should be adjustable

update settings (automatic, manual, defer)
target version
minimum version
channel (release, preview)

switches via registry (better ADMX and Intune Policies) similar to Windows / Office implementation.
Option 4
when conditions are met (Windows, appropriate version), offer winget to install / upgrade
https://github.com/microsoft/winget-cli/issues/120

echo this, do we provide a simple way to upgrade powershell in powershell itself? like just run a cmdlet as "Upgrade-this" or anything

echo this, do we provide a simple way to upgrade powershell in powershell itself? like just run a cmdlet as "Upgrade-this" or anything

I would rely on winget to be honest. But it is sad to see that Server vNext has still no Winget support.

I would rely on winget to be honest. But it is sad to see that Server vNext has still no Winget support.

Picking this up again, rather than creating a separate suggestion/issue:
I think installations from the Microsoft Store should simply include a clickable link to directly open the store page (maybe make the "Upgrade now" clicky?).
This would already provide a more casual friendly upgrade process without introducing any additional user interface elements or maintainable components.

I think this is a duplicate of other very similar issues & comments made on this & these ideally need linking together. Though this is a hard thing to get right because there is on one way that you can install/maintain that install.
Comments around how to improve the User/Dev/Admin experiences across Windows versions help but we also need bigger picture conversations even if many might have previously been covered.
Think this can be "resolution-duplicate" but feel that we should get this linked to similar discussions/issues that have been raised for this for tracking purposes.


Icon request: NextDNS

URL of the site or app (required): https://nextdns.io/
Logo resources for the icon (optional, but recommended):

Here you go!
https://github.com/krisu5/aegis-icons/blob/master/PNG/NextDNS.png


Mount osdctl config file if it exists

PD config is now loaded from the osdctl config file now that openshift/osdctl#278 has been merged.
This just adds a mount for that file so we can use osdctl cluster context within ocm-container.
I am not sure what else uses the old pagerduty-cli config file anymore so I left that as-is for now

/lgtm

/lgtm


fix: lowercase for environment + difficulty level on proxy record

I mixed up name and name(), and assumed coverage meant something was tested instead of just that we had some test that ran that bit of code.

The code coverage stats tell you whether a particular line was run in any test, rather than whether there were any assertions that related to the code in question. For example, it is the difference between
myfunc();

and
assertThat(myfunc(), is(1))

The former calls, but doesn't test anything except that the code doesn't crash; the latter tests the actual function.
In this case it's much less obvious: some test calls a complicated bit of code that includes the relevant lines, then tests something else, and not those lines in particular.


fix(docs): update React integration name to qwik-react

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests

Description
The correct integration name for React is qwik-react
Use cases and why

One use case

Another use case

Checklist:

[ ] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Good catch, thanks


Java 21 was released on 19th September 2023

On https://hub.docker.com/_/eclipse-temurin the tag for Java 21 is missing,
though it was released a few days ago.
https://github.com/adoptium/temurin21-binaries is still missing a release (only prereleases are currently built and distributed).
This issue is intended as a reminder.

We're waiting for TCK access to complete this release.  Please visit our adoptium/adptium repo to track progress

I assume this issue is meant https://github.com/adoptium/adoptium/issues/248 ?

We're waiting for TCK access to complete this release. Please visit our adoptium/adoptium repo to track progress

In recent past releases there was a banner on the homepage linking to the GitHub checklist.  I've been checking daily, waiting for this to show up for 21, but it never did, so I had to google to find #248.


fix: Allows CustomHeader backgrounds the possibility of being transparent

GitHub Issue: #386
PR Type
What kind of change does this PR introduce?

Bugfix

Description

Removed a default background color

PR Checklist
Please check if your PR fulfills the following requirements:

Commits must be following the Conventional Commits specification
[x] Tested UWP
[ ] Tested iOS
[x] Tested Android
[ ] Tested WASM
[ ] Tested MacOS
[x] Contains No breaking changes

If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

Internal Issue (If applicable):

Noticed and need the adjustment for gallery sample


moved at first line WidgetsFlutterBinding

I am experiencing the same issue that I previously reported. That's is why I added this line at the first line
Restarted application in 738ms.
E/flutter ( 5450): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Binding has not yet been initialized.
E/flutter ( 5450): The "instance" getter on the ServicesBinding binding mixin is only available once that binding has been initialized.
E/flutter ( 5450): Typically, this is done by calling "WidgetsFlutterBinding.ensureInitialized()" or "runApp()" (the latter calls the former). Typically this call is done in the "void main()" method. The "ensureInitialized" method is idempotent; calling it multiple times is not harmful. After calling that method, the "instance" getter will return the binding.
E/flutter ( 5450): In a test, one can call "TestWidgetsFlutterBinding.ensureInitialized()" as the first line in the test's "main()" method to initialize the binding.
E/flutter ( 5450): If ServicesBinding is a custom binding mixin, there must also be a custom binding class, like WidgetsFlutterBinding, but that mixes in the selected binding, and that is the class that must be constructed before using the "instance" getter.
E/flutter ( 5450): #0      BindingBase.checkInstance. (package:flutter/src/foundation/binding.dart:308:9)
E/flutter ( 5450): #1      BindingBase.checkInstance (package:flutter/src/foundation/binding.dart:389:6)
E/flutter ( 5450): #2      ServicesBinding.instance (package:flutter/src/services/binding.dart:56:54)
E/flutter ( 5450): #3      _findBinaryMessenger (package:flutter/src/services/platform_channel.dart:136:25)
E/flutter ( 5450): #4      BasicMessageChannel.binaryMessenger (package:flutter/src/services/platform_channel.dart:181:56)
E/flutter ( 5450): #5      BasicMessageChannel.send (package:flutter/src/services/platform_channel.dart:195:38)
E/flutter ( 5450): #6      SharedPreferencesApi.getAll (package:shared_preferences_android/src/messages.g.dart:227:10)
E/flutter ( 5450): #7      SharedPreferencesAndroid.getAllWithParameters (package:shared_preferences_android/shared_preferences_android.dart:99:20)
E/flutter ( 5450): #8      SharedPreferencesAndroid.getAll (package:shared_preferences_android/shared_preferences_android.dart:81:12)
E/flutter ( 5450): #9      SharedPreferences._getSharedPreferencesMap (package:shared_preferences/shared_preferences.dart:255:38)
E/flutter ( 5450): #10     SharedPreferences.getInstance (package:shared_preferences/shared_preferences.dart:78:19)
E/flutter ( 5450): #11     MemoryManager.init (package:maid/static/memory_manager.dart:19:23)
E/flutter ( 5450): #12     main (package:maid/main.dart:10:17)
E/flutter ( 5450): #13     _runMain. (dart:ui/hooks.dart:159:23)
E/flutter ( 5450): #14     _delayEntrypointInvocation. (dart:isolate-patch/isolate_patch.dart:296:19)
E/flutter ( 5450): #15     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:189:12)
E/flutter ( 5450):
D/EGL_emulation( 5450): app_time_stats: avg=22691.62ms min=22691.62ms max=22691.62ms count=1

Also I added an automatic configuration for n_threads slider. I tested only on my android device

Ive never seen this issue before? try clearing the cache if you haven't already.

Yeah this happens on my linux too.

I take this opportunity to report another error:
Launching lib\main.dart on Windows in debug mode...
C:\Users\Enjoy\Desktop\Dev\Maid\core\llama.cpp\ggml-quants.c(532,26): warning C4244: '=': conversione da 'float' a 'int8_t'. Possibile perdita di dati. [C:\Users\Enjoy\Desktop\Dev\Maid\build\windows\core\llama.cpp\ggml.vcxproj]
C:\Users\Enjoy\Desktop\Dev\Maid\core\llama.cpp\ggml-quants.c(750,36): warning C4244: '=': conversione da 'float' a 'int8_t'. Possibile perdita di dati. [C:\Users\Enjoy\Desktop\Dev\Maid\build\windows\core\llama.cpp\ggml.vcxproj]
C:\Users\Enjoy\Desktop\Dev\Maid\core\llama.cpp\ggml-quants.c(751,36): warning C4244: '=': conversione da 'float' a 'int8_t'. Possibile perdita di dati. [C:\Users\Enjoy\Desktop\Dev\Maid\build\windows\core\llama.cpp\ggml.vcxproj]
C:\Users\Enjoy\Desktop\Dev\Maid\core\llama.cpp\llama.cpp(1103,1): warning C4305: 'inizializzazione': troncamento da 'double' a 'float' [C:\Users\Enjoy\Desktop\Dev\Maid\build\windows\core\llama.cpp\llama.vcxproj]
this is on master branch of your llama.ccp forks (7feec2ef) i can't run debug on windows

Those are warning and they stem from llama.cpp not maid. Not something I can fix on my end. They shouldn't break windows though

ok, does that file exist in your builds asset folder?

Yes, this error is thrown only on debug until the file is loaded, then works fine


Script Picture Frame

Picture Frame component
export type ScriptPictureFrame = {
    type: ScriptComponentType.PICTURE_FRAME;
    imageAsset?: string; // Turn off picture frame is asset is undefined
};

https://apps.atlasacademy.io/db/NA/script/0300060630

https://github.com/atlasacademy/apps/commit/4df0a0907b919f3dbfc32d82d8cd0c83df73212f


Asynchronous version of prefetch method

Hi,
as @mrbox has wrote I am providing async prefetch which is working for us.  This should close #11
We use that like that:
import peewee_async
products = await peewee_async.prefetch(Food.select(), Nutrition.select())
for product in products:
   print(product.nutritions_prefetch)

Hi @cypreess! Thanks you, that's great!
I think we need to add a test case wrapped in sync_unwanted() context just to make sure there are no implicit sync calls involved.

I would really like to provide tests for prefetch but I am struggling with setting workable tests on my dev enviroment.
I got:
$ python setup.py test
running test
running egg_info
writing requirements to peewee_async.egg-info/requires.txt
writing dependency_links to peewee_async.egg-info/dependency_links.txt
writing peewee_async.egg-info/PKG-INFO
writing top-level names to peewee_async.egg-info/top_level.txt
reading manifest file 'peewee_async.egg-info/SOURCES.txt'
writing manifest file 'peewee_async.egg-info/SOURCES.txt'
running build_ext
test_count_query (tests.AsyncPostgresTestCase) ... /usr/local/Cellar/python3/3.5.0/Frameworks/Python.framework/Versions/3.5/lib/python3.5/asyncio/tasks.py:509: DeprecationWarning: asyncio.async() function is deprecated, use ensure_future()
  DeprecationWarning)
ok
test_create_obj (tests.AsyncPostgresTestCase) ... ok
test_create_uuid_obj (tests.AsyncPostgresTestCase) ... ok
test_delete_obj (tests.AsyncPostgresTestCase) ... ok
test_get_obj (tests.AsyncPostgresTestCase) ... ok
test_get_uuid_obj (tests.AsyncPostgresTestCase) ... ok
test_insert_many_rows_query (tests.AsyncPostgresTestCase) ... ok
test_insert_one_row_query (tests.AsyncPostgresTestCase) ... ok
test_insert_one_row_uuid_query (tests.AsyncPostgresTestCase) ... ok
test_scalar_query (tests.AsyncPostgresTestCase) ... ok
test_select_query (tests.AsyncPostgresTestCase) ... ok
test_update_obj (tests.AsyncPostgresTestCase) ... ok
test_update_query (tests.AsyncPostgresTestCase) ... ok
test_atomic_failed (tests.tests_py35.AsyncPostgresTransactionsTestCase)
Failed update in transaction. ... /Users/cypreess/.virtualenvs/peewee_async/lib/python3.5/site-packages/aiopg/pool.py:303: ResourceWarning: Unclosed 1 connections in <aiopg.pool.Pool object at 0x108618208>
  ResourceWarning)
FAIL
test_atomic_success (tests.tests_py35.AsyncPostgresTransactionsTestCase)
Successful update in transaction. ...

And test runner freeze at that point. Any help?
I was trying to change max_connection=1 to avoid pooled pg and it was even worst.
I use py35. It also seems that problem is only in py35 tests, because if I comment them tests passes

OK I was able to provide tests for prefetch, (still other tests fails on my dev machine:)

@cypreess Transactions are half-working actually - not working with connection pool #14


Warning being emitted: --requirements-max-depth

I am invoking flake8 --verbose, and note it emits the following warning
flake8.options.manager    MainProcess    155 WARNING  option --requirements-max-depth: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future

Just thought I would report!  Looks like some internal of flake8-requirements's --requirements-max-depth needs updating.
Setup
My setup.cfg:
[flake8]

max-line-length = 50

Using Python 3.10.4 here's my dependencies:
flake8==5.0.4
flake8-requirements==1.7.0

Nice work!


As a user, I can set reminders in Address Book

... so that I can have more functionality with this application.
We can have a command: addReminder d/date.
We can then use a pop up window to gather user input.
We can then use the browser area to display the reminders in chronological order and indexed, with reminders that are N days away being highlighted in a different color, and those that are overdue in another color.
We can then have a command: deleteReminder index
to delete the reminders using their index.

As a modern user looking for a one-stop application that can provide many related services


p5Dojo

p5Dojo

I am a fan of the technical clocks like the QR codes - even if they aren't that readable!

Yeah, I know.
Had to construct a neural network to decode it.
I used Tensorflow. Gets right 99% of the time.

My only problem is, it is a bit hard to explain missing some meetings.


FIPS provider TLS tests

The FIPS provider needs to be tested against TLS in most or all of the CI builds.
This requires proper interconnection of libssl and providers via properties and library contexts.

We do TLS tests using the FIPS provider.  Closing this.


Failed installation from source -- py_modules?

Decided to install from source.  After installing automake (an apparent dependency),
I crashed out after the library build:
 /bin/mkdir -p '/home/xavier/Projects/Python/NaMaster/_deps/bin'
  /bin/bash ./libtool   --mode=install /usr/bin/install -c namaster '/home/xavier/Projects/Python/NaMaster/_deps/bin'
libtool: install: /usr/bin/install -c .libs/namaster /home/xavier/Projects/Python/NaMaster/_deps/bin/namaster
 /bin/mkdir -p '/home/xavier/Projects/Python/NaMaster/_deps/include'
 /usr/bin/install -c -m 644 src/namaster.h '/home/xavier/Projects/Python/NaMaster/_deps/include'
make[1]: Leaving directory '/home/xavier/Projects/Python/NaMaster'
Traceback (most recent call last):
  File "setup.py", line 120, in <module>
    ext_modules=[_nmtlib],
  File "/home/xavier/anaconda3/lib/python3.7/site-packages/setuptools/__init__.py", line 144, in setup
    return distutils.core.setup(**attrs)
  File "/home/xavier/anaconda3/lib/python3.7/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/home/xavier/anaconda3/lib/python3.7/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/home/xavier/anaconda3/lib/python3.7/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "setup.py", line 87, in run
    _build.run(self) # RM
  File "/home/xavier/anaconda3/lib/python3.7/site-packages/setuptools/command/build_py.py", line 50, in run
    if not self.py_modules and not self.packages:
  File "/home/xavier/anaconda3/lib/python3.7/distutils/cmd.py", line 103, in __getattr__
    raise AttributeError(attr)
AttributeError: py_modules

Will start to investigate (have forked the code and will submit a PR if I figure it out).
Thought I'd raise the Issue now, however.
Am building with Python 3.7 + anaconda on a Linux + Ubuntu 18.0 machine.
I see now that it may matter that I used:
python setup.py develop

Indeed
python setup.py install
ran successfully.  Perhaps someone can advise on how
to use develop.  If that is possible..

@profxj , sorry for the delay in getting to this one. PR #123 should have fixed this, but let me know if the problem persists.


Character Edit/Copy item not working bug

I changed the TQVault.Config.dll XML file like shown in the tutorial to make those values true but even then it still loads and you cannot character edit or copy items anymore, How do you get it to work or is this just a big thatll get fixed soon?

Edit the config file as described.in our FAQ
Save and close the config file
Open TQVaultAE
Open the configuration menu using the top left button
Enable the cheats you want

If the cheat options don't appear in the configuration menu, it means the config file was not edited correctly.

Edit the config file as described in our FAQ (the AllowCheats key)

Save and close the config file

Open TQVaultAE

Open the configuration menu using the top left button

Enable the cheats you want

If the cheat options don't appear in the configuration menu, it means the config file was not edited correctly.

That FAQ is missing out on one key part, you need to edit TQVaultAE as well as TQVaultAE.config then itll show, so its fixed now, got it to work

Glad you got it working.
I'll review the documentation.


Is there a performance difference between the JS versions and C++ / C# versions of coding of sdk's such as ink?

I noticed that the js sample for ink had a different performance than the c++ version.  The c++ version was smooth and glided naturally... where the js version was rough until it fully rendered as if it were smoothing over after it was fully rendered
wanted to temper the expectation

I've forwarded your question to the feature team.

Great question, and there is a big difference. The "SimpleInk" sample demonstrating Windows Ink in C++ leverages DirectInk and Direct2D to render smooth strokes in Windows natively. These libraries are highly optimized for ink stroke modeling and rendering, and include ink acceleration features that provide very low latency for end-users.
The "Ink" sample is a separate sample that demonstrates basic DirectInk usage in js (InkManager). We don't yet expose our native Direct2D stroke rendering to js; instead this sample is using the web standard CanvasRenderingContext2D methods to render the ink strokes, which accounts for the difference you're seeing. In particular, you'll notice that on pointer updates we simply use moveTo for "wet ink", and on pointer up we use bezierCurveTo for "dry ink" which results in a better looking stroke on lift.
Are you looking to build an inking web application? Please reach out to directink at microsoft dot com and we can provide advice on how you can best render ink today in a web context.


sandbox deploy - app registration failed - splash screen image cannot be located

DEP0700: Registration of the app failed. [0x80073CF6] AppxManifest.xml(34,27): error 0x80070002: Cannot install or update package 230e07b0-ebc2-4fde-9ac8-074d5c3269b3_9zz4h110yvjzm because the splash screen image [splashSplashScreen.png] cannot be located. Verify that the package contains an image that can be used as a splash screen for the application, and that the package manifest points to the correct location in the package where this splash screen image can be found.	Sandbox
I'm just trying to launch Sandbox on windows under VS, as part of DrawnUI sln. I'll figure out how to skip this.

That's a known MAUI bug, unfortunately, happens randomly when the whole wasn't properly restored.

Ahh. Okay, good to know. I thought deleting bin and obj of Sandbox would be good enough.
FYI, after deleting all bin and objs from all projects, this time it successfully deployed.
I'll keep in mind to run "dotnet restore" if I run into this again.

Yeah there is a nice PS script for that to avoid manually searching for bin obj: https://github.com/taublast/DrawnUi.Maui/blob/main/src/DeleteBinObj.ps1


Fix build

Add new verilator deps
Comment out docs copy, due to dir not existing

Thank you for the PR, just successfully tested a build cycle with the update master branches


.toDisk adds another row of columns to the output file.

For example: The input file looks like this:
name,status,url
A,B,C

After reading this as an array of objects, it becomes this:
[
  {
    name: A,
    status: B,
    url: C
  }
]

But after using .toDisk it becomes:
name,status,url
name,status,url
A,B,C

It seems there was some issue with my code. I have no idea what fixed this.


HELP

Does this issue occur when all extensions are disabled?: Yes

Version: 1.67.1 (user setup)
Commit: da15b6fd3ef856477bf6f4fb29ba1b7af717770d
Date: 2022-05-06T12:37:03.389Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19043
Steps to Reproduce:
Everytime I open vscode i get this error:

i don't know why the only way to get it to go away is to hit cancel multiple times

Can you uninstall VS Code and reinstall it?

You won't lose any settings or extensions.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Bad URL on api/server/README.md

The link "This is a reference implementation of the Grafeas API Spec" (https://github.com/Grafeas/Grafeas/blob/master/README) is not found. This link can be found on the following document: https://github.com/grafeas/grafeas/blob/master/samples/server/go-server/api/server/README.md
Apologies for not submitting a pull request to fix the issue, I am too unfamiliar with the project, but hope to soon be more familiar :)

Thanks for reporting this. Pull request #123 fixes this...


Staging next

Motivation for this change
https://hydra.nixos.org/jobset/nixpkgs/staging-next
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/84660 should probably be included in this.

There are apparently some python regressions that break e.g. nixops.  One way might be to migrate anything important away from python2 anyway...

Probably best to drop nixops in Nixpkgs since it's changed quite a bit upstream cc @adisbladis @GrahamcOfBorg

I fixed it somehow in 312e903; feel free to improve.

@FRidh A new release of NixOps is still pretty far away, in the mean time we need the current release.
If you'd like I can try to repackage the current release using Poetry/poetry2nix so NixOps won't be blocking any progression in pythonPackages?

I fixed the build of pyopenssl which was blocking it, so nixops builds now and I don't expect you need to hurry with anything.

I could neet some help with #85668. Both parent commits of this merge commit work fine, but waybar built from the merge commit does not (starts up fine but doesn't show the bar). Any idea what could cause this?


Improve Documentation

A number of features have been added to Criterion.rs in recent versions, but the documentation (both the user guide and the rustdoc comments) have lagged behind.
In particular:

Baselines are not yet mentioned in the user guide.
Throughput measurements are not yet mentioned in the user guide (see also #151).
The rustdoc comments only show a general guide to the usage and expect the reader to fill-in-the-blanks. They should be clarified and/or expanded (see also #151).

The documentation should be expanded to cover these features (and other important ones not listed, if any).

The documentation should also offer users guidance on the warning that newer versions of Cargo give about [[bench]] sections in the Cargo.toml.


make density test work on non-default TP

This PR fixes the issue that density test fails when the test tenant does not belong to the default TP.
Verification:
Combining this PR with https://github.com/CentaurusInfra/arktos/pull/902 and https://github.com/CentaurusInfra/arktos/pull/897, a test cluster with 3 TPs and 1 RP was created. Density tests succeeded for each of the following three tenants:

arktos ( home TP: TP1)
memphis ( home TP: TP2)
zeta (home TP: TP3)

/assign @XiaoningDing

/assign @yb01

/assign @pdgetrf

/approve

/lgtm


-c by default

Please add an option for no color by default

Added option to use configuration file in https://github.com/dundee/gdu/commit/22398bb067acb93e2f8e630abe9d4b8b7d0a165b.
So you can now run: echo "no-color: true" > ~/.gdu.yaml and you will have gdu without colors.

@dundee Can the config go into .config directory?

@dundee
Why do I get the message that there is no such flag?

Oh, my bad. I refactored it to not use viper lib and forgot to add this flag manually.

Fixed in https://github.com/dundee/gdu/commit/3b55796fbcb7d1a45f1cc3e6750645751268c063


✨issue #274 solved✨

resolved the following things :

added home btn to login/signup page
addes security to signup page by making sure null entries dont count.
fixed the footer of features page and home page.

https://github.com/user-attachments/assets/4b0afcb6-7f05-4850-a5c7-4c40e184db0a
@mansiruhil13 please review.

returning to home page, you make symbol "home", instead you can use symbol of home

ok ill do that


i18n(fr): update guides/routing.mdx

Description (required)

Translate first/last pages documentation (see #9215)

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

fr
guides/routing.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Just a new PR to fix highlight
https://github.com/withastro/docs/pull/9232


Failures on [cfe] Lookup representation field using ExtensionTypeDeclaration.procedures

There are new test failures on [cfe] Lookup representation field using ExtensionTypeDeclaration.procedures.
The tests
pkg/front_end/test/fasta/strong/extension_types/inherited_representation_field Fail (expected Pass)
pkg/front_end/test/fasta/weak/extension_types/inherited_representation_field Fail (expected Pass)

are failing on configurations
cfe-unittest-asserts-release-linux

The semi-fuzzing result seem unstable.


JAMES-3887 MailboxManager::createMailboxReactive should subscribe par…

…ent mailboes it creates

https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1752/1/testReport/junit/org.apache.james.mailbox.inmemory.listener/MailboxSubscriptionListenerTest/shouldNotPropagateUnsubscriptionToNonChildrenMailboxes/
Related


Update CLI to be comptabile with mbed-os logging

Unified logging in mbed-os provides logging API;s compatible with mbed_trace library. But features like filtering is not supported in similar manner as runtime option.
Changes in this PR are to disable trace logging at compile time, which was earlier done runtime at https://github.com/ARMmbed/mbed-client-cli/blob/master/source/ns_cmdline.c#L266
This fix is required for CI success in https://github.com/ARMmbed/mbed-os/pull/5965
CC @sg- @SenRamakri @SeppoTakalo

Updated the defines and rebased the code

I will revert back my commit, which was to show how sync can be done with mbed-os logging library. Its not needed till logging library support is added to master.


Update azure-kubernetes-service-cluster-backup-concept.md

Edit line 67 for accuracy, ASK -> AKS

@reigntastic - Thanks for the typo fix!


setTankData is not setting and returning the correct elevation

Adding tests to NetworkNode.ts I noticed that setTankData isn't returning elevation as I would have expected.
The below test is failing for elevation. Will need to confirm what is going on.
Noticed that changing to imperial units makes things off by a factor of 10, while in metric returns comes back as 3.048

    test('set and get tank values', () => {
      const model = new Project(ws);
      model.init('report6.rpt', 'out6.bin', FlowUnits.LPS, HeadLossType.HW);

      //Create Network
      const tankId = model.addNode('N1', NodeType.Tank);

      model.setTankData(tankId, 10, 1, 0, 5, 3.2, 1, '');

      const elevation = model.getNodeValue(tankId, NodeProperty.Elevation);
      const minLevel = model.getNodeValue(tankId, NodeProperty.MinLevel);
      const maxLevel = model.getNodeValue(tankId, NodeProperty.MaxLevel);
      const tankDiam = model.getNodeValue(tankId, NodeProperty.TankDiam);
      const minVolume = model.getNodeValue(tankId, NodeProperty.MinVolume);

      expect(elevation).toEqual(10);
      expect(minLevel).toEqual(0);
      expect(maxLevel).toEqual(5);
      expect(tankDiam).toEqual(3.2);
      expect(minVolume).toEqual(1);
    });

 ✕ set and get tank values (5ms)

   Epanet Network Node Functions › Impliment Methods › set and get tank values

    expect(received).toEqual(expected) // deep equality

    Expected: 10
    Received: 3.048

bug due to internal workings of the owa toolkit.issue resolved solved!

Thanks @cdzuwa for letting me know! I didn't get a chance to dive into this but good to know it was fixed upstream.
At this stage, I'm going to keep epanet-js locked to public release so not sure if I'll do a hotfix on my library until 2.3 or something else.
Going to jump back into this library soon and try to get test coverage up.

You're doing a great job.Nice piece of software


PECL for multiple PHP versions

Q
A

New Feature
yes/no

Description
With #19 we add pre-install script support which can use pecl to install extensions which are not pre-compiled with this action.
I've used Ondřej example from here to set alternatives for php-config and phpize.
To do so, the docker container has to provide php-dev for all PHP versions aswell.

Should I add some more details to the README?

Should I add some more details to the README?

Yes, please - demonstrate a pre-install script and how it can be used to install an extension via pecl.
At some point, we may need to consider adding caching capabilities...


Add wrap constructor to V1/V2 StakeCredential

I'm not entirely sure if this is the right approach, but I wanted to suggest a potential solution to the missing constructor when a V1/V2 validator Purpose is of the Rewarding type. In such cases, the StakingCredential type must be wrapped in a StakingHash constructor as per the Plutus Ledger API for V1/V2:
Previous Aiken versions used to encode the StakeCredential as follows:
121([_ 122([_ h\'524A8B6C686BF0C225C8BC8EB63100BDF1047A35599626878EDF3BFE\'])])
For V3, however, this extra constructor in the Rewarding Purpose is not required , which seems to be correctly reflected in the latest Aiken version:
I'd also suggest renaming StakeCredential to Credential, as the current name can be misleading.
pub enum StakeCredential {
    AddrKeyhash(AddrKeyhash),
    Scripthash(Scripthash),
}

Duh, that's an oversight as you can see it's being done in every other places. And since we got rid of the acceptance tests for V2 recently, this has slipped through the cracks 😬 ...
Thanks.


UnityCam doesn't show up as a webcam in Unity

When running a scene / compile app using UnityCam, I can see its output in some programs like Skype, but not in others like OBS and most importantly, Unity itself! Is it using a different method than the kind Unity is looking for?

About not being played in Unity, thats true and its also applied to some other softwares as you mentioned.
I guess you are using WebCamTexture to load the device, however unity doesn't accept virtual webcameras as a video source. I am still investigating the reason, and any other help from the community would be highly appreciated.

The virtual camera from XSplit is supported.

I have double checked the issue and found what was causing the issue,
The filter was not added to the registry. I did a quick fix to the code in DllRegisterServer() so the issue got resolved.
Unity now can detect the virtual camera using WebCamTexture:
foreach (var d in WebCamTexture.devices)
Debug.Log (d.name);
int index=0;// change to camera index appeared Debug window
tex = new WebCamTexture (WebCamTexture.devices [index].name,1280,720);
tex.Play ();

Oh, awesome! Thank you!
On Sat, May 13, 2017, 7:19 AM mrayy<EMAIL_ADDRESS>wrote:

I have double checked the issue and found what was causing the issue,
The filter was not added to the registry. I did a quick fix to the code in
DllRegisterServer() so the issue got resolved.
Unity now can detect the virtual camera using WebCamTexture:
foreach (var d in WebCamTexture.devices)
Debug.Log (d.name);
int index=0;// change to camera index appeared Debug window
tex = new WebCamTexture (WebCamTexture.devices [index].name,1280,720);
tex.Play ();
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mrayy/UnityCam/issues/2#issuecomment-301251227, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAtCYAelQXQ-rGsstMUXFa_QQGrIFpMbks5r5bv5gaJpZM4MvAlR
.


Article body text

Looks very cramped, try to space out for readability.

Changed line-height to ensure spacing for lines within body paragraphs.


Add text highlighting what optimisation is

Add some paragraphs explaining what optimisation algorithms are and how we use them in deep learning.
Resolves #9

Great changes, LGTM!


Plugin Update Instructions

Our VR tutorial has a line like this:

Make sure you have the latest version of Cesium for Unreal. To find the updater, open the Epic Games Launcher and go to the Library tab. Below the version of Unreal that you are using for this tutorial, click Installed Plugins.

@argallegos suggested that we should have info about updating the plugin somewhere in our documentation (in a guide and/or FAQ).

Thanks for making this issue, @getinthedamnbox. It's not too complicated to update the plugin, and we don't necessarily need a whole page for it, but it may be good to bundle in to the FAQ (https://github.com/CesiumGS/cesium-unreal/issues/550) or perhaps on another page.
The guide should probably include:

How to know if you need to update the plugin
Updating the plugin through the Epic launcher
Possibly updating the plugin if using it through git - not sure if this is covered already in another guide, but if not we should have instructions somewhere
Updating Cesium for Unreal Samples (You can't really update them like you would a plugin, you have to make a new project as far as I know, but should still have steps for it)

Now complete - Has been bundled in with #550


[Breadcrumbs] Add component

Add Breadcrumbs component, hiding complexity of inner nested components.
See for reference: https://material-ui.com/components/breadcrumbs/
Developers will pass one array property containing objects, where each object represent one breadcrumb (label, url), and one onClick property that will be called when a breadcrumb is clicked.
All breadcrumbs except last one will be clickable.

:tada: This issue has been resolved in version 8.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Roles/Permission Inheritance

So the example uses $myPath = '/blog_admin/blog_editor/blog_writer/blog_member'; Does blog_admin inherit the permissions from each role below it? Also how does inheritance work with permissions, is it recommended to use inheritance for permissions?
I was thinking of having permissions based on the URL path, so something like  'news/view', 'news/create', 'news/edit', 'news/delete', 'news/publish', 'news/delete'

member would only have permission to view
writer could view, create, and edit (obviously only theirs, but that's separate),
editor could view, create, edit, publish and delete
admin would have all that and more

I'm relatively new to using RBAC so please bear with me. :)

Think of it as a hierarchy of permissions rather than inheritance.
For example "/door/vault_door" and "/door/office_door". door is the parent permission, and if someone has it, s/he has all the child permissions as well. That is less confusing.
Yes, the major purpose of this library is to use permission hierarchy. Role hierarhcy has meaning, but permission hierarchy has even more meaning!
In your example, you have to establish the relationship between those permissions yourself rather than in the hiararchy. Write can not necessarily view, but in your system can. So you can force "view or write" on view. Admin will just have the root permission.
Or you can give write the whole "news" permission, that would be more structured.

On Mar 10, 2017, at 12:26 PM, Knight-Yoshi<EMAIL_ADDRESS>wrote:
So the example uses $myPath = '/blog_admin/blog_editor/blog_writer/blog_member'; Does blog_admin inherit the permissions from each role below it? Also how does inheritance work with permissions, is it recommended to use inheritance for permissions?
I was thinking of having permissions based on the URL path, so something like 'news/view', 'news/create', 'news/edit', 'news/delete', 'news/publish', 'news/delete'
member would only have permission to view
writer could view, create, and edit (obviously only theirs, but that's separate),
editor could view, create, edit, publish and delete
admin would have all that and more
I'm relatively new to using RBAC so please bear with me. :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/OWASP/rbac/issues/93, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVjW1a8dLvDsfeUmcLaAC_6SWAmNN-mks5rkYeygaJpZM4MZpmC.


auro-eslint-config: explore adding eslint-plugin-lit-a11y

User story
As a developer, I want to be warned of a11y issues as I'm developing my component, so that I don't ship an inaccessible component.
There is an eslint plugin to lint lit-html templates for a11y issues. We should explore adding it to the standard eslint config.
Steps

add plugin to eslint config
see what kinds of issues it detects (maybe with existing components)

:tada: This issue has been resolved in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


On Android OpenFile seems to crash

Using v1.2.1 Compiling against Oreo
On Android OpenFile seems to crash. My app freezes. No exception is thrown.  I have tried opening jpg, pdf, txt files. I pass in a file name, a func to return the stream, and blank path.  From looking in the code passing a blank path should cause OpenFile to call SaveFile to save the file in the platform appropriate path.
I am guessing this has to do with trying to pass a file with Intent on SDK >= 24.
https://inthecheesefactory.com/blog/how-to-share-access-to-file-with-fileprovider-on-android-nougat/en
This link mentions the need to use FileProvider in SDK >= 24.
Using Xamarin's Device.OpenUri method I get the error "file:///storage/emulated/0/tmp6e4aa988.png exposed beyond app through Intent.getData()"

I know version 1.2.1 is bugged, I will take 2.0 out of beta soon.
1.2.1 is just the version taken from the original repo and has a lot of problems. Did you try if this is still current in the latest pre-release?

@jfversluis  I also have a fix for Android.OS.Build.VERSION.SdkInt >= Android.OS.BuildVersionCodes.N using FileProvider to create the uri to fix the  error:

exposed beyond app through Intent.getData()

I will submit a pull request after more testing.
Thanks

I will gladly look at a PR that you have in the workings


md-card NgModule is not a function

Bug, feature request, or proposal:
Bug (?)
Version: @angular2-material/card": "^2.0.0-alpha.7
Angular version: RC4 (but tested with RC5 also)
Case is is simple from angular2-material options card is the one that simply cannot work in my case. It is install and accessible through systemJs and the usage is this:
Component:
import { Component, OnInit, Input } from '@angular/core';
import { MenuItems } from '../../../models';
import { MD_CARD_DIRECTIVES } from '@angular2-material/card';

@Component({
  moduleId: module.id,
  selector: 'big-icons-vertical-menu',
  templateUrl: 'big-icons-vertical-menu.component.html',
  styleUrls: ['big-icons-vertical-menu.component.css'],
  directives: [MD_CARD_DIRECTIVES]
})
export class BigIconsVerticalMenuComponent implements OnInit {

  @Input() items: MenuItems;

  constructor() { }

  ngOnInit() {
  }

}

Template (well even if there is no template the issue is the same).
<md-card class="text-center detail-menu">
  <md-card-content>
    Text here
  </md-card-content>
</md-card>

When the app runs and i use the component I get:

zone.js:461 Unhandled Promise rejection: TypeError: core_1.NgModule is not a function
at eval (http://localhost:4200/vendor/@angular2-material/core/ripple/ripple.js:168:16)
at Object.eval (http://localhost:4200/vendor/@angular2-material/core/ripple/ripple.js:175:2)
at eval (http://localhost:4200/vendor/@angular2-material/core/ripple/ripple.js:178:4)
at eval (http://localhost:4200/vendor/@angular2-material/core/ripple/ripple.js:179:3)
Evaluating<EMAIL_ADDRESS>Evaluating<EMAIL_ADDRESS>Evaluating http://localhost:4200/app/top-bar/top-bar.component.js
Evaluating http://localhost:4200/app/top-bar/index.js
Evaluating http://localhost:4200/app/shared/index.js
Evaluating http://localhost:4200/app/routes.js
Evaluating http://localhost:4200/main.js
Error loading http://localhost:4200/main.js ; Zone:  ; Task: Promise.then ; Value: Error: TypeError: core_1.NgModule is not a function(…)consoleError @ zone.js:461_loop_1 @ zone.js:490drainMicroTaskQueue @ zone.js:494ZoneTask.invoke @ zone.js:426
zone.js:463 Error: Uncaught (in promise): Error: TypeError: core_1.NgModule is not a function(…)consoleError @ zone.js:463_loop_1 @ zone.js:490drainMicroTaskQueue @ zone.js:494ZoneTask.invoke @ zone.js:426

Maybe there is a relation here with #954 but I cannot add my issue there as it is locked for collaborators only.

I met this issue,too.

@xinfangke you solved it somehow though?

@vapits  package.json
    "@angular/common": "2.0.0-rc.5",     "@angular/compiler": "2.0.0-rc.5",     "@angular/core": "2.0.0-rc.5",     "@angular/forms": "0.3.0",     "@angular/http": "2.0.0-rc.5",     "@angular/platform-browser": "2.0.0-rc.5",     "@angular/platform-browser-dynamic": "2.0.0-rc.5",     "@angular/router": "3.0.0-rc.1",

Yes I did it also and still wrong.

Did you try just using the git version of angular? Look at Material's package.json and try using the same git package version.

@bennycooly I'm not sure what you mean/ Same version of card and core for example? Or you mean something else?

Ah okay nevermind...when I checked yesterday Material was still using the git version of Angular but I see that they published RC5 now. I was compiling manually but I'll try using Material Alpha7 and Angular RC5.

Sure. If you manage to solve this please share your experience plz.

Look at the breaking changes for RC5, especially under "Bootstrapping". Once you refactor your main.ts and app.component.ts to use NgModule, it should work.

Closing as this should all be fine in alpha.7

@jelbourn it is not working in alpha.7

Try blowing away your node_modules. It sounds like your @angular is stale.

I thought that was it at first place but it is not. alpha.7 (card or tabs or anything) is simply not working neither on RC4 or RC5.

I've updated my material2-app to use alpha.7 and RC5 with everything working. Looking at that might help debug your issue.

@jelbourn as it is a new clean app it is working for me also.
If I follow exactly the same approach I'm getting as many as my tests error messages when I'm trying to compile the app like:

Livereload server on http://localhost:49152
Serving on http://localhost:4200/
The Broccoli Plugin: [BroccoliTypeScriptCompiler] failed with:
Error: Typescript found the following errors:
/Projects/WebApp/tmp/broccoli_type_script_compiler-input_base_path-ZIaFMlDP.tmp/0/src/app/+login/beta-stats/beta-stats.component.spec.ts (7, 3): Module '"/Projects/WebApp/node_modules/@angular/core/testing"' has no exported mng 'beforeEach'.
/Projects/WebApp/tmp/broccoli_type_script_compiler-input_base_path-ZIaFMlDP.tmp/0/src/app/+login/beta-stats/beta-stats.component.spec.ts (7, 15): Module '"/Projects/WebApp/node_modules/@angular/core/testing"' has no exported mng 'beforeEachProviders'.
/Projects/WebApp/tmp/broccoli_type_script_compiler-input_base_path-ZIaFMlDP.tmp/0/src/app/+login/beta-stats/beta-stats.component.spec.ts (8, 3): Module '"/Projects/WebApp/node_modules/@angular/core/testing"' has no exported mng 'describe'.
/Projects/WebApp/tmp/broccoli_type_script_compiler-input_base_path-ZIaFMlDP.tmp/0/src/app/+login/beta-stats/beta-stats.component.spec.ts (8, 13): Module '"/Projects/WebApp/node_modules/@angular/core/testing"' has no exported mng 'xdescribe'.
/Projects/WebApp/tmp/broccoli_type_script_compiler-input_base_path-ZIaFMlDP.tmp/0/src/app/+login/beta-stats/beta-stats.component.spec.ts (9, 3): Module '"/Projects/WebApp/node_modules/@angular/core/testing"' has no exported mng 'expect'....

Never mind, I moved to WebPack and it seems that there things are better. thx.

I am having the same issue using md-progress-circle using RC2.
Is there a way I can make angular material work with RC2?


pre-install common modules

related to https://github.com/shogo82148/actions-setup-perl/issues/416

we have EXCEPTION_ACCESS_VIOLATION with Perl 5.12.x
It seems related to https://github.com/shogo82148/actions-setup-perl/issues/225, but I don't any idea to solve it...


Some data were not uploaded to the S3 when the num of partition  > 7

What happened?

Several of the partition data were not uploaded to the S3 when the partition num of topic > 7
What did you expect to happen?
All partition data was successfully uploaded to the S3
What else do we need to know?
diff of two paritions as follow

The tieredTopic01173-13 partition had not logs like "Copied<PHONE_NUMBER>0000000000.log...."  found

@freshtang thanks for reporting this issue.
I can see you have a topic with 14 partitions.
Could you confirm if the partitions you highlight have more than one segment? If only one (active) segment, then there's no candidate segments to upload.
You could also expose JMX metrics and validate if there's any error when copying segments (MBean: kafka.server:type=BrokerTopicMetrics,name=RemoteCopyErrorsPerSec)

@jeqo I have set the prop of segment.bytes =100MB，so the partitions  have more than one segment
I encountered this issue in the Kafka 3.6.1，but it did not appear in the Kafka 3.6.2-SNAPSHOT

@freshtang thanks for the context.
Can't find any commit upstream that may be fixing this since 3.6.1.
Could you provide more info on the topic configuration (retention, etc.) and broker configs, and scripts to try to reproduce it?
You could use the demo: https://github.com/Aiven-Open/tiered-storage-for-apache-kafka/tree/main/demo as baseline if it helps.
Also relevant to mention that we haven't yet fully test against KRaft--could you also try to reproduce against a Zookeeper based cluster?

@freshtang we have similar behavior in other users. If this issue persists on your side, could you use the API timeout configuration for S3? (s3.api.call.timeout and s3.api.call.attempt.timeout)
By default these are empty. My guess is that S3 operations are getting stuck and without a timeout they just hung indefinitely blocking the uploads for the partition assigned.

@jeqo I tried to reproduce with a Zookeeper based cluste and API timeout configuration(s3.api.call.timeout and s3.api.call.attempt.timeout), but the problem still exists


Smart form component form documentation not working

The smart form component from the documentation is not working: https://codesandbox.io/s/react-hook-form-smart-form-component-eqb3n
In the Form it does not like ...methods. It yields object is not a function.
Also; how do you write the Form component in typescript? It does not accept props on child object.

thanks @mr-bjerre codesandbox have been fixed, will update the website as well.

https://react-hook-form.com/api#TypeScript

I haven't tried to write that form component in typescript. it may be a bit tricky to write that

Yeh I figured. It would also be pretty cool to embed validation rules into the setup. I guess it could go into either the Form as props or the individual UI components.
And thanks a bunch for a great library (and extremely quick response)

yeah, that's the pattern I have set up at work, but we are not using typescript, so I have bit extra freedom there :) it did work out pretty well with the help from form context. Basically any inputs sit under SmartForm data and validation will apply directly, for something bit more complicated we use FormContext to solve them individually. (https://react-hook-form.com/advanced-usage#ConnectForm)

going to close it here for fixing the website :) in terms of typescript for smart form hopefully someone can figure out a solution :) it's sitting in the spectrum as well

Do you mind opening this again?
I'd love to have a typescript version of the smart form.

Sure, let's see if community can help out this one. I will attach a help tag.

Cool.
I also noted that input elements like <input /> has to be an immediate child of <Form>. You can't have them nested.

That's correct. for deep nest consider to use ConnectForm, which is in the doc as well

(cleaning up issues) This issue is getting really "old", i am going to close this issue, but feel free to leave your answer here.

import React, { createElement, ReactElement } from "react";
import { DeepPartial, OnSubmit, useForm } from "react-hook-form";

interface IFormProps<T> {
  defaultValues?: DeepPartial<T>;
  onSubmit: OnSubmit<T>;
}

export function Form<T>({
  defaultValues,
  children,
  onSubmit
}: IFormProps<T> & { children: ReactElement | ReactElement[] }) {
  const { register, handleSubmit } = useForm<T>({ defaultValues });

  return (
    <form onSubmit={handleSubmit(onSubmit)}>
      {Array.isArray(children)
        ? children.map(child => {
            return child.props.name
              ? createElement(child.type, {
                  ...{
                    ...child.props,
                    register,
                    key: child.props.name
                  }
                })
              : child;
          })
        : children}
    </form>
  );
}

I was able to make use of the smart form in TypeScript using this, the usage is as follows:
Input (I'm using a UI Component library for this)
import { Input as ChakraInput, InputProps } from "@chakra-ui/core";
import React from "react";
import { FormContextValues } from "react-hook-form";

interface IInputProps {
  register: FormContextValues["register"];
  name: string;
}

export const Input = ({
  register,
  name,
  ...props
}: Partial<IInputProps & InputProps<HTMLInputElement>>) => (
  <ChakraInput name={name} ref={register} {...props} />
);

Form setup (passing in the generic gives Type safety for defaultValues)
interface UserGuildInput {
  prefix: string
}

<Form<UserGuildInput>
  defaultValues={{ prefix: data.guild.prefix }}
  onSubmit={onSubmit}
>
  <Input name="prefix" />
  <Input name="language" />

  <button type="submit">submit</button>
</Form>

I'm not too experienced with TypeScript so input is welcome :)

hey @pandaniell this is really awesome. would be able to create a TS codesandbox with this, i can link this into our website.

import { FormContextValues } from "react-hook-form";

Hey @pandaniell / @bluebill1049 I wasn't able to get this line working. How can I fix it? I'm using the lasted version of the lib.

import { FormContextValues } from "react-hook-form";

...
  register: FormContextValues["register"];
...

Hey @pandaniell / @bluebill1049 I wasn't able to get this line working. How can I fix it? I'm using the lasted version of the lib.

https://react-hook-form.com/ts#UseFormMethods

Just want to point out that the smart Form component doesn't work if you have an element that doesn't contain the prop "name" or any prop at all inside of the Form component, as it will throw an error like this:

To make it possible I change the code to check the type of the component inside of the form component by creating a simple method "childIsAFormComponent", like this:
import React from 'react'
import { useForm } from 'react-hook-form'

const Form = ({ defaultValues, children, onSubmit }) => {
  const methods = useForm({ defaultValues })
  const { handleSubmit } = methods

  const childIsAFormComponent = (NameOfComponent) => {
    if (
      NameOfComponent === 'Input' ||
      NameOfComponent === 'Select' ||
      NameOfComponent === 'TextArea' ||
      NameOfComponent === 'Checkbox'
    ) {
      return true
    }
    return false
  }

  return (
    <form onSubmit={handleSubmit(onSubmit)}>
      {React.Children.map(children, (child) =>
        childIsAFormComponent(child?.type?.name)
          ? React.createElement(child.type, {
              ...{
                ...child.props,
                register: methods.register,
                key: child.props.name
              }
            })
          : child
      )}
    </form>
  )
}

export default Form

With this solutions you still need the input elements to be a direct child, but you can have other components in it as well (like divs and buttons), like this:
<Form onSubmit={onSubmit}>
  <Input name="firstName" />
  <Input name="lastName" />
  <Select name="gender" options={["female", "male", "other"]} />

    Some cool stuff here ...

  <button type="submit">Submit</button>
</Form>

Suggestions for improving this are welcome.


Bug: No signing request/pop-up shown

Context
After a page refresh, no signing request is shown for the user. Tested on an Android phone using Chrome browser.
The page reloaded due to a recoverable error (the signer service was not available locally) and after I fixed that, the process reached the signing stage but no signing was requested nor any error shown.
However, there is a warning
'Navigation is blocked: wc:9c5dad9dbeb4eb6bbe40808d1899ed17db016bfec3bd042b9fdeb365e29136bd@2/wc?requestId=1730988197737568&sessionTopic=9abe69febffb3628afea0eecc23779de1e4c55e8ac474a8d3d4577a8df734db9'.

My flow was: Start the offramping process by clicking on the 'Confirm' button. Metamask opens and asks me to switch the network to polygon (this is expected and worked like a charm). I am back on Vortex but the process cannot continue because the signer-service is unavailable. The app starts reloading the page every 30 seconds. I make sure the signer-service is available again. I fill in the details with Mykobo and get back to the App. The signing-dialog shows after a brief delay but I don't get any notification/pop-up to open Metamask or similar.

After waiting for ~5 minutes, the app moved to the failure stage because the request expired.

TODO

Investigate the Navigation is blocked warning. This indicates that the request for signing sent by vortex via the WalletConnect implementation in rainbowkit/wagmi was blocked by the browser.

@ebma I was not able to replicate this error or my mobile.
I tried refreshing before the request (as your experiment) and after it, and for both I see the pop-up to change to Metamask. Tried many times.
I am testing in a preview with our current code. Any ideas? My plan was to first replicate the error, then try appkit to see if it solved the issue.

Hmm okay, interesting. To be fair, I think when testing stuff with rainbowkit on my phone I also never saw the exact warning 'Navigation is blocked: ...' again. So this is probably not very easy to reproduce. Has to be an edge case. One might assume that it's related to browser settings but as I also didn't really see it happen afterward, this also doesn't make too much sense.
If neither you and me are able to reproduce this issue, let's maybe close this as not planned/wont-fix and re-open the ticket if it happens again.

So you saw it only once? Or was it reported. Interesting.
But yeah, I agree we close this for now and open it if happens more times. There is not much we can do if we can't reproduce it.


Excise Rule Filters for Constants and Duplicate Variables from the Rule Model

Technical Debt from #62.
Support for constants and duplicate variables is currently implemented using filters in a very hacky way in the execution engine.
I did not look into the code in detail yet so I cannot make an informed proposal on how to improve this.
Maybe @aannleax has ideas on this already?

I wonder if this issue is obsolete by now or at least dominated by other efforts regarding changes in the rule representation.

At least for the rule model, we want to stay true to the original input, so rewritings like getting rid of duplicate variables should not happen there yet.

This will be released in 0.4.0 now, right?


[BUG] Cannot join game through website via Bloxstrap

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

What problem did you encounter?
Upon auto-updating to the latest version of Bloxstrap (2.8.0), I can no longer directly join games through the website. Attempting to do so simply opens Bloxstrap's menu; from there, I can still select Launch Roblox, but this just brings me into the Roblox app's home (which I don't want).
Steps to reproduce:

In your browser, set roblox and roblox-player links to execute using Bloxstrap.
On any game page, click either the green play button OR the Join button on any server.
The Bloxstrap menu will open. You will not be sent into a game server.
Click Launch Roblox.
Bloxstrap will apply the modifications as normal.
The Roblox app will open to the home page. You still will not be sent into a game server.

Not unplayable, but definitely inconvenient for someone like me who absolutely detests using the app for no reason in particular.
Bloxstrap Log
N/A

Can you send your log file?

Can do, I've got two of them.
Bloxstrap_20241016T181110Z.log - this one was generated first when the menu opened.
Bloxstrap_20241016T181117Z.log - generated when I selected Launch Roblox.
Bloxstrap was launched from a website join link for these; I did not manually join a game after selecting Launch Roblox, I simply closed the window.

I'm still not entirely clear on this, can you send a video of you attempting to launch from the website?

https://github.com/user-attachments/assets/7832cad6-ae3d-4e7e-a203-5096ff393be8
It'll launch Bloxstrap, it'll launch Roblox, but it won't actually join the game.

Can you open the Windows Registry Editor, go to HKEY_CURRENT_USER\SOFTWARE\Classes\roblox-player\shell\open\command, and show a screenshot of what the values shown there are?

Attempt a Roblox launch from the website again. Make sure you don't close it.
Then, open a PowerShell window and run this command:
Get-WmiObject Win32_Process -Filter "name = 'Bloxstrap.exe'" | Select-Object CommandLine

Send a screenshot to me of what you see privately (email me at pizzaboxer@proton.me), let me know here when you have.

Send a screenshot to me of what you see privately (email me at pizzaboxer@proton.me), let me know here when you have.

Went ahead and sent it; email made the image a bit small, might need to open it in a new tab.
It definitely looks like Bloxstrap is receiving the launch options, but... nothing happens.

This strangely seems like a Firefox issue, since it's not actually obeying the rules specified in the Registry. I'll come up with a workaround for this.

Really? That's especially strange; I've been using Firefox for a while and I've never had an issue like this with anything else, not even older versions of Bloxstrap.
Oh well.

What arguments is Bloxstrap launched with?

What arguments is Bloxstrap launched with?

It's acting as if it's "Bloxstrap.exe %1" - I'll add an exception in the launch settings parser for it

To get around this for the time being, use this prerelease version of 2.8.1: https://github.com/bloxstraplabs/bloxstrap/actions/runs/11526434565/artifacts/2106464097

not having this problem - even without the prerelease version
bit weird why some firefox users are having this problem and others aren't (i.e. me)...

To get around this for the time being, use this prerelease version of 2.8.1: https://github.com/bloxstraplabs/bloxstrap/actions/runs/11526434565/artifacts/2106464097

Prerelease seems to be working for the time being; will update if any issues crop up. Thank you!

Fixed in 2.8.1 - reopen if not


Homekit Automations with Wiz Plugin

I have been running into some weird HomeKit shortcut automations with button presses. I create a automation to check if the light is on or off and based on that it turns it on or off. The automations rarely have a issue with turning the wiz lights off but turning on they always time out. I can manually turn them on and off. I was wondering if you have run into this issue before?

No I have not, did you resolve this?


DEBUG TOOLBAR - fix INTERNAL_IPS discovery for docker

A simple fix for the INTERNAL_IPS when using DOCKER
Rationale
For users with multiple containers, the DEBUG TOOL BAR stops showing up if the django container receives an IP higher than 9, ex <IP_ADDRESS>, it becomes <IP_ADDRESS>, not complying with the INTERNAL_IPS requirement.
The actual code doesn't consider this scenario. This fix will work for all scenarios.
Use case(s) / visualization(s)
Users that has a stack with numerous containers

Thanks for the fix 🎉


EntityGrid: gridPersistanceFlags.quickSearch not working as expected

If you set the quickSearch flag to true in EntityGrid.getPersistanceFlags, the quick search criteria is not always persisted.
Steps to reproduce with Northwind sample:

Add protected gridPersistanceFlags(): Serenity.GridPersistanceFlags { return { quickSearch: true }; } to CustomerGrid.ts
Start sample
enter i.e. 'be' in quick search field of customer grid
go to another grid, i.e. products
go back to customer grid. Expected result: Quick filter is set to 'be', but it is not!
enter 'be' again, and make some change to the layout (i.e. change column order)
go to another grid, i.e. products
go back to customer grid. Expected result: Quick filter is set to 'be'. Now it is!
change the quick search criteria to something else
go to another grid, i.e. products
go back to customer grid. Quick filter is set back to 'be', not what you entered last!

-> it seems that a call to persistSettings() is missing after the quick search criteria was changed

There is a related issue when using EntityGrid.getQuickSearchFields. The column the user has selected for quicksearch is not always persisted.

Fixed 9e09829a768d7e6773f585acc11ff414ee2cc463


Attribute Style Manipulation

Hi, thank you for sharing the great project. I found your attribute style manipulation particularly meaningful and useful for my recent research. I saw from previous issue that you have no plan to open source the code for this part. I have the following questions:

I found nowhere in your paper as for how you derive your θ and the relationship between θ and the image, so how do you get the θ in an unsupervised way for each input?
Is this part's idea (and the way you derived θ) based on the paper 'Generative Attribute Controller with Conditional Filtered Generative Adversarial Networks'? (I found their code is also not open source).
If I want to realize this part myself, could you give me some hints of where to start or any papers and sources I could refer to (there is really very few works on accurate or multiple attribute style manipulation)?

Thank you!

@XijieJiao

I am not sure that I understand your question. Do you mean the relationship between theta and x^a? They are independent, and theta is randomly sampled from a categorical distribution.

Yes, this idea is inspired by CF-GAN.

You can start by reproducing CF-GAN on "Bangs" style of CelebA, it's easy, just use AC-GAN with conditional filter. Or you can read this repo, which is the implementation of DTLC-GAN (the next version of CF-GAN). But DTLC-GAN is more complicated on losses and conditional signals.

Hi, thank you. I am now referring to your DTLC-GAN code but found something confusing.

DTLC-GAN has no encoder, but a decoder and discriminator, right?
DTLC-GAN use two random vectors(z and c) as input and the images are only used in discriminator, so what should I do if I want to use a pretrained DTLC-GAN to generate results for an appointed image(generally speaking, how to run test for DTLC-GAN)?

Thank you.

@XijieJiao

Yes.

DTLC-GAN generates images from z and c, but not for appointed images. You can read the DTLC-GAN paper for more details. If you wish to deal with appointed images, you could incorporate the DTLC-GAN idea into an image-to-image method (e.g., AttGAN-style incorporates CFGAN into AttGAN).

Thank you.


util: Replace util.get_message_topic().

Replace util.get_message_topic(message) with message.topic.
fixes: #13931

Thanks for working on this!  Looks good overall but can you fix the typo in your commit message and add “Fixes #13931” at the bottom?  @timabbott quick reminder to check email for relevant blueslip errors before merging

We should also actually remove the function as part of the commit. 😔

@showell I had made the changes. Please review it.

I had also added a commit (3add38f) which replaces set_message_topic() function

It appears that 39405fccdc20dac9a0eefa499ceef807e01de369 has been deployed, so we're close to the final step here.

Merged, thanks @shubhamgupta2956!
@timabbott I checked blueslip errors on czo, and nothing showed up related to get_message_topic() over the last day or two.  It's not a huge sample size, but I'm fairly confident we've mostly cleaned subject references.  We should keep an eye out for any possible problems with topics that seem like they could potentially be related to finalizing the migration here.


feat(nats-connection): implement named executor thread factories

goodbye, "pool-2-thread-1"

@krzysiekigry So the idea is fine, but it needs to be done in an optional way, since someone might currently rely on that naming scheme in their existing application / logs.
In the Options Builder, you can call public Builder executor(ExecutorService executor), so maybe add these:
public Builder callbackExecutor(ExecutorService executor)
public Builder connectExecutor(ExecutorService executor)

With the defaults matching exactly the existing i.e. newSingleThreadExecutor()
And so starting at line 159 of NatsConnection, that block of code would look like this:
this.executor = options.getExecutor();
this.callbackRunner = options.getCallbackExecutor();
this.connectExecutor = options.getConnectExecutor();

Also, please sign your commits. Here is a good link to help with that: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Thanks for the suggestion, but I believe this approach works better. When NatsConnection shuts down, it terminates the executors. This can cause issues when attempting to create a new NatsConnection, as the executors would already be shut down. Please let me know if I’m mistaken.

Factory is a good idea.


ENH: partially vectorize components2list

with @fraimondo we figure that this removes one potential bottleneck.
Should create a linear scaling with graph components.
In out test case we improve by a factor of 17.
cc @agramfort @Eric89GXL

besides LGTM


MWPW-116989 -  Consonant card horizontal block

As an SEO marketer, I want multiple options for single action cards. [Card Horizontal, Card Horizontal (tile)] - *supports 1-3up
Resolves: MWPW-116989
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/sarchibeque/card-horizontal?martech=off
After: https://card-horizontal--milo--adobecom.hlx.page/drafts/sarchibeque/card-horizontal?martech=off

LGTM


Inviting users with phone number displays weird message on phone

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging dot on web chrome and login with User A
Create a new workspace and go to invite members
Invite a user that has phone number (it's compulsory), and on the message field , remove the current message and add your own message within quotation marks " " and also add signs like & , backtik ` and <
Check the message that may have arrived on your phone number that you invited before
Notice that quotation marks is displayed as &quot and looks weird in the message. Also the backtick, & and < are also shown weirdly

Expected Result:
Message while Inviting users with phone number doesn't display properly on the message that has arrived on phone
Actual Result:
Message while Inviting users with phone numbers should  be displayed properly
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.25-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/f94c7644-c038-4e87-bb2a-f90ade3f34c7

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685941205156389
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0108b7537c7a8d0d92
Upwork Job ID:<PHONE_NUMBER>016310784
Last Price Increase: 2023-06-14

Yes, this will have to be internal

Thanks @alex-mechler, guess you're the lucky one on assignment here then!

Reapplying the Bug label to get another BZ member on this while I am OOO til July 3. Thanks @NicMendonca,  I'll grab this back from you when I return!

Have not had a chance to dive into this, and am OOO friday-monday as a heads up here. I don't think this is urgent enough to warrent reassignment, but feel free to spin the wheel for another engineer if needed

@alex-mechler should this still be a daily?

🧇 I'm removing AlexM's assignment and triggering assignment of a new engineer

@cead22 let me know if I need to find someone else internally 👋

Quick investigation so far

I reproduced inviting my phone number to an expensifail.com workspace
Logs
AccountID #2211126 called 'InviteUsers' for policy '8F24C5EAEC6CADA3' message 'Test & " >' emailList<EMAIL_ADDRESS>It looks like we're HTML-encoding the message before make the api call, so we're sending the encoded message to the api. It's possible we need a front end fix as well

Processing 'AddMembersToWorkspace' for 'expensify.com' from '<IP_ADDRESS>' ~~
command: 'AddMembersToWorkspace'
employees<EMAIL_ADDRESS>welcomeNote: 'Test & " >'                      <---------------------------------------
policyID: '8F24C5EAEC6CADA3'
reportCreationData: '{"+14153166423@expensify.sms":{"reportID":"3871915553990080","reportActionID":"668730370059106033"}}'
appversion: '1.3.31-3'
pusherSocketID: '479922.296723'
authToken: '<REDACTED>'
referer: 'ecash'
platform: 'web'
api_setCookie: 'false'
email<EMAIL_ADDRESS>partnerName: 'expensify.com'
browserGUID: '64963360b5db0'
HTTP_CF_BOT_SCORE: '93'
HTTP_CF_JA3_HASH: '21374ef547fa5844c59fd5d2f4ffdbaf'

Looks like we intentionally html-escape here
https://github.com/Expensify/App/blob/820fa93ad1e799c12d8b639b98018b5350ea17af/src/libs/actions/Policy.js#L408-L409

@cead22 any update on this one?

Sorry, I don't have any updates for this yet, I've been kinda slammed. Ionatan posted a message today that makes me think that the solution I was thinking about might not be the right one, so I need to check with him on that before trying to code the solution

I think this is related to: https://github.com/Expensify/App/issues/20081
@cristipaval has a solution here: https://github.com/Expensify/Web-Expensify/pull/38012 but let's confirm this is actually the holistic solution we want.

I think this is related to: #20081
@cristipaval has a solution here: Expensify/Web-Expensify#38012 but let's confirm this is actually the holistic solution we want.

Yes, it seems to be a dupe of https://github.com/Expensify/App/issues/20081

Ah yep, I agree this is a dupe and is solved with https://github.com/Expensify/App/issues/20081. Gonna close this out but feel free to reopen if you disagree


Icons by class

At the moment, it is not possible to use a glyph font like font-awesome to replace your default icons, because you rely on background-image(...) in your angular-toastr.css. It would be nice if we could just define the classes in the definition object like this:
{
  icons: {
    warning: 'fa fa-warning',
    success: 'fa fa-check'
    ...
  }
}

I know, this can be done by creating a custom template, but I believe this functionality should be possible out of the box.
Please consider enabling icon fonts in this already awesome project. It would also enhance accessibility.

Sounds like a cool addition. I will add on my list of things to consider for 2.0.0.


Add location indicator dot to radar map

Suggestion to add a location indicator dot for the current location/weather location on the radar map, this would be useful when the entire map is full of "weather" to help pin point the original location, especially when moving or zooming the map around.
I'm not sure if Rainviewer would provide some type of transparency otherwise so we can see names or landmarks on the map?
Something like this for opacity/transparency:

I think it might be in https://github.com/Akylas/oss-weather/blob/78adcf94274a8ff106530a7feb77f76a1daf1db8/map/index.ts, setting opacity to 0.5 or 0.7?
Referenced from (https://github.com/rainviewer/rainviewer-api-example/blob/master/rainviewer-api-example.html):
maxZoom: 18,
pmIgnore: false,
opacity=0.5
Example without opacity (you can also test out different colour themes):
https://rainviewer.github.io/rainviewer-api-example/rainviewer-api-example.html
Example with opacity (0.5) adjustable through the little icon in the bottom right:
https://mwasil.github.io/Leaflet.Rainviewer/demo/

@0-5-0 it is released!

Location indicator looks great, opacity looks great :), thanks again lol


Colors look... off?

Here is what it looks like on my end:

After using a color picker I found out that the background color is #181821. As you may know the main background is black2 (#1E1E2E).

oh. I forgot to check if the previous PR had the correct colors before submitting a new one.
I will try to fix it today.


Ecto defines a type for prefix that conflicts with Ecto FoundationDB's use of tenants as prefixes

In Ecto.Schema,
@type prefix :: String.t() | nil

This isn't compatible with Ecto FoundationDB's use of tenants as the prefix.
The tenant is an opaque term ({erlfdb_tenant, reference()} under the hood) that corresponds to a resource allocated by the NIF via for example Tenant.open!.
This works fine for all of the implemented features so far during runtime. I suppose Ecto is not actually inspecting the prefix, and leaving it fully to the adapter implementations.
However, adding type specifications is impossible because dialyzer will correctly recognize the mismatched types between Ecto.Schema.prefix() and Tenant.t().
Workarounds to this may include ets, persistent_term, process dictionary, etc, but they are likely to be hacky and/or brittle.

I was forced to address this in commit 544bba9, where the :ecto_sql migration pipeline requires the prefix to be a string. Tenant.to_prefix and Tenant.from_prefix implement the encoding/decoding of the tenant.
However, this is pretty hacky. We're simply using term_to_binary and then shoving it into a Base16 string. I'll be on the lookout for a better way.


Update popup preventDefault behavior

Summary
Remove preventDefault prop on PopupContent. This was preventing events inside the popup content, where we just want to prevent events outside the popup content when it is open. This behavior should be handled by default with react-onclickoutside.

Need to cross-browser test / cross-device test this change.

It seems removing the preventDefault prop reintroduces the bug logged here. Clicking on the popup button results in the following error when the prop is removed.
index.js:186 [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/5093566007214080


Resuming PSK session options failing 3.0.0-beta1

This appears eerily similar to #7433, but for 3.0.0-beta1. Heck, the same error message is popping up! (Supposedly fixed in #7434).
Built openssl-3.0.0-beta1: ./config && make -sj
Built OpenSSL_1_1_1-stable: ./config && make -sj
Note that in 1.1.1-stable, the following sequence works:
I'm trying to do the same thing as #7433, create a session via PSK, and then re-use it.
Server (run once, and continues through test):
openssl s_client -psk<PHONE_NUMBER> -nocert

Client getting ticket:
openssl s_client -psk<PHONE_NUMBER> -sess_out mysession

Client using ticket:
openssl s_client -psk<PHONE_NUMBER> -sess_in mysession

Note: same behavior with or without the -psk option. I've tried various other psk options without success.
s_server error output:
PSK warning: client identity not what we expected (got '<garbage text>' expected 'Client_identity')
ERROR
C0113AB3757F0000:error:0A0000FD:SSL routines:tls_psk_do_binder:binder does not verify:ssl/statem/extensions.c:1603:
shutting down SSL
CONNECTION CLOSED

openssl s_client -psk<PHONE_NUMBER> -sess_in mysession error output:
CONNECTED(00000003)
C031B790BB7F0000:error:0A000417:SSL routines:ssl3_read_bytes:sslv3 alert illegal parameter:ssl/record/rec_layer_s3.c:1584:SSL alert number 47
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 7 bytes and written 660 bytes
Verification error: unspecified certificate verification error
---
New, TLSv1.3, Cipher is TLS_CHACHA20_POLY1305_SHA256
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
Early data was not sent
Verify return code: 1 (unspecified certificate verification error)
---

(Connection drops)
First off, am I doing this right? It seems to work fine in 1.1.1, but not in 3.0.0-beta1.

This issue does actually also impact 1.1.1 - but only if you additionally supply the option "-no_ticket" to the s_server command line.
The difference between the behaviour in master and 1.1.1 is due to 9c13b49a9f2, which changed PSK_MAX_IDENTITY_LEN from 128 to 256. It just so happens that a default OpenSSL TLSv1.3 ticket length happens to fall between those 2 values. Tickets are presented in TLSv1.3 as a PSK "identity". Passing "no_ticket" doesn't actually stop TLSv1.3 tickets completely, it just forces the use of "session ids as a ticket" instead. This significantly reduces the ticket size to below 128 in 1.1.1.
What is happening is that s_server is setting a TLSv1.2 PSK callback and a TLSv1.3 PSK callback. For backwards compat reasons the TLSv1.2 PSK callbacks also work in TLSv1.3 but are not preferred. In this scenario we use the "1234567890" PSK to create the initial connection. Subsequent to that we are doing a resumption using a TLSv1.3 ticket (psk). If the psk length is below PSK_MAX_IDENTITY_LEN then we first call the TLSv1.2 PSK callback. Subsequently we call the TLSv1.3 PSK callback. Unfortunately s_server's TLSv1.2 PSK callback accepts the identity regardless, even though it is an unexpected value, and hence the binder subsequently fails to verify.

Fix in #16008

The fix is merged, this should be closed.


[JointTrajectoryController] Add velocity-only command option for JTC with closed loop controller

The PR has been tested with:

galactic
livanov93/ros2_control
livanov93/ros2_control_demos

Velocity jtc has been used with following commands:
ros2 launch ros2_control_demo_bringup rrbot_system_multi_interface.launch.py start_rviz:=true use_fake_hardware:=true robot_controller:=velocity_trajectory_controller

ros2 launch ros2_control_demo_bringup test_action_client_follow_joint_trajectory_velocity.launch.py

This looks good. Can you add some tests?

I can. I will follow the currently existing tests in the jtc package and add one to test velocity interface.

I can. I will follow the currently existing tests in the jtc package and add one to test velocity interface.

Maybe you are lucky and can add simply a new parameterized test. Check the end of the file (before the last test). Last test should also be changed because it will fail if VELOCITY interface is enabled.

@destogl what is the decision with this?