Support kotlin default arguments for non coroutines methods

Currently, there is no easy way to use kotlin default arguments for non coroutine methods.
Either you have to make all your commands suspending, and you switch back to the main thread for commands that need to be synchronous.
@Command("test-async [value]")
fun onAsyncCommand(
  @Argument("value") value: Int = 5,
  context: CommandContext<MySender>
) {
  doStuff(value)
}

@Command("test-sync [value]")
fun onSyncCommand(
  @Argument("value") value: Int = 5,
  context: CommandContext<MySender>
) {
  runMainThread {
    doStuff(value)
  }
}

Or use reflection to instantiate a KotlinMethodCommandExecutionHandler, with a custom predicate to catch all kotlin methods, and use a the main thread executor as a coroutine scope.
object MyAsyncScope

fun <C : Any> AnnotationParser<C>.installKotlinSupport(mainThreadExecutor: Executor) {
    val syncScope = CoroutineScope(mainThreadExecutor.asCoroutineDispatcher() + SupervisorJob())
    registerCommandExecutionMethodFactory({ it.kotlinFunction != null }) { context ->
        val function = context.method().kotlinFunction!!
        if (function.isSuspend) {
            createKotlinMethodInvoker<C>(MyAsyncScope, context)
        } else {
            createKotlinMethodInvoker<C>(syncScope, context)
        }
    }
}

@Suppress("UNCHECKED_CAST")
private fun <C : Any> createKotlinMethodInvoker(
    scope: CoroutineScope,
    context: MethodCommandExecutionHandler.CommandMethodContext<C>
) =
    Class.forName("org.incendo.cloud.kotlin.coroutines.annotations.KotlinMethodCommandExecutionHandler")
      .kotlin
      .primaryConstructor!!
      .apply { isAccessible = true }
      .call(scope, scope.coroutineContext, context) as MethodCommandExecutionHandler<C>

It would be real nice if there was a cloud module providing support for that, or simply making KotlinMethodCommandExecutionHandler public.

Nvm, I completly forgot about SuspendingExecutionHandler (even tho you still have to use coroutines, its still better that creating another module).


Default range selection in inline date picker

I have to use inline date picker with no input linked to it, same like you have in your demo link but here I am unable to property for passing date range as default range, output is fine but unable to locate Input for date range like 'begin' and 'end' value, there is property named as selected but that is just for single date.

What do you mean by using it inline? Are you using mat-calendar directly or mat-datepicker? It would be useful to see what your markup looks like.

What do you mean by using it inline? Are you using mat-calendar directly or mat-datepicker? It would be useful to see what your markup looks like.

<div class="inlineCalenderContainer">
    <sat-calender [rangeMode]="true" (dateRangesChange)="inlineRangeChange($event)" [selected]="selectedDate">
    </sat-calender>
</div>

This is the exact code available in your demo.


libkb: fix PGP update problem in jwives's sigchain

the issue was that he's using a PGP update link to sign in a new signing subkey
he's likely to use the new key and not the old when signing the PGP update link
and therefore the old PGP update key won't work for verifying, since it lacks the
proper subkeys that are being introduced in this signature.

We might eventually need to try both the new and the old, be on the lookout
for bugs as a result of this commit.

@oconnor663 want to take a look?

I thought we already had to solve this problem for using an extended version of an expired PGP key to update itself. Did we never actually implement that? (All the PGP update links coming from the client will actually be signed by the device key, so it's possible we didn't.)

We might have solved this problem on the server.
On Saturday, February 6, 2016, oconnor663<EMAIL_ADDRESS>wrote:

I thought we already had to solve this problem for using an extended
version of an expired PGP key to update itself. Did we never actually
implement that? (All the PGP update links coming from the client will
actually be signed by the device key, so it's possible we didn't.)
—
Reply to this email directly or view it on GitHub
https://github.com/keybase/client/pull/1921#issuecomment-180943507.

You revoke A, and issue a PGP Update link pinning the new version of your key that includes the revocation.
Evil Keybase Server impersonates you and issues a second PGP Update link, reverting you back to the old PGP key where A was valid. The server can now make arbitrary signatures as you.

I think this change allows step 3 to succeed, where before it would fail with an invalid signature. But if so, that might defeat the whole point of key pinning, which was to prevent the server from rolling you back to an old version of your PGP key.
There's a good argument for this "pgp update reaches back in time" rule with respect key expiration times specifically, but I'm not sure we can allow it to undo revocations.

Good point. That is an attack.....
Other suggestions welcome as to how to fix this bug.

You revoke A, and issue a PGP Update link pinning the new version of
your key that includes the revocation.
Evil Keybase Server impersonates you and issues a second PGP Update
link, reverting you back to the old PGP key where A was valid. The server
can now make arbitrary signatures as you.

I think this change allows step 3 to succeed, where before it would fail
with an invalid signature. But if so, that might defeat the whole point of
key pinning, which was to prevent the server from rolling you back to an
old version of your PGP key.
There's a good argument for this "pgp update reaches back in time" rule
with respect key expiration times specifically, but I'm not sure we can
allow it to undo revocations.
—
Reply to this email directly or view it on GitHub
https://github.com/keybase/client/pull/1921#issuecomment-180944536.

Can we do a PGP key merge respecting revocations? WACKY BACKY IN TIME additions of subkeys seems safe, as long as revoked subkeys stay revoked.

Actually your attack also works against revoked device keys also.
The only defense against a bad keybase is to delete your social media
proofs.
On Saturday, February 6, 2016, oconnor663<EMAIL_ADDRESS>wrote:

Can we do a PGP key merge respecting revocations? WACKY BACKY IN TIME
additions of subkeys seems safe, as long as revoked subkeys stay revoked.
—
Reply to this email directly or view it on GitHub
https://github.com/keybase/client/pull/1921#issuecomment-180944755.

You mean if the Keybase server is rolling back your sigchain? I was assuming the Merkle tree is audited enough to prevent that. The attack I'm worried about in my comment above works without rolling back the sigchain, if we loosen PGP Update link verification in this way.

Alright, let's just go with this for now. This attack is real, but the defense against it is going to have to be revoking your PGP key Keybase-style, in your sigchain. I'll file a ticket about doing some more interesting key merging here in the future.
:ship:

Field https://keybase.atlassian.net/browse/CORE-2526 for the future.


how to set mean value

Hi,@yjxiong. Excuse me,I want to apply this code on other videos.However,I'm not sure how to set mean value in caffe solver prototxts.I write a code to compute the mean values of rgb frames,which first compute the rgb mean values of one frame and then average all frames' mean values to get the final mean value.And I have 1117 thousands images, so I have computed 3 three days and don't finish computing.Would you tell me how you get the mean value in rgb frames and flow frames?

You can use the provided mean values in the model proto file. The init model was trained with this setting. So it should suffice unless your video are from a very distinct domain (e.g. CT scans or infra).
https://github.com/yjxiong/temporal-segment-networks/blob/master/models/ucf101/tsn_bn_inception_rgb_train_val.prototxt#L25

Thanks a lot.

Closing this. Please feel free to reopen it if you meet any further problem.


DO NOT MERGE. PN implementation. For review only

CLA signed by all contributors.

I deliberately left out the AST to PN transformer tests because once the pspec is functional, each and every transformation will be thoroughly tested by the parser.pspec. It felt somewhat redundant to implement very similar tests in Ruby (it's 70 transformations and hence > 70 tests that needs to be duplicated).

What is PN? All of the commit messages are empty.

@josh, PN is short for Puppet Extended S-Expression Notation and it's Clojure like string representation is what that  the Puppet Specification Language, pspec, is using when validating a generated AST. I'm currently using it when validating the  Go-parser and the parser in pcore-java.
This PR is about adding PN and parts of pspec to Ruby so that we can validate all Puppet Language and EPP parsers using the same test suites. It's work in progress and I put it up here to get a preliminary review of the source code. Once the final PR arrives, it will have proper commit comments, ticket affinity, and API documentation.

@joshcooper PN is a formal replacement of the informal AST dump format we already have in the code base (used in puppet parser dump and in unit tests of the language). We want to make that API, and thomas has improved and fixed issues with the informal existing format.

superseded by #6673


Avoiding array assignment with for loop

Thanks for the great work in developing autograd!
I understand from the tutorial that array assignment is not supported when the array is contained in the objective to be differentiated. However, I currently have the following objective function in my code which I would like to differentiate with respect to theta:
def obj(theta):
    """
    Computes the objective function to be differentiated.

    Args:
        theta: np.array of shape (n, d)

    Return:
        res: np.array of shape (n,)
    """
    theta = np.atleast_2d(theta)
    n = theta.shape[0]

    res = np.zeros(n)  # Scores
    for i in xrange(n):
        res[i] = ... # Do some computations with theta[i, :]

    return res

Typically I can avoid the for loop by vectorizing the computation over theta; however, the catch in this case is that each row of theta corresponds to a list of hyper-parameters of the covariance function in a Gaussian process, and within the for-loop I am computing the likelihood of a set of observations under a GP with that hyper-parameter setting. Since the computation already involves various linear algebra operations (inverses, etc.) on the data matrix for a specific row of theta, I found it quite difficult to vectorize the operation over all rows of theta. In this case, I don't know of a better way than filling the res array row by row with a for-loop.
I have tried a naive way to avoid array assignments by creating a list and at each iteration append the results to that list, then finally convert the list to the array upon returning res, but I get all-zero gradients in the end...
I wonder what is the general recommend solution in this setup? If you have specific suggestions for vectorizing the GP calculation in this case, please also let me know. Thanks!

@bewantbe Ah, I see. Thanks! Just for future reference, what could I do if the computations in each iteration are not independent?

I can't see a general solution when the iterations are not independent. It need to be examined case by case, and probably not easy and requires high cost.
Some functions help you rewrite the for loop into vectorized form, say np.cumsum.
Even for a simple-looking code, it is not easy to make it autograd compatible:
def run_simulation(y0, f, n):
    y = np.zeros(n)
    y[0] = y0
    for k in range(n-1):
        y[k+1] = f(y[k])  # f() is unknown in advance
    return y

If you need only the final step result, then you can discard middle step values:
def run_simulation(y0, f, n):
    y = y0
    for k in range(n-1):
        y = f(y)
    return y

If the dependence of y in f(y) is linear, then it is possible to replace the for loop by a linear equation solving (moving all y terms to the LHS). In the most simple case, it is solved by np.cumsum.
Beyond these, I don't know a simple solution. Probably you need to define a custom gradient function.
In the worst case, you might run the second code above n times with n=1,2,...n :-(
I would love to known if this have a nicer solution.


tap-mysql is not supported

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2027
Originally created by @DouweM on 2020-05-15 16:00:50

Mathieu Hinderyckx wrote on Slack:

Hi, I'm trying out meltano, currently using stitch and pipelinewise.
Some initial questions: no MySQL/postgres tap being included is a surprise. These are basic mature db's which I would expect to be in any etl product.
Then I've tried running the singer MySQL tap as custom extractor and got the following issue: I cannot select a replication method. I've modified the installed python code to enforce logbased replication. It does sync, but it does not seem to save state.

View 4 previous comments from the original issue on GitLab


Run now fixes

Implements the following changes:

A rerun button now appears on the task history table for requests whose tasks can be rerun.
The run now dialog imports default command line arguments from the previously run task - unless it's a rerun in which case it imports from the task to be rerun.
The run now dialog guesses that you want to tail the running log path.
Code cleanliness, including not mutating state.

Forgot to cc here too...  @tpetr @kwm4385 @wolfd

LGTM

LGTM aside from my comments


PBXCp Error No Such File or Directory Error for Certain Fonts

I'm trying to build my react native project onto my actual device but these errors are causing the build to fail.

CpResource /Users/maxwellgover/Desktop/nimbus/node_modules/native-base/Fonts/Arial\ Black.ttf /Users/maxwellgover/Library/Developer/Xcode/DerivedData/nimbus-dwhroufdxzvgkcajekmlbluemoyy/Build/Products/Debug-iphoneos/nimbus.app/Arial\ Black.ttf
    cd /Users/maxwellgover/Desktop/nimbus/ios
    export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
    builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -resolve-src-symlinks /Users/maxwellgover/Desktop/nimbus/node_modules/native-base/Fonts/Arial\ Black.ttf /Users/maxwellgover/Library/Developer/Xcode/DerivedData/nimbus-dwhroufdxzvgkcajekmlbluemoyy/Build/Products/Debug-iphoneos/nimbus.app

react-native, react and native-base version
react-native-cli: 2.0.1
react-native: 0.44.0
nativebase: 0.2.0
Expected behaviour
Not cause the xcode build to fail.
Actual behaviour
Causes xcode build to fail.
Steps to reproduce (code snippet or screenshot)
Try building onto actual device.
Is the bug present in both ios and android or in any one of them?
ios

Going to resources folder in xcode and deleting all the fonts highlighted in red solved the issue.

Any guess why it happened?


[WIP] cleanup and rebase of models for jenny

Purpose
Description...
Proposal
Description...

[] item 1...
[] item 2...

This work was finally done in a separate prroject.


Iss1

Fix minor bugs and language issues

It's better to continue working on the already started Pull Request.


Fixed the signup and login issue #255

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #255
Type of change
Please give a X on it which is applicable

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactor Code
[ ] A documentation update
[ ] Others(mentioned in the issue number)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test A Describe here
Tested this in localhost and it's working fine now
Test B Describe here (if Requred)
https://github.com/VanshKing30/FoodiesWeb/assets/115611556/176b90f0-eb83-4df1-a4a4-6bab577b8f8f
Checklist:
give a X on it which is applicable

[ X] My code follows the style guidelines of this project
[ X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@hustlerZzZ please merge this PR as soon as possible so everyone can Signup

@hustlerZzZ please add labels too


Check SQL Logins for Weak Passwords - updates

Added more core passwords from danielmiessler/SecLists/
Do basic permutation steps on core passwords
Do a connection count in the output screen.
Tested on SQL 2012 and 2019

Thank you for your contribution, Adrian!
I'll get this sorted out to remove any duplicates and then merge.

I made several optimizations and I'm merging this into the main branch.

Legend. Thanks Eitan. I love your work.


Feature conflict with software repositoriy and local shared software

We have two advanced features:

Remote software repository - see #98
Shared local software cache - see #152

However, if these two features are combined undesired things can happen. So to be precise:
The implementation of 2. needs to separate software per repository.
Unlike a maven repository we can not be sure that a combination of tool, version, and OS will lead to the same binary no matter what repository is configured for 1. The idea of 1. is actually for projects to provide a customized version of a tool (e.g. use Java from a different vendor, use Eclipse with a preinstalled set of plugins, etc.).
The feature 2. only makes sense if you mave multiple installations of devon-ide in parallel. Now if some of these installations use different configurations for 1. the devon-ide will accidentally use the software of the one also for the other even though they should be different.
To fix the issue the structure of the shared software folder for 2. needs to be extended to:
${DEVON_SOFTWARE_PATH}/${software_repo}/${software_name}/${software_version}

Where ${software_repo} is one of:

default if 1. is not used
some unique identifier for 2. - IMHO the hostname should already be sufficient. To be more reliable a hash of the entire URL could be appended.

Fixed with PR #201


Font selection for Bold and BoldItalic is mixed up

I like the app so far and it is a lot easier to make your own theme with it, so thanks a lot for making it!
I just discovered that the font selection for bold and bold italic is mixed up. You can also see it in the card widget titles. They are all italic. If you switch out the fonts manually and put a bold italic font in the selection for a bold font and the other way around it works properly.

Vs how the app starts:

Edit: But in the theme file it is correct. So I exported my theme file as shown in image 1 but the bold and bold italic fonts are mixed up. So the bug only seems to be in the ui.

Thanks for catching this, and thanks for your interest!

Thanks a lot for the fast fix!


New server new setup as per requirements but getting this now.

Is there anyone that could give me giudance please.
Wed Oct 16 01:03:49.159687 2019] [:error] [pid 23958:tid<PHONE_NUMBER>2544] (12)Cannot allocate memory: [client <IP_ADDRESS>:16114] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Wed Oct 16 00:26:48.893656 2019] [:error] [pid 23957:tid<PHONE_NUMBER>8272] (12)Cannot allocate memory: [client <IP_ADDRESS>:39142] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Tue Oct 15 22:10:07.871469 2019] [access_compat:error] [pid 23957:tid<PHONE_NUMBER>3776] [client <IP_ADDRESS>:36427] AH01797: client denied by server configuration: /home/clubhou1/video.clubhouse121.com/styles/cb_27/images/home.html
[Tue Oct 15 22:10:07.871291 2019] [access_compat:error] [pid 23957:tid<PHONE_NUMBER>3776] [client <IP_ADDRESS>:36427] AH01797: client denied by server configuration: /home/clubhou1/video.clubhouse121.com/styles/cb_27/images/default.html
[Tue Oct 15 22:10:07.871091 2019] [access_compat:error] [pid 23957:tid<PHONE_NUMBER>3776] [client <IP_ADDRESS>:36427] AH01797: client denied by server configuration: /home/clubhou1/video.clubhouse121.com/styles/cb_27/images/Default.html
[Tue Oct 15 22:10:07.869504 2019] [access_compat:error] [pid 23957:tid<PHONE_NUMBER>3776] [client <IP_ADDRESS>:36427] AH01797: client denied by server configuration: /home/clubhou1/video.clubhouse121.com/styles/cb_27/images/index.html
[Tue Oct 15 14:47:56.075924 2019] [authz_core:error] [pid 2053:tid<PHONE_NUMBER>68224] [client <IP_ADDRESS>:42352] AH01630: client denied by server configuration: /home/clubhou1/public_html/data/system/modules/user/avatar/img/happypanda386
[Mon Oct 14 23:25:01.243181 2019] [:error] [pid 9360:tid<PHONE_NUMBER>79136] (12)Cannot allocate memory: [client <IP_ADDRESS>:55070] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 23:24:53.369909 2019] [:error] [pid 9360:tid<PHONE_NUMBER>79136] (12)Cannot allocate memory: [client <IP_ADDRESS>:55070] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 22:52:48.555986 2019] [:error] [pid 26220:tid<PHONE_NUMBER>75520] (12)Cannot allocate memory: [client <IP_ADDRESS>:46045] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 22:52:36.374904 2019] [:error] [pid 26220:tid<PHONE_NUMBER>75520] (12)Cannot allocate memory: [client <IP_ADDRESS>:46045] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 22:46:08.264382 2019] [:error] [pid 26219:tid<PHONE_NUMBER>60928] (12)Cannot allocate memory: [client <IP_ADDRESS>:59746] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 22:46:08.264354 2019] [:error] [pid 26220:tid<PHONE_NUMBER>30208] (12)Cannot allocate memory: [client <IP_ADDRESS>:44133] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 22:46:02.870584 2019] [:error] [pid 26220:tid<PHONE_NUMBER>30208] (12)Cannot allocate memory: [client <IP_ADDRESS>:44133] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 22:46:02.871849 2019] [:error] [pid 26219:tid<PHONE_NUMBER>60928] (12)Cannot allocate memory: [client <IP_ADDRESS>:59746] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 22:44:48.536285 2019] [:error] [pid 26480:tid<PHONE_NUMBER>93728] (12)Cannot allocate memory: [client <IP_ADDRESS>:59439] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 22:44:43.441931 2019] [:error] [pid 26480:tid<PHONE_NUMBER>93728] (12)Cannot allocate memory: [client <IP_ADDRESS>:59439] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 22:34:28.940365 2019] [:error] [pid 26480:tid<PHONE_NUMBER>28064] (12)Cannot allocate memory: [client <IP_ADDRESS>:56358] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 22:34:25.092726 2019] [:error] [pid 26480:tid<PHONE_NUMBER>28064] (12)Cannot allocate memory: [client <IP_ADDRESS>:56358] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 21:48:35.622659 2019] [:error] [pid 26480:tid<PHONE_NUMBER>13472] (12)Cannot allocate memory: [client <IP_ADDRESS>:35684] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/cam.clubhouse121.com/index.php
[Mon Oct 14 21:42:45.643247 2019] [:error] [pid 26480:tid<PHONE_NUMBER>82816] (12)Cannot allocate memory: [client <IP_ADDRESS>:45108] couldn't create child process: /usr/sbin/suphp for /home/clubhou1/public_html/index.php
[Mon Oct 14 18:33:57.908160 2019] [authz_core:error] [pid 27159:tid<PHONE_NUMBER>13472] [client <IP_ADDRESS>:62536] AH01630: client denied by server configuration: /home/clubhou1/public_html/templates/system/modules/user/themes/base/index.cgi
[Mon Oct 14 18:33:57.907914 2019] [authz_core:error] [pid 27159:tid<PHONE_NUMBER>13472] [client <IP_ADDRESS>:62536] AH01630: client denied by server configuration: /home/clubhou1/public_html/templates/system/modules/user/themes/base/index.pl
[Mon Oct 14 18:33:53.855846 2019] [authz_core:error] [pid 27160:tid<PHONE_NUMBER>08320] [client <IP_ADDRESS>:61558] AH01630: client denied by server configuration: /home/clubhou1/public_html/templates/system/modules/user/themes/base/index.cgi
[Mon Oct 14 18:33:53.854330 2019] [authz_core:error] [pid 27160:tid<PHONE_NUMBER>08320] [client <IP_ADDRESS>:61558] AH01630: client denied by server configuration: /home/clubhou1/public_html/templates/system/modules/user/themes/base/index.pl
Please can someone help The server has lots of memory it is not the server
Simon

Staff
Hello,
Thank you for contacting TMDHosting Technical Support Team.
The reported error is related to the website's script using all of the allocated system memory. The PH7 requirements linked above specify 128MB of PHP memory_limit. Currently, the VPS is set to 1024MB PHP memory_limit. Thus, the script consumes nearly all of the available memory on the VPS. What we could assist with, as Hosting-related is to set up Swap space on the VPS, by using 2 or 4GB of the Disk Space on the VPS to be used as virtual memory. As you currently have 29GBs available, this should not be an issue.
Simon

Closing this down, Wow have I got a head ache now, But this was a mix of problems mainly server configuration, I have learned a lot. The guy's on here give you pointers not resolves but this is good as you have to learn yourself, They will answer questions and give direction, It is a big learning curve.
Simon


Add opa cli tool to appstudio-utils docker image

OPA is the tool used for for validating rego policies such as the
ones that will be used by the Enterprise Contract to validate
pipeline runs.
It's not clear yet whether the final version of the Enterprise
Contract tasks will use this base image, but there's a reasonable
chance they will, and either way it seems like this is generally
useful tool to add alongside the others.
See also:

https://github.com/open-policy-agent/opa/releases
https://www.openpolicyagent.org/
https://issues.redhat.com/browse/HACBS-233
https://issues.redhat.com/browse/HACBS-235

Actually the checksum check doesn't work like that, maybe because the filename is different.

Fixed now - problem was I had the sha for the static version but fetched the non-static version.

Choose one or other of this and #46 (not both).

PTAL @Michkov @zregvart @bcaton85 @joejstuart

I'd go with this version, perhaps we could (in a different PR) add hash checks to other bits downloaded.

Replaced by #48 - sorry for the noise.


Support PHP 7.1-8.0

Q
A

Bug fix?
yes

New feature?
yes

BC breaks?
no

Deprecations?
no

Related tickets
fixes #159

License
MIT

Switches to GitHub actions and supports php 7.1-8.0. Note that travis needs to be removed from the required to pass CI thing.

// cc @dbu, @sagikazarmark

i merged this, but the build of master is now failing. the problem is that we try to build on travis with php 7.0: https://github.com/php-http/httplug/blob/bfd345b7c7940ccabeeccfd376b54d9c08f0e347/.travis.yml#L10


feat: remove specialized delete methods

The service now funnels all delete operations through a single
delete RPC. Therefore the specialized delete
methods (DictionaryDeleteAsync, SetDeleteAsync, ListDeleteAsync)
are no longer necessary.
We retain the integration tests though to test removing all data
types.
closes #65

Did you want to go ahead and remove the Responses classes for these as well (e.g., CacheSetDeleteResponse)?

Yes, absolutely! Thanks for pointing that out :eagle: :eye:


[Doc-12284][Installation] Update ZooKeeper minimum version requirements

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@tuchg  please relation with issue

@tuchg please relation with issue

ok


mounNode property does not work

I have tried to set a property like this
mountNode={document.getElementsByClassName('clas-name')[0]}
and also tried to set react ref.current.
So, it does not work. All the time I get picker at the end of 'body' tag

also, I've tried to do this in the same place of DOM with Popup control from semantic and it works. Looks like a problem of calendar

As I understand this property should be set in InputView.tsx file.

fixed locally in the component. Please fix this. Just add property
mountNode={mountNode}


I have some questions. Can GFlowNet be used for topic modeling? What are the challenges involved? Discussion is welcome.

Good question.
Yes, a GFlowNet -- and GFlowNet-EM in particular -- could be used for topic modeling, since a topic model is a particular kind of latent variable model, albeit one with a continuous latent variable. Consider the example of LDA, using the notations $\theta$ for a topic vector and $x$ for a document.

The generative model ($p$) is specified by $p(\theta)$, which is fixed to $\text{Dirichlet}(\alpha)$, and by $p(x\mid\theta)$.

In LDA, the latter is fully specified by the topic-word matrix $A$, and $\log p(x_i\mid\theta_i)$ can be computed using matrix products and logsoftmax operations (if $x_i$ is represented as a vector of word counts).
This could take some other parametric form in topic models that do not assume exchangeability (i.e., words in $x_i$ not conditionally independent given $\theta_i$).

The posterior model $q(\theta_i\mid x_i)$ is typically estimated with a Dirichlet in LDA algorithms. However, we can instead train a continuous GFlowNet of some form to sample $\theta_i$, a point in the probability simplex, conditioned on $x_i$.

This GFlowNet would be trained in the E-step, and the reward for sampling $\theta_i$ given document $x_i$ is $p(\theta_i)p(x_i\mid\theta_i)$.
How should a GFlowNet generate a vector in the probability simplex over topics? One way is using a stick-breaking process with a mixture of Betas policy (like in the code below), but there are probably other ways.
In the M-step, one trains the model $p(x_i\mid\theta_i)$ by sampling from the posterior model, $\theta_i\sim q(\theta_i\mid x_i)$, and taking gradient steps on $\log p(x_i\mid\theta_i) + \log p(A)$, where $p(A)$ is the $\text{Dirichlet}(\beta)$ prior on the topic-word matrix.

I have tried this for very small topic models on synthetic data -- you can find the code for a proof of concept at https://gist.github.com/malkin1729/88227a1e451596e1ea1fc7d4e0a7ae09 -- but never pursued it further. Curious about what you can do with it, and particularly about whether topic models with more interesting structure in the latent can benefit from the GFlowNet approach.

As far as I know, some tree-structured neural topic models and nonparametric forest-structured topic models do utilize the stick-breaking process with a mixture of Betas. I am considering whether GFlowNet can be used as an alternative for modeling in these cases.
Additionally, for certain popular neural topic models based on VAEs, the assumption is often made that the latent variables follow a Gaussian distribution or a logit Gaussian distribution. I am pondering whether continuous generative flow theory can be employed as a replacement in these cases.

As far as I know, some tree-structured neural topic models and nonparametric forest-structured topic models do utilize the stick-breaking process with a mixture of Betas. I am considering whether GFlowNet can be used as an alternative for modeling in these cases.
Additionally, for certain popular neural topic models based on VAEs, the assumption is often made that the latent variables follow a Gaussian distribution or a logit Gaussian distribution. I am pondering whether continuous-GFlownet theory can be employed as a replacement in these cases.

A GFlowNet could be used to sample the posterior over latents topics in nonparametric topic models, indeed. However, I have not seen stick-breaking with mixture of Betas in that literature. Do you have a reference?
In my code, I simply used mixture of Betas in parametrizing the sampling of a point in the probability simplex by sequentially “breaking off” probability mass to assign to a chosen topic.

Masaru Isonuma, Junichiro Mori, Danushka Bollegala, and Ichiro Sakata. 2020. Tree-structured neural topic model. In ACL, pages 800–806.

Ziye Chen, Cheng Ding, Zusheng Zhang, Yanghui Rao, and Haoran Xie. 2021b. Tree-structured topic modeling with nonparametric neural variational inference. In ACL/IJCNLP, pages 2343–2353.

Zhang Z, Zhang X, Rao Y. Nonparametric Forest-Structured Neural Topic Modeling[C]//Proceedings of the 29th International Conference on Computational Linguistics. 2022: 2585-2597.

I apologize, but I believe these papers are related. If they are combined with Gflownet, do you have any thoughts or suggestions?

There is nothing to apologize for. Thank you for the references. I have worked a little on graph-structured topic models and had seen the first paper before, and I quickly looked at the other two now.
They are relevant to structured topic models, of course, but I do not see there the use of learned Beta mixtures as posterior estimators, which is what I had asked about in the comment above.
A GFlowNet could be used as an amortized variational posterior in any of these models.


Potentially Split File and Directory into Separate Builders

While Files and Directories are the same thing to use, service and SDK team, this may not be thought as the same from a consumers perspective. We should look into splitting Files and Directories into separate builders again where one derives from the other.

Closing as we are post GA and this would require a break.


cannot find libobjectbox.so

After I had configed this in my android project , when I run my app. But I Get an error, "cannot find libobjectbox.so". So, what should I do ? Can you ofter a solution, thank u.

Oh, your meaning is that I make a mistaken in my ndk configuration. just like this:
android{
...
defaultConfig{
...
ndk{
abiFiter "armeabi"
}
}
...
}
I will try to delete ndk configuration, thank u.

hi, I have solved my problem, thanks for your help.


refactor: Improve customAppColors usage according to usage

Description:

refactor app design to efficiently handle customAppColor variables

fix: LEARNER-10043

We're closing this PR and moving these changes to our own fork, as they are critical for us. After our release, we hope to find a way to contribute these changes back, thanks!


Inflector.Inflector.Titleize(Model.Tablename) Replace with ClassNameFromTableName(Model.Tablename)

At placing lookup editor
Inflector.Inflector.Titleize(Model.Tablename)
Should be Serenity.CodeGenerator.RowGenerator.ClassNameFromTableName(Model.Tablename)

I have generated some table with generate lookup checked.
and got some error regarding this.
because
it generated Container Type  instead of ContainerType

thank you @dfaruque.
I did a fix some weeks ago, but i saw now that my pull request had some problemns ( I don't know why...)
maybe used the same  Branch Name that used in the last PR?
Another fix is about Fix - Maximizable option
Let's try delete the branch and create another, with another name.


[FEAT REQ.] - Aliases Folder

Is your feature request related to a problem? Please describe.
Consider relabeling your ISR folder to Aliases

Fixed/Added in version 0.5.5


fixes note on common courses

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.171%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
395

Relevant Lines:
555

💛  - Coveralls


Inline URL preview

The following things are implemented in this pull request:

Getting data for links using 3 sources: oEmbed, Open Graph, meta tags. (In that order).
Getting data asynchronously.
Caching link data

These things are not implemented/taken care of yet:

Race condition: user can try to edit a message before the data links are obtained.
Design for links preview on client side.
Issue: #406

Automated message from Dropbox CLA bot
@TigorC, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

Automated message from Dropbox CLA bot
@TigorC, thanks for signing the CLA!

It looks like you've got one Python 3 compatibility issue, namely trying to use assertIn on something that is an Iterable (not a List) in Python 3.
Running python 3 compatability test libmodernize.fixes.fix_dict_six
+        self.assertIn('title', list(result.keys()))

Did you figure out why that Facebook link didn't work?

Did you figure out why that Facebook link didn't work?

Yes I did, I fixed this.

Great!  I cleaned up a few small things and merged this, default-off, thanks @TigorC!
Things we'll want to fix before turning it on by default:

Working on the styling (@brockwhittaker, can you take care of this?)
Getting the test coverage on the new code up to 100%; zerver/lib/url_preview could use more testing.  I think we should have at least one test "integration test" that only mocks at the level of the HTTP request from the requests library so that we exercise the code; that probably should take the form of a test that exercises the full sequence of sending a message containing a link (mocking only the requests call to make it still run fast off the Internet), and then runs the queue worker code (perhaps involves refactoring the consume method to actually just call a function in actions.py that has all the logic in it), and verifies that the right thing happened.

Merged (after dropping the first two commits, which just cancel each other).  Thanks @TigorC !


abigen is intolerant of duplicate names with different casing

Version
https://github.com/gakonst/ethers-rs#906c504f
Platform
linux
Description
Abigen is intolerant of identifiers that have the same name but differ in casing.
For example the names index and INDEX both appear in the sOHM contract: 0x04f2694c8fcee23e8fd0dfea1d4f5bb8c352111f
I tried this code:
Abigen::new(
    "StakedOHM",
    "https://etherscan.io/address/0x04f2694c8fcee23e8fd0dfea1d4f5bb8c352111f",
  )
  .unwrap()
  .generate()
  .unwrap()
  .write_to_file("src/contracts/staked_ohm.rs")
  .unwrap();

I expected to see this happen: the generated code compiles
Instead, this happened:
error[E0201]: duplicate definitions with name `index`:
   --> src/contracts/staked_ohm.rs:153:5
    |
51  | /     pub fn index(&self) -> ethers::contract::builders::ContractCall<M, ethers::core::types::U256> {
52  | |       self
53  | |         .0
54  | |         .method_hash([45, 247, 92, 177], ())
55  | |         .expect("method not found (this should never happen)")
56  | |     }
    | |_____- previous definition of `index` here
...
153 | /     pub fn index(&self) -> ethers::contract::builders::ContractCall<M, ethers::core::types::U256> {
154 | |       self
155 | |         .0
156 | |         .method_hash([41, 134, 192, 229], ())
157 | |         .expect("method not found (this should never happen)")
158 | |     }
    | |_____^ duplicate definition

Nice catch, this is similar to #548 and should be fixed with the same approach.
In the meantime, you should be able to prevent this with methods field like
abigen!(StakedOHM,
    "https://etherscan.io/address/0x04f2694c8fcee23e8fd0dfea1d4f5bb8c352111f",
    methods {
        INDEX() as index_;
    }
);

@casualjim could you please check that the issue is no longer present in master?

There is progress: different error, but still an issue:
error[E0428]: the name `IndexCall` is defined multiple times
 --> src/contracts/ethereum/mod.rs:3:3
  |
3 | /   abigen!(
4 | |     StakedOHM,
5 | |     "./abi/staked_ohm.json",
6 | |     event_derives(serde::Deserialize, serde::Serialize)
7 | |   );
  | |    ^
  | |    |
  | |____`IndexCall` redefined here
  |      previous definition of the type `IndexCall` here
  |
  = note: `IndexCall` must be defined only once in the type namespace of this module
  = note: this error originates in the macro `abigen` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0428]: the name `Index` is defined multiple times
 --> src/contracts/ethereum/mod.rs:3:3
  |
3 | /   abigen!(
4 | |     StakedOHM,
5 | |     "./abi/staked_ohm.json",
6 | |     event_derives(serde::Deserialize, serde::Serialize)
7 | |   );
  | |    ^
  | |    |
  | |____`Index` redefined here
  |      previous definition of the type `Index` here
  |
  = note: `Index` must be defined only once in the type namespace of this enum
  = note: this error originates in the macro `abigen` (in Nightly builds, run with -Z macro-backtrace for more info)

@casualjim
hmm, could not reproduce with master, as
    abigen!(
        StakedOHM,
        "etherscan:0x04f2694c8fcee23e8fd0dfea1d4f5bb8c352111f"
    );

compiles and generates
fn index()
fn INDEX()

@casualjim what's the exact ABI you're using?

I did  update to master, I verified the commit hashes after running cargo update
I think maybe some local cache needed to be invalidated.
It works now!  And it appears that the etherscan stuff now also works again.

@casualjim what's the exact ABI you're using?

I used a downloaded version, because when I was trying this there was an issue with downloading from etherscan through ethers.
I used a json structure like this:
[
  {
    "network": "ethereum",
    "symbol": "sOHM",
    "typeName": "StakedOHM",
    "filename": "staked_ohm",
    "address": "0x04f2694c8fcee23e8fd0dfea1d4f5bb8c352111f"
  },
]

in combination with this download script:
set -eu -o pipefail

declare -A explorers=( ["ethereum"]="etherscan.io" ["polygon"]="polygonscan.com" ["avalanche"]="snowtrace.io" )
declare -A apikeys=( ["ethereum"]="$ETHERSCAN_API_KEY" ["polygon"]="$POLYGONSCAN_API_KEY" ["avalanche"]="$SNOWTRACE_API_KEY" )

download::abi() {
  local explorer
  local filename
  local address
  local network

  network="$(jq -r .network <<< "$1")"
  explorer="${explorers[$network]}"
  address="$(jq -r .address <<< "$1")"
  filename="$(jq -r .filename <<< "$1")"

  >&2 echo "downloading $(jq -r .typeName <<< "$1") $(jq -r .network <<< "$1") ABI"

  url="https://api.${explorer}/api?"
  url="${url}module=contract&action=getabi"
  url="${url}&address=${address}"
  url="${url}&apikey=${apikeys[$network]}"
  curl -LSs "${url}" | jq -r .result | jq > "abi/${filename}.json"
}

main() {
  readarray -t contracts < <(jq -c '.[]' ./contractdeps.json)
  for item in "${contracts[@]}"; do
    download::abi "$item"
  done
}

main "$@"


Fix a few small typos

👋🏽 This PR fixes a few small typos in the allow-scripts README.

much love!


Cursor Not Displaying

Hi jroimartin,
Thanks for answering my earlier question. I am asking this question as a new thread, thinking that others who want to use this fantastic library may find these Q&A helpful.
The issue/question I am having is, I have to draw a UI and ask for the user input. I would like to show the cursor in the screen (may be blinking as well) so user knows where the cursor is. I created a sample using gocui https://github.com/shibukraj/synapseconsole/blob/master/console-dev.go
While running I am not able to draw the cursor at all. Can you guide me please.
Thanks again

I got the issue figured out. Thanks

Cool! :)

how? running into same issue ...

Also having this issue; necro from 2017 but it's 2019 and this shows up first in Google. How did you get the cursor to show up?


Refine test AddPolicyHandler_Generic_AddsPolicyHandler

The test was identical to the nongeneric test above it.  From the test title, it looks as if the intention is to exercise the AddPolicyHandler(this IHttpClientBuilder builder, IAsyncPolicy<HttpResponseMessage> policy) generic method.  This change makes it do so.

Ahhh oopsies. Thanks


tcurl benchmark mode: sending a request many times

r @Raynos @kriskowal
cc @breerly
ref: #68

I hope that these comments clarify the intent of the delegate object. The delegate stands in place of a callback as a collector of multiple errors or results instead of a single error or response. Totally a great tool for collecting results for the benchmark. There should just be one instead of two.

That concludes my review. Looking forward to seeing this in master.

What does the user experience look like?

I was using tcurl.py with a batch mode like this to benchmark Python initially, but it didn't give me the numbers I actually wanted. Knowing how long it takes to complete 1000 requests just tells you how long the longest request took, which can be anomalous.
I suggest something like --bench which just fires off as many requests as possible (with some ceiling, and maybe ramping up initially), and then continuously display how many responses were received in the last second. I think this is similar to @prashantv's benchmark for Go.

@blampe
Very good point. hyperbahn ( https://github.com/uber/hyperbahn/blob/master/test/lib/time-series-cluster.js#L588-L620 ) has a results object including latencies and error rate.
I think the expected use case is to send n req/s and see what the latency is. You can then manually increase n until the p99 is too big.
That's why we have a --rate for sending N req/s and we have --time or --requests to say how long to benchmark it.
It should definitely stream results like telling us every M seconds what the success rate and latencies are.

I have talked to @kriskowal, we agreed to use a separate delegate since the user case for benchmark is quite different.


Rename generate-raw?

This is a question based on very little experience with the tool: should it be renamed to witx-bindgen? The tool seems similar in purpose to bindgen and wasm-bindgen and renaming it to something along those lines might help users familiar with the ecosystem to more quickly pick up on what the tool is intended to do.

cc: @alexcrichton, @pchickey


update PP to SNR

Poison Pill is deprecated, so update all occurences to Self Node Remediation.
Existing NHC resources refering to the old PP defaut template will also be updated during runtime.
New template name depends on https://github.com/medik8s/self-node-remediation/pull/22
CI config changes for having latest SNR available:
SNR:
https://github.com/openshift/release/pull/29089
https://github.com/openshift/release/pull/29136
NHC:
https://github.com/openshift/release/pull/29101
https://github.com/openshift/release/pull/29140

/retest

will merge manually, in order to be able to test CI update... 🤷🏼♂
review still welcome, will address in a follow up


Rick pumpkin from Rick an Morty

Still need some more helloween themes #42

Thanks!!!

Your welcome !


Is this project being maintained or not?

There are still problems need to be fixed like #305, and valuable improvements need to be implemented like #278. What's the state of this project now?

It's a shame. For me, it is still the best markdown slideshow tool out there.


unsafePerformEffect component

Your initial "actual" example is a great way to write it -- keeping the PS bits effectful and running unsafePerformEffect once at the top level where next.js can pick it up. A component library could similarly expose both the effectful version (which might support a generic type constrained with type classes) alongside a fully applied version which chooses a type for some common use case.

Btw, this is explained briefly in the docs, but if that was confusing or not enough info let me know.

Originally posted by @spicydonuts in https://github.com/spicydonuts/purescript-react-basic-hooks/issues/12#issuecomment-573794368

hmmm?

...continued...
I suggest that the documentation for component should specifically encourage users to call it in unsafePerformEffect at the top level.
No-one will believe that calling unsafePerformEffect is the right thing to do unless instructed that way. I was very confused about this until I found this comment in this issue.

I wouldn't say it's the right thing to do. I prefer the "app bootstrap effect" pattern that's been used in examples (which I've unfortunately broken, but you can switch the git tag to the last major version to find them).
Definitely need a lot of documentation work, I'll leave this open. But yeah, I recommend using main to effectfully construct your root component, and construct the components each child component depends on there in that child's own component creation effect. This is what the Component props alias is for.

For example:
main = do
  app <- mkApp
  render (app unit)

mkApp = do
  ctx <- createContext ...defaultCtxValue
  child <- mkChild ctx
  component "App" \_ -> React.do
    ...
    pure $ provider ctx currentCtxValue [ ...more stuff ]

mkChild ctx = do
  component "App" \_ -> React.do
    xyz <- useContext ctx
    pure ...

I was recently trying to use useContext in a purescript-cookbook recipe to implement a react-router-style Link component. The Link might be used in any leaf node of the app, so I was initially using unsafePerformEffect to avoid threading it through. After reading this thread, I thought better of it and refactored to use a ReaderT context wrapper around Component, but now I'm thinking that's not really worth the overhead and I should just thread the context through explicitly as you recommend 😅 .
I'm curious though, since I've only used the library for small examples, what approach you would recommend if you find yourself needing a context at many leaf nodes of a large app. Would you end up using unsafePerformEffect? Or does the ReaderT approach make sense? Or is the situation just an anti-pattern that should be avoided? (It seems like wire-react-router avoids using Context, but I haven't yet figured out how that library works.)

We use unsafePerformEffect, partly because it matches the JS convention and we transitioned from a JS app initially, but also because it can be more convenient with lots of leaves. But it does occasionally bite us with unexpected component remounts.
Your ReaderT example is probably the best approach though, if you're starting from scratch. Maybe the react-basic-hook Component type should be type Component props = ReaderT (RouterContext) Effect (props -> JSX) to encourage that pattern. Or at least expose a ComponentT of that type. You'd have to redefine it with explicit types in your app anyway.


ripgrep: 0.5.0 -> 0.5.1

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks!


Update tables to example

Updates the Java example to use the Gateway.
See https://github.com/openmicroscopy/openmicroscopy/pull/5270

code has been merged


PolarPlane does not work with 0 as maximum

Enhancement proposal
It is very common in antenna engineering to plot antenna radiation patterns in dB on a polar axis. It is also fairly common for those plots to be normalized (i.e. such that 0 is the maximum). Currently this is not possible with PolarPlane. I believe this is primarily due to these lines:
# PolarPlane.__init__()
# ...
        super().__init__(
            x_range=np.array((-radius_max, radius_max, radius_step)), # <===
            y_range=np.array((-radius_max, radius_max, radius_step)), # <===
            x_length=size,
            y_length=size,
            axis_config=self.radius_config,
            **kwargs,
        )

It should be possible to set 0 as the maximum, as well as set the minimum, eg.
class RadiationPattern(Scene):
    def construct(self):
        polar = PolarPlane(
            radius_min=-40,
            radius_max=0,
            radius_step=10,
        )

Additional comments
This is an example of this type of plot

It should be possible if you define your own labels in .add_coordinates([-30, -20, -10, 0], None) or similar. Could add a invert_radius argument or something if this would be a common use.

Hi, if someone still wants me to do this, let me know and I'll start a PR.


examples: MNIST: DefinitionMissing exception while resolving resize.outputs, missing resize.outputs.result

2020-06-24T21:19:38.2097548Z Traceback (most recent call last):
2020-06-24T21:19:38.2098542Z   File "/usr/share/miniconda/bin/dffml", line 33, in <module>
2020-06-24T21:19:38.2099663Z     sys.exit(load_entry_point('dffml', 'console_scripts', 'dffml')())
2020-06-24T21:19:38.2100304Z   File "/home/runner/work/dffml/dffml/dffml/util/cli/cmd.py", line 273, in main
2020-06-24T21:19:38.2100759Z     result = loop.run_until_complete(cls._main(*argv[1:]))
2020-06-24T21:19:38.2101347Z   File "/usr/share/miniconda/lib/python3.7/asyncio/base_events.py", line 587, in run_until_complete
2020-06-24T21:19:38.2101784Z     return future.result()
2020-06-24T21:19:38.2102341Z   File "/home/runner/work/dffml/dffml/dffml/util/cli/cmd.py", line 234, in _main
2020-06-24T21:19:38.2102773Z     result = await cls.cli(*args)
2020-06-24T21:19:38.2103424Z   File "/home/runner/work/dffml/dffml/dffml/util/cli/cmd.py", line 220, in cli
2020-06-24T21:19:38.2108592Z     return await cmd.do_run()
2020-06-24T21:19:38.2112982Z   File "/home/runner/work/dffml/dffml/dffml/util/cli/cmd.py", line 200, in do_run
2020-06-24T21:19:38.2113496Z     return [res async for res in self.run()]
2020-06-24T21:19:38.2114029Z   File "/home/runner/work/dffml/dffml/dffml/util/cli/cmd.py", line 200, in <listcomp>
2020-06-24T21:19:38.2114473Z     return [res async for res in self.run()]
2020-06-24T21:19:38.2114982Z   File "/home/runner/work/dffml/dffml/dffml/cli/ml.py", line 69, in run
2020-06-24T21:19:38.2115419Z     self.model, self.sources, update=self.update, keep_record=True
2020-06-24T21:19:38.2116018Z   File "/home/runner/work/dffml/dffml/dffml/high_level.py", line 503, in predict
2020-06-24T21:19:38.2123617Z     async with sources() as sctx, model() as mctx:
2020-06-24T21:19:38.2124036Z   File "/home/runner/work/dffml/dffml/dffml/util/asynchelper.py", line 48, in __aenter__
2020-06-24T21:19:38.2124387Z     self.data.append(await self.__stack.enter_async_context(citem))
2020-06-24T21:19:38.2124735Z   File "/usr/share/miniconda/lib/python3.7/contextlib.py", line 570, in enter_async_context
2020-06-24T21:19:38.2125033Z     result = await _cm_type.__aenter__(cm)
2020-06-24T21:19:38.2125355Z   File "/home/runner/work/dffml/dffml/dffml/source/df.py", line 54, in __aenter__
2020-06-24T21:19:38.2125628Z     self.parent.config.dataflow = DataFlow._fromdict(**exported)
2020-06-24T21:19:38.2125955Z   File "/home/runner/work/dffml/dffml/dffml/df/types.py", line 639, in _fromdict
2020-06-24T21:19:38.2126217Z     kwargs.update(cls._resolve(kwargs))
2020-06-24T21:19:38.2126701Z   File "/home/runner/work/dffml/dffml/dffml/df/types.py", line 791, in _resolve
2020-06-24T21:19:38.2126977Z     f"While resolving {instance_name}.{arg}, missing {definition_name}"
2020-06-24T21:19:38.2127236Z dffml.df.types.DefinitionMissing: While resolving resize.outputs, missing resize.outputs.result

Related: #735
This is because we haven't updated the definition names in the create dataflow command to their shorthand names.


Automatic folding/collapsing of specified HTML tags (ie. ) on file load

I would like to make PHP Storm fold specific tags on file open.
I have a file with SVG image inline:

            <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 12 12">
              <path class="stroke" d="M6,1V11"
                    style="fill: none;stroke-linecap: square;stroke-linejoin: round;stroke-width: 2px" />
              <path class="stroke" d="M11,6H1"
                    style="fill: none;stroke-linecap: square;stroke-linejoin: round;stroke-width: 2px" />
            </svg>
            Add

But just after a few such elements HTML is getting messy. Code is much clearer when I fold this tag. Then I see only one line for whole image:

            <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 12 12">... (folded)
            </svg>
            Add

It's much clearer. But now I need to fold them manually.
I see is as list of tags that are collapsed by default when I open HTML file (for me it's SVG, but maybe someone would like to add other tags).

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

[html] fold attributes (#57520)

I've checked it. Unfortunately it's not relevant.

dup of https://github.com/microsoft/vscode/issues/40338


Misses half of the player in Elden ring Arena

Half of the player are missed from by the app - tested over multiple back to back arena session. The very first session almost never misses, which lead me to believe It might have to do with back to back queuing

Hi, the reason for this is that the peer detection method currently isn't very reliable when you are the owner of your session's Steam lobby (in the arena, you should expect to be the lobby owner about 50% of the time). In non-arena multiplayer, that player is the host.
I see 2 possible fixes for this problem:

Return to the detection method used by my Dark Souls 3 tool, which involves periodically fetching the list of recently encountered players and checking for active P2P connections. I didn't do this at first because Elden Ring used to not add players on this list (until update 1.04).
It may also be possible to fix this by using log_matchmaking_callbacks in the Steam console and making use of the LobbyChatUpdate callback dumps to find peers.

I don't currently have time to work on this project, and one of the next ones I will be working on will be an Elden Ring specific tool that uses an internal Steam hook to provide detailed connection information and more (like player character names, rune levels, etc). However, if anyone is willing to implement these things and submit a PR, I will happily accept it.


Error: linking with cc failed

When using test-tube as an execution environment I run into the following error:
error: linking with `cc` failed: exit status: 1
|
  = note: LC_ALL="C" PATH="/Users/robin/.rustup/toolchains/stable-aarch
  // a dump....
  ct/abstract/framework/target/debug/deps/authz-2cb5cbbc2d1e019a" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: ld: warning: ignoring file /Users/robin/Programming/Abstract/abstract/framework/target/debug/deps/libosmosistesttube.dylib, building for macOS-arm64 but attempting to link with file built for macOS-x86_64
          Undefined symbols for architecture arm64:
            "_AccountNumber", referenced from:
                test_tube::runner::app::BaseApp::create_signed_tx::heeb23fb2f1dc67e9 in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
            "_AccountSequence", referenced from:
                test_tube::runner::app::BaseApp::create_signed_tx::heeb23fb2f1dc67e9 in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
            "_BeginBlock", referenced from:
                test_tube::runner::app::BaseApp::run_block::h35beeb6f6973b738 in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
                test_tube::runner::app::BaseApp::run_block::h4f5cf920549feaf9 in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
                test_tube::runner::app::BaseApp::run_block::h9d5e1886d063572f in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
                test_tube::runner::app::BaseApp::init_account::hb6c1758ff816e7c9 in libtest_tube-32dac9dd450a6ea7.rlib(test_tube-32dac9dd450a6ea7.test_tube.585259ba-cgu.7.rcgu.o)
            "_EndBlock", referenced from:
                test_tube::runner::app::BaseApp::run_block::h35beeb6f6973b738 in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
                test_tube::runner::app::BaseApp::run_block::h4f5cf920549feaf9 in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
                test_tube::runner::app::BaseApp::run_block::h9d5e1886d063572f in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
                test_tube::runner::app::BaseApp::init_account::hb6c1758ff816e7c9 in libtest_tube-32dac9dd450a6ea7.rlib(test_tube-32dac9dd450a6ea7.test_tube.585259ba-cgu.7.rcgu.o)
            "_Execute", referenced from:
                _$LT$test_tube..runner..app..BaseApp$u20$as$u20$test_tube..runner..Runner$GT$::execute_multiple_raw::_$u7b$$u7b$closure$u7d$$u7d$::h2352f24e142551de in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
                _$LT$test_tube..runner..app..BaseApp$u20$as$u20$test_tube..runner..Runner$GT$::execute_multiple_raw::_$u7b$$u7b$closure$u7d$$u7d$::h514c07ab6259dcc1 in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
                _$LT$test_tube..runner..app..BaseApp$u20$as$u20$test_tube..runner..Runner$GT$::execute_multiple_raw::_$u7b$$u7b$closure$u7d$$u7d$::h6fe04a9bd8ec67c7 in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
            "_InitAccount", referenced from:
                test_tube::runner::app::BaseApp::init_account::hb6c1758ff816e7c9 in libtest_tube-32dac9dd450a6ea7.rlib(test_tube-32dac9dd450a6ea7.test_tube.585259ba-cgu.7.rcgu.o)
            "_InitTestEnv", referenced from:
                test_tube::runner::app::BaseApp::new::h1f50c7e5febe166b in libtest_tube-32dac9dd450a6ea7.rlib(test_tube-32dac9dd450a6ea7.test_tube.585259ba-cgu.7.rcgu.o)
            "_Query", referenced from:
                _$LT$test_tube..runner..app..BaseApp$u20$as$u20$test_tube..runner..Runner$GT$::query::h6e7977d2643c0655 in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
            "_Simulate", referenced from:
                test_tube::runner::app::BaseApp::simulate_tx::h69440b7504931d3f in authz-2cb5cbbc2d1e019a.pofc1mhaai8ywix.rcgu.o
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

Are there any pre-requisites that I might not have installed? I didn't see any in the readme.
Running on an M1 max.

Looks like this is because osmosisd only supports x86.
https://docs.osmosis.zone/osmosis-core/osmosisd/

I got this just now on our CI: https://github.com/mars-protocol/red-bank/actions/runs/5621988241/job/15233817436?pr=267
Not sure why it happened. I managed to solve it by running the job on macos-latest instead of ubuntu-latest.

@CyberHoward Are you running linux? Perhaps its a linux issue.

No, running the latest Mac OS.

Also seeing this. looks like test-tube/packages/osmosis-test-tube/libosmosistesttube is build for x86 and when running on mac os M1/2 linking for arm architecture fails
cc @iboss-ptk

Also having this issue. Makes it more annoying to write tests with this library... and it's so nice I want to use it.

I also have the same issue running on Apple M1 Max

A temporary fix I've found is to run the test in a x86 docker container: https://gist.github.com/CyberHoward/f28ab16382b145be86d62914155196c9
But it's a lot slower.

@CyberHoward @njerschow @j0nl1 @JakeHartnell
I was really wondering about this issue since I'm on m1 max as well and there is no issue.
But one possibility might be because of rust toolchain .
run rustup show and check if active toolchain some variant of *-aarch64-apple-darwin
you might be on x86_64-apple-darwin and other things might work for some reason I'm unsure of but this might cause linker to confuse.

stable-aarch64-apple-darwin (default)
rustc 1.72.0 (5680fa18f 2023-08-23)

Running the aarch toolchain.

Then how about
export GOOS="darwin"
export GOARCH="arm64"

Did that, now the osmosis-test-tube build fails:
error: failed to run custom build command for `osmosis-test-tube v19.0.0`
note: To improve backtraces for build dependencies, set the CARGO_PROFILE_TEST_BUILD_OVERRIDE_DEBUG=true environment variable to enable debug information generation.

Caused by:
  process didn't exit successfully: `abstract/modules/target/debug/build/osmosis-test-tube-066cc009cbc73844/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=./libosmosistesttube

  --- stderr
  go: no Go source files
  thread 'main' panicked at 'failed to build go code', /Users/robin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/osmosis-test-tube-19.0.0/build.rs:114:9
  stack backtrace:
     0: rust_begin_unwind
               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panicking.rs:593:5
     1: core::panicking::panic_fmt
               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panicking.rs:67:14
     2: build_script_build::build_libosmosistesttube
     3: build_script_build::main
     4: core::ops::function::FnOnce::call_once

Thanks for the help btw, happy to try some more suggestions.

In summary doing the following fixed the issue for me:
cargo clean
export GOOS="darwin"
export GOARCH="arm64"
export CGO_ENABLED=1

@JakeHartnell @njerschow @j0nl1
Mind trying it out and letting us know if it worked?

@CyberHoward  Nice!
Out of curiosity, what's the output of your go version?

@CyberHoward Nice!
Out of curiosity, what's the output of your go version?

go version go1.19.4 darwin/amd64

Oh, that's probably why. Mine is go1.20.4 darwin/arm64.

darwin/amd64 is for x86-64 arch

Same here with an M2 mac, im running go version go1.21.3 darwin/arm64. Haven't been able to resolve it even with @CyberHoward's fix above

Update, works for me with latest versions. Also running it in DAO DAO CI: https://github.com/DA0-DA0/dao-contracts/blob/95e4f73a170705deeb3689341c51f3a3b126e3e9/.github/workflows/test_tube.yml

OP issue is resolved, please open new issue if there is any similar one.


Added support for nested arguments.

Hi,
I couldn't find a way to declare nested arguments, so I decide to propose an implementation.
Please take a look and let me know if this makes sense, of maybe there's a better way to handle the issue.
Thanks in advance.

The proposed solution doesn't provide any support for nested arguments beyond telling the parse to expect certain keys in the nested object. This would fail for lists. Other marshaling libraries have better support for nested inputs (see discussion in #335).
...also merge conflicts... :boom:

webargs has the feature you want!

...also merge conflicts...

@joshfriend with all respect, it's project maintainers fault the PRs stalled. So it's not :boom: it's :-1:
I'm not sure if you or @skimbrel is responsible for making this decision, but the answer I was expecting was not about whenever this is good to merge or not, it is about whenever flask-restful wants this functionality or not?!
If the project maintainers decide to remove reqparse support, I will start looking for alternatives, otherwise I don't see the reason this issue got closed.


Create Capact images tarball and put in release assets

Description
Add a step to our Capact release which will create an archive and upload it as GitHub release artefact.
Script which does the release: https://github.com/capactio/capact/blob/main/hack/make-release.sh
AC

Create archive (compressed, as GitHub allows only up to 2 GB per asset)
capact alpha archive-images helm -v --version ${CAPACT_VERSION} -o ./capact-images-amd64.tar.gz --compress gzip

Put the archive in release assets:

Use gh cli: gh release upload (source: https://cli.github.com/manual/gh_release_upload)
or use GitHub action, e.g. https://github.com/AButler/upload-release-assets

Reason
Currently, user needs to execute that manually, and it takes time to create such archive. The images in a given release are "hardcoded" we can prepare such archive upfront.

@mszostok @pkosiec I would like to give this issue a shot. Please let me know how to onboard myself with it & I can start.


Cast UUID to string, because XlsxWriter can't write it

Apparently this is a deliberate feature of XlsxWriter, because it tries to convert Python types to native Excel types, and there is no native UUID type in Excel. The suggestion is that if you want something mapped to string, you should do it before writing it to XlsxWriter.

If you can remove the extra migration file, I'm happy to merge. Thanks!

OK, I've removed the extra migration.

Thanks!


Refactor authentication feature helpers for specs

While working on https://trello.com/c/6qASsHQl I found some strange behaviour in a test I had written. It took me a while to figure out what was going on, partly because the code defining how users work in tests was located in several different places. This PR brings it all together, to hopefully make people's lives easier in future, and also to make it easier to stop relying on the gds-ssomock authentication strategy in future.

I think this PR is showing as closed rather than merged because I merged it just as GitHub was having an issue (I didn't realise it was having an issue when I merged it). But the commits are in main!


Add WiredTiger to vcpkg

http://source.wiredtiger.com/3.2.0/index.html

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


add bundle and un bundle file

May I know what it means "add bundle and un bundle file"?
Sorry I am pretty new.
Also, may I know if there is a plan to versioning the library? Because its kinda really hard to see what have changed from one version to another if anything has been done. Its just really pain has to go back and read comment of each commit...
Not sure if its reasonable :)
Thanks

This is totally reasonable and I should be doing this.

yea, sorry about that. This was created before I knew about semver. Going in today and fixing that. The bundle is ngFx with all the dependencies it needs to work.

all fixed in version 1.1.0


Implemented hibp. Solves #2476

Implemented hibp. Solves #2476

Hmm, confusing.. Tests are working on WIndows locally but seem to fail here 😵

Okey @waldekmastykarz added a single log line to see what happens and (while not sure why it doesn't do work) I am one step further:

The line console.log(loggerLogSpy.getCall(0).args); // eslint-disable-line no-console returns TypeError: Cannot read property 'args' of null (if I do not add a null check)
So it looks like the loggerspy is never populated with results ... I cannot explain why that would be the case on windows though .. Must be me screwing up somewhere..

Any other idea's :D?

Not off the top of my head. Let me have a look at it and get back to you.

It's odd: locally, all tests are passing for me 🤔

I wonder if it could be related to the fact that we're trying to assert stub call with an array with an object that's different from the actual object sent to the log (the difference is in the fact that we're creating two separate instances of what's inside the array so the reference isn't the same). We could test if this is the case, by changing the assert to compare JSON.stringify values of args of the last call to logger and what we assume it should be, like:
assert.strictEqual(loggerLogSpy.lastCall.args[0], JSON.stringify([{ "Name": "Adobe" }]));

I wonder if it could be related to the fact that we're trying to assert stub call with an array with an object that's different from the actual object sent to the log (the difference is in the fact that we're creating two separate instances of what's inside the array so the reference isn't the same). We could test if this is the case, by changing the assert to compare JSON.stringify values of args of the last call to logger and what we assume it should be, like:
assert.strictEqual(JSON.stringify(loggerLogSpy.lastCall.args[0]), JSON.stringify([{ "Name": "Adobe" }]));

Weird thing is that if I run that test I get an error that the loggerLogSpy.lastCall === null (and thus has no args) 😵

Perhaps it would help to check if the command returns an error, by adding an extra assert: assert.strictEqual(err, undefined)

One million commits later 🥳, turns out my bad; implemented the AnonymouysCommand from the wrong place, that in itself did not throw an error, but does explain why it wasn't working. After fixing that I got a bunch of linting errors (forgot a , and added a space on a place that was not allowed). After fixing those it turns out I missed a test case for logging an error and additional validation ... What a mess I have made 😂 All works good, pay attention to the fact that it now has 8 commits  #sorry

Merged manually. Thank you! 👏


(feature) Dynamically loaded botpress.com/download links

Add this to website so that the download links automatically points to first non-pre-release version.
const url = "https://api.github.com/repos/botpress/botpress-electron/releases"
axios.get(url).then(({data})=>{
  const legitReleases = data.filter(({draft,prerelease})=>{
    return draft === false && prerelease === false
  })
  legitReleases.sort((a,b)=>{
    return a.published_at > b.published_at ? -1 : a.published_at < b.published_at
  })

  const firstLegitRelease = legitReleases[0]

  const dmgUrl = firstLegitRelease.assets.find(({name})=>{
    return name.slice(-4) === ".dmg"
  }).browser_download_url

  const snapUrl = firstLegitRelease.assets.find(({name})=>{
    return name.slice(-5) === ".snap"
  }).browser_download_url

   const exeUrl = firstLegitRelease.assets.find(({name})=>{
    return name.slice(-4) === ".exe"
  }).browser_download_url

   console.log({
     dmgUrl,snapUrl,exeUrl
   })
})

This is solved. You can see the new download links on botpress.com/download. Also, I just pushed a new release, and the changes were propagated to the download page as expected! Thanks Janin!


Can't change pyright settings: python.analysis.typeCheckingMode doesn't turn off

Problem description
Can't change the setting, the server schema says that its still on "basic" instead of the "off" that i've defined.
Neovim version (>= 0.6)
NVIM v0.7.0-dev+665-g4e352ecc4
Build type: RelWithDebInfo
LuaJIT 2.0.5
Operating system/version
Linux project-jenova 5.13.19-2-MANJARO #1 SMP PREEMPT Sun Sep 19 21:31:53 UTC 2021 x86_64 GNU/Linux
I've recently downloaded the latest plugin version of both nvim-lsp-installer and nvim-lspconfig

[ ] Yes

Affected language servers
pyright
Actual behavior
I've defined the settings as

	if server.name == 'pyright' then
		opt['settings'] = {
				python = {
						analysis = {
								typeCheckingMode = "off"
							}
					}
			}
	end

It shouldve been turned off.
Expected behavior
Doesnt turn off.

Healthcheck output
All ok

Screenshots
No response

Hello! Ah, the schema that is displayed there is static. It only shows the configuration schema that the server provides, it doesn't apply any changes you've made in your own settings on top of that.
Apart from that UI not showing your custom settings, does it not work?

One thing that might be worth checking @bryangeplant (or other people who bump into this) is that you don't have this setting set in pyproject.toml: with
[tool.pyright]
typeCheckingMode = "strict"

I noticed that the pyproject.toml setting was overriding my lsp setting.


chore: Mobile Drivers License (mDL) context

closes #35
Signed-off-by: Rolson Quadras<EMAIL_ADDRESS>

Sample VC:
{
    "@context": [
        "https://www.w3.org/2018/credentials/v1",
        "https://raw.githubusercontent.com/rolsonquadras/context/issue-35/mDL/v1.jsonld"
    ],
    "credentialSubject": {
        "birthdate": "1993-12-05",
        "document_number": "S9OBVU5HAS2MXFJ",
        "driving_privileges": [
            "Car"
        ],
        "expiry_date": "2025-05-26",
        "family_name": "Doe",
        "given_name": "John",
        "issue_date": "2020-05-27",
        "issuing_authority": "Ontario Ministry Of Transport",
        "issuing_country": "CA",
        "type": "mDL"
    },
    "id": "http://example.com/e0368452-9fa4-4b2a-b008-a9fdb3430c65",
    "issuanceDate": "2020-08-11T16:48:54.7042751Z",
    "issuer": {
        "id": "did:trustbloc:testnet.trustbloc.local:EiBsKZtIjNljW6mdj1--XB46G96nkOW3dhGuk8h3x25wgg",
        "name": "trustbloc-ed25519signature2018-ed25519"
    },
    "proof": {
        "created": "2020-08-12T19:40:08.5139944Z",
        "jws": "eyJhbGciOiJFZERTQSIsImI2NCI6ZmFsc2UsImNyaXQiOlsiYjY0Il19..lL8kidF2vjk8uM3tiHmjsh6JvoCL6lun8lYkbLjBHk31xlwiW-_u9BZ9DoDKkGtzB3QDrWbkNfVTtYq4194fBQ",
        "proofPurpose": "assertionMethod",
        "type": "Ed25519Signature2018",
        "verificationMethod": "did:trustbloc:testnet.trustbloc.local:EiBMZr24laluTrahqGmwCEEb9oTnxFq141-DmS4cDHmIMw#gyeyKTd2QqVVhuntCTNT"
    },
    "type": [
        "VerifiableCredential",
        "mDL"
    ]
}

@rolsonquadras please link to the spec

@rolsonquadras please link to the spec

@mavarley can you provide the public link for the spec ?

Related issues #40, #41 and #42.

Which spec? There is no working draft of a Verifiable Credential for mDL. The current mDL spec is defined in ISO 18013.

Link: file:///tmp/mozilla_llorllale0/ISO-IECJTC1-SC17-WG10_N1818_ISO_IEC_DIS_18013-5_E.pdf

Link: https://isotc.iso.org/livelink/livelink?func=ll&objId=20919524&objAction=Open

I would suggest we change the name from 'mDL' to 'mDLdemo' or something similar. "mDL" is a defined Standard term in the ID industry and we are not trying to propose this as a Standard -  this is for our demo purposes only (closely aligned on what we think the Standard may eventually look like).

I would suggest we change the name from 'mDL' to 'mDLdemo' or something similar. "mDL" is a defined Standard term in the ID industry and we are not trying to propose this as a Standard - this is for our demo purposes only (closely aligned on what we think the Standard may eventually look like).

@mavarley May be I can move this to /examples folder, so that we are clear about the status of this credential (that it's an example and not a standard). Let me know what you think. If this doesn't work, I can rename the type as you suggested.

@mavarley May be I can move this to /examples folder, so that we are clear about the status of this credential (that it's an example and not a standard). Let me know what you think. If this doesn't work, I can rename the type as you suggested.

Ok I'll let you decide based on the following criteria:

If we intend to keep this definition in sync with an emerging Standard as it develops (whenever that is...), then drop it in /examples
If we just need this for a few short-term demos and plan on abandoning it when a Standard starts to develop, then rename it

I think the answer is (1 -we will try and keep it current) but I'll let the team decide.
Thanks!

@mavarley May be I can move this to /examples folder, so that we are clear about the status of this credential (that it's an example and not a standard). Let me know what you think. If this doesn't work, I can rename the type as you suggested.

Ok I'll let you decide based on the following criteria:

If we intend to keep this definition in sync with an emerging Standard as it develops (whenever that is...), then drop it in /examples
If we just need this for a few short-term demos and plan on abandoning it when a Standard starts to develop, then rename it

I think the answer is (1 -we will try and keep it current) but I'll let the team decide.
Thanks!

I too feel #1 would be better. It'll force us to be upto date with the standard as well.
@mavarley I have moved to /examples folder.


KeyboardInterrupt doesn't interrupt (parallel scheduling)

The KeyboardInterrupt handling in Luigi does not stop processing.
If a child receives the KeyboardInterrupt while processing specific tasks, the child will cleanup and close the tasks.  (Spark and Pig come to mind).  However, if the main process handles the KeyboardInterrupt, it doesn't tell the existing workers to stop.
As is, Worker.add() raises the exception, but doesn't tell any of the existing workers to stop.
Adding a pool.terminate() to the KeyboardInterrupt exception handler in Worker.add() would handle this issue.  The various tasks that call out to external tools (such as Spark and Pig) already handle SIGTERM gracefully.

This would be great to fix. Thanks for raising this. It's really annoying when libraries do this

:+1:

Since I was pestered with this issue myself, I took a stab at this in #1427. Feel free to review it :)

Updated name to reflect the bugfix in #1429. Most users (who I assume don't do parallel scheduling) shouldn't face any issues anymore.

@Tarrasch  should I assume this won't be fixed or Should we keep it open?

I'm closing this issue.

[x] It has been inactive for +4 months.
[ ] It's not about luigi core, so not as many users are affected about this.
[ ] The change seems quite big, it's unlikely to be sporadically picked up.
[ ] The owner haven't responded or disappeared.
[ ] I don't understand what this issue is about.
[ ] There exists a reasonable workaround for this.
[ ] We need to check if this hasn't been fixed by now (for old issues).
[ ] This is kind of by design and not a bug.
[ ] Resolving this would probably add a lot of complexity.

Every open issue adds some clutter, and we try to make the issues fewer and make it easier for new collaborators to find. Currently we try to close any issue that meets the first checkbox + one other.
Feel free to reopen this issue at any point if you have the intent to continue to work this. :)

I close it. Anyone interested please see https://github.com/spotify/luigi/pull/1429.


Add a sample setup for performance benchmarking in security plugin

It would be nice to have a documented set of steps for contributors to follow when benchmarking any performance improvement code changes that they make as part of their contribution. They post these on PRs to facilitate better visualization for reviewers, and can serve as a reference for future.

[Triage] @DarshitChanpura to follow-up on this.


Added custom reservoir support

Reservoir as an important feature is missing in current metrics-clojure. It allows histogram based metrics (histogram and timer) to drop some data based on custom strategy (uniform, sliding window, etc). This is helpful when we want to collect timer for last minute, for example.
The bad part is upstream API doesn't provide entry point for custom reservoir in MetricRegistry, so there is no way to use this feature with MetricRegistry's get-or-add API. Duplicated creation will lead to IllegalArgumentException. So I created new function for timer and histogram.
@michaelklishin @sjl PTAL

@michaelklishin Thanks for fast response. I just updated the style.

Thank you!

@michaelklishin  possible to make a release for this?

@sunng87 I'll try making one over the weekend.

@sunng87 2.7.0 is up on Clojars.

@michaelklishin Excellent! Thank you!