bento/_config.py in edf9bee0f8fb2ed992e (Failure to install executables on Windows)

This is with edf9bee0f8fb2ed992e (since edf9bee0f8fb2ed992e..eb8b312f51563e37b8d58 do not install properly on Windows).
Another Windows issue:
Consider this bento.info file (it's boiled down):
Name: bentotest
Author: Friedrich Romstedt
Summary: Bento project for testing Bento

Library:
    Modules: bentotest

Executable: bentotestscript
    Module: bentotest
    Function: foo

If you leave out the Executable section, everything's fine.
Now the traceback is:
  File "C:\Programme\Python 2.7.1\lib\site-packages\bentomakerlib\bentomaker.py", line 363, in noexc_main
    ret = main(argv)
  File "C:\Programme\Python 2.7.1\lib\site-packages\bentomakerlib\bentomaker.py", line 151, in main
    _wrapped_main(popts)
  File "C:\Programme\Python 2.7.1\lib\site-packages\bentomakerlib\bentomaker.py", line 189, in _wrapped_main
    return _main(popts)
  File "C:\Programme\Python 2.7.1\lib\site-packages\bentomakerlib\bentomaker.py", line 242, in _main
    run_cmd(cmd_name, cmd_opts)
  File "C:\Programme\Python 2.7.1\lib\site-packages\bentomakerlib\bentomaker.py", line 307, in run_cmd
    run_dependencies(cmd_name, top, pkg)
  File "C:\Programme\Python 2.7.1\lib\site-packages\bentomakerlib\bentomaker.py", line 270, in run_dependencies
    run_cmd_in_context(cmd_klass, cmd_name, cmd_argv, ctx_klass, top, pkg)
  File "C:\Programme\Python 2.7.1\lib\site-packages\bentomakerlib\bentomaker.py", line 347, in run_cmd_in_context
    cmd_func(ctx)
  File "C:\Programme\Python 2.7.1\lib\site-packages\bento\commands\build.py", line 96, in run
    self.section_writer.update_sections(ctx.pkg)
  File "C:\Programme\Python 2.7.1\lib\site-packages\bento\commands\build.py", line 131, in update_sections
    self.sections[name].update(updater(pkg))
  File "C:\Programme\Python 2.7.1\lib\site-packages\bento\commands\build.py", line 205, in build_executables
    ret[name] = create_win32_script(name, executable, bdir)
  File "C:\Programme\Python 2.7.1\lib\site-packages\bento\commands\script_utils.py", line 134, in create_win32_script
    fid = open(launcher, "rb")
bentomaker: Error: bentomaker crashed (uncaught exception <type 'exceptions.IOError'>: [Errno 2] No such file or directory: 'C:\\Programme\\Python 2.7.1\\share\\commands\\cli.exe').
Please report this on bento issue tracker:
    http://github.com/cournape/bento/issues

It tracks down to site-packages/bento/_config.py:22:
# Windows binaries
_CLI = os.path.join(ARCH_DATA_DIR, "commands", "cli.exe")

The cli.exe is present, but at site-packages/bento/commands/cli.exe.  Guess that's where it is intended to live.
The problem boils down to that, on bootstrapping, the logic succeeds, but when it comes to generating executables from the installed bento, then ARCH_DATA_DIR no longer holds "commands/cli.exe".
I think a good remedy would be to add some config variable, say $subprocessexecdir, where cli.exe et al. go.  For the case of bootstrapping, this could fallback to the same dir as it does currently.
If __config_py.py is written after the other modules, would it be possible to put a __config_py.py with bootstrap-suitable defaults in the source?
Would it be a good idea to rename _config.py to pathes.py?
Shouldn't BUILD_DIR = (...) use os.path.join()?
After installation of bento, parsetab currently gets written to DATA_DIR (i.e. shared/) by _config.py.  Wouldn't it be better placed in os.path.join(DATA_DIR, 'bento', 'parsetab') (i.e. shared/bento/parsetab) or even os.path.join(BUILD_DIR, 'parsetab')?  (I found this parsetab in shared/ and thought it was a bug!)

All the issues you raised have been fixed I believe:

parsetab is now correctly installed in shared/bento subdirectory
*.exe are installed in shared/bento as well instead of living in site-package
your example should work on windows


On login error: object is not an instance of....

Unsure how to reproduce, may have to do with timing of hooks and requests

have not encountered since


Cleanup target include directories and libraries

This PR:

switches to use target_include_directories instead of include_directories to convey the dependency headers to the dependent libraries
changes utils-urdf to optional component

Coverage remained the same at 85.089% when pulling eb7c4897101bb66855c243109f10933deea78abb on build/target_dependencies into 6779dd2438c84a5ecdef5978bd88ef25b03096ac on master.

It looks like we lost the target_compile_options you added in #114. Was that intentional?

It's intentional. I removed it for targets that have dependencies of other Aikido targets that already includes the compile options not to duplicate the options. Adding the same options multiple times wouldn't hurt anything, but it (not duplicating) would be clearer I think.

Coverage remained the same at 85.208% when pulling 95d316c519c5bee64acc3d3bb9e78b191eecd55f on build/target_dependencies into bc5308261b8ff3d209d2726ac2d95e8181f16488 on master.

Coverage remained the same at 85.208% when pulling 95d316c519c5bee64acc3d3bb9e78b191eecd55f on build/target_dependencies into bc5308261b8ff3d209d2726ac2d95e8181f16488 on master.

It's intentional. I removed it for targets that have dependencies of other Aikido targets that already includes the compile options not to duplicate the options. Adding the same options multiple times wouldn't hurt anything, but it (not duplicating) would be clearer I think.

I disagree. If the target requires those flags, then it should specify them. Otherwise we'll get into trouble if we ever change the dependency relationship between Aikido components. This is hairy enough to debug already that I'd prefer to not add more implicit constraints. 😬
@psigen Thoughts?

I disagree. If the target requires those flags, then it should specify them. Otherwise we'll get into trouble if we ever change the dependency relationship between Aikido components. This is hairy enough to debug already that I'd prefer to not add more implicit constraints.

It makes sense. I don't have a strong preference here so am fine with explicitly listing necessary flags and dependencies. To be clear, we would like to add all the necessary external dependencies to each Aikido targets (using target_link_libraries()), right?

Coverage remained the same at 85.208% when pulling b1b77ec94e0a1a03270ae5569e86811a49892905 on build/target_dependencies into bc5308261b8ff3d209d2726ac2d95e8181f16488 on master.

Addressed @mkoval 's comment I believe.

Coverage decreased (-0.02%) to 85.19% when pulling 63024f2f2eae3f56c923598d948cc33d279c96ea on build/target_dependencies into bc5308261b8ff3d209d2726ac2d95e8181f16488 on master.

Coverage decreased (-0.02%) to 85.19% when pulling a6add5185581d7d051f85651cf3f5b5a7e841afe on build/target_dependencies into bc5308261b8ff3d209d2726ac2d95e8181f16488 on master.

Coverage decreased (-0.02%) to 85.19% when pulling 54d672ef39568f59f2da9ef89a562458b5f971c9 on build/target_dependencies into a59975f7b726a3ff83fecd3e18510a5ba8eba30c on master.


contact form wrap

Fixes Issue
Changes proposed

Screenshots
https://www.awesomescreenshot.com/video/19770142?key=35eed0308a78ded81dfd94e76a58ad52
Note to reviewers

#626


Make usable as a library

Soon after I published this to a Maven repository, I noticed, that one cannot use this as a library. I've changed my own fork a lot and after a lot of googling and browsing through the Cucumber Java source code found that it is indeed possible to use the step definitions from this library:
https://github.com/geekdenz/selenium-cucumber-java/blob/fb23d90fee928718458370d4f9922bf46c937b20/src/test/java/stepDefintions/RunCukeTest.java#L13
Also see the README:
https://github.com/geekdenz/selenium-cucumber-java/blob/master/README.md#using-canned-tests-in-your-project
You are more than welcome to merge these changes in. I also made it so that if a test fails, it makes a screenshot and puts it into the directory with the scenario ID.
Also, I made the headless Firefox the default driver, so this can be used on a build server. For this some libraries may need to be installed:
sudo apt install libgtk-3-0 libdbus-glib-1-2 xvfb

@geekdenz thanks for putting your efforts to contribute this library
I will check and merge soon.

@geekdenz can you provide  examples/tests using selenium-cucumber-java as a library?

I will create a sample project soon.

Here you go: https://github.com/geekdenz/selenium-cucumber-java-examples
Hope it works for you. It seems to work fine on Linux. For Windows and MacOS you may need to download the OS's web drivers for Firefox etc.

@geekdenz I ran the example, its not picking up pre-defined steps from library as it showing steps not implemented errors.

@sameer49 This is bizarre since it works perfectly for me. Are you using ./gradlew on Linux?

No I am using on Windows
And with maven as well same issue
On Sep 8, 2017 11:45 AM, "Tim-Hinnerk Heuer"<EMAIL_ADDRESS>wrote:

@sameer49 https://github.com/sameer49 This is bizarre since it works
perfectly for me. Are you using ./gradlew on Linux?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/selenium-cucumber/selenium-cucumber-java/issues/12#issuecomment-328009130,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHSlNJxXxUcab5-X44bBcqzgOpiZr9Gdks5sgNtkgaJpZM4PMQPm
.

Can you please try with gradlew? It works even when you don't have it installed and gradle is more powerful than maven. Android uses it as its default build system and it has a Turing complete scripting language in the bills tool.  You will need the driver in the same directory on windows. I can look into making it work with Maven later maybe, although I don't know why you would use maven over gradle tbh.

If you really want to use Maven, you need to look at the test task in the build.gradle file for its parameters to make it work and possibly write a maven plugin if it doesn't support the same options with xml or an existing plugin.

I tried with gradle as well
Actually its not build issue its not able to link pre defined step
definitions from library.
On Sep 8, 2017 6:48 PM, "Tim-Hinnerk Heuer"<EMAIL_ADDRESS>wrote:

Can you please try with gradlew? It works even when you don't have it
installed and gradle is more powerful than maven. Android uses it as its
default build system and it has a Turing complete scripting language in the
bills tool. You will need the driver in the same directory on windows. I
can look into making it work with Maven later maybe, although I don't know
why you would use maven over gradle tbh.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/selenium-cucumber/selenium-cucumber-java/issues/12#issuecomment-328100894,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHSlNPzx-i34xJ7wAynRgWS3phJmP0WAks5sgT6lgaJpZM4PMQPm
.

Hi @sameer49
Yeah, sorry but I assumed it would work on Windows as well, which it doesn't. It does work on Linux though, which is weird since it is Java and supposedly cross-platform. I'm looking into what might be the problem but I am getting an exception when I try to run the tests on Windows.
How did you manage to get it to a state where the tests were suggested? I don't even get that far on Windows. It fails when it tries to connect to the browser driver, although I have it in the folder.
Could you post in more detail the errors you are getting, please?

Hi @sameer49
I think it should work now also on Windows. Did some cleanup of how the DriverUtil is used to ensure there is only one instance used.
Can you please try again on Windows with Gradle?

okay

following error I got when try to run with gradle.
tk.landcare.sampletests.TestRunner STANDARD_OUT
Expected only one instance, but found too many: [cucumber.runtime.java.picocontainer.PicoFactory@493e3dd, cucumber.runtime.java.guice.impl.GuiceFactory@234a73a5]
More than one Cucumber ObjectFactory was found in the classpath
You probably may have included, for instance, cucumber-spring AND cucumber-guice as part of
your dependencies. When this happens, Cucumber falls back to instantiating the
DefaultJavaObjectFactory implementation which doesn't provide IoC.
In order to enjoy IoC features, please remove the unnecessary dependencies from your classpath.
Feature: Learning selenium-cucumber using java
  As a tester I want to learn selenium-cucumber

tk.landcare.sampletests.TestRunner > Scenario: I am learning selenium-cucumber.classMethod STARTED
tk.landcare.sampletests.TestRunner > Scenario: I am learning selenium-cucumber.classMethod STANDARD_OUT
Failure in before hook:PredefinedStepDefinitions.before()
Message: org.openqa.selenium.WebDriverException: org.apache.http.conn.HttpHostConnectException: Connect to localhost:23911 [localhost/<IP_ADDRESS>, localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connect

When I run using maven it opens multiple instance of browser and at end it shows all test steps as pass but scenario fail.
https://github.com/selenium-cucumber/selenium-cucumber-java-maven-example
Failed scenarios:
features/my_first.feature:4 # Scenario: I login with valid credential
1 Scenarios (1 failed)
6 Steps (6 passed)
0m25.552s
java.lang.NoSuchMethodError: env.DriverUtil.closeDriver()V
at info.seleniumcucumber.stepdefinitions.PredefinedStepDefinitions.tearDown(PredefinedStepDefinitions.java:561)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at cucumber.runtime.Utils$1.call(Utils.java:40)
at cucumber.runtime.Timeout.timeout(Timeout.java:16)
at cucumber.runtime.Utils.invoke(Utils.java:34)
at cucumber.runtime.java.JavaHookDefinition.execute(JavaHookDefinition.java:60)
at cucumber.runtime.Runtime.runHookIfTagsMatch(Runtime.java:224)
at cucumber.runtime.Runtime.runHooks(Runtime.java:212)
at cucumber.runtime.Runtime.runAfterHooks(Runtime.java:206)
at cucumber.runtime.model.CucumberScenario.run(CucumberScenario.java:46)
at cucumber.runtime.junit.ExecutionUnitRunner.run(ExecutionUnitRunner.java:102)
at cucumber.runtime.junit.FeatureRunner.runChild(FeatureRunner.java:63)
at cucumber.runtime.junit.FeatureRunner.runChild(FeatureRunner.java:18)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at cucumber.runtime.junit.FeatureRunner.run(FeatureRunner.java:70)
at cucumber.api.junit.Cucumber.runChild(Cucumber.java:95)
at cucumber.api.junit.Cucumber.runChild(Cucumber.java:38)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at cucumber.api.junit.Cucumber.run(Cucumber.java:100)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)

@geekdenz it working now, in project few files ware outdated


User and Role arguments do not work, only some IDs are counted as valid

Describe the bug
When using the "User" and "Role" message command arguments, some pings/IDs are counted as valid while others arent
<user_id> is not a proper userID
Steps to reproduce
use the "User" or "Role" command arguments
Expected behavior
the command to accept the arg
Additional Context

Closed by #33

Note to self: update tests and somehow make a way for them to run in PRs


Use BigTable Columns as range keys

This PR replaces #753, fixes #714.
Should improve performance for BigTable queries as we don't need to resend the row key multiple times.
Required a fair amount of refactoring of the composite store to support changing storage client based on time, as well as schema.

I've already done a bunch of review on this, LGTM from me.

I've updated the PR, but it's not reflecting because GH has issues rn: https://status.github.com/messages
But you can put this PR back on your TODO now :) Thanks a lot for all the reviews!


Update specs2-core to 4.12.6

Updates org.specs2:specs2-core from 4.11.0 to 4.12.6.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2", artifactId = "specs2-core" } ]

labels: test-library-update, semver-minor

Superseded by #81.


Fixes PrimitiveCollection documentation issue

Fixes #8496

Thank you so much for the pull request @sanjeetsuhag! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!
The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

:x: Missing CONTRIBUTORS.md entry.

Please add yourself to the contributors file!

:x: Missing CLA.

Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!

:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

@sanjeetsuhag I added you to the CLA

Thanks @sanjeetsuhag. Congrats on your first CesiumJS contribution!


09/11/2018 05:57 : Create Pull Request for branch master -> prTesting1_2018091105

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Espresso: fix pdos test

Summary of Changes
Same issue
Checklist

[ ] I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
[ ] My PR is on a custom branch and is not named main.
[ ] I have used black, isort, and ruff as described in the style guide.
[ ] I have added relevant, comprehensive unit tests.

Notes

Your PR will likely not be merged without proper and thorough tests.
If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
When your code is ready for review, ping one of the active maintainers.

Can one of the admins verify this patch?

Freaking codecov....


fix deadlock hang when broadcast to clients

What problem are we solving?
when master thransfer leader, the old master will disconnect with all filers and volumeServers, if the cluster is a big one, the broadcast messages may be much more than the max len of the channel 100, and if the KeepConnect just not listen on the channel in disconnect, the broadcastToClients will hang. and the whole cluster will not serve!
Related to： https://github.com/seaweedfs/seaweedfs/commit/91e4eca1e98cb5195346d90a2cc1fb9c92557213
How are we solving the problem?

broadcast to client with no block, and add metirc to monitor full err
volumeServer heartbeat no need to broadcast when transfer leader

How is the PR tested?
hard code the len the message channel to 1, it's easy deadlock when transfer leader, after fix, it will not deadlock
Checks

[ ] I have added unit tests if possible.
[ ] I will add related wiki document changes and link to this PR after merging.

Nice fix!

s3 integration tests start to fail. Need to look into this.

s3 integration tests start to fail. Need to look into this.

hi， @chrislusf I ran the test locally， and all passed.

The error about test_lifecycle_get does not look related to this pr.

recheck


Pinoy Movies

Addon Manifest URL
https://dindz-addon.onrender.com/manifest.json
Addon Description
This catalog features Filipino movies sourced from TMDB, showcasing the latest Filipino releases.
Language of Content
Tagalog (tl-PH)
Choose Labels

[ ] anime
[ ] asian drama
[ ] bollywood
[ ] cartoons
[ ] debrid support
[ ] http streams
[ ] live tv
[ ] metadata
[ ] misc
[X] movies
[ ] music
[ ] nsfw
[ ] podcasts
[ ] radios
[ ] subtitles
[ ] torrents
[ ] tv shows
[ ] video games

Bin neu hir


Gracefully shutdown AbstractHandlerAdaptor's cached stubs

Close due to https://github.com/DanielLiu1123/grpc-starter/commit/8c17513b80fdc41940580216f88c4c38b31d5a7f


Cleanup safechecker

This cleans up quite a few naming problems (one could say outright nonsense :) and refactors the safechecker proof. I will split PCUICSafeChecker into PCUICTypeChecker and PCUICSafeChecker next.

This is already a bit better: I managed to make erasure independent from the safechecker (only saferetyping is needed) and to split SafeChecker into Errors/TypeChecker/SafeChecker (mainly checking of inductive decls). The last refactoring I want to do now in safechecker is to use a record wf_env to pack up the global_env/global_env_ext, its squashed well-formedness proof and associated graph and graph correctness proof to streamline the APIs.


functions in polygon_selection.py need to be removed

remove the following functions:
is_inside
filter_by_lat
filter_by_lon_lat
filter_by_magnitude

these have been deleted in the utilities-update branch


code testing & syntax/bug fix

This commit ensures that the contents from the previous commit was usable, and executed substantial testing (Beta standards) to make sure all errors are caught.

Since the source code was tested to Beta standards, and this pull request was made to merge into master, this merge will be aborted.


[flipt] Released version of @openfeature/flipt-web-provider does not support flipt entityId evaluation

The version of @openfeature/flipt-web-provider over at npmjs.com has outdated flipt dependencies.
Please release a version with updated flipt dependencies, to support flipt entityId evaluation.
The version in the open-feature/js-sdk-contrib repository has already an updated version of flipt-client-browser that supports entityId evaluation:
https://github.com/open-feature/js-sdk-contrib/blob/main/libs/providers/flipt-web
Thanks a lot!

FYI, @markphelps. Are we good to release the updated web provider?

@beeme1mr yes all good to release. i'll likely create another PR to upgrade to latest version of our browser SDK v0.3.0 https://www.npmjs.com/package/@flipt-io/flipt-client-browser later today

Any update?

@beeme1mr I believe the only thing required is to merge https://github.com/open-feature/js-sdk-contrib/pull/1098 ?
cc @ohyeahitsstef

The latest version of the Flipt web provider has been released. Sorry for the delay.

Thanks!


Rebuild for python310

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Add two common patches

https://github.com/libharu/libharu/pull/157
https://github.com/libharu/libharu/pull/187

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender


AKS Linux VHD release notes: 2021.08.28

AKS Linux VHD release notes: 2021.08.28

As per the check, this branch is out of date with master. Looks like the latest changes from the master need to be pulled. Lgtm overall.


Updating upload.yml to run Julia tests

@SamFerracin, can you add a description please? What is this doing, why and what changed? Thanks!


7.5.2 produces wrong APIGatewayAuthURL on windows

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v14.15.1
Amplify CLI Version
7.5.2
What operating system are you using?
Windows
Amplify Categories
auth, api
Amplify Commands
push
Describe the bug
After changing some options in api and upgrading from 7.5.1, i receive the following error:
templateurl must be a supported url amplify
Checking the files, with git diff show up the following:
"APIGatewayAuthURL": "https://s3.amazonaws.com/amplify-*-deployment/amplify-cfn-templates/api\APIGatewayAuthStack.json"
When i correct the \ to / after entering amplify push and before acknowledging the changes of the graphQL-Files, i can push the
Expected behavior
the url should be generated correctly on windows system
"APIGatewayAuthURL": "https://s3.amazonaws.com/amplify-*-deployment/amplify-cfn-templates/api/APIGatewayAuthStack.json"
Reproduction steps

install 7.5.1
create api (graphql with public access)/auth
install 7.5.2
update graphql to use auth (cognito user pool, instead of public)
amplify push

GraphQL schema(s)

# Put schemas below this line
type Bank @model @auth(rules: [{ allow: owner }]) {
}

Log output

# Put your logs below this line

Additional information
No response

The problems occurs everytime you call "amplify push".
If you need to publish something right now on windows, you can patch your file locally (dirty and fast :)):
<EMAIL_ADDRESS>const S3_UPLOAD_PATH = amplify_cli_core_1.AmplifyCategories.API + /${exports.APIGW_AUTH_STACK_LOGICAL_ID}.json;
it would be nice, if this bugfix will be released soon.


Browser compatible?

No real reason this couldn't be made to work in the browser as well.

Added in e7133e04cfffa78767c7eb1f9d2561e61270f38f. :tada:


Integrate etc/no-commented-out-code into PR CI

Add a eslint check for etc/no-commented-out-code into the CI to be triggered on PR

This sounds like a good idea - lets double check with our latest eslint config


Rest Endpoint - /api/v1/tokens

Implement the endpoint with all filters
Check the query time and add needed filters.
Refer to https://mainnet-public.mirrornode.hedera.com/api/v1/docs/#/tokens/listTokens

example queries:

select * from entity where type = 'TOKEN' AND entity_number = 1101476
order by consensus_timestamp desc limit 2;   [time: 5 ms]

select * from entity where type = 'TOKEN' order by consensus_timestamp desc limit 2;   [time: 6 ms]


Confirm exit screen

Adds a confirm exit screen when exiting the from the pause menu

I cannot exit from the tutorial scene. The pause menu seems to break when clicking exit.

Tutorial Pause Menu should be fixed but idk if it will update the pull request. Should I reopen it?


Fix duplicated container image tag problem

This change fix the tag duplication problem, something looks like: "ubuntu:14.04:14.04" in output container.image.
The m_imagetag actually a substring parsed from in m_image. Use m_imagerepo plus m_imagetag here to solve default tag (latest) problem.

@araujof thanks for reminding, the container tag related test case is now fixed. I've checked the under layer implementation and seen nothing out of our expectation. Is there some edge case to try?

@araujof thanks for reminding, the container tag related test case is now fixed. I've checked the under layer implementation and seen nothing out of our expectation. Is there some edge case to try?


RFP - Visual Paradigm

Visual Paradigm is a world-wide leading award-winning enterprise management and software development suite, which provides all the features you needs for enterprise architecture, project management, software development and team collaboration in a one-stop-shop solution.
https://www.visual-paradigm.com/
Community version : https://www.visual-paradigm.com/download/community.jsp

Ok i've picked that up - my first community package, I hope I don't regret this. I don't even use the software myself, I just deploy it to our developers. Anyway it's awaiting moderation:
https://chocolatey.org/packages/visualparadigm-ce/15.1

This is now approved and available, issue can be closed


Unable to access Ensemble-Wide Custom Widgets

Use Case

I am unable to access or use custom widgets from Ensemble Widget Library
it just shows any error like unsupported widget as in SS attached

Code Sample
simple code like
ensemble.countryCodeSelector in any screen can re-produce this issue.
Screen Shot

@sibteali786 is this still an issue?

@kmahmood74 no khurram, its no longer an issue.


Fix symlink unpriviledged in windows

Windows Creators Update supports  symlink-creation without any special permission setup.

This is not entirely correct for Emacs implementation of make-symbolic-link.
It seems that when calling CreateSymbolicLink, Emacs needs to add a new flag SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE for symlink can be created unpriviledged in Developer mode.
I've created a mitigation by using mklink command which works independently from Emacs implementation and supported in Windows.

Fixed CI

Thanks!


Fix Monitor ci.yml

Description
Fixes the structure of sdk/monitor's ci.yml to follow the formats of other SDK groups where the only include is the entirety of the SDK group and only pom.xml files are excluded.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - monitor - ci

/azp run java - monitor

@alzimmermsft, I'm not sure the properties section of azure-monitor-spring-native/pom.xml should even be in there but, what's there is wrong. Skip javadoc shouldn't be in the properties, it needs to have a javadoc to publish to maven even if it's empty. Here's the example where we do this in another library. Everything in between the START/END: Empty Java Doc tags.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-monitor-spring-native


PreCompose doesn't work with Compose Multiplatform 1.6.0-rc02

iOS build fails because of the issue discussed here:
https://github.com/JetBrains/compose-multiplatform/issues/4277
(Could not find "org.jetbrains.compose.annotation-internal:annotation")
It looks like PreCompose 1.6.0-beta02 utilizes Compose Multiplatform 1.6.0-beta02 and two of the internal dependencies of Compose Multiplatform (org.jetbrains.compose.annotation-internal:annotation and org.jetbrains.compose.collection-internal:collection) are binary incompatible with 1.6.0-rc01 and 1.6.0-rc02 which cause this issue.
Most probably upgrading Compose Multiplatform dependencies to the latest version will fix this.
More info: https://github.com/JetBrains/compose-multiplatform/releases/tag/v1.6.0-rc01

Wait for koin to upgrade, see https://github.com/Tlaster/PreCompose/pull/251#issuecomment-1953327494

@Tlaster Koin updated the compose version 1.6.0-rc02 in this 3.6.0-wasm-alpha2
[Diff ] (https://github.com/InsertKoinIO/koin/compare/3.6.0-alpha1...3.6.0-wasm-alpha2#diff-46bb88d929c23161f27e7968f73bd6f3a3e6c6f50041ff1c0f10b7072c661e3fR23)

@Tlaster Koin updated the compose version 1.6.0-rc02 in this 3.6.0-wasm-alpha2
Diff

You might got the wrong release, precompose 1.6.0-beta02 is already using this version

we want precompose also should refere to the Jetbrains compose v1.6.0-rc02  instead Jetbrains compose v1.6.0-beta02

ho okay...
I think we should wait for Koin release (3.6.0-wasm-alpha2)to get stable.
This is the error I am coming across
Could not find "org.jetbrains.compose.annotation-internal:annotation"

Wait for koin to upgrade, see #251 (comment)

koin 3.6.0-alpha3 is out.

Wait for koin to upgrade, see #251 (comment)

koin 3.6.0-alpha3 is out.

But not in maven yet, so still waiting...

Wait for koin to upgrade, see #251 (comment)

koin 3.6.0-alpha3 is out.

But not in maven yet, so still waiting...

The koin-compose version is 1.2.0-alpha3
https://mvnrepository.com/artifact/io.insert-koin/koin-compose/1.2.0-alpha3

Wait for koin to upgrade, see #251 (comment)

koin 3.6.0-alpha3 is out.

But not in maven yet, so still waiting...

The koin-compose version is 1.2.0-alpha3
https://mvnrepository.com/artifact/io.insert-koin/koin-compose/1.2.0-alpha3

Are you sure about that? 1.2.0-alpha3 was released in Mar 05, 2024.

I also saw it in this issue :
https://github.com/InsertKoinIO/koin/issues/1634#issuecomment-1980928550

I also saw it in this issue : InsertKoinIO/koin#1634 (comment)

Kinda misleading...I thought koin would uses 3.6.0 as the version name.

fixed in 1.6.0 rc release


Module 1 pull request

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

Opened by mistake. Already closed.


windows update issues

seems to be related to these blocked:
3.tlu.dl.delivery.mp.microsoft.com.c.footprint.net
cs11.wpc.v0cdn.net
au.download.windowsupdate.com.c.footprint.net

3.tlu.dl.delivery.mp.microsoft.com.c.footprint.net
cs11.wpc.v0cdn.net
au.download.windowsupdate.com.c.footprint.net

Ok, I've added the whitelist for now. Let's hope it works.

3.tlu.dl.delivery.mp.microsoft.com.c.footprint.net
cs11.wpc.v0cdn.net
au.download.windowsupdate.com.c.footprint.net

Ok, I've added the whitelist for now. Let's hope it works.

looks like it's fixed now, thank you 👍

looks like it's fixed now, thank you 👍


Publish as Firefox Extension

Pretty great idea, and very much welcomed for Slack distracting UI!
Would be nice to have it also available in Firefox, of course!

I would like to get to this at some point, but a PR is very welcomed.
For now, you should be able to use this https://addons.mozilla.org/en-US/firefox/addon/chrome-store-foxified/.

I cloned this repo and directly tried the extension locally on Firefox, and it works out of the box! 👍
I noticed that the UI doesn't look so nice on narrower viewports (e.g. 960px wide), but I understand it's because of the 800px width of the main container that is now set. Still it looks great when the browser is full-screen width :) And I guess the behavior is the same currently on Chrome as well.
Anyway, this means you can simply package this extension for Firefox and then publish it to Firefox Add-ons!

@berbaquero I just tried uploading it and got the following error. If you can submit a PR that fixes this, I'd be happy to publish it.
https://www.dropbox.com/s/bggh8sejr2okht6/Screenshot 2018-10-03 22.39.30.png?dl=0


Console shows many "DevTools failed to load source map" warnings

This is an upstream Chrome DevTools issue (and Firefox DevTools has a similar one too), but opening it here at the invitation of Chris (https://twitter.com/codepo8/status/1542844440078860289).
Browsers may download JS or CSS code which have a source map URL, but that URL may not be reachable for a number of reasons: .map files filtered out in the deployment process, filtered out by servers, etc. And while technically it’s a flaw in the website, those often don’t get fixed because they don’t impact the vast majority of end users.
On https://stackblitz.com (e.g. at https://stackblitz.com/edit/nextjs) it can be especially egregious because we run Node.js code and packages in the browser, including processes that create development web servers that may serve hundreds of scripts. For complex reasons serving source maps with those servers doesn't work on stackblitz.com currently. So we end up with hundreds of warnings generated by DevTools that make it impossible to see more relevant logs, warnings and errors. The following screenshot has 209 warnings about source maps:

What's more, it doesn't respect any of those two options:

"Hide network" (it's technically a network issue…)
"Group similar messages in console" (there was no grouping of the 209 messages)

Any intervention in DevTools that reduces this noise — especially in a HTTP/2+ world with potentially many resources and many source maps — would be appreciated.
AB#40274880

Thanks so much Florens for filing this. I'll get this on our team's radar.

Totally understand the frustration. It seems like the "Group similar messages in console" should work on these messages too.
It's on our team's backlog. People can help prioritize this by leaving comments and reactions on this issue.

I just tested https://stackblitz.com/edit/nextjs today, to see if I could find an existing console setting that would help, and realized that Edge and Chrome didn't behave the same:

As you can see in Edge, no source map warnings appear at all. I checked that both browsers had the same default levels set, and the same console settings.
So, apparently, in Edge we did something that hides those browser-level source map warnings.
Although using Edge would help @fvsch debug in this case, this feels to me more like a bug than an implementation choice. At least something to investigate.
But, I did find something that can help you in Chrome:

Open the Console sidebar (using the little arrow icon that's all the way to the left of the console toolbar)
In the sidebar, click the X user messages tab.

This should only show your messages and hide the 200+ source map warnings.

Thanks for looking into this @captainbrosset. I’ll have to try the Chrome "user messages" filter and maybe find a way to add that to our own docs.

@fvsch did you have a chance to try the user messages filter? Does it meet your needs?

@captainbrosset I confirm that the "User messages" filter is a good workaround. We might recommend it in our user documentation.

Thanks a lot for getting back to us on this. Closing now.

Correction: it's not a good workaround.
I just spent a bunch of time missing errors logged in the console because I had selected the "User messages" filter, which only shows console.log messages, and will filter out JS errors and console.error, console.warn, etc.
I can't offer this solution to our users, as it will make them miss important message (coming from their own code or from tooling that compiles their code). Too much of a footgun.

Hmm, no that's not exactly it.
The “User messages” filter does show console.error and console.warn messages, but it will hide important messages such as native JavaScript errors.
So in my case I had a document that didn’t render anything, and seemed to have no blocking error when using the “User messages” filter:

But the blocking error was a JS TypeError, not appearing in “User messages”:

And for context, I was trying to use the “User messages” filter to silence these 1180 warnings from DevTools about inaccessible sourcemaps:

The next best option I found is using -DevTools in the filter text input, but that carries a risk of silencing legitimate messages.

I guess ideally I would need DevTools to either categorize those source maps warnings as “Verbose”, or group them in a collapsible group, or both.

Thanks for the added details Florens. I re-opened this issue. It's on the backlog of our DevTools team.

It looks like Chrome 117 is moving those source map loading warnings outside of the Console and into a dedicated panel:
https://twitter.com/jecfish/status/1694076347742625832


Add the Port PR workflow

This add the Port PR workflow to Dashboard, this workflow is taken from internal docs provided with the rancherbot shutdown announcement. ^1
closes #10218

Does the primary PR have to be open before the backport issues are created? If so could the trigger be a comment in the PR instead? Often the issues are created first

@richard-cox I assume that you are referencing the usage of issue_comment in the workflow? If so, the github actions documentation recommends using issue_comment over pull_request_comment. There is then a guard for the port-pr job that will short circuit via github.event.issue.pull_request if this isn't a PR.


Adding picture to a sheet with existing pictures

When I open an existing xlsx file and try to add a picture to a sheet which already has some pictures in it,  existing pictures will be corrupted or removed and the picture I'm trying to add is not added to the sheet.
My code:
func main() {
	xlsx, err := excelize.OpenFile("./tmp.xlsx")
	if err != nil {
		log.Println(err)
	 }

	if err = xlsx.AddPicture("Sheet1", "E5", "./test.jpg", `{"x_scale": 1, "y_scale": 1}`); err != nil {
		log.Println(err)
	}

	err = xlsx.WriteTo("./Workbook.xlsx")
	if err != nil {
		log.Println(err)
		os.Exit(1)
	}
}

Base xlsx file:
tmp.xlsx
After adding the picture:
Workbook.xlsx

Thanks for your issue, I have fixed it by adding relationships in drawing content type shall.


Update status-socket

Made some fresh updates and fixed some bugs to have equipment bonuses and better hit splat tracking.

Thanks for that. Got that fixed.

This might sounds really dumb, but how do you use this? interested in tracking average hits and whatnot.

This might sounds really dumb, but how do you use this? interested in tracking average hits and whatnot.

Feel free to contact me on discord: DStat#0001
Willing to help out

This might sounds really dumb, but how do you use this? interested in tracking average hits and whatnot.

Feel free to contact me on discord: DStat#0001
Willing to help out

Sent you a Msg. Name on Discord is the same as my display name here.


Migrate to RESTEasy Reactive

This port is causing two test to fail in the backend module:
[ERROR] Failures:
[ERROR]   AlertingServiceTest.testLogging:127 expected: <true> but was: <false>
[ERROR]   TokenAuthTest.testTokenInHeader:42 1 expectation failed.
Expected status code <200> but was <401>.

I have no idea about the first one, but I believe the second one is a bad test and should be failing

@geoand Thanks for this PR - and sorry for some delay in review due to holidays. I think that the devil will be in ordering the filters before whatever handles OIDC.

Hey,
I am just coming back from a sick leave, so it might take me a while to get back to this :)

Hi @geoand, would you like to finish the request or should I take it over?

Hi,
I'm on PTO and a lot of things have pilled up, so realistically I won't be
able to get to this for another couple of weeks.
So up to you 😎
On Fri, Aug 19, 2022, 13:42 Radim Vansa @.***> wrote:

Hi @geoand https://github.com/geoand, would you like to finish the
request or should I take it over?
—
Reply to this email directly, view it on GitHub
https://github.com/Hyperfoil/Horreum/pull/229#issuecomment-1220526487,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBMDP6XBE55EWU7E7L5R7DVZ5QIRANCNFSM53NQ52CA
.
You are receiving this because you were mentioned.Message ID:
@.***>

So, I've managed to get the test working with few changes in HorreumAuthorizationFilter: first I set it up with
@ServerRequestFilter(priority = Priorities.AUTHENTICATION - 1)

and then I remove the Authorization header with this:
         try {
            Field delegate = PreventAbortResteasyReactiveContainerRequestContext.class.getDeclaredField("delegate");
            delegate.setAccessible(true);
            var actualContext = (ResteasyReactiveContainerRequestContext) delegate.get(containerRequestContext);
            HttpServerRequest actualServerRequest = ((QuarkusResteasyReactiveRequestContext) actualContext.getServerRequestContext()).vertxServerRequest();
            actualServerRequest.headers().remove(HttpHeaders.AUTHORIZATION);
         } catch (NoSuchFieldException | IllegalAccessException e) {
            e.printStackTrace();  // TODO: Customise this generated block
         }

I wouldn't mind the few casts, but so far I haven't found a way around accessing the delegate...

We'll, we can make the method parameter "injection" work with whatever type we want in RESTEasy Reactive 😉

🎉

@geoand I forgot to thank you for this, you did most of the heavy lifting.

Thank you for taking it over the finish line!
Glad to see this in :)


[stdlib] [task] - Implement stop function and remove redundant compiler plugin

Purpose

$subject
Fixes #14474
Fixes #14642

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ac75d9c). Click here to learn what that means.
The diff coverage is 61.53%.

@@            Coverage Diff            @@
##             master   #14509   +/-   ##
=========================================
  Coverage          ?   64.21%
  Complexity        ?      544
=========================================
  Files             ?     2282
  Lines             ?   100152
  Branches          ?    13273
=========================================
  Hits              ?    64314
  Misses            ?    30796
  Partials          ?     5042

Impacted Files
Coverage Δ
Complexity Δ

...ballerinalang/stdlib/task/utils/TaskConstants.java
0% <ø> (ø)
0 <0> (?)

...a/org/ballerinalang/stdlib/task/objects/Timer.java
96.15% <0%> (ø)
0 <0> (?)

...ng/stdlib/task/exceptions/SchedulingException.java
33.33% <0%> (ø)
0 <0> (?)

...ballerinalang/stdlib/task/objects/Appointment.java
93.1% <0%> (ø)
0 <0> (?)

...va/org/ballerinalang/stdlib/task/service/Init.java
100% <100%> (ø)
0 <0> (?)

...ava/org/ballerinalang/stdlib/task/utils/Utils.java
79.48% <100%> (ø)
0 <0> (?)

...lang/stdlib/task/impl/TaskServerConnectorImpl.java
100% <100%> (ø)
0 <0> (?)

...allerinalang/stdlib/task/objects/AbstractTask.java
69.38% <27.27%> (ø)
0 <0> (?)

...a/org/ballerinalang/stdlib/task/service/Start.java
72.72% <33.33%> (ø)
0 <0> (?)

...a/org/ballerinalang/stdlib/task/actions/Pause.java
70% <33.33%> (ø)
0 <0> (?)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac75d9c...4417a47. Read the comment docs.


gitattributes so we can easily run tests on Windows

Windows uses CRLF, which when the git worktree is mounted into the container, breaks bash running those scripts.
I've been working around this so far via
shopt -s globstar
dos2unix **/*.bash **/*.bats hooks/pre-command
docker-compose run --rm tests
unix2dos **/*.bash **/*.bats hooks/pre-command

before committing, but then I had this idea instead.

@petemounce is this change still useful for you? Also noting Ryan's suggested change.
If not I will close this old PR.

Closing this old PR. Can re-open if the changes proves relevant.


Messagebar does not pass type in 0.9.3, causing ManagedFormInput to nullref

After upgrading from 0.8.5-beta.10 to 0.9.3 of f7-react, Messagebar causes ManagedInputForm to nullref.
 <Page >
                <Messages>
                {
                    this.state.messages.map((message, index) => {
                        return this.getMessage(message, index);
                    })
                }
                </Messages>
                <Messagebar placeholder="Message" sendLink="Send" maxHeight={300} onSubmit={this.onSubmit.bind(this)} />
            </Page>

this.getMessage just emits a Message component based on the map. The core issue appears to be here, in ManagedFormInput:
  switch (props.type.toLowerCase()) {
        case 'checkbox':
        case 'radio':
            return React.createElement(SelectableInput_1.SelectableInput, __assign({}, renamedProps));
        case 'textarea':
            return React.createElement("textarea", __assign({}, renamedProps));
        default:
            return React.createElement("input", __assign({}, renamedProps));
    }

the props.type is null for the messagebar. coercing the type to be textarea results in the code rendering properly. Downgrading the app to react 15 also works.

Dug into this a little more. It's probably related to
import {ManagedFormInput} from '../../../components/inputs/ManagedFormInput';

 const propsProcessor = new PropsProcessor();
-const formElements = ['input'];
+const formElements = ['input', 'textarea'];

in CreateReactElements.ts. The TextArea type is now managed, where before it didn't pass through ManagedInputForm. However, I'm not sure where the code should be setting input type.

Dug more...The issue seems to be that messagebar.vue doesn't set type like the inputs do.
<template>

    <slot name="before-inner"></slot>

      <slot name="before-textarea"></slot>
      <textarea
        ref="area"
        :placeholder="placeholder"
        :disabled="disabled"
        :name="name"
        :readonly="readonly"
        @input="onInput"
        @change="onChange"
        @focus="onFocus"
        @blur="onBlur"
      >{{value}}</textarea>

Those attributes are passed into the f7 code, which eventually converts them into properties. Type is not being set here where ManagedFormInput is expecting it.

Same problem!


Templates injected via JavaScript are not hydrated

In our Django application, a lot of the content is rendered on the server via a template and then injected into a part of the page via JavaScript. This poses a problem when trying to add Unicorn to the codebase, since Unicorn components included in those templates are rendered correctly, but do not become interactive.
Is there a way to tell Unicorn to rescan the page for unicorn:click actions and the like after html has been added to the page by JavaScript?

If I manually run the code injected as a script by unicorn from the browser console, the component properly initializes. I'm not sure why this does not happen automatically O.o

Side note: the Unicorn code is incredibly readable for newcomers trying to fix problems. Props for that :)

That's awesome to hear. :) I don't see anything in your approach that worries me.
It does seem like something that could be integrated into Unicorn itself. If you are able to make a PR that would awesome. Otherwise I can probably work on this in the next couple of days I think. I know there are others who would benefit from this functionality. 👍

For now the decision in our company was to not adopt Unicorn, so I am not going to have much time to integrate this. Also, this seems like a much more heavy-handed approach to initializing new components than the current one. Maybe it could be added as a setting.


Create funding-the-commons-taipei-2023

This event has been added using the pull request - https://github.com/memser-spaceport/pln-events/pull/359 - closing this PR.


Revert "Bump RestSharp from 106.15.0 to 107.0.0 in /roles"

Reverts CactuseSecurity/firewall-orchestrator#1410
due to error:
 /usr/local/fworch/lib/files/FWO.Middleware.Client/MiddlewareClient.cs(29,27): error CS0246: The type or namespace name 'IRestResponse<>' could not be found (are you missing a using directive or an assembly reference?) [/usr/local/fworch/lib/files/FWO.Middleware.Client/FWO.Middleware.Client.csproj]

or do you see the another solution?

reverting until new code elements are integrated in next PR


Show correct ubuntu flavor

There are different environment variables that can be used to correctly identify which ubuntu flavor is being used, primarily XDG_CONFIG_DIRS.
Kubuntu
XDG_CONFIG_DIRS=/etc/xdg/xdg-plasma:/etc/xdg
Ubuntu Mate
XDG_CONFIG_DIRS=/etc/xdg/xdg-mate:/etc/xdg
DESKTOP_SESSION=mate
XDG_SESSION_DESKTOP=mate
XDG_CURRENT_DESKTOP=MATE
XDG_DATA_DIRS=/usr/share/mate:/usr/share/xfce4:/usr/local/share:/usr/share:/var/lib/snapd/desktop:/usr/share
GDMSESSION=mate
Xubuntu
XDG_CONFIG_DIRS=/etc/xdg/xdg-xubuntu:/etc/xdg:/etc/xdg
DESKTOP_SESSION=xubuntu
XDG_SESSION_DESKTOP=xubuntu
XDG_DATA_DIRS=/usr/share/xubuntu:/usr/share/xfce4:/usr/local/share:/usr/share:/var/lib/snapd/desktop:/usr/share
GDMSESSION=xubuntu
Lubuntu
XDG_CONFIG_DIRS=/etc/xdg/xdg-Lubuntu:/etc/xdg:/etc/xdg
DESKTOP_SESSION=Lubuntu
XDG_DATA_DIRS=/usr/share/Lubuntu:/usr/local/share:/usr/share:/var/lib/snapd/desktop

Here is a patch based on your infos. I've tested it only on Kubuntu, since I use it on my netbook.
https://github.com/arisinfenix/neofetch/commit/f47b8b07f7483b7323669a6df1d7cad98766a9e3
@dylanaraps let me know if I should open a PR.

@arisinfenix thanks for the patch. I tested it in Xubuntu and Lubuntu and it worked.
It didn't work in Ubuntu Mate as you'd need to change your code to 'Ubuntu-MATE' rather than 'Ubuntu MATE'.
Please add to your patch detection of ubuntu budgie.
XDG_CONFIG_DIRS=/etc/xdg/xdg-budgie-desktop:/etc/xdg
DESKTOP_SESSION=budgie-desktop
XDG_SESSION_DESKTOP=budgie-desktop
XDG_GREETER_DATA_DIR=/var/lib/lightdm-data/ubuntu-budgie
XDG_CURRENT_DESKTOP=Budgie:GNOME
XDG_DATA_DIRS=/usr/share/budgie-desktop:/usr/local/share:/usr/share:/var/lib/snapd/desktop
GDMSESSION=budgie-desktop
Possibly also this one for ubuntu cinnamon if the icon is in neofetch.
XDG_CONFIG_DIRS=/etc/xdg/xdg-cinnamon:/etc/xdg
CINNAMON_VERSION=4.4.8
DESKTOP_SESSION=cinnamon
XDG_SESSION_DESKTOP=cinnamon
XDG_CURRENT_DESKTOP=X-Cinnamon
XDG_DATA_DIRS=/usr/share/gnome:/usr/share/cinnamon:/usr/local/share:/usr/share:/var/lib/snapd/desktop
GDMSESSION=cinnamon

@philipzae thanks for testing. I've updated the patch, it should work now for MATE and Budgie too.
https://github.com/arisinfenix/neofetch/commit/a3cb1285ae4f3989ee9f098417e629a75529c84f
For ubuntu cinnamon there is no ascii logo yet.
Is there a reliable way to detect ubuntu studio? Its default DE is Xfce, but it can also be installed on any other ubuntu flavor. https://ubuntustudio.org/ubuntu-studio-installer

Ubuntu Studio has xdg-ubuntustudio in XDG_CONFIG_DIRS. Using ubuntu-studio-installer doesn't convert a flavor into ubuntu studio, so there is nothing to worry about there. Also the next version of studio will use KDE rather than Xfce.
If the logo for Ubuntu Kylin is available, then detecting it is limited to searching in XDG_GREETER_DATA_DIR for ubuntu-kylin.

Thank you for the info. I've opened PR #1507 and tested it with mate, budgie and studio.

Slightly concerned that this change infers the distro from the currently running DE, i.e. $XDG_CONFIG_DIRS - In cases where alternative DEs have been installed, this can give spurious results.
Could we use  /var/log/installer/media-info as a primary selection method for Ubuntu distros if present, then failback to the XDG_CONFIG_DIRS ?


Add content to README.md

was not entirely sure about the answer for the FAQ question

Hi @Ignition , just made the changes you had requested. Please let me know if you would like any other changes to be made.


Linking directly to a tab

Is there a way to create a link to a tab, even if it is not the active one?  I noticed that if I link to a tab, it will only jump to it if it is active.  If there is a link to an inactive tab, it will do nothing.
Thanks!

You should be able to link to the page with an ID for the tag in question, so if for example you had a tab called "awesomeTab" you could link to mypage.html#awesome and the tab would be made active whether it was or not. Or are you asking about linking to that place on the page?

That is what I thought, but for some reason mine is not working that way.  It will only work if it is the active tab. On my page there is Artsgarden Events (#artsgarden) and Citywide Events (#city) links at the top.  When the page loads, click one of those and nothing happens.  If you go down and click on one of those tabs and then go back and click on the link that relates to the tab, it will jump down.  But if you click on the other link, it won't. So yes, linking to that place on the page and having that tab become active.
Here is the link: http://indyarts.org/artsoul/index1.html

We revisited this today. The reason we don't jump down is...complicated, but boils down to an incompatibility with preventDefault and the way we have the page load an anchor and have that tab active. In order for the link to jump down and activate the tab we would lose the tab deep linking on page load. We may tackle this in a future version of Reveal.


catachment data

best way to include this in breakdown of baseline data

not sure how to do this probably can just show baseline of top function


unpublished news shown in list

If I create a new news with publication_start in the future it's shown in the news list.
I looks like hvad does not use using_translations(), wasn't called in my debuging approaches.
Queryset filter should be correct.
django-cms==3.0.10
django-hvad==1.0.0

maybe it's because I don't use translations.
If I read the django-hvad docs (https://github.com/KristianOellegaard/django-hvad/blob/master/docs/public/queryset.rst) correctly it should be .untranslated() in that case, but not working.


How to correctly upgrade the built-in Python version of Spyder ?

Issue Report Checklist

[ ] Searched the issues page for similar reports
[ ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[ ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[ ] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[ ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
What steps reproduce the problem?

I want to upgrade my Python version to a newer version. How do I do it correctly? thank you.

What is the expected output? What do you see instead?
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version:  ver5.5.6
Python version:    python 3.8.10
Qt version:
PyQt version:
Operating System name/version:  windows 10

Dependencies

PASTE DEPENDENCIES HERE

Hey @int0x09, thanks for reporting. Unfortunately, that's not possible.
If you want to use a more recent Python version with our standalone installers, I'm afraid you'll have to install Spyder 6.0.1, which comes with Python 3.11.

thanks.
Sypder6.0.1 is to fat, I prefer  spyder5.5.6.


How to write template of chiral alchol to ketone.

I want to write template of chiral alchol to ketone.
In the case of not chiral alchol,
template "[Oh:1][C:2]([C:3])[C:4]>>[O:1]=[C:2]([C:3])[C:4]" worked well for reactant "OC(C)CC": then it gave ['CCC(C)=O'].
But in the case of chiral alchol,
template "[Oh:1][C@H:2]([C:3])[C:4]>>[O:1]=[C:2]([C:3])[C:4]" didn't work for reactant "O[C@H](C)CC": then it gave [].
How I write template for chiral alchol?

This is because your chiral template specifies that the carbon with atom map 2 has a hydrogen in the reactants side and, when copied over to the product, is left implicit. This leads to a valence issue, which you can see if you install rdchiral from source with python setup.py install and set PLEVEL = 99 in the header of utils.py:
[O:1]=[CH:2]([CH3:3])[CH2:4][CH3:5], Explicit valence for atom # 1 C, 5, is greater than permitted
You can fix this by correcting your chiral template to the following:
"[OH:1][C@H:2]([C:3])[C:4]>>[O:1]=[CH0:2]([C:3])[C:4]"

Thank you for your reply.
Your template include "CH0" worked well!


Fix panic-in-panic in tests.

There are some very rare circumstances that can cause a double panic during
development. For example, .with_json("") (or any invalid JSON) will panic, and then the drop
will also panic.  This can cause a confusing SIGILL.

r? @nrc
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit fa94e8aab49fb77bbe8bcc4d9e221495c5a7138c has been approved by nrc

:hourglass: Testing commit fa94e8aab49fb77bbe8bcc4d9e221495c5a7138c with merge 79f962f8c96d8e3be3f1034111e9d350ff184caf...

:sunny: Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 79f962f8c96d8e3be3f1034111e9d350ff184caf to master...

Oh cool!  I ran into this and tried to help in #6364.  Nice to see this fixed properly, thanks @ehuss!
Is panicking in Drop impls generally considered a terrible idea?

Is panicking in Drop impls generally considered a terrible idea?

I think it depends on what Drop is doing.  If the failure is so critical that it would be unsafe for other threads to continue, I think aborting is the right thing to do.   I've seen other crates check for panicking like this for similar situations ("finish" functions used to finalize a builder) where the consequences are not critical.


Run job multiple times, but never at the same time

Hey!
Thanks for this great gem! One question:
I want a job to run multiple times in a row, but never at the same time, no matter how long it takes.
I.e. I tried following
:scheduler:
  :schedule:
    test:
      interval: '1m' # interval one minute
      class: Bookshelf::Jobs::Test

but Bookshelf::Jobs::Test sleeps for 115 secs
module Bookshelf
  module Jobs
    class Test < PayNRed::Job
      def perform
        # simulate a long-running job
        sleep 115
      end
    end
  end
end

but with this the result are 2 busy jobs. Is it possible to specify that a job is not called if the old one is still running?
thanks and best regards

We don't have this feature. Maybe you can check out https://github.com/mhenrixon/sidekiq-unique-jobs
I know sidekiq enterprise also has kind of a similar feature, which is Sidekiq Limiter, but that requires paying for sidekiq enterprise https://github.com/sidekiq/sidekiq/wiki/Ent-Rate-Limiting

Yes, that works if you record somewhere if the job is already running. Not sure how you're going to implement old_job_is_still_running?, assuming it is a flag in redis, keep in mind that if the job fails you want to set the key in redis to false otherwise, if a job fails no other job would run since it would continue to return true even though there isn't a job running.


SSH retry with integration tests

@schisamo Thanks for your patience.  This PR has a single commit and passing integration tests.

Just wanted to say that this patch is working for us in production.  Thanks @jsmickey.

Thanks for the contribution @jsmickey. We are going to try to work this in to the cookbook by the end of the month.

Fantastic, I was just looking for this feature!

I've rebased and merged this with #532. There may be some minor issues with the PR, but rather than delaying on merging and having to rebase again when I'm resolving some other issues with this cookbook, I want to get a release of this out in the next few days that includes this patch since folks have reported it working for them.


ci: added flags to codecov upload

Closes #
📝 Description

Add a brief description

⛳ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (13c66b0) 55.60% compared to head (2c98d65) 55.60%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   55.60%   55.60%
=======================================
  Files          10       10
  Lines         223      223
  Branches       59       59
=======================================
  Hits          124      124
  Misses         99       99

Flag
Coverage Δ

PhoneInput
21.42% <ø> (?)

useClickOutside
100.00% <ø> (?)

usePreserveInputCaretPosition
100.00% <ø> (?)

usePrevious
100.00% <ø> (?)

useSelectionRange
100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Context data retrieval is unsafe

Our current design, where a context handler is given during jerry_init_with_user_context () via an init/deinit pair of function pointers and the pointer is later retrieved via jerry_get_user_context () is unsafe, because for two different contexts you can have two different pairs A and B of function pointers passed to jerry_init_with_user_context () but there is nothing to prevent a call to jerry_get_user_context () from the wrong environment - that is, from an environment where the returned pointer is assumed to be a pointer to a structure B when in fact the context was initialized with the init/deinit pair for A.
The answer is to store the init/deinit pair in a global static structure, a pointer to which can serve as a runtime type id for the void * stored on the context. Then, if two different pointers are identified by two different such type IDs, requesting one of the pointers by type ID will return the correct one.

With "environment", do you mean different JerryScript instances?

No, I mean the user case for attaching data to a single context. So, if one use case is a module instance list and another use case is some other kind of framework, then, when the module handler calls jerry_get_user_context () it will assume that the resulting void * is a pointer to whatever it uses, whereas when the other kind of framework calls jerry_get_user_context () it will assume that the resulting void * will be a pointer to it's own state. As things stand, if you accidentally call into the other framework after having done jerry_init_with_user_context (JERRY_INIT_EMPTY, jerryx_module_init, jerryx_module_deinit), things will likely segfault eventually.

Basically, when you wish to retrieve the void * you have to either prove that you are the one who created it in the first place, or you have to provide the means to lazily create and return to you a brand-new void * (which is what #1833 does).

In both cases you prove it and provide for lazy creation by providing the pointer to the jerry_context_data_manager_t as a parameter to jerry_get_user_context () (or jerry_get_context_data () in the #1833 version).


Chore: Add support for encrypted SSL-key

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
Add supported for encrypted private key in the HTTPS server config.
Type of change
Please delete any options that are not relevant.

New feature (non-breaking change which adds functionality)
This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[ ] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[x] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Whats the benefit of this for this particular app?


[Keycloak Guard] Signature verification failed

Im getting this error message after trying to access an url with access_token bearer. I did setup the required parameter .env
What did I do wrong ?

@shineirvin, this  error is raised when you supply an invalid token. Check the token you're passing as the access_token and ensure that:

Was generated by the Keycloak instance whose public key you've set in your .env
That you copied the entire key

Please, if it is still a issue fill a new issue providing more details.


Support strict_vars globally in application config

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html

Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/6127
User: @hschletz
Created On: 2014-04-12T18:08:09Z
Updated At: 2016-05-03T10:44:27Z
Body
I want a notice whenever a view template tries to access an undefined view variable via $this->var. I know only 2 ways to achieve this:

Call $this->vars()->setStrictVars(true) in every template
Set up an event listener and run setStrictVars(true) recursively on the view model and all its children (taking into account that a model's variables may be stored as an array instead of Zend\View\Variables).

Zend\View\Variables even supports an option "strict_vars" via its constructor, but neither this option nor setStrictVars() appear to be used anywhere within the ZF code.
It would be nice to be able to set strict_vars globally in the application configuration and have the Variables constructor evaluate it.

Changing Variables#$strictVars can't really be done in 2.x as it looks like quite a BC break to me...

Comment
User: @hschletz
Created On: 2014-04-13T08:57:23Z
Updated At: 2014-04-13T08:57:23Z
Body
The change would not break BC if the default remains unchanged. I'm talking about a new option "strict_vars" in the application config. Since this option does not exist yet (only if passed manually to the Variables object), it will not be present in any existing application code - it would be an entirely new feature.
I think view variables should be treated like any other variable - ignoring reference to an undefined variable is bad practice.The hassle of an external module for this essential feature looks like overkill to me.

Comment
User: @Ocramius
Created On: 2014-04-13T08:59:28Z
Updated At: 2014-04-13T08:59:28Z
Body

I'm talking about a new option "strict_vars" in the application config. Since this option does not exist yet (only if passed manually to the Variables object), it will not be present in any existing application code - it would be an entirely new feature.

Yeah, for this path, I really suggest having a module that deals with it. It can be as minimal as EdpModuleLayouts

Comment
User: @hschletz
Created On: 2014-04-13T09:22:41Z
Updated At: 2014-04-13T09:22:41Z
Body
Sure, my workaround is not much code, but it's a bit quirky because it adds some postprocessing to all view models, instead of having things set up correctly in the first place. Additionally, I want to keep external dependencies as minimal as possible. This functionality really should be provided by the ZF core which currently not only encourages writing bad code, but makes writing better code needlessly complicated.
I'm not exaggerating with the "bad code" thing: Once enabled, the notices revealed several previously undiscovered bugs in one of my projects.

Comment
User: @Ocramius
Created On: 2014-04-13T16:37:30Z
Updated At: 2014-04-13T16:37:30Z
Body
I fully agree on the strictness here, it would indeed help, but I would really just change that default value in 3.x and have a debug module in 2.x

Comment
User: @Martin-P
Created On: 2014-04-15T16:04:54Z
Updated At: 2014-04-15T16:19:34Z
Body
Interesting info about setStrictVars().
I did some testing by attaching a listener to ViewEvent::EVENT_RENDERER and I am able to set strict vars on the ViewModel returned by the controller and on the layout. However, this does not cover the render() view helper and partial() view helper. I know this is not a forum for coding issues, but I think this can be useful for the actual implementation to make sure all parts are covered. Any ideas on how to cover that?
<?php

namespace MyStrictViewVars;

use Zend\EventManager\EventInterface;
use Zend\ModuleManager\Feature;
use Zend\ServiceManager\ServiceLocatorInterface;
use Zend\View\Variables as ViewVariables;
use Zend\View\ViewEvent;

class Module implements Feature\BootstrapListenerInterface
{
    /**
     * @var ServiceLocatorInterface
     */
    protected $serviceManager;

    /**
     * Bootstrap event listener
     *
     * @param EventInterface $event
     */
    public function onBootstrap(EventInterface $event)
    {
        $application    = $event->getApplication();
        $eventManager   = $application->getEventManager();

        $identifier = 'Zend\View\View';
        $event      = ViewEvent::EVENT_RENDERER;
        $callback   = array($this, 'setStrictVars');
        $priority   = 100;
        $eventManager->getSharedManager()->attach($identifier, $event, $callback, $priority);

        $serviceManager = $application->getServiceManager();
        $this->setServiceManager($serviceManager);
    }

    /**
     * Set strict vars on ViewModel
     *
     * @param EventInterface $event
     */
    public function setStrictVars(EventInterface $event)
    {
        $config = $this->getServiceManager()->get('Config');
        if (!isset($config['view_variables']['strict_vars'])) {
            return;
        }

        $useStrictVars = (bool) $config['view_variables']['strict_vars'];
        $viewModel     = $event->getModel();

        /**
         * If $variables is not instance of ViewVariables,
         * convert it to ViewVariables and overwrite $viewModel variables
         */
        $variables = $viewModel->getVariables();
        if (!$variables instanceof ViewVariables) {
            $viewVariables = new ViewVariables($variables);
            $viewModel->setVariables($viewVariables, true);
        }

        $viewModel->getVariables()->setStrictVars($useStrictVars);
    }

    /**
     * @param ServiceLocatorInterface $serviceManager
     */
    protected function setServiceManager(ServiceLocatorInterface $serviceManager)
    {
        $this->serviceManager = $serviceManager;
    }

    /**
     * @return ServiceManager
     */
    protected function getServiceManager()
    {
        return $this->serviceManager;
    }
}

Comment
User: @Ocramius
Created On: 2014-04-15T17:12:55Z
Updated At: 2014-04-15T17:12:55Z
Body
@Martin-P the solution there would be to just replace the PhpRenderer IMO.

Comment
User: @Martin-P
Created On: 2014-04-16T22:13:43Z
Updated At: 2014-04-16T22:29:25Z
Body
Did some digging. The creation of PhpRenderer which is used in the application is hardcoded in the ViewManager on line 184 and the factory for the ViewManager is hardcoded in the ServiceListenerFactory on line 57. The ServiceListener is created even before the modules are loaded in the ModuleManagerFactory on line 44. It is possible to overwrite the ServiceListener via application.config.php:
return array(
    'service_manager' => array(
        'factories' => array(
            'ServiceListener' => 'ModuleName\Factory\ServiceListenerFactory',
        ),
    ),
    // more config
);

But now the namespace is still unknown, because the module is not yet loaded. Perhaps the dirty way by overriding the protected property $renderer of the ViewManager with Reflection? :wink:
Edit: nevermind, this is becoming a mess :smiley:

Comment
User: @Martin-P
Created On: 2014-04-23T12:32:43Z
Updated At: 2014-04-23T12:32:43Z
Body
Always funny to read back your own comments :smile:
Easy solution: indeed overwrite PhpRenderer and set HelperPluginManager and Resolver from the already existing PhpRenderer. Overwrite the methods get, __get and vars and set strict mode before they are called. Add an initializer to the view_helpers config and inject your custom PhpRenderer with the setView() method of the view helper.

 :)
There is no reason to handle view variables different than regular variables, if they are not set but used.

 All available/proposed solutions are far too complicated for such a basic code quality feature. @antiphp has it summed up pretty well. I'd also suggest making the desired behavior the default for ZF3.

Comment
User: @grizzm0
Created On: 2016-05-02T18:43:20Z
Updated At: 2016-05-02T18:43:20Z
Body
This sounds like the job of a module to me.

This repository has been closed and moved to laminas/laminas-view; a new issue has been opened at https://github.com/laminas/laminas-view/issues/20.


refactor(rpc): move sanity check logic from rpc handlers to implementations.

I see only 1 implementation. Tell me if here are more.
Close #998

Codecov Report

Merging #1213 (37b1d8b) into main (18860df) will increase coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   55.76%   55.92%   +0.16%
==========================================
  Files         161      161
  Lines        9650     9645       -5
==========================================
+ Hits         5381     5394      +13
+ Misses       3740     3720      -20
- Partials      529      531       +2

Impacted Files
Coverage Δ

service/rpc/state.go
0.00% <ø> (ø)

state/core_access.go
12.34% <0.00%> (-0.85%)
:arrow_down:

header/core/listener.go
52.83% <0.00%> (-5.67%)
:arrow_down:

ipld/get_namespaced_shares.go
88.32% <0.00%> (-2.19%)
:arrow_down:

fraud/pb/proof.pb.go
36.61% <0.00%> (+1.89%)
:arrow_up:

share/discovery.go
35.41% <0.00%> (+3.12%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Rebased twice, and it still failed...

Yeah, we have some flakiness

happy to see it passed :)


Also make it possible to change background colors

Is there a way to extend EnhanceAnyLexer so that background colors can also be changed?
Personally, it would be enough for me if only the background colors could be changed, so it might be possible to program a switch like use RGB instead of BGR for using background colors instead of foreground colors.
Of course, a complete solution for foreground and background colors would be better, but it would definitely require a change to the ini file, so there could be incompatibilities with existing configurations for other users.
I would be happy if something like this could be made possible.
Thank you for the work you have put into the project so far.
Best regards

The background colors of the individual matches? Like we say Jein (Yes and no).
It is possible to use indicators such as INDIC_STRAIGHTBOX or INDIC_ROUNDBOX,
but these can only be used with permanently assigned colors and not
be used at runtime like INDIC_TEXTFORE with SC_INDICFLAG_VALUEFORE .
Currently 44 different indicators can be used with Scintilla, some of which are used by Scintilla itself, from 32 upwards, 0-7 are assigned to the lexers and Npp and other plugins can/should use the rest.
In other words, you don't know beforehand how many can actually be used without conflict. If it's just one or two fixed indicators, then there's a good chance you can get those assigned, but 10 or 20 ... probably not.

Thanks for your fast answer.
Jein 😂 I understand that. I'm German.
I thought it would be easier to assign the background colors.
Maybe it is possible to use INDIC_STRAIGHTBOX together with the colors "Mark Style 1" to "Mark Style 5" defined in stylers.xml?
This should ensure that the color is available.
An entry in the ini file could then look like this:
mark_style_1 = test
mark_style_2 = peace
This probably wouldn't cause any conflicts with existing ini files.
Bt I don't know whether it's easy to get the Mark Style colors from the configuration into the plugin or whether the stylers.xml has to be read and evaluated from the plugin.
Best regards

Sorry for replying so late, but a flu-like infection caught me at the weekend. Of course ... at the weekend ... grml :-)

I'm German.

Haha ... me too.
Using the "style token" function with EnhanceAnyLexer has an annoying effect.
Once defined, the document types handled by the plugin can no longer use the "style token" Npp function.

I don't know what -25 and -25 mean in your example. I suspect this is your trial version to test this functionality.
You seem to misunderstand me. IIRC, the problem was assigning possible colors, so my suggestion was to take the bgColor from Mark Style 1 to Mark Style 5 defined in stylers.xml and use those colors in the plugin.
I didn't suggest calling the style token function.
Hopefully using these colors to color the background shouldn't be a problem with the plugin.

Oh no, I didn't use the style token function itself, I reused the indicator that is basically responsible for doing this. Maybe a short gif will illustrate this a little better.

As you can see, it is automatically colored, but you can no longer use the style token functions for the 1st and 2nd style. Btw 25, 24 (and 23, 22, 21) are the indicator IDs that Npp defines. I chose to use -25, -24 to easily distinguish them from the normal foreground color regexes.
I'm not sure if I should go this route. Ultimately it's up to the users to decide what's more helpful in their cases, but ... maybe I should rethink the whole idea with the indicators and go back and re-investigate the styles that caused some problems in an older version.

Thank you for your excellent explanation and illustration and sorry for the late reply, I was out of town.
I didn't think it was that complicated. I thought N++ makes its style dependent on the language and then the plugin examines the text and if an applicable regular expression is found it applies the style to the appropriate text in addition to the already formatted text.
By the way, I could live with the restriction you mentioned.
Thank you for your efforts, maybe you will find a good solution. I hope I'm not the only one who would like a feature like this.
Best regards.

@Weber-Frank - I will close this one and continue to document the status in #12.

👍


Question about deformable_convolution implementation

Here, input_offset_dim_  was defined as the product of ishape from 1 to offset_shape.ndim(). I was thinking whether it should be offset_shape's product, since it is used to address offset here?

 Thanks a lot!

Though it's solved I still wonder: ishape and offset_shape looks totally different for me, no matter how much batch_size is (in fact I think batch_size is kind of marginalized in ProdShape from dim 1), so how on earth does batch_size has to do here?

@Zardinality , I am now using your tensorflow deform-conv, does that op solve this problem?

@argman sure, if you have any questions about my impl, feel free to file an issue or email me

@Zardinality , ok ,tks!


[Clipboard] GetFormatsAsync empty on Windows

GetFormatsAsync returns an empty array. Is it a known behavior or a bug? Getting and setting text does work. I want to implement file copy/paste for my app. I was surprised that GetFormatsAsync is empty on Windows.
Windows 11 22H2
Avalonia 11.0.0-preview7
On linux I get an array with 13 items with the same codebase, same Avvalonia version.

On my computer it works well (Win10 22H2, Avalonia latest master version).
Does clipboard in other program works well? Do you try on other computer? As I know some remote-desktop software could break clipboard.

@ADIX7 preview7 is pretty outdated now. Please try again using latest RC2.2 or even nightly builds. Thx.

It seems GetFormatsAsync must be called from UI thread. I cached a result from TopLevel of MainWindow in the constructor of MainWindow and got clipboard from it on a different thread in a service and somehow I did not get an exception but an empty array... After getting TopLevel every time instead of caching it I get the exception. Scheduling the code on UIThread solved the problem.


rename internal to utilties for 1.5 compatibility

fixes #36

The change itself LGTM, but I want to know what was the error #36 exactly.

LGTM
c.f. https://docs.google.com/document/d/1e8kOo3r51b2BWtTs_1uADIA5djfXhPT36s6eHVRIvaU/edit


add button to see / make reviews on game detail page

Include a button in the game detail page from #40 that allows a user to make a review of a game. Make a list view for the reviews as well to display a list of reviews.

Created branch game-management/review-page

Made a form ReviewForm for creating new reviews

Updated the GameDetailView with a FormMixin to allow a form to create reviews for games

Made a ReviewListView and a game-review template. Also updated the URLs to include a URL to the game-reviews page for a specific game

Made a Review entity in the models

Updated the ReviewForm to include is_public and a rating field

This issue is closed as per PR #275. Tasks I worked on:

I made a ReviewForm to allow users to leave ratings and reviews for games.
I updated the GameDetailVIew to render the form.
I made a ReviewListView to render  a list of reviews
I updated game_grid.html to display the review form
I made a game_reviews.html to display a list of reviews that a game has

Issue Score: Excellent
Comments:
Great work @danielngira !
Quite nice closing comment. Good job updating as you've worked! The kind of use of updates we want.


Replace service cpu/mem link to 'Monitor'

The previous link to 'Monitor' contained a recording rule metric, and since not all Weave Clound instances have recording rules, the link would redirect to a 'Monitor' page without data points.
The recording rule metric has been substituted with the underlying query.
Fixes #2925

@dlespiau thanks!
I have added an additional commit which removes that assumption in the service metrics that the service name equals the deployment name.


Question Service Update

Migrated question id handling for add and delete to the backend
Separated app and server connection code
Add endpoint to get random question based on the given difficulty and category
Add unit tests
Add integration tests

LGTM!


Question - Using error types with axios client

Hey - Is it possible to use the Axios client and also have error response types? From looking through source, it seems that only the fetch client can handle a secondary/error response type.
Thanks!

Hello @jdimmerman !
As I know - there is no way to use good typings from bad response in fetch\axios


CompositePrimaryKey conflict with ActiveModel::Associations

I'm trying to use both CompositePrimaryKey and ActiveModel::Association however I'm finding that the added functions used in CompositePrimaryKey (namely instance method method `composite?' ) is undefined.
Cross reference: https://github.com/composite-primary-keys/composite_primary_keys/issues/352
Sample application with error: https://github.com/jufemaiz/testing-composite-primary-keys

Thanks for your report.
I think that it is probrem, but this gem should not support CompositePrimaryKey gem internally.
Because this gem depends on implementation of CompositePrimaryKey and it makes cohesion of this gem worse.
Please add workaround to your code.


Default color of segmentation masks

Hi,
May i know what the color represents in the segmentation image on the right ?

Thanks

these are unique integers for segmentation masks, you can check with this:
img["segmented_watershed"].as_numpy()

closing due to inactivity


buildtimeout default 10m is not used

/area API
/area test-and-release
/kind bug
Expected Behavior
Build timeout of 10 minutes is applied if no timeout was specified.
Actual Behavior
Build defaulted to build timeout of 0s, failing builds.
Steps to Reproduce the Problem

Create a new build or a service requiring a build that takes a few minutes.
Observe that the build fails to complete and has BuildTimeout error.

Additional Info
Built using jib build template, with persistent volume for local cache.
PVC:
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: build-cache-claim
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 5Gi

Service:
apiVersion: serving.knative.dev/v1alpha1
kind: Service
metadata:
  name: vision
  namespace: default
spec:
  runLatest:
    configuration:
      build:
        serviceAccountName: riff-build
        source:
          git:
            url: https://github.com/spring-cloud/spring-cloud-gcp.git
            revision: v1.0.0.RELEASE
        template:
          name: jib-maven
          arguments:
          - name: IMAGE
            value: &image gcr.io/${GCP_PROJECT}/vision-sample
          - name: CACHE
            value: build-cache
          - name: DIRECTORY
            value: spring-cloud-gcp-samples/spring-cloud-gcp-vision-api-sample
        volumes:
          - name: build-cache
            persistentVolumeClaim:
              claimName: build-cache-claim
      revisionTemplate:
        metadata:
          labels:
            knative.dev/type: app
        spec:
          container:
            image: *image

Revision failure:
kubectl get revisions vision-00002 -oyaml
apiVersion: serving.knative.dev/v1alpha1
kind: Revision
metadata:
  annotations:
    serving.knative.dev/configurationGeneration: "2"
  clusterName: ""
  creationTimestamp: 2018-09-23T21:35:14Z
  generation: 1
  labels:
    knative.dev/type: app
    serving.knative.dev/configuration: vision
    serving.knative.dev/service: vision
  name: vision-00002
  namespace: default
  ownerReferences:
  - apiVersion: serving.knative.dev/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: Configuration
    name: vision
    uid: fc0cb3aa-bf77-11e8-8504-42010a800102
  resourceVersion: "10507"
  selfLink: /apis/serving.knative.dev/v1alpha1/namespaces/default/revisions/vision-00002
  uid: 8eab6f80-bf78-11e8-8504-42010a800102
spec:
  buildName: vision-00002
  container:
    image: gcr.io/springone18-iad-5999/vision-sample
    name: ""
    resources: {}
  generation: 1
  labels:
    knative.dev/type: app
    serving.knative.dev/configuration: vision
    serving.knative.dev/service: vision
  name: vision-00002
  namespace: default
  ownerReferences:
  - apiVersion: serving.knative.dev/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: Configuration
    name: vision
    uid: fc0cb3aa-bf77-11e8-8504-42010a800102
  resourceVersion: "10507"
  selfLink: /apis/serving.knative.dev/v1alpha1/namespaces/default/revisions/vision-00002
  uid: 8eab6f80-bf78-11e8-8504-42010a800102
spec:
  buildName: vision-00002
  container:
    image: gcr.io/springone18-iad-5999/vision-sample
    name: ""
    resources: {}
  generation: 1
  servingState: Active
status:
  conditions:
  - lastTransitionTime: 2018-09-23T21:35:14Z
    status: Unknown
    type: Active
  - lastTransitionTime: 2018-09-23T21:35:39Z
    message: Build "vision-00002" failed to finish within "0s"
    reason: BuildTimeout
- lastTransitionTime: 2018-09-23T21:35:14Z
    status: Unknown
    type: ContainerHealthy
  - lastTransitionTime: 2018-09-23T21:35:39Z
    message: Build "vision-00002" failed to finish within "0s"
    reason: BuildTimeout
    status: "False"
    type: Ready
  - lastTransitionTime: 2018-09-23T21:35:14Z
    status: Unknown
    type: ResourcesAvailable
  logUrl: |

Confirmed working if timeout was explicitly specified in the YAML.

/assign @shashwathi

@saturnism : Which version of serving and build are used in your cluster?

I believe this is fixed now, please reopen if you're still seeing this.


Fix Unreal Engine links in Gaming landing page

📝 Changed routes:

/solutions/gaming

(view full size)

Commit 26e6a247354437cbaca91b9d97eb170b77d1c8ca (https://thirdweb-ndmeto8yi.thirdweb-preview.com).


Not working with Unity :(

Hi,
I spent the whole day trying to make this project work with Unity but unfortunately I still cannot import the dll without errors.
I tried many different things and it seems like the necessary dependencies are not included in the build.
Here is the kind of errors I am getting when importing the dll of Networker:
Unable to resolve reference 'Microsoft.Extensions.Logging.Abstractions'. Is the assembly missing or incompatible with the current platform?
Reference validation can be disabled in the Plugin Inspector.
Unable to resolve reference 'Microsoft.Extensions.Configuration.Abstractions'. Is the assembly missing or incompatible with the current platform?
Reference validation can be disabled in the Plugin Inspector.
Unable to resolve reference 'Microsoft.Extensions.Logging'. Is the assembly missing or incompatible with the current platform?
Reference validation can be disabled in the Plugin Inspector.
Unable to resolve reference 'Microsoft.Extensions.DependencyInjection.Abstractions'. Is the assembly missing or incompatible with the current platform?
Reference validation can be disabled in the Plugin Inspector.
Unable to resolve reference 'Microsoft.Extensions.DependencyInjection'. Is the assembly missing or incompatible with the current platform?
Reference validation can be disabled in the Plugin Inspector.
Unable to resolve reference 'Microsoft.Extensions.Options.ConfigurationExtensions'. Is the assembly missing or incompatible with the current platform?
Reference validation can be disabled in the Plugin Inspector.

Any idea what I am doing wrong or how to fix it?
Thank you,
Etienne

I'll have a go at adding a project to Unity today and let you know if I get it working. It's been a while since I used Unity with Networker but need to make sure it's still OK!

I got it working for .NET 4.* but not for standard 2.0, there's some horrible reference conflicts going on
Change your Unity project to target .NET 4.*

• Create a new C# project which references Networker and targets .NET 4.7.2
• Set to Release
• Build
• Go to output and copy the .DLL files, put them into a folder in your Unity project called Plugins
• Create new script for your network code in unity project which derives from MonoBehavior

That worked! Thank you very much @MarkioE
Additionally I found a way to bundle all the dlls together to makes things a bit cleaner in Unity using ILRepacker by adding the following code in the vs project:
   	<ItemGroup>
   		<InputAssemblies Include="$(TargetPath)" />
   		<InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.DependencyInjection'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.DependencyInjection.Abstractions'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.Logging'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.Logging.Abstractions'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.Logging.Configuration'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.Configuration'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.Configuration.Abstractions'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.Options.ConfigurationExtensions'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.Options'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.Logging'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.Primitives'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'Microsoft.Extensions.Configuration.Binder'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'System.Memory'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'System.Runtime.Extensions'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'System.Buffers'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'System.ComponentModel.Annotations'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'System.Numerics.Vectors'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'System.Runtime'" />
     <InputAssemblies Include="@(ReferencePathWithRefAssemblies)" Condition="'%(filename)' == 'System.Runtime.CompilerServices.Unsafe'" />

   	</ItemGroup>

   	<ILRepack AllowDuplicateResources="false" DebugInfo="true" Internalize="true" InputAssemblies="@(InputAssemblies)" OutputFile="$(TargetPath)" Parallel="true" TargetKind="SameAsPrimaryAssembly" />
   </Target> ```

I have the same error . would you please give a unity project example to show the usage of client in unity3d.


YouTube no longer works

Message: Client error response [status code] 410 [reason phrase] Gone [url] http://gdata.youtube.com/feeds/api/videos/zCbfWGgp9qs?v=2&alt=jsonc

It looks like google deprecated v2 API. I will look into this ASAP. Thank you for reporting.

No problem. I think it's still doable of you use yql

Fixed youtube parser. It is not using API anymore, but takes information from meta tags.