SUNCG scene bug

While retrieving objectType data via demo.py new error occurred with one of the scenes:
2018-04-16 19:03:31,787 INFO b'preloading /root/data/suncg//navgrid_10/58306be361138410c5383bfc6af2b843/58306be361138410c5383bfc6af2b843.furnished.grid.json'
2018-04-16 19:03:31,787 INFO b'preloading /root/data/suncg//wall/58306be361138410c5383bfc6af2b843/58306be361138410c5383bfc6af2b843.arch.json'
2018-04-16 19:03:31,787 INFO b'preloading /root/data/suncg//wall/58306be361138410c5383bfc6af2b843/58306be361138410c5383bfc6af2b843.arch.json'
2018-04-16 19:03:31,790 INFO b'Removing subscribers for event drain [ 0 ]'
2018-04-16 19:03:33,589 ERROR b'/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:2555'
2018-04-16 19:03:33,589 ERROR b'\t    this.__remove(lru.id);'
2018-04-16 19:03:33,589 ERROR b'\t                      ^'
2018-04-16 19:03:33,589 ERROR b''
2018-04-16 19:03:33,589 ERROR b"TypeError: Cannot read property 'id' of null"
2018-04-16 19:03:33,590 ERROR b'    at AssetCache.set (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:2555:24)'
2018-04-16 19:03:33,590 ERROR b'    at Array.<anonymous> (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:73642:22)'
2018-04-16 19:03:33,590 ERROR b'    at LoadingAsset.done (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:73571:25)'
2018-04-16 19:03:33,590 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:73652:25'
2018-04-16 19:03:33,590 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/ssc/lib/file-util.js:117:9'
2018-04-16 19:03:33,590 ERROR b'    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:528:3)'
2018-04-16 19:03:33,745 INFO Finished simserver stdout
2018-04-16 19:03:33,745 INFO Finished simserver stderr

@kvas7andy can you also copy the corresponding log files as well?

Of course,
I attached log files in this comment.
simulator.log
simserver.log
This error with the same file occured while training unreal on suncg dataset, without using any objectType data (with almost the same config file, except a typo in objectgoal_suncg_mf.py - empty_room: True, but should be False):
2018-04-18 13:45:56,241 INFO b'starting memory= { rss:<PHONE_NUMBER>,'
2018-04-18 13:45:56,241 INFO b'  heapTotal: 690302976,'
2018-04-18 13:45:56,241 INFO b'  heapUsed: 329192120,'
2018-04-18 13:45:56,242 INFO b'  external: 392962798 }'
2018-04-18 13:45:56,242 INFO b'preloadData { loadSceneStatistics: true, loadSounds: false }'
2018-04-18 13:45:56,243 INFO b'Loading scene  p5dScene.58306be361138410c5383bfc6af2b843'
2018-04-18 13:45:56,261 INFO b'preloading /root/data/suncg//navgrid_10/58306be361138410c5383bfc6af2b843/58306be361138410c5383bfc6af2b843.furnished.grid.json'
2018-04-18 13:45:56,261 INFO b'preloading /root/data/suncg//wall/58306be361138410c5383bfc6af2b843/58306be361138410c5383bfc6af2b843.arch.json'
2018-04-18 13:45:56,261 INFO b'preloading /root/data/suncg//wall/58306be361138410c5383bfc6af2b843/58306be361138410c5383bfc6af2b843.arch.json'
2018-04-18 13:45:56,264 INFO b'Removing subscribers for event drain [ 0 ]'
2018-04-18 13:45:58,322 ERROR b'/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:2555'
2018-04-18 13:45:58,322 ERROR b'\t    this.__remove(lru.id);'
2018-04-18 13:45:58,323 ERROR b'\t                      ^'
2018-04-18 13:45:58,323 ERROR b''
2018-04-18 13:45:58,323 ERROR b"TypeError: Cannot read property 'id' of null"
2018-04-18 13:45:58,323 ERROR b'    at AssetCache.set (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:2555:24)'
2018-04-18 13:45:58,323 ERROR b'    at Array.<anonymous> (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:73642:22)'
2018-04-18 13:45:58,323 ERROR b'    at LoadingAsset.done (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:73571:25)'
2018-04-18 13:45:58,323 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:73652:25'
2018-04-18 13:45:58,323 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/ssc/lib/file-util.js:117:9'
2018-04-18 13:45:58,324 ERROR b'    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:528:3)'
2018-04-18 13:45:58,443 INFO Finished simserver stdout
2018-04-18 13:45:58,444 INFO Finished simserver stderr

The same error with another scene:
simserver.log
simulator.log
2018-04-16 23:21:18,792 INFO b'starting memory= { rss:<PHONE_NUMBER>,'
2018-04-16 23:21:18,792 INFO b'  heapTotal: 947347456,'
2018-04-16 23:21:18,792 INFO b'  heapUsed: 566072544,'
2018-04-16 23:21:18,792 INFO b'  external: 367284817 }'
2018-04-16 23:21:18,792 INFO b'preloadData { loadSceneStatistics: true, loadSounds: false }'
2018-04-16 23:21:18,792 INFO b'Loading scene  p5dScene.25a19fa80aac90b4cf22aea24e4b7032'
2018-04-16 23:21:18,849 INFO b'preloading /root/data/suncg//navgrid_10/25a19fa80aac90b4cf22aea24e4b7032/25a19fa80aac90b4cf22aea24e4b7032.furnished.grid.json'
2018-04-16 23:21:18,849 INFO b'preloading /root/data/suncg//wall/25a19fa80aac90b4cf22aea24e4b7032/25a19fa80aac90b4cf22aea24e4b7032.arch.json'
2018-04-16 23:21:18,849 INFO b'preloading /root/data/suncg//wall/25a19fa80aac90b4cf22aea24e4b7032/25a19fa80aac90b4cf22aea24e4b7032.arch.json'
2018-04-16 23:21:18,851 INFO b'Removing subscribers for event drain [ 0 ]'
2018-04-16 23:21:20,114 ERROR b'/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:2555'
2018-04-16 23:21:20,114 ERROR b'\t    this.__remove(lru.id);'
2018-04-16 23:21:20,115 ERROR b'\t                      ^'
2018-04-16 23:21:20,115 ERROR b''
2018-04-16 23:21:20,115 ERROR b"TypeError: Cannot read property 'id' of null"
2018-04-16 23:21:20,115 ERROR b'    at AssetCache.set (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:2555:24)'
2018-04-16 23:21:20,115 ERROR b'    at Array.<anonymous> (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:73642:22)'
2018-04-16 23:21:20,115 ERROR b'    at LoadingAsset.done (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:73571:25)'
2018-04-16 23:21:20,115 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:73652:25'
2018-04-16 23:21:20,115 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/ssc/lib/file-util.js:117:9'
2018-04-16 23:21:20,115 ERROR b'    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:528:3)'
2018-04-16 23:21:20,253 INFO Finished simserver stdout
2018-04-16 23:21:20,254 INFO Finished simserver stderr

One more scene, with the same problem: "f3bb9c723c8f8f50827f92741a463b24"
simserver.log
simulator.log
Do you have any ideas, what the problem is?

After update, one more run of objectgoal_suncg_mf.py for unreal algorithm didn't throw any error!
But, as noticed before (in previous comment), running demo.py after node_modules rebuild throw such error with another scene (I had to sort out p5dScene.58306be361138410c5383bfc6af2b843 scene, but error occured with new scene).

@kvas7andy This issue was due to over-eager cache clearing logic which would occasionally fail when the cache was empty.  The v0.5.3 update resolves this bug.  I will close the issue but please re-open if you still encounter the same problem.

Hi,
I haven't checked before update, but now occurred another problem, while running unreal:
2018-04-27 22:05:35,401 INFO b'Timing waitImages: 161.092ms'
2018-04-27 22:05:35,577 ERROR b'THREE.WebGLRenderer: EXT_texture_filter_anisotropic extension not supported.'
2018-04-27 22:05:35,757 INFO b'Timing start: 35099.751ms'
2018-04-27 22:05:42,296 INFO b'Seeding simulator rng with 46722566'
2018-04-27 22:06:07,592 INFO b'SimState.sample: 2284.321ms'
2018-04-27 22:06:07,592 INFO b'set active level 0'
2018-04-27 22:06:07,682 ERROR b'/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:106471'
2018-04-27 22:06:07,683 ERROR b'\t      callback(err, scope.state.sceneState);'
2018-04-27 22:06:07,683 ERROR b'\t      ^'
2018-04-27 22:06:07,683 ERROR b''
2018-04-27 22:06:07,683 ERROR b'TypeError: callback is not a function'
2018-04-27 22:06:07,683 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:106471:8'
2018-04-27 22:06:07,683 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:35013:17'
2018-04-27 22:06:07,683 ERROR b'    at next (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:39855:30)'
2018-04-27 22:06:07,683 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:35498:17'
2018-04-27 22:06:07,683 ERROR b'    at Timeout._onTimeout (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:106467:35)'
2018-04-27 22:06:07,684 ERROR b'    at ontimeout (timers.js:458:11)'
2018-04-27 22:06:07,684 ERROR b'    at tryOnTimeout (timers.js:296:5)'
2018-04-27 22:06:07,684 ERROR b'    at Timer.listOnTimeout (timers.js:259:5)'
2018-04-27 22:06:07,764 INFO Finished simserver stdout
2018-04-27 22:06:07,765 INFO Finished simserver stderr

simserver.log
simulator.log
After killing the process with Ctrl+C in terminal, python process still works, while node processes exit.

Hi @msavva,
Unfortunately, I am not good at debugging javascript. However, I think this is not a difficult mistake.
I cannot re-open my own issues, if a repo collaborator closed it.

@kvas7andy This looks like a different issue -- we'll look into it from our side.  Do you observe this consistently soon after starting the simulation?

I thought the problem is linked to the update of version "v0.5.3", that's why commented it here.
It seems to occur consistently, as I tried different envs with unreal training, and, while running demo.py. I think, particularly, when environment resets.


Web Notification front end [Desktop]

As a commentor/author of a post, I want to receive a notification for every comment posted, as well as when a post or comment is edited.
Current Scenario: When someone comments on my post, I don't know right away because I'm not sent an email or notification.
Expected results: As soon as someone comments on my post or likes/shares it, I should see a web notification to alert me, (similar to notifications on facebook or reddit)
Initial design: https://fightpandemics.slack.com/archives/C018ZNAD62Y/p1598344009136700

The changes have been merged into PR #1677 , I'm going to close this thread


BigImage: Add merger of overlapping noaa records from different stations

The NOAA recordings of different stations should be mergable.
It will provide two advantages:

it will increase the image size and mage it bigger, because overlapping parts of each station adds up.
the pixels with several sources will be "stronger". This means that of one image line is noisy in the recording on station 1, it can be with lower noise at station 2 and decreasing the signal to noise level of the combined solution.

synchronization of the images can be achieved with 3 methods:

by taking the minute marker (only possible with longer recordings).
by using line matching. taking one line and find this pattern by correlation in the other recoring
by the dgsn gps synch method. this is only possible with DGSN stations.

Hi horning I would like to work on this issue can you guide me where i can get started.


Add Generate data section to README.md

Related: https://github.com/webmproject/codec-compare/issues/5


[Feature Request] Add LSP support for multiple programming languages.

Hi, I would like to request for LSP support for this app if it's possible, just like in lunarvim. LSP is a great feature.

Thank you for your suggestion. I'll find a way to implement it next versions.

Having LSPs such as rust-analyzer and gopls would be cool. I'm looking forward to it. Cheers!

I am also looking for support for my favourite language. Do you accept some kind of bounty or something like that? I really would like to have this feature in order to have the following feature for the C language:

Go to definition
Go to declaration
Find usages
Syntax highlighting (including syntax error highlighting)

Check out plugins


include step contracts:external in start script

I guess it makes sense to include contracts:external in the start script in order to hide it from the user.

@dvinubius The docs need to be updated, but we want the user to run

yarn contracts:build
'yarn chain`
yarn deploy
yarn start

I don't think I want to hide that from the user.  rebuilding contracts may change their addresses and have other impacts,s o currently its not something I would want to do.
what do you think?

Yes, then it's closer to my initial commit, where I just edited the readme.
Although I see we have no more contracts:build, but contracts:external

Not sure I understand what impact this step may have. I gathered it's just about making the external contracts available to the hooks. It's not related to the hardhat contracts. I've only been using the TS repo since yesterday, so I assume the contracts:build step (which is now not among the scripts any longer) was also related to the deployed hardhat contracts?

What i meant was yarn contracts:build is a command in the root workspace.  It uses yarn contracts:external.  yarn contracts:external is a destructive operation that is slow and i think its a good idea to pair it with yarn start
the commands i mentioned above are all from the root workspace

Cool, thanks for clarifying

@dvinubius  i've updated the eth-hooks docs as well:  https://www.npmjs.com/package/eth-hooks


Fix seeking behaviour

I discovered that the cause of intermittent seeking behaviour across machines and platforms was due to using the address of an out-of-scope stack variable. This PR contains three patches to fix and robustify seeking behaviour.

Nice finds!
Thanks a lot, Steven.
Much appreciated.


New principled type oriented code generation

👋 Sorry for the gigantic PR :)
This is in a lot of ways a rewrite with some specific goals, so I'll attempt to describe what these are and what features are enabled.
Easy code generators
My number one goal with this was to make it easy to make new code generators that were feature-full. To this end all the built-in generators are under 100 lines of code, and most of that code is obvious.
Customization
It would be hard work to build all possible code generators ourselves and it would be good for users to have a way to build their own with minimal fuss (and then potentially contribute them). As such the design now exposes an interface to build code generators, as well as an argument to rule to include them.
Feature Full
Although the code generators are simple, I wanted them to support everything the user can throw at them. As such, they support:

Every kind of type Elm has to offer, including custom types, records, extensible records, tuples, primitives, recursive types, mutually recursive types, opaque types, etc.

Automatically create auxiliary definitions for named records and custom types:
type Foo
    = Foo Bar

type alias Bar =
    { x : Int }

generate : MyThingy Foo
generate =
    Debug.todo ""

will generate something like
generate : MyThingy Foo
generate =
    MyThingy.map Foo thingifyBar

thingifyBar : MyThingy Bar
thingifyBar =
    MyThingy.record "x" MyThingy.int

Error handling by using the detail field in elm-review errors. This is a slight departure, as before errors were handled by emitting more Debug.todo "can't handle this" snippets. I think the elm-review philosophy seems to be more into the "only offer a fix if you are sure it's correct" territory, so I think this is preferable.

Using existing definitions in the codebase if available.

Generics by taking in arguments of the same type. So if we have a generator for Foo <x>, then it will automatically support generating Foo a -> Foo (SomeType a). These are properly matched, so it would also support Foo b -> Foo a -> Foo c -> Foo (Other a b c) for instance.

Automatically resolving imports and aliases. This means that the author of a code generator only has to deal with fully qualified names and is guaranteed that all inputs will be transformed into fully qualified and all outputs will be transformed into whatever import style the user uses in that module. Missing import statements will be automatically generated.

Drop in replacement for elm-review-debug. Before the rule would only report Debug.todo that it thought it could fix. Now it reports all uses of Debug.todo as well as Debug.toString. To make it a true drop-in replacement, we would need to copy paste the NoDebug.Log rule, however I think that would work without modification.

Basic code simplification after generation. This ensures that generated code is still idiomatic, yet allows the code generators to be very simple by not needing to take into account complex combinations. This for instance transforms
(\x ->
    case x of
        Foo bar ->
            doSomething bar

        Baz qux ->
            doSomethingElse qux
) myRecord.myField

into
case myRecord.myField of
    Foo bar ->
        doSomething bar

    Baz qux ->
        doSomethingElse qux

Solid building blocks
I think in some ways the most important thing here is the ResolvedType type. It's a full representation of everything we know about a type from the perspective of a module. As such it unifies type annotations with type declarations, but also concerns like import visibility and generics resolution. Constructing this ResolvedType is the main step of having robust code generation, as the code generation is then "just" mapping this type into AST.

Also some practical notes:
Limitations

The way these generators are set up, they currently only talk about a single type. This works fine for most things (indeed I have ported all the code generators to this new system), except for the migrate code generator. I've marked all it's tests skipped for now, but there needs to be some further action taken to support it. One option is to add it as a special custom case, albeit perhaps benefiting from the ResolvedType abstraction. Another option is to drop it from the first release. Finally, we could extend the mechanism to support multiple different types, however that might require some careful design work.

The TypePattern type is at the moment limited to a single occurrence. This makes it impossible to make generators for i.e. interpolators (<t> -> <t> -> Float -> <t>). This could be easily extended by making the matching function a bit smarter to assert that the Target constructors are the same when they occur multiple times, however I haven't done this work yet.

Furthermore, there is no mechanism for dealing with changing generics in type signatures either. This would be required to be able to generate i.e. mapping function ((a -> b) -> <t containing a> -> <t containing b>). Again I think such an extension could be added, but I haven't explored this in detail.

Documentation has been written for some things, but more should be added before this can be reasonably published.

I have added loads of unit tests, but I think actually using this in anger on a project would be a good way to get more confidence in how robust this actually is.

I just checked the elm-review documentation and it is possible with npx elm-review --template MartinSStewart/elm-review-todo-it-for-me/preview#temp --fix-all. So it wasn't a blocker 👍

That's fine. This is quite a step forward and I think I'll merge this in once I've had some time to look at the code more thoroughly (probably will have be during this weekend).

Merged! Thanks again for your help!


[Feature Request] "Volume" download

With Royal Road allowing to organize chapters into Volumes it would be useful to download a specific Volume.

On a sidenote: in pair with --from-chapter a --to-chapter equivalent would be useful. Also using RR chapter id (https://www.royalroad.com/fiction/49717/the-rise-of-the-winter-wolf/chapter/812891/b1-prologue -> 812891) to specify chapter range would make more sense than counting chapters. Yes, that would require looping over the entire chapter URL list once before the download but it is simpler for user-side. An universal option would be something like --chapter-range that allows standard range expressions e.g. "812891-812991,812993,812995" with addition of something like a wildcard symbol to denote an open range.
I digress, the feature request is only about the Volume download.

This seems reasonable, I'll take a closer look next week.

As far as i understand you parse a tags with href that starts from /fiction and contains /chapter
https://github.com/Aivean/royalroad-downloader/blob/8e7f4fdcb0d2b1dcb3a51333445123016126eec3/src/main/scala/com/aivean/royalroad/Main.scala#L36
But instead if you parse tr tags

            Chapter 68: Arrival

            <time unixtime="1639068708" title="12/9/2021 4:51:48 PM +00:00" format="agoshort">3 months </time> ago

and find tr you actually need by filtering data-url for /fiction and /chapter you also get data-volume-id attribute which contains either volume id or null. Then you can additionally search for volume name by searching tags for id="volume-N-label" where N is the data-volume-id.

Volume 1

@Raisoshi

Is "--from-chapter" a command? Where do I see how to use it and other available commands? Sorry if this is obvious, I can't see anything about it in the Code page or the readme

It's an an argument.
You can run the program with:
java -jar royalroad-downloader-assembly-VERSION.jar --help

to see the usage.
In short,
java -jar royalroad-downloader-assembly-VERSION.jar --from-chapter 123 https://link-to-the-book

should be the syntax.

Honestly, I'd just be happy with being able to save every chapter as a separate file.

What's the use case for that?

A --to-chapter argument would be nice too.

Huh, I thought it already exists. Ok, I'll add it when I finally find some time :)

I wrote a simple implementation of this for myself, sharing here in case someone finds it useful.
https://gist.github.com/nozwock/c692697b28fda884826a96593967a21c
This will download the fictions volume-wise.
usage: royalroad_fiction_scraper.py [-h] [-o DIR] [--max-active-requests INT] [--max-rate FLOAT] [--rate-period FLOAT] URL

positional arguments:
  URL                   eg: 'https://www.royalroad.com/fiction/000...'

options:
  -h, --help            show this help message and exit
  -o DIR, --output DIR
  --max-active-requests INT
                        [default: 10]
  --max-rate FLOAT      [default: 1]
  --rate-period FLOAT   [default: 0.1] In seconds.

Example:
python royalroad_fiction_scraper.py 'https://www.royalroad.com/fiction/62881/reborn-as-a-demonic-tree'

'Reborn as a Demonic Tree'
├── 01-Index
│  ├── '000-Art Chapter.html'
│  └── cover.jpg
├── '02-Book One'
│  ├── '001-Chapter 1: A Scrumptious Meal.html'
│  ├── ...
│  ├── '090-Chapter 90: A Chance at Rebirth [END OF BOOK 1].html'
│  └── cover.jpg
├── '03-Book 2'
│  ├── "091-Chapter 91: Ashfallen sect's new member [START OF BOOK 2].html"
│  ├── ...
│  ├── "169-Chapter 168: Ashfallen's rise [Book 2 Epilogue].html"
│  └── cover.jpg
└── cover.jpg


[Feature] Make vLLM optional in model code

Motivation
This is a tracker of removing vLLM dependencies in general model code (not considering quantization). This is our current  import from vLLM, and we want to remove all them.
from vllm.config import CacheConfig
from vllm.distributed import get_tensor_model_parallel_world_size
from vllm.model_executor.layers.rotary_embedding import get_rope
from vllm.model_executor.layers.vocab_parallel_embedding import (
   ParallelLMHead,
   VocabParallelEmbedding,
)

Tracker

[x] Remove CacheConfig: https://github.com/sgl-project/sglang/pull/1658
[ ] Remove RoPE: https://github.com/flashinfer-ai/flashinfer/issues/530
[ ] Remove get_tensor_model_parallel_world_size
[x] Remove ParallelLMHead: https://github.com/sgl-project/sglang/pull/1856
[x] Remove VocabParallelEmbedding:  https://github.com/sgl-project/sglang/pull/1856

Just curious, are the following imports in model_runner.py also being considered for removal, in later stages
from vllm.config import DeviceConfig, LoadConfig
from vllm.config import ModelConfig as VllmModelConfig
from vllm.distributed import (
    get_tp_group,
    init_distributed_environment,
    initialize_model_parallel,
    set_custom_all_reduce,
)
from vllm.distributed.parallel_state import in_the_same_node_as
from vllm.model_executor.model_loader import get_model
from vllm.model_executor.models import ModelRegistry


I can't open the website.

I found I can't open the website now: https://nebulaswallet.app/
Who can fix it?

There wasn't enough interest from the community, so I haven't worked on this project in the last 3 months.


feat: Table.keep_only_rows

Summary of Changes

New method Table.keep_only_rows. This is consistent with Table.keep_only_columns.
Deprecate Table.filter_rows, which does the same thing. It will be removed in a future version.

:tada: This PR is included in version 0.24.0 :tada:
The release is available on:

v0.24.0
GitHub release

Your semantic-release bot :package::rocket:


Fatal error: Unable to find local grunt

Hi - it would be helpful if local grunt could be installed somehow, as it's expected to exist as a reference in :

/home/jenkins/workspace/project-directory/package.json

then it should be installed running the command "npm install" , but it can't be installed locally due to permission issues.
Other than this I find this image a lifesaver in a lot of situations due to it's extensive tools inclusion.

grunt is included in the existing images.


Anything worth pulling in from my fork?

Hi, I've made a bunch of tweaks in my fork of your project. I understand that I kinda went to town on the code so my changes might not align with your original goals. Nonetheless I tried to make the commits self-contained so if any of these are of interest to you let me know and I can raise one or more PRs.
(oldest first):

5af40ff Remove extern crates declarations (not needed in Rust 2018)
9b26b73 Address cargo warning
30c0a2a Remove unnecessary to_string call
a107dca Make RetentionPolicy::parse a FromStr impl
e6565cb Remove unnecessary copy of snapshots in check_age
9c8e655 Use lines and is_empty in _call_read
a1e14a1 Construct age check result at end of gc_find
7b63abf Avoid copying SnapshotMetadata in gc_find
fe9a103 Add tests for RetentionPolicy::from_str
f1722bd Drop regex and lazy_static dependencies
5fdf101 Drop anyhow dependency
1896827 Extract _parse_snapshots function and add tests
e9da9d6 Replace unwraps and panics with errors
7bc4201 Tidy up check_age
58c14c7 Split library code out of the binary
2c4e878 Make check_age a method of RetentionPolicy
1f53496 Tidy up main function
b0a83ad Add CI
f01c0257 Implement cargo clippy suggestions

Hey! Sorry, my email client ate the notification. This is a lot of really excellent work - thank you a million. I consider the tool feature complete, but this is exactly the kind of review, cleanup & polish it needed.
I've cherry-picked the commits I liked (almost everything) and reverted only two lines - I find continue next_rule; easier to follow ;)
Are you currently using zfs-autosnap in production? Have you had any issues, found any rough edges?

Are you currently using zfs-autosnap in production? Have you had any issues, found any rough edges?

Only on my desktop. I run Linux (Arch) and my home directory is on a ZRAID pool of 3 SSDs. I started running my fork of zfs-autosnap on it a month ago, scheduled with the systemd timers in my repo and all it has been working fine. I needed to use a snapshot to restore a file merely days after setting it up too.

Hey boys,  im using your versions, actually @wezm one in production, instead of the official autosnap tools.
Thought that wezms one is a bit newer simply.
So far everything works great 👍
I would only suggest only 1 improvement:

You can limit hourly snapshots to let's say 6 per day.
With systemd service or a cronjob, you can simply change the interval to every 4 hours, for example with systemd "OnCalendar=00/4:00"
So you get spreaded daily snapshots, 6 of them every 4 hours.
Would be actually great that someone is able to spread the same way daily snapshots.
Let's say, you do 5 weekly (every day for the last 5 days), and 14 monthly: but that 14 will get spreaded over the month (like with hourlys above), because you have already a weekly variable.

Now, actually this is a bit confusing: let's say i do: 7/week and 14/month, so you get of the last week 7 snapshots + 14daly snapshots per month.
Doesn't that mean that i get simply the last 14 daily snapshots of the month? And the weekly variable can be ignored?
That's what im finding a little confusing and where i think that the documentation needs a little improvement.
I mean about the weekly variable.
Im running the utility about 4 days now, so i actually need to wait a bit to see what the actual behavior is with the weekly ones.
But when i change the variable to experiment what happens, ill need to wait forever 😂
So i thought to write here!
Thanks btw for the tool, i do like it a lot, because you can set different routines for datasets in a very nice and visible way, instead of fu*king with 6 different variables per dataset😂

Hi @Ramalama2, you should probably open a new issue for questions. I will close this one as after merging @wezm's changes the forks are pretty much identical (and he's kind enough to provide automated builds).
Trying to answer your questions below:

You can limit hourly snapshots to let's say 6 per day.
With systemd service or a cronjob, you can simply change the interval to every 4 hours, for example with systemd "OnCalendar=00/4:00"
So you get spreaded daily snapshots, 6 of them every 4 hours.
Would be actually great that someone is able to spread the same way daily snapshots.

The whole point of this utility is it does not differentiate, which snapshot is supposed to be "hourly" or "daily" - it just takes a snapshot whenever instructed to (e.g. by cron, anacron, systemd timer, manually, while sleep $RANDOM; do zfs-autosnap snap; done, however you choose to run it). That's it - you can take snapshots as (in)frequently as you wish to, on any schedule you like, it's all 100% up to you, and how you configure your schedules. You don't even need to take the snapshots with this utility - as long as they inherit the at.rollc.at:snapkeep property (which happens by default even on 100% manual snapshots), they will be considered for automatic GC.
This is also why you do zfs-autosnap gc in a separate step, and decide on your own retention policy. The retention policy will just decide which snapshots to keep:

Now, actually this is a bit confusing: let's say i do: 7/week and 14/month, so you get of the last week 7 snapshots + 14daly snapshots per month.

Doesn't that mean that i get simply the last 14 daily snapshots of the month? And the weekly variable can be ignored?

The "weekly" retention policy does not mean "X daily snapshots in the last week", it means "consider the ISO week number and the the year as the bucket, limit the number of buckets to 7, put each snapshot into it's week's bucket, and keep 1 freshest snapshot from each bucket" - so with your policy (7w14m), you will retain 7 snapshots (one from each Sunday: Dec 18th, Dec 11th, Dec 4th, etc), plus 14 more snapshots (one from each last day of the month: Oct 30th, Nov 31st, Sep 30th...), not just the last 14 days (that would be a 14d policy).
I suggest that you turn off GC on your machine for a couple of days, weeks or months (as space allows), and run zfs-autosnap status at different points in time, to see what it WOULD do. Also browse the source for the function check_age, it's written to be as readable as I could make it, and includes a fair bit of commentary that explains what's going on at each step.

That's what im finding a little confusing and where i think that the documentation needs a little improvement.

Yes, as you may have noticed from the README, it's a quick & dirty rewrite of a quick&dirty old script that just happens to have caused exactly 0 data loss problems (and prevented MANY) in the 6+ years that I've been running it ;) I might eventually get to properly documenting and explaining this, but you are more than welcome to give it a try yourself.
Closing the issue, if you'd like to follow up please open a new one (or feel free to email me).

Thank you very much for explaining!
I do what you said, with turning off gc and wait a month or so, to check with status what gc would delete/keep.
That's very clever, thx!
Otherwise i do like the utility, it's great, thanks for the work and sorry for posting here 🙈
I can do the documentation pull request myself, in a month or so.
Thx & Cheers!


std::basic_string<uint8_t> is broken for LLVM-19

Describe the bug
The uint8_t type is typedef'ed as unsigned char in glibc. However the support for unsigned char type has been removed from std::char_traits in libc++ according to https://reviews.llvm.org/D138307. This gives an "implicit instantiation of undefined template std::char_traits<unsigned char>" error, during build.
To Reproduce
Steps to reproduce the behavior:

Compile D++ using the latest libc++.

System Details:

OS: Linux

Additional context
I would like to know what could be the proposed fix for this? I wouldn't mind sending the PR.

what thing in dpp actually causes the warning, under what compiler and version?

I'm not sure this needs to be a string, perhaps a vector would suffice? it is important for it to be unsigned 8 bit wide elements though.

Yeah, I agree.

Any news on this?

Idk we just need to have someone pick this up

I can look into this next week

I can look into this next week

No unfortunately I just got extremely busy 😔

I think we should close this issue.


Clearer indication of when spoofing is needed

When URL-spoofing is needed, the error should not only be more informative but since SynBioHub knows its in a spoofing mode, its response should give breadcrumbs to indicate that spoofing is likely the correct answer.

closing for now, as we seem to have kinda figured out spoofing with sbh2


glShaderSource has different behavior in release mode

Rust version: 1.29.0
gl version: 0.10.0
Expected behavior: When I call gl::ShaderSource, it uploads the source found behind the pointer.
Actual behavior: In debug mode (cargo run) this works fine, but in release mode (cargo run --release) the shader just ends up containing garbage data according to GetShaderSource.
I'm calling glShaderSource with parameters I've initialized outside of the unsafe block, so I would assume my code shouldn't cause this.
Code:
let create_shader = |t: GLuint, source: &'static str| {
    let len = [source.len() as GLint].as_ptr();
    let source = [source.as_ptr() as *const GLchar].as_ptr();
    let shader;
    unsafe {
        shader = gl::CreateShader(t);

        // FIXME: This doesn't actually upload the source when ran with --release.
        gl::ShaderSource(shader, 1, source, len);

        let mut uploaded = [0; 10];
        gl::GetShaderSource(shader, 10, ptr::null_mut(), uploaded.as_mut_ptr());
        // Debug mode prints out (and this matches the actual string): [35, 118, 101, 114, 115, 105, 111, 110, 32, 0]
        // Release mode prints out (and changes every run): [-24, -24, -100, -124, -45, 0, 0, 0, 0, 0]
        println!("{:?}", uploaded);

        gl::CompileShader(shader);
    }
    shader
};

It's part of this project in case more context is needed.

Weird - I wonder if this is running into some UB (undefined behaviour) that LLVM is now taking advantage of? I'm afraid I'm a bit out of my depth on this one.
cc. @kvark

Might be interesting to compare the assembly output at both optimization levels.

Let's keep this open please. Unsafety issues like this are difficult to discover and should get proper treatment.

@neonmoe is there a particular revision I could grab from your project to reproduce this on my side?

Also please note that this code is incorrect:
gl::GetShaderSource(shader, 10, ptr::null_mut(), uploaded.as_mut_ptr());

The length passed doesn't include the null terminator, which is still written by the GL driver. So this line causes out of bounds writes.

Thank you, that's a good repro case. I had a chance to look at it.
Moral of the story - don't play with pointers!
    let len = [source.len() as GLint].as_ptr();

Here, rust sees that you need a local fixed size array (of size 1) on the stack, and it's happily allocating it. However, it's not getting any name assigned, so it's lifetime is contained within this very line... as soon as you take as_ptr() of it - POOF! it's gone!
let source = [source.as_ptr() as *const GLchar].as_ptr();

The same thing happens here. In Release (starting with opt-level = 1), the compiler is happily re-using the same stack space (since, as we noted, it's lifetime is a single line of code), thus you end up passing the same pointer for both the source and the length to GL :)
With this, I think the issue can be closed. It's not a bug in gl-rs :tada:

Oh, that makes a lot of sense. Thank you for the explanation!


Unable to enter decimals in Spring Image View

Hi guys,
I am not able to enter decimals in the attributes inspector of Spring.
It is only accepting whole numbers. Any idea why?
In the video demo. MengTo shows entering of decimal number in force, scale etc. but I am not able to do that.
I am using Xcode 6.4
Look forwards to some advice.
Regards
Steven

I believe that in some keyboard languages, you need to enter a comma instead of a dot.
Thanks! Meng
On Sun, Jul 12, 2015 at 9:29 AM, kktay281<EMAIL_ADDRESS>wrote:

Hi guys,
I am not able to enter decimals in the attributes inspector of Spring.
It is only accepting whole numbers. Any idea why?
In the video demo. MengTo shows entering of decimal number in force, scale etc. but I am not able to do that.
I am using Xcode 6.4
Look forwards to some advice.
Regards
Steven
Reply to this email directly or view it on GitHub:
https://github.com/MengTo/Spring/issues/83

Thanks for the Tips Meng.
Indeed it is due to the languages. I have US keyboard setup but the region was Netherland and this automatically set the decimal and comma according to the local standard here.


Added support for Azure Openai

Added support for Azure Openai.  Thank you for your work.

@minimaxir  could you take a look at this PR. Happy to add / modify anything. It adds only support for Azure openai.

There is a lot changed here so I need to test on Azure OpenAI myself but haven't had the time.

Hello, any update @minimaxir on when this PR might be accepted?


DRY'ify show actions

Show actions and their respective templates could be made simpler and not repetitive by creating a new utility which would automatically generate contents of show templates. That utility could decide which fields of entities to display by using field annotations.

https://github.com/okulbilisim/ojs/commit/ee13c650e3774783619a36dc5afb290e4250f28d via JMSserializer works perfectly


Need guide for custom connect

Can you please create a guide on how to use custom connect?

This is already available here: 31670fa0b3940f761ed9ad0cd4485ccc37a5a617


add default models to docker image

Pull Request
Description
Add default models to the docker image. The models are on the order of 100MB in size for pvnet and the summation model. The models will be saved to the on-disk model cache and this means we do not need to download them from huggingface each time we run the app.
This seems neater and makes us less susceptible to rare huggingface outages, as happened today.
Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

Did you try it locally? did it work?


Downgrade Python Language Server command

I like that the Python Language Server automatically updates itself in the background, but occasionally updates have rendered VSCode unusable due to high CPU usage or memory leaks. This obviously impacts my work.
It would be great to have an easy way of manually downgrading the language server until issues are resolved and another update is released.
Just for reference, I'm currently experiencing the issue described here and would love to just downgrade to the previous version of the LS which worked perfectly fine.

We have no plans on supporting this feature.
Please consider one of the following:

Install an older version of the extension  (you can do this from VS Code itself)
Use the Jedi language server (go into settings.json and enable the setting "python.jediEnabled": true

Here is a stack exchange post showing how to install an older version from VSCode itself.

Install an older version of the extension (you can do this from VS Code itself)

This does not have the desired effect. Regardsless of which older version of the Python extension is installed it always seems to fetch the latest version of the Python language server.
In the screen shot below an older Python extension is still using the latest Language server. I have tried a couple of different versions of the Python extension and they all download this version of the language server.

Use the Jedi language server (go into settings.json and enable the setting "python.jediEnabled": true

This is a successful workaround to the memory problem


thread 'main' panicked at src/refine/refinery.rs:115:33

Hello,
I have unfortunately been running into a few issues while trying to use Rosella recently. Oddly enough I was able to use it previously without issue and when I had to remove then reinstall the conda environment I cannot seem to get it to work. I had issues when I did not supply the coverage file, but then I went and produced a coverage file with metabat and input the coverage file into my command and now I am getting the following:
Command -> rosella recover --assembly contigs.fasta -C metabat_contigs_coverage.txt -t 31 --output-directory rosella_bins
output ->
[2024-10-15T20:40:55Z INFO  rosella] rosella version 0.5.4
[2024-10-15T20:40:55Z INFO  rosella::recover::recover_engine] Calculating contig coverages.
[2024-10-15T20:40:55Z INFO  rosella::recover::recover_engine] Calculating TNF table.
[2024-10-15T20:40:57Z INFO  rosella::recover::recover_engine] 277448 valid contigs, 0 filtered contigs.
[2024-10-15T20:40:57Z INFO  rosella::recover::recover_engine] Time - 15:40:57 15-10-2024
[2024-10-15T20:40:57Z INFO  rosella::recover::recover_engine] Command - /home/.mamba/envs/rosella/bin/flight bin --input metabat_non_xenia_non_sym_contigs_coverage.txt --kmer_frequencies xenia_rosella/kmer_frequencies.tsv --output xenia_rosella --min_contig_size 1500 --min_bin_size 200000 --n_neighbors 100 --cores 31
[2024-10-15T20:41:05Z INFO  rosella::recover::recover_engine] Filtering disconnected contigs...
[2024-10-15T20:41:05Z INFO  rosella::recover::recover_engine] Filtering Params - Max: 3.550032, 0.039308, 4445 Min: 3.698970, 0.003999, 1872
[2024-10-15T20:41:24Z INFO  rosella::recover::recover_engine] Found 411 disconnected points. 411 TNF disconnected and 0 ADP disconnected...
[2024-10-15T20:41:24Z INFO  rosella::recover::recover_engine] Filtered 411 contigs...
[2024-10-15T20:41:24Z INFO  rosella::recover::recover_engine] Creating initial embedding of 280 contigs...
[2024-10-15T20:41:24Z INFO  rosella::recover::recover_engine] Creating intersected UMAP...
[2024-10-15T20:41:32Z INFO  rosella::recover::recover_engine] Clustering UMAP embedding...
[2024-10-15T20:41:33Z INFO  rosella::recover::recover_engine] Embedding unbinned contigs...
[2024-10-15T20:41:33Z INFO  rosella::recover::recover_engine] Creating intersected UMAP...
[2024-10-15T20:41:33Z INFO  rosella::recover::recover_engine] Preparing output for parsing...
[2024-10-15T20:41:33Z INFO  rosella::recover::recover_engine] Binning filtered contigs...
[2024-10-15T20:41:33Z INFO  rosella::recover::recover_engine] Writing bins... 12
[2024-10-15T20:41:34Z INFO  rosella::recover::recover_engine] Writing clusters.
thread 'main' panicked at src/refine/refinery.rs:115:33:
attempt to divide by zero
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Here is the output of head metabat_contigs_coverage.txt
contigName      contigLen       totalAvgDepth   sorted_read_alignments_to_non   sorted_read_alignments_to_non-var
NODE_353_length_27116_cov_87.845423     27116   194.504 194.504 543.121
NODE_1805_length_13210_cov_65.677233    13210   104.421 104.421 423.02
NODE_1919_length_12750_cov_75.069870    12750   95.8071 95.8071 588.248
NODE_2035_length_12320_cov_69.101345    12320   106.653<PHONE_NUMBER>.08
NODE_2080_length_12179_cov_89.299159    12179   199.612 199.612 499.589
NODE_2144_length_12015_cov_98.964883    12015   169.155<PHONE_NUMBER>.02
NODE_2364_length_11340_cov_83.420027    11340   123.715<PHONE_NUMBER>.02
NODE_2714_length_10441_cov_3.495282     10441   5.4776  5.4776  16.5699
NODE_2959_length_9888_cov_74.982915     9888    101.181 101.181 584.575
Thank you for the program and any help/guidance you can provide!

Hello!
Sorry my delay in responding, I've had my hands a bit full. So the good news, rosella is failing at this particular line:
let extra_threads = max(self.threads / self.mags_to_refine.len(), 1);

Due to a divide by 0 error. A silly mistake on my end. But it means that rosella found 0 mags to refine, so the output that currently exists should be the MAGs that rosella would have finished on. So you can take that output as the output of rosella, if it exists.
I'll fix this small issue. Does that make sense?
Cheers,
Rhys

No worries at all, completely understandable. Yes, that makes sense. Ouput files seems to be there. Thanks for the help and for the tool!


Kirstie's TO DO list - week starting 3rd July 2017

NSPN

[ ] MRI numbers report #54 Deadline: 7th July
[ ] Version error with NSPN code - see NSPN_WhitakerVertes_PNAS2016 issue 11

NORA

[ ] Upload filtered_func_data.nii.gz & send info to meta analysis inquiry

Peer reviews

[ ] A0026 deadline 2nd July
[ ] A0027 deadline 9th July
[ ] A0020 deadline 10th July
[ ] A0028 deadline 17th July

Emails: SH - preregistration, JS & EDP WOW & open leadership, S follow up w AA-S


Fault to download an existing video, no clue why, sorry

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE
% youtube-dl https://youtu.be/6Z0GwgiOs1U --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'https://youtu.be/6Z0GwgiOs1U', u'--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 2.7.13 (CPython) - Darwin-22.4.0-x86_64-i386-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] 6Z0GwgiOs1U: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1794, in _real_extract
    'uploader_id': self._search_regex(r'/(?:channel|user)/([^/?&#]+)', owner_profile_url, 'uploader id') if owner_profile_url else None,
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 1012, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

WRITE DESCRIPTION HERE
Fails to download an existing youtube recording

[x]  I've searched the bugtracker for similar bug reports including closed ones

Really? #30839.


Strict hostkey checking by default in cluster utils (fixes #1373)

Automated functions (i.e. spinning up a cluster) will skip host key checking
ssh-cluster and rsync-cluster will not skip host key checking by default and will prompt the user when encountering a new host. There is no way to override this (#1505)

Jenkins, test this please

Jenkins, retest this please

Jenkins, test this please

This should be about completed. One potentially dangerous thing that this PR does is enable strict host key checking by default, meaning that this change is backwards-incompatible. One would have to add --insecure to any cluster operation in a script to make sure it still works, which might be too annoying.
Tests should pass, though. ¯_(ツ)_/¯


Coordinate Tool manifest.json needs updating

From @adgiles on January 27, 2016 12:56
The name attribute in the manifest.json needs to be the same as the widget folder "CoordinateTool" otherwise the widget will not load in the builder
Copied from original issue: Esri/solutions-webappbuilder-widgets#418

Manifest files for both DistanceAndDirection and CoordinateConversion match the name of the widgets directory


Reload the internal topics when reloading the configuration file

In the previous version, adding an allowlist while the DdsRecorder was running made the DdsRecorder not save the type information of the allowed topics. Now, the DdsRecorder always saves the type information of allowed topics.

I believe this bug was introduced in https://github.com/eProsima/DDS-Record-Replay/commit/77ebb971506f92e8910437cf0098bed57df58dce. The previous version of the DDS Record & Replay worked fine.


Cascading shadow borders are displayed.

What are some possible causes for this?

Missed this (sorry). Please reopen and provide more data (position of the camera mainly) if you still have the issue-

I found the cause of this problem.
This occurs when anisotropic filtering is used for shadows.
It does not seem to be noticeable if it is up to 2x.
However, there is no advantage to using anisotropic filtering for shadows, so it is preferable not to use it.

Thanks for reporting! I I will reopen to check if I can add something about this.

Below is a description of a solution to a problem with cascade boundaries when using anisotropic filtering, and I tried it.
(https://learn.microsoft.com/en-us/windows/win32/dxtecharts/cascaded-shadow-maps)
However, it did not work.
Probably due to my own lack of HLSL knowledge...
I hope this helps!

Just uploaded a fix for this. It should improve the quality. However I will keep on trying to improve it, specially when camera moves.


use right option names for serverIndex(path, indexOptions)

Like indexOptions.icons we should use indexOptions.view and indexOptions.hidden
see
https://github.com/expressjs/serve-index#icons
https://github.com/expressjs/serve-index#view
https://github.com/expressjs/serve-index#hidden

well spotted, thanks.. released in lws-index v3.1.1. 👍


New app, DC Next Train

Queries the WMATA (Washington DC Metro) API and gets the upcoming arrivals for a given station.  Users can filter results based on schema options for things like train line and/or direction out of the station.  Also gives a few options for how information is displayed.

I have read the CLA Document and I hereby sign the CLA

@cbromano Looks like there are some formatting and lint issues blocking a green build here.

Corrected the lint and format issues


Can't Install Stable Cascade

When I install Stable Cascade, everything works except for when it reaches (3/4) fs.share {"venv": "app/env"}, it says:
'uvicorn' is not recognized as an internal or external command, operable program or batch file. The installation is located in D:.

try factory resetting and try it again, happened to me a few times with can't finding certain items, once factory resetted it started to work and downloaded the required files.


close out artist merch test and launch homepage search test

This closes out the artist merch test in favour of the control group, and launches a homepage search test (whose key for analytics purposes is home_search_test) with two groups control and experiment.
To test on staging:
http://staging.artsy.net/?split_test[home_search_test]=control
http://staging.artsy.net/?split_test[home_search_test]=experiment

👍 lgtm once 🍏

@sarahscott I think this is good to test on staging now.


feat(client): adapt openAPI "getStatistics"

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

20 of 30 (66.67%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 86.122%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tensorbay/client/statistics.py
10
20
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
6162

Relevant Lines:
7155

💛  - Coveralls


NavView content

how to change the nav-view content on menu item clicked,
https://codepen.io/gurucharan-the-lessful/pen/GXRVBw

https://www.google.com.ua/search?q=js+change+html+of+element


Ag Grid  & Ag Charts Enterprise

Hi Pablo,
Fiirst of all, thanks for the very good work developing this library.
Very well structured and neat.
I have bought the enterprise bundle, but I am struggling to enable the charting options inside the grid.
Is this a limitation (more code needed) or a matter of setup ?
Integrating both becomes really powerfull...
Tks in advance

Alex, I figure it out. It was a matter of column setuo to allow Ag Charts to be part of the grid...

Tks for the attention ...


added plugins for remark image linking to add gif support

@davidtsong can you add a description to the PR explaining how we know this works, or how you tested it?

I tested this works by including a gif into any of the markdown pages then viewing the page after gatsby dev. I wasn't sure if I was supposed to include it in this PR otherwise it would be merged into master?
Another option to test is to merge this with the slackbot tutorial where there are gifs and then view that tutorial after running a npm install.
Also, there might be a way to support gifs without this plugin as the docs show Gatsby should have support https://www.gatsbyjs.org/docs/working-with-gifs/.
However, I think using remark for the images messes this up or something? https://github.com/gatsbyjs/gatsby/issues/7317 so that's why the plugin is necessary. Probably good to ping Adam if we want to double check.


Extend elichika type inference for PyTorch

Seems we need to add pip3 install torch==1.4.0+cpu somewhere

Fixed CI issue and seems there is a test failure:
https://github.com/pfnet-research/chainer-compiler/pull/804
https://travis-ci.org/pfnet-research/chainer-compiler/jobs/655642540#L4036-L4060

/test


Update Chrome support for Referrer-Policy

Chrome does not support same-origin, strict-origin, or strict-origin-when-cross-origin values (issue 627968)

Can you change this to a numbered note instead of a bug? Else it won't be obvious to people that the bug refers to the partial support. Thanks!

All set, it's now a new numbered note.

Excellent, thanks!


JavaScript syntax highlighting fails with ternary operator

From @elisee on March 12, 2016 14:25
Hi!
Running Visual Studio Code v0.10.10, the following JavaScript lines are incorrectly highlighted:
let a = true ? true : true; // the last "true" should be colored
let a = true ? true : `this is ${incorrectly} highlighted`;
this should not be in yellow.

Here's what it looks like:

Copied from original issue: Microsoft/vscode#4067

Duplicate of https://github.com/Microsoft/TypeScript-TmLanguage/issues/81


Links to tutorial steps 4 and 5?

Is there a reason tutorial parts 4 and 5 are not in the side nav, and there is no link from 3 to 4, or from 4 to 5? I would be happy to add these, but didn't want to if these tutorial pages are not finished yet.

They are in progress and not yet published. Links will appear when they re ready.


Added French language support

Nothing crazy, just French locale added 🙏  🇫🇷

Codecov Report

Merging #630 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   17.43%   17.42%   -0.02%
==========================================
  Files          21       21
  Lines        1147     1148       +1
  Branches      374      375       +1
==========================================
  Hits          200      200
- Misses        947      948       +1

Impacted Files
Coverage Δ

src/Table.tsx
20.47% <ø> (-0.28%)
:arrow_down:

src/component/toolBar/index.tsx
6.77% <0.00%> (-0.12%)
:arrow_down:

src/component/intlContext/index.tsx
60.71% <100.00%> (+1.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c3709...6cb997b. Read the comment docs.


Fix bug for Dropout with axes, also adding unit test

Description

Fix bug/typo in previous PR https://github.com/apache/incubator-mxnet/pull/9931
Add unit test for new feature Dropout with axes (variational dropout)

Checklist
Essentials

[x] Passed code style checking (make lint)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Dropout operator with axes, unit tests

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Thanks. Let's add a jira retroactively when you figure out how.


fixes #5029

A description of the changes proposed in the pull request:
It fixes the typos and removes spurious noise?
Tests performed by the developer:
pip install -e .

Hello, can you please change the PR to merge it into the development branch?

Closing this PR as the developer has not responded and created a PRP.


Unable to add show

Bug report

ShowsRage version: 1.4.1
Device / Android version: Nexus 6P / 6.0.1 and Nexus 7 original / running latest Cyanogenmod

Issue description
Upon adding a show, no matter the destination (local disk volume and/or NFS), I get the following toast error:
'RootDir = [{defaultDir:0},{location:/path/to/downloadDir},{valid:1}]' is not a valid location
"/path/to/downloadDir" is of course an actual path, not this one used in the example.
I thought it may have been the folders contained spaces, tried with one that didn't still doesn't work.
Am I missing some configuration on the Server side? Something on the ShowsRage side?
Expected result
Show would be added to the selected destination with the chosen options
Steps to reproduce

Click + to search for show
Click Show
Keep defaults, or change destination, and click add

This issue was reported a couple of time already, but I was not yet able to reproduce it.
I will do my best to find the cause and fix it in the next release.

I found the cause of this issue. The fix will be integrated soon and available in the next version of ShowsRage.
Thanks for reporting it.

Fantastic, very much appreciated. Happy it was easily resolvable.


Export code lenses strip data constructor exports

Export management code lenses export data types without data constructors, and worse strip them from existing exports when modifying the exports list.

Fixed in 773de67310d63f321c71c5c49e697541984672b3


added docs section to readme

beefed out the wiki. adding a reference to it here, and other docs.

ironic that a (successful!) effort aimed at demonstrating that 'good process' can sometimes be counter productive, is blocked from being discoverable by good process.


column is not aligned with the header when frozenRight enable

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

Column is not aligned with the header when frozenRight enable
this.actionColumn =  {
      cellTemplate: this.actionTpl,
      frozenRight: true,
      name: 'Action',
    };

Meanwhile, some content of other column is not hidden in the right:

Expected behavior

the column should be aligned with the header.
Reproduction of the problem

What is the motivation / use case for changing the behavior?

After debug for the DOM, after add margin-left: 15px for the column will fix the issue. I try to add this style to the datatable.component.scss under the class of .datatable-row-right {     z-index: 9;   }, but I found that it also applied to the header. So it doesn't work, so I think we need to find why it is not aligned.
Please tell us about your environment:

Fedora 24
Webstorm

Table version: 10.3.0

"@swimlane/ngx-datatable": "^10.3.0",

Angular version: 4.2.4

"@angular/animations": "^4.2.4",
"@angular/common": "^4.2.4",
"@angular/compiler": "^4.2.4",
"@angular/core": "^4.2.4",
"@angular/forms": "^4.2.4",
"@angular/http": "^4.2.4",
"@angular/platform-browser": "^4.2.4",
"@angular/platform-browser-dynamic": "^4.2.4",
"@angular/router": "^4.2.4",

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome 57.0.2987.133

Language: [all | TypeScript X.X | ES6/7 | ES5]
"typescript": "~2.4.0"

find duplicate with other keyword https://github.com/swimlane/ngx-datatable/issues/527

add to css file
.datatable-row-group.datatable-row-right.ng-star-inserted{
margin-left: 17px;
}


Problems with $state.reload reinitializing controller in IE11

Hi All,
I am hitting a peculiar bug in IE 11 w.r.t state transitions.
Now, I have the following line of code:
$state.go('state1.state2',{test:1},{reload:true})
When I run this in chrome and firefox everything works fine, and I don't run into any issues.
However when I run the above piece of code in IE 11, the parameters are resolved,
any promises that are associated with the state are also resolved, but the controller is not re-initialized/view is not refreshed.
This problem seems to only happen when I run the app in IE, it works fine in FF and chrome. I am unsure as to how to proceed and debug the issue. Are there any events, that I can listen to check if the controller is being re-initialized?
PS: Apologies on not providing a plunkr, I tried to create one but it didn't seem to repro with simple state configurations.

Try adding this, to see if any IE-specific errors are being swallowed by the transition rejection:
app.run(function($rootScope) {
  $rootScope.$on("$stateChangeError", console.log.bind(console));
});

So, it turns out there was nothing wrong with state transitions. The actual problem was with IE caching ajax requests. Hence, though the resolve was running, the data from the $http.get was stale.
Thanks for the tip, it definitely helped me identify the correct issue, and keep up the great work with this project!

@masterkidan What did you do to resolve the issue for IE?

If anyone comes across this thread, I solved it by disabling caching using HTTP response headers from the server. This prevents IE from caching AJAX calls, because someone thought it was a good idea to cache AJAX calls... that's a terrible idea, IE sigh.
In Node world this middleware does the trick:
app.use(function noCache(req, res, next){
res.header("Cache-Control", "no-cache, no-store, must-revalidate");
res.header("Pragma", "no-cache");
res.header("Expires",0);
next();

});

You can also do the following if you are using $httpProvider in angular (1.3):
app.config(['$httpProvider', function ($httpProvider) {
$httpProvider.defaults.headers.get = { 'If-Modified-Since': 'Mon, 26 Jul 1997 05:00:00 GMT','Cache-Control':'no-cache','Pragma': 'no-cache' };
}]);

Holy shit, this is a new level of horrible.

Does anyone have a solution for disabling the caching on api requests but maintaining it for static files? I guess i could make a middleware function and add it to all my api routes, just wondering if there is a nicer solution.

@pursual i ran into the same problem, IE was caching all HTTP requests. this method has helped me
app.config(['$httpProvider', function ($httpProvider) {
$httpProvider.defaults.headers.get = { 'If-Modified-Since': 'Mon, 26 Jul 1997 05:00:00 GMT','Cache-Control':'no-cache','Pragma': 'no-cache' };
}]);
since i am using angular template cache service , i dont have to worry about my partials not being cached.


'dart migrate' throws Exception: type '_NullAwareAccessContext<PromotableElement, DartType>' is not a subtype of type '_TryContext<PromotableElement, DartType>' in type cast

When I run 'dart migrate' on a small Flutter project, I get this output with an Exception thrown:
Migrating /Users/kami/development/getx_benchmark

See https://dart.dev/go/null-safety-migration for a migration guide.

Analyzing project...
[------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------]No analysis issues found.

Generating migration suggestions...
[-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------\                                    ]Aborting migration due to an exception.  This most likely is due to a
bug in the migration tool.  Please consider filing a bug report at:

https://github.com/dart-lang/sdk/issues/new
To attempt to perform migration anyway, you may re-run with
--ignore-exceptions.

  I was able to reproduce your bug with changenotifier_benchmark as of https://github.com/knaeckeKami/changenotifier_benchmark/commit/4679f8ff9a56502eaa679b35bbfe3cdc9f4b80fb.  To help us prioritize, were you able to make reasonable progress using the --ignore-exceptions flag?

Yes, with --ignore-exceptions it worked almost perfectly (with some small manual corrections needed, not sure if related to the exception).
I had issues with:
migration of
 List<_Listener> _listeners = List<_Listener>();

to
 List<_Listener>? _listeners = List<_Listener>();

(error: The default 'List' constructor isn't available when null safety is enabled. (default_list_constructor at [getx_benchmark] lib/notifiers/clever_value_notifier.dart:17))
(Multiple instances of this error, but easily fixed)

Migration of
 bold(resultsByApproach[approach]
                  .map((e) => e.time)
                  .fold(0, (a, b) => a + b)
                  .toString())

to
bold(resultsByApproach[approach]!
                  .map(((e) => e.time) as _ Function(TestResult))
                  .fold(0, ((dynamic a, b) => a + b) as _ Function(_, dynamic))
                  .toString())

With error: Undefined class '_'. (undefined_class at [getx_benchmark] lib/print_table.dart:77), seem like type inference failed there

Yes, with --ignore-exceptions it worked almost perfectly (with some small manual corrections needed, not sure if related to the exception).

Ok, good to know, thanks.

I had issues with:
migration of
 List<_Listener> _listeners = List<_Listener>();

to
 List<_Listener>? _listeners = List<_Listener>();

(error: The default 'List' constructor isn't available when null safety is enabled. (default_list_constructor at [getx_benchmark] lib/notifiers/clever_value_notifier.dart:17))
(Multiple instances of this error, but easily fixed)

Glad this was easily fixed.  FYI, we're hoping to improve the migration tool's handling of the List constructor prior to the stable release - see https://github.com/dart-lang/sdk/issues/44198.

Migration of
 bold(resultsByApproach[approach]
                  .map((e) => e.time)
                  .fold(0, (a, b) => a + b)
                  .toString())

to
bold(resultsByApproach[approach]!
                  .map(((e) => e.time) as _ Function(TestResult))
                  .fold(0, ((dynamic a, b) => a + b) as _ Function(_, dynamic))
                  .toString())

With error: Undefined class '_'. (undefined_class at [getx_benchmark] lib/print_table.dart:77), seem like type inference failed there

Interesting: that's not one I've seen before.  I filed https://github.com/dart-lang/sdk/issues/44357 to track it.

Actually, there's another issue :)
The tool migrated
 results.toMultiMap(keyFunc: (r) => r.approach, valueFunc: (v) => v);

to
 final resultsByApproach =
      results.toMultiMap(keyFunc: ((r) => r.approach) as String Function(TestResult), valueFunc: (v) => v);

(print_table.dart, line 12).
This throws an exception at runtime:
type '(dynamic) => dynamic' is not a subtype of type '(TestResult) => String' in type cast

Actually, there's another issue :)
The tool migrated
 results.toMultiMap(keyFunc: (r) => r.approach, valueFunc: (v) => v);

to
 final resultsByApproach =
      results.toMultiMap(keyFunc: ((r) => r.approach) as String Function(TestResult), valueFunc: (v) => v);

(print_table.dart, line 12).
https://github.com/knaeckeKami/changenotifier_benchmark/blob/nullsafety2/lib/print_table.dart#L12
This throws an exception at runtime:
type '(dynamic) => dynamic' is not a subtype of type '(TestResult) => String' in type cast

This looks very similar to the issue discussed in https://github.com/dart-lang/sdk/issues/44345#issuecomment-737278551, which was fixed in e047dd60d6156f8e937dc39f89781e6be603067a.  I believe what's happening is that the presence of as String Function(TestResult) is defeating the normal type inference process, so a proper type is no longer being inferred for ((r) => r.approach).  You should be able to just drop as String Function(TestResult) entirely, and then type inference should assign the proper types at compilation time, so you won't get the runtime exception anymore.
Alternatively, you can try running the migration tool again with a more recent build that contains the bug fix (Dart version 2.12.0-77.0.dev or higher).

Yeah, removing the cast works, of course, it just wanted to report the issue, but great to see that it's already fixed on master.

@stereotype441 @srawlins this is currently marked P1, is this still an issue, and if so do we plan to fix it?

@stereotype441 @srawlins this is currently marked P1, is this still an issue, and if so do we plan to fix it?

I'm dropping priority to P2 considering that --ignore-exceptions was able to work around the problem.

I'm dropping priority to P2 considering that --ignore-exceptions was able to work around the problem.

@stereotype441 Are we still targeting this for January?

@stereotype441 Are we still targeting this for January?

At this point it looks unlikely that we'll be able to get to this in time for the stable release.  Removing from the milestone.

Unassigning myself because I'm not actively working on the migration tool right now.


flutter upgrade should take a hidden --version argument

Our release process says that when pushing a beta build, you should ensure that the build "can be successfully upgraded to from an earlier dev build (via 'flutter upgrade')".
The problem with this is that if you're upgrading from (e.g.) v0.0.20 to v0.1.4, but the most recent dev build is v0.1.6, then there's no way to tell whether an upgrade will work, because just running flutter upgrade will upgrade to v0.1.6 (not to v0.1.4, as you'd like).
If we had a --version argument, it would allow us to test this better.  The trick is that we have no way of knowing whether the version they specify was ever a release on their channel.  And what if they just specify a git hash?  Do either of those matter?
We could even allow an older version to be specified, effectively allowing them to downgrade in case of a regression... This could supersede #14801

@jonahwilliams is this still relevant?

I accomplished testing of upgrade/downgrade differently, using a hidden command to apply the upgrade to a different flutter checkout. This gives us pretty OK coverage for an integration test
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/upgrade.dart#L39
Closing as resolved.


ISSUE-19: Add contibution guidelines

PR Summary:

Adds contribution guideline, inspiration from https://gist.github.com/PurpleBooth/b24679402957c63ec426

Looks good to me 👍


React Confusion

How do I use React with this framework?  I like all of the PAW parts for the boring parts of my app, but want to pull React for the code-heavy parts.
Thanks!

@ajoslin103 the whole framework is build with React, you can simply use it in any file like:
import React from 'react';


CDN Base Url for Orature (RC) Files

Supports download rc files using the CDN URLs of file server

This change is

fetcher-web/src/main/kotlin/org/bibletranslationtools/fetcher/usecase/RequestResourceContainer.kt, line 67 at r1 (raw file):
Previously, jsarabia (Joe) wrote…
This looks like it could be a general utils function, not associated with any particular class, usable elsewhere in the future, rather than something specific to just resource container requests. What do you think?

if so then it may need to take in an environment variable as parameter, since the other use cases also do the same thing with different env var. How do you think?