tsARIBCharset::Encoder not inserting LS1 into generated strings

Not sure if this is the right place to ask/mention this but,
when encoding a string like L"日本共産党放送"
the resulting B24-encoded string is "46 7c 4b 5c 36 26 3b 3a 45 5e 4a 7c 41 77"
However the LS1 (0x0e) shift is not prepended to the string. When looking at descriptors in ISDB-T broadcasts, for example in SDT,
            48      descriptor_tag
            12      descriptor_length
                01 00 0F
                0E 4E 48 4B 45 1D 46 ....

You can see that text starts with 0x0E locking shift.
Should this be fixed? Should I be manually prepending LS1?

What makes you think that the string "日本共産党放送" should start with LS1?
According to ARIB STD-B24, LS1 is a character with a specific function: "assign G1 to GL". So, an encoded string shall start with LS1 only if you need to "assign G1 to GL". This is not always the case.
The initial state of an ARIB STD-B24 encoder/decoder is:

G0: Kanji 2-byte encoding
G1: Alphanumeric 1-byte encoding
G2: Hiragana 1-byte encoding
G3: Katakana 1-byte encoding
GL = G0
GR = G2

So, when a string starts with an alphanumeric sequence (latin characters), we must use "Alphanumeric 1-byte encoding". By chance, it is already in G1. But G1 is not in the two active sets, GL and GR. So, you need to "assign G1 to GL" (LS1) and then start to encode your latin characters. Note that you could also "assign G1 to GR" (LS1R) if you prefer, there are several ways to encode the same string.
In other words, an encoded string shall start with LS1 only if the first character is alphanumeric / latin.
In the case of your descriptor
$ tscharset --japan -d '0E 4E 48 4B 45 1D 46'
NHKEテ
$

The string starts with 0x0E (LS1) because the first four characters are latin: NHKE -> 4E 48 4B 45. Then, 0x1D (SS3) means "assign G3 to GL", effectively using "Katakana 1-byte encoding". Are the following characters really Katakana?
In the case of your initial string, if we try to decode the binary without LS1:
$ tscharset --japan -d '46 7c 4b 5c 36 26 3b 3a 45 5e 4a 7c 41 77'
日本共産党放送

Being French and European, I unfortunately don't know a word of Japanese and I can hardly recognize Japanese characters. But the decoding looks good to me if I visually compare it with your string. Google Translation gives "Japanese Communist Party Broadcast". Is that correct? A very different type of service compared to NHKE, right ?
Could you confirm if the characters are Kanji? If this is the case, then we use "Kanji 2-byte encoding", already in G0, which in turn is already assigned to GL. So, we can directly start to encode characters without any control sequence.
Reference: http://www.arib.or.jp/english/html/overview/doc/6-STD-B24v6_4-1p3-E1.pdf
See table 7-1 page 37.

Hey,
You are absolutely right.
Reason all this came up is I was trying to verify the generated descriptors/etc in TSReader, and was getting garbage encoding, so I thought there was something missing.

$ tscharset --japan -d '0E 4E 48 4B 45 1D 46'
NHKEテ

Are the following characters really Katakana?
Yes, they are. I cut off the remainder of the descriptor hex, but it says ＮＨＫＥテレ福岡 which is NHK-E channel, and テレ are 2 katakana characters. And by your explanation, needing LS1 at start followed by SS3 there makes sense.

Could you confirm if the characters are Kanji?
Yep, entire string is kanji, so it makes sense to start encoding them right away without shift with default encoder state.

Anyway, the whole reason this came up, is I've asked TSReader developer how the ARIB string is detected, and he is checking for the control codes at beginning of a string, such as LS1/LS0/SS2/SS3, and then switching string decoding to B24.
So this "works" most of the time because transport name descriptor usually starts with 3 wide alpha letters, or sometimes katakana, as per ARIB TR-B14 part 5, Table 9-3 "TS Names". ref: http://www.arib.or.jp/english/html/overview/doc/8-TR-B14v6_0-5p5-E1.pdf
However some do start with kanji, such as "東海テレビ", where this logic would break.
Anyway, sorry for the long rant, but yeah it seems to be tsARIBCharset is working properly and there's just a misunderstanding with the tools that analyze generated content. I've re-analyzed the ts with slightly more expensive tools (DekTec StreamXpert) and it's appearing correctly:

Thanks a lot for such a detailed reply!

But, wait a second. If I try and encode a string like "NCPテレビ"
the string is get is "1b 7e ce c3 d0 25 46 25 6c 25 53"
which is not LS1 but ESC + ?? and encodes ascii as some 8-bit chars.
what is tscharset by the way, I don't see that tool available in the standard release downloads

Anyway, the whole reason this came up, is I've asked TSReader developer how the ARIB string is detected, and he is checking for the control codes at beginning of a string, such as LS1/LS0/SS2/SS3, and then switching string decoding to B24.

I understand the encoding dilemma because I had it too. The problem with ARIB signalisation is that they re-used part of the DVB syntax with sometimes a different semantics: B24 character sets instead of DVB encoding, JST instead of UTC, etc. This is an extremely poor design choice in an international environment. Either you choose a standard and rigorously use it or invent a new standard. For instance, ATSC chose a radically different way. They created a new set of tables and descriptors and use a specific character encoding inside them. When you decode an ATSC structure, you know which character encoding to use. On the contrary, when exploring DVB tables and descriptors, DVB character encoding is used everywhere on Earth, except in Japan. And there is no obvious proof that the stream comes from Japan. So, by default, DVB is DVB for TSDuck.
TSReader tries to guess the encoding from some hints that work in some cases, but not in others. TSDuck also tries to guess the standard, globally: if we encounter specific ATSC or ISDB signalisation in the TS, then the whole TS is tagged with a standard. There was already a --default-charset option in TSDuck because some DVB operators use an incorrect signalisation. They assume that the most useful charset for their language is the default one (incorrect according to DVB spec). I assume that their proprietary receivers make the same assumption. But at TSDuck level, we need to indicate which charset is used.
So I added option --default-charset long ago and now you have to use --default-charset ARIB-STD-B24 on Japanese streams. Given the number of incorrect usages of DVB data in ARIB, I added the synthetic option --japan to set all suitable defaults for a Japanese stream. If you work only with Japanese streams, you should set in the TSDuck configuration file (see Appendix 1 of the user's guide).

what is tscharset by the way, I don't see that tool available in the standard release downloads

It has been added in version 3.21, the version which now correctly handles Japanese streams (thanks to the help of two Japanese users).

If I try and encode a string like "NCPテレビ"
the string is get is "1b 7e ce c3 d0 25 46 25 6c 25 53"
which is not LS1 but ESC + ?? and encodes ascii as some 8-bit chars.

$ tscharset --japan -d 1b7ecec3d02546256c2553
NCPテレビ

Looks good to me. 1B 7E is LSR1, "assign G1 to GR". As I wrote before, there are more than one way to encode the same string. TSDuck is probably not the best optimizing encoding tools for ARIB STB-B24. There is probably a way to gain one or two bytes here and there. But, honestly, one or two bytes... As long as the encoding is correct, this is fine with me.

This is an extremely poor design choice in an international environment.

Yeah, tell me about it. TSReader doesn't do proper EIT offset for ISDB due to the UTC/JST reason, since everone else in the world does it properly.

It has been added in version 3.21, the version which now correctly handles Japanese streams

Hm? I grabbed windows-x64-portable zip from /releases and that's not one of the binaries.

Looks good to me. 1B 7E is LSR1, "assign G1 to GR". As I wrote before, there are more than one way to encode the same string. TSDuck is probably not the best optimizing encoding tools for ARIB STB-B24. There is probably a way to gain one or two bytes here and there. But, honestly, one or two bytes... As long as the encoding is correct, this is fine with me.

Yep, I understand. But I'm curious, and since you know the codebase better, do you think if I init with _GL_last = false in the encoder, is that going to break anything? It seems to result in LS1 + ascii being used for ascii encoding which saves a bit of space and makes descriptor readable, and doesn't seem to break any other test cases (kanji string, mixed kanji+kana, etc). Space is kinda a concern because TR-B14 specifies fairly limited byte sizes for descriptor lengths, so...

Hm? I grabbed windows-x64-portable zip from /releases and that's not one of the binaries.

Ooops, you are right, thank you for noticing this. I just found a mistake in the MSBuild file for tscharset. On Windows, when the build was "made for an installer", tscharset was not rebuilt. For my tests, I rebuild installers on top of the dev environment and tscharset has been usually rebuilt recently, so the binary was already there and embedded in the package. For the official release, I clean up everything first and rebuild from scratch. And there, tscharset was not rebuilt. This is the same for the nightly builds, they are built on a fresh empty GitHub runner VM system. So, tscharset is not in the Windows nightly builds either.
The problem does not exist on macOS and Linux since the build system is completely different.
I just fixed this. So, the next nightly builds for Windows will include tscharset. I will also rebuild and update the release 3.21.

do you think if I init with _GL_last = false in the encoder, is that going to break anything?

No, I don't think so. I will update and test. But this is just a flag which ensures that we alternate the use of GL and GR. The initial state is not important. It will change the encoding but in a still valid way.

Space is kinda a concern because TR-B14 specifies fairly limited byte sizes for descriptor lengths, so...

Yes, a descriptor is limited to 255 bytes in all standards. That is a master MPEG specification.
Honestly, more or less one byte will not change much in practice. The only descriptor in which the limitation has an impact is the extended event descriptor. But this one is designed to chain more than one instance.
Talking about the extended event descriptor, I noticed that NHK uses it incorrectly (seen in an ISDB-T capture). They encode the string text first and then they split the binary content over the various extended event descriptors. In at least one occurrence, I see that the split occurred in the middle of a 2-byte character. The second descriptor started "in the middle of a character" (and without charset-switching control sequence of course). This is illegal. The text field of the descriptor must be a character string "coded using the character sets and methods described in Annex A" as they say. In that case, the character string is incorrect and the beginning of the string was decoded as garbage, up to the next charset-switching control sequence.

I just fixed this. So, the next nightly builds for Windows will include tscharset. I will also rebuild and update the release 3.21.

Nice, thank you!

Yes, a descriptor is limited to 255 bytes in all standards. That is a master MPEG specification.

True, but it is even further limited by operating specifications, TR-B14, for example Network Name Descriptor specifies:

Tho I suppose that means actually visual presentation and not how many bytes it takes to encode the same thing, but still.
Anywho, it seems to run with last=false and results in slightly more "user-friendly" encoding of ASCII as actually ASCII, so I'm OK with that, as long as it has no other side-effects.

they split the binary content over the various extended event descriptors

I'll be getting to EIT soon, but I thought sections were split up, then assembled into a single long thing, and then parsed after reassembly, buut yeah I wouldn't be too surprised if some things were broken there... thankfully ISDB-S3 done away with this godawful encoding and switched to UTF-8 finally... Probably same will be in ISDB-T2 if that ever gets finalized.

TR-B14, for example Network Name Descriptor specifies:
... 10 two-byte or 20 one-byte characters ...

This is a particularly insane requirement. What about a network name mixing one-byte latin chars and two-byte kanji chars? And even though, it does not make sense to limit the network name.
I updated the encoder strategy so that it now uses GL at the first charset switch. I had, of course, to update the test suites. Interestingly, the encoded strings in the unitary test suite were either the same size or longer than previously. But in the system test suite, the encoded strings were either the same size or shorter. So, basically, it depends. The gain in space is not obvious, it depends on the context.

I just fixed this. So, the next nightly builds for Windows will include tscharset. I will also rebuild and update the release 3.21.

Nice, thank you!

I confirm that tscharset.exe for Windows is now in the latest nightly builds here: https://tsduck.io/download/prerelease/
I still had not yet time to rebuild release 3.21 with the fix (this must be done manually while the nightly builds are fully automated).

I updated the encoder strategy so that it now uses GL at the first charset switch.

Excellent. Yeah I've ran some tests here and it looked OK but it's good to have confirmation.

I confirm that tscharset.exe for Windows is now in the latest nightly builds here:

Nice, thank you. That will do for now, no problem.

This is a particularly insane requirement. What about a network name mixing one-byte latin chars and two-byte kanji chars? And even though, it does not make sense to limit the network name.

I think this is aimed at receivers with limited ram/storage space, as TR-B14 specs cover these kinda cases, for example the simple logo descriptor is limited to 5 characters (because it might be rendered by mobile phone or similar limited-capacity device).
And I guess since we did resolve the LS1 stuff + ended up with a slightly nicer looking encoder output, this bug can be closed as well.
Thanks for a quick reply on this.


how do i install it is their a guide?

can you be more clear with your question since I don't undestand

how do i install xeno rat how do i make it work and send logs

@kylegotdrip12  that was quick... anyway I suggest checking issue #15 and also build client set up a port and use that same port in listener. like I said, check issue 15

thanks but what port ? i do not know how to do that

do you have discord by chance?

@kylegotdrip12  yes but id rather not commnicate via discord so as to avoid a ban


Add KerbinSide Skyways from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of AlphaAsh, to add KerbinSide Skyways to CKAN.
Please direct questions about this pull request to AlphaAsh.

KerbinSide mods are always a time sink as they involve a lot of overlapping files. See #2166 as an example.

Closing this and adding to https://github.com/KSP-CKAN/NetKAN/issues/2179 as the suite will require overwriting or a "fragile" install stanza.


Username instead of link

Hi, I was just checking out the site and... Probably for instagram and other social media sites, tab for username would be better than link as a whole. I looked through the code but it seemed confusing for not much doc or names...
No issue if it's a small project or archive. And if you permit me, I can look through it sometime.

maybe value in form instead placeholder. Then you only need add your username at end of url?

Well I didn't get what you said but let me tell what I thought.
Like get the username from input but

just add "https://instagram.com/" into a var like $igbase and concate it in backend with the $username

Also in frontend client side, you could display just the username


backupccl: add support for SHOW BACKUP WITH SCHEMAS

PR: https://github.com/cockroachdb/cockroach/pull/39323
From release notes:

Added support for displaying creation statements of relations stored in a backups. [#39323][#39323] {% comment %}doc{% endcomment %}

Related to: #5413, specifically https://github.com/cockroachdb/docs/pull/5413#pullrequestreview-288726107


I use the default config, and Inlay hints doesn't work

NVIM v0.7.0-dev+1082-g046950f63
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by
Features: +acl +iconv +tui
See ":help feature-compile"
system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/usr/local/Cellar/neovim/HEAD-046950f/share/nvim"
Run :checkhealth for more info

If you're using the default config you can skip the extensions part entirely, just configure the server setting

Do other things like symbol info work?  (Put your cursor on a variable and run :ClangdSymbolInfo)

they are work, just Inlay hints doesn't work

Hmmm

If you're using the default config you can skip the extensions part entirely, just configure the server setting

i put them here just make sure i can change this config as i need, i try to delete them, and still does not work.
just Inlay hints does not work, others things work well. Maybe it's related to my colorscheme? I'm using onedark

你的clangd版本是什么？

Apple clangd version 13.0.0 (clang-13<IP_ADDRESS>)

I think clangd also has a startup argument for inlay hints, can you try that.

I think clangd also has a startup argument for inlay hints, can you try that?
Because https://clangd.llvm.org/extensions#inlay-hints says clangd 14 and it works for me with clangd 13 on Linux, so it might be experimentally enabled on 13 just for Linux

unbelievable, I reinstalled clangd with homebrew "brew install llvm", now inlay hints work for me!! thanks for you gays replay!
Homebrew clangd version 13.0.1 Features: mac+xpc Platform: x86_64-apple-darwin21.3.0

How to set the inlay hints at the neovim startup? @p00f
Here is my config:
return {
  "p00f/clangd_extensions.nvim",
  lazy = true,
  config = function() end,
  opts = {
    inlay_hints = {
      inline = false,
      show_parameter_hints = true,
    },
    ast = {
      --These require codicons (https://github.com/microsoft/vscode-codicons)
      role_icons = {
        type = "",
        declaration = "",
        expression = "",
        specifier = "",
        statement = "",
        ["template argument"] = "",
      },
      kind_icons = {
        Compound = "",
        Recovery = "",
        TranslationUnit = "",
        PackExpansion = "",
        TemplateTypeParm = "",
        TemplateTemplateParm = "",
        TemplateParamObject = "",
      },
    },
  },
}

The inlay hints can work when I use the `ClangdSetInlayHints` command, but I want to the inlay hints auto start at the startup time, any solution to that?

@cxzhou35 https://github.com/p00f/clangd_extensions.nvim#usage

@cxzhou35 https://github.com/p00f/clangd_extensions.nvim#usage

Sorry, I am not familar with the nvim-lspconfig, how to add the config?


[Feature Request] Include Progress Bar on Card When There Are Subtasks

Visual indicators are always nice, so this would add a progress bar to the card, maybe including complete / total numbers as well.
This would be more important if #17 were implemented as not all subtasks would then be shown on the card. This would include a progress bar for completed / total subtasks, and I would include the actual numbers as well mostly because 2 / 4 is pretty different than 10 / 20 even though they are both 50%.
Quick mock up for my idea:

I thought about putting the progress bar on the same line as the Edit and Trash icons, but I do think that is a better place for task context (#4), since context would exist for all cards but subtasks don't. So I think having a spot above the footer works, almost acting like another subtask line.

Nice idea - like your thinking.  I won't put it in the next milestone (yet at least) but it should be reasonably straightforward to put together so I shouldn't be too far off getting it done :)

Another mock up:

thanks 🙏


TST Make string comparison cross-platform by using os.linesep

This fixes Windows failures when running CLI tests due to different line
separator (\n != \r\n).
Worth noting that windows require PYTHONIOENCODING=utf8 environment
variable to make it compatible with the CMD terminal IO.

Fixes #74

Ah ha, now I recognize the issue, and that looks like a good solution. Thanks.


Local aws lambda simulator (for development env)

So it will not consume paid requests locally (in case of recursion - may not be very pleasantly)

it's here #9


test problem

Hello：
I run your program，your implement is amazing.
But it test it on the jpg taked by myself，it cannot got the right label.
Could you provide some explanation?
                                                                                thanks!

Hi @bingo9062,
Did you manage get the right label on it?
I am trying to test it as well but it is not working....
Please let me know if you could test it correctly.
Thanks!

@bingo9062 @mandacduarte  Did it worked for webcam. it's working for static images but not working for web cam classification.


New version: Coder.Coder version 0.26.2

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/112770&drop=dogfoodAlpha

🤖 cc: @deansheather @matifali

Close this PR, as we have a new version https://github.com/microsoft/winget-pkgs/pull/112775
and have already deleted this release.


Fix sanit

:tada: This PR is included in version @ra-data-prisma/dataprovider-v7.0.0-beta.3 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add integration test for channel upgrades

Track issues linked to channel upgradability tests.

ChannelUpgradeInit: https://github.com/informalsystems/hermes/issues/3246
ChanUpgradeTry: https://github.com/informalsystems/hermes/issues/3254
ChanUpgradeAck: https://github.com/informalsystems/hermes/issues/3255
Complete handshake: https://github.com/informalsystems/hermes/issues/3256

Let's track these issues in the higher-level tracking issue 🙂


Adds a new glass-producing plant to botany.

About the PR
Adds a glass producing plant and associated reagent.
Why / Balance
For a long time I wanted to be able to grow glass for many projects and departments to use.
Technical details

The Crystalthistle is a mutation of galaxythistle and creates a new reagent called Quartzite. When heated to a high temp 10u of quartzite will become one sheet of glass similar to how plastic can be made with chems. The plant also contains Ethyloxyephedrine since Stellibinin comes from galaxythistle, I thought it would be a good fit and make sure the plant can be grown partly for medical purposes as well since there are a lot of players that enjoy using the narcoleptic trait. Quartzite, if drank also acts as a less potent version of razorium (about 1/3 as painful).
Media

![Screenshot 2024-

07-02 231106](https://g

ithub.com/space-wizards/space-station-14/assets/47635328/18091e67-0718-42f2-b9ad-cdeedcd994f5)

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
None to my knowledge.
Changelog

:cl:

add: A Crystalthistle, A new glass producing plant, and associated reagent, Quartzite!

This PR already adds the same thing: #28993
Welding it to create glass is better than adding an additional reagent only for this in my opinion. That way botany can make the glass without the help of chemistry (like for steelcaps).

This PR already adds the same thing: #28993 Welding it to create glass is better than adding an additional reagent only for this in my opinion. That way botany can make the glass without the help of chemistry (like for steelcaps).

I had made this before i knew that one existed and was shocked to see that it did. I do see the practicality of it, but it requires botany to either get a welding mask as well or oculine to prevent themselves from going permanently blind. The reagent in this one can also be heated up in a microwave which botany can often get use of.
I certainly see the benefits of theirs, and I will be happy to just get a glass growing plant one way or the other. In this case, I mostly made this PR because I had already put the work into it and it's my first one. So i wanted to see what people think of it.

iI think there is also a problem with capitalization, which is why IntegrationTests fails

Error when validating server prototype (EntityPrototype, FoodCrystalthistle). Errors:

PrototypeID Crystalythistle for type Content.Server.Botany.SeedPrototype at Line: -1, Col: -1 not found

i think thats happening because in "Resources/Prototypes/Entities/Objects/Consumable/Food/produce.yml" it's capitalized, seedId: Crystalythistle.
but since it starts with a lower case c in seeds.yml it can't find it

I think there is also a problem with capitalization, which is why IntegrationTests fails

Error when validating server prototype (EntityPrototype, FoodCrystalthistle). Errors:

PrototypeID Crystalythistle for type Content.Server.Botany.SeedPrototype at Line: -1, Col: -1 not found

I think that's happening because in "Resources/Prototypes/Entities/Objects/Consumable/Food/produce.yml" it's capitalized, seedId: Crystalythistle. but since it starts with a lower case c in seeds.yml it can't find it

Thanks for pointing this out on it's own. even on your snippet of it, it's misspelled. For some odd reason it says "Crystalythistle" with an extra y in there when it's intended to be crystalthistle.

#28993
Looks like the other glass thistle PR got merged, making this one redundant.
I still like the artwork you did, so I hope to see other ideas from you in the future.


download resume option

How can I have my visitors DOWNLOAD my resume? Is there a way for that?  Thanks.

I've only tested this on Chrome.

Add this in gatsby-config inside plugins array with the other resolve objects:

   {
      resolve: 'gatsby-source-filesystem',
      options: {
        name: 'pdf',
        path: '${__dirname}/src/pdf/',
      },
    },

Create directory in src folder called pdf and drop your resume in there: /src/pdf/My-Resume.pdf
In /src/Components/About/About.jsx add to the top of the page: import File from '../../pdf/My-Resume.pdf'
On line 58 of About.jsx, change to :

                  <span className="d-flex mt-3">
                    <a
                      target="_blank"
                      rel="noopener noreferrer"
                      className="cta-btn cta-btn--resume"
                      href={File}
                    >
                      Resume
                    </a>
                  </span>

In data.js, change to resume: "My-Resume.pdf" under aboutData. I'm pretty sure you can put anything here as long as it's not empty so the button shows up, I haven't tested it.

Browser's download option is in the top right when clicked.

@ap-dev1 do you want this feature for Simplefolio V1 or Gatsby Simplefolio?
@hadi-mirza suggest a solution but for Gatsby version.
Let me know your response, if you already solved it or not. So I can start working on that feature and update the Documentation.

@ap-dev1 Hi,
Let me know if you solved this or the status.
So I can close the issue.

I remade the entire app but I forget to close the issue. Thank you for the reminder. Best, -a.


deposit: datetimepicker version bump

Updates eonasdan-bootstrap-datetimepicker to 4.14.30

Signed-off-by: Javier Martin Montull<EMAIL_ADDRESS>

We were having the following problem https://github.com/inspirehep/inspire-next/issues/247
Updating datetimepicker fixes it.

I have removed pickTime option as it is no longer supported https://github.com/Eonasdan/bootstrap-datetimepicker/issues/864#issuecomment-76004406

@jmartinm please check milestone where this patch should be applied.

IMHO we can't really merge it to maint-2.0 as it's breaking the UI. Shall we instead pin version of some other library?
It should contain INCOMPATIBLE label in commit message.
There is a missing dot at the end of the bullet point.

IMHO we can't really merge it to maint-2.0 as it's breaking the UI. Shall we instead pin version of some other library?

Does it break the UI? Did not try it but with the change in the code that this commit introduces (removal of picktime) there should be no problem in principle.

There is a missing dot at the end of the bullet point.

I'll fix that. Shouldn't the kwalitee script capture that?

Shouldn't the kwalitee script capture that?

You can submit a patch :wink:

@jmartinm ping https://github.com/inveniosoftware/invenio/pull/3317#issuecomment-117215206

Updated PR. It is rebased against master.

@jmartinm are we going to merge it to maint-2.0 or just master?

For us it does not make a difference and master would be simpler. I updated it because the old version had a glitch on the display.
Is there any use in merging into maint-2.0 ?

IMHO the old version is pinned and works just fine except the special case mentioned above.


Discussion on the use of codec

Does vtprotobuf supports the use of vtprotobuf and standard proto.Message in the same project (we can rely on the Pb. Go file generated by other projects);
Our real scene is that the internal proto file uses vtprotobu to improve performance, and some other functions rely on the third-party pb.go file; The following error occurred during processing
stream is closed with error: xds: stream.Recv() failed: rpc error: code = Internal desc = grpc: error while marshaling: failed to marshal, message is *envoy_service_discovery_v3.DiscoveryRequest (missing vtprotobuf helpers)" func=goexit

Hi @davygeek! It's very easy to support this use case, but you can't use the default GRPC codec that ships with the library.
The Vitess project has the same requirement and I simply implemented our own coded that targets the behavior we need: https://github.com/vitessio/vitess/blob/main/go/vt/servenv/grpc_codec.go
You'll need to do the same for your project. Cheers!

@vmg thanks


✨Added KubestellarUI

Summary
This PR introduces the KubestellarUI, a React and Golang-based user interface aimed at enhancing KubeStellar's usability. While the code is in working order on my machine, it is still in an early stage with several known bugs and needs a better get started guide. The PR includes a basic installation guide to help contributors get the UI running on their systems. The primary goal of this PR is to get eyes on the UI and get more work done on the UI.
Kubestellar Code
Any help would be appreciated!

/ok-to-test

@katamyra I think you need to add .bin to .gitignore and remove those files from your PR

@katamyra thank you for this effort!
Though I have to say that this repo does not seem like the right place for this contribution. It makes more sense to start a separate one that can later get adopted into the project's organization, or to extend the galaxy repository to home such contributions (cc @clubanderson).

@vMaroon yes, we are debating the right home for this. The idea is to get something in as a PR and then discuss how to proceed. I suggest kubestellar/ui as possibility.

@katamyra (cc @andreyod ) I'm having problems with npm run...:
 npm run dev -- --host <IP_ADDRESS>

><EMAIL_ADDRESS>dev
> vite --host <IP_ADDRESS>

  VITE v5.4.8  ready in 385 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: http://<IP_ADDRESS>:5173/
  ➜  Network: http://<IP_ADDRESS>:5173/
  ➜  Network: http://<IP_ADDRESS>:5173/
  ➜  press h + enter to show help
node:internal/process/promises:394
    triggerUncaughtException(err, true /* fromPromise */);
    ^

[Failed to load PostCSS config: Failed to load PostCSS config (searchPath: /home/vagrant/kubestellar/KubestellarUI): [Error] Loading PostCSS Plugin failed: Cannot find module '/home/vagrant/kubestellar/KubestellarUI/node_modules/lines-and-columns/build/index.js'. Please verify that the package.json has a valid "main" entry

(@/home/vagrant/kubestellar/KubestellarUI/postcss.config.js)
Error: Loading PostCSS Plugin failed: Cannot find module '/home/vagrant/kubestellar/KubestellarUI/node_modules/lines-and-columns/build/index.js'. Please verify that the package.json has a valid "main" entry

(@/home/vagrant/kubestellar/KubestellarUI/postcss.config.js)
    at load (file:///home/vagrant/kubestellar/KubestellarUI/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:33602:11)
    at file:///home/vagrant/kubestellar/KubestellarUI/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:33627:16
    at Array.map (<anonymous>)
    at plugins (file:///home/vagrant/kubestellar/KubestellarUI/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:33626:8)
    at processResult (file:///home/vagrant/kubestellar/KubestellarUI/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:33696:14)
    at file:///home/vagrant/kubestellar/KubestellarUI/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:33826:14]

Node.js v23.4.0

Additional info:

go version go1.23.3 linux/amd64
npm 10.9.2
node v23.4.0
VITE v5.4.8
Linux vagrant.local 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

I am using vite 5.4.11 - thats prolly your issue @francostellari

  ➜  Local:   http://localhost:5173/
  ➜  Network: http://<IP_ADDRESS>:5173/
  ➜  press h + enter to show help```

Currently this PR is asking to contribute over 5000 files. If those are mostly not intended, then do please get them out of the PR.
Remember that in Git it does not work to update .gitignore in a later commit than one that introduces the files that you want to ignore. The update to .gitignore has to come first.

@MikeSpreitzer see my comments above re: too many files

@clubanderson: yes, I was trying to add a little detail about the update to .gitignore.

@katamyra added https://github.com/kubestellar/ui with the latest from your main branch. closing this PR so we can move over to that repo and continue working. Thank you for your contribution.


bug: onConnect not triggered when another hook is using the useAccount

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.11.7 (also tried 0.12.1)
Current Behavior
The function onConnect is not called when connecting a wallet to the application.
When refreshing the page (with the wallet connected) then the function is triggered.
Expected Behavior
The function onConnect should be called when the wallet is connected not after reloading the page
Steps To Reproduce

Clone https://github.com/antho1404/issue-rainbowkit-wagmi
Run npm install
Run npm run dev
Open http://localhost:3000
Click the "connect" button

With normal behavior, you should receive an alert with "do action on login"
With the current behavior you get nothing

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
https://github.com/antho1404/issue-rainbowkit-wagmi
Anything else?
The issue seems to come from a hook that is also using the useAccount. If this hook does not use the useAccount, everything works as expected.

having the same issue of onConnect not being executed, only after a refresh
using
"react": "^18.2.0",
"wagmi": "^0.12.9",
"@reservoir0x/reservoir-sdk": "^0.6.4",

useAccount's onConnect callback is called whenever a wallet connects through a user action or when the page loads and it reconnects. Looks like you want to use the isReconnected property of onConnect to filter out reconnections on page load.

This issue is not related to the isReconnected, the issue here is that in some conditions, the onConnect is simply not called at all.
I updated my reproduction and deployed it, so now you can experience it directly by going to https://issue-rainbowkit-wagmi-antho1404.vercel.app/.
Simply click on the button, connect the wallet, and you should not get the alert saying, "do action on login", if you refresh the page now, you have this alert.
And now, if you remove the const { isConnected } = useAccount(); in the useX hook everything works as expected.
Can this issue be reopened or is there a hack around that?

also having this issue where connecting (or reconnecting) from either a UI component (e.g., button) or browser extension (e.g., metamask) does not trigger onConnect by default...i have to refresh the page and then it triggers onConnect, and even then it's not always consistent in triggering it

@jxom @tmm can I take it?

sure!

@antho1404 Hello, it's look like not wagmi bug.
I moved <RainbowKitProvider /> to index.tsx and it works properly
const HomePage: NextPage = ({}) => {
  const doX = useX();

  const { isConnected } = useAccount({
    onConnect() {
      doX();
    },
  });

  if (isConnected) return connected;

  return <RainbowKitProvider chains={chains}><ConnectButton /></RainbowKitProvider>;
};

export default HomePage;

@jxom do you have any ideas why this might be happening?

The source of a problem can be illustrated by noticing that:
diff --git a/pages/index.tsx b/pages/index.tsx
index 6f59144..7a962ca 100644
--- a/pages/index.tsx
+++ b/pages/index.tsx
@@ -7,13 +7,9 @@ const HomePage: NextPage = ({}) => {
   const doX = useX();

   const { isConnected } = useAccount({
-    onConnect() {
-      doX();
-    },
+    onConnect: doX,
   });

   if (isConnected) return connected;

   return <ConnectButton />;
 };

resolves the issue. This fits in perfectly with

And now, if you remove the const { isConnected } = useAccount(); in the useX hook everything works as expected.

What's happening is the first useAccount() causes the component to re-render and make a new closure, which then triggers a resubscription in the second useAccount():
https://github.com/wagmi-dev/wagmi/blob/c8139b1cd5b9cc78961e158cc6f0de59f198908f/packages/react/src/hooks/accounts/useAccount.ts#L22-L58
Unfortunately this means unsubscribing just before the "disconnected"->"connected" transition and creating a new subscription just afterwards.
The question is, why this bespoke code to manage zustand subscriptions? Doesn't zustand already provide useStore to access native zustand stores? If the maintainers are interested, I can provide a PR to do it this way.


feat: Release 0.7.0

allow to specify separate devices for loading checkpoints and merging keys
multiprocessed key merging for faster CPU operations

Some quick local zero-shot "benchmarks" for -m ties_add_difference -ba 0.5:

--work_device cuda --threads 10

stage 1: 100%|██████████| 1131/1131 [00:22<00:00, 50.92it/s]

--work_device cuda

stage 1: 100%|██████████| 1131/1131 [00:31<00:00, 35.86it/s]

--threads 10

stage 1: 100%|██████████| 1131/1131 [00:45<00:00, 24.73it/s]

Baselines:

cpu:

stage 1: 100%|██████████| 1131/1131 [01:30<00:00, 12.56it/s]

--device cuda:

stage 1: 100%|██████████| 1131/1131 [00:15<00:00, 71.03it/s]

All merges give exactly the same output, so merging in parallel does not seem to affect precision. As expected, but I wanted to test this just to prevent bad surprises. Read below.

It seems --device cuda --threads 10 is giving me slight differences in merged models. Will investigate. It is mild but still different, I assume it is related to precision?
I recommend opening these in different tabs to rapidly compare. The first one is on cpu, the second one using cuda:

So --work_device cuda gives exactly the same result as --device cpu. However, --device cuda gives different results. I'll test on main branch to see if the issue is related to the changes here.

I can reproduce the problem on 11991bf, so it does not seem related to this new release.

I can reproduce the problem on 11991bf, so it does not seem related to this new release.


Types not being generated for gql files with imports

Note that this is using 1.4.1-alpha-906f6449.78
Describe the bug

It looks like files that import other fragments aren't getting types generated.
Config:
overwrite: true
schema: path/to/schema
documents: src/**/*.gql
generates:
    codegen/graphql.d.ts:
        plugins:
            - 'typescript'
            - 'typescript-operations'
        config:
            namingConvention:
                enumValues: keep
                typeNames: change-case#pascalCase
            preResolveTypes: true
            typesPrefix: I
    codegen/graphql.schema.json:
        plugins:
            - 'fragment-matcher'

If I have two files
src/fragments/clickEventInfo.gql:
fragment clickEventInfo on ClickEvent {
  __typename
  .
  .
  .
}

and
src/fragments/blah.gql:
#import 'src/fragments/clickEventInfo.gql'

fragment blah on Blah {
  clickEvent {
    ...clickEventInfo
  }
}

A type will only be generated for the IClickEventInfoFragment.
Expected behavior

Types to be generated for all documents

@joshlam you are using graphql-import, right? I think the syntax should be:
# import clickEventInfo from './clickEventInfo.gql'

Can you please test it?

@dotansimha we're using graphql-tag. Tried with relative imports and still not generating. It works fine in v1.4.0, so I'll bisect through the changes between the 1.4.1 prerelease and that version to try to identify the culprit

@joshlam any update?
I think it might be related to the change we did in graphql-toolkit recently.
Can you please try 1.4.1-alpha-33fb5f7e.75? (this is before the changes)

@dotansimha doesn't seem to be the culprit

@joshlam
Just tested it. Seems like graphql-import doesn't work with fragments and queries now.
When I'm using *.gql - everything is loaded, so the #import is not relevant at all because the glob matches everything.
When I'm telling the codegen to use 1.gql only, and use import with your syntax - it doesn't work because the codegen doesn't know about the existence of this fragments, and graphql-import returns an error.
Not sure why it worked before. @joshlam can you please provide a work reproduction? it will be easier to compare the changes.

On a related note, we've been testing out the most recent alpha versions (1.4.1-alpha-ad8ddfd9.92 and a few before it) and we've noticed that Typescript React Apollo HOC & Component generation no longer works for any query that imports a fragment.  An example query def that no longer works:

query UserPrefs {
  userPrefs {
    ...UserPrefs
  }
}

This was working fine for us in 1.4.0.
If it helps, I removed the import and HOC/Component generation worked (but of course the query no longer does).
Let me know if you want me to file a separate issue as this is a bit different than the parent as Typescript defs are still working for these, just not the React Apollo stuff.

@jacobheric it happens only with imports, right?
I'm not sure what has changed since then. which library is the one that added #import syntax before? it wasn't graphql-import for sure, because it doesn't support GraphQL operations, only schemas.
Using new Source and parse from graphql doesn't seem to support this syntax.

@dotansimha, yes we only experience this problem when we use #import in our *.gql fragment and query defs. That syntax is supported by a graphql-tag webpack loader as described here: https://www.apollographql.com/docs/react/recipes/webpack/.
FWIW, I think it has something to do with the upgrade to graphql-toolkit to v0.4.0 or subsequent fixes. The last time HOC/Component generation worked for us is prior to https://github.com/dotansimha/graphql-code-generator/pull/2183.

ok I think I figured it out. I think the #import syntax you used has no meaning for the codegen, but your glob pattern was broad enough to load the fragments as well. There was an issue in graphql-toolkit that was trying to load this file using graphql-import and this caused an error (because, it shouldn't handle those types of file), which caused the file to be ignored and not generated.
Fixed in: https://github.com/ardatan/graphql-toolkit/commit/433d3030bab9522b14ee43356f40dceb7b4fe3be
And will merge it to the codegen in: https://github.com/dotansimha/graphql-code-generator/pull/2299
Alpha is available as 1.4.1-alpha-0d9fbe39.93, can you please try it?  @joshlam @jacobheric

@dotansimha, thanks for looking into it! I tested against 1.4.1-alpha-0d9fbe39.93 and we still get no HOC/component generation whenever #import exists in our query/fragment .gql files.

You are right, @jacobheric , the document is detected and it seems like something is not passing it correctly to the plugin. I'm trying to fix.

Managed to fix that in https://github.com/dotansimha/graphql-code-generator/commit/680e7b3941fbea29074120eeb5470ba424adddcd
@jacobheric try: 1.4.1-alpha-680e7b39.95

@dotansimha, tested our app against 1.4.1-alpha-680e7b39.95 and all React Apollo HOC & Component generations worked even when they contained the graphql-tag webpack loader #import syntax. Thanks for the quick fix!

@dotansimha, works great on this end too 👍thanks! 🙇

Fixed in 1.5.0 🎉


Update README.md

Did minor changes in the readme. Please merge my pull request.

@Harold-lkk Please merge my pull request


Menu mnemonics not underlined

Issue Type: Bug
When I click on Help (for example), no mnemonics are shown.
Same for the main menu bar, until i press Alt.
VS Code version: Code 1.30.0 (c6e592b2b5770e40a98cb9c2715a8ef89aec3d74, 2018-12-11T22:29:11.253Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz (4 x 2904)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.73GB (0.42GB free)

Process Argv

Screen Reader
no

VM
67%

Extensions: none

@OlafvdSpek this is the intended behavior. Use Alt+Mnemonic to open the menus and see the mnemonics. This is consistent with other windows app menu bars.

It's not, other apps respect Underline keyboard shortcuts and access keys.
https://www.groovypost.com/howto/make-windows-underline-menu-shortcut-keys/

I really thought the underlines would always be there in sub menus but I was wrong.


Add GitHub issue template

This PR introduces a template to make sure the necessary information is entered in GitHub issues.
The goal is to make every new issue immediately actionable.
This template is very similar to the issue template published for https://github.com/hashicorp/terraform-provider-azurerm

@lonegunmanb please let me know what you think of the template.
Do not merge yet, I would like to understand if there is a way to use the same template for multiple git repositories, because every terraform module lives in a dedicated repository.
To see the rendered template you can test it here:
https://github.com/zioproto/terraform-azurerm-aks/issues/new/choose

Thanks @zioproto, I've already added your template to our scaffold repo at https://github.com/Azure/tfmod-scaffold(I've transfer this repo to Azure org) so I'm closing this pr.


Add CCDM15ENG to content types with 100 year max gap

Will install with no package version update.  Probably need some kind of independent versioning on update_archive.py or put it in the package.

Tested locally and got expected results.


Can't replace with regex containing lookaround that matches across lines

Issue Type: Bug
Find:
import type \{ (\w+) \}

Replace
import { $1 }

Does what you expect, and turns
import type { Test } into import { Test }
but if you use the regex which includes back references
import type \{ (\w+) \}(?=[\s\S]*(new \1\(|\b\1\.|instanceof \1\b|\b\1\())

And replace with the same
import { $1 }

import type { Test } into import { $1 }
I cannot seem to find a way to cheese the system
Test example
import { A } from './A';
import type { B } from './B';
import { C } from './C';
import type { D } from './D';
import { E } from './E';
import type { F } from './F';
import { G } from './G';
import type { H } from './H';

B();
D.hello();
instanceof F()

In-file find and replace works perfectly fine. 👍

But the 'find in files' one breaks 👎

VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:07.755Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1620 v3 @ 3.50GHz (8 x 3492)

GPU Status
2d_canvas: unavailable_softwaregpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: disabled_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
undefined

Memory (System)
15.92GB (1.88GB free)

Process Argv
--crash-reporter-id 21d722df-78c7-4ac1-bbfa-5b7156602bd2

Screen Reader
no

VM
0%

Extensions (32)

Extension
Author (truncated)
Version

alloy-vscode
cmc
0.0.1

ascii-tree-generator
apr
1.2.4

markdown-preview-github-styles
bie
0.2.0

npm-intellisense
chr
1.3.1

bracket-pair-colorizer
Coe
1.0.61

vscode-svgviewer
css
2.0.0

vue-peek
dar
1.0.2

vscode-eslint
dba
2.1.23

java-decompiler
dgi
0.0.2

vscode-ts-auto-return-type
ebr
1.1.0

RunOnSave
eme
0.2.0

prettier-vscode
esb
8.0.1

todo-tree
Gru
0.0.213

jbockle-format-files
jbo
3.3.0

vscode-js-annotations
lan
0.11.0

node-module-intellisense
lei
1.5.0

camelcasenavigation
map
1.1.3

rainbow-csv
mec
1.9.1

vscode-typescript-tslint-plugin
ms-
1.3.3

node-modules-resolve
nau
1.0.2

uuid-generator
net
0.0.4

printcode
nob
3.0.0

vetur
oct
0.34.1

vscode-versionlens
pfl
1.0.9

java
red
0.80.0

vscode-xml
red
0.17.0

vscode-sort-json
ric
1.20.0

gitconfig
sid
2.0.1

vscode-stylelint
sty
0.86.0

open-in-browser
tec
2.0.0

sort-lines
Tyr
1.9.0

vscode-icons
vsc
11.5.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551:30311712
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30323308
vscorehov:30309549
vscod805:30301674
pythonvspyt200:30329803
binariesv615:30325510
vsccppwtct:30329789

I don't even follow how that regex is supposed to match. A simpler example works fine for me.

I have already shown the regex works above. It works fine in "in-file" search and replace
But global it doesn't.
Hence the bug.

I've removed the new \1\( part as it was extraneous and fulfilled by \b\1\( but the problem still remains.
import type            // Match the characters “import type ” literally
\\{                    // Match the character “{” literally
                       // Match the character “ ” literally
(                      // Match the regular expression below and capture its match into backreference number 1
   \\w                 // Match a single character that is a “word character” (letters, digits, and underscores)
      +                // Between one and unlimited times, as many times as possible, giving back as needed (greedy)
)
                       // Match the character “ ” literally
\\}                    // Match the character “}” literally
(?=                    // Assert that the regex below can be matched, starting at this position (positive lookahead)
   [\\s\\S]            // Match a single character present in the list below
                         // A whitespace character (spaces, tabs, and line breaks)
                         // Any character that is NOT a whitespace character
      *                // Between zero and unlimited times, as many times as possible, giving back as needed (greedy)
   (                   // Match the regular expression below and capture its match into backreference number 2
                         // Match either the regular expression below (attempting the next alternative only if this one fails)
         \\b           // Assert position at a word boundary
         \\1           // Match the same text as most recently matched by capturing group number 1
         \\.           // Match the character “.” literally
      |                // Or match regular expression number 2 below (attempting the next alternative only if this one fails)
         instanceof    // Match the characters “instanceof ” literally
         \\1           // Match the same text as most recently matched by capturing group number 1
         \\b           // Assert position at a word boundary
      |                // Or match regular expression number 3 below (the entire group fails if this one fails to match)
         \\b           // Assert position at a word boundary
         \\1           // Match the same text as most recently matched by capturing group number 1
         \\(           // Match the character “(” literally
   )
)

A simpler example works fine for me. Please check your regex

Your regex doesn't even contain a positive lookahead.
Please try to make your "simpler example" more complex

The problem is that rg only gives us the lines that actually matched, not lines that match with a lookahead, so we can't compute the replace with the group reference just on the preview.
I can't find an issue, but I think we've discussed it before. We would have to either open the file to do this with the full file contents, or strip the lookahead from the regex (probably not safe)

I believe I've run into the same issue.
Regex: (?<=\n)((!+-?){2,}\n)(?!\n)
Should match:
!!!!!!!-!!!!-!!!!!!!!!!-!-!!!!!!!!
Thisisa samp lelinethat w illmatch

But it should not match:
!!!!!!!-!!!!-!!!!!!!!!!-!-!!!!!!!!!!!

Thisisa samp lelinethat w illnotmatch

Nor should it match:
! This is text
!
! this is more text

We would have to either open the file to do this with the full file contents, or strip the lookahead from the regex (probably not safe)

@roblourens stripping the lookahead and re-matching against the match string would work in most cases, but here's a small example where it would break:
The regex /(.*)(?=.$)o?/ matches the hello part of strings hello1 and hello. However, match group $1 is hello for the first string, but hell for the second string. Stripping the lookahead gives us the regex /(.*)o?/, where $1 = hell for both match strings.
We could analyze the regex for this form of context sensitivity, but that sounds complex and still fails in corner cases.
I would like to investigate your other suggestion - interpret the file contents for each match string.
Can you point me to the appropriate method? I'm looking for the method that receives the match string from ripgrep, and would populate the match groups if it could, but instead defaults the match groups to the literal strings'$1', '$2', '$3', etc.

This would not be a small refactoring, and I don't think I want to take a PR for this, thanks though.

@roblourens, I hear you and now agree with you - reparsing the file is unwieldy and would not be worth the debugging pain.
A proposal - if I find a way to use the ripgrep --json submatch info, could we move forward with this issue? This would be a much easier and smaller PR.
I'm familiar with the vscode ripgrep search engine, but not how it integrates into file replace.  Could you please point me to some relevant code?

I think that might have the info we need, but using that instead would not be a small refactoring either, especially because it will touch extension API which complicates the change.

@roblourens can you sketch what you'd like the solution to be like?

Similar bug still exists on vscode insiders 1.74.2 (2022-12-20) :
Search in files : ((?!)(.|[\n]))*    (says:  search blocks  ... )
works on open file only.
Fixe it, please at last.

Similar issue exists in 1.78.2 (2023-05-10)

Similar issue exists in 1.78.2 (2023-05-10)

I believe you can do $1\40 to fix that issue

Similar issue exists in 1.78.2 (2023-05-10)

I believe you can do $1\40 to fix that issue

That doesn't seem to work either.  It just adds the slash into the substitution.

Next, try
$1\x{0034}0

\x{0034} being the unicode char for 4
I don't know what language of regex it uses for the code. If it's perl, it might work, if they are using PCRE it may not be possible..
\u0034 is something else to try

Duplicate of https://github.com/microsoft/vscode/issues/172882
Closing as duplicate
/duplicate


The Node.JS version in the search skills lab is not updated

In the lab file instructions there is the 14LTS  Node.JS version that is not available. I change the version with 18LTS.

The pull request resolves the issue #15

completed with a different commit, thanks for reporting!


"Sending data to Treblle failed"

i followed the dashboard's instructions to implement treblle in my api but on every call i get this error message in the console
[error] Sending data to Treblle failed - status: Forbidden (403) { message: 'Forbidden' }
Here is how i implemented treblle
const app = express();

app.use(json());

app.use(cors());
app.use(urlencoded({ extended: true }));

useTreblle(app, {
  apiKey: process.env.TREBLLE_API_KEY,
  projectId: process.env.TREBLLE_PROJECT_ID,
});

and here are my dependencies
  "dependencies": {
    "@types/node-cron": "^3.0.1",
    "axios": "^0.27.2",
    "body-parser": "^1.19.0",
    "cors": "^2.8.5",
    "csv-parser": "^3.0.0",
    "date-fns": "^2.28.0",
    "express": "^4.17.1",
    "express-async-errors": "^3.1.1",
    "express-validator": "^6.13.0",
    "jsonwebtoken": "^8.5.1",
    "mongoose": "^6.0.14",
    "multer": "^1.4.3",
    "node-cron": "^3.0.0",
    "nodemailer": "^6.7.4",
    "treblle": "^1.2.0"
  }

my first thought was that i've setup my envs wrong but they seem to be correct, how can i fix it?

works now thanks!


added sites for practising programming

please, label this PR as "hacktoberfest-accepted" and merge it

Hey @Suraez Why are you whitelisting those websites ?

codesandbox.io is the best when it comes to practising React.js, Angular.js , Vue.js(all of the javascript libraries ) remotely whereas codeforces is the site for competing with the programmers around the world.

This is not the right way for contributing, please check the CONTRIBUTING.md file


Resize post-check: Support terabyte-sized disks

I added this check as part of #946 as a lower-priority check. It's breaking a large test that uses a disk of size 1024 GB; lsblk returns a size of 1T rather than 1024G, and hence the check is failing.
So, I'm reverting this check for now since it would break all imports of size greater than 1T.

I believe you can force lsblk output GB. Just like I used "--output=size -b" to force output bytes in export_disk_ext.sh

Good idea! Updated


[ESP32] CPU halt when two SPI ports are used.

The same issue when we open the same port one more time.


Highlight differences with GitHub.com

I found out that in JavaScript and TypeScript the name of a const is assigned a span with a pl-c1 class which doesn't match with what GitHub does in their highlighting, where they mark it as a pl-s1.
Current starry-night with source.js.js grammar

Current GitHub rendering of the same file

It seems that the name of the pattern is constant.other at least in Javascript.
I'm still trying to get into the codebase but am I right that the mapping between grammar pattern names and css classes are done here? https://github.com/wooorm/starry-night/blob/main/lib/theme.js
In that case I would propose to add, to /lib/theme.js
  "constant.other": "pl-s1"

Also there is some different behaviour in method calls e.g. string.slice() slice is also assigned a pl-c1 instead of pl-en.

https://github.com/wooorm/starry-night#what-is-prettylights
This is because GH uses TreeLights for some languages.

This is because GH uses TreeLights for some languages.

Thanks @wooorm I'm aware of that, but I think we should be able to mimic some syntax decisions of TreeLights in PrettyLights? Or is there something that would break in some other language maybe?
Or better said the mapping between pattern names and css classes is not to be touched with?

Or better said the mapping between pattern names and css classes is not to be touched with?

Correct. They are not to be touched.
It’s explained more in the next paragraph:

starry-night does what PrettyLights does, not what TreeLights does. I’m hopeful that that will be open sourced in the future and we can mimic both.

GH has three things:
    -----
    | x |
    +---+
    |   |
----+   +---|
| y |   | z |
-----   -----

…where y is pretty lights and z is tree lights.
This project implements y, which uses grammars of one kind, and needs dependencies of one kind to handle those grammars.
z has different grammars and different dependencies.
I don’t think the solution is to change grammars in y. I think the solutions is to implement z.
Perhaps then the next step then is to make this project like x. However, that comes at the cost of doubling dependencies included in this project. Which might not make sense for everyone.

Thanks @wooorm for the explanation, will close the issue due to your great explanation, thanks for your time 🙇

Hey @wooorm I still wanted to ask you if you could give a reason why you don't want to touch the mapping between regex capture groups and css classes?
It seems like the best place to add more granularity and fix some weird highlighting.

why you don't want to touch the mapping between regex capture groups and css classes

I didn’t say this I believe. If there are bugs in that, they can be fixed.
You are talking about how GH uses treelights. Which is a different project. This project is currently about prettylights. The solution is not to hack around prettylights to make it look like treelights. The solution is to implement treelights. Or upstream your changes: https://github.com/atom/language-javascript.

It seems like the best place to add more granularity and fix some weird highlighting.

There should not be weird highlighting.


6.1 Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting') vulnerability

TestNG Version

Note: only the latest version is supported
7.8.0

Expected behavior
When we add the testng dependency - no vulnerability issues should be reported.
        <dependency>
            <groupId>org.testng</groupId>
            <artifactId>testng</artifactId>
            <version>7.8.0</version>
            <scope>test</scope>
        </dependency>

Actual behavior
IntelliJ shows the below warning message:
https://devhub.checkmarx.com/cve-details/CVE-2014-6071/
jQuery can potentially allow remote attackers to conduct Cross-site Scripting (XSS) attacks when using methods such as "jQuery()", "append()" and "after()". These methods accept an HTML string and can, by design, execute code. This vulnerability can be avoided by sanitizing inputs such as URL query parameters, cookies, or form inputs when obtained from untrusted sources. This issue wasn't fixed because it's considered to be present by design and it was documented for users to be careful when passing user input to specific functions. This security issue exists in all JQuery versions.

Is the issue reproducible on runner?

[ ] Shell
[ ] Maven
[ ] Gradle
[ ] Ant
[ ] Eclipse
[Yes ] IntelliJ
[ ] NetBeans

Test case sample

Please, share the test case (as small as possible) which shows the issue

        <dependency>
            <groupId>org.testng</groupId>
            <artifactId>testng</artifactId>
            <version>7.8.0</version>
            <scope>test</scope>
        </dependency>

Contribution guidelines
Incase you plan to raise a pull request to fix this issue, please make sure you refer our Contributing section for detailed set of steps.

Similar to #2972


Safari: camera view square

Describe the bug
When showing the camera view in safari, the video is shown as a square (as opposed to the circle in other browsers).
In the documentation I could not find details on which browsers are supported. Did I overlook that or should we add it?
To Reproduce
Steps to reproduce the behavior:

Start the presentation in Safara
Click on 'Show camera view'

Desktop (please complete the following information):

OS: macOS big sur 11.6
Browser: Safarin 15.0
Slidev version: 0.25.8 (latest)

Nice catch. I think we could document it. If it's an easy fix, I am also happy to receive a PR for it. Otherwise, I don't really have the bandwidth to fix Safari issues (you know, the new IE) atm. Thanks


no prerequesites attempting purchase (likely) not fixed on the latest docker image

Describe the bug

With the latest docker image version COMMIT_SHA: "09f406ffcda6613d92c77244650503d74e0b520d",
my order was denied after solving the captcha for this purchase
[2022-11-17 17:06:31.977 +0800] INFO: Purchasing Epic Cheerleader Pack
Screenshots or Logs

Configuration (please complete the following information):

Browser: not sure, I'm running this on under a docker container
Hosting solution [e.g. reverse proxy, HTTPS/HTTP, caching, localhost]: localtunnel: true

Additional context

Thanks for the logs. It helped find the difference between what I was testing and your setup. Turns out it was just a typo from some lazy programming. Thanks for opening the issue!


Support for Laravel Compoships

I'm having some trouble setting up this package.
The models in my app don't directly inherit the Eloquent Builder as they instead use "Compoships" as a middleman (https://github.com/topclaudy/compoships) for more complex relations.
So in my case, I am trying to perform:
        $builder = EloquentBuilder::setFilterNamespace('Modules\\To\\Filters\\Invoices')             ->to($user->company->invoices(), $request->get('filters'))             ->get();
where ->company->invoices() returns a eloquent model relationship instance.
Whereas when I try perform the builder instance, I am getting the following error:
Return value of Fouladgar\EloquentBuilder\EloquentBuilder::resolveQuery() must be an instance of Illuminate\Database\Eloquent\Builder, instance of Awobaz\Compoships\Database\Eloquent\Relations\HasMany returned
Is there any way I can get around this? (Can I override a class perhaps to allow for Compoships instances?)
If I were to do ->to(Invoice::class, $request->get('filters')), it does work as expected, but it won't work when I pass a relationship into the ->to() method.
Might I add, this is a fantastic package nonetheless :)

I'll also add (I've been looking around), Compoships has its own version of the Builder class called \Awobaz\Compoships\Database\Query\Builder

@nicholaszuccarelli
Please check this issue #28  and see if your problem is will be resolve.

Thank you! :)
Binding ->getQuery() onto the end of my statement has fixed the problem!


Julio wants an estimate of the leftover work to bridge substrate

The main technologies to research are:

Statemint / Statemine
Some DEX on Acala
Wormhole

Here's a summary of the situation AFAICT:
Currently we have ETH-FCL listed on some exchanges. We want some mechanism to exchange Sub-FCL with the rest of the crypto ecosystem.
Options:

Create a web2 service with liquidity provided by Fractal and/or users. Con: requires liquidity from Fractal, or complexity of designing users providing liquidity.
Send Sub-FCL to Acala or another EVM-compatible Polkadot chain and use a DEX on that chain. Could use Statemint and/or Wormhole to transfer to/from our Substrate chain to Acala. Con: These options are not secure and/or not ready for implementation yet. Another con: The process to go from Sub-FCL to an arbitrary currency would be confusing and multi-step. Another con: would likely require us running as a parachain.
List Sub-FCL on an exchange. Con: potentially confusing for users. Ideally we can have exchanges list it as one token and accept deposits and withdrawals to either Substrate or Ethereum.

@nikoladimitroff @juliosantos Is there any possibility of our existing exchanges allowing deposits/withdrawals as Sub-FCL in addition to ETH-FCL? If not, the only feasible option seems to be creating a web2 service with liquidity provided by Fractal.

Could use Statemint and/or Wormhole to transfer to/from our Substrate chain to Acala. Con: These options are not secure and/or not ready for implementation yet

Statemint is both secure and ready — what I am missing? Regardless, I don't think we can use it to transfer tokens — we'd need to burn FCL on our chain and mint the same amount using Statemint if I understand it correctly.
As for Wormhole, I think the main issue would be their refusal to integrate with a non-parachain.

any possibility of our existing exchanges allowing deposits/withdrawals as Sub-FCL in addition to ETH-FCL

I don't think so.

Summarizing a video discussion:
There are concerns about using a decentralized technology to bridge.
We decided to make a web2 solution that supports transitioning FCL between all the chains it will live on: Fractal's main Substrate chain, Acala as ERC-20, and Ethereum as ERC-20. We'll also provide a unified view of a user's FCL in the wallet extension, and allow them to transfer between the different chains.
@nikoladimitroff I think this issue can be closed and you can start writing out stories for building this bridge. If necessary, we can VC on the UI I imagine.


fix(tesh.sh): add shebang for test.sh

coverage: 93.889%. remained the same when pulling 5a2e2914a47010cc5b850046910199b440a0b482 on derrick-test-sh-add-shebang into aec2b69d606dfc4b7bb634341620a42e4d281a64 on main.


Add Demo Mode

The option to enable Demo Mode will only be visible after the app is
granted the DUMP permission. The permission can be granted via pm.
There is a split second display delay before the SystemUI updates from the broadcast.
Maybe there's a better spot to send the broadcasts before RecordingSession.Listener.onStart()?
Also, of course, just close this if there's not a large use case relative to the code addition. :)

There is a split second display delay before the SystemUI updates from the broadcast.
Maybe there's a better spot to send the broadcasts before RecordingSession.Listener.onStart()

We could add an .onPrepare() callback triggered when the "Recording..." item is shown and starts to fade out.

Oh, I like that idea; I'll give it a shot in a bit!

Lint is still failing for some reason despite you suppressing it.

Yeah, I was just about to look at that. Hmm.
Wonder if it's an accidental difference between RequiresApi and TargetApi.
On Sat, Jan 14, 2017, 10:22 PM Jake Wharton<EMAIL_ADDRESS>wrote:

Lint is still failing for some reason despite you suppressing it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JakeWharton/Telecine/pull/144#issuecomment-272676660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD2Im0gtW-WQH953eHmJscNrgv1zz4oLks5rSbsrgaJpZM4Lj0Ph
.

I don't see why Lint is failing. Should I file a bug and work around it here?

Does it fail locally as well?
On Sun, Jan 15, 2017 at 2:09 PM Eric Cochran<EMAIL_ADDRESS>wrote:

I don't see why Lint is failing. Should I file a bug and work around it
here?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JakeWharton/Telecine/pull/144#issuecomment-272729862,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEYx7rVGmW999EK1PwSz6vQXWBRbbks5rSpkGgaJpZM4Lj0Ph
.

Yeah, running lint fails on my machine with the same errors.
On Sun, Jan 15, 2017, 2:14 PM Jake Wharton<EMAIL_ADDRESS>wrote:

Does it fail locally as well?
On Sun, Jan 15, 2017 at 2:09 PM Eric Cochran<EMAIL_ADDRESS>wrote:

I don't see why Lint is failing. Should I file a bug and work around it
here?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/JakeWharton/Telecine/pull/144#issuecomment-272729862
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAEEEYx7rVGmW999EK1PwSz6vQXWBRbbks5rSpkGgaJpZM4Lj0Ph
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JakeWharton/Telecine/pull/144#issuecomment-272732405,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD2Im70rAF_pEws2OtnrdY-P9yMsYaVmks5rSppEgaJpZM4Lj0Ph
.


Ability to not use setContentView

Since I was using this library, I was not happy with the setContentView method. It is because it is not similar to the methods you would use when you normalle use Fragments.
When I use ProgressListFragment it is like magic. Even when I use custom layout in the onCreateView it gets the ListView and does all the magic automatically.
Here is the solution in my mind. I hope I can tell it well.
If you have a FrameLayout in the content_container FrameLayout on top of the emptyView. You can use that id as a mContentView. When developer use custom layout in onCreateView and have a view with that id, you can use it right away. If the developer don't have a view with that id, you can expect usage of setContentView. If the developer doesn't do any of that, you can throw a IllegalStateException.
What do you think? Sorry if the English is not good.

I'm having the same problem as @mitsus pointed.
Does anybody has any further information on this issue?


ARROW-13350: [Python][CI] Fix test_extract_datetime_components for pandas 0.24

@github-actions crossbow submit test-conda-python-3.7-pandas-0.24

The question that I have is by the way why we care about testing against Pandas 0.24 which seems to be 3 years old.

I opened ARROW-13351 an hour ago :-)
The 0.24 release is 2.5 years old, which is also not that old, since we are eg also supporting Python 3.6 (almost 5 years old) and numpy 1.16 (also 2.5 years old). See ARROW-12706 for those.
(but let's discuss this further on those issues)


Update to copier-cpp template version 0.2.4

Purpose

Sync with upstream.

Integrate breaking llfio change io_handle -> byte_io_handle.

clang-tidy warnings to cleanup:

[ ] [bugprone-branch-clone]
[ ] [bugprone-exception-escape]
[ ] [bugprone-implicit-widening-of-multiplication-result]
[ ] [bugprone-macro-parentheses]
[ ] [bugprone-use-after-move]
[ ] [clang-analyzer-core.uninitialized.Assign]
[ ] [clang-analyzer-optin.cplusplus.VirtualCall]
[ ] [cppcoreguidelines-avoid-magic-numbers]
[ ] [cppcoreguidelines-avoid-non-const-global-variables]
[ ] [cppcoreguidelines-init-variables]
[ ] [cppcoreguidelines-non-private-member-variables-in-classes]
[ ] [cppcoreguidelines-pro-bounds-constant-array-index]
[ ] [cppcoreguidelines-pro-bounds-pointer-arithmetic]
[ ] [cppcoreguidelines-pro-type-member-init]
[ ] [cppcoreguidelines-pro-type-reinterpret-cast]
[ ] [modernize-use-nodiscard]
[ ] [modernize-use-trailing-return-type]
[ ] [performance-move-const-arg]
[ ] [performance-unnecessary-value-param]
[ ] [readability-avoid-const-params-in-decls]
[ ] [readability-container-size-empty]
[ ] [readability-convert-member-functions-to-static]
[ ] [readability-else-after-return]
[ ] [readability-function-cognitive-complexity]
[ ] [readability-implicit-bool-conversion]
[ ] [readability-make-member-function-const]
[ ] [readability-qualified-auto]
[ ] [readability-simplify-boolean-expr]


Display issue when using totem of undying and tinted arrows from EFR

https://github.com/user-attachments/assets/29e11af4-ea78-4f94-8633-14ca913bf4e9
Backhand version 1.5.2

https://github.com/user-attachments/assets/760fbcd1-837f-4afa-aac0-f54d00764cbb

If the videos do not load (broken file?):
https://github.com/user-attachments/assets/951f900c-5a04-41dc-a30d-216f7b98d399
https://github.com/user-attachments/assets/83de783d-32d8-421c-be67-8e5337f0c5be

video looks well for me.

@Darek505 think they used 265/HEVC for encoding

video looks fine for me.

@Darek505 think they used 265/HEVC for encoding

yes

https://github.com/user-attachments/assets/ed1525d2-e72f-407a-b3b0-ab4e524113a1
https://github.com/user-attachments/assets/f609b7e1-2486-4f84-b1e7-f7f530950a3a

@huihiuhuai @Darek505 can both of you please try out https://github.com/GTNewHorizons/Backhand/releases/download/1.5.3-pre/backhand-1.5.3-pre.jar to see if any issues still persist?

I can confirm that the problem with totem is still relevant, the problem with arrows seems to have been resolved
https://github.com/user-attachments/assets/5a7ae3c1-3c3d-4ec8-9592-6c80d76d04ad
https://github.com/user-attachments/assets/cdf03be6-ddf3-4692-9664-bd4b9459e6b8

Version 1.5.7-pre. Totem issue is fixed. Tinted arrow issue persists.

tinted arrows issue persists

2024-07-25.15-59-56.00_00_02-00_00_12.mp4

Can you give https://github.com/GTNewHorizons/Backhand/releases/tag/1.5.9-pre a try, I'm 99% sure it's fixed for good now

(1.5.9-pre) I can confirm that it is fixed

perfectly fixed


Add invertase to Rhodo model

On the experimental side, we confirmed both from Pavlo and Biolog that Rhodo can grow on sucrose. On the computational side, we see that RhodoCyc  has an invertase enzyme and computational studies identified SUC2 which was confirmed by BLAST analysis to be
>gnl|RHTO|G1DOZ-20580-MONOMER Beta-fructofuranosidase. (complement(join(835023..835852,835908..835965,836028..836146,836239..837165,837222..837288))) Rhodotorula toruloides scaffold_6
MVMNDVNGAF RAPNGTWHLY YQYNPTDVVA GNQHWGHATS DDMYHWVNQP IALFPPNSTA
AVFSGSAVTD PNNTSGFFPN NNASNPGVVA IYTLNTPEKQ TQEIAYSTDG GYSFTPYSGN
PVIDIGSNQF RDPKVIWYND RWVMTVAHAQ EMFIAIYTSQ NLKQWTEVSR FTRHGFTQLQ
YECPGLQRVP IRRRNATSSS GSSGSSGGSS NSSMSSSSSS APSSPVSTAS ASLARRQAST
LVSGASSLFS GASSVVRPSA SSAMSSGSRA SSTGSASSSS MISSGSSMAS ASSTASSAMP
SSTSTGGAAG GSSGGNSSSN SSSQDFAWVM WISINPGAPL GGSITQYFVG DFNGTHFTPF
DDSVKLADFG KDNYAGQFFY NTGDQAVSMA WASNWQYTDF VPTANELWRS ADSLPRNNYL
VEADRIGWVL ASEPYNISAV RNSSILPGGN ETTSLVNQTV SADFSNITSG AIYFSVNITL
PSNVTLGDYA SLNMTLTSAS SNENLTAGYF FGGPNSNSTW IDRSGTRGYT GNPFFTSQFS
QTAPTVAYNI EGVFDRSLFE LFIDEGTYAA TVDVYSQQPL TKIALATGDM PEGAQVQAAI
WGLSSVWTNS TSGGNSTSGG NSTNSAASSS MMSSTSSMMS SSSSMMSSMS STASAASTSA
SASTTA

@JamesPino  if you submit a pull request with the changes, I will review it.

Rhoto_IFO0880_4_14826
is the protein id in RhodoCyc

I believe this originated from an error in interpreting memote output.  The false negatives were
EX_succ_e,  EX_pro__L_e,  EX_for_e, EX_galur_e, EX_gly_e, EX_akg_e

I see. Since the rhodo model can grow on sucrose consistent with the Biolog observation, I think we can close this issue.


fix(certificates): general and print styling issues

Closes #36383

@ojeytonwilliams, apologies - I wasn't thinking and forgot to look at how it looked with different printing margins 🤦♂ Should be fine now, thanks for reviewing 👍

@jonathan-grah no need to apologise!  Anyway, it still wasn't looking quite right on my machine (it was still flowing onto a second page) so I played with the css until it looked fine on Chrome and Firefox - I can't test Edge at the moment.  Firefox was a bit odd, since it didn't like the fact that everything was wrapped in a 100vh box, for some reason.
Let me know what you think.  Does everything seem okay?

Actually, it looks like I had non-default margins, same as you!  It's now a little on the small side, so I'll fix that in a sec.

LGTM 👍
Cheers @ojeytonwilliams, I prefer it vertically centred but if there's issues on Firefox then that's no problem. I also had a styling issue with the color of fonts only on Firefox; I've fixed that too.
In regards to Edge, I couldn't get the development user to sign in. Was that the same with you?

@raisedadead, completely understand. However, do you not think it's worth merging the PR at the minute, as it doesn't really change that much, but does address this issue (I get asked about this quite a lot). It can easily be changed during the re-styling rerun, just don't see much harm in merging as is.

There are still a few outstanding problems I discovered - Firefox doesn't print all the certs on one page, Saxmono is missing and so on.
I had a fix in the works, but am I right in thinking that problems with the display are worth fixing, but not problems with printing?


split_pdf splits too much, since it does not take into account that different entities might have same type (but different confidence)

Here is entities example returned from splitter:
[text_anchor {
  text_segments {
    end_index: 1424
  }
}
type_: "form1"
confidence: 0.96
page_anchor {
  page_refs {
  }
  page_refs {
    page: 1
  }
  page_refs {
    page: 2
  }
}
, text_anchor {
  text_segments {
    start_index: 1424
    end_index: 6935
  }
}
type_: "form1"
confidence: 0.68
page_anchor {
  page_refs {
    page: 3
  }
  page_refs {
    page: 4
  }
}
]

In this case we see that all pages are actually of same type and we should not split. However document.Document.split_pdf would not detect that.

Ok, this is a bit complicated because the Document AI Custom Splitter specifically detected those two "form1" entries as separate documents.
If we combine them together by default, it could create ambiguity when there are multiple separate documents of the same type in a file.
We could create a parameter like combine_like_document_types or something like that, but I think this issue would be best resolved on the Custom Splitter itself.


Schematics: ng add throws startTag error

Bug:
Installing material using schematic with custom theme option throws error in Terminal.
Error:
Cannot read property 'startTag' of undefined
What is the expected behavior?
Material added with custom theme option configures app with material
What is the current behavior?
An error is thrown in Terminal.
What are the steps to reproduce?

Create a new app
ng new test-app --prefix=tst --style=scss

Install material
yarn add @angular/material

Run schematic
ng add @angular/material --theme=custom

Which versions of Angular, Material, OS, TypeScript, browsers are affected?
MacBook Pro, Sierra 10.13.5
Chrome Version 67.0.3396.99
"@angular/core": "^6.0.3", // all angular deps
 "@angular/cdk": "^6.3.2",
 "@angular/material": "^6.3.2",
 "@angular/cli": "~6.0.8"
"typescript": "~2.7.2",

Same error

Same error

is there solution for this error , i am having the same one

I used ng add<EMAIL_ADDRESS>it worked ,
it seems ng add<EMAIL_ADDRESS>have some problem that is latest one

If you don't want to downgrade material and retain<EMAIL_ADDRESS>you can make the same edit in node_modules as in this PR just before you run the schematics.

The fix by jerryorta-dev worked very well. You really need to modify the file html.js from the dir node_modules/@angular/cli/schematics/utils if you really need to use the latest version of Angular Material.

I don't have node_modules/@angular/cli/schematics/utils in my app what am I doing wrong, I have run ng new test-app and this folder above does not exist

@jerryorta-dev that fix worked! I'm including material as part of a schematic and this was needed to get it to work. hopefully, it goes in soon

same error

Same Error. Also find when generate schematics, dashboard and sidenav have wrong align

The same here on Windows and cli version 6.0.8.

Uninstall the @angular/material and reinstall...

Use solution by @jerryorta-dev, works as a charm! (Mine: Angular/Cli 6.0.8, Node 10.1.0, Linux Mint 18.3 x64)

I am not able to find html.ts file. Should i create and add the file directly?

@addyfreek, in your folder you maybe has an html.js file instead of a .ts one, that's the file you need to change, is the one i change, so try it and hope that's work for you.

Same error

Hi, as I commented on Github, you need to modify a file called html.js,
because there's a chance that the html.ts is not in your folder structure
or is not part of your environment. Hope that's work for you.
El sáb., 7 jul. 2018 a las 10:16, Aditya Ramanathan (<
<EMAIL_ADDRESS>escribió:

I am not able to find html.ts file. Should i create and add the file
directly?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/angular/material2/issues/12027#issuecomment-403198093,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYNCh7jSGTBWwXGNBNuAY5kyUYC97eVuks5uEG5HgaJpZM4VARpg
.

Same error

@prashanthv, @RobynLiu are you getting the same error after applying the solution proposed by @jerryorta-dev ???

@jerryorta-dev fix worked for me.

@jerryorta-dev Fix worked. Thank you!

Same here, I am using<EMAIL_ADDRESS>and the fix #12028 has already been merged in master branch but I still have the error Cannot read property 'startTag' of undefined

@sagarrokade404 using<EMAIL_ADDRESS>worked as well :) thanks!

same here, I cant relate with the suggestions made days ago. There is no schematics folder in my @material/.  "Cannot read property 'startTag' of undefined"

@tobbyGithub Refer to my above comment

Same error

npm uninstall angular-font-awesome font-awesome

I am using the latest angular version : 7.3.2 and I do not find the utils or html.jsthe file in the path<EMAIL_ADDRESS>Is there an alternate rather than changing the html.js file?
if not, how to create one in the folder?

Have the same issue Cannot read property 'endTag' of null on Angular CDK 7.3.7 and no node_modules@angular\material\schematics\utils folder. It has only folders and files:
ng-add
ng-generate
ng-update
collection.json
migration.json

@progmars I have the same error. Did you fix it?

@Vangreen  @kaflake  It seems, Angular is very sensitive to versions - some combinations just do not work together. I recreated the project from scratch, using ng cli tool and made sure to ignore Visual Studio suggestions to upgrade TypeScript compiler etc., because if you upgrade, something breaks.


[transport] Ensure support of the transport-nio by security plugin

Is your feature request related to a problem? Please describe
The OpenSearch security plugin used to tightly integrates with the transport and supported TLS/SSL for transport-netty4 only. Since we've integrated https://github.com/opensearch-project/OpenSearch/issues/12903, it is not an issue anymore and each transport could provide secure variants.
Describe the solution you'd like
Ensure support of secure transports by transport-nio plugin
Related component
Plugins
Describe alternatives you've considered
N/A
Additional context
See https://github.com/opensearch-project/OpenSearch/issues/12903

[Triage - attendees 1 2 3 4 5 6 7]
@reta Thanks for filing this issue


Will there be support for React?

Will there be support for React? It doesn't seem possible on the<EMAIL_ADDRESS>version. Or maybe I don't understand how to use it? I'm not very familiar with coding, I'm doing a small project to improve myself

Hello, React should be supported, but most likely you need to configure your bundler to support WASM ESM proposal.
@Hayakii May I ask what are you using to bundle your React app (Vite, CRA, Next.js)?

As far as you are using Vite or Next.js, the support should be there with appropriate code changes.
For CRA, please follow progress at #21


table index is nil in util.lua

I tried setting up lsp-status according to the example config in the readme but once my lsp loads I get an error (also see https://github.com/nvim-lua/lsp-status.nvim/issues/9#issuecomment-913260530 who seems to be having the same issue):
Error executing vim.schedule lua callback: .../start/lsp-status.nvim/lua/lsp-status/util.lua:62: table index is nil

My lsp/lsp-status config is here. It's basically the lsp-status config from the readme but integrated into the default config from lspconfig.
-- setup lsp status
local lsp_status = require('lsp-status')
lsp_status.config({
})
lsp_status.register_progress()

local nvim_lsp = require('lspconfig')

-- Use an on_attach function to only map the following keys
-- after the language server attaches to the current buffer
local on_attach = function(client, bufnr)
  local function buf_set_keymap(...) vim.api.nvim_buf_set_keymap(bufnr, ...) end
  local function buf_set_option(...) vim.api.nvim_buf_set_option(bufnr, ...) end

  -- Enable completion triggered by <c-x><c-o>
  buf_set_option('omnifunc', 'v:lua.vim.lsp.omnifunc')

-- key bindings

-- lsp_status
  lsp_status.on_attach(client)
end

-- Use a loop to conveniently call 'setup' on multiple servers and
-- map buffer local keybindings when the language server attaches
local servers = { 'julials' }
for _, lsp in ipairs(servers) do
  nvim_lsp[lsp].setup {
    on_attach = on_attach,
    capabilities = lsp_status.capabilities,
    flags = {
      debounce_text_changes = 150,
    }
  }
end

From looking at the lsp-status source my guess is that id is never set but I can't figure out why.

I have the same issue with a similar config, have you found a fix yet?

Sorry for neglecting to get to this for so long. I've been unable to reproduce this issue with your config - do you see this error with servers other than JuliaLS, or just that server?

Also, if you're willing to help debug this, could you please try putting print calls with unique messages at the calls to util.ensure_init in lsp_status.messaging.register_client and lsp_status.messaging.progress_callback, so that we can narrow down where the nil value is occurring?

I'm also not able to reproduce this issue anymore. I tried some things in my config, I guess the order in which plugins are loaded is relevant. The plugin is currently working for me.

yes, it's working for me too now! lightline doesn't seem to support animations but that's fine.


Remove all DD code

Remove all DD code (it will be kept in the reference branch). This is done in order to create a new instrumentors top level directory where to hold all the instrumentors code.
Fixes #3

Can you add a comment in the README regarding the initial code being available as reference in the reference branch? This would help folks taking a look at the repo for the first time. A few files were deleted that shouldn't be. Please fix.

Thanks for the review, I have added the changes :+1:

Had a chat with @ocelotl @codeboten and @mauriciovasquezbernal and we're going to pause on this PR to make the porting of the instrumentation PRs easier.


Typecheck fails using mypy

On the feature-azure-pipelines branch, running mypy blocklib --ignore-missing-imports --no-implicit-optional --disallow-untyped-calls with Python 3.7 fails. The logs are:
blocklib/signature_generator.py:28: error: Incompatible types in assignment (expression has type "object", variable has type "str")
blocklib/signature_generator.py:33: error: Incompatible types in assignment (expression has type "int", variable has type "str")
blocklib/signature_generator.py:34: error: Incompatible types in assignment (expression has type "int", variable has type "str")
blocklib/signature_generator.py:36: error: Incompatible types in assignment (expression has type "object", variable has type "str")
blocklib/signature_generator.py:37: error: Incompatible types in assignment (expression has type "object", variable has type "str")
blocklib/signature_generator.py:38: error: Slice index must be an integer or None
blocklib/signature_generator.py:40: error: Incompatible types in assignment (expression has type "int", variable has type "str")
blocklib/signature_generator.py:41: error: Incompatible types in assignment (expression has type "object", variable has type "str")
blocklib/signature_generator.py:42: error: Slice index must be an integer or None
blocklib/signature_generator.py:44: error: Incompatible types in assignment (expression has type "int", variable has type "str")
blocklib/signature_generator.py:45: error: Incompatible types in assignment (expression has type "object", variable has type "str")
blocklib/signature_generator.py:46: error: Slice index must be an integer or None
blocklib/signature_generator.py:60: error: "int" has no attribute "__iter__"; maybe "__str__", "__int__", or "__invert__"? (not iterable)
blocklib/signature_generator.py:141: error: Cannot call function of unknown type
blocklib/encoding.py:46: error: Need type annotation for 'candidate_bloom_filter' (hint: "candidate_bloom_filter: Set[<type>] = ...")
blocklib/simmeasure.py:103: error: Need type annotation for 'q_gram_cache' (hint: "q_gram_cache: Dict[<type>, <type>] = ...")
blocklib/simmeasure.py:106: error: Need type annotation for 'sim_cache' (hint: "sim_cache: Dict[<type>, <type>] = ...")
blocklib/pprlindex.py:42: error: Need type annotation for 'rec_to_block' (hint: "rec_to_block: Dict[<type>, <type>] = ...")
blocklib/pprlindex.py:73: error: Need type annotation for 'ref_val_list' (hint: "ref_val_list: Set[<type>] = ...")
blocklib/pprlpsig.py:27: error: Call to untyped function "__init__" in typed context
blocklib/pprlpsig.py:35: error: Need type annotation for 'reversed_index' (hint: "reversed_index: Dict[<type>, <type>] = ...")
blocklib/pprllambdafold.py:25: error: Call to untyped function "__init__" in typed context
blocklib/pprllambdafold.py:63: error: Need type annotation for 'invert_index' (hint: "invert_index: Dict[<type>, <type>] = ...")
blocklib/pprllambdafold.py:65: error: Need type annotation for 'lambda_table'
blocklib/candidate_blocks_generator.py:49: error: Call to untyped function (unknown) in typed context
blocklib/blocks_generator.py:53: error: Need type annotation for 'map_rec_block'
blocklib/blocks_generator.py:72: error: Need type annotation for 'cbf' (hint: "cbf: Set[<type>] = ...")
blocklib/blocks_generator.py:76: error: "PPRLIndex" has no attribute "blocking_config"
blocklib/blocks_generator.py:83: error: Unsupported operand types for >= ("Set[Any]" and "int")
Found 29 errors in 8 files (checked 12 source files)

This issue is fixed in pull request #13


[Fix] Unpause atomic writes on block insert error

This PR contains a potential fix to one of the atomic panics we've seen on the devnet:
May 15 15:55:28 ip-172-31-42-88 snarkos[58891]: 2024-05-15T15:55:28.771227Z  WARN snarkos_node_sync::block_sync: Attempted to insert a block at the incorrect height into storage
May 15 15:55:29 ip-172-31-42-88 snarkos[58891]: thread 'tokio-runtime-worker' panicked at /Users/nkls/dev/snarkVM/ledger/store/src/helpers/rocksdb/internal/mod.rs:235:9:
May 15 15:55:29 ip-172-31-42-88 snarkos[58891]: assertion failed: !already_paused

I initially thought the error might suggest the occurrence of simultaneous block inserts from different threads (there are no await points so it can't be from the same task) but the block lock ruled this out. This leaves us with improper handling of unpausing which this changeset aims to fix.
Drafting this PR as I haven't yet been able to confirm this fix is sufficient to resolve the issue entirely.

Is there a way to force this error to occur and validate that this fix correctly addresses the failure case?
In addition, is there a way to determine why the rocksDB write might have failed? Could there be any issues with the BFTPersistentStorage rocksDB usage in snarkOS? Are there any locks we need to enforce between the two rocksdb writes (ledger vs bft)?

@niklaslong correct me if I'm mistaken, but I believe the error was not rocksDB-related, but rather "couldn't insert block at height N".

I believe the only errors in self.block_store().insert(block) are the merkle tree update or RocksDB insert.

BlockStore::insert can also fail as such:
if block.height() != u32::try_from(updated_tree.number_of_leaves())? - 1 {
    bail!("Attempted to insert a block at the incorrect height into storage")
}

Yes, the error I managed to trigger on the devnet was the "incorrect height" ☝

force this error to occur and validate that this fix correctly addresses the failure case?

I didn't have any further luck last week on the devnets but we could try to trigger an error on insert manually to check if the issue can be replicated that way. It would at least validate that it's possible to trigger it on that codepath.

Is this ready for review or is there still changes/testing to be done?

Should  be good to go in theory. Fabiano has encountered the error again on a client, I've sent him a patched branch to try, hopefully we can validate the fix in practice that way 🤞

@HarukaMa thank you for testing the branch! Did you spot any other atomic related panics in your logs?

@HarukaMa thank you for testing the branch! Did you spot any other atomic related panics in your logs?

hmm, after grepping the logs I did see a few panics about 16 hours ago, but as the stderr is not logged to log file I'm not sure what they are about now.

Ran e2e.yml integration test on this, passed succesfully.


openbsd: make WIFCONTINUED() safe

it seems it was a missed part of #1891
Found it because rustc -nightly started to use libc::WIFCONTINUED() recently in a safe context and the build fail to build on OpenBSD.
Fixes #2001

r? @JohnTitor
(rust-highfive has picked a reviewer for you, use r? to override)

r? @JohnTitor
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

@bors r+

:pushpin: Commit cf0793a926460fab325d06191c833a99e347b14f has been approved by JohnTitor

:pushpin: Commit cf0793a926460fab325d06191c833a99e347b14f has been approved by JohnTitor

:hourglass: Testing commit cf0793a926460fab325d06191c833a99e347b14f with merge 7f11cdb191a7d78bc8e09583cec6b67589fe766e...

:hourglass: Testing commit cf0793a926460fab325d06191c833a99e347b14f with merge 7f11cdb191a7d78bc8e09583cec6b67589fe766e...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 7f11cdb191a7d78bc8e09583cec6b67589fe766e to master...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 7f11cdb191a7d78bc8e09583cec6b67589fe766e to master...