chore: remove @redux-devtools/remote to stop unit tests failing

Try out this version of Leather — download extension builds.

This fixes the failing unit tests
https://github.com/leather-wallet/extension/pull/4490#issuecomment-1812791852
I'm not sure if we need @redux-devtools/remote though.
This issue happened when re-adding prism here. I'm trying to think how we can solve it. We don't use nanoid.
Here's a SO
Maybe we should squash and re-write the commits to avoid doing it

@fbwoolf we may be able to avoid this by not adding "prism-react-renderer" but then we won't have the CodeBlock ported over I guess

We might just have to add a resolution to the package.json? I'll check it today. I think we need Prism to display Clarity code? cc @kyranjamie

We do need this to use dev tools

We do need to keep clarity-prism in some way to display Clarity code, correct?

I think this is just the prob here so I can add a resolution to fix I think...

Closing this bc I fixed by adding the resolution to the feature branch, let me know if not a good solution.

Closing this bc I fixed by adding the resolution to the feature branch, let me know if not a good solution.

Great, thanks!


linting issue

linter.log
hello sir , i was runnig rtl to gds flow using openlane , but in am getting linter issue , could you please help me  to take care of it .

attach run log to understand the issue


Locale Modal (React) Prod QA testing

User Story

As a [user role below]:
developer using the ibm.com Library Locale Modal

I need to:
have a version of the component that has been tested for accessibility compliance as well as on multiple browsers and platforms

so that I can:
be confident that my ibm.com web site users will have a good experience

Additional information

This component was recently changed to increase the unit test coverage to 80%.  Because code changes were made as part of this work the new code version must be retested.
Browser Stack link
Browser Standard
Browser versions to be tested:  Tier 1 browsers will be tested with defects created as Sev 1 or Sev 2.  Tier 2 browser defects will be created as Sev 3 defects.
Platforms to be tested, by priority:  1)  Desktop  2)  Mobile  3)  Tablet
Mobile & Tablet iOS versions: 13.1 and 13.3
Mobile & Tablet Android versions: 9.0 Pie and 8.1 Oreo
Browsers to be tested:  Desktop: Chrome, Firefox, Safari, Edge, Mobile: Chrome, Safari, Samsung Internet, UC Browser, Tablet: Safari, Chrome, Android
Accessibility Checklist
Creating a QA bug
This component was originally created in the Fall of 2019.  The original issues are included in the IBM Enterprise Digital Design System Github.
Locale Selector component MVP link
Locale Selector enhancements included in release 2
Functional spec issue (#1315)
Local Modal functional specs:  https://ibm.ent.box.com/file/655028173280
Design specs Box link
Ignore designs on pages 1, 4 & 5
Dev issue to increase the unit test coverage (#2077)
** Development is finished.  The updated code is available on the Canary URL for testing.**

Acceptance criteria

[ ] Accessibility testing is complete.  Pattern is compliant.
[ ] All browser versions are tested
[ ] All operating systems are tested
[ ] All devices are tested
[ ] Defects are recorded and retested when fixed

@Praveen-sr @chetankan This component is ready to be tested.

Prod QA testing has started.

Prod QA Testing is finished.  Has been sent to Accessibility team for testing.

3 Accessibility issues reviewed in the QA meeting.  Bugs will be created.  Testing finished.


CSS support shadowdom selectors?

I have only 1 problem, but maybe we have another problems with shadowdom selectors.
Before beautify: :host ::content after beautify: :host::content. Maybe i can config that?

Is this a problem standard CSS or in something like LESS/SCSS?  I ask because the default beautifier used for CSS is different than for the other languages and I cannot reproduce the problem in those other languages.

@prettydiff ok thanks, i'll test it soon and answer here with tests results

@prettydiff its standard CSS.

It appears csscomb is the default beautifier if I am reading https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/index.coffee correctly.  You may wish to open a bug with that project: https://github.com/csscomb/CSScomb
@Glavin001 is this correct?

The default beautifier for CSS is JS Beautify: https://github.com/Glavin001/atom-beautify/blob/master/src/languages/css.coffee#L28
Also see https://github.com/Glavin001/atom-beautify/blob/master/docs/options.md#language-config---css---default-beautifier


Create unal.txt

I add the domain unal.edu.co corresponding to the National University of Colombia for academic validation.

@alfarito2019 I am sorry, the domain unal.edu.co is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


xworkspaces shows no output at all

This is for exwm.
I've configured xworkspaces in the most trivial way:
[module/xworkspaces]
type = internal/xworkspaces

The output of xprop -root is:
_NET_CLIENT_LIST(WINDOW): window id # 0x1200010
_NET_CLIENT_LIST_STACKING(WINDOW): window id # 0x1200010
_NET_ACTIVE_WINDOW(WINDOW): window id # 0x0
_NET_CURRENT_DESKTOP(CARDINAL) = 0
_NET_DESKTOP_GEOMETRY(CARDINAL) = 1366, 768
_NET_NUMBER_OF_DESKTOPS(CARDINAL) = 4
_NET_DESKTOP_VIEWPORT(CARDINAL) = 0, 0
_NET_WM_NAME(UTF8_STRING) = "EXWM"
_NET_SUPPORTING_WM_CHECK(WINDOW): window id # 0xe00002
_NET_SUPPORTED(ATOM) = _NET_SUPPORTED, _NET_CLIENT_LIST, _NET_CLIENT_LIST_STACKING, _NET_NUMBER_OF_DESKTOPS, _NET_DESKTOP_GEOMETRY, _NET_DESKTOP_VIEWPORT, _NET_CURRENT_DESKTOP, _NET_ACTIVE_WINDOW, _NET_SUPPORTING_WM_CHECK, _NET_CLOSE_WINDOW, _NET_WM_MOVERESIZE, _NET_REQUEST_FRAME_EXTENTS, _NET_WM_NAME, _NET_WM_DESKTOP, _NET_WM_WINDOW_TYPE, _NET_WM_WINDOW_TYPE_DOCK, _NET_WM_WINDOW_TYPE_TOOLBAR, _NET_WM_WINDOW_TYPE_MENU, _NET_WM_WINDOW_TYPE_UTILITY, _NET_WM_WINDOW_TYPE_SPLASH, _NET_WM_WINDOW_TYPE_DIALOG, _NET_WM_WINDOW_TYPE_DROPDOWN_MENU, _NET_WM_WINDOW_TYPE_POPUP_MENU, _NET_WM_WINDOW_TYPE_TOOLTIP, _NET_WM_WINDOW_TYPE_NOTIFICATION, _NET_WM_WINDOW_TYPE_COMBO, _NET_WM_WINDOW_TYPE_DND, _NET_WM_WINDOW_TYPE_NORMAL, _NET_WM_STATE, _NET_WM_STATE_FULLSCREEN, _NET_WM_STATE_DEMANDS_ATTENTION, _NET_WM_ALLOWED_ACTIONS, _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE, _NET_WM_STRUT, _NET_WM_STRUT_PARTIAL, _NET_WM_PID, _NET_FRAME_EXTENTS, _NET_WM_PING, _NET_WM_FULL_PLACEMENT
XFree86_DDC_EDID1_RAWDATA(INTEGER) = 0, -1, -1, -1, -1, -1, -1, 0, 76, -93, 70, 51, 0, 0, 0, 0, 0, 21, 1, 3, -128, 29, 16, 120, 10, -121, -11, -108, 87, 79, -116, 39, 39, 80, 84, 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, -98, 27, 86, 120, 80, 0, 24, 48, 48, 32, 37, 0, 37, -91, 16, 0, 0, 25, 0, 0, 0, 15, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, -76, 2, 116, 0, 0, 0, 0, -2, 0, 83, 65, 77, 83, 85, 78, 71, 10, 32, 32, 32, 32, 32, 0, 0, 0, -2, 0, 76, 83, 78, 49, 51, 51, 65, 84, 48, 49, 56, 48, 49, 0, 93
AT_SPI_BUS(STRING) = "unix:abstract=/tmp/dbus-0WOClmwcpF,guid=ceac96fc7a4d888529b298015b310067"
GDK_VISUALS(INTEGER) = 191, 234
RESOURCE_MANAGER(STRING) = "Emacs.font:\tHack-11\nEmacs.geometry:\t152x43\nEmacs.menuBar:\t0\nEmacs.toolBar:\t0\nEmacs.verticalScrollBars:\toff\nXft.dpi:\t96\n"
_XKB_RULES_NAMES(STRING) = "evdev", "pc105", "us", "altgr-intl", ""
XFree86_has_VT(INTEGER) = 1
XFree86_VT(INTEGER) = 3

There are no desktop names but seems fine otherwise.

The desktop-names are read from _NET_DESKTOP_NAMES. I do not see that property exposed. Therefore, no names are shown.

I understand that, but I tried to output indexes as well to no avail.
On Tue, Jun 26, 2018 at 2:21 PM, Matthias Viehweger <
<EMAIL_ADDRESS>wrote:

The desktop-names are read from _NET_DESKTOP_NAMES. I do not see that
property exposed. Therefore, no names are shown.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jaagr/polybar/issues/1298#issuecomment-400395716, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACtq-XLZjPaHBZg-GXDvnv6q0c06ek_Qks5uAm2QgaJpZM4U2aHO
.

Can you show the xprop output after you set the names?
Also, we have an old PR #904 which should fix this.

Sorry I won't have access to exwm for a while, close this if you prefer and
then I will repoen it if needed.
On Sun, Jul 8, 2018, 3:41 PM NBonaparte<EMAIL_ADDRESS>wrote:

Can you show the xprop output after you set the names?
Also, we have an old PR #904 https://github.com/jaagr/polybar/pull/904
which should fix this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jaagr/polybar/issues/1298#issuecomment-403307332, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACtq-SPXuQMyw2_jEGJoZdmP2pP2hZfaks5uElJGgaJpZM4U2aHO
.


kmesh panic when change bpfloglevel

What happened:
When kmesh is started in ADS mode, the EBPF log level cannot be changed. panic
kubectl exec -it -n kmesh-system kmesh-q4f5d -- curl -s localhost:15200/debug/bpfLogLevel/3
command terminated with exit code 52

kubectl logs -f -n kmesh-system kmesh-q4f5d
2024-07-03T02:36:33.168057Z	info	http: panic serving <IP_ADDRESS>:52122: runtime error: invalid memory address or nil pointer dereference
goroutine 78 [running]:
net/http.(*conn).serve.func1()
	/usr/local/go/src/net/http/server.go:1898 +0xbe
panic({0x28de820?, 0x4e09b80?})
	/usr/local/go/src/runtime/panic.go:770 +0x132
kmesh.net/kmesh/pkg/status.(*Server).bpfLogLevel(0xc0012aa030, {0x32e5f30, 0xc000d96000}, 0xc00074bb00)
	/kmesh/pkg/status/status_server.go:298 +0xe6
net/http.HandlerFunc.ServeHTTP(0xc00129b520?, {0x32e5f30?, 0xc000d96000?}, 0x78c0fa?)
	/usr/local/go/src/net/http/server.go:2166 +0x29
net/http.(*ServeMux).ServeHTTP(0x474b79?, {0x32e5f30, 0xc000d96000}, 0xc00074bb00)
	/usr/local/go/src/net/http/server.go:2683 +0x1ad
net/http.serverHandler.ServeHTTP({0xc0009fe420?}, {0x32e5f30?, 0xc000d96000?}, 0x6?)
	/usr/local/go/src/net/http/server.go:3137 +0x8e
net/http.(*conn).serve(0xc00088c000, {0x32f72c0, 0xc0013062d0})
	/usr/local/go/src/net/http/server.go:2039 +0x5e8
created by net/http.(*Server).Serve in goroutine 120
	/usr/local/go/src/net/http/server.go:3285 +0x4b4
time="2024-07-03T02:54:58Z" level=info msg="grpc reconnect succeed" subsys=controller

What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Kmesh version:
Others:

cc @bfforever

https://github.com/kmesh-net/kmesh/blob/bb1990048f1a58fd1a253b2bcbdf1ad5df287a1b/pkg/status/status_server.go#L298
In ads mode, bpfWorkloadObj not load, cause to nil pointer, I would fix recently.

This is urgent

root@ubuntu-1:/home/zmy/github/kmesh# kubectl exec ds/kmesh -n kmesh-system -- curl -s localhost:15200/debug/bpfLogLevel/3
404 page not found
Is there something wrong with me?


Adds my fork of Homoglyphs

Thank you! Good luck with the project. I'm glad you found it useful :)


add eu_fsf crawler

Added a crawler for Financial Sanctions Files (FSF) published by EU Commision

Ok, this is really good. Thanks!

Ok, this is really good. Thanks!


Issue/#106/blog-post-description

RSS specification does not restrict description length for RSS items so I assumed maximum length to be 4096 characters in db. Even then we have blog post items that descriptions exceed this limit (the longest description was longer that 10000 chcracters). To avoid SQLException in such cases we have to trim the description to fit description column of the BlogPost entity.

Ok, I removed @ExtensionMethod.
To bad it's not supported by IDEA yet :-1: (Eclipse FTW :+1: ). I'm using @ExtensionMethod and @Delegate since I have discovered Lombok. It saved me from writing lot of boilerplate code and makes to code easy to read, especially @ExtensionMethod transforms the code into poetry :)
I'm wondering why Oracle did not adapt this awesome feature into JDK. It's available in Groovy or C# from the very beginning.


Mono .Net Automatic Analysis

Automatic analysis for .net (mono atleast) does not even run

.NET will be awhile, since we will need to extend our IL to support stack based languages like MSIL. Also This is a duplicate of #134


Add noop for both algebras

Added noop implementations for both classic and mtl algebra flavors
Refactor mapK on classic algebra for easier implementation of noop.

@bplommer Thoughts?


Update LSP, tree-sitter and fix spell highlight grups

Update LSP highlight groups (same changes as in the main repo)

Update nvim-treesitter highlight groups. There are ~7 new groups (I changed the order to match the docs but the old order might be more useful, maybe change that)

Update the listed version 😁

Weird that the build number went backwards but whatever. Build number might not be the best way of tracking it all anyway since TS groups are from the TS plugin anyway.


Fix terminationGracePeriodSeconds in Submariner Pods

In K8s the default termination grace period for a Pod is 30
secs. However, for Globalnet, we were configuring this as
0 secs, because of which, cleanup was not happening in a
consistent manner and we are seeing failures in CI jobs.
This PR modifies the terminationGracePeriodSeconds to 10 secs.
Along with this change, it also uses the proper namespace of
submariner in the excluded namespaces.
Fixes issue: https://github.com/submariner-io/submariner-operator/issues/444
Signed-off-by: Sridhar Gaddam<EMAIL_ADDRESS>

The failing test is a known failure (i.e., Pods with HostNetworking will not get globalIp annotation) and is already fixed in shipyard.

Can we generalize the patch and do the same to the other pods?,
I submariner-engine and routeagent also do cleanups at exit. In some cases that is going to be neglected.

The failing test is a known failure (i.e., Pods with HostNetworking will not get globalIp annotation) and is already fixed in shipyard.


Adding new attribute to control save the user groups origin

Adds a new attribute in the WebEntitlementContext sincronized with the user session to keep the origin of the user groups

I would like to see some tests!

one trivial comment, ignore or address as you like, then please merge


chore: use identus apollo

Description:
Updating code to use Identus Apollo
Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

9 of 12 (75.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.499%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/apollo/Apollo.ts
4
7
57.14%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2719

Relevant Lines:
3613

💛  - Coveralls


Backport for release of azure-cosmos_4.53.4-hotfix

API change check
API changes are not detected in this pull request.

/azp run java - cosmos - tests


Contact people in other teams for interest in pairing

What
Contact other frontend developers in service teams to propose pairing for observation while they try to upgrade to v5.
Why
We'd like to take advantage of the v5 pre-release to pair with people from other teams and witness which issue they come across when trying to upgrade to v5.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when

[ ] We've contacted the other developers and have a list of who's keen for pairing.

Moved as this is underway.

Closing as pairing is underway: https://github.com/alphagov/govuk-frontend/issues/4294


Interpolate STACK and GRID inside variable definitions

This is possible now:
variables:
  foo:
    type: string
    from:
      vault: ${STACK}-foo-password

These two envs are always set before yaml parsing by the CLI in #1475
Fixes #1473

Hold on

Needs rebase

Needs close I think. The other PR interpolates all ENVs into variables.

git master already seems to interpolate ${STACK} within the variables? Unfortunately, it only interpolates the stack: ... name from the YAML, which is almost useless. It should interpolate the kontena stack install --name ... :( #1504

Closing. See #1475 + #1505


Add watch to dev style

📥 Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
☑ Submission checklist

[ ] I have read the CONTRIBUTING doc
[ ] yarn build works locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

💬 Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc...

@piofinn
This is a very small, but handy branch. I went through all components and noticed that two of them were missing ":watch" command. So, no more doubts for newbies like me :)


I am using junit5-getting 401 authentication error while using post and get in same scenario

Given path 'api/project/write/updateProject'
And request prjct
When method post
Then status 200
#And print response
And string NewprjctId = response.projectId
Given path 'api/project/findProjectById/'+NewprjctId
When method post
Then status 200
And print response
And match NewprjctId == project_Id
the same script works fine in junit4 but with junit5 it throws an error.
Not sure what iam doing wrong.
TEam can you please help here.
iam getting below error. authentication details are passed in config file and is being used as well. Post request is a success whereas get request gives error. Anything i am doing wrong.
status code was: 401, expected: 200, response time in milliseconds: 65, url: https://gfciu-gateway-dk1986-a.dei1f.paas.intranet.db.com/api/project/findProjectById/11554, response:
{"exception":"com.db.fciu.gateway.exceptions.AuthenticationException","path":"/api/project/findProjectById/11554","code":"UNAUTHORIZED","method":"GET","message":"Authentication required.","timestamp":"2022-11-23T15:18:53.767+00:00","status":401}
src/test/java/features/postRequests/UpdateProjectRandom.feature:54

follow this process to reopen: https://github.com/karatelabs/karate/wiki/How-to-Submit-an-Issue

@pranjalbhatia1987 sorry please read the instructions again, cut and paste code is not helpful. please note that you are mixing old versions of karate which is not supported.


Note API calls to syslog and the audit log

These are changes from @alecbenson's PR#109 (for the fedora-1.8 branch), cherry-picked and with merge conflicts resolved.
We had to move from reading the host config directly from the container structure because the field is no longer public.  Instead, we take a bit of a hit by calling ContainerInspect(), which returns that data, along with some that we discard.

Oh, and I also made some changes to the placement of commas in the logged text.  Mistakes there are mine.

Thanks @nalind!  :+1:

Fixing some warnings from the recently-added lint validation checks and rebasing.

Now that we have a working os/user in Fedora, we don't need to call getpwuid() using cgo any more, and we don't need to bother with switching to getpwuid_r().
I'm getting a panic in the integration tests the second time we try to log something for a user with no login UID set (the kernel casts -1 to a UID, which is unsigned, which gives us<PHONE_NUMBER>), and am trying to run that down.

Ok,
I merged your changes.

Please send new patch and I will merge with privous

Turns out it's not a bug in this patch set; the crash appears to be a bug in the libc that we're using.


"Ștefan cel Mare" and "Ianca Nouă" are listed in the drop-down menu

Description:
When user writes ”Ștefan cel Mare” and "Ștefan cel Mare" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Ștefan cel Mare".

Expected results
The location is listed in the drop-down menu as "Sat Ștefan cel Mare OLT (Ștefan cel Mare)".

Step 2
Write in the search bar "Ianca Nouă".

Expected results
The location is listed in the drop-down menu as "Sat Ianca Nouă OLT (Ștefan cel Mare)".


JOINDIN-642 Additional fix

@liam-wiltshire  This is the fix for rejecting a claim.
Also it looks like the looping was in the wrong place. Fixed that

Can one of the admins verify this patch?

Ok to test

ok to test


feat: free-course-list cards & description

On the new incoming website of starter-kit.
I want them minimalist, not big cards.

I want to see cards (logo or their banner) and descriptions.
Ex.:

Link: https://github.com/SurPathHub/starter-kit/blob/main/courses/free-course-list.md

We can make improvements to this design if you don't mind.

Thanks! I would like to hear your cool ideas again ✨

For sure,


ci: Update labeler.yml

This bump by dependabot couldn't be checked and broke this module. The event only runs off master, so I'll need to merge and find out it this fixes the issue.
https://github.com/wcampbell0x2a/backhand/commit/cb27266f84e861420f9fb03f43989955d5409672


As a user, I want to see a history list of my distinct chats

This issue is for a: (mark with an x)
[ ] bug report -> please search issues before submitting
[x] feature request
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Description

As a user, I want to have my chats saved so that I am able to persist them across client sessions

Predecessor feature: #13
Expected/desired behavior

[ ] Show the conversations in a left panel for the user to be able to select and have the conversation be the active chat window
[ ] Should have helpful (short) description (probably GPT-generated) of what the chat is about
[ ] Pull the conversations from CosmosDB for that user
[ ] Should only be able to see my conversations (not able to see other users - i.e. authenticated user only)

Mention any other details that might be useful

Ability to delete chat is not included in this feature

Will need to decide how to create the cosmsodb object schema for history objects in the CosmosDB https://github.com/bdleavitt/chatgpt-on-azure/wiki/Chat-History-objects-in-nosql-cosmos--%235

Closed.


Follow up after April 22 Style Council and publish updates

What
Write up of meeting notes and actions taken and share with attendees
Content changes published in service manual
Done when

[x] notes written up
[x] action points agreed and allocated
[x] notes and actions shared on Slack content channel
[x] notes and actions approved by clinicians
[x] agree when to publish new standard
[x] GitHub updated
[ ] Outcomes of Style Council meeting communicated
[ ] Make other minor changes before publishing
[ ] Amendments made to style guide and published

Other actions

[ ] respond Amy at GDS re COVID style guide

Related task

[ ] Content creation principles #1740
[ ] Reading age - PIF feedback
[ ] Negative - we already have positive
[ ] Specialty of speciality
[ ] Report on skin symptoms update
[ ] Report on user research - content style guide and inclusive content guide

For future consideration:
May?

[ ] 1 versus one for professional audiences: https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/321#issuecomment-1031635148
[ ] Skin symptoms - add further examples
[ ] Skin symptoms - Pathways user research
[ ] Links - update on analytics
[ ] Choosing content formats - draft in NHS.UK Confluence - see GitHub issue #1672 1680

Not yet ready:

[ ] Deaf people and deafness/ versus hearing loss - https://github.com/nhsuk/nhsuk-service-manual-backlog/issues/211#issuecomment-845010321
[ ] Do and don't list feedback
[ ] autism - "autistic people" -
[ ] contractions - see comment from Karin

Amendments to style guide:

added entry for negative to A to Z
amended entry for positive in A to Z


Optimize code to remove useless objects

Optimize code to remove useless objects
update before
public void addAttachments(Map<String, String> attachments) {
if (attachments == null) {
return;
}
if (this.attachments == null) {
this.attachments = new HashMap<String, String>();
}
this.attachments.putAll(attachments);
}
update after
public void addAttachments(Map<String, String> attachments) {
if (attachments == null) {
return;
}
if (this.attachments == null) {
this.attachments = attachments;
}else{
this.attachments.putAll(attachments);
}
}

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3e02287). Click here to learn what that means.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #7572   +/-   ##
=========================================
  Coverage          ?   58.66%
  Complexity        ?      526
=========================================
  Files             ?     1076
  Lines             ?    43417
  Branches          ?     6321
=========================================
  Hits              ?    25470
  Misses            ?    15088
  Partials          ?     2859

Impacted Files
Coverage Δ
Complexity Δ

...main/java/com/alibaba/dubbo/rpc/RpcInvocation.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e02287...6d56b90. Read the comment docs.


Add ngjiayuan.md and edit DG

Codecov Report

Merging #189 (f1e3de4) into master (4a87e64) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #189   +/-   ##
=========================================
  Coverage     69.16%   69.16%
  Complexity      579      579
=========================================
  Files            90       90
  Lines          1933     1933
  Branches        268      268
=========================================
  Hits           1337     1337
  Misses          484      484
  Partials        112      112

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a87e64...f1e3de4. Read the comment docs.


drivers: i2c: Update drivers to use devicetree Kconfig symbol

Update i2c drivers to use DT_HAS__ENABLED Kconfig symbol
to expose the driver and enable it by default based on devicetree.
We remove 'depend on' Kconfig for symbols that would be implied by
the devicetree node existing.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Its interesting to go this route, does this mean the various dt helpers are no longer the recommended way?

Its interesting to go this route, does this mean the various dt helpers are no longer the recommended way?

Only for Kconfig, this is the recommend way forward.

@teburd can you take another look/approve.

@teburd ping

@teburd ping

I'm guessing he's on vacation... but not 100% sure.


Consider per-language core-interface repos

Go implementation of core-interface (CoreAPI) is getting to the stage where it can be extracted from go-ipfs repo, and afaik it's supposed to live it this repo together with js interface definitions / tests.
But there are problems:

Both NPM and GX use package.json
Many tools expect package.json to live in repository root (things like gx-workspace, our Jenkins pipelines)
Packages will carry unnecessary bloat (this can probably be mitigated)
This will only get worse with more languages

I'd say that this repo should stay focused on JS, and interface repos should be called [lang]-ipfs-interface
@alanshaw @Stebalien @daviddias (+others) Thoughts?

Seems that we have consensus. Wanna take this on?
Pinging @vasco-santos @jacobheun to update the libp2p ones as well (note, we can keep the package name)

So interface-go-ipfs? I'll handle Go side soon, after https://github.com/ipfs/go-ipfs/pull/5969 and one other PR with minor fixes.

interface-go-ipfs-core to be exact (HTTP API and CLI are the other APIs)

@daviddias just to clarify, the goal is to have, for example, interface-stream-muxer be a language agnostic repo for design/docs and we would create interface-js-stream-muxer with the current content, except the go information?

Repo renamed and PR here for moving stuff in js/ dir back to root: https://github.com/ipfs/interface-js-ipfs-core/pull/435

@daviddias any reason to do interface-[lang]-[name] instead of [lang]-[name]-interface? We have quite a few packages following the latter convention.

I'm ok with that also, in fact I think I prefer it - so it would be js-interface-ipfs-core and go-interface-ipfs-core for example.

Yes but @daviddias asked for the current naming scheme so I'd like to get his reasoning before we rename again.

We've been using interface-* since 2015 in multiple places https://github.com/libp2p?utf8=✓&q=interface-&type=&language=, that's pretty much my reasoning.

Shall we close this? https://github.com/ipfs/interface-go-ipfs-core exists now.


Tuple indexing expression support

We do currently not have support for accessing the fields of a tuple, which I've added support for in this PR.
The syntax for a tuple indexing expression is the same as in rust, e.g.,
async fn main() {
    t = ("a", "b")
    print("{t.0}").await #! OUTPUT a
    print("{t.1}").await #! OUTPUT b
}

I'm not sure if this is the syntax we want, but I'm happy to do something else as well.

@Aadamandersson this is cool, thanks! Let me check it out.

bors r+


unknown type name ‘class’  class SimpleStringCollection;

Installed cpputest as mentioned in http://cpputest.github.io/ for ubuntu 16.04
$ apt-get install cpputest
Then create C project in eclipse and add below files at main.c
#include <stdio.h>
#include <stdlib.h>
#include "CppUTest/CommandLineTestRunner.h"
#include "CppUTest/TestHarness_c.h"
int main (void) {
	puts("!!!Hello World!!!"); /* prints !!!Hello World!!! */
//	CommandLineTestRunner::RunAllTests(ac, av);
	return EXIT_SUCCESS;
}

then build the project but build failed with below error
Building file: ../src/edgeDeviceApp.c
Invoking: GCC C Compiler
gcc -I"/home/dattatray/workspace_C/edgeDeviceApp/src/common" -I"/home/dattatray/workspace_C/edgeDeviceApp/src/utils" -O0 -g3 -Wall -c -fmessage-length=0 -MMD -MP -MF"src/edgeDeviceApp.d" -MT"src/edgeDeviceApp.o" -o "src/edgeDeviceApp.o" "../src/edgeDeviceApp.c"
In file included from /usr/include/CppUTest/Utest.h:34:0,
from /usr/include/CppUTest/TestHarness.h:39,
from /usr/include/CppUTest/CommandLineTestRunner.h:31,
from ../src/edgeDeviceApp.c:14:
/usr/include/CppUTest/SimpleString.h:43:1: error: unknown type name ‘class’
class SimpleStringCollection;
src/subdir.mk:18: recipe for target 'src/edgeDeviceApp.o' failed
^
/usr/include/CppUTest/SimpleString.h:44:1: error: unknown type name ‘class’
class TestMemoryAllocator;
^
/usr/include/CppUTest/SimpleString.h:46:1: error: unknown type name ‘class’
class SimpleString
^
/usr/include/CppUTest/SimpleString.h:47:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘attribute’ before ‘{’ token
{
^
/usr/include/CppUTest/SimpleString.h:114:1: error: unknown type name ‘class’
class SimpleStringCollection
^
/usr/include/CppUTest/SimpleString.h:115:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘attribute’ before ‘{’ token
{
^
/usr/include/CppUTest/SimpleString.h:134:1: error: unknown type name ‘SimpleString’
SimpleString StringFrom(bool value);
^
/usr/include/CppUTest/SimpleString.h:134:25: error: unknown type name ‘bool’
SimpleString StringFrom(bool value);
^
/usr/include/CppUTest/SimpleString.h:135:1: error: unknown type name ‘SimpleString’
SimpleString StringFrom(const void* value);
^
/usr/include/CppUTest/SimpleString.h:136:1: error: unknown type name ‘SimpleString’
SimpleString StringFrom(char value);
^
/usr/include/CppUTest/SimpleString.h:136:14: error: conflicting types for ‘StringFrom’
SimpleString StringFrom(char value);
^
/usr/include/CppUTest/SimpleString.h:135:14: note: previous declaration of ‘StringFrom’ was here
SimpleString StringFrom(const void* value);
^
/usr/include/CppUTest/SimpleString.h:137:1: error: unknown type name ‘SimpleString’
SimpleString StringFrom(const char value);
^
/usr/include/CppUTest/SimpleString.h:137:14: error: conflicting types for ‘StringFrom’
SimpleString StringFrom(const char value);
^
/usr/include/CppUTest/SimpleString.h:135:14: note: previous declaration of ‘StringFrom’ was here
SimpleString StringFrom(const void value);
^
/usr/include/CppUTest/SimpleString.h:138:1: error: unknown type name ‘SimpleString’
SimpleString StringFromOrNull(const char * value);
^
/usr/include/CppUTest/SimpleString.h:139:1: error: unknown type name ‘SimpleString’
SimpleString StringFrom(int value);
^
/usr/include/CppUTest/SimpleString.h:139:14: error: conflicting types for ‘StringFrom’
SimpleString StringFrom(int value);
^
/usr/include/CppUTest/SimpleString.h:135:14: note: previous declaration of ‘StringFrom’ was here
SimpleString StringFrom(const void value);
^
/usr/include/CppUTest/SimpleString.h:140:1: error: unknown type name ‘SimpleString’
SimpleString StringFrom(unsigned int value);
^
/usr/include/CppUTest/SimpleString.h:140:14: error: conflicting types for ‘StringFrom’
SimpleString StringFrom(unsigned int value);
^
/usr/include/CppUTest/SimpleString.h:135:14: note: previous declaration of ‘StringFrom’ was here
SimpleString StringFrom(const void* value);
^
/usr/include/CppUTest/SimpleString.h:141:1: error: unknown type name ‘SimpleString’
SimpleString StringFrom(long value);
^
/usr/include/CppUTest/SimpleString.h:141:14: error: conflicting types for ‘StringFrom’
SimpleString StringFrom(long value);
^
/usr/include/CppUTest/SimpleString.h:135:14: note: previous declaration of ‘StringFrom’ was here
SimpleString StringFrom(const void* value);
^
/usr/include/CppUTest/SimpleString.h:142:1: error: unknown type name ‘SimpleString’
SimpleString StringFrom(unsigned long value);
^
/usr/include/CppUTest/SimpleString.h:142:14: error: conflicting types for ‘StringFrom’
SimpleString StringFrom(unsigned long value);
^
/usr/include/CppUTest/SimpleString.h:135:14: note: previous declaration of ‘StringFrom’ was here
SimpleString StringFrom(const void* value);
^
/usr/include/CppUTest/SimpleString.h:143:1: error: unknown type name ‘SimpleString’
SimpleString HexStringFrom(long value);
^
/usr/include/CppUTest/SimpleString.h:144:1: error: unknown type name ‘SimpleString’
SimpleString HexStringFrom(unsigned long value);
^
/usr/include/CppUTest/SimpleString.h:144:14: error: conflicting types for ‘HexStringFrom’
SimpleString HexStringFrom(unsigned long value);
^
/usr/include/CppUTest/SimpleString.h:143:14: note: previous declaration of ‘HexStringFrom’ was here
SimpleString HexStringFrom(long value);
^
/usr/include/CppUTest/SimpleString.h:145:1: error: unknown type name ‘SimpleString’
SimpleString HexStringFrom(const void* value);
^
/usr/include/CppUTest/SimpleString.h:145:14: error: conflicting types for ‘HexStringFrom’
SimpleString HexStringFrom(const void* value);
^
/usr/include/CppUTest/SimpleString.h:143:14: note: previous declaration of ‘HexStringFrom’ was here
SimpleString HexStringFrom(long value);
^
/usr/include/CppUTest/SimpleString.h:146:1: error: unknown type name ‘SimpleString’
SimpleString StringFrom(double value, int precision = 6);
^
/usr/include/CppUTest/SimpleString.h:146:53: error: expected ‘;’, ‘,’ or ‘)’ before ‘=’ token
SimpleString StringFrom(double value, int precision = 6);
^
/usr/include/CppUTest/SimpleString.h:147:1: error: unknown type name ‘SimpleString’
SimpleString StringFrom(const SimpleString& other);
^
/usr/include/CppUTest/SimpleString.h:147:43: error: expected ‘;’, ‘,’ or ‘)’ before ‘&’ token
SimpleString StringFrom(const SimpleString& other);
^
/usr/include/CppUTest/SimpleString.h:148:1: error: unknown type name ‘SimpleString’
SimpleString StringFromFormat(const char* format, ...) check_format(printf, 1, 2);
^
/usr/include/CppUTest/SimpleString.h:149:1: error: unknown type name ‘SimpleString’
SimpleString VStringFromFormat(const char* format, va_list args);
^
/usr/include/CppUTest/SimpleString.h:150:1: error: unknown type name ‘SimpleString’
SimpleString StringFromBinary(const unsigned char* value, size_t size);
^
/usr/include/CppUTest/SimpleString.h:151:1: error: unknown type name ‘SimpleString’
SimpleString StringFromBinaryOrNull(const unsigned char* value, size_t size);
^
/usr/include/CppUTest/SimpleString.h:155:18: fatal error: string: No such file or directory
compilation terminated.
make: *** [src/edgeDeviceApp.o] Error 1
21:30:07 Build Failed. 38 errors, 0 warnings. (took 932ms)

Can you include TestHarness.h and not the _c variant?

You've got C++ syntax in a main.c.  Rename to main.cpp.

Is it working now or still problems there?


Vitis AI 2.0 compile issue

An error occurred while compiling a tf2 quantization model (h5) using Vitis ai 2.0
I successed Vitis ai tutorial using tf2
but I failed with my custom model

plz help me
Thank you for Vitis ai manager

Hi @gkdl0335 ，
Can floating point and quantized models and code be provided? We need these files to analyze the problem.
Thanks.
Regards

The Issue existed for a long time with no response, I will close it , U can reopen it @gkdl0335 when you need.


Bug in loading png with indexed colors

Hi,
I've find out that there is an issue with loading png images with 4 bits indexed colors. I belive the problem is cased by two bugs in Common/Extensions/ByteExtensions.cs and in Formats/Png/PaletteIndexReader.cs. I've figured out how to fix them but I'm not sure if this does not break something else.
This is fix for ByteExtensions:
public static byte[] ToArrayByBitsLength(this byte[] bytes, int bits)
        {
            Guard.NotNull(bytes, "bytes");
            Guard.MustBeGreaterThan(bits, 0, "bits");

            byte[] result;

            if (bits < 8)
            {
                result = new byte[bytes.Length * 8 / bits];

                //BUGFIX i dont see a reason for this: int factor = (int)Math.Pow(2, bits) - 1;
                int mask = 0xFF >> (8 - bits);
                int resultOffset = 0;

                foreach (byte b in bytes)
                {
                    for (int shift = 0; shift < 8; shift += bits)
                    {
                        int colorIndex = ((b >> (8 - bits - shift)) & mask);//BUGFIX removed * (255 / factor);

                        result[resultOffset] = (byte)colorIndex;

                        resultOffset++;
                    }
                }
            }
            else
            {
                result = bytes;
            }

            return result;
        }

And this is fix for PaletteIndexReader:
if (this.paletteAlpha != null && this.paletteAlpha.Length > 0)
            {
                // If the alpha palette is not null and does one or
                // more entries, this means, that the image contains and alpha
                // channel and we should try to read it.
                for (int i = 0; i < header.Width; i++)
                {
                    index = newScanline[i];
                    offset = ((this.row * header.Width) + i) * 4;
                    int pixelOffset = index * 3;

                    float r = this.palette[pixelOffset] / 255f; //BUGFIX this used to be newScanline[pixelOffset]
                    float g = this.palette[pixelOffset + 1] / 255f; //BUGFIX this used to be newScanline[pixelOffset + 1]
                    float b = this.palette[pixelOffset + 2] / 255f; //BUGFIX this used to be newScanline[pixelOffset + 2]
                    float a = this.paletteAlpha.Length > index
                                            ? this.paletteAlpha[index] / 255f
                                            : 1;

                    Color color = new Color(r, g, b, a);
                    if (color.A < 1)
                    {
                        // We want to convert to premultiplied alpha here.
                        color = Color.FromNonPremultiplied(color);
                    }

                    pixels[offset] = color.R;
                    pixels[offset + 1] = color.G;
                    pixels[offset + 2] = color.B;
                    pixels[offset + 3] = color.A;
                }
            }

PS Great work, I'm finding this project really useful.

Ah excellent! Thanks for this!
There's a few small bits of the codebase I inherited from other projects that weren't fully tested. Indexed pngs is one of those last sections. Would you be able to submit a PR with the updated code and a test image? I could start working on encoding them too then.

Sure, when I get to work I will get on that.

Ok so I have issued a Pull Request with proposed changes: #325 . I'm just getting started with GitHub so I hope I did it right.

Absolutely brilliant. Thank you :+1:


Extend redis subscriptions service collection extensions to use a factory method

Can you add tests for the extension methods.... then we can merge it.


fix wrong number in service-ip-dynamic-and-static-allocation

I have checked that the Chinese version is correct.
`min(max(16,4096/16),256)` = `min(256,256)` = 256

/cc aojea

/lgtm
/approve
right, thanks for catching it

/assign @onlydole

@pacoxu Please look at the changes which are being requested.

/approve

That looks correct!
/ready-to-merge

Great.
/lgtm

Thank you, @pacoxu, for this contribution!
/approve


[Misc][Refactor] Introduce ExecuteModelData

The current execute_model() interface accepts the following arguments:
seq_group_metadata_list: List[SequenceGroupMetadata],
blocks_to_swap_in: Dict[int, int],
blocks_to_swap_out: Dict[int, int],
blocks_to_copy: Dict[int, List[int]],
num_lookahead_slots: int,

Since this interface is used by many executors, it is tedious when we want to pass a new argument to the executor, especially not all executors need all arguments. In this PR, we introduce a simple data class ExecuteModelData that encapsulates all arguments but seq_group_metadata_list.
On top of it, we also add running_queue_size to ExecuteModelData. running_queue_size indicates the current running requests, and will be used by speculative decoding in follow-up PRs.
cc @cadedaniel @Yard1 @LiuXiaoxuanPKU @rkooo567
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Thanks for the prompt review. Will fix all CI failures asap.


add peerDeps, fix Cannot find module

Error: Cannot find module 'webpack/lib/node/NodeTemplatePlugin'

Hmm could you change the peerDependency version to *?
Or do you think this might cause unintended issues?

Or do you think this might cause unintended issues?

yep, the major version maybe including some break changes, so I think keep 1.x is better

But we have also support for webpack 2

how about >= 1.12.0 < 3


EnqueueIn doesn't seem to be working

Hi,
I've been testing CakeResque for a week now, and all seemed very fine, but since yesterday that i've been struggling to add a delayed task.
I only have one scheduler worker and one regular worker running, only the default queue, and it seems that all jobs get processed without failing, but nothing seems to happen.
I have tried the exact same code with just enqueue and it works, when i change to enqueueIn it doesn't work...
Let me know if I'm doing anything wrong; below is the code and outputs of cakeresque
Stats:
Resque Statistics
Jobs Stats
Processed Jobs :          430
Failed Jobs    :            0
Scheduled Jobs :            0
Queues Stats
Queues count : 1
- default         :            0 pending jobs
Workers Stats
Workers count : 2
REGULAR WORKERS
* ubuntu:11931:default
- Started on     : Sat Apr 15 12:16:42 UTC 2017
- Processed Jobs : 22
- Failed Jobs    : 0
SCHEDULER WORKER
   - Started on     : Sat Apr 15 12:16:49 UTC 2017
   - Delayed Jobs   : 17
   - Next Job on    : Thu Jan 01 00:00:00 UTC 1970

PHP:
// with enqueueIn; not working
CakeResque::enqueueIn(
5,
'default',
'BackgroundShell',
array('test', $data)
);
// with enqueue; working
CakeResque::enqueue(
'default',
'BackgroundShell',
array('test', $data)
);

If anyone facing this problem, please use enqueueAt instead of enqueueIn.
CakeResque::enqueueAt(
    new DateTime('2019-12-01 15:56:23'),
    'default',      // Queue Name
    'FriendShell', // Job classname
    array('findNewFriends', 'John Doe', 'Ghana') // Various args
);

or If you want to tigger in next 20 minutes,
$scheduleTime = strtotime("+20 minutes");
CakeResque::enqueueAt(
    new DateTime(date('Y-m-d H:i:s',$scheduleTime)),
    'default',      // Queue Name
    'FriendShell', // Job classname
    array('findNewFriends', 'John Doe', 'Ghana') // Various args
);

Hope this help to others.

Just got a update for this. When I flushdb in redis-cli, all queue job stuck in
Thu Jan 01 07:30:00 SGT 1970 (I used Singapore Timezone)
I hope, this can help someone too.


KAFKA-16333 remove deprecated join method with named param

Resolves https://issues.apache.org/jira/browse/KAFKA-16333
Removes deprecated join method with Named param
Committer Checklist (excluded from commit message)

[X] Verify design and implementation
[X] Verify test coverage and CI build status
[X] Verify documentation (including upgrade notes)

@mjsax would you like to take a look at this one ?

Thanks for the PR. Merged to trunk.

Thank you.


Bug - No result message shows up, although there are results.

Hi,
At the initial start of the app, if I type in one thing and get results, I get the button selections for the icon sets with results. Cool! However, if I undo that search and start again, then it shows, correctly, other icon sets, but also shows the no results message at the bottom, which it shouldn't.

Scott

@smolinari For the second part, what do you think of this when the results don't have a match for the currently selected icon set?

I'll address the first part shortly.

When there is no icon set selected and no matches for the filter, you will no see this:

Fix in new release (but available now when built on Netlify)

@hawkeye64 - I didn't even get past the initial startup and search. But, if an icon set is selected and a new search is done, and nothing is found in that selected icon set, the suggestion above to show there aren't any in the icon set is good.
This issue was started, because if I searched for something and there were icon sets found, the buttons would show to select from. If I change the search entry without any selection, then I got the "No icons found that match the filter". I should have just gotten the new set of selection buttons.
I tested again. "No Icons Found" isn't true on the first search. I get a lot of icon set selections from the search. The message should be "Icons found, select an icon set above to peruse the results in each set." or something to that effect. Or, don't show any message, as it was before.
Scott

Yes, eventually there will be instructions on the main page when you arrive.
Also, sometimes the message will show up because the message is taking too long. I need to set a var so a spinner can appear while the search is happening.

I just released v2.4.0 - this should satisfy all of your concerns @smolinari .
If you find anything further, do not hesitate to create an issue. Thanks.

Good job @hawkeye64 !!! 👍
Scott


Threat dragon online only uses public git repos to save threat models

Describe the bug
When using threat dragon online (https://threatdragon.org/) it will only accept a public git repo to save the threat model. This is no good for a corporate environment as threat models can't be publicly available. We wanted to use the online version as it is said to be slightly better than the desktop version in terms of being able to move lines around with out it adding additional control points, having a better undo when this happens, larger settings cog on lines so you can enter a threat, etc. Please could you advise?
Expected behaviour
Ability to select private git repo.
Environment

Online version in latest chrome browser

To Reproduce
See description.

Hello @huwjeffries - could you try setting GITHUB_SCOPE? Set this to 'repo' if you want access to private repos, it defaults to public. There is some more info in the docs at https://docs.threatdragon.org/setup-env/
I do not have any private github repos myself, so could you tell me if it still tests out OK? It  was tested some time ago, and I hope it still owrks as expected

Hi @huwjeffries
The threatdragon.org site is meant to serve as a demo area.  In the future, we may have a more permanent/reliable solution that is publicly available. Most users opt to host the web version in their own environment, or use the desktop version.  Threat Dragon saves all the models as JSON, so many organizations use source control alongside the web version for change/version management (I know you said you're avoiding additional control points, just thought it was worth mentioning!)
If you're hosting your own instance, there's some configuration that needs to be done, which is what @jgadsden was referring to.  I created a private repo to test this and it seems that setting GITHUB_SCOPE to repo still works as expected.  There's also multiple deployment/installation methods including a docker image.  The configuration docs also include an example docker-compose file that shows how to stand up the web version with file-based secrets (eg docker secrets if you're running in swarm mode, or in kubernetes)
Let us know if you have any other questions or if we can help!

Thanks, that's good to know.

We can close this issue now, if that is OK with @huwjeffries ?

We can close this issue now, if that is OK with @huwjeffries ?

Yes, please go ahead and close it.

Yes, please go ahead and close it.


Prealpha prefinal

This represents the integration of the successful reference configuration from the simulation we performed yesterday on 2024-03-22 devnet data. Further work is outstanding, but this gets us close.

!ci-build-me

!ci-nightly-me

!ci-nightly-me

!ci-build-me

!ci-nightly-me

!ci-build-me

!ci-nightly-me

!ci-build-me

Nightly is happy modulo the develop merge and the version linter flake https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/1659

devnet initial migration verified on 03-22 data, running final migration.


fix: some improvements

Description
This PR includes the following changes:

Fixing mistakes in the New Address dialog.
Preventing package shadowing.
Rebuilding models enough to rebuild the view.

@jemiluv8 merge this and let's finalize the PR

@themantre I just merged.


Make reversed on Tensor public

Hello,
I was excitedly going to use Tensor.reversed() in my project and find out that it is not public in swift-APIs. I looked at https://github.com/tensorflow/swift-apis/pull/709 and it does not seem to be intended. Hope this is helpful PR.

LGTM! Thank you!


feat: PRT: Generic parsers implementation - basic

Description
Closes: #XXXX

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] read the contribution guide
[ ] included the correct type prefix in the PR title, you can find examples of the prefixes below:

[ ] confirmed ! in the type prefix if API or client breaking change
[ ] targeted the main branch
[ ] provided a link to the relevant issue or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] included the necessary unit and integration tests
[ ] updated the relevant documentation or specification, including comments for documenting Go code
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

New Features

Enhanced JSON configuration with new parsing capabilities for improved data handling.
Introduced new dependencies to support JSON querying and time formatting.

Bug Fixes

Improved error handling and tracing in parsing logic, enhancing reliability.

Tests

Expanded test suite for ParseBlockFromParams to cover new parsing scenarios and edge cases.

Made a new branch, will create new PR for it


How to overcome Issue 1881

This is not a bug report ;-). The bug https://github.com/facebookincubator/create-react-app/issues/1881 was already closed.
However I cloned a project which was originally generated by CRA. I developed it in my direction and now I observed Issue 1881 (exactly the same).
The issue was closed with https://github.com/facebookincubator/create-react-app/commit/4b92fd366c615ab860f25a5dc2bb0bd0bfddd7bf .
The problem in the issue seems to be the ansi-html module.
In my project  I have
"react-dev-utils": "^0.4.2",
in my package.json.
This version of react-dev-utils references ansi-html in exactly version 0.0.5 which caused the bug above.
Current version of ansi-html is 0.0.7. In this version the trailing coma is deleted and it should all be fine.
However, when I simply replace react-dev-utils 0.4.2 with react-dev-utils 4.0.1 I get other errors.
What would be a sensible upgrade path?

@porschberg unfortunately there was never a version of 0.9.x released which included the upgraded copy of ansi-html; so you'll need to fork the package and publish a corrected version yourself.
You could try<EMAIL_ADDRESS>and see if it works, it may.
The proper upgrade path would be to upgrade your CRA setup as a whole, maybe create a new project, eject it, and then copy the configuration over your current setup -- re-adding any modifications you had to make.
Unfortunately, ejecting puts you in a bad position -- you stop receiving updates, and it requires manual tracking to stay up to date.

This was fast, thank you. I tried<EMAIL_ADDRESS>but there seems a similar problem with IE11 and trailing coma. This time it comes from webpackHotDevClient.js
    // Connect to WebpackDevServer via a socket.
    var connection = new SockJS(
        url.format({
         protocol: window.location.protocol,
         hostname: window.location.hostname,
         port: window.location.port,
         // Hardcoded in WebpackDevServer
          pathname: '/sockjs-node',
        })
     );

Yikes! I have not a clue when we could've fixed it then 😞.
Could you try to upgrade to the latest version? If that still has a problem we can talk about fixing it and getting a release out.
Alternatively, you can fork the package and publish that corrected version yourself.

Closing this as unactionable, hope you figured this out!


unit testing for storagecluster controllers

Refactored Storage Cluster Controller init and added Unit Test
Signed-off-by: Marco Yeung<EMAIL_ADDRESS>

Note: tests will be affected by #66 if that merges in first (refactoring init code in controllers)

/assign @jarrpa

/lgtm


Input shape for swin transformer backbone ?

Hi,
First, thanks for this work !
I got an error when a try to build a segmentation model using swin transformer as encoder :
x = tf.keras.layers.Input(shape = (224,224,3))
feature = tfdet.model.backbone.swin_transformer_tiny_224_w7_1k(x, weights=None)

I got  AssertionError: input feature has wrong size.
It's the same with various shapes : (256,256,3), (224,224,1) ... etc
Maybe it's a silly question but I'm fairly new to transformers...
What should be input shape for swin backbones ? Or I missed an intermediate layer between input and swin ?

The number of 'Swin Transformer' backbones has been reduced, so please check the details below.
swin_tiny > The recommended image shape is 224.(224, 448, 672, ...)
swin_small > The recommended image shape is 224.(224, 448, 672, ...)
swin_base > The recommended image shape is 224.(224, 448, 672, ...)
swin_v2_tiny > The recommended image shape is 256.(256, 512, 768, ...)
swin_v2_small > The recommended image shape is 256.(256, 512, 768, ...)
swin_v2_base > The recommended image shape is 256.(256, 512, 768, ...)


[Event Request] Codeunit 5802 Inventory Posting To G/L - OnAfterPostInvtBuffUpdateGlobalDimFromDimSetID

Hi Team,
In codeunit 5802 we need possibility to replace and avoid using standard code. Having event in procedure PostInvtPostBuf, would be a perfect solution :

[IntegrationEvent(false, false)]
local procedure OnAfterPostInvtBuffUpdateGlobalDimFromDimSetID(var GenJnlLine: Record "Gen. Journal Line")

Can't you use the existing events: OnPostInvtPostBufOnBeforeSetAmt, OnBeforePostInvtPostBuf, OnBeforeCheckInvtPostBuf?

Hi @StanPesotskiy , after OnPostInvtPostBufOnBeforeSetAmt publisher, GenJnlLine dimension set ID is overwritten from record GlobalInvtPostBuf, so this event does not suit us, unless it would have IsHandled param with extra params needed to execute whole block.
OnBeforePostInvtPostBuf and OnBeforeCheckInvtPostBuf events are within two booleans CalledFromTestReport and RunOnlyCheck, in bad scenario, code might be not executed.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


MAINT: Fix prevention of zero division

Codecov Report

Merging #359 (c849c1c) into develop (7f2d979) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #359   +/-   ##
========================================
  Coverage    99.87%   99.87%
========================================
  Files           46       46
  Lines         1653     1653
========================================
  Hits          1651     1651
  Misses           2        2

Impacted Files
Coverage Δ

pfhedge/stochastic/cir.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2d979...c849c1c. Read the comment docs.


dom-if (in restamp mode) should not forward changes as soon as if gets false

A completely idiotic example can be found here: http://jsbin.com/tifuciyawo/edit?html,console
B/c of the debounced render, the stamped instance usually gets notified about all changes that happen in the current microtask even if the instance will teardown at the end of the microtask as a result of render.
Low hanging fruit:
_forwardParentProp: function (prop, value) {
  if (this.restamp && !this.if) { return; }
  ...
},
_forwardParentPath: function (path, value) {
  if (this.restamp && !this.if) { return; }
  ...
}

Additionally the effects should be sorted so that child templates (or: effects pointing to a _parent_...) are applied at the end.

Considering this blocked on https://github.com/Polymer/polymer/issues/3343 per comments on https://github.com/Polymer/polymer/pull/3355#issuecomment-179599682


Error if index leads with wildcard

Issue
I created dual wildcard-ed index, by having a prefix, and a suffix, ie; client1-sales-09-18, but when I put the index into a rule, it causes the rule to error out because it doesn't like the *-sales-*.
Possible Solutions
if I wrap the value for index in quotes will it force yml to interpret the first wildcard as a string?
Feature request?

Fixed by wrapping value in quotes.


Invalid iframe port in Livebook 12.0 - http://localhost:0/iframe/v5.html

Environment

Elixir & Erlang/OTP versions (elixir --version):

Erlang/OTP 26 [erts-14.1.1] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1] [jit]
Elixir 1.15.7 (compiled with Erlang/OTP 24)

Operating system: macOS 14.1.1 (23B81)
How have you started Livebook (mix phx.server, livebook CLI, Docker, etc):  Desktop App
Livebook version (use git rev-parse HEAD if running with mix):
Browsers that reproduce this bug (the more the merrier): safari, firefox
Include what is logged in the browser console:

GET /iframe/v5.html undefined
Host: localhost:0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:122.0) Gecko/20100101 Firefox/122.0
Accept: */*
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate, br
Referer: http://localhost:55284/
Origin: http://localhost:55284

  Uncaught (in promise) TypeError: NetworkError when attempting to fetch resource.
    TCe http://localhost:55284/assets/app.js:656
    Qte http://localhost:55284/assets/app.js:656
    loadIframe http://localhost:55284/assets/app.js:656
    mounted http://localhost:55284/assets/app.js:656
    promise callback*mounted http://localhost:55284/assets/app.js:656
    __mounted http://localhost:55284/assets/app.js:160
    maybeAddNewHook http://localhost:55284/assets/app.js:160
    performPatch http://localhost:55284/assets/app.js:160
    trackAfter http://localhost:55284/assets/app.js:159
    trackAfter http://localhost:55284/assets/app.js:159
    perform http://localhost:55284/assets/app.js:159
    perform http://localhost:55284/assets/app.js:159
    performPatch http://localhost:55284/assets/app.js:160
    applyJoinPatch http://localhost:55284/assets/app.js:160
    onJoinComplete http://localhost:55284/assets/app.js:160
    onJoin http://localhost:55284/assets/app.js:160
    applyDiff http://localhost:55284/assets/app.js:160
    onJoin http://localhost:55284/assets/app.js:160
    join http://localhost:55284/assets/app.js:160
    after http://localhost:55284/assets/app.js:166
    requestDOMUpdate http://localhost:55284/assets/app.js:166
    join http://localhost:55284/assets/app.js:160
    matchReceive http://localhost:55284/assets/app.js:152
    matchReceive http://localhost:55284/assets/app.js:152
    startTimeout http://localhost:55284/assets/app.js:152
    trigger http://localhost:55284/assets/app.js:152
    Lre http://localhost:55284/assets/app.js:152
    trigger http://localhost:55284/assets/app.js:152
    onConnMessage http://localhost:55284/assets/app.js:153
    decode http://localhost:55284/assets/app.js:153
    onConnMessage http://localhost:55284/assets/app.js:153
    onmessage http://localhost:55284/assets/app.js:153
    connect http://localhost:55284/assets/app.js:153
    i http://localhost:55284/assets/app.js:166
    connect http://localhost:55284/assets/app.js:166
    WCe http://localhost:55284/assets/app.js:657
    <anonymous> http://localhost:55284/assets/app.js:657
app.js:656:10614

Include what is logged to the server console: No errors.

Current behavior
I have upgraded to livebook v0.12.0 and kino_explorer data frames stopped rendering. I have disabled all extensions and checked network settings and tried again. I see that iframe port is being set to 0.
I tried same trying to render vega lite and it failed as expected.
The same works with livebook v0.11.4
Expected behavior
Output cells render without any issue

https://github.com/livebook-dev/livebook/blob/ece00ad70c9553853590234c209a1fc19615e5a7/lib/livebook/utils.ex#L626-L635
@josevalim endpoint.server_info/1 is undefined, because the endpoint is not a Phoenix endpoint, but just a Plug module. But looking at 4c7259688db20b58a55c20707c4490d51797e2ff, Bandit.PhoenixAdapter.bandit_pid doesn't seem to work either for the same reason.

Apologies. I have pushed a fix to main. We will need to do a new release, because I believe this fully breaks the desktop app. :S

Thanks, I will do a release later today!

Just curious as to why this was not caught in CI  tests -  inadequate tests or something else ?

We don't have tests for booting with port 0, unfortunately. To do so, I am suspecting we would need to have a duplicate test suite for testing the different boot options. Perhaps it is worth doing separately.


User Story 1 - Emergency Rescue

Problem description
Add the first User Story for Region User Count
User Story 1 - Emergency Rescue
As an emergency rescue worker, I hope to be able to obtain the number of users in a certain area through an API, so as to quickly understand the population density in the area and guide the rescue work in emergency situations.
Background
In the event of a disaster or emergency, understanding the population size and density within the affected area is crucial for timely scheduling of rescue operations. Therefore, we need an interface to obtain this information.
User requirements:
1.I hope to obtain the number of users in the area by providing coordinates or boundary information.
2.I need the information returned by the API to include the total number and distribution of users in that area.
3.I hope the response time of the API is very short, so that information can be quickly obtained in emergency situations.
Acceptance criteria
1.I can provide the coordinates or boundary information of the area by calling the API, and successfully obtain the number of users in that area.
2.The information returned by the API includes the total number and distribution of users.
3.The response time of the API should be within a few seconds to meet the needs of emergency rescue.
Remarks
1.This API can be implemented through the operator's data platform or relevant location service providers.
2.In practical use, it is necessary to ensure user privacy and data security, and ensure that user information is not abused.

LGTM. If there is no other comment, we can initialize a pr to put in the docs.

If the goal is "to quickly understand the population density in the area" why do not use Population Density API for that?
UC does cover how emergency rescue worker will estimate population density based on device number. How should they estimate population without a connected devices?

Acceptance criteria says that API provides number of users. However, we have agreed that API will expose number of connected devices.

PplDensity API expose population estimation, not number of devices.
Still, my concern here is: an API which exposes number of connected devices does not meet requirements of the UC description as this is done above. Therefore, UC description needs some adjustment. Or API must be redesigned to really expose number of users (where a single user can have multiple connected devices on them).

Suggestion for the UC:
User Story 1 - Emergency Rescue
As an emergency rescue worker, I hope to be able to obtain the number of users in an area where a special emergency activities could be needed through an API, so as to quickly understand the situation, plan and guide the rescue work.
Background
In the event of a disaster or emergency, understanding the population within the affected area is crucial for timely scheduling of rescue operations. Therefore, we need an interface to obtain this information.
User requirements:
1.I hope to obtain the number of connected devices on people in the area by providing coordinates or boundary information.
2.I need the information returned by the API to include the total number and distribution of the devices in that area.
3.I need the response time of the API is very short, so that information can be quickly obtained in emergency situations.
4. I need a reliable factual information only, if/how to estimate and handle population which does not have connected devices on them is my task (depends on the area and situation).
Acceptance criteria
1.I can provide the coordinates or boundary information of the area by calling the API, and successfully obtain the number of connected devices on people in that area.
2.The information returned by the API includes the total number and distribution of the devices (using a grid).
3.The response time of the API should be within a few seconds to meet the needs of emergency rescue.

Thanks, @gregory1g LGTM

Thank a lot!
@gregory1g
This description is more in line with the functionality of this API. If there are no other modification suggestions, I will make the changes and put it in the document. Another question is whether the community has requirements for the format of user stories, and whether the format of QOD's user story is standard

There is some reference. But I think there is no requirements on that. Only if we elaborate it clear.

There is some reference. But I think there is no requirements on that. Only if we elaborate it clear.

Thanks:)

User Story has been added:
PR is here: add User Story


[Question]: initial promt for bot

Describe your problem
If you have found where the starting instructions for the bot are in one of the scripts, please provide a link. I've searched the whole database and can't understand where this promt comes from: "You are an intelligent assistant. Please summarize the content of the knowledge base to answer the question."
Thanks

https://github.com/infiniflow/ragflow/blob/944776f207fb9c5711f3911f31805130c0d70971/web/src/locales/en.ts#L307

!!!Thanx


fix: update ChaosEngine crd manifest file in graphql server

Proposed changes
Currently, the litmus-graphql-server uses an old CRD manifest file. So when you execute the experiment in Litmus version 3.0.0-beta12, you can see the error logs below.
{"mainLogs":"W1003 08:59:55.273647       1 client_config.go:552] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.\n2023/10/03 08:59:55 Error Creating Resource : ChaosEngine.litmuschaos.io 'pod-network-loss-h6srhrls' is invalid: [spec.experiments[0].spec.probe[0].runProperties.interval: Invalid value: 'string': spec.experiments[0].spec.probe[0].runProperties.interval in body must be of type integer: 'string', spec.experiments[0].spec.probe[0].runProperties.probeTimeout: Invalid value: 'string': spec.experiments[0].spec.probe[0].runProperties.probeTimeout in body must be of type integer: 'string']\n"}
In this PR, I updated ChaosEngine manifest file.
I used this file (https://github.com/litmuschaos/chaos-operator/blob/master/deploy/crds/chaosengine_crd.yaml)
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[x] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the commit for DCO to be passed.
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@namkyu1999 did you try applying this crd: https://github.com/litmuschaos/litmus/blob/master/mkdocs/docs/3.0.0-beta12/litmus-portal-crds-3.0.0-beta12.yml ?

@namkyu1999 did you try applying this crd: https://github.com/litmuschaos/litmus/blob/master/mkdocs/docs/3.0.0-beta12/litmus-portal-crds-3.0.0-beta12.yml ?

Hi @Saranya-jena, As you said, if we apply that crd file to all target clusters, it works fine, because once the crd is defined, even if we update to an old manifest in the future, the crd won't change. But if we download the control plane and don't download the crd as you should, the graphql server will create a manifest using the old crd file, so we need that pr.

Some variable types changed in this pr https://github.com/litmuschaos/chaos-operator/pull/459. But the crd version not changed. So anyone who already applied old version of ChaosEngine CRD will face the same problem.


Allow for subfolders in templates dir

easy enough to read them.
but should they display as folders? or just a flat list? or maybe just a list with categories:
HTML=====

html thing one
html thing two
Python=====
python thing one
python thing two
Ruby======
ruby thing one

still on the fence about this one. adds a lot of complexity, both in terms of code and ui. could make the tool more complex to use and manage.

closing for now. putting another note for later.


Fixes disk size misreporting for some disks

Needs bz
(Resource details view) Some disks total size was being misreported in the tooltip.
before

after

cc @nachandr 🙇 ❤ 🎿


Do not force MUI to require new typography variants

Applications, rather than mui-datatables, ought to be the ones
responsible for setting whether or not to use the new typography
variants. The flag does not need to be enabled in order to use the new
variants. The flag mainly controls whether or not MUI will warn about
the usage of deprecated variants so applications can ensure they have
completely migrated away completely.
Resolves #398

Coverage decreased (-0.01%) to 72.355% when pulling a76dd75b482e6351542ea06a7b089d7f5718e03e on mpareja:no-variant-global into 671461ca92d45ebe41f33a077cf43a9225fb1b70 on gregnb:master.


Workflow fails when using PVC

I observed a bug that makes a workflow to instantaneously fail upon starting when it uses a PVC. The logs on the associated pod show no error and the output of the node(s) show what they are supposed to show. So in short the workflow works but Argo reports an error.
Here is the failing workflow:
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: volumes-pvc-
spec:
  entrypoint: generate-message
  serviceAccountName: workflow

  volumeClaimTemplates:
    - metadata:
        name: workdir
      spec:
        accessModes: ["ReadWriteOnce"]
        resources:
          requests:
            storage: 100Mi

  templates:
    - name: generate-message
      script:
        image: docker/whalesay:latest
        command: [sh]
        source: |
          echo generating message in volume
          mkdir -p /mnt/vol
          cowsay hello world | tee /mnt/vol/hello_world.txt
        volumeMounts:
          - name: workdir
            mountPath: /mnt/vol

Here is a similar one that works:
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: volumes-pvc-
spec:
  entrypoint: generate-message
  serviceAccountName: workflow

  # volumeClaimTemplates:
  #   - metadata:
  #       name: workdir
  #     spec:
  #       accessModes: ["ReadWriteOnce"]
  #       resources:
  #         requests:
  #           storage: 100Mi

  templates:
    - name: generate-message
      script:
        image: docker/whalesay:latest
        command: [sh]
        source: |
          echo generating message in volume
          mkdir -p /mnt/vol
          cowsay hello world | tee /mnt/vol/hello_world.txt
        # volumeMounts:
        #   - name: workdir
        #     mountPath: /mnt/vol

I am on GKE and use the following storage class provisioner: pd.csi.storage.gke.io.
This has been tested on 2.8.1, 2.8.2, 2.9.0-rc2 and 2.9.0-rc3.

In case this is useful for someone, the bug is due to running workflow-controller with a replica value of 3. Only a value of 1 makes it work in my case. argo-server can have 3 replicas without issue.
@alexec : couple of questions about this

does that make any sense to use more than one replica for argo-server and/or workflow-controller?
is that a know limitation that only one replica is allowed for workflow-controller? Since it's a Deployment I would have excepted to not be an issue.

https://github.com/argoproj/argo/blob/master/docs/scaling.md#horizontally-scaling

Sorry for that, I should have been more careful reading the doc! Thanks.


"Partition boost" the group by queries in MSQ for better splits

Description
In MSQ, each partition corresponds to a single segment (if it is the end stage) or the unit of work that is assigned to a worker. If the clustering key has low cardinality, then the returned partitions can be too large. For certain stages, we can break up the resulting partitions by introducing a synthetic clustering column "__boost" (which should contain a unique value - incrementally increasing longs for MSQ's implementation) at the end of the clustering keys, so that the keys become unique, and the partition boundaries are respectable. This is done in ScanQueryKit, and can be done in the GroupByPostShuffleFrameProcessor.
This PR introduces this partition boosting to the group by queries as well.
For example, the queries of the form
INSERT INTO table
SELECT dim1, dim2, agg(metric1) as aggregated FROM EXTERN(...)
GROUP BY dim1, dim2
PARTITIONED BY YEAR
CLUSTERED BY aggregated

can run into large segments if the "aggregated" is a very low cardinality column, and the (dim1, dim2) is a high cardinality pair. The solution (before the patch) would be to add more dims into the CLUSTERED BY clause to make it more unique. Post this patch, that won't be required.
ControllerImpl already handles partition-boosted columns specially.
NOTE: Group by queries can fail during the cluster upgrade, if some of the workers are on an older version, while the others are on a newer version.
Release note

Key changed/added classes in this PR

MyFoo
OurBar
TheirBaz

This PR has:

[ ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

We do not want the boosted column as part of the segment.

This is the job of the controller to remove the boosted column. Also, we have pre-existing MSQInsertTests, which assert on the expected row and the row signature of the segment. The boosted column doesn't show up there.

I have also removed the conditional in the GroupByFrameProcessor and its factory because depending on the signature passed by the query kit, it will choose to add or ignore the partition boosted column. If the signature has __boost column in it, it will pick the column from the selector factory. Else, it will ignore the virtual column altogether. There's no need for additional conditional in the processor or the factory.

Tested that there's a __boost column at the end of the post-processor factory. Also, I went into the debug mode into the GroupByPostShuffleFrameProcessor and the SegmentGeneratorFrameProcessor and the boost column is present in both places with an incrementing value.

Thanks for the review @cryptoe


FR: 'In file search': Search for an exact phrase

It would be great if you could search for an exact phrase (input surrounded with quotes, for example "I will be there")
Thanks in advance!

Thank you for your FR, @avirosso :)
I agree with your opnion 👍

If there are others who also need it, I will consider it promptly, but I believe it would be an option. At least in my case, the hassle of escaping quotations outweighed the benefits.

Hi @avirosso, I wonder what are the differences between ripgrep mode and what you are looking for?

The 'grep-search' not only requires to install ripgrep - it searches in all notes (or all notes in a directory). The 'in file search' is and should be a simple search only in the current note ...

If so wouldn't the default in-file search of Obsidian works?


Any tutorial to install it?

It works for e 570 top? And how can i install it?

It works for e 570 top? And how can i install it?
I do not know, I can not check because I do not have ThinkPad e570. On E560 work good 10.12-10.14

It works for e 570 top? And how can i install it?

Try this repo


run examples on ci

failing because of the react-native npm package that contains import

I'll merge and will fix the RN issue.


Windows SDK Plans?

I've done some research and can't find anything, but are there any plans for releasing an SDK for Windows?

@atb-brown You may be able to use the sdk that's released today while developing on Windows 10. https://forum.dfinity.org/t/dfx-on-windows-for-beginners/194/4

@gobengo Cool, this looks like a useful resource. I'll give this a shot. Thanks.

Thanks for your interest! This is not quite on-topic here, so I’ll close this and invite you to follow up on the developer forum.