updateScore method it is missing the documentPath

The error in my logs:
Error: Value for argument "documentPath" must point to a document, but was "SEwddLtelv69q8iaYTMj". Your path does not contain an even number of components.
On step 3 where contains the code with the problem:
async function updateScore(playerID, newScore, firestore) {
const playerSnapshot = await firestore.collection("scores")
.where("user", "==", playerID).get();
if (playerSnapshot.size !== 1) {
throw Error(User not found in leaderboard: ${playerID});
}
const player = playerSnapshot.docs[0];
const doc = firestore.doc(player.id);   <===== HERE IS THE PROBLEM
return doc.update({
score: newScore,
});
}
How I fixed it:
Replace the old line with the new line -> const doc = firestore.collection("scores").doc(player.id);
Now the the documentPath is complete!

I faced the same issue. Here is my implementation of the updateScore function:
async function updateScore(playerID, newScore, firestore) {
const playerSnapshot = await firestore.collection("scores")
.where("user", "==", playerID).get();
if (playerSnapshot.size !== 1) {
throw Error(User not found in leaderboard: ${playerID});
}
const player = playerSnapshot.docs[0];
return player.ref.update({
score: newScore,
});
}


Some ideas for future development

I will work on some of these myself, I'm posting here to see if there's additional interest.

Context-specific completion where it makes sense (e.g. tags)
elfeed-search-set-{entry,feed}-title should show the old title,feed
Let people do their own formatting for elfeed-log entries (by exposing a `format' function)
Show db sync status in header or mode-line

Some nice things that can be implemented on top of the existing API and features exposed
by the elfeed DB:

Comments for entries that are saved in the DB. A tag can be used to indicate if an entry
has comments or not. Comments are saved/shown/edited and kept track of as a single entity
per elfeed entry.

Entry archiving via external process (think Chrome -> save complete webpage as). Scenario
being that you're in elfeed-search, hit a key and a customizable external browser will fetch/save
the target post and all its assets under a customizable root directory (say ~/.elfeed/archived/).
A tag can be used to indicate if an entry has been archived or not.

Context-specific completion where it makes sense (e.g. tags)

Oh, good idea! Filter editing could use some work in general. I'm still not sure if I'm happy about the current character classes (e.g. I decided that + and - are a word constituents, so they're traversed/handled just as if they were letters).

elfeed-search-set-{entry,feed}-title should show the old title,feed

Sounds good to me. I don't use that interface much, so it hasn't gotten much attention.

Let people do their own formatting for elfeed-log entries

Sounds fine.

Show db sync status in header or mode-line.

That's a very good idea. I've personally gotten (too) comfortable with tracking that information in my head, but it should somehow be communicated. Maybe the appropriate place is the "CH" modified indicator on the mode-line (which is perhaps what you meant).

Comments for entries that are saved in the DB.

The way I see it, the only change in Elfeed core would be the indicator in the search listing. Comments should be stored as just another item in the meta plist (:comments), and the interface to comments (editing, viewing) would be its own mode and buffer.
It could basically be done as a pure extension, except for the difficultly in making a minor change to the search listing (which currently is either the default, or a wholesale re-implementation via elfeed-search-print-entry-function).

Entry archiving via external process

This has been brought up before. So far I've left it as something to be done as an extension. Though there may be value in leveraging the existing content database (elfeed-ref, elfeed-deref) — except that a locally-mirrored site (ala wget -m) isn't just a hunk of content, but a loose collection of interdependent files.

Re: sync indicator, I'd make it more obvious than reusing the Emacs buffer-modified thingy.
Glad you like the rest of the improvements.
Regarding the last 2 (comments and archiving), I don't think they should be implemented as part of elfeed
itself, I just posted here about them to see if they've come up before and get additional opinions.
 If i was in your shoes, I'd strive to keep it "tight" and not bloat it with extraneous functionality that will
not directly improve things everytime someone uses the application (my personal metric for when to add features). Elfeed is also the first RSS client that I can stand using (and also one I'm willing to spend personal time to extend!) so props for that too.


[Feature] Add easy to approach extension for new voices

Heya!
It would be nice if you could create some configuration file format where others could extend the voice sounds.
For instance having a file like this (pseudo):
class MyArabicVoices {
  side = EAST,
  faction = "CFP_O_IS",
  voices = {
   lowAmmo = "path/to/audiofile",
   wounded = "path/to/audiofile"
  }
}

While it was one of my goals making this mod truly "modular" at start so people could add / have their own sound sets, It is not doable simply because:

mod depends on say3d command to emit sounds.

say3d command requires each sound file defined inside cfgSounds so game can access them fast.

In short, It was the idea when I start. Now you can't get away without recompiling the cfgSounds. Mod both uses methods and pre-defined configs to do what it does to balance performance vs functionality. there is no way to simply replace sound files at this point.

One can script something to the level of almost real-time (we see them with modders, making 'while {true} do' mods which reduce fps to 20 -- cpu don't matter) but performance is important. This mod doesn't detect which side you are on, unless it is necessary. The weight is shared on class definitions and methods, it allows the best performance while allowing never done before possibilities.

Okay I got your point here.
Another questions regarding extending the whole would be if it is possible to add different voices for different factions? Or only EAST vs WEST ?

I think you mean sides;  game has 4 sides total east,west,guerilla and civil.  Mod has sounds for guerilla, west and east. @SceptreOfficial undergone this task and trying to find a new way to make things easier to replace or add new sounds, easier customization. It won't be drag & drop but it will be easier to add new sounds, create your own flavor.

Yes... I'm working on a system that will allow custom sounds on a per faction basis. Currently, the system will require users to make their own cfgSounds config and 'nationality' definitions (using a template).

@SceptreOfficial sounds awesome!  Isn't that beautiful @xetra11 ? release soon...

@the0utsider wow rude

Thanks a heap buddy

Check the github wiki for current information regarding custom nationalities. Closing because of #9


add clique example and new init and start scripts

provide example for using clique consensus
create generic init.sh and start.sh scripts so users can specify consensus and privacy implementation from command line args

This pull is to be merged with the official release


[Unhandled promise rejection: TypeError: undefined is not an object (evaluating 'messages.def')]

Leaving this here for others who might have this issue  (Noticed it when using Laravel, Vitejs and VueJs )
Add: Validator.setMessages('en', en);
import Validator from 'validatorjs';
import en from 'validatorjs/src/lang/en';

Validator.setMessages('en', en);

const validation = new Validator(data, rules);

omg THANK YOU this was driving me ape shit

What happens if you use multi language app?


Feature/5 multiremote support

feature: #5 Multiremote support
Added:

multiremote tests
util functions for getting element and elements

Updated:

arrow functions > function declaration
use this instead of the browser instance
tests

How difficult is it to make this work with multiremote as well:
      it('should verify urlContains method', async () => {
        await browser.url('https://webdriver.io');
        expect(await urlContains('io')).toBe(true);
      });

?

It will not work with a single instance and multiremote either.
Because we have to return a function.
So, this function urlContains('io') returns another function where we have logic.
Maybe you meant to make it urlContains('io')()?
I can check this and if it's undefined, then I'll use the browser instead of this, and in multiremote case, the urlContains('io')() method will return an array of booleans[false, true], and in a single instance, the urlContains('io')() method will return just boolean.

Yeah, in the original issue my example was referring to a single browser instance:
const matrix = await multiremote({ browser1: {...} })
await matrix.browser1.waitUntil(
   titleContains('expected conditions'),
   {
      timeout: 5000,
      timeoutMsg: 'expected title....'
   }
)

but I wonder if we can also allow:
await matrix.waitUntil(
   titleContains('expected conditions'),
   {
      timeout: 5000,
      timeoutMsg: 'expected title....'
   }
)

in which case the conditions need to be fulfilled for all browser instances.

Yeah, in the original issue my example was referring to a single browser instance:
const matrix = await multiremote({ browser1: {...} })
await matrix.browser1.waitUntil(
   titleContains('expected conditions'),
   {
      timeout: 5000,
      timeoutMsg: 'expected title....'
   }
)

but I wonder if we can also allow:
await matrix.waitUntil(
   titleContains('expected conditions'),
   {
      timeout: 5000,
      timeoutMsg: 'expected title....'
   }
)

in which case the conditions need to be fulfilled for all browser instances.

Actually, it works now.
I've just tested the following cases:

      // Passed
      it('should pass for specific instance urlContains method', async () => {
        await browser.url('https://the-internet.herokuapp.com')
        await browserB.url('https://webdriver.io/docs/wdio-wait-for/#api');

        //@ts-ignore
        await browser.browserB.waitUntil(
          titleContains('expected conditions'),
          {
            timeout: 1000,
            timeoutMsg: 'expected title for browser B'
          }
        )
      });

      // Passed
      it('should pass for two instances urlContains method', async () => {
        await browser.url('https://webdriver.io/docs/wdio-wait-for/#api')

        await browser.waitUntil(
          titleContains('expected conditions'),
          {
            timeout: 1000,
            timeoutMsg: 'expected title for two instances'
          }
        )
      });

       // Failed
      it('should fail for two instances urlContains method', async () => {
        await browser.url('https://the-internet.herokuapp.com');
        await browserB.url('https://webdriver.io/docs/wdio-wait-for/#api');

        await browser.waitUntil(
          titleContains('expected conditions'),
          {
            timeout: 1000,
            timeoutMsg: 'expected title for two instances'
          }
        )
      });

Do we need to enhance the tests or do they already cover this?

They cover it, in our tests I do the same, except I don't use the waitUntil method to focus only on our prediction functions.

@elaichenkov to release trigger the Manual NPM Publish action and set Release type to minor and keep NPM tag at latest

@christian-bromann
Thank you!
There were few issues with npm script and github token, which I've fixed and it works now. Published 2.1.0


Refactor how - and -- are handled

In some circles, using a single - means that the next character will be a single-character flag and if there are multiple letters, they should be treated like a list of single-character flags.  If a double dash is used (--) then we should consider the following characters all part of a single flag until a space or = is seen.
Right now, flaggy does not parse differently when it sees a - or --.  This means that single letter flags can not be grouped up.
For example, this command would be parsed with two flags by some parsers:
docker exec -it
However in flaggy, this would be treated as one long flag named it.
I propose that we refactor flaggy with the following logic:

If a single dash (-) is used, then we treat every following character as its own flag
if a double dash (--) is used, then we treat the following as one long flag name

Relevant to #49


Update cache section

Motivation
Documentation snippets for HTTP cache using invalid directory. By default application do not have access to /cache directory. Caching will fail silently.
Common aproach for cache is to use application directory as this space is reserved for the application and it will be removed along with app.
This simple suggestion to documentation will help developers to get cache working out of the box and with the most appropriate folder.
Issue
AppolloHttpCache

Thank you for your contribution


click twice to open folder after start vscode

VSCode Version:  1.3.1
OS Version: Ubuntu 14.04.3 LTS

Steps to Reproduce:

Start Vscode
Click File -> open folder in menu
Select a folder and click OK, but nothing happened.
Click File -> open folder again and select the same folder.
Open folder successfully.

I have installed vscode since version 0.9 and installed every released version until now. But the problem is still existed. I install newest version on another Ubuntu 14.04 but nothing wrong. I tried to reinstalled vscode but it was still existed. What should I do except reinstall my ubuntu system?

Can you check the console for errors? (Help > Toggle Developer Tools)

@Tyriar

Open vscode, log the first error.
Open a folder, log the second error.
Open the same folder agian, the vscode reload and no error

@Tyriar I remove the .config/Code folder and reopen the vscode, then problem resovled. Thank you for your help.
PS: Why I can open it at second time?

@zuoez02 looks like it happened as storage.json was not owned by your user. Removing ~/.config/Code however is essentially clearing all the cache/settings for vscode so it's starting from a clean slate. @bpasero perhaps we could allow opening of folders even if storage.json get s a permission exception?

We already catch this possible error when reading the storage.json and now we are doing the same when writing. The error is printed when verbose logging is enabled.


Second attempt at migrating packages to vcpkg

This is an updated version of #786 that attempts to resolve issues with the installation footprint, specifically the lack of installed headers and libraries for the upstream dependencies of Cesium-Native, as covered in #817.
In order to avoid flooding the installation directory with every single library and header that is part of the upstream dependencies for Cesium-Native, this PR breaks down the packages into 4 groups: public, private, and test.
The public packages are any packages where the headers are used in the installed public headers for Cesium, and therefore need to have both the static library and the headers for the package bundled in the install.  Things like expected-lite and rapidjson fall into this category.
The private packages are any where the headers are not used in the public interface, so they don't need to be installed, but the static library will still need to be installed for the final link step of the consumer application.
The final category, test, is for libraries that are only used by the test code and therefore don't need any install step at all.
Unfortunately, it looks like Abseil, a dependency of s2geometry, distributes an excessive number of distinct static libraries, and I don't really know how that could be trimmed down easily to just what s2 needs (I'm assuming it's a small subset).
This should much more closely match the current installation layout of the main branch.

@kring feel free to ping me if you're struggling with this.  I do have experience with Unreal building as well, so I could try to locally debug some of the problems you're facing.

Thanks @jherico, I really appreciate the offer. It's been a pretty painful process getting it working with Unreal, mostly because Unreal / UnrealBuildTool are so... interesting. I haven't hit any hard blocks, but I have hit lots of small ones. My current hurdle is that UnrealBuildTool has special hard-coded logic for libraries named libssl and libcrypto that causes it to wrap them in --whole-archive at link time on Linux. And that in turn causes linker errors about multiply defined symbols.
I can probably fix this just by renaming those libraries. But that's sort of just kicking the can down the road, because in a packaged built, UE's OpenSSL and cesium-native's are going to get slammed together into the same executable, so we'll probably have linker errors at that point with or without --whole-archive.
A perhaps more robust solution is to define an overlay port for OpenSSL that uses Unreal's implementation directly. That'll be very exciting to try to set up I'm sure. 😁

I think I have the OpenSSL situation pretty well sorted by using an overlay port that grabs UE's OpenSSL instead of building it from the vcpkg registry.
Something else I could use your advice on though @jherico:
I've set up GitHub Actions vcpkg caching in cesium-unreal, following your lead in cesium-native:
https://github.com/CesiumGS/cesium-unreal/blob/f07c2377c775e11c8ac25ecad546e65bcaa7f31b/.github/workflows/buildWindows.yml#L72
This works well and saves a ton of CI time.
But it causes problems when we update one of the several overlay ports that we (unfortunately) need in cesium-unreal. If the previous version is already in the vcpkg directory restored from cache, then vcpkg refuses to install the new version (it says it's already installed). Bumping the version or port-version field in vcpkg.json doesn't seem to help.
The only options that I can see are:

Make sure that the cache key is arranged in such a way that the entire cache is invalidated when an overlay port is updated. This will work, but can cause a fair bit of extra compilation.
Have some kind of complicated system whereby we store hashes of overlay ports with the cache, and explicitly remove any ports (and their dependencies) for which the hash has changed. This would avoid the extra compilation, but would be a good chunk of work to set up.

I vaguely have this notion that vcpkg "manifest mode" could help here, but I don't know if that's actually true.
I'm curious what you think of this, and if you have any advice. Thanks!

I just noticed this PR replaces the fillWithRandomBytes implementation with one that isn't cryptographically secure. We'll have to fix that, either by vcpkg-ifying CSPRNG or by switching to an alternative (like OpenSSL, which we already depend upon).

I just noticed this PR replaces the fillWithRandomBytes implementation with one that isn't cryptographically secure. We'll have to fix that, either by vcpkg-ifying CSPRNG or by switching to an alternative (like OpenSSL, which we already depend upon).

I called this out in the original PR comments.  CSPRNG isn't a great candidate for vcpkg, since it relies on a deprecated API for the Windows version, and I don't really feel like adopting the project to the extent I would have to in order to update it to the new Windows crypto API.
OTOH, directly using OpenSSL would make it a public facing dependency, instead of a private dependency of s2geometry, so we'd have to install the headers as well.
It's probably easiest to use an #ifdef inside the function to create a Win32 version that uses the current Crypto API and a POSIX version using /dev/urandom for all other cases, which is similar to what  CSPRNG does.  Will try to get to that today.

Thanks @jherico! I meant the comment as a reminder for myself, not to assign you a task, but I really appreciate you tackling it!

OTOH, directly using OpenSSL would make it a public facing dependency, instead of a private dependency of s2geometry, so we'd have to install the headers as well.

Are you sure about that? I don't think we'd need the headers, because OpenSSL wouldn't be in the public API anywhere. It would just be an implementation detail of fillWithRandomBytes. It's possible I'm thinking about it wrong, though.

Are you sure about that?

No, @kring  you're right, I wasn't thinking.

I'm going to merge this into a branch in the main repo. Thanks again @jherico!


Search for blocks added by mods

Versions

Minecraft 1.19.2
Minutor 2.19.1

Problem

Searching for block names added by mods makes the "Search" button change to "cancel" but nothing happens and pressing "cancel" does nothing.

Sulution

Allow searching of non-minecraft blocks.

I will look into the button behavior.
To be able to search for modded Blocks (or do anything else with them), you have to add a definition file for that mod.
Only Blocks in a definition file are known to Minutor, all others are just "unkown".

You have to create a definition file matching your mod.
It is just a JSON file with all of your Blocks and has to be added in Minutor.
Explanation is here

You should take vanilla_blocks.json as example and create a yourmod_blocks.json from that.


OpenCover is missing is missing hideskipped setting

Opencover allows hiding skipped modules by providing a `hideskipped parameter. Would be great to add this.
See https://github.com/OpenCover/opencover/wiki/Usage#console-application-usage for details.

I can take this up as my 1st issue.

@devlead @Roemer Please review PR


New version: Min.Min version 1.31.0

Pull request has been created with WinGet Automation 🪟📦🤖
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:


Update German translations in the Checkout

What does this PR do?
This PR updates German translations in the Checkout

resolves #330

:tada: This PR is included in version 4.0.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support client certificates for default backend service (nginx controller)

We currently have a service that uses subdomains to identify client sites, and we'd like to allow the use of CNAME aliases.  Currently traffic is routed to the site via an Ingress resource using the Nginx controller, where the Ingress resource has a client certificate configured.
In order to support CNAMEs, we need all non-matching domains to route to the service, for example, by setting --default-backend-service. However, there's no way to specify a client certificate for the default backend, so the pod rejects any traffic that routes via the default backend service.  These are the annotations we currently use on the Ingress:
  annotations:
    kubernetes.io/tls-acme: "false"
    kubernetes.io/ingress.allow-http: "false"
    kubernetes.io/ingress.class: "nginx"
    ingress.kubernetes.io/auth-tls-secret: "default/cloudflare-origin-pull-ca"
    ingress.kubernetes.io/auth-tls-verify-depth: "1"
    nginx.org/server-snippets: "ssl_verify_client optional;"

Therefore we'd like a way to specify client certificates for the default backend service to support this scenario.

The default backend does not supports annotations. This is because we reference the service (and there is no Ingress rule).
Not sure how we can add support for this.

/remove-help
I don't think this meets the criteria for help wanted. Please add back via /help if I'm incorrect


Feat: is_in method for dask

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[x] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[x] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #
Closes #

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.

thanks for your PR!
usual comment - please check over https://github.com/narwhals-dev/narwhals/pull/782/files, there's a lot of irrelevant changes showing up 😉


Setup AppVeyor so that it does something useful

Overview
Setup AppVeyor to actually build the Windows version of the app.
What is now
AppVeyor is not doing anything useful
What is desired
AppVeyor should build the Windows version of the app and run tests in the Windows environment.

We'll be using Github Actions for that


fix(CX-3803): remove 'remove artist' CTA when unable to remove artist

This PR resolves CX-3803
Description
This PR removes the 'remove artist' CTA when it is not possible to remove the artists
Screenshots

Android
iOS

PR Checklist

[X] I have tested my changes on iOS and Android.
[X] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[X] I have added tests, or my changes don't require any.
[X] I added an app state migration, or my changes do not require one.
[X] I have documented any follow-up work that this PR will require, or it does not require any.
[X] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Remove "remove artist" CTA for collected artist when it's disabled - mrsltun

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

thanks @dariakoko


Re-enable MacOS CI caching

@thomaseizinger to add some reference links here

@thomaseizinger to add some reference links here

This release contains the fix.


Add VTEX to adopters lists

This change:
Adds VTEX to the adopters list

@nicacioliveira please take a look at my comment around the spelling, for all other things, you can either run npm fix:all locally, or we can run this here with a bot

/fix:all


Reference a old error

It's a known issue - as per the link below:
https://github.com/coreybutler/nvm-windows/issues/334#issuecomment-1066032479
During installation, the program says "version 8" of node is installed - but actually it is not; if I install any version of node, like 13.9.0 that still runs on windows 7, it is not recognized in the list. And now, when I install the downloaded version, it cannot be used, as an error is generated, as shown in the images below. The path is the default; no changes were made. Do I need to use an older version?

Does https://github.com/coreybutler/nvm-windows/wiki/Common-Issues#permissions-exit-1-exit-5-access-denied-exit-145 help?


Override enumerate on AutoGraph

This pull request address #30802 issue.

Almost there! Looks like a few lint errors are blocking the pull:
tensorflow/python/autograph/operators/py_builtins_test.py:143: [C0301(line-too-long), ] Line too long (89/80)
tensorflow/python/autograph/operators/py_builtins_test.py:143: [C0326(bad-whitespace), ] Exactly one space required after comma
tensorflow/python/autograph/operators/py_builtins_test.py:143: [C0326(bad-whitespace), ] Exactly one space required after comma
tensorflow/python/autograph/operators/py_builtins_test.py:144: [C0301(line-too-long), ] Line too long (92/80)
tensorflow/python/autograph/operators/py_builtins_test.py:144: [C0326(bad-whitespace), ] Exactly one space required after comma
tensorflow/python/autograph/operators/py_builtins_test.py:144: [C0326(bad-whitespace), ] Exactly one space required after comma
tensorflow/python/autograph/operators/py_builtins_test.py:31: [W0611(unused-import), ] Unused tensor_shape imported from tensorflow.python.framework

@mdanatg Ah, yes! I've fixed it.

merged internally , waiting for auto merge to happen, thank you all

@mdanatg Thank you so much for guiding me on my first pull request ever to a big repository on GitHub.  I want to contribute more! Please let me know if there's anything that I can do to help.

@ilhamfp glad to hear that! Other examples of features worth adding could include adding similar support for zip.
Also, keep an eye out for issues marked with these two tags: "god first issue" and "stat:contributions welcome" - they are good ways to get started.
Cheers,
Dan

@mdanatg Ah, yeah I see. I'm working on it! Expect my PR tomorrow :D
...
Wait, should I open an issue first?
And for the last bit, actually, I've been thinking about that. I've been searching solution for me to get automated email or notification when there's a new "good first issue" and "stat:contributions welcome" label. But so far, I have found nothing. Not even slack have this feature yet. Did you know any solution for this?

@ilhamfp It's ok to open an issue if you wish, and assign yourself to it, but it's not strictly necessary.
Unfortunately I don't know if there's a way to get automated emails on filtered searches. If there is one, I'd like to use it too :)

closing this PR as the changes have been merged by  e496ac8


commented-out ssh-key loading (it wasn't used)

removed Pharo-5 (which Iceberg doesn't support)
Changed Pharo-6 to Pharo-alpha, because stable VM doesn't support
iceberg's git

and yes, using latest it was ok... I was just arguing that use Pharo-alpha to provide a latest vm was not the best choice, IMO.

Fabio has in his plans to split image and vm configuration, but that requires a bit more changes.

Now what I don't understand is why the load fails here, and not in the source repo:
source repo: loading ok, 18 tests ok, 55 tests error ( https://travis-ci.org/peteruhnak/iceberg/jobs/225239554 )
here repo: loading fail #withSqueakLineEndings ( https://travis-ci.org/npasserini/iceberg/jobs/225240382 )

wow... no clue :P


logo design

sir if you need any logo design so please contact with me-<EMAIL_ADDRESS>thank you

This is not the place to do advertizing.


Creation of ListView Component

A listview component should be created. An applied example of component is below.
https://facebook.github.io/react-native/docs/flatlist.html

We did not develop our list view instead we used the existing one.


Fix SMBJ checking existing file or folder behavior.

See https://github.com/wa2c/cifs-documents-provider/commit/85e400d9cfdfd578b69f95b0a916b0cb89b1e8db#commitcomment-134106897 for details
TL;DR: fileExists() and folderExists() throw exception if the path is invalid. Using both functions at the same time for the same path to check the existence of file or directory will throw SMBApiException type exception. If the path is for a file, it can't be for a directory, and vice versa.

@wa2c This video will show the bug I am talking about. And this PR fixes this issue.


[SPARK-8541][PySpark] test the absolute error in approx doctests

A minor change but one which is (presumably) visible on the public api docs webpage.

Can one of the admins verify this patch?

Jenkins, this is ok to test.

Merged build triggered.

Merged build started.

Test build #35497 has started for   PR 6942 at commit fbed000.

Test build #35497 has finished for   PR 6942 at commit fbed000.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class NGram(override val uid: String)
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

LGTM, so I'm going to merge this into master, branch-1.4, and branch-1.3.


Colored terminal output

This PR adds colour to the messages from logger. This PR has been tested on OSX, Window, VS code terminal and Jupyter notebook.

LGTM


Add methods to Tracer for prepending and clearing span lifecycle listeners

Codecov Report

Merging #97 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #97      +/-   ##
===========================================
+ Coverage      98.7%   98.7%   +<.01%
- Complexity     1107    1110       +3
===========================================
  Files            62      62
  Lines          2619    2624       +5
  Branches        374     374
===========================================
+ Hits           2585    2590       +5
  Misses           19      19
  Partials         15      15

Impacted Files
Coverage Δ
Complexity Δ

...s-core/src/main/java/com/nike/wingtips/Tracer.java
98.36% <100%> (+0.03%)
103 <5> (+3)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d42e03...4e3e977. Read the comment docs.


Support installation on Alpine

It would be great to have dart docker images with smaller footprints for use in CI building and testing.

I would also support this request.
In combination with acqueduct and postgresql it would be a fast and lightweight combination for docker.

Side note: The hard part here is probably configuring the Dart-SDK to compile with musl-libc.

I've done some work on making this work.
You can see my notes at the bottom of this page:
https://github.com/bsutton/dshell/wiki/Docker
The problem is that pub get is failing randomly on network requests. I'm guessing it might related to the glibc/musl-libc issue.
The rest of it (at least the bits I've tried) appear to be working.

This would be a very useful feature, the official Dart image is about ~300MB right now while alpine images for other languages (PHP, Node, Python, Ruby) are all around ~25MB.

Any news about that? It's pretty inconvenient even using cache.

In collaboration with @mit-mit and @mraleph, I created a slim image based on scratch called dart-scratch. It's available on Docker Hub at subfuzion/dart-scratch for now.
The image weighs in a 4.97MB (2.05MB compressed on Docker Hub) with only the essential system library support pulled in from Debian Buster (no need for Alpine or dealing with any glibc/musl-libc issues).
You can use the image to build JIT- or AOT-compiled apps in your image. See more at:

GitHub repo
Medium post
Reddit thread

Disclaimer: subfuzion/dart-scratch is not an official Google project. I haven't done a lot of testing so YMMV right now; I'm still iterating on it while I also work on creating a buildpack. At some point I'd like to see image available as an official image with the dart:slim. Feedback is welcome, but if you run into issues, please open them in the repo, not here.

Closing: We now support creating small serving images using the new Docker Official Image for Dart, see the "Using this image" section for how to build that:
https://hub.docker.com/_/dart


Get name Element text

Thanks. This change needs to go elsewhere too. Can you look at #13?

It's times like this I really miss Haskell...

It's times like this I really miss Haskell...

Haha probably too much of a yak shave to write some libvirt bindings for haskell

Awesome, thanks.

Haha probably too much of a yak shave to write some libvirt bindings for haskell

Yeah someone started but it looks incomplete and broken.

Confirmed working for me :+1:


config/v1: add networkResourceGroupName for azure platform

The newtork resources like Virtual Network and Subnets are created currently for each cluster in the cluster's resource group.
To support reusing exisitng Virtual network and Subnets for OpenShift clusters, the cluster uses pre-existing ones in a separate resource group.
networkResourceGroupName is the resource group that contains the Virtual network and subnets for the cluster.
The resource group for network resources is the same as cluster unless specifically specified, therefore, this field is optional.
This is based on work in PR https://github.com/openshift/installer/pull/2441
A consumer of the field is https://github.com/openshift/cloud-credential-operator/pull/122

/cc @sdodson @jhixson74
/assign @mfojtik

/approve

A consumer of the field is openshift/cloud-credential-operator#122

And as you say there, it's consuming the new property to enable the machine API provider to attach a cluster-resource-group machine's network interface to a network-resource-group's subnet.  But couldn't we also handle that by adding the network resource group to the machine provider itself?  Looks like they already have a slot for it.  And then adding a set of resource groups to cred requests?  We'd need to grow a field here.

A consumer of the field is openshift/cloud-credential-operator#122

And as you say there, it's consuming the new property to enable the machine API provider to attach a cluster-resource-group machine's network interface to a network-resource-group's subnet. But couldn't we also handle that by adding the network resource group to the machine provider itself? Looks like they already have a slot for it. And then adding a set of resource groups to cred requests? We'd need to grow a field here.

the resource groups are dynamic, and the cred requests are static for auditing purposing and therefore we cannot expand the api to include resource group names.

...the cred requests are static for auditing purposing...

... so we move the dynamic things into a different place?  Do we really need the cred requests to be static?  Won't the current composition in openshift/cloud-credential-operator#122 mean that the machine-API operator is requesting create-machine permissions (or whatever) in the network namespace, where it doesn't need them?

...the cred requests are static for auditing purposing...

... so we move the dynamic things into a different place? Do we really need the cred requests to be static?

If they were dynamic, the operators still won't have the network resource group name to request access to them. The operator like machine-api would have to keep tracking the machine objects to keep a list of groups it need to request credential for, which is not as simple or ideal as move them

Won't the current composition in openshift/cloud-credential-operator#122 mean that the machine-API operator is requesting create-machine permissions (or whatever) in the network namespace, where it doesn't need them?

I am not sure what you mean by this.

/approve
I'll leave this with @sdodson
/assign @sdodson

/lgtm


Foreman OS Mirrors

Hello,
Not sure where to get help for this but I have a working Foreman Provisioning Server that is working but every VM I provision, it goes and gets the ISO/install files to the online repos and I'd like to change that so that it gets it from my server. Kinda new at Foreman. Can anyone help me or point me in the right the direction?
Thanks
Joey

This is about the "other" foreman project (http://theforeman.org/), please close this.


[SPARK-15692][SQL]Improves the explain output of several physical plans by displaying embedded logical plan in tree style

What changes were proposed in this pull request?
Improves the explain output of several physical plans by displaying embedded logical plan in tree style
Some physical plan contains a embedded logical plan, for example, cache tableName query maps to:
case class CacheTableCommand(
    tableName: String,
    plan: Option[LogicalPlan],
    isLazy: Boolean)
  extends RunnableCommand

It is easier to read the explain output if we can display the plan in tree style.
Before change:
Everything is messed in one line.
scala> Seq((1,2)).toDF().createOrReplaceTempView("testView")
scala> spark.sql("cache table testView2 select * from testView").explain()
== Physical Plan ==
ExecutedCommand CacheTableCommand testView2, Some('Project [*]
+- 'UnresolvedRelation `testView`, None
), false

After change:
scala> spark.sql("cache table testView2 select * from testView").explain()
== Physical Plan ==
ExecutedCommand
:  +- CacheTableCommand testView2, false
:     :  +- 'Project [*]
:     :     +- 'UnresolvedRelation `testView`, None

How was this patch tested?
Manual test.

Test build #59723 has started for PR 13433 at commit 9693e52.

Test build #59725 has started for PR 13433 at commit 6dac1cf.

This is pretty cool.
(I didn't actually review the pr but only read the description)

Test build #59723 has finished for PR 13433 at commit 9693e52.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #59725 has finished for PR 13433 at commit 6dac1cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59723/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59725/
Test PASSed.

Merged build finished. Test PASSed.

@cloud-fan  updated.

Test build #59749 has started for PR 13433 at commit 7f7741e.

Test build #59750 has started for PR 13433 at commit c9ab285.

Test build #59749 has finished for PR 13433 at commit 7f7741e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59749/
Test PASSed.

Merged build finished. Test PASSed.

Test build #59750 has finished for PR 13433 at commit c9ab285.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59750/
Test PASSed.

Merged build finished. Test PASSed.

Test build #59767 has started for PR 13433 at commit fee1afb.

Test build #59767 has finished for PR 13433 at commit fee1afb.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59767/
Test FAILed.

Test build #59773 has started for PR 13433 at commit c0bdfe2.

Test build #59773 has finished for PR 13433 at commit c0bdfe2.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59773/
Test FAILed.

Test build #59774 has started for PR 13433 at commit 7ba2c12.

LGTM except for two minor issues, and pending Jenkins.

Test build #59784 has started for PR 13433 at commit dea71f7.

Test build #59787 has started for PR 13433 at commit 7860982.

LGTM, pending jenkins

Test build #59774 has finished for PR 13433 at commit 7ba2c12.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59774/
Test PASSed.

merging to master and 2.0!

Test build #59784 has finished for PR 13433 at commit dea71f7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59784/
Test PASSed.

Test build #59787 has finished for PR 13433 at commit 7860982.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59787/
Test PASSed.


Test adc support temperature sensor stm32 mcu

The goal is to test the junction temperature sensor and the
vref int property in the ADC device-tree node of each stm32 where it is
available.
Check all the ADC of the stm32 mcus where the temp and VrefInt monitoring
is available (based on the Ref Man).
Check that has-temp-channel; and has-vref-channel; in the corresponding
ADC node of the DTS of each stm32 mcu is correctly set.
Verify the VTEMP/ VREFINT activation in the in adc_stm32.c for example).
It is necessary to add and activate the node die-temp in the boards dts files.
Execute the testcase running the samples/sensor/stm32_temp_sensor on
each available target board.

Nice. I made a PR making one of these changes.

@ABOSTM please revisit

@TDhaouST please rebase


Source Codee for Feed page

Added Files:
Images/FeedPage/
Images/network.jpg
Images/redo.png
Images/undraw_buffer_wq43.svg
Layouts/FeedPage.html
Scripts/scroll-animation.js
Styles/feed.css
Modified Files:
Layouts/TeamPage.html
Styles/media-queries.css
index.html

3 Column Layout (Min Width : 992px) (1368 X 768)=>

Hover Effect =>

Fading Effect (while scrolling)=>

2 column Layout (Min Width: 575px) (843 X 768)=>

1 Column Layout (414 X 736) =>

@saumyasingh203 Kindly review the PR.

Great job, looks perfect!

Thanks @saumyasingh203 .
Also could you please tell me if we can create our own issues now to make certain additions and add more features to the existing site?

Great job, looks perfect!

Thanks @saumyasingh203 .
Also could you please tell me if we can create our own issues now to make certain additions and add more features to the existing site?

Yes of course that'd be great! You guys can also add each other too as reviewers apart from me and merge the PR yourself, you'll get some insight about being a maintainer plus the code will be reviewed regularly.
I'll be busy with my intern from now on so I think ^this will work out for the best 💯 Ping me if you across any problems.


Fix revert_latest_[67] GitLab jobs

What does this PR do?
Fix revert_latest_[67] GitLab jobs.
Motivation
We don’t publish arch-specific mono-arch images in datadog/agent-amd64 and datadog/agent-arm64 anymore. Or at least, those images are not tagged anymore. They are only referenced by the multi-arch datadog/agent image.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

I tested the change of IMG_SOURCES by running the revert_latest_[67] jobs on this “test” commit: https://github.com/DataDog/datadog-agent/pull/12554/commits/cc81a2d81da51250725fe1829e1e1669a2ee0f78
And we can validate the that the agent-dev:lenaic-* images properly have all the architecture that are in the 7.36.1 ones: https://hub.docker.com/repository/registry-1.docker.io/datadog/agent-dev/tags?page=1&ordering=last_updated&name=lenaic-


Add pagination to the apis

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
The API as well as the frontend should show all Prompts, Agents, Documents and Tools
Current behaviour
The prompt API currently only returns 16 items. After that, the last added prompt gets shown as the oldest one in the UI and the one before that disappears. Also the API only returns 16.
I think the same is the case for other APIs. ,
Steps to reproduce

Go to the Dashborad
Create 16+ Agents, prompts, documents or tools
The oldest item gets replaced with the newest one.

Possible solution
The API probably doesn't have pagination and only returns 16 elements.
Which Operating Systems are you using?

[ ] Android
[X] iPhone/iPad
[ ] Linux
[X] macOS
[ ] Windows

Acknowledgements

[X] My issue title is concise, descriptive.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of superagent.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

haven't had this issue anymore. I will monitor but close the issue for now


[WIP] Implement store state cache in ~/.kubicorn for #310

First part is to just save the state in ~/.kubicorn. I think this should work for what was wanted in that issue (#310). Haven't implemented for the json as am looking for feedback first.

Not sure about importing go-homedir... should I use the expandPath function instead? If so, how do I "bring" it to fs/impl.go? Looks like apply.go gets it from create.go but I'm not sure how.
Should I implement any further logic in terms of when/how the state is cached?

Going forward I'll work with the ReadCachedState function to get the functionality that was envisioned as kubicorn apply !! -- since as was pointed out !! would be expanded to whatever was previously run in the shell, I'll try to use kubicorn apply last-known-state or kubicorn apply --last-known-state instead.

This could work, looks good for now.
About go-homedir.. I believe there's no need to vendor/use it. We should have functions doing so. At least, I'm sure we have it in cmd/env.go. If you need it, you can move it to cutil (make sure it doesn't exist there before moving).
Using the flag (--last-known-state) would be much better idea instead of kubicorn apply last-known-state. I don't believe somebody will use last-known-state as the name, but well.. we never know that. :D

Closing as this is an older PR - please re-open if you'd like us to take another look! Thank you! <3


Can't get translations to work.

Hi,
I've got the latest ttkbootstrap from github today:
pip3 install git+https://github.com/israel-dryer/ttkbootstrap
then I cloned the repository:
git clone https://github.com/israel-dryer/ttkbootstrap
All examples work, but the translations. I tried the tests, and I could not get tableview or any dialog to be translated. I am using ubuntu linux:
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.3 LTS
Release:        20.04
Codename:       focal
Is there any specific command I need to choose the language? How do I know if ttkbootstrap is loading the correct the translation file? In my case it should be 'pt_br'.
EDIT: tried on python3.8.4
Thanks for your time.

What value do you get if you run the MessageCatalog.locale() command?

What value do you get if you run the MessageCatalog.locale() command?

import ttkbootstrap as ttk
from ttkbootstrap.dialogs import Querybox, Messagebox
from ttkbootstrap.icons import Icon
import tkinter as tk
from ttkbootstrap.localization import MessageCatalog
from ttkbootstrap import localization
localization.initialize_localities()
MessageCatalog.locale('pt_br')
Messagebox.yesnocancel("Messagebox.yesnocancel")
print("My locale:", MessageCatalog.locale())
---------------- console output after pressing "yes" ---------
My locale: pt_br
---------------- screen output ----------------------

If I remove: MessageCatalog.locale('pt_br')
I still get "My locale: pt_br"

What locale is returned from the MessageCatalog.locale() method with no parameters. I'm wondering what native locale is recognized by tkinter.

Take the following test.
download the repository zip file
https://codeload.github.com/israel-dryer/ttkbootstrap/zip/refs/heads/master
extract the contents of the zip file folder
/ttkbootstrap-master/src/ttkbootstrap/
to the python modules folder. In my case python 3.8
/home/YOUR_USER_NAME/.local/lib/python3.8/site-packages/ttkbootstrap/
See if the translation has been applied

There seems to be a problem installing via pip
See my test:
I deleted the folder 'ttkbootstrap' and 'ttkbootstrap-1.5.1.dist-info' in the directory:
/home/YOUR_USER_NAME/.local/lib/python3.8/site-packages
and I installed it via pip:
pip3 install git+https://github.com/israel-dryer/ttkbootstrap
see the result of your code, did not apply the translation:

To fix I downloaded the zip file
https://codeload.github.com/israel-dryer/ttkbootstrap/zip/refs/heads/master
and put the contents of the folder:
/ttkbootstrap-master/src/ttkbootstrap/
in the directory:
/home/YOUR_USER_NAME/.local/lib/python3.8/site-packages/ttkbootstrap/
see the result of your code, here applied the translation:

I wonder if it's using the cached version of ttkbootstrap on the local machine?

See the files downloaded and installed via pip (ttkbootstrap-1.5.1).
pip3 install git+https://github.com/israel-dryer/ttkbootstrap
There is no msgs folder, so the translation was not applied.
ttkbootstrap_via_pip.zip

@antrrax, @dmalves, you should get the msg files now when installing via github.

I tested it here
via
pip3 install git+https://github.com/israel-dryer/ttkbootstrap
Successfully installed ttkbootstrap-<IP_ADDRESS>
It worked as expected - new version with translated text and colorchooser widget

via:
pip install ttkbootstrap
Successfully installed ttkbootstrap-1.5.1
Old version - no translation and no colorchoser

@antrrax, @dmalves, you should get the msg files now when installing via github.
I installed the latest version using:

pip3 install git+https://github.com/israel-dryer/ttkbootstrap
Translation is working (pt_br.msg is present) on python 3.8.10 as shown bellow

I couldn't get it to work on python 3.9.0, but the reason is another bug:
https://github.com/israel-dryer/ttkbootstrap/issues/172


[FLINK-26358][Runtime / Coordination] Operator maxParallelism is lost during chaining

What is the purpose of the change
FLINK-26358: https://issues.apache.org/jira/browse/FLINK-26358
This pull request fixes the maxParallelism issue in operator chaining
Brief change log

Add chainedMaxParallelism map in StreamJobGraphGenerator to store the max parallelism of each operator chain
Fetch max parallelism from chainedMaxParallelism and config job vertex in createJobVertex
Added unit test for this case

Verifying this change
This change added tests and can be verified as follows:

Unit tests added in StreamingJobGraphGeneratorTest.java

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@flinkbot run azure

Hey @fapaul ,
Thanks so much for your review! Yeah I read the code in loadAndValidateCheckpoint and indeed this would break state compatibility. Sorry I'm new to this code base and may have some noob questions:
Q1. Breaking State Compatibility
If I understand it correctly, this change will break state compatibility in the following case:
CHAIN[Map(maxParallelism: -1) -> Filter(maxParallelism: 300) -> Print(maxParallelism: 01)] -> maxParallelism will be -1

Then if user creates a savepoint, upgrades to a Flink version that includes this change, this application can't start from that savepoint because the max parallelism changes from -1 to 300. And there's a unit test in CheckpointMetadataLoadingTest that covers such case.
However, if we are going to change the max parallelism of chained operators, that condition in loadAndValidateCheckpoint will break anyway right? Since we can't hold two max parallelism values for the same operator
Q2. Adding Tests to Cover Restore Behavior
For adding a test to show the restore behavior, do you think the test case mentioned above is sufficient or we should add a test case to start from the beginning(in DataStream API when we declare map/filter operators)?
transformations -> StreamGraph -> JobGraph(with new maxParallelism for chained operators) -> ExecutionGraph -> Test the restore behavior of this generated ExecutionGraph

Thanks!


sitk.Resample  outputs empty img while trying to adjust direction

Problem:
I am trying to adjust direction of mask to the direction of img, using sitk.Resample
But, this process sometimes will output empty mask with all 0.
No idea why, Can someone help me !!

code :
new = sitk.Cast(sitk.GetImageFromArray(mask_arr), sitk.sitkUInt8)
new.SetOrigin(mask.GetOrigin())
new.SetSpacing(mask.GetSpacing())
new.SetDirection(mask.GetDirection())

transform = sitk.TranslationTransform(3)
interpolator = sitk.sitkNearestNeighbor
default_value = 0
# Resample(Image image1, Image referenceImage, Transform transform,
# itk::simple::InterpolatorEnum interpolator, double defaultPixelValue=0.0,
#                 itk::simple::PixelIDValueEnum outputPixelType) -> Image
resampled = sitk.Resample(mask, img, transform,
                     interpolator, default_value)

print('\noutput:')
print('resampled mask.max: ', sitk.GetArrayFromImage(resampled).max())

output 1, Falied:
## input
img size: (512, 512, 18)
mask size: (512, 512, 18)
img spacing: (0.6953125, 0.6953125, 8.0)
mask spacing: (0.6953125, 0.6953125, 8.0)
img direction: (1.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 1.0)
mask direction: (1.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 1.0)

## now, mask is not empty
mask.max:  1

## after resampling, mask is empty
resampled mask.max:  0

but the same method may success sometime
output 2, Success:
## input
img size: (512, 512, 42)
mask size: (512, 512, 42)
img spacing: (1.0, 1.0, 1.0)
mask spacing: (1.0, 1.0, 1.0)
img direction: (1.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 1.0)
mask direction: (1.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 1.0)

## now, mask is not empty
mask.max:  1

## after resampling, mask is not empty
resampled mask.max:  1

output 3, Success:
## input
img size: (384, 384, 12)
mask size: (384, 384, 12)
img spacing: (0.52083331346512, 0.52083331346512, 2.3999996185302734)
mask spacing: (0.5208333134651184, 0.5208333134651184, 2.399998903274536)
img direction: (1.0, 0.0, 0.0, 0.0, -0.21, 0.97, 0.0, -0.97, -0.21)
mask direction: (1.0, 0.0, 0.0, 0.0, 0.21, 0.97, 0.0, 0.97, -0.21)

## now, mask is not empty
mask.max:  255

## after resampling, mask is not empty
resampled mask.max:  255

Hello @srkeyan,
Based on the information you provided it is hard to understand what is the problem you are encountering. Please create a short code snippet that includes an appropriate image and mask which illustrates the problem.
Also I am surprised by the output3, where the resulting img and resampled mask directions are different while the size and spacing is the same. The Resample filter creates a grid based on the image and then resamples the mask onto that grid, so the grid settings for the resampled mask and the image should be the same (origin, size, spacing, direction).

Hello, @zivy ,thank you so much for your apply.
I have renewed my question, hope it's more clear now.
The main problem is that resampling sometimes makes mask all empty.

Hello @srkeyan ,
Unfortunately, I still don't understand the issue. The first section of the code creates an image called new  (copy of information from mask_arr) which is not used in later in the resampling code. This whole section can be removed as it has no effect on the resampling. I guess this was not your intent. Please edit the code so that the new image is used.

Closing.  If this is still a problem, please re-open.


Makes departmental account tooltip

Ticket Link
Ticket
Test Checklist

[X] Exhibits Clear Code Structure:
[X] Project Unit Tests Passed:
[X] Project Jasmine Tests Passed:
[X] Executes Expected Functionality:
[ ] Tested For Incorrect/Unexpected Inputs:

The new tooltip will also be needed in the basis.html, exclude.html, include.html, and owners.html.

sounds like we need another ticket
On Fri, May 10, 2024 at 7:03 PM Jordan Wong @.***>
wrote:

The new tooltip will also be needed in the basis.html, exclude.html,
include.html, and owners.html.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/uhawaii-system-its-ti-iam/uh-groupings-ui/pull/937*issuecomment-2105365256__;Iw!!PvDODwlR4mBZyAb0!TKVvgG-XJ-PKXsZbVVjXS_PcNKlkKox0CtyIq51k7r7yQu1wVqAhyq5lQr6PQDHq_3qGbizCUeJkXrqUSf4TGSxhDQ$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACX2CMGCLNGFXKX2ZEC57A3ZBVG5ZAVCNFSM6AAAAABHRKW2QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGM3DKMRVGY__;!!PvDODwlR4mBZyAb0!TKVvgG-XJ-PKXsZbVVjXS_PcNKlkKox0CtyIq51k7r7yQu1wVqAhyq5lQr6PQDHq_3qGbizCUeJkXrqUSf4XJgvuXw$
.
You are receiving this because your review was requested.Message ID:
@.***
com>


Update astranaut version

@rultor release, tag is 0.1.8

@rultor release, tag is 0.1.8

@kniazkov OK, I will release it now. Please check the progress here

@rultor release, tag is 0.1.8

@kniazkov Done! FYI, the full log is here (took me 10min)


feat: config into its own class

Could you just pipe the config to the refactors so that the are all calling refactor_setup with config.  Then get rid of all the references to config?  I promise i'll accept this pr :)
Also stylua

For now, I'm going to close this PR due to inactivity. If you want to reopen later on, please feel free to do so.


test remove; rename vars

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@da2fe15). Click here to learn what that means.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##             master     #533   +/-   ##
=========================================
  Coverage          ?   91.46%
=========================================
  Files             ?       36
  Lines             ?     2835
  Branches          ?        0
=========================================
  Hits              ?     2593
  Misses            ?      242
  Partials          ?        0

Impacted Files
Coverage Δ

tests/test_api_plugins.py
100% <100%> (ø)

vent/api/actions.py
93.1% <81.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2fe15...aabb1fa. Read the comment docs.


Virtual Products - how to no include in shipstation.xml

Figured I'd mark this as an issue here so others can benefit!
So our store, Alarm Grid, has some weird virtual products (our monitoring packages).
Currently I track them using a shipping category (cleverly titled Monitoring) to make sure I don't charge users in our shipping calculator.
But clearly I should not be sending these to shipstation. Any idea on how to easily edit the code to:

not include virtual products in mixed physical/virtual product orders
not send shipments at all to shipstation that contain all virtual products

Hey ehoch,
I am running into this exact same issue! We use Magento and it is sending virtual products to shipstation as well. Did you find a solution?
Thanks!


Add callback to baseliner/forecaster

Could/should we add an onBoundsBreached callback parameter to the baseliner similar to the onOutlierDetected parameter of the outlier detector, which is called whenever the actual value strays outside of the bounds? Might be useful for something. We could have a direction field indicating which way the bounds went as well as any other useful information.

:rocket: Issue was released in v0.1.3 :rocket:

:rocket: Issue was released in v0.1.3 :rocket:


Split EpicsAdapter

There are two usecases for an EpicsAdapter:

Create an IOC that strictly conforms to the PVs of an existing db file so as to directly simulate it. In this case when creating the adapter we should provide the db file and only be able to override records to link them to Python code. We should not be able to create new PVs.
Create an IOC that allows arbitrary PVs to be created and linked to Python code. It should not require a db to be passed into it to function

We should split these into separate adapters

FYI @callumforrester, I think this covers what we discussed, you're effectively working on 2?

The second point on the list has been fixed, so you can now make them without db files. I don't think 1 is really worth doing for the foreseeable, but if it becomes and issue in the future feel free to raise an issue then.


Widget doesn't appear when using bootstrap-datepicker and X-Editable on the same modal dialog

Expected behaviour
I'm using X-Editable plugin too on the same modal, not in the same input field, i expect the bootstrap-datepicker widget to appear when click on a input box
Actual behaviour
The calendar widget of bootstrap-datepicker doesn't not appears completly.
I have used the .noconflict() method too.
Datepicker version used
Latest, tried befor on 1.6.x
Example code
(function ($) {
$.fn.editable.defaults.mode = 'inline';
var datepicker = $.fn.datepicker.noConflict(); // return $.fn.datepicker to previously assigned value
$.fn.bootstrapDP = datepicker;
.....

$('#MyDateBox').bootstrapDP({
    todayBtn: "linked",
    autoclose: true,
    language: 'es'
});

}(jQuery));

It looks like it is kinda working: https://jsfiddle.net/azaret/ohhkhd1t/17/
Tho you'll have issue with mixed css rules.
Unfortunately x-editable is shipped with an outdated version of datepicker.
Not sure what their plan are for the future of x-editable, but we will happily work with @vitalets & co to found a quick solution on this matter.

@MarQuisKnox

Hi, @Azaret what are the correct css rules? Can you give me some guidance while @vitalets corrects the problem? Thanks

Hi, thanks for the report. I plan to remove all bundled plugins a future release. Any required plugins will need to be explicitly loaded. I will try to review this issue this week. Thanks for your patience.

@anibol Few rules are the same. You could try to force the latest rules, for instance by adding body at the start of each rule, but then you'll break the inline date picker. I'm not sure there is an easy way out of this.


Add time series functions?

Hi, I wonder is it possible to add custom time series functions such as rolling mean, rolling std to it? Any example? And how to add custom fitness function too? Thanks

It's not possible at the moment but is certainly something I'd like to include in a future version

Cool! Have u compared the performance of this one to gplearn? Gplearn always generates same features, and not really useful.


Enocde buildid+offset of unknown symbols in the frame

I'll merge this once we're ready with the backend side.


Enable "Find implementations" for TypeScript

See https://github.com/sourcegraph/scip-typescript/pull/136

Done https://github.com/sourcegraph/sourcegraph/pull/35966


NameError: uninitialized constant Zip::File

when I try to read the doc by doing
doc = Docx::Document.open("tmp/document.docx")
I get an error saying "NameError: uninitialized constant Zip::File"
I have gem 'zip' & gem 'rubyzip' both in my gemfile.
What can be the possible cause and solution for this?

Please, remove gem 'zip' from your gemfile, its outdated and out of use.


Enable colour output from .NET CLI

Enable coloured output to the terminal in GitHub Actions for Linux and macOS.

Codecov Report

Merging #427 (c2d6083) into main (e24be46) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #427   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           16        16
  Lines          699       699
=========================================
  Hits           699       699

Flag
Coverage Δ

linux
100.00% <ø> (ø)

macos
?

windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24be46...c2d6083. Read the comment docs.


Security Key Sign-in for third party VPNs

[Enter feedback here]
Hi all,
we are starting supporting customers on implementing third party VPN appliances log on using Azure Ad accounts.
The reference document is this one:
https://docs.microsoft.com/en-us/azure/active-directory/manage-apps/secure-hybrid-access#sha-through-vpn-and-sdp-applications
The actually implemented scenarios are working very well with Modern Authentication and Azure MFA as a second factor.
The actual limit seems that triyng to use a FIDO2 security key is not an available option. The security key sign-in is missing from the modern authentication form, when passing through the third-party VPN client.

Is this feature in roadmap?
Thanks,
Marco

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 639afd75-5ffa-3dc3-a256-19992958cdc9
Version Independent ID: c269dd0f-607a-99a9-162b-b0ad5b186286
Content: Azure AD secure hybrid access
Content Source: articles/active-directory/manage-apps/secure-hybrid-access.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @Gargi-Sinha
Microsoft Alias: gasinh

@MarcoL-Progel
Thanks for your feedback! We will investigate and update as appropriate.

Passwordless security key sign-in is currently in public preview.
For more info on new releases and features, the best place to check is in User Voice, which I see you have already done. (I went in and upvoted your request.)
I have reached out to the product team to check if this can be done now or if there is an ETA for this and will update this post as soon as I have a reply.
(I noticed that this blog also has a post on the topic.)
CC: @Gargi-Sinha

I am closing this out since there is an open feedback request but I will reply on this post if there's an update or workaround provided by the product group.


Add API to help writing integration tests that drive an AppHost project

For authoring integration tests of web projects, we ship Microsoft.AspNetCore.Mvc.Testing which contains the WebApplicationFactory<TEntryPoint> API. To better support authoring integration tests against an Aspire-based app, we should consider adding something like DistributedApplicationFactory<TEndpointPoint>.
I spiked an approach to this in a branch in the samples repo but it required numerous hacks to make work and doesn't address some other issues that arise when using AppHost projects to orchestrate an Aspire app in a testing context. But it ends up enabling authoring a test like so:
namespace ApiService.Tests;

public class ApiServiceTests : IClassFixture<DistributedApplicationFixture<Program>>
{
    private readonly HttpClient _httpClient;

    public ApiServiceTests(DistributedApplicationFixture<Program> appHostFixture)
    {
        _httpClient = appHostFixture.CreateClient("apiservice");
    }

    [Fact]
    public async void WeatherForecast_Returns_200()
    {
        var forecasts = await _httpClient.GetFromJsonAsync<WeatherForecast[]>("weatherforecast");

        Assert.NotNull(forecasts);
        Assert.NotEmpty(forecasts);
    }

    record WeatherForecast(DateOnly Date, int TemperatureC, string? Summary)
    {
        public int TemperatureF => 32 + (int)(TemperatureC / 0.5556);
    }
}

Note that another approach is to use WebApplicationFactory to host the specific project being tested, and have the test itself create a separate DistributedApplication to manage the target app's dependencies. An example of this approach can be seen in the eShop repo. I think this approach is still useful in some scenarios but results in duplication of the AppHost setup in the test itself, along with needing to manually extract configuration information like connection strings as the app under test is not being setup by the AppHost.
While the example shown above is a good start, the application builder and hosting patterns have evolved since WebApplicationFactory was created, and as such we likely want to enable an updated approach that's more aligned with the modern IHostApplicationBuilder pattern used by WebApplicationBuilder, HostApplicationBuilder, DistributedApplicationBuilder, etc., i.e. a two-phase approach involving a builder and then an app, e.g.:
namespace ApiService.Tests;

public class ApiServiceTests
{
    [Fact]
    public async Task WeatherForecast_Returns_200()
    {
        // arrange
        var builder = DistributedApplicationFactory.CreateBuilder<Program>();
        builder.Services.Add(...); // Services can be added to the DAB here but it's probably uncommon
        builder.Environment = "Test"; // Enable easily setting the environment name, maybe default to "Test"?

        await using var app = builder.Build();
        await app.StartAsync(); // Should this start the host *and* wait for DCP startup?

        var client = app.CreateHttpClient("apiservice");

        // act
        var forecasts = await client.GetFromJsonAsync<WeatherForecast[]>("weatherforecast");

        // assert
        Assert.NotNull(forecasts);
        Assert.NotEmpty(forecasts);
    }

    record WeatherForecast(DateOnly Date, int TemperatureC, string? Summary)
    {
        public int TemperatureF => 32 + (int)(TemperatureC / 0.5556);
    }
}

Here's a list of the items we'd likely need to address:

Update DistributedApplicationBuilder to allow for certain options to be configured via the string[] args passed to the AppHost project's Main method. Today these can only be set in code on the DistributedApplicationOptions instance passed to DistributedApplication.CreateBuilder. Anything proposed below that doesn't currently exist on DistributedApplicationOptions should likely be added there too:

The application name, e.g. --application-name. This is used by Aspire.Hosting to find the AppHost assembly upon which a few different things depend, including extracting the path to DCP from the AssemblyMetadata attributes stamped onto the AppHost during build.
Disabling the dashboard, e.g. --disable-dashboard.
A flag that enables randomization of all ports assigned to resource endpoints, e.g. --randomize-endpoint-ports. This is critical to ensure that concurrent tests against the same resources can be executed without port conflicts.
A semi-colon delimited list of resource names to include in the model, e.g. --resource-filter. Resources with names not specified should be removed from the model when built. This enables constraining which resources should run when launching an AppHost. It's the responsibility of the caller to ensure all resources required to satisfy dependencies of the specified resources are included. This is effectively #303 (rudimentary prototype here).

Update DistributedApplication such that pre-startup hooks are no longer managed and executed outside of just before starting the inner IHost but rather integrated there such that starting the inner host executes the hooks appropriately.
Add a new DistributedApplicationFactory.CreateBuilder<TEntryPoint> API to enable configuring and launching an AppHost project from a test. This would be in a new package Aspire.Hosting.Testing. It would use the established HostFactoryResolver pattern to intercept the creation of the internal IHost such that it can be mutated and coordinated as required by the test. Some further details:

It should default to passing the args defined above, i.e. --application-name set to the name of the AppHost project assembly of the TEntryPoint type, --disable-dashboard so that the dashboard isn't launched during test execution, --randomize-endpoint-ports so that resource endpoints don't collide with each other when tests are running concurrently (or tests are running while the project itself is still running from a launch session).
A method to get an HttpClient instance for a specified resource, and optional endpoint name, e.g. CreateHttpClient(string resourceName, string? endpointName = null). This client have its BaseAddress configured to connect to the appropriate HTTP endpoint for the resource and have standard resiliency added
A method to get an allocated endpoint for a specified resource, and optional endpoint name, so that addresses non-http clients can be configured, e.g. GetEndpoint(string resourceName, string? endpointName)
A method to get a connection string for a specified resource, e.g. GetConnectionString(string resourceName)
A method to build the builder and get back an "app", e.g. Build(). Note that DistributedApplication already implements IAsyncDisposable so this method might return a derived type like WrappedDistributedApplication or perhaps the extra functionality detailed here can be added directly to DistributedApplication or as extensions in Aspire.Hosting.Testing.
A method to allow async waiting on the orchestrator to start, rather than just waiting on the IHost itself, e.g. WaitForOrchestrator. Or perhaps the StartAsync method should just default to waiting on the orchestrator instead of the host?
A property/method to get the ApplicationModel of the built AppHost project.
Console logs from running resources should be collected and piped to the test log to aid in diagnosability.
VS test tooling won't attach the debugger to processes launched by DistributedApplication today so we'd likely need to do work there similar to what was done to make launching AppHost projects work well. /Cc @timheuer

I recently set up some tests against an Aspire application. Some background:

There are 3 main ASP.NET Core projects in the application
There is additional ASP.NET Core application running YARP that sits in front of all traffic that is going to the other 3 servers
There are couple of docker containers that are also running that the main server projects talk to
Authentication for incoming traffic is done in the YARP proxy and is using EntraID.

I started just trying to use the app host that we use for regular development in the tests but ended up changing to model used in the eShop application with making multiple WebApplicationFactorys and then having a trimmed down distributed app builder for the containers.
The main decisions that made me use this method were:

Auth - When using EntraID, there is no good way to login to the application in test code. Using the WebApplicationFactory I can modify the ASP.NET host and replace EntraID auth with a test auth service for my testing purposes.
Invoking individual services - Not all tests that we have are testing API endpoints. Using the WebApplicationFactory we can get an IServiceProvider instance from the server we want to test and then invoke individual services in isolation.

There were also some challenges:

When making the proxy in the test, we had to make a custom YARP ForwarderHttpClientFactory that would pass requests through to the HttpClient from the correct WebApplicationFactory since the server has been replaced with the in memory test server (and therefore the normal HTTP requests that YARP does won't work).

Personally I would like to see some of merging of the WebApplicationFactory into the Aspire distributed app model for testing. That we can still get fine grained control over the server projects, while having he ease of setup with Aspire.

Assigning to @ReubenBond

I've created a draft PR with my WIP here: https://github.com/dotnet/aspire/pull/2310

Moved to P5

Fixed by #2310


Add logic for validating gtx physical id on pickup

This adds two fields to the shipment model: gtx_validation and gtx_validation_timestamp.
These fields are updated upon the action: PICK_UP, and gtx_validation values are an enum of NOT_APPLICABLE, VALIDATION_FAILED, or VALIDATED.
If validation fails, the fields are updated but does not affect the flow of the PICK_UP action in any other way.

If we do move the validation check out of the postsave and to a celery task, then the person who performed the action might not realize that the GTX validation failed until retrieving data from the shipment again.

My understanding was we were waiting on @jamesfneyer to speak with @djones0 to determine appropriate path forward for validation

Will be reviewing today

@jamesfneyer recommendation sent

Rebase


close event for inline notification

Is there any event which gets triggered when clicking on the close button of inline kyn-notification ?

Not emits any event yet as it's internal method to close entire notification. @brian-patrick-3  do we need to emit any event while closing inline and toast notification ?

Yeah we'll need to add a close event


Sticky Element does not stick when within a scrollable div

I'm submitting a ...

[ ] bug report
[x ] feature request
[ ] support request

If you're reporting a bug, please provide a minimal demonstration of the problem
When wrapped within an enclosing div with a max height and scrollbar the Sticky components no longer stick.
https://codesandbox.io/embed/react-sticky-sample-project-0yz7t
What is the current behavior?
The sticky component no longer sticks
What is the expected or desired behavior?
The sticky component sticks on scroll
Why do you want this? What use case do you have?
What is your environment?

Version: 75.0.3770.100
Browser: Chrome

Is there anything else I should know?
I believe the issue is that the sticky component does not capture the scroll events of the parent div which creates the scrollable area.  Adding an additional (optional) prop taking in the ref of the parent should allow the component to bind to the parent's scroll event.

I have the same problem

Is it not possible for you to do something like this:
<StickyContainer style={{ maxHeight: "400px", overflowY: "auto" }}>
Basically instead of defining an extra div you use the SectionContainer component which will intern also render a div. You could also append a custom class with className..

you can try my version https://github.com/hb-bobo/react-sticky#getparent-default-undefined


issue of compiling on macOS

Hello! As I was trying to compile SimpleElastix on macOS 10.15 and entering command in terminal as follow:
cmake -DCMAKE_CXX_COMPILER:STRING=/usr/bin/clang++ -DCMAKE_C_COMPILER:STRING=/usr/bin/clang /Users/zhangyuwei/SimpleElastix/SuperBuild
It returned:
Performing Test Weak Link MODULE -> SHARED (gnu_ld_ignore) - Failed
Could you please tell me how can I overcome this issue? thx.

Have tried running make -j4? If not, try to run this command in the build directory after you have run the cmake command. Let me know how it goes!

Have tried running make -j4? If not, try to run this command in the build directory after you have run the cmake command. Let me know how it goes!

Yes! It works. Thanks a lot.


Failures on Flaky CI Pipeline

Was digging into this. But moving back to backlog as I'm going to be OOF.
I could only repro this on the server so I was seeing in tracepoints. Tracepoints seem to indicate that JupyterCommandFinder -> findBestCommandImpl is at fault for the export from guest issue. Seems to be getting back an undefined from getActiveInterpreter and then fails out on this line:
traceInfo(Active interpreter does not support ${command} because of error ${found.error}.Interpreter is ${current ? current.displayName : 'undefined'}.);

Latest failures seem to be only from Linux & Mac (Py 3.5, 3.6 & 3.7).
No failures on Windows.

Closing meta bug in favor of individual bugs.


Change setValue to updateValue until officially deprecated.

It's easy enough to switch this back when we need to. Supporting anything but the final public Angular 2 release shouldn't be a goal but it's good if we can give people more time to upgrade.

LGTM!


"AIRMap" was not found in the UIManager.

Is this a bug report?
Yes and No, as it has been answered in many other Issues, but none of the answers seems to work for me...

Invariant Violation: requireNativeComponent: "AIRMap" was not found in the UIManager.
This error is located at: in AIRMap (at MapView.js:760) in MapView (at Home.js:118)

Have you read the Installation Instructions?
Yes
Environment

"react-native": "^0.57.0-rc.4",
"react-native-maps": "^0.21.0",
Target platform: iOS Simulator: iPhone 6
Steps to Reproduce

I tried this:

rm -rf ios android node_modules
npm install
react-native upgrade
react-native link
libAirMaps.a is added in Build Phases
AirGoogleMaps and AirMaps is added to Frameworks
Followed this guide to add Maps SDK for iOS manually without CocoaPods: https://developers.google.com/maps/documentation/ios-sdk/start
Added @import GoogleMaps; and [GMSServices provideAPIKey:@"YOUR_API_KEY"]; to AppDelegate.m

Expected Behavior
I have not added this to package.json, as I am unsure what path it is asking for? I found this at https://github.com/react-community/react-native-maps/blob/master/docs/installation.md
{
  "name": "your-app",
  "scripts": {
    "postinstall": "./node_modules/react-native-maps/enable-google-maps REPLACE_ME_RELATIVE_PATH_TO_GOOGLE_MAPS_INSTALL"
  }
}

The Map would be displayed. But I get the error no matter what I do.
Actual Behavior

Added this to my component, followed the guides excactly. Also tried creating a new app, but it doesn't work:
import MapView from 'react-native-maps';
<MapView
        initialRegion={{
          latitude: 37.78825,
          longitude: -122.4324,
          latitudeDelta: 0.0922,
          longitudeDelta: 0.0421,
        }}
      />

Reproducible Demo

Working on setting this up.

@vemundeldegard many other issues say to use the github version - did you try?

@vemundeldegard many other issues say to use the github version - did you try?

Isn't the Github version the same as the npm 0.21.0? How can I use the github version istead? sorry for asking stupidly

@vemundeldegard sadly no, there is only one person that is allowed to publish to npm and he's very busy

@vemundeldegard sadly no, there is only one person that is allowed to publish to npm and he's very busy

Ah! I see. So you suggest cloning the Git and adding it manually? How can I do that?

"react-native-maps": "https://github.com/react-community/react-native-maps.git"

No difference sadly:( Can't it be something wrong in the xcodeproject? I don't understand...

did you run react-native link react-native-maps ?

Yes, I did!

pod files?

Vemunds-MacBook-Air:ios vemundeldegard$ pod install
Analyzing dependencies
Fetching podspec for DoubleConversion from ../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec
Fetching podspec for Folly from ../node_modules/react-native/third-party-podspecs/Folly.podspec
Fetching podspec for React from ../node_modules/react-native
Fetching podspec for glog from ../node_modules/react-native/third-party-podspecs/glog.podspec
Fetching podspec for react-native-google-maps from ../node_modules/react-native-maps
Fetching podspec for react-native-maps from ../node_modules/react-native-maps
Fetching podspec for yoga from ../node_modules/react-native/ReactCommon/yoga/yoga.podspec
[!] Unable to find a specification for boost-for-react-native depended upon by Folly
[!] Automatically assigning platform ios with version 9.0 on target AwesomeProject because no platform was specified. Please specify a platform for this target in your Podfile. See https://guides.cocoapods.org/syntax/podfile.html#platform.

Used the Podfile found in the Installation guide...

My issues fixed by using this step

Using "react-native-maps": "https://github.com/react-community/react-native-maps.git" in my package.json and run yarn install

In my android/build.gradle, add:

ext {
    buildToolsVersion = "27.0.3"
    minSdkVersion = 16
    compileSdkVersion = 27
    targetSdkVersion = 26
    supportLibVersion = "27.1.1"
    googlePlayServicesVersion = "15.0.1"
    androidMapsUtilsVersion = "0.5+"
}

May be you must adjust with your project

In android/app/build.grade add compile project(':react-native-maps') in dependencies object

In android/app/src/main/java/com/projectName/MainApplication.java edit in getPackages() function so it look like this

@Override
    protected List<ReactPackage> getPackages() {
      return Arrays.<ReactPackage>asList(
          new MainReactPackage(),
            new MapsPackage()
      );
    }

I fixed my issue by adding this last step. I got the AIRMap error when I forget to adding new MapsPackage() in my MainApplication.java
May be you must adjust with yout ios setting, btw I didn't develop in ios :smile:

@vemundeldegard did you solved your problem?

@adispartadev I try this steps, but I get 'AURMAP' not found error again,

I didn't solve the problem, but I made it work by redoing everything and making a new project. Start from scratch and install everything again. Works good now.

I have the same issue. Clean react native 0.57.1 and tried install maps from npm or git. I am just running react-native link, but I am not sure if I should do both steps iOS - CocoaPods and iOS - ReactNative Link because I do not want google maps for ios.

I temporary switched to Mike Morris version. This only works fine to me at the moment for 0.57.1. Using react-native link.
"react-native-maps": "github:mikemorris/react-native-maps#ef5c839252e427268ae2ebbf4f0cced1cb51fed6"

These steps fixed the issues for me.

Delete the app on the ios simulator (I'm using the simulator).
Delete /ios/build
run 'react-native run-ios'.

@vemundeldegard put this in your package.json
"react-native-maps": "https://github.com/react-community/react-native-maps.git", and run npm install

I've just tried this and still doesn't work, the error is the same "AIRMap was not found"

Still doesn't work for me
"react-native": "0.57.2",
"react-native-maps": "^0.21.0",

I have got this lib working, after completely updating node and yarn to the latest versions. In the end I've used yarn instead npm, so there might be a problem with npm install.

@NTramper @benjaminreid link is implemented in 0.22 so please update your map package.

I solved it by adding the .xcodeproj in node_modules/react-native-maps/lib to Libraries by right clicking and then adding it to link binary with libraries and linked frameworks and libraries.
Shout out to @spearmootz for guiding me on this :D

I love how every issue gets simply closed without solution or help. A simple statement what could be wrong/missing would help. People writing their Android "solution" to an ios OP is also not very helpful and only clutters everything.
 Something missing or clashing. But giving a hint how to validate that everything is linked correctly would be nice.
Something like "downgrade your RN until it works" like many stated is clearly no solution or option whatsoever.
As the podfile in the instructions differs significantly from the default one - and simply replacing it is normally not an option (we have other pods, you know?) - my guess would be people not including all the dependencies correctly. But no one can validate things like that without knowing what is actually needed from the podfile.

Try this before you try anything of the above (I tried a bunch of them and none worked, but they made it more difficult to apply the fix below as I screwed up my project in the process)
I fixed this one by
cd ios
pod install

The instructions are simply unclear on what to do - the implication seems to be one can either use react native link OR install CocoaPods. When in actuality you have to do a pod install at least.
Although it wasn't that simple as I tried many different things, got maps version 0.21 installed, the pod for that doesn't work, so had to install maps v 0.22, then upgrade the pod to 0.22 - and voila, it works!
It's not difficult to fix! The problem is there's poor documentation, and a lot of the steps in this answer are unnecessary. I am guessing they were for version 0.21 and possibly others that actually had an issue with integration.
0.22 works!

For me manually linking in iOS was the solution, as for the android, it works by default.
react-native: 0.57.4
react-native-maps: 0.22.0

For me

My issues fixed by using this step

Using "react-native-maps": "https://github.com/react-community/react-native-maps.git" in my package.json and run yarn install
In my android/build.gradle, add:

ext {
    buildToolsVersion = "27.0.3"
    minSdkVersion = 16
    compileSdkVersion = 27
    targetSdkVersion = 26
    supportLibVersion = "27.1.1"
    googlePlayServicesVersion = "15.0.1"
    androidMapsUtilsVersion = "0.5+"
}

May be you must adjust with your project

In android/app/build.grade add compile project(':react-native-maps') in dependencies object
In android/app/src/main/java/com/projectName/MainApplication.java edit in getPackages() function so it look like this

@Override
    protected List<ReactPackage> getPackages() {
      return Arrays.<ReactPackage>asList(
          new MainReactPackage(),
            new MapsPackage()
      );
    }

I fixed my issue by adding this last step. I got the AIRMap error when I forget to adding new MapsPackage() in my MainApplication.java
May be you must adjust with yout ios setting, btw I didn't develop in ios 😄

This fixed my, I forgot to add new MapsPackage() to getPackages after RNN install. what a painnnnn 🗡

My issues fixed by using this step

Using "react-native-maps": "https://github.com/react-community/react-native-maps.git" in my package.json and run yarn install
In my android/build.gradle, add:

ext {
    buildToolsVersion = "27.0.3"
    minSdkVersion = 16
    compileSdkVersion = 27
    targetSdkVersion = 26
    supportLibVersion = "27.1.1"
    googlePlayServicesVersion = "15.0.1"
    androidMapsUtilsVersion = "0.5+"
}

May be you must adjust with your project

In android/app/build.grade add compile project(':react-native-maps') in dependencies object
In android/app/src/main/java/com/projectName/MainApplication.java edit in getPackages() function so it look like this

@Override
    protected List<ReactPackage> getPackages() {
      return Arrays.<ReactPackage>asList(
          new MainReactPackage(),
            new MapsPackage()
      );
    }

I fixed my issue by adding this last step. I got the AIRMap error when I forget to adding new MapsPackage() in my MainApplication.java
May be you must adjust with yout ios setting, btw I didn't develop in ios 😄

LOL
It worked for me

I tried lot of things and in the end I realised not one answer was enough. So I compiled and write it into an article . I tried my best and hope it will help everyone
https://medium.com/@nayabbutt1/google-maps-in-react-native-ios-application-3e27eece15b4

see https://github.com/react-native-community/react-native-maps/blob/master/docs/installation.md

Where you install react native map, react native keep the old build. You must remote iOS/build and node modules and re-build your application ! In new version builded there are AirMap ! Enjoy

Anyone have fix this issue for RN version 0.60 ?

try this https://github.com/react-native-community/react-native-maps/issues/2495#issuecomment-580953357

@vemundeldegard put this in your package.json
 "react-native-maps": "https://github.com/react-community/react-native-maps.git", and run npm install

why

If you followed all instructions on the react-native-maps properly, the way to fix this issue is simply to uninstall the app from your device / simulator, then re-running it.
This is a general advice when installing new pods.

nothing works for me, anyone can help?
I am working on android version.

This works for me:

npm install react-native-maps@latest --save
react-native link react-native-maps
For IOS
cd ios
pod install
For Android
gradle clean

What worked for me was using yarn instead of npm.
I ran yarn add react-native-maps -E instead of npm install react-native-maps.
The package was missing under node_modules folder, using yarn did the trick.
Then cd ios pod install

What worked for me was using yarn instead of npm.
I ran yarn add react-native-maps -E instead of npm install react-native-maps.
The package was missing under node_modules folder, using yarn did the trick.
Then cd ios pod install

I got the same error but fix it. In android/build.gradle, set minSdkVersion value to 22

try to pod install

For me manually linking in iOS was the solution, as for the android, it works by default. react-native: 0.57.4 react-native-maps: 0.22.0

No it doesn't for me!!


Kitchen Sink: Build A News Aggregator App

Build an app that aggregates news articles from various sources using a news API.that you'll add to the kitchen sink. Feel free to use any existing projects of yours or start one from scratch.
For more information about the Kitchen sink; check out:

https://sink.million.dev/
https://github.com/aidenybai/million/blob/main/packages/kitchen-sink/README.md

N.B: Upon PR review, your usage of Million.js is a plus

@tobySolutions Can you please assign this issue to me?

Sure thing! @sukritmalpani!

Fixed by #646


investigate ways to avoid heap allocations

Right now for the sake of cleaner syntax, there's allocation being done using Box structs to avoid forcing users of snow to specify a ton of ugly generics when they store sessions in their own structs, for example.

It would be an option to use impl Trait. Unfortunately, this does not allow users to store the results in their own structs.
Maybe associated types would help?

@vks I think we'd need impl Trait to extend support for being used in structs, which it currently can't do and I'm not sure what the roadmap is for that.

related to #62

Why is snow doing Box<dyn SomeTrait> everywhere rather than &'a SomeTrait? Is it because the explicit lifetimes would make it harder for snow users?

@isislovecruft yep, it's purely for ergonomic reasons. I'd love to use something like associated traits and maybe a convenience macro to be able to drop the Boxes while keeping roughly the same level of simplicity.

If you want trait objects without heap allocations, one option is an enum with Deref impl whose Target is the desired trait object. Something like this:
enum CipherBackends {
    #[cfg(feature = "backend1")]
    ....
}

impl core::ops::Deref for CipherBackends {
    type Target = dyn Cipher;

    fn deref(&self) -> &(dyn Cipher + 'static) {
        match self {
            #[cfg(feature = "backend1")]
            ....
        }
    }
}

Note that this does have the advantage that the size of CipherBackends will always be as big as the largest of the variants, but hopefully they're roughly the same size.

@tarcieri the reason I didn't choose this method in the original design is because I wanted the option for people to implement their own crypto backends if snow didn't provide any that fit their needs. If it's totally clear that flexibility isn't necessary, we could definitely switch to something like this.

Unfortunately I think you need either Box or a generic type parameter in that case, the former requiring a heap allocation, and the latter defeating the point of using an enum since it can just monomorphize rather than using a trait object.