[Capella] Add method: Withdrawal

Add a method to generate signed data necessary for making an ETH2 withdrawal. This uses the Withdrawal data format.

[ ] Determine what data needs to be signed in order to withdraw
[ ] Determine what data needs to be returned from lattice-eth2-utils in order to withdraw
[ ] Add Withdraw util
[ ] Add corresponding tests

I don't see a reference anywhere about this one. I guess we will probably start seeing more utils closer to the fork release

No BLS signature is required to withdraw, so we don't need to worry about this. Partial withdrawals will be done automatically, while full withdrawals are activated by a voluntary exit.


It is necessary to divide the test cases and tests in the report (TestNG)

It is necessary to divide the test cases and tests in the report, so the report will be visually closer to the ideology of the xUnit and the file structure, run tests TestNG.CML. In the current implementation, test cases and call them tests are mixed together. I suggest the following variant of report (TestNG) tab in the xUnit:

0 level: test cases;
Level 1: tests which were performed in a particular test case;
Level 2: the test methods are invoked in a particular test.

This desire is due to the fact that when running many test cases, the report is very difficult to find and to determine where and what was called in the test case.
Here is an example when it is difficult to understand the report:

Here's an example of what I would like to see, when the structure testng.xml corresponds to the display in the report:

Allure has test steps concept. Do you think that some of your levels map to test steps?

@buzdin I personally like to create a new tab for testNg with such grouping. What are you think?
IMHO separate test methods using steps - bad idea. At least while test case can contains only one failure.

By default when you’re using maven surefire plugin with the default configuration, TestNg is setup as standard xUnit framework. The suite name and test name is generated automatically by surefire plugin.  TestNg is using XML Suite file as an input for execution and orchestration of tests. Some test execution frameworks like Maven surefire or any IDE testNg plugins area generating the TestNG XML Suite file before the test execution and creating an illusion that your test classes are the one which are executed.
But when you provide your own TestNg Xml Suite file you can configure the test to be executed in very different and unpredictable fashion.  To fully implement all the features of TestNg test component hierarchy you have to implement support for the following containers:
•	Suites of suite files
•	Suites of Tests
•	Tests
•	Groups
•	Test cases (methods)
•	Test case invocations  (multiple instance invocation of the same test)
•	and the last one: Allure steps

Done in new TestNG adaptor. https://github.com/allure-framework/allure-java


fix(RpcProvider): update of RpcProvider getBlock method to work with v0.3.0 of pathfinder

with the recent update of pathfinder, some methods have been deleted, making starknet.js not working when using them
e.g. starknet_getBlockByHash and starknet_getBlockByNumber, that are used in getBlock method of RpcProvider
here is an update using starknet_getBlockWithTxHashes instead

I'm going to reopen the pr


cannot import name Reminder

Rasa Core version: 0.8.5
Python version: 3.6.5
Operating system (windows, osx, ...): OSX
Issue: cannot import Reminder
Error output:
  File "/Users/myusername/Code/mybot/actions.py", line 7, in <module>
    from rasa_core.events import Reminder, SlotSet
ImportError: cannot import name 'Reminder'

I installed rasa_core with pip install rasa_core. Bot works fine until I try to add this Reminder functionality.

should be ReminderScheduled
https://github.com/RasaHQ/rasa_core/blob/master/rasa_core/events/__init__.py#L455
I can see that the docs are out of date - would you care to create a PR to fix that?

Sure, is it just s/Reminder/ReminderScheduled ?

yes

This has been fixed in #357


Pkg 3632 update 17.0.6

Destination channel: defaults
Links

PKG-3632

Explanation of changes:
Pull v17.0.6 from conda-forge. Changes (in merge commit) are:

strip .rcX suffixes from installation path
use ninja rather than nmake on windows or make on unix
add check on INSTALL_PREFIX
make sure we use our libcxx rather than compiling one; point to correct C++ stdlib
change maj.min.patch paths to maj only
rebase patches
remove patch checking glibc greater than 2.16
remove patch setting cmake file dir as a cache variable (might have been used for debugging)

Add back in changes our side we want to keep (see commit on that, below):

don't build universal binaries on osx platforms
use our osx sdk versions as a first punt (might need to be upgraded to 11.0/11.1 on x86_64
comment out channel_sources and channel_targets, they're c-f specific
skip s390x
explicitly pin zlib and libxml2 to cbc
add back in our about: changes

other notes:

libcxx doesn't have a run_export so it doesn't matter that this is compiled against the last version of libcxx (hence lack of pinning)

Linter check found the following problems:
Traceback (most recent call last):
  File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/run.py", line 208, in main
    return_code, report = execute_linter(
                          ^^^^^^^^^^^^^^^
  File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/run.py", line 180, in execute_linter
    result = linter.lint(recipes, subdir, variant_config_files, exclusive_config_files, fix_flag)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/__init__.py", line 728, in lint
    msgs = self.lint_file(
           ^^^^^^^^^^^^^^^
  File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/__init__.py", line 834, in lint_file
    self.lint_recipe(
  File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/__init__.py", line 894, in lint_recipe
    res = self.check_instances[check].run(recipe, fix)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/__init__.py", line 294, in run
    self.check_recipe(recipe)
  File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/check_syntax.py", line 41, in check_recipe
    spec = cast(str, ro_parser.get_value(path))
                     ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/linter/lib/python3.12/site-packages/percy/parser/recipe_parser.py", line 983, in get_value
    raise KeyError(f"No value/key found at path {path!r}")
KeyError: "No value/key found at path '/outputs/0/requirements/host/0'"
ERROR conda.cli.main_run:execute(125): conda run conda-lint /tmp/abs_0ezzsmh9zr/clone failed. (See above for error)

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_004tykfymq/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

clone/recipe/meta.yaml:25: patch_must_be_in_build: patch must be in build when source/patches is set.
===== Final Report: =====
1 Error and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_11_kcayst6/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

clone/recipe/meta.yaml:25: patch_must_be_in_build: patch must be in build when source/patches is set.
===== Final Report: =====
1 Error and 1 Warning were found

Same here, please split the conda-forge changes into a separate PR.

separate PR here: https://github.com/AnacondaRecipes/compiler-rt-feedstock/pull/3

@JeanChristopheMorinPerso there's a separate PR with that view here

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_47qd8yve_v/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

clone/recipe/meta.yaml:25: patch_must_be_in_build: patch must be in build when source/patches is set.
===== Final Report: =====
1 Error and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_5580w98xw1/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

clone/recipe/meta.yaml:25: patch_must_be_in_build: patch must be in build when source/patches is set.
===== Final Report: =====
1 Error and 1 Warning were found


Feature Request: Anonymous mailer

RSpec has an anonymous controller which comes in handy to test the "base" controller of other controllers, please see this example:
app/controllers/admin/base_controller.rb
class Admin::BaseController < ApplicationController
  before_action :authenticate_user!
  before_action :admin_required

  layout 'admin'

  private

    def admin_required
      render text: 'Unauthorized', status: :unauthorized unless current_user.admin?
    end
end

spec/controllers/admin/base_controller_spec.rb
require 'rails_helper'

RSpec.describe Admin::BaseController, :type => :controller do
  controller do
    def index
      head :ok
    end
  end

  describe '#index' do
    def do_request
      get :index
    end

    context "as non-admin" do
      before { sign_in create(:user) }

      it 'raises error' do
        do_request
        expect(response).to have_http_status(:unauthorized)
        expect(response).not_to be_success
      end
    end

    context "as admin" do
      before { sign_in create(:user, :with_admin) }

      it 'does not raise error' do
        do_request
        expect(response).to be_success
      end
    end
  end
end

I use a similar structure for my mailers.
My current implementation would need me to add a test to BaseMailer and add a corresponding view for that test method:
# base_mailer.rb
class BaseMailer < ActionMailer::Base
  default from:     'Support<EMAIL_ADDRESS>          reply_to: 'Support<EMAIL_ADDRESS>
  def test
    mail
  end
end

# app/views/base_mailer/test.html.erb

# spec/mailers/base_mailer_spec.rb
RSpec.describe Admin::BaseController, :type => :mailer do
  describe '#test' do
    let(:email) { email_to }

    def email_to
      BaseMailer.test
    end

    it { expect(email).to deliver_from 'Support<EMAIL_ADDRESS>}
    it { expect(email).to reply_to     'Support<EMAIL_ADDRESS>}
  end
end

Anonymous mailer would be: Just create a method in mailer block and does not need to add a test method to BaseMailer and get rid of test view:
app/mailers/base_mailer.rb
class BaseMailer < ActionMailer::Base
  layout 'mailer'

  default from:     'Support<EMAIL_ADDRESS>          reply_to: 'Support<EMAIL_ADDRESS>end

spec/mailers/base_mailer_spec.rb
require 'rails_helper'

RSpec.describe Admin::BaseController, :type => :mailer do
  mailer do # <= Anonymous mailer!
    def test
      mail
    end
  end

  describe '#welcome' do
    let(:email) { email_to }

    def email_to
      mailer.test # <= Anonymous mailer!
    end

    it { expect(email).to deliver_from 'Support<EMAIL_ADDRESS>}
    it { expect(email).to     reply_to 'Support<EMAIL_ADDRESS>}
  end
end

What do you think?
P.S. This mailer testing syntax is from: https://github.com/bmabey/email-spec

@JonRowe Mailers can share functionality through observers and interceptors. Additionally, there is indeed a base mailer - ApplicationMailer.
I'd be 👍  on this feature, however I also agree that using Class.new can be sufficient enough given that shared mailer logic is less common than shared controller logic.


v0.3.23 Problem with current

Discussed in https://github.com/lbbrhzn/ocpp/discussions/233

Originally posted by McFranky December 13, 2021
Since v0.3.23 the current_import sensor is 0A on my ABB Terra AC Wallbox. Before I got the actual current...

In v0.3.24 the problem with no current always exists.

And now, I get no voltage! New Bug

Test Version 0.3.25 on ABB Terra AC
Now the current is to small!

And same by the voltage...

Test v0.3.26 on ABB Terra AC

OK

OK

OK
Super!! Great Job!


Problems with dark colorscheme

What happened?
The molecule is barely visible

F/C=C/F

What did you expect to happen?
The bonds to be white
How can we reproduce it (as minimally and precisely as possible)?
See above
Anything else we need to know?

Plugin version
0.3.0
Obsidian version
1.5.3

I had to activate dark color scheme

Sorry for the confusion and glad that you have found the solution! The newly installed plugin should load the default settings by design. An underlying bug in settings version conversion is uncovered by this issue. Thanks again for reporting this anyway!


Dismiss toast by matching toastIds with regex

Right now, we can dismiss a toast by using toast.dismiss() and providing the toastId.
I propose adding regex matching functionality to toast.dismiss(). This way, we'd be able to pass a regex pattern to toast.dismiss() and it would dismiss all the toasts whose ids match that regex pattern.

This would be very useful!


No logo when starting via .zshrc

General description of bug:

What happened: starting fastfetch in .zshrc produces output without OS icon and colors i.e. same if I were to use --pipe true
running fastfetch once the terminal is running it shows properly
What should happen: it should print the logo and colors
Did it work in an older version:  yes worked on 1.11.3
Where did you get the binary:  AUR, updated via yay
Does this issue still occurs in the latest dev build? not tested

Often helpful information:
Output of fastfetch --version:
$ fastfetch --version
fastfetch 1.12.0 (x86_64)

shell is zsh
$ zsh --version
zsh 5.9 (x86_64-pc-linux-gnu)

terminal terminator or xfce4-terminal
$ terminator -v
terminator 2.1.3

$ xfce4-terminal --version
xfce4-terminal 1.0.4 (Xfce 4.18)

Currently fixed by adding fastfetch --pipe false to my .zshrc

I can't reproduce with both konsole and terminator

We are using isatty to detect if stdout is a tty, which should not be problematic. Can you backup your .zshrc and reproduce the issue with only fastfetch in the file?

Used a blank .zshrc and it worked with just fastfetch
I'm using Powerlevel10k and narrowed it down to the instant prompt feature
if [[ -r "${XDG_CACHE_HOME:-$HOME/.cache}/p10k-instant-prompt-${(%):-%n}.zsh" ]]; then
  source "${XDG_CACHE_HOME:-$HOME/.cache}/p10k-instant-prompt-${(%):-%n}.zsh"
fi

When I comment above lines it works.

Does moving fastfetch before p10k work?

It does work if I move it before the instant prompt call i.e. at the very beginning of my .zshrc


AES vulnerable to timing attacks

http://cr.yp.to/antiforgery/cachetiming-20050414.pdf demonstrates that table lookups are vulnerable to timing attacks and yet that's exactly what https://github.com/openssl/openssl/blob/master/crypto/aes/aes_x86core.c is doing.

See https://github.com/openssl/openssl/blob/master/crypto/aes/aes_x86core.c#L29

There are two essential words that are missing in original message, namely "would" and "if executed", i.e. that's what aes_x86core.c would be doing if executed. But the fact is that it's not executed in supported cases. The issue is discussed in great detail in https://securityblog.redhat.com/2014/07/02/its-all-a-question-of-time-aes-timing-attacks-on-openssl/.

From the link Andy posted:  "In short answer, no"  Closing this issue.


added tests for invalid testset

Depends on https://github.com/LIonWeb-org/lionweb-integration-testing/pull/4

The build seems to fail

I will wait for https://github.com/LIonWeb-org/lionweb-integration-testing/pull/4 to be merged before completing the review. Does this make sense?

Thank you Niko!
I have modified the configuration to create a separate source test for integration test and automatize the download of the integration repo. I now have 14 invalid files not recognized as invalid. I would merge this anyway, and fix those tests as soon as I can


fix sqlite3 backup and put interval sleep to front

Codecov Report
Base: 84.39% // Head: 86.45% // Increases project coverage by +2.05% :tada:

Coverage data is based on head (1c3d6fd) compared to base (0b05b8a).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   84.39%   86.45%   +2.05%
==========================================
  Files           6        6
  Lines         173      155      -18
==========================================
- Hits          146      134      -12
+ Misses         27       21       -6

Impacted Files
Coverage Δ

sql.go
85.71% <83.33%> (+6.22%)
:arrow_up:

schedule.go
80.95% <100.00%> (+1.58%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


HDFS-16952. Support getLinkTarget API in WebHDFS

JIRA: HDFS-16952. Support getLinkTarget API in WebHDFS

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
19m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 38s

trunk passed

+1 :green_heart:
compile
6m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
6m 19s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 19s

trunk passed

+1 :green_heart:
mvnsite
3m  4s

trunk passed

+1 :green_heart:
javadoc
2m 28s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m  4s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 29s

trunk passed

+1 :green_heart:
shadedclient
23m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 42s

the patch passed

+1 :green_heart:
compile
6m 34s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
6m 34s

the patch passed

+1 :green_heart:
compile
6m 15s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
6m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  9s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 1 new + 146 unchanged - 0 fixed = 147 total (was 146)

+1 :green_heart:
mvnsite
2m 47s

the patch passed

+1 :green_heart:
javadoc
2m  1s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 47s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 35s

the patch passed

+1 :green_heart:
shadedclient
23m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 20s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
223m 37s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
21m 21s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

410m  1s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 40f0dfc92c04 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c912d1dfb9eec4e0f1ef64dc3cae4b8d808e51d2

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/2/testReport/

Max. process+thread count
2249 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 49s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 47s

trunk passed

+1 :green_heart:
compile
6m  6s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
5m 42s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
3m 11s

trunk passed

+1 :green_heart:
javadoc
2m 30s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 13s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 14s

trunk passed

+1 :green_heart:
shadedclient
20m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 41s

the patch passed

+1 :green_heart:
compile
5m 53s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 53s

the patch passed

+1 :green_heart:
compile
5m 40s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  4s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 1 new + 146 unchanged - 0 fixed = 147 total (was 146)

+1 :green_heart:
mvnsite
2m 43s

the patch passed

+1 :green_heart:
javadoc
2m  1s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 50s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 14s

the patch passed

+1 :green_heart:
shadedclient
20m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 25s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
242m 26s

hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
22m  9s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

414m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 69778f0dc2a1 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 83c7c038c1cd04370b4ba5bf8f559238b17f08c2

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/3/testReport/

Max. process+thread count
2853 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhtttylz We need to fix checkstyle.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 48s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 24s

trunk passed

+1 :green_heart:
compile
5m 56s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
5m 47s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
3m 11s

trunk passed

+1 :green_heart:
javadoc
2m 29s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 15s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 10s

trunk passed

+1 :green_heart:
shadedclient
20m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 40s

the patch passed

+1 :green_heart:
compile
5m 51s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 51s

the patch passed

+1 :green_heart:
compile
5m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  5s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 10 new + 146 unchanged - 0 fixed = 156 total (was 146)

+1 :green_heart:
mvnsite
2m 46s

the patch passed

+1 :green_heart:
javadoc
1m 59s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 56s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 15s

the patch passed

+1 :green_heart:
shadedclient
20m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 28s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
206m  3s

hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
21m  3s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

376m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 6f1ae6ee5f7f 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2a28640c03a1ebaa5b90d355bd4a8f353be0a439

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/5/testReport/

Max. process+thread count
3128 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989 I've updated the PR based on your suggestion, could you review this please. thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
25m 33s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  4s

trunk passed

+1 :green_heart:
compile
6m  6s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
5m 49s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 17s

trunk passed

+1 :green_heart:
mvnsite
3m 17s

trunk passed

+1 :green_heart:
javadoc
2m 29s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 12s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 14s

trunk passed

+1 :green_heart:
shadedclient
20m 41s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m  1s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 40s

the patch passed

+1 :green_heart:
compile
5m 54s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 54s

the patch passed

+1 :green_heart:
compile
5m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  5s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 10 new + 146 unchanged - 0 fixed = 156 total (was 146)

+1 :green_heart:
mvnsite
2m 49s

the patch passed

+1 :green_heart:
javadoc
1m 59s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 52s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 11s

the patch passed

+1 :green_heart:
shadedclient
20m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 27s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
210m  6s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
20m 33s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

390m  2s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux c043f09341af 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b5184b93127acdc9de45d4357402a99fdc6cd097

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/6/testReport/

Max. process+thread count
3661 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
19m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 32s

trunk passed

+1 :green_heart:
compile
6m 52s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
6m 14s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
3m  5s

trunk passed

+1 :green_heart:
javadoc
2m 22s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m  4s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 30s

trunk passed

+1 :green_heart:
shadedclient
23m 36s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 54s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 42s

the patch passed

+1 :green_heart:
compile
6m 39s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
6m 39s

the patch passed

+1 :green_heart:
compile
6m 11s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
6m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 10s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 10 new + 146 unchanged - 0 fixed = 156 total (was 146)

+1 :green_heart:
mvnsite
2m 47s

the patch passed

+1 :green_heart:
javadoc
2m  1s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 47s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 36s

the patch passed

+1 :green_heart:
shadedclient
23m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 20s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
229m 33s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
21m 24s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

414m 58s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestObserverNode

hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 0cfdab4e4e99 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d3eec1667f7ff9ef4f6db8d843aa1c0515480c91

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/7/testReport/

Max. process+thread count
2843 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 17s

trunk passed

+1 :green_heart:
compile
6m 10s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
6m 12s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
3m 41s

trunk passed

+1 :green_heart:
javadoc
2m 38s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 32s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 40s

trunk passed

+1 :green_heart:
shadedclient
21m  5s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 24s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s

the patch passed

+1 :green_heart:
compile
6m 12s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
6m 12s

the patch passed

+1 :green_heart:
compile
6m 17s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
6m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 10 new + 146 unchanged - 0 fixed = 156 total (was 146)

+1 :green_heart:
mvnsite
3m 16s

the patch passed

+1 :green_heart:
javadoc
2m 17s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 20s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 45s

the patch passed

+1 :green_heart:
shadedclient
20m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 23s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
259m 30s

hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
23m  7s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

438m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 98a146ad3d22 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 85d1cdb209348bed5a0617c8232b0bc5f286a1a1

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/8/testReport/

Max. process+thread count
2615 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 36s

trunk passed

+1 :green_heart:
compile
7m 10s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
6m 15s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 22s

trunk passed

+1 :green_heart:
mvnsite
3m  9s

trunk passed

+1 :green_heart:
javadoc
2m 27s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m  6s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 17s

trunk passed

+1 :green_heart:
shadedclient
21m  4s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 22s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 52s

the patch passed

+1 :green_heart:
compile
7m  8s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
7m  8s

the patch passed

+1 :green_heart:
compile
6m  4s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
6m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  8s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 10 new + 146 unchanged - 0 fixed = 156 total (was 146)

+1 :green_heart:
mvnsite
2m 49s

the patch passed

+1 :green_heart:
javadoc
1m 59s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 46s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 19s

the patch passed

+1 :green_heart:
shadedclient
21m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 31s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
262m  3s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
22m 45s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

441m 33s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux ff7ad1bf678b 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0bcd6d1a9d228109a17ea75e1e37d4911c851c48

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/9/testReport/

Max. process+thread count
3352 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 38s

trunk passed

+1 :green_heart:
compile
6m  0s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
5m 38s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
3m  8s

trunk passed

+1 :green_heart:
javadoc
2m 31s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 17s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 12s

trunk passed

+1 :green_heart:
shadedclient
20m 22s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
20m 42s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 40s

the patch passed

+1 :green_heart:
compile
5m 55s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 55s

the patch passed

+1 :green_heart:
compile
5m 34s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  4s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 9 new + 146 unchanged - 0 fixed = 155 total (was 146)

+1 :green_heart:
mvnsite
2m 47s

the patch passed

+1 :green_heart:
javadoc
1m 59s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 50s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 13s

the patch passed

+1 :green_heart:
shadedclient
20m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 26s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
212m 26s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
20m 31s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

381m 25s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 82a4d63b38f4 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 07ced20926f4dd5c0e2a832ee53890ad16f17f3d

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/10/testReport/

Max. process+thread count
3551 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 57s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 48s

trunk passed

+1 :green_heart:
compile
6m  2s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
5m 48s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
3m 13s

trunk passed

+1 :green_heart:
javadoc
2m 31s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m  6s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 11s

trunk passed

+1 :green_heart:
shadedclient
20m 30s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
20m 49s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 41s

the patch passed

+1 :green_heart:
compile
5m 51s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 51s

the patch passed

+1 :green_heart:
compile
5m 33s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 9 new + 146 unchanged - 0 fixed = 155 total (was 146)

+1 :green_heart:
mvnsite
2m 52s

the patch passed

+1 :green_heart:
javadoc
2m  0s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 53s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 13s

the patch passed

+1 :green_heart:
shadedclient
20m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 26s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
204m  5s

hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
20m 39s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

374m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux fb00d49d93fe 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3d10f35f84dd501bbd19d9a261e7e1b36a5400cb

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/11/testReport/

Max. process+thread count
3269 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 49s

trunk passed

+1 :green_heart:
compile
5m 59s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
5m 45s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 17s

trunk passed

+1 :green_heart:
mvnsite
3m 13s

trunk passed

+1 :green_heart:
javadoc
2m 32s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 12s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 16s

trunk passed

+1 :green_heart:
shadedclient
20m 42s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m  2s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 44s

the patch passed

+1 :green_heart:
compile
5m 52s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 52s

the patch passed

+1 :green_heart:
compile
5m 43s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  5s

the patch passed

+1 :green_heart:
mvnsite
2m 48s

the patch passed

+1 :green_heart:
javadoc
2m  2s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 55s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 13s

the patch passed

+1 :green_heart:
shadedclient
20m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 28s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
230m 49s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
0m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

+0 :ok:
asflicense
0m 34s

ASF License check generated no output?

380m 57s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRead

hadoop.hdfs.TestCrcCorruption

hadoop.hdfs.server.namenode.TestXAttrConfigFlag

hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA

hadoop.hdfs.server.namenode.TestFSImage

hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocks

hadoop.hdfs.TestMaintenanceWithStriped

hadoop.hdfs.TestDFSOutputStream

hadoop.hdfs.server.namenode.ha.TestObserverNode

hadoop.hdfs.server.namenode.TestReencryption

hadoop.hdfs.server.namenode.TestNamenodeStorageDirectives

hadoop.hdfs.TestDFSRemove

hadoop.hdfs.server.namenode.TestNetworkTopologyServlet

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestDFSClientSocketSize

hadoop.hdfs.server.namenode.TestFSImageWithAcl

hadoop.hdfs.server.namenode.TestReconstructStripedBlocks

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 93ee412b323d 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae69e6d9bbf1eda84a871e787656cc83b3b16f93

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/12/testReport/

Max. process+thread count
3303 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
66m 20s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 55s

trunk passed

+1 :green_heart:
compile
6m 11s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
6m 39s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
3m 14s

trunk passed

+1 :green_heart:
javadoc
2m 30s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 12s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 14s

trunk passed

+1 :green_heart:
shadedclient
20m 36s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
20m 56s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s

the patch passed

+1 :green_heart:
compile
5m 55s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 55s

the patch passed

+1 :green_heart:
compile
5m 36s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  4s

the patch passed

+1 :green_heart:
mvnsite
2m 49s

the patch passed

+1 :green_heart:
javadoc
2m  1s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 50s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
7m 14s

the patch passed

+1 :green_heart:
shadedclient
20m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 26s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
205m 59s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
20m 57s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

428m  9s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5517

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 53e15f4db464 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e7dc8909f3f9bf33184d5d3ba9c7ee139160a97e

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/14/testReport/

Max. process+thread count
3203 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/14/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhtttylz Thanks for the contribution! The unit test error is not caused by this pr. merged.

Thanks @slfan1989  help review and merged.


Release 1.0.0-alpha

What It Does 🔎

Proposition to release version 1.0.0-alpha of our hip validator !
Documentation Updates 📘

N/A
How To Test ✔

cargo test
Linked Issues 🎫

https://polyphene.myjetbrains.com/youtrack/issue/HTB-109
Related Pull Requests 🔀

N/A

🛑 Replaced with https://github.com/polyphene/hip-validator/pull/3


Updated Autofac example in wiki

I have updated the wiki's Autofac example to have the ContravariantRegistrationSource excluded by default, with a warning about enabling it.  Having it enabling it by default drops users into a small minefield IMO (#128) if/when they start using the pipeline.  It bit me today, and looks like it was probably the root cause behind #209 as well.  I also added a warning to the behaviors page to give a short explanation of the issue and link to #128 if users want to try to work around the issue.  Basically just requesting a review to ensure the changes make sense to someone who hasn't been immersed in this issue for the last few hours.  :)

Thanks!


place of events

At the moment we have two contracts that take responsibility for events: DealProvider and LockDealNFT. We can move all events to LockDealNFT.

    event UpdateParams(uint256 indexed poolId, uint256[] params);


Add missing RBI definitions for RubyVM's AbstractSyntaxTree and Node

Motivation
Add missing RBI definitions for RubyVM's AbstractSyntaxTree and Node.
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_I42zcojIijLecB

Tests in Stripe's codebase were succesful. Letting @jez give the final 👍🏽 , though

@jez is anything missing to get this through?


Update cloud-init user data warning

Modifies the warning about cloud-init user data to emphasize that it's not encrypted, and provides a link to data security and encryption best practices.

#sign-off

Please use azure-docs-pr

Closing and opening new PR against azure-docs-pr


too many EventEmitter ?

Hi when I execute npm install , some warning messages happend.
 >> npm install
npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native atob() and btoa() methods instead
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
(node:95637) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(Use `node --trace-warnings ...` to show where the warning was created)
(node:95637) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:95637) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:95637) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:95637) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit

I found some suggestion on slackoverflow.
https://stackoverflow.com/questions/9768444/possible-eventemitter-memory-leak-detected

I'd like to point out here that that warning is there for a reason and there's a good chance the right fix is not increasing the limit but figuring out why you're adding so many listeners to the same event. Only increase the limit if you know why so many listeners are being added and are confident it's what you really want.

I'm not sure if this is a problem or not.

The errors are not produced by the project, I don't have any control on it. The problems are coming from NPM or from the dependencies. FYI, the dependencies are on the latest version (updated a few days ago).

I deleted the package-lock.json node_modules/,  and npm install it again. It seemed to have vanished.
May be something wrong with the babel version.
"node_modules/@babel/compat-data": {
-      "version": "7.24.1",
-      "resolved"<EMAIL_ADDRESS>-      "integrity": "sha512-Pc65opHDliVpRHuKfzI+gSA4zcgr65O4cl64fFJIWEEh8JoHIHh0Oez1Eo8Arz8zq/JhgKodQaxEwUPRtZylVA==",
+      "version": "7.24.4",
+      "resolved"<EMAIL_ADDRESS>+      "integrity": "sha512-vg8Gih2MLK+kOkHJp4gBEIkyaIi00jgWot2D9QOmmfLC8jINSOzmCLta6Bvz/JSBCqnegV0L80jhxkol5GWNfQ==",
    "dev": true,
    "engines": {
      "node": ">=6.9.0"
    }
  },
  "node_modules/@babel/core": {
-      "version": "7.24.3",
-      "resolved"<EMAIL_ADDRESS>-      "integrity": "sha512-5FcvN1JHw2sHJChotgx8Ek0lyuh4kCKelgMTTqhYJJtloNvUfpAFMeNQUtdlIaktwrSV9LtCdqwk48wL2wBacQ==",
+      "version": "7.24.4",
+      "resolved"<EMAIL_ADDRESS>+      "integrity": "sha512-MBVlMXP+kkl5394RBLSxxk/iLTeVGuXTV3cIDXavPpMMqnSnt6apKgan/U8O3USWZCWZT/TbgfEpKa4uMgN4Dg==",
    "dev": true,
    "dependencies": {
      "@ampproject/remapping": "^2.2.0",
      "@babel/code-frame": "^7.24.2",
-        "@babel/generator": "^7.24.1",
+        "@babel/generator": "^7.24.4",
      "@babel/helper-compilation-targets": "^7.23.6",
      "@babel/helper-module-transforms": "^7.23.3",
-        "@babel/helpers": "^7.24.1",
-        "@babel/parser": "^7.24.1",
+        "@babel/helpers": "^7.24.4",
+        "@babel/parser": "^7.24.4",
      "@babel/template": "^7.24.0",
      "@babel/traverse": "^7.24.1",
      "@babel/types": "^7.24.0",
@@ -224,9 +224,9 @@
    }
  },

Not surprise it has been solved by a fresh npm install, usually these message are generated by dependencies.


Huge Memory Leak by ToolTips Object : With Fix Proposal

We have localized a huge memory leak in WPFLocalizeExtension.Provider by ParentChangedNotifiedHelper class.
The Function GetValueOrRegisterParentNotifier should be extended with
if (depObj is System.Windows.Controls.ToolTip)
break;
At Line 63-66, after this it works fine. At this moment we have like 5 Mb memory leak each time we switch the page. So it would be great if it would be fixed very soon.

Thank you for submitting the bug. I just created the fix, but @MrCircuit has to review it because I don't use WPF anymore.
Would you be kind and provide a working example where the memory leak can be observed / tested against after the fix is applied?

I can make a test after but I can't attach the App. We have a Delta von unter +10MB with the fix and more than +40MB after 130 interaction with current script. The Tooltips are saved as an Referenz in ResxLocalizationProvider and ParentChangedNotifier.OnParentChangedList hold them in Memory. If we skip them there are not there anymore and still will be translated.

Yes, I guess WPF does not cache the tooltips but create a new one every time, is that true?
at least it would explain the behavior.
we need to wait for @MrCircuit for the deployment :(

Sorry - I was under heavy load the last weeks. I scheduled myself to work on this topic at latest this weekend. If not done, please remind me.


Thanks for posting this to GitHub

Hi, I'm the original author. Thanks for picking this up and rehosting it on GitHub.
Happy to see the old code again.

I'm just hopeful that it's of use to someone!
I used this for pretty much all of the on-site installs that I did, and generated versions for SharePoint 2013/2016. It always seemed like such a simple and elegant solution!

I'm just hopeful that it's of use to someone!
I used this for pretty much all of the on-site installs that I did, and generated versions for SharePoint 2013/2016. It always seemed like such a simple and elegant solution!


OOM error during inference.

Describe the bug
I am using the WriteH5Callback at inference time. I tracked the RSS memory which gets utilised during inference. Below is what I found.

After writing each H5 file corresponding to one WSI from the inference dataset:

The RSS memory held up by the callback increases consistently.
In this example, I deliberately requested memory of 400GB and surely enough, the job throws an OOM error once this limit is crossed (check below).

Expected behavior
The RSS memory shouldn't keep increasing with every new image while performing inference.

I investigated this a little bit more and I am fairly certain that we don't have a bug in our callback. But let me know what you think @jonasteuwen. I did the following things:

Kept track of the reference counts to H5FileImageWriter and ensured they are explicitly dereferenced after each WSI output have been stored to disk by adding the following line within the process management:
self._writers[self._current_filename] = {}

Explicitly deleted variables or references to classes which may be leaking memory. For example, I delete self._data at the end of consume function in H5FileImageWriter. This was immediately followed by by a gc.collect() step.

Line-by-line profiling of the callback to analyse which line creates memory resources. Check the snippet below:

Filename: /home/a.karkala/ahcore/ahcore/callbacks.py
Line #    Mem usage    Increment  Occurrences   Line Contents
=============================================================
   367   4262.4 MiB   4262.4 MiB           1       @profile
   368                                             def _batch_end(
   369                                                     self,
   370                                                     trainer: pl.Trainer,
   371                                                     pl_module: pl.LightningModule,
   372                                                     outputs: Any,
   373                                                     batch: Any,
   374                                                     batch_idx: int,
   375                                                     stage: str,
   376                                                     dataloader_idx: int = 0,
   377                                             ) -> None:
   378   4262.4 MiB      0.0 MiB           1           filename = batch["path"][0]  # Filenames are constant across the batch.
   379   4262.4 MiB      0.0 MiB          11           if any([filename != path for path in batch["path"]]):
   380                                                     raise ValueError(
   381                                                         "All paths in a batch must be the same. "
   382                                                         "Either use batch_size=1 or ahcore.data.samplers.WsiBatchSampler."
   383                                                     )
   384
   385   4262.4 MiB      0.0 MiB           1           if filename != self._current_filename:
   386                                                     output_filename = _get_h5_output_filename(
   387                                                         self.dump_dir,
   388                                                         filename,
   389                                                         model_name=str(pl_module.name),
   390                                                         step=pl_module.global_step,
   391                                                     )
   392                                                     output_filename.parent.mkdir(parents=True, exist_ok=True)
   393                                                     link_fn = (
   394                                                             self.dump_dir / "outputs" / f"{pl_module.name}" / f"step_{pl_module.global_step}" / "image_h5_link.txt"
   395                                                     )
   396                                                     with open(link_fn, "a" if link_fn.is_file() else "w") as file:
   397                                                         file.write(f"{filename},{output_filename}\n")
   398
   399                                                     self._logger.debug("%s -> %s", filename, output_filename)
   400                                                     if self._current_filename is not None:
   401                                                         self.__process_management()
   402                                                         self._semaphore.release()
   403
   404                                                     self._semaphore.acquire()
   405
   406                                                     if stage == "validate":
   407                                                         total_dataset: ConcatDataset = trainer.datamodule.validate_dataset  # type: ignore
   408                                                     elif stage == "predict":
   409                                                         total_dataset: ConcatDataset = trainer.predict_dataloaders.dataset  # type: ignore
   410                                                     else:
   411                                                         raise NotImplementedError(f"Stage {stage} is not supported for {self.__class__.__name__}.")
   412
   413                                                     current_dataset: TiledWsiDataset
   414                                                     current_dataset, _ = total_dataset.index_to_dataset(self._dataset_index)  # type: ignore
   415                                                     slide_image = current_dataset.slide_image
   416
   417                                                     data_description: DataDescription = pl_module.data_description  # type: ignore
   418                                                     inference_grid: GridDescription = data_description.inference_grid
   419
   420                                                     mpp = inference_grid.mpp
   421                                                     if mpp is None:
   422                                                         mpp = slide_image.mpp
   423
   424                                                     scaling = slide_image.get_scaling(mpp)
   425                                                     slide_image.close()
   426                                                     # Below, we set the flag use_limit_bounds to account for the slide bounds used during dataset creation.
   427                                                     size = slide_image.get_scaled_size(scaling, use_limit_bounds=self._limit_bounds)
   428                                                     num_samples = len(current_dataset)
   429
   430                                                     # Let's get the data_description, so we can figure out the tile size and things like that
   431                                                     tile_size = inference_grid.tile_size
   432                                                     tile_overlap = inference_grid.tile_overlap
   433
   434                                                     # TODO: We are really putting strange things in the Queue if we may believe mypy
   435                                                     new_queue: Queue[Any] = Queue()  # pylint: disable=unsubscriptable-object
   436                                                     parent_conn, child_conn = Pipe()
   437                                                     new_writer = H5FileImageWriter(
   438                                                         output_filename,
   439                                                         size=size,
   440                                                         mpp=mpp,
   441                                                         tile_size=tile_size,
   442                                                         tile_overlap=tile_overlap,
   443                                                         num_samples=num_samples,
   444                                                         progress=None,
   445                                                     )
   446                                                     self._logger.info(f"Number of references to H5Writer: {len(gc.get_referrers(H5FileImageWriter))}")
   447                                                     new_process = Process(target=new_writer.consume, args=(self.generator(new_queue), child_conn))
   448                                                     new_process.start()
   449                                                     self._writers[filename] = {
   450                                                         "queue": new_queue,
   451                                                         "writer": new_writer,
   452                                                         "process": new_process,
   453                                                         "connection": parent_conn,
   454                                                     }
   455                                                     self._current_filename = filename
   456
   457   4294.3 MiB     31.9 MiB           1           prediction = outputs["prediction"].detach().cpu().numpy()
   458   4294.3 MiB      0.0 MiB           1           coordinates_x, coordinates_y = batch["coordinates"]
   459   4294.3 MiB      0.0 MiB           1           coordinates = torch.stack([coordinates_x, coordinates_y]).T.detach().cpu().numpy()
   460   4294.3 MiB      0.0 MiB           1           self._writers[filename]["queue"].put((coordinates, prediction))
   461   4294.3 MiB      0.0 MiB           1           self._dataset_index += prediction.shape[0]

Filename: /home/a.karkala/ahcore/ahcore/callbacks.py

Line #    Mem usage    Increment  Occurrences   Line Contents
=============================================================
   367   4294.4 MiB   4294.4 MiB           1       @profile
   368                                             def _batch_end(
   369                                                     self,
   370                                                     trainer: pl.Trainer,
   371                                                     pl_module: pl.LightningModule,
   372                                                     outputs: Any,
   373                                                     batch: Any,
   374                                                     batch_idx: int,
   375                                                     stage: str,
   376                                                     dataloader_idx: int = 0,
   377                                             ) -> None:
   378   4294.4 MiB      0.0 MiB           1           filename = batch["path"][0]  # Filenames are constant across the batch.
   379   4294.4 MiB      0.0 MiB          11           if any([filename != path for path in batch["path"]]):
   380                                                     raise ValueError(
   381                                                         "All paths in a batch must be the same. "
   382                                                         "Either use batch_size=1 or ahcore.data.samplers.WsiBatchSampler."
   383                                                     )
   384
   385   4294.4 MiB      0.0 MiB           1           if filename != self._current_filename:
   386                                                     output_filename = _get_h5_output_filename(
   387                                                         self.dump_dir,
   388                                                         filename,
   389                                                         model_name=str(pl_module.name),
   390                                                         step=pl_module.global_step,
   391                                                     )
   392                                                     output_filename.parent.mkdir(parents=True, exist_ok=True)
   393                                                     link_fn = (
   394                                                             self.dump_dir / "outputs" / f"{pl_module.name}" / f"step_{pl_module.global_step}" / "image_h5_link.txt"
   395                                                     )
   396                                                     with open(link_fn, "a" if link_fn.is_file() else "w") as file:
   397                                                         file.write(f"{filename},{output_filename}\n")
   398
   399                                                     self._logger.debug("%s -> %s", filename, output_filename)
   400                                                     if self._current_filename is not None:
   401                                                         self.__process_management()
   402                                                         self._semaphore.release()
   403
   404                                                     self._semaphore.acquire()
   405
   406                                                     if stage == "validate":
   407                                                         total_dataset: ConcatDataset = trainer.datamodule.validate_dataset  # type: ignore
   408                                                     elif stage == "predict":
   409                                                         total_dataset: ConcatDataset = trainer.predict_dataloaders.dataset  # type: ignore
   410                                                     else:
   411                                                         raise NotImplementedError(f"Stage {stage} is not supported for {self.__class__.__name__}.")
   412
   413                                                     current_dataset: TiledWsiDataset
   414                                                     current_dataset, _ = total_dataset.index_to_dataset(self._dataset_index)  # type: ignore
   415                                                     slide_image = current_dataset.slide_image
   416
   417                                                     data_description: DataDescription = pl_module.data_description  # type: ignore
   418                                                     inference_grid: GridDescription = data_description.inference_grid
   419
   420                                                     mpp = inference_grid.mpp
   421                                                     if mpp is None:
   422                                                         mpp = slide_image.mpp
   423
   424                                                     scaling = slide_image.get_scaling(mpp)
   425                                                     slide_image.close()
   426                                                     # Below, we set the flag use_limit_bounds to account for the slide bounds used during dataset creation.
   427                                                     size = slide_image.get_scaled_size(scaling, use_limit_bounds=self._limit_bounds)
   428                                                     num_samples = len(current_dataset)
   429
   430                                                     # Let's get the data_description, so we can figure out the tile size and things like that
   431                                                     tile_size = inference_grid.tile_size
   432                                                     tile_overlap = inference_grid.tile_overlap
   433
   434                                                     # TODO: We are really putting strange things in the Queue if we may believe mypy
   435                                                     new_queue: Queue[Any] = Queue()  # pylint: disable=unsubscriptable-object
   436                                                     parent_conn, child_conn = Pipe()
   437                                                     new_writer = H5FileImageWriter(
   438                                                         output_filename,
   439                                                         size=size,
   440                                                         mpp=mpp,
   441                                                         tile_size=tile_size,
   442                                                         tile_overlap=tile_overlap,
   443                                                         num_samples=num_samples,
   444                                                         progress=None,
   445                                                     )
   446                                                     self._logger.info(f"Number of references to H5Writer: {len(gc.get_referrers(H5FileImageWriter))}")
   447                                                     new_process = Process(target=new_writer.consume, args=(self.generator(new_queue), child_conn))
   448                                                     new_process.start()
   449                                                     self._writers[filename] = {
   450                                                         "queue": new_queue,
   451                                                         "writer": new_writer,
   452                                                         "process": new_process,
   453                                                         "connection": parent_conn,
   454                                                     }
   455                                                     self._current_filename = filename
   456
   457   4326.3 MiB     31.9 MiB           1           prediction = outputs["prediction"].detach().cpu().numpy()
   458   4326.3 MiB      0.0 MiB           1           coordinates_x, coordinates_y = batch["coordinates"]
   459   4326.3 MiB      0.0 MiB           1           coordinates = torch.stack([coordinates_x, coordinates_y]).T.detach().cpu().numpy()
   460   4326.3 MiB      0.0 MiB           1           self._writers[filename]["queue"].put((coordinates, prediction))
   461   4326.3 MiB      0.0 MiB           1           self._dataset_index += prediction.shape[0]

I changed the threshold for garbage collection. By default, the threshold after which a garbage collection is triggered for three generations is (700,10,10). I changed this to (1,1,1) only during the duration of the callback but it didn't help.

The issue we have looks is the same as what is reported here. They identified a problem with hdf5 c library against which h5py is compiled. Unfortunately, the issue they pointed out is still not fixed in upstream hdf5. Check here. One of the contributor has taken this up and marked this issue for the next release. check below:

For now, maybe we should compile h5py from source by choosing the non-leaky hdf5 library.

This version does work for me

Thanks @moerlemans ! So, your working environment uses hdf5 1.10.6. That confirms the findings.

I did some more checks and I am capturing them here. It's now starting to look like it wasn't a problem with h5py or the underlying library either (well, at least it may have added to the trouble we saw). But I installed older versions of h5py with older versions of hdf5 library and the problem still persisted.
Specifically, I tried:
h5py 3.7.0 compiled against hdf5 1.10.6 (same setup as @moerlemans above).
h5py 3.6.0 compiled against hdf5 1.10.6 (just for the heck of it and really rule this out).
Then, I started looking elsewhere. I investigated how much memory the child processes end up taking while doing the h5 writing. Following are some screenshots I made using the top -u <username> command.

output from top while h5 writing for first wsi
output from top while h5 writing for second wsi

When the prediction begins for the first image, process with id 3328375 is the parent. 3336839 is the child process. After that's done, the child process is properly exited. During this time, the resident set size and the virtual memory has significantly increased in the parent process. The next child process with id 3387563 inherits the parent (multiprocessing uses forking by default. So, the memory isn't copied but it's shared and copied only when the child is trying to modify it.).
So, this rules out any problem with the multiprocessing we have in place currently. Or in fact, the problem doesn't seem to be in the h5 writing or the callback at all. So, I disabled all the callbacks and simply ran a prediction loop. Much to my own surprise, it crashed very quickly. It turns out there is an open issue on pytorch lightning github which is similar (but not exactly the same).

I downgraded to pytorch_lightning 1.9.1 while retaining the latest pytorch. The issue doesn't seem to go away.

I downgraded pytorch to 1.12.1 and the issue didn't go away.

Here is a memory profile for ahcore during inference from start to the point when the program crashes.

From the looks of it, it seems like the predictions are not being deallocated after the prediction step. So, to test this hypothesis I return None after predict_step() in the lit_module. The memory profile now looks much better. Maybe, this is what was going wrong afterall.

@EricMarcus-ai and I looked at the issue today. We disabled virtually eveyrhting that could cause memory leaks. Concretely, we did the following:
Commented all the lines within the predict_step() and ran the script. Even though the model isn't being used at this time, the memory usage was through the roof and it eventually crashed.
Just as a sanity check, we also downgraded the pytorch lightning version and repeated the run. It still broke.
    def predict_step(self, batch: Any, batch_idx: int, dataloader_idx: int = 0) -> Any:
        if self._augmentations and "predict" in self._augmentations:
            batch = self._augmentations["predict"](batch)

        #_relevant_dict = {k: v for k, v in batch.items() if k in self.RELEVANT_KEYS}
        #batch = {**batch, **self._get_inference_prediction(batch["image"])}
        #pred_debug = self._get_inference_prediction(batch["image"])
        #_prediction = batch["prediction"]
        #output = {"prediction": _prediction, **_relevant_dict}

        # This is a sanity check. We expect the filenames to be constant across the batch.
        filename = batch["path"][0]
        if any([filename != f for f in batch["path"]]):
            raise ValueError("Filenames are not constant across the batch.")
        return None

Today, I investigated the role of the return_predictions flag in the trainer.predict(). It looks like when this is set to True, pytorch lightning aggregates results from all batches throughout the epoch hence holding them in main memory. Below, we see this clearly. (note: callbacks are completely switched off).

@AjeyPaiK can this be closed?

Yes. I made the necessary changes in this PR.


Module level directives cause errors when bundled

Describe the bug
I got a lot of error warnings while building with React v18.2.0 + Vite v4.1.4.
Your minimal, reproducible example

Steps to reproduce

npm run build;
see error;

Expected behavior
I expected the build process to go without any error warnings. It has already been said in this pull request.
How often does this bug happen?
Every time
Screenshots or Videos

Platform

macOS;
Chrome;
version 111;

Tanstack Query adapter
react-query
TanStack Query version
v4.28.0
TypeScript version
v4.9.5
Additional context
No response

I literally just closed the same issue an hour ago as a duplicate. Opening more duplicates won't make it any better. Please use the search before filing issues.

https://github.com/TanStack/query/issues/5216
https://github.com/TanStack/query/issues/5175

My bad. Thanks.