kubernetes: build with an initContainer or a Job

Context
Currently, envbuilder runs at the start up of a workspace, exposing elements of the buildtime to the runtime and vice-versa:

Build secrets (e.g. dockerconfig)
Environment variables (#91)
Mounts (#187)
Privileges (#181)
Container layers are downloaded in each container rather than on the nodes
... (feel free to grow the list)

Proposal 1: initContainer

Envbuilder would build the image as an initContainer and push it to a container registry
The main container would pull and run the image (todo: validate that the pod can be created without the image existing yet)

This would require to generate/know the image reference ahead of time.
Proposal 2: Kubernetes Job
Entire decoupling of buildtime and runtime:

Envbuilder runs as Kubernetes Job to build and push the container image
It writes a ConfigMap with the reference of the built image
Terraform waits for completion of the Job
Terraform reads the ConfigMap with kubernetes_config_map datasource (explicitly depending on the Job creation)
The image reference from the ConfigMap is then used to create a Deployment
A short ttl_seconds_after_finished would allow clean up of the Job for it to be recreated on the next terraform apply

The ConfigMap could be used to share of information between envbuilder and Terraform (#121), like the volumes defined in the devcontainer.json (#220)
Detail to consider: I believe the Coder server starts streaming the logs from the deployment after the terraform apply has finished, it would need to be able to do it for the Job while the apply is running to expose the build logs to the user.
Is it something that has been thought of/done but not documented yet?

Thank you @maxbrunet. I think these are excellent ideas to improve the dev container Kubernetes.

@maxbrunet these are all great ideas!


Wrap More in Retry Logic

Azure DevOps Extensions
WIKI Updater
Platform
Azure DevOps Services
Azure DevOps Server (TFS) Version
No response
Extension Version
No response
Describe the bug
We have quite a concurrent pipeline with a single build/test followed by a large set of deployment stages running in parallel. Part of the deployment stages we use the Release Notes Generator task followed by the WikiUpdater task.
Because these deployments are happening in parallel occasionally we hit the scenario where two WikiUpdater tasks are running around the same time on the same wiki repo.
One of the tasks succeeds but the other fails with:
Cloned dev.azure.com/<org>/<project>/_git/release_notes to /home/vsts/work/1/s\repo
Set GIT values in /home/vsts/work/1/s\repo
Pull in case of post clone updates from other users
Working file name is __latest.md
Created the '__latest.md' in '/home/vsts/work/1/s\repo/SIT/SFI' - fixing line-endings
Added SIT/SFI/__latest.md to repo /home/vsts/work/1/s\repo
Committed file "/home/vsts/work/1/s\repo" with message "SFI SIT Release notes from build [60243]" as SHA 81f8e9f
Attempt 1 - Push to dev.azure.com/<org>/<project>/_git/release_notes
Push failed, probably due to target being updated completed, will retry up to 32 times
Pull to get updates from other users
##[error]Error: Need to specify how to reconcile divergent branches.
##[error]Error: Need to specify how to reconcile divergent branches.

Looking at the code - the retry is around only the git push command - but because the remote repo has been updated by a parallel task it is the pull which is failing. I think this could be fixed by using a rebase rather than pull when iterating through the retries.
The line in question is:
https://github.com/rfennell/AzurePipelines/blob/70073f554776d99a3f24921a7c3fe6724253172e/Extensions/WikiUpdater/WikiUpdaterTask/src/GitWikiFuntions.ts#L320
Repo Steps
Run tasks in parallel against the same wiki repo
Expected Behavior
All parallel tasks complete (albeit with possibly retries)
Logging Information
Cloned dev.azure.com///_git/release_notes to /home/vsts/work/1/s\repo
Set GIT values in /home/vsts/work/1/s\repo
Pull in case of post clone updates from other users
Working file name is __latest.md
Created the '__latest.md' in '/home/vsts/work/1/s\repo/SIT/SFI' - fixing line-endings
Added SIT/SFI/__latest.md to repo /home/vsts/work/1/s\repo
Committed file "/home/vsts/work/1/s\repo" with message "SFI SIT Release notes from build [60243]" as SHA 81f8e9f
Attempt 1 - Push to dev.azure.com///_git/release_notes
Push failed, probably due to target being updated completed, will retry up to 32 times
Pull to get updates from other users
##[error]Error: Need to specify how to reconcile divergent branches.
##[error]Error: Need to specify how to reconcile divergent branches.

I think the best option is to add a parameter so you can pick a pull or a rebase, leaving pull as the default so it is not a breaking change for other uses.
I will try to get that out this week

Works like a dream. Thanks for the quick turnaround!


.ptx is fail

[root@localhost resources]# ptxas GpuEnablerExamples.ptx
ptxas fatal   : SM version specified by .target is higher than default SM version assumed

Why do you want to generate assembly code?

make
file:  GPUEnabler-master\examples\src\main\resources\Makefile

You have a GPU that has a lower compute capability than that specified in the .ptx file. Try building the .cu file to .ptx using your GPU instead of directly using the .ptx provided.

but as I run:
./bin/run-example GpuEnablerExample
./bin/run-example SparkGPULR
It is ok
why


Fixup pep8 errors and swap to sha256 instead

Didn't add a flag for sha256 mode as I wasn't sure if you wanted to actually keep md5 for a specific reason.

You can't just change the hash. It would invalidate every existing data set.
MD5 is used because it's faster and in this usecase generally fine. Collision is not likely. However, I am already planning to add arbitrary hash support for those that care and to allow for a null hash so it can be used just for indexing but that's far more invasive. It will be backwards compatible though.
As for pep8... i suppose I'm fine with that but it should be a separate pr. Shouldn't mix restructuring with with other commits.

@skarekrow Check the new version. You can choose the hash function with -H


Making Euler number 43 a bit simpler.

I found a few changes to make the code simpler and easier to read (perhaps also faster).
I really like this problem/solution because it shows the power of the persistent data types. I do CharSeq#remove lots of times on ALL_DIGITS without affecting the original list. It's really great to be able to declare a common set of data and then use it in different ways without having to think about shared state.

Current coverage is 97.04% (diff: 100%)

Merging #1514 into master will increase coverage by <.01%

@@             master      #1514   diff @@
==========================================
  Files            87         87
  Lines         10507      10507
  Methods           0          0
  Messages          0          0
  Branches       1797       1797
==========================================
+ Hits          10195      10196     +1
  Misses          183        183
+ Partials        129        128     -1

Powered by Codecov. Last update 7acab64...3e3032f

Very nice solution, thanks!


Also redirect_url() doesn't work as in documentation.

 let mut easy = Easy2::new(CollectorForTests(Vec::new()));
        easy.get(true).unwrap();
        easy.follow_location(true).unwrap();
        easy.ssl_verify_peer(true).unwrap();
        easy.ssl_verify_host(true).unwrap();
        easy.connect_timeout(Duration::from_secs(30)).unwrap();
        easy.timeout(Duration::from_secs(30)).unwrap();
        easy.max_connects(10).unwrap();
        easy.max_redirections(10).unwrap();

        // easy.verbose(true).unwrap();
        easy.url("http://rust-lang.org/").unwrap();
        easy.perform().unwrap();

        println!("Redirect count: {:?}", easy.redirect_count().unwrap());
        println!("Final URL: {:?}", easy.redirect_url().unwrap());

Here page is redirected from http to https (hence first println reports "1"), but redirect_url() reports "None", where it should get https://www.rust-lang.org/

Switched to:
println!("Effective URL: {:?}", easy.effective_url().unwrap());

and it does the job :)

redirect_url is only guaranteed to return something useful if follow_location is disabled.

Looks like this is solved! Feel free to re-open this issue if there's still a problem.


Add c2hs as dependency

I think my build failed because I didn't have c2hs installed, but it's not listed as a dependency. You probably installed it at some other time, and it was in your PATH even if you tested using a fresh sandbox.

It is listed as a dependency in the build-depends field of the cabal file.
Unfortunately, I believe Cabal doesnt automatically install build dependencies so you have to do it manually, see:
https://github.com/haskell/cabal/issues/220

Oh well. Thanks#


Possible issue on this DOC

Hi TEAM. It's my first contribution. Hope I can help.
I think there's an issue with this DOC. In pt-br is different from en-us

In pt-br says:
https://docs.microsoft.com/pt-br/microsoftteams/cloud-recording

Cenário
Etapas

Quero que todos os usuários da empresa possam transcrever ao iniciar a gravação de uma reunião.
Confirme que CsTeamsMeetingPolicy global tem AllowTranscription = verdadeiro.Todos os usuários têm as CsTeamsMeetingPolicy globais ou uma das políticas de CsTeamsMeetingPolicy com AllowCloudTranscription = verdadeiro.

And in en-us says:
https://docs.microsoft.com/en-us/microsoftteams/cloud-recording

Scenario
Steps

I want all users in my company to be able to transcribe when initiating recording of a meeting.
Confirm Global CsTeamsMeetingPolicy has AllowTranscription = True.All users have the Global csTeamsMeetingPolicy OR one of the CsTeamsMeetingPolicy policies with AllowTranscription = True.

And also I think in both cases they want to say: AllowCloudRecording = True
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 976b8a9b-5a3e-1f3b-b848-d1dfbfd3389d
Version Independent ID: 2b13a471-3baf-0086-439a-f94abb162fd6
Content: Teams cloud meeting recording - Microsoft Teams
Content Source: Teams/cloud-recording.md
Service: msteams
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.
@OfficeGlobal Could you kindly help with this issue?

@ancru Thanks for reporting this problem, we have logged a case/ticket to follow up internally.

@scanum


problem with mkdfa.pl

Error on mkdfa.pl with 4.6. No problem with 4.5
$ mkdfa.pl home
home.grammar has 32 rules
home.voca    has 25 categories and 138 words
executing [/usr/local/bin/mkfa -e1 -fg ./tmp17054-rev.grammar -fv ./tmp17054.voca -fo home.dfatmp -fh ./tmp17054.h]
Now parsing grammar file
Now modifying grammar to reduce states[20]
Now parsing vocabulary file
Now making nondeterministic finite automaton[105/105]
Now making deterministic finite automaton[67/67]
Now making triplet list[67/67]
sh: 1: cygpath: not found
sh: 1: cygpath: not found
usage: dfa_minimize [dfafile] [-o outfile]
executing [/usr/local/bin/mkfa -e1 -fg ./tmp17054.grammar -fv ./tmp17054.voca -fo home.dfatmp -fh ./tmp17054.h]
Now parsing grammar file
Now modifying grammar to reduce states[19]
Now parsing vocabulary file
Now making nondeterministic finite automaton[122/122]
Now making deterministic finite automaton[60/60]
Now making triplet list[60/60]
sh: 1: cygpath: not found
sh: 1: cygpath: not found
usage: dfa_minimize [dfafile] [-o outfile]
generated: home.dfa home.term home.dict home.dfa.forward

Just discovered that mkdfa.py working properly

Looks like solved now


Add a hook before dash.js media player initialization

Missing some test changes from https://github.com/videojs/videojs-contrib-dash/pull/75/files#diff-a7f35573a9a8c8e9ca9b2f511f994675R57


Contrast coding not explicitly given

I could not find anywhere in the R code nor accompanying text a specification of the contrast coding. For most factorial designs in psycholinguistics, effect/sum/deviation coding would be more appropriate than the default treatment coding. But in either case, you need to specify in the manuscript the contrast coding because the coefficients are not interpretable without it. Also, you should explicitly convert categorical variables to factors and not just leave them as characters because this can have weird knock-on effects elsewhere.
The default contr.sum in R has a opaque naming scheme, but the car package has an alternative with a more meaningful naming scheme, contr.Sum.
Here's a brief example from my own tinkering:
library(car)
# the sort-decreasing step makes contr.Sum/contr.sum more consistent with other
# contrasts in R and contrasts in Julia
contrasts(d_lmer$trial_type) <- contr.Sum(sort(levels(d_lmer$trial_type),decreasing = TRUE))
contrasts(d_lmer$nae) <- contr.Sum(sort(levels(d_lmer$nae),decreasing = TRUE))
contrasts(d_lmer$method) <- contr.Sum(sort(levels(d_lmer$method),decreasing = TRUE))

Hi Philip,
Thanks very much for your comments. I agree completely about adding
explicit coding information to the ms, and we will do that.
On your other two points:

I honestly have never understood why people prefer to move away from
dummy coding most of the time. Maybe I'm a dummy. Seriously, I find the
additive interpretation of coefficients from dummy coding much more
straightforward. Can you point me towards some arguments, or a
recommendation why a particular alternate coding scheme could be useful
here?
Why convert strings to factors? stringsasfactors=TRUE
https://simplystatistics.org/2015/07/24/stringsasfactors-an-unauthorized-biography/
is a big discussion point. My impression of the tidyverse workflow is to
avoid casting strings to factors whenever possible.

Mike
On Tue, May 21, 2019 at 4:39 AM Phillip Alday<EMAIL_ADDRESS>wrote:

I could not find anywhere in the R code nor accompanying text a
specification of the contrast coding. For most factorial designs in
psycholinguistics, effect/sum/deviation coding would be more appropriate
than the default treatment coding. But in either case, you need to specify
in the manuscript the contrast coding because the coefficients are not
interpretable without it. Also, you should explicitly convert categorical
variables to factors and not just leave them as characters because this
can have weird knock-on effects elsewhere.
The default contr.sum in R has a opaque naming scheme, but the car
package has an alternative with a more meaningful naming scheme, contr.Sum
.
Here's a brief example from my own tinkering:
library(car)# the sort-decreasing step makes contr.Sum/contr.sum more consistent with other # contrasts in R and contrasts in Julia
contrasts(d_lmer$trial_type) <- contr.Sum(sort(levels(d_lmer$trial_type),decreasing = TRUE))
contrasts(d_lmer$nae) <- contr.Sum(sort(levels(d_lmer$nae),decreasing = TRUE))
contrasts(d_lmer$method) <- contr.Sum(sort(levels(d_lmer$method),decreasing = TRUE))
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/manybabies/mb1-analysis-public/issues/4?email_source=notifications&email_token=AAI25F4KSJVB72L6E232T2DPWPNQBA5CNFSM4HOKDJA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GU6D33A,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI25F3O7KZBL23JDQWOSXLPWPNQBANCNFSM4HOKDJAQ
.

It matters for the interpretation of interactions, see e.g. Dale Barr's comments or my (admittedly tedious) worked example for a linguistic manipulation.

When combining and manipulating the data as tables, strings are fine and possibly preferred. But when treating them as variables in a model, then factors are definitely preferred (at least for regression models), because that's the representation the model will actually need. And you can't set contrasts on characters, only on factors. (Although you can somewhat get around that with options(contrasts=...) or using the contrasts= argument in modelling functions that support that. Treating known categorical variables as factors also has certain debugging advantages for variables whose string representation may be mistakenly purely numeric (e.g. participant ID can be numeric). Sure, you can force these things to be strings instead, but that's not actually representing the structure of your data (a finite set of labels rather than a selection of potentially infinite strings).

OK, thanks for this - right now we are using dummy coding and I think we'll stick with that, but I have processed your example and noted this for future work!


Possible switch to using MQuery and MAggregate?

I think monk would be a lot nicer to work with if it used the following query libraries:
https://github.com/aheckmann/mquery
https://github.com/rschmukler/maggregate
Has this been considered before?

I think I prefer this approach: #150


Added Bytebot wikipedia plugin

Added wikipedia plugin

This still cannot be merged as the Plugin contains PEP8 errors

How it can still contain PEP8 error?
We have checked it last and even Travis said its good.
Am 25.10.2016 09:38 schrieb "mkzero"<EMAIL_ADDRESS>
This still cannot be merged as the Plugin contains PEP8 errors
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Bytespeicher/Bytebot/pull/128#issuecomment-255960137,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASzjjJBhsr3LNh-UOwMBP3R9KH0YNA0gks5q3bHxgaJpZM4Kdedo
.

@petrk94: See https://github.com/petrk94/Bytebot/pull/1 - this should fix the last issues with pep8. Just Merge my pullrequest should add my changes to this pull request and travis will be fine.

Hooray;)
@mkzero: Please check again and merge


Remove remaining global config

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
This removes the remaining global configuration. Finally done refactoring!
[WIP] because this still needs to be tested, please do not spend lots of time reviewing yet.
Give a summary of what the PR does, explaining any non-trivial design decisions
There are a few non-trivial things:

The file storage needs to be passed around a bit
The "parse arguments" function was setting the workspace_base variable, I removed this because it seems like a bit of an anti-pattern, but we probably need to make sure this doesn't break things.
I decided to pass in AppConfig to Runtime. I want to avoid using AppConfig as much as possible, as it requires/provides too much information, and obscures which information is actually used by the class. However, runtimes use lots of information and different runtimes use different types of information at the moment, so this seemed necessary to avoid further extensive refactoring.

Other references
Fixes #2758

I have confirmed that tests pass and the app runs on my local machine, I think this is ready to merge!


CMS author is able to create loops in their path

When I'm creating questions and answers, I can create loops in the Pathfinder by setting an answer's "Goes to" value to be a question that preceded that answer's question
Steps to reproduce

Login to the CMS and navigate to a Pathfinder
Create at least 2 questions
Edit the first question, and add an answer that "goes to" the second question
Edit the second question, and add an answer that "goes to" the first question

Actual result
The CMS allows this, and create a loop in the Pathfinder's succession of questions
Expected result
The CMS doesn't allow me to create loops

Fixed in 0.1


Filtering tests by issue

When an issue is reported in the issues box it is very difficult to go from that to the test run that failed. For example, with
https://dashboard.kernelci.org/tree/3106ac6516bafc19c903de63d95b05e149802f7a?tableFilter={"buildsTable"%3A"all"%2C"bootsTable"%3A"failed"%2C"testsTable"%3A"failed"}&origin=maestro&currentPageTab=treeDetails.tests&diffFilter={}&treeInfo={"gitBranch"%3A"linus-next"%2C"gitUrl"%3A"https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fsashal%2Flinus-next.git"%2C"treeName"%3A"sashal-next"%2C"commitName"%3A"v6.12-12007-g3106ac6516baf"%2C"headCommitHash"%3A"3106ac6516bafc19c903de63d95b05e149802f7a"}&intervalInDays=7
there are two warnings in regulator_unregister() but clicking on that (or anything else in the issues list) doesn't do anything - I would have expected that this would do something like filter things down to runs showing the reported issue.

Solved in PR 648 and PR 669


Difference between awsconfiguration.json and amplifyconfiguration.json?

What's the difference between the twos? is awsconfiguration.json even used? Could one remove it?

awsconfiguration.json is the previous configuration file used by the SDKs (https://github.com/aws-amplify/aws-sdk-ios) and Appsync SDK (https://github.com/awslabs/aws-mobile-appsync-sdk-ios). It is not used by the Amplify libraries, and Amplify will use amplifyconfiguration.json

I see, thanks for your explanation. So why does it generate both?

awsconfiguration.json is produced for backward compatibility, so that developer who would like to use the older SDK can import awsconfiguration.json into their app. If your app use only the Amplify apis, you can ignore awsconfiguration.json and just import amplifyconfiguration.json.


[Question] In "dev mode", is configureAccessory() invoked?

Function invoked when homebridge tries to restore cached accessory.
Developer can configure accessory at here (like setup event handler).
Update current value.
-- homebridge-samplePlatform

Should I expect the above-mentioned behavior when I run Homebridge using the following command?
DEBUG=* ./bin/homebridge -D -P ../my-great-plugin/
If so, I'm not seeing the function called ... so then my question becomes, "What might be preventing this expected behavior?"
Thank you!

I have the same question and this issue here is result #1 when coming from google - can anyone clarify?

Homebridge only persists and restores accessories previously exposed by dynamic platform plugins, i.e. platform plugins that, on loading, registered with something like:
registerPlatform('homebridge-xxx', 'Xxx', XxxConstructor, true)

Hi @ebaauw, thanks for taking the time to respond. I use the exact dynamic platform you describe. But: even when I use the sample-plugin freshly checked out from the repo (https://github.com/nfarina/homebridge/tree/master/example-plugins/homebridge-samplePlatform) I see no Configure Accessory entry in the log when running in development mode.

Did you create an accessory through the sample plugin’s web server?  Is the accessory persisted in cachedAccessories when you stop homebridge?

Hi Erik, yes I did and yes it is. :-) I then restart homebridge and see no entries (although the device is in fact restored from cache).

Do you see log entries when controlling the restored device from HomeKit?

Yes I do:
[2019-8-13 00:03:36] [homebridge-samplePlatform.SamplePlatform] 2019-08-12T21:39:16.164Z Light -> true

Then ConfigureAccessory() was called.  The message is issued by the on('set', ...) handler (re-) created by ConfigureAccessory().

Alright, my bad. Everything works as desired. For the record: I used a different platform name in the call to registerPlatformAccessories than I used in registerPlatform. This actually showed in the logs as Failed to find plugin to handle accessory, but because it appeared above the big QR Code, I never bothered to look at it. Thank you again Erik for helping me debug this.


Tab completion for REPL

As a user it would be nice to have tab completion for the REPL, especially for things like actor/provider IDs.  I think a good initial implementation would be upon pressing tab:

Complete any verbs/commands (e.g. link, start actor, get host)
If following a command that expects an argument, refresh a list of actors/providers/etc from the host (depending upon context) and allow completion from the generated list.

Another thought could be to do what Docker does with container IDs where the first 'n' distinct characters work to grab the IDs.

REPL is deprecated, closing this issue


Home page shows flashing page, any other link works

http://www.styleriver.co.il/ <-- doesn't work
http://www.styleriver.co.il/AllBrands.aspx <--works

It's because crawler protection using a javascript cookie, so it's a feature missing in Splash. This is the Splash ticket: https://github.com/scrapinghub/splash/issues/238


fix for undefined var, comma instead of semi-colon

Fix for https://github.com/mikaelbr/node-notifier/issues/81

Thanks! Don't know how this fell through.

Wow, never even noticed this..


"Cannot invert degenerate transform" while loading data

I'm trying to load some Sentinel-2 data I ingested in Datacube :
dc = datacube.Datacube(app='dc-example')
nbar = dc.load(product='s2a_level1c_albers_10', latitude=(-90, 90), longitude=(-180, 180))

I obtain this stack trace :
TransformNotInvertibleError               Traceback (most recent call last)
<ipython-input-5-ce4ec2f4f0a5> in <module>()
----> 1 nbar = dc.load(product='s2a_level1c_albers_10', latitude=(-90, 90), longitude=(-180, 180))

/usr/local/lib/python2.7/dist-packages/datacube-1.1.4+39.ge273fce-py2.7.egg/datacube/api/core.pyc in load(self, product, measurements, output_crs, resolution, stack, dask_chunks, like, **query)
    228         geopolygon = query_geopolygon(**query) or query_geopolygon_like(like) or get_bounds(observations, crs)
    229         resolution = resolution or query_resolution_like(like) or get_resolution(observations)
--> 230         geobox = GeoBox.from_geopolygon(geopolygon, resolution, crs)
    231
    232         group_by = query_group_by(**query)

/usr/local/lib/python2.7/dist-packages/datacube-1.1.4+39.ge273fce-py2.7.egg/datacube/model/__init__.pyc in from_geopolygon(cls, geopolygon, resolution, crs, align)
    631         affine = (Affine.translation(left, top) * Affine.scale(resolution[1], resolution[0]))
    632         right, bottom = float(bounding_box.right), float(bounding_box.bottom)
--> 633         width, height = ~affine * (right, bottom)
    634         if align:
    635             width = math.ceil(width)

/usr/lib/python2.7/dist-packages/affine/__init__.pyc in __invert__(self)
    421         if self.is_degenerate:
    422             raise TransformNotInvertibleError(
--> 423                 "Cannot invert degenerate transform")
    424         idet = 1.0 / self.determinant
    425         sa, sb, sc, sd, se, sf, _, _, _ = self

TransformNotInvertibleError: Cannot invert degenerate transform

Looking in the code of the from_geopolygon function, I see :
...
affine = (Affine.translation(left, top) * Affine.scale(resolution[1], resolution[0]))
right, bottom = float(bounding_box.right), float(bounding_box.bottom)
width, height = ~affine * (right, bottom)
...

The "affine" matrix value is
| 0.00, 0.00,-180.00|
| 0.00,-0.00, 90.00|
| 0.00, 0.00, 1.00|
So effectively it's not inversible.
Looking at how the matrix is generated, it comes from values of left, top and resolution parameters. In my case the values are :
left = -180.0
right = 90.0
resolution = (-0.0001, 0.0001)
So the affine matrix should be :
| 0.0001, 0.00,-180.00|
| 0.00,-0.0001, 90.00|
| 0.00, 0.00, 1.00|
But it seems that the scaling resolution values are rounded to 0 by the Affine library.
Do you confirm this problem?
Or is it a problem with the data, or load function parameters, that should result in different resolution values?
Thanks for the help.
Fabien

I suspect that the 0's along the diagonal are printing rounding, and they are actually 0.0001s.
What version of affine library do you have? We had similar issues with 1.2, but there were some changes in 1.3.0 that 'fixed' that for us.

Updating the affine library from 1.2 to 1.3 effectively fixed the problem.
Thank you


fix: Input widget rehaul final review

Incorporates final review feedback for the Input widget doc.

@spark-c please resolve the merge conflicts


10.0.17134.706 everything green but not working

I installed the RDP wrapper (1.6.2) on one of our Win 10 Enterprise workstations (w/o full internet access) and updated the ini file manually by appending the content of file 10.0.17134.706.txt in repo https://github.com/fre4kyC0de/rdpwrap, containing the following lines:

[10.0.17134.706]
LocalOnlyPatch.x86=1
LocalOnlyOffset.x86=ADAB8
LocalOnlyCode.x86=jmpshort
LocalOnlyPatch.x64=1
LocalOnlyOffset.x64=92521
LocalOnlyCode.x64=jmpshort
SingleUserPatch.x86=1
SingleUserOffset.x86=36B1C
SingleUserCode.x86=nop
SingleUserPatch.x64=1
SingleUserOffset.x64=1511C
SingleUserCode.x64=Zero
DefPolicyPatch.x86=1
DefPolicyOffset.x86=33579
DefPolicyCode.x86=CDefPolicy_Query_eax_ecx
DefPolicyPatch.x64=1
DefPolicyOffset.x64=10E78
DefPolicyCode.x64=CDefPolicy_Query_edi_rcx
SLInitHook.x86=1
SLInitOffset.x86=475DD
SLInitFunc.x86=New_CSLQuery_Initialize
SLInitHook.x64=1
SLInitOffset.x64=22F5C
SLInitFunc.x64=New_CSLQuery_Initialize
[10.0.17134.706-SLInit]
bInitialized.x86      =CBF38
bServerSku.x86        =CBF3C
lMaxUserSessions.x86  =CBF40
bAppServerAllowed.x86 =CBF44
bRemoteConnAllowed.x86=CBF48
bMultimonAllowed.x86  =CBF4C
ulMaxDebugSessions.x86=CBF50
bFUSEnabled.x86       =CBF54
bServerSku.x64        =F1378
lMaxUserSessions.x64  =F137C
bAppServerAllowed.x64 =F1380
bInitialized.x64      =F2430
bRemoteConnAllowed.x64=F2434
bMultimonAllowed.x64  =F2438
ulMaxDebugSessions.x64=F243C
bFUSEnabled.x64       =F2440

After restarting the service with net stop termservice & net start termservice and executing RDPConf.exe, everything seems to be fine (Wrapper state: Installed, Service state: Running, Listener state: Listening, [fully supported]). However, the tool doesn't work as expected.
When I try and log on with another user simultaneously, then the usual message appears saying that another user is currently logged in.

Is there any debug log that I can use to further investigate this issue?

I'm willing to contribute to solving this issue, but I need a bit of start-up support :)

Duplicate of https://github.com/stascorp/rdpwrap/issues/721


chore: update to newest aod cli version

Is it possible to use a var for the version?

Yes, in case when the var is not provided, it has a default. We haven't set those vars yet except for WIF and SA.


Add POST for feedback

Description
Add ability to POST feedback for a video
Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, tested, ready to review and merge

How Has This Been Tested?

[x] Tested case when submitting valid data via Insomnia

[x] Tested case when submitting invalid data via Insomnia

[x] Tested case when submitting invalid owner id via Insomnia

[x] Wrote tests to verify basic functionality (response code, JSON body type)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

 Create POST to submit video feedback


feat(toolbar-search): support auto-filterable rows

Closes #591
Currently, ToolbarSearch does not filter rows provided to the DataTable. This PR adds a shouldFilterRows prop that supports auto-filtering in addition to custom filtering. The use case is to support client-side, in-memory search (e.g., a table with fewer than 500 rows).
By default ,shouldFilterRows is false.
If  shouldFilterRows is true, it will use value  to perform a basic string comparison on cell values that are of a string or a number type.
<ToolbarSearch shouldFilterRows />

For custom filtering, shouldFilterRows accepts a function and passes it the current row and value. It expects the function to return a boolean.
<ToolbarSearch
  shouldFilterRows={(row, value) => {
    // only test the value against a specific cell
    return row.port.includes(value);
  }}
/>

Technically, there is a breaking change, which is flagged when generating documentation.
DataTable rows will no longer be reactive because it is written to a Svelte store and passed down via the "DataTable" context.
Currently, if you bind:rows, an extra field is written to each row called "cells," which is used when rendering the data table. However, this is an acceptable change as row.cells should not be exposed in the first place.

TODO:

[ ] document internal row keys (id, cells)
[x] add basic filterable example (shouldFilter)
[x] add custom filterable example

Released in v0.62.0


Violation code table in README

This would close #1

I'm going to leave this until https://github.com/keisheiled/flake8-implicit-str-concat/pull/9 is merges as the scope of the package will have slightly changed


message.body = body and message.prepare_payload()

See
http://vinniefalco.github.io/beast/beast/using_http/message_containers.html
There you write
Note that this message has a body. The function message::prepare_payload automatically sets...
What does "has a body" mean?
Both messages (req and res) in that example have string_body as template argument. So both have a body which is not empty_body.
But you call prepare_payload() for res only:
res.prepare_payload();
This implies that the assignment
res.body = "Hello, world!";
makes the message to "have a body". Right?
So the rule is:
If you assign a body to the message you should call prepare_payload
?
If so ... have a look at your examples, e.g.
https://github.com/vinniefalco/Beast/blob/v64/example/http-client/http_client.cpp
As you see there is no assignment of the body but a call of prepare_payload()
That might confuse people.
BTW:
If i set a body (currently via assignment to public member variable body) and i should use prepare_payload() later, why not provide a method to set the body?!
That method will protect the better private body member variable and will call prepare_payload() implicit if needed.
So people can't forget calling prepare_payload().
So the body member variable could be private.
So you have control over setting the body.
What do you mean?

Hmm...you are right! The documentation is not clear. prepare_payload is an optional function, you don't have to use it. Its not practical to have a member to set the body, because of how broadly the Body concept is specified (how would you "set" a buffer_body?) So body can't really be private.
Still, you have given me great feedback and I think that the documentation could be better, willfix

Hmm...
You have a public member in message
typename Body::value_type body

If the member becomes private, why we can't provide a method
set_body(typename Body::value_type body)
{
  this->body = body;
  this->prepare_payload();
}

?

prepare_payload is not required and in fact sometimes you don't want it. For example, we never want to call prepare_payload for this case:
https://github.com/vinniefalco/Beast/blob/master/example/server-framework/file_service.hpp#L254
Having a set_body also imposes some annoying restrictions on Body::value_type: It must be movable or copyable, otherwise it cannot be modified. And modification in-place would require moving the value out, performing the modification, and then moving it back in. Consider this code
template<class DynamicBuffer>
void foo(DynamicBuffer& buffer)
{
  beast::ostream(buffer) << "foo\n";
}

template<class DynamicBuffer>
void bar(DynamicBuffer& buffer)
{
  beast::ostream(buffer) << "bar\n";
}

void foobar()
{
  response<dynamic_body> res;
  foo(res.body);
  bar(res.body);
}

How would this work with set_body?

In the example
https://github.com/vinniefalco/Beast/blob/master/example/server-framework/file_service.hpp#L254
there is no
res.body = <something>
So there would be no
res.set_body(<something>)
So there would be no implicit
res.prepare_payload()

The basic idea was: If message has set_body() it has get_body() too.
void foobar()
{
 response<dynamic_body> res;
 foo(res.get_body());
 bar(res.get_body());
}

get_body() simply returns a reference to the body member variable.
But now I have to think about it!! The bad thing is this
res.get_body() = <someting>
or this
res.get_body() += <someting>
etc, which changes the body without calling
res.prepare_payload()
And
res.get_body() = <someting>
is not much better than
res.body = <someting>
I see and will think about it...

The bad thing is this

Yes :)
I think the current scheme is the best we can do. message::body is a simple, public data member. And message::prepare_payload is a function that anyone can call, at any time, to adjust the Transfer-Encoding and Content-Length fields as needed in order to reflect the current state of the body member. You don't have to call it, you can set those fields manually or not at all. This follows the spirit of Beast's low-level approach.
I do agree that the documentation needs to do a better job explaining this - I am working on it right now!


[VL] Fix broken GHA CI cache, add cache for Centos 8 static build

As title, to fix and enable cache to speed up CI build.

@PHILO-HE

@zhztheplayer, one nit. Let's drop "static" in the name of ci-velox-buildstatic-centos-8.sh, since it is not static build for now.

@zhztheplayer, one nit. Let's drop "static" in the name of ci-velox-buildstatic-centos-8.sh, since it is not static build for now.

Just made it buildshared.


Example(6.4) in specification document

We are in the process of testing all of the code fragment examples in the specification document, against the Imperas simulation model, we have a question regarding the example in section 6.4
For the first example, there is no function prototype defined
could you please

describe the expected function arguments
specifically state what values are held in

x10 (note x10 is the equiv of ABI a0, is this a mistake?)

Many Thx
Lee Moore - Imperas

It is just a code sample to show how to write a useful loop.  It isn't meant to be an entire function.
a0 holds the number of elements in the vectors.  a1 is the address of the input vector, which is a pointer to 16-bit elements.  a2 is the address of the output vector, which is a pointer to 32-bit elements.
Yes, the use of x10 looks like a bug.  It would make more sense to use a3 instead.  This would then be the value we are multiplying by.

Hi Jim
Thanks for this, I have this working now
at some point do you want me to send the (working) code back to put in as your examples ?
Thx
Lee

You are welcome to submit a pull request to suggest changes, or file another issue to report the bug.


DPP for diverse pixel sampling

Thanks for your great work on DPPy. I am new to DPPs and this framework and was wondering what would be the correct way of using it for a simple problem setup: Given is a 32 x 32 pixel image. I now want to sample pixels from this image such that they are as diverse as possible (I presume here diversity could be measured in terms of discrepancy when projected back onto the unit square). What would be the correct DPP to use here? I presume I have to use a k-DPP, since I only want subsets of cardinality 2 (i.e., pixel locations)?
I am currently using the following approach:
r, N = 2, 32
Phi = np.random.randn(r, N)
DPP = FiniteDPP('likelihood', **{'L': Phi.T.dot(Phi)})
for i in range(nsamples):
    DPP.sample_exact_k_dpp(size=2)

Unfortunately, this does not cover all pixels even when sampling more than 5000 samples (in contrast to uniform sampling of the pixels). In particular, it seems like it does not sample pixels of form (k,k) for any k=0,...,31 (i.e., on the diagonal of the image). I presume I'm doing something wrong here?
Thanks for your help already in advance.

Hi @tk-rusch,
Thanks for your question.
When using DPPs, it is the very question to select a good kernel / the right kernel for the task at hand.
In your example, you considered a random, unstructured likelihood kernel L with rank 2.
Samples from 2-DPP(L) will be made of exactly 2 pixels
The likelihood of the samples is given here.
You can compute this likelihood for some or even all possible pairs including a diagonal pixel to see whether you just ran out of luck in your 5000 samples or your kernel indeed will never yield diagonal pixels.
You can also consider more structured kernels, see Determinantal Point Processes for Image Processing, Launay et al.. If you wish to sample from complex kernels, you can use this branch https://github.com/guilgautier/DPPy/tree/v1-dev.
More generally, you may get in touch with Ayoub Belhadji who is currently a postdoc at MIT and worked on DPPs.
Cheers


perf: tweak uglifyOptions.js

Removed unnecessary configuration.
Many configurations are already configured by default.
Detail see Options

Thanks for the PR, but these are intentionally left there for explicitness / documentation purposes.

@yyx990803 In addition, I have a question, why should set these configurations to false by default? Is there any special reason?
{
   arrows: false,
   collapse_vars: false, // 0.3kb
   comparisons: false,
   computed_props: false,
   hoist_props: false,
   inline: false,
   loops: false,
   negate_iife: false,
   properties: false,
   reduce_funcs: false,
   reduce_vars: false,
   switches: false
}


adding favicons for build + success

This adds dynamic favicons for "building" and "success". I'            update_favicon("/favicon_success.ico");
m not 100% on the javascript since there was some weird cacheing going on with my binderhub server...not sure how to fix that so it'd be great if somebody else can give the code a shot...
cc @Carreau!

+1.
We'll have to take care of the base_url at some point now that there is one, but let's keep that for another issue.

sounds good - let me know if there's anything else I should do on this PR...else we can iterate on subsequent PRs

I'll merge and deploy tomorrow. Getting late here.


Handle push notification theoretical edge case: when device token is renewed but Ably client doesn't exist

In Ably-java, there is an ActivationContext with keeps a specific token (DeviceTokenDetails) so that it can update Ably servers with the latest FCM registration token whenever it it is expired/ renewed by Android runtime. Because it has this token, it doesn't need an Ably client (rest/ realtime) to currently exist. The only requirement is that an ably client has been instantiated at least once in the whole lifetime of the app since it was installed (assuming the DeviceTokenDetails doesn't expire). This is because the DeviceTokenDetails will be created saved locally for future use when the ably client doesn't exist yet. In ably-java, you just call
ActivationContext.getActivationContext(this).onNewRegistrationToken(RegistrationToken.Type.FCM, s);

However, in Ably-cocoa, there is no such thing that would update Ably with the latest APNs token when it is renewed. In Ably-cocoa, to provide Ably servers with the APNs device token, a realtime or rest client is needed, using ARTPush.didRegisterForRemoteNotifications withDeviceToken: realtime:. This is bad in 2 ways:

It is tedious for developers: after registering for APNs, they must save the deviceToken (in a property) and remember to give it to Ably when they create a realtime/ rest client. It adds complexity when there may be more than 1 Ably client (which client do you use?, does it matter if you give it to both, etc.).
It goes against the Apple documentation. According to Configuring Remote Notification Support,

Each time your app launches, it must register with APNs. The methods to use differ according to the platform, but in all cases it works as follows:
Your app asks to be registered with APNs.
On successful registration, APNs sends an app-specific device token to the device.
The system delivers the device to your app by calling a method in your app delegate.
Your app sends the device token to the app’s associated provider

If a new (and different) device token is provided to the device at app launch, Ably will not know about it until a new Ably client and the [ARTPush didRegisterForRemoteNotificationsWithDeviceToken:plugin.didRegisterForRemoteNotificationsWithDeviceToken_deviceToken rest:rest] method is called with the new APNs device token and the rest/ realtime client.
Also, from Configuring Remote Notification Support:

When a device token has changed, the user must launch your app once before APNs can once again deliver remote notifications to the device.

If the device token changes while your app is running, the app object calls the application:didRegisterForRemoteNotificationsWithDeviceToken: delegate method again to notify you of the change.

This is the same behaviour as Android, and I believe was one reason why ActivationContext was implemented in ably-java/ ably-android. @paddybyers
TLDR
We do not handle a theoretical edge case: when the device token is changed on iOS but the Ably client has not been created. Theoretically, it can change. I think its debatable if we handle this github issue/ case, because it may never change (this is not well documented). By making ARTPush.didRegisterForRemoteNotifications or similar method which does not require a client, it would be easier for users to implement. It will also be more consistent with ably-java.
┆Issue is synchronized with this Jira Uncategorised by Unito

I agree, we should free users from calling ARTPush.didRegisterForRemoteNotifications(withDeviceToken:realtime:) manually.


Translation: Japanese

Repository: https://github.com/ja-opensource-guide/ja-opensource-guide.github.io
Preview: https://ja-opensource-guide.github.io/
Locale: ja-JP

[x] Merge the i18n branch into gh-pages and push the branch to your fork. This should build the website and it should be visible at the preview url above.
[x] Update title, description, and locale in _config.yml
[x] Copy _data/locale/en-US.yml to a new file with the name of your locale and translate the strings
[x] Create a new directory in _articles/ for your locale and translate each guide:

[ ] best-practices.md
[ ] building-community.md
[ ] code-of-conduct.md
[ ] finding-users.md
[ ] getting-paid.md
[ ] how-to-contribute.md
[ ] leadership-and-governance.md
[ ] legal.md
[ ] metrics.md
[ ] starting-a-project.md

[ ] ??? TODO - other steps here
[ ] Update CNAME to include your locale (e.g. de.opensource.guide)

Once a translation is completed:

[ ] Open a Pull Request on the upstream repository to add your fork to translations in _config.yml

I'm planning to manage the status of the translation progress on https://github.com/ja-opensource-guide/ja-opensource-guide.github.io/issues/1.

@watilde I am not sure the status of it. Do you need help?


ENH: dipole to MNI space

Reference issue #3525.
Adding this method to Dipole should make it clear how to convert dipoles coordinates to MNI space.
This is already mentioned in the tutorial, although I think it is more convenient this way.

I know this is still marked as draft, but FYI these are some of the issues on the CI so far:
WARNING: [numpydoc] Validation warnings while processing docstring for 'mne.Dipole.to_mni':
  PR01: Parameters {'subject', 'subjects_dir', 'verbose'} not documented
  PR02: Unknown parameters {'%(subject)s', '%(subjects_dir)s', '%(verbose)s'}
  PR07: Parameter "%(subject)s" has no description
  PR07: Parameter "%(subjects_dir)s" has no description
  PR07: Parameter "%(verbose)s" has no description

Thanks @vagechirkov !


json: avoid testing a 3-byte utf8 code-point that mismatches expectations in a future protobuf library upgrade

Commit Message: The next protobuf upgrade will break a few JSON-related tests, mostly due to brittle dependence on error-message syntax. However this one is a consistency check for serializing 3-byte utf-8 code-points, and there is one that is serialized differently in the new version of the protobuf library than the previous one.
Additional Description:
Risk Level: low
Testing: test/common/json/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

This was fixed on the protobuf side.


send_email auth hook email_change does not contain token

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
I don't know if it's a local only bug, but when using a custom auth hook for send_email and when email_data.email_action_type is email_change, email_data.token is an empty string.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Setup a HTTP send_email auth hook
Make sure a user is logged in
Update the email (supabase.auth.updateUser({ email }))
In the custom auth hook, log the data received. Here is an example:

{
  user: {
    id: '0386027a-a39a-45a3-a75e-473c3c888360',
    aud: 'authenticated',
    role: 'authenticated',
    email<EMAIL_ADDRESS>    email_confirmed_at: '2024-08-22T07:27:11.394655Z',
    phone: '',
    confirmation_sent_at: '2024-08-22T07:26:55.521605Z',
    confirmed_at: '2024-08-22T07:27:11.394655Z',
    new_email<EMAIL_ADDRESS>    email_change_sent_at: '2024-08-22T07:36:24.467158Z',
    last_sign_in_at: '2024-08-22T07:27:11.399789Z',
    app_metadata: { provider: 'email', providers: [ 'email' ] },
    user_metadata: {
      email<EMAIL_ADDRESS>      email_verified: false,
      phone_verified: false,
      sub: '0386027a-a39a-45a3-a75e-473c3c888360'
    },
    identities: [
      {
        identity_id: 'a2433b21-80f8-4c2b-8425-49076082f2fc',
        id: '0386027a-a39a-45a3-a75e-473c3c888360',
        user_id: '0386027a-a39a-45a3-a75e-473c3c888360',
        identity_data: {
          email<EMAIL_ADDRESS>          email_verified: false,
          phone_verified: false,
          sub: '0386027a-a39a-45a3-a75e-473c3c888360'
        },
        provider: 'email',
        last_sign_in_at: '2024-08-22T07:26:55.51048Z',
        created_at: '2024-08-22T07:26:55.510545Z',
        updated_at: '2024-08-22T07:26:55.510545Z',
        email<EMAIL_ADDRESS>      }
    ],
    created_at: '2024-08-22T07:26:55.501756Z',
    updated_at: '2024-08-22T07:36:24.991146Z',
    is_anonymous: false
  },
  email_data: {
    token: '', // <------ HERE
    token_hash: 'pkce_7f5214d4e090e25816b5b073f7638aa4ca747ab1de65b7c5174a62bf',
    redirect_to: 'http://localhost:8888',
    email_action_type: 'email_change',
    site_url: 'http://<IP_ADDRESS>',
    token_new: '',
    token_hash_new: ''
  }
}

Expected behavior
email_data.token should contain a value. It works when using an email template instead of an auth hook.
System information

OS: Windows 11
Version of supabase: 1.190.0
Version of supabase-js: 2.45.1
Version of Node.js: 20.11.1

Thanks for reporting the issue. We're looking into this


Less certain language for multi-contributor repos

Closes https://github.com/github/choosealicense.com/issues/503

See my comment on #503. I do appreciate the idea and effort in expressing it!


Add Yii::t

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues

If I remember correctly we don't translate exception messages. Can anyone confirm it either way?

@bizley nope, https://github.com/yiisoft/yii2/blob/master/framework/messages/ru/yii.php

Yes, we don't do that. @ripaym1970 you must handle the translation in your application yourself.


API for updating questions for registrering a meeting

Added support for the API Meeting Registrants Questions Update.

Thanks for contributing! Hint has given me some dedicated time to getting this gem maintained so I'll handle writing some tests for this. Just go ahead and grab master if you need this functionality immediately. I'll get a new gem version up on rubygems soon.

Thanks for contributing! Hint has given me some dedicated time to getting this gem maintained so I'll handle writing some tests for this. Just go ahead and grab master if you need this functionality immediately. I'll get a new gem version up on rubygems soon.

I would be glad to contribute to the tests. Let me know if I could help you.
Thanks

Yeah if you want to write some test that would be great. 👍 Thanks in advance


Sparse matrices written with 32bit indptr

Please make sure these conditions are met

[X] I have checked that this issue has not already been reported.
[X] I have confirmed this bug exists on the latest version of anndata.
[X] (optional) I have confirmed this bug exists on the master branch of anndata.

Report
Sparse matrices are currently being written with 32bit indptrs. They should be written with 64bit indptr so that we can append to them freely.
In particular, this is causing problems when writing large dask arrays where each chunk has an indptr that can fit in 32bit indices.
I could have sworn we were always writing matrices with 64 bit indptr, but need to check that. I'm not sure when this would have changed. I think it would have been quite easy to miss since it's difficult to test without using more memory/ disk space than our CI typically allows.
Versions
In 0.10.4 and main branch

Thinking about less aggressive ways of fixing this rather that always writing 64 bit:

SparseDataset.append can check whether we're going to overflow and either error or rewrite

Sorry @flying-sheep , missed your comment. I think it's performance in the sense of "high performance computing" in that in only comes up with very large dataset size. But also things will be faster if we're 32bit whenever we can.

As a workaround when using dask with sparse chunks right now, you can run:
    def with_int64_indptr(x):
        x.indptr = x.indptr.astype(np.int64)
        return x
    elem = elem.map_blocks(with_int64_indptr, dtype=elem.dtype)

To write with 64bit indptr.

This workaround gives me the same ValueError: Output dtype not compatible with inputs error as in https://github.com/scverse/anndata/issues/1349  when I try to persist.
def with_int64_indptr(x):
    x.indptr = x.indptr.astype(np.int64)
    return x
elem = elem.map_blocks(with_int64_indptr, dtype=elem.dtype).persist()

@mumichae, I suspect that may be more related to https://github.com/scverse/anndata/issues/1349

We've sorta solved this for dask arrays. We also now throw an error if you try to append too much to one of these.


Save collection to bookmarks

Reopened from #59 - Implements the project roadmap's card "Add a collection to the bookmarks"

[x] Adds a user-facing button to add a collection to the bookmarks, using the SaveCollectionAsBookmarks() function defined in #48

[x] Rework the tree to have sets saved as subfolders of a "Tabs Aside" folder

[x] Include an unique string (the creation date ?) along with the collection name so that 2 different collections do not get merged

Edit by @XFox111:
TODO: Update translations:

[x] RU
[x] IT (Google Translate)
[x] PT_BR
[x] ES (Google Translate)
[x] ZH_CN (Google Translate)

This should not be too difficult to get back on this, I'll set myself a reminder to complete this feature this week. (With the exception of the translations.)

Here you go ! I added machine translations for the missing ones for good measure, but of course human translations would be better.


No more landscape splashscreen on iOs

I used ionic resources ios to generate splash screen.
The command didn't generate landscape splash screens, but it did in the past, is it normal ?
My app has different splash screen in landscape or portrait format.

Greetings @loicfavory!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Can you check to see what your orientation setting is set to in your config.xml?

I just used ionic resources and notices the exact same issue. My config.xml shows no orientation setting? What should it be?

Greetings @loicfavory!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


ISPN-10335 Use stub for PersistenceManager when no stores are configured

https://issues.jboss.org/browse/ISPN-10335

@danberindei this PR should help alleviate some of the test suite leaks - others will still remain, have to narrow those down still.

Unused import @wburns, otherwise looks good

Fixed import.

Integrated, thanks Will!


Seq.groupBy() preserving insertion order: guaranteed or accident of implementation?

I notice that Collections.groupBy() creates a LinkedHashMap, which preserves insertion order when classifying items by their new key. Is this intended to be guaranteed or is it merely an accident of implementation? If it is intended to be guaranteed, then I would like to add those details to the documentation and perhaps check whether any tests are needed to reflect this guarantee.
Mostly, I would like to assess my risk in assuming that the various groupBy() implementations will preserve insertion order in the future.

I can't say for certain since I'm not the one that wrote it, but usually maps are unordered, so the apparent ordering within LinkedHashMap would be by chance.

By this I assume you mean Traversable.groupBy. Since this returns a Map of Traversables, neither of which guarantee order, I would assume that any apparent ordering is a coincidence. Furthermore, I would consider it a coincidence that it returns a LinkedHashMap because neither the method signature nor the documentation guarantees this.


[publish] dpmpy publish

While Publishing Datapackage, Got the following error.

Original error was: ValueError('No JSON object could be decoded',)
Invalid JSON response from server

Duplicate of https://github.com/frictionlessdata/dpr-api/issues/2 url endpoint on the server should be changed to /api/package/{publisher}/{dpname}


Running the set finder locally sans container

When I run the set finder locally without the container, I usually do from a Jupyter notebook using the "%run" command. This maybe is not best, but in any case it's how I've been doing things. Any case, this messes with how the arguments come in. The zeroth argument is the file that gets run. So "main" in getAllSets.py wants there to be 2 or fewer arguments to use the branch where it uses the non-AWS approach to assign arguments and run.

This was resolved some time back.


添加桌面文件预览

Description of the new feature / enhancement
目前的版本已经实现资源管理窗口的文件预览功能了，要是能实现在桌面敲击快捷键打开文件预览就好了

Scenario when this would be used?
桌面使用快捷预览文件
Supporting information
No response

OP would like to add the Peek shortcut to the desktop, but 🤨 can’t we do that since the very birth of Peek? At least I’m able on the recent PowerToys version.
Could also be inteference with other apps (Supporting information: No response)
@sanbu3 请再看看在桌面上用不用的了快捷键，试试更新PowerToys，以及检查是否有摆弄桌面的其它程序。

Hey! I'm not sure what's being asked here. I'm able to use PowerToys Peek on my desktop to preview files. I just make sure the file is highlighted and then hit the "Ctrl + Space" shortcut, and the Peek preview window appears.
If what you're asking for instead is that Peek be invokable as Desktop shortcut, I'm not even sure what that means or how that would work?
/needsinfo


Line chart overshoots points at sharp turns

I'm having this issue where the line chart is overshooting by a lot, vertically, when the turns are sharp. It's kind of hard to explain but if you take a look at this screenshot hopefully it's a bit easier to understand - the overshoots are circled in blue.
(ignore the array index - chart year mismatch, the indices are not meant to correspond to the years)
http://i.imgur.com/49YXw1K.png
The above is just one example, this problem is occurring consistently for me in a lot of places.
My chart options are as follows; pretty simple and nothing fancy...
var options = {
	width: width,
	height: height,
	showPoint: true,
	chartPadding: {
		right: 30 // so the labels on the far right don't get cut off
	},
};

Has anyone ever encountered this problem, or have any suggestions as to how I can approach it? I've been racking my brains all day on this and can't figure it out at all.

The thing with cardinal spline smoothing is that it looks very nice but it can create artifacts on rapid value changes. Try using simple interpolation as shown in the "LINE INTERPOLATION / SMOOTHING" exanple on the chartist example page.

Hey, thanks! That fixed the problem perfectly.

Oh, one question: could you explain what the divisor field in the simple interpolation means?

Search the API docs for interpolation simple. Youll find all the information there. Cheerd

Did you find the information? Please re-open if you're still having issues.


[ownership] (SharePoint) Documenting SharePoint support and team ownership

Scripts will be able to be saved on SharePoint sites, letting teams co-own them.

Docs Build status updates of commit 2e60f06:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/script-storage.md
:bulb:Suggestion
View
Details

docs/develop/external-calls.md
:white_check_mark:Succeeded
View

docs/develop/power-automate-integration.md
:white_check_mark:Succeeded
View

docs/overview/script-storage.md

Line 49, Column 229: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /microsoft-365/compliance/retention-policies-sharepoint?view=o365-worldwide. Otherwise, remove the view parameter.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thanks @peronald! I've updated the PR based on your feedback.

Docs Build status updates of commit ef31107:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/script-storage.md
:bulb:Suggestion
View
Details

docs/develop/external-calls.md
:white_check_mark:Succeeded
View

docs/develop/power-automate-integration.md
:white_check_mark:Succeeded
View

docs/overview/script-storage.md

Line 49, Column 229: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /microsoft-365/compliance/retention-policies-sharepoint?view=o365-worldwide. Otherwise, remove the view parameter.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9ac92c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/external-calls.md
:white_check_mark:Succeeded
View

docs/develop/power-automate-integration.md
:white_check_mark:Succeeded
View

docs/overview/script-storage.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2aa4d4d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/external-calls.md
:white_check_mark:Succeeded
View

docs/develop/power-automate-integration.md
:white_check_mark:Succeeded
View

docs/overview/script-storage.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Cleanup motion app after the refactoring of the users app

rename person in the field submitter and supporter
remove the tables, if it can be done with a many2many field
remove or check the property supporters

This is done


Add vim to base image

I tried out the javascript-node:12 image, imported my git config but since it uses vim as the editor, I could't use it from the command line. I see the nano editor is present so could we add vim also

vim-tiny will be there in the next release. However vim itself is fairly large so don't plan to add it by default. Can you can try out the current development mcr.microsoft.com/vscode/devcontainers/javascript-node:dev-12 to see if that works for you?

Is the problem that you are using vim as the command? We could add vim.tiny as an alternative to work around that.


Add github training on-demand

This pull request adds a link to GitHub's On Demand Training.

Thank you @brianamarie! Appreciated. :-)

Great, thank you @phillipadsmith 🙇
As you maintain this resource, if you ever feel there's a need for specific Git or GitHub content, always feel free to ping me. The training team at GitHub is eager to produce more content like this.

As you maintain this resource, if you ever feel there's a need for specific Git or GitHub content, always feel free to ping me. The training team at GitHub is eager to produce more content like this.

Great to know, @brianamarie, thank you! :-)


ModuleNotFoundError: No module named 'pgvector.psycopg2'; 'pgvector' is not a package

I have installed and imported both pgvector-0.2.3 and  psycopg2-2.9.9 but on importing below register vector i get the error as follows:
from pgvector.psycopg2 import register_vector
ModuleNotFoundError: No module named 'pgvector.psycopg2'; 'pgvector' is not a package
It was working few months ago. Has there been any change?

I have installed and imported both pgvector-0.2.3 and psycopg2-2.9.9 but on importing below register vector i get the error as follows:
from pgvector.psycopg2 import register_vector ModuleNotFoundError: No module named 'pgvector.psycopg2'; 'pgvector' is not a package
It was working few months ago. Has there been any change?

I met the same error, how do you resolve that?
thanks!

Make sure your file isn't named pgvector.py (otherwise, it conflicts with the package).

Make sure your file isn't named pgvector.py (otherwise, it conflicts with the package).

Thank you so much, , that's exactly the issue.


Variable scope leaking

$ cat index.html
{{ isdef title }}

{{ fill title }}

{{ end }}

$ cat post.md
@def title = "Title in post.md"

$ cat config.md
@def title = "Title in config.md"

$ cat __site/index.html

Title in post.md
       <---  ???

Thanks, the expected behaviour is Title in config (always); I'm assuming that you're seeing sometimes one sometimes the other? this is because when processing *.html files  the dictionary of local variables they have access  to is not set properly; this is a simple issue to fix;  thanks for reporting!

Yea, it is a bit random which one shows up.


TiffCompression.jpeg support for decode

It would appear that the TiffCompression.jpeg is not supported.
Any plans to support this, I got an error on the first multipage tiff I tried to decode as a result of this throw, tiff-image.js@551.

To be honest, I can try to look at it when I have time, but I'm not sure if it can be done quickly, and if it can be done at all in the near future.
But could you please provide an example file of such an image that you have a problem with? Thank you!

Hi @kariudo!
To be honest, I can try to look at it when I have time, but I'm not sure if it can be done quickly, and if it can be done at all in the near future.
But could you please provide an example file of such an image that you have a problem with? Thank you!


IntelliSense: Drill in on callback?

From @unional on April 14, 2016 23:32

I would be great if when tape((<cursor>)) it would be able to drill in the tape.TestCase and show the signature of the callback. :tulip:
This is probably on tsc, but let's start here. :smile:
Copied from original issue: Microsoft/vscode#5284

Yes, hint is computed by Salsa/TypeScript. Moving to TypeScript.

We will need to see if the current expression is a parenthesized expression and should the signature help at the first parameter position instead of the main call expression.

I'm having issues reproing this bug.
@unional, Could you please let me know what the definition of tape.TestCase is ?

For example:

interface Callback {
  (a: string, b: string): void;
}

function foo(cb: Callback) {
}

foo(())

Thanks! The example provided is indeed helpful.

Looks like you'd only do this if you have a single-call signature. Otherwise it doesn't really make a ton of sense to do so.

It is used quite a lot in typings. For example
https://github.com/types/npm-bluebird/blob/master/bluebird.d.ts#L86
you would be templated to create:
interface SomeCallback {
  (err: any, value?: R) => void
}

so you can reuse them on those functions.
One example:
https://github.com/types/env-node/blob/master/6/node.d.ts#L850

Sure, I've had this experience as well, so I definitely understand the advantages. I'm just mentioning that if you have any members other than call signatures, or if you have any overloads, we should not use the shorthand.

Daniel, maybe I'm not understand what do you mean on the single call signature.
It does seem that we are on the same page :).
I just want to understand what do you mean so I may learn some new things :smile:

Sure thing @unional. All objects have a set of members. These aren't the same things as properties. A property is a type of member, but members also include:

call signatures
construct signatures
index signatures

The thing that allows a type to be callable is a call signature. You might already be familiar with call signatures if you've thought about overloads.
Here is an example of a type with a single call signature:
interface Foo {
    (hello: string, world: number): void;
}

If I have something of type Foo, I can call it with a string and number.
let f: Foo = /* ... */;

f("hello!", 100);

You can also have multiple call signatures.
interface Foo {
    (hello: string, world: number): void;
    (hello: string): void;
}

If Foo was declared like that, you could have also called f like so:
f("hello!");

We have two different shorter ways of writing things with call signatures. One place is method members.
If you have something like
interface Bar {
    m(): void;
}

Here, Bar is actually equivalent to
interface Bar {
    m: {
        (): void;
    }
}

Meaning that Bar has a property named m, which has a single call signature.
Another short-hand that we use is arrow function types. These are just objects with a single call signature.
In other words, if you've ever seen (x: number) => void, that's actually just an easier way of writing the type { (x: number): void }.
Which is why I think that if you have an interface type with no members apart from a single call signature, we should consider showing the arrow function notation.

For more about call signatures, you can check out the language spec too: https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#3.9.2

@DanielRosenwasser many thanks! Great examples. Especially that Bar and the arrow function one. Didn't know function signature is expanded to a property with single call signature (in this case). It does make a lot of sense.


temp fix for cc wallet for testing usage

wallets is a array not directory indexed by wallet_id use filter function to pick it .

thank you.
we are going to handle cc wallets in a different way. therefore I am closing this PR


Installation 1.3.7 within pyjoulescope_ui failed

Installing the driver fails when installed with:
git clone https://github.com/jetperch/pyjoulescope_ui.git
cd pyjoulescope_ui
python3.10 -m venv .venv
source .venv/bin/activate
pip install -U -r requirements.txt

Reported Error:
Collecting pyjoulescope_driver<2.0.0,>=1.3.7
  Downloading pyjoulescope_driver-1.3.7.tar.gz (2.7 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.7/2.7 MB 12.2 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [15 lines of output]
      Traceback (most recent call last):
        File "/home/sven/install/joulescope/pyjoulescope_ui2/.venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/sven/install/joulescope/pyjoulescope_ui2/.venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/sven/install/joulescope/pyjoulescope_ui2/.venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-jouiabvd/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 341, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/tmp/pip-build-env-jouiabvd/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 323, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-jouiabvd/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 338, in run_setup
          exec(code, locals())
        File "<string>", line 34, in <module>
      ModuleNotFoundError: No module named 'pyjoulescope_driver'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

System: Ubuntu 22.04

Hi @satirebird and thanks for reporting this issue.  I confirm that python3 -m pip install pyjoulescope_driver gives the same error with a clean venv on Ubuntu 22.04 LTS.  That error is entirely unhelpful, so I will have to investigate.  Python packaging recently obsoleted the python setup.py` method, so I suspect that this is related.
In the meantime, here is a process to build and install from source:
python3 -m venv ~/venv/tmp
. ~/venv/tmp/bin/activate
pip3 install Cython numpy requests setuptools wheel
cd {path/to}/joulescope_driver
python3 setup.py bdist_wheel
pip3 install dist/pyjoulescope_driver*

Same as this issue:

Fixed in 1.3.9.


Reduce code / allocations when printing Exprs

Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/issues/6677
Rationale for this change
Using a macro to format Vec's of Exprs adds more code and it does a bunch of allocations (both String and Vec) that we can avoid.
See  https://github.com/apache/arrow-datafusion/pull/6708#discussion_r1236829200 for more context
What changes are included in this PR?
Change macro to functions and impl Display
cc @parkma99
Are these changes tested?
Yes, by existing tests
Are there any user-facing changes?

I am a beginner of Rust. I have no thoughts on this.😊

I have no plans to pursue this PR at this time, so closing it


fix: serialize user-defined window functions to proto

Which issue does this PR close?

Closes #13401.
Rationale for this change

Same as #13401.
What changes are included in this PR?

Serializes user-defined window functions to proto
Adds codec methods to PhysicalExtensionCodec:

pub trait PhysicalExtensionCodec: Debug + Send + Sync {

    fn try_decode_udwf(&self, name: &str, _buf: &[u8]) -> Result<Arc<WindowUDF>> {
        not_impl_err!("PhysicalExtensionCodec is not provided for window function {name}")
    }

    fn try_encode_udwf(&self, _node: &WindowUDF, _buf: &mut Vec<u8>) -> Result<()> {
        Ok(())
    }
}

Are these changes tested?
Yes, roundtrip physical plan for,

An existing user-defined window function and,
A user-defined window function with a custom payload and implements PhysicalExtensionCodec.

Are there any user-facing changes?
No.

I just merged up from main to fix conflict.

Thanks again @jcsherin


Typo "639" should be "6379" in the remote port

@DazWilkin Thanks for catching and fixing that issue, Daz!
Please let us know when you've signed the CLA, so that we can accept the fix. See CONTRIBUTING.md for more information.


Queue and Priority Queue concept in c++

Select the Day of Content
Day 18
What information is missing?
The Day 18 folder consists of doubly linked list and stack. It is better to include queue and priority queue concepts in this folder. I will explain their functionality along with the code and solve some example problems. Please assign this issue to me.

Please assign this issue to me.


Dice Roll

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like

After reading feature request #82 I thought of a similar feature that could be added as well being also a good base for said request's implementation:
Adding some command to throw a dice, maybe a solution similar to Roll20's dice system, something like:
!dice <number_of_dices>d<number_of_faces>
Ex: !dice 2d6 would ask the bot to throw two six-faced dices.

Also, I could work on this one.

I think this would be a neat addition! By the way, I'd also like for some limits to be in place for this one, including a reasonable limit for the number of dice and the number of sides.

@all-contributors please add Thromax for ideas

I've tried coding this one myself, could I be assigned so I can send a pull request?


Extension of Dialogs is not possible due to design and missing exports

Release number or git hash: v4.0.0-beta.1

Observed behavior

Example: If I want to customize the StringFilterDialog to not show the Regular Expression checkbox, I have to copy the entire dialog and remove the checkbox "manually".

Copying is problematic because it duplicates code
Copying is barely possible because many internal utility functions are used in the dialogs which should not be exported
Inheritance is not possible because:

the dialogs are not exported
the dialogs do not offer functions such as show|hideRegexCheckbox (which is fine, but should be implementable in the subclasses)
the relevant inputs are usually accessed by a querySelector, such that subclasses cannot access this.regexCheckbox without the chance of breaking in the future

Expected behavior

Example: I want to have the StringFilterDialog without the Regular Expression checkbox (should be checked by default) and without the Filter missing checkbox (should be checked if the filter itself is not empty).

The following is an example how it could look like:
export default class SimpleStringFilterDialog extends StringFilterDialog {

  protected updateFilter(filter: string | RegExp | null, filterMissing: boolean) {
    // Set the filterMissing to true if filter is truthy
    super.updateFilter(filter, Boolean(filter));
  }

  protected build(node: HTMLElement) {
    super.build(node);
    // Hide the filterMissingCheckbox and regexCheckbox checkboxes
    // Note: currently, they might refer to the actual checkbox and not to the "container" with the label. Maybe add filterMissingCheckbox[Container] to this?
    this.filterMissingCheckbox.style.display = 'none';
    this.regexCheckbox.style.display = 'none';
    this.regexCheckbox.checked = true;
  }
}

In reality this is not possible because:

StringFilterDialog and all other dialogs are not exported

Solution: Export it in own namespace dialogClasses and dialogUtils like the renderers (https://github.com/lineupjs/lineupjs/pull/207)

updateFilter (or the equivalent in other dialogs) is private

Solution: Changing it to protected should not cause any issues

this.filterMissingCheckbox and this.regexCheckbox do not exist yet, as they are currently accessed via this.findInput('input[type="checkbox"]') or the internal utility function findFilterMissing(this.node), making it nearly impossible to access them in a clean way in subclasses.

Solution: Create protected members for the important UI elements of a dialog to allow the subclasses to modify them.

Alternatively, it would be much nicer to have functions such as setRegexCheckbox(boolean) or even allowing options to be passed in the constructor, but that would assume that people often use these dialog APIs, besides the massive refactoring. I think it is better to allow developers to access the internals in a safe and easy way, such that they can implement it themselves.

This is just a simple example, but it should generalize to all other dialogs as well.
I would appreciate any input/discussion about a better way to accomplish the task(s) above.

Related to this is my change request in https://github.com/lineupjs/lineupjs/pull/334#issuecomment-639560277 point 2.

why not just implement the whole dialog in this case as in https://codepen.io/sgratzl/pen/XWXmWQR?editors=1010

@sgratzl That's exactly how it was implemented prior to LineUp4. But with the update to LineUp4 every dialog broke because of the new functions such as cancel and reset. Therefore, we had to update all the dialogs although they only change minor things (checkbox hiding, default checking, ...).
With the ability to extend existing dialogs, we will not have this problem in the future, and we will always be in sync (except for minor updates on a per-dialog basis).
I understand that it has to be carefully decided if a dialog is supposed to be a completely new dialog, or just the extension of an existing one. But the main use case, the minor adjustment of a dialog, would be easily possible with the above solution.
Another example would be the hiding of the Filter Missing checkbox in the CategoricalFilterDialog. Reimplementing it from scratch is rather difficult, as many dependencies are also marked internal such as https://github.com/lineupjs/lineupjs/blob/lineup-v4/src/model/internalCategorical.ts#L174-L193. One can not be expected to copy all dependencies in your own codebase, as this will cause many problems in the future by being out of sync, etc.
The point is that we want to do minor adjustments, which are not worth the trouble (and problems...) of reimplementing an entire dialog including sort/filter/rendering logic.

@thinkh so what is the plan?


feat: Add Lab CI/CD folder

Also disables the OPA check for now. We need to be able to trigger it per folder... I need to resolve that separately.
Part of: https://github.com/operate-first/support/issues/113

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign tumido after the PR has been reviewed.
You can assign the PR to them by writing /assign @tumido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tumido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [tumido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


How to generate the train and test fold on cub_200-2011

Thanks for your nice work! How to generate the train and test folders on cub_200-2011 when run the codes directly.

Hi,
There is a train_test_split.txt file in the folder of the data package from the official link .
You can split the data according to the  train_test_split.txt.
Or just follow the related cub_200-2011 preprocessing repo.


fix(stepper): avoid breaking change in stepControl type

In #15134 we reworked the stepper not to depend on @angular/forms under the assumption that our limited FormControl interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the stepControl type to avoid the breaking change.
Fixes #15462.

This is still a breaking change for us since FormControlLike is not exported. We depended on this being AbstractControl in one of our methods to mark all child controls as touched, and now the only option we really have is to cast the FormControlLike to `AbstractControl. Is that the recommended option?


Add TypeScript Definition

Hello,
Good Tool, can you add a TypeScript Definition for use with *.tsx files.
Thanks
Gi

Is this what you are after? @arunoda you can maybe add it? Or do you want a PR?
declare var module: any;

declare module "@kadira/storybook" {
  interface Story {
      add (storyName: string, callback: Function): Story;
  }

  export function storiesOf(name: string, module: any): Story;
  export function action(name: string): void;
}

You also need to extend your definition of webpack.config.js to following. @arunoda, resolving jsx should be supported by default in my opinion.
const path = require('path');
module.exports = {
  module: {
    resolve: {
      extensions: ['', '.js', '.jsx']
    },
    loaders: [
      {
        test: /\.jsx?$/,
        loader: 'babel',
        query: { presets: ['react', 'es2015', 'stage-2'] },
        exclude: [path.resolve('./node_modules'), path.resolve(__dirname, 'node_modules')],
        include: [path.resolve('./'), __dirname],
      },
      {
        test: /\.css?$/,
        loaders: [ 'style', 'raw' ],
        include: path.resolve(__dirname, '../')
      }
    ]
  }
};

Hmm, resolving does not seem to work .. not sure why .. the jsx files are not resolved ;(

@tomitrescak I am not good with TS, yes send me a PR.
Also add .configure() method as a definition.
BTW, how TS and .jsx extentions are related?

tsx are compiled into jsx in some configurations (e.g. mine). I am not using typescript loaders or typescript compiler in Meteor, but am compiling TS files into JS. This is faster and more controllable.

Okay. got it.
I took the jsx PR and now in master.
Will do a release in few hours.

BTW: could you work on the TS definition file. Not sure where to add it.

Thanks guys!
The best place for typescript definition  is on the definitelytyped site.
http://definitelytyped.org/
it's a catalogue for typescript definition.

@Gi972 I submitted a pull request, yet they need to include a test file with it as well. And I have noo idea what to put in those tests. Have you done a PR there before?
I also have a full d.t.s definition for Mantra ready, which I'm using personally and I can share it .. yet again .. no idea what tests should be there.

Another problem is that storybook does not have a npmjs page, therefore it is not recognised by the DT CI workflow.

We have a NPM page.
See: https://www.npmjs.com/package/@kadira/storybook/

Yea, I know, but the silly CI scrip only check for high level npmjs addresses such as https://www.npmjs.com/package/storybook/

hello Tomitrescak , I never make PR before, I don't know how it works.
For the test , I think you have already tcheck it : http://definitelytyped.org/guides/contributing.html#tests
It's right, I never saw the npm module name like @username/module-npm-Name  I think it's not very conventional.
Does you think rename it  like it:   https://www.npmjs/package/storybook after @arunoda ?
It will better for the future not for only this case.

@Gi972 yes it not. That's something NPM introduce recently. This is very important because of the recent NPM related issues.
If that user have used a scoped package, there may not such an issue.

How far are you with supporting .tsx files?
In my .storybook/webpack.config.js I have the following configured for typescript files:
const path = require('path')

module.exports = {
  module: {
    loaders: [
      { test: /\.(ts|tsx)$/, loader: 'ts-loader' }
    ]
  }
}

However, it does not seem to work. Sad panda.

Definitely Typed is deprecated in favour of https://github.com/typings/typings. It's much easier to add to.

Great catch! I'll add it as soon as I'll have a bit of time.

@camwest I simply do not have the time. Yet, @arunoda, if you make the typings part of your package (above), it can be easily added to the typings repository.

@tomitrescak You mean, use typescript?

No, making the typescript definition as a part of the package and including it in package.json:
// file typings.d.ts
declare var module: any;

declare module "@kadira/storybook" {
  interface Story {
      add (storyName: string, callback: Function): Story;
  }

  export function storiesOf(name: string, module: any): Story;
  export function action(name: string): void;
}

and in package.json
"typings": "./lib/foo.d.ts"

More info ... http://www.typescriptlang.org/docs/handbook/typings-for-npm-packages.html
Do you want a PR for this?

Why not. Send me a PR.

@tomitrescak This is merged and released with v1.20.0. What else do we need to have to do?

All you need to do is enjoy the smiles of Typescript developers that will love you for this;) and occasionally update the typing when API changes. If you'll need help, just ping me. Thanks!

And you can close this now. Thanks!

Thanks @tomitrescak.
I think I can update the def file with API changes :)

@tomitrescak @arunoda
Guys thanks a lot for your time
;-)

@tomitrescak
Module not found: Error: Cannot resolve 'file' or 'directory' ../stories


bug: Website constantly reloading in iframe

Type: bug
Platform: ios 8 webview
My app requires loading a webpage in an iframe. I have a list view with multiple items. When each item is clicked it opens a sub page where the ion-view contains an iframe with a webpage.
sample code from subpages:
<ion-view>
    <ion-content scroll="true" overflow-scroll="true" class="iframe-wrapper padding"
           ng-repeat= "item in links | filter: {shortname: whichlink}">
               <iframe data-tap-disabled="true" class= 'webPage' name= "{{ item.shortname }}"
                   src="" dynamic-url dynamic-url-src="{{item.link}}"></iframe>
     </ion-content>
</ion-view>

I fixed my iframe to become scrollable, but the webpage inside it keeps reloading non stop, resetting every time and preventing the user from seeing the content as it goes back to the top of the page every few seconds.
I have no idea why this is happening and how to stop it. Please suggest what i can do.

Greetings @gere0018!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


fix: rewrite default git version command

Signed-off-by: x893675<EMAIL_ADDRESS>
What type of PR is this?

/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

/milestone v1.1.1

/cherrypick release-1.1


Format On Code Snippet

I noticed that there do not seem to be any settings to trigger the formatter for code snippets.
I am writing Java code using the Java Language Support extension by Redhat, which comes with a formatter and many predefined code snippets such as main, fori, try_resources, etc.
These predefined code snippets are written with braces at the end of method headers, while my formatter settings place braces on the next line. When I am writing code and use a snippet with braces it does not follow the existing conventions of the file.
Example

With Java Language Support extension, use Eclipse formatting preferences that place braces on the next line, ex.

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<profiles version="20">
    <profile kind="CodeFormatterProfile" name="BracesNextLine" version="20">
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_block" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_block_in_case" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_annotation_type_declaration" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_record_constructor" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_anonymous_type_declaration" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_method_declaration" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_constructor_declaration" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_lambda_body" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_record_declaration" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_enum_declaration" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_switch" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_enum_constant" value="next_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_type_declaration" value="next_line"/>
    </profile>
</profiles>

Use main snippet in a new Java class.

Current Result
The generated method has the opening brace on the same line as the method header as defined by the snippet.
public class Example
{
    public static void main(String[] args) {

    }
}

Behavior With Feature Enabled
The formatter would be triggered when the code snippet was used so that the closing brace would be placed on the line following the method header as defined in the formatter configuration.
public class Example
{
    public static void main(String[] args)
    {

    }
}

Of course, this example is a specific situation using the Java extension but it applies more generally to using any code snippets and formatter extensions. While you could always define custom user snippets to use in place of those provided by the extensions, this is definitely not ideal and does not adapt well to projects with different formatting conventions. Automatic formatting would make language support feel more integrated into the editor.
I've already tried the editor.formatOnPaste feature which does not seem to work for code snippets.
editor.formatOnType is kind of a workaround to this issue but it does not fix the formatting until moving to the next line and instead of only formatting a selection (like editor.formatOnPaste), it formats the entire document.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!

If you are "happy to listen and to reconsider" are you looking here to listen?  Or do I need to add information somewhere else?
Personally, I don't really see this issue as a feature request.  I consider this a bug that needs to be addressed to make the "code snippets" feature work in a useful way.  I actually do not use code snippets at all in VS Code because formatting doesn't work right, so every time it comes up (suggested) I just type the snippet by hand with the formatting I like, rather than insert the snippet then take the time to fix all the formatting.
Please reconsider this and fix code snippets in VS Code.

This isn't affecting me in my current environment (where the snippets I use basically align with the standards) but I definitely agree this is an issue.
When this issue was opened I was supporting an introductory programming class and provided students formatting configurations that matched the course coding standards / helped get their environment setup. Unfortunately, the coding standard did not line up with the code snippets so I could not recommend that feature to students since it would require them to basically rewrite any multi-line code snippets.
The same situation would apply when writing code for a company or project with coding standards that do not align with the snippets, which would make the snippets almost useless. It's not the most urgent problem but it does prevent use of a feature in many situations.


Update release/2.7 with changes in main

Just your normal update PR.
Must be merged after #1407

Bypassing required review step as this is a necessary update to release 2.7


The description details on rule no-floating-promises has a typo on rule no-unused-expression (an  extra s)

See:
https://github.com/palantir/tslint/blob/3369ff8603381fe2990e052f1f74a2c138b33e0b/src/rules/noFloatingPromisesRule.ts#L28
The actual rule is  no-unused-expression without the final s.

Fixed by #3125. Thanks for reporting.