HBASE-25583: NoNodeException of the peer should call the remove peer workflow

There was a review comment on the original of HBASE-25583 here for an improvement to call the remove peer workflow as a whole instead of just terminating source.
It makes sense to call the removePeer for no node exception on peer since it will do some aditional cleanup.
@shahrs87 Can you please review it here?
@apurtell @wchevreuil Can you please review it too since you reviewed the original PR for HBASE-25583.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 21s
branch-1 passed

+1 :green_heart:
compile
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 54s
branch-1 passed

+1 :green_heart:
shadedjars
3m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 18s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 14s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 47s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 43s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 10s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
124m 11s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 30s
The patch does not generate ASF License warnings.

170m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2970

JIRA Issue
HBASE-25583

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d78d84f25022 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2970/out/precommit/personality/provided.sh

git revision
branch-1 / f9a9148

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/1/testReport/

Max. process+thread count
3536 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 16s
branch-1 passed

+1 :green_heart:
compile
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 57s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
2m  4s
branch-1 passed

+1 :green_heart:
shadedjars
3m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 52s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 38s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 35s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 42s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
checkstyle
1m 56s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 18s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 12s
the patch passed

_ Other Tests _

-1 :x:
unit
126m 26s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

176m 29s

Reason
Tests

Failed junit tests
hadoop.hbase.TestCachedClusterId

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2970

JIRA Issue
HBASE-25583

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 38fe7dd900e7 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2970/out/precommit/personality/provided.sh

git revision
branch-1 / f9a9148

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/2/testReport/

Max. process+thread count
3705 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m  1s
branch-1 passed

+1 :green_heart:
compile
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 53s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 56s
branch-1 passed

+1 :green_heart:
shadedjars
3m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 16s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 12s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 12s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 48s
the patch passed

+1 :green_heart:
checkstyle
1m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m  8s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
124m 54s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

171m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2970

JIRA Issue
HBASE-25583

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 6f01c3024200 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2970/out/precommit/personality/provided.sh

git revision
branch-1 / f9a9148

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/3/testReport/

Max. process+thread count
3762 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/3/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
16m 49s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 55s
branch-1 passed

+1 :green_heart:
compile
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 52s
branch-1 passed

+1 :green_heart:
shadedjars
3m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 15s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 11s
branch-1 passed

-0 :warning:
patch
3m 20s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 47s
the patch passed

+1 :green_heart:
checkstyle
1m 43s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 54s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 13s
the patch passed

_ Other Tests _

-1 :x:
unit
143m 48s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 44s
The patch does not generate ASF License warnings.

204m 37s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.regionserver.TestReplicationSourceWithoutReplicationZnodes

hadoop.hbase.replication.TestReplicationSource

hadoop.hbase.replication.TestMultiSlaveReplication

hadoop.hbase.replication.regionserver.TestReplicationSourceManagerManager

hadoop.hbase.replication.TestReplicationChangingPeerRegionservers

hadoop.hbase.master.cleaner.TestSnapshotFromMaster

Timed out junit tests
org.apache.hadoop.hbase.TestCachedClusterId

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2970

JIRA Issue
HBASE-25583

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 8f0af563eaf3 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2970/out/precommit/personality/provided.sh

git revision
branch-1 / a7574ec

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/5/testReport/

Max. process+thread count
4090 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/5/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 48s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 31s
branch-1 passed

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 51s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
2m  6s
branch-1 passed

+1 :green_heart:
shadedjars
3m 56s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 51s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 24s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 22s
branch-1 passed

-0 :warning:
patch
3m 31s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
0m 51s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 51s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
checkstyle
1m 49s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 24s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 28s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 40s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 50s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
140m 39s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

190m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2970

JIRA Issue
HBASE-25583

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 164545e08df8 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2970/out/precommit/personality/provided.sh

git revision
branch-1 / a7574ec

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/6/testReport/

Max. process+thread count
3536 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/6/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Waiting for additional review/comment before any merging

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m  5s
branch-1 passed

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 56s
branch-1 passed

+1 :green_heart:
shadedjars
3m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 17s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 15s
branch-1 passed

-0 :warning:
patch
3m 24s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  9s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
checkstyle
1m 48s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 11s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m  8s
the patch passed

_ Other Tests _

-1 :x:
unit
126m 49s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

172m 25s

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestZKLessSplitOnCluster

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2970

JIRA Issue
HBASE-25583

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 36c030245e98 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2970/out/precommit/personality/provided.sh

git revision
branch-1 / a7574ec

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/7/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/7/testReport/

Max. process+thread count
3756 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2970/7/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Test failure TestZKLessSplitOnCluster is not related.


About reviving OPENSSL_ALLOW_PROXY_CERTS

Hi,
I was wondering whether you would consider reverting this commit: https://github.com/openssl/openssl/commit/8e21938ce3a5306df753eb40a20fe30d17cf4a68
I know it has been there for ages and that it is only a "temporary hack". But as a matter of a fact, not all the software have adapted (for example python wrappers..), leaving end users without a real solution.
Many thanks

I would also support the request, because there is also software whose developers are not very keen in applying changes to support something that is not widely used. See for example this discussion about a patch to nginx.
Irrespective of the change, I would also kindly request to review the documentation in doc/HOWTO/proxy_certificates.txt to align it with the code, especially where it reads:
For these reasons, OpenSSL requires that the use of proxy certificates be
explicitly allowed.  Currently, this can be done using the following methods:

 - if the application directly calls X509_verify_cert(), it can first call:

   X509_STORE_CTX_set_flags(ctx, X509_V_FLAG_ALLOW_PROXY_CERTS);

   Where ctx is the pointer which then gets passed to X509_verify_cert().

 - proxy certificate validation can be enabled before starting the application
   by setting the environment variable OPENSSL_ALLOW_PROXY_CERTS.

In the future, it might be possible to enable proxy certificates by editing
openssl.cnf.

In fact what is important is not to be able to call directly X509_verify_cert(), but to have access to ctx in order to be able to set that flag

If the environment variable "hack" is not supported any more, the second bullet should be removed

What about the use of openssl.cnf? is it a realistic option? from a cursory look it doesn't look easy, because the configuration is not readily available inside check_chain_extensions() and calling functions. If that's the case maybe it's better to remove that future option, just not to create illusions :-)

Thanks.

The mention of old doc/HOWTO files got me thinking that they need a serious update, which is the reason we're labelling this as a documentation issue.
As for bringing back OPENSSL_ALLOW_PROXY_CERTS, my opinion is that it should remain the temporary hack that it was, i.e. not be added back.  But, doc/HOWTO/proxy_certificate.txt should be updated.

I understand your point, and even share your view.
However, from the user perspective, we are now in a situation where the "hack" is not available and neither is the doc.
How about bringing back the env variable until the doc is properly updated ?
This would seem a good trade off to me.

Having an environment variable silent control what is allowed for validation seems like a security issue to me.  You can always add it back in your own copy of openssl or fix the apps.

Meanwhile, I've heard the cue that the documentation needs a slight update.  I've done so by create a section 7 manual, see #10507

Thanks for looking again at this issue and updating the documentation. I still think that it would be nice to be able to configure an existing TLS application to recognize proxy certificates, but I also understand the concerns of using an environment variable. In our case we fortunately managed to find a way to enable proxies via an application plugin, others may not be so lucky.

Docs updated, and it seems like there is no plan to implement proxy certificate allowance
Marking as inactive, to be closed at the end of 3.4 dev barring further input


add opcache php module

Does simply installing this module enable opcache? If not, we need a line to enable opcache for PHP.

you mean any configuration for php.ini ?
I'm not sure, but it seems I did not do anything else. only this.
i will recheck and write you

Thanks, I confirmed just adding opcach ext enabled the opcache. Woohoo. This will be in next release I'm working on.


Replaced COPYTRACK Token Sale with COPYTRACK Token

As the token sale is over now I replaced the entry with the actual token. As it provides some additional functionality like burning tokens it would be nice to have the contract in the dropdown list.

manually added!


Added lookbehind functionality

Lookbehind is like lookahead but in the other direction. This can be useful if you want to select the function name from the function body with a custom query. If lookahead and lookbehind are configured as true, lookahead is dominant. As a further improvement i suggest that lookahead and lookbehind should be assigned to each keymap individually, because this will allow bindings like vim's integrated f for search forward and F for search backward.

Thank you again for this nice addition @fabiocaruso !


as_route method for class based consumers

Hello @andrewgodwin
It is proof of concept.
I hope that somebody creates a really generic Consumers, so at this way it will be real nice to have method that gives more fluent way to use CB consumers.
Old way:
# consumers.py
from mygeneric import ModelBaseConsumers
from .models import User

class UserConsumers(ModelBaseConsumers):
    model = User
    fields = ['username', 'group']

#routes
from channels import route_class
from .consumers import UserConsumers, ....

routes = [
   route_class(UserConsumers, path='/users/'),
   ...
]

New way:
from mygeneric import ModelBaseConsumers
from .models import User, Message

routes = [
    ModelBaseConsumers.as_route(model=User, fields=['username', 'group'], path='/users'),
    ModelBaseConsumers.as_route(model=Message, fields=['user', 'text'], path='/messags'),
]

What do you think about this?

The ability to pass kwargs is quite nice, but the implementation using type() is a little verbose. Do we really need to copy the dict like that or can the kwargs just be passed in as the class body?
Also, if there are no kwargs, maybe skip making the new class and just pass in cls?

@andrewgodwin I tried to fix it

Looks like something strange with flake8 and travis...

That was odd!
I'm still a little conflicted about the mixing of class body settings and route settings in the same kwarg list, and which one they apply to being implicit (not to mention you wouldn't be able to set the path routing key if there was anything called path on the class). Do you have any ideas to deconflict them?

I suggest to using filters key word argument for filters and kwargs  for class body. Will it be more clear?
routes = [
    ModelBaseConsumers.as_route(model=User, fields=['username', 'group'], filters={'path': '/users'}),
    ModelBaseConsumers.as_route(model=Message, fields=['user', 'text'], filters={'path': '/messags'}),
]

Isn't filters bit problematic because of the QuerySet#filter, since we are dealing with the Model a thus the fields argument, this can be confusing. What about match?

I actually might be more a fan of keeping the routing filters as the things outside as normal kwargs - to match route() calls - and moving the class body overrides into a named variable, maybe attrs or something.

@andrewgodwin  Suitable naming.

Yes! I like that a lot. Sorry to ask for so many changes :)

No problems @andrewgodwin . Thanks you!


Validate collection information on create and update

Move collection form validation from the FE to the BE. For example, collection name, collection description, contact name, contact email and links are to be validated by the BE.

Closing based on roadmap priorities.


[graphiql/toolkit] support graphql-sse

@dimaMachina can you update the docs in toolkit as well?

@dimaMachina needs a very minor rebase it seems, main release branch is now unblocked!


FloatingPointExtensions + tests

Swift 3.0 API design guidelines:
getRoundedByPlaces(_:) is now rounded(toPlaces:)
getCeiledByPlaces(_:) is now ceiled(toPlaces:)
roundByPlaces(_:) is now round(toPlaces:)
ceilByPlaces(_:) is now ceil(toPlaces:)
Significant change Methods above are now part of FloatingPoint protocol extension with default implementation.
Motivation:
round(ed) and ceil(ed) are useful for all floating types. In 1.7 version we have Double implemented round(ed) and ceil(ed), but Float are still missing these methods.
Okay, we could just copy-paste methods to Float extension, but it is not good to ignore reusability.
Let's move to protocol representing floating types - FloatingPoint protocol.

Do not merge, need to verify results from
http://codereview.stackexchange.com/questions/142748/swift-floatingpoint-rounded-to-places/142850#142850

#229

Current coverage is 43.41% (diff: 96.22%)

Merging #218 into master will increase coverage by 0.91%

@@             master       #218   diff @@
==========================================
  Files            60         62     +2
  Lines          2600       2656    +56
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1105       1153    +48
- Misses         1495       1503     +8
  Partials          0          0

Powered by Codecov. Last update 6ef7312...24dd667

@goktugyil I'd like you to approve this once since it is changing a lot of files....

Looks good. Have to run it to make sure ofc

Why is it better to extend the tests than to write the method inside the class.
@goktugyil You said in #225 that you didn't want global variables. Should we change in here?

Yeah. Could also be done after merge too


Help! Any suggestions?

It may be possible to train a network to stylize a collection of meshes towards a target style in a feed-forward manner.

Hey @Augustus95. I'm not sure what exactly the issue is about, since the attached image doesn't make sense in the context of your sentence.
If you are trying to optimize the face mesh into some text target and facing this multi-face issue, I would recommend that you'll align your mesh. Make sure that the frontview is set to be infront of the face of the content mesh. This can be done by either by adjusting the argument frontview_center or by rotating your source mesh.


Fix #302

Fix #302 and trailing whitespaces

Looks good, thanks!

Nice, cheers!

Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


bazel: 3.2.0 -> 3.3.0

Motivation for this change
Bazel 3.3.0 release
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Tested on macOS, works.


Use autoload instead of require/require_relative

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe
No
Describe the feature you'd like to see implemented
As we progress towards dual Legacy and V2 APIs, we should use autoload instead of require/require_relative. Unused code can remain unloaded, and it's just easier to reason about IMHO.
Since this isn't a material change, we could technically merge this right into main. Might prevent some conflicts with the V2 branch as work in main continues. Thoughts?
Describe alternatives you've considered
No response
Additional context
No response

Done


After the payload is upgraded, the graphql type changes

Link to reproduction
https://payloadcms.com/
Describe the Bug
After upgrading the payload from 1.11.1 to 2.3.1, I encountered the following error: Variable "$category" of type "String" Variable "$tags" of type "[String] " used in position expecting type "[JSON]".
{
    slug: 'seo-resource-template-pages',
    labels: {
      singular: 'Template Page',
      plural: 'Template Pages',
    },
    fields: [
        {
            name: 'category',
            label: 'Category',
            type: 'relationship',
            relationTo: 'categories',
            index: true,
            required: true,
            filterOptions: {
              id: { equals: 'car-insurance' },
            },
            admin: {
              position: 'sidebar',
              description: 'For now, we only support car-insurance.',
            },
        },
        ...
    ]
}

To Reproduce
When the payload version is 1.11.1

After the payload is upgraded to v2.3.1

Payload Version
2.3.1
Adapters and Plugins
No response

Hey @blueMountain007 — this is expected as a breaking change from v1 to v2. If it was not documented in the migration guide, it should have been. But we did indeed intend on this.
Looking forward, moving from v2 to v3 will keep the same behavior as v2, so if you can adjust your queries to match the new shape on v2, that is what we would recommend.
Let me know if you need a hand!

@jmikrut  Got it, thank you. Can you send me a PR related to this change? Quite curious


SP-3061 - Backport of PDI-14294 - Booleans are not being translated from MongoDB (7.0 Suite)

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
mvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml site

Cleanup Commands
mvn -B -f pom.xml build-helper:remove-project-artifact

Changed files
  src/main/java/org/pentaho/mongo/wrapper/field/MongoField.java
  src/test/java/org/pentaho/mongo/wrapper/MongoFieldTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.mongodboutput.MongoDbOutputMeta

Branch Change:  + .89%
Line Change: -.28%:small_red_triangle_down:

org.pentaho.mongo.wrapper.field.MongoField

Branch Change:  + .76%
Complexity Change:  + .68%
Instruction Change:  + .10%
Line Change:  + .14%


vc 1

[ ] https://atcoder.jp/contests/agc034/tasks/agc034_a
[ ] https://atcoder.jp/contests/abc230/tasks/abc230_c
[x] https://atcoder.jp/contests/arc146/tasks/arc146_a

added to projects


Benchmarking as part of pytest

Add pytest runs for benchmarking (may have to be a limited set given the time constraints) similar to what is done in statsforecast.
https://github.com/Nixtla/statsforecast/blob/d7bceb07e5eda3a74d638dffaaf2023d0b8f8c15/.github/workflows/ci.yaml#L119
https://github.com/Nixtla/statsforecast/blob/main/experiments/m3/src/evaluation.py

Question: Should this be done here or in the pycaret repo?


ITextModel.GetAllDecorations() should return an array

Hi, adding the ITextModel bindings is a huge help.
I thing there is a small error in the GetAllDecorations().  you have it returning a single ModelDecoration object, but the documentation says the returned object should be an array - ModelDecorations[], which is also implied by the function name.
Thanks again!

You're right. My bad. I'll correct that this weekend.

I've corrected this in v2.1.0


[DC-813] Update Temporal Data Point CR to New Base Class & Correct Pi…

…peline Step

@dcampbell-vumc now updated with sandboxing!

@dcampbell-vumc now updated with sandboxing!


dm-yaml-adapter handles Serial ids very poorly

If you delete an object that has a Serial attribute declared on it, dm-yaml-adapter will generate duplicate ids on the next create. Also, once there are duplicate ids, dm-yaml-adapter's find all will return return the right number of records but with the wrong content (i.e. it will duplicate the values of the first record it finds for all found records).
I have written a spec that demonstrates both of these problems here:
https://gist.github.com/949306
I would have added it to this repo's spec directory but I couldn't figure out how to get all the dm test helpers up and running.
-- Greg

I ran into this corruption issue using dm-is-list with dm-yaml-adapter.
I integrated a modified version of @atduskgreg's failing spec into my fork
I'm not familiar enough with dm's internals to figure out where the problem would be. Any help?

@see https://github.com/datamapper/dm-yaml-adapter/pull/4


cl.network.listeners: add systemd-timesyncd

Add systemd-timesyncd to list of expected listener processes in cl.network.listeners test
This change adds systemd-timesyncd to the list of expected listener processes in the test cl.network.listeners.
systemd-timesyncd is an NTP client service which will not listen constantly but only run occasionally, binding to random UDP client ports when running. Therefore, the test does not check for a port number.
How to use

check out: gh pr checkout 76
build: make -j
run qemu test (needs a Flatcar qemu image: sudo ./kola run cl.network.listeners --debug --platform qemu --qemu-bios=bios-256k.bin --qemu-image flatcar_production_qemu_image.img

Testing done

Ran the above commands and validated the change does not break cl.network.listeners
Did not explicitly validate against a running systemd-timesyncd as the NTP client only runs occasionally, for a short period of time. We've seen the test fail during release testing though, so I'll closely monitor release testing logs to make sure the test does not fail because of systemd-timesyncd in the future.

Will merge it, to apply the fix for the on-going Jenkins tests.


Postgres additional_users: prevent null from being passed as password

This is a fix for the issue referenced here. The cause was due to terraform interpreting null as a literal value instead of using the default value. It seems to have been an issue for awhile and is referenced in this terraform thread.

Thanks for the PR! 🚀✅ Lint checks have passed.


0800 Contact support number for New Zealand is not working

I called the number from New Zeland mobile phone and I got an auto-response message "The number you've called is not available from your location. Thank you."
Alternative Phone Number: 09 912 7298 is working though

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3425d88a-ef04-122b-abef-8526912c0633
Version Independent ID: 43eb8a88-ef1f-bb9d-fa08-c77e6809d56a
Content: Support information for New Zealand
Content Source: Office365-Admin/support/new-zealand.md
Service: o365-administration
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@officedocsbot assign @mypil

@LinnZawWin - Thank you for submitting feedback.
I will get this telephony issue over to the O365ITPro writing team for investigation.
In the meantime, if you require technical support, you can also open a service ticket in your tenant so your issue can get resolved ASAP. Based on outcome, let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:  https://docs.microsoft.com/office365/admin/contact-support-for-business-products

@cmcatee-MSFT - FYI.

Hi @LinnZawWin The telephony carrier for the 0800 number cannot guarantee that every mobile provider will be able to call that in-country number. Therefore, it's recommended that you use the alternate phone number.


Add BlueStacks.app <IP_ADDRESS>5611

Thank you for the contribution. It was merged directly as f8b98981884eff34560744d4d58108cda45c7e57 to keep commit history cleaner. Your contribution is still credited to you.


Request: Example of Reducer for createAsyncAction

I would like to expand your Todo example by providing an action which fetches a list of Todo's from an API.
I've declared the following in actions.ts:
const FETCH = 'todos/FETCH';
const FETCH_SUCCESS = 'todos/FETCH_SUCCESS';
const FETCH_FAILURE = 'todos/FETCH_FAILURE';

export const fetchTodos = createAsyncAction(
    FETCH,
    FETCH_SUCCESS,
    FETCH_FAILURE
)<void, Todo[], Error>();

and declared the API in root-epic.ts
const fetchTodosFlow: Epic<RootAction, RootState> = (action$, store) =>
    action$.pipe(
        filter(isActionOf(fetchTodos.request)),
        mergeMap(action =>
            ajax.getJSON('http://someurl/fetch').pipe(
                map(fetchTodos.success),
                catchError(pipe(fetchTodos.failure, of))
            )
        ));

however I get the following tslint error:
Error:(14, 7) TS2322: Type '(action$: ActionsObservable<RootAction>, store: StateObservable<{ router: RouterState; todos: Readonly<{ todos: Todo[]; todosFetch: Todo[]; todosFilter: TodosFilter; }>; }>) => Observable<{} | PayloadAction<...>>' is not assignable to type 'Epic<RootAction, { router: RouterState; todos: Readonly<{ todos: Todo[]; todosFetch: Todo[]; todosFilter: TodosFilter; }>; }, any, RootAction>'.
  Type 'Observable<{} | PayloadAction<"todos/FETCH_SUCCESS", Todo[]>>' is not assignable to type 'Observable<RootAction>'.
    Type '{} | PayloadAction<"todos/FETCH_SUCCESS", Todo[]>' is not assignable to type 'RootAction'.
      Type '{}' is not assignable to type 'RootAction'.
        Type '{}' is not assignable to type 'LocationChangeAction'.
          Property 'type' is missing in type '{}'.

I'm using the following versions:
    "react-redux": "5.0.7",
    "react-router-redux": "5.0.0-alpha.9",
    "redux": "4.0.0",
    "redux-observable": "^1.0.0",
    "redux-thunk": "^2.3.0",
    "rxjs": "6.1.0",
    "rxjs-compat": "6.1.0",

Any help is greatly appreciated.

Hey, that's cool, I'll try to book some time tomorrow and take a look.

I had the same issue. It's because the version of redux-observable in the todo-app is v1.0.0-alpha-2 whereas you're using the latest version of redux-observable, v1.0.0.
The Epic Signature has changed between those two releases: https://github.com/redux-observable/redux-observable/commit/0b0efc05ed7fb6f70efa3faa0e106a9a4384069c
So, you probably want:
const fetchTodosFlow: Epic<RootAction, RootAction, RootState> = ..., allowing you to output any action in your app in the output observable.

Hi @MattTennison , I've tried out your suggestion but unfortunately it didn't work.
I downgraded RxJS to 5.x, still no joy.
I checked out the latest master of the todo-sample and tried it with no package upgrades, even less joy :-(
Can you push a branch of the sample app that you have working ?
Thanks again,
Dave

By todo-sample, do you mean this repository: https://github.com/piotrwitek/typesafe-actions-todo-app? Because it doesn't have any Epic's created in it - if you're struggling to get it running, perhaps there's an issue elsewhere.
I'm not too familiar with all this stuff myself, so can't provide much more help, but I can share my working Epic:
export type RootAction = ActionType<typeof Locations> | ActionType<typeof SearchBar>
export type RootState = StateType<typeof appReducer>;

export interface IServices {
  geolocationService: IGeolocationService;
  locationService: ILocationService;
}

export const searchBarFlow: Epic<RootAction, RootAction, RootState, IServices> = ((action$, state$, { locationService }) => {
  return action$.pipe(
    filter(isSearchRequest),
    switchMap(action =>
      from(performLocationSearch()).pipe(
        map(handleLocationSearchResponse),
        catchError(err => of(searchFromSearchBar.failure(err)))
      ))
  );

  function isSearchRequest(action: RootAction) {
    return action.type === getType(searchFromSearchBar.request);
  }

  function performLocationSearch() {
    return locationService.getNearbyLocationsObservable(state$.value.userInterface.searchBar.text);
  }

  function handleLocationSearchResponse(response: ILocationServiceResult<ILocationSearch>) {
    return response.isSuccessful ?
      searchFromSearchBar.success(response) :
      searchFromSearchBar.failure(new Error(response.error || "Something went wrong"));
  }
});

Hope this helps!

@boostio funded this issue with $20. Visit this issue on Issuehunt

@loadbalance-sudachi-kun funded this issue with $256. Visit this issue on Issuehunt

@piotrwitek has started working. Visit this issue on Issuehunt

Is this not an issue with the catchError syntax? For our app, we always follow this:
ajax.getJson().pipe(
  map(successAction),
  catchError(err => of(failureAction(err))),
)

In addition to the example of @MattTennison what was missing for me (and not really documented anywhere) is where to get the service from within the epic.
export interface Services {
    positionService: PositionService;
}

The epic itself
export const fetchPositionsEpic: Epic<RootAction, RootAction, RootState, Services> = (action$, state$, { positionService }) =>
    action$.pipe(
        filter(isActionOf(fetchPositions.request)),
        switchMap(() =>
            from(positionService.getPositions()).pipe(
                map((data) => fetchPositions.success(data)),
                catchError((err) => of(fetchPositions.failure(err)))
            )
        )
    );

Then hooking it up
const rootEpic = combineEpics(fetchPositionsEpic);

// inside configureStore
const epicMiddleware = createEpicMiddleware({ dependencies: { positionService: new PositionService() } });

const store = createStore(
    rootReducer,
    initialState,
    composeEnhancers(applyMiddleware(...[thunk].concat(...middleware, epicMiddleware)))
);

epicMiddleware.run(rootEpic);

Working example is there in the referenced commit, but docs examples still needs to be updated. WIP

I'm not sure if I'm doing something obviously wrong but I have a similar problem (I think)
user.actions.ts
import { createAsyncAction, ActionType } from "typesafe-actions";

import { User } from "./user.models";

const SIGN_IN = "@user/SIGN_IN";
const SIGN_IN_SUCCESS = "@user/SIGN_IN_SUCCESS";
const SIGN_IN_FAILURE = "@user/SIGN_IN_FAILURE";

export const signInAction = createAsyncAction(
  SIGN_IN,
  SIGN_IN_SUCCESS,
  SIGN_IN_FAILURE
)<void, User, Error>();

export type UserAction = ActionType<typeof signInAction>;

user.epic.ts
import { combineEpics, Epic } from "redux-observable";
import { from, of } from "rxjs";
import { filter, switchMap, catchError, map } from "rxjs/operators";
import { isActionOf } from "typesafe-actions";

import { RootState } from "../../store/root-reducer";
import * as Services from "../../services";

import { UserAction, signInAction } from "./user.actions";

const signIn: Epic<UserAction, UserAction, RootState, typeof Services> = (
  action$,
  store,
  { GoogleAuthServices }
) => {
  action$.pipe(
    filter(isActionOf(signInAction.request)),
    switchMap(action =>
      from(GoogleAuthServices.signIn()).pipe(
        map(user => signInAction.success(user)),
        catchError(err => of(signInAction.failure(err)))
      )
    )
  );
};

export default combineEpics(signIn);

GoogleAuthService
export class GoogleAuthServices {
  public static async signIn(): Promise<User> {
    const auth = await GoogleAuthServices.getAuth();
    return auth.signIn().then(
      (GoogleUser: any): User => {
        const profile = GoogleUser.getBasicProfile();
        return {
          name: profile.getName(),
          imageUrl: profile.getImageUrl()
        } as User;
      },
      (error: Error) => {
        throw error;
      }
    );
  }
}

Error
Type error: Type '(action$: ActionsObservable<EmptyAction<"@user/SIGN_IN"> | PayloadAction<"@user/SIGN_IN_SUCCESS",User> | PayloadAction<"@user/SIGN_IN_FAILURE", Error>>, store: StateObservable<{ user: Readonly<...>; }>, { GoogleAuthServices }: typeof import("../../services/index")) => void' is not assignable to type 'Epic<EmptyAction<"@user/SIGN_IN"> | PayloadAction<"@user/SIGN_IN_SUCCESS", User> | PayloadAction<"@user/SIGN_IN_FAILURE", Error>, EmptyAction<"@user/SIGN_IN"> | PayloadAction<...> | PayloadAction<...>, { ...; }, typeof import("../../services/index")>'.
  Type 'void' is not assignable to type 'Observable<EmptyAction<"@user/SIGN_IN"> | PayloadAction<"@user/SIGN_IN_SUCCESS", User> | PayloadAction<"@user/SIGN_IN_FAILURE", Error>>'.  TS2322

@piotrwitek has submitted a pull request. See it on IssueHunt

@piotrwitek has rewarded $193.20 to @piotrwitek. See it on IssueHunt

:moneybag: Total deposit: $276.00
:tada: Repository reward(20%): $55.20
:wrench: Service fee(10%): $27.60


[BLE Mesh]IRAM0 segment data does not fit (IDFGH-2248)

Environment

Development Kit:      [ESP32-Wrover-Kit]
Kit version (for WroverKit/PicoKit/DevKitC): [v1|v2|v3|v4]
Module or chip used:  [ESP32-WROVER-B]
IDF version (run git describe --tags to find it):
// v4.1-dev-1086-g93a8603c5
Build System:         [Make]
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
// xtensa-esp32-elf-gcc (crosstool-NG esp32-2019r1) 8.2.0
Operating System:     [macOS]
Power Supply:         [USB]

Problem Description
init the PSRAM
ESP32-specific --> Support for external,SPI-connected RAM --> Try to allocate memories of Wifi and LWIP...
Bluetooth --> Bluedriod Enable --> BT/BLE will first malloc the memory from the PSRAM
Bluetooth --> Bluedriod Enable --> Use dynamic memory allocation in BT/BLE stack.
Bluetooth --> Blutooth controller --> BLE full scan feature supported.

Expected Behavior
success
Actual Behavior
/Users/zhujunkun/Desktop/ayla-espressif/espressif/xtensa-esp32-elf/bin/../lib/gcc/xtensa-esp32-elf/8.2.0/../../../../xtensa-esp32-elf/bin/ld: /Users/zhujunkun/Desktop/ayla-espressif/pda-http-2.4-esp32/examples/ayla_demo/blemesh-gateway/build/blemesh_gateway.elf section `.iram0.text' will not fit in region `iram0_0_seg'
/Users/zhujunkun/Desktop/ayla-espressif/espressif/xtensa-esp32-elf/bin/../lib/gcc/xtensa-esp32-elf/8.2.0/../../../../xtensa-esp32-elf/bin/ld: IRAM0 segment data does not fit.
/Users/zhujunkun/Desktop/ayla-espressif/espressif/xtensa-esp32-elf/bin/../lib/gcc/xtensa-esp32-elf/8.2.0/../../../../xtensa-esp32-elf/bin/ld: region `iram0_0_seg' overflowed by 21116 bytes
collect2: error: ld returned 1 exit status
make: *** [/Users/zhujunkun/Desktop/ayla-espressif/pda-http-2.4-esp32/examples/ayla_demo/blemesh-gateway/build/blemesh_gateway.elf] Error 1

Hi @isDerek, could you please elaborate on the problem description? Just "init the PSRAM" and some seemingly menuconfig settings are a bit vague. It would as well be helpful to describe what you're trying to achieve, including an example of your code which has this issue. Thanks.

i want to add the ble mesh module to my wifi demo(the demo is a wifi agent for our company's cloud).  when i never change the sdkconfig ( ble & wifi coexist sdkconfig), the log tell me
I (985) wifi: wifi firmware version: a44d1c6
I (986) wifi: config NVS flash: enabled
I (986) wifi: config nano formating: disabled
I (987) wifi: Init dynamic tx buffer num: 32
I (997) wifi: Init data frame dynamic rx buffer num: 64
I (998) wifi: Init management frame dynamic rx buffer num: 64
I (1009) wifi: Init management short buffer num: 32
I (1009) wifi: Init static tx buffer num: 16
I (1010) wifi: Init static rx buffer size: 1600
W (1021) wifi: malloc buffer fail
I (1022) wifi: Init static rx buffer num: 14
I (1022) wifi: Init dynamic rx buffer num: 64
E (1033) wifi: Expected to init 16 rx buffer, actual is 14
I (1033) wifi: Deinit lldesc rx mblock:0
I (1034) wifi: Deinit lldesc rx mblock:0
I (1045) wifi: Deinit lldesc rx mblock:0
I (1045) wifi: Deinit lldesc rx mblock:0

so i think maybe i need init the PSRAM, when i modify the menuconfig, the log occured
region `iram0_0_seg' overflowed by 21116 bytes

i want to add the ble mesh module to my wifi demo(the demo is a wifi agent for our company's cloud).  when i never change the sdkconfig ( ble & wifi coexist sdkconfig), the log tell me
I (985) wifi: wifi firmware version: a44d1c6
I (986) wifi: config NVS flash: enabled
I (986) wifi: config nano formating: disabled
I (987) wifi: Init dynamic tx buffer num: 32
I (997) wifi: Init data frame dynamic rx buffer num: 64
I (998) wifi: Init management frame dynamic rx buffer num: 64
I (1009) wifi: Init management short buffer num: 32
I (1009) wifi: Init static tx buffer num: 16
I (1010) wifi: Init static rx buffer size: 1600
W (1021) wifi: malloc buffer fail
I (1022) wifi: Init static rx buffer num: 14
I (1022) wifi: Init dynamic rx buffer num: 64
E (1033) wifi: Expected to init 16 rx buffer, actual is 14
I (1033) wifi: Deinit lldesc rx mblock:0
I (1034) wifi: Deinit lldesc rx mblock:0
I (1045) wifi: Deinit lldesc rx mblock:0
I (1045) wifi: Deinit lldesc rx mblock:0

so i think maybe i need init the PSRAM, when i modify the menuconfig, the log occured
region `iram0_0_seg' overflowed by 21116 bytes

i want to add the ble mesh module to my wifi demo(the demo is a wifi agent for our company's cloud).  when i never change the sdkconfig ( ble & wifi coexist sdkconfig), the log tell me
I (985) wifi: wifi firmware version: a44d1c6
I (986) wifi: config NVS flash: enabled
I (986) wifi: config nano formating: disabled
I (987) wifi: Init dynamic tx buffer num: 32
I (997) wifi: Init data frame dynamic rx buffer num: 64
I (998) wifi: Init management frame dynamic rx buffer num: 64
I (1009) wifi: Init management short buffer num: 32
I (1009) wifi: Init static tx buffer num: 16
I (1010) wifi: Init static rx buffer size: 1600
W (1021) wifi: malloc buffer fail
I (1022) wifi: Init static rx buffer num: 14
I (1022) wifi: Init dynamic rx buffer num: 64
E (1033) wifi: Expected to init 16 rx buffer, actual is 14
I (1033) wifi: Deinit lldesc rx mblock:0
I (1034) wifi: Deinit lldesc rx mblock:0
I (1045) wifi: Deinit lldesc rx mblock:0
I (1045) wifi: Deinit lldesc rx mblock:0

so i think maybe i need init the PSRAM, when i modify the menuconfig, the log occured
region `iram0_0_seg' overflowed by 21116 bytes

iram is instruction ram and unrelated to psram which is a type of data ram.  This means too much code is placed in iram.

oh~ how could i tracer the iram space, have some methods?

https://github.com/espressif/esp-idf/issues/4234

i modify the esp32.ld file, i change the iram0_0_seg size from 0x20000 to 0x30000
 iram0_0_seg (RX) :                 org = 0x40080000, len = 0x30000

does it not the allowed action? the code can't run completely, the code run stopped
I (1896) wifi: wifi firmware version: a44d1c6
I (1897) wifi: config NVS flash: enabled
I (1897) wifi: config nano formating: disabled
I (1898) wifi: Init dynamic tx buffer num: 32
I (1909) wifi: Init data frame dynamic rx buffer num: 64
I (1909) wifi: Init management frame dynamic rx buffer num: 64
I (1920) wifi: Init management short buffer num: 32
I (1921) wifi: Init static tx buffer num: 16
I (1922) wifi: Init static rx buffer size: 1600
I (1933) wifi: Ini

You can't just change iram length because it will overlap with other memory regions that are in use

could i decrease the size (bt) in the iram0_0_seg ? menuconfig?

i cancel the WiFi IRAM speed optimization and WiFi RX IRAM speed optimization（menuconfig）. finally, the iram size could be accepted.


k8s Dependencies Upgraded

name: k8s library upgrades
about: Submit a pull request
title: 'Upgraded go mod managed k8s package dependencies and API calls'
labels: 'k8s'
assignees: '@boz @gosuri'
Description

Upgrades all of the k8s libraries to v0.18.2
Primary change was adding context.Context to all k8s API calls, these updates were effectively no code logic changes with simple initialization of empty contexts. We will need to re-paramaterize that code to pass context/shutdown hooks from the service's manager.
Upgraded go.mod Go version to 1.14 since I noticed upstream CosmosSDK is already demanding it. If that causes issues it can probably be backed off.

Motivation and Context
Numerous problems with k8s packages breaking at build time. Needed to get it all cleaned up to stop blocking features.
How Has This Been Tested?
make test, numerous builds.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] All new and existing tests passed.

🔥


Parallelize requests?

Hey,
is it possible to process multiple requests to the instagram api on threads?
If you have a longer list of usernames, instagram-scraper process them sequential. Parallel processes will speed up the round trip time.
greetings

Good idea :+1:

The scraper utilizes multiple threads to download media, however multiple users are scraped  sequentially. I've experimented with using multiple threads to process each user but found it had a cumulative effect of increasing the overall scrape times. Running multiple instances of the scraper using gnu parallel did not seem promising either.  This will require more research.

I would like if the scraping was separated from the actual downloading. If you got processes/threads that focus on gathering URIs and putting them on a queue/fifo/text file, you could have other processes/threads that asynchronously empty the queue. The emptying of the queue can be done way later, completely outside of the Instagram.com cookie duration.
Footnote: Instagram relies on security by obscurity - the actual image files on their CDNs are not protected by authentication, only by long and randomly looking URIs. You can confirm this easily by visiting/creating a private account and visiting that image file.


Can it support in Windows10?

Can it support in Windows10?

Not yet, but it is on the roadmap. See #173


fix setWindowSize clamp

Describe your PR, what does it fix/add?
fixes https://github.com/hyprwm/Hyprland/issues/4621
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
no
Is it ready for merging, or does it need work?
yes

somebody pls merge this, killing me lol


dependency issue with cmake

when i download howdy the installation stops because howdy depends on cmake but cmake isn't configured so i removed cmake and installed it manually and i get the error that cmake depends on cmake-data but cmake-data isn't installed so i   (sudo apt install cmake-data): but it says that cmake-data is already installed so that is weird

I've searched for similar issues already, and my issue has not been reported yet.
Linux distribution (Linux mint):

i think i figured it out i had  to reinstall cmake-data because it was in a inconsistent state after that i could install howdy again


Feature Roadmap

The following features will be implemented when I am free:

[ ] DeepAR
[ ] NBeat
[ ] transformer
[ ] autoformer
[ ] informer

A new library called PipelineTS has been released that implements most of the above algorithms, so enjoy


WIP New Youtube Sample

Fixes #1399

Let's use this issue to resolve #1399 :)  Just say "Fixes #1399" in the description to auto-close the issue!

@chingor13 @bshaffer @dwsupplee would one of you mind giving this a one over?

Happy to take a look.
@mattwhisenhunt is this ready for me to review, or would you prefer I wait until the WIP flag is removed?
@JustinBeckwith The new group notifications are really slick - but I don't seem to be getting any when tagging "google/yoshi-php".  😕

@dwsupplee Please review it, I guess my only hang up is not including a sample_video.flv file and thus not having a working sample.

@dwsupplee I'm still trying to get the yoshi-php group figured out :(

Is this just copied over from here? I have been putting together some notes, and there are some definite issues with that code (in my testing, it doesn't just work out of the box). It looks like this sample follows a similar pattern but is updated to be more idiomatic and to work correctly. I'd recommend we just link out to the latter sample, but if we prefer to have something different living in this repo I'd be happy to post my notes so this can be useful for our users.

Yes, it is a copy and paste job. From the full sample setting.
On Fri, Jun 8, 2018 at 11:41 AM David Supplee<EMAIL_ADDRESS>wrote:

Is this just copied over from here
https://developers.google.com/youtube/v3/docs/videos/insert? I have
been putting together some notes, and there are some definite issues with
that code (in my testing, it doesn't just work out of the box). It
looks like this sample
https://github.com/youtube/api-samples/blob/master/php/resumable_upload.php
follows a similar pattern but is updated to be more idiomatic and to work
correctly. I'd recommend we just link out to the latter sample, but if we
prefer to have something different living in this repo I'd be happy to post
my notes so this can be useful for our users.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/google-api-php-client/pull/1435#issuecomment-395852025,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFAP27Trq2vW1AQfmsZkyX2w6ovqYKkYks5t6sVFgaJpZM4UdC4o
.

Thank you for checking this out @dwsupplee :)
@mattwhisenhunt If there is an existing place for the same code on github, I'm in favor of using that sample code and directing the user there.  Please modify the README in the examples directory to call out to the stuff in the YouTube repo 👍


Error inside phpstan.neon

Larastan Version: 3.0.1
--level used: max
Pull request with failing test:

Description
Getting errors in phpstan.neon file:

See log:
log.txt
Laravel code where the issue was found
Error shows in .neon file as seen in screenshot

Hello @ilyub! 👋🏻
Thank you for your report.
What software is version 3?
https://github.com/nunomaduro/larastan/releases

Note: log shows this line
https://github.com/nunomaduro/larastan/blob/38254abf035dbf324a9acb1d4d30e7e7cc052411/src/Methods/MacroMethodsClassReflectionExtension.php#L87

Sorry, larastan version is 2.2.1
  "require": {
    "google/apiclient": "^2.12.6",
    "guzzlehttp/guzzle": "^7.5.0",
    "laravel/framework": "^9.35.1",
    "laravel/sanctum": "^3.0.1",
    "laravel/socialite": "^5.5.5",
    "laravel/tinker": "^2.7.2",
    "php": "^8.0.2",
    "real/config": "^1.14.0"
  },
  "require-dev": {
    "captainhook/captainhook": "^5.10.11",
    "fakerphp/faker": "^1.20.0",
    "friendsofphp/php-cs-fixer": "^3.12.0",
    "laravel/pint": "^1.2.0",
    "laravel/sail": "^1.16.2",
    "mockery/mockery": "^1.5.1",
    "nunomaduro/collision": "^6.3.1",
    "nunomaduro/larastan": "^2.2.1",
    "phpstan/phpstan": "^1.8.9",
    "phpunit/phpunit": "^9.5.25",
    "ramsey/conventional-commits": "^1.3.1",
    "spatie/laravel-ignition": "^1.5.1"
  },

Does this also occur if you move "nunomaduro/larastan" to "require" and don't install dev deps?
composer install --no-dev

Yes, I reduced configuration to:
  "require": {
    "guzzlehttp/guzzle": "^7.5.0",
    "laravel/framework": "^9.35.1",
    "laravel/sanctum": "^3.0.1",
    "laravel/tinker": "^2.7.2",
    "nunomaduro/larastan": "^2.2.3",
    "php": "^8.0.2"
  },

Hi,
Can you post the code from app\Http\Middleware\BuildResponse.php?

It turns out I really use "mix" macro. Below is the code for BuildResponse.php and ResponseServiceProvider.php (where "mix" marco is defined).
app\Http\Middleware\BuildResponse.php:
<?php

namespace App\Http\Middleware;

use Closure;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * BuildResponse HTTP middleware class.
 */
class BuildResponse
{
  /**
   * Handles incoming request. Adds global data to JSON response (see
   * ResponseServiceProvider).
   */
  public function handle(Request $request, Closure $next): Response
  {
    $response = $next($request);

    return $response instanceof JsonResponse
      ? response()->mix($response)
      : $response;
  }
}

app\Providers\ResponseServiceProvider.php:
<?php

namespace App\Providers;

use Illuminate\Http\JsonResponse;
use Illuminate\Routing\ResponseFactory;
use Illuminate\Support\ServiceProvider;

/**
 * ResponseServiceProvider class. Allows to set global response data and mix it
 * into JSON response.
 */
class ResponseServiceProvider extends ServiceProvider
{
  /**
   * Bootstraps the service. Adds macros to the app's response factory.
   */
  public function boot(ResponseFactory $factory): void
  {
    $factory->macro('getData', [$this, 'getData']);
    $factory->macro('mix', [$this, 'mix']);
    $factory->macro('set', [$this, 'set']);
  }

also config/app.php:
<?php

return [
   ...
  'providers' => [
    App\Providers\ResponseServiceProvider::class,

I didn't think anyone would register a macro like that 😅 Anyway fixed and released: https://github.com/nunomaduro/larastan/releases/tag/2.2.4


x64 design xaml issue

Hi all,
first of all I'd like to thank you for the very great and useful job. I have to bring to your attention an issue concerning the xaml and the design view of VS. If the solution/project is compiled with AnyCPU, in design mode I see the keys used in {lex:Loc KEY}, even the default value or just Key:KEY. If I compile the solution/project with x64, everything disappears and I don't see nothing in design mode, not the default value nor the Key:KEY (for example a button with just a text as Content becomes completely collapsed), even if in runtime is working correctly.
This is not a blocking stuff but during the design of windows/controls it is quite helpful to see the final appearance, as you can easly imagine.
Is there something I am missing?
Thanks in advance

@GrazianoDeKa thanks for the finding. The issue is that the design mode is tricky. If you can debug that issue a little bit more this would be great.

That is because the visual studio design instance only works in x86 (or Any CPU, in that case the VS instance will opt for the x86 version). This is not the extension's fault. If you have IoC or other stuffs that bind and reflect in design time you will notice the same effect, nothing will change/reflect in design-time if running on x64.
Bottom-line: Always set your application to Any CPU, this way VS will always use internally the x86 version for its design instance, and in runtime it will always run in x64 anyway if your PC is x64.
(Just make sure the checkbox "Prefer 32-bit" is NOT checked. This is available in Project -> Build tab)
You can see numerous questions about this: https://stackoverflow.com/questions/5378919/visual-studio-designer-in-x64-doesnt-work


doc-ci: use julia-docdeploy@latest

Compare https://github.com/JuliaDocs/Documenter.jl/issues/2002#issuecomment-1367304615
with e.g. https://github.com/JuliaData/DataFrames.jl/actions/runs/3776489530/jobs/6419783212

hm no, should be same: latest is v1.3


Add link to main k8s docs on service-catalog

To my delight, I found that there is doc for service-catalog on the main kubernetes site.  This PR adds a link to that doc.

Yeah, I think the issue was with the break in the int tests.  Might need to
rebase.
On Mon, Dec 18, 2017 at 12:53 PM, Aaron Schlesinger <
<EMAIL_ADDRESS>wrote:

@pmorie https://github.com/pmorie I didn't see anything in the test
runs that related to docs, so restarted
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/pull/1627#issuecomment-352504430,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXmKOtQaKVcgLuwvVYRnSsVW8Hduj1ks5tBqaugaJpZM4REgwL
.


A PowerToys feature that make Windows 11 don't join icons of same app on taskbar

Description of the new feature / enhancement
Windows 11 don't join icons of same app on taskbar
Scenario when this would be used?
Any time you are working with Windows 11
Supporting information
I believe this is not neccessary in this case
### Tasks

Never combine is now in insider flights of windows :).

Good news. Thanks!


Added CompSciLib to Prob/Stats section

Added CompSciLib to the Probability & Statistics section.

This is a list of books and tutorials, and

A website featuring Statistics Calculators, Practice Problems, and Cheatsheets.

seems to me to not fit the list.


Issue with GetSystemTimePreciseAsFileTime on Windows Server 2008 in libuv 1.48.0 and Suggested Fix

Hello,
I encountered an issue while using the libuv library version 1.48.0 on Windows Server 2008. During runtime, an error message appears stating "Entry Point Not Found: GetSystemTimePreciseAsFileTime." After analyzing the code, I found that the issue lies in the uv_clock_gettime() function within the util.c file. This function uses GetSystemTimePreciseAsFileTime(), which is not supported on Windows Server 2008.
To ensure compatibility with Windows Server 2008, I suggest adding a check for the operating system version in the code: use GetSystemTimePreciseAsFileTime() on Windows 8 or Windows Server 2012 and later versions, and use GetSystemTimeAsFileTime() on earlier versions.
Here is my modified code, which has been tested successfully on Windows Server 2008:
int is_windows_8_or_greater() {
  OSVERSIONINFOEXW osvi;
  DWORDLONG conditionMask = 0;

  ZeroMemory(&osvi, sizeof(OSVERSIONINFOEXW));
  osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEXW);
  osvi.dwMajorVersion = 6;
  osvi.dwMinorVersion = 2;

  VER_SET_CONDITION(conditionMask, VER_MAJORVERSION, VER_GREATER_EQUAL);
  VER_SET_CONDITION(conditionMask, VER_MINORVERSION, VER_GREATER_EQUAL);

  return VerifyVersionInfoW(&osvi, VER_MAJORVERSION | VER_MINORVERSION, conditionMask);
}

int uv_clock_gettime(uv_clock_id clock_id, uv_timespec64_t* ts) {
  FILETIME ft;
  int64_t t;

  if (ts == NULL)
    return UV_EFAULT;

  switch (clock_id) {
    case UV_CLOCK_MONOTONIC:
      uv__once_init();
      t = uv__hrtime(0 /* UV__NANOSEC */);
      ts->tv_sec = t /<PHONE_NUMBER>;
      ts->tv_nsec = t %<PHONE_NUMBER>;
      return 0;
    case UV_CLOCK_REALTIME:
      if (is_windows_8_or_greater()) {
        GetSystemTimePreciseAsFileTime(&ft);
      } else {
        GetSystemTimeAsFileTime(&ft);
      }
      /* In 100-nanosecond increments from 1601-01-01 UTC because why not? */
      t = ((int64_t)ft.dwHighDateTime << 32) | ft.dwLowDateTime;
      /* Convert to UNIX epoch, 1970-01-01. Still in 100 ns increments. */
      t -=<PHONE_NUMBER>00000000ll;
      /* Now convert to seconds and nanoseconds. */
      ts->tv_sec = t / 10000000;
      ts->tv_nsec = (t % 10000000) * 100;
      return 0;
  }

  return UV_EINVAL;
}

I hope you find my suggestion helpful, and thank you for your hard work!
Best regards,
[linjifan]

Windows Server 2008 is no longer supported by libuv: https://github.com/libuv/libuv/blob/v1.x/SUPPORTED_PLATFORMS.md#supported-platforms


Internal links (and possibly arbitrary components) in rendered HTML

Hi.
My markdown content has cross-references. I want them to behave like internal links between routes.
I think ember-remarkable could optionally run rendered HTML through Ember template compiler to leverage {{link-to}}s and other components.
Or maybe there's a better path?

I definitely think there should be a way in which we can support this. Not sure how this would work, but optionally running through the template compiler could work well (I'd have to do a bit of digging to see how feasible this is).
The {{link-to}} parser in place of the default linkify option could potentially work as a custom plugin [#7], which can be pulled in.

Ember template compiler transforms a string to a function, there's no way you can use it as a Remarkable plugin.

I mean as a plugin to transform markdown output like
Some Link

To
{{#link-to 'some-link}}Some Link{//link-to}}

But, after rereading your issue I think I may have misunderstood you. From what I gather now you're referring to {{link-to}} helpers that actually exist in your markdown, correct?

@johnotander My links appear as {{#crossLink "myClass:method"}}{{/crossLink}} where myClass is an URL segment and method is a child route name.
I can regex them into s or {{link-to}}s, whatever.
What I meant is that the result should be internal links handled by Ember (behave like {{link-to}}s). Not just s with relative URLs.


Have explicit browser support

I'd like to add explicit support for using akismet-api in the browser

I'm going to close this as it doesn't seem to be anything that has drummed up any particular interest from users -- can always revisit later


db/pebble: Extract Pebble's native metrics

closes #1243

I see that the overall metrics were refactored. Any changes you would want to see before I start adapting it to the new structure? I could also split this PR into smaller ones, each representing part of the pebble.metrics if that's helpful.

PR into smaller ones, each representing part of the pebble.metrics if that's helpful.

thanks, that would be great. separate commits are good enough, no need for multiple PRs.

@omerfirmak Would mind giving it a try? Just LevelsListener for now.

Any thoughts? I don't think that going forward with this pr is appropriate until the base approach is approved since each metric is just a slight variation of that.
Few thoughts:

Pebble returns some of the metrics as total, I transform them into delta to use it in counter instead of gauge since only increasing gauge doesn't seem logical to me, eg.

	// These metrics are only ever increasing, return delta instead of total.
	formatted.Level[i].BytesIn = levels[i].BytesIn - cache.Lvls[i].BytesIn

Some interesting metrics that aren't included in pebble.Metrics can be collected through pebble.EventListener, eg compaction duration.

  // CompactionBegin is invoked after the inputs to a compaction have been
    // determined, but before the compaction has produced any output.
    CompactionBegin func(CompactionInfo)

    // CompactionEnd is invoked after a compaction has completed and the result
    // has been installed.
    CompactionEnd func(CompactionInfo)

Most of the metrics don't seem useful, is it really worth ingesting them all ? It could be way slimmer if we just collected the bare minimum, eg. etherum for reference.

Some small linting issues, I will resolve them later. Just figured out that I had different linter version installed and that one wasn't complaining about anything :smile:

I think most of the metrics pebble exposes are way too specific to make any sense for us. We definitely don't need metrics from all the levels.
Let's do what geth does and only report a subset if you dont mind.
https://github.com/ethereum/go-ethereum/blob/a8617c6d4dbe0df8c67e1f5c2ecd76c3200dc18d/ethdb/pebble/pebble.go#L58-L70C27

Should be ready for review @omerfirmak
preview of metrics in dashboard during initial sync:

I added changes that align with the behavior described incomment.

Hey @joshklop, I noticed you added this to the milestone. Do you want me to resolve the conflicts since this PR has been idle for some time already?

Hey @joshklop, I noticed you added this to the milestone. Do you want me to resolve the conflicts since this PR has been idle for some time already?

Hi @Exca-DK, that would be super helpful. Thanks for offering.
I think @omerfirmak had some opinions about how we should move forward on this PR, so I'll re-request a review from him.

Hey @joshklop, I noticed you added this to the milestone. Do you want me to resolve the conflicts since this PR has been idle for some time already?

Please do, we will try to get this merged soon. Sorry it took us so long:(

Closing in favour of https://github.com/NethermindEth/juno/pull/2187/files (similar changes).


solve for both intersections

This patch updates the rsi function to solve for both roots of the quadratic and to solve for both the atmospheric and planetary intersection. The previous implementation assumes that the ray always starts inside the sphere, but under this implementation that is no longer necessary. which means you can calculate atmospheric scattering for distant planets: https://substack.neocities.org/earth/atmo.html
I tested that the existing demo still works under this change. It looks different with more light on the bottom half, but still looks great. If you merge this I would bump the major version since this change will impact how existing demos look.

Oh man, that looks fantastic. Thanks!

...and bumped!


Show error message if LoTW upload fails

The current code throws an exception which causes the script to terminate without any output. This is to change so that the user sees an error message that upload had failed:

Then testing in dev commences ;D


Error in making prediction on CPU after training the model on GPU

Hi,
I trained the model on GPU according to tutorial.
reader = BertQA(bert_model='bert-base-multilingual-cased',
                train_batch_size=256,
                learning_rate=3e-5,
                num_train_epochs=2,
                do_lower_case=False,
                verbose_logging=True,
                output_dir='./temp')

reader.fit(X=(train_examples, train_features))

And before dumping the model, send it to CPU.
reader.model.to('cpu')
reader.device = torch.device('cpu')

But I try to make a prediction on CPU, then following error occurs...
query = 'some sample query...'
prediction = cdqa_pipeline.predict(X=query)

--------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-79-c881b3585457> in <module>
      1 query = ''some sample query...''
----> 2 prediction = cdqa_pipeline.predict(X=query)

~/anaconda3/lib/python3.7/site-packages/cdqa/pipeline/cdqa_sklearn.py in predict(self, X, return_logit)
    158                                                      metadata=self.metadata)
    159             examples, features = self.processor_predict.fit_transform(X=squad_examples)
--> 160             prediction = self.reader.predict((examples, features), return_logit)
    161             return prediction
    162

~/anaconda3/lib/python3.7/site-packages/cdqa/reader/bertqa_sklearn.py in predict(self, X, return_logit)
   1220             with torch.no_grad():
   1221                 batch_start_logits, batch_end_logits = self.model(
-> 1222                     input_ids, segment_ids, input_mask)
   1223             for i, example_index in enumerate(example_indices):
   1224                 start_logits = batch_start_logits[i].detach().cpu().tolist()

~/anaconda3/lib/python3.7/site-packages/torch/nn/modules/module.py in __call__(self, *input, **kwargs)
    491             result = self._slow_forward(*input, **kwargs)
    492         else:
--> 493             result = self.forward(*input, **kwargs)
    494         for hook in self._forward_hooks.values():
    495             hook_result = hook(self, input, result)

~/anaconda3/lib/python3.7/site-packages/torch/nn/parallel/data_parallel.py in forward(self, *inputs, **kwargs)
    144                 raise RuntimeError("module must have its parameters and buffers "
    145                                    "on device {} (device_ids[0]) but found one of "
--> 146                                    "them on device: {}".format(self.src_device_obj, t.device))
    147
    148         inputs, kwargs = self.scatter(inputs, kwargs, self.device_ids)

RuntimeError: module must have its parameters and buffers on device cuda:0 (device_ids[0]) but found one of them on device: cpu

Is there something else I need to do?

Hi @deo4kyo ,
After sending the model to CPU, Did you dump it using joblib.dump and loaded the dumped model on the QAPipeline?
Can you please paste here the whole code?
Thanks

thanks, @andrelmfarias.
I followed this tutorial training
reader = BertQA(bert_model='bert-base-multilingual-cased',
train_batch_size=256,
learning_rate=3e-5,
num_train_epochs=2,
do_lower_case=False,
verbose_logging=True,
output_dir='./temp')
reader.fit(X=(train_examples, train_features))
reader.model.to('cpu')
reader.device = torch.device('cpu')
joblib.dump(reader, os.path.join(reader.output_dir, 'bert_qa_vCPU.joblib'))
I downloaded the fine-tuned model to my local machine.
And, inferenced like this..
from cdqa.utils.download import download_model, download_bnpp_data
download_bnpp_data(dir='./data/bnpp_newsroom_v1.1/')
download_model(model='bert-squad_1.1', dir='./models')
df = pd.read_csv('./data/bnpp_newsroom_v1.1/bnpp_newsroom-v1.1.csv', converters={'paragraphs': literal_eval})
df = filter_paragraphs(df)
df.head()
cdqa_pipeline = QAPipeline(reader='./models/bert_qa_vCPU.joblib')
cdqa_pipeline.fit_retriever(X=df)
query = 'How long BNP Paribas and IBM Services have a partnership?'
prediction = cdqa_pipeline.predict(X=query)  <--- ...An error occurs here...
...
RuntimeError: module must have its parameters and buffers on device cuda:0 (device_ids[0]) but found one of them on device: cpu
But, It worked fine when I ran this code.
cdqa_pipeline.cuda()
What is the problem...?

I found something strange.
It works well with model received using the download_model function from cdqa.utils.download.
(bert_qa_vCPU-sklearn.joblib)
However, it doesn't work well with the models i've trained by following the tutorials provided here.
So I did some tests as below...
from sklearn.externals import joblib
model1 = joblib.load('./models/bert_qa_vCPU-sklearn.joblib') # -> download model..
model2 = joblib.load('./models/bert_my_qa_vCPU-sklean.joblib') # -> my fined-tuned model..
type(model1.model), type(model2.model)
(pytorch_pretrained_bert.modeling.BertForQuestionAnswering,
torch.nn.parallel.data_parallel.DataParallel)
two results are different...so I added a line of code as below.
cdqa_pipeline.reader.model = cdqa_pipeline.reader.model.module
It works fine now...
If you don't mind, Would you explain about this?

Maybe it's related with last updates by Hugging Face...
I will investigate it further and make the necessary changes if needed

I just tried to train a new model and when print type(model.model) I get
pytorch_pretrained_bert.modeling.BertForQuestionAnswering

Not torch.nn.parallel.data_parallel.DataParallel...
Did you train the model with multiple GPUs with distributed training?
Thanks

Hi, andrelmfarias.
I used 8 GPUs(distributed training).
But now I understand what's wrong. Thanks for your help ndrelmfarias.


Funcargs

Support functional args for configuration

Codecov Report

Merging #421 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   57.91%   57.91%
=======================================
  Files          45       45
  Lines        5638     5638
=======================================
  Hits         3265     3265
  Misses       2071     2071
  Partials      302      302

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb94eb2...f859443. Read the comment docs.


Doc Request: Describe why "!important" styles will be stripped out of rendered HTML

I ran across something that sounded like a bug, but after discussion on the Elm Slack channel, might just be Elm protecting itself against discouraged CSS? If that's the case, some commentary in the docs would be helpful as to why this happens and when to expect it.
For example, I tried rounding the corners of a text input:
module Main exposing (..)

import Html exposing (Html, text)
import Html.Attributes

main : Html msg
main =
    Html.input [ Html.Attributes.style [ ( "borderRadius", "5px !important" ) ] ] []

This does nothing (you can inspect the rendered HTML and see it just renders <input>).
But, removing the !important will include the style in the generated HTML:
module Main exposing (..)

import Html exposing (Html, text)
import Html.Attributes

main : Html msg
main =
    Html.input [ Html.Attributes.style [ ( "borderRadius", "5px" ) ] ] []

This correctly yields: <input style="border-radius: 5px;">.
elm-make --warn also provides no feedback about this.
Environment
OS X Sierra
Elm 0.18
Chrome v.54.0.2840.98 (but it's not a rendering issue, you can see the raw HTML results in the inspector)

Just dropping a random opinion here:
As a person coming from JavaScript, my brain immediately translated Html.input [ Html.Attributes.style [ ( "borderRadius", "5px !important" ) ] ] into input.style.borderRadius = '5px !important'. If you paste document.body.style.backgroundColor = 'red !important' into the console, you'll see that it won't work. So for me, my reaction would be to look for JavaScript/DOM documentation on how to deal with !important in inline styles.
What about people who don't come from JavaScript? Are they expected to learn the DOM API? But on the other hand, are they supposed to know about !important? Elm doesn't mention !important in its docs.
(The only way I know of to set an inline style as !important in JavaScript, is to use code such as document.body.style.setProperty('background', 'red', 'important'). The setProperty method takes three parameters. Elm only takes two. If ( "borderRadius", "5px !important" ) is going to work, Elm would have to parse "5px !important" and look for the !important part in it. In other words, it would have to do extra work for every single inline style you create. The alternative would be to introduce a Html.Attributes.styleImportant function (which I personally wish won't happen ;) ).)

I am not a person coming from JS, but your first paragraph makes perfect sense. I didn't think through to what the JS assignment looked like under the hood. This kind of example would be perfect in the docs for how not to do something.

Workaround for anyone who needs !important as a style: use property: https://embed.ellie-app.com/36HYmxTRh5wa1/0

I don't really see a compelling reason to add support for this in this discussion, so I will leave the behavior as is. I would be interested to see compelling examples that prove that this is a good idea.
Anyway, thanks for bringing this up!


add Jenkins with build/test functionality and GitHub postback

With this, by adding the 'jenkins' label to your PR, Jenkins will run tests (currently only Travis equivalency) on it.

@duglin I went ahead and added the environment variable flag for kubectl. I also changed the filename to kubectl.sh; I know the intent was to make calling kubectl via docker notationally equivalent to calling it without, but it also obscures the filetype, causing me problems when trying to debug the TTY issue as I was treating it as a black-box binary. Let me know your thoughts.

@kibbles-n-bytes does this fix either #487 or #456?

@arschles No, this brings Jenkins up to Travis equivalency but it does not currently run the e2e tests, due to the changes in the controller and walkthrough I took that out temporarily and am working on adding that back in now.

@duglin Continuing the discussion out here, since I pushed the change to un-default TTY-less, so GitHub collapsed the discussion.
Having the TTY-less version be the alternative is fine by me, I was just hesitant to pollute setup-kubectl.sh and test-apiserver.sh with a bunch of "no tty" statements. I agree Jenkins is the odd-ball.
For kubectl vs. kubectl.sh, I feel like that's solved just as easily by making a simlink called kubectl and pointing it to kubectl.sh. And that way, it's clearer to both the user and anyone looking at our code what this file is actually doing. This isn't a Jenkins issue; this is just something that was confusing to me in general, as looking at the filename and extension, you expect it to be an executable, but it's actually a shell script.

@duglin That said, I'll go ahead and punt this for now, rename it, unblock this PR so we can get Jenkins in in some manner, and then open up a separate CL to see people's thoughts.

LGTM
would prefer to not have NO_TTY=1 on each line (just a bit verbose) though.

@kibbles-n-bytes does this close https://github.com/kubernetes-incubator/service-catalog/issues/487 and/or https://github.com/kubernetes-incubator/service-catalog/issues/456? If so, can you add Closes #12345 into the OP?

nevermind, I saw the answer above. Merging.


description "extension" is a bit confuse

actually is a script not an extension😀

Haha thanks for the clarity! Resolved in c68188be0493ed15b42f92ebb104c649f6c29dd4


Deprecated collection binding was much faster

I recently replaced the deprecated collection binding:
$collection(aCollection).bind($scope, 'bindingName');

with
$scope.bindingName = $meteor.collection(aCollection);

Unfortunately the performances drastically dropped. Displaying a list of those documents, I can imagine AngularJS has to redraw all the list each time a new document is inserted into the collection during the initial loading. Probably the bind function was using the same object references in order to allow AngularJS to only redraw modified items ? This does not seems to be the case using the affectation.

@Xample Can you share your use case and how you noticed the performance drop?
The new collection API still works with the collection reference so it should now redraw all the list when a new item is inserted.
But maybe we missed something..

Basically it is working but it looks like all the process is done within the main thread and stuck the UI the time the whole collection is loaded. The more the collection loads, the slower this even becomes so slow that the page even becomes irresponsive and I need to close it. I can hardly profile the page… will dig this more later if I can.
The venue is an entry using twitter bootstrap. Works like a charm with the bind function, here is the code (nothing more simple)

{{venue.name}}

{{venue.address}}

How big is your collection? Does it stop responding when the collection first loads or after an insert/update/delete operation?

The collection is 204 items, max 1mb of data (I am loading it locally so it is not a matter of bandwidth.)
First load but also after updating an item, deleting and inserting.
Same problem on Safari, Chrome and Firefox
After profiling, the root comes from the Tracker.flush function, then safeApply spending most of the time on equals and copy

Based on the timeout, perhaps this take 204 ticks (one per item) before the page to actually get reloaded ?
Here is the Chrome canary profile file http://wikisend.com/download/770096/CPU-20150228T200757.cpuprofile

A lot of time being spent in equals and copy means a long time is being spent inside the digest cycle traversing the object being watched, as far as I can tell.
The objects in your collection, do they have a lot of properties and sub properties?
If you can share your code or any reproduction i'd love to take a look.

A lot of properties yes, here below is one entry. For sharing the code I will message you
{
   "_id":"29",
   "originalData":{
      "Id":"29",
      "cat_id":"0",
      "company_id":null,
      "name":"The Observatory",
      "headline":"Afterwork drinks with the best view of the Palm",
      "image":"",
      "lat":"25.0877",
      "long":"55.1462",
      "address":"Dubai Marriott Harbour Hotel & Suites, Al Sufouh Road, Dubai Internet City, Dubai, 128358, United Arab Emirates",
      "summary":"Enticing. Tempting. Engaging. A feast for the eyes, the warm woods, custom lighting and modern décor help create the perfect setting for a dinner party with friends or business partners. With imposing views across Dubai, The Observatory is an audacious host. \n\nUnforgettable in its style and undeniable in its energy, The Observatory’s dynamic libations and cosmopolitan ambiance are as welcomed as the modish, melodious setting. As Dubai Marriott Harbour’s definitive destination venue, The Observatory serves up more than signature dishes and cocktails; it’s the ultimate night out.\n\n\n\n\n",
      "status":"1",
      "order":"29",
      "dt1":null,
      "dt2":null,
      "desp":null,
      "city":"dubai",
      "address2":"Marriott Hotel - Marina",
      "contact":"+97143194000",
      "happy_hours":"Saturday to Thursday: discounts on selected beverages",
      "dress_code":"Smart Casual",
      "check_in":"2",
      "photos":[
         {
            "Id":"50",
            "venu_id":"29",
            "photo":"1411028071.jpeg"
         },
         {
            "Id":"51",
            "venu_id":"29",
            "photo":"14110280711.jpeg"
         },
         {
            "Id":"52",
            "venu_id":"29",
            "photo":"14110280712.jpeg"
         }
      ],
      "hours":[
         {
            "Id":"1196",
            "venu_id":"29",
            "day_id":"Everyday",
            "time_id":"12.30pm - 1am"
         }
      ],
      "ratings":[

      ],
      "categories":[
         {
            "venue_id":"29",
            "cat_id":"4",
            "status":"0"
         },
         {
            "venue_id":"29",
            "cat_id":"5",
            "status":"0"
         }
      ]
   },
   "name":"The Observatory",
   "location":{
      "latitude":"25.0877",
      "longitude":"55.1462"
   },
   "address":"Marriott Hotel - Marina",
   "summary":"Enticing. Tempting. Engaging. A feast for the eyes, the warm woods, custom lighting and modern décor help create the perfect setting for a dinner party with friends or business partners. With imposing views across Dubai, The Observatory is an audacious host. \n\nUnforgettable in its style and undeniable in its energy, The Observatory’s dynamic libations and cosmopolitan ambiance are as welcomed as the modish, melodious setting. As Dubai Marriott Harbour’s definitive destination venue, The Observatory serves up more than signature dishes and cocktails; it’s the ultimate night out.\n\n\n\n\n",
   "city":"dubai",
   "cities":[
      "dubai"
   ],
   "contact":"+97143194000",
   "dressCode":"Smart Casual",
   "happyhours":[
      {
         "description":"Saturday to Thursday: discounts on selected beverages"
      }
   ],
   "ladiesnights":[

   ],
   "photos":[
      "1411028071.jpeg",
      "14110280711.jpeg",
      "14110280712.jpeg"
   ],
   "opening":[
      {
         "day":"Everyday",
         "hours":"12.30pm - 1am"
      }
   ],
   "categories":[
      "4",
      "5"
   ]
}

@Xample We've understood the difference and we found a few solutions, you can look at the different branches.
We are going to test them soon and update with the best one

Another thing you should notice is that the default  behavior in the new collection is to auto bind for changes. If you do not need that feature it will greatly improve your performance.
@Urigo should we consider making it not the default?

No I don't think so.
Have you seen my solution?

@Xample , while we are getting ready to release a new version that helps a lot in performance, looking at your code, it isn't even related to that.
The reason is that the default of the library is now autobind and default before (and in your code) is not to autobind.
So the solution for your problem is to simply pass a false in the second parameter, like that:
scope.bindingName = $meteor.collection(aCollection, false);

Closing this now, please re-open the problem still persist.
I will also update this issue when we get the new release although it's a different thing.

Good job guys ;-)

@Xample did it worked for you?

@Urigo using "false" as the parameter solved it, it is fluid again. I will check the new version one once released (if it is not the case already)