Can't advance to the next task

Challenge Compound Assignment With Augmented Subtraction has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

var a = 11;
var b = 9;
var c = 3;

// Only modify code below this line

a -= 6;
b -= 15;
c -= 1;

I am getting the following error:
Error 504 Ray ID: 346d5b5b486c716d • 2017-03-28 20:32:06 UTC

I refreshed the page and am now able to continue to the next task

@scriptingbear I'm glad you figured it out, I was just about to ask you to do that 😄
Happy coding!


warn user before opening large files

Hi,
I have some very large pickle files (1GB+). If I click on them by mistake, a python process will run to read them, and even if I close the editor straight away, the python process keeps running, using CPU and RAM.
I'd be nice to get a warning "are you sure you want to open ..." when the file is large!
Thanks for your work, G

Sounds good! Thanks for pointing out that the issue may cause poor user experiences. I will add a warning and enable one option to show partial content of the large file in the next version (planned to be released in the middle of Aug).

Cool, thanks!


Impossibility to modify ClientHello message

Expected behavior
Added handler before SSLHandler, that modifies ByteBuf containing ClientHello message allows successfull handshake.
Actual behavior
The Handshake falls on "Client Handshake Finished" step, while checking if the message was tampered with or not.
If we'll try to print the sent messages of the Client, we can see that is succeeds until
14 03 03 00 01 01 packet, that means that the Client indicates that it has calculated the shared encryption keys and that all following messages from the client will be encrypted with the client write key.
The following step is "Client Handshake finished", which fails with throwing exception (using Bouncy Castle as a Provider):
Caused by: javax.crypto.AEADBadTagException: mac check in GCM failed 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) Caused by: javax.crypto.AEADBadTagException: mac check in GCM failed 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) 	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) 	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490) 	at org.bouncycastle.jcajce.provider.symmetric.util.BaseBlockCipher$AEADGenericBlockCipher.doFinal(Unknown Source) 	at org.bouncycastle.jcajce.provider.symmetric.util.BaseBlockCipher.engineDoFinal(Unknown Source) 	at java.base/javax.crypto.CipherSpi.bufferCrypt(CipherSpi.java:826) 	at java.base/javax.crypto.CipherSpi.engineDoFinal(CipherSpi.java:730) 	at java.base/javax.crypto.Cipher.doFinal(Cipher.java:2497) 	at java.base/sun.security.ssl.SSLCipher$T13GcmReadCipherGenerator$GcmReadCipher.decrypt(SSLCipher.java:1929) 	at java.base/sun.security.ssl.SSLEngineInputRecord.decodeInputRecord(SSLEngineInputRecord.java:240) 	at java.base/sun.security.ssl.SSLEngineInputRecord.decode(SSLEngineInputRecord.java:197) 	at java.base/sun.security.ssl.SSLEngineInputRecord.decode(SSLEngineInputRecord.java:160) 	at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:111) 	... 31 more
This issue appears independently from any security provider.
Steps to reproduce

Create basic ChannelOutboundHandlerAdapter.
Check for ClientHello header
Modify any bytes inside
Add it before SSL Handler

Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.85 Final
JVM version (e.g. java -version)
openjdk version "11.0.17" 2022-10-18
OS version (e.g. uname -a)
Ubuntu 22.04
Possible solution for this can be using final ClientHello message that should be acquired from the handlers, for using not original but it in all following actions.

Show code where you're modifying TLS Client Hello.

Show code where you're modifying TLS Client Hello.

This is ChannelOutboundHandlerAdapter that I add to channel before SSLHandler
public class ClientHelloChannel extends ChannelOutboundHandlerAdapter {
    @Override
    public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise) throws Exception {
        //Copy buf not to rewrite existing
        var buf = ((ByteBuf) msg).copy();

        var bytes = new byte[buf.readableBytes()];
        buf.readBytes(bytes);

        //Check if is ClientHello message with Handshake header
        if (bytes[0] != 22 && bytes[3] != 1) {
            //write original buffer
            super.write(ctx, msg, promise);
            return;
        }

        System.out.println("Original bytes:" + new String(Hex.encodeHex(bytes)));

        //Wrap ClientHello with model
        var hello = new ClientHello(bytes);

        //Add cipher as a sample
        hello.getCipherSuites().getCiphers().add(CipherSuite.TLS_AES_128_CCM_SHA256);

        //Get bytes and write it to buf
        var newBytes = hello.getBytes();

        System.out.println("Modified bytes: " + new String(Hex.encodeHex(newBytes)));

        //Clear old buf and write new bytes
        buf.clear().writeBytes(newBytes);

        //Write modified buf
        super.write(ctx, buf, promise);
    }
}

Note, that I wrap ClientHello bytes into model class. BTW, It fully works, passing original bytes and getting again works fully.
This is output of ClientHello bytes (before and after) request to https://www.google.com:
Before:
16030301520100014e0303c52fde167668bdb42a272b860c12c53c3d21c28aa8a4f8942a3b1c7b7fbf157f20b5d49ac3ea3064b2c32fcabee2d260c5e068019f9df423414990c1bfd2ad335b0016c02cc02bc02fc030c013c014009c002f003513011302010000ef00000013001100000e7777772e676f6f676c652e636f6d000500050100000000000a00160014001d001700180019001e01000101010201030104000b00020100000d002c002a080708080403050306030804080508060809080a080b04010501060104020303030103020203020102020032002c002a080708080403050306030804080508060809080a080b04010501060104020303030103020203020102020011000900070200040000000000170000002b00050403040303002d00020101003300260024001d0020f0b7c6fb3828c78d3b7a378b5418926f6626fbca0a6f04b45a7331e769a91046ff01000100
After:
1603030154010001500303c52fde167668bdb42a272b860c12c53c3d21c28aa8a4f8942a3b1c7b7fbf157f20b5d49ac3ea3064b2c32fcabee2d260c5e068019f9df423414990c1bfd2ad335b0018c02cc02bc02fc030c013c014009c002f0035130113021304010000ef00000013001100000e7777772e676f6f676c652e636f6d000500050100000000000a00160014001d001700180019001e01000101010201030104000b00020100000d002c002a080708080403050306030804080508060809080a080b04010501060104020303030103020203020102020032002c002a080708080403050306030804080508060809080a080b04010501060104020303030103020203020102020011000900070200040000000000170000002b00050403040303002d00020101003300260024001d0020f0b7c6fb3828c78d3b7a378b5418926f6626fbca0a6f04b45a7331e769a91046ff01000100
As we see it added valid bytes of cipher inside. It doesn't matter If I change cipher, or simple shuffle them or even modify 1 byte of client random, it results with exception on last step of Client Handshake (I do get ServerHello).

Have a similar problem

@hyperxpro any ideas to this matter? Is there any ability to handle integrity check error?

Will check this soon.

@KVANTJVM if this produces a correct client hello it should work... I dont see why it shouldn't. Are you sure the ClientHello.getBytes() actually does the correct thing in terms of generating the packet length / client hello message length ?

Also is the exception be thrown on the client side or server side ?

@normanmaurer
Yes, it produces 100% right result and all length calculations are done correctly (rechecked multiple times).
It doesn't fail on sending but fails on reading the server's message on one of the steps, failing with "mac check failed" (that is integrity check against MITMing the TLS traffic, maybe).
This is full successful handshake: https://pastebin.com/04S1dupU
This is what it is able to read and write while modifiying the bytes: https://pastebin.com/uLgFDC4a
Password: nettyissue

Corrupted ClientHello isn't accepted by server at all, while I get several handshakes and fail on mac check.
This issue is pretty important for me, I will be glad to hear opinions by you.
Thanks.

@normanmaurer pastebin staff decided to delete the pastes so I attach a file
hello.txt

So I think there is nothing we can do about this as the SSLEngine itself does some verification. This is provided by the JDK itself.

@normanmaurer Verification should be 100%, in other case it would be big security hole. The solution for this error may be adding the ability to modify buffer when they are constructed, cause the ClientHello message that is sent is constructed on netty side and verification is made on initial buffer that netty constructed.
Like how it looks now:
CLIENT_HELLO_BYTES -> CONSTRUCT -> WRITE -> FLUSH
And when we modify it, it looks like: CLIENT_HELLO_BYTES -> CONSTRUCT -> WRITE -> MODIFY -> FLUSH
And then it fails, cause it checks the integrity with CLIENT_HELLO_BYTES
How I suggest to do this is:
CLIENT_HELLO_BYTES -> MODIFY -> CONSTRUCT -> WRITE -> FLUSH
Then the integrity check would be succeeded, because bytes are modified not on writing in the channel, but when the message is constructed.
I believe it would be good idea to add something like Handshake handler, cause It is not small problem, especially because of difference in JA3 fingerprints of HTTP clients and browsers, especially if you work with server that uses JA3 fingerprinting.
If you create own SSLSocketFactory with own SSLSocket implementation (or simply wrapping original and modifying startHandshake process). If you approach me to ClientHello handling (client side) in Netty Project, I believe I can try to make PR request, if not, I believe your team can implement it better than me.

The SSLEngine does add the bytes to the buffer which is provided by OpenJDK and not netty itself. I have a hard time to see how we can change anything that is done inside it. What I am missing ?

The SSLEngine does add the bytes to the buffer which is provided by OpenJDK and not netty itself. I have a hard time to see how we can change anything that is done inside it. What I am missing ?

SSLEngine by default is really restrictive. But you already provide own implementations (like JdkSslEngine) that wrap over default SSLEngine and in beginHandshake method you call wrapped engine's original method, while we can rewrite handshake process to add more scalability.
The same scenario as with SSLSockets and custom SSLSocketFactory.

@KVANTJVM I think this is not really something we want to provide.. You can do it by-yourself and inject the SSLEngine into the SslHandler constructor.

@normanmaurer Ok then, I believe we can close this issue as something that should user do himself.


New version: Microsoft.OneDrive.Insiders version 21.250.1205.0002

ARP entries are correct.
Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 1619
Microsoft Reviewers: Open in CodeFlow

x86 and x64 fail with 0x80072efd

x86 and x64 fail with 0x80072efd

A quick google search reveals this as a common Windows Problem
Non Microsoft reason: https://ugetfix.com/ask/how-to-fix-error-code-0x80072efd-on-windows-10/

The error code 0x80072efd might bother Windows 10 operating system users. However, in some cases, this error might cause problems to previous Windows versions users. Indeed, this error is related to the internet connection problems. This error might show up when trying to use or open Windows Store, installing updates, and sometimes when attaching new printers cameras or other devices to the computer for the first time. There are numerous reasons why this error might show up, and the majority of them are related to connection problems. Sometimes users receive this error because firewall or local network prevents the computer from connecting to the Windows Update site. However, most of the time Proxy server settings are responsible for interfering connection to the Windows Updates, so all you have to do to fix 0x80072efd error is to disable Proxy.

.

/azp run

@denelon...

@yao-msft here is another one.

@ryfu-msft

@denelon

/azp run


Dusk Frontend performance and test

Add Laravel dusk and a test to the build.
composer require --dev laravel/dusk

Can't get dusk to work on an M1 shifted testing to artisan test command using PhpUnit.


Using linux environment variable in cgo failed

What version of Go are you using (go version)?

$ go version 1.15.6

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/bill/.cache/go-build"
GOENV="/home/bill/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/bill/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/bill/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.15"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.15/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build550771112=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Using cgo to load a shared library in linux.

tree
.
├── inc
│   └── mylib.h
├── libmylib.so
├── main.go
├── mylib.o
└── src
    └── mylib.c

src/mylib.c

#include

void PrintHello()
{
    printf("Hello\n");
}

inc/mylib.h

void PrintHello();

main.go

package main

/*
#cgo linux CFLAGS: -I${LIB_PATH}/inc
#cgo linux LDFLAGS: -lmylib
#cgo linux LDFLAGS: -L${LIB_PATH}/cgo
#include "mylib.h"
*/
import "C"

func main() {
        C.PrintHello()
}

Compile shared library

gcc -fPIC -c src/mylib.c
gcc -shared mylib.o -o libmylib.so

Set the env.

export LIB_PATH=/home/bill/project/cgo
export LD_LIBRARY_PATH=/home/bill/project/cgo

run the code

go run main.go
/home/bill/project/cgo/main.go: malformed #cgo argument: -I${LIB_PATH}/inc

What did you expect to see?
No environment var is ok

package main

/*
#cgo linux CFLAGS: -I/home/bill/project/cgo/inc
#cgo linux LDFLAGS: -lmylib
#cgo linux LDFLAGS: -L/home/bill/project/cgo
#include "mylib.h"
*/
import "C"

func main() {
        C.PrintHello()
}

go run main.go
Hello

Just remove ${LIB_PATH} in cgo arguments and put all files in the package.

You might want to check "C_INCLUDE_PATH" and setting
https://gcc.gnu.org/onlinedocs/gcc/Environment-Variables.html
and use Makefile to overwrite these enviorment values.

Just remove ${LIB_PATH} in cgo arguments and put all files in the package.
You might want to check "C_INCLUDE_PATH" and setting
https://gcc.gnu.org/onlinedocs/gcc/Environment-Variables.html
and use Makefile to overwrite these enviorment values.

So I can't load library in different folder? It seems not convenience.

Just remove ${LIB_PATH} in cgo arguments and put all files in the package.
You might want to check "C_INCLUDE_PATH" and setting
https://gcc.gnu.org/onlinedocs/gcc/Environment-Variables.html
and use Makefile to overwrite these enviorment values.

So I can't load library in different folder? It seems not convenient.

That's what I mean in "2", for example: export C_INCLUDE_PATH=$C_INCLUDE_PATH:/your-custom-include-path

Just remove ${LIB_PATH} in cgo arguments and put all files in the package.
You might want to check "C_INCLUDE_PATH" and setting
https://gcc.gnu.org/onlinedocs/gcc/Environment-Variables.html
and use Makefile to overwrite these enviorment values.

So I can't load library in different folder? It seems not convenient.

That's what I mean in "2", for example: export C_INCLUDE_PATH=$C_INCLUDE_PATH:/your-custom-include-path

https://golang.org/cmd/cgo/#hdr-Using_cgo_with_the_go_command
only ${SRCDIR} can be accept?
When the cgo directives are parsed, any occurrence of the string ${SRCDIR} will be replaced by the absolute path to the directory containing the source file. This allows pre-compiled static libraries to be included in the package directory and linked properly. For example if package foo is in the directory /go/src/foo:

// #cgo LDFLAGS: -L${SRCDIR}/libs -lfoo


Add Instant primitive type

Adds parser, storage and refinement support for a first pass implementation of Instant (which corresponds with Javascript's Date and Java/Kotlin's Instant).
It is meant as a first pass, so there are some fixes that are probably not production ready (e.g. there is no duration type, we auto-cast Instant to milliseconds and back where necessary). The SQL implementation is also only in the sql-refinement-generator which I believe is not fully integrated into the storage service.

Note about CLAs: the bot has missed that my chromium, personal and work emails are all me and the same CLA covers all my work for Google. I'll update my git config and make sure future CLs are in my person email (so there's just one me).

Docker failure, re-running
/gcbrun

/gcbrun
I think this was a build system flake (not our code), Planning to land this soon with clean up CLs later.

Note: Cloud build succeeded here https://pantheon.corp.google.com/cloud-build/builds/171025f0-2e6b-4143-b5c1-e1fdadb9f7aa?project=arcs-265404


Is JavaScriptSnippet.FullScript Deprecated?

This quickstart suggests inserting a JS blob into the page to initiate tracking. Is the use of JavaScriptSnippet.FullScript not recommended/deprecated?
Sample
@inject Microsoft.ApplicationInsights.AspNetCore.JavaScriptSnippet JavaScriptSnippet
<!DOCTYPE html>
<html lang="en">
<head>
// ... other header content
@Html.Raw(JavasScriptSnippet.FullScript)
// ... other header content
</head>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e18bc26a-c050-89ba-a4a2-111bfa7ac9e1
Version Independent ID: e4e26c83-5f08-72e7-a1f3-b0e0797bbadd
Content: Quickstart with Azure Application Insights
Content Source: articles/azure-monitor/learn/dotnetcore-quick-start.md
Service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

Nope, not deprecated, the most up-to-date recommendation from the engineering team is here and is using the method you described: https://docs.microsoft.com/en-us/azure/azure-monitor/app/asp-net-core-no-visualstudio#enable-client-side-telemetry-for-web-applications.
If using the Visual Studio Application Insights configuration approach that is described in the Quickstart the client-side JS will automatically get added for you so the JS blob insertion is not necessary. I will pull that from this quickstart as it is likely causing confusion. Thanks for calling that out!

The change to fix this is merged internally, it will go-live in the public docs between 3-4 PM (UTC-7). Thanks again for helping make our docs better!

@itanex Thank you for reaching out to us!  If you have any further questions, please tag me in your reply and we will be happy to continue the conversation.

@kobulloc-MSFT So do we need to add this or not, documentation still has it listed....

@bbakermmc  if you add Application Insights to .NET Core via Visual Studio using the Add > Application Insights Telemetry enablement experience client-side monitoring is automatically added for you, but you can always check _ViewImports.cshtml _Layout.cshtml to confirm.
If you add Application Insights manually in VS Code or with some other IDE you need to follow the steps to add client-side monitoring described here:
https://docs.microsoft.com/en-us/azure/azure-monitor/app/asp-net-core#enable-client-side-telemetry-for-web-applications
The doc for how to monitor .NET Core without Visual Studio was consolidated into this doc after this PR thread was closed. In retrospect the H2 should be modified to ##Enable client-side telemetry for web applications (No Visual Studio) to make clear this should only be needed for non Visual Studio projects. I will take care of that to avoid further confusion. Thanks for calling this out!


Please support feature duplicate lines

VSCode Version: Code 1.12.2 (19222cdc84ce72202478ba1cec5cb557b71163de, 2017-05-10T13:16:25.899Z)
OS Version: Linux x64 4.10.0-21-generic

I want VS Code have feature duplicate lines and its hot key. Thanks!

Have you seen the command "copy line down" (alt+shift+down)? Does that help?

No, that hotkey can only select continuous lines!
On Sun, May 28, 2017, 10:16 Rob Lourens<EMAIL_ADDRESS>wrote:

Have you seen the command "copy line down" (alt+shift+down)? Does that
help?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/27355#issuecomment-304489907,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGYN6299ys-EfEQ7yP_F0Pkl8FlRi6yTks5r-OcJgaJpZM4NoNCA
.

What if you have multiple cursors active? Can you be more clear about what you want?

(alt+shift+down) can only right if I want to edit continuous lines such as 1,2,3,4,5. But if I want to edit lines: 1,23,45,67,..., I can't use it.
I am using Ubuntu and Alt+Click is an Ubuntu hotkey used for moving window. So I cannot use Alt+Click in VS Code.
Do you have any workaround solution?

Ok, it sounds like the real problem is not being able to use alt+click to add a cursor on Ubuntu. @Tyriar is there a way around that? Can the user rebind that command?

Since Friday, there is editor.multicursorModifier that can be set to ctrl to add multiple cursors via ctrl + click.

@alexandrudima Can you provide VS Code version? I am using 1.12.2.

It will be available in 1.13 next week or the Insiders build right now: https://code.visualstudio.com/insiders


fix includepath for @import in scss for component.scss

Fixes #363
Using @import in a component .scss file

@sanderbos1402 much appreciated 💯


README could use more examples for options to uglify()

Say we have:
 pump([
        gulp.src('lib/*.js'),
        uglify(),
        gulp.dest('dist')
    ],

which options can we pass to uglify()?
Are the options verbatim what's documented in the uglifyjs2 project?
Specifically I am looking to strip console.log / console.error statements from my front-end code.

It says to drop console, use this:
drop_console -- default false. Pass true to discard calls to console.* functions. If you wish to drop a specific function call such as console.info and/or retain side effects from function arguments after dropping the function call then use pure_funcs instead.
My guess is that this will work:
 pump([
        gulp.src('lib/*.js'),
        uglify({dropConsole:true}),
        gulp.dest('dist')
    ],

but this is just a guess, and I hate guessing :/

but I get this:
[14:24:10] Using gulpfile ~/WebstormProjects/cisco/cdt-now/gulpfile.js
[14:24:10] Starting 'compress'...
[14:24:10] 'compress' errored after 51 ms
[14:24:10] GulpUglifyError: unable to minify JavaScript
Caused by: DefaultsError: `dropConsole` is not a supported option
File: /Users/alexamil/WebstormProjects/cisco/cdt-now/public/app.js

:(

That option is a compress option, so it needs to be provided in the compress section.
 pump([
        gulp.src('lib/*.js'),
        uglify({
                compress: {
                        drop_console: true
                }
        }),
        gulp.dest('dist')
    ],

PR requests accepted for examples.

ok thanks! :)

That would be a great addition to the README btw


imp: do not store total escrow when amount is zero

Description

closes: #3549
Commit Message / Changelog Entry
N/A

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (see CONTRIBUTING.md).
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[x] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report

Merging #3585 (4efa203) into feat/total-escrow-state-entry (5b6e8b4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 4efa203 differs from pull request most recent head a8ed946. Consider uploading reports for the commit a8ed946 to get more accurate results

Additional details and impacted files

@@                      Coverage Diff                       @@
##           feat/total-escrow-state-entry    #3585   +/-   ##
==============================================================
  Coverage                          78.82%   78.83%
==============================================================
  Files                                183      183
  Lines                              12713    12719    +6
==============================================================
+ Hits                               10021    10027    +6
  Misses                              2261     2261
  Partials                             431      431

Impacted Files
Coverage Δ

modules/apps/transfer/keeper/keeper.go
89.18% <100.00%> (+0.61%)
:arrow_up:


add node-osc example

Basic example of sending osc messages through a nodeJS server, and then share them through a websocket server.

update list in readme

thank you very much

thank you very much


[modify] reduce complexities

Coverage decreased (-0.06%) to 79.517% when pulling e6e326ae1dcd56111b8e0e4a71da617de627d92b on sunny4381:features/reduce-complexities into cb90df60a67accc80d00be8437623cf27e05ee7f on shirasagi:master.


[bug] Java compiler version 21 has deprecated support for compiling with source/target version 8

Describe the bug
I'm not entirely sure, but I've followed all of the instructions for getting Android up and running.
My environment has the following:
joseph@Josephs-MBP-2 test-app % echo $JAVA_HOME
/Applications/Android Studio.app/Contents/jbr/Contents/Home

But when I attempt to run Android in dev, it gives me the following error:
Java compiler version 21 has deprecated support for compiling with source/target version 8.
Try one of the following options:
    1. [Recommended] Use Java toolchain with a lower language version
    2. Set a higher source/target version
    3. Use a lower version of the JDK running the build (if you're not using Java toolchain)
For more details on how to configure these settings, see https://developer.android.com/build/jdks.
To suppress this warning, set android.javaCompile.suppressSourceTargetDeprecationWarning=true in gradle.properties.
warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
3 warnings

And then the tauri android dev command exits.
So I can obviously change the JAVA_HOME to point to a different JDK version
Anyone have any idea what the issue is?
Reproduction
No response
Expected behavior
No response
Full tauri info output
joseph@Josephs-MBP-2 test-app % npx tauri info

[✔] Environment
    - OS: Mac OS 14.7.1 arm64 (X64)
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.82.0 (f6e511eec 2024-10-15)
    ✔ cargo: 1.82.0 (8f40fc59f 2024-08-21)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-aarch64-apple-darwin (default)
    - node: 22.11.0
    - pnpm: 9.14.2
    - yarn: 4.2.2
    - npm: 10.9.0

[-] Packages
    - tauri 🦀: 2.1.1
    - tauri-build 🦀: 2.0.3
    - wry 🦀: 0.47.2
    - tao 🦀: 0.30.8
    - @tauri-apps/api : 2.1.1
    - @tauri-apps/cli : 2.1.0

[-] Plugins
    - tauri-plugin-shell 🦀: 2.0.2
    - @tauri-apps/plugin-shell : 2.0.1

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: React
    - bundler: Vite

[-] iOS
    - Developer Teams: None

Stack trace
No response
Additional context
No response

deprecated doesn't mean it won't work (in theory at least). Is there no other error? Does it work if you download java 17 and point JAVA_HOME to that as you mentioned?

Thanks for the response, but now that its (my computer) had the night to think about, its decided to work....
I've copied the whole of the output below just for reference. The one thing I did that is maybe different is I kept Android studio open while debugging.

Try one of the following options:
    1. [Recommended] Use Java toolchain with a lower language version
    2. Set a higher source/target version
    3. Use a lower version of the JDK running the build (if you're not using Java toolchain)
For more details on how to configure these settings, see https://developer.android.com/build/jdks.
To suppress this warning, set android.javaCompile.suppressSourceTargetDeprecationWarning=true in gradle.properties.
warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
3 warnings
Java compiler version 21 has deprecated support for compiling with source/target version 8.
Try one of the following options:
    1. [Recommended] Use Java toolchain with a lower language version
    2. Set a higher source/target version
    3. Use a lower version of the JDK running the build (if you're not using Java toolchain)
For more details on how to configure these settings, see https://developer.android.com/build/jdks.
To suppress this warning, set android.javaCompile.suppressSourceTargetDeprecationWarning=true in gradle.properties.
warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
3 warnings
Performing Streamed Install
Success
Starting: Intent { cmp=com.test_app.app/.MainActivity }
E1126 21:35:39.114911 fc6f000 FrameBuffer.cpp:3619] Failed to find ColorBuffer:0
E1126 21:35:39.470628 fe7b000 FrameBuffer.cpp:3619] Failed to find ColorBuffer:0


[Run][Indexer] Define portable apps folder

📝 I would like to start portable apps which I have stored in a specific folder.
When I start the Run plugin and start typing a name of a portable app, I would like the plugin to also offer me executable files found in the portable apps' folder. Ideally, I would want this with the Windows indexing service disabled (as I have now, since I only have fast drives in my computer), but I would also be willing to enable indexing, if necessary.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@marko-p
It can be done if you are willing to enable indexing.
 You should be able to add your folder to indexing.

@marko-p
It can be done if you are willing to enable indexing.
 You should be able to add your folder to indexing.

@marko-p I'm trying to see what that folder is but would love to get some clarity from you, can you give us some more detail about it?  This may be easy as just us detecting the folder but i'm unsure how to create one.
@mykhailopylyp he wants to be able to do this with indexer disabled.  I think maybe a better way to view this is have the application plugin maybe have a list of user defined folders as well it scans

@marko-p I'm trying to see what that folder is but would love to get some clarity from you, can you give us some more detail about it?  This may be easy as just us detecting the folder but i'm unsure how to create one.
@mykhailopylyp he wants to be able to do this with indexer disabled.  I think maybe a better way to view this is have the application plugin maybe have a list of user defined folders as well it scans

Thanks for answering! As @mykhailopylyp suggested, I added my portable apps folder to be indexed. It is usable, although it seems to me, that:

executable files are not prioritized over other files and folders (I would mainly use PT Run to run apps)
installed applications get a precedence over portable apps (even if I search for and choose the portable app multiple times over the installed app - for example searching for "fire" always offers Win Firewall over Firefox, even though I never chose the Firewall and ran Firefox multiple times)

Thanks for answering! As @mykhailopylyp suggested, I added my portable apps folder to be indexed. It is usable, although it seems to me, that:

executable files are not prioritized over other files and folders (I would mainly use PT Run to run apps)
installed applications get a precedence over portable apps (even if I search for and choose the portable app multiple times over the installed app - for example searching for "fire" always offers Win Firewall over Firefox, even though I never chose the Firewall and ran Firefox multiple times)

@crutkas I'm not sure how others handle portable apps, but I've created a dedicated folder where I copy all portable apps. For example, I manually create a folder C:\PortableApps\ and copy/extract all portable apps there. As I first imagined, it would be useful to tell PT Run that I also want it to (periodically) scan for executable files in that folder.

@crutkas I'm not sure how others handle portable apps, but I've created a dedicated folder where I copy all portable apps. For example, I manually create a folder C:\PortableApps\ and copy/extract all portable apps there. As I first imagined, it would be useful to tell PT Run that I also want it to (periodically) scan for executable files in that folder.

@marko-p

installed applications get a precedence over portable apps (even if I search for and choose the portable app multiple times over the installed app - for example searching for "fire" always offers Win Firewall over Firefox, even though I never chose the Firewall and ran Firefox multiple times)

We improved it in 31 release. https://github.com/microsoft/PowerToys/issues/2092.

@marko-p

installed applications get a precedence over portable apps (even if I search for and choose the portable app multiple times over the installed app - for example searching for "fire" always offers Win Firewall over Firefox, even though I never chose the Firewall and ran Firefox multiple times)

We improved it in 31 release. https://github.com/microsoft/PowerToys/issues/2092.

just trying to validate terminology, portable app => a self contained app like sysinternal procexp?  correct?

just trying to validate terminology, portable app => a self contained app like sysinternal procexp?  correct?

@crutkas Yes, I guess that would be the correct term. Process Explorer is a "portable app", but many others can also be made "portable": https://en.wikipedia.org/wiki/PortableApps.com or are provided as such by the original authors. I don't have admin rights in my corporate environment and I prefer using such self contained apps over nagging my IT department for small utilities which come in handy from time to time.
I'm looking forward for the 31 release. Would it be possible to limit Run to only display executable files in indexed folders?

@crutkas Yes, I guess that would be the correct term. Process Explorer is a "portable app", but many others can also be made "portable": https://en.wikipedia.org/wiki/PortableApps.com or are provided as such by the original authors. I don't have admin rights in my corporate environment and I prefer using such self contained apps over nagging my IT department for small utilities which come in handy from time to time.
I'm looking forward for the 31 release. Would it be possible to limit Run to only display executable files in indexed folders?

Yes @mykhailopylyp the issue at #12491 remains, and also all the issues detailed above.

To add some details, because in the past I used Launchy and Wox.
There is the PortableApps platform (portableapps.com), which enables the user to download compiled apps and it stores them in folders. No installation.
Like, PortableApps/FileZillaPortable/FileZillaPortable.exe
But, this is the launcher binary. The actual real binary is there PortableApps/FileZillaPortable/App/filezilla/filezilla.exe along with fzsftp.exe and other stuff.
If the user indexes the entire PortableApps folder, they'll have multiple "Filezilla" appearing in the search results.
Feature https://github.com/microsoft/PowerToys/issues/2092 kinda takes care of that with bumping the most used one at the top of the search... but it's still "meh". Because the search results will get cluttered regardless.
In the past, using Launchy or Wox can't remember, I was able to solve this by specifying a folder deph to an indexed folder.
That way I could take only +1 level from my PortableApps root folder, indexing only the launchers binaries, and not the other stuff deeper. And then it was perfect.
Hope this gives the devs some ideas!

In the past, using Launchy or Wox can't remember, I was able to solve this by specifying a folder deph to an indexed folder

That's an interesting approach for sure. Still, imo this request could use a wider focus than just 'portable' apps; more generically:
'allow configuring directories or even paths to applications so they are considered by Run' (and possibly implemented by the Program plugin, that seems to make most sense).
My typical usecase: desktop application developer for multiple clients and I have quite a lot of applications residing in build output directories, a lot of different ones too, and they cannot be in the system PATH (name/dll clashes) nor is it interesting to create links for those applications all in one directory (e.g. because debug and release versions have the same .exe name). These directories also aren't indexed now (could be, not sure how well that works with content changing on every build). Currently I launch these applications from PS history or aliases, but hey, PT Run is a launcher after all so would make sense if it could do that :)

Any progress on this issue?
Would love to see this feature implemented

Would also like to see this

It seems there is an option in %LocalAppData%\Microsoft\PowerToys\PowerToys Run\Settings\Plugins\Microsoft.Plugin.Program\ProgramPluginSettings.json to configure this and the setting is referenced here. The problem is that there's no UI to set it and when you set it manually, it gets cleared upon both launch and exit.
"ProgramSources": [],
 "DisabledProgramSources": [],
 "ProgramSuffixes": [
   "bat",
   "appref-ms",
   "exe",
   "lnk",
   "url"
 ],
 "RunCommandSuffixes": [
   "bat",
   "appref-ms",
   "exe",
   "lnk",
   "url",
   "cpl",
   "msc"
 ],


Loading-Issue on iphone-only

Hi, I'm using dayjs for a timeline-map based https://github.com/skeate/Leaflet.timeline.
The JSON that holds to date-iso8601-information has about 3600 data-points and a size of about 950kb.
Everything is working fine on any device but the iphone (iOS 13, Firefox/Safari/Chrome) with the following code and json-structure:
var pointTimeline = L.timeline(rechts, {
    onEachFeature: onEachFeature,
    style: function (feature) {
        return {
            radius: 5,
            color: 'red',
            fillColor: '#fff',
            fillColor: '#FFFFFF',
            fillOpacity: 1
        }
    },
    pointToLayer: function (feature, latlng) {
        return L.circleMarker(latlng, pointTimeline);
    }
});

var slider = L.timelineSliderControl({
    formatOutput: function (date) {
        return moment(date, 'YYYY-MM-DDTHH:mm').format("DD.MM.YYYY");
    },
    enableKeyboardControls: true,
});
map.addControl(slider);
pointTimeline.addTo(map)
slider.addTimelines(pointTimeline);

    { "type": "Feature", "properties": { "start": "2019-01-01T00:00", "end": "2019-01-01T23:59", "datum": "Dienstag, 1. Januar 2019", "Tatort": "Erkelenz", "Deliktsgruppe": "Volksverhetzungsdelikt" }, "geometry": { "type": "Point", "coordinates": [ 6.31559, 51.07967 ] } },
If I reduce the file to >800kb the map get loaded on iOS. Does anyone has any explanation on that issue?
iPhone:

Android:

Thanks for opening this request.
This is a great question for Stack Overflow.


fix: Added clarification and link to secrets configuration.

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


MAINT: forward port 1.10.0 relnotes

forward port the SciPy 1.10.0 release notes and the docs version switcher following the
release this evening

reviewers may want to wait for the new docs to be deployed though

I should have skipped all but the docs CI as well, woops

thanks, Ralf deployed here: https://github.com/scipy/docs.scipy.org/pull/72#issuecomment-1370700396


Issue with mapWithKeys

Larastan Version: 1.0.1
--level used: 7
Pull request with failing test: I'm sorry I'm currently unable to submit a PR

Description
Using a Collection mapWithKeys which return a string key, I get the error:
Parameter #1 $callback of method Illuminate\Support\Collection<int,string|false>::mapWithKeys()
expects callable(string|false, int): array,
Closure(string): non-empty-array<string, string> given.

It expects an array, and it receives an non-empty-array, so there should be no error if I'm not mistaken.
Laravel code where the issue was found
        $names= $files->mapWithKeys(function (string $path) {
            return [basename($path) => $path];
        });

Hello David!
Thank you for your report.
I think this is a PHPStan issue: a non-empty-array doe not suffice a general array.

For reference, the question and answer on PHPStan: https://github.com/phpstan/phpstan/discussions/5967

I was looking for the word: contravariant.


Window name is not null terminated in X11

This is set here:
https://github.com/linebender/druid/blob/5fa4ce51ed3d74640388de6385f135c50d346c8d/druid/src/app.rs#L107
This is reproducible with the following C code snippet:
xcb_get_property_reply_t *name_reply = xcb_get_property_reply(conn, xcb_get_property(conn, 0, window, XCB_ATOM_WM_NAME, XCB_ATOM_STRING, 0, 256), NULL);
if (name_reply) {
    char *name = xcb_get_property_value(name_reply);
    ...

name for a druid application is 61 70 70 2d 6e 61 6d 65 11 01 which is app-name
It should be 61 70 70 2d 6e 61 6d 65 00 which is app-name
This is only an issue for Druid applications. I have not been able to reproduce it in a hello-world application for Iced, GTK, or QT.

Ok this is interesting, and I haven't found an authoritative source for what the correct behavior is. In the X11 protocol itself, the string is encoded with a length so it doesn't need to be null-terminated. And I found this thread where dwm is discussing whether WM_NAME should be null-terminated. I think they end up deciding not to, but it isn't clear whether this applies to _NET_WM_NAME. We should check to see exactly what GTK and Qt do here...

I propose to close this bug report as invalid.

This is reproducible with the following C code snippet:

That C code is wrong. libxcb only exposes the X11 wire protocol and X11 does not null-terminate its strings. Please fix your code to use xcb_get_property_value_length() and only read that many bytes from the result of xcb_get_property_value(). Copy the data if you need to add a null terminator.
Random code sample: https://github.com/awesomeWM/awesome/blob/0e5fc4575ab0adbae75908cb49937d9cf63437ec/common/xutil.h#L46-L51
However, the X11 protocol pads many things to a multiple of four bytes (in this case: Replies are always a multiple of four bytes long) and the padding is AFAIK always a null byte, so these kind of bugs are relatively common in code using libxcb. It goes wrong too seldomly.
Here is a screenshot of Wireshark for a GetPropertyReply for a window with title 1234 (dunno why Wireshark didn't recognise the reply type). You see that the "1234" is right at the end of the packet without a \0 afterwards:

And here is the same thing for a window with title "1234567". This is one byte short for a multiple of four and thus padded with a zero byte.

We should check to see exactly what GTK and Qt do here...

Well... random example:
$ xtrace gvim | grep ChangeProperty | grep WM_NAME
No display name to create specified, trying :9
Got connection from unknown(local)
Got connection from unknown(local)

(gvim:11916): dbind-WARNING **: 14:24:24.357: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
000:<:0071: 28: Request(18): ChangeProperty mode=Replace(0x00) window=0x04000001 property=0x163("_NET_WM_NAME") type=0x154("UTF8_STRING") data=0x67,0x76,0x69,0x6d;
000:<:0072: 28: Request(18): ChangeProperty mode=Replace(0x00) window=0x04000001 property=0x27("WM_NAME") type=0x1f("STRING") data='gvim'
000:<:00a1: 28: Request(18): ChangeProperty mode=Replace(0x00) window=0x04000003 property=0x163("_NET_WM_NAME") type=0x154("UTF8_STRING") data=0x56,0x69,0x6d;
000:<:00a2: 28: Request(18): ChangeProperty mode=Replace(0x00) window=0x04000003 property=0x27("WM_NAME") type=0x1f("STRING") data='Vim'
000:<:00ab: 28: Request(18): ChangeProperty mode=Replace(0x00) window=0x04000001 property=0x163("_NET_WM_NAME") type=0x154("UTF8_STRING") data=0x56,0x69,0x6d;
000:<:00ac: 28: Request(18): ChangeProperty mode=Replace(0x00) window=0x04000001 property=0x27("WM_NAME") type=0x1f("STRING") data='Vim'
000:<:01b1: 44: Request(18): ChangeProperty mode=Replace(0x00) window=0x04000003 property=0x163("_NET_WM_NAME") type=0x154("UTF8_STRING") data=0x5b,0x55,0x6e,0x62,0x65,0x6e,0x61,0x6e,0x6e,0x74,0x5d,0x20,0x20,0x2d,0x20,0x56,0x49,0x4d;
000:<:01b2: 44: Request(18): ChangeProperty mode=Replace(0x00) window=0x04000003 property=0x27("WM_NAME") type=0x1f("STRING") data='[Unbenannt]  - VIM'

Clearly no zero bytes in the data of _NET_WM_NAME.  Sadly, xtrace decodes the WM_NAME request and does not show the raw contents. But I tell you: There is no zero byte in there either.
(I don't think I have any Qt apps laying around to test this with, but I can guarantee you that they also do not add that byte to the end of their window titles.)

Thanks for the detailed information!


TestIntegration_FileSystem_Lint fails on windows

https://ci.appveyor.com/project/sourcegraph/go-langserver/builds/19433013#L40
2018/10/11 13:44:23 warning: lint command stderr: "warning: \"/C:/Users/appveyor/AppData/Local/Temp/1/langserver-go-integration705672984/gopath/src/test/p/...\" matched no packages\n"
--- FAIL: TestIntegration_FileSystem_Lint (10.07s)
    integration_test.go:518: Timeout while waiting for notification of type *lsp.PublishDiagnosticsParams
2018/10/11 13:45:37 refs.DefInfo: not a package-level definition (ident: x, object: var x map[string]test/pkg/a.A) and unable to follow type (type: map[string]test/pkg/a.A)

I wonder if this is a result of changing the pattern passed to golint to include rootFSPath (see #321).
I'm also not familiar with windows pathing, but it looks like the path is prefixed with an extra /.

Yeah windows is mysterious to me and I don’t have an env for it to iterate. I did quite a few attempts via appveyor to work it out, but gave up.

I think I can borrow a machine to look into this with. If I can find a solution I will submit a PR. I’ll provide an updated either way.

Thank you!!


Factor outputs name conflicts

Coverage increased (+0.04%) to 81.723% when pulling 1e846b709d07b275465974663030967baa4c09ac on outputs-name-conflicts into 96ec1fd639cf8310ffe978af441e8053cc796237 on master.

Coverage increased (+0.04%) to 81.723% when pulling 8089496af235cbea5a0cce50fdf59f42f4857e32 on outputs-name-conflicts into 96ec1fd639cf8310ffe978af441e8053cc796237 on master.

@ssanderson Ready for a look

Coverage increased (+0.04%) to 81.794% when pulling 9546ed4cad53c320c6eec6f9203eb1afe6b9c138 on outputs-name-conflicts into d34b1b9224edf2583bcb43d59f78e66eee11debd on master.

Coverage increased (+0.04%) to 81.799% when pulling a54cb4f5a1dc3b628f2d788b44125980da7afa0c on outputs-name-conflicts into d0890085bd1ecf867e6c31f6fd086286287e3178 on master.


Support both ref & rev in flake input url

Describe the bug
Currently when I try to use both ref and ref in flake input url I get:
error: URL 'github:ipetkov/crane?ref=v0.12.1&rev=445a3d222947632b5593112bb817850e8a9cf737' contains both a commit hash and a branch/tag name v0.12.1 445a3d222947632b5593112bb817850e8a9cf737

Steps To Reproduce
Use an flake input url that has both ref and rev (that point at the same commit).
Expected behavior
I think it should be supported. nix should just verify that that ref is still pointing at that rev.
rev is for pinning to a hash for security/reliability, while ref is for letting humans reading the code know which release version is it. One could put the ref in a comment, but then there's nothing to make sure it's not incorrect.

This issue should probably be on https://github.com/NixOS/nix instead

Thank you. Moved to https://github.com/NixOS/nix/issues/8226


Make routing more consistant

Currently in proxy dev-mode, META-INF/resources has priority over Quinoa and not in prod mode.

Proxy dev-mode and prod mode behave the same,  META-INF/resources has priority over Quinoa.
Introduce quarkus.quinoa.ignored-path-prefixes

ping @sberyozkin @geoand @maxandersen

sorry @sberyozkin, I meant to ping @ebullient, not sure how this happened TBH..

Hey @ia3andy Np at all, I've just noticed this ping in my non-RH email account, PR LGTM nonetheless :-)


Bug: Auto-summarize and Add-and-sumarize do not work

Describe the bug
The Auto-summarize and the Add-and-summarize button on the Hightlights suggestion section are not working properly in the highlight creation process.
When trying to use either functionality with a valid GitHub PR links, the following error message is shown: "Oops! Auto-Summarize not supported for current link!"

No console errors are displayed:

Steps to reproduce

Go to app.opensauced.pizza/feed.
Click on the "Post a highlight to show your work!" input.
Paste the URL of a GitHub pull request.
Click the Auto-Summarize button.

To test the Add-and-Summarize button:

Clear the input field.
Choose a PR from the Highlight Suggestion pages.
Click the Add-and-Summarize button.

Can confirm this is still happening


Changing quantum computation model in algorithm view is not possible

Changing the quantum computation model in the algorithm view is not possible. No request is sent to the backend

This works now, closing. Not sure when it was implemented. Just tested it.


Using @JsonValue on an enum with Lombok

Responding to this comment by @harvanchik which was deleted from springdoc/springdoc-openapi/issues/1244 by the project owner:

Is it possible to combine this with lombok? This did not work.
@Getter @JsonValue
public enum DevelopmentPhase {

    UNKNOWN(0, "Unknown"),
    BETA(1, "Beta"),
    GAMMA(2, "Gamma"),
    PRODUCTION(3, "Production"),
    MAINTENANCE(4, "Maintenance");

    private final int value;
    private final String name;

    DevelopmentPhase(final int value, @NotNull final String name) {
        this.value = value;
        this.name = name;
    }

And this did not work either.
@Getter
public enum DevelopmentPhase {

    UNKNOWN(0, "Unknown"),
    BETA(1, "Beta"),
    GAMMA(2, "Gamma"),
    PRODUCTION(3, "Production"),
    MAINTENANCE(4, "Maintenance");

    @JsonValue private final int value;
    @JsonValue private final String name;

    DevelopmentPhase(final int value, @NotNull final String name) {
        this.value = value;
        this.name = name;
    }

Yes, it is possible; you just need to tell Lombok to add the annotation to the getter method, using @Getter(onMethod_ = @JsonValue) on the field:
@Getter
public enum DevelopmentPhase {

    UNKNOWN(0, "Unknown"),
    BETA(1, "Beta"),
    GAMMA(2, "Gamma"),
    PRODUCTION(3, "Production"),
    MAINTENANCE(4, "Maintenance");

    @Getter(onMethod_ = @JsonValue)
    private final int value;

    @Getter(onMethod_ = @JsonValue)
    private final String name;

    DevelopmentPhase(final int value, @NotNull final String name) {
        this.value = value;
        this.name = name;
    }

Thank you very much for responding to my comment even though it was deleted.  I appreciate the help!

Glad to be of assistance. :-)


Introduces TestSlotComposer

The intention is:

use TestSlotComposer when you want something that works without asserting on what are the render calls.
use MockSlotComposer when you want to express assertions on render calls (more fine grained testing).

MockSlotComposer extends TestSlotComposer extends SlotComposer.
Over time both classes can grow with test utilities, but I would like to keep the invariant that TestSlotComposer just works without need to set the expectations.

Thanks. At the risk of being super annoying, I believe this guy is properly FakeSlotComposer. :)

Thanks. At the risk of being super annoying, I believe this guy (TestSlotComposer) is properly FakeSlotComposer. :)

I do agree!

Ok, Renamed to FakeSlotComposer.


Better NVM integration

TL;DR;
As a user, I want to set `$HOME/.nvm` as the NVM directory in my VS Code settings
And have VS Code do the necessary steps to load NVM
So that VS Code is aware of my NVM configuration even if it is started from a GUI shortcut

Long version
NVM is very useful when one has to work with different Node.js versions. It enables setting a specific Node.js version for a console session. In order for this to work, a few commands need to be run to load NVM. This is typically achieved by putting the needed commands into .bashrc/.zshrc/etc. which are then executed by the shell when a new console session is started.
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

Applications that are started from the resulting console session would then be aware of Node.js version configured via NVM.
There is a catch however: one must always run those said applications from a console session where NVM was loaded.
In VS Code's case, when the it is launched via a GUI shortcut, NVM is never loaded and VS Code stays ignorant about it.
This will cause issues like #131911 where the configured Node.js version is seemingly ignored. Another extension that is sensitive to the Node.js version is for Azure Functions.
There are at least two scenarios that I know of where VS Code is not launched from a console with NVM loaded:

user launches VS Code from a GUI shortcut
VS Code is launched from the browser (opening a Live Share session for example)

It would be nice if I could point VS Code to my NVM directory and have it load my configuration when it starts up.
There is already some support for specifying the Node.js version for node tasks but this would make it better.

In VS Code's case, when the it is launched via a GUI shortcut, NVM is never loaded and VS Code stays ignorant about it.

VS Code does source a login shell when you launch it from a shortcut, you could try add the nvm config to your profile script instead and/or source your .bashrc file from the profile script.

My system is configured to use ZSH. I have the lines that load NVM in my .zshrc file, and if start a terminal application then NVM is loaded.
VS Code is also configured to use ZSH.
If I start VS Code from that terminal then I don't have issues with VS Code using a different Node.js version then what is set to default by NVM.
Would VS Code know that it has to source my .zshrc file and not something else?

@szszoke vscode sources a login shell, adding . ~/.zshrc to your ~/.zprofile (or ~/.profile?) should get it to show up.

I have the same issue!
I use zsh and I have everything configured, including automatically setting up the correct Node version if .nvmrc.
If I open a new terminal, the profile loads correctly, but if I try to run a NPM script as a task (clicking in the Run button in the NPM Scripts panel), the script will run right away without setting up the profile first, thus breaking the script that depends on the Node version defined in .nvmrc.
Funny thing is that if I instead Debug the same task (clicking in the button next to Run), the profile will now run before running the actual task...

@szszoke vscode sources a login shell, adding . ~/.zshrc to your ~/.zprofile (or ~/.profile?) should get it to show up.

Indeed you were right.
I first tried to put the NVM loader into ~/.profile and then reboot. That didn't work.
I then symlinked ~/.profile to ~/.zprofile and now VS Code uses the expected Node.js version when starting tasks.
Thank you!


Add: API logotype

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[x] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[x] Content (and my changes are in index.md)

Added a logo for the API.

Thanks for this contribution! 💖
Per our API docs:

logo
(if applicable) The official logo associated with that topic. You must have permission to use this logo. If no official logo exists, do not include an image.

APIs are a concept not owned by any particular entity. APIs do not have an official logo, so I'm going to close this PR.

Okay, sure.


rename open_text to open, and open to _open

Restore synch with the VisiData v3.1.1 parallel version of unzip_http.py.

The renaming of these files was necessary for archive.py:        zip_open = fp._open


Code coverage

Codecov Report

Merging #23 (cbc55f4) into master (a067bde) will increase coverage by 1.73%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   93.17%   94.91%   +1.73%
==========================================
  Files           7        7
  Lines         337      334       -3
  Branches      108      107       -1
==========================================
+ Hits          314      317       +3
+ Misses         23       17       -6

Impacted Files
Coverage Δ

src/index.ts
92.15% <0.00%> (+1.59%)
:arrow_up:

src/parse.ts
94.15% <0.00%> (+0.60%)
:arrow_up:

src/convertFilesInDirectory.ts
97.56% <50.00%> (+2.43%)
:arrow_up:

src/generateTypeFiles.ts
94.11% <0.00%> (+8.82%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a067bde...cbc55f4. Read the comment docs.


read_verilog is very slow when module has many for iterations in an always block

read_verilog seems to take exponentially longer reading the following module depending on the number of iterations in the for loop:
module TestCase(
  input wire clock,

);

localparam COUNT = 1600;

reg buffer[0:COUNT-1];

always @(posedge clock) begin : GENERATE
  integer ii;

  for(ii = 0; ii < COUNT; ii = ii + 1) begin
    buffer[ii] <= 1'b0;
  end
end

endmodule

Time spent by 'yosys -p read_verilog test.v':

100 iterations -> 0s
200 iterations -> 2s
400 iterations -> 8s
800 iterations -> 36s
1600 iterations -> 160s

The OS X performance tools (Sample of yosys) seem to implicate Yosys::AST_INTERNAL::ProcessGenerator::removeSignalFromCaseTree(const std::setRTLIL::SigBit &pattern, RTLIL::CaseRule *cs) which is calling Yosys::RTLIL::SigSpec::remove2(const RTLIL::SigSpec &pattern, RTLIL::SigSpec *other).  This form of remove2() calls to_sigbit_pool() to get a poolRTLIL::SigBit.  Inside to_sigbit_pool(), it creates a poolRTLIL::SigBit and then inserts each each bit of each chunk.  This insert seems to trigger a memory allocation via pool<>::insert calling pool<>::do_insert which does a push_back() on a new vector.  It seems that creating a pool on each call to remove2() is excessive in this case.

For the record: Fixed by PR #115.


Improve Content-Type Rating

Improve the Content-Type Rating by validating the used charset if it's valid.

Get a list of all possible and valid browser supported charset. Check against them.

Not needed for this scanner any more.
Best practice UTF-8.


[Android] Pixel rounding error in rendering contingent views

🐛 Bug Report
Some layouts involving elements that are next to one another have thin empty lines appearing only on Android, iOS is fine. This bug appears in some conditions but not always.
To Reproduce
Init a new project and replace App.js by the following code:
import React, { Component } from 'react';
import { StyleSheet, Text, View } from 'react-native';

export default class App extends Component<Props> {
  render() {
    return (
      <View style={{ justifyContent: 'space-between', marginTop: 100 }}>
        <View style={{ flexDirection: 'row', justifyContent: 'space-around' }}>
          {[...Array(3)].map((_, index) => (
            <View key={index} style={styles.container}>
              <View style={styles.content} />
              <View style={styles.content} />
            </View>
          ))}
        </View>
      </View>
    );
  }
}

const styles = {
  container: {
    flexDirection: 'row',
    marginHorizontal: 16,
  },
  content: {
    backgroundColor: 'blue',
    height: 20,
    width: 20,
  },
};

Here is an example on a Nexus emulator running Android API 26, with its PixelRatio being 2.625, but the issue is also visible on other Android API versions and screen densities. No problem on iOS

Android
iOS

Expected Behavior
Elements that are positioned next to one another are painted without any separation on Android like on iOS
Code Example
https://github.com/yassinecc/android1pxBug
Environment
React Native Environment Info:
    System:
      OS: macOS 10.14.4
      CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
      Memory: 25.63 MB / 16.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 10.14.2 - ~/.nvm/versions/node/v10.14.2/bin/node
      Yarn: 1.12.3 - /usr/local/bin/yarn
      npm: 6.9.0 - ~/.nvm/versions/node/v10.14.2/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
      Android SDK:
        API Levels: 23, 25, 26, 27, 28
        Build Tools: 23.0.1, 25.0.0, 25.0.2, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.3
        System Images: android-22 | Google APIs Intel x86 Atom, android-26 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom
    IDEs:
      Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
      Xcode: 10.2/10E125 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: 0.59.4 => 0.59.4

@hramos @kelset could we keep this issue open and move it to the backlog?


Make legion sent EntityChanged event when an component is changed.

I work on an entity synchronization library (for amethyst) and look into ways to detect changes here I need to track each change that happens to a component. As we spoke about this in discord when we query we only get to know that something is changed and what the newest version of that component is. I need all the changes because this is needed for the simulation of the game world on other clients. And for server stuff.
Would it be possible to drag along the event channel to the DerefMut for RefMapMut? Then when dereferenced and a mutate is going to be made, the current T will be pushed onto the channel with the event Event::EntityChanged(T).
There are already Remove and Add events, however, change events need to be requested via the query API. I understand the motivation behind this, though it would be awesome if I can directly see the exact changes that were made.
I am not entirely sure if this scenario can be achieved other than by capturing a mutable call to a component. For this, you need to own the component. Since the legion owns the component and knows exactly when a component is changed, it can note the changes and tell the user what and when something has changed. Therefore legion is only able to do this in the most optimal way without hacky workaround.
Any ideas, suggestions, proposals, insights?

Never mind, this will be too much overhead.


Use here documents to declare manifests in the documention

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
Documentation is hard to follow when reader needs to constantly switch between documentation and analysing the manifests in his IDE/git repository/wherever else the example links.
Proposed Solution:
Use here documents to inline the manifests.
Take Persistent Volume Walkthrough as an example.

Using your claim as a volume
Claims are used as volumes in pods. Kubernetes uses the claim to look up its bound PV. The PV is then exposed to the pod.
$ kubectl create -f docs/user-guide/persistent-volumes/simpletest/pod.yaml

$ kubectl get pods
NAME      READY     STATUS    RESTARTS   AGE
mypod     1/1       Running   0          1h

$ kubectl create -f docs/user-guide/persistent-volumes/simpletest/service.json
$ kubectl get services
NAME              CLUSTER_IP       EXTERNAL_IP       PORT(S)       SELECTOR           AGE
frontendservice   <IP_ADDRESS>       <none>            3000/TCP      name=frontendhttp  1d
kubernetes        <IP_ADDRESS>         <none>            443/TCP       <none>             2d

To understand what you are actually doing I will need to pull the repository and read docs/user-guide/persistent-volumes/simpletest/pod.yaml and docs/user-guide/persistent-volumes/simpletest/service.json separately as I go through the examples.
It would be so much easier if this example read:

Using your claim as a volume
Claims are used as volumes in pods. Kubernetes uses the claim to look up its bound PV. The PV is then exposed to the pod.
$ cat <<'EOF' | kubectl create -f -
kind: Pod
apiVersion: v1
metadata:
  name: mypod
  labels:
    name: frontendhttp
spec:
  containers:
    - name: myfrontend
      image: nginx
      ports:
        - containerPort: 80
          name: "http-server"
      volumeMounts:
      - mountPath: "/usr/share/nginx/html"
        name: mypd
  volumes:
    - name: mypd
      persistentVolumeClaim:
       claimName: myclaim-1
EOF

$ kubectl get pods
NAME      READY     STATUS    RESTARTS   AGE
mypod     1/1       Running   0          1h

$ cat <<'EOF' | kubectl create -f -
{
  "kind": "Service",
  "apiVersion": "v1",
  "metadata": {
    "name": "frontendservice"
  },
  "spec": {
    "ports": [
      {
        "protocol": "TCP",
        "port": 3000,
        "targetPort": "http-server"
      }
    ],
    "selector": {
      "name": "frontendhttp"
    }
  }
}
EOF
$ kubectl get services
NAME              CLUSTER_IP       EXTERNAL_IP       PORT(S)       SELECTOR           AGE
frontendservice   <IP_ADDRESS>       <none>            3000/TCP      name=frontendhttp  1d
kubernetes        <IP_ADDRESS>         <none>            443/TCP       <none>             2d

Page to Update:
http://kubernetes.io/docs/user-guide/
Considerations:

Inline manifest length
There should be a sane limit that restricts inline manifest length, e.g. 100 lines. In cases where manifest is longer than this limit, use URL to the resource (instead of a relative file path) to refer to the manifest.
The benefit of using a URL is that:

It enables to quickly open the resource in the browser. This reduces switching between different applications, assuming user is reading the documentation in a browser.
It enables to copy-paste the examples without needing to pull the repository containing the referred resources.

Keeping the examples up-to-date
Having the example manifests in the version control enables easy revision/ tracking of/ making changes.
Therefore, documentation source pages should not inline manifests (also, respecting the length limit by hand is error-prone).
Instead, documentation should always refer to the manifest by URL and there needs to be a build step that pulls the manifest,
validates that the resource URL returns response 200, and depending on the length of the response, keeps the URL as it is
or inlines the manifest in the output document.

cc @chrislovecnm

Another option is hosting them on http, which may be slmpler
kubectl create -f https://git.io/my-example.yaml
Woul that help or is embedded the yaml better?

Our have both?? You can see the doc and then use the url?

Our have both?? You can see the doc and then use the url?

I have added "Considerations" section to the end of the original issue.

This makes a lot of sense to me @kubernetes/docs any feedback?

wanted to open an issue about this, but i'm glad there's one that addresses it currently. the docs are confusing, they assume i want to clone the docs repo locally to be able to use an example.
bump for interest!

/remove-lifecycle stale

There is currently syntax for embedding yaml manifests in the markdown documents, for example:
{% include code.html language="yaml" file="podpreset-preset.yaml" ghlink="/docs/tasks/inject-data-application/podpreset-preset.yaml" %}

This syntax will have the yaml file embedded in the webpage while at the same time provide a link for readers to download and try the example.
With https://github.com/kubernetes/website/pull/6546 merged, we can enforce syntax checking when new manifests are added.
Please feel free to reopen this if it is not solving the issue.


zkEVM: skeleton menu plus Overview section

CURRENT:
This PR contains the overview section of the architectural material using @omnifient 's diagram as a starting point.
The template menu remains, and is commented out for now with warnings on the empty pages if anyone manages to see one.
OLD:
This PR is a draft template for the High Level Architectural documentation we are going to add to the zkEVM docs section, with a view to moving to CDK in the future, and maintaining placeholder items for content not yet ready for publishing.
Use this to build your doc menu items that relate to this epic: https://polygon.atlassian.net/jira/software/projects/DOCS/boards/79/backlog?selectedIssue=DOCS-222

I'm gonna put this in dev for you to have a look at @EmpieichO

Should we change the directory name? It still says "hermez-node"
Might cause links to break though.

Should we change the directory name? It still says "hermez-node" Might cause links to break though.

this is in reference to the pic naming ... i can change it now and not break any links as nothing is published yet ... what do you suggest? zkevm-node maybe


How create site settings page

I have model Option.
Option.first -> [:site_title,:site_enabled, and more ... ]
I want create page in ActiveAdmin to edit this attributes.
Like this:
index -> show first record
update -> update first record

Hello, please ask the mailing list for support questions.
http://groups.google.com/group/activeadmin?pli=1
φ http://pcreux.com
On Sun, Nov 27, 2011 at 13:52, Evgeniy Shurmin <
<EMAIL_ADDRESS>
wrote:

I have model Option.
Option.first -> [:site_title,:site_enabled, and more ... ]
I want create page in ActiveAdmin to edit this attributes.
Like this:
index -> show first record
update -> update first record

Reply to this email directly or view it on GitHub:
https://github.com/gregbell/active_admin/issues/790


Respect plugin settings in buy-widget-form

After the update from 7.2.4 to 7.3.0 on the product detail pages an text apperead "PayPal Bezahlen Sie in 3-24 monatlichen Raten. Mehr erfahren"
This changes makes sure the plugin setting "'Direkt zu PayPal' auf Detailseite" is respected.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PPI-844
Please use this issue to track the state of your pull request.

Thank you for your contribution, your PR has been merged. We will release a patch release with this fix in the next 24h 😉


Conflicts between reactive and non-reactive libraries

Disabled DevServices for all extensions module
Comment Quarkus-SpringWeb extension due to some reactive library conflicts
patch some other modules in order to fix dependency conflicts

The native error is because 002-quarkus-all-extensions module is not included in the native profile.


Update resource-links.html with EthPillar

Is this the wei?

it is indeed the wei, thanks @coincashew !


how to enable full game rendering

question : I successfully installed pysc2 on linux ubuntu and I can render the gameplay with its 2d basic shapes and texts using pysc2.bin.agent. But I see many sample videos that have the full game rendering. can I do the same for ubuntu linux pysc2?

I believe the full game UI is not available on Linux (yet?). The videos you are seeing are probably using Windows.

@islamelnabarawy Are there even plans to make it available on Linux?

I'm not affiliated with Deepmind or Blizzard, so I'm afraid I don't know the answer to that question.

I think it's unlikely considering amount of work it requires.

Full game rendering works on Windows like a charm
On Oct 27, 2017 3:02 PM, "ShadowDancer"<EMAIL_ADDRESS>wrote:

I think it's unlikely considering amount of work it requires.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/deepmind/pysc2/issues/106#issuecomment-339890163, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQ-ORuyEw5cJPqGD33_-fSN_F-CMWvYqks5swX_pgaJpZM4QFam5
.

@alfonsolink
And so does on mac :) That's because they're selling this game for quite a while. However game is not available on linux, and I doubt that it even has render that works or linux.

In the underlying protocol, we've stated we plan to add this but haven't given a timeline: https://github.com/Blizzard/s2client-proto/blob/master/docs/protocol.md#rendered
It will work on Windows/Mac/Linux.

@KevinCalderone so, there's no way of even having basic 2D rendering using the C++ API right now?

No, there isn't yet, but it's one of the top priorities to get working and released. Note that this means there will be rgb observations similar to the feature layers. It doesn't mean having a full UI for playing the game the same as on Windows/Mac.
All the current videos have been rendered from Windows/Mac.


Update the documentation for issue-31

Set the default nodejs version to 12 as per https://github.com/perara/wg-manager/issues/31
Also set the pip install to pip3 as we are using python3.
This was causing some issues with the wheel setup
error: invalid command 'bdist_wheel'
 ----------------------------------------
 ERROR: Failed building wheel for python-multipart
 ERROR: Failed building wheel for sqlalchemy-utils
 ERROR: Failed building wheel for Tempita

Also set these as being used by sudo otherwise the venv has an issue with the permissions
ERROR: Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/opt/wg-manager/wg_dashboard_backend/venv/lib/python3.8/site-packages/typing_extensions.py'
Consider using the `--user` option or check the permissions.

Attempting to use the --user flag does not work
This works (once the requirements.txt file has been edited to set the sqlalchemy version to < 1.4.0 due to a versioning issues with API calls)
ImportError: cannot import name '_ColumnEntity' from 'sqlalchemy.orm.query' (/opt/wg-manager/wg_dashboard_backend/venv/lib/python3.8/site-packages/sqlalchemy/orm/query.py)
https://stackoverflow.com/questions/66644975/importerror-cannot-import-name-columnentity-from-sqlalchemy-orm-query
Working as below
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)

See https://github.com/perara/wg-manager/pull/92 for fix of requirements.txt


Generate reference documentation using Puppet Strings

Puppet strings can be used to automatically generic REFERENCE.md documentation based on specially formatted comments of Puppet classes, types, and resources.
In this card, we'll migrate the existing REFERENCE content to comments so that it can be generated using Puppet strings, and going forward the code comments can be maintained and used to auto update the REFERENCE file.
AC:

[ ] REFERENCE.md is generated by code comments using puppet strings

@sgnn7 I think this issue is done already, right? I see gen_docs.sh is using puppet strings

Not quite - I was having some issues running this command with the bleeding-edge PDK and I want to ensure this still works. There's also a question if we want this documentation to be generated on-the-fly during releases and be excluded from the repo by default.

Closed via https://github.com/cyberark/conjur-puppet/pull/225.


Read keyword arguments in the function body of connect/2

Reading them in the function head forces the keys to be passed in in-order,
which is difficult to see when using application config to set the values.
Originally by my colleague @waisbrot, with minor fixes and testing from me.

This looks good, thanks!


This resolver is trying to find the wrong plugin

This resolver currently does not work. This is because the naming convention has changed.
From line 36:
p[0] === 'babel-root-import'

It's trying to find the plugin settings from the .babelrc file, but the plugin name is no longer babel-root-import. It's now babel-plugin-root-import. So if you simply make that change in the string:
p[0] === 'babel-plugin-root-import'

This package suddenly works again!

@olalonde I have made a PR for this: #6
Please merge and release if it looks good! I am eager to get this working!!!

any news on sorting this?
cheers

I'm no longer maintaining this but both @cle1994 @GollyJer have commit access


remove content deleted audios from !wat

I think this would be a good time to suggest new !wat sounds. Let me begin....


Add republish_drafts_by_format rake task

Adds a rake task to republish draft editions by format
In conjunction with : https://trello.com/c/LTxUDSbU/661-enable-preview-links-for-external-users-for-draft-content

👍


How can I store the result of galtab.CICTabulator() and the meaning of Warning 'placeholders with weight>1'?

Given that Galtab employs the tabulation technique similar to Tabcorr, how can I store the output of galtab.CICTabulator() like in Tabcorr?

halocat = CachedHaloCatalog(simname='bolplanck')
halotab = TabCorr.tabulate(halocat, wp, rp_bins, pi_max=40, verbose=True, num_threads=4)
halotab.write('bolplanck_wp.hdf5')
halotab = TabCorr.read('bolplanck_wp.hdf5')
Because after I tabulate and try to save the results, it fails:
gtab = galtab.GalaxyTabulator(halocat, hod)
cictab = galtab.CICTabulator(gtab, proj_search_radius, cylinder_half_length, bin_edges=cic_edges)
cictab.save('smdpl_cictab_2_10.hdf5')
where the file 'smdpl_cictab_2_10.hdf5' is unreadable (Unable to open file (file signature not found)).

Also, when I try to pass cictab into emcee, I found it runs very slow, and keeps on telling me that:
WARNING: There are 80341 placeholders with weight>1, averaging: 1.2103241682052612

Hi @Sherlockids, thanks for getting in touch!

The CICTabulator class has methods for both saving and reloading the instance. This uses pickling since I never got around to implementing an hdf5 saving mechanism, and pickling was the quick and dirty way to do this. For example, if you save your cictab using cictab.save('smdpl_cictab_2_10.pickle'), you can reload it using cictab = CICTabulator.load('smdpl_cictab_2_10.pickle')
This warning could be easily suppressed by passing warn_p_over_1=False to the predict() method. However, it is good to understand why this is happening: essentially, you are passing in an AssemBias model in which  is greater than N_placeholder for certain halos, which invalidates assumptions going into our tabulated CiC algorithm (around the fiducial HOD, we have  ~ 0.05 * N_placeholder). The best fix is either (a) using a fiducial HOD with more satellites per halo (fiducial hod is set in this line: gtab = galtab.GalaxyTabulator(halocat, hod)) or (b) setting a tighter parameter bound on your prior so that you don't feed in hod models with unphysically large numbers of satellites.
The expected time we expect certainly will depend strongly on simulation size and  values of the fiducial HOD, but 20 minutes seems very off in comparison to what I was seeing (closer to 1-5 seconds). My guess is that there is disk swapping going on, which means the memory taken up by the gtab tables are combined larger than your RAM. This is especially likely given that your code snippet shows you are using multiprocessing, and so you have N processes each loading separate instances of the same gtab object, and they are competing for RAM space. I would start with just loading a single gtab table, since they occupy a lot of memory (and it scales with N_halo * N_placeholder). If you need parallelization, the solution might be distributing over computing nodes with MPI.

Thanks a lot，I will try your suggestions！

Thanks again for your assistance. I have come to realize that I had set the nwalkers parameter too high. Perhaps the communications between the walkers were slowing down the computation time per step. By reducing the number of nwalkers to 100, the time per step amounted to approximately ~70s/step. However, with a more conservative setting of nwalkers = 20, the time per step decreased significantly to around ~20s/step.


Add user uploaded client images

Closes https://github.com/AY2223S1-CS2103-W14-1/tp/issues/98
This PR introduces user-uploaded client images.
Make sure you specify the image directory in your preferences.json
issues: to delete images when client/property is deleted.

Codecov Report

Merging #92 (32b6c9e) into master (4b74a97) will increase coverage by 0.66%.
The diff coverage is 45.45%.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Provide scheduling hints?

When more crates are ready to start compiling than there is available parallelism, how does Cargo pick which ones to start first? Are there ways to influence this scheduling? (For example, does the order of declarations of dependencies in a given Cargo.toml file matter? Or, what effect would it have to add an otherwise unnecessary edge to the dependency graph?) Should we add a new mechanism to influence it?
Here is the output of cargo build -Z timings for Servo: (with "Min unit time" set to 10 seconds)

If we start from the end of the graph, (part of) a critical path is very apparent: the final executable only starts to build after the script crate has finished. The script crate in turns only starts after the build script for the mozjs_sys has finished.
Additionally, CPU utilization drops while script is compiling because Cargo runs out of other tasks to do and rustc only has limited intra-crate parallelism. (Though I expected codegen-units to provide some more parallelism during codegen, but that’s a separate issue.)
It seems that if we could start mozjs_sys and script and earlier, the total time could be significantly reduced. Specifically: cargo build -p mozjs_sys && cargo build -p script && cargo build might lead to better scheduling. A way to achieve that scheduling with more parallelism could be to assign priorities. mozjs_sys and its recursive dependencies have priority 2 (more urgent), script and its dependencies that don’t already have a priority have priority 1, and everything else has priority 1.
Literally this mechanism with numeric priority levels is probably not the UX we want for Cargo. But how does it sound to add some way to influence the scheduling? Maybe call it “hints” to avoid setting in stone the current algorithm.
CC https://github.com/rust-lang/cargo/issues/5125 which is on the more general topic of scheduling

I expected codegen-units to provide some more parallelism during codegen, but that’s a separate issue

(Looks like codegen-units defaults to 2, not ncpu.)

Scheduling has come up from time to time, but generally hasn't received a ton of love unfortunately! Some history is:

Initial issue - https://github.com/rust-lang/cargo/issues/5014
First fix - https://github.com/rust-lang/cargo/pull/5100
Recent fix - https://github.com/rust-lang/cargo/pull/7390

The tl;dr is that Cargo only has limited judgement when scheduling things. This only comes up when Cargo has multiple candidates to schedule for an available jobserver token. The "waiting" red line in the graph you have, when it's nonzero, is the only chance where Cargo actually has a scheduling decision to make.
When Cargo has a scheduling decision, it currently sorts the list of candidates to scheduled based on the number of transitive crates which depend on the crate. The thinking is that this schedules things that will hopefully unlock the most parallelism later in the graph. The previous behavior after the "first fix" was sorting based on depth in the graph.
That being said I definitely agree that we should have some way of providing hints to scheduling. For example Servo should be able to codify "when you compile the script crate, it's like you compile 15 crates serially" or something like that, and Cargo could use that to prioritize scheduling of script's transitive dependencies.
If you zoom out though on your graph, do you know if Cargo could have actually scheduled better here? Did dependencies of script get held back by accident?

(Looks like codegen-units defaults to 2, not ncpu.)

I'm pretty sure it is 16?

If you zoom out though on your graph, do you know if Cargo could have actually scheduled better here? Did dependencies of script get held back by accident?

At a meetup last night we realized that that can be answered with a small addition to the data stored in the -Ztimings (cc https://github.com/rust-lang/cargo/issues/7396#issuecomment-533932835). I think it will be very motivating to "know" the performance we are leaving on the table.

(Looks like codegen-units defaults to 2, not ncpu.)

I'm pretty sure it is 16?

Oh, interesting. Any guess why this machine’s 4 cores / 8 threads are not saturated during codegen for the script crate in the timings above, then?

If you zoom out though on your graph, do you know if Cargo could have actually scheduled better here? Did dependencies of script get held back by accident?

If I run cargo clean then cargo build -p script, the total time is 319 seconds whereas in the full build graph the script crate finishes after second 560. So as far as I can tell that’s ~240 seconds worth of work that is not a dependency of script, and that could (with different scheduling) be done in parallel with it.

Is it practical to use the json output from cargo build -Ztimings=json (or something similar) as a kind of profile guided optimization to determine the optimal build order automatically?
In any case, I've submitted #8908 which attempts to take a small step toward allowing some weighting to be considered when determining build order. I think this should be useful for either allowing a user to provide scheduling hints as requested in this issue, or in implementing a system which uses actual timing data from a previous build.

Is it practical to use the json output from cargo build -Ztimings=json (or something similar) as a kind of profile guided optimization to determine the optimal build order automatically?

That's #7396.

#11032 looked at adding more heuristics to improve build order but they were a mixed bag.  Something that came up in that discussion was a (presumed) perma-unstable way of configuring the priority of every package to explore what heuristics could be used.  #7396 could then build on this to create a feedback loop for your own system to improve.

Now that nightly supports parallel front-end compilation, I propose we develop an algorithm $A = A_\alpha$ with an adjustable configuration $\alpha$ and follow a data-driven approach to optimize $\alpha$ for different build environments. Guessing an optimal schedule should run $o(\text{compilation time})$, but may be used to reduce overall compilation time.
Notes:

Job-shop scheduling is famously NP-hard.

Despite this, a great deal of effort has gone towards the development of operations research techniques to develop solvers and heuristics to efficiently find $\varepsilon$-good-enough solutions that perform well in problem contexts
We can improve overall compilation time by leveraging decades of existing research methodologies.

Job scheduling is harder when processing time is unmeasured or stochastic

To optimize compile times for all users, we need to account for the diversity of hardware specifications and other factors, controlling for bias.

Heuristics will work on my machine but not your's

Hard-coding bias terms for famous crates in the short-term may work for a large number of users, but create unmeasured friction for others.
Hard-coded coded values need to be benchmarked periodically and updated via a reproducible set of techniques that may be adjusted empirically over time.

FWIW, not exactly the same issue but could share some ideas in between regarding parallelism — https://github.com/rust-lang/cargo/issues/12912.

Similarly, protobuf generation (via prost) is usually assigned to a lower priority but takes relatively longer time to build. Here is a case in risingwave:

Since we have integrated SQLite into Cargo, it is a good time to evaluate how to persist timings data as a first step.


Add politecnico internacional

URL of the institution which is different from the email domain name: https://politecnicointernacional.edu.co/
URL of a program lasting for more than one year (2.5 years):
politecnico internacional

@Kathebyte First stage of verification passed, official domain is politecnicointernacional.edu.co as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://sppi.politecnicointernacional.edu.co:8443/PasantiasEstudiantes/

@Kathebyte Pull request merged. Thank you.


Mpi parallel dmrg plus hc

@jhauschild you wanted to just delete the branch, right?

This is included in the excitation_science branch


transpose channel for prelu replacement when prelu channel number is 3

PReLU with 3 channels has weights (c, 1, 1), need to be transposed before adding/multiplication

LGTM.


global table only if joinable

Description
This PR extends #10020 to more correctly only convert a TableDataSource to a GlobalTableDataSource if it is also joinable. In service to this, the JoinableFactory interface has been modified to add a new method:
boolean isDirectlyJoinable(DataSource dataSource);

which should return true if for a JoinableFactory and a DataSource may possibly produce a Joinable for at least some JoinAnalysis, directly, that is without a subquery join. This is useful, because DataSource.isGlobal is used to determine whether or not a subquery is necessary to complete the join. I left some notes in javadocs and comments on how we should consider using this new method in query planning and processing so that we might decouple the idea that a datasource is globally distributed among the cluster and whether or not a joinable can be directly built for it.
Secondly, it adds automatic conversion of TableDataSource to GlobalTableDataSource for native druid queries whenever eligible, to make GlobalTableDataSource an internal construct.
To make these changes visible, the INFORMATION_SCHEMA.TABLES table now has two additional columns: IS_JOINABLE and IS_BROADCAST.

IS_JOINABLE means that a Joinable can possibly be built for that table during query execution, allowing the right hand side of a join to be performed without issuing a subquery.
IS_BROADCAST means that the table is distributed to all query processing servers (historicals, brokers, indexers/realtime tasks). Note that this value will be incorrect for broadcast datasources in clusters where the broker is not configured to serve broadcast segments, due to inferring if a datasource is broadcast by checking the brokers local segment cache. A future improvement might be to swap this out for something that examines the load rules instead of guessing.

This PR has:

[ ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Key changed/added classes in this PR

ClientQuerySegmentWalker
JoinableFactory and implementations
DruidSchema
InformationSchema

Thanks for review @jon-wei and @jihoonson :metal:


Injecting reinstalls back to CIBOX

We should inject our work to CIBOX
This issue will be used for collecting thoughts about current implementation
DIfferent solr reindexing commands
searchapi
sudo drush -y search-api-clear -l http://stage.steptoe-johnson.com || true
sudo drush -y search-api-index -l http://stage.steptoe-johnson.com || true

apachesolr
sudo drush -y solr-mark-all -l http://istage.steptoe-johnson.com || true
sudo drush -y solr-index -l http://istage.steptoe-johnson.com || true

Let's have an option var for selecting proper one. Or a tag, that sounds better, because we will have ability to run only selected tags

Features should be injected from:
https://github.com/propeoplemd/TFALL/blob/master/docroot/reinstall.yml
https://github.com/propeoplemd/NAS/blob/master/docroot/reinstall.yml
https://github.com/propeoplemd/asc/blob/master/docroot/reinstall.yml

PR: https://github.com/propeoplemd/cibox/pull/205

For review before processing:
https://github.com/propeoplemd/code/blob/master/docroot/reinstall.yml
https://github.com/propeoplemd/ANC/blob/master/drupal/reinstall.yml
https://github.com/propeoplemd/asc/blob/master/docroot/reinstall.yml
https://github.com/propeoplemd/NAS/blob/master/docroot/reinstall.yml
https://github.com/propeoplemd/TFALL/blob/master/docroot/reinstall.yml

Import D8 back from https://github.com/InternetDevels/d8drupalua

Roadmap for this task

rename pre && post . ymls
remove include from folder names
split environment configs to files
boolean TRUE FALSE for optional commands

---
- name: Loop with when conditionals
  hosts: localhost
  gather_facts: false
  connection: local
  vars:
    list:
      - name: peter
        state: true
      - name: silie
        state: false
  tasks:
    - name: Debug when state equals true
      with_items: list
      when: item.state
      debug:
        msg={{ item.name }}

add pre_settings and post_settings config loops for settings.php
Move registry rebuild to SQL profile


Enhance X509_REQ_get_extensions(), add its doc, and improve x509_att.c

X509_REQ_get_extensions(): add error queue entry on ill-formed extensions attribute
add missing doc of X509_REQ_get_extensions() and X509_REQ_add_extensions{,_nid}()

On this occasion, improve error checking and reporting and coding style in x509_att.c.
In particular, there should be only one attribute per OID/NID, which is now checked.

Also here, thanks @t8m for the OTC review,
and asking @openssl/committers for 2nd review.

Still OK with the typo fixed.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged - thanks @t8m and @mattcaswell


Dev

@rdaly525 anything blocking this? I believe we were holding off because of the magma hackathon. Now that its over, I think we can consider merging this in? We can run a flow build to make sure that isn't broken.


tikv_utils, *: merge after_start_wrapper and before_stop_wrapper.

What is changed and how it works?

Issue Number: Close #15014
What's Changed:
Merged after_start_wrapper and before_stop_wrapper.

Replace `after_start_wrapper` and `before_stop_wrapper` with `with_sys_and_custom_hooks`.
Replace no-op(how strange!) `after_start_wrapper` and `before_stop_wrapper` with `with_sys_hooks`.

Check List
Tests

No code

Release note
None

@tabokie PTAL

/merge


Stream exported csv file

@viktor-yakubiv Could you please help me with styling clicked export button. Now it gets red color and red underline. Should it stay white without underline?

It should but this is a problem of the design library. I would keep it as is and fix it in the design later, it's not a big problem.
Is there a way to preview disabled button without running project locally?

I am afraid you will need to run this project locally to see disabled button. Or you can try every repository and maybe you find empty one.

@Joozty I removed extra span, class and resolved the commit. Could you please confirm the business logic has not changed?


Ugly hack while Scryfall set data is buggy.

This is BS. I am struggling with the new rebase future. Killing this and will make a better PR.

Hey @bakert,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: 3df61780-0ebc-11ea-97d2-e7d533c125a8