link validator CI failing

https://github.com/apache/pekko-connectors/actions/workflows/link-validator.yml
for this repo, link validation CI is only done once a week on a schedule - not for every PR
the job has been failing for a while but #899 made it worse
this PR temporarily enables link validation for PRs but that is just to prove that this change helps

(in pekko-grpc I had to remove the ./ from root-dir: https://github.com/apache/pekko-grpc/pull/400/files#diff-2a4ceebcb5b6c8bab1e5727bc9d87843f8f5c73f41c024b37acea23edb532ce7R4)

thanks @raboof - that helps progress.
There are some issues not associated with license report and I'll look at those now.
## Non-https pages
http://reactivemongo.org/
 - docs/pekko-connectors/snapshot/mongodb.html

http://www.scala-lang.org/api/2.13.15/scala/concurrent/Future.html
 - docs/pekko-connectors/snapshot/ftp.html
 - docs/pekko-connectors/snapshot/mqtt.html

http://www.scala-lang.org/api/2.13.15/scala/util/Try.html
 - docs/pekko-connectors/snapshot/dynamodb.html

Still hitting issues with scaladoc links.
https://pekko.apache.org/api/pekko-grpc/1.1.1/org/apache/pekko/grpc/org/apache/pekko/grpc/GrpcChannel.html status 404 Not Found
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/PublisherClient$.html
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/SubscriberClient$.html
 - ... 7 more

https://pekko.apache.org/api/pekko-grpc/1.1.1/org/apache/pekko/grpc/org/apache/pekko/grpc/GrpcClientSettings.html status 404 Not Found
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/PublisherClient$.html
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/SubscriberClient$.html
 - ... 7 more

https://pekko.apache.org/api/pekko-grpc/1.1.1/org/apache/pekko/grpc/org/apache/pekko/grpc/ServiceDescription.html status 404 Not Found
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/Publisher$$MethodDescriptors$.html
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/Publisher$$Serializers$.html
 - ... 33 more

https://pekko.apache.org/api/pekko-grpc/1.1.1/org/apache/pekko/grpc/org/apache/pekko/grpc/javadsl/PekkoGrpcClient.html status 404 Not Found
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/PublisherClient.html
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/SchemaServiceClient.html
 - ... 14 more

https://pekko.apache.org/api/pekko-grpc/1.1.1/org/apache/pekko/grpc/org/apache/pekko/grpc/javadsl/SingleResponseRequestBuilder.html status 404 Not Found
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/PublisherClient.html
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/PublisherClientPowerApi.html
 - ... 8 more

https://pekko.apache.org/api/pekko-grpc/1.1.1/org/apache/pekko/grpc/org/apache/pekko/grpc/javadsl/StreamResponseRequestBuilder.html status 404 Not Found
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/SubscriberClient.html
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/SubscriberClientPowerApi.html
 - ... 10 more

https://pekko.apache.org/api/pekko-grpc/1.1.1/org/apache/pekko/grpc/org/apache/pekko/grpc/scaladsl/PekkoGrpcClient.html status 404 Not Found
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/PublisherClient.html
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/SubscriberClient.html
 - ... 15 more

https://pekko.apache.org/api/pekko-grpc/1.1.1/org/apache/pekko/grpc/org/apache/pekko/grpc/scaladsl/ScalapbProtobufSerializer.html status 404 Not Found
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/Publisher$$Serializers$.html
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/Subscriber$$Serializers$.html
 - ... 7 more

https://pekko.apache.org/api/pekko-grpc/1.1.1/org/apache/pekko/grpc/org/apache/pekko/grpc/scaladsl/SingleResponseRequestBuilder.html status 404 Not Found
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/PublisherClient.html
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/PublisherClientPowerApi.html
 - ... 8 more

https://pekko.apache.org/api/pekko-grpc/1.1.1/org/apache/pekko/grpc/org/apache/pekko/grpc/scaladsl/StreamResponseRequestBuilder.html status 404 Not Found
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/SubscriberClient.html
 - api/pekko-connectors/snapshot/com/google/pubsub/v1/pubsub/SubscriberClientPowerApi.html
 - ... 10 more

https://pekko.apache.org/api/pekko-http/1.1.0/org/apache/pekko/http/impl/util/Renderable.html status 404 Not Found
 - api/pekko-connectors/snapshot/org/apache/pekko/stream/connectors/google/scaladsl/X$minusUpload$minusContent$minusType.html

https://pekko.apache.org/api/pekko-http/1.1.0/org/apache/pekko/http/impl/util/Rendering.html status 404 Not Found
 - api/pekko-connectors/snapshot/org/apache/pekko/stream/connectors/google/scaladsl/X$minusUpload$minusContent$minusType.html

https://pekko.apache.org/api/pekko-http/1.1.0/org/apache/pekko/http/impl/util/ToStringRenderable.html status 404 Not Found
 - api/pekko-connectors/snapshot/org/apache/pekko/stream/connectors/google/scaladsl/X$minusUpload$minusContent$minusType.html

Still hitting issues with scaladoc links.

I suppose we can add them to ignore-prefixes and create an issue for the problem?


Pokemons should contain their different forms as a map

Feature Request
Is your feature request related to a problem? Please describe.
Pokemons contains different form (Alolan, Water, Fairy etc.). A root Pokemon (e.g. Arceus) should contain a map of its different forms (e.g. Arceus Water, Arceus Fairy).
Describe the solution you'd like

{
  "name": "Arceus",
  "forms": [
    { "id": "ARCEUS_WATER", "name": "Arceus Water" },
    { "id": "ARCEUS_STEEL", "name": "Arceus Steel" }
  ]
  ...
}

@BrunnerLivio https://github.com/Furtif/POGOProtos/blob/master/src/POGOProtos/Enums/Form.proto#L105

Thaks a lot @bytelabsco ! Great job


⚠ Cioos National CKAN has degraded performance

In e20c2b5, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 12051 ms

Resolved: Cioos National CKAN performance has improved in f4607ba after 14 minutes.


Authorisation of API user must distinguish between a Translator and a Data Exporter

Data Exporter right to be granted only to people downloading bulk data.

Additional role: Data Importer
For users who are permitted to submit data to the API


evaluation framework for integrator chains domain

Create a script that parses an LTL formula into a Buchi or Rabin automaton and checks that an input string satisfies the specification. Should interface with the trial data from tdstat.py. The script should take as input a time duration for the trial and output success or failure based on appropriately defined acceptance criterion where not obvious (e.g. for liveness properties).

Note that the integrator_chains domain uses only LTL formulae that can be expressed through two basic reach-avoid templates. As such, we could use a task specification syntax that is accordingly restricted and thus avoid the need for Rabin automaton construction.

@vraman What do you think about my recommendation of using a restricted syntax? It could be used for an initial implementation and be supplemented or replaced by a design involving Büchi or Rabin automata later.

I agree with the suggestion of using a restricted syntax for an initial implementation.


[SEO] Add 'rel=nofollow' for any external links a tag

For all the external links a tag, it should add rel="Nofollow" in the tag attribute, in case there is someone using our website for spam
Like the one in job post header, it should look like <a target="_blank" rel="nofollow" title="XXX" href="YYY">
Might need to check all the links in our website about this, not sure is there any handling about this in nextjs
https://en.wikipedia.org/wiki/Nofollow

can also refer to this
https://pointjupiter.com/what-noopener-noreferrer-nofollow-explained/
we should also add rel= "noopener" for those  with target="_blank"

For those  component which containing user defined url, we can use router.push to fix this problem which will not create a  tag
reference:
https://stackoverflow.com/questions/65086108/next-js-link-vs-router-push-vs-a-tag

Done


⚠ GitLab Server has degraded performance

In ee2fdfa, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6894 ms

Resolved: GitLab Server performance has improved in 4997b06.


Palo Alto data connector fixes

Changes

added PAN connector JSON (exported from portal)
replaces DeviceProduct string operator from == to contains for both workbooks and connector

@erant10 did you also updated the version of the workbook in the workbook metadata?


Merging ROI Pooling into master

Can one of the admins verify this patch?

Sorry, this was a mistake!


[Model][Misc] Add e5-mistral-7b-instruct and Embedding API

Key Features of This Pull Request
This PR adds the e5-mistral-7b-instruct model and enables an E2E embedding vector generation.
There are a few open PRs that add support for embedding models. Our PR uniquely addresses the following key issues:
Integration of the OpenAI Server Front End
This PR includes comprehensive end-to-end (E2E) embedding functionality, spanning from the OpenAI Front End to the Back End.
Turn off KV cache with embedding models
This PR introduces the capability to turn off KV cache when operating in embedding mode, which includes the block_tables and cache_engine.
High Level Design
The embedding model can essentially be considered a special type of generative model with max_token=1 from an inference perspective. Both embedding and generative models (with max_token=1) require a single feedforward calculation without the need for generating any subsequent new tokens. The primary differences are:
The embedding model returns the hidden state, while the generative model takes an extra step to sample and return the first output token. In this sense, the embedding model is a subset of the generative model in terms of the calculations performed during the single feedforward operation on GPUs. They differ in their API specifications concerning request and output formats.
As a consequence, the serving of embedding models is:

Independent of any technologies implemented for subsequent token-by-token generations; and
They share the same technologies as generative models for prompt processing.

Therefore, in this PR, our current implementation focuses on bypassing vLLM’s components for subsequent token generations, such as KV cache and CUDA Graph to avoid unnecessary GPU memory, which in turn is useful to optimize the performance for embedding serving. If these technologies (e.g., CUDA Graph) are enhanced to improve prompt processing, they can be directly applied to embedding models. At a high level, our PR is independent of such crucial feature tensor parallelism, quantization, etc., which are addressed in Milestone 1 below. We have tested it with tensor parallelism > 1 and it functions effectively. We are willing to work together to test/improve these crucial features where needed.
Benchmarking Results
On 1 H100 GPU, vLLM’s serving of the E5 embedding model reaches a max throughput up to 36.6k tokens/s and remains consistent across sequence lengths from 128 to 32k (when gpu_memory_utilization is 0.8).
On 1 A100 GPU, it reaches up to 15.3k tokens/second and  also remains consistent across sequence lengths. As a comparison, in a test of the latest ONNX, the speed is up to 12.6k tokens/sec when sequence length is low (256 tokens), is reduced to 8k tokens/sec when sequence length is 2k, and shows a general trend of getting worse when the sequent length is longer.
See the figure for more details of our testing results on H100 and A100
Note: The throughput is measured as the "number of sequences in a batch" * "sequence length" / "end-to-end latency"

Design and Implementation Details
Add Embedding generation
Add Embedding API to entrypoints/openai

Add EmbeddingRequest and EmbeddingResponse to protocol.py
Add serving_embedding.py
Add OpenAIServingEmbedding to api_server
Make llm.py work with embedding

Add Embedding in outputs and sequence

Make an abstract base class of RequestOutput and SequenceGroupOutput.
Add separate Completion*Output and Embedding*Output.
Add EmbeddingOutput, EmbeddingRequestOutput, RequestOutputFactory and
EmbeddingSequenceGroupOutput to support processing the embedding output
sequence.
Update process output and sequence in *llm_engine to use embedding

Add MistralModel and embedding generation in llama.py

Add llama.embedding() and load_weights in LlamaModel to support forward
and embedding vector generation
Adapted from code examples in https://huggingface.co/intfloat/e5-mistral-7b-instruct
Mistral uses LlamaModel.
Use embedding when embedding_mode is True in model_runner
Add load_weights in llama.py to support embedding models

Disable KV Cache for Embedding serving
Skip slot_mapping with embedding mode

slot_mapping is only used in model_executor/layers/attention.py when
kv_cache is not None. In embedding mode, we pass None kv_cache. So no
need to process slot_mapping

Turn off KV cache for embedding mode
The goal is to disable the block_table and cache_engine completely, so
we don't consider allocating blocks for KV cache for embedding mode

Add embedding_mode to ModelConfig and SchedulerConfig
Add a BlockSpaceManagerProxy to control the block management behavior
for embedding mode

Update parameters for max batching

Add profile_max_batched_tokens_for_embedding to profile the
max_num_batched_tokens for embedding server mode
Return max_batch_size as each Ray worker runs the profiling once
Enable embedding profiling in ray_gpu_executor.py to support tensor parallelism > 1

Notes
Overlaps with other PRs
This PR overlaps with the following Milestones in Supporting embedding models #3187
Milestone 1: Basic functionality using Hugging Face models [Partially completed]
Note: Instead of using LLM.encode(), this PR currently adds embedding() to LlamaModel, and then keeps LLM.generate() for embedding.
G) Update parameters for max batching [Completed]
We introduced profile_max_batched_tokens_for_embedding in gpu_executor.py to support the maximum number of tokens the GPU can take in one batch.
Milestone 2: Implement the model properly [Completed]
This PR focuses on adding the e5-mistral-7b-instruct model, which can utilize llama.py. So it already uses the vLLM layer primitives.
Milestone 4: Add the OpenAI Server Front End [Completed]
This PR has implemented the Embedding API to entrypoints/openai.
Discrepancies with other discussions
This PR didn't implement the following in this discussion in Supporting embedding models #3187
Move finish sequence logic to check_stop
Currently, the logic is in llm_engine._process_model_output()
The logic should be in llm_engine._check_stop
Automatically detect that the model is an embedding model
The user should not have to specify that it is an embedding model
Somewhere in the vllm code, create a registry that selects which models are embedding and which models are decoders
F) Update Pass EmbeddingParams around instead of SamplingParams
note: this is going to require a lot of work
Note: This PR passes SamplingParams() to the LLMEngine and disabled the use of it in embedding mode. As separating EmbeddingParams and SamplingParams requires changes to the UX, it would be easier to discuss and review in a following PR.
Discussion Points and Considerations
Simplifying the Workflow

Evaluate the possibility of consolidating embedding-related workflows into existing structures with minimal branching logic. This could involve using if-else statements (specifically in model_runner.py) or integrating embedding as a subset of generation needs.

Soundness of Profiling

Evaluate if the current profile_max_batched_tokens_for_embedding is sufficient to support the maximum number of tokens in one batch without causing CUDA OOM.

An overview of tasks derived from the pull request discussions:
Immediate changes
core/

[x] Make a BlockSpaceManagerV3
[x] Remove self.prompt_limit if branch in scheduler.py

worker/ and executor/

[x] Remove profile_max_num_batched_tokens for embedding
[x] Evaluate to set a hardcoded batch_size or max_num_batched_tokens (32k as Woosuk and Zhuohan suggested) instead of profiling

models/

[x] Make a new embedding_models_dict
[x] Make a llama_embedding.py
[x] Check how HuggingFace(HF) generates embedding

Separate model_runner and embedding_model_runner

[x] Implement execute_model separately in model_runner and embedding_model_runner

Further evaluation

Evaluating the possibility of using config.json to distinguish whether a model is for embedding or generation, e.g. XForCausalLM as a generation model. Check edge cases for fine-tuning.
Separate LLM and LLMEmbedding
Separate SamplingParams and EmbeddingParams
Evaluate latency on individual request level

HF embeddings
HF's sentence_transformers provide sentences, texts, and image embeddings. They use an encode() for computing sentence embeddings. And Pooling class supports different types of pooling, including lasttoken, which e5-mistral-7b-instruct uses.
Adhering to the same design would require further discussion and evaluation of the points mentioned above.

@ywang96 thanks for the initial review!
I have applied the suggestions and resolved some comments.

The current implementation doesn't allow an engine to do generation and embedding at the same time (since the embedding_mode is passed to initialize the engine), so I wonder if it's actually worth the effort to create a separate EmbeddingEngine since a lot of logics in LLMEngine are completely not needed, and this separation could also make a lot of higher level APIs cleaner.

I agree that having a separate EmbeddingEngine has a lot of benefits. Besides making the design cleaner, adding more functionalities in embedding and supporting more embedding models would be easier. Happy to discuss detailed design. It might be good for a following PR as the current is big.

@ywang96 A question related to design:
intfloat/e5-mistral-7b-instruct requires an eos_token_id appended at the end each input. See:
# Tokenize the input texts
batch_dict = tokenizer(input_texts, max_length=max_length - 1, return_attention_mask=False, padding=False, truncation=True)
# append eos_token_id to every input_ids
batch_dict['input_ids'] = [input_ids + [tokenizer.eos_token_id] for input_ids in batch_dict['input_ids']]
batch_dict = tokenizer.pad(batch_dict, padding=True, return_attention_mask=True, return_tensors='pt')

I checked a few embedding models, it seems specific to this model. Since input_ids are processed in ModelRunner._prepare_prompt, is there a good place to inject eos_token_id to the end of each input?

cc @simon-mo
@CatherineSue
@ywang96 and I discussed.
There are a few things we want to do for the final implementation, but we want to take an approach of landing something close to the current version and then following up with incremental work.
Needed For Merge
Tests
This is a big feature that needs end-to-end testing. I would suggest that we focus in the following areas:

Model correctness: compare vs sentence-transformers or hugging face implementation of the model. Use L2 norm of the differences between the embeddings. This can use the LLM engine.

Server API correctness: show that querying the API gets what is expected from the client side. Check out the existing tests for the OpenAI API server for inspiration as to how to write these tests

Clean up llama_embedding.py
We currently re-implement all the llama layers.  I am okay with having a separate file for llama_embedding.py, but we should import LlamaModel and use that rather than re-writing all the layers of the model. For example:
from vllm.model_executor.models.llama import LlamaModel

class LlamaEmbeddingModel(nn.Module):
    def __init__():
         self.model = LlamaModel(**)

    def forward(inputs):
        return self.model(inputs)

    # currently called embedding
    def pool(hidden_states):
       # same as current embedding function

Update Terminology from embedding to pool
This is to be consistent with HF / sentence-transformers, which use this terminology for translating between the final hidden states and output embedding.
So specifically

LlamaEmbeddingModel should use pool instead of embedding
`EmbeddingModelRunner

Update LLM.generate API to log a warning if used with the embedding model

Make a note that this interface is experimental, and that LLM.encode will replace it soon

Add Incompatible Feature Guards
The following features are incompatible with embedding models:

Spec Decode
Chunked Prefill
Automatic Prefix Caching
Neuron / CPU
Fp8 KV cache

If these features are specified for an embedding model, we should either fail or log a warning. I would be okay with doing this in a follow up PR if it is not straightforward.
I will make a follow up note for

Follow Ups Post Merge
After we merge this initial implementation, we can refactor in the following way:
Replace SamplerXXX with PoolerXXX

Swap SamplingParameters for PoolerParameters, which only had the data needed for embedding models
Swap SamplerOutput for PoolerOutput, which only has the data needed for embedding models
Pipe all this info around the various layers of the engine

LLM.encode
Deprecate embedding models from LLM.generate().
Instead expose LLM.encode(), which accepts PoolerParams and returns EmbeddingRequestOutput
Create Generic Pooler
Create a generic Pooler() that corresponds to Sampler() (currently, we implement pooling logic in LlamaEmbeddingModel.embedding() rather than in a shared class for each . Pooler could be instantiated with sentence transformer config
This will allow us to support more complex methods like ColBERT, sparse, etc over time.
Refactor LLMEngine

Currently _process_sequence_group_outputs is very complicated and focused on CompletionRequests
Add abstract called SequenceGroupProcessor, with subclasses SequenceGroupProcessorEmbedding SequenceGroupProcessorCompletion. Each of these is responsible for implementing _process_sequence_group_outputs using PoolerOutput or SamplerOutput   ##respectively

@robertgshaw2-neuralmagic thanks for the feedback. Working on resolving the comments and getting the checklist. Will update it soon.

@robertgshaw2-neuralmagic thanks for the feedback. Working on resolving the comments and getting the checklist. Will update it soon.

Thanks @CatherineSue
Apologies for the delay on getting this reviewed and thank you so much for your contribution :)

@robertgshaw2-neuralmagic I resolved all the comments. Here's an overview of the tasks in the new commits:

[x]  Rename BlockSpaceManagerV3 to EmbeddingModelBlockSpaceManager

[x]  Use ModelRegistry to check for embedding models

[x]  Tests

[x]  Clean up llama_embedding.py

[x]  Update terminology from LlamaEmbeddingModel.embedding to LlamaEmbeddingModel.pooler

[x]  Replace SamplerXXX with PoolerXXX
I added Pooler, PoolingParams, PoolerOutput, and PoolingMetadata. Note that Pooler is not following sentence_transformer's config. I didn't have time to finish it.

[x] LLM.encode
I have separated it from LLM.generate

[x] Log warning from LLM.generate() that this API will change for embedding models
Since I have separated it so I didn't add warning.

@CatherineSue - awesome!
Are you planning to resolve the merge conflicts?
Should I review now?

@robertgshaw2-neuralmagic
I can resolve them if it is easier for you to review. Might take a while, ETA tonight. Does it work for you?

that works, ill review tomorrow

ping me when ready

I can take a first pass too whenever it's ready if @robertgshaw2-neuralmagic doesn't get there before me :)

@robertgshaw2-neuralmagic @ywang96 Just finished rebase

@ywang96 thanks for the quick review. Will start addressing comments after Robert has another look.

Comments above.
Big items:

The CI is red.

Small items:

[ ] Revert LLM.generate interface change. The interface for LLM.generate changed (because we formerly had RequestOutput and now we expose CompletionRequestOutput. This is a breaking change. Its suboptimal, but I think we should have RequestOutput for LLM.generate() and EmbeddingRequestOutput for LLM.encode(). This will avoid a breaking change.
[ ] Expand Test Cases. I like the test framework. Can you expand it to make sure there is some batching that gets triggered?

Questions:

Have you run this though MTEB or anything that can do a holistic of correctness?
Have you run any benchmarking to see if these changes impact performance of the generative models at all?

In terms of follow ups:

Are you planning to continue on the roadmap / refactor that I laid out?

Resolved most comments.

The CI is red. Looks like you are missing a dependency. Add it to requirements-dev.txt
Added the dep. Waiting for CI.

[x] Revert LLM.generate interface change.

The interface for LLM.generate changed (because we formerly had RequestOutput and now we expose CompletionRequestOutput. This is a breaking change. Its suboptimal, but I think we should have RequestOutput for LLM.generate() and EmbeddingRequestOutput for LLM.encode(). This will avoid a breaking change.

I reverted the API. Does this mean I need to revert CompletionRequestOutput back to RequestOutput?
Questions:

Have you run this though MTEB or anything that can do a holistic of correctness?
I tried but LLM.encode() interface is not consistent with SentenceTransformer. And it would raise errors in MTEB.
We have performed correctness testing internally with our science team for their use case.

Have you run any benchmarking to see if these changes impact performance of the generative models at all?

No, it is a valuable benchmark to try. I didn't have time to run regression test for the generative models. Is there any regression benchmark in CI?

In terms of follow ups:

Are you planning to continue on the roadmap / refactor that I laid out?
Unfortunately, I don't have bandwidth to continue the future tasks on the roadmap.

@ywang96 @robertgshaw2-neuralmagic I resolved most of the comments. Please see the summary above.

ModelTest keeps failing due to OOM. I tried to set dtype to half in test_llama_embedding. But it didn't seem to help. I ran it alone locally and the test passed.

Is the model size too big?

@CatherineSue shoot me a note when ready!

@robertgshaw2-neuralmagic It is ready. Not sure how to fix Entrypoints Test's ray resource issue or Models Test's OOM error. Suggestions appreciated.

@CatherineSue Ill take a look at getting the CI to pass

@CatherineSue we have release on Friday, so I think we should merge this after

@robertgshaw2-neuralmagic sounds good. Do you plan to take another look at this PR next week then?

I have reviewed in detail and feel good about it, just have been waiting for a clean CI build

@CatherineSue  https://github.com/CatherineSue/vllm/blob/1c508625a85449c83c8fc1f2f99d78e7035fcbb6/vllm/model_executor/layers/pooler.py#L13
Last token is good, there are some using meaning pooling either.

Another question , this push will only solve llama's embedding problem.
https://github.com/vllm-project/vllm/blob/1c508625a85449c83c8fc1f2f99d78e7035fcbb6/vllm/model_executor/models/llama_embedding.py#L29
Support of other model, is a question?

@WuNein

"mean", "max", "cls", "weightedmean", "lasttoken" are all important.
Another question , this push will only solve llama's embedding problem.

These are not within the scope of this PR. I believe there will be following PRs to cover these topics.

@CatherineSue For me, return the last hidden state is everything. Pool can be implement separately. You offer a solution that is more difficult to use on other model.

@CatherineSue For me, return the last hidden state is everything. Pool can be implement separately. You offer a solution that is more difficult to use on other model.

We can expand upon this in a follow up PR

@CatherineSue I force pushed a commit that fixes the model test in the CI

Going to let the CI run now

@robertgshaw2-neuralmagic thanks!

Another question , this push will only solve llama's embedding problem.
https://github.com/vllm-project/vllm/blob/1c508625a85449c83c8fc1f2f99d78e7035fcbb6/vllm/model_executor/models/llama_embedding.py#L29
Support of other model, is a question?

Adding other models in future PRs!

@CatherineSue Are you going to revert CompletionRequestOutput back to RequestOutput?

@robertgshaw2-neuralmagic I can do that now. I am not clear on the exact solution. Currently CompletionRequestOutput and EmbeddingRequestOutput are inherited from RequestOutput interface. To revert CompletionRequestOutput back, it would mean to remove the interface and maintain RequestOutput and EmbeddingRequestOutput separately, is that right?

@CatherineSue ping me when ready

@robertgshaw2-neuralmagic Code change is done. Some new CIs are failing:
AMD Benchmark Test: Connection Refused.
Speculative decoding tests: CUDA OOM
Models Test: CUDA OOM

@robertgshaw2-neuralmagic I did another rebase. Looks like Speculative decoding and Models tests are still failing due to CUDA OOM. I can't seem to find a solution here. Can I get some suggestions from you? Thanks!

Latest test on llama_embedding

@robertgshaw2-neuralmagic The current failing AMD Distributed Test is not caused by changes in this PR.

@robertgshaw2-neuralmagic Do you think the PR is ready for merging? Given that the vLLM is actively maintained, we're encountering more frequent merge conflicts. Since this PR is extensive, rebasing it has become quite time-consuming. Could we aim to merge it soon?

@robertgshaw2-neuralmagic Do you think the PR is ready for merging? Given that the vLLM is actively maintained, we're encountering more frequent merge conflicts. Since this PR is extensive, rebasing it has become quite time-consuming. Could we aim to merge it soon?

Yes - going to do final review + merge.
Thank you so much for your efforts on this

Going to force push a few things to this branch @CatherineSue - please do not make any more changes

@CatherineSue
Thank you so much for your efforts. This is ready to go. Just letting the CI run and then will merge.

@robertgshaw2-neuralmagic thank you so much for all the time and help on reviews and CIs!!

@CatherineSue Thanks for the incredible works! Is there a speed comparison between vllm and hf/sentence-transformers in terms of inference speed?

Are there any updates to the project docs on how to actually use this feature?

Are there any updates to the project docs on how to actually use this feature?

@linuxliker @K-Mistele this feature is ready to use. You can follow examples/openai_embedding_client.py to use it.

Thanks for the effort @CatherineSue 🙏
The openai example leaves me confused unfortunately:
There is no model name configured in the example.
Does that mean when I use vllm with the mistral model ("mistralai/Mistral-7B-Instruct-v0.2") the embeddings endpoint is automatically enabled as well?
Or do I have to run two vllm instances? one "intfloat/e5-mistral-7b-instruct" for embeddings and one "mistralai/Mistral-7B-Instruct-v0.2" for completions endpoint?
I flew over the code, but unfortunately couldn't figure out how to set an embedding and a regular model at the same time.
Thanks in advance :)

@yannickschuchmann thanks for trying this out. You would need to run two vLLM instances. Running one vLLM instance with two models is not supported for now.

If a model's tokenizer has add_bos_token=True and add_eos_token=True, will vLLM handle this, or should the special tokens be inserted into the text prompt?


test's addition request for test

test has requested that add 'test' to the list of job search resources.

Just testing some stuff!


Proposal for UI and Design Enhancement

Overview:
I would like to propose an initiative to enhance the user interface and overall design of the "Geet" project. This will not only improve the visual appeal of the application but also contribute to a better user experience.
Changes Proposed:
These are the proposed changes i have in my mind
->Redesigning the home page layout for improved content presentation.
->Styling the navigation bar for a more visually appealing and intuitive experience.
->Revamping the user profile page design to be more modern and user-friendly.
->Introducing a dark mode for users who prefer a darker theme.
->Enhancing readability through font adjustments and maintaining consistent UI elements.
Discussion:
I would like to invite feedback, suggestions, and thoughts from the maintainers and the community regarding these proposed enhancements. Your input and ideas are highly valued, and together we can make "Geet" a more engaging and user-friendly platform.
Next Steps:
Once we reach a consensus on these proposed changes, I will proceed with creating a specific pull request to implement them. I'm open to collaboration and discussion as we work together to improve the project.
Thank you for your consideration and I look forward to your input.

Kindly help me review this update @adityakmrmishra

Your proposal to enhance the "Geet" project's user interface and design is great! To move forward and make these improvements effectively, it would be incredibly helpful to have a visual representation of your design ideas. Therefore, I kindly request that you provide a Figma design or any other visual mockup that outlines the proposed changes in the UI/UX. This will make it easier for the maintainers and the community to understand and discuss the enhancements you're suggesting.
Thank you for your initiative and your willingness to collaborate on this project. A visual design representation will greatly facilitate the discussion and implementation of these changes.

Thank you for your response and your valuable support in enhancing Geet's Design.
I'll begin working on a Figma design to illustrate the proposed changes in the Design. As my exams are going on so i estimate that it will take about 7-10 days to create a comprehensive visual representation.
During this time, I'd like to keep the lines of communication open for any additional input or feedback from both the maintainers and the community. If there are specific aspects of the Design that you believe should take precedence or if there are any design guidelines to follow, please don't hesitate to let me know.
Once the design materials are ready, I'll  share them, initiating a focused discussion on these enhancements. I'm truly excited about collaborating with you and the entire community to make "Geet" an even better platform.
Your patience is appreciated, and I'll ensure to keep you updated on the progress of the visual representation.


Edit trip

I also removed the 100m distance requirement on this branch so that it gets merged with the master

The Resources file can be omitted from the commit (its generated automatically when you build and its unique for each machine).


🚀 Feature: Add login/signup page to connect with backend auth APIs of nodejs

🔖 Feature description

[X] Login/SignUp with NodeJS

[X] Use passport for auth

[X] Take username, email, password as signup details

Add Login/SignUp pages

Make request to backend using Axios

Notify status of login/signup using toaster messages in frontend

NOTE: Follow proper coding structure when creating backend code
🎤 Why is this feature needed ?
No response
✌ How do you aim to achieve this?
No response
🔄 Additional Information

Email and username should be unique

There should be a validation check for email, username for signup

Implement best solution which is used in real-world

Skeleton code is done in PR #46

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

hello there! I would like to work on this please.

Okay @techy4shri , you can start working.

I can help you with it in this.

@techy4shri Sorry, We have unassigned you because as you did not raised the PR. @TanishLande has been assigned with consent from the PA.

@mehul-m-prajapati Just want to confirm if you still want me to raise the PR or not. Let me know when you can.

@techy4shri ; yes, you can work on it when you have time.

i'm working on this...

check it out for any required changes

@parassareen4 : Add login option in navbar

sure, on it in a while.

Sorry I was out, just got things back. Let me know if you need any help or I will continue to explore other issues in the meantime?

@parassareen4 are you working on the backend too?

@techy4shri as you were absent @parassareen4 was assigned & is already working on this issue, you can try out other issues.

Sure.

Sure. I just got my account back after suspension so yeah, it's been a while.

no problem you are free to take on the pending issues, share your approach with @mehul-m-prajapati and get assigned on the issue

@parassareen4 : Add login option in navbar

added the login button in navbar
how you want the routing structure at client site to be?

Sure. I just got my account back after suspension so yeah, it's been a while.

@techy4shri : you can look at other issues.

is there anything else to do in this issue?


[🐞] Resource onPending does not render

Which component is affected?
Qwik Runtime
Describe the bug
<Resource onPending={...} /> not working; onResolved works just fine, I see the eventual result render on screen, but the "loading" message I want to display in the interim is never rendered.

Reproduction
https://stackblitz.com/edit/qwik-starter-7hecip?file=src%2Froutes%2Findex.tsx
Steps to reproduce
Go to repro link (created via qwik.new) and do 'npm run dev'
System Info
This is my info, but it also happens in qwik.new online environment.

 System:
    OS: macOS 12.6.2
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 306.66 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 19.1.0 - /usr/local/bin/node
    npm: 9.6.7 - /usr/local/bin/npm
  Browsers:
    Chrome: 113.0.5672.126
    Safari: 15.6.1
  npmPackages:
    @builder.io/qwik: ^1.1.4 => 1.1.4
    @builder.io/qwik-city: ^1.1.4 => 1.1.4
    undici: 5.22.1 => 5.22.1
    vite: 4.3.5 => 4.3.5

Additional Information
No response

Referenced Discord channel & a video of the issue
https://i.imgur.com/RYvr7sq.gif
https://discord.com/channels/842438759945601056/1108776276916973578/1108776276916973578

Just to add a comment, during SPA navigation it works perfectly, the only issue I can see is on SSR (refreshing the page). Looks like a streaming issue, not a Resource component issue itself.

If this happens during SSR only it's a documented limitation because the server is waiting for the promose to be resolved in the server before it streams the rest of the renderred html (currently it can't come back and replace the "loading" to the resolve state)
But there is research that's being done on how to make it work afaik, so we will update as soon as we know

I think I have a similar issue? I have a Resource on page /foo. When navigating from /bar to /foo on SPA, it just waits until the resource is resolved before rendering anything, which obviously does not work for long-timed resources.


Fix docker build on Github Actions

This PR try to fix the problems with docker build, due to running out of space

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 30.88%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2070

Relevant Lines:
6264

💛  - Coveralls


404 - Content Not Found for link https://go.microsoft.com/fwlink/?linkid=832647 in EventID 360 - User Device Registration

The link in EventID 360 - User Device Registration "https://go.microsoft.com/fwlink/?linkid=832647" gives a 404 - Content Not Found.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 49d45db5-5172-45cb-2c4d-d73a9e15d699
Version Independent ID: fa08e81d-3307-514e-129a-843e812e97a9
Content: Hybrid Windows Hello for Business key trust Provisioning (Windows Hello for Business)
Content Source: windows/security/identity-protection/hello-for-business/hello-hybrid-key-whfb-provision.md
Product: w10
GitHub Login: @MikeStephens-MS
Microsoft Alias: mstephen

@officedocsbot assign @mypil

@mvaneijken - Thank you for submitting feedback.
When I checked on the article, I cannot find the EventID 360 link that you mentioned in this issue. This could mean that this link was removed from this article.
Thank you.

@mypil : The link referred to by @mvaneijken is not a link in the article document, but the link appearing in Event Viewer in Windows 10.

The link referred to by @mvaneijken -- https://go.microsoft.com/fwlink/?linkid=832647 -- points to

https://docs.microsoft.com/windows-server/identity/ad-fs/whats-new-active-directory-federation-services-windows-server

... which gives the 404 page.

See also this Technet page (from 1 year ago) for related info:
https://social.technet.microsoft.com/Forums/en-US/3860e01c-abe1-4957-9483-43f131aa5a7d/windows-hello-for-business-user-device-registration-error?forum=win10itprosetup

@illfated - Thanks for the clarification.
@mvaneijken - I think the best way forward is if you can open a service ticket so this can get resolved ASAP. Based on outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for Windows 10 products:
https://support.microsoft.com/en-us/hub/4338813/windows-help?os=windows-10
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.

@mvaneijken : If your Event ID 360 is on Windows Server 2016, the software may not be updated enough and the so-called "What's new" page may have been moved because of Windows Server 2019.

@officedocsbot close


Update Documenter

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1fdef90) 1.27% compared to head (9733cd5) 0.75%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #50      +/-   ##
========================================
- Coverage   1.27%   0.75%   -0.53%
========================================
  Files          8       7       -1
  Lines        707     665      -42
========================================
- Hits           9       5       -4
+ Misses       698     660      -38

Files
Coverage Δ

src/trace.jl
0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


exports.__esModule should be emitted in declaration file

Currently, a __esModule export would be appended to target js file for es module, but not in the declaration file, which causes canHaveSyntheticDefault checking failed.
TypeScript Version:  3.7.x-dev.201xxxxx
__esModule
esModuleInterop
Code
// canHaveSyntheticDefault checks __esModule exports

// function canHaveSyntheticDefault ...

// It _might_ still be incorrect to assume there is no __esModule marker on the import at runtime, even if there is no `default` member
// So we check a bit more,
if (resolveExportByName(moduleSymbol, escapeLeadingUnderscores("__esModule"), /*sourceNode*/ undefined, dontResolveAlias)) {
    // If there is an `__esModule` specified in the declaration (meaning someone explicitly added it or wrote it in their code),
    // it definitely is a module and does not have a synthetic default
    return false;
}

Expected behavior:
__esModule exports emitted in both declaration and target js file for es module
Actual behavior:
__esModule exports only emitted in target js file:
Object.defineProperty(exports, "__esModule", { value: true });

Related Issues:
https://github.com/microsoft/TypeScript/issues/41898

My comments in the other thread apply equally here


[Security] SAM temporary file not deleted

All versions of CME < 4.0 are buggy, leave an export of the Windows SAM/LSASecrets registry keys in the following folder: %windir%\system32********.tmp and put a weak DACL.
This security issue appears when the following options are specified : --sam, --lsa and --ntds.
It gives a local user the opportunity to obtain the LM:NT hashes of the local Administrator account (RID 500) and can be used for privilege escalation or lateral movement.
The vulnerable code is in the __retrieveHive function:
[...]
tmpFileName = ''.join([random.choice(string.letters) for _ in range(8)]) + '.tmp'
[...]
rrp.hBaseRegSaveKey(self.__rrp, keyHandle, tmpFileName)
[...]
remoteFileName = RemoteFile(self.__smbConnection, 'SYSTEM32\\'+tmpFileName)
return remoteFileName
[...]

The tmpFileName is never removed.
CME 3.1.5 should be deprecated if you don't remove the tmp files.
Please upgrade a CrackMapExec release 4.0.
ʕ•̫͡•ʔ ʕ•̫͡•ʔ ʕ•̫͡•ʔ
tmpsam

The only real difference between v3 and v4 is that CME switched to using the same function that impacket's secretdump.py uses. Impacket still does this here:
https://github.com/SecureAuthCorp/impacket/blob/61d24d713c380761a226733b1498905a98ccbe84/impacket/examples/secretsdump.py#L774-L788
So this might be something that Impacket might want to address as well. Although, from a developer's standpoint, robust error handling might be the easiest way to address this.

I get that the SAM is vulnerable as you can pass the hash locally or decrypt.  Not to sound like a noob, but I'm gonna......what can you do with LSA secrets?  Can't pass the creds, and from what I have seen they are much harder to decrypt than a sam hash.  Am I missing something ridiculously obvious.....thanks in advance.  Always trying to learn new things.

Closing, the issue seems to be fixed as I don't see any tmp file into system32 folder :)
Feel free to reopen if you as this issue again !


Allowing Eyal to approve user

Eyal will like to volunteer to approve waiting list when time permits

/test appstudio-e2e-tests


Fixed #3084

Modified class.js once event listener. Moved handler.apply(self, args) to run after if (onceHandler.f7proxy). This should fix a bug where this event runs more than once. See issue 3084.

Great, thanks!


feat: add support for automatic 997 generation

add x12-tools dependency
add top level ack property on partnership data model, including bucket destination when enabled
generate and deliver 997 for inbound interchanges when ack: { enabled: true } on partnership

Closes: #19

I tried to take this for a test drive in my account, and hit an error running npm run bootstrap

🤦 apologies, @BDQ! I had already addressed this actually, but apparently I never pushed the commit up! Give it another shot when you have time


need to make sure observer has not been deleted before doing a delayed update

SetState is generally delayed to the end of the rendering cycle, and all updates are sorted and queued to prevent multiple updates of the same value.
If component A gets a state update during this delayed update process, and that causes another component to unmount, and that component is scheduled to receive state updates, react.js generates a warning (because you will attempt to do a state update on an unmounted component.)
The fix is to simply check to see if the observer has been removed from the current_observers list.
module React
  class State
    def self.set_state(object, name, value, delay=ALWAYS_UPDATE_STATE_AFTER_RENDER)
      states[object][name] = value
      if delay || @bulk_update_flag
        @delayed_updates ||= Hash.new { |h, k| h[k] = {} }
        @delayed_updates[object][name] = [value, Set.new]
        @delayed_updater ||= after(0.001) do
          structure_check('delayed set state')
          delayed_updates = @delayed_updates
          @delayed_updates = Hash.new { |h, k| h[k] = {} }
          @delayed_updater = nil
          updates = Hash.new { |hash, key| hash[key] = Array.new }
          delayed_updates.each do |object, name_hash|
            name_hash.each do |name, value_and_set|
              set_state2(object, name, value_and_set[0], updates, value_and_set[1])
            end
          end
          updates.each { |observer, args|
# -------> CHECK to make sure observer is still in current_observers hash
            observer.update_react_js_state(*args) if current_observers.key?(observer)
# ------->
          }
          updates = nil
        end
      elsif @rendering_level == 0
        updates = Hash.new { |hash, key| hash[key] = Array.new }
        set_state2(object, name, value, updates)
        updates.each { |observer, args| observer.update_react_js_state(*args) }
      end
      value
    end

The above code will work as a patch if you want to try it.

The patch above requires commenting out this line:
# structure_check('delayed set state')


Allow to remove TableNameSuffix on operation level

Fixes #3470
Description
Allow to remove TableNameSuffix in operation-level configs by setting an empty string.
Motivation and Context
In some cases I have most of the tables with suffix, and one or two, which do not correspond to such convention. In this case I would like to be able to use TableNameSuffix globally, but remove it per operation.
Testing
Added unit tests.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[x] I have updated the documentation accordingly
[x] I have read the README document
[x] I have added tests to cover my changes
[x] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

Verified that all unit tests and integrations tests pass locally.
@dscpinheiro has initiated a full dry-run that will run this commit through our build system.

@Dreamescaper Shouldn't the PR title and the commit message read_"...remove TableNamePrefix"_ instead of TableNameSuffix?
Unless I am missing something.


Split out kube and helm code from suse-extensions package and port upstream

covered by another issue, brought downstream via #4630


How to migrate dynamic custom select options on panels from v3.2.1 to >3.4.0

Hi, i have a problem with dynamic custom select options on panel when i try to update from v3.2.1 to v3.4.0 version (and up to 3.6.0).
Testing Issue:
The testing issue is a empty data manipulation panel with 1 form panel (type: "Select With Custom Options") with empty options. On initial Request custom code i write the next code which push 4 custom options to the form panel:
console.clear();

elements[0].options = [];
onChange(elements)

const selectorOptions = [
  "a", "b", "c", "d"
]

selectorOptions.forEach((option) => {
  elements[0].options.push(
    {
      id: option,
      label: option,
      type: "string",
      value: "a"
    }
  )
});

onChange(elements)

v3.2.1 output:
Output is the expected:

v3.4 (and newer) output:
Output is empty:

Thanks in advance for your time!

@daguirrem working example for your case
console.clear();

context.panel.elements[0].options = [];

const selectorOptions = [
  "a", "b", "c", "d"
]

selectorOptions.forEach((option) => {
  context.panel.elements[0].options.push(
    {
      id: option,
      label: option,
      type: "string",
      value: "a"
    }
  )
});

context.panel.onOptionsChange({
  ...context.panel.options,
  elements,
})

Please let us know if there is anything else


Fix specs to work when simulators not installed

This spec is failing on my machine, because it expects the TV simulator was installed.
I'm not sure if this breaks the scope of the unit test, but figured others might run into the same situation.

Thanks for the PR, looks nice, I added one comment 👍


Firefox equivalent?

Hi! I love this project, makes my presentations look great. Just wondering if there's a Firefox project for this?

Hi! I'm glad it's been useful for you! Unfortunately I'm not aware of Firefox equivalent.


Localization changes for web extension

Requirements added here: https://github.com/microsoft/vscode-dev/issues/477
To address string literal issue changes are made directly - link to issue - https://github.com/Microsoft/vscode-nls-dev/issues/5
Testing:
npm run compile-web
tested with portal route -
http://localhost:3000/powerplatform/portal/webpages/563a8e53-6cf7-ec11-82e4-000d3a8b4b81?orgUrl=https://org4e297bda.crm10.dynamics.com&dataSource=Dataverse&schema=portalDataverseoldschema&websiteId=24828659-6cf7-ec11-82e4-000d3a8b4b81&websiteName=Site 5&clientSessionId=20d30dc0-040a-11ed-a9c5-d5d08bd7e3e0&Client=PowerPagesStudio

Added the loc files


Add hints to Custom Signs

where/how does these show up?

In the exercise there's a hint icon 💡 in the top right corner.

It opens a popup with hints for each task:


merge

Description

Checklist

[x] I have added screenshots above for all UI changes.
[x] I have added e2e tests for all UI changes.
[x] Documentation was updated if it was needed.

@karlotimmerman sorry what was this PR about? It looks like this PR is changing some yarn dependency versions. Can this PR be closed?

Yes, sorry accidentally created a pr.


Fix feature provenance for URL and Email features in DefaultAlgorithm

Fixes #3392.

@jeremyliweishih Also, let's make sure Restaurant Likes is in our perf test dataset collection!


Fix, port renorm option is respected also in Driven Terminal

_create_port_terminal had no "renorm" parameter. Consequently the renorm option was ignored if the solution type was Driven Terminal.

@Alberto-DM, can you just add a unit test for the new argument renorm?
Otherwise LGTM.


Added party for Amsberry, Guerrero, Peters, 2008

Excellent! You're in! Email your mailing address to<EMAIL_ADDRESS>to get your sticker.


Upload failure

Hello again,
ive got my pageflow application now ready and running.
Still some flaws ill have to figure out with the help of the logfiles.
One issue i cant figure out myself. If i try to upload an image file of 3.7MB
the upload fails with a "Upload failure.".
This failure is not logged in any way. Neither in the /log/production.log nor in the /log/jobs/production/resizing.log
No output there at all.
Can someone give me a hint on this?
Thank you in advance and best regards,
Ronald

Check your Nginx logs. Probably client_max_body_size is not configured correctly. Non of this is really a Pageflow issue, though, but general topics on how to run Rails applications in production.

Of course its the only part i didnt check. Thank you for that hint.
The Issue can be closed now.
Best regards,
Ronald


[Bugfix] ListView: horizontal grid

Horizontal grids fixed for TopHorizontal and BottomHorizontal layouts.

Now some of the layout functions look very similar, such as topVerticalLayout() and bottomVerticalLayout(). I suspect we can further simplify/optimize the code. Let's do it later


Need Paging

Is there any way to implement paging with appendgrid.

Hi vikasroimantra,
In order to form values to submit to backend by using normal HTTP POST method , appendGrid  needs to generate all input elements on screen. I am afraid it is not possible to apply "paging".
You may take a look on fix header demo if you don't want a long table on screen. Thanks!


COPY command runs but no data being copied from Teradata (on-prem)

Hello,
I am running into an issue where I have a set up a pipeline that gets a list of tables from Teradata using a Lookup activity and then passes those items to a ForEach activity that then copies the data in parallel and saves them as a gzipped file. The requirement is to essentially archive some tables that are no longer being used.
For this pipeline I am not using any partition options as most of the tables are small and I kept it to be flexible.
Pipeline

COPY activity within ForEach activity

99% of the tables ran without issues and were copied as gz files into blob storage, but two tables in particular run for long time (apprx 4 to 6 hours) without any of the data being written into a blob storage account.

Note that the image above says "Cancelled", but that was done by me. Before that I had a run time as described above, but still no data being written. This is affecting only 2 tables.
I checked with our Teradata team and those tables are not being used by any one (hence its not locked). I also looked at "Teradata Viewpoint" (admin tool) and looked at the query monitor and saw that the query was running on Teradata without issues.
Has there been such an issue before? Please let me know if there is anything in Azure settings that I can do.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a317cac0-e27c-7263-8c85-e44243b21234
Version Independent ID: 8d0f5788-07f2-56e4-79c1-7ee944976f77
Content: Copy data from Teradata Vantage by using Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/connector-teradata.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@vlado101 Thanks for reaching out. It looks like you are referring to a specific used case scenario and not directly related to document content. This type of queries are best suited in other community forums, hence we request you to please post your question on "MSDN - Azure Data Factory" and other forums (Stackoverflow - Azure Data Factory). We have our engineers and others who are monitoring them and will be happy to help.
Please do share the thread link here, once you have posted your query in MSDN/Stackoverflow.
If you have a document which you are following and if you think it needs an update, please let us know about that here.
Thank you.

Hello,
Just wanted to post a response just in case someone is still facing this issue. The issue that I had was that I was trying to write a very large file with just a single query on the source side. Once I update my job to do parallel queries (from Teradata side) then the job completed without issues.


whitelist valtech ip address

What
Added Holly-requested valtech ip to tenant whitelist in prod.
For off-site usability testing on 2016-12-02.
How to review
Holly or her testee needs to check connectivity from the remote site before the user testing starts.

IP matches that from story, merging


When SWITCH function will be available on ChainX 2.0 web wallet (https://dapp-v2.chainx.org)

Hello, in ChainX 1.0 there was a very helpful function which allows to transfer stake amount from a node to another with a minimum interval of 3 days.
I know that this feature is present in the code of the chain, so when will be available on ChainX 2.0 web wallet?
Let us know
Thank you

Ok now it is available! Thank you


Cache the _location_without_md5.

Fixes #2089. Alternate to #2090.

This relies on the fact that location should be set only once. Is there anything that avoids to set it twice ?
This is why #2090 makes location a property.

There's nothing that prevents it from being set again, but there's also no reason to think that it will be set again.

@jaraco While reading the code to answer to your question on #2089, I notice the following:

hashcmp is mainly slow because of _remove_md5_fragment but it uses a lot of properties
key and parsed_version are also cached, with two very simple but differing implementations, key uses try except AttributeError; parsed_version uses hasattr

This leads me to the following questions:

Should the full hashcmp be cached ? I tend to answer yes because it already relies on other cached properties.
Could it be cached simply, like key or parsed_version ? I also tend to answer positively.
Which implementation should we choose ? hasattr or try except ? I am not deep enough in Python internals to know which is quicker.
Is there a reason to use a different implementation of caching for keyand parsed_version ? Should we unify on the quickest ?

I prefer #2108. I'll answer the questions in #2089.


UniTask - Performance Spikes

Issue Description:
Running around on Genesis Plaza with debugger shows big performance spikes with UniTasks and huge memory allocations

STR:

Launch Editor with Profiler
Run around Genesis Plaza, it's more probability the error would occur if run towards an unloaded scene

It's mostly AB errors, we have to redefine the errors policy


[Bug] Selection background is not rendered correctly

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: v1.60.0-insider
OS Version: Windows 10

Steps to Reproduce:
Notice at the second round of selections, the second foo isn't highlighted after pressing Escape:

I'm interested in trying this out. Would you have any tips on where to start?

@maldahleh The logic for this is implemented here

@alexdima Thank you

@alexdima fixed on https://github.com/microsoft/vscode/pull/136625 - let me know if anything needs to be changed.


Missing DLL error

System information

OS Platform and Distribution (e.g., Linux Ubuntu 20.04, WSL2): Linux 20.04
Target (e.g. desktop cpu, android arm64): desktop and android
Bazel version: 4.0.0
Python version: 3.9
GCC/G++ version:
Unity version: 2019.4.13f1
Android NDK version (if building for Android): 21.x
Xcode version (if building for iOS):

Describe the problem
I installed opencv and have two versions it seems, one from apt-get install, installed to /user/lib/x86_64-linux-gnu, version 4.2.0 and one it seems is downloaded via bazel build, installed to /user/local/lib when I edit WORKSPACE and linux build I still don't find the DLL
WORKSPACE, tried both paths, here is the current
new_local_repository(
name = "linux_opencv",
build_file = "@//third_party:opencv_linux.BUILD",
path = "/usr/local/lib",
)
And
cc_library(
name = "opencv",
srcs = glob(
[
"usr/local/lib/libopencv_core.so",
"usr/local/lib/libopencv_calib3d.so",
"usr/local/lib/libopencv_features2d.so",
"usr/local/lib/libopencv_highgui.so",
"usr/local/lib/libopencv_imgcodecs.so",
"usr/local/lib/libopencv_imgproc.so",
"usr/local/lib/libopencv_video.so",
"usr/local/lib/libopencv_videoio.so",
],
When I find the opencv versions I get:
find / -name "libopencv_video.so" -print 2>/dev/null
/x/x/.cache/bazel/_bazel_wventer/ce2d6f27d9834f5b0751c3dd09fab20a/external/linux_opencv/libopencv_video.so
/usr/lib/x86_64-linux-gnu/libopencv_video.so
/usr/local/lib/libopencv_video.so
They are:
4.2 in /user/lib/x86_64-linux-gnu
3.4.14 in /usr/local/lib
Steps to reproduce the issue
Provide the exact sequence of commands / steps that you executed before running into the problem.
All instructions as per the build guide, it builds without error, just missing DLL error when starting in Editor, same build works fine on a Windows PC, so related to opencv location on Ubuntu
Full logs
Additional context
Add any other context about the problem here.
I get this when setting load at start:
Plugins: Couldn't open /x/x/UnityProjects/MediaPipeUnityPlugin/Packages/com.github.homuler.mediapipe/Runtime/Plugins/libmediapipe_c.so, error: /x/x/UnityProjects/MediaPipeUnityPlugin/Packages/com.github.homuler.mediapipe/Runtime/Plugins/libmediapipe_c.so: undefined symbol: _ZTVN2cv9BFMatcherE

You need to specify the root path in WORKSPACE and relative paths in opencv_linux.BUILD.
In your case (OpenCV 3), I think path in WORKSPACE should be /usr/local and opencv_linux.BUILD should be kept untouched.

Thank you, that solved it, hat to set the path to /usr/local


fix(move-cli): ignore_compile_warnings test flag ignored

Description
The --ignore_compile_warnings flag for sui move test was forgotten along the way, making it effectively ignored. This PR forwards it properly.
Test Plan
No tests for this. Verified expected behaviour by using the local CLI build.

Thanks for this fix!


add visit_col to config wiki

Fixed.
cc: @bzkrouse just in case this slipped through the cracks in ReDish


Update streaming subscription to understand new initial response

Description

Issue reference

Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@mikeee done


Sort report rows

After impl. concurrent operation, rows are randomly added.
Require sorting for ease of use.

Partially implemented. But no significant requirement for long time. Wont' fix for this time.


Add usage metrics headers to CLI requests

Description of change

Fixes https://github.com/meroxa/cli/issues/536
Fixes https://github.com/meroxa/product/issues/614
Type of change

[x]  New feature
[ ]  Bug fix
[x]  Refactor
[ ]  Documentation

How was this tested?

[x]  Unit Tests
[ ]  Tested in staging
[ ]  Tested in minikube

Demo

before
after

Additional references

Documentation updated

There are two layers for headers:

For all CLI commands:

Meroxa-CLI: if the request is coming from the CLI
Meroxa-CLI-Version: version of the meroxa CLI

When the CLI command is a turbine app:

Meroxa-CLI-App: if it is coming from App
Meroxa-CLI-App-Lang: language used for the turbine integration
Meroxa-CLI-App-Lang-Version: version of the library used for the turbine integration

We could maybe remove Meroxa-CLI & Meroxa-CLI-App Because we could verify if the other fields are set. Different from the document, what do you think?

@janelletavares Thank you for addressing https://github.com/meroxa/product/issues/614. Could you open a separate a pull-request that fixes it? This helps with our automated changelog (example: https://github.com/meroxa/cli/releases/tag/v2.8.1) and helps with reviews, rollbacks (if necessary). Thank you.


Particles 2D and 3D - fix hue variation not working

The hue variation matrix is hardcoded as transposed and thus the multiplication always yielded the original color value.
I wanted to keep the matrix and get the same result by switching the operands (getting a result as if the matrix was transposed back to the correct state).

You mention Particles2D but this only modifies Particles(3D) no?

This code, even though it's particles.cpp not, particles2d.cpp, is also used for 2D particles. I believe that's because the fragment shader is the same for them.

This code, even though it's particles.cpp not particles2d.cpp, is also used for 2D particles. I believe that's because the fragment shader is the same for them.

I want to note that this commit has inverted the spectrum in this property in ParticlesMaterial for Particles2D, so any dessigner that were working with hue variation will see color changes (or almost inversion if the parameter is about 0.2-3  0,7-8 and not completely because is stepyfied  (why?) to 0.1) in their scenes. If this is the new state of this property should be advertised to skip questions like "-Why is my fire green now?" So any explanation in the note of the new release is needed.

From what I experienced, changing the value of hue variation properties had no effect until this change. So yes - if someone left them changed it will have effect on their particles. The step should probably be removed or changed to a much lower value? I might look into it and add it to this PR (?).

I have a godot compilation from 1 month ago and hue variation was working for 2d. With this commit the direction of variation in spectrum is inverted ( from red to blue to red to yellow) i will investigate commits from 3.02 and report here. (This pr is merged so if any fix is needed probably new pr will be needed, PM CC @Akien will say).

This is strange. Look this:

And this is the compilation from yesterday:

What is your platform?

Think that did a wrong invocation in past menssages, i will try with correct name:  CC @akien-mga
I want make an aclaration. I´m not saying that this is a bug, I like more this scale because with the implemented algorithm and the "0.1" stepify is hard to do some effects (Ej: Red to yellow to do fire...). but with inverted scale red-yellow is easy to do. And your system is really better (More natural colors can be accomplished). But this is a visible functionality change that will be reported from dessigners than uses particles2d with hue variation ( There will be some more than you and me..... or not!). So, if there is something somewhere an explanation that this is not a bug will be needed.

I'm on Linux 64 bit (Mint 17)

I had a quick look at 3.02 build and my repro project seems to work with hue variation there - could it be that in 2.1 the variation worked the way like after my change and that's what I orignally noticed? I don't exactly remember but I started looking into this because my hue variating particles looked differently than in 2.1 even with same parameters. Feel free to revert this if this behaviour is not desired. I can confirm that the latest version works with the original code - the color scheme is just different (dimmed compared to my version).

I have no problem with this commit, don't think it will be reverted. I will investigate to do an aditional commit to fix the implemented particlesmaterial properties bounds to have a correct limits/stepyfies in parameters. A good idea will be to have a property to invert the scale (like a tick). With the invert option no compatibility is break and all colors can be acomplished, but this is more that i can do. My vote is to maintain the inverted scale (more useful) until this parameter can be used up and down the spectrum.


chore: prepend @aws-amplify to dependencies pt.8

Description of changes
Dependencies changed:

amplify-function-plugin-interface
amplify-headless-interface
amplify-util-headless-input
amplify-velocity-templates

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[n/a] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[x] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #11973 (7a6a20b) into dev (984c0f8) will decrease coverage by 3.61%.
The diff coverage is 58.23%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev   #11973      +/-   ##
==========================================
- Coverage   49.45%   45.85%   -3.61%
==========================================
  Files         692      819     +127
  Lines       33424    37636    +4212
  Branches     6840     7726     +886
==========================================
+ Hits        16529    17257     +728
- Misses      15370    18693    +3323
- Partials     1525     1686     +161

Impacted Files
Coverage Δ

...y-appsync-simulator/src/resolvers/unit-resolver.ts
90.32% <0.00%> (ø)

...ages/amplify-appsync-simulator/src/schema/index.ts
70.68% <0.00%> (-1.25%)
:arrow_down:

...s/amplify-appsync-simulator/src/type-definition.ts
100.00% <ø> (ø)

...tor/src/velocity/util/transform/dynamodb-filter.ts
4.93% <0.00%> (ø)

...ync-simulator/src/velocity/util/transform/index.ts
21.05% <0.00%> (ø)

...appsync-simulator/src/velocity/value-mapper/map.ts
86.88% <ø> (ø)

...ackages/amplify-category-auth/src/commands/auth.ts
0.00% <0.00%> (ø)

...es/amplify-category-auth/src/commands/auth/help.ts
0.00% <0.00%> (ø)

.../amplify-category-auth/src/commands/auth/import.ts
0.00% <0.00%> (ø)

...vice-walkthrough-types/cognito-user-input-types.ts
100.00% <ø> (ø)

... and 439 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update action to create issue in kanban board

Try out this version of the Stacks Wallet - download extension builds.

This PR updates the github action to create a new issue for firefox from the template .github/FIREFOX_ISSUE_TEMPLATE.md in the current repo.
Additionally, it adds this issue to the Kanban board https://github.com/orgs/blockstack/projects/44 in the Backlog column.
Note: If the issue is currently open, it won't add a new issue - it will attempt to update the issue (in the case where the content is different). this can be disabled by setting update_existing: true in the step Create Issue for Firefox Manual Step.
https://github.com/hirosystems/devops/issues/705
cc/ @aulneau @kyranjamie @fbwoolf

Think i have a typo in the board org name....checking


Added ko_KR (Korea) localization

Hi, Anders.
I translated all as I can, with iBluemind.
We think we are lucky to translate this nice job.
Thanks,
DrZix

Really nice!
Thank you very much :)


where is the image file ?

It would be useful if I can get the image file that you used .
Errors I'm getting with other image files :
** Error: Image file has no EXIF data.

Me too getting the same error when running it on my set images.
Could you solve it @bismoy2013 ?


Fast switch between Beer Banker

As longs as we don´t have any new Upgrade system like our Beerwarts, can we have an fast switch arrow between our Beer Banker
I really dont like to klick any more

I think we need some fast Solution, because my 70 Bankers have a Balance of Minus 300 Seconds worth of Production. So the Game ist unplayable when i dont keep teaching my Bankers one by one.

@Marcnesium87 which balance is negative? the current balance or the total balance?

Current is negativ. Total stays uncangend since couple of days. So i think i dont earn any Money with them. (19 Back Rooms with full Path)


installation: tell user to install submodules

git submodule update --init --recursive

submodule is not well managed by github yet (download zip --> no submodule!). I added MoxUnit directly as a folder in External

If you want the modules to appear for the user immediately on download/clone, isn't a git subtree what you want instead of a submodule?
I use submodules in my C++ quantitative stuff (github.com/spinicist/QUIT), but that's because people may have them on their system already and prefer to link against them.
For a Matlab project, I guess you always want the files present so a subtree is more appropriate?

On 21 Sep 2017, at 21:07, tanguyduval<EMAIL_ADDRESS>wrote:
submodule is not well managed by github yet (download zip --> no submodule!). I added MoxUnit directly as a folder in External
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

thank you @spinicist
i guess we can reopen this issue and change the title for suggesting the possibility to link this external repo as a subtree

done in ada500a950cb8689a9c0a5300de2074ecbf18f95


with a pipsText-array you can define pip text

an example array could be:
"pipsText": [
{
"value": 4,
"text": "example"
},
{
"value": 10,
"text": "Another pip"
},
]

Thank you for the contribution!


Scraper SO date time fix

replaced wrong character with :

The date/time scraping is all here: https://github.com/openZH/covid_19/blob/master/scrapers/scrape_dates.py
There are even some tests here: https://github.com/openZH/covid_19/blob/master/scrapers/test/test_dates.py


File Uploads

See File Uploads

Available in latest release 0.6.0.
Example here: https://github.com/floodfx/liveviewjs/blob/main/packages/examples/src/liveviews/photos/index.ts
Still need to update docs a bit but can run the express or deno example server and see it live at /photos path.


WFLY-14869 Add support for MicroProfile LRA

https://issues.redhat.com/browse/WFLY-14869

@xstefank this probably needs rebase after https://github.com/wildfly/wildfly/pull/16544

/retest

/retest

Updated to the final release of MP LRA 2.0 - https://github.com/eclipse/microprofile-lra/releases/tag/2.0

/retest

@xstefank I think Paul's inputs re capabilities would be good to get into this, particularly re the attribute definitions.  I didn't cover those in my review because TBH the handling of those capabilities in the undertow subsystem is not really clean and I didn't want to enforce proper use of an unclean contract. Those capabilities are private, and the Host and Server types they expose have not-so-clean interfaces that should be cleaned up before those capabilities are "officially" marked as public (e.g. via "PRIVATE = false" in [1]).
But, other subsystems use Host, and your use here matches how I'd expect any cleaned up Host type to work. And using the capability reference stuff in the AttributeDefinitions allows proper configuration validation by the server, which is a good thing.
[1] https://github.com/wildfly/wildfly-capabilities/blob/main/org/wildfly/undertow/host/capability.adoc
If it's ok with you adding updates for that in a separate commit in this PR would be good. Leaving the existing commit unchanged will help me a bit with pulling together this change in combo with Jason Lee's and Jean-Frederic's.

@bstansberry I added those in the latest push - https://github.com/wildfly/wildfly/pull/16547/files#diff-ecb5c4f8643a28ebeabc67bdfc5baf66e36fa2303e7f75471f108e0259041384R90 and https://github.com/wildfly/wildfly/pull/16547/files#diff-c9bb2d7aed1dca50fb31bfbf153435ff37cdb30617d8e8a6fd709333cbc64158R70. But I don't know if this is enough. I will fix in the follow up if needed.

/retest

Thanks, @xstefank!


Primaries swatch

The material design primary color swatches, excluding grey.
primaires

@rafamizes 3 puzzles #32, #33, #34 are still not solved.

@rafamizes all 3 puzzles are solved here: #32, #33, #34.


#60 Added weather app extension

#60
I added a weather app chrome extension that takes the current user location and displays the weather status of that location.
preview:

No, I added dynamic latitude and longitude to get the location. It's not hard coded.


Tooltip does not show when hover on  MenuItem

When I hover over MenuItem component which wrapped to Toolip, Tooltip does not fire.

[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Tooltip should be shown on hover
Current Behavior

Tooltip does not show when hovering on MenuItem
Steps to Reproduce (for bugs)

https://codesandbox.io/s/9jyv058xyr
Context

Your Environment

Tech
Version

Material-UI
v1.0.0-beta.34

React
16.2.0

browser
chrome 64

etc

Clarification:
A Tooltip will not appear on a disabled MenuItem.
It will appear for a MenuItem that is not disabled, but if there is not enough room for the tooltip, it will behave erratically.  See this codesandbox.
Here is another codesandbox  which is a modification of the first one.  It increases the width of the Menu to accomodate the Tooltip and everything appears to be working.  Is this your expected behavior?  If not, would you please elaborate?

Actually, I can show even on disable an item, just wrapped MenuItem to div, I've already solved this issue previously because tooltip populates events to the child. So you can check that it possible to show it on disabling one here https://codesandbox.io/s/6zx6j184z3
But the real problem to show tooltip from the right of the menu item, not inside or over on menu item.

Okay, so it is possible to display a Tooltip on a disabled MenuItem if you wrap the entire MenuItem in a div and wrap that with a Tooltip 😄

...the real problem to show tooltip from the right of the menu item, not inside or over on menu item.

Good clarification of the issue.

@palaniichukdmytro
Thanks for your fix with the div wrapper. I also found that the Tooltip didn't respect any placement properties you gave it.
I was also experiencing this issue https://github.com/mui-org/material-ui/issues/10735 so a quick hack I'm using to position the Tooltip is this:
<Tooltip PopperProps={{ style: { pointerEvents: 'none', marginTop: '40px' } }}>
  ...
</Tooltip>

It's not pretty but maybe it's a quick fix for now.

I have updated the reproduction to the latest version: https://codesandbox.io/s/926jp1qwyr.

Okay, so it is possible to display a Tooltip on a disabled MenuItem if you wrap the entire MenuItem in a div and wrap that with a Tooltip 😄

Worth noting that the disabled MenuItem will still be selectable when it's wrapped with a div. The div must have
pointer-events: none to avoid this issue.

Okay, so it is possible to display a Tooltip on a disabled MenuItem if you wrap the entire MenuItem in a div and wrap that with a Tooltip 😄

...the real problem to show tooltip from the right of the menu item, not inside or over on menu item.

Good clarification of the issue.

The only problem with this is that it's not accessibility friendly as you can't navigate using a keyboard only.


Custom components can't be set via renderRichText resolver

Expected Behavior
Documentation says

You can also set a custom Schema and component resolver by passing the options as the second parameter of the renderRichText function.

renderRichText(props.blok.articleContent, {
  schema: mySchema,
  resolver: (component, blok) => {
    switch (component) {
      case "my-custom-component":
        return `<div class="my-component-class">${blok.text}</div>`;
      default:
        return "Resolver not defined";
    }
  }
})

Current Behavior
I have tried a few different combinations (with/without Schema) to make it work, but had no luck. The idea is pretty simple — I want to replace some generic tags (e.g. <p>) with my own custom components during rich text rendering. Or maybe I didn't get the purpose of renderRichText and its resolver?
Steps to Reproduce
Here is a reproduction link.
https://stackblitz.com/edit/github-5bwqah?file=pages/index.vue

This isn't what the component resolver is for. The component resolver is for when you embed a Storyblok component inside of a rich text field, such as the Feature component in the screenshot below.

@joezimjs thanks for the clarification! That was not that obvious :thinking: . I'll give it a try!


CONTRIBUTORS.md

Hi,
Creating my first Open source contribution for hacktoberfest 2021.
Thank you
Shiladitya

HI Nishant,
I am not getting any conflicts actually from my side. Could you please tell me what is the conflict basically.It would be helpful
Thank you Shiladitya

@shiladityaroy212, I've made the required changes from my side. No worries.

Thanks a lot !!! Nishant


JDBC Driver error during compile time

Describe the bug
I have a small issue to decribe. This error occurs in  jdbc driver.
When I try to compile I occurs this error message:
$ ./gradlew assemble
Erro: Não foi possível localizar nem carregar a classe principal org.gradle.wrapper.GradleWrapperMain
Causada por: java.lang.ClassNotFoundException: org.gradle.wrapper.GradleWrapperMain

This error is  happening because the file gradle-wrapper.jar dont exists in directory. I verify that in the file  .gitignore there is a configuration to exclude this file.
When I drop gradlew and grandlew.bat and create a new wrapper with the same gradle version  and it works!
How about remove  entry for .gitignore file and put gradle-wrapper.jar in the repository? Or at least exclude gradle wrapper binary to force run gradle wrapper again?
I hope this issue can help others developpers.
Thanks for this driver and  I hope that this issue can be resolved as soon as possible.
How are you accessing AGE (Command line, driver, etc.)?

JDBC

What data setup do we need to do?
None
What is the necessary configuration info needed?

Only try to compile java driver

What is the command that caused the error?
$ ./gradlew assemble

Erro: Não foi possível localizar nem carregar a classe principal org.gradle.wrapper.GradleWrapperMain
Causada por: java.lang.ClassNotFoundException: org.gradle.wrapper.GradleWrapperMain

Expected behavior
Succesfull compile
Environment (please complete the following information):

Version: Latest

Additional context
When I drop gradlew and grandlew.bat and create a new wrapper with the same gradle version  and it works!
How about remove  entry for .gitignore file and put gradle-wrapper.jar in the repository? Or at least exclude gradle wrapper binary to force run gradle wrapper again?

Waiting for a feedback

@amthiagomont Could you provide the command you used to build the file?

I just cloned the repository and ran the command $ ./gradlew assemble , as i described when i open the issue.

@amthiagomont Thank you. I was able to reproduce it. However, I'm not exactly sure what you mean by -

Additional context
When I drop gradlew and grandlew.bat and create a new wrapper with the same gradle version and it works!


Remove unnecessary null pointer checks

An extra null pointer check is not needed in functions like the following.

letter
sliding_buffer_kernel_1
static_map_kernel_1::deserialize

Sure. Feel free to submit a PR :)


[Ng-NgRx-SCSS] Pin all Dependency Versions

Resolves #223
This change also changes the global .gitignore as specified in the issue, "Add to starter.dev gitignore but not local gitignore". This change should work for all of the starters for npm, yarn and pnpm.

Question: There was no lock file in the starter itself because we are using yarn workspaces. I assume the requirement to remove the existing lockfile is for the lockfiles in the starters themselves and not the global one also used with the website package?


Mobile touch screen version

Hi is there a way to make this mobile please? Thanks

I believe it works with jquery-ui-touch-punch.

I believe it works with jquery-ui-touch-punch.

Yes that worked great thanks and thanks for making your code available.

Yes that worked great thanks and thanks for making your code available.


JS error reporting analytics on school_administrator_dashboard route

I'm assuming this is because currentEducator isn't set.  We could either not track visits to this page, which would be fine, or could fix the bug so that value is present for the code trying to track these analytics.  cc @edavidsonsawyer
This also isn't causing anyone any problems :)

Actually this impacts when you visit either dashboard directly too, so we definitely need to fix this up.  It probably didn't come up locally because analytics logging is disabled.  We could improve the way we do that so that we'd catch things like this locally more easily too.

Fixed by https://github.com/studentinsights/studentinsights/pull/1503


sensu plugin could do with a source param

Description of problem
When using sensu plugin type package:
'package': {
      $gem_install_options_real = $pkg_provider ? {
        'gem'   => $gem_install_options,
        default => undef,
      }

      package { $name:
        ensure          => $pkg_version,
        provider        => $pkg_provider,
        install_options => $gem_install_options_real
      }
    }

There is no source option. So when behind a proxy it fails.
In this case I am using sensu_gem provider to use the embedded ruby.
Also above if the pkg_provider is sensu_gem default becomes undef for install options. So install options do not work.
Though looking at the parent gem provider gem list operations do not use install_options but only source. So it will still be preferable to have a source option available.
It would be nice to add a pkg_source param for this so we can supply a source option.
Something like:
'package': {
      $gem_install_options_real = $pkg_provider ? {
        'gem'   => $gem_install_options,
        'sensu_gem' => $gem_isntall_options,
        default => undef,
      }

      package { $name:
        ensure          => $pkg_version,
        provider        => $pkg_provider,
        install_options => $gem_install_options_real
        source     => $pkg_source,
      }
    }

What did you do?
Tried to install plugins using the sensu_gem provider

What happened?
As part of the operation a gem list is done and if behind a proxy this fails as the only var/option available to use is "install_options" which is not used during a list operation inherited from the gem provider to the sensu_gem provider.

What did you expect to happen?

How can someone reproduce the problem?
Run behind a proxy using the sensu_gem provider

Command used and debugging output

What does your puppet config look like (including any hiera config)
Is this a masterless or master based puppet setup?

Platform and version information

Your OS: U16
Your Ruby version: Sensu Embedded ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
Your version of Puppet: 5.0.1
Your version of Sensu: 1.3.3-1
Your version of this module: 2.52.0

Anything else to add that you think will be helpful?
Or please feel free to show me if there is a better way to do this?

Will close this, looking at the 2.53.0 changelog: https://github.com/sensu/sensu-puppet/pull/878 has implemented this.


Serializer validates only first argument of include option

Hi,
I've noticed that #validate_includes! validates only first element of the include option array. The reason for this behavior is #detect method that was used in order to iterate through the array, it stops iterating after a first successful block or exception obviously.
class Movie
  attr_accessor :id, :name, :actor_ids, :actors
end

class Actor
  attr_accessor :id
end

class ActorSerializer < ApplicationSerializer
  attributes :id
end

class MovieSerializer < ApplicationSerializer
  attributes :id, :name
  has_many :actors
end

actor = Actor.new
actor.id = 1

movie = Movie.new
movie.id = 1
movie.name = 'Movie #1'
movie.actor_ids = [1]
movie.actors = [actor]

#include: %i(actors blah_blah)

irb(main):001:0> MovieSerializer.new(movie, include: %i(actors blah_blah)).serializable_hash
=> {:data=>{:id=>"1", :type=>:movie, :attributes=>{:id=>1, :name=>"Movie #1"}, :relationships=>{:actors=>{:data=>[{:id=>"1", :type=>:actor}]}}}, :included=>[{:id=>"1", :type=>:actor, :attributes=>{:id=>1}}]}

#include: %i(blah_blah actors)

irb(main):002:0> MovieSerializer.new(movie, include: %i(blah_blah actors)).serializable_hash
Traceback (most recent call last):
        2: from (irb):28
        1: from (irb):28:in `new'
ArgumentError (blah_blah is not specified as a relationship on MovieSerializer)

As you can see, only the first relation in array truly validated.
I've tried something like this in order to handle that behavior:
def validate_includes!(includes)
  return if includes.blank?
  invalid_include_items = []

  includes.each do |include_item|
    klass = self

    parse_include_item(include_item).each do |parsed_include|
      relationships_to_serialize = klass.relationships_to_serialize || {}
      relationship_to_include = relationships_to_serialize[parsed_include]
      invalid_include_items << parsed_include unless relationship_to_include
      klass = relationship_to_include.serializer.to_s.constantize unless relationship_to_include.polymorphic.is_a?(Hash)
    end
  end

  raise ArgumentError, "#{invalid_include_items} are not specified as relationships on #{klass.name}" unless invalid_include_items.blank?
end

irb(main):001:0> MovieSerializer.new(movie, include: %i(blah_blah actors weird_thing)).serializable_hash
Traceback (most recent call last):
        2: from (irb):28
        1: from (irb):28:in `new'
ArgumentError (['blah_blah', 'weird_thing'] are not specified as relationships on MovieSerializer)

All rspec tests and performance checks are passed with this solution but I'm still not sure that it will not affect overall performance in comparing to single element check as it does right now.

it stops iterating after a first successful block or exception obviously

A bit off-topic, but if there's any work planned on this one, it would be great to add a specific exception type instead of the generic ArgumentError.

@stas there is planned work on this. However i see some PRs addressing this issue. I will take a look at them see if i can merge and release a new version


Unable to download file from...

When running:

npm install gulp-sass

I get:

Can not download file from https://raw.githubusercontent.com/sass/node-sass-binaries/v2.1.1/win32-x64-node-3.3/binding.node

After that I see there is a fallback? That tries to build from source? But fails because of:

Error: Can't find Python executable "python", you can set the PYTHON env variable.

Do I need to install python in order to use this package?
Output of npm -v is 2.14.3.
My OS is Windows 8 x64.
I tried installing with iojs and nodejs, result was the same.
Full output can be found at this Gist.

I just found out more about this. This error occurs when I try to run ionic setup sass. I found out that inside package.json of this module (gulp-sass) there is a dependency called node-sass and the version used is ^2.0.1 which at the moment translates to 2.1.1, this version seems to be bugged and doesn't download the necessary libsass. If we were to change the version to ^3.0.0 it would successfully install. So basically this is not a problem with gulp-sass I believe. My bad...

I've PR'd ionic to fix their broken dependency https://github.com/driftyco/ionic/pull/4449


Fix issue #419: parallel mode was ignored with command line

Hello.
I tried 6.9.11-SNAPSHOT version withnext maven parameters:
3
tests
or with:

threadCount
13

parallel
tests

But it doesn't work.
parallel is always 'none' and threadCount is always 5.
https://groups.google.com/forum/#!topic/testng-users/kRmLWw6ts0U
What I'm doing wrong?
Thanks.

There is/was some problems with parallel when used with Surefire (have a look on surefire bug tracker).
First, you shoud be sure you use the latest Surefire version.
Then, how do you know that parallel is always 'non'?
BTW, you should try to run your tests without maven too because we are not able to know if the problem is located in TestNG or Surefire. If you think it is a TestNG issue, feel free to open a new issue.

If I remember correctly issue in surefire was fixed. We use in our project 2.19 version where it should be fixed.
About 'non':
I've printed value from getParallel() method for ITestContext (tried few of them). The same for threadCount - method getThreadCount() from ITestContext.
Without maven:
If I put parameters for parallel tests directly into xml suite - it works fine. But we need it through maven for setting parameters from CI.

Ok. So please, open a new issue


dropdown button added

I added the dropdown button
Closes #95

Good job @error707-persona
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

Star this repository. ⭐

SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.


tokio-epoll-uring: fix cfg(test) and provide again VirtualFile::read_at, used only in cfg(test)

With this PR, the tests pass on my machine.
I'm working on making the tokio-epoll-uring.git repo public so that the neon.git CI passes.
I'll rebase https://github.com/neondatabase/neon/pull/6101 onto this one.

69158a33ddcf772607e3873413b79b9db8207e6a


New function to read Power Platform env vars

See here:
https://learn.microsoft.com/en-us/power-apps/maker/data-platform/environmentvariables
Key things there:

Env vars have both display and logical name.
Env vars vars have many types (like json):

Data Type. Select from Decimal number, Text, JSON, Two options, Data source, or Secret.

Given those requirements, looking at something like introducing each variable as a strongly typed constant like this:
Environment.Variable.VarName

VarName is the display name
it's scoped to the Variable object in the Environment namespace.  The extra "Variable" layer helps avoid conflicts with other names on Environment.

We may want this to be plural ".Variables" vs singular ".Variable".  I need to check with the content team before we finalize.

fyi - methods for converting between Display and Logical names:
https://github.com/microsoft/Power-Fx/blob/c70286e724de26c535e2c44386d59340f9b8d6f6/src/libraries/Microsoft.PowerFx.Core/Public/Engine.cs#L498C23-L498C45
Persist in invariant form.
Edit in display name.


Fix Filters' discoverFilters on class redeclaration

In a new project I have defined Config => app/Config/ in my composer.json's autoload.psr-4 so that phpstan will not complain later of undiscovered symbols. However, I am getting class redeclaration error for Config\Filters, particularly on the discoverFilters method of CodeIgniter\Filters\Filters.

This is because Services::locator will locate two Config\Filters in my case, 1) as defined by Config\Autoload and 2) as defined by Composer. Now, the discoverFilters method will just check if the path to the file is not equal to APPPATH . 'Config/Filters.php. Since the Composer one is a relative route usually having the vendor in its path, it will fail the check and will be included. Since it is really identical to the main filter config, the PHP error will be thrown for same class name declared.
This PR modifies the conditional include to check the fully qualified class name of the files instead. Other changes are just aesthetic fixes.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Requesting review from @MGatner


Missing pixels

In cube3d demo, it seems that in some positions there will be missing some missing pixels in the cube's edge

This bug is caused by floating point calculation error, and should be solved after the move to fixed point math.


Return 200 OK HTTP fast

I have a rails application. The webhook callback sometimes is a bit slow to return a 200 OK HTTP response, as it has to interact with other APIs before. This makes facebook send the app duplicated requests.
How can I send back as fast as possible 200 OK HTTP message once i've received a message in Bot.on :message do |message|?
Thanks

Just run your API requests and send the reply in a queue using Active Job.


Investigating Exam Issue

We have decided to close this PR due to the fact that the issue is caused by a BCMP.