Can module blocks appear in non-module scripts?

<script>
  const module = module { export default 42; }
  import(module);
</script>

Does the above work?

Yes

Yeah, since import() is available in non-module scripts, I don’t see why module blocks should not be available.

Sounds good. Ohhh, but…
<script>
  console.log(import.meta.url);
</script>

The above throws with "SyntaxError: Cannot use 'import.meta' outside a module". But would this work?:
<script>
  const module = module { export default = import.meta.url; }
  import(module).then(console.log);
</script>

Relative imports work in classic scripts, so there isn't an issue knowing what script they're in. I'm not sure why import.meta.url throws in classic scripts.

Because classic scripts aren’t importable. import.meta.url is supposed to be the specifier you used to import the current module.

Given that, it isn't clear to me if the above example should work.

Per #26, i think it should be nullish, but it should work regardless of what its value is in the module block, because the module block is a Module, not a Script.

Yeah, we'll have to work out the import.meta.url in the HTML integration PR. There are a lot of possible answers here.

Yes, module blocks can appear in non-module scripts. import.meta is available in module blocks declared inside scripts, because module blocks are modules and import.meta is always available in modules.
The discussion about the import.meta.url value is in https://github.com/tc39/proposal-js-module-blocks/issues/26.


Monitor https://github-wiki-see.page/m/aiegoo/tmux/wiki/startify-vim as it is detected as a redirect when it should not be

https://github-wiki-see.page/m/aiegoo/tmux/wiki/startify-vim

Not decommissioned
Contentful
Yet detected as a redirect?

Will check every two days.
https://search.google.com/search-console/inspect?resource_id=sc-domain%3Agithub-wiki-see.page&id=UCy4w0VNemi8RuuiwHLGCw&hl=en

On second thought it's not really contentful. Two headers and two images. Maybe it really thinks this is a soft redirect after all. Might reopen if a better subject comes up.


Disabled test: VideoRippersTest#testVineRipper -- fix and re-enable or remove

See #21
testVineRipper(com.rarchives.ripme.tst.ripper.rippers.VideoRippersTest)  Time elapsed: 0.269 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Error while ripping https://vine.co/v/hiqQrP0eUZx : java.io.IOException: Could not find meta property 'twitter:player:stream' at https://vine.co/v/hiqQrP0eUZx
	at junit.framework.Assert.fail(Assert.java:47)
	at com.rarchives.ripme.tst.ripper.rippers.VideoRippersTest.videoTestHelper(VideoRippersTest.java:31)
	at com.rarchives.ripme.tst.ripper.rippers.VideoRippersTest.testVineRipper(VideoRippersTest.java:62)

I think the vine ripper should be removed at this point. The vine archive is broken as fall as I can tell and there's no talk of it ever getting fixed

Can we not scrape vine.co itself?

Vine.co doesn't host the videos anymore


Update to ungoogled-chromium 103.0.5060.134-1

No upates of the patches needed.
Do we want to set the is_official_build flag with this release like requested in #163?

I do. And when updating the patches I always have the flag set. There is a dedicated branch in my fork with the flag set, so enabling the flag with this PR is just a matter of changing the source branch.

@Nifury Have you also tried is_official_build on Windows?

From my experience, building and liking takes a bit more time and resources. The question is if it will work in the CI or if we run in any limitations there.

From my experience, building and liking takes a bit more time and resources. The question is if it will work in the CI or if we run in any limitations there.

Exactly!

Have any of you made a rebuild of this? There was a issue with a third party binary (see https://github.com/ungoogled-software/ungoogled-chromium/issues/2019)

Have any of you made a rebuild of this? There was a issue with a third party binary (see https://github.com/ungoogled-software/ungoogled-chromium/issues/2019)

Can you rephrase that, I don't understand your question.

So someone else publishing ungoogled-chromium binaries for windows apparently had some issues with the latest build. I want to make sure that we don't run into the same issue.
As such I asked if any of you have made a working build of this pull request yet

Of course, I always compile before creating a PR to make sure it works.

Alright perfect, thank you :)

So, was there a definitive decision on is_official_build flag for Windows?

@Nifury has a CI job with the flag set running, I think we are waiting for that to finish.

@teeminus Build failed. https://github.com/Nifury/ungoogled-chromium-windows/runs/7463225940?check_suite_focus=true#step:5:4959
I think it's because windows-fix-generate-resource-allowed-list.patch passes bytes to subprocess.Popen.
names.add(sym_name.encode('utf8'))
...
for name in names:
    undname = subprocess.Popen(['undname', name],

It's not an issue in Python 3.8 or later (Changed in version 3.8: args parameter accepts a path-like object if shell is False and a sequence containing bytes and path-like objects on Windows.), but the CI job uses Python 3.7.

Yeah, I already saw that. I think we can fix that with the next release, so we can merge this PR for now.

Sure!

https://github.com/Nifury/ungoogled-chromium-windows/actions/runs/2724307448
Builds and runs fine. Just need to remove the encode('utf-8') part.

Shall we create a -2 or do we wait for the next release?

I'm fine with either, but why not create a -2.

Do you want to create a PR for your fixed branch or shall I fix mine and create a PR afterwards?

It's probably better that you create a PR. You added a patch for is_official_build after all.

Okay, then I will create a PR tomorrow with a cleaned up branch. Otherwise there will be a lot of merge commits from that branch being added to master 😆

I was thinking about if we really want to bump the revision with the PR. It should not change the user experience so I thought we don't need a new release for that.

Maybe the official build runs negligibly faster than the dev build...
Sure we can wait for the next release if you prefer.

What do @PF4Public and @networkException think, should we bump the revision and create a new release with the release flag set or wait for the next core release?

I'd be in favor of making a release now.
If we were to wait for the next release it might not be clear that an issue was actually caused by is_official_build and not changes in upstream chromium or the patchset.


Update documentation

Bringing the dev best practices google doc into markdown files.
Ready-for-merge Checklist

[x] Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
[ ] Was this documentation approved?
[ ] Did you update the CHANGELOG.md file with a summary of this update?

Be sure to share your updates with the<EMAIL_ADDRESS>mailing list!
Testing instructions
$ cd docs/
$ hugo server -D

then what @kylebuch8 ?

I think there is still more (always) that could be added to the docs, but @kylebuch8 if you can take a look at the last two remaining comments and then maybe we can merge?


Add download icon to package links

as per the discussion here on PR https://github.com/pypa/warehouse/pull/878
I'd like to add a download icon to the project links. This code will need to be the first if statement::
{% if name|lower == "download" %}
   {% set icon = "cloud-download" %}

I have submitted pull request for this issue. Please check #885 .

Closed by #885

Thanks @umeshksingla :D


Support Envoy

To support Istio images Envoy will be a required dependency that also needs to be compatible with any given architecture.

Envoy arm64 is supported upstream, istio-envoy is being built also now and will soon be available in the raspbernetes/istio repository when it becomes a public repository.


Add Apache 2.0 as dual license?

I don't mind, but all of it is @TheDevMinerTV's code.

I mean, if you make the PR @TheButlah

Closed by #13


Turn on Network switcher in navigation

Find a way to navigate between Mainnet and Testnet docs
Example of what docusaurus already does and can be turned on when we're ready https://nymtech.net/docs/next/overview/
https://github.com/vegaprotocol/documentation/issues/116 - enable navigation

Closing as a duplicate of #116


Updated list of authors

removed nydia and svetleen from the package.json file outside of the client folder in the src folder.
(src/myapp/package.json)

Thanks! I have to get a official list of github username tomorrow in class and update for real this time.


Tag values over 255 characters long are silently truncated if uploaded

URL
https://www.openstreetmap.org/node/11829238608/history
How to reproduce the issue?
Enter a tag value longer then 255 characters, as tag value for some key and then upload the changeset.
They value of the tag will be truncated after upload.
This easily occurs when writing complex opening_hours=* with comments, as common e.g. for German physicians (after I hit the 255 char limit limit the 2nd time, I report it now). You can also look at the the German opening_hours=*-page (machine translated), if you need some more complex rule examples.
Screenshot(s) or anything else?
The user should be notified about this and the actual length of the values over the 255 character limit should be displayed in some kind to help to shorten the comments or remove some whitespaces.
Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
2.29.0
Which browsers are you seeing this problem on?
Firefox

Duplicate of #4061

@fabi003: Did you not get the warning message that the entered value is longer than 255 characters? It should look something like this:

If I pasted the opening hours into the input fields in the above picture, I got this warning (I found it out after this issue report). If I paste the opening_hours=* into the generic tag editor, what I do in most times, when adding/editing tags, I don't get any warnings.

ok, I didn't think about the raw tag editor. There should be a similar indicator also in those input fields.


Export HardMix blend mode values

Expand the blend mode enum to cover hard-mix and update both layer
and shape helpers to export the new value.

fmalita:hardmix-blendmodebundle/jsx/helpers/blendModes.jsxfmalita:hardmix-blendmodefmalita:hardmix-blendmode


Bluetooth Chatting application Python

Describe the project you want to add with tech stack
Through running this application, two bluetooth capable devices would be able to communicate and transfer messages through a socket channel.
Techstack : Python, socket library
Expected behavior

There would be a client and a server.
The client can connect to the server.
After connection, they can exchange messages.

I would like to work on this project please assign it to me


BinaryFormatter issue in net5.0

Hi,
just a quick question as I could not find anything about it so far: do you have replacement of the Binary Formatter usage on your list so far? See: https://docs.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/5.0/binaryformatter-serialization-obsolete
We use npoi in net5.0 projects and it works great but we need to add the "EnableUnsafeBinaryFormatterSerialization" flag to all the projects currently. Not sure how long this will work with later .NET versions...
Thanks!

Thank you for your report. The Ptg.cs is using BinaryFormatter for now.

https://stackoverflow.com/questions/78536/deep-cloning-objects


Lag while save files

Hi,
This package works well while editing the code, but when I save the file, it's always lag around 2 seconds, is there anyway to fix it?
Thanks!

After took a little investigation, it seems the same issue as https://github.com/SublimeLinter/SublimeLinter3/issues/267

A workaround:
I finally adopt this PR https://github.com/SublimeLinter/SublimeLinter3/pull/271
and cancel the Show Errors on Save in Tools/SublimeLinter, it works fine for me.

https://github.com/SublimeLinter/SublimeLinter3/pull/271 has been merged, thank you for your patience.
Hope this resolves this issue.


Got it to work?

Hi!
I am not sure if this does work or not. Docs mention that it is in early stage, but is it functional?
How do you authorize the client application?

Hello,
It is definitely not production ready. I've made a convenient way of authorizing for server-only communication. How are you planning on using it? I might be able to help out!

We want our customers to see if they have open invoices with us. It is pretty much an in-house development.
OAuth is a bit of a pain asking for interactive authentication in this particular case.
I see you seem to rely on refresing an access token, but I am not sure where the token is created for the first time, where the application is authorized.

I would have the same question: I am not sure where the token is created for the first time, where the application is authorized?

It's not currently developed. I will accept pull requests.

@BagheeraBear you create the token once (interactively) and then you can refresh it whenever it has expired.
In practice, what we are doing is that our application will log an URL if an interactive authorization is required. After authorizing once, you don't need to do it any more. In fact we save tokens to a file and we can even upgrade new releases of our app without having to authorize again. You need to create a token listener (HTTP endpoint) where Visma will redirect the browser after interactive auth is successful, that is how you receive the token. Then you only refresh it.
We have had our self service billing portal running since september'17 with no issues at all.
during the process we actually decided to use OAuth directly, without this library. The question is that once you implement this auth system, the rest is pretty straight forward.
However we are happy to share our code.
Here are some tests I wrote to understand the authorization process.
https://pastebin.com/K6sctAnD
Here are some tests for refreshing the token:
https://pastebin.com/TjKiuPW4

@rvalle Thank you! I am really grateful for all help I can get. I see also the rest as pretty straightforward as soon as I can get the authentication to work.

@rvalle Hi again! Do you think you could share what it looks like in the actual call to get the access token? I have the authorization code already (to a https-page). best regards! Uffe

@BagheeraBear the token you get via the HTTP callback.
I wrote something that I called the token listener to receive it.
Remember, You have to contact visma support, and request that they set up those URLs both for development and production. I kind of remember that the standard setup for development was OK, like localhost:3000 or something similar. You can just test and see where your browser redirects to after autorizing.
I can share the token listener that I have:
https://pastebin.com/tSkK96fS
Maybe you find this class useful also, it is the eAccounting module I use.
https://pastebin.com/RYZpPmY8

@rvalle Thank you very much! Visma are using localhost and https, so I'll give this a go! Again, thanks a lot

You are welcome! if you manage to download PDFs for invoices let me know... that I still have to look into...

I'm gonna call this stale :)
Heads up, there are large changes being made to this library. #9


transcription factors

Dear all,
I am having a hard time choosing between
negative regulator of basal transcription activity
(17163),
transcriptional repressor activity (16564) and its two
children:
general transcriptional repressor activity (16565) and
specific transcriptional repressor activity (16566).
Any suggestions?
Thanks, Pascale
Reported by: pgaudet
Original Ticket: "geneontology/ontology-requests/1728":https://sourceforge.net/p/geneontology/ontology-requests/1728

thanks www.movied.org


Add transfer command

Description
This PR adds a transfer command. This enhancement allows users to easily transfer tables across accounts through the CLI
Usage:
tableland transfer <tableName> <destinationAccountAddress>

Requires privateKey flag, or for for private key to be set in .tablelandrc file.
This PR completes the work for JSTC-8.

@awmuncy, when I look at this PR, I don't see any context / explanation of your thinking that went into the implementation, or what the command looks like in practice, examples, etc. I just see "no description provided".
Note you can also link this PR with the Linear issue w/ a line like...
Fixes JSTC-8

@awmuncy, when I look at this PR, I don't see any context / explanation of your thinking that went into the implementation, or what the command looks like in practice, examples, etc. I just see "no description provided".
Note you can also link this PR with the Linear issue w/ a line like... Fixes JSTC-8

Sorry, should have been in draft. The description has been updated.


[ add ] adding idrisGL (https://github.com/ECburx/Idris2GL) to Pack

Thanks!

Sorry to mention that the following libs are needed during CI.
libsdl1.2-dev
libsdl-image1.2-dev
libsdl-mixer1.2-dev
libsdl2-image-dev
libsdl2-ttf-dev
libsdl2-gfx-dev
libsdl2-mixer-dev

OK, CI dependencies are added.

Fixed some errors in the library repo. Could you re-run the checks?

Seems not to be the problem of this library now.
[ info ] The following packages built successfully:
         ...
         - idrisGL (no tests run)
         ...
[ warning ] The following packages failed to build:
            - monad-bayes(failing dependencies: free)
            - prob-fx(failing dependencies: free)
[ warning ] The following packages could not be resolved:
            - free
            - fvect
[ fatal ] 4 packages failed to build.

Seems not to be the problem of this library now.
[ info ] The following packages built successfully:
         ...
         - idrisGL (no tests run)
         ...
[ warning ] The following packages failed to build:
            - monad-bayes(failing dependencies: free)
            - prob-fx(failing dependencies: free)
[ warning ] The following packages could not be resolved:
            - free
            - fvect
[ fatal ] 4 packages failed to build.

I'll rerun CI.


How to generate the queries file?

Hey team,
Thanks a lot for developing the library.
There is one thing which is quite unclear to me - what if I would like to have a client that can run any possible query?
Currently, if I understand correctly, the codegen will only cover the queries I've provided in the queries.graphql file, is there any way to have all possible queries generated?

is there any way to have all possible queries generated?

You mean you want to have queries that are products of all possible queries in your schema? Won't it be like millions of those?

This sounds like the same as #132

Yes, this is exactly the same thing I'm looking for. I'll close this for now as a duplicate, but in general it seems like the generated API is a bit cumbersome since I cannot programmatically create a query (which would be a convenient option).


Api base url has changed

Fixes https://github.com/DavidWittman/serverless-southwest-check-in/issues/55
Url has changed from
BASE_URL = "https://api-extensions.southwest.com/v1/mobile"
to
BASE_URL = "https://mobile.southwest.com/api/extensions/v1/mobile"

Thanks @ScottBishop!


stdev/stddev typo fix

The name of the stdev function doesn't correspond to the generated name of series.
I think that the function stddevSeries should be renamed to stdevSeries but at least it is consistent. So it doesn't cause any problems when using raw JSON data.

👍


Select comment icon if content is present

Fixes #138356549

Good catch @colinta - changed it so the correct value is always assigned.


New ItemClickBehavior for ListView/GridView.ItemClick

Feature: new ItemClickBehavior type
Summary
This PR introduces a new ItemClickBerhavior type, targeting ListViewBase (so it can be used with both ListView and GridView), which allows to easily invoke a command when an item is clicking, and also to pass the clicked item directly as parameter.
This results in more compact and efficient code than using an EventTriggerBehavior + an invoke command behavior, and it allows to directly receive the clicked item as argument to the command, which would've otherwise not been possible.
Here's a usage example:
<ListView
    ItemsSource="{x:Bind ViewModel.Source}"
    IsItemClickEnabled="True">
    <interactivity:Interaction.Behaviors>
        <core:ItemClickBehavior Command="{x:Bind ViewModel.ProcessItemCommand}"/>
    </interactivity:Interaction.Behaviors>
    <ListView.ItemTemplate>
        <DataTemplate>
            <!--Template here...-->
        </DataTemplate>
    </ListView.ItemTemplate>
</ListView>

The target command will be invoked when an item is clicked and will receive the ItemClickEventArgs.ClickedItem instance directly. This is especially useful when using eg. the RelayCommand<T> type (see https://github.com/windows-toolkit/WindowsCommunityToolkit/issues/3230), as you can then also specify the target type of a clicked item and have the command wrap a model directly in the viewmodel:
public class MyViewModel : ViewModelBase
{
    public MyViewModel()
    {
        Source = ...;
        ProcessItemCommand = new RelayCommand<MyModel>(ProcessItem);
    }

    public ObservableCollection<MyModel> Source { get; }

    public ICommand ProcessItemCommand { get; }

    private void ProcessItem(MyModel model)
    {
        // Custom logic here...
    }
}

I'm surprised this wasn't here already actually! Having created this on multiple occasions for various projects, I'd find this addition welcoming.

Can anyone help with the CI? I'm not super familiar with the setup of this repo/CI, but the Microsoft.Xaml.Interactions project is building just fine for me locally (granted, I needed to locally bump the SDK to 17763 since the original SDK 10586 is so old I don't even see that as an option in the Visual Studio installer). 😅
The CI is failing with some rather weird errors that seem a bit suspicious, considering the new behavior literally is a single self-contained class only using standard types from the BCL and the various built-in UWP types.
I mean, like:

TriggerOfT.cs(13,58): error CS1069: The type name 'DependencyObject' could not be found in the namespace 'Windows.UI.Xaml'. This type has been forwarded to assembly 'Windows, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null, ContentType=WindowsRuntime' Consider adding a reference to that assembly. [C:\projects\xamlbehaviors\src\BehaviorsSDKManaged\Microsoft.Xaml.Interactivity\Microsoft.Xaml.Interactivity.csproj]

VisualStateUtilities.cs(46,68): error CS1069: The type name 'FrameworkElement' could not be found in the namespace 'Windows.UI.Xaml'. This type has been forwarded to assembly 'Windows, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null, ContentType=WindowsRuntime' Consider adding a reference to that assembly. [C:\projects\xamlbehaviors\src\BehaviorsSDKManaged\Microsoft.Xaml.Interactivity\Microsoft.Xaml.Interactivity.csproj]

VisualStateUtilities.cs(78,58): error CS1069: The type name 'FrameworkElement' could not be found in the namespace 'Windows.UI.Xaml'. This type has been forwarded to assembly 'Windows, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null, ContentType=WindowsRuntime' Consider adding a reference to that assembly. [C:\projects\xamlbehaviors\src\BehaviorsSDKManaged\Microsoft.Xaml.Interactivity\Microsoft.Xaml.Interactivity.csproj]

I'm a bit confused here 🤔

@Sergio0694 it looks like the issue is to do with the SDKs not being available and it's building with VS2019 looking at the logs from appveyor.
At the top,

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\WindowsXaml\v16.0\8.2\Microsoft.Windows.UI.Xaml.Common.targets(676,5): warning : Could not find target platform winmds for the SDK specified by [Windows, 10.0, UAP, 10.0.10240.0, 10.0.10586.0]

Then everything after that point is just errors 🤔

Hey @jamesmcroft - thanks for looking into this!
Yeah that makes perfect sense, especially because I really didn't make any breaking changes or refactorings at all in the PR.
I guess we'll just need to hear from someone from the behaviors team about how to proceed here then 😄

@mgoertz-msft what should be done here?


support /?search=  url which is used in browser address search

@guo  could you please add more description thanks

@gyanpgupta you might need to handle URLSearchParams for the search-box like below:


Change network queuing to use NetworkTasks

Continuing my obsession with classes... (thanks for the indulgence).

CI test failure is deployment flakeyness that I already have a TODO to fix.


Recipe List Header

Component RecipesListHeader renders text and search input field. On every character change of the input field the parent component index filters the recipe list by recipe title only and passes the filtered list to RecipeList. The RecipeList component has been unaltered.
Added also some internationalization support so that translating strings is easier but it is not of great importance. The relevant changes are in:

src/pages/index.jsx
src/components/RecipesListHeader.jsx

Added mobile support for the search input field. Only tested in Safari's iOS. It should:

Select current text on focus
Show button Search on the virtual keyboard instead of input
Close keyboard on Search

For these functionalities it was required to:

onFocus={e => e.target.setSelectionRange(0, e.target.value.length)}. It would've been nicer to use e.target.select(), unfortunately it doesn't work on Safari iOS.
Set type="search" and wrap the input in a <form> tag with an action attribute defined. Since we are not submitting the form we prevent the default event on submit as usual.
onKeyPress={e => e.key === 'Enter' && e.target.blur()}. Blurring the target input field hides the iOS keyboard and we only have to blur when the Search button is pressed which emits an 'Enter' key. This has the additional effect on browsers that the cursor is hidden on enter.


Ability to Manually Refresh All Podcast Subscriptions

Clear and concise description of the problem
To get the latest podcast releases, a setting can be set in the docker-compose.yml, which specifies how frequently to check for new releases. That said, I don't know why, but my podcast subscriptions don't always update and show the latest releases.
Suggested solution
Currently, when you click on a specific podcast, there is a refresh button that manually forces the system to look for new releases for that particular podcast. Would it be possible to add a refresh button on the Podcast page (ui/podcasts) to allow users to manually request Podfetch to look for new podcasts across all your subscriptions?
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Great idea. I hope to get started with your issue next week. I'm currently working on the GPodder integration which requires some manual testing. If you'd like to test the next version of PodFetch. Change the latest tag to dev.

I've transitioned to the Dev docker tag, but I'm still having issues with the refresh function of Podfetch. When I hit the Refresh All button on the Podcast page, no new podcast episodes show up, and I see the below output in the logs. I wonder if the refresh process stops once it comes to a podcast that doesn't have any new episodes, instead of updating all the subscribed podcasts.
2023-05-01T10:00:00 [INFO] - Polling for new episodes
thread '' panicked at 'called Option::unwrap() on a None value', src/db.rs:205:49
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
2023-05-01T18:08:08 [INFO] - Refreshing podcast: The Common Man Progrum
thread '' panicked at 'called Option::unwrap() on a None value', src/db.rs:205:49

Thanks for the quick work on this! I was able to update a few of the podcasts that I subscribe to, but then I ran into another issue that stopped the refresh process.
2023-05-01T19:17:31 [INFO] - Refreshing podcast: Security In Five
thread '' panicked at 'called Option::unwrap() on a None value', src/service/podcast_episode_service.rs:153:80

Thanks for the podcast name. This one has episodes that don't have a download url. Didn't encounter that yet because I thought if you host a podcast you need urls people can enter and media they can listen to.

Dev build is updated for arm

I'm not seeing errors anymore. Thanks for the help!

Awesome.


docs(examples): use only 'latest' and 'react' babel preset syntaxes

see #1746
Also add our multi-index example into our examples directory.

You :metal:


Make dependencies less restrictive

In GitLab by @arisilon on Oct 16, 2019, 13:41
Don't make the dependency versions so specific. Only specify a minimum.

In GitLab by @arisilon on Oct 16, 2019, 15:02
mentioned in commit ba5a16c6b08e56f0cb9ea07b98b51d18f0427920

In GitLab by @arisilon on Oct 16, 2019, 13:43
closed

In GitLab by @arisilon on Oct 24, 2019, 10:39
closed


Systolic value wraps on smaller screens/larger font sizes

What happened
The systolic value on the stats page wraps to two lines on a smaller screen.
On my Samsung Galaxy S22:

ideas
May also have to do with font size set on phone. If I decrease font size, it fits fine.

Rhank you for the bug report, that looks really odd.
How do you think I could fix that / can you suggest a alternate layout? Just ignoring the system settings will annoy someone else.


added link to lqe (linear quadratic estimator) function in docs

Coverage remained the same at 84.209% when pulling e2d8f9d4efe1a410c83ba8228878a4c6ccd2c86f on sawyerbfuller:master into 03183d157a5f6cd8a9918498ab8717dc7b91c9cf on python-control:master.


Move off webapp2

We use webapp2 for our web framework, but it doesn't support Python 3 so we need to replace it. The current plan is to replace it with Django.
Summary of the reasons for choosing Django: Django has a strong community and long history, so it's probably something we can count on in the long term; we're already using Django for templating; and we know of no significant reason to use anything else instead.

FTR, I just learned there's a package called webapp3, but all three of its releases were on the same day (2018-10-29), all the links on its pypi page are broken, and I couldn't even find a repo for it from the maintainer's GitHub page, so I'm sticking with Django.

webapp2 3.0.0b1 release supports Python 3: https://github.com/GoogleCloudPlatform/webapp2/releases/tag/3.0.0b1
But since webapp2 is not actively maintained anymore, it's better to go with something else. I suggest looking into Flask.
P.S.: Avoid unknown Pypi packages. Who knows what they have hidden in their source code.


Ludusavi creates backup of Documents folder called "The Lord of the Rings: The Return of the King"

Hi there, I've been checking out this plugin for a while now and I came across something that doesn't make sense.
I selected the Back up save data for all games option through Playnite and in the report the game The Lord of the Rings: The Return of the King appears with a save file of ~9.5 GB of data. When I checked what kind of files it could have stored from a game I don't own nor have installed I saw that the entire Documents folder was copied into it.

Ludusavi app shows the same.

I was wondering if I could exclude this game from being stored.
Thanks a lot.

Thanks for reporting this! There was an error in the manifest updater script. I've fixed it and updated the manifest (https://github.com/mtkennerly/ludusavi-manifest/commit/2ae7df680bde9b55002bff30b258bf806c5f2f43), so this will be resolved the next time you launch Ludusavi.


Transcluding a heading doesn't show content

Describe the bug
First off, thank you for your amazing work!
The issue I'm seeing is that when transcluding a header:
![[Scene Transformer#Marginal vs. Joint Prediction]]

I expect the content to be shown but instead it displays:
[Transclude of Scene-Transformer#marginal-vs-joint-predictionMarginal vs. Joint Prediction](http://localhost:8080/Research-Papers/Scene-Transformer#marginal-vs-joint-predictionmarginal-vs-joint-prediction)

To Reproduce
Make a transclude with reference to a specific heading.
Expected behavior
The heading should be displayed:

Screenshots
Current results:

Thank you for the quick fix!


Return on cost

Can we document or remove the dependence on orca.get_injectable("settings")["profit_vs_return_on_cost_combination_factor"] someway being set to the correct thing?

yup, I already had a story to do so @mkreilly you got me in trouble!


Upgrade curator

I talked with @gianm offline and raise this PR because he can't afford to work on #4752 right now.
The reason of the test failures is that curator-test 4.0 is not compatible with zookeeper 3.4.x. It looks to be recommended to use 2.12.0 instead (https://issues.apache.org/jira/browse/CURATOR-428).
Also, I excluded zookeeper dependency from curator-recipes to enable soft-compatibility mode (https://curator.apache.org/zk-compatibility.html).
The expected benefits are

Curator 4.0.0 contains a fix for CURATOR-394 (see also #4103).
Fixes #4056, fixes #3837.

This change is

Can you please add the benefits of a 4.0.0?
Taking on a .0 major release is a bit scary

The benefits are described in the original PR (#4752). I updated the PR description.

@jihoonson could you try merging master once again; #4787 should help with the CI failures.

@gianm thanks. Merged master.

@gianm @jihoonson sounds good to upgrade. it would be good to run this on a test cluster with some load for a day or so that any trivial issues surface immediately.

@himanshug is that something you are equipped to test?

@drcrallen I would be fine to merge it if @jihoonson has done sanity verification on some cluster with multiple machines. once merged, we can update our metrics cluster to latest master and let it run there .. see if any problems spring up.

@himanshug thanks. I'll let you know after testing on our cluster.

@himanshug this patch works well on our cluster.

I'll merge this, based on comments so far and testing from @jihoonson. If anyone notices any issues after more testing, that may be related, then please speak up.


Implements Network Publishing API

Implements the Network Publishing API defined in https://github.com/projectcontour/contour-operator/pull/151.
Requires:

https://github.com/projectcontour/contour-operator/pull/151
https://github.com/projectcontour/contour-operator/pull/162

@stevesloka @skriss I addressed your feedback in my above comments or in commit 6d1e09b.

xref: https://github.com/projectcontour/contour-operator/issues/159


Installation of external-secrets with kustomize does not populate external-secrets-webhook secret

Describe the bug
We are setting up the external-secrets using kustomize, but it is failing to start the external-secrets-webhook due to a lack of values in external-secrets-webhook secret.
This is the error logs in of external-secrets-webhook pod:
´´´
{"level":"error","ts":1688741970.212487,"logger":"setup","msg":"invalid certs. retrying...","error":"stat /tmp/certs/tls.crt: no such file or directory","stacktrace":"..."}
´´´
To Reproduce
Use a kustomization.yaml file like this:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: external-secrets
resources:
  - namespace.yaml

helmCharts:
- name: external-secrets
  releaseName: external-secrets
  repo: https://charts.external-secrets.io

namespace.yaml file:
apiVersion: v1
kind: Namespace
metadata:
  name: external-secrets

Use the following command to apply the kustomization file:
kustomize build . --enable-helm | kubectl apply -f -
It seems the it is not triggering the function to populate the values secrets values.
And the pods are in this state:
> kubectl get pods -n external-secrets
NAME                                                READY   STATUS             RESTARTS          AGE
external-secrets-66968d49b4-hgr2w                   1/1     Running            0                 35h
external-secrets-cert-controller-6db44898bd-znjh5   0/1     Running            0                 35h
external-secrets-webhook-6d5c7d847c-4nbx5           0/1     CrashLoopBackOff   202 (2m12s ago)   23h

The secret is created without data.
> kubectl get secret external-secrets-webhook -o yaml -n external-secrets
apiVersion: v1
kind: Secret
metadata:
  name: external-secrets-webhook
  namespace: external-secrets
type: Opaque

Expected behavior
The external-secrets installation works with kustomize. :D
Additional context
We have tried to install it using the helm command in the same EKS cluster and it worked correctly.

We understand that the secret is populated using a helm hook, but we could explore different implementations that do not rely on helm for a successful installation.

This secret is setup by cert controller, not a helm hook. I would investigate why cert controller is not able to populate the secret :)


It was updated with https://github.com/stellar/go/tree/release-horizon-v2.27.0 (since it's what contains the new XDR changes from https://github.com/stellar/go/pull/5079). @tamirms asked me to merge there


Left sub-nav color is too light

The color of the sub-nav text is too light. The color combined with the size makes it fail accessibility - as you can see in the screenshot.
Also, the open/close carats seem backward to me. I can't tell if the section is open or not unless I click to make sure.

Step numbers and TOC also seem too light.

Step numbers and TOC also seem too light.

Closing in favor of Sidebar navigation color and font-size #9424

Closing in favor of Sidebar navigation color and font-size #9424


[DNM] Checking content provider

Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/547

@raukadah can we close this PR?


Udp tcp over socks

In my vps server , i install softether vpn server that use tap devie with <IP_ADDRESS>/21 subnet . Traffic of this devoce go throuh gateway if eth0 ip.
With some iptables trick can forward tcp to local go simple tunnel and use tls tunnel to coonect to socks server on another vps . Beacuse of many restriction on internet in our country . But mg problem is with udp traffic . How i can forward udp this way . I was test tun2soxks but i cant got it working beacuse when change metrics with way say in exampl , i lost connection to device .  Can i do it with hev ?

Certainly. If you want to proxy UDP, you should use hev-socks5-server on server side vps. BTW, the traffic in direct access is not encrypted or obfuscated.
It should be noted that if you use the global default route, you need to bypass the socks5 server address to avoid it going through the virtual tunnel:
ip route add SOCKS5-SERVER-IP dev INTERNET-IFACE metric 10

ip route add default dev tun0 metric 20
ip -6 route add default dev tun0 metric 20

Certainly. If you want to proxy UDP, you should use hev-socks5-server on server side vps. BTW, the traffic in direct access is not encrypted or obfuscated.
It should be noted that if you use the global default route, you need to bypass the socks5 server address to avoid it going through the virtual tunnel:
ip route add SOCKS5-SERVER-IP dev INTERNET-IFACE metric 10

ip route add default dev tun0 metric 20
ip -6 route add default dev tun0 metric 20

tnx for quick answer , for tap device to use tun0 as gateway what rule must add ?
i want be like this :
tap_se  ==>  tun0  ==>  eth0
tap_se has subnet <IP_ADDRESS>/24 with netmask <IP_ADDRESS> and brodcast <IP_ADDRESS> and ip of router <IP_ADDRESS>

I need more info about your network topology.

Run hev-socks5-server directly on vpsserver, and hev-socks5-tunnel on another without softether, if encryption is not required. (or use a tcp stream wrapper to encrypt socks5 traffic between server and client. e.g. ssh port forwarding?)
vps server:
hev-socks5-server conf.yml # default config

another host:
hev-socks5-tunnel conf.yml # socks5 sever point to vpsservet

ip route add vpsserver dev eth0
ip route default dev tun0

当然。如果你想代理 UDP，你应该在服务器端 vps 上使用hev-socks5-server。顺便说一句，直接访问中的流量未加密或混淆。
需要注意的是，如果使用全局默认路由，需要绕过socks5服务器地址，避免走虚拟隧道：
ip route add SOCKS5-SERVER-IP dev INTERNET-IFACE metric 10

ip route add default dev tun0 metric 20
ip -6 route add default dev tun0 metric 20

Is there a plan to develop the original udp proxy?  If not,lay4 VPN like v2ray xray is not easy to use hev-socks5-tunnel

Is there a plan to develop the original udp proxy? If not,lay4 VPN like v2ray xray is not easy to use hev-socks5-tunnel

I'm currently too occupied to add this feature.

Is there a plan to develop the original udp proxy? If not,lay4 VPN like v2ray xray is not easy to use hev-socks5-tunnel

Adding UDP associate support is done: https://github.com/heiher/hev-socks5-tunnel/commit/f5311b06fcce4d5255d1feea52c3ba3a7de756c9
socks5:
  # Socks5 UDP relay mode (tcp|udp)
  udp: 'udp'

Please let me know if you have any other questions.

Is there a plan to develop the original udp proxy? If not,lay4 VPN like v2ray xray is not easy to use hev-socks5-tunnel

Adding UDP associate support is done: f5311b0
socks5:
  # Socks5 UDP relay mode (tcp|udp)
  udp: 'udp'

Please let me know if you have any other questions.

Have you tested this in practice? I am now almost 100% confident that that the Hev does not pass DNS UDP traffic. Compiled code from the last commit.
When I use curl -sSx socks5h://localhost:1080 https://checkip.amazonaws.com  I get the DNS query on my socks server and the proxy works fine.
When I use  curl -sS --interface tun0 --dns-interface tun0 --dns-ipv4-addr <IP_ADDRESS>  https://checkip.amazonaws.com, the DNS UDP is leaked from tun0 to the eth0 interface.
Not only is this a problem, but it also can be dangerous from a privacy point of view...

#!/bin/sh
/usr/bin/hev-socks5-tunnel /usr/bin/hevsocksconfig.yaml \
& ifconfig eth0:0 <IP_ADDRESS> netmask <IP_ADDRESS>

ip rule add pref 300 from <IP_ADDRESS>/24 table tun2socks

iptables -A FORWARD -i eth0:0 -s <IP_ADDRESS>/24 -j ACCEPT
iptables -A FORWARD -i tun0 -d <IP_ADDRESS>/24 -j ACCEPT
iptables -t nat -A POSTROUTING -s <IP_ADDRESS>/24 -o tun0 -j MASQUERADE

ip route flush table tun2socks
ip route show table main | grep -Ev ^default | while read ROUTE ; do ip route add table tun2socks $ROUTE; done
ip route add default via <IP_ADDRESS> dev tun0 table tun2socks

ip route flush cache

/usr/local/bin/xray run /usr/local/bin/config.json

Someday someone might find this script useful for NATing a local network traffic to Hev tun0 and then pass it by the tun2socks to a Xray or V2ray or V2fly client connection over socks...
(PAY ATTENTION TO THE "pref 300" AS IT IS CRITICALLY IMPORTANT)
I had limited Kernel Modules and was not able to utilize Tmark Iptables modules. So had to use a tun2socks adapter and do an old fashion typical nat.
Works fine with latest Hev build.
speedtest -I tun0

   Speedtest by Ookla

      Server: KPN - Amsterdam (id: 26996)
Idle Latency:    96.52 ms   (jitter: 1.17ms, low: 95.34ms, high: 97.32ms)
    Download:   452.90 Mbps (data used: 584.0 MB)
                290.17 ms   (jitter: 69.22ms, low: 95.39ms, high: 458.78ms)
      Upload:   378.08 Mbps (data used: 535.0 MB)
                121.87 ms   (jitter: 8.42ms, low: 102.21ms, high: 162.63ms)
 Packet Loss:     0.0%


Add tests for block version

Add unit tests for block Version

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

16 of 16 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.595%

Totals

Change from base Build<PHONE_NUMBER>6:
0.02%

Covered Lines:
19143

Relevant Lines:
23177

💛  - Coveralls

Appreciate the effort but I don't think these tests add any real value. What exactly are you thinking that theses tests prove (or what are you imagining that they test)?

These tests will test the functionality of Version::is_signalling_soft_fork. Mainly for regression testing, in case (for whatever reason) Version::is_signalling_soft_fork gets updated, it should still follow the behavior defined in BIP 9

Cool, if they are regression tests then they should be marked as such and probably live in tests/ (for examples we already have see bitcoin/tests/serde.rs or hashes/tests/regression.rs

It’s also testing the different branches of logic with different versions to make sure that it’s only returning true for versions that are signaling soft fork. Seems like they would be fine as unit tests

I agree with @shinghim. There's not much conceptual difference between a unit test or a "regression test" on a single function. These seem fine to me.

Alright, I'm with you guys. If this is unit testing functionality perhaps this makes it easier to read
    #[test]
    fn version_is_not_signalling_with_invalid_bit() {
        let arbitrary_version = Version::from_consensus(1234567890);
        // The max bit number to signal is 28.
        assert!(!Version::is_signalling_soft_fork(&arbitrary_version, 29));
    }

    #[test]
    fn version_is_signalling() {
        let version = Version::from_consensus(0b00100000000000000000000000000010);
        assert!(Version::is_signalling_soft_fork(&version, 1));
    }

    #[test]
    fn version_is_not_signalling() {
        let version = Version::from_consensus(0b00100000000000000000000000000010);
        assert!(!Version::is_signalling_soft_fork(&version, 0));
    }

    #[test]
    fn version_is_not_signalling_when_use_version_bits_not_set() {
        // Top three bits must be 010 to signal.
        let version = Version::from_consensus(0b01000000000000000000000000000010);
        assert!(!Version::is_signalling_soft_fork(&version, 1));
    }

hmm, I don't want to ack because I think the added code comments are beneficial but please BDFL over me @apoelstra and merge if you think I'm being overly pedantic.

No, go ahead and hold it up over the comments. I don't think there's any particular rush on this PR.

Added the comments 👍🏼

Thanks man!


[prometheus-operator] upgrade CRDs to 32.4

Towards: https://github.com/giantswarm/giantswarm/issues/21411
This PR:

Adds a script to sync CRDs
upgrade CRDs to 32.4

Can you ensure those work with PMO?

Can you ensure those work with PMO?

I have tested it on ginger (https://github.com/giantswarm/giantswarm/issues/21411#issuecomment-1261223115)
but also, we need to upgrade this dependency in PMO: https://github.com/giantswarm/prometheus-meta-operator/pull/1003


[fix] Allow dashboard viewer auto refresh dashboard

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[x] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

before #7248, dashboard viewers and owners can auto refresh dashboard periodically, but this refresh frequency can not be saved into dashboard metadata. In #7248, dashboard owner can change refresh frequency and save it as part of dashboard metadata, so that next time viewer open dashboard, it will auto-refresh per owner's setting. But in this PR, viewers lost their options to change refresh frequency, even they doesn't want to change owner's setting. There are some cases where dashboard owner didn't set auto refresh, but viewers still want to auto refresh during current visit.
This PR added back this feature:

dashboard viewers can trigger auto refresh for this visit, but this change won't persist.
In edit mode, if dashboard owner changes auto refresh frequency, this change will be saved into dashboard metadata.

AFTER SCREENSHOTS OR ANIMATED GIF
Dashboard viewers will see menu Auto-refresh dashboard:

In edit mode, dashboard owners will see Set auto-refresh interval:

TEST PLAN
CI, and manual test.
REVIEWERS
@betodealmeida @khtruong
@michellethomas @etr2460

Minor. Should the label be "Enable auto-refresh" instead of "Set auto-refresh interval"?
The latter made it feel you have the ability to set the interval value.

Dashboard viewers will see menu Auto-refresh dashboard:
Can they click? What does it do?
Yes.

Dashboard owners will see Set auto-refresh interval:
Does this bring up another dialog or what happen? If brings up another dialog may be add ...
Should the label be "Enable auto-refresh" instead of "Set auto-refresh interval" if it is just enable or not? The latter made it feel you have the ability to set the interval value.
Nothing extra to be enabled in edit mode. Edit mode can persist the change. Auto refreshment should be enabled for viewers and owners. But only owner has ability to save.

Thanks for fixing this, @graceguo-supercat!


Required validation for foreign key columns fails when left blank.

@howdyjessie @jrchudy
When you try creating an entity which has a foreign key and leave it blank while submitting, you get an Ermrest API error
Error 409 Conflict The request conflicts with the state of the server. Input data violates model. ERROR: null value in column "accommodation_id" violates not-null constraint DETAIL: Failing row contains (10, null, 3.24324e+17, null).

The UI validation doesn't kick in when you submit even though it is mandatory.

@RFSH I think you will need to pass the NOT NULL flag to the psuedo column for this to work correctly as well..

This issue is from before recordedit refactor was done. This pertains to the old instance of recordedit without the reference API. Closing this issue as it is a duplicate of #525.


[FLINK-12970][hive] Support writing Hive complex types

What is the purpose of the change
To support writing to Hive tables with complex data types.
Brief change log

Support writing ARRAY, MAP and STRUCT types in HiveTableOutputFormat.
Use HiveObjectConversion to convert Flink object to Hive object in HiveTableOutputFormat.
Fixed some issue with creating Hive TypeInfo for struct type.

Verifying this change
Added new unit test.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): yes
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? NA

cc @xuefuz @bowenli86 @zjuwangg

Thanks @bowenli86 for the review. Please take another look.

LGTM. Merging


fixed: HTTP security headers

Goal
Enhance security headers in file vercel.json
How to test
Tracking security header at here
Screenshots

@michaelrambeau Could you help to review it again?

Thank you the changes @chuongtrh
I wonder what is the difference between the 2 regular expressions:

/[^.]+ the one for the routing in the SPA (we want to redirect requests for any page to index.html)
/(.*?) the one you added about headers?

Could everything be combined?
Or should the rule about the headers apply to only index.html route?
Note: according to Vercel docs, the routes property is not recommended https://vercel.com/docs/project-configuration#legacy/routes but I don't know if there an other way to achieve the routing in the SPA.

Thank you @michaelrambeau

Using rewrites to achieve routing in SPA
Remove routes, it not recommended by vercel

The develop branch has been deployed, you can check the result here: https://bestofjs-git-develop-bestofjs.vercel.app/


[FEA] Initiate CICD setup

The CICD should include:

signoff check
pre-merge check
nightly build and deploy
periodical submodule sync
auto-merge from pre-release branch to dev branch

pre-merge will take more time, create another ticket to follow https://github.com/NVIDIA/spark-rapids-jni/issues/6


Update filter.component.ts

add a check for existing filters and set the query (displayed filter text) if one exists for this column, this covers instances where the filter is set by user code while maintaining existing functionality

@geneeblack thanks for your PR.


Admin user list

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

I will merge into a temporary branch and make changes


Add kifu conversion

I would like to add 棋譜変換 known as #9 in skk dictiontionary.
https://webcache.googleusercontent.com/search?q=cache:s_3rg-UB7QkJ:quruli.ivory.ne.jp/document/ddskk_14.2/skk_4.html&cd=2&hl=ja&ct=clnk&gl=jp

Thanks.


⚠ ClamAV has degraded performance

In abf84b0, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: ClamAV performance has improved in b432db6 after 5 minutes.


BadgeBLE: add description of uploading behavior

Add detail on how data is sent/received through 16 bytes value of the characteristic

Hi @kienvo
Thanks for your contribution. May I ask for a small rework?
Please keep the "format" column in the table. This is vital information for people trying to implement this.
One example is the "sizes" row, where there is an 8 element array of 16-bit values (so it is in fact 16 byte sized, that is an error in your description, also offset needs adjustment then). Offset and byte-size are useful informational additions, but they don't carry the same information as the type description in the "format" column.
Also for ease of editing I'd suggest to align the cell separators in the markdown with the separators in the header row.
The additional paragraph about splitting up that data block is good. I'd probably add a small sentence for the padding of the last 16-byte block.
Thanks!

@simon-budig Thank you for the review. I have adjusted to your suggestions. Please take a look at my new changes.


Set result_msg of TTS service

Previously, the result_msg attribute wasn't set in the local TTS service request, although the functionality is complete. This PR fixes that issue.

Looks good, but on a possibly unrelated note, I don't see the config.json needed for the tts_config at "/root/harmoni_catkin_ws/src/HARMONI/harmoni_actuators/harmoni_tts/content/config.json"
Am I missing something or is a file missing here?

@chrismbirmingham, here, the TTS model config files are downloaded using the setup_tts.sh script. I've updated the STT and TTS setup in the STT PR by including all the setup commands in the dockerfiles.


Double carriage return when using \r\n as line terminator

Describe the bug
Passing in \r\n as the line terminator when calling to_csv yields a CSV file with an extra carriage return.
To Reproduce
import awswrangler
import pandas

if __name__ == "__main__":
    bucket = "example-bucket"
    key = "example.csv"
    df = pandas.DataFrame(data={
        "reading": ["col1", "col2"],
        "timestamp": [1601379427618,<PHONE_NUMBER>625],
        "value": [1, 2],
    })

    awswrangler.s3.to_csv(df=df,
                          path=f"s3://{bucket}/{key}",
                          index=False,
                          line_terminator="\r\n")

Gives the following output:
cat -e ~/carriage-return.csv

reading,timestamp,value^M^M$
col1,1601379427618,1^M^M$
col2,1601379427625,2^M^M$

Where ^M == \r and $ == \n. Notice the extra ^M.
If I make line_terminator = \n, I get the following output:
cat -e ~/newline.csv

reading,timestamp,value$
col1,1601379427618,1$
col2,1601379427625,2$

Which is what I would expect.
I'm running this on MacOS but have also seen this when running in a lambda function on AWS.
Thank you!

Hi @mike-at-upside, thanks for reporting it. Awesome troubleshoot!
I've just fixed this issue in the commit above.
Do you mind to test it from our development branch and check if it helps in your use case?
The ideia is to publish this enhancement in the version 1.9.6 next weekend.
pip install git+https://github.com/awslabs/aws-data-wrangler.git@dev

That works, @igorborgest. Thanks!

Released in 1.9.6!


CSS missing from coverage reports?

This super weird, but using the following config:
coverageInstrument: {
      test: {
        src: '**/js/**/*.js',
        expand: true,
        cwd: '../webroot/assets',
        dest: 'webroot/assets'
      }
    },
    coverageReport: {
      test: {
        options: {
          reports: {
            html: 'reports/coverage'
          }
        }
      }
    }

from inside a build folder (where my source code is in webroot, and my gruntfile is in build, and they share a parent), the resulting html files can't seem to find their CSS.
The top level report looks fine, but when I click on the report for any given file, it's looking for build/reports/prettify.css instead of build/reports/coverage/prettify.css
Am I doing something wrong here?

I'm not sure that I understand your configuration. But this looks suspicious:  dest: 'webroot/assets'
Usually dest is a temp folder.
Please take a look into the sample.
Can you reproduce issue in it?

Yeah, sorry, what I'm having it do is create a temporary webroot inside my test directory, but I'm sure it's really confusing to read :)
I'll check this afternoon if I can reproduce

I think it has to do with the fact I'm not running from the root of the project.
When I create a subfolder inside the sample configuration, copy the gruntfile and the package.json into it, and modify the gruntfile to use the subfolder, I get one of the stylesheets referring to a nonexistant file:
file:///C:/Users/yamikuronue/Documents/GitHub/grunt-croc-qunit/example/grunt-croc-qunit-sample/subfolder/.tmp/coverageReports/src/prettify.css
The file is actually at C:\Users\yamikuronue\Documents\GitHub\grunt-croc-qunit\example\grunt-croc-qunit-sample\subfolder\.tmp\coverageReports\html\prettify.css
The page doesn't look as broken, but that's one symptom reproduced. Here's the config changes I had to make to support running from a subfolder:
connect: {
			testserver: {
				options: {
					port: 9001,
					hostname: '<IP_ADDRESS>',
					middleware: function (connect) {
						return [
							mountFolder(connect, '../src'),
							mountFolder(connect, '../tests'),
						];
					}
				}
			},
			test: {
				options: {
					port: 9002,
					hostname: '<IP_ADDRESS>',
					middleware: function (connect) {
						return [
							mountFolder(connect, '../src'),
							mountFolder(connect, '../tests'),
						];
					}
				}
			},
			testcoverage: {
				options: {
					port: 9002,
					hostname: '<IP_ADDRESS>',
					middleware: function (connect) {
						return [
							mountFolder(connect, '.tmp'),
							mountFolder(connect, '../src'),
							mountFolder(connect, '../tests'),
						]
					}
				}
			}
		},
		coverageInstrument: {
			test: {
				src: 'lib/**/*.js',
				expand: true,
				cwd: '../src',
				dest: '.tmp'
			}
		},
		coverageReport: {
        	test: {
				options: {
	        		reports: {
	        			html: '.tmp/coverageReports/html/'
	        		}
	        	}
        	}
        }
    });

Yep, modifying my gruntfile to run from the root of my project resovles the issue. So either

Running from a subfolder is not supported, or
Running from a subfolder is supported but there's a bug :)

I think putting Gruntfile.js inside a subfolder isn't correct. It should in the project root dir along with package.json.
coverageReport's reports folder and coverageInstrument's dest folder could be in any place (above or below).
So if you don't mind I'll close the issue. Feel free to reopen if you have any other thought. Thanks.


Update to CoreOS update scheme.

Fixes #194
This change sets nodes to not auto-reboot after update.
This can be modified after build by the user.

Here is already a coreos key in those yams files.


need to deal with build errors without breaking the entire view

need to deal with build errors without breaking the entire view.
I opened this PR because of this need.
A small change to deal with this lack of being able to deal with errors in a more customized way.
Please check bellow:
https://github.com/peiffer-innovations/json_dynamic_widget/pull/310

Nice - good idea to add such a callback
What do you think @jpeiffer ?

This is deployed as of now.


Nix packaging for Nomad

release.nix and Makefile.release for publishing a package for use in our Nomad exec environment at JYU. Maybe you don't want these in the public repo since they're not useful for most people, but I thought @datakurre would be interested to see them.
By the way, our Sisu integration robot is now running successfully and I'm really happy with how neat the code looks with carrot-rcc handling the boring repetitive parts :) Will definitely use this for other integrations in the future!

@MoleTrooper Thanks. So great to hear good news.
I wonder if that glib approach also works for dbus-glib and libGL here https://github.com/datakurre/carrot-rcc/blob/main/nix/pkgs/rcc/default.nix#L17 which I added earlier to check that rcc-installed Firefox works :thinking:
I also wonder, why I did not run into this linker issue myself :thinking: Was it that I had previously configured our build to use FHSUserEnv wrapped rcc, but now you found a way to make it work without FHSUserEnv (and without extra chroot inside nomad exec chroot)?

Here are the two versions: bare rcc and FHSUserEnv wrapped version https://github.com/datakurre/carrot-rcc/blob/main/nix/default.nix#L21

And yes, I'll merge this later. It's better to have it here connected to carrot-rcc, than in the "camunda-rcc"-project.

Oh, I didn't realize I wasn't using the FHS-wrapped version of rcc :sweat_smile: Probably the FHS environment would have come with libc/ldd and avoided this problem. It seems the linker was the only thing needed for our current robots, but maybe FHS would be more robust in case of new dependencies in the future.

@MoleTrooper Just remembered that FHSUserEnv prevented mounting the maintained certificate bundles from Nomad host into Nomad job so that they are available in RCC jobs (because chroot inside chroot). So your approach is the better one. Just need to accept that the worker needs and update every now and then when new libraries need to be added.

Forgot this pull request still existed, merged some stuff that didn't belong here, and accidentally erased more commits than I meant to when I tried to revert that merge so it closed the PR :upside_down_face:

Oops. I guess the changes are till somewhere to be looked into later. I still don’t know which one is better. FHSUserEnv works better with Conda packages, without better with Nomad 😅

Yeah, the changes still exist; I pushed them back to this branch after the PR got closed. I'll try reopening and see if they appear in the PR.

That worked. I'll leave this open for you to think about when you feel like it and do my future messy merges in another branch :sweat_smile:

Merged in https://github.com/datakurre/carrot-rcc/pull/30


Add Quantopian to list of Airflow users

We've been using it in production for a few months now, and we love it!
Presumably I don't need to file a JIRA issue for this one :)

Codecov Report

Merging #3331 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3331   +/-   ##
======================================
  Coverage    76.1%   76.1%
======================================
  Files         197     197
  Lines       14733   14733
======================================
  Hits        11212   11212
  Misses       3521    3521

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18b437...f6da6c1. Read the comment docs.

@Eronarn Welcome aboard. For future reference, please follow the instructions in the PR template.. for trivial documentation updates, you must prepend [AIRFLOW-XXX] to your commit. I did that for now on merge.

Ah, I read the guide but didn't realize that was a literal string,
apologies! Thanks for fixing it.
On Tue, May 8, 2018, 14:17 Sid Anand<EMAIL_ADDRESS>wrote:

@Eronarn https://github.com/Eronarn Welcome aboard. For future
reference, please follow the instructions in the PR template.. for trivial
documentation updates, you must prepend [AIRFLOW-XXX] to your commit. I
did that for now on merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-airflow/pull/3331#issuecomment-387494460,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgvc0WNwF6kNXsScHfV7Ko1lEJGUjXpks5tweEngaJpZM4T25ww
.


add Arabic language to UI

Category
This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[ ] a bug fix (Fix #...)
[ ] a new Ripper
[ ] a refactoring
[ ] a style change/fix
[x] a new feature

Description
add the Arabic Language to the UI.
Testing
Required verification:

[x] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[x ] I've verified that this change works as intended.

[x] Downloads all relevant content.
[x] Downloads content from multiple pages (as necessary or appropriate).
[x] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.

[x] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[ ] I've added a unit test to cover my change.

Looks good to me


Feature/744 add checkstyle to sbt

#744
Add the plugin - sbt checkstyle into our project

Create a new sbt command checkJavaCodeStyle, which is automatically executed after sbt compile
A HTML report will be produced if checkJavaCodeStyle runs successfully. The report lives in the root target folder
Currently, Java codes are checked based on Sun's coding conventions, and we can tailor what checks we need later on
The HTML report template is provided by the plugin itself
The version of checkstyle is updated to 8.19 in order to support checks used in Sun

Finally work out the threshold is 870, which means if checkstyle finds more than 870 errors it will fail the Travis build and send the report to S3.

Sorry @PenghaiZhang , my bad there, you now also need to return false after uploading to s3. e.g.:
sbt checkJavaStyle || (aws s3 cp ... ; false)

Sorry @PenghaiZhang , my bad there, you now also need to return false after uploading to s3. e.g.:
sbt checkJavaStyle || (aws s3 cp ... ; false)

No worries, Ian. I also realised this before lunch time.


feat: Introduce basic idlgen

A library generating IDL file in a format similar to the DFinity's Candid one.

It will be merged in via a child branch


Cannot subscribe to SSL/TLS Signal K stream with self signed certificate

When subscribing to a Signal K SSL/TLS stream with a self-signed certificate on server the connection is refused with the message:
Feb 16 11:14:18 signalk-js-sdk/Connection [_onWSError] WS error self signed certificate +23ms
Feb 16 11:14:18 signalk-js-sdk/Connection [_onWSClose] called with wsURI: wss://<IP_ADDRESS>:3443/signalk/v1/stream?subscribe=none +3ms

Can be fixed with export NODE_TLS_REJECT_UNAUTHORIZED=0 before starting Signal K server.
signalk@navmot3:~ $ cat .signalk/signalk-server
#!/bin/sh
export NODE_TLS_REJECT_UNAUTHORIZED=0
/usr/lib/node_modules/signalk-server/bin/signalk-server -c /home/signalk/.signalk $*

closed via #1122


AWS Billing partitionSpec mismatch

I'm trying to get my AWS billing report loaded in, and am running into errors like this:
validation failure list:  \ nspec.partitions.partitionSpec in body must be of type array: "object" " app=metering component=reportDataSourceWorker error=" HiveTable.metering.openshift.io "reportdatasource-metering-aws-billing" is invalid: []: Invalid value: map[string]
followed by a dump of the HiveTable that's trying to be applied. I've copied the relevant part below, with the table name redacted:
"databaseName": "metering",
		"external": true,
		"location": "s3a://my-redacted-billing-reports-bucket/cur-report/",
		"managePartitions": true,
		"partitionedBy": []interface {} {
			map[string]interface {} {
				"name": "billing_period_start",
				"type": "string"
			},
			map[string]interface {} {
				"name": "billing_period_end",
				"type": "string"
			}
		},
		"partitions": []interface {} {
			map[string]interface {} {
				"location": "s3a://my-redacted-billing-reports-bucket/cur-report/cur-report/20191001-20191101/d0abd31d-5d9b-4af1-80e9-8596bcc7b6e3/",
				"partitionSpec": map[string]interface {} {
					"end": "20191101",
					"start": "20191001"
				}
			}
		},
		"rowFormat": "\\nSERDE 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'\\nWITH SERDEPROPERTIES (\\n    \\" serialization.format \\ " = \\",

Looking through the Go source code, it seemed like partitionSpec really should be an object, not a string array. So I modified hive.crd.yaml from this...
partitions:
              type: array
              description: |
                A list of partitions that this Hive table should contain.
                Note: this is an optional field.
              items:
                type: object
                required:
                - partitionSpec
                - location
                properties:
                  partitionSpec:
                    type: array
                    description: |
                      PartitionSpec is a map containing string keys and values, where each key
                      is expected to be the name of a partition column, and the value is the
                      value of the partition column.
                  location:
                    type: string
                    description: |
                      Location specifies where the data for this partition is stored.
                      This should be a sub-directory of the "location" field.
                    minLength: 1
                    format: uri

to this...
            partitions:
              type: array
              description: |
                A list of partitions that this Hive table should contain.
                Note: this is an optional field.
              items:
                type: object
                required:
                - partitionSpec
                - location
                properties:
                  partitionSpec:
                    type: object
                    description: |
                      PartitionSpec is a map containing string keys and values, where each key
                      is expected to be the name of a partition column, and the value is the
                      value of the partition column.
                  location:
                    type: string
                    description: |
                      Location specifies where the data for this partition is stored.
                      This should be a sub-directory of the "location" field.
                    minLength: 1
                    format: uri

That allowed the HiveTable update to actually go through, but then I started getting errors like this:
time="2019-10-23T14:04:24Z" level=error msg="error syncing HiveTable reportdatasource-metering-aws-billing" app=metering component=hiveTableWorker error="failed to add partition `billing_period_start`=``, `billing_period_end`=`` location s3a://my-redacted-billing-reports-bucket/cur-report/cur-report/20191001-20191101/d0abd31d-5d9b-4af1-80e9-8596bcc7b6e3/ to Hive table \"datasource_metering_aws_billing\": hive: query failed. errmsg=Error while compiling statement: FAILED: ParseException line 1:96 cannot recognize input near '' ',' 'billing_period_end' in constant" hiveTable=reportdatasource-metering-aws-billing logID=hsAWCI9NrM namespace=metering

I couldn't reconcile this behavior with the Go code. aws_usage_hive.go seems to hard-code the names as "start" and "end":
		p := metering.HiveTablePartition{
			Location: location,
			PartitionSpec: hive.PartitionSpec{
				"start": start,
				"end":   end,
			},
		}

But db.go seems to look for keys matching the column names, which I guess are billing_period_start and billing_period_end in this case:
func FmtPartitionSpec(partitionColumns []hive.Column, partSpec hive.PartitionSpec) string {
	var partitionVals []string
	for _, col := range partitionColumns {
		val := partSpec[col.Name]
		// Quote strings
		if strings.ToLower(col.Type) == "string" {
			val = "`" + val + "`"
		}
		partitionVals = append(partitionVals, fmt.Sprintf("`%s`=%s", col.Name, val))
	}

What's going on here? It seems like there's a mismatch between the hivetable spec used by aws_usage_hive.go, the hive crd, and db.go

The CRD validation was added much later so it's entirely possible we messed that up, and we haven't had access to an AWS account with billing data in it until recently, and we've been hitting issues with that (unrelated to any of this though) so it's been problematic for us to test it recently.
The thing to know is that columns and partition columns are separate and you can't use regular columns as partition columns. So when you define the partitions, it's like defining another column, but it's a partition column, hence the usage of hive.Column in FmtPartitionSpec. But the actual partitions themselves are a separate list of locations that we can point to in s3/hdfs/etc for specific partition values. For example if start/end is 02012019 and 03012019 it might point at s3a://my-bucket/report/02012019-03012019or something.
It would be easier to debug if you could get the hive metastore and hive server logs (just the metastore and hiveserver2 container logs is fine). That said I see the issues you've pointed out as most likely candidates for some of these problems.
If I built a custom reporting-operator image would you be able to try it out to see if it resolves the issue for you? As I mentioned, our AWS billing reports are giving us issues in other ways (preventing us from even scanning the bucket for reports) due to how they were setup and I've got no real way to test this right now.

I've nearly made this work, with the following changes:
Partitionspec field names need to match the columns
On line 154 of pkg\operator\aws_usage_hive.go
Change the from this
p := metering.HiveTablePartition{
            Location: location,
            PartitionSpec: hive.PartitionSpec{
                "start": start,
                "end":   end,
            },
        }

to this:
p := metering.HiveTablePartition{
            Location: location,
            PartitionSpec: hive.PartitionSpec{
                "billing_period_start": start,
                "billing_period_end":   end,
            },
        }

HiveTable CRD needs to accept an object/map, not string array for partitionSpec
Change hive.crd.yml from this...
partitions:
              type: array
              description: |
                A list of partitions that this Hive table should contain.
                Note: this is an optional field.
              items:
                type: object
                required:
                - partitionSpec
                - location
                properties:
                  partitionSpec:
                    type: array
                    description: |
                      PartitionSpec is a map containing string keys and values, where each key
                      is expected to be the name of a partition column, and the value is the
                      value of the partition column.
                  location:
                    type: string
                    description: |
                      Location specifies where the data for this partition is stored.
                      This should be a sub-directory of the "location" field.
                    minLength: 1
                    format: uri

to this...
            partitions:
              type: array
              description: |
                A list of partitions that this Hive table should contain.
                Note: this is an optional field.
              items:
                type: object
                required:
                - partitionSpec
                - location
                properties:
                  partitionSpec:
                    type: object
                    description: |
                      PartitionSpec is a map containing string keys and values, where each key
                      is expected to be the name of a partition column, and the value is the
                      value of the partition column.
                  location:
                    type: string
                    description: |
                      Location specifies where the data for this partition is stored.
                      This should be a sub-directory of the "location" field.
                    minLength: 1
                    format: uri

Literals need to be escaped with single quotes, not backticks.
pkg\operator\reporting\db.go line 73
Change this:
val = "`" + val + "`"

to this:
val = "'" + val + "'"

LOCATION needs to be quoted
db.go line 55
From this:
locationStr = "LOCATION " + partition.Location

to this:
locationStr = "LOCATION '" + partition.Location + "'"

With all of those changes, the partition statement looks plausible. It still fails though, with this:
time="2019-10-23T17:56:05Z" level=error msg="error syncing HiveTable reportdatasource-metering-aws-billing" app=metering component=hiveTableWorker error="failed to add partition `billing_period_start`='20191001', `billing_period_end`='20191101' location s3a://my-redacted-billing-reports-bucket/cur-report/cur-report/20191001-20191101/d0abd31d-5d9b-4af1-80e9-8596bcc7b6e3/ to Hive table \"datasource_metering_aws_billing\": hive: query failed. errmsg=Error while compiling statement: FAILED: SemanticException [Error 10001]: Table not found datasource_metering_aws_billing" hiveTable=reportdatasource-metering-aws-billing

Yep these are the same changes I was looking at minus the quote changes, but those seem necessary too as we used the wrong quotes. That last one is probably caused by https://github.com/operator-framework/operator-metering/issues/993, which looks like is the other one you filed. I may try to combine these PRs and bugs to make it easier to fix.

If I built a custom reporting-operator image would you be able to try it out to see if it resolves the issue for you?

Yeah I'm happy to help test with a custom image. You'll need to get the SDK updated like I have in my private fork, that's the only change I'm running with in that image other than the ones I just mentioned.

@SapientGuardian ill make a separate PR for just that that we can get merged sooner than later since I actually need to do that for the other bug i was hitting that I mentioned.

PR #1004 is to update the SDK.

I have a reporting-operator image which contains the SDK update, datasource + query name fixes, and partitionSpec handling fixes. The image is quay.io/ecnahc515/origin-metering-reporting-operator:fix-aws-datasources1, and you can specify it in your MeteringConfig like so (plus any other modifications to the MeteringConfig you've made):
apiVersion: metering.openshift.io/v1
kind: MeteringConfig
metadata:
  name: "operator-metering"
spec:
  openshift-reporting:
    spec:
      awsBillingReportDataSource:
        enabled: true
        bucket: "your-bucket"
        prefix: "your-report-prefix"
        region: "us-east-1"

  storage:
    type: "hive"
    hive:
      type: "s3"
      s3:
        bucket: "your-stuff"
        secretName: "your-secret"
        createBucket: false

  reporting-operator:
    spec:
      config:
        aws:
          secretName: your-secret
      image:
        repository: quay.io/ecnahc515/origin-metering-reporting-operator
        tag: fix-aws-datasources1
  presto:
    spec:
      config:
        aws:
          secretName: your-secret
  hive:
    spec:
      config:
        aws:
          secretName: your-secret

I also found another environment with billing data but not for the clusters I'm using, but it should work for testing these fixes, so I'm working on verifying it myself as well now.

Oh, you'll also need to run the modified metering-ansible-operator since it has the updates to the templates. Follow https://github.com/operator-framework/operator-metering/blob/master/Documentation/manual-install.md#install-with-a-custom-metering-operator-image for how to install with a custom metering-operator image and use quay.io/ecnahc515/origin-metering-ansible-operator:fix-aws-datasources1 for the image. For example:
export METERING_OPERATOR_IMAGE_REPO=quay.io/ecnahc515/origin-metering-ansible-operator
export METERING_OPERATOR_IMAGE_TAG=fix-aws-datasources1
./hack/openshift-install.sh

Well found a panic as part of this. Making progress though.

I fired up the fix-aws-datasources1 reporting-operator image. As expected (since I made the same changes) it behaves just like mine does, getting far enough to fail on creating the partition with errmsg=Error while compiling statement: FAILED: SemanticException [Error 10001]: Table not found datasource_metering_aws_billing, .
I haven't tested your ansible image yet. Assuming it has all of the active PRs merged in (does it?), the one necessary change I have in my fork that I haven't seen a PR for is setting fsGroup in reporting-operator-deployment.yaml so the non-root user can read the projected token:
    spec:
      securityContext:
        fsGroup: 3001

Is the panic you ran into the one about dbName being empty, coinciding with errors about the metering database not existing yet already existing, at the same time? I was holding off on filing the issue for that until the other things got resolved. I'm not actually sure how to fix that one, I couldn't figure out what the real problem was. But I did figure out a workaround: Don't enable the awsBillingReportDataSource on a fresh install; wait until everything else is created, then enable it.

I used the hive cli (beeline) to manually run ALTER TABLE datasource_metering_aws_billing ADD IF NOT EXISTS PARTITION (billing_period_start='20191001', billing_period_end='20191101') LOCATION 's3a://my-redacted-billing-bucket/cur-report/cur-report/20191001-20191101/d0abd31d-5d9b-4af1-80e9-8596bcc7b6e3/'; and it worked, so I'm not sure why the reporting operator is getting "table not found". Wondering if somehow it's not in the metering database when it tries to run it?

Table not found datasource_metering_aws_billing i believe is because the datasource is named incorrectly, which is what requires the ansible operator change. That said, I don't understand why the partition being added works since I expect the table name to be off.
I did forget to build with the the fsGroup option in the ansible operator though. Just fixed that though.
The panic is that issue, yes. It's because it's checking the spec, not the status of the datasource for the database name causing a few issues.
I'm continuing to test this this week and next so I hope to have verified this myself soon. I'm also looking into how we can mock this out in some tests.

If it's a clue, while the table did exist in hive, it appeared to be empty (but did have a ton of columns).
Did you push the fsGroup change to the fix-aws-datasources1 tag on the ansible image? I just tried using that, seems like it doesn't have it.

How did you attempt to use it? Can I see your MeteringConfig? It should be updated.

Oh the table not existing issue is database schema not being properly selected when we add partitions I think.

I used the env vars, this is included in the output of ./hack/upstream-install.sh:
using $METERING_OPERATOR_IMAGE_REPO=quay.io/ecnahc515/origin-metering-ansible-operator to override metering-operator image
using $METERING_OPERATOR_IMAGE_TAG=fix-aws-datasources1 to override metering-operator image tag

Here's my MeteringConfig:
apiVersion: metering.openshift.io/v1
kind: MeteringConfig
metadata:
  name: "operator-metering"
spec:
  disableOCPFeatures: true

  reporting-operator:
    spec:
      image:
        repository: quay.io/ecnahc515/origin-metering-reporting-operator
        tag: fix-aws-datasources1
      config:
        prometheus:
          url: "http://prometheus-operator-prometheus.monitoring.svc.cluster.local:9090"
      annotations:
        eks.amazonaws.com/role-arn: arn:aws:iam::redacted:role/redacted/redacted-eks-operator-metering
  hive:
    spec:
      image:
        repository: artifactory.redacted.cloud/dsax/origin-metering-hive
        tag: web-identity-token
      annotations:
        eks.amazonaws.com/role-arn: arn:aws:iam::redacted:role/redacted/redacted-eks-operator-metering
  presto:
    spec:
      image:
        repository: artifactory.redacted.cloud/dsax/metering-presto
        tag: latest
      annotations:
        eks.amazonaws.com/role-arn: arn:aws:iam::redacted:role/redacted/redacted-eks-operator-metering
      config:
        connectors:
          s3:
            useInstanceCredentials: false
  storage:
    type: hive
    hive:
      type: "s3"
      s3:
        bucket: "redacted-hive-bucket/"
        createBucket: false
        region: "us-west-2"

  openshift-reporting:
    spec:
      awsBillingReportDataSource:
        enabled: true
        # Replace these with where your AWS billing reports are
        # stored in S3.
        bucket: "redacted-billing-bucket"
        prefix: "cur-report"
        region: "us-west-2"

With your ansible image, the reporting-operator keeps spitting out this error:
time="2019-10-25T18:54:36Z" level=error msg="error syncing ReportDataSource \"metering/aws-billing\", adding back to queue" ReportDataSource=metering/aws-billing app=metering component=reportDataSourceWorker error="could not list retrieve AWS billing report keys: WebIdentityErr: unable to read file at /var/run/secrets/eks.amazonaws.com/serviceaccount/token\ncaused by: open /var/run/secrets/eks.amazonaws.com/serviceaccount/token: permission denied" logID=ZBIpODgcXx

kubectl get deployment/reporting-operator -n metering -o yaml | grep fsGroup returns nothing.
Here's the describe of the ansible pod:
[root@cloud-toolbox operator-metering]$ kubectl describe pod/metering-operator-6d9fc7fcc8-2cwwb -n metering
Name:               metering-operator-6d9fc7fcc8-2cwwb
Namespace:          metering
Priority:           0
PriorityClassName:  <none>
Node:               ip-10-52-199-203.us-west-2.compute.internal/<IP_ADDRESS>
Start Time:         Fri, 25 Oct 2019 17:14:19 +0000
Labels:             app=metering-operator
                    pod-template-hash=6d9fc7fcc8
Annotations:        kubernetes.io/psp: eks.privileged
Status:             Running
IP:                 <IP_ADDRESS>
Controlled By:      ReplicaSet/metering-operator-6d9fc7fcc8
Containers:
  ansible:
    Container ID:  docker://923a4a30a3aa2caefc7de9d333bb4879e1d0838e6872ee3ab3e885483410f338
    Image:         quay.io/ecnahc515/origin-metering-ansible-operator:fix-aws-datasources1
    Image ID:      docker-pullable://quay.io/ecnahc515/origin-metering-ansible-operator@sha256:ddb03d9b789348ba35fa6411b73eedde9b0a474bce1b01ede584c66194b83a6e

You need to specify the fsGroup in your MeteringConfig:
  reporting-operator:
    spec:
      securityContext:
        fsGroup: 3001

I believe I've got everything working, just verifying everything and making sure some changes are still necessary. I'll post here when I republish the images.

Ok I was able to generate a report finally. I pushed the updated images just now, and I expect it should all work. I'll begin working on opening a PR today and monday and getting bugs sorted we can get this backported into the next 4.2.z release also.

Seems like we're super close. I ran into one easily fixed issue with the reporting operator:
could not list retrieve AWS billing report keys: WebIdentityErr: failed to retrieve credentials\ncaused by: MissingRegion: could not find region configuration which I solved by adding the AWS_REGION env var to the deployment spec. After that, there are no errors, and the partitioning is happening successfully, but...
While the hive table does have a bunch of columns, suggesting it did find the usage manifest, the table has no data in it and the aws-billing ReportDataSource has no times logged for import or metrics. I have about 30GB worth of csv.gz files in the billing bucket. Suggestions?


Close #1221: Add Riseup as hard

@tupaschoal why is riseup being set has hard? It's easy to delete your account. You only need to login to your account and press a button, not contact them to delete it.


Feature/exoplayer

WIP PR to prevent future massive review.

I'm sorry...  because i don't know english.....  just some know
english.....   english reading is difficult ...  so need english
translation korean language...  and i think so many time rate understand
you'r answer....   i'm sorry......
2018년 7월 3일 (화) 오전 3:55, Jared Woolston<EMAIL_ADDRESS>작성:

Merged #24 https://github.com/jwoolston/Android-Webcam/pull/24.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jwoolston/Android-Webcam/pull/24#event-1712325282,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdeyhGaE9CovMh1hllC7bhmV1zIYTQg1ks5uCmyZgaJpZM4U9olC
.


Container / Docker Image Tag Missing for v8.20.0

Describe the bug
There is no docker image in docker hub for the release v8.20.0.
https://hub.docker.com/r/zricethezav/gitleaks/tags
Build seems to have failed: https://github.com/gitleaks/gitleaks/actions/runs/11164588212
To Reproduce
docker pull zricethezav/gitleaks:v8.20.0
Expected behavior
works :D
Screenshots
Basic Info (please complete the following information):

OS: Ubuntu/Linux
Gitleaks Version: v8.20.0

cc @zricethezav

Seems to be:
  > [linux/amd64 build 4/4] RUN VERSION=$(git describe --tags --abbrev=0) && CGO_ENABLED=0 go build -o bin/gitleaks -ldflags "-X="github.com/zricethezav/gitleaks/v8/cmd.Version=${VERSION}:
0.068 go: go.mod requires go >= 1.22.0 (running go 1.21.13; GOTOOLCHAIN=local)

Ahh cool didn't take a closer look, thought restarting it would have been enought :D
Opened up pr #1551 to bump the golang version which should solve this :)


Use warning log level when file cannot be loaded.

Currently the error log level is used when a file cannot be loaded. Not finding a file is a very common scenario in our apps. It would be better to use, say warning as the log level for logging the message that states that a file cannot be loaded.

Fixed in #35

v1.0.1 released: https://github.com/IBM-Swift/Configuration/releases/tag/1.0.1


Add pass-through support for exists and ptr entries.

My company includes a domain that makes use of the exists and ptr mechanisms. Current behavior is to silently skip those entries. This patch keeps those entries intact.
Additionally, the behavior of simplify.sh has been changed to print ip4 and ip6 entries before everything else. Logically, I think we would want a mailserver to test forip6 matches before any tests that could trigger another DNS query.

Thanks Evan! 👍

I'll just fix the codeship integration after I get home and will merge it.

Keep in mind that someone can rely on the fact that are only ip4/ip6 entries. For that reason there should be a note on the RELEASE NOTES for the next version.

@jcbf fair enough. @epf would it make sense to use this new functionality only when a special parameter is passed?

I think it could be as is by default, since it is the corrected behaviour.
Just provide a warn.

I didn't see this patch until now... this breaks my postwhite script, because it's not expecting the ptr: or exists:.
If we're not going to require a flag to enable it, would you consider a flag to disable it and return to the original behavior? Thanks! :)


feat: support __getitem__ with slices for columns

I kinda wish we didn't have to go overboard with __getitem__ overloads, but scikit-learn are using this, so I think we should
My general thinking on this is: make sure that Narwhals is easily usable by scikit-learn. Then, it's their decision whether or not they adopt - but we should at least be ready

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #
Closes #

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.

good points, thanks! I think this is easier to explain with examples


workbench.action.quit Command Title == "E&&xit" in the Keyboard Shortcuts editor

Does this issue occur when all extensions are disabled?: Yes/No

Looks like it is only in the Insiders Build:
E&&xit
workbench.action.quit

Version: 1.94.0-insider
Commit: e34ecab75b0c379c17921f759a77eebaf24bebf2
Date: 2024-09-16T05:03:40.122Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.94.0-insider Chrome/124.0.6367.243 Electron/30.4.0 Safari/537.36
See https://github.com/microsoft/vscode/blob/c4efe1dc9eec4914f3076b2d954fe4fe174a5820/src/vs/workbench/electron-sandbox/desktop.contribution.ts#L121
Should be : "&&Exit" on line 121.

Why should this change and how would this only be a problem in insiders?

info-needed?
Good to see this got reverted in https://github.com/microsoft/vscode/pull/228922.

Oh sorry, I now fully get it! Yes, fixed.


Switch local KinD clusters to Structured Authorization

This allows us to drop the workaround in the hack/kind-up.sh that used to patch the kubeadm-config ConfigMap and rollout the pods.
How to categorize this PR?

/area dev-productivity
/kind enhancement
What this PR does / why we need it:
https://github.com/gardener/gardener/pull/9155 had to introduce a workaround for configuring the seed authorizer in the local KinD setup. The new Structured Authorization feature of Kubernetes allows us to get rid of it again, hence clean up some technical debts. 🧹
This speeds up the KinD cluster creation because we no longer need to rollout the nodes.
Which issue(s) this PR fixes:
Follow-up of https://github.com/gardener/gardener/pull/9155 and https://github.com/gardener/gardener/pull/10723
Special notes for your reviewer:
FYI @acumino @ialidzhikov
Release note:

NONE

/lgtm

/lgtm
/approve


How to add dependency to total apk?

Hello!
I have a project with dependencies (libraryDependencies).
I do
sbt clean android:package
Now, I have apk but it doesn't contains my libraries.
How can I specify that I need classes from the some library in my total apk ?
Thanks!

All libraries are included in the final apk unless configured in a non default scope. Closing unless further details provided

@pfn, I have project as a dependency.
 App running failed, because class loader can't find classes (which defined in project apiProject).
My build.sbt
import android.Keys._
import android.Dependencies.{LibraryDependency, aar}
import android.PlainSigningConfig

android.Plugin.androidBuild

platformTarget in Android := "android-22"

name := "{some-app-name}"
versionCode := Some(0)
versionName := Some("0.0.1")

scalaVersion := "2.11.6"

run <<= run in Android

resolvers ++= Seq(
  Resolver.sonatypeRepo("releases"),
  "jcenter" at "http://jcenter.bintray.com"
)

scalacOptions in (Compile, compile) ++=
  (dependencyClasspath in Compile).value.files.map("-P:wartremover:cp:" + _.toURI.toURL)

scalacOptions in (Compile, compile) ++= Seq(
  "-P:wartremover:traverser:macroid.warts.CheckUi"
)

javacOptions ++= Seq("-source", "1.7", "-target", "1.7")
scalacOptions ++= Seq("-feature", "-deprecation", "-target:jvm-1.7")

libraryDependencies ++= Seq(
  aar("org.macroid" %% "macroid" % "2.0.0-M4"),
  aar("org.macroid" %% "macroid-viewable" % "2.0.0-M4"),
  aar("com.android.support" % "support-v4" % "21.0.3"),
  compilerPlugin("org.brianmckenna" %% "wartremover" % "0.10")
)

proguardScala in Android := true

proguardOptions in Android ++= Seq(
  "-ignorewarnings",
  "-keep class scala.Dynamic"
)

apkbuildExcludes in Android += "META-INF/LICENSE.txt"
apkbuildExcludes in Android += "META-INF/NOTICE.txt"

Set exportJars := true  in the library. This is documented in the readme.


[Bug]: invokeMethodAsyncSequentially hangs when called from within a service

Description
When invokeMethodAsyncSequentially() is called within a native method which is invoked by a service resource function, the operation does not complete.
This only happens if the client is initialized outside of the resource function.
Steps to Reproduce
Example code can be found at: https://github.com/kaneeldias/invoke-test
import ballerina/io;
import ballerina/jballerina.java;
import ballerina/http;

public client class TestClient {

    isolated function callBMethod() returns string = @java:Method {
        'class: "io.ballerina.stdlib.test_project.Utils",
        name: "callBMethod"
    } external;

    isolated function getString() returns string {
        io:println("Inside Ballerina getString method");
        return "Hello";
    }
}

TestClient testClient = new;

service / on new http:Listener(8080) {
    resource function get callBMethod() returns error? {
        io:println("Inside Ballerina service resource method");
        string result = testClient.callBMethod();
        io:println(result);
    }
}

Java native method
    public static BString callBMethod(Environment env, BObject client) {
        System.out.println("Inside native callBMethod method");

        BFuture future = env.getRuntime().invokeMethodAsyncSequentially(
            client, "getString", null, null, null, null, PredefinedTypes.TYPE_STRING
        );

        return (BString) getFutureResult(future);
    }

When the above code is run, and we GET localhost:8080/callBMethod, the following output is seen and the program hangs.
Inside Ballerina service resource method
Inside native callBMethod method

In the above case, the Ballerina method TestClient.callBMethod() and the Java native method callBMethod() is invoked, but the Ballerina method TestClient.getString() is not invoked.
Affected Version(s)
Update 5 RC1
OS, DB, other environment details and versions
No response
Related area
-> Runtime
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

It seems async api is called incorrectly. You need to pass a callback to  invokeMethodAsyncSequentially  and during notify success we need to set the future value.
Please refer https://ballerina.io/learn/java-interoperability-guide/ballerina-ffi/#call-methods-asynchronously to how to handle asynchronous call.

Closing issue as the issue does not persist when the recommended usage of the API is used