Support ServiceInternalTrafficPolicy

Please provide a description of this PR:
Fixes https://github.com/istio/istio/issues/42377
NOTE: This PR does not take ProxyTerminatingEndpoints into account

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
265757005cab05778f2cc094a07fc88b1d9f76a8
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
265757005cab05778f2cc094a07fc88b1d9f76a8
link
true
/test unit-tests-arm64

unit-tests_istio
265757005cab05778f2cc094a07fc88b1d9f76a8
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
e77534c62b7018c6638af47cc5aabfd01dcc5804
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

NOTE: This PR does not take ProxyTerminatingEndpoints into account

FWIW after looking at it more I think that feature is orthogonal

FWIW after looking at it more I think that feature is orthogonal

Yeah I think it also applies to internalTrafficPolicy: Cluster. It's a bit confusing that the user-facing change says:

When enabled, kube-proxy will attempt to route traffic to terminating pods when the traffic policy is Local and there are only terminating pods remaining on a node.

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test release-notes

unit-tests-arm64_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test release-notes

unit-tests-arm64_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test unit-tests-arm64

unit-tests_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test release-notes

unit-tests-arm64_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test unit-tests-arm64

unit-tests_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test unit-tests

gencheck_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test unit-tests

gencheck_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test gencheck

unit-tests-arm64_istio
d984c337b25e9e6366578a03b6ee5e16b64cc4d8
link
true
/test unit-tests-arm64

release-notes_istio
d984c337b25e9e6366578a03b6ee5e16b64cc4d8
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
5af030ab53611107323705ddef9f1eb697779caf
link
true
/test gencheck

unit-tests-arm64_istio
d984c337b25e9e6366578a03b6ee5e16b64cc4d8
link
true
/test unit-tests-arm64

release-notes_istio
d984c337b25e9e6366578a03b6ee5e16b64cc4d8
link
true
/test release-notes

unit-tests_istio
d984c337b25e9e6366578a03b6ee5e16b64cc4d8
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
d984c337b25e9e6366578a03b6ee5e16b64cc4d8
link
true
/test unit-tests-arm64

release-notes_istio
d984c337b25e9e6366578a03b6ee5e16b64cc4d8
link
true
/test release-notes

unit-tests_istio
d984c337b25e9e6366578a03b6ee5e16b64cc4d8
link
true
/test unit-tests

gencheck_istio
d984c337b25e9e6366578a03b6ee5e16b64cc4d8
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/42551/gencheck_istio/1610947968523833344 I don't know why those generated yamls have no ISTIO_META_NODE_NAME, is that expected? Am I missing something? I'm not very familiar with updating charts, could you please give some hints?

you can just run git apply <(curl -sL "https://gcsweb.istio.io/gcs/istio-prow/pr-logs/pull/istio_istio/42551/gencheck_istio/1610947968523833344/artifacts/check-clean-repo-diff.patch")
But those files are not actually based on manifests/ but a snapshot of them to avoid excessive churn,

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
0b4e3974e07225ac513b081a5885c41d7a1a5949
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Get it, thanks!
The release-notes test failed because gh pr view --json files cannot find the release note I added, see https://github.com/cli/cli/issues/5368
Maybe add a release-notes-none label for this pr? Or fix it in test-infra


Use app identifier for shipping webhooks

Use app.identifier is set instead of app.id for shipping webhooks.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Was tested locally by @korycins


chore(main): release 2.0.5

:robot: I have created a release beep boop
2.0.5 (2024-11-29)
Dependencies

update dependencies (#126) (9fc51c7)
Update eslint-config-plus-prettier (#124) (75e7696)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/aimeerivers/watchthis-user-service/releases/tag/v2.0.5 :sunflower:


Excessive # of identical JSON RPC requests being made during screen render

Problem
When loading the UI and switching pages, an excessive number of completely identical/redundant RPC requests are being made.
For example, loading the Account page results in 15 identical requests with payload shape:

on my mainnet account
17 identical requests with payload shape:

are made on my testnet account
When sorting the requests by payload size (like sizes are the result of identical requests being made with identical responses returned), check out the waterfall for page load:

Expected Behavior
Ideally the app would only load a logical piece of data once during page initialization/screen loads, rather than fetching the same data multiple times.  Although the account detail page is the worst offender, there are duplicate requests being made for a couple of other JSONRPC calls also (4x calls to query access keys for my account, and 5x queries for EXPERIMENTAL_protocol_config) for the same logical data.
Steps to reproduce

Open wallet with an account linked
Open network devtools panel and record network traffic
Switch to 'Account' screen
Observe redundant and excessive network requests being made

If this is just the result of a lot of different components requesting the same logical data in series, then it might be a good solution to implement data loader to handle coalescing/caching (https://github.com/graphql/dataloader)


Color, Font Size, and CSS Related Customization Option

There is no option to change Color, Font Size, Font Family, and other CSS Related Styles.
Chart JS and other Similar Plugin has those Options.
Can you add those options on this plugin?

Yeah, options to config chart is on my plan, should be finished in 1-2 weeks

I clearly need to figure out how to control the colors.
What's curious is that I don't specify any colors yet the axis becomes white.

@peterbe I use d3-axis to draw the axis, it automatically changes color when background color changes I think. I will try to find time in the weekend to add options to update color and font.
What I can think of for now is the following options, suggestions?
dataColors,
axisColor,
fontColor,
fontFamily,
titleSize,
labelSize,

I would love a default color too. Then, for example, fontColor would be var fontColor = options.fontColor || options.defaulltColor || 'black'

dataColors and fontFamily options are added in v1.1

While implementing axis and fontColors I think it might be better to implement a dark mode for chart.xkcd to make it easier to use.
Further discussions about dark mode - https://github.com/timqian/chart.xkcd/issues/21


Multi OpenStack region support in Atlas (TF)

I'm going to close this issue since it's not a gap in this project -- more of a blocking issue for migrating to Terraform.
Jeff Lindsey is working to add this capability to Terraform.


DOC: Documentation note update for truncnorm

Reference issue
Closes #16914
What does this implement/fix?
The documentation note for the truncnorm distribution is more clear.

Thanks @charlie0389! If you'd be willing to do this for the other truncated distributions, I'd be happy to review.


extending afalg with aes-cbc-192/256, afalgtest.c also updated accord…

HI
Please consider the new pull request which considers the latest comments from matt and stephen.
The changes are for extending afalg support for aes cbc key sizes 192 and 256 bits.
The tests also have been added which encrypt and match the encrypted bytes with known good values. Also the tests decrypt and match  the decrypted bytes with the original plain text.
The known good encrypted bytes have been taken as the following (without afalg engine):
jlulla@ubuntu:~/openssl-master2/apps$ od --format=x1 /home/jlulla/plain
0000000 53 69 6e 67 6c 65 20 62 6c 6f 63 6b 20 6d 73 67
0000020 0a
jlulla@ubuntu:~/openssl-master2/apps$ ./openssl enc -aes128 -in /home/jlulla/plain -out /home/jlulla/encrypted1  -K 06a9214036b8a15b512e03d534120006 -iv 3dafba429d9eb430b422da802c9fac41
jlulla@ubuntu:~/openssl-master2/apps$ od --format=x1 /home/jlulla/encrypted1
0000000 e3 53 77 9c 10 79 ae b8 27 08 94 2d be 77 18 1a
0000020 2d 34 aa 3e 5a 6f 8d 05 69 ef 36 5d 48 27 a9 bb
jlulla@ubuntu:~/openssl-master2/apps$ ./openssl enc -aes192 -in /home/jlulla/plain -out /home/jlulla/encrypted1  -K 06a9214036b8a15b512e03d53412000606a9214036b8a15b -iv 3dafba429d9eb430b422da802c9fac41
jlulla@ubuntu:~/openssl-master2/apps$ od --format=x1 /home/jlulla/encrypted1
0000000 f7 e4 26 d1 d5 4f 8f 39 b1 9e e0 df 61 b9 c2 55
0000020 eb 7d 5a a2 1a 66 1e da 99 e9 14 2c 6c 23 e7 7c
jlulla@ubuntu:~/openssl-master2/apps$ ./openssl enc -aes256 -in /home/jlulla/plain -out /home/jlulla/encrypted1  -K 06a9214036b8a15b512e03d53412000606a9214036b8a15b512e03d534120006 -iv 3dafba429d9eb430b422da802c9fac41
jlulla@ubuntu:~/openssl-master2/apps$ od --format=x1 /home/jlulla/encrypted1
0000000 a0 76 85 fd c1 65 71 9d c7 e9 13 6e ae 55 49 b4
0000020 13 aa 1d a7 39 f3 df c3 40 66 d0 7b dd d5 30 d5
Please review the changes.
Thanks
Jitendra
Previous pull requests:
https://github.com/openssl/openssl/pull/4448
https://github.com/openssl/openssl/pull/4465
https://github.com/openssl/openssl/pull/4482
https://github.com/openssl/openssl/pull/4484
https://github.com/openssl/openssl/pull/4567
Checklist

[ ] documentation is added or updated
[x] tests are added or updated

Thanks Matt for approving it.
I have fixed the indentation and have removed printf from afalgtest.c.
HI
Please consider the pull request.
The changes are for extending afalg support for aes cbc key sizes 192 and 256 bits.
The tests also have been added which encrypt and match the encrypted bytes with known good values. Also the tests decrypt and match the decrypted bytes with the original plain text.
Thanks
Jitendra

Darn, I was about to merge this but I'm getting some compile errors when I use the "--strict-warnings" Configure flag (why didn't travis pick this up?). Anyway looks like this needs to be fixed:
gcc  -Iinclude -DDSO_DLFCN -DHAVE_DLFCN_H -DOPENSSL_THREADS -DOPENSSL_NO_STATIC_ENGINE -DOPENSSL_PIC -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DRC4_ASM -DMD5_ASM -DAES_ASM -DVPAES_ASM -DBSAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -DPADLOCK_ASM -DPOLY1305_ASM -DOPENSSLDIR="\"/usr/local/ssl\"" -DENGINESDIR="\"/usr/local/lib/engines-1.1\"" -Wall -O0 -g -pthread -m64 -DL_ENDIAN  -DDEBUG_UNUSED -DPEDANTIC -pedantic -Wno-long-long -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wswitch -Wsign-compare -Wmissing-prototypes -Wshadow -Wformat -Wtype-limits -Wundef -Werror -Wmisleading-indentation -Wa,--noexecstack -fPIC -DOPENSSL_USE_NODELETE -MMD -MF engines/e_afalg.d.tmp -MT engines/e_afalg.o -c -o engines/e_afalg.o engines/e_afalg.c
engines/e_afalg.c:646:14: error: no previous prototype for 'get_cipher_handle' [-Werror=missing-prototypes]
 cbc_handles *get_cipher_handle(int nid)
              ^~~~~~~~~~~~~~~~~
engines/e_afalg.c: In function 'free_cbc':
engines/e_afalg.c:849:18: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
     for(i = 0; i < OSSL_NELEM(afalg_cipher_nids); i++) {
                  ^
cc1: all warnings being treated as errors
Makefile:6378: recipe for target 'engines/e_afalg.o' failed
make[1]: *** [engines/e_afalg.o] Error 1
make[1]: Leaving directory '/home/matt/dev/openssl-write'
Makefile:139: recipe for target 'all' failed
make: *** [all] Error 2

Sorry for the trouble but I could not catch it on my system.
I will fix this shortly.

On Tue, 11/14/17, mattcaswell<EMAIL_ADDRESS>wrote:
Subject: Re: [openssl/openssl] extending afalg with aes-cbc-192/256, afalgtest.c also updated accord… (#4717)
To: "openssl/openssl"<EMAIL_ADDRESS>Cc: "Jitendra Lulla"<EMAIL_ADDRESS>"Author"<EMAIL_ADDRESS>Date: Tuesday, November 14, 2017, 10:15 AM
Darn, I was about to
merge this but I'm getting some compile errors when I
use the "--strict-warnings" Configure flag (why
didn't travis pick this up?). Anyway looks like this
needs to be fixed:
gcc  -Iinclude -DDSO_DLFCN -DHAVE_DLFCN_H
-DOPENSSL_THREADS -DOPENSSL_NO_STATIC_ENGINE -DOPENSSL_PIC
-DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT
-DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM
-DSHA256_ASM -DSHA512_ASM -DRC4_ASM -DMD5_ASM -DAES_ASM
-DVPAES_ASM -DBSAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM
-DPADLOCK_ASM -DPOLY1305_ASM
-DOPENSSLDIR=""/usr/local/ssl""
-DENGINESDIR=""/usr/local/lib/engines-1.1""
-Wall -O0 -g -pthread -m64 -DL_ENDIAN  -DDEBUG_UNUSED
-DPEDANTIC -pedantic -Wno-long-long -Wall -Wextra
-Wno-unused-parameter -Wno-missing-field-initializers
-Wswitch -Wsign-compare -Wmissing-prototypes -Wshadow
-Wformat -Wtype-limits -Wundef -Werror
-Wmisleading-indentation -Wa,--noexecstack -fPIC
-DOPENSSL_USE_NODELETE -MMD -MF engines/e_afalg.d.tmp -MT
engines/e_afalg.o -c -o engines/e_afalg.o engines/e_afalg.c
engines/e_afalg.c:646:14: error: no previous prototype for
'get_cipher_handle' [-Werror=missing-prototypes]
cbc_handles *get_cipher_handle(int nid)
^~~~~~~~~~~~~~~~~
engines/e_afalg.c: In function 'free_cbc':
engines/e_afalg.c:849:18: error: comparison between signed
and unsigned integer expressions [-Werror=sign-compare]
for(i = 0; i < OSSL_NELEM(afalg_cipher_nids); i++) {
^
cc1: all warnings being treated as errors
Makefile:6378: recipe for target 'engines/e_afalg.o'
failed
make[1]: *** [engines/e_afalg.o] Error 1
make[1]: Leaving directory
'/home/matt/dev/openssl-write'
Makefile:139: recipe for target 'all' failed
make: *** [all] Error 2
—
You are receiving this because you authored the
thread.
Reply to this
email directly, view
it on GitHub, or mute
the thread.

I think the error message around the get_cipher_handle problem is a bit misleading. Actually I think the problem is that it needs to be declared "static".

Hi,
I have fixed the warnings coming when --strict-warnings was supplied to configure script.
Thanks
Jitendra

As correctly suggested by Matt,  get_cipher_handle should be static. Making this change.

Added the missing static.

Hi Pauli,
Could you please review and approve?
Thanks
Jitendra

Ping @paulidale

Ping @paulidale

Pushed. Thanks.


docs/guide-ja/structure-assets.md updated [ci skip]

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
--

Fixed issues
--

Merged. Thank you!


Frontmatter support for JSON / TOML format

Description
This makes it easier to migrate to Lume from other SSG. (e.g. Zola)
Check List

[x] Have you read the
CODE OF CONDUCT
[x] Have you read the document
CONTRIBUTING

[x] One pull request per feature. If you want to do more than one thing,
send multiple pull request.
[x] Write tests.
[x] Run deno fmt to fix the code format before commit.
[x] Document any change in the CHANGELOG.md.

It looks like other formats of frontmatter conflict with deno fmt, I added fmt.exclude to deno.json to skip the check.

Thank you!


Added eurekaConsulAdapter.preferHostName option so that hostName will…

… be used in service endpoint address and serviceAddress fields instead of IP

@lwitkowski thanks for your contribution. Sorry, i didnt merge sooner.

Awesome, thanks for merging!

I created a new release 1.2.0 with your changes.


Execute DefaultValidator first

Maybe I don't understant DefaultValidator logic correctly, but from my point of view I would like default values to be set before execution of any other validatiors, so they could validate those values.
For example, I can have some required attribute. And want to set a default value there. The only way to archive this is to use beforeValidate() always, because for some reason RequiredValidator will start before the DefaultValidator means validation will fail.
Currently I'm fixing this in my project with help of custom AR class with the following code:
    /**
     * @inheritdoc
     */
    public function getActiveValidators($attribute = null)
    {
        $result = [];
        $validators = parent::getActiveValidators($attribute);
        foreach ($validators as $validator) {
            if ($validator instanceof DefaultValueValidator) {
                array_unshift($result, $validator);
            } else {
                array_push($result, $validator);
            }
        }

        return $result;
    }

However, I would like to have this in the framework.

Have you tried define DefaultValidator before RequiredValidator?

@miraage, no I didn't.
Hovewer, if it works, I see that it's very risky to change that - a lot of developers could use the fact that validators are running in order they are declared.
Maybe it will be a good idea to at least add a note to documentation mentioning this fact?

As for me - it is pretty obvious, that validators are executed in order they are defined.

We won't change it. Validators are running in the order they're specified. Changing it would be confusing. Default validator should be placed before others by developer.


New link for the model weights

The previous link didn't work, So I wrote to the author and she sent me a working link for vocaset.pth and biwi.pth
https://wormhole.app/8Lr4b#tS8QVcPTSSMt2NH1LogSGA

Oops, it is expired.

Hi @TamirCohen, mind to share the models with me? I tried to contact the author by email, but it is returned by the server.

For now I uploaded it to my Google drive.
https://drive.google.com/drive/folders/1C2GBWKupKE7waI0yTLUcU4Bx_99gFPQT

thank you so much😁@TamirCohen

thank you!!!!!!!!

非常感谢您的劳动成果。想问一下，就是BIWI的数据集已经失效了，有保存好的数据集吗


Add support for configurable location of time axis ticks

This commit adds support for configurable location of time axis ticks. Currently, the ticks can only be displayed above the time labels in the time axis, which do not make sense UI-wise when we have graphs that are displayed under the time axis. This commit allows the ticks of the time axis to be displayed dynamically either on top or under the time labels by adding a configuration parameter to the TimeGraphAxisScale component, so that developers can position the ticks correctly.
Resolve Issue 203 of the Theia Trace Extension. This also relates to Issue 755 of the Theia Trace Extension.

@hoangphamEclipse is this PR ready for review? I'm asking because it's marked as draft.

@bhufmann Yes it is ready for review. Sorry I forget to revert it back to Ready for review.


Identical statements in if and else if.

https://github.com/baldurk/renderdoc/blob/aa5538b2e92a266b9126c75f085abdc508597c10/renderdoc/driver/d3d11/d3d11_device_wrap.cpp#L1740
Not completely sure what may have been meant but we have two identical statements in the if and else if.
Possible D3D_PRIMITIVE_TOPOLOGY_POINTLIST was meant for the first if statement?
D3D_PRIMITIVE_TOPOLOGY_POINTLIST	= 1,
D3D_PRIMITIVE_TOPOLOGY_LINELIST	= 2,
D3D_PRIMITIVE_TOPOLOGY_LINESTRIP	= 3,

Line 1820 there is an identical issue.

Thank you for the static analysis or compiler warning report.
In this case it does like a real code mistake however there hasn't been a user report of a bug associated with it and ideally project change is driven by user bug reports. In this case would need a geometry shader that generates points to expose the problem.

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.


4-Gridded_Datasets example does not display

When running holoviews/examples/getting_started/4-Gridded_Datasets.ipynb all plots are rendered correctly except for ds.to(hv.Image...:

Which version of HoloViews are you using? This appears to be very old. We also need some more detail on whether this is in classic notebook or JupyterLab and if the latter if you have the JupyterLab extension installed.

OK I had installed the jupyterlab extension but not restarted my jupyter server. On restart the plot is rendered correctly, sorry for the mistake!


For the Wrong Key also gets Success 200 - Android

I have followed the instruction of installing the library. and in App.js i have added the following.
`  try {
await initializeSslPinning({
'google.com': {
includeSubdomains: true,
publicKeyHashes: [
'AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=',
'BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB=',
],
},
})
.then((response) => {
console.log('THIS CALLED (1) ', response);
})
.catch((e) => {
console.log('ERROR ####', e);
});
} catch (error) {
console.log('ERROR ****', error);
}
// ...
// This request should fail with an error
try {
const response = await fetch('https://google.com');
console.log('RESPOSNSE (1) ----->  ', response.status);
} catch (error) {
console.log('ERROR ', error);
}`
This always returns 200.
"react-native": "0.63.2",
"react-native-ssl-public-key-pinning": "^1.0.6",

Also, try change this line
const response = await fetch('google.com');

to this line
const response = await fetch('https://google.com');

@frw The example I downloaded it works fine. i cannot understand why it does not work in my app. could it be because of the react-native version?

@chathuralakmal try running without debug you will get the correct response i think because i was also getting same issue but i disabled the debug and run then i am getting proper response

@abhishekrup @frw I Just found out it works fine in iOS. I believe may be its because it's using TrustKit. will try out trust kit android.

Closing since the issue seems to be with an older RN version and workarounds have been provided.
Let me know if you're still facing any issues!


The Firebase message subscription is done with a hack right now

https://stackoverflow.com/questions/62253691/firebasemessaging-getinstancefirebaseapp-for-secondary-app-supposed-to-be-publ
The constructor which referenced by the documents is not public in real life. Right now I'm using Java reflection to access it and set it to public in the name of "sudo make me a sandwitch!". But it'd be better to have a more legitimate solution.
This is all due to the fact that we are operating everything on secondary databases, which is not the usual way. We use secondary databases because each app user brings their own database and configures it, so I as the author don't have to store any highly sensitive data.

The hack went in with this commit: https://github.com/DIYGPSTracker/DIYGPSManager/commit/270f9c099b5b1e7921364cb89c4fe3b8cc05c881
    val getInstance2: Method =
        FirebaseMessaging::class.java.getDeclaredMethod("getInstance", FirebaseApp::class.javaObjectType)
    getInstance2.setAccessible(true)  // if security settings allow this
    // FirebaseMessaging.getInstance(appSingleton.firebaseApp!!)
    // null is for static methods
    val firebaseMessaging: FirebaseMessaging =
        getInstance2.invoke(null, appSingleton.firebaseApp!!) as FirebaseMessaging
    firebaseMessaging.subscribeToTopic(GEO_FENCE_TOPIC)
        .addOnCompleteListener { task ->
            if (!task.isSuccessful) {
                Timber.d("Could not subscribe to topic ${GEO_FENCE_TOPIC}")
            } else {
                Timber.d("Subscribed to topic ${GEO_FENCE_TOPIC}")
            }
        }

Currently the messages don't arrive which is possibly due to https://github.com/DIYGPSTracker/DIYGPSMessaging/issues/1 but we have to verify the receiver end as well.


Dockerfile out of date

The golang:1-alpine image referenced in the Dockerfile is now based on Alpine Linux 3.13, which does not have llvm9 packages.
Users may either target golang:1-alpine3.12 or switch the packages to llvm10 (don't forget to set the LLVM_CONFIG env variable to /usr/bin/llvm-config).

Thank you Richard. Fixed


ci: goreleaser darwin

Closes https://github.com/celestiaorg/celestia-app/issues/2567
Testing
Testing with binaries on my fork.

os
arch
machine
works
notes

darwin
arm64
Rootul's MBP
✅
I had to circumvent Apple can't check app for malicious software

darwin
amd64
TBD

linux
amd64
Digital Ocean

linux
arm64
Digital Ocean

Codecov Report

Merging #2654 (42265bb) into main (a52ed26) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2654   +/-   ##
=======================================
  Coverage   21.11%   21.11%
=======================================
  Files         138      138
  Lines       15767    15767
=======================================
  Hits         3329     3329
  Misses      12115    12115
  Partials      323      323


Calculate a custom tip: Android Basics with Compose  Boolean

URL of codelab
In which task and step of the codelab can this issue be found?
Describe the problem
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

bad click


Wrap --codesign-identity into flet pack

Please Describe The Problem To Be Solved
In macOS if you pack a .app using "flet pack", and then codesign + notarize the app it will fail to run because the packed binaries are not signed as well. The easy workaround is to use pyinstaller which allows the argument "--codesign-identity" to complete the build with an end to end signing process.
The problem with this workaround appears to be that once the Application is opened the app icon changes to the Flet icon, and the application name changes to "Flet". Meanwhile, the app icon & name remain correct in /Applications.
(Optional): Suggest A Solution

Wrap --codesign-identity from pyinstaller into flet pack

Not sure how feasible or desirable this option fits into the future of the project, but it would be helpful with the current circus of code signing on MacOS.

Clearing any ~.flet cache does resolve the app icon issue when using pyinstaller. The App name when running appears to be the only thing I can't resolve.

For further testing and to confirm this solution does indeed resolve the issue I explored the source for pack.py and added in the parser argument for --codesign-identity as well as the handler. I officially have a fully signed (end to end) and working macOS app when using "flet pack".
I'm new to contributions on github so I'll review the guidelines and make a submission if it's of interest for the repo manager/owner.

Finally getting time to get around to the PR so I'll do that this afternoon.
I'm going to include wrapping for --add-binary as well due to further testing with dynamic linked libraries  (.dylib) being packed. Unsigned you can get away with --add-data to pack the dylib in "./" however, with end to end code signing I noticed the underlying security system of macOS was unhappy about the dylib signing.
Adding in --add-binary to use for dynamic linked libraries in flet pack resolved this in code signed packages.

Closing. PR #1789 accepted and merged.


Add record struct support for sort

Summary of the changes (Less than 80 chars)
Add support for record struct sortconvention

@zyofeng  I dont think this works as this would also treat structs like Guid as a sortable input object. Does it work when you just manually register the SortInputType?

You are correct, I've updated the PR to filter out structs such as guid, decimal by checking for PrintMembers, which is a generated method specifically for record structs

@zyofeng How does one of you sort queries look like?

I have the following record struct
public record struct CountryDto(string Name, string? Iso, string State, bool IsNonCompliantCountry);
using the aforementioned sortconvention I am able to sort using the following query
query {
  countries(order: [{ name: ASC }, { isNonCompliantCountry: DESC }]) {
    isNonCompliantCountry
    iso
    name
    state
  }
}

and generate the following EF Core query
SELECT [c].[IsNonCompliantCountry], [c].[Iso], [c].[Name], [c].[State]
FROM [Countries] AS [c]
ORDER BY [c].[Name], [c].[IsNonCompliantCountry] DESC

since IsNonCompliantCountry is a boolean struct this means the modified SortConvention works for normal struct.

I have the following record struct
public record struct CountryDto(string Name, string? Iso, string State, bool IsNonCompliantCountry);
using the aforementioned sortconvention I am able to sort using the following query
query {
  countries(order: [{ name: ASC }, { isNonCompliantCountry: DESC }]) {
    isNonCompliantCountry
    iso
    name
    state
  }
}

and generate the following EF Core query
SELECT [c].[IsNonCompliantCountry], [c].[Iso], [c].[Name], [c].[State]
FROM [Countries] AS [c]
ORDER BY [c].[Name], [c].[IsNonCompliantCountry] DESC

since IsNonCompliantCountry is a boolean struct this means the modified SortConvention works for normal struct.

Is this looking okay?

This one needs test for this otherwise we cannot verify if this is a good idea or not. We need tests showing that Guid and other important structs are ignored. What is with typed id structs ... they are not primitives.

@zyofeng Are you still working on this?

@zyofeng Are you still working on this?

Im happy to take a look at implementing some tests for record struct vs common struct types like guid, datetime etc when I get some time, hopefully this weekend.


Particle Accelerator gets stuck if it's in the singularity shader.

Description

This is a problem that's mostly on Delta due to how bad Delta's singularity area is, but it's still applicable on other stations because of how big the singularity shader can get.
How to replicate:

Spawn (or construct) a particle accelerator. I did this in Delta's PA room when testing an unrelated bug.
Turn the PA to 2 in order to spawn a singularity.
Once the singularity spawns and the shader turns on, you will no longer be able to interact with the PA computer.

Is this because ScreenToMap looks different from a player's perspective? Because that one's not really fixable.

It's fixable but the consequences are potentially worse than what it's curing (as it would likely make clicking anything near the singularity a complete nightmare when the singularity is in motion, and it requires a separate C# copy of the shader's logic)


k8s: Fetch-free CEP update logic

CEP update controllers would always fetch, update then upload CEP
objects. In larger deployments this would cause undue load on
kube-apiserver because the same controller is the only writer of the
CEP, and can re-use the previous update's instance.
The new controller reuses the CEP object and handles unexpected errors
by recreating the CEP from scratch. This means there is a 1 period delay
between refetching and updating a CEP when that occurs.
One side-effect is that unless the local state changes, deleted CEPs are not restored. They can only be recovered when they change or the agent restarts.
Fixes https://github.com/cilium/cilium/issues/7237

This change is

test-me-please

Coverage decreased (-0.04%) to 43.219% when pulling 360913dd7fc6e6a60892ca860b09391fdb6b6d22 on raybejjani:cep-optimistic-patch into f60987ff4c840b4eb7d1367b351fcafd54fa3d7e on cilium:master.

test-me-please

test-missing-k8s

test-missed-k8s

test-me-please

test-me-please

test-me-please

test-missing-k8s

failures are not related with this change


[Bug]: llama_index run graphstore persist without any error. However, there is no json file in persist dir

Bug Description
use Neo4jGraphStore to initial a graphstore then persist to local dir. the program exit with no error but the dir is still empty.
neo4j database is online and has 88 nodes.
seems the persist method fails and raise nothing
Version
0.10.46
Steps to Reproduce
import nest_asyncio
nest_asyncio.apply()
from llama_index.graph_stores.neo4j import Neo4jGraphStore
graph_store = Neo4jGraphStore(
username="neo4j",
password="neo4j",
url="bolt://localhost:7687",
database="graphstore",
)
graph_store.persist(persist_path="F:/gstore/gstore.json")
run the code above and you'll find no json created under persist_path
Relevant Logs/Tracbacks
No response

@zydmtaichi there is nothing to persist, the data is all in neo4j already.
The persist method is merely pass, so that when you call persist on the storage context, everything else can save without error
Since it's all in neo4j already, you can just connect back to it
https://docs.llamaindex.ai/en/stable/examples/property_graph/property_graph_neo4j/?h=neo4j#loading-from-an-existing-graph

@zydmtaichi there is nothing to persist, the data is all in neo4j already.
The persist method is merely pass, so that when you call persist on the storage context, everything else can save without error
Since it's all in neo4j already, you can just connect back to it https://docs.llamaindex.ai/en/stable/examples/property_graph/property_graph_neo4j/?h=neo4j#loading-from-an-existing-graph

@logan-markewich the link above can only use for graph created by PropertyGraphIndex. other kinds of graphs created by KnowledgeGraphIndex or maybe manually edited in neo4j can not load from existing neo4j database. that's why i try to export my KnowledgeGraphIndex graph to local using persist method. unfortunately it's still not working. pls tell me how to load these graph as llama index?

Check Dependencies: Ensure all prerequisites for Neo4jGraphStore are met, including the installation of the neo4j Python package and the APOC plugin in your Neo4j database

This is not in the Neo4jKGIndexDemo docs. I'm going to create a separate issue for this lack-of-docs issue.

@logan-markewich
Indeed, KnowledgeGraphIndex only has from_documents, and not from_existing.
I have a few questions:

What is the difference between KnowledgeGraphIndex and PropertyGraphIndex, and which one should I use if I want to create a knowledge graph-based question and answer system?
If I choose to use KnowledgeGraphIndex for a knowledge graph question and answer system, how should I import existing data from neo4j? PropertyGraphIndex can import, but this is not applicable for KnowledgeGraphIndex.
I hope to receive your reply soon, thank you very much!

+1, I also want to get the answer about @WQL782795 's question. /assign logan-markewich   pls reopen this issue


Auth adapter does not override record attributes but still prevents illegal creation/modification

This fixes an active bug in which the authorization adapter interacts with permissions gem CanCan in such a way that records are erroneously assigned attributes, which has been reported in countless issues dating back years such as this one: https://github.com/sferik/rails_admin/issues/1880
These issues all get pseudo-resolved with the suggestion to use the work-around to specify CanCan conditional permissions using a block instead of an attribute hash.
This is an unsatisfactory solution for three reasons:

A workaround is still a workaround, this is a bug, it should be fixed.
When someone employs the workaround, they fail to take advantage of the important case that RailsAdmin is trying to protect against (explained below).
When using the block workaround, RailsAdmin can't build list views or complete certain batch-actions with the records, as these rely on CanCan's accessible_by, which is incompatible with ability block conditions.

It's really time for this to get fixed.
Whats happening is this, if you have a permission rule like this one, stipulating that a user can only create edit a comment that they own:
can [:create, :update], Comment, :user_id => user.id

And let's say the user above does have access to the admin dashboard, but is not a full admin (perhaps, a user with an "intern" role).
Rails Admin sees this permissions rule, and so they don't show you or let you edit any comments by other users. BUT they do let you create new comments, and also let you edit comments that you currently own. Which theoretically lets you create or modify a comment that would be owned by another user. Sure, you'd then no longer have access to it. But you could theoretically create a comment for someone else saying something nasty!
So what rails admin was doing was deducing what attributes a comment you create should always have. It sees that rule, and so after it has applied all the attributes you manually assign to your new/modified record, it then creates a hash of attributes prescribed by the permission scheme, and applies them to the record before it is saved, potentially overriding attributes you would have set (but perhaps shouldn't have).
So in the case of the apocryphal comment, this works great:
goofball intern tries to create a comment someone else as the user, with body "im a jerk!"
rails admin applies the user_id and the body specified
rails admin then pulls @authorization_adapter.attributes_for(:create, RailsAdmin::AbstractModel.new(Comment) to get the attributes that should be present given the current users abilities, which in this case, are {:user_id => goofball_user.id}
It then overrides that attribute, so instead of assigning the comment to the innocent other use, goofball users comment is assigned to himself. take that goofball user - ya jerk!
So far so good. BUT, problems arise when we have a legit admin user, and we've assigned rules like this:
can [:create, :update], Comment, :user_id => user.id

if user.admin?
  can :manage, :all
end

This says that all users can update a comment if they own it, but also, if you're an admin, you can just do everything. And this is a common way of assigning rules in can can.
 Say, edit that goofball comment from before because it was flagged. You're allowed to do that, you're an admin. but @authorization_adapter.attributes_for(:create, RailsAdmin::AbstractModel.new(Comment) still pulls that hash {:user_id => admin.id}. Even though that can :manage, :all specification should wipe that out, it doesn't. So when the admin edits the goofball comment, rails admin force applies the admins own ID as the user_id. Re-saving the comment as belonging to the admin user. We don't want this.
So how do we keep the best of both worlds: preventing users with limited abilities from creating/modifying records such that they break permissions, but without introducing this occasionally disastrous case where users with extended permissions accidentally rob other users records (or users themselves) or unwittingly change other attributes?
I'm removing the hard-assignment of @authorization_adapter.attributes_for when records are updated/created, no more overriding. But after the record is instantiated or updated in memory, but before it's persisted to the database, I'm re-checking to see if the current user still has permissions to take the current action for this record, and then refusing to save if they don't. For the admin this means they update someone else's comment, no problem. For the goofball, instead of them creating a comment for someone else, or instead of them creating a comment that gets reassigned to themselves, the comment just refuses to save if they try to attribute it to someone else.
The only place I'm keeping use of @authorization_adapter.attributes_for is in the new action (but not create). This means that when an admin or anyone goes to create a new comment, it will pre-populate the form with them as the comment's owner. That's all!
I see that there are specs in this gem, but couldn't find any documentation for contributors on how they are to be run. Happy to update them if some documentation could be provided. Thanks!

Thanks for the proposal, applied this change as c84d1703.


Issue with the association control

Hello,
I have tried so many ways and compared this an existing implementation. Everything is setting right. But I get always this error.

Do you have an idea?
thank you

I have exact same issue. Does anyone have some explanation or solution?

Hi, My users are seeing the same checkboxChanged error but our error message has far less detail. Any progress on resolving this issue?


Use redux form without form element

Thanks for the amazing tool. In our product due to some legacy code the whole app is in a <form> element. Therefore, a form inside a form is not allowed and results in the production of invalid html. Could redux-form be used without it?

Yes @pegiadise you don't even need to use a <form> node inside your redux-form component if you don't have to.
Just as an example of this, this should work just fine:
const FormWithoutForm = React.createClass({
  render() {
    return (
      <div>
          //
          //..... input form fields here
          //
        <button onClick={ this.props.handleSubmit } />
      </div>
  }
});

export default reduxForm({ form: 'FormlessForm' })(FormWithoutForm);

Hope this helps!

Thank you.

@kevinzwhuang's answer is correct. Using a <form> is completely optional.


Namespace for classification types

This PR addresses issue #8

Added namespaces for classification types
Added requestDocs & requestTransmittedDocs pagination parameters

Codecov Report

Merging #11 (99eaa7c) into main (2b3ab75) will decrease coverage by 17.94%.
The diff coverage is 25.58%.

@@             Coverage Diff             @@
##             main      #11       +/-   ##
===========================================
- Coverage   93.70%   75.75%   -17.95%
===========================================
  Files           3        5        +2
  Lines         127      165       +38
===========================================
+ Hits          119      125        +6
- Misses          4       32       +28
- Partials        4        8        +4

Impacted Files
Coverage Δ

pkg/models/expense_classification.go
0.00% <0.00%> (ø)

pkg/models/income_classification.go
0.00% <0.00%> (ø)

pkg/mydata/client.go
83.60% <47.82%> (-8.71%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Coverage looking better after adding some test cases. Let me know what you think : )

I just noticed I had to sign all of my changes so I squashed them as well. No new changes introduced in todays commit.
Also I get the message First-time contributors need a maintainer to approve running workflows


docs unclear / lsp-document-symbol no longer does anything

Maybe I'm just too much of a noob at configuring Kakoune, but I just cannot get this thing to work. I remember that  it was "working" a few weeks ago, or at least lsp-document-symbol would print some info in some buffer (the debug one probably?).
Anyways, the docs really should make this stuff clearer. This is likely one of the first modules one would install for Kakoune (it certainly is in my case) so it'd be nice if they weren't expected to know all the lingo.
(ps.: fun fact: hosting on GitHub means people in countries under US sanctions can't access your code or send bug reports. hence i for one would very much prefer to be giving this bug report elsewhere.)

My config didn't change in any relevant way that I know of, the python language server is in my $PATH, etc, etc. There is no error, nothing shows up in debug, I just have no idea what's going on.

Okay, I remembered that kak-lsp can be run separately, maybe I can figure out what the heck is going on.

Okay, figured it out, apparently I mistakenly assumed the sample config means those are defaults. I'm not sure if this issue should be closed though, others might have an even harder time finding that info. I'll try and contribute some fix for the docs.

I mistakenly assumed the sample config means those are defaults

They are the defaults, but those defaults are no longer loaded once you have your own kak-lsp.toml.
The readme instructs the user to copy (or link to) kak-lsp.toml; creating one from scratch is probably not common.
I'm not sure what exactly happened on your side since you didn't change anything? Maybe we can make the docs clearer.

hosting on GitHub means people in countries under US sanctions can't access your code or send bug reports

That's a general issue in the Kakoune ecosystem.
I think we could offer a mailing list (sr.ht) as alternative channel?
IRC would also work but it's better if it's publicly searchable.
(In theory, https://github.com/MichaelMure/git-bug could be used to host read-write mirrors of GitHub repos, though that relies on GitHub's goodwill.)


fix(datatypes): handle None if HP does not return a value

In case the firmware does not support a given parameter listet in any of the know calculations (at least that's where the issue happened for me) it will return None and plugging that into any of the various mathematical calculations inside datatypes.py leads to exceptions. This PR handles them gracefully.

Sorry for ignoring this for so long. Let's get going here.
Changes to me look fine to me.
What I would like to see, though, are unit tests to make sure that this will not be forgotten for any new datatypes, etc.
@wilriker Would you be willing to work on this, or should I give it a go?
@Bouni Any feedback regarding this PR?

Hi @kbabioch!
I just pushed a set of test cases checking for None. Is that sufficient?

LGTM

Thank your for the test cases. Changes itself look fine, but I'm still trying to understand the root cause of the issue here. So in your case you were trying to access parameters that you're firmware doesn't know about.
What is returned as raw value in this case? None is a Python-specific value, but what is actually being returned by the Luxtronik controller?

Just a speculation: In
https://github.com/Bouni/python-luxtronik/blob/16a5f6f91891a7ade1824e51f241c797aff21cef/luxtronik/datatypes.py#L16
the .raw is set to None. If the heat pump only returns 500 parameters (indicated by length), then the raw values of all the other parameters is still None.

the .raw is set to None. If the heat pump only returns 500 parameters (indicated by length), then the raw values of all the other parameters is still None.

That might be a good explanation. Is this something we should handle in the code, or if this is expected behaviour? Where have you seen / derived the 500 from?

Since I have upgraded my heatpump firmware meanwhile I can no longer reproduce the initial problem. At that time I was running a 1.69 version (that still had the old Java Applet).

There are some Pythonic errors that need to be addressed:

tests/test_datatypes.py:149:51: E711 [] Comparison to None should be cond is None
tests/test_datatypes.py:312:50: E711 [] Comparison to None should be cond is None
tests/test_datatypes.py:337:52: E711 [] Comparison to None should be cond is None
tests/test_datatypes.py:362:51: E711 [] Comparison to None should be cond is None
tests/test_datatypes.py:432:50: E711 [] Comparison to None should be cond is None
tests/test_datatypes.py:457:51: E711 [] Comparison to None should be cond is None
tests/test_datatypes.py:482:49: E711 [] Comparison to None should be cond is None
Found 7 errors.
[] 7 potentially fixable with the --fix option.
Error: Process completed with exit code 1.

At least I don't see any harm in merging this, so let's go forward with it.

Could you also add this for the Hours2 datatype

Done

the .raw is set to None. If the heat pump only returns 500 parameters (indicated by length), then the raw values of all the other parameters is still None.

That might be a good explanation. Is this something we should handle in the code, or if this is expected behaviour? Where have you seen / derived the 500 from?

Here, 500 just was a number smaller than the number of current parameters.


fix(v2): markdown title parser should ignore all forms of MDX import statements

Motivation
Currently the markdown title can be parsed after some kind of import statements. For example:
import Component1 from '@site/src/components/Component1';

import './styles.css';

# Markdown Title

Lorem Ipsum

This PR allow the most of import syntaxes.
import DefaultComponent from '@site/src/components/Component1';
import DefaultComponent2 from '../relative/path/Component2';
import * as EntireComponent from './relative/path/Component3';

import { Component4 } from "double-quote-module-name";
import { Component6 as AliasComponent6 } from "module-name";
import DefaultComponent8, { DefaultComponent81 } from "module-name";
import DefaultComponent9, * as EntireComponent9 from "module-name";

import _ from 'underscore';
import "module-name";

# Markdown Title

Lorem Ipsum

Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Already added test for the change.
Related PRs
From @slorber's suggestion in #4729.
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

thanks for this :) looks great


fix: update duplicates_pandas.py

Fixing Bug Report #1384
Dataset with categorical features causes memory error even on tiny dataset.

Thank you for reporting the issue and solving it!

Codecov Report
Patch and project coverage have no change.

Comparison is base (7fb4fc5) 89.71% compared to head (f0a9840) 89.71%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1427   +/-   ##
========================================
  Coverage    89.71%   89.71%
========================================
  Files          194      194
  Lines         6319     6319
========================================
  Hits          5669     5669
  Misses         650      650

Flag
Coverage Δ

py3.8-ubuntu-22.04-pandas
89.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

.../ydata_profiling/model/pandas/duplicates_pandas.py
100.00% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


If my picture set the display: none, it will be the default load?

hi, for the 1.x version, I have a question:
In the 1.x source, I see skip_invisible set to false.
        var settings = {             skip_invisible  : false,         };
Then traverse the elements, through this condition to judge, the image lazy load.
 if (settings.skip_invisible && !$this.is(":visible")) {         return;  }
In this case, the default loading display: none picture elements, why should this set up? What is the meaning of this conditional judgment?
If you have time, please tell me why, thank you very much.

In the old times when browsers were much slower one could set skip_invisible : true and images which were hidden with CSS would be ignored by the plugin. This way there would be smaller amount if images to check and plugin worked faster.


count, skip and many1Till combinators

I found I needed these for my MIDI parser:

-- | Parse `n` occurences of `p`. -
count :: forall a. Int -> Parser a -> Parser (List a)
count n p =
  let
    accumulate x acc =
      if x <= 0 then
        pure (reverse acc)
      else do
        res <- p
        accumulate (x - 1) (res : acc)
  in
    accumulate n Nil

-- | Apply a parser and skip its result.
skip :: forall a. Parser a -> Parser Unit
skip p = unit <$ p

-- | Parse several phrases until the specified terminator matches, requiring at least one match.
many1Till :: forall a end. Parser a -> Parser end -> Parser (List a)
many1Till p end = do
  x <- p
  xs <- manyTill p end
  pure (x:xs)

Any chance of accepting another PR ?

count is just replicateA and skip is void. many1Till sounds good though.

Ah - I didn't realise that - still a good deal to learn.  I'll raise a PR for many1Till.


Support nested audio dissolve

This fixes an odd structure I've found in a few timelines generated from Media Composer.
It's a Transition inside an OperationGroup

It just ends up becoming a dissolve on the end of a audio clip.

I'm not entirely sure how Media Composer creates this structure, but I've run into on a few timelines.
Without the the fix the adapter raise this exception:
  File "d:/dev/otio-aaf-adapter/src/otio_aaf_adapter\adapters\advanced_authoring_format.py", line 1574, in read_from_file
    result = _transcribe(mobs_to_transcribe, parents=list(), edit_rate=None)
  File "d:/dev/otio-aaf-adapter/src/otio_aaf_adapter\adapters\advanced_authoring_format.py", line 821, in _transcribe
    result.append(_transcribe(child, parents + [item], edit_rate, indent + 2))
  File "d:/dev/otio-aaf-adapter/src/otio_aaf_adapter\adapters\advanced_authoring_format.py", line 413, in _transcribe
    track = _transcribe(slot, parents + [item], edit_rate, indent + 2)
  File "d:/dev/otio-aaf-adapter/src/otio_aaf_adapter\adapters\advanced_authoring_format.py", line 639, in _transcribe
    child = _transcribe(item.segment, parents + [item], edit_rate, indent + 2)
  File "d:/dev/otio-aaf-adapter/src/otio_aaf_adapter\adapters\advanced_authoring_format.py", line 631, in _transcribe
    result = _transcribe_operation_group(item, parents, metadata,
  File "d:/dev/otio-aaf-adapter/src/otio_aaf_adapter\adapters\advanced_authoring_format.py", line 1148, in _transcribe_operation_group
    child = _transcribe(segment, parents + [item], edit_rate, indent)
  File "d:/dev/otio-aaf-adapter/src/otio_aaf_adapter\adapters\advanced_authoring_format.py", line 625, in _transcribe
    child = _transcribe(component, parents + [item], edit_rate, indent + 2)
  File "d:/dev/otio-aaf-adapter/src/otio_aaf_adapter\adapters\advanced_authoring_format.py", line 621, in _transcribe
    metadata["PhysicalTrackNumber"] = list(parent.slots).index(item) + 1
AttributeError: 'Sequence' object has no attribute 'slots'

The fix is to only set PhysicalTrackNumber if the parent is a MobSlot

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (4b2d658) 90.15% compared to head (ad592e5) 90.17%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   90.15%   90.17%   +0.01%
==========================================
  Files           3        3
  Lines        1107     1109       +2
==========================================
+ Hits          998     1000       +2
  Misses        109      109

Flag
Coverage Δ

unittests
90.17% <100.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

..._aaf_adapter/adapters/advanced_authoring_format.py
85.97% <100.00%> (+0.04%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

FYI, this structure is the result of a track effect that applies pan to the original audio timeline sequence, thus the nesting.

I rebased this on top of the current main. It will cleanly merge now


Night Terrors

text: ruling 4 is very confusingly worded for a reaction, I assume it coems from hide the heart rulign, where it makes mor sense to talk about "another methuselah being targeted" this ruling should be reworded here and for draba
link: https://www.vekn.net/forum/rules-questions/78676-draba-timing#100043

Agreed
@lionel-panhaleux I think that line should be dropped completely from the card, considering that:

as mentioned, it is extremely confusing, and
the new impulse rules removed the "declining to block" declaration (simply becoming implicit on the first pass of the impulse on an action)

I'd rather keep it because I did stumble in the very specific case of:

A play Magic of the Smith
B would like to block, but the 2 intercept from Second Tradition is not enough
C can actually Draba the stealth out
→ But B needs to commit first, and attempt to block without enough intercept, paying blood and playing their Second Tradition, then and only then can C play Draba. Or decide that, in the end, they'd rather keep it.

But I agree, the wording's not great, I'll try to come up with a better one.

Correct, and that all falls within the impulse rules
I think people just need to get used to it and not shortcut to "I decline to block"
If you follow the impulse rules, it would be:

A plays MotS
A passes impulse
B plays second tradition and attempts to block as per card text (impulse goes to A)
A passes impulse
B passes impulse
C gets impulse and plays Draba (impulse goes back to A, and then B)

C cannot attempt to play Draba before this point because they do not have the impulse
Following the impulse rules also allows for the following:

A plays MotS
A passes impulse (impulse goes to B)
B decides not to play second tradition and passes impulse (impulse goes to C)
C plays Draba (impulse goes to A)
A passes impulse (impulse goes to B)
B uses their impulse to attempt to block the now 0 stealth MotS (impulse goes to A)


Update pre-install cleanup

Description
The older mechanism moves the existing directory to a temporary one and then clears it. Updated pre-install script to directly delete the existing directory.
Related Issue
If /opt has space constraints applied, we could run into errors.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

Attaching historical context for reference
https://github.com/chef/chef/pull/8046
https://github.com/chef/chef/pull/7964


#[derive(QueryableByName)] fails to compile if there is a type called Result in scope

I really wish people wouldn't shadow types from Rust's prelude, but we should probably explicitly reference std::result::Result

This conversation is very thoughtful. I believe this issue has been addressed in 443f43ae and can be closed 🙂 .


Review request for Microsoft.ContainerService to add version 2022-06-02-preview

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
Expected to deploy to all global regions on 7/7.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
2022-07-08.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

    "enabled": {

ARM prefers string enum vs. boolean, although I see you have booleans all over the place in your API already. Enums make better properties than booleans: they are more descriptive, flexible and future-proof while being easier for customers to discover, understand and use. Ref: https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html?q=boolean#common-issues-found-in-review.

Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json:6161 in 83f13e9. [](commit_id = 83f13e9bba9320199ccd41bff5fedf8d12b90ef9, deletion_comment = False)

@serbrech, @FumingZhang - Note: after you are finished responding to ARM feedback, remove the ARMChangesRequested label to hand it back to ARM review. I think you might have used WaitForReviewRevisit for that purpose, but since I'm not sure about that, I put it back in case it was intended for the SDK reviewers.

/azp run

Dear review board, I would like to clarify the failures in the CI checks.
For SDK azure-powershell, from log it seems that the reason for the failure lies in the build tool /home/cloudtest/.autorest/@autorest_powershell<EMAIL_ADDRESS>- TypeError: value.replace is not a function. This CI used to be optional and is enabled recently.
For SDK azure-sdk-for-net, it happened in our previous PR 05-02-preview. I suppose this should be a known issue.
For Breaking Change(Cross-Version) and Swagger SDK Breaking Change Tracking, it's caused by rebranding of Microsoft Defender. The modification has been added to our previous preview API (2022-05-02-preview) and is about to be introduced into the following stable API (2022-06-01). For more details about the clarification, see comment.

Quote previous explanations for the CI failures.


spleeter.separator not found when installing with pip

Description
Pip installing seems to be missing the separator module.
Step to reproduce

Pip installed ffmpeg and spleeter
Ran this code

from spleeter.separator import Separator

sep = Separator('spleeter:2stems')
path = "C:\\Users\\Sebastian\\Documents\\VScode\\Personal Projects\\Music Recognition Project"
song_path = path + "Automatic Stop.mp3"

sep.separate_to_file(song_path,path)`

Got this error ImportError: DLL load failed: The specified module could not be found.

Output
2021-01-04 20:05:42.196029: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'cudart64_101.dll'; dlerror: cudart64_101.dll not found
2021-01-04 20:05:42.201066: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
Traceback (most recent call last):
  File "c:/Users/Sebastian/Documents/VScode/Personal Projects/Music Recognition Project/pokesong2.py", line 1, in <module>
    from spleeter.separator import Separator
  File "C:\Users\Sebastian\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\spleeter\separator.py", line 27, in <module>
    from librosa.core import stft, istft
  File "C:\Users\Sebastian\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\librosa\__init__.py", line 211, in <module>
    from . import core
  File "C:\Users\Sebastian\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\librosa\core\__init__.py", line 5, in <module>
    from .convert import *  # pylint: disable=wildcard-import
  File "C:\Users\Sebastian\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\librosa\core\convert.py", line 7, in <module>
    from . import notation
  File "C:\Users\Sebastian\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\librosa\core\notation.py", line 8, in <module>
    from ..util.exceptions import ParameterError
  File "C:\Users\Sebastian\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\librosa\util\__init__.py", line 87, in <module>
    from ._nnls import *  # pylint: disable=wildcard-import
  File "C:\Users\Sebastian\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\librosa\util\_nnls.py", line 13, in <module>
    import scipy.optimize
  File "C:\Users\Sebastian\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\scipy\optimize\__init__.py", line 389, in <module>
    from .optimize import *
  File "C:\Users\Sebastian\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\scipy\optimize\optimize.py", line 37, in <module>
    from .linesearch import (line_search_wolfe1, line_search_wolfe2,
  File "C:\Users\Sebastian\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\scipy\optimize\linesearch.py", line 18, in <module>
    from scipy.optimize import minpack2
ImportError: DLL load failed: The specified module could not be found.

Environment

OS
Windows

Installation type
pip

RAM available
20GB

Hardware spec
GTX 1060 / i5 6600k

Python version
3.8.0

Hi @SebastianCardenasEscoto
The issue seems to be an incorrect installation of scipy or an incorrect environment setting for accessing dynamic libraries used by scipy and then does not seem to be a spleeter issue.
Please check https://stackoverflow.com/questions/22753695/dll-load-failed-with-scipy-optimize as it is seems to be a very similar issue.

Hi @SebastianCardenasEscoto
The issue seems to be an incorrect installation of scipy or an incorrect environment setting for accessing dynamic libraries used by scipy and then does not seem to be a spleeter issue.
Please check https://stackoverflow.com/questions/22753695/dll-load-failed-with-scipy-optimize as it is seems to be a very similar issue.


Users upload photos (if they have any).

[t:45] - partially completed, need to polish

Going to come back to this. Need questions answered like how do we want the images to look on the main page and if they even should be there. Questions on how it will be exported as CSV and if that will put an unnecessary strain on the DB having a picture or two with each team because it could become very large quickly. Especially because the planners want a very high res picture quality.

[t:60] going to punt this. ran into many problems and don't see how it could really benefit the user. The user would only get a ZIP of a whole bunch of images and have no idea which project correlated to which image. this would be the same as emailing a ZIP to the planners with images.


Acurrate/Precise/Stable/Cross-platform sleep()

Windows
This blog post nicely explains everything we need to know about sleeping threads in windows. TLDR; i ran the benchmarks locally and all those solutions are extremely precise and has similar CPU usage except for the the new waitable timer flag CREATE_WAITABLE_TIMER_HIGH_RESOLUTION added in Windows 10 which has an stable CPU usage even in 10ms scheduler. i believe we should listen to author's advice and go with the win32 Waitable Timers API
Linux/Android
Easy choice. We use the high-resulotion sleep function (clock_nanosleep) with CLOCK_MONOTONIC flag. there's also the POSIX function nanosleep(), but it's just clock_nanosleep() with extra overhead.
WASM
std::chrono::high_resolution_clock + std::this_thread::sleep_for

we will likely be sleeping for anything between 50us and 33ms, can you make win32, linux and wasm benchmarks for this and figure out the us amount of sleep when we should use a busywait rather than the API provided sleep
More importantly does Linux and WASM offer anything similar to the Win32 timers that sleep accurately ?


geopmbench / OMPT : OMPT Regions suppressed  in reports when listed after regular regions

When I run the following config with geopmbench, all is well:
{"loop-count": 100,
 "region": ["dgemm-unmarked", "dgemm", "stream-unmarked"],
 "big-o": [0.100000, 0.100000, 0.1]}

The report corresponding to the above configuration looks like:
##### geopm 1.0.0+dev95g899a7a0 #####                                                                                [6/2981]
Start Time: Thu Jan 08 11:17:00 1970
Profile: /p/lscratchh/geltz2/build/geopm/bin/geopmbench
Agent: monitor
Policy: {}

Host: quartz30
Region [OMPT]geopmbench:geopm::StreamModelRegion::run()_40184 (0x000000006ccb2dbe):
    runtime (sec): 18.2092
    sync-runtime (sec): 4.92884
    package-energy (joules): 913.413
    dram-energy (joules): 228.677
    power (watts): 185.32
    frequency (%): 114.799
    frequency (Hz): 2.41079e+09
    mpi-runtime (sec): 0
    count: 100
Region [OMPT]libmkl_intel_thread.so:gemm_omp_driver_v2_2986379 (0x0000000062e155b0):
    runtime (sec): 1.61942
    sync-runtime (sec): 0.0447739
    package-energy (joules): 8.66296
    dram-energy (joules): 1.28595
    power (watts): 193.482
    frequency (%): 114.699
    frequency (Hz): 2.40869e+09
    mpi-runtime (sec): 0
    count: 100
Region dgemm (0x00000000a74bbf35):
    runtime (sec): 1.6153
    sync-runtime (sec): 0.0201255
    package-energy (joules): 4.64417
    dram-energy (joules): 0.699188
    power (watts): 230.76
    frequency (%): 114.637
    frequency (Hz): 2.40737e+09
    mpi-runtime (sec): 0
    count: 100
Region model-init (0x00000000644f9787):
    runtime (sec): 0.449011
    sync-runtime (sec): 0.440202
    package-energy (joules): 77.73
    dram-energy (joules): 14.7723
    power (watts): 176.578
    frequency (%): 123.788
    frequency (Hz): 2.59954e+09
    mpi-runtime (sec): 0
    count: 1
Region unmarked-region (0x00000000725e8066):
    runtime (sec): 0.506853
    sync-runtime (sec): 16.9179
    package-energy (joules): 3324.63
    dram-energy (joules): 773.019
    power (watts): 196.515
    frequency (%): 115.001
    frequency (Hz): 2.41501e+09
    mpi-runtime (sec): 0
    count: 0
Epoch Totals:
    runtime (sec): 21.9002
    sync-runtime (sec): 20.7308
    package-energy (joules): 4029.83
    dram-energy (joules): 955.344
    power (watts): 194.389
    frequency (%): 114.85
    frequency (Hz): 2.41184e+09
    mpi-runtime (sec): 0
    count: 100
    epoch-runtime-ignore (sec): 0
Application Totals:
    runtime (sec): 23.6038
    package-energy (joules): 4491.15
    dram-energy (joules): 1037.03
    power (watts): 190.273
    mpi-runtime (sec): 0
    ignore-time (sec): 0
    geopmctl memory HWM: 152976 kB
    geopmctl network BW (B/sec): 0

If I change the bench config to be:
{"loop-count": 100,
 "region": ["dgemm", "dgemm-unmarked", "stream-unmarked"],
 "big-o": [0.100000, 0.100000, 0.1]}

(That is, I put "dgemm" before "dgemm-unmarked"...) The report looks like:
##### geopm 1.0.0+dev95g899a7a0 #####
Start Time: Tue Feb 24 21:32:09 1970
Profile: /p/lscratchh/geltz2/build/geopm/bin/geopmbench
Agent: monitor
Policy: {}

Host: quartz35
Region model-init (0x00000000644f9787):
    runtime (sec): 0.47895
    sync-runtime (sec): 0.470349
    package-energy (joules): 79.6368
    dram-energy (joules): 14.9743
    power (watts): 169.314
    frequency (%): 123.733
    frequency (Hz): 2.5984e+09
    mpi-runtime (sec): 0
    count: 1
Region dgemm (0x00000000a74bbf35):
    runtime (sec): 0.135101
    sync-runtime (sec): 0.129899
    package-energy (joules): 18.8153
    dram-energy (joules): 2.45386
    power (watts): 144.845
    frequency (%): 121.288
    frequency (Hz): 2.54705e+09
    mpi-runtime (sec): 0
    count: 1
Region unmarked-region (0x00000000725e8066):
    runtime (sec): 0.0617347
    sync-runtime (sec): 0.0200873
    package-energy (joules): 2.7417
    dram-energy (joules): 0.414703
    power (watts): 136.489
    frequency (%): 123.365
    frequency (Hz): 2.59067e+09
    mpi-runtime (sec): 0
    count: 0
Epoch Totals:
    runtime (sec): 21.9653
    sync-runtime (sec): 0.144786
    package-energy (joules): 21.0402
    dram-energy (joules): 2.78575
    power (watts): 145.319
    frequency (%): 121.595
    frequency (Hz): 2.55349e+09
    mpi-runtime (sec): 0
    count: 100
    epoch-runtime-ignore (sec): 0
Application Totals:
    runtime (sec): 23.5895
    package-energy (joules): 4409.84
    dram-energy (joules): 1017.46
    power (watts): 186.941
    mpi-runtime (sec): 0
    ignore-time (sec): 0
    geopmctl memory HWM: 152996 kB
    geopmctl network BW (B/sec): 0

In the second case, all OMPT regions are absent from the report.

I have observed a similar problem: regular regions after OMPT regions suppress all user markup regions from the report.

No longer reproducible.


feat(x/downtime): make x/pairing use x/downtime for relay payments

can you resolve the conflicts?


Samples should not require us to specify devDependencies in root package folder

https://github.com/Azure/azure-sdk-for-js/pull/12111#discussion_r514489086

Ideally, we should not need a devDependency in the root folder for something that's used only in the samples
Check why there is such a need
Remove the devDep in service-bus
Followup with dev-tool if needed updates

Removing the Service Bus label as we now have other packages in the similar boat
@willmtemple We don't have any plans to change anything here correct? If so, please provide a summary on why we need this and close this issue

We discussed this offline. Having the sample dependencies in devDependencies makes some logical sense, and it aligns with the work moving forward to integrate samples as first class sources in the project (like tests).


Ford: add models. Placeholders for Fingerprints and DBC.

Added models to values.py. Made placeholders for fingerprints and dbc's

Commented out blank lines to pass validation. Data is still present, so fingerprints and DBC's can be added.

There is no point adding unsupported cars now, since it will add unused lines of code that need to be maintained. The cars can be added one by one when there is a port.


Text rendering issues

VSCode Version:

$ code -v
1.18.1
929bacba01ef658b873545e26034d1a8067445e9

OS Version:

$ uname -a
Linux dell-laptop 4.13.0-1-amd64 #1 SMP Debian 4.13.13-1 (2017-11-16) x86_64 GNU/Linux
$ cat /etc/issue
Debian GNU/Linux buster/sid \n \l

Steps to Reproduce:

Open any file in vscode

Reproduces without extensions: Yes

I think it is duplicate of #35675

Exactly! I solved this issue by disabling anti-aliasing settings:


[logger] Adding terminal formatter support

Signed-off-by: Piyush Singariya<EMAIL_ADDRESS>Description
This PR introduces logrus formatting support for Terminal logs for mesheryctl
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

I just wonder that what's the difference between Syslog LogFormat and Terminal LogFormat.

@Aisuko SysLog format prints timestamps and the appName from where these logs are coming. however, they aren't required in case of mesheryctl, and also is a bad experience seeing those being printed by a CLI, so a new format is being added in a similar format for logrus from mesheryctl.

@Aisuko SysLog format prints timestamps and the appName from where these logs are coming. however, they aren't required in case of mesheryctl, and also is a bad experience seeing those being printed by a CLI, so a new format is being added in a similar format for logrus from mesheryctl.

Thank you @piyushsingariya, Would you consider set log formats to the new format?

Would you consider set log formats to the new format?

I didn't get it. Would you rephrase it?

Would you consider set log formats to the new format?

I didn't get it. Would you rephrase it?

Shall we set the new format as the default log format for mesheryctl in this PR?

Yes, this new format would be used across the mesheryctl.

@leecalcote new release is required and dependencies needs to be updated in meshery


'Autofill' feature takes 1+ minute to render complex rig.json

Describe the bug
When loading a complex rig.json to pre-fill the form, it may take upwards of 1min. This is noticed with complex jsons (in this case, it was a rig.json with 17 manufacturers).
To Reproduce
Steps to reproduce the behavior:

Go to https://metadata-entry.allenneuraldynamics.org/
Click on the 'Autofill from file' button and select a rig.json file from local files.
See the loading indicator stating "Reading from file".
Observe that it may take 1+ min to see the new form with existing data.

Expected behavior
We should profile this and see if we can make the render faster. Ideally it would take <10s even with complicated rig.json.
Screenshots

Desktop (please complete the following information):

Browser: Edge, Chrome

Additional context

This is related to adding the CustomTextWidget to render consts values. The effect may be unnecessarily calling the parent onChange callback.

Fix in #161 reduces time for the same rig.json to 5 seconds.


change cursor style to text for react-select multi CreatableSelect

The presenter and contributor fields in the metadata tab use a combined select input control with multi-select enabled. The actual  is only a few pixels wide, so when hovering over the control, it's not showing a text cursor indicating the possibility to input new text.
This commit sets the cursor on the valueContainer component to text and resets it to default on the multiValue component.
For the list of available components for React-Select see: https://react-select.com/components
Fixes: #785

Why is this PR not deployed on test.editor.opencast.org?

Why is this PR not deployed on test.editor.opencast.org?

The github action is currently hardcoded to only work for PRs from certain repos: https://github.com/opencast/opencast-editor/blob/2a17c13bd814db30f987952cbfe91ee59dfd601b/.github/workflows/update-test.yml#L12. Would make sense to extend this to all Opencast committers, I think we just kind of forgot about it.

I would fix the text cursor in the dark mode in a new PR.

Created an issue so we don't forget #813

Why is this PR not deployed on test.editor.opencast.org?

The github action is currently hardcoded to only work for PRs from certain repos (there are more lines than in the preview):
https://github.com/opencast/opencast-editor/blob/2a17c13bd814db30f987952cbfe91ee59dfd601b/.github/workflows/update-test.yml#L12
. Would make sense to extend this to all Opencast committers, I think we just kind of forgot about it.

@Arnei any suggestion on how to reasonably update the workflow? I do not want to add all commiters manually and not update it automatically. Is there any way to check for the members of the developer team?

Why is this PR not deployed on test.editor.opencast.org?

The github action is currently hardcoded to only work for PRs from certain repos (there are more lines than in the preview):
https://github.com/opencast/opencast-editor/blob/2a17c13bd814db30f987952cbfe91ee59dfd601b/.github/workflows/update-test.yml#L12
. Would make sense to extend this to all Opencast committers, I think we just kind of forgot about it.

@Arnei any suggestion on how to reasonably update the workflow? I do not want to add all commiters manually and not update it automatically. Is there any way to check for the members of the developer team?

Tbh I do not know how to do this in a smart way, would have to look into it myself. @lkiesow might have an idea?


[simplebar-angular] contains deep imports

Describe the bug
I am receiving the following warning while compiling an angular 10 application:
Warning: Entry point 'simplebar-angular' contains deep imports into 'C:/Users/.../node_modules/simplebar/dist/simplebar-core.esm'. This is probably not a problem, but may cause the compilation of entry points to be out of order.
followed by this warning (probably related to the original one):
WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.array.filter'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.string.replace'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.regexp.exec'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.string.match'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.function.name'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.array.reduce'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.weak-map'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/web.dom-collections.iterator'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.string.iterator'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.parse-int'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.object.to-string'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.object.assign'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.array.iterator'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\Users\...\node_modules\simplebar\dist\simplebar-core.esm.js depends on 'core-js/modules/es.array.for-each'. CommonJS or AMD dependencies can cause optimization bailouts.
s.array.for-each'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

To Reproduce
Steps to reproduce the behavior:

Create angular 10 application (using ivy by default)
Install the latest 'simplebar-angular'
Compile the project
See error

Expected behavior
No warnings.
Your environment

Software
Version(s)

SimpleBar
2.3.0

Angular
10.2.3

Browser
edge / chrome (latest)

Operating System
windows 10

here is a post talking about this Warning: Entry point simplebar-angular contains deep imports
try adding in the angular.json in the "build"=> "options":
"allowedCommonJsDependencies": ["core-js"]

Yes, that's what I did, thanks.
This will ignore all the core-js warning's about the CommonJS , but the deep import issue still remains.

@axmad22 that's works for me, thanks.

It'd be nice if there were a way to opt-out of the core-js stuff if we're targeting modern browsers.

Solved.


New Latest Commit

Related Issue

Issue No. #193

Changes you made :

Added Transition Effects in Card.

Describe the changes :
Added Hover Effect which displays description about that destination providing a more user friendly experience.
Check list :

[x] I have followed code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All the aspects mentioned in the issue are covered.
[x] The website is properly working after my changes.
[x] 🌟 ed the repo

Type of change :

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Output Screenshots

@ANSHUMANDAS1506 I appreciate your dedication.
But you have not fixed the navbar. You can see that the navbar is sliced and the contact and favourites section have came below the navabr.
I don't know why you're trying to do with navbar, Plz fix the navabr.
Also it would be better if you create new branch for each new PR.
It reduces the chances of branch conflicts.

@ANSHUMANDAS1506 Due to inactivity this PR will be closed


[BUG] Error flashing Matter light example into esp32c3 (CON-443)

Reproduction steps
I'm following the following espressif documentation for Matter implementation:
Espressif documentation
Installed the prerequisites for ESP IDF:
mkdir -p ~/esp cd ~/esp git clone -b v4.4.3 --recursive https://github.com/espressif/esp-idf.git

cd ~/esp/esp-idf ./install.sh esp32

Getting the Repositories:
cd esp-idf
source ./export.sh
cd ..

git clone --depth 1 https://github.com/espressif/esp-matter.git
cd esp-matter
git submodule update --init --depth 1
cd ./connectedhomeip/connectedhomeip
./scripts/checkout_submodules.py --platform esp32 linux --shallow
cd ../..
./install.sh
cd ..

After getting the Repositories:
cd esp-idf; source ./export.sh; cd ..
cd esp-matter; source ./export.sh; cd..
cd esp-matter/examples/light
idf.py set-target esp32c3
idf.py -p /dev/ttyUSB0 flash

Bug prevalence
Everytime I try to flash an example
GitHub hash of the SDK that was being used
Espressif
Platform
esp32
Platform Version(s)
No response
Anything else?
Screenshot of error message

(Already tried to reinstall ESP-IDF)

Please refer to the note here mentioned in step 3. Please give a try by doing the steps below:
cd ~/esp/esp-idf
./install.sh esp32c3  (for esp32c3 as target)
. ./export.sh
cd path/to/esp-matter
./install.sh
. ./export.sh

Already tried these steps but it gave me the same error so I decided to start from the beginning.
Following the document mentioned before, I started with the 2.1.1 Host Setup (I tried to use a virtual enviroment with Ubuntu 22.04 LTS and also a Raspberry Pi 3 also with Ubuntu Server 22.04 LTS), I was able to follow the Prerequisites for ESP IDF (version 4.4.4 for esp32c3) without a problem but I can't say the same for the Prerequisites for Matter.
First, the link does not work (it redirects you to a non-existing github site) I was able to find the webpage in another site.
The first command git clone --recurse-submodules git@github.com:project-chip/connectedhomeip.git pops up an error related with the permission (publickey, I've done a research and is something that I have to configure) so I used a similar command that I believe it does the same git clone --recurse-submodules https://github.com/project-chip/connectedhomeip.git. After that I continued with the Prepare for building section (the Synchronizing submodules and Prerequisites  sections didn't gave me problems) where it appeared a new error related with the ./enviroment/env_root.txt when I run the command: source scripts/activate.sh.

@LinJiaDeng

First, the link does not work (it redirects you to a non-existing github website) but I was able to find the webpage in another site.

Thanks for reporting. We will fix the link.

The first command git clone --recurse-submodules git@github.com:project-chip/connectedhomeip.git pops up an error related with the permission (publickey, I've done a research and is something that I have to configure) so I used a similar command that I believe it does the same git clone --recurse-submodules https://github.com/project-chip/connectedhomeip.git.

You should just follow the pre-requisites from the connectedhomeip repo as mentioned. The other steps should be from the esp-matter documentation here
You can retry by deleting the esp-matter/connectedhomeip/connectedhomeip/.environment folder. If you still face issues, then please upload (and not paste) the set of entire commands you execute.

Hi @dhrishi, thanks for your response.
I was able to follow the pre-requisites from the connectedhomeip repository, but now I'm facing a new issue with the esp-matter documentation, specifically, when trying to flash the firmware.
Below it is attached a screenshot of the error and all the commands used, if you need more information, please let me know.

Commands used.txt

I've tried again entering the commands
idf.py set-target esp32c3
idf.py build
idf.py -p /dev/ttyUSB0 flash
And it worked, closing this post.


Draft: Starting Salesforce XGen model integration

Description: Salesforce recently released the LLM XGen. This change is to begin integration of the model into Langchain.
Issue: the issue # it fixes (if applicable),
Dependencies: transformers
Tag maintainer: @hwchase17 @baskaryan
Still new here so marking as Draft to ensure further development is okay. Mimicked design of llamacpp wrapper to start.

Yes- wasn't aware that class was made. Interestingly, uncovered some hangs in the tutorial notebook [#3275] so just opened the PR to fix. Closing this PR.


Check Apache Arrow Rust 6.2.0 RC1 failure

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.

Hi @alamb, After receiving your email about [VOTE][RUST] Release Apache Arrow Rust 6.2.0 RC1. I tested it and got the following error.
error: failed to prepare local package for uploading

Caused by:
  failed to select a version for the requirement `arrow = "^6.2.0"`
  candidate versions found which didn't match: 6.1.0, 6.0.0, 5.5.0, ...
  location searched: crates.io index
  required by package `arrow-flight v6.2.0

My testing environment is macOS Monterey.

Hi @xudong963  -- thanks for reporting this issue
I think this is the same problem as fixed in  https://github.com/apache/arrow-rs/pull/882 but which I did not backport to active_release (and thus it is not in the tarball). I will backport that now 🤦
FYI @andygrove  reported something similar

resolved in https://github.com/apache/arrow-rs/pull/949