ghostscript seg fault error with openGL export in R2013a

With the latest version of export_fig, I'm encountering an error trying to export to pdf using the OpenGL renderer in R2013a.  The error only occurs when running pre-HG2 versions of Matlab; thus far, all figures export without error in 2015a with any renderer (though due to several issues related to patch rendering with the new graphics, I need to stick with the older Matlab version to export publication-quality graphics).  Older versions of export_fig do not throw the error (I have the version dated 7/05/14 installed alongside a version I cloned yesterday, but I've made certain only one is on my path at any given time), and the painters renderer works fine in all versions.
The error:
figure
plot(1:10)
export_fig('test', gcf, '-pdf', '-opengl')

export DYLD_LIBRARY_PATH=""; "/usr/local/bin/gs" -q -dNOPAUSE -dBATCH -sDEVICE=pdfwrite -dPDFSETTINGS=/prepress -sOutputFile="test.pdf" -dEPSCrop -sFONTPATH="/usr/share/fonts:/usr/local/share/fonts:/usr/share/fonts/X11:/usr/local/share/fonts/X11:/usr/share/fonts/truetype:/usr/local/share/fonts/truetype" -f "/private/tmp/tpf998dea4_aac5_42f3_aaaf_2aa12ec47112.eps": Segmentation fault
/bin/bash: line 1: 39072 Segmentation fault: 11  "/usr/local/bin/gs" -q -dNOPAUSE -dBATCH -sDEVICE=pdfwrite -dPDFSETTINGS=/prepress -sOutputFile="test.pdf" -dEPSCrop -f "/private/tmp/tpf998dea4_aac5_42f3_aaaf_2aa12ec47112.eps"
export DYLD_LIBRARY_PATH=""; "/usr/local/bin/gs" -q -dNOPAUSE -dBATCH -sDEVICE=pdfwrite -dPDFSETTINGS=/prepress -sOutputFile="test.pdf" -dEPSCrop -f "/private/tmp/tpf998dea4_aac5_42f3_aaaf_2aa12ec47112.eps": Segmentation fault
Ghostscript error: perhaps test.pdf is open by some other application
export_fig error. Please ensure:
  that you are using the latest version of export_fig
  and that you have Ghostscript installed
  and that you do not have multiple versions of export_fig installed by mistake
  and that you did not made a mistake in the expected input arguments

If the problem persists, then please report a new issue.

Error using eps2pdf (line 149)
/bin/bash: line 1: 39069 Segmentation fault: 11  "/usr/local/bin/gs" -q -dNOPAUSE -dBATCH
-sDEVICE=pdfwrite -dPDFSETTINGS=/prepress -sOutputFile="test.pdf" -dEPSCrop
-sFONTPATH="/usr/share/fonts:/usr/local/share/fonts:/usr/share/fonts/X11:/usr/local/share/fonts/X11:/usr/share/fonts/truetype:/usr/local/share/fonts/truetype"
-f "/private/tmp/tpf998dea4_aac5_42f3_aaaf_2aa12ec47112.eps"

Error in export_fig (line 569)
                eps2pdf(tmp_nam, pdf_nam, 1, options.append, options.colourspace==2,
                options.quality, options.gs_options);

Running on Mac OS X 10.9.5, Matlab R2013a, Ghostscript 9.10.

I do not have access to Mac so it is difficult for me to trace the problem. Email me (altmany at gmail) the referenced temporary EPS file (/private/tmp/tp*.eps) and I'll try to check it.

Matlab's built-in print() function (which is used internally by export_fig) creates a huge temporary EPS file (200MB), which is then used to create the PDF. This huge file is also the cause of the slow export, which I am sure that you have noticed. This temporary file, large as it may be, is valid and processes well on my Windows using GS 9.14. So try upgrading your GS version, maybe this will help.
In any case, since we cannot help Matlab's generation of this huge file, and since the file does appear to be valid (at least for GS 9.14 on Windows), I am closing the issue.


compile error.

I was following the getting started instructions, however '$ cmake ..' fails:
In file included from /mnt/vbox/shared/github/seasocks/src/main/c/Connection.cpp:49:0:
/mnt/vbox/shared/github/seasocks/src/main/c/Connection.cpp: In member function ‘bool seasocks::Connection::sendError(seasocks::ResponseCode, const string&)’:
/mnt/vbox/shared/github/seasocks/src/main/c/Connection.cpp:696:22: error: ‘HANDLING_HIXIE_WEBSOCKET’ was not declared in this scope
     assert(_state != HANDLING_HIXIE_WEBSOCKET);

I changed it to get it to compile:
$ git diff
diff --git a/src/main/c/Connection.cpp b/src/main/c/Connection.cpp
index ca760cf..405e7e4 100644
--- a/src/main/c/Connection.cpp
+++ b/src/main/c/Connection.cpp
@@ -693,7 +693,7 @@ void Connection::handleWebSocketBinaryMessage(const std::vector<uint8_t>& messag
 }

 bool Connection::sendError(ResponseCode errorCode, const std::string& body) {
-    assert(_state != HANDLING_HIXIE_WEBSOCKET);
+    assert(_state != State::HANDLING_HIXIE_WEBSOCKET);
     auto errorNumber = static_cast<int>(errorCode);
     auto message = ::name(errorCode);
     bufferResponseAndCommonHeaders(errorCode);

Whoops; fixing! Apologies.


Go implementations of airgap upgrade for automate HA

Descriptions
context

our ruby code of upgrade is not smart enough to determine whether it is offline env or not, it will try to download arigap bundle from internet even though airgap bundle had been passed.

ToDo

we need to take care of all the flags in golang code, we will not paas any flag to ruby code, only deploy command will called if --skip-deploy is not passed.

Acceptance
Ruby code will not get flags and bundles should not be downloaded.

Pr: https://github.com/chef/automate/pull/6551


Move to new forwarding api's

Current dependencies on/for this PR:

main

PR #75

PR #76   👈

This comment was auto-generated by Graphite.


fix: improve unexpected plugins validation errors handling

Right now, if an unexpected error like a panic happens during plugins validation via goks, an Internal Error is returned to the user with no explanation about the nature of the error. For example:
{
    "code": 9,
    "message": "unmarshal kong plugin validation error: invalid character 'r' looking for beginning of value"
}

This commit makes sure Koko logs the original error and returns a slightly nicer 400 to the user, like:
{
    "code": 3,
    "details": [
        {
            "@type": "type.googleapis.com/kong.admin.model.v1.ErrorDetail",
            "messages": [
                "(ip-restriction) unknown plugin validation error, please file a bug with Kong Inc"
            ]
        }
    ],
    "message": "validation error"
}

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


'none' as a ColorExpression result produces an error after #15906

TL;DR https://openlayers.org/en/v10.0.0/examples/osm-vector-tiles.html is broken
In v9.2.4 and earlier, OpenLayers supported* 'none' as the result of a ColorExpression in a FlatStyle. For example, see the official v9.2.4 OSM Vector Tiles example (Ctrl+F 'none').
After #15906, such usages fail during style building with Error: failed to parse "none" as color; see the same OSM Vector Tiles example with OL v10.0.0.
I cannot find anywhere in the current documentation (other than the OSM example) or type definitions that suggests 'none' could be an acceptable ColorLike value. However, the source code appears to contain special handling for 'none' in a couple of places. If I understand the #15906 changes correctly, these ifs will always evaluate to false and their inner blocks are unreachable in v10.0.0.
Either

'none' should be supported, so the documentation should mention it and some of the code added by 15906 should be edited, or
'none' should be unsupported, so the OSM Vector Tiles example should be edited and any code with special handling can be removed.

I am not familiar enough with this project to recommend one option over the other. My own code has not been affected by this issue; I only noticed it in the example. I have not checked if there are more examples affected by this.
*Even in v9.2.4, I think using 'none' resulted in some unexpected code paths, like ColorType not being added to the type during expression parsing.

the documentation should mention it

It is documented for its original intended pupose in 'text-fill-color' where it allows a no fill, no hit detection override of the default '#333'.

Updated the documentation to mention the 'none' fill everywhere, not just on text-fill-color.


Create a night builds

As per last sig we would like to have nightly releases

@obecny are you working on this or up for grabs?

leaving it for "up for a grabs" until I do few other things, so someone else might be interested in this, if not until I have "free" slot then will get back to it

Would we prefer to release "nightly" once per day, or release a git sha version like `0.10.2-alpha.0+${SHA}`` every time master is merged?
In both cases, https://github.com/lerna/lerna/tree/master/commands/publish#--canary can be useful for this.


User is not able to list charts/apps/repos in Dashboard and error seen in console/request

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Deploy a master-head rancher in a HA setup.

Navigate to Dashboard --> Apps

Charts/Apps/Repos are not listed.

Request sent while loading the page: https://<rancher-server>/v1/catalog.cattle.io.clusterrepos/rancher-partner-charts?link=index

Response:
{"type":"error","links":{},"code":"ServerError","message":"converting (url.Values) to (v1.GetOptions): unknown conversion","status":500,"type":"error"}

Expected Result:
User should be able to list Charts/Apps/Repos on dashboard
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-head commit id: 4ff98cc6
Installation option (single install/HA): HA

I am getting the charts in Rancher version: master-head (09/09/2020) 4ff98cc603ea47528062ee6994d2a5e58a29ed5a

HA k8s
Single Docker install

The last commit I have this working is master-head (09/08/2020) _ f7f8e8bb0649e6f163bd6ba2118622a9889236ce_

On master-head - commit id: c63f8fda

User is able to list Apps/repos.
No error is seen.


Addon upgrade flux 2.4

This update includes all the necessary changes to upgrade Flux to its 2.4 GA version, ensuring compatibility and enhanced functionality for the addon. The key changes are:

Integration of the Notification Controller: The Notification Controller is now included, enabling centralized event management within Flux and adding associated parameters for proper configuration.
Resource Parameter Customization: Support for customizing requests and limits values has been implemented to optimize resource usage for controllers.
CRD Updates: Custom Resource Definitions (CRDs) have been updated to reflect changes and improvements introduced in Flux 2.4 GA, ensuring compatibility with the new version.

Some practices, such as priorityClassName, securityContext, and terminationGracePeriodSeconds, were not implemented as they are currently not supported by the webservice component type. Discussions regarding their support are still ongoing in the community, as referenced in kubevela/kubevela#5580.
I would appreciate clarification on what types of tests should be run to ensure the changes meet the project's merge requirements. This would help validate the implementation further and ensure compatibility across different environments.

oops, sorry the conflict happen when I merged other PR

oops, sorry the conflict happen when I merged other PR

No worries, already fixed it


Add gov proposal type to modify CW->ERC pointer registration

Describe your changes and provide context
Add new proposal types to register/unregister CW->ERC pointers, similar to what we already have in gov for ERC->CW pointers.
Testing performed to validate your change
unit test

Codecov Report
Attention: Patch coverage is 31.37255% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 60.54%. Comparing base (c92dc5f) to head (3d387bf).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1691      +/-   ##
==========================================
- Coverage   60.81%   60.54%   -0.27%
==========================================
  Files         368      368
  Lines       26857    26955      +98
==========================================
- Hits        16332    16320      -12
- Misses       9411     9524     +113
+ Partials     1114     1111       -3

Files
Coverage Δ

x/evm/gov.go
100.00% <100.00%> (ø)

x/evm/types/codec.go
51.35% <100.00%> (+1.35%)
:arrow_up:

x/evm/handler.go
10.81% <0.00%> (-1.32%)
:arrow_down:

x/evm/keeper/pointer.go
89.63% <40.00%> (-6.99%)
:arrow_down:

x/evm/types/gov.go
7.85% <3.57%> (-2.86%)
:arrow_down:

... and 1 file with indirect coverage changes


Ignore all files in the screenshots folder.

Apple supports both PNG and JPEG files for screenshots. The current recommendation only ignores PNG files. All files in the screenshots folder should be ignored. This change matches the recommendation on gitignore.io.

That's great, thanks @benhanzl :+1:


Coverage update

Description
Trying to update the coverage report to exclude the test files and lines which should be skipped like type checking lines.
Todos
Notable points that this PR has either accomplished or will accomplish.

[x] exclude test files
[ ] exclude lines like type checking

Questions

[ ] Question 1 ..

Status

[ ] Ready to go

Developers certificate of origin

[ ] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

Codecov Report

Merging #871 (1441f8d) into main (512aacc) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@jthorton would you mind if I merged here so I can get #832 in ASAP?

@hmacdope did it actually work? I still see the test file coverage on this branch https://app.codecov.io/gh/choderalab/asapdiscovery/pull/871/tree/asapdiscovery-alchemy/asapdiscovery/alchemy/tests

no it did not by the looks of things.

Note sure how to get this to work will close for now.


Add 1.11.0-rc1

Adds fault_domain_enabled for DC/OS 1.11 to run.sh of bootstrapper.
PR into main for testing.

Oops, wrong base!


Need some help... Is it possible to extend it to be a multiagents version??

Really thankful for your work. The code is neat and simple, which help a python beginner like me a lot.
After run the example in the notebook folder, I'm now trying to extend it to be a multiagents version by simply replicate multiple copy of the DiscreteDeepQ.
However, I encounter some error of the namescope in DiscreteDeepQ.
I try to solve the issue by add agent id to the namescope. I not quite sure if it's the 'correct' way to solve.
Would it mass up the storage data of the network? Or the problem can be solved by these simple solution?
Ps. The program can be successfully compiled, but the agent seems to just move randomly...

Hey, I would like to work on this issue. This is my first time to open source.


Infinite scrolling

I believe infinite scrolling would work well on the feed. We could do some tests.

@lyoshida  I would suggest first to implement #21 and #34 first, now that we have implemented the ?type= parameter. And then go with this issue and #32.


Wrong swagger versioning - always 1.1.1

Firstly i installed 1.8.3 (did not notice docker specified this one) and started testing how to migrate myself via API from bitBucket and add topics. Was getting 404 but had properly used API for adding topics.
I was using documentation from try.gitea server which stated it's version 1.1.1 After a while I found there is API documentation for each installation and my v 1.8 did not have topics yet. Upgraded to 1.9 and it did not have topics yet (still 1.1.1). Then upraded to beta 1.10 and finally in my copy of swagger i had my dreamed of topics. But docs is still 1.1.1
My suggestion is just to update version of docs as it changes. Because different docs revisions have same version number which can be confusing
Trying it out now and it seems (for API) not so painless one would say, but i still think gitea is great from what I see! ❤

Gitea version (or commit ref): 1.9.2/1.10.x
Git version: does not apply
Operating system: does not apply
Database (use [x]):Does not apply
Can you reproduce the bug at https://try.gitea.io:

[x] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist: Does not apply

Description

reverence: https://github.com/go-gitea/gitea/pull/3572/files#r205924980

half working solution:
if you replace 1.1.1 with {{AppVer}}
at https://github.com/go-gitea/gitea/blob/master/routers/api/v1/api.go#L12
It works with stable versions but on dev the '+' mess around and you get 1.11.0+dev-517-g1ea447aed  for example

closed by #14654

It works with stable versions but on dev the '+' mess around and you get 1.11.0+dev-517-g1ea447aed for example

tracked in #14706


Flash during MDX editor preview

When toggling the preview panel on the MDX editor there will be:

A loading indicator while the preview is rendered server-side.
After the loading is finished, the blog will be rendered correctly.
After this finishes, Remix will reload the page in order to ensure everything is up-to-date.

The issue is that the reload on step 3 will cause the preview to be re-rendered and cause a flash of the preview content.
Might need to cancel the refresh in order to prevent this. There is an unstable unsafe_shouldReload api for this, sounds like this might change in the future.

Fixed after migrating to Markdoc.


Add: . Dark and Light Mode Support

Since I am already using a dark theme for Monaco Editor, extend the dark and light mode to the entire app for a cohesive look. Add a dark mode toggle button, making the UI more customizable.

please assign to me @aayushai

Sure! @thevashuydv

tried switch the editor to light mode too, but I didn't look quite good

@thevashuydv can you add previews of both the editor and whole page going light and dark mode also.

@aayushai  sure

these were the light and dark modes

@aayushai please tell which one look fine

For the dark mode can you add the dark mode in the code editor conatiner where the Input Language text is coming and change the color of Input Language accordingly.
For the light mode don't make the whole editor white maintain a slightly pale shade of white for editor sector.
When in light mode also change the color of Convert button and the Cliploader if it is not visible.

@aayushai  okayy

raised a new pr , kindly review

Hi @thevashuydv ,
Convert button is not visible in light mode and the code editor is set to white color, I asked to set it to a different shade like pale white or off-white.

@aayushai  on it buddy

@aayushai done buddy , kindly review

@thevashuydv It has been merged.


impr:  optimize countGsm7bitExt function

Removed for loop from countGsm7bitExt. We can check the text with regex using the match method. We will still return length or 0.

Hey @c-o-x, thanks for the PR.
We will release a new minor version of this library after a little refactor, please change the base branch to new-version for your changes to be merged.

Again, thank you @c-o-x


NBA FANTASYDRAF is not working

Hello, how are you?
I have tried to use nba fantasydraft optimizer using the csv from superdraft.
And I have got incorrect csv error.
Also I tried to use load players from players list.
And I am getting yahoo result instance of fantasy_draft
optimier = get_optimizer(Site.FANTASY_DRAFT, Sport.BASKETBALL)
I have used above code
Please help me.
Thanks

optimizer is spelled wrong


Website parsing error:

Netflix add-on version
Kodi 21 (Omega)
Operative systems used
Android
Kodi version used
Other (specify in description)
Description of the bug
The extension ont start. There is message:
Website parsing error: unable to extract reactContext.
Kodi 21 (Omega)
Steps to reproduce the behavior
No response
Debug log - mandatory
https://paste.kodi.tv/ojazafavok
Possible fix
No response
Additional context
No response
Screenshots
No response

Netflix add-on version
1.23.3

It's probably the same as #1706.

My daughter was able to login and watch video with her subscription after I applied the following fix https://github.com/biocoder-frodo/plugin.video.netflix/commit/f31989d013d32e04de495703152d35523f076cd3


Night mode doesn't work if disable post processing is enabled first

possible fix could just be a simple check for if night mode is finished "activating" (because it slowly goes dark) and then enabling it upon config load or adding a notice when hovering over disable post processing

possible fix havent tested it too much but seemed to work:
`static bool bPostProcessingDisabled = false;
static float postProcessingDisabledTime = 0.0f;
void WORLD::PostProcessingRemoval()
{
static bool* bOverridePostProcessingDisable = reinterpret_cast<bool*>(MEM::FindPattern(CLIENT_DLL, Q_XOR("80 3D ? ? ? ? ? 53 56 57 0F 85")) + 0x2); // @xref: "mat_software_aa_strength", "dev/engine_post_splitscreen", "dev/engine_post"
// Check if night mode is enabled
bool bNightModeEnabled = C::Get<bool>(Vars.bVisualWorld) && C::Get<bool>(Vars.bVisualWorldNightMode);

// Determine whether to enable or disable post-processing based on conditions
bool bEnablePostProcessing = (!bNightModeEnabled || (bPostProcessingDisabled && (I::Globals->flFrameTime - postProcessingDisabledTime >= 1.0f)));

// Update the timer if we just disabled post-processing
if (bNightModeEnabled && !bEnablePostProcessing)
{
	bPostProcessingDisabled = true;
	postProcessingDisabledTime = I::Globals->flFrameTime;
}

*bOverridePostProcessingDisable = bEnablePostProcessing && (C::Get<bool>(Vars.bVisualWorld) && (C::Get<unsigned int>(Vars.nVisualWorldRemovals) & VISUAL_WORLD_REMOVAL_FLAG_POSTPROCESSING));

}`

known issue and regarding to base i don't really want to fix this. but thanks for your efforts you put on this


Add metadata registry

Need to support a md5, sha1, sha256 hash database consisting of hashes and component information.
Registry should be a combination of user editable within the UI (or via REST), as well as provide metadata replicated from Maven Central and potentially other repositories (npm).
Refer to:
https://repo1.maven.org/maven2/.index/
https://github.com/apache/maven-indexer
<dependency>
    <groupId>org.sonatype.nexus</groupId>
    <artifactId>nexus-indexer</artifactId>
    <version>3.0.4</version>
</dependency>

Database should be searchable via UI as well as a REST service that accepts hashes as input and provides component metadata in response.
To compliment service, an analyzer needs to be created for Dependency-Check.

Download from Central is ~400MB compressed. Uncompressed Lucene index is ~3.5GB
https://repo.maven.apache.org/maven2/.index/
https://maven.apache.org/repository/central-index.html

no longer needed as remote repositories have been introduced in v3.1 to retrieve metadata without having to replicate.


Browser client should use http

This will allow us to check status codes :)

class AngelBase {
  final http.BaseClient inner;
}

This would mean that browser and io could share a base... Which means easier testing :)


fix: add patch for react-native-get-random-values

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bugfix

What is the current behavior? (You can also link to an open issue here)
When running generator it builds but upon running yarn ios it breaks with error message related to duplicates.
Ref: https://github.com/expo/expo/issues/15649

What is the new behavior (if this is a feature change)?
It adds on the build pipeline a new function at the end that adds to the patches directory the needed patch to overwrite a header file in react-native-get-random-values

Other information:
--

can we merge?


dartdoc for parseIPv6Address ends up with an emoji

As seen on https://api.flutter.dev/flutter/dart-core/Uri/parseIPv6Address.html
::1
FEDC:BA98:7654:3210:FEDC:BA98:7654:3210
3ffe:2a00💯7031::1
::FFFF:<IP_ADDRESS>
2010:836B:4179::836B:4179

I think it'd be sane to just add backtics around the addresses to code-format them.

Opened  https://dart-review.googlesource.com/c/sdk/+/109317

Good catch. I'll accept the CL for now, and take it up with the DartDoc people.
I was not aware that DartDoc supported Github emoji syntax like :100: (:100:), and I'm not sure it should.

I'm afraid it might be part of the Markdown parsing stuff.  @jcollins-g or @kwalrath might know more.

It is part of the Dart Markdown package, but it is an optional extension that we don't have to have enabled.


Test PR2: Dont merge

Task name:
Description:
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

-azp run

/azp run

/azp run

/azp run


Add drop aware sender new type (fixes #13242)

Fixes #13242

@mattsse should I label the fn new as const as directed by lint?

yep,
and cargo +nightly fmt

@mattsse can you please enable the workflow for this PR.


How to use a different directory for .env files ?

We need to create many environment.

We want to store env file under folder config/env.
We might use javascript file in config/env/staging.js because .env seems to be only for root directory.
We have real development/staging/preproduction/production environmnent.
We expect the default environment to be a default config under version control in config/env/default.js, it must be the default configuration used when doing npm start
We expect the user to be able to override with a file with no version controle. (something like config/env/default.local.js

What is the best strategy for us, without ejecting ?

You can't change the location of the .env files without ejecting. However, you can create an environment variable that tells your app which config file to load. For example, REACT_APP_MY_ENV=staging yarn start. Then in your app code you can load config/env/${process.env.REACT_APP_MY_ENV}.js.

I am answering my own answer but this is how we did :
Just copy the environment file to .env before starting / building. You can even put .env in .gitignore that way
"start": "cp ${ENV:-src/config/env/.env.default} .env && react-scripts start"

Then run it:
ENV=config/staging/.env npm start


Tax Amount

It would be really good if the tax amount could be passed as a separate line item in Thawani since Thawani currently does not support taxation. It would display the customer that they are paying this much as tax.

It would be really good if the tax amount could be passed as a separate line item in Thawani since Thawani currently does not support taxation. It would display the customer that they are paying this much as tax.

Thank you @ghulamostafa I will highlight this to the team

@ghulamostafa I marked this issue as won't fix and that is due to Thawani policy of not accepting less than 100 baisa products and if the total price is less than that 2 rials( tax will be less than 100 baisa) the endpoints will fail


In Safari, cannot preserve appearance of link while dragging

I am trying to preserve the appearance of a div containing an  tag while dragging it. In Chrome and Firefox, I have no trouble, but in Safari, when I begin dragging the element, its appearance changes to the native browser implementation of a dragged link.
I verified the discrepancy in Safari by cloning your repo and changing the markup in react-dnd/examples/02 Drag Around/Naive/Box.js to include an  tag (see diff below).
Even with that change, Chrome and Firefox are still able to show the original image while dragging.
Running OS X Yosemite (10.10.5)
Browsers:

Safari: 9.0.1 (106<IP_ADDRESS>)
Chrome: 46.0.2490.86 (64-bit)
Firefox: 42.0

Moved to https://github.com/gaearon/react-dnd-html5-backend/issues/11.

FYI—closed as wontfix because apparently we can't fix it.
https://github.com/gaearon/react-dnd-html5-backend/issues/11#issuecomment-167253149


Mitigate DatasourceError grafanacloud-logs A Hypothes.is rate limiting false positives

The 'Edit rule' Grafana UI for this alert is https://sciety.grafana.net/alerting/H542stS4k/edit?returnTo=%2Falerting%2Fgrafana%2FH542stS4k%2Fview
Step 3: Alert evaluation behavior has a field Alert state if execution error or timeout that is currently set to Error. The other options for this field are Alerting and OK.
The current for field value of 5 min indicates that the alert will be pending for 5 minutes before sending switching to the Alerting state and sending an email

Looking at the false positive emails only, they are usually recovered from within 5 minutes. Probably this is even faster, and we don't receive emails due to default notification policy being configured not to send emails more frequently than 5 minutes.
Hypothesis to test: if we change the configured threshold duration (for label) to extend it to 15 minutes, the alert instance state might be able to recover from Error before the state of the alert goes from Pending to Alerting; and we wouldn't receive an email.
Changed on 2023-04-20 11:09.

Some documentation of alert rules & instances at https://grafana.com/docs/grafana-cloud/alerting/fundamentals/state-and-health/

Received email:
[FIRING:1] Sciety (DatasourceError grafanacloud-logs A Hypothes.is rate limiting) alert
at 4:35 PM. Resolved email at 4:40 PM, so first attempt at mitigation didn't succeed.

The email has these labels:
alertname | DatasourceError
datasource_uid | grafanacloud-logs
grafana_folder | Sciety
ref_id | A
rulename | Hypothes.is rate limiting

so https://community.grafana.com/t/alerting-notification-policy-datasourceerror-datasourcenodata/59638 may be right in suggesting that a filter on the notification policy of alertname != DatasourceError might be ok to silence these or to then route them to another channel.

Attempting to remove notifications when there is an execution error, we changed the value of:
3. Alert evaluation behavior > Configure no data and error handling > Alert state if execution error or timeout

from Error to OK in the drop down.


Adjust least upper bound to avoid spurious loss of precision

The language specification says:
Let $U$ be a type variable with upper bound $B$.
The least upper bound of $U$ and a type $T \ne \bot$ is
the least upper bound of $B$ and $T$.

This causes an unnecessary loss of typing information:
bool b = ...;

class C<U, T extends U> {
  // The type of `x` is List<Object>.
  var x = b ? <U>[] : <T>[];
}

The type of x is List<Object> because the bound of U is Object, T is not bottom, and LUB(Object, U) is Object. But given that T <: U we could have used the more informative type List<U>.

Closing: Obsolete. Check out this topic.


small formatting mistake in docs

in http://ninenines.eu/docs/en/cowboy/2.0/guide/req/
where it says
 Read more about constraints

constraints is formatted as a exponent or something similar, I think you wanted to make it a link?

lol
Well that's an oversight from converting to asciidoc I guess. Should be an xref link.

That one is also fixed, thanks!


disable withdrawal button until withdrawBlock comes

Pull Request Test Coverage Report for Build 750

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.47%

Totals

Change from base Build 748:
0.0%

Covered Lines:
92

Relevant Lines:
103

💛  - Coveralls


Bug on offers ordering in job board and html tags on preview

overrided get_queryset method for job list to order posts by pk, fixe…d list template avoiding bothering stuff with safe filter and html tags in description preview

Done


liquibase core tar.gz missing from maven central?

Environment
Liquibase Version: Since 4.6.2
Liquibase Integration & Version: Maven dependency for liquibase tar.gz
Liquibase Extension(s) & Version: N/A
Database Vendor & Version: N/A
Operating System Type & Version: N/A
Description
It seems like since version 6.1.2 there tar.gz artifact is no longer published to maven central. I tried to search the forums, stackoverflow and other websites through google but I couldn't find anything that pointed me to a possible change/notice. Am I missing anything here? My apologies if this is not the place to ask.
Steps To Reproduce
N/A
Actual Behavior
tar.gz not available.
Expected/Desired Behavior
The tar.gz should be available.
Screenshots (if appropriate)
Example for 4.8.0: https://repo1.maven.org/maven2/org/liquibase/liquibase-core/4.8.0/

Additional Context
N/A

@DiogoParrinha Thanks for alerting us to this.  We will look into why it no longer is added.

Can you download from here directly instead with your curl or wget command that you are using today?
https://github.com/liquibase/liquibase/releases/download/v4.9.1/liquibase-4.9.1.tar.gz

Can you download from here directly instead with your curl or wget command that you are using today? (4.9.1, 4.8.0, 4.6.2 links respectively below) https://github.com/liquibase/liquibase/releases/download/v4.9.1/liquibase-4.9.1.tar.gz https://github.com/liquibase/liquibase/releases/download/v4.8.0/liquibase-4.8.0.tar.gz https://github.com/liquibase/liquibase/releases/download/v4.6.2/liquibase-4.6.2.tar.gz

Hello! I can but the point was to include liquibase tar.gz dependency into an assembly file for a given product 😁 curl or wget will work as a workaround but will require deployment pipeline changes. Those using older versions won't be able to update without this issue

Thanks for the explanation @DiogoParrinha . At this time, we are not planning on putting these files into maven central.
I'd like to keep this issue open here so that others can share with us if this is an issue for them and we can re-evaluate at a later date.
Feel free to also ask on the forum  to see if others are facing this. Thanks!

This also applies for the zip attachment. In the past it was super convenient to download/install Liquibase CLI using Maven tooling as shown below. Downloading from Gitlab might be restricted for internal (e.g. CI) systems.
<plugin>
   <groupId>org.apache.maven.plugins</groupId>
   <artifactId>maven-dependency-plugin</artifactId>
   <executions>
      <execution>
         <id>unpack-liquibase</id>
         <phase>prepare-package</phase>
         <goals>
            <goal>unpack</goal>
         </goals>
         <configuration>
            <artifactItems>
               <artifactItem>
                  <groupId>org.liquibase</groupId>
                  <artifactId>liquibase-core</artifactId>
                  <type>zip</type>
                  <version>${liquibase.version}</version>
               </artifactItem>
            </artifactItems>
            <outputDirectory>${project.build.directory}/dist/liquibase</outputDirectory>
         </configuration>
      </execution>
   </executions>
</plugin>

How is this possible now?
How do we download the batch file using maven?

The only way now is to build your own tar.gz with the liquibase cli and its dependencies inside. You can use appassembler-maven-plugin for instance to generate the executable


Set experiment group key from context metadata

The group keys for class, school, and instructor are right now hardcoded as "class", "school", and "teacher". We need to have a way to define custom keys for class/school/instructor. We can add this detail in the context metadata.

Yes - the spec here https://docs.google.com/document/d/13SvJajnCcH0cqMD7gPqb5MWmynzJrVqmD5a5tooPeNo/edit#heading=h.ytlzcnrrqnwt has the group types specified in the metadata (for each AppContext).

Closing this; @SritterCL will be opening a related issue.


Bug: sdk selfupdate fails at line 92 when tmp directory does not exist

Bug report
sdkman should check that the tmp directory exists before writing to it
output
Updating SDKMAN...
Installing script cli archive...
* Downloading...
bash: line 92: ~/.sdkman/tmp/sdkman-5.16.1.zip: No such file or directory
'curl --fail --location --progress-bar "$download_url" > "$sdkman_zip_file"': command failed with exit code 1.

To reproduce
delete the tmp directory in ~/.sdkman/ and run sdk selfupdate
easy work-around
mkdir ~/.sdkman/tmp
and then rerun.
Users should not have to do this, though. The cause of the error is not obvious, and creating the tmp directory was just a guess. tmp directory and files in it should be managed, and should not be assumed to exist. This occurred for me after restoring from a backup which excluded tmp directories.
System info

OS: Fedora 37
Shell: GNU bash, version 5.2.15(1)-release (x86_64-redhat-linux-gnu)
The output of sdk version

script: 5.16.1
native: 0.1.0

Hi @travisfw,
I honestly don't think this is a bug. In short, never delete folders or change files in the sdkman directory. If you do, you do so at your own risk. If you want to clear out the temp folder, be sure to read the help we provide here:
sdk help flush

In short, never delete folders or change files in the sdkman directory.

You misunderstand.
I have had no need for flushing the temp files on demand.
It's really quite reasonable for backup and sync systems to skip tmp dirs and caches.

I recommend not deleting that folder, since it isn't a cache but a temporary workspace. This is much like the /tmp or /var/tmp directories that would cause huge issue on your Linux distro if they were removed. Everything in the .sdkman folder should be backed up.


Rancher Azure Active Directory : Missing /verify-auth-azure in docs

When configuring Azure Active Directory,  the sign on URL needs to contain /verify-auth-azure in the path, otherwise, the integration fails.
Can the screenshot be updated to capture the same (http://rancher-server-url/verify-auth-azure):
https://rancher.com/docs/img/rancher/new-app-registration.png

Thanks, this is covered in https://github.com/rancher/rancher/issues/14741

Fixed docs and the next release (v2.1) should have  UI fix to make it more obvious.


Extras installation is broken since v1.0.0

Description
With the changes introduced in v1.0.0 (specifically, in commit https://github.com/tomasfarias/airflow-dbt-python/commit/06e60258e9e1ff5e028b72047c406747b8f36924), specifying this package's extras does not install the optional dependencies.
It gets fixed when adding these lines back to the [tool.poetry.dependencies] section in pyproject.toml:
dbt-postgres = { version = ">=1.0.0", optional = true }
dbt-redshift = { version = ">=1.0.0", optional = true }
dbt-snowflake = { version = ">=1.0.0", optional = true }
dbt-bigquery = { version = ">=1.0.0", optional = true }
dbt-spark = { version = ">=1.0.0", optional = true }

This makes sense according to Poetry documentation:

The dependencies specified for each extra must already be defined as project dependencies.
Dependencies listed in dependency groups cannot be specified as extras.

However, I haven't created a PR for this, because I see that commit also created a Poetry adapters group, which could get broken with this change. Related Poetry issue: https://github.com/python-poetry/poetry/issues/4891#issuecomment-993816696
Steps to reproduce

Create a new virtualenv.
Run pip install 'airflow-dbt-python[snowflake] == 1.0.0'.
Check for the presence of dbt-snowflake, by running pip freeze | grep dbt-snowflake.

Additional context
Installing version 0.15.3 correctly installs provided extras:
$ pip install 'airflow-dbt-python[snowflake] == 0.15.3'
(...)
Successfully installed Babel-2.12.1 Jinja2-3.1.2 MarkupSafe-2.1.2 SecretStorage-3.3.3 agate-1.7.0 airflow-dbt-python-0.15.3 asn1crypto-1.5.1 attrs-22.2.0 betterproto-1.2.5 certifi-2022.12.7 cffi-1.15.1 charset-normalizer-2.1.1 click-8.1.3 colorama-0.4.6 cryptography-39.0.2 dbt-core-1.4.5 dbt-extractor-0.4.1 dbt-snowflake-1.4.2 filelock-3.10.0 future-0.18.3 grpclib-0.4.3 h2-4.1.0 hologram-0.0.15 hpack-4.0.0 hyperframe-6.0.1 idna-3.4 importlib-metadata-6.1.0 isodate-0.6.1 jaraco.classes-3.2.3 jeepney-0.8.0 jsonschema-3.2.0 keyring-23.13.1 leather-0.3.4 logbook-1.5.3 mashumaro-3.3.1 minimal-snowplow-tracker-0.0.2 more-itertools-9.1.0 msgpack-1.0.5 multidict-6.0.4 networkx-2.8.8 oscrypto-1.3.0 packaging-23.0 parsedatetime-2.4 pathspec-0.10.3 pyOpenSSL-23.0.0 pycparser-2.21 pycryptodomex-3.17 pyjwt-2.6.0 pyrsistent-0.19.3 python-dateutil-2.8.2 python-slugify-8.0.1 pytimeparse-1.1.8 pytz-2022.7.1 pyyaml-6.0 requests-2.28.2 six-1.16.0 snowflake-connector-python-3.0.1 sqlparse-0.4.3 stringcase-1.2.0 text-unidecode-1.3 typing-extensions-4.5.0 urllib3-1.26.15 werkzeug-2.2.3 zipp-3.15.0

$ pip freeze | grep dbt-snowflake
dbt-snowflake==1.4.2

For version 1.0.0, that's no longer the case:
$ pip install 'airflow-dbt-python[snowflake] == 1.0.0'
(...)
Successfully installed Babel-2.12.1 Jinja2-3.1.2 MarkupSafe-2.1.2 agate-1.7.0 airflow-dbt-python-1.0.0 attrs-22.2.0 betterproto-1.2.5 certifi-2022.12.7 cffi-1.15.1 charset-normalizer-3.1.0 click-8.1.3 colorama-0.4.6 dbt-core-1.4.5 dbt-extractor-0.4.1 future-0.18.3 grpclib-0.4.3 h2-4.1.0 hologram-0.0.15 hpack-4.0.0 hyperframe-6.0.1 idna-3.4 isodate-0.6.1 jsonschema-3.2.0 leather-0.3.4 logbook-1.5.3 mashumaro-3.3.1 minimal-snowplow-tracker-0.0.2 msgpack-1.0.5 multidict-6.0.4 networkx-2.8.8 packaging-23.0 parsedatetime-2.4 pathspec-0.10.3 pycparser-2.21 pyrsistent-0.19.3 python-dateutil-2.8.2 python-slugify-8.0.1 pytimeparse-1.1.8 pytz-2022.7.1 pyyaml-6.0 requests-2.28.2 six-1.16.0 sqlparse-0.4.3 stringcase-1.2.0 text-unidecode-1.3 typing-extensions-4.5.0 urllib3-1.26.15 werkzeug-2.2.3

$ pip freeze | grep dbt-snowflake
(no output)

Thanks for the detailed report. I've opened a PR to address this issue: we can keep both the dependency group for tests/development and re-add the adapters back to the main dependencies group.
A bit of history on 06e6025:
The idea of dropping adapters from dependencies was to simplify version resolution: Airflow and dbt-core already contain a lot of dependencies and adding adapters on top of that was making things worse.
However, now that we have dropped support for Airflow 1, I'm not seeing any version conflicts, except for having to set an upper boundary on Python <4.0 (see bottom for a note on upper boundaries). And version resolution is not too bad (took about 3.5 minutes on my machine, when it used to take >40 minutes when supporting Airflow 1). I've been playing around with pdm as of late, so I'll test out if migrating to that can result in quicker version resolution.
In retrospective, I do regret including adapters as dependencies in the first place: I intended them as a shortcut when installing airflow-dbt-python, but I didn't realize at the time that we were placing the burden of resolving dependencies on airflow-dbt-python. Sometimes we can run airflow-dbt-python even with conflicts, as the conflict could be in dbt-core's CLI logic or other parts we don't access (I wish dbt-core offered a light library alternative, there are some ongoing efforts apparently). So it doesn't make much sense for us to carry that burden.
However, it has become a bit of a feature at this point and I rather not break existing users while it's not a big problem.
A note on upper boundaries: I dislike upper boundaries except when completely necessary, even on something still far into the future as Python <4.0, but I recognize it's a small cost to pay for now.
As an example, before this PR we only had one upper boundary on pytest-postgresql = ">=3,<4" as newer versions of pytest-postgresql break our tests because they rely on psycopg3.


git graph very slow on huge codebase

I experience very slow git graph on very huge codebase.
It seems that there is missing a sensible limit on some point in order to make it more responsive.
I would argument, that you would mostly be interested in the recent history, rather than what banching has happened some 10 years ago.
EDIT: Last line of graph is:
171535

Hehe, thanks for reporting. I did not think of this as an issue but this is a problem when you have  150k  commits and even worse with a slow HDD. I am think that this can be configured and set a limit to 20k commit as default.
I opened 70k commits in 4 sec.
Copy from git log doc
   Commit Limiting
       Besides specifying a range of commits that should be listed using the special notations explained in the description, additional commit limiting may be applied.

       Using more options generally further limits the output (e.g. --since=<date1> limits to commits newer than <date1>, and using it with --grep=<pattern> further limits to commits whose log message has a line that matches <pattern>), unless otherwise noted.

       Note that these are applied before commit ordering and formatting options, such as --reverse.

       -<number>, -n <number>, --max-count=<number>
           Limit the number of commits to output.

       --skip=<number>
           Skip number commits before starting to show the commit output.

I guess you are referring to this config section:

    /*
        Update the desired graph arguments for a customized experience.
        Do not add "--all" in this setting, it is added in graph all branches

        NOTE: Changes you make may break in-view functionality, so use with caution.
     */
    // "git_graph_args": ["log", "--pretty=format:%h%d (%ar) by `%an` %s", "--graph"],
    "git_graph_args": ["log", "--oneline", "--graph", "--decorate"],

Actually I was think to add a new setting for git log commit limit. Also append a line last to load see the next 10 or 20k commits
page 1 git log --max-count=10000 --skip=0
●   6e96e92 (HEAD -> master, origin/master, origin/HEAD) (25 hours ago) by `Simon` a
|\
| ● 3ec06b8 (13 days ago) by `Simon` b
|/
●   bf5306a (25 hours ago) by `Simon` c
go to page 2

page 2 git log --max-count=10000 --skip=10000
go to page 1
●   6e96e92 (25 days ago) by `Simon` a
|\
| ● 3ec06b8 (26 days ago) by `Simon` b
|/
●   bf5306a (27 days ago) by `Simon` c
go to page 3

Even better! :smile: So my comment would be a workaround for now.

Yes, you can use that as a work around.


Fix nil Details field in Error reply

Fixes https://github.com/digitallumens/lightworks_router/issues/17


Fix crash with failed compatibility tiles

Fixes #77673
Opening the project now results in a spam of
 Cannot create tile. The tile is outside the texture or tiles are already present in the space the tile would cover.
  The TileSetAtlasSource atlas has no tile at (0, 0).
  C:\godot_source\scene/resources/tile_set.cpp:2612 - Condition "!tile_data" is true. Continuing.

Looks like some tile was too big or something, it failed to create, and TileData was null. Maybe there is a way to somehow restore the TileData, but for now this prevents a crash.

But occurs in 4.0.3 and seems trivial, should this be cherrypicked as well?

Thanks!

Cherry-picked for 4.0.4.


Draggable doesnt work with slot inside tempate #item

When working with slot inside tempate #item, draggable doesnt work. Slot elements are rendered but I cannot drag & drop
  <draggable
    v-model="myArray"
    group="people"
    @start="drag = true"
    @end="drag = false"
    item-key="id"
  >
    <template #item="{ element }">
        <slot name="default" v-bind="{ element }" />
    </template>
  </draggable>

As workaround, I wrap into slot a div to make it work.
  <draggable
    v-model="myArray"
    group="people"
    @start="drag = true"
    @end="drag = false"
    item-key="id"
  >
    <template #item="{ element }">
      <div>
        <slot name="default" v-bind="{ item: element }" />
      </div>
    </template>
  </draggable>

Sorry for not providing jsfiddle, I can't generate (see #23 )

Item should be element with only one root, this is why you need to add the extra div. Consider it as a permanent limitation.

it's word!


Feature Request - Expand all transaction data

Overview

option to 'expand all' for collapsed transaction data in tx table

And I assume this option would be somewhere right above the table in this area?

And I assume this option would be somewhere right above the table in this area?

Yea, I think a toggle should do the trick. There's a related bug where if you expand one row, that row remains expanded on data update and/or page navigation. We want the following behavior:

on expand row, disable live transactions (if enabled and on front page)
collapse rows if on first page and live transactions is toggled on
collapse rows on page navigation


[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:

[x] I have reviewed the documentation for AME onboarding.
[x] Validation tools have been run on swagger spec(s) updated and errors have all been fixed with this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

We’ve had this api version for a while but never got around to actually releasing the spec/clients for it since it was punted in priority. We would have to make code changes to rename it so I kept the name.

Thanks, @fengzhou-msft could you merge this when you get the chance?


C# SDK change with Hub's certificate and operation tasks

Description
Regenerated the SDK based off a new swagger and add/update the test cases for updated SDK.
Updated swagger PR

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: anusapan sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@azuresdkci test this please

@azuresdkci retest this please

@azuresdkci test this please

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


add typing for count elements

this change is required for php 7.2

@schmittjoh what do you think about it?

This hardly makes any sense because elements is always an array.


AWS KMS documentation Unclear

Description
When trying to use AWS KMS to sign my certs in fulcsio using awskms://[endpoint]/[arn] it took me ages to realize that the endpoint was optional, but the trailing / was not. It's not clear from the guidance that the correct prefix when not specifying the endpoint is awskms:///. The documentation does show examples of this, but I spent longer than I care to admit not noticing 3 slashes and assuming it was meant to be just 2.
There's also a lack of guidance around exactly what IAM role permissions you need in order to call AWS KMS from fulcio. I ended up reading through https://github.com/sigstore/sigstore/blob/main/pkg/signature/kms/aws/client.go to find the full list of commands that needed to be called.
The last point that is unclear is exactly how to go about setting up the certificate chain needed by fulcio to validate KMS. I'm using a Private CA to achieve this with some success, but its taken a very long time to figure out.

@ChevronTango how are you going about signing the Private CA w/ KMS?
we've tried using the ca and cert created via kms-issuerkms-issuer , but keep getting errors using x509: certificate specifies an incompatible key usage even tho we're following the correct spec via the certificate resource certificate resource:

https://github.com/sigstore/fulcio/blob/main/docs/certificate-specification.md

Can you specify your certificate chain?

Can you specify your certificate chain?

Yes, we've tried using a local key (which was then imported to KMS) to sign a Private CA created via openssl and that worked, but using kms-issuer hasn't seemed to work so far. We've tried including the CA it's created as well as the certificate it creates.
Any other suggestions in regards to creating/signing a Private CA using KMS?

An incompatible key usage means that the x509 library failed to build a valid chain. I would confirm that your root and intermediate specifies Certificate Sign and CRL Sign only.

An incompatible key usage means that the x509 library failed to build a valid chain. I would confirm that your root and intermediate specifies Certificate Sign and CRL Sign only.

hmm, i think it's because the CA it creates doesn't have the correct usages select. don't think this is something you can change using kms-issuer:
        X509v3 extensions:
            X509v3 Key Usage: critical
                Digital Signature, Certificate Sign
            X509v3 Extended Key Usage:
                TLS Web Client Authentication, TLS Web Server Authentication

ah, i was able to get it working using step-ca. cheers 🍻

My approach involved creating a simple CSR and using aws-kms-sign-csr to sign it. I then passed it to my root CSA and asked it to sign the CSR using the SubordinateCACertificate_PathLen0_APIPassthrough/V1 template. I gave it an ExtendedKeyUsageType of CODE_SIGNING and filled in all the usual subjects and common names.
The KMS key in particular was RSA_4096 and I passed it through to Fulcio using awskms:///<kms_arn> along with a certificate bundle containing both the root CA public key and the KMS intermediate public key.
I did all of this in terraform, but was able to achieve a nice reliable and repeatable pattern once I'd figured out all the steps I needed.


Block explorer UI edit: buttons

Make a selected state for the nav bar buttons

new component for the nav bar

https://user-images.githubusercontent.com/102996538/220485243-892205e6-4104-44fe-ac25-5f64b33b412f.mov
@hoffmannjan et al, take a look and see what you think of this

@megan-demit great work!

@hoffmannjan this seems generic enough that it could be part of the ui-kit.... WDYT?


[V2] innerRef doesn't work with styled(Component)

I am trying to set the ref for a <Input /> styled components.
The component has been created with const Input = styled(InputUnstyled).
I have the following react app:
function _objectWithoutProperties(obj, keys) { var target = {}; for (var i in obj) { if (keys.indexOf(i) >= 0) continue; if (!Object.prototype.hasOwnProperty.call(obj, i)) continue; target[i] = obj[i]; } return target; }

class InputUnstyled extends React.Component {
  render() {
      var _props = this.props,
          isOpen = _props.isOpen,
          rest = _objectWithoutProperties(_props, ["isOpen"]);

      return React.createElement("input", rest);
  }
}

const Input = styled(InputUnstyled)`
  font-size: 1.5em;
  text-align: center;
  color: palevioletred;
`;

const Wrapper = styled.section`
  padding: 4em;
  background: papayawhip;
`;

export default class App extends React.Component {

  constructor(props) {
    super(props);
    this.handleIsOpen = this.handleIsOpen.bind(this);
    this.state = { isOpen: false };
  }

  componentDidUpdate() {
     this.handleFocus();
  }
  componentDidMount() {
     this.handleFocus();
  }

  handleIsOpen() {
     this.setState({ isOpen: !this.state.isOpen });
  }

  handleFocus() {
     this.search.focus();
  }

  render() {
    return (
      <Wrapper>
        <button type="button" onClick={this.handleIsOpen}>Rerender</button>
        <Input type="text" isOpen={this.state.isOpen} innerRef={(search) => { this.search = search }} />
      </Wrapper>
    );
  }
}

Version
2.0.0-8
Reproduction
https://www.webpackbin.com/bins/-Kg-9xQ8QPTOnSFLmOOt
Steps to reproduce

Open the WebpackBin link.
Open your developer console.
Click on the button to trigger this.search.focus().

It will through an error in your developer console.
Expected Behavior
The <Input /> element should receive the :focus.
Actual Behavior
Throw error this.search.focus is not a function

I've just notice this bug was also present in 1.4.4 See https://github.com/styled-components/styled-components/issues/592

This is not a bug, but due to how the "innerRef" logic works. Once it's in the input props, it will pass it innerRef as ref to the underlying element , I.e. The unstyled component in your example.
Thus the component that renders Input will receive a ref, but it won't be the element, but the unstyled component itself. If you want the element ref then either add your own ref prop and set it on the component instance, so that you can access it with its ref, or use findDOMNode.

@philpl can you please elaborate I didn't really get it.
I have read here the recommendation.

add your own ref prop and set it on the component instance, so that you can access it with its ref

Could you please show a small example in the best case update the webpackbin to see how you would handle the problem ?

or use findDOMNode.

There is a warning if you use findDOMNode. You are not supposed to use findDOMNode as they won't work (haven't tried) in react-native. Styled-components is targeting full compatibility with react-native so it can't be the best solution for our components.
Is there any way to pass the innerRef through in case it's a styled components ? There is no reason to use innerRef if you target the styled components.
I suggest to reopen this. Or the doc must be updated at some point.

@kopax So the thing is, that we can't pass it through. We would have to expose innerRef and the wrapped component would have to accept innerRef and pass it as ref to one of the children. Otherwise we'd have to check what it renders, clone it, and pass that on, which is not even good in terms of correctness, since the user might render more than one element anyway.
Right now we directly pass innerRef as ref and thus you'll see your component instance as a ref, and not a DOM element.
Let's look at your example:
<Input type="text" isOpen={this.state.isOpen} innerRef={(search) => { this.search = search }} />

search in the callback will be the rendered instance of InputUnstyled.
If you want to get a DOM ref you could do:
class InputUnstyled extends React.Component {
  render() {
    const { isOpen, ...rest } = this.props
    return <input ref={input => this.ref = input} {...rest} />
  }
}

And then accept it like this:
<Input type="text" isOpen={this.state.isOpen} innerRef={(search) => { this.search = search.ref }} />

If we'd decide to pass on input ref, then you'd have to do:
class InputUnstyled extends React.Component {
  render() {
    const { isOpen, innerRef, ...rest } = this.props
    return <input ref={innerRef} {...rest} />
  }
}

Which works, until you render multiple elements. At that point, you'd be up to yourself, with no way to pass anything sensible accept maybe innerRef(this), which is weird.
We could also cloneElement in the wrapper which is IMHO ugly and constricts the user in such a way that it's impossible to escape the default behaviour.
I agree that we need to add some docs for this, but I don't think that there's a better default behaviour for this use-case.

Thanks for the detailed explanation it makes a bit more sens.
This should be added to the documentation.

@philpl Thanks .. That worked for me. In my case, I was trying to get the reference of a third party component, react-custom-scrollbar. I managed to do it in the following way
import Scrollbars from 'react-custom-scrollbars';

export const StyledScroll = styled(({ _ref, ...rest }) =>  <Scrollbars ref={_ref} {...rest} />)`
  /* Styles */
`;

And invoked it like this
<StyledScroll _ref={(el) => { this.scrollbar = el; }} />

Couldn't we just check if the underlying component is a styled component itself, and in that scenario pass down innerRef instead of ref?


Node.js 12 actions are deprecated

Describe the bug
If you use this action, this deprecation warning appears
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: UnlyEd/github-action-store-variable

To Reproduce
Steps to reproduce the behavior:

Using this action in any workflow

Screenshots

Thanks for the issue and PR, I'll take a look at it.


Uses unnecessary much CPU in client while waiting for responses

Package Name:
azure-eventhub, or possible uamqp.

Package Version:
python3-azure-eventhub-5.2.0-lp152.2.1.noarch
python3-uamqp-1.2.12-lp<IP_ADDRESS>.x86_64

Operating System:
Linux, OpenSUSE, kernel 5.3.18-lp152.66-default

Python Version:
Python 3.6.12

Describe the bug
Simple client that sends one item to an eventhub: create_batch(), batch.add(), client.send_batch(). Whiling waiting for the response the client library performs an inefficient busy-wait with recvfrom() on a non-blocking socket.
In my observation with a response time of 116ms the client library did 4152 calls to recvfrom():
10995<PHONE_NUMBER>.139150 sendto(3, "\27\3\3\0\232\337`\255\210\360\252\314\332\342\263\20\316\375\265\367\256@\316\351\200(\314\323\271\n\216H"..., 159, 0, NULL, 0) = 159
10995<PHONE_NUMBER>.139301 recvfrom(3, 0x7fdf14002bf0, 1024, 0, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable)
10995<PHONE_NUMBER>.139384 recvfrom(3, 0x7fdf14002bf0, 1024, 0, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable)
10995<PHONE_NUMBER>.139447 recvfrom(3, 0x7fdf14002bf0, 1024, 0, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable)
<ad nauseam>
10995<PHONE_NUMBER>.256065 recvfrom(3, 0x7fdf14002bf0, 1024, 0, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable)
10995<PHONE_NUMBER>.256093 recvfrom(3, 0x7fdf14002bf0, 1024, 0, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable)
10995<PHONE_NUMBER>.256130 recvfrom(3, "\27\3\3\0000\0\0\0\0\0\0\0\16\237\371li\372`D\250\"\27,&I\205\177\363\310\3308"..., 1024, 0, NULL, NULL) = 53

To Reproduce
Steps to reproduce the behavior:

Use a simple client, the sample code at https://docs.microsoft.com/en-us/python/api/overview/azure/eventhub-readme?view=azure-python "Publish events to an Event Hub" works fine for this purpose.
Send batch to an eventhub that is NOT physically nearby, requiring speed-of-light latency of at least 40-100ms. Inter-continental communication is ideal for reproduction of this issue.
Observe client CPU use while waiting for response
Or: use strace to see what it's doing

Expected behavior
I expected the client to do an efficient blocking recvfrom() or a poll/select/epoll instead of a busy-wait.
Screenshots
From htop - while tracking down the excessive CPU use I added OS thread names so I could see which one was doing it. "evhub-sender" is purely sending to eventhub.

Additional context
In a production program that sends ~1600 items in ~250 batches over a minute the CPU use is 38-50% in the thread that sends to eventhub. The other threads that deal with amqp 0.9 (rabbitmq) and more computational intensive operations use less than 0.9% CPU.

hey @isj4 , thanks for reaching out and the efforts you have put into investigating the issue.
Sorry about the trouble that the library is causing and your understanding is correct, the high CPU usage origins from the implementation of the underlying uamqp library.
I could give more context for the reason of high CPU usage (which I have replied in another issue):

The sync implementation is based on the pulling mode -- within the sdk when send is called, there is while loop keeps calling underlying amqp connection to dowork (send and receive data) and checking if all the messages are being sent. Once the sending is finished, the send method shall return.
This is bound to the implementation of the underlying amqp protocol library (which is pull based) and an expected behavior.

The uamqp itself is a composite of Python and C library, and the socket work takes place in the deep-down C layer and was originally designed on the pulling mode. Our hands get tied here and few things could be done.
We're already considering moving to a pure python AMQP implementation which should give us more control over the socket behavior to save cycles.
Let me know if you have any other questions!

I did search for already known issues but the referenced case didn't seem to be the same problem, so I opened this issue. It's good to know that my analysis is correct.
Question: If I use the async interface (as in the example "Publish events to an Event Hub asynchronously") will the high CPU use disappear?
I have not investigated uamqp - only had a brief look at it. In the past I have encountered libraries with similar deficiencies. In one case the library did provide a "minimum wait time" for the "do-IO-work" method. Maybe uamqp does something similar. In another case it was possible to get access to the file descriptor and do a poll() in the application code. Maybe that's possible with uamqp. Just wild ideas that may save you some work.

hey @isj4 , the "async" would also encounter the same deficiencies as the underlying pull mode is the same.
the async connection work is basically doing the same thing as the sync one:
async def connection_dowork():
    while condition:
        c_connection.dowork()

compared to sync
def connection_dowork():
    while condition:
        c_connection.dowork()

really appreciate your suggestion! I'll keep them in mind when implementing the underlying connection.

Ok, thanks for your answer - that saved me time going into a dead end with asynchronous alternative.

@isj4 , I'm closing the issue now, feel free to reach out if you have more questions or just reopen the issue.
thanks again for sharing your thoughts with us!


Connecting the frame to a frontend that will be rendered with jade

I must comment your very great effort for this great project of yours, but I have some little issues.
I have created all my jade files (all in Views) with their styling and others (in the Public), but I'm still trying to figure exactly how the entire frame routing and linking works.
I have checked various platforms to see if I could get a tutorial that might help, but can't find any.
Help please

I have created all my jade files (all in Views) with their styling and others (in the Public), but I'm still trying to figure exactly how the entire frame routing and linking works.

It sounds like you already have an app started. Typically I'd recommend starting an app with Frame or Aqua, rather than trying to integrate it into an existing app.
Aqua started out as Frame and made a handful of changes to the server side and added a front-end to it. Maybe that'll serve as a good reference.


Provide an RSS/Atom Feed

I like your blog a lot and would like to subscribe to it via a Webfeed. It would be great if there was one.

That's a great idea.
It's been something I wanted to implement for awhile but never got around to it 😊 I'll take a look at adding support real soon!
Thanks for the support ❤

Hey @Kaligule I've implemented a basic RSS feed which you can find here and it's also linked here:

Let me know if there are any issues, if not I'll close this issue 😊

Looks great. Now all there is to do is wait for a new post so we can see if updating works. Thanks a lot.


Add Franciscan University of Steubenville

Domain is franciscan.edu, which is also the website, https://franciscan.edu.
It offers a 4-year Software Engineering program, catalog page here.

@ah-OOG-ah Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Display vesting detail

As a user, I would like to know the detail of my vesting tokens. To see when and how many tokens will be vested.

We decided against this in favor of Forbole x and user privacy

Right, UI would be only on X.


Mostly backend changes for new segment navigation

The customer was confused by our current segment navigation. Basically, once we added support for revelations like super ballets, where there exists a hierarchy between super ballets and the ballets that belong to them, a linear interface is inadequate, in spite of the tweaks we added to identify the different types of pieces/segments.
The customer asked for a folder like structure where super ballets can be open, and expose their ballets, or closed, and hide them. This requires a database change, and that is why I am rushing this change.
The code is pretty straight forward: Add a isOpen Boolean field to the piece/section table.

After analyzing the multiuser implication of the database storing the display state of a Super Ballet, I decided to remove the database changes. The remaining changes now have to do with changing the 'REVELATION' code to 'SUPER'.


get session info and player profile

Not sure if this is how we want to handle getting the info from the parent page


Customs LLMs

Do you have any plans to add configuration options that would allow the use of custom LLMs in future versions ?

I stumbled over the issue yesterday when I wanted to use promptimize for a custom model. I am not sure wether or not I complete got your question but isn't this already possible by passing a custom prompt_executor to a PromptCase?
even a simple lambda function instead of an LLM
from promptimize.prompt_cases import PromptCase
from promptimize import evals

simple_prompts = [
    PromptCase(
        "hello there!",
        lambda x: evals.any_word(x.response, ["hi", "hello"]),
        prompt_executor=lambda _x: "hi there!",
    ),
    PromptCase(
        lambda x: evals.all_words(x.response, ["zappa", "hendrix"]),
        weight=2,
        prompt_executor=lambda _x: "zappa, hendrix, clapton, page, beck, ...",
    ),
]


Why the software history was not kept?

Hi there,
I'm a researcher studying software evolution. As part of my current research, I'm studying the implications of open-sourcing a proprietary software, for instance, if the project succeed in attracting newcomers. However, I observed that some projects, like fsharp-support, deleted the software history during the transition to open-source.
https://github.com/JetBrains/fsharp-support/commit/051cd658d3a6c7f475022d1022372d27a71d3cf5
Knowing that software history is indispensable for developers (e.g., developers need to refer to history several times a day), I would like to ask fsharp-support developers the following four brief questions:

Why did you decide to not keep the software history?
Do the core developers faced any kind of problems, when trying to refer to the old history? If so, how did they solve these problems?
Do the newcomers faced any kind of problems, when trying to refer to the old history? If so, how did they solve these problems?
How does the lack of history impacted on software evolution? Does it placed any burden in understanding and evolving the software?

Thanks in advance for your collaboration,
Gustavo Pinto, PhD
http://www.gustavopinto.org

Hi @gustavopinto,
I'm apologise for the late reply. The most of the history is actually remained in the repo. The commit you're referring to was at the point when initial F# support has been moved from Rider/ReSharper codebase to a separate plugin, not at the time we've open-sourced it.
It's been several months since that commit and before the repo went public, so the most of the history is available.
There was no intention to hide the history and as it was in the very initial state most of the files from the commit has changed a lot since and it didn't bring any trouble not having the history from the very beginning.

Hi @auduchinok,
thanks for answering our research inquiries. We were able to collect 35 responses and we drafted a research paper with the results. The paper was submitted and accepted for the 14th International Conference on Open Source Systems (http://oss2018.org/). You can find the paper here. Hope you enjoy reading the paper!
Thanks again,
Gustavo


Stricter flagging of bad pixel neighbors

Another tweak that I have made while looking at NIRCam bad pixels is to look at neighbors of pixels flagged by RCSelfCal using a stricter threshold.
I've seen the best results so far by running RCSelfCal with a 5 sigma threshold, and then going back and looking at the 4 neighbors around each flagged pixel and flagging those using a 3 sigma threshold. I currently do this neighbor flagging outside of RCSelfCal, but I could look into integrating it if you think it would be useful.

That could be interesting.  This is essentially a flagging of the IPC effect? I.e. if the central pixel is large outlier, then it's likely that the connected pixels due to IPC will be some ~0.6% of that or whatever the IPC kernel is?
That makes sense.  I've mostly been relying on JumpStep to catch these, but if these are consistently hot pixels that just have a much higher baseline (bias), then maybe they don't get flagged, nor do the pixels around them, is there's actually no jump in the slope.  Is that what you've seen as well?

Here's what a median stack of NRCALONG looks like.  You can see the little "flowers" or OPEN pixels and ADJ_OPEN, or something close to those, and you can see the hot pixels with an IPC effect at their adjacent ones too.

For most of these "flowers" already have the central pixel flagged as BAD and set to NaN.  The ADJ_OPEN ones around though are not.
It's possible that that perhaps since these central pixels are getting caught early, and flagged as bad during the jump step and not used in the ramp fitting, perhaps these are actually also hot pixels that are causing IPC?  Would be worth looking at high-zodi final groups in the _uncal files.

To answer my own question, here's a blink between the first group of individual exposure
jw02234001001_02101_00002_nrcalong_jump.fits
and the median stack made from all NRCALONG exposures in program 2234.  I've colored the NaNs in the stack green, as they are NaNs in the input rate files (due to how they're handed in RampFitStep).  But you can see that these are OPEN and ADJ_OPEN pixels, or something very similar.

Interesting.  It sounds like there's a number of electronic effects going on.
I was actually quite surprised that the first group shows these pixels so well.  It turns out so does the ZEROFRAME.  Would be interesting to use a stack of the ZEROFRAMES to get map of these bad pixels.

A good number of the RC pixels have a very high signal rate in the early reads. I've also seen some that have a very short time constant, such that the signal between frame 0 and frame 1 can be thousands of counts, but between consecutive later frames the rate has decayed to nominal dark current level.

Interesting.  What's the current strategy for handling these?  Masking them?  Or will an RC model be used to correct them?  Or just mask the first N groups until they've settled down?

Mask them. They're few enough that it's not worth trying to save them at the moment. Who knows what other symptoms might show up in addition to/because of the RC behavior? It's safer to just throw them out.

Agree.  In that case, the ZEROFRAME images processed through refpix is very good for finding these.  Here's a median of 40 NRCALONG zeroframe images.

Coming back around to this now that I've delivered updated mask files to CRDS, and am looking to clean up and improve my process for next time. This time around, I really wanted to get something in for reprocessing associated with the next build of the pipeline, and it seems like what I had was most of the way there.
For the pixels that are dark in the zeroframe/0th group, have you looked at any signals up the ramp? I'd always been thinking that these pixels were dark because they were saturated in all groups, which would then make them NaN in the rate file. But if they are showing low, finite (or exactly zero?) signal values in the initial group and the rest of the way up the ramp, then I guess that's not the case.
I can put in a PR to add the neighbor search, if you think it will be useful. Like was mentioned in a conversation with some other NIRCam folks a few weeks ago, since the IPC step is off by default, most users' data is not IPC corrected, which means very hot/RC pixels can cause their neighbors to also appear hot/RC, just at a lower level.
And then it seems like these dark central pixels would be a separate search, and that OPEN/ADJ_OPEN would be the flag to use if they have low/zero signal up the ramp.


Retriever for PGVector

Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.
Type of change
List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)

Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.

Hi, please add PGVector tests

Hi, please add PGVector tests

Done, Please check


Fix AttributeError: module 'discord' has no attribute 'InvalidArgument'

Basically fixes this error:
Traceback (most recent call last):
  File "/{SPUNGED}/.local/share/Red-DiscordBot/data/MELON/cogs/CogManager/cogs/webhook/webhook.py", line 519, in send_to_channel
    return await webhook.send(allowed_mentions=allowed_mentions, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/{SPUNGED}/lib/python3.11/site-packages/discord/webhook/async_.py", line 1800, in send
    data = await adapter.execute_webhook(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/{SPUNGED}/lib/python3.11/site-packages/discord/webhook/async_.py", line 219, in request
    raise NotFound(response, data)
discord.errors.NotFound: 404 Not Found (error code: 10015): Unknown Webhook

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/{SPUNGED}/lib/python3.11/site-packages/discord/ext/commands/core.py", line 229, in wrapped
    ret = await coro(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/{SPUNGED}/.local/share/Red-DiscordBot/data/MELON/cogs/CogManager/cogs/webhook/webhook.py", line 159, in webhook_sudo
    await self.send_to_channel(
  File "/{SPUNGED}/.local/share/Red-DiscordBot/data/MELON/cogs/CogManager/cogs/webhook/webhook.py", line 520, in send_to_channel
    except (discord.InvalidArgument, discord.NotFound):
            ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'discord' has no attribute 'InvalidArgument'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/{SPUNGED}/lib/python3.11/site-packages/discord/ext/commands/bot.py", line 1350, in invoke
    await ctx.command.invoke(ctx)
  File "/{SPUNGED}/melon-dpy2/redbot/core/commands/commands.py", line 783, in invoke
    await super().invoke(ctx)
  File "/{SPUNGED}/lib/python3.11/site-packages/discord/ext/commands/core.py", line 1642, in invoke
    await ctx.invoked_subcommand.invoke(ctx)
  File "/{SPUNGED}/lib/python3.11/site-packages/discord/ext/commands/core.py", line 1023, in invoke
    await injected(*ctx.args, **ctx.kwargs)  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/{SPUNGED}/lib/python3.11/site-packages/discord/ext/commands/core.py", line 238, in wrapped
    raise CommandInvokeError(exc) from exc
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: module 'discord' has no attribute 'InvalidArgument'

https://discordpy.readthedocs.io/en/stable/migrating.html?highlight=invalidargument#removal-of-invalidargument-exception

The docs says here

Changed in version 2.0: This function will now raise ValueError instead of InvalidArgument.

So you should be using ValueError instead of TypeError

It says TypeError and/or ValueError

shouldn't we be using both if that's the case?
Tho I think using just TypeError should be enough

The docs says here

Oh i see so Webhook.send now returns a ValueError instead of InvalidArgument


Update sbt to 1.3.8

Updates org.scala-sbt:sbt from 1.3.7 to 1.3.8.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #78   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines          84     81    -3
  Branches        2      2
=====================================
- Hits           84     81    -3

Impacted Files
Coverage Δ

.../main/scala/org/uaparser/scala/CachingParser.scala
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3a789...b2b311e. Read the comment docs.


Make companies sort ESG by null: 'last'

Description
Currently the companies that do not have an ESG value are being shown first when sorting from high to low score. Because prisma does not allow for null sorting on a relation. Because of this we need to convert the current company query into a raw mongodb query or something similar
Learning Objectives

Objective 1

Todo
These points are a rough guideline. Please feel free to discuss with others on the team about the best way to design this component!

[ ] Todo 1

Useful Links

Link 1

This is temporarily resolved with a work-around here, by filtering out all NA values whenever sort by env grade is selected. Leaving this issue open in case we want to revisit this behavior in the future.


Automator: update<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

Generated by Automator - 2024-05-01T15:41:52+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio_release-1.22
9edcd21738801521eac9e5927fe789cde36daaeb
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Superseded by https://github.com/istio/istio/pull/50778

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio_release-1.22
7a993a38f9d3d47c538019d7c9a5d46ab51d90bd
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


disable heapster config

What this PR does / why we need it:
we do not want heapster addons, thus we do not need configuration for heapster
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@robbiezhang @yangl900


Publish to bower more often (unstable bower package?)

I do not want to be cheeky but would it be possible to publish your progress to bower more often? Maybe a dedicated bower package for the unstable versions? It would simplify my build process :)

We have been consciously holding off with a target to fix the outstanding hi-pri bugs.  This was to avoid spending our limited time pushing RCs instead of fixing things.  But we've gone a bit slower than we'd like in fixing those bugs.

I totally get the point and appreciate your effort. Can i provide any help? My Angular Skills may not be good enough to help fixing stuff but i could provide some CI/CD skills&infrastructure to automate bower package builds etc.

Absolutely that would be useful.  One big outstanding is the protractor (e2e) tests running with Travis, that would be really great to get going.

I think we're now pushing more frequently, so closing.


[JS] WeakRef, Fx 79

User story
As a web developer, I want to know how about JS WeakRef that is now implemented in Firefox 79 and in other browsers.
Acceptance criteria

[ ] WeaKref marked dev-doc-complete: https://bugzilla.mozilla.org/show_bug.cgi?id=1639246
[x] Compat data updated
[x] Announced on Firefox 79 for developers
[ ] Pages written/reviewed https://wiki.developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakRef
[ ] Pages written/reviewed https://wiki.developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry

This was mostly done to by MDN contributor tjcrowder.
Release notes: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/79#JavaScript
Docs:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakRef
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry

Compat data: https://github.com/mdn/browser-compat-data/pull/6287
Not adding interactive examples, given you should "avoid this when possible". But I'm updating this so that every page has an example section that passes the linter.


Session JNI interface has memory leak

System information
Have I written custom code (as opposed to using a stock example script provided in TensorFlow): NO
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): Master
Python version: 3.6
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: None
GPU model and memory: None
Exact command to reproduce: Run the snippet below.
Describe the problem
Read the tensorflow_jni.cc code in the code section as blow.
  TF_Graph* graph = reinterpret_cast<TF_Graph*>(graph_handle);
  TF_Status* status = TF_NewStatus();
  TF_SessionOptions* opts = TF_NewSessionOptions();
  const char* ctarget = nullptr;
  jbyte* cconfig = nullptr;
  if (target != nullptr) {
    ctarget = env->GetStringUTFChars(target, nullptr);
  }
  if (config != nullptr) {
    cconfig = env->GetByteArrayElements(config, nullptr);
    TF_SetConfig(opts, cconfig,
                 static_cast<size_t>(env->GetArrayLength(config)), status);
    if (!throwExceptionIfNotOK(env, status)) {
      env->ReleaseByteArrayElements(config, cconfig, JNI_ABORT);
      //Not release the status, opts
      return 0;
    }
  }

After throw exception, it look like not release the status, opts memory.

Update the code in the github try to fix it. Please check it.
https://github.com/raintung/TensorflowPatch/blob/master/v1.6/java/src/main/native/session_jni.cc

Nagging Assignee @jart: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jart: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Thank you for bringing this to our attention. That does appear to be a small memory leak. We'd welcome a pull request fixing it.

@jart Can you please assign me this. I'm new might need help, but will submit a PR fixing this


Minor changes to Tox and Readme

Pre-commit, codecov configuration looks Ok. Only minor things.

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   91.55%   91.55%
=======================================
  Files           3        3
  Lines         379      379
=======================================
  Hits          347      347
  Misses         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9b504...16d8732. Read the comment docs.


[BEAM-14534] Allow users to compress values being shuffled in dataflow

This PR adds a new interface, ShuffleCompressor, which allows users to plug in compression for values just before they're written to shuffle.
The interface is a little odd, we originally had exposed it as simply wrapping Input/Output streams.  However, this interface is much more efficient:

In the compression path, the implementor can use the RandomAccessData as both a buffer pool (using scratch space at the end for example) and also compress the data "in place" if possible.  Additionally, many compression algorithms can operate more efficiently on a fixed-sized buffer rather than having to deal with an unknown amount of input data.
In the decompression path, using ByteBuffer allows efficiently slicing the input and output buffers as well.  Ideally I think this interface would use ByteString as well, but didn't want to expose the shaded protobuf library in the public API.

Additionally this also changes most places in the shuffle IO path to use ByteString rather than byte[].  This allows efficiently "slicing" the buffer received from the shuffle reader, removing a significant number of byte[] copies.
Internally we have an implementation of ShuffleCompressor that uses zstd, and we see a significant benefit from using it.  For example, at level 3 (the default), a simple read -> reshuffle -> do something pipeline sees a 50% reduction in data shuffled for our representative test datasets.
R: @lukecwik

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I see that BEAM-14534 does specifically mention using a wrapping coder to compress the data and I think it would still be a better solution since it would allow you to:

plugin compression into more places such as compressing the shuffle key, user state and side inputs
works for all runners and not just Dataflow runner v1. (Note that this solution won't work for any portable runners like Dataflow runner v2 since you can't edit the shuffle code)
the compression can be configured per GroupByKey since in some places it won't make sense since the values are not easily compressible

You can also create a PipelineVisitor that walks all transforms and replaces the KV<KeyCoder, ValueCoder> with KV<KeyCoder, CompressingCoder<ValueCoder>> so that users don't need to do this themselves which would give similar behavior as specifying the shuffle compressor.
The other part of the change makes sense to reduce byte[] copies by using ByteString.
CC: @tudorm

The other part of the change makes sense to reduce byte[] copies by using ByteString.
CC: @tudorm

Maybe I'll pull the ByteString refactoring stuff out into another review just to make this easier? Do you have any particular issues with it using ByteString there?
The downsides with using Output/Input stream are really too big to ignore here, the performance differences are orders of magnitude in our tests. The main problem is that most "stream" compressor implementations are designed to compress a large amount of data, but in this case we're usually only compressing a few 100-1KB. It makes the overhead from creating/destroying the compressor streams very high (comparatively at least). We ran into this problem both with deflate and zstd, and its one of the reasons we ended up with an interface like this. If its really a non-starter putting this on OSS with a similar interface that's fine though, we can continue maintaining this in our own fork for the time being.
The PipelineVisitor idea is interesting, although I'm skeptical how well it'd work in practice. For example with a Combine the coder for the data being shuffled is the accumulator coder, not the value coder of the KV. I bet you'd need a bunch of special cases to pick the "right" coder to wrap for various transforms.

I'm happy with using ByteStrings as it reduces copies and will review and merge that and then we can revisit this.
I was unaware of the additional overhead for using a stream compressor/decompressor vs one that worked on fixed length byte strings. I'm curious to learn more about it though as I might see something that wasn't considered before and also with the migration to Dataflow runner v2 you'll lose the ability to have this option have an effect unless you go the coder route which will have additional benefits since you'll reduce the amount of data being sent over gRPC between the SDK harness and the runner and also how much the runner materializes in shuffle in addition to those other use cases such as side inputs/user state/...
Using the PipelineVisitor should work quite well as since you really only need to handle GBK, CoGBK and Combine and that would give you everything that is optimized across runners today to my knowledge.

Is this blocked on https://github.com/apache/beam/pull/17802 ?

Is this blocked on #17802 ?

Yes, it is the precursor.

Have you tried the pipeline visitor using a SnappyCoder that wraps existing encodings?

Have you tried the pipeline visitor using a SnappyCoder that wraps existing encodings?

now that we have compression working well end-to-end in our internal fork (and a good baseline for performance), I was going to re-evaluate options for making a "coder wrapper" that can do the compression/decompression.  I really do agree that a coder-wrapper would be much cleaner here, I'm just worried we won't be able to reach the same level of performance with that interface.

Have you tried the pipeline visitor using a SnappyCoder that wraps existing encodings?

now that we have compression working well end-to-end in our internal fork (and a good baseline for performance), I was going to re-evaluate options for making a "coder wrapper" that can do the compression/decompression. I really do agree that a coder-wrapper would be much cleaner here, I'm just worried we won't be able to reach the same level of performance with that interface.

Its not just about being cleaner, its about the value being added to other runners and for Dataflow Prime where you wouldn't have access to be able to edit the shuffle code.

Any updates on using the pipeline visitor vs this approach?

I just stumbled upon this PR while searching for the ZstdCoder PR.
I had been thinking of writing a PipelineVisitor to do this, so it's a fun surprise to see it suggested here as well.
@steveniemitz I would be happy to pick up the PipelineVisitor feature if you have other priorities.

I just stumbled upon this PR while searching for the ZstdCoder PR. I had been thinking of writing a PipelineVisitor to do this, so it's a fun surprise to see it suggested here as well. @steveniemitz I would be happy to pick up the PipelineVisitor feature if you have other priorities.

It would make sense to have an approved and/or denied list of coders that we should compress or not. Things that are already small like int/double/... would make sense to have in the denied list. Making it user configurable also would be nice. Lots of options here.


ClientModel: Address APIView feedback regarding Freeze APIs

Address @tg-msft's questions:

What's the reason for the new Freeze methods on PipelineOptions and RequestOptions?
How do we expect people to use it?
What happens when I modify a frozen value?
How deep does freezing go (i.e., do the allow lists in DiagnosticOptions become immutable too)?
How does it impact the story for ClientOptions.Default?

Notes from @tg-msft:

https://github.com/Azure/azure-sdk-pr/issues/693 has the details for why ClientOptions.Default was added (tl;dr so Chaos could add PerTransport policies globally and without instrumenting/reshipping all our libraries).

I think we will not end up adding the Freeze API to ClientOptions or have it inherit from ClientPipelineOptions.  Moving this to the backlog for now to preserve the questions in case we pick up this piece in the Azure.Core 2.0 integration work.