Feature/global notification settings [#OSF-5748]

Again piggybacking off of #5452 to implement small spec changes

Purpose

New Projects get default notifications set as instantly
Global project notification settings on project page

Changes
Summary across the three PRs this one incorporates:

Add method that subscribes a user to notifications
Call that method with signals when a node is first saved with the nodes' creator
Also call that method when a contributor is added with that contributor
Add a setting that decides if a notification subscription should be automatically created (by default yes)
Adjust that setting to False in a special case for NotificationSubscrtiption related tests that don't create the subscriptions by default
Disable automatic subscriptions on tests that benefit from creating them manually
Alter text on contributor added, invite, forward invite, and public project emails to explain notifications and link to profile settings to update them
add global subscription types for comments added and files updated to USER_SUBSCRIPTIONS_AVAILABLE
in subscribe_user_to_notifications check for global settings before defaulting to email_transactional
Update settings heading and add tooltip explaining global preferences settings

Side effects

Will not change settings for existing projects

Ticket
https://openscience.atlassian.net/browse/OSF-5748

From the ticket -- desired settings, options, and their default values:

Comments Added to Your Projects: (Options: Never, Daily Digest, Instantly) - Default is Instantly
Files Updated on Your Projects: (Options: Never, Daily Digest, Instantly) - Default is instantly
Replies to your comments: (Options: [Never,] Daily Digest, Instantly) - Default is Instantly

Please change the default for Comments Added to Instantly.

Recently requested on the ticket:

Also, please include text in this Configure box:
"NOTE: Regardless of your selected preferences, OSF will continue to provide transactional and administrative service emails."

Pass complete. Back to you, @erinspace 🌃

Closing in favor of #5452


add .draftignore

@bacongobbler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


latest release does not have correct version info

latest releases download tagged as 2.6.1 downloads  2.6.0

ugh I didn't even notice.  Looks like a bug in the gulp script for release - it automatically bumps the version but looks like it commits the version bump after creating the git tag.  I'll release a new version with a corrected bower.json file.

fixed

ya, it looks like all versions of late have been behind. I just noticed as I'm going through and testing earlier versions.

yeah I've been using gulp tag and gulp tag --minor for making new versions since 2.5.6 or so.  I did this last one manually now.


Issue#517 Removed background and improved contact button

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

This is a fix.
Summarize what this PR fixes:-

Fixes #
#517

removed light grey background in nav links.
added hover effect to contact button.
added border radius of 5px to contact button like other buttons are having and also given in mockup.

Checklist
(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[x] I have provided the issue ID/URL above
[x] I have not added Bootstrap or jQuery and used correct styling guide.
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue - I created the issue

Ah, so much better, thank you!

Ah, so much better, thank you!

Glad you appreciated, Thank You..!!!


How do we pass file ids in message creation on asssistants now?

Library name and version
Azure.AI.OpenAI 2.0.0-beta.5
Query/Question
In the Azure.AI.OpenAI.Assistants we were able to do this to attach the file to the message. I can find no documentation on the new process as I see no way to reference file IDs in a user message:
        private async Task<ThreadMessage> CreateMessage(string userMessage, string[] fileIds, AssistantThread thread)
        {
            var messageResponse = await _client.CreateMessageAsync(thread, MessageRole.User, userMessage, fileIds);
            var message = messageResponse.Value;
            return message;
        }

Environment
.NET Core 8
Visual Studio 2022 Preview
Windows

Thank you for getting in touch, @raysuelzer!
You're absolutely right that this use of attachments with Assistants v2 and the new library is missing sample coverage at the moment; I'll ensure we get a work item filed to have the changes better documented.
As a direct answer, you can extend the pattern shown in this test code by using the Attachments property of MessageCreationOptions.
Here's a rough adaptation of the test to demonstrate:
[Test]
public void MessageWithAttachmentWorks()
{
    AssistantClient client = GetTestClient();

    FileClient fileClient = GetTestClient<FileClient>(TestScenario.Files);
    OpenAIFileInfo numbersFile = fileClient.UploadFile(
        BinaryData.FromString("""
        15
        20
        22
        12
        20
        """).ToStream(),
        "text/plain",
        FileUploadPurpose.Assistants);
    Validate(numbersFile);

    Assistant assistant = client.CreateAssistant(
        "gpt-4o",
        new AssistantCreationOptions()
        {
            Tools = { new CodeInterpreterToolDefinition() },
            ToolResources = new()
            {
                CodeInterpreter = new()
                {
                        FileIds = [numbersFile.Id],
                }
            }
        });

    AssistantThread thread = client.CreateThread();
    Validate(thread);

    ThreadMessage message = client.CreateMessage(
        thread.Id,
        MessageRole.User,
        content:
        [
            MessageContent.FromText("What's the standard deviation of the numbers in the attached file?"),
        ],
        new MessageCreationOptions()
        {
            Attachments =
            {
                new MessageCreationAttachment(
                    numbersFile.Id,
                    tools: [ new CodeInterpreterToolDefinition() ]),
            }
        });
    Validate(message);

    foreach (StreamingUpdate chunk in client.CreateRunStreaming(thread.Id, assistant.Id))
    {
        if (chunk is MessageContentUpdate contentUpdate)
        {
            Console.Write(contentUpdate.Text);
        }
    }
}

Which yields:
    It appears that the file contains a single column of numbers. To calculate the standard deviation of these numbers, we can proceed with the computation.The standard deviation of the numbers in the file is approximately \(4.43\).


Generate the blob with correct MIME type

I haven't tested it, but I think this will solve #22.

Is there any progress on this? I would like to have this as well!

@WietskeVisser Seems like it has stalled unfortunately. If you wanna fork @judofyr's branch, I'd be happy to review a new PR 🙂

Stalled how? The patch is a one-liner and all that's missing is to write a test for it. This is my suggestion for how to write a test. Feel free to tweak my patch if you want it a different way.

This is all I need, the fix without a test: https://github.com/egeriis/zipcelx/pull/44

@judofyr Our conversation stalled, thus the PR.


Give paragraphs a max-width

Great to see new docs in the makings!
One thing I think the old and new docs alike are suffering from is readability, the biggest problem being the number of characters per line (120+ on my 13" MacBook).
Attaching an example of paragraph width constraits and use of system font.
Before

After
p {
  max-width: 35em;
  line-height: 1.5;
  font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";
}

Hi @alexanderwallin, I definitely agree that we should have an optimal width for reading. However I just double checked the deployed version and found that even at our widest screen width we're under 960px (currently) for the content section. We are planning to bring that down for smaller screens, see #183, but isn't 960px the recommended max for readability?
Either way I'm fine with bringing it down a bit but I'd rather take the max screen size, see [_screens.scss], than individual paragraphs.
EDIT: After a little more research, I guess you're right that typically these days 560 - 720px (at a font-size of 16) is the recommended norm.

I think the key metric is the number of characters per line, where anything between ~45 and ~95 seem to be recommended. 720px results in about 120 characters per line on my machine.
Thanks for the quick reply!

No problem, I'll play around with it and tonight and try to get it down in a clean way, probably shooting for 90 - 95 characters per line to start.

Closed via 46dbf283. Taking the screen size down 1024 still leaves the sidebar with a decent amount of room and yields around 95 characters per line.


JMLL-835 Search index updates

Codecov Report

Merging #149 (684f5d6) into main (39d7864) will decrease coverage by 0.37%.
The diff coverage is 19.71%.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   80.16%   79.78%   -0.38%
==========================================
  Files         137      137
  Lines        5087     5126      +39
==========================================
+ Hits         4078     4090      +12
- Misses       1009     1036      +27

Impacted Files
Coverage Δ

core/service_now/interfaces.py
33.51% <10.00%> (-0.19%)
:arrow_down:

core/service_now/client.py
29.87% <20.00%> (+0.32%)
:arrow_up:

core/utils/staff_index.py
43.29% <33.33%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d7864...684f5d6. Read the comment docs.


SinglePage to TabsPage not working properly on iOS

SinglePage to TabsPage not working properly on iOS
on Chrome, I can use code to control the single page (root page) to nav.push to TabsPage, but it doesn't work on iOS, I need to physically press a button to do this action instead.
Steps to reproduce:

the root page is set to a single page and the Single page use code to call nav.push to TabsPage
TabsPage constructor called but not pushed, it's on the background
Physically press a button to goto the TabsPage and now the tabs page constructor called the second time which mean now I have two tabspage.

Which Ionic Version? 2.11
Run ionic info from terminal/cmd prompt:
Your system information:
Cordova CLI: 6.3.0
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.36
Ionic App Lib Version: 2.0.0-beta.19
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.4.7
Xcode version: Xcode 7.3.1 Build version 7D1014

Hello, thanks for opening an issue with us! Would you mind posting a repo or code snippet I can use to reproduce this issue? Thanks for using Ionic!

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!


LibWeb: Apply the word-spacing css property to Node

This will let us start to begin applying this during text shaping.

@AtkinsSJ changes made :)

Friendly ping @AtkinsSJ


check bn_new return value

If "bn_new" fail, bn = (BIGNUM *)*pval == NULL.
and in next function "BN_bin2bn", if bn is NULL, it will be realloced as follow:
if (ret == NULL)
ret = bn = BN_new();
If "BN_bin2bn" sucess,  *pval is still a NULL pointer, but bn_c2i will return sucess, and no one free the bn malloced in BN_bin2bn.
Also in function d2i_PublicKey:
    if ((ret->pkey.rsa = d2i_RSAPublicKey(NULL,
                                          (const unsigned char **)pp,
                                          length)) == NULL) {
        ASN1err(ASN1_F_D2I_PUBLICKEY, ERR_R_ASN1_LIB);
        goto err;
    }

Although RSAPublicKey return sucess ,but ret->pkey.rsa.n or ret->pkey.rsa.e is still null .
I found this problem in my machine with high loading, and it caused segmentfault and memory leak.I fixed it by checking bn_new return value.

done in master, 1.0.2, 1.0.1; thanks.


New version: GenieAutoReload v0.2.0

Registering package: GenieAutoReload
Repository: https://github.com/GenieFramework/GenieAutoreload.jl
Created by: @essenciary
Version: v0.2.0
Commit: c12a859a672629bddb0d46a077e29c59aea53276
Reviewed by: @essenciary
Reference: https://github.com/GenieFramework/GenieAutoreload.jl/commit/c12a859a672629bddb0d46a077e29c59aea53276#commitcomment-43144619

Tried everything, I don't understand what the problem is...

@essenciary I'll take a look.
[noblock]

I think this is because your package expects Revise.jl to be installed at the top level.


Unknown Failure to Load Datapacks on Modified TNP-6

# Unknown Issue with Apugli and a Modified TNP6
Preface:
I have a modified version of TNP6 as a server and client. The mod list for normal unmodified mod-pack can be found on the TNP6 Mod-Index
My Additions are as such:

JobsPLus+1.19.2-0.9.4.jar

immerisve_melodies-0.1.0+1.19.2-forge.jar

aether-1.19.2-1.0.0-beta.1.2-forge.jar

aether-redux-1.2-1.19.2-forge.jar

deep_aether-1.19.2-1.0.0.jar

aeroblender-r1.19.2-1.0.jar (Dependacy for Deep Aether, and Aether Redux)

Eternal Tales [v<IP_ADDRESS>] [1.19.2].jar

puffish_skills-0.9.0-1.19.2-forge.jar

IBEEditor-1.19.2-2.2.2-forge.jar

create_enchantment_industry-1.19.2-for-create-0.5.1.e-1.2.6.c.jar

create-stuff-additions1.19.2_v2.0.4a.jar

createbigcannons-forge-1.19.2-0.5.2.a.jar

create_misc_and_things_+1.19.2_4.0A.jar

createdieselgenerators-1.19.2-1.1d.jar

create_recycle_1.0.2_forge_1.19.2.jar

bellsandwhistles-v0.4.jar

worldedit-mod-7.2.12.jar

Create-Dreams-n-Desires-1.19.2-0.1a.PREBETA.jar

create_crystal_clear-0.2.1-1.19.2.jar

create-1.19.2-0.5.1.e.jar (Updated from create-1.19.2-0.5.1.c.jar)

jmi-forge-1.19.2-0.13-44.jar

FastLeafDecay-30.jar

[1.19.2]+SecurityCraft+v<IP_ADDRESS>.jar

carryon-forge-1.19.2-<IP_ADDRESS>.jar

create-interiors-v0.3.1-1.19.2.jar

astikorcarts-1.19.2-1.1.2.jar

inventorypets-1.19.2-2.0.19.jar

secrets_of_forging_revelations-1.2.1-1.19.2.jar

Gobber2-Forge-1.19.2-2.7.28.jar

art_of_forging-1.6.7-1.19.2.jar

createoreexcavation-1.19-1.2.2.jar

player-animation-lib-forge-1.0.2.jar

tetratic-combat-1.19-2.6.3.jar

bettercombat-forge-1.7.1+1.19.jar

createfoundry-forge-1.1.0-1.19.2.jar

Vampirism-1.19.2-1.9.5.jar

Guide-API-VP-1.19.2-2.2.4.jar

Werewolves-1.19.2-<IP_ADDRESS>.jar

VampirismIntegrations-1.19.2-1.8.0.jar

vampiricageing-1.2.0.jar

VampiresNeedUmbrellas-1.19.2-1.0.jar

ironbookshelves-1.19.2-1.2.2-forge.jar

minecraft-comes-alive-7.5.8+1.19.2-universal.jar

GodlyVampirism-1.19.2-1.0.6.jar

origins-forge-1.19.2-<IP_ADDRESS>-all.jar

origins-accessbilities-1.19.2-1.1.1.jar

Issue:
When I add Apugli (Apugli-2.6.6+1.19.2-forge.jar or other older versions) I'm left with my server unable to continue loading due to THIS on my server console. Issue also occurs preventing generation of a single player world.
Now what I find is odd, is there isn't a full crash log, I've tried remaking worlds with Apugli and no custom datapacks minus the ones Built-in to TNP6
On a fresh world, without Apugli, the datapacks present from TNP6 can be read from a screenshot(s) here.

I have tried debugging it myself, but it would take too much time to remove each mod from TNP6's and my additions to find the exact culprit. So I'm posting this issue to see if anyone has had anything similar or there might be an better solution.

This is awfully strange tbh. I'll probably binary search myself once I'm no longer sick.

This is awfully strange tbh. I'll probably binary search myself once I'm no longer sick.

I know I have no idea either, granted I'm not well versed in modding minecraft or making compatibility patches or anything. I just work with Websites, servers, and C#, and vehicles XD.  I'd love to see what you discover.


[image_picker] add multiple images or videos selection

I suggest adding the functionality of choosing multiple photos or videos as it is now not supported.
some requirements:

choose multiple images
have limit for choosing images
it should be the native look, since it is supported natively. At least on iOS
have one photo or video mode, so two new functions for multiple picking 😁

possible duplicate of https://github.com/flutter/flutter/issues/16054

@YazeedAlKhalaf
Please check out the the similar open issue as referred above and follow-up there for updates and for any questions.
Closing this as duplicate. If you disagree, write in comments and I'll reopen.
Thanks.


Fail early if cargo build returns non-zero exit code

Looks like something changed with the --build-plan command so it's no longer linking up dependencies. This PR just inherits the stderr so we can see what cargo is actually doing and blows up if the exit code is non-zero rather than trying to parse an empty build plan.

I logged https://github.com/rust-lang/cargo/issues/6082 to track this.

Good idea! I already guessed using the build-plan feature would bring some problems with it down the road °_°


fix: export _storage package in setup.py

I'm a little confused. What would the export do?
You can just import nano_graphrag._storage.

Whether I use pip install .  to install the package from source, or using python . \setup.py bdist_wheel to manually package the package, I end up missing the folder _storage as shown below:

Also, the _storage.py in your latest 0.0.8 release on pypi seems to be still old and doesn't include these new classes like Neo4jStorage:

Thanks! The sub-modules are indeed not packed into the package.
I changed the setup.py and used find_packages to fix that problem.
I will close this PR for it's fixed, thanks for your feedback!


How To: composite icon in IconLayer

Is it possible to make an IconLayer that has a dynamic aspect to it. Like I want a marker that is a graphic pin and then a picture from a url to fill some part of it? Does this require a special shader?

@ibgreen that was the only thing I was thinking. Is that preferable?

I think my only concern is fitting the image (square) into a round container (the mask)

think my only concern is fitting the image (square) into a round container (the mask)

@pr1ntr I imagine that you'd want the second layer (with the round frames) to render over the first layer. You could turn e.g. off depth testing to make sure the second layer renders on top of the first:
new IconLayer({
  id: 'pictures'
}),
new IconLayer({
  id: 'frames',
  ...
  parameters: {
    depthTest: false
  }
});

This all may be moot since the project is about to get killed 🙄


Remove references to OpenSDS in documentation ?

Issue/Feature Description:
Check and remove references to OpenSDS from SODA documentation.
Why this issue to fixed / feature is needed(give scenarios or use cases):
Make SODA usage consistent across documentation and products.
How to reproduce, in case of a bug:
N/A
Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)
N/A

@anvithks  can u add the link to the documentation

@anvithks can u add the link to the documentation

@shelar1423
Sorry if I was not clear. I meant across the Documentation repository.
We have to check all the documents and if there is any occurrence of the word OpenSDS, we need to change it to SODA . This could be in the content or also in the license information.

@anvithks can u add the link to the documentation

@shelar1423
Sorry if I was not clear. I meant across the Documentation repository.
We have to check all the documents and if there is any occurrence of the word OpenSDS, we need to change it to SODA . This could be in the content or also in the license information.

If openSDS is there in multiple documents, I need to create multiple pr's right?


small typo README.md 'Testing React with Enzyme'

sorry i do not know how to do a multiline code block
const wrapper = mount(<App/>)
 const results = await axe(container.getDOMNode())
should be
const wrapper = mount(<App/>)
const results = await axe(wrapper.getDOMNode())
Also I had to change
const App = require('./app')
to
import App from '.App'
because mount was being passed an object instead of the component

Fixed thanks for raising this issue!


Upstream merge

This pull request merges some minor bugfixes and some product strings back to upstream.

any reason you left out the Janitza UMG 96S from https://github.com/lategoodbye/libmbus/commit/6c23e1db2bd761c974cb8aa113db273b12513fbe ?

Sorry, i missed that.


Validation dependency (mb same issue)

Hello, i am trying to do validation that depends on other field, but when use markAllAsTouched and then print errors of  FormGroup, it shows only the first error on the first field.
There is an example
_requiredOfType(type) {
  return (AbstractControl<dynamic> control) {
    return (control.parent as FormGroup?)?.control('UserType').value == type &&
            (control.value == null || control.value.isEmpty == true)
        ? {ValidationMessage.required: true}
        : null;
  };
}

final form = FormGroup({
  "UserType": FormControl<dynamic>(validators: [Validators.required]),
  "Iin": FormControl<String>(
    validators: [_requiredOfType(UserTypes.FL)],
  ),
  "BIN": FormControl<String>(
    validators: [_requiredOfType(UserTypes.UL)],
  ),
});

@override
  Widget build(BuildContext context) {
    return ReactiveValueListenableBuilder<dynamic>(
      formControlName: 'UserType',
      builder: (context, control, child) {
        return Column(
          children: control.value == UserTypes.FL
              ? [
                  AppTextField(
                    key: ValueKey('iin'),
                    formControlName: 'Iin',
                    labelText: LocaleKeys.user_iin.tr,
                    maxLength: 12,
                    validationMessages: {
                      ValidationMessage.minLength:
                          AppValidationMessages.minLength(12),
                    },
                    keyboardType: TextInputType.numberWithOptions(
                      decimal: false,
                      signed: false,
                    ),
                  )
                ]
              : [
                  AppTextField(
                    key: ValueKey('bin'),
                    formControlName: 'BIN',
                    labelText: LocaleKeys.user_bin.tr,
                    maxLength: 12,
                    validationMessages: {
                      ValidationMessage.minLength:
                          AppValidationMessages.minLength(12),
                    },
                    keyboardType: TextInputType.numberWithOptions(
                      decimal: false,
                      signed: false,
                    ),
                  ),
                ],
        );
      },
    );
  }

If you create a copypastable and runable main.dart I'll try to help you

Hi @SmirnovM91,
Thanks for usnig Reactive Forms and for the issue.
Usually if you are going to create a validation that involve multiple fields of the form, then you should define the Validator at FormGroup level, not to a particular field.
In this example, the mustMatch validator is defined at FormGroup level and it checks that password and passwordConfirmation have the same value:
final form = FormGroup({
  'password': FormControl<String>(),
  'passwordConfirmation': FormControl<String>(),
}, validators: [
  Validators.mustMatch('password', 'passwordConfirmation'),
]);

Closing this issue because we haven't received any update on it.


Look into complex array query parameters

According to http://swagger.io/specification/#itemsObject complex array items are not supported and the code from https://github.com/NSwag/NSwag/issues/492 will never be called for a valid Swagger spec:

The value MUST be one of "string", "number", "integer", "boolean", or "array".

... and thus the type is never "object" or empty (any type)
This why we may have to further look into this.
Option 1:

Leave as is as it does not break anything and may work correctly for some malformed Swagger specs

You may also look at this sample spec generated by Swashbuckle and is valid according to the official swagger.io editor tool

@RicoSuter is this issue referring to parameters generated in controllers with the [FromQuery] attribute?
{asp net core 3}
For example, I have an object a use for paging search results:
The controller action looks like this:
 [HttpGet("api/search")]
 public async Task<IActionResult> Search([FromQuery] PaginatedResponse query)
{
    // implementation omitted
}

    public class PaginatedResponse
    {
        /// <summary>
        /// Gets or sets how many files to return.
        /// Defaults to 64.
        /// </summary>
        public int Take { get; set; } = 64;

        /// <summary>
        /// Gets or sets how many files to skip before returning.
        /// Defaults to 0.
        /// </summary>
        public int Skip { get; set; } = 0;
    }

I can't figure out a way to make these parameters camelCase in the OpenAPI definition

How can I make these camelcase?

I think you can put [FromQuery("take")] on the properties to change the names

Closing this in favor of #2708


Remove access fields from tests, uistatic

Remove access fields from tests, uistatic - these should have been part of https://github.com/uProxy/uproxy/pull/762
Tested in grunt test, chrome, firefox

:+1:


ModuleNotFoundError: No module named 'zxingcpp'

Hey i am on a aarch64 system and built the module successfully with the setup.py. When i check if the module is in my python environment every thing is okay.... but when i try to import the module into a python file and try to run it, it says that there is no module...
Is there any help or does someone have the same issue?
Thanks!

Can you try to copy the zxingcpp.[...].so file into the same directory as your python script and try again?

Hey axxel, thanks for you fast reply! I don't have such a file inside my site-packages folder... i have a folder called zxing_cpp-2.2.0-py3.8-linux-aarch64.egg, inside this folder a is a other folder called EGG-INFO and three .so files libZXing.so, libZXing.so.2.2.1 and libZXing.so.3. i tried to copy those three files in the same directory as my python script is but with the same result.

If I execute python setup.py build in wrappers/python I get a subdirectory build/lib.linux-x86_64-cpython-312 which contains exactly one file zxingcpp.cpython-312-x86_64-linux-gnu.so and that is the python module.

Yes on a normal x86 computer this is the case but on my aarch64 system i get after building this folder zxing_cpp-2.2.0-py3.8-linux-aarch64.egg :|

Can you paste the complete output of the python setup.py build command?

I found a solution: I downloaded the zxing-cpp-2.1.0.tar.gz from pypi and built in with this setup.py with the command python setup.py install. Now i got the zxingcpp.cpython-38-aarch64-linux-gnu.so and it is working :)

Ok. And if you use the latest release 2.2.0 it does not work? If so, could you please provide the output of the python setup build command to allow me to get some insight into what is wrong?

Also the latest release works fine! What i did before was cloning the git repo then moving into the folder and run this command: python /home/multi/zxing-cpp/wrappers/python/setup.py install
(by the way is there any documentation how to handle the (result.position output to draw bounding boxes)) ?
Then the output was this:
running install
/home/multi/barcodeTrail/lib/python3.8/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.
!!
    ********************************************************************************
    Please avoid running ``setup.py`` directly.
    Instead, use pypa/build, pypa/installer or other
    standards-based tools.

    See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
    ********************************************************************************

!!
self.initialize_options()
/home/multi/barcodeTrail/lib/python3.8/site-packages/setuptools/_distutils/cmd.py:66: EasyInstallDeprecationWarning: easy_install command is deprecated.
!!
    ********************************************************************************
    Please avoid running ``setup.py`` and ``easy_install``.
    Instead, use pypa/build, pypa/installer or other
    standards-based tools.

    See https://github.com/pypa/setuptools/issues/917 for details.
    ********************************************************************************

!!
self.initialize_options()
running bdist_egg
running egg_info
writing zxing_cpp.egg-info/PKG-INFO
writing dependency_links to zxing_cpp.egg-info/dependency_links.txt
writing top-level names to zxing_cpp.egg-info/top_level.txt
reading manifest file 'zxing_cpp.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'zxing_cpp.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-aarch64/egg
running install_lib
running build_ext
-- Checking for module 'stb'
--   No package 'stb' found
INFO: Qt (Gui/Multimedia/Quick) not found, skipping Qt examples
-- Configuring done
CMake Warning (dev) in example/CMakeLists.txt:
AUTOGEN: No valid Qt version found for target ZXingOpenCV.  AUTOMOC and
AUTORCC disabled.  Consider adding:
find_package(Qt<QTVERSION> COMPONENTS Core)

to your CMakeLists.txt file.
This warning is for project developers.  Use -Wno-dev to suppress it.
-- Generating done
-- Build files have been written to: /home/multi/zxing-cpp/build/temp.linux-aarch64-cpython-38
[ 94%] Built target ZXing
[ 98%] Built target ZXingWriter
[ 98%] Built target ZXingReader
[100%] Built target ZXingOpenCV
creating build/bdist.linux-aarch64/egg
copying build/lib.linux-aarch64-cpython-38/libZXing.so.3 -> build/bdist.linux-aarch64/egg
copying build/lib.linux-aarch64-cpython-38/libZXing.so -> build/bdist.linux-aarch64/egg
copying build/lib.linux-aarch64-cpython-38/libZXing.so.2.2.1 -> build/bdist.linux-aarch64/egg
creating build/bdist.linux-aarch64/egg/EGG-INFO
copying zxing_cpp.egg-info/PKG-INFO -> build/bdist.linux-aarch64/egg/EGG-INFO
copying zxing_cpp.egg-info/SOURCES.txt -> build/bdist.linux-aarch64/egg/EGG-INFO
copying zxing_cpp.egg-info/dependency_links.txt -> build/bdist.linux-aarch64/egg/EGG-INFO
copying zxing_cpp.egg-info/not-zip-safe -> build/bdist.linux-aarch64/egg/EGG-INFO
copying zxing_cpp.egg-info/top_level.txt -> build/bdist.linux-aarch64/egg/EGG-INFO
writing build/bdist.linux-aarch64/egg/EGG-INFO/native_libs.txt
creating 'dist/zxing_cpp-2.2.0-py3.8-linux-aarch64.egg' and adding 'build/bdist.linux-aarch64/egg' to it
removing 'build/bdist.linux-aarch64/egg' (and everything under it)
Processing zxing_cpp-2.2.0-py3.8-linux-aarch64.egg
creating /home/multi/barcodeTrail/lib/python3.8/site-packages/zxing_cpp-2.2.0-py3.8-linux-aarch64.egg
Extracting zxing_cpp-2.2.0-py3.8-linux-aarch64.egg to /home/multi/barcodeTrail/lib/python3.8/site-packages
Adding zxing-cpp 2.2.0 to easy-install.pth file
Installed /home/multi/barcodeTrail/lib/python3.8/site-packages/zxing_cpp-2.2.0-py3.8-linux-aarch64.egg
Processing dependencies for zxing-cpp==2.2.0
Finished processing dependencies for zxing-cpp==2.2.0

I don't know if that makes any difference but you are supposed to be inside the wrappers/python folder and then simply execute pyhton setup.py build. If you could confirm that this works even in you git cloned working copy that would be nice. You may also just close the issue as resolved if you don't find the time for that.


✨  Add support for monitoring kcp with prometheus-operator

This adds three ServiceMonitor objects that can be enabled to monitor the components deployed by the kcp Helm chart: etcd, kcp-front-proxy and kcp(-server).

/approve
/lgtm

@embik whats holding this up?

@embik whats holding this up?

Now that 0.23.0 is out with metrics-viewer battery fix: Days just having 24 hours.
I'll get back to finalizing this as soon as possible.

/hold cancel

/cc @mjudeikis

/lgtm


Repeated call improvements

I guess I would prefer to merge this after https://github.com/eth-sri/securify/pull/90 but otherwise LGTM.


Expected Behaviour
A default value that presents the animation correctly should be provided
Steps to Reproduce
Screenshots

Current default scale value:

What this looks like:

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

This is what amp-story has for their presets, but I agree this is unnoticably small. We can update to whatever tho since nothing prohibits us code wise from deviating from the amp animation defaults/presets

@samitron7 - Is there an updated default value for this that you'd like to recommend?

^^ above PR makes it so whatever is in the scale input is true to the deviation you see in the pulse animation. Before we were multiplying the input by 0.1 which was making it go from 0.995 -> 1.005, but removed that so now if you have scale: 0.05 in the editor input it should now be true to animation scale deviation and be 0.95 -> 1.05 which amp uses as it's preset value

Verified in QA


SyntaxError: /Users/quinnhammerlund/modmailbot-Bencadenc/config.json: Unexpected token } in JSON at position 611

I can't find the error, Help?

Remove the last , on line 14.

I forgot about the token (Stupid Quinn!!) And thanks!

I'm still getting that error 🤔

Make sure each row, apart from the ones with { } and the last one (port) have a trailing comma.

ok


Extra extensions directories

[x] Add flag for overriding builtin extension directory.
[x] Add flag to specify extra builtin extension directories.
[x] Add flag to specify extra user extension directories.

Fixes #693.

Amazing Asher 🤸🏽♂


Foreground fix

Implemented issue #63039.
After a couple of tests, it seems to be working as intended and now it is possible to customise the hover foreground color on setting.json.
Before:

After:

Finally, selecting high_contrast theme:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: simaosilva sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Problem matcher skips some matches when match for "info" severity is included in regex

This issues is in regards to the problemMatcher in tasks.json. In some cases, adding a capture group for severity which includes info/note causes some regex matches to be ignored.
Consider the following regex which should match gcc/g++ compilation output:
"problemMatcher": {
	"owner": "cpp",
	"fileLocation": ["relative", "${workspaceRoot}"],
	"pattern": {
		"regexp": "^(.*):(\\d+):(\\d+):\\s+(?:.*)?\\s*(warning|error):\\s+(.*)",
		"file": 1,
		"line": 2,
		"column": 3,
		"severity": 4,
		"message": 5
	}
}

The above regex matches all warning and error messages. However, if I modify the regex to capture all "note" information, like so:
"regexp": "^(.*):(\\d+):(\\d+):\\s+(?:.*)?\\s*(warning|error|note):\\s+(.*)"

Then some of the error messages are skipped in the "Problems" window. This only happens when multiple files have errors matched by the regex.
Attached is a minimum repro for Windows 10 (with WSL) and Linux. Requires g++ 4.9.
VSCodeWorkspace.zip
This is not a bug with the C/C++ plugin; the plugin is merely being used to demonstrate the bug.

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:21:47.485Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

cpptools
ms-vscode
0.11.4

csharp
ms-vscode
1.10.0

This got addressed in the problem collector a while ago. Problems can now come in random order.


Update for Firefox to prevent window.event error.

Based on this Stack Overflow: http://stackoverflow.com/questions/9813445/why-ff-says-that-window-event-is-undefined-call-function-with-added-event-list

@ghost thank you


Prompt of running services

This is how it looks:
79c354a7-validator-1  | host-runner: ENABLE_SUNODO_NODE is not set, skip the host mode...
79c354a7-validator-1  | Provisioning cartesi-machine snapshot...
79c354a7-prompt-1     | Anvil running at http://localhost:8545
79c354a7-prompt-1     | GraphQL running at http://localhost:8080/graphql
79c354a7-prompt-1     | Inspect running at http://localhost:8080/inspect/
79c354a7-prompt-1     | Press Ctrl+C to stop the node
79c354a7-prompt-1 exited with code 0

I'm not super happy with the last line, because it may give the user the impression something went wrong.
Any suggestion?

What if you use sleep infinity as a command inside a bash entrypoint that prints the medsage instead of this multiple files approach?

If I add a ; sleep infinity to the container command, the container is not being gracefully shutdown.

It's working now.
I feed it adds a few seconds to the startup process, as we have more healthy waits.

Please review

Yes, I think it's too long, but I also don't understand well why.


How to get data from response with errors?

Environment
Nuxt project info:

Operating System: Linux
Node Version:     v16.11.0
Nuxt Version:     3.0.0
Nitro Version:    1.0.0
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      srcDir, modules, build, routeRules, app, hooks, swiper, typescript, tailwindcss, apollo, experimental, runtimeConfig, postcss
Runtime Modules<EMAIL_ADDRESS>unplugin-icons/nuxt<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Describe the bug
I try to get data from response with errors. I can't extract "data" from the response when there are more "errors" next to it, I have already tried 2 libraries nuxt-graphql-client and @nuxt/apollo, both have the same situation.
nuxt-graphql-client

@nuxtjs/apollo

Expected behaviour
In addition to the error, I also expect to receive the data that is in the response
Reproduction
No response
Additional context
No response
Logs
No response

I found that by default, Apollo Client throws away partial data - link. In order to get these partial results I should define an error policy for my operation. But how is this done specifically in this library?

I also found in the graphql-request library that is used as the base for this library, that in order to get partial data from a request, you have to set errorPolicy: 'all' like this:
const client = new GraphQLClient(endpoint, { errorPolicy: 'all' })

source:  https://github.com/jasonkuhrt/graphql-request#errorpolicy


feat: Prototype PR for adding PgNumeric support

This is the prototype PR to get early feedback on the approach for adding PgNumeric support in Spanner.

@Rishabh-V I think it's best to wait for PGNumeric to be ready before re-reviewing this one, and also so you have refactored this PR in two separate commits, one for the changes concerning the introduction of TypeAnnotation, and one for actually adding support for PgNumeric across the Spanner lib.
Let me know if this sounds OK.

@Rishabh-V I think it's best to wait for PGNumeric to be ready before re-reviewing this one, and also so you have refactored this PR in two separate commits, one for the changes concerning the introduction of TypeAnnotation, and one for actually adding support for PgNumeric across the Spanner lib.
Let me know if this sounds OK.

Sure Amanda. I have fixed the review comments for PgNumeric. Should I raise a new PR for TypeAnnotation and PgNumeric support commits or can I add 2 commits to the PgNumeric PR itself? Please let me know and I will make the changes.  Thanks.

I think we can now close this PR in favour of #8261

Closing this PR as all the changes were done in PR #8261 and its merged now.


update galaxy

add more infos

tanks fo your changes. can you provide more documetation on the new added fields into the readme.md


[Errno -2] Name or service not known

Hi,
When adding my sensor toe the .plantgw.yaml I seem to get every time an error:
Wed, 01 Jun 2022 12:33:26 INFO     PlantGateway version 0.7.0 Wed, 01 Jun 2022 12:33:26 INFO     loaded config file from /home/pi/.plantgw.yaml Wed, 01 Jun 2022 12:33:26 INFO     Getting data from sensor Flower care Wed, 01 Jun 2022 12:33:26 ERROR    could not read data from C4:7C:8D:66:1A:05 (Flower care) with reason: [Errno -2] Name or service not known Wed, 01 Jun 2022 12:33:26 WARNING  fail_silent is set for sensor Flower care, so not raising an exception.
What's this error?

Was a bad .yaml file entry. This issue is solved.


python37Packages.hdmedians: 0.14.1 -> 0.14.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.hdmedians is: "High-dimensional medians"
meta.homepage for python37Packages.hdmedians is: "https://github.com/daleroberts/hdmedians"
meta.changelog for python37Packages.hdmedians is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.14.2 with grep in /nix/store/7k81nhd8r1in1khph5v8nyjv4qzhy37x-python3.7-hdmedians-0.14.2

directory tree listing: https://gist.github.com/fc3e2c3a7a8d2cddd1510c32951c0f66

du listing: https://gist.github.com/2f1fb0e25e251ed4707c07bfea00214f

Rebuild report (if merged into master) (click to expand)

23 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
7 x86_64-darwin rebuild(s)
6 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python37Packages.hdmedians
python37Packages.scikit-bio
python38Packages.hdmedians
python38Packages.scikit-bio
python39Packages.hdmedians
python39Packages.scikit-bio
tebreak

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7k81nhd8r1in1khph5v8nyjv4qzhy37x-python3.7-hdmedians-0.14.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.hdmedians https://github.com/r-ryantm/nixpkgs/archive/f6669640729917b846c70201b148eb676e28937c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7k81nhd8r1in1khph5v8nyjv4qzhy37x-python3.7-hdmedians-0.14.2
ls -la /nix/store/7k81nhd8r1in1khph5v8nyjv4qzhy37x-python3.7-hdmedians-0.14.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

7 packages built:

python37Packages.hdmedians
python37Packages.scikit-bio
python38Packages.hdmedians
python38Packages.scikit-bio
python39Packages.hdmedians
python39Packages.scikit-bio
tebreak

Maintainer pings
cc @costrouc for testing.

Result of nixpkgs-review pr 114868 at f6669640 run on aarch64-linux 1

3 packages failed to build:

python37Packages.scikit-bio
python38Packages.scikit-bio
python39Packages.scikit-bio

3 packages built:

python37Packages.hdmedians
python38Packages.hdmedians
python39Packages.hdmedians

1 suggestion:

warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/development/python-modules/hdmedians/default.nix:32:5:
   |
32 |     license = licenses.gpl3;
   |     ^


Forward tabs not working.

STR:
Try and indent some code by using tab.
Expected:
Tab indents the code as expected.
Actual:
Tab does not do anything. This is working on the standard JS grammar that Atom ships with.

This is an Atom issue but I don't know what causes it. Probably something to do with a partial install of the package. e.g. https://github.com/gandm/language-babel/issues/325

How weird, ok thanks - I'll try and look into it further.

Yep its exactly as you said. Thanks for the speedy reply anyway!


Can't use "Ref" or "Fn::Sub" in Metadata DockerTag

Hi,
Description:
I am trying to deploy a serverless application by using AWS Toolkit ("Publish to AWS" button) with Visual Studio 2019
It seems that "Ref" function does not work in "Metadata" attribute. (It works well on other parts of the serverless)
Steps to reproduce:
Example template :
{
    "AWSTemplateFormatVersion": "2010-09-09",
    "Transform": "AWS::Serverless-2016-10-31",
    "Description": "An AWS Serverless Application.",
    "Parameters": {
        "DockerTag": {
            "Type": "String",
            "Default": "tag:9.9.9",
            "Description": "The value the docker image will be tagged with."
	}
    },
    "Resources": {
        "Foo": {
            "Type": "AWS::Serverless::Function",
            "Properties": {
                "PackageType": "Image",
                "ImageConfig": {
                    "Command": ["Project::Namespace.Class::FunctionHandler"]
                }
            },
            "Metadata": {
                "DockerTag": {"Ref": "DockerTag"}
            }
        }
    }
}

Exactly the same behavior if I try to use "Fn::Sub" instead of "Ref"
"Metadata": {
    "DockerTag": { "Fn::Sub": [ "proxy-.${DockerTag}", { "DockerTag": {"Ref" : "DockerTag" }} ]}
}

Observed result:
... docker build -f "C:\Workspace\C-Next\evs-cnext-monitoring\EVS.CNext.Monitoring.\Dockerfile" -t jsondata object:latest .
Expected result:
... docker build -f "C:\Workspace\C-Next\evs-cnext-monitoring\EVS.CNext.Monitoring.\Dockerfile" -t tag:9.9.9 .
Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

OS: Windows 10
AWS Toolkit for Visual Studio 2017 and 2019 version : <IP_ADDRESS>
Visual Studio

Thanks for reaching out @vdesplanque . I was able to recreate this issue using the cloudformation that you listed above. The issue seems to be how the Toolkit is trying to apply the docker tag in the docker build invocation.
Instead of using my selected parameter value of "tag:1.1.1" it also printed out "jsondata" along with keeping the "object:latest" tag.


Add support for mailcap

Mailcap is a file that describes what programs to use to display each MIME type. As mentioned in a comment on #23, we could implement the same for URLs dialog, so users don't have to create macros like set browser "whatever" ; open-in-browser; set browser "the default".

On the other hand, there are already standalone tools like run-mailcap which can most likely fulfil this job just fine when set as a browser, safe maybe a minimal wrapper script (xdg-open falls into this category, too).

For future wanderers, the source for run-mailcap can be found in the mime-support package for ubuntu and debian. Source for that (currently) can be found inside http://http.debian.net/debian/pool/main/m/mime-support/mime-support_3.60.tar.gz

That doesn't quite fit: run-mailcap requires a file, which we don't have in URL dialog. I thought Newsboat would issue a HEAD request to learn the Conent-Type, and act on that.
I'd be glad for an opportunity to close this issue without doing much work, though, so if there are any more alternatives, bring them up!


Update README.md

fixed description how-to change file in Docker as "bash" is not  available and the "app" folder is the current directory when entering the container.

thanks!


Adding PodDisruptionBudget support

This resolves #4 by bringing in PodDisruptionBudget visibility into the output.
Sample Output:
└─┬ [Namespace]  pdb-test
  └─┬ [Deployment]  pdb-tester                   Replica: 3/3
    ├─┬ [Node]  kind-control-plane               [Ready] Node IP: <IP_ADDRESS>
    │ └─┬ [Pod]  pdb-tester-69655c77bb-s5dc8     [Running] Pod IP: <IP_ADDRESS>
    │   └── [Container]  pdb-tester              [Running] Restart: 0
    └── [ConfigMap]  kube-root-ca.crt

 Related Resources

Kind:        	Deployment
Name:        	pdb-tester
Replicas:    	3
---          	---
Kind:        	PDB
Name:        	pdb-tester
MaxAvailable:	33%
Disruptions: 	1
---          	---

with sample Pod/Pdb:
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: pdb-tester
  name: pdb-tester
  namespace: pdb-test
spec:
  replicas: 3
  selector:
    matchLabels:
      app: pdb-tester
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 40%
    type: RollingUpdate
  template:
    metadata:
      labels:
        app: pdb-tester
    spec:
      containers:
      - env:
        - name: START_WAIT_SECS
          value: "15"
        image: trondhindenes/k8sprobetester:latest
        imagePullPolicy: Always
        livenessProbe:
          failureThreshold: 3
          httpGet:
            httpHeaders:
            - name: Host
              value: KubernetesLivenessProbe
            path: /healthz
            port: 80
            scheme: HTTP
          initialDelaySeconds: 20
          periodSeconds: 10
          successThreshold: 1
          timeoutSeconds: 1
        name: pdb-tester
        readinessProbe:
          failureThreshold: 3
          httpGet:
            httpHeaders:
            - name: Host
              value: KubernetesReadinessProbe
            path: /healthz
            port: 80
            scheme: HTTP
          initialDelaySeconds: 20
          periodSeconds: 10
          successThreshold: 1
          timeoutSeconds: 1
---
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: pdb-tester
  namespace: pdb-test
spec:
  maxUnavailable: 33%
  selector:
    matchLabels:
      app: pdb-tester

Thanks for your contribution.


GQLGW-530 - added support for @hydratedFrom directive and added timeout to hydration in general

The new Nadel definitions look like this.  Naming is up for review - however we have done some in the Slack room already and this reflects that

 "This allows you to hydrate new values into fields with the @hydratedFrom directive"
input NadelHydrationFromArgument {
  name: String!
  valueFromField: String
  valueFromArg: String
}

enum NadelHydrationTemplate {
  NADEL_PLACEHOLDER
}

"This allows you to hydrate new values into fields"
directive @hydratedFrom(
   "The arguments to the hydrated field"
   arguments: [NadelHydrationFromArgument!],
   "The hydration template to use"
   template: NadelHydrationTemplate!) on FIELD_DEFINITION

"This template directive provides common values to hydrated fields"
directive @hydratedTemplate(
"The target service"
service: String!,
"The target top level field"
field: String!,
"How to identify matching results"
identifiedBy: String! = "id",
"Are results indexed"
indexed: Boolean = false,
"Is querying batched"
batched: Boolean = false,
"The batch size"
batchSize: Int = 200,
"The timeout in milliseconds"
timeout: Int = -1) on ENUM_VALUE

Please make sure you consider the following:

[ n/a ] Add tests that use __typename in queries
[ / ] Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
[x ] Is it worth using hints for this change in order to be able to enable a percentage rollout?
[yes ] Do we need to add integration tests for this change in the graphql gateway?
[ x] Do we need a pollinator check for this?

Note the current hydration directive is
"This allows you to hydrate new values into fields"
directive @hydrated("The target service"
  service: String!, "The target top level field"
  field: String!, "How to identify matching results"
  identifiedBy: String! = "id", "Are results indexed"
  indexed: Boolean = false, "Is querying batched"
  batched: Boolean = false, "The batch size"
  batchSize: Int = 200, "The timeout to use when completing hydration"
  timeout: Int = -1, "The arguments to the hydrated field"
  arguments: [NadelHydrationArgument!]) repeatable on FIELD_DEFINITION


analyzer for changes of environment variables in meshConfig.defaultConfig

Please provide a description of this PR:
This PR fixed issues#32602 and issues#34439, the former is for re-deploying Istio, the latter is for changing the environment variables in meshConfig.defaultConfig,  such as  PROXY_CONFIG and any other env variable in proxyMetadata

Here are the output steps below:

Install istio by istioctl install --set profile=demo -y --set meshConfig.defaultConfig.tracing.zipkin.address=jaeger-collector.istio-system.svc.cluster.local:9411
Deploy httpbin and sleep by kubectl apply -f samples/httpbin/httpbin.yaml and kubectl apply -f samples/sleep/sleep.yaml
Check pod's sidecar data by kubectl describe pods productpage-v1-xxxxxx in environment PROXY_CONFIG  of container istio-proxy
Re-install istio by istioctl install --set profile=demo -y --set meshConfig.defaultConfig.tracing.zipkin.address=jaeger-collector.istio-system.svc.cluster.local:14268 or change the value directly in configmap istio under the namespace of istio-system
Analyze via istioctl analyze -A and the result looks like below:

Warning [IST0149] (Pod httpbin-74fb669cc6-9tcrx.default) The environment variable configured with the running proxies on pods does not match the environment variable defined in the mesh configmap (dismatch environment variable in pod is {"tracing":{"zipkin":{"address":"jaeger-collector.istio-system.svc.cluster.local:9411"}}} and in mesh configmap is {"tracing":{"zipkin":{"address":"jaeger-collector.istio-system.svc.cluster.local:14268"}}}). This often happens when re-installing Istio control-plane and updating the mesh configmap.
Warning [IST0149] (Pod sleep-557747455f-xnjt9.default) The environment variable configured with the running proxies on pods does not match the environment variable defined in the mesh configmap (dismatch environment variable in pod is {"tracing":{"zipkin":{"address":"jaeger-collector.istio-system.svc.cluster.local:9411"}}} and in mesh configmap is {"tracing":{"zipkin":{"address":"jaeger-collector.istio-system.svc.cluster.local:14268"}}}). This often happens when re-installing Istio control-plane and updating the mesh configmap.
......

This doesn't take into account a large number of factors that will lead to excessive false positives. The source of the env var can come from MANY different areas - multiple configmaps, filemounts, explicitly setting it on the pod, annotations, etc. Revision can also be set on a per-pod basis, not just at the namespace level. This code assumes the happy path of a single configmap and no customization which is not sufficient; especially when this is reported for every pod this will lead to a lot of noise which we are already seeing is a big issue for analyzer.
I would be hesitant to move forward with this at all as its quite a mess to sort out, but if you are are still interested I think we should make sure we handle all of these cases... but if we handle each one the code will be incredibly complex.

Thanks @howardjohn, I understand your worries,  it should be a problem if customized environment variable will take precedence.  Therefore, I will temporarily close this PR.


feat(paths): use absolute paths

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added/updated (for bugfix/feature)
[ ] Docs have been added/updated (for bugfix/feature)

PR Type
What kind of change does this PR introduce?

[x] Feature (a new feature)
[ ] Bugfix (a bug fix)
[ ] Style (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
[x] Refactor (a code change that neither fixes a bug nor adds a feature)
[ ] Perf (a code change that improves performance)
[ ] Test (adding missing tests or correcting existing tests)
[x] Build (changes that affect the build system, CI configuration or external dependencies)
[ ] Chore (anything else), please describe:

What is the current behavior?

What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The feature is all good except for one thing:
Running the production.
Parcel 1 can not handle for now the custom TypeScript paths.
A plugins exists nevertheless there are a lot of compilation errors and anyway, it is not maintained anymore.
It lead to two solutions:

Wait for Parcel 2 (an official feature exists for the support)
Remove parcel to use something else to build the production

For now, I prefer the first solution since this feature is not a must have.

https://github.com/parcel-bundler/parcel/issues/202

@vvalembois no need to review it, the label waiting it set because it is not yet finished.


TOML parse breaks when given an directory path in windows

Description:
It is not possible to give a windows directory path in the toml file used by the config library.
Steps to reproduce:
mount_path = "C:/Users/Administrator/Downloads"

When running the app:
C:\Users\Administrator\IdeaProjects\bal-http-server>ballerina run target\bin\server-executable.jar
error: For input string: "sers"

OS, DB, other environment details and versions:
Windows

Duplicate of https://github.com/ballerina-platform/ballerina-lang/issues/21638. Here the solution is to give path within single quotes instead of double quotes as the toml library allows paths within single quotes.


[doc] generator with linting types does not work

Accoding to documentation, there is an option to add linting-types-js for enabling types linting. It's not working and I suppose it's unupdated documentation about that. What is a correct option for generator to enable that? If it still supposed to work of course.

I think this was removed from the generator to keep the number of options to a minimum, so we just have the docs for now since it's not really web component related.

We need to remove this mention of the generator in the docs.


CWL Viewer broken in develop branch

Bug Report
The CWL Viewer is not working on develop branch. Clicking on the CWL viewer radio button leads to this error (note url=undefined in the url):
The Common Workflow Language Viewer was unable to process the CWL. It returned the following error:
Http failure response for https://view.commonwl.org/workflows?url=undefined%2Fblob%2Fmaster%2Fmetaphlan_wfl.cwl: 400 OK

Steps to reproduce
Go to http://localhost:4200/workflows/github.com/dockstore-testing/Metaphlan-ISBCGC:master?tab=dag
Per @garyluu , problem is that the cwl-viewer.component.ts is expecting an ExtendedWorkflow but getting a Workflow.
Fix will most likely be needed in fullscreen mode as well.
┆Issue is synchronized with this Jira Bug
┆Issue Type: Bug
┆Fix Versions: Dockstore 1.6
┆Sprint: Seabright Sprint 6 Ferry
┆Issue Number: DOCK-525

➤ Charles Overbeck commented:
Verified in +2.3.0-beta.2+ ( https://github.com/dockstore/dockstore-ui2/releases/tag/2.3.0-beta.2 ) on staging.dockstore.org


Distance - "Out of pocket" and "Company spend" appear in report after changing distance

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.32-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4237772
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
1, Go to workspace chat.
2. Create a distance request.
3. Navigate to request details page.
4. Click Distance.
5. Change the distance.
6. Return to expense report.
Expected Result:
There will be no "Out of pocket" and "Company spend" in the expense report.
Actual Result:
"Out of pocket" and "Company spend" appear in the expense report after changing distance.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/ed160802-90b1-4310-9eac-f7f50899aba6
View all open jobs on GitHub

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

Damn... I can't even get to that page to edit the distance 😱

@aldo-expensify Would you be able to take a look at this one? It seems related to https://github.com/Expensify/App/pull/34107

Oh wait, seems like you are on top of it in another issue: https://github.com/Expensify/App/issues/35178#issuecomment-1911229178

Investigating...

ahh this is a duplicate of https://github.com/Expensify/App/issues/35178, it is the same root cause

Heh yes sorry that's what I was trying to say 😅

Damn... I can't even get to that page to edit the distance 😱

I also experienced this one while testing, I wonder if it is new problem or if it is in production. From what I remember, this happened right after creating the distance request when I tried to edit the locations.

Heh yes sorry that's what I was trying to say 😅

True, I read your comment poorly

Damn... I can't even get to that page to edit the distance 😱

Reproduced in production too, the steps are:

Create distance request
Without reloading the page, go to the distance request transaction
Try to edit the distance -> fail


Challenge "Regular Expressions: Reuse Patterns Using Capture Groups" not accepting a valid regex

Describe your problem and how to reproduce it:
This challenge is not aceepting the regex /^(\d+)(\s\1)\2$/ which is valid and matches all the conditions except one condition Your regex should have two spaces separating the three numbers. because it is checking whether 2 \s is used in the regex or if (\s) is used along with \1 or \2. So, it does not accept the above regex.
Add a Link to the page with the problem:
Regular Expressions: Reuse Patterns Using Capture Groups
Tell us about your browser and operating system:

Browser Name: Firefox
Browser Version: 83.0 (64-bit)
Operating System: macOS 11.0.1 Big Sur

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

Thank you, for taking the time to raise this issue. I can confirm the issue.
I suggest the test in question be removed:
Your regex should have two spaces separating the three numbers.
```javascript
assert(
  reRegex.source.match(/ |\\s/g).length === 2 ||
    reRegex.source.match(/\(\\s\)(?=.*\\(1|2))/g)
);
```

There should be no need for it, as the test conditions satisfy the requirements of the instructions. I am opening this to first timers only

I'm fine with removing that test.

I've went ahead and changed this one to start familiarizing myself with the code and hopefully keep contributing. Please tell me if there's any problem.


LDAP group membership is not recursive

Hi there,
gitblit is a wonderfull peace of software.  UserZ belongs to GroupB. By nesting this means UserZ is also member of GroupA. However gitblit only sees GroupB.
Furthermore, if a group has only other groups as members and therefor no users gitblit does not seem to "see" them. (Gitbltit 1.8 with AD as LDAP)
If you need more details i am happy to provide.
Cheers Jens

That is correct. This is a feature treated differently by different LDAP servers, if supported at all.
There is currently no support implemented in Gitblit to deal with such a set up.

Wow, that was fast ... :-) ok maybe in the future. There seems to be an issue with ldap searches however.
The nesting situation can be somewhat mitigatet by adapting the groupMemberPattern to:
realm.ldap.groupMemberPattern = (&(objectClass=group)(|(member=${dn})(member=${memberOf})))
This should find all groups which have the user as direct member and additionally all groups which have the users groups as member.
This filter is not designed to find groups in a chain - but you get at least one level of nesting.
Assume: GroupA has member GroupB has member GroupC has member UserZ.
GroupA should never be found, GroupB and GroupC should.
Above search should return GroupC (because: member=${dn}) AND GroupB (because: member=${memberOf}) however only GroupC is found.

It is possible to match users in a chain. It is a feature of AD.
The following value in gitblit.properties works for me:
realm.ldap.groupMemberPattern = (&(objectClass=group)(member:1.2.840.1135<IP_ADDRESS>1:=${dn}))
See: https://msdn.microsoft.com/en-us/library/aa746475(v=vs.85).aspx


Probably a bug near @inline

This behaviour is reproduced via https://github.com/sjrd/scalajs-benchmarks/pull/3 with current master.
java.math.Division.monReduction is something likes:
...
      val m = Multiplication.unsignedMultAddAdd(res(i), n2, 0, 0).toInt
      for (j <- 0 until modulusLen) {
        val nextInnnerCarry =
          unsignedMultAddAdd(m, modulusDigits(j), res(i + j), innnerCarry)
...

and unsignedMultAddAdd is very trivial:
  @inline def unsignedMultAddAdd(a: Int, b: Int, c: Int, d: Int): Long =
    (a & 0xFFFFFFFFL) * (b & 0xFFFFFFFFL) + (c & 0xFFFFFFFFL) + (d & 0xFFFFFFFFL)

But if we check that js is generated by monReduction we can see:
...
    $m_Ljava_math_Multiplication$();
    const a = res.get(arg1);
    const a0 = (65535 & a);
    const a1 = ((a >>> 16) | 0);
    const b0 = (65535 & n2);
    const b1 = ((n2 >>> 16) | 0);
    const a0b0 = $imul(a0, b0);
    const a1b0 = $imul(a1, b0);
    const a0b1 = $imul(a0, b1);
    const lo = ((a0b0 + (((a1b0 + a0b1) | 0) << 16)) | 0);
    let i$1 = 0;
    while ((i$1 < modulusLen)) {
...

and this call a function exists
...
        var k = void 0;
        k = 0;
        R();
        var l = f.a[g],
            n = 65535 & l,
            r = l >>> 16 | 0,
            u = 65535 & d,
            t = d >>> 16 | 0;
        l = m(n, u);
        r = m(r, u);
        n = m(n, t);
        n = l + ((r + n | 0) << 16) | 0;
        for (l = 0; l < a;) {
...

This function is defined as:
function $m_Ljava_math_Multiplication$() {
  if ((!$n_Ljava_math_Multiplication$)) {
    $n_Ljava_math_Multiplication$ = new $c_Ljava_math_Multiplication$()
  };
  return $n_Ljava_math_Multiplication$
}

This call doesn't do anything at this case, because the body was inlined.
You can see some differences with and without this R() — I've cleaned it up by hand:
➜  scalajs-benchmarks git:(added-bignums) node bigNumbers/.js/target/scala-2.12/bigNumbers-opt.js
bigNumbers.ModBenchmark$: Node.js;1499576.8605984747;250.7403228241497
➜  scalajs-benchmarks git:(added-bignums) node bigNumbers/.js/target/scala-2.12/bigNumbers-opt.js
bigNumbers.ModBenchmark$: Node.js;1323191.7049996555;244.21177772706403
➜  scalajs-benchmarks git:(added-bignums)

It's a call to load the module (object). It must be kept for correctness in case its constructor is not pure. For trivial constructors, the optimizer can figure out that they're pure and eliminate the call. But the constructor of object Multiplication is not trivial enough for that.
There are some more related information about module loading in this is ticket: #1588.

@sjrd but why you need to call a constructor of inlined function that hasn’t call anything from object?

Because the constructor of said object could have side effects or be impure. It is simply not correct to disregard those potential side effects. The linked issue discusses this in detail.