accessing settings from the gear icon from sidebar not working

Today I noticed pressing the 'gear' icon doesn't do anything. Also the "->" icon or "CTRL" icon don't do anything, but in case of the CTRL icon I guess it could be just that if it's supposed to emulate the keyboards ctrl key then I guess nothing should happen anyway.
I did reboot my phone before I noticed the problem. After noticing the problem I went to the keyboard settings and tried to tap the "settings" under 8vim, but that doesn't do anything either, so I went to the 8vim icon on the phone's "desktop". That opens up the 8vim settings page as expected. Now there I try to "resize circle", but for some reason the circle is not changing size. I did resize it 2-3 days ago succesfully when I installed the app. I guess I try delete all data and see if that helps, or reinstall the app?
extra/off-topic:
I saw 8vim 2-3 days ago on f-droid front page and it seemed interesting and I decided to try it. I have been typing a bit, but not much so maybe it's that I haven't gotten experienced yet, but after say .. maybe 200-400 typed words now I do remember the layout quite well except 3rd or 4th sector ones I might not remember until after I think about it for one second or check the layout. Typing is slow which is not the problem at this point as a beginner, but rather that I am struggling to exit from the correct sector every now and then, (for example typing "r" when I meant "a")  so I am making typos. Is this something that I will get better at, or is this a common problem?  I was wondering that maybe some time in the future A.I. could learn from the size of curves I make in a way that I wouldn't need to know where the middle circle is or where the sector limits are and typing would become easier?
The other more urgent improvements that I have thought about have been discussed here aswell, so I guess I can expect those in the (near?) future. Those would be the umlauts (I like the 4th proposal of the possible implementations), suggestion bar (that expands the dictionary from the words I have typed) and a clipboard. I want to mention that I am an avid user of the swiftkeys sticky clipboard items. Meaning that I have added some words (or special utf8 chars) as sticky items that I use alot and then access them from the clipboard list. Also I like the idea of the feature some user mentioned about skipping vowels on words allowing them to appear on the suggestion bar. I would definitely give that a try if it was available.
edit: I have Xiaomi Redmi Note 7 with MIUI Global 11.0.5 and Android version 10 QKQ1...Today I noticed the circle size had changed, I tried changing it again but it didnt work right away, then after restarting 8vim (it didnt yet work) but then I did something else and when I got back to typing something the circle had changed.

So, as I understand you faced 2 bugs

setting changes not affecting the ui
gear icon on the main keypad not working

For the first one,  please see #36
For the second one, I might be missing something. The gear icon is suppose to open the settings activity, so if you are already there you won't seen any change. As I understand, the gear icon is working as expected ... I feel I have missed something.

Here's a short video where I type.. or write(?) a text "testing" and then I try press the buttons on the left side. Two of the buttons do something visibly, the three other I haven't figured out what they do. One in the middle opens the keypad and the upper one opens google voice, which I have set as the emoji keyboard or what it was called. I wanted a quick access to that. https://imgur.com/a/k7aXyXS

Interesting.
I will try to figure out what is going wrong.

iteration-7 on a Samsung Galaxy S6 with Android 7.0. Tapping the gear icon tries to open a new screen but immediately crashes.

The current application is targeted at android 11, and you are using
android 7, so it is likely some lib used in the UI page is not compatible.
Based on statistics from "
https://gs.statcounter.com/android-version-market-share/mobile-tablet/worldwide
"
Android 7.0 holds less then 5% market share, (which is not insignificant)
I think I have hastily upped the target version and should support at-least
Android 6 .
I will try and do the necessary research.
On Tue, May 18, 2021 at 12:13 AM Geofrey Sanders @.***>
wrote:

iteration-7 on a Samsung Galaxy S6 with Android 7.0. Tapping the gear icon
tries to open a new screen but immediately crashes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/flide/8VIM/issues/86#issuecomment-842547514, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABX5WR2PI5OPJ4DZ5NQB2ETTOFPUJANCNFSM4TL5Z5SQ
.

Okay I double checked, the minimum Android supported on 8vim is Android 5.
And I ran a test on an emulated device with Android 5.1, works with no
issues.
I also tested the app on an emulated Pixel device with Android 7.0. So it's
clearly not a android issue.
Not sure, how to figure this out.
On Tue, May 18, 2021 at 8:00 AM @.*** @.***>
wrote:

The current application is targeted at android 11, and you are using
android 7, so it is likely some lib used in the UI page is not compatible.
Based on statistics from "
https://gs.statcounter.com/android-version-market-share/mobile-tablet/worldwide
"
Android 7.0 holds less then 5% market share, (which is not insignificant)
I think I have hastily upped the target version and should support
at-least Android 6 .
I will try and do the necessary research.
On Tue, May 18, 2021 at 12:13 AM Geofrey Sanders @.***>
wrote:

iteration-7 on a Samsung Galaxy S6 with Android 7.0. Tapping the gear
icon tries to open a new screen but immediately crashes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/flide/8VIM/issues/86#issuecomment-842547514, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABX5WR2PI5OPJ4DZ5NQB2ETTOFPUJANCNFSM4TL5Z5SQ
.

On one hand I in particular expect to replace this device soon so don't put
yourself out on my account. On the other hand I'm surely not the only one
with an old phone.
On Mon, May 17, 2021, 23:22 Ravi Agarwal @.***> wrote:

Okay I double checked, the minimum Android supported on 8vim is Android 5.
And I ran a test on an emulated device with Android 5.1, works with no
issues.
I also tested the app on an emulated Pixel device with Android 7.0. So it's
clearly not a android issue.
Not sure, how to figure this out.
On Tue, May 18, 2021 at 8:00 AM @.*** @.***>
wrote:

The current application is targeted at android 11, and you are using
android 7, so it is likely some lib used in the UI page is not
compatible.
Based on statistics from "

https://gs.statcounter.com/android-version-market-share/mobile-tablet/worldwide

"
Android 7.0 holds less then 5% market share, (which is not insignificant)
I think I have hastily upped the target version and should support
at-least Android 6 .
I will try and do the necessary research.
On Tue, May 18, 2021 at 12:13 AM Geofrey Sanders @.***>
wrote:

iteration-7 on a Samsung Galaxy S6 with Android 7.0. Tapping the gear
icon tries to open a new screen but immediately crashes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/flide/8VIM/issues/86#issuecomment-842547514, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABX5WR2PI5OPJ4DZ5NQB2ETTOFPUJANCNFSM4TL5Z5SQ

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/flide/8VIM/issues/86#issuecomment-842796095, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAWXSPUKZ2ECLF2H6UNGSDTOHMN5ANCNFSM4TL5Z5SQ
.


Added file format migration example to README

Provided example for moving all use cases of a specific file format to the README, very useful if migrating existing repositories to LFS usage.

Hey, I really appreciate you writing this up. Any thoughts on moving this to the wiki, instead? It seems like a better place for things like this. The steps are only applicable for Windows, and probably not every use case. The wiki would be a good place for you and other contributors
I want to keep all technical docs (specifications, man pages, etc) in the repository, but not user tutorials.

Sure thing, here you go: https://github.com/github/git-lfs/wiki/Moving-existing-file-formats-to-LFS-on-Windows

Thanks, closing this out, for now. I'll experiment with organized wiki pages, so you could go to a page like Migration, with links to tips like this. Then we'd link to Migration from the README.


RuntimeError: inconsistent tensor sizes at /pytorch/torch/lib/TH/generic/THTensorMath.c:2709

When running test_net.py this happens, anyone any idea why?
Traceback (most recent call last):
File "test_net.py", line 232, in
data = next(data_iter)
File "/home/guyan/anaconda3/envs/Maxwell2/lib/python2.7/site-packages/torch/utils/data/dataloader.py", line 179, in next
batch = self.collate_fn([self.dataset[i] for i in indices])
File "/home/guyan/anaconda3/envs/Maxwell2/lib/python2.7/site-packages/torch/utils/data/dataloader.py", line 109, in default_collate
return [default_collate(samples) for samples in transposed]
File "/home/guyan/anaconda3/envs/Maxwell2/lib/python2.7/site-packages/torch/utils/data/dataloader.py", line 91, in default_collate
return torch.stack(batch, 0, out=out)
File "/home/guyan/anaconda3/envs/Maxwell2/lib/python2.7/site-packages/torch/functional.py", line 64, in stack
return torch.cat(inputs, dim)
RuntimeError: inconsistent tensor sizes at /pytorch/torch/lib/TH/generic/THTensorMath.c:2709

@guyan277 did you try to run test_net.py with batch data? If that's true, now our code does not support this. You should specify the batch size = 1.

@jwyang thx for replying, i have just found that. if i want to test with batch data, where should i modify the code ? the blob.py ?

@guyan277 , In this case, you can use the dalaloader for training data.


Add my own functions

Hello,
Is that possible to add my own function to call them in Qlik ? if Yes I have to modify the _main.py file and the functions.json in which folder and do i have to modify other file or create new one ?
Thank you
:)

Hi @Faustiine , yes you can add your own functions in the __main__.py file under the ExtensionService class. The function definition that will be visible in Qlik needs to be added under the functions.json file. The mapping to tie these bits together is defined in the functions property of the ExtensionService class.
If you're extending this SSE you can modify the files under the qlik-py-tools/qlik-py-env/core folder. If you want to build your own SSE, the examples at qlik-oss may be a good start.

Thank you for your answer, I did all of that in the _main.py in the qlik-py-tools-5.1\core , add my function under ExtensionService class, add the id number in the mapping of function and add the function in the json file but when I am in Qlik my new function doesn't appear.


frac_gc in tools.py throws error

When I try to run frac_gc, I get the following error:
/home/sameer/miniconda3/lib/python3.6/site-packages/bioframe/tools.py in _each(chrom_group)
149         for _, bin in chrom_group.iterrows():
150             s = seq[bin.start:bin.end]
--> 151             g = s.count('G')
152             g += s.count('g')
153             c = s.count('C')
AttributeError: 'Sequence' object has no attribute 'count'
I think this is because the variable s is an OrderedDict() of <chrom_name> and associated FastaRecord. The fasta record needs to be a string variable before the count method can be used successfully.

I may or may not have fixed it in https://github.com/mirnylab/bioframe/commit/d0f6b74090986ac9e025d1bb713e5b4cfe609ef3
may I ask you to test the proposed fix?

Tested and issue seems resolved. Thanks!

thanks for reporting and testing!!


MicroG services account aleady exist while try sig in

Good Morning,
I use MicroG services <IP_ADDRESS>80 and when I try log into Google Music I get a error that this acoount already exist on this device.
Can someone help me?

I had a similar problem with Play Store and Maps, IIRC. I deleted the account from the device and changed the login order, then it worked.

I had a similar problem with Play Store and Maps, IIRC. I deleted the account from the device and changed the login order, then it worked.

I solve this issue, but when I log into Google Music I don`t see any of my playlist etc


Add port forward for services (#2037)

Epinio services can now be accessed from the host by executing:
epinio service port-forward SERVICENAME [LOCAL_PORT] [...[LOCAL_PORT_N]] [flags]
Issue: https://github.com/epinio/epinio/issues/2037

This will be instead split into small PRs.


Context menu is not triggered on iPhones and/or iPads

Is your feature request related to a problem? Please describe.
Long-press is the alternative to trigger context menu on devices with touchscreen. For this package, this technique works on Android, but not on iPhones and iPads.
Describe the solution you'd like
I would like the context menu to be triggered by long-pressing on an iPhone or an iPad.
Here's an example where iPhones and iPads work: https://www.radix-ui.com/primitives/docs/components/context-menu
Describe alternatives you've considered
I do not have any alternative for this problem.
Additional context
N/A

After some research, I have found that the contextmenu is just not supported on webkit.
This is extremely unfortunate. I understand that there is no simple solution to this without a massive amount of workaround. As such, please feel free to close the problem unless you would like to further work on it.

The implementation of shadcn is somehow able to trigger this, though not perfect (it also triggers a text selection event). I'll look into further.

My attempt to custom implement my own long-press event to circumvent iOS limitation did not succeed. I will now seek an alternative to context menu and close this issue.


bug: Back button now shown on Android

Type: bug
Ionic Version: 2.0 beta11
Platform: android 5.1 webview
When paged is pushed in as following then it does not show back button:
this._navController.pop().then(() => this._navController.push(Page));

Hello! Thanks for opening an issue with us!  Are you pushing a popping and pushing a page from an overlay component such as an alert, actionsheet, or popover? Thanks for using Ionic!

Hi,
Sorry for the delay. The page is standard page and not a modal of any kind. I did change the code to following:
this._navController.push(Page).then(() => {
this._navController.remove(this._navController.length() - 2, 1, {
animate: false
});
});
Which works but difference is that it first pushes in the new page and then removes the page underneath.


Should the set of both AV and WSI in iofence command be illegal

When an IOFENCE.C command completes,  AV or WSI could be configured for the indication. The WSI bit when set to 1 causes a wired-interrupt and AV=1 indicates a 4-byte store. However, there is no restriction whether AV and WSI could be set at the same time.
When fctl.wsi=0, setting WSI in IOFENCE.C is illegal and we could use AV bit to indicate the IOFENCE.C completion.
When fctl.wsi=1, when AV and WSI bit are set together, their behavior would both be valid.
Taking note of this description from spec,

Software may configure the ADDR[63:2] command operand to specify the address of the seteipnum_le/seteipnum_be register in an IMSIC to cause an external interrupt notification on IOFENCE.C completion. Alternatively, software may program ADDR[63:2] to a memory location and use IOFENCE.C to set a flag in memory indicating command completion.

If the software follows the first option, then it seems a MSI write as well as a WSI notification would both happen. This is a bit stange.
If the software takes alternative option, this indication looks redundant since wired-interrupt is provided as well.
From my understanding, I assume that AV and WSI bit are not expected to be set together.  Further, if this is right, should the set of both AV and WSI in iofence command be illegal?

The AV and WSI may usually not be set together but it is not illegal for software to request that.

I may need to confirm one point.
When AV and WSI are both set, their behavior would both be valid (though it maybe unexpected). Under this circumstance, should any priority between them or both be allowed?

Thanks a lot.


add ProgressCircular in ImportExcelModal

review it, please.

Should fix indented in the code

I know that  I config the 2 space indented format.
so, I suggest that add a .editorconfig file to the solution items to define code style.

Anyway you should fix this in the PR before merge it.

fixed.


Is dashrep-file-name-if-read-file-missing deprecated?

Hi Richard (@cpsolver),
Is the phrase dashrep-file-name-if-read-file-missing deprecated? A search for code on GitHub, only shows reference files in the results, with no actual code usage.
The only related commit, shows it being removed from list-of-phrases-with-quoted-strings.txt, but being added to specifications_phrase_categories_and_names.txt.
Should it be included in specifications_phrase_categories_and_names.txt if it is not being used in actual code? If it should be removed from this file, then I can create a pull request for this purpose.
Kind Regards,
Liam

I don't remember what dashrep-file-name-if-read-file-missing is supposed to do.  When I read the description in the documentation it didn't make sense.  Since you say it isn't implemented in code, yes we should remove it from the documentation.  Once again, thank you for finding this error!  And thanks in advance for fixing it!  (I apologize for the delay; I've been busy answering questions about ranked choice voting, which will doubly be on the November election ballot here.)

Hi Richard (@cpsolver),
Not a problem! There is no need to apologize as there is actually real life outside of GitHub! 😄 As noted above, I have created PR https://github.com/cpsolver/Dashrep-language/pull/16 to resolve this issue. If the pull request is satisfactory, then this issue will be automatically closed when the PR is merged.
Kind Regards,
Liam


Backend for Gaia Dashboard

Create a Express Typescript server, that instantiates a Gaia HUB instance fully automated.
For this check the following notion to learn what steps are currently done manually and automate them:
https://www.notion.so/Local-Installation-c243fb57ca004c918ab780321b47f2ae
https://www.notion.so/Deployment-360498ca35dc498998f54ccf0f9eb82d
Also define what data the user has to provide (configuration)

I somehow cannot add @fritzsima as Assignee, but he is the one implementing this issue.


Add pylint to pre-commit

@webknjaz I think I do not right to write path in pre-commit.

Yes, I did a mistake.
Fixed it.


User.MultipleObjectsReturned: get() returned more than one User -- it returned 2!

https://sentry.io/share/issue/5453bab130884dd0a3eb0a96d4bc9046/

stale


Consistency updates

Remove ConfigurationManager dependency from nuspec
Standardize App Context switch name for "UseManagedNetworkingOnWindows"

If you are updating the switch name, you'll also need to update the BUILDGUIDE and DataTestUtility.cs. Then I assume the pipeline will need to be updated, too.

Looks like you just did that. :)

Be sure to think about what the pipelines should look like for building slightly older code, too. Since this switch just came out in 2.0 previews, maybe we don't need to support the previous name.

Pipelines are run based on config.json property UseManagedSNIOnWindows which is untouched, and AppContext name is taken care in DataTestUtility, so we are good :)


Allow closing of geometries with a keybinding

Original issue for this is https://github.com/JamesLMilner/terra-draw/issues/2 (thank you @dabreegster!) , I am extracting this so it can be tackled in isolation.
Being able to close a geometry using a keyboard shortcut whilst drawing may be a nice improvement and probably wouldn't be too much work to implement. This approach is taken in other open source drawing libraries, so people may expect this behavior.
I would recommend that as with all keybindings in Terra Draw, we make it configureable.

Implemented in 0.0.1-alpha.8


open port for wireguard in acl

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Unit test must be updated:
 [ERROR] acl_request_by_config_server(com.yahoo.vespa.hosted.provision.restapi.NodesV2ApiTest)  Time elapsed: 0.196 s  <<< FAILURE!
15:19:10 org.junit.ComparisonFailure: acl-config-server.json expected:<...y":"cfg1.yahoo.com"}[]]}> but was:<...y":"cfg1.yahoo.com"}[,{"port":51820,"trustedBy":"cfg1.yahoo.com"}]]}>

Another test failure:
AclProvisioningTest.trusted_nodes_for_config_server:112 expected:<[4443, 22]> but was:<[22, 4443, 51820]>


Enhancement: Add option for live recording + transcription

Why not?
from: https://gist.github.com/Vaibhavs10/a48d141534cc8d877937d421bb828d8e
#pip install git+https://github.com/huggingface/transformers.git

import datetime
import sys
from transformers import pipeline
from transformers.pipelines.audio_utils import ffmpeg_microphone_live

pipe = pipeline("automatic-speech-recognition", model="openai/whisper-base", device=0)
sampling_rate = pipe.feature_extractor.sampling_rate

start = datetime.datetime.now()

chunk_length_s = 5
stream_chunk_s = 0.1
mic = ffmpeg_microphone_live(
    sampling_rate=sampling_rate,
    chunk_length_s=chunk_length_s,
    stream_chunk_s=stream_chunk_s,
)
print("Start talking...")
for item in pipe(mic):
    sys.stdout.write("\033[K")
    print(item["text"], end="\r")
    if not item["partial"][0]:
        print("")

Done.


Add eureka metadata dynamically

Question:
How can I dynamically add metadata, so that the EurekaDiscoveryClient in my application will send it to Eureka?
I know that statically configuring it in appsettings.json does work, but I need to be able to add information in a dynamic way. I tried to use ApplicationInfoManager instance, but this instance does not appear to be initialised.
I found a similar question on spring-cloud Github issues: https://github.com/spring-cloud/spring-cloud-netflix/issues/62#issuecomment-62534871
Is there a similar way to do that using dotnet?

It is possible to access the EurekaApplicationInfoManager from the DI container, and add metadata to the app instance programmatically...
public MyClass(EurekaApplicationInfoManager infoManager)
{
    _infoManager.InstanceConfig.MetadataMap["some key"] = "Some new value";
}

Unfortunately it doesn't look like we have anything wired up to automatically update the registration, but you can call Initialize again with the updated instance config and that seems to work on the next heartbeat:
_infoManager.Initialize(_infoManager.InstanceConfig);

This use case should be thought about during #131 in case there's a convenient crossover opportunity, otherwise it would be nice if there was a community contribution here


Add Maven Shade plugin configuration to create a shaded artifact JAR

Add Maven Shade plugin configuration to create a shaded artifact JAR that bundles a relocated Guava.  This allows Trickle to be bundled with projects that require a different, incompatible Guava version.

I'm actually withdrawing this pull request for now, since I just noticed that it has some issues.  The fact that it renames the Guava interface names causes some library client code to break.  If your Trickle code uses lambdas you don't notice, but older Java 7 code that tries to pass in references to Guava classes runs into trouble.
Still, it seems to me like a solution is needed to allow Trickle to play more nicely with other libraries that depend on different Guava versions.  Maybe an upgrade to Java 8 (like in another pull request I have) would allow for Tricke's external-facing interfaces to be based on Java 8 native interfaces like java.function.Function instead of Guava's versions that get shaded by this patch.


[chartmuseum] upgrade and add new env var for anonymous GET operation…

…s, when basic auth enabled

Upgrades to the latest chartmuseum v0.2.8
Include default value for a new env var AUTH_ANONYMOUS_GET  so it's disabled OOTB

/lgtm


Fix "Identity verification" copy in support admin menu

Description
There is a typo in the copy on the support admin menu page. Please change the link to say "Identity verification" instead of "Identify verification"
Acceptance criteria
Links behave as before
Link copy is changed as described

Work has been completed in #6072


Improving download artifact logging upon failure

Log file share path before starting the download
Log error during download before retrying
Don't retry for issues that will not get fixed with retry

Looks good.

I'm doing a new preview tomorrow.  We're testing.  So if you want this in the next preview, get in tonight/early in morning.  Sounds like it's ready to go


feat: sync committee message production

Motivation
Start producing sync committee messages and broadcasting them in the subnets.
Description
This PR focus on producing and broadcasting sync committe messages, for that we need to calculate duties for the active validators, and make sure the recalculation of periods is now done when needed. This PR is aprt of the Sync Aggregate effort and just the first step in that direction, aggregates will probably change a lot how data is represented in duties, but for now this is sufficient for other nodes to pick app and aggregate our sync committee messages [link for Validator spec]
Closes #800, #834 & #835

Sync committee message production working for 6 periods and 50 epochs


Actor sheet will not open.

I am pretty sure this error is from the Compact DnDBeyond 5e Character Sheet module.  Actor sheet for any actor where this sheet would open just fails.  Error message from Electron browser is as follows:

Using version:  0.10.1

uh oh. thanks for the report! I'll take a look asap.

fixed in 0.10.2 (this is what I get for copying code from tidy sheet 😅, I forgot to check if the helpers here were foundry core and they were not)


Make the Git repository URL configurable.

User will be creating their own repository based on our template repository at https://github.com/QCDIS/NaaVRE-cells.
So we need both URL and token

fixed by #pull/29


Add app loader

I'm a fan of a loading screen in general as opposed to showing a blank screen for anything > 4 sec

Coverage decreased (-0.3%) to 82.019% when pulling 5de357639f1123122af6b638cabd97ed2e06c40f on eatonphil:add-app-loader into 46eb5e1d6e1ba2ab31c1be0f9200a113f7d5d253 on linode:master.

We could show this over the UI with an opacity:

So long as response times are reasonable (not 10 seconds), I'd rather the app be fully ready before we show anything.

The header (minus notification counts) should be static. Why can't they be loaded immediately while you wait for the body content below? Like the following (Blue constant & Red dynamic content waiting for complete responses):

BTW - see the following for React loading screen example.
https://stackoverflow.com/questions/40987309/react-display-loading-screen-while-dom-is-rendering

I agree w/ @phuegel that we should show the header UI at least while body loads.

The most we can do here is display the header with the Linode logo (and the three main nav items). However, it is not possible to show the rest of the items because (like the body), they are not returned immediately. I'll make a commit to add the header and the Linode logo for now. But I don't think it's appropriate to show the header nav items because those are clearly "logged in" items and it isn't clear you aren't entirely "logged in" until we can display your username at least.

Updated with some nice improvements:

Improvements include:

Moved all session related logic into src/sessions.js alone
Make authenticated calls first in src/layouts/Layouts.js so the redirect to login gets triggered sooner
If a request fails with 401, remove the current token from localstorage so if you happen to not log in immediately and refresh the page, no time is wasted redirecting you to login.

@eatonphil build failing?

Coverage decreased (-0.1%) to 80.836% when pulling 024da69309ad9d24958a0de6c41cb6a9a270e31d on eatonphil:add-app-loader into 307dd97aaee02db14674d4a8e46e99afb9b60890 on linode:master.


Add context menu with cut, copy and paste

Addresses issue #306
Implemented by overriding EditView.defaultMenu. This allows for the system to handle right click events regardless of how the user has chosen to access context menus (tap with two fingers vs bottom right corner tap).
The NSMenu is implemented in EditViewController so that it can share the existing implementation.
NSMenuItem.keyEquivalent was left blank in keeping with the HIG. This also aligns with what Xcode does.
Future work should include a method to validate the menuItems actions. For example, “Paste” should be disabled when no items exist on the pasteboard. This might be a bit more involved than I initially thought since this should apply to items in the Menu Bar as well.
I went with cut, copy and paste and sensible defaults. Find might be another great initial menu item but I did have questions about its behaviour - namely beginning a search from selected text. This might probably then be implemented from the existing .find() action.
I'm sure there's a discussion to be had for what items will exist in the context menu as time goes on. Thanks!

Hi @MartinJrP, thanks for the pull request!
This looks like the right approach,  but I'm having trouble activating the menu with a control+click gesture. Not quite sure why that is, since macOS is supposed to show menus automatically.
You might find a better way to solve this, but one option is manually calling NSMenu.popUp(positioning:at:in:) when the EditView receives a control+click.

The NSTextInputClient thing is definitely still a mystery to most of us, which is largely why IME and press-and-hold accents don't work properly yet. Wouldn't be surprised if it had other side effects as well.

It's definitely got me beat so far. Don't have too much experience with the Text subsystem either. I'll add another commit that does add support for control+click as well as word_selection on accessing the menu

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@67a4ce7). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #343   +/-   ##
=========================================
  Coverage          ?   43.31%
=========================================
  Files             ?       31
  Lines             ?     3911
  Branches          ?        0
=========================================
  Hits              ?     1694
  Misses            ?     2217
  Partials          ?        0

Impacted Files
Coverage Δ

Sources/XiEditor/EditView.swift
54.75% <ø> (ø)

Sources/XiEditor/EditViewController.swift
25.26% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67a4ce7...879e11f. Read the comment docs.

Uhm, what's going on here?

Wasn't able to make too much headway on NSTextInputClient... A few ideas but nothing solid to report yet unfortunately. The last commit does add support for accessing the context menu through a right click as well as text selection on a secondary click. Maybe I didn't highlight it correctly but hopefully the next step is a review and some more feedback?

Okay, so played around with this a little bit, and it generally feels good. There are some problems though: if I have a selected region, and I ctrl+click on a word in that region, it deselects the region before showing the context menu.
I think the best way to address this, for now, is to avoid modifying the selection. When the user right/control clicks, we should just display the context menu at the click location, without any other logic. If the user chooses cut/copy/paste we send that RPC; core uses the current selection to determine how to handle the RPC.
In the future, I agree, we may want to query core for what commands should be available for a given location. For now, though, I think a simple/dumb implementation is good, and I think the simpler the better?

@MartinJrP how're finals going? 😉


tab_size is sometimes set wrong

This is my .editorconfig
root = true

[*]
indent_style = tab
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[{package.json,*.yml}]
indent_style = space
indent_size = 2

[*.md]
trim_trailing_whitespace = false

It has some properties that are not yet supported, but it's future proof :).
One thing I noticed is that the tab_size is sometimes calculated wrong. My editor.tabSize setting is set to auto. But when set to 4, the issue remains. So I use tabs on all my files, except in package.json and in all the .yml files.
The most basic project structure looks something like this
/
 |- package.json
 |- index.js
 |- .editorconfig

Steps to reproduce

Open the project directory
Open `index.js

The plugin indicates EditorConfig: Tabs: 4

Open package.json

The plugin indicates EditorConfig: Spaces: 2

Open index.js

The plugin indicates EditorConfig: Tabs: 2

As you can see, after opening a file with spaces (2), the tab_size is using not being reset to the correct value because my .editorconfig file is not specifying the indent_size when using tabs.

@SamVerschueren do you think it would be possible to provide a breaking test on the issue in the form of a PR?

At line 104 the insertSpaces and tabSize properties are read from the text editor.
I open index.js

The first time that method runs, those properties are set by the settings file of the user (workspace or global).
The options are then overridden at line 117
I have no indent_size specified for js files so the default from the settings (4) is used

I open package.json

The method executes again but this time, it doesn't take the users settings, it takes the options of the texteditor (which are previously overriden)
Because indent_size is set for package.json, it is set working correctly

I navigate back to index.js

It uses the textEditor.options properties, which have the values of the previous run (with an incorrect indent_size of 2)
Settings are applied to index.js with a wrong indent_size of 2


php handler: mod_php=> php-fpm

it is said:
php handler: mod_php=> php-fpm
can you give me hints where/how to do that? :) thanks

Severity: Warning Message: mysqli::real_connect(): php_network_getaddresses: getaddrinfo for https failed: Name or service not known Filename: mysqli/mysqli_driver.php Line Number: 203


revert is not working

www-data@vps:~/tools$ pm2 deploy ecosystem.config.js production revert 1
--> Deploying to production environment
--> on host localhost
  ○ reverting 1 deploy(s)
  ○ deploying 6e1cc1a
  ○ executing pre-deploy-local
  ○ hook pre-deploy
  ○ fast forward 6e1cc1a
Previous HEAD position was 762fbb6 Update index.js
HEAD is now at 6e1cc1a Update index.js
fatal: Couldn't find remote ref 6e1cc1a

It's on linux ubuntu 18
pm2 version is 3.3.1

same problem.
centos 7
pm2 version 3.5.0
pm2 deploy development revert
--> Deploying to development environment
--> on host localhost
○ reverting 1 deploy(s)
○ deploying 91ef402
○ executing pre-deploy-local
○ executing pre-deploy echo
○ fast forward 91ef402
HEAD is now at 91ef402... /api/dev
fatal: Couldn't find remote ref 91ef402
git pull failed
Deploy failed

It might be linked to: https://github.com/Unitech/pm2-deploy/blob/master/deploy#L267
Feel free to PR

@Unitech
Same problem here. fatal: Couldn't find remote ref #changesetNumber
Error occur on

run "cd $path/source && git checkout $branch && git pull origin $branch"

It will execute "git pull origin $branch", however the $branch = git changeset, instead of a branch name.

any news?

Ping on news concerning this?

Same problem here

Please try with:
npm install Unitech/pm2#development -g

This is PM2 v4

It is also not working with v4.
Why? Any news. PM2 is such a good tool, but revert / rollback is not working!

btw: It seems like @t0lkman fixed this within #174
Is there a reason why it's still not merged? @Unitech

I was referred to pm2 after realizing that shipit would not work for deploying to multiple servers, and then I run into this.  The ability to revert a deployment is a bit of a must have.  😞


linked more argument completions are broken

Linked mode arg proposals were working until very recently. Not sure what happened here...

Oh, I see, it was the fix to #381. So this isn't a bug. But why do we have linked mode arg completions disabled by default?

No, they are enabled by default (see CompletionOptions). Maybe you disabled them a long time ago and forgot about it (because the setting was never used)?

Disabling linked mode gave a slight performance boost when we started working on this topic a few weeks ago, maybe that's when you disabled it?

OK, could be. Closing.


Broken link

Removing the sentence that has broken link - could not find a suitable replacement  - checked with CSS SME from IE (Louis Shanks) and confirmed that we can remove the sentence with broken link.

Thanks @ramakoni1

Thanks @ramakoni1

Great- thanks for taking care of this so quickly!


graph: meta indexer fix

Fix logical error in metadata indexer

run skydive-k8s-tests

run skydive-cdd-overview-tests

run skydive-k8s-tests

run skydive-cdd-overview-tests

run skydive-unit-tests

@lebauce - can you please review ?


Decouple reconcilers from each other

Instead of having the HC reconciler directly enqueue other reconcilers,
it now has a level of indirection through the forest. This allows the
anchor and object reconcilers - and, soon, the Hierarchical Resource
Quota reconcilers - to be notified of changes to the hierarchy, without
the HC reconciler having to know about them. (This change was prompted
by my work on HRQs, which I felt would overly complicate the HC
reconciler).
At the same time, I've removed the enqueues of the HNC Config
reconciler. Instead of reconciling whenever there was a change, with a
rate-limited maximum, it's now just on a periodic ticker.
Finally, I used the SetupWithManager functions as constructors to take
the initialization of certain fields out of internal/setup and put them
into the per-feature packages.
Tested: all e2e tests still work (I didn't try the ones that require
repair but those should be unaffected). Also tested this with my HRQ
changes and HRQ works correctly and fits in with minimal changes to the
rest of HNC.

/assign @rjbez17
Also CC @erikgb , please feel free to leave comments but I'd like Ryan to approve since he has a bit more context here.
The HRQ implementation I allude to in the commit description is at https://github.com/adrianludwin/hierarchical-namespaces/tree/hrq.

Oooh, that's a good idea. I'll add that to #182.
On Tue, Apr 5, 2022 at 10:31 AM Ryan Bezdicek @.***>
wrote:

@.**** commented on this pull request.
In internal/objects/reconciler.go
https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/180#discussion_r842858290
:

// since this is in a goroutine, we can't return it. Therefore, we need to handle the error

// ourselves.

attempts := 0

for {

	attempts++

	err := r.enqueueExistingObjects(context.Background(), log, nsnm)

	if err == nil {

		break

	}

	log.Error(err, "Couldn't list objects")

	time.Sleep(10 * time.Second)

	if attempts == 3 {

		// We can get into a permanent failure loop if, for example, the GVK has been deleted from

		// the server (i.e. it was a CRD). Rather than looping forever, let's restart and hope that

		// fixes it.

		log.Info("Couldn't list objects for 30s. Something's gone very wrong; hopefully a restart will fix it.")

Yeah that makes sense. We could also just add some logging here.
Alternatively, we could just update the healthz endpoint in this case to
tell the control plane we aren't healthy. We could then loop forever in the
code and lets k8s restart us based on liveness probes. If the loop recovers
we could update the endpoint to be healthy again. It would also give a
better 'audit trail' of HNC health for monitoring tools as it'll show as
unhealthy in k8s instead of random restarts.
However, that seems like its out of scope of this specific PR.
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/180#discussion_r842858290,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE43PZGDCOQA7E3OYDC5AALVDRFCHANCNFSM5SQLCWUA
.
You are receiving this because you were mentioned.Message ID:
@.***
com>


chore: update dependencies

@thorn0 @sosukesuzuki Any of you know how to remove "Travis CI"? The file has been deleted

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (5e10835) compared to base (dc1ce95).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 5e10835 differs from pull request most recent head 34b2ea4. Consider uploading reports for the commit 34b2ea4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           78        78
  Lines          781       781
  Branches       129       129
=========================================
  Hits           781       781

Impacted Files
Coverage Δ

src/transform.ts
100.00% <ø> (ø)

src/parse.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


lint podspecs during build.sh verify-cocoapods

This will lint all podspecs (Realm.podspec & RealmSwift.podspec) /cc @bdash

It looks like the CI job for verify-coocapods failed due to the worker having a cached copy of core tarball with the headers that generate the warning. Might have to remove that on all of the VMs prior to merging this?
:+1:


feat: add new node method "IndexOrGetWithIdx"

ref #588

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Mutation base on async call result

Hi ,
I found myself confused in handling muations in async call

 // action
    func mutate(action: Action) -> Observable<Mutation> {
        switch action {
            case let .requestSMSCode(phone):
                return createRequestSMSCodeTask(phone)
           ....
}

func createRequestSMSCodeTask(_ phone: String) -> Observable<Mutation> {

        let startLoading = Observable<Mutation>.just(
            .updateNetworkStatus(.loading("sending code"))
        )

        let createErrorLoading: (_ error: Error) ->Observable<Mutation> = { error in
            return Observable<Mutation>.just(
                    .updateNetworkStatus(.failed(" sent code failed"))
            )
        }

        let startCoundown = Observable<Int>.interval(1, scheduler: MainScheduler.instance).take(60).map(Mutation.updateCountDownLeftSeconds)

        let requestCode = self.userService.requestSMSCode(phone).asObservable()
            .map {_ in Mutation.updateNetworkStatus(.loaded("code sent")) }
            .catchError(createErrorLoading)

        return .concat([startLoading, requestCode, startCoundown ])
    }

whether to performstartCoundown task is based on  requestCode task is  success or failed,
but startCoundown task execution has no context to know pervious status

In this case you may use concat() directly to requestCode like below:
let requestCode = userService.requestSMSCode("phone").asObservable()
  .map { _ in Mutation.updateNetworkStatus(.loaded("code sent")) }
  .concat(startCountdown) // when succeeds
  .catchErrorJustReturn(.updateNetworkStatus(.failed(" sent code failed"))) // when fails
return .concat([startLoading, requestCode])

Found another question,  the startCountdown stream will keeping emit Mutations before user click sign in , how can set  this steam as completed gracefully after perform user signin muation

@waltcow, you might refer to the GitHubSearch example. You can use .takeUntil() with the next mutation.

@devxoul Thanks a lot


Support for longer job names

In portrait mode, the job names are truncated and appended with "..."
When rotating to landscape mode, there is much more screen realestate to support a longer name, however the same length is shown as in portrait mode. It would be great to use the extra space in landscape.
Another improvement could be utilising 3D touch to show the an insight into the job from the main job list menu (full name, last build date, last successful build date etc)

we'll look into the long names, that is definitely a bug but don't think we'll get into the force touch unless any developer would feel like creating something like that?


Switching to any network other than Mainnet w/ network selector is broken

In production, switching from one network to another using the app based network selector is broken, unless the destination network is mainnet. It produces the following error in console:
{
    "code": -32603,
    "message": "networkConfigurationId undefined does not match a configured networkConfiguration",
    "data": {
        "originalError": {}
    }
}

I think this is on the metamask side

This is working for me now and I think can be closed.

Same here, and agreed. Closing!


Deleting Multiple Files

Description
When deleting multiple files the application freezes and deletes each file one at a time, very slowly, then crashes.
Steps To Reproduce

Have files
Delete Files
CRASH!

Requirements
When deleting multiple files the application freezes and deletes each file one at a time, very slowly, then crashes.
Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.2715
Log File
debug.log
user_settings.json

Thanks for the report, the crash isn't specific to deleting items. It's a bit hard to fix because it's a platform bug, but we'll keep looking for workarounds. Regarding the performance when deleting items, we're tracking this in #13499.


Client Side Blazor Authentication NotifyAuthenticationStateChanged not updating Components

Describe the bug
Calling NotifyAuthenticationStateChanged after authentication state changes does not update Components with latest AuthenticationState.
To Reproduce
Here is a link to a demo - https://github.com/rabberbock/BlazorAuthTest
Expected behavior
On the home page when authentication is set to true or false the authorize view should update automatically.
Additional context
Add any other context about the problem here.
Include the output of dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100-preview6-012264
 Commit:    be3f0c1a03

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17763
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview6-012264\

Host (useful for support):
  Version: 3.0.0-preview6-27804-01
  Commit:  fdf81c6faf

.NET Core SDKs installed:
  2.1.201 [C:\Program Files\dotnet\sdk]
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.300 [C:\Program Files\dotnet\sdk]
  2.1.401 [C:\Program Files\dotnet\sdk]
  2.1.403 [C:\Program Files\dotnet\sdk]
  2.1.500 [C:\Program Files\dotnet\sdk]
  2.1.502 [C:\Program Files\dotnet\sdk]
  2.1.600-preview-009426 [C:\Program Files\dotnet\sdk]
  2.1.600-preview-009472 [C:\Program Files\dotnet\sdk]
  2.1.600 [C:\Program Files\dotnet\sdk]
  2.1.602 [C:\Program Files\dotnet\sdk]
  2.1.700 [C:\Program Files\dotnet\sdk]
  2.2.101 [C:\Program Files\dotnet\sdk]
  2.2.200-preview-009648 [C:\Program Files\dotnet\sdk]
  2.2.200-preview-009748 [C:\Program Files\dotnet\sdk]
  2.2.200 [C:\Program Files\dotnet\sdk]
  3.0.100-preview6-012264 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-preview6.19307.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.3-servicing-26724-03 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview6-27804-01 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview6-27804-01 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

Any help would be much appreciated. Thanks!

I'm not sure what ails your app, but I believe the following code is problematic:
<button onclick="@(() => UpdateAuthentication(true))">     Set Auth True </button>
onclick is a directive attribute and should be preceded with the '@' sign: @onclick
Also, why do you have both of these in your Startup class:
services.AddScoped<AuthenticationStateProvider, CustomAuthStateProvider>();             services.AddScoped<CustomAuthStateProvider>();
Hope this helps...

@enetstudio Thanks for the feedback! I updated the onlclick syntax to @onclick, but still no luck. Even before adding @ the onclick handler was being called, so I am not sure if that is really needed....
Also, I register CustomAuthStateProvider so I can inject it into the component to access the NotifyStateChange method of that class.

Your problem is here:
services.AddScoped<AuthenticationStateProvider, CustomAuthStateProvider>();
services.AddScoped<CustomAuthStateProvider>();

You're configuring two different instances of CustomAuthStateProvider. You're toggling the state on the second instance, but your components are receiving the first instance.
Solution: register it like this: https://github.com/SteveSandersonMS/presentation-2019-06-NDCOslo/blob/master/demos/MissionControl/MissionControl.Client/Util/ServiceExtensions.cs#L17

@SteveSandersonMS Thanks so much for the solution! Works Perfectly!

@rabberbock @ sign before onclick was not required in earlier versions of Blazor but it should be used in preview6 and newer. Currently Blazor supports both syntaxes but the old one without @ will be removed soon.

@SteveSandersonMS I'm impressed by this line of code https://github.com/SteveSandersonMS/presentation-2019-06-NDCOslo/blob/7169cf82755cee0ae6922c6344f33f33743513c2/demos/MissionControl/MissionControl.Server/Controllers/AgentsController.cs#L21
You have Hans Kloss but no James Bond! Have you ever seen this film? From Wikipedia:

Stakes Larger Than Life was a Polish black and white TV series about the adventures of a Polish secret agent, captain Hans Kloss (real name, Stanisław Kolicki, codename J-23), who acts as a double agent in the Abwehr during Second World War in occupied Poland. The series was filmed from March 1967 to October 1968. There were 18 episodes.

I saw it when I was a few years old. It is oficialy available online but only in Polish:
https://vod.tvp.pl/video/stawka-wieksza-niz-zycie,odc-1-wiem-kim-jestes--hd,1076058


Migrate state management to Redux

Management of cohort state has been migrated out of UserData and context
and into the Redux store and reducers. The current set of actions
mirrors what was there before but it would be good to break
updateCriteria into several actions for more precise edits, especially
for undo/redo support.
One side effect is that Redux supports only basic objects and arrays so
the existing classes have had their functionality moved into separate
functions. In general, this isn't a big deal but it it prevents us from
continuing to use inheritance to support multiple criteria types. I have
instead implemented a basic plugin system which allows multiple types of
criteria without pulling the spcifics into the data model, and also
provides a prototype for what a more robust plugin system might look
like long term. The plugin system will likely evolve over time but for
now it demonstrates how criteria plugins can be defined separately and
referenced only in a single, easily merged location.
While the TypeScript decorators are still experimental, they have
existed for a couple years and are unlikely to go away. At some point
they may be deprecated in favor of the latest JavaScript decorator
proposal, https://github.com/tc39/proposal-decorators, at which point
would could easily migrate if necessary.

I unfortunately don't know any Redux experts either so we'll be learning as we go.


Run fails on new system

Looks like the conditional postfix_exporter_version_check.stdout is not defined is never true; on a system with no such binary, I get the following value for postfix_exporter_version_check:
    "postfix_exporter_version_check": {
        "changed": false,
        "cmd": "/usr/local/bin/postfix_exporter --version",
        "failed": false,
        "failed_when_result": false,
        "msg": "[Errno 2] No such file or directory: b'/usr/local/bin/postfix_exporter'",
        "rc": 2,
        "stderr": "",
        "stderr_lines": [],
        "stdout": "",
        "stdout_lines": []
    }

On a host where this is installed, the --version flag doesn't appear to work anyway:
$ /usr/local/bin/postfix_exporter --version
postfix_exporter: error: unknown long flag '--version', try --help

Can be worked around by removing the conditional, but that then copies the binary every time the role is called.

I've applied a million of changes and bugfixes and also included automatic molecule testing.
Also this is now working for ubuntu and RedHat, including the molecule testing.
Please update the role and try again :)

Regarding version flag I opened an issue https://github.com/kumina/postfix_exporter/issues/91

Cheers for your quick response, and apologies for the slow response on my part! Your changes look to have done the trick, many thanks. I hope there's a response for the upstream issue soon!
I'll close this one off - feel free to open an alternative to track the version implementation, or not, as the case may be!


NCTL: add . filter to jq in client.sh

Changes:

Fixes bug that occurs in drone nightlies.

Ticket: https://app.zenhub.com/workspaces/cn-sre-60d363546afb85000e491ff6/issues/casper-network/sre/502

bors r+


The typings can only be a .d.ts file. Contact package author to fix it

Happens when using the latest compiler as a language service. Sample package : csx https://github.com/basarat/csx npm install csx.
I suspect that https://github.com/Microsoft/TypeScript/pull/4911 broke it ... it now looks at the csx.ts file and errors :rose:

yup. that would be a side effect of #4911. the fix would be to add the full extension in the typings field ("typings": "csx.d.ts").
We have got feedback about users wanting to include their .ts files and found the compiler changing its lookup rules to pick .d.ts files too restrictive.
We should remove the error though.


Don't delete soft links when -L not set

I've updated the lines which generate tree-current so that soft links make it through the grep and into fetch-exclude, even when -L is not set in the config file. Now, links are copied as links when -L is not set, and links are dereferenced when -L is set. The old behavior erased links when -L was not set.
I couldn't figure out how to run the spec code, so if anybody can provide some direction with that, or if somebody could run the specs that is probably an important step. Preliminary tests on my home machine were successful at providing expected behavior.

I just caught some weird behavior that could potentially result in lost data with this version. I haven't yet tracked down the reasons, but here is a description of the scenario and results:

If I create a link in my local BitPocket directory and then sync to master,
unlink the link, but then create a normal file with the same name in my local Bitpocket directory
sync to master again.

The result is that my local normal file is erased and replaced with the old link. Any data in the normal file not backed-up elsewhere is lost.

Hmm, this sounds like one of many obscure edge cases :/

@jordan-stone, would it be possible to see if this was addressed in 33b61a854a68d7e39125a2474fa22ea4d1c40ad7?

I'm closing this issue, as I believe 33b61a8 corrects the issue of syncing folders with symbolic links. The new issue discovered by @jordan-stone has been moved to #69 to be tracked separated. Thanks for the contributions!


[rendering] consider how to deal "offensive" overlaps of land grants

This has been references in several other issues, namely #87 and #91 (and some PRs). For this issue, making a decision for land grants to make their boundaries invisible unless hover-highlighted, and to request moving all naming to the area of (potential) population. For instance, the Land Grant to the Virginia Company of London  should only put text over the settlements on the east coast, not across "sea to shining sea". The border can remain for hover-viewing, but this at least won't offend as much the real native settlements that are in the land that the land grant has never even viewed, much less visited.

For land grants at least, this was fixed with #112. Might need these for early provinces which are quite specious as well. Likely need a better taxonomy for these to make sure true polygons are bound by actual settlements and populations.


-d [width]:[height] is wrong

The docs say:
-d [width]:[height] - set plot dimensions
Actually, it seems to be
-d [height]:[width] - set plot dimensions

Thank you!  Fixed in 6e55c7fd7a9cfbab1e76244fc96d71ca19eb2b05


Change react-mirror dependency to use react-mirror2 as in styleguidist

This should fix #20.
I left it as peerDependency for now and I required a minimum version 0.0.13 as it's the version used in styleguidist
Changes are tested installing the library from github and it seems working as expected.
Let me know if you need anything else
Edit: I just realized I installed a different version of jest-cli and it cause to update all the snapshot tests, is it allright or it's better to restore them as they were before?

You shouldn’t use your own version of Jest, only one that’s included in the project dependencies. I’m surprised that CI is failing not because of that but for some other reason ;-)
Yeah, CI is failing because peerDependencies is not the right place for react-codemirror2. CI installs an old React Styleguidist version that doesn’t depends on react-codemirror2 and CI is failing because Snapguidist can’t find it. That’s why I said yesterday that we shouldn’t rely on coincidences — it will fail.

Actually I don't think jest-cli is included in the dependencies, tests failed when I tried to push my commit and I had to install it.

You don’t need jest-cli, jest binary is included in the main package:
https://github.com/facebook/jest/blob/a344d497160e4ab8f8e8a1d122395a4a52a3ce61/packages/jest/package.json#L10


Updating Mobile and Web SDK content

Docs Build status updates of commit 3175cfe:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/WebSDK/docs/SkypeWebSDK.md
:warning:Warning

Details

Skype/AppSDK/SkypeAppSDK.md
:bulb:Suggestion

Details

Skype/WebSDK/docs/SkypeWebSDK.md

Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 12, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'Skype for Business Online Retirement') are not allowed. You can only have one top-level heading.
Line 22, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/presence' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 23, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/localuser' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 24, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/conversations' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 24, Column 292: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/graph/api/resources/chat?view=graph-rest-beta' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 25, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/presenceevents' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 26, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/persons' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 27, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/devices' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 24, Column 292: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/en-us/graph/api/resources/chat?view=graph-rest-beta. Otherwise, remove the view parameter.

Skype/AppSDK/SkypeAppSDK.md

Line 38, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f212fc8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/WebSDK/docs/SkypeWebSDK.md
:warning:Warning

Details

Skype/AppSDK/SkypeAppSDK.md
:bulb:Suggestion

Details

Skype/WebSDK/docs/SkypeWebSDK.md

Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 12, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'Skype for Business Online Retirement') are not allowed. You can only have one top-level heading.
Line 22, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/presence' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 23, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/localuser' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 24, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/conversations' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 24, Column 292: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/graph/api/resources/chat?view=graph-rest-beta' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 25, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/presenceevents' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 26, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/persons' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 27, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/skype-sdk/websdk/docs/devices' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 24, Column 292: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/en-us/graph/api/resources/chat?view=graph-rest-beta. Otherwise, remove the view parameter.

Skype/AppSDK/SkypeAppSDK.md

Line 38, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


write performance tests

once we have our framework up, the tests we need are:

starting a big notebook (time until completely rendered, and also longest interval stuck inside JS interpreter)
starting a notebook with no cells but major evaluators (R, python, groovy) (time until completely rendered)
run through all the tutorials (repeat and monitor memory usage)
run through all UI interactions (repeat and monitor memory usage)

I am currently working on a tool to do just this, it is a combination of chrome debugger-protocol and selenium-webdriver.
When it is ready it should allow for an objective measure of memory useage, FPS, node count, and time to first paint. :+1:

great thanks sam.

unfortunately this is blocked via
https://code.google.com/p/chromedriver/issues/detail?id=878#makechanges


Registry with auth: auth issue at push

Hi,
I have implemented a token management server talking with registry v2 and it works fine. I can push/pull from remote servers while dealing with user access rights and authentication.
I face however an issue doing a push on 1 host (the same where is registry).
I can do a docker login. However, at push, it fails (with no error).
[ ~]# docker   push docker-registry.genouest.org/osallou/blast
The push refers to a repository [docker-registry.genouest.org/osallou/blast] (len: 1)
3acbd84b58f1: Pushing 1.024 kB
unauthorized: authentication required

The unauthorized suggest that an authorisation is requested from my token server. I can see the request in the log of token server and it is correctly managed. The same push from an other,remote, server works fine (with same user).
Here is a wireshark capture. The token request answers with a 200OK, then a post on registry is done, which answers a 202 Accepted. However, a new 401 Unauthorized error appears after that (and ends the push).

The only difference is my Docker client version, on this host, is docker v1.9. Others are v1.7.
Any idea on what is going on ? The registry is running in a container
registry logs are available here: https://gist.github.com/osallou/d0dfe3ca8e5db68676c8

Additional info:
The PATCH message sent does not contain any authorization header:
PATCH /v2/osallou/blast/blobs/uploads/3dcec9c4-4198-4ea0-9a95-4b48abda3bb2?_state=UyQg_fLbBfMDPU1hrKZrpoMMv8BPZIry6aUUt0Aa3Lt7Ik5hbWUiOiJvc2FsbG91L2JsYXN0IiwiVVVJRCI6IjNkY2VjOWM0LTQxOTgtNGVhMC05YTk1LTRiNDhhYmRhM2JiMiIsIk9mZnNldCI6MCwiU3RhcnRlZEF0IjoiMjAxNS0xMS0xMFQxNDo1MToxMy44NzM0NjI5NzdaIn0%3D HTTP/1.1
Host: docker-registry.genouest.org
User-Agent: docker/1.9.0 go/go1.4.2 git-commit/76d6bc9 kernel/3.10.0-229.20.1.el7.x86_64 os/linux arch/amd64
Accept-Encoding: gzip
X-Forwarded-For: <IP_ADDRESS>
X-Forwarded-Host: docker-registry.genouest.org
X-Forwarded-Server: docker-registry.genouest.org

Connection: Keep-Alive
Content-Length: 32
This explains the unauthorized issue, but why client does not sent the authorization error, a bug in client?
I use Docker version 1.9.0, build 76d6bc9

@dmcgowan Any ideas here?

This really does not look like a bug on the client since PATCH is not treated any differently. However the proxy may be treating it differently. Where are you seeing the PATCH headers and is it possible to see it from the proxy. The Headers you sent appear to be post proxy and not necessarily what is leaving the client. I have never seen an issue where the authorization is attached to previous requests then does not send for subsequent requests, therefore I would like to take a look at the capture directly from the client.  We can figure this out :)

As requests go through https, i cannot get http info directly on client output, only after the https/http proxy. I am using Apache as proxy.
A push from my computer, going through the same proxy works, but with client 1.7, not using patch if i am correct.
I saw the patch headers in the wireshark capture, it is the request just before the last 401 error.

For info, I could reproduce the issue at home in a vagrant box with v1.9 client. So issue seems really related to the PATCH message. Could be a https/http proxy issue, could I force client to use http instead of https to be able to decode messages sent by client?

I have tried to capture messages sent by client, and just saw a strange thing. While I caznnot decode the HTTPS messages, I can see a flow of message to port 443. However, at the end, I see the PATCH message sent to port 80 instead of 443.
See capture screenshot here. The highlighted message is the PATCH message (previous are HTTPS ones), followed by the 401 Unauthrorized. We can see the message is sent to the port 80, leaving the HTTPS transaction.

Moving forward.... The 202 Accepted message following POST /v2/...../blobs/uploads/ contains in its headers a Location field:
Location: http://docker-registry.genouest.org/v2/.../uploads/xxxx

The location header returned by the registry is in http instead of https. A registry v2 bug / config issue ?

Gotcha !! The registry requires, when going through a proxy, to set the X-Forwarded-Proto header in the requests. Others X-Forwarded-xx headers are automatically set by proxy, not the -Proto.
The file https://github.com/docker/distribution/blob/master/registry/api/v2/urls.go looks at this header to decide  if http or https scheme is to be used. In most messages we do not care as we handle relative urls. For blob uploads, a complete url is set in Location header of the response.
Adding the X-Forwarded-Proto in the proxy configuration fix the issue. This may however require a documentation hint....  ;-) I let you decide to close the bug or not as this could be managed as a documentation bug.

Glad you figured it out! Wireshark is great but I like using http://www.charlesproxy.com/ (there are some free alternatives as well) which can MITM your HTTPS connection to give you better visibility over what is sent over the wire directly from the Docker daemon. Would treat updates to the docs separately, feel free to open up a PR or issue requesting such a change.

For the record, we ran into the same issue with our proxied registry. Maybe a warning in the docker daemon might be possible?

Same problem. With paid trusted registry.
The push refers to a repository [registry.*./user/repo] (len: 1)
4dcb8199317b: Image already exists
76d245af546f: Image already exists
df94a3fe4639: Image already exists
d6120df089ae: Image already exists
ed274cec0091: Image already exists
4d7743f8fd11: Image already exists
45cf80647aba: Pushing [==================================================>] 296.6 MB
unauthorized: authentication required

@tempico if you are using DTR, please contact the support.
Furthermore, use of X-Forwarded-Proto is documented and I don't think there is a reason for you to set it / disable it in DTR.
Anyhow, like I said, please reach out to the support.

@dmp42
OK, thanks!
DTR is installed at dedicated machine, without proxy.

@osallou in your previous comment, "adding the X-Forwarded-Proto in the proxy configuration fixes the issue."  So does it mean the PATCH request to be triggered against https url not http?
But if that's the case, IMHO, this maybe still questionable:
1)Why the "Location" header in the response of POST is handled differently?
2)If there's a scheme switch from https to http, is it correct to drop the token?

@reasonerjt
In my case, I had the Registry and my server acting for authentication behind a web proxy, accessed via https. Proxy forwards requests to both in http on private network. I had to set the X-Forwarded-Proto scheme in proxy configuration because I trigger the registry in https (in front of the proxy) then forward the request to the registry in http. As original info about used protocol is lost when going though the proxy, we had to set the used scheme. The X-Forwarded-Proto header is detected by the registry and update requests accordingly for some specific API use.
Regarding 1) Location, well, this should be asked to developpers  ;-)
Regarding 2), why would you drop the token ?

Regarding 1) Location, well, this should be asked to developpers ;-)

We made the decision to use absolute urls in the location header to make client implementation easier for http libraries that don't handle redirects. To make this work correctly in most cases, we have some detection using various forwarding headers. This also allows one have schemes where registry can produce breakout redirects to route large streams around load balancers. Unfortunately, the token management scheme in docker isn't up to the task to leverage this yet.
This affects the PATCH because that is the most common redirect that happens.
I do recall some discussion in adding a configuration option that would just restrict these to relative redirects. There is no reason that shouldn't be backwards compatible.

Regarding 2), why would you drop the token ?

You must drop the token when going to an insecure scheme or switching hosts. Otherwise, you risk leaking authentication tokens.


resmgr: better expression validation, cleaner key resolution.

Notes: this PR is stacked on top of

#263
#264

Simplify/clean up key reference resolution in expressions, fixing resolution to allow label keys with '/'. This should allow using domain-prefixed label keys in affinity expressions.

Let me take another look at this...

@askervin Updated with a few additional cleanups.

I'd suggest to make the first commit a separate PR to make this cleaner to review. WDYT?

...BC I'm a bit struggling to comprehend the change 😅 Is this part of the config api or not? Why not put this under pkg/apis/config/v1alpha1/resmgr/?

...BC I'm a bit struggling to comprehend the change 😅 Is this part of the config api or not? Why not put this under pkg/apis/config/v1alpha1/resmgr/?

No, it's not part of the config API. It is used for other things, too. Now it is also used for configuration.

I'd suggest to make the first commit a separate PR to make this cleaner to review. WDYT?

It is a separate PR. #264

It is a separate PR. #264.
Yeah, sorry, I just noticed that after posting my comment...

No, it's not part of the config API. It is used for other things, too.

"too" -> so is it part of the config API or not? 😅 I think if it's used in the config API it should be considered part of that (as that's our most obvious and best-defined user-facing API). I'm not sure if this deserves a separate top-level api if there's no self-contained implementation of it 🤔

No, it's not part of the config API. It is used for other things, too.

"too" -> so is it part of the config API or not? 😅 I think if it's used in the config API it should be considered part of that (as that's our most obvious and best-defined user-facing API). I'm not sure if this deserves a separate top-level api if there's no self-contained implementation of it 🤔

It has always been a top-level API, but Jukka moved it to a slightly incorrect package path. The moving PR now fixes that.

No, it's not part of the config API. It is used for other things, too.

"too" -> so is it part of the config API or not? 😅 I think if it's used in the config API it should be considered part of that (as that's our most obvious and best-defined user-facing API). I'm not sure if this deserves a separate top-level api if there's no self-contained implementation of it 🤔

If this is considered a show-stopper, of course I can move it... I'm just not keen on it because 1) this is very close to the original idea and how it was in CRI Resource Manager, 2) just because something is used in/referenced by our config API does not mean that it must be defined there, and 3) moving to a different location totally screws me with the rest of the PR above in the stack.

That is where it came from. And it is still a user-facing API: pods and containers can be annotated with it.

That's true

If this is considered a show-stopper, of course I can move it...

I don't think it's a show-stopper. I'm just trying to understand/figure out the principles how/what/where the api definitions should be maintained.

this is very close to the original idea and how it was in CRI Resource Manager

We don't need to do what CRI-RM did 😅 The question is was pondering is really where should the API definitions be maintained. Is there a difference with CRD, gRPC, annotation etc APIs. Looking at this, I think it is probably a good principle for us to have all user-facing APIs under pkg/apis/. So LGTM

just because something is used in/referenced by our config API does not mean that it must be defined there, especially if it predates our config API, and

That is true. But if this was included in the config API I would include it there as in practice it would've become part of it (both maintained in the same project). Also one reason being that it would make it clear that changing/updating it would essentially change the config API, too.
But, now looking at it I can see that it's NOT included in the config API so I don't think it belongs there. So my earlier question/comment on this is resolved.

That is where it came from. And it is still a user-facing API: pods and containers can be annotated with it.

That's true

If this is considered a show-stopper, of course I can move it...

I don't think it's a show-stopper. I'm just trying to understand/figure out the principles how/what/where the api definitions should be maintained.

this is very close to the original idea and how it was in CRI Resource Manager

We don't need to do what CRI-RM did 😅

Yes, I totally agree with that. I shouldn't have brought up CRI-RM at all.

The question is was pondering is really where should the API definitions be maintained. Is there a difference with CRD, gRPC, annotation etc APIs. Looking at this, I think it is probably a good principle for us to have all user-facing APIs under pkg/apis/. So LGTM

I think your question and pondering was valid and I am glad that you voiced your concern. If nothing else, it forced me to think about it and try to articulate it and then try to decide if what I say really looks like a valid justification or if it is just an excuse...
Basically I think there are two reasonable ways to organize the externally visible APIs. 1) either blow them apart and put each logically self-contained bit together/under the component to where it the most closely belongs to, or 2) use a single rooted subtree under which all of them are put by some logic. IMO, we explicitly chose to go with 2, when we reworked the configuration. But the expression API was left untouched and it was according to 1 above.

just because something is used in/referenced by our config API does not mean that it must be defined there, especially if it predates our config API, and

That is true. But if this was included in the config API I would include it there as in practice it would've become part of it (both maintained in the same project). Also one reason being that it would make it clear that changing/updating it would essentially change the config API, too.

That is still a valid comment/concern albeit a more genera one. Maybe one way to address that would be to make the build target depend on generate. Then if you change anything and rebuild, you will inevitable see if your changes cause changes to creep into the config API.


Added SlowSort

I have added another ineffective algorithm as sorting algorithm example.

Ok, merging this in :]


[Bug] Updated Ear Tag to 0.2.0, now it's missing

Greetings,
I just updated flatpak version of Ear Tag to v 0.2.0 on EndeavourOS Gnome 42.4 and when trying to search the app to launch in Overview, it's no where to be found. I tried rebooting and searching for the app but it doesn't show up even though it is currently installed. I tried removing it, clearing out all the flatpak data and re-installing Ear Tag again, but still I am unable to see the app in any of my menus and I am therefore unable to even launch the app.
I don't know the correct command to launch Ear Tag, but I tried with this app.drey.EarTag and I got the following error message:
[scott@EndeavourOS ~]$ app.drey.EarTag

** (/usr/bin/flatpak run:3836): CRITICAL **: 23:18:41.759: mct_app_filter_is_content_type_allowed: assertion 'is_valid_content_type (content_type)' failed
error: Running app/app.drey.EarTag/x86_64/stable is not allowed by the policy set by your administrator
[scott@EndeavourOS ~]$

I'm not sure what else to provide, but please let me know what other information I may be able to offer to assist in this bug, thank you.  Root privileges required.
  ID-1: /dev/sda maj-min: 8:0 vendor: SK Hynix model: HFS256G39TND-N210A
    size: 238.47 GiB block-size: physical: 4096 B logical: 512 B
    speed: 6.0 Gb/s type: SSD serial: <filter> rev: 1P10 scheme: GPT
Partition:
  ID-1: / raw-size: 229.37 GiB size: 229.37 GiB (100.00%) used: 146.62 GiB
    (63.9%) fs: btrfs dev: /dev/sda2 maj-min: 8:2
  ID-2: /home raw-size: 229.37 GiB size: 229.37 GiB (100.00%) used: 146.62
    GiB (63.9%) fs: btrfs dev: /dev/sda2 maj-min: 8:2
  ID-3: /var/log raw-size: 229.37 GiB size: 229.37 GiB (100.00%) used: 146.62
    GiB (63.9%) fs: btrfs dev: /dev/sda2 maj-min: 8:2
Swap:
  Kernel: swappiness: 60 (default) cache-pressure: 100 (default)
  ID-1: swap-1 type: partition size: 8.8 GiB used: 0 KiB (0.0%)
    priority: -2 dev: /dev/sda3 maj-min: 8:3
Sensors:
  System Temperatures: cpu: 66.0 C pch: 58.0 C mobo: N/A gpu: nvidia
    temp: 55 C
  Fan Speeds (RPM): N/A
Info:
  Processes: 280 Uptime: 8m wakeups: 1 Memory: 15.51 GiB used: 2.33 GiB
  (15.0%) Init: systemd v: 251 default: graphical tool: systemctl
  Compilers: gcc: 12.2.0 Packages: 1221 pacman: 1151 lib: 329 flatpak: 70
  Shell: Bash v: 5.1.16 running-in: tilix inxi: 3.3.20

I think I've narrowed down the issue to a small typo in the .desktop file; I've pushed a hotfix to the Flatpak, so it should work after an update (alternatively, try to get it from the buildbot: flatpak install https://dl.flathub.org/build-repo/105719/app.drey.EarTag.flatpakref).
Let me know if that fixes the problem.

Just updated to the latest flatpak version. Searched and still didn't see it. But once I did a reboot then it showed up, so it's working again, thanks for the quick update, very much appreciate it! :+1:


Add pkg-config fallback to --enable-system-luajit

This addresses issue #1507

@shukitchan Ah, gotcha. So this is not a candidate as is. If someone cares, they can propose back porting all the necessary changes.


Create Mingione-NowCasting

Thanks for contributing your submission to the e-Rum2020 CovidR contest.
For CovidR contributors:

[x] The title of this PR reflects your contribution
[x] The pull request only includes one new .yml file under contest/contributions
[x] Make sure "Allow edits from maintainers" is checked
[x] Send an email to<EMAIL_ADDRESS>(for further direct communication down the road)

Subject: "Submission to CovidR: PR #00", where #00 is the number of this Pull Request
Content: A full link to this Pull Request
Optionally include your social media profiles (Twitter, LinkedIn, Facebook): we will use them to @mention you while sharing the contribution through our channels.

For CovidR maintainers:

[x] Label the PR as "submission"
[x] Check the validity of the submission
[x] Assess completeness of metadata and possibly adjust the .yml file-name
[x] Check the integration of the new page in the website gallery (via Actions' artifact or locally)
[x] Make sure the email to<EMAIL_ADDRESS>was received
[x] Add a field with the current date and approx. merge time (e.g. 2020-04-01-16:30 for April 1st, 4:30 PM)
[ ] Squash-merge the pull request (commit headline will be OK, consider cleaning-up the details)
[ ] The initial comment should be automatically created, otherwise comment manually with the raw content of vote-comment.md and an initial like
[x] Provide here the link to the contribution as published to the gallery: https://milano-r.github.io/erum2020-covidr-contest/___.html
[x] Instruct contributors on how to include their badge from the gallery page, share on social media, and get a free ticket.
[x] Consolidate e-mailed information.

Please let me know if you need anything else by my side. I hope that everything is ok with the submission. Thank you!

@minmar94, your submission is now accepted and visible at https://milano-r.github.io/erum2020-covidr-contest/mingione-nowcasting.html :tada:
You can click on the eRum2020::Covidr badge in the page to obtain the badge code you can embed in your repository.
Furthermore, feel free to spread your contribution on social media with the link above, using hashtags #erum2020 #covidr, and invite the community to like the contribution using the corresponding button.
Last but not least: You can get your free ticket for the pre-conference event at https://www.eventbrite.it/e/covidr-erum-2020-pre-conference-event-tickets-104133026686


Python 3.10 test failures: DeprecationWarning: There is no current event loop (might be asgiref)

The following tests fail when running the test suite under Python 3.10.0b1:
FAILED tests/test_async.py::test_async_route[/] - assert b'GET' in b'<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">\n<title>500 Intern...
FAILED tests/test_async.py::test_async_route[/home] - assert b'GET' in b'<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">\n<title>500 In...
FAILED tests/test_async.py::test_async_route[/bp/] - assert b'GET' in b'<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">\n<title>500 Int...
FAILED tests/test_async.py::test_async_error_handler[/error] - assert 500 == 412
FAILED tests/test_async.py::test_async_error_handler[/bp/error] - assert 500 == 412
FAILED tests/test_async.py::test_async_before_after_request - assert False

In all cases, the underlying reason seems to be a DeprecationWarning triggered inside asgiref, e.g.:
______________________________________________________________ test_async_route[/] _______________________________________________________________
tests/test_async.py:64: in test_async_route
    assert b"GET" in response.get_data()
E   assert b'GET' in b'<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">\n<title>500 Internal Server Error</title>\n
Internal Serv...nd was unable to complete your request. Either the server is overloaded or there is an error in the application.
\n'
E    +  where b'<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">\n<title>500 Internal Server Error</title>\n
Internal Serv...nd was unable to complete your request. Either the server is overloaded or there is an error in the application.
\n' = <bound method Response.get_data of <WrapperTestResponse 290 bytes [500 INTERNAL SERVER ERROR]>>()
E    +    where <bound method Response.get_data of <WrapperTestResponse 290 bytes [500 INTERNAL SERVER ERROR]>> = <WrapperTestResponse 290 bytes [500 INTERNAL SERVER ERROR]>.get_data
--------------------------------------------------------------- Captured log call ----------------------------------------------------------------
ERROR    test_async:app.py:1441 Exception on / [GET]
Traceback (most recent call last):
  File "/tmp/flask/.tox/py310/lib/python3.10/site-packages/flask/app.py", line 2052, in wsgi_app
    response = self.full_dispatch_request()
  File "/tmp/flask/.tox/py310/lib/python3.10/site-packages/flask/app.py", line 1502, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/tmp/flask/.tox/py310/lib/python3.10/site-packages/flask/app.py", line 1500, in full_dispatch_request
    rv = self.dispatch_request()
  File "/tmp/flask/.tox/py310/lib/python3.10/site-packages/flask/app.py", line 1486, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
  File "/tmp/flask/.tox/py310/lib/python3.10/site-packages/flask/app.py", line 1583, in ensure_sync
    return self.async_to_sync(func)
  File "/tmp/flask/.tox/py310/lib/python3.10/site-packages/flask/app.py", line 1615, in async_to_sync
    return asgiref_async_to_sync(func)
  File "/tmp/flask/.tox/py310/lib/python3.10/site-packages/asgiref/sync.py", line 135, in __init__
    self.main_event_loop = asyncio.get_event_loop()
DeprecationWarning: There is no current event loop

I don't really know whether the problem is in asgiref itself, or in the way Flask is calling it. If you believe it's the former, I can file a bug for asgiref instead.
The problem can reliably be reproduced by running tox -e py310.
BTW if you consider testing on 3.10-dev valuable, I can submit a PR to add it to GHA workflows.
Environment:

Python version: 3.10.0b1
Flask version: 9039534eee6a87da98a1dee9e4338d1b73e861f8

I think this is an asgiref bug - I think 3.10 has changed asyncio.get_event_loop() such that it no longer creates a loop if one isn't available.

I think this is an asgiref bug - I think 3.10 has changed asyncio.get_event_loop() such that it no longer creates a loop if one isn't available.

That's true. What I was wondering is whether it's correct to call asgiref_async_to_sync() without an event loop.

Ok, I've figured out that I needed to enable warnings in asgiref's pytest, and then I can reproduce it with their own test suite. Filed https://github.com/django/asgiref/issues/260

Closing as this is an asgiref issue.


Alternative Routes are supported?

Hi,
First of all, thanks for develop this package, is really useful.
Only I have one question, is there a way to get alternative routes from directions? I know that Google Directions API brings alternative routes but I don´t find some method in TK.CustomMap for this.
Thanks again,
Regards.

Sorry but this is currently not possible. PRs are welcome though. :-)


f2: 2.0.1 -> 2.0.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ayoisaiah/f2/releases.
meta.description for f2 is: Command-line batch renaming tool
meta.homepage for f2 is: https://github.com/ayoisaiah/f2
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.3 with grep in /nix/store/jzwy3kispzdghmss63rm5mxpirii93a1-f2-2.0.3
found 2.0.3 in filename of file in /nix/store/jzwy3kispzdghmss63rm5mxpirii93a1-f2-2.0.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

f2

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jzwy3kispzdghmss63rm5mxpirii93a1-f2-2.0.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A f2 https://github.com/r-ryantm/nixpkgs/archive/a540ecdf739bdadee706ee4bccc4e8352bb37d13.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a540ecdf739bdadee706ee4bccc4e8352bb37d13#f2

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jzwy3kispzdghmss63rm5mxpirii93a1-f2-2.0.3
ls -la /nix/store/jzwy3kispzdghmss63rm5mxpirii93a1-f2-2.0.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

f2

Maintainer pings
cc @zendo for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Fix import paths github action

Background
The import paths workflow seems broken:
https://github.com/osmosis-labs/osmosis/actions/runs/5115321530
Acceptance
The workflow works when manually running it

#5401 fixes the logic for getting the version_to_replace variable
there is another issue with this workflow:
the workflow will still fail, because after updating import paths to (for example) v16 from v15, some recently introduced modules will have an invalid version set. Ex:
How go.mod of cl-go-client looks after workflow run (from v15 to v16):
github.com/osmosis-labs/osmosis/v16 v15.0.0-20230530235412-9f091596cbcf

error it results in is:

version "v15.0.0-20230530235412-9f091596cbcf" invalid: should be v16, not v15

Here is how this error looks in gh actions.
Question to reviewers:
Are we running this workflow after the release is created or before? In former case, it would be easy to simply change the version of github.com/osmosis-labs/osmosis/vX in modules that import it

Before

@pysel thanks for the timely update of this script! Do you think you could also auto-apply state compatibility and changelog labels to the PR created by this CI job?

Also, FYI, the proto-gen CI check is failing: https://github.com/osmosis-labs/osmosis/actions/runs/5159223921/jobs/9293878347?pr=5408

The script doesn't seem to run make proto-all at the end, can we fix that?

the logic for proto has not been changed, but it only runs proto-gen, w/o formatting them

Closing as resolved