[IOS][Google Maps] animateToRegion: undefined is not an object

When i try to use animateToRegion — I got this:
undefined is not an object (evaluating 'this._mapManagerCommand(name).apply')

@gilbox what do you think about it?

This is one of the missing features. I'll probably fix this pretty soon.

@gilbox any progress on it?

I've had to de-prioritize this. ʕ ಡ ﹏ ಡ ʔ  .... feel free to submit a PR if you get a chance to look into it.

I have the same problem. But I add some code to AIRGoogleMapManager.m to fixed my problem.
Hope this can help you @stereodenis
PS: I am new to objective-c and react-native, so the following code maybe not good solution.
wait for new update version :)
RCT_EXPORT_METHOD(animateToRegion:(nonnull NSNumber *)reactTag
                  withRegion:(MKCoordinateRegion)region
                  withDuration:(CGFloat)duration)
{
  [self.bridge.uiManager addUIBlock:^(__unused RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) {
    id view = viewRegistry[reactTag];
    if (![view isKindOfClass:[AIRGoogleMap class]]) {
      RCTLogError(@"Invalid view returned from registry, expecting AIRGoogleMap, got: %@", view);
    } else {
      AIRGoogleMap *mapView = (AIRGoogleMap *)view;

      float latitudeDelta = region.span.latitudeDelta * 0.5;
      float longitudeDelta = region.span.longitudeDelta * 0.5;

      CLLocationCoordinate2D a = CLLocationCoordinate2DMake(region.center.latitude + latitudeDelta,
                                                            region.center.longitude + longitudeDelta);
      CLLocationCoordinate2D b = CLLocationCoordinate2DMake(region.center.latitude - latitudeDelta,
                                                            region.center.longitude - longitudeDelta);
      GMSCoordinateBounds *bounds = [[GMSCoordinateBounds alloc] initWithCoordinate:a coordinate:b];

      [mapView animateWithCameraUpdate:[GMSCameraUpdate fitBounds:bounds withPadding:55.0f]];
    }
  }];
}

any updates on this ?

FYI: It works for me in the latest release:
    "react": "15.4.2",
    "react-native": "0.42.0",
    "react-native-maps": "^0.13.0"

But, I needed animateToCoordinate which isn't there, so I have added that in and will send a PR.

Any progress on getting animateToCoordinate working?

Use latest version and comment please


bad word list probe & detector

probes can have a [preamble] [partial bad word]
look for completion of the word
preamble optional

see https://github.com/leondz/garak/issues/50#issue-1720137410 for links

addressed in 257364595a3fea2234d2cb5b636f30a5d6bd8fc3, 1ae56ed3dc2f7bc8d4e5776c2a7fc54b2c5bbee6, 152038d71f1e6a1f2ac1878d0e0dbe244a5eaad2


Quality selection UI for audio-only content

Have you read the FAQ and checked for duplicate open issues?
Yes
Is your feature request related to a problem? Please describe.
In the default UI controls, audio-only content gets a language menu, but not a quality menu (equivalent to the resolutions menu for video content).  Although the variant tracks API will allow the choice of quality level for audio-only, the default UI doesn't expose this.
Describe the solution you'd like
We should add a new overflow menu item for audio-only content, to allow the selection of a specific bitrate.
Describe alternatives you've considered
We could always leave it up to audio-only apps to register their own button for this, but we could easily make the UI more usable for audio-only content.
Additional context
Idea based on feedback from @vickymin13.  Thanks!

Hey @joeyparrish any update here in 2021 ?

Hello @mbvenu, we haven't got time to add that yet. I just marked it as "contributions welcome" to see if anyone is interested to work on it :) Thank you!

This might also be a good gsoc issue if anyone's interested.

Hello, everyone!
I approached the issue by introducing the quality selection to the currently existing resolution button in the UI, conditionally, when audio-only content is being displayed.
tracks = tracks.filter((track, idx) => {
  // If audio-only content is being displayed
  if (this.player.isAudioOnly()) {
    // Keep the first one with the same audioBandwidth.
    otherIdx = tracks.findIndex(
        (t) => t.audioBandwidth == track.audioBandwidth);
  // If video content is being displayed
  } else {
    // Keep the first one with the same height.
    otherIdx = tracks.findIndex(
        (t) => t.height == track.height);
  }
  return otherIdx == idx;
});

This replaces the resolution menu with an audio quality menu when audio-only content is displayed, but I have a couple of questions.
Are there any downsides to this design or should I reiterate by directly creating a new button that should only handle audio quality?
Also, is using the .audioBandwith attribute the correct approach to obtaining the bits/s, or am I mixing concepts together here?
I left my approach on a draft at my personal fork @draft:feat-2071 as a working proof of concept! 😄

You should use bandwidth instead of audioBandwidth.  HLS doesn't give us separate audio and video bandwidth numbers, so audioBandwidth may not be present in all cases.  (DASH content is more explicit.)  For audio-only content, bandwidth and audioBandwidth should be the same anyway.
I haven't reviewed your draft in detail, but in sounds reasonable.  Thanks!

Thank you for your review and comments on the draft!

For audio-only content, bandwidth and audioBandwidth should be the same anyway.

This was so obvious now that I think about it, if no video is being played, of course there is no videoBandwith, then bandwidth and audioBandwidth should be exactly the same, and clearly, bandwidth is preferred.
Anyways, I implemented the changes - Reiterated to bandwidth and fixed the declaration problem with a conditional operator.
Updated the draft @draft:feat-2071!

Great!  Please take the PR out of draft and let us know when it's ready for a more thorough review.  @ismena should take a look for UI, or I can take a look if she's busy.


Replace www.turbobytes.com IP by a known static address in tests

(Copy of original comment by @sajal )
re: https://github.com/turbobytes/geoipdb/blob/bbf39598be903a3d6553f6ed22846ae1fd950739/geoipdb_test.go
I suggest using a well known IP address (like <IP_ADDRESS>) . It is is highly unlikely that it will move across ASNs in the foreseeable future. Using www.turbobytes.com is not that ideal because if/when we move hosting provider it will break the test. Also we plan to host the site on CDN, once we do that the IP from LookupIP will be very inconsistent.

Curiously IP <IP_ADDRESS> is reported to be part of distinct ASNs according to who is queried:
 $ go test -v
=== RUN   TestInitIp
--- PASS: TestInitIp (0.00s)
	geoipdb_test.go:44: using ip '<IP_ADDRESS>' for tests
=== RUN   TestCreateHandler
--- PASS: TestCreateHandler (0.01s)
=== RUN   TestLibGeoipLookup
--- PASS: TestLibGeoipLookup (0.00s)
	geoipdb_test.go:63: libgeoip results for <IP_ADDRESS>: AS15169 Google Inc.
=== RUN   TestIpInfoLookup
--- PASS: TestIpInfoLookup (0.39s)
	geoipdb_test.go:73: ipinfo.io results for <IP_ADDRESS>: AS3356 Level 3 Communications, Inc.
=== RUN   TestCymruDnsLookup
--- PASS: TestCymruDnsLookup (0.18s)
	geoipdb_test.go:82: CymruDnsLookup results for AS15169: GOOGLE - Google Inc., US
	geoipdb_test.go:89: CymruDnsLookup results for AS3356: LEVEL3 - Level 3 Communications, Inc., US
=== RUN   TestLookupAsn
--- PASS: TestLookupAsn (0.00s)
	geoipdb_test.go:98: LookupAsn results: AS15169 Google Inc.
PASS
ok  	github.com/turbobytes/geoipdb	0.583s

Interesting; I'll investigate it a bit

The issue is with ipinfo.org database: ipinfo.io/<IP_ADDRESS>
AS3356 owns the parent subnet <IP_ADDRESS>/8, but AS15169 announces <IP_ADDRESS>/24 so correct answer should have been AS15169 http://bgp.he.net/ip/<IP_ADDRESS>

More proof we need our ASN DB ;-)

Good thing libgeoip is preferred over ipinfo in LookupAsn implementation.


defect: sparse: 1d bool mask with wrong shape should raise IndexError

Reference issue

https://github.com/scipy/scipy/issues/19951
What does this implement/fix?

This causes an IndexError to be thrown when a malformed boolean index is passed. Previously this index was converted to integer indices before the length was validated.
This now throws an index error, like the equivalent numpy classes do.
Notably, this is also implemented for the old matrix classes, mostly since it was easier to do it that way, but also because the equivalent numpy classes also error here.
np.matrix(np.arange(25).reshape(5, 5))[[True, False]]

---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
Cell In[3], line 1
----> 1 np.matrix(np.arange(25).reshape(5, 5))[[True, False]]

File /mnt/workspace/mambaforge/envs/scipy-dev/lib/python3.11/site-packages/numpy/matrixlib/defmatrix.py:194, in matrix.__getitem__(self, index)
    191 self._getitem = True
    193 try:
--> 194     out = N.ndarray.__getitem__(self, index)
    195 finally:
    196     self._getitem = False

IndexError: boolean index did not match indexed array along dimension 0; dimension is 5 but corresponding boolean dimension is 2

Additional information

https://github.com/scipy/scipy/pull/19956

This PR builds on ^
The main addition here is adding checks for masking along one axis.

Perhaps the new tests could be folded into  test_fancy_indexing_boolean, or the parts of the old test function that deal with missized masking could be moved to the new test function. But it's not a big deal either way.

I like keeping the cases for 1d and 2d masks separate, since they're different enough code paths I think it's informative to know if one or both cases are failing. My preference would actually be to split the 2d mask case out of test_fancy_indexing_boolean and either:

Make it it's own case
Move it into test_fancy_indexing_sparse_boolean, like:

 Diff for merging with `test_fancy_indexing_sparse_boolean `
    def test_fancy_indexing_boolean(self):
        np.random.seed(1234)  # make runs repeatable

        B = asmatrix(arange(50).reshape(5,10))
        A = self.spcreator(B)

        I = np.array(np.random.randint(0, 2, size=5), dtype=bool)
        J = np.array(np.random.randint(0, 2, size=10), dtype=bool)
        X = np.array(np.random.randint(0, 2, size=(5, 10)), dtype=bool)

        assert_equal(toarray(A[I]), B[I])
        assert_equal(toarray(A[:, J]), B[:, J])
        assert_equal(toarray(A[X]), B[X])
        assert_equal(toarray(A[B > 9]), B[B > 9])

        I = np.array([True, False, True, True, False])
        J = np.array([False, True, True, False, True,
                      False, False, False, False, False])

        assert_equal(toarray(A[I, J]), B[I, J])
-
-        Z1 = np.zeros((6, 11), dtype=bool)
-        Z2 = np.zeros((6, 11), dtype=bool)
-        Z2[0,-1] = True
-        Z3 = np.zeros((6, 11), dtype=bool)
-        Z3[-1,0] = True
-
-        assert_raises(IndexError, A.__getitem__, Z1)
-        assert_raises(IndexError, A.__getitem__, Z2)
-        assert_raises(IndexError, A.__getitem__, Z3)
-        assert_raises((IndexError, ValueError), A.__getitem__, (X, 1))

-    def test_fancy_indexing_sparse_boolean(self):
+    def test_fancy_indexing_2d_mask(self):
        np.random.seed(1234)  # make runs repeatable

        B = asmatrix(arange(50).reshape(5,10))
        A = self.spcreator(B)

        X = np.array(np.random.randint(0, 2, size=(5, 10)), dtype=bool)

        Xsp = csr_matrix(X)

        assert_equal(toarray(A[Xsp]), B[X])
        assert_equal(toarray(A[A > 9]), B[B > 9])

        Z = np.array(np.random.randint(0, 2, size=(5, 11)), dtype=bool)
        Y = np.array(np.random.randint(0, 2, size=(6, 10)), dtype=bool)

+        assert_raises(IndexError, A.__getitem__, Z)
+        assert_raises(IndexError, A.__getitem__, Y)
+        assert_raises(IndexError, A.__getitem__, np.zeros_like(Z))
+        assert_raises(IndexError, A.__getitem__, np.zeros_like(Y))

        Zsp = csr_matrix(Z)
        Ysp = csr_matrix(Y)

        assert_raises(IndexError, A.__getitem__, Zsp)
        assert_raises(IndexError, A.__getitem__, Ysp)
        assert_raises((IndexError, ValueError), A.__getitem__, (Xsp, 1))
+        assert_raises(IndexError, A.__getitem__, csr_matrix(np.zeros_like(Z)))
+        assert_raises(IndexError, A.__getitem__, csr_matrix(np.zeros_like(Y)))


gh-246: replace numpy.ndarray with numpy.typing.NDArray

Closes #246. Use numpy.typing.NDArray as the first step towards #280. With NDArray we can use types, i.e. NDArray[np.float64], which I'll save for future work (#306).
I have also gone throughout and made sure anything like ArrayLike is using the alias import numpy.typing as npt. Imports are generally in a if TYPE_CHECKING block where possible.
We are using numpy.testing in some places. This was being aliased as npt. To avoid confusion, I have removed this alias and left them as an explicit import.

This is ready, but blocked by #307.

Actually thinking about it, the test failure is related to the notebooks - which aren't being touched. So actually this is okay to merge.


Rere 24

Changed the image.yml file to show 2 subfields.

Can one of the admins verify this patch?

see my previous comments


[BEAM-9910]Add mutation byte counters to SpannerIO.write

Adding mutation byte counters for all mutations written to Spanner. This will help monitor job progress.
@nielm  @chamikaramj
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)

Lang
SDK
Dataflow
Flink
Samza
Spark
Twister2

Go

---

---

---

Java

Python

---

---

XLang

---

---

---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@nielm - Could you do the first review on this one?

@allenpradeep given that this seems to be a per-element change, have we done a performance analysis to confirm that there's won't be a significant performance degradation due to this ?
LGTM other than that.

@allenpradeep - any progress on this?

@allenpradeep given that this seems to be a per-element change, have we done a performance analysis to confirm that there's won't be a significant performance degradation due to this ?
LGTM other than that.

Hi Cham,
While dealing with a batch of mutations the size of the batch is already calculated. We are just passing this size as a KV pair through the pipeline and so there would be no cost here. But if a batch fails, then we end doing a recalculation of individual mutation as we commit it separately which is the added cost here. This may not be significant compared to the cost of making a RPC call per mutation.
However, I'm planning to work with Niel on this once he is back.
In my initial tests, I did not find performance degradation when the batches did not fail.

@allenpradeep - any progress on this?

@aaltay
I had similar thoughts on this as @chamikaramj had with respect to performance. I'll would want to hear feedback from Niel on this and so I'll work with him once he is back.

LGTM from me :)

Allen, are you doing further updates here ? If not we can merge.

Retest this please

Allen, are you doing further updates here ? If not we can merge.

Hi Cham,
I'll a few more tests and rebase this.

Retest this please

Allen, any updates ? Seems like there's a conflict to be resolved now.
Feel free to close if this is no longer needed.


Test for orphaned subprocesses

This adds the test requested in https://github.com/spotify/luigi/pull/1187#issuecomment-137130124 .
I've tweaked the implementation of _recursive_terminate to send SIGINT instead of SIGKILL (which allows processes to cleanup after themselves). While using this I also ran into a race condition where a subprocess finishes between the time terminate() is called and the signal is sent, so I added some try/catch blocks to handle this gracefully.

I'm not really that comfortable with signals and unix processes. But shouldn't you first try to terminate and then kill after a while if the process still doesn't terminate?

Ok, can you rebase this please? Sorry for the conflict. :)

shouldn't you first try to terminate and then kill after a while if the process still doesn't terminate

Yeah you could do that -- I switched from kill() to terminate() (with no eventual kill) because that was more consistent with the name of the method, and the behavior of the superclass. To my knowledge multiprocessing.Process sends a single SIGTERM signal and doesn't ever send SIGKILL.
I could imagine situations where the cleanup after a terminate request legitimately takes a while (For example in python you can intercept SIGTERM and do as much work as you want), so choosing a proper timeout interval is tricky, and potentially something that should be specifiable as a task attribute and/or command line argument.  Maybe that's best left to a dedicated PR?

Yea, I'm fine with keeping it simple and only doing SIGTERM. You seem to know what you're doing. :)

@Tarrasch ok, this is rebased and green!

Can you merge (amend) the commits? It's not nice useful to see "Rebase cleanup" in the commit log. :)


[BUG] SAML error when user logs out using local authentication.

Rancher Server Setup

Rancher version: v2.10-2b955aa0e4823baf6fbaf25c898aeae0273c6b48-head

Installation option (Docker install/Helm Chart): Docker and Helm

If Helm Chart, Kubernetes Cluster and version : k3s

Proxy/Cert Details: byo valid and rancher-self-sign

Information about the Cluster

Kubernetes version: 1.30 and 1.28
Cluster Type: local / imported

User Information

What is the role of the user logged in? admin

Describe the bug
When the user logs out a POST request is sent to /v3/tokens?action=logout
But the response is 500
To Reproduce

Install Rancher
Login as admin
Logout observing the Developer tools network section.

Result
The response is 500
{
    "baseType": "error",
    "code": "ServerError",
    "message": "SAML [logout]: Rancher provider resource `local` not configured at all",
    "status": 500,
    "type": "error"
}

Expected Result
Response do not be 500 neither SAML related as it's not enabled.

@izaac - Can you confirm that this is fixed for v2.10.1?


[Feature] Removing the static images and storing them in Supabase Storage

Description
On home page the cart logo shows 8 cart element by default i think it is not as intended and on clicking add to cart it is not being added to cart and nor it have option to delete cart element
Screenshots

Any additional information?
Please assign this issue under GSSOC'24 to me , i would like to work on this to solve this issue and want to add some extra functionality..
What browser are you seeing the problem on?
No response

Congratulations, @Yogesh-ok55! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

How would you try to implement that?
Coz we also need to store the cart items in Supabase @Yogesh-ok55

As you have stored images locally so for that I can use useContext() hook to implement this , for managing states or if you want I can also do this using Supabase but the problem here is that you have stored images locally..

I think we need to create a Cart Slice but yes keeping the images in Supabase Storage is also necessary. Can you work on that? @Yogesh-ok55

Yes I can do..

Okay drop me your email here in the comment. Store the images in supabase DB and use them in the frontend.
We'll move to other tasks later. @Yogesh-ok55

<EMAIL_ADDRESS>

Invite sent for supabase. check your mail. @Yogesh-ok55

Invite sent for supabase. check your mail. @Yogesh-ok55

Received and joined

Received and joined

All the best! @Yogesh-ok55

Sorry for being late , actually it was my end term going on , so I could not able to do this please assign again this to me I have already uploaded images to supabase and it is being rendered from supabase

showing this token is invalid..
so please do this again

it was expired as you were too late :) @Yogesh-ok55

@Yogesh-ok55 what are the updates? give it by today eod

It is already done I have also create a PR but I have been asked to fix some build errors  which I have done but I don't what next to do

@Yogesh-ok55 mention your issue number in the pr

@Yogesh-ok55 mention your issue number in the pr

issue number #152 , PR number 220 , i have made some changes to fix build errors which was problem in my PR , these changes will solve build errors


Remove brython.js and text/python script from discovery page

[ ] Check presence of url search params
[ ] SPID button link

brython was there as a simple example about how to use it in a daily usage :)
whould you like to have some vanilla js for that?

Yes, is my idea, more later I send a code sample :+1:

Feel free and go ahead


Incremental builds in VS does not copy Views dll from referencing class library project

Steps:

Create a solution containing a WebApp that references a Razor Class Library project.
Build the solution
Verify that the ClassLibrary Views dll and pdb are copied to the WebApp's output directory
Clean the WebApp
Build it.

Expected:
Views dll exists in the build output dir of WebApp
Actual:
No view dll found in the build output dir

Fixed in 8d99ba53ced84ce4223b22e16a738bd6eb26b7f6


to destroy the communication between app and service

Hey, everything fine? Can you tell a little more about this? sounds interesting!


Not installing with<EMAIL_ADDRESS>

Hi,
Getting the following error while doing pod install.

What version do you use?
It was fixed in https://github.com/futurepress/react-native-static-server/pull/63

Looks like this version wasnt released. @saggiyogesh try to install version from github

@StanislavMayorov When it is planned for release.

I dont know. I'm not contributor of this package.


Handle Ctrl-C's and other Signals gracefully.

Let's track the signals and their functionality here.


add extensions to GraphQLRequestError

this feathure can support error code etc

Codecov Report
Base: 100.00% // Head: 99.21% // Decreases project coverage by -0.78% :warning:

Coverage data is based on head (11367c2) compared to base (66283f3).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #76      +/-   ##
===========================================
- Coverage   100.00%   99.21%   -0.79%
===========================================
  Files            8        8
  Lines          125      127       +2
  Branches        36       37       +1
===========================================
+ Hits           125      126       +1
- Misses           0        1       +1

Impacted Files
Coverage Δ

src/AwesomeGraphQLClient.ts
100.00% <ø> (ø)

src/GraphQLRequestError.ts
87.50% <50.00%> (-12.50%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Thanks!


[Payment card / Subscription] Integrate failed billing scenarios banner with backend data

Details

Prepare account for testing:
Sign up for an account on staging.expensify.com, go to Settings > Workspaces > New Workspace. Create a Collect workspace.
To access this newly created component, paste the following link into the browser
https://dev.new.expensify.com:8082/settings/subscription
or add this effect to InitialSettingsPage.tsx
useEffect(() => {
    Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION)
}, [])

Fixed Issues

$ https://github.com/Expensify/App/issues/42431
PROPOSAL: N/A
Tests

Log into your account that has a Collect/Control workspace (see Details section above for instructions)
Navigate to the Subscription settings page
Edit the src/pages/settings/Subscription/CardSection/utils.ts file to to return a specific variant and check if the app displays the correct banner
Repeat the previous step for every variant, e.g.

Looking at the first case:
case SubscriptionUtils.PAYMENT_STATUSES.POLICY_OWNER_WITH_AMOUNT_OWED:
    return {
        title: translate('subscription.billingBanner.outdatedInfo'),
        subtitle: translate('subscription.billingBanner.updateCardDataByDate', {date: endDateFormatted}),
        isError: true,
        isRetryAvailable: true,
    };

copy the return and paste it over the switch block to return by default:
return {
    title: translate('subscription.billingBanner.outdatedInfo'),
    subtitle: translate('subscription.billingBanner.updateCardDataByDate', {date: endDateFormatted}),
    isError: true,
    isRetryAvailable: true,
};

[ ] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

N/A

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

Policy owner with amount owed, within grace period

Policy owner with amount owed, overdue (past grace period)

Owner of policy under invoicing, within grace period

Policy under invoicing, overdue (Past grace period)

Billing disputed by cardholder

Card not authenticated

Insufficient funds

Expired payment card

Card due to expire soon

Retry billing - SUCCESS

Retry billing - FAILURE

@MrMuzyk PR updated!

I would like to have a better understanding of the problems and solutions that this PR is solving, as I commented on the issue, before I start reviewing this. Otherwise I'm going in pretty blind to the purpose of what we're trying to achieve.

@JKobrynski when you requested a review via puller bear I'm assuming you meant to get a C+ to look at this PR right?
@neil-marcellini I think you can unassign and I'll get a C+ to review this

Update: requested C+ review here

I'll review this PR.

The banners feel pretty good to me, but cc @dannymcclain who worked on these for a quick style check

Yeah the banners are looking good to me too.

@blimpich @JKobrynski I am getting the grace period date in the past. In that case should the message be still Update your payment card by May 6, 2024 to continue using all of your favorite features.?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Looks like we have a merge conflict. @JKobrynski can you address that?

@blimpich change applied, conflicts resolved

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.4-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This looks like it's causing some flakey tests - https://github.com/Expensify/App/issues/45340 - let me know if you have ideas!

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Part of this issue was caused by this PR.


Progress bar only shows up for the first file downloaded from a release

Our CI just started consuming v0.27.4 and I noticed that there is an issue with the file download progress bar when retrieving multiple files from a release. Here is the output from downloading ERT 1.8.23:
2016/12/21 00:47:13 PivNet Resource version: 0.27.4
2016/12/21 00:47:13 Creating download directory: /tmp/build/get
2016/12/21 00:47:13 Getting release for product slug: 'elastic-runtime' and product version: '1.8.23'
2016/12/21 00:47:16 Accepting EULA for release with ID: 3508
2016/12/21 00:47:16 Getting product files
2016/12/21 00:47:17 Getting file groups
2016/12/21 00:47:19 Getting release dependencies
2016/12/21 00:47:19 Getting release upgrade paths
2016/12/21 00:47:19 Downloading files
2016/12/21 00:47:19 Filtering download links by glob
2016/12/21 00:47:19 Downloading filtered files
2016/12/21 00:47:19 Downloading: 'PCF Elastic Runtime 1.8 License' to file: '/tmp/build/get/open_source_license_PCF-Elastic-Runtime-1.8.txt'
 1.71 MB / 1.71 MB  100.00% 3s11ss
2016/12/21 00:47:25 Downloading: 'DiegoWindows' to file: '/tmp/build/get/DiegoWindows-1.8.5.zip'
2016/12/21 00:47:30 Downloading: 'PCF Cloudformation for AWS Setup' to file: '/tmp/build/get/pcf_1.8.23-build.2_cloudformation.json'
2016/12/21 00:47:33 Downloading: 'PCF Elastic Runtime' to file: '/tmp/build/get/cf-1.8.23-build.2.pivotal'

It looks like there might be a rendering issue.

Interestingly, even if CI only downloads a single file from PivNet, the elapsed time in the progress bar is still messed up:
2016/12/21 16:24:25 Downloading filtered files
2016/12/21 16:24:25 Downloading: 'PCF Elastic Runtime' to file: '/tmp/build/get/cf-1.8.9-build.13.pivotal'
 4.63 GB / 4.63 GB  100.00% 6m32ss2s
2016/12/21 16:30:59 Calcuating MD5 for downloaded files

Yeah it's interesting. I think there's two issues here - one is that the progress doesn't seem to render properly - the === is missing. The second issue is that the progress bar doesn't seem to render at all for all products after the first. It seems likely that these issues are related. Not sure what's going on yet.

Yeah it's interesting. I think there's two issues here - one is that the progress doesn't seem to render properly - the === is missing. The second issue is that the progress bar doesn't seem to render at all for all products after the first. It seems likely that these issues are related. Not sure what's going on yet.

Fixed - the progressbar library needed to explicitly be told the width of the terminal as it isn't a TTY. This will be in the next release.


[Bug]: CSS-in-JS is unable to style the error/catch handling component

Which Remix packages are impacted?

[X] remix (Remix core)
[ ] create-remix
[ ] @remix-run/architect
[ ] @remix-run/cloudflare-workers
[ ] @remix-run/dev
[ ] @remix-run/express
[ ] @remix-run/netlify
[ ] @remix-run/node
[ ] @remix-run/react
[ ] @remix-run/serve
[ ] @remix-run/server-runtime
[ ] @remix-run/vercel

What version of Remix are you using?
^1.0.6
Steps to Reproduce

Go to Codesandbox and run it.
Click to GO TO 404 page button. And notice that the button has a red color.
Because the /404-unkown page doesn't exist, it renders the CatchBoundary component containing the button component. And notice, the button should be the same as the one used on the index page. (e.g. red color button)

Expected Behavior
The red button should appear on the /404-unkown page.
Actual Behavior
A button that is not styled red backgroud color.

IMO, this problem occurs because the root error handler component unmount and mount it again. To solve the problem, it seems that we need to make the css created through ServerStyleSheet available to the client as well, or there must be a component that wraps the error handler and the root component in common way.

@pixelstew I posted a workaround here (material-ui / emotion) : https://github.com/mui-org/material-ui/issues/30436#issuecomment-1003339715

@pixelstew I posted a workaround here (material-ui / emotion) : https://github.com/mui-org/material-ui/issues/30436#issuecomment-1003339715


Add -Checkout parameter to Get-VVVersion

Adds support for a new -Checkout parameter in the Get-VVVersion cmdlet, enabling users to checkout a version of a file using git blob tags. This update includes changes to the function definition, documentation, and integration tests.

Functionality Update: Modifies Get-VVVersion in source/Public/Get-VVVersion.ps1 to include a -Checkout switch parameter, allowing for the checkout of specific versions of a file. Implements logic to ensure the -Path and -Version parameters are specified when using -Checkout.
Documentation Enhancement: Updates docs/help/Get-VVVersion.md to describe the new -Checkout parameter and provides usage examples, ensuring users understand how to use the new functionality.
Testing Expansion: Adds a new integration test in tests/Integration.Tests.ps1 to verify the checkout functionality works as expected, ensuring reliability of the new feature.

For more details, open the Copilot Workspace session.

Should add a warning and no change on -Checkout if it's the same contents.


How about F-Droid?

Thanks a lot for this. It improves things for me significantly.
Maybe get this into an F-Droid repo so more people can find this easily?

Thanks for the suggestion of adding it to F-Droid.
I've created a pull request for F-Droid: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11097


Use TextVar for CLI flags

It can simplify code in many ways (Go 1.19+) and I think we have some use cases for it:
https://pkg.go.dev/flag#TextVar

No, it can't, see #3157.


<EMAIL_ADDRESS>update version 6.4.3

[x] I have read the Contributing Guide.

/verify

#10971


Add G123 window size calibration

Currently the size runs G123 GWSS using the window size chosen from H12 calibration. However, the G123 calibration curves generally look a bit different, and indicate a different window size should be used for G123. Suggest to add a separate G123 window size calibration step to the workflow.
Btw, it's probably safe to assume that if a cohort passes H12 calibration then it will also pass G123 calibration, and therefore filtering of final cohorts may still only need to inspect the results of H12 calibration. Something to consider though, as there could be an edge case where H12 calibration passes but G123 calibration fails, in which case the build would break.

closed with #44


Expand build process

Credentials need updated

Current coverage is 48.97%

Branch #7 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.


Unable to resolve internal DNS names when external network connection is broken

To Reproduce
Steps to reproduce the behavior:

Disconnect external ISP connection (path to external DNS server)
Try to resolve names of machines on internal network

Expected behavior
All machine names on internal network which are managed by the OPNSense router should resolve, regardless of the state of the connection to the external network.  They do not.
These machine names include 'Host Overrides' defined in the 'Dnsmasque DNS=>settings=>Host Overrides' section, and also names that are registered by the DHCP service.
Additional context
No external connection to a DNS service should be required to resolve internal machine names managed by my internal OPNSense router.  I fear this represents a information leak, and therefore a security risk.  Is the router's DNS service first trying to resolve internal machine names externally?
I am uncertain with which version of OPNSense this broke, but I'm reasonably certain it has not always behaved in this manner.  My ISP connection failed yesterday a couple of hours after updating my router packages, which created a lot of confusion about what was happening.  I finally realized my external network connection was down.  When the connection returned, I was able to resolve internal machine names again.
Environment
All latest OPNSense updates applied as of 04/11/2020
Versions
OPNsense 20.1.4-amd64
FreeBSD 11.2-RELEASE-p18-HBSD
OpenSSL 1.1.1f  31 Mar 2020

If you use a forwarder, then be prepared for your queries to be forwarded. ;)
I'm not sure if this is actually a feature, but I do know that possibilities to configure this more elaborate do not exist (in Dsnmasq). No such report for this over the years, likely not relevant to security, but that's no conclusive analysis.
That being said, I'm not sure your connection is non-existant or simply hangs due to ISP hiccup, in wich case no service would have a chance to return directly and instead do some operation that has to time out first.
My best guess is try to use Unbound and see if that works better. Unbound is our default since a few years.
Cheers,
Franco

After a bit more digging around in the Services=>Dnsmasq=>Settings and digging into 'Domain Overrides' I found some instructions that helped me figure it out.
I added a Domain Override for my domain and set the value of the IP Address to '!' as noted by the instructions.
Here are the instructions given for the IP Address field on that page...

IP address of the authoritative DNS server for this domain
e.g. <IP_ADDRESS>
Or enter # for an exclusion to pass through this host/subdomain to standard nameservers instead of a previous override.
Or enter ! for lookups for this host/subdomain to NOT be forwarded anywhere.

I was thrown by OPNsense because this was default behavior for the router's system domain on other routers I have used.
Anyway, this appears to resolve the issue.  DNS look-ups for the router's domain are not forwarded to an external DNS, and DNS lookups for my domain on my internal network don't hang when my external network connection goes down.


pull request for e2e test at 11/16/2016 00:15:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Crashing the app in iOS 13.

In all the simulator and iOS 13 devices..
App is getting crashed says "nil" cannot insert (object) at index ......
I can not debug in simulator at all.
+ (void)prepareNotificationForPresentation:(RMessageView *)messageView
{
  [mLock lock];
        [[RMessage sharedMessage].messages addObject:messageView];
  [mLock unlock];

  [nLock lock];
  if (![RMessage sharedMessage].notificationActive) {
    [nLock unlock];
    [[RMessage sharedMessage] presentMessageView];
    return;
  }
  [nLock unlock];
}

Which line is the crash at?

Which line is the crash at?

At line 4
[[RMessage sharedMessage].messages addObject:messageView];
I checked In few of the iOS devices it is being crashed.

Really won't be able to investigate for now but you can try to debug why messageView is nil which it shouldn't be. I would put a breakpoint at line 4 and start tracing the stack trace upwards.


TODO: refactor material updates

Move the event callbacks for material updates from level code to material-specific code.

Could not think of a way that would not require a lot of changes to the codebase...
Updating materials in RenderObject is a no-go, as I do not want to pass level data to render objects.
Making a separate material manager might be an option to consider in the future.


wsl --install fails with Error Code: 0x80245006

Version
Microsoft Windows 10 Enterprise [Version 10.0.19044]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
5.10.16
Distro Version
No response
Other Software
No response
Repro Steps

Enable "Windows Subsystem for Linux" and "Virtual Machine Platform" in Windows Features.
Download and install kernel update for WSL2: https://learn.microsoft.com/en-us/windows/wsl/install-manual#step-4---download-the-linux-kernel-update-package
In an Admin PowerShell, run wsl --install -d Ubuntu

Expected Behavior
Ubuntu gets installed.
Actual Behavior
Installing: Ubuntu
An error occurred during installation. Distribution Name: 'Ubuntu' Error Code: 0x80245006
Diagnostic Logs
Note: I had already had WSL installed in the past, but had uninstalled it. Not sure if potentially the existing installation had broken anything.
wsl --list --online shows that I am connected, and Ubuntu is returned on the list.

Same issue here on my corporate laptop. Others in the company have installed WSL without issue, but not recently. After trying (and failing) to find any reference to this error code I stumbled on this blog post:
https://devblogs.microsoft.com/commandline/the-windows-subsystem-for-linux-in-the-microsoft-store-is-now-generally-available-on-windows-10-and-11/
I thought maybe it has something to do with the fact that I don't have the windows store installed on my laptop. I attempted to use the new --web-download option but complains that option isn't available.
wsl --status output:

Default Version: 2

Windows Subsystem for Linux was last updated on 2023-01-13
WSL automatic updates are on.

Kernel version: 5.10.16

/logs

Same as @shaggyhiggins I was doing this on a corporate laptop, and several employees had done it successfully. It appears IT made changes to our proxy that seems to have broken it. Doing it from my home network resolved the issue.

Versione
Microsoft Windows 10 Enterprise [Versione 10.0.19044]
Versione WSL

[x] WSL2
[ ] WSL1

Versione del kernel
5.10.16
Versione distribuita
Nessuna risposta
Altro software
Nessuna risposta
Passaggi di riproduzione

Abilita "Sottosistema Windows per Linux" e "Piattaforma macchina virtuale" in Funzionalità Windows.
Scarica e installa l'aggiornamento del kernel per WSL2: https://learn.microsoft.com/en-us/windows/wsl/install-manual#step-4---download-the-linux-kernel-update-package
In un PowerShell di amministrazione, eseguiwsl --install -d Ubuntu

Comportamento atteso
Ubuntu viene installato.
Comportamento effettivo
Installazione: Ubuntu Si è verificato un errore durante l'installazione. Nome distribuzione: Codice errore "Ubuntu": 0x80245006
Registri diagnostici
Nota: avevo già installato WSL in passato, ma lo avevo disinstallato. Non sono sicuro che potenzialmente l'installazione esistente abbia rotto qualcosa.
wsl --list --onlinemostra che sono connesso e Ubuntu viene restituito nell'elenco.


Added an option to pass in a custom HttpsConnectionContext to the Htt…

Overloaded constructor for HttpsClientBlock to enable setting custom SSL context for Akka Http

Minor thing but can you please use orElseGet() instead of orElse() to prevent unnecessary object creation?


perform CodeQL analyses weekly and on prs

Codecov Report

Merging #160 (6c419ee) into main (b14f5c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   85.23%   85.23%
=======================================
  Files          22       22
  Lines         210      210
  Branches       32       32
=======================================
  Hits          179      179
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b14f5c4...6c419ee. Read the comment docs.


GH-4920 SPARQLConnection.size() now uses count query

GitHub issue resolved #4920
Briefly describe the changes proposed in this PR:
SPARQLConnection.size() method should not fetch every statement in the repository. Just send a count query instead.

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[x] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] I've squashed my commits where necessary
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@hmottestad did you see this license failure before?

@hmottestad did you see this license failure before?

I haven't seen that one before, but I have once experienced an old dependency suddenly failing the license check. I didn't figure out what was wrong last time, ended up just upgrading the dependency. Let me try to submit it to clearlydefined. Might take some time though :(

@hmottestad did you see this license failure before?

I haven't seen that one before, but I have once experienced an old dependency suddenly failing the license check. I didn't figure out what was wrong last time, ended up just upgrading the dependency. Let me try to submit it to clearlydefined. Might take some time though :(

CQ: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14675

I'm still a bit unsure about this. We want to be able to correctly count the statements in the default/unnamed graph. I don't know how well the previous solution handled it, but I would assume that it would be able to check for if the context is null on each statement.

I'm still a bit unsure about this. We want to be able to correctly count the statements in the default/unnamed graph. I don't know how well the previous solution handled it, but I would assume that it would be able to check for if the context is null on each statement.

The behavior is the same between this code and previous regarding the default graph.
Before:
select * where {?s ?p ?o}

New
select (count(*) as ?c) where {?s ?p ?o}

The logic is a bit more robust in the case of using the internal default graph IRI's of RDF4j. Which should not be send over the wire.


expose the panose subfield for detecting the GenericFamily in fount

https://stackoverflow.com/questions/46708801/is-there-an-algorithm-to-classify-a-ttf-font-into-a-generic-font-family-programm

this was solved by matching strings in font names


ci: add better/more useful checks

the title is pretty clear as day. right about now, the only type of ci or github actions is the semantic check for pr titles/commit messages and a compile on commit. i dont have an idea of useful ci, but i just thought to put the idea out

Once #63 is finished and merged, we should add build/test ci


NotificationAction objects page not found

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[ ] Correction or update
[x] Bug

Details

URL: https://developer.mozilla.org/en-US/docs/Web/API/NotificationAction
Referance URL: https://developer.mozilla.org/en-US/docs/Web/API/Notification/actions
Problem: Resource not found.

There are a number of red links on this page, pointing to pages that haven't been written yet. This isn't currently a hight priority, so I'm clising this for now.


Empty data label doesnt seems to work

I use it like it is said on documentation : http://c3js.org/reference.html#data-empty-label-text
Nothing appears and a javascript error pops out.
Please make documentation clearer.
data: {
  empty: {
    label: {
      text: "No Data"
    }
  }
}

My bad, it works fine


fido2 type hints complete

added type hints for  the entire fido2/ directory
likely I oversaw/misjudged/forgot some, but this doesn't make things worse than  before I suppose
fido2::set_pin sneaked itself in as the non-type-hinting part
needs some more tests, but 1st draft in place

oh, and I might have accidentally replaced all 3-line occurrences of these (within the scope of this PR of course): https://github.com/Nitrokey/pynitrokey/blob/284456c9bd7d128cee021c764fb2f725ac6f091d/pynitrokey/fido2/client.py#L46-L48 with the proper 1-liner version, if we decide that black never fails in its perfection, then I'll happily invest another 20secs to generate lots of empty lines :grinning: :rocket:

Hi! Is this a WIP? If so, please make it a draft. Otherwise please call us for the review, thanks!

called for review


UnnecessaryExplicitTypeArguments: Don't apply to var variables

When the initializer of a var declared variable calls a method with type arguments, these arguments should not be removed, as otherwise the type cannot be deduced and the Java code doesn't compile.
Fixes: #2818

I suggest that we add a utility method to J.VariableDeclarations (and possibly also J.VariableDeclaration.NamedVariable) like isVar(). There is already at least one other recipe which could use this: https://github.com/openrewrite/rewrite/blob/683900a969afeab5d3c83e952193b25c195d0437/rewrite-java/src/main/java/org/openrewrite/java/cleanup/UseCollectionInterfaces.java#L155-L157


"The -c and -m parameters of StringTie are not effective.

During the bam-gtf conversion step, I set the -c 3 parameter, but when I checked the generated gtf file, I found that there were still transcripts with cov values less than 3. I did not handle them and merged them together. The file size was about 140.2MB. Later, I found that the -m parameter was set to 50 by default during the merging process, so I changed it to 200. However, I found that the resulting gtf.tamp file still contained transcripts with a length less than 200, and I was confused as to why. I also tried adding the -c parameter again during the merge step, but it didn't work, and it still generated a file with the same size of 140.2MB as before. Can you explain this to me?"
stringtie --merge -m 200 -c 3 -F 1 -p 8 -G
tringtie -p 8 -G  update.gtf
-o  ZS/mappingputout/GTF/7121BSF.gtf
--rf -c 3 -m 200 -l

These parameters only apply to the novel transcripts assembled by StringTie, not to the ones in the reference, i.e. the ones in the file, provided with the -G parameter.

这些参数仅适用于 StringTie 组装的新转录本，不适用于参考文献中的转录本，即文件中的转录本，由 -G 参数提供。
So, stringtie -- merge-c 3-m200 should work, right?
But the resulting new file, "mergenew.gtf," is the same size as the one I created without setting the -c 3 parameter。
And in this part “--merge “， -m parameter was set to 50 by default during the merge process, so it was changed to 200. However, I found that the generated gtf.tamp file still contained transcripts less than 200 in length。

Thank you，So, stringtie -- merge-c 3-m 200 should work, right?
But the resulting new file, "mergenew.gtf," is the same size as the one I created without setting the -c 3 parameter。
And in this part “--merge “， -m parameter was set to 50 by default during the merge process, so it was changed to 200.However, I found that the generated gtf.tamp file still contained transcripts less than 200 in length。

These parameters only apply to the novel transcripts assembled by StringTie, not to the ones in the reference, i.e. the ones in the file, provided with the -G parameter.

Thank you，So, stringtie -- merge-c 3-m 200 should work, right?
But the resulting new file, "mergenew.gtf," is the same size as the one I created without setting the -c 3 parameter。
And in this part “--merge “， -m parameter was set to 50 by default during the merge process, so it was changed to 200.However, I found that the generated gtf.tamp file still contained transcripts less than 200 in length。

These parameters only apply to the novel transcripts assembled by StringTie, not to the ones in the reference, i.e. the ones in the file, provided with the -G parameter.
Do you mean that these parameters set the new transcripts produced after assembly, and those less than 200 that are already present in the reference genome are still present? Or should I not provide the -G argument and just "merge "or "merge.list"？


Buffers opened through fzf require resourcing to get colorcolumns

Category

[ ] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[x] Neovim
[ ] Etc.

OS

[x] Linux
[x] Mac OS X Maybe, havne't yet tried it on my mac
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

I currently have a setup which colors all the columns from 101 onwards:
let &l:colorcolumn=join(range(101, 999), ',')
For some reason, this does not work on buffers opened through fzf and I have to source my init.vim manually. Any ideas why this might be happening?

&l:colorcolumn is local to buffer, remove l: part.


Update CUDA capabilities to match official TF releases

After discussing with @rnett and build with these new capabilities, I think we are good to merge


Cursor focused at the end of the file

Hi,
Since 1.2.0, when we try to open a file at a defined line number, the cursor is set to the end of the file, not on the correct line.
The file must not have been opened before.

I get this problem as well, in a slightly different way, but I think it's related to the same issue.
Steps to reproduce:

install atom-editorconfig
Press cmd+shift+f (or search project) and search for a known word (in a large file, which requires scrolling)
Click a search result
Cursor is focused at the end of the file

What should happen:

Cursor should be focused on selected search result

I get the same thing, but when using symbols-view's go-to-declaration (only when the file isn't currently opened). Seems very similar to what's reported in here.

Same thing going on for me, see https://github.com/atom/find-and-replace/issues/526
I've narrowed it down to the problem coming from this atom package. Will have to disable the package for the time being, as it's unworkable at the moment.

I've run into this as well. This was the last plugin I thought would be causing the issue :) I haven't had a chance to look into what's causing it yet, but I might this weekend.

+1

This is a problem for me, too.

+1

+1
Experiencing this as well (using 1.2.0). As mentioned above, it seems to have started happening when the end_of_line support got added in, and seems to be fixed by removing the end_of_line setting from my .editorconfig file.

+1, closed the issue on the atom-project when I found out that it is related to the editorconfig-package

:+1:

@caleb Mind doing a PR with your fix?

@sindresorhus couldn't you just take what's in this comment https://github.com/sindresorhus/atom-editorconfig/issues/51#issuecomment-140940459, and see if it works and/or breaks anything, and if everything looks good just apply the update? @caleb's comment is from more the a month ago, surely we all have commitments IRL, the longer this bug continues to exist the longer everyone have to either: be annoyed by this bug; or not use this package at all.

couldn't you just take what's in this comment #51 (comment), and see if it works and/or breaks anything

So could you... This is open source. Complaining will get you nowhere. If something bothers you, fix it.

surely we all have commitments IRL

And I don't?

the longer this bug continues to exist the longer everyone have to either: be annoyed by this bug

Seeing how nobody has done a PR yet, it can't be very annoying.

or not use this package at all.

Yes, please do.


Inaccurate value in UPDATE query

Hi, when we generate an update query of the table contains as primary key a decimal(17), the primary key loses accuracy value.
As in the examples below.
UPDATE DB2PNG.SLCT_LIB_CRD SET VL_LIB_SLCD=600 WHERE NR_SLCT=20150871226566400;
UPDATE DB2PNG.SLCT_LIB_CRD SET VL_LIB_SLCD=700 WHERE NR_SLCT=20150871245483100;
In first case, the right value is<PHONE_NUMBER>6566398 and in second is<PHONE_NUMBER>5483101.
Versions:
DBeaver: 4.0.7, on Windows 7
DB2 z/OS Driver

Could you post sample DDL + INSERT?

DDL:
CREATE TABLE DB2PNG.SLCT_LIB_CRD (
	NR_SLCT DECIMAL(17,0) NOT NULL,
	SG_SIS_CDU_SLCT CHAR(3) NOT NULL,
	DT_LIB_SLCD DATE,
	VL_LIB_SLCD DECIMAL(17,2) NOT NULL,
	CD_PRD_SLCT SMALLINT NOT NULL,
	CD_MDLD_SLCT SMALLINT NOT NULL,
	CD_CHV_CTL_TRAN SMALLINT NOT NULL,
	NR_UNCO_CTR_OPR DECIMAL(17,0) NOT NULL,
	CD_FNLD_CRD SMALLINT NOT NULL,
	NR_OPR_SIS_CDTR DECIMAL(17,0) NOT NULL,
	CD_PRF_DEPE_CDTR SMALLINT NOT NULL,
	NR_PRPT_SIS_CTRC INTEGER NOT NULL,
	CD_LNCD INTEGER NOT NULL,
	PRIMARY KEY NR_SLCT
);

Insert:
INSERT INTO DB2PNG.SLCT_LIB_CRD (
	NR_SLCT, SG_SIS_CDU_SLCT, DT_LIB_SLCD,
	VL_LIB_SLCD, CD_PRD_SLCT, CD_MDLD_SLCT,
	CD_CHV_CTL_TRAN, NR_UNCO_CTR_OPR,
	CD_FNLD_CRD, NR_OPR_SIS_CDTR, CD_PRF_DEPE_CDTR,
	NR_PRPT_SIS_CTRC, CD_LNCD )
VALUES (
<PHONE_NUMBER>6566398, 'XPO', NULL,
	500.00, 73, 11, 1,<PHONE_NUMBER>7701445,
	1, 5002713, 123, 22118996, 456
);

Well, I can't test it with DB2 z/OS. In DB2 LUW I see exactly the same values which were inserted.

Probably z/OS driver fetches numbers differently. You could try to play with numbers data format (context menu->View/Format->Data formats->Numbers). E.g. try different rounding modes.

When we change some atribute on record, the script created loses acurracy on NR_SLCT field. As in the example in image.
Ps.: For consult the script created, click in the magnifying glass below records.

@serge-rider The error still persists, could you check, please?

hi @kelvinwnfeitosa , is issue still actual for you on 6.2.5?

there is no update on ticket more than a month.
If issue still actual for you - feel free to reopen the ticket


darwin.CF: fix retry condition

Motivation for this change
Using a function in an if condition when set -e is set doesn't seem to
break out or return false which means the workaround from 41ca86129fa18278758e177d1821351dc608d24c
never gets triggered.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

OK, why not try it.  Pushed to staging-next, as that's where it blocked Hydra.


Multi-account support

The functionality would be useful when using business and private accounts - it would be convenient to switch between users.

I agree. It would be very helpful to have multi-account support.


建议增加双屏任务栏增强功能

建议增加双屏任务栏增强功能，将当前任务显示到当前屏幕任务栏

Translated by deepl.com:

Suggest adding a dual-screen taskbar enhancement to display the current task to the current screen taskbar

@FBI1234
Maybe it helps you: You can choose in personalization settings of Windows, that the Window icon should be only shown on the monitor where the window is shown.

Can you please add a lot more context here?  I'm not sure what exactly your asking for here.


App is crashing when using "cmd+S" shortcut

The app is reproducible crashing when using the "cmd+S" shortcut to save a schema. All data is lost and no auto-resume is available.

Thanks @entusdictus for catching that.  Crash should be fixed.


Rustfmt yeets const param defaults

Describe the bug
Rustfmt yeets const param defaults
playground
#![feature(const_generics_defaults)]
struct Foo<const N: usize = 5usize>;

fn main() {}

run cargo +nightly fmt or rustfmt or run the tool in playground etc and it gets formatted to:
#![feature(const_generics_defaults)]
struct Foo<const N: usize>;

fn main() {}

Expected behavior
it to not do this
Meta

rustfmt version: rustfmt 1.4.37-nightly (0bd2b19 2021-04-03)
From where did you install rustfmt?: playground/cargo
How do you run rustfmt: playground/cargo fmt/rustfmt

I ended up getting distracted and looking into this a bit can probably PR a fix, no idea if its the "correct" fix


[Feature] Reset reasoner

Is your feature request related to a problem? Please describe.
The function reset() of Reasoner has not been implemented yet.
https://github.com/bowen-xu/PyNARS/blob/b1142425a2af70dc76a185a70c7f6619c5376aaf/pynars/NARS/Control/Reasoner.py#L42-L44
This function is usefult when user want to restore the system to its initial state in a GUI without reopening it.
Describe the solution you'd like
Write a function to reset the system, including its memory, buffers, channels and so on.

This code will probably be closely linked to the code for #19

This code will probably be closely linked to the code for #19

Yep. They're highly related. I think this issue is prior to #19

I think this issue is prior to #19

Is it can be represented by "Load empty memory and experience"?
i think @ccrock4t 's saying is logically reasonable.

I was trying to split the problem into smaller ones. To load experience, one can choose whether to reset the system or just to accumulate the experience upon old one. When loading a "memory" file, maybe the system should be reset, but if not I don't know whether it could work.

To load experience, one can choose whether to reset the system or just to accumulate the experience upon old one. When loading a "memory" file, maybe the system should be reset, but if not I don't know whether it could work.

Oh yes, maybe I'm assuming that the "load" contains "reset" - in this aspect, you're right.
Accumulating memory is a good and novel idea for me. I think the key is combining concepts in memory.
Maybe pull request #27 can have a try, or at least it allow you run and manage multiple reasoners without run several Python program.


Consider fixing issue with "Show CLI results" button

If we fix this, it might involve finding all instances of the Show CLI results button and removing/replacing it in cases where it doesn't apply.
From Jan:
"The "Show CLI results" link/button on hidden output does not make sense in many cases.
Here for example it shows/hides the data that the query produces, nothing related to the CLI at all. This is just wrong https://www.prisma.io/docs/concepts/components/prisma-client/relation-queries#nested-reads"
Link to Slack thread: https://prisma-company.slack.com/archives/C5Z9TH6N9/p1662966003038179

👋 we're cleaning up our backlog of issues and are closing everything older than two years. If you still feel that this issue is relevant, please feel free to re-open and our team will take a look. Thank you!


MicroKernel does not work with inline HAL for VMVX

What happened?
Microkernel currently does not work with inline HAL for VMVX, though it works okay for regular HAL. Hope to get this feature added.
Steps to reproduce your issue

Build IREE

Inline HAL compile with microkernel enabled
path/to/iree_compiler/install/bin/iree-compile --iree-input-type=mhlo --iree-hal-target-backends=vmvx-inline --iree-execution-model=inline-static --iree-vmvx-enable-microkernels path/to/iree/samples/static_library/simple_mul.mlir  -o /tmp/simple_mul.vmfb

See error
error: failed to legalize operation 'util.buffer.subspan' that was explicitly marked illegal ...

What component(s) does this issue relate to?
Compiler
Version information
IREE ToT
Additional context
No response

@bjacob @benvanik FYI

Going to need @benvanik for this one :-) this is the first I hear about the "inline HAL" and the issue description states it's specific to that.

Probably an unhandled case in compiler/src/iree/compiler/Dialect/Util/Transforms/PropagateSubranges.cpp

An IR dump before that pass runs may help spot the issue (-mlir-print-ir-before=iree-util-propagate-subranges).

Thank you. We will take a deeper look with the debug flag and see if we can spot where the problem is.

It looks like ukernel buffer-level pass creates another layer of vmvx mul op that failed to be rendered with inline HAL.
https://github.com/iree-org/iree/blob/077168f6c8b2bff9eda724f7d2a764c909d8458c/compiler/src/iree/compiler/Codegen/LLVMCPU/Passes.cpp#L451-L454
// -----// IR Dump Before PropagateSubranges (iree-util-propagate-subranges) //----- //
#executable_target_vmvx_ir = #hal.executable.target<"vmvx-inline", "vmvx-ir">
#device_target_vmvx_inline = #hal.device.target<"vmvx-inline", {executable_targets = [#executable_target_vmvx_ir]}>
module attributes {hal.device.targets = [#device_target_vmvx_inline]} {
  func.func private @simple_mul_dispatch_0_generic_4(%arg0: !util.buffer, %arg1: !util.buffer, %arg2: !util.buffer, %arg3: !util.buffer, %arg4: index, %arg5: index, %arg6: index, %arg7: index, %arg8: index, %arg9: index, %arg10: index, %arg11: index, %arg12: index) {
    %c4 = arith.constant 4 : index
    %c0 = arith.constant 0 : index
    %c1 = arith.constant 1 : index
    vmvx.binary op("mul" : f32) lhs(%arg1 offset %c0 strides[%c0, %c1] : !util.buffer) rhs(%arg2 offset %c0 strides[%c0, %c1] : !util.buffer) out(%arg3 offset %c0 strides[%c0, %c1] : !util.buffer) sizes(%c1, %c4)
    return
  }
  func.func private @__dispatch_simple_mul_dispatch_0_simple_mul_dispatch_0_generic_4(%arg0: index, %arg1: !util.buffer, %arg2: !util.buffer, %arg3: !util.buffer, %arg4: index, %arg5: index, %arg6: index, %arg7: index, %arg8: index, %arg9: index) {
    %c0 = arith.constant 0 : index
    %c1 = arith.constant 1 : index
    %0 = util.null : !util.buffer
    %buffer_size = util.buffer.size %arg1 : !util.buffer
    %buffer_span = util.buffer.subspan %arg1[%arg4] : !util.buffer{%buffer_size} -> !util.buffer{%arg7}
    %buffer_size_0 = util.buffer.size %arg2 : !util.buffer
    %buffer_span_1 = util.buffer.subspan %arg2[%arg5] : !util.buffer{%buffer_size_0} -> !util.buffer{%arg8}
    %buffer_size_2 = util.buffer.size %arg3 : !util.buffer
    %buffer_span_3 = util.buffer.subspan %arg3[%arg6] : !util.buffer{%buffer_size_2} -> !util.buffer{%arg9}
    call @simple_mul_dispatch_0_generic_4(%0, %buffer_span, %buffer_span_1, %buffer_span_3, %c0, %c0, %c0, %c1, %c1, %c1, %c1, %c1, %c1) : (!util.buffer, !util.buffer, !util.buffer, !util.buffer, index, index, index, index, index, index, index, index, index) -> ()
    return
  }
  func.func @simple_mul(%arg0: !hal.buffer_view, %arg1: !hal.buffer_view) -> !hal.buffer_view attributes {iree.abi.stub} {
    %c0 = arith.constant 0 : index
    %c16 = arith.constant 16 : index
    %c4 = arith.constant 4 : index
    %c553648160_i32 = arith.constant 553648160 : i32
    %c1_i32 = arith.constant 1 : i32
    hal_inline.buffer_view.assert<%arg0 : !hal.buffer_view> message("tensor") shape([%c4]) type(%c553648160_i32) encoding(%c1_i32)
    %buffer = hal_inline.buffer_view.buffer<%arg0 : !hal.buffer_view> : !hal.buffer
    hal_inline.buffer_view.assert<%arg1 : !hal.buffer_view> message("tensor") shape([%c4]) type(%c553648160_i32) encoding(%c1_i32)
    %buffer_0 = hal_inline.buffer_view.buffer<%arg1 : !hal.buffer_view> : !hal.buffer
    %c64 = arith.constant 64 : index
    %buffer_1, %storage = hal_inline.buffer.allocate alignment(%c64) : !hal.buffer{%c16} in !util.buffer
    %storage_2 = hal_inline.buffer.storage<%buffer : !hal.buffer> : !util.buffer
    %length = hal_inline.buffer.length<%buffer : !hal.buffer> : index
    %storage_3 = hal_inline.buffer.storage<%buffer_0 : !hal.buffer> : !util.buffer
    %length_4 = hal_inline.buffer.length<%buffer_0 : !hal.buffer> : index
    call @__dispatch_simple_mul_dispatch_0_simple_mul_dispatch_0_generic_4(%c4, %storage_2, %storage_3, %storage, %c0, %c0, %c0, %c16, %c16, %c16) : (index, !util.buffer, !util.buffer, !util.buffer, index, index, index, index, index, index) -> ()
    %c0_i64 = arith.constant 0 : i64
    %c4_5 = arith.constant 4 : index
    %c0_6 = arith.constant 0 : index
    %c553648160_i32_7 = arith.constant 553648160 : i32
    %c1_i32_8 = arith.constant 1 : i32
    %view = hal_inline.buffer_view.create buffer(%buffer_1 : !hal.buffer)[%c0_6, %c16] shape([%c4_5]) type(%c553648160_i32_7) encoding(%c1_i32_8) : !hal.buffer_view
    return %view : !hal.buffer_view
  }
}
...

Whereas --iree-vmvx-enable-microkernels-decompose-linalg-generic uses linalg.generic and render the IR at the same pass into scf.for loop.
https://github.com/iree-org/iree/blob/077168f6c8b2bff9eda724f7d2a764c909d8458c/compiler/src/iree/compiler/Codegen/LLVMCPU/Passes.cpp#L434-L440
// -----// IR Dump Before PropagateSubranges (iree-util-propagate-subranges) //----- //
#executable_target_vmvx_ir = #hal.executable.target<"vmvx-inline", "vmvx-ir">
#device_target_vmvx_inline = #hal.device.target<"vmvx-inline", {executable_targets = [#executable_target_vmvx_ir]}>
module attributes {hal.device.targets = [#device_target_vmvx_inline]} {
  func.func private @simple_mul_dispatch_0_generic_4(%arg0: !util.buffer, %arg1: !util.buffer, %arg2: !util.buffer, %arg3: !util.buffer, %arg4: index, %arg5: index, %arg6: index, %arg7: index, %arg8: index, %arg9: index, %arg10: index, %arg11: index, %arg12: index) {
    %c1 = arith.constant 1 : index
    %c4 = arith.constant 4 : index
    %c0 = arith.constant 0 : index
    %buffer_size = util.buffer.size %arg1 : !util.buffer
    %buffer_size_0 = util.buffer.size %arg2 : !util.buffer
    %buffer_size_1 = util.buffer.size %arg3 : !util.buffer
    scf.for %arg13 = %c0 to %c4 step %c1 {
      %0 = arith.muli %arg13, %c4 : index
      %1 = util.buffer.load %arg1[%0] : !util.buffer{%buffer_size} -> f32
      %2 = util.buffer.load %arg2[%0] : !util.buffer{%buffer_size_0} -> f32
      %3 = arith.mulf %1, %2 : f32
      util.buffer.store %3, %arg3[%0] : f32 -> !util.buffer{%buffer_size_1}
    }
    return
  }
  func.func private @__dispatch_simple_mul_dispatch_0_simple_mul_dispatch_0_generic_4(%arg0: index, %arg1: !util.buffer, %arg2: !util.buffer, %arg3: !util.buffer, %arg4: index, %arg5: index, %arg6: index, %arg7: index, %arg8: index, %arg9: index) {
    %c0 = arith.constant 0 : index
    %c1 = arith.constant 1 : index
    %0 = util.null : !util.buffer
    %buffer_size = util.buffer.size %arg1 : !util.buffer
    %buffer_span = util.buffer.subspan %arg1[%arg4] : !util.buffer{%buffer_size} -> !util.buffer{%arg7}
    %buffer_size_0 = util.buffer.size %arg2 : !util.buffer
    %buffer_span_1 = util.buffer.subspan %arg2[%arg5] : !util.buffer{%buffer_size_0} -> !util.buffer{%arg8}
    %buffer_size_2 = util.buffer.size %arg3 : !util.buffer
    %buffer_span_3 = util.buffer.subspan %arg3[%arg6] : !util.buffer{%buffer_size_2} -> !util.buffer{%arg9}
    call @simple_mul_dispatch_0_generic_4(%0, %buffer_span, %buffer_span_1, %buffer_span_3, %c0, %c0, %c0, %c1, %c1, %c1, %c1, %c1, %c1) : (!util.buffer, !util.buffer, !util.buffer, !util.buffer, index, index, index, index, index, index, index, index, index) -> ()
    return
  }
  func.func @simple_mul(%arg0: !hal.buffer_view, %arg1: !hal.buffer_view) -> !hal.buffer_view attributes {iree.abi.stub} {
    %c0 = arith.constant 0 : index
    %c16 = arith.constant 16 : index
    %c4 = arith.constant 4 : index
    %c553648160_i32 = arith.constant 553648160 : i32
    %c1_i32 = arith.constant 1 : i32
    hal_inline.buffer_view.assert<%arg0 : !hal.buffer_view> message("tensor") shape([%c4]) type(%c553648160_i32) encoding(%c1_i32)
    %buffer = hal_inline.buffer_view.buffer<%arg0 : !hal.buffer_view> : !hal.buffer
    hal_inline.buffer_view.assert<%arg1 : !hal.buffer_view> message("tensor") shape([%c4]) type(%c553648160_i32) encoding(%c1_i32)
    %buffer_0 = hal_inline.buffer_view.buffer<%arg1 : !hal.buffer_view> : !hal.buffer
    %c64 = arith.constant 64 : index
    %buffer_1, %storage = hal_inline.buffer.allocate alignment(%c64) : !hal.buffer{%c16} in !util.buffer
    %storage_2 = hal_inline.buffer.storage<%buffer : !hal.buffer> : !util.buffer
    %length = hal_inline.buffer.length<%buffer : !hal.buffer> : index
    %storage_3 = hal_inline.buffer.storage<%buffer_0 : !hal.buffer> : !util.buffer
    %length_4 = hal_inline.buffer.length<%buffer_0 : !hal.buffer> : index
    call @__dispatch_simple_mul_dispatch_0_simple_mul_dispatch_0_generic_4(%c4, %storage_2, %storage_3, %storage, %c0, %c0, %c0, %c16, %c16, %c16) : (index, !util.buffer, !util.buffer, !util.buffer, index, index, index, index, index, index) -> ()
    %c0_i64 = arith.constant 0 : i64
    %c4_5 = arith.constant 4 : index
    %c0_6 = arith.constant 0 : index
    %c553648160_i32_7 = arith.constant 553648160 : i32
    %c1_i32_8 = arith.constant 1 : i32
    %view = hal_inline.buffer_view.create buffer(%buffer_1 : !hal.buffer)[%c0_6, %c16] shape([%c4_5]) type(%c553648160_i32_7) encoding(%c1_i32_8) : !hal.buffer_view
    return %view : !hal.buffer_view
  }
}
...

See the debug flag IR dump at https://gist.github.com/hcindyl/9bc6d8a2cee08037af805298e342b4d3. The difference starts at L59 with
func.func private @simple_mul_dispatch_0_generic_4(%arg0: !util.buffer, %arg1: !util.buffer, %arg2: !util.buffer, %arg3: !util.buffer, %arg4: index, %arg5: index, %arg6: index, %arg7: index, %arg8: index, %arg9: index, %arg10: index, %arg11: index, %arg12: index) {
    %c4 = arith.constant 4 : index
    %c0 = arith.constant 0 : index
    %c1 = arith.constant 1 : index
    vmvx.binary op("mul" : f32) lhs(%arg1 offset %c0 strides[%c0, %c1] : !util.buffer) rhs(%arg2 offset %c0 strides[%c0, %c1] : !util.buffer) out(%arg3 offset %c0 strides[%c0, %c1] : !util.buffer) sizes(%c1, %c4)
    return
  }

@bjacob Is related to the problem in which we tried to solve about the order between assigning the buffer and op?

--iree-vmvx-enable-microkernels-decompose-linalg-generic is not relevant here. Also, it defaults to true, so passing this flag does not make a difference, unless you add  =false.
I took a look and it does look like what @benvanik is suggesting in https://github.com/iree-org/iree/issues/11027#issuecomment-1320408512 above. If that helps, here is my print-after-all dump: https://gist.github.com/bjacob/96ee5b878ca0a3e251c304a2445f6230
The util.buffer.subspan are created by InlineExecutables (iree-hal-inline-executables) and they are not rewritten by PropagateSubranges.
I'm 100% unfamiliar with vmvx-inline (I didn't know about it prior to this Issue), with util.buffer.subspan, and with PropagateSubranges.

--iree-vmvx-enable-microkernels-decompose-linalg-generic is not relevant here. Also, it defaults to true, so passing this flag does not make a difference, unless you add =false.

Yes the default is set to be true. What I meant in https://github.com/iree-org/iree/issues/11027#issuecomment-1322981636 was that if I only set --iree-vmvx-enable-microkernels-decompose-linalg-generic but not --iree-vmvx-enable-microkernels, no vm.binary op ("mul": f32) would be added and the subrange could be expanded correctly.
I am not sure how to expand compiler/src/iree/compiler/Dialect/Util/Transforms/PropagateSubranges.cpp to add support for the op like this. The existing functionality does not cover vm binary IRs.

I took a look and it does look like what @benvanik is suggesting in #11027 (comment) above. If that helps, here is my print-after-all dump: https://gist.github.com/bjacob/96ee5b878ca0a3e251c304a2445f6230
The util.buffer.subspan are created by InlineExecutables (iree-hal-inline-executables) and they are not rewritten by PropagateSubranges.
I'm 100% unfamiliar with vmvx-inline (I didn't know about it prior to this Issue), with util.buffer.subspan, and with PropagateSubranges.

I'll see if I can't get the base interface in ~tomorrow - I'll leave adding it to the VMVX ops for someone else to pick up.

Interface added in #11340 - someone can then implement that on the VMVX ops and things should work!

Yes the default is set to be true. What I meant in https://github.com/iree-org/iree/issues/11027#issuecomment-1322981636 was that if I only set --iree-vmvx-enable-microkernels-decompose-linalg-generic but not --iree-vmvx-enable-microkernels, no vm.binary op ("mul": f32) would be added and the subrange could be expanded correctly.

That's normal:  --iree-vmvx-enable-microkernels-decompose-linalg-generic does not have any effect on its own unless --iree-vmvx-enable-microkernels is passed. So all you observed here was that if you don't pass --iree-vmvx-enable-microkernels then you don't reproduce the problem.


🐛 BUG: SSLV3_ALERT_CERTIFICATE_UNKNOWN

Which Cloudflare product(s) does this pertain to?
Wrangler core
What version(s) of the tool(s) are you using?
0.0.0-a986f19f [Wrangler]
What version of Node are you using?
19.5.0
What operating system are you using?
WSL
Describe the Bug
Error when use https after clear cache
Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
ubuntu@Optiplex:/mnt/d/code$ sudo wrangler dev --local-protocol https -l sc.js --port 443
Delegating to locally-installed<EMAIL_ADDRESS>over global<EMAIL_ADDRESS>Run `npx wrangler dev --local-protocol https -l src/v3.1.js --port 443` to use the local version directly.

 ⛅ wrangler 0.0.0-a986f19f
---------------------------
wrangler dev now uses local mode by default, powered by 🔥 Miniflare and 👷 workerd.
To run an edge preview session for your Worker, use wrangler dev --remote
▲ [WARNING] --local is no longer required and will be removed in a future version.

  `wrangler dev` now uses the local Cloudflare Workers runtime by default. 🎉

⎔ Starting local server...
[mf:wrn] The latest compatibility date supported by the installed Cloudflare Workers Runtime is "2023-09-04",
but you've requested "2023-09-08". Falling back to "2023-09-04"...
[mf:inf] Ready on https://<IP_ADDRESS>:443
[mf:inf] - https://<IP_ADDRESS>:443
[mf:inf] - https://<IP_ADDRESS>:443
workerd/util/symbolizer.c++:98: warning: Not symbolizing stack traces because $LLVM_SYMBOLIZER is not set. To symbolize stack traces, set $LLVM_SYMBOLIZER to the location of the llvm-symbolizer binary. When running tests under bazel, use `--test_env=LLVM_SYMBOLIZER=<path>`.
kj/compat/tls.c++:500: error: error accepting tls connection; kj::mv(e) = kj/compat/tls.c++:72: failed: OpenSSL error; message = error:10000416:SSL routines:OPENSSL_internal:SSLV3_ALERT_CERTIFICATE_UNKNOWN
stack: /mnt/d/code/node_modules/@cloudflare/workerd-linux-64/bin/workerd@20b7830 /mnt/d/code/node_modules/@cloudflare/workerd-linux-64/bin/workerd@20c0cf0 /mnt/d/code/node_modules/@cloudflare/workerd-linux-64/bin/workerd@20c2250
kj/compat/tls.c++:500: error: error accepting tls connection; kj::mv(e) = kj/compat/tls.c++:72: failed: OpenSSL error; message = error:10000416:SSL routines:OPENSSL_internal:SSLV3_ALERT_CERTIFICATE_UNKNOWN
stack: /mnt/d/code/node_modules/@cloudflare/workerd-linux-64/bin/workerd@20b7830 /mnt/d/code/node_modules/@cloudflare/workerd-linux-64/bin/workerd@20c0cf0 /mnt/d/code/node_modules/@cloudflare/workerd-linux-64/bin/workerd@20c2250
GET : https://localhost.dev/

Hi @anasfanani - sorry we didn't get to look at this issue earlier. Is it still a problem for you?
It is difficult to work out what might be the problem. Are you trying to use your own certificates for the local HTTPS server?
Could you please provide a reproduction that we could debug?

Hi @anasfanani :) we haven't heard from you in a while, so we’re going to close this issue for now. if this is still a problem, please feel free to open a new issue referencing this one. please be sure to include an updated summary and any additional details and a repro and we will revisit and investigate further. thanks!

@petebacondarwin
I'm not the OP, but I'm having this same problem. I'm on Windows (not WSL), and I get this error any time I wrangler dev:
X [ERROR] kj/compat/tls.c++:500: error: error accepting tls connection; kj::mv(e) = kj/compat/tls.c++:72: failed: OpenSSL error; message = error:10000416:SSL routines:OPENSSL_internal:SSLV3_ALERT_CERTIFICATE_UNKNOWN

It's probably the local_protocol = "https" configuration in wrangler.toml.

@quisido - could you check a few things:

does turning off local_protocol = "https" stop the error?
what version of Wrangler and Node are you using?

Great question. Removing local_protocol did not stop the error.
Wrangler is 3.17.1, I believe.
Node is v21.1.0.

Hmm... OK. So I think we will need a bit more help with a reproduction that we can dig into. Any chance you could create a minimal Worker project that has this problem that I can try out locally?

@quisido we haven't heard from you so we’re going to close this issue for now, but if this is still a problem, please feel free to open a new issue referencing this one. please be sure to include an updated summary and a reproduction and we'll revisit and investigate further. thanks!


Get enough countdown time for the TTS to read out all cards

I will go with the number of cards to be spoken out loud. Maybe approximately 5 seconds per card.

After testing, optimal solution is to have 5 seconds for each white card and 10 seconds for black card.


Kms changes for noobaa

KMS configuration, when provided, will be populated to Noobaa spec.
This is based on #905.

Depend on
PR https://github.com/openshift/ocs-operator/pull/961 , which updates the noobaa-operator
PR https://github.com/openshift/ocs-operator/pull/905 , which adds the KMS changes into ocs-operator

This is based on #905 (which is based on #959).
Needs to be rebased and merged after that one.
@aruniiird , @jarrpa
/hold
holding due to the dependency

/ok-to-test

rebasing does not seem to be needed, since #905 and #959 have merged without further changes

/test ocs-operator-ci

strange ci says 31/31 tests passed. but there are failures:
 2020/12/16 19:14:19 Executing pod "ocs-operator-bundle-e2e-aws-ipi-conf"
2020/12/16 19:14:24 Container cp-secret-wrapper in pod ocs-operator-bundle-e2e-aws-ipi-conf completed successfully
2020/12/16 19:14:49 Container test in pod ocs-operator-bundle-e2e-aws-ipi-conf completed successfully
2020/12/16 19:14:49 Pod ocs-operator-bundle-e2e-aws-ipi-conf succeeded after 20s
2020/12/16 19:14:58 Executing pod "ocs-operator-bundle-e2e-aws-ipi-conf-aws"
2020/12/16 19:27:54 Container cp-secret-wrapper in pod ocs-operator-bundle-e2e-aws-ipi-conf-aws completed successfully
2020/12/16 19:29:59 pod didn't start running within 15m0s:
* Container artifacts is not ready with reason PodInitializing
* Container test is not ready with reason PodInitializing
Found 20 events for Pod ocs-operator-bundle-e2e-aws-ipi-conf-aws:
* 0x : Successfully assigned ci-op-f9i504mn/ocs-operator-bundle-e2e-aws-ipi-conf-aws to ip-10-0-149-202.ec2.internal
* 1x kubelet: Failed to create pod sandbox: rpc error: code = DeadlineExceeded desc = context deadline exceeded
* 1x kubelet: Created container cp-secret-wrapper
* 1x kubelet: Started container cp-secret-wrapper
* 1x kubelet: Container image "image-registry.openshift-image-registry.svc:5000/ci-op-f9i504mn/pipeline@sha256:dbbacecc49b088458781c16f3775f2a2ec7521079034a7ba499c8b0bb7f86875" already present on machine
* 1x kubelet: Created container test
* 1x kubelet: Started container test
2020/12/16 19:30:04 pod didn't start running within 15m0s:
* Container artifacts is not ready with reason PodInitializing
* Container test is not ready with reason PodInitializing

etc.
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ocs-operator/961/pull-ci-openshift-ocs-operator-master-ocs-operator-bundle-e2e-aws/1339282115774124032

can that be a flake?

It seems like a flake, but it also seems the test didn't actually run. The 31/31 tests passed message does not refer to the actual number of things being done in the ginkgo test suite.

/test ocs-operator-bundle-e2e-aws


config.server not configured on integration test

I can't seem to get my config.server configured. When I run "jest integration" in terminal I get the following error:

config.server not configured

  at Function.<anonymous> (node_modules/dataverse-ify/src/webapi/XrmStatic.ts:26:15)
  at node_modules/dataverse-ify/lib/webapi/XrmStatic.js:8:71
  at Object.<anonymous>.__awaiter (node_modules/dataverse-ify/lib/webapi/XrmStatic.js:4:12)
  at Function.createInstance (node_modules/dataverse-ify/lib/webapi/XrmStatic.js:17:16)
  at node_modules/dataverse-ify/src/webapi/SetupGlobalContext.ts:36:39
  at node_modules/dataverse-ify/lib/webapi/SetupGlobalContext.js:8:71

My configuration is as follows:

test.yaml file is present in a config folder directly under the root directory. Am I missing a step to configure credentials?

test.yaml contains the following configuration:
nodewebapi: logging: verbose server: host: https://[my environment].dynamics.com version: 9.1
however in the dataverse-ify integration instructions it says to use this:
nodecds: server: host: https://someorg.crm11.dynamics.com version: 9.1

import { SetupGlobalContext } from "dataverse-ify/lib/webapi"; present in integration.AccountRibbon.test.ts

serviceClient set to const serviceClient = new XrmContextCdsServiceClient(Xrm.WebApi);

Ran npx node-cds-auth to get refreshToken

I tried updating the version in the test.yaml to 9.2. I also tried using a host = "https://[my environment].api.crm.dynamics.com"
Can you help me troubleshoot what I might be missing in my configuration?

Hi @kayetter - I think the issue here is that you are using node-cds-auth and the test.yaml for cdsify - but the integration test code for dataverse-ify.
I'd recommend using dataverse-ify rather that cdsify.
So you would ened to use the nodewebapi in your test.yaml, and use dataverse-auth
I've updated the docs which still had the old cdsify info which I suspect was the cause of confusion!

Old integration testing with cdsify
Integration testing with dataverse-ify

Hi @kayetter you might have got round this by now - but it seems the issue could just be as simple as there being a trailing / in your test.yaml file.
Instead of:
nodewebapi:
 server:
  host: https://org.api.crm3.dynamics.com
  version: 9.1

Use:
nodewebapi:
 server:
  host: https://org.api.crm3.dynamics.com/
  version: 9.1

I'll add an issue to make dataverse-ify more forgiving of this!

Tracked in #21


this.$gtag.event("xyz") doesn't appear to be functioning

Not sure if this is a bug or if I am not following the documentation correctly.
Description
mounted() {
this.track();
},
methods: {
track() {
this.$gtag.event("xyz");
},
},
I have the code above on the home page of my vue app, I am not seeing events being registered on google analytics when I go to the url.
Expected behavior
I expect the code above to fire a Google Analytics Event with an action of 'xyz', a default category of 'general', and a default label of '(not set)'. In addition, I expect to see this event appear on the Google Analytics Dashboard under Behavior --> Events tab.
Actual behavior
I do not see any events appear on the Google Analytics Dashboard. However, I can see navigational behaviors on the Google Analytics Dashboard.
Environment
Run this command in the project folder and fill in their results:
npm ls vue-gtag<EMAIL_ADDRESS>Then, specify:

Operating system: macOS Mojave, Version 10.14.6
Browser and version: Chrome 81

Reproducible Demo
mounted() {
this.track();
},
methods: {
track() {
this.$gtag.event("xyz");
},
},
I have the code above on the home page of my vue app, I am not seeing events being registered on the google analytics dashboard when I go to the url www.mentallyapp.co or other users go to the url.

Did you select the correct date span?
By default, Google Analytics does not display the report with an incomplete day.

@NickeManarin thanks for the update, I saw that the event was being triggered with the GTM/GA Debug chrome extension so was pretty confused. I see the event now on Google Analytics, thanks!


update to peotry as a buildsystem and update dependencies

This PR updates the buildsystem to use poetry and also updates the dependencies of the package to higher versions, including numpy 2.

We could also switch from pylint to ruff as we just also did for MS2DeepScore.
The workflow would need something like this:
      - name: Check style against standards using Ruff
        run: ruff check .

And we could add a config file ruff.toml or .ruff.toml, e.g. like this ruff.toml

We could also switch from pylint to ruff as we just also did for MS2DeepScore.
The workflow would need something like this:
      - name: Check style against standards using Ruff
        run: ruff check .

And we could add a config file ruff.toml or .ruff.toml, e.g. like this ruff.toml. In principle this should also work with something like tool.ruff in the existing toml-file.

I've referenced this in a new issue, so we can address this separately.


Add silent failure of divisibleby filter

Hi,
I understand the community guideline but this simple change did not seem significant enough to warrant a ticket.
If a field can be null and blank, having the value (which would be None) divided by a divisor would show an error, but I think it might be a good decision to make the filter fail silently by returning  an empty string.

How about {{ value|default_if_none:0|divisibleby:3 }}. I think silent failure is generally to be avoided. By the way, this isn't something that qualifies for changing without a ticket.


Serious mobile view problems - near 0 editing space

The buttons and the toolbars are too big, The editor is useless for mobile apps and sites. You must find another solution. The current solution is OK for desktop and tablets
And another problem... the android selection prompt do not disappear after selection... see the red circle form screenshot.

Visiting your website 5.2 inch phone  - No real space to edit

And another screenshot from a larger phone 6.7 inch

You must add an icon version for font type, font size, paragraph and use only ONE toolbar with a popup button  - toolbox  for the rest of buttons may be something like this:

another solution from CKEditor

or even better look at Microsoft word for mobile/desktop that combine tabs and toolbars. I think that is the best solution (elegant, professional, space saving) for mobile, desktop, and the inline editor when you want more buttons/options.

I hope that the next version will be usable for mobile apps / websites. On the other hand excepting this bug (prompt bug) and design problems ... you have done a very good job.
Thank you in advance,
Paul

Hi, @vanillamasonry
Thank you for your interest in this project!

Focus:
The editor's cursor disappears only when the editor loses focus.
It is a bad practice to lose focus whenever the editor clicks a button on the toolbar.
And whenever the editor loses focus, the input area at the bottom will disappear.
As a result, each time the button on the toolbar is clicked, the input area at the bottom disappears and reappears.
This is a bad experience for the user.

Toolbar buttons:
I agree with your opinion.
Currently you can define a container plugin, but it is very lacking.
In the next version, I'll improve the responsive and button layout.

Thank you.

Dear Lee,
First of all I want to thank you for your fast reply and taking in consideration my suggestion and clarifying the Focus issue.
On the hand I have setup the editor in one application and after
creating -> editing -> deleting (destroy +null)  -> creating again with the saved content I get the following problem (error):

Beautifying the suneditor.min.js and tracking down the error I have found that
( no d.history.push(!1) in the else statement )  is causing the error
setContents: function(t) {
const n = this.convertContentsForEditor(t);
if (this._resetComponents(), d._variable.isCodeView) {
const e = this.convertHTMLForCodeView(n);
d._setCodeView(e)
} else e.element.wysiwyg.innerHTML = n, d.history.push(!1) <- HERE
},
removing  ", d.history.push(!1)" from the else statement, the loading, creation editing etc... was working without any errors. I have no idea  what "d.history.push(!1)" is doing and I am wondering if is OK to delete it
I hope that you will have time to review also this problem for the next release.
Thank you,
Paul

The 2.30.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


Add new Gulp task - Send emails to Litmus

It would be awesome if we have a Gulp task that would send emails to Litmus once built to test cross-browser. There is already an NPM module we can use:
https://www.npmjs.com/package/gulp-litmus

Hey @m-bodmer great suggestion! I will try and get this added over the next couple of days. cheers!

Awesome, if you'd like I can try adding it in as well.


Add test to truffle-migrate example #767

Add test for truffle-migrate example

@jcarpanelli I think this PR is good to merge, WDYT?


Feature: sidebar page has auto-tag button

Note current tags.
Take tags from title.
Take tags from content, if possible.
Take tags from preview?
Save all as tags.

Content keywords should be optional with a warning that it might take some time and use up some bandwidth.
Get website keywords SEO somehow? Alternatively, parse the page's entire content and get the three most common words.

Get  if available.

Keywords should be stored precisely but filtering should be insensitive.

Remove common words eg. "has", "and", "when".

Ok, new sequence.

Connect to page.
If 404, mark link as broken and move on. Do not search.
If 301 or 302, mark link as moved and move on. Do not follow.
If 200 or 204, parse out meta keywords and move on. If no meta keywords found...
Parse entire content, take 10 most common words, move on.

If no meta keywords, try meta description. That's less good.

If content searching, clip out Javascript and CSS. We don't need to look at those.

Some websites (eg. BBC) do stuff like this:
<meta data-rh="[true]()" name="[description]()" content="[Samira Ahmed assesses the legacy of decency campaigner, whose name became a byword for prudery and censorship.]()"/><
:|


Labels are not visible in organisation issue overview or user issue overview

Gogs version (or commit ref): <IP_ADDRESS>1
Git version: 2.1.5
Operating system: Debian 8
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[x] Yes (provide example URL) (needs login)
[ ] No
[ ] Not relevant

Log gist:

Description
See attached screenshots.

Because it is just impossible or will be a mess to show all labels from all repos from all related repositories. This is by design!

Great!