Grammar railroad diagram

If you change the EBNF used to describe the grammar by the one understood by https://www.bottlecaps.de/rr/ui (see bellow) you can get a nice navigable railroad diagram for it.
Noticed that the EBNF shown bellow came from a copy/paste/format/cleanup from https://logtalk.org/manuals/refman/grammar.html and there was several dubious rules that I used my judgement to fix then.
//
// EBNF to be viewd at https://www.bottlecaps.de/rr/ui
//
// Copy and paste this at https://www.bottlecaps.de/rr/ui in the 'Edit Grammar' tab
// then click the 'View Diagram' tab.
//

//Grammar
//The Logtalk grammar is here described using Backus-Naur Form syntax. Non-terminal symbols in italics have the definition found in the ISO Prolog Core standard. Terminal symbols are represented in a fixed width font and between double-quotes.

//Entities
entity ::=
	object
	|category
	|protocol

//Object definition
object ::=
	begin_object_directive object_terms? end_object_directive

begin_object_directive ::=
	":- object(" object_identifier ( "," object_relations )? ")."

end_object_directive ::=
	":- end_object."

object_relations ::=
	prototype_relations
	|non_prototype_relations

prototype_relations ::=
	prototype_relation
	|prototype_relation "," prototype_relations

prototype_relation ::=
	implements_protocols
	|imports_categories
	|extends_objects

non_prototype_relations ::=
	non_prototype_relation
	|non_prototype_relation "," non_prototype_relations

non_prototype_relation ::=
	implements_protocols
	|imports_categories
	|instantiates_classes
	|specializes_classes

//Category definition
category ::=
	begin_category_directive  category_terms? end_category_directive

begin_category_directive ::=
	":- category(" category_identifier ( "," category_relations )? ")."

end_category_directive ::=
	":- end_category."

category_relations ::=
	category_relation
	|category_relation "," category_relations

category_relation ::=
	implements_protocols
	|extends_categories
	|complements_objects

//Protocol definition
protocol ::=
	begin_protocol_directive  protocol_directives? end_protocol_directive

begin_protocol_directive ::=
	":- protocol(" protocol_identifier ( "," extends_protocols)? ")."

end_protocol_directive ::=
	":- end_protocol."

	|":- set_logtalk_flag(" atom "," nonvar ")."
	|":- include(" source_file_name ")."

//Prolog directives
//Conditional compilation directives
conditional_compilation_directives ::=
	conditional_compilation_directive
	|conditional_compilation_directive conditional_compilation_directives

conditional_compilation_directive ::=
	":- if(" callable ")."
	|":- elif(" callable ")."
	|":- else."
	|":- endif."

//Object directives
object_directives ::=
	object_directive
	|object_directive object_directives

object_directive ::=
	":- initialization(" callable ")."
	|":- built_in."
	|":- threaded."
	|":- dynamic."
	|":- info(" entity_info_list ")."
	|":- set_logtalk_flag(" atom "," nonvar ")."
	|":- include(" source_file_name ")."
	|":- uses(" object_alias_list ")."
	|predicate_directives

//Category directives
category_directives ::=
	category_directive
	|category_directive category_directives

category_directive ::=
	":- built_in."
	|":- dynamic."
	|":- info(" entity_info_list ")."
	|":- set_logtalk_flag(" atom "," nonvar ")."
	|":- include(" source_file_name ")."
	|":- uses(" object_alias_list ")."
	|predicate_directives

//Protocol directives
protocol_directives ::=
	protocol_directive
	|protocol_directive protocol_directives

protocol_directive ::=
	":- built_in."
	|":- dynamic."
	|":- info(" entity_info_list ")."
	|":- set_logtalk_flag(" atom "," nonvar ")."
	|":- include(" source_file_name ")."
	|predicate_directives

//Predicate directives
predicate_directives ::=
	predicate_directive
	|predicate_directive predicate_directives

predicate_directive ::=
	alias_directive
	|synchronized_directive
	|uses_directive
	|use_module_directive
	|scope_directive
	|mode_directive
	|meta_predicate_directive
	|meta_non_terminal_directive
	|info_directive
	|dynamic_directive
	|discontiguous_directive
	|multifile_directive
	|coinductive_directive
	|operator_directive

alias_directive ::=
	":- alias(" entity_identifier "," predicate_indicator_alias_list
	| non_terminal_indicator_alias_list ")."

synchronized_directive ::=
	":- synchronized(" predicate_indicator_term
	| non_terminal_indicator_term ")."

uses_directive ::=
	":- uses(" object_identifier
	| parameter_variable "," predicate_indicator_alias_list
	| non_terminal_indicator_alias_list
	| operator_list ")."

use_module_directive ::=
	":- use_module(" module_identifier
	| parameter_variable "," module_predicate_indicator_alias_list
	| module_non_terminal_indicator_alias_list
	| operator_list ")."

scope_directive ::=
	":- public(" predicate_indicator_term
	| non_terminal_indicator_term ")."
	|":- protected(" predicate_indicator_term
	| non_terminal_indicator_term ")."
	|":- private(" predicate_indicator_term
	| non_terminal_indicator_term ")."

mode_directive ::=
	":- mode(" predicate_mode_term
	| non_terminal_mode_term "," number_of_proofs ")."

meta_predicate_directive ::=
	":- meta_predicate(" meta_predicate_template_term ")."

meta_non_terminal_directive ::=
	":- meta_non_terminal(" meta_non_terminal_template_term ")."

info_directive ::=
	":- info(" predicate_indicator
	| non_terminal_indicator "," predicate_info_list ")."

dynamic_directive ::=
	":- dynamic(" qualified_predicate_indicator_term
	| qualified_non_terminal_indicator_term ")."

discontiguous_directive ::=
	":- discontiguous(" predicate_indicator_term
	|non_terminal_indicator_term ")."

multifile_directive ::=
	":- multifile(" qualified_predicate_indicator_term
	|qualified_non_terminal_indicator_term ")."

coinductive_directive ::=
	":- coinductive(" predicate_indicator_term
	|coinductive_predicate_template_term ")."

parameter_variable ::=
	_variable_

entity_resources_list ::=
	predicate_indicator_list
	|operator_list

predicate_indicator_term ::=
	predicate_indicator
	|predicate_indicator_sequence
	|predicate_indicator_list

predicate_indicator_sequence ::=
	predicate_indicator
	|predicate_indicator "," predicate_indicator_sequence

predicate_indicator_list ::=
	"[" predicate_indicator_sequence "]"

qualified_predicate_indicator_term ::=
	qualified_predicate_indicator
	|qualified_predicate_indicator_sequence
	|qualified_predicate_indicator_list

qualified_predicate_indicator_sequence ::=
	qualified_predicate_indicator
	|qualified_predicate_indicator "," qualified_predicate_indicator_sequence

qualified_predicate_indicator_list ::=
	"[" qualified_predicate_indicator_sequence "]"

qualified_predicate_indicator ::=
	predicate_indicator
	|object_identifier "::" predicate_indicator
	|category_identifier "::" predicate_indicator
	|module_identifier ":" predicate_indicator

predicate_indicator_alias ::=
	predicate_indicator
	|predicate_indicator "as" predicate_indicator
	|predicate_indicator "::" predicate_indicator

predicate_indicator_alias_sequence ::=
	predicate_indicator_alias
	|predicate_indicator_alias "," predicate_indicator_alias_sequence

predicate_indicator_alias_list ::=
	"[" predicate_indicator_alias_sequence "]"

predicate_template_alias ::=
	callable "as" callable
	|callable "::" callable

predicate_template_alias_sequence ::=
	predicate_template_alias
	|predicate_template_alias "," predicate_template_alias_sequence

predicate_template_alias_list ::=
	"[" predicate_template_alias_sequence "]"

module_predicate_indicator_alias ::=
	predicate_indicator
	|predicate_indicator "as" predicate_indicator
	|predicate_indicator ":" predicate_indicator

module_predicate_indicator_alias_sequence ::=
	module_predicate_indicator_alias
	|module_predicate_indicator_alias "," module_predicate_indicator_alias_sequence

module_predicate_indicator_alias_list ::=
	"[" module_predicate_indicator_alias_sequence "]"

module_non_terminal_indicator_alias ::=
	non_terminal_indicator
	|non_terminal_indicator "as" non_terminal_indicator
	| non_terminal_indicator ":" non_terminal_indicator

module_non_terminal_indicator_alias_sequence ::=
	module_non_terminal_indicator_alias
	|module_non_terminal_indicator_alias "," module_non_terminal_indicator_alias_sequence

module_non_terminal_indicator_alias_list ::=
	"[" module_non_terminal_indicator_alias_sequence "]"

non_terminal_indicator_term ::=
	non_terminal_indicator
	|non_terminal_indicator_sequence
	|non_terminal_indicator_list

non_terminal_indicator_sequence ::=
	non_terminal_indicator
	|non_terminal_indicator "," non_terminal_indicator_sequence

non_terminal_indicator_list ::=
	"[" non_terminal_indicator_sequence "]"

non_terminal_indicator ::=
	functor "//" arity

qualified_non_terminal_indicator_term ::=
	qualified_non_terminal_indicator
	|qualified_non_terminal_indicator_sequence
	|qualified_non_terminal_indicator_list

qualified_non_terminal_indicator_sequence ::=
	qualified_non_terminal_indicator
	|qualified_non_terminal_indicator ", " qualified_non_terminal_indicator_sequence

qualified_non_terminal_indicator_list ::=
	"[" qualified_non_terminal_indicator_sequence "]"

qualified_non_terminal_indicator ::=
	non_terminal_indicator
	|object_identifier "::" non_terminal_indicator
	|category_identifier "::" non_terminal_indicator
	|module_identifier ":" non_terminal_indicator

non_terminal_indicator_alias ::=
	non_terminal_indicator
	|non_terminal_indicator "as" non_terminal_indicator
	| non_terminal_indicator "::" non_terminal_indicator

non_terminal_indicator_alias_sequence ::=
	non_terminal_indicator_alias
	|non_terminal_indicator_alias "," non_terminal_indicator_alias_sequence

non_terminal_indicator_alias_list ::=
	"[" non_terminal_indicator_alias_sequence "]"

operator_sequence ::=
	operator specification
	|operator specification "," operator_sequence

operator_list ::=
	"[" operator_sequence "]"

coinductive_predicate_template_term ::=
	coinductive_predicate_template
	|coinductive_predicate_template_sequence
	|coinductive_predicate_template_list

coinductive_predicate_template_sequence ::=
	coinductive_predicate_template
	|coinductive_predicate_template "," coinductive_predicate_template_sequence

coinductive_predicate_template_list ::=
	"[" coinductive_predicate_template_sequence "]"

coinductive_predicate_template ::=
	atom "(" coinductive_mode_terms ")"

coinductive_mode_terms ::=
	coinductive_mode_term
	|coinductive_mode_terms "," coinductive_mode_terms

coinductive_mode_term ::=
	"+"
	| "-"

predicate_mode_term ::=
	atom "(" mode_terms ")"

non_terminal_mode_term ::=
	atom "(" mode_terms ")"

mode_terms ::=
	mode_term
	|mode_term "," mode_terms

mode_term ::=
	"@"  type?
	| "+" type?
	| "-" type?
	| "?" type?
	|"++" type?
	| "--" type?

type ::=
	prolog_type | logtalk_type | user_defined_type

prolog_type ::=
	"term"
	| "nonvar"
	| "var"
	|"compound"
	| "ground"
	| "callable"
	| "list"
	|"atomic"
	| "atom"
	|"number"
	| "integer"
	| "float"

logtalk_type ::=
	"object"
	| "category"
	| "protocol"
	|"event"

user_defined_type ::=
	atom
	|compound

number_of_proofs ::=
	"zero"
	| "zero_or_one"
	| "zero_or_more"
	| "one"
	|"one_or_more"
	| "zero_or_error"
	| "one_or_error"
	|"zero_or_one_or_error"
	| "error"

meta_predicate_template_term ::=
	meta_predicate_template
	|meta_predicate_template_sequence
	|meta_predicate_template_list

meta_predicate_template_sequence ::=
	meta_predicate_template
	|meta_predicate_template "," meta_predicate_template_sequence

meta_predicate_template_list ::=
	"[" meta_predicate_template_sequence "]"

meta_predicate_template ::=
	object_identifier "::" atom "(" meta_predicate_specifiers ")"
	|category_identifier "::" atom "(" meta_predicate_specifiers ")"
	|atom "(" meta_predicate_specifiers ")"

meta_predicate_specifiers ::=
	meta_predicate_specifier
	|meta_predicate_specifier "," meta_predicate_specifiers

meta_predicate_specifier ::=
	non-negative integer
	| "::"
	| "^"
	|"*"

meta_non_terminal_template_term ::=
	meta_predicate_template_term

entity_info_list ::=
	"[]"
	|"[" entity_info_item "is" nonvar "|" entity_info_list "]"

entity_info_item ::=
	"comment"
	| "remarks"
	|"author"
	| "version"
	| "date"
	|"copyright"
	| "license"
	|"parameters"
	| "parnames"
	|"see_also"
	|atom

predicate_info_list ::=
	"[]"
	|"[" predicate_info_item "is" nonvar "|" predicate_info_list "]"

predicate_info_item ::=
	"comment"
	| "remarks"
	|"arguments"
	| "argnames"
	|"redefinition"
	| "allocation"
	|"examples"
	| "exceptions"
	|atom

object_alias ::=
	object_identifier "as" object_identifier

object_alias_sequence ::=
	object_alias
	|object_alias "," object_alias_sequence

object_alias_list ::=
	"[" object_alias_sequence "]"

//Clauses and goals
clause ::=
	object_identifier "::" head ":-" body
	|module_identifier ":" head ":-" body
	|head ":-" body
	|fact

goal ::=
	message_sending
	|super_call
	|external_call
	|context_switching_call
	|callable

message_sending ::=
	message_to_object
	|message_delegation
	|message_to_self

message_to_object ::=
	receiver "::" messages

message_delegation ::=
	"[" message_to_object "]"

message_to_self ::=
	"::" messages

super_call ::=
	"^^" message

messages ::=
	message
	|"(" message "," messages ")"
	|"(" message ";" messages ")"
	|"(" message "->" messages ")"

message ::=
	callable
	|variable

receiver ::=
	"{" callable "}"
	|object_identifier
	|variable

external_call ::=
	"{" callable "}"

context_switching_call ::=
	object_identifier "<<" goal

//Lambda expressions
lambda_expression ::=
	lambda_free_variables "/" lambda_parameters ">>" callable
	|lambda_free_variables "/" callable
	|lambda_parameters ">>" callable

lambda_free_variables ::=
	"{" conjunction of variables "}"
	|"{" variable "}"
	|"{}"

lambda_parameters ::=
	list of terms
	|"[]"

//Entity properties
category_property ::=
	"static"
	|"dynamic"
	|"built_in"
	|"file(" atom ")"
	|"file(" atom "," atom ")"
	|"lines(" integer "," integer ")"
	|"events"
	|"source_data"
	|"public(" entity_resources_list ")"
	|"protected(" entity_resources_list ")"
	|"private(" entity_resources_list ")"
	|"declares(" predicate_indicator "," predicate_declaration_property_list ")"
	|"defines(" predicate_indicator "," predicate_definition_property_list ")"
	|"includes(" (predicate_indicator "," object_identifier | category_identifier "," predicate_definition_property_list ) ")"
	|"provides(" ( predicate_indicator "," object_identifier | category_identifier "," predicate_definition_property_list ) ")"
	|"alias(" predicate_indicator "," predicate_alias_property_list ")"
	|"calls(" predicate "," predicate_call_update_property_list ")"
	|"updates(" predicate "," predicate_call_update_property_list ")"
	|"number_of_clauses(" integer ")"
	|"number_of_rules(" integer ")"
	|"number_of_user_clauses(" integer ")"
	|"number_of_user_rules(" integer ")"
	|"debugging"

object_property ::=
	"static"
	|"dynamic"
	|"built_in"
	|"threaded"
	|"file(" atom ")"
	|"file(" atom "," atom ")"
	|"lines(" integer "," integer ")"
	|"context_switching_calls"
	|"dynamic_declarations"
	|"events"
	|"source_data"
	|"complements(" ("allow" | "restrict") ")"
	|"complements"
	|"public(" entity_resources_list ")"
	|"protected(" entity_resources_list ")"
	|"private(" entity_resources_list ")"
	|"declares(" predicate_indicator "," predicate_declaration_property_list ")"
	|"defines(" predicate_indicator "," predicate_definition_property_list ")"
	|"includes(" ( predicate_indicator "," object_identifier | category_identifier "," predicate_definition_property_list ) ")"
	|"provides(" ( predicate_indicator "," object_identifier | category_identifier "," predicate_definition_property_list ) ")"
	| "alias(" predicate_indicator "," predicate_alias_property_list ")"
	|"calls(" predicate "," predicate_call_update_property_list ")"
	|"updates(" predicate "," predicate_call_update_property_list ")"
	|"number_of_clauses(" integer ")"
	|"number_of_rules(" integer ")"
	|"number_of_user_clauses(" integer ")"
	| "number_of_user_rules(" integer ")"
	|"module"
	| "debugging"

protocol_property ::=
	"static"
	|"dynamic"
	|"built_in"
	|"source_data"
	|"file(" atom ")"
	|"file(" atom "," atom ")"
	|"lines(" integer "," integer ")"
	|"public(" entity_resources_list ")"
	|"protected(" entity_resources_list ")"
	|"private(" entity_resources_list ")"
	|"declares(" predicate_indicator "," predicate_declaration_property_list ")"
	|"alias(" predicate_indicator "," predicate_alias_property_list ")"
	|"debugging"

predicate_declaration_property_list ::=
	"[" predicate_declaration_property_sequence "]"

predicate_declaration_property_sequence ::=
	predicate_declaration_property
	|predicate_declaration_property "," predicate_declaration_property_sequence

predicate_declaration_property ::=
	"static"
	| "dynamic"
	|"scope(" scope ")"
	|"private"
	| "protected"
	| "public"
	|"coinductive"
	|"multifile"
	|"synchronized"
	|"meta_predicate(" meta_predicate_template ")"
	|"coinductive(" coinductive_predicate_template ")"
	|"non_terminal(" non_terminal_indicator ")"
	|"include(" atom ")"
	|"line_count(" integer ")"
	|"mode(" (predicate_mode_term | non_terminal_mode_term "," number_of_proofs) ")"
	|"info(" list ")"

predicate_definition_property_list ::=
	"[" predicate_definition_property_sequence "]"

predicate_definition_property_sequence ::=
	predicate_definition_property
	|predicate_definition_property "," predicate_definition_property_sequence

predicate_definition_property ::=
	"inline"
	| "auxiliary"
	|"non_terminal(" non_terminal_indicator ")"
	|"include(" atom ")"
	|"line_count(" integer ")"
	|"number_of_clauses(" integer ")"
	|"number_of_rules(" integer ")"

predicate_alias_property_list ::=
	"[" predicate_alias_property_sequence "]"

predicate_alias_property_sequence ::=
	predicate_alias_property
	|predicate_alias_property "," predicate_alias_property_sequence

predicate_alias_property ::=
	"for(" predicate_indicator ")"
	|"from(" entity_identifier ")"
	|"non_terminal(" non_terminal_indicator ")"
	|"include(" atom ")"
	|"line_count(" integer ")"

predicate ::=
	predicate_indicator
	|"^^" predicate_indicator
	|"::" predicate_indicator
	|variable "::" predicate_indicator
	|object_identifier "::" predicate_indicator
	|variable ":" predicate_indicator
	|module_identifier ":" predicate_indicator

predicate_call_update_property_list ::=
	"[" predicate_call_update_property_sequence "]"

predicate_call_update_property_sequence ::=
	predicate_call_update_property
	|predicate_call_update_property "," predicate_call_update_property_sequence

predicate_call_update_property ::=
	"caller(" predicate_indicator ")"
	|"include(" atom ")"
	|"line_count(" integer ")"
	|"as(" predicate_indicator ")"

//Predicate properties
predicate_property ::=
	"static"
	| "dynamic"
	|"scope(" scope ")"
	|"private"
	| "protected"
	| "public"
	|"logtalk"
	| "prolog"
	| "foreign"
	|"coinductive(" coinductive_predicate_template ")"
	|"multifile"
	|"synchronized"
	|"built_in"
	|"inline"
	|"declared_in(" entity_identifier ")"
	|"defined_in(" (object_identifier | category_identifier) ")"
	|"redefined_from(" (object_identifier | category_identifier) ")"
	|"meta_predicate(" meta_predicate_template ")"
	|"alias_of(" callable ")"
	|"alias_declared_in(" entity_identifier ")"
	|"non_terminal(" non_terminal_indicator ")"
	|"mode(" (predicate_mode_term | non_terminal_mode_term "," number_of_proofs) ")"
	|"info(" list ")"
	|"number_of_clauses(" integer ")"
	|"number_of_rules(" integer ")"
	|"declared_in(" entity_identifier "," line_count ")"
	|"defined_in(" (object_identifier | category_identifier "," line_count) ")"
	|"redefined_from(" (object_identifier | category_identifier "," line_count) ")"
	|"alias_declared_in(" entity_identifier "," line_count ")"

line_count ::=
	integer

//Compiler flags
compiler_flag ::=
	flag "(" flag_value ")"

The diagrams look really nice and useful! Thanks for your contribution! I will adapt it (with due credit). You also wrote:

Noticed that the EBNF shown bellow came from a copy/paste/format/cleanup from https://logtalk.org/manuals/refman/grammar.html and there was several dubious rules that I used my judgement to fix then.

Do you remember which rules you found dubious?

There is some . dots at the end of some rules :
object ::=
      begin_object_directive [ object_terms ] end_object_directive.
...
category ::=
    begin_category_directive [ category_terms ] end_category_directive.

And some | alternations on the middle of seems to be one rule:
...
alias_directive ::=
“:- alias(”
entity_identifier “,”
predicate_indicator_alias_list | non_terminal_indicator_alias_list
“).”
...
uses_directive ::=
“:- uses(”
object_identifier | parameter_variable “,”
predicate_indicator_alias_list | non_terminal_indicator_alias_list | operator_list
“).”
...
“provides(” predicate_indicator “,” object_identifier | category_identifier “,” predicate_definition_property_list “)”
...

And maybe straw quotes ?:
line_count ::=
integer”

And some missing quotes ?:
compiler_flag ::=
flag(flag_value)

Thanks. In the case of the alias/2, uses/2 directives (and a few others) there parenthesis missing. I'm fixing those and the typos.

Pushed a first commit with the changes:
https://github.com/LogtalkDotOrg/logtalk3/commit/06acfe54733a5b752ee0db8364255cd6d82ca2af
I still need to find how best to provide the generated diagram. Several Handbook sections link to different parts of grammar and thus the diagram cannot be included as-is.

I'm trying to adapt your grammar to use here https://mingodad.github.io/parsertl-playground/playground/ but there is this rules that are not referenced anywhere:
'category_directives' is an unused rule.
'category_identifiers' is an unused rule.
'category_property' is an unused rule.
'compiler_flag' is an unused rule.
'entity_identifiers' is an unused rule.
'goal' is an unused rule.
'lambda_expression' is an unused rule.
'non_terminal_indicator_term' is an unused rule.
'object_directives' is an unused rule.
'object_identifiers' is an unused rule.
'object_property' is an unused rule.
'predicate_indicator_alias_list' is an unused rule.
'predicate_property' is an unused rule.
'predicate_template_alias_list' is an unused rule.
'protocol_identifiers' is an unused rule.
'protocol_property' is an unused rule.
'source_file_directives' is an unused rule.
'source_file_names' is an unused rule.

There is something missing ?

Just pushed 0f19b1c711c383f41dd7781a1d7149763a947799 simplifying and removing several rules. You will still find some reported as unused as they are referenced from other Handbook sections.

Thank you !
But I'll give up for now because it doesn't describe a valid grammar as it is now.

I assume that a main issue is that Prolog non-terminals (e.g. callable or integer) are implicit defined?

Diagram published at:
https://logtalk.org/_pages/grammar_diagram.html


DevOps ADF Walkthrough Outdated

The DevOps recommended process has changed via 2/15 and announcements link to this article for walkthrough- however, it doesnt appear that the article is updated to contain the new recommended process

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e22e4d6-366f-fbf8-e141-8905ca7ab7ae
Version Independent ID: 5be2acf2-66e7-cadf-6666-5a85a65b9771
Content: Continuous integration and delivery in Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/continuous-integration-deployment.md
Service: data-factory
GitHub Login: @dcstwh
Microsoft Alias: weetok

@kyledeloitte
Thanks for the feedback! We have assigned the issue to the content author to investigate this and update the document as appropriate.

This should be covered in https://docs.microsoft.com/en-us/azure/data-factory/continuous-integration-deployment-improvements

Do verify it captures what you have in mind, and we can close this issue.
Thank you.

We are closing this issue, as the new doc has been updated.
Do reopen a new issue if this does not meet what you are looking for. Thank you.

#please-close


Improve IPAM logging info returned by AutoAssign()

Description
Improve logging output from AutoAssign() for more clarity, especially when not all requested IPs are successfully assigned, stating the reasons for it.
Add type IPAMAssignmentInfo struct to ipam.go and return v4 and v6 versions of it from autoAssign() and propagate it to AutoAssign().
Change signature AutoAssign() in interface.go, and change every call of both functions to accommodate the new return values.
IPAMAssignmentInfo has as String() method which returns a formatted log message of the success/failure/reasons of the assignment. I would appreciate feedback on the message/output, thanks.
Add IPAMAssignmentInfo verification to AutoAssign fv tests in ipam_test.go and ipam_win_test.go and add a IPAMAssignmentInfo.String() ut test case to ipam_test.go.
Also: fix a typo in a log msg in findOrClaimBlock() and make AutoAssign tests in ipam_test.go check the error obtained against the expected (instead of just expecting any error to occur).
Todos

[x] Tests
[ ] Documentation
[x] Release note

Release Note
Added enhanced error logging for IPAM failures

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/sem-approve

/sem-approve


feat: added new tweet

which file should we add the images to

Great job @akwe-afriitech thanks for your contribution.


test: useChangeEffect

Tests for hook useChangeEffect

@nytai or @ktmud Can either of you see this PR for me? Thanks!

LGTM


resolveDebugConfiguration is not passed the correct (closest) workspace folder when they are nested

If you have a WorkspaceFolder inside a WorkspaceFolder, I'm told that getWorkspaceFolder(Uri) will always return the closest one.
As such, it seems reasonable to assume other APIs behave the same. However, if I hit F5 with a file open that exists in multiple workspace roots, the debug configuration provider gets called with the top-level folder and not the closest one.
Eg.:
my_projects                   // WorkspaceFolder
  |- my_flutter_project       // WorkspaceFolder
    |- my_flutter_script.dart
  |- my_dart_project          // WorkspaceFolder
    |- my_dart_script.dart

When I press F5 with my_flutter_script.dart open, I get given the my_projects WorkspaceFolder which means I don't detect that the project is a Flutter project.

Fix looks good in Insiders to me! Is it too late/insignificant for the Feb recovery release? Solves a big issue for my users with debugging projects in sub folders; would be awesome if I could include the fix (which relies on this) in the next release.

It will be included in the march release, not for frebruary recovery since it is too risky.
Thanks for verifying

Understood; thanks for the quick response!


animations: don't ignore curves with one keyframe

Objective

While playing with animated models, I noticed some were a little off

Solution

Some animations curves only have one keyframe, they are used to set a transform to a given value
Those were ignored as we're never exactly at the ts 0.0 of an animation. going there explicitly (.set_elapsed(0.0).pause()) would crash
Special case this as there isn't much to animate in this case

bors r+


Fix velox_query_replayer linking error

A follow-up fix PR for #11360 to address the linking error:
[1432/1435] Linking CXX executable velox/tool/trace/velox_query_replayer
FAILED: velox/tool/trace/velox_query_replayer
...
Undefined symbols for architecture arm64:
  "facebook::velox::tool::trace::TraceReplayRunner::run()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "facebook::velox::tool::trace::TraceReplayRunner::init()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "facebook::velox::tool::trace::TraceReplayRunner::TraceReplayRunner()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "vtable for facebook::velox::tool::trace::TraceReplayRunner", referenced from:
      facebook::velox::tool::trace::TraceReplayRunner::~TraceReplayRunner() in TraceReplayerMain.cpp.o
   NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

ninja: build stopped: subcommand failed.
make[1]: *** [build] Error 1
make: *** [debug] Error 2

CC @xiaoxmeng

@kgpai can you please help merge this? Thanks.


[CARBONDATA-2884] Rename the methods of ByteUtil class to avoid the misuse

The method toBytes will execute XOR operation on data.
So the result is not the byte array of the real value.
Better to rename the methods of ByteUtil class to avoid the misuse

[x] Any interfaces changed?
yes,

rename the old toBytes methods to toXorBytes
new toBytes methods return the real byte array

[x] Any backward compatibility impacted?
no

[x] Document update required?
yes, added java doc

[x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
added test case
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
small changes

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6367/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/8019/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6742/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6746/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/8023/

retest dev please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6470/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6472/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/90/

retest sdv please


How do I specify generation_kwargs in python Tasks?

Hi all! I defined some new tasks from scratch purely in python by inheriting Task, e.g., https://huggingface.co/spaces/hallucinations-leaderboard/leaderboard/blob/main/src/backend/tasks/cnndm/task_v2.py#L63
How do I specify which generation_kwargs to use? I'd like to use the following ones:
generation_kwargs:
  until:
    - "\n"
    - "."
    - ","
  do_sample: false
  temperature: 0.0

I'm asking because in some cases I'm getting the following:
ValueError: `temperature` (=0.0) has to be a strictly positive float, otherwise your next token scores will be invalid. If you're looking for greedy decoding strategies, set `do_sample=False`.

Looks like you can set them in construct_requests. Pass them as a dict to index 1 of the arguments tuple.

@baberabb thanks! giving it a try
@lintangsutawika @haileyschoelkopf  shall we add this to SQuADv2 and Scrolls as well?

How does this look?
        super().__init__(config={
            'metadata': {'version': self.VERSION},
            'generation_kwargs': {
                'do_sample': False,
                'temperature': 0.0
            }
        })

This doesn't seem to work, looking into it.

Here it is:
    def __init__(self):
        # breakpoint()
        super().__init__(config={'metadata': {'version': self.VERSION},
                                 'generation_kwargs': {'do_sample': True, 'temperature': 5.0}})


Editor Crash After Spawning Blui Actor

Editor Crashes After Spawning Blui Actor.
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION 0x9a2dc100
0x00007ffa9a2dc100 libcef.dll!UnknownFunction []
0x00007ffab93f51d8 UE4Editor-Blu.dll!UnknownFunction []
0x00007ffab93fd033 UE4Editor-Blu.dll!UnknownFunction []
0x00007ffa97054986 libcef.dll!UnknownFunction []
0x00007ffa97a8131e libcef.dll!UnknownFunction []
0x00007ffa97a80695 libcef.dll!UnknownFunction []
0x00007ffa97a80c9b libcef.dll!UnknownFunction []
0x00007ffa970435fe libcef.dll!UnknownFunction []
0x00007ffab93e03dc UE4Editor-Blu.dll!UnknownFunction []
0x00007ffab93ce546 UE4Editor-Blu.dll!UnknownFunction []
0x00007ffad1db0ae4 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad20000dd UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad2023113 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad202574d UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad1ff3bea UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad2025392 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad2023113 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad202574d UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad1ff3bea UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad2025392 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad202574d UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad1ff3bea UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad2025392 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad202574d UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad2024c54 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad1db0ae4 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad2024783 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad275a025 UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad27247db UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad27302fc UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad27564f2 UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad273c59c UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad2e09d5e UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad3ad53c6 UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad204a635 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad204ce7f UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad202574d UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad2024c54 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad1db0ae4 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad2024783 UE4Editor-CoreUObject.dll!UnknownFunction []
0x00007ffad275a025 UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad2fea528 UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad2fcb57f UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad2772e28 UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad2772f8a UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad27394c4 UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad37f7e0f UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad37fce67 UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad53f87d8 UE4Editor-Core.dll!UnknownFunction []
0x00007ffad53f8aa3 UE4Editor-Core.dll!UnknownFunction []
0x00007ffad540f027 UE4Editor-Core.dll!UnknownFunction []
0x00007ffad3818e52 UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad381e11a UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad2fdbfff UE4Editor-Engine.dll!UnknownFunction []
0x00007ffad2fe6897 UE4Editor-Engine.dll!UnknownFunction []
0x00007ffacfe0af57 UE4Editor-UnrealEd.dll!UnknownFunction []
0x00007ffad06e1d06 UE4Editor-UnrealEd.dll!UnknownFunction []
0x00007ff6a9777800 UE4Editor.exe!UnknownFunction []
0x00007ff6a978ba7c UE4Editor.exe!UnknownFunction []
0x00007ff6a978bb5a UE4Editor.exe!UnknownFunction []
0x00007ff6a979e31d UE4Editor.exe!UnknownFunction []
0x00007ff6a97a145a UE4Editor.exe!UnknownFunction []
0x00007ffb359c6fd4 KERNEL32.DLL!UnknownFunction []
0x00007ffb365dcec1 ntdll.dll!UnknownFunction []

This isn't enough to go on e.g. context, examples, platform & plugin versions, and steps to reproduce needed

In UE 4.25
I created an empty blueprint project and copy your plugin to necessary location (Project's root/Plugins). I can see plugin is enabled in Plugins folder.
And dragged your example actor to viewport.
When I press to play, editor crashes.
OS is windows, target platform is desktop. Plugin version is 4.0

Did you use the ```BLUI-v4.0.0-UE4.25.7z

In UE 4.25
I created an empty blueprint project and copy your plugin to necessary location (Project's root/Plugins). I can see plugin is enabled in Plugins folder.
And dragged your example actor to viewport.
When I press to play, editor crashes.
OS is windows, target platform is desktop. Plugin version is 4.0
--
Also tried with C++ project and result is same.

This is happening to me too. UE 4.25. I used this:

Did you use the BLUI-v4.0.0-UE4.25.7z release folder from https://github.com/getnamo/BLUI/releases/tag/4.0.0? (not source code zip)

The issue was the "Web Browser" plugin. Make sure that the "Web Browser" plugin under the "Widgets" category is disabled. I think that the web browser plugin uses an older version of CEF so that might be conflicting with this plugin.

@parthnaik92  this may be a common thing people run into after experimenting with other plugins.


Broken links to "Common Data Object" section

PR #250 introduces broken links. Grep sources for regexp "common.data.objects" (case insensitive) to see problem parts.

I see that build log even contains relevant messages.
warn: page events/events.md contains an hyperlink to resource outside spine

Fixed with #273


getBoundingClientRect of null error

Hello, I really appreciate for this awesome layout tool.
But I got a some issues when I try to use 'horizontal' splitter.
If I try to resize the horizontal bar, there are Type error 'Cannot read property 'getBoundingClientRect' of null'.
This error takes place in Splitter.js. line 149, 132.
Could you check this errors?

Hello @Widus , thank you for your kind words. Can you please provide some simple demo as I am not able to reproduce this issue. Thank you

I got the same Issue (but using vertical splitter), but i'm not sure what caused it. I upgraded redux to 4.0.0, had this error and found this issue, then downgraded again and it worked fine again, then i upgraded again to see if the error would come again but now it works fine, weird ...

I got this simple Demo reproducing the error: https://codesandbox.io/s/7l1o2lk01

I know how to reproduce the error now:

Open my demo: https://codesandbox.io/s/7l1o2lk01
Change something in the code (add text for example)
See the Errors

I just released new version. Hope this issue is fixed for you

This error still exists:
Uncaught TypeError: Cannot read property 'getBoundingClientRect' of null
    at Splitter._this.getSize (Splitter.js:205)

From what I can see, this may be a problem with multiple instances of the Splitter object in one application.  For example, in my application I have two main tabs which each contain a Splitter.  I see that the Splitter.componentDidMount adds a window resize event listener, that calls _this.getSize.  It seems to me that this could cause a problem, since only the currently-rendered object should be responding to window.resize events.
And, a non-rendered Splitter object will have a null reference to its paneWrapper property -
      ref: function ref(node) {
        return _this.paneWrapper = node;
      }

@martinnov92 Have you tested this component in a case like this, with two instances of Splitter in visible and hidden parent tabs?
Thanks,
Don


Server draw lost message when "Use 32-bit vertex indices"

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

cancel annotation ‘#define ImDrawIdx unsigned int’ in imconfig.h both in netImgui and UnrealImGui.
compile this project and run.
draw over ten thousand circle in imgui.
server seem like not execute draw all circle.

Expected behavior
server behavior same like local
Screenshots

Desktop (please complete the following information):

OS: Windows
Version [netImgui 1.5]

Additional context
Thank you upgrade UnrealImGui to netImgui 1.5! I want draw meta world all entity location (count will over ten thousand). But  looks like remote server can't draw so many graphics.

Fixed in submit b1016ac.
Note 1: The server application doesn't need to be rebuilt to match your Dear Imgui Index size anymore. It now handles both 16/32bits indices.
Note 2: You don't need to compile Dear ImGui with 32bits index to handle large amount of content. ImGui automatically split large amount of vertices into multiple drawcalls (+ vertex offset)
Note 3: I added 2 samples to test this large amount of content problem (SampleIndex16, SampleIndex32). Thank you for bringing this to my attention.
Note 4: UnrealImgui's pull request has been also updated with this change. This means you should be able to get it and run with the NetImguiServer application as it, without needing to recompile it (whether you choose to use 16 or 32 bits indices).


unnecessary(?) implementation of get/setcontext on arm breaks armhf

On armhf, the test suite fails with the following error message:
sh ./tests/runtests.sh
Running unit tests:
Segmentation fault
ERROR in test tests/bstr_tests:
make[1]: *** [tests] Error 1

This is caused by the implementation of getcontext/setcontext embedded in src/task/. It's just not compatible with armhf. And it seems unnecessary even on armel, because by now these functions are implemented by the libc.
(But I only verified that on debian - not sure about other linux distributions.)
If it's true that all (relevant) linux distributions do implement these functions, I can provide a patch to disable the embedded version.

Fixed by #253


Copyright violation by republishing the HID Usage Tables?

I'm not the copyright holder, so it's not really my business, but still wondering if it is intentional. This repository distributes hut1_3_0.pdf. The document's copyright notice says:

THIS SPECIFICATION MAY NOT BE REPUBLISHED EXTERNALLY OR OTHERWISE TO THE PUBLIC.

Does Microsoft have the permission to republish it here?

At least it seems it's not possible to fork this repo without violating the license, I think as a layman (not a lawyer).

Thanks @bjanders, this does strike me as a problem and I appreciate you bringing this up.  I've reached-out to the USB-IF for their guidance, and they are still reviewing it.  I'll respond back to this thread when I hear back, and what a solution could look like.

@bjanders I've heard back from the USB-IF and they agree the PDF shouldn't be included in the repo.  I've modified the build process so it now downloads the PDF at compile-time, mitigating this problem.


ActiveJob support

Would you accept a PR that (conditionally) introduces support for ActiveJob? Something like:
  def create
    normalized_params.each do |p|
      process_email(p)
    end

    head :ok
  end

  # ...

  def process_email(params)
    if griddler_configuration.use_active_job?
      processor_class.perform_later(email) # In this case processor class must extend ActiveJob::Base
    else
      processor_class.new(Griddler::Email.new(params)).public_send(processor_method)
    end
  end

I'm asking this because currently Griddler::Email is not serializable as AJ parameter, a very quick alternative would be to make Griddler::Email#params public, in this way a user may do this
# in processor
MyJob.perform_later(email.params)

# in Job class
def perform(params)
  email = Griddler::Email.new(params)
end

But in any case it would be useless to process the email twice, once in controller and later in the job.

I think this is a good idea but if implemented I would not want to limit it to ActiveJob. We'd also need to support setting up the queue, priority, etc.

I agree about other settings, mainly queue name, but I'm reluctant to explicitly support other queue BG job processors, that's ActiveJob's job 😄
Meanwhile I've implemented this in my project using a monkey patch in this way
# in config/initializers/griddler.rb
module Griddler

  # Reopen configuration class to allow active job support
  module ConfigurationExtension

    # Enable active job support, interpret processor job class as an active job subclass
    def use_active_job!
      @active_job = true
    end

    def use_active_job?
      defined?(@active_job) ? !!@active_job : false
    end
  end

  # Prepend module to override behavior
  Configuration.prepend(ConfigurationExtension)

  # Reopen controller to change its behavior to use active job
  module EmailsControllerExtension

    def self.prepended(base)
      base.delegate :use_active_job?, to: :griddler_configuration
    end

    def create
      normalized_params.each do |p|
        process_email(p)
      end

      head :ok
    end

    def process_email(params)
      if use_active_job?
        processor_class.perform_later(params) # In this case processor class must extend ActiveJob::Base
      else
        processor_class.new(Griddler::Email.new(params)).public_send(processor_method)
      end
    end
  end

  # Prepend the module to override behavior
  EmailsController.prepend(EmailsControllerExtension)

end

# Configure griddler
Griddler.configure do |config|
  config.processor_class = EmailCommandJob
  config.use_active_job!
  config.reply_delimiter = '-- REPLY ABOVE THIS LINE --'
  config.email_service = :sendgrid
end

ActiveJob's purpose it to provide opinionated background job support for Rails.  By necessity, that means its support is sort of "lowest common denominator". Sidekiq, for instance, has a much better retry feature than that built into ActiveJob. By choosing to only support ActiveJob, downstream consumers are then forced to use that interface if they need background job support with Griddler. I'd rather not ask people to use ActiveJob just to get that feature (especially if they aren't loading it along with the rest of Rails since they are using a different job strategy).
The monkeypatch looks fine (although a refinement may be a better implementation here?). I'm not a huge fan of use_active_job? for every iteration of that loop but in the grand scheme of things oh well.

So how do people actually do this now? I definitely want to pawn off processing emails to the background

Off the top of my head:
class ActiveJobEmail < Griddler::Email
  # implement GlobalID so this class can be serialized
end

class GriddlerJob < ActiveJob::Base
  def perform(email)
    # do something with email
  end
end

Griddler.configure do |config|
  config.processor_class = GriddlerJob
  config.email_class = ActiveJobEmail
  config.processor_method = :enqueue
end

Alternatively, instead of subclassing Griddler::Email, you could override initialize in the job and convert the email to a hash prior to enqueuing it.
Note that I haven't actually tried this approach.

Depending on how much data in coming from your Email Service, it could be a little risky to pass your griddle object class straight ActiveJob. For example, if you receive 5 emails with 100mb worth of attachments you're potentially passing a lot of data around (Or losing references to temporary files).
I think a better approach is to have something like:
class GriddlerReceiver
  def initialize(email)
    @email = email
  end

  def perform(email)
    # Pass your Griddle email attributes somewhere into your database.
    griddler_email = GriddlerEmail.new
    griddler_email.attributes = email.to_h

    # If you've got your bare minimum, go off and do whatever you need to do to that emails data.
    griddler_email.save && GriddlerJob.perform_later(griddler_email)
  end
end


integration-async: improve flaky tests

Refactored most flaky test 'test_indexer_updates_authors_papers_when_name_changes' which was causing 60% of failures il last week.
Other tests also updated and refactored to be more stable.
retry_until_matched tool for tests refactored and updated to be more reliable and to return meaningful exceptions.
Added tests for retry_until_matched tool
*INSPIR-3313

I'd rather try to find a better approach than using  and extending retry_until_matched.
What about using something like https://www.elastic.co/guide/en/elasticsearch/reference/7.x/docs-refresh.html to make sure we have the results available to search https://elasticsearch-py.readthedocs.io/en/master/api.html#elasticsearch.Elasticsearch.index

From what I can see in docs this refresh has to be added in put/post sent to ES for which you want to wait. So we would have to change functions which we want to test for this. Also it wont work for all citation/references updates which is happening in celery tasks for which we made async-tests at the first place because we don't know when they will start exactly and when they will finish.

We can explore other options, such as to check the health of the cluster etc? Have we explored this kind of solutions?

Yes, nothing guarantees us results as indexing happens in few separate celery tasks. Which can be started independently, ES has nothing to it. Even if ES could index without any delay, we still have celery tasks which won't run immediately in which we are processing citations, relations etc.


Browserslist: caniuse-lite is outdated.

Problem
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme

Solution
pnpm up caniuse-lite

✔ Fixed
Commits

92a6c16: chore(libs): update tailwind lib version


use nodejs v20

Change Summary

Google map script tag is executed before the initMap is defined, which cause a blank page. Fixed by changing the script attribute from async to defer

PR Checklist

[x] I have read and signed the Contributor License Agreement.

The google map deprecation warnings is from instantsearchjs so there is nothing we can do about it.


Update Arq to 5.0.4

Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

Updated appcast checkpoint and rebased.


"Cannot find module .... or its corresponding type declarations"

Issue Type: Bug
After the recent Live Share update, my TypeScript projects are no longer recognizing imported modules and are generating errors (but only on the remote machine).

Extension version: 1.0.2666
VS Code version: Code 1.48.1 (3dd905126b34dcd4de81fa624eb3a8cbe7485f13, 2020-08-19T17:12:13.244Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
AMD Ryzen 7 2700X Eight-Core Processor          (16 x 3700)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.95GB (24.40GB free)

Process Argv
C:\Users\Will Resen\Downloads\StatPackChart_CallsByMonth.json

Screen Reader
no

VM
0%

Thanks for reporting this issue.
@aletsdelarosa can you please look at this and try to repro it?

I have a similar problem with TypeScript v3.9.7, the host doesn't get affected here too

Same with me and my friend @jazerix, who are both on the newest version of TS and LiveShare, with a clean TS project. It also happens for the one who is not hosting.

Happening with me as well :/

This is an issue with the latest version of VS Code stable - the local TypeScript extension is running on the Live Share guest. You can either revert to the previous version of VS Code stable, use VS Code Insiders (where we've since fixed the issue), or wait for the next version of VS Code stable, where this will be fixed. Sorry for the inconvenience!

@daytonellwanger That's great to hear that a fix is coming down the pipeline!

@daytonellwanger This is fixed!


Feature Request: User device detection / Meteor.isCordova check

Thanks @mizzao for this awesome package!
It would be great if there was a field under status and lastLogin for the device the user is/was using. Basically I would like to know if they are using the app or the web version (in the latter case, one could differentiate more, between different devices).

Are you talking about the userAgent field? Or you actually want to know if they are logging in from Cordova or regular browser?

I want to know whether they're logging in from Cordova or regular browser. AFAIK using the user agent string for device detection isn't always reliable?

I don't use Cordova regularly right now and can't really help with this, but would be happy to review a PR.


Dropping too large datagram (max allowed: 1336 bytes)

2024-11-12T08:46:54.191488Z DEBUG firezone_tunnel::io: Dropping too large datagram (max allowed: 1336 bytes) from=<IP_ADDRESS>:53805 len=2540
2024-11-12T08:46:54.197357Z DEBUG firezone_tunnel::io: Dropping too large datagram (max allowed: 1336 bytes) from=<IP_ADDRESS>:53805 len=2540

Saw this one in customer logs. Not sure what is happening here, we should be chopping these datagrams correctly in the case of GRO.

Interestingly, the IP is one of our relays, so somehow this happens with relayed traffic?

I am seeing only two different kind of packet sizes: 3810 and 2540. Those are both perfect multiples of 1270.
The customer that hit this said this only happens when they are connected via their Dell Dock WD19S.
Could this be a GRO issue with quinn-udp where it doesn't correctly detect that there is more than one packet in the datagram and it tries to read it as a single one?


fix: lncli description connect/disconnect peer

Change Description
Fix description of lncli connect & lncli disconnect
Steps to Test
lncli connect --help & lncli disconnect --help
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

Thanks. Can you please squash the commits into a single one, using the prefix as described in the contribution guidelines, then I can merge.


copyedit of mdash, miscellaneous

What's changed

Fixed mdash codes per user feedback

Related
Fixes #3578
Reviewers
@johndmulhausen @mstanleyjones @stbof
Signed-off-by: Victoria Bialas<EMAIL_ADDRESS>

LGTM


refactor(engine): add labware on modules geometry

Overview
Closes #8242
Changelog
Allow labware to be loaded on top of modules in Protocol Engine
Review requests

[ ] Code looks good
[ ] LPC with temperature module and magnetic module should fully work
[ ] LPC with thermocycler may have issues (ticketed as #8911)

Thermocycler closed lid height is not yet accounted for in PE movement planning (may not matter for LPC)
Moves to TC labware when lid is closed not yet rejected (may not matter for LPC, but also not good)
Moves with a lid-open TC will not attempt to dodge the TC (matters for LPC)

Risk assessment
Low, if this all works!

Tested on robot. Labware locations get updated correctly to use module parents. Labware offsets get added correctly.
@SyntaxColoring smoke tested adding labware offsets to legacy protocol run and that worked correctly as well.


Abort if the command for run fails and exit_on_failure? is true

Hi, there :rainbow:
I'd like to change the error handling of Thor::Actions#run for the following reason.
According to the description of exit_on_failure?, the process should exit with status 1 if any error happens. I think that it should be also applied to run.
Although we can pass abort_on_failure option for run, passing it every time seems a little redundant when we call run multiple times. This is the other reason for this change.
For instance, when an error occres here, I want to notice not only by the output but also by the status code.

#649 is needed to fix the error on CI. A build with that patch seems work.
https://travis-ci.org/hibariya/thor/builds/505774428

I really like this idea! :heart:
Even after adding the abort_on_failure: flag I still miss errors in my generators, because I cannot control every call to Thor::Actions#run.
For example, I just noticed that our Rails 6 application generation in ActiveAdmin is crashing, but the crash is only buried in the logs, so there's no way to notice other than manual log scanning (or if the failure affects further tests, but in that case, the culprit is still very hidden).

I've rebased onto the top of the master. The build seems OK.

Any chance on getting a review here?

👍, this also matches the original intent https://github.com/erikhuda/thor/pull/628
I don't have commit access, so it'll have to be @rafaelfranca who merges ❤


evidence check results guidance

pivotal 105859572

@kelliematheson can you test this here and confirm if happy it closes this ticket?


Add verto.mediaParams support

Adds support for handling veto.mediaParams. This is needed to allow us to tweak the media constraints from the server.
also, applyMediaContrains is a public method in the BaseCall that allows us to easily invoke it from the browser console.

@jpsantosbh Tony mentioned that we should make this the new parameters the default if everything looks in ok in test. Should this new default be part of this PR?

@crienzo, no, this PR is not setting a new default.
It allows the apps to set the default for themselves. maybe we should do a few tests to find the best defaults to set.
The change will be minimal to set it later.

@jpsantosbh makes sense. As long as we can change from browser console, we'll be in better shape to test w/ Sprinklr app once they update SDK.


Webpack failing to compile

After a fresh install build and start webpack is failing to compile.
cacheable modules 1.34 MiB
modules by path ./node_modules/ 1.3 MiB 47 modules
modules by path ./src/ 36.9 KiB
modules by path ./src/pages/ 33.5 KiB 30 modules
modules by path ./src/assets/img/ 115 bytes
./src/assets/img/logo.svg 52 bytes [built] [code generated]
./src/assets/img/tmp-launcher128.png 63 bytes [built] [code generated]
./src/containers/Greetings/Greetings.jsx 3.28 KiB [built] [code generated]
./node_modules/webpack/hot/ sync nonrecursive ^./log$ 170 bytes [built] [code generated]
ERROR in Unexpected string in JSON at position 355
webpack 5.23.0 compiled with 1 error in 10130 ms
i ｢wdm｣: Failed to compile.

@owlyowl I have the same issue. Were you able to fix this?


qwen2-vl无法启动

Reminder

[X] I have read the README and searched the existing issues.

System Info
写了个启动脚本
python src/webdemo.py
--model_name_or_path /home/2tdisk/working/AI/model/Qwen2-VL
--template qwen2_vl
但是运行时发生以下报错
Reproduction
ValueError: The checkpoint you are trying to load has model type qwen2_vl but Transformers does not recognize this architecture. This could be because of an issue with the checkpoint, or because your version of Transformers is out of date.
Expected behavior
No response
Others
No response

pip install git+https://github.com/huggingface/transformers.git


[Mongo] Embedded types generates wrong typescript typing

Describe the bug
Currently, if you use embedded types with typescript typings, the typings for that embedded type gets generated as
<T= FragmentableArray<S>>() => T. If you wanna call this Promise it throws an error, cause the embedded type isnt a function.
Example Datamodel:
type User {
  firstName: String!
  lastName: String!
  email: String! @unique
  password: String

  isAdmin: Boolean @default(value: false)

  id: ID! @id
}

enum UserPermission {
  READ
  WRITE
  DELETE
}

type AreaAccess @embedded {
  userId: ID! @db(name: "User")
  permission: UserPermission!
}

type Area {
  name: String!

  id: ID! @id
  updatedAt: DateTime
  createdAt: DateTime

  accesses: [AreaAccess!]!
}

Generated Area interface:
export interface Area {
  name: String
  id: ID_Output
  updatedAt?: DateTimeOutput
  createdAt?: DateTimeOutput
  accesses?: <T = FragmentableArray<AreaAccess>>() => T
}

To Reproduce
Steps to reproduce the behavior:

Create Datamodel
run prisma generate
create resolver with ctx.area({ id }).accesses()
throws error
create resolver with ctx.area({ id }).accesses
all fine

Expected behavior
Generated interface should look like this:
export interface Area {
  name: String
  id: ID_Output
  updatedAt?: DateTimeOutput
  createdAt?: DateTimeOutput
  accesses?: AreaAccess[]
}

Versions (please complete the following information):

Connector: MongoDB
Prisma Server: 1.25.4
prisma CLI: prisma/1.25.4 (darwin-x64) node-v10.5.0
OS: OS X High Sierra

I am unable to reproduce this in the latest version of prisma-cli 1.25.6. Please try to upgrade to that.

If you think this is still now working please provide us with a reproduction repository.

Seems to be gone with prisma 1.25.7 didnt test 1.25.6

I was wrong, the error is still there, the typing is also fine, but the execution throws an error. So create the datamodel i posted and run a graphql query to resolve "accesses".
From test:
 Received: {"data": {"organization": null}, "errors": [[GraphQLError: parent.accesses is not a function]]}

My fault still fixed sry guys :( should have read the error message before post such dumb comment and reopen the issue.


Receptor, Cell and Rearrangement schema representations

Receptor
A receptor represents two chains(i.e. one heavy and one light) of a cell, each with a antigen-binding site. However, an individual cells can also express multiple receptors, e.g. due to simultaneous expression of two TCR alpha chains.
Aim of the Receptor object is to provide reactivity information for individual Ig/TCRs.
Receptor object which is currently available in the pull request #404.
However, if the amino acid sequences of V-region of both receptor chains are identical and grouping them together will be considered as identical receptors and they would have identical reactivity information. So, the question was how to represent them in order to avoid redundancy of identical Receptor object?
Relationship between Receptor, Cell and Rearrangement
The current schema for Cell, Rearrangement and Receptor is represented below

• Receptor has N: N with Cell – A cell would contain multiple receptors and a receptor can be from multiple cells
• Receptor has 1:2 with Rearrangement –Two rearrangement represents a receptor and a receptor contains only two rearrangements sequences.
However the current linkage between Receptor and Rearrangement breaks because the rearranged sequences associated with the receptor might be different as receptors are determined at amino acid level whereas rearranged sequences are determined at nucleotide level there by having any synonymous substitution would lead to identical V-region of both receptor chains but their rearrangements would not be identical. Hence, 2:1 Rearrangement:Receptor does not hold true.
Given the schema representations that allows N:N Cell:Receptor relationship we have come up with two schema proposals and would be good to get some suggestions/comments on the proposed schemas below.
Proposal 1:

In the proposed schema we define two Receptor objects i.e Intermediate and Observed Receptor where multiple Intermediate Receptor objects are related to a single Cell  object and a Observed Receptor object is linked to multiple Intermediate Receptor object and there are no direct linkage to Cell Object.
The Observed Receptor object will then contain same properties as what we have defined currently in #409 but with addition of amino acid sequences of the receptor chains.
Proposal 2:

• Receptor has N:1 with Cell – A cell would contain multiple receptors and a receptor can be present in single cell
Here we then do not link Receptor to Rearrangement but as proposed for Observed Receptor we should extend the currentReceptor object by addition of the protein sequences of both receptor chains

Looking at #404, it seems to me that "Proposal 2" is what currently exists, as I do not see a slot in the Receptor object for Rearrangements. But, regardless, I don't see why a Receptor couldn't have the following fields allowing for a full linkage of N Rearrangements:
heavy_chain_aa:
    type: string
heavy_chain_rearrangements:
    type: array
    items:
        type: string
light_chain_aa:
    type: string
light_chain_rearrangements:
    type: array
    items:
        type: string

I don't really see a need to preserve that nucleotide sequence H1 was observed in 5 cells, paired with nucleotide sequences {L1, L1, L2, L1, L4} etc, so I think this structure should suffice...

I made a longer comment here:
https://github.com/airr-community/airr-standards/issues/409#issuecomment-638965495
But, I'm not convinced Receptor needs to store links to Rearrangement or Cell records, or if that's even desirable because it ties a Receptor record to a specific experimental result. In which case, you just need to add a receptor_id column to Rearrangement.
If your questions are:

Given an observed nucleotide sequence, what is it's antigen-affinity?
Given a Receptor (affinity), what samples have corresponding sequences?

It seems like Rearrangement already meets these needs if you add a receptor_id column and a  Receptor record database.

As #574 included a receptors property of the Cell object, this issue will be closed with the complementary definition of the Receptor object in #404. To provide a brief summary of decisions we made regarding the original questions of this issue:

Receptor is considered to be a global object, i.e., it describes the properties of an abstract receptor.
Receptor is not directly linked to Rearrangement, as it requires two rearrangement to be properly defined. Linkage is instead provided by the Cell object.


Message update

Since Member#getAsMention() exists i thought about adding Message#isMentioned(Member) / Message#getMentionedMembers() and now i realized my plans and so i hope its good enough (docs and code) and helps some users. Your Sanduhr <3

This is something we want to address in the message rewrite specifically.

Ah ok Minn hopefully soon™ <3

This is now tracked on experimental/message-rw


Use teardown instead of shutdown in CounterStoreTest

Which issue(s) this PR fixes:
No issues
What this PR does / why we need it:
Timecop.return is never called because CounterStoreTest#shutdown is never called.
We shuould define CounterStoreTest.shutdown or CounterStoreTest#teardown.
cf. https://github.com/test-unit/test-unit/blob/3.2.8/lib/test/unit.rb#L462-L473
As you can see, this PR corrects the elapsed time from -90938190.322263 seconds to 0.013861 seconds.
Before
% bundle exec rake TEST=test/counter/test_store.rb
/Users/arabiki/.anyenv/envs/rbenv/versions/2.6.2/bin/ruby -w -I"lib:test" -Eascii-8bit:ascii-8bit -I"/Users/arabiki/.anyenv/envs/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/rake-11.3.0/lib" "/Users/arabiki/.anyenv/envs/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/rake-11.3.0/lib/rake/rake_test_loader.rb" "test/counter/test_store.rb"
/Users/arabiki/.anyenv/envs/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/rake-11.3.0/lib/rake/thread_pool.rb:106: warning: mismatched indentations at 'rescue' with 'def' at 94
Loaded suite /Users/arabiki/.anyenv/envs/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/rake-11.3.0/lib/rake/rake_test_loader
Started
..................
Finished in -90938190.322263 seconds.
----------------------------------------------------------------------------------------------------
18 tests, 53 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
----------------------------------------------------------------------------------------------------
-0.00 tests/s, -0.00 assertions/s
fluentd 1.6.3 built to pkg/fluentd-1.6.3.gem.

After
% bundle exec rake TEST=test/counter/test_store.rb
/Users/arabiki/.anyenv/envs/rbenv/versions/2.6.2/bin/ruby -w -I"lib:test" -Eascii-8bit:ascii-8bit -I"/Users/arabiki/.anyenv/envs/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/rake-11.3.0/lib" "/Users/arabiki/.anyenv/envs/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/rake-11.3.0/lib/rake/rake_test_loader.rb" "test/counter/test_store.rb"
/Users/arabiki/.anyenv/envs/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/rake-11.3.0/lib/rake/thread_pool.rb:106: warning: mismatched indentations at 'rescue' with 'def' at 94
Loaded suite /Users/arabiki/.anyenv/envs/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/rake-11.3.0/lib/rake/rake_test_loader
Started
..................
Finished in 0.013861 seconds.
----------------------------------------------------------------------------------------------------
18 tests, 53 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
----------------------------------------------------------------------------------------------------
1298.61 tests/s, 3823.68 assertions/s
fluentd 1.6.3 built to pkg/fluentd-1.6.3.gem.

Docs Changes:
Release Note:

Ahhh... good catch!


MED-2488: update custom attributes

Cognito custom number attributes have a max limit of 100000
on the develop database we reach resources with id > 100000
It means at some point we won't be able to bind a user to an org
the solution is to store the organizationId as a string
This PR use the custom:orgId which is a string

:tada: This PR is included in version 1.4.1 :tada:
Your semantic-release bot :package::rocket:


Created a Repo for code review

In this repo my coding partner will review it for JavaScript best practices and DRY,KISS and YAGNI

Hi @Xghayor you did Good Job
But there are some issues that you will new to work in mansion at the bottom

kindly request change the type to const the array in order to avoid type change in some of the code
-(https://github.com/Xghayor/Clean-code-review/blob/c3908ac1c46caa1d6c704563714d8ed299a8b2a1/src/modules/taskManager.js#L1)


Add Option to Specify Request Timeout in PagerDuty API Session.

As the title suggests.

What's the current behavior, if the timeout isn't specified? Is the default for the timeout None, because this change will cause None to be passed in.

Checked the requests docs. None is default. Please update the if statement for an explicit check on None, so 0 can be used as an argument

Checked the requests docs. None is default. Please update the if statement for an explicit check on None, so 0 can be used as an argument

While requests default is None, pagerduty session sets it to 5 seconds as default: https://pagerduty.github.io/pdpyras/#pdpyras.PDSession.timeout
Either way, checking against None makes sense and I've updated the check.

@rana-awais-paypay oh, please also update the docs: https://github.com/lyft/cartography/blob/master/docs/root/modules/pagerduty/config.md

@rana-awais-paypay oh, please also update the docs: https://github.com/lyft/cartography/blob/master/docs/root/modules/pagerduty/config.md

Done.

Thanks for the PR!


[chore] FIx test flakiness

I observed the results of a recent CI run on the master branch.
Then I noticed that mostly url-supplied anchor is ignored with onMount() scrolling on navigation to page is failed.
So I focused on how to fix this test.
Then, I also fixed the related tests.
And finally, I changed 3 things.
1. FIx wrong assertion
The test url-supplied anchor is ignored with onMount() scrolling on navigation to page is using #onMount, but if JavaScript is disabled, it doesn't run. So scroll event is not happen.
So the expected result should be #go-to-element but it was #abcde.
So I changed it.
2. Why sometimes tests are passed?
Because this test depends on CSS file but I think sometimes assertion is run before loading the CSS file.
So in the second commit, I put style in HTML directly. Then I think the test will be stable.
3. Fix missing await
Just I added the missing await.
refer: https://playwright.dev/docs/test-assertions#expectlocatortobefocusedoptions
https://github.com/sveltejs/kit/pull/4071/commits/e5e94ffd75eb34522392451f68c3e9478e6aa4c0#diff-35da857c87de7945a1a14898efa59865955ced32f6ede60e298a3386be524dd6R256
https://github.com/sveltejs/kit/pull/4071/commits/1e0946926055acb04acc028102f3ddaebc0d7c42
BTW, I'll run the CI a few times and monitor for checking another issue also is there or not.
=> CI is failed, so I change this PR as draft.
Now all tests are passed.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

My local repo passed CI 5 times in a row.
I think now we can say that CI has stabilized, at least compared to before.

My local repo : https://github.com/baseballyama/kit/actions/runs/1886065877

thank you sooooo much! this is a legendary PR


Lab 03L01, MFA registration UI is different

Module: 3
Lab/Demo: 03L01, Configure Conditional Access policies for WVD (AD DS)
Exercise: 1, Task: 3
Step: 2
The latest MFA registration UI presents a pulldown list to choose between authentication phone, app, office phone. Please update the steps.

Hi Ning,
what specifically would you want to see in the instructions?
rgds
Marcin

The instructions: "This will automatically redirect your browser to the Microsoft Authenticator page.
On the Microsoft Authenticator page, click the link I want to set up a different method...." are no longer valid.
Below is the current MFA registration UI. Can the instruction be updated accordingly?

updated


feat(cache) introduce cache warmup for entities and DNS

Introduces a new configuration property, db_cache_warmup_entities, which allows the user to specify which entities should be warmed up at initialization.
From the documentation at kong.conf.default:
#db_cache_warmup_entities = services, plugins
                                 # Entities to be pre-loaded from the datastore
                                 # into the in-memory cache at Kong start-up.
                                 # This speeds up the first access of endpoints
                                 # that use the given entities.
                                 #
                                 # When the `services` entity is configured
                                 # for warmup, the DNS entries for values in
                                 # its `host` attribute are pre-resolved
                                 # asynchronously as well.
                                 #
                                 # Cache size set in `mem_cache_size` should
                                 # be set to a value large enough to hold all
                                 # instances of the specified entities.
                                 # If the size is insufficient, Kong will log
                                 # a warning.

The default value is services, plugins: the routes entity does not need to be warmed up because it is cached via the in-memory router object; specifying this in this configuration property is a no-op.
Includes unit tests for the kong.cache_warmup module.
This is a port of work produced by @bungle and kikito in #4408, #4462, #4468, #4488. Thanks @thibaultcha for the preliminary feedback and suggestions on the property name and specifics of the behavior.
(Note that, at @thibaultcha's suggestion, this PR replaces the "cache prewarm" terminology for the more usual "cache warmup" in all commits.)
Closes #4408.

This is what we need to debate:

#db_cache_warmup_entities = services, plugins

The async patches in its current form:

load services on init, and do cache active services on route rebuilds, also does DNS warmup when getting things from db, but also when getting events.
load all the plugins in memory

This kinda makes:
#db_cache_warmup_entities =

by default, otherwise we will loop through entities twice on start.

Though, not sure where to discuss it, if not here.

@bungle I would say "not here", because these are changes that are not being made by this PR. We should focus on the code that's under review here: scope creep in the discussion is the path of PR Review Hell. Let's keep both the PRs and the discussion in manageable-sized pieces. (Any changes to this motivated by future PRs should be made in those future PRs — and in the particular cases you brought up, we are talking about a one-line change to the defaults, so it's absolutely not a problem to merge the defaults as-is here (as they make sense for this code) and change them later if it proves necessary.)
I'm not saying those aren't relevant topics, but we'll cross those bridges when we get there.

Approved the changes as the only open one is the routes one and there's a log now.


[Suggestion] Brewing Stand Support

What is your suggestion?
Brewing Stand support

I feel I should leave a comment here for a progress update:
I've began work on this feature, actually at the time of writing this I've been working on it for five hours now. I've currently stumbled upon an issue that has broken Furnaces and doesn't quite get brewing stands working. I do expect this feature to be complete in the coming days (if not tomorrow), though for today I going to take a break.

If this doesn't work as expected please open a new issue.


Tailwind class typo:  appareance-none -> appearance-none

There is a typo in 22 files:
https://github.com/search?q=repo%3Aprimefaces%2Fprimevue-tailwind appareance&type=code
The correct tailwind class is:
'appearance-none‘ and not 'appareance-none'
https://tailwindcss.com/docs/appearance
Also this reset not being applied correctly could cause other issues ...

Thank you @atakantepe for the fast fix 🎉


Display more descriptive information on apps

This is a debatable UX improvement which we can all discuss... but the underlying issue is real from users that seem to agree that our apps are a little difficult to understand at first.
Our apps are pretty terse. The apps display model elements and data but have little in the way of explanation or descriptive text on them. At best we use the column comments as thumbnail text. Even that is a debatable UX decision which could be open for discussion. We also have a guided tutorial but I think its only on the search app and its optional and it has to be initiated by the user who will have no idea that it exists.
A few ideas come to mind to improve on this:

use a cookie to recognize a new user (i.e., lack of cookie) and by default walk them through a tutorial explaining the features of each app (of course, allow users to dismiss);
in addition, the walkthrough needs to have use case specific steps (e.g., to explain the various model elements on the page like Samples or Replicates etc);
another thought is to display model comments (table comments from postgres/ermrest) on pages below the element name. for example, under each model element display name used as a heading or subheading display a few sentences (up to the data modeler) to explain what it is;
or if you don't want to literally use the pg comments it could be some auxiliary annotation or subresource of a model element, and that annotation could be context-able.

Yes, we here this repeatedly.  Perhaps this also shows up in in the other issue with table of contents.
I can see from watching people use the UI, that the length of some of these pages is an issue.  People hit the record and then scroll, scroll, scroll.
Starting with things closed is a start. Remembering what people opened up previously would help, as would in idea of what the layout is (perhaps starting with more things closed at start would help, but you still loose the global state…..
Carl

Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine, Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA  90292-6695
Phone:  +1<PHONE_NUMBER>
Email:  carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
From: robes<EMAIL_ADDRESS>Reply-To: informatics-isi-edu/chaise<EMAIL_ADDRESS>Date: Thursday, May 18, 2017 at 5:00 PM
To: informatics-isi-edu/chaise<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [informatics-isi-edu/chaise] Display more descriptive information on apps (#1120)
This is a debatable UX improvement which we can all discuss... but the underlying issue is real from users that seem to agree that our apps are a little difficult to understand at first.
Our apps are pretty terse. The apps display model elements and data but have little in the way of explanation or descriptive text on them. At best we use the column comments as thumbnail text. Even that is a debatable UX decision which could be open for discussion. We also have a guided tutorial but I think its only on the search app and its optional and it has to be initiated by the user who will have no idea that it exists.
A few ideas come to mind to improve on this:

use a cookie to recognize a new user (i.e., lack of cookie) and by default walk them through a tutorial explaining the features of each app (of course, allow users to dismiss);
in addition, the walkthrough needs to have use case specific steps (e.g., to explain the various model elements on the page like Samples or Replicates etc);
another thought is to display model comments (table comments from postgres/ermrest) on pages below the element name. for example, under each model element display name used as a heading or subheading display a few sentences (up to the data modeler) to explain what it is;
or if you don't want to literally use the pg comments it could be some auxiliary annotation or subresource of a model element, and that annotation could be context-able.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/chaise/issues/1120, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXtWQtTbBoMqfslJqmZ1J55IAJJqLks5r7LF-gaJpZM4Nfyln.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/informatics-isi-edu/chaise","title":"informatics-isi-edu/chaise","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/informatics-isi-edu/chaise"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Display more descriptive information on apps (#1120)"}],"action":{"name":"View Issue","url":"https://github.com/informatics-isi-edu/chaise/issues/1120"}}}

I believe we already expose column comments as tooltips on field names in the recordedit app. At minimum, we should make this more consistent across apps?
I also vaguely remember a debate where I requested a way to make these visible w/o hovering...

Closing this issue since it is out of date.
As mentioned in my previous comment, there have been improvements over the last few years to show model more comments in more contexts. We've also added "inline" comments to related table sections and to recordedit pages to provide more details.
Issue #2393 (and the corresponding PR) added the inline comments to recordedit app.
As mentioned by Carl, we have also since added the "Table of Contents" panel to record app to reduce the "scrolling" that is done. The one issue not resolved from this is adding a tutorial/walkthrough which was part of the "search" application BEFORE angularJS but was never carried over during angularJS implementation (or now during reactJS implementation)


Account names vertical alignment wrong when compact or slim

Name of Defective Feature

Account name height

System Settings (Required)

ToolKit Version: 2.8.1
Operating System (Mac/Windows/Etc): Mac OS X EL Capitan
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: 67.0.3396.99
Other Extensions: Too many to list

Export of Toolkit Settings (Bottom Left of Settings Page)

Settings Export
[{"key":"AccountsDisplayDensity","value":"2"},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"AccountsStripedRows","value":true},{"key":"AdjustableColumnWidths","value":true},{"key":"AutoDistributeSplits","value":false},{"key":"BetterScrollbars","value":"0"},{"key":"BudgetCategoryFeatures","value":true},{"key":"BudgetProgressBars","value":"0"},{"key":"BudgetQuickSwitch","value":false},{"key":"CalendarFirstDay","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"1"},{"key":"ChangeEnterBehavior","value":true},{"key":"CheckCreditBalances","value":true},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":false},{"key":"CollapseSideMenu","value":true},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":true},{"key":"CreditCardEmoji","value":true},{"key":"CurrentMonthIndicator","value":false},{"key":"CustomFlagNames","value":false},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingHistoryLookup","value":"0"},{"key":"DisableToolkit","value":false},{"key":"DisplayTargetGoalAmount","value":"0"},{"key":"DisplayTotalMonthlyGoals","value":false},{"key":"DisplayUpcomingAmount","value":false},{"key":"EasyTransactionApproval","value":false},{"key":"EditAccountButton","value":"2"},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":true},{"key":"GoalIndicator","value":false},{"key":"GoalWarningColor","value":true},{"key":"GoogleFontsSelector","value":"2"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideAgeOfMoney","value":false},{"key":"HideHelp","value":true},{"key":"HideReferralBanner","value":true},{"key":"HighlightNegatives","value":true},{"key":"ImportNotification","value":"0"},{"key":"IncomeFromLastMonth","value":"1"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":true},{"key":"MonthlyNotesPopupWidth","value":"1"},{"key":"NavDisplayDensity","value":"1"},{"key":"Pacing","value":"0"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"2"},{"key":"QuickBudgetWarning","value":true},{"key":"ReconciledTextColor","value":"1"},{"key":"RemovePositiveHighlight","value":true},{"key":"RemoveZeroCategories","value":true},{"key":"ResizeInspector","value":true},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"1"},{"key":"RowsHeight","value":"1"},{"key":"RunningBalance","value":"1"},{"key":"SeamlessBudgetHeader","value":true},{"key":"ShowCategoryBalance","value":true},{"key":"ShowIntercom","value":true},{"key":"SpareChange","value":false},{"key":"SplitKeyboardShortcut","value":true},{"key":"SplitTransactionAutoAdjust","value":true},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":true},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleMasterCategories","value":true},{"key":"ToggleSplits","value":true},{"key":"ToggleTransactionFilters","value":"1"},{"key":"TransactionGridFeatures","value":true},{"key":"ViewZeroAsEmpty","value":false},{"key":"goalIndicator","value":false},{"key":"highlightNegativesNegative","value":true},{"key":"l10n","value":"0"},{"key":"reports","value":false}]

Steps to Reproduce the Behavior

Change 'Account name height' option to either compact or slim (more noticeable on slim)

Expected Behavior

Account names to be vertically aligned to centre (so that they align with account balances
Actual Behavior

No errors in console.
Each account name is aligned below the level of the account balance. This is more obvious when using the slim option, but is also the case with the compact option. See Screen shot attached.

@gsix14 Thanks for the report! this will be fixed in our next release :D

Hey @user the fix for this should be in our current release! If you notice the issue still exists and you're definitely running the newest version of the toolkit, please reopen! Thanks!
Please note, all browser can take up to an hour to provide updates to all users. You can force an update if it's available for you by going to chrome://extensions and clicking the "Update" button. Firefox users can go to about:addons, click the setting cog, and click "Check for updates...".


chore: add event names for system token awards, and refunds

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 9.706%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
9465

Relevant Lines:
97517

💛  - Coveralls


Separate Security Configuration

Creates new Config\Security class and make \CodeIgniter\Security\Security class depends on it
removes useless properties
rename some properties
rename some methods
CSRFVerify() to verify()
getCSRFHash() to getHash()
getCSRFTokenName() to getTokenName()
setHash() to generateHash()

add new public methods:
getHeaderName()
getCookieName()
isExpired()
shouldRedirect()

edits changes in user guide

[x] Securely signed commits
[x] Component(s) with PHPdocs
[x] User guide updated
[x] Conforms to style guide

Closes #3703

All green

Please squash commits 9ff90b9 to 6ab17ef.
Squash commits 9df259b to 2bb5089.

We're now implementing a clean, descriptive commit history to help in changelog generation.

I'm working on it


Allow to use any feedback style

Primary reason to submit this PR is to allow the flexibility of using any feedback style.

Very cool, thank you!


View is referred to incorrectly

In the CodeFlow CallBackController, the return:
return View("Token", response);
should be
return View("Tokens", response);

Nice catch, thanks!
I just rebuilt the sample from scratch in #14 to clean it up. If you notice any other bugs, please let us know! 👍


something wrong

I'm working on it, I'll update it as soon as possible

hello, sorry for taking long, I have managed to fix the problem and upgraded the project to the current version of Avalonia. I will be uploading it in the next 24 hours.

The update has been approved and is available for download. Repot any bugs you may encounter, and also any improvements necessary. Thank you and Happy Coding


SQL Server Table Hints

Dear @volkanceylan,
I hope you're doing well!
I'm still playing with Serenity even if a little less frequently than before, neverthless I would like to share with you my latest change to the sources.
In fact I found myself in a particular scenario where SQL Server Table Hint are mandatory and I managed to integrate such feature in Serenity.
Just a couple of things:

I was on the verge of using an enum as a parameter of the TableHintAttribute, but table hints could be very complex (https://docs.microsoft.com/en-us/sql/t-sql/queries/hints-transact-sql-table?view=sql-server-2017) so in the end I chosed the more straightforward approach, allowing the developer to use a string as parameter.

As per documentation, "Omitting the WITH keyword is a deprecated feature", so I preferred to always put the table hints inside a "WITH (<my_table_hint>)" block in order to both standardize the generated sql and prevent the developer from putting arbitrary sql after the table alias.

Table hint are supported by both LeftJoin and InnerJoin

TableHintAttribute(s) can be applied only to classes, but its used both in the from clause of the Row where its applied and in the joins (if the foreign tables have the attribute aswell)

I added also a sql dialect check in order to prevent the usage of table hints for db engine other than sql server

Let me know if everything is fine!
Have a nice weekend :-)
Bye

Need to check failed test: temporary closed

reopened


NativeTestApp fails to start on Android

The app immediately crashes after startup. There really isn't much info to go on from the logs:
10-16 13:30:46.750  1785  1785 W ResourcesManager: getTopLevelResources: /data/app/com.apps.nativetestingapp-1/base.apk / 1.0 running in com.apps.nativetestingapp rsrc of package null
10-16 13:30:46.780  1785  1785 I Adreno-EGL: <qeglDrvAPI_eglInitialize:379>: EGL 1.4 QUALCOMM build:  (Ia10634f51b)
10-16 13:30:46.780  1785  1785 I Adreno-EGL: OpenGL ES Shader Compiler Version: E<IP_ADDRESS>
10-16 13:30:46.780  1785  1785 I Adreno-EGL: Build Date: 01/28/16 Thu
10-16 13:30:46.780  1785  1785 I Adreno-EGL: Local Branch: ss
10-16 13:30:46.780  1785  1785 I Adreno-EGL: Remote Branch:
10-16 13:30:46.780  1785  1785 I Adreno-EGL: Local Patches:
10-16 13:30:46.780  1785  1785 I Adreno-EGL: Reconstruct Branch:
10-16 13:30:46.780  1785  1785 D libEGL  : eglInitialize EGLDisplay = 0xbed79bf4
10-16 13:30:47.430  1785  1785 F libc    : Fatal signal 6 (SIGABRT), code -6 in tid 1785 (ativetestingapp)
10-16 13:30:47.540   329   329 F DEBUG   : pid: 1785, tid: 1785, name: ativetestingapp  >>> com.apps.nativetestingapp <<<
10-16 13:30:48.110  2148  2148 E audit   : type=1701 msg=audit(1508153448.110:416): auid=4294967295 uid=10185 gid=10185 ses=4294967295 subj=u:r:untrusted_app:s0:c512,c768 pid=1785 comm="ativetestingapp" reason="memory violation" sig=6

I've tried on a Samsung P5210, Lenovo TB3-X70F  and Samsung Galaxy S5.
 Adding back any little bits seems to cause it to crash.

git bisect lead me to this a8ee93d68a96ca1943f869c555f25ced261f886b

@kristianhasselknippe: Do you have any clue about this?

Setting ImageSource to null ends up throwing exceptions since this case was removed: https://github.com/fusetools/fuselibs-public/commit/a8ee93d68a96ca1943f869c555f25ced261f886b#diff-15267d96e994703ba7a6d3ed676b724dL81


Consider disabling double-quoted strings

See https://sqlite.org/quirks.html#double_quoted_string_literals_are_accepted
AFAICT this dbconfig option isn't exposed by rusqlite.  It would be nice to expose it, and then we shoudl consider changing the default (in the next breaking release, presumalby).

AFAICT this dbconfig option isn't exposed by rusqlite.

https://docs.rs/rusqlite/latest/rusqlite/?search=dqs


cdc/codec: fix nil value in canal codec.

What problem does this PR solve?

Issue Number: close #4736
What is changed and how it works?
check nil before use the Column.Value in Canal
Check List
Tests

Unit test

Code changes
Side effects
Related changes
Release note
fix `Canal-JSON` meet `unsigned` SQL Type and nullable, which cause CDC server panic.

/run-verify
/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

/run-leak-test


Loadable propagator for Clingo via Python API

I was hoping to try out this project as a background theory in combination with a number of other features that Clingo offers. In particular we (developers of Popper) make considerable use of the programmatic interface of Clingo, e.g. for multi-shot solving.
I have the project compiling, but I don't see how I could just load the propagator. I see in main.cc how this would work for a C++ project making use of this solver/propagator, but I am not seeing bindings to Python.
Are the Python bindings planned and are they much work to write up?

It would not be that difficult to add Python bindings. It would basically mean to copy existing code from clingo-dl or clingcon and adjust it to clingo-lpx. It's just an interface after all. The only bit that requires some thought is to make sure that multi-shot solving works.
I am currently busy with other projects but can mark this issue as a todo and address it later when I have some time. No promises, though.

Thanks Roland. Am looking forward to being able to use it (in our project which makes extensive use of multi-shot solving).

I implemented something. Note that this is a side project and does not get the same attention as for example clingo-dl. You find development packages in the usual places (but there is no stable release yet).


authentication required

Hi!
I am trying to test the boldqc on our XNAT, but I am unable to pull the container from your docker hub.
While making image from oci registry: error fetching image to cache: failed to get checksum for docker://neuroinformatics/boldqc/0.1.0: reading manifest latest in docker.io/neuroinformatics/boldqc/0.1.0: errors:
denied: requested access to the resource is denied
unauthorized: authentication required

Is it possible to unlock the dockerhub? Or add my docker account (same as my git username).
Thanks!

wrong syntax was used.


Add Ami Not Encrypted query for Ansible #1498

AWS AMI Encryption is not enabled #1498

Scan submitted to Checkmarx

Scan not submitted to Checkmarx due to existing Active scan for the same project.

Checkmarx SAST - Scan Summary & Details
Cx-SAST Summary
Total of 4 vulnerabilities 0 High 3 Medium 1 Low 0 Info
Violation Summary
 3 Medium
View more details on Checkmarx UI
Cx-SAST Details

Lines
Severity
Category
File
Link

30
Medium
Path_Traversal
cmd/builder/main.go
Checkmarx

52
Medium
Denial_Of_Service_Resource_Exhaustion
pkg/kics/service.go
Checkmarx

83
Medium
Denial_Of_Service_Resource_Exhaustion
test/main_test.go
Checkmarx


/connection/create: connection identifier is not safed on DB after a successful creation

Describe the bug
/connection/create: connection identifier is not safed on DB after a successful creation
To Reproduce
Steps to reproduce the behavior:

Call /connection/create with valid params (recive 201)
Look Up Database with SQL Workbench

Expected behavior
The connection identifier is saved in order to link a registered employee to a connection.

duplicate: #110 and fixed in #135


Add Show/Hide to graphic renderer

Adding/Removing graphics from graphic groups is super duper slow (due to rebuilding meshes) or might not even be possible! (baked renderer baked mesh at edit time).  Since enabling/disabling visuals is something basically 99.99% of UI's want to do, this drives basically everyone to the dynamic renderer since it's the only one that supports adding/removing at runtime.
Alternate proposal is to introduce the idea that a graphic can be hidden, where it is still technically attached to a group and has all of the important feature data and stuff, but it is actually not visible.  This would allow the baked renderer and the dynamic renderer to hide and unhide graphics much more quickly.

Idea now is to completely separate the concept of attachment from enabled/disabled.  A graphic can be attached to a group whether or not it is enabled or disabled.  Enabling or disabling the object would then be the way that you show or hide a graphic (if it is supported).
I think this would be vastly superior to adding a show/hide boolean, since it would allow disabling of a gameobject to efficiently hide all of the childed graphics, and would still do so without needing to detach them!


The links over footer are not active

The  links needs to be active  for user to know about the creator

@saurabhbakolia plz assign me this