Package request: 64Gram

Project description
64Gram (unofficial Telegram Desktop)
Metadata

homepage URL: https://t.me/tg_x64
source URL: https://github.com/TDesktop-x64/tdesktop
license: gpl3
platforms: linux

+1

+1

+1

Well why was this closed exactly? I dont see 64gram added yet? and whatsup with that code sent above?

Kotatogram exist in nixpkgs, I think its worth it.. Please re-open this if maybe someone wanted to add this in future.


supporting snowflake extract syntax

Closes #1373

@iffyio thank you for the review. I've updated the PR per your suggestions.
Snowflake also offers the option to pass a string to the EXTRACT method like so:
EXTRACT('hour', foo)

Do you have any recommendation on how to handle that case here?

I took the liberty of running cargo fmt and pushing a commit to this branch to get the CI passing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

37 of 40 (92.5%)  changed or added relevant lines in 5 files are covered.
649 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.005%) to 89.054%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser/mod.rs
10
13
76.92%

Files with Coverage Reduction
New Missed Lines
%

src/ast/mod.rs
302
81.57%

src/parser/mod.rs
347
93.34%

Totals

Change from base Build<PHONE_NUMBER>2:
0.005%

Covered Lines:
27646

Relevant Lines:
31044

💛  - Coveralls


Support ingestion of logs via fetching/polling from RESTful APIs

In its current state, StreamAlert is able to receive log data via a push-like approach, wherein other services (AWS SNS, Kinesis, S3) are able to send data into the Rule Processor lambda function for processing.
This proposal is to incorporate a flexible poll-like model into StreamAlert that would allow for scheduled fetching of logs via RESTful APIs that could then be handed off to the Rule Processor lambda function for processing.
The idea is that this would be extensible and offer the ability to support practically any generic SaaS application, RESTful endpoint, etc. A few bullet point use cases could include retrieving logs from services provides such as OneLogin, DUO Security, Google Admin, etc and batching/formatting them in a way that the Rule Processor could easily ingest & process.

Shouldn't a scheduled event triggering lambda to fetch and prepare data be something that I create to feed data into "Stream"Alert? This proposal sounds a bit against the concept of serverless and add a data producer to something I considered a pure data consumer.

@ryandeivert:

In its current state, StreamAlert is able to receive log data via a push-like approach, wherein other services (AWS SNS, Kinesis, S3) are able to send data into the Rule Processor lambda function for processing.

It's worth noting that Kinesis is actually a polling method.  Lambda checks the stream every 250ms and a static batch of records is analyzed.
@glaslos:

Shouldn't a scheduled event triggering lambda to fetch and prepare data be something that I create to feed data into "Stream"Alert?

I believe @ryandeivert is suggesting the creation of a framework that would be generic enough for most use cases to avoid duplication of effort.  Users always have the option of creating their own producer by whichever preferred means.

This proposal sounds a bit against the concept of serverless and add a data producer to something I considered a pure data consumer.

Scheduled jobs can run in Lambda just fine via CloudWatch Scheduled Events, this is actually how you connect a Lambda function to a SQS Queue.


flutter_inappwebview iOS keep autoplay background video in full screen

Hi, I'm using this version in iOS keep autoplay background video in full screen, not happen on Android.
Please check this screen record:
https://monosnap.com/file/1BH4ee4p4Q23H9HrE2TtEatzvJihUq
flutter_inappwebview:
    git:
      url: https://github.com/vixez/flutter_inappwebview.git
      ref: fix-xcode-17

Please advice how to fix this bug?
Thank you

Probably unrelated, but you can switch to the newest version of the library. Fix for xcode 15 was already merged.


Remove close() calls on name selection

Fixes the bug that closes the tab when you select an identity.
@grace-fagan
Not sure why close was there, but lmk if there're contexts I'm missing.

@DanTehrani This is fine with me, no other contexts. I chose to close the menu on selection to signify to the user that they've chosen their identity and can send the post. I can see arguments for leaving the menu open though – allows the user to make multiple selections, etc.

@grace-fagan
In my browser (Brave) not only the menu but also the entire tab closes (probably close() calls window.close())...
I assume you're seeing a different behavior?
(Anyways feel free to merge this PR!)


[stable/nats] Add support for extraArgs to NATS

Signed-off-by: William Clifford<EMAIL_ADDRESS>
What this PR does / why we need it:
This PR adds the ability to template in additional flags to the gnatsd process.
I have a use case, when using a custom NATS image, where additional custom flags need to be set.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Thanks for the PR, before continue, it seems you need to resolve some conflicts

@carrodher All fixed up 😄

/ok-to-test

/lgtm


[TEST] [ENHANCEMENT] Support updating VM networks and vlanconfigs

What's the test to develop? Please describe
A clear and concise description of what the test you want to develop.

As for v1.1.1, Harvester doesn't support updating VM networks. If users want to change the VM network, they need to delete it and create a new one. However, the old VM network usually has been used by some VMs and could not be deleted.

As for v1.1.1, it's not allowed to change the cluster network of vlanconfigs. In some cases, our customs wants to migrate vlanconfigs into a new cluster network. We'd better support cluster network migration for vlanconfigs.

Test Scenarios:
https://github.com/harvester/harvester/issues/3372#issuecomment-1521502390
Case 1:  Migrate vlanconfig to another cluster network and vice versa

Create cluster network cn1 and cn2
Create vlanconfig nc1 on cluster network cn1 and set uplink NIC to enp179s0f0 on node1
Create vlanconfig nc2 on cluster network cn2 and set uplink NIC to enp179s0f0 on node2
Migrate vlanconfig nc1 to cn2
Migrate vlanconfig nc2 to cn1
Migrate vlanconfig nc1 back to cn1
Delete vlanconfig nc2
Delete cluster network cn2

Case 2: Prevent to migrate vlanconfig if already set on a Running VM

Create vlanconfig nc1
Create a VM network vlan101 and set manual route CIDR and Gateway
Create a VM vm101 and set network to vlan101
Migrate vlanconfig to another cluster network cn2
It would prompt error message

Case 3: Migrate vlanconfig already set on a running VM

Create cluster network cn1 and cn2
Create vlanconfig nc1,
Create VM network vlan101 on vlanconfig nc1
Create a VM vm101 and set vlan network vlan101
Migrate vlanconfig to another cluster network cn2. It would fail.
Stop VM
Migrate vlanconfig, now the the VM network display unready
Restart VM. It would fail.
Modify VM network to new cluster network
Start VM it should be running correctly

Case 4: Update vlanconfig from all nodes to specific node and one node to another node
ref: https://github.com/harvester/harvester/issues/3372#issuecomment-1439707225

Create a new cluster network cn1
Create a vlanconfig nc1 that covers all nodes under the cluster network
Change the vlanconfig node selector of nc1 to one specified node 1
We should change vlanconfig by using node selector
Switch node selector of nc1 to cover all nodes
Change node selector to node 0 again

Case 5: Update VM network of the running VM
Prerequisite:

Two active vlan network environment
Two cluster networks cn1 and cn2

Create vlanconfig nc1 on cluster network cn1
Create vlanconfig nc2 on cluster network cn2
Create a VM network vlan101 and set manual route CIDR and Gateway
Create a VM vm101 and set network to vlan101
Update VM network

Change VLAN ID to 102 , it wil prompt error to prevent to proceed
Change Cluster network to cn2
Change VLAN manual route to correct CIDR and Gateway
Change Type to UntaggedNetwork

Case 6: Update VM network of the stopped VM

Follow Test Case 5 step 1 - 4
Stop the running VM
Stop VM
Update VM network

Change VLAN ID to 102
Change Cluster network to cn2
Change VLAN manual route to correct CIDR and Gateway

Start VM, check state is Running
Stop VM
Update VM network Type to UntaggedNetwork
Start VM, check state is Running

Prerequisite and dependency of test
Manual test to Harvester logging with opensearch service
Describe the items of the test development (DoD, definition of done) you'd like

Please use a task list for items on a separate line with a clickable checkbox https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists

[ ] Test all testcases in first section

Additional context
Add any other context or screenshots about the test request here.
related issue: harvester/harvester#3372

@TachunLin Are these scenarios already covered in automation or do we want to implement these?


fix: exit --help with code 0

Fixes #80. Not sure why --help exits with an error code (1) but this just changes that to exit code 0.

Having this fixed would be lovely

FYI, I found this also needs at least one fix to a test: https://github.com/Schniz/cmd-ts/blob/main/test/ui.test.ts#L107

FYI, I found this also needs at least one fix to a test: main/test/ui.test.ts#L107

Thanks for pointing that out, a bunch of others are failing. I'll fix those.

I also have a few other fixes at https://github.com/lgarron/cmd-ts-too/commits/main/ , feel free to crib.

I also have a few other fixes at lgarron/cmd-ts-too@main (commits) , feel free to crib.

Awesome, love the new fork. Sent you some suggestions over DM on Mastodon :)


Redesign FromXml trait.

So I've thought that with v0.3.0's change of removing the OptionFromXml trait things would be better and more ergonomic, but this is only the case for single value types which are to be serialized where this makes sense.
When reading more complicated things with many fields or just many parsing steps, it can be quite problematic if a try!/? macro leads to returning of FromXmlError::Absent when only a single field is absent which might be a completely wrong document and should be indicated with an error instead of just None. (read_option would in this case end up just swallowing errors.)
Options:

Somehow differentiate FromXml for single value types and more complicated things. I fear this might end up rather badly.
Make reading from option a marker trait which has to be added to a type implementing FromXml so a developer would have the power to make this choice.
(something better which I haven't thought of yet)

One idea how this could be done is simply don't care at the FromXml trait level whether something is an option or not. That is, each type gets to decide how it is implemented, and it can return an error if the implementation considers the input invalid. If users really want to support the FromXml<Option<T>> for their own types, they have to do it explicitely. (However I expect this will only really be the case for "simple" datatypes.)

The result of each query is a Nodeset, the required information for each query is a Node.
FromXml implementors should retrieve the data from the Nodeset and load more Nodesets using a handle to a relative reader.


Missing ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE

Since default branch of repo changed to master, the ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE are not showing up due to them not being available on master.

This has been fixed


Audio issues.

For a while I have been havig audio issues on my chroagh, not sure what caused it. I have tried to restart pulseaudio, use pavucontrol, or alsamixer, nothig seems to work.
Using mplayer I get:
Audio device got stuck!
Any help on getting my audio back to working mode?

Have you tried updating your chroot? It's not impossible that it's currently broken, I'll check on my side.

Thanks that worked, the update process was a bit cumbersome, would be nice to have the string to update on arch. The original instructions on update intends to download precise.
This is what I did, although I think some of the flags were no necessary:
sudo sh -e installer/main.sh -r arch -t xfce -u

Well, Arch will get merged into crouton soon, so that'll help ,-)
For reference, the update line looks like this:
sudo sh -e installer/main.sh -n arch -u

(but, of course, what you did also works)


VS2019 Running clang-power-tools rebooted my computer

I installed clang-power-tools in VS2019 Community edition. Running clang from the toolbar rebooted my computer. After that, I haven't been able to get clang-power-tools to even load again.
Starting VS2019 now gives the following message:
"The 'RunClangPowerToolsPackage' package did not load correctly.
The problem may have been cause by a configuration change or by the installation of another extension. You can get more information by examining the file 'C:\Users<username>\AppData\Roaming\Microsoft\VisualStudio\16.0_08d1afd8\ActivityLog.xml'."
I have tried uninstalling and reinstalling clang-power-tools multiple times after this, without success.
Interesting part of ActivityLog.xml:

1706
2019/04/21 09:48:10.647
Error
VisualStudio
    SetSite failed for package [RunClangPowerToolsPackage]Source: 'System.Xml' Description: There is an error in XML document (0, 0).
System.InvalidOperationException: There is an error in XML document (0, 0). ---> System.Xml.XmlException: Root element is missing.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XmlTextReader.Read()
   at System.Xml.XmlReader.MoveToContent()
   at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderClangTidyOptions.Read6_ClangTidyOptions()
   --- End of inner exception stack trace ---
   at System.Xml.Serialization.XmlSerializer.Deserialize(XmlReader xmlReader, String encodingStyle, XmlDeserializationEvents events)
   at System.Xml.Serialization.XmlSerializer.Deserialize(Stream stream)
   at ClangPowerTools.XmlSerializer.DeserializeFromFile[T](String aFilePath)
   at ClangPowerTools.ConfigurationPage`1.LoadFromFile(String aFilePath)
   at ClangPowerTools.ClangTidyOptionsView.LoadSettingsFromStorage()
   at Microsoft.VisualStudio.Shell.DialogPage.set_Site(ISite value)
   at System.ComponentModel.Container.Add(IComponent component, String name)
   at System.ComponentModel.Container.Add(IComponent component)
   at Microsoft.VisualStudio.Shell.Package.GetDialogPage(Type dialogPageType)
   at ClangPowerTools.SettingsProvider.Initialize(AsyncPackage aPackage)
   at ClangPowerTools.RunClangPowerToolsPackage.<InitializeAsync>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Shell.AsyncPackage.<>c__DisplayClass16_0.<<Microsoft-VisualStudio-Shell-Interop-IAsyncLoadablePackageInitialize-Initialize>b__1>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Threading.JoinableTask.<JoinAsync>d__68.MoveNext()System.Xml.XmlException: Root element is missing.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XmlTextReader.Read()
   at System.Xml.XmlReader.MoveToContent()
   at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderClangTidyOptions.Read6_ClangTidyOptions()
{F564F9D3-01AE-493E-883B-18DEEBDB975E}
80131509

Full ActivityLog.xml:

1
2019/04/21 09:47:51.700
Information
VisualStudio
    Microsoft Visual Studio 2019 version: 16.0.28803.197

2
2019/04/21 09:47:51.700
Information
VisualStudio
    Log ID
{51A9ECBB-E107-491F-9EB0-0763CD98FB71}

3
2019/04/21 09:47:51.701
Information
VisualStudio
    Running in isolation mode.

4
2019/04/21 09:47:51.704
Information
VisualStudio
    Looking for master PkgDef file
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\master.pkgdef

5
2019/04/21 09:47:51.705
Information
VisualStudio
    Creating PkgDefCacheNonVolatile

6
2019/04/21 09:47:51.705
Information
VisualStudio
    PkgDefCache flags
00013801

7
2019/04/21 09:47:51.714
Information
VisualStudio
    Double-checking master pkgdef file

8
2019/04/21 09:47:51.714
Information
VisualStudio
    PkgDefManagement initialized

9
2019/04/21 09:47:51.714
Information
VisualStudio
    RootFolder
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\

10
2019/04/21 09:47:51.714
Information
VisualStudio
    ShellFolder
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\

1608
2019/04/21 09:48:05.687
Information
VisualStudio
    End package load [Visual C++ Language Manager Package]
{8C2EA640-ABC1-11D0-9D62-00C04FD9DFD9}

1609
2019/04/21 09:48:05.690
Information
VisualStudio
    Begin package load [Microsoft.VisualStudio.Editor.Implementation.EditorPackage]
{E269B994-EF71-4CE0-8BCD-581C217372E8}

1610
2019/04/21 09:48:05.837
Information
VisualStudio
    End package load [Microsoft.VisualStudio.Editor.Implementation.EditorPackage]
{E269B994-EF71-4CE0-8BCD-581C217372E8}

1611
2019/04/21 09:48:05.872
Information
VisualStudio
    End package load [Visual C++ Package]
{1B027A40-8F43-11D0-8D11-00A0C91BC942}

1612
2019/04/21 09:48:05.941
Information
VisualStudio
    Begin package load [LLVM.ClangFormat.ClangFormatPackage, ClangFormat, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=f0d7d4b9681b3b28]
{C5286038-25D3-4F65-83A8-51FA2DF4A146}

1613
2019/04/21 09:48:05.952
Information
VisualStudio
    End package load [LLVM.ClangFormat.ClangFormatPackage, ClangFormat, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=f0d7d4b9681b3b28]
{C5286038-25D3-4F65-83A8-51FA2DF4A146}

1614
2019/04/21 09:48:05.986
Information
MruList
    Entering AddItem. Persistence data for item: %UserProfile%\Generic-Source\BetterGetter\src\main.cpp|{00000000-0000-0000-0000-000000000000}|1,23|False

1615
2019/04/21 09:48:05.986
Information
MruList
    Entering TryPromoteItem

1616
2019/04/21 09:48:05.986
Information
MruList
    Did not find item to promote

1617
2019/04/21 09:48:05.986
Information
MruList
    Entering AddItem. Persistence data for item: %UserProfile%\Generic-Source\BetterGetter\src\Decorate.cpp|{00000000-0000-0000-0000-000000000000}|0,23|False

1618
2019/04/21 09:48:05.986
Information
MruList
    Entering TryPromoteItem

1619
2019/04/21 09:48:05.986
Information
MruList
    Did not find item to promote

1620
2019/04/21 09:48:05.986
Information
MruList
    Entering AddItem. Persistence data for item: %UserProfile%\Generic-Source\BetterGetter\include\BetterGetter\Decorate.h|{00000000-0000-0000-0000-000000000000}|0,0|False

1621
2019/04/21 09:48:05.986
Information
MruList
    Entering TryPromoteItem

1622
2019/04/21 09:48:05.986
Information
MruList
    Did not find item to promote

1623
2019/04/21 09:48:05.986
Information
MruList
    Entering AddItem. Persistence data for item: %UserProfile%\Generic-Source\BetterGetter\include\BetterGetter\BetterGetter.h|{00000000-0000-0000-0000-000000000000}|99,50|False

1624
2019/04/21 09:48:05.986
Information
MruList
    Entering TryPromoteItem

1625
2019/04/21 09:48:05.986
Information
MruList
    Did not find item to promote

1626
2019/04/21 09:48:05.986
Information
MruList
    Entering AddItem. Persistence data for item: %UserProfile%\Generic-Source\BetterGetter\include\BetterGetter\AsConst.h|{00000000-0000-0000-0000-000000000000}|0,0|False

1627
2019/04/21 09:48:05.986
Information
MruList
    Entering TryPromoteItem

1628
2019/04/21 09:48:05.986
Information
MruList
    Did not find item to promote

1629
2019/04/21 09:48:05.986
Information
MruList
    Entering AddItem. Persistence data for item: %UserProfile%\Generic-Source\BetterGetter\test-src\CMakeLists.txt|{00000000-0000-0000-0000-000000000000}|29,60|False

1630
2019/04/21 09:48:05.986
Information
MruList
    Entering TryPromoteItem

1631
2019/04/21 09:48:05.986
Information
MruList
    Did not find item to promote

1632
2019/04/21 09:48:05.986
Information
MruList
    Entering AddItem. Persistence data for item: %UserProfile%\Generic-Source\BetterGetter\test-src\GetterByValue.cpp|{00000000-0000-0000-0000-000000000000}|43,0|False

1633
2019/04/21 09:48:05.986
Information
MruList
    Entering TryPromoteItem

1634
2019/04/21 09:48:05.986
Information
MruList
    Did not find item to promote

1635
2019/04/21 09:48:05.986
Information
MruList
    Entering AddItem. Persistence data for item: %UserProfile%\Generic-Source\BetterGetter\test-src\GetterByValueNoCopy.cpp|{00000000-0000-0000-0000-000000000000}|28,0|False

1636
2019/04/21 09:48:05.986
Information
MruList
    Entering TryPromoteItem

1637
2019/04/21 09:48:05.986
Information
MruList
    Did not find item to promote

1638
2019/04/21 09:48:05.986
Information
MruList
    Entering AddItem. Persistence data for item: %UserProfile%\Generic-Source\BetterGetter\test-src\GetterByValueExplicitCopy.cpp|{00000000-0000-0000-0000-000000000000}|60,19|False

1639
2019/04/21 09:48:05.986
Information
MruList
    Entering TryPromoteItem

1640
2019/04/21 09:48:05.986
Information
MruList
    Did not find item to promote

1641
2019/04/21 09:48:05.986
Information
MruList
    Entering AddItem.  Persistence data for item: C:\Users\\Generic-Source\BetterGetter\test-src\GetterByRef.cpp|00000000-0000-0000-0000-000000000000|0,0

1653
2019/04/21 09:48:07.248
Information
MruList
    Entering TryPromoteItem

1654
2019/04/21 09:48:07.248
Information
MruList
    Entering PromoteItemAt and found the index of the item to be 0

1655
2019/04/21 09:48:07.254
Information
Manage Visual Studio Performance
    End execution cost summary for SolutionLoad scenario and Project component

1656
2019/04/21 09:48:07.254
Information
Manage Visual Studio Performance
    Component: f1c25864-3097-11d2-a5c5-00c04f7968b4, Inclusive Cost: 151.5666, Exclusive Cost: 139.5988, Top Level Inclusive Cost: 151.5666
{F1C25864-3097-11D2-A5C5-00C04F7968B4}

1657
2019/04/21 09:48:07.254
Information
Manage Visual Studio Performance
    Component: e269b994-ef71-4ce0-8bcd-581c217372e8, Inclusive Cost: 148.6028, Exclusive Cost: 148.6028, Top Level Inclusive Cost: 0
{E269B994-EF71-4CE0-8BCD-581C217372E8}

1658
2019/04/21 09:48:07.254
Information
Manage Visual Studio Performance
    Component: 1b027a40-8f43-11d0-8d11-00a0c91bc942, Inclusive Cost: 347.0998, Exclusive Cost: 142.6478, Top Level Inclusive Cost: 347.0998
{1B027A40-8F43-11D0-8D11-00A0C91BC942}

1659
2019/04/21 09:48:07.254
Information
Manage Visual Studio Performance
    Component: a9405ae6-9ac6-4f0e-a03f-7afe45f6fcb7, Inclusive Cost: 248.3325, Exclusive Cost: 216.4437, Top Level Inclusive Cost: 248.3325
{A9405AE6-9AC6-4F0E-A03F-7AFE45F6FCB7}

1660
2019/04/21 09:48:07.254
Information
Manage Visual Studio Performance
    End execution cost summary for SolutionLoad scenario and Project component

1661
2019/04/21 09:48:07.255
Warning
SyncAutoLoadedExtensions
    Extension 'ClangFormat' uses the 'synchronous auto-load' feature of Visual Studio. This feature will no longer be supported in a future Visual Studio 2019 update, at which point this extension will not work. Please contact the extension vendor to get an update. (UI Context: {f1536ef8-92ec-443c-9ed7-fdadf150da82} Package Guid: {c5286038-25d3-4f65-83a8-51fa2df4a146})

1662
2019/04/21 09:48:07.283
Information
MruList
    Entering OnAddVerbInvoked

1663
2019/04/21 09:48:07.283
Information
MruList
    Entering AddItem. Persistence data for item: C:\Users\\VS2019-Source-x64\BetterGetter_build\BetterGetter.sln

1664
2019/04/21 09:48:07.283
Information
MruList
    Entering TryPromoteItem

1665
2019/04/21 09:48:07.283
Information
MruList
    Entering PromoteItemAt and found the index of the item to be 0

1666
2019/04/21 09:48:07.283
Information
CodeContainerTracing
    Entering MruItemsStoreServiceDecorator.AddProjectIfNecessaryAsync. projectItemData: %UserProfile%\VS2019-Source-x64\BetterGetter_build\BetterGetter.sln|{00000000-0000-0000-0000-000000000000}|False|BetterGetter||||{00000000-0000-0000-0000-000000000000}

1667
2019/04/21 09:48:07.283
Information
CodeContainerTracing
    Entering CodeContainerStorageManager.AddOrUpdateAsync. CodeContainer path: C:\Users\\VS2019-Source-x64\BetterGetter_build\BetterGetter.sln

1668
2019/04/21 09:48:07.284
Information
CodeContainerTracing
    Entering ObservableSettingsListBase.AddOrUpdateAsync. Item key: C:\Users\\VS2019-Source-x64\BetterGetter_build\BetterGetter.sln, Item value: Microsoft.VisualStudio.Shell.CodeContainerManagement.CodeContainer

1669
2019/04/21 09:48:07.284
Information
CodeContainerTracing
    Entering ObservableSettingsListBase.AddToFrontAsync and updating the SettingsList

1670
2019/04/21 09:48:07.286
Information
CodeContainerTracing
    Entering CodeContainerStorageManager.AddOrUpdateAsync. CodeContainer path: C:\Users\\VS2019-Source-x64\BetterGetter_build\BetterGetter.sln

1671
2019/04/21 09:48:07.286
Information
CodeContainerTracing
    Entering ObservableSettingsListBase.AddOrUpdateAsync. Item key: C:\Users\\VS2019-Source-x64\BetterGetter_build\BetterGetter.sln, Item value: Microsoft.VisualStudio.Shell.CodeContainerManagement.CodeContainer

1672
2019/04/21 09:48:07.286
Information
CodeContainerTracing
    Entering ObservableSettingsListBase.AddToFrontAsync and updating the SettingsList

1673
2019/04/21 09:48:07.288
Information
Manage Visual Studio Performance
    End execution cost summary for SolutionLoad scenario and VSPackage component

1674
2019/04/21 09:48:07.288
Information
Manage Visual Studio Performance
    Component: f1c25864-3097-11d2-a5c5-00c04f7968b4, Inclusive Cost: 151.5666, Exclusive Cost: 139.5988, Top Level Inclusive Cost: 151.5666
{F1C25864-3097-11D2-A5C5-00C04F7968B4}

1675
2019/04/21 09:48:07.288
Information
Manage Visual Studio Performance
    Component: e269b994-ef71-4ce0-8bcd-581c217372e8, Inclusive Cost: 148.6028, Exclusive Cost: 148.6028, Top Level Inclusive Cost: 0
{E269B994-EF71-4CE0-8BCD-581C217372E8}

1676
2019/04/21 09:48:07.288
Information
Manage Visual Studio Performance
    Component: 1b027a40-8f43-11d0-8d11-00a0c91bc942, Inclusive Cost: 347.0998, Exclusive Cost: 142.6478, Top Level Inclusive Cost: 347.0998
{1B027A40-8F43-11D0-8D11-00A0C91BC942}

1677
2019/04/21 09:48:07.288
Information
Manage Visual Studio Performance
    Component: a9405ae6-9ac6-4f0e-a03f-7afe45f6fcb7, Inclusive Cost: 248.3325, Exclusive Cost: 216.4437, Top Level Inclusive Cost: 248.3325
{A9405AE6-9AC6-4F0E-A03F-7AFE45F6FCB7}

1678
2019/04/21 09:48:07.288
Information
Manage Visual Studio Performance
    End execution cost summary for SolutionLoad scenario and VSPackage component

1679
2019/04/21 09:48:07.288
Information
Manage Visual Studio Performance
    End execution cost summary for SolutionLoad scenario and ToolWindow component

1680
2019/04/21 09:48:07.288
Information
Manage Visual Studio Performance
    Component: 3ae79031-e1bc-11d0-8f78-00a0c9110057, Inclusive Cost: 174.5099, Exclusive Cost: 174.5099, Top Level Inclusive Cost: 174.5099
{3AE79031-E1BC-11D0-8F78-00A0C9110057}

1681
2019/04/21 09:48:07.288
Information
Manage Visual Studio Performance
    End execution cost summary for SolutionLoad scenario and ToolWindow component

1682
2019/04/21 09:48:07.561
Information
VSPackage
    Parsing compatibiliy list file for VS assemblies that should not be in GAC - C:\Users\\AppData\Local\Microsoft\VisualStudio\16.0_08d1afd8\Extensions\CompatibilityList.xml

1683
2019/04/21 09:48:07.561
Information
VSPackage
    Should automatically check for an update

1684
2019/04/21 09:48:07.562
Information
VSPackage
    Checking for an update now

1685
2019/04/21 09:48:08.527
Information
VisualStudio
    Begin package load [TestMethodAssociationPackage]
{062C4CFB-AE76-4913-BE8D-FF1F84AFCA14}

1686
2019/04/21 09:48:08.528
Information
VisualStudio
    End package load [TestMethodAssociationPackage]
{062C4CFB-AE76-4913-BE8D-FF1F84AFCA14}

1687
2019/04/21 09:48:08.571
Information
PromotionsFramework
    Triggered promotion with RuleId: FA900934-7FD0-4DED-A500-47CC9B2E7327

1688
2019/04/21 09:48:08.576
Information
VisualStudio
    Begin package load [Visual Studio COM+ Library Manager Package]
{ED8979BC-B02F-4DA9-A667-D3256C36220A}

1689
2019/04/21 09:48:08.577
Information
VisualStudio
    Loading UI library
{ED8979BC-B02F-4DA9-A667-D3256C36220A}
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\*\msenvui.dll

1690
2019/04/21 09:48:08.577
Information
VisualStudio
    End package load [Visual Studio COM+ Library Manager Package]
{ED8979BC-B02F-4DA9-A667-D3256C36220A}

1691
2019/04/21 09:48:08.757
Information
PromotionsFramework
    Shown promotion with RuleId: FA900934-7FD0-4DED-A500-47CC9B2E7327

1692
2019/04/21 09:48:09.845
Information
VSPackage
    Next update check in '86400000' ms

1693
2019/04/21 09:48:09.938
Information
VisualStudio
    Begin package load [RestoreManagerPackage]
{2B52AC92-4551-426D-BD34-C6D7D9FDD1C5}

1694
2019/04/21 09:48:09.955
Information
VisualStudio
    End package load [RestoreManagerPackage]
{2B52AC92-4551-426D-BD34-C6D7D9FDD1C5}

1695
2019/04/21 09:48:09.971
Information
VisualStudio
    Begin package load [Scc Display Information]
{D7BB9305-5804-4F92-9CFE-119F4CB0563B}

1696
2019/04/21 09:48:10.004
Information
VisualStudio
    End package load [Scc Display Information]
{D7BB9305-5804-4F92-9CFE-119F4CB0563B}

1697
2019/04/21 09:48:10.024
Information
VisualStudio
    Begin package load [BoostTestPackage]
{6E0D1C7A-EF6A-4442-B8CE-9A58B21C3239}

1698
2019/04/21 09:48:10.453
Information
VisualStudio
    End package load [BoostTestPackage]
{6E0D1C7A-EF6A-4442-B8CE-9A58B21C3239}

1699
2019/04/21 09:48:10.463
Information
VisualStudio
    Begin package load [GoogleTestExtensionOptionsPage]
{6FAC3232-DF1D-400A-95AC-7DAEAAEE74AC}

1700
2019/04/21 09:48:10.484
Information
VisualStudio
    End package load [GoogleTestExtensionOptionsPage]
{6FAC3232-DF1D-400A-95AC-7DAEAAEE74AC}

1701
2019/04/21 09:48:10.534
Information
VisualStudio
    Begin package load [Tab Designer Launcher]
{B4E787A4-A9FC-4579-945E-D71AFEC4DD90}

1702
2019/04/21 09:48:10.535
Information
VisualStudio
    End package load [Tab Designer Launcher]
{B4E787A4-A9FC-4579-945E-D71AFEC4DD90}

1703
2019/04/21 09:48:10.552
Information
VisualStudio
    Begin package load [RunClangPowerToolsPackage]
{F564F9D3-01AE-493E-883B-18DEEBDB975E}

1704
2019/04/21 09:48:10.570
Information
Package Framework
    Initialized ServiceProvider.GlobalProvider from SetSite.

1705
2019/04/21 09:48:10.570
Information
Package Framework
    Initialized AsyncServiceProvider.GlobalProvider from SetSite.

1706
2019/04/21 09:48:10.647
Error
VisualStudio
    SetSite failed for package [RunClangPowerToolsPackage]Source: 'System.Xml' Description: There is an error in XML document (0, 0).
System.InvalidOperationException: There is an error in XML document (0, 0). ---> System.Xml.XmlException: Root element is missing.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XmlTextReader.Read()
   at System.Xml.XmlReader.MoveToContent()
   at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderClangTidyOptions.Read6_ClangTidyOptions()
   --- End of inner exception stack trace ---
   at System.Xml.Serialization.XmlSerializer.Deserialize(XmlReader xmlReader, String encodingStyle, XmlDeserializationEvents events)
   at System.Xml.Serialization.XmlSerializer.Deserialize(Stream stream)
   at ClangPowerTools.XmlSerializer.DeserializeFromFile[T](String aFilePath)
   at ClangPowerTools.ConfigurationPage`1.LoadFromFile(String aFilePath)
   at ClangPowerTools.ClangTidyOptionsView.LoadSettingsFromStorage()
   at Microsoft.VisualStudio.Shell.DialogPage.set_Site(ISite value)
   at System.ComponentModel.Container.Add(IComponent component, String name)
   at System.ComponentModel.Container.Add(IComponent component)
   at Microsoft.VisualStudio.Shell.Package.GetDialogPage(Type dialogPageType)
   at ClangPowerTools.SettingsProvider.Initialize(AsyncPackage aPackage)
   at ClangPowerTools.RunClangPowerToolsPackage.<InitializeAsync>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Shell.AsyncPackage.<>c__DisplayClass16_0.<<Microsoft-VisualStudio-Shell-Interop-IAsyncLoadablePackageInitialize-Initialize>b__1>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Threading.JoinableTask.<JoinAsync>d__68.MoveNext()System.Xml.XmlException: Root element is missing.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XmlTextReader.Read()
   at System.Xml.XmlReader.MoveToContent()
   at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderClangTidyOptions.Read6_ClangTidyOptions()
{F564F9D3-01AE-493E-883B-18DEEBDB975E}
80131509

1707
2019/04/21 09:48:10.652
Error
VisualStudio
    End package load [RunClangPowerToolsPackage]
{F564F9D3-01AE-493E-883B-18DEEBDB975E}
80131509

Hi,
Unfortunately, we cannot reproduce this issue. Can you send us a sample project for testing? Any other information is highly appreciated.

Did the GUI change? I also got a crash during an install and for the life of me can not get ANYTHING to show up anywhere in any menus etc. It finally installed after 3rd attempt, and appears installed in Manage Extensions, but I can't find anything at all related to it. Worked fine in 2017, but not working at all in 2019 unless the GUI entirely changed and I'm missing something, which I believe might be the case????

Hi,
Maybe something went wrong with the installation system and the config files got corrupted. Just to be sure, please try to make another fresh install, but this time removing the config files. To do this you need to follow the next steps:

Uninstall Clang Power Tools from Visual Studio
Manually delete the user config files from %AppData%/ClangPowerTools
Open Visual Studio and install the Clang Power Tools again

If the issue is still reproducing after these steps please let me know.

Thanks for the instructions on how to delete ClangPowerTools settings. I re-installed Visual Studio, and then found these instructions and did a clean re-install of ClangPowerTools, and now things seems to be working properly. So I'm going to write off what happened as a one-time fluke, and close this issue. :)


Use send to change _filter/_action callbacks for Rails 5

This change renames the before_filter and after_filter calls to be Rails 5 compatible. It is based on the feedback in PR #315.
I've been running this patch in production and it's working well.
Sorry to open a duplicative PR, but I didn't hear back from @terracatta when I opened a PR against their PR: https://github.com/terracatta/vanity/pull/1
Thank you for this awesome gem.

Thanks @bensheldon! Can you squash the first three commits into just one? Otherwise, looks good to me.

@phillbaker I squashed down to a single commit.


Bot Markup seems to be broken?

Hello, sometimes the bot gets stuck when buying coins using my own script plugin.
order status: rejected, bid: 0.00000103, -0.00000001 below best bid, 0.0% filled
order status: rejected, bid: 0.00000103, -0.00000001 below best bid, 0.0% filled
order status: rejected, bid: 0.00000103, -0.00000001 below best bid, 0.0% filled
order status: rejected, bid: 0.00000103, -0.00000001 below best bid, 0.0% filled
order status: rejected, bid: 0.00000103, -0.00000001 below best bid, 0.0% filled
order status: rejected, bid: 0.00000103, -0.00000001 below best bid, 0.0% filled
^C
[root@www zenbot]# ./zenbot.sh buy --buy_pct=100 --order_type=maker --markup_pct=-1 --order_adjust_time=1000 poloniex.DOGE-BTC
I want to buy at a higher  price so that my transactions go smoothly, but all I get is rejected.
Thanks for fixing this loop by the way!!!

`
import json
import requests
import re
import unicodedata
import subprocess
import os
import sqlite3
import time
from decimal import *
flag = "undefined"
##Main App Loop
while True:
##DB Refresh
os.remove('/example.db')
print("File Removed!")
conn = sqlite3.connect('/example.db')
c = conn.cursor()
c.execute('''CREATE TABLE gains (ke4,pct1,dips)''')
wjdata = requests.get('https://poloniex.com/public?command=returnTicker&period=60').json()
##Load Initial Data
for key in wjdata:
if re.match(r'BTC_+', key):
ke1=key.replace('', '-')
ke2=ke1.replace('BTC-', '')
ke3='-BTC'
ke9=ke2+ke3
pct=(wjdata[key]['last'])
pct0=Decimal(pct)
pct1=format(pct0, 'f')
print(ke9)
print(pct1)
dips='undefined'
c.execute("INSERT INTO gains VALUES (?, ?, ?);", (ke9, pct1, dips))
conn.commit()
print('Waiting some time for comparison...')
time.sleep(180)
wjdata = requests.get('https://poloniex.com/public?command=returnTicker&period=60').json()
##Load the second Data
for key in wjdata:
if re.match(r'BTC+', key):
ke1=key.replace('_', '-')
ke2=ke1.replace('BTC-', '')
ke3='-BTC'
ke4=ke2+ke3
pct2=(wjdata[key]['last'])
pct3=Decimal(pct2)
dips=format(pct3, 'f')
print(ke4)
print(dips)
c.execute('UPDATE gains SET dips = ? WHERE ke4 = ?;', (dips, ke4))
conn.commit()
for row in c.execute('SELECT ke4, (dips-pct1) as diff FROM gains ORDER BY diff DESC LIMIT 1;'):
print(row)
row=str(tuple(row))
ro1=row.replace("u", '')
ro2=ro1.replace("'", '')
ro3=ro2.replace('(', '')
ro4=ro3.replace(')', '')
ro5=ro4.replace(",", '')
s = ro5
s=re.sub('\d', '', s)
ros=s.replace(".", '')
if flag == ros:
print(ros)
print(flag)
print ('Current Profitable Coin Is The Same!')
else:
print(ros)
print(flag)
sell=subprocess.call('./zenbot.sh sell --sell_pct=100 poloniex.'+flag,shell=True)
buy=subprocess.call('./zenbot.sh buy --buy_pct=100 poloniex.'+ros,shell=True)
flag=ros
`

--order_adjust_time=1 seems to work... But, I had to edit my config too I think (the default one) to:
// Order execution rules:

// avoid trading at a slippage above this pct
c.max_slippage_pct = 5
// buy with this % of currency balance
c.buy_pct = 99
// sell with this % of asset balance
c.sell_pct = 99
// ms to adjust non-filled order after
c.order_adjust_time = 1000
// avoid selling at a loss below this pct
c.max_sell_loss_pct = 25
// ms to poll order status
c.order_poll_time = 1000
// ms to wait for settlement (after an order cancel)
c.wait_for_settlement = 5000
// % to mark up or down price for orders
c.markup_pct = 0
// become a market taker (high fees) or a market maker (low fees)
c.order_type = 'taker'

No dice, I updated zenbot to the latest and it's just now says placing order when run from my script.
But is fine from the command line.


[FEATURE REQUEST] Prevent installers from adding shortcuts to the desktop

Please confirm these before moving forward

[X] I have searched for my feature proposal and have not found a work-in-progress/duplicate/resolved/discarded issue.
[X] This proposal is a completely new feature. If you want to suggest an improvement or an enhancement, please use this template

Describe the new feature
The feature could work in two ways with option 1 probably be preferrable.

Monitor the state of the desktop during installation and if there are new app shortcuts created during an install, potentially with some fuzzy matching, then they are automatically deleted.
The tool could switch the Desktop to read only during updates and installs and toggle back when done.

Describe how this new feature could help users.
One of the most annoying things about software installers on Windows is that the majority take liberty with automatically creating a desktop shortcut and there is no formal way of preventing that. I suggest an experimental feature where WingetUI can help with this when updating/installing through its interface.

Duplicate of https://github.com/marticliment/WingetUI/issues/624


fix: updated docker file to use lock file if it's present, if it's no…

Description
this is the PR for the Isuue - #33743
Updates in Pr:

modified the dockerfile to copy package files and RUN based on lock file availability.
modified the ENTRYPOINT command , to resolve the  path which is causing error during the build process.

Description about the chnaged code:
1.the new code main check for the lock file , if its present then it install the depencies from lock file
, if its not there then it install the dependecies through the package.json file.
the new code main deals with this also updated few lines to avoid the errors while generting the image
for the project.
2.EntryPoint is commentted and its written in the RUN along by providing the permission to the file
""chmod +x /deploy/docker/fs/entrypoint.sh "".
3.In Docker, it's a good practice to use /opt/bin as a directory to store custom binaries and scripts
that you want to include in your Docker image. This directory is then added to the PATH environment
variable, allowing the executables within it to be easily run from anywhere in the container.
In the code, I have used /opt instead of /opt/bin. There is not much difference between them, and it
does not cause any errors. Both /opt and /opt/bin are acceptable, but /opt/bin is commonly used for
rganizing custom executables.
I have tested it locally with appsmith project as well as other project containing lock file.It was working fine.
Below are the screenshots attached from build docker image to running the container and listing the files inside the image:

@srix @ayushpahwa

Summary by CodeRabbit

Chores

Improved Dockerfile structure and efficiency.
Updated directory creation, permission settings, and file copying processes.
Modified environment variables for better integration.
Adjusted health check command for more reliable performance.

Hello @srix  @ayushpahwa ,
I hope you're well. I’m curious and excited to hear your thoughts on my pull request raised a while ago. Looking forward to your review!
Thank you.

Hii @srix @ayushpahwa ,
Could you please review this PR.
thank you.

Hii @srix @ayushpahwa ,
Could you please review or assign reviewers to this PR.
thank you.

Hii @srix @ayushpahwa @Nikhil-Nandagopal  @rohan-arthur ,
Could you please review or assign reviewers to this PR.
thank you.

I dont see my earlier comments resolved


Integrate Bas's remediation tasks script into Create-AzRemediationTasks

Create-AzRemediationTasks is more sophisticated in creating the tasks
Bas's script has interesting features dealing with task failures: https://techcommunity.microsoft.com/t5/core-infrastructure-and-security/use-powershell-to-remediate-non-compliant-policy-definitions/ba-p/3878321

This task is to combine them to gain the best of both approaches.
Stretch: support GitHub Issues (in addition to ADO work items

I like the approach. Separate scripts for GH and ADO is the better approach.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Bas van Bennekom @.>
Sent: Monday, August 14, 2023 6:33:37 AM
To: Azure/enterprise-azure-policy-as-code @.>
Cc: Mention @.>; Author @.>; Subscribed @.***>
Subject: Re: [Azure/enterprise-azure-policy-as-code] Integrate Bas's remediation tasks script into Create-AzRemediationTasks (Issue #309)
@techlakehttps://github.com/techlake, based on what I have seen in the repository, I propose the following actions.
Create-AzRemediationTasks.ps1

Update the ForEach-Object loop, starting on line 197, with the logic to add failed remediation tasks to a new variable (e.g. failedPolicyRemediationTasks)
Output the new variable to the pipeline so that the failed remediation tasks can be used in the next script

Create-AzureDevOpsBug

Create a new PowerShell script that creates a Bug on the current iteration of a team
The bug is formatted as a HTML table and should contain all the failed remediation tasks that have been exported from the Create-AzRemediationTasks.ps1 PowerShell script

For now, I propose to have a separate PowerShell script for Azure DevOps and GitHub. However, if you prefer to have one script, I will create two function and build a PowerShell script around that.
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/enterprise-azure-policy-as-code/issues/309#issuecomment-1677155789 or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABTITRILSFJU6MTGJI54HWTXVIEJDBFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZDOMRVHE4DSNBYGOSG4YLNMWUWQYLTL5WGCYTFNSWHG5LCNJSWG5C7OR4XAZNMJFZXG5LFINXW23LFNZ2KM5DPOBUWG44TQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJTGM3TCNRSHAZTRAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDCOBUG4ZTGNJVHA2YFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIZDOMRVHE4DSNBYGOTXI4TJM5TWK4VGMNZGKYLUMU.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Done!


Getting Started

I've run through the getting started and setup my inventory.ini but what command do I need to run to start the deploy phases?

Hi, I realize how much time has passed since the opening of this issue. I've been away from this codebase foir personnal reasons and I only saw it 3 months ago. Be sure I am sorry for that. We are actively working on improving the capabilities and the onboarding.
If you are inclined to give a second try, please have a careful look at this updated tutorial : https://hashistack.readthedocs.io/en/latest/tutorials/deploy_scw.html
Also, if you are not deploying on Scaleway, please let me know it right before trying and I will prioritize updating the documentation to give you the technical hints to a successful deployment.
Regards

No worries, I completely understand. I was not planning on deploying to Scaleway. I run my own ESXi server and was going to run Hashistack on a few Debian VMs. Looking forward to trying to get this to run.

By next week, I'll provide some hints in the documentation to ease your path in replacing the stage0 (infrastructure) by your own and validate that everything is ok before starting stage1.
Without being too curious, will you rely on our LetsEncrypt automation (implying a public DNS delegation and exposure) for certificates on supply some prepared by your own mean?

Haven't decided. I do run nginx proxy manager in front of all my websites which handles my LetsEncrypt certs, but not sure  how Hashistack behaves behind a nginx reverse proxy.

Well actually we handle a nginx reverse proxy as front server to load balance to vault, consul and nomad admin webUI and to nomad minions nodes. Adaptation should be quite feasable if you base yourself on our configuration template for examples.
I added the promised documentation right there. I will close this issue but please feel free to open some more when you decide to get your hands dirty.
Again: Thanks for your interest.

Thank you very much for taking the time to add the documentation. If I come across any road blocks, I will be sure to open another issue. Looking forward to getting things up and running.


Screen for lobby

Story #8 Lobby
Sub-Tasks:

[x] CSS
[x] Display all players in the lobby
[x] Mark the creater with icon
[x] Ready button
[x] Start button

Estimate: 7h

c152dc9e887fe4520437f8d1c4ff66c854ac69e9


Add link to the Markdown Guide

I'd like to suggest adding a link to the Markdown Guide. This is a new open source project that is still actively being worked on, but it's complete enough to be useful.
Disclosure: This is my personal website.

Great suggestion, thanks!


MSBuild 14.0.25123.0 not restoring nuget packages

I am not sure if this is a nuget issue or a msbuild issue.  When I build a solution in Visual Studio 2015 Update 2 - all nuget packages are restored 100% correctly and the solution builds.  When I try to build via MSbuild, no packages are restored at all regardless of how I configure my build scripts.
Note: I am now looking into using the nuget.exe command line tool to force a restore, however that also is having issues as it is not restoring specific framework packages (like Microsoft.CSharp).

At the moment, MSBuild does not restore packages; you must run restore as a separate step before invoking MSBuild. That's true in Visual Studio, but it's handled for you. On the command line you must use nuget.exe explicitly.
There's some documentation about this from NuGet: http://docs.nuget.org/consume/package-restore#package-restore-approaches

Thanks, that is what I thought and the command line restore isn't working.  I submitted a possible bug here

Note: It would be great if msbuild would also be able to restore

In MSBuild 15.0 with some of the newer logic, there is now a Restore target.  The target isn't called for you so it still needs to be run first.
MSBuild.exe /Target:Restore
MSBuild 14 won't be getting an update to enable this target so I'm going to close this issue.  We are working closely with the NuGet team to improve the experience in future versions.


Updated to 0.13

All of the mods function (should) remain intact, but it seems to run fine in 0.13 now. I have tried to do the absolute minimum of code changes, but added a small change to the readme. My fork will also include the version 2.0.0 release.
Incremented major version as you can no longer use the mod in 0.12.

Accepted with minor changes. Thanks.


[BUG] Not working all original message transfer protocol

Describe the bug
After we simplified the broadcast/receive protocol, all original examples became not working.
In original system, we directly emit and receive messages as string.
Now, however, the received signal connects to _receivedMessage() slot and it tries to decode the message from json string.
In this procedure, a JSONDecodeError occurs.
To Reproduce
All messages should be changed to go through broadcast() and receivedSlot().

This issue is closed by #140.


fixes possible race condition in getKafkaTopicHandle

fixes #18. also fixied up some topicConfigHandle related stuff.
@edenhill

I'm not sure this fixes the problem, the read and write are still not protected by the same locking.
        private SafeTopicHandle getKafkaTopicHandle(string topic)
        {
            // TODO: We should consider getting rid of these and add proper support in librdkafka itself
            //       (producev() with RD_KAFKA_V_TOPIC() is one step closer)

Checking if topic is in the cache (no lock)

            if (topicHandles.ContainsKey(topic))
            {
                return topicHandles[topic];
            }

            var topicConfigHandle = SafeTopicConfigHandle.Create();
            if (topicConfig != null)
            {
                topicConfig
                    .ToList()
                    .ForEach((kvp) => { topicConfigHandle.Set(kvp.Key, kvp.Value.ToString()); });
            }
            topicConfigHandle.Set("produce.offset.report", "true");
            IntPtr configPtr = topicConfigHandle.DangerousGetHandle();

            // note: there is a possible (benign) race condition here - topicHandle could have already
            // been created for the topic (and possibly added to topicHandles). If the topicHandle has
            // already been created, rdkafka will return it and not create another. the call to rdkafka
            // is threadsafe.
            var topicHandle = kafkaHandle.Topic(topic, configPtr);

Add new rd_kafka_topic_t * object to cache

            topicHandles.Add(topic, topicHandle);

            return topicHandle;
        }

in topicHandles.Add:
       public void Add(TKey key, TValue val)
        {
            lock (writeLockObj)
            {
                if (readDictionary == null)
                {
                    throw new InvalidOperationException("Attempting to add an item to SafeDictionary which has been disposed.");
                }

Check again if topic is in the cache (now with lock)

                if (!readDictionary.ContainsKey(key))
                {
                    Dictionary<TKey, TValue> writeDictionary = new Dictionary<TKey, TValue>(readDictionary);

Only add if not existent

                    writeDictionary.Add(key, val);
                    // this is atomic.
                    readDictionary = writeDictionary;
                }
            }
        }

So it seems the race condition is still there if two or more threads call getKafkaTopicHandle() with the same topic then multiple topic objects will be created and only one of them will be added to the cache.
The proper fix would be to lock the entire 'read-check-create-add' cycle with one single lock taking.
Otherwise there will be multiple topic objects for the same topic and I'm not sure if the ones that are not added to the cache will be cleaned up (every topic_new() must have a corresponding topic_destroy()).

every topic_new() must have a corresponding topic_destroy()
ok, i understood that incorrectly then.
at least the current code won't throw an exception (it'll just leak memory occasionally).
will re-open issue.

:+1:
https://github.com/edenhill/librdkafka/blob/master/src/rdkafka.h#L1626


[fireflyiii] Can't use special characters in DB password

Which addon?

Addon name : fireflyiii
Addon version : 5.6.14-4

Describe the bug
When starting the addon it fails with:
/etc/cont-init.d/99-run.sh: executing
/./etc/cont-init.d/99-run.sh: line 16: QYUI: unbound variable
/etc/cont-init.d/99-run.sh: exiting 1

This QYUI got my attention, because there's nothing like this in the script itself. However, I noticed that my DB password contains the following sequence of characters: [...]$QYUI%[...]. It looks like $[...]% triggers the shell script to treat [...] as a variable, so some escaping is required.
To Reproduce

Set DB password to anything that contains $[...]% sequence of characters.
Try to start the addon.

Full addon log
See description
Full addon config
APP_KEY=base64:
CONFIG_LOCATION=/share/fireflyiii/config.yaml
DB_CONNECTION=mysql
DB_DATABASE=firefly
DB_HOST=core-mariadb
DB_PASSWORD=[...]$QYUI%[...]
DB_PORT=3306
DB_USERNAME=firefly
silent=false
System

Supervisor version: supervisor-2022.01.1
Host system version: Raspbian 10 (buster)

Hi, thanks. I thought I had put the escapes yesterday, I'll check what went wrong

Great work! I now have Firefly III running as Home Assistant addon and can throw away my custom container.


Launcher code observations

all Launcher constructors have the same signature. That is not the intention. Each constructor should accept only arguments that are relevant.
create_launcher contains this complicated code, some of which looks redundant:

    allowed_options = [mode for mode in LaunchMode]
    if (
        not isinstance(fluent_launch_mode, LaunchMode)
        or fluent_launch_mode not in allowed_options
    ):
        raise DisallowedValuesError(
            "fluent_launch_mode",
            fluent_launch_mode,
            allowed_values=allowed_options,
        )

We shouldn't over-validate like this as it complicates the code unnecessarily. The subsequent block can detect if an invalid argument was provided (just add an else clause):
    if fluent_launch_mode == LaunchMode.STANDALONE:
        return StandaloneLauncher(**kwargs)
    elif fluent_launch_mode == LaunchMode.CONTAINER:
        return DockerLauncher(**kwargs)
    elif fluent_launch_mode == LaunchMode.PIM:
        return PIMLauncher(**kwargs)
    elif fluent_launch_mode == LaunchMode.SLURM:
        return SlurmLauncher(**kwargs)

@seanpearsonuk
Regarding (just add an else clause)
I thought we should raise an exception before checking 4 conditions in next block, therefore we have added condition to check this before going forward.
We can also change it as follows but don't you think that it's redundant to raise an exception after checking 4 conditions ?
    if fluent_launch_mode == LaunchMode.STANDALONE:
        return StandaloneLauncher(**kwargs)
    elif fluent_launch_mode == LaunchMode.CONTAINER:
        return DockerLauncher(**kwargs)
    elif fluent_launch_mode == LaunchMode.PIM:
        return PIMLauncher(**kwargs)
    elif fluent_launch_mode == LaunchMode.SLURM:
        return SlurmLauncher(**kwargs)
    else:
        raise DisallowedValuesError(
            "fluent_launch_mode",
            fluent_launch_mode,
            allowed_values=allowed_options,
        )

I think we can remove not isinstance(fluent_launch_mode, LaunchMode)  from the first condition and update it as follows -
    allowed_options = [mode for mode in LaunchMode]
    if fluent_launch_mode not in allowed_options:
        raise DisallowedValuesError(
            "fluent_launch_mode",
            fluent_launch_mode,
            allowed_values=allowed_options,
        )


Commits are not validated for required Properties

If I post a Commit for a resource that is an instance of some class, I might expect it to be validated for required properties. However, this is not yet the case. I think a store should guarantee that every commit does not result in incomplete resources. This also means that it is not always possible to remove a single property from a resource - it will fail if it results in a missing required prop.

Fixed


add usage instructions to readme.md

like which keys to use to navigate the cli or maybe make a builtin help page, like pressing ctrl-h or something

Hi @pointbazaar
that's a nice idea! If you have spare time to implement it, a PR would be very welcome. I don't have in mind all the shortcuts yet for my part.

Seconded, just some basic commands in the README would be great, currently I have no idea how to navigate this, i.e change channel or server.


fails to build on macOS with disabled cuda

I disable cuda
'-DBUILD_CUDA=OFF'

but build fails with undefined symbols that suggest the presence of cuda:
[  2%] Linking CXX shared library libginkgo_cuda.dylib
cd /Users/davydden/spack/var/spack/stage/ginkgo-develop-zeye3v3wrsei5bnsicjkcjkljrbhnriq/ginkgo/spack-build/core/device_hooks && /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/cmake-3.14.0-qpuv2tznpy7mu7zko425s24qbkxcizty/bin/cmake -E cmake_link_script CMakeFiles/ginkgo_cuda.dir/link.txt --verbose=1
/Users/davydden/spack/lib/spack/env/clang/clang++ -O3 -DNDEBUG -dynamiclib -Wl,-headerpad_max_install_names  -o libginkgo_cuda.dylib -install_name @rpath/libginkgo_cuda.dylib CMakeFiles/ginkgo_cuda.dir/cuda_hooks.cpp.o ../devices/cuda/CMakeFiles/ginkgo_cuda_device.dir/executor.cpp.o
Undefined symbols for architecture x86_64:
  "gko::CudaExecutor::mutex", referenced from:
      gko::CudaExecutor::CudaExecutor(int, std::__1::shared_ptr<gko::Executor>) in cuda_hooks.cpp.o
      gko::CudaExecutor::~CudaExecutor() in executor.cpp.o
  "gko::CudaExecutor::num_execs", referenced from:
      gko::CudaExecutor::CudaExecutor(int, std::__1::shared_ptr<gko::Executor>) in cuda_hooks.cpp.o
      gko::CudaExecutor::~CudaExecutor() in executor.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [core/device_hooks/libginkgo_cuda.dylib] Error 1
make[1]: *** [core/device_hooks/CMakeFiles/ginkgo_cuda.dir/all] Error 2
make: *** [all] Error 2

@davydden can you please add the CMakeCache.txt? Thanks!

sure, here you go CMakeCache.txt

wait a second, should that be GINKGO_BUILD_CUDA instead of BUILD_CUDA? but default is still disabled...

@davydden , thank you for identifying this. Yes, we had to add GINKGO_ prefixes to conform to xSDK requirements. I will create a PR with the updated docs on deal.ii soon. I thought I would add it in the next wave when I add a few more of Ginkgo's solvers as well.
Disabling -DGINKGO_BUILD_CUDA actually does disable cudabut not the CudaExecutor paradigm, The philosophy of ginkgo is to have a modular setup and hence the CudaExecutor module in the disabled state just contains some hooks and will consequently have a GKO_NOT_COMPILED/IMPLEMENTED error when one calls something on the cuda executor.
So, it seems that you are having an issue with std::mutex from the C++ standard library. Could you tell us what clang version you are using ? It is not clear to me from the CMakeCache file. Additionally, if you could try running it with gcc instead of clang, that would be great.

I will create a PR with the updated docs on deal.ii soon

thanks 👍

it seems that you are having an issue with std::mutex from the C++ standard library.

Should not be the case, deal.II also uses std::mutex and I have no issues with it there on macOS.

Could you tell us what clang version you are using ?

$ clang --version
Apple LLVM version 10.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

if you could try running it with gcc instead of clang, that would be great.

Unfortunately that's not an option. I build the whole stack of things, and too many things fail to build with gcc on macOS.

it seems that you are having an issue with std::mutex from the C++

btw, how is std::mutex related to
Undefined symbols for architecture x86_64:
"gko::CudaExecutor::mutex"

?

btw, how is std::mutex related to

Sorry, I wrote something that was misleading. We use std::mutex within CudaExecutor to manage when we have multiple CudaExecutors such that we have a count of the number of cuda devices that we have. We had to add this due to an issue with cudaDeviceReset(). So, for some reason, it seems that there is an issue with the variable within the CudaExecutor class gko::CudaExecutor::mutex.

@davydden I am using clang 7 and I encounter problems with some circular dependency that we have not yet resolved. I circumvent that problem by disabling the shared libs. Maybe you can give it a try? (it is an open issue  #203 , sure not a long-term solution)

@davydden You can disable shared libraries with the cmake option -DBUILD_SHARED_LIBS=OFF. Instead of shared libraries (.lib), it will build static libraries .a. It should not make a difference performance wise, but I hope we have a better solution for that in the near future.

@hartwiganzt @thoasm static gives other issues while building:
   906    [ 76%] Built target core_test_solver_cgs
     907    In file included from /Users/davydden/spack/var/spack/stage/ginkgo-develop-alk3r26k56kgsu6an7o3w6ofzfkuw5pg/ginkgo/examples/asynchronous_stopping_criterion/asynchronous_stopping_criterion.cpp:67:
  >> 908    /Users/davydden/spack/var/spack/stage/ginkgo-develop-alk3r26k56kgsu6an7o3w6ofzfkuw5pg/ginkgo/include/ginkgo/ginkgo.hpp:41:10: fatal error: 'ginkgo/**/*.hpp' file not found
     909    #include <ginkgo/**/*.hpp>
     910             ^~~~~~~~~~~~~~~~~
     911    [ 76%] Built target core_test_solver_fcg
     912    1 error generated.
  >> 913    make[2]: *** [examples/asynchronous_stopping_criterion/CMakeFiles/asynchronous_stopping_criterion.dir/asynchronous_stopping_criterion.cpp.o] Error 1
  >> 914    make[1]: *** [examples/asynchronous_stopping_criterion/CMakeFiles/asynchronous_stopping_criterion.dir/all] Error 2

Interesting, it looks like your shell does not know the ** expression that we use to update our global header file.
Temporarily, you can disable the check if any header was put into include/ginkgo/ by removing the following lines from the global CMakeLists.txt:
add_custom_target(generate_ginkgo_header ALL
        COMMAND ${Ginkgo_SOURCE_DIR}/dev_tools/scripts/update_ginkgo_header.sh
        WORKING_DIRECTORY ${Ginkgo_SOURCE_DIR})

After removing this part, it should work fine because we have the global header file include/ginkgo/ginkgo.hpp in git already.
I also created the issue #272 to tackle this problem, so this temporary solution will no longer necessary.

@thoasm

Temporarily, you can disable the check

unfortunately, that leads to other errors:
    1002    /Applications/Xcode.app/Contents/Developer/usr/bin/make -f benchmark/solver/CMakeFiles/solver.dir/build.make benchmark/solver/CMakeFiles/solver.dir/build
     1003    [ 92%] Building CXX object benchmark/solver/CMakeFiles/solver.dir/solver.cpp.o
     1004    cd /Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo/spack-build/benchmark/solver && /Users/davydden/spack/lib/spack/env/clang/clang++   -I/Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl7
             53pipvjq2u5/ginkgo/spack-build/include -I/Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo/include -I/Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo -I/Users/davydden/s
             pack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo/spack-build/third_party/rapidjson/src/include -isystem /Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo/spack-build/third_party/gflags/b
             uild/include  -O3 -DNDEBUG   -std=gnu++11 -o CMakeFiles/solver.dir/solver.cpp.o -c /Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo/benchmark/solver/solver.cpp
     1005    In file included from /Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo/benchmark/matrix_statistics/matrix_statistics.cpp:44:
     1006    In file included from /Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo/benchmark/utils/general.hpp:54:
  >> 1007    /Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo/spack-build/third_party/rapidjson/src/include/rapidjson/document.h:872:22: error: call to constructor of 'rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson:
             :MemoryPoolAllocator<rapidjson::CrtAllocator> >' is ambiguous
     1008            GenericValue v(value);
     1009                         ^ ~~~~~
     1010    /Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo/benchmark/utils/general.hpp:115:22: note: in instantiation of function template specialization 'rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::MemoryPoo
             lAllocator<rapidjson::CrtAllocator> >::operator=<unsigned long>' requested here
     1011            object[name] = std::forward<T>(value);
     1012                         ^
     1013    /Users/davydden/spack/var/spack/stage/ginkgo-develop-nhrsjtztfvapqtaiyqnl753pipvjq2u5/ginkgo/benchmark/matrix_statistics/matrix_statistics.cpp:123:5: note: in instantiation of function template specialization 'add_or_set_member<const unsigned long &, char
             const (&)[4], rapidjson::MemoryPoolAllocator<rapidjson::CrtAllocator> &>' requested here

disabling the benchmarks in cmake (-DGINKGO_BUILD_BENCHMARKS=OFF) should be the last thing that you need to do in order for Ginkgo to work on your system

thanks, that allowed me to build ginkgo indeed.

Thanks a lot for your report @davydden. All the issues you found should now be fixed after the following PRs:
#278
#274
#272

thanks!


Add solves information to /api/scoreboard for each team

It would be easier to write a chatter bot if the /api/scoreboard endpoint returned solved information (similar to /api/categories) - as we could then report on ladder changes, when challenges were solved by who, etc.
(additionally, it means not having to mess around with /api/categories which doesn't allow anonymous access).

That's going to add a bit of overhead to an endpoint that gets hit a lot.  (As it is, I'm not convinced it should be added to /api/categories, I thought you were using /api/challenge?)

/api/challenges will do the trick


Remove old false-positive from baseline

This false positive was fixed at #4249 so we can remove this line from the baseline.

Ok... It seems that the fix is not applied to our own codebase yet. I'll rebase this in the next release.

Blocked by #4242


Allow for stripped LVM storage volumes

As a sysadmin, sometimes I would like to be able to create a striped lvm logical volume to use as a backing store for a container to take advantage of its performance characteristics. Currently, it appears that lxd does not provide a mechanism to do this. Special options would need to be passed to lvcreate by lxd to accomplish this. Without these options, the underlying vg will be used as a concatenated (linear) volume rather than a stripe, since lvcreate will not be "told" to set up the logical volume as a stripe.
Proposed solution: at container creation time, provide a mechansim for a sysadmin to specify parameters to be used for creating the thinpool to allow optimal use of the LVM volume group. Also allow a sysadmin to set defaults as desired. I am not sure where the best place for this is, but I could see the option varying per container. But it does need to be set at container creation time.

A LVM specific option on the storage pool, similar to that we have for thinpool would likely be acceptable, though I don't expect us to have much of an interest in doing this work, so we'd need someone who cares about this to send a pull request.

I could potentially send you a pull request -- can you give me an idea on the optimal way to specify this option -- either command-line -- or where it would be stored -- in which part of the config? And it's preferred name?

Also wondering if maybe there should be some user-friendly option for creation like lxc launch --lvm_mode=striped, which would reference some specific some specific configuration defined somewhere else? Is there any way that these default settings could be placed inside profiles?

I guess my dilemma is this... As a sysadmin, when I do create a container with "special options" for the underlying storage pool, I would like a way -- after the fact -- to be able to "see" that I did this, so I can know that I did it without doing a deep dive into the storage technology to re-discover it.
So I am wondering what the best way would be to store this information in lxd. Maybe a container-specific configuration variable that can only be set on creation time, but is immutable after the container is created? If you can give me some hints about this part and the best way to approach it from an lxd perspective, then I should be able to come up with a patch that is more suitable to be merged upstream, rather than a "hack" :)

Hi, I'm a student taking a virtualization class at UT Austin, and I'm currently collaborating with two others. @stgraber Is it possible that we can get more information about this issue if it's still available?

So my understanding of that LVM feature is pretty limited so we'll need @danielrobbins to confirm that this would work for him. My understanding is that for striping, you'll want to configure both the number of stripes and the stripe size.
For LXD, we'll want this applied on a per-volume basis with support for a default volume as would typically be used for creating a new container from an image.
So I think we'd be looking at adding two pool config keys:

volume.lvm.stripes (must be >= 1, defaults to 1, no striping options passed if it's <= 1)
volume.lvm.stripes.size (amount of bytes (with our usual suffix support), default is empty and causes lvcreate to use the default)

And the matching keys for the volumes:

lvm.stripes
lvm.stripes.size

If lvm.stripes is set to > 1, then the -i option will be passed to lvcreate, if lvm.stripes.size is set as well, then both -i and -I will be passed.

Thank you for the additional info! I'm one of @mparfan 's collaborators, we're interested in this one as well, just pending instructor approval.

Cool, let me know when you get the go ahead and I'll assign it to the two of you.

Hi @stgraber , we're approved! Could you assign @lay-ton @mparfan and I?

Hi @rcash I've assigned it to you and @mparfan, I can't assign to @Lay-ton as Github won't let me assign to someone who hasn't commented in the issue.

Hello, could you assign me as well?

Hi @stgraber, I just wanted to give a status update since we've been silent for a few days and need some help/clarification on setting the volume keys.
We've spent awhile reading through files relevant to the issue and have added the storage pool config keys (volume.lvm.stripes and volume.lvm.stripes.size) and currently set the default number of stripes (volume.lvm.stripes) in StoragePoolCreate(). Where should the corresponding volume keys (changeableStoragePoolVolumeProperties for these be set? When the storage pool is created, when the volume is created, or another place? Our current assumption is the user will do something like lxc storage create poolA lvm volume.lvm.stripes=2 volume.lvm.stripes.size=64kB and the volumes that follow suit from this command will be striped like that as a result.

lvm.stripes and lvm.stripes.size  should go in changeableStoragePoolVolumeProperties, StorageVolumeConfigKeys and VolumeValidateConfig.
One quick way to see pretty much everywhere changes are needed would be to look for zfs.use_refquota which is a similar key in the zfs backend.
stgraber@castiana:~/data/code/lxc/lxd (lxc/master)$ grep -r zfs\.use_refquota . | grep -v storage\.zfs
./lxd/patches.go:			if !shared.IsTrue(pool.Config["volume.zfs.use_refquota"]) {
./lxd/patches.go:				pool.Config["volume.zfs.use_refquota"] = ""
./lxd/patches.go:				if !shared.IsTrue(volume.Config["zfs.use_refquota"]) {
./lxd/patches.go:					volume.Config["zfs.use_refquota"] = ""
./lxd/storage_pools_config.go:		"volume.zfs.use_refquota",
./lxd/storage_pools_config.go:	"volume.zfs.use_refquota":     shared.IsBool,
./lxd/storage_volumes_config.go:		"zfs.use_refquota",
./lxd/storage/utils.go:	"zfs.use_refquota": func(value string) ([]string, error) {
./lxd/storage/utils.go:			if config["zfs.use_refquota"] != "" {
./lxd/storage/utils.go:				return fmt.Errorf("the key volume.zfs.use_refquota cannot be used with non zfs storage volumes")
./test/suites/storage.sh:      lxc storage create "lxdtest-$(basename "${LXD_DIR}")-valid-zfs-pool-config" zfs volume.zfs.use_refquota=true
./test/suites/storage.sh:      ! lxc storage create "lxdtest-$(basename "${LXD_DIR}")-invalid-btrfs-pool-config" btrfs volume.zfs.use_refquota=true || false
./test/suites/storage.sh:    ! lxc storage create "lxdtest-$(basename "${LXD_DIR}")-invalid-dir-pool-config" dir volume.zfs.use_refquota=true || false
./test/suites/storage.sh:      ! lxc storage create "lxdtest-$(basename "${LXD_DIR}")-invalid-lvm-pool-config" lvm volume.zfs_use_refquota=true || false
./test/suites/storage.sh:      lxc storage volume set "lxdtest-$(basename "${LXD_DIR}")-pool1" c1pool1 zfs.use_refquota true
./scripts/bash/lxd-client:      volume.zfs.use_refquota zfs.clone_copy zfs.pool_name"
./scripts/bash/lxd-client:      security.unmapped security.shifted zfs.remove_snapshots zfs.use_refquota"

Hi @stgraber , we've implemented all the logic that we think is necessary to support striped volumes, however, we're running into some issues testing lvcreate-are there instances where where striping is not valid on thinly provisioned volumes (such on when there is only one physical volume in a volume group)?
This is the error we've been seeing when trying to create a striped thin volume here.
Error: Error Creating LVM LV for new image: Could not create thin LV named custom_vol0: Failed to run: lvcreate -i 2 -I 64K -Wy --yes --thin -n custom_vol0 --virtualsize 10GB poolA/LXDThinPool: Command does not accept option: --stripes 2.   Command does not accept option: --stripesize 64K
This is the underlying volume group:
  VG    #PV #LV #SN Attr   VSize   VFree   poolA   1   1   0 wz--n- <27.94g    0
We understand you mentioned not knowing much about this part of lvm, but any help from you or someone you could recommend would be appreciated.

Does it work when using normal volumes rather than thin pools?

Yes it looks like when using thin volumes its the thin pool lvm that needs the stripe settings.
"A thin pool can be striped like any other logical volume. All the thin volumes created from the pool inherit that settings - do not specify it manually when creating a thin volume. " https://wiki.gentoo.org/wiki/LVM


Fix: OpenSSL build

:tada: This PR is included in version 0.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Elm won't install in npm v5

The new version of elm imposes some additional safety constraints on build scripts. You can work around this using npm install -g elm --unsafe-perm=true --allow-root, which bypasses the new checks. It would be helpful to have this on the website.
I'd submit a PR but my haskell version is 8 (arch linux), so I can't follow the build instructions.

The recommended approach for npm permission issues is to change its default installation location. (By recommended, I mean this is what we recommend people do on Slack)
This is probably useful to add to the instructions.

Not sure any action to take here. Should this live on the elm-platform repo? Are there changes to make to this website? @zwilias can make a new issue in the right place if needed.


applications/editors/mg is broken on darwin

Describe the bug
The package mg is broken on darwin
To Reproduce

nix-env -iA nixpkgs.mg

Expected behavior
The package should install, but it attempts to build the derivation from source (as it obviously isn't cached), and then fails.
Build log
building '/nix/store/cfnfqnwiwwnb8c6hzfnfkrmwxwvi2xly-mg-20171014.drv'...
unpacking sources
unpacking source archive /nix/store/5nypk0lfxqx8xwkpd27qma01568zlrpf-mg-20171014.tar.gz
source root is mg-20171014
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file mg-20171014/README.md
patching sources
configuring
no configure script, doing nothing
building
build flags: -j4 -l4 SHELL=/nix/store/5cxnav5r00f9w7kh1nyfv55vajqzwyyy-bash-4.4-p23/bin/bash PKG_CONFIG=/nix/store/xms65ifdiaxd45paqwmh9hig4yzrj9zj-pkg-config-0.29.2/bin/pkg-config
clang -O2 -pipe -g -Wall -Wno-strict-aliasing -Wno-deprecated-declarations -DREGEX -D_GNU_SOURCE -DLIBBSD_OVERLAY -isystem /nix/store/a9zswhinyrzmqc560qk9sfj6a4c7m3n5-libbsd-0.9.1/include/bsd -D__dead=__dead2 -c autoexec.c
In file included from autoexec.c:10:
In file included from /nix/store/a9zswhinyrzmqc560qk9sfj6a4c7m3n5-libbsd-0.9.1/include/bsd/string.h:28:
In file included from /nix/store/3j24bxhc35hwcby810ah2khihk4pl2ia-Libsystem-osx-10.12.6/include/string.h:182:
In file included from /nix/store/3j24bxhc35hwcby810ah2khihk4pl2ia-Libsystem-osx-10.12.6/include/strings.h:92:
/nix/store/a9zswhinyrzmqc560qk9sfj6a4c7m3n5-libbsd-0.9.1/include/bsd/string.h:57:6: error: conflicting types for 'strmode'
void strmode(mode_t mode, char *str);
     ^
/nix/store/3j24bxhc35hwcby810ah2khihk4pl2ia-Libsystem-osx-10.12.6/include/string.h:164:7: note: previous declaration is here
void     strmode(int __mode, char *__bp);
         ^
1 error generated.
make: *** [GNUmakefile:63: autoexec.o] Error 1
builder for '/nix/store/cfnfqnwiwwnb8c6hzfnfkrmwxwvi2xly-mg-20171014.drv' failed with exit code 2
error: build of '/nix/store/cfnfqnwiwwnb8c6hzfnfkrmwxwvi2xly-mg-20171014.drv' failed

Additional context
I did manage to build this some months ago from the source repo - there are at least two portable mg versions that I know of, both being similar apart from a few patches and build changes. I believe this is related to the two definitions of the same function, in libbsd and in the system libraries.
Homebrew and macports carry https://github.com/ibara/mg. Fink does not package it. Debian and many Linux distributions carry https://github.com/hboetes/mg. NetBSD pkgsrc carries the hboetes version albeit from 2011 (!).
This applies to the same version in 19.09 and nixpkgs-unstable.
Maintainer information:
- nixpkgs.mg

Closing because fixed.


Use kube-state-metrics jsonnet dependency

As kube-state-metrics now has switched to including jsonnet we should remove ours in favour of that and bring it in as a dependency. Same goes for the alerts.
See https://github.com/coreos/kube-prometheus/pull/368#issuecomment-572694051

I think this can be closed now. If we need to do follow up we can open a new issue.


DBZ-4451 Store previous table id in alter schema change events

https://issues.redhat.com/browse/DBZ-4451
The originally reported issue above discussed an error that was raised by the connector when tables were renamed.  This error was due to the fact that the in-memory schema would contain both the previous table with the old name and the new table with the new name after the ALTER TABLE abc RENAME TO xyz DDL statement.
We've relaxed the checks in the streaming source so that we no longer hard fault on this condition but one of the remaining tasks was to address the contents of the in-memory schema.
This change introduces a new field to the tableChanges document called previousId.  This field is designed to carry the prior table's identifier when an ALTER event occurs that renames the table.  This allows us to automatically remove the old table from the in-memory schema and leave only the current representation during recovery.
Because this field is new and is expected to be optional, it should be safe & backward compatible.
This PR supersedes #3158

Added Db2 sibling PR to align code changes made to SchemaChangeEvent, see https://github.com/debezium/debezium-connector-db2/pull/60

@Naros Applied, thanks!


info added about the ordering of the export file

@J535D165 is record_id also added to the export file? if so, we need to add this to the documentation as well

Yes, it is.

@J535D165 and just to be sure: record_id is row number of the data as uploaded and starting at zero

If present, the variable record_id contains the values of the record_id column. Otherwise, ASReview generates a new record_id, based on the row number and starting at 0.

Thanks, nice contribution!


Add Devconsole.ts, typescript based utility console

Description
Devconsole.ts is a command-line utility to quickly work with wallet-core library.
It is based on node typescript console, and uses the WASM version of wallet-core.
Related to #2422 .
How to test
cd samples/typescript/devconsole.ts
npm install
npm run build
npm run start

type:
> help()
This is an interactive typescript shell, to work with wallet-core (wasm)
You can use:
...
> w1 = HDWallet.create(256, '')
W {}
> w1.mnemonic()
'round profit immense ... sniff'
> w1.getAddressForCoin(CoinType.cosmos)
'cosmos1kgd25tvkz3jtuee4cl796trc2s0hjsfgqmhmku'

Also, building it is added to the sample app CI.
Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] Create pull request as draft initially, unless its complete.
[ ] Add tests to cover changes as needed.
[ ] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

[ ] I have read the guidelines for adding a new blockchain.

Here's the current output from the CI :)

Can you add one example how to use protobuf models? the rest looks good, we can add more useful commands later

Can you add one example how to use protobuf models? the rest looks good, we can add more useful commands later

Protobuf example added:  https://github.com/trustwallet/wallet-core/blob/ar/devconsole.ts/samples/typescript/devconsole.ts/samplescripts/protoeth.sampleinput.txt

First of all, hello to everyone, I regret that thousands of hyenas are looking for the prey that the lion worked hard for for himself and his family for years, and in the end, due to an accident, he has been lying in a hospital bed for 17 months.
He sold his two sons to treat him, and wishes and efforts for many years for his two sons for their future and the future of his country, that they become great developers like him, of course, not like many carrion eaters,, yesterday also because of 12 days
Due to the hospital's lack of money, they said that they want to take away the ventilators and other facilities from her. I am a woman and I am no longer responsible for all these expenses. You can also draw a plan for the carcass of this lion and its 2 sons, but remember that this lion is in trouble.
He came, so how about the hyena,,,✋

I remember him saying that the director of Binance, I see a kind of manliness in him, that he accepted the request of America not to accept the embargoed countries, but the American no longer accepts (and said he is the manager of TrustVault.
the same)
He doesn't care about anyone, he does what he knows is right, but now I see something else??
The manager,, me, his wife ((Rezadars)), that colleague, I know he will be fine,, 🙏 Whatever it is, please open his account and don't let him lose it.
Thank you


Error when upgrading to 0.39.0; process.stdin.setRawMode is not a function error

Description
So I was trying to upgrade my react-native library from 0.38.0 to 0.39.0. I was expecting to prompt me about changes, replace and what not. But all I got is this kind of error and the CLI prompt just exit.
$ react-native upgrade
Upgrading project to react-native v0.39.0
Check out the release notes and breaking changes: https://github.com/facebook/react-native/releases/tag/v0.39.0
android\app\build.gradle has changed in the new version.
Do you want to keep your android\app\build.gradle or replace it with the latest version?
If you ever made any changes to this file, you'll probably want to keep it.
You can see the new version here: H:\Git\React-Native\AppTest\node_modules\react-native\local-cli\templates\HelloWorld\android\app\build.gradle
Do you want to replace android\app\build.gradle? Answer y to replace, n to keep your version:

process.stdin.setRawMode is not a function

Additional Information

React Native version: 0.38.0
Platform: Android
Operating System: Windows

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.

@kenma9123 It happend me too.
I think its happen on MINGW64 terminal. I run that command in VScode (bash) and it was ok.


Add datasets module

Currently this only contains timeseries.
Hopefully this creates a model on which we can add in the future.

Dask Name: make-timeseries, 30 tasks

[ ] Tests added / passed
[ ] Passes flake8 dask

Adding this seems a little premature with only one dataset, but I'm inclined to start recording some videos and I'd like to future-proof them a bit

Are you planning to start storing test data in Dask? If so, would like to discuss that further.

Nope

I think that operationally we need to decide what sort of API we want for easy to use datasets going forwards.  Should this be centralized in the dask project?  Should it be in a .datasets module or something else (sklearn does this)?
If no one has any thoughts on this I'm going to go ahead and merge.

If it's only including generated data (not binary data), I have no thoughts on it. If we get into binary data packaging, I'd like to engage in that discussion.

On Fri, Jul 20, 2018 at 1:16 PM, jakirkham<EMAIL_ADDRESS>wrote:

If it's only including generated data (not binary data), I have no
thoughts on it. If we get into binary data packaging, I'd like to engage in
that discussion.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3780#issuecomment-406667136, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszHTGiB-x1Y8Jlz2i0idOGx_c_KLpks5uIhBagaJpZM4VUt6S
.

Definitely packaging binary data. Possibly also downloaded data. How/when would downloaded datasets get added?

If we started doing that then we would probably follow the model in
libraries like scikit-learn.  I think that they download when necessary but
keep some sort of cache around.
I would be -1 to including non-trivial data within the dask package itself.
On Fri, Jul 20, 2018 at 2:06 PM, jakirkham<EMAIL_ADDRESS>wrote:

Definitely packaging binary data. Possibly also downloaded data. How/when
would downloaded datasets get added?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3780#issuecomment-406682231, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszI5uj7k9t_0Vg17u_4nosgXzIwCFks5uIhwSgaJpZM4VUt6S
.

I see. Is it on import?
Ok, that makes sense.

Nothing happens on import.  If someone calls a function like get_nyc_taxi()
then some download might happen, but definitely nothing would happen on
packaging, installation, or import.
On Fri, Jul 20, 2018 at 4:13 PM, jakirkham<EMAIL_ADDRESS>wrote:

I see. Is it on import?
Ok, that makes sense.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3780#issuecomment-406714509, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszBhMWXfvjkr47iDjOk8Atx0xQnFeks5uIjnjgaJpZM4VUt6S
.

OK to merge?
This is in-line with existing conventions in scikit-learn, (and I suspect other projects).  I think that having it in a release will make it easier to integrate with the dask-examples repository, which will encourage additional use in the future.

Sure this seems fine. Would you like to add a test?

The current timeseries function is currently tested in the dataframe
module.  I think that might be enough.  Open to other suggestions though.
On Fri, Jul 20, 2018 at 6:55 PM, jakirkham<EMAIL_ADDRESS>wrote:

Sure this seems fine. Would you like to add a test?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3780#issuecomment-406746259, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszD-83c-vsUDi6r8fROp9V5VNaZ7Qks5uIl_cgaJpZM4VUt6S
.


⚠ 广电VRBT has degraded performance

In ff92fef, 广电VRBT (https://vrbt.10099.com.cn/#/home) experienced degraded performance:

HTTP code: 200
Response time: 8480 ms

Resolved: 广电VRBT performance has improved in 1514820 after 22 minutes.


🐛  make sure the proxy values are set on the android pod

This PR will:

Make sure the "-remoting" flag is set when running the Jenkins cli. This is required for running groovy scripts. It was the default mode before, but with the current version of Jenkins, this mode is deprecated and we need to explicitly add this flag to run the groovy scripts
Make sure the proxy env vars are set for the android pod template.

To verify:
Remote the android pod template from osm4. Run the playbook and it should recreate the pod template, with the correct env vars created.
ping @laurafitzgerald @PhilipGough @luigizuccarelli for review

@wei-lee :eyes:

@wei-lee added some new changes
What

If the template exists
Check the existing env vars
Update them if they have changed
If new template
Create env vars as normal

Updated log statements used in the script.
Now outputting this to the user.
Why
The plugin was duplicating (rather than recreating) the env vars when the playbook was run more than once.
Verification
Step

Delete the pod template on osm4 (if present)
Run:

ansible-playbook -i inventories/engineering/osm4/osm4-hosts playbooks/buildfarm.yml -e "digger_project_name=digger" --tags=configure-buildfarm --vault-password-file ~/.osm4pass.txt

Expected Result

New pod template created with the correct entries.

Steps

Change one of the env vars (proxy_url or proxy_gradle_opts) in the osm4 inventory file.
Re-run the command.

Expected Result

The changed env var should be updated
No duplicate env vars should be present

@laurafitzgerald very good catch. I didn't realise the env vars will be duplicated as the code was recreating the env var list every time when it runs. It turns out that the setEnVars method is adding the new env vars to the existing list, rather than reset the envVars list completely (See https://github.com/carlossg/jenkins-kubernetes-plugin/blob/master/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplate.java#L308).
I improved the format of the code. Verified it on OSM4.


Cmd+Click on back/forward buttons should open/fork in new tab

Depends on https://github.com/electron/electron/issues/7186 or tracking history ourselves as described in https://github.com/mozilla/tofino/issues/996#issuecomment-246672736

Unasigning for now.

Found out about https://github.com/mozilla/tofino/pull/1120#issuecomment-246906935


Guides/Livestreaming -- update landing page

The Livestreaming guides landing page was a bit sparse.
Update with next steps.

pushed to main, closing branch


"incompatible character encodings: ASCII-8BIT and UTF-8" when displaying build results

I'm getting this error when attempting to display a successful build page. Could there be something wrong with my settings?

Started GET "/projects/1/builds/9dc0f4078cbca2607e66aeafe2aa424f1c634e6a" for <IP_ADDRESS> at 2012-12-13 22:05:48 +0000
Processing by BuildsController#show as HTML
  Parameters: {"project_id"=>"1", "id"=>"9dc0f4078cbca2607e66aeafe2aa424f1c634e6a"}
  Rendered builds/show.html.haml within layouts/application (4.8ms)
Completed 500 Internal Server Error in 8ms

ActionView::Template::Error (incompatible character encodings: ASCII-8BIT and UTF-8):
    68:     %pre.trace#build-trace
    69:       = preserve do
    70:         = raw @build.trace_html
    71:
    72:   .span3
    73:     .builds
    74:       %h5 Builds for<EMAIL_ADDRESS>  app/views/builds/show.html.haml:71:in `block in _app_views_builds_show_html_haml___1157928019919596779_48687460'
  app/views/builds/show.html.haml:69:in `_app_views_builds_show_html_haml___1157928019919596779_48687460'

I'm still having this issue on an omnibus-gitlab install.  Installed 3 weeks ago.


Add 'subset' diff stategy option that checks the live state is a subset of the config state.

Part of #46, looking for feedback and discussion more than anything.
This PR adds a --diff-strategy=subset flag (default value is all, for the current behaviour).  The affect of this flag is to remove fields from the live state that are not present in the config state, reducing the diff to a subset operation.  This is how weaveworks/kubediff behaves.  Note that for lists of differing lengths we preserve the live state, meaning you'll still get diff results for missing (or added) ports, containers etc.
IMO this approach turns out to be super useful - after all, if you haven't declared the desired value for a given field in you config, do you really care what its value is?  One limitation with this approach is that we won't catch labels or annotations that have been remove from config and not from live.
An alternative approach would be to "flesh out" the local config with default values for all the fields, remove the status value which will never be present locally, and then do a full diff.   This sounds super brittle to me, as you would need to keep you local kubecfg in sync with the cluster version (or make kubecfg cluster version aware).  We'd also need to maintain a black list of fields which are never going to be present locally but don't have sensible default values - for instance most of the stuff in metadata, such as resourceVersion, selfLink, uid etc.
WDYT?
(NB includes #53 until that is merged)

Thanks for the feedback @anguslees!  Have added a bunch of tests and fixed the other comments.