[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: istio-testing
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-bookInfoTests-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-bookInfoTests-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-bookInfoTests-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-mixer-no_auth

prow/e2e-mixer-no_auth-mcp.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-bookInfoTests-v1alpha3.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-mixer-no_auth

prow/e2e-mixer-no_auth-mcp.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-mixer-no_auth-mcp

prow/e2e-simpleTests.sh
4462685497102ebcb8d9c061a1bb6a02c97617e6
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Can we add/remove 1 byte at the end of file?

I see an example, something like this
ftruncate($handle, $size-1);
By doing this, we can change file md5. Can we do that?

What do you mean?
Can you please describe the problem


Update event subscribers to use suffixed subjects

As of https://github.com/wasmCloud/wasmCloud/pull/1090, the host emits events on wasmbus.evt.{latticeID}.{eventName}. Some subscribers (tests in wash, the washboard, and wadm) still subscribe to the non-suffixed subject.
These clients should be updated prior to wasmCloud 1.0

Hijacking this issue just to drop a nice-to-have, it would be really nice to have a defined list of all the events we publish and, optimally, some kind of JSON schema or other specifier for the expected fields on those events. Unsure if https://cloudevents.io/ has a good tool to do this

hey @brooksmtownsend , do you have an idea/tip of how one would go about taking a survey of all events that are published? For the particular case of wasmbus.evt.{latticeID}, @connorsmith256 I haven't been able to located its use in wadm and wash tests (although, it seems like @vados-cosmonic already made such changes for tests some weeks ago).  I only found one place in washboard-ui where it is being used.

@ahmedtadde that's a good question. We do want to have a place where we officially note all of the events that are published, but for now it's best discovered by looking for calls to publish_event.

host_heartbeat
host_started
host_stopped
actor_start_failed
actors_start_failed
provider_started
provider_start_failed
provider_stopped
config_set
config_deleted
linkdef_set
linkdef_deleted
actors_started
actors_stopped

Soon to be added

actor_scaled
actor_scale_failed

There but soon to be gone
13. actor_started
15. actor_stopped

[ ] wadm https://github.com/wasmCloud/wadm/pull/241
[ ] control interface and wash https://github.com/wasmCloud/wadm/pull/241
[ ] washboard @lachieh

Clients are all done, good to close?

@lachieh yep!


Support named handlers #156

Back port change from PR: https://github.com/quarkiverse/quarkus-logging-splunk/pull/210
to version RHBQ 2.2.x

In the end we're not going to backport, as it's a feature.
If really needed the 3.x versions of the extension seem to actually still be binary compatible with Quarkus 2.x.


Bug related to Reliable resend of old sample after emission of a new one

Summary

Bug discovered in tagged version 0.9.0

In Reliable mode, if sample A is sent first but not received, then sample B is sent, the middleware will drop sample B, waiting for sample A, to make sure to have a proper history. Then, sample B should be re-emitted and received by the DataReader. This doesn't seem to be the case.
It seems that sample A is never received, even if it is re-sent.
Steps to reproduce
Test setup configuration
Tested on Ubuntu 22.04. The test uses iptables to drop packets.
We give iptables rights to the user executing the test:
/etc/sudoers
test_runner ALL=(ALL) NOPASSWD: /usr/sbin/iptables

Minimal reproducible example
minimal_reproducible_example.zip
The following diagram explains the minimal reproducible example:

On the network capture, we see that samples are re-sent correctly, and ACK packets are good too, but we don't see any logs about receiving Sample 2 in the application.
What is the expected correct behavior?
Receiving application receives all samples.
Relevant logs and/or screenshots
Minimal reproducible example logs:
2024-02-20 10:37:55.667223 | main       | INFO  | rdds_xxx     | Creating DomainParticipant
2024-02-20 10:37:55.671392 | main       | INFO  | rdds_xxx     | Creating Subscriber
2024-02-20 10:37:55.671535 | main       | INFO  | rdds_xxx     | Creating Data Writer
2024-02-20 10:37:55.671840 | main       | INFO  | rdds_xxx     | Starting Subscriber thread
2024-02-20 10:37:55.671864 | main       | INFO  | rdds_xxx     | Starting Publishing
2024-02-20 10:37:55.671956 | main       | INFO  | rdds_xxx     | Wait 2 seconds to make sure the DataWriter and DataReader matched themselves.
2024-02-20 10:37:55.672112 | ReceiverTh | INFO  | rdds_xxx     | DDS receiver thread started
2024-02-20 10:37:55.673280 | ReceiverTh | INFO  | rdds_xxx     | DataReader event: SubscriptionMatched { total: CountWithChange { count: 1, count_change: 1 }, current: CountWithChange { count: 1, count_change: 1 }, writer: GUID {01125c4b32
55512c8dd3551a EntityId {[0, 0, 1] EntityKind::WRITER_WITH_KEY_USER_DEFINED}} }
2024-02-20 10:37:57.672216 | main       | INFO  | rdds_xxx     | Publishing 1
2024-02-20 10:37:57.674486 | ReceiverTh | INFO  | rdds_xxx     | Received 1
2024-02-20 10:37:57.735232 | main       | INFO  | rdds_xxx     | Start dropping UDP packets with payload 'DropMe'
2024-02-20 10:37:57.735293 | main       | INFO  | rdds_xxx     | Wait 1 sec
2024-02-20 10:37:58.735612 | main       | INFO  | rdds_xxx     | Publishing 2
2024-02-20 10:37:58.735784 | main       | INFO  | rdds_xxx     | Wait 1 sec
2024-02-20 10:37:58.736114 | RustDDS Pa | WARN  | rustdds::net | send_to_udp_socket - send_to <IP_ADDRESS>:7401 : Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" } len=99
2024-02-20 10:37:58.736242 | RustDDS Pa | WARN  | rustdds::net | send_to_udp_socket - send_to <IP_ADDRESS>:7401 : Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" } len=99
2024-02-20 10:37:58.736298 | RustDDS Pa | WARN  | rustdds::net | send_to_udp_socket - send_to <IP_ADDRESS>:7401 : Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" } len=99
2024-02-20 10:37:58.736348 | RustDDS Pa | WARN  | rustdds::net | send_to_udp_socket - send_to <IP_ADDRESS>:7401 : Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" } len=99
2024-02-20 10:37:58.736398 | RustDDS Pa | WARN  | rustdds::net | send_to_udp_socket - send_to <IP_ADDRESS>:7401 : Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" } len=99
2024-02-20 10:37:59.751278 | main       | INFO  | rdds_xxx     | Stop dropping UDP packets with payload 'DropMe'
2024-02-20 10:37:59.751340 | main       | INFO  | rdds_xxx     | Publishing 3
2024-02-20 10:37:59.801671 | main       | INFO  | rdds_xxx     | Wait 5 secs
2024-02-20 10:37:59.877035 | ReceiverTh | INFO  | rdds_xxx     | Received 3
2024-02-20 10:38:04.802077 | RustDDS Pa | ERROR | rustdds::rtp | Event for unknown writer EntityId {[0, 0, 1] EntityKind::WRITER_WITH_KEY_USER_DEFINED}

Minimal reproducible example commented network capture
Complete test-plan sent by e-mail (Test Reliability_QOS_3).
Analysis
There must be a problem in the user API of RustDDS, between the RTPS reception and the add to the sample queue. We may want to take a look at src/dds/with_key/datasample_cache.rs.

Thank you for such a detailed report and a brilliant reproduction example!
This does indeed look like a bug in RustDDS's Reliable Reader logic, so we'll investigate.
Initial findings so far:
...
2024-07-30 12:59:39.927991 | main       | INFO  | rdds_344     | Publishing 1
2024-07-30 12:59:39.928985 | ReceiverTh | INFO  | rdds_344     | Received 1
2024-07-30 12:59:39.997281 | main       | INFO  | rdds_344     | Start dropping UDP packets with payload 'DropMe'
2024-07-30 12:59:39.997394 | main       | INFO  | rdds_344     | Wait 1 sec
2024-07-30 12:59:40.998122 | main       | INFO  | rdds_344     | Publishing 2
2024-07-30 12:59:40.998338 | main       | INFO  | rdds_344     | Wait 1 sec
2024-07-30 12:59:40.998598 | RustDDS Pa | WARN  | rustdds::net | send_to_udp_socket - send_to <IP_ADDRESS>:7401 : Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" } len=99
2024-07-30 12:59:40.998713 | RustDDS Pa | WARN  | rustdds::net | send_to_udp_socket - send_to <IP_ADDRESS>:7401 : Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" } len=99
2024-07-30 12:59:42.018813 | main       | INFO  | rdds_344     | Stop dropping UDP packets with payload 'DropMe'
2024-07-30 12:59:42.018950 | main       | INFO  | rdds_344     | Publishing 3
2024-07-30 12:59:42.019101 | main       | INFO  | rdds_344     | Wait 5 secs
2024-07-30 12:59:42.133660 | ReceiverTh | INFO  | rdds_344     | Received 2
2024-07-30 12:59:47.020708 | RustDDS Pa | ERROR | rustdds::rtp | Event for unknown writer EntityId {[0, 0, 1] EntityKind::WRITER_WITH_KEY_USER_DEFINED}

I am able to reproduce the issue, but it is not the same!
Now receiver reports "Received 2" instead of "Received 3", like you were getting. And sample number 3 is not received.
We will continue looking into this.

This was indeed a bug in DataReader's caching and metadata generation logic. It was possible for a Reliable DataReader to deliver samples to the application in the wrong order, if they are received out-of-order, which is what you are testing here.
I just released RustDDS 0.10.2, where this is fixed.
However, the result that you are receiving only sample 2, and sample 3 is lost, is because in your test code the DataReader has QoS History::KeepLast depth =1. It is not specified in the code, but DDS spec says this is the default. This causes the DataReader's receive buffer have effectively only one slot, and therefore no space to reorder 3 and 2when they are received out of order. This can be fixed simply by adding .history(History::KeepLast{ depth: 2}) to the QoS at receiving side.
My test results with History depth=2 are as follows:

RustDDS 0.9.0: received 1,2,3 - ok
RustDDS 0.10.0: received 1,3,2 - incorrect order
RustDDS 0.10.1: received 1,3,2 - incorrect order
RustDDS 0.10.2: received 1,2,3 - ok

Naturally, in order to cope with more severe data reordering, the History depth would have to be increased more.
I am still uncertain if this is the intention of the DDS spec. Is a DDS implementation allowed to lose samples with QoS Reliability::Reliable, if the QoS History does not provide a buffer large enough to reorder the samples?

If History is really necessary to get reordering to work, then that seems a bit unintuitive.

If reordering should work regardless of History, then how long reorder buffer should be provided?

If you have any thoughts on this, or manage to find a part of the DDS Spec to clarify this, please leave a comment.

I think the DDS Spec part <IP_ADDRESS> RELIABILITY is answering that question:

The setting of this policy has a dependency on the setting of the RESOURCE_LIMITS policy. In case the RELIABILITY kind is set to RELIABLE the write operation on the DataWriter may block if the modification would cause data to be lost or else
cause one of the limits in specified in the RESOURCE_LIMITS to be exceeded. Under these circumstances, the
RELIABILITY max_blocking_time configures the maximum duration the write operation may block.
If the RELIABILITY kind is set to RELIABLE, data-samples originating from a single DataWriter cannot be made available
to the DataReader if there are previous data-samples that have not been received yet due to a communication error. In other words, the service will repair the error and re-transmit data-samples as needed in order to re-construct a correct snapshot of the DataWriter history before it is accessible by the DataReader.

IMO:

Since ResourceLimits is not implemented yet in RustDDS, we assume its default value (Infinite).
Even if we have infinite resources, the 1st sample would be lost if we send a 2nd before every reader received it, so the writer should block. I think that in that case, the History size doesn't matter, and thus, the ResourceLimits neither.

Thanks a lot for your answer and for the fix, I'm grateful to be able to participate to this open-source project !

IMO:

Since ResourceLimits is not implemented yet in RustDDS, we assume its default value (Infinite).
Even if we have infinite resources, the 1st sample would be lost if we send a 2nd before every reader received it, so the writer should block. I think that in that case, the History size doesn't matter, and thus, the ResourceLimits neither.

Sorry, but I cannot follow what is your logic here.
The term "send" here is a bit ambiguous. Also the word "it" after "receive" is ambiguous, but I assume it refers to the "1st sample".
If we send samples 1,2,3,.., we can send them in order, with Reliability=Reliable, without waiting for an acknowledgement from all readers in between, provided that we can buffer them in the Writer for possible retransmit.
In my reading, the two spec paragraphs have a different meaning.
First paragraph says that a Reliable DataWriter may (or even should) block until timeout, if the write operation would cause data to be lost. This is a mechanism to eventually throttle writing, if a DataWriter tries to write faster than the matched Reliable DataReaders can acknowledge that they have the data. If the write call results in a timeout, then that indicates the write did not succeed.
The second paragraph states that a Reliable Datareader should receive the samples in order. If a RTPS Reader receives 1 and 3, it should deliver only 1 to DataReader and request retransmit of 2 from Writer. Note that a Writer may respond either by sending 2, or by a Gap message indicating that 2 is no longer available. In the latter case DataReader will deliver 3, and 2 is never delivered. There is no explicit indication to the application about this, but it can be detected by e.g. inspecting sample lost status in a DataReader or DomainParticipant. This is where DDS reliability is different from e.g. TCP, which will absolutely refuse to continue while there is a gap in the received data.


consider making dedup optional if local disk limited but remote is not

although it's not obvious if the non duplicated output has value

no let's do #18 instead


Add unbeatable mode

Minmax algorithm works perfectly for games with a small number of turns like tic-tac-toe. The unbeatable mode or the hard mode can be implemented by it.

I would love to solve this. Please assign this to me

@gokulrajanpillai great!!
You may open a PR.

@j-tesla can you give me permission to make the branch for PR?

Fork, branch and PR.
What permission do I need to give?

@j-tesla Thought I should create a branch directly from this repo (was the case for some other challenges). Thanks for clarifying this 👍
I have made the PR.


Direct drawing API for SIXEL and such

Recently, many new, modern terminals are popping up with decent SIXEL support, and with VTE's SIXEL branch coming closer to being ready, I've been thinking of various ways of adding SIXEL graphics through tcell to ultimately make an image widget in tview; however, I'm making an issue first to see how such a thing should be best implemented.
My current idea involves these interfaces:
// DrawInterceptFunc is the callback to intercept a draw. It is called when the
// lock is acquired. Sync is true if the whole screen is about to be cleared, or
// for after interceptors, after clearing.
type DrawInterceptFunc func(sync bool)

// DrawInterceptAdder is an interface that Screen can implement to add a draw
// itnerceptor function. This interface could be used to draw custom SIXEL
// images as well as other raw terminal things.
//
// Implementations must call these functions before any state changes, or in teh
// case of After, after all state changes. For example, draw interceptors should
// be called before the cursor is hidden, and the after interceptors should be
// called after the cursor is shown and everything is drawn into the buffer (but
// before flushing).
type DrawInterceptAdder interface {
	// AddDrawIntercept wraps the existing draw intercept function with the
	// given one.
	AddDrawIntercept(fn DrawInterceptFunc)
	// AddDrawInterceptAfter adds the draw interceptor after everything is
	// drawn.
	AddDrawInterceptAfter(fn DrawInterceptFunc)
}

// DirectDrawer exposes the raw draw function for the caller to draw code
// unknown to tcell.
type DirectDrawer interface {
	// DrawDirectly draws the given bytes as-is directly into the screen.
	DrawDirectly([]byte)
}

They have a problem, however. Callbacks may call methods on Screen, which would cause a deadlock, because the lock would already be acquired in draw() calls, which is where these callbacks are executed. I'm currently thinking of using a halting mutex (mutex that allows invalidation of its methods temporarily while it's acquired), but this seems hacky.
The idea of unlocking and relocking may seem fine at first, but it will lead to excessive graphical blinking.
The ultimate use case of this type of API would be drawing SIXEL graphics onto tcell applications, like so:

For the record, this image is rendered on the foot terminal using my current prototype branch.

With the current changes in my branch, I was able to make a working SIXEL implementation with GIF support.

Hi! Is there any plans on moving forward with integrating this? I've started looking into adding image viewing to aerc which uses tcell-term and according to the author, the easiest would be if tcell would support it directly, because otherwise it will be a bit hacky.

I haven't looked at this in quite a while.  I'll need some time to re-review it.
My biggest complaints right now with these relate to a couple of areas of concern:

for SIXEL specifically, making sure that it fits in our model sensibly -- bitmap graphics is way different than character cells.
identifying which terminals support this -- the problem with that is that there are a bunch of different variants, and even worse, different versions of those variants, and so using $TERM to identify this capability becomes increasingly challenging.  This is fine when adding a feature is mostly benign if the terminal doesn't support it, but this seems unlikely to be the case for SIXEL.

Anyway, I'll look again, maybe with a fresh perspective.

I've reviewed the PR for this, and had some thoughts.  It needs work before it can land, and some of it needs changes in approach, because SIXEL doesn't really work for all terminals -- it is linked intrinsically to the model of a stream of bytes and escape sequences, and that isn't how some of the targets we support work (neither Windows console nor the new HTML terminal widget).
I think that there are however ways forward to achieve what is desired here, in a way that doesn't lead to unacceptable compromises.  My notes on that are in the PR.

Note that the approach discussed here doesn't actually offer full SIXEL support, but merely exposes some things that make it possible for a SIXEL library to coexist with tcell.

Thanks for looking into this!

Is it possible to draw sixel image with transparency?

I actually think the PR to enable this was merged already.  I don't know whether transparency is possible here but I sort of doubt it.

Closing since https://github.com/gdamore/tcell/pull/602 is merged.


Error: System.InvalidOperationException: Cannot provide a value for property 'Http' on type 'MatBlazor.MatTable`1[[BlazorMaterialDesign.Data.WeatherForecast, BlazorMaterialDesign, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]]'. There is no registered service of type 'System.Net.Http.HttpClient'.

I am using .net core 3.0 preview 6 and matblazor latest version and getting lot of issues
My Code:
`@page "/fetchdata"
@using BlazorMaterialDesign.Data
@inject WeatherForecastService ForecastService

Weather forecast

This component demonstrates fetching data from a service.

@if (forecasts == null)
{

Loading...

}
else
{
    <MatTable Items="@forecasts"
                    LoadInitialData="true"
                    Striped="true"
                    FilterByColumnName="Date">
        <MatTableHeader>
            Date
            TemperatureC
            TemperatureF
            Summary
        </MatTableHeader>
        <MatTableRow>
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>        </MatTableRow>
    </MatTable>
}

@code {
    WeatherForecast[] forecasts;

    protected override async Task OnInitAsync()
    {
        forecasts = await ForecastService.GetForecastAsync(DateTime.Now);
    }
}

`

you need register HttpClient in services

Register HttpClient in services doesn't help.

I'm also having this problem, isn't it HttpClientFactory in the latest version?

You Should Register httpClient as  Scoped :
           services.AddScoped<HttpClient>();


Add handling for convention to repeat character entry more than twice

November 1984 issue of Ahoy added support for entry of characters (special or regular) more than twice with the following notations:
[5 "[LEFT]"] - enter the special character for cursor left five times
[10 "."] - enter the regular period character 10 times

Closed via PR #39


S3: Not throwing an exception with a Deny bucket policy

Hello, I'm using pytest v8.2.2, boto3, botocore v1.34.142 and moto v5.0.11 installed with poetry, and the following code snippet passes just fine without throwing an exception:
def test_s3_deny(mock_s3):
    s3 = boto3.client("s3")
    policy = {
        "Version": "2012-10-17",
        "Statement": [
            {
                "Effect": "Deny",
                "Principal": "*",
                "Action": ["s3:PutObject"],
                "Resource": "arn:aws:s3:::mybucket/*",
            }
        ],
    }
    s3.create_bucket(Bucket="mybucket")
    s3.put_bucket_policy(Bucket="mybucket", Policy=json.dumps(policy))
    s3.put_object(Body="test", Bucket="mybucket", Key="obj")

I don't know if it's relevant, but here's my conftest.py:
import os
import pytest
from moto import mock_aws
import boto3

@pytest.fixture(scope="function", autouse=True)
def aws_credentials():
    os.environ["AWS_ACCESS_KEY_ID"] = "testing"
    os.environ["AWS_SECRET_ACCESS_KEY"] = "testing"
    os.environ["AWS_SECURITY_TOKEN"] = "testing"
    os.environ["AWS_SESSION_TOKEN"] = "testing"
    os.environ["AWS_DEFAULT_REGION"] = "us-east-1"

@pytest.fixture(scope="function")
def mock_s3():
    with mock_aws():
        yield boto3.client("s3")

According to #5883, it should throw an exception and weirdly there is a test for this case. I haven't tried without pytest because I don't think it's the problem here
Related to #5820

Potentially relevant:
https://github.com/getmoto/moto/blob/1c8c0fe4d9c7f5481a40814a8a6459a5142707ff/moto/iam/access_control.py#L396C1-L417C44

I did some debugging and found the problem:
https://github.com/getmoto/moto/blob/1c8c0fe4d9c7f5481a40814a8a6459a5142707ff/moto/s3/responses.py#L1302
Remove this if, and magically everything works. It seems that key is None when calling put_object in my example. I don't know what the if condition is for though


Sync sometimes stalls due to peering challenges

Description
As a user, I do not want my sync to stall so that I can get up and running as fast as possible. In a post-Merge environment, there are some changes to sync that may help with this, like

PoS Friendly sync target
Peer shuffling to avoid trying to peer with the same node over and over
Re-Evaluating best-peer rules in post-Merge context
Better logging in a stuck sync

Acceptance Criteria

Clearer or better sync process

NEED TIMING / SCOPE ESTIMATE FOR THIS
Steps to Reproduce (Bug)

Have a sync stall

Expected behavior: [What you expect to happen]

Completed sync

Actual behavior: [What actually happens]
Frequency: [What percentage of the time does it occur?]
Versions (Add all that apply)

Software version: latest

@non-fungible-nelson can we close this? Recent work on syncing should have made this obsolete


Failed installation - nothing has appeared in firebase console

The GoogleService-Info.plist file is in iOS folder (previously it was in Runner folder, and firebase messaging works in both cases),
firebase_crashlytics: ^0.1.3+3 is in pubspec.yaml,
added buildphase script with and without info.plist path
and added Crashlytics.instance.enableInDevMode = true; and FlutterError.onError = Crashlytics.instance.recordFlutterError; into main.dart,
and finished the Android installation as instructed,
launched the iOS app on real device
but "Add the SDK, then build and run your app" is still shown in the firebase console in both android and iOS.
Have I done something wrong or what?
flutter doctor --verbose
[✓] Flutter (Channel stable, v1.17.2, on Mac OS X 10.15.4 19E287, locale en)
• Flutter version 1.17.2 at /Users/admin/dev/flutter
• Framework revision 5f21edf8b6 (3 days ago), 2020-05-28 12:44:12 -0700
• Engine revision b851c71829
• Dart version 2.8.3
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/admin/Library/Android/sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.5, Build version 11E608c
• CocoaPods version 1.9.1
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 45.1.1
• Dart plugin version 192.8052
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.45.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.11.0
[✓] Connected device (1 available)
• iPhone • ... • ios • iOS 13.5

Hi @nausharipov
Did you create an app id and new firebase app?
Make sure the app id matches with firebase's app id
and place plist here using xcode,  import Firebase and configure()

Also add this to AppDelegate.swift
import UIKit
import Flutter
import Firebase

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    FirebaseApp.configure()
    GeneratedPluginRegistrant.register(with: self)
    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }
}

and uninstall previous version and install the app
Thank you


GC/Code Official Support Pitch

https://github.com/gcdevops/strategie-devops-strategy/blob/master/Content/OfficialGCCodeSupport.md

[x] Consult with community
[x] Send to Martin
[x] Investigate cost recovery model
[x] Jayson to review
[x] Create elevator pitch to ADM (cost recovery model?)
[x] Submit to Martin
[x] Document relevant benefits for existing projects (e.g. OAS)
[ ] Determine Value Add for CDO and contact them for feedback
[ ] Add costing estimates
[ ] Waiting for response from Martin

https://github.com/gcdevops/strategie-devops-strategy/pull/23


Fix code scanning alert - Polynomial regular expression used on uncontrolled data

Tracking issue for:

[ ] https://github.com/josuamanuel/js-awe/security/code-scanning/1

Change regex to remove look ahead


Add server version to the Admin UI

It would be useful to be able to check the server version from the UI.

Is the  server version you are referring to the 'release' version? Is that currently available in the signalk-server-node code?

Yes, the version is in package.json and available in /signalk response per Signal K specification:

There is one problem though: the version is updated on publishing to npm and after that the master version in Github still advertises that same version, even if there are additioanl changes.

Should the version be present on the Dashboard or Footer or within the Server menu ? Preferred location?

Im not certain as to how to edit the admin app files. Here is what I have tried:
-clone signalk-server-node-admin-app
-run npm link in signalk-server-node-admin-app folder. Some complaints wrt jquery missing
-run 'npm link @signalk/server-admin from signalk-server-node folder
-Run signalk-server-node with changes to Footer.js not being shown
-Try to run signalk-server-node-admin-app - no joy
Would it be preferable to ask this in slack?

(handled in slack)


Sync stops progressing after last checkpoint

Headers.Height, Consensus.Height, BlockStore.Hight never progress past 1000000 (The last checkpoint?)
The block explorer shows well past this (1100377).
Reproduce:

Download latest code
Delete the StratisMain folder (%AppData%\StratisNode\stratis\StratisMain)
Start full node with default settings (Do not create a wallet)

hey @einewton what's actually happening here is from 1m onwards you will need to be connected to a C# node to continue progressing and the seeds for this are still being set up.
The recommendation is to wait, as peer discovery should get you there... Or you may be able to bypass it by adding a C# node manually - try starting your node with the extra param -addnode=<IP_ADDRESS>

@codingupastorm thanks, I am connected to @dangershony node... I will wait to see.

Good to hear :) Let us know how you progress

There was a problem even when connected to PH enabled nodes.
Should have been fixed in https://github.com/stratisproject/StratisBitcoinFullNode/pull/2893
So if you are running earlier version- please update


[docs] Inconsistency between doc and code

I am trying to use the Selector.withAttribute method, and can't tell if the method should be wrapped in async/await.
What is the Current behavior?
Selector.withAttribute, as documented here, mentions the return type to be a Selector.
When I hover this method in VSCode, the method signature tells me it returns a SelectorPromise.
What is the Expected behavior?
Well, I would expect consistency
What is your web application and your TestCafe test code?
This impacts wether the method using this is
Your Environment details:

testcafe version: 1.4.2
node.js version: 10.16.3
platform and version: Windows 10

Thank you for your report. There is a mistake in our TypeScript Definitions. We will fix it ASAP.


🐛 BUG: wrangler pages project create --> unknown error when project name exists

Which Cloudflare product(s) does this pertain to?
Pages, Wrangler
What version of Wrangler are you using?
3.1.1
What operating system are you using?
Mac
Describe the Bug
Step to failure: Attempt to create a pages project with wrangler, using a project name that already exists.
example:
wrangler pages project create test-direct-upload fails with an error with code 8000000
This project didn't exist in our account, so wrangler pages project list did not show a conflict/collision.
When I used the web interface, it suggested an alternate (test-direct-upload-***, where *** were three letters tacked on the end).  My guess is that the original name (test-direct-upload) is already used (which seems true when I visit that address in a browser).
It's possible this isn't a bug, but a feature request?  If I selected the wrong category, sorry!

hi @mbakaitis :) we haven't heard from you in a while, so we’re going to close this issue for now, but if this is still a problem, please feel free to open a new issue referencing this one. please be sure to include an updated summary and any additional requested details, followup, or context and we will revisit and investigate further. thanks!


New Control: Persona Card

Category

[x] Enhancement
[ ] Bug
[ ] Question

Version
Please specify what version of the library you are using: [1.12.0]
Expected / Desired Behavior / Question
The office ui fabric library provides a way to create a persona card that looks and feels like the out-of-the-box persona card in SharePoint. However, it requires the developer to do all the work to retrieve the information.

Picture credit Heinrich Ulbricht
While it ultimately gives developers full control over what to render in the persona card, there are times where a developer just wants to render a standard/out-of-the-box persona card in their custom solutions.
Would it be useful to have a standard control to render an out-of-the-box persona card?
Observed Behavior
Office UI Fabric offers persona card control, but does not retrieve data for you.
Steps to Reproduce

Go to the Office UI Fabric example and copy into your own solution.
Control will require you to populate the data

This idea originated from a StackExchange post from Heinrich. If you think it's a good idea, he deserves the credit. If you think it's a bad idea, I deserve the credit :-)

Thanks!

By the way, the proposed control would leverage the existing hovercard in the FieldUserRenderer control, but make it more generic so that it can be used outside of the FieldUserRender control.

Note: Re-using the standard control would be my preferred solution as this would always be up-to-date. But if that's not possible a PnP control would be really handy!

Yes, you're right, I should have been clearer. It should use the standard control, but make it easier for developers to use in their solutions.  That way, the behavior remains consistent when Microsoft updates the functionality.

Oh and looking at the PersonaCard component: this is Fabric JS only, there is no React component. I'd like the new component to be a React one.

@heinrich-ulbricht I started putting something together last night.  It uses the Office UI Fabric HoverCard and retrieves the user profile information from their username. I would have preferred to hook into SharePoint's own livepersonacard but I suspect it isn't supported for us to do so.
If anyone has any ideas how to leverage the OOB livepersonacard, I would appreciate any tips you may have.
My goal would be to avoid having every developer to re-write the profile loading and persona card rendering bits, but with the ability to pass the persona information (to avoid loading it from the profile) and optionally override rendering (to create your own version of a persona card).
I'll post it as a sample on my own repo over the next few days, and we can see about converting it to a control if there is interest.

Don't know who could give more information about whether using the standard card is supported or not - maybe @estruyf?

As far as I know, standard card is not exposed as a component. That’s why we can’t use it. And that’s why I implemented the functionality using HoverCard in FieldUserRenderer. You can partially reuse code from there, and maybe add additional info if you find a way to get more profile details (like LinkedIn profile)

@AJIXuMuK Well technically it seems to be possible to load and use the standard card as demonstrated here. Now we need a sign if we are supposed to do this.

@AJIXuMuK the example you linked uses the loadComponentById method of the SPComponentLoader. If I'm reading this right, that method is no longer available and shouldn't be used. I believe the best way to do it (as @AJIXuMuK  pointed out) would be to use the HoverCard.
If you have success with the sample you linked to, please do not hesitate to share with us. I'd love to avoid duplicating what SharePoint does.

This might not be related, but there is also a nice Org Chart feature within the persona when clicking the "Show more" button that perhaps can be extracted and decoupled into different component:

@AJIXuMuK @heinrich-ulbricht @hugoabernier @VesaJuvonen  - Is there a blog that showcases the steps to implement a custom HoverCard functionality with custom attributes to be displayed on the hovercard? or any article out there which shows us how to incorporate the FIeldUserRenderer? In my case i do not think this would work, since i am reading data from a custom list on SharePoint and rendering the data in a Persona Office UI Fabric react component and i am trying to surface custom attributes onhover of the persona card. Can you confirm if this is doable with the FieldUserRenderer?

@yeshwanthjagannath
FieldUserRenderer is created to provide UI similar to OOTB rendering on User or Group field in SharePoint - display name as a link + HoverCard on hover.
There is a documentation on how to use FieldUserRenderer.
You can also look at FieldUserRenderer code itself to see how HoverCard is used.

@AJIXuMuK - Thanks for pointing me out to this. Looking at it looks like i would have to implement my own FieldUserRenderer and HoverCard because of my custom attributes i want to surface as part of the HoverCard. Correct me if am wrong.

@yeshwanthjagannath
Yes, FieldUserRenderer doesn't have any API or something to allow to add custom elements into HoverCard.

@AJIXuMuK - Sounds good. Thank you for your response. I will dig through and code this out from scratch for my need.

Ok, since loadComponentById is available again, I was able to create ProfileCard component with Denis Molodtsov's help (he did all the hard work, I just made it into a potential PnP control).
This is what it looks like:

The question I have is: do we want a control that wraps around any element, e.g.:
<ProfileCard>
<FieldUserRenderer users={event.fieldValue} context={this.context} className={'some-class'} cssProps={{ background: '#f00' }} />
</ProfileCard>

Or do we want a control that allows passing all the properties of a persona card in? Which is what I have now...
 public render(): React.ReactElement<IHelloPersonaProps> {
    const currentUserProps = {
      text: this.props.context.pageContext.user.displayName,
      email: this.props.context.pageContext.user.email ? this.props.context.pageContext.user.email : this.props.context.pageContext.user.loginName,
      serviceScope: this.props.context.serviceScope,
      //className: 'persona-card',
      //size: PersonaSize.size32,
      // moreDetail: this.personaDetail(), /* pass react element */
      //moreDetail: '
Details
', /* pass html string */
      // onCardOpenCallback: () => {
      //     console.log('WebPart', 'on card open callback');
      // },
      // onCardCloseCallback: () => {
      //     console.log('WebPart', 'on card close callaback');
      // }
  };
    return (

User with automatic picture

        <PersonaCard {...currentUserProps} />

User with smaller picture

        <PersonaCard {...currentUserProps} size={PersonaSize.size32} />

User name for list

        <PersonaCard {...currentUserProps} size={PersonaSize.size10} hideCoin={true} />

External user

        <PersonaCard
        text="Denis Molodtsov"
<EMAIL_ADDRESS>        serviceScope={this.props.context.serviceScope}
        secondaryText={"Deserves all the credit"}
        //size={PersonaSize.size32}
        />

Totally fake user

        <PersonaCard
        text="Fake User"
<EMAIL_ADDRESS>        serviceScope={this.props.context.serviceScope}
        //size={PersonaSize.size32}
        />

    );
  }

I suspect that we want option 1, so that we don't have two controls that render user information and so that it can be re-used in other situations, but I'd like your opinion.
Either way, I can submit the PR today.

Oh, and also, what do you want to call the control? PersonaCard or ProfileCard?

Looking at the developer tools:

Seems to be called "LivePersonaCard" by Microsoft - so I would say something with "Persona" is good.

LivePersonaCard it is! Thank you @heinrich-ulbricht -- it was you idea in the first place! (Don't worry, I gave you credit in the code)

No worries! So far I did nothing but wanting to have such a component. I'm thankful you guys found the time to work on this.
@joaojmendes over here on Twitter https://twitter.com/joaojmendes/status/1155945428027768834  was the one getting this topic rolling again - maybe some development efforts could be coordinated? Just discovered he has a pull request open: https://github.com/SharePoint/sp-dev-fx-webparts/pull/930

Soon I will work  on new reusable control persona card that will have a live persona card associated.
Thank you. ☺
Obter o Outlook para Androidhttps://aka.ms/ghei36

From: Heinrich Ulbricht<EMAIL_ADDRESS>Sent: Thursday, August 1, 2019 4:24:51 PM
To: SharePoint/sp-dev-fx-controls-react<EMAIL_ADDRESS>Cc: joaojmendes<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-fx-controls-react] New Control: Persona Card (#259)
No worries! So far I did nothing but wanting to have such a component. I'm thankful you guys found the time to work on this.
@joaojmendeshttps://github.com/joaojmendes over here on Twitter https://twitter.com/joaojmendes/status/1155945428027768834 was the one getting this topic rolling again - maybe some development efforts could be coordinated? Just discovered he has a pull request open: SharePoint/sp-dev-fx-webparts#930https://github.com/SharePoint/sp-dev-fx-webparts/pull/930
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-fx-controls-react/issues/259?email_source=notifications&email_token=AC7YHVN66KAEOQTLZOV76LDQCL54HA5CNFSM4HA6AKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3K6TDQ#issuecomment-517335438, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AC7YHVKYYFQFFAABOCEDV33QCL54HANCNFSM4HA6AKFA.

@joaojmendes  Great minds think alike! I submitted PR # 352, but I would love to see how we can combine our efforts to avoid duplicates.
The version I wrote is intended as a wrapper around any HTML elements, for flexibility purposes. If you create an empty <LivePersonaCard /> element, it will attempt to create a PersonaCard with the user info that's passed it.
There is an opportunity to combine some elements with FieldUserRenderer, but I didn't want to make those changes until I discussed it with you guys.
Let me know what you think! I welcome any and all suggestions... just be kind :-)

Hi Hugo,
I saw your PR now, that's what I was going to do! 🙂 It's looking pretty good. is what I use in the React-directory Web Part.
It seems-very well to change the FieldUserRenderer, and include the Live Persona Card.
Thanks for sharing!
João

From: Hugo Bernier<EMAIL_ADDRESS>Sent: Thursday, August 1, 2019 7:46 PM
To: SharePoint/sp-dev-fx-controls-react<EMAIL_ADDRESS>Cc: joaojmendes<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-fx-controls-react] New Control: Persona Card (#259)
@joaojmendeshttps://github.com/joaojmendes Great minds think alike! I submitted PR # 352, but I would love to see how we can combine our efforts to avoid duplicates.
The version I wrote is intended as a wrapper around any HTML elements, for flexibility purposes. If you create an empty  element, it will attempt to create a PersonaCard with the user info that's passed it.
There is an opportunity to combine some elements with FieldUserRenderer, but I didn't want to make those changes until I discussed it with you guys.
Let me know what you think! I welcome any and all suggestions... just be kind :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-fx-controls-react/issues/259?email_source=notifications&email_token=AC7YHVNWJBNUNWTPPUZYZ5LQCMVSBA5CNFSM4HA6AKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3LRE4A#issuecomment-517411440, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AC7YHVJMC3LTPQ6IYMGKRVDQCMVSBANCNFSM4HA6AKFA.

Thank you @Hugo<EMAIL_ADDRESS>Done !  😊
From: Hugo Bernier<EMAIL_ADDRESS>Reply to: SharePoint/sp-dev-fx-controls-react<EMAIL_ADDRESS>Date: Monday, 26 August 2019 at 18:04
To: SharePoint/sp-dev-fx-controls-react<EMAIL_ADDRESS>Cc: João Mendes<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-fx-controls-react] New Control: Persona Card (#259)
@joaojmendeshttps://github.com/joaojmendes @heinrich-ulbrichthttps://github.com/heinrich-ulbricht @AJIXuMuKhttps://github.com/AJIXuMuK I opened a uservoice feedback to ask (nicely) that Microsoft supports the LPC for 3rd-party developers. Your votes would help: https://sharepoint.uservoice.com/forums/329220-sharepoint-dev-platform/suggestions/38451154-provide-support-for-livepersonacard-in-3rd-party-s
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-fx-controls-react/issues/259?email_source=notifications&email_token=AC7YHVNJCRYDSOEJD3D7Q4TQGQEHRA5CNFSM4HA6AKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5E7U7Q#issuecomment-524941950, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AC7YHVKGULOXXT2O6INS6VTQGQEHTANCNFSM4HA6AKFA.

@joaojmendes @heinrich-ulbricht @AJIXuMuK I opened a uservoice feedback to ask (nicely) that Microsoft supports the LPC for 3rd-party developers. Your votes would help: https://sharepoint.uservoice.com/forums/329220-sharepoint-dev-platform/suggestions/38451154-provide-support-for-livepersonacard-in-3rd-party-s

Hey can I ask what happened with this? I voted for your web part too.
I want a Persona web part so I can use the Graph API to call 'People I work with' and provide a list of users via Graph displayed through the Live Persona Card. Do I have to manually create it through https://docs.microsoft.com/en-us/graph/toolkit/components/person-card?

@hugoabernier we now have a persona control in the library. Can we close this issue?

Absolutely! Thank you!!!


Delegated events inside table get killed when attaching this

This plugin is sooo good! But then it killed my row event handlers.
// Kills all my event handlers inside .my-table
$('.my-table').floatThead();

i don't believe you, unless you were delegating them, in which case you need to change your delegation selector. Either way, if you want me do do something about it, please provide a jsfiddle.

Yes, they were being delegated I believe. It's kind of tough to provide a repo because I'm using it inside a Meteor app.

no, i don't know meteor.
if they were being delegated, then you just need to fix the selector. your thead is moved into another dynamically created table which goes under your table, and perhaps a wrapper depending on which options you used.
you need to float the header, take a look at the dom inspector and see where it is located. you should be able to update your delegation selector to work for both floating mode and non-floating mode.
without seeing your code, this will work:
give your table(s) a new class myTableFoo, change the delegate selector to .myTableFoo tr - this will match tr element in both floating and non-floating mode.

still need help with this?

I haven't gotten a chance to try this out yet, I will try tomorrow.

Still no luck here. It must have something to do with the way the table gets wrapped in the div.

event delegation, if done right, should work. Perhaps meteor is doing some magic behind the scenes that you need to understand before you can solve this.

you can put up the equivalent of a jsfiddle for meteor if you want. I make no promises though since I dont know meteor

reopen if you can come with something reproducing the issue you are facing. Its not a bug with this lib though.


Can we make the space reserved for type annotations on the AutoComplete box wider?

I'm on Ionide-fsharp 3.3.4 and VSCode 1.16.1
Not sure if this is something that Ionide can customize or if it's something hardcoded in VSCode.
With type providers, because the type name is a bit long, the type of members doesn't fit most of the time:

I have to always click the (i) to see the rest, but then there's a lot of wasted space on the dropdown it selft and an extra tooltip that wraps to two lines

VS2017 for comparison:

Unfortunately it's not something we can control.  So I'm going to close issue.
But one additional pro tip ;) - instead of clicking "i" icon, you can press Ctrl+space again to see extra info.


Allow specifying custom task repo - all-in-one PR

Allow users to specify the task repo rather than always using TASK_REPO_URL
Watch out:

.env changes

Testing:
try running a task from another repo

Same as this stack:
https://github.com/METR/vivaria/pull/737 - Add repoName to TaskSource
https://github.com/METR/vivaria/pull/738 - Add taskRepoName to task_environments_t
https://github.com/METR/vivaria/pull/739 - Update the frontend taskRepoUrl function to use the DB taskRepoName
https://github.com/METR/vivaria/pull/740 - Fetch tasks from repos other than TASK_REPO_URL
https://github.com/METR/vivaria/pull/741 - Allow specifying custom task repo
https://github.com/METR/vivaria/pull/742 - Add more params to CopyRunCommandButton
But @sjawhar requested an all-in-one PR

Also, getOrCreateLockFile() is a misleading function. The lock file does not need to exist, its parent directory does.

When I tried it it seemed that the lockfile did need to exist. And when you were encountering errors before, you said it was because wellKnownDir didn't exist, but Vivaria has always put lockfiles in wellKnownDir so I would be surprised if that was the case, I'm pretty sure the errors you were encountering was because the lockfile didn't exist

Please do not merge without fixing the / in the image name

When I tried it it seemed that the lockfile did need to exist.

$ rm -f this_file_does_not_exist.lock && git status && flock this_file_does_not_exist.lock git status
On branch report-run-error-rate
Your branch is up to date with 'origin/report-run-error-rate'.

nothing to commit, working tree clean
On branch report-run-error-rate
Your branch is up to date with 'origin/report-run-error-rate'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        this_file_does_not_exist.lock

nothing added to commit but untracked files present (use "git add" to track)

Flock will create the lock file, that is not the issue

Please do not merge without fixing the / in the image name

I did fix this already in 062ae40


Remove webkitFilter to prevent Chromium WebVR build crashout

One solution for Issue #6 - this simply removes the crash causing line. SVG icons work in Firefox Nightly and behave the same as in Chrome and Safari, which is simply not show.

Wait, the idea was to de-emphasize, not to hide the icon... Are you saying this change just hides it?

This PR has it behave the same way that it does (currently on master and gh-pages) in Chrome and Safari, which is it is missing due to filter not being supported for SVGs. Not ideal in my opinion, just a quick temp solution to prevent it crapping out.
The other PR (#8) I submitted detects the browser version and uses PNGs with opacity again in that case, and uses SVG for other browsers. I was planning another commit though to switch it to contrast, as contrast filtering should work with PNGs. And as mentioned, I've filed a separate issue with Chrome-WebVR on this issues, as it shouldn't crash out, just ignore.


Sometimes readyState 'complete' can be "too late"

See https://github.com/silktide/cookieconsent2/blob/eca71f6a2cfa24c724ba4744e2453ab8d853383f/cookieconsent.js#L343
There's some situation where waiting for document.readyState=='complete' can be a long time. If something in the fame, like an iframe hang the connection forever, the banner is not displayed.
My suggestion is to change this to:
if (!initialized && document.readyState == 'interactive')

This will only wait for the DOMContentLoaded event.

Thanks for your suggestion, although the change cannot be made now as CookieConsent V2 is no longer supported.
CookieConsent V3 does not assume that the user wants to run the script on "document ready". The tool can be initialised at any time, so this is no longer an issue.


Make optional fields come after required fields in a generated Python CST

We can do this with a simple transform on the resulting code that sorts the parameters.

Fixed a couple of commits ago.


[ci] use wch1/r-debug image in Solaris tests

As a result of the changes #3946 , which introduce vignettes/ to the R package (part of #1944), building the R package with R CMD build will include installing the package, since it must be installed to create vignette outputs.
To make this work in the existing Solaris CI job, two changes are required:

pandoc must be available in the container used to build the package before submitting it to R Hub
{lightgbm}'s dependencies must be installed before running sh build-cran-package.sh.

This PR proposes both of those changes. It proposes the re-organization of test_r_package_solaris.sh just to make the diff of #3946 slightly smaller and easier to review.
Changing the image used in the Solaris job (to one that already has pandoc installed) needs to be done in a separate PR, since GitHub Actions configs for jobs triggered by comments are sourced from master  (https://github.com/microsoft/LightGBM/pull/4397#issuecomment-866790489).

Solaris job is working with this change! https://github.com/microsoft/LightGBM/pull/3946#issuecomment-959783925
valgrind timed out (https://github.com/microsoft/LightGBM/pull/3946#issuecomment-959784081), tried triggering it again (https://github.com/microsoft/LightGBM/pull/3946#issuecomment-960242417)


Allow PI's to de-approve a user to remove access from their resources

~NOTE: this is only a discussion topic for now, NOT an enhancement request. We need to discuss options and potential for abuse.~ Decision is to proceed with this as an enhancement.
PI noted they would like to be able to "de-approve" accounts to remove access from their resources. I am envisioning a button with "Remove Access" type wording.

Decision is to proceed with this as an enhancement.

We can't move forward on this until HPC starts using our EventQueue api or a yaml schema is established for this type of operation.


✨ Added a GitHub Actions pipeline for generating docs

This PR adds:

A new workflow file inside the .github directory which uses the pre-included docgen task to generate the documentation for illwill, then automatically deploy a GitHub Pages site by uploading the generated static files as artifacts.

Live Demo
A preview is hosted on my fork: https://hitblast.github.io/illwill
Why?
I found this technique useful for some of my previous projects with and/or without Nim, and since this project was missing a documentation webpage, I thought it'd be useful to add one manually.
⚠ Must enable GitHub Pages inside the project settings and select "GitHub Actions" as source.

Hey @hitblast, this seems interesting, thanks. Can you please point me to the generated GitHub pages using your branch? Just want to preview how it looks like before I merge this 😄

Hey @hitblast, this seems interesting, thanks. Can you please point me to the generated GitHub pages using your branch? Just want to preview how it looks like before I merge this 😄

@johnnovak Hello! I've already mentioned the link to the preview that I've hosted, but here you go:
https://hitblast.github.io/illwill
The workflow looks like this:
https://github.com/hitblast/illwill/actions/runs/8355163831

@johnnovak Hello! I've already mentioned the link to the preview that I've hosted, but here you go:

Ah, my bad, getting tired.
Thanks for this, merging 🚀


smoke test pipeline hook

@jsquire could you please help have a look at https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1432298&view=logs&j=f3570516-c8fe-5ce9-92b2-b737df25d5ea&t=8b1263e5-6598-5fef-152d-3338b5972413? Looks like the test code is now hitting load failures but there isn't any good information as to why.

@jsquire could you please help have a look at https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1432298&view=logs&j=f3570516-c8fe-5ce9-92b2-b737df25d5ea&t=8b1263e5-6598-5fef-152d-3338b5972413? Looks like the test code is now hitting load failures but there isn't any good information as to why.

Looks like Microsoft.Identity.Client.TokenCache is being detected as a parameterless constructor but is throwing because there are missing parameters.    I'll investigate; likely we missed a corner/special case.

@ckairen:  At this point, this PR is the authoritative copy of the updated Smoke Tests code, as we've all been pushing directly to this branch.    Can you please restore the files that were removed here?

@weshaggard Are there any suggestions that you want to put it out before this PR is merged?

/check-enforcer override


Send data from nRF51822 DHT22 to Raspberry Pi 3 using python

As the topic says, I want to create a bunch of wireless temperature sensors, which should send their data to server on my raspberry pi3.
Yesterday I started playing around with the serial example and managed to send the data of the DHT22 to the nRF Toolbox and the nRF UART app. Today I tried to write a simple python program using pybluez to receive my temperature data, but nothing I tried seems to work.
Maybe someone tried something similar and can explain me what I have to do to get my temperature data from my nRF51822 to my raspberry pi3.

You might find reading a copy of http://makebluetooth.com useful.


Compared to the position of the sun in STK, there is a significant difference. Why does this situation occur?

 jd = date_to_jd(2024,8,6,4,0,0)
s_mod = sun_position_mod(jd)
r_mod_j2000 = r_eci_to_eci(MOD(),J2000(),jd)
r_mod_j2000 * s_mod
3-element StaticArraysCore.SVector{3, Float64} with indices SOneTo(3):
 -1.0512053177080336e11
  1.0039274359027356e11
  4.351950513418951e10

STK:
-105129703.817743    100395407.099930    43520964.349647

Hi @blackbutton !
The algorithm we currently have is a "low-precision" implemented from the Astronomical Almanac (and described on Vallado's book). We still lack a high precision Sun position algorithm. Nevertheless, there is a minor problem in your code because sun_position_mod expects the time in TBD (Barycentric Dynamical Time) instead of UTC. The difference between the Terrestrial time and TBD is period by Earth's orbit. Hence, we can assume that both are the same here:
julia> jd = date_to_jd(2024, 8, 6, 4, 0, 0)
2.4605286666666665e6

julia> jd_utc = date_to_jd(2024, 8, 6, 4, 0, 0)
2.4605286666666665e6

julia> jd_tt = jd_utc_to_tt(jd_utc)
2.4605286674674074e6

julia> s_mod = sun_position_mod(jd_tt)
3-element StaticArraysCore.SVector{3, Float64} with indices SOneTo(3):
 -1.05776297878576e11
  9.981141741230861e10
  4.326692615766075e10

julia> s_j2000 = r_eci_to_eci(MOD(), J2000(), jd) * s_mod
3-element StaticArraysCore.SVector{3, Float64} with indices SOneTo(3):
 -1.0512198446655511e11
  1.003914406336404e11
  4.351894032716577e10

Now, if we take the angular difference between the STK answer and the one we just obtained, we get:
julia> s_j2000_stk = [-105129703.817743, 100395407.099930, 43520964.349647]
3-element Vector{Float64}:
 -1.05129703817743e8
  1.0039540709993e8
  4.3520964349647e7

julia> using LinearAlgebra

julia> acosd(s_j2000 / norm(s_j2000) ⋅ s_j2000_stk / norm(s_j2000_stk)) * 3600
3.4026739070005374

The result indicates that we differ from STK by less than 3.5 arcs, which is more that enough for most satellite applications. If you want a really accurate algorithm for satellite purposes, we can implement it here.


SPARKC-104 Add partitionKeyMapper to repartitionByCassandraReplica()

Previously we relied on the implicit mapping of rdd to CassandraRows to
determine a the Primary Key present in the RDD. This patch allows the
user to specify using a column mapper the mapping between the partition
key and the RDD. The interface is the same as if they were saving to
Cassandra.

Looks good, please reformat according to style guide

Although we've had some disagreement on style this is what is listed in http://docs.scala-lang.org/style/declarations.html
class Person(
    name: String,
    age: Int,
    birthdate: Date,
    astrologicalSign: String,
    shoeSize: Int,
    favoriteColor: java.awt.Color)
  extends Entity
  with Logging
  with Identifiable
  with Serializable {
}

So I'll move to match that?

+1


Add identity to messages

It helps to add identity to the envelope, in the following cases:
Using UDP, as messages are dispatched.
Using TCP, if we don't rely on persistent connections.
In the case of RLPx, identities are exchanged during the handshake, and then again when exchanging hellos. That only works because we rely on TCP persistent connections.

Proposal is to add a header to messages. The header is not required, but would be leveraged by application protocols such as the EWP RPC.
I would use the header under the key "signature".
I would also store the signature as a base64 encoded string suffixed by .sig and the curve name, similar to SSB.
                  IousK4cCn9T5qFa8E14GVek4cAMmMbjqDnAg==.sig.ed25519"```

```"z7W1ERg9UYZjNfE72ZwEuJF79khG+eOHWFp6iF+KLuSrw8Lqa6
                  IousK4cCn9T5qFa8E14GVek4cAMmMbjqDnAg==.sig.secp256k1"```


Saving fields creates a new contact

Is your feature request related to a problem? Please describe.
Currently, editing your profile and saving it creates a new contact rather than updating your profile.
Describe the solution you'd like
Saving the edited fields should just update the profile.

Can we confirm that this is still a bug? I believe this was fixed with this commit.

Interesting. The bug is no longer happening for me but was at the workshop yesterday. Can others confirm this? @jordantgiang


Removing unnecessary indirection

@redonkulus @renatoi

CLA is valid!

:shipit:

Coverage remained the same at 100.0% when pulling 9a7b2e9ddbc25c1cf80dbe9e3925dc4cff9921f4 on pkgindex into 9c445b759eaa36b40f2ca1c08547e66014981036 on master.


feat: support patch in envoyService

Fixes: https://github.com/envoyproxy/gateway/issues/2716

@zirain seeing failures in the ClientTimeout e2e test
    --- FAIL: TestE2E/ClientTimeout (31.03s)
        --- FAIL: TestE2E/ClientTimeout/http_client_timeout (31.01s)

@zirain seeing failures in the ClientTimeout e2e test
    --- FAIL: TestE2E/ClientTimeout (31.03s)
        --- FAIL: TestE2E/ClientTimeout/http_client_timeout (31.01s)

sometime, 1ms is a large window for request timeout.


Upgrade Spring 6.1.8 -> 6.1.9

This PR contains the following updates:

Package
Type
Update
Change

Spring
import
patch
6.1.8 -> 6.1.9

Release Notes

spring-projects/spring-framework (Spring)
v6.1.9
Compare Source
:star: New Features

CRaC: ignore checkpointOnRefresh afterRestore #32978
Add missing hints for Hibernate @TenantId #32967
AnnotationUtils performance degrades with deep stacks #32921
Missing hints for Hibernate generators #32842
AbstractAutoProxyCreator#determineBeanType can trigger bean initialization at build time for aspects implementing Ordered #32230

:lady_beetle: Bug Fixes

Behaviour change in ScheduledAnnotationBeanPostProcessor: canceling scheduled tasks on ContextClosedEvent v6.0 -> v6.1 #33009
ContentCachingRequestWrapper  may allocate too much memory #32987
Support canEncode() for JAXBElement in Jaxb2XmlEncoder #32977
AspectJ CTW aspects executed twice #32970
@Valid annotations on container elements for handler argument validation not supported #32964
Add support for double backslashes to StringUtils#cleanPath #32962
@CacheEvict condition uses wrapper comparison instead of actual objects #32960
ConcurrentHashMap.computeIfAbsent used in AdvisedSupport can cause virtual thread pinning #32958
Exception mapping does not work as expected when plugging in ReactorNettyClientRequestFactory into RestTemplate and RestClient #32952
ReactorResourceFactory not working with CRaC onRefresh checkpoint #32945
SpEL compilation fails when indexing into an array or list with an Integer #32908
SpEL compilation fails when indexing into a Map with a primitive #32903
BeanUtils.copyProperties no longer copies generic type properties from a base class that has been enhanced #32888
Application not starting with @EnableTransactionManagement(mode = AdviceMode.ASPECTJ)  #32882
ReactorNettyClientResponse should not throw exception if no body is available #32805
Observation in ServerHttpObservationFilter is never stopped for asynchronous requests #32730

:notebook_with_decorative_cover: Documentation

Fix typo in the Simple Broker section of the reference documentation #32993
Remove outdated copyright from index.adoc #32983
Use HttpStatusCode consistently in reference guide #32966
Entity name in MappingSqlQuery example of reference guide is wrong #32957
Fix RegisterReflectionForBinding Javadoc  #32947
Reference documentation sample for MethodValidationPostProcessor is missing a static keyword #32929
Fix typo in Jakarta validation documentation #32928
Refine KotlinDetector.isKotlinType documentation for Kotlin 2.x lambdas #32905
Complete Kotlin example for HTTP message codecs in reference doc #32877
Use Threadlocal.remove() instead of .set(null) in documentation #32874
Unexpected bean override / inject behavior #32825
Document why complex object structure are not supported as paremeters or properties by AOT #32273

:hammer: Dependency Upgrades

Upgrade to Micrometer 1.12.7 #33001
Upgrade to Reactor 2023.0.7 #33007

:heart: Contributors
Thank you to all the contributors who worked on this release:
@Attacktive, @Seungpang, @deblockt, @hlmg, @ozooxo, @soglad, and @ypyf

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Spring 6.1.8 -> 6.1.9

See:
- https://github.com/spring-projects/spring-framework/releases/tag/v6.1.9
- https://github.com/spring-projects/spring-framework/compare/v6.1.8...v6.1.9


[Question] support deploy  behind a proxy like nginx ?

Question
does hertzbeat support deploy behind a proxy like nginx ?
I tried it, if the contextpath is added, the application cannot be used normally, and the resource paths are all wrong
maybe we can add a server.basePath configuration like kibana?
server.basePath:
Enables you to specify a path to mount Kibana at if you are running behind a proxy. This only affects the URLs generated by Kibana, your proxy is expected to remove the basePath value before forwarding requests to Kibana. This setting cannot end in a slash (/).

hi, hertzbeat support deploy behind a proxy like nginx.

maybe we can add a server.basePath configuration like kibana?

maybe you can try config the application.yml file
server:
  port: 1157
  servlet:
    context-path: /demo

如果在网关层自定义context path，可以使用rewrite移除自定义的路径前缀，例如
location ^~ /hertzbeat {
    rewrite ^/hertzbeat/(.*)$ /$1 break;
    proxy_pass http://hertzbeat;
}

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

If you customize the context path at the gateway layer, you can use rewrite to remove the custom path prefix, for example
location ^~ /hertzbeat {
    rewrite ^/hertzbeat/(.*)$ /$1 break;
    proxy_pass http://hertzbeat;
}

I have tried to use this config:
location ^~ /hertzbeat {
    rewrite ^/hertzbeat/(.*)$ /$1 break;
    proxy_pass http://hertzbeat;
}

Then I can get js code when I directly request the /hertzbeat/xxx.js:

But I find that front-end static resources are directly spliced behind the domain？

So this background is not available. 😥
version: docker image (latest)

Any Update?


Use RGBA8 for png and jpg

The image loader was specifying RGB8 pixel format for JPG, but this incurs a format conversion cost when using ImageBitmap.
This PR standardises on RGBA8 instead, speeding up JPG loading in Chrome.

Nope. GPUs store textures in 32bits anyway, never 24.


crypto.games - coins

updated currency list:
ethereum eth
binancecoin bnb
litecoin ltc
solana sol
dogecoin doge
monero xmr
ethereumclassic etc
bitcoincash bch
dash dash
neogas gas
playmoney play

This version of dicebot is no longer being developed or supported as of May 5, 2023.


WindiCSS problem with CSS variables, double dash prefix is only single dash in the generated javascript files

Hi there.
I am using DaisyUI together with Vite and WindiCSS (vite-plugin-windicss) and it is almost working.
There is one problem with CSS variables, though (Styled components and themes).
DaisyUI uses prejss-cli to convert the css into JS objects.
Strangely, during this conversion, CSS vars get mangled from:
--tw-bg-opacity

To something like this:
-TwBgOpacity

The conversion from kebab to Pascal case would be ok, windicss can handle this, the problem is the deleted dash at the start.
It only happens for CSS variables starting with double dash.
Something in the prejss-cli conversion is going wrong.
If I manually replace all -Tw with --Tw in daisyui/dist/styled.js, the styled components seem to work.

Hi,
I don't think this problem is because how prejss converts the variables because in a Tailwind project, Tailwind uses the same JS object and everything works fine. However Windi seems to read it differently.
As mentioned in this issue @marshallswain is working on the plugin (Thanks to him) and it might get fixed soon.

Ok, I will have a look on how tailwind processes the JS objects. Maybe the WindiCSS team can be convinced to process these the same way. Then an extra plugin would not be strictly necessary I think.
That said, I still think prejss-cli does the wrong thing here, maybe I will look into that too, just curious :)

I found the reason why Tailwind can handle the '-TwBgOpacity syntax':
 dashify
May the WindiCSS team can adapt their parsing to match this, I will ask them :)

I created an issue for WindiCSS: Component generation not 100% compatible to TailwindUI with leading dashes

I created another issue for WindiCSS because themes break because the media style "@media (prefers-color-scheme:dark)" is moved to the end: Component generation moves media CSS styles to the end

@gunters63 I'm glad you confirmed the issue.  I suspected it was a WindoCSS bug, but it's much better that you've identified the actual cause of the bug.

This issue seems to be fixed (https://github.com/windicss/windicss/issues/218)
@gunters63 Can you please update WindiCSS to latest version (2.5.10) and confirm if it works now?

@saadeghi: Yes, can confirm it works now. Now there is only a little problem with theming left which I could work around (copying the CSS, removing the media prefers-dark style and importing it directly with themes: false in daisyui config).

Closing issue as WindiCSS is fixed now


CLOUDSTACK-9069: Newly added project is not showing in the drop down until the browser is refreshed.

The created or deleted project was added to/deleted from the list but it was not being updated.
Now it updates the list at the same time.

LGTM

Isn't this PR the same as #1082?

@rafaelweingartner This PR will merge with current master. and #1082 Will merge in branch 4.6. Thanks.

Closing this PR. As #1082 is there to merge in 4.6. Thanks.


The same thing is already possible in https://github.com/slackapi/bolt-python/pull/113 (the decorator style that is still in review) and workflow_* methods in App/AsyncApp. This is particularly useful for process_before_response option users.
app.step(
    callback_id="copy_review",
    edit=[copy_review_edit, copy_review_edit_lazy],
    save=[copy_review_save, copy_review_save_lazy],
    execute=[copy_review_execute, copy_review_execute_lazy],
)

The existing way to register only one function is still the one we recommend as default. This PR doesn't change anything about it.
app.step(
    callback_id="copy_review",
    edit=copy_review_edit,
    save=copy_review_save,
    execute=copy_review_execute
)

Category (place an x in each of the [ ])

[x] slack_bolt.App and/or its core components
[x] slack_bolt.async_app.AsyncApp and/or its core components
[ ] Adapters in slack_bolt.adapter
[ ] Document pages under /docs
[ ] Others

Requirements (place an x in each [ ])
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

Codecov Report

Merging #127 into main will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   91.08%   91.17%   +0.09%
==========================================
  Files         148      148
  Lines        4184     4195      +11
==========================================
+ Hits         3811     3825      +14
+ Misses        373      370       -3

Impacted Files
Coverage Δ

slack_bolt/app/async_app.py
94.40% <ø> (ø)

slack_bolt/app/app.py
85.04% <100.00%> (ø)

slack_bolt/workflows/step/async_step.py
94.20% <100.00%> (+0.55%)
:arrow_up:

slack_bolt/workflows/step/step.py
94.11% <100.00%> (+0.46%)
:arrow_up:

slack_bolt/listener/thread_runner.py
89.62% <0.00%> (+2.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ecce6b...f570c3b. Read the comment docs.


Illegal reflective access warnings with SoftAssertions and Java 9+ (f…

…ixes #1165)
SoftAssertions: Replace writing to private field detailMessage of Throwable with creation of a new Throwable.

Merged in https://github.com/joel-costigliola/assertj-core/commit/ffe1df787317546ce202276fc9f1202453e12e9b


chore(package): update @rollup/plugin-typescript to version 4.1.1

Closes #96

Coverage remained the same at 100.0% when pulling 6da49b801082ba1228ee62dffb1a9223d80dbb96 on<EMAIL_ADDRESS>into ef6d6e8a95b0ca151ac4759f5e9a363104e72bbb on master.

Coverage remained the same at 100.0% when pulling 6da49b801082ba1228ee62dffb1a9223d80dbb96 on<EMAIL_ADDRESS>into ef6d6e8a95b0ca151ac4759f5e9a363104e72bbb on master.


Insertion actions

I haven't tested everything thoroughly. I will be testing now, you guys also test by inserting everything.
I haven't sanitized input, we will have to take care of it later.
There is no useful addition in the SQL file, I will remove it before merging: don't care about it now.

@pavani-17 @alapan-sau It's almost done: please review now. I think the SQL file can also merge and that we can clean comments later. Otherwise, I will remove it before merging.

Or sud we merge it and check it later?

I went through the code..But sud u check it b4 we merge it? Like once u test all options, merging then makes sense ig
@pavani-17 Did you test it? If yes, I'll merge.


Update Readme

If anyone of you knows how to make nice Readme
Feel free to contribute :)
@hacktoberfest

I'd like to contribute. Please assign!

I would like to contribute to this repository and come up with a good readme. Please Assign this task to me.

I'd like to contribute. Please assign!

Feel free to Contribute ^^

Sorry to bother, but for the prs to count for hacktoberfest you have to add the "hacktoberfest" label to the repository.
Thank You.
https://hacktoberfest.digitalocean.com/hacktoberfest-update


(chore) Move side-effects out of components. Add namespacing to store…

… features #1

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Arkadiusz Szaleniec seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add CI check to run terraform plan

Resolves https://app.clickup.com/t/3cq8zhu

Task linked: CU-3cq8zhu Add CI check to run terraform plan

I decided to go rogue and completely change this PR after getting approvals 😆
I think it makes sense to split the terraform checks into a separate workflow that only triggers is any file changes in the terraform/ directory. That way PRs that only touch python code don't have to wait for a terraform plan to run. Let me know what you think about this!


Need a way to set root context name programmatically

It is usual practice for graphite collectors to have configurable prefix for example "staging.#{machine-name}.MyUserAuthenticationApp.Sql.RequestDurationSeconds". I have seen "Metrics.GlobalContextName" configuration parameter, and it is almost what I would like, but I do not want to set machine name in config file, because of possible chaos it can cause if config files will be copy-pasted around or machine change name, etc.
What I would like to have is to be able programmatically set the root context name where I would be able to append machine name. Or, another option is to have "magic param", where "$env.machine-name$" in config would be replaced with actual name.
If given directions, I can implement it and submit pull request.

@vchekan thanks for the suggestion, it makes perfect sense.
Turns out it is very easy to implement support for "magic params". See https://github.com/etishor/Metrics.NET/commit/93cb1222d190d3a016a034d8d188bb49c8ddfbae for details. The params are case insensitive.
I've also changed the default name for the global context name to include the machine name.
For now only $Env.MachineName$ is implemented. Let me know if you think other parameters would make sense. (feel free to send PR with other params if you need them).
Thanks

Closing this, thanks.


support kubeflow through a new training service

kubeflow is a popular tool for running deep learning jobs. It would be great to add a new training service which could submit kubeflow jobs on kubernetes.

In progress now. Will release it in NNI v0.4 soon.


[Enhancement]: Explain how to use the output from Mode Task

What would you like us to improve?
I had a hard time to figure out how to pass the output from mode task to ethabiencode task, so I think it would be important to explain how it is done.
I suggest adding the following information to the docs regarding mode task (https://docs.chain.link/chainlink-nodes/oracle-jobs/task-types/task_mode):
Using the Output
To pass the results array to ethabiencode task you must specify in the ABI that the data is an array and point the data parameter to "YOUR_MODE_TASK.results" like this:

encode_mode_task [type="ethabiencode" abi="(bytes32 requestId, uint256[] _data)" data="{\\"requestId\\": $(decode_log.requestId), \\"_data\\": $(YOUR_MODE_TASK.results)}"]

How important it is?
I believe it is fundamental to use mode task. As this task is not very common I couldn't find these instructions anywhere.

thanks @marcelofrayha ! we've just made the fix.

Awesome, thanks for the update!
Em sex., 2 de jun. de 2023 às 04:26, Amine E. @.***>
escreveu:

thanks @marcelofrayha https://github.com/marcelofrayha ! we've just
made the fix.
—
Reply to this email directly, view it on GitHub
https://github.com/smartcontractkit/documentation/issues/1234#issuecomment-1573281096,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVW7LAMG2KMJRT46KG5L5ELXJGIRVANCNFSM6AAAAAAWTKAYDU
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add DeploymentOptions to DeploymentPlanner

save some steps in deployment than cutting steps in statsdex
@xichen2020 @robskillington

Coverage increased (+0.1%) to 87.919% when pulling 843c91e1367894283c5518ae334bbf051ed2cdba on chao-batch-size into 0a22c5204b14a9c699d8d8e101b76061f6e33151 on master.

Coverage decreased (-0.6%) to 87.164% when pulling eb10ebeed34ae29404625abdca62d19c9d8c9bfe on chao-batch-size into 0a22c5204b14a9c699d8d8e101b76061f6e33151 on master.


jsdoc linting

I used eslint-plugin-jsdoc to harmonize the jsdoc in the code base. I decided to replace @returns by @return because it is used way more.

This is great.  Thanks, @simonseyock.


Create a setup to use approval tests

See https://github.com/alvarogarcia7/json-schema-tools/pull/2

See #3


Add wildcard support to no-verifier hasPermission

This adds wildcard support to the #hasPermission(Permission permission) method.
EX:
If a player has the permission test.*, test.one and test.two would count as valid permissions when passed through the above hasPermission method.
This is part of one of the two PRs (#401) to help bring better support for permission plugins.

Could you test it?

Added. Works fine on my machine, just have to wait for the CI builds here.

Closed due to no longer being relevant. Feel free to reopen.


Saving and loading nested models fails

EDIT: I adjusted the bug description the bug appears in a different place than I thought before.
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: -
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): unknown 2.1.0 (Installation from conda repository)
Python version: 3.7.6
Bazel version (if compiling from source): -
GCC/Compiler version (if compiling from source): -
CUDA/cuDNN version: -
GPU model and memory: -

Describe the current behavior
I created a simple nested tensorflow.keras model with an input node and sequential model containing two convolutional layers:
import tensorflow as tf
model_inside = tf.keras.models.Sequential([tf.keras.layers.Conv2D(16, 3, input_shape=(None,None,1)),
                                   tf.keras.layers.Conv2D(2, 1, activation='softmax')])

model_outside_input = tf.keras.Input(shape=(256, 256, 1))
model_outside = model_inside(model_outside_input)

model_outside = tf.keras.models.Model(inputs=model_outside_input, outputs=model_outside)

Saving this model to disk in SavedModel format and loading it again results in a TypeError: list indices must be integers or slices, not NoneType.
According to my observations this error only occurs with nested models.
Describe the expected behavior
I expect the loaded model to be exactly the same as before saving it and loading should not lead to an error.
Standalone code to reproduce the issue
https://colab.research.google.com/drive/1Qu32g7WpH_mVtwEvRToueF_Q8SMNMlf3

@soyers I don't see any issue with tf-nightly. Please check the gist here. Thanks!
Please close the issue if the issue resolved for you. Thanks!

@soyers I ran your code as it is in tf-nightly and I don't see any issues. Recently, there were lot of improvements in saving the model. I think this issue was resolved by one of those recent changes.
I am closing this issue as it was resolved. Feel free to reopen if this was not resolved for you. Thanks!


[BUG]: Leader election timeout flags are not present in operator but present in helm for CSI-Powerscale

Bug Description
Leader election timeout flags are not present in operator but present in helm for CSI-Powerscale which is sometimes leading to controller pods restart.
Logs
[root@V99SRH-005753 ~]# oc get pods
NAME                                 READY   STATUS             RESTARTS   AGE
isilon-controller-799fd8765f-****  5/5     Running            0          3m56s
isilon-controller-799fd8765f-****   1/5     CrashLoopBackOff   17         3m56s
isilon-node-****                    2/2     Running            0          3m56s
isilon-node-****                    2/2     Running            0          3m56s

Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce
Install CSI-powerscale driver using operator
controller pods began to restart
Expected Behavior
Controller pods should not be restarted
CSM Driver(s)
CSI Driver for CSI-PowerScale 2.1
Installation Type
operator 1.6.1
Container Storage Modules Enabled
No response
Container Orchestrator
kubernetes 1.22.1
Operating System
OCP 4.8

This has been taken care of with Operator PR.


⚠ Bofrost.de has degraded performance

In 2d4e6b2, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 711 ms

Resolved: Bofrost.de performance has improved in f39ca5f.


Where is code that handles communication with EDEX server for CAVE located?

What class(es) does CAVE use to handle the task of "connect to the EDEX server, find the latest data for {product}, and fetch it"?
Why:
I need to write a program that's able to connect to an EDEX server, find the latest data for GOES-16/CONUS/ABI-L2+/Clear Sky Mask, and fetch it the same way CAVE would.
I'm trying to find the class(es) used by CAVE to do it so I can see how it does it.
Of course, I'm totally open to better ideas. If there's already a way to launch CAVE (or some other existing utility) from a shell script to connect to the EDEX server, find the latest clear sky mask file, and download it, I'd love to know about it. ;-)
Verbose background:
I wrote an Android app that uses the GOES-16 CONUS ABI-L2+ clear sky mask data to help users in South Florida find the best place to watch rocket launches from Cape Canaveral by determining how many cloudy and cloud-free 2km sectors lie along the line of sight between the vantage point and Cape Canaveral.
Initially, I planned to use data from NOAA CLASS. I spent about 2 weeks working on the first version, finally got it to the point where it's usable, then discovered (too late) that the data from CLASS is delayed by an hour and a half.
After searching for a few days, I found a commercial source for fresher data. Unfortunately, it's on an EDEX server (as opposed to a web or ftp server).
So... somehow... I need to write a program that's able to pretend it's a proper AWIPS client (like CAVE) and:

Connect to the EDEX server.

Find the latest data for the GOES-16 CONUS ABI-L2+ clear sky mask

Grab it.

Wrangle it into a NetCDF-format file (if it isn't ALREADY in that form when it comes from the EDEX server), then write it to disc.

Push it via ftp to my shared-host web server so the Android app can grab it. I already know how to do this part. :-)

Thanks!

Closing because I found the classes I need.
For anyone who stumbles across this later with a similar question, the relevant classes are in https://github.com/unidata/awips2-core
Specifically, com.raytheon.uf.common.dataaccess.DataAccessLayer.


Add [BsonProperty] to serialize internal property

Thank you for your awesome project ! It's very well design and very fast.
I just add the feature to serialize an internal property via Attribute [BsonProperty].
Moreover it could be nice if you sign the dll. I will be able to use it in nuget ;)
Thanks again for your work
Kind Regards

Hi @techrising, thanks for your contribuition. I have some questions:

Why not use BsonFieldAttribute that exists? In LiteDB i try to use definition names like "Classes has Properties, Document (Bson) has Fields" - So when I refer to a Class I use "Property", when is Document I use "Field"

By default, internal/protected/private properties could not be serialized - only if has [BsonField]

Hi @mbdavid

Why not use BsonFieldAttribute that exists?

You are perfectly right for the name.I just didn't want to change the implementation of the bson field because it must have a "Name" and that's not something required.
If you don't have a problem with [BsonField] I can change it and use it.

By default, internal/protected/private properties could not be serialized - only if has [BsonField]

Yes only if they have the attribute. I already add few tests (on Mapper_test).
If you want to add this feature on the next release I will create a dedicated test method.

let me know your thoughts and I will do it.

Nice works! I'm merging with master branch and will release this feature with 1.1 version that I'm working on it. Thanks

Thanks! I'm looking forward to try it.
And please sign the dll on nuget ;)


adds 'update PR comment' routes to allowlist

Description of the change
As part of CU-8694k6wnq (Allow notification policy to update PR comment in-place) new endpoints were added for the VCSs, in order to update the PR comments.
Type of change

[ ] Bug fix (non-breaking change that fixes an issue);
[ ] New feature (non-breaking change that adds functionality);
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected);
[ ] Other (miscellaneous, GitHub workflow changes, changes to the PR template);

Checklists
Development

[ ] Lint rules pass locally;
[ ] All tests related to the changed code pass in development;

Code review

[ ] This pull request has a descriptive title and sufficient context for a reviewer. There may be a screenshot or screencast attached;
[ ] This pull request is no longer a draft;

Deployment

[ ] Selected merge strategy is squash merge;
[ ] Changes have been reviewed by at least one other engineer;

Task linked: CU-8694k6wnq Allow notification policy to update PR comment in-place