feat: upgrade React to v16.6.3

This PR provides support for the React version used by React Native v0.58.3 (the current version at time of writing). I've done some thorough testing in the RNTester, but it would be great if some other people could test this PR on their own apps and provide feedback.
Note: This PR does not include any new native features, so there are plenty of react-native commits that still need to be ported over. I plan to make React hooks work inside react-native-macos in a future PR, so that's why this PR was created.

Thanks again for your work!


Host Javascript API docs (close #1255)

This PR adds hosted api docs to gh-pages for the browser and node trackers. The homepage can be found here:
https://snowplow.github.io/snowplow-javascript-tracker/docs/

@rlh1994 I'll need to apply for an API key from algolia, but yeah assuming we get approved it shouldn't be an issue


two instances on one page

Hi guys thanks for this lib. I want to report a bug. Chrome shows these warnings when I have two rtes on page

Thanks, I will check this out.

Still appening ^^ It's just because ids are generated the same way so you have many items with the same ID

Can you check this, it's annoying and not very hard to solve i think

Thank you. From version 1.15.0 you can set an id for each editor to avoid this warnings.


Update 0.18 to 0.18.1

Just updating to the latest version of bitcoin-core: https://bitcoin.org/en/release/v0.18.1

Perfect, thank you @victorperin!


Add simpler API for invoking prerendering without using tag helper

Although the asp-prerender-module tag helper is usually the most convenient and natural way to invoke prerendering, there are some cases where you'd want to do it from controller code, or from a code block in your Razor page. For example, you might want to receive back additional custom data values from prerendering, and then maybe use them to set the page title or similar. Or you might want to change how the globals values are serialized and delivered to the client.
Currently it is possible to do this by invoking Prerenderer.RenderToString directly. However it's inconvenient, because you have to duplicate some non-obvious logic from the tag helper. For example, to run prerendering from controller code, currently you need something like this:
var requestFeature = Request.HttpContext.Features.Get<IHttpRequestFeature>();
var unencodedPathAndQuery = requestFeature.RawTarget;
var unencodedAbsoluteUrl = $"{Request.Scheme}://{Request.Host}{unencodedPathAndQuery}";
var prerenderResult = await Prerenderer.RenderToString(
    hostEnv.ContentRootPath,
    nodeServices,
    new JavaScriptModuleExport("ClientApp/dist/main-server"),
    unencodedAbsoluteUrl,
    unencodedPathAndQuery,
    /* custom data parameter */ null,
    /* timeout milliseconds */ 15*1000,
    Request.PathBase.ToString()
);

ViewData["SpaHtml"] = prerenderResult.Html;
ViewData["Title"] = prerenderResult.Globals["pageTitle"];

We should consider migrating this logic out of PrerenderTagHelper and into some new DI service class that PrerenderTagHelper starts using. Then developers will be able to grab instances of that new service class and do custom prerendering much more easily. Ideally, you'd be able to do something like this directly in a Razor view:
@inject Microsoft.AspNetCore.SpaServices.Prerendering.IPrerenderer prerenderer
@{
    var prerenderResult = await prerenderer.RenderToString("ClientApp/dist/main-server");
}
...
<EMAIL_ADDRESS><app>@Html.Raw(prerenderResult.Html)</app>

There could be an options param for overriding things like the request URL, timeout, etc., but by default it would use values from the context automatically like asp-prerender-module already does.

Thank you for looking into this @SteveSandersonMS ! :100: :100:
It seemed like a change that would have to happen with the underlying Prerenderer, tried everything on my end with no luck.
Also for those wondering what the use-case for this is:
Since we're allowing .NET (MVC) to have control over the overall <html>, when we prerender applications through prerenderer.RenderToString, although we can pass variables through globals onto the window., we're still unable to effect the html that's output from the MVC View.
Being able to manipulate <title> and <meta> tags is crucial for SEO when it comes to server-rendered pages (ie: social-media deeplinking, link previews, etc)
Your example looks like it would be perfect for this!
@inject Microsoft.AspNetCore.SpaServices.Prerendering.IPrerenderer prerenderer
@{
    var prerenderResult = await prerenderer.RenderToString("ClientApp/dist/main-server");
}
...
<html>
  <head>
<EMAIL_ADDRESS>
    <!-- meta tags -->
    <meta name="description"<EMAIL_ADDRESS>    <meta name="keywords"<EMAIL_ADDRESS>
    <!-- and so on, for the remaining meta / FB: / og: / twitter: meta tags -->
    <meta name="fb:app_id"<EMAIL_ADDRESS>
  </head>
  <body>
    <app>@Html.Raw(prerenderResult.Html)</app>
  </body>
</html>

One last question, would this be an alternative to the way we're currently doing things, or would all the templates need to be changed in this way? I feel that ideally they might as well all change, because eventually everyone will get to the point where they realize they need to update the Title / etc.

(On the Angular side) I have a way of extracting the title/meta data from the serialization, but I'm going to look into making it even easier & cleaner.
Ideally it'd be great to have Universal do something like this, I brought it up that normal meta manipulation won't work with .NET for the reasons above, so I'm hoping I can somehow convince them to add this in there.
    platform.serializeModule(AppModule)).then( result => {
        resolve({
           html: result.html,
           globals: result.meta // <--
        });
    };

@MarkPieszak Is there any reason not to switch to code you provided in last post?
Only thing that comes to my mind is asp-append-version attribute that is used for cache busting.

The code will actually be slightly similar to the above :)
Of course some of those APIs have changed in Angular 4.x since I wrote that, but so far I have it working, and am able to extract out styles (to be placed in the correct location), Title, and only place in the correct Html from the serialized application (instead of the entire <html><head>... etc)
We're still in beta, but I should be updating it in my repository once everything is ironed out more, I'm also going to eventually abstract out some of the logic so it's much cleaner in the boot-server file.
We're getting there though! 😄  @hheexx

Thanks @MarkPieszak ,
I'm willing to help if I can.
I have a finished website that is blocked by SEO. Sorry for making pressure but it's very urgent for me :)
I hope you can commit something around RC time :)

Not a problem totally understand!
You need Title & Meta tag support as well right?
If we can't get it within this repo, I'll at least have it within mine soon so you can patch your project with it. No worries 👍 @hheexx

Just on a side-note:
I'm using the code at the top of this thread in my HomeController.
I had to add
            var redirectUrl = prerenderResult.RedirectUrl;

            if (redirectUrl != null)
                return LocalRedirect(redirectUrl);

to make redirects in my react-router work:
        <Redirect from='/de/selbstbedienung' to='/de/distribution/selbstbedienung' />

I've developed an web application built  using ASP.NET Core Web API and Angular 4. My module bundler is Web Pack 2.
So I cannot use this piece of code: ViewData["SpaHtml"] = prerenderResult.Html; from my controller. I do not have any cshtml views., so I cannot send data from controller to view through ViewData["SpaHtml"].
But I would like to use server side prerendering. I would like to add metatags into head:
`import { Meta } from '@angular/platform-browser';
constructor(
private metaService: Meta) {
}
let newText = "Foo data. This is test data!:)";
//metatags to publish this page at social nets
this.metaService.addTags([
// Open Graph data
{ property: 'og:title', content: newText },
{ property: 'og:description', content: newText },        {
{ property: "og:url", content: window.location.href },
{ property: 'og:image', content: "http://usiter.com/uploads/20111118/zhivotnie+koshki+kartinka+s+malenkim+kotyonkom+35121656913.jpg" }]);`
Is it possible to do without "ViewData"?`

You receive rendered html string from node.js.
You can do whatever you want to it and you can return it directly from controller like:
return Content(htmlStr)

@hheexx ok, how can I add meta tags from controller to html page?

html page is in a string so you need to find a way to find the right spot and insert meta in.

Why is this so poorly documented? I can't find anything online explaining exactly how to use Prerenderer directly except this github issue.

You can see an example of it in action here @mryarbles
https://github.com/MarkPieszak/aspnetcore-angular2-universal/blob/master/Server/Controllers/HomeController.cs

@hheexx  I have a way to send data to be added to metatags and this data correctly is added to metatags:
import { Meta } from '@angular/platform-browser';

constructor(
private metaService: Meta) {
}

let newText = "Foo data. This is test data!:)";
//metatags to publish this page at social nets
this.metaService.addTags([
// Open Graph data
{ property: 'og:title', content: newText },
{ property: 'og:description', content: newText }, {
{ property: "og:url", content: window.location.href },
{ property: 'og:image', content: "http://www.freeimageslive.co.uk/files
/images004/Italy_Venice_Canal_Grande.jpg" }]);

However, Search engines, Facebook, Twitter does not show my images when I try to post news at Facebook, Twitter or other social nets. I've explored why it happens and the reason is that SEO does not run JavaScript code. So when I post I do not see images.

There's now a new API for this. It looks extremely similar to the proposal in this issue. Sample usage: https://github.com/aspnet/JavaScriptServices/commit/94fc84a9b457839802831544daab1a0da88fbec1#diff-ac9fabb76766dea5d503c5a5387e88e4
Further docs will come later. This will be included in version 2.0.0 of the SpaServices package.


govaluate types mismatch

Summary
I am trying to run a workflow with some conditional steps(I am trying to figure out if a new branch in GitLab was created):
when: "{{inputs.parameters.sha-before}} !=<PHONE_NUMBER>000000000000000000000000000000 && {{inputs.parameters.sha-after}} ==<PHONE_NUMBER>000000000000000000000000000000"
But this comparison would fail with an error:
Error node gitlab-workflow-render-gb79x[0]: Invalid 'when' expression '5d1ca167fd6272d60bbf69f49f0a0ca502765081 == '0000000000000000000000000000000000000000' && 5d1ca167fd6272d60bbf69f49f0a0ca502765081 != '0000000000000000000000000000000000000000'': Cannot transition token types from NUMERIC [5] to VARIABLE [d1ca167fd6272d60bbf69f49f0a0ca502765081]
It looks like govaluate thinks that commit hash is of some numeric type...
Diagnostics
What Kubernetes provider are you using?
Yandex Cloud
What version of Argo Workflows are you running?
3.0.1
Paste a workflow that reproduces the bug, including status:
kubectl get wf -o yaml ${workflow}

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  annotations:
    argo: workflows
  labels:
    env: devdynamic
    events.argoproj.io/action-timestamp: "1617984446200"
    events.argoproj.io/sensor: gitlab-project-render
    events.argoproj.io/trigger: gitlab-workflow-render-trigger
    workflows.argoproj.io/completed: "true"
    workflows.argoproj.io/controller-instanceid: system-controller
    workflows.argoproj.io/phase: Failed
  name: gitlab-workflow-render-fw6mg
  namespace: argo-events
spec:
  arguments:
    parameters:
    - name: ref
      value: master
    - name: sha-before
      value: 5d1ca167fd6272d60bbf69f49f0a0ca502765081
    - name: sha-after
      value: 5d1ca167fd6272d60bbf69f49f0a0ca502765081
  entrypoint: infra-handler
  templates:
  - inputs:
      parameters:
      - name: sha-before
      - name: sha-after
    metadata: {}
    name: infra-handler
    outputs: {}
    serviceAccountName: argo-events-sa
    steps:
    - - arguments:
          parameters:
          - name: ref
            value: '{{workflow.parameters.ref}}'
        name: create-on-branch-commence
        template: infra-generator
        when: '{{inputs.parameters.sha-before}} ==<PHONE_NUMBER>000000000000000000000000000000
          && {{inputs.parameters.sha-after}} !=<PHONE_NUMBER>000000000000000000000000000000'
      - arguments:
          parameters:
          - name: ref
            value: '{{workflow.parameters.ref}}'
        name: destroy-on-branch-abstand
        template: infra-destroyer
        when: '{{inputs.parameters.sha-before}} !=<PHONE_NUMBER>000000000000000000000000000000
          && {{inputs.parameters.sha-after}} ==<PHONE_NUMBER>000000000000000000000000000000'
  - container:
      args:
      - echo
      - branch created= {{inputs.parameters.ref}}
      image: argoproj/argosay:v2
      name: ""
      resources: {}
    inputs:
      parameters:
      - name: ref
    metadata: {}
    name: infra-generator
    outputs: {}
    serviceAccountName: argo-events-sa
  - container:
      args:
      - echo
      - branch deleted= {{inputs.parameters.ref}}
      image: argoproj/argosay:v2
      name: ""
      resources: {}
    inputs:
      parameters:
      - name: ref
    metadata: {}
    name: infra-destroyer
    outputs: {}
    serviceAccountName: argo-events-sa
  ttlStrategy:
    secondsAfterSuccess: 5
status:
  artifactRepositoryRef:
    default: true
  conditions:
  - status: "True"
    type: Completed
  finishedAt: "2021-04-09T16:11:08Z"
  message: 'Invalid ''when'' expression ''5d1ca167fd6272d60bbf69f49f0a0ca502765081
    ==<PHONE_NUMBER>000000000000000000000000000000 && 5d1ca167fd6272d60bbf69f49f0a0ca502765081
    !=<PHONE_NUMBER>000000000000000000000000000000'': Cannot transition token types from
    NUMERIC [5] to VARIABLE [d1ca167fd6272d60bbf69f49f0a0ca502765081]'
  nodes:
    gitlab-workflow-render-ffq9c:
      children:
      - gitlab-workflow-render-ffq9c-4264465097
      displayName: gitlab-workflow-render-ffq9c
      finishedAt: "2021-04-09T16:11:08Z"
      id: gitlab-workflow-render-ffq9c
      inputs:
        parameters:
        - name: sha-before
          value: 5d1ca167fd6272d60bbf69f49f0a0ca502765081
        - name: sha-after
          value: 5d1ca167fd6272d60bbf69f49f0a0ca502765081
      message: 'Invalid ''when'' expression ''5d1ca167fd6272d60bbf69f49f0a0ca502765081
        ==<PHONE_NUMBER>000000000000000000000000000000 && 5d1ca167fd6272d60bbf69f49f0a0ca502765081
        !=<PHONE_NUMBER>000000000000000000000000000000'': Cannot transition token types
        from NUMERIC [5] to VARIABLE [d1ca167fd6272d60bbf69f49f0a0ca502765081]'
      name: gitlab-workflow-render-ffq9c
      phase: Failed
      startedAt: "2021-04-09T16:11:08Z"
      templateName: infra-handler
      templateScope: local/gitlab-workflow-render-ffq9c
      type: Steps
    gitlab-workflow-render-ffq9c-4264465097:
      boundaryID: gitlab-workflow-render-ffq9c
      displayName: '[0]'
      finishedAt: "2021-04-09T16:11:08Z"
      id: gitlab-workflow-render-ffq9c-4264465097
      message: 'Invalid ''when'' expression ''5d1ca167fd6272d60bbf69f49f0a0ca502765081
        ==<PHONE_NUMBER>000000000000000000000000000000 && 5d1ca167fd6272d60bbf69f49f0a0ca502765081
        !=<PHONE_NUMBER>000000000000000000000000000000'': Cannot transition token types
        from NUMERIC [5] to VARIABLE [d1ca167fd6272d60bbf69f49f0a0ca502765081]'
      name: gitlab-workflow-render-ffq9c[0]
      phase: Error
      startedAt: "2021-04-09T16:11:08Z"
      templateScope: local/gitlab-workflow-render-ffq9c
      type: StepGroup
  phase: Failed
  progress: 0/0
  startedAt: "2021-04-09T16:11:08Z"

Paste the logs from the workflow controller:
kubectl logs -n argo $(kubectl get pods -l app=workflow-controller -n argo -o name) | grep ${workflow}

time="2021-04-09T16:11:08.683Z" level=info msg="Processing workflow" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.689Z" level=info msg="Updated phase  -> Running" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="Steps node gitlab-workflow-render-ffq9c initialized Running" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="StepGroup node gitlab-workflow-render-ffq9c-4264465097 initialized Running" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=error msg="Mark error node" error="Invalid 'when' expression '5d1ca167fd6272d60bbf69f49f0a0ca502765081 ==<PHONE_NUMBER>000000000000000000000000000000 && 5d1ca167fd6272d60bbf69f49f0a0ca502765081 !=<PHONE_NUMBER>000000000000000000000000000000': Cannot transition token types from NUMERIC [5] to VARIABLE [d1ca167fd6272d60bbf69f49f0a0ca502765081]" namespace=argo-events nodeName="gitlab-workflow-render-ffq9c[0]" workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="node gitlab-workflow-render-ffq9c-4264465097 phase Running -> Error" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="node gitlab-workflow-render-ffq9c-4264465097 message: Invalid 'when' expression '5d1ca167fd6272d60bbf69f49f0a0ca502765081 ==<PHONE_NUMBER>000000000000000000000000000000 && 5d1ca167fd6272d60bbf69f49f0a0ca502765081 !=<PHONE_NUMBER>000000000000000000000000000000': Cannot transition token types from NUMERIC [5] to VARIABLE [d1ca167fd6272d60bbf69f49f0a0ca502765081]" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="node gitlab-workflow-render-ffq9c-4264465097 finished: 2021-04-09 16:11:08.690595529 +0000 UTC" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="step group gitlab-workflow-render-ffq9c-4264465097 was unsuccessful: Invalid 'when' expression '5d1ca167fd6272d60bbf69f49f0a0ca502765081 ==<PHONE_NUMBER>000000000000000000000000000000 && 5d1ca167fd6272d60bbf69f49f0a0ca502765081 !=<PHONE_NUMBER>000000000000000000000000000000': Cannot transition token types from NUMERIC [5] to VARIABLE [d1ca167fd6272d60bbf69f49f0a0ca502765081]" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="Outbound nodes of gitlab-workflow-render-ffq9c is []" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="node gitlab-workflow-render-ffq9c phase Running -> Failed" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="node gitlab-workflow-render-ffq9c message: Invalid 'when' expression '5d1ca167fd6272d60bbf69f49f0a0ca502765081 ==<PHONE_NUMBER>000000000000000000000000000000 && 5d1ca167fd6272d60bbf69f49f0a0ca502765081 !=<PHONE_NUMBER>000000000000000000000000000000': Cannot transition token types from NUMERIC [5] to VARIABLE [d1ca167fd6272d60bbf69f49f0a0ca502765081]" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="node gitlab-workflow-render-ffq9c finished: 2021-04-09 16:11:08.690708242 +0000 UTC" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="Checking daemoned children of gitlab-workflow-render-ffq9c" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="Updated phase Running -> Failed" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="Updated message  -> Invalid 'when' expression '5d1ca167fd6272d60bbf69f49f0a0ca502765081 ==<PHONE_NUMBER>000000000000000000000000000000 && 5d1ca167fd6272d60bbf69f49f0a0ca502765081 !=<PHONE_NUMBER>000000000000000000000000000000': Cannot transition token types from NUMERIC [5] to VARIABLE [d1ca167fd6272d60bbf69f49f0a0ca502765081]" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="Marking workflow completed" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="Doesn't match with archive label selector. Skipping Archive" namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.690Z" level=info msg="Checking daemoned children of " namespace=argo-events workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:08.715Z" level=info msg="Workflow update successful" namespace=argo-events phase=Failed resourceVersion=16881938 workflow=gitlab-workflow-render-ffq9c
time="2021-04-09T16:11:18.683Z" level=info msg="Workflow processing has been postponed due to max parallelism limit" key=argo-events/gitlab-workflow-render-ffq9c

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Maybe quote the numbers
"'{{inputs.parameters.sha-before}}' != '0000000000000000000000000000000000000000' && '{{inputs.parameters.sha-after}}' == '0000000000000000000000000000000000000000'"

I've tried quoting zeroes hoping it would cast template to string-it didn't work. Will try your solution with quoting both parts... Thanks!

What @alexec suggested worked for me. I.e. "'{{workflow.parameters.<your-param>}}' != '<your-string>'". Although in our setup (GKE + ArgoCD) the double quotes got converted to 2 single quotes and the single quotes as well.


questions about the dielectric constant setup

I noticed that the data type of your model is float, in some special cases, dielectric constant is complex, which means there is some loss in the material (such as metal).
So, are there methods to apply the imaginary part dielectric constant into Legume model? Is it possible to calculate a PhC slab with loss?
Thank you!

Unfortunately no, legume currently only accepts real permittivity. There are various complications with lossy modes, specifically with properly ortho normalizing the basis set.
I think what you may have seen as complex is the Fourier transform of the permittivity. For a real valued field this is still complex, but has the property that e(G) = e(-G)*

Thank you for your reply!
What I want to do is to calculate the band stucture of  a PhC slab with loss, which means the permittivity has imagniary part. I will find other ways to do ti.Thank you again.


[Text Analytics] Add links to GitHub issues for tracking

API change check
API changes are not detected in this pull request.


First draft of incubation document.

Here is a very rough draft of an incubation process. More to follow tomorrow, but would love early feedback.

@jupyter/steeringcouncil

Can we add a sentence to say that in particuliar cases this process might not be set in stone, for example if the incubation need changes to one of the core repos, or any other subproject that would not make sens as standalone ?

+1 otherwise.

I think this is sensible. I like the proposal process and the proposals repo. I'm not sure making repos for each incubated project is always going to make sense, but I think it's an okay default pattern.
The case I don't see covered, and maybe it doesn't need to be, is projects that start or end outside Jupyter, rather than starting their life in incubation.

A project is started on a personal org and eventually it is decided that it should become an official project. Is there an incubation process at all? Do we follow the proposal process but skip the incubator repo?
An incubated project is rejected from Jupyter, but the advocates decide they want to maintain it outside Jupyter. Should there be any language around that? The license file, for instance, would need to change.

Another case we may want to address: how do we handle incubator proposals that are patches to main repos? Does the incubator repo contain a fork of the target jupyter repo? Or is there no incubator repo, and just a PR?

A project is started on a personal org and eventually it is decided that it should become an official project. Is there an incubation process at all? Do we follow the proposal process but skip the incubator repo?

I was thinking about this too. I think a project can incubate anywhere, potentially. I think this new incubation org for Jupyter is just a convenience that may bring higher visibility to a project (i.e., I know where to look for cool new Jupyter stuff if it's all under github.com/jupyter-incubator or something).

Another case we may want to address: how do we handle incubator proposals that are patches to main repos? Does the incubator repo contain a fork of the target jupyter repo? Or is there no incubator repo, and just a PR?

We don't want to introduce overweight process for flows that have been working just fine so far. So I think there's just a PR for changes that are not "earth shatteringly large". Of course, a definition of what's too big to go into one of the main repos without a proposal or incubation will need to evolve. (Strawman: if the maintainers of an existing repo feel there's not consensus on a big change, it should probably be a proposal.)

I talked to Kyle (@rgbkrk) yesterday about the case of projects that end up "incubating" as someones personal repo, not in the official incubator org. Kyle thought that those subprojects could complete the second part of the incubation application and immediately graduate to the main org.
I can also imagine that it would be useful to have a brief period of incubation, but the two step process is probably overkill.
I can add language about rejected project moving their code elsewhere.
Your example of an incubation subproject that ends up becoming a patch to other main repos is a good one. My thought is that we would eventually "retire" the incubator subproject and have their proposal PR point to the main repo.

I like the overall idea.  It feels to me like this proposal starts out very thoughtful and comprehensive, and by the time we get to the graduation phase, it's still pretty bare-bone.  I'd be exhausted writing by the time I got down there too.

OK I have taken another pass at the document. I think I have addressed all comments. Here are some of the main outstanding questions:

Which repo do we use for the incubation/graduation proposals. Two ideas are jupyter-incubator/proposals or the JEP repo.
What word do we want to use for the Steering Council member that is the mentor/sponsor/champion. I think it is important to pick one and stick with it to avoid confusion with the terminology of Apache, where these are separate roles in the incubation process.

Once this phase is done, I will create an application template in the relevant repo for subprojects to use.

Did you push  your changes?  It seems like a lot of my small comments are still to be addressed.

Um, no...guess I should do that...done

Regarding the outstanding questions:

Do we want to introduce the idea of a repository/Subproject maintainer?
We suggest to allow the proposer of the incubation effort to be assigned as a maintainer (admin of the github team for the new incubator projects).

Which repo do we want to use for the incubator proposals?
JEP so that a single place exists for all proposals (incubation and mainline)

Mentor? Sponsor? Champion?
Champion is a Steering Council member that aids and stewards the incubation team through the Incubation process.

I think my thoughts are mainly summarized as: This makes sense as something we should allow, but we shouldn't impose every piece of it. We should be careful that many of these things should be MAY instead of MUST, and it should be very clear and small what MUST be done.

Other than my small, but important point at the top about corporate, I'm quite happy with this. Brian, many thanks for pushing!
Others have raised a bunch of good specific points, so I won't belabor those...  While detailed, in practice it's not actually burdensome, and I hope people will realize that we're not making anything too bureaucratic, only trying to balance flexibility of development,  long-term sustainability of repos/projects and the growth of the community.

@minrk, do you feel that it's still too strong in places? Too many 'musts'? I think your point is an important one: we don't want to come across as more bureaucratic/ham-fisted than necessary...

@fperez The implication of this document is that nobody will ever create a repo on the jupyter org without going through the full incubation process. That seems too far, to me. I think the whole incubation document should indicate that this is a way to assemble a Jupyter project, and not the way.

That seems too far, to me. I think the whole incubation document should indicate that this is a way to assemble a Jupyter project, and not the way.

I agree with @minrk thoughts here...

@minrk - great point. I talked to Kyle about this the other day. His
thought was that the incubator process should only apply to truly "new"
efforts that are not simply us continuing our work on existing things but
in different repos. I definitely want to continue to make it easy for us to
create new repos in the normal course of our work. It probably shouldn't
apply to thing we know for sure are already right at the center of the
projects activities. I will add some notes about that that clarifies when
this process applies. If in doubt, probably makes sense to have the
Steering Council consensus about whether incubation is needed.
On Fri, Sep 4, 2015 at 4:58 AM, Damián Avila<EMAIL_ADDRESS>wrote:

That seems too far, to me. I think the whole incubation document should
indicate that this is a way to assemble a Jupyter project, and not the way.
I agree with @minrk https://github.com/minrk thoughts here...
—
Reply to this email directly or view it on GitHub
https://github.com/jupyter/governance/pull/3#issuecomment-137717021.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

The main point that I agree with is this:

For general community projects, I agree. But for individuals at companies that only have permission to contribute to Jupyter, the incubator is their only way of getting experimental stuff out to the community.

We should enable developers whose corporations prefer certain ways to on-ramp contributions intended to be contributed to Jupyter (when not in the form of a PR). This sounds abstract, but the contributions that IBM would like to make fall into this camp. We should enable them as much as possible.
I personally don't forsee myself creating projects in incubation, I'll just create them in personal repos or orgs and collaborate with others. If it seems like it makes sense as a Jupyter project, then it can move then. No different than what we've done before. This can't become the only way to on ramp, otherwise we're favoring a particular corporate model rather than the simplified community on GitHub model.

OK I think I have address @minrk and @fperez recent comments.

+1 to merge after the last round of changes @ellisonbg is about to make after the S. council call. With those small fixes, I'm good to go. Thanks everyone!

One point I wanted to bring up on the incubation process is that we should be careful that the incubated projects don't cannibalize the core ones.
We should encourage contributions to core projects over what could be practically forks.
A small team can get a new feature out faster in such a repository than if they have to go through the process of being reviewed by the maintainers of a core project, and it can be tempting for a developer to iterate quickly on a given feature, which would make it a slippery slope in my opinion.

Good point by @SylvainCorlay.  Obviously that's the risk we always have of competition, but we may wan to explicitly indicate that we want to, when possible, encourage contribution into our core projects to avoid this issue.
You're basically describing the innovator's dilemma ;)

Yes, it would be nice to add some language with respect to the fact that we prefer evolutions of the core repos over alternatives when evolution is possible. Otherwise, we may end up endorsing forks...

Hi folks, I just pushed a bunch of changes. I am still in the middle of the reorganization - maybe wait until I finish edits to do another round of comments.

@jupyter/steeringcouncil @vinomaster @parente
OK folks this is ready for another round of comments. I went ahead and did the larger reorganization/refactor of the content we talked about.

Here is a PR on the jupyter-incubator/proposals repo that adds a proposal template and basic instructions on how to use that template
@vinomaster @jupyter/steeringcouncil @parente

I think this is looking better and better.  Thanks again for working on this!

Thanks for the feedback! I will make another pass tomorrow to address your
comments.
On Sat, Sep 5, 2015 at 8:26 PM, Jason Grout<EMAIL_ADDRESS>wrote:

I think this is looking better and better. Thanks again for working on
this!
—
Reply to this email directly or view it on GitHub
https://github.com/jupyter/governance/pull/3#issuecomment-138037168.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Needs rebase

LGTM as is... if more iteration are needed we can do it in another PR.

rebased!

:+1:

Thanks for everyone going back and forth on this to flesh it out!

8/10 Steering Council members have voted unanimously to approve and merge this governance change. Thanks everyone! Let the incubations begin!

Thanks @ellisonbg and everyone else for jumping all over this. We'll be coming to get some advocate names for our proposals soon. ;)

Delighted to have you on board, folks!!


GUI: Incorrect text on recovery screen

This is not the coin recoverable at the current blockheight, but those that will be spendable through the recovery path in the next block.

I started reworking this screen.
First thing I did is :

Align the image and title
Change the text as mentioned in the issue
Remove the "1/2" subtitle => I think it can be misleading, it was for me as I had 2 coins to recover, and thought it could mean it apply only for the first one.
Switched the two inputs: address and feerate

Should I continue working on that screen and open a PR ?

Nice !
Good job for finding your way in the entangled forest of components of the GUI.
From what you described, your changes should fix the current issue so feel free to open a PR with your current state.
Next screen after the recovery transaction generation will be radically changed by the new multisig PR #289, so no need to change it.
In case you want to learn more about the iced framework, the documentation is quite missing but the examples examples are a good way to start understand the elm architecture.
(I am myself still struggling to understand what are the good patterns and good practice).
Cheers

Yes it reminds me the early days of Android development, I'm used to work with messy stuff :sweat_smile:
OK thank you for all these info, I'll open a PR and look at these examples!
Cheers


Wasm: remove stack machine model

Simplify the Wasm dev backend by removing an optimisation that isn't paying for itself!
In https://github.com/roc-lang/roc/pull/5851#issuecomment-1775876646 I mentioned that the most complicated part of the Wasm dev back end is the model of the VM's stack machine. On thinking about it some more, I realised it actually causes more problems than it solves.
The model is supposed to let us shrink our code size. But the actual results are not very impressive.
Disk space for all test_gen binaries with stack model: 759592 bytes
Disk space for all test_gen binaries without stack model: 759688 bytes
So across 1250 tests this optimisation seems to have only saved us 96 bytes!
But it looks really impressive on tiny snippets. That's why I did it in the first place.
The total runtime for cargo test-gen-wasm goes from 7.428s to 7.412s (based on hyperfine with 10 runs).
Details
Below is the less-optimal code this PR generates for 1 + 2 + 3 (as I64)

Each Roc symbol is assigned a local variable (because i64 is a Wasm primitive type).
Each let statement in the IR is directly translated to an assignment to a local variable, using a local.set instruction.
But often after setting the variable we immediately "get" it again. This is inefficient, but easier to generate because it's a more direct mapping from the Roc IR.

  (func $main (type 52) (result i64)
    (local i64 i64 i64 i64 i64 i64)
    block  ;; label = @1
      i64.const 1
      local.set 1
      i64.const 2
      local.set 2
      local.get 1
      local.get 2
      call $roc_builtins.num.add_or_panic.i64
      local.set 3
      i64.const 3
      local.set 4
      local.get 3
      local.get 4
      call $roc_builtins.num.add_or_panic.i64
      local.set 5
      local.get 5
      local.set 0
      br 0 (;@1;)
    end
    local.get 0)

Here's the more efficient code that we currently generate.
You can see that there is a lot less local.set and local.get because we're able to model the stack machine and understand what's stored in it. But that makes the code generator more complex.
  (func $main (type 52) (result i64)
    (local i64)
    block  ;; label = @1
      i64.const 1
      i64.const 2
      call $roc_builtins.num.add_or_panic.i64
      i64.const 3
      call $roc_builtins.num.add_or_panic.i64
      local.set 0
      br 0 (;@1;)
    end
    local.get 0)

So we're making the generated code worse?
Yep. But it only seems to matter for really simple snippets like the one above.
The effect is smaller in more complex code with block scopes and control flow. And the size of the final binary is often dominated by platform/libc code and constant data (we have dead code elimination but no dead data elimination).
Across all our test binaries it saves very little. I'm actually quite surprised at how little.
And it makes the code generator a lot more complicated, as you can see in the size of the diff.
I think this simplification is worth it.
Alternative implementation idea
What if we realise we really need this optimisation?
It would be much simpler to operate on the generated instructions after generating them. While generating each function, we'd remember which variables are only used once. Then we'd do a quick pass to detect the set/get pattern and eliminate the instructions.
But we have avoided anything multi-pass, and that led to this complex implementation.
Reviewer tips
Don't review the files in the order they're displayed in GitHub!
The changes logically start in code_builder.rs and storage.rs, so review these first!

code_builder.rs no longer tracks which mono IR Symbols are in the stack machine
code_builder.rs no longer needs info about how many pushes and pops each instruction does.
storage.rs no longer models data being stored in the Wasm VM stack machine

Those lead to consequences in backend.rs, low_level.rs, and everything else.

Zulip discussion: https://roc.zulipchat.com/#narrow/stream/395097-compiler-development/topic/Removing.20a.20Wasm.20optimisation

Thanks for reviewing, @folkertdev !


Compiler error: "FieldGenerator.h not found" when compiling using scons cache

Before opening an issue
Questions should go to the GEE mailing list (https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!forum/google-earth-enterprise)
or Slack Open GEE channel (http://slack.opengee.org/) GitHub issues are for bug reports and suggestions for new features.
Describe the bug
When building using scons cache a dependency bug is sometimes encountered.  This error does not happen every time as it depends on how fast things are extracted from cache but geautoingest library depends on generated header files but does not declare an explicit dependency to these files.  Implicit Dependencies 'should' catch this but there is a known issue in scons that prevents Implicit Dependencies from working well with generated files.  The work around is to use Depends() and explicitly add the generated files as dependencies to geautoingest
To Reproduce
With scons cache enabled build and re-build until this error happens.
Expected behavior
The compiler error should not happen
Screenshots
N/A
Desktop
Build error.
Additional context
Add any other context about the problem here.

This still seems to be happening.

New fix seems to have worked.  Closing issue


Feature/1737 inject expression content for related question

Allows multiple Branch (grey) boxes

Messed up the history so closing this PR to raise another.


Add Hope UI Component library

Hope UI is a "Chakra UI inspired" component library for SolidJS with a style props API, theming, dark mode and follow WAI ARIA 1.2 design patterns.

Thanks @fabien-ml 👍


DataBase Drivers list

How I can get SOCI Database Drivers list at run-time ?

No, you can't do this, because  backends load dynamically, by request.


MOV format not supported

.MOV videos are not supported:

Thanks for reporting this @yassineatik. Did you happen to see any errors show in the console about processing the video?
It could be that the video wasn't processed yet and this was the player falling back to the local source. If you wait for a few minutes before trying to load the page/player (after the video has had time to process) does it work then?

I can confirm other .mov files work, so without more info there's nothing we can do here. We can reopen if you have more info to give. Thanks!


cdnjs: Update index.md

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

As you can see in https://github.com/orgs/cdnjs/people Peter Dave is no longer part of cdnjs, so I am removing him

On the cdnjs.com site, this name is still listed.


Rebuild edges that update their output file on error

https://groups.google.com/forum/#!msg/ninja-build/YQuGNrECI-4/ti-lAs9SPv8J discusses a case where an rule updates its output file and then fails.  The next run of ninja considers the ouptut file clean and doesn't rebuild it.  Always stat output files after they are built, and write the mtime into .ninja_log.  Consider output files dirty if the recorded mtime is older than the most recent input file.

This pull request requires ninja to stat all output files.

Fixes #1135

(This was supposed to be a comment on the first of your 3 reviews.)

I'll just drop that patch from here, it was useful to generate the before and after statistics but it can be its own pull request if you want it.

If the motivation is to fix metrics, I think I'd rather move the macro call around.

Moved the metrics to RealDiskInterface

Thanks! let's hope this doesn't break something we didn't think of :-)

This introduced a regression with subninja.  See #1290.


Non interactive commands

Examples:
# Toggle pause/play.
echo "space" | castnow --quiet

# Toggle mute.
echo "m" | castnow --quiet

This allows castnow to be used from cron jobs or via window-manager bindings.
Constraint... commands are read from standard input if:

standard input is not a TTY, and
no playlist arguments are provided.

The latter avoids problems when the media itself is read from standard input.
Issues... Here, we just use the command names as they are for keypress.  This avoids having to introduce new names, but it does lead to some non-descriptive names (e.g., space means toggle pause/play).  It's not clear what the right thing to do about this is.

It's not clear what the right thing to do about this is.

Hmm, there is no right or wrong way here.
I would vote for something like a heredoc or more --flags.

Closing in favour of #191.


V1.2.0

Purpose
This PR does not intend to be merged in master. This branch has been created from v1.1.0 tag. All commits will be cherry pick later to put in the master commit history properly.
Changed

Add languages to the CourseRun serializer
Rename certificate field to certification_definition into the ProductSerializer

Proposal

[x] Bind languages field to the CourseRunSerializer
[x] Rename certificate field to certification_definition into the ProductSerializer
[x] Update tests
[x] Prepare release 1.2.0

Version 1.2.0 has been released. We can close this PR.


Enable logging for WCs

Ingestion of logs from workload cluster should be the default when a cluster is created.
Currently we have the opposite logic where logging is disabled by default and can be enabled via giantswarm.io/logging=true label on Cluster CR.
Here we should reverse this logic to have logging enabled by default, and if needed user can disable logging by applying giantswarm.io/logging=false label on Cluster CR.

This was actually merged here https://github.com/giantswarm/logging-operator/pull/79/files

This was reverted today with https://github.com/giantswarm/logging-operator/pull/84, as we observed performance issue. For details see https://gigantic.slack.com/archives/C064ZHJ25BQ

Blocked by https://github.com/giantswarm/giantswarm/issues/28842

We moved forward on tuning Loki write path and improve performances. We can soon proceed with enabling logging for WCs.

It's been enabled on Monday.
Loki crashed out of disk space on 3 installations (alpaca, argali, antelope) when it had to absorb the logs backlog and scale up quickly. But after some disks cleanup all seems stable now.


support Oracle object storage

--bucket format https://${bucketName}.${namespace}.compat.objectstorage.${region}.oraclecloud.com
eg: https://zhijian-test.axntujn0ebjj.compat.objectstorage.ap-singapore-1.oraclecloud.com

#1083

Codecov Report

Merging #1516 (9e322e7) into main (d8063a0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

:exclamation: Current head 9e322e7 differs from pull request most recent head d4b4aaf. Consider uploading reports for the commit d4b4aaf to get more accurate results

@@            Coverage Diff             @@
##             main    #1516      +/-   ##
==========================================
- Coverage   60.13%   60.12%   -0.02%
==========================================
  Files         132      132
  Lines       22189    22195       +6
==========================================
+ Hits        13344    13345       +1
- Misses       7283     7293      +10
+ Partials     1562     1557       -5

Impacted Files
Coverage Δ

pkg/object/s3.go
42.23% <0.00%> (-0.94%)
:arrow_down:

pkg/chunk/cached_store.go
67.35% <0.00%> (-2.07%)
:arrow_down:

pkg/meta/redis.go
71.14% <0.00%> (-0.14%)
:arrow_down:

pkg/meta/sql.go
68.94% <0.00%> (+0.15%)
:arrow_up:

pkg/meta/tkv.go
76.20% <0.00%> (+0.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8063a0...d4b4aaf. Read the comment docs.


refs

PR-Codex overview
Detailed summary
This PR focuses on updating the references to the "messages-api" section in the README.md file to "messages". It also clarifies the need to close fake producers and consumers after use.
Notable changes:

Updated the reference to "messages-api" to "messages"
Clarified the need to close fake producers and consumers after use

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.
If this PR solves a todo from the code, please don't forget to remove it.

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-07-04T07:49:03.315486.
You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.
Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


[WIP] update version to 2.7.6

[ ] update dubbo version to 2.7.6
[ ] add some simple dubbo provider and dubbo consumer for integration test
[ ] add dockerfile build for latest version code and include in CI
[ ] other dependencies update (include necessary npm module)

issue 1: upgrade to 2.7.6 will fail some unit tests, it may cause by https://github.com/apache/dubbo/pull/4880/files


[Bug]: Home Page code editor Section is not responsive

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
for all screen sizes the text size is same..it is looking ugly
Expected behavior
it must me responsive for all screen sizes
Add ScreenShots

On which device are you experiencing this bug?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

/assign

it looks responsive to me. can you please explain in more detail?


Fixing the rake task that updates the sizes from Merritt

This is a task that triggers size updates based on the Merritt reported sizes for an object (which are compressed and include all versions).
They had a config problem on their end where they were not returning the manifests where we got the size.
The only change is to skip updating size on any datasets that aren't successfully submitted to Merritt or that don't have URLs as supplied by Merritt-Sword.
The lack of these URLs means we cannot query Merrritt for size because we need to use their internal identifier (supplied in their URLs) in order to construct a correct URL.

Looks good


Currency weight is not taken into account. Item weight do not take quantity into account. Adjust UI/UX of currency section.

Ok, firstly, love the fact you implemented adding currency to the containers. And I have one suggestion, to unclutter the UI.
maybe just have a single button at the top to open a second popup which has the currency tab listed with all its currencies. That why it would be easier to see the correct amounts and make it easier to add and subtract stuff.
And now to the man problem.
The weight doesn't seem to calculate correctly for some cases.
Currency weight doesn't seem to display in the container tab, and the weight of stacked items only calculates the weight of the item as a single item.
To clarify, I have pictures. Tested with adding 1000 Electrum (cause that's all electrum is good for ^^) and for items one with animal feed. Base weight of 10 pounds per sack. Currently, there are 8 sacks (80 pounds) in the carriage (container) and it doesn't matter if I increase the amount or decrease it, it only calculates the base 10 pound of the item weight. Left sheet is the character, right sheet is the container. (also note, the on sheet weight callculates correctly)

For the moment, I'll fix those issues and adjust the look of the currency section. Replacing it with a single prompt could be a future addition. Please make a separate issue if so.

Works nicely now great quick fixing work I salute.


Projectile animation swap doesn't work

I'm trying to change the bolt projectile animation to a javelin animation and it doesn't work, nor does any spell animation swap work. I have had no success with any projectile. Just wondering if this is a known issue and whether or not there's a fix.
Thanks.

which weapon and which bolt type is this, and is it in pvp or pvm?

which weapon and which bolt type is this, and is it in pvp or pvm? zcb in pvp is a known issue.

The weapon is the dragon crossbow, and the bolt types were ruby dragon bolts (e) and diamond dragon bolts (e). This would be PvM, i haven't tried it in PvP yet. I actually did a little bit of troubleshooting and I discovered that the animation swap does not work for the dragon bolts, but works for every other bolt type I've tried thus far.

can you click on custom projectile, open the projectile ids window, shoot some bolts, and post the results here?

I haven't changed any of the projectile values. The projectile ID changed from 1301 to 1468 once I hit "use".

This is probably due to dragon bolts having a different projectile. I submitted a fix (3.6.1). Let me know if it works.

I think I added this.


Create /V1.1/company/summary/string:query endpoint

Create a simpler summary endpoint that enables users to more quickly get data back.

[x] Created the summary logic to enable this capability
[x] Mounted in the endpoint at /V1.1/edgar/companies/summary
[x] Reformatted the previous endpoint to /V1.1/Edgar/companies/detail
[x] Updated /V1.1/help accordingly.

The API has been updated readying it for inclusion into the mediumroast.io project.


Fix connection leak if WebSocketListener.onOpen() throws

If WebSocketListener.onOpen() throws, failWebSocket() is responsible for releasing the allocated streams. Specifically it releases this.streams. Previously WebSocketListener.onOpen() was called after the streams were allocated but before they were assigned to this.streams. As a result the streams were not allocated if WebSocketListener.onOpen() threw.
Fixes part of https://github.com/square/okhttp/issues/4515.

Nice find.


Check notification type in custom template

Just wanted to know if there is a way to do this.
I would like the icons within my custom notifications to be different for error, warning and success types however I see no way of doing that other that passing in the icon html with the message or creating a new scope to pass in.
Is there a way to check the notification "type" inside a custom template?

Try to use scoped variable 't'
This variable set to the first letter of the message class name
For example "error" -> t = "e"

That's perfect! Below is a sample of what I was wanting to do:

		{{title}}

Or use it with ngClass as needed!


No C++/WinRT example

When this page is in C++/WinRT mode, a C# and C++/CX example is shown, but not a C++/WinRT one. This is against recommendations, which prefer using C++/WinRT for new code.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae1e0293-4dd3-9057-4e47-da7861c86151
Version Independent ID: 4b19dea0-4b17-614b-d13d-d7b5556d5012
Content: IValueConverter Interface (Windows.UI.Xaml.Data) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.UI.Xaml.Data/IValueConverter.xml
Product: uwp
Technology: winui
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Thanks, @sylveon, I've published a C++/WinRT snippet in the topic.
-Steve


Example code does not add worker nodes to cluster. kubectl get nodes shows no resources.

I have issues
After running the example code. kubectl get nodes shows no nodes added to the cluster. The configmap aws-auth is added with no problems. I deleted it and re-added it still no nodes.
NAMESPACE     NAME                                 DATA   AGE
kube-system   aws-auth                             3      8m21s
kube-system   coredns                              1      23m
kube-system   eks-certificates-controller          0      22m
kube-system   extension-apiserver-authentication   6      23m
kube-system   kube-proxy                           1      23m
kube-system   kube-proxy-config                    1      23m
I'm submitting a...

[X ] bug report
[ ] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
If this is a bug, how to reproduce? Please include a code sample if relevant.
Run current example code with your own subnets and vpc id.
data "aws_eks_cluster" "cluster" {
name = module.my-cluster.cluster_id
}
data "aws_eks_cluster_auth" "cluster" {
name = module.my-cluster.cluster_id
}
provider "kubernetes" {
host                   = data.aws_eks_cluster.cluster.endpoint
cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data)
token                  = data.aws_eks_cluster_auth.cluster.token
load_config_file       = false
version                = "~> 1.9"
}
module "my-cluster" {
source          = "terraform-aws-modules/eks/aws"
cluster_name    = "my-cluster"
cluster_version = "1.17"
subnets         = ["subnet-0439457bd188a340f","subnet-08c03322bc056f489","subnet-06a93826b8f22c0d0"]
vpc_id          = "vpc-03ed0604d97169a60"
worker_groups = [
{
instance_type = "m4.large"
key_name = "devopsclass"
asg_min_size  = 3
asg_desired_capacity = 3
asg_max_size  = 5
}
]
}
What's the expected behavior?
The nodes to be added to the cluster automatically.
Are you able to fix this problem and submit a PR? Link here if you have already.
Environment details
The instances are tagged with the default tags from community module

Affected module version:
OS: Fedora
Terraform version: 13.0

Any other relevant info
Here are the logs from the nodes
Sep 03 18:05:36 ip-20-10-2-241.ec2.internal systemd[1]: Starting Kubernetes Kubelet...
Sep 03 18:05:36 ip-20-10-2-241.ec2.internal systemd[1]: Started Kubernetes Kubelet.
Sep 03 18:05:36 ip-20-10-2-241.ec2.internal kubelet[5189]: I0903 18:05:36.795873    5189 server.go:416] Version: v1.17.9-eks-4c6976
Sep 03 18:05:36 ip-20-10-2-241.ec2.internal kubelet[5189]: W0903 18:05:36.796192    5189 plugins.go:115] WARNING: aws built-in cloud provider is now deprecated. The AWS provider is deprecated and will be removed in a future release
Sep 03 18:05:36 ip-20-10-2-241.ec2.internal kubelet[5189]: I0903 18:05:36.796323    5189 aws.go:1241] Zone not specified in configuration file; querying AWS metadata service
Sep 03 18:05:36 ip-20-10-2-241.ec2.internal kubelet[5189]: I0903 18:05:36.798806    5189 aws.go:1281] Building AWS cloudprovider
Sep 03 18:07:37 ip-20-10-2-241.ec2.internal kubelet[5189]: F0903 18:07:37.093007    5189 server.go:273] failed to run Kubelet: could not init cloud provider "aws": error finding instance i-0f5ec363015f3e214: "error listing AWS instances: "RequestError: send request failed\ncaused by: Post https://ec2.us-east-1.amazonaws.com/: dial tcp <IP_ADDRESS>:443: i/o timeout""
Sep 03 18:07:37 ip-20-10-2-241.ec2.internal systemd[1]: kubelet.service: main process exited, code=exited, status=255/n/a
Sep 03 18:07:37 ip-20-10-2-241.ec2.internal systemd[1]: Unit kubelet.service entered failed state.
Sep 03 18:07:37 ip-20-10-2-241.ec2.internal systemd[1]: kubelet.service failed.
Sep 03 18:07:42 ip-20-10-2-241.ec2.internal systemd[1]: kubelet.service holdoff time over, scheduling restart.

Looking at that log snippet the kubelet process is failing to reach the EC2 API service. This looks like a network level problem. Do the subnets you are using have internet access?

Thank you for your comment. I was using the community module and it locks down internet access by default. Thank you


Add expression links as requested from GitHub issue

Link to GitHub issue: https://github.com/mendix/docs/issues/6644


[core] Add pr-html-generator

Greetings,
this is a new quality checking workflow.
This will automatically generate the html output of any changed bridges of a PR, for any context of the bridge.
You can see it in action here (its a dummy repo of mine, hardwired to a specific PR. the code in this PR uses the actual PR number that it's running for).
@em92 this would replace the manual process/script for testing. This will also check/indicate if all example/default values are correctly defined. It tests all contexts so it's basically an automatic full-test of this specific bridge. Thoughts?
Additionally: I wrote this in python but it's probably just as doable in php. If you want to keep even the helper/quality scripts php only, I would still advocate for merging and then someone else can do the php version :)

The check fails for this bridge since I didn't change any bridges btw. That doesnt happen that often on normal PRs and even if, it would be hard to tell which bridge to test if someone changes something in a core file :)

What do you think of putting the link through https://github.com/htmlpreview/htmlpreview.github.com so that the html is rendered?
Ex: https://htmlpreview.github.io/?https://github.com/Bockiii/dmxprbldr/blob/artifacts/pr3-Phoronix-current-context1.html

@yamanq  ouuuuuh, thats exactly what I was looking for for 20 minutes :D Thanks, I'll see what I can do since its a github action thats doing it.

Here is the issue and possible workarounds.

Looking at the existing workflow, it already uses pull_request_target, so ignore my previous comment. This article might be more helpful.

Is it possible that the action must exist in the target branch first?

I dont think so. The same action (just with on: pull_request) works fine. You can see the runs and failed runs of it in the repo actions history. It's running... just not with pull_request_target... and I have no idea why...

Okay.... that was actually it. And in my shame, it actually makes sense. You can add a workflow.yml in a PR and it will run it no problem (if you use on: pull_request). It will NOT do it if you use pull_request_target because you could just go "echo secrets.*" or something like that in a new PR on any repo
So.. the solution is: accept that the workflow works in my repo and then just merge ^^

Okay, I will merge this commit then. Worst thing that can happen is that a few tests fail for new PRs. Changes can be done in further PRs.
Thanks a whole lot @yamanq !


Allow disabling support for unneeded serialization formats.

nanoserde supports several formats: RON, JSON, TOML, and a bincode-like binary format. For some cases I could imagine using more than one of these, but many programs may just need one or two. Including all of them seems to slows down the build a bit.
I think they should be behind e.g. feature = "json", feature = "ron", feature = "bin" and feature = "toml" (which would extend to the proc macro crate of course). I don't have strong feelings about which are on or off by default. (I don't think I'm the best person to argue either way there. Leaving them all on by default avoids breaking changes, though...).

actually it looks like TOML is partial or just planned. Still, this applies to the rest of them anyway.

#70 is up to potentially implement this, wanted to get feedback on whether it is worth a breaking change with a version bump.


Allow restore network to have network connectivity

Reuse the endpoint of the checkpointed container when restore.
Pass veth pair name to ciur when restore a checkpointed container.
Signed-off-by: Hui Kang<EMAIL_ADDRESS>

@boucher  @SaiedKazemi The solution is not perfect, but the restored network can ping "<IP_ADDRESS>".

Awesome, I'll try it out in a couple of hours and report back.
On Wednesday, August 19, 2015, huikang<EMAIL_ADDRESS>wrote:

@boucher https://github.com/boucher @SaiedKazemi
https://github.com/SaiedKazemi The solution is not perfect, but the
restored network can ping "<IP_ADDRESS>".
—
Reply to this email directly or view it on GitHub
https://github.com/boucher/docker/pull/15#issuecomment-132760278.

--
Sent from Gmail Mobile

The good news is that I'm able to use the network after checkpointing and restoring with this patch! The bad news is that we're going to need to split it into 3 separate patches: one for runc, one for libnetwork, and one for docker (plus, we need to wait for the first two patches to be merged, and then upstreamed in docker, in order to use the third).

@boucher Good to know it works for you. I will split the patch and try pushing them to runc and libnetwork.

Excellent. Let me know if I can help.
On Wednesday, August 19, 2015, huikang<EMAIL_ADDRESS>wrote:

@boucher https://github.com/boucher Good to know it works for you. I
will split the patch and try pushing them to runc and libnetwork.
—
Reply to this email directly or view it on GitHub
https://github.com/boucher/docker/pull/15#issuecomment-132801990.

--
Sent from Gmail Mobile

Hi guys! I also tested @huikang's version on some of my containers.. I was able to C/R successfully a tomcat container on the same host and then I was able to connect to it. I also noticed two problems...

Trying to C/R a mysql container, after restore I get

ERROR 2003 (HY000): Can't connect to MySQL server on '<IP_ADDRESS>' (111)

Trying to Checkpoint tomcat and then restore it to a new container. The restore had no errors, but I couldn't connect to tomcat.

As I noticed, when you are restoring the same container, the container keeps its old IP and you can restore successfully, but when  you 're restoring to a "fresh" one you 've got a new IP. Maybe, this is the problem??..
Thanks

@huikang did you forget to include your patch for writing state to disk from https://github.com/boucher/docker/pull/14
?

@fl0yd I think @boucher merged #14. So I did not duplicate it in this patch.

What's interesting is that this has a ReleaseNetwork(true).  If you do that, the tcp connection restore on your fixed 1.9 for libnetwork, tcp connectivity is lost.  However if you leave it as () then you get a compilation error.
Mark

On Aug 20, 2015, at 11:00 AM, huikang<EMAIL_ADDRESS>wrote:
@fl0yd https://github.com/fl0yd I think @boucher https://github.com/boucher merged #14 https://github.com/boucher/docker/pull/14. So I did not duplicate it in this patch.
—
Reply to this email directly or view it on GitHub https://github.com/boucher/docker/pull/15#issuecomment-133060378.

@fl0yd
I added a parameter to the function, which I think causes the compilation error.

Understood.  I'm pointing out that I think the 2 patches are going to need to be modified slightly to not be in conflict due to req'd parameters.
Mark

On Aug 20, 2015, at 11:08 AM, huikang<EMAIL_ADDRESS>wrote:
@fl0yd https://github.com/fl0yd
I added a parameter to the function, which I think causes the compilation error.
—
Reply to this email directly or view it on GitHub https://github.com/boucher/docker/pull/15#issuecomment-133062293.

@fl0yd Do you think if I rebase this patch on #14 will kind of resolve the conflict as #14 is already merged? Thanks.

@klesgidis
I was able to checkpoint a container running sshd with FileLocks and TCPConnections set to true and restore it into a surrogate container on the same while keeping TCP connectivity in place.  Maybe you should retry?

No, I don't think it will.  You modified daemon/container_unix.go
to add the "is_checkpoint bool" to the func (container *Container) ReleaseNetwork(is_checkpoint bool) parameters and an if inside the function to return if the value is true.
presumably you did that for a reason and want to keep that inclusion.

@boucher Not at all. Please go ahead and submit them. Thanks.

@fl0yd After I put --allow-tcp flag, mysql container C/R successfully, but still I've got problem restoring to a surrogate container. The command  s I use are
$ docker run -d --name tomcat1 tomcat:8.0
$ docker checkpoint --allow-tcp --image-dir ~/Desktop/cr_migrations/tomcat/memory --work-dir ~/Desktop/logs/tomcat tomcat1
$ docker export tomcat1 > ~/Desktop/cr_migrations/tomcat/fs.tar

$ docker import --change "ENV PATH /usr/local/tomcat/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" --change "ENV LANG C.UTF-8" --change "ENV JAVA_VERSION 7u79" --change "ENV JAVA_DEBIAN_VERSION 7u79-2.5.5-1~deb8u1" --change "ENV CATALINA_HOME /usr/local/tomcat" --change "ENV TOMCAT_MAJOR 8" --change "ENV TOMCAT_VERSION 8.0.24" --change "ENV TOMCAT_TGZ_URL https://www.apache.org/dist/tomcat/tomcat-8/v8.0.24/bin/apache-tomcat-8.0.24.tar.gz" --change "CMD [\"catalina.sh\", \"run\"]" --change "EXPOSE 8080" --change "WORKDIR /usr/local/tomcat" - tomcat:kyriakos < ~/Desktop/cr_migrations/tomcat/fs.tar
$ docker create --name tomcat2 tomcat:kyriakos
$ docker restore --force --allow-tcp --image-dir ~/Desktop/cr_migrations/tomcat/memory --work-dir ~/Desktop/logs/tomcat tomcat2

The  restore completes but I cannot connect from the browser..  :P Thanks..

@klesgidis how are you trying to connect? One (unfortunate) thing to note is that the restore will force the new container's IP address to be the same as the old container. You may need to either go in and change its IP, or do some other magic, to make things actually connectable.

I am trying to connect with mysql -h container_ip -u root -p. The thing is that if I restore to the same container I get the same ip, but if I restore to a surrogate, the restored container has a new IP..

Yes. It's worse though: docker thinks the IP is the new IP, and inside the container it will be set to the old IP. So, what I do is use the new IP and docker exec into the container to set its IP to the new IP.

Yes.. I tried this solution with the previous version of docker (without the network fix), but it didn't work. I 'll give a try in a couple of hours ( i am not home right now :p) with the new one and I 'll inform you. Thanks, I apreciate your help.. :)

@boucher , I was able to Restore and to reconnect to a surrogate tomcat and a mysql container using the old IP. I confirm what you said. Docker thinks that the new container has a new IP, but I was still able to connect to the old one.
e.g.
$ docker run -d --name tomcat1 my-tomcat
$  docker inspect -f {{.NetworkSettings.IPAddress}} tomcat1
<IP_ADDRESS>

Connecting from browser to <IP_ADDRESS>:8080 successfully
 $  docker checkpoint --allow-tcp --image-dir ~/Desktop/cr_migrations/tomcat/memory --work-dir ~/Desktop/logs/tomcat tomcat1
 $  docker export tomcat1 > ~/Desktop/cr_migrations/tomcat/fs.tar
 $  docker import --change "ENV PATH /usr/local/tomcat/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" --change "ENV LANG C.UTF-8" --change "ENV JAVA_VERSION 7u79" --change "ENV JAVA_DEBIAN_VERSION 7u79-2.5.5-1~deb8u1" --change "ENV CATALINA_HOME /usr/local/tomcat" --change "ENV TOMCAT_MAJOR 8" --change "ENV TOMCAT_VERSION 8.0.24" --change "ENV TOMCAT_TGZ_URL https://www.apache.org/dist/tomcat/tomcat-8/v8.0.24/bin/apache-tomcat-8.0.24.tar.gz" --change "CMD [\"catalina.sh\", \"run\"]" --change "EXPOSE 8080" --change "WORKDIR /usr/local/tomcat" - tomcat:kyriakos < ~/Desktop/cr_migrations/tomcat/fs.tar
 $  docker create --name tomcat2 tomcat:kyriakos
 $  docker restore --force --allow-tcp --image-dir ~/Desktop/cr_migrations/tomcat/memory --work-dir ~/Desktop/logs/tomcat tomcat2
$  docker inspect -f {{.NetworkSettings.IPAddress}} tomcat2
<IP_ADDRESS>

Cannot connect from browser to <IP_ADDRESS>:8080, but I can connect to <IP_ADDRESS>:8080 successfully persisting the old session Id!

@klesgidis Semantically checkpoint/restore is different than stop/start. The regular stop/start will change the IP, while checkpoint/restore should not. However, the current C/R implementation has the limitation of adding new NAT for a new IP, which actually should not happen.

Closed this PR because I rebased the changed on the recent cr-combined branch #17


doesn't contains class named 'Exp'

doesn't contains class named 'Exp'

@YaoTaoQiHua Your question is quite unclear. Please provide more detail like the training log, training command, etc.

@YaoTaoQiHua Your question is quite unclear. Please provide more detail like the training log, training command, etc.

I've met the same error.
python tools/demo.py image -n yolox-s -c yolox_s.pth.tar --path assets/dog.jpg --conf 0.25 --nms 0.45 --tsize 640 --save_result
Traceback (most recent call last):
File "/home/zhkan/anaconda3/envs/solo/lib/python3.7/site-packages/yolox/exp/build.py", line 13, in get_exp_by_file
current_exp = importlib.import_module(os.path.basename(exp_file).split(".")[0])
File "/home/zhkan/anaconda3/envs/solo/lib/python3.7/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 965, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'yolox_s'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "tools/demo.py", line 273, in
exp = get_exp(args.exp_file, args.name)
File "/home/zhkan/anaconda3/envs/solo/lib/python3.7/site-packages/yolox/exp/build.py", line 53, in get_exp
return get_exp_by_name(exp_name)
File "/home/zhkan/anaconda3/envs/solo/lib/python3.7/site-packages/yolox/exp/build.py", line 35, in get_exp_by_name
return get_exp_by_file(exp_path)
File "/home/zhkan/anaconda3/envs/solo/lib/python3.7/site-packages/yolox/exp/build.py", line 16, in get_exp_by_file
raise ImportError("{} doesn't contains class named 'Exp'".format(exp_file))
ImportError: /home/zhkan/anaconda3/envs/solo/lib/python3.7/site-packages/exps/default/yolox_s.py doesn't contains class named 'Exp'

How do you install yolox?

How do you install yolox?

I've solved that error, thanks

How do you install yolox?

I've solved that error, thanks

hi, I met the same problem with you. Can you tell me how do you solve your problem? thanks a lot!

don't install yolox by pip. Uninstall and next to import sys in demo.py  , sys.path.append(${yolo path})

doesn't contains class named 'Exp'

Hi, do you solve your problem? really need your help,very thanks!
don't install yolox by pip. Uninstall and next to import sys in demo.py , sys.path.append(${yolo path})

How do you install yolox?

I've solved that error, thanks

Hi, how you are solve it? I got the same error when try to use yolox_nano. Here my command.
python3.7 tools/demo.py video -n yolox-nano -c models/yolox_nano.pth --path test.mp4 --conf 0.25 --nms 0.45 --tsize 640 --save_result

How do you install yolox?

I've solved that error, thanks

So, how did you solve this problem? Can you share it?

yolox_s.py doesn't contains class named 'Exp'

yolox_s.py doesn't contains class named 'Exp'  求解

yolox_s.py doesn't contains class named 'Exp' 求解

Did you modify any code or are you using the lastest branch?

I solved this problem just now.  the reason of this issue  is 'Exp' class in the file of exps/default/yolox_x.py inherited base-class 'BaseExp'  in the file of ...yolox_base.py, if you weren't overwrited some functions (eg: get_model, get_optimizer, eval) in the 'Exp' class in 'yolox_base.py', the problem will be made. So, overwriting it!

I solved this problem just now.  the reason of this issue  is 'Exp' class in the file of exps/default/yolox_x.py inherited base-class 'BaseExp'  in the file of ...yolox_base.py, if you weren't overwrited some functions (eg: get_model, get_optimizer, eval) in the 'Exp' class in 'yolox_base.py', the problem will be made. So, overwriting it!

doesn't contains class named 'Exp'

has you solved this issue? I meet this problem and don't has a clue on how to solve this. Looking forward to your reply.


Made the Getting Started docs more clear

Added some additional guidance to the prerequisites section.
Tidied up the dependencies section
Improved formatting for Step 2 & 3 to be easier to read at a glance
Added some additional context to Step 4

somehow just saw this, slipped through graphite
@AngelOnFira i know you just rewrote this for dev containers, want to take a peek and see if there's anything helpful to grab from this?

Took some of the recommendations from here and incorporated them in #661


Improved Logging

I'm looking at improving the logging be it stdout or to a file. Currently there are random console.log calls spotted all over the place. Hopefully having a specific "Logger" in the Robot can help unify this output. Still work in progress.

:smoking:


Use correct offset for debug and simulate flags.

Fixes #1708
oe_enclave_t offsets here:
https://github.com/Microsoft/openenclave/blob/113a8bf22768b3152d57b31085e1cb981556ed99/host/sgx/enclave.h#L136-L139

bors try

bors try

bors try

bors try

@paulcallen
Formalizing/rewrite of the debugger contract is planned for v0.6 and would take most of the release.
The proposed contract incorporates your suggestions where applicable.
The fix in this PR is more appropriate for keeping the master not broken.
I have added tests to rigorously lock down the contract. This test is not throwaway and will be applicable for v0.6 as well when the contract is rewritten.
Can you take another pass at reviewing this?

bors r+

bors r+


Improve test failure output

This PR improves the way that the RunTests function presents test failures to the developer in three ways:

I added t.Helper() calls to the helper functions so that the file/line number for failures is in calling code instead of the test helpers every time

BEFORE:
--- FAIL: TestGqlInvestigationSuite/TestInvestigationNotFound (0.02s)
testing.go:93: unexpected error: got [...SNIP}

testing.go:93 is the line number where you call t.Fail() in graphql-go, not the location where I called RunTests in my library
AFTER:
--- FAIL: TestGqlInvestigationSuite/TestInvestigationNotFound (0.02s)
investigation_test.go:123: unexpected error: got [...SNIP}

investigation_test.go is the calling code and takes me to which test I wrote that failed.

I added an import of github.com/nsf/jsondiff to print out a diff between the actual and expected responses to a tested query
EXAMPLE:

--- FAIL: TestGqlCasesSuite (0.03s)
    --- FAIL: TestGqlCasesSuite/TestValidCasefileRequest (0.03s)
        /Users/macrae/ccode/saber/saber-api/gql/casefile_test.go:238: Did not get expected result:
             {
                "filed": {
                    "closedAt": null,
                    "id": "a688c5c5-0f8c-4f5a-a179-6d29caef924f",
                    "initiatedAt": "2020-02-19T18:55:36Z",
                    "number": "510322",
                    ---"status": "INVESTIGATION"---
                }
            }
        /Users/macrae/ccode/saber/saber-api/gql/casefile_test.go:238: Got: {"casefile":{"id":"a688c5c5-0f8c-4f5a-a179-6d29caef924f","number":"510322","flagCount":10,"initiatedAt":"2020-02-19T18:55:36Z","closedAt":null}}

the --- indicates that the status field was missing.

I added a formatting step to printing out errors when the expected errors are not returned. I'm not entirely sure why Sprintf("+v" was printing out error.Error() instead of the struct and its members but I made a format string that does that explicitly. This caught me because I was being told that two errors were different even though their .Error() appeared the same. They had different paths.
EXAMPLE:

--- FAIL: TestGqlInvestigationSuite/TestInvestigationNotFound (0.02s)
        /Users/macrae/ccode/saber/saber-api/gql/investigation_test.go:123: unexpected error:
        /Users/macrae/ccode/saber/saber-api/gql/investigation_test.go:123:   Got:
            graphql: error [NotFound]: Could not match an investigation with that ID
            Path: [casefile investigation]
            Rule:
            Resolver: error [NotFound]: Could not match an investigation with that ID
            Extensions: map[code:NotFound message:Could not match an investigation with that ID]

        /Users/macrae/ccode/saber/saber-api/gql/investigation_test.go:123:   Want:
            graphql: error [NotFound]: Could not match an investigation with that ID
            Path: [casefile]
            Rule:
            Resolver: error [NotFound]: Could not match an investigation with that ID
            Extensions: map[code:NotFound message:Could not match an investigation with that ID]

Notes for reviewer
I used jsondiff because I'd used it before. It should be pretty easy to get rid of that dependency and use the system diff instead but I wanted to get the ball rolling on this PR.
I didn't make any changes to the streaming tests because I'm not using them. If you'd like me to at least add the .Helper() stuff to this PR I can do that. I also noticed that they are not deep comparing errors so they are potentially missing some things.

This is my first PR here, we've been using your library on a project and I've been very happy with how solid it has been. Please let me know what I can do to help this PR forward.

This PR has been open for a week with zero comments. I'd love to be part of making this project better, is there anything I can do to get some attention? Are you looking for more people to help out tend it? @pavelnikolov @tonyghita

Hi @macrael,
first of all thank you for your contribution.
Ideally, different changes should be in different PRs.
I would really like to avoid adding dependencies unless they bring a significant value. That is why I would consider "2)" an improvement if this was pluggable so that each user can decide for themselves if they want that extra dependency. One of the goals of the library is to be minimalistic instead of offering a huge feature set. For now, I don't want to merge this into the library.
As for 3), I'm not convinced that this is needed.
I'd be happy to merge 1).

I am closing this PR as stale.


requirements.txt

OK, I added a requirements.txt file for binder to pick up. The build of my fork is here - I'll keep committing changes to the requirements file until I can work through the whole thing with no errors. When you merge (not yet, please!), you'll need to rebuild your version of the tutorial by going to its binder status page and clicking "reload".

I didn't want to include healpy in the requirements because it requires to have a C compiler installed. It is optional (the function where I use healpy can be executed as well without having it installed by setting healpy=False)

Ah, OK - I'll remove this then. Thanks!

I think you can merge this now - not sure why it is complaining about conflicts, I don't see any! Should be easy to fix in a command line merge. I issued #16 and #17 separately, because they are (probably) not binder problems. Thanks!


Let's try playwright

Description of changes: playwright basic scaffold. The testids are still using cypress format 'data-cy' for now, may swap swap them later if choose this path.  Video is on for now as a test.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@samIndustrio playwright basic scaffold - give it a go.  This feels nicer to me build off than cypress.  I left the testids it used to still be 'data-cy' for now, can always swap them later.  Video is also on, but just as a test.


Depend on libgdal-core and any needed plugins

Comment:
Presently, this feedstock depends on libgdal (the kitchen sink).  Can it be updated to depend on libgdal-core and any required plugins needed for functionality?

I think this is a good suggestion. I'm on break for a few weeks but would be happy to review a PR. Or maybe @danielnachun might want to look into it.

This should be possible.  How do we determine which plugins are actually needed?

Thanks for the responses.  I am the least sharp tool in the toolbox, but I inspect the build logs and look for the sf.so links
INFO (r-sf,lib/R/library/sf/libs/sf.so): Needed DSO lib/libgdal.so.36 found in conda-forge/linux-64::libgdal-core==3.10.0=hef9eae6_1
So unless r-sf calls command line stuff provided by the plugins, it would seem all it needs is libgdal-core, but I could be horribly wrong, sorry.

I think you're right.  I tried a local build with only libgdal-core and it worked with no issues.  I see no references in the C++ source code to dlopen which as far as I know is the only way you load plugins at run time that were not linked at build time.  I'm also not even sure Rcpp supports dynamic loading of shared libraries in that matter.  I've opened https://github.com/conda-forge/r-sf-feedstock/pull/138 so we'll see how it goes.
If this does work, I'll also do the same r-terra, as that also currently depends on the full libgdal but probably doesn't use plugins.

The PR passed and has been merged!  Thanks @akrherz for noticing this - reducing dependency footprints is always a nice improvement for a package like this.  I will close this as completed now.

Thank you!


Custom InfoWindow

Summary
I'm looking for a way to create custom infowindow. In react-google-maps an infoWindow is only for a marker i guess, I tried to create an infowindow with 'new google.maps.InfoWindow', and failed to open it.
i'm using react-google-maps version "9.4.5".
Snippet
// this is my MarkerClusterer onClick function
_markerClusterClick = async (markerCluster) => {
    const markersData = markerCluster.getMarkers().map(x => this.data.orders[x.title]);
    const iw = new window.google.maps.InfoWindow({
      content: renderToString(<PluralValues values={ markersData }/>)
    });

    const map1 = window.google.maps.Map;
    const map2 = this.data.map;
    iw.setPosition(this.data.currentCenter);
    iw.open(map1);
    iw.open(map2);
  }

// this.data.map (map2) is set here
return (
  <div>
    <GoogleMap
      ref={(map) => this.data.map = map}
      { props... }
...
)

when i tried with map1 or map2,
infowindow.js:11 Uncaught (in promise) TypeError: Cannot read property 'get' of undefined
    at pf.d (infowindow.js:11)
    at _.S.ma (js?v=3.exp&libraries=geometry,drawing,placesmaps&key=AIzaSyBCpFlL1pK26gRZjnG8gVaZhRdUEjh-QCM&language=kr:182)
    at Object.oj (infowindow.js:11)
    at js?v=3.exp&libraries=geometry,drawing,placesmaps&key=AIzaSyBCpFlL1pK26gRZjnG8gVaZhRdUEjh-QCM&language=kr:100

an error occurred.
Is there any way to open custom infowindow, not only for markerclusterers, just at arbitrary LatLng without any markers?
stack overflow
I found the same issue   and no one answer this.
please enlighten me

Hello @whojes
This library is unmaintained almost two years. We have build new npm package @react-google-maps/api.
We have a community, docs and examples

oh, i was happy i'm 1000th issuer.
see you there~


How to add scale line?

I want to use scale line on maps.  thanks

try this https://github.com/kimlet/flutter_map


Add cloudron as a deployment method

Thanks your PR!
But README already mentions the CloudRon and I think that's pretty much enough information for users to know, since install is as far as click a button.
Add additional page to documentation adds more cost to maintain and organize.

@Unknwon fair enough, it's your call :-) I thought it would be nice to have it listed in https://gogs.io/docs since that's the main gogs docs page. I see your concern though, so maybe a line in  https://gogs.io/docs/installation/install_from_packages ? I will close this PR and if you have an alternate suggestion I can provide another PR.


validate_document_with_cert uses local cert when no cert in response

I hit an issue when you have 2 certs signing and encryption and the cert is not included in the response.
After tracing it down, it appears that the validate_document_with_cert behaves differently to the validate_document method in that it won't fall back to the supplied cert when there was no cert included in the response.
I tried to write tests, but wasn't sure how to generate an signing/encryption pair of certs and wasn't sure I was allowed to use what my SP was using.

@Adam21e you can generate self-signed cert for the SP with that tool:
https://www.samltool.com/self_signed_certs.php

Thanks, I had a lot more time today so poked around a bit more and found a similar test already and added a new test based on this.
response_test has a "return true when no X509Certificate and the cert provided at settings matches" which is the situation that I have.
The difference for me is that I am using idp_cert_multi and not idp_cert.
Using idp_cert_multi triggers validate_document_with_cert which is where the issue for me was.


License missing from repo

Hello :)
I noticed there isn't a license listed on the repo. Is that intentional? I'm asking so I understand whether or not I'm able to use it in my projects

Hi, sorry about that. I forgot add the licensing file as I am still reviewing the code. Please feel free to use this repo.


IJ1MacroEngine: type boolean parameters properly

Previously, these was no special case for injecting a boolean parameter into an ImageJ1 macro, so it got converted to a string.
Thanks to Benoit Lombardot for noticing.

Tested with Benoit's macro; now works as expected!
//@boolean bool1

IJ.log("bool1 is "+bool1) // boolean declared in @parameter annotation print as "true"
if (bool1){ IJ.log("in test 1 : bool1 is "+bool1) }                     // does not pass
if (startsWith(bool1,"true")){ IJ.log("in test 2 : bool1 is "+bool1) }  // this test pass

bool2 = true;
IJ.log("bool2 is "+ bool2) // boolean declared in macro display as "1"
if (bool2){ IJ.log("in test 3: bool2 is "+bool2) }                      // this test pass
if (startsWith(bool2,"true")){ IJ.log("in test 4 : bool2 is "+bool2) }  // this test pass


gh-pages: Updating swagger-ui code to the latest version and removing the 'Try it out' buttons

LGTM


Fix for #514

Changes to implement 'isNotEqualToIgnoringWhitespace' assertion.

Thanks, will have a look at it soon.

I'm not very happy about the way that JUnit handles parameterised tests. Would you be OK with adding something like https://github.com/Pragmatists/junitparams or https://github.com/piotrturski/zohhak as a test dependency to the project?

Yes  no problem, I kinda like https://github.com/piotrturski/zohhak better.

https://github.com/TNG/junit-dataprovider is another possibility

Ok, I'll do a separate patch for parameterised tests, as they are used in other places too.

Thanks Dan, integrated.


Add to Package Control

Description of your enhancement/feature request proposal.
Submit a request to the Package Control Channel to add this package so that users can install it via Package Control.
Alternatives.
Continue following the instructions given in the README.

This has now been added to Package Control.


AWSXRayRecorder is full framework only.  Need .NET Core.

I don't know where to go for this but it is full framework only.
I could probably port the usage to .NET Core but I don't know where the source is.

https://www.nuget.org/packages/AWSXRayRecorder/1.0.1-beta
When being installed the target is just net45

At the moment the AWSXRayRecorder is only supported on net45. We are looking to porting this functionality to .NET Core, but cannot give an ETA.
Keeping this issue open and will update it with any progress.

Is the code open source?  Is all that is needed is to hook into Asp.Net Core middleware instead of a http handler of whatever the System.Web version was called?
I'm interested in helping.

The source for AWSXRayRecorder is not open source at this moment, and I cannot provide an ETA of when (if ever) it will be.

That's disappointing.  I was hoping the X-Ray protocol would be open so we could embed the implementation in various applications.

We are definitely interested in making it as easy as possible for members of the AWS community to implement X-Ray integration in whichever language and framework is best suited to your needs. To that end we are working on documenting the protocol, which should be available in the next few weeks, and will eventually publish the source for the current .NET version to GitHub.

Great!  Thank you.

@PavelSafronov I was looking for AWSXRayRecorder github page, but as I read above I will not found it.
But we are starting using at VTEX and one of the problems I found was that library stuck when working in a test environment without XRay service running. I believe in some point the TracingMessageHandler handler it lock waiting for service response (sorry I don't know)
Since there isn't a public project I hope you can pass my message forwarder ..
PS: Sorry use reply as "email"

@Caldas , please post your question to the AWX X-Ray forum and the team should be able to help you out.

@Caldas There is no blocking logic in TracingMessageHandler. It doesn't acquire any locks or waiting for any external components. Actually, there is no direct connection between XRayRecorder and XRay service. The communication is through a daemon on the host using UDP package.
As @PavelSafronov stated, AWS X-Ray Forum is the better place to ask any XRay related questions. Can you post your question there and elaborate more about what you did and what's the problem you see? I would like to help you figure out what went wrong.

Closing this as the discussion seems to be taking place in the forums.  Feel free to reopen if I missed anything.

@sstevenkang: I would suggest that this issue needs to be re-opened. It was originally opened due to lack of .NET Core support which, as far as I can tell, hasn't been implemented.
cc @adamhathcock

I agree this should be reopened as it was high jacked by an irrelevant question then closed.

You are correct, reopening.

The X-Ray Segment documentation provides the documentation around the X-Ray protocol.
We're still working on adding .NET Core support and open-sourcing the AWSXRayRecorder code.

Would it be helpful to attempt to implement this on ASP.NET Core or is the release close-ish?

Sorry, I can't say anything schedule-wise, it's against Amazon policy to provide any estimates on future releases.

Reimplementing the full protocol is not something I'm looking to do.  I will help with porting to .NET Core and ASP.NET Core once the current code is open sourced however.

@PavelSafronov any updates on when the AWSXRayRecorder will be open sourced?

Hello, I am also waiting, to implement it in lambda .net functions through api gateway with core dotnet, thanks.
Another small problem about cloudformation to configure x-ray on a lambda :
TracingConfig : {Mode: "Active"}  # does not exist in your documentation, but it's ok with cloudformation?
`
LAMBDA EXECUTION HANDLER ASP.NET
LambdaApi:
    Type: 'AWS::Lambda::Function'
    Properties:
        FunctionName: TestApiRest-Lambda
        TracingConfig: {Mode: Active } # ACTIVE X-RAY
        Handler: 'TestAWSServerless::TestAWSServerless.LambdaEntryPoint::FunctionHandlerAsync'
        MemorySize: 256
        Role: {'Fn::GetAtt': [LambdaRole, Arn]}
        Runtime: dotnetcore1.0
        Timeout: 30`

AWS Lambda Function TracingConfig
http://docs.aws.amazon.com/fr_fr/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-function-tracingconfig.html
Here, There is no reference at propertie TracingConfig
AWS::Lambda::Function
http://docs.aws.amazon.com/fr_fr/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-function.html
And the template cloudformation : "serverless.template", into visual studio 2017 Reports error for TraceConfig, but publish into AWS works well

bump for xray with .net core

Any progress on this? It is been quiet for a while

bump for xray with .NET Core!!!

Progress is being made to get .NET Core support. Out of curiosity what type of environments are you planning to use X-Ray in? Beanstalk, Lambda, other?

I am planning to use it in an Lambda

I Will be using on ECS/Beanstalk
Em 16 de nov de 2017 5:19 PM, "Norm Johanson"<EMAIL_ADDRESS>escreveu:

Progress is being made to get .NET Core support. Out of curiosity what
type of environments are you planning to use X-Ray in? Beanstalk, Lambda,
other?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-sdk-net/issues/500#issuecomment-345033324,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5QPTHlp-iIENSW5O5NaT5XhcgaiImUks5s3Iq-gaJpZM4LCUpz
.

Lambda

Lambda

Lambda

ec2 docker .net core 2.0

EC2 Docker Beanstalk

EC2 Docker .NET Core 2.0

Doing Lambdas just now, and it an absolute must-have for production debugging.
Any chance we getting it at ReInvent  :)  ?

ECS Docker .NET Core 2

@PavelSafronov @normj I checked the license you use for AWSXRayRecorder it looks like you explicitly allow to make a derivative work based on it.
Let me quite it
"Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form."
So as I understand it nothing is stopping me or anyone else to jus dissamble your dll and just prepare a version for .net core.

Yesterday I did my .NET Core session at our AWS re:Invent conference. In my session, .NET Core 2.0 Lambda support was officially pre announced and it is coming soon. To help prove it was coming soon, we actually demoed running an ASP.NET Core application with Razor pages using our upcoming .NET Core 2.0 runtime from the us-west-2 region.
We also demoed upcoming .NET Core 2.0 X-Ray support as well. That will probably come out around the same time as .NET Core 2.0 Lambda support. .NET Core 1.0 didn't have some of the API we needed to port the existing .NET Framework version to .NET Core. There has also been a lot of work done to make it easier to use X-Ray for .NET in the upcoming version.
The session will be posted online soon and I'll post a link for those that wanted to see that demo.
@tsibelman Yes you could disassemble the assembly and make your own .NET Core but you want have to wait much longer for our official support.

Hey Norm - I was in your session. It was great! Thank you. Really excited about what is coming. I just hope "soon" actually is just that. ;-)

@eric-davis Thanks! Glad you liked it.

Great news @normj let's make .net great again :)

My session is online if anybody wants to see the .NET Core 2.0 Lambda demo with X-Ray support. The Lambda part starts about 13 minutes into the talk. There is also some cool ECS Fargate support we talked about after the Lambda section.
https://www.youtube.com/watch?v=IfF1E2RJ6Do

AWS X-Ray support for .NET Core 2.0 is out today. Checkout the new AWS X-Ray .NET GitHub repository which has a lot of the information on how to use it. There is also a new version of the AWS Toolkit for Visual Studio that allows you to enable X-Ray in Beanstalk and Lambda environments.
Closing this issue as the support has been released. For issues with the new .NET X-Ray SDK open an issue on the new .NET X-Ray GitHub repository.

Woohoo! Thanks for the update!
On Mon, Feb 5, 2018 at 3:13 PM, Norm Johanson<EMAIL_ADDRESS>wrote:

AWS X-Ray support for .NET Core 2.0 is out today. Checkout the new AWS
X-Ray .NET GitHub https://github.com/aws/aws-xray-sdk-dotnet repository
which has a lot of the information on how to use it. There is also a new
version of the AWS Toolkit for Visual Studio that allows you to enable
X-Ray in Beanstalk and Lambda environments.
Closing this issue as the support has been released. For issues with the
new .NET X-Ray SDK open an issue on the new .NET X-Ray GitHub repository.
https://github.com/aws/aws-xray-sdk-dotnet
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-sdk-net/issues/500#issuecomment-363207173,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACT-qMxnxQgjdH4nKuk9T3TwuzdP3Wa8ks5tR2DzgaJpZM4LCUpz
.