Slick w/ vanilla JS

Hi Ken.
Thanks for this awesome slider, I really like it. But this time I would really like to use it w/o jQuery.
Do you think it is possible to port it to vanilla JS?
Cheers.

Closing, as this will be 2.0

@kenwheeler, any ETA of v2.0?

Working on it. The first step to 2.0 is getting CI and tests running. I'm almost there.

+1

+1

+1

+1

+1

Hey Ken, are there any news about the vanilla version?
best regards

+1 Any news of progress :-)

+1 subscribing for news on this subject :D

Is this still planned for v2 @kenwheeler ? Someone said v2 didn't seem to be moving in this direction.

when v2 drops, it will be vanilla js

Awesome @kenwheeler. Any progress?

a little but not a ton. I've been super focused on react and react-native lately, and driving initiatives at scale with both at my full time job. I would love to get v2 out the door, but I just havent had the hours in the day lately.

Ok. I don’t use jQuery as a matter of stubbornness, but if there’s a small
way in which I could help I’d love to.
In the meantime, are there competing libraries without jQuery dependency?
Slick’s feature set is just so awesome…
On Tue, Jul 26, 2016 at 10:06 AM Ken Wheeler<EMAIL_ADDRESS>wrote:

a little but not a ton. I've been super focused on react and react-native
lately, and driving initiatives at scale with both at my full time job. I
would love to get v2 out the door, but I just havent had the hours in the
day lately.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/494#issuecomment-235278040,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ5Yr7nbGsp9uJNnzHIgaF4e7OkdSFXRks5qZhRhgaJpZM4CeF6e
.

Why not use jquery? If I wasn't in react land, I'd still use it. A couple extra kb in exchange for battle tested browser API normalization is well worth it imo.

Yeah, but I’m lucky enough to be 14 and not writing code that needs to be
cross-browser compatible. Thanks, though.
On Tue, Jul 26, 2016 at 10:17 AM Ken Wheeler<EMAIL_ADDRESS>wrote:

Why not use jquery? If I wasn't in react land, I'd still use it. A couple
extra kb in exchange for battle tested browser API normalization is well
worth it imo.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/494#issuecomment-235281321,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ5Yr8i2mf37fCOLdSvJZWHKaiB7EPmbks5qZhbsgaJpZM4CeF6e
.

Microsoft has stopped supporting IE9. So should developers.
+1 for javascript.

Currently going with http://flickity.metafizzy.co, for anyone interested. It has everything I need, and it's vanilla JS. When Slick drops jQuery I'll come back, though 😀

I'm very happy with http://idangero.us/swiper it's flexible with good APIs.

I've had a good experience with Swiper also, though I'll probably be moving back to Slick come v2 with this news. Many of the websites I develop now only support modern browsers so I've no need for jQuery, and it's massive bloat as a dependency.
Echoing someone above, if there's anything that can be done to help progress this cause let me/us know!

Don't get me wrong, I get it, I wish I never had to support any older browsers, but slick is used on big ass websites where supporting older browsers means not losing out on potential revenue for them. If someone wants to, they could really just convert all the jquery to regular js. You would make an IIFE and pass a selector and then use QSA for all the selections and addEventListener for the events. Then use a lightweight animation lib for tweening values. If any of you wanna do that, I'd be happy to provide it as a vanilla version. V2 isn't about that. I mean v2 will be vanilla, but it would be a fundamental rewrite as well. Think free scrolling, dropping clones, physics based animation.

That's awesome @kenwheeler. Not hating on Slick. I'll switch back as soon
as v2 is out (or even in beta). You've done great work here already, as
well.
On Wed, Jul 27, 2016 at 8:09 AM Ken Wheeler<EMAIL_ADDRESS>wrote:

Don't get me wrong, I get it, I wish I never had to support any older
browsers, but slick is used on big ass websites where supporting older
browsers means not losing out on potential revenue for them. If someone
wants to, they could really just convert all the jquery to regular js. You
would make an IIFE and pass a selector and then use QSA for all the
selections and addEventListener for the events. Then use a lightweight
animation lib for tweening values. If any of you wanna do that, I'd be
happy to provide it as a vanilla version. V2 isn't about that. I mean v2
will be vanilla, but it would be a fundamental rewrite as well. Think free
scrolling, dropping clones, physics based animation.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/494#issuecomment-235566320,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ5Yr7jtlin4C-1Oz3yocB1aKlGegfzzks5qZ0p2gaJpZM4CeF6e
.

@kenwheeler Does it work with cash.js?

@SamHH @websirnik had a look at Swiper, but it's double the size of Slick.  So, using jQuery and Slick comes to the same thing?

Any updates on v2 @kenwheeler ?

This is a good slick substitute until Slick drops jQuery: http://meandmax.github.io/lory/. Written in ES6 and looks/acts very similar to slick too.

We found this alternative, it's vanilla JS and has so much of Slicks
functionality, it's brilliant.
http://idangero.us/swiper/#.WG5cEraLSWY
On 5 January 2017 at 11:57, alittlebirdo<EMAIL_ADDRESS>wrote:

This is a good slick substitute until Slick drops jQuery:
http://meandmax.github.io/lory/. Written in ES6 and looks/acts very
similar to slick too.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/494#issuecomment-270628300,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtC8NUKMi2AfSu6dNNTjnaenUXLiYFAks5rPNqYgaJpZM4CeF6e
.

Thanks @alittlebirdo will have a look.  @Quirksmode I've had a look at Swiper, but it's larger than Slick and jQuery combined.

@alittlebirdo @Quirksmode @darrenjacoby a friend recommended this. Decided to go for it with the current project I'm working and. Really liking it so far.
http://flickity.metafizzy.co/

@splurtcake Looks good, but it has got a comm license, whereas Lory is MIT.

I have worked with Flickity quite a bit and can say it's a really solid library.. Lory just seems to be quite a bit smaller than the other libraries.

@kenwheeler Its nice to have an approx time for v2 release. I really want to use it with React and no jquery.
Thanks 😊

@TheAsia there's actually a react port
https://github.com/akiran/react-slick

@mike3run That appears to include jQuery under the hood based upon a cursory look, so it doesn't really solve the issue of needless dependency bloat.

@mike3run Ah I think you're right. Strange that jQuery is listed under Bower deps though.

i mean bower got deprecated a while ago so most likely not all packages are updated in that department :(

@kenwheeler We're awaiting the v2 release ! Please let us shower in the holy rains of Vanilla JS Slick! :)

@kalpeshmange give tiny-slider a try, its vanilla, works really well and the developer is actively adding new stuff and ironing bugs

3 years since this issue was opened. :(
+1 for vanilla

@rudza you know @kenwheeler doesn't owe us anything right?
if you want the vanilla so badly make a PR, or give tiny-slider a try, but don't just straight up demand features like you're paying for them 😛

+1

I will be honest, it is a bit of a dick move to constantly add references to these other competing projects in these tickets.  It is insulting to the developers that have worked so hard to build this great tool that a ton of websites use.
Yeah the jQuery limitation is a blocker for some people. But I am sure these guys have other things to do then just code to everyone's requests. If you want that took then fork it and PR back to this project with your VanillaJS version of this tool. If you build it and do so very well then I am sure they will strongly consider your changes.
  Give back to the community and do this refactor.

Yeah, I understand your point but look on the other side of the issue:

slick is the best
jquery is great
slick is the best but jquery gets crappy
you have tested algoryrthms & you're pretty experienced
you are very popular at this point, decide do move towards faster vanilla
js
you have better product, you're populating the market gap
slick is still the best
profit.

jQuery will die eventually. Many people are moving towards pure js / es6
transpiled. People are creating similar sliders becouse there's a need for
such. (I would test them but, you know, slick for the win) MaterializeCss
has done that as well, they moved all theirs library to vanilla js.
I know they have better things to do, I understand it's annoying, but
there's a need, simple.
https://mailtrack.io/ Sent with Mailtrack
https://chrome.google.com/webstore/detail/mailtrack-for-gmail-inbox/ndnaehgpjlnokgebbaldlmgkapkpjkkb?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality
2018-02-13 19:55 GMT+01:00 Patrick Thurmond<EMAIL_ADDRESS>
I will be honest, it is a bit of a dick move to constantly add references
to these other competing projects in these tickets.  It is insulting to the developers that have worked so hard to
build this great tool that a ton of websites use.
Yeah the jQuery limitation is a blocker for some people. But I am sure
these guys have other things to do then just code to everyone's requests.
If you want that took then fork it and PR back to this project with your
VanillaJS version of this tool. If you build it and do so very well then I
am sure they will strongly consider your changes.
  Give back
to the community and do this refactor.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/494#issuecomment-365367218,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIdodqv-OMK_J_s_9QqvHQo4_zhxLcECks5tUdq5gaJpZM4CeF6e
.

just checking up on this, still a thing asked most for at my studio :)

I like slick slider a lot, but we have to ask ourselves: what we gain from a vanilla rewrite? Performance? Less filesize? More stability (or the opposite)? We are in 2018 and we live in the age of client side frameworks. Just take a look what is possible with vue.js:
https://vuejsexamples.com/tag/slider/
Of course, there are a lot of plugins in here as well, like the slick slider addon for vue:
https://vuejsexamples.com/vue-component-for-slick-carousel/
Lot of these projects are just pure vue components making your life easier that you don't have to write them yourself:
https://github.com/SSENSE/vue-carousel
Lot of people complaining about ditching Jquery, because we don't use it anymore. Not realizing that they asking something for a bigger final project size, if they use a client side framework anyway.

4 years have passed, I think we should forget this issue

+1

Well i'm gonna try to learn enough and someday make the refactor :)

+1
On most projects I work on, I prefer to use JQuery so all is good, but on a current project, they want to dump JQuery to save in total JS file size so I'm forced to find another slider that doesn't require it. Shame, as I love this one, it's perfect.

tinyslider is pretty good.

4 years...I think we should forget this issue

Never quit!

I ended up making my own one, but this one is still better.

Has anyone tried using cash.js and this? Could be a good alternative to pulling in jQuery and still using this.

Has anyone tried using cash.js and Slick? Could be a good alternative to pulling in jQuery and still using this.

Would be very cool to see imo. I personally avoid using JQuery on all of my websites period.

Man .... i thought this would be the the last carousel I willl ever need :P
Slick Slider is an awesome slider, hope you still working on this :)

If you're looking for something simple and no-modules-vanilla, this is the best I've found: https://nickpiscitelli.github.io/Glider.js/
It's missing a lot of the features, but it's should cover at least ~75% of use cases.

tinyslider is pretty good.

Very buggy. A lot of issues on Github.

Has anyone tried using cash.js and Slick? Could be a good alternative to pulling in jQuery and still using this.

Yes, I actually did today and got it running with a few minor additions to cash and some smallish tweaks to Slick 1.8.1.
I did not test in IE11, but everything Edge 18 and up seems to be running generally pretty smoothly.
I will test this further, because this is actually for a real project, but the results seem promising so far. I'm quite positive that this will hold up with different configs, since I chose a rather complex one from the get go. Still have to verify if instance handling with multiple sliders on one page holds up and if destroying and reinitialization works properly.
Just give me a mention or PM if you are interested in the changes.

Has anyone tried using cash.js and Slick? Could be a good alternative to pulling in jQuery and still using this.

Yes, I actually did today and got it running with a few minor additions to cash and some smallish tweaks to Slick 1.8.1.
I did not test in IE11, but everything Edge 18 and up seems to be running generally pretty smoothly.
I will test this further, because this is actually for a real project, but the results seem promising so far. I'm quite positive that this will hold up with different configs, since I chose a rather complex one from the get go. Still have to verify if instance handling with multiple sliders on one page holds up and if destroying and reinitialization works properly.
Just give me a mention or PM if you are interested in the changes.

I was just about to try the same thing. Keep us posted if it's easy to use cash.js in place of jquery.

@CorySchulz
I created a gist for you, outlining our current solution.
https://gist.github.com/OktarinTentakel/6480bdd1b0277b2d75afab8bb2b8d603
We had to fill some gaps in cash to work with slick (first file "cash-shim.js ", methods starting with underscore are from lodash, mainly for type checks).
Then we took version 1.8.1 of slick slider and mainly reworked some details of event handling (second file "slick.mod.js "). All changed lines should be marked with "// MOD". Additionally we removed the boilerplate module stuff and just encapsulated into a factory method that we can import more easily in ES6 (you can see the call in the first file).
Have fun!

Any update Slick slider vanila Js version? @kenwheeler

@OktarinTentakel
I was able to get this to work! I actually spent the day modding the cash and slick js files and essentially recoded the same things you did, but I'm going to use your shim file because I think that's a cleaner implementation and modifies the original Slick file the least. You should package this and post it online and call it "Slick Cash". I'm sure a ton of people would use this.
Thanks again!

@OktarinTentakel

please do, i dont have much stake in this as ive moved to other solutions, but for me slick is dear to my heart

Current I'm using swiperjs for vanilla js project. It is used in conjunction with Flebox. That's good.
But slick slider went with me through a long time from I became a coder.
So I'm expecting slick slider vanilla version :)

I honestly tried most go-to sliders for a new project and was quite disappointed with the offerings. Slick still offers some layout options no other slider is able to pull off, which out creative guys really seem to like.
I tried all three current big vanilla solutions and none was satisfactory. That's when I tried the port.
I'll see if I can find the time to put the changes into a neater package somehow.

Busy working on a vanilla port...
Got quite far (still some work to do) - could use some help - if anyone is willing to contribute:
https://github.com/ubergeoff/flingo/blob/master/apps/flingo/src/vendor/slick/slick.js

@ubergeoff I just found your vanillajs version of slick and I'm curious what's the state of affairs? Were you able to make a fully independent jquery version?

HI there @sheriffmarley
Sorry - got a little off track for a while - but I am back on it now.
However: I have made good progress since Aug 26.
As for a status update:

I have remove Jquery animations - as CSS transitions options are just fine.
I am still trying to cover all the events - it's been a little challenging (converting these away from JQuery) - but I feel I have made good progress.
After 2) is completed - I believe I will have a final script that is good to go.

DEMO's can be seen here: https://www.flingo.co.za/slick/slick1
A few more days are going to be required for me to finish off a add some polish. (Please hold thumbs)
As always: any code contributions are welcome...

Ok job 99% done. But mostly useable.
Still outstanding (WIP)

Accessibility features
Infinite scrolling

Full source: https://github.com/ubergeoff/flingo
And if I made your day: https://www.flingo.co.za/donate

Hi @ubergeoff ,
Could you please share the url of slick slider in vanilla JS files?

Hi there @chinhphan099
Not 100% sure what you are requesting..?
Are you asking slick script (using vanilla js)? If yes - then here it is: https://github.com/ubergeoff/flingo/blob/master/apps/flingo/src/vendor/slick/slick.js
Or are you asking for something else..?

Thanks @ubergeoff .
Much appreciate. I'm going to apply this file https://github.com/ubergeoff/flingo/blob/master/apps/flingo/src/vendor/slick/slick.js into my project.

Hi @ubergeoff ,
Could you please share the url of slick slider in vanilla JS files?

Thanks @ubergeoff .
Much appreciate. I'm going to apply this file https://github.com/ubergeoff/flingo/blob/master/apps/flingo/src/vendor/slick/slick.js into my project.

OK @chinhphan099 - please let me know how it goes...

I tried and face a issue: https://i.gyazo.com/6559ab687bc8011f91ff15743b968360.mp4
Current I stopped debug that issue.
So I'm using the slick with jquery to push live my project.
I am expecting your final vanilla js version to use, @ubergeoff.
It would be great if you make a web page to explain the difference between your version with Kenwheeler (if have)

So I'm using the slick with jquery to push live my project.
I am expecting your final vanilla js version to use, @ubergeoff.
It would be great if you make a web page to explain the difference between your version with Kenwheeler (if have)

I think, lets take this over to another thread...
PLease can we try resolve this issue here: https://github.com/ubergeoff/flingo/issues/1

https://flickity.metafizzy.co/

the issue is still not resolved 😨

HI there @varave
What is not resolve for you..?
Are you not 100% happy with: https://github.com/kenwheeler/slick/issues/494#issuecomment-704821512
?

Hi @ubergeof!
Now i use vue-agile in my vue.js project

@kenwheeler this is the best slider in the world I know, its a shame that still use JQuery, Why don't just use patreon to buy you a coffie?

Hi @ubergeoff
I'm trying to progressively remove jQuery from a web app, so using your version of the library seems like a good start, bu I'm having some issues, as it looks like jQuery is not completely removed.
For example I had to change this line
_.$slideTrack
  .find('.slick-cloned')
  .find('[id]')
  .each(function () {
    $(this).attr('id', '');
  });

to this
$(_.$slideTrack)
  .find('.slick-cloned')
  .find('[id]')
  .each(function () {
    $(this).attr('id', '');
});

in order to prevent an error.
Now I'm trying to destroy and create the slideshow but if I run
const uspSlideshow = new Slick(uspSlide, uspOptions);
slickSlider.unslick();
slickSlider.reinit();

I get an error which I'm not able to fix:
Uncaught TypeError: Cannot read properties of undefined (reading 'offsetWidth')

Do you think I can open an issue on the https://github.com/ubergeoff/flingo/ repository even if it's only related to a library in that project?
Thanks

@gtempesta-pixartprinting - please feel free to log the error there - yes... will take a look over on that side..

+1

So how do you use this in a basic one page website?

@ubergeoff Thank you so much for your work on vanilla-fy-ing my favorite slider plugin!
@AGrush (and anyone finding this thread in the future), I had luck setting up ubergeoff's version of Slick like this for usage outside a framework.
I needed to reference my Slicks from a separate JS file than they were created in, so I decided to store them on the window object, referencing them by the name/id of the parent.
var containerID = "my-container-id";
var slickContainer = document.getElementById(containerID);
var slickObject = new Slick(slickContainer, {
  slidesToScroll: 1,
  slidesToShow: 3,
  arrows: false,
  dots: false,
  mobileFirst: true
});

var Slicks = window.Slicks = window.Slicks || {};
Slicks[containerID] = slickObject;

With it setup like that, elsewhere after my Slick has been initialized, I can call the Slick methods on the Slick item, like this:
window.Slicks["my-container-id"].slickGoTo(slideNumber, true);

Hope that helps anyone looking to do the same thing.


feat: fix unit tests

Description:

Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.15%.  Consider uploading reports for the commit 25bf85d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2241   +/-   ##
=======================================
  Coverage   75.15%   75.15%
=======================================
  Files          13       13
  Lines         644      644
  Branches      118      118
=======================================
  Hits          484      484
  Misses        115      115
  Partials       45       45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@georgi-l95 can we close this PR?

@AlfredoG87 yep, I'm closing it


Add unique aggregate index on subject_id and workflow_id

close #1135
Please check the rake task code, i wrote it pretty quickly and haven't tested on a copy of the db that has dups.

The rake thing was borked? I'll give it a go.


Remove deprecated decorators + boto dependency

DO NOT MERGE YET - should only be merged when we're ready for a major release (3.0.0)
This PR removes the deprecated decorators + boto and httpretty dependencies.
The majority of the boto-tests were already rewritten using boto3 in #3842 (and related PR's). As a result, this PR can remove the boto-tests without losing any coverage.
Removing old API versions
As an additional measure, I'd like to also repurpose the rds and dynamodb module. Both use a deprecated AWS API, and the majority of the users will be using the current API anyway.
I propose the following upgrade path:
Moto 2.x:

Add a warning when using the mock_dynamodb and mock_rds decorator, to indicate that they will repurposed in a future release

Moto 3.0.0:

Remove _deprecated decorators

Moto 3.1.0:

Point mock_dynamodb to the dynamodb2 implementation (rds -> rds2), so that users can use these decorators interchangeably, and both use the latest API
Add a warning to dynamodb2/rds2 that users should switch to dynamodb and rds
From this release onwards, the deprecated API's will no longer be testable using the Moto decorators

Moto 4.x:

Remove the dynamodb2 and rds2 decorators, as users will have had enough time to switch to the mock_dynamodb and mock_rds decorators.

Edit 12/10:
I've changed the upgrade path to show the warning when using the mock_dynamodb and mock_rds decorator as early as possible.
Before, I only wanted to show this warning in 3.x - but I've realized it makes sense to give people as much warning as possible.

Codecov Report

Merging #4378 (e35887b) into master (7deabd3) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4378      +/-   ##
==========================================
- Coverage   95.12%   94.77%   -0.36%
==========================================
  Files         501      501
  Lines       56461    56307     -154
==========================================
- Hits        53709    53365     -344
- Misses       2752     2942     +190

Flag
Coverage Δ

servertests
36.64% <72.05%> (-12.19%)
:arrow_down:

test_responses
32.62% <63.23%> (-0.14%)
:arrow_down:

unittests
94.68% <100.00%> (-0.35%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/dynamodb/__init__.py
100.00% <ø> (ø)

moto/iam/__init__.py
100.00% <ø> (ø)

moto/route53/__init__.py
100.00% <ø> (ø)

moto/s3/__init__.py
100.00% <ø> (ø)

moto/ses/__init__.py
100.00% <ø> (ø)

moto/sts/__init__.py
100.00% <ø> (ø)

moto/__init__.py
97.95% <100.00%> (-0.48%)
:arrow_down:

moto/apigateway/__init__.py
100.00% <100.00%> (ø)

moto/athena/__init__.py
100.00% <100.00%> (ø)

moto/autoscaling/__init__.py
100.00% <100.00%> (ø)

... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23e507...e35887b. Read the comment docs.


fix(tilecatalognew): console warnings

carbon-addons-iot-react/issues/1255
Closes https://github.com/IBM/carbon-addons-iot-react/issues/1255
Summary
Fixes PropTypes and aria properties to prevent console warnings.
Change List (commits, features, bugs, etc)

https://github.com/IBM/carbon-addons-iot-react/commit/34ba26708e9d05ea0bdcf0921a99d5bd5d4906c6

Acceptance Test (how to verify the PR)

open TileCatalogNew story and verify console warnings are no longer printed

:tada: This PR is included in version 2.84.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update of Core from Core elements

Description
Some Core elements (see GUI controls for Core) can provide feedback to Core (such as: "Create a new scenario").
We need to come up with a way to make this possible.
Acceptance Criteria

[ ] An API is accessible from the front-end to trigger Core actions.

this is handled by the GuiCoreContext

it provides callbacks for the front-end components
it calls the core API


Fix javadoc comments

Pull Request
Description
Fix existing javadoc comments.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code cleanup/refactoring
[x] Documentation update
[ ] This change requires a documentation update
[ ] CI system update
[ ] Test Coverage update

Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:

Java: v11
LPVS Release: v1.x.x

Checklist:

[ ] My code follows the style guidelines of this project
[ ] My code meets the required code coverage for lines (90% and above)
[ ] My code meets the required code coverage for branches (80% and above)
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2cfc37e) 91.01% compared to head (d6903f1) 91.01%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #362   +/-   ##
=========================================
  Coverage     91.01%   91.01%
  Complexity      486      486
=========================================
  Files            48       48
  Lines          1703     1703
  Branches        206      206
=========================================
  Hits           1550     1550
  Misses           89       89
  Partials         64       64

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


decoder is not a function

Here is a minimal test case:
module Main where

import Html exposing (div, text)

import Json.Decode exposing (..)
import Dict exposing (Dict)

type Rec = A Int
         | R (List Rec)

decodeSumObjectWithSingleField : String -> Dict String (Decoder a) -> Decoder a
decodeSumObjectWithSingleField name mapping = keyValuePairs value `customDecoder` \lst -> case lst of
    [(key,value)] -> decodeSumFinal name key value mapping
    _ -> Err ("Can't decode " ++ name ++ ": object has too many keys")

decodeSumFinal : String -> String -> Value -> Dict String (Json.Decode.Decoder a) -> Result String a
decodeSumFinal name key value mapping =
    case Dict.get key mapping of
        Nothing -> Err ("Unknown constructor " ++ key ++ " for type " ++ name)
        Just dec -> Json.Decode.decodeValue dec value

decRec : Decoder Rec
decRec =
    let dic = Dict.fromList
                [ ("A", map A int)
                , ("R", map R (list decRec))
                ]
    in  decodeSumObjectWithSingleField "Rec" dic

sample : String
sample = "{\"R\":[{\"A\":1}]}"

main : Html.Html
main = div [] [text <| toString <| decodeString decRec sample]

It displays Err ("custom decoder failed: decoder is not a function") instead of the expected decoded output. I think this is related to #873, but I really am not sure.

Anyone have any idea how to get this down to an SSCCE?
I can guess that some kind of JS runtime error is occurring, which is caught and turned into an Err.

Anyone have any idea how to get this down to an SSCCE?
I can guess that some kind of JS runtime error is occurring, which is caught and turned into an Err.

While debugging I noticed that the "decoder" variable was undefined.
Le 1 janv. 2016 5:05 PM, "Max Goldstein"<EMAIL_ADDRESS>a
écrit :

Anyone have any idea how to get this down to an SSCCE http://sscce.org/?
I can guess that some kind of JS runtime error is occurring, which is
caught and turned into an Err.
—
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/elm-compiler/issues/1244#issuecomment-168314206
.

While debugging I noticed that the "decoder" variable was undefined.
Le 1 janv. 2016 5:05 PM, "Max Goldstein"<EMAIL_ADDRESS>a
écrit :

Anyone have any idea how to get this down to an SSCCE http://sscce.org/?
I can guess that some kind of JS runtime error is occurring, which is
caught and turned into an Err.
—
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/elm-compiler/issues/1244#issuecomment-168314206
.

This is the faulty code:
var decRec = function () {
  var dic = $Dict.fromList(_U.list([{ctor: "_Tuple2"
                                    ,_0: "A"
                                    ,_1: A2($Json$Decode.map,A,$Json$Decode.$int)}
                                   ,{ctor: "_Tuple2"
                                    ,_0: "R"
                                    ,_1: A2($Json$Decode.map,R,$Json$Decode.list(decRec))}]));
  return A2(decodeSumObjectWithSingleField,"Rec",dic);

}();
In the second entry of the Dict, decRec is undefined!

I didn't even see the recursive call in all of that!
Here is an SSCCE:
import Graphics.Element exposing (show)
import Json.Decode exposing (..)

type Person = Person { name : String, children : List Person }

decode : Decoder Person
decode =
  map Person <|
    object2 (\n c -> {name = n, children = c})
      ("name" := string)
      ("children" := list decode)

json =
  """ { "name": "Nat King Cole", "children": [ { "name": "Natalie Cole", "children": [] } ] }"""

main = show <| decodeString decode json

It seems recursive decoding is buggy.

It's not recursive decoding that is buggy. It's just again that recursive values are problematic. Just another instance of #873.

Or https://github.com/elm-lang/core/issues/361 if you want it more specific.

@bartavelle, your code can be made to work, as follows:
module Main where

import Html exposing (div, text)

import Json.Decode exposing (..)
import Dict exposing (Dict)

type Rec = A Int
         | R (List Rec)

decodeSumObjectWithSingleField : String -> Dict String (() -> Decoder a) -> Decoder a
decodeSumObjectWithSingleField name mapping = keyValuePairs value `customDecoder` \lst -> case lst of
    [(key,value)] -> decodeSumFinal name key value mapping
    _ -> Err ("Can't decode " ++ name ++ ": object has too many keys")

decodeSumFinal : String -> String -> Value -> Dict String (() -> Json.Decode.Decoder a) -> Result String a
decodeSumFinal name key value mapping =
    case Dict.get key mapping of
        Nothing -> Err ("Unknown constructor " ++ key ++ " for type " ++ name)
        Just dec -> Json.Decode.decodeValue (dec ()) value

decRec : Decoder Rec
decRec =
    let dic = Dict.fromList
                [ ("A", \() -> map A int)
                , ("R", \() -> map R (list decRec))
                ]
    in  decodeSumObjectWithSingleField "Rec" dic

sample : String
sample = "{\"R\":[{\"A\":1}]}"

main : Html.Html
main = div [] [text <| toString <| decodeString decRec sample]

Can the issue be closed, then?

I already applied a workaround to my code, but I thought the issue was the code generator bug, not its manifestation in my specific use case ?

Sure. But the code generator bug is already tracked in #873. So, the issue here could be closed irrespective of the code I posted above to address the specific use case. That, I posted just as a convenience.

Oh yes, sure!

(and thanks again by the way)

For anyone else who stumbles on this issue, we ended up using
JSDecode.succeed () `JSDecode.andThen` recursiveDecoder

to thunkify the decoder in question


GitHub settings page sidebar doesn't navigate

See original issue #31
Bug was first seen in M107.0.5256.0, was fixed in M107.0.5271.0.
The bug is back as of M108.0.5314.0

@gz83 This issue is NOT present on Thorium-Win 5314 or other regular versions of Chromium, only Thorium-AVX2 5314.

I was just about to make an issue about this as well. I also faced problems on Discord (gives the "Well this is awkward" error page after using it for a few seconds), and Youtube Studio (the page contents show for a split second then immediately disappears into a blank page).
I can also confirm this issue happens on 107.0.5256.0, but NOT on 107.0.5271.0, which is the version I'm currently using, but unfortunately returned in 108.0.5314.0. I can also confirm it doesn't happen in the regular AVX releases of Thoriun-Win.

@Delphox @SodaPortal @tomByrer See if latest release fixes issues.

@Alex313031 nope still happens. :(

Issue still present in release from an hour ago :(

Issue still present in release from an hour ago :(

@Delphox Does the latest released version still have this problem?

The one from this repo yes. Still loads a blank screen on Youtube Studio. Regular AVX version from Thorium-Win is fine.

M110 seems to fix everything! YT studio loads and I've been using Discord Web for hours with no crash so far.
Small observation, the .bat launcher from the AVX2 zip release is still the old one without the new disable encryption and machine id arguments. However using the bat from regular Thorium-Win version works fine.

@Delphox Yeah, I mentioned in the release notes that everything should be fixed in M110.  We were using /fp:fast (floating point contraction = fast) during compilation, to make it faster. However, it looks like this causes bugs on windows (on linux it doesn't), and is most likely causing very small rounding errors in math routines used when rendering web pages, causing random and small breakages across sites.

@


Please add count to ae and ie

The ae and ie object selectors would be more useful if you could prepend a count.  BTW, I'm really liking vim-sexp.

Hello, thanks for reporting!
The ae and ie text objects are analogous to the builtin aw and iw objects, which do not accept a count. The <M-f> and <M-b> motions do accept counts, however, and are probably what you're looking for.
HTH!

The ae and ie object selectors would be more useful if you could prepend a count. BTW, I'm really liking vim-sexp.

@dubiousdavid I've implemented this feature (along with several others) on a fork I'm preparing for an eventual PR: enhanced-sexp-objects
Features are mostly documented/working, (though significant code cleanup is still needed).
Feedback welcome...


Reduce collisions by using a much larger hash (2^53)

This PR greatly improves the algorithm by using up to 2^53 module IDs. The number 53 comes from the JavaScript/EcmaScript limit of the largest integer that can be considered "safe".
The probability of a collision is now 0.0000000000000011102% * (number of modules)!
A new hashSize option controls the size of the hash (previous behavior would be 28 bits).
Fortunately Webpack does not store it's modules in an array (it's an object), as otherwise this would lead to immensely huge arrays (and thus memory problems). I actually wonder why module IDs can't be strings.
This version has been successfully tested in current Chrome, Firefox, IE11 and Edge browsers. It should work fine in all browses.
@zhenyong I would be glad if you accept this pull request, thanks!

Some measurements.
| no hash | 28bit | 53bit
---|---|---|---
bundle.js | 4.43Mb | 4.45Mb (+0.45%) | 4.48Mb (+1.13%)
bundle.min.js | 1.53Mb | 1.55Mb (+1.31%) | 1.58Mb (+3.27%)
bundle.min.js.gz | 385K | 453K (+17.66%) | 466K (+21.04%)

Interesting. Thanks for sharing.
Maybe some bytes can be saved by hex-encoding the values (0x12345...). I don't know if Webpack makes that possible.

@zhenyong any feedback?

@jampy Thanks and sorry too late.
Really awesome, it take me serval hours to learn knowledge behind.

@zhenyong thanks, would you mind publish  a new release on npmjs please?

@jampy Done.


Operator Deployment OOMKill.

The memory limits might be a little too low. I wonder if anyone else is seeing the same with this version. I'm not doing anything fancy.
Version: v0.10.0
I needed to patch them to 400Mi (Not precise. I just picked a number):
[
  {
    "op": "replace",
    "path": "/spec/template/spec/containers/1/resources/limits/memory",
    "value": "400Mi"
  }
]

Thanks!

Edit: Removed an incorrect code line reference.
https://github.com/adyanth/cloudflare-operator/blob/c38e0cc14dceef41729f8f9852c5e3743d392bff/controllers/reconciler.go#L491

I am assuming you mean the Cloudflare tunnel deployment and not the operator itself?
Mine seems to be running fine with the same limits, may I ask which version of cloudflared are you using?

I am assuming you mean the Cloudflare tunnel deployment and not the operator itself?

No, the operator.
This is the snippet from my kustomization.yaml:
patches:
- path: patches/cloudflare-operator-controller-manager-resources.json
  target:
    group: apps
    version: v1
    kind: Deployment
    name: cloudflare-operator-controller-manager

I'll get a log capture. Not at the system right now.

Okay. I see the confusion. I referenced the the tunnel deployment code in the original post.
This is what I meant to reference: https://github.com/adyanth/cloudflare-operator/blob/c38e0cc14dceef41729f8f9852c5e3743d392bff/config/manager/manager.yaml#L51
Pod logs:
manager I0531 06:34:20.420863       1 request.go:601] Waited for 1.002272575s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/batch/v1?timeout=32s
manager 1.6855148613748305e+09    INFO    controller-runtime.metrics    Metrics server is starting to listen    {"addr": "<IP_ADDRESS>:8080"}
kube-rbac-proxy I0531 06:31:02.064905       1 main.go:190] Valid token audiences:
kube-rbac-proxy I0531 06:31:02.065069       1 main.go:262] Generating self signed cert as no cert is provided
kube-rbac-proxy I0531 06:31:02.628100       1 main.go:311] Starting TCP socket on <IP_ADDRESS>:8443
kube-rbac-proxy I0531 06:31:02.628691       1 main.go:318] Listening securely on <IP_ADDRESS>:8443
manager 1.6855148613757348e+09    INFO    setup    starting manager
manager 1.685514861376296e+09    INFO    Starting server    {"path": "/metrics", "kind": "metrics", "addr": "<IP_ADDRESS>:8080"}
manager 1.6855148613763669e+09    INFO    Starting server    {"kind": "health probe", "addr": ":8081"}
manager I0531 06:34:21.376443       1 leaderelection.go:248] attempting to acquire leader lease cloudflare-operator-system/9f193cf8.cfargotunnel.com...
manager I0531 06:34:37.877037       1 leaderelection.go:258] successfully acquired lease cloudflare-operator-system/9f193cf8.cfargotunnel.com
manager 1.6855148778770685e+09    DEBUG    events    cloudflare-operator-controller-manager-548fc568dc-cfs8c_033a82a3-9de3-4d13-90d8-123523d8bed3 became leader    {"type": "Normal", "object": {"kind":"Lease","namespace":"cloudflare-operator-system","name":"9f193cf8.cfargotunnel.com","uid":"b5e6b291-a2a9-4593-aac0-d5a4dc43119b","apiVersion":"coordination.k8s.io/v1","resourceVersion":"1514017449"}, "reason": "LeaderElection"}
manager 1.6855148778774395e+09    INFO    Starting EventSource    {"controller": "tunnel", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "Tunnel", "source": "kind source: *v1alpha1.Tunnel"}
manager 1.6855148778775022e+09    INFO    Starting EventSource    {"controller": "tunnel", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "Tunnel", "source": "kind source: *v1.ConfigMap"}
manager 1.685514877877516e+09    INFO    Starting EventSource    {"controller": "tunnel", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "Tunnel", "source": "kind source: *v1.Secret"}
manager 1.6855148778775249e+09    INFO    Starting EventSource    {"controller": "tunnel", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "Tunnel", "source": "kind source: *v1.Deployment"}
manager 1.685514877877531e+09    INFO    Starting Controller    {"controller": "tunnel", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "Tunnel"}
manager 1.6855148778777483e+09    INFO    Starting EventSource    {"controller": "tunnelbinding", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "TunnelBinding", "source": "kind source: *v1alpha1.TunnelBinding"}
manager 1.6855148778777907e+09    INFO    Starting Controller    {"controller": "tunnelbinding", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "TunnelBinding"}
manager 1.6855148778777394e+09    INFO    Starting EventSource    {"controller": "clustertunnel", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "ClusterTunnel", "source": "kind source: *v1alpha1.ClusterTunnel"}
manager 1.6855148778778672e+09    INFO    Starting EventSource    {"controller": "clustertunnel", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "ClusterTunnel", "source": "kind source: *v1.ConfigMap"}
manager 1.6855148778778884e+09    INFO    Starting EventSource    {"controller": "clustertunnel", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "ClusterTunnel", "source": "kind source: *v1.Secret"}
manager 1.6855148778779e+09    INFO    Starting EventSource    {"controller": "clustertunnel", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "ClusterTunnel", "source": "kind source: *v1.Deployment"}
manager 1.6855148778779075e+09    INFO    Starting Controller    {"controller": "clustertunnel", "controllerGroup": "networking.cfargotunnel.com", "controllerKind": "ClusterTunnel"}
Stream closed EOF for cloudflare-operator-system/cloudflare-operator-controller-manager-548fc568dc-cfs8c (manager)

It seems doubling the limit to 200Mi will get the container to successfully start.

Well this is interesting. Two EKS clusters. Different versions. Both AL2.
1.24.13 : 5.4.241-150.347.amzn2.x86_64 - lower mem
1.23.17 : 5.10.178-162.673.amzn2.x86_64 - higher mem

I wonder if the kube client discovery cache is bloating the memory.
I don't have an excessive number of CRDs in either. I cleaned up the 1.24 cluster before the image above.
I'll clean up the 1.23 cluster tomorrow and see what happens.

That does not seem right and I cannot think of a way to debug why this one is taking more memory (other than profiling it, which I am not sure is worth the effort haha) since the containers themselves do not have any tools for you to exec into. The 50 MB sounds about right. I do not think the kube discovery has anything to do with this, but sure, lemme know. Mine used to be on k8s 1.22, now on 1.26 so the version should not be an issue.

I did get an alloc flame graph with the krew flame plugin. Github does a static rendering, so the 15min one is sort of useless when posted here.
1m:

15m:

I guess I have something wrong with that cluster. I'll roll this out to the rest and compare.
FWIW, there's just a single ClusterTunnel in my deployment. The overlays only change the name of the tunnel.

Is that a alloc count or byte graph? Either way, all I see are k8s libraries used by the controller, nothing from the code from this project. The widest call by x/net/http2 -> compress/gzip seems like a lot of (or a large body of, depending on what graph this is) HTTP requests to the manager pod. If health checks or something like that are misconfigured (to either send a lot of requests or request with large content), it could be a reason too.

fwiw, I'm seeing this behaviour on an OpenShift 4.14 (k8s 1.27) cluster:

after patching the limit, memory usage hovers around 150mb:


Update Known-issues.md

SPO vanity domain issue resolved February 2019. https://icm.ad.msft.net/imp/v3/incidents/details/104609094/home

@marclauinger needs to approve any changes to this article. Please do NOT merge this PR without his approval.

The ICM attached does not match the known issue.  The ICM is about adding a sharepoint tab and the Save button not getting activated, nothing about when going to the new tab it showing a blank page.  Has someone verified that adding an SPO page to a tab actually renders correctly now?

 This is also documented against https://domoreexp.visualstudio.com/MSTeams/_workitems/edit/287249 and https://domoreexp.visualstudio.com/MSTeams/_workitems/edit/243161. We can also defer to<EMAIL_ADDRESS>for this as needed.

Then it should be good.  I couldn't find the bugs and in the ICM I didn't see any links.  Approving.


banner added only

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

hmm actually that makes no sense, the tabs are in but are not visible in UI yet. why got yarntest fail already

now failing on smoke test, querying for # of policies on a default instance of datahub quickstart?? how come can fail one

now only left smoke test, but it is failing in weird way.... count of policies ingested =/=8?


Update SchemaGenerator to fix #2514 and #2052 (Rebased)

Rebases #2683
The issue or feature being addressed
#2052 #2514

Details on the issue fix or feature implementation

This pull request fixes (reverts) the placement of the discriminator to the polymorphic oneOf element. Fixes https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/2052.
This pull request also fixes https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/2514 and the bug where enabling UseOneOfForPolymorphism forces UseAllOfForInheritance=true (when UseAllOfForInheritance=false).

I've posted my current progress, but I think I'm stuck now. The code compiles and work, but the unit tests fail.
I don't know how to fix them because I don't understand the different use cases well enough.
Specifically,

What is the interplay between UseAllOfForInheritance and UseOneOfForPolymorphism?
Does it (ever?) make sense for the BaseType to keep a discriminator entry?
What works well/at all with other projects like code generators/Json deserialisers?


[SPARK-25790][MLLIB] PCA: Support more than 65535 column matrix

What changes were proposed in this pull request?
Spark PCA supports maximum only ~65,535 columns matrix. This is due to the fact that, it computes the Covariance matrix first, then compute principle components. The main bottle neck was computing covariance matrix. The limit 65,500 came due to the integer size limit. Because we are passing an array of size n*(n+1)/2 to the breeze library and the size cannot be more than INT_MAX. so, the maximum column size we can give is 65,500.
Currently we don't have such limitation for computing SVD in spark.  So, we can make use of Spark SVD to compute the PCA, if the number of columns exceeds the limit.
Computation of PCA can be done directly using SVD of matrix, instead of finding the covariance matrix.
Following are the papers/links for the reference.
https://arxiv.org/pdf/1404.1100.pdf
https://en.wikipedia.org/wiki/Principal_component_analysis#Singular_value_decomposition
http://www.ifis.uni-luebeck.de/~moeller/Lectures/WS-16-17/Web-Mining-Agents/PCA-SVD.pdf
How was this patch tested?
added UT, also manually verified with the existing test for pca, by removing the limit condition in the fit method.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test results with existing PCA and using SVD without computing covariance matrix
val data = Array(
Vectors.sparse(5, Seq((1, 1.0), (3, 7.0))),
Vectors.dense(2.0, 0.0, 3.0, 4.0, 5.0),
Vectors.dense(4.0, 0.0, 0.0, 6.0, 7.0))

PCA using covariance matrix
explained Variance = [ 0.7943932532, 0.2056067468, 1.26E-16]
Top 2 Principle components :
[[-0.44859172075072673 -0.28423808214073987
0.13301985745398526 -0.05621155904253121
-0.1252315635978212 0.7636264774662965
0.21650756651919933 -0.5652958773533949
-0.8476512931126826 -0.11560340501314653 ]]

PCA using SVD, without computing covariance matrix:
explained Variance = [0.7943932532, 0.2056067468, 5.55E-17]
Top 2 Principle components :
[[-0.44859172075072673 -0.2842380821407399
0.13301985745398529 -0.056211559042531424
-0.12523156359782125 0.7636264774662964
0.21650756651919945 -0.5652958773533953
-0.8476512931126826 -0.11560340501314664]]

Leading Eigen Values MSE = 0.0
Leading eigen vectors MSE = 0.0

cc @srowen

ok to test.

Test build #97673 has started for PR 22784 at commit 1252526.

Test build #97673 has finished for PR 22784 at commit 1252526.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97673/
Test FAILed.

retest this please

Test build #97677 has started for PR 22784 at commit e6cf661.

Test build #97678 has started for PR 22784 at commit 9111fca.

Test build #97678 has finished for PR 22784 at commit 9111fca.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97678/
Test FAILed.

Test build #97679 has started for PR 22784 at commit 4c1776f.

Test build #97677 has finished for PR 22784 at commit e6cf661.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97677/
Test PASSed.

Test build #97680 has started for PR 22784 at commit 9aff54f.

Test build #97679 has finished for PR 22784 at commit 4c1776f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97679/
Test PASSed.

Test build #97680 has finished for PR 22784 at commit 9aff54f.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97680/
Test FAILed.

retest this please

Test build #97682 has finished for PR 22784 at commit 9aff54f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97682/
Test FAILed.

All the UTs are passing locally. Seems random error.
retest this please.

Test build #97683 has started for PR 22784 at commit 23cfda1.

Test build #97683 has finished for PR 22784 at commit 23cfda1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97683/
Test PASSed.

Can I clarify the description?

Because we are passing an array of size n*(n+1)/2 to the breeze library and the size cannot be more than INT_MAX. so, the maximum column size we can give is 65,500.

If n > 20726, n*(n+1)/2 > 214783647 ( = INT_MAX). Where does 65,500` come from?

Can I clarify the description?

Because we are passing an array of size n*(n+1)/2 to the breeze library and the size cannot be more than INT_MAX. so, the maximum column size we can give is 65,500.

If n > 20726, n*(n+1)/2 > 214783647 ( = INT_MAX). Where does 65,500` come from?

Can I clarify the description?

Because we are passing an array of size n*(n+1)/2 to the breeze library and the size cannot be more than INT_MAX. so, the maximum column size we can give is 65,500.

If n > 20726, n*(n+1)/2 > 214783647 ( = INT_MAX). Where does 65,500` come from?

Can I clarify the description?

Because we are passing an array of size n*(n+1)/2 to the breeze library and the size cannot be more than INT_MAX. so, the maximum column size we can give is 65,500.

If n > 20726, n*(n+1)/2 > 214783647 ( = INT_MAX). Where does this limitation 65,500` come from?

Hi @kiszk ,
I think, INT_MAX is<PHONE_NUMBER>, so n ~= sqrt(2*2147483647) = 65536.
Thanks

Can I clarify the description?

Because we are passing an array of size n*(n+1)/2 to the breeze library and the size cannot be more than INT_MAX. so, the maximum column size we can give is 65,500.

If n > 20726, n*(n+1)/2 > 214783647 ( = INT_MAX). Where does this limitation 65,500` come from?

Can I clarify the description?

Because we are passing an array of size n*(n+1)/2 to the breeze library and the size cannot be more than INT_MAX. so, the maximum column size we can give is 65,500.

If n > 20726, n*(n+1)/2 > 214783647 ( = INT_MAX). Where does this limitation 65,500` come from?

Can I clarify the description?

Because we are passing an array of size n*(n+1)/2 to the breeze library and the size cannot be more than INT_MAX. so, the maximum column size we can give is 65,500.

If n > 20726, n*(n+1)/2 > 214783647 ( = INT_MAX). Where does this limitation 65,500` come from?

One question: After this PR, what is the maximum column that we can accept?

Hi @kiszk Maximum it can go upto the following limit.
https://github.com/apache/spark/blob/23cfda1547355a823a3b2b2d374e64608c9ce175/mllib/src/main/scala/org/apache/spark/mllib/linalg/EigenValueDecomposition.scala#L78-L79
where ncv = min(n, 2*k), normally k << n.
For eg: if n = 1 million features, we can compute top 100 principle components.
Number of principle components to compute is configurable.

Hi @srowen , Thanks for the comment. As per my knowledge, PCA/SVD is not limited on row size.

Currently row size is not a constraint. Ultimately we need to compute graminan matrix/GramianMatrix vector product to compute SVD.  So, computation of svd is limited by columns only.

Sparsity is only for the computation of gramian matrix/ gramian matrix vector product in both PCA and Spark SVD. Mean centred vector  will always be dense. Currently PCA is computed with dense matrix and SVD uses dense vector.
So, only constraint about dense is coming in the matrix vector product computation.

In this PR, if the limit exceeds, it will compute in the distributed manner, which current PCA doesn't support.

Currently PCA is not scalable in terms of column number
For 40GB driver memory, and number of columns is 40,000 and number of rows is 1lakh, I am getting following error.

scala> val pca = new PCA(k).fit(rad)
2018-10-22 22:44:23,128 | WARN  | main | 40000 columns will require at least 12800 megabytes of memory! | org.apache.spark.internal.Logging$class.logWarning(Logging.scala:66)
2018-10-22 22:47:02,836 | WARN  | main | 40000 columns will require at least 12800 megabytes of memory! | org.apache.spark.internal.Logging$class.logWarning(Logging.scala:66)
java.lang.OutOfMemoryError
  at java.io.ByteArrayOutputStream.hugeCapacity(ByteArrayOutputStream.java:123)
  at java.io.ByteArrayOutputStream.grow(ByteArrayOutputStream.java:117)
  at java.io.ByteArrayOutputStream.ensureCapacity(ByteArrayOutputStream.java:93)
  at java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:153)
  at org.apache.spark.util.ByteBufferOutputStream.write(ByteBufferOutputStream.scala:41)
  at java.io.ObjectOutputStream$BlockDataOutputStream.drain(ObjectOutputStream.java:1877)
  at java.io.ObjectOutputStream$BlockDataOutputStream.setBlockDataMode(ObjectOutputStream.java:1786)
  at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1189)
  at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
  at org.apache.spark.serializer.JavaSerializationStream.writeObject(JavaSerializer.scala:43)

Sorry for my mistake. My keyboard '4' sometimes has a trouble.

I think, INT_MAX is<PHONE_NUMBER>, so n ~= sqrt(2*2147483647) = 65536.

Test build #98134 has started for PR 22784 at commit b1789d7.

Thank you @srowen for the review.  I have addressed the comments.

I wonder if the SVD should be used at even smaller scales? as you point out, it's pretty hard to compute a gramian on even a 40k x 40k matrix.

Yes. We can compute the PCA using SVD even for smaller scales. In fact if the number of columns are lesser, Spark SVD computes eigen decomposition by computing gramian matrix first, which is the same approach as in PCA.
The condition for whether to compute gramian matrix first or not is given below, for Spark SVD.
https://github.com/apache/spark/blob/d5573c578a1eea9ee04886d9df37c7178e67bb30/mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala#L232-L243
So, for smaller number of columns, (< 15000 columns), Spark SVD prefers computation of graminan matrix first and then computing the svd, which is same as the current implimentation of PCA.

Test build #98135 has started for PR 22784 at commit a8c4391.

Test build #98134 has finished for PR 22784 at commit b1789d7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98134/
Test PASSed.

Merged build finished. Test PASSed.

Test build #98135 has finished for PR 22784 at commit a8c4391.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98135/
Test PASSed.

Test build #98140 has started for PR 22784 at commit 5674e17.

Test build #98141 has started for PR 22784 at commit 3cbe017.

Test build #98140 has finished for PR 22784 at commit 5674e17.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98140/
Test PASSed.

Test build #98141 has finished for PR 22784 at commit 3cbe017.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98141/
Test PASSed.

Test build #98144 has started for PR 22784 at commit 094594b.

Test build #98145 has started for PR 22784 at commit 18af032.

Test build #98144 has finished for PR 22784 at commit 094594b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98144/
Test PASSed.

Test build #98145 has finished for PR 22784 at commit 18af032.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98145/
Test PASSed.

Test build #98161 has started for PR 22784 at commit 0d9eea8.

Test build #98164 has started for PR 22784 at commit 2b7ee7b.

Test build #98161 has finished for PR 22784 at commit 0d9eea8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98161/
Test PASSed.

Test build #98164 has finished for PR 22784 at commit 2b7ee7b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98164/
Test PASSed.

Test build #98178 has finished for PR 22784 at commit 0effc85.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98178/
Test PASSed.

Thanks a lot @srowen


fix(render/ids): add temp dir for new method of training model creation

Description

Add an emptyDir for some detectors as a temp folder to write data to for the process of model creation.  Only a temporary directory is required and would be deleted once the detector pod is done running and the model has been committed to the model storage api
For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

not needed - fixed AD pod side


[$1000] mWeb/safari - Split -  What's it for? field jumped to the top of the page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch App
Click on the green plus button (FAB) > Split Bill > Add the amount and currency
Select a couple of attendees from the list
Tap on Next
Tap on 'What's it for" line to enter message

Expected Result:
What's it for? field is not jumped to the top of the page
Actual Result:
What's it for? field jumped to the top of the page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/221906082-9cd292aa-3b56-41ad-b17d-33e9098041c9.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0109a0cf5e28e65c10
Upwork Job ID:<PHONE_NUMBER>227999744
Last Price Increase: 2023-03-07

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

There is another area when field is jump to the top under Invite Members, please let me know if we need create a separate issue for this.
https://user-images.githubusercontent.com/93399543/221916560-3ee15012-c447-4293-995f-397021b8fd4c.mp4

Hm I am also getting the issue where tapping What's it for "jumps the field out of view, sort of like @kbecciv has shown in the most recent comment. I can't reproduce the specific issue mentioned here though.
https://user-images.githubusercontent.com/22508290/222295747-01e699c5-ab09-433e-a562-3d20801671e6.MP4
@kbecciv are you still seeing the original issue as well?

@kevinksullivan Let me check original issue, will update you shortly.

@kevinksullivan We are still seeing the original issue with build <IP_ADDRESS>
https://user-images.githubusercontent.com/93399543/222517268-da367e68-1097-4383-b7b4-6f194de0efc4.MP4

Job added to Upwork: https://www.upwork.com/jobs/~0109a0cf5e28e65c10

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

Triggered auto assignment to @bondydaa (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Exported

This is a dupe #15572 @kevinksullivan.

Ah ok, going to close then.


Enable ppc64le on 3Scale-istio-adapter

Hi,
Thanks for the wonderful readme/documentation, I could build 3scale-istio-adapter from the source almost instantly, run the tests outlined successfully on ppc64le architecture.
In case, if you are wondering what ppc64le architecture is?
It is a RISC Architecture and is IBM's prodigy, IBM has recently made its ISA (Instruction Set Architecture) opensource,
doing so they have contributed back to the opensource world. Many of the pioneers of banking, HPC industries today run on ppc64le architecture.
As an ongoing effort to enable open-source projects to which ppc64le architecture can add value, we are trying to enable this project. We have seen absolutely no deviation in build/test instructions. I will soon submit a PR to enable build/testing on ppc64le architecture as well.
So, what would it take from us to enable ppc64le in the CI/CD pipeline?
Currently we are enabled/certified on Travis & Jenkins.

Hi @krishvoor,
we currently use CircleCI for the CI pipeline of this project, but AFAICT there is no ppc64le support there for native compilation. If you have a cross compiler running on amd64 targeting ppc64le it should be just a matter of adding the appropriate job for CircleCI in the .circleci configuration.
Alternatively I'm happy to take your PR as well if you add a Travis pipeline with a ppc64le runner, as it can run in parallel with CircleCI.

Hi @unleashed,
Thanks for your response, I agree with the latter proposal, for now, we can enable the ppc64le architecture via Travis Pipeline. I will work on a PR and submit for your review.

Additionally, are the binaries/ container image published? If so, what will be the location?

Currently the images are automatically built by Quay when tagging releases. I don't know if quay.io supports building ppc64le directly, but if not we can have a script pick up all different architecture builds and push a multiarch image to quay.io.

Thanks for your review & merge - @unleashed

don't know if quay.io supports building ppc64le directly

AFAIK, we can build the container images on ppc64le architecture and push them to quay.io
I can work with you and help you streamline anything that is needed from ppc64le architecture and aim to be available from
next GA release.

Hi @unleashed -
The short answer to this is no -

don't know if quay.io supports building ppc64le directly via the build - trigerrs

For multi-arch, with help of image manifest - we can do something like this  -
Travis-CI - https://github.com/razee-io/RemoteResourceS3/blob/master/.travis.yml#L51
Corresponding Quay Repo- https://quay.io/repository/razee/remoteresources3?tag=latest&tab=tags
Let me know your thoughts ( especially on integration of Circle-CI on Travis-CI ), we can work something out.

@krishvoor that looks just fine, especially when paired with the job to create the multiarch image - https://github.com/razee-io/RemoteResourceS3/blob/c1e29392d4a4fa292f1f9a926ab423fd7e5e003f/.travis.yml#L115. My concern is whether the creation of the multiarch image could fail due to any one of the arches not being built yet by the time it executes (since this is on Travis the only build that could be not yet published would be the amd64 one by Quay), but I think in practice Travis is likely to be slower and we can add some waiting to decrease the odds that the multi-arch image build will fail.
TL;DR: the approach sounds good to me.


fix(headless): improved condition that needs to be satisfied before handling a generated answer stream

SFINT-5516
The issue
In Salesforce, where the Abort Controller is not available, we currently use a a ponyfill to mimic the behaviour of the the Abort Controller and to create an alternative abortable fetch.
However, this workaround we created is not able to really abort and the stop the communication completely.
I tested and confirmed that a simple fetch request can be stopped using our ponyfill. However the server sent communication that we initiate with the fetch-event-source library to get the generated answer is not completely stopped, the server is still sending messages even after aborting the request.
Therefor, the following corner case is occurring sometimes when triggering a new search query while a generated answer is still being streamed:
https://github.com/coveo/ui-kit/assets/86681870/17d1b9ba-d738-4ece-842c-29d0a19a21b2
The solution:
To solve this, we strengthened the condition that needs to be satisfied before taking a generated answer stream in consideration.
Now we first check if abortController.signal.aborted is set to true, if it is the case we discard the stream even if its request is not completely aborted.
https://github.com/coveo/ui-kit/assets/86681870/37cc4fc5-fb65-4f88-8a8d-d15d66e55c11

I don't think this is the right solution.
Of course, the true solution would be for Salesforce to porperly support standard web APIs, but well, we can't count or act on that 🙄.
So, because we can't rely on our fetch being aborted properly (sigh...), we should ignore it if its aborted. For that, the state handling is too "high" in the code proposed: this should not be handled at the state level, instead this should be handled at the API level.
i.e. response from aborted request should not be considered at all and not trigger actions even.
So I would suggest to add support for AbortController in the generated-answer-client instead.
i.e. if abortCtrler.abort() is called, the listeners.
Here's a patch that should do just that:
diff --git a/packages/headless/src/api/generated-answer/generated-answer-client.ts b/packages/headless/src/api/generated-answer/generated-answer-client.ts
index 6b22f0b6e..9bdccd011 100644
--- a/packages/headless/src/api/generated-answer/generated-answer-client.ts
+++ b/packages/headless/src/api/generated-answer/generated-answer-client.ts
@@ -132,6 +132,9 @@ export class GeneratedAnswerAPIClient {
           }
         },
         onmessage: (event) => {
+          if (abortController?.signal.aborted) {
+            return;
+          }
           const data: GeneratedAnswerStreamEventData = JSON.parse(event.data);
           if (data.finishReason === 'ERROR') {
             timeoutStateManager.remove(timeout!);
@@ -152,6 +155,9 @@ export class GeneratedAnswerAPIClient {
           }
         },
         onerror: (err) => {
+          if (abortController?.signal.aborted) {
+            return;
+          }
           timeoutStateManager.remove(timeout!);
           if (err instanceof FatalError) {
             abortController?.abort();

I don't think this is the right solution. Of course, the proper solution would be for Salesforce to support standard web APIs properly, but we can't count or act on that 🙄.
So, because we can't rely on our fetch being aborted properly (sigh...), we should ignore it if it's aborted. For that, the state handling is too "high" in the code proposed: this should not be handled at the state level, instead this should be handled at the API level. i.e., a response from an aborted request should not be considered at all and should not even trigger actions.
So, I would suggest adding support for AbortController in the generated-answer-client instead. i.e. if abortCtrler.abort() is called, the listeners.
Here's a patch that should do just that:
diff --git a/packages/headless/src/api/generated-answer/generated-answer-client.ts b/packages/headless/src/api/generated-answer/generated-answer-client.ts
index 6b22f0b6e..9bdccd011 100644
--- a/packages/headless/src/api/generated-answer/generated-answer-client.ts
+++ b/packages/headless/src/api/generated-answer/generated-answer-client.ts
@@ -132,6 +132,9 @@ export class GeneratedAnswerAPIClient {
           }
         },
         onmessage: (event) => {
+          if (abortController?.signal.aborted) {
+            return;
+          }
           const data: GeneratedAnswerStreamEventData = JSON.parse(event.data);
           if (data.finishReason === 'ERROR') {
             timeoutStateManager.remove(timeout!);
@@ -152,6 +155,9 @@ export class GeneratedAnswerAPIClient {
           }
         },
         onerror: (err) => {
+          if (abortController?.signal.aborted) {
+            return;
+          }
           timeoutStateManager.remove(timeout!);
           if (err instanceof FatalError) {
             abortController?.abort();

Better! thank you @louis-bompart.


Add CSS Nesting

Spec: https://drafts.csswg.org/css-nesting-1/
https://cssdb.org/#nesting-rules
https://twitter.com/Fyrd/status/1103820945758674944 B-)
Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1095675
Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1648037
Safari bug: https://bugs.webkit.org/show_bug.cgi?id=223497

I was looking for info about this and can't find any on CanIUse despite the fact the proposal being [merged ~2 years ago](The https://github.com/w3c/csswg-drafts/pull/2878).
The process on adding information is foreign to me, but should this be added under other or unoff status?

Now available at https://caniuse.com/css-nesting

CSS Nesting is now available in Chromium 109.0.5368.0 with the experimental web platform features flag enabled.

@BenjaminAster PR is ready https://github.com/Fyrd/caniuse/pull/6500

@Schweinepriester Oh, didn't see that, thanks!


Does not detect links inside strong tags

An example of a link that does not get detected:
**Some text before the link [link text](http://www.example.com) and some text after the link**
Any ideas to why this is, and maybe how to solve?

The other way around also doesn't work. If you have italics inside a link, it is not detected:
_This is ok_ but this one [_is not parsed_](http://www.example.com).


Replace default arrow with another SVG

Hello! 👋
I ran into a case where your component is perfect! However, instead of an arrow, there should be a +/- sign.
I was wondering if it would be possible, for a future version, give control to what svg show on the collapsed and uncollapsed state.
Could be something like: collapsedSVG={<CollapsedSvgImage /> and uncollapsedSVG={<UncollapsedSvgImage />}.
Thank you so much! ✨

hey friend!
sorry for not being so long

No worries!
Thank you! 😄

Is this implemented @Eliav2
I am facing same, need to change arrow image.

this is not customable by the API
but you can just copy the source code and replace the ArrowDownIcon.js file with your own svg


Enhance UI

Convert UI to React or Angular while keeping current functionality. Change color scheme to a mild blue. Include test cases where possible.

Angular 1 is fine?

Absolutely.

@ottoliar I actually would prefer it be written in Angular 1. One additional note, please make sure it scales correctly on a mobile devices. Go to our dev version here while on a mobile device to see the scaling problems. Let me know if you have any questions. The UI can be independent from the actual node service.

@BondAnthony Thanks. Would this include changing some of the routing in Express? For example I could put the angular script to make a request to api/status on page load and get rid of pug but that would render some of the test cases failing.

@ottoliar that would be the right direction to head. I'll take care of the failing tests once you make the change. I could create a new branch for this work so I could assist with the service changes while your working on the UI or we can handle the changes after the PR is merged into master.
I might make a devel branch anyway.

I have a devel branch that will deploy directly to the development space on cloudfoundry if you want to do your work on the branch. Dev version

@ottoliar please rebase your next PR off of the changes I've made on devel today.


Communication and collaboration

This issue tracks ways we will communicate and collaborate on Woodstar (SQL Server.Core). Please let us know what works for you, and also comment with your own ideas.
Some initial ideas:

Discord/Slack channel or similar
GitHub discussions on this repo
Teams/Zoom meetings with some/all collaborators
Live streaming

@ErikEJ @wraith2 @NickCraver @mgravell @Drawaes
/cc @davidfowl

Combination of persisted chat and teams/zoom meetings

We can get a channel on the dotnet discord.
I'm open to any/all, whatever is most easy for most people.

Closing issues as part of the repo archiving, see #22 for a summary of Woodstar.


drivers: can: mcp251xfd: Fix initialization sequence

This fixes #73586
The mcp251xfd sometimes fails to initialize on mcu reboot. This is caused by trying to communicate with the mcp too soon (the mcp is still resetting).
This PR adds a 5ms delay.
On init failure (failing to configure the device after reset etc) no console errors would show up which causes confusing for the user/developer.
This PR also makes sure an error would show up in the console log.

Closing in favor of https://github.com/zephyrproject-rtos/zephyr/pull/77816