Input validation

Update #182

What is the state of this PR? Any help needed?

validate_while_typing is not supported.
I am not sure that the mutable line buffer will play well with the undo manager (to be checked).
And if result is incomplete, issue #193 will most likely appear

I needed these changes to make the current branch work, or else I get the errors on rust-1.40:
error[E0283]: type annotations needed: cannot resolve `std::string::String: std::convert::AsRef<_>`
   --> /work/target/.cargo/git/checkouts/rustyline-96f659ed5b4c338d/d15722d/src/lib.rs:627:43
    |
627 |             editor.add_history_entry(line.as_ref());
    |                                           ^^^^^^

error[E0283]: type annotations needed: cannot resolve `std::string::String: std::convert::AsRef<_>`
   --> /work/target/.cargo/git/checkouts/rustyline-96f659ed5b4c338d/d15722d/src/history.rs:151:28
    |
151 |             self.add(line?.as_ref()); // TODO truncate to MAX_LINE
    |                            ^^^^^^

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0283`.

Other than that at a glance, it works. I'm not sure how to check the undo manager you've outlined above. And yes #193 is there when you hit backspace on a new line.
What do we need to do to merge this other than fix the compilation bug? I think #193 is not new and can be handled afterward.

I am sorry.
I don't have much time to finalise this PR.
If we can implement custom actions like replxx, users can mutate the line buffers by invoking/combining several "standard" actions/commands like macros.
And be sure that both undo manager/kill ring are updated correctly.
Something like:
fn custom_action(ctx: &mut ActionContext) -> Result<ActionResult> {
    ctx.invoke(Cmd::Insert(1, ))?;
    ctx.invoke(Cmd::Move(Movement::EndOfLine))?;
    ...
    Ok(ActionResult::Continue)
}

Also we can refresh the screen only once (to avoid flickering).
But this implies refactoring the main loop and split many State methods.
Once we have an ActionContext, I guess we can do the same for validation: no direct mutation.
    fn validate(&self, ctx: &mut ValidationContext) -> Result<ValidationResult> {
        let _ = check(ctx.line());
        ctx.invoke(Cmd::Move(Movement::EndOfLine))?;
        ctx.invoke(Cmd::SelfInsert(1, ';'))?;
        ...
        Ok(...)
    }

Well, maybe I'm misunderstanding the issue here. What I want is just "continue input if the line doesn't contain semicolon". So I don't need a mutable buffer, or actions or whatever.
Maybe I would better just use loop along the lines of:
let initial = "";
loop {
    let line = readline_with_initial(">", (initial, ""));
    if is_full(line) { break line; }
    initial = line;
}

Returning from #311.
I propose we provision this:
enum ValidationResult {
  Valid,
  Incomplete,
  ModificationNeeded,
}
trait Validator {
  fn validate(self, data: &str) -> Result<ValidationResult>;
  fn correct(self, ctx:&mut ModificationContext);
}

But now implemement just this as MVP:
#[non_exaustive]
enum ValidationResult {
  Valid,
  Incomplete,
}
trait Validator {
  fn validate(self, data: &str) -> Result<ValidationResult>;
}

Looks quite easy to make this from the current PR.
Does it look sensible?

The original ValidationResult seems fine to me:
https://github.com/kkawakam/rustyline/pull/231/files#diff-e860543c88a7b150ab5ffca6b874971eR6
/// Input validation result
pub enum ValidationResult {
    /// Incomplete input
    Incomplete,
    /// Validation fails with an optional error message. User must fix the
    /// input.
    Invalid(Option<String>),
    /// Validation succeeds with an optional message (instead of https://github.com/kkawakam/rustyline/pull/169)
    Valid(Option<String>),
}

And if we want to provide auto-correction/auto-formatting/mutation in the future, it seems to me we need to introduce a ValidationContext:
    fn validate(&self, ctx: &mut ValidationContext) -> Result<ValidationResult> {
        let _ = check(ctx.line()); // immutable access
        // ctx.invoke(Cmd::Move(Movement::EndOfLine))?;
        // ctx.invoke(Cmd::SelfInsert(1, ';'))?; in the future, indirect mutation
        ...
        Ok(...)
    }

#193 has been fixed.

And if we want to provide auto-correction/auto-formatting/mutation in the future

Yes, if you're okay with breaking changes. I've just proposed how to make it future proof. So we could introduce mutation later without breaking changes.
Anyway, I'm still not sure what needs to be done to merge this PR?

I am reluctant to provide an API (fn validate(self, data: &str) or fn validate(&self, line: &mut LineBuffer)) that we already know it will need to be broken/changed.

Fair enough. What are use-cases for modification in validator? (I don't see modification documented in prompt-toolkit, but it's always unclear in python :smile:  )
By the way, a future-compatible alternative to the coment above would be something like this:
// Now
fn readonly_validate(&self, data: &str) -> Result<..>;
// Later
fn validate(&self, ctx: &mut ValidationContext) -> Result<..> {
  // default implementation
  self.readonly_validate(self, ctx.get_data())
}

Or should I implement #311 on top of hack above ?

// Now
fn readonly_validate(&self, data: &str) -> Result<..>;
// Later
fn validate(&self, ctx: &mut ValidationContext) -> Result<..> {
  // default implementation
  self.readonly_validate(self, ctx.get_data())
}

looks fine to me.

@tailhook Could you please review last commit ?
Thanks.


(re-)Undo hacky porterstemmer/sphinx fix from #126

Tried this in #129 but the relevant sphinx change didn't get actually released in that minor version update; this time it's there for real.

Looks like this is a bug in sphinx==1.4a1, goes away when I revert to 1.3.x :japanese_ogre:. Guess we can wait for a more stable release in however many months...

Drone is happy now but won't know for sure til readthedocs is too...


"Features not available for Viva Engage tenants in the EU Geo" section is misleading

The external collaboration restrictions referred in the article leads readers to believe that EU Geo does not support any external collaboration capabilities.
This is not correct.
Azure B2B Guest experience is available EU Geo for external collaboration purposes.
It is possible to invite guests into Viva Engage Communities using Azure AD B2B:
Reference articles:
Work with AzureAD-B2B guests in Viva Engage communities | Microsoft Learn
Collaborate with guests in a Viva Engage community | Microsoft Learn

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2ae39c9a-4553-1804-76fa-eedd9125cca9
Version Independent ID: 2ae39c9a-4553-1804-76fa-eedd9125cca9
Content: Data residency for Viva Engage
Content Source: Viva/engage/manage-security-and-compliance/data-residency.md
Service: viva
Sub-service: viva-engage
GitHub Login: @cedemaagd
Microsoft Alias: dmillerdyson

Hello @sinansuer
I am checking this, thanks

Hello @sinansuer An update to the article should be reflected in the published version of the article soon. cc @tiburd
Thank you.


What's the scope of get_state(), set_state(), and get_parameter()

Am I right in thinking that get_state(), set_state(), and get_parameter() are only relevant inside a Haiku Module or the function that creates a Haiku Module?
If yes I think the documentation could be improved a tiny bit to make this clear. For example the way get_state() and set_state() are mentioned in the documentation of transform_with_state() suggests that you can use them with what init() returns.

Hi @mil-ad , thank you for the feedback! *_state mirror get_parameter in that the state is associated with the module you are currently inside (I have heard from others that it is easier to think about this as if the API was self.get_state(..) instead of hk.get_state(..)).
Perhaps the best example of get/set state are in hk.ExponentialMovingAverage where (during training) the value of the moving averages are updated as part of the forward pass of the network.
If you are not inside a module method then parameters/state are put into "root" (or "no module") namespace. This is not a super common use case and it is probably easiest to not think about it. We use this in the documentation to try and keep the code snippet brief (e.g. not including a module class, instantiation etc).
FWIW all Haiku documentation is run under doctest so you can assume that the snippets in transform_with_state (and all others) would work if you ran them 😄

Aw that makes sense. This whole notion of namespaces are also not mentioned in the docs I think? Do you consider PRs from outside DM? I might have a go at making some bits in the doc a tiny bit clearer.

We sure do 😄
As a heads up, a few of us have actually been iterating on the docs a bit recently (e.g. ae0d060, 81d1b4b) and we have some plans to improve the guides section quite a bit, so if you would prefer to wait (and avoid merge conflicts) on that I'd be happy to bump this issue so you can see if the docs are clear enough.


Add ability to clear the consistency manager

Be able to cancel all tasks and wipe listeners. This is useful when logging out.

#21 fixes this


Migrate to LLVM12

With Rust 1.52, rustc uses LLVM12. We should bump the build environments and cargo-bpf to support that version, too.

WIP in https://github.com/foniod/build-images/pull/3

New PR will be sent after PR #160 is merged.
The new PR will use foniod-build images that contain LLVM12.


Parse cmap table with platform 0 as well

Description
Adds support for cmap platformId, encodingId:

[0, 0] Unicode, Default semantics
[0, 1] Unicode, Version 1.1 semantics
[0, 2] Unicode, ISO 10646 1993 semantics (deprecated)
[0, 3] Unicode, Unicode 2.0 or later semantics (BMP only)
[0, 4] Unicode, Unicode 2.0 or later semantics (non-BMP characters allowed)

Motivation and Context
Issue #348
How Has This Been Tested?
npm test and npm start (dropping a couple of fonts including that from #348)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I did npm run test and all tests passed green (including code styling checks).
[ ] I have added tests to cover my changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the README accordingly.
[x] I have read the CONTRIBUTING document.

@moyogo Thanks for the PR!
I guess you'll need that to be published to npm?

Cool! Pls let us know when there is a new release that we can test

Just released 0.9.0 😉

passes all of our tests -- thanks much!


Bugfixes, refactoring, cleanup

Coverage increased (+0.4%) to 88.272% when pulling 04ed0ff6638e769e09ca9da009ab7f4c77d7f464 on michakraus:master into 5057adc36718400f3c4837266e05e9da3528ab9f on DDMGNI:master.


add Array checks after template variable changes

Add Array checks before calling forEach and map so existing dashboards don't break
Prevents definitions.forEach is not a function and similar .map error
see related PR #561

As alternative, could we just wrap part of the component tree in an ErrorBoundary? Feels like that's probably what we want in the future anyway so that an error in that part of the page doesn't break everything?

Going to close this and use #562 instead


UTF-16 unsupported

When calling jsonFromData with an array of UTF-16-encoded bytes, Jay throws unimplemented.
The RFC recommends to determine the encoding by looking at the initial bytes (section 3).
I don't really want UTF-16, but if the API offers (only) a raw bytes interface, I would expect it to take any encoding like JSONSerialization does.

Good point, first step would be to specify in inline documentation that everything is UTF-8.
Regarding supporting UTF-16, I don't see the point, really. I saw some stats that a huge majority of all Internet comms is UTF-8, so I think that's the thing to focus on with limited resources.
But a nice PR would be accepted, I suspect (@dantoml?)

It's probably a relatively easy fix, but I'm not really interested in UTF-16 either, UTF-8 everywhere and all. But I was wondering what the point was of a raw data API if all you take is strings in a specific encoding anyway; might as well just take Strings instead, and not leave room for any error thanks to the type system? (if all the user has is Data/[UInt8], at least they know they have to think about what encoding it is in if the compiler tells you it needs a string).

Ah I see, yeah that makes sense. I'd lean towards 1) documenting we only take UTF-8 and maybe 2) detect the first bytes while parsing and throw a specific error that says it's an incompatible encoding and that we need UTF-8. That should cover the majority of failing cases.

Yeah, I'd go for initially documenting as UTF8 only, and throwing a better error. Then adding actual support later.


Some data types can't be filtered on

For example, we don't support filtering on dates and timestamps.
This is mostly because literals seem to always be strings, floats, or integers. We may need to cast literals in comparisons to match the right type.

We could also support cast() in expressions, which will provide some workaround for this.


Verify binary alloy enthalpy model

First, reproduce this result from Phaseflow (See https://github.com/geo-fluid-dynamics/phaseflow-fenics/issues/83):

I have been trying to resolve a sharper interface, and it's making it so that the freezing front is stuck:

Before digging into that, I should make sure we get the first result with the oversmoothed interface. Also note that, for the old Phaseflow result, not as much work was put into setting up the example with physically relevant parameters. While the movement of the interface is qualitatively wrong for the latest FemPy result, the magnitude of the concentration at the solidification front is about right.

The current model should be valid so long as there is no supercooling.

Superseded by #75


Add a command to simplify setting up and maintenance of authentication for automation services

Automate the creation and maintenance of service accounts for the use in application, scripts, etc. to enable them to communicate with Kubernetes API in workload clusters.
The process of setting up a service account and use it to authenticate an automation service (script, application, ...) consists of several steps, all of which need to be taken manually. The process is documented here: https://docs.giantswarm.io/advanced/workload-cluster-api-access-for-automation/
To simplify the process and make it more user friendly, in can be implemented as ome or more commands (e.g. in kubectl gs), which would automate as many tasks related to creating and setting up service account setup and maintenance as possible:

creation of service accounts
creation of kubeconfigs
rotation of SA tokens

Possible concerns:

It should be implemented as a new command, not added to an existing command like e.g. kubectl gs login
The user should be authenticated
In case the process is simplified, it may be tempting to (ab)use it for user authentication, too. We need to find a way to prevent that (e.g. by restricting permissions, etc.)

Ownership of kgs is with Honeybadger, so I'm moving this issue there for consideration. I'll keep it on the Shield board as well in this case because IF we were to change any auth behavior (which isn't currently planned) then kgs would need to follow and we would make adaptations there.


Add golang lint ci

Add golangci config file and github action for it.
/assign

@liangyuanpeng from the Refinement meeting, assigning @coreydaley as well.


RCTVideo is not fabric compatible yet.

Bug
Platform

Android

Environment info
System:
OS: macOS 13.0
CPU: (8) arm64 Apple M1
Memory: 77.16 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.19.1 - ~/.nvm/versions/node/v16.19.1/bin/node
Yarn: 1.22.19 - ~/.yarn/bin/yarn
npm: 8.19.3 - ~/.nvm/versions/node/v16.19.1/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.1, iOS 16.1, macOS 13.0, tvOS 16.1, watchOS 9.1
Android SDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9477386
Xcode: 14.1/14B47b - /usr/bin/xcodebuild
Languages:
Java: 11.0.11 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.2.0 => 18.2.0
react-native: 0.71.3 => 0.71.3
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Library version: 6.0.0-alpha.6
RCTVideo is not fabric compatible yet

duplicate of: https://github.com/react-native-video/react-native-video/issues/2650

solution?


ZMAI-90 v1: ¿Status?

Hi, I have a couple of questions:
Is it possible to know the status of the switch?
Is it possible to act on it from HA or from webserver?
The supply has been cut and when the switch returns to the zmai it stays off, having to manually press the button to return the supply, so I wonder if you can see that information.

As far I know it is a know problem of this device. If you turn off the switch, it will completely turn off the power, including device itself and no way to turn it on because it is offline. If I am not right and you could suggest a solution I'm will try to implement it.
Personally, I only use v2 as an energy meter in and don't even publish the switch to HA.

The problem is that if the "switch" was published in ESP, when the power is cut and returns to the second I could from HA switch the switch to ON and let the power pass to the rest of the house, as both HA and the AP are protected with a UPS that holds on about 12 minutes, plenty of time if it is a temporary cut.

Are you trying to say that the switch is always stay off after the main power is on back?

Yes, just this.

I added the restore_mode parameter to the main switch.

It Work!!
Is possible to view status in webservice?

sorry, i do not understand again :( status of the switch - it is switch itself. If you need additional sensor based on switch status you could create binary_sensor template and link it with the main switch.

Thanks!


Update new-affidavit-test.yml

added a drop down menu for highest level of education completed, included a checking and savings account screen and a loop asking if user would like to disclose additional accounts.


Compiled hex files if possible

I was wondering if you could release a precompiled hex. I havent had any luck with geting Kali to compile it right with out errors it seems as if it might be easier to flash the hex with st32 flashing utilty. Thanks if you can

There already is a precompiled hex - it's in firmware-multimeter/objects/OL_DVM_v14.hex (the version number is wrong, it's 1.5).
Hope this helps.


DFS: (Connected Cell in a Grid)

Problem Link
https://www.hackerrank.com/challenges/ctci-connected-cell-in-a-grid/problem?h_l=interview&playlist_slugs[]=interview-preparation-kit&playlist_slugs[]=graphs
Coding platform
Hackerrank
Programming language

[ ] C
[ ] C++
[ ] Java
[ ] Python

Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.

Please review this issue. I would like to solve this in C++ :)

Hey @Nivedita967 , Please assign me in Java .

@Nivedita967 Please assign it to me in C.

@Sloth-Panda Are you working?


RFC: export experiments

Experiments are currently retained for up to 120 days https://console.aws.amazon.com/servicequotas/home/services/fis/quotas/L-9D601129 is it worth adding a section on how to persist the results of experiments somewhere else, e.g. in version control?
It is possible to export experiments using
aws fis list-experiments
aws fis get-experiment --id ...

As far as I can tell saving this currently provides the following benefits from an auditing perspective:

the time and date the experiment ran
success/fail results for each step and the overall experiment in state sections
an abridged version of the actual content of the experiment template used, as opposed to the current content if anyone updated or deleted it since then.

Notable it does NOT save description or tags from the experiment template.

I think this and #17 are similar, or by solving the documentation part you'll be solving this as well.


Nancy

Motivation and Context

Description

Contribution Checklist

[ ] I have built and tested the code locally and in a deployed app
[ ] For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
[ ] This is a change for all users of this app. No code or asset is specific to my use case or my organization.
[ ] I didn't break any existing functionality :smile:

Closing since this appears to be an unintentional PR


Parameters for putting are not working

When i try to put cookie with CookieOptionArgs like this:
`
let token: string = 'blahblahblah';
let cookieConfig: CookieOptionsArgs = {
path: null,
domain: null,
expires: null,
secure: true
};
cookieService.put('accessToken', token, cookieConfig);;
`
the function doesn't work (the cookie is not added) but without providing optional parameters the function works perfectly fine.

I met the same problem

Actually it is working as expected :).  For example, try with this:
let key = 'testCookieKey';
let value = 'testCookieValue';
let opts: CookieOptionsArgs = {
  expires: new Date('2030-07-19')
};
cookieService.put(key, value, opts);

I have the same issue, without optional its working.


adding longtail and selectAccount to OPTIONS

this way it's passed to Plaid.create()

LGTM. Thanks @drewnichols!


Stop instantiating character ranges

Part of #81.

Fsm no longer tolerates missing states or transitions - every state, including an "oblivion" state if desired, must be explicitly part of the set of states provided, and every transition must also be provided. It no longer raises OblivionErrors or tolerates ANYTHING_ELSE. This was done to make the rest of this logic less agonisingly painful.
Fsm now requires that states always be integers and that its alphabet consist of Charclasses - it no longer tolerates strings or other values as symbols. This had some ramifications for testing. Note that this rules out ANYTHING_ELSE as a possible symbol - ANYTHING_ELSE has been removed entirely. Fsm is no longer intended to serve any generic finite state machine functionality and is instead specifically dedicated to handling strings for regular expressions.
To support this, the dependency between Fsm and Charclass has been inverted. Previously, Charclass had a to_fsm method. Now, Fsm has a from_charclass static function.
Note that the methods Fsm.derive, Fsm.accepts and Fsm.strings still accept/return strings (Python values of type str), not sequences of Charclasses.
Fsm now additionally requires that its alphabet of Charclasses fully partition the space of all possible Unicode characters. This means that instead of ANYTHING_ELSE, it requires some kind of negated Charclass. A sample alphabet is (Charclass("a"), Charclass("b"), ~Charclass("ab")).
Because every Fsm essentially has the same "alphabet", we no longer need to gather or unify the set of all in-use characters from regular expression elements when constructing those Fsms. All of those alphabet() methods are now gone.
This also means constructors epsilon(alphabet) and null(alphabet) can simply become constants EPSILON and NULL.
Replacing this, we have a sophisticated new Charclass function, repartition, for rewriting those alphabets of Charclasses, and Fsm has a new method replace_alphabet - this is used during manipulations in order to unify alphabets among disparate Fsms and make it possible to combine them with relative ease.

All of the above makes it possible for an Fsm over a relatively large collection of characters to do so by making use of only a relatively small collection of individual Charclass symbols. For example, [\t\n\r -\uD7FF\uE000-\uFFFD\U00010000-\U0010FFFF] is now a single symbol, and an Fsm making use of it will have a single transition for that symbol.
So far so good. All of that paves the way for the next part:

Charclass no longer stores a collection of characters. Instead it stores a list of "ord ranges", which are inclusive ranges of Unicode character numbers. Charclass("abce"), for example, stores ((97, 99), (101, 101)). Some sophisticated, moderately efficient methods negate and add_ord_range have been added to make it possible to sanely manage large collections of these ranges, maintaining their sequence, merging or separating them when appropriate.
Due to this, stringification of Charclass is much simplified.
Parsing of Charclasses is also modified slightly.
We no longer directly reference charclass.chars or charclass.ord_ranges - instead we use new helper methods get_chars, num_chars and accepts to determine what the Charclass has inside of it.
Yes, negations inside of negations like [1a\\D] do still work.

All of this in turn means that a Charclass like [\t\n\r -\uD7FF\uE000-\uFFFD\U00010000-\U0010FFFF] no longer instantiates a chars collection with over 1,000,000 individual characters in it. Instead it maintains just a few ranges internally, and it can be combined with other Charclasses relatively efficiently.
This was a total nightmare taking multiple solid days of work. I decided there was no way to do this piecemeal, it had to be done all in one shot. I'm likely to spend a little while longer looking over this code to see if it can be improved, and I expect folks might want to lint it a little. There may be lingering performance hangups for these nasty cases, but I tackled all the obvious stuff.
The public API of greenery is unchanged. This is essentially a performance uplift.

Future work: it might be possible to simply eliminate the concept of a "negated character class". Instead of ~Charclass("a"), which internally stores ord_ranges of ((97, 97),) and a self.negated flag, we could internally store ord_ranges of ((0, 96), (98, 1114111)) and scrap the flag. This could potentially simplify a great deal of logic.


fdk-aac-encoder: apply patch for CVE-2022-37781

Description of changes
See upstream issue (a POC is included): https://github.com/nu774/fdkaac/issues/54

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

fdk-aac-encoder
soundconverter

</details

Can you add a comment describing the purpose of the patch and stating that it should be removed when v1.0.4 is released?

Done but I'm not sure if it is really helpful. The name of patch tells why it is included and with the next upgrade we might need to check if the patch is still needed or not if it does not show as already applied.

I think it's useful to have all the context in the file itself. LGTM now, thanks for the patch!


Priority correction of html used in __authz endpoint.

Now: Property setting of Cell -> Personium default
Future: Property setting of Cell -> Unit default -> Personium default

Note
The current is as follows.

Get URI page set in Cell or URI set in Unit
If the above can not be obtained, it will be the default page.

I would like to do the following in the future.

Get URI page set in Cell
If the above is not set or the page can not be obtained, get the default URI set in Unit.
If the above is not set or the page can not be obtained, it will be the default page.

When the page is set to both Cell and Unit and the page set to Cell can not be acquired due to incorrect value etc, the default page is displayed without referring to the page of Unit.
It seems that it is thought that you should refer to the page of Unit about this movement.


Reduce memory copy in "afterRender" event

Since $output parameter is already a reference, we could assign to ViewEvent::$output property directly with the reference of $output parameter. Then we can reduce some memory.
I found it when my $event->output is very large, the memory usage is wired with this line: $output = $event->output;, it does some unnecessary memory copy.

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Tests pass?
✔

Fixed issues

There could be an event which processes the output, would this still be applied?

@schmunk42 good question. I think it won't be.

@schmunk42 is right. Handler may modify output.

Do we have a test for it?

@schmunk42
I did some tests with my project, the output is the same as before, but allocate less memory.
@samdark
I didn't find any test for testing the "afterRender" method. I checked [ViewTest.php] (https://github.com/yiisoft/yii2/blob/ab1c653fb788383c4b8b628bc1f0021b06316427/tests/framework/base/ViewTest.php) file, there is no test either. I can add a test for testing the "afterRender" method.

@LeoOnTheEarth Do you have output filter?
I think we need a test for it.

i think better solution is
$event = Yii::createObject(['class' => ViewEvent::className(), 'viewFile' => $viewFile, 'params' => $params]);
$event->output =& $output;
$this->trigger(self::EVENT_AFTER_RENDER, $event);

because reference to array element not copy to object property.

After added the test, I found the reference problem. The first implement cannot modify $output in EVENT_AFTER_RENDER events.
I update my changes. Thanks.

Please add a line for changelog.

Please add a line for changelog.

I added a changelog.
Should I modify the commit logs? There is a commit log that is not related to this PR.

Should I modify the commit logs? There is a commit log that is not related to this PR.

No, it's fine.

Thanks!


Mast: Watch bigseobazar.com

Mast requests the watch of the watch_keyword bigseobazar\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

bigseobazar\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Rejected by Daniil in Charcoal HQ. Reason: 'The domain in question has 0 hits on Metasmoke, I questioned the author of the PR (Mast) asking them why they wanted to watch the domain but haven't received a reply after waiting a reasonable amount of time as they are also unsure.'


Definitely Do Not Merge

Fail every visual-diff test.

Fixed officially in https://github.com/BrightspaceUI/core/pull/2709 and https://github.com/BrightspaceUI/core/pull/2714


Documentation unclear for TextSpan::{start,end}

The documentation says this for usvg::TextSpan::start and end

A span start in UTF-8 codepoints.

But if I'm not mistaken these seem to be byte offsets into the string, not lengths in unicode code points. Maybe the wording should be simply "A span start in bytes", or "Byte offset to the start of the span, relative to the parent text chunk"?

In case of UTF-8, byte offset == UTF-8 codepoint. By I guess using bytes would be more obvious. Will update the docs.


Open local server docx file via url

I'm a novice. Could you please show the code to open the docx file on the local server through the url? Thank you very much!

Like this:
http://<IP_ADDRESS>/docxjs/index.html?file=http://<IP_ADDRESS>/test.docx

Like this:
http://<IP_ADDRESS>/docxjs/index.html?file=http://<IP_ADDRESS>/test.docx

Please use stack overflow for such questions


attribution attribute

Probably required for dowscaling CC BY 4.0 data (CMIP6, ERA5)
{
    "attribution": "CORDEX model data is based on downscaling <driving_source_id> driving data produced by <driving_institution_id> using the regional model <source_id>. The driving data is licensed under a Creative Commons Attribution 4.0 International License (https://creativecommons.org/licenses)."
}

I think this pretty much sums it up for CMIP6:

should be checked with experts

Hi folks, the CC BY 4.0 relaxation (from CC BY-SA 4.0) means that the ShareAlike clause no longer applies to any of the CMIP6 contributing models - see CMIP6_source_id_licenses.html. So with the CC BY 4.0 and CC0` being the only licenses that are associated with CMIP6 output, clause 2 above doesn't apply. By "attribution", I believe this is satisfied if you cite the source data, so for e.g. the DOE E3SM-1-1 historical experiment can be identified by the citation/DOI https://doi.org/10.22033/ESGF/CMIP6.11485

@durack1 Thanks! Yes, i just realized the relaxation yesterday! So according to this:

we are free to choose from any CC licenses including non-commercial (NC). We have a few institutions that might require that. However, i think we should encourage CC BY 4.0 also for CORDEX.

My recommendation, through our CMIP6 learning is that you want to make the licenses as relaxed as possible from the outset, otherwise you'll also have to go through the after-the-fact relaxation, which is a total pain, and more work than you think. For e.g. if you went a CC0, that would mean that ANYTHING could be done with the data, but there is no responsibility to CORDEX or the data providers after the fact

Yes, i agree, thanks for sharing your experiences here. This has really been helpful to tackle my understanding of license issues!


Laravel 5.0

This is a running list of items that need to be addressed for the upcoming Laravel 5.0 release

Create Table Command should autodetect, and/or give the option of where to place the migration file

done


Can't view File Share via Storage Explorer | Error

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.23
Regression From
No response
Architecture
x64
Storage Explorer Build Number
20220223.14
Platform
Windows
OS Version
Windows 11 21H2
Bug Description
Untergeordnete Ressourcen können nicht abgerufen werden.
Details:
{
"name": "FetchError",
"message": "request to https://azzvfile01.file.core.windows.net/?comp=list failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443",
"stack": "FetchError: request to https://azzvfile01.file.core.windows.net/?comp=list failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443\n    at ClientRequest. (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-file-extension\dist\src\index.js:2:107389)\n    at ClientRequest.emit (node:events:394:28)\n    at TLSSocket.socketErrorListener (node:_http_client:447:9)\n    at TLSSocket.emit (node:events:394:28)\n    at emitErrorNT (node:internal/streams/destroy:157:8)\n    at emitErrorCloseNT (node:internal/streams/destroy:122:3)\n    at processTicksAndRejections (node:internal/process/task_queues:83:21)",
"type": "system",
"errno": "ETIMEDOUT",
"code": "ETIMEDOUT"
}
Steps to Reproduce

Launch Explorer
Open Storage Accoun (File Share)
Try to open Folder

Actual Experience
I'm getting the error:
Untergeordnete Ressourcen können nicht abgerufen werden.
Details:
{
"name": "FetchError",
"message": "request to https://azzvfile01.file.core.windows.net/?comp=list failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443",
"stack": "FetchError: request to https://azzvfile01.file.core.windows.net/?comp=list failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443\n    at ClientRequest. (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-file-extension\dist\src\index.js:2:107389)\n    at ClientRequest.emit (node:events:394:28)\n    at TLSSocket.socketErrorListener (node:_http_client:447:9)\n    at TLSSocket.emit (node:events:394:28)\n    at emitErrorNT (node:internal/streams/destroy:157:8)\n    at emitErrorCloseNT (node:internal/streams/destroy:122:3)\n    at processTicksAndRejections (node:internal/process/task_queues:83:21)",
"type": "system",
"errno": "ETIMEDOUT",
"code": "ETIMEDOUT"
}
Expected Experience
Should open Files.
Additional Context
No response

Hi @MRayermannMSFT ,
it is already working again, I think it was a BUG of Azure.
Thanks and greets


Help With My Token

Does anyone know where i would put my token to have the bot run? ive looked through most of the files and have yet to find where

Hello, I'm not a .js developer
I think you should make on file called Auth.js in the main directory and put this syntax as given below
module.exports = {
discordToken: 'Discord bot token',
youtube: 'Youtube API key',
trelloKey: 'Trello API key',
trelloToken: 'Trello API token',
dbPass: 'Database password',
};

source: Issue#10


lotus wallet list not working

Describe the bug
No response from JSON-RPC API when attempting to list wallets via lotus. No errors in forest log.
To Reproduce
Steps to reproduce the behavior:

make install
forest (be sure to copy the Admin token printed after the keystore is initialized
Replace the token in this command, and create a new wallet like so: FULLNODE_API_INFO="eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJBbGxvdyI6WyJyZWFkIiwid3JpdGUiLCJzaWduIiwiYWRtaW4iXX0.6stmBuYIVFCGPMnhFI7U1hNXcjPKUZTF4cTBQazD4gM:/ip4/<IP_ADDRESS>/tcp/1234/http" lotus wallet new
Attempt to list wallets via: FULLNODE_API_INFO="eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJBbGxvdyI6WyJyZWFkIiwid3JpdGUiLCJzaWduIiwiYWRtaW4iXX0.6stmBuYIVFCGPMnhFI7U1hNXcjPKUZTF4cTBQazD4gM:/ip4/<IP_ADDRESS>/tcp/1234/http" lotus wallet list
Wait roughly 30 seconds, lotus hangs, and then exits.

Expected behaviour
Expected to see a wallet list.
Environment (please complete the following information):

OS: I run Arch, btw
Rust version: 1.53.0-x86_64-unknown-linux-gnu
Branch/commit: main, 3771568cc9f1a9ecab8089aef8a7c9258056ea63

Screenshot:

Lotus compatibility is no longer guaranteed. Closing.


Feature: TAA (Temporal anti-aliasing)

This version of AA remains to give the smoothest result (especially when moving) by far in my opinion, so I was wondering, is this a Post-process effect that we can add?
Three.js has it's own implementation here: https://threejs.org/examples/webgl_postprocessing_taa.html.
It also has been talked about before on the HTML5gamedevs forum: https://www.html5gamedevs.com/topic/28727-subpixel-rendering/ where someone was able to implement it with BabylonJS in a commercial product.
What I can see from the Three.js example is that it uses features from SSAA, and I've read it's pretty much one of the more complicated AA techniques out there. So I'm wondering, has this been thought of before but that it's not something easy to add?

Hey, as mentioned in the github issue template, please go to the forum first to discuss about features.
We are only capturing validated requests here

@deltakosh My bad, I will most certainly do that. I do think that You must provide a link to the forum post where the initial discussion happened feels a bit optional to me, something like along the lines of We only accept feature requests that are discussed on the BabylonJS forum might help more for bad readers like me :)

Well "You must provide a link" seems like you must :D

That being said let me use your wording now :)


Issue in the  DNN-FM.ipynb

NameError: name 'find_de1' is not defined

find_de1 can be replaced with find_de (function to find differential entropy)


Smart re-try for operations

If an operation immediately receives an error indicating a closed socket (common with Amazon ELB), re-try it at least once no matter the global retry settings. This will also be done for streaming operations that are normally not retried at all, since it is safe to re-try in this specific case.
Fixes #503 (CLIENTS-1049)

Code looks good and tests pass. Do we have tests that confirm connections are closed?

Do we have tests that confirm connections are closed?

Not sure why we would need that? For this change the only way to test it is to use haproxy with really short timeouts https://gist.github.com/lukebakken/81c0609c274b083272f182443a6267f5


ZCL_ABAPGIT_PERSIST_INJECTOR and ZCL_ABAPGIT_INJECTOR is not in zabapgit.abap

Folllwoing classes is not included in zabapgit.abap

ZCL_ABAPGIT_PERSIST_INJECTOR

ZCL_ABAPGIT_INJECTOR

all classes "FOR TESTING" are skipped by abapmerge, https://github.com/larshp/abapmerge
do you need them in the report?

all classes "FOR TESTING" are skipped by abapmerge, https://github.com/larshp/abapmerge
do you need them in the report?

They are needed as called in the actual version. So you can't activate, error "Type "ZCL_ABAPGIT_PERSIST_INJECTOR" is unknown", line 9574
CLASS zcl_abapgit_persist_factory DEFINITION   CREATE PRIVATE   FRIENDS ZCL_ABAPGIT_persist_injector .

thanks, try again, latest version

thanks, try again, latest version

Working again, thanks!

cool 👍
Todo:

abapmerge 0.14.0 must be changed to handle the global FOR TESTING classes different
abaplint should report error for the compiled report, opened https://github.com/abaplint/abaplint/issues/899

closing, root cause will be solved by https://github.com/larshp/abapmerge/issues/102 and https://github.com/abaplint/abaplint/issues/899


Discrepancies with Analyzer during compilation

We have a class called MultiToken and another called ExistingProvider:
https://github.com/dart-lang/angular/blob/1abcb5c62fc8a8267f1abdb2081d07f40567c56f/angular/lib/src/core/di/opaque_token.dart#L62-L74
https://github.com/dart-lang/angular/blob/1abcb5c62fc8a8267f1abdb2081d07f40567c56f/angular/lib/src/di/providers.dart#L241-L265
This pattern was created in order to correctly "infer" what the type of a given DI provider should be, but also not require manual type annotations (use flowing type inference from OpaqueToken<T> -> ExistingProvider<T> -> Provider<T> (T):
const NG_VALUE_ACCESSOR = const MultiToken<ControlValueAccessor>(
  'NgValueAccessor',
);

const DEFAULT_VALUE_ACCESSOR = const ExistingProvider.forToken(
  NG_VALUE_ACCESSOR,
  DefaultValueAccessor,
);

When analyzing this during our compilation, T of DEFAULT_VALUE_ACCESSOR is dynamic internally (with bazel_codegen) and (correctly) ControlValueAccessor externally (with build_runner). This is causing our sync to fail on travis:
https://api.travis-ci.org/v3/job/342583283/log.txt
If I manually type (don't rely on inference), it works as intended in both places:
const DEFAULT_VALUE_ACCESSOR = const ExistingProvider<ControlValueAccessor>.forToken(
  NG_VALUE_ACCESSOR,
  DefaultValueAccessor,
);

It's also possible this is due to different analyzer versions/configuration? I know top-level inference is inconsistent without using Dart 2 semantics, but I'm very confused why this works properly externally but not internally.
/cc @natebosch @scheglov @alorenzen

Both places are using an AnalysisContext. Both places set strongMode to true and no other analysis options. (bazel, build_runner)
In bazel we use summaries for files outside the current package, in build_runner we always read Dart sources, never summaries.

Interestingly enough, this worked internally a while back :-/

Could be a regression in the AnalysisContext in that case - I think we're likely getting older versions of the analyzer package externally than what is rolled internally. If you can build a test case you might want to see if you can try against older versions of analyzer internally.

For folks reading this thread:
INTERNALLY = 0.31.2-alpha.0
EXTERNALLY = ^0.31.0+1

@MichaelRFairhurst:

My understanding was that top levels don't have inference, they get implicit dynamic. It seems like for const values we do some kind of inference, though...

Yeah, it works as of 0.31.0+1 for this limited case. If I'm relying on something "bad", let me know, but my assumption is that it should continue to work indefinitely.
If you need a better reproduction case, I'm happy to write one.

Its my understanding that this does not have any inference...const ExistingProvider.forToken(...) but rather gets implicit dynamic...I think that's the problem

@MichaelRFairhurst:
Its a little hard to see here, but the failing travis sees it:
https://api.travis-ci.org/v3/job/342583283/log.txt
     Which: is different.
            Expected: ... ;\n  List<dynamic> _ ...
              Actual: ... ;\n  List<import15.C ...
                                    ^
             Differ at offset 8427
  ./build/test/_files/directives/directive_wrapper.template_debug.golden is out of date. See ./build/test/_files/directives/directive_wrapper.template_debug.check.

i.e. externally, we read this provider as T=ControlValueAccessor, but internally it is read as T=dynamic. We obviously want the former.

In order to avoid this blocking the sync, I'll add a work-around for now @alorenzen.

This should almost certainly be inferred.  We do toplevel inference, and this looks like a straightforward example of something we should catch, unless I'm missing something.  There are a lot of known bugs and unimplemented bits in the analyzer (since it was intended to only be implemented in the new front end), but we certainly shouldn't be regressing here.
Unfortunately this is sometimes very sensitive to multiple files and analysis order, but if there's any way you can get a small repro that would be great.  Also, file an issue in the sdk if you haven't already.

@leafpetersen I tried implementing the simplest repro possible:
import 'provider.dart';
import 'token.dart';

const tokenOfString = const Token<String>();
const implicitProviderOfString = const Provider(tokenOfString);
const explicitProviderOfString = const Provider<String>(tokenOfString);

@TestOn('vm')
import 'package:analyzer/dart/constant/value.dart';
import 'package:build/build.dart';
import 'package:build_test/build_test.dart';
import 'package:test/test.dart';

void main() {
  final asset = new AssetId('top_level_analyzer', 'lib/library.dart');

  DartObject explicitProviderOfString;
  DartObject implicitProviderOfString;

  setUpAll(() async {
    final library = await resolveAsset(asset, (r) => r.libraryFor(asset));
    final fields = library.definingCompilationUnit.topLevelVariables;;
    explicitProviderOfString = fields[1].computeConstantValue();
    implicitProviderOfString = fields[2].computeConstantValue();
  });

  test('should resolve explicitProviderOfString', () async {
    expect(explicitProviderOfString.type.toString(), 'Provider<String>');
  });

  test('should resolve implicitProviderOfString', () async {
    expect(implicitProviderOfString.type.toString(), 'Provider<String>');
  });
}

... and this works externally, just fine, with both:

analyzer: 0.31.1
analyzer: 0.31.2-alpha.0

... so now I'm thinking its related to summaries (Bazel uses). I'll try and write the same test internally and see if I get different results tomorrow, I hope I can figure something out.

@stereotype441 took a look at this.
I'm going to port the above test internally, where it fails, and then share with the team to see if we can make some progress. Update a little later today.

From what I can tell... this works fine internally, too.
It's likely something very subtle and not directly related to the analyzer, or build, but I really appreciate everyone looking at this and trying to help diagnose the problem(s). I'll ping again if I have a fix or further questions.

I'm closing this, as we are just landing a workaround instead.

Re-opening. Even with the workaround... sometimes it doesn't work :-/

This test fails internally when DDC enforces type checks for List:
https://github.com/dart-lang/angular/blob/master/_tests/test/core/linker/deferred_component_ngmodel_test.dart
... it shouldn't.

I believe the underlying cause is https://github.com/dart-lang/sdk/issues/32290.

Wow! Thanks @stereotype441!
I think I can add a workaround, again, until we have a fix.


Assign a generic function to property in class

Dart VM version: 2.0.0-dev.69.2 (Mon Jul 23 17:10:56 2018 +0200) on "macos_x64"

Type id<Type>(Type a) => a;

typedef FunctionType<T> = T Function(T);

class FunctionWrapper<T> {
  FunctionWrapper({
    this.func = id,
  });

  FunctionType<T> func;
}

main() {
  final f = FunctionWrapper<int>();
  print(f.func(0));
}

Causes a runtime error:
Unhandled exception:
type '(T) => T' is not a subtype of type '(int) => int'
#0      main (file:///Users/means88/code/test/function.dart)
#1      _startIsolate.<anonymous closure> (dart:isolate/runtime/libisolate_patch.dart:279:19)
#2      _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:165:12)

Maybe an error should be thrown during the static checking if it was not supported.

Clearly there's a bug in the reported behavior, and I think I've seen a relevant github issue. But I'm not working directly on these things and I can't find such an issue right now, so I'll leave it to others to pin that down.
However, one issue which is evident is that you don't get a compile-time error on = id, but you should.
The problem is that id has type X Function<X>(X), but an attempt is made to use it to initialize an instance variable func of type T Function(T) (where T denotes the type variable of the enclosing class). There is no subtype relationship between those two function types, so this would just be a compile-time error in general.
However, Dart has a special mechanism addressing exactly this kind of type mismatch: Generic function instantiation. This is a mechanism where type inference is used to compute some actual type arguments to the generic function type (such that the resulting non-generic function type is assignable to the context type, here: the type of func).
So we could have had a regular assignment in the body of the constructor like func = id, and that would "just work", assigning an instantiation of the generic function id to func which has already received its type argument and become a function of type T Function(T).
However, again, that is a dynamic operation (because the value of T differs according to the execution history), and this means that it cannot be a compile-time constant. More precisely, an occurrence of id which is subject to generic function instantiation involving a type variable from the enclosing class is not a constant expression. Consequently, it is a compile-time error to use it as a default value (in the given example, it is the default value for a named parameter).
This error is not reported, so I'm marking this as a bug in the common front end.
However, the fact that it runs and reports an error mentioning a type which contains a free type variable rather than its value would be another bug, and it might be better to create a separate issue for that (but that's the part that I'm leaving to someone else to handle ;-).

unfortunately this still happens
https://dartpad.dartlang.org/bf386455c236384861927f40101bbfda


Improvements/#269 nccl optimization

Issue #, if available:
#269
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looks almost ready. Just need the section on DL AMI NCCL test usage.

@sean-smith please review

@sean-smith anything else?

Yes.


Add bambulab to latest

Please add my adapter ioBroker.bambulab to latest.
This pull request was created by https://www.iobroker.dev c0726ff.

First of all - THANK YOU for the time and effort you spend to maintain this adapter.
I would like to give some (preliminary) feedback based on my personal oppinion. This is NOT an offical review and @Apollon77 might have several additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him (or wait for a response from him) if you cannot follow my suggestsions or before you spend major effort.

[ ] sensitive information, especially passwords should be stored encrypted
You configuration seems to contain passwords (or other sensitive information) which is not stored encrypted. As long as those information is not stored inside a table you can encrypt and secure this infomation simply by adding the following configuration to io-package.json. The iob runtime will encrypt / decrypt the data as required; no addition programming effort is required. Note that users will need to reenter this info one time after adding encryption, so drop a note at release notes.
"encryptedNative": [
  "password",
  "data2"
],
"protectedNative": [
  "password",
  "data2"
],

You use encryptedNative but not protectedNative. I just want to note it; if its not on purpose consider adding it.

[ ] review writeable states (button states)
If noticed that at 'controlStates' the buttons 'chamberLight' and 'start' have an attribut 'write:true' while 'stop' and 'resume' do not have it. This looks inconsistent but might be OK depending on other code or your goals. So take it as info only.

[ ] reevaluate state roles
Only the values specified here (https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md) may be used as state roles. Do not invent new names as this might disturb the functionalyity of other adapters or vis.
In addition the roles MUST match the read/write functionality. As an example a role value.* requires that the state is a readable state. Input states (write only) should have roles like level.*. Please read the description carefully.
For your adapter I want to note especially:

button.resume is not (yet ?) listed there. It might be a good idea to request an addition befor using it (eventually discuss with Apollon77 / bluefox directly)
I did not install the adapter, but check if button states have read=false attribute set. Looks like you do not specify read and I think read defaults to true - but not sure for this.

[ ] some labels seem to have no translation into all languages
It seems that some labels are not translated into all supported languages, i.e. de/translations.json
Please consider adding missing translations

{
	"bambulab adapter settings": "Adaptereinstellungen für bambulab",
	"option1": "Option 1",
	"option2": "Option 2"
}

[ ] consider using adapter.setTimeout / this.setTimeout instead of (standard) setTimeout
The adapter package provides wrapper routines for native setTimeout, setInterval, clearTimeout and clearInterval. Using those routines ensures that timers are cancelled on on load. Additional checks on thomse limits might be performed, too. So consider replacing native setTimeout/clearTimeout by adapter.setTimeout/adapter.clearTimeout or this.setTimeout/this.clearTimeout. The same refers to setInterval/clearInterval.

[ ] check and limit configurable timeouts / intervals
Node setTimeout/setInterval routines have a maximum allowed value of 2,147,483,647 ms. Using delays larger than 2,147,483,647 ms (about 24.8 days) result in the timeout being executed immediately. So all (user configurable) values passed to setTimeout / setInterval should be checked and limited.

[ ] check and adapt testing
Standard iobroker testing is required but seems to be missing. Please add and setup ./gizthub/workflows/test-and-release.yml

[ ] adapt testing to supported node releases
Consider adding node 20 tests unless you already know incompatibilities.
So the recommended testmatrix is [16.x, 18.x, 20.x],

Thanks for reading and evalutaing this suggestions.
McM1957

First of all - THANK YOU for the time and effort you spend to maintain this adapter.

Thank you for your swift and constrictive review :)!

I would like to give some (preliminary) feedback based on my personal oppinion. This is NOT an offical review and @Apollon77 might have several additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him (or wait for a response from him) if you cannot follow my suggestsions or before you spend major effort.

appreciated!

[x]  sensitive information, especially passwords should be stored encrypted
You use encryptedNative but not protectedNative. I just want to note it; if its not on purpose consider adding it.

Thank you, solved
https://github.com/DrozmotiX/ioBroker.bambulab/commit/5a3a619650b585d0245a0f5aa584ecac3b06974e

[x]  review writeable states (button states)
If noticed that at 'controlStates' the buttons 'chamberLight' and 'start' have an attribut 'write:true' while 'stop' and 'resume' do not have it. This looks inconsistent but might be OK depending on other code or your goals. So take it as info only.

Thank you, solved https://github.com/DrozmotiX/ioBroker.bambulab/commit/0fedf4e1228d67717d1c6505b28dfe0491351b54

[x]  reevaluate state roles

button.resume is not (yet ?) listed there. It might be a good idea to request an addition befor using it (eventually discuss with Apollon77 / bluefox directly)

for now I removed button.resume and looked just button. Resume make sense in generic as several controls, but mostly a combination of play/pause, know the command resume

I did not install the adapter, but check if button states have read=false attribute set. Looks like you do not specify read and I think read defaults to true - but not sure for this.

added read: true just to be sure https://github.com/DrozmotiX/ioBroker.bambulab/commit/67c8cc71accbbf9b5501d45a2b67ec2d53637345

[x]  some labels seem to have no translation into all languages

translations added  https://github.com/DrozmotiX/ioBroker.bambulab/commit/c4030ed7a4c53cfac25c2568356ac5d544b778ac

[x]  consider using adapter.setTimeout / this.setTimeout instead of (standard) setTimeout

will evaluate this new function in a later version, for now and latest release current implementation with set timeout and clear (also in unload) should be sufficient

[x]  check and limit configurable timeouts / intervals
Node setTimeout/setInterval routines have a maximum allowed value of 2,147,483,647 ms. Using delays larger than

timeout has a fixed value and is ensured to be cleaned before fun
				if (timeout) {clearTimeout(timeout); timeout = null;}
				timeout = setTimeout(async function () {
					client.reconnect();
				},

[x]  check and adapt testing
Standard iobroker testing is required but seems to be missing. Please add and setup ./gizthub/workflows/test-and-release.yml

workflow is present https://github.com/DrozmotiX/ioBroker.bambulab/blob/main/.github/workflows/test-and-release.yml

[x]  adapt testing to supported node releases
Consider adding node 20 tests unless you already know incompatibilities.
So the recommended testmatrix is [16.x, 18.x, 20.x],

testing for node 20 added https://github.com/DrozmotiX/ioBroker.bambulab/commit/e46638edd9b14ab40757a79d4bbff50b2df77ce0

Thanks for reading and evalutaing this suggestions. McM1957

thank you reviewing & al valuable feedback !

Hi and thanks for the fast response.
Sorry for some issues at the end of my review - I simply forgot to remove them from the template (i.e. limiting timout values).
BUT
start : {
	name: 'Start printing',
	type: 'boolean',
	role: 'button.start',
	read: true,
	write: true

should have set read:false according to documentation:
'common.type=boolean, common.write=true, common.read=false'
https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md#buttons-booleans-write-only
Sorry that my first statement was misleading.
If you feel, this is a documentation error, please check with @Apollon77 or othgers from core team and create a correction PR / issue at documentation.

FYI:
I've created a PR to add button.resume.
Lets wait if it will be accepted.
https://github.com/ioBroker/ioBroker.docs/pull/429

Can you please provide your feedback here ? I was in the impression the read flag should be always default true as it makes otherwise no sense you can always read a state ?

This is the usual "formal" discussion.
A Button ( "Taster" only triggers when you press but else have no state), so should also be not readable .... This is also like HomeMatic does it ... a Switch has clear states true or false and so can be read.

Can you please provide your feedback here ? I was in the impression the read flag should be always default true as it makes otherwise no sense you can always read a state ?

This is the usual "formal" discussion.
A Button ( "Taster" only triggers when you press but else have no state), so should also be not readable .... This is also like HomeMatic does it ... a Switch has clear states true or false and so can be read.

with that explanation it makes sense, I changed my lines to ensure all buttons have the read flag set to false

@DutchmanNL
This adapter has been released to latest repository and should be visible within 24h maximum.
Please create a thread at https://forum.iobroker.net/category/91/tester titled like "Test Adapter " to collect some user feedback and provide a link to this topic when requesting addition to stable repository later.
Note: If an other testing topic already exists, ist OK to continue using this topic too.

@mcm1957 thank you, forum thread already exists 😉
https://forum.iobroker.net/topic/67178/bambulab-3d-drucker-adapter?_=1692616355318

Its fully ok to keep this thread.
I only want to e nsure in future taht every dev creates a forum thread at least after going to latest so that one (i ?) can make a rough scan whether the adapter has serios problems when first going to stable. Ok, some mor work :-) - but I do not think that such a "suggestions" is not ok. I did not filter users when merging PRs today :-).


Spring unit & integration tests. Spring单元&集成测试完善

James

i want to do but how?

i want to do but how?

We should add some test cases to verify whether the verification and spring adaptation are as expected. Such as annotation, configurations...


Fixes and improvements for CompositeElementPlot

Fixes bug when using glyphs containing an underscore and allows defining an explicit draw order for glyphs.

Going ahead and merging this since it's mostly a bug fix and other work depends on it.


SUBMARINE-1305. Fix submarine-server-core test error

What is this PR for?
Currently, the test case class SubmarineAuthSimpleTest in submarine-server-core does not reset submarine.auth.type to none at the end (@After), which will cause subsequent test cases to be blocked.
What type of PR is it?
Bug Fix
Todos

[x] - Reset submarine.auth.type to none after test passed.

What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1305
How should this be tested?
Have fixed.
Screenshots (if appropriate)
No
Questions:

Do the license files need updating? No
Are there breaking changes for older versions? No
Does this need new documentation? No

@pingsutw
Hi~ After PR https://github.com/apache/submarine/pull/979 has been merged, I found that the test cases in submarine-server-core would get blocked, probably due to a problem with my legacy test case (it didn't seem to be a problem in the test submitted at the time, I suspect it was caused by PRs that were merged after the PR was raised). I have now fixed the problem and would appreciate your help in reviewing it and merging it as soon as possible so that it does not affect other PRs.


We should retitle the "JSON OUTLINE"

I've never liked that, it implies we're outlining generic JSON, but we're not.  It's especially weird now that there's an OUTLINE view:

Suggested: "TEMPLATE OUTLINE" and "TEMPLATE PARAMETERS OUTLINE"

@fiveisprime I'd like to get this in the webpack release.  Do you agree with the suggestions?

Yeah, maybe "TEMPLATE OUTLINE" makes sense or maybe "ARM TEMPLATE OUTLINE"?

Going with ARM TEMPLATE OUTLINE

Nice, looks good. 👌


Add a license

Firstly, I really appreciate the efforts of iCepa - I'm learning a lot from this code being here and the setup so well-documented. Thank you thank you thank you!
Unfortunately, none of this code can really be used for other projects in iCepa's current state since it's missing a license that would permit any kind of reuse or distribution.
I'm guessing something similar to https://git.zx2c4.com/wireguard-go/tree/README.md#n11 would work, but IANAL nor am I the author.

Done!


RDMA packet transmission

Problem
with both Vitis and Vivado HLS RDMA stack, the packet cannot be transmitted correctly. After several runs, the packages can be sent and received correctly (but the bpss_wr/rd_done signal is always zero).
TODO

[x] Check is sq is and rd/wr command is correct -- Yes: correct.
[x] Check the Tx/Rx package -- No: RDMA TX is correct, but total TX is not -- Maybe it's the MIE issue (hash table)?
[x] Check the axis_net before and after MIE, check the arp table req/reply -- Normal😂  after one day, the RDMA WR works correctly.. Does the traffic interference this??
[ ] #3

Observation and Solutions

doArpLookUp needs time to take effect (delay after ip/mac change and lookup), see this picture, the lookup_reply is 0 at the beginning

Solutions: add 1 second latency after doArpLookUp

Related issue in the driver
The ipaddr in the arpLookUp is fixed to the BASE_IP_ADDR and NODE_ID in the driver.  Therefore the driver.h should be set for each machine.

[ ]  Get flexible arpLookUp ip address in the driver

cb150bc2b7de56c15f626678bff56b98abe07727


jenkinsx-quickstart-nuxeo-poc to 1.0.21

Promote jenkinsx-quickstart-nuxeo-poc to version 1.0.21

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-x-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Precompiled DLL

Hello. Can you add to releases or give me a compiled DLL, because I can't compile it (don't ask why).

Hello,
I've uploaded the binaries:
https://github.com/JeremyAnsel/ddraw_logger/releases/latest

Thank you very much, so quickly!


[Adaptive Cards- Import- Input Form with Validation]: 'Tell us about yourself' text above the input field is not visible after resizing the screen.

https://microsoft.visualstudio.com/OS/_workitems/edit/34110137

This issue is not repro hence closing this issue.


Add dictionary with groups

It would be great to have separate list of groups. Thanks to this we will have two improvements:

icons on main page can be customizable (now there is automatically generated icon based on group title)
on project details page we can put drop down with list of groups.

Implemented.


Unexpected reserved word

await runBot();
^^^^^
SyntaxError: Unexpected reserved word
at Loader.moduleStrategy (internal/modules/esm/translators.js:88:18)
at async link (internal/modules/esm/module_job.js:41:21)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node ./src/index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/linux/.npm/_logs/2021-09-01T00_38_33_541Z-debug.log

my log
0 info it worked if it ends with ok
1 verbose cli [
1 verbose cli   '/home/linux/.nvm/versions/node/v14.4.0/bin/node',
1 verbose cli   '/home/linux/.nvm/versions/node/v14.4.0/bin/npm',
1 verbose cli   'run',
1 verbose cli   'start'
1 verbose cli ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: /home/linux/.nvm/versions/node/v14.4.0/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/linux/binance-dca-bot/node_modules/.bin:/home/linux/.nvm/versions/node/v14.4.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
9 verbose lifecycle<EMAIL_ADDRESS>CWD: /home/linux/binance-dca-bot
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'node ./src/index.js' ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec start script
13 verbose stack Error<EMAIL_ADDRESS>start: `node ./src/index.js`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/home/linux/.nvm/versions/node/v14.4.0/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:332:16)
13 verbose stack     at EventEmitter.emit (events.js:315:20)
13 verbose stack     at ChildProcess.<anonymous> (/home/linux/.nvm/versions/node/v14.4.0/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:315:20)
13 verbose stack     at maybeClose (internal/child_process.js:1051:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd /home/linux/binance-dca-bot
16 verbose Linux 5.11.0-27-generic
17 verbose argv "/home/linux/.nvm/versions/node/v14.4.0/bin/node" "/home/linux/.nvm/versions/node/v14.4.0/bin/npm" "run" "start"
18 verbose node v14.4.0
19 verbose npm  v6.14.5
20 error code ELIFECYCLE
21 error errno 1
22 error<EMAIL_ADDRESS>start: `node ./src/index.js`
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>start script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

Could   you help me ?
Thanks

Duplicate of issue #6

you close it but its not exactly the same issue .... i have v14.4.0 installed ... any suggestion ?

you close it but its not exactly the same issue .... i have v14.4.0 installed ... any suggestion ?

Sorry it seems that node version is not compatible either. I will look into transpiling into es5 so older versions of node work. In the meantime please try v14.17.6 and that should work.

Working with v14.17.6 !! Thanks


NOJIRA Provide an alternative way to determine widget editability

NOJIRA Provide an alternative way to determine if a user can edit a widget based on it's container, when there is no widget data to draw from

@croby: Can you create a JIRA for this and explain why/when we'd want to use this?

@nicolaasmatthijs Sure thing, forthcoming

@croby: thx!

https://jira.sakaiproject.org/browse/SAKIII-4173


Revamp the presentation of 'Status'

Currently there is no visual indication as to whether code is compiling or not. Previous plan was to eventually show this in the file Header. Now I think the opposite.

Leave parse status in the header (because it is useful - for now in tests) but hide it from user with CSS
Add separate status properties on the File frame for:

ParseStatus - as now
CompileStatus - pending [parse being valid], OK, error
TestStatus - pending [compile OK], passed, failed
RunStatus - running, paused, stopped, error

Display these outside the code area
The four status values are a progression. Each is displayed only if the previous one is green.
Parse:  invalid / incomplete / valid
Compile:  fail / OK
Tests:  failed / passed
Run: running (green) / paused (amber) / error (red)

Could be positioned vertically (alongside the Graphics pane ?) and showing only the colour (no word)
Parse:
Compile:
Tests: [background colour if no tests]
Run: [background colour until run]
Run, Pause, Stop buttons are enabled / disabled according to status
A run error remains as red until either run again, or any change to code - which resets it to background.

Largely done, and the rest now superseded by #368


Tmux pane is closed when executing whatever command after sourcing .zshrc

             `ooo/                 OS: Arch Linux
            `+oooo:                Kernel: x86_64 Linux 4.7.1-1-ARCH
           `+oooooo:               Uptime: 3h 38m
           -+oooooo+:              Packages: 531
         `/:-:++oooo+:             Shell: zsh 5.2
        `/++++/+++++++:            Resolution: 1920x1080
       `/++++++++++++++:           WM: i3
      `/+++ooooooooooooo/`         CPU: Intel Core i7-4710MQ CPU @ 3.5GHz
     ./ooosssso++osssssso+`        GPU: GeForce GTX 765M
    .oossssso-````/ossssss+`       RAM: 1581MiB / 15972MiB

Please set the set-remain-on-exit tmux option and report what
error message appears, if any.

You might be running into this issue:
.
https://github.com/zsh-users/zsh-autosuggestions/issues/126#issuecomment-217041261
.
See two comments down the page from that for a workaround.

@danielshahaf I tried to exec tmux set remain-on-exit on,giving me the message of Pane is dead.

Sorry for the long silence;I missed your reply.  Does this still occur?  If it does, can you show the smallest zshrc for which it occurs?  (Binary search your zshrc to find the most minimal reproducer.)

Feedback timeout.   See #353 for known issues.


Make it easier to find out how to delete a template

Feature Suggestion

Make it easier to find out how to delete a template.
Possible Implementation

Create a link on the template title to the catalog entry to each of the available templates in /create. This would allow  a user to easily follow the normal unregister a component.
Context

It is diffifult for a user to understand how to delete a template:

Lack of documentation
Difficult to find template in catalog

Another possible implementation is showing kinds other than Component on the catalog page. So one could select Template and see all registered templates through the catalog interface (or User, Group, Resource etc). The capability is there already in EntityKindPicker, but it has no UI at the moment since a design proposal is needed.
As a workaround, you can visit /search which has a kind filter and select Template there without any search terms. A bit awkward, to be sure.

As discussed on discord, I'm wondering if it makes sense to add a little View in Catalog icon on the Template Cards in the /create screen list. Right now it's a little abstracted away as they're not in the main /catalog view as that default to Components.
Maybe the actual solution is to be able to browse everything in the Catalog, but that opens up more questions really in terms of is that really what we want either?

Can we close one now as we should be able to see the templates in the entity page now there's a filter for the type of kind you want to see?


Replace Cobertura With JaCoCo

JaCoCo seems to do a better job and also it is supported by default by Sonar.

Remove milestone as for now since this is not on top priority.


[Aggregate-reports] Upload Dependency Report failing in nightly runs

Aggregate-reports nightly test runs are failing with:

Error message:
ClientSecretCredential authentication failed: A configuration issue is preventing authentication - check the error message from the server for details. You can modify the configuration in the application registration portal. See https://aka.ms/msal-net-invalid-client for details.  Original exception: AADSTS7000222: The provided client secret keys for app '***' are expired. Visit the Azure portal to create new keys for your app: https://aka.ms/NewClientSecret, or consider using certificate credentials for added security: https://aka.ms/certCreds.
Stack trace:
Connect-AzAccount -ServicePrincipal -Tenant 72f988bf-86f1-41af-91ab-2d7cd011db47 -Credential System.Management.Automation.PSCredential -Environment AzureCloud @processScope
##[error]ClientSecretCredential authentication failed: A configuration issue is preventing authentication - check the error message from the server for details. You can modify the configuration in the application registration portal. See https://aka.ms/msal-net-invalid-client for details.  Original exception: AADSTS7000222: The provided client secret keys for app '***' are expired. Visit the Azure portal to create new keys for your app: https://aka.ms/NewClientSecret, or consider using certificate credentials for added security: https://aka.ms/certCreds.
Trace ID: 0ebd6803-de07-4f1b-ada4-aef76e6f8f02
Correlation ID: 8e2dad7c-250a-4610-96eb-0e968a5fb1e0
Timestamp: 2023-02-09 07:29:52Z
##[error]There was an error with the service principal used for the deployment.

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2174380&view=results

The expired service principal has been refreshed.


Improved flags fixturing for for repository unit tests

resolves #8627
Problem
Our flags are a global. Although hopefully they won't be soon 🤞 Regardless because of their global nature, setting the global flags in one unit test, affected other unit tests. This meant either any unit test had to clean up the global flags at the end OR every test had to reset the global flags at start. The latter was more common because it's easier to code defensively than hope any upstream test appropriately cleans up after itself.
Additionally we didn't have a "standard" way of setting up flags for tests.
Solution

Create a fixture which sets and tears down the global flags for every pytest unit test
Create an intentionally overridable fixture for any args a test may want to have in its flags

Checklist

[X] I have read the contributing guide and understand what's expected of me
[X] I have run this code in development and it appears to resolve the stated issue
[X] This PR includes tests, or tests are not required/relevant for this PR
[X] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
[X] This PR includes type annotations for new and modified functions

At the time of this comment it appears that Tests and Code Checks / (5) integration test/ python 3.11 / ubuntu-20.04 is In progress. However if you click on at action, you can see that it actually has finished. This is because there is an active GHA incident . All other GHA based checks have reported as Successful for this PR, going to move forward with merging.


Secrets should be decrypted to tmpfs

The current behavior writes the decrypted form of the secret file to the same directory that contains the sops-encrypted version.  This means sensitive data hits the filesystem in plaintext and depending on the environment this could also mean secrets hit the underlying storage in the clear, which may not be properly encrypted.
As a best practice, secrets should decrypt to tmpfs by default.  Barring that, it should be possible to override the target directory for decrypted secrets.

Duplicate of #151 (at least #151 can address this concern).


Fixes the month consistency issue in enums (OS::Month) and get_date etc

Also updated the docs to reflect this.
Added some vim temp files to gitignore

Ticket:
https://github.com/godotengine/godot/issues/4025

Awesome work! Thank you for making it consistent! :)

Will that work as expected on all OS implementations?

If I understand the issue correctly, OS.get_date() was already starting to number months at 1, while the OS enum started at 0?
If so I agree with the change, but we need to make sure we won't break existing engine code that relies on the OS::Month, and if we break games relying on OS::Month, it has to be made clear in the release notes.

Things to check:

https://github.com/godotengine/godot/blob/master/platform/windows/os_windows.cpp#L1648 (according to the MSDN doc you linked, it seems that it will work fine after your PR and was broken previously?)
https://github.com/godotengine/godot/blob/master/platform/winrt/os_winrt.cpp#L464
https://github.com/godotengine/godot/blob/master/platform/nacl/os_nacl.cpp#L252

Yes that's correct.  The implementations I saw of get_date were indexing starting at Jan == 1.
For the platforms mentioned, I don't have any way check these since I don't have these systems.  If Travis has a built in Unit test framework (for auto running) this could be an option.
I was actually surprised that there were no unit tests I could find in Godot.  This would be a great verification step for pull requests.

All implementations found:
OS_Unix::get_date => verified...
OSNacl::get_date => indirectly verified (see code notes). This follows unix standard and needed to be +1 for month, to match Julian calendar style 1-12.
OS_Windows::get_date => Indirectly verified. SYSTEMTIME already follows 1-12 month format
OSWinrt::get_date => indirectly verified. SYSTEMTIME already follows 1-12 month format

Thanks, looks good :)
I'll merge once the travis CI checks are done.


Integrate the eBPF based AppArmor recorder into the API

What type of PR is this?

/kind feature
What this PR does / why we need it:
It integrates the eBPF based AppArmor profile recorder into the API. This will allow to record AppArmor profiles for workloads directly into the cluster in the same fashion like seccomp profiles.
Which issue(s) this PR fixes:

Does this PR have test?

Yes
Special notes for your reviewer:
I will follow up with some integration tests in a separate pull request.
Does this PR introduce a user-facing change?

Add the eBPF based AppArmor profile recorder into the API.

cc @mhils @@milkmix_

@mhils please could you review the changes and let me know if you find any issues? Thanks a lot!

Codecov Report
Attention: Patch coverage is 49.01478% with 207 lines in your changes missing coverage. Please review.

Project coverage is 42.11%. Comparing base (11d77f4) to head (004e484).
Report is 254 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
- Coverage   45.50%   42.11%   -3.39%
==========================================
  Files          79      109      +30
  Lines        7782    15810    +8028
==========================================
+ Hits         3541     6658    +3117
- Misses       4099     8660    +4561
- Partials      142      492     +350

@saschagrunert @mhils This is ready for final review. All tests finally passed. Thanks

@saschagrunert @mhils if you are happy please could you approve? I'll follow up with e2e tests and other small fixes if needed since this got already quite large. Thanks a lot!


tests: posix: common: separate posix c_lib_ext to standalone test

Fixes #81488
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves fnmatch into a singular testsuite at tests/posix/c_lib_ext app directory.

I think there is likely an unrelated test failing in main, so this will just need a rebase at some point

@Pancakem - this should basically be ready to go after a rebase


Provide bi-directional data flow

It would be good to be able to specify bidirectional data flows, as well as the existing single direction data flow, as it would make some diagrams look less busy and would not detract from the information in the threat model

There is no need for bi-directional arrows, as nobody in the Threat Dragon community has specifically asked for them (except @jgadsden ;) )

Made a search to see if there was a feature for this, breaks my heart tbh

Oh! @Lytes it is really good that you want this. I was the originator of this issue, because personly wanted it - but there seemed no interest from the community so I closed it
Very happy to open this issue again and I hope it attracts some developer interest

Was this feature ever included? I'd be extremely happy to have this as well...

All done, this was included in Pull Request "Diagram style updates" #742, September 2023


⚠ ClamAV has degraded performance

In c1812b5, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 80 ms

Resolved: ClamAV performance has improved in 912de2d.


tileSize is irrelevant in PositionToTileXY

tileSize should be removed as a parameter in PositionToTileXY
AzureMaps.TileMath.PositionToTileXY([28.0, -26.2], 10, 1);
{tileX: 592, tileY: 589}
AzureMaps.TileMath.PositionToTileXY([28.0, -26.2], 10, 100000);
{tileX: 591, tileY: 589}

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a5e829b4-ffb5-9a4c-5cb4-980636e195e0
Version Independent ID: d0ba3e05-4a72-51d0-8ae1-ae0a8eccacd6
Content: Zoom levels and tile grid in Azure Maps
Content Source: articles/azure-maps/zoom-levels-and-tile-grid.md
Service: azure-maps
GitHub Login: @jingjing-z
Microsoft Alias: jinzh

@algattik Thanks for the feedback! We are currently investigating and will update you shortly.

@jinzh-azureiot Please check this issue and update the doc as appropriate.

@rbrundritt Please check this issue and provide your insights.

In 99.9% of cases it isn't needed, but in the last 0.1% it can make the difference of a single pixel which can be the difference from one tile to another.

Thanks for the clarification. It would be great to add a comment to the source code as it's unexpected.

I'm working on a large addition to the docs (something unrelated to this), but have added the following comment to this code:
//tileSize needed in calculations as in rare cases the multiplying/rounding/dividing can make the difference of a pixel which can result in a completely different tile.
I'll check it in with the larger check-in I'm working on later this week.

@rbrundritt Thank you so much for the quick response and addressing this issue.
@algattik We hope that addresses your feedback.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Oauth integration keycloak dev

This pull requests adds configuration boilerplate to allow social login integration with keycloak.
Changes contained are mostly taken from the comments of @cynthia-rempel given whithin issue #4103.
To be precise, this is what I did:
figure out how integration works:

took a recent master branch of defect dojo repo
added the changes from #4103 and made sure it was working against a recent version of keycloak (15.x)
tested this in my dev environment (using k8s: local minikube as well as remote EKS development environment)

now to provide the pull request, I took these steps:

forked Defect Dojo repo on github
created branch oauth-integration-keycloak-dev, branching off from dev branch
added the same changes to oauth-integration-keycloak-dev
add docu snippet
create PR

Regarding testing of this PR:
I've read about the unit test guidelines, but as far as i understand there are no unit tests needed/feasable, since this PR only provides configuration boiler plate for the social plugin integration.
I did not test this branch yet. Please let me know if I should do so. In case the answer is yes, please let me know if there is something different when running Defect dojo from the dev branch.1

This is cool, I will walk through it, and test it, because we need this as well.

Thank you very much for your comments, @dsever !
I've made my changes/comments accordingly.

Thank you very much for your comments, @dsever ! I've made my changes/comments accordingly.

@oliversommer I'm not moderator, I'm just user who would like to have this kind of integration to move away from SAML.
For full code review you should wait for moderators.
But my PoW, great work

I did not test this branch yet. Please let me know if I should do so. In case the answer is yes, please let me know if there is something different when running Defect dojo from the dev branch.

Although your changes seem to be fine for me, I would like to have confirmation that the changes have been tested manually as well. If you use docker-compose, you can execute docker/setEnv.sh dev, docker-compose build and docker-compose up to start a development environment locally.

@oliversommer, @dsever Has anyone of you tested the integration against a keycloak server?

@StefanFl not yet, but is in the plan till the end of the week

@StefanFl @oliversommer  I finally had some time to test PR. It works as planned, I'm able to login into app.
The things that still needs to be checked are:

attribute mapping
auto redirect to keycloak form (not to show DD one)
not enable by default user creation

@StefanFl are there group mappings implemented in DD, so I  can test it as well?

@StefanFl @oliversommer I finally had some time to test PR. It works as planned, I'm able to login into app.

@dsever Great, thanks a lot.

The things that still need to be checked are:
attribute mapping
auto redirect to keycloak form (not to show DD one)
not enable by default user creation

Can you do these checks? Or would you approve the PR without them?

@StefanFl are there group mappings implemented in DD, so I can test it as well?

No, there are no group mappings implemented yet. I don't know a lot about social auth and don't have a test environment for it, so I don't know where to get the data from that shall be mapped to DD groups.

Have in plan to check it as well

thanks @Maffooch for reviewing, @dsever for having a go with testing this and @StefanFl for taking a look again.
here are my comments on the highlighted points:

attribute mapping: for me that worked pretty out of box, just by defining those audience mappers in keycloak, as described in the docs (other sources here or the comments from @cyntia-rempel in issue 4103) . It's pretty easy, actually. At any time you can delete the created ddojo user via the admin account and retry login/creating user without the need of restarting keycloak or defect dojo

auto redirect to keycloak form: is generic function from the social-auth integration and not related to the keycloak related bits. It should work by using SOCIAL_LOGIN_AUTO_REDIRECT and I guess I will use that feature soon myself (haven't tried yet, but as pointed out it does not really relate to the keycloak specific bits)

not enable by default user creation: unsure about this one. By the sound of it, you would prefer to create ddojo accounts only manually and not automatically at first login? I haven't read about such a functionality, but from my understanding such a feature would either be available for all social login providers/systems or none, i.e. it has to be provided at the social-auth level and not at the keycloak integration level. As far as I understand, defect dojo currently does not support such a setting.

regarding group mappings: I am clueless as well. Right now I do not require such a functionality, though that could change in the more distant future.

improved documentation snippet a little bit.
I am happy to hear what else can be done in order to bring this forward.

Basically from my side it looks ok,
This SAML_CREATE_UNKNOWN_USER = env('DD_SAML2_CREATE_USER') as we have in the SAML  auth is very nice feature but not sure is supported by social-auth. (yes we are creating users via API in front to reduce risk)
I'm very thankful that @oliversommer  helped us all.

Thank you @oliversommer for implementing this new integration and thank you @dsever for testing it 😃

Hi, I do not see DD_SOCIAL_AUTH_KEYCLOAK_OAUTH2_ENABLED in https://github.com/DefectDojo/django-DefectDojo/blob/dev/dojo/user/views.py#L78-L102. Is there any reason?

I prepared PR: https://github.com/DefectDojo/django-DefectDojo/pull/5835
I haven't tested (I do not have any running keycloak) but I followed the existing implementation.


Eliminate explicit backslash path separators to fix tests on MacOS

This PR fixes the compiler tests to run on MacOS by splitting up paths with explicit "" path separators into multiple segments that are combined with Path.Combine.
In almost all cases the code was already using Path.Combine so this was relatively straightforward.
One special case was flipping a "" to a "/" in the "examples.json" file.  I'm hoping this won't cause problems for the tests on Windows ...

Thank you for fixing these!


Add only new story check

I'm using Telegram API to send me a notification every time the script runs; is it possible to add a background check to verify only if new story is published and so send me a notification?
Edit: without need to install anything, maybe a good solution can be using something like this
ls -1A >/path/OUTPUT/username/stories  | wc -l
so that it checks if there's a new file

Since I don't use the Instagram API, but just collect data from insta-stories.com, I can receive notifications when stories are published.
Maybe one day I will write a new project which will be based on instagram_private_api
In the meantime, I recommend to look at other projects, for example:
github.com/Veeenz/instagram-story-stalker
It uses Telegram API and has notifications about new posts and stories.

Many thanks for creating this amazing tool. Github.com/instaloader/Instaloader gave me 400 errors, so your tool saved me :)


Fix run time error in release build

https://github.com/facebook/react-native/commit/53905a537a58d028fc5eb1c4e9a8ec967d8cd396

Thanks @nim23 !
ViewPropTypes got introduced in RN 0.50.0, right? So what happens if your code will run on RN 0.49.0? If it crashes, it means that future releases of react-native-recyclerview-list will be available just on RN >= 0.50.0 and users will be forced to upgrade to that version of RN.

Pretty sure I had this error on 0.49.0. Not sure though if the version React would have any impact on the error I was getting. https://github.com/archriss/react-native-snap-carousel/issues/87. Similar related issue, funny though I was only getting this error when trying to get a release build.


Gamelogic-configurable netcode for playerState_t

A lot of hacks! There are a few fields referenced in the engine code, so I'm keeping those hard-coded in for now. I have only implemented loading the table from sgame so far, not from cgame (though it's matter of trivial copy and paste), so it only works with a local server.
The point is to be able to change the definition of playerState_t without rebuilding the engine.  If we like this, there's another table for entityState_t that it can also be done for.

This should be in a mergeable state now.

I pulled playerstate/sync on both side and I got that while loading a map:
Warn: SGame VM: IPC: Unexpected end of message

And the game returns to main menu.

Whoops, accidentally put QVM as the syscall major number of GetNetcodeTablesMsg, when it was ended to be MISC. Now fixed.

I now see no issue on my end. I'm not sure to understand everything but I'm confident in what you've done.


No attribute 'GenerateCpuTfLite'

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
None
OS Platform and Distribution
mac os
Mobile device if the issue happens on mobile device
No response
Browser and version if the issue happens on browser
No response
Programming Language and version
python
MediaPipe version
No response
Bazel version
No response
Solution
llm
Android Studio, NDK, SDK versions (if issue is related to building in Android environment)
No response
Xcode & Tulsi version (if issue is related to building for iOS)
No response
Describe the actual behavior
Get an error
Describe the expected behaviour
Expecting to convert the model successfully.
Standalone code/steps you may have used to try to get what you need
Hello, after compiling and installing the Python package from the source code, I encountered the following error when trying to convert my own model. Is there any additional option that can be added during compilation to solve this problem?

File "python3.9/site-packages/mediapipe/tasks/python/genai/converter/llm_converter.py", line 163,  in combined_weight_bins_to_tflite
    model_ckpt_util.GenerateCpuTfLite(
AttributeError: module 'mediapipe.python._framework_bindings.model_ckpt_util' has no attribute 'GenerateCpuTfLite'

### Other info / Complete Logs

_No response_

I added --copt=ENABLE_ODML_CONVERTER in setup.py but it didn't work.

@ayushgdev Unable to find the odml package for local compilation. How can I pull the odml package?

Hi @zkh2016,
We believe, We have not tested this scenario yet. Could you please share the complete steps you're following from the documentation?
Thank you!!

Firstly, compile and install the source code through python3 setup.py install -- link opencv, and then follow this tutorial to convert the model. The error message has no attribute' GenerateCpuTfLite  was prompted. Therefore, try to directly place the ODML package in media pipe/Python/pybind/BUILD into deps, and when compiling, the prompt The repository '@ ODML' could not be resolved
So, how to compile the source code and use it correctly?

Hi @zkh2016,
After internal discussion, we have concluded that this scenario cannot be supported. This functionality is designed and built specifically for internal use and is not intended for the wider user base. As a result, we likely won't be able to resolve this issue for your specific use case.
Thank you!!

Hi @zkh2016,
After internal discussion, we have concluded that this scenario cannot be supported. This functionality is designed and built specifically for internal use and is not intended for the wider user base. As a result, we likely won't be able to resolve this issue for your specific use case.
Thank you!!

Thank you for your answer. My goal is actually to use MediaPipe to run the Minicpm model. Can you help me adapt it? Or what should I do to get this model running with MediaPipe.

Hi @zkh2016,
We want to inform you that currently, this is not possible. We have already brought it to the attention of the team, and it is on our roadmap. Rest assured, Our team is actively working on this, and it will be available soon.
Thank you!!


Add support for i18n subfolders

Corresponds to my SMAPI PR

Merged into develop for the upcoming version 2.2.0. Thanks for the help!


Non-Gallery apps now can use all Azure AD Editions

Non-Gallery apps now can be used in all Azure AD Editions include Azure AD Free.
Source: https://techcommunity.microsoft.com/t5/azure-active-directory-identity/unlimited-sso-and-new-azure-ad-features-to-simplify-secure/ba-p/1257358

As Brad Anderson also shared in his Microsoft 365 news blog this morning, we're extending the ability to use Azure AD single sign-on (SSO) for an unlimited number of cloud apps at no extra cost. Whether you need gallery apps or non-gallery apps, using OIDC, SAML or password SSO, we have removed the limit on the number of apps each user can be assigned for SSO access in Azure AD.

@watahani : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

Hi @kenwith - The update in this PR deletes the entire introductory paragraph for the article. A quality criteria is that an article must have an introductory paragraph; text must follow the H1 heading--you can't go straight to an H2 heading.
Could you suggest changes to the contributor to keep the article compliant with this requirement?
#hold-off

@ktoliver - We can remove the first H2 also in this PR.

Thanks @kenwith - I made the update; merging now.