Improve jupyter launching (Jupyter Lab + enhanced alternate PORT)

What is the purpose of this PR?

Launch Jupyter as Jupyter Lab instead of Jupyter Notebook
Enhance start_docker.sh to pass the first available port to jupyter so that "remapped port" warning is no longer required.
Enhance available port detection to be more reliable
Add execute to start_docker.sh to allow running directly, updated readme to match.

How did you implement your changes
I've touched start_docker.sh and Dockerfile.
For details, see commit history as I have broken up commits to tell story clearly.
Remaining issues
None

@ngreenwald Figured we could merge this into master prior to finalizing the metacluster GUI.

Overall looks good! Is there a code cleanliness reason that having the script be executable is preferable to running bash scriptname? Or just a personal preference?

I'd say it follows "least astonishment" since it allows both bash ./script.sh and ./script.shand different people might be used to one or another.
Marking as executable also made sense since the script already included a the "hash-bang" (#!), which does nothing if not ran directly.
start_docker.sh
#!/bin/bash
...

I did just push a small change, to use the slightly more portable #!/usr/bin/env bash ipo #!/bin/bash
https://stackoverflow.com/questions/10376206/what-is-the-preferred-bash-shebang


CrowdStrike Spotlight c2c doc

Purpose of this pull request
This pull request (PR) ...
Issue number:

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[x] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

Thanks Kim! I updated the file name as per the id.


HIVE-17494: Bootstrap REPL DUMP throws exception if a partitioned table is dropped while reading partitions.

Already pushed to master.


Added whitelist tag support to work alongside sanitizer

Addresses #133.
This is a similar PR to that in #536, except it uses an object literal for the whitelist rather than a Regular Expression. Sample usage:
marked("
Some small text
", {
    sanitize: true,
    sanitizeWhitelist: ["div"]
});

Output:

        Some <strong>small</strong> text

    <script>alert('a script');</script>

The tests aren't very well set up for passing complex parameters (array of strings) through to the options so I've left those out. If someone can explain how I can add these in, I'll be happy to update the PR.

+1

please continue :)

Are there plans to merge this in? Whitelisting HTML tags would be a useful feature.

Thanks! I know this is old, and see #956
I too think this would be very useful. Needs tests also please fix the merge conflict. Given the state of things for the project and community, if no further comment is made on this it will be assumed stale and will be closed.


@kanaabe margin below images instead of below caption

fixes https://github.com/artsy/force/issues/799
now all images will have the same space below them that previously was only given to images with a caption

😻  thank you @1aurabrown!


Improve the discoverability of best practices guides

Background
We've created best practices guides:

Package authoring best practices
Best practices for a secure software supply chain

These guides should be really easy to find!
Solution

[ ] Add links to these guides on NuGet's docs homepage
[ ] Add links to these guides on NuGet's getting started docs (including the "Create a package" guides, and "Publish packages" guides)

Urgh I abhor these kinds of bots. It's plain disrespectful. There are better ways to manage a backlog.


audit: add uses_from_macos dependency ordering

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Brings uses_from_macos into the brew audit fold by checking that it

comes after any depends_on statements
is ordered like depends_on statements

Note that I wasn't able to deduplicate more code in rubocops/dependency_order.rb. I need to pass in a predicate to a more generalized function but there's something funky going on with how rubocop's node searcher macros are constructed and I can't figure out how to work around it.


undefined function backbone

Hi there, is this defined?
from .backbone import build_backbone:
Exception has occurred: ModuleNotFoundError
No module named 'backbone'
By the way, I am trying to get the tensorRT version of the weight running but based on what I can see the pytorch weight is the one which is doing the inference.

ok I just noticed you have another repo related to this.


feat: added sample product list

Created a sample product list with names and prices

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


How to install the sample app

I'm using the NfcProvisionning sample app but I'm not able to install the deviceOwner app on the child device. This app is already installed on the master device, the child device is well encrypted and the wifi connected but I receive an error during the admin app download.
I test with a Motorola X Style (XT1572) and a Motorola X Force (XT1580) on Android 6.0

I am closing this issue/PR, as it has been migrated to the new repo linked above in the comments. Thank you!


test_tensordot is flaky

This is part of https://github.com/chainer/chainer/issues/6903 effort.

Failure example: https://ci.preferred.jp/chainer.py27and35/2328/
Failure test case: TestTensorDot_param_216_{gc_shape=(5, 6), axes=([1, 3, 2], [0, 1, 3]), a_dtype=float16, b_dtype=float16, a_shape=(5, 4, 2, 3), b_shape=(4, 3, 6, 2)}.test_tensordot_backward_gpu
Tolerance:

E           Not equal to tolerance rtol=0.01, atol=0.01
E
E           Mismatch: 100%
E           Max absolute difference: 0.01180549
E           Max relative difference: 1.43404194

Hm, I cannot reproduce this locally. 🤔

I will reopen this issue when I see this issue again. This issue has not observed since Apr 22, so this seems quite rare.


Fix issue with OutSelect{Exact}

Happens when SizeStack vertices when at least one input has increased size while the total outsize has decreased (due to other inputs decreasing in size)
Fix #46

Codecov Report

Merging #47 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   92.08%   92.11%   +0.03%
==========================================
  Files          13       13
  Lines         960      964       +4
==========================================
+ Hits          884      888       +4
  Misses         76       76

Impacted Files
Coverage Δ

src/mutation/select.jl
95.38% <100%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0541fa4...3c1f0e4. Read the comment docs.


/cool/:name inconsistent

http://foaas.com/cool/rik returns 'bro' while documentation says 'Bro'
I have forked and fixed both, just let me know which one to create a pull-request from.....
see https://github.com/rikribbers/foaas

Probably documentation, don't think Bro qualifies as a proper noun
On Mon, Jun 20, 2016 at 5:06 PM, Rik Ribbers<EMAIL_ADDRESS>wrote:

http://foaas.com/cool/rik returns 'bro' while documentation says 'Bro'
I can provide a fix, but what to fix documentation or code...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tomdionysus/foaas/issues/155, or mute the thread
https://github.com/notifications/unsubscribe/AF1y2JNE2mUDNdokZZF20WeZHOki2LHVks5qNrqKgaJpZM4I52-I
.

mhh somehow created a new issue with the pull request... sorry for that...


Cleanup and remove any FD2 branch-specific hacks before merging to main

This includes changes to:

infra and CI files
build-specific hacks
CODEOWNERS
README etc.

@jliangTT Tagging this with P2 and infra-ci labels as they're relevant, although FD2 project is owning project.

FD2 has been merged


Add to watch from context menu in the Dynamic listing of the debugger

Is your feature request related to a problem? Please describe.
Currently, adding a watch is terrible workflow wise. You add the watch, remember that (to me) weird syntax of.. from memory:
*:64 0x004002aa:4 , this means to add a watch of 64 size to address 0x004002aa, and the rest i don't even know. And then manually typing it, etc.
Describe the solution you'd like
When i right click in the dynamic area, and the cursor address is typed, allow me a button that says "Add to watch" much like visual studio does. This automatically adds the address to watch, with the size, and type of the selected struct. (And if no struct, bring up a dialog that defaults to 4 bytes at that address and ask what you want it to do from there?)
Bonus points: Allow it in Static listing too (static listing is usually typed already, saving time)
Bonus Bonus points: Add breakpoint from watches, matching size, defaulting to SW_WRITE so i can start run until this struct changes.
Describe alternatives you've considered
Doing it manually as described above, usually halfassing the type or size for sake of quickness.
Additional context
I am a spoiled brat with fancy dev environments. But i feel as a programmer, assuming the context that is available in ghidra, this should be easy to make an MVP of, and is a massive time saver for anyone working with the debugger tool to do runtime inspection, because now i often forgo the use of a watch, because it is such a pain to add one manually.

This would be a nice feature. Even the "Bonus points" request is pretty reasonable. The "Bonus Bonus", however, I hesitate to implement. Instead, if you double-click the "Address" column of the Watch, it'll take you there in the listing, and you can easily set the breakpoint from there using the K key. I you're worried about size, then use the "Select Addresses" button in the Watches toolbar before setting the breakpoint.
I hesitate to implement "Setting breakpoints on watches," since that would imply breaking whenever the watch's value changes, which is subtly different than the bytes at the address changing. Granted, for watches of the form you describe, they are the same, but consider *:4 EAX. The watch's value could change if EAX changes, or the bytes pointed to by EAX change, or both. Putting a 4-byte breakpoint where EAX points only covers the latter.

@nsadeveloper789 I suppose that the breakpoints setting would probably be a whole other 2nd feature request.
To the problems you pose, I imagine "add breakpoint on address" and "add breakpoint on value" to differentiate between the two would be an option. But it already sounds way more complicated than my original feature request.
I suggest you forgo the whole "add breakpoint" stuff and indeed stick to the workflow of "you have a shorthand, you can easily navigate there and do it yourself" in favor of making the feature request a lot less painful to develop.

Issue addressed by commit adeefc58c88de8b5b078665f1c04e031a0ce4881


Add API documentation for Spec module

Expectations, Methods and ObjectExtensions have little to no documentation in API docs.

What's the status of this? I wouldn't mind taking on the job. I actually like Crystal's spec (reminds me of Jasmine) and it would be great if I could learn more about it while getting better at documenting code at the same time.

There has been some work done to document expectations on #5092 already (this will be available in the official API docs on next full release).

Thanks for showing me this! Is there any reason why the API documentation hasn't been updated yet?
I built the docs locally and it shows the new changes, so I'll be using this version for now.

@GloverDonovan They are, just in the master branch of api docs.

Didn't know about this. Thanks!

@GloverDonovan The regular API docs will be updated as soon as 0.24.1 is relased. That should be anytime now.

The docs not being updated is actually a CI bug. It should have been done when 0.24.1 tag was pushed.

I think this can be closed:
https://crystal-lang.org/api/0.25.0/Spec/Expectations.html


JSTree Error: Failed to execute 'querySelector' on 'Element'

When deploying Redis Commander to Pivotal Cloud Foundry I'm able to load the service details for Redis and connect, but JSTree is throwing numerous errors for the querySelector.
Clicking the refresh button or a node on the tree throws the following error:
Uncaught DOMException: Failed to execute 'querySelector' on 'Element': '#R:q-s0.redis-instance.dynamic-services.service-instance-422e5436-73b3-49d4-af9c-dc0c3b9a6809.bosh:6379:0:,O^m��RV!$��' is not a valid selector.

Do you have the output of the server-side console? Can you post it please?
And what does the name of your keys look like? Something special it looks like - maybe binary data?
And when does it throw the errors? On initial display of the tree without opening anything on key level? OR after clicking of the server entry inside the key (with the red redis logo) Or opening the keys below it...

Nothing shows up in the server-side logs, just browser console.  Here is the complete output from Chrome:
Uncaught DOMException: Failed to execute 'querySelector' on 'Element': '#R\:q\-s0\.redis\-instance\.dynamic\-services\.service\-instance\-422e5436\-73b3\-49d4\-af9c\-dc0c3b9a6809\.bosh\:6379\:0\:\,O\^m��RV\!\$��' is not a valid selector.
    at $.jstree.plugins.contextmenu.redraw_node (https://internal-pcf-app.int/jstree/jstree.js:2448:87)
    at $.jstree.plugins.contextmenu.draw_children (https://internal-pcf-app.int/jstree/jstree.js:2413:25)
    at $.jstree.plugins.contextmenu.open_node (https://internal-pcf-app.int/jstree/jstree.js:2683:12)
    at $.jstree.plugins.contextmenu.toggle_node (https://internal-pcf-app.int/jstree/jstree.js:2835:17)
    at $.jstree.plugins.contextmenu.<anonymous> (https://internal-pcf-app.int/jstree/jstree.js:759:12)
    at HTMLElement.f (https://internal-pcf-app.int/scripts/jquery-2.2.4.js:2:3698)
    at HTMLDivElement.dispatch (https://internal-pcf-app.int/scripts/jquery-2.2.4.js:3:7537)
    at HTMLDivElement.r.handle (https://internal-pcf-app.int/scripts/jquery-2.2.4.js:3:5620)

This appears in the console when the app first loads and if we attempt to expand the tree.  If I click on the main Redis node then I am able to see server info.

Your comment about binary data got me thinking, I deployed another test app so I could see the keys and it looks like some encrypted keys and values were written.  I ran FLUSHALL and was able to get things working again.  So FYI that bad keys will completely break the UI.
Thanks for the assistance.

than i reopen it - we have to do something about this kind of keys to not break the UI.
Good to know the reason...

just think about the problem - do you have any idea or preferences how binary keys should be represented in the tree view?
What would be useful here?
Thanks


DATAJDBC-359 - Support for arbitrary chains of entities with or without Id.

That's merged and polished now.


[FEATURE REQ] ServiceBus and EventHubs processing: use parent instead of link when possible

Library name
Azure.Messaging.ServiceBus, Azure.Messaging.EventHubs
Please describe the feature.
When we trace EH/SB.Process call, we create a link in all cases, even when one message is received. We receive feedback indicating that links are confusing, e.g.
https://github.com/Azure/azure-functions-dotnet-worker/issues/1089 and through support channels.
The suggestion here is that if we process one message/event, we should use the incoming message context as a parent for the new span rather than a link. With this, the producer and consumer will have one trace-id - it's supported by all tracing backends and easy to query.
This is not breaking as all tracing backends should support parent-child relationships.

Here is the current structure for Service Bus:
Receiver.Receive --Link to Message
|
Processor.Process --Link to Message

@lmolkova are you saying it should be
Message
|
Receiver.Receive
|
Processor.Process

I think today it's:
Trace0: Message
Trace1: Receiver.Receive --Link to Message
Trace2: Receiver.Process --Link to Message
But should rather be
Trace0: Message
Trace1: Receiver.Receive -- Link to Message
Trace0: Receiver.Process, child of Message
(for single message case)


[proposal] Add CRDs from external helm chart

Hello
Wdyt about extending this controller with possibility to extract CRDs from published Helm charts repositories. (both OCI and plain old HTTP).
Since Helm has old issue that CRDs are not automatically upgraded but the CRDs are still packaged within Helm charts, this application could address this gap.

Oh that is a very good idea! Thanks for this proposal. I actually know how to do that. :D
💯

Oh that is a very good idea! Thanks for this proposal. I actually know how to do that. :D
💯

In terms of cli it would be smth like
helm pull --untar .... /tmpdir
.. do magic with crd folder ...

Yep, pretty much. Also, flux has some libraries in it's publish pkg repository to deal with OCI repos and extract tar files. So integrating that will help massively in providing this feature.

Yep, pretty much. Also, flux has some libraries in it's publish pkg repository to deal with OCI repos and extract tar files. So integrating that will help massively in providing this feature.

i just assumed helm libs itself should support oci repos, without even going to any 3rd party.

That's true. I thought you might want to do something like a helm source which would require credentials and would use helm package or something to extract / fetch the helm resources.

The difficulty here will be tag discovery. Since that is broken in Helm for OCI repositories. I'll see what I can do about it.

The difficulty here will be tag discovery. Since that is broken in Helm for OCI repositories. I'll see what I can do about it. Like, I can use oras or containerregistry or whatever to see which is the latest tag. And then hope it's a chart file. :D

First, what do you mean broken and 2nd - why do you mention latest tag ?
Could you plz provide more details ?

The difficulty here will be tag discovery. Since that is broken in Helm for OCI repositories. I'll see what I can do about it. Like, I can use oras or containerregistry or whatever to see which is the latest tag. And then hope it's a chart file. :D

First, what do you mean broken and 2nd - why do you mention latest tag ?
Could you plz provide more details ?

https://github.com/helm/helm/issues/11000
I'm not saying latest; I'm saying latest as in the newest version. So v1.0.0 v2.0.0 v3.0.0. To detect if a new version has been pushed.

https://github.com/helm/helm/issues/11000
I'm not saying latest; I'm saying latest as in the newest version. So v1.0.0 v2.0.0 v3.0.0. To detect if a new version has been pushed.

sorry, i don't understand :(

helm should already support semantic ranges for OCI, so i still not understanding the issue.

Can it list tags for a specific chart?
I need to be able to track which is the latest version to reconcile new versions. If a new versions is available, I'm installing it.
In order to do that, I'm asking for a list of versions and see if the latest version is greater than the current reconciled versions given a semver constraint. So like, only patch versions, or, major, or minor.

For example:
helm search repo chart oci://ghcr.io/skarlso/helm/crd-bootstrap --versions

Returns
No results found

So I can't use helm to discover tags.
But that's fine.. I can use oras for example, or anything else that deals with OCI registries.

Can it list tags for a specific chart?
I need to be able to track which is the latest version to reconcile new versions. If a new versions is available, I'm installing it.
In order to do that, I'm asking for a list of versions and see if the latest version is greater than the current reconciled versions given a semver constraint. So like, only patch versions, or, major, or minor.

this is a very bad idea imo.
the versions of CRDs must be driven by customer restriction, i.e. either particular version, or semantic range ( assuming helm golang library supports it, because helm CLI supports it)

For example:
helm search repo chart oci://ghcr.io/skarlso/helm/crd-bootstrap --versions

Returns
No results found

So I can't use helm to discover tags.
But that's fine.. I can use oras for example, or anything else that deals with OCI registries.

this is incorrect syntax, this should work
helm search repo crd-bootstrap -l

Did you try it? :) It does not work. :)

this is a very bad idea IMO.
the versions of CRDs must be driven by customer restriction, i.e. either particular version, or semantic range ( assuming >helm golang library supports it, because helm CLI supports it)

Yes, this is exactly what I just wrote. You define a semver. If the semver allows it it will update. If it doesn't it won't. :)

Did you try it? :) It does not work. :)

this is a very bad idea IMO.
the versions of CRDs must be driven by customer restriction, i.e. either particular version, or semantic range ( assuming >helm golang library supports it, because helm CLI supports it)

Yes, this is exactly what I just wrote. You define a semver. If the semver allows it it will update. If it doesn't it won't. :)

i am AFK,  command lines writing by memory.
but about latest - there should not be latest, semver exact or range should be srt. and helm already handles this.

I'm not looking at latest. I'm looking for new versions that are allowed by a set semver.

I'm not looking at latest. I'm looking for new versions that are allowed by a set semver.

since i am afk - cant suggest smth in particular
but let give you an example.
I was using helm library chart as a dependency for my charts.
That helm library chart was published to github packages, i.e OCi registry.
I was declaring the dependency with semantic version, like ~6.
So, every time i was running helm dep up withing my my charts, the latest semantic version was resolved and downloaded.

Aha. Interesting. I'll take a look at that code section how they circumvent the search problem. Thanks for the pointer.

So dep update basically downloads everything again into the local registry and THEN selects the latest version using the semver. I could use something similar internally, but I don't require this level of engagement. I literally just need some tags from the OCI registry and that's it. :)
For plain HTTP and use helm search.

So dep update basically downloads everything again into the local registry and THEN selects the latest version using the semver. I could use something similar internally, but I don't require this level of engagement. I literally just need some tags from the OCI registry and that's it. :)
For plain HTTP and use helm search.
edit: technically it only downloads the index file. not the actual whole thing.

for plain HTTP it downloads index.yaml from the repo. for OCI it queries tags via OCI registry API.

for OCI it queries tags via OCI registry API.
Yep:

tags, err := c.RegistryClient.Tags(strings.TrimPrefix(ref, fmt.Sprintf("%s://", registry.OCIScheme)))

I guess I could use the registry client I already construct. Hopefully that works.

The latest release should contain this feature. v0.5.0.

The latest release should contain this feature. v0.5.0.

great.
need a time to test it, hope during the weekend.

Maybe worth mentioning here ?
https://github.com/helm/helm/issues/8668

Heh, interesting answer on that issue....

Heh, interesting answer on that issue....

which one ?

There is only one.

This is now done. Please feel free to re-open or create a new issue if problems arise. :) 🙇


Video rendering - kplanes-dynamic (AssertionError: Initialized model with time-planes, but no time data is given)

I have trained the kplanes-dynamic model with the proposed dnerf synthetic dynamic dataset. However, as there is no clear instruction on how to render the video for the same, I am struggling to render video result. I have few questions regarding the process.

How to render videos for kplanes-dynamic model?
Is camera path necessary or could I directly use interpolate option?
Do we need to use the viewer and do something in order to start rendering successful? or is it possible directly to render with using viewer interface.
How does the Time slider in viewer affect the rendering?

I had come across the following error while attempting to render.

The following are the steps that led to the error.

trained for dnerf sythetic dynamic scene --> jumpingjacks
ns-render interpolate --load-config outputs/jumpingjacks/kplanes-dynamic/2024-09-05_115237/config.yml --output-path renders/jumpingjacks/jj_interpolate.mp4

Could anyone guide me with the steps to attain the rendering. Thanks in advance.

I have trained the kplanes-dynamic model with the proposed dnerf synthetic dynamic dataset. However, as there is no clear instruction on how to render the video for the same, I am struggling to render video result. I have few questions regarding the process.

How to render videos for kplanes-dynamic model?
Is camera path necessary or could I directly use interpolate option?
Do we need to use the viewer and do something in order to start rendering successful? or is it possible directly to render with using viewer interface.
How does the Time slider in viewer affect the rendering?

I had come across the following error while attempting to render.
The following are the steps that led to the error.

trained for dnerf sythetic dynamic scene --> jumpingjacks
ns-render interpolate --load-config outputs/jumpingjacks/kplanes-dynamic/2024-09-05_115237/config.yml --output-path renders/jumpingjacks/jj_interpolate.mp4

Could anyone guide me with the steps to attain the rendering. Thanks in advance.

Hi, I'm glad to help.
Let me address your questions one by one:

How to render videos for kplanes-dynamic model?
To render, you can use the command ns-render --help to check the usage instructions. Note that from version v1.0.0 onwards, the render type supports dataset. So if you'd like to render the same image as in the eval dataset, upgrade your nerfstudio version first.
Is camera path necessary or could I directly use interpolate option?
It depends. If you want to render along an arbitrary path in the scene, use camera-path. If you're following the train/eval path but with different views, interpolate is the way to go. If you prefer rendering the same views as in the train/eval dataset, choose dataset.
Do we need to use the viewer and do something in order to start rendering successful? or is it possible directly to render with using viewer interface?
Rendering is performed via ns-render. Unless you're customizing camera paths, viewer isn't necessary for rendering.
How does the Time slider in viewer affect the rendering?
The time slider in the viewer controller only impacts the output you see in the viewer interface, it does not affect the rendering result.

The error you encountered is caused by the interpolate. Since kplanes-dynamic requires time in every frame, but the interpolate mode only interpolates camera poses, excluding time, as a result, this leads to the error you're seeing.
To resolve this, you can either interpolate time yourself, or just use dataset mode to follow the pre-defined path. This should solve your issue.

@Tavish9 Thank you for your response. Really appreciate it.
However, I still have doubts. I am unable to still understand how to obtain/render a time variant kplanes-dynamic video. I too have obtained the images but it would be nice to get a video.
I cannot find documentations for the video generation of kplanes-dynamic.
I was able to generate video for static scene using --interpolate only. How else do you suggest I generate a video? Direct ns-render with load-config does not generate any video for me. The other sub commands are {camera-path,interpolate,spiral,dataset}  and thats how I decided to go for interpolate choice.

@Tavish9 Thank you for your response. Really appreciate it.
However, I still have doubts. I am unable to still understand how to obtain/render a time variant kplanes-dynamic video. I too have obtained the images but it would be nice to get a video.
I cannot find documentations for the video generation of kplanes-dynamic.
I was able to generate video for static scene using --interpolate only. How else do you suggest I generate a video? Direct ns-render with load-config does not generate any video for me. The other sub commands are {camera-path,interpolate,spiral,dataset} and thats how I decided to go for interpolate choice.

Could you clarify which command you’re referring to?
Additionally, whether using camera-path or interpolate, a video can still be generated with the --output-format video option.
As I mentioned earlier, rendering time-variant kplanes-dynamic requires manual code modifications.
Let me know if this works or if you need further adjustments!

@Tavish9 Could you explain what manual modification needs to be done for  rendering time-variant kplanes-dynamic and how? I am fairly new to this and quite confused.
As per your suggestion I once again tried using ns-render dataset and it renders. However, I am not able to get a video output!

I get a folder lego_dynm.mp4  instead of video, containing another folder test and which contains various image folders.

and all I want is a video and not images of the lego in dynamic motion as per the paper and there official page, with moving lego arm.

Where am I going wrong? How do I rectify it. This is the option I see for rendering and choosing dataset is not giving me a video output.

Hi, @Anji-Builds, ns-render dataset command does not support video generation. If you want to generate a video, use ns-render interpolate with manual code modification. Here is what you need to do.

fix camera times in cameras/camera_paths.py:

  cameras = Cameras(
      ...
      times=times
  )

generate times in cameras/camera_utils.py:

time = []
for idx in range(poses.shape[0] - 1):
      ...
      time += get_interpolated_time(times[id], times[id+1], , steps=steps_per_transition)

return ..., torch.stack(time, dim=0)

finish get_interpolated_time function.

I plan to submit a pull request to the official repository soon to implement these changes. Stay tuned!


fulcio.sigstore.dev is not working

fulcio.sigstore.dev is not working
It appears that fulcio.sigstore.dev returns a 404 when accessed.
Instructions for using the tuf-client in the README can be found at https://raw.githubusercontent.com/sigstore/root-signing/main/repository/repository/~
is not available due to broken links in

Are you trying to access the instance’s certificate chain? It is available at https://fulcio.sigstore.dev/api/v2/trustBundle.

Note that fulcio.sigstore.dev does return a 404 as expected, nothing is served from that URL. See the proto definition for available methods.
As for TUF, the Fulcio certificate chain is securely provided in the TUF repository. If you're using Sigstore, this is handled automatically, or with cosign initialize.
Feel free to ping the issue if you have other questions.


Cannot use with_structured_output

I have a basic setup that looks like this.
The calls works fine without the structured output but fails when I include it.
from pydantic import BaseModel, Field

class Subject(BaseModel):
    title: str
    description: str

class DesiredOutput(BaseModel):
    subjects: List[Subject]

llm = ChatBedrockConverse(
            model="anthropic.claude-3-5-sonnet-20241022-v2:0",
            temperature=0,
            max_tokens=None,
)

structured_llm = self.llm.with_structured_output(DesiredOutput)

 messages = [
            (
                "system",
                prompt, # defined elsewhere
            ),
            (
                "user",
                "generate 25 subjects",
            )
]

llm.invoke(messages) # works fine
structured_llm.invoke(messages) #raises

Traceback:
  File "/var/task/botocore/client.py", line 569, in *api*call
    return self._make_api_call(operation_name, kwargs)
  File "/var/task/aws_xray_sdk/ext/botocore/patch.py", line 38, in *xray*traced_botocore
    return xray_recorder.record_subsegment(
  File "/var/task/aws_xray_sdk/core/recorder.py", line 456, in record_subsegment
    return_value = wrapped(*args, **kwargs)
  File "/var/task/botocore/client.py", line 980, in *make*api_call
    request_dict = self._convert_to_request_dict(
  File "/var/task/botocore/client.py", line 1047, in *convert*to_request_dict
    request_dict = self._serializer.serialize_to_request(
  File "/var/task/botocore/validate.py", line 381, in serialize_to_request
    raise ParamValidationError(report=report.generate_report())

botocore.exceptions.ParamValidationError: Parameter validation failed:
Invalid length for parameter toolConfig.tools[0].toolSpec.description, value: 0, valid min length: 1

Found the issue. You need to add a description to the pydantic model for it to work.
class DesiredOutput(BaseModel):
    """Some description"""
    subjects: List[Subject]

Not very clear from the docs that this is required.


fix: incorrect text on above offers table

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #3531
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

stats:

incoming offers

gallery offers

LGTM

let's resolve conflicts and merge this:)
wfm

let's resolve conflicts and merge this:)

Done

pay 50

😍 Perfect, I’ve sent the payout
💵 $50 @ 65.56 USD/KSM ~ 0.763 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x52045dfb6bfca2f7fd57b99f6cff893cdcf1e4386fb606df0fd7b5750ca543ee
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


tools/syz-linter: fix golangci-lint plugin signature

This pull request address the following warning:
WARN plugin: 'AnalyzerPlugin' plugins are deprecated, please use
the new plugin signature:
https://golangci-lint.run/contributing/new-linters/#create-a-plugin

Thank you!


[Linux] Is it possible to deploy privately built Kudu to Web App for Containers?

Hi,
I was going through the wiki and I found this article - https://github.com/projectkudu/kudu/wiki/Deploy-locally-built-private-kudu-to-azure
I was wondering whether it is possible to deploy a privately built Kudu to Web App for Containers or not.
Thanks,
Pranav

@rramachand21 do you know whether it's possible for someone to run their own Kudu bits on Linux?

any updates? I too would like to deploy kudu to a Linux environment to control/build/deploy from GitHub

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Rollback for older node versions that have followed a legacy chain

Motivation
If an old version of Zebra isn't upgraded before a network upgrade, we need to rollback or delete the database.
Solution
Let's do this work in a few separate parts.

Mandatory checkpoint refactor #2305
Acceptance test refactor #2306
Move Block in State Checks to Downloaders #2307
Legacy Chain Check #2308

Alternatives
We don't need to do the legacy chain check until after the highest checkpoint in Zebra's checkpoint list. (Regardless of Zebra's checkpoint config.) But it's easier to test if we do it as early as possible.
We could:

automatically delete the database (like #1213)
drop existing Zebra services and create new ones
automatically shutdown and restart any running Zebra services
exec zebrad using Unix or Windows process APIs

This might not be possible on Windows, it could leave some resources open, and we'd need to guard against multiple restarts.
Related Work
This change is part of ZIP-200 and #337.
These tickets might also be related:

Design and implement graceful shutdown for Zebra #1678
Interrupt handler does not work when a blocking task is running #1351

Re-adding this to NU5, because the longer NU5 timelines make it more likely that outdated deployed Zebra nodes will pass NU5 activation, but not have the activation heights set.

This was closed by ticket #2308 and PR #2366.


[Feature Request] Stable/sticky link hints

When performing repeated actions using link hints on a single page, it would be really nice if they didn't change (even when the page changes). This may not be possible in all cases but it would be nice if assigned hints could somehow stick to elements.

It's possible but tricky, potentially performance limiting, and would take a long time to implement.
Finding and rendering hints is already surprisingly complicated. Hintable elements (and their characters) are a function of the document and the current viewport. The document changes as elements are added, removed, and modified in interactive websites. The viewport changes whenever the user scrolls or resizes the window.

My thinking was:

Add a hidden attribute to all hinted elements that stores previously assigned hints.
Have a function that spits out the next hint.

The algorithm would:

Check if the node already has an old hint. If so, use that.
Otherwise, generate a new hint.

However, this would mean that hints wouldn't be reusable (so they might get long if a page changes frequently).

Other options:
A) Extract link hints from a consistent hash of the link target URL.
B) Attempt to build a heuristic to extract link hints from the relative URL, so if I'm on github.com/lusakasa/saka-key/ the link to github.com/lusakasa/saka-key/issues should be iss or so...


Rfc 441 compliance

Verifiers, provers choose credentials and vet presentations deterministically as per RFC 441.

Codecov Report

Merging #849 (4a65946) into master (3d3196c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #849   +/-   ##
=======================================
  Coverage   98.97%   98.97%
=======================================
  Files         293      293
  Lines       15757    15812   +55
=======================================
+ Hits        15595    15650   +55
  Misses        162      162


Automator: update istio/client-go@master dependency in istio/istio@master

Generated by Automator - 2024-02-01T21:56:13+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
99fbe7af0e0e5badbe7077d63fa3fce8874d8257
link
unknown
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-istiodremote-mc


Add back querystring to proposal form

好像不小心刪到了。
這個 form 要有 full path，才能保留 query string 給 list view。
原本就有的，只是把它加回去。

Current coverage is 78.67%

Merging #178 into master will not affect coverage as of 67ed601

@@            master    #178   diff @@
======================================
  Files           40      40
  Stmts         1266    1266
  Branches         0       0
  Methods          0       0
======================================
  Hit            996     996
  Partial          0       0
  Missed         270     270

Review entire Coverage Diff as of 67ed601

Powered by Codecov. Updated on successful CI builds.

奇怪，可是我測試好像沒有問題？

我剛去讀了 HTML spec，好像 empty action 就是沿用網址（包含 query string）沒錯，所以符合標準的瀏覽器應該不會有問題。算了那就不改了。


Install pkgconfig files into gRPC_INSTALL_LIBDIR (#24512)

Fixes #24512
Instead of installing pkgconfig files into hard coded lib/pkgconfig path, use gRPC_INSTALL_LIBDIR instead.
Useful for distributions using e.g. lib64 instead of lib.
This patch was taken from the openSUSE project where it is already used.

@nicolasnoble

Rebased onto current master, any progress on merging?

@nicolasnoble Any progress? :)


Mbasiuk/tdi 39100 backport couchbase 651

What is the current behavior? (You can also link to an open issue here)
This component will be present in master branch(7.0.1) but not in 6.5.1
What is the new behavior?
Migrate Couchbase to 6.5.1
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[x] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:
Sonar results

Pull request test result: success :star:
Sonar results

Pull request test result: success :star:
Sonar results

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: success :star:
Sonar results


Adds support to dependentRequired and dependentSchemas

Adds dependentRequired and dependentSchemas support since the dependencies was split into these keys
https://json-schema.org/draft/2019-09/release-notes.html
Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

Related issue: https://github.com/fastify/fluent-json-schema/issues/135

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 10 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 99.568%

Totals

Change from base Build<PHONE_NUMBER>:
0.009%

Covered Lines:
420

Relevant Lines:
420

💛  - Coveralls

hey @joaopedrocampos thank you for this.
Could you update the DOC as well by running yarn doc? 🙏

Hey @aboutlo! Thanks for the feedback 🙏

Could you update the DOC as well by running yarn doc? 🙏

I actually already did it, the API.md changes were generated from the command. Should I do something else?

sorry my bad, I missed the API.md 👻


[WFLY-18855] MicroProfile spec support table is out of date

https://issues.redhat.com/browse/WFLY-18855
Remove entry for MP Metrics
Add entry for MP Telemetry
Update versions for other specs

Thanks @jasondlee


[Feature] Using selects for fields on recurring donation form

@dimitur2204 I do agree that we need a better approach for selecting a person.
Let's use the current <PersonSelect /> for this task and fork the topic in another issue so we can do it properly on all locations at once.
It can be done within the PersonSelect component without involving the recurring donations context. It can be realized as a Button that opens a Modal for finding the person you need by typing their name, etc
Originally posted by @kachar in https://github.com/podkrepi-bg/frontend/issues/708#issuecomment-1105491940

What do you think about a Material UI Autocomplete or a normal Select or should I improvise with a Modal with a search bar to search the user that I think would look good?
This is the Autocomplete

@dimitur2204 In fact we may need both for different scenarios. A separate dialog will help us add additional controls if we want to be sure that this person is the one we're looking for. It may display latest campaigns of this user or similar extra info.
One scenario would be to have this autocomplete in a modal dialog.
Do you think the autocomplete would be sufficient by itself?

@dimitur2204 In fact we may need both for different scenarios. A separate dialog will help us add additional controls if we want to be sure that this person is the one we're looking for. It may display latest campaigns of this user or similar extra info like ID, email or others.
One scenario would be to have this autocomplete in a modal dialog.
Do you think the autocomplete would be sufficient by itself?

Okay I got it. I will then implement something like a PersonSelectModal which will have a Select at the top showing the first and last name and then when you select a person it would show more info about him. And then you would click confirm to actually select the person.
Should we have a similar functionality for vaults?

That sounds great
If you mean if we're going to use the PersonSelectModal component in vault edit form, then yes.

Fixed with https://github.com/podkrepi-bg/frontend/pull/728


Added a button to link docs to appPage

Fixes Issue
Closes #313
Changes proposed
Add a button that on click redirects to appPage in the docs section of the website.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

A fix for the failing test is in main. So when merging main into this, the tests should pass again

sorry, can you explain a bit more why the test failed, i'm a newbie.

To be honest, I'm not 100% sure because the tests weren't changed. I think it relates to a self-closing popup, but its just a guess


[match] Add support for Developer ID certificates from G2 Sub-CA

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
Developer ID certificates can now be generated using one of two different intermediary CAs, and Fastlane currently doesn’t support the newer G2 Sub-CA. Following is the description from the certification creation page on the Apple Developer portal when selecting "Developer ID Application":

Certificates issued from the Developer ID G2 intermediary certificate authority (Sub-CA) are supported by Xcode 11.4.1 or later. If you need to sign software for distribution on an earlier release, you can create a certificate associated to the previous Sub-CA and turn off Automatic Signing in Xcode. Any certificates created after Feb 01, 2022 and associated to the previous Sub-CA will expire on Feb 01, 2027.

Description

Adds a new DEVELOPER_ID_APPLICATION_G2 certificate type
Updates match and sigh to find Developer ID certificates using this new type
Updates cert to generate Developer ID certificates using this new type

I used match to generate and find a new Developer ID certificate.

Thank you for posting that it could be just the thing to give inspiration to someone who needs it! Keep up the great work!

Thanks! Btw. the CLA is signed.

Thanks for your feedback @joshdholtz!
Could you give me a hint how to test this with the ASC API? It’s a bit tricky to test this as you can only have one Developer ID cert, and I think you can’t even revoke it. Any guidance how to deal with this would be appreciated.


Use API v3 /account endpoint

With the shiny new allow_if_user hook #42 added I'd like to check for two_factor_authentication but it's not returned on the v2 /account endpoint.
cc @jacobian

Seems okay to modify this?
https://github.com/heroku/heroku-bouncer/blob/master/lib/heroku/bouncer/middleware.rb#L187-L193
But if the fields change significantly, it might break people's apps.

AFAICT, /account is also the V3 endpoint, so is this a matter of setting a particular header?

@wuputah that's right—specifically the Accept header at https://github.com/heroku/heroku-bouncer/blob/master/lib/heroku/bouncer/middleware.rb#L194 would need to be application/vnd.heroku+json; version=3 instead.


fiberplane-charts: Split charts lib

Description
This extracts the "ACG" (abstract chart generator) to become a standalone component inside fiberplane-charts. Both the MetricsChart and the SparkChart call the ACG, while the internal CoreChart has been refactored to render abstract charts instead.
This PR also reduces our dependency on VisX slightly, although I only used direct SVG components where doing so was low hanging fruit.
TODO:

[x] Make sure dragging along the X axis works
[x] Fix positioning of bar charts
[x] Fix percentage stacked charts
[x] Fix tooltips

Implements RFC 104.
Checklist

- [ ] The changes have been tested to be backwards compatible.
- [ ] The OpenAPI schema and generated client have been updated.
- [ ] New models module has been added to api generator xtask

[x] New types/fields are well-documented and annotated.
[ ] The CHANGELOG is updated.

Please link any related PRs in other repositories that depend on this:

[ ] Monofiber: https://github.com/fiberplane/monofiber/pull/63

After merging, please merge related PRs ASAP, so others don't get blocked.

I think I've addressed all the feedback thus far!


[DC-3337] Add a cleaning rule to update the src_id values in fitbit tables from site maskings table

Needs more work


chore(install): add validation rules for older versions of windows

https://newrelic.atlassian.net/browse/VIRTUOSO-640


Feature request: Could the plugin recommend "import"s for inferred types?

Try opening this minimal demo project https://github.com/mcclure/ts-hello-bug/tree/editor-demo in Sublime Text, and opening the file 'src/index.tsx'. index.tsx imports a function demoFunction() from 'dependencyOne.ts' and calls it. If I move the cursor over the let x in 'index.tsx', it says:
let x : DemoClass, Line 3, Column 5

Here is a problem: what is DemoClass? I didn't import any such class. If I try to say let x : DemoClass = demoFunction(), I will get error TS2304: Cannot find name 'DemoClass'., because I didn't import it. (Since I wrote the demo project myself, I know the answer: 'dependencyOne.ts' imported it from 'dependencyTwo.ts'. But let's say I don't know that.)
If I cmd-P and look at the features of the TypeScript plugin, I see it exposes a useful function: "GoTo Type Definition". If I select this option, it takes me to class DemoClass in 'dependencyTwo.ts'. Awesome, problem solved! I need to import { DemoClass } from "./dependencyTwo"`.
But consider a slightly more complicated example: What if DemoClass had been imported from a library? In this case the existing tools are less helpful. Try out this other demo project https://github.com/mcclure/ts-hello/tree/stable which is also minimal, but this one has Preact in package.json. Try npm installing, then opening 'src/index.tsx' and adding the line:
let test =
Test

If I mouse over test it says "let test : h.JSX.Element". This is a little odder. If I "GoTo Type Definition" this, I get:
interface Element extends preact.VNode<any> {}

inside namespace JSXInternal, in jsx.d.ts. That's not actionable the way finding 'dependencyTwo.ts' was. What I want to do here, probably, is import { JSX } from "preact"; and then use the type JSX.Element. But I wouldn't figure this out by using the Sublime plugin.
I'm not sure these are the best examples. But this is a situation I did find myself in twice this weekend: There is a symbol or value I have access to by writing code. The Sublime plugin can successfully infer its type. I want to assign the value to a variable, and I want to write a type signature for that variable. But the type is not in scope, I have no idea what to import to get it in scope, and the plugin can't help me because the type is something deep inside a spaghetti of import exports in 'node_modules'.
Expected behavior/suggestion: In both the cases above, I think the plugin could have figured out the correct import line and suggested it to me. In the first case, it could have followed the import from './dependencyTwo' and detected I can import './dependencyTwo' also. In the second case, it could have noticed the JSXInternal namespace that h import exports is also import exported by the "preact" node_module (which I am already importing other symbols from) and suggested that.
(The second example might be a harder case because it would require the plugin to speculate about different ways JSXInternal could get into scope; but possibly if there are several sensible "import" routes, the plugin could show a list. Also I think the plugin has this speculation logic already, because if I type let test : JSX.Element without importing JSX, then use the mysterious "TypeScript: Request Code Fixes" feature of the plugin, it magically adds , JSX to my "import JSX" line up top (!))
I am using v3.7.3 to test.

I'm looking for the same thing. It's definitely possible to have automatic imports. The Webstorm IDE does this. It indexes projects and adds imports as you type or uses alt-enter to insert them manually.
It can be more difficult with compiled libraries because this can impact performance if it has to find references inside large compiled files.
As well as imports, it would be useful to add Typescript reference links automatically too.
https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html
Since compiled libraries tend not to change, those can be indexed manually and project files can be indexed when files are modified with an option to rebuild the project.
With an index built, whenever a class is referenced and there's no equivalent import statement, it can automatically add it. If there's more than one, it can let the editor flag the keyword and then have a menu item to "add import reference" and popup a list of choices of which to use.
There's an ImportHelper plugin for Sublime that's supposed to do this sort of thing but it gives errors for me:
https://github.com/unlight/sublime-import-helper


In generated rust code, i32 to enum type conversion using from_i32() is deprecated

Report
If there is an enum type in protobuf message, there is a deprecated issue in converting i32 to the enum in generated rust code like below.

message.proto

enum MyEnum {
  A = 0;
  B = 1;
}

rust code

let my_enum: MyEnum = MyEnum::from_i32(i32_enum).unwrap();

compiler warning log:

warning: use of deprecated associated function `messages::my_app::MyEnum::from_i32`: Use the TryFrom<i32> implementation instead

This could be fixed by upgrading the prost package to v0.12.6 which is the latest one.
See the related fix on the prost.
Steps to Reproduce
N/A
System Information
N/A

Great, there will be a new version soon with this fix applied :)


Inject github tokens to docker build and test

For external PRs just use the automatic github actions token
as the scope is already restricted.
Change-type: patch
Signed-off-by: Kyle Harding<EMAIL_ADDRESS>

What this PR needs is some aliases to resolve trusted vs untrusted tokens.
GetTokenForUntrusted would return either a generated app token or FLOWZONE_TOKEN for internal PRs, and the automatic GITHUB_TOKEN for external PRs.
GetTokenForTrusted would return either a generated app token or FLOWZONE_TOKEN for both internal and external PRs.
I'll add these on my next pass and install them where appropriate.

I self-certify!


Randomly change the background angle when "a" is pressed

Does what it says on the tin - randomly change the angle of moving particles when you press "a".

@md678685 You are failing a lint...

@mark-i-m it's not the PR, it's the base of the PR. Don't worry about it.


Support "javax.annotation.concurrent.Immutable" for immutability checks

I have a lot of code here, that uses "javax.annotation.concurrent.Immutable" to annotate classes that are - you may have guessed it - immutable.
Unfortunatley error-prone-compiler doesn't seem to recognize those annotations.
I'd love to see support for "javax.annotation.concurrent.Immutable". And maybe support all annotations that are called "Immutable". Independent from the package they are located in...

+1

+1


testing release

Run Dataflow PortabilityApi ValidatesRunner with Java 11

Run Java examples on Dataflow with Java 11

Run Java examples on Dataflow with Java 11

Run Dataflow PortabilityApi ValidatesRunner with Java 11

Dataflow Runner Nexmark Tests

Direct Runner Nexmark Tests

Flink Runner Nexmark Tests

Run SQL PostCommit

Run Java Flink PortableValidatesRunner Batch

Run Dataflow PortabilityApi ValidatesRunner with Java 11


Validate tls-sni domain authorization linked service port

Fixes #3128

And technically you could also be exposing the TLS service on a different non-443 port, if you have some external loadbalancer that's mapping it to port :443.
Dunno if this needs some kind of override flag for the validation check?

Maybe a better way to validate this would be in the GridCertificates::RequestCertificate, similarly to how it's done for dns-01 challenges: have the server connect to the authorized domain on port :443

@jnummelin PTAL

Maybe a better way to validate this would be in the GridCertificates::RequestCertificate, similarly to how it's done for dns-01 challenges: have the server connect to the authorized domain on port :443

I can also take a go at implementing this method of external validation... the only issue would be if the server is unable to connect to the external domain for whatever reason.

I can also take a go at implementing this method of external validation... the only issue would be if the server is unable to connect to the external domain for whatever reason.

I don't think we can ever make it 100% reliable given how external things can influence, so maybe some override/force flag would make sense.

Maybe a better way to validate this would be in the GridCertificates::RequestCertificate, similarly to how it's done for dns-01 challenges: have the server connect to the authorized domain on port :443

I can also take a go at implementing this method of external validation... the only issue would be if the server is unable to connect to the external domain for whatever reason.

Implemented in #3152... OTOH that might be a useless approach, because the ACME API will already return similar errors... they're maybe just a bit terse.

@SpComb is this still going to 1.4.3?

Bumping from 1.4.3 to 1.5.0 unless someone convinces me that we can't release 1.4.3 without this.
I haven't had a chance to actually test the validation here yet.


Moved (bigger) first line on the screen

Hi,
why I see the first line bigger or moved (only in some themes - alien, night, nemo)? Like on this picture: https://scontent-ams3-1.xx.fbcdn.net/v/t1.0-9/50549186_2056416067779937_8128424365881556992_o.jpg?_nc_cat=106&_nc_ht=scontent-ams3-1.xx&oh=2969e48226e8bfb159bf9cb24b792fbc&oe=5CB850C5
Thank you.

Hi, when I moved tab view below by 20px, then It is OK. The first 20px is ok too. I don't know why.


figure out which backends to support

pandas
polars
dask?
???
maybe things that work directly on databases? test with sqlite?

document that

document that

pandas + dask seem to be compatible, found nothing else.

documented in 986a97162f3c98880b9a1940b6ebf32c63415f77


Apply the TK hook config to the test instances too

Previously the jetty testutils service instances' configs were only
adjusted by process-config!, but the actual server's config was also
adjusted by hook-tk-parse-config-data.  Change it so that
adjust-tk-config is applied in both cases.
Doing so exposes a bug -- a [global] url-prefix setting with a relative
path like "foo" will prevent the server from responding on /foo.  That's
because add-web-routing-config (via the tk hook) wasn't normalizing the
url-prefix before stashing it in in the web-router-service config.  To
fix that, normalize the url-prefix in add-web-routing-config.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/335/

@pljenkinsro retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/340/


Server1

Current coverage is 61.18%

Merging #27 into master will decrease coverage by -7.45% as of d8fe620

@@            master     #27   diff @@
======================================
  Files           18      21     +3
  Stmts          271     304    +33
  Branches        47      52     +5
  Methods          0       0
======================================
  Hit            186     186
  Partial         19      19
- Missed          66      99    +33

Review entire Coverage Diff as of d8fe620

Powered by Codecov. Updated on successful CI builds.


AUI-2112

Hey @thiago-rocha,
Attached is an update for http://issues.liferay.com/browse/AUI-2112.
Please let me know if you have any questions. Thanks!

Just started reviewing :) :octocat: Sent from GH.

Pull request submitted to https://github.com/mairatma/alloy-ui/pull/337. :octocat: Sent from GH.


Base64 encoding should be URL safe and non-padded

We have had issues sending padded, non-URL safe (but encoded) base 64 to the snowplow server. Inspection of the scala source seems to indicate that it wants b64 to be the URL-Safe version and with no == padding.
I have a local branch with this fix and tested it against our instances.  I will PR it soon.

Hi @loufranco - awesome. Scheduling into 0.3.2...

BTW you are correct - we must use URL-safe Base64 for passing values on GET querystrings.

Is it ok to do the patch at the point of b64 (that would happen for GET and POST)

Yes it's totally fine for all Base64 encoding to be URL-safe (I think that's what you're asking)

That's what other trackers do

@alexanderdean The protocol spec does not specify that the base64 encoding has to be url safe, no wrap, and no padding. I only figured it out because I hunted down the parser code in the enricher.

I've updated the TP to make it clear it has to be URL-safe: https://github.com/snowplow/snowplow/wiki/snowplow-tracker-protocol

@alexanderdean thank you!

No worries - sorry for the pain!


Omit geometry in WFS transaction if user has insufficient permissions

does not transmit geometry when user has insufficient permissions

@terrestris/devs Please review

:tada: This PR is included in version 6.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Blur event not setting date correctly when allowInput true

When using the allowInput functionality alongside the enableTime flag, inputting dates directly no longer works. To reproduce:

go to the fiddle
select a date/time
close the picker
click on the input again
type in a new date
click another part of the page
The picker will revert back to the previous value

When using enableTime: false, clicking on another part of the page would keep the newly input date.
Oddly, if you press enter or tab instead of just clicking out of the calendar, the Date is updated correctly. Did some digging to see what kind of issue it might be, and I think it may have to do with the blur event triggering twice, the first time setting the input field to what's currently selected in the picker widget and the second time it updates the internal date based on the input value (which is now whatever was selected in the picker). No idea why this only becomes a problem when using date+time.
https://jsfiddle.net/dv2qbeyp/
Your Environment

flatpickr version used: master
Browser name and version: Google Chrome (87.0.4280.141)
OS and version: macOS Big Sur (11.1)

@chmln Submitted a PR to fix this. Can you please review that?


Enhanced the hover effect of navbar buttons

Fixes Issue🛠

Closes #620
Description👨💻
I have enhanced the hover effect of nav items which is looking good in light mode as well as dark mode
Type of change📄

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳 @Manishar55


wurst fails very ungracefully when used with reign of chaos map files

If you try to compile a map written in wurst, but the map file is w3m rather than w3x, it produces very obscure errors about missing mpq objects.

Yes, it is mentioned in the manual.

Indeed, it's also repeated that it's necessary in your tutorials.
Still a bug.
Cokemonkey11 opened this 1 minute ago

I agree that it is a bug. If I remember correctly, there was something strange about it. There was a reason why we said that we just support w3x. I will have to look into it again.

In the worst case, providing a useful error, for example

Wurst only supports frozen throne map files (.w3x)

would at least prevent issues like #334 :+1:


how to speical consumer to special upstream

Summary
i want speical consumer use special upstream, did it support?
Steps To Reproduce

Additional Details & Logs

Kong version (0.13)

ngx.balancer.set_current_peer is support in plugin


Add atomic intrinsics

We need this when optimizing some locks' implementation, but using inline assembly will stop some optimizations. For example, if we use inline assembly, the compiler doesn't know lr.w will sign-extend the result.
ARM provides similar intrinsics like __builtin_arm_ldaex.

I don't know if we should add intrinsics for AMO instructions as we have some "standard" C builtins for AMO.

Ping. :-)


On Android Working as a toast only !

HI,
Hope you are doing great!!
I have tried this widget and found on android its not working as expected. Its  working as a toast only.
Please provide me the steps to make it work for android. Any help will be appreciated.
Regards,

Are you passing a view ?

@harsukhbir
As android works with Views you need to pass a view variable;
Example:
Alloy.Globals.notify.show({message: 'MyMessage', duration: 2500, view:$.myMainView});

Thanks for your responses !
Yes Its working in the view but not When I am using the Tab group view its not working for me. Do you have any idea to use in the TabBar group?

What's wrong with TabBar ?

$ not defined.

Are you sure that is not a bug in your code?
Could you paste a snippet?

Now I am trying with tabGroup id. If not work then I will share

knockApp.notifier.show
({
message: 'Recived new message form '+data.userId+' : '+data.text,
view: $.tabs,  //view: $.mainScreen also not worked
icon: 'appicon.png',
pushForce: 10,
duration: 2500,
elasticity: 0.5, // iOS7+ only
pushForce: 30, // iOS7+ only
usePhysicsEngine: true, // disable if you don't want on iOS7+
animationDuration: 200,
});

In which context are you calling this code?
In the Alloy controller?
Are you sure that $ is available, try to debug it.

How are you creating the tabView?
var tabView = Ti.UI.createTabGroup(...);
knockApp.notifier.show
({
message: 'Recived new message form '+data.userId+' : '+data.text,
view: tabView, //view
icon: 'appicon.png',
pushForce: 10,
duration: 2500,
elasticity: 0.5, // iOS7+ only
pushForce: 30, // iOS7+ only
usePhysicsEngine: true, // disable if you don't want on iOS7+
animationDuration: 200,
});

OR in Alloy?
xml
<TabGroup id="myTabGroup">
...
</TabGroup>

js
knockApp.notifier.show
({
message: 'Recived new message form '+data.userId+' : '+data.text,
view: $.myTabGroup, //view
icon: 'appicon.png',
pushForce: 10,
duration: 2500,
elasticity: 0.5, // iOS7+ only
pushForce: 30, // iOS7+ only
usePhysicsEngine: true, // disable if you don't want on iOS7+
animationDuration: 200,
});

I have created my tabView in the Alloy. The problem is I am using js files for some reasons in the lib folder.
I declared ORTC handler in the Alloy for global use and I am trying to access tab group in this js file.
ortcHandler: require('ortcHandler'),

You have to pass the controller to access to $

Thanks for your kind help.
I am very new in Titanium. Could you paste a snippet for how to pass controller in js.
Thanks in Advance

In the controller file, you have to reference the $ variable to the function that uses it.
controller.js
var lib = require('external');
lib.myFunction({ controller: $ });

external.js
exports.myFunction = function(obj) {
   Notifier.show({ view: obj.controller.getView() });
};

Not sur if this helps... but i use my notifications in this way
alloy.js
Alloy.Globals.notify = Alloy.createWidget('com.caffeinalab.titanium.notifications');

index.js
Ti.App.addEventListener('showAlert', function(e){
	OS_IOS ? Alloy.Globals.notify.show({message: e.message, duration: e.duration}):Alloy.Globals.notify.show({message: e.message, duration: e.duration, view:e.view});
});

anyController.js
Ti.App.fireEvent('showAlert', {message:'Loading...', duration: 2500, view:$.myView});

This works for iOS and Android.

Also i pass my views in this method
controller.js
var someCommonJS = require('someCommonJS');
someCommonJS.myFunction('SomeString', $myView);

someCommonJS.js
exports.myFunction = function(myString, myView)
{
      Ti.App.fireEvent('showAlert', {message: myString, duration: 2500, view:myView});
};

Hope it helps :)

So, does it works?

Hi Thanks for your valuable time. Yes Its worked for me. Sorry I was stuck in some personal issues so unable to update the git.
Thanks guys for your help and time


Add retries to rvm install in travis

This has been failing a lot lately, maybe retrying will help.
Signed-off-by: Steven Danna<EMAIL_ADDRESS>

I was also considering caching the .rvm folder but that explodes the cache to 1GB.  Hopefully the retries will make the tests a bit less flakey.


Tlint command not found.

Hi,
I am new to laravel, So I apologise for the silly question.
I have installed this package both globally and locally, When I try and run tlint in my terminal I get
-bash: tlint: command not found
Would you be able to advise in where I am going wrong.
Thanks,

Hey @Gazzza20 can you response with the output from running the command composer global info?

tightenco/tlint           3.0.12  Tighten linter for Laravel conventions

Is the global composer bin directory in your path?

Sorry, Do you mean the path I run in the terminal?
Really am sorry for being a pain.

https://stackoverflow.com/questions/25373188/how-to-place-the-composer-vendor-bin-directory-in-your-path

Ok, I will give that a read.

Or in video form: https://laracasts.com/series/setup-a-mac-dev-machine-from-scratch/episodes/6

Ok, I will give that a read. I can get results if I run ~/.composer/vendor/tightenco/tlint/bin/tlint. The main cause of my issue is I can't seem to get it to run with gitlab CI


[jvm-packages] Fix build for JVM packages

Fix the error

[WARNING] JAR will be empty - no content was marked for inclusion!
Building jar: /workspace/jvm-packages/xgboost4j-gpu/target/xgboost4j-gpu_2.12-1.3.0-SNAPSHOT.jar
...
Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:3.0.2:jar (default-jar) on project
xgboost4j-gpu_2.12: You have to use a classifier to attach supplemental artifacts to the project instead of
replacing them

by adding the symlink for the source in xgboost4j-gpu directory.

Ensure that a single build command (mvn package) can build xgboost4j and xgboost4j-gpu simultaneously, with xgboost4j having CPU code and xgboost4j-gpu having GPU code.

Fix SNAPSHOT build on the master branch.

@wbo4958 @CodingCat Can you review?

Will try to find a way to associate GPU unit tests with xgboost4j-spark, to avoid error "xgboost not compiled with CUDA"


Add screenshots for web browser installer sections of docs

Currently, the /installation/ and /quickstart/ sections of the documentation do not have any screenshots of the web browser (GUI) installation process.
Adding screenshots will help readers confirm they are getting through the process successfully.

Closed via #563


minor change to enable separate listen / main accept&process loop

Idea behind this minor change is following. If we have a server that should accept multiple quic/http2 connections at the same time, then we can have a tcp connection by which we would negotiate udp port for quic, and then start quic server on that port. Client, in its turn, gets port and starts quic/http2 communication over that port. However, if listen & accept are in the same method, then there is a race condition, since udp is stateless. In order to avoid that, first we need to create listener, then communicate port back to client and after that start main accept & process loop for quic/http2 server.

I signed CLA.

I don't think I fully understand this change. You can already run multiple h2/quic connections at the same time today, and the QUIC per is advertised via the Alt-Svc header (in fact, this is how Chrome does QUIC discovery). Can you please help me see the use case where this mechanism doesn't work?

I have tried to server many clients on the same port at the same time and each client transfers somewhat big amount of data, and very often I get "tls handshake timeout", which is set up to be 30 seconds (I tried even 120 seconds). Amount of data is 128k+ (both client request & server response), amount of clients is 50+. Network latency is 150-200ms, packet loss ratio around 10%.

To me, this sounds more like a loss recovery problem. 10% packet loss is an awful lot, and quic-go is known to not perform optimally under those conditions. Rewriting the loss recovery has been on my todo list for a long time, but I didn't have the time for that yet.

Well, as a quick solution this works. I have tried to span a new port (quic server) per each 10 clients that are accessing server at the same time and it works.

I'm not a fan of hacks, especially not if they change the public API.


Yoctocolors

Missing benchmark for https://github.com/sindresorhus/yoctocolors

I don't think the author is going to support this library as something that is not just a joke, so I don't see a reason to include it in the benchmark. Also, yoctocolors is ESM only, something we need to fix in #45 first.

Curious what makes you think that's a joke? Doesn't seem funny if something claims to be faster, does it?


LCFS - Add fuel code date validation logic

Describe the task
Review the Fuel Code Logic in the compliance report to ensure that the system enforces the following rules:

A fuel code cannot be used if it is expired.
A fuel code cannot be used in the current reporting period if it does not become effective until a later period.

Purpose
To validate and enforce correct Fuel Code Logic in the compliance reporting system, ensuring that only valid fuel codes (approved and past effective date but before expiry date) are selectable. This ensures compliance with reporting standards and prevents the use of invalid fuel codes.
Acceptance Criteria

Confirm that expired fuel codes are unavailable for selection in the compliance report.
Ensure that fuel codes with an effective date later than the current reporting period are unavailable for selection.
Test the system to verify that only valid fuel codes are available based on their effective and expiry dates.
Ensure proper error messages or restrictions are in place if a user attempts to select an invalid fuel code.

Additional context
Previous addressed in card #969, but not fully implemented as I am able to add a fuel code with an effective date in the future to a compliance report.

Moved to block, we are not sure on the logic


Printing large pandas DataFrame clears iPython terminal

From<EMAIL_ADDRESS>on 2014-10-20T08:25:52Z
Spyder Version:  2.3.1
Python Version:  2.7.6
Qt Version    :  4.8.6, PyQt4 (API v2) 4.10.4 on Linux
pyflakes >=0.5.0:  0.8.1 (OK)
pep8 >=0.6      :  1.4.6 (OK)
IPython >=0.13  :  1.2.1 (OK)
pygments >=1.6  :  1.6 (OK)
pandas >=0.13.1 :  0.14.1 (OK)
sphinx >=0.6.6  :  1.2.2 (OK)
psutil >=0.3    :  1.2.1 (OK)
rope >=0.9.2    :  0.9.2 (OK)
matplotlib >=1.0:  1.3.1 (OK)
sympy >=0.7.0   :  <IP_ADDRESS> (OK)
pylint >=0.25   :  1.1.0 (OK)
What steps will reproduce the problem?
import pandas as pd
import numpy as np
rand = np.random.random([50, 40])
pd.DataFrame(rand)
I would expect to see a DataFrame pretty printed like the attached image. In fact what happens is that the screen clears and I see nothing but the next iPython In [.] prompt.
Some notes:

"tall" dataframes work fine:
rand = np.random.random([50,4])
pd.DataFrame(rand)

"wide" DataFrames work fine too:
rand = np.random.random([5,40])
pd.DataFrame(rand)

The normal Python prompt works fine

Attachment: Screenshot from 2014-10-20 14:21:54.png
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=2015

From ccordoba12 on 2014-10-20T10:57:31Z
Thanks for reporting. You are right: dataframes of certain sizes are not printed at all in our IPython consoles.
I already fixed this problem and will submit a patch soon.
Status: Accepted
Labels: Cat-IPythonConsole MS-v2.3.2

From ccordoba12 on 2014-10-20T10:57:59Z
This issue was closed by revision 1167b4fc4d7f .
Status: Fixed

From ccordoba12 on 2015-01-08T09:02:27Z
This issue was closed by revision bc7b19601511 .


New subworkflows for preparing Fasta files

cf TOLIT-702
There are two subworkflows: one for all Fasta files, and one specifically for repeat-masked files. Both have a README, a config file for testing, a demo workflow, and the actual subworkflow.
Example outputs:
$ nextflow run src/nf-core-pipeline/subworkflows/prepare_fasta/main.nf --fasta GCA_927399515.1.fa --outdir test_dir1
N E X T F L O W  ~  version 22.04.0
Launching `src/nf-core-pipeline/subworkflows/prepare_fasta/main.nf` [golden_swirles] DSL2 - revision: c5598b1304
executor >  local (3)
[2a/5d9881] process > PREPARE_FASTA:TABIX_BGZIP (GCA_927399515.1)                [100%] 1 of 1 ✔
[31/08bd84] process > PREPARE_FASTA:CUSTOM_GETCHROMSIZES (GCA_927399515.1.fa.gz) [100%] 1 of 1 ✔
[9b/f8757a] process > PREPARE_FASTA:SAMTOOLS_DICT (GCA_927399515.1.fa)           [100%] 1 of 1 ✔

$ tree test_dir1/
test_dir1/
├── GCA_927399515.1.fa.dict
├── GCA_927399515.1.fa.gz
├── GCA_927399515.1.fa.gz.fai
├── GCA_927399515.1.fa.gz.gzi
└── GCA_927399515.1.fa.gz.sizes

and
$ nextflow run src/nf-core-pipeline/subworkflows/prepare_repeat_masked_fasta/main.nf --fasta GCA_927399515.1.masked.ncbi.fa --outdir test_dir2
N E X T F L O W  ~  version 22.04.0
Launching `src/nf-core-pipeline/subworkflows/prepare_repeat_masked_fasta/main.nf` [lonely_boyd] DSL2 - revision: 301caee5ef
executor >  local (7)
[5f/7b3862] process > PREPARE_REPEAT_MASKED_FASTA:MASKING_TO_BED (GCA_927399515.1.masked.ncbi.fa)          [100%] 1 of 1 ✔
[84/b6cf80] process > PREPARE_REPEAT_MASKED_FASTA:TABIX_BGZIP_BED (GCA_927399515.1.masked.ncbi)            [100%] 1 of 1 ✔
[8d/8b2ab6] process > PREPARE_REPEAT_MASKED_FASTA:TABIX_TABIX_CSI (GCA_927399515.1.masked.ncbi)            [100%] 1 of 1 ✔
[47/158a8a] process > PREPARE_REPEAT_MASKED_FASTA:TABIX_TABIX_TBI (GCA_927399515.1.masked.ncbi)            [100%] 1 of 1 ✔
[72/b30679] process > PREPARE_REPEAT_MASKED_FASTA:TABIX_BGZIP_FASTA (GCA_927399515.1.masked.ncbi)          [100%] 1 of 1 ✔
[1b/235fd2] process > PREPARE_REPEAT_MASKED_FASTA:CUSTOM_GETCHROMSIZES (GCA_927399515.1.masked.ncbi.fa.gz) [100%] 1 of 1 ✔
[f1/6db403] process > PREPARE_REPEAT_MASKED_FASTA:SAMTOOLS_DICT (GCA_927399515.1.masked.ncbi.fa)           [100%] 1 of 1 ✔
$ tree test_dir2
test_dir2
├── GCA_927399515.1.masked.ncbi.bed
├── GCA_927399515.1.masked.ncbi.bed.gz
├── GCA_927399515.1.masked.ncbi.bed.gz.csi
├── GCA_927399515.1.masked.ncbi.bed.gz.tbi
├── GCA_927399515.1.masked.ncbi.fa.dict
├── GCA_927399515.1.masked.ncbi.fa.gz
├── GCA_927399515.1.masked.ncbi.fa.gz.fai
├── GCA_927399515.1.masked.ncbi.fa.gz.gzi
└── GCA_927399515.1.masked.ncbi.fa.gz.sizes

(typically the .bed wouldn't be published)
Initially they had a few differences (https://github.com/sanger-tol/insdcdownload/blob/main/subworkflows/local/prepare_genome.nf vs https://github.com/sanger-tol/insdcdownload/blob/main/subworkflows/local/prepare_repeats.nf ) but after a round of polishing, prepare_repeat_masked_fasta is essentially the same as prepare_fasta with additional modules to extract the BED file and index it.
I guess this means I could make prepare_repeat_masked_fasta call prepare_fasta ? That would make the installation instructions slightly more complex, and would introduce another depth of subworkflows (is that an issue ?)
Another idea might be to have a single workflow that always extracts the BED file, but then only indexes it if it's not empty ? There would be extra compute cost parsing the Fasta file, though.

You can call another subworkflow from within a subworkflow, it doesn't cause any problems. I do this in readmapping without issue.

@muffato Do you want to modify the structure before I review?

@priyanka-surana . Done. I've copied prepare_fasta into the prepare_repeat_masked_fasta subworkflow.
(I've left masking_to_bed as it is because I couldn't find any satisfying 2-word name)

Why do you need both subworkflows? Since prepare_fasta is being called from inside prepare_repeat_masked_fasta, maybe just combine the README and instructions. If someone wants just one, they can always piece it apart easily.
Suggestion on masking_to_bed: repeats_bed.nf since it creates a bed file for repeats, which are the masked regions.
Also consider shortening the name of prepare_repeat_masked_fasta, suggestion prepare_repeats since all the genome work is done in prepare_fasta and this adds additional repeat associated functionality. You can also rename prepare_fasta to prepare_genome to be more specific.

OK. I would do this:

rename masking_to_bed to repeats_bed
rename prepare_repeat_masked_fasta to prepare_repeats and remove the call to prepare_fasta from it, i.e. make it a subworkflow that only deals with the BED file. I'd prefer pipeline developers to take 2 subworkflows and be able to use these without modifications, rather than having just 1 subworkflow that needs to be edited.

Thank you ! Next PR will be making sanger-tol/insdcdownload use these subworkflows


network: physical and macvlan nictype MTU support

This exposes the network_phys_macvlan_mtu support in LXC for setting a boot time custom MTU on physical and macvlan nic device types and updates tests to expect the MTU to be changed if that feature is present.
It also modifies LXD to restore the MTU and MAC of physical devices if changed by the container's settings or from within the container.
Depends on https://github.com/lxc/lxc/pull/2985

jenkins: test this please

@stgraber this is ready for review now.
The original issue you reported is fixed, that of MTU for vlan passthrough not working.
This also fixes several other issues related to MTU restore once a container is shutdown.
There is an outstanding issue that I have been unable to fix, that is the scenario where a new physical device is hotplugged into a container, has its MTU modified and then the container is shutdown.
Right now I can't figure out a way to restore the MTU after the container has stopped, this will need more discussion with @brauner on the best way to achieve this.

jenkins: test this please

@stgraber as it stands, this PR utilises the existing (but renamed) OnPostStop() hook to more accurately reflect when the hook is actually run.
This allows us to restore MTU and MAC for physical passthrough in situations where the devices are hot-unplugged or where LXC knows about them at boot time . However to cover all common scenarios (specifically the scenario where a device is hotplugged and then container is shutdown) I propose adding a new hook to LXD called OnStop() which would be run by LXC's lxc.hook.stop which would then be able to switch into the container's network namespace (only) and move the network devices back to the host (as well as restoring their original config) before LXC destroy's the namespace and the kernel moves them back (or deletes them in the case of dummy devices).
I propose the OnStop hook should iterate through each nic and then attempt to find the device in the container's netns using volatile.eth1.name at which point it can run nsenter --net=${LXC_NET_NS} ip link set ${NAME} netns ${LXD_PID} to move the container back to LXD's netns and then restore it's original name, MTU, MAC etc from the other volatile keys added in this PR.
Are you happy with this general approach?

@stgraber I've implemented the physical device MTU/MAC restore based on my proposed approach above.

jenkins: test this please

Needs rebasing

jenkins: test this please

@stgraber this has been re-implemented using the forknet approach you suggested.
The new forknet command removes IP addresses from interface and brings the interface down before moving it back to the container under its original name.
Regarding the check for whether the ifindex has changed inside the container, I believe this would require me to add a new forknet command to inspect the ifindex of the interface inside the container at boot and at hotplug time so that it can be recorded in volatile data. This would likely need either to execute the network up hook for physical devices too, or add a new function for lxc.hook.start-host as the current OnStart() function is called as lxc.hook.pre-start before networking is setup.
Is this something you would want to do, or are the current protections sufficient? (this brings it inline with hot unplugging devices).

@stgraber I did some more research into this, and I think if it is acceptable to add an OnStartHost() hook to be run as lxc.hook.start-host then I should be able to use c.networkState() (easily extended to gather ifindex) in order to snapshot all boot time interface's ifindexes in a single hit. I can then store in volatile data associated to the device name (using the device's m["name"] property which is generated by LXD and passed into LXC's name interface property to match them up to the container side ifindexes). Then at shutdown and interface removal time I can check whether the existing ifindex inside the container has changed.

@brauner could you take a look at this one too? Just a quick glance through at the bits that look interesting to you is fine.

@stgraber thanks will make those changes.
I was thinking about how we can avoid the use of LXC's hooks calling into LXD.
This PR introduces a new hook called OnStopNS which is utilises LXC's lxc.hook.stop hook.
The key reason I had to introduce this new hook was so that devices can be removed from a container and renamed on the host without relying on the OS to do it, in situations where LXC doesn't know about it (i.e when a device is hot plugged after start).
https://github.com/lxc/lxd/pull/5745/files#diff-082fd0ef6645e509accb07d6a535fee6R2795
This is also why I created detachInterfaceRename() and extended forknet to allow it to enter a container's netns and move the device back to LXD's netns.
https://github.com/lxc/lxd/pull/5745/files#diff-082fd0ef6645e509accb07d6a535fee6R2758
I was thinking that we could avoid both of these steps and move the rest of the restoration code to the existing OnStop() hook if we could rely on LXC to detach and rename hot-plugged devices on shutdown.
LXD uses go-lxc's AttachInterface() function to hot-plug devices after start.
https://github.com/lxc/lxd/blob/f5bec32c9c9446561ac0a24c75cbda8b04e442d2/lxd/container_lxc.go#L8322
This in turn calls LXC's do_lxcapi_attach_interface() https://github.com/lxc/lxc/blob/e9ab177d3f7029db7a59f5097917d3defe84c28e/src/lxc/lxccontainer.c#L4741
Anyway, I was thinking if we could get do_lxcapi_attach_interface() to record somewhere any devices that were hot-plugged (just original host name and destination name at a minimal, but could be extended to also read original mtu and mac for restoration by LXC) then we could update LXC to detach hot-plugged devices when the container is shutdown.
This could just be a text file somewhere (each line being something like origName newName mtu mac etc), or perhaps it could communicate with the persistent LXC process and update the state internally?
@brauner is this something that could work?

@brauner @stgraber requested changes made. Thanks

jenkins: test this please

@stgraber thanks will make those changes.
I was thinking about how we can avoid the use of LXC's hooks calling into LXD.
This PR introduces a new hook called OnStopNS which is utilises LXC's lxc.hook.stop hook.
The key reason I had to introduce this new hook was so that devices can be removed from a container and renamed on the host without relying on the OS to do it, in situations where LXC doesn't know about it (i.e when a device is hot plugged after start).
https://github.com/lxc/lxd/pull/5745/files#diff-082fd0ef6645e509accb07d6a535fee6R2795
This is also why I created detachInterfaceRename() and extended forknet to allow it to enter a container's netns and move the device back to LXD's netns.
https://github.com/lxc/lxd/pull/5745/files#diff-082fd0ef6645e509accb07d6a535fee6R2758
I was thinking that we could avoid both of these steps and move the rest of the restoration code to the existing OnStop() hook if we could rely on LXC to detach and rename hot-plugged devices on shutdown.
LXD uses go-lxc's AttachInterface() function to hot-plug devices after start.
https://github.com/lxc/lxd/blob/f5bec32c9c9446561ac0a24c75cbda8b04e442d2/lxd/container_lxc.go#L8322
This in turn calls LXC's do_lxcapi_attach_interface() https://github.com/lxc/lxc/blob/e9ab177d3f7029db7a59f5097917d3defe84c28e/src/lxc/lxccontainer.c#L4741
Anyway, I was thinking if we could get do_lxcapi_attach_interface() to record somewhere any devices that were hot-plugged (just original host name and destination name at a minimal, but could be extended to also read original mtu and mac for restoration by LXC) then we could update LXC to detach hot-plugged devices when the container is shutdown.
This could just be a text file somewhere (each line being something like origName newName mtu mac etc), or perhaps it could communicate with the persistent LXC process and update the state internally?

No text files please. It would likely mean adding new api helpers to liblxc as the current functions are unsuited. I have discussed and suggested something like this with @stgraber already about 1 year ago. Might be worth bringing up again.


Quilt/Fabric crash upon joining world

When using quilt or fabric, hexcasting seems to crash when joining a world.

hexcasting-fabric-1.18.2-0.9.0
paucal-fabric-1.18.2-0.4.7
Patchouli-1.18.2-70-FABRIC
fabric-language-kotlin-1.8.0+kotlin.1.7.0

fabric-loader-0.14.8-1.18.2 + fabric-api-0.56.1+1.18.2
quilt-loader 0.17.0-1.18.2 + qsl-1.1.0-beta.17_qfapi-1.0.0-beta.19_fapi-0.55.1_mc-1.18.2

Crash reports:
Fabric: https://pastebin.com/BE90ED6J
Quilt: https://pastebin.com/kfW1kN4e

Duplicate of #138 (or not technically a duplicate, but the same problem)

frogchamp, thanks

Still getting this with the latest dev build, even though #138 was marked as closed in a previous commit.

hexcasting-fabric-1.18.2-0.9.0-pre-329
paucal-fabric-1.18.2-0.4.7
Patchouli-1.18.2-70-FABRIC
fabric-language-kotlin-1.8.0+kotlin.1.7.0

fabric-loader-0.14.8-1.18.2 + fabric-api-0.56.1+1.18.2
quilt-loader 0.17.0-1.18.2 + qsl-1.1.0-beta.19_qfapi-1.0.0-beta.22_fapi-0.56.0_mc-1.18.2

Crash reports:
Fabric: https://pastebin.com/iX82SJ5i
Quilt: https://pastebin.com/S5j85niR
Also running into an issue i think is related: When i try to join my main world (with a bunch of other mods), it freezes (not crashes) on 0% loading. It still spat out a crashlog, here it is: https://pastebin.com/ym6En5U8

This is a problem with our JiJ-ing of CC.


Tests for Python 3.3 are failing

Python 3.3 is end-of-life, but I'm committed to not dropping support for anything until the next major release. I still have a minor release to do, so I'm stuck with Python 3.3. for now.
The tests are currently rather over-complicated, with nested virtualenvs and doubly-force-upgraded installations of pip et al. I'm going to try whether I can simplify things and avoid incompatible versions of pip and setuptools as a side effect. As always, help is welcome.

At second thought, I suggest not working on this until #61 is implemented. Leaving this open just to acknowledge the current situation.


Improve the --ping command

Right now, the --ping command is fairly limited.. it doesn't respect --host and --port and stuff like that. Make it better.

Fixed in the client-cleanup branch.


mod-playerbots module installation issue

[ 13%] Building CXX object modules/CMakeFiles/modules.dir/mod-playerbots/src/ChatFilter.cpp.o
/home/tricore/acore/modules/mod-playerbots/src/ChatFilter.cpp:166:47: error: no member named 'GetTargetIcon' in 'Group'
ObjectGuid rtiTarget = group->GetTargetIcon(RtiTargetValue::GetRtiIndex(rti.substr(1)));
~  ^
1 error generated.
make[2]:  [modules/CMakeFiles/modules.dir/build.make:104: modules/CMakeFiles/modules.dir/mod-playerbots/src/ChatFilter.cpp.o] Error 1
make[1]:  [CMakeFiles/Makefile2:1100: modules/CMakeFiles/modules.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

he he he, I think it's like me, when I tried to use it for the first time!
Question: did you download the 'playerbot' branch of AzerothCore? If not, pull the correct branch, then compile again. You will have a lot of warnings, but no errors. And the core will run correctly.
Check this post (mine) :)

Nah, your issue is different. They are all warnings not errors. Mine is definitely an error.

I can't use your fork because I need to use the PR for openSSL on the main fork to compile. Otherwise I will not be able to compile even the main source without modules

In that case, you will need to wait until the OpenSSL PR is merged with master so that it will be integrated with the fork to use the Playerbots module. There is no way to use it without the custom fork.

Is it possible for you to have that on your fork too so I can grab it from your github and then compile?

Or maybe guide me how to apply that feat/openssl PR to your fork?

so you should be more precise about your issue.
Actually, the official AzerothCore is not currently supporting OpenSSL3.
It is said here, on the 2 first lines: https://www.azerothcore.org/wiki/installation
IMPORTANT NOTE
OpenSSL 3.x is NOT SUPPORTED. Use the version the installation guide points to.

Ubuntu 22.0 and later ships with OpenSSL 3.x! If you want to use Ubuntu, use a lower version or compile a lower version of OpenSSL
...


[Bug]: Can not run the demo on RTX4090!

Before Reporting

[X] I have pulled the latest code of main branch to run again and the bug still existed. 我已经拉取了主分支上最新的代码，重新运行之后，问题仍不能解决。

[X] I have read the README carefully and no error occured during the installation process. (Otherwise, we recommand that you can ask a question using the Question template) 我已经仔细阅读了README上的操作指引，并且在安装过程中没有错误发生。（否则，我们建议您使用Question模板向我们进行提问）

Search before reporting

[X] I have searched the DAMO-YOLO issues and found no similar bugs. 我已经在issue列表中搜索但是没有发现类似的bug报告。

OS
Ubuntu
Device
RTX4090
CUDA version
10.2
TensorRT version
None
Python version
3.7
PyTorch version
1.7.0
torchvision version
0.8.0
Describe the bug
When I run the demo to detect dog.jpg, a warning occurs, and the program is stuck.
/<condapath>/envs/damo-yolo/lib/python3.7/site-packages/torch/cuda/__init__.py:104: UserWarning:
NVIDIA GeForce RTX 4090 with CUDA capability sm_89 is not compatible with the current PyTorch installation.
The current PyTorch install supports CUDA capabilities sm_37 sm_50 sm_60 sm_61 sm_70 sm_75 compute_37.
If you want to use the NVIDIA GeForce RTX 4090 GPU with PyTorch, please check the instructions at https://pytorch.org/get-started/locally/

  warnings.warn(incompatible_device_warn.format(device_name, capability, " ".join(arch_list), device_name))

I have to kill this zombie process.
To Reproduce
Run demo command
python tools/torch_inference.py -f configs/damoyolo_tinynasL20_T.py --ckpt weights/damoyolo_tinynasL20_T_418.pth --path assets/dog.jpg
A warning as described above occurs, and the program is stuck.
Hyper-parameters/Configs
No response
Logs
No response
Screenshots
No response
Additional
Actually, I have solved this problem.
Maybe cu102 is too old for RTX4090, and cu116 is suitable, I think.

Update the latest nvidia driver, which I have is 525.60.11.
Install pytorch with pip instead of conda.
pip install torch==1.12.1+cu116 torchvision==0.13.1+cu116 torchaudio==0.12.1 --extra-index-url https://download.pytorch.org/whl/cu116
When I use conda, I get a PackagesNotFoundError, but using pip is work.

Run the demo command and I get the expected output, an image with 3 bbox.

@thinktu2 Hi, thanks for your attention!
What you said above is right. As this previous issue #35 showed, RTX 30xx and 40xx series GPUs from Nvidia only support CUDA 11.x. So the first solution is to upgrade your CUDA driver and cudatoolkit.
If you want to install cudatoolkit and PyTorch with conda, you can follow the official instructions from here. You just need to make sure that the PyTorch version is what you need and the cudatoolkit version <= your CUDA driver version.
By the way, we are validating DAMO-YOLO on the later version of PyTorch and CUDA, including the latest PyTorch 2.0 and CUDA 11.x. When everything is OK, we will update the repo.
Please get in touch with us if you have any further issues.

@HYLcool Thank you for your answer! DAMO-YOLO is a meaningful work. Looking forward to the next update!