Year 400 crashes in ESM1.5 simulations

This relates to discussion in #457.
Background:
Researchers have had problems with long ESM1.5 paleo simulationscrashing in calendar year 400. See here and here. In the examples, the coupler and sea ice model appear to think there are only 365 days in the year while the ocean and atmosphere use the correct 366 days, leading to the crash, and in the first example, the ice model thinks its at year 300.
The disagreement between the ice/namcouple and the other components doesn't occur in every simulation that reaches year 400 though. E.g. attempting to reproduce the error by branching from the CSIRO pre-industrial run at year 400, and setting it to run for 3 months, payu gives the namcouple file the correct leap year run length of 91 days.
After working through some of Himadri's simulations, it looks like the calendar mismatch comes from payu's  start date calculation for the cice submodel. It pulls in information from both the control directory and the restart directory, meaning that if you copy a restart directory across different experiments, you could end up with inconsistent start dates. I still find it a bit confusing, so I hope the following explanation makes some sense.
How payu sets the cice and namcouple run lengths/start dates:
The cice start date and run length are (mostly) calculated in the access.py driver. It uses the <CONTROL-DIRECTORY>/ice/input_ice.nml namelist, which for example in our pre-industrial configuration looks like
<CONTROL-DIRECTORY>/ice/input_ice.nml
---------------------------------------------
&coupling
 *** caltype=1 ***
 jobnum=2
 inidate=01010101
 *** init_date=00010101 ***
 runtime0=3155673600
 runtime=86400
...

in addition to <RESTART-DIRECTORY>/ice/input_ice.nml, which for the pre-industrial configuration looks like
<RESTART-DIRECTORY>/ice/input_ice.nml
---------------------------------------------
&coupling
 *** runtime0=3155673600 ***
 *** runtime=0 ***

I've highlighted the variables that access.py uses in for the calculation with the * symbols. The other variables are ignored.
To set the start-date, it adds a total simulation length of runtime0+runtime seconds from <RESTART-DIRECTORY>/ice/input_ice.nml to the init_date from <CONTROL-DIRECTORY>/ice/input_ice.nml:
https://github.com/payu-org/payu/blob/e9bd1f4c4adc223e818c71f8d45c36de98025dc4/payu/models/access.py#L138-L142
To calculate the run duration for the next experiment, it then uses this start date, the caltype value from <CONTROL-DIRECTORY>/ice/input_ice.nml, and the runtime settings in the config.yaml file:
https://github.com/payu-org/payu/blob/e9bd1f4c4adc223e818c71f8d45c36de98025dc4/payu/models/access.py#L151-L157
The resulting runtime then gets used by cice and the coupler.
How problems can arise
Because the calculation uses the init_date from the control directory, copying a restart directory between different experiments can lead to different cice start dates (and hence run times) if the <CONTROL-DIRECTORY>/ice/input_ice.nml files don't match. This can come up when using the warm-start.sh scripts to create a new restart directory based on a CSIRO simulation, which was done for some of the linked examples.
The warm-start.sh scripts modify the cice start date by setting init_date in <CONTROL-DIRECTORY>/ice/input_ice.nml to the desired start date (for example 01010101), and runtime0=0, runtime=0 in <RESTART-DIRECTORY>/ice/input_ice.nml. Running the resulting configuration will then start the ice calendar at 0101-01-01.
If you then start a new experiment by cloning e.g. the pre-industrial simulation, and copying over the restart directory already created by the warm-start.sh scripts, the new control directory will still have the unmodified init_date=00010101, while the restart folder will have the modified runtime0=0, runtime=0, and cice will use a start date of 0001-01-01, 100 years off where it's meant to be.
Meanwhile, the UM and MOM have their start dates given completely in the restart directory via the um.res.yaml and ocean_solo.res file, and so they'll use the correct date of 0101-01-01 (there are some caveats for the UM in other situations). Once the simulation gets to year 400 the mismatch and crash can then occur.
Possible changes
A couple of ideas listed below:

Consistency checks. During the setup, payu could compare the start dates and run lengths for each component and produce an error if they aren't the same.
All CICE start date settings moved to the restart directory. Conceptually should a restart directory contain all the start date information, rather than half being in the control directory? E.g. we could move the init_date settings into the namelists in the restart directory and make corresponding changes to payu.

It would be great to get any other ideas/opinions on possible changes!

An option that @aidanheerdegen brought up is to try cut the current complicated timing calculations, and replace them with a completely new setup that uses an "artificial" calendar file that goes in the restart directory, say cice.res.yaml. This would mirror the behaviour of the UM time controls, which use the um.res.yaml file  (usually - we might need to think about this more eventually).
The overall steps for setting cice's start date and run length could be:

Read the start date from <prior-restart>/ice/cice.res.yaml.
Read the run length from config.yaml.
Calculate the run length in seconds using: the above start date, the above run length, the caltype setting in <control-dir>/ice/input_ice.nml
Copy <control-dir>/ice/input_ice.nml and <control-dir>/ice/cice_in.nml into <work-directory>/ice and write the newly calculated start date and run length into the copies
...
At the end of the run, write the start date + run length into a new cice.res.yaml file in the new restart directory.

This means that we would no longer need copies of the input_ice.nml and cice_in.nml files in the restart directory, and that all the information for setting the start date would live in the restart directory rather than being spread across the restart and control directories.
Does this sound like a reasonable overall approach?
I'm happy to try and start implementing this, however there are a few implementation details/rough patches I'm anticipating will come up.

Implementation details/concerns:
1. Can we assert in access.py that the experiment must have a prior restart directory (either as a restartXYZ directory in the archive directory or a restart path in the config.yaml)? From what I can understand, ESM1.5 will crash if it can't find the restart files, however there are a couple of niche situations where payu will allow a restart directory to be absent.
Based on what I understand of the following:
https://github.com/payu-org/payu/blob/89d70cf74655b6870505340b51124e7836284f9b/payu/experiment.py#L360-L376
payu will let ESM try to run without a prior_restart_dir in the following two cases:

A: the experiment is a repeat run, via the repeat setting in the config.yaml, and B: no restart directory is specified in the config.yaml
A: the experiment counter self.counter is 0 and B: no restart path is specified in the config.yaml (and C: restart-01 does not exist in the archive/restart directory).

Trying to run in these situations, the model crashes because of the missing restarts. Are there any niche ESM situations where either of the above two situations need to be supported/allowed? Or is it safe to assert in the access.py driver that a prior_restart_path must exist?

2. Currently two separate timing calculations occur in different parts of payu: one in the access.py driver and the second (mostly but not completely ignored) one in the cice.py driver. Details about the differences between the two are discussed here. I think it would be good to simplify this so that for ESM1.5 experiments, only one calculation occurs using the artificial restart date file.
Would we prefer this calculation to occur in the access.py driver (where the main calculation currently is), or is it better to move it into the cice.py driver?
I suspect we need to keep the second calculation in the cice.py driver in case of standalone cice simulations (I'm not 100% on this – is this something that the cice driver is set up to do?), and so we'll need to add in some logic about which calculation to use in the different situations.

3/. In the standalone cice case, where timing calculations are completely controlled by the cice.py driver: do we want to refactor this to also use a new cice.res.yaml file for the start date?
I think this would be nice to do and would help make everything simpler, however may involve some work in understanding the different situations that the current calculation and logic paths are set up for, as it would be bad to accidentally break any of them...

4. Consistency checks. I think the easiest way to check consistency between the different model start dates would be to compare each of their restart date text/yaml files (um.res.yaml, <NEW>cice.res.yaml, ocean_solo.res). Eventually we might want to add internal consistency checks for cice. The binary iced.YYYYMMDD restart files contain a timestamp, and if this doesn't match the time set in the model namelists, cice will still run but with the time all messed up.
Similar internal consistency checks might also be useful for the UM, as the actual restart dump restart_dump.astart contains date information as well as the um.res.yaml calendar file. I haven't tested what happens if they don't match yet.

5. Caltype. If we swap to an artificial restart date text or yaml file, the ice model could still get the timing wrong if the caltype setting in input_ice.nml somehow got changed. I think this is unlikely, but we could guard against by requiring in the access.py driver that it is Gregorian for ESM1.5 experiments – or could that be too inflexible/possibly impact future configurations.

6. If we set ice model start date using a text file in the restart directory, it looks like there are some specific situations where payu will overwrite the prior_restart_path, and hence the timing calculations could be affected.
In the cice.py driver, the cice model's prior_restart_path is overwritten if the restart_dir setting in <control-directory>/ice/cice_in.nml happens to be absolute, or if it's not absolute, the restart_dir setting joined with any of the cice input paths is a real directory (I think).
https://github.com/payu-org/payu/blob/89d70cf74655b6870505340b51124e7836284f9b/payu/models/cice.py#L132-L146
If this happened, the timing calculation might be impacted. Since the current calculations also use data in the restart directory, I don't think this would be a new issue though.

A much simpler suggestion from @anton-seaice: Rather than reading the init_date from <control-dir>/ice/input_ice.nml, make sure this field is saved to <restart-dir>/ice/input_ice.nml. This would prevent the mixing of information from the control and restart directories. I think it would also be easier to implement – it doesn't create any new artificial files and should (I think) be able to work with most of the existing timing calculations in the drivers... hopefully reducing the risk of messing up anything that's already there.
I'll have a go at implementing this and seeing how it goes.

I wondered if it will work ok with the existing warm-start scripts too?
I believe <restart-dir>/ice/input_ice.nml is only used by payu as a reference for changing a couple of fields in <control-dir>/ice/input_ice.nml? So adding a field here doesn't affect anything except how payu handles it. Ideally the models would just read this date from the restart files rather than needing an extra configuration item.

I've started putting this together in this feature branch LINK and will do pull requests to that in smaller steps.
The first step has been to rename the <restart_dir>/ice/input_ice.nml file to <restart_dir>/ice/restart_date.nml (happy to use other names), and move the experiment initialisation date init_date setting to it:
<restart_dir>/ice/restart_date.nml
----------------------------------
&coupling
init_date=10101
runtime0=3155673600
runtime=0
/

I've then modified payu to read init_date from this file rather than <work_dir>/ice/input_ice.nml, so that gets all the information for setting the start date from the restart directory. All the calculations in payu otherwise remain exactly the same.
This method seems to work and has a couple of benefits:

Backwards compatibility is easy as we're using the exact same calculation
But also downsides:
Not very user friendly. Requires knowing what init_date, runtime0 and runtime all mean to understand what the starting date is going to be. Also requires messing around with calendar calculations if you need to set up a new restart directory.

An alternative is to modify the setup so that <restart_dir>/ice/restart_date.nml contains
&coupling
init_date=10101
inidate=1010101
/

which makes it more transparent what the start date for the new simulation actually is, and makes it easier to set up new restart directories. The calculation of runtime0 for use with the next simulation (i.e. the time between the init_date and inidate) can then be handled completely internally by payu.
I have a rough version of this working in THIS BRANCH.
I think a couple of downsides to this approach are:

Requires adding new calendar calculations to payu. These are working but it's a less straightforward solution.
Makes backwards compatibility messier if it's something we want to maintain. I.e. we'd need to keep both the old and new calculations floating around in payu if we want older configurations to still work.

It would be great to hear what everyone thinks of these approaches, and whether you have a preference between the two.
In either case, I think the next steps would be to pull the code which reads/calculates the start date into a seperate method, that then can be used to check whether the start dates are consistent between the submodels.

I've started putting this together in this feature branch (https://github.com/ACCESS-NRI/payu/tree/466-esm1p5-cice-startdate-fix) and will do pull requests to that in smaller steps.
The first step has been to rename the <restart_dir>/ice/input_ice.nml file to <restart_dir>/ice/restart_date.nml (happy to use other names), and move the experiment initialisation date init_date setting to it:
<restart_dir>/ice/restart_date.nml
----------------------------------
&coupling
init_date=10101
runtime0=3155673600
runtime=0
/

I've then modified payu to read init_date from this file rather than <work_dir>/ice/input_ice.nml, so that gets all the information for setting the start date from the restart directory. All the calculations in payu otherwise remain exactly the same.
This method seems to work and has a couple of benefits:

Backwards compatibility is easy as we're using the exact same calculation
But also downsides:
Not very user friendly. Requires knowing what init_date, runtime0 and runtime all mean to understand what the starting date is going to be. Also requires messing around with calendar calculations if you need to set up a new restart directory.

A rough version of this option is available here:
https://github.com/ACCESS-NRI/payu/tree/466b-cice-move-init_date

An alternative is to modify the setup so that <restart_dir>/ice/restart_date.nml contains
&coupling
init_date=10101
inidate=1010101
/

which makes it more transparent what the start date for the new simulation actually is, and makes it easier to set up new restart directories. The calculation of runtime0 for use with the next simulation (i.e. the time between the init_date and inidate) can then be handled completely internally by payu.
I have a rough version of this working in THIS BRANCH.
I think a couple of downsides to this approach are:

Requires adding new calendar calculations to payu. These are working but it's a less straightforward solution.
Makes backwards compatibility messier if it's something we want to maintain. I.e. we'd need to keep both the old and new calculations floating around in payu if we want older configurations to still work.

A rough version of this option is available here: https://github.com/ACCESS-NRI/payu/tree/466a-cice-start-noruntime0

It would be great to hear what everyone thinks of these approaches, and whether you have a preference between the two.
In either case, I think the next steps would be to pull the code which reads/calculates the start date into a seperate method which could then be used to check whether the start dates are consistent between the submodels.

Closing following #484, and further work to be done in #495


[Suggestion] - Use image from values.yaml for all tests containers images

Suggestion
Hello,
I've noticed that the values.yaml allows defining custom image for the permissions and status test containers.
testPods:
...
  image:
    permissionsTestContainer: debian:stable-slim
    statusTestContainer: alpine:latest

However, these values are not used consistently in the templates.
Notably, the Jira template
It works with the test-application-status.yaml file
      image: {{ .Values.testPods.image.statusTestContainer }}

But the test-shared-home-permissions.yaml file hard codes the image:
      image: debian:stable-slim

The Confluence template:
test-application-status.yaml
      image: alpine

test-shared-home-permissions.yaml
      image: debian:stable-slim

Could you please make it so both containers in every templates refers to their respective value?
      image: {{ .Values.testPods.image.statusTestContainer }}

      image: {{ .Values.testPods.image.permissionsTestContainer }}

This is a blocker to deploy the Helm Charts in environments where Helm can only access an internal registry.
Thanks!
Product
Jira, Confluence
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks!
In addition to the image, would it be possible to set resources requests/limits to testPods as well?
Currently, if the namespace has a ResourceQuota set, these pods won't be deployed.


Cody Web: Add support running prompts from consumer

Part of https://linear.app/sourcegraph/issue/SRCH-1290/implement-new-prompt-library-ui
In the new Prompts Library, we're going to have a Cody Web demo staging, with which you can run your prompt; this means that we have to have some API to trigger prompts in the Cody Web UI from the Cody Web consumer.
This PR adds this "external API" functionality by exposing the External API object
Test plan

No Changes in the actual Cody shared webview

@thenamankumar can you review this again? I fixed the comment about the prompt mode and left a comment callback prop.


plugin adds two instead of one whitespace to class definition line

Hi,
I just pulled 0.1.11 of your plugin. It creates the following diff:
diff --git a/manifests/postgrescreatedb.pp b/manifests/postgrescreatedb.pp
index db227516..c2011f2a 100644
--- a/manifests/postgrescreatedb.pp
+++ b/manifests/postgrescreatedb.pp
@@ -1,5 +1,5 @@
 # this profile creates all roles, databases and users
-class profiles::postgrescreatedb{
+class profiles::postgrescreatedb  {
   # create puppetdb, this only wraps postgresql::server::db, but sets the correct password
   class { 'puppetdb::database::postgresql':
     manage_server => false,
@@ -18,7 +18,7 @@ class profiles::postgrescreatedb{
   # https://github.com/puppetlabs/puppetlabs-puppetdb/blob/master/manifests/database/postgresql.pp
   postgresql::server::db { 'puppet4puppetdb':
     user     => 'puppet4puppetdb',
-    password =>  postgresql_password('user', 'password'),
+    password => postgresql_password('user', 'password'),
     grant    => 'all',
   }
   postgresql::server::pg_hba_rule { 'user access to db from puppetserver':

the first change is wrong, only one whitespace should be added. The latter change is correct.

@bastelfreak I added a specific test for this, but it does not fail for me. Could you:

try again with the latest release (0.1.16 - yop, it's going fast...)
point me to the file so I can copy the whole manifest for tests

Thanks for reporting!

I had to adjust it a bit but here is an example to reproduce the error. it's still present with 0.1.16:
class profiles::postgrescreatedb{
   # create puppetdb, this only wraps postgresql::server::db, but sets the correct password
   class { 'puppetdb::database::postgresql':
     manage_server => false,
   }
   # https://github.com/puppetlabs/puppetlabs-puppetdb/blob/master/manifests/database/postgresql.pp
   postgresql::server::db { 'puppet4puppetdb':
     user     => 'puppet4puppetdb',
     password =>  postgresql_password('user', 'password'),
     grant    => 'all',
   }
}

Again, two checks working against each other. Since my spec tests only test one check at a time, they are not interfering there. But I can certainly reproduce now!

(Any idea how to test multiple checks simultaneously?)

I think I fixed it now

awesome, diff now looks like this:
diff --git a/manifests/postgrescreatedb.pp b/manifests/postgrescreatedb.pp
index db227516..c2011f2a 100644
--- a/manifests/postgrescreatedb.pp
+++ b/manifests/postgrescreatedb.pp
@@ -1,5 +1,5 @@
 # this profile creates all roles, databases and users
-class profiles::postgrescreatedb{
+class profiles::postgrescreatedb {
   # create puppetdb, this only wraps postgresql::server::db, but sets the correct password
   class { 'puppetdb::database::postgresql':
     manage_server => false,
@@ -18,7 +18,7 @@ class profiles::postgrescreatedb{
   # https://github.com/puppetlabs/puppetlabs-puppetdb/blob/master/manifests/database/postgresql.pp
   postgresql::server::db { 'puppet4puppetdb':
     user     => 'puppet4puppetdb',
-    password =>  postgresql_password('user', 'password'),
+    password => postgresql_password('user', 'password'),
     grant    => 'all',
   }
   postgresql::server::pg_hba_rule { 'user access to db from puppetserver':


Isolate test went from flaky to timeout

There are new test failures on Migrate NonErrorResolverTest to null safety...[vm/concurrency] First changes for hot-reloading with isolate gropus..
The test
co19/LibTest/isolate/Isolate/pause_A01_t01 Timeout (expected Pass)

is failing on configurations
dartk-weak-asserts-linux-release-simarm64

Also on dartkp-linux-release-x64 from flaky -> timeout
Log: https://dart-ci.appspot.com/log/vm-kernel-precomp-linux-release-x64/dartkp-linux-release-x64/15717/co19_2/LibTest/isolate/Isolate/pause_A01_t01

This is still flaky.
@sgrekhov I think this test needs to be aligned in pre-nnbd with the updated one in master branch


Make redis an optional dependency (#69)

Fix #69

Add CACHE_TYPE to configure internal cache type (default filesystem).

default cache directory is .nekocache

Added CELERY_BROKER_URL and CELERY_RESULT_BACKEND to configure celery.

default database files are yume_broker.db and yume_result.db

Codecov Report

Merging #73 into master will decrease coverage by <.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   77.43%   77.42%   -0.01%
==========================================
  Files          17       17
  Lines        1560     1564       +4
==========================================
+ Hits         1208     1211       +3
- Misses        352      353       +1

Impacted Files
Coverage Δ

nekoyume/app.py
94.11% <80%> (-1.63%)
:arrow_down:

nekoyume/models.py
74.46% <0%> (-0.29%)
:arrow_down:

tests/models_test.py
100% <0%> (ø)
:arrow_up:

nekoyume/api.py
59.64% <0%> (+1.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b0bca...ae06008. Read the comment docs.


[Feature Request] WebP Support

WebP support
Feature: A config option to also convert images to WebP or convert specific formats to WebP (like PNG)
WebP now has support on all major browser: https://caniuse.com/webp
Not much longer will websites require PNG/JPG fallback for WebP used on the web.

As far as what file formats should be converted to WebP, PNG seems to be the main one:
Converting a JPG -> WebP will retain JPG's sub-par quality at a slightly smaller file size, but converting PNG -> WebP will significantly reduce file size without sacrificing PNG's great image quality. So, maybe an option to convert PNGs -> WebP would make the most sense?

Libraries for converting to WebP
As far as what library could be used, Google has libwebp which looks a little difficult to integrate into an Electron application. Alternatively, there's cwebp which is Google's CLI-friendly version that uses libwebp, which node could run if cwebp is installed. But, getting the user to install it or shipping cwebp with Electron is the tricky part.
A somewhat maintained JS wrapper for cwebp (library has a cwebp binary in it): https://github.com/imagemin/cwebp-bin
An example of Apache's "Echarts" repo using the cwebp-bin in practice: https://github.com/apache/echarts-examples/blob/00e79accd3f1ac638774ae56b84e845d616a3124/tool/build-example.js#L91
A library that supports converting a number of different formats, including webp: https://github.com/Yuriy-Svetlov/compress-images

Created a PR with using the cwebp-bin library.


Should I use this pattern?

This question will have more to do with the pattern than with this example of implementation.
I'm trying to understand the clean architecture, and getting in touch for the first time with RxJava and injection dependencies.
Considering that it'll take me even longer to understand all this, I'd like to know before starting to use this project as a base if I could use this pattern for the development of my application, all the functionality of the application (or most of it) will be Based on a map, and from certain conditions such as the user's position, one functionality or another will be available. Very similar to the way Google Maps works. My doubt arises more than anything because I consider that all the functionality of the map could be done in the same activity, and specific things like the entrance of users could be handled in other activities and I don't know if the clean architecture will complicate things more for me (I'm beginner) .
All this is for the sake of implementing an architecture that allows other developers to integrate into the future in the project and quickly.
regards

There is no the only right way how to implement the code in your app.
Usage of Clean Architecture and MVP gives a lot of benefits. Read more about them here and here
I would always suggest to develop your app the same way, using Clean Architecture approach and MVC / MVP / MVVM


R-CRAN-dplyr-1.0.8-1.fc35 gives an error

With the new dplyr package, I get the following error:
> library(dplyr) Error: package or namespace load failed for ‘dplyr’ in
loadNamespace(i, c(lib.loc, .libPaths()), versionCheck = vI[[i]]):
namespace ‘rlang’ 0.4.11 is already loaded, but >= 1.0.0 is required
>

To overcome this error, I have to downgrade dplyr to  R-CRAN-dplyr-1.0.7-1.fc35.
Any help? Thanks!

Did you try updating both R-CRAN-dplyr and R-CRAN-rlang to the latest version?

Thanks, Iñaki, for your answer.
I have:
# rpm -q R-CRAN-dplyr R-CRAN-rlang
R-CRAN-dplyr-1.0.8-1.fc35.copr3415487.x86_64
R-CRAN-rlang-1.0.0-1.fc35.copr3255516.x86_64
#

Moreover, I have restarted the R session.

Sorry, I cannot reproduce here. Are you sure you don't have any incompatible version in your user library?

Thanks, Iñaki. How can I check for such incompatible version?

In R, packageVersion("rlang").  The first one is the user library.

Thank you much, Iñaki: Your solved my problem!
I did the following, based on your directions:
> packageVersion("rlang")
[1] ‘0.4.11’
> uninstall.packages("rlang")
Error in uninstall.packages("rlang") :
  could not find function "uninstall.packages"
> remove.packages("rlang")
Removing package from ‘/home/x/R/x86_64-redhat-linux-gnu-library/4.1’
(as ‘lib’ is unspecified)

And problem fixed!


Add libbpfgo API functions for attaching generic bpf program types, selftests

Add libbpfgo API functions for attaching generic bpf program types,  such as fentry/fexit, and add selftests for demonstration
Signed-off-by: grantseltzer<EMAIL_ADDRESS>

Messed up git, didn't use a different branch. Closing this for duplicate #144 (sorry! :-) )


Bug: Types file is gone

https://github.com/TheNexusAvenger/Nexus-Admin/blob/typing-refactor/src/Types.lua is gone, it seems to be still linked at https://github.com/TheNexusAvenger/Nexus-Admin/blob/master/docs/api.md though

nvm the link is just weird, it seems to exist, though the link is incorrect


TBB track builder

Adds track builder threading with TBB.  Factors out the core of track building into separate routing shared by the OMP and TBB builders.  Adds new flags for the TBB builder and number of seeds per task with TBB.  Adds TBB support to the benchmark suite.  Moves seed fit and initial binning out of the time section, so all builders get somewhat faster.

Hi @dan131riley, are you going to run the benchmarking script or you prefer me to do it?

@cerati, put the initial results here:
http://www.lepp.cornell.edu/~dsr/mic-track/2016-04-11-PR40/
re-running now with a couple of small changes, shouldn't be any different.
-dan

@dan131riley, thanks.
Once this test is done, can you point me to the location on phiphi so that I can copy the pngs to my usual area (I'd keep all the plots in the same place)?
Also, I thought we wanted to get rid of OMP now that we established that TBB works better - is this planned in a followup pull request?

@cerati, I'm not sure we want to get rid of OpenMP entirely. The fact is, so far we have been using OMP in a relatively simple way--I think just in order to get started. I believe OMP 3.0 has task-based features that may not be too different from what we're now doing with TBB. (OMP 4.0 seems more focused on accelerators and SIMD, though it does introduce some task enhancements, such as task dependency and thread affinity... I must admit I have not kept up with all the latest developments... the OpenMP 4.0 document is 250+ pp. long, while 1.0 was just 40 pp.)
Anyway, given that OMP is arguably more portable, we may not want to let go of it just yet. Or I suppose we could ditch OMP for now, then start over with it at a later time, assuming we learn a lot from the TBB experience. Probably we all agree that this is a low-priority area of development, given the more pressing performance issues we'd like to address in the near term.
One good reason I can think of for tossing OMP is if it constrains our code structure in some bad way, so that it inhibits future development.

@cerati,
see /home/dsr/mictest-mt on phiphi.  wrt removing OMP, I think it's useful to have a version with both OMP and TBB so we have a direct comparison with a continuous record of performance changes.  We also still need TBB versions of (at least) best hit and the fitter, so I think the development plan is to do those next, and then after doing a PR for that we can look at removing the OMP versions.  I am also doing some refactoring to minimize the code duplication, so the chunks of code that are OMP-specific are getting smaller.
@srlantz,
I'd argue that TBB is more portable!  TBB works with any C++11 (or later) compiler, all it needs is features that are in the C++ standard.  OpenMP needs special compiler support, so (for example) TBB works with the standard system compiler on the Mac, but for OpenMP I need to install pre-release versions of LLVM.  We've also got a mandate from CMS that anything we expect to incorporate into the standard CMS processing change has to use TBB, as that's what the CMSSW framework uses.
Also, even the latest versions of OpenMP is based on C++98, so its interaction with C++11 features isn't defined.  I find this very constraining, as I find C++11/C++14 much more expressive than C++98.
-dan

@dan131riley, good counter-arguments, thank you for making these points.

for the record: copied to http://uaf-7.t2.ucsd.edu/~cerati/mictest/2016-04-13-PR40/

Hi @cerati,
sorry, could you recopy those from /home/dsr/mictest-mt/2016-04-13-PR40?  I was doing some further testing and forgot you still needed to copy those, so if you look at the host_th_speedup.png and host_th_time.png you copied, you'll see those are actually from a later version with the best hit converted to TBB (and showing an improvement in scaling).  I've put the correct versions back to /home/dsr/mictest-mt/2016-04-13-PR40 so that can't happen again.
-dan

done, thanks
g.
On Fri, Apr 15, 2016 at 1:44 PM, Dan Riley<EMAIL_ADDRESS>wrote:

Hi @cerati,
sorry, could you recopy those from /home/dsr/mictest-mt/2016-04-13-PR40? I
was doing some further testing and forgot you still needed to copy those,
so if you look at the host_th_speedup.png and host_th_time.png you copied,
you'll see those are actually from a later version with the best hit
converted to TBB (and showing an improvement in scaling). I've put the
correct versions back to /home/dsr/mictest-mt/2016-04-13-PR40 so that can't
happen again.
-dan
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/cerati/mictest/pull/40#issuecomment-210431238

Hi @cerati,
I added a couple of changes to PR#40 to fix problems with setting the number of threads.  This bug only hit when -read was not used, so it doesn't affect the test results.  Are you going to go ahead with the merge?
-dan

I thought I already merged, but I guess I did not push the button, doing it now!


Add ability to map dependencies from existing locations ex. object storage

Allow users to map kubernetes volumes, object storage, nfs, ceph etc. to their components when executing a pipeline

https://github.com/elyra-ai/elyra/issues/1131 appears to be such an issue that is storage type specific


License notice update for each source code file

I wrote license for each source code file, Thanks for making your project Free Software and happy hacking !

Change algos.go package name will break the code!

@mekramy Do you please elaborate this issue ? Should I change algos.go name and make it crypt_algo.go for instance ?

Thanks for your collabration.
Please replace package algos with package crypto in algos.go.


Remove "sudo: required" and "dist: trusty" from .travis.yml.

These settings are no longer required, because we aren't using Bazel.
This commit fixes the build after Travis updated the environment: https://travis-ci.org/census-instrumentation/opencensus-java/jobs/247751414
/cc @dinooliva @bogdandrutu

Codecov Report

Merging #399 into v0.4.x will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             v0.4.x     #399   +/-   ##
=========================================
  Coverage     94.79%   94.79%
  Complexity      439      439
=========================================
  Files            61       61
  Lines          1325     1325
  Branches         92       92
=========================================
  Hits           1256     1256
  Misses           43       43
  Partials         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908f63c...4181b0e. Read the comment docs.


Removed Twitter box

@GeeH
Do you want to remove the corresponding view helper and view scripts as well?

ZfModule\View\Helper\TwitterWidget
zf-module/helper/twitter-widget-view.phtml

?

No, we may add this back but we need to put the Twitter account under some kind of rules

@GeeH
Ok, then :rocket:!


More aggresssive discovery - thanks @robwebset. Closes #289

Implementation of ideas in #289.  This uses the default method, and two other methods of finding the relevant local address (if they result in anything different). I have not included the suggestion for calling out to songs.com and then checking the local socket address because (1) it takes too long, and (2) I am far from certain that it is likely to produce any address different from the other methods.  Let's wait and see if this is generally good enough.
Comments please, especially from @robwebset
Lawrence

Coverage increased (+0.24%) to 54.18% when pulling 8fb825ccf4d437f714c28c2fe49249e7f217c0bc on lawrenceakka:more-discovery into 2cbe3692da202b242dcb49320d44d785f06c91ba on SoCo:master.

Hi @lawrenceakka
I have added some comments against each line - hope that is OK.
Can I suggest you add the method that does the call to "sonos.com" at the end if no other speakers are found.  In my experience people will only use the discover if they believe they have speakers on their network - so it would be worth doing absolutely everything we can to try and find it.
Thanks
Rob

Hi Rob,

I have added some comments against each line - hope that is OK.

Of course.

Can I suggest you add the method that does the call to "sonos.com" at the end if no other speakers are found. In my experience people will only use the discover if they believe they have speakers on their network - so it would be worth doing absolutely everything we can to try and find it.

The point is that I think we are doing everything we can. I just don't see why having the call to sonos.com will add anything to the other methods, except a DNS request, and a long interval (in computer terms) whilst we wait for a response. Do you have any examples where this method succeeds whilst the other three fail?
Lawrence

Yes, I notice you rejected every single one of the comments!
When I did my original searching - it was one of the things suggested to support all platforms, doing the call to a web page seems to set the socket up when all other things have failed - I know it takes longer, this is why I suggested doing it as a last resort - which is how it was implemented in the pull I submitted.
I see no harm in this, as at that point no speakers have been found - so we should try everything.
Rob

Yes, I notice you rejected every single one of the comments!

Nothing personal. And I always agree with the good points :smile:

When I did my original searching - it was one of the things suggested to support all platforms, doing the call to a web page seems to set the socket up when all other things have failed - I know it takes longer, this is why I suggested doing it as a last resort - which is how it was implemented in the pull I submitted.
I see no harm in this, as at that point no speakers have been found - so we should try everything.

If we want to do everything we can (and I'm not sure that we should), the only sound cross-platform solution is to use netifaces. But as you have pointed out elsewhere, that introduces a binary dependancy, which neither of us is keen on.  I am afraid I remain unpersuaded (for the moment at least) about adding in the call to sonos.com. I just don't see why finding out which interface has a route to sonos.com will help with finding out which interface has a route to the local sonos network, especially in circumstances where the two other methods have failed. And it adds delay to a process which is supposed to be as quick as possible/messes up the timeout code.
It is always open to the user of the soco library to check for a null return from discover() and apply whatever additional solutions are appropriate for that particular platform to find out the relevant interface.

Hallo @lawrenceakka and @robwebset.
The work on this seems to have stalled a bit and there unquestionably is a need for a more aggressive discovery function.
Summarizing the discussion, there is line 112 which @lawrenceakka agreed to change, a few minor style discussions and then the 2 remaining core issues:

Catering for independent Sonos systems on different networks
Using a call out to Sonos.com as a last resort.

Disregarding for a moment our opinions of these, they are both in essence "additions" to the core enhancements that this PR currently contains. So might I suggest, to get at least the improvements that we agree on out into the hands of the users, that we merge this in the current form and then start up separate discussions over issues 1 and 2 if the need arises or you feel that it needs more attention?

Hallo @lawrenceakka and @robwebset.
The work on this seems to have stalled a bit and there unquestionably is a need for a more aggressive discovery function.
Summarizing the discussion, there is line 112 which @lawrenceakka agreed to change, a few minor style discussions and then the 2 remaining core issues:
Catering for independent Sonos systems on different networks
Using a call out to Sonos.com as a last resort.
Disregarding for a moment our opinions of these, they are both in essence "additions" to the core enhancements that this PR currently contains. So might I suggest, to get at least the improvements that we agree on out into the hands of the users, that we merge this in the current form and then start up separate discussions over issues 1 and 2 if the need arises or you feel that it needs more attention?

Hi @KennethNielsen
Sorry I've been out of action for a while. I'll look at this in the next couple of days, retest, and commit something. I'll also try to catch up on a few of the other issues.
Lawrence


Add constraints to pin pylint to known working version

Summary
This commit adds a constraints file so we're always running pylint and
astroid at known working version. The 2 are requirements are very coupled
and small changes in one often requires an update in the other.
Unfortunately new versions of pylint often change or add rules which
makes running it unpinned not a good decision. To ensure a consistent
environment for running pylint this commit leverages pip constraints to
make sure we always install the same version of astroid and pylint.
Details and comments

@derivation This patch should workaround the issues with the latest pylint. It'll keep us at fixed known working versions until we're ready to bump things.


az network bastion rdp leads to msrestazure.azure_exceptions.CloudError: Unexpected internal error

Bug
when calling az network bastion rdp --name bastion --resource-group rg-test --subscription xxx --target-resource-id testmachineresourceId --verbose
i receive
Creating a socket on port: 0
Setting socket options
Binding to socket on local address and port
Auto-selecting port: 60545
Finished initialization
Exception in thread Thread-1:
Traceback (most recent call last):
File "threading.py", line 932, in _bootstrap_inner
File "threading.py", line 870, in run
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/custom.py", line 8089, in _start_tunnel
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/tunnel.py", line 182, in start_server
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/tunnel.py", line 117, in _listen
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/tunnel.py", line 104, in _get_auth_token
msrestazure.azure_exceptions.CloudError: Unexpected internal error
Command ran in 9.468 seconds (init: 0.262, invoke: 9.205)
To Reproduce
just calling the command
Expected behavior
native rdp client opens and i can connect through rdp
Environment summary
azure-cli                         2.32.0
core                              2.32.0
telemetry                          1.0.6
Extensions:
ssh                                1.0.0
Dependencies:
msal                              1.16.0
azure-mgmt-resource               20.0.0
Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\sykorlub.azure\cliextensions'
Python (Windows) 3.8.9 (tags/v3.8.9:a743f81, Apr  6 2021, 13:22:56) [MSC v.1928 32 bit (Intel)]
Additional context
bastion is set to support native clients following https://docs.microsoft.com/en-us/azure/bastion/connect-native-client-windows.
bastion is hosted in vnet which is peered with second vnet having my test machine. for test purposes all peering connectivity is allowed.
for test purposes all incoming traffic is allowed on nsg for test machine.
Connecting to test machine through bastion from portal UI works.

route to service team

Was this ever resolved?

Was this ever resolved?

no. at least as far as i know... :-(

not for me too..

I faced the same issue for Linux VM. Any solution for this problem?

still not working in "azure-cli": "2.37.0"


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit 8c2079d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-03-11-03-30-14 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-03-11-03-30-14

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


New type of ads

Today I noticed in my timeline for the first time that an "Ad" is showing. See the word "Ad" in the top-right. This one is with an image, I saw another one that just had text and looked very similar to a normal tweet.

Could this kind of tweet be removed?

That's just what Ads on Twitter look like now, maybe it's been so long since you last saw one.
If you're not running v4.1.0 you were probably being affected by the Twitter bug it has a workaround for.

That's it probably then... Thank you.


fix: Don't show pending requests for users already in the group

Filter out requests that have already been approved but not updated on the backend Set storage so users can only attempt to join once from app installation perspective
Closes https://github.com/ephemeraHQ/converse-app/issues/584
Closes https://github.com/ephemeraHQ/converse-app/issues/588

Curious why requests would be approved but not updated on the backend. Shouldn't the two things happen at roughly the same time?

Curious why requests would be approved but not updated on the backend. Shouldn't the two things happen at roughly the same time?

They should, and from debugging it looks like it's being called and works successfully locally from what I am seeing
I think what may happen is a second request gets made, but I am not 100% sure
Either way it should clean up some UX

Just feels a bit like we are covering up the issue rather than resolving it.
If there are duplicate requests shouldn't we either prevent them from being sent in the first place or respond to them?
We can ticket this to handle later if we think that's going to be a pain.

@neekolas this PR adds the part of caching the invite https://github.com/ephemeraHQ/converse-app/pull/586/files#diff-8f2c7accf2c2da40406bf00e47a5197cde61da72f12d858f33df6ccdf56323c8R69


[FLINK-16441][SQL] SQL Environment Configuration section will also be set in flink conf

What is the purpose of the change
Allow users to override regular Flink configuration settings from the SQL Client env file.
The cofniguration section of the env yaml will be set in the Flink Configuration used to create the command line, executor etc in addition to the already present behavior of setting it as table config.
Brief change log
Move (and simplify) commandline related behavior from LocalExector to the ExecutionContext class where we have all the necessary environment related settings to create the proper Configuration.
Verifying this change
This change still needs to be verified with tests as it has only been tested manually, do not merge yet
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): No
The public API, i.e., is any changed class annotated with @Public(Evolving): No
The serializers: No
The runtime per-record code paths (performance sensitive): No
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: Yes
The S3 file system connector: No

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? not documented yet

cc @wuchong
I still need to add a test case + some docs, just opening the PR for comments

Needs to be updated for 1.11 or 1.12


:sparkles: add jira tagging workflow

Type of Change

[ ] Bugfix
[x] Enhancement / new feature
[ ] Refactoring
[ ] Documentation

Description

add jira release tagging workflow
example pr

Checklist

[x] Add relevant labels (for example type of change or patch/minor/major)
[x] Make sure not to introduce some mistakes
[x] Update documentation
[x] Review the Contributing Guideline and sign CLA
[ ] Reference relevant issue(s) and close them after merging

@0x46616c6b I had the same thought. But since we use the same configuration everywhere and copy the text again and again, I would have found it quite nice to also make the maintainability of the action easier.


fix(rust test): fix occasional CI test failures

CI occasionally shows the "hotspare" test failing; specifically in the
"hotspare_replica_count_spread" function.
The problem appears to be in the "wait_till_volume" function where we
were waiting for the number of replicas to be correct. However, we were
checking the replica count in the spec, which defines the desired number
of replicas rather than the actual number of replicas in the system.
This function has been enhanced to check the replica topology field in
the volume state which will give the number of actual replicas.

bors merge


Adjust wording on request publishing page

Users were unclear during testing why they couldn't publish yet; some thought it was because the product was still under development.
Be sure to indicate this only applied to the first time.

I assume it's still a problem; we didn't test the sign-up process in the last round. But the problem occurred on the onboarding screen and in the app. Users assumed they would have to unlock publishing every time they built a form. A small line about only having to do this once will be enough.
Users were very concerned about doing this every time and indicated they would find another way to publish forms if this was the case. Clarifying from the start will go a long way to improve user confidence.

Thanks for clarifying! :D Turns out that is a bit more confusing than I initially thought because there are basically two ways to be blocked from publishing and they're separate but maybe a bit muddled:

The ability of the account to publish (support unlocks -- which disappears after onboarding)
The checklist of requirements for each form (user has control -- which is more about the state of the form)

Correct, and to muddy it more... if you skipped the unlock step during onboarding, you'll be presented with the unlock publishing CTA when you land on the publishing checklist page.

Yes, that's the one. This is the screen where users who skipped the unlock step during onboarding thought they would have to request an unlock every time.

Yes, we specified that you unlock before publishing your first form.

We also applied the different visual styling to separate the Unlock publishing in the publish checklist if that step was skipped in onboarding and changed the CTA to Request publishing ability

We can do more if it's still confusing? But I haven't seen this issue recently?


paginate() shows raw HTML with Slim template engine

Well, I'm using Slim as my template engine, and whenever I put "=paginate(@videos)" it shows raw HTML instead of the actual links. I got it working with "=paginate(@videos).to_s.html_safe", but I think this shouldn't be the way kaminari should work...
Thanks anyway for your work!

For future reference, the sample @derencius linked to is now located here.
Code here, just in case it gets moved or deleted:
= paginator.render do
  ul.pagination
    == first_page_tag unless current_page.first?
    == prev_page_tag unless current_page.first?

    - each_page do |page|
      - if page.left_outer? || page.right_outer? || page.inside_window?
        == page_tag page
      - elsif !page.was_truncated?
        == gap_tag

    == next_page_tag unless current_page.last?
    == last_page_tag unless current_page.last?


Renaming files with only an extension (hidden files) fails

Actual behavior
When trying to rename .env.example to .env it does not save or when you leave in the -copy suffix it gets the name -copy.env
Expected behavior
A file saved as literal name .env

Unchecking this setting fixes this issue.


FlatList footer render bug??

Is this a bug report?
Yes

Have you read the Contributing Guidelines?
Yes
Environment

Environment:
OS:  macOS Sierra 10.12.6
Node:  8.2.1
Yarn:  0.27.5
npm:  5.3.0
Watchman:  4.7.0
Xcode:  Xcode 9.1 Build version 9B55
Android Studio:  2.3 AI-162.4069837
Packages: (wanted => installed)
react: 16.0.0-beta.5 => 16.0.0-beta.5
react-native: 0.49.3 => 0.49.3
Target Platform: iOS (10.3)
Steps to Reproduce

(Write your steps here:)

create a custom compoennt, and render a FlatList
add renderItem，ListFooterComponent，refreshing，onRefresh，onEndReached，onEndReachedThreshold，keyExtractor，ItemSeparatorComponent props
write functions for these props except refreshing set a boolean value, onEndReachedThreshold set 1,

Expected Behavior

when i bind 'this' for _handleRefresh()、_renderFooter()、_renderSeparator()、_onEndReached() all 4 functions in my component constructor，FlatList can not render its footer as normal, nothing render actually, but if i bind this as above, the FlatList‘s footer rendered as expected.
What make me strange is , it is worked if i bind 'this' as above for one of them, the other three functions do bind in constructor, it's also worked.
Actual Behavior

when i bind 'this' for _handleRefresh()、_renderFooter()、_renderSeparator()、_onEndReached() all 4 functions in my component constructor，FlatList can not render its footer as normal, nothing render actually,
Reproducible Demo

https://github.com/xilibro/ReactNativeFlatListDemo

You do not need to do bind the functions in the constructor. Remove this:
        this._renderFooter=this._renderFooter.bind(this)
        this._onEndReached=this._onEndReached.bind(this)
        this._separator = this._separator.bind(this)

Instead, write your functions with the arrow function like this:
_renderFooter = () => {
    ....
}

@jslok  from what i understand arrow function instead of bind create a new function on each render.
I'm trying to optimise my flatlist who is slow and use arrow function everywhere.
any advice ?


[HUDI-7230] stream read supports skipping insert overwrite instant

Change Logs
In streaming scenarios, insert overwrite is usually used to repair data. Here you can control the visibility of downstream stream reads.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

cc @danny0405 @stream2000 @yihua

cc @danny0405


Select path for opensearch ca

I'm trying to deploy rubrix in k8s and connect with external ES instance. Connection should be secure, but i got error
opensearchpy.exceptions.SSLError: ConnectionError([SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1091)) caused by: SSLError([SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1091))
This is because with opensearchpy you should select path in parametr ca_certs with OpenSearch function. Reference: https://opensearch.org/docs/latest/clients/python/#sample-code
It would be great if you add ca_cert_path variable to rubrix. #1495

Hi @zelanastasia and thanks for using Rubrix.
I've seen also your PR, thanks a lot! But, first of all, I would like to better understand why you're getting that error.
If you have a valid certificate configured to connect to your elasticsearch instance, this extra configuration should not be needed. If I'm not wrong, you're trying to connect to an es instance using the secured HTTPS protocol, but the certificate is not valid for the domain you're using. It's that right?
Did you try to disable the client SSL verification? You can use the RUBRIX_ELASTICSEARCH_SSL_VERIFY=False configuration for that.
Anyway, I will review your PR.
Thanks!


[Improvement] Handle EXIF DOP zero values

When a camera vendor incorrectly sets the GPS DOP exif tag of an image to zero, OpenSfM currently throws a division by zero error.
Details here: http://community.opendronemap.org/t/float-divison-by-zero-error/317/4
While a solution is to remove the offending exif tag, adding the necessary logic to handle zero values on DOP tags could make OpenSfM more robust.

Thanks for the warning. It is fixed in current master, https://github.com/mapillary/OpenSfM/commit/e6c260467ddf6f66f4f97a42acd5685b2ae05f71
This was happening when averaging the lat, lons to chose a reference. We added a check for that case.


Hourly summary should not require view_user permission

I couldn't seem to find new issue before making the commit.
commit a4d27b940f96987c2e01fd in
fix/permission-hours
should fix this. I've made a pull request

I think we can close this one?


If user doesnt remember password

Hi all,
Lets say a user goes on passcore but doesnt remember their current password, is there a way for them to reset their password even tho they cant remember their current one
Cheers,
Rob

I'm sorry but there's no way. And we don't have plans to implement it.

Thats fine thank you for the quick response


Support for Array of Classes

I have something like this in my class:
 public SSATricks[] Tricks:

But the array isn't cloned, witch I have verified with DotPeek

Fields are not supported per design. Use Properties:
public SSATricks[] Tricks { get; set; }


text encoder

I noticed that the function get_text_emb is decorated with @torch.no_grad(), which means the text encoder's parameters won't be updated. However, I also noticed that in config.yaml it says free_layers: 6 # set 12 to freeze all layers in bert, so is your text encoder frozen?

Additionally, there are many parameters in your config.yaml that differ from those in the paper. For example, the learning rate and weight decay in the paper are 2e-4 and 1e-5 respectively, but in the config file, they are 1e-3 and 1e-8.

Thanks for your detailed response! There should be typo in the config file, please change it to match the parameters mentioned in paper.


Made thumbnail list responsive

Fixes
Fixes #25  by @tinniaru3005
Fixes #26 by @tinniaru3005
Description
Earlier the page used to scale down if screen size reduced. Fixed that by changing viewport tag.
Also the number of boxes and there size used to be static on reducing screen size making them unreadable on smaller screens , It now shows 4 boxes on large screens, 2 on medium sized and 1 on mobile sized screens.
Tests
Run the site and check the responsiveness on the home page
Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Hi @tusharbansal22 Thank you for your excitement. ❤
I will point at what @tinniaru3005 said above.
Please review the Contribution Guidelines when submitting PRs. Issues without a status of ready for work shouldn't have PRs submitted against them.
Since this PR is a little ahead of process, and only addresses pieces of what's proposed in the attached Issues I'm closing it for now.


Settings tab titles unaligned

On Firefox and full screen in Electron window padding is fine. The problem occurs only in Electron with the default window size that we have. We need to play around with CSS for default window size of electron window.


Implement lesson cards for app-react

Noticed that the LessonCard component in app-react is a work under progress. This should be implemented as soon as possible since it's one of the bare-bone features of the application.

The styles of the cards should be the same as the ones from app-main right?

Thanks for raising this issue! Totally agree and to answer your question, for now, yes. Let's keep things consistent 👍
If you want to take this on Dale, I can assign it to you?

Definitely! You can assign this to me. I'll probably need to pass #129 so that I can focus on this one.

No worries and no rush on either of them!


Linux build error - ghc: panic!

Freshly enlisted repository on Linux (WSL)
NAME="Ubuntu"
VERSION="20.04.5 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.5 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

ghc: panic! (the 'impossible' happened)
(GHC version 8.6.5 for x86_64-unknown-linux):
Prelude.chr: bad argument:<PHONE_NUMBER>

cmake -B build -S .
cmake -B build -S .
-- The C compiler identification is GNU 9.4.0
-- The CXX compiler identification is GNU 9.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PythonInterp: /usr/bin/python2.7 (found suitable version "2.7.18", minimum required is "2.7")
-- Could NOT find PythonLibs (missing: PYTHON_LIBRARIES PYTHON_INCLUDE_DIRS) (Required is at least version "2.7")
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.71.0/BoostConfig.cmake (found suitable version "1.71.0", minimum required is "1.58.0") found components: chrono date_time thread system missing components: unit_test_framework python
-- Boost Python Library:
-- Stack found at /usr/local/bin/stack. Version 2.9.3, Git revision 6cf638947a863f49857f9cfbf72a38a48b183e7e x86_64 hpack-0.35.1
-- Configuring done (35.6s)
-- Generating done (0.5s)
-- Build files have been written to: /home/user/source/rpc/bond/build
</details>

cmake --build ./build/
cmake --build ./build/
[  9%] Generating build/gbc/gbc
/home/user/source/rpc/bond/compiler/bond.cabal was modified manually. Ignoring /home/user/source/rpc/bond/compiler/package.yaml in favor of the Cabal file.
If you want to use the package.yaml file instead of the Cabal file,
then please delete the Cabal file.
ghc: panic! (the 'impossible' happened)
  (GHC version 8.6.5 for x86_64-unknown-linux):
        Prelude.chr: bad argument:<PHONE_NUMBER>

Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug

Error: [S-6374]
       While building simple Setup.hs (scroll up to its section to see the error) using:
       /usr/bin/ghc-8.6.5 -rtsopts -threaded -clear-package-db -global-package-db -hide-all-packages -package base -main-is StackSetupShim.mainOverride -package Cabal-<IP_ADDRESS> /home/user/.stack/setup-exe-src/setup-SvXsv1f_.hs /home/user/.stack/setup-exe-src/setup-shim-SvXsv1f_.hs -o /home/user/.stack/setup-exe-cache/x86_64-linux/tmp-Cabal-simple_SvXsv1f__<IP_ADDRESS>_ghc-8.6.5
       Process exited with code: ExitFailure 1
CMake Error at stack_build.cmake:30 (message):
  build failed - scroll up for its output

make[2]: *** [compiler/CMakeFiles/gbc.dir/build.make:103: compiler/build/gbc/gbc] Error 1
make[1]: *** [CMakeFiles/Makefile2:927: compiler/CMakeFiles/gbc.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

@achindra - The error message suggests this is a ghc bug. Would you mind reporting at: http://www.haskell.org/ghc/reportabug

@bhardwajs, I opened a bug for GHC, however I am concerned how is Linux build passing in the bond pipeline.

This is caused by stale interface files; it's a bug in stack's recompilation checking.

Since this appears to be a bug in stack and not Bond, I'm going to close this issue.


[FEATURE REQUEST] Add Fall 2024

What feature would you like to see added?
Fall 2024 has closed, so there should be an option to do Fall 2024 reviews.
Additional context
Add any other context or screenshots about the feature request here.

Done thank you!


Cow: Watch 09060-631-083

Cow requests the watch of the watch_number 09060-631-083. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Jeff Schaller in Charcoal HQ

Approved by Makyen in Charcoal HQ


Feat: addon readme

Signed-off-by: wangyike<EMAIL_ADDRESS>
Description of your changes

How has this code been tested?

Checklist

I have:

[ ] Title of the PR starts with OAM type (e.g. [Workload] or [Trait] or [Scope]).
[ ] Updated/Added any relevant [documentation] and [examples].
[ ] Unit/E2E Tests added.

this pr should block until this pr: https://github.com/oam-dev/kubevela/pull/2980 merged


Duplicate items in SMB drive after "Cache files and folders for better performance" enabled

Describe the bug
While "Cache files and folders for better performance" is enabled (seems default on), the file/folder list in a mounted SMB drive will duplicate after every refresh.
To Reproduce
Steps to reproduce the behavior:

Enable "Cache files and folders for better performance"
Open a mounted SMB drive
refresh
See error

Screenshots

Desktop (please complete the following information):

OS Version: Windows 10 21286
App version: <IP_ADDRESS>

@jakoss could you take a look at this?

@jakoss could you take a look at this?

@gave92 At first glance i think there's problem with equality check in OrderFiles function:

I'll debug this in spare time

@gave92 At first glance i think there's problem with equality check in OrderFiles function:

I'll debug this in spare time

@gave92 At a first glance i think that's an issue with loading files via AddFileAsync. It adds file by file without clearing _filesAndFolders first (it was cleared earlier before, but it got populated with cache). I think it might be necessary to list files to temporary table and after loading display them at once

@gave92 At a first glance i think that's an issue with loading files via AddFileAsync. It adds file by file without clearing _filesAndFolders first (it was cleared earlier before, but it got populated with cache). I think it might be necessary to list files to temporary table and after loading display them at once


Address Book UI

The Address book feature are requirements described in https://github.com/Electric-Coin-Company/zashi-android/issues/1563

Author

[x] Self-review your own code in GitHub's web interface[^1]
[ ] Add automated tests as appropriate
[ ] Update the manual tests[^2] as appropriate
[ ] Check the code coverage[^3] report for the automated tests
[ ] Update documentation as appropriate (e.g README.md, Architecture.md, CHANGELOG.md, etc.)
[x] Run the app and try the changes
[x] Pull in the latest changes from the main branch and squash your commits before assigning a reviewer[^4]

Note
It is good practice to provide before and after UI  screenshots in the description of this PR. This is only applicable for changes that modify the UI.

Reviewer

[ ] Check the code with the Code Review Guidelines checklist
[ ] Perform an ad hoc review[^5]
[ ] Review the automated tests
[ ] Review the manual tests
[ ] Review the documentation, README.md, Architecture.md, etc. as appropriate
[ ] Run the app and try the changes[^6]

[^1]: Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[^2]: While we aim for automated testing of the application, some aspects require manual testing. If you had to manually test something during development of this pull request, write those steps down.
[^3]: While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: ./gradlew check for Kotlin modules and ./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true for Android modules.
[^4]: Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.
[^5]: In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[^6]: While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

@Milan-Cerovsky can you please provide information on how to properly test these changes? When I hit the new Address Book button in Settings, nothing happens. Also, please note that in the screenshot above, I see the missing plus icon on the left side of the text in the Add New Contact Button.

These are just designs not screens themselves yet :) Please check compose preview and code :) The rest will be coming in next PRs


Close reason: protocol error against zimbra imap and another imap server

I just replaced the IP addresses with < ...IP > entries in the reported logs
Against one imap:
DEBG Windows News       12:01:07 CheckNewMails
DEBG Windows News       12:01:07 CheckImapConnection: DialTLS
IMAP  Windows News      12:01:07 Connected to :993 (Tag=KVJGB)
IMAP Windows News       12:01:11 S:  (read tcp :34130->:993: read: connection reset by peer)
IMAP Windows News       12:01:11 Close reason: protocol error
IMAP  Windows News      12:01:11 Connection closing (flush=false)
IMAP  Windows News      12:01:11 Close error: write tcp :34130->:993: write: broken pipe
IMAP  Windows News      12:01:11 Greeting error: read tcp :34130->:993: read: connection reset by peer
EROR  Windows News      12:01:11 Unable to connect: read tcp :34130->:993: read: connection reset by peer
INFO  Windows News      12:01:11 Waiting new messages
DEBG  Windows News      12:01:11 IdleMailBox
DEBG  Windows News      12:01:11 CheckImapConnection: DialTLS
IMAP  Windows News      12:01:12 Connected to :993 (Tag=ZHTER)
IMAP  Windows News      12:01:16 S:  (read tcp :34132->:993: read: connection reset by peer)
IMAP  Windows News      12:01:16 Close reason: protocol error
IMAP  Windows News      12:01:16 Connection closing (flush=false)
IMAP  Windows News      12:01:16 Close error: write tcp :34132->:993: write: broken pipe
IMAP  Windows News      12:01:16 Greeting error: read tcp :34132->:993: read: connection reset by peer
EROR  Windows News      12:01:16 Unable to connect: read tcp :34132->:993: read: connection reset by peer
INFO Windows News       12:01:16 Error Idle: read tcp :34132->:993: read: connection reset by peer
Against Zimbra imap:
IMAP Windows News       15:39:53 Connected to :993 (Tag=XVRDY)

Please test this issue with Release 4

Feel free to reopen this issue if it does not work


SPFarm create farm: Execution Timeout Expired

Hi,
I have the following error executing SPFarm:
PowerShell DSC resource MSFT_SPFarm  failed to execute Set-TargetResource functionality with error message: Exception calling "ExecuteNonQuery" with "0"
argument(s): "Execution Timeout Expired.  The timeout period elapsed prior to completion of the operation or the server is not responding."
+ CategoryInfo          : InvalidOperation: (:) [], CimException
+ FullyQualifiedErrorId : ProviderOperationExecutionFailure
+ PSComputerName        : XXXXX
The error is raised after detecting no config and no admin database, then the creation is launched.
The configuration portion:
SPFarm CreateSPFarm
{
Ensure                    = "Present"
ServerRole                = "ApplicationWithSearch"
DatabaseServer            = $ConfigurationData.NonNodeData.SQLServer.FarmDatabaseServer
FarmConfigDatabaseName    = $ConfigurationData.NonNodeData.SharePoint.Farm.ConfigurationDatabase
Passphrase                = New-Object System.Management.Automation.PSCredential ('Passphrase', (ConvertTo-SecureString -String $ConfigurationData.NonNodeData.SharePoint.Farm.Passphrase -AsPlainText -Force))
FarmAccount               = $FarmAccount
PsDscRunAsCredential      = $SPSetupAccount
AdminContentDatabaseName  = $ConfigurationData.NonNodeData.SharePoint.Farm.AdminContentDatabase
RunCentralAdmin           = $true
CentralAdministrationPort = 5000
CentralAdministrationAuth	= "NTLM"
}
The mof portion:
instance of MSFT_SPFarm as $MSFT_SPFarm1ref
{
Ensure = "Present";
FarmConfigDatabaseName = "SP_Config";
ServerRole = "ApplicationWithSearch";
PsDscRunAsCredential = $MSFT_Credential1ref;
ResourceID = "[SPFarm]CreateSPFarm";
DatabaseServer = "SP2016SQL.xx.xx.xx\SP2016";
Passphrase = $MSFT_Credential2ref;
SourceInfo = "D:\Sources\Scripts\03_SP_CreateFarmNodesOnly.ps1::25::9::SPFarm";
CentralAdministrationAuth = "NTLM";
RunCentralAdmin = True;
ModuleVersion = "<IP_ADDRESS>";
ModuleName = "SharePointDSC";
CentralAdministrationPort = 5000;
FarmAccount = $MSFT_Credential3ref;
AdminContentDatabaseName = "SP_AdminContent";
ConfigurationName = "SharePointServer";
};
Installing SharePoint 2016 Enterprise on Windows Server 2016
The SharePoint Prereq et Binaries has been run successfully (Patched to January 2018 with Language Pack)
No Wizard launched.
The database has not received any connection from the machine that creating the node. No Db created. The udl test from the targeted server is ok.
Any clues ?
Many thanks

Are there any errors in the Event Logs correlated to this dsc configuration?
Is this issue reproducible? Could you try to apply the configuration a second time and  post the outcome. If the error persists: Which SharePointDsc Version are you using and are you able to start the configuration wizard and connect to your database server?

Hi andikrueger,
Yes i reproduced the error a couple of times, and the Wizard was contacting the database (steps pushed to the finish). But i figured it out by using the machine FQDN. I was using mahine aliases (except for the database: SQL Alias) provided by the DC admin (i don't know the type). When i change them (Small farm) the farm has been created.

Good to hear, that you were able to create the farm.

Yes me too, you can close this issue. There is maybe something to dig around alias usage, but this issue is not linked to SPFarm i guess.


hw/mcu/nordic: Fix hal_timer firing too early

In hal_timer there is a workaround for an RTC compare issue which in
some cases fires timer callback too early. The problem with this code
is that timer value read in a callback will be before what was set
on timer and this is not what callback expects.
To fix this, in case we detect that new compare is too close to current
timer value we should not trigger timer too early but instead enable
TICK interrupt which occurs on every counter change and disable it once
condition for a workaround is no longer valid. This can cause an extra
interrupt on a tick with no timers being handled, but this is ok.

@wes3 @kasjer fixed

previous version (after 1st round of fixes) did not handle delta<0 properly, fixed now. also it was possible that if we have an "empty" interrupt before actual expiry value of 1st timer we would trigger another interrupt instantly so we could spin for a brief moment in an interrupt - also fixed. it seems to work fine now although I did not verify on nrf51 as I do not have one at the moment...


[FLINK-9688] ATAN2 sql function support

What is the purpose of the change
This PR adds SqlFunction atan2
Brief change log

ATAN2 implementation
tests
Documentation updates related to Atan2

Verifying this change
This change added tests and can be verified as follows:
updates in

SqlExpressionTest.scala
ScalarFunctionsTest.scala

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
The serializers: ( no )
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
The S3 file system connector: ( no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? ( docs )
in docs/dev/table/sql.md and docs/dev/table/tableApi.md

@fhueske @hequn8128 @yanghua thank you very much for your review and comments
I did almost all the corrections except one related to atan2 description
So I have a question:
as @hequn8128 wrote

I checked the wiki about atan2, it said: The atan2 function calculates one unique arc tangent value from two variables y and x. So, would it be better of two variables? atan2(y,x) can be the arc tangent of (x,y) or (nx, ny).

At the same time I checked Calcite's definition of it: ATAN2(numeric, numeric) | Returns the arc tangent of the numeric coordinates.
What do you think what is more suitable?


Some ideas and possible PR previews

About some optimizations & improvements:

Optimization: For ImageShape, what is needed in more cases is to retain the original image, such as an emoji, and only use the BlendMode mask mode in the case of a solid color image;

Improvement:

Add Effect Instead of using SetState to refresh the Widget, use CustomPainter({Listenable? repaint}) comes with Listenable to handle additions or deletions, to notify Painter, to provide better performance, and to extend functionality;
For example, NewtonPainter has an object inherited from Listenable that manages the Effect queue.
Effect supports its own Shape, speed, direction and other attributes to cover the global configuration, which has provided greater flexibility, such as randomly ejecting a bunch of funny emoji, or dynamically changing the speed of Effect without fault

First thank you for your feedback,

Optimization: For ImageShape, what is needed in more cases is to retain the original image, such as an emoji, and only use the BlendMode mask mode in the case of a solid color image;

you shouldn’t recreate the ImageShape once created you should reuse it or at least the image can be reused over shapes.

Add Effect Instead of using SetState to refresh the Widget, use CustomPainter({Listenable? repaint}) comes with Listenable to handle additions or deletions, to notify Painter, to provide better performance, and to extend functionality;

I’m not sure how it will improve performance as the widget will still be rebuilt when the listenable will change. Could you provide some pseudo-code of your idea?

Effect supports its own Shape, speed, direction and other attributes to cover the global configuration, which has provided greater flexibility, such as randomly ejecting a bunch of funny emoji, or dynamically changing the speed of Effect without fault

You should already be able to do that, existing effects (explode, rain) are provided mainly as examples. Feel free to create your own Effect and customize how the particles are instantiated. Regarding multiple shapes, it’s a good idea need to check how we could properly add it to the API.

Fixed by #31


#1073 Simplify GitHub issue templates

Type of Change

[x] Chore (changes to the build process or auxiliary tools)

Description
This PR contains two relevant types of changes:

Introduces dedicated issue templates for each labeled type

Bug reports
Maintenance chores
Documentation issues
Enhancements
Feature requests

Simplfies all issue templates to be more 'to the point'

How the Changes Have Been Tested
Not applicable
Checklist

[x] I have performed a self-review of my own code
[x] Related issue number is linked in pull request title
[x] Any dependent changes have been merged and published in downstream modules
[x] I have rebased my branch on top of the latest develop branch

Related Issue
Closes #1073

Failure caused by issue with macos-latest, not caused by framework or proposed changes


feature request: autocomplete links by title

I would like to be able to autocomplete links by title, not just by filename and header.
My notes system uses unique and meaningless filenames, leaving it up to the first H1 in the note to define the note's title. When I am writing a link in another note, I would like the autocomplete to search by this title, and exclude the filename entirely (from the search).
When actually inserting the link, the title should be the link text, and the filename should be the link destination, eg. (My Note File)[12345678.md] for markdown links or [[12345678.md|My Note File]] for wikilinks.
As an additional extension, I expect other people with different setups would like to define their note titles differently, including from the filename or from frontmatter. This obviously is less important to me personally!

Hey!
This is planned for v1!


Add pelias panel ltr

A couple of tweaks for #699.

Merged by https://github.com/ibi-group/datatools-ui/pull/699/commits/3f832614074de2f1b2e1115af38a539c3d5b9e1a


Compiler error when using a method defined on Object for an variable of type T | Nil

Reproducing Code Sample
class Object
  def map?(&block)
    if nil?
      nil
    else
      yield self
    end
  end
end

puts "foo".map?(&.upcase).inspect
puts nil.map?(&.upcase).inspect
a = if rand > 0.5
      "foo"
    else
      nil
    end
puts a.map?(&.upcase).inspect

Error message on crystal build:
BUG: trying to assign Nil <- String (Exception)
  from Crystal::CodeGenVisitor#assign<LLVM::Value, Crystal::Type+, Crystal::Type+, LLVM::Value>:(Bool | LLVM::Value | Nil)
  from Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::CodeGenVisitor>:Nil
  from Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::CodeGenVisitor>:Nil
  from Crystal::CodeGenVisitor#visit<Crystal::Call>:Bool
  from Crystal::CodeGenVisitor#visit<Crystal::Call>:Bool
  from Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::CodeGenVisitor>:Nil
  from Crystal::CodeGenVisitor#prepare_call_args_non_external<Crystal::Call, Crystal::Def+, Crystal::Type+>:Tuple(Array(LLVM::Value), Bool)
  from Crystal::CodeGenVisitor#visit<Crystal::Call>:Bool
  from Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::CodeGenVisitor>:Nil
  from Crystal::CodeGenVisitor#prepare_call_args_non_external<Crystal::Call, Crystal::Def+, Crystal::Type+>:Tuple(Array(LLVM::Value), Bool)
  from Crystal::CodeGenVisitor#visit<Crystal::Call>:Bool
  from Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::CodeGenVisitor>:Nil
  from Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::CodeGenVisitor>:Nil
  from Crystal::Compiler#codegen<Crystal::Program, Crystal::ASTNode+, Array(Crystal::Compiler::Source), String>:(Tuple(Array(Crystal::Compiler::CompilationUnit), Array(String)) | Nil)
  from Crystal::Compiler#compile<Array(Crystal::Compiler::Source), String>:Crystal::Compiler::Result
  from Crystal::Command#run:(Bool | Crystal::Compiler::Result | Nil)
  from main
Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

Crystal version is
Crystal 0.26.1 (2018-08-27)                                                                                │
                                                                                │
LLVM: 6.0.1                                                                                │
Default target: x86_64-apple-macosx

macOS is version 10.13.4

I guess the trouble is that self is not restricted to non-nil. However, it doesn't work when storing it in a local variable, either.
This however is a working solution, similar to how .try is implemented:
class Object
  def map?(&block)
    yield self
  end
end
struct Nil
  def map?(&block)
    nil
  end
end

Nevertheless, the initial code should either work or raise a proper error, not a compiler bug.

Hello,
I modified some instances of the firstNonWhite variable, as it could possible have a racist undertone. "First non white person of whom?"
Also changed it to be more expressive for what that variable is actually doing (and less oppressive).
Since @mverzilli thinks it's okay to close my PR without any justification. You will get spammed. Enjoy!

Fixed? The original example now gives
"FOO"
nil
nil

Crystal 0.31.1 on MacOS
$ crystal --version
Crystal 0.31.1 (2019-10-02)

LLVM: 8.0.1
Default target: x86_64-apple-macosx

Indeed, nil? is now parsed like self.nil? and so usual type flow restrictions now apply.


[RHDM-670] Update RHDM Templates to be in a similar structure as RHPAM Templates

[RHDM-670] Update RHDM Templates to be in a similar structure as RHPAM Templates
https://issues.jboss.org/browse/RHDM-670
Signed-off-by: David Ward<EMAIL_ADDRESS>Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[x] Pull Request title is properly formatted: [RHDM-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Attached commits represent units of work and are properly formatted
[x] You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
[x] Every commit contains Signed-off-by: Your Name<EMAIL_ADDRESS>- use git commit -s

Hey @errantepiphany why are you adding database templates? (externaldb and mysql)

@spolti All I did is copy/paste + search/replace. I have yet to remove things that don't make sense, but I will.

Ah, ok :)

@errantepiphany Looks good to me, at least in terms of templates and the components in them, without checking that every t is crossed and every i dotted. Why not rename rhdm71-prod-kieserver-s2i.yaml to rhdm71-prod-immutable-kieserver.yaml, since it is immutable and that would be more consistent with RHPAM naming?

@bmozaffa s2i template renamed to immutable per your suggestion. :)

@spolti @jakubschwan @sutaakar @bmozaffa  Another look, please? I think we're all good now. I also added SSO+LDAP to the templates that didn't have it, per our call on Tuesday.

@errantepiphany , just a curiosity, did you test the templates with the validator? :)

@spolti No, because I can't seem to get the validator to build on my machine... :(

@sutaakar @jakubschwan @spolti Should be all set now, finally? (LOL) Can I get an approval please?

There is a few of KIE server, instead Server.on the templates.


make a structure for colour values

So that the values stack over each other. Maybe even use a table(gasp)

I've made a pattern. I think it's the best markup, but I'm not wild about its editability (this is a perfect use of a plugin, but without getting fancy plugins are off the table)
@tuksun  Could you move the current tables into this format please?


Support (original) ImageJ ROI and Overlay

We can get selected Shape(s) from napari's active Shapes layer. Can we turn this into a ROI/Overlay, to pass to the original ImageJ's Measure command?

Related to this is this comment, which describes a way that we could transfer Shapes layers with an Image layer.

This issue would be closed by #267


Update diffs on changes

When the user presses "Accept" or "Reject" on a diff, all of the diffs below should be updated, because they are now on different line numbers.

and can i have more info

Approved and Reject Section
Screencast
Screencast from 2024-09-20 13-04-23.webm
After selecting a section of the code and pressing Ctrl + L, the following interface appears.

@liamstamper just do it and send PR

Did you push any code? I'm not sure what this video is showing.

Thanks @mathewpareles.


emacs: add versatile "emacsWrapper"

Motivation for this change
"emacsWrapper" replaces emacsWithPackages. In addition to "packagesFun",
emacsWrapper has an optional variable called "execStart". execStart can
be used to append elisp to the default site-start.el script. This is
useful for providing a way to load a user's .emacs.d/init.el
file. "emacsWithPackages" is implemented with emacsWrapper for
convenience and compatability.
Things done

[ ] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

cc @ttuegel @oxij @DamienCassou

I don't feel confident enough to say anything about the PR. I'm not even sure that my Emacs configuration is correct (at least, it is different from the recommended setup).

I'm not even sure that my Emacs configuration is correct (at least, it is different from the recommended setup).

Your configuration should be equivalent to the recommendation, i.e. overriding emacsPackagesNg and overriding emacs should commute.


feat: add --config & --generated-files-dir option to CLI

Motivation
We're trying to get docusaurus to play nicer with bazel, which relies heavily on explicit IO. Currently docusaurus makes a lot of assumptions on folder structure based on siteDir (e.g .docusaurus temp folder & docusaurus.config.js). The new CLI options allow user to control:

--config controls the path to docusaurus.config.js.
--generated-files-dir controls the path to .docusaurus folder which is used for deployment.
Fixes deployment issue where it needs generated files dir but in reality it just needs a tmpdir. This prevents issue where generated files dir is read-only (in bazel scenario).

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Upstream bazel setup: https://github.com/formatjs/formatjs/blob/main/website/BUILD#L50
Related PRs

@slorber if u can review that'd be great! Thanks!

Thanks, will take a deeper look tomorrow but that looks nice.
Just wondering if having 2 new cli options for a quite niche use-case isn't going to clutter a bit our API?
Could it make sense to keep using env variables instead and document these differently than widely used cli options?
Could we use only --config and configure the .docusaurus folder through the config file instead?
I don't have strong opinions, just wondering what's the best public API choice for this.

yeah that works too I'm fine w/ either option. LMK and I'll change it :)

Note: we could basically have a need to allow customizing all these constants:
packages/docusaurus/src/constants.ts
export const BABEL_CONFIG_FILE_NAME = 'babel.config.js';
export const BUILD_DIR_NAME = 'build';
export const CONFIG_FILE_NAME = 'docusaurus.config.js';
export const GENERATED_FILES_DIR_NAME = '.docusaurus';
export const SRC_DIR_NAME = 'src';
export const STATIC_DIR_NAME = 'static';
export const OUTPUT_STATIC_ASSETS_DIR_NAME = 'assets'; // files handled by webpack, hashed (can be cached aggressively)
export const THEME_PATH = `${SRC_DIR_NAME}/theme`;
export const DEFAULT_PORT = 3000;
export const DEFAULT_PLUGIN_ID = 'default';

At least it has been requested already the ability to customize STATIC_DIR_NAME.
My point is that I would find it odd if we would end up with many start/build options, most of them are barely used by anyone.

Although the bigger question would be, is generatedFilesDir just a tmpdir or is there some significance to it? I saw it being used in webpack to resolve @generated but those get inlined after packaging. How about the server side? If it's only used as tmp I'd just switch to mkdtemp and have the consistency basically.

Honnestly I don't know too much the impact of changing .docusaurus to a tmp folder. I think we could do that technically, but having this folder in the site can be useful for debugging.
And we could later leverage some kind of image resizing or Webpack 5 build caching inside it so we should be able to read from the .docusaurus folder of the previous build (ie it should be constant across builds). Will have to double-check that to be sure, but would rather delay this change after we upgrade to Webpack 5 just in case.

ok gotcha. Yeah I don't really mind 1 way or the other as long as there's a way to customize it (env var, param, config file...)

So, I see a few use-cases where --config can be useful as a cli option.
For .docusaurus I'd say it can stay as an env variable to avoid cluttering the cli API. Note neither Gatsby or Next do allow to customize .cache or .next/cache btw.
Going to edit a bit your PR and merge it asap, thanks

@longlho have you tested this with .docusaurus being replaced by an absolute path outside of the monorepo?
I'm trying this and it fails:
DOCUSAURUS_GENERATED_FILES_DIR_NAME=/tmp/test-docu yarn workspace docusaurus-2-website build:blogOnly

This is somehow expected as this tmp folder does not have any node_modules  to read, and the generated files contain require/import calls to import React.

Note I tested to revert my local changes and it does not work either.
yarn workspace docusaurus-2-website build:blogOnly => OK
yarn workspace docusaurus-2-website build:blogOnly --generated-files-dir /tmp/test-docu => KO with a similar error

hmm gotcha I'll take a look. What's the server bundling btw?

hmm gotcha I'll take a look.

I don't mind merging a way to customize the .docusaurus folder, but would this actually solve your usecase if you can't use /tmp/.docusaurus-123 ? The current limitation is that this folder should be able to read the node_modules of your site, so rather be a subfolder of your site (or at least  subfolder of the monorepo)

What's the server bundling btw?

What do you mean? Webpack?

@slorber yes subfolder of the monorepo is what I'm looking for. For context bazel creates a sandbox for every build and symlink dependencies in, including node_modules. I'm actually ok w/ dropping the generatedFilesDir config param for now since it's not blocking me anymore.
By server bundling I mean I don't know what the server component of docusaurus is since I only use the client bundle and throw it on GH pages.

@slorber yes subfolder of the monorepo is what I'm looking for. For context bazel creates a sandbox for every build and symlink dependencies in, including node_modules. I'm actually ok w/ dropping the generatedFilesDir config param for now since it's not blocking me anymore.

Ok, so I'll push to your PR with my updates/cleanups. We'll keep that .docusaurus customization env variable undocumented for now as it does not work in all cases.

By server bundling I mean I don't know what the server component of docusaurus is since I only use the client bundle and throw it on GH pages.

We don't have any server like Next. We generate files in .docusaurus and use the generated files during the build process, assuming those files can find a node_modules folder in a parent dir.

So, just pushed my update.
As a summary, this works:
yarn workspace docusaurus-2-website build:blogOnly

DOCUSAURUS_GENERATED_FILES_DIR_NAME=/Users/sebastienlorber/Desktop/projects/docusaurus/website/.docusaurus-test-gendir yarn workspace docusaurus-2-website build:blogOnly

But this won't work, and afaik it's not a problem for your use-case:
DOCUSAURUS_GENERATED_FILES_DIR_NAME=/tmp/test-docu yarn workspace docusaurus-2-website build:blogOnly


Image in CropeImageView show in very small size

I have dynamically add the Image to CropImageView but the image is looked like very small.
Even i am not able to set the scaletype to that imageView.
<com.edmodo.cropper.CropImageView
android:id="@+id/CropImageView"
android:layout_weight="1"
android:layout_width="fill_parent"
android:layout_height="fill_parent"/>
In Java:
Bitmap bitmap = null;
try {
bitmap = MediaStore.Images.Media.getBitmap(this.getContentResolver(),imageUri);
} catch (IOException e) {
e.printStackTrace();
}
cropImageView.setImageBitmap(bitmap);
Please let me know, what to do if i want to cover the image in device screen. Right now it is display as small. If i user image in big size then it display well in it.
Sincerely,
Shreyash

Even I am facing the same issue, for any ImageView, this issue will be solved if we use scaleType. But here scaleType does not apply. And this happens only if the image dimensions are very small, though it should stretch and show it.

Any solution

This is my beginCrop() http://pastebin.com/BHXdhPQ2, (I am setting height width of result bitmap as per size of my imageView). You can check this https://github.com/edmodo/cropper/issues/21 for a permenant fix.