[v2] How to work with login pages

I am using the Framework7 Vue Webpack starter pack.
My default page ('/') is a login page.  My plan is to run a xhr request as soon as any page in the app is requested.

So I tried putting the isLoggedIn() call in the onF7Ready(f7). If logged in I thought I would use this to take the user to the home screen - self.$f7router.navigate('/home/'); else I would take the user to the Login page. Then I learnt the $f7router is only accessible in the Route Components.
Then I thought I will put the isLoggedIn() check in each and every page's pageInit(). So I tried putting that code in the login.vue file in

on: {
    pageInit(e) {

The $f7router is available here but the self.$f7router.navigate('/home/'); does not work. The same self.$f7router.navigate('/home/'); however does work if I use it in one of the methods in the same login.vue file.
Even if the above code did work, there must be a better way of checking if a user is logged in and then do things in a much better way then I am doing. All my routes except for the  ('/') require authentication.
Can anyone tell me how I should approach this very standard issue? Thanks a lot.

Router navigate won't work in pageInit because routing is still in the process. I can recommend you the following app structure:
<div id="app">
  <f7-view v-if="$root.isLoggedIn" url="/"></f7-view>
  <f7-login-screen v-if="!$root.isLoggedIn">
    ...
  </f7-login-screen>
</div>

So when you set isLoggedIn prop on app root then you will have main view, otherwise you will have login screen. And if you have api calls then it is better to check and set the isLoggedIn there

Thanks. I will try it out and post results here.


Added Intermediate Tutorial on Distributed Training with CIFAR10

Converted CIFAR10 Distributed example into an intermediate tutorial with explanation for every function and outputs for different configurations.
To do:

[x] Check if the tutorial is running on single node, multiple GPUs and multiple node, multiple GPUs.

@sdesrozis I have made the suggested changes!

@vfdev-5 I have made the suggested changes!

In the end of the tutorial let's put links to ClearML experiments to explore the runs.

@vfdev-5 can you please review this again?

@Priyansi I left some comments.

Thank you for the suggestions @sdesrozis and @vfdev-5 . I left a few comments as well.

@vfdev-5 I added the note for TPUs and included the output for both TPUs and Jupyter Notebooks.

@Priyansi thanks for all the updates ! There are few other things to update in above comments.
In the end I think we have to provide a link on complete code:

cifar10-distributed.py near the notebook in the folder
Links to ClearML experiments (https://github.com/pytorch-ignite/examples/pull/26#issuecomment-913455194). Let's do that once PR is merged and we'll update the notebook


Set default shell

I want ubuntu as my default shell. How to do that?
When I open the terminal app, I would like to see ubuntu be opened instead of powershell.

You can do this setting in the profiles.json file. There you find the option to set the default profile for your terminal.
You'll find the correct GUID for your profile in the profiles section of the file.

Thank you!
It worked. For people also looking for the answer:
{
    "globals" :
    {
        "alwaysShowTabs" : true,
--      "defaultProfile" : "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
++      "defaultProfile" : "{2c4de342-38b7-51cf-b940-2309a097f518}",
        "initialCols" : 100,
        "initialRows" : 25,
        ....

This worked for me. Where {2c4de342-38b7-51cf-b940-2309a097f518} is the value of the "guid" in my ubuntu profile.


Live Server: Reload doesn't properly set forward and back buttons

Testing #124865

Have an index.html file open in preview
Reload window
The forward and back buttons show as not disabled
Click refresh
🐛 Now they're disabled. They should always have been disabled.

I can't seem to replicate this issue. :(  Can you try using the new vsix from https://github.com/andreamah/VS-Code-LiveServer-V2-Extension/releases/tag/0.2 and see whether it still happens?


The hackage version is broken

And so is the current master:
https://hackage.haskell.org/package/discord-hs-0.3.2/src/src/Network/Discord/Rest/Prelude.hs
Fetched has kind *, and, AFAIK, can't be a Functor or a Comonad.

Yes, #13 should probably be reverted. Fetched isn't being used as a Functor or Comonad anywhere at the moment.


Adding support for struct decoding

Hello. You ever have one of those days where you are just click-clacking around having a good old time, when BAM - you get
[error] GenServer ContractManager terminating
** (FunctionClauseError) no function clause matching in ABI.TypeDecoder.decode_type/2
    (ex_abi 0.5.8) lib/abi/type_decoder.ex:245: ABI.TypeDecoder.decode_type(:tuple, <<0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 5, 141, 21, 225, 118, 40, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ...>>)
    (ex_abi 0.5.8) lib/abi/type_decoder.ex:271: anonymous fn/3 in ABI.TypeDecoder

Ouch!
You take a look at the stack trace and cruise on over to ex_abi and look for similar issues and find https://github.com/poanetwork/ex_abi/issues/51. Hmmmm the journey begins.
The following is a brief tale of sorrow and glory. I was attempting to retrieve a Struct from a smart contract, but when making the call boom - error. Surely I did something wrong. I double check things and start to presume that I didn't do anything incorrectly (a fairly dangerous assumption to be sure). After looking for awhile I notice the following code:
    output_types = Enum.map(abi[name]["outputs"], fn x -> x["type"] end)
    types_signature = Enum.join(["(", Enum.join(output_types, ","), ")"])
    output_signature = "#{name}(#{types_signature})"

which for a struct returns the following type
"get((tuple[]))"

If you follow the trail into ABI.decode you'll find that that string representation makes it way through Parser.parse!()
resulting in the following function selector type
types: [tuple: [array: :tuple]]

that last :tuple is what makes ex_ab blow up. Hmmm but why?????
It turns out that defined in the latest https://docs.soliditylang.org/en/v0.8.10/abi-spec.html structs are handled as tuples - and are handled differently

Handling tuple types
Despite that names are intentionally not part of the ABI encoding they do make a lot of sense to be included
in the JSON to enable displaying it to the end user. The structure is nested in the following way:
An object with members name, type and potentially components describes a typed variable. The canonical type
is determined until a tuple type is reached and the string description up to that point is stored in type
prefix with the word tuple, i.e. it will be tuple followed by a sequence of [] and [k] with integers k.
The components of the tuple are then stored in the member components, which is of array type and has the
same structure as the top-level object except that indexed is not allowed there.

So the code above fails to work for decoding struct. The type is incorrect and ex_ab chokes on the bad input. It's expecting something like the following instead:
[array: {:tuple, [uint: 256, uint: 256]}]

Well....hmmm, that code doesn't currently do that? We'll need to checkout the components section of the abi - write unit tests and write some logic???
It turns out ABI has done all that right over here >>>> https://github.com/poanetwork/ex_abi/blob/master/test/abi/type_decoder_test.exs#L137
So there isn't a need for us to reinvent the wheel.
I started off with creating a failing test - added a new smart contract that shows off how a returning struct fails. Great. Now we'll just change a bit of code to parse the abi passed in using the elixir ABI.parse_specification  function that parses the abi and does all the heavy lifting of figuring out how to deal with weird tuple types. Great!
My test passes!!! Woo Hoo! Ready to submit a PR.....and whoa hold my horses. When I run a full test I now get a failing test for an seemingly unrelated issue.
That night instead of sleeping I spend that night thinking about what I did that would break other things?
Day 2
I dig into the failing ArrayTester test and I notice the following.
 {:ok, result} = ExW3.Contract.call(:ArrayTester, :dynamicUint, [1, 2, 3])
which uses
ABI.TypeEncoder.encode_raw
under the hood.
The encoding that is sent is as follows:
0x5d4e0342
0000000000000000000000000000000000000000000000000000000000000020
0000000000000000000000000000000000000000000000000000000000000020
0000000000000000000000000000000000000000000000000000000000000003
0000000000000000000000000000000000000000000000000000000000000001
0000000000000000000000000000000000000000000000000000000000000002
0000000000000000000000000000000000000000000000000000000000000003

The expected return value is [1,2,3] however, we send something extra. Upon receipt of the call we get the result of what was sent
[3,1,2,3,0,0,0.......

That's definitely not right!
Running the same contract in Remix I see the following encoding:
0x5d4e0342
0000000000000000000000000000000000000000000000000000000000000020
0000000000000000000000000000000000000000000000000000000000000003
0000000000000000000000000000000000000000000000000000000000000001
0000000000000000000000000000000000000000000000000000000000000002
0000000000000000000000000000000000000000000000000000000000000003

Which omits the extra empty segments and does result in the expected results of [1,2,3]
I'm curious if that extra encoding existed prior to my pesky meddling? And it does. The encoding has always been off. It turns out that my fix of using the correct type started to correctly decode - wrong encoded things - ending up with a single failing test. wow.
That's right, we're unnecessarily wrapping everything in an extra tuple. If you compare what exw2 encodes to other libraries - there's always an extra tuple. Hmmmm.
OK no big deal, just remove the extra tuple. However, when you do that you get all kinds of errors.
If I compare the types ex_abi is working with we see the following
ABI.FunctionSelector.decode_raw("(uint256[])")
{:tuple, [array: {:uint, 256}]}

vs
iex(2)> ABI.FunctionSelector.decode_raw("uint256[]")
[uint: 256]

Let's look at that again:
iex(1)> ABI.FunctionSelector.decode_raw("(uint256[])")
[tuple: [array: {:uint, 256}]]
iex(2)> ABI.FunctionSelector.decode_raw("uint256[]")
[array: {:uint, 256}]

Notice those extra parentheses? Now, check this very very similar method out:
iex(2)> ABI.FunctionSelector.decode("(uint256[])")
%ABI.FunctionSelector{
  function: nil,
  input_names: [],
  inputs_indexed: nil,
  method_id: nil,
  returns: [],
  type: nil,
  types: [array: {:uint, 256}]
}
iex(3)> ABI.FunctionSelector.decode("uint256[]")
** (MatchError) no match of right hand side value: {:error, {1, :ethereum_abi_parser, ['syntax error before: ', '\'[\'']}}
    (ex_abi 0.5.7) lib/abi/parser.ex:15: ABI.Parser.parse!/2

It turns out that decode_raw adds extra parans .....because the ABI.Parser syntax needs it - it's part of that AST, It's not a tuple at all!
decode assumes you've added that those extra parans. _raw functions don't.
def decode_raw(type_string) do
  {:tuple, types} = decode_type("(#{type_string})")
  types
end

And my code is using both versions so I fix the array test and it causes other tests to break. So I fixed those as well. I also noticed that the commented out tests don't actually pass in ganache at all the return types where incorrect you can't add {:ok, 5} + 5 so I also fixed those. So recap.

added a test to highlight returning a struct
added code to make structs pass
added code to remove the extra tuple we were mistakenly wrapping all the types in (or at least that's what it looked like to me)
got the commented out tests passing again

Some other thoughts - I'm currently parsing the abi file for every call. It would be much much better to parse that as part o the abi loading, but I think this had enough churn without adding that. I appreciate and look forward to your feedback as well as any clarifications you could make since I probably misunderstood something along the way. Notice I haven't written a test for passing a struct into a call. I think even if you don't like or use the implementation the test will highlight the goal of why I started down this path in the beginning. Thanks!

rebased on master

@rupurt

I do get all passing on my fork

@gregors thanks for updating. Sorry for the delayed response. I haven't had the time to dedicate to maintenance but starting to get back in the swing of things.

@gregors Thanks for this update! It seems that ex_abi has been updated and now exw3 doesnt need to try compensate for its behavior.
The extra parens were me wrapping ex_abi's output to something that was actually usable. Glad this got fixed upstream. It has been a while since I wrote that code and I haven't needed to change it.
As for the names for the structs #101 is generating contract code at compile time, so including the struct names might be a natural fit with that feature.

Gotcha - closing my PR since you seem to have a way forward. I would say that you may want to add tests that specifically test your encoding logic. I think most people would be surprised in a bad way to find incorrect encoding taking place under the hood.

Ah, I was a bit surprised you closed the PR. Your work seems quite helpful, I was merely suggesting that adding names for struct fields could be added after the contract compilation feature is added.
Your struct decoding I think is great and a welcome addition.

@hswick oh gotcha, I misunderstood. I'll re-open it. and see if I can incorporate the names.

actually I'll, refactor a bit to separate the encoding issues from the struct logic


FIX #4100 Setup the ability to overload the ShortcodeParser class and en...

Setup the ability to overload the ShortcodeParser class and ensuring its methods/properties are extensible via "static" keyword. Fixes issue #4100.

Updated commit to change access to local properties/constants (which were changed to protected) to use self keyword instead of static keyword due to the Travis CI build errors for PHP 5.3.

Thanks Patrick! In general, we have to move those enhancements to the 3.2 release line ("3" branch here in framework), but its a low risk change so making an exception here.

Ok no problem. That being said: Do you think maybe #4140 should then be rebased upon 3 instead of 3.1 like it is now?


Precached content filesizes are duplicated on page reload

Library Affected:
workbox-sw v. 3.6.3
Browser & Platform:
all browsers
Precached content filesizes are duplicated on page reload:
On initial install the precached assets are added to the storage and when you reload they duplicate in size even though you cannot visibily see it in the cached files themselves in the devtools. The temp cache seems to hang around as empty. And when an actual change  happens in the source files the temp cache is again populated making the cache storage now triplicate of the original.
So initially the assets are precached on install (3mb) > reload > it's now 6 mb, yet the files in the actual cache have not changed size > source files change and temp cache is populated > total cache storage is now 12 mb (assuming the sourcefiles size didn't actually change dramatically).
Here is a 15mb file that is the only thing in the cache storage

And here is the total cache storage size displayed after page reload (and sourcefiles have not changed on pagereload

The same issue can also be seen by logging the storage quota and usage, it displays the total as duplicate of the only thing stored in the cache.

 const _storageStats = await navigator.storage.estimate();
        console.log(_storageStats);
output: {quota:<PHONE_NUMBER>4, usage: 33681672}

Does this amount to a bug report about Chrome DevTool's storage quota interface, or do you believe that Workbox is storing more data than it should be?
I know that there were several issues with how quota info is displayed in DevTools that the Chrome engineering team was working on—some of them might be better in the current Chrome Canary.
Storing new/modified URLs in the -temp cache while a new service worker waits to activate is expected behavior in Workbox right now, but that will likely change if/when #1793 is implemented.

Does this amount to a bug report about Chrome DevTool's storage quota interface, or do you believe that Workbox is storing more data than it should be?

I believe workbox is storing the precached content somehow duplicated outside of the temp caching.  I managed to log it increase in size on first page load and then when I actually edited some of my source files the new precache was there waiting on top of that. Meaning when I had precached all my content initially on first page visit, it then duplicated the precached content size(but at least visibly not the files themselves) on a second page load. However the temp cache was empty since source files were not changed and no need to fill the temp cache was there.

I know that there were several issues with how quota info is displayed in DevTools that the Chrome engineering team was working on—some of them might be better in the current Chrome Canary.

While I first noticed said issue in the chrome devtools, I also managed to log the issue with  navigator.storage.estimate()
Also in firefox 64.

Storing new/modified URLs in the -temp cache while a new service worker waits to activate is expected behavior in Workbox right now, but that will likely change if/when #1793 is implemented.

Yep, this worked as intended.

While this project of mine was not the one I got the issue with originally, I still managed to at least see some very weird amount of data stored in the cached storage. The site does put a lot of stuff in cache, but it seemed to show much more than it stored.
It didn't duplicate, but the amount did not even close to match that of the sizes of the cached files.

I believe workbox is storing the precached content somehow duplicated outside of the temp caching.

I don't think that's the case, but you could get a compete dump of the entirety of the Cache Storage API entries for an origin with the following snippet:
for (const cacheName of await caches.keys()) {
  const cache = await caches.open(cacheName);
  for (const request of await cache.keys()) {
    console.log(`${cacheName} contains ${request.url}`);
  }
}

If you see multiple entries for resources, not withstanding the expected -temp content while a new service worker waits to activate, then that sounds like a bug in Workbox. I'm not seeing anything out of the ordinary when running that against https://bytons.github.io/aurelia_pwa/
Otherwise, there are a few issues that I've seen in the past related to how Chrome reports quota usage, and this might be related. Testing in Chrome Canary would help determine whether recent changes have improved things, but it's largely outside of Workbox's control.

Could not reproduce it anymore on canary nor stable.
Might have been a fluke or some other unrelated error in my own project.


Allow publicly accessible cluster machines

This is aimed at users who want to use the cluster module without the bastion setup provided.
This pull request adds the option of public access on created cluster machines.
The user would still need to update the specified security group to allow public access.

thanks!


installation/ gameplay

I followed all the directions step by step and when i activated CCL my game froze, afterward I restarted because that's what the page said to do and when i did the screen for rimworld went black and now i can't play please help.

Some people have had issues with "dirty installs" of either the core game or CCL.  Be sure to run and exit RimWorld at least once before activating any mods so the game can create all the necessary config files.

Is this still an issue?  Haven't heard anything back.

I'm sorry and nothing was loading after a few weeks while still checking in  to see if I got any answers so I deleted all of the extra stuff and now it won't let me redownload it

The core game has sometimes issues with old versions of it's own config files.  The best bet would be to do a completely clean install.  A14D just came out on steam (no sendowl e-mail sent) and CCL is about to be released for the new build.

Based on lack of info to reproduce and lack of feedback, closing this as it seems it's an installation issue.
If the problem persists and you can provide new info then feel free to add more to this and I'll re-open it.


feat: fold acir programs

Please read contributing guidelines and remove this line.

Benchmark results
Metrics with a significant change:

protocol_circuit_witness_generation_time_in_ms (root-parity): 108 (+100%)
protocol_circuit_proving_time_in_ms (private-kernel-tail-to-public): 98,358 (+20%)
protocol_circuit_proving_time_in_ms (private-kernel-tail): 42,338 (+20%)
protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 54,991 (+17%)
protocol_circuit_proving_time_in_ms (base-rollup): 88,410 (+19%)
protocol_circuit_proving_time_in_ms (root-parity): 52,730 (+20%)
protocol_circuit_proving_time_in_ms (public-kernel-tail): 188,147 (+21%)
protocol_circuit_proving_time_in_ms (root-rollup): 23,689 (+22%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.
| Metric |  |
| - |  |
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,464
9,464
9,464

l1_rollup_execution_gas
616,105
616,105
616,105

l2_block_processing_time_in_ms
1,362 (-2%)
5,096 (-2%)
10,175 (-1%)

l2_block_building_time_in_ms
47,165 (-1%)
186,239 (-1%)
372,753 (-1%)

l2_block_rollup_simulation_time_in_ms
46,995 (-1%)
185,605 (-1%)
371,488 (-1%)

l2_block_public_tx_process_time_in_ms
25,253 (-3%)
104,672 (-3%)
214,744 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
9,877 (-1%)
15,144

node_database_size_in_bytes
14,475,344
21,348,432

pxe_database_size_in_bytes
18,071
29,868

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
protocol_circuit_simulation_time_in_ms
protocol_circuit_witness_generation_time_in_ms
protocol_circuit_proving_time_in_ms
protocol_circuit_input_size_in_bytes
protocol_circuit_output_size_in_bytes
protocol_circuit_proof_size_in_bytes
protocol_circuit_num_public_inputs
protocol_circuit_size_in_gates

private-kernel-init
160 (-1%)
3,452 (-7%)
25,095 (+14%)
19,990
61,798
86,720
2,643
1,048,576

private-kernel-inner
604 (-1%)
3,962 (-7%)
55,437 (+15%)
88,862
61,798
86,720
2,643
2,097,152

private-kernel-tail
531
2,706 (-5%)
:warning: 42,338 (+20%)
86,653
76,438
10,624
265
2,097,152

base-parity
6.51 (-3%)
1,285 (+5%)
2,855 (-2%)
128
64.0
2,208
2.00
131,072

root-parity
48.9 (-3%)
:warning: 108 (+100%)
:warning: 52,730 (+20%)
27,084
64.0
2,720
18.0
2,097,152

base-rollup
762 (+1%)
2,387 (+4%)
:warning: 88,410 (+19%)
119,578
756
3,648
47.0
4,194,304

root-rollup
112 (-3%)
78.8 (+23%)
:warning: 23,689 (+22%)
25,297
620
3,456
41.0
1,048,576

public-kernel-app-logic
524 (-1%)
2,865
:warning: 54,991 (+17%)
103,405
84,766
116,832
3,584
2,097,152

public-kernel-tail
1,187 (-1%)
26,744 (+7%)
:warning: 188,147 (+21%)
393,850
7,490
10,624
265
8,388,608

private-kernel-reset-small
581 (-1%)
2,495 (+6%)
28,249 (+14%)
118,173
61,798
86,720
2,643
1,048,576

merge-rollup
28.8 (-2%)
N/A
N/A
16,534
756
N/A
N/A
N/A

public-kernel-setup
636 (+1%)
N/A
N/A
103,405
84,766
N/A
N/A
N/A

public-kernel-teardown
544 (+2%)
N/A
N/A
103,405
84,766
N/A
N/A
N/A

private-kernel-tail-to-public
N/A
8,877 (-10%)
:warning: 98,358 (+20%)
N/A
N/A
116,832
3,584
4,194,304

Stats on running time collected for app circuits

Function
app_circuit_proof_size_in_bytes
app_circuit_proving_time_in_ms
app_circuit_size_in_gates
app_circuit_num_public_inputs

SchnorrAccount:entrypoint
16,128
52,281 (+14%)
2,097,152
437

Token:transfer
16,128
48,093 (+11%)
2,097,152
437

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
11.0 (-3%)
18.1 (-3%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.642 (-4%)
0.554 (-3%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
51.9 (-2%)
80.6 (-2%)
261 (-3%)
503
989 (-2%)
1,964 (-2%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.529 (-3%)
0.497 (-2%)
0.475 (-2%)
0.470
0.469 (-2%)
0.469 (-2%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
61.7 (-3%)
119 (-2%)
379 (-2%)
740
1,473 (-2%)
2,939 (-2%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.535 (-3%)
0.534 (-2%)
0.513 (-2%)
0.510
0.511 (-2%)
0.510 (-2%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
66.4 (-2%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
107

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.589 (-2%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
82,705
664,768

Transaction size based on fee payment method
| Metric |  |
| - |  |
Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
12,113 (+9%)
4,221 (-1%)
78,184 (+12%)

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
8 public data writes

tx_sequencer_processing_time_ms
3,209 (-2%)
2,101 (-3%)
6,126
2,279 (-1%)
2,542 (-3%)


Case-insensitive Discovery message type names

Windows NTFS is case-insensitive, so this PR escapes DiscoveryField identifiers that are the same, disregarding character casing.
Introduce global table of DiscoveryFields to prevent duplicate creation of DiscoveryFields from the same Schema.
Constructor for DiscoveryFields enforces unique, case-insensitive identifiers for message-type Schemas.
Refactor SchemaTypeName* utils to use DiscoveryFields instead of Schemas. This allows the TypeName utils to use the DiscoveryField's unique identifiers.

PTAL

Codecov Report

Merging #1956 into master will increase coverage by 0.01%.
The diff coverage is 85.93%.

@@             Coverage Diff              @@
##             master    #1956      +/-   ##
============================================
+ Coverage     85.93%   85.94%   +0.01%
- Complexity     4914     4925      +11
============================================
  Files           450      450
  Lines         19567    19621      +54
  Branches       2050     2055       +5
============================================
+ Hits          16814    16863      +49
- Misses         2068     2077       +9
+ Partials        685      681       -4

Impacted Files
Coverage Δ
Complexity Δ

...va/com/google/api/codegen/util/CommonAcronyms.java
90.9% <ø> (ø)
17 <0> (ø)
:arrow_down:

...i/codegen/transformer/SchemaTypeNameConverter.java
66.66% <0%> (ø)
5 <0> (ø)
:arrow_down:

...i/codegen/transformer/SchemaTypeFormatterImpl.java
36.84% <0%> (ø)
5 <0> (ø)
:arrow_down:

...er/java/JavaDiscoGapicSchemaToViewTransformer.java
95.91% <100%> (+0.04%)
16 <7> (-3)
:arrow_down:

...oogle/api/codegen/config/DiscoveryMethodModel.java
82.1% <100%> (-0.37%)
40 <0> (ø)

...a/JavaDiscoGapicResourceNameToViewTransformer.java
100% <100%> (ø)
15 <0> (ø)
:arrow_down:

...degen/discogapic/transformer/DiscoGapicParser.java
91.52% <100%> (+0.45%)
22 <5> (+1)
:arrow_up:

...r/java/JavaDiscoGapicRequestToViewTransformer.java
94.79% <100%> (+0.02%)
18 <0> (ø)
:arrow_down:

.../java/com/google/api/codegen/util/SymbolTable.java
100% <100%> (ø)
10 <2> (+1)
:arrow_up:

...oogle/api/codegen/transformer/SchemaTypeTable.java
70% <25%> (-0.5%)
26 <1> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b125b5...6d505d4. Read the comment docs.

Made adjustments. PTAL

@pongad in case I can't finish this review in a timely fashion - could you take a look too?

Made fixes. PTAL


[super-agent] chore: bump flux dep

Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [mychartname])

upgrade path is not required to work for this update


xml2js normalizeTags

There is an option in xml2js:
"normalizeTags (default: false): Normalize all tag names to lowercase."
Setting this to true would make life easier for us as we wouldn't have to normalize ourselves- we could always assume tags are lowercase. Since this is a breaking change, it should not be done until we are all aware of this issue and have agreed on when it will be fixed.

Not needed. musicxml tags seem to already be normalized, but the values can still be uppercase- xml2js doesn't provide anything for that. Perhaps a PR would be beneficial for them?


Different match depending of punctuation

Intent matching can be different with different punctation. It should be the same. Sometimes, STT adds comma to the sentences and it can lead to different intent matching.
Here's some examples in french using comma. I tested those sentences using Home Assistant.
Allume la lumière du salon
<allume> [<tous>] [<le>](<lumiere>|<lumieres>) [<dans>] [<le>]{area} ✅
Allume, la lumière du salon
<allume> [<le>]{name} ❌
,Allume, la lumière du salon
<allume> [<tous>] [<le>](<lumiere>|<lumieres>) [<dans>] [<le>]{area} ✅

We are very unlucky to get this one (IT also happens to me constantly... That coma in that particular place)
It happens with HA Cloud STT.
We're very unlucky because HASSIL seems to stripe almost everything down in any other cases...


set up subdomain for whw 2023 website

@scottyhq, @jomey can you add "water" as a hackweek.io subdomain so I can get an initial splash page up for WHW?

water.hackweek.io is not pointing to waterhackweek.github.io
Is there a need for an archival URL for the past event website?

Thanks @jomey! I looked and previous year's websites are not archived so I don't think there's a need for previous years.
So far I copied our website template over to this organization and called it website2023. Then I was able to give it the custom domain water.hackweek.io.
I'm not sure how that meshes with you pointing the subdomin to a specific url? Let me know if I'm following the workflow on this that we set up.

You did all the steps needed. I only added the checkmark to enforce HTTPS (a good practice).
The final link up is done by GitHub internally.
The new website shows up under water.hackweek.io


Fix two problems with the PDB parsing

This fixes two PDB processing bugs #1029 and #1340
The fixes are pretty straightforward:

manually assign a +1 charge to four-coordinate neutral N. This seems to appear in some PDB files. Thanks to Roger for explaining this.
don't form H-H bonds based on proximity

These two ended up coupled since one of the test files for #1029 revealed #1340

@lilleswing @rbharath this should fix our issues, can you give this a whirl and see?

Thanks greg!

The travis build failure was because I forgot to check in a couple of test files. That's now fixed.

Just to followup - this now works with sanitize=True and removeHs=False, however while setting them both to true does work, it is horrendously slow (~15 seconds) - is this expected?

The RDKit does more work than it should when sanitizing a protein. But the fact that (sanitize=True,removeHs=False) is dramatically faster than (sanitize=True,removeHs=True) is somewhat surprising at first glance.
I'll look into it.

I found the problem and ought to be able to fix it: #1359


Generate types for enums

Feature request
Currently, the typegen command inlines enum types for columns. It would be more helpful to generate "top-level" types for the enums. This would allow us to use the enum types elsewhere in our code. Additionally, the enum types could be used for the column definitions rather than repeating the same type multiple times (for Row, Insert, and Update on tables).
Is your feature request related to a problem? Please describe.
I have to manually create types for the enums which can get out of sync with the Postgres enums.
A clear and concise description of what you want and what your use case is.
The typegen command creates top level types for enums, uses the enums for the table column definitions, and exports the enum types.

Does this kind of format work for you? Each enum belongs to a schema so they need to be namespaced.
export type Json =
  | string
  | number
  | boolean
  | null
  | { [key: string]: Json }
  | Json[];

export interface Database {
  public: {
    Tables: {
      users: {
        Row: {
          id: number;
          name: string | null;
          status: Database["public"]["Enums"]["user_status"] | null;
        };
        ...
      };
    };
    Views: { ... };
    Functions: { ... };
    Enums: {
      user_status: "ACTIVE" | "INACTIVE";
    };
  };
}


Problems with auth server

I'm having some problems in getting tokens from auth server. I'll try to explain here:
Running Authorization Server - Resource Server demo flow:
Using the dummy account for test I'm getting this response after the performing the curl as suggested:
curl -v -H "Accept: application/json" -H "Content-type: application/x-www-form-urlencoded" -H \
  "Authorization: Basic aXQtdGVzdC1jbGllbnQtY3JlZGVudGlhbC1ncmFudDpzb21lLXNlY3JldC1jbGllbnQtY3JlZGVudGlhbC1ncmFudA==" \
  -X POST -d 'grant_type=client_credentials' http://localhost:8080/oauth2/token

I'm getting back this response:
 HTTP/1.1 400 Bad Request
< Content-Type: application/json
< Transfer-Encoding: chunked
* Server Jetty(8.1.4.v20120524) is not blacklisted
< Server: Jetty(8.1.4.v20120524)
<
{"error":"unsupported_grant_type","error_description":"The supported grant_type values are 'authorization_code' and 'refresh_token'"}* Connection #0 to host localhost left intact

I've tried even by building the http header using a browser-plugin and the result is slightly different:

First it ask me for a username/password (couldn't find a valid pair btw)
Then it returns a 401 unauthorized response.

Something similar happens when I'm trying to get a token by authorization code flow: I'm able to get a request_code but not able to exchange it for an authorization token. When I'm asking by building the http request header via browser plugin it asks me again for the username-login password for connecting to OAuthSecure2 server.
PS: The key that I'm using for generating the key use in Authorization header is obtained by openssl base64 command

I have the same problem =/

Use double quotes on the data portion of your request
instead of -d 'grant_type=client_credentials'
use
-d "grant_type=client_credentials"


Use custom dogpile cache key generator

Dogpile cache cache only accepts ascii strings as values for the default key generator. Passing non ascii characters results in UnicodeEncodeError.
By creating a custom key generator we ensure that the value is converted to a valid native string.
On Python 2: unicode strings are converted to byte strings with utf-8 encoding.
On Python 3: byte strings are decoded with utf-8 encoding.
Fixes https://github.com/Diaoul/subliminal/issues/887 and also other cache_on_arguments calls where strings are passed with non ascii characters.

@ratoaq2 any comment ?

@h3llrais3r is it possible to add any test ?

Will check if I can add one.

@fernandog Test added.
Test contains both original and custom version, so it's also clear what's the difference is between the versions.

Thanks


ARXML: load the choices dictionary of texttables correctly

For the message.decode() method to work properly, the key of the choices dictionary must be the raw signal's integer value mapped to the corresponding text, not vice-versa.
Andreas Lauser<EMAIL_ADDRESS>Mercedes-Benz AG on behalf of MBition GmbH.
Imprint

Coverage remained the same at 96.574% when pulling a131285656f517bad0793b255607b2d5217d41bf on Daimler:arxml_fix_signal_choices into 2f66e185eee915ddd2bf9ef1672515c712e9171b on eerimoq:master.


traefik generating incorrect certification

am trying to generate a certificate using reverse proxy template but it generate incorrect certification
steps as below :
1 - connect to local 0-robot and create a reverse proxy service
robot = j.clients.zrobot.robots.get('local')
In [24]: args = {
    ...:     'webGateway': 'wg',
    ...:     'domain': 'supportu.gird.tf',
    ...:     'servers': ['http://<IP_ADDRESS>:8085']
    ...: }
In [24]: service = robot.services.create('github.com/threefoldtech/0-templates/reverse_proxy/0.0.1', 'support_gird_tf', data=args)
In [24]: service.schedule_action('install').wait(die=True)

when check traefik container  , it has a record for support.grid.tf as below

when test website in browser , i got error due to unsecure certs and pointing to incorrect CN (common name)  as below

so it is creating certs with incorrect CN

when i checked etcds i found below errors

in node <IP_ADDRESS>

2019-08-22 11:56:27.476009 W | etcdserver: read-only range request "key:\"/hosts/dns/stub/\" range_end:\"/hosts/dns/stub0\" " took too long (206.783009ms) to execute
2019-08-22 11:57:27.688073 W | etcdserver: read-only range request "key:\"/hosts/dns/stub/\" range_end:\"/hosts/dns/stub0\" " took too long (165.952917ms) to execute
2019-08-22 11:58:27.971026 W | etcdserver: read-only range request "key:\"/hosts/dns/stub/\" range_end:\"/hosts/dns/stub0\" " took too long (252.162258ms) to execute
2019-08-22 11:59:28.259527 W | etcdserver: read-only range request "key:\"/hosts/dns/stub/\" range_end:\"/hosts/dns/stub0\" " took too long (255.426898ms) to execute
2019-08-22 12:00:20.378985 I | auth: deleting token eprplWkzpnXyTjUw.203211 for user root
2019-08-22 12:00:28.474875 W | etcdserver: read-only range request "key:\"/hosts/dns/stub/\" range_end:\"/hosts/dns/stub0\" " took too long (174.389808ms) to execute
2019-08-22 12:00:38.378989 I | auth: deleting token yAqOOLCvZLoIJlqn.203214 for user root
2019-08-22 12:00:38.379020 I | auth: deleting token nojvuFxibhiqaBAf.203220 for user root
2019-08-22 12:01:28.718201 W | etcdserver: read-only range request "key:\"/hosts/dns/stub/\" range_end:\"/hosts/dns/stub0\" " took too long (210.702752ms) to execute

in node <IP_ADDRESS>

In [32]:  f = ncl.containers.get('etcd_0a1a71c4-7262-479a-b501-d4659b94f250')
In [33]: job = f.client.subscribe('etcd.0a1a71c4-7262-479a-b501-d4659b94f250')

In [34]: job.stream()
2019-08-22 11:53:09.386064 I | rafthttp: established a TCP streaming connection with peer 9127694cad515a48 (stream MsgApp v2 writer)
2019-08-22 11:53:09.386268 I | rafthttp: established a TCP streaming connection with peer 9127694cad515a48 (stream MsgApp v2 reader)
2019-08-22 11:53:10.073412 W | rafthttp: health check for peer 9127694cad515a48 could not connect: dial tcp <IP_ADDRESS>:2380: getsockopt: connection refused
2019-08-22 11:55:27.138187 W | etcdserver: read-only range request "key:\"/traefik/frontends/3bot_org/redirect/entrypoint\" " took too long (613.644766ms) to execute
2019-08-22 11:55:40.953096 I | auth: deleting token ZGruEqrYhirbyNIL.203194 for user root
2019-08-22 11:56:00.953109 I | auth: deleting token iEHjiJVimrHuPHmB.203204 for user root
2019-08-22 11:56:00.953144 I | auth: deleting token MUSIUeUKBwLoZWyX.203198 for user root
2019-08-22 11:56:27.357958 W | etcdserver: read-only range request "key:\"/traefik/frontends/euroflow_io/headers/stsincludesubdomains\" " took too long (618.329414ms) to execute
2019-08-22 11:57:27.601244 W | etcdserver: read-only range request "key:\"/traefik/frontends/freeflowtokenS_com/redirect/regex\" " took too long (617.44949ms) to execute
2019-08-22 11:57:36.953109 I | auth: deleting token HugvGLYxcFsrPCeo.203209 for user root
2019-08-22 11:58:27.836626 W | etcdserver: read-only range request "key:\"/traefik/frontends/nbhdigitalcom/redirect/regex\" " took too long (612.281542ms) to execute

in node 3 <IP_ADDRESS>

In [36]: f = ncl.containers.get('etcd_463c3363-d9c8-407b-b456-80de34c9f5dd')
In [37]: job = f.client.subscribe('etcd.463c3363-d9c8-407b-b456-80de34c9f5dd')
In [38]: job.stream()
2019-08-22 11:53:09.386024 W | rafthttp: closed an existing TCP streaming connection with peer 9127694cad515a48 (stream MsgApp v2 writer)
2019-08-22 11:53:09.386052 I | rafthttp: established a TCP streaming connection with peer 9127694cad515a48 (stream MsgApp v2 writer)
2019-08-22 11:53:09.777258 W | rafthttp: health check for peer 9127694cad515a48 could not connect: dial tcp <IP_ADDRESS>:2380: getsockopt: connection refused
WARNING: 2019/08/22 11:53:35 grpc: Server.processUnaryRPC failed to write status connection error: desc = "transport is closing"
2019-08-22 11:55:40.766742 I | auth: deleting token ZGruEqrYhirbyNIL.203194 for user root
2019-08-22 11:56:00.766720 I | auth: deleting token MUSIUeUKBwLoZWyX.203198 for user root

after rebooting traefik , create certification for new websites works


Invalid HTTP method for PATCH _plugins/_security/api/rolesmapping

Describe the bug
When attempting to use the PATCH _plugins/_security/api/rolesmapping endpoint, it returns an error stating that the PATCH method used is invalid.
According to the documentation, I should be able to use PATCH
https://opensearch.org/docs/latest/security/access-control/api/#patch-role-mappings
To Reproduce

Go to 'Dev Tools'
Try to execute the following on an existing role (replace the name of the role for your test)

PATCH _plugins/_security/api/rolesmapping
[
  {
    "op": "add", "path": "/test-role", "value": { "users": ["testing"] }
  }
]

Expected behavior
The PATCH method should be accepted.
Plugins
N/A
Screenshots

Host/Environment (please complete the following information):

OS: AWS Opensearch Service
Version OpenSearch_2_3_R20221114-P4

Seems to be a duplicate of https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2343
@fdx0 Please follow the above issue for any updates or requests.


⚠ ClamAV has degraded performance

In 598137d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 198 ms

Resolved: ClamAV performance has improved in f4e9d18.


Request to improve error messaging

Is it possible to improve the error message when casting to Amount from SignedAmount?  It's currently annoyig to debug because the error doesn't supply the reason in some cases:
eff value Err(OutOfRangeError { is_signed: false, is_greater_than_max: false })

Here is the offending line of code the produces that prints the above error:
let signed_amount = SignedAmount(-1210838 SAT);
let amt = signed_amount.to_unsigned();
println!(amt);

Is it possible to show is_less_than_min: true here?  Obviously in this trivial example it's easy to see, however in more complex code where it's not so clear, some time would be saved with a more precise message.
Cheers

You've printed a debug message, print using Display to see a more readable one.

I really wish there was an option for the assert! macro to use display output rather than debug output, because I have this same issue with many errors in many libraries.

@Kixunil not that I doubt you, but I must be doing something wrong because I get an error when I try using Display.
Display uses the print marker {} and debug {:?}.  If I try with Display, here is what is "Displayed" on my screen:
^^^ `Result<Amount, bitcoin_units::amount::OutOfRangeError>` cannot be formatted with the default formatter `

Here's the exert that displays the above message
let signed_amount = SignedAmount::from_sat(-1210838);
let amount = signed_amount.to_unsigned();
println!("{}", amount);

@yancyribbens Result doesn't have Display but OutOfRangeError does. You need to match on it.
@apoelstra good point that some errors are annoying in debug representation, though I vaguely remember seeing a more informative debug impl.


Remove deprecated fields from Update Number snippet

Update number snippet should use app_id instead of deprecated messagesCallback* params.
See: https://nexmoinc.atlassian.net/browse/DEVX-3431

@marklewin I approved your changes but I have a quick question before merging....
The Jira ticket you linked to states "VOICE_CALLBACK_TYPE option should only be used for setting tel or sip config, we should discourage the use of the app value here."
Is that change covered in a separate PR?

@marklewin I approved your changes but I have a quick question before merging....
The Jira ticket you linked to states "VOICE_CALLBACK_TYPE option should only be used for setting tel or sip config, we should discourage the use of the app value here."
Is that change covered in a separate PR?

Hi @niati - Yes, I'll be changing the description of the fields concerned in the parent PR on NDP. Thanks :)


fix(elements): print at least one token on a page (#645).

Before:

After:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 3.577%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/pages/games/Tokens.jsx
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
514

Relevant Lines:
16224

💛  - Coveralls


Improve Auto Scroll feature

Currently the log is jumping multiple times per second to the bottom if Auto Scroll is activated.
Deactivating the ability to scroll if Auto Scroll is activated could solve this problem.

Published in Version 1.2.3

Published in Version 1.2.3


backend overview and plot_gate_map show matplotlib warning

Information

Qiskit Terra version: master
Python version: 3.5
Operating system: mac

Matplotlib version 3.0.3
What is the current behavior?

/Users/kevin.krsulichibm.com/q/qiskit-terra/lib/python3.5/site-packages/matplotlib/figure.py:2369: UserWarning: This figure includes Axes that are not compatible with tight_layout, so results might be incorrect.
warnings.warn("This figure includes Axes that are not compatible "

Only occurs on the first call, so recalling the function will clear the warning
Steps to reproduce the problem
%matplotlib inline
import matplotlib.pyplot as plt

import qiskit.tools.jupyter

qk.IBMQ.load_account()
ibmq_open_provider = qk.IBMQ.get_provider( hub = 'ibm-q', group = 'open', project = 'main' )

%qiskit_backend_overview

from qiskit.visualization import plot_gate_map
plot_gate_map(ibmq_open_provider.get_backend('ibmqx2'))

Hmm, I'm not able to reproduce this warning on linux in jupyter with either matplotlib 3.0.2 or matplotlib 3.1.1

It seems that might be a Mac thing. I also have one of the warnings.

This is not an issue for me as well.  I am using 3.1.1.


Intermittent Crash when node is syncing

This error occurs intermittently:
[ 2019-08-01 15:43:02 --    Debg ] new block coming: 6
[ 2019-08-01 15:43:02 --    Debg ] block index from peer: 6
[ 2019-08-01 15:43:02 --    Debg ] sending new block on to peer
[ 2019-08-01 15:43:02 --    Debg ] entering send_block
[ 2019-08-01 15:43:02 --    Debg ] before send_on_chord
[ 2019-08-01 15:43:02 --    Debg ] after send_on_chord.. exiting send_block
[ 2019-08-01 15:43:02 --    Debg ] finished sending new block on to peer
[ 2019-08-01 15:43:02 --    Debg ] in valid_as_latest?.. using difficulty: 15
[ 2019-08-01 15:43:02 --    Verb ] tx -- 6f1c24b6: validating common
[ 2019-08-01 15:43:02 --    Verb ] tx -- 6f1c24b6: validating coinbase transaction
[ 2019-08-01 15:43:02 --    Verb ] tx -- 1f4f30b7: validating embedded transactions
[ 2019-08-01 15:43:02 --    Erro ] invalid prev_hash: expected 39013a196bddbfa9a4643055f1ffb8373b0a791d00f0f6cba6ae906745d91799 but got 22666b5ebd6a6419e57a82a179f0ef1bc3d33d62ebfb6cc9d3b930acf4291ef3
[ 2019-08-01 15:43:02 --    Erro ] /usr/local/Cellar/crystal/0.29.0/src/gc/boehm.cr:76:5 in 'Sushi::Core::Transaction#valid_as_embedded?<Sushi::Core::Blockchain, Array(Sushi::Core::Transaction)>:Bool'
src/core/blockchain/block.cr:407:7 in 'valid_as_latest?'
src/core/blockchain/block.cr:94:14 in '->'
/usr/local/Cellar/crystal/0.29.0/src/http/web_socket.cr:255:3 in 'run'
/usr/local/Cellar/crystal/0.29.0/src/http/server/handlers/websocket_handler.cr:43:9 in 'call'
/usr/local/Cellar/crystal/0.29.0/src/http/server/request_processor.cr:39:11 in 'process'
/usr/local/Cellar/crystal/0.29.0/src/fiber.cr:255:3 in 'Fiber#run:(IO::FileDescriptor | Nil)'

Kingsley says:
Kingsley Hendrickse 12:40 PM
I asked about the error with sync on gitter and it was suggested it might be a memory leak
so I've been trying to investigate that - I've rewritten some classes as Structs in the utxo as that is more performant
looks like on Mac you can only use the instruments binary to profile
I think what happens is - that during the valid_as_embedded it is invalid - so raises an exception which is caught higher up and the transaction in question is removed from the list - however it seems that around this time some memory thing happens which causes the loop to crash - so we don't continue processing transactions - which means we don't get to syncing part
it's a hard crash so I don't think any kind of exception handling would catch it - I think it's some kind of memory leak or GC issue
John says
yeah.. we have a couple of threads of execution going on via the websocket onmessage invocations.. maybe some GC issue caused by 2 threads interacting

haven't seen this for ages - monitor for a bit longer

It's still there :(


Adding support for JWKS-based token validation and token attribute mapping (#151)

Adds support for JWKS-based token validation (#150) and also extracting token attributes as HTTP headers (besides the X-Userinfo header)

@cristichiru will you be accepting this pull request if I resolve the merge conflicts?

@cristichiru will you be accepting this pull request if I resolve the merge conflicts?

@jmdacruz I have proposed this change for the revomatico fork since that seams to be the one that is most maintained.

@jmdacruz I have proposed this change for the revomatico fork since that seams to be the one that is most maintained.

@Starefossen of course!

@Starefossen of course!

@Starefossen You could check https://github.com/revomatico/kong-oidc/pull/2 if it covers your JWT validation and header injection use case. Quite a timing coincidence!

@Starefossen You could check https://github.com/revomatico/kong-oidc/pull/2 if it covers your JWT validation and header injection use case. Quite a timing coincidence!

for me that did the trick. both JWKS based validation from discovery endpoint as well as header mapping works.
Using a config like this.
`_format_version: "1.1"
services:

name: mock-service
url: http://mockbin.org/request
path: /
tags:

example
routes:
name: mock-route
methods:

GET
paths: ["/mock"]
plugins:

name: oidc
config:
client_id: "dummy"
client_secret: "dummy"
discovery: "redacted"
unauth_action: deny
bearer_only: "yes"
bearer_jwt_auth_enable: "yes"
bearer_jwt_auth_allowed_auds: ["redacted"]
enabled: true
protocols:

grpc
grpcs
http
https
`

for me that did the trick. both JWKS based validation from discovery endpoint as well as header mapping works.
Using a config like this.
`_format_version: "1.1"
services:

name: mock-service
url: http://mockbin.org/request
path: /
tags:

example
routes:
name: mock-route
methods:

GET
paths: ["/mock"]
plugins:

name: oidc
config:
client_id: "dummy"
client_secret: "dummy"
discovery: "redacted"
unauth_action: deny
bearer_only: "yes"
bearer_jwt_auth_enable: "yes"
bearer_jwt_auth_allowed_auds: ["redacted"]
enabled: true
protocols:

grpc
grpcs
http
https
`

So, can we close this?

So, can we close this?


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit fa49557:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-10-08-07-21-43 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-10-08-07-21-43

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


OrganizationsService.ListFailedOrgInvitations

/orgs/{org}/failed_invitations has the same API as /orgs/{org}/invitations, although we should likely expand the Invitation model to include failure fields. My userland copypasta "implementation:"
// listFailedOrgInvitations returns a list of pending invitations.
// Copied and edited version of ListPendingOrgInvitations.
//
// GitHub API docs: https://docs.github.com/en/rest/reference/orgs#list-failed-organization-invitations
func listFailedOrgInvitations(ctx context.Context, client *Client, org string, opts *gh.ListOptions) ([]*gh.Invitation, *gh.Response, error) {
	u := fmt.Sprintf("orgs/%v/failed_invitations", org)
	u, err := addOptions(u, opts)
	if err != nil {
		return nil, nil, err
	}

	req, err := client.NewRequest("GET", u, nil)
	if err != nil {
		return nil, nil, err
	}

	var failedInvitations []*gh.Invitation
	resp, err := client.Do(ctx, req, &failedInvitations)
	if err != nil {
		return nil, resp, err
	}
	return failedInvitations, resp, nil
}

Thank you, @micimize !  (There is a bit more involved, so I'll open this up to volunteers for a complete implementation.)
This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!
Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.
Please check out our CONTRIBUTING.md guide to get started.
Thank you!

@gmlewis I can probably PR this, but why do you say it's more involved? The API is identical (the failure fields are in both responses).

Thanks, @micimize - it's yours.
What I meant by "a bit more involved" is that you also need to write one or more tests for the new endpoint and need to run go generate ./... as described in our CONTRIBUTING.md guide... but yes, you are definitely on the right track for success.

@micimize Are you still working on it ?
I am also interested in contributing

@IamMaheshDere I'm planning on it but probably won't get to it for a while – if you want to take it go ahead


A theoretical problem about protein structure DDPM and SE(3) invariant model

Hi ! Dear authors, your derivation in this paper is very rigorous and amazing! Including RFdiffusion, there are two SE(3) equivariant models for protein structure generation based on diffusion model. My question is: is it possible for an SE(3) invariant model to do protein structure generation with diffusion model?
To my way of thinking, an SE(3) invariant model plus an alignment algorithm (e.g. Kabsch algorithm) is equal to an SE(3) equivariant model. Looking forward to your answer!

Hi! If I understand your question, you're asking if a SE(3) invariant score model can be used to perform SE(3) equivariant diffusion? Of course you can use any model to do diffusion but achieving equivariance is important. We utilize IPA which (by its name) is a SE(3) invariant model but with a change of frame it becomes equivariant (see the AF2 supp for more details). IPA is somewhat unique in this sense though by keeping track of these "local frames" at each residue. I'm not sure how you'd use an alignment algorithm to achieve equivariance with a invariant model. You could look into works like frame averaging which AIUI is a framework for converting neural networks to be equivariant/invariant.

Thanks for your patient answer!
In my opinion:

When sampling, DDPM needs a network to predict x_pred (to approximate x_0) in order to calculate p( x_(t-1) | x_t, x_pred) .
In SE(3) equivariant diffusion, we have to ensure that x_pred, x_0 and x_t are In the same coordinate system. Only that we can calculate p( x_(t-1) | x_t, x_pred) directly and calculate the loss || x_pred - x_0 ||^2_2.
In your FrameDiff, you use an IPA module (SE3 invariant) to update invariant node features h_l and update your frame T_(l+1) = T_l * T_update. Because T_update derives from invariant node features h_l, T_(l+1) is equivariant as T_l.

I'm not sure whether my above comprehensions are right. And my questions are as following:

I want to use an SE(3) invariant model to perform SE(3) equivariant diffusion, which means that x_pred may not in the same coordinate system as x_t (or x_0). So before calculating p( x_(t-1) | x_t, x_pred), I have to align x_pred to x_t, i.e. p( x_(t-1) | x_t, Align(x_pred)).
When calculating loss, I want to replace || x_pred - x_0 ||^2_2 by || Align(x_pred) - x_0 ||^2_2 or FAPE(x_pred, x_0).

I hope I can express my questions clearly and look forward to your answer! orz

Through computing FAPE-style loss, you gets an SE(3) invariant loss, instead of SE(3) equivariant prediction. They are not equivalant, and what we expect is "the score rotates with the input".

Yes dugu's answer is correct. I think the equivariant loss fits the theory more closely but I have heard of many works where invariant losses lik FAPE also work. Hope you were able to solve your problem and sorry I dropped the ball on responding. I'm closing the issue for now.


Add documentation for Security rule CA5372 (UseXmlReaderForXPathDocument) in FxCopAnalyzers

Rule implementation: https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.NetCore.Analyzers/Core/Security/UseXmlReaderForXPathDocument.cs#L11

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1295961-36c4-75a0-f50a-c5d86159746c
Version Independent ID: 3d4bba1e-0d05-f577-3b78-65dd6ab10635
Content: Security Warnings - Visual Studio
Content Source: docs/code-quality/security-warnings.md
Product: visual-studio-windows
Technology: vs-ide-code-analysis
GitHub Login: @gewarren
Microsoft Alias: gewarren

Bootsrapped: https://github.com/paulomorgado/MicrosoftDocs-visualstudio-docs/tree/paulomorgado/ca5372


fix: deoptimize slots when a directive is used

🤔 What is the nature of this change?

[ ] New feature
[x] Fix bug
[ ] Style optimization
[ ] Code style optimization
[ ] Performance optimization
[ ] Build optimization
[ ] Refactor code or style
[ ] Test related
[ ] Other

🔗 Related Issue
fixes #541
💡 Background or solution
resolveDirective in an optimized slot uses the child component's scope, so directives registered locally in the parent fail to resolve. To fix this we either need to hoist resolveDirective to setup like vue/compiler-sfc does (not really possible in JSX), or disable slot optimization for all parents.
This should be merged after #637 as that added another instance of optimize that needs updating.
📝 Changelog

Language
Changelog

🇺🇸 English

🇨🇳 Chinese

☑ Self Check before Merge
⚠ Please check all items below before review. ⚠

[ ] Doc is updated/provided or not needed
[ ] Demo is updated/provided or not needed
[ ] TypeScript definition is updated/provided or not needed
[ ] Changelog is provided or not needed

Don't merge yet, I need to make some more changes after #637


🐛 BUG:

Which Cloudflare product(s) does this pertain to?
Queues
What version(s) of the tool(s) are you using?
3.75.0
What version of Node are you using?
v20.10.0
What operating system and version are you using?
MacOS Sonoma
Describe the Bug
Observed behavior
Queue can not be deleted since its attached to worker; worker is non-existent or was deleted before.
Expected behavior
Should delete the queue successfully.
Steps to reproduce
Please provide the following:

A minimal working subset of your worker code
A minimal working subset of your wrangler.toml
Commands used to start your local dev server, including custom env and cli args
Steps to be performed in the browser, curl commands, or a test we can run that reliably fails (at least a percent of the time)

A git repo we can clone and run a test suite on, or which has a README with step-by-step instructions, is even better. In this case, please use the field below to provide a link to the minimal repro.
Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
No response

hi @9M6  :) we haven't heard from you in a while, so we’re going to close this issue for now. if this is still a problem, please feel free to open a new issue referencing this one. please be sure to include a repro and we will revisit and investigate further. thanks!


if it's there, use luggage.local for local overrides

We'd like to keep our upstream copy of luggage.make as pristine as possible. With this method, we add all local mods (a tweaked STAMP with HHMM, REVERSE_DOMAIN, and a slew of custom rules) to luggage.local and keep luggage.make untouched.
Also use $(shell ...) instead of ... and Make proto.plist's full path a variable that can be overridden in luggage.local

Definitely awesome.  Thanks for contributing features that (I assume) you guys are developing/using in-house!

The allow spaces in filenames bit we'd had internally for a while, but only noticed it was missing from luggage because we just recently switched from Joe's original packagemaker.make :)

Yeah I'm just going to pile on here...

Clay,
I've added you as a collaborator on the project.


Using JWM with lxpanel

I was having an issue with JWM not allowing lxpanel to iconify any windows when the window list button is toggled with a left mouse click. Instead, it would just focus/raise the window. So for comparision, I reset Openbox as the window manager, and besides allowing lxpanel to work correcly, I noticed that when I click on a lxpanel window list button, it would not take focus, but yet under JWM, the lxpanel winodw list button would take focus during mouse1 button press.
So, after unsuccessfully trying to modify lxpanel to not take focus on mouse clicks, I added a group option to JWM called "neverfocus". This is enabled on lxpanel by adding the group section to my .jwmrc :
   <Group>
      <Name>lxpanel</Name>
      <Option>neverfocus</Option>
   </Group>

And now lxpanel works as designed.
For those who may be interested, see the attached patch.
neverfocus.patch.zip
Update: It appears the group config is being ignored, as lxpanel works without the .jwmrc group section. So my modification needs some more work.

Hmm, not sure what lxpanel provides that isn't already built into jwm... so I'm probably not the only one who hasn't tested this.
It seems like the nofocus group setting would do the same thing.

The lxpanel just has tighter integration with the LXDE desktop environment. The JWM taskbar is in fact quite functional but I have a preference towards lxpanel. I choose to use JWM over the default OpenBox WM for the framed window drag/resize, which make for a snappier desktop experience over RDP.
Unfortunately, the nofocus group only takes effect on initial window mapping, not for subsequent mouse events sent to lxpanel after mapping.
When I get free time I need to dig further into the logic of JWM so that I can create a functional neverfocus group handler. As I mentioned in my update, I inadvertently included a few changes that caused my handler to activate on lxpanel without regard to having a group section in .jwmrc. In the mean time, I'm just happy that JWM is working fine with my patch.


Update templates to use React 18 createRoot

Fixes #12219
Since CRA installs React 18 by default now, we should update the template to use the new createRoot

Hey just checking in, what's blocking this?

Friendly ping @iansu and @mrmckeb.  This PR is ready to merge.

Now that the TypeScript types for React 18 are out nothing is blocking this. Does this need to be merged along with https://github.com/facebook/create-react-app/pull/12223?

Now that the TypeScript types for React 18 are out nothing is blocking this. Does this need to be merged along with #12223?

Yes, the RTL update should also be merged for react 18 compatibility.
Thanks!

@kyletsang I merged the RTL PR. Do you mind updating this branch from main so we can re-run the tests?

@iansu done!

Thanks!

At which version, is this going to fix?
As far today(April 10th, 2022), the npx create-react-app doesn't pickup this change.


test_make_text fails after SPDX changes

Test failure:
________________________________________ test_make_text _________________________________________

    def test_make_text():
        license = licenses.get_by_id('MIT')

        assert 'Copyright (c) <year> <copyright holders>' in license.make_text()
        assert 'beginOptional' not in license.make_text()
        assert license.make_text().strip().startswith('MIT License')

>       assert 'Copyright (c) 2018 Gram' in license.make_text(copyright='2018 Gram')
E       AssertionError: assert 'Copyright (c) 2018 Gram' in 'MIT License 2018 Gram\n\nPermission is hereby granted ...

It seems to be caused by newer SPDX data files having moved the Copyright (c) part inside the variable (at least for the MIT license):
spdx v3.5: Copyright (c) <<var;name="copyright";original="<year> <copyright holders>";match=".+">>
spdx v3.7: <<var;name="copyright";original="Copyright (c) <year> <copyright holders>";match=".{0,1000}">>

Thanks. Fixed in #3


Referencing types from hyphenated modules

I have this module definition in a [libs] directory:
declare module "data-canvas" {
  declare class DataCanvasRenderingContext2D extends CanvasRenderingContext2D {
    pushObject(o: any): void;
    popObject(): void;
    reset(): void;
  }
}

This provides types for node_modules/data-canvas. This works fine, until I need to reference one of those types from code in another module. They hyphen is a problem:
function getRenderer(ctx: data-canvas.DataCanvasRenderingContext2D, scale: (num: number) => number) {
src/main/PileupTrack.js|43 col 31 error|  Unexpected token -

I tried quoting it:
function getRenderer(ctx: "data-canvas".DataCanvasRenderingContext2D, scale: (num: number) => number) {
src/main/PileupTrack.js|43 col 40 error|  Unexpected token .

I eventually discovered that import type works:
import type {DataCanvasRenderingContext2D} from 'data-canvas';
function getRenderer(ctx: DataCanvasRenderingContext2D, scale: (num: number) => number) {

This isn't really an issue with Flow, I just wanted to file an issue with the solution in case anyone else runs into this in the future!

I'm confused. If you rename your declared module to nospace, you can access the types using a qualified syntax like nospace.DataCanvasRenderingContext2D? If you can, that feels like a bug. I think the hyphen is unrelated.

If I change the declaration to
declare module "datacanvas" { ... }

Then I can refer to datacanvas. DataCanvasRenderingContext2D. But that's not the name of the NPM package, which is already published with a hyphen. So I'd rather not rename the NPM package.

@jeffmo This behavior is really surprising. IMO, we should require the type to be imported through the import type syntax. Jeff, is this a bug or intended behavior?

Oh, and thanks for confirming @danvk. :)

Lemme double check what I said about referring to datacanvas.DataCanvasRenderingContext2D, I may have misinterpreted the errors.

If I put this in a [libs] file:
declare module "mymodule" {
  declare class Foo {
    x: number;
  }
}

and then do this:
function foo(x: mymodule.Foo) {
}

Then I get the error you might expect: type-annotation 'mymodule' Could not resolve name. The import type statement still works.
So... forget I said anything :)


does LayoutLM require bboxes & text for token classification?

Can LayoutLM function as an object detection model for documents?
I need to find & label portions of a document into 'question' and 'answer' regions, and fine-tuning on detectron2 had very poor results. I tried looking for a model pretrained with documents images & doing 'dense' object detection, and the only model I could find was LayoutLM.
However, I see in documentation that LayoutLM will use the bouding boxes of text & the OCR'ed text as input, which sort of defeats the purpose of 'object detection' here since my purpose for the model is to output the bounding boxes & labels.
Is my understanding of LayoutLM correct, and do you have any advice on dense object detection models for documents?

@parulsingh23 Yes, LayoutLM needs OCR'ed text as input, because natural language provides more hints for detecting "question" and "answer" pairs. For bbox output, you may need to use any off-the-shelf OCR tools or train your own models with our pre-trained DiT (https://github.com/microsoft/unilm/tree/master/dit).


SAK-28957 add config service

This service allows lookups and sets of the config values in sakai, as well as runtime adjustment of the log configuration which is handy for debugging in dev and in production. The config stuff is useful for scripts that might want to check config, or external tools that help manage config, or adjust things at runtime.
Some examples:
Set logging to DEBUG
http://localhost:8080/sakai-ws/rest/configuration/adjustLogLevel?sessionid=3141ae2f-3065-4782-b614-13627f2b92d6&packageName=org.sakaiproject&level=DEBUG
Get a property
http://localhost:8080/sakai-ws/rest/configuration/getProperty?sessionid=3141ae2f-3065-4782-b614-13627f2b92d6&propName=auto.ddl
You can even get the @ style properties:
<EMAIL_ADDRESS>

Are you ok to rebase and squash this down to one commit? It's just that having a simple commit makes it easier for people to cherry-pick features out, and to browse the history?
Nice feature BTW.

was having trouble with rebase, made a new PR, https://github.com/sakaiproject/sakai/pull/14


vite3 output bundle much bigger than vite2

Describe the bug
Please see here https://github.com/pwang2/test-bundle

With a single icon,  vite3 generates a bundle almost 6 times larger than vite2
Reproduction
https://github.com/pwang2/test-bundle
System Info
System:
    OS: macOS 13.0.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 9.14 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 19.0.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.19.2 - /usr/local/bin/npm
  Browsers:
    Chrome: 107.0.5304.121
    Safari: 16.1

But basicall, all OS.

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

see explanation here: https://github.com/vitejs/vite/discussions/11162
Closing


Right Alt + Left Arrow doesn't work

VSCode Version: 1.3.1
OS Version: Windows 7 64bit

Steps to Reproduce:

Right Alt + Left Arrow doesn't work. Expect it works as Left Alt + Left Arrow

Similar in Mac OSX - have lost this as well using Alt + cmd + right arrow to open a new split pane?

@NalinNexus you can rebind keybindings to get the old behaviour back for splitting editor (look for workbench.action.focusNextGroup).
As for Alt+Gr (right Alt), I am not sure we can support this key easily. On my Windows machine it turns my display around so it seems like a very native build in OS key.
Moving to @alexandrudima if he has an idea.

@trucbinh Try defining your keybinding in the "Define Keybinding" widget, it's there to help out :)
Does it correctly identify your keypresses?

Closing after a number of days without a reply.


NS-9862: Generating type definition file

The nosto-react library export doesn't work when used in a typescript environment because only the definitions in types.ts is considered as the exported types and components. This PR will create d.ts file with all the type definitions for property types and components. Also updates the package.json to use the newly generated type definitions
https://nostosolutions.atlassian.net/browse/NS-9862

There is an ugly type name clash in the d.ts file:
export declare function NostoSession(props: {
    cart: Cart;
    customer: Customer;
}): JSX_2.Element;

/**
 * @group Types
 */
declare interface NostoSession_2 {

There is an ugly type name clash in the d.ts file:
export declare function NostoSession(props: {
    cart: Cart;
    customer: Customer;
}): JSX_2.Element;

/**
 * @group Types
 */
declare interface NostoSession_2 {

Fixed. Thanks!


improvements to IAM dataset code

incorporates #31 and #30 and #21 and adds in some reorganization code
making a PR to trigger the CI testing via GitHub Actions, which starts from a clean slate

FYI, this is still a dont-merge draft until i get a chance to kick the tires on overfitting and on the IAMLines dataset

a sniff test on a few hours of single GPU training look okay -- W&B Report

the first four commits are a nuisance -- trying out and then reverting a cacheing change, with some bonus docs commits
the last three are more interesting -- i rationalized the scaling of images by making it primarily the responsibility of IAMLines and connecting it with IAMParagraphs

@srbhchandra merge party 🦀 🦀 🦀


Update range size plots to reflect changes in workflow

Given changes in map and overlap creation, which led to changes in calculating range areas, the scripts for comparing current and forecast ranges (statistically and graphically) needs updating.

Addressed by a7c8377


endpoint/id: use strings.IndexByte

Use strings.IndexByte instead of strings.Index to look for a single byte. This improves BenchmarkSplitID as follows:
name       old time/op    new time/op    delta
SplitID-8    62.5ns ±61%    41.1ns ± 5%  -34.14%  (p=0.000 n=10+9)

/test

@tommyp1ckles gentle ping for review

Looks good


type definition sets to any (from DaisyThemes) on build

since in the first build, it can't import the availableThemes array. type of, for example, set becomes
set (theme: DaisyThemes) : void.    to.  set (theme:any) : void

version 0.0.28 fixes


unable to decompile .so files

Error: File is not supported archive or is not readable.
getting this error when trying to decompile .so file

Please attach the .so file you're trying to decompile, if you can, and post the command-line you're calling retdec with and the exact version of retdec.

This is the file that i was using
libBlinkID.zip

Hi. Shared objects (.so) files have to be decompiled via retdec-decompiler.py. I think the reason why the decompilation does not work for you is that you are using retdec-archive-decompiler.py instead of retdec-decompiler.py. Is that correct? If so, you have to use retdec-decompiler.py because retdec-archive-decompiler.py is only for archives (.a or .lib files).

Yes, it work thanks.


⚠ Bofrost.at has degraded performance

In 0ad61ee, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1643 ms

Resolved: Bofrost.at performance has improved in e41ca7a after 6 minutes.


Does this support OpenBalena v4.1.x?

I just tried setting up open-balena-admin to test this nice looking, and helpful software.
When accessing :8080 after all containers started, connected to PostgreSQL DB, i'am returned with: Not Found
Blank page with Not Found.
Using latest OpenBalena. Any suggestions on where to start debugging?

I am hoping the dev replies, but I have found that the issue with the NotFound has to do with the REACT_APP_BANNER_IMAGE env variable.  I added an image but I believe the resolution is wrong as I just get a blank screen.  I think, the banner image that is in the container was some how corrupted or missing for a default.

Actually after digging into the UI docker image I believe it is looking for the API version tag but it does not exist for API v30. I'm looking into the coding for the versions to see if any changes need to be made or if we can just you the last listed version.

@giuseppe443 @alekbless apologies for the delay in jumping in here - there have been a lot of updates to the open-balena-admin app since those docker scripts were built. The primary method of deploying it is in kubernetes via helm, and I've been keeping those up to date. If you look at the commit logs of the various open-balena-admin components (ui, postgres, remote) you should see the environment variables / other configuration items that have been added, and I would welcome any PR's to keep those docker scripts updated. Otherwise I'm sure I'll get around to this at some point, it's just not a focus at the moment.


Configurable retry codes

Internally, we have some clients that currently rely on some bespoke, legacy
retry behavior, whereby an HTTP/1.1 request can be retried on a 429 response
code. Ideally, we'd like to be able to move this retry logic out of the clients
and into the proxy-layer (i.e. Envoy) and still preserve the same behavior in
the event the server returns a 429.
Below are some options we'd like to pitch.
The first would involve adding a new field to the RouteAction.RetryPolicy
proto, retryable_codes, that would contain one or more HTTP response codes
(as integers) that are deemed retryable for the request.
In addition to this, we could create a new policy, say "retryable-codes",
which expects either an accompanying request header (e.g.
X-envoy-retryable-codes: 429,503), or entry in the route configuration with
the retryable codes (as per above).
Another option, which is probably a non-starter, would be to add the specific
retry policy we need, "retriable-429", but this feels a little too specific
and brittle.
Open to thoughts on how we might go about this. Thanks!
cc: @mpuncel @snowp

I'm a fan of the new header, it seems very flexible. Maybe also make the retry codes configurable in RetryPolicy so it can be configured through RDS without injecting headers?

I love the idea of being able to specify response codes for retry behaviour:
retry_policy:
  retry_on: connect-failure
  retryable_codes: 503,418
  num_retries: 3

Or even just:
retry_policy:
  retry_on: connect-failure,503,418
  num_retries: 3

I don't fully understand the idea behind x-envoy-retryable-codes though. This was mentioned as being a request header, but it seems like the place the knowledge about wether something should be retryable or not should be the proxy or the upstream service.
As an aside, I also think getting rid of the gateway-error policy would be a good idea. IMO it's presence suggests that retrying non-503 errors is a safe thing to do.

I'll just chime in to mentioned we're still playing around with some ideas on this proposal and will hopefully offer up a patch soon. Feel free to assign this me for now.

This was mentioned as being a request header, but it seems like the place the knowledge about wether something should be retryable or not should be the proxy or the upstream service.

@wjessop - totally agree with you in principle here in that ideally retry configuration should live in the proxy layer. The reason we're proposing this is to attempt to provide feature parity between Envoy and our existing polyglot HTTP client libraries that all make extensive use of HTTP response codes to determine when to retry.

Thanks for the reply @nicktrav. In this situation being able to have both methods of configuration would be great, though the ability to ignore re-try headers set from downstream of Envoy would be essential for us as I could see that having them enabled for public facing infra could be a DoS risk.

I like this proposal. In our legacy systems, a custom proxy component replies http 570 indicating clients to retry another instance, when such components going into graceful upgrade process. 502 and 503 codes aren't used in this scenario because that would cause ambiguity.

Did this get fixed? If not then it's still a valid issue and I don't think should be closed.


Unable to start VM through docker-machine in KVM in CentOS 7

Hi,
I am getting some error while creating VM through docker-machine in KVM in CentOS 7.
[budhram@localhost ~]$ docker-machine -D create -d kvm default
Docker Machine Version:  0.8.2, build e18a919
Found binary path at /usr/local/bin/docker-machine-driver-kvm
Launching plugin server for driver kvm
Error attempting to get plugin server address for RPC: Failed to dial the plugin server in 10s

Other details
[budhram@localhost ~]$ uname -a
Linux localhost.localdomain 3.10.0-327.28.3.el7.x86_64 #1 SMP Thu Aug 18 19:05:49 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

[budhram@localhost ~]$ sudo systemctl status libvirtd
● libvirtd.service - Virtualization daemon
   Loaded: loaded (/usr/lib/systemd/system/libvirtd.service; enabled; vendor preset: enabled)
   Active: active (running) since Tue 2016-12-13 20:49:06 IST; 56min ago
     Docs: man:libvirtd(8)
           http://libvirt.org
 Main PID: 9495 (libvirtd)
   Memory: 0B
   CGroup: /system.slice/libvirtd.service
           ├─2286 /sbin/dnsmasq --conf-file=/var/lib/libvirt/dnsmasq/default.conf --leasefile-ro --dhcp-script=/usr/libexec/libvirt_leaseshelper
           ├─2287 /sbin/dnsmasq --conf-file=/var/lib/libvirt/dnsmasq/default.conf --leasefile-ro --dhcp-script=/usr/libexec/libvirt_leaseshelper
           └─9495 /usr/sbin/libvirtd

Dec 13 20:49:06 localhost.localdomain systemd[1]: Starting Virtualization daemon...
Dec 13 20:49:06 localhost.localdomain systemd[1]: Started Virtualization daemon.
Dec 13 20:49:06 localhost.localdomain dnsmasq[2286]: read /etc/hosts - 2 addresses
Dec 13 20:49:06 localhost.localdomain dnsmasq[2286]: read /var/lib/libvirt/dnsmasq/default.addnhosts - 0 addresses
Dec 13 20:49:06 localhost.localdomain dnsmasq-dhcp[2286]: read /var/lib/libvirt/dnsmasq/default.hostsfile
Dec 13 20:57:47 localhost.localdomain systemd[1]: Started Virtualization daemon.
Dec 13 20:58:21 localhost.localdomain libvirtd[9495]: libvirt version: 2.0.0, package: 10.el7_3.2 (CentOS BuildSystem <http://bugs.centos.or...os.org)
Dec 13 20:58:21 localhost.localdomain libvirtd[9495]: hostname: localhost.localdomain
Dec 13 20:58:21 localhost.localdomain libvirtd[9495]: End of file while reading data: Input/output error
Hint: Some lines were ellipsized, use -l to show in full.

Tested it and looks like libvirt service had some issue. @budhrg can you please close it?

I really don't know what happened but it start working today like charm.
Yesterday, it was not working. It was my new setup and followed this link to setup KVM hypervisor.
Its working fine now.


bug: Requirement tests do not distinguish events if raw events differ by some additional words

Raw events like:

The user 'someone' has FAILED authentication.  Failure count equals 1
The user 'someone' has FAILED authentication
CIM field equal to the whole raw event, for a  sake of simplicity.

The bug in https://github.com/splunk/pytest-splunk-addon/blob/e947cb24f76b7986f7f4f17d1915ea7a6ac96cb3/pytest_splunk_addon/standard_lib/requirement_tests/test_templates.py#L174 causes that condition build for 2nd event takes CIM fields for the1st event. As value is ofc different than expected, test fails.
Proposed solution - instead of just {escaped_event} use _raw="{escaped_event}"

Adding event sample here -
<event code="" name="AuthenticationFailed" format="">
    <transport type="modinput" sourcetype="jira:datacenter:security:log" source="/var/atlassian/application-data/jira/log/atlassian-jira-security.log" host="so1" />
    <source>
      <jira id="" />
      <comment>lab</comment>
    </source>
    <raw><![CDATA[2021-12-31 15:21:30,538+0000 http-nio-8080-exec-24 anonymous 921x1127x1 vrocv0 <IP_ADDRESS> /login.jsp The user 'someone' has FAILED authentication.]]></raw>
    <cim>
      <models>
        <model>Authentication</model>
      </models>
      <cim_fields>
        <field name="action" value="failure" />
        <field name="app" value="jira" />
        <field name="reason" value="The user 'someone' has FAILED authentication." />
        <field name="src" value="<IP_ADDRESS>" />
        <field name="src_user" value="anonymous" />
        <field name="user" value="someone" />
      </cim_fields>
      <missing_recommended_fields>
        <field>dest</field>
      </missing_recommended_fields>
    </cim>
  </event>
  <event code="" name="AuthenticationFailed" format="">
    <transport type="modinput" sourcetype="jira:datacenter:security:log" source="/var/atlassian/application-data/jira/log/atlassian-jira-security.log" host="so1" />
    <source>
      <jira id="" />
      <comment>lab</comment>
    </source>
    <raw><![CDATA[2021-12-31 15:21:30,538+0000 http-nio-8080-exec-24 anonymous 921x1127x1 vrocv0 <IP_ADDRESS> /login.jsp The user 'someone' has FAILED authentication.  Failure count equals 1]]></raw>
    <cim>
      <models>
        <model>Authentication</model>
      </models>
      <cim_fields>
        <field name="action" value="failure" />
        <field name="app" value="jira" />
        <field name="reason" value="The user 'someone' has FAILED authentication.  Failure count equals 1" />
        <field name="src" value="<IP_ADDRESS>" />
        <field name="src_user" value="anonymous" />
        <field name="user" value="someone" />
      </cim_fields>
      <missing_recommended_fields>
        <field>dest</field>
      </missing_recommended_fields>
    </cim>
  </event>

a quick workaround for the above -  change "username" or any user-defined key in the event
 The user 'someone2' has FAILED authentication.


region misc bugfix:

这个 PR 实现什么功能/修复什么问题:

fix get details hosts
save image enable generate_name
network auto set a DNS
fix servers filter by disk

是否需要 backport 到之前的 release 分支:
release/3.2
/area region
/cc @swordqiu @zexi @yousong @ioito

Codecov Report

Merging #6038 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #6038   +/-   ##
=======================================
  Coverage    7.02%    7.02%
=======================================
  Files         644      644
  Lines      110405   110419   +14
=======================================
+ Hits         7754     7756    +2
- Misses     102051   102064   +13
+ Partials      600      599    -1

Flag
Coverage Δ

#aFlag
7.02% <0.00%> (+<0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/cloudcommon/db/caller.go
25.43% <0.00%> (ø)

pkg/compute/models/disks.go
0.54% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/guest_actions.go
0.00% <0.00%> (ø)

pkg/compute/models/guests.go
0.56% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/hosts.go
0.31% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/networks.go
0.55% <0.00%> (-0.01%)
:arrow_down:

pkg/appsrv/response.go
70.58% <0.00%> (+2.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1db63d...9a7c762. Read the comment docs.

/lgtm

/lgtm


Fix mutable tensor related bugs and some enhancement

What do these changes do?
Fix the mutable tensor bugs and some enhancements:

Fix bug about worker selection for chunks
Support write mutable tensors using raw payload (for example, arrow tensors and arrow record batches), for better support for other languages.
Add an enhanced test for mutable tensor.

Related issue number
N/A

Could you please open an issue to describe the bug fixed in this PR ?


Officer jato this means war

Officer jato this means war  <!--
Thank you for contributing to this project! You must fill out the information below before we can review this pull request. By explaining why you're making a change (or linking to a pull request) and what changes you've made, we can triage your pull request to the best possible team for review.
See our CONTRIBUTING.md for information how to contribute.
For changes to content in site policy, see the CONTRIBUTING guide in the site-policy repo.
We cannot accept changes to our translated content right now. See the contributing.md for more information.
Thanks again!
-->
Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@m-star5
Help

What
On Fri, Jun 25, 2021, 8:32 PM Arman7717 @.***> wrote:

@Arman7717 approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/7686#pullrequestreview-693259187,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT5TPGQTPSDSY7KQJVJB43LTUUNZ7ANCNFSM47JI6D2A
.


TAD mapping

In the update-ui branch (not current master branch or website) the TAD locations are getting all messed up which are messing up everything downstream.
original version:

branch version:

Okay, so to confirm, the SNP rs12 should be in a TAD with range 8353475 to 11393475, but in the as of 8f7d3421e7f6 the range is incorrectly displayed as 112132764 to 113372764?

Correct but not just for that snp, it is happening multiple times including in some of the examples

Okay, I fixed the error. Here's a minimal reprex in case this comes up again.
library(haploR)
library(data.table)

packageVersion("haploR")

tad <- fread("data/IMR90_domains_hg19.bed")
colnames(tad) <- c("chr", "start_position", "end_position")
tad$chr <- gsub("chr", "", tad$chr)
tad$chr <- as.numeric(tad$chr)
tad <- tad[!is.na(tad$chr), ]

snps <- c("rs12")
dat <- queryHaploreg(snps, ldThresh = 0.8, ldPop = "EUR")
dat$chr <- as.numeric(as.character(dat$chr))
dat$pos_hg38 <- as.numeric(as.character(dat$pos_hg38))
dat<-dat[dat$rsID %in% snps,]
snp_pos<-dat$pos_hg38

tad<-tad[tad$chr==max(dat$chr,na.rm=TRUE),]
in_tad <- tad[tad$start_position<= snp_pos & tad$end_position>=snp_pos,]

in_tad
in_tad$start_position
in_tad$end_position
paste0("In a TAD! The TAD ranges from ",in_tad$start_position," to ",in_tad$end_position)

Expected results
> library(haploR)
> library(data.table)
data.table 1.11.6  Latest news: r-datatable.com
>
> packageVersion("haploR")
[1] ‘2.0.6’
>
> tad <- fread("data/IMR90_domains_hg19.bed")
> colnames(tad) <- c("chr", "start_position", "end_position")
> tad$chr <- gsub("chr", "", tad$chr)
> tad$chr <- as.numeric(tad$chr)
Warning message:
NAs introduced by coercion
> tad <- tad[!is.na(tad$chr), ]
>
> snps <- c("rs12")
> dat <- queryHaploreg(snps, ldThresh = 0.8, ldPop = "EUR")
> dat$chr <- as.numeric(as.character(dat$chr))
> dat$pos_hg38 <- as.numeric(as.character(dat$pos_hg38))
> dat<-dat[dat$rsID %in% snps,]
> snp_pos<-dat$pos_hg38
>
> tad<-tad[tad$chr==max(dat$chr,na.rm=TRUE),]
> in_tad <- tad[tad$start_position<= snp_pos & tad$end_position>=snp_pos,]
>
> in_tad
   chr start_position end_position
1:   7        8353475     11393475
> in_tad$start_position
[1] 8353475
> in_tad$end_position
[1] 11393475
d_position)n a TAD! The TAD ranges from ",in_tad$start_position," to ",in_tad$end
[1] "In a TAD! The TAD ranges from 8353475 to 11393475"

Just so I know for my own reference, what was the issue? the code above exactly matches the original but not the dev version (because of all the extra code). Was it needing to add the  x <- x$result bit?

Yeah, safe_queryHaploreg() returns a list with result and error, where error is NULL when the function works and otherwise returns the error message without breaking the app.
So I had missed pulling out x$result before trying to modify the columns in x$result. Plus I refactored a little bit so that that code chunk only does the processing after verifying that the query worked.


upgrade statichcheck-action to v1.3.0 across all repos

<EMAIL_ADDRESS>should be upgraded across all repos wherever it's used to v1.3.0 with these configurations:
      - uses<EMAIL_ADDRESS>        with:
          version: "latest"
          install-go: false

which is part of the static check workflow:
  static_check:
    name: Static check
    runs-on: ubuntu-latest
    steps:
      - name: Check out code
        uses: actions/checkout@master
        with:
          fetch-depth: 1
      - name: Setup Go
        uses: actions/setup-go@v5
        with:
          go-version: 1.23
      - uses<EMAIL_ADDRESS>        with:
          version: "latest"
          install-go: false

i wanted to work on this can you assign me this?

I am not able to find the static check workflow can we get an example?

@doppedheart @pratikgitss I recently fixed it here in [meshery-cilium](https://github.com/meshery/meshery-cilium) in this pr https://github.com/meshery/meshery-cilium/pull/173/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f

Yes @devhindo . Thanks for sharing it, I believe this repo doesn't use staticcheck-action but there are other adaptor repos which do use it and need the update in their workflows. Let me raise a PR on whichever adaptor repository the updated is needed.
Thanks

yeah you're right, wherever this is used in any of the other adapters this should be updated @Deeptanshu-sankhwar

Hello @devhindo , I believe I have made the upgrade to all the possible go repositories across meshery which were using staticcheck-action in their workflows, as can also be seen at https://github.com/orgs/meshery/repositories?q=lang%3Ago&type=all.
Please review the changes made to those above 4 repositories.
Thanks!


cad computer comes out as???????????????

So i'm running a document script and a polic mdt scrtipt an the problem is that when someone types something in bulgarian/cirillyc the db saves it as ????????? instead for example: нещо си там. can yuou tell me how am i supposed to change the charset of the scriptl, or the whole sql thing

Use the string, change the charset to something that is not UTF8_GENERAL_CI


[Backport release 24.05] soundsource: 5.6.3 -> 5.7.1

Backports:
#344186
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 349276

x86_64-darwin

:white_check_mark: 1 package built:

soundsource

aarch64-darwin

:white_check_mark: 1 package built:

soundsource

What's with the failing Check cherry-picks? Are we missing a commit in the middle.

#325738 Didn't get backported