Release Google.Cloud.Channel.V1 version 2.4.0

Changes in this release:
New features

Enable REST transport in C# (commit 496c8ab)

Created release for Google.Cloud.Channel.V1-2.4.0


Web App compatibility

Will your project be implemented on web app's, like in any exam portal??

I don't plan to do that myself. If you want to build that you can and start a pull request.

yeah i've been working on my college project so for that, i'm encountering some problem while doing face detection.

actually do you have any idea about how we can implement face detection , so that any user who open the portal the camera will also get accessed and face detection will also done

No, sorry.


sticky_header [nfc]: Use new SlottedMultiChildRenderObjectWidget base class

This was introduced recently upstream, deprecating the old mixin SlottedMultiChildRenderObjectWidgetMixin.
This change follows up on 2f0f4692f (from #103), which handled the mandatory part of the same upstream API change.

Thanks, LGTM! Merged.


BatchNorm can not converge with scale=False

Description
BatchNorm operator with scale=False can not converge.
Error Message
No error message, but loss value and training accuracy is abnormal comparing with scale=True BatchNorm.
To Reproduce
We can try https://github.com/nttstar/arcface.np to train arcface. Add one BatchNorm op with scale=False after final embedding layer
What have you tried to solve it?

Set Scale=True, it can work but with slightly worse test accuracy.

Environment
----------Python Info----------
Version      : 3.6.9
Compiler     : GCC 7.3.0
Build        : ('default', 'Jul 30 2019 19:07:31')
Arch         : ('64bit', '')
------------Pip Info-----------
Version      : 19.3.1
Directory    : /root/anaconda2/envs/py36/lib/python3.6/site-packages/pip
----------MXNet Info-----------
Version      : 2.0.0
Directory    : /root/anaconda2/envs/py36/lib/python3.6/site-packages/mxnet
Num GPUs     : 8
Hashtag not found. Not installed from pre-built package.
----------System Info----------
Platform     : Linux-3.10.0-327.el7.x86_64-x86_64-with-centos-7.5.1804-Core
system       : Linux
node         : gpu06
release      : 3.10.0-327.el7.x86_64
version      : #1 SMP Thu Nov 19 22:10:57 UTC 2015

Hi @nttstar , there was a bug in BatchNorm in the previous version of MXNet. The bug was reported in #18373 , and it was fixed in PR #18377 . Could you please try the latest version of MXNet?

@wkcn I communicated with @nttstar offline and https://github.com/apache/incubator-mxnet/issues/18373 should not be the casue. Would you help try with scale=False and see if there is anything wrong?

@sxjscience I'm sorry that I don't have any machine with GPU to check it recently.
I read the code of batch norm and its unittest.
There is a gradient check when fix_gamma=True:
https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_operator.py#L1777,
but no output check when fix_gamma=True:
https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_operator.py#L1882

I try to test the batch norm with fix_gamma=True on GPU, the test fails on assert_almost_equal(bn_beta.grad.asnumpy(), db.asnumpy(), atol=atol, rtol=rtol) in test_operator.py#L1950.
(<function BatchNorm at 0x7f54854753b0>, (24, 2), 0, False)
(<function BatchNorm at 0x7f54854753b0>, (24, 2), 0, False)
(<function BatchNorm at 0x7f54854753b0>, (24, 2), 0, True)
(<function BatchNorm at 0x7f54854753b0>, (24, 2), 0, True)
(<function BatchNorm at 0x7f54854753b0>, (24, 2), 1, False)

*** Maximum errors for vector of size 2:  rtol=0.01, atol=0.01

  1: Error 90.669586  Location of error: (0,), a=28.82106400, b=14.64017868
  2: Error 64.738541  Location of error: (1,), a=22.83149147, b=13.46625137

The result on CPU is correct.

I'm fixing the bug and I will submit a PR later.

Hi @nttstar , the bug of BatchNorm has been solved in #18492 .

@wkcn Thanks! I will check it in the next pip package release.


Document how to add a custom resolve path

In https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/config/webpack.config.js#L269 it would be interesting to know how to add a path in the webpack resolve field
for example, I tried to create a jsconfig.json file
{
  "compilerOptions": {
    "baseUrl": "src"
  }
}

and then use imports like this:
import foo from 'src/utils/foo';

but it didn't work
NODE_PATH is deprecated, so how should it be done now?
related to https://github.com/facebook/create-react-app/issues/2188

import foo from 'utils/foo';
```js
works, if ultils/ folder is in the src/ folder


Document ModRule specification

Closes #5

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   77.93%   77.93%
=======================================
  Files           4        4
  Lines         213      213
=======================================
  Hits          166      166
  Misses         31       31
  Partials       16       16

Impacted Files
Coverage Δ

core/modrulestoreitem.go
78.33% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067d7cd...1e352f7. Read the comment docs.


Update the “Writing a plugin” docs for the new plugin API

Update the docs to use the new Tapable API
Add the “Under the hood” section
Remove the “Hook types” section and link to the Tapable docs instead (depends on https://github.com/webpack/tapable/pull/63)
Put sections talking about compiler and compilation next to each other
Do some minor tuning

Depends on https://github.com/webpack/tapable/pull/63.

Related to #2200.


test: add iletisim initial test

Codecov Report

Merging #161 (0043fbd) into main (6d82e99) will increase coverage by 0.11%.
The diff coverage is 58.40%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   50.66%   50.77%   +0.11%
==========================================
  Files          16       17       +1
  Lines        1275     1349      +74
  Branches       29       38       +9
==========================================
+ Hits          646      685      +39
- Misses        629      662      +33
- Partials        0        2       +2

Impacted Files
Coverage Δ

cacheDecorator.js
33.33% <0.00%> (-19.05%)
:arrow_down:

routes/controllers/yardimEt.js
27.81% <0.00%> (-0.38%)
:arrow_down:

lib/Check.js
31.11% <50.00%> (-0.71%)
:arrow_down:

server/buildCache.js
73.01% <73.01%> (ø)

server/build.js
96.00% <88.88%> (-1.54%)
:arrow_down:

config.js
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Custom titlebar appears late compared to native titlebar

On Windows:
When launching VS Code with a native titlebar the titlebar (and menubar) are shown immediately when the window is created while the rest of the workbench appears later.
This is not the case when using the custom titlebar. The window initially is one empty flat rectangle and the titlebar appears at the same time as the rest of the workbench.
The time it takes to render the workbench varies on Windows more than on other platforms. During slow startups, the empty rectangle is the only thing the user sees.

since @joaomoreno added the "splash screen" behavior, we discussed this issue may now be moot. Is this still the opinion?

I think you mean @jrieken

sorry @jrieken

I don't see us doing anything major on this any time soon. the splash screen helps and this has sat for some time.


HBASE-27101 support commons-crypto version 1.1.0

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 32s
the patch passed

+1 :green_heart:
compile
6m  0s
the patch passed

+1 :green_heart:
javac
6m  0s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
13m 59s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

39m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4506

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 8a63168316fa 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
AdoptOpenJDK-1.8.0_282-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt

Max. process+thread count
140 (vs. ulimit of 30000)

modules
C: . U: .

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 50s
the patch passed

+1 :green_heart:
compile
1m 41s
the patch passed

+1 :green_heart:
javac
1m 41s
the patch passed

+1 :green_heart:
shadedjars
4m 14s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
1m 44s
root generated 165 new + 18 unchanged - 0 fixed = 183 total (was 18)

_ Other Tests _

+1 :green_heart:
unit
231m 56s
root in the patch passed.

256m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4506

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ed95ea92eb83 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
AdoptOpenJDK-11.0.10+9

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/1/testReport/

Max. process+thread count
4192 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 55s
master passed

+1 :green_heart:
compile
5m 56s
master passed

+1 :green_heart:
spotless
0m 48s
branch has no errors when running spotless:check.

-0 :warning:
patch
0m 54s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  8s
the patch passed

+1 :green_heart:
compile
5m 54s
the patch passed

+1 :green_heart:
javac
5m 54s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
12m 11s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

38m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4506

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 8aaa4bd18d19 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f526609331

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
138 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 14s
master passed

+1 :green_heart:
compile
7m 38s
master passed

+1 :green_heart:
spotless
0m 54s
branch has no errors when running spotless:check.

-0 :warning:
patch
1m  1s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 41s
the patch passed

+1 :green_heart:
compile
8m 14s
the patch passed

+1 :green_heart:
javac
8m 14s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
14m 15s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 50s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

44m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4506

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 88f22788ef16 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c0e7e98ec7

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
140 (vs. ulimit of 30000)

modules
C: . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 22s
the patch passed

+1 :green_heart:
compile
1m 39s
the patch passed

+1 :green_heart:
javac
1m 39s
the patch passed

+1 :green_heart:
shadedjars
3m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
236m 31s
root in the patch passed.

260m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4506

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 503a08b6177e 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c0e7e98ec7

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/3/testReport/

Max. process+thread count
4283 (vs. ulimit of 30000)

modules
C: . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 16s
the patch passed

+1 :green_heart:
compile
1m 39s
the patch passed

+1 :green_heart:
javac
1m 39s
the patch passed

+1 :green_heart:
shadedjars
3m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
347m 49s
root in the patch passed.

370m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4506

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c3a6b437f2f2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c0e7e98ec7

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/3/testReport/

Max. process+thread count
3863 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4506/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Borrow field identifiers from deserializer, instead of input

Fixes #167.
Bitvec's handwritten Deserialize impls tried to borrow a bunch of strings directly from the deserializer's input, including the field names "order", "head", "bits", "data", "width", "index" and the value of the "order" field for comparing against type_name::<O>().
This sometimes works, for example when deserializing from a JSON &str. However, this is not how derived Deserialize impls work and a lot of formats won't be able to hand out borrowed data from the input like that. For example, when deserializing any data format from a R: std::io::Read. (You can tell because https://doc.rust-lang.org/std/io/trait.Read.html literally has no methods for borrowing data. Everything that this trait does is defined in terms of copying data into a caller-provided buffer, not borrowing it from the underlying i/o object.)
This PR changes the Deserialize impls to borrow from the Deserializer instead, as opposed to the input data. This works efficiently in all formats. Deserializers that operate on i/o resources will let you borrow from the same buffer that they use for obtaining data from the underlying Read object. Deserializers that wrap an in-memory data structure like serde_json::Value will borrow from there without copying or allocation.

This is wonderful, thank you!!


Build.rs for crt-sys crate fails on windows with conflicting math.inl implementations and other errors

Mountpoint for Amazon S3 version
main branch
AWS Region
us-east-1
Describe the running environment
Windows 11
Mountpoint options
None

What happened?
Trying to leverage crt-sys crate on windows, potentially as a future PR for windows support
Relevant log output
No response

Things I've tried
When building on windows as is, the aws-c-common runtime provides multiple definitions for math.h (inside of math.inl). Clang will get multiple definitions of aws_ctz_* and aws_clz_* types from both the math.gcc_builtin.inl and math.msvc.inl and cause a redefinition failure. I'm not sure how math.msvc.inl is being included as I'm building as is on windows without any additional clang arguements/macro definitions. Trying both blocklist_file and blocklist_item did not work for me (I believe Clang MUST go through all header definitions). Manually modifying the math.inl file to include math.msvc.inl only by force fixes the redefinition conflict but causes Bindgen to panic (unsure why). Manually modifying math.inl to force the pure C implementation aws/common/math.fallback.inl will pass by clang and build.rs finishes. However, for some unknown reason, logging_shim.rs and lib.rs will fail to compile as it's not picking up the generated types.

Hey @NukaCody, we don't support Windows at the moment. We may accept small PRs to fix Windows build as long as they don't break anything on Linux, but we can't guarantee anything. Your particular issue seems related to CRT, I'd suggest reaching out to them for any queries.


Scrollbar background not transparent

I'm using this in a popover and the scrollbar is not transparent for some reason, any pointers would be most appreciated.

I've just encountered this issue but with a regular NSScrollView. It happens because the NSPopover tries to apply a custom styling to elements in Yosemite (i.e. the NSAppearanceNameVibrantLight appearance).
To avoid the bug you can set the appearance of the content view of the popover to NSAppearanceNameAqua:
[view setAppearance:[NSAppearance appearanceNamed:NSAppearanceNameAqua]];

I'm not sure if this is a bug or if some designer at Apple thought it would be a good idea to have backgrounds for scrollers that are in popovers.

@Kapeli Thanks, that fixes it. Sorry for the late response!


Ignore server certificate error

Hi,
i have this error:
Net::LDAP::Error (hostname "x.x.x.x" does not match the server certificate):
So I need to ignore certificate error.
How I can do it?
Thanks

I had the same error and found these settings to ignore the certificate error in a development environment:
encryption:
  method: simple_tls
  tls_options:
    verify_mode: OpenSSL::SSL::VERIFY_NONE

(see also this stackoverflow question)
However I had to change the gem a little bit so the config would be read as symbols in order to work with (the newest version) of ruby-net-ldap. I created PR #264 with my alterations. It's still more of a workaround but might already be helpful.

This doesn't seem to be a Net::LDAP bug as such, but certainly will prevent you from reading your LDAP settings from a YAML file as in the above example.  You can't set verify_mode using an ldap.yaml config file, because the verify_mode settings hash needs to have Symbol keys for Net::LDAP to recognize them, but the top level parameters need to have String keys for devise_ldap_authenticatable.  But for other users of devise_ldap_authenticatable: you can actually set this without any monkey patching or PR merges by settting devise.ldap_config to a Proc rather than a String. i.e.:
  config.ldap_config = proc do
    {
      "host" => "my.ldap.server",
      "port" => 636,
      ...
      "encryption" => {
        method: :simple_tls,
        tls_options: {
          verify_mode: OpenSSL::SSL::VERIFY_NONE
        }
      }
    }
  end

This way you can also evaluate OpenSSL::SSL::VERIFY_NONE (which just returns 0).

Worked for me using ldap.yml in this way:

development:
  host: XXXXX
  port: 636
  attribute: sAMAccountName
  ....
  ....
  ssl: true
  encryption:
    :method: :simple_tls
    :tls_options:
      :verify_mode: 0


blackboard.png image is not being applied to all slides

Hi, the blackboard.png is only being applied to the title slide for me. Any suggestions for modifications to the scss or _extensions.yml to apply to all slides?

Ok, perhaps an ad-hoc fix, but was able to add directly to each slide:
## Slide Title {background-image="_extensions/blackboard/blackboard.png"}

`

hmm turns out it still works for me. Can you provide a reproducible example, or talk through what you did that caused the problem?

It is entirely possible that it is because of my green-ness and naïveté on how to implement the quarto templates. I was having bad luck with the installation via quarto use template xxxx. Instead my approach was to clone the repo and change the template.qmd to my working document.

So the quarto use template does work for me. cloning does not work, because there is still some hardcoded copy paste in the template that i cannot resolve, which only work with quarto use template. Can you tell me what your issue with that is?

My ignorance - I've been using Quarto through Rstudio and didn't realize I needed to also install Quarto as stand alone software. You can chalk this one up to the learning curve - will close this issue. Thanks!


Add 'http://' to the url output, then is possible to click and open the default browser

details:
2017-10-13T16:06:02.880Z INFO route host mapping mean-booster-mb.<IP_ADDRESS>.nip.io

http:// added
2017-10-13T16:06:02.880Z INFO route host mapping http://mean-booster-mb.<IP_ADDRESS>.nip.io

it is also possible that it could be https
https://github.com/bucharest-gold/nodeshift/blob/master/lib/routes.js#L45 that is where it is happening.   i wonder if there is more info from that route object that is returned?

Agree.
@lholmquist on this step, nodeshift returns this:
2018-02-19T13:30:01.721Z INFO using namespace myproject at https://<IP_ADDRESS>:8443

https
I really don't know if the same can be done with the route.

we now return a whole object of stuff when nodeshift finishes,  and rhoaster does something to figure out the url of the route.  so we might already have something for this

@helio-frota can i close?

yes


Create User Details Page: Displaying Login Details, Contact Information, and Permissions

What is the motivation for adding/enhancing this feature?
Currently, our system lacks a centralized user details page, making it challenging for administrators to access essential user information in one place. To address this issue, we need to create a user details page that displays login details, contact information, and permissions for each user, facilitating efficient user management and access control.
What are the acceptance criteria?
The user details page should provide comprehensive information about each user, including login credentials, contact details, and permissions
Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Additional information

Closing as done through - #5 #13 #16 #17


Unable to open shell after upgrading to 4.2.0

Describe the bug
After I upgraded LENS 4.2.0, I am unable to open any shell using LENS IDE for my GKE or Baremetal Clusters.
I downgraded to 4.1.5 and it works again.
Getting the below error when trying to open a node shell from the menu:

To Reproduce
Steps to reproduce the behavior:

Go to 'Nodes'
Click on a particular node
Try to open the 'Node shell'
See error as in screenshot above.
The same problem is noticed for both GKE and Baremetal Clusters. with 4.1.5 it works fine.

Expected behavior
Should open the shell for the corresponding node.
Screenshots

Environment (please complete the following information):

Lens Version: 4.2.0 (works fine with 4.1.5)
OS: MacOS Catalina 10.15.7
Installation method (e.g. snap or AppImage in Linux):

duplicate https://github.com/lensapp/lens/issues/2433

Closing in favour of #2433


Fix for issue #13

Attached is the fix for the memory leak reported in issue #13.
Thanks for your help @w1nk!

Aw man, I tried to beat you to it, now I've hosed up the auto merge :)

Ok, I think I got it merged, yours was way prettier thank mine :P.

Haha. Awesome. Should we bump the version?

Yeah probably should, that leak sounds like it could be a little nasty under the right circumstances.  I've not even considered versioning, I suppose it's probably time to do that :).


feat: Entity extraction

Is your feature request related to a problem? Please describe:

The ML Kit Entity Extraction API is not yet supported.
Describe the solution you'd like:

Add a Entity Extraction plugin.
Describe alternatives you've considered:

Additional context:

This issue can be sponsored if interested. Please contact us in advance by email and mention the issue. PRs are also welcome.


Module Does Not Support Tensor<B, D, Int>

Describe the bug
For some reason Module structs do not allow having a Tensor of Kind = Int.
Screenshots

This should be fixed now.

Can confirmed as fixed!


Plain Text format dump support

I need to parse plain text dump files and would like to use pgdumplib as a more generic solution compared to my parser.

Those are just raw SQL statements. There are a few libraries for that:

https://pypi.org/project/pgparse/
https://pypi.org/project/pglast/

(And a few more)

thanks for pointing out the libraries. Somehow obvious that there are raw SQL parsers. didn't cross my mind though. thanks!


chore: fix koordinator typo

Ⅰ. Describe what this PR does
fix typo koordiantor to koordinator
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/lgtm

/lgtm


A fishing command that can give you fish that you can sell for random monies

ok so heres the fish list:
Common Fish: 1-5
Uncommon Fish: 5-10
Rare Fish: 10-20
Unrare Fish: 20-40
Legendary Fish: 40-100
Unlegendary Fish: 100-150
Legend's Fish: 500-1000
Happyheart's Fish: -1
Fishing Cost: 10
Bait Cost/List (Can buy from the shop; Also can catch while fishing):
Bad Bait: 5
Good Bait: 50
Rare Bait: 100
Legendary Bait: 500

Awesome Idea! Will add.

Instead of fish and bait you could make it something league or happyheart related.

also the prices aren't balanced since a common fish has a large chance of giving you a loss, you would need to compensate for that.

there should be a cooldown like 20-30 seconds

yeah probably, it could be random ranging from 10 seconds to 10 minutes with messages like "random hurricane" to "I needed to put the fish in a bucket"

Also maybe a 50/50 Fail messages?..
example: "My bait fell into the water, FRICK." or, "A tree fell on you, But you manage to survive the incident."

greater chance to get the fish than 50/50 but yeah.

Too lazy to add this

@bumbleblake may want this

Closing (In-Active)


Archiving an archive?

I realize this isn't a common use case but I tried using scoop to archive a page in the Internet Archive Wayback Machine:
$ scoop https://web.archive.org/web/20051221165217if_/https://ldodds.com/writing/

You can find the WACZ here:
https://edsu-webarchives.s3.amazonaws.com/tmp/ldodds.wacz
I noticed that the screenshot looks fine:

But replay gets confused by some kind of recursive loop!

Is there any way around this?

Hi @edsu 👋 ! I think this is known a playback issue with replayweb.page? Probably worth checking with folks at Webrecorder. Cheers!

@ikreymer just let me know that using the id_ instead of if_ view works ok!
https://replayweb.page/?source=https%3A%2F%2Fedsu-webarchives.s3.amazonaws.com%2Ftmp%2Fldodds.wacz#view=pages&url=https%3A%2F%2Fweb.archive.org%2Fweb%2F20051221165217id_%2Fhttps%3A%2F%2Fldodds.com%2Fwriting%2F&ts=20241018194358

@ikreymer just let me know that using the id_ instead of if_ view works ok!
https://replayweb.page/?source=https%3A%2F%2Fedsu-webarchives.s3.amazonaws.com%2Ftmp%2Fldodds.wacz#view=pages&url=https%3A%2F%2Fweb.archive.org%2Fweb%2F20051221165217id_%2Fhttps%3A%2F%2Fldodds.com%2Fwriting%2F&ts=20241018194358

@edsu For what it's worth, I get "Archived Page Not Found" when following that link.

Weird, I don't see that ...


Change Android versionName replacement regex to prevent changes to versionNameSuffix

I am using Android product flavors in my gradle build scripts. Product flavor builds can optionally append a suffix to a global versionName string when configured with versionNameSuffix property.
capacitor-set-version plugin correctly updates the global versionName property but unfortunately replaces all versionNameSuffix properties with versionName: VERSION due to broad regex for replacement.
This pull request prevents capacitor-set-version from replacing versionNameSuffix properties in product flavors by narrowing down the replacement regex. A mandatory empty space ([ \t]+) is added to the versionName capture group.

Hello @akomelj
Thank you for you contribution.


Back scroll bar to start when changing folder

Now when changing directory, scroll bar back to start.
Fix #26041

Thanks!


The withStreamUsage() of the OpenAiChatOptions is not supported in AzureOpenAiChatOptions.

When using Azure OpenAI, the 'usage' metadata is always returned as empty in the stream().
I understand that 'usage' is supported in the latest OpenAIServiceVersion, V2024_08_01_PREVIEW. Therefore, the AzureOpenAiChatOptions should also support the withStreamUsage() method to align with this.

Related Issue: https://github.com/Azure/azure-sdk-for-java/issues/40998


[RFC]: Alert | Banner  |  Message component

[RFC]: Alert | Banner  |  Message component
Problem description
We need a component that can offer users a visual representation similar to an alert regarding different states of the application for specific scenarios:

there's a connectivity issue in the app
some users are not available to chat
an item needs extra visual attention because it might be urgent, etc

Proposed solutions
Other libraries tackle this problem by introducing a dedicated component. You can see some examples in the next section (Other Libraries Screenshots, after Proposed solutions)
Name:

Alert (used by most librariies) - front runner
Message (used by SUIR)
Banner (used by Attlassian)

API:
v1:
export interface IBannerProps {
  /** Content for childrenApi. */
  children?: TChildren

  /** Shorthand for primary content. */
  content /* or message */ ?: TContent

  /** Describes the emphasis and style of the Alert. */
  type /* or color or intent */ ?: 'info'
    | 'warning'
    | 'danger'
    | 'success' /* or 'positive' */
    | 'error' /* or 'negative' */

  // or we can have each type value as boolean prop:
  success?: boolean
  danger?: boolean
  warning?: boolean
  info?: boolean
  error?: boolean

  /** The callback used when the user chooses to hide the Alert */
  onDismiss?: () => void // or onClose

  /** Controls Alert's relation to neighboring items. */
  attached?: boolean | 'top' | 'bottom'

  /** Generic animation property for applying different theme animations. */
  animation?: AnimationProp
}

v2:
interface IBannerPropsV2 extends IBannerProps {
  /** Additional content of Alert. */
  description?: ShorthandValue

  /** Defines whether Alert is displayed. */
  open?: boolean

  /** Event for request to change 'open' value. */
  onOpenChange?: ComponentEventHandler<PopupProps>

  /** EXPERIMENTAL - some Alerts might need different style for all types/intents */
  appearance?: 'basic' | 'card'
}

Other Libraries APIs:
Bootstrap - Alert:

class names for describing the emphasis:primary, secondary, success, danger, warning, info, light, dark preceded by alert- suffix
can have header and content (similar to Stardust's Header with description)
close button

Reactstrap - Alert:

color:primary, secondary, success, danger, warning, info, light, dark
can have header and content (similar to Stardust's Header with description)
isOpen: boolean prop for visibility state
toggle: handler for controlling visibility
fade: boolean prop for fade animation
close button
visually the same as Bootstrap

Ant Design - Alert:

Property
Description
Type
Default

afterClose
Called when close animation is finished
() => void
-

banner
Whether to show as banner
boolean
false

closable
Whether Alert can be closed
boolean
-

closeText
Close text to show
string|ReactNode
-

description
Additional content of Alert
string|ReactNode
-

icon
Custom icon, effective when showIcon is true
ReactNode
-

message
Content of Alert
string|ReactNode
-

showIcon
Whether to show icon
boolean
false, in bannermode default is true

type
Type of Alert styles, options: success, info, warning, error
string
info, in bannermode default is warning

onClose
Callback when Alert is closed
(e: MouseEvent) => void
-

Evergreen - Alert:

Property
Type
Descriptio

child
renunion
The content of the alert. When a string is passed it is wrapped in a <Text size={400} /> component.

intent
enum = 'none', 'success', 'warning', 'danger'
The intent of the alert.

title
node
The title of the alert.

hasTrim
bool = true
When true, show a border on the left matching the type.

hasIcon
bool = true
When true, show a icon on the left matching the type,

isRemoveable
bool = false
When true, show a remove icon button.

onRemove
func
Function called when the remove button is clicked.

appearance
enum = 'default', 'card'
The appearance of the alert.

VuetifyJs - Alert:

Semantic-UI React - Message:

Name
Type
Description

as
{custom}
An element type to render as (string or function).

attached
{bool, enum}
A message can be formatted to attach itself to other content, Enums: 'bottom', 'top'

children
{node}
Primary content.

className
{string}
Additional classes.

color
{enum}
A message can be formatted to be different colors. Enums: 'red', 'orange', 'yellow', 'olive', 'green', 'teal', 'blue', 'violet', 'purple', 'pink', 'brown', 'grey', 'black'

compact
{bool}
A message can only take up the width of its content.

content
{custom}
Shorthand for primary content.

error
{bool}
A message may be formatted to display a negative message. Same as negative.

floating
{bool}
A message can float above content that it is related to.

header
{custom}
Shorthand for MessageHeader.

hidden
{bool}
A message can be hidden.

icon
{custom, bool}
A message can contain an icon.

info
{bool}
A message may be formatted to display information.

list
{custom}
Array shorthand items for the MessageList. Mutually exclusive with children.

negative
{bool}
A message may be formatted to display a negative message. Same as error.

onDismiss
{func}
A message that the user can choose to hide. Called when the user clicks the "x" icon. This also adds the "x" icon.

positive
{bool}
A message may be formatted to display a positive message. Same as success.

size
{enum}
A message can have different sizes

success
{bool}
A message may be formatted to display a positive message. Same as positive.

visible
{bool}
A message can be set to visible to force itself to be shown.

warning
{bool}
A message may be formatted to display warning messages.

Fabric - MessageBar:

Material UI - Snackbar:

Name
Value
Description

action
node
The action to display.

anchorOrigin
enum
The anchor of the Snackbar: { horizontal: enum: 'left' | 'center' | 'right', vertical: enum: 'top' | 'bottom'}

autoHideDuration
number
The number of milliseconds to wait before automatically calling the onClose function. onClose should then set the state of the open prop to hide the Snackbar. This behavior is disabled by default with the null value.

ClickAwayListenerProps
object

ContentProps
object

message
node

onClose
func
Callback fired when the component requests to be closed. Typically onClose is used to set state in the parent component, which is used to control the Snackbar open prop.

open
bool

Other Libraries Screenshots:
Bootstrap and Reactstrap - Alert:

Ant Design - Alert:

Evergreen - Alert:

VuetifyJs - Alert:

Semantic-UI React - Message:

Fabric - MessageBar:

Material UI - Snackbar:

Naming
I propose to go with Alert, it has the similar name in ARIA patterns: https://www.w3.org/TR/wai-aria-practices/examples/alert/alert.html
type vs separate props
We can use type, it's an HTML attribute. So, let's go with separate props. We had a long discussion before about the color palette, so I propose to simply use its defintions: danger, info, success, warning.
Slots
Actually, I see that we have everywhere description/content, header, statusIcon/stateIcon and closeIcon.

Conclusions
I vote for the minimal implementation:

danger, info, success, warning to customize, defaults to info. SUI has basic, but I propose to omit it
content. Prefer instead of description, it doesn't make any sense to call it description in the case below:

closeIcon and onClose: we will have the similar thing in Dialog component, so let's align
skip header and statusIcon/icon for initial implementation

great feedback, thanks @layershifter 👍
I'd also add attached since it's highly needed by clients

still not sure what makes more sense.. danger vs error vs both (since we already have success and the natural opposite is failure or error rather than danger)
but we will start with success, danger, info, warning and iterate from there. 1st PR soon 😃


feat(besu): private transaction support

This is a first cut of implementing private transaction support into Cactus for besu.
This main issue with this was trying to figure out a meaningful way of testing this functionality, the initial attempt was to use the Besu private network example in a docker container as part of our CI pipeline, as this is how I tested this in development. However this fires up quite a lot of nodes and uses a silly amount of computing resources. Mocking the responses of these transactions would also equate to meaningless tests and we're then not testing the "private" part of the private transactions, and we already have tests that check regular transactions.
A potential solution to this could be to fire up multiple of our "besu-all-in-one" containers in and perhaps try to get them to talk to each other, or even fire up multiple nodes within that container itself. Either way, this ends up making our CI suite quite the choke point.
Any further ideas from @kikoncuo @petermetz would be welcome.

@travis-payne I don't have any better ideas apart from the ones already outlined by you above so the best thing I can do is to offer to help out with the investigation.
What we can do to move things along is this:

You confirm that manual tests were executed and that the code works (and document the test script in a bullet pointed fashion in the git commit message)
You document in the package README that the tx privacy feature is developer preview for now due to lack of test coverage
Maintainers review the code with the assumption that it works (e.g. if there were tests they would actually pass)
This PR gets merged, fingers crossed
In parallel: You open a follow-up issue to write the test and the necessary components it would use (a test ledger class that supports tx privacy for the purpose of tests)
Then at some point we figure all that out and add the tests in another PR, happy days.


Build error with VS 2022

As the title.

same with 2019 with the newest pull

What's the error message?

Ok found the problem, of missing Definitions in winnt.h file Windows SDK 10. Just comment out or ifdefine for windows 11 libs?
Just made a PR here for it: https://github.com/processhacker/processhacker/pull/1024

What's the error message?
@dmex  as mentioned by @suuhm (Thanks)
@suuhm If we can upgrade CustomBuildTool to support VS 2022/Win 11 with latest SDK as well (CustomBuildTool/Utils.cs) it would be better.

The build errors with VS 2022 were all fixed 👍


How do I need to setup custom registry from private repo

I set up a custom registry in a private repo.
In the repo with sources, I added vcpkg-configuration.json to enable using ports from the custom registry.
On local environment it works great: during cmake configure I am prompted to select a credential source and then ports building is proceeded as with public ports.
But in the CI environment configuration fails with the following error:
-- Running vcpkg install
Fetching baseline information from https://github.com/private-repo/private-vcpkg-registry...
Error: Couldn't find baseline `"4e1a753b8265dc92e7e4f1de871bfe8c7b773a93"` for repo https://github.com/private-repo/private-vcpkg-registry:
fatal: not a git repository: 'C:\Users\runneradmin\AppData\Local\vcpkg\registries\git\.git'

Error: Failed to fetch https://github.com/private-repo/private-vcpkg-registry:
Error: Failed to fetch ref 4e1a753b8265dc92e7e4f1de871bfe8c7b773a93 from repository https://github.com/private-repo/private-vcpkg-registry.
fatal: Cannot prompt because user interactivity has been disabled.
bash: /dev/tty: No such device or address
error: failed to execute prompt script (exit code 1)
fatal: could not read Username for 'https://github.com': No such file or directory

-- Running vcpkg install - failed

From what I found in vcpkg-tool - it simply generates and executes git fetch cmd.
Is there a way to provide a token for git cmd? Or any different way to use a custom registry located in a private repo?

Same error if repo is cloned in a separate step and X_VCPKG_REGISTRIES_CACHE is used to provide vcpkg path to it.

A workaround is to configure git credential helper before running vcpkg.
git config --global credential.helper '!f() { echo username=${GIT_USER}; echo password=${GIT_TOKEN}; }; f'

@srgbtl, see https://github.com/microsoft/vcpkg/discussions/17720 and https://github.com/microsoft/vcpkg/discussions/17272.

The solution with using git credential approve (#17272) works for me.


Image export failed.

I am trying to convert a DGN File.
Here is my function so far
private static void ConvertDgnToPdf(Stream input, Stream output)
{
using (var cadImage = (CAD.FileFormats.Dgn.DgnImage)CAD.Image.Load(input))
{
var rasterizationOptions = new CAD.ImageOptions.CadRasterizationOptions();
rasterizationOptions.PageWidth = 600;
rasterizationOptions.PageHeight = 300;
rasterizationOptions.CenterDrawing = true;
rasterizationOptions.NoScaling = true;
rasterizationOptions.AutomaticLayoutsScaling = false;
CAD.ImageOptions.PdfOptions pdfOptions = new CAD.ImageOptions.PdfOptions();
pdfOptions.VectorRasterizationOptions = rasterizationOptions;
cadImage.Save(output, pdfOptions);
}
}
I am looking at the example https://github.com/aspose-cad/Aspose.CAD-for-.NET/blob/master/Examples/CSharp/Exporting-DGN/ExportDGNToPdf.cs and I'm getting a "Image Export Failed".
What is missing?  I am using the Nikon dgn file as well.
Also, I believe that line 21 should be  (Aspose.CAD.FileFormats.Dgn.DgnImage) instead of ** (Aspose.CAD.FileFormats.Cad.CadImage)**.  It will result in a Cannot cast 'Aspose.CAD.Image.Load(input)' (which has an actual type of 'Aspose.CAD.FileFormats.Dgn.DgnImage') to 'Aspose.CAD.FileFormats.Cad.CadImage' error.

@gmalenko,
I have observed the issue shared by you and like to share that the code sample in example is fine. There seems to be an issue with API while working with your DGN file. Can you please share the source DGN file reproducing issue on your end.

@mudassirfayyaz
Here are my example files
example_files.zip

@gmalenko ,
Thank you for sharing the files. I have tested the files on my end and have received, "Image saving failed" exception. An issue with ID CADNET-494 has been added in our issue tracking system to further investigate the issue and we will share updates with you as soon as the issue will be fixed.

@aspose-cad
Thank you

@aspose-cad  any updates?

@gmalenko,
I have verified from our issue tracking system and like to share that concerned issue has been marked as resolved in upcoming Aspose.CAD for .NET 18.2, which will be available by end of February. We will share the good news with you as soon as the issue will be fixed.


Raw File Support

Version of Photo Location Map
1.8.0
OS
Windows
OS Version
10
Description
Any chance this could be expanded to include raw photo formats (such as Canon .cr3)? This looks like a great application, but most of my photos are in cr3 format.

Hello @lazus2
I don't have cr3 files.
Could you attach your examples of cr3 files to this thread?
Please note that the example files need to have GPS coordinates within EXIF because this application reads it.
I'm not sure if this application can support cr3 or not because this application relies on some libraries for reading EXIF. Whether or not this application will be able to support cr3 depends on such libraries.
Anyways, having example files is the starting point.


Alerting with email as a destination not working in version <IP_ADDRESS>.

 Issue by Kanmanir
Wednesday May 26, 2021 at 09:44 GMT
Originally opened as https://github.com/opendistro-for-elasticsearch/alerting/issues/382

Alerting with email as a destination not working in version <IP_ADDRESS>.
I have added email as a destination , I followed procedure given on official page

Created a sender with smtp as outlook 365 with TLS port 587 and recipient email group for the destination.
Tried to add the credentials using the below command,
./bin/elasticsearch-keystore add opendistro.alerting.destination.email.xxxx.username
./bin/elasticsearch-keystore add opendistro.alerting.destination.email.xxxx.password

when tried to see what is the code used in elasticsearch-keystore, I found out it uses a class KeyStoreCli.
But KeyStoreCli class "org.elasticsearch.common.settings.KeyStoreCli" is not available in 7.10.2 in javadocs instead it has class BaseKeyStoreCommand
https://www.javadoc.io/doc/org.elasticsearch/elasticsearch/7.10.2/org/elasticsearch/common/settings/BaseKeyStoreCommand.html
keyStoreCli class is available upto 7.7.1 in javadocs
https://www.javadoc.io/doc/org.elasticsearch/elasticsearch/7.7.1/org/elasticsearch/common/settings/KeyStoreCli.html
But in opendistro version <IP_ADDRESS> has jar available for KeyStoreCli
/usr/share/elasticsearch/lib/tools/keystore-cli and this jar containes the KeyStoreCli.class
[root@3995dd7839e7 keystore-cli]# jar xvf keystore-cli-7.10.2.jar
created: META-INF/
inflated: META-INF/MANIFEST.MF
inflated: META-INF/LICENSE.txt
inflated: META-INF/NOTICE.txt
created: org/
created: org/elasticsearch/
created: org/elasticsearch/common/
created: org/elasticsearch/common/settings/
inflated: org/elasticsearch/common/settings/  AddFileKeyStoreCommand.class
inflated: org/elasticsearch/common/settings/KeyStoreCli.class
inflated: org/elasticsearch/common/settings/CreateKeyStoreCommand.class
inflated: org/elasticsearch/common/settings/ListKeyStoreCommand.class
inflated: org/elasticsearch/common/settings/RemoveSettingKeyStoreCommand.class
inflated: org/elasticsearch/common/settings/AddStringKeyStoreCommand.class
it is using this lib and class why email destination not working, and I am not able to get where it is storing credentials of sender configured from destination.
Can anybody help with configuring email destination and make it work for alerting.

Hi,
Any update on the above bug or any workaround to make it work?

Hai,
Did you find any workaround to make it work? or any schedule when this bug will be fixed?

@qreshi Could you pls triage this.

Hey @Kanmanir,
I can take a closer look at this. Would you able to answer a couple questions for me to get some more details on the issue?

Did you try on an older version of ODFE (I believe email was introduced in Alerting 1.10.1 so any version between that and this current one), are you getting the same problem there?
Is the problem with adding settings into the keystore itself, do you get any error when doing so? After adding the settings what do you see when you call ./bin/elasticsearch-keystore list?

Hi Qreshi,
I didn't try the older version of ODFE. The docker image tag for both we are using is 1.13.2 and <IP_ADDRESS> is the alerting plugin version.
sh-4.2$ ./bin/elasticsearch-plugin list
opendistro-alerting
opendistro-anomaly-detection
opendistro-asynchronous-search
opendistro-index-management
opendistro-job-scheduler
opendistro-knn
opendistro-performance-analyzer
opendistro-reports-scheduler
opendistro-sql
opendistro_security
sh-4.2$ ./bin/kibana-plugin list
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Which version of alerting plugin you want me to try? I will install it and update you.
Ans 2 : We have elasticsearch cluster setup with 4 nodes. I executed add command in all the node as per opendistro documentation. I configured outlook365 as SMTP host and tried to send test mail. I am not getting any error in logs in kibana as well as in elasticsearch.
sh-4.2$ ./bin/elasticsearch-keystore list
keystore.seed
opendistro.alerting.destination.email.kanmani.password
opendistro.alerting.destination.email.kanmani.username
The keystore list command is listing the output as above. so, I think credentials are getting added properly.

Hmm, assuming your trigger conditions are being met and the Action is being executed, are you seeing the following log messages in your elasticsearch.log:
logger.info("Message published for action name: $name, messageid: $responseContent, statuscode: $responseStatusCode")

It should give us some insight into whether or not the email action is failing.

I have tried to configured the email alerting with latest version (<IP_ADDRESS>) alerting plugin. Now its working fine.
I am able to get the email as an alert.
Thanks for helping me.

Hey @Kanmanir,
Before closing this out, to understand better, did you see any errors in the ES logs for the previous version you used when sending the message and/or did you add your keystore settings while ES was running and not call the _reload API?
I ask since I don't believe Alerting <IP_ADDRESS> made any changes that were related to the Email Destination so if it works there, it should have worked in <IP_ADDRESS>.

Hi,
I think i facing the same issue on opensearch 1.2.1, the latest version.
I'm using email address(not gmail) with port 25 without encryption.
javax.mail.MessagingException: Invalid Addresses                                                                                at org.opensearch.alerting.destination.client.DestinationEmailClient.execute(DestinationEmailClient.java:100) ~[alerting-notification-<IP_ADDRESS>.jar:?]                                 at org.opensearch.alerting.destination.factory.EmailDestinationFactory.publish(EmailDestinationFactory.java:52) [alerting-notification-<IP_ADDRESS>.jar:?]                                at org.opensearch.alerting.destination.factory.EmailDestinationFactory.publish(EmailDestinationFactory.java:39) [alerting-notification-<IP_ADDRESS>.jar:?]                                at org.opensearch.alerting.destination.Notification.lambda$publish$0(Notification.java:56) [alerting-notification-<IP_ADDRESS>.jar:?]                                                     at java.security.AccessController.doPrivileged(AccessController.java:312) [?:?]                                                                                at org.opensearch.alerting.destination.Notification.publish(Notification.java:54) [alerting-notification-<IP_ADDRESS>.jar:?]                                                              at org.opensearch.alerting.model.destination.Destination.publish(Destination.kt:319) [opensearch-alerting-<IP_ADDRESS>.jar:<IP_ADDRESS>]                                                       at org.opensearch.alerting.MonitorRunner$runAction$2.invokeSuspend(MonitorRunner.kt:680) [opensearch-alerting-<IP_ADDRESS>.jar:<IP_ADDRESS>]                                                   at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) [kotlin-stdlib-1.3.72.jar:1.3.72-release-468 (1.3.72)]                                     at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:233) [kotlinx-coroutines-core-1.1.1.jar:?]                                                                                at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:594) [kotlinx-coroutines-core-1.1.1.jar:?]                                                       at kotlinx.coroutines.scheduling.CoroutineScheduler.access$runSafely(CoroutineScheduler.kt:60) [kotlinx-coroutines-core-1.1.1.jar:?]                                                 at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:742) [kotlinx-coroutines-core-1.1.1.jar:?]                                              [2021-12-19T08:10:42,993][INFO ][o.o.a.m.MonitorRunResult ] [opensearch-node1] Internal error: javax.mail.MessagingException: Invalid Addresses. See the opensearch.log for details  java.lang.IllegalStateException: javax.mail.MessagingException: Invalid Addresses

@AndreyByhalenko Have you double checked the email address that is being used? Based on this error, the email address is not valid.

@lezzago hi, the issue was solved, thank you.

Closing

Experiencing the same issue now on <IP_ADDRESS>. An attempt to configure the sender without SMTP AUTH (local Postfix or MS Office 365 cloud) fails with "javax.mail.MessagingException: Invalid Addresses":
`[2022-05-24T15:49:15,538][DEBUG][o.o.a.r.RestGetDestinationsAction] [opensearch01] GET /_plugins/_alerting/destinations
[2022-05-24T15:49:15,538][DEBUG][o.o.a.t.SecureTransportAction] [opensearch01] User and roles string from thread context: andrija.pantovic@phoenix-systems.ch|admin|own_index,all_access|admin
[2022-05-24T15:49:15,538][DEBUG][o.o.a.t.SecureTransportAction] [opensearch01] Is filterByEnabled: false ; Is admin user: true
[2022-05-24T15:49:23,079][DEBUG][o.o.a.r.RestExecuteMonitorAction] [opensearch01] POST /_plugins/_alerting/monitors/_execute
[2022-05-24T15:49:23,080][DEBUG][o.o.a.t.TransportGetMonitorAction] [opensearch01] User and roles string from thread context: andrija.pantovic@phoenix-systems.ch|admin|own_index,all_access|admin
[2022-05-24T15:49:23,080][DEBUG][o.o.a.MonitorRunner      ] [opensearch01] Running monitor: kore_hsm_syslog_test with roles: [own_index, all_access] Thread: DefaultDispatcher-worker-8
[2022-05-24T15:49:24,090][ERROR][o.o.a.d.f.EmailDestinationFactory] [opensearch01] Exception publishing Message: DestinationType: EMAIL, DestinationName: my_test, Host: phoenixsystems-ch01i.mail.protection.outlook.com, Port: 25, Message: Monitor kore_hsm_syslog_test just entered alert status. Please investigate the issue.

Total hits:
Trigger: severe_events
Severity: 1
Period start: 2022-05-24T15:48:23.079Z
Period end: 2022-05-24T15:49:23.079Z

The syslog messages:
javax.mail.MessagingException: Invalid Addresses
at org.opensearch.alerting.destination.client.DestinationEmailClient.execute(DestinationEmailClient.java:79) ~[alerting-notification-<IP_ADDRESS>.jar:?]
at org.opensearch.alerting.destination.factory.EmailDestinationFactory.publish(EmailDestinationFactory.java:31) [alerting-notification-<IP_ADDRESS>.jar:?]
at org.opensearch.alerting.destination.factory.EmailDestinationFactory.publish(EmailDestinationFactory.java:18) [alerting-notification-<IP_ADDRESS>.jar:?]
at org.opensearch.alerting.destination.Notification.lambda$publish$0(Notification.java:35) [alerting-notification-<IP_ADDRESS>.jar:?]
at java.security.AccessController.doPrivileged(Native Method) [?:?]
at org.opensearch.alerting.destination.Notification.publish(Notification.java:33) [alerting-notification-<IP_ADDRESS>.jar:?]
at org.opensearch.alerting.model.destination.Destination.publish(Destination.kt:298) [opensearch-alerting-<IP_ADDRESS>.jar:<IP_ADDRESS>]
at org.opensearch.alerting.MonitorRunner$runAction$2.invokeSuspend(MonitorRunner.kt:659) [opensearch-alerting-<IP_ADDRESS>.jar:<IP_ADDRESS>]
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) [kotlin-stdlib-1.3.72.jar:1.3.72-release-468 (1.3.72)]
at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:233) [kotlinx-coroutines-core-1.1.1.jar:?]
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:594) [kotlinx-coroutines-core-1.1.1.jar:?]
at kotlinx.coroutines.scheduling.CoroutineScheduler.access$runSafely(CoroutineScheduler.kt:60) [kotlinx-coroutines-core-1.1.1.jar:?]
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:742) [kotlinx-coroutines-core-1.1.1.jar:?]
[2022-05-24T15:49:24,091][INFO ][o.o.a.m.MonitorRunResult ] [opensearch01] Internal error: javax.mail.MessagingException: Invalid Addresses. See the opensearch.log for details
java.lang.IllegalStateException: javax.mail.MessagingException: Invalid Addresses
at org.opensearch.alerting.destination.factory.EmailDestinationFactory.publish(EmailDestinationFactory.java:36) ~[alerting-notification-<IP_ADDRESS>.jar:?]
at org.opensearch.alerting.destination.factory.EmailDestinationFactory.publish(EmailDestinationFactory.java:18) ~[alerting-notification-<IP_ADDRESS>.jar:?]
at org.opensearch.alerting.destination.Notification.lambda$publish$0(Notification.java:35) ~[alerting-notification-<IP_ADDRESS>.jar:?]
at java.security.AccessController.doPrivileged(Native Method) ~[?:?]
at org.opensearch.alerting.destination.Notification.publish(Notification.java:33) ~[alerting-notification-<IP_ADDRESS>.jar:?]
at org.opensearch.alerting.model.destination.Destination.publish(Destination.kt:298) ~[opensearch-alerting-<IP_ADDRESS>.jar:<IP_ADDRESS>]
at org.opensearch.alerting.MonitorRunner$runAction$2.invokeSuspend(MonitorRunner.kt:659) ~[opensearch-alerting-<IP_ADDRESS>.jar:<IP_ADDRESS>]
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) [kotlin-stdlib-1.3.72.jar:1.3.72-release-468 (1.3.72)]
at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:233) [kotlinx-coroutines-core-1.1.1.jar:?]
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:594) [kotlinx-coroutines-core-1.1.1.jar:?]
at kotlinx.coroutines.scheduling.CoroutineScheduler.access$runSafely(CoroutineScheduler.kt:60) [kotlinx-coroutines-core-1.1.1.jar:?]
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:742) [kotlinx-coroutines-core-1.1.1.jar:?]
Caused by: javax.mail.MessagingException: Invalid Addresses
at org.opensearch.alerting.destination.client.DestinationEmailClient.execute(DestinationEmailClient.java:79) ~[alerting-notification-<IP_ADDRESS>.jar:?]
at org.opensearch.alerting.destination.factory.EmailDestinationFactory.publish(EmailDestinationFactory.java:31) ~[alerting-notification-<IP_ADDRESS>.jar:?]
... 11 more
`
When SMTP AUTH client configured (for example MS Office 365 smtp.office365.com:587 with TLS and credentials set in the keystore) the setup works fine:
2022-05-24T15:59:05,415][DEBUG][o.o.a.r.RestExecuteMonitorAction] [opensearch02] POST /_plugins/_alerting/monitors/_execute [2022-05-24T15:59:05,416][DEBUG][o.o.a.t.TransportGetMonitorAction] [opensearch02] User and roles string from thread context: andrija.pantovic@phoenix-systems.ch|admin|own_index,all_access|admin [2022-05-24T15:59:05,417][DEBUG][o.o.a.MonitorRunner      ] [opensearch02] Running monitor: kore_hsm_syslog_test with roles: [own_index, all_access] Thread: DefaultDispatcher-worker-1 [2022-05-24T15:59:06,923][INFO ][o.o.a.m.d.Destination    ] [opensearch02] Message published for action name: my_test, messageid: Sent, statuscode: 0

I'm using OSD 1.2.0
Opensearch Reporting scheduler not working with E-mails.
Don't want to add emails to my settings everytime a report has to be sent over a new email address.
Anyworkaround?

@Sandy381 Looks like you've already found your way to https://github.com/opensearch-project/dashboards-reports/issues/72, that would be the best place to continue discussions as it pertains to Reporting integrating with the Notifications plugin.


Fix: change filter’s option -p into —prompt

Hi!
Your anyfff is so helpful because I am just looking for something like anyframe or enhancd in fish-shell.
I use peco as a selector tool but peco do not recognize -p option.
So I rewrite the short option -p into long one --prompt.
Most of selector tools such as sk, fzy, and fzf have both of the long option --prompt and short one -p.
So I think this change do not cause problems in most cases.

I am glad you liked it!
Thank you for your contribution, added to master 🎉


DOCS: REQUEST: Add page detailing supported types and UN-supported types?

Hi All,
Any chance of adding a simple table of supported and unsupported objects (for non-object-mode compilation)? There's a start here, but it's far from complete and a little hard to interpret. For example, no mention of string or set support (which, through experimentation, I've realized aren't supported).
I think it'd be a nice quick reference, especially so people can keep an eye out for updates!
Thanks!

By definition, things that are not listed there are not supported (unless we forgot to update the docs). I'm not sure what more we could do: listing all existing Python types would be unwieldy, and ultimately pointless.

OK – some things you don't support are explicitly listed, I guess I thought a slightly more complete list would be helpful. My sense is that it's not quite as clear what is and is not supported as it could be.

We list things we don't support only when as an exception to a larger rule (such as "we support all syntactical constructs except..."). Listing all unsupported features would make a very long list, for no practical benefit.


Element.toFront()   doesn't work on IE6

Same as the title...

I don't know of anyone or any software out there that still supports IE6. That thing is way dead.
https://www.modern.ie/en-us/ie6countdown

:-1:


Idea: defekt-sonarqube-plugin

I use SonarQube for all of my projects (it is a free service for open source projects). It would be great to have a plugin, which can be used to show the results of a static code analysis of Kotlin code done by detekt in SonarQube (I use the sonarqube-gradle-plugin).

Yes that would be a good step to make detekt more popular, thx for the suggestion! But I do not know when I will have time to work myself into sonar -> masterthesis.

Thank you very much for your reply. Unfortunately I don't have any experience with writing sonar plugins. This month we have a few Hackergarten events here (Bern, Basel, Lucerne) where I suggest this topic – maybe there is someone who can help.

Some useful links:
https://deors.wordpress.com/2014/03/20/sonarqube-plugins-1/
https://www.beyondjava.net/blog/write-sonarqube-plug-in/
http://ashismo.github.io/java-code quality analyzer/2016/06/09/Custom-Java-Plugin-For-SONAR
https://github.com/SonarSource/sonar-custom-plugin-example
I will take a look at these ^^

How is it going with this?

It's delayed after 1.0 release without the milestone number :). Take a look at the ROADMAP.md file.

Well, worked started for this. Prototype works and is in a PR, just need to figure out why sonar-runner does not sent the issues to the server :O

detekt-sonar-kotlin-plugin in early access version 0.1.0 can be build from master and used in sonar 5.6 or 6.4 :)

Syntax-Highlighting, more descriptions etc will follow!

As sonar-kotlin now has it's own repository, I will close this one.

Thank you very much for your work! I hope to have some time soon to try it out.


Different Behavior of tf.raw_ops.AdjustContrastV2 with jit_compile=True

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
2.14.0
Custom code
Yes
OS platform and distribution
Ubuntu 22.04.3 LTS (x86_64)
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
11.8
GPU model and memory
GPU 0: NVIDIA GeForce RTX 2070 GPU 1: NVIDIA GeForce RTX 2070 GPU 2: NVIDIA GeForce RTX 2070 GPU 3: NVIDIA GeForce RTX 2070
Current behavior?
When the tf.raw_ops.AdjustContrastv2 operation is invoked within a tf.function with JIT compilation enabled (jit_compile=True), it produces different results compared to the same operation called without JIT compilation. This inconsistency is observed when the code is executed on a CPU device.
Standalone code to reproduce the issue
import tensorflow as tf
import traceback

class Network(tf.Module):
    def __init__(self):
        super().__init__()

    @tf.function(jit_compile=True)
    def __call__(self, x):

      x = tf.raw_ops.AdjustContrastv2(images=x, contrast_factor=tf.random.normal([], dtype=tf.float32))
      return x

m = Network()
inp = {
    "x": tf.random.normal([8, 8, 8], dtype=tf.float32),
    }

with tf.device('/CPU:0'):
    tf.config.run_functions_eagerly(True)
    no_op_res = m(**inp)
    tf.config.run_functions_eagerly(False)
    with tf.device('/CPU:0'):
        op_res = m(**inp)

    tf.debugging.assert_near(tf.cast(no_op_res, tf.float64), tf.cast(op_res, tf.float64), atol=0.001, rtol=0.001)

Relevant log output
File "/home/guihuan/LLM/results/tf-2/2023-10-22-20-21/test.py", line 27, in <module>
    tf.debugging.assert_near(tf.cast(no_op_res, tf.float64), tf.cast(op_res, tf.float64), atol=0.001, rtol=0.001)
  File "/home/guihuan/.conda/envs/night/lib/python3.9/site-packages/tensorflow/python/util/traceback_utils.py", line 153, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/home/guihuan/.conda/envs/night/lib/python3.9/site-packages/tensorflow/python/ops/control_flow_assert.py", line 102, in Assert
    raise errors.InvalidArgumentError(
tensorflow.python.framework.errors_impl.InvalidArgumentError: Expected 'tf.Tensor(False, shape=(), dtype=bool)' to be true. Summarized data: b''
b'x and y not equal to tolerance rtol = tf.Tensor(0.001, shape=(), dtype=float64), atol = tf.Tensor(0.001, shape=(), dtype=float64)'
b'x (shape=(8, 8, 8) dtype=float64) = '
0.09821675717830658, -0.057733699679374695, 0.08248079568147659, ...
b'y (shape=(8, 8, 8) dtype=float64) = '
0.17769138514995575, -0.02411397360265255, 0.15723268687725067, ...

Hi @zoux1a ,
It seems there is precision related errors as you are casting float32 to float64. If I print overall result like converting the array to a number using tf.reduce_sum() then tf.reduce_sum(tf.cast(no_op_res, tf.float64)) is equal to  tf.reduce_sum(tf.cast(op_res, tf.float64) in the tolerance level of 0.00001.
I have checked this assertion and its success.
tf.debugging.assert_near(
          tf.reduce_sum(tf.cast(no_op_res, tf.float64)),
          tf.reduce_sum(tf.cast(op_res, tf.float64)),
          atol=0.00001,
          rtol=0.00001
)

This means the difference in results are just precision related or the order of elements might be different.But overall the result is same as described in the attached gist-r1.
Thanks!

Hi @zoux1a ,
I have debugged more into the issue and the root cause is the contrast_factor which you are using as random initializer and this value is different for both eager and graph execution. I have printed the same and you can observe both contrast_factor values are different in both cases which is causing the difference results but keeping the overall sum same.
If I pass a fixed contrast_factor say 0.2 , the results are same with and without jit_compile.
Please find the attached gist-r2 for same excercise.


Fix mapping of methods which have parameter types of String, Date or byte[]

Previously, an annotated method with a parameter type of String, Date or byte[] would fail with exception.
@Column(COL_FIRSTNAME)
public void setFirstname(String firstName) {
    this.firstname = firstname;
}

Error:(38, 15) error: Unsupported type java.lang.String as parameter...

This was caused by MethodCodeFactory using the method type (return type?) instead of the parameter type.
There was also a closing bracket missing when generating ContentValues builder methods for Date fields.

Thanks!

I have release your fix in 0.2.2. May takes some hours to be synced with maven central

Awesome - thanks :)


Javascript error: same origon policy

Description
I get an error from my browser that Gitea tried to access forbidden elements to to SOP
Gitea Version
1.21.1 (-rootless)
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots

Git Version
No response
Operating System
No response
How are you running Gitea?
portainer stack
Database
SQLite

Lol, that should only be a grafical bug of bitwaden. The same javascript error also happens on the demo website
But will test it with disabled bitwarden.

Could you help to provide the embedded HTML? Then we can make Gitea ignore these non-same origin resources, then there will be no error anymore.

how can I do that?

Could you also try to figure out the outer iframe code?
ps: I proposed a fix #29081.

ps: I proposed a fix #29081.

when ready I could test it with a rootless docker image

We can't do builds for pull requests, so you'd have to build from source and run that.
What are the minimal steps to reproduce? Just install the Bitwarden extension and open Gitea? Any specific settings made in the extension?

Odd, because I'm also a Bitwarden user on Firefix and have never seen this error. There must be something different about your setup.

My extension does not have this "Show auto-fill menu on form fields" option, maybe that is causing the iframe? Try toggling it off. What's the version of your extension? Mine is 2024.1.1.

As per this the feature is only enabled for Bitwarden Cloud users, not self-hosted like mine is.

No, it's fine. https://github.com/go-gitea/gitea/pull/29081 will fix it, one way or another.

ps: I proposed a fix #29081.

when ready I could test it with a rootless docker image

1.21 nightly is ready by #29089


feature: add TTL for argo workflows

adds a TTL of one week for argo workflow specs, matching the TTL present in Kubernetes job specs

addresses #1231

If there any chance this functionality could be made configurable? In particular, would it be possible to turn it on or off?
In our organisation we set the TTL via workflow defaults on the Argo workflow controller. We would like to manage the TTL for all workflows, including those running via Metaflow, in the same manner. As such, we would like to be able to turn off this functionality and rely on our existing approach.

Great point! We can reorient this PR to address pod TTLs so that your current strategy still works.

If there any chance this functionality could be made configurable? In particular, would it be possible to turn it on or off?
In our organisation we set the TTL via workflow defaults on the Argo workflow controller. We would like to manage the TTL for all workflows, including those running via Metaflow, in the same manner. As such, we would like to be able to turn off this functionality and rely on our existing approach.

Great point! We can reorient this PR to address pod TTLs so that your current strategy still works.

We could adapt things on our side to handle this PR in its current format, e.g., remove the ttlStrategy fields from the workflows when we create the manifests, so it is not a massive issue either way.
It would definitely be some additional work though, so would prefer something else if possible.
Pod TTLs would work. Also something like having a METAFLOW_ARGO_TLL setting in metaflow_config.py that defaults to a week. If the TTL was not set when this piece of config is set to zero/none, then it would also be trivial for us to handle.


Be able to delete resources

I need to kill pods a lot. Muahahaha

In the meantime, https://github.com/farmotive/kud


Fix content-length tests

Motivation
The runtime library now always includes content-length with bodies, and our tests verified the exact set of header fields present.
Modifications
Update the expectations to include the content-length header.
Result
Passing tests again.
Test Plan
Tests are passing again.

I think this should come with an update of the minimum version of runtime.

I think this should come with an update of the minimum version of runtime.

Good point, let me update


Move CompileAllBuildCacheNG to QuickFeedbackLinux

So it can run with each commit. Also, we don't want it to fail any stage.

I've triggered a build for you.


Added inclusion of Privacy Notice as a To Use step

This is a suggestion resolution for issue #16

+1


Updating broker/Interoperator docker image versions

Updating SF broker docker image version : 0.4.1
Updating SF interoperator docker image version : 0.4.1
Updating Helm Chart version : 0.4.1

Pull Request Test Coverage Report for Build 3363

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 89.852%

Totals

Change from base Build 3361:
0.01%

Covered Lines:
9398

Relevant Lines:
10103

💛  - Coveralls


non field errors

I'm wondering how should one support errors returned by the api that don't correspond to any single field.
For example, say you have a Credit Card form. All the input values pass client-side validation. However, the card is low on funds and an api error is returned. How should a formsy form display the api validation error?
In django it's called a non_field_error http://devdocs.io/django~1.9/ref/forms/api#django.forms.Form.non_field_errors It'd be nice to outline this in the examples.

Hi, did you find any answer to this? I'm struggling with the same.
For example, the API returns an error key 'all' which isn't mapped to any field, and some other field errors, but the updateInputsWithError will fail because of the all key that is not an actual field.
I tried building a custom input that will simply be a placeholder for the all key, but adding an error there would cause the form to be in a permanent invalid status since the input is invalid and there's no easy way to make it valid while at the same time contain an error.

I have not found a solution. I have had to make my component stateful and append any non_field_error to the component's state. Then in the render block I do
render() {
  const flashError = this.state.errors.map((e) =>
e.message
);
  return (
    {flashError}
    ...
  )
}

I feel like this is a common enough problem (not my solution necessarily) that it bears adding to the formsy examples.

Does that mean you can't use updateInputsWithError directly from the server response so you don't need to map each field to form field manually one by one? I was doing things this way so errors would be really easy to manage as long as name and error keys match (which happens by design)
I came with probably a very ugly work around, but I ended up extending the Formsy.Form class, and added a different updateInputsWithError method which is basically a copy paste of the original, but rather than raising an exception on invalid keys, they are all sent to the last input error field. So all the non field errors always end up at the bottom. Not a great solution but allows me to leave the code as it is for error - field mapping.

right, fundamentally formsy attempts to map an error to an input. But we are currently handling errors that don't map to any particular input. It'd be great to get some guidance on this usecase from the authors.


Use #!/usr/bin/env for bash shebangs

/bin/sh and /usr/bin/env are the only two binaries that NixOS provides at a fixed path (outside a buildFHSUserEnv sandbox).
This discussion was split from #11004.

Merged, thanks @andersk!  Though should we also move /bin/sh for codebase consistency?  There's hardly anything with /bin/sh, and I wouldn't be surprised if half of these use bash features anyway.
docs/tutorials/shell-tips.md:cases, `#!/bin/bash` or `#!/bin/sh` is used.
puppet/zulip/files/nagios_plugins/zulip_nagios_server/check_website_response.sh:#!/bin/sh
puppet/zulip/files/postgresql/env-wal-e:#!/bin/sh
puppet/zulip_ops/files/munin-plugins/humbug_send_receive:#!/bin/sh
puppet/zulip_ops/files/munin-plugins/rabbitmq_connections:#!/bin/sh
puppet/zulip_ops/files/munin-plugins/rabbitmq_consumers:#!/bin/sh
puppet/zulip_ops/files/munin-plugins/rabbitmq_messages:#!/bin/sh
puppet/zulip_ops/files/munin-plugins/rabbitmq_messages_unacknowledged:#!/bin/sh
puppet/zulip_ops/files/munin-plugins/rabbitmq_messages_uncommitted:#!/bin/sh
puppet/zulip_ops/files/munin-plugins/rabbitmq_queue_memory:#!/bin/sh
puppet/zulip_ops/files/munin-plugins/tornado_event_queues:#!/bin/sh
puppet/zulip_ops/files/postgresql/setup_disks.sh:#!/bin/sh
puppet/zulip_ops/files/zulip-ec2-configure-interfaces_if-up.d.sh:#! /bin/sh
scripts/lib/third/install-yarn.sh:#!/bin/sh
tools/circleci/Dockerfile.template:CMD ["/bin/sh"]
tools/linter_lib/custom_check.py:                # /bin/sh and /usr/bin/env are the only two binaries
tools/linter_lib/custom_check.py:                {'pattern': '^#!(?! *(?:/usr/bin/env|/bin/sh)(?: |$))',

I doubt we have /bin/sh scripts using bash features: /bin/sh is dash on Ubuntu, and ShellCheck also catches bashims in /bin/sh scripts. We can always change the shebang on individual scripts if we want to add bashisms. Doing it in en masse doesn’t seem worth the hassle. (Unless we also want to turn on bash-specific features like errtrace and pipefail, which is maybe worthwhile but needs extra attention.)

OK, that's fair.  Those scripts have basically all not been edited in years in any case.


Implement pcap_major/minor_version()

Getting the pcap_major_version()/pcap_minor_version() of a dump file can be handy.

I'm concern with i32 this function return an int this is not always an i32 this could make rust_pcap not compile on some target. I would prefer at least a cast to i32. Or we return a c_int and let the user handle this.
I would like you add a fn version(&self) ->(i32, i32) that return both. (utils)

Makes sense - yes. Done.
And added a cast to i32. I think this should be ok  c_int is i32 on all platforms rust knows of today, and even more so for the platforms libpcap can run on.

I think you misunderstand, I wanted to add version-) not remove the two others method.
About the i32 I saw we already have a i32 exposed https://docs.rs/pcap/0.9.2/src/pcap/lib.rs.html#898-901 so add your code should not break already existing workflow. I only found some micro controller that are 16 bits, but I don't think pcap could run on them anyway so I think it's a non problem for now.

Thanks for the PR @noselasd!
I'm not sure what the problem with i32 is. If c_int has a smaller bitwidth it's safe, it's only a problem if it has more, which it could in principle according to spec. Rust decided to default c_int to i32 (https://doc.rust-lang.org/std/os/raw/type.c_int.html) so I think that's good enough for us.
Once you reintroduce major_version and minor_version and make version call the pcap functions it can be merged.

I think you misunderstand, I wanted to add version() not remove the two others method. (version() would simply call the other two)
Aye, I didn't quite get that .Added them back 😄

I'm not sure what the problem with i32 is. If c_int has a smaller bitwidth it's safe, it's only a problem if it has more, which it could in principle according to spec. Rust decided to default c_int to i32 (doc.rust-lang.org/std/os/raw/type.c_int.html) so I think that's good enough for us.

It's not about safety but about compilation playground:
fn foo(_: u16) {}

fn bar(_: u32) {}

fn main() {
    foo(42u32);
    bar(84u64);
}


sexycooldown seems to load scripts after includes even if scripts are declared first

if this works in the client then we need to redo <ui> handling in xml loading

confirmed in retail client that the addon is broken as is. WAI


Portfolio: desktop version

Portfolio desktop version website code optimized in index.html and style.css with added reset.css file.
Use of media queries to make sure website displays correctly on desktop and mobile screens.
Add new folder assets for storing new images and css folder to store style.css and rest.css files.

hi @prolajumokeoni thanks for the review. I have the checked the code and cloned the project again from the specific branch. Everything's fine with me, there's no clustering of sections and also the padding between skills li seems fine. What do you suggest what must do in order to correct all these clashes in the project?


GoThemis version badge

Add a badge for GoThemis as well, leading to our pkg.go.dev page. Unfortunately, this badge needs to be manually updated with each release. Though, there is an issue tracking badge generation. There has been some recent progress on it, but who knows when it lands into production.

d(⌒ー⌒d)


WIP: Compile dependencies from node_modules

Resolves #725.
While this all seems to work, it still feels very much like a hack to me as I haven't explored a lot of edge cases. However, I wanted to open a draft PR early just to make sure this is the right approach or if there are other ideas. If you are comfortable with this approach I can start to clean things up and add some test cases.
I was able to get the trivia sample working with passing an Instant as a game parameter. However I switched to the world-clock sample for the PR since it was a more natural fit; it compiles but I haven't tested it for real yet.

Seems like a great first step. Do you want feedback on the individual TODOs?

Seems like a great first step. Do you want feedback on the individual TODOs?

I would gladly take any feedback you have on TODOs! Quite a few are just notes to myself on what needs to be improved in the next round of changes so don't stress about it if you like the general direction this PR is going.

After some research & experimentation, I think we’re gonna try to support a WASM-based future for this project. That means anything we build to better support NPM & JS ecosystem is gonna have a limited lifespan.

Is this still active ?
Can see the mention of shift to WASM, and short lifespan on this if ever included until Zipline 2.0 arrives.
Couldn't resist asking, if yes, any eta on that ?


Image builder for Bottlerocket Metal Variant

Description of changes:
Bottlerocket now has a metal variant. These changes will help pull these images and upload them along with our Ubuntu image building process for raw/metal.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/test imagebuilder-presubmit

/test imagebuilder-presubmit

/retest

/test imagebuilder-presubmit

/test imagebuilder-presubm

/test imagebuilder-presubmit

/test imagebuilder-presubmit


Talk to Alexa during TuneIn Playback

We have ported AVS SDK Ver1.7 to our custom platform based on imx7D. We have built successfully and we could run Alexa also.
We asked Alexa to play from TuneIn. It said, getting the last tuneIn Station and started playing that station. We interrupted by asking a question. It went  to different states like Listening, Thinking and Speaking but the response was not heard. It was like muted.
After this, it resumed TuneIn playback.
We like to know though it got response for our question but it not speak out when we interrupted during TuneIn playback. Please check and advice.

Hi @jimediaplayer, in order to investigate further, would you be able to attach the DEBUG9 logs.
You can enable DEBUG9 by running cmake with -DCMAKE_BUILD_TYPE=DEBUG and enabling DEBUG9 mode with $TZ=UTC ./SampleApp xxx/AlexaClientSDKConfig.json DEBUG9
Please capture the entire log and attach the file.

Hi,
Kindly find the attached log regarding issue mentioned above.
TuneIn-AVS.txt

Hi @jimediaplayer, sorry for not getting back to you sooner, are you still seeing this issue.  The logs you provided doesn't contain the DEBUG9 logs.  But I remember some platforms are not able to play more than one sound simultaneously. Could you try adding a dmix plugin to your alsa: https://alsa.opensrc.org/Dmix


Input for 4337 checklist

Here is some input the for checklist, that will require some structuring
Other chains:
Does the L2 chain support eth_sendRawTransactionConditional?
https://blog.oplabs.co/erc-4337-and-account-abstraction/
https://notes.ethereum.org/@yoav/SkaX2lS9j
https://github.com/maticnetwork/bor/pull/700
https://forum.arbitrum.foundation/t/aip-2-activate-support-for-account-abstraction-endpoint-on-one-and-nova/14790
Does the chain (plan to) support rip-7560?
https://github.com/eth-infinitism/RIPs/blob/native_account_abstraction/RIPS/rip-7560.md
Does the factory allow anyone to add stake to the entrypoint?
In that case the unstakeDelay may not be changed (could be set to high value and then prevents unstake)
Does the wallet support the latest Entrypoint contract?
https://github.com/eth-infinitism/account-abstraction/releases
Does the wallet only access storage fields that are associated with the sender?
Otherwise that standard bundlers won't support it
https://eips.ethereum.org/EIPS/eip-4337#storage-associated-with-an-address
Is the wallet proxy based?
If so, which proxy is used?
If its an ERC1967Proxy, does it comply to the standard?
Can the smart contract account be converted to another type of smart contract account (via the proxy pattern)?
Could the initalizable storage slot be reused? See https://github.com/OpenZeppelin/openzeppelin-contracts/issues/4782
Does the wallet account support modules?
If so what type?

Delegate call based:

https://docs.zerodev.app/extend-wallets/overview
diamond pattern EIP-2535
safe

Call based

https://eips.ethereum.org/EIPS/eip-6900
Universal Profile (slightly different) https://github.com/lukso-network/LIPs/tree/main/LSPs

Does it comply to the specs?
If delegatecall is used (e.g. Safe modules): no storage slots overlaps
What is the process the review modules?
What is the process to register modules?
Does the wallet support session keys?
https://www.biconomy.io/post/modular-session-keys
https://docs.zerodev.app/blog/session-keys-are-the-jwts-of-web3
https://docs.zerodev.app/use-wallets/use-session-keys
https://mirror.xyz/matchboxdao.eth/VXOvLKIvfXHP-cusKHw55zqlHpvvWwzh_fqm6j48Yek
Checks for applications using erc-4337
Do applications use ERC-6492: Signature Validation for Predeploy Contracts?
If so it comply to the standard?
https://eips.ethereum.org/EIPS/eip-6492 Signature Validation for Predeploy Contracts

trivial things - signature check (erc1271), not using tx.origin
gas assumptions: always use estimate, don't assume specific cost, like the 21000 fixed cost of "transfer"
support batching (not required, but can greatly improve UX)
Support paymaster: (e.g. pay gas with the token I'm converting)

Links
https://hacken.io/discover/erc-4337-account-abstraction/

Hi @gpersoon,
Thank you for the contribution, it's great!
I will review this in more detail and integrate each point into the existing checklist. I'll ping you after I have a new version ready and will ask for feedback once it's completed.


fix composer to use defined php version if found in /usr/bin/composer

Q
A

Bug fix?
Yes

New feature?
No

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

if compoesr is found /usr/bin/composer it wont add the defined php binary {{bin/php}} in front of it as it would if composer need to be downloaded.

BTW: This PR originates from the 6.8.0 TAG. master seems to clearly be 7.0.0 and the branch 6.x is (way) behind.

Yes, now work activity going on. Maybe you can rebased you pr to master?

Would it be possible to release that fix within 6.8.x? I can then also port it to 7.0.0. WDYT?


Fixing some of the mis-configured rate metrics

Some of the network metrics have been configured as histograms when the need is just for rates. So have fixed them with this patch.
SLA: 5 mins
Reviewers: @cgtz @pnarayanan

LGTM, has it been built and formatted?

yes. done.


Remove the dependency of Guava

Since Chimera is library, we should not have dependency with Guava.

Thanks @winningsix! This patch is overall great! A few of minor comments will be posted online the code.

This closes #60


Cannot generate rust bindings for fbx c++ library

Hello!
I'm trying to generate rust bindings for the autodesk fbx c++ library to be able to use the fbx functionalities inside a rust application.
The fbx library is comprised of precompiled dynamic libraries and header files and it's publicly available.
I created a build.rs file like this:
fn main() {
    println!("cargo:rustc-link-search=/path/to/lib/gcc/x64/release/"); // path to the compiled fbx library
    println!("cargo:rustc-link-lib=fbxsdk");

    cxx_build::bridge("src/main.rs")
        .flag_if_supported("-std=c++11")
        .include("/path/to/lib/include")  // path to the fbx headers files
        .compile("cxxbridge-demo");
    println!("cargo:rerun-if-changed=src/main.rs");
    println!("cargo:rerun-if-changed=src/shim.h");
}

My main.rs file is like this:
#[cxx::bridge]
mod ffi {
    unsafe extern "C++" {
        include!("testcxx/lib/include/fbxsdk.h");
        include!("testcxx/src/shim.h");

        type FbxManager;

        fn FbxManager_Create() -> UniquePtr<FbxManager>;
    }
}
fn main() {
    let mgr = ffi::FbxManager_Create();
}

In shim.h I tried to create a shim for the FbxManager::Create() static method which is usually the first method called to initilaize the library.
This is shim.h
#pragma once
#include <fbxsdk.h>
#include <memory>

std::unique_ptr<FbxManager> FbxManager_Create() {
    return std::unique_ptr<FbxManager>(FbxManager::Create());
}

When I run cargo build with this situation I get an ld error that says:
path/to/testcxx/target/debug/build/testcxx-59666266ff383069/out/libcxxbridge-demo.a(main.rs.o): in function `FbxManager_Create()':
          /path/to/testcxx/target/debug/build/testcxx-59666266ff383069/out/cxxbridge/crate/testcxx/src/shim.h:6: undefined reference to `fbxsdk::FbxManager::Create()'
          collect2: error: ld returned 1 exit status

I would like to ask help for this specific case but also how in general I should behave when trying to bind to c++ static methods and creating instances of c++ classes.
Many thanks,
Frank

Perhaps add inline:
inline std::unique_ptr<FbxManager> FbxManager_Create() {
    return std::unique_ptr<FbxManager>(FbxManager::Create());
}

Sorry I forgot to transcribe the 'inline' statement because I did thousands of attempts, for a second I wished it would be that easy :-)
Unfortunately the error is the same even with inline added.
Thanks,
Frank

Ah, yes, reading your error message more carefully it's not that simple :)
 undefined reference to `fbxsdk::FbxManager::Create()'
          collect2: error: ld returned 1 exit status

It seems like the SDK itself is not being linked in. I'd double-check these lines are having the desired effect
    println!("cargo:rustc-link-search=/path/to/lib/gcc/x64/release/"); // path to the compiled fbx library
    println!("cargo:rustc-link-lib=fbxsdk");

cargo build -vvv may give clues about the linker command actually being used? You could also use commands like nm to list the symbols inside the fbxsdk to ensure it really does contain the Create method you're calling.

It looks like those two lines written like that are the only way I could make it compile without errors concerning library not found.
Those libraries are compiled with gcc 4.8 in both static and dynamic versions (.so and .a), could this be a problem?
I'm kind of desperate, the FbxManager::Create() method is the main entry point for the library so it's exported for sure.
Unfortunately I'm not an expert with c compilers and linkers...
Sorry, maybe the issue section is not the place to discuss these kind of problems, is there some other forum or community where I should ask instead?
Thanks,
Frank

Without a lot more information (especially the full build output with -vvv and some nm-like dumps) I'm not sure there's much more I can suggest. All you really need to know about linking is that the libcxxbridge-demo.a generated by the cxx and cc build process will require certain mangled names, and those names need to be within libfbxsdk.so or libfbxsdk.a. You use nm or objdump to check that those lists match up. (My only theory is that somehow the old version of GCC is doing different C++ name mangling from the modern compiler, but this suggests it should be compatible).

My other guess is it's an order sensitive link flag situation. If you're doing the link using gold or GNU ld, the rustc-link-lib (which are -l flags) are order sensitive. You might try moving rustc-link-lib=fbxsdk further down. Alternatively you can rule out order sensitivity by using lld for the linker, which is not order sensitive for -l flags. RUSTFLAGS="-C link-arg=-fuse-ld=lld"

Hi guys!
Thanks a lot for the suggestions!
I followed the advice of changing the order of linking and placed the rustc-link-lib=fbxsdk at the end of build.rs. Finally this revealed some enlightning messages:
note: /usr/bin/ld: /path/to/testcxx/lib/lib/gcc/x64/release//libfbxsdk.so: undefined reference to `deflateInit_'
          /usr/bin/ld: /path/to/testcxx/lib/lib/gcc/x64/release//libfbxsdk.so: undefined reference to `xmlDocSetRootElement'

and others like these.
This suggested me that the the linker missed gzlib and libxml2.
So I added them making my build.rs like this:
fn main() {
    println!("cargo:rustc-link-search=/path/to/testcxx/lib/lib/gcc/x64/release/");

    cxx_build::bridge("src/main.rs")
        .flag_if_supported("-std=c++11")
        .include("/path/to/testcxx/lib/include")
        .compile("cxxbridge-demo");
    println!("cargo:rerun-if-changed=src/main.rs");
    println!("cargo:rerun-if-changed=src/shim.h");

    println!("cargo:rustc-link-lib=fbxsdk");
    println!("cargo:rustc-link-lib=z");
    println!("cargo:rustc-link-lib=xml2");
}

and finally the build completed successfully!
Now I have another problem: when running cargo run I get this error:
target/debug/testcxx: error while loading shared libraries: libfbxsdk.so: cannot open shared object file: No such file or directory
what should I add to make it work?
Thanks,
Frank

Please forget my last question, I solved by adding libfbx to LD_LIBRARY_PATH.
Now the build and run complete without errors but I have two problems.
1: many destructors in the fbx library are declared as protected. For example the FbxManager class is declared like this:
class FBXSDK_DLL FbxManager
{
...
protected:
	FbxManager();
	virtual ~FbxManager();
}

This leads to an error during the build:
/path/to/testcxx/target/debug/build/testcxx-59666266ff383069/out/cxxbridge/crate/testcxx/src/shim.h:6:60:   required from here
/usr/include/c++/9/bits/unique_ptr.h:81:2: error: ‘virtual fbxsdk::FbxManager::~FbxManager()’ is protected within this context
   81 |  delete __ptr;
      |  ^~~~~~

I can solve by modifing the headers and setting protected to public, is there another way?
2: I have a static method, used as constructor for the FbxIOSettings class, with this signature:
static Class* Create(FbxManager* pManager, const char* pName);
How can I declare it to be used in rust? I converted the pManager argument as a UniquePtr, what about the pName, which is a const char* in C++?
Thanks,
Frank

I'm glad that the linkage issue got solved!
The protected destructor issue seems unrelated so I would appreciate if you could open a separate issue with a minimal repro — that can reproduce the same build error without needing the whole fbx library involved. Hopefully you can write your own small dummy types with protected destructor for the repro to use.
On the Create question: this would be appropriate for Stack Overflow or any of the resources shown in https://www.rust-lang.org/community.