Prerequisites don't explain how to resolve issues

I'm wanting to setup the Inventory Visibility provider, the prerequisites say I should have a "Datasource - IOM" but I don't.  I can create one but it would have no Dimensions or Physical Measures and the prerequisites don't explain what they should be.  When should this data source have been created?
Also, the "Intelligent Order Management Mappings" section only says which sections should be on the page not how they should be configured (my config is empty).  Should I copy the screenshot or something else?
Thanks

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 33be77bc-5427-526c-1162-a800ef671209
Version Independent ID: 33be77bc-5427-526c-1162-a800ef671209
Content: Set up Inventory Visibility provider
Content Source: topics/set-up-inventory-visibility-provider.md
Service: dynamics-365-intelligent-order-management
GitHub Login: @SUMANIC
Microsoft Alias: sumanic

Reached out to content author for guidance.


Comparison of preprocessing results

Script comparing results from original and preprocessed document.

I didn't know where to put the script, so made it 01-03, but could probably be a part of 02-01.
We could also think about removing certain words, such as "odstavek" and "zakon". These are usually not a part of structural sentences, but hint at legal speak.
Should we remove everything in parenthesis?

It sure must be 02_something. Maybe it can be 02_02 and we rename other notebooks.
I agree with you
Probably there is no important text in parenthesis but I am not sure about that. Maybe we can decide about that when we will use it in practice (predicting, document map) and test what works better.

Here is my suggestions for renaming the scripts. 03 is visualizations, 04 is extracting interesting words.
I've added stopwords and scripts in #17.
Will do it at a later point if necessary.


Develop

replace resistance and resurgence tags

Tag changes have been made to develop; we're not ready to update the main / published version yet, so I'm going to close this without merging.


TV lighting setup

Create a set up with LED strips and a PI to allow Aurora to be used in the living room (or behind a monitor, or under the desk, or wherever a user places led strips). The project will need:

[ ] Assemble the PI setup
[ ] Create Device Script for PI connectivity
[ ] Automatically detect when PI device should be turned on (for my purposes, only when steam is in big picture)
[ ] Film the thing

Converted into a project.


Add JourneyCardState

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#228  👈
#227
#226
#225
#223
#222
#221
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite


Upgrade macOS target to 12.0

Summary
macOS 11 has been 7 months, and it seems like it's common to publish ARM-only wheels at 12.0+. I think this is a better default for ARM macs.
Closes https://github.com/astral-sh/uv/issues/3227.
Test Plan
cargo run pip install scikit-learn==1.3.2 --python-platform macos --no-build

I think this is better as a default. I'm going to enable the API to accept arbitrary macOS and manylinux versions too.


t2 wifi fails if not connected to wifi

I ran t2 wifi just to verify that my Tessel was not connected to wifi and I got this error:
➜  t2-cli git:(master) t2 wifi
INFO Looking for your Tessel...
INFO Connected to Tessel-02A30958C11A.
ERR! Error: Command failed: Not found

To reproduce, just disconnect your Tessel from wifi (t2 wifi --off) and then run t2 wifi.

Clarification: it actually throws that error for any wifi command. For example, if I run t2 wifi --off and then t2 wifi -n SSID -p PASS, it will throw that same error and then successfully connect to the network.

Maybe @rwaldron's latest PR, #610, will help with this. Will try it out during my smoke test tonight.

@HipsterBrown I was able to repro on master and Rick's branch for #610 (encountered when I was smoke testing) so I think it's unrelated.

@johnnyman727 OK. Will investigate as a separate issue then.

What is the expected output of t2 wifi after t2 wifi --off?
I've fixed the issue where enabling a wifi connection, either through t2 wifi --on or t2 wifi -n SSID -p PASS, would return ERR! Error: Command failed: Not found even though the network would successfully connect. I'm still running into that same error with t2 wifi but I think it's the expected output since the wifi-iface is disabled.

I think at some point, we'll want to intercept the Command failed: Not found error and turn it into something that's more understandable for the consumer. Something like "Tessel is not connected to a network." would be a more reasonable message to spew out.


Adding BOTC wiki and dutchnews.nl

I don't know if these are absolute top tier traffic sites, but they are public reference sites meant for general consumption by interested audiences.


Missing windows-icons Dependency

Hi,
First of all, thank you for for this little projet! I'm trying to set up the software following the instructions provided in the README. However, I've encountered an issue related to a missing dependency.
When I run pnpm tauri dev, I receive the following error:

error: failed to get windows-icons as a dependency of package holdem v0.1.0 (C:\Users\nmx\Documents\holdem\src-tauri)
Caused by:
failed to load source for dependency windows-icons
Caused by:
Unable to update C:\Users\nmx\Documents\windows-icons
Caused by:
failed to read C:\Users\nmx\Documents\windows-icons\Cargo.toml
Caused by:
The system cannot find the path specified. (os error 3)

It seems that there is a reference to a local path for the windows-icons dependency in the Cargo.toml file:

toml
windows-icons = "0.1.1"
windows-icons = { path = "../../windows-icons" }

I couldn't find any information about this dependency or where it should be sourced from.
Could you please provide guidance on how to resolve this issue? Is there a specific repository or location where I can obtain this dependency?
Thank you for your assistance!

Apologies for this, You could use windows-icons "0.1.1".
I'm currently working on some changes, You'll soon be able to download the exe and installer directly.


Generate RPM files in addition to Debian files for mesh expansion

Describe the feature request
Currently, only Debian files are provided to be used on a VM for mesh expansion, see
https://istio.io/docs/examples/mesh-expansion/multi-network/#setting-up-the-vm.
For RHEL, RPM files are required.
Describe alternatives you've considered
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[X ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Additional context

duplicate of https://github.com/istio/istio/issues/9117 ?

@jwendell you are right, it is a duplicate, closing the issue.


docs: write new component to centralize component demos

Currently each demo HTML file is responsible for reproducing the demo template (from accordion):

      {{ accordionDocs.title }}

      <ngb-tabset>
        <ngb-tab title="typescript">
          <template ngbTabContent>

          </template>
        </ngb-tab>
        <ngb-tab title="html">
          <template ngbTabContent>

          </template>
        </ngb-tab>
      </ngb-tabset>

      <ngbd-accordion-basic></ngbd-accordion-basic>

Most of this can be put into a new component.  What will need to be parameterized are the following:

[ ] Card Title
[ ] Plunker Link
[ ] Demo TS Content
[ ] Demo HTML Content
[ ] Demo Directive - This may prove to be the trickiest as I don't know if there's a way to insert a directive into a component.  This has been discussed but I'm not sure if there's been a resolution.

@icfantv I think that this is done now since we've got https://github.com/ng-bootstrap/core/tree/master/demo/src/app/components/shared/example-box. If there are sill things missing let's open more focused issues.

@pkozlowski-opensource yep, this is done.  thanks.


Feature : Create Documentation  for the engine

Hello ✋🏻  Hazel  !
i want just to suggest that its will be a great idea to make a documentation for the engine
it will be very useful ! 😄
Thanks.
Greetings.

@cxgslegend and I started working on a community driven wiki TheChernoCommunity/HazelWiki over at thechernocommunity.github.io/HazelWiki/. It just requires content, so feel free to contribute!

Oh interesting!
But it would be good if the side menu was fixed(sticky) because it is difficult to open it every time 👀

it is sticky if your screen is wide enough

What i mean is, it should show up all the time and not hidden (dont make it as a hidden menu)
https://imgur.com/a/93HfcaR

Well IMO this is too early to add documentation for how to use the engine, we need to develop it further and some things might change in the future. I don't think anyone would like to repeatedly edit the documentations everytime a feature is changed, so we should add documentations once the engine is actually capable of making something decent enough that anyone would want to use it.


Displaying expected and actual values

Hello. It would be nice if there was a neat, compact way of being able to print the expected and actual values in a font color in keeping with the rest of the printed output. Maybe it can already be done but it's beyond my skill level if it is!

Okay. I've made a close approximation of what I want which will do for now.
func TestStatsVector(t *testing.T) {
	var v StatsVector
	v = populateVector(v)
	var expected string
	var actual string

	g := goblin.Goblin(t)

	actual = fmt.Sprintf("%10.4f", v.Sum())
	expected = "26770.4503"
	g.Describe("Sum", func() {
		g.It("Should provide the sum of the constituent elements", func() {
			fmt.Print(MakeGray("      Expected: " + expected))
			fmt.Println(MakeGray("  Actual: " + actual))
			g.Assert(actual).Equal(expected)
		})
	})
}

func MakeGray(s string) string {
	return "\033[90m" + s + "\033[0m"
}

This code will not run as it is but it should demonstrate what I have done

Hey @carlca I'd really love this feature, but I don't have time ATM to implement it. If you want to level up and take a  shot with a PR I'll try to help in whatever I can to implement it.

Hi Marcos, I assume by PR you mean Pull Request (I'm new to the mysteries of Git!) and make changes that could be released as part of Goblin. Yeah, I'd be up for that. I'll need a bit of guidance on exactly what git commands to use and when to use them. Thanks in advance, Carl.


[DTLS] allow providing custom certificates

Hey! I'm building a webrtc server for Parity's light client called smoldot (https://github.com/paritytech/smoldot). The server's identity is fixed, meaning server's certificate does not change.
In the current API, one can provide a certificate, BUT there seems to be no way to actually "load" existing certificate (from pem) because
pub struct RTCCertificate {
    pub(crate) certificate: dtls::crypto::Certificate,
    pub(crate) stats_id: String,
    pub(crate) x509_cert: rcgen::Certificate,
    pub(crate) expires: SystemTime,
}

rcgen::Certificate can only be used for generating new certificates (no way to construct an existing one). Am I missing something? Thanks
Maybe we can replace x509_cert rcgen::Certificate with pem string? I don't think it's used for anything other than serialising certificate to pem. See https://github.com/melekes/webrtc/commit/04acecb68ccb813ca7caf4e30fc3affb6314e834 What do you think?

opened https://github.com/webrtc-rs/webrtc/pull/204


YPbPr

I have never owned a PC Engine before.  My Turbonanza just arrived, and I have been looking over board schematics for the PC Engine.
As I am looking, it appears that the YUV circuitry is wholesale independent of the RGB stuff, which is weird.  I get that it processes in the altered palette before generating composite and feeding that to the RF out, and that you are tapping that circuitry to generate s-video.  So far, so good.
What I can't help but notice is that since you did s-video already, we already have a good luma (Y) signal, and I see Y-Red and Y-Blue already coming off of the video chip.
That leaves me to wonder the level of difficulty required to attenuate those two signals to match your luma.  Obviously that means the Saturn din couldn't hold them, but in the past I have used TRRS jack and have a stack of TRRS to RCA in RGB colors that would work.
That should then theoretically provide a "perfect" picture with the correct color palette, and those wanting RGB could use a low-cost YPbPr to RGB transcoder.
Am I misunderstanding?

Hi Tony,
The issue with the "B-Y" and "R-Y" signals coming from the Hu6260 is that
they are already modulated with the NTSC subcarrier and would require some
more advanced circuitry to demodulate those signals to potentially be
something usable. Unfortunately, my knowledge of this process only pertains
to RF systems and I've never built a "low" frequency demodulation system
like this, so I would need to do more research into what it entails.
Zack
On Wed, Aug 2, 2023 at 7:08 AM Tony Shadwick @.***>
wrote:

I have never owned a PC Engine before. My Turbonanza just arrived, and I
have been looking over board schematics for the PC Engine.
As I am looking, it appears that the YUV circuitry is wholesale
independent of the RGB stuff, which is weird. I get that it processes in
the altered palette before generating composite and feeding that to the RF
out, and that you are tapping that circuitry to generate s-video. So far,
so good.
What I can't help but notice is that since you did s-video already, we
already have a good luma (Y) signal, and I see Y-Red and Y-Blue already
coming off of the video chip.
That leaves me to wonder the level of difficulty required to attenuate
those two signals to match your luma. Obviously that means the Saturn din
couldn't hold them, but in the past I have used TRRS jack and have a stack
of TRRS to RCA in RGB colors that would work.
That should then theoretically provide a "perfect" picture with the
correct color palette, and those wanting RGB could use a low-cost YPbPr to
RGB transcoder.
Am I misunderstanding?
—
Reply to this email directly, view it on GitHub
https://github.com/zaxour/TurboNanza/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU7A2VJGVP2YTUGQEOZIWC3XTJGNTANCNFSM6AAAAAA3BIBRK4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I am completely unfamiliar with subcarriers, so I tried to do some reading.
I am unclear that the subcarrier would prevent it from working.  I mean, it would be present in the video signal anyway, would it not?

Tony,
The issue is that the B-Y and R-Y components are frequency modulated with
the NTSC carrier, so you couldn't just send the signal through an amplifier
and hope to have something usable on the output. You can see an example
here: https://imgur.com/a/PBCK0YF
It needs more complex demodulation to get it back to the original 15 kHz
bandwidth signal that we normally use for 240p/480i video signals.
Zack
On Sun, Aug 6, 2023 at 9:55 AM Tony Shadwick @.***>
wrote:

I am completely unfamiliar with subcarriers, so I tried to do some reading.
I am unclear that the subcarrier would prevent it from working. I mean, it
would be present in the video signal anyway, would it not?
—
Reply to this email directly, view it on GitHub
https://github.com/zaxour/TurboNanza/issues/3#issuecomment-1666903568,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU7A2VKOETFAPFV3QOFFLALXT6453ANCNFSM6AAAAAA3BIBRK4
.
You are receiving this because you commented.Message ID:
@.***>

Ah, so it is a 59.94 Hz signal as opposed to 15 kHz?

59.94 Hz is the vertical sync frequency, 15 kHz is the horizontal sync. The whole signal frequency modulates the 3.84MHz NTSC carrier (constant amplitude, varying phase) to produce the signal.
Zack
On Aug 6, 2023 at 15:22 -0600, Tony Shadwick @.***>, wrote:

Ah, so it is a 59.94 Hz signal as opposed to 15 kHz?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Thank you again for humoring me.  Documentation on this is tricky to come by.

Leaving this to look at later, as I am unsure a microprocessor could do this fast enough.
https://batchdrake.github.io/ntsc-iii/


Many errors in the log as of 1.20.1

What happened?
I'm making a modpack and while checking the log, I've noticed many errors from recipes and GLM
These are the errors: https://gist.github.com/Insane96/d11a3b25bb7d830967d81fc28e7e7d18
The first one is due to changes to loot tables, iirc alternatives has been changed to "any_of" or something similar. https://gist.github.com/ChampionAsh5357/cf818acc53ffea6f4387fe28c2977d56#or-and-and-composite-lootitemconditions
The others are just missing the items.
This is the full log: https://gist.github.com/Insane96/36332cd1a2ef44cc11991fa90c9e7e58
Mod Version
1.1.0
Minecraft Version
1.20.1
Relevant log output
No response

Thanks, I will update the loot table operator. Not sure if anything about the missing item warnings can be done, but they also don't break anything, just clutter the log which is a bit annoying

For the recipes you can use conditional loading:
https://github.com/Insane96/SurvivalReimagined/blob/1.20.x/src/generated/resources/data/survivalreimagined/recipes/flint_from_gravel.json

I don't think there are any recipe errors, since these are already only injected if the mod is present. For the loot tables I unfortunately can't do anything


Copy the golangci-lint setup from Submariner

... disabling failing tests for now.
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

Didn't realize we were missing this here, good catch. :exploding_head:


Fix wrong displayed category name in EditorHelpSearch

The last two parameters of _create_category_item() are passed in the opposite order in actual use, so the dialog currently displays methods (metadata) instead of Methods (text). This PR swaps the two parameters.
Also fixed two typos related to the "Properties" category.

Thanks!


Voting on Gennlife as an organization member

Gennlife (Beijing) Technology Co.,Ltd.
Gennlife has passed the preliminary review and completed the assessment. TSC board members are requested to vote based on the assessment result, either "agree" or "disagree."
If more than half of the votes are favored, Gennlife will officially become a FATE community organization member.

agree

agree

agree， from WeBank


⚠ ClamAV has degraded performance

In 17f1b74, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 72 ms

Resolved: ClamAV performance has improved in 178df9a after 5 minutes.


ECPC change

Fixes #92
See email on all the changes. Below a copy of that email:
I’m looking at the temporal allocation of Equal Cumulative Per Capita (ECPC).
There were some issues with the current way we did it. It’s not technically wrong, but a bit ad-hoc and can simply be done better. How we did it: starting with a GF allocation, a deviation from the GF allocation was determined. This deviation was of a square-root functional form and the area under this deviation + the GF curve is exactly the ECPC budget.

it used GF as a basis, which induced mere flattening for countries that get a lot of budget -> no ‘bell-shape’ emission curves for countries that still need to peak.
ECPC budgets were only met at the very end of the century, so that during the century, in fact ECPC was never met and all allocations are not fully fair.
In the near-term, countries with negative ECPC budgets were not penalized much, mostly the post-2050 negative allocations would make sure the ECPC budget was met. This is of course not productive when talking about 2030 and 2040 allocations (especially if their ECPC budget is in fact negative, e.g. for NLD).

I’m proposing a new version, with these characteristics:

A convergence year parameter (e.g., 2050) that makes sure that ECPC budgets are met by that year. Rather than necessarily 2100. If this convergence year is quite soon (e.g. 2040/2050), the emissions for certain countries (e.g., Rwanda) blows up in the near-term to approx. 20x its current emissions. This is of course simply the result of inequality in light of responsibility.
From the convergence year and on, per capita shares are used -> this makes sure the ECPC budget (albeit updated with post-convergence year emissions) is always met afterwards
[This is a major choice] I think it is nice to by the convergence year itself, the allocations convergence to a per-capita allocation. This does mean that allocations for e.g. NLD or USA go first very negative, and afterwards less negative: i.e., their allocations start increasing, which is counterintuitive -> see USA + India plots at the bottom of this email. USA goes up a lot again, with a dramatic change between 2030 and 2040 when having a short-term convergence year (e.g., 2050).
In practice this means that a PCC graph is underlying the calculations (rather than the GF as previously). And because we want to harmonize to current allocations at the start, and at the per capita point in the convergence year, I’m using a sine function (half-period).
Potentially we can also propose a discontinuity or another extension method than per capita, but I think this is the cleanest / best explainable if we want to remain continuous. We can add discontinuous rules later, potentially as a slider in the new Explorer version (see also Yann’s paper on this issue).

You will also see in the input.yml and in class_datareader/allocation that I now added 'dimension_ranges' as settings in the yaml to centralize how we deal with all parameter ranges. I also changed some of them slightly, to preserve memory space (which explodes with the new ECPC).

Please therefore also rerun the datareader. A single run of the allocator (for one country) takes approximately 2 minutes on my Azure.

@chantalwuer I went through your comments, thanks! I committed it. Could you have a final look and merge?


Please add an option for group.instance.id support

Hi
Kafka static membership is a new feature introduced with Kafka 2.3. It allows the coordinator to persist member identities and to recognize restarted members. This is possible via the consumer configuration group.instance.id. If a consumer restarts for any reason, the group coordinator can assign the same partitions to the consumer without rebalancing everything.
Can we add this very useful option to the Kafka Input Plugin for Logstash?
Thanks in advance!

Thanks for the collaboration and adding this!
(Introduced by Kafka https://cwiki.apache.org/confluence/display/KAFKA/KIP-345%3A+Introduce+static+membership+protocol+to+reduce+consumer+rebalances)


The behavior of the RequiredRuleInferrer is confusing

✏ Describe the bug
If you make a property of a Data of type bool, then the Required auto rule will not be applied to it.
↪ To Reproduce
use Illuminate\Validation\ValidationException;
use Spatie\LaravelData\Attributes\Validation\Required;
use Spatie\LaravelData\Data;
use Spatie\LaravelData\Exceptions\CannotCreateData;

it('successfully validated', function () {
    class SomeData1 extends Data
    {
        public function __construct(
            public string $just_string,
            public bool $i_am_bool,
        ) {
        }
    }

    $payload = ['just_string' => fake()->text()];
    $validated = SomeData1::validate($payload);
    expect($validated['just_string'])->toEqual($payload['just_string']);
});

it('validated, but not created', function () {
    class SomeData2 extends Data
    {
        public function __construct(
            public string $just_string,
            public bool $i_am_bool,
        ) {
        }
    }

    SomeData2::validateAndCreate(['just_string' => fake()->text()]);
})->throws(CannotCreateData::class);

it('fail validation', function () {
    class SomeData3 extends Data
    {
        public function __construct(
            public string $just_string,
            #[Required]
            public bool $i_am_bool,
        ) {
        }
    }

    SomeData3::validateAndCreate(['just_string' => fake()->text()]);
})->throws(ValidationException::class);

✅ Expected behavior
I expect that I won't have to manually add the Required attribute
🖥 Versions
Laravel: 10.46.0
Laravel Data: 4.2.0
PHP: 8.3.1

The problem is here
https://github.com/spatie/laravel-data/blob/6e20d6f191b4260e64738bd299d2aa50dae42297/src/RuleInferrers/RequiredRuleInferrer.php#L38-L40

Yeah this has always been like this and has to do with checkboxes, they do not send a value when not being checked and thus validation would fail since the key is missing.
That being said,  the behavior looks weird after all those years. Data isn't a request to data solution anymore, we're powering event sourcing objects with it, not even using a request in between. These days when using Inertia with react/vue, the boolean fields will be present from the start so I agree that this change we've made in the past now feels weird.
The problem is, that just adding the required rule is a massive breaking change since a lot of validation which was previously not throwing error will do now.
Since this is in a RuleInferrer, we could implement a new one combing all RuleInferrers like I suggested in #647, you could than manually use this rule inferrer and remove the other ones. in v5 this could become the default rule inferrer.
The problem, I'm currently working on typescript-transformer 3 and do not want to spend too much time on data (if that's even possible). So it will have to wait or someone should send in a well tested PR.

Another one that seems not to spec is a required array type throws validation error when the array is empty, which is a perfectly acceptable array. If someone needs there to be a minimum amount of elements in the array, they can add Min rule.
class ItemTask extends Data {
  public function __construct(
          public readonly string $task,
          public readonly array $data,
  ) {}
}

ItemTask::validateAndCreate(['task' => 'lmao', 'data' => []]);
// Illuminate\Validation\ValidationException  The data field is required.

I understand, I'm suggesting that the inferred rule should maybe rather be present than required for arrays, since it would be madness to make it nullable if i also accept an empty array. Can't fix it with an annotation either, would have to override the rules in this case to have the class types correspond to what is needed.
public static function rules(ValidationContext $context): array
{
    return ['data' => 'present|array'];
}

I don't want to change how the default behaviour works in Laravel, making a property non nullable makes a property required in data. Even if it is an array.
Adding an annotation is working as far as I'm aware:
it('bla', function (){
    $data = new class  extends Data
    {
        #[Present]
        public array $array;
    };

    dd($data::getValidationRules(['array' => []]), $data::getValidationRules([]));
});

array:1 [
  "array" => array:2 [
    0 => "array"
    1 => "present"
  ]
] // /Users/ruben/Spatie/laravel-data/tests/DataTest.php:138
array:1 [
  "array" => array:2 [
    0 => "array"
    1 => "present"
  ]
] // /Users/ruben/Spatie/laravel-data/tests/DataTest.php:138


fixes #551, MockDirectory.Move should throw when target cannot be parsed

Based on .NET source, the Directory.Move method PInvokes Win32 MoveFileExW (tested on net 472), which has certain rules for what path shapes it can tolerate.  I wrote a comparable C# method that matched the cases I could think to test, confirming the behavior against System.IO behavior.

Thanks for all your contributions!

This appears to cause a bug. MockFileSystem.Directory.Move no longer works with paths with more than one element.
Reproduction:
`            var mockFileSystem = new MockFileSystem();
mockFileSystem.AddDirectory(@"C:\Foo\Bar");
        mockFileSystem.Directory.Move(@"C:\Foo\Bar", @"C:\Foo\Baz");`

This produces:
System.IO.DirectoryNotFoundException : Could not find a part of the path.
at System.IO.Abstractions.TestingHelpers.MockDirectory.Move(String sourceDirName, String destDirName)

This appears to cause a bug. MockFileSystem.Directory.Move no longer works with paths with more than one element.
Reproduction:
var mockFileSystem = new MockFileSystem();
mockFileSystem.AddDirectory(@"C:\Foo\Bar");

mockFileSystem.Directory.Move(@"C:\Foo\Bar", @"C:\Foo\Baz");

This produces:
System.IO.DirectoryNotFoundException : Could not find a part of the path.
at System.IO.Abstractions.TestingHelpers.MockDirectory.Move(String sourceDirName, String destDirName)

Sorry for the trouble. I'll revert this PR to get out a fixed version asap.
@pianomanjh Could you take a look at the problem and re-apply this PR once you fixed it?

@IvoMiller This change is reverted in https://www.nuget.org/packages/System.IO.Abstractions/10.0.8

@fgreinacher Thank you very much. I can confirm this solved the issue.

Thank you @IvoMiller, with my apologies.  I'll take a look tonight at what I've missed there, and be sure to get test cases in accordingly.

Hi there @IvoMiller @fgreinacher , I've had a chance to look at this, and the newly implemented behavior is correct.  The behavior change, in response to the bug, was to match MockFileSystem behavior to actual Filesystem behavior.
Your repro above:
var mockFileSystem = new MockFileSystem();
mockFileSystem.AddDirectory(@"C:\Foo\Bar");

mockFileSystem.Directory.Move(@"C:\Foo\Bar", @"C:\Foo\Baz");

fails on a real file system with a DirectoryNotFoundException.
Let me know if you agree this PR should be re-merged.

I don’t get why this code should fail. This move operation is merely a rename that in my opinion is totally valid.

I couldn't agree more, but I doubt you'll get the Windows team to fix their kernel. :)  If the expectation is that the tests are accurate with respect to the OS behavior, then the change is warranted.  Feel free to double-check me against the file system you are using.  (I've only tested on Windows 10 19592, and Ubuntu 18.04.)

my apologies @fgreinacher I did not make an additional commit with the major version bump.  Do we want to do that?

I just opened #579 to reproduce the behavior.


add proper logging to the API

especially there should be a log of the requests to the Triplestore

backend is hooked to sentry


Accept should be public function of the Contract

I think accept should be a member of the Contract, and should take the saleOfferResourceID and the address as additional parameters.
that way if everyone will have single storefront:

it forces a single instance of StoreFront on Path set by contract (also I think we can check path when listing, and not list if it is not on the correct public path, prevents ghost offers)
we can clean up sale offers after they are accepted. (no need for cleanup also accepted field will not be necessary)
we can emit events on the hostile sellers. (remove listings on the first failed attempt when NFT is not listed anymore ( OfferGoneAway(saleOfferResourceID) ) or cannot reach StoreFront (such as StoreGoneAway(address) )

Those events will be useful, if there will be some dapps showing listing etc, so they can remove users or listings from their DBs

Isn't that always going to be an issue in the way NFTs work on Flow? Any project derived from standard NFT can be sold on a Third-Party marketplace as long as the actual NFT is not "locked" inside the contract or any of their "saleOffer" resources directly...? So e.g. someone has a listing on CM marketplace and on VIV3 - one of the two - in the current design - will run into an issue if sold on one of them. (not an issue for CM right now due to current wallet garden design)
I believe therefore a marketplace needs to figure out a solution that works for all use-cases and I don't believe it is therefore required in this contract 🤔

@CineTek Problem is mainly ghost listing, if you have on viv3 some legendary item for 1 FLOW, if someone tries to buy it, and fails, the contract has to clean this listing normally, and emit an event. But currently to cleanup, you need to call a method, and you can only clean up sold items.

Yeah sorry I deleted my comment, I misread the situation in the contract😬


ROX-21477: Update "scope" field to handle sha based image tags

Description
Handles the display of exception scope field, when the "just for this image tag" option is selected for an image that does not have an explicit tag, but is referenced by hash.
This isn't fully supported by the backend, and is effectively the same as choosing "all tags", so this is displayed as a wildcard as well.
In addition, this removes the "just for this image tag" option from the form UI when the image in scope does not have a tag.
Note - this is easier to review with "hide whitespace" on.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Create an exception at:

global scope
image scope for an image with no tag (gke.gcr.io/fluent-bit)
single tag scope for an image with no tag (gke.gcr.io/fluent-bit)
image scope for an image with a tag
single tag scope for an image with a tag

Visit an image with a tag and open the exception form:

Visit an image without a tag and open the exception form:

This change is causing a legitimate break in e2e tests due to the non-determinism of what images are available in CI. I added the do-not-merge label until I push a workaround.

/retest


Does a Migrate from 2008R2 to 2016/2019 require the multiple steps?

It says that in-place upgrades need multiple steps ... But what about a Migrate?
This is especially relevant to SBS2011 servers as that can't be upgraded in-place.
Not easy to plan the upgrade before end-of-life without info like this

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88d8e06f-1416-57d1-84b9-fd82d217a481
Version Independent ID: 9047ff8c-95f0-ffea-38d6-9a6d6c56e383
Content: Windows Server Installation and Upgrade
Content Source: WindowsServerDocs/get-started/Installation-and-Upgrade.md
Product: windows-server
Technology: server-general
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Issues/issue 51 reproduce

Just a way to reproduce vimeo-unity-sdk's issue #51 by adding another JSON package. Not to be merged to master, except last commit that can be cherry-picked. Last commit is a suggested fix: not using the overloaded JSON symbol, which is not really necessary in the case of the SimpleJSON library used by Vimeo/Unity SDK.

#65 resolved this


Promisify

Since the Mineflayer codebase officially has Promise support, all Mineflayer plugins should also start moving in that direction.

done, close pls


Added flagSize parameter to control the size of the country flag

I used this package in a Flutter web project. Regarding responsiveness, this doesn't provide a way to control the size of flag.  So I ended up with the idea of adding a parameter (flagSize) to control the size of the flag. It's just a minor change in two lines with an addition of two lines.

use intl_mobile_field package

Check the README. This package is not longer maintained so your pull request won't be reviewed or merged anymore.


I can't send people messages

Subject: I can't send people messages
Description:
A pop up says that I can't send messages because I have an empty profile but I have it with pictures and description and still I can't... Help me
Results:
Backend version: develop-1dbd5d77
Frontend version: develop-1dbd5d77
User Agent: Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36
Page: https://couchers.org/user/tcw101
User: @alejandraeo (49297)

Dupe #5050


Can you re-publish this to npm?

I'd like to be able to use the latest version of this package in npm. Can you update please?
Thanks!

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Re-published as 0.6.3. Cheers! :smile:

What is the package name?  There is no package.json in this repo's root.

Right, the package.json is generated on-the-fly via the Makefile.
The correct npm package name is rot-js.

Thanks @ondras!


Add stable-diffusion model wrapper

name: Pull Request
about: Create a pull request
Description
add stable-diffusion model wrapper
Integrate https://github.com/AUTOMATIC1111/stable-diffusion-webui
Checklist
Please check the following items before code is ready to be reviewed.

[x]  Code has passed all tests
[x]  Docstrings have been added/updated in Google Style
[ ]  Documentation has been updated
[x]  Code is ready for review

I've made some updates to the PR:

Replaced the custom request with the third-party package webuiapi. Let me know if this is suitable for the project or if you prefer a different approach.
I've wrapped the SD model as a callable agent service (similar to 'dashscope_services'), as I realized that directly conversing with the text2img model was not a good idea. But the dialogue agent for direct conversation with the SD model is still available and can be modified based on your feedback.


Weird behaviour with RefreshIndicator and Streams

You can check the complete code here: https://github.com/JavierSegoviaCordoba/bloc_example
When you open the app you can see the snackbar is appearing multiple times. if you pull to refresh without really refreshing, just to see the refresh indicator circle, the snackbar appears.

Hi @JavierSegoviaCordoba , can you share more information about your env with output of flutter doctor -v?

@andrijasinski tomorrow I will send you the info, btw everybody which compile my repo will get the same result. Have you tried it?

I am only using Android Studio for Flutter Development.
flutter doctor -v

[✓] Flutter (Channel stable, v1.7.8+hotfix.4, on Mac OS X 10.14.6 18G87, locale en-ES)
    • Flutter version 1.7.8+hotfix.4 at /Users/javiersegoviacordoba/Development/sdk/flutter
    • Framework revision 20e59316b8 (6 weeks ago), 2019-07-18 20:04:33 -0700
    • Engine revision fee001c93f
    • Dart version 2.4.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/javiersegoviacordoba/Development/sdk/android
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/javiersegoviacordoba/Development/sdk/android
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.3, Build version 10G8
    • CocoaPods version 1.7.5

[✓] iOS tools - develop for iOS devices
    • ios-deploy 1.9.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 38.2.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[!] VS Code (version 1.37.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

Some updates about it?

Up

The solution was pretty simple, I was wrapping the widgets in the following way: RefreshIndicator(StreamBuilder), if I revert that to StreamBuilder(RefreshIndicator), the problem is solved.


google speech api access credentials need

I am using following piece of code to recognize audio using speech_recognition. I am successfully able to convert the audio to text but looks like this uses google speech API internally which require some user credentials perhaps(key etc.). I did not have to supply any credentials to this code in order to convert, how and which credentials are used to access this API  and would there be any limitation in terms of number of conversions per day? Please help with the details.
import speech_recognition as sr

r = sr.Recognizer()
audio_file = sr.AudioFile('path_to_recorded_audio')

with audio_file as source:
    audio_file_record = r.record(source, offset=10)

print(r.recognize_google(audio_file_record, language='en-US'))

System information
(Delete all the statements that don't apply.)
My system is Windows 10 x64
My Python version is 3.6
My Pip version is 3
My SpeechRecognition library version is 3.8.1

still the error?


[BEAM-6056] Migrate gRPC to use org.apache.beam.vendor.grpc.v1_13_1 as the package prefix

This is towards meeting the goals of<EMAIL_ADDRESS>
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.


Release v0.9.2

Bump codeclimate-poseidon to 0.0.12 (details)

This version bump isn't needed right now.
gem "codeclimate-kafka", "~> 0.9.1"
gem "codeclimate-poseidon", "~> 0.0.12"


US Embassy

Hi can I use it for USA embassy

Hi @amirghavipanjeh ,
It currently only supports VFS appointments for India-Germany and Iraq-Germany. We are currently working on adding support for more countries. We will update once it's added.


release: update manifest and helm charts for v1.1.0

Signed-off-by: Anish Ramasekar<EMAIL_ADDRESS>
Reason for Change:

Requirements

[ ] squashed commits
[ ] included documentation
[ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

[ ] Yes
[ ] No

If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:

/azp run pr-e2e-azure


[FEATURE]: Script - gaming featues

Description
Add flags for game launchers, utilities, and more

Depends on issues #10 #12

added games

[x] Minecraft
More comming soon...


fix: resolve issue with logo click not redirecting to home

closes #74
This PR addresses a bug where clicking the app logo did not correctly redirect to the home page. The issue has been identified and fixed. Now, when users click the logo, it successfully redirects to the home page.

Hi @eddiejaoude updated this PR with the link tag and removed the previous changes.

Hi @j-grosse  thanks for the review , I have now deleted the unnecessary "useRouter" and updated this PR.


feat: Force users to change their passwords after three months

issue3330
The interval between forcing users to change their passwords is temporarily set at three months, and the configuration method is to be developed

Replaced by: https://github.com/casdoor/casdoor/pull/3352


v1: record() attribute parsing throws error due to unescaped input to ^\\. RegExp

@ThomasAribart Hello again! I've got another weird/unexpected edge case for you.
I'm introducing an entity for existing data that stores a nested record of Expo push notifications. Expo push notifications have the following format: ExponentPushToken[6mNTFFQ-muzshhHQJ7FJ1n], which will be important in just a second. Here's an abridged example of the entity I've created for this purpose:
export const FooEntity = new Entity({
  table,
  name: 'Foo',
  schema: schema({
    notifications: record(
      string(),
      map({
        type: string().required().enum('expo', 'apns', 'fcm'),
        token: string().required(),
        issued: number().required(),
        meta: any(),
      })
    ),
  })
})

When attempting to query this entity, a runtime error occurs because the record attribute parser attempts to construct a RegExp with the unsanitized raw value of the attribute (the Expo push token) on this line of code:
{
    "exception": true,
    "message": "Invalid regular expression: /^\\.ExponentPushToken[6mNTFFQ-muzshhHQJ7FJ1n]/: Range out of order in character class",
    "name": "SyntaxError",
    "stack": [
      "SyntaxError: Invalid regular expression: /^\\.ExponentPushToken[6mNTFFQ-muzshhHQJ7FJ1n]/: Range out of order in character class",
      "    at new RegExp (<anonymous>)",
      "    at <redacted>/node_modules/dynamodb-toolbox/dist/cjs/schema/actions/format/record.js:25:72",
      "    at Array.forEach (<anonymous>)",
      "    at formatRecordAttrRawValue (<redacted>/node_modules/dynamodb-toolbox/dist/cjs/schema/actions/format/record.js:22:30)",
      "    at formatAttrRawValue (<redacted>/node_modules/dynamodb-toolbox/dist/cjs/schema/actions/format/attribute.js:45:61)",
      "    at <redacted>/node_modules/dynamodb-toolbox/dist/cjs/schema/actions/format/map.js:31:74",
      "    at Array.forEach (<anonymous>)",
      "    at formatMapAttrRawValue (<redacted>/node_modules/dynamodb-toolbox/dist/cjs/schema/actions/format/map.js:21:42)",
      "    at formatAttrRawValue (<redacted>/node_modules/dynamodb-toolbox/dist/cjs/schema/actions/format/attribute.js:43:55)",
      "    at <redacted>/node_modules/dynamodb-toolbox/dist/cjs/schema/actions/format/schema.js:29:74"
    ]
}

FYI for anyone experiencing this bug, this patch fixed the issue for me:
diff --git a/dist/cjs/schema/actions/format/record.js b/dist/cjs/schema/actions/format/record.js
index 647174a707c7553a21c28cd6897d8efbb226cf67..76a39a35407a0f8f73dceb1d7261ac71deccc9cc 100644
--- a/dist/cjs/schema/actions/format/record.js
+++ b/dist/cjs/schema/actions/format/record.js
@@ -21,8 +21,9 @@ const formatRecordAttrRawValue = (attribute, rawValue, { attributes, ...restOpti
     const formattedRecord = {};
     Object.entries(rawValue).forEach(([key, element]) => {
         const parsedKey = (0, primitive_js_1.formatPrimitiveAttrRawValue)(attribute.keys, key);
+        const sanitizedParsedKey = parsedKey.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")
         // We don't need isProjected: We used the saved value key so we know it is
-        const { childrenAttributes } = (0, utils_js_1.matchProjection)(new RegExp('^\\.' + parsedKey), attributes);
+        const { childrenAttributes } = (0, utils_js_1.matchProjection)(new RegExp('^\\.' + sanitizedParsedKey), attributes);
         const formattedAttribute = (0, attribute_js_1.formatAttrRawValue)(attribute.elements, element, {
             attributes: childrenAttributes,
             ...restOptions
diff --git a/dist/esm/schema/actions/format/record.js b/dist/esm/schema/actions/format/record.js
index dc395d1eef1af87235699e255432f6ff22a839ce..afe7e182456923d6d5e8ce9418b7a2794404bd5c 100644
--- a/dist/esm/schema/actions/format/record.js
+++ b/dist/esm/schema/actions/format/record.js
@@ -18,8 +18,9 @@ export const formatRecordAttrRawValue = (attribute, rawValue, { attributes, ...r
     const formattedRecord = {};
     Object.entries(rawValue).forEach(([key, element]) => {
         const parsedKey = formatPrimitiveAttrRawValue(attribute.keys, key);
+        const sanitizedParsedKey = parsedKey.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")
         // We don't need isProjected: We used the saved value key so we know it is
-        const { childrenAttributes } = matchProjection(new RegExp('^\\.' + parsedKey), attributes);
+        const { childrenAttributes } = matchProjection(new RegExp('^\\.' + sanitizedParsedKey), attributes);
         const formattedAttribute = formatAttrRawValue(attribute.elements, element, {
             attributes: childrenAttributes,
             ...restOptions

Not sure if it's the correct fix though 🤷♂. I created the patch using pnpm patch. If you're not using pnpm then patch-package works as well.

Good catch! Will have a look asap!

@tranhl I cannot reproduce the bug on my side, can you provide more details on the query you made? Did you filter attributes?

@ThomasAribart Apologies, the example string I provided wasn't reproducing the issue (I had to redact the actual Expo push notification token to protect the device). Here's a code sandbox reproducing the error on v1.8.4, hope that helps!
https://codesandbox.io/p/sandbox/wxy8nj

@tranhl should be fine in v1.10.1 !


Monorepo

Move back to a monorepo!

Closing this as there are just sooo many issues when implementing this 😞Someday!
See

https://github.com/lerna/lerna/issues/375
https://github.com/lerna/lerna/issues/1892
https://forum.vuejs.org/t/one-node-modules-folder-using-vue-cli-for-multiple-vuejs-projects/55868/3


User Dedupe Script

What does this PR do?
Adds script to remove duplicate users and adds mobile number conversion in User model to only save numbers (no spaces, -, ., etc.).
How should this be manually tested?
Run php artisan users:dedupe
@sheyd and I also tested in Thor and seems to be working correctly, except for one error (Sena will elaborate on this in comments below).
What are the relevant tickets?
Fixes #187

@chloealee If you rebase from dev you should get much more reasonable feedback from StyleCI. I can sit down with you sometime today or tomorrow to look through that if you want! :)

that would be awesome, thanks @DFurnes !

@DFurnes @blisteringherb @angaither Quick notes from the testing @chloealee and I did on Thor Northstar:

Looks like it gets through the end of all records (user records scrubbed for security):

user deleted<EMAIL_ADDRESS>555xxx555xxx5x555x55555xxxx5x5x5x
user deleted<EMAIL_ADDRESS>666xxx666xxx6x666x66666xxxx6x6x6x

This error pops up at the end:

[MongoResultException]
  mongo1:27017: exception: aggregation result exceeds maximum document size (16MB)

Before we roll into Prod on this, I'd like to do a Thor Northstar re-fresh with updated backend values (the ones in Thor are much smaller than Prod), and re-run the test. Thoughts?

yeah, let's retest!

We hit another error, this time:
 [ErrorException]
  Undefined offset: 0

I'll re-sync with @chloealee on this next week when she's back.

@sheyd did a little research and realized that I didn't need the [0] index in one of the loops. I think this triggered the [ErrorException]        Undefined offset: 0   so should be good now! Can we test again?

OMG THERE ARE SO MANY COMMITS IN HERE :scream:

soon they're be crushed along with all my little green boxes! :sob:

@angaither thanks to @jonuy 's help and refactored code, the script is now working! You have to run the script a few times until only the message Script successful. Re-run script until no users are deleted and yields only this message. If only this message, deduplication complete! is returned (with no echos of users being deleted beforehand).
I have the Jenkins jobs set up on my computer to test if you want to test together to go through - just let me know!

:+1: cool, we can get this merged, I'm not sure if we want to run it now before break or wait till next year. but awesome job with this!

@angaither added another line of code I was missing to properly switch users and make sure that the master_doc is always the original user.
Just ran it again in Thor and from the users I saw (three random emails and three random mobile numbers) it worked correctly! Now I’m just trying to find a user that was created after the original that has new fields the original didn’t to see if that merged correctly but am having trouble finding examples. I saw that it worked in tinker when creating this scenario. Is it worth it to keep looking for a real example in Thor?

:+1: from here, @DFurnes wanna take a look as well?

@DFurnes added the conditional and changed the regex to match voting app for consistency!

Looks good to me! :ship: :tada:


Implement WebSocket module for Android. Fixes #2837

The JavaScript code for Android is same as the iOS counterpart, I just added few new lines and used arrow functions instead of binding this.

Thanks for the pull request!
Please see my note about using okhttp-ws instead of org.java-websocket. Which means WebSocketModule will need to be changed as well. But the general approach seems fine.

Regarding tests, we have not opensourced those yet so we don't have a story around it. Stay tuned! (cc @mkonicek)

@foghina Thanks. looking forward to it :)

@foghina From the README on the okhttp-ws page

Note: This module's API should be considered experimental and may be subject to breaking changes in future releases.

Currently it's used to connect to Chrome debugger I think. The docs don't have anything and the API is also subject to change. Should I migrate it to use okhttp-ws ? I'm a bit skeptical.

Yes please migrate to okhttp-ws.
See how it's used here: https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/bridge/JSDebuggerWebSocketClient.java

@mkonicek Ok, I'll migrate to okhttp-ws and update the pull request accordingly.

Pull request updated. Mostly changes from https://github.com/facebook/react-native/pull/2870

I really want to share more JS between iOS and Android. My thinking is that we should merge https://github.com/facebook/react-native/pull/2599 first, to get iOS's implementation even better, and then start moving code out of WebSocket.ios.js into WebSocketBase.js till only a few lines need to be specific to iOS or Android.
@mkonicek can you do a pass over the Java code style?

@ide done.

@ide Also, the JavaScript code of both iOS and Android implementations are exactly the same. So when the pull request is merged, we can just copy/paste the code.

@satya164 If the code is exactly the same then I'm proposing that we rename WebSocket.ios.js to WebSocket.js and delete the platform-specific files.

@ide Okay, so I was looking at the implementations and noticed that the close method didn't accept any parameters as per the spec. I changed the Android code so that it now accepts a code and a reason as argument, and the code is no longer the same :(
I'll look at the pull request for iOS and see if I can do those changes in my pull request also.

Any updates on this?

@foghina @ide Would love to get this merged!

@vjeux Done.

@facebook-github-bot import

@facebook-github-bot shipit

@ide For now, we will need to have different code for Android and iOS right now, as the iOS module doesn't support the parameters on onClose.

@mkonicek It goes to 108 columns :(

Can you reduce the code duplication or see a good way to use Platform.OS to run different code around onClose?

@mkonicek Not really sure about the timeouts, but I just changed the values to match that in the JSDebugger.

@ide Okay, will do the platform check then.

Did a detailed review, just came back from a week of vacation, sorry about the delay.
Looks good! Main point are the error handling. Please remove all the empty lines in method bodies.

Thanks for working on this @satya164!
This is super useful and we're getting close to merging this!

Whoa, that's a lot :D
Hope you had a good vacation @mkonicek
I just did the changes. Please let me know if I need to fix something.

Also please squash your commits when you're done. One commit per idea (per PR ideally).

What?
On Sep 30, 2015 2:21 PM, "Satyajit Sahoo"<EMAIL_ADDRESS>wrote:

@foghina https://github.com/foghina @ide https://github.com/ide Would
love to get this merged!
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/pull/2839#issuecomment-144497903
.

Error handling looks good, see the comment about getExecutorService().shutdown() (missed this one before).

@mkonicek Here it says,
// Trigger shutdown of the dispatcher's executor so this process can exit cleanly.
 client.getDispatcher().getExecutorService().shutdown();

https://github.com/square/okhttp/blob/master/samples/guide/src/main/java/com/squareup/okhttp/recipes/WebSocketEcho.java#L32
Will do the other things shortly.

The EventTarget diff just landed in master too, so you'll pick it up if you rebase.

@ide done.

The code duplication between WebSocket.ios/android.js can be significantly reduced. There is much more copy-pasted code than the code that is different. This is a suggestion:

Either rename the native module to from WebSocketModule WebSocketManager so that it matches iOS (cc @mkonicek if you have thoughts considering the cross-platform consistency) or in JS use a platform check:

var WebSocketManager = (Platform.OS === 'android') ?
  require('NativeModules').WebSocketModule : require('NativeModules').WebSocketManager;

Abstract over close so you can internally use the same interface across both platforms:

function closeWebSocket(statusCode, reason, socketId) {
  if (Platform.OS === 'android') {
    WebSocketManager.close(statusCode, reason, socketId);
  } else {
    WebSocketManager.close(socketId);
  }
}

Now you can call it everywhere within WebSocket.js.

@ide I renamed WebSocketManager to WebSocketModule in iOS code. It's building in XCode.

The failing tests don't seem to be related.

Looking much better, thanks. @vjeux this looks correct from reading the code though you may have input on code style.

@ide License fixed.

@mkonicek Yeah it was also confusing for me. I've changed it to always call 'failled', and you're right, it makes it much easier to understand. Thanks.

I also added WebSocket under polyfills section.

@mkonicek My bad. Removed the function name.

Awesome, let's ship it :)

@facebook-github-bot shipit

I'm haven't yet tried the shipit bot on PRs where the commits haven't been squashed. Let's see what happens :)

@mkonicek probably this.

Import looks good, except it failed because Network.md doesn't exist in the fb codebase - it is github only. Can you please remove the Network.md from this PR? I can edit it directly on github once this lands. We should probably also only update the docs once this gets released (to npm and Maven Central) which is when people can start to use it.

Just send a separate PR for the docs please.

Actually let me do that.

@mkonicek I made the same changes as https://github.com/facebook/react-native/commit/626b551ff2e09f2770bac71a5d14d139f1b09226
I had to move those into separate files since we had 2 different files for iOS and Android. I believe the pull request was to provide a proper Event class. If I change the name it will be no longer be the case.
It's generic enough though, and not tied to WebSockets in any ways. So it could be used for other events also.
But if you want, I could inline them to the WebSocket.js file, so it'll not conflict with other files.

Thanks for the explanation! I think Event is fine for now. The module system we use internally at fb uses global names so the websocket Event will be available anywhere using require('Event'), that's why I was suggesting require('WebSocketEvent').

I'll work on merging this internally now, need to make some changes to the Buck build scripts we use internally to build React Native.

Still working on merging, will continue on Monday. No need to make more changes to the PR, looks good now. I'll just inline the Event into MessageEvent as Event is going to conflict with a class of the same name we have on the web.

@mkonicek Awesome. Thanks a lot :D

@mkonicek Any updates on this?

I had to update the Java files a bit, merging now..

This got delayed because it's failing some internal iOS tests. Looking.

Will have to rebase once the fb internal tests are fixed and commit then. Hang tight! Thanks for the hard work, I literally just need to get this into the internal fb repo now :)

@mkonicek Thanks a lot for keeping me updated. Much appreciated :D

No problem :)

Yay!

Awesome!

@satya164 The PR had to be split into two commits because of a technical detail of how the sync with the internal fb codebase works: Network.md lives on github only, all the other files also live in the fb codebase. Currently we have to commit these two types of changes separately.
I committed the docs for you which saves you a bit of work but makes the comit blame to me: https://github.com/facebook/react-native/commit/c819c5590bba7730728caf6b65c4f039150a216b
Let me know if you'd like to split the PR into two yourself next time and keep attribution that way.

Long term we should probably have a way to auto-split the PR, can't estimate yet how much work that would be.

@mkonicek No problem. Yeah, sure, I can do the work next time :D
This was a really small commit though, so it's alright :)


urllib.error.HTTPError: HTTP Error 401: Unauthorized

weather widget not working.

Maybe you need to get correct APPID first.

can you provide an example of a proper setting for
"weather": {
    "appid": 'what exactly goes here`
}

obviously you can omit your apikey, but formatting for reference on the top-level readme would be helpful

If you got the appid already, just put your addid only like this.
"appid" :  "xxxxxxxxxxxxxxxxxxxxxxxxxxx"
You can also check your appid by your web browser :
http://api.openweathermap.org/data/2.5/weather?q=seoul,KR&APPID=xxxxxxxxxxxxxxxxxxx
This is an example of response  :
{"coord":{"lon":127.14,"lat":37.44},"weather":[{"id":721,"main":"Haze","description":"haze","icon":"50d"}],"base":"stations","main":{"temp":297.19,"feels_like":297.11,"temp_min":296.15,"temp_max":298.15,"pressure":1013,"humidity":69},"visibility":9000,"wind":{"speed":4.1,"deg":230},"clouds":{"all":75},"dt":1591498475,"sys":{"type":1,"id":8096,"country":"KR","sunrise":1591474241,"sunset":1591527012},"timezone":32400,"id":1897000,"name":"Seongnam-si","cod":200}


Add tooltips

In order to improve UX of an application we need to provide tooltips almost to every item in CC

Not relevant and mostly done.


#254-1: removed duplication of export PATH environment variable in log

Closes #254

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.009%) to 58.478%

Files with Coverage Reduction
New Missed Lines
%

com/devonfw/tools/ide/commandlet/EnvironmentCommandlet.java
1
92.31%

Totals

Change from base Build<PHONE_NUMBER>:
-0.009%

Covered Lines:
4062

Relevant Lines:
6694

💛  - Coveralls


Remove hashedMessage and HashedMessage references

Related to #176
I still found references, but only in non-*.md files
I think those need to be removed because this is not described:
$ git grep -l 'ashed'
negotiation/message/contract-agreement-verification-message.json
negotiation/message/diagram/contract-agreement-verification-message.puml
negotiation/message/schema/contract-agreement-verification-message-schema.json
negotiation/message/shape/contract-agreement-verification-message-shape.ttl
releases/v0.8/negotiation/message/contract-agreement-verification-message.json
releases/v0.8/negotiation/message/schema/contract-agreement-verification-message-schema.json
releases/v0.8/negotiation/message/shape/contract-agreement-verification-message-shape.ttl

Meeting result today:
Wait for #184
and do NOT change content in folder releases/v0.8/

Fixed with #214


How to keep dart class name when i use flutter build apk --obfuscate?

How to keep class name when i use flutter build apk --obfuscate?
In flutter project, i use page runtimeType as route name!

Hi @v7lin
Please check Obfuscating Dart code
 and Obfuscating Dart Code for Android
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you

Hi @v7lin
Please check Obfuscating Dart code  and Obfuscating Dart Code for Android
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you

keep dart class, not keep java class

I also have such problems, such as some dart bean conversion problems.


[#5976] Warn for Rails Cops

This PR warns for Rails Cops.
The following warning is displayed when the next released rubocop gem is installed.
# The following is an example for operation check.
% rake build
Rails cops have been removed from RuboCop 0.71. Use the `rubocop-rails`
gem instead.

Put this in your `Gemfile`.

gem 'rubocop-rails'

And then execute:

$ bundle install

Put this into your `.rubocop.yml`.

require: rubocop-rails

More information: https://github.com/rubocop-hq/rubocop-rails
    exists /Users/koic/src/github.com/rubocop-hq/rubocop
Successfully installed rubocop-0.70.0
1 gem installed

Based on the migration of RuboCop Performance I am considering the following transition schedule.

0.70 ... Current version
Next release ... Display a warning and prepare a transition period for users
0.72 ... Remove the Rails cops from RuboCop Core

https://github.com/rubocop-hq/rubocop/pull/6845#issuecomment-474277118

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks!


Test OAK Validation using ODK

Related to https://github.com/INCATools/ontology-development-kit/issues/610

@anitacaron  - can this PR be deleted or is it still important?

It's fine to close it. The issue at the ODK repo already references it.


DTM: Property library: Issues observed in Add new property screen.

Issues are mentioned below,

When user is creating a custom property, and default value is already filled, then the moment user clicks on Max length check box, empty validation error is displayed for default value. It should be displayed only if the default value does not conform to the max length of characters.

When creating a custom property of type text, in minimum length field, user is able to reduce the value to lesser than 0 using the decrement icon. This should not be allowed.

If user selects type as a text and configures min & max length, it is observed that if they don’t provide value as per the condition then error message is being displayed only for min length not for max. Though user can’t provide text beyond max length.

Validation issue when creating custom property of type number. In case user provides a 2 digit number as maximum limit and enters a default value greater than that, then in validation message only the first digit is seen.

Validation for Key field is missing in the complex custom property. It accepts space/special characters as valid input.

Refer https://itrac.eur.ad.sag/browse/CTM-34 for details


Added Planalyze to Showcase

I've added a new app I've been working on, Planalyze :)

@oliviertassinari No problem, thanks!


Define a way for adding MIRIAM annotations to Antimony

It would be desirable if MIRIAM annotations could be added to objects in Tellurium. A possible syntax could read, for instance,
x isVersionOf [https://identifiers.org/catalog1/entry1, https://identifiers.org/catalog2/entry1];

where x is some model component, such as a parameter or species, isVersionOf represents one arbitrarily chosen qualifier from the list of MIRIAM qualifiers, and the two URIs in square brackets represent an array of resources.
This syntax would be pretty short and easy to type, yet allow adding multiple controlled vocabulary items to any object as well as one or many resource URIs.

Hi Andreas, good to hear from you! I've been looking into implementing this as well as the syntax for naming modules that you requested. Antimony requires libsbml 5.17.1 svn, so we were planning on waiting until the next update, but if you can let me know what OS you are running I could upload an alpha version to https://test.pypi.org/ for you to experiment with.


Get Unable to resolve module error when create empty project

Problem
I created a new project with React Native CLI and run project. I got this error
 Unable to resolve module "@babel/runtime/helpers/interopRequireDefault"
Environment
Environment:
OS:  macOS High Sierra 10.13.6
Node:  10.10.0
Yarn:  1.9.4
npm:  6.4.1
Watchman:  4.9.0
Xcode:  Xcode 10.0 Build version 10A255
Android Studio:  3.1 AI-173.4907809
Packages: (wanted => installed)
react: 16.5.0 => 16.5.0
Steps to Reproduce

Run react-native init testapp && cd testapp
Run react-native run-ios

This project is not related to React Native. You can find resources for getting help with React Native here: https://facebook.github.io/react-native/help


don't wrap in $apply if configured + allow capitalized props

allow user to pass "wrapApply" prop config, which will prevent
the functions passed as props to be wrapped in scope.$apply.
Wraps functions as default.

React allows properties to be on any case, like for instance,
capitalized. This will allow it.

fixes #129

@rosston you are right. using getPropName makes sense.

Looks good - I think we can make the README entry slightly better. Otherwise, let's get a merged.

@kasperp please let me know if the new description on the README is acceptable.

Thanks - looks good. I'll make a patch release within the next couple of days.

0.4.1 is now available on npm.
Thanks for the effort 👍

Awesome. Thank you @kasperp and @ghermeto!


Generate target from multiple sources

Is your feature request related to a problem? Please describe.
Sometimes, the target we want to generate require multiple sources.
Is it possible to be done using goverter somehow? Even if it is, would be great if we can pass multiple source parameters.
Describe the solution you'd like
type Source1 struct {
    Free bool
    Blocked bool
}

type Source2 struct {
   Id string
   Name string
}

type Target struct {
   Id string
   Name string
   Free bool
   Blocked bool
}

Describe alternatives you've considered
I've considered using 2 map functions, one then the other, but if the target is of the same type, it doesn't work.

Similar #68
This is currently not possible, you could wrap both types into a separate object like this:
// goverter:converter
type Converter interface {
	// goverter:autoMap S1
	// goverter:autoMap S2
	Convert(source Sources) Target
}

type Sources struct {
	S1 Source1
	S2 Source2
}

But yeah, I want to support this use case.


RadioButtonGroups not triggering onChange events with React 15.6.1

RadioButtonGroups are not triggering onChange events since updating to React 15.6.1. Both controlled and uncontrolled events don't trigger the event.
handleUpdateMargin: (e, value) -> @setState margins: value

<RadioButtonGroup className='buttons-margins' name='margin-button' onChange={@handleUpdateMargin}
<EMAIL_ADDRESS>  <RadioButton className='inch-button' value='inch' label='1"' iconStyle={marginRight: '8px'}/>
  <RadioButton className='half-button' value='half' label='0.5"' iconStyle={marginRight: '8px'}/>
  <RadioButton className='min-button' value='min' label='Minimal' iconStyle={marginRight: '8px'}/>
</RadioButtonGroup>

This was working on React 15.5.3 but not on 15.6.1

Material-UI: 0.19.0
React: 15.6.1
Browser: Chrome

Having the same issue.
Deps;
"material-ui": "0.18.7",
"react": "15.6.1",

handleOptionItemChange = (event, radioButtonValue) => { ...stuff... };
doesn't fire an event in RadioButtonGroup as
onChange={this.handleOptionItemChange} or
onChange={(event, value) => {
  this.handleOptionItemChange(event, value)
}}

Any immediate fix for this?

I'm having the same issue with Radio component. Is there any update or workaround for this issue? Thanks!

The work around I have been using is adding manual onClick events to the components. For example
<RadioButton className='inch-button' value='inch' label='1"' iconStyle={marginRight: '8px'} onClick={@handleMargin.bind(nil, 'inch')}/>

onChange did not work for me too. Had to use onClick, as @dvriezen suggested.
 <Radio       checked = {this.state.value === option}       onClick= {this.handleChange}       {...input}       value={option}  />
Using material-ui-next with redux-form.
Could not find onClick in the API for Radio

With material-ui-next, if I handle a Radio onChange, I notice the value is always false. Maybe this is preventing RadioGroup from triggering onChange?

hi everyone, any news about this bug?  RadiobuttonGroup is still broken.

@dvriezen  We have been porting the component on the v1-beta branch. We have reimplemented it from the ground-up.
We encourage people starting with Material-UI to go with v1-beta. The master branch is in a low maintenance mode. We don't plan any work on it. However, we still do our best to review and merge pull requests that fix bugs on this branch.


Use of standard_name and TXYZ on special coordinates

✨ Feature Request
It should ALSO be possible to use the standard_name and the coordinate letter TXYZ for referring the 4 most common coordinates when performing statistical and other functions. For example:
mean = cube.collapsed('latitude', iris.analysis.MEAN)

AND
mean = cube.collapsed('Y', iris.analysis.MEAN)

Motivation
Basically, CF Conventions 1.9 does not restrict the way a variable or coordinate is named in the netCDF. Therefore if you have to perform an analysis from multiple sources, you cannot rely on the variable name. For example, if I want to calculate the mean of a cube:
For source 1 would be:
mean = cube.collapsed('latitud', iris.analysis.MEAN)

For source 2 might be:
mean = cube.collapsed('lat', iris.analysis.MEAN)

That is not reliable, it requires effort from the programmer to prepare the analysis for every source (or extend it with a dynamic coord read which I could not figure out on iris). Instead, as specified by CF Conventions and reproduced by other libraries cf-python, cf-xarray, the usage of standard names is recommended for the special coordinates described at section 4 at CF Conventions 1.9.
Additional context
This is collected form CF Conventions 1.9:
"Because identification of a coordinate type by its units is complicated by requiring the use of an external software package [UDUNITS] , we provide two optional methods that yield a direct identification. The attribute axis may be attached to a coordinate variable and given one of the values X, Y, Z or T which stand for a longitude, latitude, vertical, or time axis respectively. Alternatively the standard_name attribute may be used for direct identification. But note that these optional attributes are in addition to the required COARDS metadata."

Nevermind, looks it already uses "standard_names".

@BorjaEst in case it helps, you should also be able to do something like
y_coord = cube.coord(axis="Y")
mean = cube.collapsed(y_coord, iris.analysis.MEAN)

@BorjaEst in case it helps, you should also be able to do something like
y_coord = cube.coord(axis="Y")
mean = cube.collapsed(y_coord, iris.analysis.MEAN)

Yes @rcomer, actually that helps a lot, thanks!


_server.close callback never called

During a server shutdown, when clients are disconnected by the shutdown, the _server.close callback is never called.
Perhaps engine.io is still accepting connections after close?

To be more specific, I have a timeout of 10 seconds for the server shutdown. If _server.close is being called after 10 seconds, I do not know about it.
I am not using deepstream in production yet, does 10 seconds seem too short to you guys?

10 seconds should be fine. We've encountered an issue a while ago where TCP ports weren't released for a few minutes by the OS, but that only caused trouble when restarting the server, not when shutting it down. We'll extend our test-suite around closing the server and should hopefully be able to pin down the issue shortly.

Perhaps this is an issue where the clients and tcp close before the server, and then engineio closed which means it doesn't actually do anything. Ran into that when writing tests for another issue, be good to see if this can still be duplicated after the next release.

@Lalem001 I can't seem to replicate this issue. Is it based on a purely vanilla setup or is their anything that can help me reproduce this?

Simplest steps to reproduce:

Create/start a basic deepstream server.
Load deepstream's test-client in browser, and leave open
Call server.stop()

I call server.stop on ctrl + c

The callback is never called. Happens every time.
I see that the server code has been updated since I originally posted. The new line in question starts at connection-endpoint.js#L128.
Despite the changes, the issue still occurs.

Awesome, will take a look at it and see

Any updates? Have you been able to replicate?

Hi @Lalem001,

I call server.stop on ctrl + c

Do you mean you're just doing ctrl+c on the running $ node start.js deepstream instance? (I got mine started with this file). Are you doing anything manual like listening to ctrl+c yourself, and calling server.stop() by yourself? Something like this is what I mean: https://gist.github.com/adityamenon/a8b24d1b6ce45c27f54fb5cbda1029e4
Sorry for the confusion!

Hello @adityamenon,
My stop code basically boils down to:
process.on('SIGINT', () => {
  server.once('stopped', () => { process.exit(0); });
  server.once('error', () => { process.exit(1); });
  server.stop();
});

This is omitting logging, promises, and many other bits.
I hope this clarifies things for you.

I couldn't replicate the issue & the callback function being passed to _server.close() is in fact being called, *when I use a key that is not ctrl+c.
My setup steps:

Modify start.js to look like so:

var Deepstream = require( './src/deepstream.io' );
var deepstream = new Deepstream();

process.stdin.on('readable', () => {
  var chunk = process.stdin.read();
  if (null !== chunk && chunk.toString() === "d\n") deepstream.stop();
});

deepstream.start();

Run $ node-debug start.js
Have a breakpoint inside the _server.close callback.
Hit d then Enter

I see that the callback is indeed being triggered.
There's a chance that SIGTERM behaves a little differently, I will test that.

@adityamenon Are you having a client connect to the test server you have created? Perhaps I was not so clear on that point in my steps to reproduce above.
Here are the steps again, with the step to connect added in.

Create/start a basic deepstream server.
Load deepstream's test-client in browser, connect, and leave open
Call server.stop()

I call server.stop on ctrl + c

The point is that the server fails to call the callback when it needs to disconnect a client.

Oh yeah, you're actually right.
I just added:
process.on('SIGINT', () => {
  deepstream.stop();
})

to my start.js file. Also, a console.log() inside that callback.
Then, without connecting with a client, when I did Ctrl+C, the callback was called. However when I ran had the test-client/test-client.html page open in the browser, then hit Ctrl+C, the callback was no longer called.
It was kind of unbelievable for me, I didn't know enough to figure that having a client connected can affect this.
As an aside, is there any way to have node-debug ignore SIGINT and not stop? It's very annoying to lose debugger abilities when doing testing related to this key combo.

(just to be clear SIGINT is not a necessity, the problem is replicated with any other key combo as well as long as a client is connected)

Cool, found a few issues:

The clients object in engine.io is an object and not an array, so the loop isn't correct
Engine.io doesn't clean up on .close, it just closes current conenctions. This means requests will come in, create new sockets and never call the close callback.

That being said, it still doesn't give immediate close callback, so not sure if state is still somewhere.
Old logs:
AUTH_SUCCESSFUL | Wolfram
engine intercepting request for path "/engine.io/" +6ms
engine handling "GET" http request "/engine.io/?EIO=3&transport=polling&sid=TcxbSUM0BKlTGSXFAAAA" +3ms
engine setting new request for existing client +4ms
engine:polling setting request +0ms
engine:socket flushing buffer to transport +6ms
engine:polling writing " ║�4AA" +1ms
engine:socket executing batch send callback +2ms
engine intercepting request for path "/engine.io/" +9ms
engine handling "GET" http request "/engine.io/?EIO=3&transport=polling&sid=TcxbSUM0BKlTGSXFAAAA" +7ms
engine setting new request for existing client +1ms
engine:polling setting request +0ms
engine upgrading existing transport +216ms
engine:socket might upgrade socket transport from "polling" to "websocket" +2ms
engine:ws received "2probe" +6ms
engine:ws writing "3probe" +3ms
engine:socket writing a noop packet to polling for fast upgrade +102ms
engine:polling writing " ╔�6" +1ms
engine:ws received "5" +6ms
engine:socket got upgrade packet - upgrading +1ms
engine:polling closing +7ms
engine:polling transport discarded - closing right away +0ms
engine closing all open clients +4s
engine:ws closing +2ms
CLIENT_DISCONNECTED | Wolfram
engine intercepting request for path "/engine.io/" +13ms
engine handling "GET" http request "/engine.io/?EIO=3&transport=polling" +3ms
engine handshaking client "-_nTxxocLJZMdG1rAAAB" +1ms
engine:socket sending packet "open" ({"sid":"-_nTxxocLJZMdG1rAAAB","upgrades":["websocket"],"pingInterval":25000,"pingTimeout":60000}) +2ms
engine:polling setting request +1ms
engine:socket flushing buffer to transport +1ms
engine:polling writing "      �0{"sid":"-_nTxxocLJZMdG1rAAAB","upgrades":["websocket"],"pingInterval":25000,"pingTimeout":60000}" +1ms
engine:socket executing batch send callback +1ms
engine intercepting request for path "/engine.io/" +15ms
engine handling "GET" http request "/engine.io/?EIO=3&transport=polling&sid=-_nTxxocLJZMdG1rAAAB" +1ms
engine setting new request for existing client +0ms
engine:polling setting request +1ms
New logs have nothing after CLIENT_DISCONNECTED.
The server now closes, but still requires about a minute so something must be held up. Wondering if its due to using .close instead of .destroy in one of the protocols which doesn't force the socket to close...

Fixed, but since engine.io closes sockets graceful you have to wait before closes to exit process


Billing: contract appear double in billing loops

I have identified multiple contracts which appear to be inserted on a index in the billing loop. See https://github.com/threefoldtech/tfchain/blob/2eb3860fd54488899e43c8234457a89b7a385408/substrate-node/pallets/pallet-smart-contract/src/lib.rs#L1020 where contracts are inserted in a billing loop if there are resources pushed or it is created with a public IP or it is any other contract https://github.com/threefoldtech/tfchain/blob/2eb3860fd54488899e43c8234457a89b7a385408/substrate-node/pallets/pallet-smart-contract/src/lib.rs#L878
We need to redesign this because this will cause issues in the long run.

The weird part is that this code is not yet live on any network. We need to check the current deployed code and see why this is happening.

Let's revert these changes and also add an extra check in the offchain worker:
fetch the contract ->

check if used resources
check if used ip
check if any consumption reports were pushed

IF no => don't make an extrinsic and such will be excluded from billing

New billing loop rules:

Each contract (node/rent/name contracts) is inserted in billing loop only once, when contract is created.
There is no more exception for node contracts with no public ips and no used resources on chain.

When a contract is to be billed during the billing loop execution (via the offchain worker), bill it ONLY if there is effectively some IP/SU/CU/NU consumed. Technically this comes down to trigger bill_contract() extrinsic only when there is some used ip / resources or consumption reports linked to this contract.

Fix was deployed on devnet, need to verify before we close but its looking good so far.

Fix verified


2n-2m-2s-sync

Before Creating the Bug Report

[X] I found a bug, not just asking a question, which should be created in GitHub Discussions.

[X] I have searched the GitHub Issues and GitHub Discussions  of this repository and believe that this is not a duplicate.

[X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment
linux redhat 8.4
RocketMQ version
5.1.3
JDK Version
jdk8
Describe the Bug
Caused by: org.apache.rocketmq.client.exception.MQClientException: CODE: 1  DESC: Can't modify topic or subscription group from slave broker, please execute it from master broker.
Steps to Reproduce
内网搭建，无法提供环境
What Did You Expect to See?
怎么解决
What Did You See Instead?
Caused by: org.apache.rocketmq.client.exception.MQClientException: CODE: 1  DESC: Can't modify topic or subscription group from slave broker, please execute it from master broker.
Additional Context
No response

Before Creating the Bug Report

[x]  I found a bug, not just asking a question, which should be created in GitHub Discussions.
[x]  I have searched the GitHub Issues and GitHub Discussions  of this repository and believe that this is not a duplicate.
[x]  I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment
linux redhat 8.4
RocketMQ version
5.1.3
JDK Version
jdk8
Describe the Bug
Caused by: org.apache.rocketmq.client.exception.MQClientException: CODE: 1 DESC: Can't modify topic or subscription group from slave broker, please execute it from master broker.
Steps to Reproduce
内网搭建，无法提供环境
What Did You Expect to See?
怎么解决
What Did You See Instead?
Caused by: org.apache.rocketmq.client.exception.MQClientException: CODE: 1 DESC: Can't modify topic or subscription group from slave broker, please execute it from master broker.
Additional Context
No response

更新topic或订阅组似乎请求到了slave broker。clsuterList命令执行结果是什么

此外，建议类似问题先去https://github.com/apache/rocketmq/discussions提问

看下是否有broker的master的服务挂了或这台网络不通


Rust build fails with latest version of CUDA.

Backend impacted
The Rust implementation
Operating system
Linux
Hardware
GPU with CUDA
Description
Attempting to build with the latest cuda driver/toolkit (12.6) results in the following error:
error: failed to run custom build command for `cudarc v0.11.6`

Caused by:
  process didn't exit successfully: `/moshi/rust/target/release/build/cudarc-52348fd62b0fe858/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=build.rs
  cargo:rerun-if-env-changed=CUDA_ROOT
  cargo:rerun-if-env-changed=CUDA_PATH
  cargo:rerun-if-env-changed=CUDA_TOOLKIT_ROOT_DIR

  --- stderr
  thread 'main' panicked at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cudarc-0.11.6/build.rs:79:14:
  Unsupported cuda toolkit version: `12.6`. Please raise a github issue.
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

Extra information
The error says to file a GitHub issue, but it doesn't specify where I should file an issue so I'm filing one on the repo I am trying to build.  It is possible this issue is in some dependency, but from the error it was not obvious to me how whatever dependency ran into this error was getting included as I don't see cudarc in any cargo files.
Environment
Fill in the following information on your system.

Operating system version: Ubuntu
Note: I'm running in a docker container on Windows, but I'm quite confident that is unrelated as the error is during the build step which happens entirely within the nVidia Ubuntu docker container.

If the backend impacted is PyTorch:

Python version: N/A
PyTorch version: N/A
CUDA version: 12.6
GPU model and memory: NVIDIA Quadro RTX 4000.

The message comes from cudarc, they already created a version to support cuda 12.6. I'm minting a new version of candle to support this in https://github.com/huggingface/candle/pull/2494 and if all goes well will update moshi to benefit from it.

Just merged #113 which brings compatibility with cuda 12.6, let us know if you still have issues.

@LaurentMazare
the build was passed after the update to v0.7.1, but showed new errors :
cargo run --features cuda --bin moshi-backend -r -- --config moshi-backend/config.json standalone
   Compiling candle-kernels v0.7.1
   Compiling candle-core v0.7.1
   Compiling candle-nn v0.7.1
   Compiling candle-transformers v0.7.1
   Compiling moshi v0.2.2 (/home/jackylee/myProjects/Ai-Rust/moshi/rust/moshi-core)
   Compiling moshi-backend v0.2.2 (/home/jackylee/myProjects/Ai-Rust/moshi/rust/moshi-backend)
    Finished `release` profile [optimized + debuginfo] target(s) in 56.29s
     Running `target/release/moshi-backend --config moshi-backend/config.json standalone`

2024-09-25T09:53:11.057410Z  INFO moshi_backend: build_info=BuildInfo { build_timestamp: "2024-09-25T08:46:04.268850290Z", build_date: "2024-09-25", git_branch: "main", git_timestamp: "2024-09-24T10:21:18.000000000+02:00", git_date: "2024-09-24", git_hash: "5d94128878678bb6e5a9471aed8c78f4d96eb473", git_describe: "5d94128", rustc_host_triple: "x86_64-unknown-linux-gnu", rustc_version: "1.81.0", cargo_target_triple: "x86_64-unknown-linux-gnu" }

2024-09-25T09:53:11.057436Z  INFO moshi_backend: starting process with pid 20925

Error: DriverError(CUDA_ERROR_UNSUPPORTED_PTX_VERSION, "the provided PTX was compiled with an unsupported toolchain.") when loading cast_f32_bf16

my system setting:
Ubuntu 24.04.1
6.8.0-31-generic
nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2024 NVIDIA Corporation
Built on Wed_Aug_14_10:10:22_PDT_2024
Cuda compilation tools, release 12.6, V12.6.68
Build cuda_12.6.r12.6/compiler.34714021_0

nvidia-smi
NVIDIA-SMI 535.171.04       Driver Version: 535.171.04   CUDA Version: 12.2
I had tried to update the Driver version to 550 560,  but after installing the nvidia-smi run failed, only the 535 works
Error: DriverError(CUDA_ERROR_UNSUPPORTED_PTX_VERSION, "the provided PTX was compiled with an unsupported toolchain.") when loading cast_f32_bf16
the errors occurred after the model was downloaded from huggingface
It looks like the  CUDA driver version: 12.2 is vary from the nvcc --version: Build cuda_12.6.r12.6/compiler.34714021_0
Any idea how to solve this error will be a great help  !!

My guess is that 535.171.04 is too old for cuda 12.6, so you can either try installing a more recent driver and get it to work, or try compiling moshi with an older toolchain (12.2 would be the appropriate one for your drivers I guess).

I had check this CUDA Compatibility the v535 was CUDA Forward Compatible Upgrade of v12.6
I also tried to downgrade to 12.2 but some of the modules failed to build, I forgot to take some notes, and I am unsure if this happened in the candle module or the moshi module.
Since the requirement 1.1. System Requirements   I also lock the Ubuntu kernel to 6.8.0-31-generic,
I am so confused about how to make the v550(v12.5) or v560(v12.6) work at my Ubuntu <IP_ADDRESS>, may the 24.04 be too new to be updated, if anyone has solutions, let me know.

Try to update cudarc in moshi-core crate to 0.12.1, that fixes the issue for me.

We've bumped the dependency to a candle version that supports 12.6 and removed the cudarc one so hopefully the github version should be all good now.

This might not be exactly this specific problem but hope it can help someone, Because i had similar errors to these.
What worked for me was to generate the ptx files from the cu's from the folder
"candle-kernels-0.7.2"
for me it was in
"C:\Users\<username>\.cargo\registry\src\index.crates.io-6f17d22bba15001f\candle-kernels-0.7.2\src"
, then move them to
"moshi\rust\target\release\build\candle-kernels-fd0438922b6766ae\out"
as they expected to be
the files i had to compile were:

unary.ptx
ternary.ptx
sort.ptx
reduce.ptx
quantized.ptx
indexing.ptx
fill.ptx
conv.ptx
cast.ptx
binary.ptx
affine.ptx

with the command :
nvcc -ccbin "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\bin\Hostx86\x64" --ptx --gpu-architecture=sm_89 <filename>.cu -I.
my suspension is that it couldn't fine the link.exe or the other executables on its own, or it could be the compilation parameters, im not sure, im still new to this ,still figuring it out, but i just wanted to put it out there hopefully it could point to something.
Im on Windows 11
4090 GPU
Intel CPU : on that not i had to put my power settings on saving mode, otherwise some other errors poped out to existence, files would just exit abruptly, typical intel stuff haha
nvcc --version                                                                                in pwsh at 23:56:52
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2024 NVIDIA Corporation
Built on Wed_Oct_30_01:18:48_Pacific_Daylight_Time_2024
Cuda compilation tools, release 12.6, V12.6.85
Build cuda_12.6.r12.6/compiler.35059454_0

Currently waiting for the model to finish downloading, will keep this updated if anything comes up.


Unable get the X-JWT-Assertion header to the WS back-end (on-open) for WS APIs

Description:
Unable get the X-JWT-Assertion header to the WS back-end (on-open) for WS APIs
Affected Product Version:
APIM 3.2.0

The issue is resolved. However, this can be further improved by NOT mandating the below configuration:
[transport.ws.sender]
enable = true

[transport.ws.sender.parameters]
"ws.custom.header" = "websocket-custom-header"

[transport.wss.sender]
enable = true

[transport.wss.sender.parameters]
"ws.custom.header" = "websocket-custom-header"

Please do resolve / close this issue accordingly.


Derive SocketAwaitable from SocketAsyncEventArgs

Based on https://github.com/aspnet/KestrelHttpServer/pull/2147#discussion_r149276777
SocketAwaitable (renamed to SocketAwaitableEventArgs) derives from SocketAsyncEventArgs and overrides OnCompleted, so

no extra object for the awaitable is needed and two int-fields saved
no need to register to the Completed event

By the way

GetResult made inlineable
SocketReceiver and SocketSender uses a common base class (refactored)

I'd like to run some RPS-benchmark similar to https://github.com/aspnet/KestrelHttpServer/pull/2147, but I don't know how. Can you please give me some advice for it?

/cc @halter73

@gfoidl I like this because it looks like pretty good code cleanup. I don't think the per-connection allocations this avoids will make a significant impact in our plaintext or json benchmarks, but I can try running it tomorrow.

Rebased due to
Conflicting files

src/Kestrel.Transport.Sockets/Internal/SocketReceiver.cs
src/Kestrel.Transport.Sockets/Internal/SocketSender.cs

@halter73 do you want to take this in 2.2?

Yep.

@dotnet-bot test this


Bugfix/fix compiler pragma for clang

Per the clang documentation, it understands both #pragma GCC and #pragma clang as synonymous:
https://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-via-pragmas
So I'm not sure this is necessary, was there a warning/error motivating this?

Ah. It is because clang didn't recognize the warning flag Walloc-size-larger-than= and I think Wstringop-overflow= as well.


Is Nuxt 3 supported?

I'm trying to integrate nuxt-intercom into my Nuxt 3 App, however I get the error..
Cannot start nuxt:  appId is not defined

No this hasn't been updated for a Nuxt 3

Unfortunately not at this time. Thinking about it, I will reopen the issue and we'll put Nuxt 3 support on the roadmap, but I can't give a date for it and we're not actively working on it right now.
We'll likely revisit it sometime after Nuxt 3 has been released. Alternatively, if you or others are happy to update for Nuxt 3 we'd be extremely grateful and happy to accept a PR.

Has this been completed yet? Nuxt 3 has been out for quite some time now. Lots of sites have moved over to it and have had to move away from Intercom due to no support for it.

Hi mate,
We haven't had the need to use this module on a Nuxt 3 site, and so haven't upgraded it for now.
If you or others are happy to update for Nuxt 3 we'd be extremely grateful and happy to accept a PR.

Why it's shown on the nuxt3 modules page then ? ... https://nuxt.com/modules/intercom

This module would be very good in nuxt 3🥺

Thanks for that. I'll close this issue and point others to this repo for Nuxt 3