Pedal overshoot (17 Corolla)

I took a drive on the stock Toyota pedal tuning (albeit not on stock openpilot, but there were no leads so it was just maintaining set speed) and this is how my velocity and set speed relate:

The time that set speed was set to 70+, I was driving on open road without any major hills. The maximum it overshot was 3 or 4 mph at 75 mph, while it was mostly 1 or 2 mph overshoot. It overshoots even if it's a slow acceleration, it continues to give gas when above by around 1.5 mph then it figures out that it needs to slow down after a second or two.
I really have no experience tuning PID or PI loops, so I have no real solution. But if the raw data can be useful to anyone who's more experienced, let me know.

This was my acceleration command from openpilot (/the car?) For some reason, it's always requesting ~.11m/s/s until it realizes that the speed is higher than my set speed and requests brake. Does anyone have any clue why this is?

I can account for 0.02 for hysteresis
ACCEL_HYST_GAP = 0.02  # don't change accel command for small oscilalitons within this value
And 0.06 because of the abs pump fix.
if CS.CP.enableGasInterceptor:
# send only negative accel if interceptor is detected. otherwise, send the regular value
# +0.06 offset to reduce ABS pump usage when OP is engaged
apply_accel = 0.06 - actuators.brake
apply_accel, self.accel_steady = accel_hysteresis(apply_accel, self.accel_steady, enabled)
Where the rest of the 0.03 is hiding I am not sure.

I took a short drive at 50 mph with 0 integral and I was pleasantly surprised that it didn't overshoot, it actually let off the gas as I approached my set speed when with integral (above) you can see it overshooting

For the math down.
0.06% gas for abs pump. Minus 0.02% gas for hysteresis. 0.04% times 3.000 because it is the brake maximum value and the scale value is based on the maximum of both brake and gas maximum. Which gets you to 0.12 apply steer, give or take a few rounding errors

I have a few updates to this issue; I tried adding a derivative term to the PI loop for long control however it didn't work too well since the setpoint changes with the measurement (our speed). However if I limited derivative to only be active when the setpoint isn't changing much (we're cruising at x speed without any lead) it actually ended up working much better.
I was able to improve this performance even better when I instead added derivative to integral, it winds down integral as we approach the set speed which performed hugely better when I went over hills, or engaged from a stop and it accelerated to something high like 50 mph.

Here's a graph I've made up of a short ~3 minute-ish drive I took (circled back and took the same section of road).

I luckily hit the same traffic light after decreasing my speed to 53 mph so I could run that 0 to 50 mph test twice.
You can see that with derivative the average error is decreased by almost half each time. Still some tuning to do, it's not perfect yet, but much better.

Here's a section of road that I was able to drive uninterrupted by any leads for a longer time than above:

However on the way back traffic picked up so I wasn't able to drive the same route again without any (slower) cars ahead of me. You can see the average error is even better at 0.09 m/s. I will try to do that section of road again without derivative tonight and post here with a comparison

Overshoot sounds like too much integral.
Another issue could be a non-linearity in the pedal. I.e. 50% pedal action causes different accelerations based on the speed. The PID controller assumes that a certain amount of pedal action always causes the same amount of acceleration.
For the Acura pedal we solved this by training a small neural network to estimate the required pedal output for a given desired acceleration and speed: https://github.com/commaai/openpilot/blob/master/selfdrive/car/honda/interface.py#L57
You don't have to do this with a neural network. A simple function that increases pedal action at higher speeds might already do the trick. Try something like:
def compute_gb(accel, speed):
  return float(accel / 3.0 * (0.5 + speed / 60.0)) # 0.5x at 0mph, 1x at 70mph

Does it make more sense to close loop with engine torque output? Do we this info on the CAN? Engine Torque at the axle to vehicle acceleration math is straight forward, that way at any speed a given engine torque will produce the calculated acceleration in the vehicle?

Issue is that we send acceleration to the pedal when it expects gas. Above 19 mph is fixed here: https://github.com/commaai/openpilot/pull/21101


Typo in gan_langauge.py

https://github.com/igul222/improved_wgan_training/blob/master/gan_language.py#L89
Remove "_"

Thanks! Fixed.

Thanks for the great repo! Love how little code it takes :-)


Error: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference

Report

[x] I have searched existing issues and this is not a duplicate.

Environment

Platforms: Android

Android version: 10

iOS version: N/A

Issues and Steps to Reproduce
I have not tested this on iOS, but on android, whenever I tap on Register, the following error gets logged:
Error: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference

Note that I am running the code I got from https://github.com/CatalystCode/react-native-azurenotificationhub/blob/master/docs/android-installation.md#javascript-configuration and only changed the connectionString and hubName to their correct values. The error is vague and I'm unsure what it's referring to...

Expected Behavior
The error shouldn't be thrown.
Actual Behavior
The error is thrown.
Link to Code
N/A

this happens on the register call, the register is successful, but the _onAzureNotificationHubRegistrationError logs with that error afterwards.

Here's the whole log from Android studio:
E/ReactNativeRegistration: Failed to complete token refresh
    java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference
        at java.net.URI$Parser.parse(URI.java:3086)
        at java.net.URI.<init>(URI.java:583)
        at java.net.URI.create(URI.java:845)
        at com.microsoft.windowsazure.messaging.Connection.executeRequest(Connection.java:147)
        at com.microsoft.windowsazure.messaging.Connection.executeRequest(Connection.java:132)
        at com.microsoft.windowsazure.messaging.NotificationHub.refreshRegistrationInformation(NotificationHub.java:297)
        at com.microsoft.windowsazure.messaging.NotificationHub.registerInternal(NotificationHub.java:391)
        at com.microsoft.windowsazure.messaging.NotificationHub.register(NotificationHub.java:144)
        at com.azure.reactnative.notificationhub.ReactNativeRegistrationIntentService$1.onSuccess(ReactNativeRegistrationIntentService.java:73)
        at com.azure.reactnative.notificationhub.ReactNativeRegistrationIntentService$1.onSuccess(ReactNativeRegistrationIntentService.java:53)
        at com.google.android.gms.tasks.zzn.run(Unknown Source:4)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.lang.Thread.run(Thread.java:764)


Generated NDArray wrappers have wrong function argument declaration

Description
Generate Python wrapper for operators in the NDArray APIs do not have the correct function declaration (argument list).
Error Message:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<string>", line 59, in softmax
  File "/Users/sskalic/projects/mxnet/sskalic_branch5/python/mxnet/_ctypes/ndarray.py", line 92, in _imperative_invoke
    ctypes.byref(out_stypes)))
  File "/Users/sskalic/projects/mxnet/sskalic_branch5/python/mxnet/base.py", line 252, in check_call
    raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: [17:09:02] src/c_api/../imperative/imperative_utils.h:336: Check failed: num_inputs == infered_num_inputs (0 vs. 1) Operator softmax expects 1 inputs, but got 0 instead.

Stack trace returned 7 entries:
[bt] (0) 0   libmxnet.so                         0x0000000103e98ae6 dmlc::StackTrace() + 1238
[bt] (1) 1   libmxnet.so                         0x0000000103e984d5 dmlc::LogMessageFatal::~LogMessageFatal() + 53
[bt] (2) 2   libmxnet.so                         0x0000000103e94655 dmlc::LogMessageFatal::~LogMessageFatal() + 21
[bt] (3) 3   libmxnet.so                         0x00000001067a895c mxnet::imperative::SetNumOutputs(nnvm::Op const*, nnvm::NodeAttrs const&, int const&, int*, int*) + 988
[bt] (4) 4   libmxnet.so                         0x00000001067a5612 MXImperativeInvokeImpl(void*, int, void**, int*, void***, int, char const**, char const**) + 210
[bt] (5) 5   libmxnet.so                         0x00000001067a8e08 MXImperativeInvokeEx + 184
[bt] (6) 6   _ctypes.so                          0x000000010319a7b7 ffi_call_unix64 + 79

The expected error message should be of the form:
TypeError: softmax() takes exactly # arguments (0 given)

Minimum reproducible example
import mxnet as mx
mx.nd.softmax()

Steps to reproduce
Execute above code
What have you tried to solve it?
There is a deep underlying problem with the way we generate wrappers "on-the-fly". Heres an example:
# generic/unsafe function definition
def sam1(*args, **kwargs):
    print(args)
    print(kwargs)

# specific function definition
def sam2(size,joe):
    print(size)
    print(joe)

#valid function calls
sam1(2,joe=4)
sam2(2,joe=4)

#invalid function calls that do not fail
sam1(1,2,3)
sam1(2,bob=4)

# invalid function calls that do fail
try:
    sam2(1,2,3)
except TypeError as e:
    print('Dont do that! ',e)

try:
    sam2(2,bob=4)
except TypeError as e:
    print('Dont do that! ',e)

MXNet should be generating specific python function declarations, not generic ones. This leads to the bad error message above instead of the familiar one in Python.

@mxnet-label-bot : [Python, NDArray]

Upon further investigation it seems that the actual issue is that there is automatically generated default values for each argument:
https://github.com/apache/incubator-mxnet/blob/76bdc8772c7f4edd3087bd1285025122fc837c06/python/mxnet/ndarray/register.py#L67-L88
This results in the following function signature for the smooth_l1 operator:
def smooth_l1(data=None, scalar=_Null, out=None, name=None, **kwargs)

The problem is that these default values end up getting passed down to the C++ operator implementation and cause the error shown in the description. Ideally, we should only set default values that the user provided when they registered the operator.

Instead, it looks like all we pass up is the name, type, and description
https://github.com/dmlc/tvm/blob/675216fbeb94c835e8267ae97aeed58f129c1c39/nnvm/src/c_api/c_api_symbolic.cc#L70-L78
If we could pass the default values (and a boolean to say whether there is one or not) then we could set the default value in the python argument list correctly. This would allow arguments with required values to fail natively as expected in the higher level language.

@samskalicky Looks like the PR referencing this issue has been merged.
Can this issue be closed then ?

@piyushghai No, this is not a problem with a single operator. Its a problem with the architecture of generating the python wrappers in the way its currently done.
The PR referencing this issue is not a solution for the actual problem, it was a solution for just the smooth_l1 operator argument issue in which this problem was discovered.


Intellisense not working with TS and dynamic exports

Intellisense doesn't work when doing:
file1.ts
export = {
  x: 1
}

file2.ts
import {/* No suggestions */} from './file1';

Looking at the current TypeScript docs, it looks like export =  must be used with import x = require('module')https://github.com/Microsoft/TypeScript-Handbook/blob/master/pages/Modules.md#export--and-import--require )
Closing as-designed


Record exception

And include bunch of changes.
Resolves #41.

Exception recording itself is not tested. Mark it ready after tested.

I've shipped lots of changes with this PR. It's not desirable but.. just did it.


NonNativeKeyboard keys can be triggered from both side

Describe the bug
When using the NonNativeKeyboard, it is possible to press the keys from the front and the back.
To reproduce
Steps to reproduce the behavior:
Open a scene which use the NonNativeKeyboard.
Place your finger behind the keyboard without touching it
Pull your finger through a key on the keyboard and it will be triggered
Expected behavior
Keys on the keyboard should only be triggered from the front
Screenshots
If applicable, add screenshots to help explain your problem.
Your setup (please complete the following information)

Unity Version2019.4..5f1
MRTK Version v2.4

Target platform (please complete the following information)

HoloLens 2

@Merichbier thanks for reporting this. We'll look into it.

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Add Predicate xsd:types fixing

predicateselectorwidget in uiwidget allow to create triples, but when object is a literal the type must be a xsd type

The button edit on Nodes Infos window is fixed and now you can use on addPredicate menu on a NodesInfos the properties xsd which makes you a triple with owl:hasValue the value selected and the datatype selected on the volet property

Not functionnal on 1.38

Work only on dates

Fixed but do we want here to introduce each time we create a litteral a new blank node which will carry the litteral information?


BackHandler only receives backs in super.onBackPressed, but should be received before backstack.goBack

This is actually a major issue in the current examples.
Using backstack.goBack() before super.onBackPressed() means that the dispatcher won't receive it before the backstack going back.
    /**
     * Called when the activity has detected the user's press of the back
     * key. The {@link #getOnBackPressedDispatcher() OnBackPressedDispatcher} will be given a
     * chance to handle the back button before the default behavior of
     * {@link android.app.Activity#onBackPressed()} is invoked.
     *
     * @see #getOnBackPressedDispatcher()
     */
    @Override
    @MainThread
    public void onBackPressed() {
        mOnBackPressedDispatcher.onBackPressed();
    }

Basically, Jetpack team should have probably made onBackPressed final with this new current approach, as the order cannot be correct if you do anything before calling super.onBackPressed.
The solution is to register an always-enabled callback, but the Activity actually tries to close the action bar first instead of finishing.
        onBackPressedDispatcher.addCallback(this, object : OnBackPressedCallback(true) { // always intercept.
            override fun handleOnBackPressed() {
                val topKey = backstack.top<FragmentKey>()
                val fragment = supportFragmentManager.findFragmentByTag(topKey.fragmentTag)
                if (fragment is BackHandler) {
                    val handled = fragment.handleBack()
                    if (handled) {
                        return
                    }
                }
                if (!Navigator.onBackPressed(this@MainActivity)) {
                    finish() // we cannot access Activity.onBackPressed() anymore. RIP
                }
            }
        })

I don't see a way to access Activity.onBackPressed() because super.onBackPressed() would just send to the dispatcher again, causing an infinite loop.
What the heck.

Fixed as an extra note in the documentation.
https://github.com/Zhuinden/simple-stack/commit/f7f82e6d2b4bc0e49f4e07c5dc54ef8f54019d08#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5


advanced security lab added

Added a new lab in azuredevops section
This covers quick overview on Advanced security feature that will be available for preview soon

Need to update more content


Port 8080

when i load steam sfp says
[Error] Could not fetch browser, SFP either tried to inject too early or another service is running on port 8080
but when i go to http://<IP_ADDRESS>:8080/ it just shows the default steam CEF dev page thing, so ig its the first part of the error where its injecting too early, this happened after steam updated for me

Ok so i just realized that clicking start injection well after steam has loaded it still gives the error so its not that its too early

SFP was working prior to updating Steam? Are you running the latest version of SFP (0.0.52)? What operating system are you running (windows/linux/mac)?
Can you post the entire SFP.log file?

SFP.log
The same error happens to me here's my latest log

The same error happens to me here's my latest log SFP.log

And what happens if you go to http://localhost:8080/ in your browser? Does that work?
Same goes for @WmeLuna actually since I just realized you put <IP_ADDRESS> in your comment

According to this reddit post the issue seems to be related to VPN usage, particularly with a "split tunneling" feature which frankly I'm not too familiar with myself. Or at least that's one possible explanation.

When I open localhost:8080 this is what I get, I am also not using a VPN at this time

for anyone on linux/steam deck having this issue, there's a chance that syncthing (particularly syncthing-gtk) is the thing that's taking up port 8080. kozec/syncthing-gtk#199 addresses this, and the solution is to open the config file located at ~/.config/syncthing/config.xml (or ~/.var/app/me.kozec.syncthingtk/config/syncthing/config.xml if using the flatpak/discover store package) and change the gui address port from 8080 to 8384, the standard port used for syncthing

having the same issue here, running on Arch Linux, no other services running on port 8080, sncthing never installed, same with VPN. Any instructions much appreciated.

Hello, is the first time I use it, so Iw as never able to change a skin, I see them in the settings menu, but cant apply them, also get the mentioned error, using fedora linux, and I dont have any other services using port 8080. http://<IP_ADDRESS>:8080/ shows the web version of steam, so its in order.  Running from terminal steam -cef-enable-debugging does not help either. I am happy to test anything you need! :-)


Reduce memory consumption when constructing the tree.

Currently, we store start (32 bits), end (32 bits) and file offset (64 bits) for each read, so 124 bits per read. For larger files (HG002.hs37d5.2x250_sorted.bam from GIAB) there are 837,504,748 reads, which requires ~110 GB of RAM to store the list of records.
There has to be a way to construct the tree without having to store this entire list. We need the start/end/offset for the interval nodes (start and offset of left-most read, end of right-most read), and the start/end of each record for the median calculations...

htslib::hts_idx_get_stat will get # of mapped and unmapped reads from a chromosome if you give it a BAI file.

htslib::hts_idx_get_n_no_coor gets total # of unmapped reads?

Resolved by #25, we now construct one interval tree per chromosome.


EKAttributes Screen interaction "absorbTouches" blocks main window after dismiss in iOS 13.6

Describe the bug
I'm using bottomFloat with EKAttributes.screenInteraction = .absorbTouches.
In iOS 13.6, if the user swipe the entry down to dismiss, after the view disappears, the entire main window is blocked to touch.
From my q.a it seems that the EKAttributes rootViewController is still on the screen and receives touches.
In iOS 13.2 everything work as expected.
Expected behavior
The entry window is dismissed and the the main window views receives touches.
Additional context
var attributes = EKAttributes.bottomFloat
        attributes.displayMode = .inferred
        attributes.displayDuration = .infinity
        attributes.screenBackground = .color(color: EKColor.init(light: UIColor(white: 100.0/255.0, alpha: 0.3), dark: UIColor(white: 50.0/255.0, alpha: 0.3)))
        attributes.entryBackground = .color(color: .white)
        attributes.screenInteraction = .absorbTouches
//        attributes.entryInteraction = .absorbTouches
        //attributes.scroll = .enabled(swipeable: false, pullbackAnimation: .jolt)
        //attributes.scroll = .edgeCrossingDisabled(swipeable: true)
        attributes.scroll = .enabled(swipeable: true, pullbackAnimation: .jolt)
        attributes.entranceAnimation = .init(
            translate: .init(
                duration: 0.5,
                spring: .init(damping: 1, initialVelocity: 0)
            )
        )
        attributes.exitAnimation = .init(
            translate: .init(duration: 0.35)
        )
        attributes.popBehavior = .animated(
            animation: .init(
                translate: .init(duration: 0.35)
            )
        )
        attributes.shadow = .active(
            with: .init(
                color: .black,
                opacity: 0.3,
                radius: 6
            )
        )
        attributes.positionConstraints.size = .init(
            width: .fill,
            height: .ratio(value: 0.6)
        )
        attributes.positionConstraints.verticalOffset = 0
        attributes.positionConstraints.safeArea = .overridden
        attributes.statusBar = .dark

        return attributes

@patzootz could you try out release 1.2.4? Please see related changes under CHANGELOG

Hi Daniel, sorry for the late reply.
I've updated to 1.2.6 and it looks fixed.
Thank you so much for this wonderful library.
Kind regards
On Tue, Sep 1, 2020 at 12:58 PM Daniel Huri<EMAIL_ADDRESS>wrote:

@patzootz https://github.com/patzootz could you try out release 1.2.4?
Please see related changes under CHANGELOG
https://github.com/huri000/SwiftEntryKit/blob/master/CHANGELOG.md#124
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/huri000/SwiftEntryKit/issues/297#issuecomment-684698928,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA5WCJHLDVES7OSA3NFJGJTSDTATZANCNFSM4P7O6DPQ
.


Loss value in the progress bar is wrong when accumulate_grad_batches > 1

🐛 Bug
The loss value reported in the progress bar is the_correct_loss_value / accumulate_grad_batches, so this value is wrong when accumulate_grad_batches > 1.
This is happening because here the loss is divided by accumulate_grad_batches, then here the running loss is the mean of these losses.
To fix this, either remove the first line (no division by accumulate_grad_batches) or replace mean with sum in the second line.
To Reproduce

Train any model with accumulate_grad_batches=1 and note the loss value reported in the progress bar
Train the same model with accumulate_grad_batches=2 and half the batch size,  now the loss value in the progress bar will be half the value from step 1.

Expected Behaviour
The loss in steps (1) and (2) should be the same
Environment
pytorch-lightning==v0.8.5

duplicate of #2569?


Data engine OMAS - issue #1831

I have no idea why previous PR was failing. I cherry-picked the commits to make a new one now.

I am running a local maven build now to see if there are any failures.

I am running a local maven build now to see if there are any failures.

All good with the build? Is it ok to merge?

I am running a local maven build now to see if there are any failures.

All good with the build? Is it ok to merge?

Still running even though I skipped the FVT.
My laptop is a bit slow now. I will let you know when it is finished.

Still running the build. :(

Still running the build. :(

Do you want me to merge it anyway?

Still running the build. :(

Do you want me to merge it anyway?

The build just finished and done successfully.
Go ahead. Thanks


Highway not visible if its also part of a boundary relation when boundaries are disabled in the map

When a way is both a highway and a member of boundary=administrative relation, the highway is not visible in the map when the boundary is disabled in the Map features.

Tested in preview/master in this location.

Thanks for reporting @maning
We have some existing logic in the feature matching code for the "rail" and "past_future" rules, so I just added it to the "boundaries" rule too.
When these features are shared with highways, iD will treat them as highways.


Fix the large number of clippy lints

Description
Cleans up the hundreds of clippy lints, these are highly distracting if developing and compiling using cargo clippy rather than cargo check. The majority are rather simple and minor fixes such as needless borrows.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Needs a rebase. Double check that the generator doesn’t produce more code that brings those warnings back too.

Needs a rebase. Double check that the generator doesn’t produce more code that brings those warnings back too.

Have rebased and looks all good 👍


How to support https and base Auth

as title
By command as below:
$ curl --user  es001:pwd001 -XGET 'https://support.xxxxxx.com/dev/elasticsearch'

To use HTTP Basic Auth, use the SetBasicAuth configuration option. It's described here: https://github.com/olivere/elastic/wiki/Configuration

from example code, may be it doesn't support https?
`Here's a full example of configuring a new client:
// Obtain a client for an Elasticsearch cluster of two nodes,
// running on <IP_ADDRESS> and <IP_ADDRESS>. Do not run the sniffer.
// Set the healthcheck interval to 10s. When requests fail,
// retry 5 times. Print error messages to os.Stderr and informational
// messages to os.Stdout.
client, err := elastic.NewClient(
elastic.SetURL("http://<IP_ADDRESS>:9200", "http://<IP_ADDRESS>:9200"),
elastic.SetSniff(false),
elastic.SetHealthcheckInterval(10*time.Second),
elastic.SetMaxRetries(5),
elastic.SetErrorLog(log.New(os.Stderr, "ELASTIC ", log.LstdFlags)),
elastic.SetInfoLog(log.New(os.Stdout, "", log.LstdFlags)))`
If it support https, , example  code like as below:
`Here's a full example of configuring a new client:
// Obtain a client for an Elasticsearch cluster of two nodes,
// running on <IP_ADDRESS> and <IP_ADDRESS>. Do not run the sniffer.
// Set the healthcheck interval to 10s. When requests fail,
// retry 5 times. Print error messages to os.Stderr and informational
// messages to os.Stdout.
client, err := elastic.NewClient(
elastic.SetURL("https://<IP_ADDRESS>:9200", "https://<IP_ADDRESS>:9200"),
elastic.SetSniff(false),
elastic.SetHealthcheckInterval(10*time.Second),
elastic.SetMaxRetries(5),
elastic.SetErrorLog(log.New(os.Stderr, "ELASTIC ", log.LstdFlags)),
elastic.SetInfoLog(log.New(os.Stdout, "", log.LstdFlags)))`

Because in front of the elasticsearch, nginx do reverse proxy (based on https)

I have been test it, it support https is ok. :)


Add access to App within LogPlugin::update_subscriber

Objective
In my library, bevy_dev_console I need access to App within LogPlugin::update_subscriber in order to communicate with the App from my custom Layer.
Solution
Give access to App.

Changelog

Added access to App within LogPlugin::update_subscriber

Migration Guide
LogPlugin::update_subscriber now has a &mut App parameter. If you don't need access to App, you can ignore the parameter with an underscore (_).
- fn update_subscriber(subscriber: BoxedSubscriber) -> BoxedSubscriber {
+ fn update_subscriber(_: &mut App, subscriber: BoxedSubscriber) -> BoxedSubscriber {
      Box::new(subscriber.with(CustomLayer))
  }

Not the most elegant of communication mechanisms, but I can see the value.
Can you add a test and/or example demonstrating this?

I'm not sure if my current solution for app-layer communication is good enough to be featured in an example.
My current solution is to use a Arc<Mutex<T>> where there are 2 instances, one inside the Layer and one in a Resource, this allows information to be tranferred from the Layer to the Resource. I find this solution not that good and more of a bandaid to make it work. (I do not like Arc<Mutex<T>>)

I found a better solution using mpsc channels. Will create an example soon.

Demonstrate that you can log in arbitrary systems: maybe add a couple of buttons that each produce a different log level when pressed?

Respond to the produced log levels in the follow-up system, rather than just printing them. A pop-up would be ideal, but if that's too tricky maybe just change the text on screen to match.

Swap the filter to show how to only catch errors.

I feel like this is a bit out of scope of the log_layers_ecs example. I only wanted to show how you can transfer logs from the tracing layer to the ECS, nothing else. Everything else can be left as an exercise left to the reader.

I only wanted to show how you can transfer logs from the tracing layer to the ECS, nothing else.

In isolation, this feature doesn't seem useful, either to maintainers or to users. They'll read the example, wonder "hmm I wonder what that would be good for" and move on (or try and delete the underlying functionality. Focusing on a specific tangible use case gives us the freedom to redesign the API to better support that use case, rather than having to guess about how it relates to the actual thing we want to do.
It's okay to do a simplified version of this (no buttons, no pop-up), but I want to make sure the intent is preserved.

The release notes are incorrect (https://bevyengine.org/learn/migration-guides/0-13-to-0-14/#add-access-to-app-within-logplugin-update-subscriber)  because this change has been superseded by https://github.com/bevyengine/bevy/pull/13159
Cc @alice-i-cecile

The correct way to fix that is to file a PR request to the bevy-website repo to update the previous migration guide. This note is helpful though.


How do I use the same content_type source to create new data?

For example, one of my content_types has an attribute that is an array in each entry and I want to take all the arrays and create a new directory of new yamls. For example,
partner
{
   ....
   projects: [ ... ]
}

I want to map through each partner and create a directory of data with just projects.

Hey @dagumak,
Each entry will create a YAML file, if you want to have other content types mapped, you need to add them to the mapped content types and ensure you're fetching those entries.
Cheers


Added sudo: required to travis.yml.

We need to specify sudo: required, or else TravisCI will use its container based infrastructure (for new repos), and will fail because it doesn't allow sudo.
I've filed an APT source whitelist request. Once it has been approved, we can use the apt addon instead of using sudo apt-get ...

Thx


corrected farming check patches & harvest reminder dm

Description:
made the wording grammatically correct because the patches are plural.
example:
current:
12 mysterious tree is ready to be harvested
my fix:
12 mysterious tree are ready to be harvested
Changes:

changed is to are

Other checks:

[x] I have tested all my changes thoroughly.


Improve wifi_getApEnable

Get enabled status by checking hostapd interface status.
Reading interface UP flag was misleading as inteface man not be configured by hostapd and has UP flag set.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/16974/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/24357/ started

https://jenkins.code.rdkcentral.com/job/build-component/60005/ started.

Smoke tests for ['build-tur-bb'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/130327/

Smoke tests for ['build-rpi-broadband'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/130326/

https://jenkins.code.rdkcentral.com/job/github-triggered/24575/ started

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/17156/ started

https://jenkins.code.rdkcentral.com/job/build-component/60304/ started.

Smoke tests for ['build-rpi-broadband'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/130806/

Smoke tests for ['build-tur-bb'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/130807/


Digitalstrom Eltako Multisensor via Enocean

Hi Mat,
I started working with Homeassistant and Digitalstrom the last days. The integration went smoothly.
And it is pretty impressive to have almost all SmartHome Devices including Digitalstrom under a common hood.
There is only one issue: In my installation there is an Eltako Environment Sensor connected via EnOcean to Digitalstrom. Within Digitalstrom I can see all the values like Temperature, Wind Speed, Rain, ...
In the your integration the values are also shown but will never updated, except the Rain indicator.
The Other values stay the same as on restart of the plugin.
In my installation I still use the dss10 / dssip setup.
Do you have any suggestion?
Thanks and best regards,
Christoph

Hi Christoph,
Can you send me a debug log? You can follow these steps.
Thanks

home-assistant_digitalstrom_2024-06-21T08-23-41.106Z.log
Hi Mat,
see attached the requested log-
Thaanks

Please test if the problem is fixed in v0.0.11
Thanks

It look like the fix solved the problem.
Thanks a lot!
Christoph


#263 Reset pooled components when replacing

Attempted fix for #263 where adding a Poolable component that replaces an existing component does not call reset() or return it to the pool.
This change modifies the return type of the package-private removeInternal so may potentially break client code that is using it.

I think it's fine breaking things that are package-private in this context. Thanks a lot for your PR!!


Gmac rx buf len fix

gmac rx dma buffer is 64 byte aligned, so mix gmac_rx_unitsize to be aligned with that.
Relocate the UNITSIZE defines after the GMAC_MAX_FRAMELEN define to be able to use that

Changed the macro name to clarify alignment is related to size, not start address.


feat: Support filtering on array of primitive types

Filtering on primitive array types
Primitive arrays can be nested i.e. part of objects

Syntax to query remains the same,

For nested Arrays: {"filter":{"obj.arr_type_str":"foo"}}
For arrays on top level: {"filter":{"arr_type_str":"foo"}}

Codecov Report
Base: 31.82% // Head: 31.91% // Increases project coverage by +0.09% :tada:

Coverage data is based on head (85aa5d2) compared to base (b661874).
Patch coverage: 46.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   31.82%   31.91%   +0.09%
==========================================
  Files          96       96
  Lines       11281    11448     +167
==========================================
+ Hits         3590     3654      +64
- Misses       7369     7464      +95
- Partials      322      330       +8

Impacted Files
Coverage Δ

query/filter/selector.go
16.47% <0.00%> (-1.96%)
:arrow_down:

server/services/v1/query_runner.go
4.50% <0.00%> (-0.02%)
:arrow_down:

server/services/v1/search_indexer.go
48.03% <0.00%> (-0.72%)
:arrow_down:

value/value.go
42.00% <0.00%> (-6.56%)
:arrow_down:

schema/schema.go
62.92% <36.36%> (-5.91%)
:arrow_down:

query/filter/filter.go
53.43% <43.75%> (-1.87%)
:arrow_down:

server/metadata/tenant.go
35.84% <44.11%> (+0.20%)
:arrow_up:

schema/collection.go
69.44% <72.72%> (+0.17%)
:arrow_up:

schema/fields.go
78.17% <76.74%> (-2.41%)
:arrow_down:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


massive update

added render event
added two beginner level tutorials
added ModAPI.promisify, allowing for using @Async methods
Fixed behavior in relation to Object.keys(), in, and a variety of other JS features on BaseData proxies.
Added getCorrective() and isCorrective() to add datas

based


fix qbits backend get wrong workspace malloc size when using Release compile Flag

Type of Change
feature or bug fix or documentation or others: bug
API changed or not: not
Description
detail description
JIRA ticket: https://jira.devtools.intel.com/browse/NLPTOOLKIU-977
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
qbits int8 compute-type linear can execute normally with Release compile Flag.
How has this PR been tested?
tested on 335T
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed: no

BTW, should be csrc not cscr

BTW, should be csrc not cscr
nice eyesight

UT：https://github.com/intel/intel-extension-for-transformers/actions/runs/6662610298


Question about input data while training convertor

Hi,
Thanks for the great idea of your works! Here is a question.
When training the convertor, the paper shows that lots of audio all collected. So for a sample like ( text_1, audio_1 ), what's the input audio of the convertor(encoder)? audio_1 or the audio_x generated by the base tts using the text_1?
* if audio_1, it seems that input equals output?
* if audio_x, would the convertor too strongly related to the base TTS (the generated voice) ?

looking for your reply. thanks again.

It's audio_1

It's audio_1

Thanks. Seems that KL between IPA sequence features and Z really works.

It's audio_1

Thanks. Seems that KL between IPA sequence features and Z really works.

Sorry for another question: what's the reference audio during convertor training? Also the audio_1? or other audio of the same speaker?

It's also audio_1

many thanks.


Updating dependencies to support Wicket 7

Required change to support the new version of Wicket and Wicket-webjars.

Michael Haitz » wicket-clientside-logging #85 SUCCESS
This pull request looks good
(what's this?)

@l0rdn1kk0n Please add me as collaborator here so I can merge the PR and publish new version.
Thanks!

0.4.0 is on its way to Maven Central.
Enjoy!
@l0rdn1kk0n Thanks!


pct_change specifies fill_method='pad'

Don't rely on default argument for fill_method as it was deprecated in Pandas 2.1.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9da4947) 73.76% compared to head (a3a16a2) 73.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   73.76%   73.71%   -0.05%
==========================================
  Files          24       24
  Lines        1616     1613       -3
==========================================
- Hits         1192     1189       -3
  Misses        424      424

Flag
Coverage Δ

unittests
73.71% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@rickecon @jdebacker I noticed that the linting check is failing on files I didn't change.  Do you want me to submit a PR that gets linting passing again? I saw this deprecation warning when running the example and thought it would be a good way to kick the tires. Let me know what makes sense.

@talumbau I appreciate you opening another PR to fix the formatting.  We use black with the 79 character line option.  If you upgrade to the most recent black version and run black -l 79 ./ from the OG-USA directory, this should resolve the linting failures.

@talumbau. Yes. We just merged a PR into OG-Core (PR #898) that set the black requirement in environment.yml to black>=24.1.1. We found that black version 23 formatted differently. We also might need to restrict the Python version in OG-USA to be <3.12.

@talumbau @jdebacker. The change in this PR has been added to PR #89, along with another line in the macro_params.py module that required a similar update. I am closing this PR.


Migrate some ledgers metadata changes to an independent class

Main issue: https://github.com/apache/pulsar/issues/9425
Eliminate direct touch of ManagedLedgerMetaStoreImpl.ledgers and ManagedLedgerMetaStoreImpl.metadataMutex from outside is a target to achieve but is hard to be finished in one patch, so they are still used somewhere in this patch.

/pulsarbot run-failure-checks


Retrieve bg_music from the tree to make music work

Because otherwise it's loaded way late, so even :ready
won't work with it.
This code needs some TLC later.

Fixed by #170.


Redis no auth

Add option to have no auth token when connecting to redis
rational:

aws elasticache does not support auth tokens without ssl
ssl requires a truststore? ect to be set up

is this an ideal solution? no
did it work: yes
am i proud: no
notes:
the SECRET_I_DONT_MATTER envar to make the lense-cli create the secret properties file. This is a hack.
next steps is to try and get redis and ssl working.

closing this PR as there is no need to change this part. more details in https://github.com/Landoop/kafka-helm-charts/pull/100

Not sure if #100 fixes as the aws elasticache is just requiring the connection to tls upgrade, so I dont think it uses a trust certificate. that is I think it just tls encrypts the traffic (I tested with stunnel and telnet) but does not protect against MITM. so yeah not ideal, but all traffic should be within your VPC...

Some context:

As long as the Redis clients support TLS protocol, you don't have to modify your applications other than making a small configuration change to your Redis clients. The change to your Redis client is simple, for example, with a Jedis java client, while creating a Redis connection, you need to pass isTls=true flag.

This is by AWS official docmentation for Encrypt data in transit https://aws.amazon.com/about-aws/whats-new/2017/10/amazon-elasticache-for-redis-now-supports-in-transit-and-at-rest-encryption-to-help-protect-sensitive-information/

yeah i saw that, also this can be picked up automatically by the jedis client by using a protocol of
rediss:// in th uri see https://github.com/xetorthio/jedis/blob/master/src/test/java/redis/clients/jedis/tests/SSLJedisTest.java#L51
but the way the connector sets up the connection, I think this is lossed.

Jedis lets you specify SSL in the URI or an explicit flag. The connect now explicitly sets the flag.


Plugin is not working on Python <3.7, but this is not mentioned in readme

Python starts from 3.7? Seems, plugin fails on Python 3.6.8 on line:
from __future__ import annotations
Is it possible to add information about requirements in readme?
/home/andy/PROJECTS/events-registration/.env/bin/flake8 --max-complexity 10 --max-cognitive-complexity=3 /home/andy/PROJECTS/events-registration/backend/backend
Traceback (most recent call last):
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/plugins/manager.py", line 158, in load_plugin
    self._load()
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/plugins/manager.py", line 135, in _load
    self._plugin = self.entry_point.load()
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/entrypoints.py", line 82, in load
    mod = import_module(self.module_name)
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 674, in exec_module
  File "<frozen importlib._bootstrap_external>", line 781, in get_code
  File "<frozen importlib._bootstrap_external>", line 741, in source_to_code
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8_cognitive_complexity/checker.py", line 1
    from __future__ import annotations
    ^
SyntaxError: future feature annotations is not defined

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/andy/PROJECTS/events-registration/.env/bin/flake8", line 8, in <module>
    sys.exit(main())
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/main/application.py", line 380, in _run
    self.initialize(argv)
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/main/application.py", line 363, in initialize
    self.find_plugins()
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/main/application.py", line 199, in find_plugins
    self.check_plugins.load_plugins()
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/plugins/manager.py", line 410, in load_plugins
    plugins = list(self.manager.map(load_plugin))
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/plugins/manager.py", line 297, in map
    yield func(self.plugins[name], *args, **kwargs)
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/plugins/manager.py", line 408, in load_plugin
    return plugin.load_plugin()
  File "/home/andy/PROJECTS/events-registration/.env/lib/python3.6/site-packages/flake8/plugins/manager.py", line 165, in load_plugin
    raise failed_to_load
flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "CCR" due to future feature annotations is not defined (checker.py, line 1).

Process finished with exit code 1

Thanks for the report!
Version 0.0.2 of the plugin supports python 3.6 + readme has badge about it :)


⚠ TTS Generation has degraded performance

In 567742c, TTS Generation ($SECRET_TTS_TEST_GEN_URL) experienced degraded performance:

HTTP code: 200
Response time: 516 ms

Resolved: TTS Generation performance has improved in 142d157 after 5 minutes.


Feature: Display error message when settings file isn't valid

If the json file isn't valid, we should notify the user of the issue.
Requirements

Display modal if the settings file isn't valid with a description of the issue
Include button to reset settings
Include button to close app

As i told in #562 we should unify all exceptions(replace JsonSerializationException with Exception or add JsonReaderException), so if there will be any json parsing error, just reset this json to default.

But if we reset the json file, the user loses all his profiles and we will have to store a default json file. If the terminal loading process goes wrong for whatever reason, i would simply default to cmd and log, that there was an error. So the user can investigate his json file, if he want's to fix it and if not, he gets the cmd terminal.

@lampenlampen That sounds like a better idea.

@yaichenbaum we can add an interface, so user can edit terminals through settings, instead of modifying json file manually.

That would be a nice addition, however it would still make sense to include a json file for someone who wants to use the json format.

Maybe we should get rid of the json file, especially if we autodetect the common terminals (powershell (core), Winodws Terminal).
And for the few users, who want's to use a custom one, they can choose custom and then we present them an input box to specify the path.
I choosed json, because i thought then they can specify multiple terminals and icons and so on, but i don't think we will use that customization.
If a user want's control over multiple terminal, he will install Windows Terminal or terminus, ...

Maybe we should get rid of the json file, especially if we auto-detect the common terminals (powershell (core), WindowsTerminal).
And for the few users, who want's to use a custom one, they can choose custom and then we present them an input box to specify the path.
I choosed json, because i thought then they can specify multiple terminals and icons and so on, but i don't think we will use that customization. If a user want's control over multiple terminal, he will install Windows Terminal or terminus, ...

@lampenlampen that is a possibility, and once support is added for importing and exporting the settings json file, users can technically add a custom terminal path even it's not detected automatically by Files.

@d2dyno1 can you confirm that this issue was resolved in your recent PR?

It's not been resolved yet. I'm working on this. Simple try-catch should be enough.

I think this issue should be modified to not conflict with #10935, and leaving this as just the error modal and reset

I updated the requirements as per @hecksmosis feedback.

Hey all! If no one's currently working on this, I want a go at implementing this feature! It'll be my first attempt at contributing to an open-source project, so I'm pretty excited honestly! -M

Sure go ahead

I assigned you 🙂

Heads up that I am looking into this.

Heads up that I am looking into this.

If Bandit's taking a shot, feel free to give it to em! I couldn't quite figure my way around everything while taking my shot

What's the status of this issue?

Available for work
Get Outlook for iOShttps://aka.ms/o0ukef

From: zackatack108 @.>
Sent: Wednesday, November 8, 2023 12:11:39 PM
To: files-community/Files @.>
Cc: Estell, Jerrod Victor @.>; Comment @.>
Subject: Re: [files-community/Files] Feature: Display error message when settings file isn't valid (#710)
[EXTERNAL EMAIL]
What's the status of this issue?
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/files-community/Files/issues/710*issuecomment-1802578161__;Iw!!JmPEgBY0HMszNaDT!oDmUjHFn6i4OFuPxQzgY6yUGIpgByVeCcOk8PgXRCWfVYsSf7luCyZXTLiR9Tvx4taBWc59o6sqGN6krf0kbCbKh8bxL$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A35NWDLJXEXBAS3FZKOGESDYDPRPXAVCNFSM4MSAOJVKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBQGI2TOOBRGYYQ__;!!JmPEgBY0HMszNaDT!oDmUjHFn6i4OFuPxQzgY6yUGIpgByVeCcOk8PgXRCWfVYsSf7luCyZXTLiR9Tvx4taBWc59o6sqGN6krf0kbCS6bh5EC$.
You are receiving this because you commented.Message ID: @.***>

It hasn't been implemented yet

I might implement this feature in a week or something but I'm not sure if I will get it working. I've tried doing something with it today but to no avail. There's so much stuff involved with creating a new dialog and making it work. I'll try to do a research on this one and come up with a solution.
If I'm not done within a week or so then it would probably mean that I stopped working on the issue and it's free for taking.

Concept from Windows Terminal:

Working on it.

The initial work:

I was working on this and make it work correctly but current implementation of json serializer for settings is not intended to display UI from their own classes and those classes are exposed as abstract classes, which means I should've add an event to notify of the parse error to AppModel after UI is loaded to prevent the dialog from having to be tried to show before UI thread starts.
@mdtauk Do you have design concept or have something to tell me before working on again, such as adding what buttons and displaying what messages?


Tooltip: Add TabContent render fragment to MudTabPanel

Description

As discussed in #3913 and #4015, the existing "embedded" tooltip of the MudTabs component is limited as it is impossible to specify properties for the Tooltip, such as color. This PR is a demo/test of a possible solution to this problem that provides a TabContent render fragment on each MudTabPanel, which is rendered accordingly by the parent MudTab component if it exists.
This is the solution originally proposed by @Garderoben https://github.com/MudBlazor/MudBlazor/pull/3913#issuecomment-1036982747
This is a breaking change as it makes the existing Tooltip property obsolete and any text provided to this property will be ignored.
Other components that similarly use tooltips may need similar changes for consistency.
How Has This Been Tested?

This has been tested visually thus far, tests will ultimately need to be added.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

I would like @Garderoben and @henon to weigh in on this if possible. 😄
Please note this is a draft and I understand significant changes may need to be made.

This is a breaking change as it makes the existing Tooltip property obsolete and any text provided to this property will be ignored.

Would it be possible to define a default tab content RF which displays the value of Tooltip? Then it wouldn't even be a breaking change and all we need to do is document that Tooltip is ignored if TabContent is defined.

@henon That is a possibility, I will look into it tonight if I have time.

What I don't like is if someone uses the TabContent and puts a tooltip in it, the tooltip ends up inside the mud-tab instead of outside of it, so the hover region to trigger the tooltip is smaller:

vs

I'll think about what the best solution to this is.

@henon I've added a possible solution. I have mixed feelings about it just because it adds some extra complexity. That aside, it solves the problem of custom tooltips not wrapping the entire tab and the TabContent render fragment can still be used without involving the TabWrapperContent.
Let me know what you think.

I say sure why not, but I guess the documentation is a bit sparse right now. If I am a new user and look at it I don't really see what this new parameter can do for me and why a wrapper around the TabContent is even necessary in the first place.
If you could explain a bit more in the <summary>  and maybe mention the use-case it was added for.

I worked on some docs changes but hadn't pushed them yet, actually! I was waiting for your thoughts on the overall idea first. 😄  I have also added to the summary. Let me know what you think.

Thanks, excellent summary.
@Garderoben @just-the-benno I think this one can be merged.


Email Verification

TODO: When going to the link in the email, the user should go to a separate page requesting they log in first.

TODO: When going to the link in the email, the user should go to a separate page requesting they log in first.

TODO: Testing that the emails properly go out


getPrebuiltLambda() fails when node is installed in a file path that contains white spaces

I have node installed in C:\Program Files\nodejs\node.exe
The prebuilt lambda function fails on every build as the exec function is attempting to execute C:\Program instead of C:\Program Files\nodejs\node.exe.
The impact is the docker image is build on every single run locally, taking more time.
  console.log
    Try to get prebuilt lambda

      at getCode (node_modules/cdk-ecr-deployment/src/index.ts:49:15)

  console.log
    "C:\Program Files\nodejs\node.exe" C:\zzz\node_modules\cdk-ecr-deployment\lambda\install.js C:\zzz\node_modules\cdk-ecr-deployment\lambda\out

      at getCode (node_modules/cdk-ecr-deployment/src/index.ts:53:7)

'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
  console.warn
    Can not get prebuilt lambda: Error: Command failed: C:\Program Files\nodejs\node.exe C:\zzz\node_modules\cdk-ecr-deployment\lambda\install.js C:\zzz\node_modules\cdk-ecr-deployment\lambda\out
    'C:\Program' is not recognized as an internal or external command,
    operable program or batch file.

function getPrebuiltLambda(outputDir: string): boolean {
  try {
    console.log('Try to get prebuilt lambda');

    const installScript = path.join(__dirname, '../lambda/install.js');
    child_process.execSync(`${process.argv0} ${installScript} ${outputDir}`);
    return true;
  } catch (err) {
    console.warn(`Can not get prebuilt lambda: ${err}`);
    return false;
  }
}

One potential fix is to quote the process parameter:
child_process.execFileSync(process.argv0, [installScript, prebuiltPath]);

https://github.com/cdklabs/cdk-ecr-deployment/blob/fbeeee17a1f927001ee244cb59ff8ffe0b4c4763/src/index.ts#L164

The lack of escaping will also cause problems when __dirname includes special characters, such as spaces, ampersands, redirects, pipes, etc.


Add schema/rebuild console command

This should work like schema/clear command + build and save new schema

See https://github.com/yiisoft/yii-cycle/blob/master/docs/en/console-commands.md

I have a question with this part: "build and save new schema" for make a build, is there a command right now?.

I have a question with this part: "build and save new schema" for make a build, is there a command right now?.

cycle/schema/clear & cycle/schema/php fileName

I sent a new PR :)

I sent a new PR :)

👍
I did not immediately understand that you are asking a question in order to make a PR. So i would write "just clear cerrent chema and read a new schema" :)


ERROR: syntax: extra token "activate" after end of expression

Getting this error when I open the integrated REPL in vscode (using the Julia extension):
conda activate .CondaPkg/env
ERROR: syntax: extra token "activate" after end of expression

It seems CondaPkg is trying to activate the conda environment, automatically, but fails. This is a project that has a CondaPkg as dependency.
But something seems to be going wrong here. Not sure if the fault is with the vscode extension, or is something CondaPkg.jl specific?

I have the same issue. CondaPkg isn't doing that, I think it's VSCode for some reason - but I've never worked out why.
It's a mystery. I've never looked into it much, since it's just a mild annoyance in the Julia REPL.


Node restarts mid test?

Hi I'm having an issue where the node restarts after 10 runs (which it should) however it does it mid test cycle.  Any way to force it to check, possibly longer, for incoming data before killing my tests?

Hi,
I'm also interesting in by this feature.
Before restarting the node, it would be good to wait 1 minute : if some tests are triggered it postpones the restart, if no test, it schedules the restart.

I am very interested in this feature as well. However, it would be a decent sized change I think.

@VinceBZH @sinisterrook I have updated the title and tagged this as enhancement.

Adding smarter checks to see if the node is currently busy. If there is another test running on the node, wait for the test to finish but don't allow any new sessions to start
https://github.com/groupon/Selenium-Grid-Extras/commit/55c62f660f1a0d4858f4e39afae274b98b3a7d29


Notoriety Tracking Timer

Would be useful to track how long remains to burn off notoriety.
Need to research whether we can get CMDRs notoriety level: Journal / CAPI / Status file

After research, the game only provides notoriety on initial login, so there is no reliable tracking of when it is assigned. We would therefore have to guess when the player gains notoriety, and how much, from journal entries which is likely to be too unreliable to be useful.
So closing as won't do.


Confirm that FAM can acknowledge and accommodate the new Test and Prod URLs

Describe the task
A clear and concise description of what the task is.
Acceptance Criteria

[ ] first
[ ] second
[ ] third

Additional context

Add any other context about the task here.
Or here

Closing it, since it's in the done column.


An statspage + homepage at the IP of the bot

Progress
So below I did put some quick progress list of what I still want to do and what already is done. (locally and/or at draft1).
BUT, I'm not promosing everything that comes below will be released or be made. Everything depends on the will and free time I have.
Note: All feature request are and must be made by using the ISSUES tab.
Major Updates

[x] #26
[x] #37

[x] Back-End
[x] Front-End - Show logging Visually

[ ] MAYBE!!! Should change the way details are logged. Instead of object, just a string with brief description of what happend.
-> ex. Instead of player: ABC, reason: Bla Bla Bla ||| => Write just "Player ABC has been banned with reason 'Bla Bla Bla'!"

[ ] #38

[ ] Add a field in user for those kicks, warns, and bans. So they get logged. + Audit logging (this is already made.)
[ ] Front-End

[ ] Show on Player Profile
[ ] Show on the player tables (via badge numbers)

[x] Back-End  (basically this is ready, via Audit...)

[ ] #39

[ ] Be able to add custom banner.
[ ] Be able to add custom logo
[ ] Be able to choose custom color palet

[x] #40

[x] Kick

[x] Front-End
[x] Back-End

[x] Ban

[x] Front-End
[x] Back-End

[x] Warn

[x] Front-End
[x] Back-End

[x] Disband Squad

[x] Front-End
[x] Back-End

[x] Kick From Squad

[x] Front-End
[x] Back-End

[x] Get Current Map

[x] Front-End
[x] Back-End

[x] Set Current Map

[x] Front-End
[x] Back-End

[x] Get Next Map

[x] Front-End
[x] Back-End

[x] Set Next Map

[x] Front-End
[x] Back-End

[x] Get Server Info

[ ] Front-End (Only API wise ?)
[x] Back-End

[x] Get Players List

[x] Front-End (Players Table)
[x] Back-End

[x] #41

[x] Permission Schema
[x] Permissions check per action (kick, ban, warn, etc)
[x] Permissions check for pages/sections
[ ] Add user to permission
[ ] Remove user from permission
[ ] Add user to which pages user can see
[ ] Add user to what actions user can do

[ ] #42

[ ] Feature: Clan recruitment through the dashboard (apply to clans)
[ ] Feature: Clan management through the dashboard (add/delete members and add/delete whitelist from members )

[ ] #43
[x] #44
[ ] #45

[ ] Personal players stats
[ ] General server stats
[ ] Leaderboards
[ ] Badge System

[ ] Linked with Discord permissions

[ ] #46

[x] Get server information for API
[ ] Sync warns
[ ] Sync kicks
[ ] Sync Bans
[ ] Export bans to different lists?

Minor Updates/Features:

[x] Feature: Admin send broadcast.
[x] #36

[x] Remove perms from whitelist groups
[x] Add perms to whitelist groups
[x] Import your existing admins.cfg
[x] Get a URL generated with a custom token to put in your remoteadmin config file @ your server

[x] Be able to regenerate a new one in case leaked.

[x] Add new group to whitelist
[x] Remove a group
[x] Add new whitelisted to an user/player
[x] Remove a whitelist from a user/player

[x] #27
[x] #28
[ ] #29
[x] #30
[ ] #31
[x] #32
[x] #33
[x] #34
[x] #35
[ ] More should come here soon...

Preview from the new dashboard

Hello folks.
I'm still in vacation but I thought I could use my free time at evenings on this side project.
Progress
So below I did put some quick progress list of what I still want to do and what already is done. (locally and/or at draft1).
BUT, I'm not promosing everything that comes below will be released or be made. Everything depends on the will and free time I have.
Note: All feature request are and must be made by using the ISSUES tab.
Major Updates

[x] Major: Dual logging with Steam + Discord (currently forced to do steam AND discord login to use the panel, might change this to be toggleable)
[x] Major: Logging all activity to MongoDB (Audit)
[ ] Major: Permissions system for admins.
[ ] Major: Permissions system for clan leaders.
[ ] Major: Players be able to interact with eachother from dashboard/website | Instagram like thing?.

Minor Updates/Features:

[x] Feature: Admin send broadcast.
[ ] Feature: Admin add whitelist.
[ ] Feature: Admin change current layer.
[ ] Feature: Admin set next layer.
[ ] Feature: Admin set a map ratation (or update it).
[x] Feature: Admin check current players with team names and squad names and status.
[ ] Feature: Admin lock and unlock squads from current players list.
[ ] Feature: Admin disband squads from current players list.
[ ] Feature: Admin kick players from current players list.
[ ] Feature: Admin ban players from current players list.
[ ] Feature: Admin ban player by SteamID (offline).
[ ] More should come here soon...

Screenshot of the progress (whitelist manager still WIP) 80%

Seperated every task point to an issue so it is easy to track every one separately!


MenuItem with Flutter 3.0.0

With new Flutter 3.0.0 there is error on MenuItem class name.
Need rename on import. Example: import 'menu_item.dart' as omi; and use as omi.MenuItem.

@IgorGZd
Thank you for teaching me! I Fixed the issue and updated v1.1.1 to pub.dev. Look carefully at the change log.
https://pub.dev/packages/flutter_admin_scaffold/changelog
This issue closes.

Thanks for the very quick solution!


Add zpages and pprof data documentation

What does this PR do?
The data was added to the flare in #28848 and #28927. This documents it.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


net: net_addr_ntop: Clarify docstring

The string returned is definitely NUL terminated, previously was
apaprently a typo.
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

Doc-only fix, so targetting for 1.13.


RMSE

Hi Maruan,
in your examples you use the rmse on the standardized data-sets.
In your paper, are you using this definition as well?
I was experimenting a little bit with some data-sets in your paper and got near these rmse's just by also using the standardized data-sets.
There isn't any hint in your paper, just we are using the rmse.
Cheers Roman Foell

Yes, we standardized datasets in all experiments except the system identification data. A more elaborate description of the experimental setups will be available in the updated version of the paper that will appear on arXiv very soon.


AppVeyor: fail early if there is a newer one queued in this PR

Coverage remained the same when pulling cc7fa8f26e748dd28b321808ca8ec0947736c23a on teh/appveyor_cancel into 9d27503b50a0175e5cea8509b5f67267c06d4b07 on master.

and apparently the web-ui whitelist didn't work, https://ci.appveyor.com/project/timholy/images-jl/build/1.0.24 is a branch build, https://ci.appveyor.com/project/timholy/images-jl/build/1.0.25 is the PR build

I noticed that too. I already have a fix queued, but I'll wait to see how this aspect works before I add it to this PR.

I don't understand this: https://ci.appveyor.com/project/timholy/images-jl/build/1.0.26/job/a2n0qwitmjy22f9i

Oh, was that just from my force-push?

What a perfect opportunity to test this functionality!

Eternal optimist :)
The queue on the free plan is much less responsive than on the pro plan, kind of a bummer.

Oh, was that just from my force-push?

Yeah, the commit doesn't exist any more by the time it tried to check it out...

Coverage remained the same when pulling fbeb3c853179d8594beac69850e4561af021b546 on teh/appveyor_cancel into 9d27503b50a0175e5cea8509b5f67267c06d4b07 on master.

That was a branch build, which always checks out a specific sha. A PR build starts a little differently, by doing:
git fetch -q origin +refs/pull/251/merge:
git checkout -qf FETCH_HEAD

So that should still work.

Can the 32-bit build cancel the corresponding 64-bit build, too? What seems to happen is:

the 32-bit queue is shorter, and so that starts first
the 32-bit job fails quickly
one waits quite some time for the 64-bit build to get to the top of its queue; this stalls any further 32-bit builds
once the 64-bit build reaches the top of its queue, it fails quickly
only then can the next one in line start, but presumably by that point one is at the end of the queue again

They're not actually running in different queues. It's just setting an environment variable differently, which downloads 32-bit Julia instead of 64-bit Julia in subsequent commands. The VM is always 64 bit.
I'm not really sure how the queue works exactly, other than for the pro plan that base Julia is on, builds start one right after the other with at most a few seconds delay. The free plan VM's seem to take a few minutes. And sometimes cancelling builds doesn't seem to free things up completely as far as the queue is concerned, but maybe I'm imagining that.

I suspect each project has its own queue, and once one job finishes then the next one gets to go to the bottom of the "global build queue."

The logic works, though: https://ci.appveyor.com/project/timholy/images-jl/build/1.0.27/job/xfr5cmd5x1j7incp

Saw that. You might want to move it to before downloading and installing the Julia binary to finish even faster.
Also ref line 85 of http://www.appveyor.com/docs/appveyor-yml, you can add a fast_finish to the matrix to skip the 64-bit build if the 32-bit build fails. That would make sense here given the longer queue times.

You might want to move it to before downloading and installing the Julia binary to finish even faster.

I have the impression it gets Images.jl via Pkg.clone, so I'm not sure I can move it before the julia binary. (That script is inside Images.jl.) But it's a good idea, so please do correct me if I'm wrong.

I have the impression it gets Images.jl via Pkg.clone

Not exactly. It does Pkg.clone from a local filesystem path to register it with Julia's package manager in order to handle dependencies, make Pkg.build and Pkg.test work, etc. But AppVeyor (like Travis) does a git clone from the repo first thing. Try just moving the line that runs the script to first-thing under install:.
https://ci.appveyor.com/project/timholy/images-jl/build/1.0.28/job/91ch4c69dthbspfs is running the whole deal because it is a branch build, so $APPVEYOR_PULL_REQUEST_NUMBER is not set. We could implement similar logic for non-PR builds, I just haven't done so yet. This is also a planned feature by AppVeyor https://github.com/appveyor/ci/issues/38 but dunno when they'll get to it.

Coverage increased (+64.59%) when pulling 8949258e3c5786353919fac78958b355519e8404 on teh/appveyor_cancel into 9d27503b50a0175e5cea8509b5f67267c06d4b07 on master.

This is looking promising; we may have reached a local optimum.
Is there any reason for me to contact AppVeyor with what we've discovered here and see if they want to do something to make all this easier?

Sure. We could just ping @FeodorFitsner and let him know he might find our discussion here (and in https://github.com/timholy/Images.jl/pull/249) worth skimming over, unless you were planning on summarizing it.
I also learned a bit more powershell over the holidays (was messing around with some xml stuff), the API query here should be pretty simple to translate and avoid depending on that little json parser and adding a bash script to the repo. jq is available cross-platform though and I figure the Julia community is a little more familiar with bash than powershell, so my code is easier to read this way (for us at least).

Pinging @FeodorFitsner as recommended above by @tkelman. @FeodorFitsner, the aim here was to reduce the load on your servers, which I imagine is something you might appreciate. Very briefly, we added a shell script to test whether there was a more recent version of the same PR already queued, and if so to fail early (and trigger the failure across all builds). I wonder if "good citizens" who use these tricks might not lose their place in line for the commits they really care about :smile:.

Yeah, seems like a right logic. I still don't have an ETA for this feature.

Coverage remained the same at 0.0% when pulling fbeb3c853179d8594beac69850e4561af021b546 on teh/appveyor_cancel into 9d27503b50a0175e5cea8509b5f67267c06d4b07 on master.

Awesome!


[Security] Is it safe to store _lastSessionId into cookie?

I noticed that meteor-files stores the _lastSessionId into a cookie, so that calls to image urls can be verified.
This _lastSessionId is short-living. If you close a tab, it is usually gone on the server.
But i am unsure if this opens a hole for xss-attacks where it is possible to hijack a session.
Meteor does not use cookies for sessions because of that (https://blog.meteor.com/why-meteor-doesnt-use-session-cookies-e988544f52c9#.lyw0zb5j1)
Did anyone took a closer look on that?

Here is loooong discussion about this: https://github.com/VeliovGroup/Meteor-Files/issues/159

It's always a good idea to check referrer header.

Hello @macrozone ,
Can we close this one in favour of #159 ?

@dr-dimitru you can close.


Minor update for #786

Adds more detail on the return statement and clarifies the role of x and y in the guide.

Thanks @cpfiffer!