(#77) Return file path from Take Screenshot

The change looks fairly simple. As I am a bit new on PR's through GitHub perhaps my way of creating could be improved?

Hey, the changes look good to me. Even though it's a simple change, I think it would be best if you added a unit test.
For this, it would be ok if you modifies the exiting test under utests/x3270/test_screenshot.py
Let me know if you need further help

Forgive my ignorance :-) : but how should I execute this test?
If I do python test_screenshot.py in a terminal window I get
ModuleNotFoundError: No module named 'pytest_mock'

I went through the Development setup documentation and could use invoke utest to get:
utest\Mainframe3270\test_run_on_failure.py ...                           [  2%]
utest\py3270\test_command.py .......                                     [  8%]
utest\py3270\test_emulator.py ................                           [ 23%]
utest\py3270\test_status.py ..                                           [ 24%]
utest\x3270\test__init__.py ....                                         [ 28%]
utest\x3270\test_assertions.py ........................................  [ 63%]
utest\x3270\test_commands.py .........                                   [ 71%]
utest\x3270\test_connection.py ......                                    [ 76%]
utest\x3270\test_read.py .....                                           [ 81%]
utest\x3270\test_screenshot.py ...                                       [ 84%]
utest\x3270\test_wait_and_timeout.py ..............                      [ 96%]
utest\x3270\test_write.py ....                                           [100%]

So I am still a bit at a loss what is expected?

I think I get the logic of this. I managed to update the test to check for the correct filepath returned. I will also look at the atest as these also give FAILures.

I did an additional commit to my branch for utest change, invoke lint and atest changes. It looks like they are added immediately to  the PR?
@robinmatz Can you confirm?
BTW The atest fails on 2 tests looking for a specific text on screen of PUB400 if the user logging in has a different language (like me). So perhaps you should validate something else (like a menu sequence number)?

Codecov Report
Base: 94.82% // Head: 87.93% // Decreases project coverage by -6.90% :warning:

Coverage data is based on head (90c8f1d) compared to base (cd2d650).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   94.82%   87.93%   -6.90%
==========================================
  Files           4        4
  Lines         580      580
  Branches      106       87      -19
==========================================
- Hits          550      510      -40
- Misses         26       65      +39
- Partials        4        5       +1

Flag
Coverage Δ

acceptance
?

unit
87.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

Mainframe3270/x3270.py
100.00% <100.00%> (ø)

Mainframe3270/py3270.py
74.33% <0.00%> (-14.39%)
:arrow_down:

Mainframe3270/__init__.py
94.44% <0.00%> (-5.56%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@robinmatz I have resolved both your suggestions. This is also new to me. It looks like your changes are now part of this PR. They are not part of my branch so probably I need to do something additional. I will investigate.
I noticed one of your changes had to do with the ubuntu 3.7 failing. Should I be able to redo this test?
The other failing test has to do with ubuntu failing on python 3.10. Could you have a look?

I was mistaken about resolving your suggestions made them part of this PR. I will do them manually in my branch.
Is there a way to do this automatically?

I was mistaken about resolving your suggestions made them part of this PR. I will do them manually in my branch. Is there a way to do this automatically?

I reviewed your changes just now. As you correctly noticed, the suggestions I made were only part of the conversation of this PR. The way GitHub displays these suggestions might be a bit confusing at first.
As for the failing pipeline, you need not to worry about this, since the failures are not related to your changes. I will look into these on another occasion.


How to install k3s on Azure Linux?

Ask your question or provide your feedback
How to install k3s on Azure Linux? Tried to use:
curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION="v1.24.10+k3s1" sh -s - server --cluster-init --disable-selinux

But dependencies failed to install, please see detail log below.
Screenshots
Actual logs as below:
yockgen@cbl-yockgen [ ~/k3s ]$ curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION="v1.24.10+k3s1" sh -s - server --cluster-init --disable-selinux
[INFO]  Using v1.24.10+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.24.10+k3s1/sha256sum-amd64.txt
[INFO]  Skipping binary downloaded, installed k3s matches hash
[INFO]  Finding available k3s-selinux versions
[ERROR]  Failed to apply container_runtime_exec_t to /usr/local/bin/k3s, please install:
    dnf install -y container-selinux
    dnf install -y https://rpm.rancher.io/k3s/stable/common/centos/9/noarch/

*** Dependencies - container-selinux not found ***
yockgen@cbl-yockgen [ ~/k3s ]$ sudo dnf install -y container-selinux
Last metadata expiration check: 0:21:47 ago on Tue Jul  9 06:41:48 2024.
No match for argument: container-selinux
Error: Unable to find a match: container-selinux

*** Dependencies - https://rpm.rancher.io/k3s/stable/common/centos/9/noarch/ not found ***
yockgen@cbl-yockgen [ ~/k3s ]$ sudo dnf install -y https://rpm.rancher.io/k3s/stable/common/centos/9/noarch/
Last metadata expiration check: 0:22:56 ago on Tue Jul  9 06:41:48 2024.
Cannot open /var/cache/dnf/commandline-a6d7f64df8682aeb/packages/.: Is a directory

Any guidance really appreciated.

CBL-Mariner already provides the k3s package:
root [ / ]# tdnf info k3s
Loaded plugin: tdnfrepogpgcheck
Name          : k3s
Arch          : x86_64
Epoch         : 0
Version       : 1.26.3
Release       : 2.cm2
Install Size  :  72.12M (75625221)
Download Size  :  65.59M (68778323)
Repo          : mariner-official-base
Summary       : Lightweight Kubernetes
URL           : https://k3s.io
License       : ASL 2.0
Description   : The certified Kubernetes distribution built for IoT & Edge computing.

Total Size:  72.12M (75625221)

It works using the installation script also!
Output, using your command:
zcobol@mariner3 [ ~ ]$ curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION="v1.24.10+k3s1" sh -s - server --cluster-init --disable-selinux
[INFO]  Using v1.24.10+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.24.10+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.24.10+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
Created symlink /etc/systemd/system/multi-user.target.wants/k3s.service → /etc/systemd/system/k3s.service.
[INFO]  systemd: Starting k3s

Thanks!  Unfortunately, the "installation script" way not work for me, see logs below:
root@cbl-yockgen [ /home/yockgen ]# curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION="v1.24.10+k3s1" sh -s - server --cluster-init --disable-selinux
[INFO]  Using v1.24.10+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.24.10+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.24.10+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Finding available k3s-selinux versions
[ERROR]  Failed to find the k3s-selinux policy, please install:
    dnf install -y container-selinux
    dnf install -y https://rpm.rancher.io/k3s/stable/common/centos/9/noarch/

However, by added "INSTALL_K3S_SKIP_SELINUX_RPM=true", the installation script able to proceed:
curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION="v1.30.2+k3s2" INSTALL_K3S_SKIP_SELINUX_RPM=true sh -s - server --cluster-init

@yockgen what version of Mariner are you using? The script won't execute install_selinux_rpm() unless it detects a redhat, centos, oracle, fedora or suse distro. See installation script beginning line 639:
install_selinux_rpm() {
    if [ -r /etc/redhat-release ] || [ -r /etc/centos-release ] || [ -r /etc/oracle-release ] || [ -r /etc/fedora-release ] || [ "${ID_LIKE%%[ ]*}" = "suse" ]; then
        repodir=/etc/yum.repos.d
        if [ -d /etc/zypp/repos.d ]; then
            repodir=/etc/zypp/repos.d
        fi
        set +o noglob
        $SUDO rm -f ${repodir}/rancher-k3s-common*.repo
        set -o noglob
        if [ -r /etc/redhat-release ] && [ "${3}" = "el7" ]; then
            $SUDO yum install -y yum-utils
            $SUDO yum-config-manager --enable rhel-7-server-extras-rpms
        fi
        $SUDO tee ${repodir}/rancher-k3s-common.repo >/dev/null << EOF
[rancher-k3s-common-${2}]
name=Rancher K3s Common (${2})
baseurl=https://${1}/k3s/${2}/common/${4}/noarch
enabled=1
gpgcheck=1
repo_gpgcheck=0
gpgkey=https://${1}/public.key
EOF
        case ${3} in
        sle)
            rpm_installer="zypper --gpg-auto-import-keys"
            if [ "${TRANSACTIONAL_UPDATE=false}" != "true" ] && [ -x /usr/sbin/transactional-update ]; then
                transactional_update_run="transactional-update --no-selfupdate -d run"
                rpm_installer="transactional-update --no-selfupdate -d run ${rpm_installer}"
                : "${INSTALL_K3S_SKIP_START:=true}"
            fi
            # create the /var/lib/rpm-state in SLE systems to fix the prein selinux macro
            ${transactional_update_run} mkdir -p /var/lib/rpm-state
            ;;
        coreos)
            rpm_installer="rpm-ostree --idempotent"
            # rpm_install_extra_args="--apply-live"
            : "${INSTALL_K3S_SKIP_START:=true}"
            ;;
        *)
            rpm_installer="yum"
            ;;
        esac
        if [ "${rpm_installer}" = "yum" ] && [ -x /usr/bin/dnf ]; then
            rpm_installer=dnf
        fi
            if rpm -q --quiet k3s-selinux; then
            # remove k3s-selinux module before upgrade to allow container-selinux to upgrade safely
            if check_available_upgrades container-selinux ${3} && check_available_upgrades k3s-selinux ${3}; then
                MODULE_PRIORITY=$($SUDO semodule --list=full | grep k3s | cut -f1 -d" ")
                if [ -n "${MODULE_PRIORITY}" ]; then
                    $SUDO semodule -X $MODULE_PRIORITY -r k3s || true
                fi
            fi
        fi
        # shellcheck disable=SC2086
        $SUDO ${rpm_installer} install -y "k3s-selinux"
    fi
    return
}

Tested on Mariner2 and Mariner3 Beta the installer is not triggering this function, and you'll notice this in the logs [INFO]  Skipping installation of SELinux RPM

My Mariner OS:
root@cbl-yockgen [ ~ ]# cat /etc/os-release
NAME="Common Base Linux Mariner"
VERSION="2.0.20240609"
ID=mariner
VERSION_ID="2.0"
PRETTY_NAME="CBL-Mariner/Linux"
ANSI_COLOR="1;34"
HOME_URL="https://aka.ms/cbl-mariner"
BUG_REPORT_URL="https://aka.ms/cbl-mariner"
SUPPORT_URL="https://aka.ms/cbl-mariner"
root@cbl-yockgen [ ~ ]# uname -r
<IP_ADDRESS>-1.cm2

Is it possible to added Mariner flag on line 639 to enabled it?
Thanks a lot of your advice!


make consumable via npm

add linting and lint
repo will need to be renamed to knockout.moment

:shipit:

:shipit: harder


Bug: PTP feature in eos_designs has flaws

Issue Summary
Vu La has found the following:

source_ip didn't generate any configuration
smpte profile configured an announce internal of -1 instead of the documented -2.
Adding a second ptp only link yielded no ptp intervals, only a description, no switchport, mtu, and ptp enable
Endpoint values for ptp profile and role were not reflected in the interface configuration. Only descriptions and no switchport are configured

Which component(s) of AVD impacted
eos_designs
How do you run AVD ?
Ansible CLI (with virtual-env or native python)
Steps to reproduce
1) Define source_ip under a node. This will not generate the relevant config.
2) Wrong defaults defined for SMPTE2059-2
3) Only first core interface defined generates the proper config - not the 2nd one.
4) Missing config when defining settings for endpoints.

Relevant log output
No response
Contributing Guide

[X] I agree to follow this project's Code of Conduct

I'm already working on fixing this and will create a PR shortly


paid feature request

Hey there, could I pay to see a version of this that plays text output via ElevenLabs Voice API? Don't have the skill to do this myself but would be super handy is there was a voice output true/false setting.

Welp I'm pretty busy lately and don't have time to update this repo unfortunately...


Set resources for worker Pods

Set requests to 0.5 CPU and 64MiB RAM.
Set limits to 1 CPU and 128MiB RAM.
/cc @yevgeny-shnaidman @mresvanis

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (4214f54) 80.05% compared to head (188ea02) 80.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   80.05%   80.06%
=======================================
  Files          47       47
  Lines        4679     4681    +2
=======================================
+ Hits         3746     3748    +2
  Misses        764      764
  Partials      169      169

Files
Coverage Δ

internal/controllers/nmc_reconciler.go
77.07% <100.00%> (+0.06%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/lgtm


feat: add sm and md size attributes

Alaska Airlines Pull Request
Fixes: #2
Summary:
Updates dialog visibility support to include a sm and md size setting. Default is lg.
Type of change:
Please delete options that are not relevant.

[x] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

PR is ready for review. Need an assist with tests.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Minor edit to lock screen

Codecov Report

Merging #178 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master     #178     +/-   ##
===========================================
- Coverage     58.99%   58.89%   -0.1%
  Complexity      412      412
===========================================
  Files            63       63
  Lines          1829     1832      +3
  Branches        190      190
===========================================
  Hits           1079     1079
- Misses          691      694      +3
  Partials         59       59

Impacted Files
Coverage Δ
Complexity Δ

src/seedu/addressbook/commands/LockCommand.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f49f0...d3ffd82. Read the comment docs.


[Feature Request]: Multi select in Pipelines page

Feature description
It would be useful to add the option to delete multiple pipelines in bulk, like we can do with pipeline runs.
current:

multi select (pipeline runs):

Describe alternatives you've considered
No response
Anything else?
No response

@kywalker-rh cc

I don't see any issues with adding this. I would expect it to work the same way as it does for Runs, but if you need more direction to implement it let me know, @andrewballantyne.

Runs are checkbox, Pipelines are expanded rows. I think we need to pick one or the other, or you need to come up with a design for this (maybe two initial columns?)

Okay, this is going to take some more thought to implement right. I'll add it as an issue for future UX work.

Migrated to:  https://issues.redhat.com/browse/RHOAIENG-2904


Button Refresh does'nt reload ReferenceManyField

On a show page, when I click on the refresh button, it doesn't refresh the referenceManyFields
I see an other issue which is merged, but it seems to do not resolve this problem, so I think it's a bug
https://github.com/marmelab/admin-on-rest/issues/279
https://github.com/marmelab/admin-on-rest/pull/290

Can you provide a repository or codepen reproducing the problem ?

Bump

seconding
example:
just follow tutorial and add ReferenceManyField to Edit from and click refresh
        <SimpleForm {...props}>
            <TextInput source="title" validate={[required]} />
            <LongTextInput source="body" />
            <ReferenceManyField label="User" source="userId" reference="users">
            <Datagrid>
                <TextField source="name" />
                </Datagrid>
            </ReferenceManyField>
        </SimpleForm>

when you use ReferenceManyField in some Edit or Show and click refresh
the ReferenceManyField is not refreshed
and it would propably be nice to be able refresh only ReferenceManyField
(ie. add some refresh icon button to label)

Fixed by #1149


TypeScript symbols is empty inside closure (like jQuery plugins)

From @Ciantic on January 2, 2016 8:38
I tried developing basic jQuery plugin with TS, looks like the symbols list is totally empty if I use following code:
/// <reference path="./typings/tsd.d.ts" />
(function ($: JQueryStatic) {

    interface Anything {
        something : string
    }

    function func() {
    }

})(jQuery);

I think it should recgonize the whole file spanning closure and not let it ruin the symbols listing.
Copied from original issue: Microsoft/vscode#1741

From @felixfbecker on January 3, 2016 12:5
I also think this is annoying. Symbols view only shows symbols in the global scope, also for Javasript. If you use class expressions for Angular, like .controller('MyController', class MyController { ... }) you will never get any methods of that class show up in the symbol view.

From @paramquery on April 20, 2016 14:5
+1
much needed feature.

This is an issue with TypeScript. For JavaScript this actually works a lot better then for TypeScript despite using the same language service...

@billti had a fix for the JS case. we need to unify the two implementations. https://github.com/Microsoft/TypeScript/issues/7523 tracks some of this work.

@andy-ms would this be handled by your refactor?

In the #8958 branch, Anything shows up, but func doesn't. We had decided that inner functions wouldn't show up if they didn't have any children. I don't know how exactly we should handle this, but maybe the entire module going in a single closure is a pattern we could recognize — although trying to recognize particular patterns like this could pile up to a list of messy special cases.

i think that is a better place to be in. if that turned out to be another source of complains, may be we should allow all function declarations regardless if they are containers or not.

Closed by #9220


framework be able to does the come up  new content？

Except for the donuts.
Such the statistical figure.
Do you have a plan making new Statistical figure?

while there are no such plans. I myself use highcharts

I 'm using this too.
However, it is not very harmonious to put the feeling into the frame.


WGUI Times out on kubernetes

When navigating to <IP_ADDRESS>:5000 Chrome reports ERR_CONNECTION_TIMED_OUT. I use a similar setup for just Wireguard by itself in another deployment, and many other webapps with similar services.
Pod logs:
Wireguard UI
App Version     : development
Git Commit      : N/A
Git Ref         : N/A
Build Time      : 02-13-2022 11:15:09
Git Repo        : https://github.com/ngoduykhanh/wireguard-ui
Authentication  : true
Bind address    : <IP_ADDRESS>:5000
Email from<EMAIL_ADDRESS>Email from name : your name
⇨ http server started on [::]:5000

Here's my K8s yaml:
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: wireguard-ui
  name: wireguard-ui
  namespace: my-namespace
spec:
  progressDeadlineSeconds: 10
  replicas: 1
  revisionHistoryLimit: 3
  selector:
    matchLabels:
      app: wireguard-ui
  strategy:
    rollingUpdate:
      maxSurge: 1
      maxUnavailable: 1
    type: RollingUpdate
  template:
    metadata:
      labels:
        app: wireguard-ui
    spec:
      containers:
      - env:
        - name: SENDGRID_API_KEY
          valueFrom:
            secretKeyRef:
              name: wireguard-ui-secret
              key: sendgridApiKey
        - name: EMAIL_FROM_ADDRESS
          valueFrom:
            secretKeyRef:
              name: wireguard-ui-secret
              key: emailFromAddress
        - name: EMAIL_FROM_NAME
          valueFrom:
            secretKeyRef:
              name: wireguard-ui-secret
              key: emailFromName
        - name: SESSION_SECRET
          valueFrom:
            secretKeyRef:
              name: wireguard-ui-secret
              key: sessionSecret
        - name: WGUI_USERNAME
          valueFrom:
            secretKeyRef:
              name: wireguard-ui-secret
              key: wguiUsername
        - name: WGUI_PASSWORD
          valueFrom:
            secretKeyRef:
              name: wireguard-ui-secret
              key: wguiPassword
        - name: NODE_NAME
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: spec.nodeName
        - name: POD_NAME
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.name
        - name: POD_NAMESPACE
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.namespace
        - name: ServerIP
          valueFrom:
            fieldRef:
              fieldPath: status.podIP
        image: ngoduykhanh/wireguard-ui:latest
        imagePullPolicy: IfNotPresent
        name: wireguard-ui
        ports:
        - containerPort: 5000
          name: http
          protocol: TCP
        - containerPort: 51820
          name: vpnudp
          protocol: UDP
        securityContext:
          privileged: true
          capabilities:
            add:
              - NET_ADMIN
              - SYS_MODULE
        volumeMounts:
        - mountPath: /app/db
          name: wireguard-ui-db
        - mountPath: /etc/wireguard
          name: wireguard-ui-wg
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      terminationGracePeriodSeconds: 3
      volumes:
      - name: wireguard-ui-db
        persistentVolumeClaim:
          claimName: wireguard-ui-db-pvc
      - name: wireguard-ui-wg
        persistentVolumeClaim:
          claimName: wireguard-ui-wg-pvc
---
apiVersion: v1
kind: Secret
metadata:
  name: wireguard-ui-secret
  namespace: my-namespace
type: Opaque
stringData:
  sendgridApiKey: apiKey
  emailFromAddress<EMAIL_ADDRESS>  emailFromName: "your name"
  sessionSecret: 64characterSecret
  wguiUsername: yourUsername
  wguiPassword: yourPassword
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  namespace: my-namespace
  labels:
    app: wireguard-ui
  name: wireguard-ui-db-pvc
spec:
  storageClassName: ""
  volumeName: wireguard-ui-db-pv
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  namespace: my-namespace
  labels:
    app: wireguard-ui
  name: wireguard-ui-wg-pvc
spec:
  storageClassName: ""
  volumeName: wireguard-ui-wg-pv
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
---
apiVersion: v1
kind: Service
metadata:
  labels:
    app: wireguard-ui
  name: wireguard-ui
  namespace: my-namespace
  annotations:
    metallb.universe.tf/allow-shared-ip: shared
spec:
  externalTrafficPolicy: Local
  ports:
  - name: http
    protocol: TCP
    port: 5000
  - name: http2
    protocol: TCP
    port: 80
    targetPort: 5000
  selector:
    app: wireguard-ui
  loadBalancerIP: <IP_ADDRESS>
  type: LoadBalancer
---
apiVersion: v1
kind: Service
metadata:
  labels:
    app: wireguard-ui
  name: wireguard-ui
  namespace: my-namespace
  annotations:
    metallb.universe.tf/allow-shared-ip: shared
spec:
  externalTrafficPolicy: Local
  ports:
  - name: wireguard-udp
    protocol: UDP
    port: 51820
  selector:
    app: wireguard-ui
  loadBalancerIP: <IP_ADDRESS>
  type: LoadBalancer

Pod describe:
Name:         wireguard-ui-5d4f4f4f9-v7ptr
Namespace:    my-namespace
Priority:     0
Node:         k8snode3/<IP_ADDRESS>
Start Time:   Sun, 13 Feb 2022 11:15:08 +0000
Labels:       app=wireguard-ui
              pod-template-hash=5d4f4f4f9
Annotations:  <none>
Status:       Running
IP:           <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  ReplicaSet/wireguard-ui-5d4f4f4f9
Containers:
  wireguard-ui:
    Container ID:   docker://f8f9d270751c040067142b9081a18f372361ef473eb415a04fe8d579514efbb5
    Image:          ngoduykhanh/wireguard-ui:latest
    Image ID:       docker-pullable://ngoduykhanh/wireguard-ui@sha256:7719cfd82e5f22d293460430efcc625a06b3fe09f1a5036989c9104dfc5b4575
    Ports:          5000/TCP, 51820/UDP
    Host Ports:     0/TCP, 0/UDP
    State:          Running
      Started:      Sun, 13 Feb 2022 11:15:09 +0000
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     500m
      memory:  256Gi
    Requests:
      cpu:     10m
      memory:  32Mi
    Environment:
      SENDGRID_API_KEY:    <set to the key 'sendgridApiKey' in secret 'wireguard-ui-secret'>    Optional: false
      EMAIL_FROM_ADDRESS:  <set to the key 'emailFromAddress' in secret 'wireguard-ui-secret'>  Optional: false
      EMAIL_FROM_NAME:     <set to the key 'emailFromName' in secret 'wireguard-ui-secret'>     Optional: false
      SESSION_SECRET:      <set to the key 'sessionSecret' in secret 'wireguard-ui-secret'>     Optional: false
      WGUI_USERNAME:       <set to the key 'wguiUsername' in secret 'wireguard-ui-secret'>      Optional: false
      WGUI_PASSWORD:       <set to the key 'wguiPassword' in secret 'wireguard-ui-secret'>      Optional: false
      NODE_NAME:            (v1:spec.nodeName)
      POD_NAME:            wireguard-ui-5d4f4f4f9-v7ptr (v1:metadata.name)
      POD_NAMESPACE:       my-namespace (v1:metadata.namespace)
      ServerIP:             (v1:status.podIP)
    Mounts:
      /app/db from wireguard-ui-db (rw)
      /etc/wireguard from wireguard-ui-wg (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-v5rg9 (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  wireguard-ui-db:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  wireguard-ui-db-pvc
    ReadOnly:   false
  wireguard-ui-wg:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  wireguard-ui-wg-pvc
    ReadOnly:   false
  kube-api-access-v5rg9:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type    Reason     Age   From               Message
  ----    ------     ----  ----               -------
  Normal  Scheduled  12m   default-scheduler  Successfully assigned my-namespace/wireguard-ui-5d4f4f4f9-v7ptr to k8snode3
  Normal  Pulled     12m   kubelet            Container image "ngoduykhanh/wireguard-ui:latest" already present on machine
  Normal  Created    12m   kubelet            Created container wireguard-ui
  Normal  Started    12m   kubelet            Started container wireguard-ui

It seems like you missed the targetPort configured for the http service object

Hey @ngoduykhanh targetPort is only required if the port number differs from port. Both ports in the service point to the same containerPort running on the pod. So from the outside, you can use either port.
But I did test with both ports, 80 and 5000, neither worked.

Figured it out! Both my TCP and UDP services have the same name and the TCP one was being overwritten. Changing the name of the UDP one fixed it.


Can run a widget notebook twice (webview-test) test is failing

Test gets stuck on 'showNotebookDocument'.
Recent change seems to have caused this.

@rebornix are you still investigating this?

Should be good now since we reverted the commit, see https://github.com/microsoft/vscode/pull/152026


Releases to package repositories

It would be easier to use for users if they could pip install pyopmspe11 from the PyPI repository.  This also makes it easier to get a specific released version compared to the git based options [related to #86].  Other options to consider are conda (related to #79) through conda-forge.
Related to https://github.com/openjournals/joss-reviews/issues/7357

Thanks @MatthewFlamm for this suggestion. After merging https://github.com/OPM/pyopmspe11/pull/95, which was also your feedback and very useful, then now we have extended the documentation in the Python installation to explain how one can install a specific release of this repository (https://opm.github.io/pyopmspe11/installation.html#python-package). We also mentioned that package managers such as Anaconda are not tested. Then, @totto82 and I we believe that with the provided documentation the installation of this repository could be achieved, and it is not planned to make package versions of this repository for now.


Audiomoth Visualizer

Hi, would you mind adding: https://github.com/ivoba/audiomoth-visualizer
to the audiomoth section.
Thank you :)

Integrating this into #16 !


FLP still cache the older version of html5 resources

Description
Sometimes when I use html5-plugin to do deplopment or update, when I through the app-router dierctly (approuter/applicationId) I can see my source-code is already updated, however if I open the flp, I can see flp is still loading an older version of html5 resources (linkToFlp/applicationIdWithTimeStamp/olderVersionResources).
Environment

Canary

Hi @kukugo ,
Thanks for reporting an issue.
Current implementation of FLP maintains it's own index of optimised HTML5 applications resources (using FDC service, that only FLP has access to). The only trigger to update this index is (re)deployment of FLP content. This may cause inconsistency you describe. However, this is something that is "by design" from FLP point of view, since they don't want to get into situation, when there are incompatible changes of HTML5 applications (especially shared by business services) that may potentially break existing sites.
So, unfortunately, this is a desired behaviour, and you need to redeploy FLP content every time you redeploy HTML5 applications to see the changes in the FLP site.

This question saved my time.. I was going crazy why the flp app was not being updated.
Can you suggest me, how do i redploy FLP content. Should i redeploy the mtar completely ?
If i have to redeploy all my apps, it makes no sense because everything is being updated and restaged for one small change in one of my ui5 apps.
I already have updated the UI5 app using cf html5-push . But not able to see the changes

Hi @cosmo83 ,
HTML5 Apps Repo service team is currently working on notifications mechanism for FLP to trigger update of the index without re-deployment of FLP content. However, it will take a time for this feature to reach the production landscapes. So far re-deployment of FLP module is the only way to update apps in FLP. You can try to re-deploy only FLP module from previously built MTAR (assuming you have not touched manifest.json files in your UI modules)
cf deploy -m <name_of_flp_deployer_module>

which should trigger update of FLP index. Deployment of such MTAR will be faster than full-blown MTAR with back-end applications.

@micellius , Iam trying to get this running but failing really bad .
https://pastebin.com/shMxDF7a is my mta file.
Iam trying to use your mention command
I tried  both (Really could not understand what you mean by flp_deployer)
cf deploy -m kavskagxportal_ui_deployer
and
cf deploy -m Launchpad
and both of them.. are getting strange issues when i do that .. I have raisen a ticket with SAP, which primarily looks like the problem with Fiori Launchpad systems.. They havent been responding
When i deploy a Fiori Launchpad with above mta.yaml file, when i check my apps status. This is what i get ..

But the flp is working as intended.
The problem is when i redeploy,or start the application like you have asked me, they crash

It will be really helpful if you can help

@micellius any help on this above issue? @cosmo83 can you please open a new issue??? this ticket is closed on GitHub...
@micellius I would like to connect internally to discuss this issue, can you please contact me @ nagesh caparthy...

I tried both (Really could not understand what you mean by flp_deployer)
cf deploy -m kavskagxportal_ui_deployer
and
cf deploy -m Launchpad

@cosmo83 , by FLP (Fiori Launchpad) deployer I meant Launchpad module from your MTA (the one with type: com.sap.portal.content). The first screenshot with applications and their states reflects correct picture - UI deployer and Launchpad are stopped after they finish uploading the content. The second screenshot of deploying MTAR with UI deployer shows the error of missing resources folder. I assume this may happen if build of MTA project was not successful, but the module was deployed.
Unfortunately, I'm not an expert nether in MTA nor in FLP, and the only thing I can help with in this context is deployment of HTML5 applications to CF HTML5 Applications Repository using CF CLI plugin (which, as you stated, passed successfully).
I would propose to continue with the ticket you opened for Fiori Launchpad. Sorry for inconvenience.


Disable Flaky Test

Disable an autodiff test that's causing the linker on Ubuntu 20.04 to crash every so often
rdar://87254800

@swift-ci smoke test and merge


Update ip2geo.md

Description
Bugs in the samples
Issues Resolved
n/a
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@heemin32 - Can you please give this a quick tech review? This was reported by a cloud support engineer. Thanks!

During the replication process for the IP2Geo processor, I found those errors in the documentation. Please help update the same.


Implement listi, findi, and FindItemCommandParser tests

Codecov Report

Merging #130 (9411d90) into master (2ca1cbc) will increase coverage by 0.89%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #130      +/-   ##
============================================
+ Coverage     53.03%   53.92%   +0.89%
- Complexity      499      510      +11
============================================
  Files           106      106
  Lines          2227     2227
  Branches        257      257
============================================
+ Hits           1181     1201      +20
+ Misses          958      938      -20
  Partials         88       88

Impacted Files
Coverage Δ

...va/tracko/logic/commands/item/FindItemCommand.java
100.00% <0.00%> (+100.00%)
:arrow_up:

...tracko/logic/commands/order/ListOrdersCommand.java
100.00% <0.00%> (+100.00%)
:arrow_up:

...racko/logic/parser/item/FindItemCommandParser.java
100.00% <0.00%> (+100.00%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Can we make the ColorAdjust(FaceParsing) node more visually friendly?

This kind of parameter ajustment is not  "what you see is what you get".
Can we make it like Photoshop?

i dont have the technique to make the js so there is no plan. maybe you can find other custom nodes that do the stuff.


Add an alias compression for codec for consistency with Spark's internal data sources

Just for the consistency for internal Spark data sources (JSON and CSV), it matches the compression option name, codec to compression.

Current coverage is 90.04% (diff: 100%)

Merging #145 into master will decrease coverage by 0.15%

@@             master       #145   diff @@
==========================================
  Files            14         14
  Lines           663        663
  Methods         605        604     -1
  Messages          0          0
  Branches         58         59     +1
==========================================
- Hits            598        597     -1
- Misses           65         66     +1
  Partials          0          0

Powered by Codecov. Last update 0c74b41...29f79cf

Merged.


Do not create new map when testing for containsOnly and containsOnlyKeys for maps

Check List:

Fixes #2159
Unit tests : YES
Javadoc with a code example (on API only) : NA

We have a similar issue for assertContainsExactly when it checks that the entries are in the same order and compares keys with equals.
@filiphr would you like to fix that too? no problem if you can't, I'm happy to do it.

I didn't have much ideas about the containsExactly one, but I just got an idea. I'll try something out shortly

@joel-costigliola I've adapted the PR to include the fix for the assertContainsExactly problem as well.

I think we should close this PR in favor of https://github.com/assertj/assertj-core/pull/2167 which tries the approach with cloning the actual map

closing this PR in favor of #2167


changes on dad decomplier module

delete outer classname when generate java source
for example :
for class declaration:
public class OuterClassName$InnerClassName --> public class InnerClassName
for constructor:
public OuterClassName$InnerClassName()-->public InnerClassName()

Sorry but we will not merge that. You could have duplicate class names.


create-react-app production build fails

Command: npm run build
Output:
> react-scripts build
3:44:35 PM: Creating an optimized production build...
3:44:43 PM: Failed to compile.
3:44:43 PM: Failed to minify the code from this file:

./node_modules/@nx-js/observer-util/src/observer.js:8

Read more here: http://bit.ly/2tRViJ9
3:44:43 PM:
3:44:43 PM: Build complete: exit code: 1
3:44:43 PM:
3:44:44 PM: Cleaning up docker container
3:44:44 PM: npm
3:44:44 PM:
3:44:44 PM: ERR!
3:44:44 PM: Linux 3.19.0-66-generic
3:44:44 PM: npm
3:44:44 PM:
3:44:44 PM: ERR!
3:44:44 PM: argv "/opt/buildhome/.nvm/versions/node/v6.11.2/bin/node" "/opt/buildhome/.nvm/versions/node/v6.11.2/bin/npm" "run" "build"
3:44:44 PM: npm
3:44:44 PM: ERR! node
3:44:44 PM: v6.11.2
npm
3:44:44 PM:
3:44:44 PM: Error running command: Build script returned non-zero exit code: 1
3:44:45 PM: ERR! npm v3.10.10
3:44:45 PM: npm
3:44:45 PM: ERR!
3:44:45 PM: An error occurred while building the site, skipping the deploy and cache refresh.
3:44:45 PM: code ELIFECYCLE
3:44:45 PM: npm ERR!
3:44:45 PM<EMAIL_ADDRESS>build: `react-scripts build`
npm
3:44:45 PM: ERR!
3:44:45 PM: Build script returned non-zero exit code: 1
3:44:45 PM: Exit status 1
npm
3:44:45 PM: ERR!
3:44:45 PM: npm
3:44:45 PM: ERR!
3:44:45 PM: Failed at the<EMAIL_ADDRESS>build script 'react-scripts build'.
3:44:45 PM: npm ERR!
3:44:45 PM: Make sure you have the latest version of node.js and npm installed.
3:44:46 PM: npm ERR!
3:44:46 PM: If you do, this is most likely a problem with the rep-counter-client package,
npm
3:44:46 PM:
3:44:46 PM: ERR!
3:44:46 PM: not with npm itself.
npm
3:44:46 PM:
3:44:46 PM: ERR!
3:44:46 PM: Tell the author that this fails on your system:
npm ERR! react-scripts build
npm ERR!
3:44:46 PM: You can get information on how to open an issue for this project with:
3:44:46 PM: npm ERR!
3:44:46 PM: Finished processing build request in 49.305966188s
3:44:46 PM: npm bugs rep-counter-client
3:44:46 PM: npm
3:44:46 PM: ERR!
3:44:47 PM: Or if that isn't available, you can get their info via:
npm
3:44:47 PM: ERR!
3:44:47 PM: npm owner ls rep-counter-client
3:44:47 PM: npm
3:44:47 PM: ERR!
3:44:47 PM: There is likely additional logging output above.
3:44:47 PM:
3:44:47 PM: npm
3:44:47 PM: ERR! Please include the following file with any support request:
npm
3:44:47 PM: ERR! /opt/build/repo/npm-debug.log
3:44:47 PM: Cached NPM modules

Thanks for the issue!
Both the commonJS and the esm builds are transpiled down only too the minimum supported platforms, which are all ES6. Webpack uses uglifyJS as its default minifier, which does not support ES6 yet. This means that the minification will fail even though the platform support is there.
To work around this I can think of 2 things:

Ask users to use an es6 aware minifier. This is a no-go as I would like to remain compatible with React Create App and default webpack config.

Distribute React Easy State in a pseudo-es5 format, even though it won't make platform support wider. It would solve the issue, but it would also introduce unnecessary transpilation. I would go with this until UglifyJS starts to support es6.

Fixed in v2.0.3. Thanks for the issue 🙂


[Feature Request] Medusa Support

Is your feature request related to a problem? Please describe.
No problem
Describe the solution you'd like
I would love to see if Medusa could be supported. It is very similar to SickChill (I believe they are both forked from SickRage). https://pymedusa.com/
Describe alternatives you've considered
I have tried using the SickChill support and just inputting my Medusa information, but it doesn't seem to work properly. I can find any information when I try making new panels in Grafana.

Medusa, unless changing their api does work. There have been many people who use it via our sickchill support. Please use discord for support


Position swapping when is dragging, what is missing?

Hey guys, I'm trying to implement the behavior from the website's example. Do you know which part of the code is missing for my application to achieve this dynamic position swapping while I'm dragging the item?
Video
1st moment - website example
2nd moment - my application
https://github.com/clauderic/dnd-kit/assets/92958274/7d77ee02-975a-4e44-a302-1f6e03109cc7

;/

@lei0gre Did you figure this out? Having the same issue.

I would say Drag Overlay is what you are looking for.

@daxiang28 no i dont!


Documentation tweaks to consider

I was just looking at C# support in F# Formatting and I was thinking of using Math.NET as a motivation for this - I see Math.NET already uses F# Formatting for the tutorial docs, but not for the API reference. So, I wanted to check if you'd be open to a change.

Assuming I get F# Formatting to work reasonably well on C# assemblies, should I send a PR replacing the current API reference with one generated by F# Formatting?

I also found it a bit confusing that the homepage (http://numerics.mathdotnet.com) is not using the scaffold template while all other pages do (http://numerics.mathdotnet.com/docs). I see why the umbrella page (http://www.mathdotnet.com) is different, but I think the project homepage could use the same format as other pages (and it could have some shiny example on the front page :-)). Would you be open to a PR changing this?

Update: all docs are now in root (dropped the extra homepage for each project). The old urls are redirected.


Fix libtool error

Turns out we need to regenerate aclocal.m4 as the one included is generated with an older version of libtool. So, we fix this problem here by regenerating aclocal.m4. Also, merges PR ( https://github.com/conda-forge/nfft-feedstock/pull/3 ) to pin versions correctly (though we can discuss if that should be kept).
cc @pelson @grlee77

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

As can be seen, this passes.
The only question at this point is whether the pinning is wanted. I have no opinion on this matter so whatever you guys decide is fine with me. Happy to remove if needed.

thanks.  I will go ahead and merge with the pinning later today unless there are any objections.

@ghisvail, thoughts on the pinning?

Not sure if it is required but go ahead and we'll see.

I don't think it is necessary, but it doesn't do any harm either. Basically I agree with @pelson's remark in this comment. In the end, any way you want this done that is agreeable to both you, @ghisvail, and @grlee77 is completely fine with me.


[v3 Branch Pick] Add some error context in transport_failure_callback

This picks the changes from https://github.com/getsentry/raven-ruby/pull/796 with some additional fixes.
Closes #661

Codecov Report

Merging #1003 into v3-1 will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             v3-1    #1003      +/-   ##
==========================================
- Coverage   97.85%   97.80%   -0.05%
==========================================
  Files          46       46
  Lines        2187     2185       -2
==========================================
- Hits         2140     2137       -3
- Misses         47       48       +1

Impacted Files
Coverage Δ

spec/raven/integration_spec.rb
100.00% <100.00%> (ø)

spec/raven/integrations/sidekiq_spec.rb
96.07% <0.00%> (-0.99%)
:arrow_down:

lib/raven/integrations/rails/active_job.rb
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25ea2c...180a8a7. Read the comment docs.


Add CLI option for transaction TTL

Issue Number
ADP-93 / #1840
Overview

[x] Hide shelley-specific CLI options in cardano-wallet-jormungandr (fixes #2169)
[x] Add option cardano-wallet transaction create [--ttl=SECONDS]
[ ] Update wiki page after merging.

Comments

Based on PR #2262 branch - merge that first.

bors r+

@rvl:
$ cardano-wallet transaction create 1ceb45b37a94c7022837b5ca14045f11a5927c65 \
  --ttl 1s \
  --payment 1000000@addr_test1qq6m4v46wc7glh4rcdcq5u49vuqu6m8e3tp5g306chrcxt6rfvtjsyka3nefuhflvhc6pfm0kj3u7xr6c67fjhqzq3rqqtw9xt
Please enter your passphrase: ****************

Error in $['time_to_live']: parsing Quantity failed, expected Object, but encountered Number

bors r-

Oops, thanks @piotr-iohk. It works now.
bors r+

bors retry

bors merge


Issue 46

In REDCap >= 6.x it is necessary to include the exportCheckboxLabel parameter in the export records call in order to retrieve the labels for checkbox fields. Prior to 6.x this could be achieved simply by setting rawOrLabel to true. Its important to note that in order for checkbox labels to be exported as values you will still have to set raw_or_label to true in calls to export_records. Fixes #46.

@tjrivera from your perspective is this ready?

@sburns yes, I'm happy with it in its current state.

Thanks @tjrivera!

Looking at the same issue..and who saves the day. @tjrivera  Thanks!

@alexanderkgonzalez can you install from master per the docs, just want to make sure your systems can get back to working.


Can't bind button to keystroke

This was reported in https://github.com/libratbag/piper/issues/242, but I believe this is an issue in libratbag.

Hi, I am still having this issue with latest fedora (f29) installed from dnf. Using a Logitech G403 over the actual cable (Piper crashes when I try to apply with just dongle, apparently because of a sync/async issue that was solved (?)


Create zh-Hans.json

Add translation for Mandarin

Thanks for the PR! Would you mind switch to the develop branch and adjust the changes?


Idea for GSoC: Support of Source Code Related Metrics

This is a proposal for GSoC'2019.

Thanks @valeriocos
I will merge this pull request as soon as you added the micro-tasks.

@valeriocos can you take a look at @GeorgLink comments. This is due very very soon (Feb 6)

@GeorgLink @germonprez @jgbarah I have added the micro-tasks to the issue (https://github.com/chaoss/grimoirelab/issues/182). Feel free to review them and give feeback, thank you

Thank you @valeriocos, this is great!
I leave the content of the Micro-tasks to you and your co-mentors. I make sure we have everything 👍

you're welcome @GeorgLink


Add generalization for DotLike operations

This PR allows other dot-like operations to be built on top of Triton instead of requiring ops to be DotOp exactly.
We are using this internally in order to support SparseDotOp (which has DotLike trait implemented).

I think several pieces of code were not designed to be generalized to all dot like ops. cc @ThomasRaoux

I agree. In this pass we are explicitly targeting an op, changing it to checking any DotLike is not correct


(cloudfront-to-s3) any in cloudfront distribution props type

https://github.com/awslabs/aws-solutions-constructs/blob/7c5571365e44598bc8dff97038ab1ace0d9c7d94/source/patterns/%40aws-solutions-constructs/aws-cloudfront-s3/lib/index.ts#L41
The | any can throw users off, e.g. mistakenly configure functionAssociations at the top level where it should be nested in defaultBehavior (or an additional behaviour) to associate it to the CloudFront distribution.
If agreed upon I can submit a PR removing the | any from the CloudFront distribution props type.

We agree with the risk of | any, but made a conscious decision to include it anyway. Without | any, users could not override a single property value without re-specifying every required property attribute. This would make the constructs significantly harder to use and less flexible. Our design decision was that the flexibility outweighed the risk.

Could Partial<cloudfront.DistributionProps> not be used instead?

https://github.com/awslabs/aws-solutions-constructs/issues/250 opened to continue discussion


PandasConnector

Here is an initial draft of PandasConnector for consideration, as discussed in #3302.
It is not complete, but it shows the general approach.
I have created contrib.tests.connectors which implements a BaseConnectorTestCase which I am using to make sure that the results returned by PandasConnector are consistent with those from SqlaTable.
If we get to the point where this PR can be merged, then we will probably want to refactor to put BaseConnectorTestCase and SqlaConnectorTestCase into the main tests directory and just leave the PandasConnectorTestCase in the contrib directory.

Thanks a lot for your great work, i'd really like this to be a first citizen in superset

Coverage remained the same at 70.161% when pulling 9df1786470f77b43c9a2fbd5e2ac5fc35c12360b on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage remained the same at 70.161% when pulling 9df1786470f77b43c9a2fbd5e2ac5fc35c12360b on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage remained the same at 70.161% when pulling 9df1786470f77b43c9a2fbd5e2ac5fc35c12360b on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage remained the same at 70.161% when pulling 9df1786470f77b43c9a2fbd5e2ac5fc35c12360b on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.5%) to 70.612% when pulling 4b47b7539128fb979dd4115a33d86b5b0cb2ee93 on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.5%) to 70.612% when pulling d156430dc4f5ee88bb5a6f7885b60312dad16fab on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.7%) to 70.83% when pulling fa3825631ec62f24ea94d69edb7b508913f25cda on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.7%) to 70.83% when pulling fa3825631ec62f24ea94d69edb7b508913f25cda on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

@mistercrunch I have moved the migration into superset/migrations/versions in order to get Travis to run. I can move it back out if you decide you want to keep it in a contrib directory.
I have also added lxml and beautifulsoup4 to dev-reqs.txt because contrib.tests.connector_tests uses them to prepare test data. connector_tests is probably useful for other people writing connectors as well as providing increased test coverage for superset/connectors/sqla/models.py so you might want to adopt some of it into core.
Please let me know what you would like me to do next?

Coverage increased (+0.7%) to 70.83% when pulling 0e50319c75933cbe88b1c750e2cafc75c650198e on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.7%) to 70.83% when pulling c69a161976c38297db69a40f74e2d3281f702eec on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.4%) to 70.592% when pulling fbfd6855d0b1187ac366b85770c6e8937906bc25 on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.6%) to 70.81% when pulling 38d6c03f24c3ab0a7eb6fa852640f623af39709e on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.7%) to 70.814% when pulling 1df623798d50470b8c40fd7712422909957d7532 on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.4%) to 70.535% when pulling 878c7c4ef9e613297077d90260e303eabd672d97 on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.4%) to 70.535% when pulling 2826876f1374d27f94e4908d5bfe0246703b45ab on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.4%) to 70.535% when pulling b24a700b3e0dffac29849e15099539744986a47d on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+0.6%) to 70.753% when pulling 3610ac0df063a0cf20af106d26e362fecfb6d446 on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Coverage increased (+1.3%) to 71.412% when pulling bb78be855a81c683bf47bb2ee073a8cbe9042954 on kimetrica:3302-pandas-connctor into ef59b6b6508d29588931755d22023b845ced8712 on apache:master.

Having the migrations and requirements mixed in with the main Superset ones without ever merging this MR causes frequent merge conflicts. Therefore, I am going to close this MR. We will continue to maintain the connector in order to allow us to use Superset with APIs and remote files, but we will do so in our fork rather than a MR.

@rhunwicks thank you for creating this code. It seems pretty perfect for us to be honest -  I wish it had made it into superset!


Fix x-correlator syntax

What type of PR is this?
Add one of the following kinds:

correction

What this PR does / why we need it:
Align with Commonalities on syntax for x-correlator
Which issue(s) this PR fixes:

Fixes #8
Special notes for reviewers:
Changelog input
 release-note

Additional documentation
This section can be blank.
docs

Fixed the errors reported earlier, and passed the local check: but the Megalinter run above says the Spectral ruleset itself is invalid...?

@javierlozallu my mistake (see issue #11)  - please review PR #12 which will fix.


Not able to fetch package mssql-tools

I added the repo as mentioned in the documentation  and  ran   yum check-update before submiting this issue
[root@host032 admin]# yum search  --enablerepo=packages-microsoft-com-mssql-server-2019   mssql
Repository packages-microsoft-com-prod is listed more than once in the configuration
Last metadata expiration check: 0:04:10 ago on Fri 25 Sep 2020 12:02:50 AM -03.
============================================================ Name & Summary Matched: mssql ============================================================
grafana-mssql.x86_64 : Grafana mssql datasource
opendbx-mssql.x86_64 : MSSQL backend - provides mssql support in opendbx
================================================================= Name Matched: mssql =================================================================
mssql-server.x86_64 : Microsoft SQL Server Relational Database Engine
pcp-pmda-mssql.x86_64 : Performance Co-Pilot (PCP) metrics for Microsoft SQL Server
mssql-server-ha.x86_64 : High Availability support for Microsoft SQL Server Relational Database Engine
mssql-server-fts.x86_64 : Microsoft SQL Server Full Text Search
tuned-profiles-mssql.noarch : Additional tuned profile(s) for MS SQL Server
mssql-server-polybase.x86_64 : Microsoft SQL Server PolyBase
mssql-mlservices-mlm-r.x86_64 : Packages for R support in Microsoft SQL Server Machine Learning Services (Full install)
mssql-mlservices-mlm-py.x86_64 : Python packages for Microsoft SQL Server Machine Learning Services (Full install)
mssql-mlservices-python.x86_64 : Anaconda Python for Microsoft SQL Server Machine Learning Services
mssql-server-extensibility.x86_64 : Extensibility support for Microsoft SQL Server Relational Database Engine
mssql-mlservices-packages-r.x86_64 : Packages for R support in Microsoft SQL Server Machine Learning Services (Minimal install)
mssql-mlservices-packages-py.x86_64 : Python packages for Microsoft SQL Server Machine Learning Services (Minimal install)
mssql-server-polybase-hadoop.x86_64 : Microsoft SQL Server PolyBase Hadoop
mssql-server-extensibility-java.x86_64 : Extensibility Java language support for Microsoft SQL Server Relational Database Engine
Hi guys I am not able to fetch the package mssql-tools on the repo bellow
[ packages-microsoft-com-prod ]
https://packages.microsoft.com/rhel/8/prod/
How ever the package it is available
mssql-tools-<IP_ADDRESS>-1.x86_64.rpm                  02-Aug-2019 20:46              292726
mssql-tools-<IP_ADDRESS>-1.x86_64.rpm                  04-Feb-2020 23:11              294866
mssql-tools-<IP_ADDRESS>-1.x86_64.rpm                  06-Mar-2020 22:59              228664
mssql-tools-<IP_ADDRESS>-1.x86_64.rpm                  31-Jul-2020 18:01              228628
Still able to install using the commands bellow
sudo yum install -y https://packages.microsoft.com/rhel/8/prod/unixODBC-2.3.7-1.rh.x86_64.rpm
sudo yum install -y https://packages.microsoft.com/rhel/8/prod/msodbcsql17-<IP_ADDRESS>-1.x86_64.rpm
sudo yum install -y https://packages.microsoft.com/rhel/8/prod/mssql-tools-<IP_ADDRESS>-1.x86_64.rpm
my system details
etc/os-release
NAME="CentOS Linux"
VERSION="8 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="8"
PLATFORM_ID="platform:el8"
PRETTY_NAME="CentOS Linux 8 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:8"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"
CENTOS_MANTISBT_PROJECT="CentOS-8"
CENTOS_MANTISBT_PROJECT_VERSION="8"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="8"
uname -r
4.18.0-193.14.2.el8_2.x86_64
dnf --version
4.2.17

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b543b57-f397-779d-6fe4-1bc2ecd3bdca
Version Independent ID: e274a0f3-ec74-e809-f4d3-515782b29a92
Content: RHEL: Install SQL Server on Linux - SQL Server
Content Source: docs/linux/quickstart-install-connect-red-hat.md
Product: sql
Technology: linux
GitHub Login: @VanMSFT
Microsoft Alias: vanto

@akenamon -- Akenamon, thank you for your thorough feedback.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@VanMSFT -- Van, please look into this issue.

Hi @akenamon - Unfortunately, this forum is for documentation issues, and we cannot provide support on your installation issues. CentOS also isn't supported at the moment. We apologize for the inconvenience, but please look into the links @WilliamAntonRohm provided.

@VanMSFT -- thank you for clarifying.


fix: terminal restore

Fixes terminal to be restored correctly to it's original state.

@MichaelMraka can you please have a quick look? thx


Swift Example

Can we get a Swift example with autolayout.

Same above!

Same above!

I ported RMPZoomTransitionAnimator to Swift.
Please see https://github.com/yhirano/RMPZoomTransitionAnimator-Swift and try it.


Extension bindings for cast_motion are incorrect in double-precision builds

Tested versions
Reproducible in: 4.3.dev [b15105a35]
System information
N/A
Issue description
PhysicsDirectBodyState3DExtension::_cast_motion, which is overridden by a GDExtension to implement PhysicsDirectBodyState3D::cast_motion, has the resulting safe and unsafe fractions bound using GDExtensionPtr<real_t>, as seen here:
https://github.com/godotengine/godot/blob/b15105a3585c29c8448f3d2dc8fe20a578a2b41b/servers/extensions/physics_server_3d_extension.h#L135
https://github.com/godotengine/godot/blob/b15105a3585c29c8448f3d2dc8fe20a578a2b41b/servers/extensions/physics_server_2d_extension.h#L133
This unfortunately leads to --dump-extension-api emitting a function signature of float* into extension_api.json, presumably because real_t isn't an actual nominal type, which means that even double-precision builds of a GDExtension end up implementing the function as float* when in fact a real_t* is being passed in (and moved across as void*) from the Godot side of things.
This then means that any result written to these fractions in double-precision builds end up garbled on the other end, leading to shape-casts being broken.
In terms of fixing this, I see the choices as being either:

Change the GDExtensionPtr<real_t> to GDExtensionPtr<float>. The extra precision seems overkill for something like this anyway. This however means it will break for anyone who might be currently be casting this to real_t*, like myself, although I haven't actually pushed any release with this yet.
Change the GDExtensionPtr<real_t> to GDExtensionPtr<double>, which will then break every precision=single extension build instead, as well as being a breaking change in terms of compilation (for godot-cpp).
Somehow allow for extension_api.json to emit real_t* for the function signature, which would be a breaking change in terms of compilation for precision=double builds, but would preserve the workaround mentioned in option 1.

EDIT: I suppose a 4th option could be to expose an entirely new method, like _cast_motion2, which uses GDExtensionPtr<double> instead, but it seems unfortunate to leave the old broken method as-is.
Steps to reproduce
N/A
Minimal reproduction project (MRP)
N/A

CC @godotengine/gdextension

My personal preference would be for GDExtensionPtr<real_t> to cause extension_api.json to have float * on single precision builds, and double * on double precision builds. The extension_api.json is already different between double and single precision builds (including for non-pointer real_t arguments), so it would make sense for this case too.

Hm, I just built Godot with double precision and ran with --dump-extension-api and they do already appear to be double *'s in the extension_json.api:

JSON data
```
				{
					"name": "_cast_motion",
					"is_const": false,
					"is_static": false,
					"is_vararg": false,
					"is_virtual": true,
					"return_value": {
						"type": "bool"
					},
					"arguments": [
						{
							"name": "shape_rid",
							"type": "RID"
						},
						{
							"name": "transform",
							"type": "Transform2D"
						},
						{
							"name": "motion",
							"type": "Vector2"
						},
						{
							"name": "margin",
							"type": "float",
							"meta": "double"
						},
						{
							"name": "collision_mask",
							"type": "int",
							"meta": "uint32"
						},
						{
							"name": "collide_with_bodies",
							"type": "bool"
						},
						{
							"name": "collide_with_areas",
							"type": "bool"
						},
						{
							"name": "closest_safe",
							"type": "double*"
						},
						{
							"name": "closest_unsafe",
							"type": "double*"
						}
					]
				}
```

Are you maybe trying to use the extension_api.json from a single precision Godot to build an extension with double precision?

Are you maybe trying to use the extension_api.json from a single precision Godot to build an extension with double precision?

Yes, that seems to be the crux here. For some reason I was under the impression that the default/bundled extension_api.json was compatible with both single- and double-precision builds, seeing as how the code emitted from godot-cpp's binding generator seems to translate every non-pointer real_t to a double regardless of precision, but I see now that they're in fact specified as float in extension_api.json as well, and that instead every single float is made into a double.
But alright, I suppose I can just generate a custom precision=double version of extension_api.json for the minimum Godot version I'm targeting.
Is there any particular reason why the same extension_api.json couldn't be used, besides this obvious incompatibility of GDExtensionPtr<real_t>? Is it to cater to the possibility of having completely different bindings based on REAL_T_IS_DOUBLE or something?
Anyway, I'll go ahead and close this.

Is there any particular reason why the same extension_api.json couldn't be used (in godot-cpp specifically), besides this obvious incompatibility of GDExtensionPtr<real_t>?

Well, they are binary incompatible, the function signatures actually different. The main consequence of this is that a number function hashes are different, but it also has an impact on virtual functions as shown here. We've discussed this a couple of times, the most recent one was here.
But at a higher-level, if you're re-compiling Godot with different options than the official builds, you can end up with differences that affect compatibility (for example, some additional modules may be enabled or disabled), and so any time you're doing that, you should generate your own extension_api.json

Well, they are binary incompatible, the function signatures are actually different. The main consequence of this is that a number function hashes are different

I'm very surprised that I didn't run into any issues with this at all. Everything ran just fine with no warnings or errors, and I was able to utilize the extra precision as expected. I guess it's just about hitting the right API call.

It'd probably be a good idea add something to godot-cpp that will detect if the extension_api.json was generated with a single or double precision build (if we can even detect that - we may need some changes to the JSON) and give an error if you try to build your extension with a mismatching setting. I'll add looking into that to my TODO :-)


Create 16 - Power Embedded.md

Adding a new Partner for Power BI Embedded

@microsoft-github-policy-service agree [company="Power Tuning"]

@bhitney I'm not working with anyone yet. Can you help me on that, please?

@bhitney I'm not working with anyone yet. Can you help me on that, please?

Could you send me an email? My alias is bhitney at MSFT. Will ask some follow up questions over email. Thx!


call updateLayout() function in a fonctional component

Hi !
I'm kind of new in react an discovered this awesome library but I really want to call the updateLayout function in a fonctional component !
How am I supposed to get the ref from the grid ?
I know it's like that in a class component
gridRef={grid => this.grid = grid}
But how do I reference it in a fonctionnal component ?
Many thanks in advance :)

export const Example = () => {
const [stackGrid, setStackGrid] = useState();

function handleUpdateLayout() {
    if (stackGrid) {
       stackGrid.updateLayout()
    }
}

return (
        <StackGrid
            gridRef={grid => setStackGrid(grid)}
            ....
)

Hope this help


fix: add @Deprecated annotation to toMap method in device_info_plus

Description
as the current implementation of toMap output an invalid json
(see discussion in this https://github.com/fluttercommunity/plus_plugins/issues/949#issue-1297230725 and https://github.com/fluttercommunity/plus_plugins/pull/950)
a suggested solution is to deprecate "toMap" in it's entirety
Related Issues
fix https://github.com/fluttercommunity/plus_plugins/issues/1139
fix https://github.com/fluttercommunity/plus_plugins/issues/949
Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[x] All existing and new tests are passing.
[x] I updated the version in pubspec.yaml and CHANGELOG.md.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the [Flutter Style Guide].
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ ] No, this is not a breaking change.

Hey! Due to changes in our contributor guidelines, all PRs should now:

Have a title that follows the Conventional Commits format. e.g. feat(package_name)!: feature description
DO NOT modify the CHANGELOG.md or the version in the pubspec.yaml. This is going to be an automated process now.

We would ask you kindly to update the PR following these changes.
Thanks!

Hey! Due to changes in our contributor guidelines, all PRs should now:

Have a title that follows the Conventional Commits format. e.g. feat(package_name)!: feature description
DO NOT modify the CHANGELOG.md or the version in the pubspec.yaml. This is going to be an automated process now.

We would ask you kindly to update the PR following these changes.
Thanks!

@miquelbeltran done
(how did you automate this? it's awesome)

@miquelbeltran done (how did you automate this? it's awesome)

With the melos tool, we already use it for other things, but haven't used it yet for versioning.

Hi @iapicca
So we had a discussion about the architecture of the plus_plugins in general and one issue that came up with device_info_plus was how the platform interface implementation is done, and if we should completely refactor it, because the platform interface, that should be platform-agnostic, contains a ton of platform implementation details.
I will give a hacktoberfest-accepted label, so it counts towards the goal, but I am not sure if we will end up merging this PR sometime soon.
Let me know if you have any questions!

I will fix the merge conflict and merge once CI finished checking everything is OK


time and timeEnd don't respect underline*: false

Describe the bug
Setting config.underlineLabel does not remove the underline from the time and timeEnd methods.
To Reproduce
Here's the code I'm working with - I've disabled any of the available underline* properties, though underlineLabel should be all that's needed:
// index.js
const { Signale } = require('signale')

const logger = new Signale({
  config: {
    underlineLabel: false,
    underlineMessage: false,
    underlinePrefix: false,
    underlineSuffix: false
  }
})

logger.time('A timer')
logger.timeEnd('A timer')

node index.js

Expected behavior
I'd expect the underlineLabel: false setting to apply to the time and timeEnd methods like it does for others.
Looks like that's being set here, without a check for _config.underlineLabel:
https://github.com/klaussinani/signale/blob/ae5701e610034629b44e028010a18b593e0b64c0/signale.js#L325
Technical Info (please complete the following information)

OS: MacOS
Signale Version: ^1.3.0
Node.js Version: 10.13.0

Additional context
I discovered this in my testing of https://github.com/JasonEtco/actions-toolkit/pull/45 - for some reason, the GitHub Actions log display adds additional spaces for labels with an underline:

I dug into it and discovered this code. I'm sure its needed for regular terminals/output, but it borks a little in Actions so I just disable underlines entirely (since they wouldn't show up anyway):
https://github.com/klaussinani/signale/blob/ae5701e610034629b44e028010a18b593e0b64c0/signale.js#L212-L216
Let me know if I can clarify anything! Happy to open a PR fixing this if y'all are into it.

Thanks @klaussinani! ❤

Nice catch! Apparently the stream.Writable in-use does not support ANSI escape codes, which combined with the bug/fact that the time() & timeEnd() unaries did not follow the underlineLabel option, resulted in the asymmetrical end-padding of the timer labels. Setting the underlineLabel option to false should now resolve the issue and display the labels as expected. Also, in the upcoming releases, it is planned for signale to automatically detect if ANSI codes are supported at all, and if not to completely avoide using them. Thank you a lot for taking the time to report the issue! : )


Update aws-java-sdk-dynamodb to 1.12.119

Updates com.amazonaws:aws-java-sdk-dynamodb from 1.11.1034 to 1.12.119.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" } ]

labels: library-update, early-semver-minor, semver-spec-minor

Superseded by #192.


Better Together

We're splitting up, kids, but it's for the best.

Ready for review.

Well, this'll take a while.  :P

Lucky for you the changes are entirely cosmetic.  Just want you to make sure I didn't Bork the transition (like how this didn't work for the past zillion commits because git's "you renamed this file" implementation is case-insensitive-I blame HFS).

Ok.  Looks good to me, but I'm trusting Travis more than myself on something like this.  :P

That's the last uncaught change I can see.  This will go through when Travis gives me the green light.

:boat:


Only MenuBar

Hi @okwasniewski , It would be possible to have only the MenuBar.
That is, when the app is started, the screen with the word "Hello!" does not appear.

Hey @Angelk90,
It's possible! However, it's not that simple. You need to take a more brownfield approach to achieve this.
Here you have a tutorial from @ospfranco that explains this pretty well:
https://ospfranco.com/post/2020/05/23/how-to-make-a-react-native-menu-bar-app-for-mac-os/
The thing that you need to modify is instead of setting popover.contentViewController = rootViewController you need to store rootViewController as a non-retained property on AppDelegate so it's kept alive.
I will create a blog post soon on how to achieve this with this lib 👍🏻

Hey,
I've released blog post on this topic recently: https://www.oskarkwasniewski.dev/blog/create-react-native-macos-menubar-app


Split RuntimeError and RequestRejection by protocol

As outlined in the Protocol Specific Errors of the Service Builder
Improvements RFC, RuntimeError should be split up into smaller,
protocol specific, errors which accurately model the failure cases of
each protocol.
The same goes for RequestRejection.
Closes #1703.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


Need to remove rn_dev_prefrence.xml from release build on decompile build

Description
we used the RN version 0.63.4 and somehow in the release build, we are getting rn_dev_preference XML in the build.
we need to remove the file for some security issues.
please suggest a way to remove the file from the release build.
The path on decompile build: res/XML/rn_dev_preference The path
React Native Version
0.63.4
Output of npx react-native info

Steps to reproduce
create a build and just decompile the build you can see the file in res/xml/ folder the
Snack, code example, screenshot, or link to a repository
res/xml/rn_dev_preference.xml

@cortinico Can you help me with this issue? if you have any idea about this.

@cortinico Can you help me with this issue? if you have any idea about this.

Sadly we cannot. Firsy, you're using a too old version of React Native.

we need to remove the file for some security issues.

Moreover, it's unclear what are the security issues with this file, so we can't help you further.


Add official plugin plugin manager (hyprpm) to installation methods in README

For me, hyprpm works better than hyprload and I think it would ease things for some people if it was indicated as an install method in the README.
https://wiki.hyprland.org/Plugins/Using-Plugins/#hyprpm

could be added if #38 or #48 were merged. #40 for readme additions only


Document how to execute migrations without the .NET Core SDK installed

I keep getting told the project can't be found.  Why is the project necessary?  The code is contained in the dlls.  How do I take my published code as an artifact and run the database update?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 263f21d6-6edc-7582-e0e2-fa1c9670bcc0
Version Independent ID: b3dd8c84-18b1-f98d-64f1-7897d1482692
Content: .NET Core CLI - EF Core
Content Source: entity-framework/core/miscellaneous/cli/dotnet.md
Product: entity-framework
GitHub Login: @bricelam
Microsoft Alias: bricelam

Not that straightforward to do manually.
We have ended up using the VSTS task from Ben Day, he's also published scripts for win/linux to execute the migrations.
https://www.benday.com/2018/07/05/deploy-entity-framework-core-2-1-migrations-from-a-dll/

See also the discussion here: https://github.com/aspnet/EntityFrameworkCore/issues/13339
Specifically, it would be useful to:

Make sure that people understand that the dotnet tools can be used if the SDK is installed
For people who can't install the SDK, link to these blog posts
Add benday's tool to the EF core extensions document.

We are working in .net 4.8 environment and using next workaround.
In csproj file with migrations we are coping all dependencies to output folder:
    <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="3.1.9">
      <IncludeAssets>compile; runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
      <Publish>true</Publish>
    </PackageReference>
     ...
    <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="3.1.9" GeneratePathProperty="true">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
    ...
   <ItemGroup>
      <None Include="$(PkgMicrosoft_EntityFrameworkCore_Tools)\tools\net461\any\ef.exe" CopyToOutputDirectory="PreserveNewest" />
   </ItemGroup>

So we don't need to know where is Microsoft.EntityFrameworkCore.Tools installed and we can run migrations much easily.
With powershell something like that:
.\ef.exe database update --assembly <assembly name>.dll


Sort by title inconsistent

Description
Enter a description for the defect.
Steps to reproduce

Bad DB data.


PR gating step for rollback migrations

Description
we have a process around manually checking db rollbacks, but it seems a bit too error prone
Proposed solution
Automatically check for db rollback during the pr checks
Additional context
post mortem

Once this is in place we can remove the rollback section from the PR template.

Can spin up a local database in Docker and run it against that.


Two different background colors for full-screen stereo plot

When rendering a plot in full-screen and stereo I notice that the left plot's background is white while the right one's is black, which I find at least unexpected, not to say not helpful. ;)

Thanks for the report, I'd say a bug :)


Put buttons in calendar cells

Please see commit message for description of this change.
We can ignore the first commit for the build, that's from another PR. The diff is easier to read with ?w=1 (.e.g.  https://github.com/angular/components/pull/24171/files?w=1)

work-in-progress, seems to have some layout problems with the table

@crisbeto

Okay, this is working correctly now, so it's ready for review. I've tested it on VoiceOver, NVDA and JAWS with Chrome.

@jelbourn

I believe that option you're looking for is already there. It's called Show Action Buttons.

Ah, I see. In that case everything generally looks good, just want to get Kristiyan's input on the CSS here.

https://github.com/angular/components/pull/24171/commits/ddaebdcb54f6619098aa2b485802c60f33e58ec5#diff-c9da88d358126fd9af0bcfe70ca9dce66f53916557502d2e817772d860c9822cR51
^ pushed a fix for the accidental font change

https://github.com/angular/components/pull/24171/files#diff-e546879714a61e2a4f78783bb86bfd5a75f2d1acb0fb1651af43299b12530cacR64
^ pushed a fix that changes aria-selected to aria-pressed.


Publish on the Snap Store

New feature proposal

Please provide an actual usecase that requires your new feature.

The Snap Store is another way for Linux apps to be installed and be auto-updated. It works on most distributions and it's generally extremely convenient.
I agree that go get is also extremely convenient, but one of its disadvantage is that the generated program doesn't update itself. Snap resolves this issue.
There's even a tutorial on building Go apps as snaps on Snapcraft using Go-Ethereum geth as an example.
https://docs.snapcraft.io/build-snaps/go
Once it's done, publishing on the snap store can be done automatically by the CI/CD to save time in a "set and forget" manner.

@NatoBoram is there any work you can complete on your own via a PR so it can just get merged?

Any progress?


Adds API enablement in the IDE to the cloud library management features

@ivanporty @patflynn
Please don't review the code yet. Still needs cleanup. Just look at the functionality now (screenshots).
This greatly simplifies the approach of integrating API enablement in the cloud library management workflows. Instead of a new panel entirely in a wizard flow, API enablement is integrated into the cloud library screen:
Select cloud libraries, and configure the API management section. (Service account related things will appear here too in the next PR):
TODO: add help icon indicating why APIs need to be enabled with a link to the docs

Select a cloud project on which to enable this APIs:

APIs are being enabled on GCP:

Notification to the user:

To understand a flow a bit better, when we hit 'OK' in 'Add Cloud Libraries' dialog, a user is asked for a project selection in a new dialog, correct? Is this only when new APIs need to be enabled on GCP, and if not, project selection is not required? What happens if someone decides he doesn't want to select a project now and hits 'Cancel' - does it go back to 'Add Cloud Libraries' again?

To understand a flow a bit better, when we hit 'OK' in 'Add Cloud Libraries' dialog, a user is asked for a project selection in a new dialog, correct? Is this only when new APIs need to be enabled on GCP, and if not, project selection is not required?

Correct - if there are no APIs to be enabled (and in the future - no service account modifications to be made) then the user will not be shown this dialog

What happens if someone decides he doesn't want to select a project now and hits 'Cancel' - does it go back to 'Add Cloud Libraries' again?

If the user hits cancel. Then currently it will close everything. I was thinking about this too. Do you think it would be better to send them back to the 'Add cloud libs' dialog?

It feels it would be a bit more natural to get to the previous step instead of closing everything - maybe a usr just realized API enabled per project and needs to double check what he selected - if we keep the original 'Add Cloud Libraries' with the current state, it might be a bit easier.

agree. I'll update it to that behavior.

Oh, by the way, won't we also want to show confirmation we added libraries as dependencies after dialog is done? I.e. another notification, same style as API on GCP, with module name and library names.

you mean after the libs are added to the POM? that is also already shown as a bubble (and in the event log). I jsut didn't show the screenshot here.

That's great, thanks!

Another thing - library dependencies are added to the module and stays with it, but we may choose an arbitrary project when we run/deploy the actual service/app. We may add a warning or validation check for deployment later, something like 'Module XYZ uses Cloud ABC API, but selected project FOO does not have this API enabled on Google Cloud.' And then maybe suggest immediately open add cloud libraries dialog to enable missing APIs.

Yes. I agree. I think @patflynn brought up this point too earlier. In the deployment config it would be a good enhancement to add this type of notification / integration into the API management.

I added some tooltip help text to explain what this enablement thing is all about. See the updated screenshots

Awesome, crystal clear!


Fixing reading variable in dictionary redis-conf

Pull request https://github.com/idealista/redis-role/pull/31 introduce a bug when the accessing to
redis-confs.cluster-config-file was done incorrectly.
Since dashes are reserved characters https://github.com/ansible/ansible/issues/8849,
the accessing should be done in the "dictionary" way
This fix #38

Hi @lihiwish,
Thanks again for your contribution. Could you please update the changelog as well?
We're gonna open an issue to update our cluster tests (and, for instance, test if the cluster config file is present). They can't be done in Travis, but it is interesting to test it locally. Any suggestions or contributions will be very appreciated.
Regards,
Jose

Hi @jnogol
I've updated the changelog.
I can try working on local cluster tests. I think it can be useful for me as well :)
I will start digging to see how this can be done nicely

You're right, sorry. I guess coffee didn't make effect enough at the time. Merging!


FPV Combat Gadget

Showcases multi-level menu system with rotary encoder for input.

@ysoldak please rebase against main thanks!


Is there a service for automatic TypeDoc generation like in Rust crates.io?

Search terms

automatic
Question
Is there a website that automatically builds TypeDoc API documentation from NPM packages, similiar to Cargo's crates.io? I think crates.io uses Docker.

There is not, unfortunately doing this comes with a whole host of problems that rust (and to a lesser extent, deno) don't have. I'm unlikely to ever build something like this.

Most packages don't ship with types... but the compiler in JS mode can infer some types from them that ought to show up.
Packages without types might have an @types package that needs to be paired with the version of the package, and it's not always clear how to do that for anything but the latest version. (And there might be more type dependencies declared with * versions, since that what definitely typed uses), could be mitigated by only supporting the latest version..
What gets used as the entry point or entry points? #1937 will enable trying to figure this out from package.json, but we don't have that yet. It's tricky to map from JS output files back to the TS files, even trickier when considering libraries that bundle their output so there isn't a 1-1 mapping.
If building from declaration files, we can't link to source code for the declaration. Even if declaration source maps are published, they don't include all exports for some reason, so can't be relied on.
ESM/CJS is terrible, and a service like this should differentiate between them.
A service like this should really allow interconnected docs. This is more possible since 0.24, but it's still not something that'll come for free. I think this one is relatively easy to fix via a custom link resolution plugin.

... probably way more I haven't even thought of, and an unlikely to in the middle of the night.


fix: file-> export report works

Pop up the file dialog before dispatching the action.
Fixes #26

Merged in e0d1463


Add the Atom color scheme

please add the Atom color scheme for higlight.js

We only can add something if someone submits it, we don't do it by request. Here's more details: http://highlightjs.readthedocs.io/en/latest/language-requests.html


Shop now button does not work

@codervivek5  The shop now button does not work . I am a gssoc'24 contributor please assign this to me.
I want to make a working 'shop now' button and want to add a page for it.

how can you fix it.... explain about the flow and also about your changes

@codervivek5 on clicking shop now button it will go to a page where there will be sections for all the category to select produt from them and the UI will look like this

There will be functionality for adding to cart


Consider allowing reverse engineering to generate CLR property defaults based on column defaults

See #9617. For example, if a column State has a default of "WA", then the entity type would be generated as:
public partial class Customer
{
    public string State { get; set; } = "WA";
}

Consider also parsing common SQL defaults, like getdate(), and generating a CLR equivalent.

Triage: We will consider doing this in the future, but:

Probably in a limited form that doesn't require any complex parsing of SQL

In a way that doesn't change the semantics of the default--for example, we wouldn't make getdate() be calculated on the client rather than the server
This means probably just simple literals

It will likely require some form of templating or other customization mechanism for code generation as a prerequisite so that the defaults can be used selectively where wanted.


sign command:  fix Options table

Scroll halfway down the Options section here and you'll see that the table was broken by some new lines.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/tools/cli-ref-sign.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add issue template for {bug,enhance,support}

Pull Request Test Coverage Report for Build 472

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.374%

Totals

Change from base Build 471:
0.0%

Covered Lines:
476

Relevant Lines:
984

💛  - Coveralls


Permit to disable comments from fediverse network

What
I would like to be able to avoid any comments in wordpress coming from fediverse.
Why
I manage comment and reply to them directly in fediverse and never show them on post and pages.
How
No response

Duplicate of #181

@baby-gnu For your site you can use Settings -> Discussion, or choose per-post Discussion setting (un-check allow comments).
However, fediverse users can still reply to a post, this is a protocol level issue... See: mastodon/mastodon#8565 (comment)

it's more or less stalled on protocol talks right now. the current roadblock is trying to make it work for both reply-based systems and comment-based systems, and maintaining compatibility between the two

Thanks @mediaformat, disabling discussion do not prevent wordpress to put comments to pending (and notify author):
The toots from fediverse are still in pending

Ah I understand, you would like a setting to to drop Fediverse replies!
So would you expect that globally, per post-type or per-post?

Ah I understand, you would like a setting to to drop Fediverse replies! So would you expect that globally, per post-type or per-post?

My use case is globally :+1:

Just out of curiosity: most users prefer this plugin, because it supports federated comments, otherwise they use crossposing-plugins. Why do you prefer this plugin, even without the comment feature?

crossposing-plugins

First, I didn't know about other plugins, I discovered the activitypub plugin by a toot on the fediverse.
I like the ability to cut&past a wordpress URL directly in my mastodon client search box to share a blog post :+1:

I like the ability to cut&past a wordpress URL directly in my mastodon client search box to share a blog post 👍

Interesting, I hadn't realised this was a possibility @baby-gnu !

I'd like to add my vote to this issue.

Just out of curiosity: most users prefer this plugin, because it supports federated comments, otherwise they use crossposing-plugins. Why do you prefer this plugin, even without the comment feature?

Personally, I've opted to disable comments on some of the posts on my site, but not all of them. When comments are open on a post, I am interested in receiving feedback, whether directly in the comments or via the Fediverse. When comments are closed for a post, I would rather not allow comments, via the site and via the Fediverse. Today folks can still leave comments via the Fediverse.
Thank you!

Internal reference: p1713216236135369-slack-C0CMN0V97

@jeherve I am not sure if it is a good idea, to re-use core settings for that. We had quite some discussions on the Webmentions plugin, where we tried to re-use the ping settings.
There are folks that disable comments completely, to only use Webmentions and ActivityPub feedback, there are others (like you) that want to have no feedback at all when disabling comments.
I would suggest to have it as a separate setting, where you can disable feedback from the fediverse completely and per post!?!

Is it possible to hook into the "Discussion" section in the Gutenberg sidebar?

I would suggest to have it as a separate setting, where you can disable feedback from the fediverse completely and per post!?!

Yeah, that may be a good option too.

Is it possible to hook into the "Discussion" section in the Gutenberg sidebar?

No, it is not filterable right now.
https://github.com/WordPress/gutenberg/blob/bea46cbe967bb481b12b9f20a6024d3ede609daf/packages/editor/src/components/post-discussion/panel.js#L18
You could suggest that improvement though.

There are 2 ways you could might do this currently:
One is code based, using the following constant, you can disable all incoming interactions:
define( ACTIVITYPUB_DISABLE_INCOMING_INTERACTIONS, true );
The other way would be with a Block based theme, you can remove the Comments display block.

I think the comment of @mediaformat explains all possible options.


[P0] Verify which metrics CAIKit/TGIS produce

@VedantMahabaleshwarkar could you provide more details here? And add necessary labels, complexity etc?

@heyselbi this work will be tracked as a part of the overall metrics investigation. Can we add this issue as a subtask in https://github.com/opendatahub-io/opendatahub-community/issues/70 ?

instructions to enable caikit metrics in Openshift Console : https://github.com/opendatahub-io/opendatahub-community/issues/70

Caikit and tgis metrics have been verified at port 8086 and 3000 respectively in the kserve container.
Getting the metrics working with the observability stack is not in the scope for this particular ticket and will be tracked in the overall metrics spike for kserve


add nginx appcr in openshift-gitops for e2e test

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
adds an nginx app cr in openshift-gitops namespace for GITOPS-1004 test scenario
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:

CI fails on permissions by label step, @shubhamagarwal19

/lgtm
/approve