Support split broadcast join condition into ast and non-ast [databricks]

This fixes https://github.com/NVIDIA/spark-rapids/issues/9759. Following similar approach as nested loop join case.

build

Will take care of DBX failure.

build

build

build

Trying to avoid wrapping a placeholder project node to workaround output attribute.

build

build

build

Comments addressed. Please help take further look. @jlowe Thanks!

build

build

build

build

build

build

Failed due to https://github.com/NVIDIA/spark-rapids/issues/9977

build

build

@NVnavkumar  can you help take a look? All comments are addressed with checks passed. Thanks!


training

Is the training code opened?

Is the training code opened?

You can follow the readme in https://github.com/AIR-THU/DAIR-V2X/tree/main/configs to train and eval the model.


docker-compose: add zsh completion

Motivation for this change
Add zsh completion script in docker-compose package.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Thank you Gerschtli!


Data missing on visualization plots

At the end of the measurements, some small portion of data is missing in visualization, because the visualization is not update one last time after acquisition threads have stopped.

Done in 0e701f13d017d43d4a4c1cb587883185768d302b.
Closing.


How to create enterprise development profile using match?

Using match how can I create development certificate and development profile instead of InHouse profile ?

@janpio so you mean normal development type will also work with enterprise account ?

Example #4 in what I linked to:
match(git_url: "https://github.com/fastlane/certificates",
      type: "enterprise",
      app_identifier: "tools.fastlane.app")

Example No 4 in what I linked to:
match(git_url: "https://github.com/fastlane/certificates",
      type: "enterprise",
      app_identifier: "tools.fastlane.app")

This will create InHouse profile or development ? I think this will create InHouse profile, if not that how can I create InHouse profile ?

There is a difference?

There is a difference? What exactly does "inhouse" mean? Is this a special version of an enterprise profile?

InHouse is distribution profile, when you specify type as "enterprise" it is creating InHouse profile, I have not checked "development" with enterprise account so I am not sure it works with enterprise account or not.


cannot connect to host: fork/exec /app/wsl-gvproxy.exe: no such file or directory

Hi guys!
Something strange happened. The service stopped running all of a sudden.
wsl.exe -d wsl-vpnkit --cd /app wsl-vpnkit

VPNKIT_GATEWAY_IP=<IP_ADDRESS>
VPNKIT_HOST_IP=<IP_ADDRESS>
VPNKIT_LOCAL_IP=<IP_ADDRESS>
TAP_MAC_ADDR=5a:94:ef:e4:0c:ee
VMEXEC_PATH=/app/wsl-vm
GVPROXY_PATH=/app/wsl-gvproxy.exe
TAP_NAME=wsltap
CHECK_HOST=example.com
CHECK_DNS=<IP_ADDRESS>
DEBUG=0
set +x
WSL2_TAP_NAME=eth0
WSL2_GATEWAY_IP=<IP_ADDRESS>
'[' 0 -eq 0 ]
set +x
starting vm and gvproxy...
ERRO[0000] cannot connect to host: fork/exec /app/wsl-gvproxy.exe: no such file or directory
started vm and gvproxy
ERRO[0001] cannot connect to host: fork/exec /app/wsl-gvproxy.exe: no such file or directory
ERRO[0002] cannot connect to host: fork/exec /app/wsl-gvproxy.exe: no such file or directory
ERRO[0003] cannot connect to host: fork/exec /app/wsl-gvproxy.exe: no such file or directory
ERRO[0004] cannot connect to host: fork/exec /app/wsl-gvproxy.exe: no such file or directory
ERRO[0005] cannot connect to host: fork/exec /app/wsl-gvproxy.exe: no such file or directory
ERRO[0006] cannot connect to host: fork/exec /app/wsl-gvproxy.exe: no such file or directory

Installation was done according to the manual. Yesterday and before everything works fine. No updates have been installed.
The change systemd=false in /etc/wsl.conf helps to start the kit in manual mode. But at the same time, it is not possible to start the service at the start of the WSL.
Ubuntu 22.04
WSL <IP_ADDRESS>
Please, help!!!

I had a similar problem, but instead it was "exec format error". This fixed it.
Not sure if it's related to this.

I had a similar problem, but instead it was "exec format error". This fixed it. Not sure if it's related to this.

Same here, but I used the approach described in the comment bellow the one you've used.


TypeError: Cannot read property 'split' of undefined

When running on circle CI with nightmare we're seeing the following error that crashes our client-side tests:
I20190820-16:20:47.578(0)? uncaughtException error TypeError: Cannot read property 'split' of undefined
I20190820-16:20:47.578(0)?     at EventEmitter.nightmare.on.on (packages/meteortesting:browser-tests/browser/nightmare.js:52:38)
I20190820-16:20:47.578(0)?     at emitOne (events.js:116:13)
I20190820-16:20:47.578(0)?     at EventEmitter.emit (events.js:211:7)
I20190820-16:20:47.578(0)?     at ChildProcess.<anonymous> (/home/circleci/app/microservices/www/node_modules/nightmare/lib/ipc.js:49:10)
I20190820-16:20:47.578(0)?     at emitTwo (events.js:126:13)
I20190820-16:20:47.578(0)?     at ChildProcess.emit (events.js:214:7)
I20190820-16:20:47.579(0)?     at emit (internal/child_process.js:762:12)
I20190820-16:20:47.579(0)?     at _combinedTickCallback (internal/process/next_tick.js:142:11)
I20190820-16:20:47.579(0)?     at process._tickDomainCallback (internal/process/next_tick.js:219:9)

Any idea what might cause this?

Should be fixed by #24. Please re-open if it's still present.


Update storage-account-key-note-include.md to remove confusion in parent doc https://learn.microsoft.com/en-us/azure/storage/common/storage-account-keys-manage?tabs=azure-portal#protect-your-access-keys

Correcting the permissions that storage account keys give you as tested with Storage Explorer v1.34. Accessing a Storage account with the key gives you full access to the data, but not to the configuration or other keys.  This include is causing confusion and contradicts other parts of the parent Learn doc: https://learn.microsoft.com/en-us/azure/storage/common/storage-account-keys-manage?tabs=azure-portal#protect-your-access-keys.
Changing first sentence to read:
Storage account access keys provide full access to the storage account data, and the ability to generate SAS tokens. Always be careful to protect your access keys. Use Azure Key Vault to manage and rotate your keys securely. Access to the shared key grants a user full access to a storage account’s data.

@pauljewellmsft
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Best

Are you requesting a feature, reporting a bug or asking a question?
Asking a question
What is the current behavior?
Javascript not recognized in the custom completedHtml that replaces default completed page
What is the expected behavior?
Javascript contained in the "
In the json, I assign completedHtml:results_html
The html button is recognized, but the javascript function myFunction is not. I have successfully rendered other html elements, like an image, headers, and body, so I can't figure out why the script tag is not working.
Specify your

browser: chrome
browser version: Version 67.0.3396.99
surveyjs platform (angular or react or jquery or knockout or vue): react
surveyjs version: 1.0.1

SurveyJS doesn't allow scripting in markup blocks.


There is a lot of space next to the icon in some of BitComponents

I checked the Bit component out of the playground project and there is a lot of space next to the icon in BitActionButton, disabled BitRating because of the width of bit-icon.
Now they look this:

This issue has been solved.


get_state() doesn't work with ha version 2024.4.0

I build an addon in HA with python code and much usage of get_state()
I have the problem reduced to a simple piece of testcode:
import hassapi as hass
from requests import get

class TestWM(hass.Hass):
    def __init__(self):
        self.hassurl = "http://<IP_ADDRESS>:8123/"
        self.hasstoken = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJmNmUwNjRhZmM0NTM0MDI5YmNjNzU2MDkzMTc3MmQ1NyIsImlhdCI6MTcxMjIzOTUxNiwiZXhwIjoyMDI3NTk5NTE2fQ.2sO0bo3gS81-7hW6CTDf5goQEavzdEUO7SImOb-UCu4"
        super().__init__(hassurl=self.hassurl, token=self.hasstoken)
        headers = {
            "Authorization": "Bearer " + self.hasstoken,
            "content-type": "application/json",
        }
        resp = get(self.hassurl + "api/config", headers=headers)
        print(resp.text)

    def test(self):
        state = self.get_state("input_datetime.start_window").state
        print(state)

test_wm = TestWM()
test_wm.test()

When I run this code against an HA machine with version 2024.3.3: no problems
But when I run with a machine with version 2404.4.0 I get this error:
Traceback (most recent call last):
  File "/home/cees/prive/day_ahead/day-ahead/dao/prog/test_get_state.py", line 23, in <module>
    test_wm.test()
  File "/home/cees/prive/day_ahead/day-ahead/dao/prog/test_get_state.py", line 18, in test
    state = self.get_state("input_datetime.start_window").state
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/cees/prive/day_ahead/env/lib/python3.11/site-packages/hassapi/client/states.py", line 13, in get_state
    return State(**self._get(f"states/{entity_id}"))  # type: ignore
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: State.__init__() got an unexpected keyword argument 'last_reported'

Process finished with exit code 1

I have read the release notes but only found some information about a new attribute "last_reported".
What am I doing wrong?

Thanks for reporting, fixed in now in 0.2.1!


Issues during model testing

Hi, thank you for providing such an outstanding work, but I have some confusion.
This image is the partial point cloud of a cylindrical object in the YCB dataset captured by the camera in a simulation environment.

And this image is the result of completion using the pre-trained model.

The result is obviously incorrect, not as perfect as the input in training, does the input point cloud need some processing? Or is there something else wrong?

Hi,
Sorry for the delay. Can you provide me with the file of the partial point cloud? I would need to run it on my side to help you further on debugging.
Best,
Nuno


In-the-wild Inference input format

Hello and thanks for sharing your code.
May I please ask about the structure of the .json file needed for the In-the-wild Inference for 3D pose estimation? I want to use 2d estimations of another network other than AlphaPose and was not sure how to structure my 2d poses so it's compatible with your code.
Thanks in advance for your help.

This worked for me:
[     {         "image_id": "0.jpg",         "category_id": 1,         "keypoints": [<PHONE_NUMBER>796875,<PHONE_NUMBER>273438, 0.5740299224853516,             ...         ],         "score": 1.8695456981658936     },     {         "image_id": "1.jpg",     ...
Where each entry to the json represents a prediction frame. Since the authors convert halpe to h36m, the keypoints entry is length 78 (26 x [x,y,score]).

This worked for me:
[ { "image_id": "0.jpg", "category_id": 1, "keypoints": [<PHONE_NUMBER>796875,<PHONE_NUMBER>273438, 0.5740299224853516, ... ], "score": 1.8695456981658936 }, { "image_id": "1.jpg", ...
Where each entry to the json represents a prediction frame. Since the authors convert halpe to h36m, the keypoints entry is length 78 (26 x [x,y,score]).

Thank you very much for your answer.
About the entry length, do you know whether they do the conversion before running infer_wild.py, or it is supposed to be embedded in the code, cause I did not find anywhere in their code that halpe2h36m() is being called. As my keypoint is already being converted to h3.6 from coco I wanted to check whether I can use 17 * [x,y,score].

it's quite hard for me to install alphapose, can't it be any other 2d pose estimation model?

Any pose estimation model should work as long as you properly format the output json. I personally used yolov5 + ViTPose topdown pipeline.

Any pose estimation model should work as long as you properly format the output json. I personally used yolov5 + ViTPose topdown pipeline.
Hi，fan23j，Can u share me your script how to use the vitpose output to generate the input format？Thx

Any pose estimation model should work as long as you properly format the output json. I personally used yolov5 + ViTPose topdown pipeline.
Hi，fan23j，Can u share me your script how to use the vitpose output to generate the input format？Thx

sure give me some time to upload to github

Here you go. Let me know if you run into any issues.
https://github.com/fan23j/yolov5-vitpose-video-annotator

Any pose estimation model should work as long as you properly format the output json. I personally used yolov5 + ViTPose topdown pipeline.

That's correct, thanks Jack! For other 2D pose estimators (and keypoint formats), you only need to change line68-line77 in https://github.com/Walter0807/MotionBERT/blob/main/lib/data/dataset_wild.py (read the 2D results and convert to H36M format).
Let me know if you have further questions.

Hi Jack,
That's correct, thank you for the clarification!
To adapt other 2D pose estimators and their keypoint formats, you only need to modify lines 68 to 77 in the following file: dataset_wild.py. Specifically, you will need to read the 2D pose results and convert them into the H36M format.
Thanks again for your interest in our work! Please don't hesitate to reach out if you have any further questions or need additional clarification.

Hi @Walter0807  May I please ask about the structure of the .json file needed for the In-the-wild Inference for 3D pose estimation?
I already got json data from AlphaPose .
but motionbert wild Inference i get error in json format .
"IndexError: index 19 is out of bounds for axis 1 with size 17"
how can fix it ? please give me soluation.


Update auth to omit content-type headers and body

Describe the bug
Symphony recently made a release that changed how an invalid request is handled. This causes issues with session creation.
To Reproduce
Sending empty body to POST /sessionauth/v1/authenticate results in either a 401 response (if a content-type header is sent) or a 500 response (if no header is sent).
E.g., the following results in a 401 response:
def _client_cert_post(host: str, request_url: str, cert_file: str, key_file: str) -> str:
    request_headers = {"Content-Type": "application/json"}

    context = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
    context.load_cert_chain(certfile=cert_file, keyfile=key_file)
    connection = http.client.HTTPSConnection(host, port=443, context=context)
    connection.request(
        method="POST",
        url=request_url,
        headers=request_headers,
        body=json.dumps({}),
    )
    response = connection.getresponse()

    if response.status != 200:
        print(response.read().decode("utf-8"))
        raise Exception(
            f"Cannot connect for symphony handshake to https:{host}{request_url}: {response.status}:{response.reason}"
        )
    data = response.read().decode("utf-8")

    return json.loads(data)

Expected Behavior
We expect tokens to be returned as in https://rest-api.symphony.com/main/bot-authentication/session-authenticate
Error Message
401 or 500 response from Symphony
Runtime Environment
CSP: 0.0.5
SYS: 3.11.9 | packaged by conda-forge | (main, Apr 19 2024, 18:36:13) [GCC 12.3.0]
SYS platform: Linux
Additional context
Without authentication tokens, this adapter becomes unusable with certificate and key.

From here: https://rest-api.symphony.com/main/bot-authentication/session-authenticate#session-token-management
It says:
The token you receive is valid for the lifetime of a session that is defined by your pod's administration team. This ranges from 1 hour to 2 weeks.
You should keep using the same token until you receive a HTTP 401, at which you should re-authenticate and get a new token for a new session.
Datafeeds survive session expiration, you do not need to re-create your datafeed if your session expires.
I think it might be worthwhile to incorporate a retry here (and probably also for the other normal checks) so that bots can last past session expiration.

@adamzuyang I agree with @NeejWeej but at the same time I'm ok getting this patch out now since symphony is rolling out a breaking authentication change on their end.  @NeejWeej please open a separate issue to track.
@adamzuyang please fix the lint errors so that we can get this in


Facts with int values which are strings internally are not findable

Describe the bug
Currently puppetboard is able to detect the facts value type correctly from the puppetdb calls, but the generated links do not differentiate between string and int, resulting in the call to parse_python switching it back to an int.
An example will hopefully make this clearer
Using Centos operating system facts, which are stored into puppetdb as strings.
https://puppetdb/fact/operatingsystemmajrelease
This page will list all the hosts with this fact present. The generated html is showing type string here too
6

Following the link - https://puppetdb/fact/operatingsystemmajrelease/6 - will display no entries.
The facts code is calling parse_python which is returning the int type to the query.
https://github.com/voxpupuli/puppetboard/blob/c0db5abcc09e419381b457af45bda2dd543cc621/puppetboard/views/facts.py#L62-L65
If I manually quote the value - https://puppetdb/fact/operatingsystemmajrelease/"6" - the search works and displays results.
Values which are int internally, and displayed as int on the facts page do search correctly.
Puppetboard version
F.e. 3.6.1 (verified code has not changed for this flow since)
Environment and installation method
F.e.:

Centos 7 and Python 3.8,
PyPI package.
puppetdb-6.21.0-1

While quoting all strings does work as a solution here, that just feels wrong which is why I haven't attached a PR here. If you have a better solution that could work, I'm happy to PR things.
Pretty print explicitly tries to not quote things too https://github.com/voxpupuli/puppetboard/blob/c0db5abcc09e419381b457af45bda2dd543cc621/puppetboard/static/js/pretty.js#L5-L6

Hi @ryaner! Thanks for reporting this.
I don’t know when I will have the time to dig into this as I will be pretty busy over the next ~2 weeks so even more than always, PRs with a fix is very welcome.

My current patch is below, but I keep thinking there must be a better solution that this. So far it does work on all the int stored as string values though.
diff --git a/puppetboard/views/facts.py b/puppetboard/views/facts.py
index 714eba9..2715cd0 100644
--- a/puppetboard/views/facts.py
+++ b/puppetboard/views/facts.py
@@ -93,7 +93,7 @@ def fact_ajax(env, node, fact, value):
                 fact_h.node))
         if value is None:
             if isinstance(fact_h.value, str):
-                value_for_url = quote_plus(fact_h.value)
+                value_for_url = '"' + quote_plus(fact_h.value) + '"'
             else:
                 value_for_url = fact_h.value

If it works and there are no side effects, then let’s create a PR and merge it. Let’s be pragmatic, @ryaner. :)

The fix has been released in v4.0.3 today.

Nice thanks for that @gdubicki


Overcoat only requires PMKPromise, not all of PMK

Should you ever need more of PromiseKit it’s easy to add more subspecs.

@mxcl thanks! :+1:

When I was using Overcoat 2.1.1, cocoa pods installed PromiseKit 1.5.3... from your spec. Now it seems to be going backwards that Overcoat 3.0 uses PromiseKit 1.2...? Also, the Latest PromiseKit is 2.1.. is that suppose to be in Overcoat 3, (just transposed the numbers)?

Hi @numerics, the version specified in the Podspec is ~> 1.2 which means you could install any version which is equal to or greater than 1.2 but smaller than 2.0. (>=1.2 and <2.0). So it's okay to keep using 1.5.3.
I don't really use PromiseKit, but I could still try to adopt the Overcoat to compatible with the newest PromiseKit. You're welcome to submit a PR for this too. :smile:

I could submit a PR to upgrade to 2.x, it probably is minimal.


React Native - Immer with Expo.io Reducer returned undefined during initialization

🐛 Bug Report
I am trying to add immer to a react native expo app with redux.
I am getting this error:
React Native - Immer with Expo.io Reducer “user” returned undefined during initialization
To Reproduce
Before Immer (working)
import { LOGIN_ACTION } from '../actions/actionTypes';

const initialState = {
  user: false,
};

const User = (state = initialState, action) => {
  switch (action.type) {
    case LOGIN_ACTION:
      return {
        ...state,
        'user': action.user
      };

    default:
      return state;
  }
};

export default User;

After Immer (not working)
import produce from 'immer';
import { LOGIN_ACTION } from '../actions/actionTypes';

const initialState = {
  user: false,
};

const User = (state = initialState, action) => {
  produce((state, draft) => {
    switch (action.type) {
      case LOGIN_ACTION:
        draft.user = action.user;
        break;
    }
  });
};

export default User;

What am I doing wrong?
Here is the full error I am getting:
Reducer "user" returned undefined during initialization. If the state passed to the reducer is undefined, you must explicitly return the initial state. The initial state may not be undefined. If you don't want to set a value for this reducer, you can use null instead of undefined.

redux.js:366:22 forEach [native code]:0 assertReducerShape redux.js:359:32 combineReducers redux.js:422:23 index.js:4:31 loadModuleImplementation require.js:292:12 index.js:2 loadModuleImplementation require.js:292:12 App.js:5 loadModuleImplementation require.js:292:12 AppEntry.js:2 loadModuleImplementation require.js:292:12 guardedLoadModule require.js:179:45 global code :0

Expected behavior
Should work like react! I followed this example:
https://github.com/react-boilerplate/react-boilerplate/blob/master/app/containers/HomePage/reducer.js

return produce(....
Op di 30 jul. 2019 03:10 schreef tomer-tgp<EMAIL_ADDRESS>
🐛 Bug Report
I am trying to add immer to a react native expo app with redux.
I am getting this error:
React Native - Immer with Expo.io Reducer “user” returned undefined during
initialization
To Reproduce
Before Immer (working)
import { LOGIN_ACTION } from '../actions/actionTypes';
const initialState = {
user: false,
};
const User = (state = initialState, action) => {
switch (action.type) {
case LOGIN_ACTION:

  return {

    ...state,

    'user': action.user

  };

default:

  return state;

}
};
export default User;
After Immer (not working)
import produce from 'immer';
import { LOGIN_ACTION } from '../actions/actionTypes';
const initialState = {
user: false,
};
const User = (state = initialState, action) => {
produce((state, draft) => {
switch (action.type) {

  case LOGIN_ACTION:

    draft.user = action.user;

    break;

}

});
};
export default User;
What am I doing wrong?
Here is the full error I am getting:
Reducer "user" returned undefined during initialization. If the state passed to the reducer is undefined, you must explicitly return the initial state. The initial state may not be undefined. If you don't want to set a value for this reducer, you can use null instead of undefined.
redux.js:366:22 forEach [native code]:0 assertReducerShape redux.js:359:32 combineReducers redux.js:422:23 index.js:4:31 loadModuleImplementation require.js:292:12 index.js:2 loadModuleImplementation require.js:292:12 App.js:5 loadModuleImplementation require.js:292:12 AppEntry.js:2 loadModuleImplementation require.js:292:12 guardedLoadModule require.js:179:45 global code :0
Expected behavior
Should work like react! I followed this example:
https://github.com/react-boilerplate/react-boilerplate/blob/master/app/containers/HomePage/reducer.js
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/immerjs/immer/issues/399?email_source=notifications&email_token=AAN4NBBJRJRS4TMANRTNIELQB6IHBA5CNFSM4IHXOLZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCFSY4Q,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAN4NBAO6TUPIEZG2N6GECTQB6IHBANCNFSM4IHXOLZQ
.

Thank you! I missed it because of the implicit return of es6 arrow function.

This must be added to the docs.


Added binary tree implementation

Added the file binary-tree.py under user-name folder in the repo.
The code is well optimised and runs well.
#hacktoberfest2023_contribution

@JosephLahiru Will this be counted for hacktoberfest2023?


Smart open

Modified load_file and save_file operator to use smart_open.

@utkarsharma2 I think you need to add smart_open to the pyproject.toml s.t. it will download it when running tests

@utkarsharma2 I think you need to add smart_open to the pyproject.toml s.t. it will download it when running tests

My bad, added.


⚠ Bofrost.lu has degraded performance

In 89b6630, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 872 ms

Resolved: Bofrost.lu performance has improved in 648a7e3.


[BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Backport of #13725 to release-1.10.

Thanks for the review @rmetzger. Merging this PR now.

Manually merged via 933041b3d8d192391437e343857f1dec14c544d1


Checkbox with 1-way binding and change results in a weird state

When using a checkbox with 1-way binding and the change event the state of the checkbox doesn't match the UI
The following example visualizes the issue when clicking the checkbox
https://user-images.githubusercontent.com/176582/148435730-e4a54718-ded3-40e5-bbc4-f0ab26d3aa0b.mp4
{checked}
<Checkbox checked={checked} on:change={change} />

<script lang="ts">
  import { Checkbox } from 'carbon-components-svelte'

  let checked = false

  const change = event => {
   checked = event.target.checked
  }
</script>

The problem seems to be in the order of the on:change declarations in the Checkbox component.
Here is the diff that solved my problem:
diff --git a/node_modules/carbon-components-svelte/src/Checkbox/Checkbox.svelte b/node_modules/carbon-components-svelte/src/Checkbox/Checkbox.svelte
index bf2a00a..4c75280 100644
--- a/node_modules/carbon-components-svelte/src/Checkbox/Checkbox.svelte
+++ b/node_modules/carbon-components-svelte/src/Checkbox/Checkbox.svelte
@@ -80,10 +80,10 @@
       name="{name}"
       readonly="{readonly}"
       class:bx--checkbox="{true}"
-      on:change
       on:change="{() => {
         checked = !checked;
       }}"
+      on:change
       on:blur
     />
     <label for="{id}" title="{title}" class:bx--checkbox-label="{true}">

I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
This issue body was partially generated by patch-package.

I'm unable to repro when putting the code in the Svelte REPL: https://svelte.dev/repl/6f48c872218b49d89ab115e8e9b09e97?version=3.44.3
Am I missing anything?

It took me some trials to figure out the combination of the versions that fixed the error. With the following patch (edited for brevity) the issue disappeared, meaning it was somewhere in the combination of an older carbon-components and/or carbon-components-svelte.
diff --git a/package.json b/package.json
index f5a49d64..866d99af 100644
--- a/clients/crm/package.json
+++ b/clients/crm/package.json
@@ -21,8 +21,9 @@
-    "carbon-components": "^10.29.0",
-    "carbon-components-svelte": "^0.44.5",
+    "carbon-components": "^10.50.0",
+    "carbon-components-svelte": "^0.51.1",
+    "carbon-icons-svelte": "^10.44.3",

Curious – why do you have carbon-components installed? Are you using SCSS for styling?

The issue is still present after all. Visually everything seems to match, but the internal state of the Checkbox component is still off. The mismatch becomes visible when using true as the initial value. I created an updated REPL that includes a copy of the current Checkbox component with an output statement: https://svelte.dev/repl/e04844b88c0e4a1187ba16823816e317?version=3.44.3

@metonym Any thoughts on this? Can you confirm the bug? Happy to provide a PR if so.

@koffeinfrei Just throwing it out there that I'm not sure if "on:change" should even be forwarded. "on:check" should be the event to listen for [1]. Regardless, I'm happy to review a PR that would fix the behavior.
[1] on:check: https://svelte.dev/repl/d194d091568a4cde9b236d39e9938891?version=3.44.3

I'm not sure if "on:change" should even be forwarded.

Do you mean because on:check should be favored? This is a basic native event of all input fields, so I think it should be supported.

"on:check" should be the event to listen for [1]

The issue with that event is that it doesn't include the field's name, only the checked value.

I'm happy to review a PR that would fix the behavior.

:point_right: https://github.com/carbon-design-system/carbon-components-svelte/pull/1013

Fixed in v0.52.0
Thanks for getting to the bottom of this!

Just to close the loop on the discussion:

Do you mean because on:check should be favored?

This is my personal opinion: my understanding of the "Svelte way" is to be as concise as possible.
This means using two-way binding instead of relying on dispatched events to manage state (like in React). However, I understand that it may be simpler sometimes to just listen to an event when you do not need to manage state (like <Toggle on:toggle /> for example).

This is a basic native event of all input fields, so I think it should be supported.

True.

Thanks! That was fast! :raised_hands:

👍


Rename files with integers less than 10 to include leading 0 for prop…

A minor change to the filenames so that they appear in order in a directory listing.

Cool thanks!

Except I think I broke it -- can you confirm if it works for you after this? I seem to have missed references to original convention somewhere.

I just fixed it and updated.

@jboxman do you want to help Peter and I with writing these challenges?

Yeah, belatedly working in that direction. Haven't they mostly been written at this point and just need to be imported into this so unit tests can be written for them?
If you want me to work on specific challenges let me know so we don't collide.
Thanks!

So some work has been done but they're definitely not finished yet and 0 have tests written which is probably the most time-consuming part. So Peter and I have pulled what existed on the GitHub Issues here and are modifing it on the fly as we go, more or less. I'm trying to pull in content that has already been written but a lot I'm just writing from scratch.
The Challenges_Map is our rough outline as we go. For the moment, if you want to help you could take the first challenge under State: Define the initial state within the component's constructor.
I think if you've been looking through the code it should be straightforward how we are writing to the challenges but please just comment or message me on Gitter if you have any specific questions.


Develop library for common NAD  functionalities

Develop library for CRUD operations (getters. setters etc) for NAD functions.

available and under review

https://github.com/nephio-project/nephio/pull/67#issuecomment-1530909820


[Questions] Migration from BCCH to the future module

Hi,
I would like to ask some questions regarding future of BCContainerHelper and planned migration to the new Powershell module. These explanations will be helpful for users who don't have managed DevOps solution/don't use Al-Go/use custom scripts based on BCCH. We would like to prepare for this migration and start as soon as possible.

Estimated release date of new module? First half of 2025 or later?
Will new module have public repo? (the same as BCCH here)
Will be there any new part of code/script/submodule private, unavailable for public?
Will new module also support old NAV(2016+)/BC versions? New demarcation line?
What is planned for now to be cut or unsupported in comparison to BCCH?
Do you predict any extra problems (except amount of work) in migrating from one module to another? (e.g. PS7 requirement, specific scenarios)

The reason why we are warning about these things at this time is to give people time to move to AL-Go for GitHub or another managed DevOps solution. For people who decide to stay on something self-made, we don't really have much info at this time, except for:

There is not going to be a new module which contains the same functionality as BCCH 1:1
2 and 3. Everything we do will be public
We are not going to support old unsupported versions of NAV/BC
Again it isn't a 1:1
At the time we sunset BCCH, it will still be working for old stuff

Parts of BCCH (specifically the things that will be used in workflows and pipelines) will be small modules inside AL-Go for GitHub, which you can use as is or fork and use.
Other parts (specifically the things that people will be using locally) will probably be a PowerShell module, much like BCCH.
So, if you decide to stay on self-build stuff - you will have to wait some time before starting your changes, probably 2-3 years - we do not recommend moving to a running train, which might be the subject of changes.


Support vm to change password by using QGA

Is your feature request related to a problem? Please describe:
Sometimes we went to change vm's password and we have to loging the vm to change it. we havn't support a way to change it. As QGA  can change paasword without logging the vm.
Describe the solution you'd like:
I want to add a API to change the vm's password
Describe alternatives you've considered:
add a api interface to realize it such ad reboot/pause/unpause
Additional context:
Add any other context or screenshots about the feature request here.

WDYT?

@matthewei this is for sure useful. However, it is important to understand where the passwords will be stored and how they are passed to KubeVirt in order to configure the VM. They are sensitive information hence we need to be extra careful.
Otherwise, the mechanism could follow the same approach we use for injecting the ssh keys

Can i work on this issue?

/assign

@alicefr I want to add one API to realize it. just as i described. so we can privide an interfance for admin to change the vm's password. What do you think? Many thinks.

Since the guest agent supports this option, I think it makes sense. However, the security isn't only where we store the password but also the stdin where the password is prompted. The password could be leaked somewhere in KubeVirt code for example. The SSH key injection isn't so problematic because it is only the public key

yes, I know what your concern. As openstack has the same function. we can use encrypt the password. what do others guys think?

yes, I know what your concern. As openstack has the same function. we can use encrypt the password. what do others guys think?

yes, I know what your concern. As openstack has the same function. we can use encrypt the password. what do others guys think?

@alicefr I want to add one API to realize it. just as i described. so we can privide an interfance for admin to change the vm's password. What do you think? Many thinks.

Since the guest agent supports this option, I think it makes sense. However, the security isn't only where we store the password but also the stdin where the password is prompted. The password could be leaked somewhere in KubeVirt code for example. The SSH key injection isn't so problematic because it is only the public key由于客户机代理支持此选项，我认为这是有道理的。但是，安全性不仅在于我们存储密码的位置，还在于提示密码的 stdin。例如，密码可能会在 KubeVirt 代码中的某个位置泄露。SSH 密钥注入没有那么大的问题，因为它只是公钥

yes, I know what your concern. As openstack has the same function. we can use encrypt the password. what do others guys think?

Hi @ashutosh7i , how about you?

@ashutosh7i  I have finish it. How about you?

yes @matthewei i am mostly done but am occupied, i guess  you should work further.

@EdDev  could you give us some comments for  this feature?

@matthewei Very much agree with the need for this feature, can I get to know, how you guys are implementing this?

I add a POST virt-api such as  /apis/subresources.kubevirt.io/v1/namespaces/{namespace}/virtualmachineinstances/{name}/setpassword to realize it. @ashutosh7i Could you finish this PR?

Can I go on develping it?

Is there any new progress on this feature?

/reopen


Adds CancellationToken in run method

The cancellation token applies both to Run and streaming result, a.k.a. The cancellation token will be passed from Session/Tx.RunAsync to ResultStatement.NextAsync. A user has to finish consuming the result before the cancellationSource is cancelled.
When a cancellationToken passed to a session/tx.run method is cancelled, a RESET message will be sent to the server to cancel the statement running/streaming. The cancellationToken cancel event will NOT stop or interrupt any existing network read operation on the client side. It just signal the server to cancel the statement execution. It is the server who will stop to run or stream the result back. If the server is not interrupted by RESET (for some reasons a.k.a. a bug?), then the client will remain blocked.
This PR changed the place where to ack failure
Mute ack failure:
We should disallow client to send ACKFAIL if the client already sent RESET. This is because RESET will clean all failure state on server side. Then if we still send ACKFAIL after RESET, the server will complain that there is no error to ack. Therefore we need to mute ACKFAIL from a RESET is sent till the reply of RESET is received.
Ack failure when the failure comes:
After we changed to pull as much as messages from ChunkedInput, we might receive and handle more than one messages in SocketConnection.ReceiveOne method. While we ack failure for any server error only at the end of this method. It could be too late to let the AckFailure method know whether it can ack or not.
Here is an example: The client sends RUN, PULLALL and RESET to the server, and then the server replies FAIL, IGNORED, and SUCC in one chunk. If we ack failure after we read all messages in this chunk, then we already passed the time slot when a RESET is sent till the reply of RESET arrives. We would think we could ACKFAIL now. However the truth is we should not in this case. This problem would go away if we ack failure at the moment the failure occurs.
Changes
AckFail is a protocol. Therefore when we receive an error, we will try to ack fail. Then the connection will help us to test if it can ack or not and enqueue the messages if it can ack.
PooledConnection will no longer handle ack failure, instead, it only cares about if the connection has any unrecoverable error or not. If it has, then this connection will be closed. If it does not, then it will be reused.
This PR also fixed a bug in DelegatedConn where an error from chained tasks passed to next call as an aggregated error rather than its base error.

Write a test to confirm tx is rolledback properly after cancelled


Licensing compliance

Chris, it's great that you're continuing the work in Scally - it shows you passion.
I must, however, ask that you follow the original licence of the software.
One is not allowed to change the licence from Apache 2 to MIT for code created by Westfield Labs.  One must also keep the Westfield Labs copyright, even though you're granted a licence to redistribute.
Any extra work you add can be licensed as you see fit.
Please refer to section 4 of the Apache Licence and correct your repository for compliance.
Thank you

Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:
(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and
(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and
(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and
(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.
You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

Thiago,
Sorry about my ignorance around the licensing and copyrighting. I believe I have made the adjustments you're wanting? See here.
If that doesn't suit please let me know what else I am missing.
Thanks


ConvertersConverterProvider needs to support Converters.chain

! Problem, how to resolve strings to class in GWT w/out hardcoding class names to class, which will always be incomplete, because new ConverterProviders will introduce new types unknown to ConverterConverterProvider.


new tests + refactoring

Neoscan cache

merge "Server" and "Worker" module in one, I did not find a good reason to separate it into two genserver
add 12 unit tests (43% -> 96%)

Neoscan node

reduce the number of node for the test config (only 5) to speed up the tests
refactor Blockchain module
refactor HttpCalls module
add 17 tests (40% -> 90%)

Neoscan sync

small refactoring
add 2 test (6% -> 61%)

Pull Request Test Coverage Report for Build 600

66 of 76 (86.84%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+9.3%) to 51.453%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

apps/neoscan_sync/lib/neoscan_sync/genstage/consumer.ex
0
1
0.0%

apps/neoscan_node/lib/neoscan_node/notifications/notifications.ex
4
5
80.0%

apps/neoscan_node/lib/neoscan_node/http_calls/http_calls.ex
15
17
88.24%

apps/neoscan/lib/neoscan/transactions/transactions.ex
0
2
0.0%

apps/neoscan_cache/lib/neoscan_cache/cache.ex
19
23
82.61%

Totals

Change from base Build 599:
9.3%

Covered Lines:
903

Relevant Lines:
1755

💛  - Coveralls


Added support for specifying a timer name.  Timers with a timerName prop...

...erty set will only respond to start, stop, resume, and clear events if the timer's name is specified on the event args.
This should allow for multiple timers of different purposes nested underneath a single controller.  This change only adds support for the start, stop, resume and clear events.  Adding support for the timer-set-countdown event looked like it would induce a breaking change, so I skipped it for now.
What are your thoughts on this?

Is there a way to broadcast for multiple timers? I have multiple countdowns to display but                     $scope.$broadcast resets all the countdowns on my page.

Hi @arun0009,
I use this for example :
        document.getElementById('chrono').getElementsByTagName('timer')[0].start();
        document.getElementById('chrono').getElementsByTagName('timer')[0].stop();

Of course, it would be better to use the angular way. In my opinion a service is the best way to perform it.

Can you update the docs or write here example how to use this feature? cause i have multiple timers in my page and i want to know in the timer-stopped event which one is stopped.

Hello,
It's possible to add a name or id to each timer, not to hard. But I find this is not the proper solution, the correct way in my opinion is to create separate events/listeners for each one. What i'm doing now is just to set a name for each timer and then I have "like a kind of machine state" hearing for "timer-tick" event and depending on the name, I choose what I want to do, but I think this is a crappy solution.
If anybody has another solution I'm glad to her it!

Any movement on this? Either the timer element should be returned in the event args or this PR should be accepted.
The ability to handle timers independently seems like a pretty basic requirement. Anyone have a good workaround?

Any movement on this? i'm looking for a solution just like you guys, how did you solve that problem guys?

@siddii Any chance of this getting merged in?

Closing this due to lack of interest


fix: Add EBS CSI policy to EKS

The current policy set omits a required built-in policy to allow the ebs-csi driver to provision EBS volumes.

Did you test upgrades and downgrades

Testing discussion aside, this is on hold until Ross and I can talk about this a bit further about how we want to manage this.


Dbeaver Installation issues

Hi, I am seeing issues with dbeaver 5.0.1 installation. It Seems like its related to the Java in my windows machine. I am looking for help in resolving this.

I have updated to version 5.0.1 then am all stuck with errors and my current work is halted.
Any leads are highly appreciated.
Thank you and Warm Regards,
Srini

I am seeing this alert constantly when am installing the 5.0.1 ver. I had it aborted but it shuts down after I aborted it

does it need JDK/JRE 8 or 10 , I have 10 on my machine

Try to reboot.
DBeaver requires Java 8 but DBeaver installer already contains it. So you don't need to install Java separately.
If it still doesn't start - please post log file which mentioned in the first error dialog.

It is getting abort all the time, quickly send me the log file.

deleted the workbench and metadata files and now the dbeaver is running is fine

Thanks for info.
Perhaps workspace was corrupted. However it is enought to delete just .metadata fodler - not entire workspace with configurations, scripts, etc

Not able to upgrade to 5.1.1

Looks like you have 32bit Java and running 64bit DBeaver.
Try to download 32 bit DBeaver or use installer (which is already bundled with JRE)


being less restrictive on dependencies

i was trying out localer with our rails app, but the dependency restrictions are too tight.
so it's not actually possible to install through bundler in our case.
there is a similar issue already: https://github.com/aderyabin/localer/issues/1#issuecomment-361690308
cucumber runs fine with the changes to thor and the changelog in dry-initializer only shows additions, so it should be fine as well.

Thanks for PR. Could you please fix tests?

@aderyabin sure! had to open a PR in order to see what would break in CI

👍

it's not nice if people yank dependencies from rubygems... but now it's green!

@aderyabin would be great if a new version of the gem could be released with this change.

👍


Revert "Add an option to SignalR to guarantee ordering of send events…

… (#10506)"
This reverts commit 4646c4a5e4412dbff6e40ade887792241f5a2c94.

Why revert this? Is the reasoning recorded somewhere?


[Alignment Bug] CTA button are aligned to the center instead of left.

Call to Action buttons at bridgecrew.io are aligned to the center when the text around it is aligned to left. This looks like an alignment issue.

Can be fixed by:
CSS:
.cta-row--center {
text-align: left;
}

Thank you for the feedback, but this feedback is for our website not our GitHub Action.


[HUDI-2503] HoodieFlinkWriteClient supports to allow parallel writing to tables using Locking service

What is the purpose of the pull request
The strategy interface for conflict resolution with multiple writers is introduced and the SparkRDDWriteClient has integrated with the ConflictResolutionStrategy. HoodieFlinkWriteClient should also support to allow parallel writing to tables using Locking service based on ConflictResolutionStrategy.
Brief change log

HoodieFlinkWriteClient adds the integration with ConflictResolutionStrategy in the preCommit() method.

Verify this pull request

Added the TestHoodieClientMultiWriter to verify whether HoodieFlinkWriteClient supports to allow parallel writing to tables using Locking service.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@SteNicholas Check the azure CI?

@yanghua , I have checked the result of the azure CI and the Flink client tests are passed.

stored

@danny0405 , IMO, I could do some work to share the flink index which is stored in the state for this pull request.
What do you think about?

@danny0405 @SteNicholas : I don't see much activity in recent times. can we follow up on the PR and see how to proceed and take it home.

@danny0405 @SteNicholas : I don't see much activity in recent times. can we please follow up on the PR and see how to proceed and take it home.

@nsivabalan, I'm working for the sharing the flink index which is stored in the state.

@SteNicholas Any discussion thread or jira from which i can learn the idea of 'sharing the flink index', please?

The preCommit of HoodieFlinkWriteClient has already been implemented in #7860. Close the pull request.


Swagger OpenAPI doc formatting - multiple single/2char columns make for poor presentation

To a lesser extent this occurs with Governance Program OMAS, Organization Integrator OMIS
This occurs under Chrome
The reason is that the link to further information is longer for some of these components, and the swagger UI tool is making the column for additional information extremely narrow
There may be some options by changing config (see https://swagger.io/docs/open-source-tools/swagger-ui/usage/configuration/) - possibly this may need a new layout manager.
Other plugins/tools may be able to also format the OpenAPI document better.
The docs still work, albeit looking bad, and whilst to some extent the oddness is a regression, it's really just a manifestation of adding more docs for new components that just happen to have long names!
As such I propose we look at this in the next release cycle and at least see if there are small changes that can be made
notes as part of #5075

Trying to view the swagger UI (on a k8s deployment) now seems problematic in chrome, firefox & safari. Browsers spin up CPU & loop - with page still unresponsive after many minutes . Completely unusable.

Raised https://github.com/swagger-api/swagger-ui/issues/7305 to see if there's anything that could be done in the default layout engine.
The alternative is we look at removing the external link, or implementing our own formatted.
See https://swagger.io/docs/open-source-tools/swagger-ui/customization/custom-layout/

SHould re-review once we integrate a new version of swagger UI with a fix to long URLs -> https://github.com/odpi/egeria/issues/6158#issuecomment-1081713323

the formatting is now a lot better so closing this issue


Beacon seeds not working on main branch

Hello
First of all thanks for this great initiative !
Small bug with example provided in seeds, creating an error:
iex(1)> Content.create_component!(%{\n
...(1)>   site: :solid_flow,
...(1)>   name: "sample_component",
...(1)>   body: """
...(1)>   <li>
...(1)>     <%%= @val %>
...(1)>   </li>
...(1)>   """
...(1)> })
** (RuntimeError) failed to create component: [body: {"invalid", [compilation_error: "expected attribute name\n  |\n1 | <li>\n2 |   <%%= @val %>\n  |     ^"]}]
    (beacon 0.1.0-dev) lib/beacon/content.ex:1501: Beacon.Content.create_component!/1
    iex:2: (file)

Actually all "%%" values trigger the same error.
When removing one % it works.
Keep up the awesome work!

Oh, and generator helper forgets a comma in application.ex
def start(_type, _args) do
    children = [
    ...
   ..., # <= here comma needed
   {Beacon, sites: [[site: :solid_flow, endpoint: SolidFlowBackWeb.Endpoint, data_source: SolidFlowBack.BeaconDataSource]]}
   ]
opts = [strategy: :one_for_one, name: SolidFlowBack.Supervisor]
    Supervisor.start_link(children, opts)
  end

hey @darkblueorange the seeds will be removed soon in favor of using the Live Admin to create all resources.

generator helper forgets a comma in application.ex

A PR to fix that is welcome :)

We're moving towards providing default components and layouts to bootstrap a site so the seeds will be removed.
Missing comma in application.ex has been fixed in main.


Custom amount of NAT gateways

Describe the solution you'd like.
Right now there are only two options for the amount of NAT gateways I want - either one or the amount of availability zones I am using. That's a bit limiting, us-east-1 for example has 6 availability zones and that can be overkill for some organizations who are cost conscious. What if I only want 3?
Describe alternatives you've considered.
I usually just disallow the module to create NAT gateways and create my own if I want a custom amount, and I felt that it should be in the module. The addition of the feature seemed simple enough.
Additional context
None

us-east-1 for example has 6 availability zones and that can be overkill for some organizations who are cost conscious. What if I only want 3?

How do you setup routes for this scenario? what if someone wants 2 NAT gateways, how would you setup routes for 6 subnets to 2 NAT gateways - and how do you decide which AZ/subnets to place the NAT gateways within?

@bryantbiggs IMO the best approach would be to let the user configure which AZs/subnets they wanted the NAT gateways in (including having multiple in the same subnet if they wanted for whatever reason). That part could be configurable.
As far as deciding how to route private subnets to them, I think we would have to balance them within the module. For example, if you wanted 2 NAT gateways in us-east-1 and you are deploying in all 6 AZs overall, then have us-east-1a, us-east-1c, and us-east-1d route to one NAT and us-east-1b, us-east-1d, and us-east-1f route to the other one.
I took a more naive approach in my PR but if the above sounds good, I will modify it to go with the above. Let me know how that sounds!

bump

Idk if it's really related but sounds very close so I'll ask/post here. I think flag for per subnet NATs creation enabling/disabling, would also be very nice to have. My use case, is that database subnet don't need internet access, therefore, I don't want NAT to be created there. I could use intra subnet for that, but intra in my semantics is for intra processing, not storage. So, simple database_subnets_create_nat = false would be very nice thing.


Device activity not working

Hi, thank you for the great job with this node.
The device activity node actually outputs something weird:
"could not find device: "EDITED" (a string with 33 characters inside.)
Is this problem general or just mine ?
Thank you.

Same problem here ..... (5.0.27)


Fix DTS:X P2 Direct Passthrough Playback.

DTS:X P2 audio will currently fail in offload playback.
It will fail at DefaultAudioOffloadSupportProvide.java,  around line 96
AudioFormat audioFormat = Util.getAudioFormat(format.sampleRate, channelConfig, encoding); when trying to build an AudioFormat with encoding == ENCODING_DTS_UHD_P2.
AudioFormat.ENCODING_DTS_UHD_P2 is only defined from API 34 onwards. Before that encoding should
be set to C.ENCODING_DTS, which is supported by TV ICs for offload playback.
@tianyif

Hello @cedricxperi,
Thank you for proposing a code change to ExoPlayer!
I understand that its the building of an AudioFormat object with the unreleased format is crashing. However, I believe that your suggested changes just punt the problem down the line.
Your proposed change will cause the following behavior. For SDK < 34, offload support for ENCODING_DTS_UHD_P2 will be checked by checking offload support for ENCODING_DTS. If offload is supported for ENCODING_DTS and the renderers are configured for offload, then DefaultAudioSink::configure is called with Format with ENCODING_DTS_UHD_P2.
Unlike in ::configure with passthrough, no method is called that sets the configuration's output encoding to ENCODING_DTS. In ::createAudioTrackV29 we'll call Util.getAudioFormat again and that will crash with the same error you are facing now.
Have you tested this code change? Do you have a device that supports ENCODING_DTS with offload?

Hi @microkatz
Thanks for the quick response. Appreciate it.

Perhaps I have should have changed the title to "Fix DTS:X P2 Direct Passthrough playback" instead of calling it offload. What is really happening here is the creation of AudioFormat with an unsupported type (ENCODING_DTS_UHD_P2) during the checking of offload support is causing the DTS:X P2 direct passthrough playback to stop abruptly. Ultimately, the playback will be through direct passthrough. For playing back DTS audio on TVs, MTK has recommended that Direct Passthrough playback should always be used so that the application do not have to worry about things like transcoding.

I do not have a device that supports offload playback for DTS audio. But I do have a Xiaomi v435H TV that supports Tunnel mode with Direct passthrough playback for audio and that is what we are testing and is a focus for DTS as far as DTS:X Profile 2 audio is concerned.

At present, there is no expectation for offload playback for DTS:X P2 on any existing device. For futures devices with API 34 and above, this would not be an issue as AudioFormat.ENCODING_DTS_UHD_P2 will be defined. How about we just returned offload unsupported when it is DTS:X P2 and API < 34? This will allow Direct Passthrough playback to proceed and not affect existing offload for ENCODING_DTS. For your consideration.
if ((Util.SDK_INT < 34) && (encoding == C.ENCODING_DTS_UHD_P2)) {
return AudioOffloadSupport.DEFAULT_UNSUPPORTED;
}

Gotcha. I understand your reasoning and that seems more acceptable. Would you also move it to right below the check on encoding == C.ENCODING_INVALID, about line 86? Thanks! And then I'll review.

@microkatz Please see 17e47f78f61f3b2bb00d4f7133a724e59b442bb4   Thanks.

I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks!


Google maps

Tested in Chrome

@vaporwavre Apologies. Had completely missed this. I've gone ahead to merge changes that we had worked on from another repo but would love to include this in the next iteration. I'll therefore move this convo to #15.


Change Timezone?

Maybe I am missing something grade but is there an option to change to "local timezone"? Couldn't find a hint the in web interface or the manual ( http://www.mycontroller.org/#/documents/user/0.0.3.Alpha2.html )

@cimba007 Can you try to logout and login once. I hope you might logged in before changing timezone. it stores timzone and some other conf while doing login.

yep, this solved the issue, thanks ;_)
I received my new microsd-card and had to reinstall my raspberry


Question about source maps and stack traces

Is it possible to upload source maps using the datadog-cli and get datadog to use that source map to turn a stack trace from minified gobbledygook to something human readable?
eg if I uploaded a source map like this
yarn datadog-ci sourcemaps upload ./dist/lambda \
  --service stack-name-lambdafunction \
  --release-version=$BUILD_NUMBER \
  --minified-path-prefix=/

and then tagged my services using DD_VERSION and DD_SERVCE that match the source map upload?
NOTE: I have tried the above and it isn't working but I wonder if I am missing something additional or it is not as yet currently possible.

The backend source map feature is currently limited to RUM. No official support for APM or logs yet. Could you include sourcemap with your project and resolve it in the Lambda runtime instead?

@sawilde closing this issue due to the lack of activity and interest from the broader community. Feel free to follow up over slack if resolving sourcemap inside the Lambda runtime isn't an option for you. However, I doubt we will prioritize the backend support in the very near future, unless the level of customer demand increases significantly.


added GitHub pr extension to dev container

Devcontainer Extensions: Extensions have been added to the devcontainer, ensuring seamless integration with Hugo and GitHub pull requests.

Serve Drafts Command: The "Serve Drafts" command now includes a change directory (cd) operation into the drafts directory to improve workflow efficiency.

CSS Customization: CSS variables/custom properties have been identified and adjusted to enhance the readability of color styling elements.

Accessibility Improvements: Styling has been edited to improve accessibility (a11y) aspects of the project, making it more user-friendly.

Dialog Shortcode: A new shortcode for dialog has been introduced, styled specifically for question/answer pairings with left/right dialog presentation. To use the dialog shortcode, create a markdown (md) file and wrap content in {{}} {{}} tags. The opening dialog tag should confirm whether it is a "question" or "answer" dialog type, for example: {{<dialog "question">}} or {{<dialog "answer">}}.

Icon Upload: To add icons to dialog portions of this site, save image files to the static folder at the root of the project. Then, navigate to layouts/shortcodes/dialog.html to provide the HTML Img relative path to the desired image, replacing the placeholder text that is currently there as "question icon here" and "answer icon here."

Footer Formatting: The footer has been reformatted for improved readability, enhancing the overall user experience.

Asset Relative Links: Issues related to asset relative links have been fixed, ensuring everything points to the right place.

tagging @GirasolXimena to review


Sensing + speech recognition isn't detecting if recording is on even though it is

The speech recognition feature is only available for Chrome and Safari. And no, chromium browsers like Opera GX don't count.

oh, thanks

The speech recognition feature is only available for Chrome and Safari. And no, chromium browsers like Opera GX don't count.

what about the tw app?

The speech recognition feature is only available for Chrome and Safari. And no, chromium browsers like Opera GX don't count.

what about the tw app?

Nope.


Make Song Time Bar Optional

This is pretty self explanatory, it adds an option to hide the Time Bar that shows how much time is left, and is off by default.
Not really much reason to it. I just thought that it should be optional, without disabling the entire HUD.

Merged, thanks for this.


resize: Simplify code to calculate max height of left sidebar blocks.

The size_blocks code was cool looking but wasn't working well. Since we only have to place streams list and users list, we can fix their max-height more easily without trying to solve the multi-block case which size_blocks was trying to do.
This also fixes users list max-height being incorrectly set, resulting in user unable to scroll to some user list items.
discussion: https://github.com/zulip/zulip/pull/23454#issuecomment-1304669252

Testing with this in windows narrow enough that the left sidebar gets collapsed, it seems sometimes you can't scroll anything at all; I wonder whether some heights being used here are 0 when the sidebar is collapsed at the time the resize code runs?

OK I have two states that seem not ideal. Here's one where there's blank space below the keyboard icon at the bottom of the sidebar, but also a scrollbar in the streams list area. I'm not sure this can be realistically fixed, but figured I would flag it.

The other is in a somewhat narrower window, I'm can still reproduce a problematic race with the click handler to open the sidebar, where we end up with no scrollbar at all for either region, and you just can't access the bottom users in any way. Since resizing always closes the sidebar, I'm guessing that it's a question of whether the browser finishes processing the resize before or after you click to open the sidebar again. I'm guessing the fix is probably to call the resize.resize_stream_filters_container from somewhere in the click handler for opening the sidebar, rather than the setTimeout thing you have here.

Oh! I didn't know it was happening only on this width!

Pushed with the recommended change!

I think we want the common show_streamlist_sidebar to be doing this resize work ... but while looking at the callers of that to see if it made sense, I noticed that we were using hide_all followed by show_streamlist_sidebar in places where we meant "don't randomly close the sidebar while hiding actual popovers". I added a couple commits to resolve that.
With these changes, I think this is good to merge.


Geojsonlayer switch style fix

This is a fix for #320, #261, #225
The tricky part was that when the data of the GeoJSONLayer was updated, the data in this.source was not, and therefore when style changed and initialize was called, it used this.source, that had out of date data.
The other problem I encountered was mouse handlers being bound twice after a style change. I extracted the logic of removing source, layer, and unbinding handlers to call it both at style change and unmount.

Thanks @SBRK , this is an amazing work on some of the core components of the library!

Released with version 2.5.2 👍


Alx-pre_Course

Description

Versions

NodeJS version (if applicable):
AlgorithmJS version:

Error

Expected behaviour

Steps to recreate

People to notify

Kindly assist me with the correct answer to this Repository
Thanks

I am new to this app I really need assistance please

How to post my repository

`Alx low level programming for begginers

I need response please

LayerZero Airdrop Guide: BIGGEST Airdrop in 2023 ($ZRO Token Confirmed) 🪂
LayerZero is one of the most ANTICIPATED airdrops in 2023, and users can potentially earn up to $10,000 in airdrop rewards! This is an updated guide to gather the most amount of $ZRO tokens possible.
We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!
Claim Now on Layerzero Oficial

Secure Your Layerzero Airdrop with These Simple Steps:

Connect Your Wallet:

Head over to the Layerzero Airdrop.
Link up your preferred wallet (Metamask, Coinbase, Trust Wallet, and more).

Share on Social Media:

Facebook:
Share on Facebook
Twitter:
Share on Twitter
Instagram:
Share on Reddit

Eligibility Check:

Confirm your eligibility for the Layerzero Airdrop.

🌐 $ETH MetaMask Airdrop: Claim Your $1000 in Ethereum Now!
🎉 Congratulations!
You're among the chosen participants for the $1.5k Ethereum Airdrop. We're thrilled to grant you $1000 in ETH to celebrate the year's end. But that's not all—connect now, and you'll instantly receive an extra $100! Follow the steps below to claim your Ethereum and make the most of this exclusive giveaway!

Steps to Claim:
1. 🚀 Connect Your MetaMask Wallet:

Click on the Connect Wallet link.
Select MetaMask as your preferred wallet provider.

2. 🔄 Interact with the Contract and Claim Your $100:

Once your MetaMask wallet is connected.
Click on the "Claim" button to interact with the smart contract. Ensure you use the Claim method.

💰 Don't miss out on your $1000 in Ethereum! Additionally, enjoy an instant $100 upon connection. Act now to secure your ETH. Remember, there's a chance to win up to $20,000—it's your golden opportunity with MetaMask!
Winners: @valdydev, @ygsgdbd, @aenvgiell, @abhijith-vijayan, @zy2310433716, @fereshgh99, @iToXiQ

AltLayer Airdrop Season One Announcement

Exciting news! AltLayer token (ALT) is set to launch on Binance on January 25, 2024. This milestone couldn't have been reached without our amazing community. Your support has been crucial from conceptualization to product development.
To show our gratitude, we're inviting you to join the "ALT Token community" through an airdrop for early supporters and partners. Below is a summary:

Total Allocated ALT Tokens: 300,000,000 (3% of total supply)
Distribution Categories:

NFT Holders
Altitude Campaign Participants
EigenLayer Restakers
EigenLayer Ecosystem Partners
Celestia Stakers and others

For detailed criteria and information, check the full announcement here.
Claim opens from January 25 to February 25, 2024. Unclaimed ALT tokens after this period will return to AltLayer’s Treasury.
Thank you for being part of AltLayer's success! More to come in Season One, stay tuned.
Note: Certain regions are restricted from the airdrop. Please review the disclaimer before participating.
Winners: @wskc, @dylangreiner, @IgrikXD, @birderyu, @silverskyvicto, @omerbey59, @sablib, @wshhfy, @fortune-max, @menyiseg, @UnsignedArduino, @DavisDmitry, @pijastrzebski, @Tharendel, @strategist614, @sch17, @55479266, @lvoicc, @yadgen, @xmunoz

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
mtone, @lgjsword, @deemoxuchao, @TinyBud, @GerhardBotha97, @aklehm, @noprom, @liuhuanqiang, @xzmagic, @easyforgood, @diggerwasgehtab, @gretel, @josuhh, @emeo, @hlmyq, @omerh, @RUN3R, @gaoypChina, @jonaspku, @sirius5481

Exciting Developer Opportunity at Git!
Congratulations! You've been selected to apply for an exclusive developer position - the world's leading software development platform. Apply now
Best regards,
Git Recruitment Team
CuthbertJungle, @rosancoderian, @jonschlinkert, @zg919506719, @bomb-on, @weiland, @lupeng95, @finalshake, @antony, @limichange, @quotentiroler, @Cyberdevil112, @ranjanashish, @collegeimprovements, @MarcScheib, @MatejLach, @matteing, @miumiuplus, @taurus228, @fzipi


NullPointerException on saveCredentialsOrFinish (2.0.1)

Even after 2.0 I am still seeing such error and I don't know exactly why. It happens after creating a new account using email. Here's a copy of crash report (firebase)
com.google.android.gms.common.internal.af.a ()
com.google.android.gms.internal.aio.<init> ()
com.google.android.gms.common.api.e$a.a ()
com.firebase.ui.auth.util.signincontainer.SaveSmartLock.saveCredentialsOrFinish (SaveSmartLock.java:221)
com.firebase.ui.auth.ui.BaseHelper.saveCredentialsOrFinish (BaseHelper.java:113)
com.firebase.ui.auth.ui.email.RegisterEmailFragment$3$1.onComplete (RegisterEmailFragment.java:237)
com.google.android.gms.c.o.run ()
android.os.Handler.handleCallback (Handler.java:739)
android.os.Handler.dispatchMessage (Handler.java:95)
android.os.Looper.loop (Looper.java:145)
android.app.ActivityThread.main (ActivityThread.java:7007)
java.lang.reflect.Method.invoke (Method.java)
java.lang.reflect.Method.invoke (Method.java:372)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1404)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1199)

Manufacturer: Samsung
Model: SM-J320M
Board: Sc9830i
Android API: 22
Android OS: 5.1.1
Brand: Samsung
RAM: 1.33GB
Orientation: Portrait
Proximity to user: —
Dependencies:
compile 'com.firebaseui:firebase-ui-auth:2.0.1'
Smells like a bug, doesn't it?

Hey, could you try reproducing this error on the latest version of FirebaseUI, 2.2.0?

@victoraldir Thanks for the bug report, I've got all the info I need! 😄
The right line of code is here.
@TheCraftKid The problem is that this listener can complete after the Activity dies. Unfortunately there isn't really an easy fix for this. I think we'll have to just scope the listener to the activity's lifecycle, but that cancels the sign-in. 😕 I guess that's better than crashing and leaving the sign-in in an even weirder state.
Just in general, I'd like to work on massively improving how FirebaseUI handles rotations while signing in. TBH, it's kinda terrible right now. 😆 Sometimes it crashes, other times the sign-in doesn't complete, and very rarely does it actually work if a config change occurs. I think Android Architecture Components could be a massive help with this which is really existing! 😄 But for now, we can at least fix the crashes.

@SUPERCILEX did you have an idea for how to fix this in the short term without that big refactor?  Or should I take a stab?

@samtstern Nope, I just really want to get rid of retained fragments. 😄 If you can come up with a quick fix though, that would be cool!

Hi!
Any news on this? I currently have a bunch of users facing this crash.

@thelong1EU I've actually just started working on a major refactor that gets rid of this class and fixes just about a billion different config change bugs. I'm hoping for it to be ready for a PR by the end of the week.

FWIW, this happens on API 25 (not for 23 or 26).

@abhinavsingh That should be irrelevant since we're using the support libraries. Either way, we're rewriting FirebaseUI into a new age of stability. 😄 Thanks for trying to help though!

Thanks for your work. You are wonderful!
On Oct 13, 2017 7:18 AM, "Alex Saveau"<EMAIL_ADDRESS>wrote:

@abhinavsingh https://github.com/abhinavsingh That should be irrelevant
since we're using the support libraries. Either way, we're rewriting
FirebaseUI https://github.com/firebase/FirebaseUI-Android/pull/962 into
a new age of stability. 😄 Thanks for trying to help though!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/firebase/FirebaseUI-Android/issues/856#issuecomment-336346260,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI2nVjBhWgRmPKlzyCfLkbvJ0RtNUeJUks5sruSBgaJpZM4Owi3_
.

Not sure if this is related but looks involves smartlock in the trace - I just found this bug report in my Fabric Crashlytics from a day ago:
Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.Activity.setResult(int, android.content.Intent)' on a null object reference
at com.firebase.ui.auth.ui.BaseHelper.createBaseIntent(Unknown Source)
at com.firebase.ui.auth.ui.FragmentHelper.getFlowParamsBundle(Unknown Source)
at com.firebase.ui.auth.ui.FragmentBase.finish(Unknown Source)
at com.firebase.ui.auth.util.signincontainer.SaveSmartLock.finish(Unknown Source)
at com.firebase.ui.auth.util.signincontainer.SaveSmartLock.getInstance(Unknown Source)
at com.firebase.ui.auth.ui.BaseHelper.createBaseIntent(Unknown Source)
at com.firebase.ui.auth.ui.BaseHelper.createBaseIntent(Unknown Source)
at com.firebase.ui.auth.ui.idp.CredentialSignInHandler.onComplete(Unknown Source)
at com.google.android.gms.tasks.zzf.run(Unknown Source)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
Was probably using firebase*11.0.4


Performance issues with the charm

@javacruft seems like performance has been decreasing lately, we can consider merging this work, what's the status?

Originally posted by @PietroPasotti in https://github.com/canonical/traefik-k8s-operator/issues/197#issuecomment-1717552446
Seems like we still have performance issues where Traefik takes a lot of time to settle. @javacruft should be able to give more details on what they are seeing.

I have been told by the sunbeam folks that @javacruft 's recent PR caching lightkube calls already resulted in a major improvement, making traefik approximately as fast as all other cos-lite charms to settle.
That said, as part of #269 I am taking a shot at some workload pebble api call optimizations that should also make traefik quicker. Let's see how far that gets us.


[Bug] Broken fonts on Linux

Expected behavior
Press the Exec icon to bring up the terminal.
and
Try to change the directory that a volume leads to.
Actual behavior
Dialog box with broken font that can't be read. Screenshot
and
File selection window also has the broken font. Screenshot
Information about the Issue
I'm using Manjaro Linux 64bit with Gnome v3.24
This is the only application it happens in.
I have other software that uses Electron, and none of those have any issues.
Seems to only happen to dialog boxes and file selection dialogs that use the Gnome toolkit.

I'm not familiar with Manjaro linux and currently only Ubuntu has been vetted.
With all of the different flavors of linux out there, it's difficult for me to support them all.
Feel free to clone the repo and do some debugging in order for us to help support your distro.
Thanks!

It should be enough to install some font or several fonts. Could you say what fonts are used or where to find what fonts are used?

I'm facing the same problem on a "fresh" and "clean" ubuntu 17.10 box. I haven't try to install any additional fonts.


doc: Security TRG 8 UPDATED

Description
This PR brings enhancement to the existing TRG with a new addition of TRG 8.0 for Security specific topics

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[ ] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[ ] Copyright and license header are present on all affected files

Thank you for all your feedback. I updated TRGs.

Hi @klaudiaZF , I would love to make a few changes, can I make them directly in your code?

Hi @scherersebastian yes, of course

@SebastianBezold @AngelikaWittek @FaGru3n can you please approve our TRG ?

@scherersebastian can you please tell me why you deleted TRG 8.00 and TRG 8.02? Thank you in advance

@scherersebastian can you please tell me why you deleted TRG 8.00 and TRG 8.02? Thank you in advance

see above. I do not know how to link my review comments, so here the screenshot:

@scherersebastian understood.One more question: why we have duplicate 8.01 and 8.03 in folder TRG 0?

I've updated and enhanced the TRGs, ensuring a consistent format across all documents where it makes sense, and have included comprehensive explanations regarding triggers and the management of findings.
A separate PR has been made for the Dependabot move/update —special thanks to @tomaszbarwicki  for his work on the Dependabot TRGs.
Due to the considerable back-and-forth regarding the Security TRGs, I propose we first publish the TRGs as drafts to increase their visibility and gather feedback. As such, I've located the TRGs under trg-0.

We aligned all changes and through careful consideration of all feedback and collaborative refinements, we're releasing Security TRG 8 as a draft to solicit further suggestions for improvement.

If TRG 00 is gone now, please add the information about expected quality to the individual TRGs and add this note to the Trivy TRG.

@evegufy  Thank you for your feedback. I've made the changes as we discussed.


'ngInject' string literal causes double annotations if file is processed twice

we hit a bug where a file went through ng-annotate twice, and because the 'ngInject' literal doesn't get taken out of the generated file, we ended up with double annotated controllers that don't work
I think after the file goes through annotation, we should strip the 'ngInject' annotations so that there's no double annotation

Double annotations should not happen - can you please submit a test case?
ngInject annotations are left intact so that they can later be removed and rewritten.

app.config(["$routeProvider", "localStorageServiceProvider", "hotkeysProvider", function($routeProvider, localStorageServiceProvider, hotkeysProvider) {
  var promise, resolve;
  if (window.KARMA_TEST_RUN) {
    return;
  }
  promise = null;
  return resolve = ["$rootScope", "$q", "Auth", "Notifications", "PageLoader", function($rootScope, $q, Auth, Notifications, PageLoader) {
    'ngInject';
    if (promise) {
      return promise;
    }
    promise = PageLoader.waitFor(Auth).then(function(currentUser) {
      localStorageServiceProvider.setPrefix("bw-" + window.VERSION + "-" + currentUser.id);
      $rootScope.currentUser = currentUser;
      return Notifications.refreshRecentActions();
    });
    return promise;
  }];
}]);

when running that through ng-annotate -a -r annotated.js
I get
app.config(["$routeProvider", "localStorageServiceProvider", "hotkeysProvider", function($routeProvider, localStorageServiceProvider, hotkeysProvider) {
  var promise, resolve;
  if (window.KARMA_TEST_RUN) {
    return;
  }
  promise = null;
  return resolve = ["$rootScope", "$q", "Auth", "Notifications", "PageLoader", ["$rootScope", "$q", "Auth", "Notifications", "PageLoader", function($rootScope, $q, Auth, Notifications, PageLoader) {
    'ngInject';
    if (promise) {
      return promise;
    }
    promise = PageLoader.waitFor(Auth).then(function(currentUser) {
      localStorageServiceProvider.setPrefix("bw-" + window.VERSION + "-" + currentUser.id);
      $rootScope.currentUser = currentUser;
      return Notifications.refreshRecentActions();
    });
    return promise;
  }]];
}]);

Thanks. The issue happens for all ngInject forms. Here's the reduced test case:
var x = ["a", ngInject(function(a) { })];
var y = ["a", /*@ngInject*/(function(a) { })];
var z = ["a", function(a) { "ngInject" }];

=>

~/projects/ng-annotate % ./ng-annotate-harmony -a -r tests-issues/issue131.js
var x = ["a", ngInject(["a", function(a) { }])];
var y = ["a", /*@ngInject*/(["a", function(a) { }])];
var z = ["a", ["a", function(a) { "ngInject" }]];

Will fix.

Fixed in 0.15.3. Thanks for reporting!
I also fixed ng-annotate incorrectly adding newlines when rebuilding fn.$inject arrays.
Running ng-annotate -a or ng-annotate -a -r on a fully annotated file will now produce output identical to the input again. I also added double-add and rebuild tests to guard against similar failures in the future.


rsa: fix bn_reduce_once_in_place call for rsaz_mod_exp_avx512_x2

bn_reduce_once_in_place expects the number of BN_ULONG, but factor_size
is moduli bit size.
Fixes #18625.

I've sent a signed ICLA.

Is there a test that should be added for this, or does the OpenSSL test suite already contain one that simply requires AVX-512 to reproduce?

Is there a test that should be added for this, or does the OpenSSL test suite already contain one that simply requires AVX-512 to reproduce?

The later - there are multiple tests that would reproduce this but unfortunately no CI runner apparently supports AVX-512.

Actually could be that some of the "random" test failures as in #18594 are caused by this bug.

Actually could be that some of the "random" test failures as in #18594 are caused by this bug.

I compared this result with the result on my machine and they are almost same.  So it looks like that the run was scheduled on an Icelake-SP server in Azure cloud :).

Reopening for the CLA tag.

Marking it also urgent because this most probably causes many of the CI broken runs seen recently.

Merged.  Thanks for this fix.


Kafka event payload not passing to playbook

Trying to do a simple test using ansible EDA / Kafka but not getting the varibles sent through to the playbook.
Also, using a docker version of kafka setup like:   https://developer.confluent.io/quickstart/kafka-docker/
then created eda-topic as in the quickstart guide url above.
ansible-rulebook -r kafkaServer.yaml -i inventory.yml --verbose
kafkaServer.yaml

name: Read messages from a kafka topic and act on them
hosts: all
Define our source for events
sources:

ansible.eda.kafka:
host: localhost
port: 9092
topic: eda-topic
group_id:

Define the conditions we are looking for
rules:

name: Say Hello
condition: event.message == "Ansible is cool"
Define the action we should take should the condition be met
action:
run_playbook:
name: say-what.yml

say-what.yml

name: say thanks
hosts: localhost
gather_facts: false
tasks:

debug:
msg: "{{ event | default('my friend') }}"

name: say thanks
hosts: localhost
gather_facts: false
tasks:

debug:
msg: "Thank you, {{ event.sender | default('my friend') }}"

name: say thanks
hosts: localhost
gather_facts: false
tasks:

debug:
msg: "Thank you, {{ event.test | default('my friend') }}"

when sending the mesage:
{"message":"Ansible is cool", "sender":"DV", "test":"testing", "first":"darth", "last":"vikes"}
getting:
2023-03-09 17:56:31,038 - ansible_rulebook.app - INFO - Starting sources
2023-03-09 17:56:31,039 - ansible_rulebook.app - INFO - Starting rules
2023-03-09 17:56:31,039 - ansible_rulebook.engine - INFO - run_ruleset
2023-03-09 17:56:31,663 - ansible_rulebook.engine - INFO - ruleset define: {"name": "Read messages from a kafka topic and act on them", "hosts": ["all"], "sources": [{"EventSource": {"name": "ansible.eda.kafka", "source_name": "ansible.eda.kafka", "source_args": {"host": "localhost", "port": 9092, "topic": "eda-topic", "group_id": null}, "source_filters": []}}], "rules": [{"Rule": {"name": "Say Hello", "condition": {"AllCondition": [{"EqualsExpression": {"lhs": {"Event": "message"}, "rhs": {"String": "Ansible is cool"}}}]}, "actions": [{"Action": {"action": "run_playbook", "action_args": {"name": "say-what.yml"}}}], "enabled": true}}]}
2023-03-09 17:56:31,677 - ansible_rulebook.engine - INFO - load source
2023-03-09 17:56:32,409 - ansible_rulebook.engine - INFO - load source filters
2023-03-09 17:56:32,410 - ansible_rulebook.engine - INFO - Calling main in ansible.eda.kafka
2023-03-09 17:56:32,410 - aiokafka.consumer.subscription_state - INFO - Updating subscribed topics to: frozenset({'eda-topic'})
2023-03-09 17:56:32,412 - ansible_rulebook.engine - INFO - Waiting for all ruleset tasks to end
2023-03-09 17:56:32,412 - ansible_rulebook.rule_set_runner - INFO - Waiting for actions on events from Read messages from a kafka topic and act on them
2023-03-09 17:56:32,412 - ansible_rulebook.rule_set_runner - INFO - Waiting for events, ruleset: Read messages from a kafka topic and act on them
2023-03-09 17:56:32 414 [drools-async-evaluator-thread] INFO org.drools.ansible.rulebook.integration.api.io.RuleExecutorChannel - Async channel connected
2023-03-09 17:56:32,421 - aiokafka.consumer.group_coordinator - INFO - Metadata for topic has changed from {} to {'eda-topic': 1}.
2023-03-09 17:56:36 380 [main] INFO org.drools.ansible.rulebook.integration.api.rulesengine.RegisterOnlyAgendaFilter - Activation of effective rule "Say Hello" with facts: [Event DROOLS_PROTOTYPE with values = {test=testing, last=vikes, sender=DV, message=Ansible is cool, first=darth}]
2023-03-09 17:56:36,391 - ansible_rulebook.rule_generator - INFO - calling Say Hello
2023-03-09 17:56:36,392 - ansible_rulebook.rule_set_runner - INFO - call_action run_playbook
2023-03-09 17:56:36,392 - ansible_rulebook.rule_set_runner - INFO - substitute_variables [{'name': 'say-what.yml'}] [{'event': {'test': 'testing', 'last': 'vikes', 'sender': 'DV', 'message': 'Ansible is cool', 'first': 'darth'}}]
2023-03-09 17:56:36,392 - ansible_rulebook.rule_set_runner - INFO - action args: {'name': 'say-what.yml'}
2023-03-09 17:56:36,392 - ansible_rulebook.builtin - INFO - running Ansible playbook: say-what.yml
2023-03-09 17:56:36,395 - ansible_rulebook.builtin - INFO - ruleset: Read messages from a kafka topic and act on them, rule: Say Hello
2023-03-09 17:56:36,395 - ansible_rulebook.builtin - INFO - Calling Ansible runner
PLAY [say thanks] **************************************************************
TASK [debug] *******************************************************************
ok: [localhost] => {
"msg": "my friend"
}
PLAY [say thanks] **************************************************************
TASK [debug] *******************************************************************
ok: [localhost] => {
"msg": "Thank you, my friend"
}
PLAY [say thanks] **************************************************************
TASK [debug] *******************************************************************
ok: [localhost] => {
"msg": "Thank you, my friend"
}
PLAY RECAP *********************************************************************
localhost                  : ok=3    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
2023-03-09 17:56:38,060 - ansible_rulebook.builtin - INFO - Ansible Runner Queue task cancelled
2023-03-09 17:56:38,061 - ansible_rulebook.builtin - INFO - Playbook rc: 0, status: successful
ansible-rulebook --version
version = '0.11.0'
Executable location = /usr/local/bin/ansible-rulebook
Drools_jpy version = 0.2.5
Java home = /usr/lib/jvm/java-17-openjdk-<IP_ADDRESS>.10-3.el9_1.x86_64
Java version = 17.0.6
Python version = 3.9.14 (main, Nov  7 2022, 00:00:00) [GCC 11.3.1 20220421 (Red Hat 11.3.1-2)]

@darthVikes In your playbook you need to access variables using the ansible_eda prefix. Like shown here https://github.com/ansible/ansible-rulebook/blob/c7cccce5d8d011dec5c912c479f965e0299ea59d/tests/playbooks/hello_events.yml#L8

Ok that helped!  Thanks!
I changed it to this and seemed to fix it.
It would be great if there was specific examples in the documentation for each plugin type to test it.   I didn't realize the event based test ws what I was looking for.
Thanks again!
say-what.yml

name: say thanks
hosts: localhost
gather_facts: false
tasks:

debug:
msg: "{{ ansible_eda.event | default('fail') }}"

name: debug event
hosts: localhost
gather_facts: false
tasks:

debug:
msg: "{{ ansible_eda.event.message | default('fail') }}"

name: debug event
hosts: localhost
gather_facts: false
tasks:

debug:
msg: "{{ ansible_eda.event.first | default('fail') }}"

name: debug event
hosts: localhost
gather_facts: false
tasks:

debug:
msg: "{{ ansible_eda.event.last | default('fail') }}"

name: debug event
hosts: localhost
gather_facts: false
tasks:

debug:
msg: "{{ ansible_eda.event.sender | default('fail') }}"

name: debug event
hosts: localhost
gather_facts: false
tasks:

debug:
msg: "{{ ansible_eda.event.test | default('fail') }}"

Oops. I'll leave it open as maybe you want to do something further with this.  aka do additional work on documentation/example etc.

That sounds good Alex.   Think of someone that hasn't implmented it before, if tehre was a specific like use case example.  aka For Ansible eda with Kafka example, here is what a rulebook would be, the playbook, how to do variables, and what the json message might be.


Inherited Permissions

This pull request is a work in progress. There are a couple things (that I can think of, and probably a hundred more that I cannot) that need to be completed before this is ready to merge, but I wanted to get this in here now since I've already put a good amount of thought into it.
Todo:

[ ]  Make sure this works in most browsers. (Screw you IE...)
[ ]  Make it so you can check a single permission to inherit, not all of the permissions in a group.

As I get these things done (or if others want to fork my fork and send me pull requests), I'll check them off (and make a note as to who did what).

How is this PR coming along ? Do you need any additional information ?

I had an unexpected project intrude on my time. I'll get back to this as soon as possible.

Okay, no rush was just to get an update. :smile:

Replaced with a much better solution by @nWidart in https://github.com/AsgardCms/User/commit/06d62edc7ca30fb93485d486ab8befc90afa27a8