problems importing images in .emf format

Hi!
¡Muchas gracias por tu extensión! :)
I faced with a problem importing .docx documents containing images in .emf format
Pandoс successfully pulls these pictures out of the document and saves them to the wiki database.
But mediawiki does not support the format and link like this appear in my article:
File:Pandocultimateconverter-8cb75f65-0a0c-43d6-a101-ab514afcc0d0-image3.emf
Is it possible to force Pandoс to change the format of such files to .png
and/or prohibit writing unsupported files to the wiki?
I'm attaching the logs
misc.log
[main.log](https://github.com/user-attach
test emf page.docx
ments/files/15886030/main.log)

Probably we can't do much with conversion (it will require one more tool)
I lean towards adding a config with an array of extensions to skip from upload.

I've supported config
$wgPandocUltimateConverter_MediaFileExtensionsToSkip = [ 'emf' ];
By default it contains EMF
For now, I did not cleanup in postprocessing (it might be helpful to at least know some files are not processed).

Later on, we may add an additional param (false by default) to cleanup such redlinks.

Hello, unfortunately the new fix only works on a test file.
When i'm trying to download a larger file, multiple errors occur in the browser:
Warning: strtolower() expects parameter 1 to be string, array given in /var/www/html/last_of_us/extensions/PandocUltimateConverter/includes/PandocWrapper.php on line 82
Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/last_of_us/extensions/PandocUltimateConverter/includes/PandocWrapper.php:82) in /var/www/html/last_of_us/extensions/PandocUltimateConverter/includes/SpecialPandocUltimateConverter.php on line 83
Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/last_of_us/extensions/PandocUltimateConverter/includes/PandocWrapper.php:82) in /var/www/html/last_of_us/includes/WebResponse.php on line 75
I am also attaching the logs.
misc.log
main.log

[error] [ee067b6119a7a20f2af24dfb] /last_of_us/index.php/%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:PandocUltimateConverter   PHP Warning: strtolower() expects parameter 1 to be string, array given
#0 [internal function]: MWExceptionHandler::handleError()
#1 [internal function]: strtolower()
#2 /var/www/html/last_of_us/extensions/PandocUltimateConverter/includes/PandocWrapper.php(82): array_map()

The code is:
$mediaFilesExtensionsToSkip = $config->get( 'PandocUltimateConverter_MediaFileExtensionsToSkip' ) ?? [];
<..>
in_array(strtolower($extension), array_map('strtolower', $mediaFilesExtensionsToSkip))

How is your PandocUltimateConverter_MediaFileExtensionsToSkip variable specified?
It should be array of strings. Might it be that you've added array as an element of this array? For example, smth like
$PandocUltimateConverter_MediaFileExtensionsToSkip[] = ['my_extension']
?

Hello!
The problem occurs regardless of the key $wgPandocUltimateConverter_MediaFileExtensionsToSkip
when log collection is enabled
Here is my config file:
#PandocUltimateConverter
wfLoadExtension( 'PandocUltimateConverter' );
$wgPandocExecutablePath = '/bin/pandoc';
$wgPandocTmpFolderPath = '/tmp/pandoc';
$wgFileExtensions[] = 'docx';
$wgFileExtensions[] = 'odt';
#$wgPandocUltimateConverter_MediaFileExtensionsToSkip = [ 'emf' ];
error_reporting( -1 );
$wgDebugLogFile = "/var/log/mediawiki/$wgDBname/main.log";
$wgDebugLogPrefix = date( '[Y-m-d H:i:s] ' );
$wgShowExceptionDetails = true;
$wgShowDBErrorBacktrace = true;
error_reporting( E_ALL ); ini_set( 'display_errors', 1 );
$wgDebugLogGroups['DBQuery'] =
$wgDebugLogGroups['DBReplication'] =
$wgDebugLogGroups['DBConnection'] =
$wgDebugLogGroups['runJobs'] =
$wgDebugLogGroups['Parsoid'] =
$wgDebugLogGroups['rdbms'] = "/var/log/mediawiki/$wgDBname/misc.log";

Interesting!
So far I was not able to reproduce it. Is it possible to create a sample docx file to confirm the issue?

Interesting! So far I was not able to reproduce it. Is it possible to create a sample docx file to confirm the issue?

Hello! I sent the document via private message

Thanks!
 Should work now :)

Found out the reason, it was related to the fact that I'm using "configs" from manifest v2, but manifest version is v1 in extension.json
Made a proper fix.
Manifest v2 works for MW 1.29+. so that's not a big deal.

it looks like that works correctly
Thanks!

Found out the reason, it was related to the fact that I'm using "configs" from manifest v2, but manifest version is v1 in extension.json
Made a proper fix.
Manifest v2 works for MW 1.29+. so that's not a big deal.


Blue sky: data constants, calculations for filters

This is a total blue sky request -- curious to see whether it's feasible/elegant to do or a total dead end. Currently our web projects use complex code to generate styles specific to the datasource, e.g. a choropleth map might need styles rendered like:
#layer[FIELD <= 10000] { ... }
#layer[FIELD > 10001] { ... }

Where 10000 is some value specific to the datasource.
I'm wondering if carto could represent certain values as pseudo-constants/calculations, e.g. MAX(FIELD), MIN(FIELD) and furthermore evaluate calculations in filters like this:
/* Choropleth of 5 colors */
#layer[FIELD >= MIN(FIELD)][FIELD < MAX(FIELD) * .2] { ... }
#layer[FIELD >= MAX(FIELD) * .2][FIELD < MAX(FIELD) * .4] { ... }
#layer[FIELD >= MAX(FIELD) * .4][FIELD < MAX(FIELD) * .6] { ... }
#layer[FIELD >= MAX(FIELD) * .6][FIELD < MAX(FIELD) * .8] { ... }
#layer[FIELD >= MAX(FIELD) * .8][FIELD < MAX(FIELD)] { ... }

So that the styles can be reused/applied easily to any datasource. The idea here is to make visualizations much simpler to express and not require hardcoded values/external calculations.
Just close if this is totally crazy.

I think this is unlikely to happen, but will re-open if it is supported on the Mapnik side.


sc-4865 fix: National Identification Validation User UI

Codecov Report

Merging #487 (7f6e4ed) into main (b5b4f98) will decrease coverage by 9.48%.
The diff coverage is n/a.

:exclamation: Current head 7f6e4ed differs from pull request most recent head ef44120. Consider uploading reports for the commit ef44120 to get more accurate results

@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   46.94%   37.46%   -9.49%
==========================================
  Files         233      151      -82
  Lines       11673     2389    -9284
  Branches      608      608
==========================================
- Hits         5480      895    -4585
+ Misses       5234     1319    -3915
+ Partials      959      175     -784

Impacted Files
Coverage Δ

.../github.com/trisacrypto/directory/pkg/gds/certs.go

...om/trisacrypto/directory/pkg/trtl/config/config.go

...isacrypto/directory/pkg/gds/store/trtl/iterator.go

...om/trisacrypto/directory/pkg/trtl/jitter/jitter.go

...sacrypto/directory/pkg/gds/store/index/sequence.go

...github.com/trisacrypto/directory/pkg/utils/gzip.go

...m/trisacrypto/directory/pkg/gds/store/trtl/trtl.go

...com/trisacrypto/directory/pkg/bff/api/v1/client.go

.../trisacrypto/directory/pkg/utils/logger/testing.go

.../github.com/trisacrypto/directory/pkg/trtl/mock.go

... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b4f98...ef44120. Read the comment docs.


Original code

Is there any backup of the code that was uploaded first? I would like to have the original ChaosBot on my private git server

You can view commits and find the commit you want then downloaded/clone that if you want an older version.

Looks like PR #∅ was 79a6b3fb943e3cfe6a510e7ce541a1aada531b01. That's the very first commit if that's what you want.


Acquia acli auth:login command fails on Mac M1

Describe the bug
When developing on a Mac with a M1 processor and the ARM build of ddev, a segmentation fault occurs when running ddev pull acquia (using a correctly configured providers yaml file) or ddev exec acli auth:login. I've confirmed that the exact commands with exact ddev config on a Mac with an Intel processor work fine.
To Reproduce
ddev exec acli auth:login on a Drupal9 install with Acquia credentials on a Mac M1.
Expected behavior
I'm betting the compiled acli phar has some AMD architecture dependencies hidden within. This will impact users of the Acquia recipe only on Mac M1 environments. I will cross-post the bug report to Acquia, but I have a feeling many ddev users will start here.
Screenshots

Version and configuration information (please complete the following information):

Host computer OS and Version: macOS Big Sur (M1)
Docker Desktop version if on macOS or Windows (from "About Docker Desktop"): <IP_ADDRESS>
ddev version information (use ddev version): 1.17.7
config.yaml contents for the misbehaving project (the part before the comments)

name: redacted
type: drupal9
docroot: docroot
php_version: "7.4"
webserver_type: nginx-fpm
router_http_port: "80"
router_https_port: "443"
xdebug_enabled: false
additional_hostnames: []
additional_fqdns: []
mariadb_version: "10.3"
mysql_version: ""
use_dns_when_possible: true
composer_version: ""
web_environment: []

Do you have any custom configuration (nginx, php, mysql) in the .ddev folder? If so, have you tried without them? None

Hi @joshuami - thanks for the detailed report.
This will be fixed with

#3102

As mentioned there, temporarily add webimage: drud/ddev-webserver:20210714_bullseye_web_image to your .ddev/config.yaml
Please don't forget to remove that when this comes out in a real release.
I expect this to be in an alpha release in the edge channel in a week or two.

Note that this has the same effect on the Platform.sh's "platform" tool, which probably dies for the same reason (curl to a particularly sensitive host).


Add CLI

pcf -h
Usage: pcf [--version] [--help] <command> [<args>...]

  Particle Cloud Framework

Options:
  -v, --version  Show PCF version.
  -h, --help     Show this message and exit.

Commands:
  apply      Set a desired state and apply changes
  run        Set desired state to 'run' and apply changes
  stop       Set desired state to 'stopped' and apply changes
  terminate  Set desired state to 'terminated' and apply changes

Changes
Adds a Click-based CLI, pcf, with four commands (apply, run, stop, and terminate) for applying state changes to Particles and Quasiparticles

CLI has autosuggestion for close typos
Respects a user's NO_COLOR env var if set. See https://no-color.org

Adds a test Make task that will execute pytest and generate code coverage reports with uncovered line numbers.

Adds a .coveragerc file to ignore the pcf/test directory in coverage reports

Overview
The CLI will by default look for the following config files in order of their precedence:

pcf.json
pcf.yml
pcf.yaml

Users can provide their own custom-named files with the -f or --file option.
These PCF config files can contain a single dict for a single particle definition or a list of particle definition dictionaries.
Example pcf.yml file:
---
pcf_name: my_ec2
flavor: ec2_instance
aws_resource:
  custom_config:
    instance_name: my-ec2
    ...

The Particle/Quasiparticle lookup method searches for the corresponding class object that has the flavor given by the user set as a class variable since they are unique.
Commands
pcf apply is a general command that takes a --state or -s option (running as default), sets desired state, and runs apply() on the particle/quasiparticle class

Example: pcf apply -s terminated my_ec2

pcf run <pcf_name> is a convenience command equivalent to pcf apply --state running <pcf_name>
pcf stop <pcf_name> is a convenience command equivalent to pcf apply --state stopped <pcf_name>
pcf terminate <pcf_name> is a convenience command equivalent to pcf apply --state terminate <pcf_name>
All four applying commands take a -c or --cascade flag to determine if state changes should cascade through family members as well as a -q or --quiet flag to prevent CLI output except when errors occur.
Tests

Adds conftest.py with reusable pytest fixtures for a CLIRunner and a convenient method to copy test config files into a temp directory.
Adds tests for commands and all utility functions

To test the CLI, check out this branch, run pip install -e . and run pcf --version to get started.

@anovis I added a progress bar to when apply runs on multiple particles.

is there a better way to install the cli for a user than running pip install -e .

can you add a readme page or add a section to the docs? even just the screenshot you have in the pr works!

awesome thanks Jacob! Will review and try this out today

Anything like a README or how to get started guide for users would be helpful. Almost just like the first comment you have at the top :)

@jacoblearned theres a merge conflict with pcf/particle/gcp/compute/compute.py because we renamed but I think we are good to merge once we have that fixed.

@davidyum Resolved the conflict. Thanks for reminding me 👍


Update hibernate-orm hints to cover AttributeBinder & ValueGenerationTypes

What does this PR do?
This PR adds hints for types created reflectively via org.hibernate.cfg.annotations.PropertyBinder based on types provided via (meta) annotation attributes via commit 0.
Additionally commit 1 updates the reflection config to reduce build time warnings due to invalid configuration which will close #107 .
Checklist before merging

[x] I have properly formatted metadata files (see CONTRIBUTING document)
[x] I have added thorough tests. (see this)

Does this PR remove all the Hibernate warnings or just some of them?


[DNMY] update pins on four dependencies and bump build number to 1 attempt build with Python 3.12

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
~[ ] Reset the build number to 0 (if the version changed)~
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

DO NOT MERGE YET (since deps have not been updated upstream)
As discussed with Prospector developers in https://github.com/landscapeio/prospector/issues/644 I am attempting an updated env and rebuild with Python 3.12 :beer:
New pins in current meta - I had to temporarily turn off pip check since the deps have not been updated upstream; will return on once the deps are good at that end - but it is very likely that I'll close this PR and will open a new one for a new version (rather than build), so please don't merge this :beer:

@conda-forge-admin, please rerender

superseded by #49


Vertical loading

How can i make it load more rows but not columns?

It is not supported at present！


Closes #152 Use default rolls for Attack and Damage

Closes #152 Use default rolls for Attack and Damage

Changes both the attack and damage rolls of weapons to use the 5e system built in rolls
Allows use of the modifiers, and selection of advantage, disadvantage and critical damage choices
Supports use of fast-forward hotkeys built into the 5e system (Shift = normal roll, Alt = advantage / critical, Ctrl = disadvantage)
Uses .mousedown as opposed to .click with event.preventDefault() to avoid highlighting text when shift + clicking text

Notes:

Uses the current damageRoll.hbs part, although, I believe with the shorter syntax required, this part could be removed, and the span could be added to attack.hbs. It's almost more complicated to pass parameters to such a small part, than to just add it to the parent part.

https://user-images.githubusercontent.com/7407481/155200650-7e737f1c-ba75-4e36-973b-8340939084da.mp4

I also have a version of this implementation locally where I include the <i class="fas fa-dice-d20"/> icon. I could incorporate that into this PR if wanted. However, I didn't want to change the style of the sheet necessarily.

Digs in heels. Kicks and screams... fine. Yeah, it's better this way isn't it 😔
But definitely no icons, got to maintain the accurate look.
I'll hopefully have time after work today to fully review all these PRs and test everything. My goal is to have a release this weekend at the latest.

eeek, I just noticed a nasty little space in that text I need to resolve.

 Every time I touch a template, there is a new edge case space.


[BUG] Some users are having issues opening moonpay:

This bug reported by Jeff

@Peppermint1020 test

Tested on ios prod version 2.2.10(10).
Succeed in my device.
https://github.com/user-attachments/assets/1ac09e9c-7c91-411f-842b-ec7382a00871
@JeffreyDoyle Jeff, could you confirm if you're still experiencing this issue with your current version?

This bug already fixed i current version 2.2.11(7)


”Iana” is listed in the drop-down menu

Description:
"Iana" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Iana" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Iana, VASLUI".


Streamlining action selection and route values

Removes a few concepts we don't need
Improves documentation
More things are IDictionary instead of other random types

/cc @pranavkm

:shipit: once comments are addressed.


rewrite: Absolute basics

This PR is intended to be merged into a new branch called rewrite, not into master.
This PR intends to lay a groundwork for the rewrite.
Here are my changes

Added an analysis crate, so that in the future code other than ash's generator can work with the API registry.
Other small miscellaneous changes.

Responding to early feedback about this PR, I've changed it to keep the old generator in the code base as a reference point and I've changed the base branch to master so that we have a working version of the current generator to build off of. Now we even might not even need to have a rewrite branch.

@Friz64
Very cool!

Okay! Now it probably makes more sense to directly work from master, so: Reverted the README.md change.

Looks like CI broke because raw-window-handle 0.5.1 got released with https://github.com/rust-windowing/raw-window-handle/pull/107 which bumps its MSRV to 1.64.

Ugh, I'm also running into that MSRV break on the ndk crate. Don't feel like bumping the MSRV for a patch dependency update (that we "could" opt out of) but raw-window-handle 0.5.1 provides some new features and drops cty in favour of the stabilized ffi types.

@Friz64 I'm tackling the MSRV bump in https://github.com/ash-rs/ash/pull/716 for just ash-window. In fact I think we might bump ash back down to 1.59 as I only bumped it to 1.60 for winit 0.28 initially which isn't used in ash's crate graph anyway (and 1.59 is still enough for #715 :partying_face:).

FYI I rebased this.

Let's get it in then and get this show on the road!


Misc. changes in scripts and anchoring wrapper

fixes https://github.com/docknetwork/sdk/issues/209


Fix-79525 New pattern to Preserve Case ( hyphen separated variables)

@roblourens , Added this logic for hyphen casing example I mentioned in #79525.
I have handled all the edge cases I would think of , Please review this and let me know.
PS : I think underscore will also be an option ( Just like what I have done here for hyphens ) but it has to be either all hyphens or all underscore and not a mix( For example foo-bar_item ) and I know no one use names variables like that but handling it in code is complicated. ( Maybe if you say yes to underscore then I can open a new issue and then implement that.
FYI : @rebornix .

@roblourens , Sorry is there something still pending or missing for this to get merged ?
I was hoping of getting the underscore also done after this, Thanks :)

It looks ok to me, but I want @rebornix to look at it too.

Cool , Thanks a lot for the review :)
Lets wait for @rebornix to review this :)

@rebornix , Fast return is done now :)

@skprabhanjan thanks for your contribution!

Sorry for the nitpicking... Was just reading that piece of code and thought I would let you know!

Thanks for this , Fixed it here


MM-18762 Remove some usage of deprecated lifecycle methods

As part of filing tickets for a campaign to get rid of deprecated lifecycle methods, I went through and replaced a bunch of trivial cases rather than filing tickets for each of them
Ticket Link
https://mattermost.atlassian.net/browse/MM-18762

All looks good except for missing image preview when image is uploaded in the RN app itself.

Is this for 1.28?  If so, then it will have to wait for 1.26 branch to cut before merging into master.


Logos

Logos in 512x512, 128x128 and 32x32. Inkscape SVG and PNG. The 32x32 PNG has been hand edited for clarity.

Hey... its THAT Alex Taylor!
Those are some lovely shade's of green you've chosen! ;)
My biggest concern is that the logo doesn't have a strong association to redux or subspace (I was secretly hoping for something with a spaceship in it).  This isn't a deal breaker, just something to consider.
Thanks for the time and effort you put into these.

@mpeyper do you want these? Or do you think we should iterate on the design? I think the concept is good but I would try to make it a bit simpler. Great work @thatalextaylor

@vivian-farrell I have spoken to @thatalextaylor about them and the decision was not to go forward with these ones.  The takeaway was that we wanted something a bit cleaner and minimalistic, and preferably with a tie in to redux (it is a redux extension library after all).
@thatalextaylor are you working on new ones (yet?)?  I'm not sure if we should keep this open as a reminder or if it's better to open new ones for each design?

I'll make a new one for new logos.


Legend labels are colored even with color=False

See the example @NikosAlexandris posted in #32

Desired behavior: With color=False everything should be without color, including the legend labels.

This is now fixed in v0.13.1


Use Hash as ID and add Nonce

Makes some changes

Uses proposal hash as ID instead of having a user-defined ID
Hash now includes a nonce, which is a uint256, and is defined as keccak256(target . calldata . value . nonce)

Tests updated as well
TODO:

[ ] Updated README

@fubuloubu let me know your thoughts if you have time


Propfind not allowing empty path

Running Propfind with an empty path throws an exception. However, this should be allowed as the BaseAddress may contain a URI that is entirely valid without having to add anything to it.
This is easily circumvented by creating your own empty Uri and giving it to Propfind, but still.

Yes, you're totally right, thanks for raising this issue.
It actually applies to all methods.
Seems like it can be fixed at this line:
https://github.com/skazantsev/WebDavClient/blob/master/src/WebDav.Client/WebDavClient.cs#L803
I can accept a Pull Request if you have time to fix it, or I can fix it myself.
Let me know what you prefer.

I'm using this via NuGet, I don't have it checked out or anything, so it's a bit of work for me to fix it, so if you could do it that would be great.

Hi @Derpalus ,
I published a new version of the library with a fix to NuGet: https://www.nuget.org/packages/WebDav.Client/2.3.1

Thanks for the speedy fix, it's great to use libraries with active developers :)
I'll update my project to use the latest version.


feat: Add cause to native exception

Which issue does this PR close?

Closes #.
Rationale for this change

We re-throw Java exception which is thrown in JVM during JNI calls. The re-thrown exception includes original exception class name and message but doesn't include cause. We should add the cause as sometimes the cause exception is root cause of the exception.
What changes are included in this PR?

How are these changes tested?

Merged. Thanks.


Filtering

Any recommendations on filterings?

By now there is no filtering API in infinite-tree, but you can try this way before the API is implemented:

Iterate over each node, if a filter criteria is matched, mark a flag (e.g. filtered = true ) to the node and all of its parent nodes.
In your rowRenderer, if the flag is not set, set display: none to hide this node.
Call the update method to update the tree.

The sample code below is using ES6/7 syntax:
let isFilterMode = false;

const tree = new InfiniteTree(el, {
    rowRenderer: (node) => {
        const { id, props = {} } = node;
        const { filtered = true } = props; // defaults to true

        if (isFilterMode && !filtered) {
            return `<div data-id="${id}" style="display: none" />`;
        }

        return `<div data-id="${id}" class="infinite-tree-item" />`;
    }
});

// Turn on filter mode
tree.isFilterMode = true;

// Filter nodes
const searchKeyword = 'keyword';
tree.nodes.forEach((node) => {
    node.props = node.props || {};

    if (node.name.indexOf(searchKeyword) < 0) {
        node.props.filtered = false;
        return;
    }

    while (node && node.parent) {
        node.props.filtered = true;
        node = node.parent;
    }
});

// Update tree
tree.update();

// You can turn off filter mode at any time
tree.isFilterMode = false;
tree.update();

This works well for me. There is one issue that can potentially come up using this method however:  if the first row (root) is hidden it throws off Clusterize calculation of scroll height initially. A workaround is to run tree.scrollTop(1) on the initial run. This is not ideal, but works in the meantime until a better solution is available.

Added in v1.12.0


Make Expr comparable

Here are some starting points

Fixpoint compare_info (x y: Info) {struct x} :=
  match x with
  | mkInfo xname xparams _ xhash =>
    match y with
    | mkInfo yname yparams _ yhash =>
      match Nat.compare xhash yhash with
      | Lt => Lt
      | Gt => Gt
      | Eq =>
        match Nat.compare xname yname with
        | Lt => Lt
        | Gt => Gt
        | Eq => ((fix compare_params (xs ys: list Info) {struct xs} :=
        (match xs with
         | [] =>
           match ys with
           | [] => Eq
           | _ => Lt
           end
         | (x'::xs') =>
           match ys with
           | [] => Gt
           | (y'::ys') =>
             match compare_info x' y' with
             | Lt => Lt
             | Gt => Gt
             | Eq => compare_params xs' ys'
             end
           end
         end)) xparams yparams)
        end
      end
    end
  end
.

Definition compare_rexpr {A: Set} {B: Set} (x y: RExpr B): comparison :=
  compare_info (@get_info A B x) (@get_info A B y).

Fixpoint compare_info (x y: Info) {struct x}: comparison :=
  match x with
  | mkInfo xname xparams _ xhash =>
    match y with
    | mkInfo yname yparams _ yhash =>
      match compare xhash yhash with
      | Lt => Lt
      | Gt => Gt
      | Eq =>
        match compare xname yname with
        | Lt => Lt
        | Gt => Gt
        | Eq => ((fix compare_params (xs ys: list Info) {struct xs} :=
        (match xs with
         | [] =>
           match ys with
           | [] => Eq
           | _ => Lt
           end
         | (x'::xs') =>
           match ys with
           | [] => Gt
           | (y'::ys') =>
             match compare_info x' y' with
             | Lt => Lt
             | Gt => Gt
             | Eq => compare_params xs' ys'
             end
           end
         end)) xparams yparams)
        end
      end
    end
  end
.

Definition compare_smart_info (xsmart ysmart: SmartInfo): comparison :=
  match xsmart with
  | mkSmart xinfo x_is_smart =>
    match ysmart with
    | mkSmart yinfo y_is_smart =>
      compare_info xinfo yinfo
    end
  end.

Started by adding Cmp instances for Func and SmartFunc, still have proofs left, see TODOs in https://github.com/katydid/proofs/pull/24

Next you will probably need https://github.com/katydid/proofs/issues/25 to complete the proofs


Normalize Union output of type_str

Union types are equivalent (but not identical) when they differ in the order of arguments. Currently, type_str prints out Union type with arguments in the same order as it is stored in the type. But I think it might be better (or at least optional with argument) to output it in a canonical and reproducible way (probably just sort it). This would allow one to output descriptions of strings without being surprised by random replacements of types with equivalent types. See here for more information: https://github.com/python/typing/issues/559
So, my suggestion would be to add to type_str an argument canonical which would always output description with everything in the same order, no matter if you are outputting for equivalent but not identical types.

Done: https://github.com/Stewori/pytypes/pull/45

Implemented as of https://github.com/Stewori/pytypes/commit/47c2aebb52cd2cb5da66199f45b5293156fe9b01


Geosearch

This PR introduces basic geo-search functionalities, it makes the engine able to index, filter and, sort by geo-point. We decided to use the rstar library and to save the points in an RTree that we de/serialize in the index database by using serde with bincode. This is not an efficient way to query this tree as it will consume a lot of CPU and memory when a search is made, but at least it is an easy first way to do so.
What we will have to do on the indexing part:

[x] Index the _geo fields from the documents.

[x] Create a new module with an extractor in the extract module that takes the obkv_documents and retrieves the latitude and longitude coordinates, outputting them in a grenad::Reader for further process.
[x] Call the extractor in the extract::extract_documents_data function and send the result to the TypedChunk module.
[x] Get the grenad::Reader in the typed_chunk::write_typed_chunk_into_index function and store all the points in the rtree

[x] Delete the documents from the RTree when deleting documents from the database. All this can be done in the delete_documents.rs file by getting the data structure and removing the points from it, inserting it back after the modification.
[x] Clearing the RTree entirely when we clear the documents from the database, everything happens in the clear_documents.rs file.
[x] save a Roaring bitmap of all documents containing the _geo field

What we will have to do on the query part:

[x] Filter the documents at a certain distance around a point, this is done by collecting the documents from the searched point while they are in range.

[x] We must introduce new geoLowerThan and geoGreaterThan variants to the Operator filter enum.
[x] Implement the negative method on both variants where the geoGreaterThan variant is implemented by executing the geoLowerThan and removing the results found from the whole list of geo faceted documents.
[x] Add the _geoRadius function in the pest parser.

[x] Introduce a _geo ascending ranking function that takes a point in parameter, this function must keep the iterator on the RTree and make it peekable This was not possible for now, we had to collect the whole iterator. Only the documents that are part of the candidates must be sent too!

[x] This ascending ranking rule will only be active if the search is set up with the _geoPoint parameter that indicates the center point of the ascending ranking rule.

On Meilisearch part: We must introduce a new concept, returning the documents with a new _geoDistance field when it passed by the _geo ranking rule, this has never been done before. We could maybe just do it afterward when the documents have been retrieved from the database, computing the distance from the _geoPoint and all of the documents to be returned.

Don't forget the document deletion 🤓

We had a debate with @ManyTheFish about the AscDesc enum in scr/criterion.rs.
I like the version I wrote, but if I remember correctly @ManyTheFish  was worried that it would add too much useless pattern match and proposed to use an enum looking like that:
pub enum AscDesc {
    Asc(String),
    Desc(String),
    GeoAsc([f64; 2]),
    GeoDesc([f64; 2]),
}

Now that we can see what is the total implication of embedding an enum in the AscDesc enum let me know what you think of it.
Personally, I like it more this way, but I'll follow the majority! :grin:

Is this PR breaking?

It adds a bunch of error codes that meilisearch needs to handle but that’s all I think

It adds a bunch of error codes that meilisearch needs to handle but that’s all I think

So it's breaking if I understand well
I add the label :)

When writing unit tests for the AscDesc::from_str function I noticed how we were accepting strange syntax.
This is not the PR to fix everything but maybe @gmourier should look at that and we should only accept a certain subset of characters instead of allowing anything.
All of the following strings are considered as valid sort rules or criterion currently:
"bidule:desc"
"a-b:desc"
"a:b:desc"
"a12:asc"
"42:asc"
"_geoPoint(42, 59):asc"
"_geoPoint(42.459, 59):desc"
"_geoPoint(42, 59.895):desc"
"_geoPoint(42, 59.895):desc"
"_geoPoint(42.0002, 59.895):desc"
"_geoPoint(42., 59.):desc"
"truc(12, 13):desc"

bors merge

bors merge


Legend SQL - assortment of updates

What type of PR is this?
Improvement/Bug Fix
What does this PR do / why is it needed ?

further alias issue resolutions
handle date strings in arithmetic

Which issue(s) this PR fixes:
Other notes for reviewers:
Does this PR introduce a user-facing change?

/easycla


Lightbox not working on iOS

The lightbox doesn't appear on iOS devices for now. Should be a simple fix.

Fixed


M0105 Trigger level sensitivity for loop detectors

Set Trigger level sensitivity for loop detectors.

Name
Type
Value
Comment

status
string
[text]
Loop detector trigger level sensitivity is written as dd-ss where: dd=loop detector number and ss=sensitivity number.Each loop detector is separated with a comma. E.g.dd-ss,dd-ss.

The format as described above requires one to set the sensitivity level of all detector loops in the same command. How about just modifying a single loop detector instead?

Hello,
It's ok for me. Individually or grouped


Tree automatically scrolls to top after various operations

The tree control should not change the scroll position after renaming, moving, or other operations. Currently, it jumps back to the top.

fixed and released https://github.com/JKISoftware/JKI-State-Machine-Editor/releases/tag/2<IP_ADDRESS>


Flavor handle types

Each flavor class template has a DataType and a HandleType (fka ViewType, but that's bad for something like a std::span since the underlying data is mutable). But these are not properly implemented, e.g., it may be beneficial to make CommitmentView be a smart pointer to a commitment.

Resolved by https://github.com/AztecProtocol/aztec-packages/pull/3407


website improvement suggestions - after page 1

all the pages have text on the top left that shouldn't be there: Blastospim main entry page or json loaded - please remove this
on the dataset page - I would remove the "Series" header
on the model page - the figure should be the architecture figure (Figure 2) and table (Figure 5) from the paper attached here.
Please put the captions without specific reference to figure numbers in the paper.
I will have Hayden send you the two models so you can put in the real links.
For the visualization page:
Let's have the choice be 8, 16,32, 64, 128 nuclei stage (without the sequence name - which doesn't mean anything to the user, nucleus -> nuclei since plural here) - and similarly change the title of the visualization to exactly match this.
Let's change the "Select the segmentation" to "Please select the developmental stage of the embryo"
I would remove the download link - since you can download on the download page and I find it confusing here.
I think there is an issue in the visualization of the slices when you look at the bottom-most slice.
BlastoSPIM__3D_instance_segmentation_of_nuclei_in_the_mouse_blastocyst_draft1 (4).pdf

I think I removed the text that shouldn't be there (?)

series header hidden

vis page -- please let me know which timestamps in which series I should use exactly.  New issue https://github.com/flatironinstitute/blastoSPIM_web/issues/11

Download link in vis page removed.

Slicing issue -- I will look into this when I regenerate the data sets for the new timetamps (3)

Added architecture illustration and qualitative illustration to model page.

Wording adjusted above vis dropdown.

I think this either addresses or reissues all suggestions here.


Make example project easier to read/understand

Suggestions for improvements to the example models created by sql init

Remove the leading example_ from all model names & files. Since the schema is named sqlmesh_example we effectively have sqlmesh_example.example_incremental_model which is really clunky.
Add a seed model. So in ./seeds add orders.csv which is basically the values statement in the incremental example, but moved over to a CSV of orders. Then add seed_model.sql and define it. Have incremental model refer to seed_model. Now we have a more complete dag: orders.csv -> seed_model -> incremental_model -> full_model
The advantage of this is people can easily edit orders.csv by adding more data, and seeing what happens, rather than directly editing the VALUES() clause in the incremental model. In addition if the CSV contains a wide range of different dates, users will be able to manipulate some more the incremental logic, including seeing what happens to the incremental model if you set different start/end backfill dates -- it all encourages more experimentation

Bigger ideas:

Have we considered a more real-world project schema, like a basic analytics.orders -> analytics.revenue? I think that'd be conceptually faster for new users to pick up on than incremental -> full.

[x] I'm happy to submit a PR for either idea or both!

@foundinblank i think this is a great idea and would be grateful if you submit a PR. the bigger idea is great and totally up to you if you want to spend the time to do it.

Closed by #779!


feat(interpreter): impl Clone for Stack

used in https://github.com/paradigmxyz/revm-inspectors/pull/220

@rakita kindly ask when will this feature been released, maybe 19.0.0

I hope in two weeks, but next release is going to be a bigger one.


Does this work on macOS?

I am working from a mac with an m2 chip. I want to use nopipeline because I can't get mgcb editor working. I've tried everything I could find as far as using the x64 version of dotnet.
I installed nuget and ran nuget install Nopipeline.Task. That added a folder to my project. I'm not sure how to proceed to get the default configuration file for nopipeline. Running dotnet run doesn't seem to do it. How can I get this working?

All Nopipeline does is generate an mgcb config for the regular pipeline tool. It's not tied to any platform, should work fine.


second try: chunk size and GC tuning

Check List:

[V ] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
[V ] All formatting changes by the build are committed
[V ] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
[V ] Output matches that of calculate_average_baseline.sh

Execution time: 16 s
Execution time of reference implementation: 3m 11s

Could you please rebase this to latest main to address the merge conflict and squash everything into one commit? Thx!


DO NOT MERGE Towards 0.6.5

Review by @nicolasstucki for the first commit, to be pushed directly on master.
The second commit should not be considered part of this PR/review. It's there only to have a chance the CI will pass properly. Once the first commit is OK and pushed on master, I will create another PR with only the second commit.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1933/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2492/
Test FAILed.

Now that artifacts for 0.6.4 are available on Maven Central, retest this please

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1934/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2493/
Test PASSed.

LGTM


How to define a heavy element, hard to be moved by small ones

I've been struggling with Matter JS physics, trying to get them right. I have 2 elements:
 Matter.Bodies.rectangle(400, 400, 113, 66, {
    frictionAir: 1,
    friction: 1,
    density: 0.5,
    restitution: 0
})
Matter.Bodies.circle(0, 0, 5, {
    friction: 0.05,
    frictionAir: 0.05,
    density: 0.001,
    restitution: 0.5
})

According to the documentation, the first one should be heavy and strong. But adding a force of only 0.004 to the small one, I manage to move the big object quite a lot. I tried various numbers and nothing works.
I basically want to have an object that is very hard to be moved by small ones but still be able to move it by adding force to it.
Any help would be appreciated!

I'm not sure what you're looking for exactly, could you provide a more complete example?

Ok! I'll try to create a Fiddle soon

https://codepen.io/dmerlea/pen/WNQvKyy
I am looking for a way to make an object so heavy that it's impossible to be moved by tiny ones.
Having a difference in size from density 0.5 to 0.001 (  500 times ) + the size difference ( 10px ball compared to ~100x60 rectangle) again ~8-10 times bigger. Adding them up should have 5000 times more weight. It's like a bird hitting a plane.
I'm not saying it's a bug, I'm just looking for a way to treat this case. Thank you!

Is somebody looking into this?

Apologies for lack of response. I believe this might be a known issue related to #832 and #890. Until that is figured out, I'd suggest avoiding such a large difference in mass since this will be unstable anyway.


Make IMDSv2 calls mandatory in EC2 plugin

Is your feature request related to a problem? Please describe
IMDSv1 calls are unauthorized and insecure. EC2 plugin used to deploy agent nodes in jenkins now supports making IMDSv2 calls which are secure and authenticated.
https://github.com/jenkinsci/ec2-plugin/blob/05cc8750ea196fc6141bd2487c0e0ce97fcd4940/README.md?plain=1#L340
Describe the solution you'd like
On main node:
Add requireImdsv2: true
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2.Instance.html#requireimdsv2
On Agent nodes:
Add metadataTokensRequired: true, in agent node configs. Default is false https://github.com/jenkinsci/ec2-plugin/blob/05cc8750ea196fc6141bd2487c0e0ce97fcd4940/src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly#L234
Describe alternatives you've considered
No response
Additional context
I tried adding both adnd deploying in my own jenkins, there was some config issue due to which agent nodes were unable to get instance profile
Error:
Failed to obtain credentials from EC2 instance profile: Unauthorized (Service: null; Status Code: 401; Error Code: null; Request ID: null; Proxy: null)

The main node would still be Imdsv1 until we add requireImdsv2: true. However, after adding that agent nodes fail to launch.

This PR updates the agent nodes to use IMDSv2 calls.


chore: update tip of plugin-check-syntax

Summary
Related Links

Checklist

[ ] I have added changeset via pnpm run change.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

❤


handleCreate now respects user-set id in andReturn

Lemme know what you think.
Much of the conversation that led up to this pull request is here: https://github.com/danielspaniel/ember-data-factory-guy/pull/96

I like it .. thanks .. I might change the implementation a bit .. but the test it great. Gimme a day to pull this in ... I am going gonzo on another branch right now.

Thanks a million! :neckbeard:

Thank you :)


originalFilename not found in getImageAsset function

The readme could probably be a lot clearer about this: This library does not interact with the Sanity content lake (database) in any way.
All functions are synchronous, and only help to resolve information based on asset IDs, paths, URLs and similar - for instance, taking a Sanity asset ID such as image-someSha1Hash-320x240-png and returning a more structured record of information, like:
{
  _type: 'sanity.imageAsset',
  assetId: 'someSha1Hash',
  extension: 'png',
  metadata: {
    dimensions: {width: 320, height: 240, aspectRatio: 1.33}
  }
}

If you want to retrieve the original filename from the database, you'll have to use a query against the API


Question:   How do i make the PS1 env output change color

right now, ps1 keeps its same color values all the time.
I have my ps1 export in an extra file that bashrc sources. may this be the cause?

aahh i found a script that kept changing colors for the ps1 prompt only. now it works like it should!


build: add ARM64 mapping for Windows

Windows uses ARM64 for the CMAKE_SYSTEM_PROCESSOR which does not match the current spellings.  Add this and unify the two ARM64 branches.

@swift-ci please test

@swift-ci please test


generate pr summary

⏳ Analyzing changes in this PR... ⏳
This might take a few minutes, please wait

📥 Commits
Analyzing changes from base commit (f5a9108de348804feb15fd49fcefc1bfda78169c) to head commit (64154a9ad86d0651ff58281990ce876376911ca2)

📁 Files being considered (4)
➕ src/diff.ts (1 hunks)
➕ src/messages.ts (1 hunks)
🔄 src/prompts.ts (2 hunks)
🔄 src/pull_request.ts (2 hunks)

autogenerated by presubmit.ai


Adding Arora and Timo to OWNERS

Both of them are active participants of the doc team for R3.

/retest

I'll try close/reopen to trigger the job.

/approve
/lgtm


'unsafeEvaluateCek' is overly lazy

Area
[x] Plutus Foundation Related to the GHC plugin, Haskell-to-Plutus compiler, on-chain code
[] Plutus Application Framework Related to the Plutus application backend (PAB), emulator, Plutus libraries
[] Marlowe Related to Marlowe
[] Other Any other topic (Playgrounds, etc.)
So we have this issue with unsafeEvaluateCek not forcing the final result of a builtin application when the result of unsafeEvaluateCek is forced. I thought it might be some strictness problem within the definition of the CEK machine, however after inspecting and reinspecting all of its internals, I wasn't able to spot any problem, everything there looks exactly like it's supposed to. Then I looked into runCekM and nothing there seemed suspicious as well. So I started inserting bangs everywhere until I made the CEK machine so stupidly strict that it started forcing the result of a builtin application before doing budgeting for it and yet it still wasn't strict enough somehow. At this point I was convinced that the problem is not in the definition of the CEK machine, but rather how it was invoked. And indeed, unsafeEvaluateCek is defined like this:
unsafeEvaluateCek emitTime params = first unsafeExtractEvaluationResult . evaluateCek emitTime params

and this seemingly innocuous definition is our culprit. first uses an irrefutable match (via bimap) for (,) (i.e. matches lazily on the spine of the tuple), which causes all subsequent forcing to WHNF not to force anything. Compare
>>> (error "uh-oh" :: (Int, Char)) `seq` True
*** Exception: uh-oh

with
>>> first succ (error "uh-oh" :: (Int, Char)) `seq` True
True

So in our case forcing the result of unsafeEvaluateCek to WHNF does not do anything AT ALL, no evaluation happens whatsoever.
Solution? Never use bimap, first and second over (,): if laziness is required, use something with a more suggestive name, if it's not, bimap will do the wrong thing and so you should use the strict version of the function.
And yeah, in case you're curious, the Functor instance for (,) a matches strictly on the spine of the tuple, just for some extra confusion.
I absolutely hate the reason why the Bifunctor instance for (,) was implemented differently.

Solution? Never use bimap, first and second over (,)

So what should we do in unsafeEvaluateCek (an other places)?  Do we really want the use of first in there for some reason, or should we do something else to make sure that it doesn't bite us unexpectedly?

So what should we do in unsafeEvaluateCek (and other places)?

Drop bimap, first and second and use stuff like
first' :: (a -> c) -> (a, b) -> (c, b)
first' f (x, y) = (f x, y)

I did check that that makes tests pass.

Fixed

Where's the PR that fixed this?  I'm sure I saw a GitHub notification about this going past a while ago, but I can't find the PR now.

Ah, I think it must have been #3877.  I was misled by the fact that it says it's about tests.


Validate SSH Public keys

Added a method to validate SSH public keys passed with certain CLI
command (VMWare encrypt/update and make-user-data).

Appreciate inputs on the following items:

Whether OK to use the sshpubkeys package or if something else is recommended?
The error message when key validation fails. It prints an error following by the exception/error (see below)
{Unable to validate public key: Invalid public key: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCvJOCPHi0EVRLhrCp35L5MOg2t58EET/qZooqqLQEjbHFi4YU9atKM4PMwaje4x4s0UupMZhfQTyXe47YZktYh9MhmIf9ium7KkE20VTyXBFOGPe3hiZGoD2eXleN6u+zRcKZ8UYfc/ip/5mln2dXjXysTGn/7kDxOqEVoIV7dSL9HCuS5C97MmeyFtcSrkCdD72ArXpXavEBqPwyT2eo5Byek5toisjfMoZ5BlAvaG1ElmFKKIJ/LUq5KACRi+OhJdJxSPTSFRXzFqiPs6qM9YHdzdEla6ruzCuOcNLzyEEfT3LYU9+A//qXlU3rZ1nHULkUnOhVvrH90yX11DW0}

And how do I make the travis unit tests to pass since the sshpubkeys package is being as part of this commit?


Snapshot issue

If I add require("nativescript-image-cache"); to vendors.ts file, because I'd like to put the plugin in the snapshot code - the webpack will fail with status:
# Script run failed in <embedded>@1740:1547
ReferenceError: com is not defined

#
# Fatal error in ../src/snapshot/mksnapshot.cc, line 175
# Check failed: blob.data.
#

Snapshot generation failed with the following error:
Error: Cannot find suitable v8 version! Original error: # Script run failed in <embedded>@1740:1547
ReferenceError: com is not defined

#
# Fatal error in ../src/snapshot/mksnapshot.cc, line 175
# Check failed: blob.data.
#

    at getV8Version.then.catch.error (/Users/dvdbrk/sample-app/node_modules/nativescript-dev-webpack/snapshot/android/project-snapshot-generator.js:254:15)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

Any ideas on how to optimise the plugin so it can be snapshotted?
There is a great article on topic at https://www.nativescript.org/blog/improving-app-startup-time-on-android-with-webpack-v8-heap-snapshot.
@sis0k0 has also done Firebase plugin optimisation (https://github.com/EddyVerbruggen/nativescript-plugin-firebase), but I am not sure how to apply the same changes to this plugin.
Does anyone know at least how to debug the process?

Thanks to @sis0k0 help on Slack, I've changed:
var proxy;

function getListener() {
  if (proxy) return proxy;

  if (typeof (com) !== "undefined" ){
    proxy = com.facebook.drawee.controller.BaseControllerListener.extend({
      _MyNSCachedImage: undefined,
      setMyNSCachedImage: function (img) {
        this._MyNSCachedImage = img;
      },
      onFinalImageSet: function (id, imageInfo, anim) {
        if (undefined != this._MyNSCachedImage) {
          this._MyNSCachedImage.isLoading = false;
        }
      },
      onIntermediateImageSet: function (id, imageInfo) { },
      onFailure: function (id, throwable) {
        console.log("onFailure", id, throwable);
      }
    });
  }

  return proxy;

}

and
var ProxyBaseControllerListener = getListener();

and added this check at few places:
function initialize() {
  if (typeof (com) !== "undefined"){
    com.facebook.drawee.backends.pipeline.Fresco.initialize(application.android.context);
  }
}

and it works, snapshot does not report any issues! BUT when I launch the app, I get the error every second time, the other time app fails to start at all.
d is not a constructor, undefined

😞

Hey @dvdbrk , try this branch https://github.com/yezarela/nativescript-image-cache/pull/17. Running the demo with webpack and snapshot is ok for me.

Tested and all works! Thank you 👏 👏 👏


Add iprange.sh which makes use of suggested iprange tool

It's the same. I did the "classic" approach ...


Function preview did not properly pop up on function pointers in LinearView

When hovering over a function pointer DataVariable in LinearView the preview would always show hex instead of code.

Fixed in 3.5.4305


[events] Code can extract variable name instead of interface

Extraction logic fails on IndexedDB 3.0 because it thinks that the variable name used in the algorithm that fires the event is the name of the interface. This leads to the following errors when running tests to ensure that all interfaces exist (see https://github.com/w3c/webref/pull/650):

error has unknown target interface request
success has unknown target interface request
close has unknown target interface connection
complete has unknown target interface transaction
abort unknown target interface transaction
versionchange has unknown target interface connection
blocked has unknown target interface request
upgradeneeded has unknown target interface request

Closing as fixed. PR was approved and merged.


onAnimationFinish not being called

Hey there! I'm calling setState from the onAnimationFinish function, but it's not being fired. The animation plays to the end, then nothing happens. I tried just calling a console.log from there instead of setting the state, just in case. It's really not being called.
Works fine on mobile thou (lottie-react-native 3.4.0). Is anyone else experiencing that?

Hey again! I looked into the code and it would seem the fix is pretty straightforward. Please take a look at https://github.com/react-native-web-community/react-native-web-lottie/pull/24 to see if it's not against the projects code style/architecture rules or something. This is my first PR on an open source project so it's likely to contain some rookie mistake. Feel free to point it out to me. I'd be glad!

Hello, thanks for your contribution, it's published in 1.4.2 :)


license clarification

is the LICENSE file in the repo for bwa-meme? (It appears to be for bwa-mem2).
What is the exact license for bwa-meme? thanks.

Hi,
Our BWA-MEME source code is distributed under the MIT Licence.
I will update the License file.
Thank you!

Thank you for clarifying the licence file.
The MIT licence says (emphasis added)

Permission is hereby granted […] to any person […] to deal in the Software without restriction, including without limitation the rights to use […]

However the repository's README.md file says

The source code and test scripts are available for academic use

These two statements would appear to be contradictory.

Thank you for clarifying the licence file.
The MIT licence says (emphasis added)

Permission is hereby granted […] to any person […] to deal in the Software without restriction, including without limitation the rights to use […]

However the repository's README.md file says

The source code and test scripts are available for academic use

These two statements would appear to be contradictory.

We updated the Readme, you can freely use the code.
Thank you


HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

Resolves https://issues.apache.org/jira/browse/HBASE-20819

Based on an old patch from Ha, Xiaolin (patch is still attached to Jira), updated for the current master branch
In the hbase-shell module, replace all usages of HTableDescriptor with TableDescriptorBuilder
Add unit tests for removing nonexistent attributes and configurations in the shell (This was previously untested and touches some of the code changes in this PR)
Added new overload for TableDescriptorBuilder.removeValue that takes a String argument.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

-0 :warning:
rubocop
0m 16s
The patch generated 114 new + 434 unchanged - 89 fixed = 548 total (was 523)

-0 :warning:
whitespace
0m  0s
The patch 2 line(s) with tabs.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

-0 :warning:
rubocop
0m 15s
The patch generated 110 new + 434 unchanged - 89 fixed = 544 total (was 523)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 41s
master passed

+1 :green_heart:
checkstyle
0m 41s
master passed

+1 :green_heart:
spotbugs
1m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

-0 :warning:
checkstyle
0m 26s
hbase-client: The patch generated 1 new + 27 unchanged - 0 fixed = 28 total (was 27)

-0 :warning:
rubocop
0m 18s
The patch generated 116 new + 478 unchanged - 95 fixed = 594 total (was 573)

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 13s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

30m 53s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux cabafe19a5f3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 22103067b6

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
compile
0m 47s
master passed

+1 :green_heart:
shadedjars
5m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
shadedjars
5m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  5s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 59s
hbase-shell in the patch passed.

31m 36s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6d6ebef0eff8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 22103067b6

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/testReport/

Max. process+thread count
2392 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 55s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
6m 42s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 27s
hbase-client in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 30s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 54s
hbase-shell in the patch passed.

38m 55s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2bf4d49ca86e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 22103067b6

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/testReport/

Max. process+thread count
1535 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 23s
master passed

+1 :green_heart:
compile
0m 52s
master passed

+1 :green_heart:
shadedjars
7m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 49s
the patch passed

+1 :green_heart:
compile
0m 52s
the patch passed

+1 :green_heart:
javac
0m 52s
the patch passed

+1 :green_heart:
shadedjars
7m 19s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 20s
hbase-client in the patch passed.

+1 :green_heart:
unit
8m 22s
hbase-shell in the patch passed.

39m 45s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b76dedf7d3f6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1378776a91

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/testReport/

Max. process+thread count
2371 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 52s
master passed

+1 :green_heart:
checkstyle
0m 49s
master passed

+1 :green_heart:
spotbugs
1m 18s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 29s
the patch passed

-0 :warning:
checkstyle
0m 39s
hbase-client: The patch generated 1 new + 27 unchanged - 0 fixed = 28 total (was 27)

-0 :warning:
rubocop
0m 25s
The patch generated 116 new + 478 unchanged - 95 fixed = 594 total (was 573)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
15m 39s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

41m  5s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux d73445740988 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1378776a91

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 13s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
shadedjars
7m 19s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 31s
hbase-client in the patch passed.

+1 :green_heart:
unit
8m 20s
hbase-shell in the patch passed.

41m 33s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9001b6da4c04 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1378776a91

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/testReport/

Max. process+thread count
1537 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 26s
master passed

+1 :green_heart:
compile
0m 48s
master passed

+1 :green_heart:
shadedjars
5m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 27s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
shadedjars
5m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  2s
hbase-client in the patch passed.

-1 :x:
unit
2m 11s
hbase-shell in the patch failed.

26m 48s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dc1f385806fd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 71af97cd05

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/testReport/

Max. process+thread count
2106 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
5m 46s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  9s
hbase-client in the patch passed.

-1 :x:
unit
1m 41s
hbase-shell in the patch failed.

28m 21s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 14d0db47cea6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 71af97cd05

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/testReport/

Max. process+thread count
2129 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 47s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  3s
master passed

+1 :green_heart:
checkstyle
0m 44s
master passed

+1 :green_heart:
spotbugs
1m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 38s
the patch passed

-0 :warning:
checkstyle
0m 35s
hbase-client: The patch generated 1 new + 27 unchanged - 0 fixed = 28 total (was 27)

-0 :warning:
rubocop
0m 23s
The patch generated 116 new + 478 unchanged - 95 fixed = 594 total (was 573)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 44s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

41m 23s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux 691d482fbab7 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 71af97cd05

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 29s
master passed

+1 :green_heart:
compile
0m 45s
master passed

+1 :green_heart:
shadedjars
5m 32s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
shadedjars
5m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  3s
hbase-client in the patch passed.

+1 :green_heart:
unit
7m 11s
hbase-shell in the patch passed.

31m 38s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dd6dee58bc37 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 71af97cd05

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/testReport/

Max. process+thread count
2246 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 13s
the patch passed

+1 :green_heart:
compile
0m 51s
the patch passed

+1 :green_heart:
javac
0m 51s
the patch passed

+1 :green_heart:
shadedjars
6m 25s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 29s
hbase-client in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 15s
hbase-client in the patch passed.

+1 :green_heart:
unit
7m  4s
hbase-shell in the patch passed.

35m  2s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c8ad984b907c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 71af97cd05

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/testReport/

Max. process+thread count
2263 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 14s
master passed

+1 :green_heart:
checkstyle
0m 42s
master passed

+1 :green_heart:
spotbugs
1m 17s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 30s
the patch passed

-0 :warning:
checkstyle
0m 31s
hbase-client: The patch generated 1 new + 27 unchanged - 0 fixed = 28 total (was 27)

-0 :warning:
rubocop
0m 22s
The patch generated 117 new + 478 unchanged - 95 fixed = 595 total (was 573)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m  5s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

38m 55s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1959

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux 25e181d9d92e 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 71af97cd05

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Update Readme: Add note re: support for the HTTP gem

Folks when reviewing will be able to quickly see what clients are supported.

@BKSpurgeon HTTP is already listed 3 lines above.

@BKSpurgeon HTTP is already listed 3 lines above.

I completely missed it! I figured that the real problem is that it is not listed alphabetically; and luckily for me through fortuitous accident, I could in fact use it!
I have updated.
Thank you for reviewing.

@BKSpurgeon awesome, thank you!


feat(tracing): redact embedded credentials from URLs

That is, remove the user:password part from URLs like<EMAIL_ADDRESS>Closes #327.

This is currently work in progress, unit tests for sanitizeUrl still need to be added.


[Typescript] Type Cloudscraper does not satisfy the constraint Request

On latest<EMAIL_ADDRESS>$ tsc --noEmit --noErrorTruncation
node_modules/cloudscraper/index.d.ts:78:56 - error TS2344: Type 'Cloudscraper' does not satisfy the constraint 'Request'.
  Type 'Cloudscraper' is missing the following properties from type 'Request': readable, writable, debug, pipeDest, and 48 more.

78   interface CloudscraperAPI extends request.RequestAPI<Cloudscraper, CoreOptions, request.RequiredUriUrl> {
                                                          ~~~~~~~~~~~~
Found 1 error.

I got the number of missing properties down to 24 by uniting Cloudscraper & http.OutgoingMessage
interface CloudscraperAPI extends request.RequestAPI<Cloudscraper & http.OutgoingMessage, CoreOptions, request.RequiredUriUrl> {
  defaultParams: DefaultOptions;
}

➤ tsc --noEmit --noErrorTruncation
node_modules/cloudscraper/index.d.ts:78:56 - error TS2344: Type 'Cloudscraper & OutgoingMessage' does not satisfy the constraint 'Request'.
  Type 'Cloudscraper & OutgoingMessage' is missing the following properties from type 'Request': readable, debug, pipeDest, qs, and 24 more.

78   interface CloudscraperAPI extends request.RequestAPI<Cloudscraper & http.OutgoingMessage, CoreOptions, request.RequiredUriUrl> {
                                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 1 error.

TSLint issue solved by doing this:
interface CloudscraperAPI extends request.RequestAPI<Cloudscraper & request.ResponseRequest, request.CoreOptions, request.RequiredUriUrl> {     defaultParams: DefaultOptions;   }

yo someone can help me i have a discord bot and when  i try to open it  i'm received this error
at Request.<anonymous> (/node_modules/request/request.js:1161:10)     at Request.emit (events.js:210:5)     at Gunzip.<anonymous> (/node_modules/request/request.js:1083:12)     at Object.onceWrapper (events.js:299:28)     at Gunzip.emit (events.js:215:7)     at endReadableNT (_stream_readable.js:1184:12)     at processTicksAndRejections (internal/process/task_queues.js:80:21) {   name: 'CaptchaError',   message: 'captcha' }

@alecs1988 please read through the docs. The error you are getting is because cloudflare is returning a captcha for your request, cloudscraper can't solve it for you, but you can always use some 3rd party service to solve this captcha and submit an answer back to the page you are trying to fetch.

but it worked perfectly but now no, and as i see the discord page does not use captcha, how could i fix this error? using a 2captcha service?

@alecs1988 it might be that your Ip address was blacklisted because of the number of requests you are making. I would use first try to different user agent, if that wont help, then most probably 2captcha or similar service would be your only solution

@codemanki yo bro i have same problem, check discord when u can


C++ projects and their initialization via Microsoft.Build.Evaluation

yes, again...
https://social.msdn.microsoft.com/Forums/en-US/2badfe39-1321-4ec4-9cc8-74bf4efd39b3/
// InvalidProjectFileException:"D:\Microsoft.Cpp.Default.props" - yes, because $(VCTargetsPath) is not defined.
new Project("Sample.vcxproj", new Dictionary<string, string>(), null);

// OK, because I also have 14.0
new Project("Sample.vcxproj", new Dictionary<string, string>(), "14.0");

// InvalidProjectFileException: The tools version "15.0" is unrecognized.
// Available tools versions are: "12.0", "14.0", "2.0", "3.5", "4.0". - yes, I know why is so -_-
new Project("Sample.vcxproj", new Dictionary<string, string>(), "15.0");

<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
</Project>

-_-
Looks like the most easy way should be init by null and to define related properties to .ctor. I think should work o_o

Same here, https://github.com/3F/MvsSln/issues/5#issuecomment-410464661 solves problem. But this only for .netfx 4.6
v14.3.0 (.netfx 4.5) contains same problem by the way.

Too many changes...
The main problem will be resolved together with #23

Looks like the most easy way should be init by null and to define related properties to .ctor. I think should work o_o

I think it does (populate everything what is needed) but this is wrong way according to Sdk etc.
My priority is IeXod
Closed.


Is there a way to slide the "right view controller" over the "front view controlller"?

I'm looking to add a right sidebar menu that is semi-transparent to slide over the front view controller where the front view controller does not move.
I've looked through issues and examples but could not find a way. If you could point me in the correct direction that would be awesome.

Put below code on menu view controller its works for me
@interface SidebarTableViewController ()
{
UIView* coverView;
}
-(void) viewWillDisappear:(BOOL)animated
{
[coverView removeFromSuperview];
//[self.revealViewController.frontViewController.view setUserInteractionEnabled:YES];
// get your window screen size
}
-(void) viewWillAppear:(BOOL)animated
{
// get your window screen size
CGRect screenRect = [[UIScreen mainScreen] bounds];
//create a new view with the same size
coverView = [[UIView alloc] initWithFrame:screenRect];
// change the background color to black and the opacity to 0.6
coverView.backgroundColor = [[UIColor blackColor] colorWithAlphaComponent:0.6];
// add this new view to your main view
[self.revealViewController.frontViewController.view addSubview:coverView];
//   [self.revealViewController.frontViewController.view setUserInteractionEnabled:NO];
}


[arm-insights 2015-07-01] Semantic validation fails with Unresolvable path parameter error

azure-rest-api-specs/arm-insights/2015-07-01/swagger/insightsManagementClient_DiagnosticsSettings.json should be valid Swagger
Errors
UNRESOLVABLE_API_PATH_PARAMETER : #/paths//{resourceUri}/providers/microsoft.insights/diagnosticSettings/service/get/parameters/2/name : API path parameter could not be resolved: subscriptionId
UNRESOLVABLE_API_PATH_PARAMETER : #/paths//{resourceUri}/providers/microsoft.insights/diagnosticSettings/service/put/parameters/3/name : API path parameter could not be resolved: subscriptionId

This is resolved in both insights and monitor folders. The extra (unused) parameter subId has been removed.

@kirthik can you close this since it is now resolved?

@gucalder : Can you please provide the commit id? That will make it easier to track

The commit for this specific file is #efed63280648eebdec8be513470cd6c23783efb6 from 2017-02-16.


Record UTM coords, calculate correct latlongs for coastal intersection

Previously, latlongs for each tile were calculated with linear interpolation, leading to inaccuracies. This results in non-coast tiles being reported as coastal. This PR:

Calculates the latlongs by using GDAL to query the UTM coords for the upper-right and lower-left pixel and convert them to WGS84.
Replaces WGS84 latlongs in the created subject manifest with UTM coords

Caveats
I couldn't get ruby-gdal to read GeoTIFFs properly, so I used python's bindings to create a small script (geotiff.py, wrapped by geotiff.rb) to read various data (coords, projection etc) from GeoTIFFs. This has two implications:

The script ends up being called multiple times for the same image. It could do with having an option to output, for example, the geoTransform for a file to avoid this.
Because colour calibration (for LANDSAT 4/5/7 images) and levelling (for LANDSAT 8), which destroy the coordinate data in the GeoTIFF, are called before tiling, we have to create these corrected images as copies, so that we can later extract the various coordinate information we need from the original GeoTIFFs. This will have diskspace implications, but I don't know how much of a concern that is.

To download the smallest dataset I could get the API to return (~650 scenes) would have taken me several days, so I just tested with one scene, but there shouldn't be any issues processing mulltiple scenes.
@aliburchard I think FF are best off reviewing the results of this before this is merged in, what with me not being totally familiar with the dataset. Ran out of time before creating a scenes manifest, but let me know if that's a dealbreaker and I can find the time somewhere.

So excited about this. Do you think you can test this on a single scene? We've done a lot of our calibration work with scene LE70440351999204EDC01. We can even send you a MATLAB file of calibrated data of where the forests are as a test. Would be great to check the coordinates for those subjects against the calibration file.

@jebyrnes With the code the way it is I don't think I can easily download a specific scene. Would you be able to send me the coordinates instead?

Sure - here's the meta-data for the scene:
Taken on 7/24/1999

sceneID
sensor
acquisitionDate
upperLeftCornerLatitude
upperLeftCornerLongitude
upperRightCornerLatitude
upperRightCornerLongitude
lowerLeftCornerLatitude
lowerLeftCornerLongitude
lowerRightCornerLatitude
lowerRightCornerLongitude
sceneCenterLatitude
sceneCenterLongitude

LE70440351999204EDC01
LANDSAT_ETM
1999
37.003
-123.374
36.6948
-121.264
35.3808
-123.822
35.0789
-121.754
36.044
-122.553

The scene name should be in the tif filename.


Updating to AutoMapper 5.0

From 4.1.1. Switching to Mapper.Initialize because that's how it works in 5.0 now.

Hi @jbogard, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Thanks @jbogard! This is now merged.


STORM-3488 Scheduling can cause RAS_Node resources to become negative

Pull STORM-3488 into 2.1.x

@Ethanlm I can't remember if this is described anywhere, so just in case no one told you: Generally when cherry picking back changes, unless there are conflicts with the base branch I think you can do the cherry pick without a PR/review and without waiting for the 24 hour waiting period. I think we have been considering the original branch review sufficient when there aren't conflicts. Just in case you don't want to go through the delay :)

@srdo  Thanks for the information. I tried to cherry-pick this commit but there were conflicts. So I asked @dandsager1 to file a separate PR so we can review.

Ok, I just wanted to be sure you knew.

@srdo  Thank you very much. I really appreciated it


Font-size changes according the size of the text in Mobile

I have a Android device (moto x), and the font-size changes everytime the text size change as well. So I have been researched a lot and I don't found the solution. I believe this is an issue.

Duplicate of #4273


Change the default notebook:change-cell-to-code (command+1) shortcut and others.

Description
Tried on jupyter-lab vim extension version: 0.15.1
I'd like to remove the change-cell-to-code,  change-cell-to-raw and change-cell-to-markdown shortcuts. But I can't. I tried to put this on the user config.
{
    "shortcuts": [
                {
            "args": {},
            "command": "notebook:change-cell-to-code",
            "keys": [
                "Accel 1"
            ],
            "winKeys": {},
            "macKeys": {},
            "linuxKeys": {},
            "selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-editMode",
            "disabled": true
        }
    ]
}

Reproduce
Go to advanced settings, try to override using the above json.
Expected behavior
The shortcut should be removed.
Context

jupyter labextension list:
(studio) sagemaker-user@studio$ jupyter labextension list
JupyterLab v3.6.0a4
/opt/conda/envs/studio/share/jupyter/labextensions
        nbdime-jupyterlab v2.1.1 enabled OK
        sagemaker_datawrangler v0.3.8 enabled OK (python, sagemaker_datawrangler)
        @jupyter-widgets/jupyterlab-manager v3.1.0 enabled OK (python, jupyterlab_widgets)
        @jupyterlab/git v0.34.2 enabled OK (python, jupyterlab-git)
        @jupyterlab/server-proxy v3.2.1 enabled OK
        @jupyterlab/scheduler v1.1.4 enabled OK
        @amzn/aws-hil-axis-jupyter-lab-extension v5.0.7 enabled OK (python, amzn_aws_hil_axis_jupyter_lab_extension)
        @amzn/sagemaker-ui v5.39.2 enabled OK (python, amzn_sagemaker_ui)
        @amzn/sagemaker-ui-canvas-collaboration v0.0.0 enabled OK (python, @amzn/sagemaker-ui-canvas-collaboration)
        @amzn/sagemaker-ui-theme-dark-jupyterlab v5.39.2 enabled OK (python, amzn_sagemaker_ui_theme_dark_jupyterlab)
        @unfolded/jupyter-map-sdk v1.5.1 enabled OK (python, unfolded.map_sdk)

Other labextensions (built into JupyterLab)
   app dir: /opt/conda/envs/studio/share/jupyter/lab
        @amzn/sagemaker_session_manager v0.2.0 enabled OK
        @axlair/jupyterlab_vim v0.15.1 enabled OK
        jupyterlab-plotly v5.8.2 enabled OK
        sagemaker_notebooks_extension v0.2.0 enabled OK
        sagemaker_sharing_extension v0.1.0 enabled OK

Uninstalled core extensions:
    @jupyterlab/launcher-extension
    @jupyterlab/running-extension

Disabled extensions:
    @jupyterlab/filebrowser-extension:share-file
    @jupyterlab/git:clone
    @jupyterlab/scheduler:IAdvancedOptions

results from uname -a:
(studio) sagemaker-user@studio$ uname -a
Linux default 4.14.296-222.539.amzn2.x86_64 #1 SMP Wed Oct 26 20:36:53 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Python package version: 3.9
Browser and its version:  Chrome  108.0.5359.124 (Versão oficial) (x86_64)

Are you just trying to disable the shortcuts, as opposed to assigning another key binding to these commands? Are you adding the preferences to a clean keyboard shortcut configuration (press "Restore to Defaults" in the regular settings editor) or to the default configuration that JL pre-populates? Disabling the bindings seems to work for me either way.
If you're starting from the keyboard shortcuts that JL pre-populates, you need to find the relevant bindings in the pre-populated list and add "disabled": "true" rather than add the whole binding again at the end, as the pre-populated setting usually overrides added settings at the end in Lumino. I usually set key bindings in a clean key binding settings file to avoid this hassle.
{
    "shortcuts": [
        {
            "command": "notebook:change-cell-to-code",
            "keys": [
                "Accel 1"
            ],
            "selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-editMode",
            "args": {},
            "disabled": "true"
        }
    ]
}

Inability to disable the default keybinding when you try to assign another binding is a known upstream issue: https://github.com/jupyterlab/jupyterlab/issues/15038.

I'll close this for now since there wasn't a response. If you're still experiencing this issue after modifying or adding the keyboard shortcut settings per https://github.com/jupyterlab-contrib/jupyterlab-vim/issues/75#issuecomment-1751765432, please reopen with additional details or open a new issue.
As mentioned above, the bug where the default keybinding can't be disabled when you try to assign another binding is being tracked upstream at https://github.com/jupyterlab/jupyterlab/issues/15038.