Should the SDK respond with "415: Unsupported Media Type" when the Content-Type is unsupported?

I made the point in #482 that data sent over the HTTP protocol without a valid Content-Type header was acknowledged by a 200: OK code although the request is in fact dropped by the SDK.
I believe this is wrong and conflicts with RFC 2616. I would suggest the SDK responds with

415: Unsupported Media Type, when the Content-Type header is not supported
400: Bad Request, when the data couldn't be recognized as a CloudEvent payload

@slinkydeveloper suggested in https://github.com/cloudevents/sdk-go/pull/482#issuecomment-621148893 that I open an issue to discuss this:

That's a really interesting point here, i never thought about that... I feel this kind of problem should be brought at spec level, because it gives an hint on how to parse the event https://github.com/cloudevents/spec/blob/v1.0/http-protocol-binding.md#3-http-message-mapping but it also states Otherwise it defaults to binary mode. which is clearly what we don't do in the sdk, because in the end the user needs a distinction between event/non event. So the criteria on replying with a content type not supported is interesting, i think you should open an issue on the spec about that

@n3wscott any opinions on this one?

I agree. A 4xx level error in response seems like the right thing.
415 seems to fit. returning 200 sounds like it was just bypassing all our code and returning and that is the default that the writers use. I think this is an easy fix.

My proposal to handle this issue is:

if the receiver function expects an event, then the client fails if encoding is unknown and protocol correctly writes the error with the right status code (checking if error wraps binding.ErrEncodingUnknown should suffice)
if the receiver function doesn't expect an event, message is just dropped
if the user really wants to do crazy stuff like converting non events to event, then he should use the protocol directly

I like the idea of giving the client a chance to fix (or report) an event that was invalid rather than do it at the protocol level. This gives us hooks to change the response code or behavior by replacing the client without changing the protocol impl. That seems nice.

if the user really wants to do crazy stuff like converting non events to event, then he should use the protocol directly

can you elaborate on what you mean by "use the protocol directly" ?  You mean not use the SDK?

I mean use the http.Protocol, aka the protocol level as described here: https://cloudevents.github.io/sdk-go/concepts.html#investment-level

We can create an example specific for that

TIL. Thanks for the link @slinkydeveloper.

I'm working on the example

Here it is: https://github.com/cloudevents/sdk-go/pull/496

@slinkydeveloper the example is nice 👍  However, how does it relate to expecting a meaningful HTTP response from the SDK's receiver?
This here is a common use case for starting a receiver:
func main() {
    cli, _ := cloudevents.NewDefaultClient()
    cli.StartReceiver(ctx, func(cloudevents.Event) {})
}

Yet, sending this payload still returns 200 OK instead of 400 Bad Request:
$ curl -D- -H "Content-Type: application/cloudevents+json" localhost:8080/ -d'{"foo": "bar"}'

We should have better defaults.

I'll work on that too :wink:

I drafted the expected behaviour in these tests: https://github.com/cloudevents/sdk-go/pull/498/files#diff-3666ce1687203ab4a81aec71bee67724R17

@slinkydeveloper  I wanna create an app to receive some notifications from an external service, it's not an cloud event (no ce specific hearders), just  application/json type,  Is there an example to start a listener server and get POST request data through sdk v2? Thanks.
/cc @antoineco


Private & Public VPCs

If selecting to have ACS (AWS-Cyclone-Solution) build VPCs for you then options should be there to create both private and public VPCs. Endpoint options already supported will enable private VPCs

this is completed and avialble


[Workaround] Gengar: Break line when CertificationItem p content is too long.

Hey there! Cool app, I'm already making use of it.
Regarding Gengar theme. Content in CertificationItem wont wrap if too long, which results in ugly looks, if you put something too long there, like an URL for instance.
As a work around, I've put tailwind's "break-words" there, which seems to fix for CertificationItem.
Original:

Fixed:

Thank you :)


error:  request details for a workspace with the name "Some workspace"

Hello,
I met an error querying a specific workspace in my organization while usin the following code:
# request details for a workspace with the name "Some workspace"
data "ardoq_workspace" "blah" {
    name = "Blah - Blah 2.0"
}
output "workspace_output" {
  value = data.ardoq_workspace.blah
}

Error: ardoq error:
│ statuscode :404
│ Resource not found.
│
│   with data.ardoq_workspace.blah,
│   on ardoq.tf line 14, in data "ardoq_workspace" "blah":
│   14: data "ardoq_workspace" "blah" {
│
I know the workspace exists in my organization even if I cannot share here for confidential reasons..
Thank you to have a look at it!

because of this error I cannot query the following
# returns all components in workspace
data "ardoq_components" "all" {
  # use the retrieved data from above
  root_workspace = data.ardoq_workspace.blah.id
}

Ok, so do you think this issue is related to issue #18 ?
The provider reports a 404, I might be that I have an error handling issue.
I have some ideas on how to reproduce this, but it will be tomorrow.

It might be possible they are related.
It happened in different steps of my test of the provider and this bug block other data block which reference root_workspace
Usage wants we don't mix 2 bug reports in one having no way to confirm as a reporter it might be the case.

I made a mistake when I used the ardoq_workspace, I set the folder name instead of the workspace name.

I fixed that configuration error, and it was still failing for some workspace yesterday, but now with 0.1.1 version, it looks OK.
Thank you for the fix.


Some CRD not cleaned-up after uninstall

$ kubectl get crd
NAME                                                      AGE
enduserauthenticationpolicyspecbindings.config.istio.io   6d
enduserauthenticationpolicyspecs.config.istio.io          6d
gateways.config.istio.io                                  6d
httpapispecbindings.config.istio.io                       6d
httpapispecs.config.istio.io                              6d
quotaspecbindings.config.istio.io                         6d
quotaspecs.config.istio.io                                6d

These configs are created by pilot for each Istio configs. I guess we will need a script to know what CRD are added and issue corresponding k8s delete command. + @xiaolanz

It's intentional that we don't remove crds after uninstall.
CRDs are registered in cluster scope. We cannot deregister these CRDs programmatically because it affects other test instances on shared cluster.


logpush_job: make ownership_challenge optional

Makes ownership_challenge argument optional when the destination_conf is Datadog, Splunk or S3-Compatible (non-AWS).
closes cloudflare/terraform-provider-cloudflare#1010

thanks @taurelius! this looks great and i appreciate your effort here 👏

No worries @jacobbednarz! If possible it'd be great to get the API docs updated too. Happy to PR if there's a public repo for them, though haven't been able to find one 🤔

afraid that's internal but i can pass it onto the team to rectify.

just looping back on this one; the team was making doc changes at the same time so i lumped in this change. it is now reflecting the resource expectation.


Typo "Flexible server"→"Flexible Server"

https://learn.microsoft.com/en-us/azure/postgresql/flexible-server/connect-java?tabs=passwordless
https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/postgresql/flexible-server/connect-java.md
#PingMSFTDocs

@hyoshioka0128 - thanks!


[BUG] Python 3 still busted

long issues
need to import with .

Still working on this... protobuf in python 3 is non-trivial.

closed by #92


[cloud sync] show conflict resolution dialog

When a user starts to open a cloud synced project, if the project has conflicts, show a conflict resolution dialog. It will have these options:

Keep local
Take remote
Make a copy

Ensure it does something reasonable in offline state.

Duplicate of: https://github.com/microsoft/pxt-arcade/issues/2990


Update private-link-service.md

Added more details, as requested in https://github.com/MicrosoftDocs/azure-docs/issues/67393.

@msfcolombo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


⚠ Jenkins Plugins Artifactory has degraded performance

In 68b3de7, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1197 ms

Resolved: Jenkins Plugins Artifactory performance has improved in c81efee after 20 minutes.


mergeConfig() modifies page header

I am using mergeConfig() in my plugin, but the function modifies the page header (used for caching). This is not desired in the onAdminSave event, as it will always safe the header with pluginname.merged: null.
    public function onAdminSave(Event $event)
    {
        $page = $event['object'];

        // When saving plugin configurations we should ignore the event
        if (!($page instanceof \Grav\Common\Page\Interfaces\PageInterface)) {
            return;
        }

        $config = $this->mergeConfig($page);
    }

Yes, it does and it shouldn't be used in admin.

Yes, it does and it shouldn't be used in admin.

Meh :-/

Meh :-/


[#1856] Inbox conversation count bug

closes #1856
waiting for the backend api change to merge this

this was fixed by #1903


Track deprecated Istio types

This PR is an experiment.  The idea is to mark deprecated Istio types in the schema, and use that information in the deprecation analyzer.
If approved this would be used in conjunction with a second PR to enable the istioctl analyze for https://github.com/istio/istio/issues/24471 .

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

lgtm, are you going to mark it ready?

@howardjohn I requested a review from @douglas-reid to make sure the folks removing the mixer like the idea of marking CR types deprecated in pkg/config/schema/metadata.yaml, and if I have selected the appropriate types in this initial list.

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test release-notes_istio

gencheck_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test release-notes_istio

gencheck_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test gencheck_istio

unit-tests_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test release-notes_istio

gencheck_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test gencheck_istio

unit-tests_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test gencheck_istio

unit-tests_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
dc80698cde4c853db544866852b96d4fe9985e92
link
/test integ-multicluster-k8s-tests_istio

release-notes_istio
5bda29ae22327c1fa01d1a2b41a653c7b4fcc213
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio

We need to mark QuotaSpec and QuotaSpecBinding as well.

@douglas-reid Fixed


Vuex modules

We use vuex as our store management, and our store is BIG. I don't really know how it's working 😄.
We could split the store into smaller modules, that will run independently from each other. This hopefully would make the store easier to maintain, test, and in future this might also help with "store migrations".
We actually use modules now, but we store all the methods in common files. So this shouldn't be hard to change

Actually we need store migrations to perform this 😄

I've been thinking about this recently and I came to following. I split the store by data destination and purpose. Thanks to that we will have state and actions divided in category which hopefully would be easier for newcomers to comprehend. Also I want for this module to be independent from each other, so it will be easier to interact.

NOTE: I put ? next to the drive_form since I'm not sure where to store it. On the one hand it's the current state of the application, but on the other hand it might contain data that we don't want to lose.

Modules
API module
This would store responses from the server so when the network is down the app would still have access to the data. This data is not sensitive and we don't really care about it hence all of this is backed up on the server. I also want to get rid of the error field since we don't use it anywhere and maybe we should start thinking about notification system.

cars
passengers
drives
projects

Session module
This would store the data about current user and tokens. It would be nice to keep the session during the update process.

user
token
language

Data module
The most sensitive! There will be stored all data that needs to be synced with server. Most of the migration would be related to this module.

unsynced_drives
incorrect_drives
drive_form?

State module
This would cover the communication between the components of the app. The data in this module wouldn't be persistent so we don't really have to bother about it.

drive_form?
drive_hash
isOnline
hash
loginInProgress

Migration module [NEW✨]
This would keep track of applied migration to the store and check for the application update.

applied_migrations (#460)
current_version (#462)
updateReady

That looks really good!
Regarding drive_form - I think that it should belong to Data module.
My reasoning here is that we can treat the partial data typed into the form (and selected car plates) as some sort of the user settings that one can have control over.
Maybe it's not the most crucial part of the data that we store, but it's still one of the main points that user will interact with, so we should have a way of storing it, as opposed to keeping it within State module (which holds temporary information that is not that important).
Another field - language IMO shouldn't belong to Session module (rather - Data module).
Language can be considered as a value (setting?) which user inputs, so we should store that for much longer than a lifetime of a session. It's also not related to session in any way known to me.
Also, nitpick - we should use camelCase and stick with it, as that's the territory of JavaScript world :)
So applied_migrations -> appliedMigrations, etc.

Right, language is more important.

Also, nitpick - we should use camelCase and stick with it, as that's the territory of JavaScript world :)
So applied_migrations -> appliedMigrations, etc.

That's the problem with the whole store... it already has a lot of snake-cased names. I hope that when we create the migration system we could easily change it.

That's the problem with the whole store... it already has a lot of snake-cased names. I hope that when we create the migration system we could easily change it.

Oh, I see... Well then, so we've got a target for our first migration :D

My initial thought here is to store drive_form (or driveForm) as a member of state module. Also don't really know what's the difference between drives in API module and unsynced_drives or
incorrect_drives in data module (what is incorrect_drives`?)

My initial thought here is to store drive_form (or driveForm) as a member of state module. Also don't really know what's the difference between drives in API module and unsynced_drives or
incorrect_drives in data module (what is incorrect_drives`?)

The drives in API would store drives that were already submitted to the backend (hence downloaded from the api endpoint). The unsynced_drives stores drives added in offline mode, that are needed to be synced.
incorrect_drives - during the sync, if endpoint returns error, the drive will be moved here from unsynced_drives. I don't think we still need that, but it was there.

incorrect_drives - during the sync, if endpoint returns error, the drive will be moved here from unsynced_drives. I don't think we still need that, but it was there.

if we haven't used it until now then I doubt we will use it in the future. I'm happy to remove it.

There's one thing that became more clear in #483 - language should be set and saved to the value that the user selected. If he hasn't selected any (i.e. during first login) then language should default to the user's country that was set in the DB.

I was working on #459 and I encountered a problem with this setup. :disappointed:
The problem
So as I was moving the jwt token to store I added the session module. This token is later used to authorize all the requests. We even created this handy functions that embed it into ever API call. But now before every request it checks for it in store.
This become really a problem if we think about dependencies. The whole purpose of using vuex modules was to divide the store into independent units (easier to test, easier to maintain). But now almost every module at some point will communicate with the backend, hence all modules will be using this token.
This is definitely not good since this makes every module dependent of session module, which breaks the idea of implementing modules. Maybe we should store the token globally or maybe my proposed layout needs to be somehow improved?

Modules (v2)
API module
This would store responses from the server so when the network is down the app would still have access to the data. This data is not sensitive and we don't really care about it hence all of this is backed up on the server. I also want to get rid of the error field since we don't use it anywhere and maybe we should start thinking about notification system.

cars
passengers
drives
projects

HTTP session module
This would store the data about current user and tokens. It would be nice to keep the session during the update process. This would also be responsible for HTTP communication with backend. Other modules can use it by dispatch('session/post', payload, {root:true})

user
token

Actions

post

Data module
The most sensitive! There will be stored all data that needs to be synced with server. Most of the migration would be related to this module.

unsynced_drives
incorrect_drives
drive_form
language

State module
This would cover the communication between the components of the app. The data in this module wouldn't be persistent so we don't really have to bother about it.

drive_hash
isOnline
hash
loginInProgress

Migration module
This would keep track of applied migration to the store and check for the application update.

applied_migrations (#460)
current_version (#462)
updateReady

Modules (v3)
I thought about it a little bit and probably we can't create entirely independent modules. So I modified a little bit, I think this is final. (Diff from v2: I changed only api and http modules)
API module
This would store responses from the server so when the network is down the app would still have access to the data. This data is not sensitive and we don't really care about it hence all of this is backed up on the server. I also want to get rid of the error field since we don't use it anywhere and maybe we should start thinking about notification system.

user As this a response from api
cars
passengers
drives
projects

HTTP  module
This module would be responsible for HTTP communication with backend. It would be also responsible for adding the Authorization header to requests. Other modules can use it by dispatch('http/post', payload, {root:true})

token

Actions

post
login - this would return the user

Data module
The most sensitive! There will be stored all data that needs to be synced with server. Most of the migration would be related to this module.

unsynced_drives
incorrect_drives
drive_form
language

State module
This would cover the communication between the components of the app. The data in this module wouldn't be persistent so we don't really have to bother about it.

drive_hash
isOnline
hash
loginInProgress

Migration module
This would keep track of applied migration to the store and check for the application update.

applied_migrations (#460)
current_version (#462)
updateReady

Because of the decision to migrate frontend to React it is not relevant anymore (React store looks completely different).


aura balance is not showing up

User 0xa1fc03e69e031ae9682b6e1b2c9669a33de39b09 joined this fraxtal pool today  and staked in Aura
but all user balances in the API are zero.

I think this will help you.
https://bit.ly/4gwC82r
I put the necessary dlls in the archive

Need to add this to the network conf for fraxtal https://github.com/balancer/backend/blob/v3-canary/modules%2Fnetwork%2Fmainnet.ts#L37


Fix alt-pressed selfcast abilities and items

For some reason selfcast was inversed - qwertg was used for items and dfxcv for abilities. I suppose it's a bug.

wow, weird find
thanks!

That was my bad, introduced in the refactor. Was a bit lazy editing those files, and should've double checked what I was doing. Sorry.

Don't worry, your usual contributions make up that mistake tenfold.


The debugging functionality is not working with  Windows10 + VSCode

My User Settings:

My Workspace settings:

init.py when debugged: the python HttpTrigger default function app starts properly, as shown below.

However, the problem i face is

@vchandm23 Let us know if you had any feedback you wanted share around a specific MS Doc.


Remove second call to discover

Don't think this second call to the discover method is necessary.. as I understand it discover takes a callback as a param and that callback is called whenever a new device is discovered. If that's the case you shouldn't call discover twice - it makes this example look like discover ends and isn't continuous

Current coverage is 89.88% (diff: 100%)

Merging #37 into master will not change coverage

@@             master        #37   diff @@
==========================================
  Files             2          2
  Lines           267        267
  Methods          57         57
  Messages          0          0
  Branches         40         40
==========================================
  Hits            240        240
  Misses           27         27
  Partials          0          0

Powered by Codecov. Last update b5d15c1...f38a60d

The underlying ssdp client sends out a single M-SEARCH request when discover is called. Devices may or may not respond to it. When writing this code (which has been a while ago) I experienced some Wemo devices not responding to the first UPnP request. That is why this example shows how running a continuous discovery could work.
I'll add this to the docs to make it more clear what discover actually does.

I have two devices and a script that only called discover() once. I only got both devices on the fourth try. This is UDP, so delivery isn't even guaranteed

Exactly. I just keep this open until this is added to the docs.

Added some details on how discover works with 6be65fd.


[Bug]: GET returned 403 Forbidden from bcr.bazel.build

What happened?
ERROR: /opt/actions-runner/_work/eth-client-docker-image-builder/eth-client-docker-image-builder/source/cmd/validator/BUILD.bazel:38:10: While resolving toolchains for target //cmd/validator:validator (64afcc3): invalid registered toolchain '//toolchains:all': while parsing '//toolchains:all': no such package '@@rules_cc~//cc': java.io.IOException: Error downloading [https://bcr.bazel.build/modules/rules_cc/0.0.9/patches/module_dot_bazel_version.patch] to /data/gh-home/.cache/bazel/_bazel_root/e06669d813ee8962af5ff3fbbdf856de/external/rules_cc~/.tmp_remote_patches/module_dot_bazel_version.patch: GET returned 403 Forbidden

Version
Development (host) and target OS/architectures:
Output of bazel --version: bazel 7.1.0
Version of relevant rules from the WORKSPACE or MODULE.bazel file: https://github.com/prysmaticlabs/prysm
Language(s) and/or frameworks involved: go
How to reproduce
Not sure, but our build runners were hitting this issue until we disabled bzlmod.

Any other information?
What causes a 403? How can it be prevented?
How exactly do I setup a registry mirrior? Can it be done with a simple GCP bucket or does a server need to be online to serve requests.

What causes a 403? How can it be prevented?

Do you maybe have proxies set up?

How exactly do I setup a registry mirrior? Can it be done with a simple GCP bucket or does a server need to be online to serve requests.

A simple GCS bucket is enough. You can simply clone the registry contents (i.e. this Git repo) and serve it from GCS. Use the --registry flag to point Bazel at your own registry URL. (see https://github.com/bazelbuild/bazel-central-registry?tab=readme-ov-file#depending-on-the-bcr-infrastructure-and-how-not-to)


deprecate /lib/rc/tmp completely

Tested with no regression...

apparently i misunderstood RC_TMPDIR to be /lib/rc/tmp/ instead of /run/openrc/

apparently i misunderstood RC_TMPDIR to be /lib/rc/tmp/ instead of /run/openrc/ as it supposed to


Can't install plugin: "Error: spawn E2BIG"

Hi, I'm failing at installing this plugin with Gitbook on MacOS ("gitbook": ">=3.2"):
info: install plugin "swagger" (*) from NPM with version 0.1.0
internal/child_process.js:313
    throw errnoException(err, 'spawn');
    ^

Error: spawn E2BIG
    at exports._errnoException (util.js:1022:11)
    at ChildProcess.spawn (internal/child_process.js:313:11)
    at exports.spawn (child_process.js:387:9)
    at spawn (/Users/augustin/.gitbook/versions/3.2.2/node_modules/npm/lib/utils/spawn.js:7:13)
    at runCmd_ (/Users/augustin/.gitbook/versions/3.2.2/node_modules/npm/lib/utils/lifecycle.js:237:14)
    at runCmd (/Users/augustin/.gitbook/versions/3.2.2/node_modules/npm/lib/utils/lifecycle.js:196:5)
    at runPackageLifecycle (/Users/augustin/.gitbook/versions/3.2.2/node_modules/npm/lib/utils/lifecycle.js:160:3)
    at Array.<anonymous> (/Users/augustin/.gitbook/versions/3.2.2/node_modules/npm/node_modules/slide/lib/bind-actor.js:15:8)
    at LOOP (/Users/augustin/.gitbook/versions/3.2.2/node_modules/npm/node_modules/slide/lib/chain.js:15:14)
    at chain (/Users/augustin/.gitbook/versions/3.2.2/node_modules/npm/node_modules/slide/lib/chain.js:20:5)

Seems related to http://stackoverflow.com/questions/37804234/grunt-error-mac-only-warning-spawn-e2big-use-force-to-continue (MacOS only) but I can't figure out how to fix it.
Any idea?

https://github.com/GitbookIO/gitbook-cli/issues/11

I can install the plugin with: npm i gitbook-plugin-swagger but then, gitbook build fails with the following error:
Loading bootprint-swagger 0.13.1
Loading bootprint-json-schema 0.8.6
Loading bootprint-base 0.8.0
error: error while generating page "api/README.md":

Error: Engine 'uglify' not found. Refusing to store configuration

Are you able to install other plugins just fine? This plugin really isn't fully baked and needs more work, but curious if its isolated or not.

Same problem here. And i'm indeed able to install other plugins.

I can't devote much time to this right now, but am happy to accept PRs!

@GuGuss I made a separate issue #2 and put in a PR #3 for it (believe it's a separate issue from the original one filed here

Is this resolved by #3?

Yes it is ! Only dependencies problems.

Great thanks!


cgroups: systemd: set DefaultDependencies=false if possible

The root problem this fixes is the docker daemon uses DefaulDependencies
for all of its scopes which means that the containers get killed by
systemd before the docker daemon is notified to shutdown. This means
that a docker run in a service file won't get ordered properly on
shutdown! This has affected many CoreOS users and is documented in
systemd as so:
"Unless DefaultDependencies=false is used, scope units will implicitly
have dependencies of type Conflicts= and Before= on shutdown.target."
Unfortunately, systemd didn't allow setting DefaultDependencies=false on
transient units until today:
systemd-run --scope --property="DefaultDependencies=false" /usr/bin/sleep 50000
Unknown assignment DefaultDependencies=false.
Failed to create message: Invalid argument

Fixed here:
http://cgit.freedesktop.org/systemd/systemd/commit/?id=261420ba2a20305ad271b6f5f380aa74c5c9dd50
Discussion with systemd upstream:
http://lists.freedesktop.org/archives/systemd-devel/2014-December/026313.html
http://lists.freedesktop.org/archives/systemd-devel/2015-February/027890.html
Tested with docker and systemd master as of today and it work for me.
Signed-off-by: Brandon Philips<EMAIL_ADDRESS>

One question, does this depend on a specific version of systemd?

@crosbymichael It shouldn't depend on a particular version of systemd. The code in there should fall back to the old behavior of not setting DefaultDependencies if the version of systemd that is running doesn't support that.

@crosbymichael I can make this patch much shorter by making libcontainer depend on systemd master :-P

heh

On Feb 4, 2015, at 11:41 AM, Brandon Philips<EMAIL_ADDRESS>wrote:
@crosbymichael https://github.com/crosbymichael I can make this patch much shorter by making libcontainer depend on systemd master :-P
—
Reply to this email directly or view it on GitHub https://github.com/docker/libcontainer/pull/359#issuecomment-72923604.

LGTM

I will test this out on Fedora.

LGTM


Making rubocop happier

@fsmanuel Would you mind reviewing it?

Can you add a travis.yml that runs rubocop?
Something like that should work:
language: ruby
cache: bundler

sudo: false
rvm:
  - 2.2.0
install: bundle install
script:
#  - bundle exec rspec
  - bundle exec rubocop

I gave you push access. The thing is that rubocop is not green yet. But I don't have a project to test bender with at the moment, so I feel uncomfortable doing too heavy refactoring.
I suggest you add it to travis but disable the cops for those 4 remaining problems. Or refactor it and test it out.

By the way, we should try capistrano 3.5.0 because the changes are pretty small compared to 3.4..
And I think airbrush is pretty neat. That way we could skip all the logging monkey patching alltogether!


team  SP0314

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

we are team SP0314 with very incredible team members . we have working on a project of web development (frontend) with the help of our mentor .....SHIVAM BOSS
our team member are

NISHANT MEENA
SAKSHI
3.PANKAJ JANGIR
4.KRITIKA

team SP0314


Question: Is RequestServiceTicket.CanCacheTickets condition too restrictive ?

in this PR https://github.com/dotnet/Kerberos.NET/pull/249 CanCacheTickets property was introduced in order to fix issue https://github.com/dotnet/Kerberos.NET/issues/248
        public bool CanCacheTicket => this.CacheTicket ?? true &&
                                      string.IsNullOrWhiteSpace(this.S4uTarget) && // is this line needed ?
                                      this.S4uTicket == null &&
                                      this.S4uTargetCertificate == null;

But when we pass string s4u to GetServiceTicket - it looks like tickets can be cached - because s4u goes to Container string parameter in TicketCacheEntry and allows to correctly identify record in cache.
It will not break the test case described in https://github.com/dotnet/Kerberos.NET/issues/248
In our case we are calling http service from backend service on behalf of the user in many parallel threads - every call to GetServiceTicket(..., s4u: username) goes to KDC (because ticket for user is not cached) and we running out of SocketPool in case of many threads (even if TcpKerberosTransport.MaxPoolSize increased).
We have workarounds on this: locking call to GetServiceTicket or using SemaphoreSlim(TcpKerberosTransport.MaxPoolSize,TcpKerberosTransport.MaxPoolSize) before it ... but it looks too rude

Ish. It's more designed to prevent polluting caches that don't understand S4U which would be very bad security-wise. Making that work requires reworking the cache system a bit.

From: sqladmin-zz @.>
Sent: Thursday, November 7, 2024 8:13:42 PM
To: dotnet/Kerberos.NET @.>
Cc: Subscribed @.***>
Subject: [dotnet/Kerberos.NET] Question: Is RequestServiceTicket.CanCacheTickets condition too restrictive ? (Issue #383)
in this PR #249https://github.com/dotnet/Kerberos.NET/pull/249 CanCacheTickets property was introduced in order to fix issue #248https://github.com/dotnet/Kerberos.NET/issues/248
    public bool CanCacheTicket => this.CacheTicket ?? true &&
                                  string.IsNullOrWhiteSpace(this.S4uTarget) && // is this line needed ?
                                  this.S4uTicket == null &&
                                  this.S4uTargetCertificate == null;

But when we pass string s4u to GetServiceTicket - it looks like tickets can be cached - because s4u goes to Container string parameter in TicketCacheEntry and allows to correctly identify record in cache.
It will not break the test case described in #248https://github.com/dotnet/Kerberos.NET/issues/248
In our case we are calling http service from backend service on behalf of the user in many parallel threads - every call to GetServiceTicket(..., s4u: username) goes to KDC (because ticket for user is not cached) and we running out of SocketPool in case of many threads (even if TcpKerberosTransport.MaxPoolSize increased).
We have workarounds on this: locking call to GetServiceTicket or using SemaphoreSlim(TcpKerberosTransport.MaxPoolSize,TcpKerberosTransport.MaxPoolSize) before it ... but it looks too rude
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/Kerberos.NET/issues/383 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAJHTYJNRTYTXWLJGU6J4KTZ7Q27PBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTLDTOVRGUZLDORPXI6LQMWSUS43TOVS2M5DPOBUWG44SQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKBYGU2DQOJRGM4IFJDUPFYGLJLJONZXKZNFOZQWY5LFVIZDMNBSG44TANBSG6TXI4TJM5TWK4VGMNZGKYLUMU.
You are receiving this email because you are subscribed to this thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Send coverage report to Codecov

This adds a step to send the coverage report to Codecov.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2325cdb). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #7   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         7
  Lines           ?       215
  Branches        ?        44
========================================
  Hits            ?       215
  Misses          ?         0
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2325cdb...12c0bb8. Read the comment docs.


Feat:Navbar design

Is there an existing issue raised for this?

[X] I have searched the existing issues

Describe the feature
improve navbar design
Add ScreenShots

Component
/navbar
It should be implemented because
I use css implement
Would you like to work on this issue?
None
Terms & Conditions

[X] I agree to follow the Code of Conduct
[X] I'm a GSSOC'24 Ext contributor

Similar issue is already assigned to someone else


added a random custom delay before deployment

sample ".deployment" file configuration should look like this
[config]
SCM_MAX_RANDOM_START_DELAY_IN_SECONDS = 40

sample trace file should look like this
<step title="custom max delay is set to 40s" date="2016-08-22T19:07:00.512" />
<!-- duration: 0ms -->
<step title="deployment deplay applied, Start sleeping for 29s" date="2016-08-22T19:07:00.512" />
<!-- duration: 29022ms -->

Hi @watashiSHUN, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@watashiSHUN, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

For test coverage, you can easily modify the DeploymentApis test. After the RunAsync call, add a line like this:
await appManager.SettingsManager.SetValue(SettingsKeys.MaxRandomDelayInSec, "10");

And in the KuduAssert.VerifyUrl(result.LogUrl, cred); line, add an extra param with the string to check for.

:shipit:

:shipit:

@watashiSHUN shall we close this PR or you are still working on it? I saw fix has already been merged into master. Same for https://github.com/projectkudu/kudu/pull/2113

@watashiSHUN can this one be closed now?


Add support for transmitting and receiving GPS location over LoRa

This uses https://github.com/tock/tock/pull/3881 to read a NMEA location and transmit it over LoRa

Ping!


Feature flags to make lsp and readline support optional

This diff moves support for readline (used by the breakpoint console)
and the LSP server behind a cargo feature.  Readline is enabled in the
lib by default to preserve debugging when embedding, while lsp is only
enabled when building the starlark binary.
The motivation is to support a wasm32-unknown-unknown build of
starlark.

It would be better just unconditionally not add the dependencies on these crates. Something  like [dependencies.cfg(not(wasm))].
Or move LSP/readline implementations into a separate crate.
The issue with feature flags, is it that it is not enough to just add them, also CI need to be set up, and all permutations properly tested.
Also, to make starlark-rust work on wasm, much more is needed than removal of these two dependencies.

I'm also not aware of a way to make a [[bin]] conditional on platform.

Bin could still exist, but work without readline on wasm.
Anyway, the larger issues with wasm are:

making it work. Just removing dependencies won't be enough for wasm. Maybe we should postpone it until we have at least proof of concept working wasm. Like interpreter running hello world on wasm.
CI. If we have an implementation for wasm, we need to make sure it won't regress. Is it possible to somehow run cargo test -p starlark --some-flag-to-make-it-run-on-wasm?

bin could still exist

You mean the repl without lsp?

Anyway, the larger issues with wasm are:

I don't have it working, but am hopefully far enough down the path to have a sense of what the issues are.  I have a solution for rust-ctor (though not it's landable).  Not sure about 32-bit tagged pointers, will try either using a u64 instead of usize on all platforms and just wasting a few bytes for 32-bit clients, or requiring a custom allocator (pretty common on wasm) that can promise an extra free high bit.

Maybe we should postpone it until we have at least proof of concept working wasm.

Makes sense.

Is it possible to somehow run cargo test -p starlark --some-flag-to-make-it-run-on-wasm

I've not tried it but believe this is possible.

Not sure about 32-bit tagged pointers

Currently we only need third bit to mark the pointer is string, which is for optimization, because string are the most common types.
We can disable string optimization when working in 32-bit setup.


Adding a cuboid object to a datapoint requires extra information

When using the put_tasks SDK method to update an existing task, we want to add a cuboid to a series. We supply the following information:
{
    point1: {i: 34, j: 42, k: 8},
    point2: {i: 38, j: 40, k: 7},
    category: "object_type_1",
    attributes: {},
}

Expectation: the task is updated with a new cuboid object.
Actual: the API throws the following error:
Error: 'absolutePoint1' is a required property at 0->series->0->cuboids->0
Docs: https://docs.redbrickai.com/python-sdk/format-reference

I understand that exported cuboids should have absolute points, but I am not quite sure why they are required on import. In fact, it seems that the provided values in absolute points do not affect how the cuboid renders in the interface once uploaded, so it seems like the server is overwriting these anyway.

Thanks @anaoum for submitting the issue. We have triaged it accordingly and will let you know once the fix is released.

This has been fixed with<EMAIL_ADDRESS>(with<EMAIL_ADDRESS>


test: translate blocks in block

Test translating blocks in block
Example:
while (j < 5) {
  System.out.println(j);
  if (j==2) {
    System.out.println("j has the value 2");
    a = 5;
  }
  if (j==3) {
    System.out.println("j has the value 3");
  }
  j = j + 1;
}

Essentially works, but the precision detection is somehow broken


fix: update svelte to 5.0.0-next.181 and fix for {:else if}

This PR updates the svelte version and fixes the wrong location and token of {:else if} nodes when using the updated svelte.
Also, since Svelte no longer provides types for AST nodes, I have added code to work around that.

Oh I think you made a commit for this to main branch.

Oh, sorry. I made a mistake once and thought I had put it back, but it seems I made another mistake 😓

I reverted the main branch and rebased this PR 😅


Should we process papers if only supplemental material is extracted but not the main paper?

For some papers, pdf to text conversion failed for the main paper but went through for supplemental material. We are currently processing these papers, maybe hoping that the supplemental material mentions most of the entities involved in the study, but this can lead to extraction issues and missed entities. This is for example what happened with #136. Should we exclude papers when the main text is not converted @draciti @vanaukenk ?

I vote for excluding. What do you think @vanaukenk

I agree with @draciti
If we don't have the main paper, we should not process just the supplemental for AFP.

keep track of bibliographic information for these papers and exclude them


[Documentation Bug]:  Empty readme file

Describe the bug ✍
Describe your bug here, there is no tutorial or overview of the work .
Provide step by step information reproduce the bug 📄

[ ] Descriptions
[ ] Introduction
[ ] Tutorial
[ ] Scoring
[ ] restart
[ ] Clue / hint
[ ] Play again

Select program in which you are contributing
No response
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @msifran , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#3313

Hey @msifran !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign


Update google-api-python-client and dev dependencies

Update google-api-python-client to fix conflicting dependency.
Tests failing with
pkg_resources.ContextualVersionConflict: (rsa 4.1 (/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages), Requirement.parse('rsa<4.1,>=3.1.4'), {'google-auth'})

Fix some other non-breaking conflicts in the dev dependencies.

Codecov Report

Merging #1880 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1880   +/-   ##
=======================================
  Coverage   99.96%   99.96%
=======================================
  Files          40       40
  Lines        2852     2852
  Branches      138      138
=======================================
  Hits         2851     2851
  Misses          1        1

Impacted Files
Coverage Δ

src/dcos_e2e/_wait_for_dcos.py
100.00% <ø> (ø)

src/dcos_e2e/backends/_aws/__init__.py
100.00% <ø> (ø)

src/dcos_e2e/backends/_docker/__init__.py
100.00% <ø> (ø)

src/dcos_e2e/backends/_docker/_containers.py
100.00% <ø> (ø)

tests/test_cli/test_dcos_docker/test_cli.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5670408...0021c10. Read the comment docs.

❤


Enhancement: Add OWASP Dependency Track Findings Importer

Scanner Name
OWASP Dependency Track
Scanner Description
Dependency Track is an intelligent Software Supply Chain Component Analysis platform that allows organizations to identify and reduce risk from the use of third-party and open source components. Dependency Track takes a unique and highly beneficial approach by leveraging the capabilities of Software Bill-of-Materials (SBoM) which provides capabilities that traditional Software Composition Analysis (SCA) solutions cannot achieve.
Scanner Link
https://dependencytrack.org/
Sample File
Note: The information in this section has been copied from https://docs.dependencytrack.org/integrations/file-formats/ for purposes of documenting this enhancement in a complete manner and in case the Dependency Track documentation changes
Dependency Track has an API-first design. API’s are simply at the heart of the platform. However, there are occasions when a file-based format is desired for integration with other systems, especially legacy systems or systems that are not API-aware or compatible.
Dependency Track has a native format that can be used to share findings with other systems. The findings contain identical information as presented while auditing, but also include information about the project and the system that created the file. The file type is called Finding Packaging Format (FPF).
FPF’s are json files and have the following sections:

Name
Type
Description

version
string
The Finding Packaging Format document version

meta
object
Describes the Dependency-Track instance that created the file

project
object
The project the findings are associated with

findings
array
An array of zero or more findings

An example FPF file looks like this:
{
  "version": "1.0",
  "meta" : {
    "application": "Dependency-Track",
    "version": "3.4.0",
    "timestamp": "2018-11-18T23:31:42Z",
    "baseUrl": "http://dtrack.example.org"
  },
  "project" : {
    "uuid": "ca4f2da9-0fad-4a13-92d7-f627f3168a56",
    "name": "Acme Example",
    "version": "1.0",
    "description": "A sample application"
  },
  "findings" : [
  {
    "component": {
      "uuid": "b815b581-fec1-4374-a871-68862a8f8d52",
      "name": "timespan",
      "version": "2.3.0",
      "purl"<EMAIL_ADDRESS>    },
    "vulnerability": {
      "uuid": "115b80bb-46c4-41d1-9f10-8a175d4abb46",
      "source": "NPM",
      "vulnId": "533",
      "title": "Regular Expression Denial of Service",
      "subtitle": "timespan",
      "severity": "LOW",
      "severityRank": 3,
      "cweId": 400,
      "cweName": "Uncontrolled Resource Consumption ('Resource Exhaustion')",
      "description": "Affected versions of `timespan`...",
      "recommendation": "No direct patch is available..."
    },
    "analysis": {
      "state": "NOT_SET",
      "isSuppressed": false
    },
    "matrix": "ca4f2da9-0fad-4a13-92d7-f627f3168a56:b815b581-fec1-4374-a871-68862a8f8d52:115b80bb-46c4-41d1-9f10-8a175d4abb46"
  },
  {
    "component": {
      "uuid": "979f87f5-eaf5-4095-9d38-cde17bf9228e",
      "name": "uglify-js",
      "version": "2.4.24",
      "purl"<EMAIL_ADDRESS>    },
    "vulnerability": {
      "uuid": "701a3953-666b-4b7a-96ca-e1e6a3e1def3",
      "source": "NPM",
      "vulnId": "48",
      "title": "Regular Expression Denial of Service",
      "subtitle": "uglify-js",
      "severity": "LOW",
      "severityRank": 3,
      "cweId": 400,
      "cweName": "Uncontrolled Resource Consumption ('Resource Exhaustion')",
      "description": "Versions of `uglify-js` prior to...",
      "recommendation": "Update to version 2.6.0 or later."
    },
    "analysis": {
      "isSuppressed": false
    },
    "matrix": "ca4f2da9-0fad-4a13-92d7-f627f3168a56:979f87f5-eaf5-4095-9d38-cde17bf9228e:701a3953-666b-4b7a-96ca-e1e6a3e1def3"
  }]
}

References
https://github.com/DependencyTrack/dependency-track/issues/410

I am working on this and should have a PR prepped shortly


log times are not right

There is no adjustments for different timezones. Core outputs logs with a different time from mine.
My time is now: 13:14 (GMT+3 Istanbul).
✔ Core started
time="2018-10-23T10:14:47Z" level=info msg="deploying (2) system services..."

The time is good :) it is just the ISO representation.
We don't want to manage timezone, that's really complicated to manage and really confusing for the users too. On your computer it's fine but what happen when you put it on a server which might not be in the same location. Kind of hard to know the timezone of the server and you have to convert the time anyway so better to always do it from UTC.

@antho1404 I'll accept this answer when there is a nice UI that parses these json log messages and shows in the proper timezone of user's.
But in case of users doesn't use such tool like that, I think we can have a flag like --adjust-timezone to adjust timezone optionally for the logs. Because seeing logs with a different timezone from my computer doesn't make much sense.

Timezones are really complex and difficult to manage. I'm also not in favor or manage it as every log collector has already built in an option to manage times (also every software I know of, sends ts in UTC to unify timezone across zones).
Closing it for now.


comment addition, for group_vars/all.yml.sample.

I was almost going to settle for bare http, but then I noticed that the code does actually autogenerate certs.
It would be helpful if you mentioned this explicitly in the comments, because they currently
sort of imply the opposite.

--- group_vars/all.yml.sample.git	2019-12-06 17:46:13.265694191 -0800
+++ group_vars/all.yml.sample	2019-12-06 17:47:42.128814075 -0800
@@ -705,6 +705,8 @@
 #dashboard_enabled: True
 # Choose http or https
 # For https, you should set dashboard.crt/key and grafana.crt/key
+# If you define the dashboard_crt and dashboard_key variables, but leave them as '',
+# then we will autogenerate a cert and keyfile
 #dashboard_protocol: http
 #dashboard_port: 8443
 #dashboard_admin_user: admin

@ppbrown Do you mind sending a PR for that?
Thanks!

done


WIP: implement sparse matrices for linear_regression_raw

Closes #2377 and addresses half of #2331
Q: I'd like to use find_outliers here. However, I get a circular import if I import it in mne.stats.regression. Can I move find_outliers to mne.utils? @dengemann

Travis not happy. Besides looks clean.
Is it faster on your data? How much?

If I'm reading this correctly, average memory usage is down by a lot while speed is perhaps a bit improved.

finally works on my laptop ;)

can you just profile to know where time is spent?

did you test this implementation on your personal datasets?

Ran both versions on 12 subjects.
Original version:
ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    12   86.727    7.227  636.132   53.011 regression.py:143(linear_regression_raw)

Sparse version:
ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    12    4.319    0.360  264.253   22.021 regression.py:143(linear_regression_raw)

A huge decrease in time!

Get the same result ? If so let's merge

I haven't managed to set up the profiler myself, but that's some impressive numbers. Subjectively, I see decent improvements too. So merge.


mj social with automatic mode vertical and horizontal

i have an issues about vertical and horizontal when open in mobile view
here the example
https://mjml.io/try-it-live/pI-AcXW5Yu
please help me

Can you add more info about your issue please ?

when open email in mobile device expected like this

and when open in desktop view expected this

https://mjml.io/try-it-live/avQi-mDW-6 Something like this should work.
If you want the first social to behave as expected split it into 2 columns and use mj-text for img + text and you should be fine


Odd vertical spaces in markdown comments

Question
Response

Version?
v1.4.1

Devices tested?
iPhone 7

What Currently Happens?
Markdown comments contains weird vertical spacings:

What Do You Expect To Happen?
Not that much spaces! It seems like Github introduced extra spaces in their HTML transformation.
My Reproduction Steps
Check this PR: https://github.com/theliturgists/app/pull/45

Just got merged in :)
THANK YOU FAM


Workflow refactoring

Q
A

Branch?
master

Bug fix?
no

New feature?
yes

BC breaks?
yes

Deprecations?
yes

Tests pass?
yes

Fixed tickets
https://github.com/phpmentors-jp/workflower/issues/79, https://github.com/phpmentors-jp/workflower/issues/80

License
BSD-2-Clause

New features included in this PR:

UserTask
ManualTask
parallel and sequential work items in tasks
InclusiveGateway
TerminateEndEvent
bpmn reader class can import above mentioned elements

Prepared the basics for implementing SubProcess Task and CallActivity Task.

@iteman Please review this PR. Next step would be to implement SubProcess and CallActivity tasks.

Great work! I will review this weekend.
Thank you.

@iteman I sent you an email last week. Don't know if you received it or not.

@ateodorescu I received it. I'll reply over the weekend.

@iteman I have pushed the SubProcess and CallActivity tasks in this PR. There are massive changes in this PR which break any compatibility with the older versions.

@iteman From my point of view this PR could be merged. I won't push any other commits to it. WorkflowBuilder class could be removed since it's not needed anymore but I'll leave that to you to decide.

Review and merge process started...

@iteman any feedback on this PR? Still reviewing?

@iteman any feedback on this PR? Still reviewing?

I'm working on the review, but it will be slow as I don't have much time right now.
Thanks.

Ok. Take your time! No worries!

@ateodorescu Thank you for your contribution! 😄


graphical iso: xorg fails to start in virtualbox with "screens found but none have a usable configuration"

The solution seems to be some subset of the override here: https://github.com/matthewbauer/nixpkgs/blob/6de20a7fe4d076cadea078b77cd2bc3d52e409aa/nixos/modules/installer/virtualbox-demo.nix#L21 .

Unsurprisingly, it seems to be the "virtualbox" driver.

Perhaps we should just move that from virtualbox-demo.nix to virtualbox-image.nix? There's not a clear differentiation between the two. I would recommend just using the pre-built .ova files, which use virtualbox-demo.nix.

Maybe I'm just being idiosyncratic (given that the images are listed on the downloads page) but I would like it if the livecd worked.


CI and Suhosin incompatibility

If php.ini contains suhosin.cookie.encrypt = On then CSRF will fail.  There are two ways to resolve this.  Either comment that line out (unsafe) or add the line suhosin.cookie.plainlist = [insert config.php cookie name here] (safe)
This should be added to a FAQ, wiki or troubleshooting guide as anyone with suhosin running is liable to run into this and suhosin.simulation = On does not make the problem go away and suhosin doesn't log it because it's not technically suhosin blocking anything which makes the problem difficult to track down.

Given Suhosin's status, this is not an issue for us.
Also, this is false speculation:

Either comment that line out (unsafe) or add the line suhosin.cookie.plainlist = [insert config.php cookie name here] (safe)

While encrypting a cookie can improve security, that is what is called "hardening", which is mostly what Suhosin is about - making a strong system even stronger, generally speaking. Lack of hardening does not mean a system is unsafe.
And more importantly, if you actually need your cookies to be encrypted, that alone would be the real problem. Data needs to be encrypted if it is a secret, and it is a major flaw to store secret data in cookies.

@narfbg You misunderstand what I mean by safe or unsafe.  Safe meaning that other cookies still get encrypted and you just whitelist the one(s) you don't want encrypted.  Unsafe is meant to indicate that it will resolve the problem but if you were relying on encrypted cookies, you won't get them.  I did not intend to imply that the system is no longer secure.
I think you are also making an assumption about encrypting cookies that is a non-sequitur. Yes, I agree that it is bad practice to store secret data in cookies, however encrypting cookies isn't therefore a moot point.  Encrypting them reduces the footprint of just one more attack vector.
I'm not suggesting changing the implementation of CI to accomodate this, but merely suggesting that you post the incompatibility somewhere so that anyone else with this suhosin directive will know to disable it.  Whether the project is dead or not, is not relevant as people still use it in CI supported PHP versions (i.e., PHP 5.6 for CI 3.1.5), so others are potentially going to run into it.

Unsafe is meant to indicate that it will resolve the problem but if you were relying on encrypted cookies, you won't get them. I did not intend to imply that the system is no longer secure.

Every library, framework, etc. comes with a set of assumptions and trade-offs. This is one of the cases where you will find unanimous agreement that you shouldn't ever rely on such a thing.

I think you are also making an assumption about encrypting cookies that is a non-sequitur. Yes, I agree that it is bad practice to store secret data in cookies, however encrypting cookies isn't therefore a moot point. Encrypting them reduces the footprint of just one more attack vector.

A non-sequitur is an erroneous argument. If you agree with my argument, then it is by definition not a non-sequitur.
But even further on that - I'm not saying storing secret data in cookies is merely a bad practice. There are a lot of "bad" practices, that when applied to valid use cases, are quite good. We call them "bad practices" because they are commonly used for the wrong purpose and/or lead to bigger problems.
What I'm saying here is that storing secret data in cookies is inherently bad, no matter what. It is insecure when not encrypted, but also otherwise problematic even when encrypted (e.g. concurrency issues with server-less sessions we had in CI2). I will tell you what is wrong with literally every use case you can come up with.

I'm not suggesting changing the implementation of CI to accomodate this, but merely suggesting that you post the incompatibility somewhere so that anyone else with this suhosin directive will know to disable it.

Fair enough.
However, we don't have a specific place for this. And to be honest, an esoteric issue with a dead third-party project is the last thing I'd care to put on a FAQ. :)
There is a Wiki we have here on GitHub, but while I do delete junk from it when I see it, it is otherwise exclusively user-maintained and you are more than welcome to edit it.
Otherwise, annoying that I have to deal with this on a bug tracker, and I ask you not to do that in the future, but you have achieved what you wanted - anybody googling for the problem will find this very discussion. We do also have a forum board, which has historically always been where CI users go in search of solutions.

Whether  the project is dead or not, is not relevant as people still use it in  CI supported PHP versions (i.e., PHP 5.6 for CI 3.1.5), so others are  potentially going to run into it.

Disagree. Conscious efforts to maintain compatibility with defunct projects only slow down progress, and is one of the major reasons why CI lost enormous amounts of popularity.
At least when we did that, we did it because older PHP versions still had the majority market share. That is not the case with Suhosin. :)

@narfbg non-sequitur is Latin and it means does not follow. it's used to indicate when your answer does not follow from your argument. I was never trying to argue that one should store secret data in cookies and you seemed to have missed that point. There is nothing wrong with encrypting non-secret data in cookies... especially if an attacker wastes a bunch of time trying to crack it. nonetheless, it sounds like this conversation has run its course so I will leave it at that.


Update tesseract library

From tesserwrap. Probably: https://github.com/sirfz/tesserocr - seems to have the most features of the several out there.

Done.


Goss reporting randomly error: Client.Timeout exceeded

Hi
I am having error related with timeout (this can be caused by our network - not sure). However what is strage is that I see following error quite frequently:
net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

This is really random. Goss is running under docker (Alpine Linux).
I tried increase timeout configuration up to 5 secs in goss.yaml - however this is not helping at all.
dns:
  "hostname.local":
    resolvable: true
    timeout: 5000
    addrs:
      - <IP_ADDRESS>

However when running goss - is not waiting for 5secs - only report error almost imidietly.
GOSS CRITICAL - Count: 14, Failed: 2, Skipped: 2, Duration: 2.005s   # <--- Not 5 secs
Any idea how to track whether goss is using provided timeout?
Is there any way to debug what goss is doing and what is real time out / error / etc?

Sorry for the late response. Is this reproducible with the latest version of goss?
Also, it seems the timeout is only used when server is provided. I've updated the documentation to clarify this.
https://github.com/aelsabbahy/goss/blob/master/docs/manual.md#dns
If it is reproducible with the latest version of goss. Do you know of a way to consistently reproduce this?


Refactoring quantecon-book-theme

We are moving from setup.py to pyprojet.toml. Also having sphinx-theme-builder as the build system.

Thanks @AakashGfude - It looks like this is building nicely and a good refactor of the code to bring it inline with EBP themes.

@AakashGfude does this incorporate any updates to search or dark theme etc?

Thanks @mmcky for checking this, I will verify the dark theme. I did get some changes in search locally, but in CI it seems to be the same unfortunately, which is quite puzzling. I will target it in another PR?
I have time tomorrow. So, I will update the README, and verify the dark theme, work a bit on search.

@mmcky, this PR should be mergeable now.

thanks @AakashGfude -- exciting.

@AakashGfude I have been testing this against lecture-python-intro and it is looking good. No visual differences that I can see with the current site 👍
For some embedded objects like sphinx-exercise there is a missing icon it seems. Is that theme related or sphinx-exercise issue?

@mmcky thanks for testing it. Looks like a font awesome issue. I will have a look

@mmcky it seems like the issue is also there in the current website: https://intro.quantecon.org/inequality.html

@mmcky I have made a change in CSS here, using pydata's icon set.

Given that the icon is still working in ebp documentation https://ebp-sphinx-exercise.readthedocs.io/en/latest/syntax.html . And most probably a version issue of fontawesome, I thought of correcting it in our theme, which is inheriting from pydata and using a newer fontawesome version.

thanks @AakashGfude are you happy for me to merge this?

Once this is merged would you be able to put a release PR together?
I think a major release number 0.6.0 would be good.

Thanks @mmcky for reviewing this. Will cut a release.


Nullpointerexception using cloudwatch collector

Hello,
I have been trying to run cloudwatch collector, when i try running the collector jar it gives me the following:
2019-09-26 15:41:41,705 [main] WARN  o.s.c.a.AnnotationConfigApplicationContext - Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'awsCloudwatchLogAnalyzerTask': Invocation of init method failed; nested exception is java.lang.NullPointerException
Any ideas?

This usually happens when the collector can't find the properties file. Please check the command you are using to run and make sure the path to properties file is correct.


Using the [DEL] key to delete one character within an annotation's comment causes the whole annotation to be deleted.

Tested in 3 different browsers (Safari / Firefox / Chrome)
When typing or editing an annotation's comment (be it an already existing annotation or a new one just being created), pressing the DEL key on the keyboard deletes the whole annotation instead of just deleting one character in the annotation's comment.
This is VERY annoying bug, considering that there's currently no way to undo the deletion of an annotation.

In the meantime, I found a proper work-around to disable the DEL key on Annonatate:

Install Shortkeys (Custom Keyboard Shortcuts) extension for Firefox or Google Chrome.
Configure it as follows:

(caveat: the "do nothing" option doesn't work, you have to choose some action that steals the focus from the webpage)
Close and reopen Annonatate, and voilà!

@Pigeo if you could please attach a screen recording of this along with information about why kind of machine and keyboard you are using. I have not been able to replicate this issue.
@rsimon

Here is the screen recording (available for download until 21th August).
Obviously, you need to use an USB keyboard from a desktop computer in order to have the DEL key on it (otherwise, most laptop keyboards don't have a DEL key, but sometimes you can simulate it by pressing a combination such as Fn + Backspace).
FYI, I also tried on a completely different machine (Firefox running on Windows 10 PC), and the issue is exactly the same, so I don't think it depends on the machine/keyboard you are using (as long as you have a keyboard with the DEL key on it, of course).


Throwing away errors

It would be nice to be able to pattern match on errors/ok, but it is not possible due to the error/ok atom being thrown away.
Example:
https://github.com/werbitzky/elastix/blob/master/lib/elastix/document.ex#L76
Wouldn't it be nicer to use the {:ok, res}  and {:error, reason}. Or is there any other reason why this is being stripped away?

Yes, you are right – this is not a good convention. Feel free to open a PR or I will change it for the next version.

Let me know what you think about that PR :clinking_glasses:


Adjust notes in benchmark output

Per request of @jak-pan in https://github.com/galacticcouncil/HydraDX-docs/pull/36
If we want 0% or better, shall we also set DIFF_MARGIN=0? https://github.com/galacticcouncil/bench-wizard/blob/main/bench_wizard/benchmark.py#L14
cc @enthusiastmartin

There is 10% margin. I'd maybe be ok with going only 5% but let's keep it 5% the wording however didn't make sense since it's better if you are more than 0 and worse if you were less than 0 not + or -10%

thanks guys 👍


"Reload the played scene" (F6) is launching the currently focused tab, not reloading the previously selected scene

Tested versions
Reproducible in 4.2.1 Stable
Not Reproducible in 4.0.4
System information
Godot v4.2.1.stable - Windows 10
Issue description
I recently upgraded from 4.0.4 to 4.2.1 and suddenly the reload button is launching the currently focused scene tab instead of the scene previously selected to run.
This behavior is different than before when it would reload the previously selected scene.
It is important for this button to work correctly so I can deliberately test a (not main) scene while using the editor tabs to update and fix other scenes that are part of it.
For example, the main scene of my project is a "Menu" scene but I am developing an "Arena" scene with a "Character" and a new "Obstacle".
I select the Arena and press the "Run Current Scene (F6)" button so I can test the interaction between the Character and the Obstacle
I then use the editor tabs to inspect and make changes to the child scenes.
Previously I would then press the "Reload the Played Scene" button to re-launch the Arena and test my updates, but instead it will launch the currently focused tab, be it the Character or Obstacle, which is not helpful for testing interaction.
Is there a setting somewhere that I've overlooked? Thanks
Steps to reproduce
Pick a scene, launch it.
Switch a tab.
Try to relaunch the scene you picked.
Notice that it launches the currently focused tab instead.
Minimal reproduction project (MRP)

I've identified the cause of this bug, will write a fix

I pulled your fix and applied it to the 4.2.1-stable branch, built it, and it works like a charm. Thank you so much for knowing right where to look! Looking forward to seeing your fix merged for future releases.

This hasn't been fixed yet so please leave it open until merge


VNet Integration for multi-container apps

Will it ever be possible to use VNet Integration with multi-container apps?
Are there plans to improve the multi-container support in app services? There hasn't been lot of news in these area, one can get the impression it is a bit left-behind.
This would be greatly useful in most hybrid-app use cases, together with the easy way to deploy docker-compose applications,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077513b8-750f-13f3-b973-36a7b53b8562
Version Independent ID: baf5fae6-c52e-b8ef-cd04-2b1b462643bb
Content: Integrate your app with an Azure virtual network - Azure App Service
Content Source: articles/app-service/overview-vnet-integration.md
Service: app-service
GitHub Login: @madsd
Microsoft Alias: madsd

Thank you for reaching out. At this time we are reviewing the ask and will provide an update as appropriate

@anrub Thanks again for asking question! Our product engineering team is actively working on but we do not have an ETA to share at this moment.


Parsing for the "alt return " character. ?

I have this in a cell:
"
We need this to store valuable building materials, so do this first.
Demolish internal rear wall
and check depth of garage. Hopefully is deep enough and door openings are wide enough.
Remove middle wall
Laminate existing main roof timbers
Demolish wall
"
This is written using the ALT return to make a carriage return within the cell.
Anyone know how to parse this ?

Reference issue #69, this lib not support set multiline texts for a cell currently.

@xuri
I got it working myself:
if cellValue != "" {

				// Split on carriage return.
				cellSplitArray := strings.Split(cellValue, "\n")
				cellSplitNewArray := cellSplitArray

				// Loop
				for i := range cellSplitArray {
					//log.Print(fmt.Sprintf("split index (%v) Value %s ", i, cellSplitArray[i]))

					//newValue := fmt.Sprintf("%s_%s", cellSplitArray[i], "_changed")

					newValue, err := lang.Translate(cellSplitArray[i], langID)
					if err != nil {
						return err
					}

					cellSplitNewArray[i] = newValue

				}

				// rejoin array
				newValue := strings.Join(cellSplitNewArray, "\n")

				s.SetCellValue(sheetName, cellAxis, newValue)


Trigger listItem events only when mounted

Automated PR Comment From BlackDuck

:x: Found dependencies violating policy!

Policies Violated
Dependency
License(s)
Vulnerabilities
Short Term Recommended Upgrade
Long Term Recommended Upgrade
Resolved / Filtered Out

Outdated Libraries should be updated
@types/react
N/A

18.2.60 (0 known vulnerabilities)
18.2.60 (0 known vulnerabilities)
:grey_exclamation:

Outdated Libraries should be updated
@storybook/addon-docs
N/A

7.6.17 (0 known vulnerabilities)
7.6.17 (0 known vulnerabilities)
:grey_exclamation:

Outdated Libraries should be updated
@storybook/addon-essentials
N/A

7.6.17 (0 known vulnerabilities)
7.6.17 (0 known vulnerabilities)
:grey_exclamation:

Outdated Libraries should be updated
ESLint
N/A

8.57.0 (0 known vulnerabilities)
8.57.0 (0 known vulnerabilities)
:grey_exclamation:

Outdated Libraries should be updated
@storybook/blocks
N/A

7.6.17 (0 known vulnerabilities)
7.6.17 (0 known vulnerabilities)
:grey_exclamation:

Outdated Libraries should be updated
storybook
N/A

7.6.17 (0 known vulnerabilities)
7.6.17 (0 known vulnerabilities)
:grey_exclamation:

Outdated Libraries should be updated
storybook
N/A

7.6.17 (0 known vulnerabilities)
7.6.17 (0 known vulnerabilities)
:grey_exclamation:


"Please reduce your request rate" when using withSequence.count: 600 * 5GB saved to S3

I am using v3.3.8
I am using withSequence.count: 600. Each pod does some processing and then tries to save about 5GB to S3 (at roughly the same time).
About 30.5% of the 600 pods fail to complete. The wait container responds with the error message level=fatal msg="timed out waiting for the condition: failed to put directory: Please reduce your request rate."
The wait container does not seem to retry and instead just hangs indefinitely.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@mm-fsai Can you provide the wait container logs?

This means that the wait container has tried multiple times to put your artifact and subsequently given up. Maybe use the paralellism feature?


Rules reporting missing hints should work with script-style code

The three rules:

Function is missing a hint.
Component is missing a hint.
Argument is missing a hint.

work only when a component is in CFML. Can they be extended to work with script code too?

@mpaluchowski , good suggestion.  It looks like functions can be hinted in 3 ways in cfscript.

a hint attribute
@hint in a multiline comment
the entire multiline comment is a hint.
?
Do you agree

Yes, agree :)

@mpaluchowski ,
this is implemented.   Note: the only valid way to hint arguments in cfscript seems to be javadoc style.


CSRF mismatch breaks neonctl auth

Steps to reproduce
neonctl auth

Expected result
Successful login (creation of auth token).
Actual result
When previously logged out in browser:
/home/salim/.software/managed/npm/lib/node_modules/neonctl/node_modules/openid-client/lib/client.js:443
      throw new OPError(params);
            ^

OPError: request_forbidden (The request is not allowed. The CSRF value from the token does not match the CSRF value from the data store.)
    at Client.callback (/home/salim/.software/managed/npm/lib/node_modules/neonctl/node_modules/openid-client/lib/client.js:443:13)
    at Server.<anonymous> (file:///home/salim/.software/managed/npm/lib/node_modules/neonctl/auth.js:70:52)
    at Server.emit (node:events:514:28)
    at parserOnIncoming (node:_http_server:1143:12)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17) {
  error: 'request_forbidden',
  error_description: 'The request is not allowed. The CSRF value from the token does not match the CSRF value from the data store.',
  state: 'naFpFWIoEZP1EJ4o_rkxZcsM6inwqFzojhNWJKPE4yI'
}

Node.js v20.8.0

When previously logged in in browser (CLI waits indefinitely):

Environment
Ubuntu 22.04, Node.js 20.8.0.
Issue occurs with both Chromium and Firefox (vanilla profile).

Thank you for reporting! I think this might be the problem with oauth setup for email based accounts, we will fix it asap, meanwhile Github auth and Google auth should work properly

Hello @salim-b, I am following up on this bug, just gathering details so that I can diagnose the issue- could you confirm for me, in the browser are you logged in via email+password, or via Gmail/Github/Hasura?

email+password

Great, thank you for confirming. I think we have identified the issue, we will try to keep you updated with our progress in fixing it. Apologies for any inconvenience in the meantime

Hello again @salim-b. I believe the issue around third party authorization in the browser should be fixed now, please retry and let us know if you still have any issues :smiley:

Thanks for the reminder, @xenomote. I can confirm that the issue is fixed in v1.23.3 ☺


Double click in Debugger watch panel should trigger new watch UI

Setting new watches in the Debugger watch panel requires you to click the tiny plus icon. We should    make it easier to set new watches.
My proposal is to make double clicking inside the blank area of the watch panel trigger "add new watch" just like if you had clicked on the plus icon.
Before:

After:

@isidorn I can verify in tomorrows build?

@auchenberg you can verify in the insiders from Friday, since until then we keep insiders frozen so our insiders community can test out the bits we plan to ship as stable.
If you want to verify right away you can run vscode out of source.


added splash screen

Added the splash screen.
please check it and merge it under 'Hacktoberfest_accepted' label
pls inform if any changes has to be made

Developer's checklist

[ ] My PR follows the style guidelines of this project
[ ] I have performed a self-check on my work

If changes are made in the code:

[ ] I have followed the coding guidelines
[ ] My changes in code generate no new warnings
[ ] I have added relevant screenshots in my PR

I'll have a look at it

could you use a good img. This is too big to fit in the screen

Ok
Will do it


Can we have nested smart table to show details of a row.

I have a smart table listing consumers and on click want to expand the row and show their order activity in details.
Can you point me to how to achieve this.

I have the same goal. Any ideas???

@RachelYang2 Hello rachel am doing using custom buttons for each functionality and using modal's as child component.

@kcadella I'm doing the same, but could be nice if we have the hability to do a 'row expand' and put another smart-table there with the info you need to show, instead of a modal ... more like most of today web-app are done.

@rbetancor Yup agreed, Hey I have encountered an issue see if you found any resolution. In the modal I have another smart table where I set the source but the table rows are not generated until I click on something else in the modal which displays the table with the rows. Very Strange.

@nnixaa Hello Dmitry did you guys encounter this scenario. I am opening a modal from a smart table custom button and passing an array object. The modal has  a smart table and source is set to the array am passing but the rows are not generated untill some other event is triggered on the component. like a click on a input box or something. Tried almost everything but not working.

@kcadella it's an eventPropagation issue ... when you click on the button that open the modal, the modal object itself its eating the events, so really, it doesn't matter if you fill the smart-table on the ngOnInit of the modal ... they will not fill-up.
I remember I see that before, but I don't remember how I fixed, and now I'm working on the expandable rows, just to avoid the modal usage for that, and use modal only for confirmations or things like that.


Attempt of merge semantics for nodes

The merge function is not yet implemented for inodes, help in doing so would be appreciated
When trying to merge a node and a content with the same name the program goes in the Conflict branch but keeps running so it looks like the error is not properly caught and the merge keeps running.

This will raise the proper conflict in the log file but will not stop the merge from happening. Since this part of the merge is not computed, the repository receiving the merge is left as is so the resulting repository will contain the binding that was originally there.
The conflict raised in Node.merge goes through Merge.conflict and is written once in the logs with Log.debug before raising an Error:
let conflict fmt =
  ksprintf
    (fun msg ->
      Log.debug (fun f -> f "conflict: %s" msg);
      Lwt.return (Error (`Conflict msg)))
    fmt

This error is then caught in three_way_merged :
let merge =
  merge t ~info
  |> Merge.with_conflict (fun msg ->
         Fmt.strf "Recursive merging of common ancestors: %s" msg)
  |> Merge.f
in
merge ~old c1 c2

The message of this conflict might be a bit strange since the log will contain the following line:
program: [DEBUG] conflict: File/Directory
program: [DEBUG] conflict: Recursive merging of common ancestors: File/Directory

Then this will be executed in Store.merge:
let merge ~into:t ~info ?max_depth ?n c1 =
  Log.debug (fun f -> f "merge_head");
  let aux () =
    let* head = head t in
    match head with
    | None -> test_and_set_unsafe t ~test:head ~set:(Some c1) >>= Merge.ok
    | Some c2 ->
        three_way_merge t ~info ?max_depth ?n c1 c2 >>=* fun c3 ->
        let* c3 = Commit.of_hash t.repo c3 in
        test_and_set_unsafe t ~test:head ~set:c3 >>= Merge.ok
  in
  Lwt_mutex.with_lock t.lock (fun () -> retry_merge "merge_head" aux)

Since the Error is not caught here and this is the entry point for the merging, unless catching the error when using this function, the merge will have failed without us noticing it:
master
  /

wip clone
  /

master add a, b and c
  /
    a => =yQ<MQk8!
    b => {FQ
    c => yp{f

wip set a/c
  /
    a
      a/c => ;V@`\N"pM

wip1 merge
  /
    a
      a/c => ;V@`\N"pM

But this is obviously better than the previous behaviour that would consider this merge as ok:
master
  /

wip clone
  /

master add a, b and c
  /
    a => =yQ<MQk8!
    b => {FQ
    c => yp{f

wip set a/c
  /
    a
      a/c => ;V@`\N"pM

wip1 merge
  /
    a
      a/c => ;V@`\N"pM
      b => {FQ
      c => yp{f

This update should fix #1433


turn on GcpHttpAuthProviderTest; close #100

@loosebazooka @patflynn

FYI, this is passing locally and failing on travis. If anyone sees why, please holler.

Can we close this?


iree-e2e-matmul-test improvements

To ease numerical debugging, these matmul tests have always tried simple matrices first (so most numerical debugging is done on simple matrices) before moving on to general random matrices. That's not changing, but the way we implement that is. That used to be hardcoded in the generated YAML traces. With this PR, the YAML traces only mention the pseudorandom matrices anymore, and the trace runner now STARTS with that general case, and ONLY if that fails does it proceed to retrying on simpler matrices, for logging purposes only. The benefits are many:

Faster (in the generic success case, only the one case of random matrices is run).
Consistently done in all cases now (before, we had to compromise with test cost/latency).
The generator Python script becomes simpler.
The shared trace_replay library doesn't need to know about identity matrices anymore.

Python script improvement: de-deduplicated generate_gpu and generate_default. They were doing the same work; the default variant was just the variant where the compilation_info is NONE, so I only needed to change CompilationInfo into typing.Optional[CompilationInfo] in one place.
C program improvements:

@benvanik had added a TODO flagging one of my helper functions as unreadable and likely replaceable with just iree_hal_buffer_map_copy, so that's done here.
renamed functions and added comments.

@KoolJBlack @ThomasRaoux can you check if i'm regressing GPU tests here?
@ScottTodd FYI, reduction of e2e test time (13 s --> 11 s here)

@KoolJBlack @ThomasRaoux can you check if i'm regressing GPU tests here?
@ScottTodd FYI, reduction of e2e test time (13 s --> 11 s here)

added Turing buildbot

@KoolJBlack @ThomasRaoux can you check if i'm regressing GPU tests here?
@ScottTodd FYI, reduction of e2e test time (13 s --> 11 s here)

added Turing buildbot

Looks all good from gpu side

@ThomasRaoux @KoolJBlack more CUDA testing welcome!

@benvanik can we wrap this up?


Add cross product and view matrix features

Hey, thanks for contributing. This seems fine. Merged.


CUDA out of memory in PyTorch OP

Hi
While I was running a 7B model by FasterTransformer's PyTorch OP on the V100, I found a problem which error message like:
[FT][ERROR] CUDA out of memory. Tried to allocate 10.00 GiB (GPU 0; 31.75 GiB total capacity; 13.84 GiB already allocated; 6.91 GiB free; 23.77 GiB reserved in total by PyTorch)
Sorry for I can't provide the reproduced steps.
For more test information to you:
I run gpt model inference with different batch size inputs, once feed different batch size inputs than before, it's much probility to occur this problem.
For instance, feed bs = 3 model inputs 100 times, then feed bs = 2 model inputs, OOM were to occur.
And I found If I fixed  batch size, everything is stably ok.
The OOM error info like:
[FT][ERROR] CUDA out of memory. Tried to allocate 10.00 GiB (GPU 0; 31.75 GiB total capacity; 13.84 GiB already allocated; 6.91 GiB free; 23.77 GiB reserved in total by PyTorch)
[FT][ERROR] CUDA out of memory. Tried to allocate 10.00 GiB (GPU 0; 31.75 GiB total capacity; 13.84 GiB already allocated; 8.88 GiB free; 21.80 GiB reserved in total by PyTorch)
The error info seems that pytorch catches a lot of memory so that there is no memory to allocate.
Unpredictably, I modify the code of allocator type, from ft::AllocatorType::TH to ft::AllocatorType::CUDA,  as it seems that Pytorch has always had Cahing Memory Problem found by google search and many guys find it hard to solve. It looks work that never occur any errors, But I'm very confused about whether it is necessary to use torch::empty to allocate memory instead of cudaMallocAsync.

Using torch::empty is much better because cudaMalloc may have overhead, while torch has memory pool.

For more test info: I added torch.empty_cache() code after gpt model forward, but it did not work..

Using torch::empty is much better because cudaMalloc may have overhead, while torch has memory pool.

thanks @byshiue for your quick reply! I'll go test the overhead later.


improved SVG icon for Mastodon

The icon added in #3 did not render nicely so I adjusted it.
Before:

After:

Thanks for the great theme!

Hi @arongergely,
This is actually awesome. I will merge it shortly.

Merged... Thank you again for the contrib.


Allow lifecycle callbacks after dynamic import

It seems that the lifecycle callbacks don’t work if the component is imported with the dynamic import() in the action function as here:
https://vaadin.github.io/vaadin-router/vaadin-router/demo/#vaadin-router-code-splitting-demos
I could see that it only happens the first time. Then, once the component has already been imported dynamically, the next times… the lifecycle callbacks works

Thanks for reporting an issue! A similar one has already been fixed: https://github.com/vaadin/vaadin-router/issues/271, which makes this report very interesting. Would it be possible for you to create a minimal reproducible example where the issue happens?
There is a basic example that you can use as a starting point: https://glitch.com/edit/#!/vaadin-router

@vlukashov sure! Check this: https://glitch.com/edit/#!/flash-snowman

Open flash-snowman.glitch.me. You can see that the home-view.js is imported, but the onAfterEnter() function does not run.
Click on the 404 page link.
Click on the go Home link. Now the onAfterEnter() function run!

This issues looks like a duplicate of #282.

Oof. I spent the last hour or so trying to figure out this. I have an onBeforeEnter that's supposed to be checking logins and it's not firing. I'm guessing this is the issue I'm having too, though I can't ever get mine to fire. I'll put up a glich if the fix here doesn't get my case too, or would you like a second one now @web-padawan?

@vlukashov, @web-padawan Any thoughts on this? It makes dynamic imports pretty much worthless and therefore makes using bundlers like Webpack much harder.

Ugly workaround:
Step 1: expose router to imported component's module:
const router = new Router(host);
router.setRoutes([
  {
    path: '/some-path', component: 'x-component', action: () => {
      import('./x-component.js').then(m => m.setRouter(router));
    },
  },
]);

Step 2: direct in imported module
export const setRouter = r => {
  router = r;
  console.log('router saved!', router);
}

Step 3: use router inside component class
router.constructor.go('/some-url-in-router-scope')

It works for me when there is only one router instance, I don't know how it works out in more complex routing scenarios.

Ugly workaround to access router on first render:
Step 1: expose router to imported component's module:
const router = new Router(host);
router.setRoutes([
  {
    path: '/some-path', component: 'x-component', action: () => {
      import('./x-component.js').then(m => m.setRouter(router));
    },
  },
]);

Step 2: direct in imported module
export const setRouter = r => {
  router = r;
  console.log('router saved!', router);
}

Step 3: use router inside component class
router.constructor.go('/some-url-in-router-scope')

It works for me when there is only one router instance, I don't know how it works out in more complex routing scenarios.

It looks like the root cause of this issue is that router does not handle well the case when a route web component is loaded async to the route resolution.
A workaround would be making router to wait until the route component is loaded before proceeding with the rest of the route resolution steps (including lifecycle callbacks):
const router = new Router(host);
router.setRoutes([
  {
    path: '/some-path',
    component: 'x-component',
    action: async () => {
      await import('./x-component.js');
    },
  },
]);

@vlukashov That would appear to fix the issue, at least in naive instances such as the glitch.me by @abdonrd and me. Should this then be just a documentation issue instead of bug? Not sure if there is really a downside to the having async/await for all dynamic imports, even if there are no lifecycle methods to fire.


docs: update changelog and docs order

coverage: 94.071% (-1.2%) from 95.241%
when pulling 829d47382344390d8bd8399a852dd91a971187b3 on v2.1-release
into cc38ecb3e41f8567650a3ef556ce495e13c1ca84 on main.


No command service defined for provider upstart

Hi,
I'm using version 6.1.5 of the puppet-logstash module. And trying to install logstash-1.4.2-1_2c0f5a1.noarch but puppet apply failed with an exception Error: /Stage[main]/Logstash::Service/Service[logstash]: Could not evaluate: No command service defined for provider upstart

Puppet:
puppetserver-5.1.0-1.el6
puppet-agent-5.2.0-1.el6
Distribution: CentOS release 6.6

Stack Trace
Debug: /Stage[main]/Rsyslog::Config/File[/var/lib/rsyslog]/seltype: SELinux bindings not found. Ignoring parameter.
Debug: Servicelogstash: Could not find logstash.conf in /etc/init
Debug: Servicelogstash: Could not find logstash.conf in /etc/init.d
Debug: Servicelogstash: Could not find logstash in /etc/init
Error: /Stage[main]/Logstash::Service/Service[logstash]: Could not evaluate: No command service defined for provider upstart
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider.rb:146:in command' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider.rb:490:in command'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/service/debian.rb:72:in statuscmd' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/service/upstart.rb:150:in statuscmd'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/service/base.rb:56:in status' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/service/upstart.rb:157:in status'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type/service.rb:110:in retrieve' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type.rb:1070:in retrieve'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type.rb:1098:in retrieve_resource' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:302:in from_resource'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:20:in evaluate' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:248:in apply'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:267:in eval_resource' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:179:in call'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:179:in block (2 levels) in evaluate' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:511:in block in thinmark'
/opt/puppetlabs/puppet/lib/ruby/2.4.0/benchmark.rb:308:in realtime' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:510:in thinmark'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:179:in block in evaluate' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/graph/relationship_graph.rb:121:in traverse'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:169:in evaluate' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:225:in block in apply'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/log.rb:155:in with_destination' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/report.rb:140:in as_logging_destination'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:224:in apply' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:172:in block in apply_catalog'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:224:in block in benchmark' /opt/puppetlabs/puppet/lib/ruby/2.4.0/benchmark.rb:308:in realtime'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:223:in benchmark' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:171:in apply_catalog'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:344:in run_internal' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:222:in block in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/context.rb:65:in override' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet.rb:263:in override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:196:in run' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/agent.rb:46:in block (4 levels) in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/agent/locker.rb:21:in lock' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/agent.rb:46:in block (3 levels) in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/agent.rb:110:in with_client' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/agent.rb:43:in block (2 levels) in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/agent.rb:67:in run_in_fork' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/agent.rb:42:in block in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application.rb:179:in controlled_run' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/agent.rb:40:in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/agent.rb:365:in onetime' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/agent.rb:343:in run_command'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application.rb:358:in block in run' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:666:in exit_on_fail'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application.rb:358:in run' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:132:in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:72:in execute' /opt/puppetlabs/puppet/bin/puppet:5:in '
Debug: Class[Logstash::Service]: Resource is being skipped, unscheduling all events
Any help will be much appreciated.
Thanks

You ever figure this out?


Write JSDoc for map, mapTo, pluck, filter, scan, do

@blesh Added "Any errors that are thrown in the aforementioned Observer or handlers are safely sent down the error path of the output Observable." and removed the map example.

LGTM. Needs a rebase though.

Rebased. :white_check_mark:

Merged with f209294, thanks @staltz :)