TypeError: load() missing 1 required positional argument: 'export_dir'

face_detector.py ave me above error:
self.model = tf.saved_model.load(self.model_path) in this line. In cofig.py as path I gave model/detector
Tensorflow 1.13

Hi,
This is the tf2 api,  if you want tf1. please switch to tf1 branch.
GoodLuck

Thank you


GUI usability - ability to blank WDL when n/a, indicate default branch

Feature Request
Desired behaviour

The Info tab description stays blank until a version is selected, we could use an indication that a default version needs to be selected first before populating this (and other fields in the into tab)
Cannot blank the (default?) WDL path when adding a default branch

chat.txt
This is on 1.1 release of Dockstore

Also, when switching between the inner tabs of 'Files' the correct version is only selected on first opened tab.  If you then click along Descriptor, test files the version changes, and persists back to 'Dockerfile'.
e.g. dockstore-cgpmap has 1.0.2 selected as current version, but it switches back to 1.0.0
https://dockstore.org/containers/quay.io/wtsicgp/dockstore-cgpmap

Check that blanking one of WDL or CWL works correctly both in the "Add Tool" dialogue and the Info tab for defaults.

Working in staging.dockstore.org


enhance: Show notification when uploading estimates to Infracost Cloud

@alikhajeh1 let me know if you want to change the wording
Comment output when logging:

When not logging:

LGTM!


Connecting to multiple brokers

Hi.
A good feature would be a way to connect to multiple brokers. This would allow to have a simple Load balancing and HA.
For instance, using RabbitMQ, you would declare an ordinary queue.
You could also make a RabbitMQ cluster, declare a mirrored queue, and you've get a HA configuration.
It would also be easy to have load balancing using other backends.

Say you want to add a new master/slave to the cluster, you would then have
to restart all clients in order to make them use it, that hardly seems
like a good solution for availability.
Using something like keepalived or corosync+pacemaker is a better solution
than maintaining a static list of nodes in every client,
and keepalived is also very simple to setup.
I don't see why Kombu should support this if its use will be discouraged,
that is unless someone has a very good reason not to use a load balancer.

How does a load balancer work on the consumer side?
For instance, you have 3 servers with workers. All the workers are consumers and producers. Now I see that producers could load balance, but what about the consumers. Do the consumers reinitiate the connection to the broker?

The consumers (workers) will re-establish the connection when lost, so if you use keepalived they only use a single address and keepalived will redirect them to a working node.

Yes, that is great for HA, and I agree, the IPs list on client side isn't great for HA. But if I wanted to have load balancing (the three RabbitMQ nodes aren't interconnected), I would have to break the connections deliberately to achieve load balancing on the consumer side using keepalived.
Perhaps there would be a setting that you would set a number of tasks completed before the consumer recreates the connection with the queue. But I think a list of IPs for load balancing would be a better option.


(chore) expire _tvs_session cookie after an hour

and rename to _teachingjobs_sesssion

Related to #270

 Expire tvs_session_cookie after one hour


dnsmasq error: cannot open or create lease file

Pretty standard config:
  services.dnsmasq = {
    enable = true;
    servers = [ "<IP_ADDRESS>" "<IP_ADDRESS>" ];
    extraConfig = ''
      interface=wlp4s0,enp2s0,enp3s0
      bind-interfaces
      dhcp-range=<IP_ADDRESS>,<IP_ADDRESS>,24h
      dhcp-range=<IP_ADDRESS>,<IP_ADDRESS>,24h
      dhcp-range=<IP_ADDRESS>,<IP_ADDRESS>,24h
    '';
  };

Dec 14 19:51:04 apu systemd[1]: Starting Dnsmasq Daemon...
Dec 14 19:51:04 apu dnsmasq-pre-start[11323]: dnsmasq: syntax check OK.
Dec 14 19:51:04 apu dnsmasq[11329]: cannot open or create lease file /var/lib/misc/dnsmasq.leases: No such file or directory
Dec 14 19:51:04 apu dnsmasq[11329]: FAILED to start up
Dec 14 19:51:04 apu dnsmasq[11329]: dnsmasq: cannot open or create lease file /var/lib/misc/dnsmasq.leases: No such file or directory
Dec 14 19:51:04 apu systemd[1]: dnsmasq.service: Main process exited, code=exited, status=3/NOTIMPLEMENTED
Dec 14 19:51:04 apu systemd[1]: Failed to start Dnsmasq Daemon.
Dec 14 19:51:04 apu systemd[1]: dnsmasq.service: Unit entered failed state.
Dec 14 19:51:04 apu systemd[1]: dnsmasq.service: Failed with result 'exit-code'.

also note https://github.com/NixOS/nixpkgs/issues/10101

Hah, thank you! I actually read that issue already, but I missed that ISC dhcpd isn't affected but dnsmasq is. I have a fix for this issue, but that won't be of much use until #10101 is fixed.

I disabled checkReversePath and patched dnsmasq to use /var/lib/dnsmasq/dnsmasq.leases, but it still doesn't respond to DHCP requests. Nothing in the logs at all, so weird..

Out of curiosity, does it work if you add the interfaces to networking.firewall.trustedInterfaces?

All internal interfaces are in trustedInterfaces. The ISC dhcpd works fine even when they're not trusted, but I added them to get the DNS part of dnsmasq working.

I think dnsmasq changed directory location so we have to create the supporting directory.

I changed a few other things and now it responds to dhcp requests..oh well, whatever.


Add separate codepath for attr get/set so args aren't encoded

Is this pull request associated with an issue(s)?
Fixes #122
Description
This PR just allows object get/set attribute calls to not encode the arguments,
which should allow the value to be passed verbatim into the attribute and when retrieving.

Tests for the class attributes were added, but I also discovered the same issue with cpp_map, it's been fixed locally but I still need to write tests for that

Map has been fixed, should be good to review now


[Task] Add Basic Error Handling

Purpose
This PR added the ability to handle some basic errors from call sdk. Basic errors including:

invalid token
chat thread deleted
other errors when initiating chat client (network issues, etc.)

for public preview, we would only be sending errors to Contoso. For GA+, we would be having UI for those error scenarios.
Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Pull request checklist
This PR has considered:

[ ] Color Theming
[x] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] View Data Injection
[ ] Demo App UI/UX update

How to Test

Open...
Click on...

What to Check

Before
After

Screenshot or description before this change
Screenshot or description with this change

Other Information

As discussed on a call. The demo app will handle the error passed up and the error object contains the error message.

Looks good!


Check for expired CA certificate

From @mhils on November 4, 2015 10:37
The mitmproxy CA certificate is generated on the first start of mitmproxy. Due to mitmproxy/mitmproxy/issues/815, the certificate is only valid for three years. CertStore.from_store should check if the CA certificate is still valid and raise an error if that is not the case (which we can then act on in mitmproxy).
Copied from original issue: mitmproxy/netlib#101

From @tinius on January 14, 2016 1:47
Seems to me that this would do it:
ca = OpenSSL.crypto.load_certificate(
            OpenSSL.crypto.FILETYPE_PEM,
            raw)
if ca.has_expired():
    raise CertExpiredException("mitmproxy's certificate has expired.")

That being said, is there a reason why we shouldn't just call create_store on the spot?

That being said, is there a reason why we shouldn't just call create_store on the spot?

I'm not sure what's the best way, but silently replacing the CA (without user notification) is not really optimal. At the very least, we need some kind of notification that a new certificate has been generated.

@mhils I am a new contributor and would like to work on this

At the very least, we need some kind of notification that a new certificate has been generated.

What kind of notification? Like printing on screen that new certificate has been generated or taking user response to whether or not generate a new certificate?

Not sure yet. Let's start by adding a function in netlib that determines if the CA is outdated + tests? :smiley:

@mhils please review #995.

From reading the chromium issue, validity length checks only apply to leaf certificates, not CAs.  This means your CA can still be valid for 20 years (mine is), so long as mitmproxy's generated leaf certificates are only valid for 39 months or less.  Since mitmproxy always generates certs on the fly, and never caches them to disk, checking for expiration of them only matters in really long running instances (usually mitmdump).

@mhils This issue seems to be still present on the latest version of mitmproxy (6.0.2), my mitmproxy certificate is expired since 16 December and I got this error on Firefox when visiting a website with HSTS preload like Facebook, which does not allow exceptions:
Did Not Connect: Potential Security Issue

Firefox detected an issue and did not continue to www.facebook.com. The website is either misconfigured or your computer clock is set to the wrong time.

What can you do about it?

www.facebook.com has a security policy called HTTP Strict Transport Security (HSTS), which means that Firefox can only connect to it securely. You can’t add an exception to visit this site.

Your computer clock is set to 12/25/2020. Make sure your computer is set to the correct date, time, and time zone in your system settings, and then refresh www.facebook.com.

If your clock is already set to the right time, the website is likely misconfigured, and there is nothing you can do to resolve the issue. You can notify the website’s administrator about the problem.

Learn more…

www.facebook.com uses an invalid security certificate.

The certificate is not trusted because the issuer certificate has expired.

Error code: SEC_ERROR_EXPIRED_ISSUER_CERTIFICATE

View Certificate

How can I renew the mitmproxy CA certificate instead of creating a new one by removing the .mitmproxy folder?


Inline annotation gives a warning Unknown attribute: "inline".

The annotation does work but gives a warning.

I will fix this now.


Evaluation of NeonTreeEvaluation dataset on various resolutions

I'm putting these documents https://github.com/weecology/DeepForest_Model


Help with Form Validation (Creating Sets of Rules)

I'm using  form_validation.php in application/config/ folder with subs arrays
$config = array(
	'siga_login' => array(
		array(
				"field" => 'usuario',
				"label" => '"Usuário (Login)"',
				"rules" => 'xss_clean|trim|required|min_length[2]|max_length[60]|strtolower'
		),
		array(
				"field" => 'senha',
				"label" => '"Senha de acesso"',
				"rules" => 'xss_clean|trim|required|min_length[4]|max_length[30]'
		)
	),
       // And more ...
);

My problem is that method run() don't validate using my rules, first I set the data (I know that the default is $_POST, but it's okay)
$this->form_validation->set_data($_POST);
if($this->form_validation->run('siga_login')===FALSE){
	// Action if has validate errors
	return;
}else{
	// It's Okay
}

I have extended the Form_validation but, everthing ok, I just added some new functions.
class MY_Form_validation extends CI_Form_validation {

	private $enableCaptcha = true;

	public function __construct($rules=array())
	{
		parent::__construct($rules);
		$ci = &get_instance();
		$ci->load->library('recaptcha');
	}
}

And I'm loading in config/autoload.php
$autoload['libraries'] = array('database','session','encryption','form_validation');

Sorry, this is a bug tracker - we don't provide help here.
Please post on our forums instead.


Not adding some social icons

I forked this repository and added some social media buttons. But not adding icons. Use icons from Simple Icons. There are so many icons available.

What icons are missing that we need?

What icons are missing that we need?

Telegram
Discord
Quora
Stack Overflow
Instagram
Facebook
LinkedIn
GitLab

etc

I just checked 1 example, Discord exists. Which ones are missing that are not available in the libraries we already use that we need to change to another library?

Use icons from Simple Icons. There are so many icons available.

Like shields badges

There are so many icons available.

You keep saying "so many available" but which ones add value to the project to include another library?
You shared a list of socials to include, which ones are not available in the current library we use?

There are so many icons available.

You keep saying "so many available" but which ones add value to the project to include another library?
You shared a list of socials to include, which ones are not available in the current library we use?

https://github.com/EddieHubCommunity/LinkFree/issues/170#issuecomment-927282311
These icons


Build failure if followed the new manual download instructions

Describe the bug
There is some discrepancy between what fetchDependencies.gradle does and what the manual download instructions tell people to do. The build script expects to find files where fetchDependencies.gradle saved. The build fails if I follow the manual download instructions.
The discrepancies are:

fetchDependencies.gradle saves yajsw-stable-12.12.zip to ${REPO_DIR}/dependencies/GhidraServer, while the manual download saves this file to ${REPO_DIR}/dependencies
fetchDependencies.gradle saves PyDev 6.3.1.zip to ${REPO_DIR}/dependencies/GhidraDev, while the manual download saves this file to ${REPO_DIR}/dependencies
fetchDependencies.gradle saves cdt-8.6.0.zip to ${REPO_DIR}/dependencies/GhidraDev, while the manual download saves this file to ${REPO_DIR}/dependencies
The manual download instructions lack the step to download .fidb files from ghidra-data and save them under ${REPO_DIR}/dependencies/fidb

Thanks, I've followed your PR commit with these fixes.


Added EXIT functionality

Hello @TechSpiritSS !
The user was unable to exit the terminal when viewing the terminal.
I have added just the functionality of exiting the terminal at one click.
Please assign me this feature edit and give this issue a "hacktoberfest" tag.
I will create a PR soon.
Hope that helps😇

Can you showcase the preview regarding this feature?

I want  to work on this issue please assign it to me. I can implement exit functionality such that after entering exit the current window closes. If this is what is needed please assign it to me.

I have fixed the issue!

Pull requested created. It works absolutely fine now. Please have a look @TechSpiritSS

I want  to work on this issue please assign it to me. I can implement exit functionality such that after entering exit the current window closes. If this is what is needed please assign it to me.

This issue is already assigned, you can create a new issue yourself if you're interested to contribute in the project :)


Asset description markdown link parsing improvements

Overview
We now have the ability to include custom asset descriptions including markdown thanks to this https://github.com/shapeshift/web/pull/1045
We want to be able to parse both

absolute URLs to external links, e.g. starting with a full protocol and origin https://www.coingecko.com/someAsset
relative urls to internal links, e.g. /earn/defi

Reference
Modify logic in this file to be able to support internal and external links https://github.com/shapeshift/web/blob/develop/src/components/SanitizedHtml/SanitizedHtml.tsx#L13
Acceptance Criteria

Markdown can include relative internal links, and absolute external links
Internal links should not be specific to our environments, e.g. they should not contain app.shapeshift.com or similar

Screenshots/Mockups
No response
Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

closed in #1107


Unbundle the cmaps data

These should IMHO be made available only as an option and in a separate wheel... The current wheel is ~ 6MB and the almost all of it except 100KB is from the cmap data.

Hi @pombredanne. Could you point out as to how should I go about doing this?

I agree that it is a little bit weird to include these into the package. But on the other hand, it worked for years and it is really easy to use. Also, they don't change a lot.
Alternatives are:

generating them when they are needed. I think one of the tools/ scripts can do this.
generate them during setup.py (https://github.com/pdfminer/pdfminer.six/pull/271, https://github.com/pdfminer/pdfminer.six/pull/117)
download them when they are needed.
put them into a separate package and depend on that.
compress them (by using zip I get it down from 6.5 to 5.5 mb)
using another way to compress them that is more efficient than pickle

Enough alternatives, but I'm not sure why the current setup needs to change.

I think that it would be better to not use pickle for cmaps, primary concern being security.
Generating them during install would be nice, but using another compression would be good too.
I read some discussion in some closed PR so I tought of giving my opinion here.

I think its this PR: https://github.com/pdfminer/pdfminer.six/pull/117
The benefit of having the cmaps is the fact that pdfminer.six has "batteries-included": CJK just works. And I'm not seeing the downsides of having them. Why is the increased package size a problem?
The security issue with pickles is a valid one. People need to trust the pdfminer.six community in order to trust the pickles. This is also mentioned by @KOLANICH in #117. I'm even more worried about the compatibility of the pickles with our code. Not sure what kind of objects are in the files, but if we change the corresponding code classes it might break them.
In summary, I'm more concerned about the file types than about the file size.

Its also very possible that pickle has a large overhead and that changing the file type reduces the file size, or makes it easier to compress.

Some observations:

The pickles are built from the text files in cmapsrc/. These are 7.4mb. The pickles are 6.6mb.
There is lots of redundancy in the text files. Zipping them results in 1.9mb.
I've checked the content of the pickles and these are just simple dicts with str and int keys and values. Json would do just as fine.
Rebuilding the pickles takes a couple of seconds, so doing that on runtime is not an option.

Preferred solution here is to pack pdfminer.six with compressed json cmap's. Instead of json, any other format that does not execute arbitrary code is also fine.

I've started working on this. Storing the cmap's as gzipped jsons takes 8.2mb.

Reading all jsons takes 0.3 seconds, whereas reading all the pickles takes 0.13 seconds.


Fix the total node count logic when checking if nodes are ready

Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve
/woof


fix: add migration for mission places.json

The previous migration<PHONE_NUMBER>912_automatic-update-static-places.ts imported an erroneous migration file. The file 08_places.json was imported as it should have been 11_places.json.

There is no conflict between this migration and the previous "invalid" one right? They can both run and the migration state will be correct?
UPDATE: I have seen the migrations directory and there are lots of them for static places. I think there will be no issues. Fixing the typo is enough for the approve.

I deleted the Places that were erroneously added (to avoid duplication) and added them again.


Changing the UI of a website and make it responsive

I will convert the UI into blue and black theme which denotes dedication and also make it responsive for the mobile phones.

Thanks
On Fri, 11 Oct, 2024, 9:21 pm Ansh Grover, @.***> wrote:

Assigned #12 https://github.com/Anshgrover23/To-Do-List/issues/12 to
@Bhumika-00 https://github.com/Bhumika-00.
—
Reply to this email directly, view it on GitHub
https://github.com/Anshgrover23/To-Do-List/issues/12#event-14611297233,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKOHTVRP4S7Z4DP4XTSQN5TZ27XWJAVCNFSM6AAAAABPZFVHOOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGYYTCMRZG4ZDGMY
.
You are receiving this because you were assigned.Message ID:
@.***>

I have completed my task please review it
On Fri, 11 Oct, 2024, 9:22 pm Bhumika Sharma, @.***>
wrote:

Thanks
On Fri, 11 Oct, 2024, 9:21 pm Ansh Grover, @.***>
wrote:

Assigned #12 https://github.com/Anshgrover23/To-Do-List/issues/12 to
@Bhumika-00 https://github.com/Bhumika-00.
—
Reply to this email directly, view it on GitHub
https://github.com/Anshgrover23/To-Do-List/issues/12#event-14611297233,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKOHTVRP4S7Z4DP4XTSQN5TZ27XWJAVCNFSM6AAAAABPZFVHOOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGYYTCMRZG4ZDGMY
.
You are receiving this because you were assigned.Message ID:
@.***>

Hello,
I have seen that the page is still not responsive for mobile view. If no one is working on this can you please assign this to me and please add the hactoberfest and gssoc-extd label

I have fixed the issue.
On Sat, 12 Oct, 2024, 9:10 pm Mohtasheem Ejaz, @.***>
wrote:

Hello,
I have seen that the page is still not responsive for mobile view. If no
one is working on this can you please assign this to me and please add the
hactoberfest and gssoc-extd label
—
Reply to this email directly, view it on GitHub
https://github.com/Groverio/To-Do-List/issues/12#issuecomment-2408604761,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKOHTVWNTGDCOCCP6TYRCKLZ3E7GBAVCNFSM6AAAAABPZFVHOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGYYDINZWGE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

I have completed my work in changing the theme and ui of the website
On Sat, 12 Oct, 2024, 9:28 pm Ansh Grover, @.***> wrote:

@Bhumika-00 https://github.com/Bhumika-00 I see that your PR is closed,
if u are working on this then make a new PR with required changes.
—
Reply to this email directly, view it on GitHub
https://github.com/Groverio/To-Do-List/issues/12#issuecomment-2408609301,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKOHTVTTCKGQYCQU5RTFYHLZ3FBI5AVCNFSM6AAAAABPZFVHOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGYYDSMZQGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

And yesterday you reviewed it and also verified the work
On Sat, 12 Oct, 2024, 9:28 pm Bhumika Sharma, @.***>
wrote:

I have completed my work in changing the theme and ui of the website
On Sat, 12 Oct, 2024, 9:28 pm Ansh Grover, @.***>
wrote:

@Bhumika-00 https://github.com/Bhumika-00 I see that your PR is
closed, if u are working on this then make a new PR with required changes.
—
Reply to this email directly, view it on GitHub
https://github.com/Groverio/To-Do-List/issues/12#issuecomment-2408609301,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKOHTVTTCKGQYCQU5RTFYHLZ3FBI5AVCNFSM6AAAAABPZFVHOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGYYDSMZQGE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Colorblind-Independent Color Accessibility Modifiers

Is your feature request related to a problem? Please describe.
While I'm not colorblind myself, I think it would be a good idea to separate the color accessibility options from having a colorblindness mode enabled.
Describe the solution you'd like
The ability to independently enable the "blue good", "black off", and network light verbosity regardless of colorblindness mode. The colorblindness modes can still toggle these on, but it shouldn't be required. Maybe vice versa as well.

I like that idea! I think it would be the least intrusive in the code if I added an additional color mode that did blue/black/network light change all as one, which sounds like it might be what you're asking. In my testing I thought the blue on black indicators looked really clean so I'm happy to make that accessible without shifting the other colors around. The basalt theme on front panels with blue indicators is very aesthetically pleasing.
I think I will leave the colorblindness stuff as-is though and not make it a vice versa change, since the blue and network light changes are critical to that and the black off was only added because it helped a lot with contrast in Tritanopia mode (and the others benefited too).

Fine enough for me.

Ended up landing on this


The HTML Tag Auto Complete is so slow

VSCode Version:
OS Version:

Steps to Reproduce:

Create html file
type code. You literally can type faster than the autocomplete.

Reproduces without extensions: Yes/No

@mohsinht Did you disable all extensions?

Closing due to lack of information.


Fixes paths containing spaces + remove \

Theses changes remove the \ when a file or folder contains a space (just like in tree) and allow such folders to be traversed.

Nice.


Why do some fills get removed?

Most svg fills remain as-is when they get added to an svg-sprite but for some reason if the fill is 000 or 000000, the fill attribute gets removed from the svg in the resulting svg-sprite. Why does this happen? Is there a config option to override this behavior?

I'm pretty sure the reason is one of SVGO's more aggressive plugins — see here for getting an idea how to disable them selectively, and here for a list of SVGO's plugins — or because you exported your SVGs with Illustrator and didn't specify "presentation attributes" during export (please have a look at this thread). Please let me know if you can solve your case with this.

@nathanjessen curious if you made progress on this. Due to semver in my build, this bit me and borked my production spritemap, my project also has lots of SVG's with fill="#000000"

@brianfeister haven't had the time or desire to look into it. Our temporary fix was to modify the fill slightly to something like fill="#000100"

@brianfeister @nathanjessen Did you try to selectively disable the SVGO plugins as I described above?

@jkphl looking at it is in my queue of things to do. I was hoping for a quick win if @nathanjessen had the exact config code for me to drop in. I'll certainly update this ticket with the needed config when I get to it in the next week or so.

@brianfeister Cool, thanks! :)

I'll close the issue due to inactivity but if this still an issue for you please feel free to get back to me again!

@nathanjessen @brianfeister You should try to disable the removeUnknownsAndDefaults plugin, which is enabled by default.


Update Post “best-way-to-treat-your-home-for-termites-white-ants”

Automatically generated by Netlify CMS

👷 Deploy Preview for chic-shortbread-66a66b processing.

Name
Link

🔨 Latest commit
a44871c56de67af8ba00097c2d4adcdf8d784cfe

🔍 Latest deploy log
https://app.netlify.com/sites/chic-shortbread-66a66b/deploys/6541dec75ca1d500083875eb


remove the --use-cfe flag from flutter analyze

remove the --use-cfe flag from flutter analyze (revert https://github.com/flutter/flutter/pull/20742)

@bkonyi, @cbracken

Thanks @devoncarew!

I'll plan to land this when the flutter build is green -


mapping: create group v2

I guess for existing installations we need to reindex all data right?

Yes! We need to reindex the groups as done here: https://inveniordm.docs.cern.ch/releases/upgrading/upgrade-v10.0/#complete-re-indexing


⚡ Automatically restart closed AMQP channel

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#740
#739  👈 (View in Graphite)
#738
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Supporting auto-merging

Support auto-merging requires further improvements

need to store not only leaf but also parent nodes
need to ensure that the same node, loaded in different days has always the same id (hash?)

Using hash for id makes a step forward.. this way the ID is unique for the page. But the rest of implementation is missing.


Style 'forgot password' page

/users/passwords/new

@cdebourcy, does this also involve, creating the route for the page? The page does not seem to exist yet.

Currently it's the following rails view: app/views/devise/passwords/new.html.erb
You can get to it by logging out and clicking "Forgot password?"
So no need to create a new route

@cyrielo you said this was done right?


Disabling rack-timeout logging fails

Hi. I want to disable rack-timeout's logging, so I put Rack::Timeout::Logger.disable in my development.rb file but I'm getting the following error:
undefined method `disable' for Logger:Class (NoMethodError)

Am I doing something wrong?

Had installed version 0.2.0. Installed newest version 0.3.2 and problem solved :)


GIM Group Bank Search

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]
I have to constantly ask my group members if they have a certain item
Describe the solution you'd like
A way to search my group members banks remotely. (Eg. banked xp plugin remembers bank items even after leaving. I am sure there are external bank search plugins as well)

I use this plugin for my group:
https://github.com/christoabrown/group-ironmen-tracker


[96] Unique Binary Search Trees

Codecov Report

Merging #74 (ea73004) into master (f358227) will increase coverage by 0.2%.
The diff coverage is 100.0%.

Impacted Files
Coverage Δ

src/problem/p0096_unique_binary_search_trees.rs
100.0% <100.0%> (ø)


[Bug] Multi-page export not working

Is there an existing issue for this?

[X] Yes, I have searched the existing issues and none of them match my problem.

Product Variant
Cloud (https://rxresu.me)
Current Behavior
Whenever the resume exceeds 1 page, it just outputs 1 long page in stead of going on to a second page. The page break line is there so it does recognize it, but not a second page is created.
Expected Behavior
No response
Steps To Reproduce
No response
What browsers are you seeing the problem on?
No response
What template are you using?
None
Anything else?
No response

Duplicate of https://github.com/AmruthPillai/Reactive-Resume/issues/1834


alembic: 1.8.3 -> 1.8.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/alembic/alembic/releases.
meta.description for alembic is: "An open framework for storing and sharing scene data"
meta.homepage for alembic is: "http://alembic.io/"
meta.changelog for alembic is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.4 with grep in /nix/store/qc8xl0vm0l2swm68z79rl1xkba63zk86-alembic-1.8.4-bin
found 1.8.4 in filename of file in /nix/store/qc8xl0vm0l2swm68z79rl1xkba63zk86-alembic-1.8.4-bin

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
alembic
blender
blender-hip
python310Packages.bpycv
python39Packages.bpycv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qc8xl0vm0l2swm68z79rl1xkba63zk86-alembic-1.8.4-bin \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A alembic https://github.com/r-ryantm/nixpkgs/archive/3b07d6b7280ddbd3b20236370de021b025488a69.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qc8xl0vm0l2swm68z79rl1xkba63zk86-alembic-1.8.4-bin
ls -la /nix/store/qc8xl0vm0l2swm68z79rl1xkba63zk86-alembic-1.8.4-bin/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @guibou for testing.

@ofborg build alembic alembic.passthru.tests


Added namespace in the kubectl plugin

Hi, there.

Used kubectl to find current context and added current namespace.
Enhanced Golang and Python plug-ins.

Hi @ziwon I saw your implementation of kubectl and I did a similiar one #312
I will add your idea to use the BULLETTRAIN_KCTX_NAMESPACE variable It's a good one

I used the option --minify on kubectl config view to simplify the implementation. What to you think about it?

@raizdepi --minify looks good! :)


new home page

For design discussion and mocks see https://github.com/inaturalist/design/issues/35. Currently going with 2.0 from there. This is mostly just an implementation todo list.

[x] bootstrap3: https://github.com/inaturalist/inaturalist/issues/674 (mostly done, just not deployed, but done enough to work from)
[x] support custom font (Whitney)
[ ] hero
[ ] how
[ ] science
[ ] value props
[ ] people
[ ] call to action

Just posting links to the icons, their licensing info and whether or not they were modified:

girl (modified): https://thenounproject.com/term/girl/69716/
spy (modified): https://thenounproject.com/term/spy/69739/
geek (modified): https://thenounproject.com/term/geek/69709/
butterfly (modified): https://thenounproject.com/term/butterfly/138812/
moth (modified): https://thenounproject.com/term/moth/17111/
cloud video (modified): https://thenounproject.com/term/cloud-video/68234/
group (modified): https://thenounproject.com/term/group/176403
owl (modified): https://thenounproject.com/term/owl/123996
bee (modified): https://thenounproject.com/term/bee/182489
honeycomb (modified): https://thenounproject.com/term/honeycomb/5568
cowboy hat (modified): https://thenounproject.com/term/cowboy-hat/156402
glasses: https://thenounproject.com/term/glasses/30742
megaphone (modified): https://thenounproject.com/search/?q=megaphone&i=169426

All assets have been uploaded here:
https://www.dropbox.com/home/iNaturalist/Design/Homepage
For the How It Works illustrations I created SVGs which I've tested on the latest versions of safari, chrome, and FF. I can always create bitmap versions, if needed.

@pleary, one part of this is displaying three stats:

total number of observations
total number of observed taxa
total number of registered, unsuspended users

I can get 1 from http://www.inaturalist.org/observations.json, but I'm wondering, is this something we can get from your work on opening up stats_adequately_scoped? Or are there other existing endpoints I can use? If not I'll just make one. We could also change 3 to total number of observers, or maybe total number of observers and identifiers, if though I suspect those might actually be harder.

I haven't changed anything yet, but we could in theory just remove most or all of the stats_adequately_scoped? method and you could hit the existing observations/taxon_stats and user_stats endpoints which should give you number of observed taxa and number of observers respectively. There is nothing yet that just counts users, as far as I know, aside from admin/stats.
The fastest way would be to get both from a single ES query, which would do a lot less and be a lot faster than calling taxon_stats and user_stats which query for other things:
Observation.elastic_search(size: 0,
  aggregate: {
    distinct_taxa: { cardinality: { field: "taxon.id", precision_threshold: 10000 } },
    distinct_observers: { cardinality: { field: "user.id", precision_threshold: 10000 } }
  }).response.aggregations

That would give you # observed taxa and observers. We don't have the data in ES for "total number of registered, unsuspended users", so you'd need to query the DB for that: User.where("confirmed_at IS NOT NULL AND suspended_at IS NULL").count

Looking so good... I'm working on the photos now.
Punch List

[ ] Slideshow: The shell should be second with the correspond blue box and the bird should be last with it's corresponding yellow box

[ ] Remove usernames because it's too wordy

[ ] The ob photos themselves should link to its ob

[ ]  Works on All Your Devices section needs a 30px trimming on the bottom (See blue guide)

[ ] Works on all devices image: Shouldn't go to the left beyond this point. See screenshot...

[ ] Works on all devices text: it shouldn't go beyond this point. See screenshot...

[ ] Works on all devices blurb: We talked about adding "...or wifi." or something like that to make the blurb fit the space better. Plus, I think it's good we mention wifi.

[ ] Who Uses iNaturalist?: Since we're going with longer quotes I would make the slide pause for 6 secs even though folks have control over the slider. Lots of times they miss it

[ ]  Who Uses iNaturalist?: Title and location need the following styles and arrow icon...

[ ] Slide Indicators: Need the following styles...

[ ] This button should be 60px high. Right now it's only 55px. After making it larger, please ensure it is vertically middle-aligned within the button

The profile photos ready and here on dropbox:
Design / Homepage / Quotes

[ ] Link in "Contribute..." needs to be white with underline

[ ] Join button needs to go back to Whitney Book

[ ] Value Prop Spacing: Can we make the icons a little closer to their blurbs and more space in between the two columns so it's clear which icons are referring to which text.

[ ] The quote person's name needs 8px of padding below it.

[ ] There needs to be about 50% more space between the "...reception or wifi." and the play store buttons.

...and then I think that's a wrap!

Wow, I finally took at look at the few images I could see on github and it looks AWESOME! I am so excited to see this for real! Will it go on gorilla first or are you going to surprise us?

@carrieseltzer thanks! I am very excited to see it launch as well :)

Yeah, excited to see this... of course :)
On Tue, Sep 29, 2015 at 11:32 PM, joellebel<EMAIL_ADDRESS>wrote:

@carrieseltzer https://github.com/carrieseltzer thanks! I am very
excited to see it launch as well :)
—
Reply to this email directly or view it on GitHub
https://github.com/inaturalist/inaturalist/issues/691#issuecomment-144272883
.

--
Charlie Hohn
Montpelier, Vermont

After seeing it on gorilla (thanks Ken-ichi!), a few comments/suggestions:
-Add commas to the stats of observations, users, and species. It's easier to read numbers that way.
-Hero images in the top carousel don't link out to functional links (search mole) but I'm guessing that's just because it's gorilla and it will work on the real thing.
-Make link to GBIF open in a new tab?
-User slide carousel moves a little fast--maybe add 1 more sec?
-Danielle should write something in her profile.
Slightly OT: The heat map of all observations (http://www.inaturalist.org/observations/map) is really not easily accessible, but it's a super cool thing to explore. I'd love to see it featured more prominently somewhere on the site.
Really great work! What's the expected release date?

Add commas to the stats of observations, users, and species. It's easier to read numbers that way.

I see commas. Screenshot and browser?

Hero images in the top carousel don't link out to functional links (search mole) but I'm guessing that's
just because it's gorilla and it will work on the real thing.

Gorilla's DB is just out of date, will update.

Really great work! What's the expected release date?

Soonish.

You're right, I see them in Chrome and Firefox but not in Safari Version 8.0.7 (10600.7.12). Screenshot below.

Commas also missing from mobile safari. Is there a mobile view plan for the new homepage?
—
Sent from Mailbox
On Wed, Sep 30, 2015 at 12:48 PM, Ken-ichi<EMAIL_ADDRESS>wrote:

Add commas to the stats of observations, users, and species. It's easier to read numbers that way.
I see commas. Screenshot and browser?
Hero images in the top carousel don't link out to functional links (search mole) but I'm guessing that's
just because it's gorilla and it will work on the real thing.
Gorilla's DB is just out of date, will update.
Really great work! What's the expected release date?
Soonish.

Reply to this email directly or view it on GitHub:
https://github.com/inaturalist/inaturalist/issues/691#issuecomment-144473113

Ok, try gorilla again. I think I dealt with the Safari issues.

Yep! Commas are there on mobile and non-mobile safari.

[ ] Please capitalize "Uses" in "Who uses iNat.." for consistency
[ ] All body copy should be 500 weight. Light will hardly be used on the site so maybe 500 weight should be "normal"? Up to you. (I just dont want light to sneak it's way back in there ;).
[ ] Please change color of headings to #1A1A1A
[ ] Slideshow: Please make the icons and text blurbs in the boxes clickable to their corresponding Meet, Explore, etc.  pages.


WC -/+ buttons in variable product

There is a bug with -/+ buttons in variable product page https://dev.bootscore.me/product/variable-product/
@Lo1176 any quick idea how to fix that?

What's the bug? They work fine on my device.

This solve it, but has to fine-tuned with media queries:
// Variable products
form.variations_form.cart {
    flex-direction: column;
}

.woocommerce-variation-add-to-cart.variations_button {
    display: flex;
}

Well done 👍
Sorry I wasn't reactif.
I'm recording a band this week. I'm not at home and I don't have my laptop
with me.
Le lun. 14 févr. 2022 à 10:40, Basti @.***> a écrit :

This solve it, but has to fine-tuned with media queries:
// Variable productsform.variations_form.cart {
flex-direction: column;
}
.woocommerce-variation-add-to-cart.variations_button {
display: flex;
}
—
Reply to this email directly, view it on GitHub
https://github.com/bootscore/bootscore/issues/100#issuecomment-1038848163,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANQPKLCW3H5Z3D23TJXUNXDU3DCYZANCNFSM5OKVY66A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


CLI flag to configure tx ban duration

New CLI flag --tx-ban-seconds to configure transaction ban duration. Defaults to 1800s which is the current default value.
If not explicitly specified and --dev is used, the value will be set to 0.
Closes #9921
cumulus companion: https://github.com/paritytech/cumulus/pull/1436

bot merge

bot merge

Can we backport this to 0.9.26?

We are not replacing the one in Rotator. Isn't this a problem?
https://github.com/paritytech/substrate/blob/43fd9a9dc2ba2644f88531b52a196a4f0800c2bf/client/transaction-pool/src/graph/rotator.rs#L49
either way, the "magic" constant of Duration::from_secs(60 * 30) is repeated twice, it should be a shared const at least.

should I just delete the Default for PoolRotator?

Actually it is fine as it is, I hadn't seen the fn new and thought we are using default to instantiate this.


Add setters for entities messages to allow custom messages

I needed to set custom messages instead of displaying the one received from JSON. So I added some setters in the models to be able to customize the message, if needed.
However, the message remains by default the one received from JSON.

Can you explain your use case a bit more? Would this be a scenario where you do not control the JSON file?

Ok, no problem :)
The message displayed in my Dialogs are chosen by the design & marketing teams and are always the same (except the "alert" one). So whatever another person set in the JSON file, I have to display the exact same message each time.
Allowing to set them in my code instead of in the JSON file removes any possibilities of typo/error in the JSON file and stick to the specs I have.

I think using the custom deserializer would allow you to accomplish the same thing, have you tried that path?

Yep. I wanted to do it this way the first time. But after thinking about it, I ended to this :

Writing custom deserializer force me to manually parse my object and so Gson becomes a little less useful.
The deserializer goal is to parse JSON string to a POJO, nothing more.
And the more important for me : I was not really OK to put "business related" code inside a deserializer.

I like to separate the "network layer operations" (like deserializing JSON string) from "business rules" (like displaying a default message).
In my app, the deserializer is not customized : my coworkers understand that I use the default JSON format provided by your documentation. Then, when displaying the AlertDialog, I have something like this : requiredUpdate.setMessage(context.getString(R.string.versioncheck_required_update_message)); and so my coworkers can understand why the message displayed is not the parsed one.

Alright I understand now, I think to accommodate this requirement it would be nice to keep the custom strings all in one place. What about adding the messages to the DialogStringHolder?
When the dialog is shown, it checks the strings holder to see if one was provided, if it was that string will override any message coming from the JSON. For this use case the library basically becomes a version checker without the ability to customize the message.
It's an interesting use case as you will need to issue an app update to change the messaging.

Good idea. Will try that and commit the result :)

Try a new way. This code works in my app :) I actually think your idea was better : is the implementation ok for you ?
I approve the use case is interesting, forcing an app update to change the message. However, the choice to do it this way is on the user hands now, not in the library ones.

Looks good, I'll cut a new release when a get a sec. Thanks for all the contributions! Keep em coming.

Approved


small typo in example site

in line series example refers to 'point' both in the code and description (instead of 'line'). Also in bar series code below, it has var point (instead of var bar)

Thanks for spotting these typos - I'll fix them shortly :-)

Fixed in #380 - please reopen if you disagree.


Print response body on failure; properly close response body

Hey Jess, your backend returns 403 for me so I needed this to know why.
so btw, it's daily usage limit exceeded.

Looks like this needs a rebase (I see there's a merge-conflict)


Android?

Hi,
This is an amazing thing you're doing here, I wonder if you considered an android port?
Would be the next cross-platform framework that would rule them all 😁

Yup that's the plan! https://github.com/Jasonette/JASONETTE-iOS/issues/9
Let's keep this issue open just because I feel like this will turn into a FAQ :)

Hi, I already commented on HN, but thought I would follow up here.
I am very interested in working on the Android port of this, but as this is "JASONETTE-iOS" do you mind creating a "JASONETTE-Android" which we can fork and start working on?
It would be great to keep it all under the same banner.

OK, kinda getting overwhelmed with all the issues so gonna close this for now, since I think my answer (YES) resolves it.
Before I close, let me clarify the roadmap: The plan is to release a rough draft version of Android as soon as I can. In order to move faster, I will try to only cover the skeleton (layout rendering, state machine, template engine, and minimal actions and components) and open it up as soon as those are ready, and hoping that we can quickly improve upon it and add things like additional components and actions then.

Guys, as promised, I'm ready to show something, and sharing here first. Ping me on Slack if you have Android!


flags constructors

All the java.time structures were created, except Clock. About path, a default parameter value isn't enough to define if the path must be already existent?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Excellent work!
As for path, I think two parameter values in a case class are enough: does it exist, and is it file or directory. Then we can have helpers to construct the common cases: it does not exist, it does exist and is a file, and it does exist and is a directory.


use FSharp.PPrint via nuget

pprint-for-fsharp is currently a dll https://github.com/FStarLang/FStar/blob/master/bin/FSharp.PPrint.dll. We should turn it into a nuget package instead, and pull it in from there instead.

Work is being done on the https://github.com/FStarLang/FStar/tree/sishtiaq_pp branch.

https://www.nuget.org/packages/PPrintForFSharp/
https://github.com/FStarLang/FStar/commit/1504251ce399bd9ebf24a0b1d9591dbf834ba610


'Result' does not contain a definition of 'Ok'

This library looks like it would be very helpful for a project I manage, however I can't get it working.
The project is a C# WebAPI (REST service) project being developed in Visual Studio 2017 (Enterprise Edition) and targets the 4.7.2 version of the .NET Framework.  I installed version 1.6.0 of FluentResults using the NuGet Package Manager built into VS.
In order to just test it quickly I looked at some of the unit tests in the GitHub repository (specifically, the ResultWithValueTests.cs file) and tried adding the following line in a method:
c# var okResult = FluentResults.Result.Ok(5);
This was taken from line 35 of the ResultWithValueTests.cs file.  But the above line causes an error which states:
'Result' does not contain a definition for 'Ok'

and the code of the error is CS0117.
I tried clone the FluentResults repository directly from GitHub through VS 2017 and it works fine.  The line does have any problem, but when I try it in my own project.
If anyone has any idea or suggestions on why I a getting this error or what a possible solution is, I would greatly appreciate it.  This library seems like it would help streamline a lot of things in my project, but I can't even get a single line of code to work.
Thank you in advance for any assistance.

Hi.
In v1.6 the factory methods like Ok or Fail are in the static class Results with a s. Results.Ok(...) should work.
I updated already the readme because I will publish v2.0 of fluentresults on nuget in the next days.
Sorry for the misunderstanding.

Here is the old version of the readme https://github.com/altmann/FluentResults/blob/a83c92a67024313189621224aaf543ac2ad50caa/README.md

@altmann The error did go away when I used FluentResults.Results.Ok(5); but I still don't understand why in the unit tests class from the GitHub repository Result.Ok(5) (without an 's') works correctly.

In v1.6 the class Results is used. v1.6 is published on nuget. You used this version in your project and therefore Results.Ok() worked and Result.Ok() not.
In the current master which you see on github are already most of the changes included which will come in v2.0. v2.0 is until now not published on nuget. For example you see the new method Result.Ok(). Results.Ok() ist deprecated in v2.0. You also see already the readme of V2.0 therefore you see Result.Ok() in the readme and not Results.Ok().
Once again sorry for the misunderstanding. I know its not a good situation to see on github the readme of v2.0 althought v2.0 is not published yet in nuget.
Hopefully I find tomorrow some time to publish v2.0 on nuget so that the published version and the readme in github is in sync.

No problem.  Thank you for the clarification.  I have it working with the initial things I wanted.  I will let you know if I come across any further issues.
Thank You

@dmarciano FYI: I published today v2.0 of FluentResults. Documentation (readme) on github is now in sync with the published version on nuget.


HERE COMES AGAIN AND AGAIN...( ERROR )

We need a hero to fix it

Always shown the error after the new version's update :(

it's not working anymore

Always shown the error after the new version's update :(

That's normal

Waiting for an update, bro.

please fix it

please fix it

please fix <3

That's normal when there is an update.


please alias jsdoc doc comments to variable assignments

Suggestion
🔍 Search Terms

typescript alias jsdoc to variable assignment
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Please copy JSDoc data to aliased variables.
📃 Motivating Example
/** Call this in order to something. */
const foo = (s: string): number => 123

const f = foo

f // hovering on 'f' does not show the documentation description "Call this in order to something."

playground
💻 Use Cases
Make documentation easier. All projects need good documentation!
Workaround:
an author can copy/paste duplicate JSDoc comments. This is harder to maintain.

Just in time! I was looking for exactly this now. I tried several JSDoc options but nothing seems to be able to copy the description the right way (@typedef, @inheritDocs, @borrows, @augments, …)

Is more feedback needed from me? Or from a team member? Not sure what the tag implies.

Could this also be applied to type aliases too?
/**
 * This is a type
 */
type Foo = string | number

type Bar = Foo

// hovering on 'Bar' does not show the documentation description "This is atype"
export { Bar }

This is especially useful for types in jsdoc
/**
 * @typedef {import('vscode-languageserver-types').Range} Range
 */

// jsdoc information is lost for 'Range'
/**
 * @param {Range} range
 */
function handleRange(range) {}

/**
 * what his type is about
 **/
export type Foo = () => void

const foo: Foo // `foo` should get `Foo` jsdoc if itself does not have one.

Big props to this... If i get another sermon about semantic reasoning from my boss I think I shall surely die... He's all about those multilevel type aliasing, type branding and guarding and now he's worked out that with async/await everywhere... those type guards are getting very very very composed... unlike myself.

Here's a video showing the issue:
https://user-images.githubusercontent.com/297678/224135023-6bc4b96a-042b-4f43-845d-f9fac7aa1e64.mov
The composition of things into an API (f.e. returning an object of things in the video) does not carry any useful information along with it.
The end user of the returned object does not see any meaningful documentation.


How to detect a button with pigpio and python

Hello
I am a newbee and I don't see how to detect a button with the pigpio library using python ?
I would like my python wait until the button has been pressed
thanks for a little example
best regards
Yves

@yves67 First set the desired pin mode as input. Next, if your hardware requires either pullup/pulldown, enable that. Either poll the pin using a read or use a callback for pin state change notification.

THANKS for your answer, I just discover the pigpio library this afternoon....
If I use callback, does that mean my script will be in wait state until the button will be pressed ?
in fact I am looking for a solution like an interrupt
I will look at the callback function
thanks again for your help
Regards
Yves67

@yves67 You will need to create your own "wait loop" since the callback is not blocking. When a state change is detected by pigpio it simply calls your callback function. You can call sleep with a very short delay in a loop.

OK, I have read some examples of the callback, I will test it tomorrow
Thanks for your help, I have understand the idea
Best Regards
Yves

Thanks a lot, it is working....
Regards
Yves67

Glad to have helped. You might want to close this issue if it is resolved.


add configuration about assert stmt in code generation

This PR is to add build configuration of whether generate assert statement.
The reason is that assert statement could hurt performance, but still useful for debug purpose.
Please see the discussion here.
https://discuss.tvm.ai/t/disable-assert-in-runtime/2152
About the code change, I am not quite sure my PR is a best way to achieve the goal,
such as the location and name. So welcome fix and suggestions!
Thanks,

We want this to be a runtime option in the codegen (through build_config), instead of the macro that is configured during compile time.

@tqchen .Thanks for the feedback. It seems there is a misunderstanding.
Just to confirm, do you mean to have an option in the tvm::build_config() API to have the assertion on or off ?
Thanks,
-W

yes

That means python/Java API also need to change accordingly ?

@baowenlei I am interested in the performance. Do you have the data between disabling assert and enabling assert? Thanks.

@FrozenGene Cannot recall any particular number, but the difference is obvious and users would like to avoid any cost of that IMO. Thanks.

@baowenlei, please update the PR.
It would also be nice to do some benchmarks, my guess is that these assertions won't create additional cost due to the bigger overhead in the kernel loops

@baowenlei I wish we could have benchmark. Because I try to one convolution. I don't notice the improvement.

ping @baowenlei

@tqchen @FrozenGene Thanks for the feedback.
It seems that we do not have any record of the difference.
But the problem is that for release version of the code, the assertion will be gone.
However, here the assertion is instrument in llvm level, which will exist in either release or debug version.
The point is that user should have option to have it in their generated code or not.
Regarding to the PR, I am sorry I recent does not have time to work on that. Tight with other works. But I will update that once I got time. Feel free to close this for now.
Thanks!

close for now due to inactive status

Thanks @FrozenGene @baowenlei


read_snirf_aux_data() / _decode_name() fails when name of aux channel is string scalar

Describe the bug
According to the snirf spec strings should be stored as as scalars, not as 1x1 arrays.

The example aux dataset  used in the aux tutorial has strings in 1x1 array.

The read_snirf_aux_data() function works fine with this dataset that has strings in 1x1 array, but when the name of aux channel is scalar the _decode_name() function fails.
https://github.com/mne-tools/mne-nirs/blob/2fdddfe9962ad000ebe60d71d0f9794d1800acbd/mne_nirs/io/snirf/_aux.py#L62-L63

To properly retrieve the scalar string,
Steps to reproduce
Can use this file (ignore other possible issues with the file):
04_single.zip
import mne
import mne_nirs

snirf_file = r"04_single.snirf"
raw = mne.io.read_raw_snirf(snirf_file)
raw_od = mne.preprocessing.nirs.optical_density(raw)
raw_haemo = mne.preprocessing.nirs.beer_lambert_law(raw_od, ppf=0.1)
aux_df = mne_nirs.io.snirf.read_snirf_aux_data(snirf_file,raw_haemo)

Expected results
Should work since strings are stored as scalar, in accordance with snirf spec.
Actual results
Fail since _decode_name() only works on arrays
Additional information
Could add conditional to check if it's a scalar, and in that case handle it as such, e.g.:
def _decode_name(key):
if key.shape == ():
return key[()].decode()
else:
return np.array(key)[0].decode()

I got a little confused during testing becuase the official snirf samples are also incorrect, in their own way, c..f. https://github.com/fNIRS/snirf-samples/issues/9
Given I'm reading the snirf spec correctly the example file I provided should have the correct string format.


substantial difference between the test set and the validation set

After submitting the test set, there is a significant discrepancy between the performance metrics for pedestrian classification and those observed on the validation set. What could be the cause of this situation?
test：Pedestrian (3D Detection) | 40.74 % | 33.57 % | 31.32 %
val： Pedestrian (3D Detection)   57 7975%、52.4494%、49.2018%

I trained the model according to the original configuration in pointpillar.yaml, splitting the dataset into 80%-20% and 50%-50% for training and validation, respectively. Despite my efforts, when submitting the best results to the KITTI official for evaluation on the test set, I consistently fail to achieve metrics close to those reported in the original paper. The discrepancy is particularly noticeable for pedestrian and cyclist classes.
Pointpillar：Pedestrian (3D Detection) | 52.08 % | 43.53 % | 41.49 %
mine：Pedestrian (3D Detection) | 42.86 % | 36.09 % | 33.53 %
What reasons could be causing this situation?  thanks！ @sshaoshuai


PHPStan - require version 0.8.5 or higher

Version number is then correctly displayed by executables from composer.
https://github.com/phpstan/phpstan/issues/160#issuecomment-322040877

Merged, thank you.


Error: requested resource not found

A minor code change introduced in the recent PR causes errors during application of TF plans:
Terraform v0.14.11
Initializing plugins and modules...
module.alerting_rules["dummy.yml"]: Destroying... [id=dummy]

Error: requested resource not found

TF logs contain the following:
2021-12-02T08:42:58.077Z [INFO]  plugin.terraform-provider-cortex: 2021/12/02 08:42:58 [DEBUG] DiffSuppressFunc: timestamp=2021-12-02T08:42:58.077Z
module.alerting_rules["dummy.yml"]: Refreshing state... [id=dummy]
2021-12-02T08:42:58.079Z [INFO]  plugin.terraform-provider-cortex: 2021/12/02 08:42:58 [DEBUG] cortex API Request Details:
---[ REQUEST ]---------------------------------------
GET /api/v1/rules/dummy_group HTTP/1.1
Host: ...
User-Agent: Go-http-client/1.1
Authorization: Basic ...
X-Scope-Orgid: ...
Accept-Encoding: gzip

-----------------------------------------------------: timestamp=2021-12-02T08:42:58.079Z
2021-12-02T08:42:58.143Z [INFO]  plugin.terraform-provider-cortex: 2021/12/02 08:42:58 [DEBUG] cortex API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/1.1 404 Not Found
Content-Length: 21
Alt-Svc: clear
Content-Type: text/plain; charset=utf-8
Date: Thu, 02 Dec 2021 08:42:58 GMT
Vary: Accept-Encoding
Via: 1.1 google
X-Content-Type-Options: nosniff

group does not exist

The cause of this behaviour is that we try to read the resource again after deleting it through Cortex API.

Fixed in https://github.com/form3tech-oss/terraform-provider-cortex/pull/6
Released in https://github.com/form3tech-oss/terraform-provider-cortex/releases/tag/v0.0.5


[pmo] Teach pmo to ignore debug instruction uses.

Just noticed this while trying to figure out why a change I was trying to make
in capture promotion wasn't optimizing loads away.

@swift-ci test

@swift-ci test

NOTE: This just causes us to promote loads, we still are very conservative at -Onone about eliminating the actual allocations. In fact, we do a check based off of the debug info attached to the allocation rather than relying on debug instructions like these. So nothing has changed beyond we will promote more loads.

NOTE: This just causes us to promote loads, we still are very conservative at -Onone about eliminating the actual allocations. In fact, we do a check based off of the debug info attached to the allocation rather than relying on debug instructions like these. So nothing has changed beyond we will promote more loads.

Build failed
Swift Test OS X Platform
Git Sha - b54ae54987cc59f416041ba401fb336273af990d

Build failed
Swift Test OS X Platform
Git Sha - b54ae54987cc59f416041ba401fb336273af990d

@swift-ci test

This is a pretty safe commit. Going to do post-commit.

lgtm


[Update Request]: MullvadVPN.MullvadVPN to version 2024.1.0

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
MullvadVPN.MullvadVPN
Package Version
2024.1.0
Please describe the changes you would like to see
There is a new release (2024.1.0) available.
Download Page Url: https://github.com/mullvad/mullvadvpn-app/releases/tag/2024.1

another update is not available through winget: https://github.com/mullvad/mullvadvpn-app/releases/tag/2024.2

Already open under #151443


feat: migrate workbox-webpack-plugin to typescript

Prior to filing a PR, please:

open an issue to discuss your proposed change.
ensure that gulp build && gulp lint test passes locally.

R: @jeffposnick @tropicadri
Fixes #2478
Description of what's changed/fixed.
This is a work in progress.
Couldn't get tests to run locally, and there are some @ts-ignore comments littered about in places that import things from workbox-build or workbox-google-analytics that I couldn't quite figure out.
I think getting this package to use the new TS version of workbox-build would get it almost ready to merge 🤞.
Feel free to push changes, or point me in the right direction to fix things :)

@roikoren755 Thank you for this, sorry for the late reply we've been doing some upgrading of TS lint and as you saw workbox-build migration to TS, I'll take a look at the PR and help where I can :)

This is far from ready, but I wanted to share the updates.

I merged with v6 branch that has the latest eslint version, we don't use @ts-ignore when we need to disable eslint we use // eslint-disable...
I reused the types from workbox-build instead of creating new ones
I setup the build to use compile with Typescript
Still fixing tests.

Let me know if you have any questions, thank you for your patience with this one.

Thanks! I'll take a look at this soon.


Update tests

These tests make this project more hackable, by fixing and eliminating noisy errors.

tests all pass
the parser is modified
the obscuring error is fixed
the npx browserslist@latest --update-db has been run.

This PR includes changes to app code!

I need to go over the legacy query-params processing carefully, to make sure I didn't short-circuit valid behavior.
In particular I notice the word Duplicate, that needs to be checked into.

I am tracking the remaining work that needs to be completed on the allowed query args here:
https://github.com/zingolabs/zecwallet-lite/issues/8

I can confirm all tests are passing for me locally, unlike the dev branch.

Fixes: #5

After reviewing this https://zips.z.cash/zip-0321#uri-syntax I am closing this PR in favor of a more incremental approach.


nixpkgs-review: 2.5.0 -> 2.6.0

https://github.com/Mic92/nixpkgs-review/releases/tag/2.6.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120108 at ecb137af run on x86_64-linux 1

1 package built successfully:

nixpkgs-review

1 suggestion:

warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/tools/package-management/nixpkgs-review/default.nix:26:0:
   |
26 |     description = "Review pull-requests on https://github.com/NixOS/nixpkgs";
   | ^


SITL Standard VTOL does not accept mission

We can't get the gazebo_standard_vtol do take off on current master.
ea138cfd380c06179d2e89cdd8167637dbd96d54
We only get "set mode command temporary rejected" in QGC."
And
"WARN  no GPS - navigator timed out"
in the console

Works on current master. Can you re-try?


Windows: [TP3] new hcsshim stdin/out/err handling

Signed-off-by: John Howard<EMAIL_ADDRESS>@swernli @jstarks
This PR is part of the proposal described in docker/docker issue 10662 to port the docker daemon to Windows. This moves the named pipe handling into Windows.

Rebased

@tiborvass Would you mind testing/reviewing this please?

@icecrime of course

Rebased again.

Rebased and moved to latest vendor commit for HCSShim

@jhowardmsft thanks! will review shortly

@tiborvass All comments addressed :)

Apart from one question around using path vs file name for layers (Ping @swernli), the code looks fine.
Didn't get to test it yet.

@tiborvass Thanks so much for reviewing, Tibor. I see you're scrutinizing HCSShim a lot, and we appreciate the feedback. Much of the feedback is though somewhat orthogonal to this PR, and we need to get this merged in order to submit the other required TP3 PR for the graph/graphdriver changes to avoid a multitude of merge conflicts and complexity. Is there anything outstanding I need to address for this PR? I think we got everything :)
@stevvooe @dmp42 @icecrime FYI.

@jhowardmsft yes, LGTM for the code, I just still don't have a windows build :( will send an email about it.

@jhowardmsft will need a rebase

@tiborvass Rebased

LGTM
There are a few comments inline that may help with reliability. I am worried a little about these copy operations "disappearing" and not having a solid way of debugging their behavior. Some clean up around error reporting may help with that.

Re "disappearing" - there are situations where there may be legitimate errors (such as a forced close of the window where docker run is, or during a system shutdown). The io.Copy call will block until the process in the container is exiting anyway. There's no need to log or return an error if any of these fail as it's sometimes expected and would be overly alarmist.
I'm just about to push with the updates from the comments.

Thanks @jhowardmsft, LGTM.


Bower info

When I run
bower info backbone-bootstrap-widgets
I have this error
/usr/local/lib/node_modules/bower/node_modules/q/q.js:128
                    throw e;
                          ^

Maybe, update the Q librairy version ?

Q seems to be a bower thing. You will have to fix that.
(one of the reasons why I truly hate bower - fixing issues with it instead
of working on real things)
On Thu, May 21, 2015 at 10:58 AM, Allan Bettarel<EMAIL_ADDRESS>wrote:

When I run
bower info backbone-bootstrap-widgets
I have this error
/usr/local/lib/node_modules/bower/node_modules/q/q.js:128
throw e;
^
Maybe, update the Q librairy version ?
—
Reply to this email directly or view it on GitHub
https://github.com/AmiliaApp/backbone-bootstrap-widgets/issues/9.

Due \n, Fixed in #10


Date and event appearance confusing

Days and events are separated by a line.
Mon

John's birthday
Tue

As you can see, John's birthday looks like it's on Tuesday, but it's on Monday. It's visually confusing.
I think the event and the day should not have a line separating them as below.

Mon
John's birthday

This clearly shows that John's birthday is on Monday.

I agree that current design may be confusing for somebody.
But that was designed many years ago and many users (including myself) are accustomed to this for a long time...

Really? You agree that it's visually confusing, in other words, the UI design is flawed, but users are 'used to it' so you'll leave it as it is?  In my mind there is no question that it should be changed. To me, it makes absolutely no logical sense to leave it as it is. But, this is your app.
Seriously, this is a deal breaker for me. I would scrap the other apps I use and change to this if it weren't for the UI.

I don't think it's so simple. As I see in GIT history, this design was created more than seven years ago, and I don't remember similar complains yet.
This doesn't mean that this design shouldn't be changed. But this means for me that the decision shouldn't be taken lightly.

I understand. Oh well, I don't suppose there will be anyone else coming in with the same opinion now if I'm the first one in 7 years. Shame.
Thanks.

As you can see on this screenshot, today is easily visible in the upcoming versio
https://github.com/plusonelabs/calendar-widget/issues/124#issuecomment-526298994
I will think about an option to have Day Header separator above the header text.

@bushrang3r  I found an old issue that asks exactly for the same: #154
So I think that I will change placement of the "Day header separator" without any "options"...

Thank you〜


Managed swiftlint integration

PR inspired by issues #23 and #25
As of now danger-swiftlint doesn't know which version of swiftlint is installed on the host computer, it either expect it to be already installed or it installs at runtime using brew install swiftlint. The problem of this is that we can't predict which version of swiftlint is installed and therefore we don't know if it will work or not with the arguments and configuration we are running with. This situation leads to a potencial flaky behaviour increasing the maintenance burden.
What I want to explore in this PR is a different way to install swiftlint on the host computer and ensure that it will be always using a predicted version. Instead of relying on a global installed  swiftlint application I wanted to bundle the swiftlint application together with danger-swiftlint as a gem extension. This way everytime the user install danger-swiftlint it will also be installing a particular version of swiftlint that comes with it.
As a consequence of pairing danger-swiftlint with swiftlint I think it makes sense for them to use the same version number. Meaning if you install<EMAIL_ADDRESS>you will be using<EMAIL_ADDRESS>everytime you run your dangerfile.
@ashfurrow I would be happy to hear your feedback if you think it makes sense.
Following is the list of tasks that I am expecting to tackle:

[x] Sync danger-swiftlint and swiftlint versions
[x] Update the gem to build swiftlint native extension
[x] Update the plugin to use the extension interface to run swiftlint
[x] Ensure tests are still passing

With these changes when the user runs gem install danger-swiftlint during the build process gem will download the portable_swiftlint.zip file present on the release and store that close to the gem to be used at runtime.
Here is how the command output would look like:
gem install ./danger-swiftlint-0.16.1.gem
Building native extensions.
Successfully installed danger-swiftlint-0.16.1
Parsing documentation for danger-swiftlint-0.16.1
Done installing documentation for danger-swiftlint after 0 seconds
1 gem installed

The line
Building native extensions.  This could take a while... is when it is downloading the portable zip file from the github releases page. After that danger-swiflint will have its own version of swiflint to use

Updated changelog @ashfurrow  =)

Thanks for merging, looking forward to see how the new model performs into the wild. I'll extend the README to explain better the relationship of this library with swiftlint (versioning, isolated install, etc).

Cool cool, thanks for contributing!


Fix type narrowing when if returns

Purpose

Consider the narrowing of types when the previous if statement returns.

Fixes #39914
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Differed till the next RnD cycle (2024).


customize objective function

I want to build my own objective function, which need to use the softmax results as the input. I add a function in the objective.py, just follow the function categorical_crossentropy, and it can run.
However, when I directly put the predict softmax result to the objective function, the result is different from the model.fit function. I use the same weight to do the test.
I wonder how the model.fit function compute the loss, is it  different from the objective function? Or the input of the objective function is not the softmax results?

I have fixed it already. The reason is that I use a dropout layer in the network.


Occasional bad frames under heavy multi-camera use

When pulling a 1920x1080 rgb8 stream @ 15 FPS && 640x480 z16 @ 30fps, several bad frames are produced. These can be checked for using additional dinghy checks and discarded.

This issue was resolved in 96d3c9f2249a8303135203cfb381bcdcaa0ee913


I Cannot Change Font Family in 1.9

I cannot change fonts in brackets Release 1.9 build 1.9.0-17312 (release 189f6d39a) previous version i can change properly but after install new version i cannot.
actually i change default font to "consolas" it changed but font size is being very small. after i increase font size change font automatically to default font. how can i fix this?
Note : I check "reload without extension" but it helpless

@imbhavin95 Actually we have fixed this issue and also did a pre-release.
You can download the stable pre-release from https://github.com/adobe/brackets/releases/tag/release-1.10-prerelease-1

Yes @saurabh95 i do this and it's now working. Topic Closed.
Thank you.


LUCENE-10016: add support for Knnvector index and query to the demo

The intent of this is to provide an end-end example of how to use KnnVector capabilities. It builds on the previous KnnVectorQuery pull request; I think all of those changes will be shown here as well; sorry it's a little messy because of that; please only look at the changes in the demo module.

Hmm I had a spotless problem that didn't show up when I ran check locally or precommit? Also locally I am getting a rat failure:
Execution failed for task ':lucene:demo:rat'.
> Found 1 file(s) with errors:
    - Unknown license: /home/ANT.AMAZON.COM/sokolovm/workspace/lucene/lucene/demo/src/test/org/apache/lucene/demo/test-files/knn-dict/knn-token-vectors

which is totally reasonable (how does it know!). I can see I need to add the pddl-1.0 license to the lucene/licenses folder to cover that content (which is from GloVe) but how can I assert that the contents there are covered by that license?

I think I understand the license check code after looking at the gradle files for it, but would appreciate some eyes (@dweiss). I excluded the GloVe data file because it is released under the public domain, meaning they waived all rights. Still I think it's good to give credit and include the license file? There is a reference in the package javadocs, but the format of the file itself doesn't lend itself to inline comments.

I think it might be better we have two separated PRs, one for the Query part and another for the demo example (for review)?

I think the KnnVectorDictFilter is a great example to show how full-fledged applications look like! (To me, it is worth having them within "misc" or "sandbox" module.)
Meanwhile, a minimum, off-the-shelf demo that just indexes and searches some pre-trained vectors might be useful for testing or just trying it out without external models?

[FWIF] As for GloVe license, we have EnwikiContentSource in benchmark module that parses/analyzes Wikipedia dump (XML), just like KnnVectorDict recognizes GloVe format; we don't include any Wikipedia license as far as I know.

I'm open to moving the KnnVectorDictFilter somewhere else, maybe sandbox is appropriate, but I do we want to keep demo dependencies minimal?
Re: licensing. I'm happy to do whatever is right; thought I'd err on the side of caution and provide some attribution.
@mocobeta  your idea for a more standalone demo is intriguing; I struggled a bit with how to provide meaningful vectors without dumping in a huge amount of data. So what I did was to take the GloVe vectors and join with the terms that occur in the demo documents.

I was also thinking about how do we (and users) obtain the example vectors data if we provide a "standalone" demo besides the IndexFiles/Searches integrated one.
There are two possible options we could take:

Sample random vectors from uniform or normal distribution when performing indexing/searching.
Of course, the generated vectors are not meaningful at all - but one could say that the "meaning" of vectors is up to specific model or application, and what we provide is general "vector search" functionality anyway...

Generate word representations of some publicly available corpus (e.g. Project Gutenberg) by using GloVe; then include a small fraction of them within demo module distribution.
While proper credits are required, distributing a dataset that is converted from copyright-free texts and public domain embeddings (GloVe) would not be problematic, I think. (Though if we come into a somewhat difficult discussion on this, I wouldn't push this plan.)

So what we're doing here is different from the benchmarks since we're redistributing (a portion of) the GloVe data, unlike benchmarks which requires the user to download the wikipedia data (or does it for them).

I didn't notice that the fraction of GloVe data was included...; yes I think it would be great if we have some decent credits (or notice?) for it.

I rebased this PR since the underlying KnnVectorQuery was pushed to main and can no longer push it here without maybe messing up the history, so I'll close this and open a new one


chore: use valid SPDX license identifier

Source: https://spdx.org/licenses/

Thank you @brettz9!


Use Mac-specific checks for ncurses

With this change, I get a clean compile from source with:
autoreconf -fvi
./configure CFLAGS=-I$(brew --prefix)/opt/readline/include LDFLAGS=-L$(brew --prefix)/opt/readline/lib
make

On my Mac with Homebrew.
See #103.

This is great Ryan. Thank you!

@ryanfb I had to rewrite configure.ac to new notation (didn't work well on) - can you please check whether it works fine? Commit 10fca39.

@dvorka Works fine for me on OS X. Sorry I didn't get a chance to check my commit under other environments, I just assumed it would work (not too familiar with what's idiomatic for autoconf). Thanks!

@ryanfb no problem. Thank you for the verification :+1:


[EXP-132-332] rpc cache middleware

Performance improvements for faster parallel computing by adding an optional multi-chain RPC cache service:
https://github.com/mariuspod/hash-brownie

caches eth_getCode responses
caches eth_getLogs responses
returns a synthetized ABI for faster contract creation
persists received results on-disk
loads persisted data from disk to RAM on startup
integrates as web3 middleware and can be easily extended to other methods
grows incrementally
can be bootstrapped with a portable data file

The cache can be activated/deactivated by setting the env variable HASH_BROWNIE_HOST.
The docker-compose.yml contains two new service entries for eth and ftm and the cache data dirs are stored inside a separate docker volume.
The initial bootup is a bit longer because the results are persisted to disk, but any following runs are pretty fast.
This can also be used without docker by starting up the hash-brownie service and pointing the env variable to it.
For a transition period, I've kept the original joblib cache implementation which can be still used by unsetting the env variable and lazily removed.

closing this for now


fix pytorchWithCuda, fix cupy, upgrade cudnn

Description of changes
This PR accomplishes a few separate but related tasks:

Fix pytorchWithCuda. This is concurrent work to https://github.com/NixOS/nixpkgs/pull/166734.
Upgrade cudnn 7.6.5 -> 8.3.2.
Fix cutensor_cudatoolkit_{10,11}.
Harden the build of cupy, and enable parallel building.

Although I try to keep PRs as small as possible, in this case  it became clear that it was much more straightforward to make these changes simultaneously than separately. I understand that increases the burden on reviewers to some extent, but I tried to keep each commit as small as possible to ease the process.
This PR is the equivalent of https://github.com/NixOS/nixpkgs/pull/166533 but targeting master instead of staging.
According to nixpkgs-review this affects packages pytorchWithCuda, Theano, and cupy. I've confirmed that all of those nix-build successfully. For some reason, nixpkgs-review wip doesn't work in this case, but everything seems to build just fine.
Fixes https://github.com/NixOS/nixpkgs/issues/161843, https://github.com/NixOS/nixpkgs/issues/166403, and possibly others.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Breaks torchvision:

Weird it works for me:
❯ nix-build --max-jobs 64 -A python3Packages.torchvision
...
copying path '/nix/store/hrwag76jyxf72fc5rk74vnqw0pl8drbf-python3.9-torchvision-0.11.3' from 'https://cache.nixos.org'...
/nix/store/hrwag76jyxf72fc5rk74vnqw0pl8drbf-python3.9-torchvision-0.11.3

Perhaps we're doing something slightly differently? I'm building directly off of this branch (as opposed to grafting onto latest master)

Not sure if I'm doing something wrong or if this is an issue with the PR, but when I try to build pytorch with CUDA 11 on this PR I still get the error with "EmbeddingBag.cu."
{
  description = "my project description";

  inputs.nixpkgs.url = "github:NixOS/nixpkgs/2a0acdbe9f36e3dbf4e4cbcf867f2c1e990f781f";
  inputs.flake-utils.url = "github:numtide/flake-utils";

  outputs = { self, nixpkgs, flake-utils }:
    flake-utils.lib.eachDefaultSystem (system:
      with (import nixpkgs {
        config = {
          allowUnfree = true;
          cudaSupport = true;
          overlays = [
            (final: super: {
              cudatoolkit = super.cudatoolkit_11;
              cudnn = super.cudnn_8_3_cudatoolkit_11;
            })
          ];
        };
        inherit system;
      }); {
        devShell =
          let
            python = python39.override
              {
                packageOverrides = self: super: {
                  pytorch = super.pytorch.override {
                    cudatoolkit = pkgs.cudatoolkit_11;
                    cudnn = pkgs.cudnn_8_3_cudatoolkit_11;
                    magma = pkgs.magma.override { cudatoolkit = pkgs.cudatoolkit_11; };
                    nccl = pkgs.nccl.override { cudatoolkit = pkgs.cudatoolkit_11; };
                  };
                };
              };
          in
          mkShell rec {
            buildInputs = with python.pkgs; [
              pytorch
            ];
          };
      });
}

$ nix develop
...
error: builder for '/nix/store/wmf91pja41azq6mbnpfh55lvbsbscy8p-python3.9-pytorch-1.10.2.drv' failed with exit code 1;
       last 10 log lines:
       > /build/source/aten/src/ATen/native/cuda/EmbeddingBag.cu(178): here
       >
       > 41 errors detected in the compilation of "/build/source/aten/src/ATen/native/cuda/EmbeddingBag.cu".
       > CMake Error at torch_cuda_generated_EmbeddingBag.cu.o.Release.cmake:281 (message):
       >   Error generating file
       >   /build/source/build/caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/./torch_cuda_generated_EmbeddingBag.cu.o
       >
       >
       > [5588/6183] Building NVCC (Device) object caffe2/CMakeFiles/torch_cuda.dir/__/aten/src/ATen/native/cuda/torch_cuda_generated_TensorModeKernel.cu.o.o[KK
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/wmf91pja41azq6mbnpfh55lvbsbscy8p-python3.9-pytorch-1.10.2.drv'.
error: 1 dependencies of derivation '/nix/store/173gfp0vxwan4ihh88dh1k8rc7n99d4z-nix-shell-env.drv' failed to build

Not sure if I'm doing something wrong or if this is an issue with the PR, but when I try to build pytorch with CUDA 11 on this PR I still get the error with "EmbeddingBag.cu."

This is bc you're overriding pytorch with CUDA 11, which as of yet does not work. Once staging gets merged into master, we'll get the newer pytorch version, v1.11.0, which will be building with CUDA 11 by default. As to why the current pytorch version does not build successfully with CUDA 11, I have no idea unfortunately. It's very finicky to build :/

torchvision
... works for me
@samuela

You're right, the vanilla build succeeds, it's the overlay with cuda 11 that breaks.
It breaks because now calling pytorch with custom values, overriding just the unversioned top-level attributes has no effect and the torchvision build ends up consuming several versions of cuda.
This has always been a problem (e.g. with tensorflow), and there are old related problems (overriding cuda at the user site and forgetting to override cudnn) which we need to address, but don't need to address in this PR

pytorch with CUDA 11
@freemagma

I can confirm that pytorch 1.10 fails to build with cuda=11.5 (attempted hotfix with cuda 11.5) and succeeds to build with cuda=10.2 (this pr, and a hotfix on top of unstable, see neverBreak.vanilla.pyPackages.pytorch)
In my home config I'm building pytorch 1.10 from nixpkgs-21.11 with cuda 11.4 and it works, but I'm still struggling with master

Build succeeds with CUDA 11.3: https://hercules-ci.com/github/SomeoneSerge/nixpkgs-unfree/jobs/139
Torchvision succeeds in the overlay where cuda11 is used globally

there are old related problems (overriding cuda at the user site and forgetting to override cudnn) which we need to address, but don't need to address in this PR

It might be an idea to use passthru. For example, having cudnn in the passthru of cudatoolkit and add cudatoolkit to the passthru of packages using it. Another option is to make a cudaPackages set for each cuda version that contains cudnn and others and add that in the passthru of the cudatoolkit package. Similar to what we do with say Python.

It might be an idea to use passthru
... another option is to make a cudaPackages for each cuda version

Indeed, we've been considering both, the first as a temporary fix, and the latter as a longer-term solution.
In this PR the passthru is used for asserts which should already somewhat improve the experience.
Note that just dropping cudatoolkit argument in e.g. pytorch/default.nix and using the passthru does not eliminate the need for asserts, because all of magma, nccl, and cudnn bring in their cudatoolkit and need to be consistent.
The cudaPackages is probably the best UX we can get at the moment

For example, having cudnn in the passthru of cudatoolkit

Hmm, I see. Currently it's the other way around (cudnn has cudatoolkit in passthru). Also, there are several releases of cudnn in nixpkgs. Again, cudaPackages seems to be a solution

there are old related problems (overriding cuda at the user site and forgetting to override cudnn) which we need to address, but don't need to address in this PR

It might be an idea to use passthru. For example, having cudnn in the passthru of cudatoolkit and add cudatoolkit to the passthru of packages using it. Another option is to make a cudaPackages set for each cuda version that contains cudnn and others and add that in the passthru of the cudatoolkit package. Similar to what we do with say Python.

On the topic of a cudaPackages package set, check out the proposal here: https://github.com/NixOS/nixpkgs/issues/163704
Re passthru: I think that's absolutely the way to go for the time being. This PR is already rather beefy, so I'd prefer to accomplish that separately, but I totally agree that we ought to do so.

@FRidh @SomeoneSerge Created an issue to track the torchvision cudatoolkit discrepancy: https://github.com/NixOS/nixpkgs/issues/166948

If no one objects, I'll go ahead and merge tomorrow

python39Packages.caffe used to succeed and now fails with
caffe> -- Found cuDNN: ver. ??? found (include: /nix/store/jrj8x3764iq0iz2gqa1pdv24l08ihl6k-cudatoolkit-10.2-cudnn-8.3.2/include, library: /nix/store/
jrj8x3764iq0iz2gqa1pdv24l08ihl6k-cudatoolkit-10.2-cudnn-8.3.2/lib/libcudnn.so)
caffe> CMake Error at cmake/Cuda.cmake:221 (message):
caffe>   cuDNN version >3 is required.

python39Packages.caffe used to succeed and now fails with

Hmm I'm not seeing this:
ubuntu in threedoo in <IP_ADDRESS> nixpkgs on  samuela/cudnn3 took 16s
❯ nix-build --max-jobs 64 -A python3Packages.caffe
/nix/store/bbca44xgdj1nl19lzk70kni0hjdppagf-caffe-1.0-bin

Relaying a conversation from #cuda:matrix.org, there's an alternative pathway.
Instead of keeping cudatoolkit = cudatoolkit_10 and passing custom cuda, cudnn, magma and nccl to pytorch, we can do:

Major updates for both cuda and cudnn in this PR, fixing pytorch and cupy
In particular:

cudatoolkit = cudatoolkit_11 = cudatoolkit_11_4
cudnn = cudnn_8_3_cudatoolkit_11

There's a jobset running for this combination: 143. But I've already verified that the current pytorch (1.10) builds with cuda 11.3 and 11.4 (reminder: it has been failing with 11.5 and, apparently, 11.1; the EmbeddingBag.cu error)
We revert passing additional arguments in the call to the pytorch derivation (cudatoolkit, ..., nccl), simplifying the PR and keeping the simple interface for overlays. This we would otherwise still do later, because pytorch=1.11 wouldn't require overriding

When pytorch 1.11 (now in staging) reaches master, we set cudatoolkit_11 = cudatoolkit_11_5, which is a minor update from 11.4 to 11.5 (context: the new pytorch doesn't have trouble building with cuda 11.5)

I think in this case there will be exactly one package left that still uses cuda 10 (seems to be libtensorflow-bin)
I'm not opposed to either solution. I prefer this alternative

Hmm I'm not seeing this:
❯ nix-build --max-jobs 64 -A python3Packages.caffe

Interesting. Actually, I have not rerun the job for python310Packages.caffe (I had this cachix issue)
Can you check python39Packages.caffe?

Actually, just got the same error with python310. I'm wondering if I'm on the right branch 🤣

@SomeoneSerge I added a caffeWithCuda alias in https://github.com/NixOS/nixpkgs/pull/166784/commits/a60ab2a1c73453828f81d52a6a3fa3d4586c6fdf and it's building successfully now. I didn't change anything with caffe2 as that is marked as broken rn. So now everything is building successfully as far as I'm aware.

Major updates for both cuda and cudnn in this PR, fixing pytorch and cupy

I'm in favor of doing this, although I hesitate to include those changes in this PR as it has gotten so huge already. What if we merged this one and then followed up immediately after with a PR that bumps the cudatoolkit and cudatoolkit_11 versions? I believe that would get us the same end result but with smaller steps along the way.

I thought the major bumps would allow to drop some of the changes and reduce the size of PR... but actually, merging the asserts and fixing pytorch+cupy before cleaning up sounds tempting

I thought the major bumps would allow to drop some of the changes and reduce the size of PR... but actually, merging the asserts and fixing pytorch+cupy before cleaning up sounds tempting

Ah I see what you mean. Perhaps that is true. But I suspect that until we get pytorch v1.11 we won't be able to get out of specifying custom cudatoolkit versions since I don't think v1.10.2 supports cudatoolkit = cudatoolkit_11 = cudatoolkit_11_5. I'm not entirely sure though.

since I don't think v1.10.2 supports cudatoolkit = cudatoolkit_11 = cudatoolkit_11_5. I'm not entirely sure though.

This is why I was talking about a downgrade to 11.4

Ohh I see. sorry I misunderstood!


Automated Package Upgrade

:tada: This PR is included in version 26.0.87 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: add convention module

Codecov Report

Merging #3 (6dd9cde) into main (7d0ed77) will decrease coverage by 40.58%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main       #3       +/-   ##
===========================================
- Coverage   70.58%   30.00%   -40.59%
===========================================
  Files           3        4        +1
  Lines          17       40       +23
===========================================
  Hits           12       12
- Misses          5       28       +23

Impacted Files
Coverage Δ

src/project_release/convention.py
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more