PIM Editor changes post review

Praharsh Jaiswal

Update ERP Integration API Documentation for FFX. Praharsh Jaiswal**-WIP**

Label family at the top.Praharsh Jaiswal**-WIP**

Set default to one family.Praharsh Jaiswal**-WIP**

Segregate model family.Praharsh Jaiswal**-WIP**

Update CSVbox configuration in product editor bulk upload not working ke lie- New Sheet ID.Praharsh Jaiswal**-DONE**

Change the header for replacement to "Current product and replacement product." Praharsh Jaiswal**-DONE**

Remove time.Praharsh Jaiswal**-DONE**

Current stock code EOL (End of Life).Praharsh Jaiswal**-DONE**

Launch new product.Praharsh Jaiswal**-DONE**

Change sequence .Praharsh Jaiswal**-TO DO**

Fix search typo.Praharsh Jaiswal**-DONE**

name of the PDF file. not showingPraharsh Jaiswal**-DONE**

Set default tax class.Praharsh Jaiswal**-DONE**

Change the color of the PDF icon from red to black. Praharsh Jaiswal**-DONE**

Add description to the PDF.Praharsh Jaiswal**-DONE**

Verify download functionality.Praharsh Jaiswal**-TO DO**

Investigate category load slowness.Praharsh Jaiswal**-TO DO**

Update license. Praharsh Jaiswal**-TO DO**

Save"Last Updated" in the product table. Praharsh Jaiswal**-TO DO**

Implement automated rule: If replacement stock code exists, keep the flag false to show related product.Amit Kumar-TO DO

Amit Kumar

Shift add button to the right. Place sort and max options inside the form. Test placement with bottom alignment. Amit Kumar**-DONE**

Fix the tab.Amit Kumar**-DONE**

Adjust PIM editor button outline and color. Amit Kumar**-DONE**

Rename "content entry" to "type" as the main filter. Amit Kumar**-DONE**

Mohit Das

Display country of origin code and name. Mohit Das**-Data Issue-TO DO/Master data restore in progress**

Make currency code dynamic ($). Display country name and code in brackets. Mohit Das**--Data Issue-TO DO/Master data restore in progress**

Resolve NaN issue in the price list. Show 0 if price does not exist.Mohit Das/-TO DO

Revert front-end code changes to differentiate domain/channel. Mohit Das**-DONE**

Disable updating of description, image, and stock code; allow updates for all other fields. Mohit Das**-Update flag-TO DO**

Keep all fields unselected by default in bulk edit. Keep column selector expanded and let users select the fields. Mohit Das**-DONE**

Open product in a new tab when clicked in the PIM editor. Mohit Das**-DONE**

Yogananda Jayanthi

Enhance workflow to show stages. Yogananda Jayanthi**-WIP**

Update workflow status options: Draft, Active, Archived, Discontinued. Yogananda Jayanthi**-WIP**

Set up eBay listing generation in the setup. @Sanjay**-WIPDONE= Dev Completed**

Link to feature: https://bettercommerce.productboard.com/feature-board/planning/features/20580028


pthread.h not found

I've downloaded the SDK (wasi-sdk-14.0-mingw.tar.gz), tried to compile some programs and getting an error saying pthread.h not found. Is this intended for MinGW?

Tested on Linux, same thing.


dockerd error message

Hello,
I get constant log messages like this:
"dockerd[2252]: time="2024-12-02T14:20:03.634699510+01:00" level=error msg="collecting stats for container /unbound-db-socket: NotFound: container \"dd1927ebed109c6fba6db549639bf299eb7b09a4144bee263990eea495013a04\" in namespace \"moby\": not found"
Do you know whats causing this?
The Pihole-Unbound-Redis-Busybox Stack is working as far as I can tell.

Hi!
It seems like a container can't be found, could you do a docker compose down and then docker compose up?

ok, I restarted the stack and now get
 dockerd[2252]: time="2024-12-02T16:16:59.630838832+01:00" level=error msg="[resolver] failed to query external DNS server" client-addr="udp:<IP_ADDRESS>:45262" dns-server="udp:<IP_ADDRESS>:53" error="read udp <IP_ADDRESS>:45262-><IP_ADDRESS>:53: i/o timeout" question>
dockerd[2252]: time="2024-12-02T16:20:40.018057083+01:00" level=info msg="No non-localhost DNS nameservers are left in resolv.conf. Using default external servers"

The message states that the resolver listening on <IP_ADDRESS>:53 isn't answering.
Have you tried from scratch first? If so, I'd need your config files (yaml, conf including your docker host's resolv.conf) to see what's wrong with your setup.
Thanks.

So after the restart the error in the logs is gone: level=error msg="collecting stats for container /unbound-db-socket
but then the logs get flooded with
dockerd[2252]: time="2024-12-02T22:48:43.139754108+01:00" level=info msg="ignoring event" container=4f687a930803af2615734f8acee957aee>
dockerd[2252]: time="2024-12-02T22:49:44.202644852+01:00" level=info msg="No non-localhost DNS nameservers are left in resolv.conf. U>
via docker ps I saw that the busybox container is constantly restarted.
docker-compose.yaml
version: "3.8"
networks:
  wirehole:
    driver: macvlan
    external: true
services:
  unbound:
    container_name: unbound
    image: madnuttah/unbound:latest
    ports:
      - 5335:5335/tcp
      - 5335:5335/udp
    volumes:
      - /etc/localtime:/etc/localtime
      - /portainer/Files/unboundstack/unbound/unbound.conf:/usr/local/unbound/unbound.conf:rw
      - /portainer/Files/unboundstack/unbound/conf.d/:/usr/local/unbound/conf.d/:rw
      - /portainer/Files/unboundstack/unbound/log.d/unbound.log:/usr/local/unbound/log.d/unbound.log:rw
      - /portainer/Files/unboundstack/unbound/zones.d/:/usr/local/unbound/zones.d/:rw
      - /portainer/Files/unboundstack/unbound/iana.d/:/usr/local/unbound/iana.d/:rw
      - /portainer/Files/unboundstack/unbound/sbin/healthcheck.sh:/usr/local/unbound/sbin/healthcheck.sh:ro
    environment:
      TZ: Europe/Berlin
      UNBOUND_UID: 1000
      UNBOUND_GID: 100
      ENABLE_STATS: false
      EXTENDED_HEALTHCHECK: false
    restart: unless-stopped
    volumes_from:
      - unbound-db-socket:ro
    networks:
      wirehole:
        ipv4_address: <IP_ADDRESS>
    depends_on:
      unbound-db:
        condition: service_healthy
    healthcheck:
      test: /usr/local/unbound/sbin/healthcheck.sh
      interval: 60s
      retries: 5
      start_period: 15s
      timeout: 30s
  pihole:
    container_name: pihole
    image: pihole/pihole:latest
    restart: unless-stopped
    hostname: pihole
    environment:
      WEBPASSWORD: xxx
      TZ: Europe/Berlin
      PIHOLE_DNS_: <IP_ADDRESS>#5335
    volumes:
      - /portainer/Files/pihole/etc-pihole:/etc/pihole
      - /portainer/Files/pihole/etc-dnsmasq.d:/etc/dnsmasq.d
      - /etc/localtime:/etc/localtime
    depends_on:
      unbound:
        condition: service_healthy
    cap_add:
      - NET_ADMIN
      - NET_BIND_SERVICE
    ports:
      - 53:53/tcp
      - 53:53/udp
      - 67:67/udp
      - 80:80/tcp
    networks:
      wirehole:
        ipv4_address: <IP_ADDRESS>
  unbound-db-socket:
    image: busybox
    container_name: unbound-db-socket
    init: true
    tty: true
    command: /bin/sh -c "chown -R 999:100 /usr/local/unbound/cachedb.d/"
    restart: unless-stopped
    volumes:
      - /portainer/Files/unboundstack/busybox/cachedb.d/:/usr/local/unbound/cachedb.d/
      - /etc/localtime:/etc/localtime
  unbound-db:
    image: redis:alpine
    container_name: unbound-db
    command: redis-server /usr/local/etc/redis/redis.conf
    volumes:
      - /portainer/Files/unboundstack/redis/data/:/data/
      - /etc/localtime:/etc/localtime
      - /etc/timezone:/etc/timezone:ro
      - /portainer/Files/unboundstack/redis/config/redis.conf:/usr/local/etc/redis/redis.conf
      - /portainer/Files/unboundstack/redis/sbin/healthcheck.sh:/usr/local/sbin/healthcheck.sh:ro
      - /portainer/Files/unboundstack/redis/sys/sysctl.conf:/etc/sysctl.conf
    volumes_from:
      - unbound-db-socket:rw
    depends_on:
      - unbound-db-socket
    restart: unless-stopped
    healthcheck:
      test: /usr/local/sbin/healthcheck.sh
      interval: 10s
      retries: 5
      start_period: 5s
      timeout: 30s

My docker user is 1000:100, should the chown command also be that?

Sure, this could be the issue.

I can't figure out why the busybox image is restarting. I switched the redis connection to tcp and will try to debug.
The 'No non-localhost DNS nameservers are left in resolv.conf' error is still there, I will try to debug that for now.

in addition to the other error logs, as far as I have googled that error should not be a problem. the dns resolving itself is working.
why the busybox image keeps restarting is strange and I can't debug it and also the dns resolving is working. so I think the issue can be closed

Thank you.
There had been some changes, the volumes_from ain't in use anymore, instead a named volume cachedb.d is used now. See this example.


WARNING: An illegal reflective access operation has occurred

Describe the bug
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.ibm.fhir.model.util.XMLSupport (file:/Users/rubberduck/.gradle/caches/modules-2/files-2.1/com.ibm.fhir/fhir-model/4.7.0/706afb6278d6bf5e56dec035ea17a0f326f41bba/fhir-model-4.7.0.jar) to constructor com.sun.xml.internal.stream.XMLInputFactoryImpl()

Environment
Which version of IBM FHIR Server?
4.7.0
To Reproduce
Steps to reproduce the behavior:
I'm not entirely sure.
Would be happy to help reproduce it given some guidance.
I'm running OpenJDK 11 and it seems that this behavior was introduced in JDK 9.
If you're using an older JDK, you might not see this.
Expected behavior
A clear and concise description of what you expected to happen.
No warnings.
Additional context
Add any other context about the problem here.
This StackOverflow Q&A may help someone who understands the problem better than I.
https://stackoverflow.com/questions/50251798/what-is-an-illegal-reflective-access

Thanks @rubberduck203 we're aware of the warning.  It's related to the XML library which we is dependent upon uses Reflection to access the xml model in memory.

Cool. Thanks @prb112.
I didn't see an issue anywhere, so wanted to make sure you were aware.

We are currently using the JVM default implementations of XMLInputFactory, XMLOutputFactory, and TransformerFactory: com.sun.xml.internal.stream.XMLInputFactoryImpl, com.sun.xml.internal.stream.XMLOutputFactoryImpl, and com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl respectively. We found that other, 3rd party implementations cause problems with how we parse / generate XML. I recently retested using Woodstox, Xalan-J, and Saxon without issues. For this particular issue, I think we should upgrade to Java 9 first and then see where things stand. If it turns out that we need to move to a different implementation to avoid the reflective access warning, then we can decide to do so at that time.

Just FYI, as of Java 17, this won't even compile anymore.
The 17 LTS is scheduled for release Sept 2021.

Confirmed with JDK 11 it no longer is reported.
Test 1: Ran build with 4.9.1 and main
mvn clean install -f fhir-parent -pl ../fhir-model --am

Confirmed the message exists on the tag, and not in the main.
Test 2: Ran with Liberty on AdoptOpenJDK 11 with 4.9.1 and main
Confirmed the message exists on tag and not in the main branch


Are you guys going to abandon this framework?

The latest commit was around 6 months ago ?
We have not seen anything changed since. I wonder whether this project is still active or not.
Thank you.

https://github.com/dart-lang/angular/issues/1866#issuecomment-571851626
https://github.com/dart-lang/angular/issues/1866#issuecomment-603947916


Support testEnvironment=jest-environment-jsdom with pnpm

Summary
The dynamic require of testEnvironment (transpiled to const testFramework = require(config.testRunner) in published source) is incompatible with pnpm.
I agree with https://github.com/pnpm/pnpm/issues/1130#issuecomment-386718095.
For environment to be truly pluggable, with stricter npm install, I guess this PR needs to consider how to support environments other than jsdom. It could be argued that a class should be injected, rather than required using a runtime value. In practice though I think the suggested addition to package.json solves the problem.
Test plan

Fixes #5369

Codecov Report

Merging #6145 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6145   +/-   ##
=======================================
  Coverage   64.19%   64.19%
=======================================
  Files         219      219
  Lines        8423     8423
  Branches        4        3    -1
=======================================
  Hits         5407     5407
  Misses       3015     3015
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca03cd...7896fd6. Read the comment docs.

Sorta related https://github.com/facebook/jest/issues/5913

Another possibility is to do require.resolve in jest-config (and the whole "try with jest-environment prefix" logic), and pass the full path to the runner.
@cpojer @thymikee @rickhanlonii thoughts? I'd also like to not paint us into a corner with regards to #5913 (maybe even solve it at the same time)

This issue is affecting my application also, because we have to install two versions of Jest side by side.  In our specific case, the<EMAIL_ADDRESS>ends up requiring<EMAIL_ADDRESS>which causes this error:

TypeError: environment.dispose is not a function

PNPM brings the problem to light, but this is fundamentally an architectural problem with Jest not just a compatibility issue:  In the modern world, libraries cannot naively call require(X) to fish a dependency out of the node_modules folder without any idea of what version of X they will get.  The version needs to be constrained somehow, either directly via package.json as a dependency, or indirectly via a peer dependency or injection.
The approach suggested in this PR would help the simple case where you get jsdom as your default.  However the jsdom dependency is like 11MB with all its dependencies.  Forcing everyone to install that and probably also jest-environment-node seems contrary to the goal of modeling the environment as a swappable plug-in.  It also doesn't help advanced users who have custom packages.
It also poses a backwards compatibility problem:  If jest-environment-jsdom is a peer dependency, upgrading consumers will fail to install unless they satisfy a new peer.  Or if it's a regular dependency, consumers may get an unexpected version if the node_modules tree gets shuffled around.
A better solution would be to make options.testEnvironment an injectable instance instead of a simple text string.  This is how other libraries treat their plugins, and it is the architecturally sound way to specify a plugin.

I tried creating a PR that would illustrate how to allow something like this:
// jest.config.js
module.exports = {
  verbose: true,
  testEnvironment: require('my-environment'),
};

However I cannot seem to get the master branch of Jest to build at all, on Windows or Mac.  The yarn install keeps failing with various errors...

@SimenB Would you be willing to merge this fix, or @pgonzal's fix, as an intermediate solution?

Leaving this one for @arcanis to merge.

@arcanis friendly ping :)

@solsson mind taking a look at @arcanis https://github.com/facebook/jest/pull/6145#discussion_r190546325?

It's been a month already without a sign of interest, closing. Happy to reopen once the feedback is addressed :)


Lesson 7 : Please help my end lottery function keeps getting reverted,

Brownie v1.19.3 - Python development framework for Ethereum
SmartcontractLotteryProject is the active project.
Launching 'ganache-cli --accounts 10 --hardfork istanbul --gasLimit 12000000 --mnemonic brownie --port 8545'...
Running 'scripts/deploy.py::main'...
deploying mocks ...
deploying MockV3Aggregator...
Transaction sent: 0x922f9955acc77e74494aa0ffe312e3493e8ec12657e14dd78caf42cd06f5895e
Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 0
MockV3Aggregator.constructor confirmed   Block: 1   Gas used: 435435 (3.63%)
MockV3Aggregator deployed at: 0x3194cBDC3dbcd3E11a07892e7bA5c3394048Cc87
deploying LinkToken...
Transaction sent: 0x689b2322bc923c1e3c142d8b2963f995bdbebabe728c3f308c714f9ba79968ca
Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 1
LinkToken.constructor confirmed   Block: 2   Gas used: 669124 (5.58%)
LinkToken deployed at: 0x602C71e4DAC47a042Ee7f46E0aee17F94A3bA0B6
deploying VRFCoordinatorMock...
Transaction sent: 0x3044d86fca91d7af9ab1f04ee0440c70f49d285987029798d3e7d27f3c6c4b37
Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 2
VRFCoordinatorMock.constructor confirmed   Block: 3   Gas used: 298504 (2.49%)
VRFCoordinatorMock deployed at: 0xE7eD6747FaC5360f88a2EFC03E00d25789F69291
All mocks deployed !
Transaction sent: 0xf5a93faa6763aa8bd8e7c3ba58eb8b35b2eb341c9ed148e9d8ed7b16511edd73
Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 3
Lottery.constructor confirmed   Block: 4   Gas used: 862486 (7.19%)
Lottery deployed at: 0x6951b5Bd815043E3F842c1b026b0Fa888Cc2DD85
deployed lottery!
Transaction sent: 0x1f3629b4ccc88f7e9e8b4f9d7d7a0e3328610fafa9346bd79152467364540969
Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 4
Lottery.startLottery confirmed   Block: 5   Gas used: 28836 (0.24%)
Lottery.startLottery confirmed   Block: 5   Gas used: 28836 (0.24%)
lottery has been started !
Transaction sent: 0x4779b635ea80279c8b219c530faa1e3c7e903f068ef85bc8431fdd563d536001
Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 5
Lottery.Enter confirmed   Block: 6   Gas used: 70729 (0.59%)
Lottery.Enter confirmed   Block: 6   Gas used: 70729 (0.59%)
you have entered the lottery !
Transaction sent: 0xe930a3aa6106d132e9479441011d896ee16f7f7c6a5feffcf02436337497410a
Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 6
LinkToken.transfer confirmed   Block: 7   Gas used: 51398 (0.43%)
LinkToken.transfer confirmed   Block: 7   Gas used: 51398 (0.43%)
funded with link !
LinkToken.transfer confirmed   Block: 7   Gas used: 51398 (0.43%)
Transaction sent: 0xe97361a7db515a30e3feac79b1e14d6e16abd3132949b17a82fbb83cd87bc619
Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 7
Lottery.endLottery confirmed (reverted)   Block: 8   Gas used: 11813021 (98.44%)
File "brownie/_cli/run.py", line 51, in main
return_value, frame = run(
File "brownie/project/scripts.py", line 110, in run
return_value = f_locals[method_name](*args, **kwargs)
File "./scripts/deploy.py", line 54, in main
end_lottery()
File "./scripts/deploy.py", line 44, in end_lottery
ending_txn = lottery.endLottery({"from": account})
File "brownie/network/contract.py", line 1864, in call
return self.transact(*args)
File "brownie/network/contract.py", line 1737, in transact
return tx["from"].transfer(
File "brownie/network/account.py", line 682, in transfer
receipt._raise_if_reverted(exc)
File "brownie/network/transaction.py", line 446, in _raise_if_reverted
raise exc._with_attr(
VirtualMachineError: revert
Trace step -1, program counter 1879:
File<EMAIL_ADDRESS>line 153, in VRFConsumerBase.requestRandomness:
* @dev fulfillRandomness.
*/
function requestRandomness(bytes32 _keyHash, uint256 _fee) internal returns (bytes32 requestId) {
LINK.transferAndCall(vrfCoordinator, _fee, abi.encode(_keyHash, USER_SEED_PLACEHOLDER));
// This is the seed passed to VRFCoordinator. The oracle will mix this with
// the hash of the block containing this request to obtain the seed/input
// which is finally passed to the VRF cryptographic machinery.
Terminating local RPC client...

Please check out the latest implementation using VRF2: https://github.com/smartcontractkit/full-blockchain-solidity-course-py/discussions/1791


Latest pangolin release breaks ncov-tools

Hiya,
The latest release of pangolin seems to have dropped thread support: https://github.com/cov-lineages/pangolin/issues/136
Pangolin now complains at the -t so I  had to downgrade the pangolin version in the ncov-tools env to 2.1.11
Not sure if you want to fix pangolin version or adjust the command to drop threads - happy to PR if you want either.
Cheers,
Will

Thanks for letting me know Will, I'll look at this

I can reinstate it- but it hasn't been a functional flag in latest releases. It seems that dropping it may be causing more issues than solving, so I can update so using -t won't break anything.

Ah, my commit crossed with your comment @aineniamh! I've removed the flag, if it isn't functional I'll keep it this way in ncov-tools but understand if you want to put it back in for compatibility with other workflows/pipelines.

Ah no problem! Sorry about that again, I had been doing a code 'spring-clean' and dropped quite a lot of the legacy code (including the now non-functional thread flag).
I've added a catch in that prints a warning but doesn't break in the latest release (https://github.com/cov-lineages/pangolin/releases/tag/v2.2.2), and hopefully we can support multithreading again in the future.


Support multiple objects in "stream" property

I was getting gibberish from every model I tried with this proxy. Stumped, I tried copying the exact payload that the proxy sends into RunPod's "requests" prompt and found that I was getting coherent replies!
It turns out that the proxy fails to handle responses from the RunPod endpoint that contain more than one "output" object. For instance, an example response that I received when querying /stream/<request_id>:

Click to show Response JSON body
{
  "status": "IN_PROGRESS",
  "stream": [
    {
      "output": {
        "choices": [
          {
            "delta": {
              "content": [
                " feeling",
                " slightly",
                " dis"
              ]
            },
            "finish_reason": null,
            "index": 0
          }
        ],
        "created": 12862879,
        "id": "cmpl-6a3c77f7ea17436ebdb5d34767a77343",
        "model": "MaziyarPanahi/miqu-1-70b-sf-GPTQ",
        "object": "chat.completion.chunk"
      }
    },
    {
      "output": {
        "choices": [
          {
            "delta": {
              "content": [
                "orient",
                "ated",
                ","
              ]
            },
            "finish_reason": null,
            "index": 0
          }
        ],
        "created": 12862879,
        "id": "cmpl-6a3c77f7ea17436ebdb5d34767a77343",
        "model": "MaziyarPanahi/miqu-1-70b-sf-GPTQ",
        "object": "chat.completion.chunk"
      }
    }
  ]
}

Click to show my request
{
  "input": {
    "sampling_params": {
      "max_tokens": 300,
      "n": 1,
      "best_of": null,
      "presence_penalty": 0,
      "frequency_penalty": 1.1,
      "repetition_penalty": 1.15,
      "temperature": 0.6,
      "top_p": 0.95,
      "top_k": 40,
      "use_beam_search": false,
      "stop": null,
      "skip_special_tokens": true,
      "ignore_eos": false
    },
    "stream": true,
    "use_openai_format": 1,
    "batch_size": 3,
    "messages": [
      {
        "role": "system",
        "content": "Write Redacted's next reply in a fictional chat between Redacted and Redacted. Write 1 reply only in internet RP style, italicize actions, and avoid quotation marks. Use markdown. Be proactive, creative, and drive the plot and conversation forward. Write at least 1 paragraph, up to 4. Always stay in character and avoid repetition."
      },
      {
        "role": "system",
        "content": "Appearance: Redacted"
      },
      {
        "role": "system",
        "content": "Redacted"
      },
      {
        "role": "system",
        "content": "[Start a new Chat]"
      },
      {
        "role": "assistant",
        "content": "Redacted"
      },
      {
        "role": "user",
        "content": "Redacted"
      }
    ]
  }
}

When streaming from vLLM, it appears that the response may contain multiple entries under the "stream" property. This resulted in only the first output being delivered to SillyTavern, which made the response appear like gibberish (as occasional tokens were missing).
This commit refactors the code slightly to handle more than one output. Note that I don't think this code is very clean, but I'm putting it up now for your consideration. Feel free to refactor or merge as-is.

Thanks a lot @anoadragon453!


Warnings and Errors compilig the Module in Godot Engine 3.2 Stable

Hi lawnjelly i have this series of issues trying to compile the module with Godot Engine 3.2 Stable
My PC is Ubuntu 20.04
In file included from modules/llightmap/llightmap_all.cpp:18:
modules/llightmap/lmerger.cpp: In static member function 'static bool LM::Merger::xatlas_unwrap(float, const float*, const float*, int, const int*, const int*, int, float**, int**, int*, int**, int*, int*, int*)':
modules/llightmap/lmerger.cpp:267:49: error: 'ParameterizeOptions' is not a member of 'xatlas'; did you mean 'ParameterizeCharts'?
267 |  xatlas::Generate(atlas, chart_options, xatlas::ParameterizeOptions(), pack_options);
|                                                 ^~~~~~~~~~~~~~~~~~~
|                                                 ParameterizeCharts
In file included from modules/llightmap/llightscene.h:6,
from modules/llightmap/llightmapper_base.h:6,
from modules/llightmap/lraybank.h:5,
from modules/llightmap/lambient_occlusion.h:3,
from modules/llightmap/llightmapper.h:3,
from modules/llightmap/gdlightmapper.h:5,
from modules/llightmap/register_types.cpp:6,
from modules/llightmap/llightmap_all.cpp:6:
modules/llightmap/llightimage.h: In instantiation of 'bool LM::LightImage::IsWithin(int, int) const [with T = LM::FColor]':
modules/llightmap/llightmapper.cpp:617:33:   required from here
modules/llightmap/llightimage.h:74:9: warning: comparison of integer expressions of different signedness: 'int' and 'const uint32_t' {aka 'const unsigned int'} [-Wsign-compare]
74 |   if (x >= m_uiWidth) return false;
|       ^~~~~~~~~~
modules/llightmap/llightimage.h:75:9: warning: comparison of integer expressions of different signedness: 'int' and 'const uint32_t' {aka 'const unsigned int'} [-Wsign-compare]
75 |   if (y >= m_uiHeight) return false;
|       ^~~~~~~~~~~
[Initial build] Compiling ==> thirdparty/pcre2/src/pcre2_config.c
[Initial build] Compiling ==> thirdparty/pcre2/src/pcre2_context.c
[Initial build] Compiling ==> thirdparty/pcre2/src/pcre2_convert.c
modules/llightmap/llightimage.h: In instantiation of 'void LM::LightImage::Blank() [with T = Vector3]':
modules/llightmap/llightimage.h:18:4:   required from 'void LM::LightImage::Create(uint32_t, uint32_t, bool) [with T = Vector3; uint32_t = unsigned int]'
modules/llightmap/llightmapper.cpp:223:49:   required from here
modules/llightmap/llightimage.h:63:9: warning: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'struct Vector3'; use assignment or value-initialization instead [-Wclass-memaccess]
63 |   memset(&val, 0, sizeof (T));
|   ^~~~~~~~~~~~~~~
In file included from ./core/math/plane.h:34,
from ./core/math/aabb.h:35,
from ./core/variant.h:38,
from ./core/method_ptrcall.h:36,
from ./core/method_bind.h:35,
from ./core/class_db.h:34,
from modules/llightmap/register_types.cpp:5,
from modules/llightmap/llightmap_all.cpp:6:
./core/math/vector3.h:39:8: note: 'struct Vector3' declared here
39 | struct Vector3 {
|        ^~~~~~~
In file included from modules/llightmap/llightscene.h:6,
from modules/llightmap/llightmapper_base.h:6,
from modules/llightmap/lraybank.h:5,
from modules/llightmap/lambient_occlusion.h:3,
from modules/llightmap/llightmapper.h:3,
from modules/llightmap/gdlightmapper.h:5,
from modules/llightmap/register_types.cpp:6,
from modules/llightmap/llightmap_all.cpp:6:
modules/llightmap/llightimage.h: In instantiation of 'void LM::LightImage::Blank() [with T = Vector]':
modules/llightmap/llightimage.h:18:4:   required from 'void LM::LightImage::Create(uint32_t, uint32_t, bool) [with T = Vector; uint32_t = unsigned int]'
modules/llightmap/llightscene.cpp:880:45:   required from here
modules/llightmap/llightimage.h:63:9: warning: 'void* memset(void*, int, size_t)' clearing an object of type 'class Vector' with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
63 |   memset(&val, 0, sizeof (T));
|   ^~~~~~~~~~~~~~~
In file included from ./core/ustring.h:37,
from ./core/math/vector2.h:35,
from ./core/math/rect2.h:34,
from ./core/math/transform_2d.h:34,
from ./core/method_ptrcall.h:34,
from ./core/method_bind.h:35,
from ./core/class_db.h:34,
from modules/llightmap/register_types.cpp:5,
from modules/llightmap/llightmap_all.cpp:6:
./core/vector.h:56:7: note: 'class Vector' declared here
56 | class Vector {
|       ^~~~~~
[Initial build] Compiling ==> thirdparty/pcre2/src/pcre2_dfa_match.c
[Initial build] Compiling ==> thirdparty/pcre2/src/pcre2_error.c
In file included from modules/llightmap/llighttypes.h:4,
from modules/llightmap/lraybank.h:3,
from modules/llightmap/lambient_occlusion.h:3,
from modules/llightmap/llightmapper.h:3,
from modules/llightmap/gdlightmapper.h:5,
from modules/llightmap/register_types.cpp:6,
from modules/llightmap/llightmap_all.cpp:6:
modules/llightmap/lvector.h: In instantiation of 'void LVector::delete_items_first(unsigned int) [with T = LM::Vec2_i16]':
modules/llightmap/ldilate.h:85:32:   required from 'void LM::Dilate::Run(LM::LightImage&, LM::LightImageLM::Vec2_i16, unsigned int) [with T = float]'
modules/llightmap/ldilate.h:36:3:   required from 'bool LM::Dilate::DilateImage(LM::LightImage&, const LM::LightImage&, unsigned int) [with T = float]'
modules/llightmap/llightmapper_base.cpp:354:51:   required from here
modules/llightmap/lvector.h:201:18: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare]
201 |   if (uiNumItems < size())
modules/llightmap/lvector.h:213:19: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare]
213 |    if (uiNumItems == size())
[Initial build] Compiling ==> thirdparty/pcre2/src/pcre2_extuni.c
[Initial build] Compiling ==> thirdparty/pcre2/src/pcre2_find_bracket.c
In file included from modules/llightmap/llightscene.h:6,
from modules/llightmap/llightmapper_base.h:6,
from modules/llightmap/lraybank.h:5,
from modules/llightmap/lambient_occlusion.h:3,
from modules/llightmap/llightmapper.h:3,
from modules/llightmap/gdlightmapper.h:5,
from modules/llightmap/register_types.cpp:6,
from modules/llightmap/llightmap_all.cpp:6:
modules/llightmap/llightimage.h: In instantiation of 'void LM::LightImage::Blank() [with T = LM::Vec2_i16]':
modules/llightmap/llightimage.h:18:4:   required from 'void LM::LightImage::Create(uint32_t, uint32_t, bool) [with T = LM::Vec2_i16; uint32_t = unsigned int]'
modules/llightmap/ldilate.h:65:24:   required from 'void LM::Dilate::Run(LM::LightImage&, LM::LightImageLM::Vec2_i16, unsigned int) [with T = float]'
modules/llightmap/ldilate.h:36:3:   required from 'bool LM::Dilate::DilateImage(LM::LightImage&, const LM::LightImage&, unsigned int) [with T = float]'
modules/llightmap/llightmapper_base.cpp:354:51:   required from here
modules/llightmap/llightimage.h:63:9: warning: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'class LM::Vec2_i16'; use assignment or value-initialization instead [-Wclass-memaccess]
63 |   memset(&val, 0, sizeof (T));
|   ^~~~~~~~~~~~~~~
In file included from modules/llightmap/lraybank.h:3,
from modules/llightmap/lambient_occlusion.h:3,
from modules/llightmap/llightmapper.h:3,
from modules/llightmap/gdlightmapper.h:5,
from modules/llightmap/register_types.cpp:6,
from modules/llightmap/llightmap_all.cpp:6:
modules/llightmap/llighttypes.h:33:7: note: 'class LM::Vec2_i16' declared here
33 | class Vec2_i16
|       ^~~~~~~~
In file included from modules/llightmap/llightscene.h:6,
from modules/llightmap/llightmapper_base.h:6,
from modules/llightmap/lraybank.h:5,
from modules/llightmap/lambient_occlusion.h:3,
from modules/llightmap/llightmapper.h:3,
from modules/llightmap/gdlightmapper.h:5,
from modules/llightmap/register_types.cpp:6,
from modules/llightmap/llightmap_all.cpp:6:
modules/llightmap/llightimage.h: In instantiation of 'bool LM::LightImage::IsWithin(int, int) const [with T = unsigned char]':
modules/llightmap/ldilate.h:193:5:   required from 'void LM::Dilate::FindEdges(LM::LightImage&) [with T = float]'
modules/llightmap/ldilate.h:71:3:   required from 'void LM::Dilate::Run(LM::LightImage&, LM::LightImageLM::Vec2_i16*, unsigned int) [with T = float]'
modules/llightmap/ldilate.h:36:3:   required from 'bool LM::Dilate::DilateImage(LM::LightImage&, const LM::LightImage&, unsigned int) [with T = float]'
modules/llightmap/llightmapper_base.cpp:354:51:   required from here
modules/llightmap/llightimage.h:74:9: warning: comparison of integer expressions of different signedness: 'int' and 'const uint32_t' {aka 'const unsigned int'} [-Wsign-compare]
74 |   if (x >= m_uiWidth) return false;
|       ^~~~~~~~~~
modules/llightmap/llightimage.h:75:9: warning: comparison of integer expressions of different signedness: 'int' and 'const uint32_t' {aka 'const unsigned int'} [-Wsign-compare]
75 |   if (y >= m_uiHeight) return false;

Which version of 3.2 is this?
I should add to the documentation it should be the latest (3.2.3 +). There may have been a change to the xatlas interface since 3.2 (the version of xatlas may have been upgraded). If you grab the latest version of 3.2 branch from github you should have more luck.
That is unless there has been a change to xatlas in the last few days, but that seems unlikely.
As for the warnings, I'll try and do some compiling with full warnings on to remove them, they look benign.

Yes, I can confirm, xatlas was synced with upstream 2 months ago, so that presumably was the point that changed the interface, so you'll need a version of 3.2 source since then. I'll add this to the doc. :+1:

Just to note there is now a precompiled release available for windows:
https://github.com/lawnjelly/godot-llightmap/releases
Although it would be good to know if you had success compiling! :+1:

Ok thank alot i will try this exe on linux also i will try to compile with 3.2.2 again this weekend i iḿ succesful compiling i will post this here xD!


No need these deps in apmon

@amaltaro can you take a look ?

test this please

Justas, Ideally it would be better to ship all the dependencies on WorkerNode. (in this case future package). But for now this would be fine. Thanks

Justas, I'm in favor of using the new style class definition, so
class Logger(object):
as Seangchan said, there is no need to import from builtins.
If it's using the old style, ok'ish not to update it. But if it has the new style and you make it old, then ... well, not good.

@juztas if you have time, can you please update the class definition only? Otherwise, Seangchan will fix it in another commit in an hour or two.

@amaltaro have you did that already? if not I will change it now. Please, let me know and sorry for late reply

Nope, otherwise this one would be merged

@juztas, Don't worry about it. I will create additional patch. Thanks,


Change cookie default options.

Cookies are still off by default, but when enabled, the default expiry will match the token life.  Setting a cookie expiry or maxAge will override the default setting.

Looks like what we discussed. I let @ekryski double check and then we can :shipit:

:shipit:
I was thinking we should have 2 different cookies, one for OAuth and one for SSR that you can enable independently but that shouldn't block this at all. That can be added in another PR.

I merged this PR instead: https://github.com/feathersjs/feathers-authentication/pull/308


Priority list for a showcase

This pinned issue contains the issues that we should prioritize from the product perspective, in order to produce a good showcase example. These issues are ordered by their importance. However, if some of lower priority issues could be solved much faster than those of higher priority, we may change the order.
The current showcase example is the Cosmos bank module, leaving in a branch, since it contains plenty of TODOs: https://github.com/informalsystems/quint/blob/igor/cosmos-bank/examples/cosmos-bank/bank.qnt
Note that this list does not take into account any work on: design, refactoring, technical debt, etc. Thus, we should be careful about not chasing only this list, but also having a look at technical priorities.

[x] Tutorials:

[x] #510
[x] #438
[x] #495
[x] #522
[x] #682

[x] Implement/fix support for multiple modules:

[x] #523
[x] #532
[x] #531
[x] #496
[x] Design and implement imports from other files: #241

[x] Implement support for constants in module instances (depends on #523?): #528
[x] Notebook-style editing, Quint <-> markdown

Using lmt

[x] Improve the runs operators for tests:

[x] #542
[x] #543

~[ ] Redesign algebraic data types and implement them: #539~

Closing this issue. All features for this showcase example have been implemented, except ADTs that require more thought and work, but there are simple workarounds.


HDDS-5041. Use getShortUserName in getTrashRoot(s)

https://issues.apache.org/jira/browse/HDDS-5041
Note: this commit changes the username set inside OFS .Trash directory when Kerberos is enabled from principal name to mapped shorted user name.

Thanks @smengcl for working on this. The change LGTM. I just have one question: how do we handle the existing Trash location with full principal name? If it is not safe to do a rename, we should document how to migration after the change.

The existing Trash becomes inactive with the patch because the path has changed. I will document this in the markdown.
It's also a bit unfortunate that the full principal (typically has / in the name<EMAIL_ADDRESS>for example) creates two levels of user directory in .Trash. Though functionally it works just fine:
2021-05-21 18:20:00,170 [main] INFO fs.TrashPolicyDefault: Moved: 'ofs://om/vol2/buck2/README.md' to trash at<EMAIL_ADDRESS>
On a side note, the fundamental idea of this patch is the same as HDDS-5019. We are allowing<EMAIL_ADDRESS>and<EMAIL_ADDRESS>to be mapped to the same short user name, typically user1 in this case but configurable via hadoop.security.auth_to_local, when using the FileSystem (Trash in this case).

Thanks @smengcl for the contribution. The change LGTM, +1.


FIX - cancelling non existing notifications causes crashes

https://github.com/wumke/react-native-local-notifications/issues/20


Update the link to README.md

The current link for the Cobra User Guide leads here which is a 404. The correct link is this.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Allow minimum resulset fetch size >= 1

Currently, the minimum resultset fetch size is 100, which is big with some blobs/long texts.
Then I would like to be able to set the minimum value to 1 or greater.

thanks for the suggestion
Duplicates #13758


race condition

https://github.com/GoogleCloudPlatform/compute-image-packages/blob/3d67bc6271650c8e1fc19b8420c17f6e204d1272/google_compute_engine_oslogin/pam_module/pam_oslogin_admin.cc#L89
Hello,
I reviewed this package as part of the Ubuntu Main Inclusion Review process, and found a few small items I think should be addressed.
If this file was created with more relaxed permissions, perhaps due to an unexpected umask(2) setting, a local attacker may be able to race the chmod(2) call. If C++ doesn't have a RAII method to set the modes at file creation time, please use chmod(2) manually to set the mode restrictively here.
Thanks

/cc @Sarsate


panic: runtime error: invalid memory address or nil pointer dereference

happened when trying to shoot an arrow with a bow
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x790093]

goroutine 26192 [running]:
github.com/df-mc/dragonfly/server/session.(*Session).handlePackets.func1()
        C:/Users/Administrator/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.4/server/session/session.go:303 +0x74
panic({0xbce7c0, 0x16684d0})
        C:/Program Files/Go/src/runtime/panic.go:884 +0x213
github.com/df-mc/dragonfly/server/item.Bow.Release({}, {0xe466f8, 0xc00cbc98c0}, 0xf55ef18, 0xc00e5428f0)
        C:/Users/Administrator/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.4/server/item/bow.go:85 +0x973
github.com/df-mc/dragonfly/server/player.(*Player).ReleaseItem(0xc00cbc98c0)
        C:/Users/Administrator/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.4/server/player/player.go:1400 +0x302
github.com/df-mc/dragonfly/server/session.(*InventoryTransactionHandler).handleReleaseItemTransaction(...)
        C:/Users/Administrator/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.4/server/session/handler_inventory_transaction.go:171
github.com/df-mc/dragonfly/server/session.(*InventoryTransactionHandler).Handle(0xbca940?, {0xe38980?, 0xc00395b180?}, 0xc005048600)
        C:/Users/Administrator/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.4/server/session/handler_inventory_transaction.go:47 +0x5f3
github.com/df-mc/dragonfly/server/session.(*Session).handlePacket(0xc005048600, {0xe38980, 0xc00395b180})
        C:/Users/Administrator/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.4/server/session/session.go:431 +0x9b
github.com/df-mc/dragonfly/server/session.(*Session).handlePackets(0xc005048600)
        C:/Users/Administrator/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.4/server/session/session.go:312 +0xef
created by github.com/df-mc/dragonfly/server/session.(*Session).Start
        C:/Users/Administrator/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.4/server/session/session.go:217 +0xa5

Could you make sure you're filling out the (world.Config).Entities field if this is a world created by you?

Could you make sure you're filling out the (world.Config).Entities field if this is a world created by you?

oh yeah it's a world created by me, that makes sense, i'll try that, and reopen the issue if it still happens


[HUDI-4954] Shade avro and parquet-avro in all bundles

Change Logs
Currently, there is no consistency for avro/parquet-avro dependecies in bundles. In some, they are included but not shaded (like hudi-gcp-bundle, hudi-hive-sync-bundle), while some have included and shaded both, and scopes are also not consistent. This PR ensures that these two dependecies are included and shaded in all bundles except hudi-timeline-server-bundle where these are not required at all.
Impact
No public API changes. bundle content changed.
Risk level
high
need to test different combination of bundles:

hudi-spark-bundle
hudi-utilities-bundle
hudi-hive-sync-bundle
hudi-datahub-sync-bundle
hudi-flink-bundle
hudispark-bundle + hudi-hive-sync-bundle
hudi-utilities-bundle + hudi-hive-sync-bundle
hudi-utilities-slim-bundle + hudi-hive-sync-bundle
hudi-aws-bundle + hudi-spark-bundle
hudi-gcp-bundle + hudi-spark-bundle

Documentation Update
NA
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

both HoodieSparkSqlWriter and DeltaSync register avro schema via org.apache.spark.SparkConf#registerAvroSchemas, which expects unshaded avro schema class, hence resulted in class casting problem

Adding more context: It happens only when the writter has written data using a bundle that has relocated/shaded Avro and the reader queries the table using a bundle with unshaded avro, and the MOR table has uncompacted delete log blocks.


Do not disable rule when it is updated

Closes https://github.com/apache/incubator-openwhisk/issues/1840

I agree, this should be moved to be a Unit test instead.

Tried to do a unit test originally, but had trouble since the Rule route also needs access to the Trigger route. I'll give it another shot when I get time.

Thanks for the kick - same comment as here: https://github.com/apache/incubator-openwhisk/pull/3187#issuecomment-363464521
Something for us to fix in the future.

Bump @dubeejw
Can you take a look into Travis failure ?
It would be good to get this bug fix landed it’s affecting the wskdeploy tool now

Turned out to be two different bugs.

Updating a rule with wsk rule update always returned a status of active.
After updating a rule with wsk rule update the status would be inactive when the rule is fetched with wsk rule get.


progress: 0.16 -> 0.17

Description of changes
Version 0.17 came with zsh completions!
https://github.com/Xfennec/progress/compare/v0.16..v0.17
maintainer ping: @pSub

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:

progress

Thanks!


Trying to fix current bypass of check

Trying to fix https://github.com/GoogleCloudPlatform/policy-library/issues/392

Needs /gcbrun from a collaborator

/gcbrun


feat: update to new issue template

Fixes https://github.com/googleapis/google-cloud-cpp-common/issues/88

This change is

I pinged salty off line about this. This was generated by github's online issue template builder, so it's pretty canned.

ha, I missed this by seconds I guess... should we also add a FR template a la https://github.com/googleapis/google-cloud-cpp-spanner/blob/master/.github/ISSUE_TEMPLATE/feature_request.md


Port 8080

The NSG created by this script opened only port 80 (without a redirect). Amending manually to port 8080 resolved it and I could access Jenkins.

@qoricode thanks for reporting the issue, could you pls specify which script you're using?

Hi Zhu, it's Microsoft's Azure marketplace template for Jenkins. The article on the Azure website links to this repo. Thanks, David
Sent from BlueMail
On 16 Nov 2018, 01:29, at 01:29, Yunge Zhu<EMAIL_ADDRESS>wrote:

@qoricode thanks for reporting the issue, could you pls specify which
script you're using?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/Azure/jenkins/issues/21#issuecomment-439250536


Add a "controller engine" that manages the lifecycles of controllers

Description of your changes

A controller engine is somewhat like a controller "sub-manager", in that it's effectively a group of controllers. Unlike a typical controller manager, the lifecycle of the controllers an engine manages are not coupled to the lifecycle of the engine itself. An engine may be used by a parent controller to start and stop child controllers in accordance with configuration provided by the custom resource that the parent controller watches
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant documentation, examples, or release notes.
[ ] Updated the RBAC permissions in clusterrole.yaml to include any new types.

I've plumbed this up to @muvaf's work in https://github.com/crossplane/crossplane/pull/1412 and run it to make sure it works as expected.

Could you also explain somewhere as comment why you needed to deal with concurrency issues?

@muvaf I wanted to allow the cache and controller goroutines a way to surface any error they encountered, and also to close the stop channel if they encountered an error (or just stopped for some other reason). This ensures that if the controller crashes it stops the cache too and vice versa. The map of stop channels can't be shared across goroutines without some kind of lock, and channels also panic if they're closed multiple times, so I ended up playing with a few patterns trying to use sync.Once etc before just giving up and using a good old fashioned mutex.


Fix for SimpleCov

Coverage increased (+11.9%) to 100.0% when pulling 239d165a996769f77dda51b4df0f8c07bf1e3413 on fix_for_simple_cov into b14cd5b4f5966bfead47aede90cc8a2eb0edd2f0 on master.


ReferenceError: siblingVersion is not defined while installing the package

Environment
node 20.9.0
yarn 1.22.17
vue 3.5.12
vite 5.4.10
Steps to Reproduce

yarn add @sentry/capacitor @sentry/vue --exact
error occured

Expected Result
package is installed
Actual Result
error /Users/iyong-eun/Desktop/works/ddtalk/codes/docktalk/node_modules/@sentry/capacitor: Command failed.
Exit code: 1
Command: node scripts/check-siblings.js
Arguments:
Directory: /Users/iyong-eun/Desktop/works/ddtalk/codes/docktalk/node_modules/@sentry/capacitor
Output:
/Users/iyong-eun/Desktop/works/ddtalk/codes/docktalk/node_modules/@sentry/capacitor/scripts/check-siblings.js:69
errorMessages.push("You must specify the version to the package " + installedVersion + ". ( " + installedVersion + "@" + siblingVersion + ")");
^
ReferenceError: siblingVersion is not defined
at ValidateSentryPackageParameters (/Users/iyong-eun/Desktop/works/ddtalk/codes/docktalk/node_modules/@sentry/capacitor/scripts/check-siblings.js:69:130)
at CheckSiblings (/Users/iyong-eun/Desktop/works/ddtalk/codes/docktalk/node_modules/@sentry/capacitor/scripts/check-siblings.js:128:7)
at Object. (/Users/iyong-eun/Desktop/works/ddtalk/codes/docktalk/node_modules/@sentry/capacitor/scripts/check-siblings.js:158:1)
at Module._compile (node:internal/modules/cjs/loader:1241:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
at Module.load (node:internal/modules/cjs/loader:1091:32)
at Module._load (node:internal/modules/cjs/loader:938:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
at node:internal/main/run_main_module:23:47
I think the function ValidateSentryPackageParameters should be defined in the function CheckSiblings or the variable siblingVersion should be passed as an argument.

Hi, could you try installing with this specific version?
yarn add @sentry/capacitor<EMAIL_ADDRESS>--exact

The same issue is occured with the command.

The only way to avoid this error seems to be installing the @sentry/capacitor and @sentry/vue packages separately, one at a time. When I try to install both simultaneously, the error occurs regardless of the versions.

I am sorry for your experience with the SDK.
We will investigate what could be happening with it.

Same here;
F:\app-mobile>yarn add @sentry/capacitor @sentry/react --exact
yarn add v1.22.21
[1/4] Resolving packages...
⠂ react@latest(node:17980) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>
warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>|| ^6.0.0".
[4/4] Building fresh packages...
[1/3] ⠂ msgpackr-extract
[2/3] ⠂ esbuild
error F:\app-mobile\node_modules\@sentry\capacitor: Command failed.
Exit code: 1
Command: node scripts/check-siblings.js
Arguments:
Directory: F:\app-mobile\node_modules\@sentry\capacitor
Output:
F:\app-mobile\node_modules\@sentry\capacitor\scripts\check-siblings.js:69
        errorMessages.push("You must specify the version to the package " + installedVersion + ". ( " + installedVersion + "@" + siblingVersion + ")");

                         ^

ReferenceError: siblingVersion is not defined
    at ValidateSentryPackageParameters (F:\app-mobile\node_modules\@sentry\capacitor\scripts\check-siblings.js:69:130)
    at CheckSiblings (F:\app-mobile\node_modules\@sentry\capacitor\scripts\check-siblings.js:128:7)
    at Object.<anonymous> (F:\app-mobile\node_modules\@sentry\capacitor\scripts\check-siblings.js:158:1)
    at Module._compile (node:internal/modules/cjs/loader:1566:14)
    at Object..js (node:internal/modules/cjs/loader:1718:10)
    at Module.load (node:internal/modules/cjs/loader:1305:32)
    at Function._load (node:internal/modules/cjs/loader:1119:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:220:24)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:151:5)

Tried with updated yarn;
F:\app-mobile>yarn add @sentry/capacitor @sentry/react --exact
➤ YN0000: · Yarn 4.5.3
➤ YN0000: ┌ Resolution step
➤ YN0085: │ + @sentry/capacitor@npm:1.0.2, @sentry/react@npm:8.47.0, and 14 more.
➤ YN0000: └ Completed in 1s 804ms
➤ YN0000: ┌ Post-resolution validation
➤ YN0060: │ @sentry/react is listed by your project with version 8.47.0 (p9778c), which doesn't satisfy what @sentry/capacitor requests (8.37.1).
➤ YN0060: │ react is listed by your project with version 19.0.0 (p9a1eb), which doesn't satisfy what @reduxjs/toolkit and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react-dom is listed by your project with version 19.0.0 (p00129), which doesn't satisfy what
 motion and other dependencies request (^18.0.0).
➤ YN0002: │ ng-mobile@workspace:. doesn't provide @mui/system (pdc13f), requested by @mui/x-date-pickers.
➤ YN0002: │ ng-mobile@workspace:. doesn't provide @types/leaflet (pa44f3), requested by @maplibre/maplibre-gl-leaflet and other dependencies.
➤ YN0086: │ Some peer dependencies are incorrectly met by your project; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0013: │ 16 packages were added to the project (+ 21.17 MiB).
➤ YN0000: └ Completed in 1s 157ms
➤ YN0000: ┌ Link step
➤ YN0007: │ @sentry/capacitor@npm:1.0.2 [5ba1f] must be built because it never has been before or the last one failed
➤ YN0009: │ @sentry/capacitor@npm:1.0.2 [5ba1f] couldn't be built successfully (exit code 1, logs can be found here: C:\Users\duoquote\AppData\Local\Temp\xfs-84d02311\build.log)
➤ YN0000: └ Completed in 1s 25ms
➤ YN0000: · Failed with errors in 4s 34ms

# This file contains the result of Yarn building a package (@sentry/capacitor@virtual:5ba1f4ad53ff79878b10372d4329a1f7ff5fc72c5a123ab60857e910bd331c68b05ea08401c579aad5251bf131bdb95fd45f102d5e6f9a5f41edb95a36d19a35#npm:1.0.2)
# Script name: postinstall

F:\app-mobile\node_modules\@sentry\capacitor\scripts\check-siblings.js:153
    throw IncompatibilityError.join("\n");
    ^
This version of Sentry Capacitor is incompatible with the following installed packages:
@sentry/react version 8.47.0
Please install the mentioned packages exactly with version 8.37.1 and with the argument --update-sentry-capacitor
npm install --save-exact<EMAIL_ADDRESS>--update-sentry-capacitor
(Use `node --trace-uncaught ...` to show where the exception was thrown)

Node.js v23.4.0


Miss file name in activity log when cloning one file under one file share

Storage Explorer Version: 1.11.2
Build: 20191215.1
Branch: hotfix/1.11.2
Platform/OS: Windows 10/ Linux Ubuntu 18.04/macOS High Sierra
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Expand one storage account -> File Shares.
Create a new file share -> Upload one file to it.
Try to clone this file.
Check the activity log.

Expect Experience:
The file name shows in activity log.
Actual Experience:
Miss file name in activity log.

More Info:

This issue doesn't reproduce for one folder under one file share.

This issue doesn't reproduce for one blob.

To be fixed when clone/rename is moved to AzCopy for File Shares

Verified this issue on build 20200217.1.
The original file name displays but the new file name doesn't display. Details see the screenshot please!

@jasonyemsft please verify that the strings are consistent across blobs and files for azcopy operations. If it is consistent then let's just close.

The behavior is consistent across blobs and the azcopy integration for file share. The 2nd string is supposed to be the parent directory of the copied blob/file.


Array.prototype.concat on nested arrays gives faulty error

Example of bug
As you can see, line 7 works whereas line 9 does not work, when they are the exact same code.
Flow seems to mess up on the extra [] around arrays inside concat(). When I ran into this live, it would tell me that arrayOfArraysVar.concat([arrayVar]) was wrong, but arrayOfArraysVar.concat(arrayVar) was right. This is an incorrect interpretation of what is happening by Flow.
arrayOfArraysVar.concat([arrayVar]) will push (without mutating) an array onto the end of arrayOfArraysVar, whereas arrayOfArraysVar.concat(arrayVar) will push the values of arrayVar onto the end of arrayOfArraysVar, no matter what type they are. When arrayOfArraysVar is typed as Array<Array>, it will push just string onto the end when it should be pushing Array onto the end.
The only fix I've found for this has been:
const before: Array<Array<string>> = etc1().slice(0);
const after: Array<Array<string>> = etc2();
for (let x: number = 0; x < after.length; x++) {
  before.push(after[x]);
}
return before;

Which is definitely less cool than the one-line alternative that does the same thing.

In your example a is an array containing string | Array<string>. You didn’t refine that a[0] is a string instead of an Array<string>.


[top/otp] Rework OTP HW CFG broadcast to address coverage and lint issues

This is an initial step to address #6713.
While it does not solve the tooling shortcomings entirely, it does address the lint and coverage issues that are a result of the hw_cfg_i wildcard connections to each IP.
PS: commits will be squashed once approved.

Latest force push contains another change in sram_ctrl which switches the OTP fuse signals over to the common otp_en_t.
@udinator I ran the executable test and it passes.


[Autodiff]: Failure to synthesize conformance to AdditiveArithmetic in some cases.

Description
The following code fails to build in Debug mode. The error message is:
Assertion failed: (!confRef.isInvalid() && "Missing conformance to `AdditiveArithmetic`"), function emitZeroIntoBuffer, file TangentBuilder.cpp, line 42.

Steps to reproduce
Paste the following code into a new project and build.
import _Differentiation
public struct P<Value> {
    public typealias TangentVector = Self
    public let name = ""
    var value: Value
}
extension P: Equatable, AdditiveArithmetic where Value: AdditiveArithmetic {
    public static var zero: Self {fatalError()}
    public static func + (lhs: Self, rhs: Self) -> Self {fatalError()}
    public static func - (lhs: Self, rhs: Self) -> Self {fatalError()}
}
public extension P {
    @differentiable(reverse where Value: Differentiable, Value.TangentVector == Value, Value: AdditiveArithmetic) func a() -> Value {self.value}
    @differentiable(reverse where Value: Differentiable, Value.TangentVector == Value, Value: AdditiveArithmetic) static internal func t(_ data: Self) -> Value{data.value}
}
extension P: Differentiable where Value:  Differentiable, Value.TangentVector == Value, Value: AdditiveArithmetic {}
@differentiable(reverse) internal func z(_ data: P<Double>) -> Double {
    data.value
    //data.a()
    //P<Double>.z(data)
}

Expected behavior
The code should compile successfully.
Environment

Swift compiler version info: Toolchains 2022-10-09a and 2023-05-31a exhibit this issue.
Xcode version info: 14.2
Deployment target: M1

Additional context

Removing public let name = "" causes the build to succeed.
Returning the value in the function called z using data.a() or P<Double>.z(data) causes the build to succeed.

Stack trace:
1.	Apple Swift version 5.9-dev (LLVM fd15f782007e262, Swift 65bb599048dbd75)
2.	Compiling with the current language version
3.	While evaluating request ExecuteSILPipelineRequest(Run pipelines { Mandatory Diagnostic Passes + Enabling Optimization Passes } on SIL for a)
4.	While running pass #172 SILModuleTransform "Differentiation".
5.	While processing // differentiability witness for z(_:)
sil_differentiability_witness [serialized] [reverse] [parameters 0] [results 0] @$s1a1zySdAA1PVySdGF : $@convention(thin) (@guaranteed P<Double>) -> Double {
}

 on SIL function "@$s1a1zySdAA1PVySdGF".
 for 'z(_:)' (at /Users/user/a/a/main.swift:17:35)
6.	While generating VJP for SIL function "@$s1a1zySdAA1PVySdGF".
 for 'z(_:)' (at /Users/user/a/a/main.swift:17:35)
7.	While generating pullback for SIL function "@$s1a1zySdAA1PVySdGF".
 for 'z(_:)' (at /Users/user/a/a/main.swift:17:35)
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  swift-frontend           0x000000010924c69c llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
1  swift-frontend           0x000000010924ba40 llvm::sys::RunSignalHandlers() + 112
2  swift-frontend           0x000000010924ccdc SignalHandler(int) + 304
3  libsystem_platform.dylib 0x0000000197f0ea24 _sigtramp + 56
4  libsystem_pthread.dylib  0x0000000197edfc28 pthread_kill + 288
5  libsystem_c.dylib        0x0000000197dedae8 abort + 180
6  libsystem_c.dylib        0x0000000197dece44 err + 0
7  swift-frontend           0x000000010939a700 swift::autodiff::TangentBuilder::emitZeroIntoBuffer(swift::SILLocation, swift::SILValue, swift::IsInitialization_t) (.cold.3) + 0
8  swift-frontend           0x0000000104c3311c swift::autodiff::TangentBuilder::emitZeroIntoBuffer(swift::SILLocation, swift::SILValue, swift::IsInitialization_t) + 996
9  swift-frontend           0x0000000104c33248 swift::autodiff::TangentBuilder::emitZero(swift::SILLocation, swift::CanType) + 264
10 swift-frontend           0x0000000104c25e14 swift::autodiff::PullbackCloner::Implementation::materializeAdjointDirect(swift::autodiff::AdjointValue, swift::SILLocation) + 348
11 swift-frontend           0x0000000104c25e7c swift::autodiff::PullbackCloner::Implementation::materializeAdjointDirect(swift::autodiff::AdjointValue, swift::SILLocation) + 452
12 swift-frontend           0x0000000104c23e80 swift::autodiff::PullbackCloner::Implementation::run()::$_1::operator()(unsigned int) const + 124
13 swift-frontend           0x0000000104c20388 swift::autodiff::PullbackCloner::Implementation::run() + 6628
14 swift-frontend           0x0000000104c1e96c swift::autodiff::PullbackCloner::run() + 24
15 swift-frontend           0x0000000104c3b81c swift::autodiff::VJPCloner::Implementation::run() + 1368
16 swift-frontend           0x0000000104c3bee0 swift::autodiff::VJPCloner::run() + 24
17 swift-frontend           0x0000000104d6ffd4 (anonymous namespace)::DifferentiationTransformer::canonicalizeDifferentiabilityWitness(swift::SILDifferentiabilityWitness*, swift::autodiff::DifferentiationInvoker, swift::IsSerialized_t) + 5616
18 swift-frontend           0x0000000104d6e0a4 (anonymous namespace)::Differentiation::run() + 1032
19 swift-frontend           0x0000000104df1a34 swift::SILPassManager::runModulePass(unsigned int) + 980
20 swift-frontend           0x0000000104df784c swift::SILPassManager::execute() + 624
21 swift-frontend           0x0000000104dee9dc swift::SILPassManager::executePassPipelinePlan(swift::SILPassPipelinePlan const&) + 68
22 swift-frontend           0x0000000104dee960 swift::ExecuteSILPipelineRequest::evaluate(swift::Evaluator&, swift::SILPipelineExecutionDescriptor) const + 68
23 swift-frontend           0x0000000104e2ce8c swift::SimpleRequest<swift::ExecuteSILPipelineRequest, std::__1::tuple<> (swift::SILPipelineExecutionDescriptor), (swift::RequestFlags)1>::evaluateRequest(swift::ExecuteSILPipelineRequest const&, swift::Evaluator&) + 28
24 swift-frontend           0x0000000104e1683c llvm::Expected<swift::ExecuteSILPipelineRequest::OutputType> swift::Evaluator::getResultUncached<swift::ExecuteSILPipelineRequest>(swift::ExecuteSILPipelineRequest const&) + 252
25 swift-frontend           0x0000000104deebd0 swift::executePassPipelinePlan(swift::SILModule*, swift::SILPassPipelinePlan const&, bool, swift::irgen::IRGenModule*) + 84
26 swift-frontend           0x0000000104e188e0 swift::runSILDiagnosticPasses(swift::SILModule&) + 192
27 swift-frontend           0x0000000104734f9c swift::CompilerInstance::performSILProcessing(swift::SILModule*) + 68
28 swift-frontend           0x0000000104599078 performCompileStepsPostSILGen(swift::CompilerInstance&, std::__1::unique_ptr<swift::SILModule, std::__1::default_delete<swift::SILModule>>, llvm::PointerUnion<swift::ModuleDecl*, swift::SourceFile*>, swift::PrimarySpecificPaths const&, int&, swift::FrontendObserver*) + 788
29 swift-frontend           0x0000000104598798 swift::performCompileStepsPostSema(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 568
30 swift-frontend           0x00000001045a7988 withSemanticAnalysis(swift::CompilerInstance&, swift::FrontendObserver*, llvm::function_ref<bool (swift::CompilerInstance&)>, bool) + 160
31 swift-frontend           0x000000010459b278 performCompile(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 724
32 swift-frontend           0x000000010459a20c swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2456
33 swift-frontend           0x00000001043e4940 swift::mainEntry(int, char const**) + 2144
34 dyld                     0x0000000197b87f28 start + 2236

@fibrechannelscsi Had a quick question about the issue description.
In the minimal reproducer, are we expecting the compiler to generate AdditiveArithmetic conformance requirements for P<>.name (String)? Reading the autodiff manifesto here, it doesn't look like there is any such requirement.
Reason I'm asking is to narrow down the path for my own investigation.

As can be seen from the stack trace, the crash is happening while generating a pullback for the differentiable function z(_:).
For reasons I don't fully comprehend, z's pullback is trying to construct a P.TangentVector, by first initializing individual members and then the tangent vector type itself, using the struct instruction. The compiler is wrongly assuming that all individual members of P.TangentVector conform to AdditiveArithmetic. Under this false assumption, it is trying to initialize P.name via the <P as AdditiveArithmetic>.zero.getter method - which then causes a crash during the TangentBuilder's emitZero function here.
The SIL code for z's pullback might have looked like below (note that it was never generated due to the compiler crash) -
// pullback of z(_:)
// NOTE - Not completely correct SIL

sil private [ossa] @$s5_65521zySdAA1PVySdGFTJpSpSr : $@convention(thin) (Double) -> P<Double> {
// %0                                             // user: %7
bb0(%0 : $Double):
 %1 = alloc_stack $String                           // users: %6, %5, %4
 %2 = witness_method $String, #AdditiveArithmetic.zero!getter : <Self where Self : AdditiveArithmetic> (Self.Type) -> () -> Self : $@convention(witness_method: AdditiveArithmetic) <τ_0_0 where τ_0_0 : AdditiveArithmetic> (@thick τ_0_0
    .Type) -> @out τ_0_0 // user: %4
 %3 = metatype $@thin String.Type                  // user: %4
 %4 = apply %2<String>(%1, %3) : $@convention(witness_method: AdditiveArithmetic) <τ_0_0 where τ_0_0 : AdditiveArithmetic> (@thick τ_0_0.Type) -> @out τ_0_0
 %5 = load [trivial] %1 : $*String                  // user: %7
 dealloc_stack %1 : $*String                        // id: %6
 %7 = struct $P<Double> (%5 : $String, %0 : $Double) // users: %9, %8
 debug_value %7 : $P<Double>, let, name "data", argno 1 // id: %8
 return %7 : $P<Double>                          // id: %9
} // end sil function '$s5_65521zySdAA1PVySdGFTJpSpSr'

As indicated in the reproducer when z is modified to use data.a(), instead of data.value, the code compiles and the compiler manages to generate a pullback for z successfully. The SIL for the generated pullback looks as below -
// pullback of z(_:)
sil private @$s4diff1zySdAA1PVySdGFTJpSpSr : $@convention(thin) (Double, @owned @callee_guaranteed (Double) -> @owned P<Double>) -> @owned P<Double> {
// %0                                             // users: %9, %8
// %1                                             // users: %15, %13
bb0(%0 : $Double, %1 : $@callee_guaranteed (Double) -> @owned P<Double>):
  %2 = alloc_stack $P<Double>                     // users: %21, %5, %18, %24, %27, %26
  %3 = metatype $@thin P<Double>.Type             // user: %5
  // function_ref static P<A>.zero.getter
  %4 = function_ref @$s4diff1PVAAs18AdditiveArithmeticRzlE4zeroACyxGvgZ : $@convention(method) <τ_0_0 where τ_0_0 : AdditiveArithmetic> (@thin P<τ_0_0>.Type) -> @out P<τ_0_0> // user: %5
  %5 = apply %4<Double>(%2, %3) : $@convention(method) <τ_0_0 where τ_0_0 : AdditiveArithmetic> (@thin P<τ_0_0>.Type) -> @out P<τ_0_0>
  %6 = integer_literal $Builtin.Int64, 0          // user: %7
  %7 = builtin "sitofp_Int64_FPIEEE64"(%6 : $Builtin.Int64) : $Builtin.FPIEEE64 // user: %10
  %8 = struct_extract %0 : $Double, #Double._value // user: %10
  debug_value %0 : $Double                        // id: %9
  %10 = builtin "fadd_FPIEEE64"(%7 : $Builtin.FPIEEE64, %8 : $Builtin.FPIEEE64) : $Builtin.FPIEEE64 // user: %11
  %11 = struct $Double (%10 : $Builtin.FPIEEE64)  // user: %13
  %12 = alloc_stack [lexical] $P<Double>          // users: %14, %18, %20, %19
  %13 = apply %1(%11) : $@callee_guaranteed (Double) -> @owned P<Double> // user: %14
  store %13 to %12 : $*P<Double>                  // id: %14
  strong_release %1 : $@callee_guaranteed (Double) -> @owned P<Double> // id: %15
  %16 = metatype $@thick P<Double>.Type           // user: %18
  // function_ref static AdditiveArithmetic.+= infix(_:_:)
  %17 = function_ref @$ss18AdditiveArithmeticPsE2peoiyyxz_xtFZ : $@convention(method) <τ_0_0 where τ_0_0 : AdditiveArithmetic> (@inout τ_0_0, @in_guaranteed τ_0_0, @thick τ_0_0.Type) -> () // user: %18
  %18 = apply %17<P<Double>>(%2, %12, %16) : $@convention(method) <τ_0_0 where τ_0_0 : AdditiveArithmetic> (@inout τ_0_0, @in_guaranteed τ_0_0, @thick τ_0_0.Type) -> ()
  destroy_addr %12 : $*P<Double>                  // id: %19
  dealloc_stack %12 : $*P<Double>                 // id: %20
  %21 = load %2 : $*P<Double>                     // users: %25, %28
  %22 = metatype $@thin P<Double>.Type            // user: %24
  // function_ref static P<A>.zero.getter
  %23 = function_ref @$s4diff1PVAAs18AdditiveArithmeticRzlE4zeroACyxGvgZ : $@convention(method) <τ_0_0 where τ_0_0 : AdditiveArithmetic> (@thin P<τ_0_0>.Type) -> @out P<τ_0_0> // user: %24
  %24 = apply %23<Double>(%2, %22) : $@convention(method) <τ_0_0 where τ_0_0 : AdditiveArithmetic> (@thin P<τ_0_0>.Type) -> @out P<τ_0_0>
  debug_value %21 : $P<Double>, let, name "data", argno 1 // id: %25
  destroy_addr %2 : $*P<Double>                   // id: %26
  dealloc_stack %2 : $*P<Double>                  // id: %27
  return %21 : $P<Double>                         // id: %28
} // end sil function '$s4diff1zySdAA1PVySdGFTJpSpSr'

As can be seen from the above code, the compiler creates P.TangentVector by directly initializing P using <P as AdditiveArithmetic>.zero.getter, which is valid since we have defined P's AdditiveArithmetic conformance requirements.

Based on the analysis so far we have a few questions.

Should the compiler be type-checking the user-defined TangentVectors at the field level, for protocol conformances?
a. If it does, we will not be able to support use-cases where we want TangentVectors to contain non-differentiable fields -- at least not without creating separate corresponding TangentVector types.
b. This would essentially mean that if the user is declaring TangentVector as Self, it better be the same thing as what the compiler might have synthesized for them.

Is this a type checking issue at all? Could/should the compiler have generated code, containing operations, that it knows are valid?
a. I'm referring to the compiler creating a P.TangentVector using <P as AdditiveArithmetic>.zero.getter.
b. Unless, I'm missing something, it seems like the compiler does not have a way to guarantee AdditiveArithmetic-ness of members of a type for which we have manually defined AdditiveArithmetic protocol requirements.

@rxwei @dan-zheng I would appreciate your guidance on this and would love to hear your guys' thoughts.

Pasting Richard's comments (provided over email).

It should still be semantically sound to allow non-differentiable members in a custom tangent vector, so long as it conforms to AdditiveArithmetic and defines its zero and arithmetics.
Looking at #66522, I think the actual underlying problem is that the compiler overused the struct instruction to create tangent vectors.  Using a struct instruction is only acceptable when both these conditions are met:

TangentVector is defined in the same compilation unit of differentiation.
All of TangentVector’s stored properties have a same-name differentiable property in the original type.

The crashing test case did not satisfy (2). In this case, I think what the compiler should do is calling TangentVector.zero to initialize a tangent vector and calling += on each vector component.  Performance aside, I think this is the semantically correct code to generate.

In this particular case the adjoint is generated for struct_extract instruction. So we do not need to call += on each vector component – as all but one entries on rhs are zeros in any way, we just need to do += for a single tangent struct member.


Updated to latest k3po

Coverage increased (+0.01%) to 46.25% when pulling a82169fec8b1e41465256b71e159b71547329415 on dpwspoon:develop into 87469d32e436efea40556181b7ea06728cc95a1e on kaazing:develop.

Coverage increased (+0.01%) to 46.25% when pulling a82169fec8b1e41465256b71e159b71547329415 on dpwspoon:develop into 87469d32e436efea40556181b7ea06728cc95a1e on kaazing:develop.


fix(mission_planner): consider overlap lanelets when enable_correct_goal_pose param is true

Description
fixes: https://github.com/autowarefoundation/autoware.universe/issues/5530
Tests performed
https://github.com/autowarefoundation/autoware.universe/assets/32412808/0a0f1cc0-aeaf-4330-b0da-fc1cdae81822

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@beyzanurkaya is it ok to update this branch?

@kosuke55 sure, I rebased the branch onto main.

@kosuke55 @beyzanurkaya
I am working on a PR also covers/solves this issue. So when I am done, I would like to review this PR as well before we possibly merge it.

@beyzanurkaya @mehmetdogru
thanks!
I ran tier4 internal scenario test just now, I will review this after checking the result is no problem

@beyzanurkaya could you resolve the conflicts and update this PR?
Do you have any blockers or questions on this PR?

I would suggest to first squash, then rebase to make it easier to resolve the conflicts. You can contact me if you need help.


Issue creating EPUB File

Hi,
I'm facing an issue after downloading the content to create the EPUB file, book<PHONE_NUMBER>047
[-] Creating EPUB file...
[#] API: [+] Use the `--cred` or `--login` options in order to perform the auth login to Safari.

I tried to re-run the whole process but no difference at all. Also, I'm using SSO to authenticate with cookies.
Any help will be very appreciate
Thank you

[23/Jan/2021 18:37:20] Last request done:
        URL: https://learning.oreilly.com/api/v1/book/1234567890/toc/
        DATA: None
        OTHERS: {}

        404
        Connection: keep-alive
        Content-Length: 45
        server: istio-envoy
        content-type: application/json
        strict-transport-security: max-age=31536000; includeSubDomains
        x-envoy-upstream-service-time: 334
        etag: xxx
        x-content-type-options: nosniff
        x-powered-by: Express
        Accept-Ranges: bytes
        Date: Sat, 23 Jan 2021 17:37:21 GMT
        Via: 1.1 varnish
        X-Client-IP: xxx
        X-Served-By: cache-fra19126-FRA
        X-Cache: MISS
        X-Cache-Hits: 0
        X-Timer: S1611423441.717720,VS0,VE902
        Vary: Accept, Accept-Encoding, Authorization, Cookie

{"error":"Could not fetch table of contents"}

[23/Jan/2021 18:37:20] Last request done:
        URL: https://learning.oreilly.com/api/v1/book/1234567890/toc/
        DATA: None
        OTHERS: {}

        404
        Connection: keep-alive
        Content-Length: 45
        server: istio-envoy
        content-type: application/json
        strict-transport-security: max-age=31536000; includeSubDomains
        x-envoy-upstream-service-time: 334
        etag: xxx
        x-content-type-options: nosniff
        x-powered-by: Express
        Accept-Ranges: bytes
        Date: Sat, 23 Jan 2021 17:37:21 GMT
        Via: 1.1 varnish
        X-Client-IP: xxx
        X-Served-By: cache-fra19126-FRA
        X-Cache: MISS
        X-Cache-Hits: 0
        X-Timer: S1611423441.717720,VS0,VE902
        Vary: Accept, Accept-Encoding, Authorization, Cookie

{"error":"Could not fetch table of contents"}

Definitely an issue with some books only. There is another TOC in XHTML format which perhaps can be used to generate the EPUB TOC. It is at https://learning.oreilly.com/library/view/book-name/1234567890/toc.xhtml. The only issue is parsing it.

Definitely an issue with some books only. There is another TOC in XHTML format which perhaps can be used to generate the EPUB TOC. It is at https://learning.oreilly.com/library/view/book-name/1234567890/toc.xhtml. The only issue is parsing it.


Updated readme with sorting information

Hi! I noticed some additions could be made to your readme and decided to add them.
Here's what I added:

General information about each sorting algorithm
Added links that go more in depth about each sorting algorithm
Added a table of contents to move around the readme easier

Hey! Thank you so much for the contribution!
I really like the algorithm descriptions, provides good information about them and seems overall better :)
When I click on an index link I was expecting to navigate to the section, also I would move the index under the "📊 Sorting Visualizer" title and remove the "Hello, and welcome!" title, what do you think?
Thanks!

Hi! And you're welcome!
That all sounds good to me

Okay, I'll implement the changes then,
Thanks! 🙌


PLAT-129911: Dropdown: Fixed initial focus when open dropdown with 5-way key

Enact-DCO-1.0-Signed-off-by: Stanca Pop<EMAIL_ADDRESS>Checklist

[x] I have read and understand the contribution guide
[x] A CHANGELOG entry](http://enactjs.com/docs/developer-guide/contributing/changelogs/) is included
[x] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
Issue: Initial focus is needed when opening dropdown with 5-way key.
Resolution
Solution: Added handleTransitionShow function to add initial focus when opening dropdown with 5-way key. Fixed UI tests accordingly.
Links
PLAT-129911
Comments

This PR is obsolete.


Question...

Is it possible to assign one of paws movement to the mouse like right click, left click or the scroll bar?

Not yet, but this looks like an interesting feature. I will think on how to add this into the program :D

Not yet, but this looks like an interesting feature. I will think on how to add this into the program :D

ovo that would be nice~ i have the tendency to use my mouse's scroll bar/right click/left click more than I do with my keyboard. I don't know anything about coding so I spent time trying to find keycodes for the mouse but there obviously wasn't any LOL.
Can't wait for if that feature comes, but no rush of course~

Okay based on this link, you can use 1 for left button and 2 for right button, and I tested and it seems correct. I will update the link in the wiki with this link instead :)

Okay based on this link, you can use 1 for left button and 2 for right button, and I tested and it seems correct. I will update the link in the wiki with this link instead :) For now, there are no easy scroll wheel detection.

thank you so much!~ Its absolutely what I needed ovo/


Rename RopeModule to _RopeModule in CMakeLists.txt to match Package.swift

This PR renames RopeModule defined in CMakeLists.txt to _RopeModule, matching the one defined in Package.swift.
Checklist

[x] I've read the Contribution Guidelines
[x] My contributions are licensed under the Swift license.
[x] I've followed the coding style of the rest of the project.
[ ] I've added tests covering all new code paths my change adds to the project (if appropriate).
[ ] I've added benchmarks covering new functionality (if appropriate).
[ ] I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
[ ] I've updated the documentation if necessary.

(All uncompleted tasks are not applicable to this PR)

@swift-ci test

We are actually targeting release/1.1. I'll close this one and reopen a new PR.


[core] Fix relative mouse mode for PLATFORM_DRM

Changes

Fixes the issue causing the PLATFORM_DRM examples with 3D cameras (e.g.: models_first_person_maze, core_3d_camera_free, etc) moving uncontrollably, by adding more handling for the relative mouse mode (R124, R404, R414, R528-R533, R1548-R1557, R1565-R1574), similar to how it was done for PLATFORM_DESKTOP_SDL.

Notes
I understand the input system is getting reworked for PLATFORM_DRM. Just submitting this to not leave the relative mouse movement broken for the examples and the future 5.0 release in the meantime.
Reference
https://github.com/raysan5/raylib/issues/3487
Environment
Tested on Raspberry Pi 3 Model B 1.2 with Linux (Raspberry Pi OS 11 Bullseye 32-bit armhf).
Edits
1: added line marks; editing.

I understand the input system is getting reworked for PLATFORM_DRM. Just submitting this to not leave the relative mouse movement broken for the examples and the future 5.0 release in the meantime.

@ubkp Sure! That's the priority at the moment! Not sure if the new input system will be ready by mid-November (@michaelfiber), in any case it's good to have it working as is now.


Updates dependencies & fixes tests

Updates dependencies via bundle update. I had to specify a minimum version for Middleman otherwise it would default to a release candidate version for some reason, and that caused a domino effect of other issues! I also had to specify a maximum version of html-pipeline for the same reason as https://github.com/alphagov/govuk-developer-docs/commit/e9541eb4d01d1fb4b883041ca211613086618641.
Updates tests, including fixing fixture data which contained YML content (and was referred to as YML in the tests) but was saved as a .json file, and ensures we stub the right URLs. announcements are no longer a thing, so I now test against redirect (wanted to retain the ability to test applications that have no dependencies, as was the case with announcements).
Fixes #1807

Have raised https://github.com/alphagov/govuk-developer-docs/issues/1821 👍


[RESOLVED] High ICMP ping loss

Problem started at 09:19:29 on 2023.04.27
Problem name: High ICMP ping loss
Host: HP_iLO
Severity: Warning
Operational data: Loss: 33.33 %
Original problem ID: 20033
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23267&eventid=20033

Problem has been resolved in 4m 0s at 09:23:29 on 2023.04.27
Problem name: High ICMP ping loss
Host: HP_iLO
Severity: Warning
Original problem ID: 20033


[WIP] Added cursor types and implemented whole cursor logic

Summary of the PR
This adds the implementation of the cursor interface. Aside custom cursors there is now also the option to use standard (built-in) cursor shapes.

I tested it and it works quiet well. The only things I am not sure about is the disposing logic (especially the ugly try-catch-blocks) and the behavior if the user provides bad values for custom cursors.
As each property must be set on its own their will always be a bad intermediate state. Like settings pixels, width and height step-by-step will always lead to inconsistent information until all the values are setup. For now the cursor is set to null (default cursor) if the custom cursor state is not valid.

Ok I will have a look at it later.

@Perksey Ready for merge. :)

Awesome, thanks!


Add daisy chaining, tests, docs

Looks good! Let me get on my PC in a minute and take a better look.

Looks good this time. Merging soon.

Fork the main switch-luau repo and start a pr so I can merge it. Alternatively, you can have @ryolikescode merge it into his repo and he can start another pr.


Sensordots Mappydot+ driver

Driver for Sensordots Mappydot+ (https://sensordots.org/mappydot_plus) rangefinder arrays.
These have a range of up to 4m, can be used for low-level collision avoidance. Support for integrating data from these in collision prevention will come in a follow-up PR.
A large portion of the driver was contributed by @mcsauder!
TODO :

[x] Squash commits before merge
[x] Start all (-a) doesn't actually work
[x] Bench test ranging mode changes

CI fails because PX4_I2C_BUS_EXPANSION2 doesn't exist on some boards.

@mhkabir I am working again on  https://github.com/PX4/Firmware/pull/10998

@dagar ready for review!

Hi @mhkabir and @dagar ,
To validate demonstration of basic functionality of this driver:
Flight Log with 3 downward facing sensors:
https://review.px4.io/plot_app?log=466e6cd2-0faa-4e26-9e09-1879f4f5a11d
QGC screenshot verifying enable param:

FlightPlot graphs of distance sensor data from flight log above:


Fix/cose signature

Quick fix for Release 3.2.0 to correctly serialize COSE sign structure.

I'll suggest to create a release 3.2.1 with the fix


Move version list to the right-hand page

List versions after metadata and remove the dropdown from the blue bar. This is borrowed from Zenodo.
Examples

WDLL

update the component that renders the drop down
create a new section between metadata and analytics
create a fixed-height or scrollable section

@nicktiberi I think the preview branch looks good. Just two things I'd like to try:

Remove the time from the dates
Add a place for small help text at the bottom of the box. It can just be filler text for now.

@srerickson - see below:

This is perfect. Thanks!

@nicktiberi lets merge without the text at the bottom (we may add this later)


Computed property in a class

TypeScript Version:  2.1.1 / nightly (2.2.0-dev.201xxxxx)
Code
declare class Person {
    name: string,
    age: number
}

declare class Test {
    [K in keyof Person]: Person[K]; // Error: A computed property must be of type...
}

Expected behavior:
It should work like in a type declaration
Actual behavior:
It doesn't allow use computed properties in a class

Mapped types are not allowed in classes. only in types. Not sure i understand what you are trying to do, but you can define a class as a constructor function if you need to.


docs:  add specific info to enable cost breakdowns

Issue : Cost breakdowns were always empty in a version of SWB deployed in a test account.
Description of changes:
Cost allocation tags need to be activated in order to get actual cost reports.
We figured that this information was not included in the documentation yet.
Feel free to correct it if you think of more exact formulations.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SanketD92 I added back the first sentence specifying that Cost Explorer should be set up.


Function to recast longitude values [0,360[ or [-180,180[

lon = longitude_unwrap(lon,pivot=[180,360]) : recast longitudes in [-180,180[ or or [0,360[
See in jLab deg180.m, deg360.m and inversion degunwrap.m

This is what I used, it's very simple but might be useful.
@nb.jit
def deg360(lon):
    """Convert longitude array from [-180, 180] to [0, 360]"""
    return np.mod(lon, 360)

@nb.jit
def deg180(lon):
    """Convert longitude array from [0, 360] to [-180, 180]"""
    return deg360(lon + 180) - 180

It may be occasionally useful to unwrap longitude not starting at 0 or -180.  For example, sometimes I like to start at 20°00 East, the southern tip of Africa, as this avoids cutting the major ocean basins.
The following Matlab code will take longitude x in -180:180 or 0:360 and return it so that it ranges from lono to 360+lono.
x=deg360(frac(360,2pi)unwrap(angle(rot(frac(2pi,360)(x-lono)))))+lono
the function rot is define as rot(x)=exp(ix);
Thus, choose lono=-180 to convert to -180:180 or lono=0 to convert to 0:360.

https://github.com/Cloud-Drift/clouddrift/issues/63#issuecomment-1367428773 seems to me the way to go, one general function rather than 180- or 360-specific ones.


vitest with prisma failing randomly in CI

Describe the bug
We are currently migrating our test-suite from jest to vitest. Everything runs smoothly locally, but on CI (Gitlab ci with k8s runner in our k8s cluster) the tests fail randomly every second or third run.
We have almost 1000 test across 115 test files, when it fails it's 1 or 2 random testfiles having one of the following errors:
Error: Cannot find module '.prisma/client/default'
Require stack:
-<EMAIL_ADDRESS>
or
⎯⎯⎯⎯⎯⎯ Unhandled Errors ⎯⎯⎯⎯⎯⎯
Vitest caught 1 unhandled error during the test run.
This might cause false positive tests. Resolve unhandled errors to make sure your tests are not affected.
⎯⎯⎯⎯ Unhandled Rejection ⎯⎯⎯⎯⎯
PrismaClientInitializationError: Prisma Client could not locate the Query Engine for runtime "debian-openssl-3.0.x".
This is likely caused by tooling that has not copied "libquery_engine-debian-openssl-3.0.x.so.node" to the deployment folder.
Ensure that you ran `prisma generate` and that "libquery_engine-debian-openssl-3.0.x.so.node" has been copied to "node_modules/.prisma/client".
We would appreciate if you could take the time to share some information with us.
Please help us by answering a few questions: https://pris.ly/engine-not-found-tooling-investigation
The following locations have been searched:
  /builds/xxx/node_modules/.prisma/client
  /builds/xxx/node_modules/@prisma/client
  /tmp/prisma-engines
  /builds/xxx/prisma

The files it can't find are in the node_modules folder.
We are already running with --pool=forks and tried different settings in regards to poolOptions, but still the same behaviour.
We did also compare the modules dump of a failed and successful run (which was exactly the same).
Any ideas how to solve that?
Reproduction
Run vitest in gitlab ci with a test suite using prisma
System Info
System:
    OS: Linux 5.10 Debian GNU/Linux 12 (bookworm) 12 (bookworm)
    CPU: (8) x64 Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
    Memory: 28.55 GB / 30.99 GB
    Container: Yes
    Shell: 5.2.15 - /bin/bash
  Binaries:
    Node: 22.9.0 - /usr/bin/node
    Yarn: 1.22.22 - /usr/bin/yarn
    npm: 10.8.2 - /usr/bin/npm
  npmPackages:
    @vitest/coverage-istanbul: ^2.1.1 => 2.1.1
    vitest: ^2.1.1 => 2.1.1

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Can't really help without a reproduction. Maybe you are removing the prisma folder or regenerating it during a test? So when another test runs in parallel, the folder is no longer there. Try running tests with --single-worker (much slower) and --no-isolate (tests might break if they rely on a shared state). You can also try running tests with the --sequence.shuffle to randomise the order.

thanks @sheremet-va for your quick response.
I did find the issue: we do some parallel, transactional testing therefore we need to run migrations within each worker. We call prisma migrate reset but this does re-generate the client implicitly if not skipped with --skip-generate.


Update FindLibCrypto.cmake to search for libcrypto.dylib as well to s…

…upport Macs
Please note that while we are transitioning from travis-ci to AWS CodeBuld, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Issue # (if available):
N/A
Description of changes:
On Macs the shared library extension is .dylib. This updates FindLibCrypto to find either.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request head (evp_pkey@8081ede). Click here to learn what that means.
The diff coverage is n/a.


Consider the ability to allocate variants based on custom filters

Variants are going to be a huge boon to this library and I'm excited to leverage them.  I often find myself creating custom filters that evaluate based on the application state rather than the traditional user centric targeting scenarios. It would be great if we could allocate variants based on these filters. Perhaps something like:
  "FeatureManagement":
  {
      "MyVariantFeatureFlag":
      {
          "Allocation": {
              "DefaultWhenEnabled": "Small",
              "AllocatedFor": [
                  {
                      "Name": "CustomFilter",
                      "Parameters": {
                          "SomeParam": "SomeValue"
                      },
                      "Variant": "Big"
                  }
              ]
          },
          "Variants": [
              {
                  "Name": "Big"
              },
              {
                  "Name": "Small"
              }
          ]
      }
  }

It's an interesting idea. With your suggestion, what would you expect the implementation of "CustomFilter" to look like?

@jimmyca15 - I haven't gone too deep on the allocation code after I saw it was all private and I couldn't extend it myself. Could it be as simple as:
public interface IContextualVariantFeatureFilter<TContext> : IContextualFeatureFilter<TContext> {
    string Variant { get; set; }
}

Hi, @CuddleBunny  Thank you for your suggestion. This is an interesting idea.
But, there is one thing I want to call out here. For the code snippet you provided here, I found that you were using .NET Feature Management schema to declare a variant feature flag. We had a PR to remove the variant & telemetry support from the .NET FM schema. The reason is that, starting from v4.0.0, we are going to embrace the Microsoft Feature Management schema which will replace .NET FM schema to be the primary schema for the .NET feature management library. Please see here and #408.
Now, our latest releases have fully supported the Microsoft FM schema. The latest preview release 4.0.0-preview3 can still recognize the variant feature flag specified in .NET schema but our next preview release will only recognize variant feature flag specified in Microsoft FM schema.
Besides, all the example projects in preview branch and example code snippets in our public doc for preview version have been changed to Microsoft FM schema. You can have a look at them. Thank you so much!

@zhiyuanliang-ms - I saw the PR for the schema changes but hadn't looked into it yet. The docs I found for variants was in the release/v4 branch. I see that they were changed in the preview branch. If I understand the new schema correctly, the result would be something like the following, but I suspect the underlying code wouldn't change much?
{
    "feature_management": {
        "feature_flags": [
            {
                "id": "MyVariantFeatureFlag",
                "enabled": true,
                "allocation": {
                    "default_when_enabled": "Small",
                    "client_filters": [
                        {
                            "name": "CustomFilter",
                            "parameters": {
                                "SomeParam": "SomeValue"
                            },
                            "variant": "Big"
                        }
                    ]
                },
                "variants": [
                    {
                        "name": "Big"
                    },
                    {
                        "name": "Small"
                    }
                ]
            }
        ]
    }
}

{
"feature_management": {
"feature_flags": [
{
"id": "MyVariantFeatureFlag",
"enabled": true,
"allocation": {
"default_when_enabled": "Small",
"client_filters": [
{
"name": "CustomFilter",
"parameters": {
"SomeParam": "SomeValue"
},
"variant": "Big"
}
]
},
"variants": [
{
"name": "Big"
},
{
"name": "Small"
}
]
}
]
}
}

This is correct.

I suspect the underlying code wouldn't change much
You are right. The code didn't change much.


When a person gets unpinned you have to search them each time you want to talk to them

When a person is pinned but then becomes unpinned they don't appear in the main page and you have to search then up each time you wanted to talk to them (a lot of features cannot be done like repin them), this also affects the web app as well.

What do you mean by "becomes unpinned"?

When you unpin someone they disappear

Please show a screen recording


Change naming convention for folders to append index after the name

Summary
This pull request modifies the unique_name function in the path.rs file to change the naming convention for folders. Instead of inserting an index before the last dot in the folder name, the index is now appended at the end of the folder name. This change aims to improve the clarity and usability of folder names when duplicates are created.
Changes Made

Updated the logic in the unique_name function to check if the path is a directory.
For directories, the index is now appended at the end of the name (e.g., a.b.c becomes a.b.c_1).
Maintained the existing behavior for file names.

Testing

The changes have been tested to ensure that both file and folder naming conventions work as expected.

no problem