Improved Git Integration

The current git pane is pretty minimal and doesn't allow you to commit parts of a file or push/pull/fetch repositories.  I'm working on improving it and would like to know what features would be wanted.  I personally think that atom was/is the gold standard for git integration and will be basing a lot of my work on that, but I'd like to hear other opinions.
Todo:

[ ] Separate unstaged/staged diff lists
[ ] List of recent commits
[ ] Staging parts of a file using git chunks, lines
[ ] Improved controls in diff view
[ ] Push/Pull/Fetch

Not sure what atom does, I got used to lazygit which is quite good too.

JetBrains IDEs are the gold standard in my opinion. Their Git Integration is just so intuitive

If I had one wish, I am missing files with uncommitted changes being highlighted in the folder / tree view on the left hand side.

Personally, I'd like to see a simple "amend commit" option which will apply your changes to the last commit using  the --amend flag.

There's no straightforward way to edit the original file once your viewing a diff

@elibroftw, this is solved by #2004

I would like to see an option for PGP-signed commits git commit -S ...

humble request to those referring other softwares to please either include screenshots, or in case that can lead to copyright, then share mockup demonstrations ....
the "atom was gold standard" or "jetbrains IDEs are [insert metal X] standard" doesn't help much - neither to discussion, nor to the point you are making.

I'd recommend actually trying as many alternatives as possible to anyone serious about putting some work into this area, but I understand where you're coming from.  Atom's spiritual successor pulsar has some good docs that explain the features better than a screenshot of mine would.
On a different note, I never got very far with this due to my unfamiliarity with the GUI libraries being used and lack of experience in rust at the time, so if anyone else wants to work on this, don't let me stop you.


data from glasses

can this possibly access the data from the glasses to termux to control the 3dof?

I tried building headset-utils but I think termux can’t access usb devices
On Tue, Jul 9, 2024 at 7:41 AM mnjm97 @.***> wrote:

can this possibly access the data from the glasses to termux to control
the 3dof?
—
Reply to this email directly, view it on GitHub
https://github.com/3rl-io/spidgets-mobile/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ3FPG27GGLZPCMTMEFEU53ZLPZBBAVCNFSM6AAAAABKTAVXEOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4TQNBQG44DQMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

https://wiki.termux.com/wiki/Termux-usb


MSID: 93267 Version: 1 DOI: 10.1101/2<IP_ADDRESS>0395

MSID: 93267
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>0395
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=93267
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>0395

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/93267v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>0395
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/93267/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

elocations missing from references

@acollings Looks like there's a mis-tagging of the heading for Review 1. Please could this be fixed?

Thanks!
James

Thanks @JGilbert-eLife: this has been updated!

Looks like it already looks good on the Sciety page - https://sciety.org/evaluations/hypothesis:XTxrYMDkEe6MQ08sVZtVvg/content. Re-running the workflow in temporal should resolve the problem I reckon.

Thanks both!


1.4.0 Json Deserialize Exception: converting value {null} to type 'System.Decimal'. Path 'data[457].askPx'

Which method? which endpoint? which model?

It was working fine before.
client = new OKXRestApiClient(new OKXRestApiClientOptions
{
    ApiCredentials = new OkxApiCredentials(accessKey, secretKey, passphrase)
})
client.OrderBookTrading.MarketData.GetTickersAsync(OKX.Api.Enums.OkxInstrumentType.Spot)

It's related with orderbook status. If there is no active orders there wont be best ask or bid. I'll fix this issue in next version. thanks


WIP Change reference to download windows scripts from github

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@MichalFupso I'm going to close this for the time being. When we're ready to engage with this work again, we can reopen or start a new PR.


Added More Configurations for Stories

Implemented:

JoinLeave Button (originally planned to make a story with a knob for this component)
Added webpack.config.js to .stories directory
Added a knob for Layout.stories.js

There seems to be some errors on the storybook, "TypeError: Cannot read property 'query' of null" appears in MembersList, MembersFreeTime, and JoinLeaveButton.

Looks good and test cases are fixed!


[release-1.20] Update embedded containerd to 1.4.9-k3s1

Backport Update embedded containerd to 1.4.9-k3s1 to branch release-1.20:

#3853

This is in v1.20.10+k3s1 and has been validated as using the expected version and sonobuoy and regression checks were all successful.


python312Packages.google-cloud-redis: 2.15.4 -> 2.15.5

Changelog: https://github.com/googleapis/google-cloud-python/blob/google-cloud-redis-v2.15.5/packages/google-cloud-redis/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 339499 run on x86_64-linux 1

4 packages built:

python311Packages.google-cloud-redis
python311Packages.google-cloud-redis.dist
python312Packages.google-cloud-redis
python312Packages.google-cloud-redis.dist


Support of empty captures array

Describe the bug
IQEngine fails and displays errors when browsing the "local to backend" when there is a .sigmf-meta without any captures (present but empty list).
To Reproduce
Steps to reproduce the behavior:

Deploy a local IQEngine with docker as explained in the documentation
Copy a .sigmf-meta file whose content has  "captures": [],
Start docker
Browse the "Local to backend"
Observe the errors about "captures[0]"

Expected behavior
As per specification, an empty array is valid.
In that case,

if there are no items in the captures array it is implied that a single capture with the core:sample_start field equal to zero

Screenshots

mmm, yep I was with Jacob when he added that blurb to the specs 6 months ago, prior to that it was sort of a grey area whether captures: [] was allowed, so yeah we'll get that fixed in IQEngine


EDU-371 Do not propagate click on storage file picker

Closes https://educandu.atlassian.net/browse/EDU-371

Looks really nice! I was still able to toggle between edit/display mode by Ctrl-Click on the black-transparent modal overlay, but I think that's a neglectable problem.

Looks really nice! I was still able to toggle between edit/display mode by Ctrl-Click on the black-transparent modal overlay, but I think that's a neglectable problem.
I noticed that too, but actually to me that's desired behavior, since the grey area click is implemented to dismiss the modal.


New payment modules

Hello,
We have created some time ago two payment modules for plata. One is for pagseguro, a payment platform comparable to paypal mostly used in Brazil. I have also a payment module for check and bank transfert which have specific parts to our shop but can be generalized if needed.
Would you be interested to include them in the plata project ?
You can have a look at the modules at https://github.com/eonpatapon/plata/tree/serviceplace/plata/payment/modules
Thanks

Hi @eonpatapon
Yes, I'd be interested. However, some tests and docs would be a great addition to ensure that the functionality doesn't break in the future.


Add user coreydaley as an approver

/assign @bparees

/approve
/lgtm

@bparees Can you override the need for a bugzilla?

overridden


Error from CreatePipeline

#pachctl create-pipeline -f examples/fruit_stand/pipeline.json
Error from CreatePipeline: rpc error: code = 2 desc = proto: bad wiretype for field pps.PipelineInput.Reduce: got wiretype 2, want 0
#2016/06/13 12:52:38 transport: http2Client.notifyError got notified that the client transport was broken read tcp <IP_ADDRESS>:35954-> w.x.y.z.:30650: read: connection reset by peer.
Context -
Cluster up and running on GCS
Repo created on GCS
Finish commit
Error while creating the pipeline

Hmm, this looks like it's probably a mismatch between the pachctl version and the server version.
What happens if you try rebuilding both of them?

pachctl version
COMPONENT           VERSION
pachctl             1.0.0(dirty)
pachd               1.0.0(849)
pachctl version - returns version (of the server on which pachyderm is deployed right?)
By server version, do you refer to the pachyderm github repo version or kubectl version?
My kubectl version is
kubectl version
Client Version: version.Info{Major:"1", Minor:"2", GitVersion:"v1.2.4", GitCommit:"3eed1e3be6848b877ff80a93da3785d9034d0a4f", GitTreeState:"clean"}
Server Version: version.Info{Major:"1", Minor:"2", GitVersion:"v1.2.4", GitCommit:"3eed1e3be6848b877ff80a93da3785d9034d0a4f", GitTreeState:"clean"}

Hi there -
That's helpful. FYI - when we refer to server version we're asking for the pachd version string reported from the first command you ran. That command reports the version of pachctl (the client) and pachd (the server).
Since you're using a build of the client from source, its a bit hard to tell if its mismatched. Please try the following:

pull the latest pachyderm code (git pull origin master)
rebuild the client (make install)
retry making the pipeline
if that doesn't work, report the current commit you're on (git log | head -n 1)

Pretty sure this was just a version mismatch. Closing.


PytorchVideo - Lightning Training pipeline

Summary:

Support Video classification
Support Video SSL - SimCLR, BYOL, MoCo

Differential Revision: D33431232

Codecov Report

Merging #158 (456d397) into main (6744240) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   94.67%   94.67%
=======================================
  Files         132      132
  Lines        8302     8302
=======================================
  Hits         7860     7860
  Misses        442      442

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6744240...456d397. Read the comment docs.


npm package 1.0.0 is missing tests and license

test.js and LICENSE are missing from the 1.0.0 tarball on npm. Can you please include them?
$ tar tzf ./normalize-path-0.3.0.tgz
package/package.json
package/.npmignore
package/README.md
package/test.js
package/index.js
package/.gitattributes
package/.jshintrc
package/bower.json
package/.verbrc.md
package/LICENSE-MIT
package/benchmark/index.js
package/benchmark/code/no-regex.js
package/benchmark/code/node-path.js
package/benchmark/code/regex.js
package/benchmark/fixtures/long.js
package/benchmark/fixtures/path-14.js
package/benchmark/fixtures/path-15.js
package/benchmark/fixtures/path-16.js
package/benchmark/fixtures/path-13.js
package/benchmark/fixtures/path-18.js
package/benchmark/fixtures/path-2.js
package/benchmark/fixtures/path-3.js
package/benchmark/fixtures/path-4.js
package/benchmark/fixtures/path-5.js
package/benchmark/fixtures/path-12.js
package/benchmark/fixtures/path-6.js
package/benchmark/fixtures/path-11.js
package/benchmark/fixtures/path-7.js
package/benchmark/fixtures/path-10.js
package/benchmark/fixtures/path-8.js
package/benchmark/fixtures/path-1.js
package/benchmark/fixtures/path-9.js
package/benchmark/fixtures/path-0.js
package/benchmark/fixtures/short.js
package/benchmark/fixtures/path-17.js
$ tar tzf ./normalize-path-1.0.0.tgz
package/package.json
package/README.md
package/index.js

generally test.js is ignored from npm, I can include license though

closing since LICENSE is supposed to be included by npm and test files should never be published to npm


Always reporting Idling

When I did a check on what the extension is showing on Discord, it always says "Idling", no matter what I do.
I am working with Python in a folder that also is a git repo.

The problem should be fixed in the newly released version, please upgrade to the extension and let me know if the problem is fixed.


[npm audit] Update Ava

Some of its dependencies represent some security problems.
node-static too but I don't know if there is a replacement.

fixed: thanks!


The split learning example was based on a previous implementation of Plato and stopped working.

Update Split Learning so that it works with the current release of Plato.

Got it, I wll check it later. Thanks for friendly reminder.


Most recent projects are showing deleted items

Release Type: Both
Version: All
Platform(s): Windows
Describe the bug
When you delete a xenko project the Launcher and Game Studio don't remove it from recently files list.
To Reproduce
Launcher:

Delete a project
Open Launcher

Game Studio:

Delete a project
Open Game Studio or go to new project window

Expected behavior
If the project was deleted is expected that the project doesn't show more in recent files list.
Screenshots

Log and callstacks
Not applicable
Additional context
Not applicable
**Please, assign to me.

FYI some software (i.e. Visual Studio) don't delete until you actually try to open and it asks you if you want to delete it.
One guess why they do this is that your project might be an a USB stick or network drive that you might have forgot to mount before start starting VS.
Simply wanted to remind you of this use case, not saying we have to do the same.

This way is interesting I'll test it! I realized now that we'll need an option to remove a project from the list too, just like visual studio does.


Fix cold takes duplicates

There was a bug where the dataset would go to https://www.cold-takes.com/, and first take all the urls from the "featured posts" section, and then take all the urls from the "all posts" section, and so the featured posts were all duplicated twice in the cold_takes dataset. Now I ignore the featured posts and the duplicates are gone.

It appears I have not commited / published the right thing. I am very confused, my bad

I suppose that this PR, on top of fixing cold takes duplicates bug, updates the analyse_jsonl_data.py file to check for duplicate urls, which was useful for verifying that the blogs + stampy did not have any duplicated urls. In fact they did, which made me notice and fix the cold_takes blog issue, but there are still two duplicated urls among the blogs:
Url: https://aisafety.info?state=616
first_duplicate: source: aisafety.info, title: Could AI alignment research be bad? How?, date_pub: 2023-05-13T08:00:17Z, url: https://aisafety.info?state=616
second_duplicate: source: aisafety.info, title: Why might an AI do bad things?, date_pub: 2023-06-22T18:10:06Z, url: https://aisafety.info?state=616
and
Url:
first_duplicate: source: waitbutwhy, title: The Artificial Intelligence Revolution Part 2 - Wait But Why, date_pub: 2015-01-27T00:00:00Z, url:
second_duplicate: source: waitbutwhy, title: The Artificial Intelligence Revolution Part 1 - Wait But Why, date_pub: 2015-01-22T00:00:00Z, url:
I notice that the changes I made in the other branch seemed to propagate to this one? I am confused. I suppose the id being optionally changed by using the id_fields key of the DataEntry class, as a feature, is present here as well.


clipboard-sys not supported

What version of pkg are you using?
5.11.5
What version of Node.js are you using?
20.11.1
What operating system are you using?
windows
What CPU architecture are you using?
x86_64
What Node versions, OSs and CPU architectures are you building for?
node20
Describe the Bug
I use clipboard-sys to copy image to cilpboard, on windows, i canuth an error:
Command failed with ENOENT: C:\snapshot\buddy\node_modules\clipboard-sys\dist\bin\win_clipboard.exe
Expected Behavior
no error
To Reproduce
const {clipboard} = require('clipboard-sys');
await clipboard.writeImage('C:\User\abc\a.png');

@cage1618 Try adding node_modules\clipboard-sys\dist\bin\win_clipboard.exe to assets

I was tried，no effect

I add node_modules/clipboard-sys/**/* to the assets

I think the exe should be moved to local directory before executing it, dunno if you can copy it to a temp dir and specify a custom path to the exe when running the command

like temp dir？

I copy the file to the root dir, still not work

No clue I'm sorry

my soluation:
1.use fs.readFile and fs.writeFile copy the binairy file from snapshot filesystem to real filesystem
2. use execa or child_process.exec execuate it
note: you must have write permission of the target dir on the real filesystem.


Fix typographical errors in introductory texts

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example only English changes, or only Chinese changes, etc.

Closes #XXXXX

This PR adds an omitted word into the introductory message for the challenge: "Advanced Node and Express".
At the moment, the first sentence of the second paragraph in the introduction reads:

The most common and easiest to use authentication middleware for Node.js is Passport.

Reading this carefully reveals that "way" is missing after the word "easiest" - which is what was added in this Pull Request. It would now read like this:

The most common and easiest way to use authentication middleware for Node.js is Passport.

Cheers!

@iamwebwiz Thank you for your contribution to the page! :+1:
We're happy to accept these changes, and look forward to future contributions. :memo:


Add app-containers/docker-buildx

This is to address a deprecation message that shows up when building docker images with docker build:
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/4438/cldsv/
docker.go:370: creating netcat containers
cluster.go:125: DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
cluster.go:125:             Install the buildx component to build images with BuildKit:
cluster.go:125:             https://docs.docker.com/go/buildx/

The PR also drops some obsolete scripts.

[x] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
[x] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

CI passed. Another 23mb in /usr taken, because the buildx backend binary is 70mb (crazy!).

CI passed. Another 23mb in /usr taken, because the buildx backend binary is 70mb (crazy!).

btrfs compression pays off really well.

Are we supposed to have Docker build tools in the production image?

Are we supposed to have Docker build tools in the production image?

I think so. Why? docker build is a part of docker itself, so it was always a part of production images. Or rather - a part of docker base sysext. And some of our kola tests use docker build.

I just find it odd given that we don't have other build tools, but I guess you don't need other build tools for docker build to be useful.

To expand on this, I feel that you might have removed docker build if you'd been able to before. I don't think adding buildx just because you couldn't remove build before isn't a strong reason. Keep in that mind that the docker-buildx binary is about 85MB.

I just find it odd given that we don't have other build tools, but I guess you don't need other build tools for docker build to be useful.

And…

To expand on this, I feel that you might have removed docker build if you'd been able to before. I don't think adding buildx just because you couldn't remove build before isn't a strong reason. Keep in that mind that the docker-buildx binary is about 85MB.

 The saving grace here is that we use compressed btrfs, which shrinks that beast to 20mb.
But honestly, I don't think anyone (certainly not me!) has put any thought of removing having parts of docker that are of some use only in generic images (like docker build). So, thinking about it right now: I'm not sure how good it would sound to user that we have some cut-down version of docker. My uneducated guess would be that most users wouldn't care, because Flatcar is for running docker images, not building them. On the other hand - removing docker build it's another patch in need of maintaining. Tradeoffs, tradeoffs.
Hm. Some of our tests are using docker build, but that's our code, so we can work it around. How about the following plan:

We merge this PR, so generic image has a buildx plugin, no pesky deprecation messages are printed.
We eventually turn our developer container into a sysext image (I think Thilo wanted to do it), so we could move the plugin there.
We patch the docker message telling user to download the developer container sysext for the best experience (or for the actually working solution, because the deprecated functionality is going to be eventually dropped).
All those steps would require some deprecation process - possibly a news item for a release announcing the plans would be enough).

Sounds good, but maybe instead of patching Docker, you could just drop in a dummy buildx binary that errors with a message like that.

Filed an issue: https://github.com/flatcar/Flatcar/issues/1529

CI passed.


Create .travis.yml

Builds are passing on my fork

:+1:
I've enabled travis. Could you please push a new version to test the setup?

Not sure what you mean by push a new version. I've ran rustfmt on the project to trigger the build

Interesting. cargo test is run but no tests are run

I think you need to enable diesel/sqlite as cargo feature to run the tests.

Got the tests running

Thanks :+1:


Retry POST requests that fail with a badNonce error

Fixes #66.

This change is

Current coverage is 100% (diff: 100%)

Merging #95 into master will not change coverage

@@           master    #95   diff @@
====================================
  Files          27     27
  Lines        1936   1957    +21
  Methods         0      0
  Messages        0      0
  Branches      172    173     +1
====================================
+ Hits         1936   1957    +21
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update e7125d1...37a7996

:heart: @jerith I was just about to look into this.. currently seeing this error often.

@JayH5 Are you able to quantify "often" more precisely? I've seen sporadic complaints about this from various people, and it should be a pretty rare occurrence even without this branch, so I'm wondering if there's some underlying bug in either txacme or Boulder that is causing it to occur more often.
(Basically, the only scenario I'm aware of that should cause it is when Boulder is restarted for an upgrade, invalidating all extant nonces)

Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/txacme/client.py, line 886 at r2 (raw file):

        def retry_bad_nonce(f):
            f.trap(ServerError)
            if f.value.message.typ.split(':')[-1] == 'badNonce':

The latest ACME RFC defines the errors in the urn:ietf:params:acme:error: namespace. In some earlier drafts (and in what Boulder actually implements), the namespace is urn:acme: instead. I assume this is why you have this slightly fuzzy comparison here, which I think is fine, but can you also add a comment explaining this?

Comments from Reviewable

@mithrandi our software is very... beta... but I've had a thing running trying to issue a certificate for a domain over the weekend. We're currently hitting the LE rate limit, though, so it's been failing consistently. We get a rateLimited error most of the time but sometimes it is a badNonce one instead. Admittedly this is a bit of a weird test but I have numbers based on the logs.

Running for just less than 3 days (2016-11-18T15:18:34+0000 -> 2016-11-21T11:43:57+0000)
279 attempts to issue the cert
232 rateLimited errors
47 badNonce errors (~17%)

Hmm, I don't think there were any LE Boulder upgrades in that timeframe.

After chatting with some LE people, it seems nonces also expire after some time, so that makes it very likely that you'd run into these errors in a long-running txacme-using process. This PR should solve that :tada:

Review status: all files reviewed at latest revision, 2 unresolved discussions.

a discussion (no related file):
@jerith: One other thing, could you add a news fragment? This seems changelog-worthy in light of the above.

Comments from Reviewable

After chatting with some LE people, it seems nonces also expire after some time, so that makes it very likely that you'd run into these errors in a long-running txacme-using process.  Maybe we should expire nonces on our side or just clear them all on a badNonce error?

Hmm, I was thinking there would only ever be one nonce, but you can actually get more than one nonce when making concurrent requests. Clearing them all sounds like a reasonable idea; at worst, you're incurring an needless roundtrip to fetch a new initial nonce, which isn't a big deal given all of the other inherent latencies here.

Hrm. I missed that we're only (passively) getting nonces from requests that themselves use nonces. Ideally, we'd clear all nonces except the one we just received, but the code for that would be awkward.

Reviewed 1 of 1 files at r4, 2 of 2 files at r5.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


chore: Add pycache to  gitignore

SUMMARY
We use rsync to sync local code changes to remote machines for debug. This small PR makes sure empty __pycache__ folders aren't synced when using rsync   --filter=":- .gitignore".
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Not needed
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11208 into master will decrease coverage by 1.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11208      +/-   ##
==========================================
- Coverage   61.38%   59.95%   -1.43%
==========================================
  Files         828      392     -436
  Lines       39145    24544   -14601
  Branches     3589        0    -3589
==========================================
- Hits        24028    14716    -9312
+ Misses      14937     9828    -5109
+ Partials      180        0     -180

Flag
Coverage Δ

#javascript
?

#python
59.95% <ø> (-0.88%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
31.91% <0.00%> (-59.58%)
:arrow_down:

superset/db_engine_specs/hive.py
53.90% <0.00%> (-30.08%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/api.py
81.38% <0.00%> (-7.98%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

superset/databases/schemas.py
94.77% <0.00%> (-5.23%)
:arrow_down:

... and 451 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5561b42...5f755ed. Read the comment docs.


fix peer dependency typo

Updated package.json

changed peerDependencies['react-react-fiber'] to peerDependencies['react-three-fiber']
updated version from 0.0.32 to 0.0.33

Oops, noticed this is a duplicate of https://github.com/react-spring/drei/pull/9


propseal for modification to drop_test_schema

resolves # https://github.com/dbt-labs/dbt-redshift/issues/110
Description
Test files where getting locked due to transactions leaving them in database after test ended leading to error:
psycopg2.errors.InternalError_: 1040
DETAIL:  Maximum tables limit exceeded. The maximum number of tables per cluster is 9900 for this instance type. The limit includes permanent and temporary tables. (pid:25694)

due to database reaching limit on tables.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

@gshank, @jtcohen6  was wondering if this change seems reasonable or if it posses any known problems?

The reason I used adapter.drop_schema was in theory to use more adapter specific macros/methods. Do you know why this works and adapter.drop_schema doesn't?

for redshift I think the drop_schema method attaches the cascade to it which doesn't work if a table is locked due to a current transaction.

It's been a while since I had to interact with Redshift, but I do vaguely remember that dropping tables in Redshift didn't necessary give back everything... you had to recover the space, etc, by .... vacuuming? It's been a while. I'm wondering if this is a Redshift management thing anyway.

Also the "drop_schema" default implementation (which I believe is used by Redshift) is: drop schema if exists {{ relation.without_identifier() }} cascade. So that code should pretty much be doing the same thing as what's happening here.

today i've continued playing around with what tests do leave files after running, non of the older integration tests have today, its only the 11 files generated by the new functional tests, so could this be an issue with how the fixtures work by chance? the initiating models/seeds staying open technically being a active transaction against the tests?

Also the "drop_schema" default implementation (which I believe is used by Redshift) is: drop schema if exists {{ relation.without_identifier() }} cascade. So that code should pretty much be doing the same thing as what's happening here.

One thing that is different is that the older test framework used the initial adapter that was created by test/integration/base.py, which meant that we had to patch providers. In order to avoid that patching, the new tests now use the latest adapter. I wouldn't think that would make a difference. It's pretty much the same thing that you get when you run separate CLI dbt commands (a "new" adapter object every time).

By "leave files after running", you actually mean "leave schemas after running"?

Also, what query are you running to see what tables are left over, and what are the schema/table names?

Also, what query are you running to see what tables are left over, and what are the schema/table names?

General process to look this over has been to move breakpoints throughtut the process even tried to debug in the macro which is interesting.
then in postico or whatever you need to sign in as super user to see lock tables and other relevant information
various commands run:
to see if you can drop the talbe
--drop schema if exists "test16512569692993986231_test_basic" cascade;
to look at current locked files
select table_id, last_update, lock_owner, lock_owner_pid from stv_locks;
see open locked. tables
select "table" from svv_table_info where table_id = <Insert a table_id from above command>;
to get more information about table like what type of lock is on table.
select * from svv_transactions;

Something wonky is going here when calling self.adapter.drop_schema(relation) for redshift specifically that is difficult to debug. I have a feeling it is related to this bit of code https://github.com/dbt-labs/dbt-redshift/blob/6543b82bf5943e2bc272880984380205437d49e6/dbt/adapters/redshift/impl.py#L36-L52. While this PR isn't a solution, it works properly for dropping schemas created by tests in dbt-redshift. I'm still working to understand why though..

So it sounds like the problem is with the drop_schema/drop_relation redshift code, not the test_drop_schema per se.

The base implementation of "drop_relation" in core/dbt/adapters/sql/impl.py does "self.cache_dropped(relation)", but the redshift version doesn't.

The base implementation of "drop_relation" in core/dbt/adapters/sql/impl.py does "self.cache_dropped(relation)", but the redshift version calls the super version... so the only thing different is the fresh_transaction bit?

Yeah which applies the exclusivelock and starts a new transaction. but is supposed to drop it to allow us to use drop_relation from core

It looks like adapter.drop_schema doesn't work in postgres either.

I looked at the logs and the 'drop_schema' call was getting rolled back every time. The 'drop_schema' method in core/dbt/adapters/sql/impl.py did not have a commit. I added "self.commit_if_has_connection()" after "self.execute_macro(DROP_SCHEMA_MACRO_NAME, kwargs=kwargs)" and it worked.

I just tried the addition and ran against redshift I still had tests remain, will play around with it some more tonight. thanks for having eyes on this everyone!

If adding commit_if_has_connection() fixes this, I'm happy with doing that.
@gshank Thanks for finding and linking the context from https://github.com/dbt-labs/dbt-core/pull/1983. I have to disagree with Drew from 2019 on these points, though:

these sprinkled-in transactional statements make it super hard to reason about what dbt is doing in different parts of the codebase.
it's the destructive nature of this method that gave me pause

If the commit is necessary, we should have it. It should be sprinkled through the logs wherever it's needed. As far as the "destructive" nature of drop schema: dbt itself doesn't actually call drop_schema anywhere, in the course of its standard operations. It gets called in two highly specific places:

While running functional tests on dbt-core (this issue)
By dbt Cloud, after a PR is merged, to drop the "PR schema" used by the CI check built from that PR. I just checked into this part of the dbt Cloud codebase, and guess what's there?

            adapter.drop_schema(database, schema)
            adapter.commit_if_has_connection()

Of course, users may also call it for their own purposes. If they do, I think they'd expect it to work :)

@gshank do we still want to add a test before merging?


Array Functions: Find Max-Min of an Array

To find the maximum and minimum element present in an array in

Time Complexity - O(N)
Space Complexity - O(1)
by implementing respective functions in  Java, C++ and Python.

I would like to contribute to this issue

@Aditi-Anil-P Go ahead. Don't use built-in functions. And make sure that your functions are generic, and instead of the element, return its index in the array. Make two functions, one for minimum and other for maximum

Also me I would like to contribute to this issue

Also me I would like to contribute to this issue

Only one person can be assigned to one issue


common: added API to get the transformation matrix of the object

I need this API in the saver module.

@mgrudzinska https://github.com/Samsung/thorvg/commit/2c37191584b18a532cd01e7986fc5f53ebeea80d

I removed Capi into separate pr


Add thread count metric

Closes elastic/apm-agent-java#574
Basic thread count support- sending global JVM thread count as jvm.thread.count in metrics.

@roncohen @jasonrhodes I've added a thread count metric reported and stored under jvm.thread.count. I want to include it in the Java agent 1.6.0 release, so you can start working on the visualizations. Just let me know if there are any objections to the field I used for it, before we merge and release.

Also update docs/metrics.asciidoc

Codecov Report

Merging #578 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #578      +/-   ##
============================================
+ Coverage      62.3%   62.34%   +0.04%
  Complexity       68       68
============================================
  Files           187      188       +1
  Lines          7064     7072       +8
  Branches        814      814
============================================
+ Hits           4401     4409       +8
  Misses         2394     2394
  Partials        269      269

Impacted Files
Coverage Δ
Complexity Δ

...astic/apm/agent/metrics/builtin/ThreadMetrics.java
100% <100%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dce160...c253abf. Read the comment docs.

LGTM. jvm.thread.count is in line with jolokia.jvm.thread.count that is suggested here. And I think it's fine to start without daemon.


dap-repl buffer does not automatically close

Hello!
I am using nvim-dap with your nvim-dap-ui and lately also tried cmp-dap. I really like it, thank you!
Without cmp-dap, the repl buffer automatically closes when toggling/closing the dap-ui. The corresponding issue was raised here. Your workaround in this comment and your PR in nvim-dap both worked.
Now, after I included cmp-dap, the issue reappears. Could you imagine whether this is due to cmp-dap?

By not closed do you mean it is still listed (i.e. appears in :ls)?
There's nothing in cmp-dap that would be do that, but perhaps nvim-cmp is doing something? I do experience any issue with it however

Yes. It doesn't exist until I select something from autocompletion in repl, then:

Finished the session and it's still there.

I encountered the same behavior and could not find a quick fix. The temporary workaround I am using at the moment is to disable cmp-dap for [dap-repl] buffers (comment out "dap-repl" when setting up require("cmp").setup.filetype(...)) and rely on nvim-dap's completion suggestion via <C-x><C-o> (built-in omnifunc implementation).

@dohmjan @oshevtsov @jaghaimo Hi, I have got a solution to hide dap-repl buffer, not close. Because this buffer shoud be reuse by the next dap session. It can be checked at my config files MozyVim.
local dap = require("dap")
local dapui = require("dapui")
local function clear_dap_ui()
  local bufs = utils.find_buffers_by_filetype("dap-repl")
  for _, buf in ipairs(bufs) do
    vim.bo[buf].buflisted = false
  end
end
dap.listeners.before.event_terminated["dapui_config"] = function()
  clear_dap_ui()
end
dap.listeners.after.disconnect["dapui_config"] = function()
  clear_dap_ui()
end


add whisper channel to send chat hotkey

I specifically want to be able to PM myself reminders at regular intervals e.g. "put your legionnaire back in the chest", so I'd be perfectly happy if this only worked for self PMs, rather than giving the opportunity to easily spam someone else. Of course, a hotkey to put the legio straight in the chest would be even better...

Added in fcfd8ea
In "Message" input box, the format is <name>,<message>


Deprecations in pandas 0.19 means moving to the public API

pandas.core.common.is_categorical_dtype -> pandas.api.types.is_categorical_dtype
pandas.core.common.is_datetime64_any_dtype -> pandas.api.types.is_datetime64_any_dtype

@wesm it looks like this issue can be closed as the fix was contained and merged from #242.


Verify That We Order Transactions By Gas Price and then By Time Added To Pool

To prevent transaction spamming, most clients are implementing a FIFO ordering among transactions with the same gas price. From the code below, it looks like we already do that. However, it seems like we don't order by gas price, which is a problem for maximizing mining profits.
https://github.com/hyperledger/besu/blob/7b9ade23cde145e67f90112d3411e80f860129f6/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/PendingTransactions.java#L72-L76
Acceptance Criteria
Ensure that we order by gas price and then by time. If we don't do either, implement and test.

@RatanRSur - the current doc on the transaction pool talks about the order in which transactions are dropped - https://besu.hyperledger.org/en/stable/Concepts/Transactions/Transaction-Pool/#dropping-transactions-when-the-transaction-pool-is-full
If there's updates needed to the doc when this issue is addressed, could you please ping Pliny.

https://github.com/hyperledger/besu/pull/1314/files
I saw the issue when browsing, and decided to attempt to fix it, I think I am close, but I never actually was able to get anything running locally.
I hope this helps some!


Added routine to get total message count from MidiFiles.

I thought it would be nice to be able to get the total message count of a midi file from MidiFile, without having to load the data back into a Parser and parse it all over again.
Useful for creating arrays of static size to manipulate midi data (e.g., with numpy).
Apologies for the gratuitous commits... never use notepad's tabs.

Alright just used the __len__ suggestion. Feel free to roll it in if you like. I find it useful, but I can just implement it on my end too.
Thanks for the help!

This seems like something nice to have around. I guess my only concern would be
"what do people think is the length of a midi file?"
This could mean a number of things:
number of notes in the file (as implemented)
length in time of the file
length in bytes of the file
Just playing devils advocate here, not sure what the right move is.

Yeah I suppose it's a toss up between being more pythonic at the cost of ambiguity, or less ambiguous at the cost of potentially more code. I'd be fine with an explicit method for number of messages too.
What's the consensus?

@cjappl  Yes, that ambiguity is what has kept me from adding __len__() in the past.
I tried a quick implementation and ran into another source of confusion:
>>> import mido
>>> mid = mido.MidiFile('Weightless.mid')
>>> len(mid)
16709
>>> len(list(mid))
16690

So... len() returns more messages than you will get when you iterate over the file. This seems strange, but the reason is that __iter__() doesn't just iterate over the messages, it merges them into one track (removing all the end_of_track messages) and converts time stamps to seconds.
I would like to deprecate __iter__() into mid.play(sleep=False). I'm not sure how much code that would break.

Hmm, yeah at the very least len(list(blah)) and len(blah) should return the same thing

Definitiely, but if len(mid) returns the same as len(list(mid) it will still be confusing why this is different from the actual number of messages in the file.
I don't see how this can be solved without either removing or redefining `iter().

Due to that, it may be better to go back to the original name "msg_count" for this one, and punt on the iter/len thing?

Sounds good, I'll revert back to the old nomenclature to avoid ambiguity. It'll be a couple hours until I get back to my machine.

To be clear, I defer to @olemb for the final decision, I'd wait to hear what he says. I'm just a hanger-on contributor :)

Doing some other work on the repo for the time being. Will loop back.


Where to get good socks 5 proxies?

Please i need proxies i get like 200 all proxies daily from website and like 3~5 bots spawns i need good proxy scraper atleast.

http://vipsocks24.net


Reactive Collision Avoidance, based on ESDF

Hi,
I am using the voxblox node for planning and it works very well. But if I move objects within the planning area, the TSDF map reacts very slowly to that change. The ESDF is little faster but not much. I speeded up the ESDF generation by lowering the esdf_max_distance_m parameter. But if I visualize the esdf slice and set voxel_carving_enable to true, I always get a full esdf-layer - no matter how esdf_max_distance_m is set. How do that parameter relates to the esdf map, what distance does it influence?
Are there any other parameters for TSDF or ESDF generation that can be changed to improve reactive collision avoidance?
Kind regards,
Christian

@clmpng The mav_voxblox_planning might be helpful for you

@Jaeyoung-Lim Thank you, but I'm using that package already - it works good, only the collision avoidance reacts very slowly.

@clmpng By reading again, by moving the object in the scene, are you trying to use Voxblox for dynamic scenes? Voxblox assumes you have a static environment

@Jaeyoung-Lim Yes, I try to used it for dynamic environments. It works well with a low voxel resolution, since the esdf map is generated very quickly in that case. Now, I'm trying to change some other parameters to make it work with a higher resolution. For that reason, I was wondering about the impact of the esdf_max_distance_m parameter.

Hi @clmpng,
Say your esdf_max_distance_m  is 5m. Then all voxels 5m away from an obstacle would have their distances as 5m. Try reducing the max_ray_length_m. Hope that's the parameter to meet your above expectations. This parameter limits the ray cast to the specified distance.

hello guys, I'm new here. I have been following the tutorial step by step in https://github.com/ethz-asl/mav_voxblox_planning , but unfortunately I can't find out how to solve a problem that I encountered.
I cant do the following (and start up rviz (rviz). In rviz, select Panels -> Add New Panel and select Planning Panel)

Do you have source ~/catkin_ws/devel/setup.bash as part of your bash.rc? If you don't you need to run this command in the terminal you use to open rviz, otherwise it won't know which directories to search for the plugin.

@ZacharyTaylor Thanks for your answer. I followed exactly that by typing:
cd ~/catkin_ws_path/src/
source ~/catkin_ws_path/devel/setup.bash
And I opened other terminal on which I typed
roscore
then on the first one I typed
rviz

Could you give me any advice about  using Voxblox to generate a 2.5D map ?


Script error Some requests did not succeed for disk.list disk.snapshot and snapshot.list

Hi,
When I try to run the script it gives me an error. I presume this is permission issues but can't figure out which ones.
I've activated a service account with Compute Engine Admin and Compute Storage Admin rights.
Here is what I get.
$ gcloud compute snapshots list
NAME        DISK_SIZE_GB  SRC_DISK                         STATUS
snapshot-1  10            europe-west1-b/disks/axxoncrm-1  READY
$ gcloud compute disks list
NAME        ZONE            SIZE_GB  TYPE         STATUS
axxoncrm-1  europe-west1-b  10       pd-standard  READY
$ sudo /opt/google-compute-snapshot/gcloud-snapshot.sh
2018-07-26 10:13:13: Start of Script
2018-07-26 10:13:13: Start of createSnapshotWrapper
ERROR: (gcloud.compute.disks.list) Some requests did not succeed:
 - Insufficient Permission
ERROR: (gcloud.compute.disks.snapshot) argument --zone: expected one argument
Usage: gcloud compute disks snapshot DISK_NAME [DISK_NAME ...] [optional flags]
  optional flags may be  --async | --csek-key-file | --description |
                         --guest-flush | --help | --snapshot-names | --zone
For detailed information on this command and its flags, run:
  gcloud compute disks snapshot --help
2018-07-26 10:13:35: Start of deleteSnapshotsWrapper
ERROR: (gcloud.compute.snapshots.list) Some requests did not succeed:
 - Insufficient Permission
2018-07-26 10:13:55: End of Script

Hi @jacksegal,
Yes I've read that post. The problem is that my instance is already created and I can't see how I can change Compute to Enable. It does mention it in the post that you can use Service Account, which I have, but didn't go into detail what roles to assign.

Right, with you - can you try running the following gcloud commands using sudo?
sudo gcloud compute snapshots list
sudo gcloud compute disks list

I can see from your first output that when you run the commands outside of the script it does look like it's working, so maybe that's worth checking.
If it works using sudo (which I expect it will), it might be worth trying the following commands too, to see if it's actually another command failing:
DATE_TIME
date "+%s"
INSTANCE_NAME
curl -s "http://metadata.google.internal/computeMetadata/v1/instance/hostname" -H "Metadata-Flavor: Google"
INSTANCE_ID
curl -s "http://metadata.google.internal/computeMetadata/v1/instance/id" -H "Metadata-Flavor: Google"
INSTANCE_ZONE
curl -s "http://metadata.google.internal/computeMetadata/v1/instance/zone" -H "Metadata-Flavor: Google"
DEVICE_LIST (replacing "instance_name" whatever value you got from the INSTANCE_NAME command)
gcloud compute disks list --filter users~instance_name\$ --format='value(name)'

@jacksegal you were right, when I ran sudo gcloud compute snapshots lists it gave me the permisions error. I've then check sudo permissions using sudo gcloud auth list and the service account was missing. So I've added the same service account with sudo and it worked. Didn't realise the service account didn't apply globally.
Thank you for your help.

No problem, glad you've got it working!


On prem?

We have a mixture of on-prem accounts and cloud. If I enable this for all users but do not pay for Azure AD Premium .. what happens to the on-prem users?
Are they able to reset their passwords? Which would make no sense as no write back to AD would occur.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ad408574-36cc-9b96-f092-58a68708d3a0
Version Independent ID: 97adbc3d-8f71-a6de-25c3-f9400125f885
Content: Let users reset their own passwords in Office 365 - Microsoft 365 admin
Content Source: microsoft-365/admin/add-users/let-users-reset-passwords.md
Service: o365-administration
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@Sirkkuw can you help answer this?

Nothing happens to the on-prem users if you keep the domain controller separate from the cloud identity. IF you set up hybrid, then the identity is controlled locally (your on prem domain) and you would have to use Azure Ad premium only if you wanted password write-back from Azure Ad if you changed things there. FOr more info, see https://docs.microsoft.com/en-us/Office365/Enterprise/set-up-directory-synchronization

@jmbainbridge did that answer your question?

@jmbainbridge - Thank you for submitting feedback.
From our understanding, the issue you raised has been answered by Sirkkuw so we will close this issue.
Thank you for your contribution to make the docs better! Much appreciated!


libnccl-dev is not installed in Dockerfile.gpu

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): master branch
Python version: not related
Bazel version (if compiling from source): 0.14.1
GCC/Compiler version (if compiling from source): not related
CUDA/cuDNN version: CUDA9, cuDNN7
GPU model and memory: not related
Exact command to reproduce:
tensorflow/tools/ci_build/ci_build.sh GPU bazel test //tensorflow/...

Describe the problem
when build from source inside docker container, configure.py will fail with error message below due to nccl.h is missing.
Please specify the location where NCCL 2 library is installed. Refer to README.md for more details. [Default is /usr/local/cuda]:

Invalid path to NCCL 2 toolkit, /usr/local/cuda-9.0/lib/libnccl.so.2 or /usr/local/cuda-9.0/include/nccl.h not found. Please use the O/S agnostic package of NCCL 2
Traceback (most recent call last):
  File "configure.py", line 1586, in <module>
    main()
  File "configure.py", line 1525, in main
    set_tf_nccl_install_path(environ_cp)
  File "configure.py", line 1156, in set_tf_nccl_install_path
    _DEFAULT_PROMPT_ASK_ATTEMPTS)
__main__.UserInputError: Invalid TF_NCCL setting was provided 10 times in a row. Assuming to be a scripting mistake.

Source code / logs
https://github.com/tensorflow/tensorflow/blob/226831aab92a395a26824a08caa9d43f0c3d604e/tensorflow/tools/ci_build/Dockerfile.gpu#L18-L20
libnccl-dev is not installed, so nccl.h is missing.

it is strange that recent GPU related CI checks on master branch can still pass without libnccl-dev installed.
e.g. https://source.cloud.google.com/results/invocations/ae1f1de9-f91b-4138-b89d-d56b3dfebb80
@gunan, does current CI check still use ci_build.sh to build inside a docker container?

No, current CI runs outside docker, because we still try to support ubuntu 14, and there is no nvidia docker containers for ubuntu 14.
We will also soon remove all docker containers under tools/ci_build
Could you try using the devel-gpu container here?
https://github.com/tensorflow/tensorflow/tree/master/tensorflow/tools/docker

@gunan, thanks for the response.
To confirm, We will also soon remove all docker containers under tools/ci_build, do you mean stop official support for build inside docker container?
when will this happen?
I believe this is a useful feature to build inside docker.
For example, our CI build machines are shared with other team, so we prefer to build inside docker for isolation.
Maybe we should still keep it, and leave the maintenance work to the community?
tools/docker is not quite friendly for ci build and release scenario.
Also, it lacks of support for multiple python versions, e.g. build whl for python 3.5, python 3.6.

Multiple python versions was something we have not considered, I will take that into account when moving forward. In our dockerfiles, we certainly want to default to latest python versions moving forward.
However, I think we can parameterize python versions on the dockerfiles so it is possible to run our CI in them.
Having the community maintain these dockerfiles is also another viable option.

Just submitted a PR https://github.com/tensorflow/tensorflow/pull/21127
@gunan could you or someone help to take a look please?
Thanks

I saw @tfboyd already submitted a fix https://github.com/tensorflow/tensorflow/commit/402bb7353289013520fa99a38559319bc7b3d845, so I closed my previous PR.
Then when I pull latest cuda image, I realized ci_build.sh needs an option to allow something like docker build --pull, so I opened another PR https://github.com/tensorflow/tensorflow/pull/21147
Thanks.


Mention the duration parameter unit in UPNP.add_port_mapping()

Finding documentation about this is surprisingly difficult (miniupnpc doesn't have any comments about it). I inferred the duration unit as many routers use a lease of 86400 if not otherwise specified (which is obviously 24 hours).
This closes https://github.com/godotengine/godot-docs/issues/2533.

Thanks!

Cherry-picked for 3.2.1.


how to use this package when using cluster？

Not enough info here for us to provide a helpful answer :(


fix cleanup for when model has multiple proffer columns #163

https://github.com/davidyell/CakePHP3-Proffer/issues/163
I tested code in my own project.
But if I need more test, please instruct me.
thank you.

Thanks for the contribution.


"Open API Spec" doesn't appear to work

Issue
I am trying to import a sample API spec doc (OAS 3.0.1) using the "Open API Spec" link in the UI.

The spec doc I am using can be found here.
While I can select it through the file explorer, it doesn't do anything. It doesn't load up, and I see no errors.
This is for Golden Edition v1.12.3.

Hi @DanaEpp, I'm sorry to say that at the moment Bruno only allows for importing YAML specifications of OpenAPI. However, we are working on fixing this. For now, you can create an empty API specification file and then simply copy and paste the JSON values into it. I've attached a demo video for reference. If you have any further questions or if there's anything else I can help you with, please let me know!
https://github.com/usebruno/bruno/assets/84461672/2cb27e11-67b2-49b3-88c3-baa050ccc87f

I've heard on Discord that the issue here is that the API spec import only supports YAML format currently, and not JSON.
So, this should be marked as a Feature Enhancement—a pretty major one, if you ask me—but still just an enhancement.

I managed to import json openapi specs once on v1.12.2, but except that one occasion, every time I select the openapi.json file, a location and then nothing happens when I click import.

yup. I noticed that JSON isn't working, but YAML is. So this is a missing feature IMO.

JSON isn't working, but YAML is

A hacky suggestion: According to spec a valid JSON file should also be valid YAML, so try to change the file extension to .yaml and open again.

Ahha no. Json isn't yaml. It's a totally different format.

JSON is valid YAML

JSON is valid YAML

Ow... OK. Today I learned that json is mostly valid yaml.


[Bug] Reconciler error Backup

Describe the bug
Anomalies in the logs in multiple instances:
{"level":"error","ts":1693470259.4182994,"msg":"Reconciler error","controller":"backup","controllerGroup":"mariadb.mmontes.io","controllerKind":"Backup","backup":{"name":"maria-db-env-example-scheduled","namespace":"mariadb"},"namespace":"mariadb","name":"maria-db-env-example-scheduled","reconcileID":"27982df8-c33d-44db-af8f-cb9f6dd8ed24","error":"MariaDB not ready","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/internal/controller/controller.go:234"}

Is the bug related to Galera?
no
Additional context

These logs appear almost every minute
Backup Settings are "0 0 * * *" / mariadb-scheduled-backup CronJob is working correctly
To me, these logs look more like false alarms. Are there any other experiences with this?

Environment details:

Kubernetes version: OpenShift Container Platform 4.12 / Kubernetes 1.25
mariadb-operator version: version: mariadb-operator.v0.19.0
Install method: helm
Install flavour: recommended

Hey there @MaAd12345 !  thanks for opening this issue.

"error":"MariaDB not ready"

This means that the MariaDB that the Backup resource refers to has enter in a non ready state, therefore the Backup won't be able to be completed, I do see the value of logging this error.
Check the status conditions of the MariaDB to figure out what's wrong with it. Once its back to ready state, the Backup will be able to complete and the logs reported in this issue will disappear.


Move mailing list signup to the top of the page

In the Hack Camp website, I believe about 0% of the signups came from people clicking the "Apply Now" button on the bottom of the page (@MaxWofford can confirm/deny this). See below for reference:

What if we moved the mailing list signup box to the top of the page, next to or below the top heading?

Closing this because Hack Camp is over.

Oops, I realized I accidently closed the issue without properly understanding it: this is a change to the Hack Club website, not hack camp. Re-opening the issue. I think this is a good idea!


linuxKernel.kernels.linux_zen: 6.5.2-zen1 -> 6.5.3-zen1 ; linuxKernel.kernels.linux_lqx: 6.4.14-lqx1 -> 6.4.15-lqx1

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

CC @thiagokokada @999eagle if you want to review it.


[Steppers] Add example for breadcrumbs using Steppers

As per https://github.com/mui-org/material-ui/issues/13176, included an example in docs for using <Steppers /> to implement breadcrumbs.

@oliviertassinari I saw your screenshot, are there still issues indexing Breadcrumbs for Algolia?

I'm wondering about mixing the Stepper use case with the Breadcrumb 🤔. Let me benchmark the alternatives, just to be sure.

@oliviertassinari I had the same concerns. As per https://github.com/mui-org/material-ui/issues/8818#issuecomment-428868056 I would rather create the described utility component and document breadcrumbs as a possible use case.
You could argue that breadcrumbs are somewhat steps down a hierarchy but a Stepper is IMO for things that are on the same level whereas breadcrumbs are on different levels. It's really only about semantics but Stepper adds a lot of overhead for a simple breadcrumbs use-case.

@bdeloeste Thanks for taking the time to create this PR 🙏, but following the subsequent discussion, it seems this isn't the right way forward. Let's close for now.


Refactoring, cleanup and generalization

Fixes #
This is a neutral PR that does not introduce any new functionality. It does some refactoring and cleanup and exposes hook methods that are necessary for the java driver adaptor to work properly.
This pull introduces/changes:

adds close methods on driver and session
packs shared spec example and a spec helper into the gem for reuse by adaptors in separate gems

Pings:
@cheerfulstoic
@subvertallchris

Coverage decreased (-0.06%) to 84.528% when pulling ae1ec57716bd6fb897305303a6b61dd879fcba10 on klobuczek:java_driver into 5eaa804475508fb56414489c3e3bb5eb1366754a on neo4jrb:master.

Coverage decreased (-0.06%) to 84.528% when pulling ae1ec57716bd6fb897305303a6b61dd879fcba10 on klobuczek:java_driver into 5eaa804475508fb56414489c3e3bb5eb1366754a on neo4jrb:master.

Coverage decreased (-0.06%) to 84.528% when pulling ae1ec57716bd6fb897305303a6b61dd879fcba10 on klobuczek:java_driver into 5eaa804475508fb56414489c3e3bb5eb1366754a on neo4jrb:master.

Coverage decreased (-0.06%) to 84.528% when pulling ae1ec57716bd6fb897305303a6b61dd879fcba10 on klobuczek:java_driver into 5eaa804475508fb56414489c3e3bb5eb1366754a on neo4jrb:master.

Coverage decreased (-0.06%) to 84.528% when pulling ae1ec57716bd6fb897305303a6b61dd879fcba10 on klobuczek:java_driver into 5eaa804475508fb56414489c3e3bb5eb1366754a on neo4jrb:master.

@cheerfulstoic could we move ahead on that? It is not ideal to point our production to forks and keep synching the fork with upstream.


Avoid downloading other file types

Checklist

[x] I'm asking a question
[ ] I've looked through the README and FAQ for similar questions
[ ] I've searched the bugtracker for similar questions including closed ones

Question

Giving youtube-dl this URL http://releases.ubuntu.com/18.04.3/ubuntu-18.04.3-desktop-amd64.iso it was able to download it. It's not a video it an iso file of Ubuntu.
My question is how to tell youtube-dl to download only videos and reject any other file types?

https://github.com/ytdl-org/youtube-dl#format-selection filter by ext.


Adds getSpecificUser and tests to cover getSpecificUser and getCurrentUser

Doing some work with users, didn't have a call for a specific user, so have added that.
Also noticed there wasn't a test covering getCurrentUser, so added that at the same time.

Thanks for the PR.
Could you check what happend with the indentation in the readme? Seems like al indentation is changed. Difficult to review the changes like this.

All I did was run generate-api-docs.php, but it looks like it generates it using tabs instead of spaces.
I've changed it to use spaces now.

Looks good to me, thanks!


should update file status when it is finished immediately in knowledgebase

closed as @0xff-dev already implemented this


Convert timestamps to support Firefox

Remove contracted year per UX review
Add left blue line for expanded rows
Convert timestamps from 'T23:59:59z' to 'T00:00:00' in order to work with Firefox

Codecov Report

Merging #202 (d4f14c8) into main (3e1e1fd) will increase coverage by 0.01%.
The diff coverage is 0.00%.

:exclamation: Current head d4f14c8 differs from pull request most recent head 1a92a71. Consider uploading reports for the commit 1a92a71 to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##            main    #202      +/-   ##
========================================
+ Coverage   5.70%   5.72%   +0.01%
========================================
  Files         43      43
  Lines       1734    1728       -6
  Branches     317     316       -1
========================================
  Hits          99      99
+ Misses      1635    1629       -6

Impacted Files
Coverage Δ

...tes/components/charts/breakdown/BreakdownChart.tsx
0.00% <0.00%> (ø)

src/routes/components/charts/trend/TrendChart.tsx
0.00% <0.00%> (ø)

src/routes/components/page-heading/PageHeading.tsx
0.00% <0.00%> (ø)

src/routes/details/Details.tsx
0.00% <0.00%> (ø)

src/routes/details/DetailsHeaderToolbar.tsx
0.00% <ø> (ø)

...tual-spend-breakdown/ActualSpendBreakdownChart.tsx
0.00% <0.00%> (ø)

...s/overview/components/actual-spend/ActualSpend.tsx
0.00% <0.00%> (ø)

...itted-spend-trend/CommittedSpendTrendTransform.tsx
0.00% <0.00%> (ø)

...view/components/committed-spend/CommittedSpend.tsx
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1e1fd...1a92a71. Read the comment docs.


Add file migration system requirements

Add system requirements to file migration so people know how to approach it depending on how many files they need to migrate.
See https://github.com/silverstripeltd/open-sourcerers/issues/45 for more information on how these estimates were obtained.

For those without access to the private issue linked:

Check web request operation (via dev/tasks/MigrateFileTask), capped at 256MB mem and 30s exec
SSP Virtual Stack: 150 File DataObjects upgraded, Execution time: 30 seconds, Peak memory usage: 6 MB
Check queuedjobs operation (by manually adding this task as a one off execution), capped at 256MB mem and 120s exec
SSP Virtual Stack: 500 File DataObjects upgraded, Execution time: 120 seconds, Peak memory usage: 8 MB
Check manual CLI run, capped at 2GB mem and no exec limit
Vagrant silverstripeltd/dev-ssp box: 10000 File DataObjects upgraded, Execution time: 10000 seconds, Peak memory usage: 916 MB


codecov on PR is broken

Surprisingly still work on push 🤷🏻

Seems like it's back as of lately 🤷🏻


earthscope: Add MsPass image to the hub

Adds MsPASS image to dropdown for the July short course

To be merged pending identity confirmation :)

Confirmed identity via email! I'll add your username to our internal airtable of authorized pull requestor openers as well @sarahwilson523 :)

Thanks, Yuvi!
On Mon, Jul 1, 2024 at 2:16 PM Yuvi Panda @.***> wrote:

Confirmed identity via email! I'll add your username to our internal
airtable of authorized pull requestor openers as well @sarahwilson523
https://github.com/sarahwilson523 :)
—
Reply to this email directly, view it on GitHub
https://github.com/2i2c-org/infrastructure/pull/4321#issuecomment-2200948679,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BINBKV6VB6EJ7QCNCAD2JK3ZKG2KHAVCNFSM6AAAAABKGEO6WOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQHE2DQNRXHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


use CG-DRAFT template

Previews:

https://elf-pavlik.github.io/notifications/streaming-http-channel-2023
https://elf-pavlik.github.io/notifications/webhook-channel-2023
https://elf-pavlik.github.io/notifications/webpush-subscription-2022

BTW: Later this week, I plan to PR WebPushChannel2023 since I have been implementing it lately.

Per the CG discussion (which I colossally disagree with), we need to remove the W3C logo as well. :(

This is a misunderstanding; I'm using a standard CG-DRAFT template. I will ask about it in the issue with participation from W3C.

This will be resolved soon, tracking it in https://github.com/solid/specification/issues/587#issuecomment-2174595176

okie dokie, this one is ready!


Use conda compilers

This PR enables the usage of conda compilers to build conda packages. This is required to use mambabuild

@gpucibot merge


Inline distutils.util.strtobool in tests (closes #813)

distutils is deprecated in Python 3.10 and slated for removal in Python 3.12. Fortunately, attrs only uses distutils once and it's trivial to remove.
As suggested by @sscherfke, add the to_bool converter to converters.py.
Closes #813
Pull Request Check List
This is just a friendly reminder about the most common mistakes.  Please make sure that you tick all boxes.  But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.  If your pull request is a documentation fix or a trivial typo, feel free to delete the whole thing.

[x] Added tests for changed code.
[x] New features have been added to our Hypothesis testing strategy.
[x] Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).

[x] ...and used in the stub test file tests/typing_example.py.

[x] Updated documentation for changed code.

[x] New functions/classes have to be added to docs/api.rst by hand.
[x] Changes to the signature of @attr.s() have to be added by hand too.
[x] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.  Find the appropriate next version in our __init__.py file.

[x] Documentation in .rst files is written using semantic newlines.
[x] Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask!  This checklist is here to help you, not to deter you from contributing!

Hi Rebecca, thanks for your PR. I am already working on this issue in #824 though (the PR title may be a little bit mesleading).
I think we should combine our efforts there. :)

Alright -- do you need any support from me? Feel free to move my work to your branch.

Maybe (just maybe) we should keep it simple and prefer your PR over mine.
I think @Tinche would agree that conversion should be done with cattrs anyways, so why add a lot of converters to attrs? On the other hand, they don't hurt and may be very handy for some use cases. I’ll have to think about this and discuss it with him and Hynek. :)

Yeah we can do this separately!
However, we're gonna need to make this pass on 2.7 and 3.5 too. 😇

And now we need two tests to fix coverage. 😇

OK, got those tests in!


feat: Allow user customization of release notes template

Description
Allow end users to override the default Jinja2 template for rendering release notes.
If a file named .release_notes.md.j2 exists in the configured template_dir, it is used to render the release notes of a given VCS release.
Implements #660
Checklist

[x] test implementation: see acde492f6d89de9f36c6807f0336d0bc2b78ee43 and 8e18b98013f08ff082f882695abbf164852f3f8f for this feature's two acceptance tests
[x] feature implementation: see fc196d05b20c14a62ab75dd15a939f844d396c70 for the implementation of this feature
[x] documentation updates:

34fa6b5f56b614166ff34c2de2ba5b71d8951d17 updates the changelog_templates.html Sphinx page to describe how to use this feature
41a2c08d97ac003c7820e034227aafb75eb7593a updates how the --noop argument is handled in the version and changelog commands to display the rendered release notes

Misc. Notes

0176982284dcda793d57f82a61411ef1eaa29c92 was needed to fix a couple of preexisting pre-commit failures
I wasn't thrilled with the cyclomatic complexity added by the support for --noop mode; so I left 41a2c08d97ac003c7820e034227aafb75eb7593a as the last commit for easier exclusion
in addition to the acceptance tests, I also validated this change by running the following in one of my projects:# install python-semantic-release from my local clone of the project
pip uninstall -y python-semantic-release    # remove the distribution from PyPI
pip install -e ../python-semantic-release

# create a release notes template
cat <<EOF >templates/.release_notes.md.j2
## What's Changed
{% for type_, commits in release["elements"] | dictsort %}
{%- if type_ != "unknown" %}
### {{ type_ | capitalize }}
{% for commit in commits %}
* {{ commit.descriptions[0] }} by {{commit.commit.author.name}} in [`{{ commit.short_hash }}`]({{ commit.hexsha | commit_hash_url }})
{%- endfor %}
{% endif %}{% endfor %}
EOF

# simulate creating a new release
semantic-release --noop version

@danth @relekang @bernardcooke53 could I ask for some help with merging this PR?
Based on a parallel PR in my fork (https://github.com/bryant-finney/python-semantic-release/pull/1), I think it's ready to merge now
CC @jmgate

Excited to be able to use this feature when it makes it in 😀


play two subtitles at once

I want to be able to show two subtitles in different languages at once. From what I understand the source code is written in a way that only one subtitle is supported at all times.
It would be great if we could play two subtitles simultaneously without changing the source code.

Unfortunately, this will require significant internal changes that is out of scope for us right now. As a workaround, I recommend merging the the two subtitle files into one.

thanks
Could you guide me what steps I should take to make playing two separate subtitles playable at once?
I really want to explore this feature and just a high level guidance could help me


hcitool lescan (Bluetooth LE or any bluetooth scan) in docker under Non-Privileged & Non-host Network mode is possible ?

Hello @jessfraz  and docker users,
I am a newbie to docker. For a specific task, I am failing to scan BLE or BlueZ in docker under Non-Privileged & Non-Host network mode.
These are my results > (in Debian-Jessie-8.8.0 Host and debian:jessie docker image)
root1@73ab53a9268e:/#  hciconfig -a Can't open HCI socket.: Operation not permitted
and -
root1@73ab53a9268e:/#  bt-device -l Couldn't connect to DBus system bus: Could not connect: Connection refused
another image -
root2@0d208802d44a:/# hciconfig -a Can't open HCI socket.: Address family not supported by protocol
I even gave ALL-CAP permissions for docker on Host but still could not make it.
docker run --name container-ID --cap-add=ALL -d -v /var/run/docker.sock:/host/var/run/docker.sock -v /dev:/host/dev -v /proc:/host/proc:ro -v /lib/modules:/host/lib/modules:ro -v /usr:/host/usr:ro Image-ID
So, is it possible by any chance ?

Half  Success :+1:

Almost Done...!  Bluetooth Scan Works by adding the below Flags.
--cap-add=SYS_ADMIN   and
-v /opt/bluetooth:/var/lib/bluetooth -v /sys/fs/cgroup:/sys/fs/cgroup:ro -v /tmp/$(mktemp -d):/run
CMD_USED :  edwin@debian:~$ docker run --cap-add=SYS_ADMIN *-v /opt/bluetooth:/var/lib/bluetooth -v /sys/fs/cgroup:/sys/fs/cgroup:ro -v /tmp/$(mktemp -d):/run* --net=host -it debian:jessie
Next I am looking to run docker with :  "not to share the Host Networking Namespace"

Almost Done...!
With help from Docker Community, First I have Successfully Started DBus Service inside docker container by logging in docker as follows :
docker run -v /opt/bluetooth:/var/lib/bluetooth -v /sys/fs/cgroup:/sys/fs/cgroup:ro -v /tmp/$(mktemp -d):/run -it debian:jessie
Then by adding --cap-add=SYS_ADMIN and --net=host this permission, Possible to start bluetooth service.
docker run --cap-add=SYS_ADMIN -v /opt/bluetooth:/var/lib/bluetooth -v /sys/fs/cgroup:/sys/fs/cgroup:ro -v /tmp/$(mktemp -d):/run --net=host -it debian:jessie
Now just looking to start bluetooth service by "Not sharing the Host Networking Namespace"  (customising --net=host to private network)
If somebody got any Clue, that would be helpful.

any news on this ?

closing as this is not a bug with the repo but feel free to discuss more

dckImg="kali-linux20180920_211247"
dckc="0df459aa83e0"

docker run -it --cap-add=SYS_ADMIN --cap-add=NET_ADMIN  --net=host --expose 80-65530 -e DISPLAY=$DISPLAY -v /tmp/.X11-unix:/tmp/.X11-unix --device /dev/cu.Bluetooth-Incoming-Port --device /dev/tty.Bluetooth-Incoming-Port --privileged  --name='kali-linux2018091d' $dckImg /bin/bash


Add support for sending null values

Allow sending willingly null values on either attributes or relationships

Closing. Support for null attributes and removing empty relationships has been implemented in v2.2.0.


[HOW-TO] Avoid CMA heap fragmentation when using switch_mode_* frequently

Using the Pi Camera v3 on a CM4, I need to record video with >20fps and occasionally capture images with full sensor resolution. This requires different sensor modes, so I have to switch in between. A short interruption in the video while taking the full res image is acceptable, but I try to keep it as short as possible. I need this to work indefinitely with thousands of mode switches without restarting the application.
Essentially, this works fine using switch_mode_and_capture_request(), interrupting the video for <0.5s. Unfortunately the application crashes after a few hundred switches with a memory allocation error. This is no surprise, as
https://github.com/raspberrypi/picamera2/blob/6f9202b8eb1ea14c9db572377d778d40d422a846/picamera2/picamera2.py#L1403-L1408
warns of heap fragmentation.
After reading this, I changed my code to switch_mode_capture_request_and_stop(), which, runs a little longer but crashes also with a memory allocation error.
Turning picamera2 debug logging on, I can see that after each mode switch new buffers are allocated. This means my application allocates and releases a lot of buffers, which seems to lead to heap fragmentation after some time.

Is there a way to avoid heap fragmentation with lots of mode switches?
@davidplowman If I would modify picamera2 to use a set of manually allocated buffers on start instead of allocating them internally, I could allocate the buffers for both modes once and never reallocate them. Could this be a solution for a lot of mode switching?
Should I expect any other problems with lots of mode switching besides cma heap fragmentation?

This is my minimal example which reproduces the issue:
from picamera2 import Picamera2
import subprocess

picam2 = Picamera2()

video_config = picam2.create_video_configuration(
    main={"size": (1920, 1080), "format": "RGB888"},
    lores={"size": (1920, 1080), "format": "YUV420"},
    raw={"size": (2304, 1296)},
    display=None
)
capture_config = picam2.create_still_configuration(
    main={"size": (4608, 2592), "format": "RGB888"},
    display=None
)

picam2.controls.FrameRate = 24.0
picam2.configure(video_config)
picam2.start()

switch_count = 0
while True:
    request = picam2.switch_mode_capture_request_and_stop(capture_config)
    buffer = request.make_buffer('main')
    metadata = request.get_metadata()
    request.release()
    picam2.configure(video_config)
    picam2.start()

    img = picam2.helpers.make_image(buffer, capture_config["main"])
    picam2.helpers.save(img, metadata, "file.jpg")

    switch_count += 1
    cma = subprocess.check_output("cat /proc/meminfo | grep CmaFree", shell=True)
    print(switch_count, cma)

The output is
[...]
85 b'CmaFree:          312796 kB\n'
[...]
374 b'CmaFree:          237928 kB\n'
[...]
564 b'CmaFree:          181640 kB\n'
[...]
1103 b'CmaFree:          100128 kB\n'
1104 b'CmaFree:          100128 kB\n'
1105 b'CmaFree:           87364 kB\n'
Traceback (most recent call last):
  File "test_switch.py", line 28, in <module>
    request = picam2.switch_mode_capture_request_and_stop(capture_config)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 1437, in switch_mode_capture_request_and_stop
    return self.dispatch_functions(functions, wait, signal_function, immediate=True)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 1304, in dispatch_functions
    return job.get_result() if wait else job
           ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/picamera2/job.py", line 79, in get_result
    return self._future.result()
           ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/concurrent/futures/_base.py", line 456, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/lib/python3/dist-packages/picamera2/job.py", line 48, in execute
    done, result = self._functions[0]()
                   ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 1354, in switch_mode_
    self.configure_(camera_config)
  File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 1085, in configure_
    self.allocator.allocate(libcamera_config)
  File "/usr/lib/python3/dist-packages/picamera2/allocators/dmaallocator.py", line 43, in allocate
    fd = self.dmaHeap.alloc(f"picamera2-{i}", stream_config.frame_size)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/picamera2/dma_heap.py", line 98, in alloc
    ret = fcntl.ioctl(self.__dmaHeapHandle.get(), DMA_HEAP_IOCTL_ALLOC, alloc)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 12] Cannot allocate memory

I think I found a solution. On every configure() call, the old buffers are removed and new buffers are allocated:
https://github.com/raspberrypi/picamera2/blob/6f9202b8eb1ea14c9db572377d778d40d422a846/picamera2/picamera2.py#L1087
To avoid this, I created a PersistentAllocator which allocates only once after the first call to allocate():
from picamera2.allocators import DmaAllocator

class PersistentAllocator(DmaAllocator):
    allocated = False
    def allocate(self, libcamera_config):
        if not self.allocated:
            super().allocate(libcamera_config)
            self.allocated = True

I manually created two instances of this allocator. Between stoping the Picamera2 instance and switching mode, I manually switch the allocator. This switch is dispatched to the event loop to ensure the correct order.
By using two allocators which allocate the buffers only once, I keep the same set of buffers for the two modes all the time and avoid CMA heap fragmentation by removing any reallocation.
Of course, this has to be done with special care as I have to ensure manually that the allocator matches the mode. Reallocation for example on resolution change has to be handled manually too.

Hi, thanks for the update. I have been looking at this. The idea of being able to hold on to the buffers and reuse them is clearly good, and is something I've been wanting to do. But I'm also a bit confused as to why we're fragmenting or leaking memory. If you use the libcamera allocator rather than the dma heap one, it seems to run indefinitely. So it seems to me like there's something misbehaving even as things stand, though I don't currently know what it is.

Thank you for the background info, I can give the LibcameraAllocator a try.
What is the reason for using DmaAllocator instead of LibcameraAllocator?
https://github.com/raspberrypi/picamera2/blob/6f9202b8eb1ea14c9db572377d778d40d422a846/picamera2/picamera2.py#L274

The DmaAllocator allows us to use cached memory buffers, which simply perform faster.
My suspicion is that the current implementation is actually leaking memory buffers from time to time, though I haven't got to the bottom of it yet.

I think I see the problem. Let me do some testing and then I can post a PR to run through the CI tests.

So I think this fixes the leak, which will hopefully make things work better.
But I still think it's a good idea to be able to allocate and hold onto buffers. Swapping the allocator object as you've done seems like a reasonable API to me, I guess some checking that the buffers are good for the configuration would be desirable. It would also be nice if that worked generically, whatever the underlying allocator. So perhaps some stuff to think about there.

Thank you for the quick fix! I will run a test over night to check if it works.
But I also think I should avoid frequent reallocation at all if not necessary. A check if the buffers still match would be a nice improvement, I will add this.
If one would implement this generically, what has to be checked? Buffer count, stream count and picture size per stream, anything else?

I suppose I was thinking that it should work for any "allocator" (currently there are only the "LibcameraAllocator" and the "DmaAllocator"). Though TBH, I'm not sure why one would ever really want anything other than the DmaAllocator, so maybe it's not so important.

So I think this fixes the leak, which will hopefully make things work better.

I can confirm this solves the issue I noticed which confirms it was a memory leak, not heap fragmentation as I supposed. Adding unseen_requests with a log output, but at first without the release() call shows, that every time the free memory decreases, len(unseen_requests) > 0. After implementing the whole fix, my minimal example runs forever.

Great, thanks for the confirmation. We're doing another code release imminently, so I'll try to squeeze this one in.

Swapping the allocator object as you've done seems like a reasonable API to me, I guess some checking that the buffers are good for the configuration would be desirable.

I implemented this idea and changed my PersistentAllocator to
class PersistentAllocator(DmaAllocator):
    def allocate(self, libcamera_config):
        buffer_layout_new = [[stream_config.buffer_count, stream_config.frame_size] for stream_config in list(libcamera_config)]
        buffer_layout_current = [[len(frame_buffers), frame_buffers[0].planes[0].length] for frame_buffers in self.frame_buffers.values()]
        if buffer_layout_new != buffer_layout_current:
            super().allocate(libcamera_config)

buffer_layout_new and buffer_layout_current are lists holding the buffer count and size for each stream, in my example they look like
[[6, 6220800], [6, 3110400], [6, 3732480]]
[[1, 35831808], [1, 14929920]]

Only when the buffer layout changes, the buffers are reallocated.

I find your discussion very interesting as I am having the same problem. But I have two questions:

How can I use the LibcameraAllocator? It is exposed in picamera2.allocators. However, it seems to me that the following doesn't work

cam = Picamera2()
cam.allocator = LibcameraAllocator(cam)

How can I use the next branch (preferably without building anything)
I am trying to take a still image at 9152x6944 (~64MP), but it seems like that is too much for picamera2 to handle. Am I assuming correctly?


FIX: Fix the CI again ..

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


test beeline

test beeline

+1 ran against our reference implementation and all tests pass
...
BUILD SUCCESSFUL
Total time: 9 mins 7.295 secs


Fix Vite build

See #3
It looks like the bug was being caused by a duplicate implementation of SVG optimization in the transform hook instead of the writeBundle hook. I did some basic testing to make sure SVGs were still being minified in the demo, but I wouldn't be surprised if I had missed something important.
Also, I took the liberty of doing some developer-friendly things like add a watch script and perform a little code-splitting.

Is there any movement here? Would love to use brotli with my Vue3 vite project

Is there any movement here? Would love to use brotli with my Vue3 vite project

You need to configure in your nginx/apache


Add 4 additional territory buttons

This looks good code-wise, but I just noticed on the QA branch, the shortcuts have what looks like a box around the initials:


nxp page

:warning: Validation status: warnings

File
Status
Preview URL
Details

windows-iotcore/learn-about-hardware/iotnxp.md
:warning:Warning

Details

windows-iotcore/learn-about-hardware/iotnxp.md

[Warning] Author GitHub username goes here cannot be recognized in GitHub.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Push 0.2.2 to METADATA?

Would be nice to clear up all the warnings that are currently caused by the released version on Julia 0.4.

ref https://github.com/JuliaLang/METADATA.jl/pull/5132


Update README with CI information

Updates readme with information on GitHub Action. Also, some general clean-up, consistency and typos were fixed.

Codecov Report

Merging #561 (2cbb928) into master (471a04d) will decrease coverage by 0.14%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   60.28%   60.14%   -0.15%
==========================================
  Files          18       18
  Lines         841      843       +2
  Branches      170      169       -1
==========================================
  Hits          507      507
- Misses        334      336       +2

Impacted Files
Coverage Δ

src/extension.ts
22.47% <0.00%> (+0.24%)
:arrow_up:

src/authextension.ts
42.50% <33.33%> (-2.24%)
:arrow_down:

src/redhatTelemetry.ts
60.86% <55.55%> (-2.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4a33f...2cbb928. Read the comment docs.


.net 4.7.1

I have an older .net 4.7.1 unity game (and that can't be changed) that i would like to use clipper2 or clipper-anything with but i tried building the code and id need to remove about 999 uses of nullable ref return values and readonly return values and etc.
Maybe i don't know how to properly find forks, it use to be easier on github, but anyway i haven't found any that would be compatible -- anyone aware of one? I found a slew of nuget packages a couple of which didn't list any dependencies on specific version of .net but turns out they fail at runtime so they are dependent on something, and its not what i have.
Any advice, any path forward?

@jamesford42 I`ve create a PR to use .net standard 2.0 instead of 2.1. If it should accept you should use the new version because .net standard 2.0 is supported by .net framework 4.7.1.
If it should declined, you can create a fork of Clipper 2 and change the target for the lib to .net Standard 2.0 and add the nuget package reference to Microsoft.Bcl.HashCode.
After this you should to be able to build a .net standard 2.0 version to use it in your project.

I've just merged Daniel's PR so Clipper2 should now compile to .net standard 2.0.


typo at node at list of items

Checklist

Issue number for this PR: #nnn (required)
Docs included?: (yes/no; required for all API/functional changes)
Test units included?: (yes/no; required)
e2e tests included?: (yes/no; required for multi-function/multi-class changes)
In a clean directory, npm install, npm run build, and npm test run successfully? (yes/no; required)

Description

Code sample

this.items = af.database.list('/items');
previously
this.items = af.database.list('items');

I signed it!


Problem with JSX highlighting

When I see Client Example, there is a problem with JSX highlighting:

With github theme in 9.17.1 version it should look like this:

I created a Codepen sandbox to see how it should work.
I checked out what version of Highlight.js is used in project and it's latest one:
➜ cat node_modules/highlight.js/package.json | grep version
  "version": "9.17.1",

Will Prism.js solve the problem?

looks like we're facing https://github.com/highlightjs/highlight.js/issues/931 and this issue is solved in Highlight.js.
Prism can also solve our problem.

Do you want to try to replace highlighter and get some experience with my fancy build system?
Here we call a highlighter https://github.com/logux/logux.io/blob/master/scripts/steps/read-docs.js#L212-L215
You can test highlighter by calling:
yarn build
npx ssdeploy run

(You can keep ssdeploy running in the background and rebuild HTML files by calling yarn build again, Docker will load changes into nginx)

Closing it for now, since I will not have time for it


[backend] Add integration test for deleteHardwareType mutation

Pull Request Test Coverage Report for Build 1828b8f651bb754d09d043e7815af66b8584b2b1-PR-189

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.824%

Totals

Change from base Build 04c6322721528b07a5b5f0ccc2565db9c5958e86:
0.0%

Covered Lines:
651

Relevant Lines:
786

💛  - Coveralls


Redesigned logging infrastructure for memflow plugins

This PR redesigns the logging infrastructure of memflow. Plugins now have a special logger instance which allows them to forward all logging calls over the FFI back to the main logger. This allows users to choose their own logging frontend and still allow plugins to use the user supplied logger.

Codecov Report

Merging #74 (319a437) into next (38c231a) will decrease coverage by 0.14%.
The diff coverage is 21.33%.

@@            Coverage Diff             @@
##             next      #74      +/-   ##
==========================================
- Coverage   32.83%   32.68%   -0.15%
==========================================
  Files         107      108       +1
  Lines        9277     9359      +82
  Branches     1616     1621       +5
==========================================
+ Hits         3046     3059      +13
- Misses       5594     5663      +69
  Partials      637      637

Impacted Files
Coverage Δ

memflow-ffi/src/log.rs
0.00% <0.00%> (ø)

memflow-win32/src/plugins.rs
0.00% <ø> (ø)

memflow-win32/src/win32/keyboard.rs
0.00% <ø> (ø)

memflow/examples/process_list.rs
0.00% <0.00%> (ø)

memflow/examples/read_bench.rs
0.00% <0.00%> (ø)

memflow/src/plugins/connector.rs
10.20% <0.00%> (+0.40%)
:arrow_up:

memflow/src/plugins/logger.rs
16.00% <16.00%> (ø)

memflow/src/plugins/mod.rs
26.96% <31.81%> (+0.13%)
:arrow_up:

memflow/src/plugins/util.rs
52.77% <37.50%> (+5.27%)
:arrow_up:

memflow-derive/src/lib.rs
51.04% <50.00%> (+0.02%)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c231a...319a437. Read the comment docs.


[53767] Android: Add DiagnosisKeysDataMapping

Implemented required DiagnosisKeysDataMapping to tell API how to translate data from TEK to ExposureWindows, added checks for EN API v1 calling it as well as pref to call this method not more often than once in a week

@nc-kano done