Issues with translation jsons after #2271

Description

There are two problems with the translation jsons after #2271 was merged:

The CI fails because some languages use the nbsp (non-breaking space) character, and it fails the linting step in the CI.
Some translations have still have the old kebab-cased keys that look like "###read-more###" in the GlotPress interface. We cannot ensure that the translators change the keys manually to camelCase, so we should add a step to camelize keys locally when saving jsons, instead.

Reproduction
The first problem was reported by @zackkrida in #2398:

While trying to push this I also noticed that after the merging of #2271, some of the generated translation files fail eslint:

openverse/frontend/src/locales/de.json
  171:29  error  Irregular whitespace not allowed  no-irregular-whitespace
  236:29  error  Irregular whitespace not allowed  no-irregular-whitespace
  472:29  error  Irregular whitespace not allowed  no-irregular-whitespace
  706:29  error  Irregular whitespace not allowed  no-irregular-whitespace

openverse/frontend/src/locales/fr.json
   68:28   error  Irregular whitespace not allowed  no-irregular-whitespace
   68:108  error  Irregular whitespace not allowed  no-irregular-whitespace
   68:112  error  Irregular whitespace not allowed  no-irregular-whitespace
   68:135  error  Irregular whitespace not allowed  no-irregular-whitespace
   68:143  error  Irregular whitespace not allowed  no-irregular-whitespace
   68:148  error  Irregular whitespace not allowed  no-irregular-whitespace
   68:156  error  Irregular whitespace not allowed  no-irregular-whitespace
   68:161  error  Irregular whitespace not allowed  no-irregular-whitespace
   68:173  error  Irregular whitespace not allowed  no-irregular-whitespace
   71:32   error  Irregular whitespace not allowed  no-irregular-whitespace
   92:39   error  Irregular whitespace not allowed  no-irregular-whitespace
  182:48   error  Irregular whitespace not allowed  no-irregular-whitespace
  182:56   error  Irregular whitespace not allowed  no-irregular-whitespace

openverse/frontend/src/locales/lv.json
  11:24  error  Irregular whitespace not allowed  no-irregular-whitespace

openverse/frontend/src/locales/ru.json
  321:230  error  Irregular whitespace not allowed  no-irregular-whitespace

I don't think we want to lint those files at all, so I've added them to the root .eslintignore. Does that seem right @obulat?

To see the second problem, you can run just frontend/run i18n and check one of the ".json" files. If you look at nl.json, and search for string "cc-search" or "read-more", you'll see that the key wasn't renamed to "ccSearch" or "readMore". This is why in the migration banner in nl locale (https://openverse.org/nl?referrer=creativecommons.org), you won't see "CC Search", or "read more" link.
Additional context

I've marked this issue as critical because the PRs are failing CI without it.

Confirming that the issue is now fixed in staging:

Compared to the error in production:


Spelling Error

I noticed some spelling errors in your documentation.
Check the Default Code Sample section, the word function is misspelled as fucntion

Thanks for the heads up. I too have noticed some mistakes in grammar and spelling and will be updating the documentation in the next release.
Didn't want to keep making new releases for just grammar edits.
If anyone has any questions about something there, please don't hesitate to reply to this issue.
Rye

Spelling and grammar mistakes have been fixed.


Action Mask for certain user roles

Allow user to to give the agent a set of actions that the particular logged in user is allowed to run. For eg. on an e-commerce site, if the user is a seller, he can use the chatbot to run all the seller actions but a customer cannot access sellers' actions.
The processor's handle_message(), could be modified to receive one extra argument 'allowed_actions' which could be a list of all the names of actions that that particular user is allowed to run.
Then, in the _predict_and_execute_next_action():
def _predict_and_execute_next_action(self, message, tracker, allowed_actions=None):
    # this will actually send the response to the user

    dispatcher = Dispatcher(message.sender_id,
                            message.output_channel,
                            self.nlg)
    # keep taking actions decided by the policy until it chooses to 'listen'
    should_predict_another_action = True
    num_predicted_actions = 0

    self._log_slots(tracker)

    # action loop. predicts actions until we hit action listen
    while (should_predict_another_action and
           self._should_handle_message(tracker) and
           num_predicted_actions < self.max_number_of_predictions):
        # this actually just calls the policy's method by the same name
        action, policy, confidence = self.predict_next_action(tracker)
        if allowed_actions is not None:
            if action.name() in allowed_actions:
                should_predict_another_action = self._run_action(action,
                                                                 tracker,
                                                                 dispatcher,
                                                                 policy,
                                                                 confidence)
            elif action.name() == ACTION_LISTEN_NAME:
                should_predict_another_action = False
                continue
            else:
                dispatcher.utter_message("You are not allowed to run this action!")
                should_predict_another_action = False
        else:
            should_predict_another_action = self._run_action(action,
                                                             tracker,
                                                             dispatcher,
                                                             policy,
                                                             confidence)
        num_predicted_actions += 1

    if (num_predicted_actions == self.max_number_of_predictions and
            should_predict_another_action):
        # circuit breaker was tripped
        logger.warning(
                "Circuit breaker tripped. Stopped predicting "
                "more actions for sender '{}'".format(tracker.sender_id))
        if self.on_circuit_break:
            # call a registered callback
            self.on_circuit_break(tracker, dispatcher)

The Actions a user is allowed to run can either be restricted as shown above by making the developer give the handle_message method of agent class a list of action names,
OR,
Alternatively, we can have each action have a default override-able method which the user has to implement and define which types of users/which specific users can run them.

Thanks for raising this issue, @tmbo  will get back to you about it soon.

@anurags397 part of the latest release of the rasa core sdk is the ActionExecutionRejection exception. I think you can use it to do exactly that (checking the users permissions in the run method of the action and throw this exception if not possible to run the action - you could even create a superclass to avoid copying this to all your protected actions).
The ActionExecutionRejection will result in the action server reporting back to core that this specific action can not be run. Core will then select the second most likely action instead and try to run that.

Thank you for sharing your ideas and giving pointers on how do it.
At the moment I'm using this to prevent unauthorized use:
        while (should_predict_another_action and
               self._should_handle_message(tracker) and
               num_predicted_actions < self.max_number_of_predictions):
            # this actually just calls the policy's method by the same name
            action, policy, confidence = self.predict_next_action(tracker)

            if allowed_actions is not None or []:
                if action.name() in allowed_actions:
                    print("User is allowed to run action {0}".format(action))
                    should_predict_another_action = self._run_action(action,
                                                                     tracker,
                                                                     dispatcher,
                                                                     policy,
                                                                     confidence)
                elif action.name() == ACTION_LISTEN_NAME or action.name() == ACTION_RESTART_NAME \
                        or isinstance(action, UtterAction) or isinstance(action, ActionDeactivateForm) or \
                        isinstance(action, ActionDefaultFallback):
                    should_predict_another_action = self._run_action(action,
                                                                     tracker,
                                                                     dispatcher,
                                                                     policy,
                                                                     confidence)
                else:
                    dispatcher.utter_message("You are not allowed to run this action!")
                    should_predict_another_action = False
            else:
                should_predict_another_action = self._run_action(action,
                                                                 tracker,
                                                                 dispatcher,
                                                                 policy,
                                                                 confidence)
            num_predicted_actions += 1

within the handle_message() function of the processor.py file.
I haven't come around to rewrite it properly but I've checked that this code works for all situations.
It prevents the core from even activating the action on the action server if the user is not permitted to run said action.
All I had to do was to add a new parameter "allowed_actions" whose type is a list of action names permitted for that user to the handle_message() and handle_text() functions of agent.py and processor.py.
In agent.py:
def handle_message(
            self,
            message,  # type: UserMessage
            message_preprocessor=None,  # type: Optional[Callable[[Text], Text]]
            allowed_actions=None,  # type: Optional[List[Text]]
            **kwargs
    )


299 refactoring removing range cluster 02

This pull request removes range constraints from ten object properties in ebucoreplus ontology.
Changes

Removed the range "AncillaryData" from the property "hasAncillaryData".
Removed the range "AnimalBreedCode" from the property "hasAnimalBreedCode".
Removed the range "AnimalColourCode" from the property "hasAnimalColourCode".
Removed the range "Agent" from the property "hasAnimalGroom".
Removed the range "Involvement" from the property "hasAnimalRole".
Removed the range "Agent" from the property "hasAnnotationAgent".
Removed the range "time:Instance" from the property "hasAnnotationCurationDateTime".
Removed the range "owl:Thing" from the property "hasAnnotationTarget".
Removed the range "Agent" from the property "hasArtefactBuyer".
Removed the range "Agent" from the property "hasArtefactOwner".

Reviewer
@aro-max
@JuergenGrupp

Hey @JuergenGrupp,
The issue with 150 lines changed due to blanks happening automatically when I removed the range and saved the file. I'll investigate this in my next commit to prevent it.

Hey @aro-max,
Can you please review it?

this is a gentle nudge to @aro-max to review this, please!


*: introduce slog_panic and SlogFormat

What is changed and how it works?
Issue Number: Ref #12842
What's Changed:
These two are helpers to utilize the static KV pairs in logger. In the
past, we use `logger.list()` to try to format the configured KV pairs,
but it will not work as values are omitted.

Check List
Tests

Unit test

Release note
None

/merge


MacOS | TSInstallSync norg

I'm trying to install the TS Parser using gcc-12 in macOS as the following:

and i'm getting the following error:

i tried some workarounds that i found here but i'm still not able to install the parser
i'm using the following nvim version:
NVIM v0.8.3
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by<EMAIL_ADDRESS>
if there is something else that i can bring your for context, or if i'm missing a detail, please let me know
Thank you in advanced and thank you for the hard work!

This worked for me:
brew install gcc@12
CC="/opt/homebrew/bin/gcc-12" nvim
CC="/opt/homebrew/bin/gcc-12" nvim -c "TSInstallSync norg"

Thank you @g-battaglia-h-farm , that actually works.
Closing


Azure Healthbot swagger

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[x] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. November 2020
When you expect to publish swagger? Please provide date, or month to public if date is not available yet. November 2020
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@pilor Thanks for the review, I made the required changes in the code.
I also replaced the use of the word "Bot" with "HealthBot" for clarity.

@pilor I made the required changes.

@guy-microsoft As ARM signed off, please let me know when this PR is ready to merge. Thanks.

@xccc-msft This PR is ready to merge, Thanks.


client_non_spring has a lot of Spring dependencies

Hello,
I followed strictly the client_non_spring documentation and the generated client includes Spring Framework.
The generated classes that import org.springframework.* are:

MutationExecutor
QueryExecutor
SpringConfiguration

Yes, that's right.
I know I have a work to on dependencies. But I have some stuff to finish before.
Étienn

I studied your comment.
Based on these points:

The future of this plugin is to be merged with the spring-graphql. I'll work on this soon.
My (very personnal) opinion, is that using Spring is the best way to develop Java app.
It would be complex to have a client runtime without spring dependencies included (complex to separate and complex to test)

Based on these points, the Spring dependencies would still be included in future versions.
Etienne

Thank you for fixing this.
My (very personal) opinion about Spring is completely different:

has a lot of magic inside - just adding spring-security dependency you'll have a very nice login page that you didn't need or implemented, also you'll have to override some stuff to get rid of it.
was also kinda late to the reactive party, and from what I understood, you can't write both imperative and reactive.
The artifacts are bigger and slower than some of their competition - https://www.baeldung.com/spring-boot-vs-quarkus
Kind regards,
Mircea C.


Wrong image size after cropping

Version: 2.6.0
Setup
var config = Mantis.Config()
config.cropViewConfig.cropShapeType = .circle(maskOnly: true)
config.presetFixedRatioType = .alwaysUsingOnePresetFixedRatio(ratio: 1/1)

Issue
Selecting a screenshot image of size 1290 x 2796 with a crop ratio of 1:1 produces an image with the same resolution as the original, no matter which area or zoom I choose when cropping.

Hi @budidino
Can you check if this issue is similar with #250?

Does it happen to all images? Does it still work with 2.4.0 now?

Hi @budidino Can you check if this issue is similar with #250?

It could be related, but I don't know if that is an iOS version issue. It seems like a vertical image issue. I tested it using 2.4.0 and 2.6.0, and it is very easy to replicate on both... take a screenshot and use that photo for Mantis. It works ok with all my other images tested so far... mostly square or horizontal, but I wonder if that even matters.

Does it happen to all images? Does it still work with 2.4.0 now?

Same issue on 2.4.0 and higher versions

Can you check the Example project inside Mantis in master branch with your image and config?

Would you mind posting one screenshot here so I can test with your screenshot? Thanks!

Never mind. I reproduced it.

@budidino
I fixed this issue in this fix-bitmapInfo-error branch
Can you have a test to see if it works for you? Thanks!

I'll test it first thing tomorrow ;)

I released Mantis 2.6.1 which includes this fix. @budidino


Update tsconfig link to point to the official docs

Hi @samiraguiar, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

thanks!


Actual behavior
Call POST /api/latest/replicate with bad data and it turns the bad data into even crazier data.
Steps to reproduce the problem

Call POST /api/latest/replicate with the following data:
 {                                blockchain_id = balance.blockchain_id,                                dataset_id = status.data.dataset_id,                                holding_time_in_minutes = 60,                                litigation_interval_in_minutes = 120,                                token_amount_per_holder = "0.01"                            }

When I checked the replicate result API call it showed -199 for the token_amount_per_holder which is pretty random?

No one bid on the job because it was too expensive. I asked in telegram and got the following from other users:
"2021-04-02T23:32:22.556Z - info - Accepting offer with price:<PHONE_NUMBER>37316195423570985008687907853269984665640564039457584007913129639737 TRAC."

Users were also getting warnings they did not have enough TRAC (users have alerts for these on telegram oops!).
Transaction for job creation: https://blockscout.com/xdai/mainnet/tx/0x9af67b3d3324c8320846984002b01c9c8ca2dac91bd0c2f05513db201b020237/internal-transactions
This mostly happened because I was winging it as I followed the parameters on https://app.swaggerhub.com/apis-docs/otteam/ot-node-api/v2.1#/replicate/post_replicate but it's missing 3 parameters (including token_amount_per_holder).
So I did a quick look in the source code and saw it was a number, In hindsight I guess it's the gwei equivalent number and not the human readable number.
This probably needs some more protection in the API code to stop me (or others) doing this again!
Specifications

Node version: v5
Platform: N/A
Node wallet: https://blockscout.com/xdai/mainnet/address/0xBe752aba11520D9b01c134B28ffe9B5F8E27f8d2/transactions
ERC725 identity: 0xb482bf4cc68770b50c405f3b17e0da6e9b0e98f3

Contact details

Email<EMAIL_ADDRESS>

Separately, this has completed nuked OT Hub v5 as my database doesn't support numbers like<PHONE_NUMBER>37316195423570985008687907853269984665640564039457584007913129639737. Figuring out how I'm going to fix that on my side now...

The documentation at https://docs.origintrail.io/en/latest/introduction-to-api.html points to the 2.1 swagger page (https://app.swaggerhub.com/apis-docs/otteam/ot-node-api/v2.1) in case I shouldn't have used that.

OT Hub is syncing again but I've skipped this job so you won't see it on the website.

Testnets nodes don't seem to require token_amount_per_holder on the replicate API call. Not sure if that's a difference between testnet/mainnet or if I did something silly.

That's really strange, I'll investigate it


Add missing dependencies

I noticed some dependencies were missing to be able to build and test on a clean install. The distribution file is unchanged after these additions.

Thanks, looks good to me. Awesome to see that you're still using this 👍


Trigger declaration generation in vite build watch mode when non-ts file changes

Description
At the moment, when Vite build watch mode is enabled, declarations get generated only when typescript files are modiefied.
I think the declarations should be generated on every change or we should be able to specify which file types trigger the generation.
My use case is that I have a library that has React components and CSS files. When I'm using the watch mode and modify a typescript file, everything works as expected. But when I modify a CSS file, vite triggers a build, which by default empties the out dir first getting rid of the declarations.
Using emptyOutDir would be a way around this, but it has other problems. And even if it worked as its supposed to work, it might have other side effects in different kinds of configurations.
Suggested solution
I'm suggesting that in watch mode, the declarations would get generated on every builld, not just when typescript files changes.
Alternative
Alternatively (or in addition), a config option for file extensions (or globs) that trigger the generation would be a viable solution.
Additional context
No response
Validations

[X] Read the FAQ.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Would you try to using the include option to include those CSS files and test whether it works?

Including .css files doesn't seem to change anything.


autosummary files are not included

Hi all,
I am not sure what have happened with read the docs web site. My api page should read like this is empty on rtdc. It was fine before version v0.1.3.
I referred to latest build log, and found these:
/var/build/user_builds/pyexcel/checkouts/latest/doc/source/generated/pyexcel.Book.rst:: WARNING: document isn't included in any toctree
/var/build/user_builds/pyexcel/checkouts/latest/doc/source/generated/pyexcel.Book.number_of_sheets.rst:: WARNING: document isn't included in any toctree
/var/build/user_builds/pyexcel/checkouts/latest/doc/source/generated/pyexcel.Book.save_as.rst:: WARNING: document isn't included in any toctree
/var/build/user_builds/pyexcel/checkouts/latest/doc/source/generated/pyexcel.Book.save_to.rst:: WARNING: document isn't included in any toctree
/var/build/user_builds/pyexcel/checkouts/latest/doc/source/generated/pyexcel.Book.save_to_database.rst:: WARNING: document isn't included in any toctree
Can someone tell me how to fix it? When I do documentation locally, I dont have such problem at all.
Cheers,
chfw

What version of sphinx are you using locally? <1.3?

Local version is 1.2.3 and rtd used 1.2.2. When I install sphinx v1.3.0+, I can reproduce it locally as well. So is it too early to adopt sphinx 1.3.0+ for readthedocs?

Not at all, we are running 1.3.1 on readthedocs. You are hitting the issue described here: #1290, which is a bug in sphinx.
Closing this ticket as a dulpicate, we'll be sure to adopt the latest sphinx when a release is made.


Update examples to use Vita PWA for full offline support in the browser.

We switched to Vita as the bundler for our examples partly because then it's trivial to use https://vite-pwa-org.netlify.app to make them work fully offline (i.e.: the page loads even when refreshed / loaded when offline).
We haven't done this yet, as per:

Let's do it.

The benefit is fairly large here: we can demonstrate working offline systems which is a key benefit of Electric sync.
I'm under the impression that https://vite-pwa-org.netlify.app/guide/ abstracts this for us and we just include their generated manifest etc. and it just works. Do you think that it won't / will we hit issues because of this?

We had a lot of issues with service workers at Gatsby and while Google pushed the various PWA technologies really hard in the mid 2010s, they by and large haven't been adopted by the industry as they can cause a lot of trouble as SW are permanently installed on clients and almost impossible to get rid of if you make certain mistakes.
Perhaps vite-pwa has solved all the problems and it's trivial to use but... I suspect not.
That being said, I agree it'd be nice to demo as people will want to see it — how about we just add it to one example and see how it goes? E.g. the tanstack one as that's the only one that has offline write support atm as well.

Yup, maybe the big linearlite that Sam's working on merging instead / as well? That's a key one that we demo and would be nice to show working fully offline (unlike Linear!).

@samwillis fancy vite-pwaing up big linearlite whilst you're there?


[openai.error.InvalidRequestError]: The model: gpt-4 does not exist

We have access to gpt-4 still it throws the error. Is there any way to dynamically configure gpt-3.5 or other LLM models?

Hi @Pranavchiku ,
try using this spark_ai = SparkAI(llm=ChatOpenAI(model_name='gpt-3.5-turbo', temperature=0))
Thanks

Thank you @sharshjot it is working :)
Do let me know if you have any easy-to-fix issues, I will be very happy to contribute


Handle SIGTERM in process and to exit immediately

It currently takes 10 seconds before Docker force kills the container on stop. See the Docker FAQ.
If this process can handle the SIGTERM signal directly, or include something like dumb-init, then the process can exit on demand and then docker doesn't have to force kill the container.

Yes, will take a look when I'm back from vacation in august.


featreq: support for multiple URLs

It would be nice to be able to specify a list of URLs to send traffic to.
Not sure how best to handle the division of URLs vs traffic, but for my personal needs a simple round-robin across the URLs would work. I.e. with 2 URLs: request1 -> url1, request2 -> url2, request3 -> url1, request4 -> url2, etc.

@iggy Hey, thank you for your suggestion! Actually I'm looking into that, but at the same time I would definitely like to keep this tool as simple as possible. We need to think about other stuff, e.g. how to draw the charts, etc.

Vegeta seems to support a formatted body that can contain multiple URLs/methods/body (you have to create a different type of targeter instead of using NewStaticTargeter with a single request)
It should be pretty easy to  add an option that instruct the attacker to create the different type of targeter.
Would you accept a pull request for that ?


please make 1.16.5 chisel and bits is that version

chisel and bits is for 1.16.5 please make a 1.16.5

Invalid issue, closing
Issues are for bug reports and stuff like that, I am well aware that people want 1.16-1.17, work in progress. Look at the discord server I guess, more updates over there first


CDS-88452-broken-link

https://harness.atlassian.net/browse/CDS-88452
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[x ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

https://harness.atlassian.net/browse/CDS-88452

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65a04efc6a9a6c36a5838e8e--harness-developer.netlify.app


Cheep-msg starting with @ cannot be written/stored in db

The stored msg will contain an empty string.
ReadCheeps() is not a problem: It is possible to manually insert a string starting with @ in the csv-file and have the string returned properly.
Acceptance:

Be able to store the string: "@", using dotnet run cheep in the CSV-file.

This seems like a really weird bug with how CSVHelper saves to a file. Using Raw string literals didn't even fix this issue so I'm going to close this issue since we now just have an error message that displays so users cant post cheeps like that


Join the two sections about the method into one as it was before.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (6e42b9a) to head (0806a53).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines         1590      1590
=========================================
  Hits          1590      1590

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Shadows are turned on, but shadows are not displayed on the map tiles.

Is your feature request related to a problem? Please describe.
I have configured the theme json

And set the light.Shadows are turned on, but shadows are not displayed on the map tiles.

Describe the solution you'd like

shadows are displayed on the map tiles.

Hi @datouzhan,
did you enable the shadows in MapView too, something like:
  map = new MapView({         canvas,         theme,         enableShadows: true     });
This is needed to enable the shadow on the map materials too.
Let me know if this helps.
Frauke

Yes,I've already set it enable.But it didn't help.The map loaded is WebTileDataSource. if it has anything to do with this.

Yes,I've already set it enable.But it didn't help.The map loaded is WebTileDataSource. if it has anything to do with this.

ah sorry, I should have seen that from the screenshot probably, ... it will only work with a VectorTileDataSource below

This is really sad news. if I want the map tiles to also show shadows, do I need to expand it?

Hi, I just checked, whats actually missing to make it work... I created some draft PR so you can try it out https://github.com/heremaps/harp.gl/pull/2125/commits .. I ll try to polish it later and push it to master

I'm glad to hear that.  @FraukeF , When will the next version be built?

@datouzhan , @FraukeF  has a merged PR: https://github.com/heremaps/harp.gl/pull/2125
We will do a release in the next week, so stay tuned.


Create word list for "der die das" game

This subtask is part of issue #48: Create der die das game
Create or source a comprehensive list of German nouns with their correct articles and translations for use in the "der die das" game. This list will be used to randomly generate words for each game screen.
Requirements:

Compile a list of at least 200 German nouns suitable for B1 level learners

Include the following information for each noun:

The German noun
Its correct article (der, die, or das)
Its translation (in English or Russian, as per project requirements)
A difficulty rating or frequency indicator (to allow for progression from common to less common words)

Ensure a good mix of nouns with different articles (der, die, das) to provide balanced practice

Verify the accuracy of all entries, including spelling, articles, and translations

Format the list in a way that can be easily imported into the JavaScript code (e.g., JSON format)

Document any sources used for the word list and ensure compliance with copyright and licensing requirements

Example format:
[
  {
    "word": "Apfel",
    "article": "der",
    "translation": "apple",
    "difficulty": 1
  },
  {
    "word": "Sonne",
    "article": "die",
    "translation": "sun",
    "difficulty": 1
  },
  {
    "word": "Buch",
    "article": "das",
    "translation": "book",
    "difficulty": 1
  },
  ...
]

Ensure that the word list covers a range of topics and difficulty levels appropriate for B1 learners preparing for their exam. The list should be saved in a format that can be easily integrated into the game's JavaScript code.

--logs--
Agent: dev
Task failed.
Details

Output:

Error:
Error: Command failed: git commit -m 'Issue #52: A new task has been created for the manual collection of German nouns with their correct articles and translations. The task number is #58.'

  </p>
  </details>

--logs--
Agent: dev
Task failed.
Details

Output:

Error:
Error: Command failed: git clone -q -b main  --depth=1 git@github.com:SergKam/learning-games.git workspace/dev
/bin/sh: git: not found

  </p>
  </details>

--logs--
Agent: dev
Task failed.
Details

Output:

Error:
Error: Command failed: git clone -q -b main  --depth=1 git@github.com:SergKam/learning-games.git workspace/dev
ssh -i ~/.ssh/id_ed25519 -o IdentitiesOnly=yes: line 0: ssh: not found
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

  </p>
  </details>

--logs--
Agent: dev
Task failed.
Details

Output:

Error:
Error: Command failed: git clone -q -b main  --depth=1 git@github.com:SergKam/learning-games.git workspace/dev
fatal: could not create work tree dir 'workspace/dev': Permission denied

  </p>
  </details>

--logs--
Agent: dev
Task failed.
Details

Output:

Error:
Error: Command failed: git clone -q -b main  --depth=1 git@github.com:SergKam/learning-games.git workspace/dev
Warning: Identity file /root/.ssh/id_ed25519 not accessible: Permission denied.
Host key verification failed.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

  </p>
  </details>

--logs--
Agent: dev
Task failed.
Details

Output:

Error:
Error: Command failed: git commit -m 'Issue #52: A new task has been created to source or compile the list of German nouns with their correct articles and translations. The task number is #59.'

  </p>
  </details>

--logs--
Agent: dev
Task failed.
Details

Output:

Error:
Error: Command failed: git commit -m 'Issue #52: The webpage for sourcing the list of German nouns returned a 404 error. I will proceed to create a comprehensive list of German nouns with their correct articles and translations manually.


release v0.0.20

:white_check_mark: odo build 1794 completed and artifacts can be found here (for commit https://github.com/redhat-developer/odo/commit/114ceb8ea1 by @surajnarwade)


Implement WAN queue via go-libp2p-pubsub

See #2 for master bug. The goal is to create a decentralized, distributed cluster of 3D printers that share a work queue.
PySyncObj is great for consensus and state agreement - but it is not sufficient since it lacks authentication.
go-libp2p-pubsub is a pubsub implementation using the same IPFS distributed systems that has some of this auth stuff already. As a transport layer, it makes some sense.
Combine the two - implement a pubsub-based Transport class that backs pysyncobj's RAFT consensus log, that then gets passed in on init. That changes very little about the overall algorithm, which means we have minimal code paths to maintain.

This is now done and checked in.


AudioPlaylist cannot automatically play next song

Hi there! Love this library, you have done a fantastic job. I am making a simple audio player, and wrote up the following code below - however, the playlist does not automatically move onto the next song in the list after the current one finishes. I've tried setting loop to true, enabling shuffle, and playlist.end doesn't seem to work.
Here is the code below, is there something I'm missing? Using 0.7.0, latest release.
import { useState, useMemo, useEffect, useRef } from "react";
import {
  IoMdPlay,
  IoMdPause,
  IoMdSkipForward,
  IoMdSkipBackward,
  IoMdMusicalNote,
  IoMdMusicalNotes,
} from "react-icons/io";
import { AudioPlaylist } from "ts-audio";
import FatsNY from "../assets/mp3/FatsNY.mp3";
import PictureBall from "../assets/mp3/PictureBall.mp3";
import Silvery from "../assets/mp3/Silvery.mp3";
import SecretGarden from "../assets/mp3/SecretGarden.mp3";

export default function MusicPlayer(props: any) {
  const [currentSong, setCurrentSong] = useState(0);
  const [isPlaying, setIsPlaying] = useState(false);

  interface Song {
    title: string;
    artist: string;
    img_src: any;
    src: string;
  }

  const songs: Song[] = useMemo(
    () => [
      {
        title: "At the Moving Picture Ball",
        artist: "Maurice Burkhart",
        img_src: IoMdMusicalNote,
        src: PictureBall,
      },
      {
        title: "New York Yacht Club",
        artist: "Fats Waller",
        img_src: IoMdMusicalNote,
        src: FatsNY,
      },
      {
        title: "By the Lights of the Silvery",
        artist: "Fats Waller",
        img_src: IoMdMusicalNotes,
        src: Silvery,
      },
      {
        title: "Secret Garden",
        artist: "Unknown",
        img_src: IoMdMusicalNote,
        src: SecretGarden,
      },
    ],
    []
  );

  const playlist = useMemo(() => {
    return AudioPlaylist({
      files: songs.map((song: Song) => song.src),
      loop: false,
    });
  }, [songs]);

  playlist.on("start", (param) => {
    // doesn't seem to have any data in the param
    console.log(param);
  });

  playlist.on("end", (param) => {
    // doesn't seem to work
  });

  const handlePlay = () => {
    playlist.play();
    setIsPlaying(true);
  };

  const handlePause = () => {
    playlist.pause();
    setIsPlaying(false);
  };

  const handleSkip = () => {
    playlist.pause();
    playlist.next();
    setIsPlaying(true);

    setCurrentSong(
      (currentSong) => (currentSong + 1 + songs.length) % songs.length
    );
  };

  const handlePrevious = () => {
    playlist.pause();
    playlist.prev();
    setIsPlaying(true);
    setCurrentSong(
      (currentSong) => (currentSong - 1 + songs.length) % songs.length
    );
  };

  return (

Now Playing

          {songs[currentSong].title} by {songs[currentSong].artist}

        <IoMdSkipBackward
          style={{ cursor: "pointer", margin: 12 }}
          onClick={handlePrevious}
        />
        {isPlaying ? (
          <IoMdPause
            style={{ cursor: "pointer", margin: 12 }}
            onClick={() => (!isPlaying ? handlePlay() : handlePause())}
          />
        ) : (
          <IoMdPlay
            style={{ cursor: "pointer", margin: 12 }}
            onClick={() => (!isPlaying ? handlePlay() : handlePause())}
          />
        )}
        <IoMdSkipForward
          style={{ cursor: "pointer", margin: 12 }}
          onClick={handleSkip}
        />

  );
}

Nevermind - it's Safari. It works perfectly, but not on Safari. I guess that's a bug worth reporting too eh?

Indeed this feature is not working on Safari and to be honest I was not aware of that. Thanks for bringing it up @mikhael28!
I will investigate this issue in the next few days, maybe there is a solution for that. As far as I understood, Safari does not handle the end AudioContext event, which we use to move the playlist to the next audio (https://github.com/EvandroLG/ts-audio/blob/master/src/playlist/playAudio.ts#L19). There are other ways to do that, so I am confident that we can create a cross-browser solution for this feature! :)

That sounds like a solid solution - I want to reiterate how much I like the simplicity of your package. In case you are curious how it’s being used, my open-source project is at https://github.com/mikhael28/paretOS
It’s a ‘high level’ operating system for human performance, and our goal is to include the software that is most helpful and beneficial for people learning new skills, or trying to perform at the highest level in their current occupations. It’s a bit of a broad mandate, but the underlying ethos is to include the 20% of software that is genuinely useful - and leave the junk out. Your audio player was added as a proof of concept for a simple music player, that people can run in the background while doing their work - using public domain jazz music at the moment, but we will add support for playlists like classical and deep house when we have a chance. Maybe even death metal, some people love that for work music.

Hi 👋 , @EvandroLG has the safari issue been solved?

At this point, I might want to look into any 'conditional-render-if-safari' packages, because there are so many places where Safari mucks up the works.

Heu @ordinz and @mikhael28
Unfortunately, I didn't find a solution for this bug yet 😞
Sorry for not keeping you posted here, but my initial assumption about this issue was incorrect and I don't have a good explanation for why this autoplay feature is not working on Safari. To be honest, I'm unsure if there is a solution for that or if it's an issue related to the internal implementation on Safari.
Let's keep this issue open anyway in case someone else has a clue about how to solve it on Safari 👊

Heu @ordinz and @mikhael28 Unfortunately, I didn't find a solution for this bug yet 😞 Sorry for not keeping you posted here, but my initial assumption about this issue was incorrect and I don't have a good explanation for why this autoplay feature is not working on Safari. To be honest, I'm unsure if there is a solution for that or if it's an issue related to the internal implementation on Safari. Let's keep this issue open anyway in case someone else has a clue about how to solve it on Safari 👊

Thank you @EvandroLG for the update, I really appreciate it.


Combine feature request mode samples

This PR combines the three existing samples that showcase our different service feature table request modes into one.

Deletes Service Feature Table Cache and Service Feature Table No Cache samples
Replaces Service Feature Table Manual Cache with a new sample Toggle Between Feature Request Modes -> since this is a new sample I have also updated the copyright on the file.
New sample has new data, and a new UI (three radio buttons to flip between different request modes, and a populate button to carry out the manual cache mode).

@jenmerritt could you review please?

thanks @jenmerritt , I've set the vbox to disabled whilst the mapview is still drawing: this should guard against the behaviour you found. could you take another look please? thanks!


added static syntax analysis tools for Tcl-lang

Adds new section for static syntax analysis tools for Tcl language.
Thanks.

Thanks @sebres. 🎉

TY :+1:


Feat/require params

Make all contracts deploy methods static
Use a promise to track loading/failure of StatefulContract
StatefulContract DOES NOT load in the constructor. This is because it makes it extremely hard to handle an error if it should fail.
Add function loadContract in StatefulContractWrapper that loads the contract, or returns the contract instance or loading promise if already loading/loaded. This is called at the beginning of every KlerosPOC method.
Make some of the wrappers required in constructors. NOTE: They are not required at the base level of resource wrappers. This is because Notifications and Event Listeners can still function without many of these wrappers. Therefore for resource wrappers they are required at a higher level.

NOTE: Tests no longer use base level Kleros object, as there is no StoreProvider, which is now required

Pull Request Test Coverage Report for Build 577

67 of 119 (56.3%) changed or added relevant lines in 19 files are covered.
80 unchanged lines in 11 files lost coverage.
Overall coverage decreased (-11.9%) to 44.93%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/contractWrappers/arbitrator/index.js
0
1
0.0%

src/contractWrappers/ContractWrapper.js
1
2
50.0%

src/contractWrappers/arbitrableContracts/index.js
0
1
0.0%

src/abstractWrappers/index.js
0
2
0.0%

src/utils/deployContractAsync.js
5
7
71.43%

src/contractWrappers/arbitrator/KlerosPOC/index.js
21
24
87.5%

src/resourceWrappers/index.js
0
3
0.0%

src/contractWrappers/index.js
0
4
0.0%

src/resourceWrappers/Notifications/index.js
10
15
66.67%

src/resourceWrappers/Disputes/index.js
1
8
12.5%

Files with Coverage Reduction
New Missed Lines
%

src/resourceWrappers/EventListeners/index.js
1
71.19%

src/contractWrappers/RNG/index.js
2
0.0%

src/contractWrappers/ContractWrapper.js
2
60.53%

src/resourceWrappers/ResourceWrapper.js
2
53.49%

src/contractWrappers/PNK/index.js
2
0.0%

src/abstractWrappers/arbitrator/index.js
2
90.91%

src/contractWrappers/RNG/BlockHashRNG/index.js
3
18.18%

src/kleros.js
9
0.0%

src/abstractWrappers/arbitrableContracts/index.js
10
34.0%

src/resourceWrappers/Disputes/index.js
23
38.16%

Totals

Change from base Build 575:
-11.9%

Covered Lines:
478

Relevant Lines:
886

💛  - Coveralls


MongoDB (post-GA); add links to new Guide

At the end of the Getting Started Guides (from scratch and add to), this block needs to be edited to link to the new Prisma with MongoDB guide:
"There are also a number of subtle differences in how the schema is setup when compared to relational databases like PostgreSQL.
For example, the underlying ID field name is always _id and must be mapped with @map("_id").
For more information check out the MongoDB schema reference."

This is documented as part of the Getting Started guide


Plugin won't install successfully

Running "cordova plugin add cordova-plugin-cocoapod-support" gives following error log

Fetching plugin<EMAIL_ADDRESS>via npm
Installing "cordova-plugin-cocoapod-support" for ios
node-pre-gyp http GET https://github.com/libxmljs/libxmljs/releases/download/v0.18.4/node-v46-darwin-x64.tar.gz
node-pre-gyp http 404 https://github.com/libxmljs/libxmljs/releases/download/v0.18.4/node-v46-darwin-x64.tar.gz
node-pre-gyp ERR! Tried to download(404): https://github.com/libxmljs/libxmljs/releases/download/v0.18.4/node-v46-darwin-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v46 ABI) (falling back to source compile with node-gyp)
node-pre-gyp http 404 status code downloading tarball https://github.com/libxmljs/libxmljs/releases/download/v0.18.4/node-v46-darwin-x64.tar.gz
In file included from ../vendor/libxml/xpath.c:476:
../vendor/libxml/trionan.c:194:1: warning: unused function 'trio_is_special_quantity' [-Wunused-function]
trio_is_special_quantity
^
../vendor/libxml/trionan.c:218:1: warning: unused function 'trio_is_negative' [-Wunused-function]
trio_is_negative
^
2 warnings generated.
clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9

https://github.com/libxmljs/libxmljs/releases/download/v0.18.4/node-v46-darwin-x64.tar.gz file does not exist physically.
OS: macOS 10.12.3
Cordova: 6.4.0

I have the same problem.
Installing "cordova-plugin-awscognito" for ios
Fetching plugin "cordova-plugin-cocoapod-support" via npm
Installing "cordova-plugin-cocoapod-support" for ios
node-pre-gyp http GET https://github.com/libxmljs/libxmljs/releases/download/v0.18.4/node-v48-darwin-x64.tar.gz
node-pre-gyp http 404 https://github.com/libxmljs/libxmljs/releases/download/v0.18.4/node-v48-darwin-x64.tar.gz
node-pre-gyp ERR! Tried to download(404): https://github.com/libxmljs/libxmljs/releases/download/v0.18.4/node-v48-darwin-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v48 ABI) (falling back to source compile with node-gyp)
node-pre-gyp http 404 status code downloading tarball https://github.com/libxmljs/libxmljs/releases/download/v0.18.4/node-v48-darwin-x64.tar.gz
In file included from ../vendor/libxml/xpath.c:476:
../vendor/libxml/trionan.c:194:1: warning: unused function 'trio_is_special_quantity' [-Wunused-function]
trio_is_special_quantity
^
../vendor/libxml/trionan.c:218:1: warning: unused function 'trio_is_negative' [-Wunused-function]
trio_is_negative
^
2 warnings generated.
clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9

OS: macOS 10.12.3
Cordova: 6.5.0

I've run into this problem. Current workaround is to run cordova prepare ios again. Plugin appears to have still installed fine, it seems it's just the hook isn't working properly.


findBestMatch() tests the inclusion of default partition name

This pull request implements the change discussed in the Hive user mailing list regarding non-determinisitic behavior of hive in generating DAGS. From the discussion thread:
I have been looking further into this issue, and have found that the non-determinstic behavior of Hive in generating DAGs is actually due to the logic in AggregateStatsCache.findBestMatch() called from AggregateStatsCache.get(), as well as the disproportionate distribution of Nulls in HIVE_DEFAULT_PARTITION (in the case of the TPC-DS dataset).
Here is what is happening. Let me use web_sales table and ws_web_site_sk column in the 10TB TPC-DS dataset as a running example.

In the course of running TPC-DS queries, Hive asks MetaStore about the column statistics of 1823 partNames in the web_sales/ws_web_site_sk combination, either without HIVE_DEFAULT_PARTITION or with HIVE_DEFAULT_PARTITION.

--- Without HIVE_DEFAULT_PARTITION, it reports a total of 901180 nulls.
--- With HIVE_DEFAULT_PARTITION, however, it report a total of 1800087 nulls, almost twice as many.

The first call to MetaStore returns the correct result, but all subsequent requests are likely to return the same result from the cache, irrespective of the inclusion of HIVE_DEFAULT_PARTITION. This is because AggregateStatsCache.findBestMatch() treats HIVE_DEFAULT_PARTITION in the same way as other partNames, and the difference in the size of partNames[] is just 1. The outcome depends on the duration of intervening queries, so everything is now non-deterministic.

If a wrong value of numNulls is returned, Hive generates a different DAG, which usually takes much longer than the correct one (e.g., 150s to 1000s for the first part of Query 24, and 40s to 120s for Query 5).  I guess the problem is particularly pronounced here because of the huge number of nulls in HIVE_DEFAULT_PARTITION. It is ironic to see that the query optimizer is so efficient that a single wrong guess of numNulls creates a very inefficient DAG.

Note that this behavior cannot be avoided by setting hive.metastore.aggregate.stats.cache.max.variance to zero because the difference in the number of partNames[] between the argument and the entry in the cache is just 1.
I think that AggregateStatsCache.findBestMatch() should treat HIVE_DEFAULT_PARTITION in a special way, by not returning the result in the cache if there is a difference in the inclusion of partName HIVE_DEFAULT_PARTITION (or should provide the use with an option to activate this feature).

What's the JIRA Ticket number for this...

I don't think there is a JIRA ticket for this issue yet.


Crashes when trying to share link

I have:

[X] searched open and closed issues for duplicates
[X] provided a reproducible result if applicable

Bug description
When trying to share link of the current wiki page, the app crashes. No info provided, just a dialog telling that ArchWiki Viewer stopped and to close it.
Steps to reproduce

Go to the any page in ArchWiki
Tap on the ⋮ (vertical ellipsis) menu button
Tap "Share link" menu item (or "Compartilhar link" in my pt_BR translated interface)

Actual result: app crashes
Expected result: open dialog to select how I want to share the link for that wiki page
Device info

Device: Samsung Galaxy A5 (2017), SM-A520F
Android version: 8.0.0
App version: 1.0.13
Language: Portuguese (Brazil)

This was fixed in #65 but didn't end up included in the release I made which got deployed as a beta for the Google Play Store and a normal release for F-Droid. It should be resolved in the v1.0.14 release if you want to download the apk directly


Add a tag to prevent fake filler from filling a specific field

I have this requirement where i have a modal dialog displayed, and fields on the main page should not be filled, just those in the dialog. Can we add a tag so we can specify that a field should not be filled.

On the Settings page, under Field Options, there is an Ignore Fields Match text field.  Are you able to meet your use case using that setting?


Warning to keep Azure Event Viewer open

In step 7 of the section "Subscribe to the Blob storage", please add a warning to keep the Azure Event Grid Viewer open. The events disappear if you close the window and reopen it.
I got well caught out by this. I could see that the events were being sent, but they were not appearing. I thought the problem was with Event Grid and repeated the exercise several times -- different region, different subscription, reregister resource provider, etc.
Eventually I stumbled on the resolution!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b250ca39-0ba3-20dc-179b-c5a0d80fba9f
Version Independent ID: 5f1d000e-c731-4b98-8eb7-55836829ca47
Content: Use Azure Event Grid to send Blob storage events to web endpoint - portal - Azure Event Grid
Content Source: articles/event-grid/blob-event-quickstart-portal.md
Service: event-grid
GitHub Login: @spelluru
Microsoft Alias: spelluru

Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

@richardcl1 - Apologize for the inconvenience. I have updated the article with an important note, which will be published around 3:30 PM PST today. Thanks.
#please-close


Python extension activates on any debug

Environment data
VS Code version: 1.18.0
Python Extension version: 0.8.0
Python 2 Version: 2.7.14
Python 3 Version: 3.6.2
OS and version: Fedora 26 x86_64
Actual behavior
The extension always starts when debugging any kind of project.
Expected  behavior
The extension probably  shouldn't start when debugging projects that do not contain any python code.
Steps to reproduce:

Open a non-python project with a launch.json file
Start a debugging session with F5

From what I see in package.json's activation events, it looks like it's supposed to activate on any debugging session. However I don't see the point, as it only slows down debugging other projects.
I know I can just disable the extension for non-python projects, but that activation event still seems a bit overkill. Is there a reason for not using "workspaceContains:**/*.py" (and a few others for other extensions) instead ?

This was left as its possible to start debugging Python code even without having a Python file open (i.e. the activation was the debugger).
However, using "workspaceContains:**/*.py" should fix this.


Example with React/ReactRedux

Can you please make official doc with react and redux as well?

This sample has been archived.
The newer one can be found at: https://github.com/Azure-Samples/active-directory-javascript-graphapi-v2


Don't use branded types for public APIs

For servers, maybe ok. For internal APIs, maybe ok. For public APIs, super rough.

@zachkirsch  this is done right?


Flow freezes when 'merging inference'

Flow checker freezes completely with following code:
// @flow
import React from 'react';
import _ from 'lodash';

export default class Test extends React.Component {

  state: {matrix: Array<Array<boolean>>};
  state = {matrix: _.times(5, () => _.times(5, () => false))};

  toggleCell(rowIndex: number, columnIndex: number) {
    const newRow = this.state.matrix[rowIndex];
    this.setState({matrix: _.set(this.state.matrix, rowIndex, newRow)})
  }

  render() {
    return (
 this.toggleCell(1, 1)}>
);
  }
}

my flow definitions for lodash looks like following:
declare module 'lodash' {
  declare function set(object?: ?Object, path?: ?Array<string>|string, value: any): Object;
  declare function set<T>(array: Array<T>, index: number, value: T): Array<T>;
  declare function times<T>(n: number, iteratee: (i: number) => T): Array<T>;
}

few ways how i can get it fixed:
(1. Move   state = {matrix: _.times(5, () => _.times(5, () => false))};
to constructor:
export default class Test extends React.Component {

  state: {matrix: Array<Array<boolean>>};

  constructor() {
    super();
    this.state = {matrix: _.times(5, () => _.times(5, () => false))};
  }

  toggleCell(rowIndex: number, columnIndex: number) {
    const newRow = this.state.matrix[rowIndex];
    this.setState({matrix: _.set(this.state.matrix, rowIndex, newRow)})
  }

  render() {
    return (
 this.toggleCell(1, 1)}>
);
  }
}

(2. Declare _.times to return any: declare function times<T>(n: number, iteratee: (i: number) => T): any;
(3. Remove _.set: this.setState({matrix: this.state.matrix})
  toggleCell(rowIndex: number, columnIndex: number) {
    const newRow = this.state.matrix[rowIndex];
    this.setState({matrix: this.state.matrix})
  }

Anyone of above is not optimal solution, and last of them breaks the logic. Just wanted to point it out to narrow the problem.
declaring state outside of the constructor should be valid javascript. Webpack&babel compiles it just fine and it works like expected.

state: {matrix: Array<Array<boolean>>} = {matrix: _.times(5, () => _.times(5, () => false))};

thanks @gcanti :) Somehow my mind was stuck with approach i had since usually we define type of state and initialize it separately in the constructor.
Anyhow in my original scenario flow should either be a) error b) it should succeed without freezing.

Looks similar to #1570 somehow (> "something" flow does not like make it ultra slow)

Is this still relevant?

Not relevant to me anymore. Not sure if the issue would still exist though.

This probably can be closed in favor of newer feedback.
/cc @vkurchatkin


Helm 3.6.1 breaks "helm pull" with repo/chartname

Helm 3.6.1 breaks helm pull with repo/chartname (after adding the repo with auth).
How to reproduce:
$ helm repo add myrepo https://example.com/myrepo --username *** --password ***
"myrepo" has been added to your repositories
$ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "myrepo" chart repository
$ helm pull myrepo/mychart
Error: failed to fetch https://example.com/myrepo/mychart-1.0.0.tgz : 401 Unauthorized

Output of helm version:
version.BuildInfo{Version:"v3.6.1", GitCommit:"61d8e8c4a6f95540c15c6a65f36a6dd0a45e7a2f", GitTreeState:"clean", GoVersion:"go1.16.5"}

I've debugged the issue into httpgetter.go - when running helm pull myrepo/mychart the variable u1 contains  myrepo/mychart - that's why this if does not work https://github.com/helm/helm/blob/release-3.6.1/pkg/getter/httpgetter.go#L74

The same happens with any other command that's using httpgetter. Like helm show values some/chart . As @derkoe pointed out correctly, the u1 doesn't contains a full url to compare with. Only the some/chart.  I did a similar debugging as Christian and came to the same conclusion.
Thank you @derkoe for raising the issue and root cause so fast.

Not sure if this helps but it looks like that the url, once discovered from the repositories is not set as url to the options.
I made a small adjustment that resolves the issue: https://github.com/helm/helm/compare/v3.6.1...dol:patch/v3.6.1?expand=1

@mattfarina please have a look at this issue (usually i wouldn't ping but this is a major issue).

@dol tried your fix and it works - could your create a PR?

Could this be related to https://github.com/helm/helm/issues/9816#issuecomment-863868716? :thinking:

@dol I tried your fix for my problem mentioned in https://github.com/helm/helm/issues/9816#issuecomment-863868716 and it works for me as well!

Thanks @dol. If you want to submit a patch along with a test case to help confirm the issue, that would be appreciated.
cc'ing @mattfarina

I was looking into a corresponding test case. IMHO it doesn't look that easy. With the help of repo/repotest it might be possible to spin up two servers that will server the index.yaml file and the other the chart files. Both listening on a different port and server1 pointing to server2 in the index.yaml file.
Not sure if I have the time/knowledge to prepare proper test cases.
IMHO the security patch 3.6.1 was not really tested and skipped some QA steps. It was optimized for speed to fix a long standing security issue. And this is now causing problems.
The way forward would be to announce that 3.6.1 is utterly broken and consider removing the release entirely. Some package managers like brew already server 3.6.1 as a default. My guess is that a lot of people use the https://github.com/helm/helm/blob/main/scripts/get-helm-3 script on their CI/CD pipeline. If no version was defined, the most recent will be downloaded.
Because I had some regression in our CI/CD pipeline due problems and changes of helm we ended up manually increase the version number from time to time. This could be achieved by specifying a desired version:
curl -LsS https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | DESIRED_VERSION="v3.6.0" bash

With the patch that I provided I wanted to shorten the time that it will take someone to identify a possible solution. At the moment I'm not able to provide corresponding test cases. Sorry for that. I only did some tests in our CI/CD environments and everything started working again.

IMHO the security patch 3.6.1 was not really tested and skipped some QA steps. It was optimized for speed to fix a long standing security issue. And this is now causing problems.

While I sympathize with your frustration on this issue, the security audit was conducted by a number of members on the security list, including myself. We did not optimize for speed in any form. We identified the issue, tested the fix against all known use cases, then released it once we verified all known cases worked as expected. This took a number of weeks.
To clarify, the scenarios we were aware of include:

relative URLs
Absolute URLs served from the same hostname
Absolute URLs from an alternative domain

We tested using the following examples, using repotest to help:
urls:
  - /charts/mychart-1.0.0.tgz

urls:
  - https://mydomain.com/charts/mychart-1.0.0.tgz

urls:
  - https://some-other-domain.com/charts/mychart-1.0.0.tgz

But we did not test for this (which apparently is accepted input according to this test case in chartmuseum):
urls:
  - charts/mychart-1.0.0.tgz

Had we known this was a valid use case, we would have accounted for it in our testing.
However I do not agree with the notion that Helm 3.6.1 is "utterly broken". The three scenarios listed above account for a VERY large majority of chart repositories available today.
However, I do acknowledge that there is an uncaught edge case we failed to address. We'll accept pull requests to fix that.

With the patch that I provided I wanted to shorten the time that it will take someone to identify a possible solution. At the moment I'm not able to provide corresponding test cases. Sorry for that. I only did some tests in our CI/CD environments and everything started working again.

Fair enough. We appreciate you taking the time to look into this issue.
If someone has the time to look into this further, we'd appreciate a patch (along with an accompanying test case). Once complete we can schedule a Helm 3.6.2 with the patch.
In the meantime, if everyone could please share their chart repository's index.yaml files so we can investigate if there are other uncaught edge cases, that would be helpful as well.
Thanks all for understanding.

Here is an index.yaml from artifactory that fails with a 401 on helm pull with 3.6.1. I've replaced some variables.
apiVersion: v1
entries:
  <chart-name>:
  - apiVersion: v2
    appVersion: "1.0.0"
    created: 2021-06-21T16:03:31.811852Z
    description: <description here>
    digest: 77831a2c79d411e3420d1cdc9cc7fe598b45315ab5c0e2921e6a053ded479c3b
    name: <chart-name>
    urls:
    - https://<artifactory-url>/artifactory/helm-prod-local/<chart-name>/<chart-name>-v2.0.3.tgz
    version: "v2.0.3"
    type: application
  generated: 2021-06-21T16:03:31.811946Z

Evidence:
hans.knecht:Repositories/ $ helm pull --untar --version 2.0.3 <repo-name>/<chart-name>                                                                                [18:08:26]
Error: failed to fetch https://<artifactory-url>/artifactory/helm-prod-local/<chart-name>>/<chart-name>-v2.0.3.tgz : 401 Unauthorized
hans.knecht:Repositories/ $ helm version                                                                                [18:08:29]
version.BuildInfo{Version:"v3.6.1", GitCommit:"61d8e8c4a6f95540c15c6a65f36a6dd0a45e7a2f", GitTreeState:"dirty", GoVersion:"go1.16.5"}

hans.knecht:Repositories/ $ helm version                                                                                [18:09:56]
version.BuildInfo{Version:"v3.6.0", GitCommit:"7f2df6467771a75f5646b7f12afb408590ed1755", GitTreeState:"clean", GoVersion:"go1.16.3"}
hans.knecht:Repositories/ $ helm pull --untar --version 2.0.3 <repo-name>/<chart-name>

repositories.yaml
  - name: <reponame>
    url: https://<artifactory-url>/artifactory/helm
    username: "<username>"
    password: "<api-key>"
  - name: <reponame>-local
    url: https://<artifactory-url>/artifactory/helm-prod-local
    username: "<username>"
    password: "<api-key>"

It's not just the case you described @bacongobbler

Thank you for providing a test case. Have you identified whether @dol's patch fixes your issue, and why?
If you have the time to contribute a patch, we'd welcome a fix, and we can schedule a hotfix release.

@dol please create a PR with the current code (or should I do that using your patch?)
(And to everybody: please stop arguing who's fault this was - let's focus on the fix)

@bacongobbler: Sorry for the negative wording on this issue. This was not ideal.
I did some further analyses of the issue and want to clarify my points.
The problem appears with to following simple example with the assumption that the repository list is empty:
helm repo add mychart https://my.helmrepo.com/helm --username 'test' --password 'somepassword'
helm show values mychart/basic-application --version 1.0.0 --debug
# The corresponding index.yaml points to https://my.helmrepo.com/helm-charts/basic-application-1.0.0.tgz

This simple example works in 3.6.0, but stopped working with 3.6.1. Even if the index.yaml and the helm chart are hosted on the same schema://hostname:port.
In 3.6.1 the debug output points out that the credentials are not sent while fetching the charts.
Error: failed to fetch https://my.helmrepo.com/helm-charts/basic-application-1.0.0.tgz : 401 Unauthorized
Regarding URL the mychart/basic-application is IMHO a common use case when using a repository. This is the basic example that most of the charts list in their documentation. Eg. https://artifacthub.io/packages/helm/bitnami/mysql
When talking about the URL's that are compared we need to distinguish between the URL that is entered in the command and the resulting http or local URL.
When using mychart/basic-application as an command URL the following steps are performed:

Determine if mychart/basic-application is a local path
Determine if mychart is in the repository list => if yes, step 3
Lookup the corresponding chart URL in the index.yaml of the repository
Check if the repository URL and the chart URL are on the same schema://hostname:post
Download the chart

The recommended patch fixes the step 4 because when ResolveChartVersion ( https://github.com/helm/helm/blob/v3.6.1/pkg/downloader/chart_downloader.go#L161 ) is used the URL u1 will be set to mychart/basic-application. If mychart is a repository then the URL mychart/basic-application should be replaced with https://my.helmrepo.com/helm.
https://github.com/helm/helm/blob/7d28adbaf1fb0d053a469005b7a349965651e93b/pkg/downloader/chart_downloader.go#L224-L227
The test cases of 3.6.1 were adopted to simulate the behavior of repository that points to an other schema://hostname:port. But the test cases fall short for a basic example with helm show values <reponame>/<application>.

With a little bit of copy & paste from other test cases I was able to add the corresponding test case that simulates a default behavior when using a repository and reference the helm chart with  <reponame>/<application>.
The result is https://github.com/helm/helm/pull/9844 .

On the Ubuntus - for example:
# Downgrade Helm from 3.6.1 to 3.6.0 with a Snap installation:
snap list helm --all
sudo snap revert helm --revision 341

I suspect that this problem also affects charts hosted with harbor (which is basically chartmuseum currently).
We're currently forced to either downgrade helm or use --pass-credentials even though the charts are hosted from the same domain, but are referenced as charts/my_chart in the index.

@horihel  this affecty any Chart repo with authentication.
Could any maintainer merge the PR from dol please and release 3.6.2? I guess we need a quick fix for this.

There are a few issues conflated here. Some users are mentioning issues with relative URLs with no leading slash in the index. Others are reporting the repo/chart syntax with helm install is broken (as you mention in the OP).
We need to spend time distilling each into a separate test case, and verify whether @dol's fix applies to only some or all of the test cases. I don't want to release a Helm 3.6.2 knowing that we only caught a small handful of cases and have to release a Helm 3.6.3 a few days later.
It's not totally clear to me at first glance why appending the getter.WithURL(r.Config.URL) option fixes the issue. That part of the codebase was let untouched in the original patch, so we need to look into why there was a cascading failure several levels down the codebase. I need to try and reproduce a similar environment to test. If you have a chart repository with basic auth enabled that can be readily tested against, please feel free to send it my way and I'll try to debug the issue further.
I'll start looking into these issues on Monday. In the meantime, please continue to test and submit fixes. Thanks for being patient.

Can you please test #9871 to see if it fixes your issue.

The PR #9871 is more or less the same approach that PR #9844 tries to fix. Different people in this thread already confirmed that the patch of #9844 resolved the issue. The PR also includes a corresponding unit tests.
I can withdraw my PR in favor of #9871.

@mattfarina Since the #9871 was merged this issue can be closed. With the functionality is restored.
I see one improvement when comparing the hostnames. When using the helm registry Jfrog Artifactory there is a possibility to have a miss match on the hostname.
Artifactory produces a index.yaml that always contains a port. Most users add the repository without the port. This example highlights the problem => https://github.com/helm/helm/issues/9857#issuecomment-868508062
I tried to fix the issue by canonicalize the hostname. https://github.com/helm/helm/pull/9886
If you could take a look at it and probably add it to 3.6.2 would be nice.

Closing as this is fixed. #9886 was added to the 3.6.3 milestone.


Zooming of pdf.js viewer is affected by zooming of other tabs from same origin

Apologies if this is a known issue...  I'm using Firefox 26.0 on Windows, with whatever version of pdf.js is bundled there.
Steps to reproduce:

Have two Firefox windows open side by side, to best see the effect.  In one, go to http://A.org/somefile.pdf, and in the other, go to http://A.org/someotherpage.html.
Select the window with the PDF open.  Use Ctrl + -/+ to zoom in and out of the PDF.  Note that the PDF.js chrome (the navigation bar with the page counts and icons) stays a fixed size, while the content zooms.
Select the other window, and again use Ctrl + -/+ to zoom in and out of the page.  Note the effect on the PDF window -- the chrome and the content all zoom in and out too.  (Actually, it's even subtler: with Ctrl+ +, the navigation bar gets larger, and the content does too, until it reaches the width of the window minus some padding.  Then further Ctrl+ + causes the navigation bar to grow more, and the padding to grow a bit, and hence the content to shrink slightly.  With Ctrl+-, the same thing happens in reverse, where the navigation bar steadily shrinks, and the content grows slightly as the padding shrinks, then the content continues to shrink along with the navigation bar.)

The latest patch in https://bugzilla.mozilla.org/show_bug.cgi?id=786674 will, among other things, fix this issue as well.


Suggested Feature: Disable Ambiguous Date Times as Config Option

We've been bitten a couple times using Timex when we've been returned an Ambiguous DateTime rather than a regular one.
It leads to some hard to track down issues.
For example we have the following:
defmodule TimezoneHelper do
  def regional_time_zone("au"), do: "Australia/Brisbane"
  def regional_time_zone("nz"), do: "Pacific/Auckland"
  def regional_time_zone("uk"), do: "Etc/UTC"
  def regional_time_zone("ie"), do: "Europe/Dublin"
  def regional_time_zone("us"), do: "US/Central"
  def regional_time_zone(_), do: "Etc/UTC"

  def to_local_date(utc_date, region) do
    utc_date
    |> Timex.Timezone.convert(regional_time_zone(region))
    |> Timex.to_date
  end
end

It took us a while, but digging through the docs it seems that Timex.Timezone.convert can return an ambiguous date time, but to_date cannot accept one.
What makes it harder is that to_date returns either a datetime or an error tuple. So you can't really pattern match to make sure the conversion is ok i.e {:ok, value} = Timex.to_date(datetime)
The error from to_date isn't super helpful as it just says {:error, :invalid_datetime}.
Because we don't really care about the ambiguity we've implemented a function:
  def disambiguate(time = %Timex.AmbiguousDateTime{}), do: time.after
  def disambiguate(time = %DateTime{}), do: time

That being said, tracking down these bugs, piping through this function, it all gets a bit messy and time consuming.
Would there be any interest in Timex having an application config var that replicated the functionality of the disambiguate function above, so that you never got caught out?
Figured I'd ask first before embarking on such an undertaking and finding out it doesn't really align with what you're trying to do here?

That being said, would something like this be more ammenable (would extended this out to call conversion functions)
https://github.com/bitwalker/timex/compare/master...hackling:ambiguity-errors?expand=1

I would be open to introducing a config option to automatically resolve ambiguity using one side or the other, but the default should be to force the user to deal with ambiguity as you have done in your codebase. Can you open a PR?

I'd be happy to take that work on. Any suggestions how you'd like this to work? Maybe something like
config :timex, handle_ambiguous: :before | :after | :nothing # defaulting to :nothing

I couldn't came up with a better naming. What do you think?


Possible Mixing Text and Geometry when rewriting GeoSPARQL functions

Description
Ontop may generate illegal SQL queries when rewriting GeoSPARQL functions.
Steps to Reproduce
The following SPARQL query fails on https://sparql.opendatahub.bz.it/
PREFIX uom: <http://www.opengis.net/def/uom/OGC/1.0/>
PREFIX : <http://noi.example.org/ontology/odh#>
PREFIX geo: <http://www.opengis.net/ont/geosparql#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX geof: <http://www.opengis.net/def/function/geosparql/>

SELECT ?x ?wkt ?wktColor ?wktLabel {
    ?m a :Municipality .  ?m rdfs:label ?mWktLabel .
    ?m geo:defaultGeometry/geo:asWKT ?mWkt .
  	FILTER(?mWktLabel = 'Bolzano'@it)
    BIND(geof:buffer(?mWkt, 1000, uom:metre) AS ?bWkt)
    BIND('red' AS ?wktColor)
    ?s a :MeteoStation . ?s geo:defaultGeometry/geo:asWKT ?wkt .
#    #spatial join
    FILTER(geof:sfIntersects(?wkt, ?bWkt))
}

Error:
it.unibz.inf.ontop.exception.OntopQueryEvaluationException: org.postgresql.util.PSQLException: ERROR: function st_intersects(geometry, text) is not unique
  Hint: Could not choose a best candidate function. You might need to add explicit type casts.
  Position: 109

Expected SQL:
SELECT ST_ASTEXT(v2."pointprojection") AS "v0"
    FROM "odp_municipalities" v1, "intimev2"."station" v2
    WHERE (ST_INTERSECTS(v2."pointprojection",
        ST_BUFFER(CAST(v1."geom_4326" AS GEOGRAPHY),1000))
               AND v1."geom_4326" IS NOT NULL AND v2."pointprojection" IS NOT NULL
               AND v1."istat_code" IS NOT NULL AND 'Bolzano' = v1."name_i" AND 'MeteoStation' = v2."stationtype");

Generated SQL:
SELECT ST_ASTEXT(v2."pointprojection") AS "v0"
        FROM "odp_municipalities" v1, "intimev2"."station" v2
         WHERE (ST_INTERSECTS(v2."pointprojection", CAST(ST_ASTEXT(ST_BUFFER(CAST(ST_ASTEXT(v1."geom_4326") AS GEOGRAPHY),'1000')) AS TEXT))
         AND v1."geom_4326" IS NOT NULL AND v2."pointprojection" IS NOT NULL AND v1."istat_code" IS NOT NULL
         AND 'Bolzano' = v1."name_i" AND 'MeteoStation' = v2."stationtype")

This cast in CAST(ST_ASTEXT(ST_BUFFER(CAST(ST_ASTEXT(v1."geom_4326") AS GEOGRAPHY),'1000')) AS TEXT) is causing the problem because the first argument of ST_INTERSECTS is geometry and this one is text. PostGIS complains.
Reproduces how often:
Always
Versions
Ontop 4.1.0 and the latest branch releasing/v4.1
Additional Information
We can use the code from https://github.com/ontopic-vkg/odh-vkg to reproduce the problem locally. However, we should also create a minimal example to replicate this issue in the codebase.

Hello, I believe this issue is still present in v4.2.1, I'm using geof:ehCovers and got the following exception
it.unibz.inf.ontop.exception.OntopQueryEvaluationException: org.postgresql.util.PSQLException: ERROR: function st_covers(text, geometry) is not unique
Hint: Could not choose a best candidate function. You might need to add explicit type casts.
Position: 1337


Add branch_inversion optimization.

This change is

crates/cairo-lang-starknet/test_data/hello_starknet.sierra line 181 at r1 (raw file):

enum_init<core::bool, 1>([25]) -> ([26]);
store_temp<core::bool>([26]) -> ([24]);
enum_match<core::bool>([24]) { fallthrough([27]) 49([28]) };

need to check why there is no match_optimization here.
Code quote:
enum_init<core::bool, 1>([25]) -> ([26]);
store_temp<core::bool>([26]) -> ([24]);
enum_match<core::bool>([24]) { fallthrough([27]) 49([28]) };

tests/test_data/testing.sierra line 15 at r3 (raw file):

struct_construct<Unit>() -> ([0]);
struct_construct<Tuple<Unit>>([0]) -> ([1]);

This test is almost entirely optimized out now
https://github.com/starkware-libs/cairo/blob/62d94330d6dd06c210499e931fc0a9e964b8633a/examples/testing.cairo#L4
Code quote:
struct_construct<Tuple<Unit>>([0]) -> ([1]);

crates/cairo-lang-lowering/src/test.rs line 143 at r1 (raw file):
Previously, orizi wrote…
print new phase

Done.


SysVnVPlan FT1-TC3 issue #8

@PeaWagon
In “Test Input Geometry” It should be considered geometry values as you think purposefully bad or invalid. The example is not sufficient and you should specify a set of inputs as well as the output which is expected regarding to the given input.

@PeaWagon, I agree with the feedback from @vajihehm - your test case should be more specific.  If the Basic Set Exchange is a good resource, you should say specifically what you are going to use from it.

@smiths Sure. Edited.

Thank you @vajihehm.


ARROW-8674: [JS] Implement IPC RecordBatch body buffer compression

Haven't quite gotten this to work yet, attempting with a sample IPC file from PyArrow, but putting up for visibility.

Hey @kylebarron, super nice work on this PR so far!
We are very interested in getting this support into Arrow JS.
Do you plan on continuing this in the next weeks?
If you're busy with other things, can you briefly elaborate on what's left to do in your opinion such that we may consider moving it forward from our side.
Thanks!

Do you plan on continuing this in the next weeks?

No I have no imminent plans to work on this, but I'd love to see support for this added.

what's left to do in your opinion

I never got this actually working at runtime; you probably need to consult the IPC spec closer to see if I'm decompressing the wrong byte range, as suggested in the comment above.
I don't have any specific suggestions on this because I haven't looked at it lately.

The codec API probably needs to have some consensus on what that should look like.


Resolve a couple of Github Action CI annoyances:

High Level Overview of Change
This PR fixes a couple of small issues that have been irking me about our Github Actions CI workflows.

By default, if one job in a workflow fails, other running jobs in that workflow will be aborted, even if the other jobs are working fine and are almost done. This leads to wasted time and resources if the failure is, for example, OS specific, or due to a flaky unit test, and the failed job needs to be re-run, because all the jobs end up re-running.

Fixed by setting fail-fast: false so that multiple jobs in one workflow can finish independently.

I get an email from Github with an error "Run failed: .github/workflows/windows.yml" on every single commit I make (two, if it's on a PR branch). This is because it considers this workflow malformed, because there is no valid on: clause. Example

Fixed by adding conditions back into the windows.yml job, which are not going to easily run, but which renders the file valid. (The workflow can be run manually, or for a branch named "action" that changes the windows.yml file.)

Note that I expect all the CI jobs to fail on this PR because of a dependency issue, addressed in #4407. When they do, note that both of the nix jobs do fail independently. Just to confirm that I didn't break anything, here is a successful job resulting from merging the #4407 fix.
Type of Change

[X ] Tests (You added tests for code that already exists, or your new feature included in this PR)

Looks good. Thanks.

Merging into develop because this doesn't touch any C++ code (other PRs may be held in Passed state because we have a feature freeze on 1.10, so will avoid merging into develop until 1.10 stable is tagged)


Allow API custom domain name to be token

Following is the example from the v1 documentation:
new Api(stack, "Api", {
  customDomain: {
    isExternalDomain: true,
    domainName: "api.domain.com",
    cdk: {
      certificate: Certificate.fromCertificateArn(this, "MyCert", certArn),
    },
  },
});

I would like to populate the custom domain name from a stack import value or any CDK Token.  However, when I pass the token value, I am getting this error.
Error: The domain name needs to be in lowercase

Expected:
I would like to populate domainName value using cloudformation output from another stack.
domainName: Fn.importValue(`${scope.stage}-custom-domain-WildcardCertificateArn`);

Hey @adikari, this is fixed in 1.2.20.


RenderObject/Box doesn't have any lifecycle methods for when it's no longer valid (ie. its associated widget has been disposed)

I'm possibly wrong about this, but I couldn't find it.
What I'm trying to do in this case is "clean up" once the RenderBox/Object is no longer in use.

The lifecycle for render objects is a bit different from widgets.  The relevant methods are attach() and detach().  attach() is called when you enter the tree (you must call super).  detach() is called when you leave the tree (you must call super).  There is no terminal state.  If you're detached, it's always possible for you to be attached again.  That's unlike State objects for widgets which are terminal after dispose().

ty, that worked perfectly.


Not working on 03DS

Sometimes crashes on streetpass list, then when i get to start race and press "OK" it just goes to a white screen, then crashes and goes to home menu.

(this is on eur O3DS)

Same as https://github.com/zoogie/Kartminer7/issues/1 (EUR crashing)
Continue there.


set up multiboot information structure

[ ] if the os image requests it
https://github.com/fubarnetes/bhyve-multiboot/blob/ff5a9bc1d89cc3aa9af451e114fe1ad7457e787d/userboot.h#L186-L190

[ ] set mbi->mem_lower and mbi->mem_upper and set bit 0 of mbi->flags.
[ ] generate a memory map buffer as described in the multiboot spec, point mbi->mmap_addr to it, set mbi->mmap_length, and set bit 6 of mbi->flags.

[ ] make sure bit 1 of mbi->flags is cleared, as specified:

If bit 1 in the ‘flags’ word is set, then the ‘boot_device’ field is valid, and indicates which bios disk device the boot loader loaded the OS image from.  If the OS image was not loaded from a bios disk, then this field must not be present (bit 3 must be clear).

[ ] if cmdline is given, copy it into the hypervisor, and set mbi->cmdline and set bit 2 of mbi->flags.
[ ] if modules are given, parse their command-line specification and load them:

[ ] copy them into the guest, page-align them if requested by the kernel.
[ ] set up an array of module structures, point mbi->mods_addr to it and set mbi->mods_count

[ ] set bit 9 of mbi->flags. copy the bootloader name into the guest and point mbi->boot_loader_name to it.
[ ] if the kernel requests it, set up video modes - although it isn't clear what this means for headless systems.

For the bhyve memory map, see grub2-bhyve's implementation:
  /*
   * bhyve is going to return the following memory segments
   *
   * 0 - 640K    - usable
   * 640K- 1MB   - vga hole, BIOS, not usable.
   * 1MB - lomem - usable
   * lomem - 4G  - not usable
   * 4G - himem  - usable [optional if himem != 0]
   */
  bhyve_info.nsegs = 2;
  bhyve_info.segs = bhyve_mm;

  bhyve_mm[0].start = 0x0;
  bhyve_mm[0].end = 640*1024;		/* 640K */
  bhyve_mm[0].type = GRUB_MEMORY_AVAILABLE;

  bhyve_mm[1].start = 1024*1024;
  bhyve_mm[1].end = (memsz > lomemsz) ? lomemsz : memsz;
  bhyve_mm[1].type = GRUB_MEMORY_AVAILABLE;

  if (memsz > lomemsz) {
    bhyve_info.nsegs++;
    bhyve_mm[2].start = 4*GB;
    bhyve_mm[2].end = (memsz - lomemsz) + bhyve_mm[2].start;
    bhyve_mm[2].type = GRUB_MEMORY_AVAILABLE;
  }

Seeing as qemu doesn't support vbe either, I think we can break with the spec here and just error out:
From qemu's hw/i386/multiboot.c:
if (flags & 0x00000004) { /* MULTIBOOT_HEADER_HAS_VBE */
    fprintf(stderr, "qemu: multiboot knows VBE. we don't.\n");
}


sim: fix input handling and add simulated buttons support from mouse

Summary
This PR fixes handling of input on simulator, to correctly indicate which button was pressed (affects touchscreen input). Also, a simulated button device is added from left mouse-click.
NOTE: this will fail style check due to X11 mixed-case variables
Impact
sim input
Testing
Tested touchscreen input and button input in sim

@v01d nxstyle errors
error: Mixed case identifier found

@jerpelea These errors are all fine. Those are X11 variable names we have no control over.

@btashton thanks


error

the loadEvent.js says evt.bind isnt a function and the code wont work, i thought it might be cuz of using 2 repos for same bot but i tried with a brand new bot it didnt work either, i reforked did everything no work

the loadEvent.js says evt.bind isnt a function and the code wont work, i thought it might be cuz of using 2 repos for same bot but i tried with a brand new bot it didnt work either, i reforked did everything no work

what command have error, when use?
on me start bot not say anything error!

As I said earlier, it is issue on your side, when u reforked, how did it work? And later on stopped working. Please be sure u refork and don't edit code by any means. Even if u add just a bracket, the code will stop working

i didnt do anything


error messages for multiple Jira instances incorrect

We say you need an enterprise license when in reality you need an E20 license, this should be properly reflected in the error to not confuse customers on E10 or E0/TE.
https://github.com/mattermost/mattermost-plugin-jira/blob/c5d366c8243ccd7d926dfd5e097ac78602641fcd/server/command.go#L790
https://github.com/mattermost/mattermost-plugin-jira/blob/0c04ea41daf62fcfb6682644ea5927370fc7ebe5/server/instances.go#L136

Hi @svelle,  can I go ahead and fix this?

Hi @svelle, can I go ahead and fix this?

sure go ahead. Looks like no one has so far started work on this :)


Ux improvement

Hi, here is a couple of UX improvements I use with your extension.
The improvements are :

MultiSelect form fields (I use the bootstrap-select component : https://github.com/silviomoreto/bootstrap-select writen by silviomoreto )
AuthItem names appear in grid view in addition to the description
AuthItem description appear in assignement grid view
User filter in AuthAssignement grid view (based on User->username)
Column filter in AuthItem view (I use the table-filter js https://github.com/hail2u/jquery.table-filter writen by hail2u )

Closing the PR, feel free to reuse the code if you want.


Add "of" between "One" and "my" of the opening sentence in the tenth point of the article

In the beginning of the  the tenth point of the article, There should be "of" between "One" and "my favourite" to make the beginning of the sentence grammatically correct.

[x ] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[x ] None of my changes are plagiarized from another source without proper attribution.
[x ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

In the beginning of the  the tenth point of the article, There should be "of" between "One" and "my favourite" to make the beginning of the sentence grammatically correct.


Add files via upload

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[ ] Filename in the lowercase format
[ ] Image format: png
[ ] Image size: 256 by 256 px

0x6b193e107a773967bd8218f3548cfa2503 image must have length 42 instead have 36

I followed the requirements

Can you show what contract are you trying to add on etherscan.io ?

0x6b193e107a773967bd821bcf8218f3548cfa2503
On Sun, Nov 4, 2018, 6:43 AM Mykola<EMAIL_ADDRESS>wrote:

Can you show what contract are you trying to add on etherscan.io ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TrustWallet/tokens/pull/711#issuecomment-435643984,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqqcASJV3kvyWYR9_mg3yxgVV_lMfXVvks5urn6PgaJpZM4YNCDt
.

Do you have an image for 0x6b193e107a773967bd821bcf8218f3548cfa2503 ?

Ok, correct address is this https://etherscan.io/address/0x6b193e107a773967bd821bcf8218f3548cfa2503 i added here https://github.com/TrustWallet/tokens/commit/c8358de4f59c548d46129138fca8fb99db1ad45a
You named wrong, i'm curious where did you copy the address from ?

Am a team member of posscion
I copied the address wrongly before.
Pls as it been done.
On Sun, Nov 4, 2018, 7:50 AM Mykola<EMAIL_ADDRESS>wrote:

Ok, correct address is this
https://etherscan.io/address/0x6b193e107a773967bd821bcf8218f3548cfa2503 i
added here c8358de
https://github.com/TrustWallet/tokens/commit/c8358de4f59c548d46129138fca8fb99db1ad45a
You named wrong, i'm curious where did you copy the address from ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TrustWallet/tokens/pull/711#issuecomment-435646607,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqqcAbXaqMyKqNuVZ598jysgx5EExFVBks5uro4mgaJpZM4YNCDt
.


Error with download_models.py

Hello, thanks for your work.
I have issued this error while running python download_models.py , can you help with that?

Hi @amira-essawy, I can't reproduce your error. Would you mind removing your venv directory (falco-venv if you followed the installation guidelines in README.md) and install again the venv following the instructions? It should work.


Support Javascript template literals for string scope

These nodes have the type template_string.

Ooh that's cool you mean like foo ${hello} to select the ${hello}?
(Btw not sure how to get GitHub to let me put those back ticks in a code block 🤔)

No actually, things like "take string blue air" don't work on template literals at the moment.
Having a scope for the interpolations is a cool idea though!

Ah right gotcha


Watchdog terminates the driver when debugging longer than 10s

Added async. thread operations (incl. a queue system to the bridge) to prevent timeouts

@DarkNebula0 can you please rebase this? Otherwise it will be closed as stale, it's been almost a year and no interest.

This would be useful for debugging the server, as SteamVR (the whole thing!) crashes if paused for 10 seconds and makes debugging with stop points stressful


Fix About page link to Home

In the About page Home link doesn’t work and get 404 Not Found:

Thanks for your PR, but when merging I notice more conflict, so I revert the merge and just add this:
https://github.com/P0WEX/Gesko/blob/ef1a65ffffe11293dcb740c15a29c1e5b87e8030/_layouts/about.html#L8
Thanks so much for pointing that out !


License?

I found a nice teddit config in this repo, but I'm not sure if I can use it. Could you add a license to the repo?
Thank you very much!

This commit adds an MIT license: https://github.com/heywoodlh/nixos-configs/commit/4fcaef49f6fdbfc142d8894bfbb1c9dab5d02b03
Go crazy (and thanks for your efforts in being respectful of open source) :smile:


FEATURE | set default branch to main

Describe the Feature
Recently, the main GIT Repo providers, such Gitlab or Github, switched to use main as default branch.
It is a good idea binbash Leverage to use such a name for the default branch when creating the project.
Expected Behavior
Use the new standards when creating a git repo.

For the moment this is just a nice to have. We'll prioritize other issues 1st.


Can DependencyCollector and Web packages be used independently without App Insights instance?

Hi I'm trying to collect ASPNET Core requests and dependency calls with Microsoft.ApplicationInsights.Web and Microsoft.ApplicationInsights.DependencyCollector packages, then log to an endpoint (STDOUT/flat file/other servers) other than App Insights. I wonder if it is achievable?

Hi @kenans
Our SDK has the concept of a TelemetryChannel which handles serialization and sending to an endpoint.
You can implement your own ITelemetryChannel that meets your needs.
Also, be aware that the Microsoft.ApplicationInsights.Web package is meant for Asp.Net.
If you're using Asp.Net Core, you should use Microsoft.ApplicationInsights.AspNetCore.
You can find some guides on this repo's Readme: https://github.com/microsoft/ApplicationInsights-dotnet
Lastly, if you're looking for a truly vendor-agnostic solution you may consider Open Telemetry: https://github.com/open-telemetry/opentelemetry-dotnet


Build roles

As per #18 organize members in Contributors, Backers, Friends (free membership)

redundant -->  #18