Expose concurrency flag of envoy

This is to address the following github issue: https://github.com/istio/istio/issues/3031

Hi @mcieplak. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

@mcieplak  Thanks for your PR! Can you please sign the CLA?

@mcieplak: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
2b7300a3e799fb7b70ef8ad6e8fcbac62e4e492b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andraxylia No problem! I just signed the CLA now. This PR is also dependent on https://github.com/istio/api/pull/341 being merged. I will send another PR to handle the kube-inject side as well.

Test fail because the corresponding istio/api change has not been merged yet.

Please update the istio/api sha to 8d86ca75131ca50e7776480a1db1b0a5abfb3e67 in the dependency file here and then to /restest
https://github.com/istio/istio/blob/master/Gopkg.lock#L1058

/ok-to-test

@mcieplak: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
5e4873165a37389ff6fb2a43399c11ba31ec838b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andraxylia I believe the changes in https://github.com/istio/api/pull/334 are affecting the build here when I update the version of the api. The broker/v1 path has been changed to broker/dev. The previous version of api inside of this repo does not have these changes included.

I asked @xiaolanz to fix istio/istio.

@mcieplak: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
6ce975ec826ae0640f00633032b229a517fef95e
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I would suggest removing the constraint (leaving api at master) once current breakages are fixed - to detect further breakages. We have a job that verifies dep can be updated.

The broker problem has been fixed, so it should be fine to use the new api version.

@andraxylia Thank you for the updates!
@costinm I have updated the PR to only add the concurrency flag if it's specified. Please review.

@mcieplak: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
dcee659cbd8e6c2c4ca8cec280fd0008234ec87b
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andraxylia The build is now passing. Can you please review?

@mcieplak: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
0cdd14b1cb80ce8fabe64cd40bc4b96604e9fbe2
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

@mcieplak: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
0cdd14b1cb80ce8fabe64cd40bc4b96604e9fbe2
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@mcieplak: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
fd5f77fa017b16976ddb9d22a3878e289e5a155b
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mcieplak: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
fd5f77fa017b16976ddb9d22a3878e289e5a155b
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
54705ec6e610d9054c0fb87dcee0a5525dcbc1c5
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@mcieplak: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
54705ec6e610d9054c0fb87dcee0a5525dcbc1c5
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
54705ec6e610d9054c0fb87dcee0a5525dcbc1c5
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

e2e-smoke failure caused by #3139

@costinm tests are passing, please check the code changes, remove the hold label and merge if everything is fine.

@andraxylia I believe the e2e-pilot ci/circleci test is also failing because of https://github.com/istio/istio/issues/3139.

@mcieplak: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
54705ec6e610d9054c0fb87dcee0a5525dcbc1c5
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
e2f5677f1f1a6769354f69a37f90eb27f2f1e9dc
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mcieplak: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
e2f5677f1f1a6769354f69a37f90eb27f2f1e9dc
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
e2f5677f1f1a6769354f69a37f90eb27f2f1e9dc
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mcieplak: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
e2f5677f1f1a6769354f69a37f90eb27f2f1e9dc
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
e2f5677f1f1a6769354f69a37f90eb27f2f1e9dc
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
2631f623dca51d33e7ba7e27e7de4c6395825836
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@mcieplak: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
2631f623dca51d33e7ba7e27e7de4c6395825836
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andraxylia @costinm Thank you for the reviews! Can we please merge?

/test istio-unit-tests

@mcieplak: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2631f623dca51d33e7ba7e27e7de4c6395825836
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

@mcieplak: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2631f623dca51d33e7ba7e27e7de4c6395825836
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e


Amend tests and syntax

In this PR I have

correct some syntax and tests

@sagieramos

Hi @AbuTalha3,
Your task is approved.
Your task is complete!  You did a great job working on it :clap:. You can go ahead and merge it :shipit:
Congratulations! 🎉 Keep up your great work :100:
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


SVG path editing tools

basics like this would be great https://iconsvg.xyz

here's a fun one to take some nice UX from https://codepen.io/thebabydino/pen/EKLNvZ

or this one https://github.com/winkerVSbecks/xvg


【bug】can not load cambrian-34b

in load_pretrained_model
model = CambrianLlamaForCausalLM.from_pretrained(
File "/usr/local/lib/python3.10/dist-packages/transformers/modeling_utils.py", line 3531, in from_pretrained
) = cls._load_pretrained_model(
File "/usr/local/lib/python3.10/dist-packages/transformers/modeling_utils.py", line 3958, in _load_pretrained_model
new_error_msgs, offload_index, state_dict_index = _load_state_dict_into_meta_model(
File "/usr/local/lib/python3.10/dist-packages/transformers/modeling_utils.py", line 812, in _load_state_dict_into_meta_model
set_module_tensor_to_device(model, param_name, param_device, **set_module_kwargs)
File "/usr/local/lib/python3.10/dist-packages/accelerate/utils/modeling.py", line 348, in set_module_tensor_to_device
raise ValueError(
ValueError: Trying to set a tensor of shape torch.Size([1024, 1152]) in "weight" (which has shape torch.Size([1024, 1024])), this look incorrect.

Hi, could you please provide more information about your case (e.g. the device_map for loading and the number of GPUs you are  using). Also, can you try to load the 8/13b model to see whether the same problem happens?

transformers in my env is 4.39  , why must transformers==4.37.0 in dependencies ?

all dependencies is "== " ， I wonder if ">" is OK？

Our training and evaluation are mainly conducted with the specified versions and haven't been extensively tested with higher versions to ensure correctness. But I have tested to run the 34B model with transformers==4.39.0 and it works fine. Could you provide the information about device_map for loading and the number of GPUs you are using? Also, what is the version of your accelerate?

Our training and evaluation are mainly conducted with the specified versions and haven't been extensively tested with higher versions to ensure correctness. But I have tested to run the 34B model with transformers==4.39.0 and it works fine. Could you provide the information about device_map for loading and the number of GPUs you are using? Also, what is the version of your accelerate?

A100*8

Loading checkpoint shards:  94%|███████████████████████████████████████████████████████████████████████████████████████████████████▍      | 30/32 [00:19<00:01,  1.57it/s]
Traceback (most recent call last):
model = CambrianLlamaForCausalLM.from_pretrained(
File "/opt/conda/lib/python3.10/site-packages/transformers/modeling_utils.py", line 3852, in from_pretrained
) = cls._load_pretrained_model(
File "/opt/conda/lib/python3.10/site-packages/transformers/modeling_utils.py", line 4286, in _load_pretrained_model
new_error_msgs, offload_index, state_dict_index = _load_state_dict_into_meta_model(
File "/opt/conda/lib/python3.10/site-packages/transformers/modeling_utils.py", line 807, in _load_state_dict_into_meta_model
set_module_tensor_to_device(model, param_name, param_device, **set_module_kwargs)
File "/opt/conda/lib/python3.10/site-packages/accelerate/utils/modeling.py", line 285, in set_module_tensor_to_device
raise ValueError(
ValueError: Trying to set a tensor of shape torch.Size([1024, 1152]) in "weight" (which has shape torch.Size([1024, 1024])), this look incorrect.

when i add some log , is loding "model.mm_projector_aux_0.0.weight"
@penghao-wu

Is it because I only kept the second one in mm_vision_tower_aux_list?

Is it because I only kept the second one in mm_vision_tower_aux_list?

What do you mean by this? You don't need to modify the config if you want to load our trained model.

Is it because I only kept the second one in mm_vision_tower_aux_list?

What do you mean by this? You don't need to modify the config if you want to load our trained model.

because i can only load local path model，Can you list the huggingface download addresses for these four vision models?
"mm_vision_tower_aux_list": [
"siglip/CLIP-ViT-SO400M-14-384",
"openai/clip-vit-large-patch14-336",
"facebook/dinov2-giant-res378",
"clip-convnext-XXL-multi-stage"
],

For example, CLIP-ViT-SO400M-14-384 seems to have many versions, and I can't search clip-conv-xxL-multi-stage in huggfing face

CLIP-ViT-SO400M-14-384 should be hf-hub:timm/ViT-SO400M-14-SigLIP-384 and clip-conv-xxL-multi-stage should be hf-hub:laion/CLIP-convnext_xxlarge-laion2B-s34B-b82K-augreg-soup . If you use local path, you might need to look into the loading code for each of the vision encoders in the cambrian/model/multimodal_encoder folder to ensure the correctness.

Hi, how can I set 2 48G gpus?
2024-06-30 15:21:12 PID=57 init.py:49 setup_logging() INFO → 'standard' logger initialized.
2024-06-30 15:21:13 PID=57 model_worker.py:274 () INFO → args: Namespace(host='<IP_ADDRESS>', port=40000, worker_address='http://localhost:40000', controller_address='http://localhost:10000', model_path='/mnt/cpn-pod/models/nyu-visionx/cambrian-34b', model_base=None, model_name=None, device='cuda', multi_modal=False, limit_model_concurrency=5, stream_interval=1, no_register=False, load_8bit=False, load_4bit=False)
2024-06-30 15:21:13 PID=57 model_worker.py:66 init() INFO → Loading the model cambrian-34b on worker b48646 ...
2024-06-30 15:21:13 PID=57 builder.py:119 load_pretrained_model() INFO → Loading Cambrian from /mnt/cpn-pod/models/nyu-visionx/cambrian-34b
Traceback (most recent call last):
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/root/cambrian/cambrian/serve/model_worker.py", line 279, in
worker = ModelWorker(args.controller_address,
File "/root/cambrian/cambrian/serve/model_worker.py", line 67, in init
self.tokenizer, self.model, self.image_processor, self.context_len = load_pretrained_model(
File "/root/cambrian/cambrian/model/builder.py", line 120, in load_pretrained_model
tokenizer = AutoTokenizer.from_pretrained(model_path, use_fast=False)
File "/usr/local/lib/python3.10/dist-packages/transformers/models/auto/tokenization_auto.py", line 814, in from_pretrained
return tokenizer_class.from_pretrained(pretrained_model_name_or_path, *inputs, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/tokenization_utils_base.py", line 2029, in from_pretrained
return cls._from_pretrained(
File "/usr/local/lib/python3.10/dist-packages/transformers/tokenization_utils_base.py", line 2261, in _from_pretrained
tokenizer = cls(*init_inputs, **init_kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/models/llama/tokenization_llama.py", line 178, in init
self.sp_model = self.get_spm_processor(kwargs.pop("from_slow", False))
File "/usr/local/lib/python3.10/dist-packages/transformers/models/llama/tokenization_llama.py", line 203, in get_spm_processor
tokenizer.Load(self.vocab_file)
File "/usr/local/lib/python3.10/dist-packages/sentencepiece/init.py", line 905, in Load
return self.LoadFromFile(model_file)
File "/usr/local/lib/python3.10/dist-packages/sentencepiece/init.py", line 310, in LoadFromFile
return _sentencepiece.SentencePieceProcessor_LoadFromFile(self, arg)
TypeError: not a string

return _sentencepiece.SentencePieceProcessor_LoadFromFile(self, arg)
TypeError: not a string

This error seems not related to multiple GPUs. Make sure that all model files are downloaded correctly (e.g. tokenizer.model)

@dionren Some of the vision encoders are not from transformers and do not support device_map, so there are some problems setting device_map=auto using multiple GPUs. And we are still working to convert the vision encoders to support this.
But I have a workaround for your case with 2 48G gpus. This includes the following modifications:

Modify the beginning of cambrian/model/builder.py

from accelerate import infer_auto_device_map, dispatch_model

def load_pretrained_model(model_path, model_base, model_name, load_8bit=False, load_4bit=False, device_map="auto", device="cuda", **kwargs):
    device_map='sequential'
    kwargs = {"device_map": device_map, "max_memory":{0: "30GIB", 1: "49GIB"}, **kwargs}

Change https://github.com/cambrian-mllm/cambrian/blob/9d382223ba3e0ab9f99bad4f45c0fd4a21749dc6/cambrian/model/language_model/cambrian_llama.py#L252 to
cur_latent_query_with_newline = torch.cat([cur_latent_query, cur_newline_embd.to(cur_latent_query.device)], 2).flatten(1,2)

@dionren Some of the vision encoders are not from transformers and do not support device_map, so there are some problems setting device_map=auto using multiple GPUs. And we are still working to convert the vision encoders to support this.
But I have a workaround for your case with 2 48G gpus. This includes the following modifications:

Modify the beginning of cambrian/model/builder.py

from accelerate import infer_auto_device_map, dispatch_model

def load_pretrained_model(model_path, model_base, model_name, load_8bit=False, load_4bit=False, device_map="auto", device="cuda", **kwargs):
    device_map='sequential'
    kwargs = {"device_map": device_map, "max_memory":{0: "30GIB", 1: "49GIB"}, **kwargs}

Change https://github.com/cambrian-mllm/cambrian/blob/9d382223ba3e0ab9f99bad4f45c0fd4a21749dc6/cambrian/model/language_model/cambrian_llama.py#L252
to
cur_latent_query_with_newline = torch.cat([cur_latent_query, cur_newline_embd.to(cur_latent_query.device)], 2).flatten(1,2)

I'm gonna try it out. Thanks a ton for your help and the awesome work you've done. It's truly impressive.

Is it possible to load cambrian-34B on 8 RTX4090?


specify source language in workflow execution request

Issue #, if available:
#288
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I've manually tested the Save Edits functionality in the Subtitles view for the following test cases:

transcribe w/ auto source language detection, translate disabled
transcribe w/ en-US source language, translate disabled
transcribe w/ auto source language detection, translate enabled
transcribe w/ en-US source language, translate enabled
transcribe w/ en-US source language and a custom vocabulary, translate disabled
transcribe w/ en-US source language and a custom vocabulary, translate enabled with a custom terminology

Skipping code review since these are relatively minor changes to the front-end.


Issue with Application ID

Hi,
Recently I am starting to face an issue where I cannot connect to any tenants.
I get following error:
"Application with identifier 'd1ddf0e4-d672-4dae-b554-9d5bdfd93547' was not found in the directory"
It seems to be related to the identifier being deprecated, reading following article:
https://learn.microsoft.com/en-us/answers/questions/1659638/weve-detected-a-microsoft-intune-powershell-script

Also interested in this update as we can no longer use the tool.

Same issue here great tool, but currently broken....... :-(

Yeah they changed something a few weeks ago that broke this.  Just needs to be repackaged.  Would love to have this back.  Saves me so much time.

Hi guys. Not had time yet to work on that. Very busy :/

Any update on this? If there is a work around to get it to connect to the Tenant please let me know.

Sorry, no update right now. I need to take time to work on that, but not really my priority at the moment :/

Sorry, no update right now. I need to take time to work on that, but not really my priority at the moment :/

@Romanitho I created a PR to support Microsofts Change :)

Anyupdate on this?

Anyupdate on this?
@stuman333

Its fixed :) See #30  for Documentation on how to set it up. Just download the new PowerShell Script in the Sources Folder and fill out the Text Boxes.
Romanitho didn't make a Release yet, but downloading it from the Repo itself should work i think

As I get it right it is not working at the moment?
I still can't connect. I get a login screen but it just closes.
I created the app and gave the right privs and the correct redirect url.
I think in the readme should be noted that you need to make this app registration in Azure.


fix: corrections mineures

Voir les commits. Des correctifs mineures + styles

:tada: This PR is included in version 3.29.0 :tada:
The release is available on:

GitHub release
v3.29.0

Your semantic-release bot :package::rocket:


bring back removed persistence generator for kogito maven plugin

@evacchi these two where removed by https://github.com/kiegroup/kogito-runtimes/pull/260 which breaks persistence completely for kogito maven plugin.

Looks good now, we can merge this.


chore: Pump llama.cpp version

Issues link: https://github.com/janhq/nitro/issues/473

https://github.com/ggerganov/llama.cpp/pull/5691
Relevant PR upstream


Classpath instrumentation of NIO.2 operations fails for paths in zip archives

Expected Behavior
Using Files.readString API in plugin code when reading non-default file systems should work correctly.
Current Behavior
When some code which runs within Gradle (a custom plugin, in most cases) tries to execute Files.readString without specifying the charset against a Path instance created from a zip file system, this method call will fail due to incorrect instrumentation within Gradle:
java.lang.UnsupportedOperationException
	at jdk.zipfs/jdk.nio.zipfs.ZipPath.toFile(ZipPath.java:674)
	at org.gradle.internal.classpath.Instrumented.filesReadString(Instrumented.java:419)
	at org.gradle.internal.classpath.declarations.NioFileInterceptors.intercept_readString(NioFileInterceptors.java:169)
	...

The reason, as it seems, is that the path is attempted to be converted into a File instance unconditionally: https://github.com/gradle/gradle/blob/709020ab2c636b5af11e9abda03bbc7bc198cef1/subprojects/core/src/main/java/org/gradle/internal/classpath/Instrumented.java#L427
This naturally fails for non-local file system paths.
It might be that some other similarly instrumented operations are affected as well.
Context (optional)
Files.readString and other similar operations are very common in plugins, so it would make sense for it to work without hitches. It seems that this error started to happen relatively recently, probably because Gradle didn't do this kind of instrumentation earlier.
Steps to Reproduce
Any way to execute Files.readString() against a Path inside a zip archive while within the instrumented Gradle classpath should demonstrate the issue. In our case, this method was called from within our internal plugin which uses zip file system to read zip archive contents.
Gradle version
8.1.1
Build scan URL (optional)
No response
Your Environment (optional)
No response

Thank you for providing a valid reproducer.
The issue is in the backlog of the relevant team and is prioritized by them.

Is there any chance of this being fixed sooner? Looking at the code and comparing two adjacent methods:
https://github.com/gradle/gradle/blob/eb27e930e9120bff77261c49818111fcfda2bcdc/subprojects/core/src/main/java/org/gradle/internal/classpath/Instrumented.java#L426-L429
https://github.com/gradle/gradle/blob/eb27e930e9120bff77261c49818111fcfda2bcdc/subprojects/core/src/main/java/org/gradle/internal/classpath/Instrumented.java#L431-L434
it looks like the fix will be a very simple one-liner, since the readString(Path, Charset) instrumented body looks correct.

If you are interested in contributing to Gradle, this issue is actionable and ready for contribution but might be challenging for first-time contributors.
See CONTRIBUTING.md for more information.

Hi @mlopatkin, this is my first PR to Gradle, could you help me assign a reviewer? https://github.com/gradle/gradle/pull/26117


Missing icons

Hi, we need some more icons:

Pundi (XNPXS)
Mixin (XIN)
Huobi Token (HT)
MOAC (MOAC)
Loom Network (LOOM)
Dropil (DROP)
Paypex (PAYX)

Could you please add them to your library?

@VladimirHumeniuk We will need vectorized versions of the logos for those currencies. (SVG or source file, not a bitmap like PNG)

@sindresorhus  i sent request for a vectorized logo to everyone of them via emails. I will give logos to you, if they give me an answers.

@VladimirHumeniuk Can you open separate issues for each coin? That makes it easier for us to track. The issue title should be the coin name and symbol, example: Paypex (PAYX)

@VladimirHumeniuk I saw you opened an issue for Dropil. I went ahead and opened issues for the rest of the coins for you.


Remove the Google XMPP social provider from uProxy

Google's support for XMPP is deprecated, buggy, and unlikely to improve. uProxy has some serious bugs with it's XMPP social provider, like #1529, and it's unclear if it is worthwhile (or even possible) to resolve them. It may not be reasonable for us to declare ourselves a beta product, while users continue to have issues with this social provider, so I'm creating a bug to track it's replacement or removal.

I created a doc listing our options at https://docs.google.com/document/d/1SJqT8a_RT1eRLp78F9a2HMpMN6agHaDm9k0P_X8sFq8/edit#heading=h.p6f3w9gtugp7 - please take a look and comment

Thanks Daniel. This is a great summary of our options! Let's discuss the
current state of XMPP with Lucas, who is its greatest detractor.
On Wed, Jul 29, 2015 at 5:28 PM dborkan<EMAIL_ADDRESS>wrote:

I created a doc listing our options at
https://docs.google.com/document/d/1SJqT8a_RT1eRLp78F9a2HMpMN6agHaDm9k0P_X8sFq8/edit#heading=h.p6f3w9gtugp7

please take a look and comment

—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/1756#issuecomment-126100161.

I discussed this with Greg and Lucas yesterday.  My takeaway is that while nobody likes XMPP, nobody likes the current Google+ social network either, and any brand new implementation of a Google social network is unlikely to be completed within a month (i.e. it would delay our beta launch).
The one hope I think we might have for a Firebase Google social network is if we can use GMail contacts with Firebase instead of Google+ contacts.  I know how to get a list of GMail contacts by email address, however we need a way to map that email address to the Google+ numeric ID, so they can be authenticated with Firebase.  I'll reach out to the GAIA team to see if there is a way to do this available to open source projects.
Otherwise I think our energy is better spent developing new social networks, specifically Firebase email authentication (I'm experimenting with this now, I think we can easily create a Quiver-like UX without any changes needed from Firebase), Quiver, WeChat, GitHub, etc.

Done, new GMail and Facebook social networks are now available on the webstores.


Unable to load Redis extension with PHP 7.4

Describe the bug
Loading redis extension with PHP 7.4 produce the following error message

PHP Warning:  PHP Startup: Unable to load dynamic library 'redis.so' (tried: /usr/lib/php/20190902/redis.so (/usr/lib/php/20190902/redis.so: undefined symbol: igbinary_serialize), /usr/lib/php/20190902/redis.so.so (/usr/lib/php/20190902/redis.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0

To Reproduce
      - name: Install PHP
        uses: shivammathur/setup-php@master
        with:
          php-version: 7.4
          extension-csv: redis

or
      - name: Install PHP
        uses: shivammathur/setup-php@master
        with:
          php-version: 7.4
          extension-csv: redis
          pecl: true

Both will cause the same issue
Expected behavior
Being able to load redis without any problem
Screenshots

Additional context
Add any other context about the problem here.

@linuxjuggler Thanks for reporting.
Fixed in #101, Test workflow
This should work now, on all OS.
- name: Install PHP
  uses: shivammathur/setup-php@v1
  with:
    php-version: 7.4
    extension-csv: redis

Amazing, thanks @shivammathur


Re-add REPL prompt CSS to tutorial

Description
This re-adds the CSS corresponding to the REPL prompt in the tutorial section.
When code is copied, the prompt symbol (» ) doesn't get copied alongside the code, which matches the expected behaviour.
The behaviour has been tested by building the website locally and inspecting the output corresponding to the tutorial page.
References

ZulipChat thread.

Thanks for the thorough investigation and solution @hristog!


NBGL Nano: Check onActionCallback validity

Description
In nbgl_step.c actionCallback, onActionCallback was called without being checked, leading to crash if the callback is NULL. This commit adds the relevant checks.
Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[ ] Other (for changes that might not fit in any category)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.49%. Comparing base (fe9d203) to head (263df08).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #824   +/-   ##
=======================================
  Coverage   35.49%   35.49%
=======================================
  Files          13       13
  Lines        1606     1606
=======================================
  Hits          570      570
  Misses       1036     1036

Flag
Coverage Δ

unittests
35.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Using node-horseman in docker/docker-compose

Okay so im working on using horseman as a prerender for my angular app.
And i have this docker-compose file:
where i start the prerender script to listen on localhost:5000, and then in my docker-compose i have my normal app on localhost:8000.
So im trying to hit my frontend(fe) container by hitting:
localhost:5000?url=http://fe:8000 because of the dns, that have been setup in docker
So i want this to hit my frontend container to resolve the page and return it only to bots
const path = require('path');
const phantomjs = require('phantomjs-prebuilt');
const Horseman = require('node-horseman');
const horseman = new Horseman({
	ignoreSSLErrors: true,
        sslProtocol: 'any',
        webSecurity: false,
	phantomPath: path.join(__dirname, 'node_modules/phantomjs-prebuilt/bin/phantomjs')
});
const express = require('express');
const app = express();

// Prep config for app
let UA = 'Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0';

app.get('/', function(req, res) {
	let url = req.query.url;

	if (url === 'undefined' || url === undefined) {
		return res.send('Please send a url :)');
	}

	url = encodeURI(url);

	console.log("url: ", url);

	horseman
		.on('loadStarted', onLoadStart)
		.on('loadFinished', onLoadFinish)
		.on('timeout', onTimeout)
		.on('consoleMessage', onMessage)
		.on('error', onError)
		.userAgent(UA)
		.open(url)
		.html()
		.then(function(html) {
			console.log("Html ready");
			res.send(html);
		})
		.close();
});

app.listen(5000, function() {
	console.log('Example app listening on port 5000!');
});

function onMessage(msg) {
	console.log('onMessage: ', msg);
};

function onError(msg, trace) {
	console.log('onError: ', msg);
	console.log('onError - trace: ', trace);
};

function onTimeout(msg) {
	console.log("onTimeout: ", msg);
}

function onLoadStart() {
	console.log("onLoadStart");
}

function onLoadFinish(msg) {
	console.log("onLoadFinish: ", msg);
}

I don't really know much about docker, but you are using phantomjs-prebuilt in a weird (wrong?) way.
const phantomjs = require('phantomjs-prebuilt');
const Horseman = require('node-horseman');
const horseman = new Horseman({
	ignoreSSLErrors: true,
        sslProtocol: 'any',
        webSecurity: false,
	phantomPath: phantomjs.path // Like this
});

Also, could you post specifically was is wrong and a log of the output when running with DEBUG='horseman*' and BLUEBIRD_DEBUG=1 set?

I use Horseman and Phantom in Docker, not with prebuilt. My Dockerfile:
# PhantomJS
RUN apt-get install -y libfreetype6 libfontconfig wget
RUN wget -q --user-agent="Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:<IP_ADDRESS>) Gecko/20070725 Firefox/<IP_ADDRESS>" https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-x86_64.tar.bz2
RUN tar xjf phantomjs-2.1.1-linux-x86_64.tar.bz2
RUN install -t /usr/local/bin phantomjs-2.1.1-linux-x86_64/bin/phantomjs
RUN rm -rf phantomjs-2.1.1-linux-x86_64 phantomjs-2.1.1-linux-x86_64.tar.bz2

For your end goal though I think its much better to use Angular Universal. If you are not on Angular 2 and app is not super complex then upgrade it. The effort is worth the return.

@robertpallas we have a huge project, and its a project in transition between legacy web, prerender stuff for all users, towards a dynamic ng1 app that only prerenders stuff for the bots.
I will try your setup

@awlayton & @robertpallas i made it work by installing the phantomjs from the bin, something that didn't work with the prebuilt version

What do you mean @sp90? Like you install PhantomJS in the docker instead of using npm to get it?

i installed as @robertpallas said

So then is the answer that phantomjs-prebuilt does not work with Docker for some reason?

@awlayton yes that is correct 👍

Closing since there is no issue in horseman. Perhaps someone should open an issue for phantomjs-prebuilt, if there isn't one already.


2.1-rc3 java.lang.ClassCastException error when inserting the same value 40 times into nonunique index

Create a subclass of V called Player with a STRING property, name, and an INTEGER property, power.
Create a unique index for Player.name.
Create a nonunique index for Player.power.
Attempt to create 100 Player vertices, each one with a unique name (like Player1, Player2, etc.), but make each record with the same power value: 123.

The first 39 vertices will be created successfully, however, any further attempts to create Player records will fail with the following error:
2015-06-10 17:44:32:222 SEVERE Sent run-time exception to the client /<IP ADDRESS>:<CONNECTION ID>: com.orientechnologies.orient.core.exception.OTransactionException: Error on committing distributed transaction [ONetworkProtocolBinary]Error on distributed transaction commit
com.orientechnologies.orient.core.index.OIndexException: Error during insertion of key in index
    at com.orientechnologies.orient.core.index.OIndexMultiValues.put(OIndexMultiValues.java:141)
    at com.orientechnologies.orient.core.index.OIndexMultiValues.put(OIndexMultiValues.java:52)
    at com.orientechnologies.orient.core.index.OIndexAbstract.putInSnapshot(OIndexAbstract.java:870)
    at com.orientechnologies.orient.core.index.OIndexAbstract.applyIndexTxEntry(OIndexAbstract.java:1050)
    at com.orientechnologies.orient.core.index.OIndexAbstract.addTxOperation(OIndexAbstract.java:684)
    at com.orientechnologies.orient.core.tx.OTransactionOptimistic$CommitIndexesCallback.run(OTransactionOptimistic.java:100)
    at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.commit(OAbstractPaginatedStorage.java:930)
    at com.orientechnologies.orient.server.distributed.ODistributedStorage.commit(ODistributedStorage.java:882)
    at com.orientechnologies.orient.core.tx.OTransactionOptimistic.doCommit(OTransactionOptimistic.java:590)
    at com.orientechnologies.orient.core.tx.OTransactionOptimistic.commit(OTransactionOptimistic.java:149)
    at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.commit(ODatabaseDocumentTx.java:2486)
    at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.commit(ODatabaseDocumentTx.java:2456)
    at com.orientechnologies.orient.server.distributed.task.OTxTask.execute(OTxTask.java:129)
    at com.orientechnologies.orient.server.hazelcast.OHazelcastPlugin.executeOnLocalNode(OHazelcastPlugin.java:776)
    at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.onMessage(ODistributedWorker.java:300)
    at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.run(ODistributedWorker.java:121)
Caused by: java.lang.ClassCastException

NOTE the error is of the type java.lang.ClassCastException - not sure why this only starts to happen after the first 39 records have been created.
NOTE If you give the Player records unique power values, you will not encounter this error.
NOTE If you drop the Player.power index, you will be able to create as many Player vertices as you wish, as long as they have unique names, of course.

i wrote a relative test case but i was not able to reproduce it, can you give more details? are you sure that your classPath is clean? often ClassCastException come out because of dirty classpath
here is my test case:
  @Test
  public void testInsert40Entries() {
    OrientGraph db = new OrientGraph("memory:" + OCompositeIndexMultipleEntryTest.class.getSimpleName(), false);
    try {
      OrientVertexType type = db.createVertexType("Player");
      OProperty propName = type.createProperty("name", OType.STRING);
      propName.createIndex(INDEX_TYPE.UNIQUE);
      OProperty propPower = type.createProperty("power", OType.INTEGER);
      propPower.createIndex(INDEX_TYPE.NOTUNIQUE);
      db.begin();

      for (int i = 0; i < 100; i++) {
        Vertex v = db.addVertex(null);
        v.setProperty("name", "Player" + i);
        v.setProperty("power", 123);
      }
      db.commit();
    } finally {
      db.drop();
    }

  }

This seems an old issue already fixed in 2.1-rc4. Closing it. In case somebody has the same problem with 2.1-rc5 or later, please comment the issue.


Fix attribute set difference

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14586/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14586/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14586/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14586/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14586/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14586/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14586/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14586/merge#BCU1XR#0


removing enum-related tables

Removing enum-related tables from this project (cassandra and elasticsearch) as enums are no longer supported.

Changes Unknown when pulling b1c3ac9cc72469b5691c2f3812d6311a95c48e93 on usnavi:remove_enum_tables into ** on rackerlabs:master**.

@drenalin23 @izrik @shintasmith @ChandraAddala - review pls.


Make #239 ruby-2.2 compatible

#239 fixed some poor error-handling, but did so in a way that's not ruby-2.2 compatible (see pipeline).  Let's expand that .& syntax to be compatible..
cc: @grosser

I think what we should do is:

drop ruby <2.5 they are EOL and anyone using them most likely does not update their DD version anyway
use GA for CI (see https://github.com/DataDog/dogstatsd-ruby/issues/241 for copy-paste example) or at least link circle-ci to the PRs

We do still have folks using older Rubies, but we could plan that deprecation now (the README says we'll add a deprecation message in the previous minor)
I just changed CircleCI to build PRs - you're right on that count.

do folks using older rubies have to use the latest dd-client code though ?
(as in if they never bothered to update their rubies why would they update their dd-client 🤷 )

would still be nice to run this on GA since then the config is visible in the repo and can be changed as part of the PR
(or check in the circle-ci config if that's supported)

https://github.com/DataDog/dogstatsd-ruby/pull/245 for the ruby versions, BTW.

somehow did not see the config, thx!


Prepare release 1.0.0

Prepare release 0.2.0. Once it has been merged, I will upload it to cargo repositories.

Hi, @sigmaSd, could you confirm the changelog file?
Also, if you want, you can suggest the authors line in cargo.toml with your name and email :)

Looks fine to me^^

Also one suggestion, you might make this release 1.0.0,
Termchat already does what it advertises, from now on we're just adding new features.

Also one suggestion, you might want to make this release 1.0.0,
Termchat already does what it advertises, from now on we're just adding new features.
I agree. Updated :).

Will you want to modify the author's line before I merge it? (You can create a suggestion for this change)

Thanks but I prefer not to
But I really appreciate the suggestion!

Ready in cargo repositories :)


elasticsearch cluster with istio sidecar error

Bug Description
when I use elasticsearch cluster without sidecar ，its works；
but when  cluster in sidecar ,the cluster doesnt works anymore;
the yamlfile is :
kind: ConfigMap
apiVersion: v1
metadata:
  name: elasticsearch-cm
  labels:
    app: elasticsearch
data:
  elasticsearch.yml: |
    cluster.name: "gistage-elasticsearch"
    network.host: <IP_ADDRESS>
    http.cors.enabled: true
    http.cors.allow-origin: "*"
    xpack.security.enabled: false

---
apiVersion: apps/v1
kind: StatefulSet
metadata:
  labels:
    app: elasticsearch
  name: elasticsearch
spec:
  podManagementPolicy: Parallel
  replicas: 3
  selector:
    matchLabels:
      app: elasticsearch
  serviceName: elasticsearch-headless
  template:
    metadata:
      labels:
        app: elasticsearch
      name: elasticsearch
    spec:
      affinity:
        podAntiAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
          - labelSelector:
              matchExpressions:
              - key: app
                operator: In
                values:
                - elasticsearch
            topologyKey: kubernetes.io/hostname
      initContainers:
      - name: initsys
        image: xxxxxx/xxxxx/elasticsearch:6.8.22
        imagePullPolicy: IfNotPresent
        command:
          ["sh", "-c", "chown -R 1000:1000 /data && sysctl -w vm.max_map_count=262144 && ulimit -n 65536"]
        securityContext:
          privileged: true
        volumeMounts:
          - name: data
            mountPath: /data
      containers:
      - env:
        - name: node.name
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.name
        - name: discovery.zen.minimum_master_nodes
          value: "2"
        - name: discovery.zen.ping.unicast.hosts
          value: elasticsearch-headless
        - name: cluster.name
          value: gistage-elasticsearch
        - name: network.host
          value: <IP_ADDRESS>
        - name: node.data
          value: "true"
        - name: node.ingest
          value: "true"
        - name: node.master
          value: "true"
        image: xxxxxx/xxxxx/elasticsearch:6.8.22
        imagePullPolicy: IfNotPresent
        name: elasticsearch
        ports:
        - containerPort: 9200
          name: http
          protocol: TCP
        - containerPort: 9300
          name: transport
          protocol: TCP
        readinessProbe:
          exec:
            command:
            - sh
            - -c
            - |
              #!/usr/bin/env bash -e
              # If the node is starting up wait for the cluster to be ready (request params: "wait_for_status=green&timeout=1s" )
              # Once it has started only check that the node itself is responding
              START_FILE=/tmp/.es_start_file

              # Disable nss cache to avoid filling dentry cache when calling curl
              # This is required with Elasticsearch Docker using nss < 3.52
              export NSS_SDB_USE_CACHE=no

              http () {
                local path="${1}"
                local args="${2}"
                set -- -XGET -s

                if [ "$args" != "" ]; then
                  set -- "$@" $args
                fi

                if [ -n "${ELASTIC_USERNAME}" ] && [ -n "${ELASTIC_PASSWORD}" ]; then
                  set -- "$@" -u "${ELASTIC_USERNAME}:${ELASTIC_PASSWORD}"
                fi

                curl --output /dev/null -k "$@" "http://<IP_ADDRESS>:9200${path}"
              }

              if [ -f "${START_FILE}" ]; then
                echo 'Elasticsearch is already running, lets check the node is healthy'
                HTTP_CODE=$(http "/" "-w %{http_code}")
                RC=$?
                if [[ ${RC} -ne 0 ]]; then
                  echo "curl --output /dev/null -k -XGET -s -w '%{http_code}' \${BASIC_AUTH} http://<IP_ADDRESS>:9200/ failed with RC ${RC}"
                  exit ${RC}
                fi
                # ready if HTTP code 200, 503 is tolerable if ES version is 6.x
                if [[ ${HTTP_CODE} == "200" ]]; then
                  exit 0
                elif [[ ${HTTP_CODE} == "503" && "6" == "6" ]]; then
                  exit 0
                else
                  echo "curl --output /dev/null -k -XGET -s -w '%{http_code}' \${BASIC_AUTH} http://<IP_ADDRESS>:9200/ failed with HTTP code ${HTTP_CODE}"
                  exit 1
                fi

              else
                echo 'Waiting for elasticsearch cluster to become ready (request params: "wait_for_status=green&timeout=1s" )'
                if http "/_cluster/health?wait_for_status=green&timeout=1s" "--fail" ; then
                  touch ${START_FILE}
                  exit 0
                else
                  echo 'Cluster is not yet ready (request params: "wait_for_status=green&timeout=1s" )'
                  exit 1
                fi
              fi
          failureThreshold: 3
          initialDelaySeconds: 10
          periodSeconds: 10
          successThreshold: 3
          timeoutSeconds: 5
        resources:
          limits:
            cpu: "1"
            memory: 2Gi
          requests:
            cpu: "1"
            memory: 2Gi
        securityContext:
          capabilities:
            drop:
            - ALL
          runAsNonRoot: true
          runAsUser: 1000
        volumeMounts:
        - mountPath: /usr/share/elasticsearch/data
          name: data
        - name: localtime
          mountPath: /etc/localtime
        - name: config
          mountPath: /usr/share/elasticsearch/config/elasticsearch.yml
          subPath: elasticsearch.yml
      volumes:
      - name: config
        configMap:
          name: elasticsearch-cm
      - name: localtime
        hostPath:
          path: /usr/share/zoneinfo/Asia/Shanghai
  volumeClaimTemplates:
  - apiVersion: v1
    kind: PersistentVolumeClaim
    metadata:
      name: data
    spec:
      accessModes:
      - ReadWriteOnce
      resources:
        requests:
          storage: 100Gi
      storageClassName: nfs-storage

---
apiVersion: v1
kind: Service
metadata:
  labels:
    app: elasticsearch
  name: elasticsearch
spec:
  ports:
  - name: http
    port: 9200
    protocol: TCP
    targetPort: 9200
  - name: transport
    port: 9300
    protocol: TCP
    targetPort: 9300
  selector:
    app: elasticsearch
  type: ClusterIP

---
apiVersion: v1
kind: Service
metadata:
  labels:
    app: elasticsearch
  name: elasticsearch-headless
spec:
  clusterIP: None
  ports:
  - name: http
    port: 9200
    protocol: TCP
    targetPort: 9200
  - name: transport
    port: 9300
    protocol: TCP
    targetPort: 9300
  selector:
    app: elasticsearch
  type: ClusterIP
  publishNotReadyAddresses: true

Version
[root@vm088084 ]# istioctl version
client version: 1.10.2
control plane version: 1.10.2
data plane version: 1.10.2 (25 proxies)
[root@vm088084 ]# kubectl version --short
Client Version: v1.17.0
Server Version: v1.20.15

Additional Information
fasdfasdfasd

It looks like your nodes are trying to communicate to each other over HTTP, but Elasticsearch's transport protocol is binary (TCP).
Try hinting to the mesh that port 9300 is tcp, either by naming it tcp-transport or by setting appProtocol: TCP.

Closing as answered ^


VS keybindings extension overrides word navigation with column selection on OSX

From @rebornix on November 16, 2017 23:6
From @adison on September 30, 2017 6:57

VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:24:39.530Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

markdown-toc
Ala
1.5.6

vsc-rustfmt
Con
0.1.0

swift
Kas
0.0.3

githistory
don
0.2.3

python
don
0.7.0

unicode-normalizer
esp
0.0.1

vscode-auto-open-markdown-preview
hnw
0.0.4

Lua
key
0.0.9

Go
luk
0.6.65

MagicPython
mag
1.0.12

prettify-json
moh
0.0.3

cpptools
ms-
0.13.0

csharp
ms-
1.12.1

vs-keybindings
ms-
0.1.7

debugger-for-chrome
msj
3.3.1

Ruby
reb
0.15.0

RustyCode
sav
0.19.1

guides
spy
0.8.4

code-spell-checker
str
1.4.0

vscode-react-native
vsm
0.4.2

markdown-pdf
yza
0.1.7

Steps to Reproduce:

use alt + arrow key(left/right) to jump word by word
use shift to select anything(word or letter) and try alt + arrow(right/left) again, it can only move letter by letter.

Reproduces without extensions: Yes
Without this feature, it's hard to delete multiple words efficiently.
Copied from original issue: Microsoft/vscode#35412
Copied from original issue: rebornix/vscode-vs-keybindings#25

From @alexandrudima on October 2, 2017 7:25
@adison I cannot reproduce, word navigation works as expected for me.
Please check:

extensions can redefine keybindings. Are the alt+arrow keys still bound to word navigation? (you can disable extensions or search for "alt+leftarrow" in the keybindings UI at cmd+k cmd+s)
Have you customized editor.wordSeparators

From @adison on October 2, 2017 7:38
I have disabled all extensions before make this clip, what I mentioned is below, while using alt+shift+left/right, it move letter by letter.
http://www.giphy.com/gifs/xT9IgxgK5tQmbIFLzO
No idea if I made changes to editor.wordSeparators, I think no though, and it is   "editor.wordSeparators": "`~!@#$%^&*()-=+[{]}\\|;:'\",.<>/?",

From @alexandrudima on October 2, 2017 7:55
@adison Can you please check your keybindings for shift+alt+right:

open the keybindings UI: cmd+k cmd+s
search for shift+alt+right

Check that it is bound only to this command:

From @adison on October 2, 2017 7:59
There are two items..
What should I do? and it seems a default binding, isn't it?

From @adison on October 2, 2017 8:10
@alexandrudima Hi, I just map the cursorColumnSelectRight to control+shift+right, and so on cursorColumnSelectLeft, it works fine now.
And I would suggest put this setting to default setting, I have no idea what is cursorColumnSelectLeft yet, but I do need select and move by word by alt+shift+left/right, just as other application, kind of sublime text and many others.
I will leave this for you to close or what you want, sort of leaving it to remind those came with same problem.
Thanks for your help.

From @alexandrudima on October 2, 2017 10:5
@adison based on your screenshot, it appears an extension defines alt+shift+left/right to be column selection instead of word selection.
Specifically, I believe the vs-keybindings would do that.
In your initial report, you have the following incorrect statement:

Reproduces without extensions: Yes


Feat/Blob 4844 PICircuit Chunk TxBytes Condense

Description
Simplifies the chunk_txbytes section within PICircuit and condenses the section into one row with a copy constraint from TxCircuit where the correctness of l2 tx bytes accumulation and final keccak hash is actually ascertained.

Remove pow_of_rand from PICircuit.
Remove accumulation scheme for chunk txbytes in PICircuit.
Add chunk_txbytes_hash_rlc column to TxTable for copy constraint.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

The l1_pi_exprs can also be removed, as its no longer being used.


feat(primitives): serde for L1BlockInfoTx

Overview
Adds a conditional Serialize + Deserialize implementation for L1BlockInfoTx.

#460  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.4%. Comparing base (0048fcc) to head (3cfc11b).

Files
Patch %
Lines

crates/primitives/src/block_info.rs
0.0%
2 Missing :warning:

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


When using paging with an include, Stats.TotalResults is equal to the number of results on the page only instead of the total overall results

We encountered an unexpected behavior for Stats TotalResults after we added an Include() call into our query.
Example below:
public async Task query_with_include_can_get_the_total_in_results(
    IQuerySession session,
    int pageNumber,
    int pageSize)
{
    // Example: this returns 40
    var count = session.Query<Target>().Count(x => x.Number > 10);

    var targetInclude = new Dictionary<string, TargetInclude>();
    var list = await session
        .Query<Target>()
        .Where(x => x.Number > 10)
        .Include(x => x.TargetIncludeId, targetInclude)
        .Stats(out var queryStats)
        .Skip((pageNumber - 1) * pageSize)
        .Take(pageSize)
        .ToListAsync();

    // fails because queryStats.TotalResults = results on the page only
    queryStats.TotalResults.ShouldBe(count);
}

count corresponds to the expected number but queryStats.TotalResults matches the number of results in the page
Notes

Checking the generated SQL, there appears to be a duplication of total_rows on both the temp table and the primary query.
Removing Include() produces the expected results

Related/Similar issues
https://github.com/JasperFx/marten/issues/2243
Other info
Version: Marten 7.23.1

More info here - this is a sample of the sql we are seeing being generated. The issue is that the first total rows saved to temp table is forgotten and a new total rows is created based on the temp table itself
create temp table mt_temp_id_list2 as (
	select d.data, d.document_id, count(*) OVER() as total_rows
	from flexible_forms.mt_doc_document_list_view as d
	where (d.tenant_id = $1 and CAST(d.data ->> 'IsArchived' as boolean) = $2 and
		d.document_id LIKE $3)
		desc OFFSET $4 LIMIT $5
);
select d.data from flexible_forms.mt_doc_userprojection as d where (d.tenant_id = $1 and d.id in (select d.data ->> 'UserId' from mt_temp_id_list2 as d));
select d.data, d.document_id, count(*) OVER() as total_rows from mt_temp_id_list2 as d;

@kenuriarte @elexisvenator Try the same with 2.26.1. There have been a couple bug fixes lately with different permutations of Include() + any usage of QueryStatistics.

Thanks @jeremydmiller , we'll try out the updated version.

Hi @jeremydmiller , upgrading to 7.26.1 resolves the issue. Thank you for the guidance.
Closing the issue.


Fixes #837

Fixes #837
Notice that --tmpfs works for docker on Linux only.
comments are appreciated!

This change is

close by accepting this comment from https://github.com/cayleygraph/cayley/issues/837#issuecomment-535234192:

I would prefer to fix the container instead of adding more flags to docs to make it just work our of the box.


tree2: Mark APIs as beta

Description
Mark new API and its dependencies as @beta.
Reviewer Guidance
The review process is outlined on this wiki page.

Can the items still marked as @alpha become @internal? Doesn't have to be in the same PR, just wondering what the plan is.

Can the items still marked as @alpha become @internal? Doesn't have to be in the same PR, just wondering what the plan is.

We have third-party partners building on the flex-tree API, so I think it makes sense to keep them public but unstable. I think alpha is a good way to do that.
I don't think @internal makes a lot of sense in this package, since anything people build on this package should be able to be build outside the repo by third parties: it doesn't have an API surface intended to be consumed by other packages inside this repo. Anything we could mark as @internal could simply not be exported.

Various people (including myself) have expressed a desire to just go ahead and merge thigs for now. It should help clarify which API surfaces we want people testing out and help our developers avoid accidently leaking non MVP APIs into the MVP types.
Since undoing this is trivial (find and replace @beta with @alpha), we decided to go ahead with this change for now, and back it out later if we want to revisit the process for stabilizing the APIs.
The package API surface will still get review if they move from beta to public, as well as when we move the package out of experimental, so moving these from alpha to beta isn't too major of a change.

Approving this PR so that we can take advantage of the reduced API surface when bug-bashing SharedTree next week, and validate the import process. Tree will follow the same tagging pattern as the rest of FF soon (e.g. alpha tags in tree may become internal, and beta tags may become public); this is just a temporary step to help validate the API during the bug bash.

I will prepare a separate PR to address the documentation gaps Josh pointed out, as thats still mostly orthogonal to this APi layering/separation work.


Can't click and drag to select text in the Debugger "Watch" pane

System:
Version: 1.29.0 (user setup)
Commit: 5f24c93878bd4bc645a4a17c620e2487b11005f9
Date: 2018-11-12T07:47:15.448Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64
Steps to Reproduce:

Start a debugging session (I used Python but that shouldn't matter)
In the "Watch" panel on the sidebar, click "+"
Type anything
Try to select text using the mouse (ie, click and drag)
Instead of text being selected, the whole expression is dragged

Note that shift + arrow keys does work to select text.

@iansan5653 good catch, thanks for reporting

@roblourens this issue was for the input box - it is definitely fixed in the latest preview.


Remove mentions to old unsupported frameworks from projects

Cleanup of conditions in project files to other (old) frameworks, which are not used anymore. All projects in solution targets just .NET 6.
I also changed element <TargetFrameworks> to <TargetFramework> everywhere.

I made this PR because there really is no need for these conditions when those frameworks are not supported. But I am curious, Mapster is dropping support for (old) .NET Framework? I do not mean .NET Core 3.x (or less), but full .NET Framework 4.x.

Thanks! Yes, it's not sustainable to maintain support for .NET Framework unfortunately (this has to do with how the code generation works). Users that require this library on that platform can use the older versions of Mapster.


Regarding context getting changed

When I am paraphrase with specific sentence that time the context of sentence getting changed. Is there any way to get control on that
Code
import numpy as np
def set_seed(seed):
np.random.seed(seed)
set_seed(0)
sentence = "Accounting for physicians who are potential prescribers, the overall Outreach declined by 89%."
text =  "paraphrase: " + sentence + " "
encoding = tokenizer.encode_plus(text, return_tensors="pt")
input_ids, attention_masks = encoding["input_ids"], encoding["attention_mask"]
outputs = model.generate(
input_ids=input_ids, attention_mask=attention_masks,
max_length=100,
do_sample=True,
top_k=50,
top_p=0.95,
#num_beams = 1,
early_stopping=True,
num_return_sequences = 5
)
for output in outputs:
line = tokenizer.decode(output, skip_special_tokens=True,clean_up_tokenization_spaces=True)
print(line)
Input
Accounting for physicians who are potential prescribers, the overall Outreach declined by 89%.
Output
Accounting for physicians who are potential prescribers, the overall outreach decreased 89%.
Including physicians who are potential prescribers, the overall outreach grew by 89%.
Recalling for physicians who are potential prescribing physicians, the overall outreach declined by 89%.
The overall outreach declined by 89% for doctors who are potential prescribers.
Accounting for physicians who are potential prescribers, the overall outreach decreased by 89%.

Thanks Vamsi


How does MenuItem and overflow item styling works?

Hi,
Am trying to change the Text color of the MenuItems in the overflow Menu.
Is it possible to use the default app theme or what attribute to use to get it fixed.
Thanks

Hi @ernestkamara ,
I haven't tried messing with the themes to get what you want working, but I'll look into it after the next release 2.0.2. If you look into the code you will see that I am using a MenuPopupHelper for creating the popup.
Regards

Thanks. I managed to come up with a workaround for our current release.
But would be nice to have some theming feature in the next releases.


Huge performance issue on IE

Hi man I was using your lib on my project but i notice performance issue on IE(10, 11, edge) on different machines.
My UI was unresponsive and very laggy so I try svg4everybody.js it was much better.

Can you provide a reduced test case?

Here is link temporary link:
As I investigate further the problem is in crappy IE svg rendering, but still getting better frame rate with svg4everybody.js.
I don't see any difference between using  svg4everybody.js and  without absolute path so svg4everybody.js isn't causing any additional performance issue in my case.
.

You can compare performance with svg4everybody here http://prototypes.magicsolutions.bg/uniqa-liveinsurance-calc/

Thanks. As you hinted yourself, it seems that IE has some performance issues when rendering SVG elements with use elements. I made another test case based on yours, which embeds those SVG definitions (in your shapes.svg file) in the html itself, and I removed svgxuse from your js. The page is still slow in IE. So it's not an issue with svgxuse, but IE itself.
svg4everybody replaces all use elements with the contents of the SVG definition and therefore avoids this issue. Since svgxuse is a polyfill, it's not supposed to replace use elements. It simply makes it possible to use SVGs with use elements that reference external SVGs.


Updates to v4 of CardFlight SDK

This PR updates Eidolon to use v4 of the CardFlight SDK. It is a work-in-progress because of some outstanding TODO items, as well as manual testing before merging. Paired with @sepans with this.

@orta okay this is good for review. Please see my note above requesting feedback.
Also note that https://github.com/artsy/eidolon/pull/687/commits/c8fdf99d0dceb87764be110f3676fe8e85d3a72f removes the "processing" label and instead we opt to display the messages that CardFlight sends us to display to the user (with "Please wait..." as a placeholder if there is no current message). This fixes a longstanding issue with users swiping before the card reader is ready, too.

Okay great, I'll put this on an iPad and work with Nicole to test before a deploy. Thanks!

I've ticketed the work for CardFlight compatibility, it's trickier than it looks at first due to Xcode 10 removing libstdc++.6.0.9:
https://artsyproduct.atlassian.net/browse/PURCHASE-615


Question marks instead of emojis?

Hi, any idea why in 4.0.3 I am getting question marks for almost all emojis in the picker? Tested in latest Chrome and Firefox on PC with latest Windows 10 and latest Chrome on Android Phone. They show fine in 3.0.0. Tried clearing Chrome's cache, incognito mode and restarting. If it matters, Windows 10 region is set to the United States.
https://stockbot.us/emojiPickerTest.php

import {  EmojiButton } from "/scripts/emoji-button-4.0.3.min.js?1";

window.addEventListener("load", function () {

  // scheduled alerts

  var emojiPickerMessage = new EmojiButton({
    autohide: true,
    autoFocusSearch: true,
    //categories: '[]',
    emojiSize: '1.8em',
    emojisPerRow: 8,
    //emojiVersion: '12.1',
    //emojiVersion: '1.0',
    position: 'bottom',
    recentsCount: 50,
    initialCategory: 'recents',
    //rootElement: body
    rows: 6,
    showCategoryButtons: true,
    showPreview: true,
    showSearch: true,
    showRecents: true,
    showVariants: true,
    style: 'native',
    theme: 'auto'

  });

  // message

  var emojiButtonMessage = document.getElementById('emojiButtonMessage');

  emojiButtonMessage.addEventListener('click', () => {
    emojiPickerMessage.togglePicker(emojiButtonMessage);
  });

  emojiPickerMessage.on('emoji', emoji => {
    document.getElementById('saMessage').value += emoji.emoji;
  });

});

Uh oh. I see it in your example as well. Let me try to reproduce locally.

ok, thanks for checking.

Can't reproduce it locally. I think it's a problem with your server. If you look at the raw JS being served by the server, the emoji data isn't in there, it's just the question marks:
 }, {
        emoji: "??",
        category: 1,
        name: "old man",
        variations: ["????", "????", "????", "????", "????"],
        version: "1.0"
    }, {

Your server needs to serve the JavaScript file with an encoding of utf-8. For example, here's the Content-Type header on my local server for the emoji data:
Content-Type: application/javascript; charset=utf-8

However, your server doesn't have the charset=utf-8 part:
content-type: application/javascript

If you adjust your server configuration to serve JS files with the utf-8 encoding, you should be good to go.


Remove needless duplicate JSDoc in generated code

What
JSDoc once on the type:

JSDoc again on the term:

Remove the JSDoc on the term.
Why

It turns out that in VSCode The term will "inherit" the JSDoc from the type in the declaration file.
Removing the duplicate JSDoc will make the generated code less noisy for readers, even though for the most part it should not be read by humans directly.

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@next-major dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


<EMAIL_ADDRESS>hash check failed

CPU-Z fails to install version 1.92 currently due to a hash check
scoop install cpu-z
Installing 'cpu-z' (1.92) [64bit]
Loading cpu-z_1.92-en.zip from cache
Checking hash of cpu-z_1.92-en.zip ... ERROR Hash check failed!
App:         extras/cpu-z
URL:         http://download.cpuid.com/cpu-z/cpu-z_1.92-en.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected:    40e0f232236ea4093200e17a65bf855f59646bffb7c516896298b63271d9f29e
Actual:      5e858342706c2afc43cc5b6856000fa5f457ed16e473ecc234253a79ea34c5e7

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/lukesampson/scoop-extras/issues/new?title=cpu-z%401.92%3a+hash+check+failed

Working around by install 1.91 works with the following:
scoop install<EMAIL_ADDRESS>WARN  Given version (1.91) does not match manifest (1.92)
WARN  Attempting to generate manifest for 'cpu-z' (1.91)
Autoupdating cpu-z
Downloading cpu-z_1.91-en.zip to compute hashes!
cpu-z_1.91-en.zip (2.9 MB) [==================================================================================] 100%
Computed hash: a535efc8014993a7b94edb6014de59905e3234d35198f6bf34b217bfa0a7d276
Writing updated cpu-z manifest
Installing 'cpu-z' (1.91) [64bit]
Loading cpu-z_1.91-en.zip from cache
Checking hash of cpu-z_1.91-en.zip ... ok.
Extracting cpu-z_1.91-en.zip ... done.
Linking ~\scoop\apps\cpu-z\current => ~\scoop\apps\cpu-z\1.91
Creating shim for 'cpuz'.
Creating shortcut for CPU-Z (cpuz_x64.exe)
Persisting cpuz.ini
'cpu-z' (1.91) was installed successfully!

It does seem to be a network issue, as was able to get 1.92 installed off of my phone hotspot. Curious that 1.91 works in that situation...


📌 [CUSTOM]

Hi, I’m @obarscan
I noticed that if you use the autoncofigurator the hostservices are in separated scope.

Hi, I’m @obarscan I noticed that if you use the autoncofigurator the hostservices are in separated scope.

Hello,
Jobs running on HostedService already run by creating a separate scope.


tests.fetchtorrent: add license

Description of changes
This turns the tests unfree, which should be fixed in a follow up PR.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Could this be more productive by just finding something free to fetch instead of worrying about the license? I didn't realise when I made the test that this was so unfree, nothing was intended by it, I'm not a licensing expert.

I was only hoping to mark it free in the prior PR, and ended up on Wikipedia which lists the license. Interpreting the license myself I'd say it is safe for non-transformative redistribution, which is what we do here for the tests, but other licenses in licenses.nix mark noncommersial as unfree which is what i ultimately when by.
The context for licenses.nix and the tests here however may be different.

Following software-oriented definition of package freedom has its pitfalls, but yeah, if a large part of a package output is non-commercial-use-only, we mark it unfree. (And we try not to have such stuff on Hydra)
I thought «sure, let's just replace with Debian netinstall image» but then  I saw the size, and it's really large nowadays….


Solution of problem 9 seems not correct

Hey there,
I run into this just because I'm on daily coding problem as well. I like your coding style. Very concise. That's brilliant. But I still want to point out that some of your solutions are too simple to be good. More edge cases need to be tested.
For example, solution of problem 9 won't work for [1, 2, 3, 4, 5, 6].

Thanks for the feedback :)
I gave myself a time limit for each to better prepare for actual coding
interviews -- testing suffered ;)
I'll have a look at the one you mentioned. If you find more errors with any
solution, let me know or send a pull request!
//Riccardo
On Tue, Jul 3, 2018 at 5:31 PM Wendell Jiang<EMAIL_ADDRESS>wrote:

Hey there,
I run into this just because I'm on daily coding problem as well. I like
your coding style. Very concise. That's brilliant. But I still want to
point out that some of your solutions are too simple to be good. More edge
cases need to be tested.
For example, solution of problem 9 won't work for [1, 2, 3, 4, 5, ##6].
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/r1cc4rdo/daily_coding_problem/issues/1, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ALnDf5cj3YyGjxvyAXh_fJTDZGQNhamOks5uDAz9gaJpZM4VBzAp
.

I see what happened.
I interpreted the problem definition as "the largest sum of any two non-adjacent numbers", hence my solution. I'll accept your pull request as it's a more precise interpretation of the problem statement and leave mine as an alternate with a note.
Thanks!

Yep, you get my point. Thanks for reviewing the code.
And like I said before, as I am having my hands on solving these coding problems every day, I will keep an eye on your solutions as well. I will continue to send you a pull request if I detect some other issues. Let's make it better.


Support for stones (mass)

Hello,
Is there the possibility to add support for stones in mass, or perhaps a way to easily extend the functions to add any units that are not supported?
Thanks,

Or of course I can contribute this if it's welcome:

https://github.com/nosferatoy/units-converter/pull/23

Tnx, I will review the PR in depth later (the code addition is simple) but I am not sure if stones are a proper unit for the imperial system or I have to expand the library so it can accommodate 'historical'(?) units.
Also about the contributions, I am interested to build a proper community to maintain this library but I have to make some improvements to my pipeline for building and npm deployment first.

Hello, stones are definitely a proper imperial unit, and not historical in the UK at least... The standard units for measuring a person's weight, for example, is stones / pounds.


Update how-to-connect-health-agent-install.md

Restart-Service AzureADConnectHealth* seems to be for old version of agent, the services are now named AdHealthAdfs*

Learn Build status updates of commit a768665:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/active-directory/hybrid/how-to-connect-health-agent-install.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@billmath
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Debug flag description hunt

We can add tooltips to the flags now, and also let tooltips be searchable too :)

Don't really know what ones are actually useful or not though, if you know any flags that actually work in UHD version please post them here!
Alternatively if you want to write a description for the flag feel free, the template for it should be like:

{int(Flags_[category]::[flag]), "[description]"},

eg

{int(Flags_DEBUG::DBG_SAT_DISP), "Displays SAT collision polygons"},

The list at https://github.com/emoose/re4-research/issues/12#issuecomment-1139181254 might be useful if anyone wants to track down which DBG_ flags work, most of the DBG_ flags in vanilla UHD are listed there, maybe will try getting a similar list for the other flags too.
(the lines with & are code where the flag value gets checked, while lines with | are setting the value to be active)

Thats feels great men. I uses alot the SPF_EM = Pause Enemies Behavior. So i will test some o then again to write here editing this comenting.
SPF_EM = Pause Enemies Behavior

The SPF_** flags seem to stop processing everything related to them, including physics calculation, movement, etc. Used it in the free camera patch too, was kinda useful there.

I'm responding to you with my previous commentary mean while i edit it

Dumped some lists of flag usages from the EXE, should help us to find more flags that are actually in use:
flag_usages.zip

@emoose Just found out SPF_KEY stops key presses from being processed.


Move abstract tracer to contrib

This comes over and over again (most recently here), I think we should address this. The reasons for moving abstract tracer out of opentracing-java are:

it is not used by many (most?) existing production tracers
it does not necessarily reflect how the tracers should be implemented
it has some unexpected, but hard to remove design choices  (#55)
it often confuses newcomers being in the official OT Java repo
it's not clear if there are active maintainers of opentracing-java who also want to maintain the abstract tracer (and they can still do it in contrib)
abstract tracer is not needed for development of OT API itself, because implementation questions can be tried out in Noop and Mock tracers, both of which do not extend the abstract tracer.

I will cc @michaelsembwever since he is most likely to come to its defense. :)  That said, I haven't heard from mck in many moons so I'm not confident that he has cycles to weigh in.
I am wildly in favor of this move and merely lack the time to actually do the mechanical work involved. If we're unable to find the time to move it, at least we could change the SpanContext/SpanBuilder relationship which is surprising to all comers.

@yurishkuro +1, I have explained so many times to my co-workers... Many of them thought they are part of Spec or Spec-java, and must be followed when implement OT-SPEC-JAVA.
I am glad about this.

@yurishkuro 👍
My biggest gripe with this is it forces subclasses to become residents of the io.opentracing.impl package which could become real crowded real soon if this continues to be encouraged.

Closed via #121.


tuptime: 5.2.3 -> 5.2.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/rfmoz/tuptime/releases.
meta.description for tuptime is: Total uptime & downtime statistics utility
meta.homepage for tuptime is: https://github.com/rfrail3/tuptime
meta.changelog for tuptime is: https://github.com/rfrail3/tuptime/blob/master/CHANGELOG
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.2.4 with grep in /nix/store/886kdfjc53fj1z9d0njqa90sv6hr0qr8-tuptime-5.2.4
found 5.2.4 in filename of file in /nix/store/886kdfjc53fj1z9d0njqa90sv6hr0qr8-tuptime-5.2.4

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

tuptime

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/886kdfjc53fj1z9d0njqa90sv6hr0qr8-tuptime-5.2.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tuptime https://github.com/r-ryantm/nixpkgs/archive/9e1bb6323faf82f482ee8bc39609ff6de10af6d2.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/9e1bb6323faf82f482ee8bc39609ff6de10af6d2#tuptime

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/886kdfjc53fj1z9d0njqa90sv6hr0qr8-tuptime-5.2.4
ls -la /nix/store/886kdfjc53fj1z9d0njqa90sv6hr0qr8-tuptime-5.2.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

tuptime
tuptime.man

Maintainer pings
cc @evils for testing.

Result of nixpkgs-review pr 327150 run on x86_64-darwin 1

2 packages built:

tuptime
tuptime.man


Go to User journal/Launch activity when clicked on chart

A nice UX feature can be added which takes the admin to the user journal page when he/she clicks on the user in the Top Contributors chart.
The admin can also launch an activity by clicking on it in the Top Activities chart.
Implemented here: #85

Fixed in https://github.com/llaske/sugarizer-server/pull/85


Question: How to control which objects are processed? In my case, in-text citations.

Congratulations on the beautiful project. I really love the structural analysis that GROBID does.
But I needed the raw body text. My first thought was to reconstruct it from the TEI output, but I can't do it properly because the "bibliographical reference markers" alters the citations. For example:
RAW:
(Jonas 1966, 1968, 1979)
PROCESSED:
<ref type="bibr" target="#b11">(Jonas 1966</ref>
<ref type="bibr" target="#b12">(Jonas , 1968</ref>
<ref type="bibr" target="#b13">(Jonas , 1979</ref>
The question is, how could one have more control over which objects are processed? Most of the ones in the fulltext model (paragraphs, section titles, figures, ...) are fine for my purposes, the issue is really the in-text citations.

Hi @DanielGieseler !
Indeed the reference text markers might be modified when the references are expressed in a compact/range way. The reason is to be able to attach mark-up to individual reference markers and link them to the full reference entries in the bibliographical section.
This is clear when using citation markers like [1-5], but we also do it for compact form like  (Jonas 1966, 1968, 1979) that we develop in 3 Jonas, YYYY forms, and this might not be the best choice in this case but it avoids overlapping issues and it rebuilds a fully specified reference marker (i.e. less related to a presentation context).
https://github.com/kermitt2/grobid/blob/master/grobid-core/src/main/java/org/grobid/core/utilities/matching/ReferenceMarkerMatcher.java#L344
Note that the raw body text is something actually often quite different from what we read on the screen and what Grobid normalizes and cleans as XML output. The goal of Grobid is to focus on "logical" document and not on the original presentation, and therefore there will be always some sort of logical "re-composition" and normalization.
It's possible to get exactly the raw text (without markups!) via the createTrainingBlank batch method, but normally it's relevant only for creating training data.

Thanks for the reply, @kermitt2 !
I tried the createTrainingBlank method, as you suggested, by adding
engine.createTrainingBlank(pdfFile, "/var/grobid/grobid-example/src/test/resources", "/var/grobid/grobid-example/src/test/resources", -1)

to your "example of usage of Grobid" program. It worked fine, but as you said it is too raw.
I am trying to improve the step of identifying in-text citations. So I would like something before that step, but further ahead of the processing pipeline. Something after processing the wonderful features of:

Dividing document into sections
Identifying and consolidating data from the header and the reference list


Move files and folders on remotes using drag and drop

At least on Mac it's working only if you bring something from the finder (ie local) with drag and drop to the desired directory on the remote files list GUI which brings up the upload window.
But it would be very useful to being able to also quickly move around files and folders already on the cloud (from one directory to another) using this GUI and drag and drop function with an option in the preferences to disable the dialog window to appear every time you move something to another directory to make even faster and more similar to how things work locally! ;-)

Just to describe it further...it's just that there isn't a quick and intuitive way to move around files already on the remote cloud storage from inside the GUI...creating jobs for this simple task (cloud drive to same cloud drive move) is not a clean approach I think...no?? ;-)

Yes I see what you mean. No plans for this though yet. Drag and drop in QT is not something I am familiar with.
It was low hanging fruit for uploads but to drag item from within QT interface required a lot of coding. Definitely doable but not easy.
Let's keep it in mind for future enhancements.

It was low hanging fruit for uploads but to drag item from within QT interface requires a lot of coding. Definitely doable but not easy.

Not used to it I discovered it today.
You are transforming what used to be a zombie in a full flesh superbaby!
Thanks!
CT


Unique identifier of User entity is email, but should be configurable

In the current implementation, the unique/required identifier and required field is email, and I think that should be configurable. Or, we can introduce a new field username which is required and email can be optional. In case where username and email address are same, simply fill both attributes with the email address.
Use Case:
At ING, we do use corporate keys, which are totally unique and can not be changed, but email address can be changed (for example, name change after marriage, change of domain part based on geolocation etc.) So, to handle that scenario we can have corporate key as the unique identifier. It would make no sense and may be confusing for the users if we send corporate key in email address field and also, then there would not be an attribute to put email address.
Happy to discuss in details, and make the change in both frontend and backend, once we finalize this.
@feng-tao @jinhyukchang

@verdan Thanks for raising this question. Could you let us know which code path is using email as a key? Thanks!

@jinhyukchang the owner and reader information here: https://github.com/lyft/amundsenmetadatalibrary/blob/master/metadata_service/entity/table_detail.py#L4
And user detail entity here: https://github.com/lyft/amundsenmetadatalibrary/blob/master/metadata_service/entity/user_detail.py#L3

I see. I agree to have unique string on it. How about adding into the model id?
Along with two entities you mentioned above, I think we also need to add it in API payload.
https://github.com/lyft/amundsenmetadatalibrary/blob/master/metadata_service/api/table.py#L11

Is there any traction on this? If not, I can make some PRs to clean this up.

@worldwise001 I haven't started working on this yet, and any help would be highly appreciated 🙂


Add Flutter in #Implementations

There is now a pure dart implemenation - I think that's the cleaner approach.

Even better !

There is now a pure dart implemenation - I think that's the cleaner approach.

I think you have mistaken the repository reference. This is the pure dart implementation with no flutter dependencies.
https://github.com/justacid/blurhash-dart

This is conflicting now. Could you fix it?

@DagAgren Done


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_9ec5c939-5843-46db-a96f-3008541c30dd/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_9ec5c939-5843-46db-a96f-3008541c30dd.git

Docs Build status updates of commit c9ed5e1:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RepositoryUnauthorizedWithSourceCommit] Git data access to 'https://github.com/opstest2/docs-archive-test-source' (branch: Release_Archive_main_2022-02-17-01-40-02) is not authorized.. It looks like this might be the first time user: v-alji submitted a pull request to this repo. Before user can run builds in a pull request, he/she can enable 'v-alji' GitHub account in Docs by visiting Docs Portal (https://ops.microsoft.com). After enabling his/her account (v-alji), close and then reopen this pull request to start another build.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


No uploads from cordova app. CORS from http://meteor.local?

Just tried cfs from a cordova app on meteor 1.0:
Looks like the mobile client runs from http://meteor.local (android, not sure how it's done on iphone) and when inserting images from the client, httpCall PUT to /cfs/files/... ends up not reaching the server.
Tried setting FS.HTTP.uploadUrl to something better like __meteor_runtime_config__.ROOT_URL + FS.HTTP.uploadUrl.slice(1) and ran into this CORS issue. Sounds like HTTP.publish needs to allowOrigin http://meteor.local at least? Also, http-methods doesn't seem to have explicit OPTIONS support at the moment? What's the best way to tackle this? Thanks!

@raix I seem to be getting a similar issue with wkview
015-08-02 23:05:51.872 Buzzy[95475:22710162] ERROR: Error: "Queue" network [undefined], errorClass@http://localhost:12344/packages/meteor.js?4dc9757b244a30bdf37a732ac4db4026ce56fb6b:558:24
http://localhost:12344/packages/cfs_upload-http.js?cf37b2941c8cdbfd85cdc3948f57fed4bb429081:379:32
http://localhost:12344/packages/cfs_upload-http.js?cf37b2941c8cdbfd85cdc3948f57fed4bb429081:105:15
http://localhost:12344/packages/underscore.js?0a80a8623e1b40b5df5a05582f288ddd586eaa18:801:24
onreadystatechange@http://localhost:12344/packages/cfs_upload-http.js?cf37b2941c8cdbfd85cdc3948f57fed4bb429081:164:19

https://github.com/CollectionFS/Meteor-CollectionFS/issues/760
Just wondering if this is a similar issue for http://localhost:12344 instead of meteor.local?
I tried adding App.accessRules and browser-policy settings for the localhost domain... but could not seem to get this to work.
Any ideas welcome.

@adamgins  try adding App.accessRule("blob:*"); to your mobile-config.js

The upload window doesn't open on my phone at all. Works on desktop. I added the blob to the config but nothing still.


Migrate to first pre-release of FFI 0.9.0

Includes:

Initialization changes to enable log filter customization. We now connect the Rust log level to the Swift log level, and always run other Rust initialization steps.
ZIP 320 support (TEX addresses).
Fetching the ZEC-USD exchange rate over Tor.

Depends on https://github.com/Electric-Coin-Company/zcash-light-client-ffi/pull/142.
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author

[ ] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[ ] Automated tests: Did you add appropriate automated tests for any code changes?
[ ] Code coverage: Did you check the code coverage report for the automated tests?  While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
[ ] Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
[ ] Run the app: Did you run the app and try the changes?
[ ] Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
[ ] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
[ ] Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

Force-pushed to address comments, and replace Float64 with NSDecimalNumber.

Rebased on latest integration branch state and pulled in latest -ffi preview state.


[MRESOLVER-290] Expand use of atomic file ops

Drop old and legacy code doing smart(er) things, use common shared primitives instead.
Also, make IO handling stricter, do not be "forgiving" by swallowing IOEx-es as they will inevitably lead to failures, it does not make resolver more robust, but actually makes it harder to figure out the problems, and could lead to incomplete downloads or uploads. Simply put, if reading or writing a file on disk fails with IOEx, do not assume "is fine" in any case. This probably shows some existing issue like permissions or whatever.

https://issues.apache.org/jira/browse/MRESOLVER-290

There's much more to do, but am stopping here due https://issues.apache.org/jira/browse/MRESOLVER-295.
My plan is following:

component should use component (even if trivial as Slawek noted) to perform IO. Reason: components can be swapped out
split FileProcessor into PathProcessor (as name says, for files) and ChecksumProcessor (to read write checksums ONLY, to not mix concerns). This opens up the possibility to implement different ChecksumWriters (BSD/GNU/whatever), as currently we read BSD/GNU/resolver-native but write only resolver-native format.
but, due module layout (SPI not depending on Utils, and both Impl and Connector depending on SPI but Connector not on Impl) this needs a bit more work: see how many implementations of FileProcessor we have across, exactly for this reason. So, I want to do something with it.
direct use of static helper reduces testability, there is a nice test where file copy fails, that cannot be done if directly static helper used.