Can't change current_time_adapter vía when is set as an attribute at compile time

https://github.com/joken-elixir/joken/blob/bccf3c6d203afd3611437af8369b2b87a5be24a0/lib/joken.ex#L105
The current_time_adapter is set as an attribute, so when the module is used as a dependency it always takes the compile time configuration (Joken.CurrentTime.OS) and can't be overridden via config.

Sorry @dariodf but I don't think it is an issue because test is a differente compilation environment than dev, prod and so on (see the _build folder where it has a different folder per environment).
The primary use case I thought about when writing this was to ease testing when depending on Joken, for example, if you want to advance or go back in time to validate a token configuration.
Can you share your use case? Do you mean to dynamically change this module in runtime?

@dariodf I'll be closing this due to inactivity. If you can share your use case or think this needs more discussion, please, be free to re-open it.


Instantiate mk encryption key registry

The KeyRegistry struct holds the private keys used for match key decryption. Currently there will only be one such key.

[x] Figure out where the KeyRegistry instance should go (this question overlaps with #675)
[x] Initialize the KeyRegistry with the private key configured on the command line

Implemented in #692.


Some logo images are hard to see in dark mode on GitHub

What problem do you want to solve?
Some logo images, such as GitHub, are hard to see in dark mode on GitHub.

What do you think is the correct solution to this problem?
Add a white background, like Node.js's one.
Are you willing to submit a pull request to implement this change?
I don't mind doing it, but anyone can do it.

Maybe better is to add white outline on the ones that needs it, so that we don't get the jarring white boxes.
e.g. the npm logo would look good if we just fill in the inside of the text with white, and I think the Node.js logo would look better with just a white outline instead of a white box...

We could use badges instead.
For example:

@feross I can create a PR to finish it if you like those badges.


Missing parts in the tutorial

I believe some parts are missing in the tutorial. The demo repo provides some missing insight and I will keep updating this as I follow the tutorial:
The Ecspanse.Entity is missing in the tutorial from:
https://github.com/iacobson/ecspanse_demo/blob/ad29dc421b08435ff83fc81d82508e1a0f44c750/lib/demo/api.ex#L9
and is needed here: https://github.com/iacobson/ecspanse_demo/blob/ad29dc421b08435ff83fc81d82508e1a0f44c750/lib/demo/api.ex#L20
The function list_hero_resources/1 is in the tutorial but adding it to the fetch_hero_details/0 function under the resources key part is missing.

The same applies for the function list_hero_inventory/1, the function is in the tutorial, not an example of hooking it up in the fetch_hero_details/0.

Thank you! I will update the docs and include them in the next release 0.8.1


Add resources for Help Center > Articles and Sections

Adds resources for Help Center / Explore's Articles and Sections.

Adds resources for Help Center / Explore's Articles and Sections.

Thanks for the contribution @brianebeyer. So sorry to took us this long to get it merged! 🙇

Thanks @nogates !


chore: Bump karpenter and operatorpkg

Fixes #N/A
Description

Bump karpenter and operatorpkg

How was this change tested?

N/A

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.828%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/controllers.go
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
5677

Relevant Lines:
6854

💛  - Coveralls


ADDING ISSUE TEMPLATE

There is no PR template in this repository yet.
I would like to work on this issue if I get assigned😊.

Sure go ahead!

PRs will mostly be handled by github-actions bot.
Folks will need to create issue to tweet from KubeSimplify's account
If you're interested in creating an issue template instead, feel free to edit this issue's title Adding issue template and work on the same
You can use kubernetes-sigs/contributor-tweets's issue template for reference

@anubha-v-ardhan I would love to work on the issue template 🙋

Thankyou @vish-han :)

@vish-han Please wait for some time as we're still deciding if to "tweet via issue" or "tweet via PR"

Ok bhia

@vish-han We've decided to go with PR workflow temporarily and continue working to build an issue based workflow (see https://github.com/kubesimplify/tweets/pull/3#issuecomment-1086152031). I think it would be nice to create templates for both Issues and PRs

Thanks @anubha-v-ardhan for letting me know about the changes,  I have my exam going on rn but I will try to make changes ASAP.😄

Issue template is done


When i use test the model in any resolution of images, i meet the following problem

This is my testing code:
import torch
import math
from model import  Uformer
def expand2square(timg, factor=16.0):
_, _, h, w = timg.size()
X = int(math.ceil(max(h, w) / float(factor)) * factor)

img = torch.zeros(1, 3, X, X).type_as(timg)  # 3, h,w
mask = torch.zeros(1, 1, X, X).type_as(timg)

# print(img.size(),mask.size())
# print((X - h)//2, (X - h)//2+h, (X - w)//2, (X - w)//2+w)
img[:, :, ((X - h) // 2):((X - h) // 2 + h), ((X - w) // 2):((X - w) // 2 + w)] = timg
mask[:, :, ((X - h) // 2):((X - h) // 2 + h), ((X - w) // 2):((X - w) // 2 + w)].fill_(1.0)

return img, mask

x = torch.randn(1, 3, 128, 720)
rgb_noisy, mask = expand2square(x, factor=128)
print(rgb_noisy.size())
print(mask.size())
out = model(rgb_noisy, (1 - mask))
print(out.size())
I meet the following problem:
torch.Size([1, 3, 768, 768])
torch.Size([1, 1, 768, 768])
Traceback (most recent call last):
File "/Users/Uformer-main/my_test.py", line 69, in
out = model(rgb_noisy, (1 - mask))
File "/opt/anaconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 550, in call
result = self.forward(*input, **kwargs)
File "/Users/Uformer-main/model.py", line 1336, in forward
conv0 = self.encoderlayer_0(y,mask=mask)
File "/opt/anaconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 550, in call
result = self.forward(*input, **kwargs)
File "/Users/Uformer-main/model.py", line 1044, in forward
x = blk(x,mask)
File "/opt/anaconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 550, in call
result = self.forward(*input, **kwargs)
File "/Users/Uformer-main/model.py", line 695, in forward
attn_mask = attn_mask or shift_attn_mask
RuntimeError: bool value of Tensor with more than one value is ambiguous

We have just fixed the  masks, you can try again, hope a good practice!

You choose Uformer...
===>Testing using weights:  ./weights/model_best.pth
0%|                                                                                | 0/8 [00:03<?, ?it/s]
Traceback (most recent call last):
File "test_in_any_resolution.py", line 105, in
rgb_restored = model_restoration(rgb_noisy, 1 - mask)
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/parallel/data_parallel.py", line 165, in forward
return self.module(*inputs[0], **kwargs[0])
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/1/o2/model.py", line 1357, in forward
deconv3 = self.decoderlayer_3(deconv3,mask=mask)
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(input, **kwargs)
File "/home/1/o2/model.py", line 1038, in forward
x = blk(x,mask)
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(input, **kwargs)
File "/home/1/o2/model.py", line 707, in forward
attn_windows = self.attn(x_windows, mask=attn_mask)  # nWB, win_sizewin_size, C
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/1/o2/model.py", line 348, in forward
attn = (q @ k.transpose(-2, -1))
RuntimeError: CUDA out of memory. Tried to allocate 2.53 GiB (GPU 0; 23.70 GiB total capacity; 16.35 GiB already allocated; 1.94 GiB free; 20.44 GiB reserved in total by PyTorch)
The resolution of the test image is 2300×1700，batch size =1 has been set.

The above error occurs when testing images of any resolution through the new code. Is this a common problem?

You choose Uformer...
===>Testing using weights:  ./weights/model_best.pth
0%|                                                                                | 0/8 [00:03<?, ?it/s]
Traceback (most recent call last):
File "test_in_any_resolution.py", line 105, in
rgb_restored = model_restoration(rgb_noisy, 1 - mask)
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/parallel/data_parallel.py", line 165, in forward
return self.module(*inputs[0], **kwargs[0])
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/1/o2/model.py", line 1357, in forward
deconv3 = self.decoderlayer_3(deconv3,mask=mask)
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(input, **kwargs)
File "/home/1/o2/model.py", line 1038, in forward
x = blk(x,mask)
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(input, **kwargs)
File "/home/1/o2/model.py", line 707, in forward
attn_windows = self.attn(x_windows, mask=attn_mask)  # nWB, win_sizewin_size, C
File "/home/1/anaconda3/envs/t1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/1/o2/model.py", line 348, in forward
attn = (q @ k.transpose(-2, -1))
RuntimeError: CUDA out of memory. Tried to allocate 2.53 GiB (GPU 0; 23.70 GiB total capacity; 16.35 GiB already allocated; 1.94 GiB free; 20.44 GiB reserved in total by PyTorch)
The above error was reported when the new code tested the pictures with a resolution of 2300 * 1700. Is this a common problem? How can we successfully test these large-resolution images? Thank you.


Error 80244019 when switching from a WSUS server to Legacy Update

So helping a friend use this and it seems that it can't connect to http://legacyupdate.net/v6/ClientWebService/client.asmx. Claims that it is a DNS problem but when changing it to cloudflare and running ipconfig /flushdns nothing changes. I have no idea where to start. I have added the log if that helps.

WindowsUpdateLOG.txt

Looks like it’s trying to access http://legacyupdate.net/v6/SimpleAuthWebService/SimpleAuth.asmx which I don’t implement, although I could look into it. Seems like maybe the update agent calls that when the machine was previously registered with a private WSUS server? (As opposed to a “public” one like Legacy Update or the Microsoft official server). I can see you had a different server address at the start of your logs so that could be the case.

Getting the exact same error here, Server 2003 SP2, we used to have a private WSUS but that's now been decommed, how do we undo the simpleauthwebservice bit?

Still trying to understand how SimpleAuth works so I can have the server just transparently handle this, but you could for now:

Stop Automatic Updates in services.msc
Go to C:\Windows and delete the SoftwareDistribution folder
Run regedit and go to HKEY_LOCAL_MACHINE\Software\Policies\Microsoft\Windows\WindowsUpdate, delete TargetGroup and TargetGroupEnabled if they exist
Start Automatic Updates again

I have the same issue, I followed those steps but now I have a totally different error, now I have "0x80072EFFE (-2147012866): Unknown Error" Not sure what to do to fix this.

That error means connection aborted, it can be an SSL related issue. The server hopefully shouldn't be configured to use https:// on XP/Vista/2003/2008 - try the "Check Update Server" button on the homepage to find out. SSL connection is required on Windows 7/2008 R2 and later as of a servicing stack update a few years back, so on those you'll need to use https:// and have the patches that enable all the current TLS ciphers installed (I don't know exactly which those are off the top of my head).

TLS 1.2 and TLS 1.3 :smiley:

I just implemented SimpleAuthWebService, proxying the requests to Microsoft the same way the main ClientWebService does. I've seen what looks like successful responses come through so far, but would really appreciate if you could give it a try and let me know how it goes. I've apparently forgotten the password to my test WSUS server (:zany_face:) so I haven't had a chance to test it yet.

Going to close because I think this has been solved.


Allow grouping profiles

Description of the new feature/enhancement
When creatimg multiple profiles, the list start to becoming longer and longer. Frequently, some profiles are similar (e.g. multiple VPS login profiles). In my case, as I'm developing plugins for Spigot, I use multiple versions (see screenshoot).

It would be great if I could create a group named "Spigot" and add multiple profiles there and then see the cascade in the dropdown menu when opening a new tab.

Thanks for the suggestion! Please make sure to search for duplicates when filing new issues. This is already being tracked by another issue on our repo - please refer to #1571 for more discussion.
/dup #1571


Please display TFLite numeric tensor IDs along with string IDs

In TFLite tensors have numeric IDs.
TF would sometimes print such error message when something goes wrong:

ValueError: Cannot set tensor: Dimension mismatch. Got 3 but expected 4 for input 59.

But netron currently can't help to find what input 59 is because it only shows string IDs.

Maybe this should be fixed in TensorFlow Lite to print the tensor name instead of or next to the index in error messages?

IMO it should be fixed in both. When you work with TFLite numeric IDs is what you have along with string IDs. All tensors/streams are indexed by this ID, and there's also a string ID in the tensor description. People print whatever comes to their mind, but tools like netron should print both IMO.


Hitting sqlite3 variable limit on extract_dataset

While trying to build a demo dataset from an org that has ~600 records in a custom object, CCI exceeds the sqlite3 variable limit of 999.
After building connecting cci to the org with sample records we ran the following pair of commands (Using cci 3.1.2):
cci task run generate_dataset_mapping --org demo
cci task run extract_dataset --org demo

The object that triggers the error has 10 fields in the generated mapping file, and the soql query returns 611 records (but any combination of [field count] X [record count] > 999 should reproduce this).  For the insert query generated for the import into the sqlite database that will generate a query with roughly 6110 variables, well over the hard coded limit.
The error is triggered by the CSV handler here: https://github.com/SFDO-Tooling/CumulusCI/blob/master/cumulusci/tasks/bulkdata/utils.py#L117
Instead of loading all the rows of the data file and dumping them into the insert statement, some care needs to be taken to break it up. Arguably sqlalchemy should protect against this better, but clearly they don't.

@acrosman Paul and I did a lot of work on the data loader over the last someodd months and this issue might or might not have been fixed along the way. I tried repeatedly to reproduce it and couldn't do so. Any chance you can repro it on the latest CumulusCI?

I've noticed that you all have been busy with the data.  Thanks!
I'll see if I can find an org that matches the conditions I can use to re-test.  Not even sure anymore which project I was pulling that from.  But I need to learn SnowFakery a bit more anyway, so maybe I'll spin something up that way.

Closing this for now -- if someone runs into this again, feel free to re-open.


'Click succeeded but Load Failed. Status: 'fail'' - Post click Ajax event

public void clearCompanyTree() {
		if (isElementPresent(clearCompanyTreeLink)) {
			wait.until(elementToBeClickable(clearCompanyTreeLink, "Company tree clear link"));
			clearCompanyTreeLink.click(); // <-- this line is what fails
			wait.until(a4jRequestsComplete());

The code doesn't show you a lot, I know. To see this happen make a webpage with a button. Have the button fire an Ajax event that will load a subsequent page on a random timer (say 1 to more than the phantomjs page load timeout threshold). Run a java/selenium script that clicks the button.
The clearCompanyTreeLink is a link which, on click, fires an Ajax event that makes some back end calls to clear the tree and reloads the page. On most tests we run which call this block of code it will fail with ghostdriver/phantom js with:
org.jbehave.core.failures.UUIDExceptionWrapper: When I enter customer data/john_doe.table details on the registration page.
	at org.jbehave.core.steps.StepCreator$ParameterisedStep.perform(StepCreator.java:564)
	at org.jbehave.core.embedder.StoryRunner$FineSoFar.run(StoryRunner.java:499)
	at org.jbehave.core.embedder.StoryRunner.runStepsWhileKeepingState(StoryRunner.java:479)
	at org.jbehave.core.embedder.StoryRunner.runScenarioSteps(StoryRunner.java:443)
	at org.jbehave.core.embedder.StoryRunner.runScenariosParametrisedByExamples(StoryRunner.java:412)
	at org.jbehave.core.embedder.StoryRunner.runCancellable(StoryRunner.java:301)
	at org.jbehave.core.embedder.StoryRunner.run(StoryRunner.java:219)
	at org.jbehave.core.embedder.StoryRunner.run(StoryRunner.java:180)
	at org.jbehave.core.embedder.StoryManager$EnqueuedStory.call(StoryManager.java:229)
	at org.jbehave.core.embedder.StoryManager$EnqueuedStory.call(StoryManager.java:201)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
	at java.lang.Thread.run(Thread.java:680)
Caused by: org.openqa.selenium.WebDriverException: Error Message => 'Click succeeded but Load Failed. Status: 'fail''
 caused by Request => {"headers":{"Accept":"application/json, image/png","Connection":"Keep-Alive","Content-Length":"27","Content-Type":"application/json; charset=utf-8","Host":"localhost:14222"},"httpVersion":"1.1","method":"POST","post":"{\"id\":\":wdc:1363995747367\"}","url":"/click","urlParsed":{"anchor":"","query":"","file":"click","directory":"/","path":"/click","relative":"/click","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/click","queryKey":{},"chunks":["click"]},"urlOriginal":"/session/e6ae3b50-9349-11e2-a73d-55fb5432ff8b/element/%3Awdc%3A1363995747367/click"}
Command duration or timeout: 173 milliseconds
Build info: version: '2.30.0', revision: 'dc1ef9ceb805a672f56dc49198f9ffbd4ca345c7', time: '2013-02-19 09:14:38'
System info: os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.8.2', java.version: '1.6.0_43'
Session ID: e6ae3b50-9349-11e2-a73d-55fb5432ff8b
Driver info: org.openqa.selenium.phantomjs.PhantomJSDriver
Capabilities [{platform=MAC, acceptSslCerts=false, javascriptEnabled=true, browserName=phantomjs, rotatable=false, locationContextEnabled=false, version=1.9.0, databaseEnabled=false, cssSelectorsEnabled=true, handlesAlerts=false, browserConnectionEnabled=false, webStorageEnabled=false, proxy={proxyType=direct}, nativeEvents=true, applicationCacheEnabled=false, takesScreenshot=true}]
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
	at org.openqa.selenium.remote.ErrorHandler.createThrowable(ErrorHandler.java:187)
	at org.openqa.selenium.remote.ErrorHandler.throwIfResponseFailed(ErrorHandler.java:145)
	at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:533)
	at org.openqa.selenium.remote.RemoteWebElement.execute(RemoteWebElement.java:246)
	at org.openqa.selenium.remote.RemoteWebElement.click(RemoteWebElement.java:79)
	at org.openqa.selenium.support.ui.Select.setSelected(Select.java:318)
	at org.openqa.selenium.support.ui.Select.selectByVisibleText(Select.java:116)
	at com.dandb.ecomm.test.pages.telesales.RegistrationPage.enterRegistrationInformation(RegistrationPage.java:127)
	at com.dandb.ecomm.test.steps.telesales.PurchaseSteps.enterCustomerDetailsToRegistrationPage(PurchaseSteps.java:70)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.jbehave.core.steps.StepCreator$ParameterisedStep.perform(StepCreator.java:550)
	... 14 more

The captured screenshots always show the Ajax spinner is present on the page in a pre-reload state. Manually signing into the same page immediately after failure shows the action was successful.
The same tests executed with Firefox succeed. Digging into prior reports of the same failure message show this comes from the phantomjs onPageLoad event. Digging into the ghostdriver code I've reached:
    _postClickCommand = function(req, res)

Specifically:
    else {
                        _errors.handleFailedCommandEH(
                            _errors.FAILED_CMD_STATUS.UNKNOWN_ERROR,
                            "Click succeeded but Load Failed. Status: '" + status + "'",
                            req,
                            res,
                            _session,
                            "WebElementReqHand");
                    }

This combined with what I've read in other threads suggests that phantomjs doesn't use any kind of Ajax listener in it's handling of click events. It acts on the click, looks for a page load, doesn't see it fast enough, and pukes up an error. There is some code in the same file for handling some async but it doesn't seem to be tied into click events by default.
The options I'm considering are changing the else block locally to ignore the phantomjs return (which isn't desirable but would be functional), change the test to fire the event without the click event (which needlessly complicates validating the functionality of the button in question, not to mention completely hackish), get our developers to put a special hook in for ghostdriver (idiotic and not going to happen), or work with you guys to get an Ajax listener in the correct place.
I'm a bit unclear as to the need for the page load validation at the phantomjs level, but if you feel there's technical merit to having it there I'd love to work with you on getting to handle more of the possible click event scenarios.

Java/Selenium/jbehave
Phantomjs 1.8 built
mvn installed with ghostdriver 1.0.3-dev

For anyone having this exception, a workaround:
public static void ClickAndWaitStale( this IWebElement element , DateTime limit = default(DateTime) , TimeSpan sleepBetween = default(TimeSpan) )
{
    if ( limit == default(DateTime) )
	    limit = DateTime.Now.AddSeconds( 300 );
    if ( sleepBetween == default(TimeSpan ) )
	    sleepBetween = TimeSpan.FromSeconds( 1 );

    try
    {
	    element.Click();
    }
    catch ( System.InvalidOperationException ) // Click succeeded but Load Failed
    {
    }

    while ( DateTime.Now < limit )
    {
	    try
	    {
		    element.GetAttribute( "id" );
		    Thread.Sleep( sleepBetween );
	    }
	    catch ( StaleElementReferenceException )
	    {
		    return;
	    }
    }
    throw new TimeoutException( "Timeout waiting for stale object." );
}


Provide a way to delay opening of the Floater

When using this library for tooltip components, I would like to be able to delay making the Floater visible. This is so that it replicates the behaviour of tooltips you'd normally find on desktop applications.

You can create a wrapper component to use the floater in a controlled mode with open prop, so you can delay the trigger.
Check out the controlled tooltip code in the demo.


Update hook inputs. Run cron at 1:10.

Description

Update the hook input descriptions for clarity (addresses https://github.com/StyraInc/opa-aws-cloudformation-hook/issues/35).
Change scheduled action to run at 1:10 instead of on the hour, per GitHub recommendations.

Looks like this pulled in some other changes not yet ready. Closing this PR and will open a new one.


Support YAML override and extension

you used lib does not provide this by default: https://github.com/yaml/yaml/issues/35
so we need to look into writing an extention for it if posible or add a post-proccessor

https://github.com/yaml/yaml/issues/48#issuecomment-1527806994 to https://codeberg.org/6543/xyaml


CUDA out of memory

RuntimeError: CUDA out of memory. Tried to allocate 358.00 MiB (GPU 0; 11.77 GiB total capacity; 5.35 GiB already allocated; 232.31 MiB free; 6.41 GiB reserved in total by PyTorch) my GPU is 3080Ti
I have set the batch_size to be 1,It is normal?

Yes.
Try to make your input image pair smaller.

Thanks for you reply


Floating Action Button JavaScript not working properly

Won't open or close in a HTML page:
http://jsfiddle.net/seanfrasure/tpfwsk96/

You didn't load jQuery.
Check your console sometimes..

On thanks


Update type definitions

Updated the following function signature definitions to reflect the changes made in the Q1 2023 update.

get_morgan_fp()
get_morgan_fp_as_uint8array()
get_pattern_fp()
get_pattern_fp_as_uint8array()

@adam-of-barot did you test if related examples were still working?

Currently I found no examples using these functions.
The only things I found was a call to get_morgan_fp() in docs/demo.html.

perfect @adam-of-barot , merging now :pray: , thank you!


404 on path that was never asked for

So when I go to http://localhost:9000/#/subjects/1/charges/new the app tries to also hit the json-server at http://localhost:3000/charges/new. But that states controller doesn't make any requests to or from json-server.  If I try to go that start directly via the URL, nothing loads.  If I go the state through a link it loads fine.
Here's the console error
GET http://localhost:3000/charges/new 404 (Not Found)

It seems like it's looking at the route
.state('subject.charges.new', {
  url: '/new',
  templateUrl: 'components/charges/new.html',
  controller: 'ChargeNewCtrl',
  controllerAs: 'vm'
});

If I change the URL property from '/new' to '/newz' then my console will now have this error: GET http://localhost:3000/charges/newz 404 (Not Found)
Any ideas?

Hi. Wanted to follow up on this.  Any ideas?  Thanks!

Hi @sharpmachine, yes sorry.
Don't have much ideas on this one.
What should GET http://localhost:3000/charges/new return?

It shouldn't return anything. I don't know why it's trying to. From that state, the json server is only meant to be hit when I save a new charge via a submit button. But just to view the form, I don't need anything from json-server.


Category endpoints (Multiple Features)

What this PR is for
The API's category endpoints are protected endpoints that are defined under the /category namespace
There are five endpoints which handle new category creation, view for all users categories, single category view, update and delete.
The PR also fixes the note issue of repetitive authorisation by adding an apiKey authorisation feature configuration in commit 9cb59e8.

The PR also fixes another of the noted issues on the /auth/reset-password endpoint. Previously the user could not reset their password since they were required to provide a public id which was never output.
To that effect, the users public id is provided to the user on login as shown below.

Feature Stories (Pivotal Tracker)
category creation#153856578
categories view #153855416
single category view #153856742
single category update #153857445
single category delete #153857686
What to review

Ensure the tasks listed on the story are  well and fully completed.
Ensure that the acceptance criteria is met.
Confirm the Dev Notes were adhered to.

How to review
Installation

Prerequisites: PostgreSQL>=9.6, Python>=3.6

$ createdb -U postgres yummy_rest # Set up the database first:
$ createdb -U postgres yummy_rest_test
$ git clone -b dev-category https://github.com/indungu/yummy-rest # Clone repo on required branch
$ cd yummy-recipes
$ virtualenv venv
$ source venv/bin/activate
(venv)...$ pip install -r requirements.txt
(venv)...$ python manage.py db init # create the relations
(venv)...$ python manage.py db migrate
(venv)...$ python manage.py db upgrade
(venv)...$ pytest # Ensure all test are passing
(venv)...$ python run.py

Noted issues

All the features seem to be working to required. The only problem is when user provides an letter, string or special character the category_id, the server is hit with malformed URL path and throws the builtin prompt which is in html instead of json.

Coverage increased (+8.3%) to 97.569% when pulling 9cb59e8362bf9577776e4d9cf0d5c746fbc83163 on dev-category into 5eac131787bc2b36f6e57aa2c6f1b70f3d550ae7 on develop.


Release a version

For easier access through composer (ie. not using "dev-master"), could you make a release?

Done, but I caution you.  I haven't looked at this in over 2 years. YMMV :)


Change BERT target to 0.720

It reflects changes in https://github.com/mlcommons/training_policies/pull/431


Invalid parsing of processing instructions

Hello,
In version 1.9.2, processing instructions are not correctly parsed any more.
Here is sample code for reproducing the issue.
package jsoupbug;

import java.util.List;
import org.jsoup.Jsoup;
import org.jsoup.nodes.Document;
import org.jsoup.nodes.Node;
import org.jsoup.parser.Parser;

public class JsoupBug {

    private static final String XML = "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<?myProcessingInstruction My Processing instruction.?>";

    public static void main(String[] args) {
        Document document = Jsoup.parse(XML, "", Parser.xmlParser());
        document.outputSettings().prettyPrint(false);
        List<Node> nodes = document.childNodes();
        Node node = nodes.get(2);
        String outerHtml = node.outerHtml();
        System.out.println(outerHtml);
    }

}

When I correctly understand the spec (https://www.w3.org/TR/REC-xml/#sec-pi) spaces are valid characters for processing instructions, but Jsoup messes things up.
With version 1.9.2 this prints:
<?myprocessingInstruction my="" processing="" instruction.=""?>
However in 1.9.1 the behavior is as I would expect:
<?myProcessingInstruction My Processing instruction.?>

Were you able to fix this issue? I can replicate the same on 1.12.1

Were you able to fix this issue? I can replicate the same on 1.12.1

@jinojohnd No unfortunately I was  not able to fix this.

@jinojohnd No unfortunately I was  not able to fix this.

Reviewed and agree that this is a bug. The root cause is that we treat XML processing instructions as an odd hybrid of a comment and of a tag with attributes. Sometimes we want the attributes (e.g. to understand encoding options) and other times it'd be better to treat it as an opaque string (as in this example)
Would suggest that the fix would be to treat these as boolean attributes so to emit them without the empty ="" component.


Add displayArrayKey Option for Rendering Array Keys in JSONViewer

Greetings,
I have implemented a new feature in the JSONViewer, introducing an option named displayArrayKey. This feature aims to enhance the user experience by providing additional flexibility in visualizing JSON data.
Feature: 'displayArrayKey' Option
The displayArrayKey option, when set to false, prevents the rendering of the keys of an array and appends a colon to the end of the line. This results in a cleaner and more concise output for users who find array keys unnecessary in certain contexts.
Usage:
<JsonView
  src={object}
  displayArrayKey={false}
/>

Enabled (without keys):

Disabled (with keys):

Use Case:
This addition is beneficial for developers seeking a streamlined representation of JSON data, especially when handling large arrays where the keys might not contribute significantly to comprehending the data structure.
Documentation:
The documentation has been updated to encompass the new displayArrayKey option, elucidating its function and effect on the JSON data representation.
Conclusion:
I am confident that this feature will serve as a valuable enhancement to the project by offering more versatility in displaying JSON data. I look forward to your feedback and am open to making any necessary modifications.
Thank you for considering this contribution. Looking forward to a positive review and eventual merge.
Best Regards,
Nicholas

I noticed the new comma added and had a thought: why do we add the prop viewMode: viewer or json? Which means json mode has the comma symbol, but the viewer mode not.

That sounds like a good idea, I'll implement the comments!

I started changing right now, do you think with the view mode 'viewer' or 'json' - do we need the displayArrayKey option at all?

I introduced now the new option viewMode with options['json', 'viewer'] where 'viewer' is the default one. Once  'json' is selected, commas are appended to the end of the line, whereas 'displayArrayKey' only the display of array keys disabled.
I removed the package-lock and used pnpm (missed that before)
I also removed the new file and adapted the existing 'name-value.tsx'. Please provide me some feedback 😄

Sorry, I am on vacation.


Chat Telemetry: Restores prompt and response text recording

Previously, chat telemetry events were not capturing promptText and responseText due to the asynchronous nature of the truncatePromptString function, which was modified in a recent pull request(https://github.com/sourcegraph/cody/pull/5231).
Now, we have added the proper await calls when using truncatePromptString, re-enabling the collection of this data for chat telemetry events.
Key changes:

Added await to ChatController where truncatePromptString is being used
Made addBotMessage an async func

Test plan
Tested locally and verified promptText and responseText are being recorded again.
https://github.com/user-attachments/assets/b3952819-0945-4162-baf7-d98704aec21d

Changelog

Looks good to me! For future work, it'd be great to have a couple unit tests for telemetry. That way, we can prevent similar regressions from happening again. And... it makes things easier on the data team, since the unit test will block a PR from being merged, and that developer needs to fix the telemetry integration!

Thanks @jtibshirani, totally agree. We have built-out telemetry unit tests within the Cody VSCode E2E Tests (example here) that validate the correct eventNames (feature/action) are being recorded. In this case, the issue was within the metadata of the event not being recorded (one layer deeper) which is why it got through. We plan to address this gap with @RXminuS's new E2E Testing framework )(thread), which will allow us to test this granularity within CI.
Thanks for the feedback and review on this PR!


Set OvfUpdateIntervalInMinutes config to 1 during deploy

The deploy script waits until the OVF file is written to the storage domain. Sometimes, probably because of a race, the OVF write is not triggered by update VM and the deploy script would have to wait for 60 minutes.
This patch changes the setting during the deploy, so the OVF is stored every minute.
Bug-Url: https://bugzilla.redhat.com/1644748

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.


rename action types

Prefix Action Types with APOLLO_
#210

Looks great!

Can you add to the change log please? And in the future tonight be easier to keep the default checklist.

Will get to it when i am home! Where is the default checklist?

https://github.com/apollostack/apollo-client/blob/master/.github/PULL_REQUEST_TEMPLATE.md
It should show up as the default description when you make a new PR.

@stubailo All done thank you!

Looks good to me, let's merge after CI passes!

Published in 0.3.9!


Fix unsqueeze with None

Proposed changes
Fix bug unsqueeze with None #898.
Checklist

[x] I have read the CONTRIBUTING document
[x] I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have updated the necessary documentation (if needed)

You can just apply this quick patch! Thanks for finding the issue and working on it!
a.patch

You can just apply this quick patch! Thanks for finding the issue and working on it! a.patch

Oh I see, thats cool.

Could you please run the formatting hooks, looks like they failed the test

Closes #898


Download the blob generated

Hey, first of all, great project!
I've been trying to figure out most stuff, but can you help me in understanding certain parts?
I am trying to download the blob that gets rendered, but nothing works.
I try to convert the blob to a file, then just try downloading it, but the file doesn't play for some reason.
It'll be great help if you could help me with this.

nvm, figured it out!
thanks a lot again for the project.


Cleanup clouddns package

Replace deprecated dns.New function with dns.NewService
Remove deprecated oauth2.NoContext
Fix unused err value in test

Signed-off-by: Ingo Gottwald<EMAIL_ADDRESS>
What this PR does / why we need it: Code maintenance in the clouddns package (see above)
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

NONE

Thanks for this PR 😄 I'm going to assign this to the 'Next' milestone and take a look in the coming days, once we've got the v0.11 release out (so that this can land in v0.12).
/milestone Next
/ok-to-test

/assign

Thanks for this :smile:
/lgtm

/approve


Gift Card Support

It would be interesting to have Gift Card support in Daedalus, allowing gift card creation and tools to empty a gift card. I wrote a short article about Gift Cards on Reddit, and I made a live demo of a gift card generator here.
Here are the relevant points:

Gift cards are paper wallets intended to be gifted (fancy documents bundled with instruction and mnemonic words). Gift cards are potentially beneficial for the ecosystem since they allow to easily gift Cardano to people who don’t own a wallet or an exchange account (thus good for adoption).
The main risk with Gift Cards is that the person receiving the funds could use the restored wallet as its own (thus putting more funds on an insecure wallet).

Here are three Gift Card features that could be integrated into Daedalus:

Gift Card Generation: A menu to generate a paper wallet bundled with instructions.
Gift Card Restoration: A menu to automatically restore and empty a gift card to a secure wallet.
Gift Card Detection: A feature that detect when a gift card is restored (in the classic wallet restore menu) and propose a Gift Card restoration (2.) instead.

Concerning (3.): one way to detect if a restored wallet is a Gift Card would be to generate every Gift Card with 'gift' as their first word.
However, it would reduce the wallet possibilities from 2048^24 to 2048^23 (a potential security risk).
I posted a Gift Card Standard proposal on GitHub, which could be used as a joint base for different services willing to integrate gift cards.

I'm trying to submit a CIP for a technical specification as suggested by one of Yoroi's developers.

Thanks @RNDfr, we'll keep an eye on the CIP.


Using the step argument raises an error for WandbLogger's log_image

🐛 Bug
When using the WandbLogger log_image method, adding the step argument raises an error:
  File "/home/nathan/work/these/engine/venv/lib/python3.8/site-packages/pytorch_lightning/loggers/wandb.py", line 417, in log_image
    if len(v) != n:
TypeError: object of type 'int' has no len()

To Reproduce

from pytorch_lightning.loggers import WandbLogger
import torch
logger=WandbLogger()
fake_img = torch.randn((50,50))
logger.log_image(key='fake', images=[fake_img], step=0)

Expected behavior
The image is logged with appropriate step in Wandb.
Environment

PyTorch Lightning Version (e.g., 1.5.0): stable

Additional context
Can be easily fixed by swapping a few lines in the method.
cc @awaelchli @morganmcg1 @AyushExel @borisdayma @scottire @manangoel99

hey @NathanGodey
good catch! mind send a PR?


input_filter.py throws a type error when filter type does not exist

How to reproduce the issue:

run python -m pyfda.input_widgets.input_filter
(Lowpass, FIR, Equiripple should be selected)
select 'Minimum Order'
select 'Bandpass' ... and:

379:            self.fo = foList[0] # use first list entry from filterTree
TypeError: 'dict_keys' object does not support indexing
Here, a minimum order bandpass is not contained in the filter dict. Consequently, it should not be selectable at all. But it is and it produces the error above.

fixed in v0.1rc2


New features to support process-level logging

This is a set of features to allow a honeycomb capturer to be used instead of stdout/stderr for a process.
This will allow us to add features to procmon that will let us capture all output from all tasks and send it to honeycomb -- even panic logs. A PR will be incoming for that.
This was a surprisingly tricky set of code to write -- in order to be able to process JSON objects in real time, it was necessary to write a parser that could both extract those objects and that would not fail in case some of the stream wasn't JSON. It was also necessary to develop a circular buffer that could safely allow an io.Writer to write data from one task and an io.Reader that could read the data at the same time, and that would block on multiple reads while waiting for more data to arrive.
There's a fair bit of test code in place.

Now that I've responded to most of this feedback in context, I'm going to move this to the writers repo as suggested and then close this.


Typescript 3.6.4 not on npm

Could you please get 3.6.4 published on npm with the following fix that has already been merged to the 3.6 branch: https://github.com/microsoft/TypeScript/commit/46ccaa29d64dc7614de5e42a0ac20c6990f32210 thank you!

TypeScript Version:  3.6.3

Search Terms:
release, npm
Related Issues:
blocks https://github.com/angular/angular/pull/32946

Major bonus points if we can manage to include https://github.com/microsoft/TypeScript/pull/33847 :-)

Sorry about the delay! 3.6.4 is published, and we'll have a 3.6.5 out as soon as #33847 is merged.

Thanks Daniel!

Ugh, there was a problem with the publish. I'm on it.

Done!

thank you @DanielRosenwasser !


Problem with Right to Left direction

when direction is rtl the background image of hexagon is messed up, an easy fix can be just adding direction: ltr to the .hexagon class in generated css

This tool assumes direction: ltr as it does other common defaults like box-sizing: border-box. I'd like to keep the generated css a minimal as possible. Those requiring direction: ltr specifically can add it to their own css as needed.


validates_format_of doesn't work with localized fields.

The currently used ActiveModel implementation checks the provided regular expression against the fields raw value, {"en":"actual value"}, instead of the actual value, actual value.

I've actually already fixed it locally — I'll just have to write some tests for it and then I'll post a push request.

Oh nice... Thanks.


possible bug: dragging of the last element results in moving other elements / drop area if there is no items in a list

I use your library in a polymer.
An example of what I have: http://plnkr.co/edit/ZaqpEO
PROBLEM 1
if you dragging last element to the miiddle of another list - all 2 items are moving to that list.... should not happen as I understand. Bug?
PROBLEM 2
here drop area of list1 disappears when you drag all items to list 2 and you can not drag it back anymore.

here is solution for the main question http://plnkr.co/edit/VY9wTh
second one is still open

I have the same issue here. It seems that in Problem 1, if you drag item 2 to the right list,  you are adding item 1 to the binding array of dom-repeat of the second list.
Although the appearance result in [], [1,2,3,4] but in fact, the binding arrays of the two dom-repeats are [2], [1,3,4]

I think a way to solve Problem 1 is to add draggable attribute to the sortable-js like in your example,
 will solve the problem.
However, another problem may relate to this is when we have a nested sortable relationship. I may have some example later on.

well that work. thx
here is plunk http://plnkr.co/edit/C2e76C


service discovery registry has bug

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[ ] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 27.x
Operating System version: *
Java version: 1.8

Actual Result
provider 在进行服务自省注册的时候，会通过url判断是否需要注册，但是开启了简化注册中心url之后，side=provider被移除了，导致不能导出url。我觉得这里需要重新梳理
    protected boolean shouldRegister(URL providerURL) {

        String side = providerURL.getParameter(SIDE_KEY);

        boolean should = PROVIDER_SIDE.equals(side); // Only register the Provider.

        if (!should) {
            if (logger.isDebugEnabled()) {
                logger.debug(String.format("The URL[%s] should not be registered.", providerURL.toString()));
            }
        }

        return should;
    }

I think it could be like DynamicDirectory

        this.shouldRegister = !ANY_VALUE.equals(url.getServiceInterface()) && url.getParameter(REGISTER_KEY, true);
        this.shouldSimplified = url.getParameter(SIMPLIFIED_KEY, false);

let me have a look.

I think it could be like DynamicDirectory

        this.shouldRegister = !ANY_VALUE.equals(url.getServiceInterface()) && url.getParameter(REGISTER_KEY, true);
        this.shouldSimplified = url.getParameter(SIMPLIFIED_KEY, false);

i think you are right. i will do a pr to solve it.

But I think it might be a good idea to add side_key to the streamlined url

ok，这里有没有必要再进行判断是值得思考的，因为服务端都需要注册，而消费端的判断逻辑是在directory 里的。可以考虑下掉这里的判断
发自我的iPhone
------------------ Original ------------------
From: xiaoheng1 @.>
Date: 周四,5月 13,2021 7:40 下午
To: apache/dubbo @.>
Cc: wangxw666 @.>, Author @.>
Subject: Re: [apache/dubbo] service discovery registry has bug (#7755)
I think it could be like DynamicDirectory
this.shouldRegister = !ANY_VALUE.equals(url.getServiceInterface()) && url.getParameter(REGISTER_KEY, true);         this.shouldSimplified = url.getParameter(SIMPLIFIED_KEY, false);
i think you are right. i will do a pr to solve it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

这样比较简单，但是我感觉这样做是不是不符合设计的原则那？是在注册的时候保留side_key还是判断以后再移除那
发自我的iPhone
------------------ Original ------------------
From: xiaoheng1 @.>
Date: 周四,5月 13,2021 7:55 下午
To: apache/dubbo @.>
Cc: wangxw666 @.>, Author @.>
Subject: Re: [apache/dubbo] service discovery registry has bug (#7755)
But I think it might be a good idea to add side_key to the streamlined url
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

这样比较简单，但是我感觉这样做是不是不符合设计的原则那？是在注册的时候保留side_key还是判断以后再移除那 发自我的iPhone
…
------------------ Original ------------------ From: xiaoheng1 @.> Date: 周四,5月 13,2021 7:55 下午 To: apache/dubbo @.> Cc: wangxw666 @.>, Author @.> Subject: Re: [apache/dubbo] service discovery registry has bug (#7755) But I think it might be a good idea to add side_key to the streamlined url — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

If we use this.shouldRegister = !ANY_VALUE.equals(url.getServiceInterface()) && url.getParameter(REGISTER_KEY, true); This judgment will cause the service to fail to subscribe in the streamlined url scenario

becase shouldRegister is always true by default. and shouldSubscribe always is false.

这样的话，如果使用接口级别注册，相当于注册中心又增加了冗余数据。
发自我的iPhone
------------------ Original ------------------
From: xiaoheng1 @.>
Date: 周四,5月 13,2021 8:00 下午
To: apache/dubbo @.>
Cc: wangxw666 @.>, Author @.>
Subject: Re: [apache/dubbo] service discovery registry has bug (#7755)
这样比较简单，但是我感觉这样做是不是不符合设计的原则那？是在注册的时候保留side_key还是判断以后再移除那 发自我的iPhone
…
------------------ Original ------------------ From: xiaoheng1 @.> Date: 周四,5月 13,2021 7:55 下午 To: apache/dubbo @.> Cc: wangxw666 @.>, Author @.> Subject: Re: [apache/dubbo] service discovery registry has bug (#7755) But I think it might be a good idea to add side_key to the streamlined url — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.
If we use this.shouldRegister = !ANY_VALUE.equals(url.getServiceInterface()) && url.getParameter(REGISTER_KEY, true); This judgment will cause the service to fail to subscribe in the streamlined url scenario
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

shouldRegister 和shouldSubscribe对提供者和消费者是相反的行为
发自我的iPhone
------------------ Original ------------------
From: xiaoheng1 @.>
Date: 周四,5月 13,2021 8:02 下午
To: apache/dubbo @.>
Cc: wangxw666 @.>, Author @.>
Subject: Re: [apache/dubbo] service discovery registry has bug (#7755)
becase shouldRegister is always true by default. and shouldSubscribe always is false.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

When the consumer is subscribing, the url is also streamlined, then the side information is lost, whether registration will return true, which will cause the consumer to not subscribe

ok，所以我认为不应该使用sidekey判断，保留意见 ٩(❛ัᴗ❛ั⁎)
发自我的iPhone
------------------ Original ------------------
From: xiaoheng1 @.>
Date: 周四,5月 13,2021 8:09 下午
To: apache/dubbo @.>
Cc: wangxw666 @.>, Author @.>
Subject: Re: [apache/dubbo] service discovery registry has bug (#7755)
When the consumer is subscribing, the url is also streamlined, then the side information is lost, whether registration will return true, which will cause the consumer to not subscribe
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Well, but after simplifying the url, there is really no way to judge whether it should be registered.
Do you have any good suggestions?

Let me think for a moment


file and password validation not working ?

Hi ,
I have found that the file and password validation are not working and createing problems .
As of now , I have changed the input function to below and skipped the validation for file and password in the bllim form builder .
But Is there any way to perform these validations .
Also Every time , I run composer ..I have to manually include this code . Can you do something about it .
public function input($type, $name, $value = null, $options = [])
{
	if($type!='file' && $type!='password') {
	$options = $this->laravelToJquery($name) + $options;
	}
	return parent::input($type, $name, $value, $options);
}

Hi, I checked but i didn't see anything wrong. Can you send how did you use it?


__webpack_require__.t is not a function

When using Webpack to build for the node target, you currently may hit the following error:
TypeError#1: __webpack_require__.t is not a function
  at call.__webpack_require__._LM_.__webpack_require__.__webpack_require__ (/.../dist/webpack/node-thread/bundle.js:27185:171)

Can be reproduced with configuration from https://github.com/MetaMask/snaps/pull/2662

__.t turns out to be a rarely needed wrapper for module formats interop


Correct the product/flow creation cm-editor in darkmode:

The dark mode CM-Editor looks weird and blends with the background in darkmode:

New look:

PR Raised:
https://github.com/entdec/satis/pull/159


Langium 3.1: Changes in inference

we have something like
Primary infers Expression:
    {infer Parenthesis} '(' expr=Expression ')' |
    ....
    NumberLiteral |
    BooleanLiteral |
    StringLiteral |
    ....

in our grammar.
with langium 3.1 we now see following compile error
src/grammars/generated/ast.ts(1615,18): error TS2320: Interface 'Parenthesis' cannot simultaneously extend types 'BooleanLiteral' and 'NumberLiteral'.
  Named property 'value' of types 'BooleanLiteral' and 'NumberLiteral' are not identical.
src/grammars/generated/ast.ts(1615,18): error TS2320: Interface 'Parenthesis' cannot simultaneously extend types 'BooleanLiteral' and 'StringLiteral'.
  Named property 'value' of types 'BooleanLiteral' and 'StringLiteral' are not identical.

export interface StringLiteral extends AstNode {
    readonly $container: .......;
    readonly $type: 'Parenthesis' | 'StringLiteral';
    value: string;
}

before in langium3 it was
export interface StringLiteral extends AstNode {
    readonly $container: ......;
    readonly $type: 'StringLiteral';
    value: string;
}

=> should the moveup also consider the type?

similar problem at other children with same name and different types


Oracle WebLogic Server Cluster deployment failed

Problem description
Failed to deploy Oracle WebLogic Server Cluster from Azure portal, the deployment of embedded template clusterLinkedTemplate failed with the following error messages:
{
  "code": "DeploymentFailed",
  "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
  "details": [
    {
      "code": "VMExtensionProvisioningError",
      "message": "VM has reported a failure when processing extension 'newuserscript'. Error message: \"Enable failed: processing file downloads failed: failed to download file[1]: failed to download file: unexpected status code: actual=404 expected=200\"\r\n\r\nMore information on troubleshooting is available at https://aka.ms/VMExtensionCSELinuxTroubleshoot "
    },
    {
      "code": "VMExtensionProvisioningError",
      "message": "VM has reported a failure when processing extension 'newuserscript'. Error message: \"Enable failed: processing file downloads failed: failed to download file[1]: failed to download file: unexpected status code: actual=404 expected=200\"\r\n\r\nMore information on troubleshooting is available at https://aka.ms/VMExtensionCSELinuxTroubleshoot "
    }
  ]
}

How to reproduce
Follow steps below to reproduce the issue:

Open Oracle WebLogic Server Cluster offer.
In "Basics" page: Fill in value for the required field(s). Click "Review + Create". Click "Create".
Wait until the deployment of embedded template clusterLinkedTemplate failed.

Potential RCA
The clusterTemplate will look for some files from ../../../../../utilities/custom-hostname-verifier/, which seems to depend on the recent changes of parent pom com.microsoft.azure.iaas:azure-javaee-iaas-parent:

https://github.com/oracle/weblogic-azure/blob/main/weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/clusterTemplate.json#L530-L533

Specifically, the dependent parent pom com.microsoft.azure.iaas:azure-javaee-iaas-parent has been updated to 1.0.15 in order to add utilities directory from WebLogic offers, see PR-24. However, the old version 1.0.13 and its commit hash 13fe6ec487024eb61355d661ab5700ae90cb0a8f are NOT updated accordingly:

https://github.com/oracle/weblogic-azure/blob/main/weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/pom.xml#L20

Should be updated to 1.0.15?

https://github.com/oracle/weblogic-azure/blob/main/.github/workflows/buildWlsVm4CcArtifact.yml#L23

Should be updated to 062fe0eb4e72012ead98c23e1a1b2c6259e7e7c4?

It looks like all upstream WebLogic offers that're impacted by the PR-24 should be checked, verified and updated appropriately.

PR created https://github.com/oracle/weblogic-azure/pull/131 yet to be merged.

@edburns PR https://github.com/oracle/weblogic-azure/pull/131 should be merged and released to Partner Center ASAP, since the offer from marketplace or azure portal has already broken.

The new release of WLS cluster on Azure including the fix is available. I tested it and all work as expected. Closing the issue now.


Better error recovery for unterminated arrays

Another attempt to address #5182. Still not sure it does everything we want, but unlike my last attempt (#5269) I think it's unlikely to disrupt current desired behaviors.
The strategy this time is to identify a whole bunch of tokens that can't possibly occur right after tLBRACK aref_args, and add an erroring rule when one of them occurs. I found the list of tokens that works here largely by trial and error (let's throw some more tokens in and see if we get any SR/RR conflicts), but intuitively I think the list makes sense: mostly they're "bracket-closing" tokens like ) and end.
Example:
# typed: true

class A
  def f
    [1,
  #   ^ error: unexpected token ","
  # ^ error: unterminated "["
    puts "hi"
  end
  def g
    [
  # ^ error: unterminated "["
  end
  def h
    puts "ho"
  end
end

class B
  def q
    puts "ho"
    [
  # ^ error: unterminated "["
  end
  def r
    puts "hi"
  end
  def s
    puts ([] + [)
             # ^ error: unterminated "["
  end
  def t
    puts "hi"
  end
end

Parse tree and output before:
s(:begin)
test/testdata/parser/error_recovery/unterminated_array.rb:5: unexpected token "," https://srb.help/2001
     5 |    [1,
              ^

test/testdata/parser/error_recovery/unterminated_array.rb:29: unexpected token ")" https://srb.help/2001
    29 |    puts ([] + [)
                        ^
Errors: 2

Parse tree and output after:
s(:begin,
  s(:class,
    s(:const, nil, :A), nil,
    s(:begin,
      s(:def, :f, nil,
        s(:array,
          s(:const, nil, :<ErrorNode>))),
      s(:def, :g, nil,
        s(:array)),
      s(:def, :h, nil,
        s(:send, nil, :puts,
          s(:str, "ho"))))),
  s(:class,
    s(:const, nil, :B), nil,
    s(:begin,
      s(:def, :q, nil,
        s(:begin,
          s(:send, nil, :puts,
            s(:str, "ho")),
          s(:array))),
      s(:def, :r, nil,
        s(:send, nil, :puts,
          s(:str, "hi"))),
      s(:def, :s, nil,
        s(:send, nil, :puts,
          s(:begin,
            s(:send,
              s(:array), :+,
              s(:array))))),
      s(:def, :t, nil,
        s(:send, nil, :puts,
          s(:str, "hi"))))))
test/testdata/parser/error_recovery/unterminated_array.rb:5: unexpected token "," https://srb.help/2001
     5 |    [1,
              ^

test/testdata/parser/error_recovery/unterminated_array.rb:5: unterminated "[" https://srb.help/2001
     5 |    [1,
            ^

test/testdata/parser/error_recovery/unterminated_array.rb:11: unterminated "[" https://srb.help/2001
    11 |    [
            ^

test/testdata/parser/error_recovery/unterminated_array.rb:22: unterminated "[" https://srb.help/2001
    22 |    [
            ^

test/testdata/parser/error_recovery/unterminated_array.rb:29: unterminated "[" https://srb.help/2001
    29 |    puts ([] + [)
                       ^
Errors: 5

Motivation
Better error recovery, better pizza. (pizza == IDE responsiveness)
Test plan
See included automated tests.

But ultimately, I really, really think that the final solution for unmatched [ brackets is going to involve using the indentation-aware techniques that https://github.com/sorbet/sorbet/pull/5000 is going to introduce.
I have a hunch that we can substantially improve on the results that this PR achieves if we use that approach instead. Do you want to chat more about this?

Sure! Let's chat about it today. If you think the indentation-aware techniques are going to handle things better, there's no need for redundancy here.

@jez: I switched from parse-tree to desugar-tree, and commented on why I think expr_end is probably the right state to end up in when we rewind, so figured I'd ask for another look when you get a chance.

:facepalm: Sorry, forgot to actually push :)

can you add these tests I suggested? i'd like to at least record the state of the world

Will do!


GDExtension: pointer parameters of type real are declared as float* in JSON

Tested versions
4.2.2
System information
N/A
Issue description
The virtual function PhysicsDirectSpaceState2D::_cast_motion() uses pointer parameters, and it's unclear if the type is declared correctly in the API spec.
The extension_api.json entry for that function looks as follows:
{
    "name": "_cast_motion",
    "is_const": false,
    "is_static": false,
    "is_vararg": false,
    "is_virtual": true,
    "return_value": {
        "type": "bool"
    },
    "arguments": [
        {
            "name": "shape_rid",
            "type": "RID"
        },
        {
            "name": "transform",
            "type": "Transform2D"
        },
        {
            "name": "motion",
            "type": "Vector2"
        },
        {
            "name": "margin",
            "type": "float",
            "meta": "float"
        },
        {
            "name": "collision_mask",
            "type": "int",
            "meta": "uint32"
        },
        {
            "name": "collide_with_bodies",
            "type": "bool"
        },
        {
            "name": "collide_with_areas",
            "type": "bool"
        },
        {
            "name": "closest_safe",
            "type": "float*"
        },
        {
            "name": "closest_unsafe",
            "type": "float*"
        }
    ]
},

So both pointers are declared as float*.
float usually means 64-bit floating point (C++ double), unless it's accompanied by meta = float key-value, see e.g. margin argument.
However, the method on C++ side is declared as real, which is 32-bit floating point in single precision builds:
https://github.com/godotengine/godot/blob/1567a498cbe0d2aeb73a9d2a67d3ac6b22b340a1/servers/physics_2d/godot_space_2d.h#L54
And I also found this:
https://github.com/godotengine/godot/blob/1567a498cbe0d2aeb73a9d2a67d3ac6b22b340a1/servers/extensions/physics_server_2d_extension.h#L133
CC @Ughuuu, who noticed this and had a crash in this code.

I would expect that if a type is declared as T* (here float*) in the JSON, that it behaves like a pointer to T.
Otherwise, a meta could be used, just like value types.
Is this assumption wrong?
Steps to reproduce
Override _cast_motion virtual method (e.g. in Rust bindings), try to dereference the f64 pointers -> UB.
Minimal reproduction project (MRP)
N/A

I did a little bit of testing, and it looks like it'll use a "type" of "double*" if it's 64-bit. So, currently, we have "float*" to indicate 32-bit, and "double*" to indicate 64-bit.
I agree that that is inconsistent with how we're using "float" elsewhere to mean either 32-bit or 64-bit, depending on what is in the "meta" (defaulting to 64-bit).
But it is consistent with other pointer types! For example, integer pointers use types like "int32_t*", rather than something like {"type": "int*", "meta": "int32"}.
So, we could:

Decide that pointer types are special, and "float*" is 32-bit while "float" is 64-bit by default with "meta". This is a little weird, but if we actually documented extension_api.json it wouldn't be that big of a deal. :-)

Change the way that pointer types are done so that we instead do something like {"type": "float*", "meta": "float"}. However, if we do this, we should probably do it for all the pointer types (including the integer and char types), which I think would amount to a pretty large source compatibility breakage. (I wonder if we should version extension_api.json to account for inevitable changes?)

I guess my personal inclination is to go with option 1, but I could be convinced of option 2 if we can come up with a way to minimize the compat issues.

Ah OK, so it's not actually wrong, just a bit unintuitive 😉
The problem is, even if we went with 2), we would still need to understand 1) because of older versions (godot-rust supports all Godot versions). So we'd need to have two code paths.
On the other hand, people who are writing newer bindings may stumble upon this, too... Maybe documentation would really solve this? What would be a good place for this to be documented (I assume godot-docs repo, but where)?

Maybe documentation would really solve this? What would be a good place for this to be documented (I assume godot-docs repo, but where)?

There has been lots of discussion about how to re-arrange the structure of the GDExtension docs, however, for now it looks like we're putting everything under tutorials/scripting/gdextension/, so I think putting it there for now makes sense.
Even the PRs documenting the structure of .gdextension files and George's monumental C example are adding their pages in that same place. We can move all those pages later if we come up with a better way to organize it.
Anyway, it would be really amazing to have some documentation for the extension_api.json file!

Discussed at the GDExtension meeting and we decided to stick with the current representation in the extension_api.json, because the "meta" for normal floats is more of "advice" for the binding generator since we always encode the data as double, however, for pointers the difference between float* and double* change the underlying type of the data, so it does make sense that these two things are represented differently.
So, I guess the next step is documenting these types in the extension_api.json.


Error on import-api variant creation

Describe the bug
Not sure if it is a bug or intended behavior, but when trying to import sunrise products data(found here:  https://github.com/commercetools/commercetools-sunrise-data/tree/master/data), sending variant request fail because the variant key is apparently less than 10?
To Reproduce
Create variants with variant-key a number less than 10
The error received is very cryptic :
Client error response [url] https://import.europe-west1.gcp.commercetools.com/XXXX [status code] 400 [reason phrase]

Expected behavior
Provide a clear error message or remove the less that 10 restriction.

Hi,
could you please provide a working code snippet to reproduce your issue please. Especially as I'm assuming this has nothing to do with the SDK itself, but limitations by the API.
Besides could you try it with the version 2.0.0-beta.2. This one has also a better message string in case of exceptions, so that you don't have to setup a logger upfront.

Hi @jenschude , here is a snippet simulating the error:
       def productRequest = ProductImportRequestBuilder.of()
                .resources([ProductImportBuilder.of()
                                    .key("product1")
                                    .name(LocalizedStringBuilder.of().values(["de-DE" : "produkt1"]).build())
                                    .slug(LocalizedStringBuilder.of().values(["de-DE": "PRD1"]).build())
                                    .productType(ProductTypeKeyReferenceBuilder.of().key("another").build())
                                    .description(LocalizedStringBuilder.of().values(["de-DE": "sehr tolles Produkt2"]).build())
                                    .build()]
                ).build()
        client.withProjectKeyValue(projectKey).products()
                .importSinkKeyWithImportSinkKeyValue("products")
                .post(productRequest)
                .executeBlocking()
                .getBody()

        def variantRequest = ProductVariantImportRequestBuilder.of()
                .resources([ProductVariantImportBuilder.of()
                                    .key("8")
                                    .sku("12345")
                                    .product(ProductKeyReferenceBuilder.of().key("product1").build())
                                    .isMasterVariant(true)
                                    .build()]
                ).build()
        client.withProjectKeyValue(projectKey).productVariants()
                .importSinkKeyWithImportSinkKeyValue("variants")
                .post(variantRequest)
                .executeBlocking()
                .getBody()

variants and products sinks are created beforehand. In this case you will receive error 400 with no reason specified. If you replace "8" with "18" it will work!

Hi @jenschude Is there any update regarding this issue?  I appreciate if you could let us know as it is hindering our use case.

Hi @jenschude Is there any update regarding this issue?  I appreciate if you could let us know as it is hindering our use case.

I was starting to take a look at it. But couldn't yet reproduce it as I had already errors before importing the variant.
Could you please check maybe with the more recent SDK version 2.0.0 as the exception should give more insights

I was starting to take a look at it. But couldn't yet reproduce it as I had already errors before importing the variant.
Could you please check maybe with the more recent SDK version 2.0.0 as the exception should give more insights

So finally got it "working" with this exception.
As it's possible to set the variant key with one character with the product API seems to be an issue with the import API. So i will forward it to the respective team.
detailMessage: Client error response [url] https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant [status code] 400 [reason phrase]
summary: POST https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant failed  with response code 400 on 2021-01-12T21:10:49.097Z
http response formatted body: {
  "statusCode" : 400,
  "message" : "Referenced resource does not exist",
  "errors" : [ {
    "constraint" : "UnresolvedReference_operationId_fkey"
  } ]
}
http response: io.vrap.rmf.base.client.ApiHttpResponse@7a9bbe58[statusCode=400,headers=[{key=access-control-expose-headers, value=WWW-Authenticate,Server-Authorization}, {key=alt-svc, value=clear}, {key=cache-control, value=no-cache}, {key=content-length, value=130}, {key=content-type, value=application/json; charset=utf-8}, {key=date, value=Tue, 12 Jan 2021 21:10:49 GMT}, {key=vary, value=origin}, {key=via, value=1.1 google}],textInterpretedBody={"statusCode":400,"message":"Referenced resource does not exist","errors":[{"constraint":"UnresolvedReference_operationId_fkey"}]}]
SDK: 1.0.0-20210112211046
endpoint: POST https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant
Java: 1.8.0_252
cwd: /Users/jensschulze/workspace/commercetools-java-sdks/commercetools/commercetools-sdk-java-importapi
request: io.vrap.rmf.base.client.ApiHttpRequest@cdaf0ba[method=POST,uri="https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant",headers=[{key=X-Correlation-ID, value=***********/00981f91-962a-4163-81c4-117d6bfe9ad9}, {key=Authorization, value=**removed from output**}],textInterpretedBody={"resources":[{"key":"9","sku":"12345","isMasterVariant":true,"product":{"key":"random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d","typeId":"product"}}],"type":"product-variant"}]
http request: io.vrap.rmf.base.client.ApiHttpRequest@cdaf0ba[method=POST,uri="https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant",headers=[{key=X-Correlation-ID, value=***********/00981f91-962a-4163-81c4-117d6bfe9ad9}, {key=Authorization, value=**removed from output**}],textInterpretedBody={"resources":[{"key":"9","sku":"12345","isMasterVariant":true,"product":{"key":"random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d","typeId":"product"}}],"type":"product-variant"}]
http request formatted body: {
  "resources" : [ {
    "key" : "9",
    "sku" : "12345",
    "isMasterVariant" : true,
    "product" : {
      "key" : "random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d",
      "typeId" : "product"
    }
  } ],
  "type" : "product-variant"
}

io.vrap.rmf.base.client.error.BadRequestException: detailMessage: Client error response [url] https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant [status code] 400 [reason phrase]
summary: POST https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant failed  with response code 400 on 2021-01-12T21:10:49.097Z
http response formatted body: {
  "statusCode" : 400,
  "message" : "Referenced resource does not exist",
  "errors" : [ {
    "constraint" : "UnresolvedReference_operationId_fkey"
  } ]
}
http response: io.vrap.rmf.base.client.ApiHttpResponse@7a9bbe58[statusCode=400,headers=[{key=access-control-expose-headers, value=WWW-Authenticate,Server-Authorization}, {key=alt-svc, value=clear}, {key=cache-control, value=no-cache}, {key=content-length, value=130}, {key=content-type, value=application/json; charset=utf-8}, {key=date, value=Tue, 12 Jan 2021 21:10:49 GMT}, {key=vary, value=origin}, {key=via, value=1.1 google}],textInterpretedBody={"statusCode":400,"message":"Referenced resource does not exist","errors":[{"constraint":"UnresolvedReference_operationId_fkey"}]}]
SDK: 1.0.0-20210112211046
endpoint: POST https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant
Java: 1.8.0_252
cwd: /Users/jensschulze/workspace/commercetools-java-sdks/commercetools/commercetools-sdk-java-importapi
request: io.vrap.rmf.base.client.ApiHttpRequest@cdaf0ba[method=POST,uri="https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant",headers=[{key=X-Correlation-ID, value=***********/00981f91-962a-4163-81c4-117d6bfe9ad9}, {key=Authorization, value=**removed from output**}],textInterpretedBody={"resources":[{"key":"9","sku":"12345","isMasterVariant":true,"product":{"key":"random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d","typeId":"product"}}],"type":"product-variant"}]
http request: io.vrap.rmf.base.client.ApiHttpRequest@cdaf0ba[method=POST,uri="https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant",headers=[{key=X-Correlation-ID, value=***********/00981f91-962a-4163-81c4-117d6bfe9ad9}, {key=Authorization, value=**removed from output**}],textInterpretedBody={"resources":[{"key":"9","sku":"12345","isMasterVariant":true,"product":{"key":"random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d","typeId":"product"}}],"type":"product-variant"}]
http request formatted body: {
  "resources" : [ {
    "key" : "9",
    "sku" : "12345",
    "isMasterVariant" : true,
    "product" : {
      "key" : "random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d",
      "typeId" : "product"
    }
  } ],
  "type" : "product-variant"
}

So finally got it "working" with this exception.
As it's possible to set the variant key with one character with the product API seems to be an issue with the import API. So i will forward it to the respective team.
detailMessage: Client error response [url] https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant [status code] 400 [reason phrase]
summary: POST https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant failed  with response code 400 on 2021-01-12T21:10:49.097Z
http response formatted body: {
  "statusCode" : 400,
  "message" : "Referenced resource does not exist",
  "errors" : [ {
    "constraint" : "UnresolvedReference_operationId_fkey"
  } ]
}
http response: io.vrap.rmf.base.client.ApiHttpResponse@7a9bbe58[statusCode=400,headers=[{key=access-control-expose-headers, value=WWW-Authenticate,Server-Authorization}, {key=alt-svc, value=clear}, {key=cache-control, value=no-cache}, {key=content-length, value=130}, {key=content-type, value=application/json; charset=utf-8}, {key=date, value=Tue, 12 Jan 2021 21:10:49 GMT}, {key=vary, value=origin}, {key=via, value=1.1 google}],textInterpretedBody={"statusCode":400,"message":"Referenced resource does not exist","errors":[{"constraint":"UnresolvedReference_operationId_fkey"}]}]
SDK: 1.0.0-20210112211046
endpoint: POST https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant
Java: 1.8.0_252
cwd: /Users/jensschulze/workspace/commercetools-java-sdks/commercetools/commercetools-sdk-java-importapi
request: io.vrap.rmf.base.client.ApiHttpRequest@cdaf0ba[method=POST,uri="https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant",headers=[{key=X-Correlation-ID, value=***********/00981f91-962a-4163-81c4-117d6bfe9ad9}, {key=Authorization, value=**removed from output**}],textInterpretedBody={"resources":[{"key":"9","sku":"12345","isMasterVariant":true,"product":{"key":"random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d","typeId":"product"}}],"type":"product-variant"}]
http request: io.vrap.rmf.base.client.ApiHttpRequest@cdaf0ba[method=POST,uri="https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant",headers=[{key=X-Correlation-ID, value=***********/00981f91-962a-4163-81c4-117d6bfe9ad9}, {key=Authorization, value=**removed from output**}],textInterpretedBody={"resources":[{"key":"9","sku":"12345","isMasterVariant":true,"product":{"key":"random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d","typeId":"product"}}],"type":"product-variant"}]
http request formatted body: {
  "resources" : [ {
    "key" : "9",
    "sku" : "12345",
    "isMasterVariant" : true,
    "product" : {
      "key" : "random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d",
      "typeId" : "product"
    }
  } ],
  "type" : "product-variant"
}

io.vrap.rmf.base.client.error.BadRequestException: detailMessage: Client error response [url] https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant [status code] 400 [reason phrase]
summary: POST https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant failed  with response code 400 on 2021-01-12T21:10:49.097Z
http response formatted body: {
  "statusCode" : 400,
  "message" : "Referenced resource does not exist",
  "errors" : [ {
    "constraint" : "UnresolvedReference_operationId_fkey"
  } ]
}
http response: io.vrap.rmf.base.client.ApiHttpResponse@7a9bbe58[statusCode=400,headers=[{key=access-control-expose-headers, value=WWW-Authenticate,Server-Authorization}, {key=alt-svc, value=clear}, {key=cache-control, value=no-cache}, {key=content-length, value=130}, {key=content-type, value=application/json; charset=utf-8}, {key=date, value=Tue, 12 Jan 2021 21:10:49 GMT}, {key=vary, value=origin}, {key=via, value=1.1 google}],textInterpretedBody={"statusCode":400,"message":"Referenced resource does not exist","errors":[{"constraint":"UnresolvedReference_operationId_fkey"}]}]
SDK: 1.0.0-20210112211046
endpoint: POST https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant
Java: 1.8.0_252
cwd: /Users/jensschulze/workspace/commercetools-java-sdks/commercetools/commercetools-sdk-java-importapi
request: io.vrap.rmf.base.client.ApiHttpRequest@cdaf0ba[method=POST,uri="https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant",headers=[{key=X-Correlation-ID, value=***********/00981f91-962a-4163-81c4-117d6bfe9ad9}, {key=Authorization, value=**removed from output**}],textInterpretedBody={"resources":[{"key":"9","sku":"12345","isMasterVariant":true,"product":{"key":"random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d","typeId":"product"}}],"type":"product-variant"}]
http request: io.vrap.rmf.base.client.ApiHttpRequest@cdaf0ba[method=POST,uri="https://import.europe-west1.gcp.commercetools.com/***********/product-variants/importSinkKey=myvariant",headers=[{key=X-Correlation-ID, value=***********/00981f91-962a-4163-81c4-117d6bfe9ad9}, {key=Authorization, value=**removed from output**}],textInterpretedBody={"resources":[{"key":"9","sku":"12345","isMasterVariant":true,"product":{"key":"random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d","typeId":"product"}}],"type":"product-variant"}]
http request formatted body: {
  "resources" : [ {
    "key" : "9",
    "sku" : "12345",
    "isMasterVariant" : true,
    "product" : {
      "key" : "random-key-63e228e3-1b9e-4dcb-8564-5cb1b8b7932d",
      "typeId" : "product"
    }
  } ],
  "type" : "product-variant"
}

Thanks a lot, feel free to close this issue if there is another issue to track for the product team.

Thanks a lot, feel free to close this issue if there is another issue to track for the product team.

@dpasdar I will open an issue with product team, but since those github repos aren't open source you won't be able to track it directly, if you wish to track this, can you please open an issue via https://jira.commercetools.com/servicedesk/customer/portal/1 with Import API endpoint

@dpasdar I will open an issue with product team, but since those github repos aren't open source you won't be able to track it directly, if you wish to track this, can you please open an issue via https://jira.commercetools.com/servicedesk/customer/portal/1 with Import API endpoint


Windows compatibility

Looking into the commit history I see Improved exception function declarations for MSVC commit, whose name suggests that sqlite3-ocaml can be built for Windows. Unfortunately that's not the case; https://github.com/mmottl/sqlite3-ocaml/commit/03291392186f33e33b6bcc5cb9566a242c65ccd3 destroyed Windows compatibility opportunity introducing pthread API use that cannot be easily emulated under Windows (destructor function passed to pthread_key_create). I could try to put Windows compatibility back, but I would like to know first why user exceptions should be registered on per-thread basis?

Users can register their own functions for use in SQL statements.  These functions may fail with exceptions, which will have to be propagated back through the C-library and the C-bindings to the OCaml user code.  The problem here is that multiple threads may be performing SQLite3 calls and hence raise exceptions in user-defined functions simultaneously.  Since there is no way of passing these exceptions back through SQLite3 arguments or results (that I know of), the only way seemed to be by storing them using thread-specific data.
Maybe there are (new) SQLite3 features that allow you to return this information through result values or by passing them back imperatively through arguments.  If not, then SQLite3 cannot be used from multiple threads under Windows in the presence of potentially failing, user-defined functions.
Please feel free to submit any potential fix without the use of POSIX thread functions if you find one!  It would also be possible to fail differently under Windows by not propagating the exact exception raised in the user-defined function and raising a generic exception instead.  I guess this loss of information would be acceptable to most users, since exceptions should generally be avoided for control flow anyway.

We noticed the same thing here, and have an alternative patch. I will try to compare the two approaches, and report there.

More Windows compatibility improvements will be released soon.


HTTPS support enabled by default [$50]

Although we do have HTTPS support enabled, for some reason, it's not currently on by default. I think that it is time we enable the visitors to browse the site securely by default.

---
There is a **[$50 open bounty](https://www.bountysource.com/issues/8113221-https-support-enabled-by-default?utm_campaign=plugin&utm_content=tracker%2F10548672&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F10548672&utm_medium=issues&utm_source=github).

@fabianthoma do we have certs and everything for this? I'm all for switching to HTTPS by default if we can.

We currently don't own any SSL certs ourselfs. The current site SSL is provided by Cloudflare's Universal SSL.

Using Cloudflare for SSL is an awful idea. It's very susceptible to Man in the Middle attacks.
http://www.jupiterbroadcasting.com/74772/cloudy-with-a-chance-of-ssl-techsnap-195/
http://blog.ricardomacas.com/index.php?controller=post&action=view&id_post=4
I'm not recommending GoDaddy, but they do offer free SSL certificates for open source projects.
https://www.godaddy.com/ssl/ssl-open-source.aspx

With a bit of luck (they promise mid 2015) Let’s Encrypt is available in time for the website launch.

StartSSL is also for free.

I think the only thing currently stopping this is our lack of a "real" ssl certificate.
$25 for 5 years => https://www.ssls.com/comodo-ssl-certificates/positivessl.html

Okay, so Midori doesn't support our SSL with Cloudflare, so for now it will be optional. Leaving this open and blocked.

Is there a corresponding bug report open with Midori? Cloudflare SSL/TLS is quite common :o

Midori is working on a Gtk3/WebKit2 version that presumably fixes the problem. However because the core of Midori has become so outdated it is a major rebuild and is taking some time, hence it won't be coming by default in Freya, although it might come through as an update.

@ApfelUser StartSSL charges for multiple subdomains. It is 60 dollars https://www.startssl.com/?app=2

Lewis had an idea about using JS trying to see if the browser can load a file over https and then redirecting if true. I think that sounds like a good workaround for the issue which should provide https for browsers that can handle it and not exclude those that can't.

The issues isn't that we can't get an SSL certificate, 3 years for $15 is nothing. The issue is we currently hide behind Cloudflare to deal with most of our traffic. As a result, we are stuck using their SSL system. The smallest plan we can get for custom SSL is $200 a month, which is outside our budget right now.
I do however have a solution. As danrabbit said, we use a small javascript snippet to asynchronously load a secure resource onto the page. That resource, on error, does nothing. On success, the browser will receive a HTTP Strict Transport Security Header. When a HSTS Header is received, a compliant browser should redirect insecure requests in the specified time period before sending them to the server.

When a web application issues HSTS Policy to user agents, conformant user agents behave as follows:
Automatically turn any insecure links referencing the web application into secure links. (For instance, http://example.com/some/page/ will be modified to https://example.com/some/page/ before accessing the server.)
If the security of the connection cannot be ensured (e.g. the server's TLS certificate is self-signed), show an error message and do not allow the user to access the web application.

http://en.wikipedia.org/wiki/HTTP_Strict_Transport_Security

To be clear, for successful bug closure, we require:

A JavaScript snippet that asynchronously fetches...
A PHP page which sends a valid HSTS Header along with a minimal JSON response. The header should have a near-maximum expiry time.

I want to remember you guys on my comment before. You can get free SSL certificates which last for one year at StartSSL. You'd get rid of all the problems you have. Midori would accept the SSL certificate and you could enable HSTS with all the (sub-)domains.

@ApfelUser Thanks for the reminder but it's not that simple unfortunately.
It is not about the certificate. We can not switch to https only because midori still uses webkit 1. This older version of webkit does not support the right chipers and encryption methods Cloudflare uses in their SSL implementation.
The $200 is the cost per month of having any custom (even a free one) certificate in Cloudflares system. Which is money we would rather spend on bounties.

I was under the impression it was Server Name Indication (SNI) that was incompatible with Midori, the selected protocols and ciphers.


Add API/flags to import richer history files

I have over a decade of shell logs with timestamp, user, cwd recorded.  I wanted to import all these as well (and not with the same timestamp and cwd).  I ended up writing a script to directly add them to the db, but would have preferred if the tool could accept a flag or env var to custom set the parameters for each command entry instead of just setting them to whatever the local and current environment dictated.
Add some ability to custom set CWD, Timestamp, User and the ability to import commands one by one?

Ah, this is a fair point! I've been pondering how I might support this, and I was wondering: Would it be easy for you to convert your shell history logs to some sort of standardized-ish format for imports? E.g. something like:
{"cmd": "ls", "cwd": "/home/david/", "timestamp":<PHONE_NUMBER>}
{"cmd": "echo x", "cwd": "/home/david/", "timestamp":<PHONE_NUMBER>}

It seems like it could be reasonable to have a feature to import JSON-formatted history entries, and then people could generate these however they'd like. What do you think?

That works for me!  One issue is the escaping of " for any of them in the commands but a JSON library would handle it just fine.

Ok, this is now supported with the import-json and export-json commands! PTAL and let me know if you have any other suggestions or feedback.


Update repositories.txt

Closing as duplicate of https://github.com/arduino/library-registry/pull/1438


vscode:// protocol should allow a windowID parameter to forward to that window, instead of the last focused one

Now that we have support for IURLService#create() we should try to get the window ID into the URI so that we can prefer to open the link in that window.
Today it seems we simply open in the last active window, which might not be right.
//cc @alexandrudima

We gotta pass the command id and args down to the StaticRouter fn, such that it could potentially parse them and make a decision accordingly.

I'm still seeing the callback being triggered on the last focused window. Steps:

Open multiple windows
From one window, use the GitHub Pull Requests: Sign in to GitHub command
Browser window should be opened, note that the url does have the windowId as part of the "callbackUri" query parameter
Focus a different VSCode window than the one that started auth
Click "Continue" on the auth page in the browser and then click "Open" when prompted to open VSCode

The "Allow an extension to open this URI?" dialog appears on the last focused window instead of the window that started the auth flow

I can reproduce and suspect an issue with that URL forwarding in electron-main. I am passing this on to @joaomoreno who implemented that.
The callback URL correctly carries forward the window ID parameter it seems:
vscode-insiders://github.vscode-pull-request-github/did-authenticate?windowId=3&code=<CODE>&state=<STATE>

@joaomoreno is this an issue with the active client ID? The window ID is just the number (as string), but getActiveClientId() returns window:<number>?

Yes, you must be aware that the ctx is whatever you pass in here: https://github.com/microsoft/vscode/blob/ad9bce89782a7badd56ab3654a167727f6f1b033/src/vs/platform/ipc/electron-browser/mainProcessService.ts#L33

@RMacfarlane Could you re-verify this this week? Thanks!


King Phisher Error on New Compaign

Error Type: king_phisher.errors.KingPhisherGraphQLQueryError
Error Details: KingPhisherGraphQLQueryError()
Error UID: b394ffc6-9d74-4fce-abad-c6dd7548e1bd
RPC Error: N/A (Not an RPC error)
King Phisher Version: 1.13.1
Platform Version: Linux: Kali kali-rolling kali-rolling
Python Version: 3.7.2
Gtk Version: 3.24.5
Timezone: Asia/Kolkata
Thread Information:
=> MainThread (alive=True daemon=False)
Thread-1 (alive=True daemon=True)
Stack Trace:
Traceback (most recent call last):
File "/usr/share/king-phisher/king_phisher/client/dialogs/campaign_selection.py", line 243, in signal_button_clicked
assistant = CampaignAssistant(self.application)
File "/usr/share/king-phisher/king_phisher/client/assistants/campaign.py", line 190, in init
self._load_url_treeview_tsafe(refresh=True)
File "/usr/share/king-phisher/king_phisher/client/assistants/campaign.py", line 260, in _load_url_treeview_tsafe
self._url_information['data'] = self.application.rpc.graphql_find_file('get_site_templates.graphql')
File "/usr/share/king-phisher/king_phisher/client/client_rpc.py", line 241, in graphql_find_file
return self.graphql_file(path, query_vars=query_vars)
File "/usr/share/king-phisher/king_phisher/client/client_rpc.py", line 224, in graphql_file
return self.graphql(query, query_vars=query_vars)
File "/usr/share/king-phisher/king_phisher/client/client_rpc.py", line 205, in graphql
query_vars=query_vars
king_phisher.errors.KingPhisherGraphQLQueryError
GraphQL Exception Information:
GraphQL Errors:
init() got an unexpected keyword argument 'follow_links'
GraphQL Query:
retrieve information for all site templates
query getSiteTemplates {
siteTemplates {
edges {
node {
created
hostname
path
metadata {
authors
classifiers
description
pages
}
}
}
}
}

I can't reproduce this. You need provide steps as to what you were doing. Creating a campaign I guess, but was it the first campaign on either the server or that the client has connected to? The later would be in the case of a fresh install of the client.
Also what version of the server are you running? The issue template would have prompted you for this information.


attempts to implement Promise constructor

The closure-taking functions/constructors seem to be quite difficult to deal with; especially in Promise constructor, where a closure takes a form of:
new Promise( /* executor */ function(resolve, reject) { ... } );

where resolve and reject are callable.

This one fails too, but I tried using Box for resolve and reject args.
The error is:
92 | #[wasm_bindgen]
   | ^^^^^^^^^^^^^^^ the trait `convert::FromWasmAbi` is not implemented for `std::boxed::Box<core::ops::FnMut(JsValue)>`

I don't believe we have any support for passing JS callbacks to rust at the moment, so I don't think you can deal with the resolve and reject arguments for now.

Thanks @ohanar, that's what I was afraid of. I'll wait for confirmation from @fitzgen, and if it's indeed impossible right now, I'll just give up on the Promise constructor for now.


Broken package types

It looks like one of the recent commits broke the package.
You can fix it by changing @automock/common/src to @automock/common.

Hi @Exeteres,
Sorry for the inconvenience, and thanks for posting.
I applied a fix, and released version 1.2.3 (of @automock/jest); please try to install it and let me know if it worked for you 🙏🏻

Everything works :tada:
Thanks for the great package!


Focus is not on page after performing an action that changes the tab

Describe the bug
The page area is not in focus after a performing an action that changes the tab such as: Move to left tab, Move to right tab, Close tab, New tab
After performing actions such as those above, if a page up/down key is sent to the browser (via a keyboard or virtual keyboard) for example, the keyboard key doesn't do anything. However, once you tap anywhere in the loaded web page area and again send the keyboard key, it will be accepted and performed. Note that the page is correctly in focus and it is responsive to keyboard keys until an action is performed to change the tab
To Reproduce
Steps to reproduce the behavior:

Load any page in tab 1
Load any page in tab 2
Switch to tab 2 by performing action: Move to right tab
Send page up/down key to the browser via a keyboard or virtual keyboard (issue here,  nothing occurs or no action in browser)
Tap anywhere on the loaded page for tab 2
Send page up/down key key again to the browser via a keyboard or virtual keyboard (action now correctly occurs on the page)

I've noticed that after doing steps 1-3,  if you change app and switch back to YuzuBrowser the page is correctly in focus again.
Expected behavior
The page is focused after performing an action that changes the tab so that any keys that are submitted to the browser via a keyboard or virtual keyboard would be accepted without needing to manually tap on the page area first to focus it again.
Device information (please complete the following information):

Device 1: Tablet running Android 7.1.2
Device 2: Mobile running Android 8.1

I have fixed this issue and will look at what is needed to commit the change. In the meantime, if anyone would like to get my updated version it can be found here: https://mega.nz/file/KJhj2SaZ#ESDk6ogTjkVGv6FufV0jtiAAFRp7g-zL5nX2zJAr1mE


samples: reel board: correct timeout condition

After this fix each LED will blink 5 times. Previously
LED_0 has been blining 6 times while others 5 times.
Signed-off-by: Jakub Rzeszutko<EMAIL_ADDRESS>

Codecov Report

Merging #12198 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12198   +/-   ##
=======================================
  Coverage   48.24%   48.24%
=======================================
  Files         293      293
  Lines       44130    44130
  Branches    10591    10591
=======================================
  Hits        21290    21290
  Misses      18570    18570
  Partials     4270     4270

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b75a05c...2f3cb43. Read the comment docs.