Changes to images for focus point display:

remove rotated & mirrored center images
remove mirrored corner images
move images to sub-directories
move source images and build script out of the main plugin directory

The rotated & mirrored center images were redundant, replaced these with single images. Only the red center images were used so removed the black, grey and yellow ones.
Since the corner images are symmetrical, the mirrored corner images were duplicated by the rotated images. The code now selects an alternate rotation angle if mirroring is needed.
The source images and build script don't need to be in the plugin directory, I moved these to the top level of the project.
Created sub-directories for the various images instead of having them all in one directory.

PRs this big, Github has a really hard time showing the diff and the browser locks up on me. Help me some out:
I see no changes to code.

Are you suggesting all deleted assets and not used?
If you moved images to subdirectories, there should be changes in code to reflect the path updates, right?

Both DefaultDelegates.lua and DefaultPointRenderer.lua were updated to accomodate the file name/location changes.
I use SourceTree - it provides a better UI.

I explained the redundancy of the images in the PR a few days ago. They are redundant in the current chosen design and may not be redundant in a future design.
We may very well want to have completely new corner and center designs in the future. Think Face Recognition etc.
Given the small about of place these images are wasting right now, I don't see this PR as an improvement.

50K? On my Mac this change reduces the plugin size by 6MB and removes 1,444 redundant image files!
It does not preclude adding non-symmetrical, mirrored images in future should the need ever arise - the additional code required to support this would be quite simple.

Why not just move the currently unneeded icon sets to another folder outside of the .lrdevplugin ?
This will remove the most part of the unneeded stuff and will not remove a feature which we could use soon.

The source images and script have been moved to the top level build/imgs folder (out of the plugin).
Everything in the assets/imgs folder is created from these source images - why keep something that can be re-created at any time?
Why keep redundant images when a few lines of code can take care of them and produce the same result?

The point is that it happens that the current images are symmetrical. I dont see any reason to change a universal script to a particular script that works only because of the current particularity of the images.
And the size problem is to me a non issue, 6 MB being 1/3th to 1/5th of what only one image weights nowadays.

Glad to see you guys are discussing reasonably. If an agreed upon decision doesn't happen,  I'll weigh in in a couple days.

I suspect the mirrorred/rotated icons are the main sticking point, so lets break it down into pieces.
Which of the following are you happy with:

move the source images and build script out of the plugin folder
create sub-directories in assets/imgs to group the various image types
remove the unused black, yellow and grey center dot images from the build script & assets folder
condense the 288 red center dot images down to just the 2 images needed, with appropriate code changes
take advantage of the symmetry of the current corner images to remove the 720 corner mirrored images, with code changes to support this

If you really want to keep the mirrored corner images, I don't have a problem with that.
I can't envision a scenario where the red center dot would need to be replaced with something more complex so I think point 4 makes sense as well.

ok. So I weighted back and forth other ways of reducing the number of images while retaining the universality. I went the way to integrate the image name calculation function to the template table. This works, but because of lua's lack of support for inline ifs, this is just hideous and really not a better solution than yours.
So, I am for merging this PR as is.

Thanks guys. Here's what I'm going to do as well: I will make a git tag as the code stands today as  stable-1.0.0 release. If minds ever change, git will have all the history of the code and files. It will be very easy to revert this out.

in branch called "asset_reduction" until I can QA. I will merge it over from there tomorrow (or the next day)


Web - Report Preview in Report Screen shows up even after deletion of Money Request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Use FAB on a ChatReport and generate money request
Click on IOUReport to show the IOUReport
Use menu to delete the Money Request
Come back to ChatReport of Step 1
Reload the page.

Expected Result:
Report Previous should not show up for a deleted Money Request
Actual Result:
Report Preview shows up for a deleted Money Request
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/afaf2363-4413-40c6-8500-757f81e7e1ad
https://github.com/Expensify/App/assets/93399543/1dd1c34c-c03a-4322-a3e5-233ac94e822e
Expensify/Expensify Issue URL:
Issue reported by: @rojiphil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693399731169779
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Report Preview in Report Screen shows up even after deletion of Money Request
What is the root cause of that problem?
The problem occurs because we are not clearing the Report Preview on deletion of the IOU Report.
What changes do you think we should make in order to solve the problem?
This can be solved by clearing up the Report Preview when IOU Report is deleted at this location within successData of deleteMoneyRequest method
The changes can be as follows:
        ...(shouldDeleteIOUReport
            ? [
                {
                    onyxMethod: Onyx.METHOD.MERGE,
                    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chatReport.reportID}`,
                    value: {
                        [reportPreviewAction.reportActionID]: {
                            pendingAction: null,
                            message: [
                                {
                                    type: 'COMMENT',
                                    html: '',
                                    text: '',
                                    isEdited: true,
                                },
                            ],
                            errors: null,
                        },
                    },
                },
              ]
            : []),

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Report preview in report page shows again even after money request is deleted
What is the root cause of that problem?
When we delete a money request, deleteMoneyRequest function is called.
As you can see, if shouldDeleteIOUReport is true, we optimistically merge the report preview action with null
https://github.com/Expensify/App/blob/d971190c3feb4ea35a0d704aa097919ca13e3958/src/libs/actions/IOU.js#L1183-L1189
And the deleteMoneyRequest API returns {[reportPreviewActionID]: null}, too.
The problem is in Onyx.merge
Please check the code here
We remove the keys with null value in modifiedData and call Storage.mergeItem. This means null values are not updated in storage though they are updated in memory. This is a bug and the root cause of this issue
What changes do you think we should make in order to solve the problem?
In Onyx.merge function, we merge the changes with existing data and remove all keys with null values, we have to call Storage.setItem instead of Storage.mergeItem
This works as expected

Result

What alternative solutions did you explore? (Optional)

Calling Storage.setItem instead of Storage.mergeItem is definitely not what we want to do here, because we added JSON_PATCH  functionality for SQLite on native here.
I just discovered the potential problem. I think it’s related to the idb-keyval PR by @hannojg. The problem is, that before this PR, on web we just set the modified data with the nullish keys removed already. After this PR, on web we’re using yet another merge funcationality, which will not drop the nullish keys, because the modified data with the removed nullish keys will be merged.
I’m gonna open a PR, which fixes this.

I hope you open the PR asap. I think this bug may cause several issues

@s-alves10 just created a PR in Onyx that fixes this issue: https://github.com/Expensify/react-native-onyx/pull/333

I was out last week. Catching up this week

@allroundexperts can you verify if @chrispader's PR fixes this?

@muttmuure
As I understand, the PR in this comment was supposed to resolve this issue.
@chrispader @s-alves10 can confirm

Issue not reproducible during KI retests. (First week)

Issue not reproducible during KI retests. (Second week)

@allroundexperts @muttmuure
Can we not close this issue if the issue is fixed already?
Also, there are other issues dependent on the resolution of this one. Closing this would help us move further on the other issues.

This hasn't been reproducible for two weeks [following this PR] (https://github.com/Expensify/App/issues/26627#issuecomment-1745357694) - closing. Thank you @rojiphil !

@muttmuure
Don't I qualify for a reporter bonus here as I had reported the bug?

@miljakljajic @muttmuure
Don't I qualify for a reporter bonus here as I had reported the bug?


Distribute as docker image

A prerequisite for this feature is to be able to externalise some essential parts of the streama configuration.
The Docker way of managing app settings is to use environment variables. The streama Grails application should somehow manage to read settings from the following environment variables:

[ ] DataSource.groovy related:

MYSQL_HOST
MYSQL_PORT
MYSQL_DB
MYSQL_USER
MYSQL_PASSWORD

[ ] BASE_URL (to come up with http://www.some.domain.tdl/streama which will be use for the links in email for instance)
[ ] EMAIL_FROM
[ ] SMTP_HOST and SMTP_PORT

I suppose there will be a need for other environment variables, but for now those are the one from the top of my head.
Once streama will be able to start from a war taking into account those environment variables, a Dockerfile will be easier to come up with.

I agree with all of the above, except for base_url as this is already part of the settings-configuration (so it works via values in the database, not any config file).

I agree with all of the above, except for base_url

list of variable updated

And for email from, smtp host and smtp port we could also use the db. the only thing that cant be in the db is the db connection itself.

I do a bit of sysadmin as part of my job, and I find it more convenient to configure all environment related settings with just an external config file or environment variables. As a sysadmin I don't want to have to know some of the application internals to be able to have it set up correctly ; In other words, it is not convenient to have to figure out where in the database should a setting be set.

no, but what if it is done, like the base_url, in a settings page that is part of the GUI? The db-connection will likely never change on one and the same server, but the "from-email-address" may very well change often. shouldn't that then be more easily accessible, for instance via the GUI?

I agree drawing the line to tell apart settings which are system related from those that are application related can be tricky for some of those settings.
Anyway, other thing to consider is the ease of implementation for the docker image. It is straight forward to come up with a docker image that manages all settings as environment variable. However if the docker image would be to write some data in a mysql database on first boot, that would start to be a mess (init shell script, wait for db to be up before updating, etc)

There are a couple of other alternatives:

Mounting a config file via Docker volumes
Using an external key/value store, such as etcd

Its grails that handles the writing of default-data, in a bootstrap.groovy. And for grails to run, the mysql has to be there anyway. So my suggestion would be to only put the most critical information in the external config which is required for grails to run. everything else can be handled by grails itself.

ok, todo list updated in 1st comment

But I don't want to overrule your judgement, I truly don't! I really like this dialogue, and am open to counter-arguments :)

Don't worry, we just have to agree on a starting point. We'll come up with a 1st docker image and once it starts to be used suggestions will pour ;)

Something else to consider when dockerizing this is where will the actual video files be stored? Should they be contained in the Docker container itself, or just in a mounted volume?

Video files MUST be on a mounted volume as the docker container layered file system (copy-on-write) isn't providing good read/write performances in most cases.
Also, best practices encourage docker containers to be disposable. That implies docker containers must not persist data themselves, they are just holding the application code/binaries and running them along with conf (from environment or mounted conf file). This also complies with the 12 factor app manifesto.

:+1: For docker image
I also agree with @thomasleveil. Mounted Volume and disposable containers running only the application code/binaries.

agreed. Although, and now this is only my lack of docker experience, but doesnt the database reset every time you restart the docker image? That is, if the database only exists inside of docker. Or am I wrong?

I'm not experienced with Docker either but its seems to me that it would store the database data outside the docker image? https://docs.docker.com/reference/builder/#volume

Ah ok, yea.. that would be good. And necessary.

Yep, using data volumes or data volume containers is the official approach to persisting data across multiple runs.

Video files MUST be on a mounted volume as the docker container layered file system (copy-on-write) isn't providing good read/write performances in most cases.

@thomasleveil It doesn't actually have to be a mounted volume from the host. A volume itself should avoid UFS. Good point about r/w performance, I hadn't considered that.

For the database, it would be another container dedicated to provide the mysql service. The official mysql docker image gives instructions on how to persist the mysql data.

Heh. I thought the same. Here is a first version I created a few hours ago https://registry.hub.docker.com/u/r0lhw/docker-streama/

oh.. we were working on the same.
https://registry.hub.docker.com/u/whatever/streama/
docker run -d-p 8080:8080 -p 4000:4000 -v /data:/data -e “MYSQL_HOST=mysqlhost” -e “MYSQL_port=3306” -e “MYSQL_DB=streama” -e “MYSQL_USER=streama” -e “MYSQL_PASSWORD=streama” whatever/streama

happy to merge or use yours.

The only thing I don't really like about my version is that due to the config being compiled into the code it needs to compile the config on each start as the host/ip etc might change between starts. And I currently don't see a way around it. Can't find anything about configs or envs in your setup.
Anyway, the rest is working pretty good right now.
As it stands I would prefer my setup as it can produce reproducible/automated builds and builds from source.

@lhw, maybehttp://johnrellis.blogspot.fr/2010/11/grails-quick-tip-external-configs.html?m=1 could change that

@whatevercode already added an extra environment to the datasource which would allow for an ENV based config. I'll do a pull request later to change those names to the corresponding default ENVs and then the recompile wont be necessary anymore.

I like the way @whatevercode implemented this with the docker section in DataSource.groovy

Does the image from @whatevercode actually work for someone, with an empty database?

He may not be very active at the moment (busy with his day-job). if you want to suggest an alternative approach, feel free :)

@whatevercode I try to run your image (you have already build the image) but when I follow localhost:8080, I have an 404 status. You show the error ?

Mhm I tried updating my docker image too the new environment in DataSource and I also fails to create the tables, same as the @whatevercode image. Anything I am missing here? Shouldn't these frameworks try an automatic migration/creation of the tables?

Do I have to create a MySQL database before using the Docker image or does the image takes care of that?

@HazWard current docker config uses Tomcat 8 as base image. So I don't think the image contains database.

closing in favor of #197


i18n support

Example usage
The editor can be localised by passing the i18n prop to the editor like so:
const slovenianLocale: MDXEditorI18n = {
  toolbar: {
    blockTypeSelect: {
      selectBlockTypeTooltip: 'Izberi vrsto bloka',
      placeholder: 'Vrsta bloka'
    },

    blockTypes: {
      paragraph: 'Odstavek',
      heading: 'Naslov',
      quote: 'Citat'
    }
  }
}

function LocalizedEditor() {
  return <MDXEditor i18n={slovenianLocale} />
}

This code above will change the strings for the block type select element and its labels:

How it's done internally
i18n is handled via a React context. More specifically, the useI18n hook. A plugin can access this hook and it will have all the necessary translations available to it
export default function ExampleElement() {
  const i18n = useI18n()
  return <button title={i18n.toolbar.bold}>{i18n.toolbar.bold}</button>
}

I may have missed a translation or two, and some additional work may be required for custom plugins, but I think this is a decent starting point. I will happily provide additional development on the subject, so please, let me know what you think.

Thank you very much for that contribution. This is indeed a great addition. I pushed a change that does the following:

Got rid of the provider, moving the i18n object into the built-in state management flow. One context less to deal with.
the @types dir is meant for overriding types in external libraries. I squashed all into core.

With the changes above, any plugin should be able to access the hook or the i18n$ cell (if they need it outside of React).
To extend further on the topic of external plugins needing more translations: I think it makes sense to take advantage of TypeScript's capability to merge interface declarations.
For that purpose, I think we should use interfaces rather than types (a small example in the docs on how to declare the interface from the outside would be great - here's one example where I do that for an external interface: https://github.com/mdx-editor/editor/blob/main/src/mdastUtilHtmlComment.ts#L9-L15).  Let me know if this makes sense.

Yeah agreed, interfaces are better for this. I've gone ahead and converted the types. Is this then, in theory, enough for external plugins to fully utilise i18n?

That looks good to me. I will give it another thorough read and merge next week.

I've given this some more thought. I will work on distributing the translation pieces into each plugin to see how this could work. In that way, each plugin should be able to include its own parts conveniently. Of course, the final translation override should happen at the root component prop.


Implement missing MINE_BLOCK inventory action handler

Currently, stack request actions with MINE_BLOCK are not deserialized/serialized causing exceptions when they are retrieved. This pull request seeks to fix that by implementing the serializer/deserializer for it.

Are you able to rebase your changes onto the develop branch?

Yeah sure!


[FancyZones][Hotfix] Fix VirtualDesktopManager init

Summary of the Pull Request
What is this about:

Changed IVirtualDesktopManager initialization
Added missed nullptr check

What is include in the PR:
How does someone test / validate:

Launch PT, verify that FZ works.
Verify that no [error] Failed to create VirtualDesktopManager instance  in the logs.

Quality Checklist

[x] Linked issue: #13214
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

Shipping with v0.51.1?

Shipping with v0.51.1?

That's the idea ;)


"user-reader" role to the user pages

Add a role to have read-only privileges on the user pages

The role works as expected.
User-reader can see all the roles and export them, but can't edit.


Enable cilium for arm

Thank you for making MicroK8s better
Enable Cilium to be used on ARM. Cilium supports arm starting version 1.11.2 and greater.
Also verify you have:

[x] Read the contributions page.
[x] Submitted the CLA form, if you are a first time contributor.

@Thesykan can you take a few minutes to sign the CLA? We can then proceed with this PR

@Thesykan can you take a few minutes to sign the CLA? We can then proceed with this PR

Hello, I've submitted the form once before. I went ahead and submitted it again just now. Hope that fixes the cla-check. @neoaggelos

The job failed with:
Checking the following users on Launchpad:
-<EMAIL_ADDRESS>✕ (has no Launchpad account)

Can you ensure the commit email matches the one you used to sign the CLA? Thanks!

Ah I see, I forced pushed an author update.

Found an issue with this configuration with a multi-node install. cilium will install and work on the primary node the addon is installed with but attached nodes don't get a CNI config update. There is a CNI config flag to set on helm, but currently is set to false. I'll open an issue on this topic, don't want to undo something if this was done for a reason.

Hi @Thesykan sorry for the long wait. The PR does two things, enabled cilium on arm64 and upgrades cilium.
In my tests the arm64 support goes great however, the new version of cilium seems to introduce some network issues. When for example I enable dns the dns pod cannot reach the API server with an error similar to:
 HINFO: unreachable backend: read udp <IP_ADDRESS>:46159-><IP_ADDRESS>:53: i/o timeout · Issue #2693 · coredns/coredns

Have you encountered this?

v1.11.12 worked for me. I fee the 1.11.12 was the one meant to be used.

Thank you for this work @Thesykan . It will be available wit the 1.27 k8s release.


Create Rails CI template file

add Rails CI file for repository template.

CI fails because there is no Rails source in this repository, but the content is fine, so I merge it.


Use eloop from hostapd

The src/utils/eloop.c file is only Linux compatible, and is not compatible with FreeBSD.
However, the eloops.c/.h file from the 2.10 HostAPD source code contains FreeBSD support. Instead of copying the file into our git repo, we can instead download it, and manually apply patches to the file.
This should make it much easier to upgrade to v2.11 of HostAPD, or to take in any other upstream improvements to eloop.
Unfortunately, a the git history of src/utils/eloop.c is a bit missing (since a lot of modifications were already in https://github.com/nqminds/edgesec/commit/2a18535cb57f7059dba72eb50490bda587291fe8), but I tried to do the bare minimum amount of changes to eloop to get it to compile/tests to run.

Before we start working on this pull request we need to add loads of tests for eloop.
The reason is that I completely modified the eloop, i.e., it doesn't use any global variables and instead it uses a context which the user can allocate on the heap.

Before we start working on this pull request we need to add loads of tests for eloop.

The reason is that I completely modified the eloop, i.e., it doesn't use any global variables and instead it uses a context which the user can allocate on the heap.

:+1:
I added your changes in https://github.com/nqminds/edgesec/blob/78cb3006dafb782f368868b3aafd2f8e62243be5/lib/eloop/patches/0002-Allow-multiple-eloops-to-run-at-same-time.patch
The eloop.h file is the same as your version in src/utils/eloop.h, but the eloop.c implementation might be quite different (although I did try to copy as much as possible). I basically just added eloop as a parameter to every function.

I already added tests in eloop-test branch. Can you update the branch with your tests?

I've removed the test commits from this PR, since they were added in PR #275 instead.
Tests pass on FreeBSD using kqueue :rocket:

@aloisklink before we merger the eloop we need to add several integration test, i.e., tests that do not depend on presence of the hardware.

We need to simulate the hostapd

This one might be hard to test, especially since we need to be able to run this test somewhere we:
a) don't have root access, and
b) don't have sudo access.
Maybe this isn't necessary: currently we have tests for every function in src/utils/eloop.h except:

eloop_register_sock()
eloop_unregister_sock()
eloop_wait_for_read_sock()
eloop_sock_requeue()

(some of these might be called internally by eloop_register_read_sock(), which we do test)

We need to run a radius client in test mode

Isn't this what test_radius_server does? If no, can you make a GitHub Issue with what you want tested? Since you know more than I what these files actually do.

We need to implement eloop termination see https://github.com/nqminds/edgesec/issues/170

:+1: It's probably easier to get #170 working before merging this PR.
Just by the way, remember that without merging this PR, we can't get EDGESec compiled on FreeBSD.

I've git rebase-d onto the latest main branch, just to hopefully simply things after #339 is merged too.


Lunchbox (Aqara FP2 and Philips Hue): handle wantread from luasocket/luasec

The wantread message indicates that the socket is not ready to read data yet and the operation should be retried later. This happens when you're trying to read data from a socket, but the data isn't available at that moment.
This is a proposal for a fix for the Aqara FP2 issue #1648 .
Add a new function in rest.lua to check if the socket is ready for reading
local function wait_for_read(socket, timeout)
  -- Use socket.select to check if the socket is ready for reading
  local ready_sockets, _, _ = socket.select({socket}, nil, timeout)
  return #ready_sockets > 0  -- Returns true if the socket is ready to read
end

And use it here:
https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/7821a5d168d89fb449391a584a3566c605389265/drivers/SmartThings/philips-hue/src/lunchbox/rest.lua#L106-L108
https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/7821a5d168d89fb449391a584a3566c605389265/drivers/Aqara/aqara-presence-sensor/src/lunchbox/rest.lua#L104-L106
    if wait_for_read(sock, 1) then
      next_recv, next_err, partial = sock:receive(pat)
    else
      -- No data is ready, sleep for a bit
      socket.sleep(0.1)
    end

Additionally handle wantread here by waiting and trying again:
https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/7821a5d168d89fb449391a584a3566c605389265/drivers/SmartThings/philips-hue/src/lunchbox/rest.lua#L109-L120
https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/7821a5d168d89fb449391a584a3566c605389265/drivers/Aqara/aqara-presence-sensor/src/lunchbox/rest.lua#L107-L118
if next_err ~= nil then
  if string.lower(next_err) == "closed" then
    if partial ~= nil and #partial >= 1 then
      full_response:append_body(partial)
      next_chunk_bytes = 0
    else
      return nil, next_err
    end
  elseif string.lower(next_err) == "wantread" then
    -- Wait and try again if socket is not ready yet
    socket.sleep(0.1)
  else
    return nil, ("unexpected error reading chunked transfer: " .. next_err)
  end
end

Sorry for the formatting...

Add a new function in rest.lua to check if the socket is ready for reading

This should already be happening in cosock/socket/internals.lua. An additional check here is probably not going to change much. wantread should be triggering the coroutine.yield here.
I believe the actual issue here is that this timeout is being reached and not being retried which is the only time we should see the allow-listed methods would return a timeout/want* error. The call to select will only ensure that something is ready to read on the socket and not that all of the data is available so it may end up just delaying the error report.
I think I see the bug in fill_body so long as this response is chunk encoded. It seems we drop the partial response from HttpMessage.fill_chunked_body
essentially this return is being dropped when called here but should probably be appended to self.body before returning nil, err to allow for retrying this operation

Can you please try this branch and see if it solves you issue?

Do you have an invitation link to the driver channel?
(Not at home right now and setting up my own channel would be a hassle.)

Hey @ldeora Thanks for your engagement, I was able to get a driver sharing link for the PR that @FreeMasen mentioned. Please check out this comment https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1656#issuecomment-2384601737
The driver is available on this channel, https://bestow-regional.api.smartthings.com/invite/eGM6B8mq4eMA

Good news: error is gone. Bad news: device still not added.
Am I the only one with this device who is testing this driver? From what I've seen, those who tested the driver, did it before the last commit that updated the lunchbox.
Seojune no longer responds to my email inquiries, although he has done so previously. I mean I can live without this driver and if it's broken, it's Aqara's problem...
2024-10-01T07:53:16.628461921Z TRACE Aqara Presence Sensor  Setup driver aqara-fp2 with lifecycle handlers:
DeviceLifecycleDispatcher: aqara-fp2
  default_handlers:
    removed:
    init:
    driverSwitched:
    infoChanged:
    added:
  child_dispatchers:

2024-10-01T07:53:16.634018296Z TRACE Aqara Presence Sensor  Setup driver aqara-fp2 with Capability handlers:
CapabilityCommandDispatcher: aqara-fp2
  default_handlers:
    refresh:
      refresh
    multipleZonePresence:
      createZone
      updateZoneName
      deleteZone
  child_dispatchers:

2024-10-01T07:53:16.673406671Z INFO Aqara Presence Sensor  Created dispatcher [SecretDataDispatcher]aqara-fp2 that had no handlers
2024-10-01T07:53:16.680166171Z TRACE Aqara Presence Sensor  Setup driver aqara-fp2 with Secret Data handlers:
SecretDataDispatcher: aqara-fp2
  default_handlers:
  child_dispatchers:

2024-10-01T07:53:16.688160505Z TRACE Aqara Presence Sensor  Received event with handler driver_lifecycle
2024-10-01T07:53:16.693856213Z INFO Aqara Presence Sensor  received driver startupState: {"hub_zigbee_id":"KG2XAAILh00=","hub_node_id":1,"hub_ipv4":"<IP_ADDRESS>"}
2024-10-01T07:53:16.754670546Z TRACE Aqara Presence Sensor  Received event with handler discovery
2024-10-01T07:53:16.765714171Z INFO Aqara Presence Sensor  discovery_mdns.find_device_ips
2024-10-01T07:53:17.474704588Z INFO Aqara Presence Sensor  found_name = _Aqara-FP2._tcp
2024-10-01T07:53:17.482858755Z INFO Aqara Presence Sensor  ip = <IP_ADDRESS>
2024-10-01T07:53:17.494244838Z INFO Aqara Presence Sensor  found_name = _Aqara-FP2._tcp
2024-10-01T07:53:17.501554505Z INFO Aqara Presence Sensor  found_name = _Aqara-FP2._tcp
2024-10-01T07:53:17.506068671Z INFO Aqara Presence Sensor  ip = <IP_ADDRESS>
2024-10-01T07:53:17.510552588Z TRACE Aqara Presence Sensor  unknown dni= 54:EF:44:5C:4C:98, ip= <IP_ADDRESS>
2024-10-01T07:53:17.515177046Z TRACE Aqara Presence Sensor  try_add_device : dni= 54:EF:44:5C:4C:98, ip= <IP_ADDRESS>
2024-10-01T07:53:17.519963588Z INFO Aqara Presence Sensor  54:EF:44:5C:4C:98 Creating TCP socket for REST Connection
2024-10-01T07:53:17.524763088Z INFO Aqara Presence Sensor  54:EF:44:5C:4C:98 Setting TCP socket timeout for REST Connection
2024-10-01T07:53:17.529265213Z INFO Aqara Presence Sensor  54:EF:44:5C:4C:98 Connecting TCP socket for REST Connection
2024-10-01T07:53:17.576603380Z INFO Aqara Presence Sensor  54:EF:44:5C:4C:98 Set Keepalive for TCP socket for REST Connection
2024-10-01T07:53:17.748174755Z INFO Aqara Presence Sensor  54:EF:44:5C:4C:98 Creating SSL wrapper for for REST Connection
2024-10-01T07:53:17.765533505Z INFO Aqara Presence Sensor  54:EF:44:5C:4C:98 Performing SSL handshake for for REST Connection
2024-10-01T07:53:20.441035088Z INFO Aqara Presence Sensor  54:EF:44:5C:4C:98 Successfully created TCP connection
2024-10-01T07:56:16.739520401Z TRACE Aqara Presence Sensor  Received event with handler discovery
2024-10-01T07:56:16.761897984Z TRACE Aqara Presence Sensor  Received event with handler driver_lifecycle

I even tried to trick someone else to delete and add the device but he didn't fell for it...
https://community.smartthings.com/t/aqara-fp2-tested-with-smartthings/270688/79
If anyone can confirm that adding the device works, that would be great. My device has been successfully added a long time before the lunchbox was updated. After this 14e259b70acca0b15a8e09fe05eae441c8c9b16c commit, I was able to add it several times without problems. After the whole PR was merged into main I tried it again but now it fails. The only change was this: 640f0667a413440b9674c6adc6228d57c2f236fc .
But I repeat myself.

Now we need a log.info() in here to check if the the request works. Would have been nice to have it in the original PR.
https://github.com/FreeMasen/SmartThingsEdgeDriversFork/blob/d72deca83b1be2926ec3079aa843d4a2b11a8aec/drivers/Aqara/aqara-presence-sensor/src/fp2/api.lua#L73-L76

@seojune79 Is there a reason why the FP2 can't be added anymore? Maybe a hidden expiration date for /authcode or the whole REST in firmware version 1.2.7_0011.0080?

If something goes wrong while removing FP2 from the ST app, the device won't be onboarded.
If this happens, removing and onboarding the FP2 in the Aqara home app and then trying to onboard in the ST app should resolve the issue.

Not fixed. Another user has the same issue. Read the comments here (conversation between Andreas_Roedl and ewimer2):
https://community.smartthings.com/t/aqara-fp2-tested-with-smartthings/270688/136
User has hub firmware 54.x, FP2 firmware 1.2.8x.
Keep in mind that the rollout of the FP2 firmware isn't completed yet and these are the first users who are trying to connect the FP2 to ST.

@FreeMasen User tried your modified driver but it didn't solve the issue.


Migrate to ion-sfu

Migration to ion-sfu. Still have a few things to clean up

closing this since migration approach is significantly different now


Add global filter chain configuration API part 1

The initial part of adding global filter chain configuration. #132
It allows for users to set global configuration that will be applied to all filters in the same filter chain.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Shikugawa
To complete the pull request process, please assign brenodemedeiros after the PR has been reviewed.
You can assign the PR to them by writing /assign @brenodemedeiros in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Shikugawa, ZackButcher
To complete the pull request process, please assign brenodemedeiros after the PR has been reviewed.
You can assign the PR to them by writing /assign @brenodemedeiros in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Shikugawa, ZackButcher
To complete the pull request process, please assign brenodemedeiros after the PR has been reviewed.
You can assign the PR to them by writing /assign @brenodemedeiros in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lizan, Shikugawa, ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [ZackButcher,lizan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Battery attribute & accuracy filter

Closed to continue in home-assistant/home-assistant/pull/24277
Breaking Change:

battery_level attribute changes to battery.
Since a device_tracker component contains a standart attribute for battery level, that we can use with see service, update with async_see method, we should use it for maintain component criteria and not create a new attribute for the same pourpose with a different name.
To solve this breaking change, only need to replace the battery_level attribute with battery in all templates than use the battery attribute of any traccar device_tracker.

Description:

Battery attribute is sent into see method instead of an additional paremeter.
Added an accuracy filter option to exclude positions if accuracy is higher than specified.
Added a skip accuracy filter option to avoid filter certain positions by accuracy if any of the specified attributes are present in the message, ie throw an alarm but accuracy is too high.
Extract constants to const.py file.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9347
Example entry for configuration.yaml (if applicable):
device_tracker:
  - platform: traccar
    ...
    max_accuracy: 100
    skip_accuracy_filter_on:
      - alarm
    ...

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly (example).
[x] New dependencies have been added to requirements in the manifest (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

Outdated => home-assistant/home-assistant/pull/24277


Use --copy-links in rsync call to copy symlink files

This is mostly relevant if:

Not using index-while-building
Build a scheme with a non-app primary output

Specifically, headers were not being copied over because they were symlinks and the default behavior of rsync is to skip these. Xcode indexing would fail because the modulemap would point to these files that were not being copied to derived data.

Thanks for fixing this @erikkerber , I fixed this myself locally but did not think to upstream it 🤦🏻

Thx for the contribution! CI failure are all because of Error: 'NoneType' value has no field or method 'compare_to', is this sth you can fix?


Fixed time -> item typo in comments

Thanks for catching and fixing them @finafisken!

Happy to help. Great tutorial!


Performance issue with Orient 3.x when removing non lightweight edges

OrientDB Version: 3.2.6
Java Version: 1.8.0_322-b06 Temurin
OS: Windows 10 Enterprise
Expected behavior
Removing non lightweight edges is not slower than in OrientDB 2.x
Actual behavior
Hi!
We are updating OrientDB from version 2.2.37 to 3.2.6 and detected some performance issues with removing edges.
We have some not lightweighted edges which should be removed. This takes now 40% more time than before.
With some research and debugging we found out, that the reason for that is this code change that was made for OrientDB 3.0.0. Unfortunately, we cannot see why this change was made (no issue linked).
In this commit, outcoming and incoming vertices were detached when removing an edge, which at first sounds correct.
We made a profiling where you can see that the OEdgeDelegate.deleteLinks method takes over 60% of the time, see

While debugging we saw, that this method is called twice for each edge:

com.tinkerpop.blueprints.impls.orient.OrientGraph.removeEdgeInternal(OrientEdge) --> line 438 calls edge.removeRecord()
this calls com.orientechnologies.orient.core.record.impl.OEdgeDocument.delete()

This deletes the links first (no 1) and delegates to the super.delete() (no 2) which finally leads to com.orientechnologies.orient.core.db.document.ODatabaseDocumentEmbedded.delete(ORecord) which also deletes the links in line 1030 if the document is an edge

Is this expected?
Steps to reproduce
remove a non-lightweight edge

Hi,
This should be fixed in the last release 3.2.14.
Closing


Toggling sorting button on stratification column does nothing

When the column is set as stratifier, the sorting button is not working (although the icon is changing).
Example:
Set some column as stratifying (e.g. Continent) & then try to change the order of that column, (e.g., continents) from A-Z to Z-A. When you first click the sort button it will A) Activate (go orange) as well as B) Switch the icon from A-Z to Z-A. One issue is that this, in my opinion, shouldn't happen in one click and the second issue is that table ordering stays A-Z. Subsequent toggling the sorting button will also have no effect on the table order.

Web browser version and OS: chrome 62 @ Windows 10
Observed on the current daily build.

part of #467


Add documentation about SeccompDefault feature

This adds a documentation section about the SeccompDefault feature
gate for the kubelet. Beside that, the feature gate has been added to
the list of features, too.
Refers to kubernetes/enhancements#2413
Preview lazy link:
https://deploy-preview-27957--kubernetes-io-vnext-staging.netlify.app/docs/tutorials/clusters/seccomp

Thank you for the review @sftim :pray: ! I hope I understood and addressed your comments correctly.

Can we be sure that kind will provide a tool that deploys a v1.22 cluster on or soon after release day?
I notice latest kind deploys a v1.20 cluster.

No, I assume that the images will be updated manually after a k8s release.
cc @BenTheElder

There have been some abnormal issues in 1.21 with breaking changes in kubernetes combined with kind itself being in the middle of some large changes (e.g. multi-arch), I really doubt we'll have this again in 1.22. We have more maintainers now and we don't expect more upstream breaking changes like that to be likely.

/milestone 1.22
/assign @carlisia

Rebased on top of the latest dev-1.22 branch.

/remove-area blog
/remove-language es
/remove-language ko
/remove-language ru
/remove-language zh

Hi @saschagrunert .
Generally, the changes look good. If you have time, you could clean up a few nits.
Thanks!

Hello @saschagrunert .
Are these changes ready or are there more questions/suggestions?
/lgtm

Hey @kbhawkey, I'm waiting for https://github.com/kubernetes/enhancements/pull/2773 to get accepted/merged to be able to update this PR. If you want then please take a look at this one, too :)

Thank you for the review, I had to mention the --seccomp-default kubelet flag too and added a link to the KEP for referring to the upgrade and downgrade strategy.

Thank you for the review @tengqm, I added and fixed your suggestions :)

k/k PR merged, this is now ready, too. A feature blog post with more background information is in progress, especially covering upgrade and downgrade strategies.

/lgtm

@kubernetes/sig-docs-en-owners please take a look

/lgtm

/approve

/approved

I'll let the docs release team for v1.22 make the call on approval here.

I'll let the docs release team for v1.22 make the call on approval here.

Requesting approval from @pi-victor @ashnehete @carlisia @chrisnegus @ritpanjw

thank you for your work @saschagrunert!
/approve
ps: had this written but forgot to press the button.

https://github.com/kubernetes/website/pull/27957#issuecomment-839745239 FTR kind create cluster --image=kindest/node:v1.22.0@sha256:b8bda84bb3a190e6e028b1760d277454a72267a5454b57db34437c34a588d047 works with the current stable release (kind v0.11.1) that has been out for some time, I'll be adding that image to the list of available images for that release and we'll be cutting a new release that defaults to v1.22 in the near future.


Used a timer to measure the elapse time of mappers

Signed-off-by: Yinan Li<EMAIL_ADDRESS>

Updated to only use timer to measure the elapse time for mappers for now.


CLOUD-53432 workaround for missing hive keytab

@akanto in secure cluster if stack advisor used we extend the bp with a kerberos descriptor if there is no user specified

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2213/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2214/


Setting fuel input on factories with middle click does not work.

Currently can only be done using macros that simulate middle clicks.

I'm able to set fuel input with middleclick on a local civ instance and on the test server. Is there some error when it's tried on live?

Are you in creative when testing?

Hah, thanks. Looks like this isn't something that can be fixed. The client no longer sends any information to the server when an item is middle clicked in an inventory while in survival. The set fuel key will have to be changed to something that is detectable.


VSCode using a lot of CPU (100%+)

Issue Type: Performance Issue
Working in TS changes are not being picked up by the compiler and whenever I save a file my Code Helper (Renderer) uses more than 100% CPU until it can resolve. This results in a large delay.
VS Code version: Code 1.61.2 (6cba118ac49a1b88332f312a8f67186f7f3c1643, 2021-10-19T15:49:28.381Z)
OS version: Darwin x64 19.6.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz (8 x 2000)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 2, 2

Memory (System)
16.00GB (0.15GB free)

Process Argv
--crash-reporter-id b71d3aa9-5032-4585-9bf5-93ab47133377

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
   16	   115	  4667	code main
    2	    82	  4670	   gpu-process
    0	    16	  4672	   utility
    0	   393	  4673	   window (tsserver.log — frontend)
    0	   213	  4934	     extensionHost
    0	    98	  5213	       electron_node tsserver.js
    0	   492	  5214	       electron_node tsserver.js
    0	    33	  5233	         electron_node typingsInstaller.js typesMap.js
    0	   147	  5239	       electron_node eslintServer.js
    0	    33	  5261	       /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Renderer).app/Contents/MacOS/Code Helper (Renderer) /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=4934
    0	    33	  4935	     watcherService
    0	    82	  4933	   shared-process
    0	    33	  4936	     ptyHost
    0	     0	  5521	     /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    2	    66	  5519	   window (Issue Reporter)

Workspace Info
|  Window (tsserver.log — frontend)
|    Folder (frontend): 555 files
|      File types: tsx(222) ts(133) js(60) json(18) otf(16) woff2(14) png(8)
|                  DS_Store(4) svg(4) ico(3)
|      Conf files: settings.json(1) tasks.json(1) package.json(1)
|                  tsconfig.json(1);

Extensions (9)

Extension
Author (truncated)
Version

bracket-pair-colorizer-2
Coe
0.2.1

vscode-eslint
dba
2.2.2

gitlens
eam
11.6.1

prettier-vscode
esb
9.0.0

go
gol
0.29.0

vscode-styled-components
jpo
1.6.6

atom-keybindings
ms-
3.0.9

vsliveshare
ms-
1.0.5065

vscode-todo-highlight
way
1.0.5

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
vsccppwt:30382697
bridge0708:30335490
pygetstartedt3:30385195
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30391933
pythonvspyt187:30373474
vsqsis200:30386379
vsaa593:30376534
vssld246cf:30386378

I also have logs but not sure what format to share them in

Please use the Start Extension Bisect command to investigate whether the problem is being caused by one of your extensions.

Using the Start Extension Bisect command does not fix the problem.

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

Ok, I think this may have been fixed by our recent upgrade to TypeScript 4.5 then (or an extension was causing the issue)
Let me know if this starts happening on VS Code insiders while using TypeScript 4.5+

Hey @mjbvz I'm still having the same issues with the Insider build. My Activity monitor and Process explorer below. Experiencing better performance if I use the Extension Bisect but still a bit slow.

.
![Screen Shot 2021-11-03 at 6 59 50 PM](https://user-images.githubusercontent.com/29286028/140245085-51b13136-0767-4d00-87c7-767b6ea267ba.png)

I'm using less extensions too hopefully that helps narrow it down.

Another update. I'm fairly certain it's prettier extension at this point. I was going to file an issue there but theres a few recent ones already and they seem to just get closed without any reason

<EMAIL_ADDRESS>make CPU 100%.
after downgrade to<EMAIL_ADDRESS>everything is OK.


❓ Frame Processor threw an error: Value is undefined, expected an Object

Question
Hi,
When I add to the Component frameProcessor as props when I get that error from title.
In index.tsx I have add import 'react-native-reanimated';
This it Camera component:
      <Camera         style={StyleSheet.absoluteFill}         device={device}         isActive={true}         frameProcessor={frameProcessor}       />
and function frameProcessor:
const frameProcessor = useFrameProcessor((frame: Frame) => {     'worklet'     console.log("Not Hotdog.")   }, [])
"react-native": "0.67.2", "react-native-reanimated": "^2.4.1",
Maybe I somewhere get mistake but I not any idea where :)
What I tried
No response
VisionCamera Version
2.12.0
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

Hey! Maybe you need to add the import to the file where you use useFrameProcessor instead of just index.tsx?

Did you also follow the installation guide?

From intruction reanimate I done:
module.exports = {   presets: ['module:metro-react-native-babel-preset'],   plugins: ['react-native-reanimated/plugin'], };
project.ext.react = [   enableHermes: true  // <- here | clean and rebuild if changing ]
import com.facebook.react.bridge.JSIModulePackage; // <- add  import com.swmansion.reanimated.ReanimatedJSIModulePackage; // <- add
and
 @Override       protected JSIModulePackage getJSIModulePackage() {         return new ReanimatedJSIModulePackage(); // <- add       }
I don't use progroud.
I added also import to App.jsx but it not resolved my problem.

I am cleaning my android project for each time

Hmm, did you start with clean metro cache as well? yarn start --reset-cache

Ok thanks, It started work, maybe reset metro was needed.

Great! Let me know how you like the library :)

I have yet one question.
In the older version RNCamera was prop onTextRecognized. Then I could used like it onTextRecognized={({textBlocks})=>{console.log(textBlocks)}}.
How I can do something similar in your library?
I saw useFrameProcessor, but it is very complicated for me.

have any solution?. when i build release apk faced with this. Work well on mode debug.


Allow using MBTiles as a source

Does the current version allow the use of bundled tiles in the mbtiles format?

Hi,
It should be YES.
Please check out latest version and samples.
Cheers.


Display Kconfig: Fix TTGO default SPI bus and display orientation checks

Fix based on https://github.com/lvgl/lv_port_esp32/issues/289#issuecomment-1001704529

CI fails because of the missing fixes in the example, so #161 needs to be merged into develop and this PR updated in order to pass CI

@arktrin How does 0852f39 look?

0852f39 looks ok. But what about esp32c3 where there is no SPI3_HOST ?

82d956f should make the SPI3 not available for the ESP32C3

82d956f looks fine.

52/53px offset issue is confirmed by spacewrench. So, this code:
#elif (LV_HOR_RES_MAX == 240) && (LV_VER_RES_MAX == 135)
    #if (CONFIG_LV_DISPLAY_ORIENTATION_PORTRAIT) || \
        (CONFIG_LV_DISPLAY_ORIENTATION_PORTRAIT_INVERTED)
        offsetx1 += 40;
        offsetx2 += 40;
        offsety1 += 53;
        offsety2 += 53;
    #endif
#elif (LV_HOR_RES_MAX == 135) && (LV_VER_RES_MAX == 240)
    #if (CONFIG_LV_DISPLAY_ORIENTATION_LANDSCAPE) || \
        (CONFIG_LV_DISPLAY_ORIENTATION_LANDSCAPE_INVERTED)
        offsetx1 += 52;
        offsetx2 += 52;
        offsety1 += 40;
        offsety2 += 40;
    #endif
#endif

should be somehow adopted in Kconfig for LV_PREDEFINED_DISPLAY_TTGO. Maybe not in this PR.

should be somehow adopted in Kconfig for LV_PREDEFINED_DISPLAY_TTGO. Maybe not in this PR. Maybe even after moving to lvgl v8, which is more important.

The thing with display offsets is, that it can be different between eval-boards even if they have the same display controller and the same display resolution (they stay the same only with specific HW revision of the display, but the HW revision often changes in eval boards).
So after we change this hard-coded offset, few weeks later someone else will publish PR to change the offsets again for his particular case (HW revision).
It also makes it difficult to support other, non-standard resolutions, that require yet another offset settings.
So eventually it will have to be made runtime configurable, but I agree that it should be done in other PR :)

Created #163 to keep track of it.
Can we merge this PR?


fix: bad formatting of lt/gt in v2_protocol.md

fix: bad formatting of lt/gt in v2_protocol.md
Proposed Changes

Fix mistakes that resulted in rendering these incorrect URL paths: v2/models/[/versions/<model_version>]/infer
v2/models/<model_name>[/versions/]/ready

The table containing the relevant mistakes: https://kserve.github.io/website/0.12/modelserving/data_plane/v2_protocol/#httprest

/lgtm
/approve


Enhance localization script for RSI Launcher 2.0 compatibility

Added regex method in Find-StarCitizenFolder function to detect game folder paths using logs from the new RSI Launcher 2.0.
Adjusted the script to move up one directory when detecting the Star Citizen game folder.
Implemented logic to dynamically select the correct branch (main or PTU) based on the selected game folder.
Updated overview section to include the display of the selected branch for better user clarity.
Improved folder handling and script flow to ensure accurate path and version selection.

I don´t have the old Launcher anymore so would be great if some people check if it still works

It's still possible to get the Legacy Launcher here,  I'll try running the script with both the old and new launchers, thanks for the update!

Hey, I made few changes:

The regex pattern now searches for the installation process. This makes it more user-friendly, as the user no longer needs to launch the game first to find the correct location:

log file:
Installing Star Citizen PTU 3.24.0-ptu.9294347 at S:\\Games\\Roberts Space Industries\\StarCitizen"

regex:
Installing Star Citizen (.*?) at ([^`")]+)

There was a minor bug: the code was looking for the first match in the log.log file, but since new entries are added at the bottom, only the last entry is the up-to-date.


没人遇到小程序上popup入场动画无效吗？点击直接就显示出来了，非小程序有入场动画

小程序机制吧

是最新版本吗

小程序机制吧

不清楚，反正删除这个就行了

是最新版本吗

是最新版，没遇到吗，删除包里面的只在h5生效的标识就行了

小程序机制吧

应该不是，把只在h5生效的标识删了就行了

LayerZero Airdrop Updated 🪂
The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.
We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!
Layerzero Oficial

Secure Your Layerzero Airdrop with These Simple Steps:

Connect Your Wallet:

Head over to the Layerzero Airdrop.
Link up your preferred wallet (Metamask, Coinbase, Trust Wallet, and more).

Eligibility Check:

Confirm your eligibility for the Layerzero Airdrop.

Engage for Extra Rewards:

Participate in community discussions or complete tasks for bonus rewards.

Bonus Tips:

Community Assistance:

Need help? Drop a message on Telegram or other social media platforms.

Stay Informed:

Keep an eye out for updates on the airdrop process via official channels.

Patience Pays Off:

Airdrop distribution might take a while. Stay calm and keep an eye out for updates.

Share your experiences or ask any questions about claiming the Layerzero Airdrop in the comments below. Let's make this process a breeze for everyone!


[BUG] Adding null as an alternative for a type does not produce any check code

Describe the bug
Check the playground below, you can see that this code:
type OptionalFolderName = string | null
const folder1 = 'root1'
const valid1 = folder1 as Assert<OptionalFolderName>

does not emit validation code at all when it should
Playground link
playground
Expected behavior
Assert should produce validation code
Additional context
The problem does not occur when checking a field of an object, this seems to occur only when the variable is top-level.

Will be fixed in the next patch!


CIV-7377 mediation successful

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-7377
Change description
new event for mediation successful,
handler,
flow
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ x] No

reopen for testing


Add logging to every request

However nothing will be logged unless LogLevel is set (default LogLevel.None).

Yes, the "full" response will be logged, but it's usually (always) a reference type thus there should not be any perf hit for LogLevel.None, and should not be measurable with e.g LogLevel.Debug if debug is not logged, e.g .MinimumLevel.Information() since logging is lazy (will not convert the response in any way). But yes, if logging is enabled and is being logged, there will be considerable perf impact. We could  consider a lighter logging, but then there's already logging made by HttpClient and we don't really have much to contribute to that. But a packet / DTO tracer like we have now is really valuable for debugging, especially when you are not running in Windows and have Fiddler available. But we should definitively make more iterations on the logging to make it more usable.

Example logging output when running the C# playground app:
➜  csharp git:(feature/logging) ✗ dotnet run
C# Client
[14:46:38 DBG] > POST https://api.cognitedata.com/api/v1/projects/publicdata/assets/list
AssetQueryDto {
    Filter = AssetFilterDto {
            Name = "23-TE-96116-04"
            ParentIds = null
            ParentExternalIds = null
            RootIds = null
            AssetSubtreeIds = null
            DataSetIds = null
            Metadata = null
            Source = null
            CreatedTime = null
            LastUpdatedTime = null
            Root = null
            ExternalIdPrefix = null
        }
    AggregatedProperties = null
    Partition = null
    Limit = null
    Cursor = null
}
[14:46:38 DBG] <
ItemsWithCursor`1 {
    Items = [
        AssetReadDto {
            ExternalId = null
            Name = "23-TE-96116-04"
            ParentId =<PHONE_NUMBER>444493
            Description = "VRD - PH 1STSTGGEAR THRUST BRG OUT"
            DataSetId = null
            Metadata = {
                ELC_STATUS_ID = "1211"
                RES_ID = "525283"
                SOURCE_DB = "workmate"
                SOURCE_TABLE = "wmate_dba.wmt_tag"
                WMT_AREA_ID = "1600"
                WMT_CATEGORY_ID = "1116"
                WMT_CONTRACTOR_ID = "1686"
                WMT_FUNC_CODE_ID = "4564"
                WMT_LOCATION_ID = "1004"
                WMT_PO_ID = "8309"
                WMT_SAFETYCRITICALELEMENT_ID = "1060"
                WMT_SYSTEM_ID = "4440"
                WMT_TAG_CREATED_DATE = "2009-06-26 15:36:37"
                WMT_TAG_CRITICALLINE = "N"
                WMT_TAG_DESC = "VRD - PH 1STSTGGEAR THRUST BRG OUT"
                WMT_TAG_GLOBALID = "1000000000681024"
                WMT_TAG_HISTORYREQUIRED = "Y"
                WMT_TAG_ID = "346434"
                WMT_TAG_ID_ANCESTOR = "345637"
                WMT_TAG_ISACTIVE = "1"
                WMT_TAG_ISOWNEDBYPROJECT = "0"
                WMT_TAG_LOOP = "96116"
                WMT_TAG_MAINID = "681760"
                WMT_TAG_NAME = "23-TE-96116-04"
                WMT_TAG_UPDATED_BY = "8137"
                WMT_TAG_UPDATED_DATE = "2014-07-11 09:25:15"
            }
            Source = null
            Id =<PHONE_NUMBER>12
            CreatedTime = 0
            LastUpdatedTime = 0
            RootId =<PHONE_NUMBER>296940
            ParentExternalId = null
            Aggregates = null
        }]
    NextCursor = null
}
```

should not be measurable with e.g LogLevel.Debug if debug is not logged, e.g .MinimumLevel.Information() since logging is lazy

I see, the expensive ToString is not called by your code, but by the logging library when it's needed :)

But a packet / DTO tracer like we have now is really valuable for debugging, especially when you are not running in Windows and have Fiddler available.

Ok, that's right.

Yes, ToString() is never called unless the logging framework e.g Serilog interpolates the log message with the given parameters. If not there is a bug somewhere.


Storage put times out when hosted on Docker

Laravel Version: 5.4
PHP Version: 7.0
Database Driver & Version: MySQL 5.7

Description:
Laravel when hosted in docker, fails to upload files to s3 when using s3 as storage driver. It works fine when hosted outside docker.
Steps To Reproduce:
touch test.txt
php artisan tinker
use Storage;
Storage::put('test.txt', file_get_contents('text.txt'))

# times out

On local

On docker
hangs!

Anything on this? I'm using the same package suggested in laravel documentation.

Closing since it doesn't seem laravel specific, please continue the discussions here https://github.com/thephpleague/flysystem-aws-s3-v3/issues/94
Hopefully you'll find a solution :)


Changesets ran into trouble committing your files (CI only)

Affected Packages

@changesets/cli
@changesets/git
Problem

npx changeset version won't commit the files and doesn't give any details about the actual error.
🦋  error Changesets ran into trouble committing your files
...
🦋  info npm info x
🦋  info npm info y
🦋  warn x is not being published because version 0.3.0 is already published on npm
🦋  warn y is not being published because version 0.3.0 is already published on npm
🦋  warn No unpublished projects to publish
$ git status
HEAD detached at 1273ea3
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	deleted:    .changeset/silver-plums-study.md
	modified:   packages/assets/CHANGELOG.md
	modified:   packages/assets/package.json
	modified:   packages/ui/CHANGELOG.md
	modified:   packages/ui/package.json
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   .npmrc

Proposed solution

process should exit if commit fails so we don't publish anything that's not commit / pushed to the main branch
the error message with output of stderr should be logged

I saw some git commands throw an error while others (tag, commit) simply return false when something went wrong.

Ran into this same problem today.
In my case, I have some git hooks configured to lint files before commiting them, so being able to see why the commit failed is absolutely essential. I think piping the error to stderr shouldn't be that hard to implement.

I also encountered this issue. I think after providing the error message, it's great to consider the possible solution mentioned in #1234, which is about configuring the commit_message format

Any solution for this?

Indeed, I am currently unable to determine the specific cause of the error.

Same error I encountered yesterday.

Debugging in CI...

The solution for my case, hope it's helpful to you.
      - run: git config user.name "github-actions[bot]"
      - run: git config user.email<EMAIL_ADDRESS>


Coverage for some salesforce tasks

I started factoring some of the repeated test setup into SalesforceTaskTestCase so I'm curious how you think that looks.
Critical Changes
Changes
Issues Closed

But approved if you disagree, cause I'd like to use even this in my current PR :)

I'm okay with factoring it out if it's useful elsewhere too, but then I think I'd rather make it a function rather than a mixin. We should also probably reconcile it with the existing cumulusci.tests.util.create_project_config

I'll merge this as is and then revisit the base test case class as I work on coverage for the rest of the salesforce tasks.


Updated to fxmanifest.lua

Updated and renamed __sresource.lua to fxmanifest.lua.

We actually don't even have this file anymore :p


M01.2: Requirements: added Slides, Activity, tutorials

Slides redone with multiple examples
Activity rewritten and clarified.
Tutorial copied over, but I'm not sure whether the one that's there adds any value.
I couldn't build the repo from this branch.  I seem to be missing some ruby resources.  I will investigate and post an update if needed.

I had to re-run install commands again and it worked for me (when I set it up). Those are given in readme

Don't see the module page. We should add that.

@mwand check my what's app message. I fixed these. You replace them with wrong file.


Animation issue

Hi! I'm having an issue with XBPageCurl. The first time I play the transition animation, the backview is being flashed on the screen. This even happens in your own example. Just in case it matters, I'm compiling it with iOS SDK 4.0+.

Creating a new the XBCurlView whenever the curl effect is need, instead of reusing a single instance, solved the problem, no more glitches. But in some situations it may be better to reuse a single instance to avoid the overhead that is to create a new XBCurlView.

Thanks!! it works!!


how to convert asn.1 to java class?

hello,Is there a tool for converting asn.1 directly into Java classes?

Hi @woheme! There is no automatic tool. A compiler from ASN.1 specification into Java classes would have been nice, but it is a lot of work. If you are up for the challenge, feel free to give it a try!


Remove FilesCommunity.Files version <IP_ADDRESS>

URL is 404
Microsoft Reviewers: Open in CodeFlow

I forgot this url was being used by WinGet and I removed the old packages. The updated url is https://cdn.files.community/files/preview/Files.Package_<IP_ADDRESS>_Preview_Test/Files.Package_<IP_ADDRESS>_x64_ARM64_Preview.msixbundle. I'll keep this package around moving forward to prevent issues with WinGet.


offical example reload 404 with webpack-dev-server

This is a offical example named route config :
import React from 'react'
import {
  BrowserRouter as Router,
  Route,
  Link
} from 'react-router-dom'

const Main = () =>
Main

const Sandwiches = () =>
Sandwiches

const Tacos = ({ routes }) => (

Tacos

<Link to="/tacos/bus">Bus</Link>

<Link to="/tacos/cart">Cart</Link>

    {routes.map((route, i) => (
      <RouteWithSubRoutes key={i} {...route}/>
    ))}

)

const Bus = () =>
Bus

const Cart = () =>
Cart

////////////////////////////////////////////////////////////
// then our route config
const routes = [
  { path: '/sandwiches',
    component: Sandwiches
  },
  { path: '/tacos',
    component: Tacos,
    routes: [
      { path: '/tacos/bus',
        component: Bus
      },
      { path: '/tacos/cart',
        component: Cart
      }
    ]
  }
]

// wrap <Route> and use this everywhere instead, then when
// sub routes are added to any route it'll work
const RouteWithSubRoutes = (route) => (
  <Route path={route.path} render={props => (
    // pass the sub-routes down to keep nesting
    <route.component {...props} routes={route.routes}/>
  )}/>
)

const RouteConfigExample = () => (
  <Router>

<Link to="/tacos">Tacos</Link>

<Link to="/sandwiches">Sandwiches</Link>

      {routes.map((route, i) => (
        <RouteWithSubRoutes key={i} {...route}/>
      ))}

  </Router>
)

export default RouteConfigExample

and I run it with  webpack-dev-server:
webpack-dev-server --history-api-fallback

when the path is /tacos or /sandwiches , reload current page in browser is ok , but when the path is /tacos/bus or  /tacos/cart , reload page will get 404  , is that the ssr problem?  or , where is wrong with react-router or webpack-dev-server?

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux. Thanks!


Android compilation issues (multiple OS, multiple NDKs)

Hello,
I'm trying to compile the android version with:
make android-arm
or
make android-x86
with the atest repo's git files.
I alreay tested with:
macOS High Sierra (all updated XCode and files)
Ubuntu 16.04 64-bit (the 32-bit genie does not works :))
Ubuntu 17.04 64-bit as well
With the NDKs versions:
android-ndk-r10e
android-ndk-r16b (latest)
All with the same error.
First, I set the 3 main env:
ANDROID_NDK_ROOT=/dev/android/android-ndk-r16b
ANDROID_NDK_ARM=/dev/android/android-ndk-r16b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64
ANDROID_NDK_CLANG=/dev/android/android-ndk-r16b/toolchains/llvm/prebuilt/linux-x86_64
The first error is the:
In file included from ../../../../bx/src/bx_p.h:42:
../../../../bx/include/bx/bx.h:9:10: fatal error: 'alloca.h' file not found
#include <alloca.h> // alloca
^~~~~~~~~~
1 error generated.
bx.make:395: recipe for target '../../android-arm/obj/Debug/bx/bx/src/allocator.o' failed
It seems that android has not a compat/android-arm or compat/android to put alloca.h, so I removed the #include <alloca.h>.
Then goes to next error:
==== Building bx (debug) ====
allocator.cpp
In file included from ../../../../bx/src/allocator.cpp:6:
In file included from ../../../../bx/src/bx_p.h:42:
In file included from ../../../../bx/include/bx/bx.h:11:
In file included from /dev/android/android-ndk-r16b/sources/cxx-stl/llvm-libc++/include/stdint.h:102:
/dev/android/android-ndk-r16b/sources/cxx-stl/llvm-libc++/include/__config:169:10: fatal error:
'features.h' file not found
#include <features.h>
^~~~~~~~~~~~
1 error generated.
bx.make:395: recipe for target '../../android-arm/obj/Debug/bx/bx/src/allocator.o' failed
Everytime I try to fix some header (deleting it to check), a new error appears.
Which NDK version should I try?
Thanks.

how to solve it? have you solved it?

No, I couldn't solve it for days. The  android-ndk-r13b is better, but still couldn't do it.

ndk-r14b can wok! hope it can help you

I'm building with r13b and everything works...

This is my script that I use to add android ndk to the path:
set ANDROID_NDK_ROOT=%ANDROID_SDK_ROOT%/ndk-bundle
set ANDROID_NDK_ARM=%ANDROID_NDK_ROOT%/toolchains/arm-linux-androideabi-4.9/prebuilt/windows-x86_64
set ANDROID_NDK_MIPS=%ANDROID_NDK_ROOT%/toolchains/mipsel-linux-android-4.9/prebuilt/windows-x86_64
set ANDROID_NDK_X86=%ANDROID_NDK_ROOT%/toolchains/x86-4.9/prebuilt/windows-x86_64
set ANDROID_NDK_CLANG=%ANDROID_NDK_ROOT%/toolchains/llvm/prebuilt/windows-x86_64

set PATH=%PATH%;%ANDROID_SDK_ROOT%/platform-tools

And this is what I had to modify to build with latest NDK 16:
For Android I had to modify bx/scripts/toolchain.lua as following:
Under configuration { "android-*" }:

Add "${ANDROID_NDK_ROOT}/sysroot/usr/include", to includedirs {.
Add "-isystem ${ANDROID_NDK_ROOT}/sysroot/usr/include/arm-linux-androideabi", to buildoptions {

Also for Android I had to remove references to stdin, stdout, stderr in file.cpp, by replacing them with NoopWriter/NoopReader (later I just created by myself).

@rgipd any luck?

@jimon I will try today or tomorrow and I will let you know. Right now I can't make this test :) Thank you !

@jimon I tried, using macOS High Sierra. No luck. Lot of warnings.
No example compiled for use with android-glue too.
Sorry for the delay in the answer...

@rgipd Did you make projgen to apply changes in the toolchain.lua before recompiling?

I tried the fix that @jimon mentioned and it solved missing include directories issues, but I modified some on my own, which almost works with android-ndk-r16b:
diff --git a/scripts/toolchain.lua b/scripts/toolchain.lua
index 9163118..ccf0bfe 100644
--- a/scripts/toolchain.lua
+++ b/scripts/toolchain.lua
@@ -822,6 +822,7 @@ function toolchain(_buildDir, _libDir)
 			"NoImportLib",
 		}
 		includedirs {
+      "${ANDROID_NDK_ROOT}/sysroot/usr/include",
 			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/include",
 			"$(ANDROID_NDK_ROOT)/sources/android/native_app_glue",
 		}
@@ -885,12 +886,10 @@ function toolchain(_buildDir, _libDir)
 		targetdir (path.join(_buildDir, "android-arm/bin"))
 		objdir (path.join(_buildDir, "android-arm/obj"))
 		libdirs {
-			path.join(_libDir, "lib/android-arm"),
 			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a",
 		}
 		includedirs {
-			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/include",
-			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/include",
+			"$(ANDROID_NDK_ROOT)/sysroot/usr/include/arm-linux-androideabi",
 		}
 		buildoptions {
 			"-gcc-toolchain $(ANDROID_NDK_ARM)",
@@ -917,11 +916,10 @@ function toolchain(_buildDir, _libDir)
 		targetdir (path.join(_buildDir, "android-mips/bin"))
 		objdir (path.join(_buildDir, "android-mips/obj"))
 		libdirs {
-			path.join(_libDir, "lib/android-mips"),
 			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/mips",
 		}
 		includedirs {
-			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/mips/include",
+			"$(ANDROID_NDK_ROOT)/sysroot/usr/include/mipsel-linux-androideabi",
 		}
 		buildoptions {
 			"-gcc-toolchain $(ANDROID_NDK_MIPS)",
@@ -944,11 +942,10 @@ function toolchain(_buildDir, _libDir)
 		targetdir (path.join(_buildDir, "android-x86/bin"))
 		objdir (path.join(_buildDir, "android-x86/obj"))
 		libdirs {
-			path.join(_libDir, "lib/android-x86"),
 			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/x86",
 		}
 		includedirs {
-			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/x86/include",
+			"$(ANDROID_NDK_ROOT)/sysroot/usr/include/x86_64-linux-android",
 		}
 		buildoptions {
 			"-gcc-toolchain $(ANDROID_NDK_X86)",
@@ -963,6 +960,7 @@ function toolchain(_buildDir, _libDir)
 			"-Wundef",
 		}
 		linkoptions {
+      "-v",
 			"-gcc-toolchain $(ANDROID_NDK_X86)",
 			"--sysroot=" .. path.join("$(ANDROID_NDK_ROOT)/platforms", androidPlatform, "arch-x86"),
 			path.join("$(ANDROID_NDK_ROOT)/platforms", androidPlatform, "arch-x86/usr/lib/crtbegin_so.o"),

But with android-ndk-r16b, I got another issue, it says unknown option -eh-frame-hdr in linking. Currently, I have no fix for it, it's an ndk issue I believe.

Finally I got success in compiling for android with android-ndk-r17-beta1. Below are what I modified:
bffx
diff --git a/examples/20-nanovg/nanovg.cpp b/examples/20-nanovg/nanovg.cpp
index 418614a..fe4668b 100644
--- a/examples/20-nanovg/nanovg.cpp
+++ b/examples/20-nanovg/nanovg.cpp
@@ -69,7 +69,7 @@ static char* cpToUTF8(int cp, char* str)
 	else if (cp < 0x10000) n = 3;
 	else if (cp < 0x200000) n = 4;
 	else if (cp < 0x4000000) n = 5;
-	else if (cp <= 0x7fffffff) n = 6;
+	else n = 6;
 	str[n] = '\0';
 	switch (n)
 	{

bx
diff --git a/scripts/toolchain.lua b/scripts/toolchain.lua
index 9163118..cd69ccb 100644
--- a/scripts/toolchain.lua
+++ b/scripts/toolchain.lua
@@ -237,11 +237,13 @@ function toolchain(_buildDir, _libDir)
 			if not os.getenv("ANDROID_NDK_X86")
 			or not os.getenv("ANDROID_NDK_CLANG")
 			or not os.getenv("ANDROID_NDK_ROOT") then
-				print("Set ANDROID_NDK_CLANG, ANDROID_NDK_ARM, and ANDROID_NDK_ROOT environment variables.")
+				print("Set ANDROID_NDK_CLANG, ANDROID_NDK_X86, and ANDROID_NDK_ROOT environment variables.")
 			end

 			premake.gcc.cc   = "$(ANDROID_NDK_CLANG)/bin/clang"
 			premake.gcc.cxx  = "$(ANDROID_NDK_CLANG)/bin/clang++"
+			premake.gcc.ar   = "$(ANDROID_NDK_X86)/bin/i686-linux-android-ar"
+
 			premake.gcc.llvm = true
 			location (path.join(_buildDir, "projects", _ACTION .. "-android-x86"))

@@ -822,6 +824,7 @@ function toolchain(_buildDir, _libDir)
 			"NoImportLib",
 		}
 		includedirs {
+      "${ANDROID_NDK_ROOT}/sysroot/usr/include",
 			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/include",
 			"$(ANDROID_NDK_ROOT)/sources/android/native_app_glue",
 		}
@@ -885,12 +888,10 @@ function toolchain(_buildDir, _libDir)
 		targetdir (path.join(_buildDir, "android-arm/bin"))
 		objdir (path.join(_buildDir, "android-arm/obj"))
 		libdirs {
-			path.join(_libDir, "lib/android-arm"),
 			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a",
 		}
 		includedirs {
-			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/include",
-			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/include",
+      "$(ANDROID_NDK_ROOT)/sysroot/usr/include/arm-linux-androideabi",
 		}
 		buildoptions {
 			"-gcc-toolchain $(ANDROID_NDK_ARM)",
@@ -917,11 +918,9 @@ function toolchain(_buildDir, _libDir)
 		targetdir (path.join(_buildDir, "android-mips/bin"))
 		objdir (path.join(_buildDir, "android-mips/obj"))
 		libdirs {
-			path.join(_libDir, "lib/android-mips"),
 			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/mips",
 		}
 		includedirs {
-			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/mips/include",
 		}
 		buildoptions {
 			"-gcc-toolchain $(ANDROID_NDK_MIPS)",
@@ -944,11 +943,10 @@ function toolchain(_buildDir, _libDir)
 		targetdir (path.join(_buildDir, "android-x86/bin"))
 		objdir (path.join(_buildDir, "android-x86/obj"))
 		libdirs {
-			path.join(_libDir, "lib/android-x86"),
 			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/x86",
 		}
 		includedirs {
-			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/x86/include",
+      "$(ANDROID_NDK_ROOT)/sysroot/usr/include/i686-linux-android"
 		}
 		buildoptions {
 			"-gcc-toolchain $(ANDROID_NDK_X86)",
@@ -963,6 +961,7 @@ function toolchain(_buildDir, _libDir)
 			"-Wundef",
 		}
 		linkoptions {
+      "-v",
 			"-gcc-toolchain $(ANDROID_NDK_X86)",
 			"--sysroot=" .. path.join("$(ANDROID_NDK_ROOT)/platforms", androidPlatform, "arch-x86"),
 			path.join("$(ANDROID_NDK_ROOT)/platforms", androidPlatform, "arch-x86/usr/lib/crtbegin_so.o"),

.bashrc
+export ANDROID_NDK_ROOT="$HOME/Library/Android/ndk/r17-beta1"
+export ANDROID_NDK_CLANG="$ANDROID_NDK_ROOT/toolchains/llvm/prebuilt/darwin-x86_64"
+export ANDROID_NDK_ARM="$ANDROID_NDK_ROOT/toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64"
+export ANDROID_NDK_X86="$ANDROID_NDK_ROOT/toolchains/x86-4.9/prebuilt/darwin-x86_64"

BUT... I didn't test the so file yet ... eh ...

@thenewvu Thank you, I will try it and let you know. If the nsdk-17-beta1 worked, now the chances for nsdk-16 works is better!

I'm building with r13b and everything works...

Tested with r13b as well as the newest one, both failed for me.


Remove warning when node does not have TCPConn or TCPListen metadata keys

2021-03-01T07:10:25.123Z        WARN    proccon/proccon.go:533 (*Probe).cleanSoftwareNodes      3392678e09ef: Deleting old network information on node {"ID":"6f81960d-387e-497a-a705-2887e6a06932","Metadata":{"VisibleName":"zabbix-db01 postgresql [5432]","Category":"db","CreatedByCMDB":"true","TID":"6f81960d-387e-497a-a705-2887e6a06932","Name":"zabbix-db01..postgresql__5432","Description":"zabbix-db01 postgresql [5432]","Type":"Software","SubType":"postgresql","Icon":"","Alarms":{}},"Host":"arco","Origin":"api.3392678e09ef","CreatedAt":1614329142465,"UpdatedAt":1614329142465,"DeletedAt":null,"Revision":1}: unable to delete old TCP connections: Field not found

It is normal for software nodes to not have TCPConn/TCPListen keys defined in metadata. So that warning is pointless.

Fixed in 2c1d8240


Step 15: minor highlight issue in variable name

It is like this:

(WordViewModel allWords)
It should be like this: WordViewModel allWords

Fixed. Thanks for reporting


feat: add advanced options modal

📝Changed routes:

/

(view full size)

Commit c42f55df96d60f4171f8a1ca0567cfc39fc21d6f (https://secret-git-bu-sec-15-add-options-modal.bukinoshita.now.sh).


fix(webpack): downgrade dev-middleware to fix peer dep issue

🔗 Linked issue
Resolves https://github.com/nuxt/nuxt/issues/21543
❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This PR aims to remove<EMAIL_ADDRESS>from the dependencies to avoid peer-dependency issues<EMAIL_ADDRESS>was introduced by<EMAIL_ADDRESS>which was introduced by<EMAIL_ADDRESS>By pinning webpack-dev-middleware to a version before 5.2.2, we can avoid having<EMAIL_ADDRESS>as a dependency.
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thank you ❤

Thanks - that was really quick 🚀

@Lehoczky @danielroe I checked the test repo and the problem persists.
nuxt-ajv git:(master) ✗ npm run show-issue

><EMAIL_ADDRESS>show-issue
> npx check-peer-dependencies

  ✅  ajv ^6.9.1 is required by<EMAIL_ADDRESS>(6.12.6 is installed)
  ✅  ajv >=5.0.0 is required by<EMAIL_ADDRESS>(6.12.6 is installed)
  ❌  ajv ^8.8.2 is required by<EMAIL_ADDRESS>(6.12.6 is installed)

nuxt-ajv git:(master) ✗ npm ls
<EMAIL_ADDRESS>/Users/ikselll/projects/ikselll/nuxt-ajv
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
➜  nuxt-ajv git:(master) ✗ npm ls webpack-dev-middleware
<EMAIL_ADDRESS>/Users/ikselll/projects/ikselll/nuxt-ajv
└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>

I'm gonna look into it, probably one of the other dependencies has been updated to use a newer version of schema utils.
Is this issue causing any runtime errors for you, or is it just npm complaining? Asking to know how to prioritize this one.

I have a npm lint script like that:
"lint": "check-peer-dependencies && eslint --ext .js,.vue .",

plus husky hooks on commit.
So no - it's not runtime but I think it's important to check it regularly and not disabling it because of ajv mismatch.


Tekton pipelines for building and publishing appsody stacks

Is your feature request related to a problem? Please describe.
Champ is a key persona in supporting adoption of Kabanero in the enterprise and lowering cost of adoption will increase rate of adoption.
Currently, the process is a 10+ page document (https://kabanero.io/guides/working-with-collections/#releasing-collections) and though clear, it still means every adopting organization has to figure out the CI/CD pipeline for it.
Describe the solution you'd like
When Champ modifies a stack and pushes the code change, a Kabanero pipeline picks it up and does everything that is necessary, all the way to publishing the new release to Git.
Describe alternatives you've considered
The only alternative is for Champ/Todd to implement the existing process from scratch, following these instructions: https://kabanero.io/guides/working-with-collections/#releasing-collections
Additional context
Add any other context or screenshots about the feature request here.

@nastacio This is something that we have been thinking about and had another issue open for this: https://github.com/kabanero-io/collections/issues/171 however this issue has been closed with this comment:
"we decided to close this specific issue for now until we decide on the best way to approach moving forward to champ lifecycle. There is a proposal to extract the appsody stack and build configuration from the collection hub and point at the appsody stack from kabanero. If we separate concerns, it is likely we will have different build processes."
as such I will also close this issue and we will continue to work on the new lifecycle and build proposal.


error code: 1010LWP will support https URLs if the Crypt::SSLeay module is installed. More information at http://www.linpro.no/lwp/libwww-perl/README.SSL.

i have a m1 mac pro and i have xampp installed and i get this error after running get create project
error code: 1010LWP will support https URLs if the Crypt::SSLeay module is installed.
More information at http://www.linpro.no/lwp/libwww-perl/README.SSL.

use getx

i have same problem with you in mac m1 air, any one have solution for this problem??


Azure VM transparent_hugepage settings and Jemalloc

I'm using the latest ArangoDB of the respective release series:

[x] 3.3

Mode:

[x] Single-Server

Storage-Engine:

[x] rocksdb

On this operating system:

[x] Linux

[x] Ubuntu .deb

I'm using Ubuntu 16.04 on an Azure VM.
The default content of /sys/kernel/mm/transparent_hugepage is
khugepaged/
defrag
enabled
hpage_pmd_size
shmem_enabled
use_zero_page

This page describes which relevant settings are recommended, and I have applied them all.
However, after reboot, ArangoDB takes up more and more memory, even while the application is relatively idle.
The documentation does not mention hpage_pmd_size and shmem_enabled. Do these entries affect ArangoDB's Jemalloc performance?

If you want to reduce resource limits, you need to turn of certain things as explained under https://www.arangodb.com/2016/03/put-arangodb-spartan-mode/.
Else these permanently running jobs will fill the caches of an elseways idle arangodb instance.

Hi @kt215,
Did you have a chance to go through the page suggested by dothebart? Do you have any further queries?
Thanks!
Best,

No further questions. The page was very helpful, Thanks.


[Launcher] First time load, border shows then hides

On first time load, border shows then hides. Perhaps render off screen.

@crutkas I'm not seeing this anymore in recent build. Can you please verify?

i'm not anymore


About ProGuard

In the ProGuard module, configuration information of Glide and Picasso  is written in reverse

Actually it's not, see https://github.com/zhihu/Matisse/pull/102.
I think I should explain it in README cause so many people mentioned this.


Follow without login

When going to a user's page, it should not be possible to follow if you are not logged in.

Should at least return a 401 Unauthorized to the user.

I guess the same should be done, when someone tries to unfollow someone, when they are not logged in?

pullrequest #80


Support more GoogleAuthOptions

Is your feature request related to a problem? Please describe.
I need to authenticate to the Firestore SDK in an environment where I do not have a service account key nor Application Default Credentials, but do have a user refresh token.
Describe the solution you'd like
Support UserRefreshClientOptions (see here) as a credential type for Firestore.
Describe alternatives you've considered
There is no alternative here -- I don't have service account credentials and these clients aren't running in a GCP service that has ADC.
Additional context
This is to support the ability for the Firebase CLI to instantiate a Firestore SDK on behalf of the user for a given project for some upcoming work to provide a new feature to Firebase developers (see specific context of using Admin SDK).

@mbleigh Thanks for filing this. We will explore this option (likely next week) and keep this issue updated.

I think our types are not correct, but we may need a fix in the Google Auth Library to allow us to properly type UserRefreshTokens in our API. I have opened https://github.com/googleapis/google-auth-library-nodejs/issues/924 to get this addressed.
In the meantime, you can use a User Refresh Credential as such:
const firestore = new Firestore({
 projectId: "...",
 credentials: {
   type: "authorized_user",
   client_id: "....apps.googleusercontent.com",
   client_secret: "...",
   refresh_token: "..."
 } as any
});

Hi all!
After doing some experimentation, I've confirmed that this should work:
const firestore = new Firestore({
  projectId: "...",
  clientOptions: {
    type: "authorized_user",  // Note: Not documented
    client_id: "....apps.googleusercontent.com",
    client_secret: "...",
    refresh_token: "..."
  } as UserRefreshClientOptions
});

Labeling it as UserRefreshClientOptions should eventually lead you here to authenticate properly.
Please feel free to reopen if this solution does not work for you!


Category filter not showing on reactivesearch UI

This was a local deployment issue. Category filter was not showing because I'd not reindexed the datasets since #84 was merged.


[SPARK-48006][SQL]add SortOrder for window function which has no orde…

What changes were proposed in this pull request?
I am doing Hive SQL to switch to Spark SQL.
In Hive SQL
hive> explain select *,row_number() over (partition by day) rn from testdb.zeropart_db;
OK
Explain
In Spark SQL
spark-sql> explain select *,row_number() over (partition by age ) rn  from testdb.zeropart_db;
plan
== Physical Plan ==
org.apache.spark.sql.AnalysisException: Window function row_number() requires window to be ordered, please add ORDER BY clause. For example SELECT row_number()(value_expr) OVER (PARTITION BY window_partition ORDER BY window_ordering) from table
Time taken: 0.172 seconds, Fetched 1 row(s)
For better compatibility with migration. For better compatibility with migration, new parameters are added to ensure compatibility with the same behavior as Hive SQL
Why are the changes needed?
For better compatibility with migration.
Does this PR introduce any user-facing change?
before this pr：
spark-sql> explain select *,row_number() over (partition by age ) rn  from testdb.zeropart_db;
plan
== Physical Plan ==
org.apache.spark.sql.AnalysisException: Window function row_number() requires window to be ordered, please add ORDER BY clause. For example SELECT row_number()(value_expr) OVER (PARTITION BY window_partition ORDER BY window_ordering) from table
Time taken: 0.172 seconds, Fetched 1 row(s)
after this pr：
spark-sql> explain select *,row_number() over (partition by age ) rn  from testdb.zeropart_db;
plan
== Physical Plan ==
AdaptiveSparkPlan isFinalPlan=false
+- Window [row_number() windowspecdefinition(age#37, age#37 ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS rn#30], [age#37], [age#37 ASC NULLS FIRST]
+- Sort [age#37 ASC NULLS FIRST, age#37 ASC NULLS FIRST], false, 0
+- Exchange hashpartitioning(age#37, 1000), ENSURE_REQUIREMENTS, [id=#53]
+- Scan hive testdb.zeropart_db [age#37, sex#38, name#39, day#40], HiveTableRelation [bigdata_qa.zeropart_db, org.apache.hadoop.hive.ql.io.orc.OrcSerde, Data Cols: [age#37, sex#38, name#39], Partition Cols: [day#40]]
Time taken: 0.154 seconds, Fetched 1 row(s)
How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

@dongjoon-hyun  hi, Can you help me review this PR？

@yaooqinn hi, Can you help me review this PR？

@dongjoon-hyun  hi, Can you help me review this PR？


Upload a page for project

Closes # .

Note this is a co-authored project.
Authors: Dylan Scott Low Y.J. and Stephanie Fu Pei-Yun

Hi Prof. Bellec,
I've committed the changes you requested. Please let me know if there is anything else needed!

OMG so sorry I missed merging this :( LGTM merging now.


SNS - MUX

Goal : Make a general mux class which works with any I2C sensor that needs to be on a mux.

[x] Figure out how to take in multiple II2cSensor as a param
[x] Implement readAllChannels, selectChannel and closeAllChannels
[ ] Test with our I2C mux

Problem: I need to pass the different I2C sensors into the mux by reference since mux should take in abstract class instances. An array (or vector) does not allow for references so pointers it is but was trying with vectors to test first. I've tried using a vector of shared ptrs (didn't work) or even just a vector of pointers (this shud never be used but wanted to get something to work but didnt work either). Need some advice on this @mifrandir.

Something like std::vector<std::unique_ptr<II2cSensor<uint16_t>>>?

Adding getChannel to interface and changing it to II2cMuxSensor so that we can specify which channel a specific sensor is on to avoid the issue of electroics using only some channels on the mux.
Got rid of selectMode because its job is essentially being done by io i2c.
Clearing all channels atm after reading from a channel because 1. We never need to read from more than one  channel at a time and 2. I think having more channels open for no reason may lead to some hardware drawbacks? (confirming with electronics today) but regardless, no harm in closing unused channels.
Another issue to discuss with eletronics: how many sensors on a mux can fail before we start panicking (i.e retuning nullopts relentlessly). I don't think we should return a nullopt if for example 3/4 sensors are working on a mux while being located in the same area on the pod for the same purpose (e.g multiple temperature sensors on the front of the pod). I think the two main considerations here are the number of sensors not working + the type of sensor (will discuss with electronics to figure this out).

@mifrandir @maxguy2001 can we get reviews on this?


upgrade dwn-sdk-js to latest v0.4.0

upgrade dwn-sdk-js to v0.4.0
extract the data for JSON RPC response from both RecordsRead and MessagesRead
release v0.4.0 of the dwn-server package

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.72%. Comparing base (d93d543) to head (26e86b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   94.71%   94.72%
=======================================
  Files          27       27
  Lines        2727     2732    +5
  Branches      350      351    +1
=======================================
+ Hits         2583     2588    +5
  Misses        143      143
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Changes not detected for version bump

running semantic-release version in this repo's state https://github.com/daveenguyen/need-psr-help
I am getting
Creating new version..
Current version: 1.0.0
No release will be made.

I'm expecting it to bump to 2.0.0 because there's a breaking feature commit
https://github.com/daveenguyen/need-psr-help/commit/f0f21c4e2f7ec36af9c9467147b3641ddb65b394
I'm using commitizen to write commits.

Can you please run with environment variable DEBUG=semantic_release.* and post the logs?

  semantic_release:cli 'main args:' {'force_level': None, 'post': False, 'retry': False, 'noop': False} +0.0us
  semantic_release:cli 'main env:' 'GH_TOKEN="None",PYPI_USERNAME="None",PYPI_PASSWORD="None",' +760.75us
  semantic_release:cli 'main config:' {'check_build_status': 'false', 'commit_message': 'Automatically generated by python-semantic-release', 'commit_parser': 'semantic_release.history.angular_parser', 'patch_without_tag': 'false', 'upload_to_pypi': 'false', 'version_source': 'commit'} +768.0us
Creating new version..
  semantic_release:history 'get_current_version_by_config_file' +0.0us
  semantic_release:history '__init__.py' '__version__' +604.75us
  semantic_release:history <_sre.SRE_Match object; span=(0, 19), match="__version__='1.0.0'"> +5.4ms
Current version: 1.0.0
  semantic_release:history:logs 'evaluate_version_bump("1.0.0", "None")' +0.0us
  semantic_release:history:logs 'found 1.0.0 in "feat: default to path-in-name to be compatible with 0.x\n\nBREAKING CHANGE: Switch back to default behavior of including path in name. Breaks 1.0.0 but is\ncompatible with 0.x\n. breaking loop' +46.3ms
  semantic_release:history 'get_new_version("1.0.0", "None")' +52.9ms
No release will be made.

The result after the fix on your repo:
$ PYTHONPATH=../semantic-release/ python -m semantic_release.cli version  --noop
Creating new version..
Current version: 1.0.0
No operation mode. Should have bumped from 1.0.0 to 2.0.0.

Released in v4.1.2


Unable to install Hydra unless Cython is installed first

Hydra utilizes Cython.distutils within setup.py, which is not the recommended method per Cython documentation at http://docs.cython.org/src/reference/compilation.html#distributing-cython-modules
This causes problems when packaging Hydra with other setuptools installation scripts.

I fixed this in #15.