Winget Defaultstate folders under user profiles does not have admin or system permission. cannot be deleted with user profile deletion

Brief description of your issue
user profiles aren't being deleted properly from sysdm.cpl or when trying to manually delete the user profiles within the C:\Users directory   when the machine has Winget installed and enrolled via Intune to install software.
The following folder path remains following profile deletion due to permissions which prevents the top level user profile folder from being removed:
C:\Users%username%\appdata\local\microsoft\winget\state\defaultstate
the permissions on the winget defaultstate folder are meant to be set without the local administrators group or system access rights
ssue happens only when winget is installed and used to install apps via intune (when the machine is enrolled into intune and has some software to be installed via new store in intune )
then we have these folders which has admin and system permission on top of it

but if we go one level deeper in the folders we can see that only the current user has permission (no system or admin permission ) so that those folders remain when user tried to delete profile and causing new folder for profile when the user logs in again ending up filling the c:\users folders with a lot of repeated names and numbers because the winget folder cannot be deleted  by admin as he do not have permission on it

Parent folder has a system and administrator full control but it is not reflected to the inside folder.
Steps to reproduce

Enroll a Windows 10 21H2 device into Intune.

Assign an application from the New Store to a test user, this will force WinGet to install to allow the app you've assigned to be downloaded and installed once you've logged in with the test user.

Logon with the test user that has the app assigned to them and ensure the app has been downloaded and installed.

these folders and files  will be created
C:\Users%username%\AppData\Local\Microsoft\WinGet\Settings\defaultState\sources_metadata
C:\Users%username%AppData\Local\Microsoft\WinGet\State\defaultState\StoreEdgeFD\installed.db
if we check the permissions on Default state folders , we will find only the current user has permission , no system or administrator permissions
files are attached below

Logon with another account and attempt to delete the profile of the test account from system properties. The test account profile folder (C\Users\testuser) should remain with the WinGet folder within.

WinGet.zip
Expected behavior
these folders named Defaultstate under winget folder should have a system and administrator permission so it can be deleted if we need to delete the profiles and clean up the C:\users  folder
Actual behavior
the profile gets deleted from the system however the the user profile folder under c:\users still exist and cannot be deleted because   wingt defaultstate folders still resides on it and cannot be deleted because of admin and system permissions missing , to delete them we need to set the permission manually to take ownership then delete profile
Environment
windows 10 21H2
Version of App Installer is 1.19.10173.0
Installed version of Winget v1.4.10173

We have run into this same issue - using delprof.exe; we did find a sort of workaround using a script that changes the WinGet folder and allows us to delete it (this was working with US Cloud)

Also experiencing the same issue.
Windows 10 21H2 v10.0.19044.3086
Winget v1.4.11071
Package v1.19.11071.0

...and here the same one too.
Windows 10 Enterprise 21H2 (10.0.19041.3086)
Winget v1.4.11071

I have checked the version.

however i can see the same files and folders still has no admin or system permission , do  i need to uninstall then install

I'm using this to fix the ACLs on my machines
`$ACL_error_state = $true
function fix-WingetACL{
$Error.Clear()
$ErrorActionPreference = "SilentlyContinue"
$SYSTEM = ([wmi]"win32_SID.SID='S-1-5-18'").referenceddomainname + "\" +([wmi]"win32_SID.SID='S-1-5-18'").accountname
$ADMINISTRATORS = ([wmi]"win32_SID.SID='S-1-5-32-544'").referenceddomainname + "\" +([wmi]"win32_SID.SID='S-1-5-32-544'").accountname
$paths = get-childitem "C:\users\*\appdata\local\microsoft\winget" -Recurse | select -ExpandProperty fullname

ForEach ($path in $paths) {

    $Acl = Get-Acl $path

    $Ar_system = New-Object System.Security.AccessControl.FileSystemAccessRule($SYSTEM, "FullControl", "Allow")
    $Ar_administrators = New-Object System.Security.AccessControl.FileSystemAccessRule($ADMINISTRATORS, "FullControl", "Allow")

    $Acl.AddAccessRule($Ar_system)
    $Acl.AddAccessRule($Ar_administrators)

    #Write-Host $path

    Set-Acl -Path $path -AclObject $Acl

}

if($error) {return $true} else {return $false}

}
while ($ACL_error_state) {
$ACL_error_state = fix-WingetACL

}`

Can confirm I'm on 1.5.1572 and the ACLs were still incorrect.
Simple to remediate with a script.
https://gist.github.com/7ep3s/94c8f0e98769e0af5dca75ac53262158

Thanks for confirming this is still a bug.

This is still a bug for us as well

This is still a bug for us as well

This is fixed from winget side, the fix is scheduled to be released with winget v1.6. But Intune uses a copy of winget binaries, intune teams needs to update their copy and push out a new client release to truly fix the issue. The issue is closed automatically by github when linked pr is merged, I'll reopen the issue for tracking purpose.

@7ep3s
Should this script hook work if you haven't explicitly installed WINGET but are using it with an Intune deploy from the Windows Store (new)? App deployment.
We ran your script but it doesn't work for us in this situation.

intune remediation package scripts for those who are still looking for a way to address this in their env while the bug is fixed https://github.com/7ep3s/IntuneRemediationScripts/tree/main/WingetACLRemediation

Should this script hook work if you haven't explicitly installed WINGET but are using it with an Intune deploy from the Windows Store (new)? App deployment.
We ran your script but it doesn't work for us in this situation.

intune remediation package scripts for those who are still looking for a way to address this in their env while the bug is fixed https://github.com/7ep3s/IntuneRemediationScripts/tree/main/WingetACLRemediation

Should this script work if you haven't explicitly installed WINGET but are using it with an Intune deploy from the Windows Store (new)? App deployment.
We ran your script but it doesn't work for us in this situation.

Thank you for the feedback.
That is interesting.
We don't install Winget separately and we use the new package manager integration for our Intune windows app deployments. We have not had (or at least I haven't heard of) any issues with profile deletes due to permissions since I rolled this out.
Maybe it's time I look at the related device status report. :)

This is still a bug for us as well

This is fixed from winget side, the fix is scheduled to be released with winget v1.6. But Intune uses a copy of winget binaries, intune teams needs to update their copy and push out a new client release to truly fix the issue. The issue is closed automatically by github when linked pr is merged, I'll reopen the issue for tracking purpose.

Does the InTune team have an ETA for when they will have fixed their end? We have several thousand shared devices at our hospital with the GPO for Windows to clean up old local profiles. This GPO is trying to do its job, but then Windows can't clean up the device and we run into issues. It would be good if we could go back to the various support teams and give them an ETA on a permanenet fix.

This is still a bug for us as well

This is fixed from winget side, the fix is scheduled to be released with winget v1.6. But Intune uses a copy of winget binaries, intune teams needs to update their copy and push out a new client release to truly fix the issue. The issue is closed automatically by github when linked pr is merged, I'll reopen the issue for tracking purpose.

Does the InTune team have an ETA for when they will have fixed their end? We have several thousand shared devices at our hospital with the GPO for Windows to clean up old local profiles. This GPO is trying to do its job, but then Windows can't clean up the device and we run into issues. It would be good if we could go back to the various support teams and give them an ETA on a permanenet fix.

Have you rolled out the remediation scripts from 7ep3s?

This is still a bug for us as well

This is fixed from winget side, the fix is scheduled to be released with winget v1.6. But Intune uses a copy of winget binaries, intune teams needs to update their copy and push out a new client release to truly fix the issue. The issue is closed automatically by github when linked pr is merged, I'll reopen the issue for tracking purpose.

Does the InTune team have an ETA for when they will have fixed their end? We have several thousand shared devices at our hospital with the GPO for Windows to clean up old local profiles. This GPO is trying to do its job, but then Windows can't clean up the device and we run into issues. It would be good if we could go back to the various support teams and give them an ETA on a permanenet fix.

Have you rolled out the remediation scripts from 7ep3s?

did you figure out why they were not working for you?

This is still a bug for us as well

This is fixed from winget side, the fix is scheduled to be released with winget v1.6. But Intune uses a copy of winget binaries, intune teams needs to update their copy and push out a new client release to truly fix the issue. The issue is closed automatically by github when linked pr is merged, I'll reopen the issue for tracking purpose.

Does the InTune team have an ETA for when they will have fixed their end? We have several thousand shared devices at our hospital with the GPO for Windows to clean up old local profiles. This GPO is trying to do its job, but then Windows can't clean up the device and we run into issues. It would be good if we could go back to the various support teams and give them an ETA on a permanenet fix.

Have you rolled out the remediation scripts from 7ep3s?

did you figure out why they were not working for you?

Yes, this was user error, manually running the script did not go well. Everything works fine via your detect and remediation script.
What we are still encountering is that TEMP profiles have sometimes been created. I also detect and remove this with a detect and remediation script (I can share this tomorrow)
The only problem I still have because of these issues is that the Intune prolicy that throws away the user profiles does this after 30 days from the "Win32_UserProfile" but the user profile folder remains.
I can delete this by running a detect and remediation script which deletes the C:\user folder older than 30 days, but here there is a good chance that I will also delete folders where the Win32_UserProfile still exists if the remediation script is earlier than the shared profile delete. from Intune. Unfortunately I don't have a good solution for this yet.
any good idea for this?

The only problem I still have because of these issues is that the Intune prolicy that throws away the user profiles does this after 30 days from the "Win32_UserProfile" but the old user profile folder remains. (before the ACL rights are set correctly So)

in my experience this can happen if there are locks on some files that are within the profile folder.
we have the same problem, probably because of the plethora of security agents running on our workstations.
setting up some housekeeping scheduled task that runs on boot or user logon might help with this issue.
I have a quite effective solution that can nuke stale profiles but not sure about temp profile folders.
I can publish it tomorrow after sanitizing it.

that would be great!

The only problem I still have because of these issues is that the Intune prolicy that throws away the user profiles does this after 30 days from the "Win32_UserProfile" but the old user profile folder remains. (before the ACL rights are set correctly So)

in my experience this can happen if there are locks on some files that are within the profile folder. we have the same problem, probably because of the plethora of security agents running on our workstations. setting up some housekeeping scheduled task that runs on boot or user logon might help with this issue.
I have a quite effective solution that can nuke stale profiles but not sure about temp profile folders. I can publish it tomorrow after sanitizing it.

That would be great!

The only problem I still have because of these issues is that the Intune prolicy that throws away the user profiles does this after 30 days from the "Win32_UserProfile" but the old user profile folder remains. (before the ACL rights are set correctly So)

in my experience this can happen if there are locks on some files that are within the profile folder. we have the same problem, probably because of the plethora of security agents running on our workstations. setting up some housekeeping scheduled task that runs on boot or user logon might help with this issue.
I have a quite effective solution that can nuke stale profiles but not sure about temp profile folders. I can publish it tomorrow after sanitizing it.

That would be great!

https://github.com/7ep3s/SCCM_Intune_PowerShell/tree/main/StaleUserProfileRemover

This is fixed from winget side, the fix is scheduled to be released with winget v1.6. But Intune uses a copy of winget binaries, intune teams needs to update their copy and push out a new client release to truly fix the issue

Hello @IntuneAdmin , do we have an update for the issue

This is fixed from winget side, the fix is scheduled to be released with winget v1.6. But Intune uses a copy of winget binaries, intune teams needs to update their copy and push out a new client release to truly fix the issue

Hello @IntuneAdmin , do we have an update for the issue

Where do you get the information that it has been fixed?
I don't have an update, I'm a "user" IntuneAdmin is just my nickname. I have no influence on the process at Microsoft / WinGet 😬

hello @IntuneAdmin  , this info was mentioned by @yao-msft on his update , so i thought you are the official Intune as you were replying to the thread , so Dear @yao-msft do we have any update from Intune team

We will release a new winget library after our winget 1.6 stable release is out (probably in 1-2 weeks). After that I'll ask intune to take in the new library (not sure how long that'll take to end customer delivery). But I'll report back when I have rough dates. Thanks.

We will release a new winget library after our winget 1.6 stable release is out (probably in 1-2 weeks). After that I'll ask intune to take in the new library (not sure how long that'll take to end customer delivery). But I'll report back when I have rough dates. Thanks.

Any update?

Intune team has taken the winget 1.6 library update. It should be in next Intune client update.

Intune team has taken the winget 1.6 library update. It should be in next Intune client update.

Nice! Do you know when the next Intune client update is?

Hello @yao-msft , thanks for the update , do you have any update from Intune team

@RDMacLachlan do you by chance have any idea when this might roll out?

Hello @denelon @RDMacLachlan  , is there any update regarding the Intune Team rollout

Hello @denelon @RDMacLachlan , is there any update regarding the Intune Team rollout!

The Intune Support Team told me that Winget 1.6 is released in the Intune 2311 update “last week”

I'm still experiencing this issue on my endpoint joined devices. I'm running winget v1.6.3133.
On shared devices, I can't deleted all the user accounts to create space on the hard drive because of this. Me and my coworker have to go to the advanced security settings and change the owner of the folder to "DEVICE\Administrators" and check both boxes  (So, the subfolders & files are included) before we can actually remove the folders.
Is there something I'm missing?

I'm still experiencing this issue on my endpoint joined devices. I'm running winget v1.6.3133. On shared devices, I can't deleted all the user accounts to create space on the hard drive because of this. Me and my coworker have to go to the advanced security settings and change the owner of the folder to "DEVICE\Administrators" and check both boxes (So, the subfolders & files are included) before we can actually remove the folders.
Is there something I'm missing?
@yao-msft

try my remediation package https://github.com/microsoft/winget-cli/issues/3365#issuecomment-1708304778

I'm still experiencing this issue on my endpoint joined devices. I'm running winget v1.6.3133. On shared devices, I can't deleted all the user accounts to create space on the hard drive because of this. Me and my coworker have to go to the advanced security settings and change the owner of the folder to "DEVICE\Administrators" and check both boxes (So, the subfolders & files are included) before we can actually remove the folders.
Is there something I'm missing?
@yao-msft

try my remediation package #3365 (comment)

And how does that work? Do I need to run that on the computers with problems? Which one of the two scripts?
So, updating to the latest version of WinGet won't work?

I'm still experiencing this issue on my endpoint joined devices. I'm running winget v1.6.3133. On shared devices, I can't deleted all the user accounts to create space on the hard drive because of this. Me and my coworker have to go to the advanced security settings and change the owner of the folder to "DEVICE\Administrators" and check both boxes (So, the subfolders & files are included) before we can actually remove the folders.
Is there something I'm missing?
@yao-msft

try my remediation package #3365 (comment)

And how does that work? Do I need to run that on the computers with problems? Which one of the two scripts? So, updating to the latest version of WinGet won't work?

https://learn.microsoft.com/en-us/mem/intune/fundamentals/remediations
or use it as sccm configuration baseline, in that case might need to change the exit code output in the detection script to return $true or $false

I'm still experiencing this issue on my endpoint joined devices. I'm running winget v1.6.3133. On shared devices, I can't deleted all the user accounts to create space on the hard drive because of this. Me and my coworker have to go to the advanced security settings and change the owner of the folder to "DEVICE\Administrators" and check both boxes (So, the subfolders & files are included) before we can actually remove the folders.
Is there something I'm missing?
@yao-msft

try my remediation package #3365 (comment)

And how does that work? Do I need to run that on the computers with problems? Which one of the two scripts? So, updating to the latest version of WinGet won't work?

https://learn.microsoft.com/en-us/mem/intune/fundamentals/remediations
or use it as sccm configuration baseline, in that case might need to change the exit code output in the detection script to return $true or $false
EDIT: idk if winget updating to latest version fixes the ACLs, or having the latest version from ground zero just means you won't have ACL issues with the state folder on the new builds but I do know that since I implemented that script package in our env when the bug was originally discovered, we have no problem purging user profiles.

We are also still have this problem after updating winget to v1.6. I would say that this is not truly fixed if we have to continue to run the remediation scripts.

This is not fixed by just updating to latest winget v1.6. Intune takes a copy of winget code and distribute with Intune client update. It's only fixed after Intune releases a new client update, which is in about 1 month last I heard.

Hello @denelon @RDMacLachlan , is there any update regarding the Intune Team rollout!

The Intune Support Team told me that Winget 1.6 is released in the Intune 2311 update “last week”

And according to this I thought the update was in the Winget 1.6 release last week.

Is this not the 2311 update?

This is not fixed by just updating to latest winget v1.6 package. Intune takes a copy of winget code and distribute with Intune client update. It's only fixed after Intune releases a new client update. @IntuneAdmin mentioned the Intune support team says it's released with Intune 2311 last week. Please let us know if the issue still exists after updating to Intune 2311 client.

How does one check/update that version?

The winget dlls (for intune consumption) are under "C:\Program Files (x86)\Microsoft Intune Management Extension". Checking the version of Microsoft.Management.Deployment.InProc.dll should be sufficient.

The winget dlls (for intune consumption) are under "C:\Program Files (x86)\Microsoft Intune Management Extension". Checking the version of Microsoft.Management.Deployment.InProc.dll should be sufficient.

And how does one update or does that go automatically?

Sorry I'm not an expert on Intune client distribution but it should be updated automatically.

Excellent. So if it is still an issue under the latest version, so I ask to reopen this issue or create my own?

By the way, the winget code (for Intune) should have been invoked at least once (like installing some app through Intune, etc) to take effect. If it does not work, please reopen the issue. Thanks.

The winget dlls (for intune consumption) are under "C:\Program Files (x86)\Microsoft Intune Management Extension". Checking the version of Microsoft.Management.Deployment.InProc.dll should be sufficient.

Looks like this has not updated yet then.

This is not fixed by just updating to latest winget v1.6 package. Intune takes a copy of winget code and distribute with Intune client update. It's only fixed after Intune releases a new client update. @IntuneAdmin mentioned the Intune support team says it's released with Intune 2311 last week. Please let us know if the issue still exists after updating to Intune 2311 client.

How does one check/update that version?

I think once your MS Tenant has Intune release 2311, your clients will update automatically, not aware of any way to force that. You can check your service release in Intune/Tenant Administration.

Sorry I'm not an expert on Intune client distribution but it should be updated automatically.

Currently running 2304. My tennant is running 2311, is there a way to force an update so I can test if the fix works? Since, it's getting really annoying & time consuming.

Sorry I'm not an expert on Intune client distribution but it should be updated automatically.

Currently running 2304. My tennant is running 2311, is there a way to force an update so I can test if the fix works? Since, it's getting really annoying & time consuming.

realistically I think the only thing you can do is ask your MS rep when your tenant will get 2311

Sorry I'm not an expert on Intune client distribution but it should be updated automatically.

Currently running 2304. My tennant is running 2311, is there a way to force an update so I can test if the fix works? Since, it's getting really annoying & time consuming.

try this https://www.reddit.com/r/Intune/comments/108zlx3/intune_management_extension_not_updating/

Sorry I'm not an expert on Intune client distribution but it should be updated automatically.

Currently running 2304. My tennant is running 2311, is there a way to force an update so I can test if the fix works? Since, it's getting really annoying & time consuming.

try this https://www.reddit.com/r/Intune/comments/108zlx3/intune_management_extension_not_updating/

Ok tried that, here is the link I used: https://naprodimedatapri.azureedge.net/IntuneWindowsAgent.msi
Now the version of Microsoft.Management.Deployment.InProc.dll is updated to this:

So that worked to force the update, now I will see if the fix works.

Sorry I'm not an expert on Intune client distribution but it should be updated automatically.

Currently running 2304. My tennant is running 2311, is there a way to force an update so I can test if the fix works? Since, it's getting really annoying & time consuming.

try this https://www.reddit.com/r/Intune/comments/108zlx3/intune_management_extension_not_updating/

Ok tried that, here is the link I used: https://naprodimedatapri.azureedge.net/IntuneWindowsAgent.msi
Now the version of Microsoft.Management.Deployment.InProc.dll is updated to this:
So that worked to force the update, now I will see if the fix works.

Same here. But we need 2311 and that's 2310... Yeah. I think that's the issue.

I stil have the bug tho.

I stil have the bug tho.

https://github.com/microsoft/winget-cli/issues/3365#issuecomment-1830754352
try to install something from the portal or push something to the device that uses winget (so a Microsoft Store App(new) application), that should invoke the intune extensions winget binaries, then see if it's still bugged

I stil have the bug tho.

Did you delete and re-create the user profile with the bug? I ran the remediate scripts then deleted the domain user profile with the bug, then re-logged in with that username to re-create the domain user profile. Once the Winget folder was created in C:\Users%username%\appdata\local\microsoft, I logged in with a local admin user and was able to successfully delete the domain user profile from sysdm.cpl and verified the user profile folder was completely removed from C:\Users.

I stil have the bug tho.

Did you delete and re-create the user profile with the bug? I ran the remediate scripts then deleted the domain user profile with the bug, then re-logged in with that username to re-create the domain user profile. Once the Winget folder was created in C:\Users%username%\appdata\local\microsoft, I logged in with a local admin user and was able to successfully delete the domain user profile from sysdm.cpl and verified the user profile folder was completely removed from C:\Users.

the point is that if the winget fix from intune 2311 is effective, they should not have to run the scripts

I stil have the bug tho.

Did you delete and re-create the user profile with the bug? I ran the remediate scripts then deleted the domain user profile with the bug, then re-logged in with that username to re-create the domain user profile. Once the Winget folder was created in C:\Users%username%\appdata\local\microsoft, I logged in with a local admin user and was able to successfully delete the domain user profile from sysdm.cpl and verified the user profile folder was completely removed from C:\Users.

the point is that if the winget fix from intune 2311 is effective, they should not have to run the scripts

Exactly. Currently, I rather have a solution like that instead of trying to debug it with a script. I personally never used remidation in Intune and I want to avoid making mistakes especially when user data is involved in the prep week for the exam period next week.
After that I might have some more time to learn about this.
Anyhow, not throwing any stones at anyones work. Thanks for the help but my current situation is more of fixing it yesterday instead of trying to learn something... :/

It seems like newly created profiles after this upgrade do not have the bug, is it possible that it does not fix pre-existing profiles?

After winget related operation is invoked as pre-existing profile user, the code should reset the folder permission to give full control to admin and system (on that user's path). It needs to be invoked for each pre-existing user.

I pushed a new app, I downloaded something via the company portal ... no luck. Even on freshly installed laptops that we connect with Intune, still 2304. Whilst our tennant uses 2311.
Is the only thing we have now is to wait or what else can I troubleshoot?

@yao-msft can we have someone from Intune team to help in the Intune fix  status - and if that will help in the pre-existing users

@nikyusof Would you be able to help answer customer questions?

@yao-msft it seems the issue is corrected if you try to access the files from local admins only  , but if you try to access it from an Intune user account (which is a member of device administrates )  which should have the same group permissson the issue still persists even if the ACL is correct, but they still cannot access the winget defaultstate folder  ,

Winget currently uses following sid for admins
auto adminSID = wil::make_static_sid(SECURITY_NT_AUTHORITY, SECURITY_BUILTIN_DOMAIN_RID, DOMAIN_ALIAS_RID_ADMINS);
My change gives back the above security groups (admins) full access. Is Intune user account part of that group? My change was to fix a regression after we applied explicit ACLs. If the Intune user account is not part of that group, I feel it's not the regression I fixed.
Can you check which security group Intune user is in (on a local machine)? If it's standard user, then we cannot add it back due to internal security review. If it's some other group we missed, we should evaluate and add to winget's explicit ACL logic.

Hello @yao-msft
I can confirm that the permission is shown correct in the folders and the local admin (not Intune can access the defaultstate folder of other users and can delete them when he deletes the user from the system

the wired thing that we cannot do that from the Intune account logged in to the machine and they are also a member of  the local admins of the machines )
I was able to reproduce with 2 users (Intune accounts) for example first user is (Selim) and second user is (Selim2)
if you login with  user (Selim2)  and try to access the defaultstate folder of the other Intune  user ( Selim)   you will hit the issue with access denied

if we check the user (Selim2) we can see it is a part of local administrators

and the permission is correct on the folder

and i can confirm also the Intune user is a part of the local administrators

so in brief , the issue still appear within Inutne Users accounts only , they cannot access eachothers defaultstate folder althogh the permission is corrected after your fix

the issue does not appear if you login with Local Administrator (not Intune) after the fix it is corrected and local admin have a full access and can delete users and folder successfully
so we need to know why Intune admins still have the issue while they have the same permissions !!
the main target is the ability to clean up old users data profiles using Intune admin task in a busy envirnments which is hard to do it manually
let me know if we can connect internally to show you the re-pro lab

Thanks for the detailed info, @selimfelex . I feel this permission issue is outside of winget code's scope. Looks like winget sets the folder permission correctly, but certain admin account has permission issues. @nikyusof, do you have any insight on how Intune account is configured? I'll also raise this issue to Intune team in our sync meeting next week.

Hello @yao-msft  , i could confirm the issue is resolved , the last operations on my last comment  was related  to UAC and it is working when you click on Continue and it is not related to the permission issue we had
thanks for your co-opration


add node_modules to ignore

when yarn installing packages, project tracked node modules in git, now we ignore them
https://stackoverflow.com/questions/29820791/git-ignore-node-modules-folder-everywhere

Current dependencies on/for this PR:

master

PR #1215   👈

This comment was auto-generated by Graphite.


The completion list icon is inconsistent between "Ctrl+Space" and press "tab" to move the tab stops

OS: Win10
Build Version: 20200621.8
Repro Steps:

Open a template file in VS Code.
F1 --> Type and select "Insert Item..." --> Select "Resource" --> Select "Application Gateway".
Press "tab" to move between the tab stops.

Expect:
The completion list icon is consistent between "Ctrl+Space" and press "tab" to move the tab stops.
Actual:
The completion list icon is inconsistent between "Ctrl+Space" and press "tab" to move the tab stops.

Good catch.  Unfortunately there's nothing I can do about this without (probably non-trivial) changes in the webtools code.


Add tests for the function class_static_subgrouping_array_recorders in the module HDF5_recorder

The function class_static_subgrouping_array_recorders has no tests currently. It would be good to write a few simple tests.

Closing issue as test coverage monitoring is handled automatically due to solving #169. So, having issues related to test coverage like this are redundant.


BREAKING CHANGE Move all auth including login into client

TODO work out what to to with actions / serverActions / adapter


Fix for Integration Editor Action ListItem row

fixes #417

PR Storybook available here

The fact that there's no real description for these items and they only repeat the title makes it a little more of an eye sore

You are generalizing over a specific example.

I think the description item has come up a few times. It would be great to have the expanded menu offer a more rich feel. Maybe we can look into this when we do a 7.4 review

I think a typical list row contains list item name, list item description, and we might bold the list item name in some cases, but never really bolding the description. The order we have in the screenshot gives me an odd feeling.
I'm not sure if right now we want to align all the bold styling across all lists in the app...and I do have an issue open https://github.com/syndesisio/syndesis/issues/5525 to investigate list behavior.
@gaughan - can you share more as to what do you mean by expanded menu and rich feel?

It would be great to have the expanded menu offer a more rich feel.

Apologies, disregard, I was cross-posting.
I do agree, the duplication of text "cron timer" cron timer" should be avoided tho.
Also, can we just call it timer?

Sorry wasn't trying to overgeneralize the problem @paoloantinori - just didn't want to push back on the bolding without offering some alternate paths forward and I saw the stub description text as further complicating the decision. If the description is the same as the title text and we don't bold one of them then it looks like a bug again, even with them not being stacked. It's all a consistency game from my point of view and as @dongniwang mentioned, if we were to bold anything, the title would make most sense and not the description.
I dunno about using only "Timer" as a title, as there a multiple types of timers. I'd think to keep the titles as is and just change the descriptions to something that points out that these actions are types of timers. Maybe time based vs interval based would be a good thing to point out in the descriptions?

But that's ok I would think because this is what the description is here to help with - and do we expect users to know what every action is just by the name? A user may not know what cron is, but if we describe it as a "type of timer that schedules jobs to run periodically at fixed times", then they may understand? I just don't want to undercut the importance of using and relying on sound descriptions.

I agree on solid descriptions. But it's a backup, user don't read it until something goes wrong.

Here's what I think we can do right now:

Keep the current layout. I'm fine with the stacked if that introduces less hassle. If we want to change it back to the horizontal view, that'd be great as well.
If we go with the horizontal view, let's bold the name and unbold the description. That would help differentiate these two kinds of content.
I don't think introducing name changes right now is a good idea. And it deserves a separate discussion. If we want to change anything or to avoid getting into a situation where we have duplicating text, we should be focusing on having a more descriptive description. Yes, users may not read until something goes wrong, but this should not be the reason for not provide them with sufficient information IMO.

For comparison sake, here is what it looks like when not bolded. Less of an eye sore, but slightly more confusing:

We probably just need to get the descriptions changed, as you guys suggested. For the purposes of this PR, however, should we bold or no bold?

Yeah, so I'd get rid of the bold and also to prevent the duplicates I'd definitely compare the name/description and just show the name and hide the description (replace it with an nbsp;) if it's exactly the same as the description.  At least we'll kinda look like we know what we're doing.

Better pass undefined to the description and set stacked to false to ensure vertical alignment of the name when it’s alone in the row

Based on the feedback:

Per @dongniwang , no name changes, only bold the name and not the description.
Per @gashcrumb , compare name to description to determine whether or not to show the description.
Per @riccardo-forina , returned undefined for description if the name and description match.

See screenshot below:

PR Storybook available here

Thanks @kahboom for making the update! Looks good to me.
I do want to reiterate that I think having a more descriptive description is the way to go.

I do want to reiterate that I think having a more descriptive description is the way to go

@dongniwang can you log a bug for that in the main syndesis repo?  That's a matter of updating the connector definition, those names/descriptions don't come from the UI at all.

Make it specifically for the timer connection BTW.

https://github.com/syndesisio/syndesis/issues/5625 here we go!

Although if we really want to be thorough, all the text coming from the BE should be matched against some i18n dictionary so to translate also those bits.
Not that we have any real support for anything but EN, but it would allow us to make UX improvements without touching the BE at all...

Although if we really want to be thorough, all the text coming from the BE should be matched against some i18n dictionary so to translate also those bits.

I absolutely agree but then we've just increased the scope of solving the problem.  For 7.4 let's keep it to updating the connector definition files, and absolutely we should plan on generally avoiding using text from the BE for anything and instead have it use i18n keys.

Of course! That was definitely to be filed as an improvement thing :D


Allow admin to authenticate with client certificate

"userCertificate" attribute was searched only under searchBaseDn and therefore it was not possible to use SASL EXTERNAL method with client certificate based authentication for admin user.
This change adds explicit search for "userCertificate" for "uid=admin,ou=system".

This topic was briefly discussed in directory-dev email list thread here. I'm not sure if you'd be interested in this change but sending it in case this would be useful for others.


ChartCanvasLinePlot should support "holes" in the data

LinePlot supports missing data like so:
      // NaN or Infinite components "pen up" and stop drawing
      if ( this.dataSet[ i ].isFinite() ) {

It seems ChartCanvasLinePlot should support it too, so it is easy to switch between plot types.
Discovered in #16

This feature also needs to be documented in LinePlot.  I didn't know this feature existed, and would only have discovered it by reading the implementation of updateLinePlot.

I updated CanvasLinePlot so it skips non-finite data the same way LinePlot does, and I added a note of documentation to each.  @pixelzoom can you please review?

This still didn't seem clear to me, so I took a stab at more clarification and examples in the above commit.
In doing this, I also discovered another issue.  A dataSet is consistently described as a {Vector2[]}:
 * LinePlot renders a dataset of {Vector2[]} by connecting the points with line segments.
...
@param {Vector2[]} dataSet

But these non-finite values that can be inserted into a data set are NOT Vector2.   So should the type expression throughout be changed to {Array.<Vector2|number>}, with the constraint the a {number} must be non-finite?   This also makes me think that using non-finite numbers is the wrong approach. Why not use null?  It would be much easier to describe, the type expression would be {Array.<Vector2|null>}, and an example would look like:
[ (0,0), (0,1), null, (0,2), (0,3) ]

The current implementation only supports Vector2[] and uses Vector2.isFinite() to determine if a value will be rendered or not.  This is a natural fit for time series data, where one dimension is known and one may be undefined, such as new Vector2(7.5, NaN).  This strategy is used in both Wave Interference and Circuit Construction Kit.  For bamboo it doesn't seem important to know that a measurement was NaN at a certain time, maybe other situations would leverage that (or maybe not).
On the other hand, an array of finite Vector2 | null also seems reasonable.  Would we want to collapse multiple null values?  For the purposes of this chart, [ (0,0), (0,1), null, (0,2), (0,3) ] would render the same as [ (0,0), (0,1), null, null, (0,2), (0,3) ].

Ah, I see -- this.dataSet[ i ].isFinite() still involves a Vector2.  Thanks for clarifying.  I've fixed the doc in the above commit.
It seems odd (and as I've unintentionally demonstrated, confusing) to have to create a non-finite Vector2 instance -- and either know or investigate how Vector2 isFinite is implemented.  Using null seem clearer, easier to explain, and creates fewer objects.  If we switched to using null to represent a gap, I see no reason to collapse consecutive null values.
Also... The doc for Vector2 isFinite is a tad confusing:
* Whether all of the components are numbers (not NaN) that are not infinity or -infinity.

Better would be:
 * Returns false if either component is NaN, infinity, or -infinity. Otherwise returns true.

I revised the documentation as recommended, and converted to use null instead of non-finite Vector2 for the data.  I found that CCK was using these renderers from bamboo, but Wave Interference is not, so Wave Interference didn't need to be updated.  I was concerned there would be a problem in CCK because it used the "time" value of a non-finite Vector2 to know when to remove a data point from the data set, but I tested removing null points and didn't see any problems, and it seems like it will be OK.
Ready for review.

Looks good, thanks for handling.  Closing.


[CI][Java] AMD64 manylinux2014 Java JNI job routinely times out

Describe the bug, including details regarding any error messages, version, and platform.
It seems to timeout in the vcpkg phase.
You can see it by enabling the timestamps in the Github Actions logs, for example in this build:
https://github.com/apache/arrow/actions/runs/5808491339/job/15745369883#step:6:2413
Wed, 09 Aug 2023 11:39:24 GMT #7 104.9 Building llvm[clang,compiler-rt,core,default-options,default-targets,disable-assertions,disable-clang-static-analyzer,enable-bindings,enable-rtti,enable-terminfo,enable-threads,enable-zlib,enable-zstd,lld,target-spirv,target-x86,tools]:amd64-linux-static-release...
Wed, 09 Aug 2023 11:39:24 GMT #7 104.9 -- [OVERLAY] Loading triplet configuration from: /arrow/ci/vcpkg/amd64-linux-static-release.cmake
Wed, 09 Aug 2023 11:39:24 GMT #7 105.0 -- Downloading https://github.com/llvm/llvm-project/archive/llvmorg-15.0.7.tar.gz -> llvm-llvm-project-llvmorg-15.0.7.tar.gz...
Wed, 09 Aug 2023 11:39:59 GMT #7 139.9 -- Extracting source /opt/vcpkg/downloads/llvm-llvm-project-llvmorg-15.0.7.tar.gz
Wed, 09 Aug 2023 11:40:10 GMT #7 151.3 -- Applying patch 0001-Fix-install-paths.patch
Wed, 09 Aug 2023 11:40:10 GMT #7 151.4 -- Applying patch 0002-Fix-DR-1734.patch
Wed, 09 Aug 2023 11:40:10 GMT #7 151.4 -- Applying patch 0003-Fix-tools-path.patch
Wed, 09 Aug 2023 11:40:10 GMT #7 151.4 -- Applying patch 0004-Fix-compiler-rt-install-path.patch
Wed, 09 Aug 2023 11:40:10 GMT #7 151.4 -- Applying patch 0005-Fix-tools-install-path.patch
Wed, 09 Aug 2023 11:40:10 GMT #7 151.4 -- Applying patch 0006-Fix-libffi.patch
Wed, 09 Aug 2023 11:40:10 GMT #7 151.4 -- Applying patch 0007-Fix-install-bolt.patch
Wed, 09 Aug 2023 11:40:10 GMT #7 151.5 -- Applying patch 0008-llvm_assert.patch
Wed, 09 Aug 2023 11:40:10 GMT #7 151.5 -- Applying patch 0009-disable-libomp-aliases.patch
Wed, 09 Aug 2023 11:40:10 GMT #7 151.5 -- Using source at /opt/vcpkg/buildtrees/llvm/src/org-15.0.7-26832cabce.clean
Wed, 09 Aug 2023 11:40:10 GMT #7 151.5 -- Getting CMake variables for amd64-linux-static-release
Wed, 09 Aug 2023 11:40:11 GMT #7 152.2 -- Configuring amd64-linux-static-release
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4 CMake Warning at installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:314 (message):
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4   The following variables are not used in CMakeLists.txt:
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4       BOLT_TOOLS_INSTALL_DIR
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4       LIBOMP_INSTALL_ALIASES
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4   Please recheck them and remove the unnecessary options from the
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4   `vcpkg_cmake_configure` call.
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4   If these options should still be passed for whatever reason, please use the
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4   `MAYBE_UNUSED_VARIABLES` argument.
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4 Call Stack (most recent call first):
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4   ports/llvm/portfile.cmake:238 (vcpkg_cmake_configure)
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4   scripts/ports.cmake:147 (include)
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4
Wed, 09 Aug 2023 11:40:31 GMT #7 172.4 -- Building amd64-linux-static-release-rel
Wed, 09 Aug 2023 13:04:01 GMT Error: The operation was canceled.

(why on Earth are we building LLVM from source?)
Component(s)
Continuous Integration, Java

@kou @assignUser We should seriously avoid building LLVM from source.

In general, we need to build all vcpkg packages by vcpkg's design.
We build packages in https://github.com/ursacomputing/crossbow and cache the built packages.
Our CI in https://github.com/apache/arrow/ should use the build packages.
But the java-jars job in ursacomputing/crossbow is failed recently: https://github.com/ursacomputing/crossbow/actions/runs/5818829907/job/15780830416
https://github.com/apache/arrow/pull/37119 will fix the build failure and resolve this problem too.

Cache is used again: https://github.com/apache/arrow/actions/runs/5835703262/job/15827803940#step:6:1431
 #7 [2/5] RUN vcpkg install         --clean-after-build         --x-install-root=/opt/vcpkg/installed         --x-manifest-root=/arrow/ci/vcpkg         --x-feature=dev         --x-feature=flight         --x-feature=gcs         --x-feature=json         --x-feature=parquet         --x-feature=gandiva         --x-feature=s3
#7 CACHED


scripts with consistent naming

some of the scripts use "-" and others "_" in their file names. There is also "construct"/"create". Would it be fine to rename them with a consistent naming?

This seems like a worthwhile cleanup step. To match the other files in the repo, I think "_" is preferable. We'll need to update references to these files as well (likely places are docs, config process, and other scripts).


prepare test for issue #78

see #78

it works!

But you mentioned there is one list item missing? https://github.com/nadar/quill-delta-parser/issues/78#issuecomment-1481161657

It bet it's the js editor that adds the second one. And if not, it is still better than what we had as doesn't duplicate text when empty and does show the text on both when filled :)


Don't limit requests per destination

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

What was default ?

I've only been able to hit the limit when feeding through a secure HTTP/2 proxy though.


Finish request verifications

Closes #139
Closes #278
Closes #287
There are a couple related by different changes here:

Adds an additional author signature to log records.

CreateRecord uses the local host as author.
AddRecord takes a fully composed record, so it's up to the caller to use the correct author (to be later checked against an ACL).

Completes verifications in the p2p networking API (get/push logs, get/push records). Previously, only PushRecord performed any kind of verification. Now, each request carries an inner body message which is signed by the sender.
Adds thread credentials (see #287 for a detailed overview)

Yeah totally, the API ease-of-use has held me up here a couple times. The the main reason to let people choose there thread ID is so that they can decide what type to use and how many bytes of randomness. Sort of like choose bit size for a symmetric key. The credentials contain a signature that is based on the thread ID, so they go hand-in-hand. Naming this stuff is hard... any suggestions welcome.

Thanks for the reviews, guys. I wanted everyone to look at this so we can all start thinking about it. I'm gonna merge now, but may follow up over the weekend with some ideas on how to solve the issue around the manager needing to save creds in order to restart the DBs.


Star should warn if input periodogram is not flattened or update docs.

Context
When I tried passing the following periodogram to the star class,
pg = lc.to_periodogram(normalization='psd')

I got this output from star.run_asy_peakbag():

For comparison, when I passed the following periodogram, (flatten() is Lightkurves method to remove noise and smooth the periodogram)
pg = lc.to_periodogram(normalization='psd').flatten()

I get this:

Issue
PBjam docs suggests a periodogram with power in any units may be passed, but not that it needs to be flattened. Clearly the periodogram needs to be flattened for this to work, as that would explain the dodgy units in the plot.
Suggestion

(easy) Update the docs to specify the input periodogram must be flattened.
(additional) PBjam raises an error or warning if it detects that the input periodogram is not flattened.
(alternative) star flattens the periodogram if it is not already

I think we should definitely recommend in the docs that the LC be flattened
first.
If I recall correctly the periodogram is flattened in session when reading
in from text file, but may not be when providing a pg object.
I don't recall putting any flattening in star. It could be a good idea to
do so. Although we should check what the effect of flattening multiple
times.
Not sure how easy it would be to put in a flatten_detector. While you can
easily compute mean/std of the psd, making it robust might be tough.
On Thu, 21 Nov 2019, 15:20 Alex Lyttle<EMAIL_ADDRESS>wrote:

Context
When I tried passing the following periodogram to the star class,
pg = lc.to_periodogram(normalization='psd')
I got this output from star.run_asy_peakbag():
[image: image]
https://user-images.githubusercontent.com/43786145/69348676-75c4f780-0c6e-11ea-830f-46967d6d4275.png
For comparison, when I passed the following periodogram, (flatten() is
Lightkurves method to remove noise and smooth the periodogram)
pg = lc.to_periodogram(normalization='psd').flatten()
I get this:
[image: image]
https://user-images.githubusercontent.com/43786145/69349790-4d3dfd00-0c70-11ea-9558-30256b369a5e.png
Issue
PBjam docs suggests a periodogram with power in any units may be passed,
but not that it needs to be flattened. Clearly the periodogram needs to be
flattened for this to work, as that would explain the dodgy units in the
plot.
Suggestion

(easy) Update the docs to specify the input periodogram must be
flattened.
(additional) PBjam raises an error or warning if it detects that
the input periodogram is not flattened.
(alternative) star flattens the periodogram if it is not already

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/grd349/PBjam/issues/197?email_source=notifications&email_token=AEJWO33XGDVT6VI3PPDC3LTQU2RKDA5CNFSM4JQD4ZUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3EG4ZQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEJWO32TSPU5ZZQGELZ4QNDQU2RKDANCNFSM4JQD4ZUA
.

I've put in a flatten method call in the init of star. Not the best procedure I guess, but it does the trick.
I tested flattening on the same spectrum 10x and it made no measureable difference after the first flattening (does this make sense?). It was a high SNR target, don't know if low SNR targets behave the same.
Tested on 4448777 and it works, feel free to close issue.


import error, how to resolve?

Are you having another C# script which is named UnityChanController.cs in another folder?
Delete the one which you think is redundant.
If you cannot decide which one, create a new project and import the corresponding unitypackage (UnityChan one) into the new project.
Hopefully this can solve your problem.

@mmmmmm44 I found there are 2 sets of cs scripts, one is from your GitHub, another one is imported from unity.package, they are almost same, but not fully same, what's the differences?

U can use diff   command in linux/mac or fc   on windows to compare them.
They are the same files (i.e. no difference)


Security warning for website on Mozilla Firefox

Mozilla Firefox displays a security warning when visiting the Shogun website: https://shogun.ml/
Screenshot:

This warning is not displayed when visiting the site without https:
http://shogun.ml
The https link is mentioned here.

Thanks for reporting. I can reproduce that. It looks like the certificate has expired long ago.
@vigsterkr didn't you add let's encrypt for that? I have some vague memory of that..

I think this has been fixed


Commands are output to the console

With the latest Docker Desktop (2.1) all commands are output to the console.

@znat Sorry for the late reply. Does the issue still exist? Not sure where exactly the problem occurs. Can you describe the issue in more detail?


Rivera Dancer ICD bugs are not correctly simulated

On live servers, Rivera Dancer's increased attack speed does increase the attack speed of item procs like Gyana Na Kashu and Obsidian Ring of the Zodiac.
So for example, suppose you have an APS of exactly 1 (60 frames), then with the 50% buff from rivera dancers this would go up to 1.5 (40 frames), but the ICD on obsidian ring / gyana na kashu is still 60 frames, so the simulation looks like this:
t=0f: use LTK; gyana+obsidian proc with 60f ICD
t=40f: use LTK, gyana+obsidian still on ICD
t=80f: use LTK, gyana+obsidian proc
and so on
Basically only every other attack or so actually procs the fireball/obsidian ring. The same is also true for the copied LTK from rabid strike (although it doesn't seem like d3planner correctly simulates RS at all right now).

I'm actually not sure if my math/explanation is correct. In practice, it doesn't quite seem 1:2, for example 15 LTK usages = 9 fireballs according to Davlok's tests. I don't know the exact math, but we could do a measurement and get a good approximation for it instead.

I've tried to pinpoint OROZ mechanics, it seemed very inconsistent so I gave up on that and just made it give 1 proc per cast of anything. I'll see if I can find anything more specific on this.
I thought RS should work now?

Could be that the RS bug has been fixed since the date of the post I was sourcing that from. Don't know for certain. But at any rate, RS feels very weak compared to how strong it should be in theory (if it worked correctly and scaled off both rivera dancers and scarbringer).


Stuck upon failing combat

If the player's fleet were to fail, script would interpret the "No remaining fleet" as a commission info message and accept it, after which the game sends you back to the world map, effectively freezing the script (doesn't do any more attempts).
Re-entering the specified map manually seems to resume normal operation as seen by this log
[2019-12-21 16:19:31] Boss fleet was found.
[2019-12-21 16:19:34] Moving towards objective.
[2019-12-21 16:19:37] Starting combat.
[2019-12-21 16:21:31] Found commission info message. ///No remaining fleet message received
[2019-12-21 16:25:24] Current location is: [1510, 551]     ///After manual fix
[2019-12-21 16:25:24] Enemies found at: [[1002, 258], [1188, 492]]
[2019-12-21 16:25:24] Closest enemy is at [1188, 492]
[2019-12-21 16:25:27] Moving towards objective.
[2019-12-21 16:25:39] Starting combat.
[2019-12-21 16:26:43] Combat ended.

Will check it out, thanks.

https://github.com/Egoistically/ALAuto/wiki/Creating-new-assets-for-bot


Revert "upgrade: devdeps"

Reverts cherow/cherow#182
@Aladdin-ADD ?

Coverage remained the same at 92.768% when pulling e9dc9004483e971452d84ba4399dc9de159457b8 on revert-182-upgrade-deps into 7b0f59f74971220911b51014934da33d07262fd6 on master.

?

Accidents happen my friend! Ignore it.  你能复习我的公关吗？

sure, I will, but plz give me some more time~

sure, all tests pased (also on CI). am I missing something?


Update element-support.md to indicate RedCircle's support for various tags

Some screenshots from our UI / our feeds:

@daveajones want to give me the stamp?

Stamped!


Enable full feature set for hyper in zenith_utils

Server functionality requires not only the "server" feature flag, but also either "http1" or "http2" (or both). To make things simpler (and prevent analogous problems), enable all features.

For the history: currently direct build of zenith_utils fails with the following message:
Compiling zenith_utils v0.1.0 (/Users/stas/code/zenith/zenith_utils)
error[E0432]: unresolved import `hyper::Server`
 --> zenith_utils/src/http_endpoint.rs:4:30
  |
4 |     Body, Request, Response, Server,
  |                              ^^^^^^
  |                              |
  |                              no `Server` in the root
  |                              help: a similar name exists in the module (notice the capitalization): `server`

But whole workspace build works because reqwest includes same hyper crate with full feature flag.
This PR fixes that.


Added color variations on Text & Heading components

The Heading and Text factories are completely the same, except the word "heading" and "text". Why no use a single factory to create these, instead of duplicating code?

I'm completely on the same track as @Sambego with this. Header is indeed a variation on the text component.

You are both right, but they get a different classname (.header vs .text) and if you take a look in ui-typography you'll notice that .heading & .text got slightly different styling.


trained model error

Hi, the trained model seems not work when compute_d_vector:
Missing key(s) in state_dict: "conv.0.low_hz_", "conv.0.band_hz_"
the keys in checkpoint_load['CNN_model_par']:
conv.0.filt_b1
conv.0.filt_band
conv.1.weight
conv.1.bias
conv.2.weight
conv.2.bias
bn.0.weight
bn.0.bias
bn.0.running_mean
bn.0.running_var
bn.1.weight
bn.1.bias
bn.1.running_mean
bn.1.running_var
bn.2.weight
bn.2.bias
bn.2.running_mean
bn.2.running_var
ln.0.gamma
ln.0.beta
ln.1.gamma
ln.1.beta
ln.2.gamma
ln.2.beta
ln0.gamma
ln0.beta

Thanks a lot.

OK, thank you for pointing it. It seems a model computed with the previous
version of SincNet. Let me update it as soon as possible!
Mirco
On Fri, 12 Apr 2019 at 01:38, donglu<EMAIL_ADDRESS>wrote:

Hi, the trained model https://bitbucket.org/mravanelli/sincnet_models/
seems not work when compute_d_vector:
Missing key(s) in state_dict: "conv.0.low_hz_", "conv.0.band_hz_"
the keys in checkpoint_load['CNN_model_par']:
conv.0.filt_b1
conv.0.filt_band
conv.1.weight
conv.1.bias
conv.2.weight
conv.2.bias
bn.0.weight
bn.0.bias
bn.0.running_mean
bn.0.running_var
bn.1.weight
bn.1.bias
bn.1.running_mean
bn.1.running_var
bn.2.weight
bn.2.bias
bn.2.running_mean
bn.2.running_var
ln.0.gamma
ln.0.beta
ln.1.gamma
ln.1.beta
ln.2.gamma
ln.2.beta
ln0.gamma
ln0.beta
Thanks a lot.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mravanelli/SincNet/issues/32, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGs1gVae7Anlvfycd3HFGjvU6ecDOIEks5vgBvygaJpZM4crXT2
.

Hi,
could you try with the new model in the external repository and with the new compute_d_vector code?

@mravanelli
Thanks very much, it works well now, the d-vector is in 2048 dim.
For open-set speaker verification, I think the model can use a more discriminative loss function such as arcface/amsoftmax insteads of softmax on the top of CNN/DNN layers.

Sure, you can try it!
On Apr 13, 2019 21:56, "donglu"<EMAIL_ADDRESS>wrote:

@mravanelli https://github.com/mravanelli
Thanks very much, it works well now, the d-vector is in 2048 dim.
For open-set speaker verification, I think the model can use a more
discriminative loss function such as arcface/amsoftmax insteads of softmax
on the top of CNN/DNN layers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mravanelli/SincNet/issues/32#issuecomment-482911527,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGs1gHwPBDK_nw0WxCPvvJRXZjWP3Rmks5vgorngaJpZM4crXT2
.


fix: unable to edit task that have read-only tags

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
When a subtask is spawned, some default tags are assigned to the subtask, and they are only read-only.
We can't edit the task anymore without removing the read-only tag, which is annoying.

What is the new behavior (if this is a feature change)?
Handle correctly the task edition without touching the read-only tags.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

Yes, you're right, I was thinking of a PATCH behavior.
Le lun. 21 sept. 2020 à 20:04, Thomas Schaffer<EMAIL_ADDRESS>a
écrit :

@loopfz commented on this pull request.
In api/handler/task.go
https://github.com/ovh/utask/pull/180#discussion_r492249583:

@@ -270,9 +271,13 @@ func UpdateTask(c *gin.Context, in *updateTaskIn) (*task.Task, error) {
t.SetInput(clearInput)
t.SetWatcherUsernames(in.WatcherUsernames)

if err := utils.ValidateTags(in.Tags); err != nil {

return nil, err

// validate read-only tags
v, readOnlyTagUpdated := in.Tags[constants.SubtaskTagParentTaskID]
oldValue, readOnlyTagInTask := t.Tags[constants.SubtaskTagParentTaskID]
if (readOnlyTagUpdated && (!readOnlyTagInTask || oldValue != v)) || (!readOnlyTagUpdated && readOnlyTagInTask) {

It seems right to me, their absence would mean a deletion otherwise?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/ovh/utask/pull/180#discussion_r492249583, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRXWEPFUYBP2UZYN4EQOZDSG6IT5ANCNFSM4RU2FNXA
.

Can I consider that no comments means LGTM ? :D


replace all uses of webpack-merge with deepmerge

we no longer use webpack in any of our tools unless specifically using it build your app, but we still use webpack-merge in many places.
we should replace this with deep-merge which does the job just as well, but with less complexity.
what do you think @daKmoR ?

at some point, we used the webpack-merge strategies but apparently, we no longer do.
if deep-merge does the job sure why not 👍  (last published 5 years ago... not sure if that is a bad or a good sign 😅 🤣 )

Actually I meant deepmerge, not deep-merge. deepmerge was last updated 10 days ago :)
webpack-merge is 9.4k and deepmerge is 664b with 0 dependencies. I know they're not browser libraries, but I still want to try and keep our tools as light as possible.

make sense 👍


standard stakeholder for gas assets should be the system operator

The standard stakeholder of a gas asset should be the system operator and not the customer.

@grdw is already working on this right @grdw?


我应该用什么脚本训练LoftQ？

Reminder

[X] I have read the README and searched the existing issues.

Reproduction
如题，我没找到loftQ的训练脚本
Expected behavior
No response
System Info
No response
Others
No response

和普通 lora 一样


Archive the old repo

Archive the repository, with a prominent note in the README explaining where the development will continue.

This is now done.


Measurement incorrect

Weird things happen during the tests.
The datapoints are wrong (to high) and not smooth.
Probably a problem with the electronic/Arduino-software or the calculation...

EWMA Filter is installed, passed first tests, only good parameterisation pending.


Authentication and Authorization of user for TuneIn purpose

DESCRIPTION
In this PR the changes are done to add a process of Authenticating and Authorizing the user before they modify and submit the TuneIn details. Both authentication and authorization of a user as of now are done using the APIs provided Azkaban which is a scheduler supported by Dr.Elephant.
So before users modify and submit the updated TuneIn details they need to authenticate themselves and then Dr.Elephant will query the scheduler to check if the respective user has Write access to the project whose properties they want to modify.
Login Page:

How Changes are tested
For the APIs for Authentication and Authorization, unit test cases are implemented in various scenarios.

This PR is just just a mirror of PR #535, which was closed due to some git conflicts.

All the comments are handled in PR #535 . LGTM

I'm not sure if VIP token is understood in open source (mentioned in placeholder text). Please consider providing a general text based on some precondition.


Add file-private types. Part of #2950

This makes it possible to use private with top-level types in a file, making them file-private. This is similar to using private on a top-level def.
For example:
# foo.cr
private class Foo
end

Foo.new # OK

# bar.cr
require "./foo.cr"

Foo.new # Error: undefined constant 'Foo'

This can be useful in specs, where we need to define some types only for some specs without fear of having name conflicts, but sometimes we might also need types what we don't want to expose outside a file.
Eventually we can add types private to a type, but for now this is a good start. See #2950

I'm a little apprehensive about this pull request because it essentially defines another "scope" that you have to worry about. Crystal is (mostly) an object oriented language, and source files do not fit into the object hierarchy. It's a bit vague, but it doesn't "feel" right. I support private and protected types in the context of being private to the enclosing type, because then it allows you to extract file-private types into their own files without refactoring.
It is my opinion that instead of defining private classes, you should (currently, until private types) simply mark them as undocumented. In the stdlib where namespace pollution becomes an issue, I would just place them off the top level into the Crystal namespace. Plus, then the classes are available for people who really know what they're doing to use.
In short, I think that this issue is adequately solved by other means while being more friendly to refactoring, so doesn't warrant the extra effort to maintain another feature.

I want to check that this is not an issue.
public_foo.cr
class Foo
end

private_foo.cr
require "./public_foo"

private class Foo
end

foo = Foo.new # ok, this is the file private Foo.

# But, is there a way to reference the public Foo? Do we want it?
# ::Foo won't work that well because we might need it to reference the private top level Foo
# from nested classes.

@bcardiff To reference the public Foo you can do ::Foo. With ::Name file-private types are never looked up.

private class Foo
end

class Bar
  class Foo
  end
  # Foo means Bar::Foo
  # ::Foo should mean the private foo IMO
  # hence the private ::Foo hides the public ::Foo
end

I am ok with either this or what you just wrote. I just wanted to expose the scenario.

The scenarios I imagine I'd want to use a private type is when I want to declare a type and use it in that file only. In that case I can't imagine why I'd choose a name that would already conflict with other types I'm using in that file.

I agree :-) But i can't help myself

Having multiple classes with the same complete namespace, but different visibilities strikes me as totally confusing. If a public class ::Foo exists, then declaring a private ::Foo one should be an error IMO

@RX14 On the contrary, that's the whole point of private classes: I want to define a class in this file, and I don't want it to conflict in the future if someone defines a public one with that name. Giving an error in this case would basically make private types useless.
This is the same reason one uses private defs in a file: I want to declare a method and not letting anyone accidentally redefine it.

I'm a little puzzled on this feature. I can hardly find any usecase. I always use namespaces, so private types means I would need to create them outside of the namespace, at the top level, which seems wrong.
I would see use cases for protected types inside a namespace that would behave like methods: a compile time error when trying to reference them out of scope (ie. no shadowing).

two use cases are described in this thread: https://github.com/crystal-lang/crystal/pull/3276#discussion_r77996881. personally i think it is useful feature to have, but it would be nice if it could be used inside a namespace and behaved similar to private_constant from Ruby in that case.

I'm split on this issue. To me it also seems natural to make private types in a namespace, not at the top level. But then again, I don't have to use it.

@asterite, my point was that this feature is useless.

To clarify, this feature is confusing if you can define multiple seperate classes with the same name, and useless if you can't.
How are you doing to differentiate between two classes with the same name when debugging? You're breaking the expectations set by almost every programming language that types have a unique name. It strikes me as a completely nonsensical tradeoff for something that should be - and already is - done using namespacing via modules.

@jazzonmymind Wow, thanks for commenting here! I did not know about Ruby's private_constant and I think that it's exactly what we should do. Ruby semantics are similar to what I described in #2950, and for now (and probably forever) we don't need to worry about protected types, maybe it doesn't make sense.
I'll soon update this PR with that addition. Private constants are very useful because they will make :nodoc: less needed. But I also think that file-private types are useful, for example in specs, and this behaviour would be consistent with file-private defs, so I'd like to introduce both changes at the same time.

Closed in favor of #3280


Accept string format http events

Shims in an httpEvent object of the correct shape if the original httpEvent is a string.

love it!
I just saw that I broke a test in master. I'll fix that.
Could you also add a test for this new feature?

I'm not familiar with JS test libraries, will try to explore that when I get some time.

serve will be removed in the next v3.0.0 release in favor of serverless-offline (see #152 ). No efforts will be spent on the function anymore. So I'll close this issue.


not/nullable join-column in toone relation

I tried to solved resolving of nullable value in toone relations for PHP Attributes.

Thanks for the PR :+1:  I wanted to go for merge now, but I could not find any test fixture that is added to verify it works.
Could you add it? I'll resolve this one promptly then

cc @samsonasik How about this one, can be closed as well?

Yes, this can be closed. nullable on typed property is always a safe belt for migration on unitialized property, even user define nullable: false, it still can be nullable in real DB afaik.

If you have null in the DB and nullable:false in ORM, you have invalid metadata And you should fix that. I thought Rector is for making quality code not for  supporting od code smell. Same thing with non-nullable columns in the other issues. But I understand your project  your decision.

We learned the hard way in the past for converting non-typed property to typed property rely by docblock.
On migrating code, on small code, that's probably easy to patch, for big code base, you will end up multiple patch.
That's why the rule need to be configurable, we already discuss about it on your other PR, if you don't have time to finish configurable rule, you can create your own custom rule yourself for your needs.

I couldn't know that this rule should be configurable, since in this PR there was no such requirement. It looks similar to #191, but ORM\Column is nullable: false by default, but ORM\JoinColumn nullable:true by default and you must explicitly tell, that it is non-nullable.
I have made configurable rule in the other PR (#191) . But later the maintainers made changes and also removed the interface, which I used for configuring and I would have to change it again. I felt, It would be a waste of my time.


removing some data files

removing some of the tracie files.

Sounds good. Also, I removed the reference to TRACIE in the root README.md.


[Change Request] page 42 "Sales Order"

Describe the request
Hello, can you please move the variables ShowQuoteNo and DocumentIsPosted to protected?
    var
        BillToContact: Record Contact;
        SellToContact: Record Contact;
        SalesSetup: Record "Sales & Receivables Setup";
        GLSetup: Record "General Ledger Setup";
        MoveNegSalesLines: Report "Move Negative Sales Lines";
        ApprovalsMgmt: Codeunit "Approvals Mgmt.";
        ReportPrint: Codeunit "Test Report-Print";
        DocPrint: Codeunit "Document-Print";
        ArchiveManagement: Codeunit ArchiveManagement;
        SalesCalcDiscountByType: Codeunit "Sales - Calc Discount By Type";
        UserMgt: Codeunit "User Setup Management";
        CustomerMgt: Codeunit "Customer Mgt.";
        FormatAddress: Codeunit "Format Address";
        PrivacyNotice: Codeunit "Privacy Notice";
        PrivacyNoticeRegistrations: Codeunit "Privacy Notice Registrations";
        ChangeExchangeRate: Page "Change Exchange Rate";
        Usage: Option "Order Confirmation","Work Order","Pick Instruction";
        JobQueueVisible: Boolean;
        Text001: Label 'Do you want to change %1 in all related records in the warehouse?';
        Text002: Label 'The update has been interrupted to respect the warning.';
        HasIncomingDocument: Boolean;
        DocNoVisible: Boolean;
        ExternalDocNoMandatory: Boolean;
        OpenApprovalEntriesExistForCurrUser: Boolean;
        IsPowerAutomatePrivacyNoticeApproved: Boolean;
        OpenApprovalEntriesExist: Boolean;
        CRMIntegrationEnabled: Boolean;
        CRMIsCoupledToRecord: Boolean;
        ShowWorkflowStatus: Boolean;
        IsOfficeHost: Boolean;
        CanCancelApprovalForRecord: Boolean;
        JobQueuesUsed: Boolean;
        DocumentIsScheduledForPosting: Boolean;
        OpenPostedSalesOrderQst: Label 'The order is posted as number %1 and moved to the Posted Sales Invoices window.\\Do you want to open the posted invoice?', Comment = '%1 = posted document number';
        PaymentServiceVisible: Boolean;
        PaymentServiceEnabled: Boolean;
        IsPostingGroupEditable: Boolean;
        EmptyShipToCodeErr: Label 'The Code field can only be empty if you select Custom Address in the Ship-to field.';
        SureToRejectMsg: Label 'Rejecting this order will remove it from your company and send it back to the partner company.\\Do you want to continue?';
        CanRequestApprovalForFlow: Boolean;
        CanCancelApprovalForFlow: Boolean;
        IsCustomerOrContactNotEmpty: Boolean;
        SalesDocCheckFactboxVisible: Boolean;
        WorkDescription: Text;
        StatusStyleTxt: Text;
        IsSaas: Boolean;
        IsBillToCountyVisible: Boolean;
        IsSellToCountyVisible: Boolean;
        IsShipToCountyVisible: Boolean;
        IsJournalTemplNameVisible: Boolean;
        IsPaymentMethodCodeVisible: Boolean;
        IsSalesLinesEditable: Boolean;
        ShouldSearchForCustByName: Boolean;
        IsBidirectionalSyncEnabled: Boolean;
        RejectICSalesOrderEnabled: Boolean;
        VATDateEnabled: Boolean;
        BasicEUEnabled: Boolean;

    protected var
        ShipToOptions: Enum "Sales Ship-to Options";
        BillToOptions: Enum "Sales Bill-to Options";
        CallNotificationCheck: Boolean;
        ShowQuoteNo: Boolean;
        DocumentIsPosted: Boolean;

Additional context
We would like use for Page Extension
Internal work item: AB#499149

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 17192.


Add microbenchmarks scripts

These are taken from https://github.com/knative/eventing/tree/master/test.
The goal is to add later a github action to run them, so we can easily support running microbenchmarks in all the different knative projects.
Sorry in advance for my poor shell scripting abilities.
Signed-off-by: Francesco Guardiani<EMAIL_ADDRESS>

I think the failure is your scripts should define a set of bash functions that integrators use by importing them, not direct run scripts.
See https://github.com/knative/hack/blob/master/e2e-tests.sh as an example. Note none of the other hack scripts are something you run, only something you import.

@n3wscott How should I use them in my GH actions? Should I source them and run the single functions?

That should do it @n3wscott


MatTab @bind-ActiveIndex initialization doesn't bind to a number besides 0

Describe the bug
MatTab's default tab is always set to the first one (zero) regardless of the value binded to ActiveIndex. This issue is also present in the TabIndex example from the MatBlazor docs.
To Reproduce
Create the below component and run
<MatButton` OnClick="@ChangeTab">Change Tab</MatButton>
<div>
    Active tab index: @tabIndex
</div>
<MatTabGroup @bind-ActiveIndex="@tabIndex">
    <MatTab Label="First">
        First Content
    </MatTab>
    <MatTab Label="Second">
        Second Content
    </MatTab>
    <MatTab Label="Third">
        Third Content
    </MatTab>
    <MatTab Label="Fourth">
        Fourth Content
    </MatTab>

</MatTabGroup>

@Code  {
    public int tabIndex = 2; //notice that this is set to 2. In the docs, it is set to zero
    //what I expect is the active tab on initialization to be the third one

    void ChangeTab(MouseEventArgs e)
    {
        tabIndex = tabIndex < 3 ? tabIndex + 1 : 0;
    }
}

Expected behavior
I expect the active tab to be set to the tabIndex on initialization
Additional context
I need this to work to be able to "remember" the user's last clicked tab.

Try calling StateHasChanged();
I dynamically set active tab (though not through a button click) and it doesn't work without StateHasChanged();

@americanslon Oh my God, thank you so much. It works. I completely forgot about the StateHasChanged() method.

Where exactly do you need to put the StateHasChanged() method? I've tried putting it inside OnInitializedAsync, din't work.

Call it in OnAfterRender().

Remember that StateHasChanged() causes the component to be rerendered.
https://docs.microsoft.com/en-us/aspnet/core/blazor/components/lifecycle?view=aspnetcore-6.0#state-changes-statehaschanged
If you want to change to another tab it will just loop on setting value OnAfterRender. You can use parameter firstRender to solve this though.
https://docs.microsoft.com/en-us/aspnet/core/blazor/components/lifecycle?view=aspnetcore-6.0#after-component-render-onafterrenderasync
Example to change tab via optional URL parameter:
@page "/product/{Id:int}/{TabId:int?}"

<MatTabGroup @bind-ActiveIndex="@tabIndex">

</MatTabGroup>

@code {
    [Parameter]
    public int Id { get; set; }

    [Parameter]
    public int? TabId { get; set; }

    private int tabIndex = 0;

    protected override void OnAfterRender(bool firstRender)
    {
        if (firstRender)
        {
            if (TabId == null)
            {
                TabId = tabIndex;
            }
            tabIndex = TabId.Value;
            this.StateHasChanged();
        }
    }
}


Foundation: correct handle management on URLSession

We would cast the CURL socket type to an Int and back during the
MultiHandle setup.  This does not work properly for Windows.  Given that
the interfaces are internal, keep the type sugar as far as possible
before handing off to libdispatch.

@swift-ci please test

CC: @millenomi

@swift-ci please test

@swift-ci please test


DBZ-740 Remove most DMLs from test execution

https://issues.jboss.org/browse/DBZ-740
Test time reduced from 15 secs to 5 secs

I'm wondering, is it actually a good idea to remove them? After all, we maintain that grammar, so it seems reasonable to leave those tests in place. Would be different if we were to pull it from upstream as a dependency.

Going to close it as "Won't Do" as discussed via chat. Thanks neverthelese, @jpechane!


Files list should start collapsed

This is more inline with most editors.
Longer term we should persist settings such as open folders between user sessions via local-storage (filing other bugs for this).
@dwl285 for updates

Woohoo
On Thu, 28 Feb 2019, 18:50 Lewis Hemens<EMAIL_ADDRESS>wrote:

Closed #106 https://github.com/dataform-co/dataform-tracking/issues/106
via 0954e8c2e5f4bef12958097c5e3d30bf63099dfd.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dataform-co/dataform-tracking/issues/106#event-2171981696,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvK8CEzxlOUPkBbF8MAViB_G__Mi44Zks5vSCTxgaJpZM4bJsWa
.


Energy and Echo pack: clarify Echo keyword to say that it creates an unmodified copy

I guess that'll solve #731 then. Personally, I don't think it was needed since we had precedence in other cards, but I don't much care since it's in a keyword.

I guess that'll solve #731 then. Personally, I don't think it was needed since we had precedence in other cards, but I don't much care since it's in a keyword.

I don't have a strong opinion on this but I figured it was mildly helpful at best and almost entirely harmless at worst.
I made the change before knowing that the Github issue existed (I never even thought to check for one), so I wouldn't mind if you decided to revert it or something. Either way it's a very minor thing.


python3Packages.mip: init at 1.14.1

Description of changes
Python MIP is a toolset for the modeling and solution of mixed-integer linear programs, at the heart of many real-world mathematical optimization problems.
Not only useful to engineers operating on the field, Python MIP is also used for teaching linear programming in university courses.
Contributes to the closure of #112353.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@RaitoBezarius as a final adjustment, do you think it would be better to delete the precompiled shared libraries that come with the source distribution, as to decrease the output size?

@RaitoBezarius as a final adjustment, do you think it would be better to delete the precompiled shared libraries that come with the source distribution, as to decrease the output size?

If those are completely useless for NixOS because they are not patched or whatever, yes.

If those are completely useless for NixOS because they are not patched or whatever, yes.
But it may make it harder to maintain the package if they change this kind of stuff.

Yes, they are completely useless to the library once installed, as the wrapper instructs the interpreter to use the libraries provided by Nixpkgs.
Unfortunately, I just discovered that the required environment variables are not passed to the test runner, so the tests rely on the pre-compiled libraries. Do you happen to know how should I do it? I never quite wrapped my head around hooks and such, and simply exporting the variables as part of the preCheck phase does not seem to be of any help (here is a draft):
preCheck = ''
     export PMIP_CBC_LIBRARY=${cbc}/lib/libCbcSolver.${if stdenv.isDarwin then "dylib" else "so"}
   '' + lib.optionalString gurobiSupport ''
     export GUROBI_HOME=${if builtins.isNull gurobiHome then gurobi.outPath else gurobiHome}
'';

Unfortunately, I just discovered that the required environment variables are not passed to the test runner, so the tests rely on the pre-compiled libraries. Do you happen to know how should I do it? I never quite wrapped my head around hooks and such, and simply exporting the variables as part of the preCheck phase does not seem to be of any help (here is a draft):

Wouldn't that mean the test runner ignores any environment variables provided? It sounds like a problem in the test runner or the wrapped scripts blocked the import of the external environment variables.

Looks like I misinterpreted the test results, the environment variables were indeed being passed.
What happened instead is that our CBC build exposes an API that is older than what MIP expects, resulting in a general failure. Unfortunately enough, I didn't notice this discrepancy while testing the package manually on some LPs.
I am now reverting back to the built-in library and re-running all the tests.
It seems like there is no better way of doing this without placing additional maintenance effort on the Nixpkgs side, as a custom derivation of CBC coming from an untagged commit on master would be needed. This would entail keeping track of all commits that modify the pre-compiled binary, guessing the corresponding commits on CBC's master, and then maintaining this more up-to-date derivation separately.
Judging from issues like coin-or/python-mip#165 and coin-or/python-mip#239, upstream is having a hard time following a consistent and transparent release process for Python MIP, therefore this solution will be necessary as long as they won't solve their organizational problems.

@RaitoBezarius I am sorry for the review request spam, I've been careless with the test environment.

No worries ;) keep spamming me as much as you need. ;)
Le dim. 4 déc. 2022 à 22:44, nessdoor @.***> a écrit :

@RaitoBezarius https://github.com/RaitoBezarius I am sorry for the
review request spam, I've been careless with the test environment.
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/197222#issuecomment-1336524636,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACMZRCGVWCRCXS6VFIG6LDWLUGDFANCNFSM6AAAAAARL3BRNA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Can you rebase most of the commits into python3Packages.mip: init at 1.14.1 (except if the commit must be split on its own)?
Do the testing stuff have been sorted out and can I run ofborg on it?

All done, you can borg it up.

@ofborg eval

Result of nixpkgs-review pr 197222 run on x86_64-linux 1

2 packages failed to build:

python310Packages.mip
python39Packages.mip

1 package built:

darwin.builder

Can you see what is wrong with the builds? Does ofborg leave logs around?
I will re-test everything through nixpkgs-review during the day.
I swear everything worked fine on my machine.
I have to track down the impurity.

Can you see what is wrong with the builds? Does ofborg leave logs around? I will re-test everything through nixpkgs-review during the day. I swear everything worked fine on my machine. I have to track down the impurity.

I am seeing
error: builder for '/nix/store/520ivga7ad703vp5zy50nxjb38g7vb6s-python3.10-mip-1.14.1.drv' failed with exit code 1;
       last 10 log lines:
       >
       > test/dbft_test.py ..........                                             [  1%]
       > test/examples_test.py ........................                           [  6%]
       > test/mip_files_test.py ................................................. [ 15%]
       > ............                                                             [ 17%]
       > test/mip_test.py .........................                               [ 22%]
       > test/numpy_test.py ..                                                    [ 22%]
       > test/rcpsp_test.py ..................................................... [ 32%]
       > ........................................................................ [ 45%]
       > client_loop: send disconnect: Broken pipe
       For full logs, run 'nix log /nix/store/520ivga7ad703vp5zy50nxjb38g7vb6s-python3.10-mip-1.14.1.drv'.
error: unexpected end-of-file
error: builder for '/nix/store/ar0g3yz9fk8849427nbsf851wdrpl4dx-python3.9-mip-1.14.1.drv' failed with exit code 1;
       last 10 log lines:
       >
       > test/dbft_test.py ..........                                             [  1%]
       > test/examples_test.py ........................                           [  6%]
       > test/mip_files_test.py ................................................. [ 15%]
       > ............                                                             [ 17%]
       > test/mip_test.py .........................                               [ 22%]
       > test/numpy_test.py ..                                                    [ 22%]
       > test/rcpsp_test.py ..................................................... [ 32%]
       > ........................................................................ [ 45%]
       > client_loop: send disconnect: Broken pipe
       For full logs, run 'nix log /nix/store/ar0g3yz9fk8849427nbsf851wdrpl4dx-python3.9-mip-1.14.1.drv'.
error: 2 dependencies of derivation '/nix/store/xdjd6ksr3is45ik4m1gdgf217ksyny3z-review-shell.drv' failed to build

It may be transient.

Result of nixpkgs-review pr 197222 run on x86_64-linux 1

1 package marked as broken and skipped:

darwin.builder

2 packages built:

python310Packages.mip
python39Packages.mip

Could it be that we're hitting a time/resource limit on ofBorg? These tests are pretty intense, as they involve heavy calculations.

Thank you for your caring reviews


Prompt Application Layer

Flask backend
React Frontend

based off https://github.com/nickumia/nlp-web

This ended up being just the prototype of the frontend.  I don't think doing this with a flask backend makes sense at this point.  We don't have enough details of the inner workings of the platform to know whether we need a complex backend application yet.
We'll continue designing the frontend before revisiting the backend.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/54884

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/63388


Make it run on gentoo and archlinux

Unify gentoo and arch in the same task
Add system-auth gentoo file

Thanks for the PR!

I spent some time trying to enable testing of gentoo in a branch in this repo but I'm stumbling on how to enable USE flags :)
Do you know how to ? Also there's many USE= in that output. Do you have an idea how to easily get a list of all the USE flags needed for a package and all its dependencies?
https://travis-ci.org/CSC-IT-Center-for-Science/ansible-role-sssd/jobs/175010740

You're right. sssd requires lots of use flags and masks.
I would run
emerge --autounmask-write sssd
etc-update --automode -5
emerge sssd

That way, emerge automagically sets the dependencies flags for sssd
Hope it work!

If I run those commands - do I use those to install sssd and not ansible? If so it's not really a good fix.
Anyway, I tried to add those to the .travis file and the ansible command still doesn't work :/
Is the role working for you?

It use to work. I'll test against a clean docker gentoo container and check what need to be fixed.


RcamMetadata Input Handle

I am testing button and knob for 9~15, but they don't work.
Then I found problem in the MakeInputState() & UpdateState() of InputHandle.cs.
fix button and toggle value array to solve this issue
_buttons[bit] ->_buttons[bit + i * 8]
_toggles[bit] -> _toggles[bit + i * 8]

Thanks for pointing it out. Your solution is right. I don't have time for fixing it at the moment, I'll do it when I get available time.


Upload files from React Native to Meteor ?

Hello !
What method i can you use for upload image or video files into backend ?
What practices are best suited for working with files between RN and Meteor ?
Thx.

This project includes CollectionFS, which is deprecated.
I think Meteor-Files is recommended, but there is no implementation of it in this project.

Will this work - https://github.com/VeliovGroup/Meteor-Files/wiki/React-Example?

No. Did you find anything? I kinda have the same problem

@giovapanasiti
Here is threads where developers are using Meteor-Files with react native:

Using HTTP upload: https://github.com/VeliovGroup/Meteor-Files/issues/430
Using POST HTTP upload: https://github.com/VeliovGroup/Meteor-Files/issues/271
https://github.com/VeliovGroup/Meteor-Files/issues/95
https://github.com/VeliovGroup/Meteor-Files/issues/74

Let me know if it is useful for you


Make image tasks pausable

Add -pause method to DFImageTask
DFImageManager should be able to put tasks back into suspended state
Add optional pause to the operation, returned by DFImageFetching protocol. Waiting for #29
Make NSProgress pausable
Support pause in image fetchers

This feature is available in Nuke, DFImageManager is deprecated.


python-xdis out of date for uncompyle6

The latest packaged version of xdis is 4.2.4, while uncompyle6 already requires xdis<4.6.0,>=4.5.1.
To Reproduce
Steps to reproduce the behavior:
nix-env -i python3.7-uncompyle6
Expected behavior
Required dependencies are packaged.
Additional context
uncompyle6 is required for unrpa, which is the package I originally tried to install.
Metadata
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.6.15, NixOS, 20.09pre228204.467ce5a9f45 (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.4`
 - channels(root): `"nixos-20.09pre228204.467ce5a9f45"`
 - channels(manu): `"home-manager, nixos-20.09pre228204.467ce5a9f45, nixpkgs-20.09pre228384.c27e54de99d"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: unrpa
# a list of nixos modules affected by the problem
module: python3.7-uncompyle6

I tried bumping xdis to 4.5.1, but the load file test fails. Unfourtunately I have no idea how to fix it (yet):
ImportError: File name: '/build/source/xdis/__pycache__/load.cpython-37.pyc' doesn't exist

I also have this issue.

xdis has been updated, should be fixed now


[OTHER] update twitter link

What would you like to share or ask?
We have updated our twitter handle from @the_linkshub to linkshubdotdev . Kindly the repalce the link with this one https://twitter.com/linkshubdotdev
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[ ] I am willing to work on this issue (optional)
[ ] I am a GSSoC'23 contributor

Hello @rupali-codes, I'm willing to work on this issue. So kindly assign me for further development!


UI: category entry bug (minor)

Location: Confirm variables page
Usage: Entering Categorical variables
Issue:

If copying and pasting a comma delimited string such as:
ac, kj, ys, bh1, bh2, jm, mh, cw, jp, rh, aq, ph, le, mn, ls2, no, af

The UI saves the results as separate strings, but doesn't trim the spaces around each string, e.g. could have:

['ac', ' kj', ' ys', etc.]   # 2nd and 3rd items have a leading space

Fix: Trim the leading/trailing spaces from categorical variables
(Note: this has been updated on the server side in branch 683-stat-spec--e.g. spaces are trimmed)

fixed on the server side


Fix source watcher configuration

Problem is that FileWatcher is created in before_sitemap callback which results in default config all the time, no matter what are user's settings for watcher_disable, watcher_force_polling, watcher_latency and watcher_wait_for_delay.
This PR fixes it by configuring SourceWatcher instance in FileWatcher's after_configuration callback.

This is great, I think I was only using those options from the command line so didn't notice it not working if done via config.rb.
One request, can you keep the old initialize signature the same. I'd rather not break API compatibility. Even if the options is no longer used, let's keep the argument list the same.
Thanks!

Taking a look now.

This fixes it: https://github.com/middleman/middleman/commit/b4699cd741f22425b45cb7751f2c358f68ae6bb0
Basically, when a source path changes, re-poll (since the watch is not not running during the change).

@tdreyno Oh, thank you!
I cherry picked your commit to my branch.

Thank you!