cancel(task): argument [object Object] is not a valid Task object . After update beta.2 => beta.3

Description
After updating my tests stopped working
  function* runnerBetween() {
    while (true) {
      yield take(startActionType);

      const taskId = yield fork(saga);

      yield take(endActionType);
      yield cancel(taskId); // Error: cancel(task): argument [object Object] is not a valid Task object
    }
  };

I chack changelog. What thah it mean:

we have stopped interpreting effects returned from fork, this shouldn't affect any real-life code, affected patterns look like this fork(() => effectCreator()) and fork(takeEvery, 'type', fn)

Could u provide a full working repro for your problem?
The mentioned entry from the changelog shouldnt affect you, it's about not interpreting returned effects from forked functions, as in
yield fork(() => {
  return put({ type: 'TEST' })
})

The TEST action won't be dispatched starting from 1.0.0-beta.3


[Feature]: Custom routes declaration

What is the new or updated feature that you are suggesting?
Declare routes based on a custom routes builder or a Json file
Why should this feature be included?
This is mandatory for websites that support i18n and and which must have routes translated for SEO purposes .
For example :
https://www.mister-auto.es/aceite-de-motor/
https://www.mister-auto.com/huile-moteur/

You can do that right now using the routes function in remix.config.js
See https://remix.run/docs/en/v1/api/conventions#routes


[CRTOOL] increase to version 2.1.0 to store review sessions on server

Bump Curriculum Review Tool to version 2.1.0
Please create a feature branch environment for this, so we can get Product Owner approval before it is merged into the main branch.

Closed in favor of #6049


Add option to reset to solved state

Sometimes the scramble is unsynced with the cube's solved state . The scramble letters turns gray even though I haven't turned the cube yet. It happens rarely, but when it happens I have to refresh the browser and connect the cube again
We can reset the solved state and generate a new scramble or just reset the state to solved

Yes, I faced it a few times too.

Well, I think it would be enough you to follow the scramble anyway and start timer, then press "reset" button once it's solved, since you should solve the cube in both way.
Or, the unsync always happens on the very first turn of the scramble? Then I doubt the greyout is triggered by overturn from the last solve, and just following scramble could work it out.

It doesn't always happen . I agree you could press reset once solved ,  sometimes though I quit solving when I messed up something and hit reset. So , it is a convenient feature to have.

Thank you @hakatashi for developing this tool. I did some experiments on my fork and implemented this things:
RESET during scramble phase

if you have connected but have NOT solved the cube. Solve it first then once solved press RESET to generate a new scramble
if the scramble highlighting is NOT synced with your cube state. Solve it first then once solved just press RESET to generate a new scramble

RESET during inspect phase

If you decide to not continue (for some reason). Just press RESET, it will direct you to the prescamble phase. You need to solve your cube before a new scramble will be generated

RESET during solve phase

If you decide to not continue (for some reason). Just press RESET, it will direct you to the prescamble phase. You need to solve your cube before a new scramble will be generated

You can try it here: https://geocine.github.io/smart-cube-timer/
If anything of this is of interest to @hakatashi , I will be doing a pull request.

@geocine,
When I tried your version,
The first time, i hit reset during a solve, then finished the solve after that i hit reset again. It stopped syncing my moves after that.
The second time, I hit reset during a solve, then finished solving the cube, it recognized that the cube is solved and showed me a scramble. After the first 2 moves of the scramble, it stopped syncing again.
I don't face these issues on the timer by @hakatashi

@shiv19
I will try to understand and reproduce your issue, thanks for your feedback. Maybe the context of reset is confusing to someone that uses it other than what I have intended it to do. Nonethless, if scramble stops syncing just solve it and hit reset.
I noticed though even on @hatakashi , the scramble gets unsynced if you move too fast during a scramble. Just my observation.

@geocine Thanks for your contribution. The feature you proposed may empower the app, but after few tries of your timer I feel like the meaning of "RESET" button may vary by context and confusing. That means, RESET could mean "cancel the current solve" or "sync the inner state of timer to solved". But now I think having both cancel and sync feature is good thing.

If anything of this is of interest to @hakatashi , I will be doing a pull request.

Feel free to send me a patch😉. For the above reason I cannot just merge your commits, but I can continue working on it.

@hakatashi I agree the context of reset is confusing on different cases. I tried doing this without adding an extra button.
This is not a good feature to pull request. At least I have proven a point as to why this could be a good thing and glad that you are considering it :+1:


Optional newline on info and comment functions

It may be useful for some verbose Artisan commands to add a bool parameter 'newline' to 'info' function and 'comment' function. When 'newline' is true, the info or comment line will printed with 'writeln', otherwise will printed with 'write'.
The functions 'comment', 'question' and 'error' work only with 'writeln' because they need to be highlighted in some way during the execution of Artisan command.

Squash to one commit after and you should be good :+1:

In this case I would just suggest using $this->output->write().


Yum exclude dispayed with nothing

When the yum exclude line is included in yum.conf however does not exclude anything it still showing within the output as:
    Yum Exclusions:
        You currently have the following exclusions set in your yum configuration: exclude=

Fixed in Commit #0ff1aa9b63e772a27bde85e501eec540c198056d


deck dump --select-tag X doesn't dump linked plugins

Hello,
deck 1.7.0 'dump' command with '--select-tag' option exports only objects that have a tag,
but not linked objects (plugins that are connected to a service/route (I have checked for ip-restriction and jwt plugins)).
I think that this is core functionality, because plugins don't allow tags + exporting part of service/route configuration (wo plugins) doesn't have a lot of sense?
I tried a workaround - adding required plugins to a state file, but
"deck diff" shows that plugins need to be created
"deck sync" fails on plugin creating step (UNIQUE violation detected on ....)
We are using terraform with kong, deck looks very interesting, but I couldn't get it working as terraform replacement yet (issue above is one of reasons).

Am I trying to use deck in some strange way?

@anton-mesnyankin I don't think you are; I'm experiencing this issue too. Same deck version.

I ended up writing a bash script to work around this that seems to work.
This script saves the plugins per service or route to a local filesystem path similar to that of the API request path (e.g. so you can maintain them under version control), then reads plugin data from those files file and pushes it the Admin API using curl.
See related docs for Admin API endpoints to list or update plugins.
The script looks something like the sample below. If you prefer using YAML, it should be possible to tweak this to use something like yq.
# Admin API base URL; see https://docs.konghq.com/gateway-oss/1.5.x/admin-api/ for port information
addr="http://$host:8001"

# Local directory where plugin information will be written to and read from
plugins_dst="$PWD/kong"

# Path to local jq executable with some default flags; see https://github.com/stedolan/jq/
jq="path/to/jq -r -M -c"

# Path to local deck JSON dump
file="path/to/deck-dump.json"

# Functions to get route and service identifiers from the local dump using jq

get_route_ids () {
    $jq < $file '.services | .[] | .routes | .[] | .id' | tr ' ' "\n"
}

get_service_ids () {
    $jq < $file '.services | .[] | .id' | tr ' ' "\n"
}

# Function to write plugin dumps to the local filesystem

write_plugins () {
    local entity="$1"
    local entity_id="$2"
    local plugin_dst="$plugins_dst/$entity/$entity_id/plugins.json"
    [ -d "$plugin_dst" ] || mkdir -p `dirname "$plugin_dst"`
    curl -s "$addr/$entity/$entity_id/plugins" > $plugin_dst
}

# Function to push local plugin dumps to the Admin API

update_plugins () {
    local entity="$1"
    local entity_id="$2"
    local plugins=`$jq < "$plugins_dst/$entity/$entity_id/plugins.json" '.data | .[]'`
    [ -z "$plugins" ] || echo "$plugins" | while read plugin; do
        local plugin_id=`echo "$plugin" | $jq '.id'`;
        curl -v -X PUT \
            -H 'Content-Type: application/json' \
            --data-raw "$plugin" \
            "$addr/$entity/$entity_id/plugins/$plugin_id";
    done
}

# To write plugins for both routes and services to the local filesystem:

for route_id in $(get_route_ids); do
    write_plugins 'routes' "$route_id";
done

for service_id in $(get_service_ids); do
    write_plugins 'services' "$service_id";
done

# To push local plugin dumps for both routes and services to the Admin API:

for route_id in $(get_route_ids); do
    update_plugins 'routes' "$route_id";
done

for service_id in $(get_service_ids); do
    update_plugins 'services' "$service_id";
done

This is the expected behaviour: whenever tags are used, it's expected that they are added accordingly to all entities.
$ deck dump --yes --select-tag managed-by-deck

$ cat kong.yaml
_format_version: "1.1"
_info:
  defaults: {}
  select_tags:
  - managed-by-deck
services:
- connect_timeout: 60000
  host: mockbin.org
  name: svc1
  plugins:
  - config:
      per_consumer: false
    enabled: true
    name: prometheus
    protocols:
    - http
    - https
  port: 80
  protocol: http
  read_timeout: 60000
  retries: 5
  tags:
  - managed-by-deck
  write_timeout: 60000

Closing this. Feel free to reopen or comment back if you have any more doubts or questions.


dev tools crashing and logging out all connected accounts

Before Reporting

[X] I found no existing issues matching my bug
[X] My issue is not caused by a plugin or theme

Describe the Bug
so basically everytime (i) use devtools it crashes my betterdiscord and when i reload it it just makes it so it logs out all of my connected accounts to the discord app and i have to re-sign into all of them again i dont know why it does this but please check on it.
Expected Behavior
being able to actually use devtools but no it just crashes when i open dev tools
Steps To Reproduce

Turn on devtools in betterdiscord
Click Control + Shift + i
and it just crashes but its 50/50

Operating System
Windows
Discord Version
Stable
BetterDiscord Version
v1.9.3
Anything else?
crashing when using dev tools

From what I've experienced this is simply a bug with vanilla Discord, although it only happens on Windows for some reason.

The crashing is related to hitting the 2gb memory limit and running out of memory, because devtools use a lot of memory
the getting logged out is due to discord "hiding" your token when you open devtools to protect you from scams.
Hiding means that it removes all your tokens from all storages.
Normally, it would add them back when you close devtools again, but since you crashed, it never restored them and thus you get logged out

although it only happens on Windows for some reason.

@KontrollFreek because Discord on Windows uses 32bit electron, whereas on Linux and Mac it uses 64bit. The 2gb memory cap only exists in 32bit chromium, so it only OOMs on Windows

no. this is a hard chromium limitation

It's exactly as Ven described. The Devtools causes a large increase in memory usage and with Discord itself being a hog you can easily hit the 2gb limit on Windows. The workaround is the setting in BD already noted.


Chronic Kidney Disease Analysis using Logistic Regression

Related Issue
Chronic Kidney Disease Analysis using Logistic Regression.
Hacktoberfest2021 Participant
Contributor
Closes:
Issue Number#25
Describe the changes you've made
I have made a jupyter notebook consisting of the code and theory explaining each and every step. I have explained in detail how Logistic Regression can be applied to find whether a person is suffering from kidney disease or not. I have also included a README file that gives a brief description of the model and its application.
How Has This Been Tested?
I have run each and every code and verified each point that I have mentioned in the README file from various sources.
Checklist:
x My code follows the guidelines of this project.
x I have performed a self-review of my own code.
x I have commented on my code, particularly wherever it was hard to understand.
x I have made corresponding changes to the documentation.
x My changes generate no new warnings.
x I have added test cases that prove my fix is effective or that my feature works.

Great work,
LGTM! @Rishita11 🚀, Thanks for your contribution!!


Setup Netlify local dev

Update Makefile to host local dev on Netlify.

All about remote dev workflow so don't worry about it being local.


python38: remove

The end of life for Python 3.8 is scheduled for 2024/10. As such it cannot be a part of NixOS 24.05, because its support cycle goes past that.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build gcc-arm-embedded-11 gcc-arm-embedded-12 gcc-arm-embedded-13 google-compute-engine valhalla qt5.qtwebkit


Eslint dependencies versions updates

SUMMARY
Upgrade eslint packages: eslint, eslint-config-airbnb, eslint-import-resolver-webpack, eslint-plugin-cypress and their dependencies.
This is the first pull request of the series - as upgrading eslint-config-airbnb caused a lot of new errors, I disabled the offending rules and I will re-enable them in subsequent PRs with proper fixes.
TEST PLAN
Run eslint on source files, verify that there are no new Javascript/Typescript errors.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Hey @rusackas, can you please take a look?

Also, maybe you could add comments next to the rules you disabled for this PR, that way we know which ones we want to reenable sooner rather than later

Codecov Report

Merging #10839 into master will decrease coverage by 1.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10839      +/-   ##
==========================================
- Coverage   61.34%   60.29%   -1.05%
==========================================
  Files         380      380
  Lines       24068    24057      -11
==========================================
- Hits        14765    14506     -259
- Misses       9303     9551     +248

Flag
Coverage Δ

#python
60.29% <ø> (-1.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
31.91% <0.00%> (-59.58%)
:arrow_down:

superset/db_engine_specs/hive.py
53.90% <0.00%> (-30.08%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.16% <0.00%> (-12.50%)
:arrow_down:

superset/db_engine_specs/presto.py
70.85% <0.00%> (-11.44%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/api.py
81.38% <0.00%> (-7.98%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686c19a...b8e4011. Read the comment docs.

@etr2460 I will add comments to the rules that will soon be re-enabled (I have a series of PRs incoming as soon as we merge this one 🙂). However, some of the rules require some discussion about whether we want to re-enable them or not. I'll mark them appropriately.
@rusackas That error from ESLint seems legit as we do import zlib and path in webpack config files explicitly. If we don't want them to be listed in package.json deps, then maybe we should just disable the no-extraneous-dependencies rule?


BCH address is invalid

Was searching web for js lib to verify bch address, and found you lib.
Cant get my coinomi wallet address to validate, lib shows that it invalid:
qqvek95wvh6gxg5aeyv6u4huxtwxmpm575rsvn40yz
bchaddr.isMainnetAddress('qqvek95wvh6gxg5aeyv6u4huxtwxmpm575rsvn40yz')

And all other functions (cashAddress, etc)
What is wrong with that address?

Took some random addresses from https://blockchair.com/bitcoin-cash/transaction/d7c017a4bc147504da8fdf60364d2987debda5c19b14567f41e812939baf486d
All are invalid. Something definitely wrong in what Im doing.
bchaddr.isCashAddress('pq9wu6klkr67ww6fz2r8v4e6pcenvgqmkgy677vszd')

Hi @Dmatafonov ,
I've just tested the two examples you've provided and they seem to be working for me:
> bchaddr.isMainnetAddress('qqvek95wvh6gxg5aeyv6u4huxtwxmpm575rsvn40yz')
true
> bchaddr.isCashAddress('pq9wu6klkr67ww6fz2r8v4e6pcenvgqmkgy677vszd')
true

This is most likely an issue with your node version. Could you please share the output of the following command on your system?
npm --version
node --version

I'm doing it in the browser, not in the node. I need a client side protection from wrong inputs.

Could you share what browser and version you're testing this on?

Here is what I tried
<script src="https://cdn.rawgit.com/bitcoincashjs/bchaddrjs/master/dist/bchaddrjs-0.2.1.min.js"></script>

And then
bchaddr.isMainnetAddress('qqvek95wvh6gxg5aeyv6u4huxtwxmpm575rsvn40yz')

Browser chrome 64.0

@ealmansi any ideas how to fix?

@ealmansi any update on this?


Clients

Is there a dart client ? That's what I am interested in.
Or how would someone make a client ?
Jetstream seems to support pull and push.
So then can I presume that grpc can be used to wrap Jetstream consumer API ?
Grpc would make things reusable for many clients

There might be others but I saw https://github.com/c16a/nats-dart, JetStream doesnt need any special clients so you could use an existing core nats on like that.
There might be others, @ColinSullivan1 might know?

thanks @ripienaar
The other option i have is to embed the golang client inside Flutter.
Then we are not reliant on Dart client for NATS.
Good example on the cocept is  here: https://github.com/deromask/deromask

this works fully on Desktop and Mobile by using gomobile and embedding this.
Protobufs are used between gomobile and Flutter layers.

Would appreciate and thoughts on this also...

If you can embed go stuff in flutter then that sounds like a winner :)

Cheers. Will give it a go and let you know how we get on.
Thanks for your advice

Closing this one, feel free to open another issue if you have more questions :)

@ripienaar
The latest NATS Dart cleint is this one btw:
https://github.com/chartchuo/dart-nats
Its reaching maturity slowly. We might help. Not sure yet

@ripienaar
https://github.com/c16a/nats-dart is very old and incomplete
https://github.com/chartchuo/dart-nats looks to be getting close to feature complete.
We might help. Nit sure yet though as we are reviewing options.

Help would be greatly appreciated, and we'd welcome another contribution in this area.  I'm not aware of any other dart client beyond the ones mentioned above.

@ColinSullivan1
We have isolated 3 approaches:

Get on board and help the dart NATS client
Embed the NATS go client via go-mobile
3 wrap the NATS server with GRPC

Option 3 looks like the most interoperable.
We need an untyped interoperability solution because our funders and users are orgs using a variety of languages. By wrapping NATS server side it will allow their microserices to easily talk to the  gateway as well as the flutter client to talk to the gateway.
I wonder if Jetstream will be moving to a grpc based API ?

I'd think #1 or #2 would be ideal.
gRPC does have a lot of language bindings, but you lose location transparency, failover functionality, and NATS does have true multi-tenancy that can help you manage the orgs connecting to you.  NATS does a multitude of client types...   https://nats.io/download/#nats
JetStream won't have a gRPC interface; it'll use core NATS.


[Event Request] Codeunit 1002 Job Create-Invoice

Requesting new event publisher on codeunit 1002 Job Create-Invoice.
OnDeleteSalesLineOnBeforeJobPlanningLineModify(var JobPlanningLine)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


functorize over sleep + channels

I need to go over the tests to get them working again, but this is one attempt at having a core that doesn't depend on lwt.unix. I'm not particularly happy with the end result so i'd be happy to get feedback about if i should explore another route. My end goal is to be able to use lwt-pipe under mirage.

@anuragsoni Could you say more about why this was unsuccessful? I'm also interested in a core that doesn't depend on lwt.unix (I'd like to use lwt-pipe in JavaScript).

@roddyyaga The resulting functorized approach felt a little heavyweight, and eventually I stopped using mirage and lwt so I no didn't get around to finishing this.


Got an error today after opening my panel

I opened my panel and I see this:

I haven't seen this error before, it just occurred when I opened my panel today.

Well that error just says that the response it got is wrong, you'll have to check your __UNAM_LIB\Logs folder for any error files, or there could be error.log files in any of your directories.


Resolving Path Optimization

Motivation: When creating a new file with a long path (the depth of the metadata tree), if the path is the first time to appear in the system, then the cache is not helpful since no object exists in the cache. For every ancestor's path component, FileScale must check its existence in DB. It's very inefficient at least for creating file operations.
Proposal: We add a cuckoo filter in each inode directory and also add the related column in inode schema for the purpose of its serialization and durability. Later, prior to querying for the child's path component, the filter can be consulted to test whether the child exists. When the filter response is negative, an unnecessary DB query can be avoided. the cuckoo filter also allows deletions of keys which is good for us when a rename operation occurs.
Reference:
Cuckoo Filter: Practically Better Than Bloom, CoNEXT’14
Bin Fan, David G. Andersen, Michael Kaminsky, Michael D. Mitzenmacher

After implementing the Cuckoo filter in each INodeDirectory, FileScale will not be affected regardless of the depth of the tree.  This is cool!


.dll doesn't download (mh v7)

i used the installer, i didn't change anything, once it was done, the only thing that had downloaded was ffmpeg, the .dll was missing, I'm not very experienced with coding however is being on windows 11 the problem? as some people have said that it works for them and it may be because their on windows 10, however that's just speculation

I have mh v7 and im on windows 10, but it doesn’t work, I think that the dll is missing


ExecuteQuery parameter value should be object, not string - to allow binary and all other data type input

This is a breaking change, so change major version.

Newtonsoft somehow converts the byte[] into something different when the dataset is converted to JObject in the Task. Needs to investigate why this is happening and is there something we can do about it.


Break open the grid layout

Description
Currently the hero-header component is contained in the main of each page, but it should be fluid and full page width.
How are we going to fix this?
Can we make a system where it's possible to create components that are 100% wide.
Acceptance criteria

[ ] Components can be 100% wide.

I think we just have to let the modular-content be 100% wide, as every component in it, and then style the components seperately

Because right now the main for example is 1080px wide at max, that should not be the case


Small fix of zk rows for chunking develop

This is the develop counterpart of PR16057
I created this PR because the original PR against compatible was not passing CI (failed with merges-cleanly-into-develop).
Followed the steps in the README-branching

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

Don't merge before develop and compatible are fixed

!ci-build-me

Closing because https://github.com/MinaProtocol/mina/pull/16057 merges cleanly into develop.


Implement min/max for Index/MultiIndex

Implement min/max for Index/MultiIndex
For Index
>>> idx = ks.Index([3, 2, 1])
>>> idx.min()
1
>>> idx.max()
3

For MultiIndex
>>> idx = ks.MultiIndex.from_tuples([('a', 'x', 1), ('b', 'y', 2)])
>>> idx.min()
('a', 'x', 1)
>>> idx.max()
('b', 'y', 2)

Codecov Report

Merging #1114 into master will decrease coverage by 1.6%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
- Coverage   95.14%   93.53%   -1.61%
==========================================
  Files          35       35
  Lines        7003     7009       +6
==========================================
- Hits         6663     6556     -107
- Misses        340      453     +113

Impacted Files
Coverage Δ

databricks/koalas/missing/indexes.py
100% <ø> (ø)
:arrow_up:

databricks/koalas/indexes.py
96.49% <100%> (+0.14%)
:arrow_up:

databricks/koalas/usage_logging/__init__.py
24.32% <0%> (-72.98%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
76.59% <0%> (-8.52%)
:arrow_down:

databricks/conftest.py
92% <0%> (-6%)
:arrow_down:

databricks/koalas/frame.py
96.24% <0%> (-0.57%)
:arrow_down:

databricks/koalas/generic.py
95.76% <0%> (-0.43%)
:arrow_down:

databricks/koalas/plot.py
94.04% <0%> (-0.24%)
:arrow_down:

databricks/koalas/groupby.py
91.18% <0%> (-0.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d42c3...f781807. Read the comment docs.


Test: Instance View

Resolves #1263
Proposed Changes

Moved RoutesGrid from index.js into it's own named file RoutesGrid.js, for both JVMInstanceView and GoInstanceView

Tested:

[x]  /components
[x]  /JVMInstanceView/Scenes/Routes
[x]   /GoInstanceView/Scenes/Routes (^^ essentially the same test)

I'm waiting on testing InstanceView.js because I still need to figure out how to get around the react-loadable component.

@kaitmore Is this WIP?

@karinakeen No it's ready, you can go ahead and review :)


add 538 model's scrape and push code

resolves #1

I made one small update to round the wins to be an integer, as Zoltar only accepts integers for the wins variable.


Add Draft Dockerfile, Deployment and Workflow commands

Adds commands for Draft:

Draft Dockerfile
Draft Deployment
Draft Workflow

These can be launched from either:

The command palette; or
Another Draft webview (in this case retaining relevant selections)

An implementation note on workflow generation:
The draft generate-workflow command is not sufficiently configurable to support workflow generation comparable to Automated Deployments in the portal. Some things we need to specify that Draft does not support:

different resource groups for ACR and cluster
the location of the deployment files that's different from the repo root (for repositories containing more than one microservice)
the cluster namespace to deploy to

For this reason, the workflow generation is done in a similar way to DevHub, i.e. not using Draft at all. Instead, the template files are defined as resources in the AKS extension repository, and we use the VS Code WorkspaceEdit and DocumentSymbol APIs for performing the substitutions.
Ideally, Draft would be responsible for this, and both DevHub and this extension would use the Draft implementation. But until that happens, our implementation here provides a proof-of-concept of how we might perform other code manipulation functionality for scenarios where Draft is not the appropriate tool (for example editing/fixing existing YAML files, rather than initial creation). See baseWorkflowEditor.ts for example.
Screenshots to demonstrate UX

Signing off as I have tested the vsix and it works properly.

Signing off as I have tested the vsix and it works properly.

Yay, thanks @qpetraroia by the way will you be willing to attach all the issues which are open here in the board with open to todo status which get catered as part of this PR: https://github.com/orgs/Azure/projects/544 (I believe it will be all of them?)
It will be worth to get @hsubramanianaks for his quick eyes please, or any suggestions / observations.
Just as a thought @qpetraroia - Do you want someone from Draft team please eyeball this? (I have no preferred choice hence just bouncing back idea form you) Thanks heaps. cc: @gambtho


Suggested feature on grimfang4/SDL_FontCache#5

struct FC_Style added (used for creating font structure - it's too much to give as arguments)
FC_GetCodepoint16FromUTF8 added (simple function returns utf8 -> unicode)
use FC_GetSurface instead of TTF_RenderUTF8_Blended function
We don't use set_color_for_all_caches anymore (as border/textured font attribute makes it impossible & this will make performance better)
FC_SetFallback added.
Test cpp file was updated. you can check some new attributes easily.

Some cool stuff here!  It'll take me a while to get around to working it in.  SDL_FontCache is a C library, so I'd have to backport any C++.  I also have to be careful with SDL_Surface pixel manipulations without an explicit pixel format.

Some cool stuff here!  It'll take me a while to get around to working it in.  SDL_FontCache is a C library, so I'd have to backport any C++.  I also have to be careful with SDL_Surface pixel manipulations without an explicit pixel format.

Oh  c language was an intended one, I didn't know that. Actually It'd be no problem if you compile these files in c language right now. anyway, I hope these features can help improve this library.


JavaScript and php encoding output are inconsistent

Use JavaScript: Base62x.encode('哈')
output: 'vPE8'
But,
Use PHP: Base62x::encode('哈')->get();
output: 'vU5'
Hope to get your help, thanks

maybe not support chinese ?

I had troubleshooted into the issue and found that the point was mb_str_split funtion which is a built-in function after PHP-7.4.
The Chinese character "哈" with UTF-8 format will be split into a Character-Array as ['哈'] by mb_str_split.
However, the same Chinese character will be split into a Byte-Array as [229, 147, 136] by str_split, which is expected in src/Encoding/Base62x::encode.
We have not figured out why the author of this repo changed the function from str_split to mb_str_split.
My advice is to use str_split for byte-array, mb_str_split for character-array.
Byte is equivalent to character in ASCII, so American-European may have no sense of such issues.
In fact, one character may contains one byte, two bytes, three bytes or even more with UTF-8 charset.
The suggestion is to replace mb_str_split with str_split in src/Encoding/Base62x for test.


MSID: 97146 Version: 1 DOI: 10.1101/2<IP_ADDRESS>7545

MSID: 97146
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>7545
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=97146
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>7545

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/97146v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>7545
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/97146/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c14) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c25) has a publication-type='other'. Is that correct?


chore(vscode): remove eslint.experimental.useFlatConfig

🔗 Linked issue
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[x] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
eslint.experimental.useFlatConfig has been deprecated in vscode-eslint v3.0.5.
Flat Config is enabled by default in ESLint v9.
So I removed the option.

ref1: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint
ref2: https://eslint.org/docs/latest/use/configure/migration-guide#visual-studio-code-support

Hi @benjamincanac , thank you for always reviewing! 🔥


BrowserSync reloads but new style is 404

Laravel Mix Version: 0.8.9
Node Version (node -v): v7.7.3
NPM Version (npm -v): 4.0.5
OS: OS X 10.10.5

Description:
After any change BrowserSync reloads page but injected css can not be found so page renders un-styled. After manual reload everything works fine.
Tried removing cache busting (version()), same issue.
Everything works with versioning off.
Steps To Reproduce:
mix.js
mix.js('resources/assets/js/docs.js', 'public/js')
    .sass('resources/assets/sass/docs.scss', 'public/css')
    .version()
    .copy('resources/assets/svg', 'public/svg')
    .copy('resources/assets/fonts', 'public/fonts');

mix.browserSync({
        proxy: 'my.dev/docs'
    });

Everything works with versioning off is this how it should work? (no information about that in documentation so far)

Yeah that's to be expected. When you change a style, the stylesheet href changes, but Browsersync doesn't pick up the change.
You could always do versioning in production only.

You could always do versioning in production only.

@JeffreyWay I can't find out how to do that. Can you give me a hint? 😄

@RobertCordes
if (mix.config.inProduction) {
    mix.version()
}

Add that into your app.js file.


Can't build the binary for Sparkfun Edge Examples

I'm new to this but after following the instructions to flash the SparkFun Edge with the hello world example it can't create the binary file. After entering
make -f tensorflow/lite/micro/tools/make/Makefile TARGET=sparkfun_edge hello_world_bin
These errors appear after downloading the dependencies:
1: tensorflow/lite/micro/tools/make/downloads/gcc_embedded/bin//arm-none-eabi-g++: ELF: not found
tensorflow/lite/micro/tools/make/downloads/gcc_embedded/bin//arm-none-eabi-g++: 1: tensorflow/lite/micro/tools/make/downloads/gcc_embedded/bin//arm-none-eabi-g++: Syntax error: Unterminated quoted string
make: *** [tensorflow/lite/micro/tools/make/Makefile:300: tensorflow/lite/micro/tools/make/gen/sparkfun_edge_cortex-m4/obj/tensorflow/lite/micro/examples/hello_world/main.o] Error 2
This has also happened with the other examples. The folders are created (/tensorflow/lite/micro/tools/make/gen/sparkfun_edge_cortex-m4/obj/tensorflow/lite/micro/examples/hello_world) but not the hello_world.bin file.
Thank you.
I'm using Rapbian on Pi4

Just realised it is likely not able to run on raspberry pi (ARM) so will close.


is there a way to set the canvas size?

Hihi, as mentioned in the subject. Reason being, my page is one-pager kind with a few sections. And this 360 tour will be in one of the section. I looked through the documentation and there isn't any options for me to set the canvas and it will just take up 100% width height of the browser.
Is there a way to set the size?

Hi. You can do this by setting the height of the element that contains Marzipano with CSS. Let me know if that doesn't work.

Hi @manuelcabral , oh yes.. sorry my bad. Forgot to add position relative to the parent container.
Thanks!!


Drawing circle doesnt save geometry.

Circle is saved but geometry is blank.

Geojson does not support circle geometries.
I break the circle geometry now down into a regular polygon with 33 sides.
This can be adjusted in the circle.mjs module.

I used turf for circle geometry before.

no need. OL has most of the turf stuff built in.

i already put this in. should be fixed in current development branch.


Improves design for selection component

Description
Fixes #...
Notes (out of scope, known isues, hints for reviewing code, ...)  (optional)
Part of forms task #1406
Improves selection when narrow screen:

Test cases

[ ] Case 1:

Given I am the usual user
On screen width about 1200px
When I go to this page
Then I see the captions of selection aligned by center

Before:

After


Running a Multi-container (Spring Boot and PostgreSQL) Application with Docker Compose

Article checklist
ATTENTION: In your PR - add the ISSUE (topic form) # that this PR corresponds to. You can do this by also adding a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
If you have not already please go over our Resources Page for more tips and tricks on how to improve our overall technical writing.
Preliminary Checks - Formatting and Structure

[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines
this fixes #2737

This fixes issue #2737. I changed the title from "Getting started with Docker Compose using Spring Boot App and PostgreSQL containers" to "Running a Multi-container (Spring Boot and PostgreSQL) Application with Docker Compose"

@paulodhiambo hey, good day. Here is the article, I am looking forward to your review.

Hey @Kikiodazie 👋
Paulo has 5 articles to review, and you can't choose a peer reviewer, someone else will review this PR.
Thanks for understanding!

Hey @Kikiodazie 👋
Paulo has 5 articles to review, and you can't choose a peer reviewer, someone else will review this PR.
Thanks for understanding!

Ohhh sorry. No problem. Thanks for the clarification. Looking forward to the review.

Hey @ahmadmardeni1 good day. I am just checking up on this.

Good afternoon and thank you for submitting your article for publishing.
Your article has been entered into our queue and should be reviewed (and published pending any changes) as soon as a peer reviewer is finished with the ones in the queue before it. :rocket:
Thank you. @Kikiodazie

Thank you @ahmadmardeni1.
Thank you @Bayler Looking forward to the review.

plagiarism check done

@Kikiodazie Great article! I love the way you've explained the code in detail. Your article also has very minimal corrections. Keep up the good work. This article is now ready for final review.

@Kikiodazie Great article! I love the way you've explained the code in detail. Your article also has very minimal corrections. Keep up the good work. This article is now ready for final review.

Thanks, @Bayler. I appreciate your feedback.
And thank you for reviewing my article.

Hi @Kikiodazie
Thanks for this amazing article and keep up the amazing job.
Check my commit for more changes.
cc: @Bayler

Hi @Kikiodazie
Thanks for this amazing article and keep up the amazing job.
Check my commit for more changes.
cc: @Bayler

Thank you @LinusMuema. I appreciate this.

@LinusMuema Sorry I check the article and it seems the uploaded images aren't showing.

Let me have a look


touch should support an array of inputs

This would make asynchronously creating several files much easier.

Not a bad idea.  Patch welcome.


Check Angular server

Issue Type: Bug
Hello world !
Very good EDI, but sometimes when i try to check my server in Angular (ng serve), it's bug, hope you solve it ASAP.
Thank you
VS Code version: Code 1.29.1 (bc24f98b5f70467bc689abf41cc5550ca637088e, 2018-11-15T19:13:36.375Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU           W3550  @ 3.07GHz (8 x 3066)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: unavailable_softwarevideo_encode: enabledwebgl: enabledwebgl2: unavailable_off

Memory (System)
12.00GB (6.83GB free)

Process Argv
-n

Screen Reader
no

VM
0%

can you elaborate more on "check my server in Angular (ng serve), it's bug" ?

Sometimes in Angular, if i would like to set a command in terminal, it's appear a dark page, so i have to restart my vscode to set that command. Thank you for replying

This is Chromium not keeping the canvas texture around, you can see the minimap is also black because it uses canvas.


Avro codecs

Description
Support for nested and non-primitive data types along with test cases added.
Issues Resolved
Resolves #1532
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

closed in favour of #2715.


chore: release 1.2.276

:robot: I have created a release *beep* *boop*
1.2.276 (2023-12-29)
Bug Fixes

pre-collapsed gitlab section not usable (#5897) (68040b1)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v1.2.276 :sunflower:


It seems cross-compiling works on Apple Silicon now?

Host
Host OS: MacOS 13.5
Host CPU: arm64
zig version
0.10.1

Erlang/OTP 26 [erts-14.0.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit] [dtrace]

Elixir 1.15.4 (compiled with Erlang/OTP 26)

Target
Target OS: Alpine Linux v3.18
Target CPU: x86_64
Target LibC and Version: musl 1.2.4-r1

Hi,
I am trying to use Burrito to simplify deployments of my Elixir app. I created a default Phoenix app and added Burrito to it. The readme says that cross-compiling does not work on Apple Silicon, however, that does not seem to be the case any longer.
I tried building for Alpine Linux with Zig 0.10.1, and it seems it does work. I ran the binary on Alpine Linux v3.18 x86_64 on DigitalOcean and it seems to work.
I then tried cross-compiling for Linux x64 with glibc and MacOS x64, and they also compile successfully.
Here is the result of file burrito_out/*:
alpine:  ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped
linux:   ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.0.0, stripped
mac_arm: Mach-O 64-bit executable arm64
mac_x86: Mach-O 64-bit executable x86_64

I suppose the main reason these are compiling now on the M1 is because of the BEAM Machine static ERTS.
My question is, is it safe to now assume that cross-compiling from Apple Silicon produces the same result as compiling on the target OS directly?
And if cross-compiling now works on Apple Silicon, perhaps the readme should be updated?
Thanks!

I'm not sure this is a bug, but yes, you can cross compile from apple silicon to Linux arm/amd, mac amd, and windows amd.

Yeah sorry about the bug label. I realized it after posting and couldn't change it.
Thanks for the reply! That's great!


ut_sb_stubs.c needs a stub for CFE_SB_ZeroCopySend

Is your feature request related to a problem? Please describe.
CFE_SB_ZeroCopySend does not have a stub in ut_sb_stubs.c causing undefined reference error when building unit tests for an app that uses this call.
Describe the solution you'd like
Add the stub for CFE_SB_ZeroCopySend with full context tracking.
Describe alternatives you've considered
Create my own locally in the app's unit test, but this does not help everyone.
Requester Info
Alan Gibson, NASA

Can you contribute your implementation?

Function deprecated, replaced by CFE_SB_TransmitBuffer which has a stub.


Suggestion: Lightning subdomain

Hello,
I quite enjoy the storm druid, however some of the current domains in the game are somewhat underwhelming. I think it would be a great boost to the storm druid if they could use the lightning rod ability for a on the go empower basically.

I did try to add this back when I added the storm druid, but at the time it was beyond what I could do.
I'll have another look at some point.

Thanks for the consideration

In next update, will close ticket after I've tested and released.


docs: add sidebar link for setup

:tada: This PR is included in version 2.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix the default configuration SQLite db path

Fixes: #142

Coverage remained the same at 92.937% when pulling 5b147fb6dfc54edc989dd553f7192d8dfe5a41e1 on fix_default_conf into aff13a02fb68267895ca8beeaea6331a85e0b686 on master.

Coverage remained the same at 92.937% when pulling 5b147fb6dfc54edc989dd553f7192d8dfe5a41e1 on fix_default_conf into aff13a02fb68267895ca8beeaea6331a85e0b686 on master.


Use Yarn Policies to use a local copy of Yarn 1.19

This avoids the issue in https://github.com/thumbtack/thumbprint/issues/592 where newer versions of Yarn throw an error

Great, thanks!


Port FsLock to Rust

Fix #633

Also, one of the C++ tests fail; can you take a look, please?

Coverage increased (+0.1%) to 56.351% when pulling 515bab2183baeffb06ec8c7cc094559bca2621b1 on pickfire:fslock into d5be1e5514b296f18487275eceee6d6b94fda4fd on newsboat:master.

@pickfire, please use fixup commits (git commit --fixup=8dcad69c608b) instead of amending and force-pushing. GitHub has very poor support for force-pushes; for example, if you force-push twice in a row, it only "remembers" the last force-push, losing the diff of the first one. This means that i have to re-read the whole PR and figure out myself what lines got edited — GItHub doesn't show me a diff anymore.
CI is partially green now, but a few jobs failed. Can you take a look at them, please?

I think I need to give some context to my comments on this PR, so let me explain what I'm pushing for, and why.
We have a C++ application, but we want it to be in Rust. To get there, we take a gradual approach, rewriting one small function or a class at a time. Each thing is rewritten in a pretty conservative fashion — we follow the existing algorithm, but use Rust's niceties where it makes sense. For example, a lot of utility functions use functional-style chained calls where C++ used loops. The result might not be idiomatic Rust, but it's Rust.
We made a decision early on to keep the Rust FFI stuff in a separate crate, and as a result, our main crate contains just a few unsafe blocks and unwrap calls (not counting tests where unwraps are totally okay). We use unwraps where it would be a logical error to have None/Err, and we use unsafe when something absolutely can't be done in safe Rust. Here's an exhaustive list of unsafe blocks as of 73572d8335652759c0f21a1d30f6916fd23d67d2:

a call to getuid() in ConfigPaths module, as safe Rust doesn't provide a way to find out current user's ID;
calls to regerror() (and a callsite for that unsafe wrapper function), regcomp(), regexec(), and regfree() in regex-rs crate, which is a safe wrapper around these C APIs. We can't replace it with safe Rust because nothing in safe Rust provides POSIX regular expressions;
a call to snprintf() in strprintf crate, which is a safe wrapper for that C function. We have to use the C function because we want to have the same results both in Rust and C++, and that's what C++ uses for formatting. We can't replace this with FFI calls into C++ because strprintf takes variable number of arguments, which can't be passed over FFI without literally writing our own varargs implementation.

rust/libnewsboat/src/fslock.rs deviates from all of this, and thus rubs me the wrong way. It keeps using unsafe for file operations that can be done in safe Rust; unsafe drags in a few unwrap calls for conversions as well. To be in line with the rest of our Rust code, this module should only use unsafe around the lockf() call, and replace everything else with safe Rust.
We can postpone a lot of things, but we can't postpone the move to safe Rust. Without that move, rewriting simply makes no sense. It can't happen later, because it's already happening now.

Oh, one more thing: I'm okay with one more force-push if it fixes the typo in the commit message :) I believe it should say "Port", not "Part".

Oh, one more thing: I'm okay with one more force-push if it fixes the typo in the commit message :) I believe it should say "Port", not "Part".

Yup, fixed that. Didn't notice it.

@Minoru CARGO_BIN_EXE-xxx is not available in rust 1.40.0, do we need to bump the minimum version?

We bump minimum supported Rust version on a schedule, so we can't do it right now. Apparently CARGO_BIN_EXE_xxx only became available in 1.43.0, so according to our schedule, we can't use this env var until December 2020.
The PR that added this env var mentions "inspecfing env::current_exe()". Can you look into those workarounds, @pickfire?

The PR that added this env var mentions "inspecfing env::current_exe()". Can you look into those workarounds, @pickfire?

I don't think getting a hack around that is a good idea, maybe we just set a reminder for this PR to merge on December since the C++ parts and this Rust part is very unlikely to change?

FSLock might change because of #314. Also, lilbnewsboat and libnewsboat-ffi will definitely change, e.g. we might split them into separate crates. By then, we might even start porting Controller to Rust, and having FSLock still in C++ would require us to write Rust->C++ bindings.
I understand you might be exhausted by all the revisions on this PR, so I'll let you off the hook for now :) Let's wait until either December, or someone implementing the workaround.

Oh, almost forgot: thanks for working on this, @pickfire! I'm really happy to see how a pretty low-level C++ with a lot of C calls turned into a nice, pretty Rust.

@Minoru Thanks a lot for showing me some of those functions I didn't know available in safe rust, I didn't know they exists but I should have the the documentation more next time. I did learned a lot while helping out.

https://github.com/rust-lang/rust/issues/71668
@Minoru we may need to add the unsafe in unsafe function later.

Oh, that's interesting! Thanks for the link, @pickfire. I think we'll decide how to deal with this when this change is actually released :)

Apparently CARGO_BIN_EXE_xxx only became available in 1.43.0, so according to our schedule, we can't use this env var until December 2020.

I misread my own schedule :) The correct date is: September 2020. So three more months until we can merge this.

Merged via #1075.


fix webhook: set a default workload.type for componentdefinition which doesn't refer to a workload

refer to https://github.com/oam-dev/kubevela/pull/1680#discussion_r634808401
The validating logic of the componentdeifnition webhook will reject if the componentDefinition doesn't refer to a workload.
Now we will set a default workloaddefinition autodetect.core.oam.dev for the componentDefinition.

please make sure the helm component still works if users don't fill any workload definition info \cc @captainroy-hy

That may cause a problem if the workload type ref is not a valid resource registered in API-server. In the stage where App controller checks whether a workload raw is cluster-scope or namespace-scope, discovermapper will return an error if it's an unknown resource to API-server.

@captainroy-hy  do we have any solution? That we just need to deploy successfully without any traits

@captainroy-hy do we have any solution? That we just need to deploy successfully without any traits

@wonderflow Yes, minor changes can help. During app controller apply, we can skip several steps and just keep applying helm resources. I would like to work with @yangsoon to fix that.

@captainroy-hy do we have any solution? That we just need to deploy successfully without any traits

@wonderflow Yes, minor changes can help. During app controller apply, we can skip several steps and just keep applying helm resources. I would like to work with @yangsoon to fix that.

very appreciate for that

With the help of @captainroy-hy , I fix part of the controller logic, please \cc @captainroy-hy


Issues with python-Levenshtein on OSX[we think]

Building projects which require python-Levenshtein on OSX causes issues.  When doing the same thing on a Debian system it works fine.
File "/var/task/Levenshtein/__init__.py", line 1, in <module>
   from Levenshtein import _levenshtein
ImportError: cannot import name '_levenshtein'

Context
Python 3.6
Zappa versions 0.44 and 0.43
OSX 10.11.6
Expected Behavior
Should be able to import Levenshtein into the project.  This error can be reproduced by having
Actual Behavior
Import error but only on OSX.
Way to replicate

add python-Levenshtein to requirements and install
zappa deploy/update
zappa invoke "import Levenshtein"
See failure on OSX but not Linux

Your Environment
Zappa versions 0.44 and 0.43
OSX 10.11.6

The output of pip freeze:
amqp==2.1.4
appnope==0.1.0
argcomplete==1.8.2
asn1crypto==0.23.0
awscli==1.11.160
base58==0.2.4
behave==1.2.5
behave-django==0.5.0
billiard==<IP_ADDRESS>
boto==2.48.0
boto3==1.4.5
botocore==1.5.40
celery==4.1.0
certifi==2<IP_ADDRESS>
cffi==1.11.0
chardet==3.0.4
click==6.7
colorama==0.3.7
cryptography==2.0.3
decorator==4.1.2
defusedxml==0.5.0
dj-database-url==0.4.2
Django==1.10.8
django-allauth==0.32.0
django-appconf==1.0.2
django-compressor==2.1.1
django-debug-toolbar==1.4
-e git://github.com/rossettistone/django-easy-audit.git@bf6c070e134fd557ffad0779b4b856afb555cf71#egg=django_easy_audit
django-extensions==1.9.1
-e git://github.com/bee-keeper/django-invitations@173524d7c462fbd6193421f67009f3d394c1a232#egg=django_invitations
django-jinja==2.4.0
django-storages==1.6.5
django-taggit==0.22.1
django-url-robots==2.0
djangorestframework==3.6.4
docutils==0.14
durationpy==0.5
factory-boy==2.9.2
fake-factory==0.7.2
Faker==0.8.4
future==0.16.0
futures==3.1.1
gunicorn==19.7.1
hjson==3.0.0
idna==2.6
ipdb==0.10.3
ipython==5.5.0
ipython-genutils==0.2.0
Jinja2==2.9.6
jmespath==0.9.3
kappa==0.6.0
kombu==4.1.0
lambda-packages==0.16.1
MarkupSafe==1.0
mixpanel==4.3.2
newrelic==<IP_ADDRESS>
oauthlib==2.0.4
olefile==0.44
parse==1.8.2
parse-type==0.4.2
pexpect==4.2.1
phonenumbers==8.8.0
pickleshare==0.7.4
Pillow==4.2.1
placebo==0.8.1
prompt-toolkit==1.0.15
psycopg2==<IP_ADDRESS>
ptyprocess==0.5.2
pyasn1==0.3.6
pycparser==2.18
Pygments==2.2.0
PyJWT==1.5.3
pyOpenSSL==17.3.0
PySocks==1.6.7
python-dateutil==2.6.1
python-http-client==1.2.3
python-Levenshtein==0.12.0
python-slugify==1.2.4
python3-openid==3.1.0
pytz==2016.10
PyYAML==3.12
rcssmin==1.0.6
reportlab==3.4.0
requests==2.18.4
requests-oauthlib==0.8.0
rjsmin==1.0.12
rsa==3.4.2
s3transfer==0.1.11
sendgrid==2.2.1
sendgrid-django==2.0.0
simplegeneric==0.8.1
six==1.10.0
smtpapi==0.3.1
sqlparse==0.2.3
toml==0.9.2
tqdm==4.15.0
traitlets==4.3.2
troposphere==1.9.6
twilio==6.1.0
ua-parser==0.7.3
Unidecode==0.4.21
urllib3==1.22
user-agents==1.1.0
vine==1.1.4
wcwidth==0.1.7
Werkzeug==0.12
whitenoise==3.3.1
wsgi-request-logger==0.4.6
zappa==0.43.2

Your zappa_settings.py:

{
    "development": {
        "aws_region": "us-east-1",
        "django_settings": "project.settings.development",
        "profile_name": "default",
        "s3_bucket": "cmr-development2-zappa",
	"environment_variables": {
	    "SECRET_KEY" :"secret key",
	    "TEST_USER_PASSWORD": "secret",
	    "DATABASE_HOST": "",
	    "DATABASE_PASSWORD": "",
	    "PURGED_DATABASE_HOST": "",
	    "PURGED_DATABASE_PASSWORD": "",
	    "AWS_ID": "",
	    "AWS_SECRET": "",
	    "BUCKET_NAME": ""
	}
    }
}

So it is in https://github.com/Miserlou/lambda-packages but when I run package it only its not listed during
Downloading and installing dependencies..
 - reportlab==3.4.0: Using locally cached manylinux wheel
 - psycopg2==<IP_ADDRESS>: Using locally cached manylinux wheel
 - pillow==4.2.1: Using locally cached manylinux wheel
 - cryptography==2.0.3: Using locally cached manylinux wheel
 - cffi==1.10.0: Using locally cached manylinux wheel

So I think it just happens to work on Debian using the normal package but the OSX package isn't compatible.
Is the python-Levenshtein package 2.7 only?

Yes, you can see which packages are Py3-ready in the lambda-packages
manifest:
https://github.com/Miserlou/lambda-packages/blob/master/lambda_packages/__init__.py
On Wed, Sep 27, 2017 at 5:25 AM, Mikela<EMAIL_ADDRESS>wrote:

So it is in https://github.com/Miserlou/lambda-packages but when I run
package it only its not listed during
Downloading and installing dependencies..

reportlab==3.4.0: Using locally cached manylinux wheel
psycopg2==<IP_ADDRESS>: Using locally cached manylinux wheel
pillow==4.2.1: Using locally cached manylinux wheel
cryptography==2.0.3: Using locally cached manylinux wheel
cffi==1.10.0: Using locally cached manylinux wheel

So I think it just happens to work on Debian using the normal package but
the OSX package isn't compatible.
Is the python-Levenshtein package 2.7 only?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Miserlou/Zappa/issues/1132#issuecomment-332398259,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIi0weGs6dNjfyHW6tSI1e8nbmR5kxmks5smcA8gaJpZM4PlCh4
.

Also, just out of curiosity - why that package? I've never used it before but it seems like a popular one? Geo/GIS-related?

I actually don't know.  Looking at the code is has something to do with calculating how much of something someone read is.
The init file was the last piece for my understanding.  I have it working on lambda with the compiled build I have.  Should I try making a tar ball and doing a PR?

So looking at the __init__ file psycopg2 is only listed with python2.7 but when it builds the package it still includes psycopg2 in list of dependencies.
I'm curious if I get Levenshtein working with lambda_packages will it then fail for psycopg2 on OSX because it will use the OSX binary?
Mainly trying to gauge how many packages I'll need to do.


Pylance fails to produce type hints on custom dataclass

Environment data

Language Server version: v2021.9.1
OS and version: Windows 10, latest
Python version (& distribution if applicable, e.g. Anaconda): Anaconda, Python 3.9.5

Expected behaviour
Mimic Jedi's behavior here:

Actual behaviour

Logs

[Info  - 10:34:45 PM] Pylance language server 2021.9.1 (pyright e804f324) starting
[Info  - 10:34:45 PM] Server root directory: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist
[Info  - 10:34:45 PM] No configuration file found.
[Info  - 10:34:45 PM] pyproject.toml file found at e:\Public\Workspace\app.
[Info  - 10:34:45 PM] Setting pythonPath for service "app": "C:\ProgramData\Anaconda3\envs\app\python.exe"
[Info  - 10:34:45 PM] Loading pyproject.toml file at e:\Public\Workspace\app\pyproject.toml
[Error - 10:34:45 PM] Pyproject file "e:\Public\Workspace\app\pyproject.toml" is missing "[tool.pyright] section.
[Warn  - 10:34:45 PM] stubPath e:\Public\Workspace\app\typings is not a valid directory.
[Info  - 10:34:45 PM] Assuming Python version 3.9
[Info  - 10:34:45 PM] Assuming Python platform Windows
Search paths for e:\Public\Workspace\app
  c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib
  e:\Public\Workspace\app
  e:\Public\Workspace\app\typings
  c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stubs\...
  c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\bundled\stubs
  c:\ProgramData\Anaconda3\envs\app\DLLs
  c:\ProgramData\Anaconda3\envs\app\Lib
  c:\ProgramData\Anaconda3\envs\app
  c:\ProgramData\Anaconda3\envs\app\Lib\site-packages
[Info  - 10:34:45 PM] Searching for source files
[Info  - 10:34:45 PM] Auto-excluding e:\Public\Workspace\app\.tox\build
[Info  - 10:34:45 PM] Auto-excluding e:\Public\Workspace\app\.tox\py39
[Info  - 10:34:45 PM] Found 13 source files
[Info  - 10:34:45 PM] Background analysis(1) root directory: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist
[Info  - 10:34:45 PM] Background analysis(1) started
Background analysis message: setConfigOptions
Background analysis message: setImportResolver
Background analysis message: ensurePartialStubPackages
Background analysis message: setTrackedFiles
Background analysis message: markAllFilesDirty
Background analysis message: setFileOpened
Background analysis message: getSemanticTokens full
[BG(1)] getSemanticTokens full at e:\Public\Workspace\app\tests\test_request.py ...
[BG(1)]   parsing: e:\Public\Workspace\app\tests\test_request.py (65ms)
[BG(1)]   parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\builtins.pyi [fs read 2ms] (73ms)
[BG(1)]   binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\builtins.pyi (29ms)
[BG(1)]   binding: e:\Public\Workspace\app\tests\test_request.py (7ms)
[BG(1)]   parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\typing.pyi [fs read 1ms] (26ms)
[BG(1)]   binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\typing.pyi (8ms)
[BG(1)]   parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\_typeshed\__init__.pyi [fs read 0ms] (5ms)
[BG(1)]   binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\_typeshed\__init__.pyi (1ms)
[BG(1)]   parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\typing_extensions.pyi [fs read 0ms] (2ms)
[BG(1)]   binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\typing_extensions.pyi (2ms)
[BG(1)]   parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\__init__.pyi [fs read 1ms] (4ms)
[BG(1)]   binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\__init__.pyi ...
[BG(1)]     parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\async_case.pyi [fs read 0ms] (0ms)
[BG(1)]     binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\async_case.pyi (0ms)
[BG(1)]     parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\loader.pyi [fs read 0ms] (1ms)
[BG(1)]     binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\loader.pyi (1ms)
[BG(1)]     parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\main.pyi [fs read 0ms] (1ms)
[BG(1)]     binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\main.pyi (0ms)
[BG(1)]     parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\runner.pyi [fs read 0ms] (1ms)
[BG(1)]     binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\runner.pyi (0ms)
[BG(1)]     parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\signals.pyi [fs read 0ms] (1ms)
[BG(1)]     binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\signals.pyi (0ms)
[BG(1)]     parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\suite.pyi [fs read 0ms] (0ms)
[BG(1)]     binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\suite.pyi (0ms)
[BG(1)]   binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\__init__.pyi (7ms)
[BG(1)]   parsing: e:\Public\Workspace\app\app\__init__.py [fs read 1ms] (2ms)
[BG(1)]   binding: e:\Public\Workspace\app\app\__init__.py (0ms)
[BG(1)]   parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\case.pyi [fs read 1ms] (11ms)
[BG(1)]   binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\unittest\case.pyi (4ms)
[BG(1)]   parsing: e:\Public\Workspace\app\app\request.py [fs read 0ms] (26ms)
[BG(1)]   binding: e:\Public\Workspace\app\app\request.py (7ms)
[BG(1)]   parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\reprlib.pyi [fs read 1ms] (2ms)
[BG(1)]   binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\reprlib.pyi (0ms)
[BG(1)]   parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\dataclasses.pyi [fs read 0ms] (4ms)
[BG(1)]   binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\dataclasses.pyi (1ms)
[BG(1)] getSemanticTokens full at e:\Public\Workspace\app\tests\test_request.py (634ms)
Background analysis message: analyze
[BG(1)] analyzing: e:\Public\Workspace\app\tests\test_request.py ...
[BG(1)]   checking: e:\Public\Workspace\app\tests\test_request.py (14ms)
[BG(1)] analyzing: e:\Public\Workspace\app\tests\test_request.py (14ms)
Background analysis message: resumeAnalysis
Background analysis message: getDiagnosticsForRange
Background analysis message: getDiagnosticsForRange
[FG] parsing: e:\Public\Workspace\app\tests\test_request.py (69ms)
[FG] parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\builtins.pyi [fs read 1ms] (84ms)
[FG] binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\builtins.pyi (30ms)
[FG] binding: e:\Public\Workspace\app\tests\test_request.py (7ms)
Background analysis message: getDiagnosticsForRange
Background analysis message: getDiagnosticsForRange
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
Background analysis message: getSemanticTokens delta
[BG(1)] getSemanticTokens delta previousResultId:1631244885749 at e:\Public\Workspace\app\tests\test_request.py ...
[BG(1)]   parsing: e:\Public\Workspace\app\tests\test_request.py (27ms)
[BG(1)]   binding: e:\Public\Workspace\app\tests\test_request.py (5ms)
[FG] parsing: e:\Public\Workspace\app\tests\test_request.py (34ms)
[FG] binding: e:\Public\Workspace\app\tests\test_request.py (3ms)
[BG(1)] getSemanticTokens delta previousResultId:1631244885749 at e:\Public\Workspace\app\tests\test_request.py (284ms)
Background analysis message: analyze
[BG(1)] analyzing: e:\Public\Workspace\app\tests\test_request.py ...
[BG(1)]   checking: e:\Public\Workspace\app\tests\test_request.py (12ms)
[BG(1)] analyzing: e:\Public\Workspace\app\tests\test_request.py (12ms)
Background analysis message: getDiagnosticsForRange
Background analysis message: resumeAnalysis
Background analysis message: getDiagnosticsForRange
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
[FG] parsing: e:\Public\Workspace\app\tests\test_request.py (11ms)
[FG] binding: e:\Public\Workspace\app\tests\test_request.py (3ms)
[FG] parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\typing.pyi [fs read 0ms] (10ms)
[FG] binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\typing.pyi (10ms)
[FG] parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\_typeshed\__init__.pyi [fs read 0ms] (4ms)
[FG] binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\_typeshed\__init__.pyi (1ms)
[FG] parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\typing_extensions.pyi [fs read 1ms] (2ms)
[FG] binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\typing_extensions.pyi (0ms)
[FG] parsing: e:\Public\Workspace\app\app\__init__.py [fs read 1ms] (2ms)
[FG] binding: e:\Public\Workspace\app\app\__init__.py (0ms)
[FG] parsing: e:\Public\Workspace\app\app\request.py [fs read 0ms] (22ms)
[FG] binding: e:\Public\Workspace\app\app\request.py (8ms)
[FG] parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\reprlib.pyi [fs read 1ms] (2ms)
[FG] binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\reprlib.pyi (0ms)
[FG] parsing: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\dataclasses.pyi [fs read 0ms] (4ms)
[FG] binding: c:\Users\user\.vscode\extensions\ms-python.vscode-pylance-2021.9.1\dist\typeshed-fallback\stdlib\dataclasses.pyi (1ms)
Background analysis message: getDiagnosticsForRange
Background analysis message: getDiagnosticsForRange
Background analysis message: getSemanticTokens delta
[BG(1)] getSemanticTokens delta previousResultId:1631244894754 at e:\Public\Workspace\app\tests\test_request.py ...
[BG(1)]   parsing: e:\Public\Workspace\app\tests\test_request.py (13ms)
[BG(1)]   binding: e:\Public\Workspace\app\tests\test_request.py (2ms)
[BG(1)] getSemanticTokens delta previousResultId:1631244894754 at e:\Public\Workspace\app\tests\test_request.py (186ms)
Background analysis message: analyze
[BG(1)] analyzing: e:\Public\Workspace\app\tests\test_request.py ...
[BG(1)]   checking: e:\Public\Workspace\app\tests\test_request.py (5ms)
[BG(1)] analyzing: e:\Public\Workspace\app\tests\test_request.py (5ms)
Background analysis message: resumeAnalysis
Background analysis message: markFilesDirty
Background analysis message: analyze

Code Snippet / Additional information

I'm wrapping this class (among many others) in a custom dataclass wrapper seen below. When I switch to the default dataclass wrapper provided in the dataclasses module, this works just fine. However, Jedi is not affected.
import reprlib
from dataclasses import dataclass as _dataclass
from typing import Literal

# The wrapper fn in question
def dataclass(
    cls=None,
    /, *,
    init=True,
    repr=False,
    eq=True,
    order=False,
    unsafe_hash=False,
    frozen=False
):
    wrapped_cls = _dataclass(
        cls,
        init=init,
        repr=repr,
        eq=eq,
        order=order,
        unsafe_hash=unsafe_hash,
        frozen=frozen
    )

    # We implement a custom repr to print 'InitVar' attributes
    reprlib.aRepr.maxother = 128

    @reprlib.recursive_repr()
    def __repr__(self) -> str:
        ret = '<{klass}({attrs})>'
        attrs = []
        for k, v in self.__dict__.items():
            attrs.append(f"{k}={reprlib.repr(v)}")

        return ret.format(klass=self.__class__.__name__, attrs=", ".join(attrs))

    wrapped_cls.__repr__ = __repr__

    return wrapped_cls
dataclass.__doc__ = _dataclass.__doc__  # noqa: E305

# The example class from above
# Note: Change '@dataclass' to '@_dataclass' to 're-enable' the expected behavior
@dataclass
class ReferenceApiExchangesV3Request:
    _path = '/v3/reference/exchanges'

    asset_class: Literal['', 'stocks', 'options', 'crypto', 'fx'] = ''
    locale: Literal['', 'us', 'global'] = ''

Pyright (the type checker that underlies pylance) handles dataclass, but it requires that you call it directly, not indirectly. This is required because dataclass transforms the original class, and the values of some arguments affects the way the transform works. These values of these arguments need to be evaluated statically, so they need to be literal booleans True or False, not dynamic expressions whose values can change at runtime.
If it's not feasible to use dataclass directly and you want to stick with your custom wrapper, you could use the dataclass_transform mechanism supported in pyright. To do this, you would add the following to your code:
_T = TypeVar("_T")

def __dataclass_transform__(
    *,
    eq_default: bool = True,
    order_default: bool = False,
    kw_only_default: bool = False,
    field_descriptors: Tuple[Union[type, Callable[..., Any]], ...] = (()),
) -> Callable[[_T], _T]:
    return lambda a: a

@__dataclass_transform__(field_descriptors=(field, ))
def custom_dataclass_wraper ...

Ah, I see. Thank you very much for the explanation.
I assume field in @__dataclass_transform__(field_descriptors=(field, )) is dataclasses.field?

Yes, that's correct.

I recommend editing builtins.pyi in pylance's typeshed-fallback.
It is in ${HOME_DIRECTORY}/.vscode/extenstions/ms-python.vscode-pylance-xxxx/dist/typeshed-fallback/stdlib/builtins.pyi
I added import statement my custom module which have type hints and custom functions.
from custom_module import *  #Added
import sys
import types

It works fine.

@kskyj, I recommend against modifying builtins.pyi in pylance's typeshed-fallback. Any changes there will be lost when the next version of pylance is released, in one week or less.

@erictraut,  Oh, The Pylance updates it frequently. Thank you for the information. 👍
Is there any easier way other than the dataclass_transform mechanism? :)

@kskyj, I don't have enough context about what you're trying to do. You may want to open a question in the discussion forum that provides more details.


language-puppet-1.1.1 can't compile its test suite

We get the following errors in NixOS trying to build with GHC 7.10.1:
Preprocessing test suite 'test-puppetdb' for language-puppet-1.1.1...
[1 of 1] Compiling Main             ( tests/puppetdb.hs, dist/build/test-puppetdb/test-puppetdb-tmp/Main.dyn_o )

tests/puppetdb.hs:31:5:
    Couldn't match type ‘either-<IP_ADDRESS>:Control.Monad.Trans.Either.EitherT
                           PrettyError IO’
                   with ‘IO’
    Expected type: IO ()
      Actual type: either-<IP_ADDRESS>:Control.Monad.Trans.Either.EitherT
                     PrettyError IO ()
    In the first argument of ‘(>>=)’, namely
      ‘replaceFacts pdb [(ndname, nfacts)]’
    In a stmt of a 'do' block:
      replaceFacts pdb [(ndname, nfacts)] >>= checkError "replaceFacts"

tests/puppetdb.hs:31:45:
    Couldn't match type ‘()’ with ‘S.Either x0 a0’
    Expected type: () -> IO a0
      Actual type: S.Either x0 a0 -> IO a0
    In the second argument of ‘(>>=)’, namely
      ‘checkError "replaceFacts"’
    In a stmt of a 'do' block:
      replaceFacts pdb [(ndname, nfacts)] >>= checkError "replaceFacts"

tests/puppetdb.hs:32:5:
    Couldn't match type ‘either-<IP_ADDRESS>:Control.Monad.Trans.Either.EitherT
                           PrettyError IO’
                   with ‘IO’
    Expected type: IO ()
      Actual type: either-<IP_ADDRESS>:Control.Monad.Trans.Either.EitherT
                     PrettyError IO ()
    In the first argument of ‘(>>=)’, namely ‘commitDB pdb’
    In a stmt of a 'do' block: commitDB pdb >>= checkError "commitDB"

tests/puppetdb.hs:32:22:
    Couldn't match type ‘()’ with ‘S.Either x1 a1’
    Expected type: () -> IO a1
      Actual type: S.Either x1 a1 -> IO a1
    In the second argument of ‘(>>=)’, namely ‘checkError "commitDB"’
    In a stmt of a 'do' block: commitDB pdb >>= checkError "commitDB"

tests/puppetdb.hs:40:5:
    Couldn't match type ‘either-<IP_ADDRESS>:Control.Monad.Trans.Either.EitherT
                           PrettyError IO’
                   with ‘IO’
    Expected type: IO ()
      Actual type: either-<IP_ADDRESS>:Control.Monad.Trans.Either.EitherT
                     PrettyError IO ()
    In the first argument of ‘(>>=)’, namely
      ‘replaceCatalog fpdb (generateWireCatalog ndname mempty mempty)’
    In a stmt of a 'do' block:
      replaceCatalog fpdb (generateWireCatalog ndname mempty mempty)
      >>= checkError "replaceCatalog"

tests/puppetdb.hs:40:72:
    Couldn't match type ‘()’ with ‘S.Either x2 a2’
    Expected type: () -> IO a2
      Actual type: S.Either x2 a2 -> IO a2
    In the second argument of ‘(>>=)’, namely
      ‘checkError "replaceCatalog"’
    In a stmt of a 'do' block:
      replaceCatalog fpdb (generateWireCatalog ndname mempty mempty)
      >>= checkError "replaceCatalog"

tests/puppetdb.hs:41:5:
    Couldn't match type ‘either-<IP_ADDRESS>:Control.Monad.Trans.Either.EitherT
                           PrettyError IO’
                   with ‘IO’
    Expected type: IO ()
      Actual type: either-<IP_ADDRESS>:Control.Monad.Trans.Either.EitherT
                     PrettyError IO ()
    In the first argument of ‘(>>=)’, namely ‘commitDB fpdb’
    In a stmt of a 'do' block: commitDB fpdb >>= checkError "commit 2"

tests/puppetdb.hs:41:23:
    Couldn't match type ‘()’ with ‘S.Either x3 a3’
    Expected type: () -> IO a3
      Actual type: S.Either x3 a3 -> IO a3
    In the second argument of ‘(>>=)’, namely ‘checkError "commit 2"’
    In a stmt of a 'do' block: commitDB fpdb >>= checkError "commit 2"

I fixed the tests in <IP_ADDRESS>


Fix #208 : Added Toast for Server Down

Fixes #208

[x] Apply the AndroidStyle.xml style template to your code in Android Studio.

[x] Run the unit tests with ./gradlew check to make sure you didn't break anything

[x] If you have multiple commits please combine them into one commit by squashing them.

@therajanmaurya I have improved the PR. Please review it again.


Pr camera capture driver

This pr replaces https://github.com/PX4/Firmware/pull/10295 because support was added also for the av-x board that currently doesn't have timer input capture available, therefore we are using gpio captures. This is not ideal but the goal is to get this merged and then do a second iteration where we add timer capture support for the av-x board.

From previous pr:
This PR adds the camera capture driver. This can be used to receive a feedback from a camera after it is triggered (eg. sony hot shoe feedback). In this case we don't publish the camera_trigger message in the camera_trigger driver when we trigger the camera, but we publish when we receive the feedback from the camera. When geotagging images this will increase the presision in the geotag.
This can be also used to sync CV cameras with the IMU data for VIO or similar applications.
Currently only channel 5 on the FMU PWM outputs can be used for this driver. I still need to check on which outputs we can actually run this.
Some more tests will be done in the next days.
Params for testing:
CAM_CAP_FBACK = 1 (enable camera capture)
CAM_CAP_MODE =
0 (get edge timestamp)
1 (get pulse midpoint timestamp for active high triggers)
2 (get pulse midpoint timestamp for active low triggers)
CAM_CAP_EDGE =
0 (trigger on falling edge)
1 (trigger on rising edge)
CAM_CAP_DELAY --> delay between image integration start and strobe firing (default to 0)

@dagar this was tested yesterday on the av-x board and on a pixhawk 4.

There are some minor things, but this looks safe to merge and we've been sitting on it for way too long. I'll merge now and we can continue from master.

@DanielePettenuzzo I'm looking at this again--so for I've built what's on master and completed a basic test it seems to work.  It looks like the autopilot should publish a camera_capture message in response to the pulse.  How do you access that message? If I run mavros the only related message I see published is the cam_imu_stamp message.  I will also try to help out with the docs so this can get pushed into a release.

I guess just to be clear, it looks like the camera_capture driver publishes the camera_trigger message which the camera_feedback module subscribes to and then looks like it should publish the camera_capture message.  Couple things I see:

the camera_feedback module doesn't run by default.
from the mavlink console in qgroundcontrol I can start it but even when I do the camera_capture message doesn't appear to be getting published.  (It doesn't show up on uorb top)

I have a quick question and it seems like the most likely place to get the answer.
Why in the following section, only one input capture is defined? what happens of the otherone?
https://github.com/PX4/Firmware/blob/dcfe226638c8d50a42f30c1c50f8c5ca4a000060/src/drivers/px4fmu/fmu.cpp#L358-L370

@AlexandreBorowczyk  - It is a mistake. There needs to be a
`up_input_capture_set(6, Rising, 0, NULL, NULL);`

added.

Alright Thanks for clearing things up!

Will this have a document? @hamishwillee

@bys1123 One can only hope that @DanielePettenuzzo will find time. I've got a placeholder for it: https://github.com/PX4/px4_user_guide/issues/604


Inconsistency, NaT included in result of groupby method first but not NaN

NaT is included in result of groupby method first while NaN. I am expecting that  first should skip both NaN and NaT and include the first value where pandas.isnull is False.
Demonstration of the inconsistency. (note that both NaT and NaN in the data frame are produced by np.nan, the difference is that the d_t column contains date values).
import numpy as np
import pandas as pd
from datetime import datetime as dt

testFrame=DataFrame({'IX':['A','A'],'num':[np.nan,100],'datetime':[np.nan,dt.now()]})

Resulting data frame:
  IX                     d_t  num
0  A                     NaT  NaN
1  A 2015-07-15 22:47:10.635  100

Grouping this data frame on the IX column and executing the first method results in this data frame which shows the inconsistency between the d_t and num columns.
testFrame.groupby('IX').first()

Resulting dataframe:
        d_t  num
IX
A       NaT  100

INSTALLED VERSIONS
------------------
commit: None
python: 2.7.9.final.0
python-bits: 64
OS: Windows
OS-release: 7
machine: AMD64
processor: Intel64 Family 6 Model 58 Stepping 9, GenuineIntel
byteorder: little
LC_ALL: None
LANG: None

pandas: 0.16.2
nose: 1.3.4
Cython: 0.22
numpy: 1.9.2
scipy: 0.15.1
statsmodels: 0.6.1
IPython: 3.0.0
sphinx: 1.2.3
patsy: 0.3.0
dateutil: 2.4.2
pytz: 2015.4
bottleneck: None
tables: 3.1.1
numexpr: 2.3.1
matplotlib: 1.4.3
openpyxl: 1.8.5
xlrd: 0.9.3
xlwt: 0.7.5
xlsxwriter: 0.6.7
lxml: 3.4.2
bs4: 4.3.2
html5lib: 0.999
httplib2: None
apiclient: None
sqlalchemy: 0.9.9
pymysql: None
psycopg2: None

hmm, @sinhrks I thought this was fixed?

I remember some issues when NaT is in group key, but not aware the aggregation issure. .min might be affected also.

prob needs some adjustment for comparison vs iNaT in the first/last (though i thought it was there)

Confirmed .min also affected. @larvian PR is appreciated:)
testFrame.groupby('IX').min()
#    d_t  num
# IX
# A  NaT  100

@sinhrks :) I see. Well, I have started to research GitHub and the Pandas source code a bit but right now I unfortunately don't have very much time available and waiting for me could require patience.
If I come to the point when I feel confident that I can contribute to the solution then I will do a PR. If someone else does it I am OK with that too :)


Add QuadrupedAnimalsWithPawsAndTails.xml

Attach file with quadruped animals with paws and tails from animal gear mod
dog utility quadruped animal with paws and tail.txt

 Issues from GitHub project.

 progress review and code

I have reopened the issue, because I'm not really sure if this file will make sure that only the husky, yorkie and Labrador can wear the dog apparel.