Read all file content and continue tailing

I've got a log file that is continuously updated. I want to read the entire file content that exists at the moment and continue with tail -f of this file. Which configuration do I need to do so?
tail.Config{
			Follow:      true,
			MustExist:   true,
			Location: &tail.SeekInfo{
				Offset: 0,
				Whence: io.SeekStart,
			},
			Logger: tail.DiscardingLogger,
			MaxLineSize: 160,
		}

Resolved

	t, err := tail.TailFile(logFile, tail.Config{
		Location: &tail.SeekInfo{
			Offset: 0,
			Whence: os.SEEK_END,
		},
		Follow: true,
	})

I also set ReOpen to true. I'm not sure if that applies to your use case.
tail.Config{Follow: true, ReOpen: true, Location: &tail.SeekInfo{Offset: 0, Whence: io.SeekEnd}})


ImportError: cannot import name timezone

I tried pip install datetime and pip3 install datetime and am still getting the error.

Do you get this error when installing it from pypi (e.g. pip3 install wayback-machine-scraper)? You shouldn't have to install any dependencies manually, but you will need to use pip3 to install it if your default pip is tied to Python 2.

Let me know if you're stilling still having this issue and I'll reopen it.


[stdlib] _Builtin_float: More availability adjustments

Explanation: This resolves issues uncovered since #74367 has landed, unblocking swift.org toolchain builds.
Scope: Standard Library (_Builtin_float module).
Risk: Low.
Testing: Regular PR testing, incl. toolchain builds.
Reviewer: tbd
Original PR: #74486
Issue: Word of mouth

@swift-ci test

@swift-ci build toolchain


cannot make axon-amqp work with spring-boot-starter-web

Hello,
I can not make axon-amqp work with spring boot module spring-boot-starter-web.
my application.yml:
spring:
  application:
    name: axon-test-consumer
  rabbitmq:
    host: rabbitmq.staging.ouialgo.com
    username: ${RABBITMQ_USERNAME}
    password: ${RABBITMQ_PASSWORD}
    listener:
      simple:
        acknowledgMode: none

server:
  port: ${SERVER_PORT:8080}

axon:
  eventhandling:
    processors:
      axonTestEventProcessor:
        source: axonTestEventEventSource

my build config : build.gradle
buildscript {
    ext {
        springBootVersion = '1.5.9.RELEASE'
    }

    repositories {
        jcenter()
    }

    dependencies {
        classpath group: 'org.springframework.boot', name: 'spring-boot-gradle-plugin', version: springBootVersion
    }
}

configure(javaProjects()) { project ->

    ext {
        lombokVersion = '1.16.18'
        axonVersion = '3.1.1'
    }

    description = 'Axon Framework Test'

    apply plugin: 'org.springframework.boot'
    apply plugin: 'java'

    dependencies {
        compileOnly group: 'org.projectlombok', name: 'lombok', version: lombokVersion

        compile group: 'org.springframework.boot', name: 'spring-boot-starter-web'
        compile group: 'org.springframework.boot', name: 'spring-boot-starter-amqp'

        compile group: 'org.axonframework', name: 'axon-amqp', version: axonVersion
        compile group: 'org.axonframework', name: 'axon-spring-boot-starter', version: axonVersion
    }
}

def javaProjects() {
    subprojects
}

If I launch with this config, I get rabbitmq connection error: org.springframework.amqp.AmqpConnectException: java.net.ConnectException: Connection refused (Connection refused)
2018-01-06 19:06:18.446  INFO 71264 --- [           main] s.b.c.e.t.TomcatEmbeddedServletContainer : Tomcat started on port(s): 8080 (http)
2018-01-06 19:06:18.450  INFO 71264 --- [           main] com.ouialgo.axon.AxonConsumerTest        : Started AxonConsumerTest in 2.846 seconds (JVM running for 3.456)
2018-01-06 19:06:23.488  WARN 71264 --- [cTaskExecutor-1] o.s.a.r.l.SimpleMessageListenerContainer : Consumer raised exception, processing can restart if the connection factory supports it. Exception summary: org.springframework.amqp.AmqpConnectException: java.net.ConnectException: Connection refused (Connection refused)
2018-01-06 19:06:23.489  INFO 71264 --- [cTaskExecutor-1] o.s.a.r.l.SimpleMessageListenerContainer : Restarting Consumer@3e05586b: tags=[{}], channel=null, acknowledgeMode=AUTO local queue size=0
2018-01-06 19:06:28.583  WARN 71264 --- [cTaskExecutor-2] o.s.a.r.l.SimpleMessageListenerContainer : Consumer raised exception, processing can restart if the connection factory supports it. Exception summary: org.springframework.amqp.AmqpConnectException: java.net.ConnectException: Connection refused (Connection refused)
2018-01-06 19:06:28.583  INFO 71264 --- [cTaskExecutor-2] o.s.a.r.l.SimpleMessageListenerContainer : Restarting Consumer@50ced644: tags=[{}], channel=null, acknowledgeMode=AUTO local queue size=0

But if I remove the line compile group: 'org.springframework.boot', name: 'spring-boot-starter-web', It works fine.
Thanks
Lei

Hi, sorry for the late reply on this issue. Honestly, I don't think this problem is Axon related. Axon doesn't create the AMQP connections. Spring should take care of that.
I'm closing this issue, for now, but don't hesitate to comment on it if there are any indications that Axon does influence this behavior somehow.


Error when I execute npm install?

I got an error when I execute npm install , do you have any solution? it seems zipper's make error? or update zipper?
275 error<EMAIL_ADDRESS>install: make all
275 error Exit status 2
276 error Failed at the<EMAIL_ADDRESS>install script.
276 error This is most likely a problem with the zipper package,
276 error not with npm itself.
276 error Tell the author that this fails on your system:
276 error     make all
276 error You can get their info via:
276 error     npm owner ls zipper
276 error There is likely additional logging output above.
277 error System Linux 3.8.0-35-generic
278 error command "/usr/local/bin/node" "/usr/local/bin/npm" "install" "--save" "xlsx-writer"
279 error cwd /home/vincent/Desktop/bitbucket/calculation
280 error node -v v0.10.25
281 error npm -v 1.3.24
282 error code ELIFECYCLE
283 verbose exit [ 1, true ]
and I'm using node v0.10.25 :)

adm-zip works well!!!!


refactor(coral): Improve data fetching for ACL request form

About this change - What it does
Implementing the feature in feat(coral): Only load topic names that are available in given env in topic name field showed that the approach of batching request with useQueries led to a better UX and more legible code. This conversation in particular..
This implements the same approach for the requests to getClusterInfo, and goes one step further by consolidating all this "environment-dependent" data in a single data structure: ExtendedEnvironment, which includes:

all data from Environment
the TopicNames for that Environment
an isAivenCluster boolean property

It also sets the staleTime of these queries to Infinity, so we never refetch them (except on page reload)
The result is:

a much snappier UI, as we now don't need to dispatch a request when an environment is selected by the user
less onSuccess side effects on the form values: we can use a more idiomatic useEffect.
more legible code, as we pick values from the consolidated ExtendedEnvironment entity.
probably much less flaky tests, as there is now no latency for rendering the correct fields for each form configuration.

Before
https://user-images.githubusercontent.com/20607294/216076924-001b27d7-fa97-490a-b304-1b01385016ca.mov
After
https://user-images.githubusercontent.com/20607294/216076707-6bb2bc1c-7fec-441b-bea1-125b4621d774.mov
Possible followup

clean up the tests to remove superfluous async logic
ExtendedEnvironment might be useful in other contexts. If it is, we might move useExtendedEnvironments to the domain/environment folder, and add it as a "first class citizen" of the data types we expose from there. The logic in useExtendedEnvironments is quite self contained and portable.

Looked through it a bit and I like the approach! It moves logic out of the component and for me that makes it easier to understand what TopicAclRequest is doing. It also would mean in case we would have endpoint changes to cater a bit more to our frontend need, it's easier to change that here.
Curious to see what Samuli thinks!

@Samuli looks great! I'm 🤦♀  because I didn't think of promise.all :D especially since I did something similar once in a side project, even with a custom query and using react query 😂


Clean up kernel entries properly on task reschedules.

related to moby #33789
When a task gets scheduled on a node, its IP could have been used by a task on a remote node
that just went down. The add event could be received before the delete the older task that went
down. In this case the kernel entry cleanup should be done before we update our state based on
the new add event. Otherwise the cleanup won't happen correctly when the old delete event does arrive.
This PR has the required changes in the libnetwork. But at least with Ubuntu 4.4.0 kernel running in AWS, I see that sometimes the fdb entry still remains even through the netlink call to delete the
entry succeeds. This needs to be looked into. But in cases where the fdb entry does get deleted
correctly this will avoid the overlay connectivity issue.
Signed-off-by: Santhosh Manohar<EMAIL_ADDRESS>

@fcrisciani What I realized after pushing this PR is that, sbox.AddNeighbor calls NeighSet netlink function. Its the equivalent of  fdb replace not fdb add. So even if we get an add while the previous entry hasn't been removed the replace should work. And the overlay driver has the logic to not try to clean up the kernel state when the old delete comes later. While doing the clean up on getting an Add event is ok, we have to get the actual root cause for why the fdb replace didn't work.

This PR was not addressing the issue, closing


Merge the latest code to the pilot branch

Add the latest code to the pilot branch

when a student login and his status (MVR, canvas) is empty - update it
add a second field for a parking spot - parkinhg_spot_return - to the vehicle report
fix cars' time available spaces bug
add drop down to display gas percentage to vehicle reports
allow to save any fuel return number, but display a message if it's less than 50%
edit all email templates

format
add 'To view/modify/cancel reservations, click here' text
in admins' emails link goes to the reservations
in students' emails - to welcome_pages/student

display all images on the vehicle report show page
in edit reservation make changing the day possible
in emails templates get the contact phone from unit preferences

@rsmoke I agree with your comments but later (in July) we will have to rethink/redesign the whole mail notification process to address the needs of all units. This is why I decided (for now) to keep the email templates simple and not spend time customizing them.

@rsmoke @jocelynanderson

in emails templates, the contact phone is coming from unit preferences now
also, I added a feature to change a day in the edit reservation form

Please consider adding your review soon

You should fix the static values issue now so it won't add to the technical debt.

@rsmoke I fixed the potential technical debt.
Please review it again.


the model is image2image or text2image

hi,i am reading the code.paper shows that the model uses img2img and textual inversion to generate data.but i did not find a img2img model in this code,only found a txt2img model.whether it is that i missed it.I am confused,hoping for your reply!

Hello leangovern,
Thanks for your interest in our code!  The underlying Stable Diffusion model is used as a [txt+img]2img model in our codebase. That is, given a real image to use as a guide, (1) we first add a small amount of random noise to that real image, and (2) we use Stable Diffusion to denoise that image, conditioned on a text prompt.
DA-Fusion uses Textual Inversion to learn the text prompt, but the prompt can also be prompt engineered if desired.
The image input helps to preserve the structure of the real image, and the text prompt input allows you to specify how you want the image to be augmented.
This class (https://github.com/brandontrabucco/da-fusion/blob/main/semantic_aug/augmentations/textual_inversion.py#L86) has the relevant code if you are interested in the implementation details.
Let me know how I can help if you have other questions!
-Brandon

Hello Brandon
Thank you very much for your detailed reply, which is of great help to me. Thank you very much for your work, which is a great inspiration to me. Thank you very much, I will continue to read your code and apply it to my work. Thank you very much.
-Govern

Hi Brandon,
I am back again.my english is poor,so i will try my best to express myself.i have a question in your paper.you mentioned that stable diffusion may leak internet images when generate pictures, if we use it to generate synthetic data may cause a diemma that the synthetic data is with great effect while it may be unfair.because stable diffusion is trained under huge number of  images.so we should erase the concept of the class we will generate, to ensure that we use the generative ability of SD instead of  the extra training data.hoping for your reply!
-Govern with repect

Hi again,
You got it!  Though in downstream applications, the model leaking internet images is not usually a big issue. We evaluated the model in our paper this way because were are interested in studying how the model generalizes to novel classes.
-Brandon

thank you brandon，your work is so inspiring!

Thank you for your work! I am curious if there is quantitative implementation of synthetic images in this work?


Missing basic info on base URL + auth

File: registry/spec/api.md, CC @joaofnfernandes
wanted to give the registry API a try.
Couldn't easily find:
a. the base URL that all documented endpoints live on (stackoverflow helped find it's https://registry.hub.docker.com)
b. a section on authentication, with a basic example (please!
Docker Hub and Docker Store don't have an officially supported API. It's true that they use Docker Registry under the hood, so you might be able to infer some of the endpoints, but it also means those products can change their APIs and break your integrations.
Since there's no action item for docs, I'm going to close this issue, but feel free to comment.

@joaofnfernandes thanks for clarifying that. is there another doc I could reference to find the information I was looking for?
WDYT about adding docker hub examples, for the benefit of everyone else?

Unfortunately the answer is no.
As much as I love seeing the community build cool things with Docker Hub, the reality is that Docker Hub doesn't have a public API, and we only document public APIs.
The rationale for this is that as a consumer of APIs you expect any API that is fully documented to not change, or at least implement some sort of versioning scheme if things change. It's a lot of work to build integrations, and having APIs changing under your feet is a real headache.
So while I understand your feedback, I think the right thing to do is to not document APIs that are private and that can change without notice.


Treat rake files as ruby files

Pronto ignores rake files even if I add this to .rubocop.yml:
AllCops:
  Include:
    - '**/*.rake'

Not sure if it's a proper fix though..
@mmozuras

@mmozuras any news? :smile:

@deees thanks! :bow:

Amazing :clap: Waiting for a ruby gem release now :smile:


Unable to reproduce the results on MS COCO datasets

Dear author, I tried to reproduce the results on MS COCO using the default config and base model from  http://dl.yf.io/fs-det/models/coco/base_model/model_final.pth, but  got average AP 10.460 on 10 seeds, could you please provide the model_final.pth you trained? Thank you very much!

我们提供的规格适用于 8-GPU。

Why do you need 8gpu? Can't I just keep the batch size consistent?

Batch size is a hyper parameter, just like learning rate. Few-shot learning is sensitive to training setting due to low data regime.
You can experiments with 4 cards, but we didn't have recommendations for hyper-params for it.
Some theoretical backgrounds on batch size and learning rate: https://stackoverflow.com/questions/53033556/how-should-the-learning-rate-change-as-the-batch-size-change


Unsubscribe keyboard shortcuts if window is hidden/closed

Here - https://github.com/zulip/zulip-electron/blob/master/app/main/index.js#L184

@akashnimare Is that different from https://github.com/zulip/zulip-electron/blob/master/app/main/index.js#L181?
How can we approach this one?

@jajodiaraghav I forgot to close this. It's already fixed 😄


mat-menu trigger is setting aria-expanded always true after first menuOpen

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
mat-menu trigger is setting aria-expanded always true after the first menuOpen,=
Reproduction
Steps to reproduce:
1.
{{t.menuOpen}}
<button mat-icon-button [matMenuTriggerFor]="menu" aria-label="Example icon-button with a menu">
more_vert

<mat-menu #menu="matMenu">

dialpad
Redial

voicemail
Check voice mail

notifications_off
Disable alerts

3. check {{t.menuOpen}} result after close menu
Expected Behavior
after closing menu aria-expanded= true should be null on mat-menu trigger
Actual Behavior
mat-menu trigger  aria-expanded  attribute always true until next menu open
Environment

Angular:14.0.7
CDK/Material: ^14.2.1
Browser(s): chrome
Operating System (e.g. Windows, macOS, Ubuntu): windows

Duplicate of https://github.com/angular/components/issues/26262.


ADDED: A few resources for reference

@divyanshu-rawat you may review and merge it

@yashovardhanagrawal  This branch has no conflicts with the base branch Travis is working fine  :).
thanks for the PR.
if possible can you add them by creating a folder instead of directly pushing them in the repo.


Add missing parent field to CreateMeasurementRequest.

This is a breaking change to comply with AIP-133.

This change is


Fix some files always having the same GUIDs(among several projects created from the template)

Fixed in a167c5690d0486e9a1ddff41dd48a9193be8c42c


addSpecificOrientationListener is not a function

I've managed to get functions like lockToLandscape() working by using 'const Orientation = require('react-native').NativeModules.Orientation;' rather than 'import Orientation from 'react-native-orientation;', as using the latter results in Orientation being undefined.
But I can't add any sort of orientation listener, or even use getSpecificOrientation, because they all throw the same error - X is not a function.
I really need to track my device's orientation. How do I get these functions to work?

Do you have some reproduction case?
This works correctly for me.
  componentWillMount() {
    Orientation.getSpecificOrientation((err, specificOrientation) => {
      console.log('specificOrientation', specificOrientation)
    })
  }

Finally I got rid of Orientation and used react-native-sensors. It works good for both Android and iOS. Acceleration data gives me real current orientation of device.

Same issue on Android.

The issue hasn't been resolved?

I'm able to both add listeners and access current orientation with
const Orientation = require('react-native-orientation')

I checked the repo and it looks like "Android Specific Orientation" functionality was added in March 17, 2016 and then reverted the next day from the repo (March 18, 2016). I am not sure why this was done or why it has not been added back in... am I missing something here?

I have opened a PR to add back in the "GetSpecificOrientation" method. I did not add back the "addSpecificOrientationListener" at the moment since I didn't need it right now. Perhaps we could create another PR to add that listener back in?

Same issue on Android.

@olbor
can you give an example for how to get  real current orientation of device by Acceleration data ?

+1


Automatically detect CF/local env

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Georgi Farashev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Potential segv if memory allocation fails.

I'm trying to work out what happens if this memory allocation fails, it looks from reading the code like mercury would segv in hg_proc_buf_memcpy() but I'm trying to test this now.
What would you expect to happen here, would it be enough to simply check here and return an error code or do the extra values need to be unpacked from the input buffer?
Edit - github seems to have failed me, this ticket should reference this line of code where a string is received as part of a RPC.
https://github.com/mercury-hpc/mercury/blob/master/src/proc_extra/mercury_proc_string.h#L184

Yes it should return an error there.  Thanks!

Fixed in 68a82c82f8084f9cc695c775db7c82268f832c26


CTDs in Wyrmstooth

Describe the bug
CTDs are encountered when visiting various areas in Wyrmstooth, primarily in the northern and southern ends of the island.
To Reproduce
Steps to reproduce the behavior:

Go to Wyrmstooth
Visit areas such as Krakevisa
Encounter a CTD

Expected behavior
It is expected to explore Wyrmstooth without encountering any CTDs.
Screenshots
N/A
Save
save.zip
Crash log
crash-2022-07-17-22-48-17.log
Desktop (please complete the following information):

OS version: [e.g. Windows 11, Windows 10] Windows 10 21H2
RAM: [e.g. 16gb, 32gb] 32gb
CPU: [e.g. Intel i7-9750H] AMD Ryzen 7
GPU: [e.g. Nvidia RTX 2060 Mobile] Nvidia RTX 2070 SUPER
Storage type Yggdrasil VR is installed on: [e.g. SSD, HDD] SSD
Antivirus [e.g. Windows Defender, Bitdefender] Windows Defender

Additional context
N/A

Dupe of #12


Error: ENOENT: no such file or directory for $ node server.js

Looks like its looking for wsdata.json and instead we have default.wsdata.json
$ node server.js
Express server listening on port 3000 in development mode
{ Error: ENOENT: no such file or directory, open '/home/ppidugu/Downloads/websync-master/wsdata.json'
at Error (native)
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: '/home/ppidugu/Downloads/websync-master/wsdata.json' }

cp default.wsdata.json wsdata.json

That should fix it...

I understand this step was mentioned in the gulpfile.js but I wasn't able to reach full execution of gulp...It was a pain from almost two days :(

Sorry for being so blunt, don't mean to be harsh, even tho thats how it sounds.
But i'm not maintaining this project anymore and haven't been for years. I can't be expected to step up every time there is an update or every time somebody gets an error.
If you want to use the project you need to either fork and fix it, and maybe submit a pull request if you want to share it with the rest of the world or don't use it.

@furier I dont know what to say.....I'm a big fan of your project. I dont expect you to be upgrading for every node.js, gulp or other dependencies..I thought If I post few of the issues may be someone could find somilar issues and that would lead to the solution someday......I dont have intention to make you feel bad....sorry if I'm being..

No problem man :) cool to hear you are a fan of the project, warms my hearth even tho I dont maintain it any more.


Truffle console fails with an unreadable error when no rpc is running

[ ] I've asked for help in the Truffle Gitter before filing this issue.

Issue
When testrpc is not running truffle console fails with an unreadable error message.
Steps to Reproduce
Run travis console without testrpc
Expected Behavior
Human readable error, which suggests, that an RPC is unreachable.
Actual Results
truffle console
/usr/local/lib/node_modules/truffle/lib/repl.js:25
    if (err) return done(err);
                    ^

ReferenceError: done is not defined
    at /usr/local/lib/node_modules/truffle/lib/repl.js:25:21
    at /usr/local/lib/node_modules/truffle/lib/repl.js:57:21
    at /usr/local/lib/node_modules/truffle/lib/contracts.js:46:25
    at /usr/local/lib/node_modules/truffle/node_modules/web3/lib/web3/property.js:119:13
    at /usr/local/lib/node_modules/truffle/node_modules/web3/lib/web3/requestmanager.js:82:20
    at exports.XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/node_modules/web3/lib/web3/httpprovider.js:114:13)
    at exports.XMLHttpRequest.dispatchEvent (/usr/local/lib/node_modules/truffle/node_modules/xmlhttprequest/lib/XMLHttpRequest.js:591:25)
    at setState (/usr/local/lib/node_modules/truffle/node_modules/xmlhttprequest/lib/XMLHttpRequest.js:610:14)
    at exports.XMLHttpRequest.handleError (/usr/local/lib/node_modules/truffle/node_modules/xmlhttprequest/lib/XMLHttpRequest.js:532:5)
    at ClientRequest.errorHandler (/usr/local/lib/node_modules/truffle/node_modules/xmlhttprequest/lib/XMLHttpRequest.js:459:14)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketErrorListener (_http_client.js:309:9)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at emitErrorNT (net.js:1281:8)

Environment

Operating System: MacOS
Truffle version: Truffle v2.1.1
Ethereum client: No
node version: v7.2.0
npm version: 3.10.9

This is no longer the case on master. The current error is Error: Invalid JSON RPC response: "", which is still cryptic, but at least that's standard across Truffle. A new issue should be added that when a provider is required that it checks the connection first by calling a standard request (eth_version or something) and produces a human readable error if that fails. Would love for you to write that issue if you feel it's a problem.
Thanks for submitting!


Map to Emerald Cloud Laboratories (ECL) ontology

[feel free to close if this is out of scope and not in the immediate area of interest for OBI]
ECL is a remotely operated research facility that handles all aspects of daily lab work — method design, materials logistics, sample preparation, instrument operation, data acquisition and analysis, troubleshooting, waste disposal:
https://www.emeraldcloudlab.com/
See this video: https://www.emeraldcloudlab.com/how-it-works/command/
ECL has what could be called an ontology (based on Wolfram Alpha Data Framework, not OWL), but it's more like a schema.org-style ontology.
https://www.emeraldcloudlab.com/documentation/
You can see the upper level classes and subtypes here:
https://www.emeraldcloudlab.com/documentation/types/
"objects" are either instances or value sets:
https://www.emeraldcloudlab.com/documentation/objects/
Some of this is in OBI territory:

WDF also has the notion of Functions, for ECL these may often map to planned processes
https://www.emeraldcloudlab.com/helpfiles/aliquot
I think a lot of this is a different way of thinking than a realist OBO ontology. Although it could be argued that this is as real as it gets - imagine instantiating OBI objects and then shipping them off to a cloud lab to perform your protocol...
I have no specific use case for a mapping yet, but it seems not engaging and aligning is a missed opportunity

Automated (robot) science and ontologies for them have been part of OBI since its foundation (Larissa Soldatova contributed based on her work here: https://pubmed.ncbi.nlm.nih.gov/16873508/). If there is interest by these guys and they want to contribute, that is awsome, but we don't have bandwidth to reaching out to something like this.


refactor(table): remove useless style

Checklist
List of tasks you have already done and plan to do.

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information
Describe your modifications here.
Issues
The issues you want to close, formatted as close #1.
Related Links

@haoziqaq
第二个 text-align 没起作用，不如整合一下

我这里合并主干代码解决冲突  保留了高权重的  低权重的没有删 @chouchouji

我这里合并主干代码解决冲突 保留了高权重的 低权重的没有删 @chouchouji

我晚上再优化下这里


Entity() resource cannot spawn modded mobs with custom nbt

e.g: a text file, Pirate.txt, containing {PersistenceRequired:1b} exists in the root of WorldObjects. There is also a bo3 in this directory which contains
Entity(0,1,0,EntityPirate,1,Pirate.txt) Entity(2,1,3,Skeleton,1,Pirate.txt) Entity(1,1,4,EntityPirate,1)
When this bo3 is placed, one EntityPirate without any nbt spawns, as does one Skeleton with nbt. Ideally a second EntityPirate with nbt should spawn.
Thanks,
spork

Thanks for reporting! Will be fixed with v7_DEV_r24, which will be released on the Discord's OTG-dev channel soon.


[Compact Storage] Compact message displayed indefinitely

Affected hardware version
Bangle 2
Your firmware version
2v18.115
The bug
I had fastload installed when this happened. I can't reproduce right now even with fastload installed.
Describe the bug

I noticed quicklaunch had stopped working and went to "Rewrite Settings" which sometimes work. I tried pressing the menu entry for that but didn't get any feedback that it initialized.
Instead I began "Compact Storage" which displayed the old instruction on the on-screen buffer and a new instruction in a small overlay window.
The screen backlight timed out and the overlay window disappeared at the same time.
I let the watch sit for at least 10 minutes but the old instruction never went away.
Eventually I long pressed the HW button which took me to my clock face.
Navigating back to the settings app I noticed swscroll had stopped working and the firmwares E.showScroller was active instead.
I now managed to do "Rewrite settings" and it executed as it normally does.
I still didn't have my quicklaunch actions set, but swscroll now worked.
Went to quicklaunch settings to see that no apps were set anymore.
Connected to Web IDE to look at the storage file browser. There were a lot of scrambled filenames on top, like so:

Looking at quicklaunch.json there are no apps set for the different actions.
Installed apps
Fastload
... and others.

Also when trying to do a backup i get stuck with this message on the app loader:

Download `l a

And in the Web IDE I get this when it is interrupted:

W10=ÿUncaught Error: Cannot read property 'length' of undefined
at line 1 col 57
...l a");Bluetooth.println(((s.length+2)/3)<<2);for(var i=0;i<s.lengt...
^
in function called from line 6 col 4
})()
^

I suspect all this will be resolved when I remove the files with scrambled filenames. That has helped before to some extent. I just wanted to document this first.

It looks like your storage has got corrupted...  Where did you start compact storage from? settings?
What do you mean by:

I began "Compact Storage" which displayed the old instruction on the on-screen buffer and a new instruction in a small overlay window.

You mean the Please Wait... STORAGE COMPACTION IN PROGRESS... message? But it went away if it's own accord?
Before you do anything else, please could you try what's here? https://github.com/espruino/BangleApps/issues/2865#issuecomment-1649549028
Then I could get a copy of what's in your storage and could see if I can figure out what went wrong. Of course it may be you were having issues because storage got corrupted, and compaction just made it worse?
After that, probably the best thing is for you to do a backup of your watch using the app loader (if you can) and then delete the broken files from the zip and then restore from the zip - which will mean storage gets completely refreshed.

It looks like your storage has got corrupted... Where did you start compact storage from? settings?

Yes, Settings->Utils->Compact Storage.

What do you mean by:

I began "Compact Storage" which displayed the old instruction on the on-screen buffer and a new instruction in a small overlay window.

You mean the Please Wait... STORAGE COMPACTION IN PROGRESS... message? But it went away if it's own accord?

Yes, it went away at the same time as the backlight turned off.

Before you do anything else, please could you try what's here? #2865 (comment)
Then I could get a copy of what's in your storage and could see if I can figure out what went wrong. Of course it may be you were having issues because storage got corrupted, and compaction just made it worse?

I'll try to do that.

After that, probably the best thing is for you to do a backup of your watch using the app loader (if you can) and then delete the broken files from the zip and then restore from the zip - which will mean storage gets completely refreshed.

I might do it that way then.

How long is the logging expected to take, roughly?

If it helps, I logged 251,661 lines in about two hours. I also saw shorter lines.
I was thinking, if the bottleneck's the BLE connection, we could tweak that code for next time to apply some compression.

If it helps, I logged 251,661 lines in about two hours. I also saw shorter lines.

Maybe I don't see longer lines. I'm not sure.

570k lines now and counting.
Curiously the Web IDE connection window have popped up spontaneously a couple of times during the streaming so far. It didn't cancel the connection or stop the data stream though.

I just came back to the laptop/phone/bangle logging setup and the Web IDE said it had been disconnected from android. I don't know if it was that the logging was done that prompted the disconnect. At the same time it seem the bangle sent status messages saying it was fully charged. It's in the log I'll send to you @gfwilliams. Web IDE says 630,751 lines were logged.

Thanks! Well, that should be promising I hope - it's trying to write 8MB of data, and for that intel hex dump it's writing 16 bytes per line, plus some extra to set the address range - so you would expect around 550k lines I guess? 600k seems a bit high but hopefully that's everything.
We could send it as base64 I guess, which should be a bit better and faster. Intel hex is just an 'easy' format to deal with - if there is data missing from the middle it's not a big deal

@gfwilliams did you get the messages with my two logs on the forum? I've been holding of resetting my device in case you'd want something more from it - if there happened to be something wrong with the second log as well. But now I'm a bit eager to actually reset the watch :p

Sorry about that - yes, I just replied on the forum. Sorry for the delay - I think that's everything we can get from the watch. I'll have a go at reproducing on mine and will see if I can figure out what's up.
Interestingly it looks like there are some big erased areas in the middle, so it's almost as if it compacted, but then didn't manage to clear all the space that it had freed up. When that happens it'll still keep functioning as normal until it hits the area that it thought was clear but then isn't - and then things start to go badly wrong.

Thanks!

Also when trying to do a backup I get stuck with this message on the app loader:

Download `l a

And in the Web IDE I get this when it is interrupted:

W10=ÿUncaught Error: Cannot read property 'length' of undefined
at line 1 col 57
...l a");Bluetooth.println(((s.length+2)/3)<<2);for(var i=0;i<s.lengt...
^
in function called from line 6 col 4
})()
^

I just tried to use the Web IDE to remove all files with scrambled names. That was possible for all but the file " `l a " referenced above.
When opening that file it's contents are 00000000: 00 00 00                                        ...  (maybe with a newline at the end)
If I Save that file and open it with neovim it looks like this:

Three identical  ^@ chars.
And the file is this:
`l a.txt

Thanks - that's interesting... Looks like the IDE hasn't been able to copy in the filename correctly.
Does doing this into the left-hand side of the IDE pane work?
print(JSON.stringify(require("Storage").list(),null,2))

You'll probably find that the filename isn't just "`l a.txt" and maybe it has some extra weird chars in there.
Then try this, but with the correct filename:
require("Storage").erase("`l a.txt")

Does doing this into the left-hand side of the IDE pane work?
print(JSON.stringify(require("Storage").list(),null,2))

You'll probably find that the filename isn't just "`l a.txt" and maybe it has some extra weird chars in there.

Yes, I get this:
>print(JSON.stringify(require("Storage").list(),null,2))
[
  "sched.boot.js",
  "sched.js",
  "sched.img",
  "sched",
  "sched.settings.js",
  "sched.clkinfo.js",
  "sched.info",
  "messageicons",
  "messageicons.img",
  "messageicons.info",
  "widmsggrid.wid.js",
  "widmsggrid.info",
  "messagegui.img",
  "health.img",
  "widminbat.wid.js",
  "widminbat.info",
  "backswipe.info",
  "torch.app.js",
  "torch.img",
  "torch.settings.js",
  "torch.info",
  "calculator.app.js",
  "calculator.img",
  "calculator.info",
  "widram.wid.js",
  "widram.info",
  "widbthide.wid.js",
  "widbthide.info",
  "smpltmr.img",
  "stopw.clkinfo.js",
  "clkinfostopw.info",
  "bwclklite.img",
  "runplus.img",
  "dtlaunch.img",
  "quicklaunch.settings.js",
  "quicklaunch.boot.js",
  "quicklaunch.app.js",
  "quicklaunch.info",
  "alarm.img",
  "powermanager.boot.js",
  "powermanager.settings.js",
  "powermanager.wid.js",
  "powermanager",
  "powermanager.default.json",
  "powermanager.info",
  "agenda.img",
  "setting.img",
  "dtlaunch.json",
  "mysetup.info",
  "fastreset.boot.js",
  "fastreset.info",
  "health-2023-5.raw",
  "bwclklite.info",
  "smpltmr.app.js",
  "smpltmr.clkinfo.js",
  "smpltmr.info",
  "log.txt\u0001",
  "health-1970-1.raw",
  "hrm.app.js",
  "hrm.img",
  "hrm.info",
  "sched.settings.json",
  "lightswitch.boot.js",
  "lightswitch.images.json",
  "lightswitch.info",
  "lightswitch.js",
  "lightswitch.settings.js",
  "lightswitch.wid.js",
  "health-2023-6.raw",
  "bwclklite.app.js",
  "bwclklite.settings.js",
  ".bootcde",
  "bootupdate.js",
  "boot.info",
  "messages",
  "messages.settings.js",
  "messages.info",
  "podadrem.img",
  "spotrem.img",
  "recorder.log20230616a.csv\u0001",
  "recorder.log20230618a.csv\u0001",
  "recorder.log20230618b.csv\u0001",
  "recorder.log20230618c.csv\u0001",
  "recorder.log20230618d.csv\u0001",
  "recorder.log20230618e.csv\u0001",
  "recorder.log20230618f.csv\u0001",
  "recorder.log20230618g.csv\u0001",
  "recorder.log20230618h.csv\u0001",
  "recorder.log20230618i.csv\u0001",
  "recorder.log20230618j.csv\u0001",
  "recorder.log20230618k.csv\u0001",
  "runplus.app.js",
  "runplus.settings.js",
  "runplus_karvonen",
  "runplus.info",
  "recorder.log20230618l.csv\u0001",
  "recorder.log20230618m.csv\u0001",
  "recorder.log20230618n.csv\u0001",
  "recorder.log20230618o.csv\u0001",
  "recorder.log20230618p.csv\u0001",
  "recorder.log20230618q.csv\u0001",
  "recorder.log20230618r.csv\u0001",
  "recorder.log20230618s.csv\u0001",
  "recorder.log20230618t.csv\u0001",
  "recorder.log20230618u.csv\u0001",
  "recorder.log20230618v.csv\u0001",
  "recorder.log0.csv\u0001",
  "recorder.log20230618w.csv\u0001",
  "gipy.img",
  "hallsbergSkogaholm.gps",
  "recorder.log20230625a.csv\u0001",
  "recorder.log20230625b.csv\u0001",
  "recorder.log20230625c.csv\u0001",
  "recorder.log20230625d.csv\u0001",
  "recorder.log20230625e.csv\u0001",
  "recorder.log20230625f.csv\u0001",
  "recorder.log20230625g.csv\u0001",
  "recorder.log20230625h.csv\u0001",
  "recorder.log20230625i.csv\u0001",
  "recorder.log20230625j.csv\u0001",
  "recorder.log20230625k.csv\u0001",
  "recorder.log20230625l.csv\u0001",
  "recorder.log20230625m.csv\u0001",
  "recorder.log20230625n.csv\u0001",
  "powermanager.json",
  "powermanager.def.json",
  "powermanager.hw.json",
  "health-2023-7.raw",
  "messages.settings.json",
  "agenda.app.js",
  "agenda.settings.js",
  "agenda.clkinfo.js",
  "agenda.info",
  "clock_info.settings.js",
  "spotrem.app.js",
  "spotrem.info",
  "recorder.settings.js",
  "messagegui",
  "messagegui.app.js",
  "messagegui.new.js",
  "messagegui.boot.js",
  "messagegui.info",
  "podadrem.app.js",
  "podadrem.info",
  "recorder.log20230704a.csv\u0001",
  "recorder.log20230704b.csv\u0001",
  "recorder.log20230704c.csv\u0001",
  "recorder.log20230704d.csv\u0001",
  "recorder.log20230704e.csv\u0001",
  "recorder.log20230704f.csv\u0001",
  "recorder.log20230704g.csv\u0001",
  "recorder.log20230704h.csv\u0001",
  "gipy.app.js",
  "gipy.settings.js",
  "gipy.info",
  "recorder.log20230705a.csv\u0001",
  "recorder.log20230705b.csv\u0001",
  "recorder.log20230705c.csv\u0001",
  "recorder.log20230705d.csv\u0001",
  "recorder.log20230706a.csv\u0001",
  "recorder.log20230706b.csv\u0001",
  "recorder.log20230706c.csv\u0001",
  "recorder.log20230706d.csv\u0001",
  "recorder.log20230706e.csv\u0001",
  "recorder.log20230706f.csv\u0001",
  "recorder.log20230706g.csv\u0001",
  "recorder.log20230706h.csv\u0001",
  "recorder.log20230706i.csv\u0001",
  "recorder.log20230706j.csv\u0001",
  "recorder.log20230706k.csv\u0001",
  "recorder.log20230706l.csv\u0001",
  "recorder.log20230706m.csv\u0001",
  "recorder.log20230706n.csv\u0001",
  "recorder.log20230706o.csv\u0001",
  "recorder.log20230706p.csv\u0001",
  "recorder.log20230706q.csv\u0001",
  "recorder.log20230706r.csv\u0001",
  "recorder.log20230706s.csv\u0001",
  "recorder.log20230706t.csv\u0001",
  "recorder.log20230706u.csv\u0001",
  "recorder.log20230706v.csv\u0001",
  "recorder.log20230706w.csv\u0001",
  "recorder.log20230706x.csv\u0001",
  "recorder.log20230707a.csv\u0001",
  "recorder.log20230707b.csv\u0001",
  "recorder.log20230707c.csv\u0001",
  "recorder.log20230707d.csv\u0001",
  "recorder.log20230707e.csv\u0001",
  "recorder.log20230707f.csv\u0001",
  "recorder.log20230707g.csv\u0001",
  "android.app.js",
  "android.settings.js",
  "android.img",
  "android.info",
  "android.settings.json",
  "recorder.log20230712a.csv\u0001",
  "recorder.log20230712c.csv\u0001",
  "recorder.json",
  "android.boot.js",
  "multitimer.img",
  "multitimer.json",
  "backswipe.settings.js",
  "android.calendar.json",
  "dtlaunch.settings.js",
  "dtlaunch.info",
  "fastload.json",
  "sched.json",
  "kineticscroll.boot.js",
  "kineticscroll.info",
  "dtlaunch.app.js",
  "swscroll.boot.js",
  "swscroll.info",
  "openstmap.img",
  "openstmap.0.json",
  "openstmap.0.img",
  "openstmap.json",
  "snepwatch.app.js",
  "snepwatch.settings.js",
  "snepwatch.img",
  "snepwatch.info",
  "sleeplog.app.js",
  "sleeplog.img",
  "sleeplog.boot.js",
  "sleeplog",
  "sleeplog.settings.js",
  "sleeplog.info",
  "sleeplog_1392.log",
  "sleeplog_1393.log",
  "sleeplog_1394.log",
  "sleeplog_1395.log",
  "sleeplog_1396.log",
  "sleeplog.log\u0001",
  "`l a",
  "`,aa`dnd `.b\u0001",
  "sde` D@C ln ",
  "s,aepdif&`-G",
  "          da\u0001",
  "sde``de&\"dad\b",
  "messagesoverlay",
  "messagesoverlay.0.boot.js",
  "messagesoverlay.info",
  "clock_info.json",
  "backswipe.boot.js",
  "fastload.5.boot.js",
  "fastload.settings.js",
  "fastload.info",
  "setting.app.js",
  "setting.info",
  "quicklaunch.json",
  "widanclk.wid.js",
  "widanclk.info",
  "widalarm.wid.js",
  "widalarm.info",
  "alarm.app.js",
  "alarm.info",
  "multitimer.app.js",
  "multitimer.boot.js",
  "multitimer.alarm.js",
  "multitimer.info",
  "backswipe.json",
  "dragboard.settings.js",
  "dragboard.info",
  "health-2023-8.raw",
  "iconlaunch.na.img",
  "iconlaunch.cache.json",
  "exstats.json",
  "setting.json",
  "textinput",
  "lightswitch.json",
  "kbmulti.settings.json",
  "notify",
  "notify.info",
  "health.app.js",
  "health.boot.js",
  "health",
  "health.settings.js",
  "health.info",
  "clock_info",
  "clock_info.info",
  "recorder.app.js",
  "recorder.img",
  "recorder.wid.js",
  "recorder.clkinfo.js",
  "recorder.info",
  "openstmap",
  "openstmap.app.js",
  "openstmap.info",
  "iconlaunch.app.js",
  "iconlaunch.settings.js",
  "iconlaunch.info",
  "sixths.app.js",
  "sixths.img",
  "sixths.info",
  ".boot0",
  "launch.cache.json",
  "fastload.cache",
  "sixths.egt\u0001",
  "fastload.history.json"
 ]
=undefined
>

You'll probably find that the filename isn't just "`l a.txt" and maybe it has some extra weird chars in there.
Then try this, but with the correct filename:
require("Storage").erase("`l a.txt")

For clarity, the file is only named "`l a.txt"  with the .txt extension when it's saved to my laptops ssd.

Maybe me working on Activity tracks  can have had something to do with it? Just adding it as a lead.

Any luck deleting those files manually?
I'm pretty sure there was an issue with the handling of StorageFiles that could have caused problems (mainly trying to repeatedly write while storage is full). I'm not sure when you last updated your firmware but it was only very recently that I made some quite big changes to try and improve the situation, so you might have been unlucky and things got corrupted while you were on an earlier firmware?

 I'm not sure when you last updated your firmware but it was only very recently that I made some quite big changes to try and improve the situation, so you might have been unlucky and things got corrupted while you were on an earlier firmware?

I think this is the likely scenario. I last worked on the PR three weeks ago, which I think is before you added the fix.

... so we're saying that you still can't back up with the app loader because you get that error?
Please can you try on the development app loader and see if it's any better? I just pushed a change to try and make readfile more robust

I could do the backup now thanks to your change. Then I unpacked the directory and removed the "`l a" file. Then I rezipped it and tried to restore it.
But the Restore utility doesn't work. It managed to erase the device after I gave the go ahead. Then it says it reads the zip. When it says it's starting the restore it pretty immediately finishes, not enough time to have restored the zip and there's nothing on the watch.
I'll do a factory reset and then try restoring the zip without erasing first.

Ok, thanks - any errors in the console? It could be one of the files is causing an issue... You won't have all the files you need on there anyway I bet, but it should still be able to restore what it has.
Maybe email me the zip and I can see if I can figure out why it's not restoring?

I'll add it on the message thread on the forum. Do you want it on email as well?

No the message thread is fine - thanks!

@gfwilliams does it make sense to close this issue?

Yes, I'd think so... I forget but did I sort out the issue with restoring that zip file?

I think so, yes 🙂


Try to remove NotParsed.Value (even if internal)

What in subject was made for HelpText needs.
I'm trying to resolve it in dev branch presrefact.
As soon on master! :smile_cat:

Very proud of how much ParserResult<T> is now made cleaner!

Heard of sometimes simpler is better? :)


Removed dependencies on internal gradle API and internal eclipse

Full story is in the commit messages :)
Btw, I'm giving a talk at GradleSummit in a couple weeks about using Gradle with Eclipse/P2/OSGi, etc.  This plugin will be spotlighted.
Do you think we can publish a 1.4.0 later this week that I can anchor my slides to?

Thanks for the contribution! I left two comments inline.
I knew about the EnvironmentInfo issue, but I didn't find any handy alternatives. That's where your code from DurianSwt comes in nicely.

Btw, I'm giving a talk at GradleSummit in a couple weeks about using Gradle with Eclipse/P2/OSGi, etc. This plugin will be spotlighted.

Awesome! Please provide a link to your presentation once it is available.

Do you think we can publish a 1.4.0 later this week that I can anchor my slides to?

Should be no problem, probably on the weekend.

Btw, I created an unpuzzle fork that aims to provide the means to mavenize existing Eclipse RCP applications to be able to reuse the functionality in a standard Maven environment. It adds the following main features to unpuzzle:

include dependencies based on Import-Package instructions in bundle manifests
translate bundle dependencies to existing Maven artifacts on jcenter and other repositories where possible (easily done for bundles that were created using bnd-platform via a Maven dependency)

Not sure if that's any use to you. My use case was a Maven Tycho based build backed by a bnd-platform p2 repo where I wanted to reuse the bundles built there in standard Gradle/Maven projects.

Re: wuff unpuzzle fork, that's very interesting! So you parse-out the export-package and import-package, and calculate it out from that?

Exactly - the basic assumption is that in the set of bundles that you have in your application or update site, all dependencies that you need are there. Thus it scans all manifests for Export-Package and Import-Package and does the matching based on that.
Afterwards, dependencies to the unpuzzled bundles may be replaced by the original Maven artifact dependencies. So, just as an example, you end up with a dependency to the official slf4j-api artifact, instead of the unpuzzled version that has a different name and maybe even version.

Eclipse makes it way too hard to use their stuff outside of the IDE plugin environment

The general truth about Eclipse (RCP) specifically and OSGi in general :wink:


Preview Time showing the wrong Date

While showing the correct time, the date is one month behind, even after multiple restarts
e.g.
WiiU Settings -> June 17th 2023 12:56
WiiU Time Sync Preview Time -> 2023-05-17 12:56:20:0090:0002
EU/ger WiiU 5.5.1e latest aroma
Syncing Enabled: true
Daylight Savings: true
Time Offset (hours): 1
Time Offset (minutes): 0
thank you

Thank you for bringing this to my attention! I apologize for the oversight on my part, as I missed this issue during my testing. I now understand that the month is zero-based indexed, meaning that January has a value of 0, February has a value of 1, onward.
To address this problem, I will commit a change that increments the value of ct.tm_mon once. This adjustment should resolve the issue and display the correct month.


Fastclick not required anymore

On the Vuejs.org website, I can see that fastclick is used. However, according to the project's readme:
"As of late 2015 most mobile browsers - notably Chrome and Safari - no longer have a 300ms touch delay, so fastclick offers no benefit on newer browsers, and risks introducing bugs into your application. Consider carefully whether you really need to use it."
I think that fastclick should be removed. The website will load faster because one less library has to be loaded.
Tell me what you think!

I agree :) Would you mind working on a PR?

Sorry, I was busy :-/
Thanks for doing it :)


API: Test & Doc Coverage Overhaul

This issue is a bit out there. Ideally before we ship a public version of our API, we need to make sure the test coverage is excellent, and also get coverage of the endpoints & their options into our documentation.
Doing both of these requires the same thing to happen: for someone to build up extensive knowledge of each endpoint and what it is capable of and ensure it's both tested and documented. That's a pretty time-consuming task.
Testing
The heart of Ghost's API lives in the functions in core/server/api/<resource>.js, E.g. posts.api.browse(). Currently, those functions are tested in the integration tests in core/test/integration/api - these tests go through the complete stack, no stubbing or mocking, and test what actually happens. Some of the endpoints are well-tested there, others not so much.
If you're using the API over HTTP, those functions get wrapped by the http method in core/server/api/index.js. That method is a sort of middleware, taking a request with the req and res functions, converts the incoming options from being in request format to being in method call format of object and options, calls the api method, and converts the result into JSON or a correctly formatted error to be sent in a response.
The HTTP version of the API is tested in the functional/integration tests that live in core/test/functional/routes/api these tests also go through the complete stack, no stubbing or mocking, and test what actually happens, but start with an HTTP call, rather than with a method call. Again, some of the end points are well-tested there and others are not.
Some endpoints are tested by one set of tests and not the others, some have both.
As well as the HTTP call wrapper around the methods, soon we're also going to have a get-helper wrapper around the methods. I wouldn't expect to have yet-another-suite of integration tests for that too.
Instead, I believe what we should have is a complete suite of integration tests for the method calls. The tests for the HTTP wrapper should then be unit tests which stub out the method calls and check that we get the correct response including status code, headers, and body format.
This means, core/test/integration/api should have 100% coverage for the tests, and we'd then have unit tests in core/test/unit/api_spec.js, which just tested the methods in the core/server/api/index.js file. All of the HTTP tests in core/test/routes/functional/api can go away, or we can keep a single set of integration tests in core/test/routes/funcitonal/api_spec.js to check key concepts, rather than every endpoint in detail.
Coverage
Our coverage tasks currently only relate to unit tests. Integration tests tend to execute a lot of intialisation code, meaning that if they're included in coverage a lot of lines get marked as covered when they're not being directly tested.
However, it would be good to be able to get a picture of how much test coverage there is on the API, and so I think it would be worthwhile to add a second coverage task (grunt coverage-api or grunt coverage-integration?) to run the integration tests or just api integration tests.
The grunt-mocha-istanbul library we're using allows for configuration of multiple coverage tasks by adding a new config: https://github.com/TryGhost/Ghost/blob/master/Gruntfile.js#L266 and wiring it up to a grunt task.
Documentation
Documentation for the API can come in 2 forms. Firstly it would be good to ensure that there is at least basic inline docs explaining what object and options are/can be for each endpoint, a bit like this: https://github.com/TryGhost/Ghost/blob/master/core/server/api/posts.js#L32
Secondly, we have API documentation setup in readme.io, but we need to populate it with the details of each endpoint. Anyone wanting to help with this will need to be added to the readme.io project.
Approach
I recommend that we start with the soon-to-be public endpoints: read & browse for posts, tags, and users. Once that is done we can extend out to edit/add/destroy for each of those, and then to other important resources like settings.

Closing this for now, will open more specific issues when we need to.


[Feature Request] Diamond Flask

I know flask slots are an upcoming feature, but I feel like a boolean "is Diamond Flask active" would be useful in the meantime, and a lot faster to implement.

Hmm. I'll consider it.

The next update will add a "Is your Crit Chance Lucky?" option to the Configuration tab, in the Effective DPS section.


Added 04.0 Android-Manifest file [issue - #516 ]

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # <issue_number_here>

Type of change 📝

[x] Doc#umentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Android Dev #(Kotlin)

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

@rahulsain  Please review my PR and if any mistake is their kindly guide me . (and I apologize @rahulsain for creating a mess... )


🐛 2.15.3+ has a 90 rotation on landscape iOS

What were you trying to do?
Take a photo in landscape, which is now rotated (90) and wrong after updating from 2.15.2 to 2.15.4.
Reverted this from 2.15.4 (to keep the RN71 fix) and all was resolved - https://github.com/mrousavy/react-native-vision-camera/commit/bf71901968fcdb7fbb5864c435ff239df23c81a5
Reproduceable Code
<Camera
          ref={scannerRef}
          photo={photo}
          device={device}
          isActive={isFocused}
        />

What happened instead?
The image displayed in preview is 90 degrees wrong, despite not specifying a rotation.
Relevant log output
n/a

Device
iPad 6 Gen
VisionCamera Version
2.15.4
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

@mrousavy - Trying to help out with a patch, but not following why this changed to be locked to portrait in this commit - https://github.com/mrousavy/react-native-vision-camera/commit/bf71901968fcdb7fbb5864c435ff239df23c81a5#diff-bff70569c755a3c0200dca5fff5c86d56017e222b6e7d2d1d348b6992d623cbeR15
Any ideas?

Also experienced this issue on iPad, have to downgrade to 2.14.1 temporarily, waiting for a fix for this.

@mrousavy any update ,fix or workaround on this will be highly appriaciated

Closing as this is a stale issue - this might have been fixed with the full rewrite in VisionCamera V3 (🥳) - if not, please create a new issue.
If your issue has been fixed, consider sponsoring me on GitHub to say thanks 💖

JFYI; Camera sensors always have a 90deg orientation

Hey - I'm tracking Orientation in this feature request/issue now: https://github.com/mrousavy/react-native-vision-camera/issues/1891 ✨
Make sure to upvote or sponsor to support this feature, and leave a comment if you have any additional thoughts/ideas.


Acknowledge Apple's current AutoLayout syntax in Readme (since iOS 9.0)

New Issue Checklist
🚫 If this template is not filled out your issue will be closed with no comment. 🚫

[x] I have looked at the Documentation
[x] I have filled out this issue template.

Issue Info

Info
Value

Platform
n/a (this is about the readme file)

Platform Version
n/a (this is about the readme file)

Masonry Version
n/a (this is about the readme file)

Integration Method
n/a (this is about the readme file)

Issue Description
I think it would be a good idea to acknowledge the fact that, while Apple's original AutoLayout API syntax is indeed very verbose, since iOS9 it can be rewritten using their anchor syntax.
For example this code from the Readme file:
[superview addConstraints:@[

    //view1 constraints
    [NSLayoutConstraint constraintWithItem:view1
                                 attribute:NSLayoutAttributeTop
                                 relatedBy:NSLayoutRelationEqual
                                    toItem:superview
                                 attribute:NSLayoutAttributeTop
                                multiplier:1.0
                                  constant:padding.top],

    [NSLayoutConstraint constraintWithItem:view1
                                 attribute:NSLayoutAttributeLeft
                                 relatedBy:NSLayoutRelationEqual
                                    toItem:superview
                                 attribute:NSLayoutAttributeLeft
                                multiplier:1.0
                                  constant:padding.left],

    [NSLayoutConstraint constraintWithItem:view1
                                 attribute:NSLayoutAttributeBottom
                                 relatedBy:NSLayoutRelationEqual
                                    toItem:superview
                                 attribute:NSLayoutAttributeBottom
                                multiplier:1.0
                                  constant:-padding.bottom],

    [NSLayoutConstraint constraintWithItem:view1
                                 attribute:NSLayoutAttributeRight
                                 relatedBy:NSLayoutRelationEqual
                                    toItem:superview
                                 attribute:NSLayoutAttributeRight
                                multiplier:1
                                  constant:-padding.right],

 ]];

becomes:
    [view1.topAnchor constraintEqualToAnchor: superview.topAnchor constant: padding.top];
    [view1.leftAnchor constraintEqualToAnchor: superview.leftAnchor constant: padding.left];
    [view1.bottomAnchor constraintEqualToAnchor: superview.bottomAnchor constant: -padding.bottom];
    [view1.rightAnchor constraintEqualToAnchor: superview.rightAnchor constant: -padding.right];

Of course in many other cases Masonry's syntax is still shorter even than Apple's revised syntax.
Moreover, if a user targets lower than iOS9, then Masonry offers a solution there.
But I think users should be made aware of this revised Apple syntax, so they can make an informed decision about the best solution for their project.

YES. I  look for rewrite Mansonry with NSLayoutAnchor api since iOS 9.
NSLayoutAnchor has a better performance , better readable syntax.
Below is my test case.
View name = kPageTypeFrame  Cost：1.342913  View name = kPageTypeAnchor   Cost：3.878272  View name = kPageTypeVFL   Cost：5.168020  View name = kPageTypeMasonry   Cost：5.072396


Fix typos in templates creating 404 links

Possible typos:

[ ] http://spring.io/team/mpollack/'https://twitter.com/springcentral - links to springcentral twitter account in the team page
[ ] http://spring.io/blog/2012/03/12http://www.youtube.com/springsourcedev-creating-spring-insight-plugins - links to youtube videos in blog posts
[ ] http://spring.io/blog/2008/12/11/.atom - links to ATOM feeds in blog posts

@bclozel
Can i take up this issue.

I think those typos have been fixed when we updated the design.
I'm closing this issue. Thanks!


Unable to use on Windows because of dependency on grep

When, after installing the latest version using pip on Windows 10, I import Scaper I get the following error:

'grep' is not recognized as an internal or external command,
operable program or batch file.

with traceback

Traceback (most recent call last):
File "C:\Program Files\JetBrains\PyCharm Community Edition 2017.2.3\helpers\pydev\pydevd.py", line 1683, in
main()
File "C:\Program Files\JetBrains\PyCharm Community Edition 2017.2.3\helpers\pydev\pydevd.py", line 1677, in main
globals = debugger.run(setup['file'], None, None, is_module)
File "C:\Program Files\JetBrains\PyCharm Community Edition 2017.2.3\helpers\pydev\pydevd.py", line 1087, in run
pydev_imports.execfile(file, globals, locals)  # execute the script
File "C:\Program Files\JetBrains\PyCharm Community Edition 2017.2.3\helpers\pydev_pydev_imps_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "E:/Github/how-noisy/util/create_soundscapes.py", line 6, in
import scaper
File "E:\Development\Python3\Anaconda3\lib\site-packages\scaper_init_.py", line 4, in
from .core import Scaper
File "E:\Development\Python3\Anaconda3\lib\site-packages\scaper\core.py", line 1, in
import sox
File "E:\Development\Python3\Anaconda3\lib\site-packages\sox_init_.py", line 19, in
from . import file_info
File "E:\Development\Python3\Anaconda3\lib\site-packages\sox\file_info.py", line 7, in
from .core import VALID_FORMATS
File "E:\Development\Python3\Anaconda3\lib\site-packages\sox\core.py", line 96, in
VALID_FORMATS = _get_valid_formats()
File "E:\Development\Python3\Anaconda3\lib\site-packages\sox\core.py", line 90, in _get_valid_formats
shell=True
File "E:\Development\Python3\Anaconda3\lib\subprocess.py", line 336, in check_output
**kwargs).stdout
File "E:\Development\Python3\Anaconda3\lib\subprocess.py", line 418, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command 'sox -h | grep "AUDIO FILE FORMATS"' returned non-zero exit status 255.

`

It's a sox problem. I changed on line 96 of sox/core.py:
VALID_FORMATS = _get_valid_formats()
to
VALID_FORMATS = ["wav"]
And now I can use Scaper again (with .wav files).


Add Brave Nightly icon

Add icon of brave Nightly too

Hello! Weʼre switching to a new system for icon requests in order to be able to better manage them. From now on, icon requests can be submitted here: https://forms.gle/Fx8vZAiWdW1Tyjo57. If your icon request hasnʼt yet been fulfiled, it has been copied to our new icon request database, meaning no action is required. Consequently, this issue will be closed.


added reply listening

It probably needs a bit more work and some testing, but here's a proof-of-concept :)

oof, already add that features in #721 lol
please look at PR tab to see if your upcoming PR is duplicated with other PRs.

#721 doesnt seem to have reply listening. You have reply sending (onya, i used your code) but not reply listening which i added :)

well, look like you're wrong, please look at file src/listen.js from line 319 to line 383.

I stand corrected. I would have liked replies to passed through the normal message pathway instead of having a separate 'message-reply' type, but I can live with that. Cheers.


[Feature] Support Compose Labels for an instant configuratiom

Description of the feature
Please consider supporting Docker Compose Labels. That way, the dashboard is automatically populated and additional configuration becomes optional.
For an example, see Plugsy:
https://github.com/plugsy/core
It's extremely simple to have an instant dashboard this way. With categories and parents etc.
Additional context
No response

Sorry, but I don't think this fits the project? Configuration is done via environment variables (and will be switched to yaml files in the near future). Unset variables fall back to a default value, so additional configuration is already optional.
It seems like you mistake Dashdot for a personal dashboard, where you display running services (like Homarr, Flame, ...) - this project does not offer such features.

I re-read the documentation, very sorry, my mistake!


Debugger

Now that very many more live processes can be running we should approach the design of the debugger again. It was only ever used for desperation-stakes postmortems of deadlocked or livelocked processes, so we were unconcerned about the vast volume of thread-backtrace output; and to keep things very simple we didn't use java monitoring technology.

Proof of concept implementation now offers choice of categories. Presence of html-generation methods will permit more refined interactions, with specific objects.

Log synchronization needs bringing up to date. Presently it uses java synchronised blocks.

Debugger interaction reimplemented a couple of months ago. We will wait for the next generation CSO before going further.


optimize code details pull-request, test=develop

PR types

Refactor
PR changes

Applications
Description

Refactor text_summarization for CI

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Activation] PowBlockDefinition - ensure we are calling validator cor…

…rectly #1934.
@noescape00 @bokobza

@Aprogiena

Okay I think


support package maligned

maligned checks if a struct could be smaller, it differs from aligncheck in that it provides more precise information (see https://github.com/golang/go/issues/12884)
https://github.com/mdempsky/maligned
thanks for considering

Note: currently it could be added by manually installing and then passing following additional argument to metalinter:
--linter='maligned:maligned .:PATH:LINE:COL:MESSAGE' --severity=maligned:warning
Where maligned points to end of the struct, aligncheck points to start of struct, based on examples

Do you have an example of where it is more precise, because it seems to be producing less information for me:
$ maligned cmd/compile/internal/gc cmd/link/internal/ld
/usr/local/Cellar/go/1.5/libexec/src/cmd/compile/internal/gc/esc.go:395:15: struct of size 232 could be 224
/usr/local/Cellar/go/1.5/libexec/src/cmd/compile/internal/gc/go.go:135:10: struct of size 120 could be 112
/usr/local/Cellar/go/1.5/libexec/src/cmd/compile/internal/gc/go.go:155:11: struct of size 224 could be 216
/usr/local/Cellar/go/1.5/libexec/src/cmd/link/internal/ld/ldelf.go:267:13: struct of size 208 could be 200
/usr/local/Cellar/go/1.5/libexec/src/cmd/link/internal/ld/ldpe.go:117:12: struct of size 144 could be 136
/usr/local/Cellar/go/1.5/libexec/src/cmd/link/internal/ld/link.go:123:11: struct of size 256 could be 240
/usr/local/Cellar/go/1.5/libexec/src/cmd/link/internal/ld/link.go:40:11: struct of size 296 could be 288

$ aligncheck cmd/compile/internal/gc cmd/link/internal/ld
cmd/compile/internal/gc: /usr/local/Cellar/go/1.5/libexec/src/cmd/compile/internal/gc/esc.go:395:6: struct EscState could have size 224 (currently 232)
cmd/compile/internal/gc: /usr/local/Cellar/go/1.5/libexec/src/cmd/compile/internal/gc/go.go:135:6: struct Sym could have size 112 (currently 120)
cmd/compile/internal/gc: /usr/local/Cellar/go/1.5/libexec/src/cmd/compile/internal/gc/go.go:155:6: struct Type could have size 216 (currently 224)
cmd/compile/internal/gc: /usr/local/Cellar/go/1.5/libexec/src/cmd/compile/internal/gc/go.go:80:6: struct Mpcplx could have size 72 (currently 80)
cmd/link/internal/ld: /usr/local/Cellar/go/1.5/libexec/src/cmd/link/internal/ld/ldelf.go:267:6: struct ElfObj could have size 200 (currently 208)
cmd/link/internal/ld: /usr/local/Cellar/go/1.5/libexec/src/cmd/link/internal/ld/ldpe.go:117:6: struct PeObj could have size 136 (currently 144)
cmd/link/internal/ld: /usr/local/Cellar/go/1.5/libexec/src/cmd/link/internal/ld/link.go:123:6: struct Link could have size 240 (currently 256)
cmd/link/internal/ld: /usr/local/Cellar/go/1.5/libexec/src/cmd/link/internal/ld/link.go:40:6: struct LSym could have size 288 (currently 296)

Note

yes, see the link to the go issue which is admittedly an edgecase

oh you mean for the same thing it provides more info, nevermind, cant read

Exactly, yes.
Both of these tools are quite slow and CPU intensive due to their nature, so I'd prefer to only integrate one. I have no preference which beyond "the best", but so far it seems that aligncheck produces better results?

sure, my mistake then, I thought it didn't cover the edgecase of a struct{} being the last member


Customise date time format

This PR allows users to customise their date time format, I have provided 6 options, if the number of options were to be expanded then the method of selection would need to change.
I have applied the users date format to all filament datetime() methods.
I have not applied it to the dates using Iso format.
There is already a fallback format applied via the .env file or tables config file.

Sorry, I just merged and did a few fixes, can you resolve the merge conflicts?

No problem, I'll take a look.

@Silver343 So where does the date time format change once I change it in my profile? I just updated it in my profile, but when viewing an item, the format isn't changing.

The format will change anywhere filament is being used to format it, this is mainly the resource pages and my page, in the other date times are formatted via carbons iso format, which can be customised but it is done via locale.
So I guess to do all date times would require to settings, one for locale and one for format of the filament dates.

I'm not sure how much of this would apply properly for the front end having this setting there then. Users that don't have admin access, will get confused about this setting as it doesn't change anything for them.

@Silver343 What do you think?

@Cannonb4ll I think you're right.
If the dates could be set similar to carbons iso format you could use a locale selector

For now I'm closing this, if you feel this needs to be opened again let me know.


Analyzer issues incorrect warning on inconsistent interfaces in mixin inference

The analyzer issues the following warnings on the code below:
  error • Type parameters could not be inferred for the mixin 'M1' because the base class implements the mixin's supertype constraint 'I<T>' in multiple conflicting ways at /Users/leafp/tmp/ddctest.dart:10:33 • mixin_inference_inconsistent_matching_classes
  error • A value of type 'int' can't be assigned to a variable of type 'String' at /Users/leafp/tmp/ddctest.dart:13:14 • invalid_assignment

Note that the second (expected) error does imply that the mixin inference is succeeding and inferring int as the type argument, but nonetheless the first (unexpected) error is emitted as if inference had failed.
class I<X> {}

class M0<T> extends I<T> {}

class M1<T> extends I<T> {
  T foo() => null;
}

// M1 is inferred as M1<int>
class A extends I<int> with M0, M1 {}

void main () {
  String s = new A().foo();
}

cc @bwilkerson @stereotype441 @yjbanov
This doesn't need to be fixed for the old super-mixin inference, but we need to be sure this works correctly with the new syntax since flutter uses this pattern.  I'll try to get some tests landed for this.

FYI, this may have been fixed(?). Not sure though. The errors I see now are:
  error • The class 'M0' can't be used as a mixin because it extends a class other than Object at test.dart:10:29 • mixin_inherits_from_not_object
  error • The class 'M1' can't be used as a mixin because it extends a class other than Object at test.dart:10:33 • mixin_inherits_from_not_object
  error • A value of type 'int' can't be assigned to a variable of type 'String' at test.dart:13:14 • invalid_assignment

if I change extends to implements I get this error:
  error • The class 'A' cannot implement both 'I<int>' and 'I<dynamic>' because the type arguments are different at test.dart:10:1 • conflicting_generic_interfaces

That makes me think the inference may not be working correctly.

There is no inference for implements clauses, so the errors are expected for the class example.  For mixins, the proposal here includes a section on inference, specified here.  I just landed tests for this here.

I'll look into this

This is the relevant reproduction for the new mixin syntax:
class I<X> {}

mixin M0<T> on I<T> {}

mixin M1<T> on I<T> {
  T foo() => null;
}

class A = I<int> with M0, M1;

void main () {
  String s = new A().foo();
}

I still see the incorrect error for this example (and actually don't see the correct error).
I believe that this case is covered by the tests that I added.

Note that this will be a blocker for migrating flutter.  cc @JekCharlsonYu

cc @yjbanov

Thanks for looking into it! Here a place in Flutter where we have to ignore an analyzer warning when inference fails.

A fix for the repro in https://github.com/dart-lang/sdk/issues/34404#issuecomment-422543630 is out for review: https://dart-review.googlesource.com/c/sdk/+/75625.
There are still a few of Leaf's test cases failing, so I'm going to leave this issue open until I've addressed them.

With 2e3f17fa2bf97f29d82a29b6fc42ccd5c9e0f350, the analyzer now produces the expected behavior for Leaf's example in https://github.com/dart-lang/sdk/issues/34404#issuecomment-422543630.  But that same example fails when the analyzer is run with the "--supermixin" flag is passed in.  The example at the top of this bug report also sill fails.
@yjbanov's Flutter code is in a similar situation: if I modify it to use "mixin" syntax and analyze it without "--supermixin", it works.  But if I analyze it with "--supermixin", it fails (regardless of whether old or new syntax is used).
So I think we are no longer blocking flutter's migration to the new syntax.  And I'm mindful of Leaf's statement that this doesn't need to be fixed for the old super-mixin inference.  But I'm bothered by the fact that the presence of the "--supermixin" flag mysteriously affects the new mixin syntax as well--that really shouldn't happen.  So I'm going to continue investigating for a bit longer.

Aha, glad I checked.  Supermixin error checking is still not working, but it looks like it's working because it's disabled when the "--supermixin" flag is missing.  Working on a fix.

Candidate fix out for review: https://dart-review.googlesource.com/c/sdk/+/75792.  This fixes and enables the error checking, and as a bonus, it fixes the test case in the original bug report (that uses the old "--supermixin" syntax).


Click event bindings do not work after navigating backward (native browser back) in iOS Safari

Version
3.0.1
Reproduction link
http://jsbin.com/hohewabama/1
Steps to reproduce
on an iOS device, in Safari:

Setup a view with an element with a @click event binding
click element to verify functionality
navigate away (either via routing or to some other link)
navigate back (cached view/state loaded by browser?)
click element and nothing happens

What is expected?
click behavior should execute
What is actually happening?
nothing is executed

The click does work, for some reason alert doesn't fire but that is probably a Safari bug, any other instruction works. You should report this bug to webkit 🙂

在点击safari里面自带返回键的时候，会有点击事件无效的情况，目前不知道是什么原因


Fix minor spelling (customizations) in 6.1 release notes

Just a few small spelling updates to align with our latest documentation styleguide.
I am still getting into the habit of using z not s.

I will merge in, CI is good and these are minor changes.


TabBarIOS paddingBottom Bug

Hello.
I'm using React Native 0.24.1 on Mac.
TabBarIOS has different top and bottom padding:

I tried to fix it with adding paddingBottom to TabBarIOS and TabBarIOS.Item, but of course it doesn't worked.
Is it a bug?
Here is my code:
import React, { AppRegistry, Component, StyleSheet, TabBarIOS, Text, View } from 'react-native'

class App extends Component {
  renderContent(pageText) {
    return (
      <View style={styles.tabContent}>
        <Text>{pageText}</Text>
      </View>
    );
  }

  render() {
    return (
      <TabBarIOS>
        <TabBarIOS.Item systemIcon="history">
          {this.renderContent('Tab 1')}
        </TabBarIOS.Item>
      </TabBarIOS>
    )
  }
}

const styles = StyleSheet.create({
  tabContent: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center'
  }
})

AppRegistry.registerComponent('App', () => App)

I don't think it's a bug - if you will take a look at all built-in iOS apps where this component is used, the paddings are like that. The style you pass to item is actually a style of the page, not the tab bar item itself.

Thank you @grabbou


working on RPi 3

Hi, we tested the setup on Raspberry Pi 3 Jessie, works like a charm.
Thank you !

Hi, thanks for feedback!
I will append that info on next README update
Tom


fix gen_prob

I changed the code so the C should have (1, *) shape, but not sure about the expected result for the test in the test_prod_cpm_sys_and_comps.

Thank you, but now "get_prob" does not work for previously working commands.
When "pf = cpm.get_prob(  Mnew, [varis['sys']], [0] )" is executed, it gives an error at "assert isinstance(M, Cpm)".
When I check what type M has, it shows <class 'BNS_JT.cpm.Cpm'>.
Do you have any idea..?

Not sure but it works when I tried. Please check test_prod_cpm_sys_and_comps.

Oh I found the issue. When a module is reloaded by importlib, it is assigned a slightly different name, and isinstance becomes confused : (


Data stays on the form when i reopen the form.

When i open form for the first time, it works perfectly. But if i close the form and reopen that screen at that time form field value auto populate even if i have not assign any value.

Issue solved, it stored the value of the previous state and not updating the states when state value is changed.


api: Include stream_id for all updates to stream messages

Updates the update_message event type to always include a stream_id field when the message being edited is a stream message.
This change aligns with the current definition in the \get-events endpoint in the OpenAPI documentation. Also, see this CZO chat.
Testing: Updated the testing schema for do_update_message in zerver/lib/event_schema.py so that the stream message fields (name, id, new) are separate from the content and topic fields in the update_message event. The updated testing schema also moves the flags and message_ids lists to the required fields because they are currently being returned for any edit / update to any type of message. Previously, those fields were listed as topic related fields.
Also added verification in zerver/tests/event_tests.py for the event returned for changes to: private message content, stream message content-only, stream message topic-only, stream message new-stream-only.

This is great, thanks for the cleanup @laurynmm!


Class libraries don't get precompiled views when publishing without Web.SDK

Due to how our factoring is being done in 2.1-preview1 - the necessary properties to activate Razor  compilation (using RazorSDK) during publish are part of the Web SDK. This means that a class library project won't do precompilation during publishing by default.
The workaround is to define a property that the WebSDK sets.
  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
    <ResolvedRazorCompileToolset>RazorSDK</ResolvedRazorCompileToolset>
  </PropertyGroup>

We plan to take ownership of these definitions from the WebSDK in 2.1-preview2 so this should just get solved at that point.

@pranavkm assigning you. We plan to leave the current behaviour for preview1, but this can be fixed now in preview2 since we control the evaluation order.

The last bit to enable here is to turn on RazorCompileOnBuild = true. This is blocked pending further details from inner-loop perf results.

Cool beans! Changing the title on this spicy boy!

Also, we have the perf numbers and everything looks good from that point of view. We'll do an experience review next week and then we'll be ready to go.

@pranavkm, is this unblocked already?

The experience review is unblocked and @ajaybhargavb's per PR also went in which was another blocked. I'd think this is. @rynowak any concerns?


Upgrade to C++20, delete GSL, fix some tests

Fixes #2242

GSL span is replaced with std::span, available in C++20 / LLVM 18
GSL Expects / Ensures is replaced with our own - the only reason for using GSL's variant was that we on a few occasions want to throw in unit tests. Not a good enough reason to keep GSL now that span is part of the standard.
The <common> header is split up into <expects> and branch_prediction renamed to <likely>
The .at() operator is replaced with [], since bounds checking is no longer done in the span. C++26 apparently fixes this.
std::shared_ptr::unique() is removed from C++20 since it's not thread safe. It's replaced with use_count() == 1.

Note the changes in Logger - we used to inherit from the span iterator, which created a dependency on the private span implementation no longer available. I've turned this into a standalone iterator, which compiles, but is not tested - we don't yet have unit tests and there is no integration test for the logger. If the review doesn't find any obvious blunders I suggest we merge this since it passes multiple integration tests - more than we've ever tested since nix, probably. I'm working on fixing unit tests, which should give us more confidence in the logger.
Tested with:

✅ time nix-shell --argstr unikernel ./test/net/integration/icmp6/ --run "./test.py"
✅ time nix-shell --argstr unikernel ./test/net/integration/udp/ --run "./test.py"
✅ time nix-shell --argstr unikernel ./test/net/integration/tcp/ --run "./test.py"
✅ time nix-shell --argstr unikernel ./test/kernel/integration/smp/ --run "./test.py"

All passing.

@fwsGonzo @AndreasAakesson would you like to review or should we go ahead and merge this? I've verified that it builds and boots :-)

LGTM


26049 run on api 14 android

Code changes to ensure tests can run against all android platform's we support.
These are:
Lower the minimum API level to 14 for the AndroidTest app
Add the system time in mills as a suffix for remote db names to avoid collisions

@rhyshort can you address my comments here so we can merge?

oops, I didn't notice your last comment, I'll get on that

Your PR says we're targeting API level 14 but your commit subject mentioned level 15 -- is that right?

oops the headline for that commit is a typo it should be 14. There a few issues with running on 14 and currently experiencing them on 15, both are issues with the emulators from what I can tell

So it looks like we're basically done if you rewrite the commit message to be correct? If so, +1 once the squashing and correction is done.

Yup that's correct, I'll go do that now


"Sync task ended successfully" notification cannot be dismissed on Android 11

The "Sync task ended successfully" notification cannot be swiped away or dismissed on Android 11.  Have to tap on it, which opens the app, to get it to go away.

Hi,
I tried with Pixel4A and Android Emulator, but could not reproduce the problem. Please let us know what kind of operation causes the problem.
The following is the operation in Emulator.
https://drive.google.com/file/d/12zlfFj7S8azmW9ONqbZKoLVN7ivXPf2e/view?usp=sharing
Best regards.

Hi,
I tried with Pixel4A and Android Emulator, but could not reproduce the problem. Please let us know what kind of operation causes the problem.
The following is the operation in Emulator.
https://drive.google.com/file/d/12zlfFj7S8azmW9ONqbZKoLVN7ivXPf2e/view?usp=sharing
Best regards.

Hi, thanks for looking at this.
Steps where I can reproduce issue:
Have a "Sync task ended successfully" notification from any SMBSync2 task, on a Samsung S10e with android 11 / oneui 3.0 with the 1/1/21 android security patch level (this is the latest available OTA software for the S10e).
Try to swipe notification away, are unable to.
This happens with both scheduled syncs and the StartSync widget.
It is listing SMBSync as an Alerting notification so the "Clear" option on the notifications drawer is disabled.
Expected behavior:
Notification can be dismissed, as you show happens properly in the emulator
I uploaded a video of the behavior I am seeing.  https://youtu.be/8-n7TRii-5g
Thanks again, please let me know if I can provide any further information or otherwise help.

Hi, thanks for looking at this.
Steps where I can reproduce issue:
Have a "Sync task ended successfully" notification from any SMBSync2 task, on a Samsung S10e with android 11 / oneui 3.0 with the 1/1/21 android security patch level (this is the latest available OTA software for the S10e).
Try to swipe notification away, are unable to.
This happens with both scheduled syncs and the StartSync widget.
It is listing SMBSync as an Alerting notification so the "Clear" option on the notifications drawer is disabled.
Expected behavior:
Notification can be dismissed, as you show happens properly in the emulator
I uploaded a video of the behavior I am seeing.  https://youtu.be/8-n7TRii-5g
Thanks again, please let me know if I can provide any further information or otherwise help.

Hi,
In the app, I have it set to onGoing(false), but for some reason it seems to be "On going notification".
Q1. Is the "Exit cleanly" option enabled? (Menu->Settings->Miscellaneous)

Q2. Is it an option in the system settings? Can you please be more specific?

It is listing SMBSync as an Alerting notification so the "Clear" option on the notifications drawer is disabled.

Best regards.

I have no issues on A Galaxy S20 with latest Android 11 from Samsung without modifying any stock settings about the notifications
Let me know if you need more info on the possible settings

After latest Samsung update on the S20, Android 11, i also get the issue. But it is random, about 3 to 4/5 times. I found no option in SMBSync 2 or system notificatiin settings to fix it. Let me know if i can provide more info. Notifications from other apps still act normally
Best regards

Hi,
I've tried to do the Notice message in a separate process to isolate the problem, so could you please test it?
https://github.com/Sentaroh/SMBSync2/commit/60bee52f018df6394134ecdb3a2e9f6e03a11562
Best regards.

Thank you
Yes, now it can always be dismissed
However, we get two notifications, and the ongoing flashing notification persists some seconds after then sync end/start result notification
I will wait for your next fix to test
Best regards

Hi,
It's fixed.(I tested : Pixel4a(SDK30), ZenFone5Z(SDK29), Huawei MediaPad M5(SDK28))
Could you please test it in your environment?
https://github.com/Sentaroh/SMBSync2/tree/2.48-1-fix-test-notice-message
Best regards.

Hi,
I tested on a Galaxy S20 latest Android 11 and Samsung updates. The problem is fixed, thank you.
I also tested on an Mi A1 with Android 9 and the emulator. It is properly working
Best regards

Hi,
Thank you.
Merged the changes into Branch2.48.
Best regards.

Hi,
After a scheduled task with two sync tasks, I get two success notifications:

One global Success notification
One about success of the last sync task

This is on a Galaxy S7 with Android 8.0. I did not have time to test more and I won't have access to the emulator in the next days
Best regards

Hi,
The following changes have been made.

In Android 28 and later, changed from startService() to startForegroundService()
On Android 28 or later, change from stopForeground(false) to stopForeground(Service.STOP_FOREGROUND_DETACH)

I was not able to reproduce the error in my environment, could you please test it?
Best regards.

I am away until next week, will test and report later
Thank you and best regards

Hi,
I could not test the latest changes.
However, here are pics of the bug I could catch on the previous 2.49 version, since I did not yet update:

This time it was on a Poco X3 with MIUI and Android 10. The icon was once flashing and once not. I include a video with it flashing despite it was done
https://youtu.be/KpXn_h3vYj4
The task was started manually, not by schedule. Pressed Home button and turned off screen until task is completed. I could reproduce 2 times, but not always

Ok, after further testing with latest changes, I could not get the double notification to persist
I can see that the task end notification is issued in the Notification log activity, but it doesn't persist in the display
I will report if I notice any anomaly in the various devices
Thank you and best regards

Hi,
Please try Ver2.51.
Best regards.

Hi,
I tested The latest version in emulator API 30, Galaxy S20 API 30, Poco X3 NFC API 29, Galaxy S7 API 27 and Galaxy Note 4 API 23
Both with manual sync (1 or 2 tasks) and by manual schedule start, sending app to background or exiting it
No issues noticed
Thank you and best regards


Remmina crashes Hyprland

after this commit https://github.com/hyprwm/Hyprland/commit/2636abca2dcf1eca2c0296bb817f644b8626a860 connecting through rdp with Remmina crashes Hyprland
hyprland.log
coredump.txt

check with 59a3c43913b0536112f3700251aea28768c6882e

works! Thank you


Rename ESP32 to XTensaLX6 and split crate into rt and base

This PR renames ESP32 (SOC name) to XtensaLX6 (CPU name) to align to convention of other platforms.
It also adds seperate xtensa-lx6-rt and xtensa-lx6 support (instead of just xtensa-lx6-rt).

r? @burrbull
(rust_highfive has picked a reviewer for you, use r? to override)

bors r+

cc @MabezDev

bors r+

@burrbull Thanks for the speedy review and merge.


RawRepresentable support

Hi, great library!
This pull request adds support for decoding RawRepresentable enums

Thanks for the contribution!
PR looks good, I ran the tests locally from the command line and they succeed. I'll check what's happening with Travis, merge and release a new version.

[Current coverage][cc-pull] is 98.31%

Merging [#1][cc-pull] into [master][cc-base-branch] will decrease coverage by 1.68%

@@           master         #1   diff @@
========================================
  Files           3          3
  Lines         104        119    +15
  Methods         0          0
  Messages        0          0
  Branches        0          0
========================================
+ Hits          104        117    +13
- Misses          0          2     +2
  Partials        0          0

Powered by Codecov. Last updated by [2d1c93e...e0e1ea7][cc-compare]
[cc-base-branch]: https://codecov.io/gh/lucianomarisi/JSONUtilities/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/lucianomarisi/JSONUtilities/compare/2d1c93e1baf335a22ef49e738d97c4e56c8d5b8b...e0e1ea76bdd60869b48d9c002a5198b7bfc694b8?src=pr
[cc-pull]: https://codecov.io/gh/lucianomarisi/JSONUtilities/pull/1?src=pr

Ok, I added another test and squashed with the existing test commit. 100% code coverage now 👍


[BUG] ValueError: numpy.dtype size changed

Please only report one bug per issue!
Describe the bug
I tried to run the following code in Thonny (under Python3), but I got Traceback, which indicates binary incompatibility:
from picamera2 import Picamera2
import Preview
import time
import cv2
picamera = Picamera2()
camera_config = picamera.create_still_configuration(main={"size":(1920, 1080)}, lores={"size": (640, 480)}, display="lores")
picamera.configure(camera_config)
picamera.start_preview(Preview.QTGL)
picamera.start()
#allow the camera to warm up
time.sleep(2.0)
#save image into file
picamera.capture_file("test.jpg")
picamera.stop_preview()
picamera.close()
#show image until a key is pressed
image = cv2.imread("test.jpg")
cv2.imshow("Image", image)
cv2.waitKey(0)
cv2.destroyAllWindows()
To Reproduce
Run with Python3, or in Thonny.
Expected behaviour
The program should start correctly.
Console Output, Screenshots
I got the following messages:
Traceback (most recent call last):
File "/home/anemethhunor/Desktop/beagyazott/gyak8/7_access_camera.py", line 1, in
from picamera2 import Picamera2
File "/usr/local/lib/python3.11/dist-packages/picamera2/init.py", line 11, in
from .picamera2 import Picamera2, Preview
File "/usr/local/lib/python3.11/dist-packages/picamera2/picamera2.py", line 27, in
from picamera2.encoders import Encoder, H264Encoder, MJPEGEncoder, Quality
File "/usr/local/lib/python3.11/dist-packages/picamera2/encoders/init.py", line 6, in
from .jpeg_encoder import JpegEncoder
File "/usr/local/lib/python3.11/dist-packages/picamera2/encoders/jpeg_encoder.py", line 3, in
import simplejpeg
File "/usr/lib/python3/dist-packages/simplejpeg/init.py", line 1, in
from ._jpeg import encode_jpeg
File "simplejpeg/_jpeg.pyx", line 1, in init simplejpeg._jpeg
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
Hardware :
Raspberry Pi Zero 2W with Pi Camera (wide).
Additional context
Nope

I forgot to mention, the aforementioned numpy module's version is 2.1.3


store tests: encode some invariants into prisms, add more tests

This looks the good to me, shall merge post-rebase.


update relay version to 5.0

And what?

hi @steida , I dont understand your comment, could you please elaborate?

Sorry, but this repo is over. https://github.com/este/este/issues/1712


Added functionality to allow polymorphism with sf::SoundSource

following on from #1094, which I stupidly had pulling from my master. Now pulling from it's own branch.

SFMLBuildMaster: Build this please.


streams: Use "archive stream" phrasing instead of "delete stream".

The previous phrasing was misleading in relation to what the action
actually does.
Discussed in https://chat.zulip.org/#narrow/stream/9-issues/topic/.2316971.20starred.20messages.20view and https://chat.zulip.org/#narrow/stream/2-general/topic/topics.20don't.20get.20deleted.20if.20you.20delete.20all.20messages.20in.20topic/near/1138690 Fixing this phrasing will probably also let us close #16971

@timabbott Fixes made.

Merged, after rebasing and adding a small change to the confirmation modal text.  Thanks @mateuszmandera!