[R] Collisions between column and function names cause error with uninformative message

Describe the bug, including details regarding any error messages, version, and platform.
Summarising over a set of columns, whose names include the name of the summarising functions throws an error, whose message is completely uninformative.
d %>%
  group_by(whatever) %>%
  summarise(across(all_of(list_of_variable_names), ~ mean(.)))

#Error: Error : object '..temp3' not found
#Call collect() first to pull data into R.

where # in temp# seems to be the index of the offending variable in list_of_variable_names - 1, or potentially could be its index in names(d) after grouping variable columns have been removed (I haven't investigated which it is).
Easy to fix by renaming the column first, but took a while to locate the problem due to the ambiguous error message. Also, I suspect the issue could be avoided upstream by escaping or otherwise disambiguating the column and function names.
Component(s)
R

Thanks for reporting this, can confirm it's reproducible; here's a reprex:
library(dplyr)
library(arrow)
tbl <- arrow_table(mean = 1:10, group_var = rep(c("a", "b"), 5))
tbl %>%
  group_by(group_var) %>%
  summarise(across(all_of("mean"), ~ mean(.)))
#> Warning: Error in eval_tidy(expr, mask) : object '..temp0' not found; pulling
#> data into R
#> # A tibble: 2 × 2
#>   group_var  mean
#>   <chr>     <dbl>
#> 1 a             5
#> 2 b             6

This reprex shows it's not just limited to across() contexts:
library(dplyr)
library(arrow)
tbl <- arrow_table(mean = 1:10, group_var = rep(c("a", "b"), 5))
tbl %>%
  group_by(group_var) %>%
  summarise(mean(mean))
#> Warning: Error in eval_tidy(expr, mask) : object '..temp0' not found; pulling
#> data into R
#> # A tibble: 2 × 2
#>   group_var `mean(mean)`
#>   <chr>            <dbl>
#> 1 a                    5
#> 2 b                    6


Modifications to support dash-daq R package development

This PR proposes to make three changes in support of building in R package support for dash-daq:

fix missing locationSlider entry and docstring in Slider.propTypes within Slider.react.js
update package.json with additional metadata for R package DESCRIPTION file
include JavaScript bundles in dash_daq (required by 'transpiler', will copy into R package inst subdirectory)

The initial R package has also been committed to this branch.

@rpkyle Would you be able to add these changes into the CHANGELOG under the next version (0.1.5)?

@rpkyle Would you be able to add these changes into the CHANGELOG under the next version (0.1.5)?

fixed in feb7b4ee47d4568e837307ef1692dea55b89c812

🎉  @shammamah mind giving me a dancing-themed emoji? 🙂

💃


is this link correct?

All links on the page are for videos, except for:
Azure Integration Runtimes for Data Flows
which goes to the blog.
https://mssqldude.wordpress.com/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf1bf12b-d61d-6af2-7198-23d77a74febd
Version Independent ID: bee73c9c-b8d5-cfc5-4570-bf604504d83d
Content: Mapping data flow video tutorials - Azure Data Factory
Content Source: articles/data-factory/data-flow-tutorials.md
Service: data-factory
GitHub Login: @djpmsft
Microsoft Alias: daperlov

@DrYSG
Thanks for the feedback and bringing this to our notice. At this time we are reviewing the feedback and will update the document as appropriate.

@DrYSG Thank you for pointing this out to me.  I am conferring with the Doc team.

@DrYSG I have created a pull request to fix the link.
It should have pointed to https://www.youtube.com/watch?v=VT_2ZV3a7Fc
Thank you for pointing this out to us! :)
Have a good day.


README.md change firmware upload instructions so we don't have to push the buttons on the board

This PR replaces the step where we needed put the board into bootloader mode and drag and drop the uf2 onto the board. The new step uses the arduino cli to do these steps with a single command.

Very cool! I will test this on a board in a couple hours and report back on how well it works.

Thanks for catching those typos!


SCIM2 User endpoint filtering users by multi attributes does not work with PostgreSQL database.

Description:
SCIM2 User endpoint filtering users by multi attributes does not work with PostgreSQL database.
Suggested Labels:
SCIM
Affected Product Version:
IS-5.8.0
OS, DB, other environment details and versions:
Primary DB - PostgreSQL
IS-5.8.0
Steps to reproduce:

Add a PostgreSQL database as the primary user store.
Create a few users and roles and assign the users to the roles
Use queries like the following:

curl --location --request GET 'https://localhost:9443/scim2/Users?filter=groups+EQ+Physicians+and+groups+EQ+Patients' \
--header 'Authorization: Basic YWRtaW46YWRtaW4='

Cause for the issue: SQL syntax error
Related Issues:
https://github.com/wso2/product-is/issues/7798

This issue can be closed, once a kernel version contains the fix is released.

Closing as per @tharindu-bandara 's comment as new kernel release was done


Fix build on FreeBSD 13

FreeBSD 13 added eventfd(2), which means that now having eventfd no
longer means that you'll also have epoll. This change updates
EventNotify to check for both eventfd(2) and epoll before trying to
use epoll.
Issue #7656

Cherry-picked to v9.0.x branch.
Cherry-picked to v9.1.x branch.


Feature/Add MessagesAndPurge to server

This PR is made on top of https://github.com/mocktools/go-smtp-mock/pull/173 and that one should be merged first.
PR Details
Allows both getting messages and clearing them at the same time.
Related Issue
https://github.com/mocktools/go-smtp-mock/issues/119
Motivation and Context
In tests, it is useful to be able to reset the messages stored in the server.
How Has This Been Tested
I added two tests
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the CONTRIBUTING document
[x] I have added tests to cover my changes
[x] I have run golangci-lint run from the root directory to see all new and existing tests pass
[x] I have run go tool cover to avoid test coverage degradation

I addressed comments.

I rebased this one.

I rebased this one.

New PR's you can create directly without forking due you have write access ;)


SockMan

Yo! There are two problems here:

In Sv2Connman::EventReadyToSend() it forgot to erase the sent message from the queue, so it kept sending the same message over and over again. Fixed by adding client->m_send_messages.erase(). This fixes the failure of BOOST_REQUIRE_EQUAL(tester.LocalToRemoteBytes(), SV2_HEADER_ENCRYPTED_SIZE + 6 + Poly1305::TAGLEN);
After this, at the exit it didn't properly interrupt SockMan. Fixed by adding interruptNet() in Sv2Connman::Interrupt().

Here is a patch: sv2sockman.diff.txt
The changes to sv2_connman_tests.cpp are not needed for the test to pass but I made them to unconfuse myself from the send vs recv interaction - since both ends of the connection are inside one program, I was confused what does it mean to "send" bytes. So I renamed a bunch of symbols to use the notation of "local" and "remote" and "local to remote" and "remote to local". Another possibility would be to use "us" and "them", e.g. "from us to them" and "from them to us". Feel free to ignore those.

Thanks. I'll apply your changes as well as the test clarifications.

Folded all of it into #50!


It seems ComicVine changed their website today.
Can no long get ComicTagger to work. Yesterday it was fine, but not now.
I'm on Win 10, Comic tagger .15-beta
Message on CLI is:
<urlopen error [Errno 1] _ssl.c:504: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure>

Probably due to the new forced SSL implementation?
https://comicvine.gamespot.com/forums/api-developers-2334/

Correct - since ComicTagger is using Python 2.7 and not Python 3+, the libraries used are defaulting to SSLv3 (which is blocked by ComicVine). However, I have found a way to get them to use TLS 1.0 instead.
I can provide further information and submit a pull request...

afuturefoe,
I am having the same issue.  Can you provide further information on how to use TLS 1.0

Maybe it's the same as #87, looking into it.

Same as #87, yes.
I was able to get it to work with the following:
import ssl
context = ssl.SSLContext(ssl.PROTOCOL_TLSv1)
resp = urllib2.urlopen( url, context=context )
return resp.read()

Thanks for the suggestion, it seems trivial to solve. Actually my problem is how to repackage the application for the various platforms, it seem I'll need lot of dependencies and the latest version of XCode refuses to install on El Capitan. This will require a little more effort..

I don't know if this will be any help, and I can't test it now, since I don't have a mac anymore, but if you need only the XCode Command Line tools, I seem to remember that I was able to get them installed from the terminal using only brew (https://brew.sh/).  Also, it may be that some of the dependencies that you needed to compile are now available  as pre-compiled packages through brew standard or third-party respositories (called Taps).

sudo port self update
sudo port install py27-pyqt4
sudo port install py27-configparser
sudo port install py27-beautifulsoup4
sudo port install py27-pil
python2.7 comictagger.py

Close this to move discussion on #87. I released a MacOS dmg with the fix, I hope. Let me know how it works. Many thanks @afuturefoe for your hints!


Does SUSE 12 supported for ASR Migration?

Is SUSE 12 Is supported for ASR Migration??
And what about the BTRFS File system.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 34d0f2df-de85-c6ab-eb01-f8e028b7f108
Version Independent ID: 5acb187c-f280-5c7d-14fc-7f07160cd50b
Content: Azure Site Recovery support matrix for replicating from Azure to Azure
Content Source: articles/site-recovery/azure-to-azure-support-matrix.md
Service: site-recovery
GitHub Login: @sujayt
Microsoft Alias: sujayt

@Anmolgan81  according to the support link: https://docs.microsoft.com/en-us/azure/site-recovery/vmware-physical-azure-support-matrix , it only supports: SUSE Linux Enterprise Server 11 SP3, SUSE Linux Enterprise Server 11 SP4  , I will add the author as well to confirm if this is up to date. @sujayt  Can you confirm if this is the case ?

I am trying to migrate a suse 12 os in azure, can you confirm if Azure supports suse 12??
I have uploaded the suse 12 os disk from vm ware to azure but am not able to boot the vm, is suse 12 is supported by azure?? This also uses BTRFS file system

The matrix is up-to-date. If it's not in there it's not supported.
Can we close this since it doesn't seem to be a content issue.
thx
#please-close

@rayne-wiselman Thanks for you response.


dogstatsd: try out a more zero-copy-ish approach

WIP.

Closing this as we merged it through three incremental PRs.


Text  / Subtitle added is not added into video after export

@wlanjie

This function is not implemented

@wlanjie we have added some features in this for text and stickers support. Happy to share.

Very good, please submit a pr

@shashankjha1994  @wlanjie  can you please help me out in this.

not implementation, do it yourself

@wlanjie we have added some features in this for text and stickers support. Happy to share.

Please help me I  also want  to add text  on my video


HDDS-2224. Fix loadup cache for cache cleanup policy NEVER.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
74
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1
mvninstall
31
hadoop-hdds in trunk failed.

-1
mvninstall
33
hadoop-ozone in trunk failed.

-1
compile
22
hadoop-hdds in trunk failed.

-1
compile
15
hadoop-ozone in trunk failed.

-0
checkstyle
26
The patch fails to run checkstyle in hadoop-ozone

+1
mvnsite
0
trunk passed

+1
shadedclient
850
branch has no errors when building and testing our client artifacts.

-1
javadoc
23
hadoop-hdds in trunk failed.

-1
javadoc
21
hadoop-ozone in trunk failed.

0
spotbugs
952
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
33
hadoop-hdds in trunk failed.

-1
findbugs
21
hadoop-ozone in trunk failed.

_ Patch Compile Tests _

-1
mvninstall
35
hadoop-hdds in the patch failed.

-1
mvninstall
38
hadoop-ozone in the patch failed.

-1
compile
26
hadoop-hdds in the patch failed.

-1
compile
19
hadoop-ozone in the patch failed.

-1
javac
26
hadoop-hdds in the patch failed.

-1
javac
19
hadoop-ozone in the patch failed.

-0
checkstyle
29
The patch fails to run checkstyle in hadoop-ozone

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
726
patch has no errors when building and testing our client artifacts.

-1
javadoc
22
hadoop-hdds in the patch failed.

-1
javadoc
20
hadoop-ozone in the patch failed.

-1
findbugs
33
hadoop-hdds in the patch failed.

-1
findbugs
21
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
29
hadoop-hdds in the patch failed.

-1
unit
27
hadoop-ozone in the patch failed.

+1
asflicense
34
The patch does not generate ASF License warnings.

2400

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1567

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8f7447798b62 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 1921e94

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-compile-hadoop-ozone.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1567/out/maven-branch-checkstyle-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/branch-findbugs-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-compile-hadoop-ozone.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1567/out/maven-patch-checkstyle-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common U: hadoop-hdds/common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1567/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thank You @arp7 for the review.
I will commit this to the trunk.


ng-bind-html with UI Bootstrap directives

I don't think this is directly an issue but I don't know how to do this. I'm trying to dynamically load content that uses UI Bootstrap directives but when the content is loaded UI Bootsrap components don't work. Being more specific, tooltips don't work. Here is the important code:

$scope.trustSnippet = function(snippet) {
          return $sce.trustAsHtml(snippet);
};

The HTML I'm trying to inject is:

Any clues?
TY

https://github.com/angular-ui/bootstrap#support


Update modal.less

More distance to right side to prevent modal--close sticking at scrollbar
Description

Questions
Answers

Why?
It doesn't look good.

BC breaks?
no

Tests exists & pass?
yes

Related tickets?

How to test?
Have a look

Requirements met?
hope so

Thanks @AyKuTmania.
Please do cross browser testing and provide a before and after screenshot to verify your change.

Here you are. Just tested in most recent Browser. Mobile-View looks same.

@shopwareBot
Done :-)

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-19200.
Please use this issue to track the state of your pull request.

Hey,
thanks for your contribution. Though your change improves the look on windows systems (more specific: on browsers/os that display the scrollbar) it looks odd on systems that hide the scroll bar. See the appended example taken from Chrome 61 running on Mac. Please keep that in mind when moving the control icon. (Maybe modernizr offers some features to switch depending on os/browser).

Dominic

Hey @tinect.
This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://developers.shopware.com/contributing/contribution-guideline/.


Pull Request Guidelines

Pull Request against any issues are accepted.
If you find any logical or syntax error in any codes, then you can pull request.
Don't pull requests to add any random codes or optimize existing codes.
If you want to pull any requests, raise appropriate issue and then work on it.
Don't pull requests to correct any typos or grammatical mistakes.

Not participating this year.


Facilities list is not visible

Current behavior

When login into specific oms, facilities count is visible on the home page but facilities list is not visible.
Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

[x] YES
[ ] NO

Environment details

Browser:
OS:
Code Version:

Additional information

Facilities list is not loading because the 'FACILITYVIEW' entity is missing from the specific instance. The app will work fine when new update comes of the instance.


Bump react-native-live-markdown

Details

This PR bumps the version of the react-native-live-markdown library to the latest. Also, it fixes the issue with  duplicating pasted text that occurred due to changes in web implementation in version 1.92 of the library. Because of this critical bug, we decided to replace the following PRs, fix the issue, and not create any deploy blocker:

#44913
#44881

Related PRs:

https://github.com/Expensify/react-native-live-markdown/pull/423

Fixed Issues

$ https://github.com/Expensify/App/issues/43983
$ https://github.com/Expensify/App/pull/44881
$ https://github.com/Expensify/App/issues/44185
$ https://github.com/Expensify/App/issues/43750
PROPOSAL:
Tests

Text duplication on paste

Go to any chat
Write some markdown text like *1234*
Copy or cut it
Paste it into the input and verify if the text was pasted only once. Also, check the cursor position if it's at the end of the pasted text

https://github.com/Expensify/App/issues/43983:

Go to workspace chat
Submit expense
Scan a receipt
Click on Description row
Start typing quickly
Open a chat where the keyboard will automatically be opened
Type quickly
Make sure nothing weird happens in the input (e.g. cursor position changing, typed letters being deleted etc)

https://github.com/Expensify/App/pull/44881

Submit an expense with a code block as the description
Open the transaction thread
Open the description
Verify there is no Parsing error: the processed text does not match the original Markdown input. error.

[X] Verify that no errors appear in the JS console

Offline tests

Same as Tests
QA Steps

Same as Tests

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/39538890/75f23953-a379-4bc7-ba04-3b37a2fded01

Android: mWeb Chrome

https://github.com/Expensify/App/assets/39538890/c4fdd2a7-9fb4-4202-94c4-8a5b100163ac

iOS: Native

https://github.com/Expensify/App/assets/39538890/830029b3-1ea1-421d-93ba-1b06e2b8c2d0

iOS: mWeb Safari

https://github.com/Expensify/App/assets/39538890/429117d5-8b30-4251-967e-b55a45a54091

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/39538890/8dd8bd84-0a23-4d90-bfc5-46b144fcf89a

MacOS: Desktop

https://github.com/Expensify/App/assets/39538890/78a526cf-1e92-48b6-a4c8-86bd144cf7a0

(Lets make sure to add the issues from the other PR here?)

https://github.com/Expensify/App/issues/43983
https://github.com/Expensify/App/issues/44185

Opening this PR for the C+ review. I will add Android videos tomorrow because I have some problems with emulator

Bug: Text duplication on paste
This is still reproducible. At first it works but after switching report the bug can be still reproducible
https://github.com/Expensify/App/assets/16493223/23749b83-12a2-4658-8f4c-5981c2718c29

@s77rt fixed! It should be working now :D

@Skalakid Still able to reproduce if I copy Composer content from report 1 and paste it into report 2
https://github.com/Expensify/App/assets/16493223/c9ccb3a4-c905-4282-85f9-a3f384927c34

@Skalakid Can you merge main and remove the patch that was updated now with the previous bump? thanks!

@s77rt I can't reproduce this issue now, have pulled the latest changes? If yes, try removing node_modules and running npm i again
https://github.com/Expensify/App/assets/39538890/d15be2da-1807-4053-96da-31308b6382cb

@mountiny done! Can you re-run check in this PR, please? Podfile check is failing even though file has been updated

@Skalakid Still reproducible after opening RHP
https://github.com/Expensify/App/assets/16493223/2cb0250f-0ab9-40a1-ad03-c0572ecf4ffb

@s77rt I totally forgot about focus/blur event listeners, it should be fixed now! :D

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/16493223/8ada6e9b-33d5-41fe-b7c0-3b4fb7976ea0

MacOS: Desktop

Going to move this ahead as it should fix CRITICAL newdot-quality task

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.7-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Help: I am in doubt about an object in L266.

https://github.com/wadpac/GGIR/blob/4d53aa1c1e959431bb6a99deb7ae3f1cdf883dd2/R/g.part6.R#L266-L277
Hi Vincent, can you provide a simple example of the object fragmode?

It is first "day" and then "spt", which means that the first time we calculate fragmentation metrics for daytime and the second time for spt time. This is what I explained in my email.


:seedling: migrate code review check to probes

What kind of change does this PR introduce?
structured results!

[X] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
eval code uses raw data
What is the new behavior (if this is a feature change)?**
eval code uses the results of the codeApproved probe. which I had to make a few minor changes to:

allowing out of platform review platforms (gerrit, phabricator etc)
allowing empty reviewer/login names

[X] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes
NONE

Special notes for your reviewer
I have questions!

codeApproved seemed like the better fit, so I just adapted that one. There could arguably be a split for "approvedInPlatform" or "approvedOutOfPlatform" for things like GitHub / GitLab native reviews vs Gerrit / Phabricator etc.
The probes take a proportional approach based on approvedChangesets and totalChangesets keys. We lose some better control over logging, so I'm thinking of switching to the "one finding per PR" approach.

Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

/scdiff generate Code-Review

@laurentsimon any thoughts on the "Special notes for your reviewer"?

codeApproved seemed like the better fit, so I just adapted that one. There could arguably be a split for "approvedInPlatform" or "approvedOutOfPlatform" for things like GitHub / GitLab native reviews vs Gerrit / Phabricator etc.

Iuuc, the advantages of separation would be:

Less likely that users ignore the type of review system by mistake when doing verification / applying a policy. The separation would make it more explicit
If there are different types of data we need to return based on the platform type, separation would make that cleaner. I'm not sure that will ever be the case? Wdut?

I think I lean towards separation due to (1).

The probes take a proportional approach based on approvedChangesets and totalChangesets keys. We lose some better control over logging, so I'm thinking of switching to the "one finding per PR" approach.

Do you mean "one finding per changeset"? I think having both probes (proportional and per changeset) is probably what we want. The proportional one is likely going to be what most people will use. Per-changeset probes will be used for manual troubleshooting and for policies where the non-reviewed bot contributions may be deemed acceptable... or something like that. Wdut?

The proportional one is likely going to be what most people will use. Per-changeset probes will be used for manual troubleshooting and for policies where the non-reviewed bot contributions may be deemed acceptable... or something like that. Wdut?

From a scorecard perspective, a per-changeset approach would allow debug messages. I wasn't envisioning having two versions of the probe, but rather trying to decide between the two.
If we split the codeApproved we would have to do per-changeset or we wouldn't be able to make a decision about accepting in/out-of-platform for each PR.

re: splitting probes. In an offline sync last week, the three of us agreed splitting probably makes sense.
For time reasons before the prerelease/OSS NA, I'll save it as a follow-up PR, so at least the probe is converted

/scdiff generate Code-Review


Crashes on iPad while rotating. iOS 8 version.

The app crashes when I rotate the iPad on selecting the images. It's not happening frequently. Any solution for this?
Please find the logs below
-[UISplitViewController _calculateDelegateHiddenMasterOrientations] + 60
0
Crashed: com.apple.main-thread
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000000

Sorry, development of this project is suspended. Please read the home page.

@SheikSulaiman Did you ever find a solution for this? Struggling with the same issue now


SILGen: disambiguate apply overload

The anonymous universal initialiser would result in ambiguous selection
of the constructor.  Name the type being constructed.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @slavapestov

@swift-ci please smoke test and merge

Fair enough. I'd prefer SubstitutionMap() but its no big deal

I can change them in a follow up.  Want to get things repaired first.

@compnerd I'm changing it in https://github.com/apple/swift/pull/24267


mobile grpc: expose cancel method on a stream

Commit Message: Expose cancel method on a gRPC stream.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Also should we update the other APIs to have cancel as well?

What other APIs are u referring too? Is if forGRPCStream? I think that I covered all of the existing implementations (Kotlin and Swift) but let me know if this is not the case.


Display a progress message when probing Java toolchains

Expected Behavior
If you use Java toolchains, for example:
java {
    toolchain {
        languageVersion = JavaLanguageVersion.of(11)
    }
}

Then Gradle will probe (and cache) the result of probing each of the recognized JVMs, but it won't indicate in the progress bar that it's doing so.
Current Behavior
When you have a lot of JDKs installed in "standard" locations that Gradle can detect (e.g SDKMan!), probing the JVMs can take a few seconds, resulting in a build apparently "stuck" when it's actually probing the JVMs.
Context
This scan shows a very basic app which doesn't use toolchains: https://scans.gradle.com/s/x335gxpgydqhg
Now add the following code snippet to your build script:
java {
    toolchain {
        languageVersion = JavaLanguageVersion.of(11)
    }
}

In this build scan it only took 2s, but in my previous test it took up to 11s (I guess because there's a cache of probed JDKs living somewhere or that now I have my OS caches warm).

Thank you for your interest in Gradle!
This feature request is in the backlog of the relevant team but this area of Gradle is currently not a focus one so it might take a while before it gets implemented.

If you are interested in contributing to Gradle, this issue is actionable and ready for contribution but might be challenging for first time contributors.
See CONTRIBUTING.md for more information.


Feature/dart2.0.0 update

Hey there, I've updated the lib to be compatible with Dart 2.0.0
I've also removed the quiver_iterable dependency as it was only required to get the min value of an array. I replaced it with reduce and min from the built-in math library.
The tests runs fine.

Hello @kseo
Any update on this PR? :D

@Outpox Sorry for being late to respond. I no longer maintain the package. I will give you the admin permission if you want to take over the package.

Hey @kseo !
No problem, I'm willing to over the package :-)

@Outpox Okay. What's your email address? I will add you to the list of uploaders.

Great, thanks!

@Outpox I've sent an invitation to you. You will be added as uploader after you confirm it. Thanks!

Invitation received and accepted! Thanks to you too :-)


DIfferentating between CPU and GPU versions of Deep Learning in Installed applications view

I haven't found anything different between CPU and GPU installation yet (other than the fact that the GPU onetakes more space). I'll have to ask the devs about it.


Build command: Better platform target support

Currently win means Win10, but electron can produce apps for Win8 and 7 as well.
The same is for Linux (which is just ubuntu for us) and mac...

This PR may address building apps for Win7 as well as OSX and Linux so apps built for each of them will run on any of the platforms supported by .NET Core 2.0. https://github.com/ElectronNET/Electron.NET/pull/38.

With the PR of @Petermarcu it should be working fine. Before the PR only the Electron Packer did produce "neutral" OS builds, now the .NET Core side should work on all supported OSs.
Thanks @Petermarcu!

hello !
I have the following issue in trying to instal the CLI package:
Package 'ElectronNET.CLI 0.0.5' has a package type 'DotnetCliTool' that is not supported by project 'MyElectronMusicPlayer'
I mention I have
  <ItemGroup>
    <DotNetCliToolReference Include="ElectronNET.CLI" Version="*" />
  </ItemGroup>

im my csproj file

Then it should be fine - CLI extensions are a bit different then normal packages.


Hypothesis: Initial support

Supersedes #60, we are redoing it to split off the various part.
This only contains the basic scaffolding to be able to write Hypothesis tests, no new tests or functional changes.

Sorry, this PR also kinda got away a bit.

Addressed everything.
Not super happy with the name .convert(), but I couldn't come up with a better one.


Service details UI issues

[x] Add space between Service:

[x] Make Image column smaller and move Node to the left so that we have more room for Node

[x] Move Age Column label to the left so it's left aligned?

[ ] The line is missing from bottom of pods (like Ports)

[x] The text color for the tables seem to be random and we need to make them look better.

Date - 11/14
Verified fixed.


Limit padded record to max plaintext

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

OK, I think I killed two birds with one stone...

Pushed. Thanks!


botocore/botocore/data/ssm-incidents/2018-05-10 /waiters-2.json = Formatted Differently than other waiters-2.json Files

Describe the bug
The problem is that the botocore/botocore/data/ssm-incidents/2018-05-10 /waiters-2.json file is formatted differently than all other waiters-2.json json files.
Expected Behavior
I expect all .json files in a given repository to be formatted similarly.
Current Behavior
The particular json file is not formatted in the same manner as other .json files.
Reproduction Steps

View the file here: https://github.com/boto/botocore/blob/develop/botocore/data/ec2/2015-03-01/waiters-2.json
View the file here: https://github.com/boto/botocore/blob/develop/botocore/data/ssm-incidents/2018-05-10/waiters-2.json

Possible Solution
I will provide a PR.
Additional Information/Context
I don't know if there is a linting tool for json files but it would be nice if all of these files conformed to a similar standard.
SDK version used
1.34.85
Environment details (OS name and version, etc.)
macOS, 14.2.1 (23C71)

Hi @colinbjohnson thanks for reaching out. The latest EC2 waiter models are in this file. Can you specify the differences you're seeing? Looking at these two files, they seem to follow the same basic structure (apart from the order of keys, and the ssm-incidents file containing a description):

Have you observed any inconsistencies in functionality between the waiters, or can you provide more context on your use case?
Waiters are also now maintained by service teams, so if any bugs or feature requests involving waiters would likely need to get forwarded to the corresponding service team. But minor formatting changes may not get prioritized unless there is some use case in which you are blocked.

Two things to look at (which a linter might catch <- I just don't know if there are linters available that can catch these things):

The acceptor configuration in most waiters files utilize list items that end on one line and start on the next line:

Typical acceptor block:
},
{

as opposed to a single-line format used in botocore/botocore/data/ssm-incidents/2018-05-10 /waiters-2.json:
}, {

The number of spaces after a "key" in most waiters files is typically 0 spaces whereas in botocore/botocore/data/ssm-incidents/2018-05-10 /waiters-2.json it is 1 space.

Typical waiters file:
"operation": "GetReplicaSet"

Versus botocore/botocore/data/ssm-incidents/2018-05-10 /waiters-2.json:
"operation" : "GetReplicaSet"

I completely understand how this wouldn't be a priority but I'd also be open to submitting a (separate) PR that includes JSON linting. My own hope would be that something (admittedly small) like JSON linting would help establish the importance of consistency across a codebase and across AWS teams.

Thanks for following up and expanding on the issue. I brought this up with the team for discussion and the takeaway was that this would need to be addressed by the service team. The reason is because waiter models are shared across SDKs, and any changes we would make to the models would be overridden by changes made by the service teams.
That being said, I think we should strive for consistency among these models. If you have a support plan then I recommend reaching out through AWS Support requesting that the SSM team update the format of their waiter model. Alternatively, you can create an issue in our cross-SDK repository and someone can reach out on your behalf.


Beta

[flutter_tools] update feature defaults (#102937)

'Create candidate branch version flutter-2.13-candidate.5 for beta'

'Update Engine revision to 44e5b38ee83a1282981a30abc08ffcf6cd0e44bd for beta release 3.1.0'

Update features.dart (#102766)

Remove armv7 codesigning.

Co-authored-by: Christopher Fujino<EMAIL_ADDRESS>Co-authored-by: Tim Sneath<EMAIL_ADDRESS>Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

finished


Improve static events

A common pattern across surface modules (and any app using this) is to use hardcoded events.
This is very likely most of the use of this package, not the external events, where it does make sense to create event manually as the trigger is also external to the code.
For the hardcoded events, the code requires the event to exist so it will usually include the data migration to create it (boring).
This change, EventRef, allows the code that creates notifications to reference the event using an instance of this class (instead of the event name: str)
There's a post_migrate signal handler that will create every event found in the code (instances of EventRef) so manual data migrations are not longer required.
Added bonus is that this invites developers to actually define the events as constants instead of using the name string everywhere, avoiding typos.
Caveat is that the EventRef variable has to be defined in some module that is imported automatically so the variable is instantiated (and registered) before the signal is received.
There's an easy choice for it though: models.py even if no models are defined in the app (admin.py is another, if django-admin is used, but models.py makes less-less sense).
Hopefully, the small diff is better explanatory.
I meant to document this but I noticed README.md is quite behind (close to non-existent) so I'll leave that to another PR!
I would prefer to have some system that would create actual migrations under the consumer app instead of running every time after migrate but I couldn't find any hooks for that and this looked like an acceptable alternative (as it only runs with migrate anyway)
No breaking changes introduced
Also, description added to events, as the name alone sometimes might not be explanatory enough (even more for manually added external events)
Feedback welcome!
(mildly related to #6)

Codecov Report
Base: 80.80% // Head: 81.28% // Increases project coverage by +0.47% :tada:

Coverage data is based on head (437f58f) compared to base (2f558a3).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   80.80%   81.28%   +0.47%
==========================================
  Files          13       14       +1
  Lines         521      545      +24
==========================================
+ Hits          421      443      +22
- Misses        100      102       +2

Impacted Files
Coverage Δ

notifications/admin.py
61.73% <ø> (ø)

notifications/models.py
93.82% <85.71%> (-1.70%)
:arrow_down:

notifications/apps.py
100.00% <100.00%> (ø)

notifications/migrations/0004_event_description.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Just remembered that this has another caveat...
When there is an unnapplied migration, django warns about it (with any command). With this approach there's an hidden pseudo data migration that django won't warn about.
When the app is freshly installed, it shouldn't be an issue as there will be other migrations to apply (and this will be triggered as well), but if events/notifications are added later, upgrading to the new version won't warn about those.
But again, I couldn't find anythin to generate actual migrations... 🤷

Converting this to draft so documentation is also updated before merge:

section on how to use from code (where this change is included)
section on how to use external events (be sure to include token and curl example)


Use ServiceWorker for offline support

Useful Links:

https://www.youtube.com/watch?v=IIRj8DftkqE

Chrome Dev Summit 2016 has a talk about webpack plugin for sw, that sounds like an elegant solution really !

Supported by 29c1915


fix(connector management): resolve cache issue in details overlay

Description
do not show regular overlay when error detail is shown. refetch connector details to fix cache issue in the details overlay
Why
wrong connect info shown behind error overlay
Issue
Link to Github issue.
Checklist
Please delete options that are not relevant.

[x] I have followed the contributing guidelines
[ ] I have performed IP checks for added or updated 3rd party libraries
[ ] I have created and linked IP issues or requested their creation by a committer
[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally
[ ] I have added tests that prove my changes work
[ ] I have checked that new and existing tests pass locally with my changes
[ ] I have commented my code, particularly in hard-to-understand areas

@gopalreddy-bmw kindly share ticket info for this issue. I did not find it in the board

@lavanya-bmw @kunalgaurav-bmw Please review


Can I use hikariCP with ReplicationDriver?

Environment
HikariCP version: x.x.x
JDK version     : 1.8.0_111
Database        : Mysql
Driver version  : x.x.x

Cool solution. Currently we run one slave and multiple slaves on Amazon RDS. We use ReplicationDriver with c3p0 in a spring/hibernate application.  We control transaction in Spring. All write transaction goes to db1-private (master) and read go to slaves (readonly)
We have following configures:
 <property name="driverClass" value="com.mysql.jdbc.ReplicationDriver"/>
 <property name="jdbcUrl" value="jdbc:mysql://db1-private:3306,db2-private:3306/mydb?autoReconnect=true&failOverReadOnly=false&roundRobinLoadBalance=true&characterEncoding=utf8"/>

I wonder if it is available to do same in hikariCP?
Thanks, Ian

Have you searched the CLOSED issues already? How about checking stackoverflow?

@yiwong2001 The MySQL Replication driver is not supported.  Please follow the discussion here:
https://github.com/brettwooldridge/HikariCP/issues/625


Update esp idf readmes

Update readmes for ESP-IDF examples to reflect most current code changes.

I force pushed the release branch so you'll need to rebase, but changes LGTM!

Let's merge to main so the release branch is just release stuff and doesn't have fixes


not compatible with django

each worker created is trying to create a new database test_ which is already created by other workers

Maybe https://pytest-django.readthedocs.io/en/latest/usage.html#running-tests-in-parallel-with-pytest-xdist is a usable solution?


Add jon's bio

great PR! I think you're the first to get everything on the first try! Bio, card, photo, and icon! 💯

@plhnk haha thanks, @abelhancock graciously helped me through it. 👍


Adding National Institute of Technology, Andhra Pradesh

a link to the site:
https://nitandhra.ac.in/

@LowNightSnack Pull request merged. Thank you!


Optimize leaderboard page with int rating columns

At present rating and prev_rating columns are in string and hence normal orderby and limit helpers couldn't be used.

Deploy plan -

Add the columns in auth_user and custom_friend
Copy columns rating and prev_rating to stopstalk_rating and stopstalk_prev_rating respectively. (Do this just before step 3 and stop the update-leaderboard crons)
Update the code to use new columns (Make sure this doesn't break locally)

Benchmarking the page timing after this issue indicates that most of the time is consumed in creating the html in the controller. Issue #247 will help in reducing the load times. We can try handlebars too for the same, let's see if raw js DOM creation helps


Fix bug #20027

How to Fix Multiple Tabs can become .active at once #20027
Original Fix here in this js:
https://www.dropbox.com/s/eg235dwr8clpny8/bootstrap.js?dl=0
I changed var into let. I do not know if this is the way to do it. Please check it.

Successor: #20039


One build to rule them all

Support for mixing different protocols in same workflow

Try to use Jacksons polymorphism functionality.
Hint: first map by app version then by class app property.


Form Validation breaking submit event

Hello,
I just found out that while using the form validation feature of semantic ui by adding a js code like the following to the page, Meteor is not able to get the submit event from the form anymore. Removing the code solves the issue.
$('.ui.form')
        .form({
            email: {
                identifier: 'email',
                rules: [
                    {
                        type: 'empty',
                        prompt: 'Please enter a valid email'
                    }
                ]
            },
            password: {
                identifier: 'password',
                rules: [
                    {
                        type: 'empty',
                        prompt: 'Please enter a password'
                    }
                ]
            }
        });

Is this a bug or something wrong on my end?
Thank you

I've just found out that semantic ui overrides meteor events. So instead of capturing events in meteor, use semantic callbacks:


Joint.parent needs to be updated in BasePartObject.init

I have a custom Part with some predefined joints, but the joints only work "partially"
Joints have moved to the correct position, but part has not:

A simple fix is updating the parent, but it seems conflicted with multiple active locations
diff --git a/src/build123d/objects_part.py b/src/build123d/objects_part.py
index 483dc7b..aa030f6 100644
--- a/src/build123d/objects_part.py
+++ b/src/build123d/objects_part.py
@@ -97,6 +97,8 @@ def __init__(
             new_part = new_solids[0].wrapped
         else:
             new_part = Compound.make_compound(new_solids).wrapped
+        for joint in part.joints.values():
+            joint.parent = self

         super().__init__(
             obj=new_part,

https://github.com/gumyr/build123d/blob/fb6f47471ffaeca9c7feaae372ded7812c22430f/src/build123d/objects_part.py#L87-L90
All solids share one joints, can we make the type of Shape.joints to list[dict[str, Joint]] when in a Locations context?

I read the Joint Tutorial again and found that the base class should be Compound, sorry for the bothering :disappointed:


Pill shape announcement refresh

https://github.com/kodadot/nft-gallery/assets/90852205/8aaf2761-19dd-45d9-8fe3-08ddb7a722f6
cc @hassnian feel free to pickup

👋


DPG, expose required query/header parameter in client method

And these query/header would not appear in Javadoc.

One thing about query parameter is:
Currently all parameter is mapped to String https://github.com/Azure/autorest.java/blob/main/javagen/src/main/java/com/azure/autorest/mapper/ProxyParameterMapper.java#L65-L71
Do we actually want basic types like boolean, int, long?
What about query as array, like CSV.
If we want, CSV can be done as String.
But "multi" (or "explode") cannot be done as merely a String in URL query, as it need to be param=value1&param=value2&param=value3.
@srnagar

Summary so far.

simple type is allowed, including String, int, boolean, date-time, duration, etc. (exclude Model and Enum)
List or Iterable is allowed, if the parameter is type=array. the element of the array is simple type


How to contribute?

I would have benefited from a hacking.md or Contributing section added to the README.
After grokking how generator-donejs ties into both donejs/cli and donejs/donejs, I was able finally to deduce the following steps, and see the result of my edits in generator-donejs/plugin:

Clone donejs/generator-donejs.
Run npm link within the cloned directory.
Make a new temporary directory for testing.
Run npm link generator-donejs within that new testing directory.
Finally, donejs add plugin will use the linked generator, because it already exists there.

If there is a better way of setting up this project to hack on it and test generator changes, I'd like to know.
Assuming documentation does not already exist regarding how to set this up, an explanation of these steps would be very helpful for new contributors like me! Thanks 👍

Closing for https://github.com/donejs/donejs/issues/295

Reopening this because it won’t be covered by https://github.com/donejs/donejs/issues/295

If you just want to work on the generators specifically, you can follow the Running the Generator steps from http://yeoman.io/authoring/index.html. Perhaps we should just link to that?

@phillipskevin The yeoman docs did help with that respective part of the initial steps. However, the yeoman docs did not help when it came to testing a modified generator in concert with other repos I had cloned locally that consume said generator (specifically, donejs/cli and donejs/donejs).
Imagine if I was updating some dependencies across all three of these repos, and I wanted to make sure everything was working nicely together without having to publish to NPM and reinstall DoneJS or something crazy like that; this is when the workflow outlined above is absolutely necessary and not documented anywhere.
For example, it's the only way that I imagine to test specific version combinations of the repos locally, and I felt it was probably most responsible to test my generator modifications within the context of the entire ecosystem like that workflow outlined in the guides.

At least, I think that's where I was going with this; it's been a while.

Related — Using DoneJS with local copy of CLI to generate app:
https://github.com/donejs/cli/pull/82#issuecomment-289615878
Not sure if there's a better way of doing this without editing that file and injecting the path?

Related — https://github.com/donejs/donejs/issues/852#issuecomment-289255817

@leoj3n, for using a local copy of the CLI, can't you just use npm link? Maybe I'm missing something because I don't quite follow the comment you linked to.

@phillipskevin Unfortunately (IIRC) that won't work, because that NPM command will overwrite whatever you link in because the syntax is<EMAIL_ADDRESS>which forces it to come from the cloud.


Remove server component check after first

I noticed the tests were running slow and it's because we're checking if the server component is installed on every single test.
We only need to check if it's installed in the first test case, then we check the local property after that.

Would it be better to push logic into ServerComponent.initialise() so that it simply knows the install check is completed? Such a change would be safer if the order of the test cases (or functional code) ever get shuffled

No. I think the purpose of initialise is correct. Though, I do think long term 'installed' should be private and there should be a method that returns a Boolean instead.

No. I think the purpose of initialise is correct. Though, I do think long term 'installed' should be private and there should be a method that returns a Boolean instead.

that makes sense. I like isInstalled()


Restart from a given step number

Dear authors,
thank you very much for the useful tool. I was wondering if there is a way to restart from a given step number (not the last one). I tried the --max-iter option but with poor results.
This is usually needed because in NVT runs also the data about the thermostat must be restarted, which are contained in the md.out file. However, the program writes this file after the geo_end.xyz one, so that if the run crashes for some reason (e.g., exceeded wall time), one cannot restart from the last step written in the trajectory file, but must select the last step for which the thermostat parameters have been written.
Also, adding a restart function for the thermostat in the python script would be very useful.
Thank you in advance.
Regards,
mbusato

Thank you very much indeed for the new implementation.
I've already struggled with the thermostat restart, it deals with adding the x, v, and g values to the "Thermostat" section in the input file. These values are found in the md.out file and of course must correspond to the coordinates and velocities of the atoms (they should all come from the same step). In the input file this section will look like:
Driver = VelocityVerlet{
TimeStep [fs] = 1.0
Thermostat = NoseHoover {
Temperature [Kelvin] = 300
Restart{
x{0.5351263186E+00   -0.1683933163E+02    0.1823564082E+03}
v{-0.1247999924E-04    0.1478896869E-02    0.2247293460E-04}
g{-0.1334724571E-06   -0.5074570642E-05   -0.3197689450E-05}
}
CouplingStrength [cm^-1] = 3200
}
Don't hesitate to ask if you need further information. Let's collaborate on this.
Regards

Thank you for explaining how to deal with thermostat restart.
I think I have understood what to do next.

Would you say that the two forms are equivalent?

Yes. In my understanding, these two are equivalent and the later is more explicit.

The 4th column of geo_end.xyz records simple Mulliken valence of each atom at each step. However, they do not contain orbital-resolved information (as stored in charges.bin or charges.dat), which is needed to restart MD.
Therefore, now I suspect that restarting from a step which is not the last seems to be impossible, excepting some specific cases (e.g., fully closed shells).

@mbusato0
Sorry for the late response.
I have enabled thermostat restart as merged in the above PR.
Thank you for your kind suggestions.


Defang Email

Hi,
like your project. Might be a good idea to add defanging for email addresses.
For example replace @ with  (at)

Thanks @modtastic ! I'll add that.


Add minification

I'm not sure minification is warranted here. I expect most consumers that are concerned about file size are using bundlers which will perform this minification for you.


Error about TEA written to excel as null value

Hello, when I execute TEA, the cost of each unit in Itemized costs in output excel is 0, the Utility of each unit is also not displayed in Utilities in excel, and there are many empty values in cash flow in excel. When code tea.TCI is calle, 0 is returned, which seems wrong. May I ask you how to solve this problem? Thanks for your help.
The code I use is as follows.
class TEA(CellulosicEthanolTEA):
    _TCI_ratio_cached = 1
    def _FCI(self, TDC):
        self._FCI_cached = FCI = TDC + self._nondepreciable_indirect_costs(self._DPI_cached)
        return 0.5 * FCI

def create_tea(sys, OSBL_units=None, cls=None):
    if OSBL_units is None: OSBL_units = bst.get_OSBL(sys.cost_units)
    try:
        BT = tmo.utils.get_instance(OSBL_units, (bst.BoilerTurbogenerator, bst.Boiler))
    except:
        BT = None
    if cls is None: cls =TEA
    tea = cls(
        system=sys,
        IRR=0.10,
        duration=(2024, 2044),
        depreciation='MACRS10',
        income_tax=0.35,
        operating_days=0.9*365,
        lang_factor=None,
        construction_schedule=(0.08, 0.60, 0.32),
        startup_months=3,
        startup_FOCfrac=1,
        startup_salesfrac=0.5,
        startup_VOCfrac=0.75,
        WC_over_FCI=0.05,
        finance_interest=0.08,
        finance_years=10,
        finance_fraction=0.6,
        OSBL_units=OSBL_units,
        warehouse=0.04,
        site_development=0.09,
        additional_piping=0.045,
        proratable_costs=0.10,
        field_expenses=0.10,
        construction=0.20,
        contingency=0.10,
        other_indirect_costs=0.10,
        labor_cost=1000000,
        labor_burden=0.50,
        property_insurance=0.007,
        maintenance=0.03,
        steam_power_depreciation='MACRS10',
        boiler_turbogenerator=BT)
    return tea

sys_tea = create_tea(sys)

print('MPSP:',
      format(sys_tea.solve_price(product), '.2g'),
     'USD/kg')

sys.save_report('product.xlsx')

@zasddsgg
When you open issues, please make sure you include ALL codes needed to reproduce the error. For example, your codes above don't include how sys was created.

Thank you for your advice. I built the system according to the BioSTEAM tutorial, and the relevant price has been set. The code of the system can also run normally. However, after running the code of TEA, although MPSP can be calculated normally, the related results in excel exported are empty.

I guess it may be because the process is too complicated, because there is result in excel exported when I executed TEA before, but after I added several additional units, there is null value in excel exported after executing TEA. May I ask if there is any way to solve this problem? Thank you for your help.

@zasddsgg, we cannot help you unless we can reproduce the error (and we cannot reproduce the error unless we have the code). Please include minimal example (using the least amount of code) with which we can reproduce the error. This template should help:
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
A script or a text file that runs the code to reproduce the error.
Expected behavior
A clear and concise description of what you expected to happen.
Actual behavior
Full trace back, as text or a screenshot
Version

PyPI  version or github

Additional context
Add any other context about the problem here.

I updated the latest version of biorefineris (2.32.1) and biosteam (2.47.0), and the following error is displayed. It seems that the nan value was encountered during TEA execution. Could I ask you how to solve the nan value problem during TEA execution.
RuntimeError                              Traceback (most recent call last)
File D:\anaconda\envs\zddd\lib\site-packages\biosteam\_tea.py:987, in TEA.solve_price(self, streams)
    986 try:
--> 987     sales = self.solve_sales()
    988 except:

File D:\anaconda\envs\zddd\lib\site-packages\biosteam\_tea.py:1016, in TEA.solve_sales(self)
   1015     if np.isnan(taxable_cashflow).any():
-> 1016         raise RuntimeError('nan encountered in cashflow array')
   1017 args = (taxable_cashflow,
   1018         nontaxable_cashflow,
   1019         depreciation,
   1020         sales_coefficients,
   1021         discount_factors,
   1022         self._fill_tax_and_incentives)

RuntimeError: nan encountered in cashflow array

During handling of the above exception, another exception occurred:

RuntimeError                              Traceback (most recent call last)
Cell In[23], line 96
     93     return tea
     94 tea = create_tea(sys)
     95 print('MPSP:',
---> 96       format(tea.solve_price(product), '.2g'),
     97      'USD/kg')
    100 sys.save_report('product.xlsx')

File D:\anaconda\envs\zddd\lib\site-packages\biosteam\_tea.py:991, in TEA.solve_price(self, streams)
    989 original_prices = [i.price for i in streams]
    990 for i in streams: i.price = 0.
--> 991 sales = self.solve_sales()
    992 current_price = 0.
    993 for i, j in zip(streams, original_prices): i.price = j

File D:\anaconda\envs\zddd\lib\site-packages\biosteam\_tea.py:1016, in TEA.solve_sales(self)
   1014     taxable_cashflow, nontaxable_cashflow, depreciation = self._taxable_nontaxable_depreciation_cashflows()
   1015     if np.isnan(taxable_cashflow).any():
-> 1016         raise RuntimeError('nan encountered in cashflow array')
   1017 args = (taxable_cashflow,
   1018         nontaxable_cashflow,
   1019         depreciation,
   1020         sales_coefficients,
   1021         discount_factors,
   1022         self._fill_tax_and_incentives)
   1023 x0 = self._sales if np.isfinite(self._sales) else 0

RuntimeError: nan encountered in cashflow array

Closing this issue because no code was included to reproduce it.


pepper-seattle friend html hacktober2018 commit

Committing pepper-seattle.html

Your pull request seems good, but must be checked by a human maintainer for the following reason(s):

This contains potentially hazardous tags that need manual review.

Please be patient until a maintainer has time to look over your contribution.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

61d64536e5091fb8de58a7dbf179b12ecb10e2f5


Handling of timing information by DataPoints class

Hi,
By peeking through the code I noticed that the DataPoints class has a Time field.
The Time field is not documented in the header section right above the class, and I couldn't find an example that shows how it is intended to be used.
By looking at the definition I infer that it is intended to hold the time per point in the point cloud, which is quite nice. It could allow people to undistort point clouds and even analyze which points were introduced when.
However, it is unclear:

Why the type is Int64 instead of a standard C++ time type as std::chrono. (credits to this GTSAM PR)
If the time should be local (e.g. from start to end of point cloud capture) or global (e.g. Unix time).

By means of this issue I would like to gather more information so that we can improve the documentation / add an example or use a standard type.

When looking at std::chrono, I see a lot of c++20. The implementation dates from a couple of years already. I essentially look at what ROS was providing, which is typically splitted Int64. See ros::TimeBase.
We can add a label to times, so one could have different representation (local or global). One could argue that we don't need int64 for local time. I could see the situation where one would like to track the name of the clock that produced those timestamps (i.e., in a global map with multiple lidar involved).
As for the hidden feature situation. I had to code something for a proof of concept a while ago and the branch was stale for too long. I merged it while I was still understanding what was going on hoping that someone pick it up. So here we are ;)

I recall having a discussion about that with some early dev, but I don't find any trace of it. For now, there was a code review here #169 (just for general info).


AddTransient MudLocalizer Dictionary based Example not work

Bug type
Component
Component name
MudDataGrid
What happened?
Hello, I want to replace the "Unsort" word of mud grid column to "Remove Sort" in a blazor wasm hosted project .net 8 and MudBlazor" Version="6.8.0" without resource file.
I inject these lines to program.cs of client project : (I also test MudLocalizer in Server project program.cs)
builder.Services.AddMudServices();
builder.Services.AddSingleton<ISnackbar, SnackbarService>();
builder.Services.AddTransient<MudLocalizer, DictionaryMudLocalizer>();
The MudDataGrid shows but Unsort still show instead of Remove Sort.
Base on your doc in here : https://mudblazor.com/features/localization#dictionary-based-example
public class DictionaryMudLocalizer : MudLocalizer
{
    private Dictionary<string, string> _localization;

    public DictionaryMudLocalizer()
    {
        _localization = new()
        {
            { "MudDataGrid.Unsort", "Remove Sort" },
        };
    }

    public override LocalizedString this[string key]
    {
        get
        {
            if (_localization.TryGetValue(key, out var value))
            {
                return new LocalizedString(key, value, true);
            }
            else
            {
                return base[key];
            }
        }
    }
}

<MudButton OnClick="@(() => dataGrid.SetEditingItemAsync(new UserDto()))">Add New Record</MudButton>
<MudDataGrid @ref="dataGrid" Items="@users" T="UserDto" ReadOnly="false" SortMode="SortMode.Single">
    <Columns>
        <PropertyColumn Property="c => c.Id" />
        <PropertyColumn Property="c => c.Email" />
        <PropertyColumn Property="c => c.FirstName" />
        <PropertyColumn Property="c => c.LastName" />
    </Columns>
</MudDataGrid>
@code {
    private MudDataGrid<UserDto> dataGrid;
    List<UserDto> users = new List<UserDto>();
    protected override async Task OnInitializedAsync()
    {
        users.Add(new UserDto { Id = Guid.Parse("C84014A9-9F54-4380-9F8F-8D4B4A60400A"), Email =<EMAIL_ADDRESS>FirstName = "aaa", LastName = "bbb" });
        users.Add(new UserDto { Id = Guid.Parse("E3DEC6E4-2DA1-4119-8E0A-AAA140BE3CEC"), Email =<EMAIL_ADDRESS>FirstName = "ccc", LastName = "ddd" });
    }
}

Expected behavior
change the "Unsort" word of MudDataGrid column to "Remove Sort"
Reproduction link
https://mudblazor.com/features/localization#dictionary-based-example
Reproduction steps

MudDataGrid
builder.Services.AddTransient<MudLocalizer, DictionaryMudLocalizer>();
DictionaryMudLocalizer class
...

Relevant log output
No response
Version (bug)
6.8.0
Version (working)
No response
What browsers are you seeing the problem on?
Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi.
As far as I understand you are trying to change the default English string to other English words, and this is not possible.
You'd have to set the language to something else then English, as English will always use the builtin translations provided by MudBlazor itself.
@Meduris correct me if I'm wrong

Yes I want to change the muddatagrid words for example Nosort. How to change the language for this goal?

I will quote and copy example from @Meduris:

so what you could do is something like this:

A class similar to this.

internal class MyMudLocalizer : MudLocalizer
{
    public override LocalizedString this[string key]
    {
        switch (key)
        {
            case "MudDataGrid.Save":
                return new(key, "apply");
            case "MudDataGrid.Cancel":
               return new(key, "abort");
            default:
                return new(key, key, true); // this will make it use the default translations for everything else
        }
    }
}

In Program.cs, add the following where you register your other services.

builder.Services.AddTransient<MudLocalizer, MyMudLocalizer>();

Set the default culture globally using something like this in your Program.cs.

// we don't want to set CultureInfo.DefaultThreadCurrentCulture as that is what affects formatting of numbers, dates etc
// CurrentUICulture is what controls translations
// to make it use the custom localizer, the CurrentUICulture can't be any of the english cultures
CultureInfo.DefaultThreadCurrentUICulture = CultureInfo.CreateSpecificCulture("fr");

Setting the default culture is necessary, as the localization feature is not intended for changing the english texts, but rather > only for providing translations for other languages.
Also you should note, that changing the current ui culture might mess with components from other libraries if you use any

Thank you @ScarletKuro
Adding this line to client program.cs project resolved the problem and replace worked :
CultureInfo.DefaultThreadCurrentUICulture = CultureInfo.CreateSpecificCulture("fr-FR");

thank you @ScarletKuro for handling this (I kinda missed the emails about this)

As far as I understand you are trying to change the default English strings to other English strings, and this is not possible.
You'd have to set the language to something else than English, as English will always use the builtin translations provided by MudBlazor itself. It's kinda by design, I don't think it's possible to change that.

Yes, this was by design, as per our discussions as it wasn't intended as a feature to let users change the english texts but rather just provide custom localization if needed.
If you (the MudBlazor team) want to change that behaviour or just provide a separate, easy, way to replace english texts without the hack of changing the language (which as stated in my cited messages can mess with other components that check the CurrentUICulture), please let me know. In that case I can work on an implementation for that.

I think it's better the Dictionary<string, string> _localization have to set always and change the words in data grid in default ui culture , and then we can write an if for other localization and set it another _localization like in MudBlazor docs:
public override LocalizedString this[string key]
    {
        get
        {
            var currentCulture = Thread.CurrentThread.CurrentUICulture.Parent.TwoLetterISOLanguageName;
            if (currentCulture.Equals("de", StringComparison.InvariantCultureIgnoreCase)
                && _localization.TryGetValue(key, out var res))
            {
                return new(key, res);
            }
            else
            {
                return new(key, key, true);
            }
        }
    }

These are my ideas for how to solve this, but I am not sure which of them I prefer:

I could remove the check where the internal localization gets always used if the CurrentUICulture is english and prioritize user provided localization (this would still allow using the fallback to the internal localization for anything the user left out)
add a separate optional service or methods to provide explicit overrides

My idea is to make it "interceptable". I would suggest making an optional abstraction that people can register and write their own logic, instead of making options like "IgnoreEnglishTranslation" and others. There are too many strategies:
Someone might want to make it so that if they miss their English key, they can use the default one instead, or completely ignore the default translation. Or maybe someone might want to log the missing key.
This is approximately how it can look:
public interface ILocalizationInterceptor
{
    LocalizedString Handle(string key);
}

internal class DefaultLocalizationInterceptor : ILocalizationInterceptor
{
    private readonly IStringLocalizer _localizer;
    private readonly MudLocalizer? _mudLocalizer;

    public DefaultLocalizationInterceptor(IStringLocalizer localizer, MudLocalizer? mudLocalizer = null)
    {
        _localizer = localizer;
        _mudLocalizer = mudLocalizer;
    }

    public LocalizedString Handle(string key)
    {
        var currentCulture = Thread.CurrentThread.CurrentUICulture.Parent.TwoLetterISOLanguageName;
        if (_mudLocalizer == null || currentCulture.Equals("en", StringComparison.InvariantCultureIgnoreCase))
        {
            return _localizer[key];
        }
        var res = _mudLocalizer[key];
        return res.ResourceNotFound ? _localizer[key] : res;
    }
}

    internal sealed class InternalMudLocalizer
    {
        private readonly IServiceProvider _serviceProvider;
        private readonly IStringLocalizer _localizer;
        private readonly MudLocalizer? _mudLocalizer;

        public InternalMudLocalizer(IServiceProvider serviceProvider, ILoggerFactory loggerFactory, MudLocalizer? mudLocalizer = null)
        {
            var options = Options.Create(new LocalizationOptions());
            var factory = new ResourceManagerStringLocalizerFactory(options, loggerFactory);
            _localizer = factory.Create(typeof(LanguageResource));
            _serviceProvider = serviceProvider;
            _mudLocalizer = mudLocalizer;
        }

        public LocalizedString this[string key]
        {
            get
            {
                var interceptor = _serviceProvider.GetService<ILocalizationInterceptor>() ?? new DefaultLocalizationInterceptor(_localizer, _mudLocalizer);

                return interceptor.Handle(key);
            }
        }
    }

Oh, yeah. That solution allows for a lot more freedom.
I also like how it allows for logging missing keys as that is something I did a lot so far to help with localization.
Though I would probably also pull the ILocalizationInterceptor as an optional service (just like the MudLocalizer) and create the DefaultLocalizationInterceptor instance in the constructor if no custom implementation is registered (just to avoid needlessly creating object instances).
Kinda like this:
    internal sealed class InternalMudLocalizer
    {
        private readonly ILocalizationInterceptor _localizationInterceptor;
        private readonly IStringLocalizer _localizer;
        private readonly MudLocalizer? _mudLocalizer;

        public InternalMudLocalizer(ILoggerFactory loggerFactory, ILocalizationInterceptor? localizationInterceptor = null, MudLocalizer? mudLocalizer = null)
        {
            var options = Options.Create(new LocalizationOptions());
            var factory = new ResourceManagerStringLocalizerFactory(options, loggerFactory);
            _localizer = factory.Create(typeof(LanguageResource));
            _localizationInterceptor = localizationInterceptor ?? new DefaultLocalizationInterceptor(_localizer, _mudLocalizer);
            _mudLocalizer = mudLocalizer;
        }

        public LocalizedString this[string key]
        {
            get
            {
                return _localizationInterceptor.Handle(key);
            }
        }
    }

Yeah, I think we should do that. Looks like there is demand for this and it's better if we have a proper solution rather than a workaround.
@Meduris do you want to make a PR?

Yeah, I think we should do that. Looks like there is demand for this and it's better if we have a proper solution rather than a workaround. @Meduris do you want to make a PR?

I can do that later today. It will be mostly just be the implementation you proposed though.
I assume we want this documented as well then? I'd start doing that as part of the localization documentation then.

I assume we want this documented as well then? I'd start doing that as part of the localization documentation then.

Yes. I would just add section in the end to our current documentation that if user wishes to override default English translation here is example of interceptor code and how to register it. That's it.

This now will be possible in the next release.
Easiest way to get rid of the default English would be:
services.AddLocalizationInterceptor<ILocalizationInterceptor>(provider =>
{
	var loggerFactory = provider.GetRequiredService<ILoggerFactory>();

	return new DefaultLocalizationInterceptor(loggerFactory) { IgnoreDefaultEnglish = true };
});

Also one additional option is to implement own ILocalizationInterceptor and register it with:
services.AddLocalizationInterceptor<CustomLocalizationInterceptor>();

or with the factory like in the first example.
Basically ILocalizationInterceptor allows to fully replace on how InternalMudLocalizer is working, because it will call your implementation instead of the default one.