[ERROR] () Authorization failed on application startup when using AZURE_USE_AUTHENTICATION=True

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Manually setup the two App Registrations (Server, and Client). Pass the values of the necessary required environment variables to .env in the App Service. Additionally set the "prompt": "request" loginRequest property in authentication.py. Use azd deploy to push code changes to service. Restart the web app.

Authentication ("Add Identity Provider") is not enabled, as I presume the two-app authentication solution supersedes this inbuilt App Service option.

AZURE_USE_AUTHENTICATION: true
AZURE_FORCE_ACCESS_CONTROL: false
AZURE_SERVER_APP_ID: Value from Server App Id
AZURE_SERVER_APP_SECRET: Value from Server App Secret
AZURE_CLIENT_APP_ID: Value from Client App Id
AZURE_AUTH_TENANT_ID: Tenant ID, same as AZURE_TENANT_ID
AZURE_TENANT_ID: Azure Tenant Id

Any log messages given by the failure

2024-03-12T11:08:47.538958884Z    _____
2024-03-12T11:08:47.539010086Z   /  _  \ __________ _________   ____
2024-03-12T11:08:47.539016086Z  /  /\  \__   /  |  _  __ _/ __ \
2024-03-12T11:08:47.539021086Z /    |    /    /|  |  /|  | /\  /
2024-03-12T11:08:47.539025286Z _|__  /_____ _/ ||    __  >
2024-03-12T11:08:47.539029886Z         /      /                  /
2024-03-12T11:08:47.539033986Z A P P   S E R V I C E   O N   L I N U X
2024-03-12T11:08:47.539038086Z
2024-03-12T11:08:47.539041887Z Documentation: http://aka.ms/webapp-linux
2024-03-12T11:08:47.539045987Z Python 3.11.7
2024-03-12T11:08:47.539049887Z Note: Any data outside '/home' is not persisted
2024-03-12T11:08:48.844062967Z Starting OpenBSD Secure Shell server: sshd.
2024-03-12T11:08:49.059191011Z Site's appCommandLine: python3 -m gunicorn main:app
2024-03-12T11:08:49.061913291Z Launching oryx with: create-script -appPath /home/site/wwwroot -output /opt/startup/startup.sh -virtualEnvName antenv -defaultApp /opt/defaultsite -userStartupCommand 'python3 -m gunicorn main:app'
2024-03-12T11:08:49.177712306Z Found build manifest file at '/home/site/wwwroot/oryx-manifest.toml'. Deserializing it...
2024-03-12T11:08:49.177826910Z Build Operation ID: 55780ade89b15f24
2024-03-12T11:08:49.186311960Z Output is compressed. Extracting it...
2024-03-12T11:08:49.186347761Z Oryx Version: 0.2.20240127.1, Commit: 4b7f2dffcc69c214f9806d67a85ec8926e2393e1, ReleaseTagName: 20240127.1
2024-03-12T11:08:49.214240984Z Extracting '/home/site/wwwroot/output.tar.gz' to directory '/tmp/8dc427754dc5c77'...
2024-03-12T11:09:16.075693702Z App path is set to '/tmp/8dc427754dc5c77'
2024-03-12T11:09:16.080167543Z Writing output script to '/opt/startup/startup.sh'
2024-03-12T11:09:16.232341951Z Using packages from virtual environment antenv located at /tmp/8dc427754dc5c77/antenv.
2024-03-12T11:09:16.232385052Z Updated PYTHONPATH to '/opt/startup/app_logs:/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages'
2024-03-12T11:09:17.709985685Z [2024-03-12 11:09:17 +0000] [70] [INFO] Starting gunicorn 21.2.0
2024-03-12T11:09:17.711870149Z [2024-03-12 11:09:17 +0000] [70] [INFO] Listening at: http://<IP_ADDRESS>:8000 (70)
2024-03-12T11:09:17.718468871Z [2024-03-12 11:09:17 +0000] [70] [INFO] Using worker: uvicorn.workers.UvicornWorker
2024-03-12T11:09:17.731471910Z [2024-03-12 11:09:17 +0000] [72] [INFO] Booting worker with pid: 72
2024-03-12T11:09:17.798010454Z [2024-03-12 11:09:17 +0000] [73] [INFO] Booting worker with pid: 73
2024-03-12T11:09:17.922319348Z [2024-03-12 11:09:17 +0000] [74] [INFO] Booting worker with pid: 74
2024-03-12T11:10:11.159352446Z [2024-03-12 11:10:11 +0000] [72] [INFO] Started server process [72]
2024-03-12T11:10:11.161102605Z [2024-03-12 11:10:11 +0000] [72] [INFO] Waiting for application startup.
2024-03-12T11:10:11.197762533Z [2024-03-12 11:10:11 +0000] [74] [INFO] Started server process [74]
2024-03-12T11:10:11.197828535Z [2024-03-12 11:10:11 +0000] [74] [INFO] Waiting for application startup.
2024-03-12T11:10:11.209201016Z [2024-03-12 11:10:11 +0000] [73] [INFO] Started server process [73]
2024-03-12T11:10:11.218005311Z [2024-03-12 11:10:11 +0000] [73] [INFO] Waiting for application startup.
2024-03-12T11:10:19.576461028Z [2024-03-12 11:10:19 +0000] [72] [ERROR] () Authorization failed.
2024-03-12T11:10:19.576508930Z Code:
2024-03-12T11:10:19.576516130Z Message: Authorization failed.
2024-03-12T11:10:19.585822232Z [2024-03-12 11:10:19 +0000] [72] [ERROR] Application startup failed. Exiting.
2024-03-12T11:10:19.604500939Z [2024-03-12 11:10:19 +0000] [73] [ERROR] () Authorization failed.
2024-03-12T11:10:19.604536440Z Code:
2024-03-12T11:10:19.604551740Z Message: Authorization failed.
2024-03-12T11:10:19.607009520Z [2024-03-12 11:10:19 +0000] [73] [ERROR] Application startup failed. Exiting.
2024-03-12T11:10:19.645547171Z [2024-03-12 11:10:19 +0000] [72] [INFO] Worker exiting (pid: 72)
2024-03-12T11:10:20.001624632Z [2024-03-12 11:10:19 +0000] [74] [ERROR] () Authorization failed.
2024-03-12T11:10:20.001657233Z Code:
2024-03-12T11:10:20.130909730Z Message: Authorization failed.
2024-03-12T11:10:20.130939331Z [2024-03-12 11:10:19 +0000] [74] [ERROR] Application startup failed. Exiting.
2024-03-12T11:10:20.130945331Z [2024-03-12 11:10:19 +0000] [73] [INFO] Worker exiting (pid: 73)
2024-03-12T11:10:20.130950031Z [2024-03-12 11:10:19 +0000] [74] [INFO] Worker exiting (pid: 74)
2024-03-12T11:10:34.165606784Z [2024-03-12 11:10:34 +0000] [70] [ERROR] Worker (pid:74) exited with code 3
2024-03-12T11:10:34.196832445Z [2024-03-12 11:10:34 +0000] [70] [ERROR] Worker (pid:72) exited with code 3
2024-03-12T11:10:34.196855546Z [2024-03-12 11:10:34 +0000] [70] [ERROR] Worker (pid:73) exited with code 3
2024-03-12T11:10:34.196861446Z object address  : 0x74bb48d58280
2024-03-12T11:10:34.196866346Z object refcount : 2
2024-03-12T11:10:34.196870646Z object type     : 0x6415322c4ed0
2024-03-12T11:10:34.196875047Z object type name: HaltServer
2024-03-12T11:10:34.224224676Z object repr     : HaltServer('Worker failed to boot.', 3)
2024-03-12T11:10:34.224279178Z lost sys.stderr

Expected/desired behavior

After configuring the two App Registrations and setting all required environment variables to enable Authentication functionality - expected behaviour be able to start the application successfully in the App Service and be presented with a login screen. Optional Document Access Control is not configured/set.

OS and Version?

Windows 10, running in VSCode Container (Linux)

azd version?

azd version 1.6.1 (commit eba2c978b5443fdb002c95add4011d9e63c2e76f)

Versions

Azure Resource as standard, deployed from template. Public Network Access enabled with restrictions to allow certain IP addresses.

Mention any other details that might be useful

The app runs normally in the App Service when AZURE_USE_AUTHENTICATION: false.  When I run it locally using the above adjusted configuration, I can build the app successfully and see the "Login" button on the Chat page and begin the authentication process.

Can you check Azure Monitor to get a better traceback for that error?
https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/docs/appservice.md#checking-azure-monitor-for-errors

The two failure events which seem to persist initially an GET./auth/.refresh, and persistently over the last few attempts SearchIndexClient.get_index() --> GET/msi/token/ --> EXCEPTION HttpResponse Error.
Traceback (most recent call last):   File "/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages/opentelemetry/trace/__init__.py", line 573, in use_span     yield span   File "/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages/azure/core/tracing/decorator_async.py", line 88, in wrapper_use_tracer     return await func(*args, **kwargs)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages/azure/search/documents/indexes/aio/_search_index_client.py", line 147, in get_index     result = await self._client.indexes.get(name, **kwargs)              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages/azure/core/tracing/decorator_async.py", line 88, in wrapper_use_tracer     return await func(*args, **kwargs)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages/azure/search/documents/indexes/_generated/aio/operations/_indexes_operations.py", line 658, in get     raise HttpResponseError(response=response, model=error) azure.core.exceptions.HttpResponseError: () Authorization failed. Code:  Message: Authorization failed.
The Exception itself;
Traceback (most recent call last):   File "/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages/quart/app.py", line 1671, in startup     await self.ensure_async(func)()   File "/tmp/8dc427754dc5c77/app.py", line 291, in setup_clients     search_index=(await search_index_client.get_index(AZURE_SEARCH_INDEX)) if AZURE_USE_AUTHENTICATION else None,                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages/azure/core/tracing/decorator_async.py", line 88, in wrapper_use_tracer     return await func(*args, **kwargs)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages/azure/search/documents/indexes/aio/_search_index_client.py", line 147, in get_index     result = await self._client.indexes.get(name, **kwargs)              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages/azure/core/tracing/decorator_async.py", line 88, in wrapper_use_tracer     return await func(*args, **kwargs)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/tmp/8dc427754dc5c77/antenv/lib/python3.11/site-packages/azure/search/documents/indexes/_generated/aio/operations/_indexes_operations.py", line 658, in get     raise HttpResponseError(response=response, model=error) azure.core.exceptions.HttpResponseError: () Authorization failed. Code:  Message: Authorization failed.

I also see I have following (new?!) environment variable in the App Service Configuration, but it is unset (empty).

SEARCH_SECRET_NAME

AZURE_SEARCH_SERVICE and AZURE_SEARCH_INDEX are set appropriately.

Okay, so there is an issue with your permissions for the search service for some reason. Can you follow the steps from this comment to inspect your roles? https://github.com/Azure-Samples/azure-search-openai-demo/issues/1398#issuecomment-1989190755
SEARCH_SECRET_NAME can be empty as long as the search roles are setup correctly, which they usually are.

I unfortunately already have all of those permissons on my AI Search Service.
If I would like to pursue the Automatic Authentication/Login Setup as a workaround, do I need any further permissions than "Cloud Application Developer" as the docs suggest?

Can you also check the roles for the app service app? Here's mine:

cc @mattgotteiner as he may have a more immediate idea for the issue.

If it's only when you're running on the deployed app, I'm wondering if the app principal has the right roles on the search service. The Authorization failed error message stack trace you point out here (SearchIndexClient.get_index())  would require Search Reader role.
https://learn.microsoft.com/en-us/azure/search/search-security-rbac?tabs=config-svc-portal%2Croles-portal%2Ctest-portal%2Ccustom-role-portal%2Cdisable-keys-portal#built-in-roles-used-in-search
The purpose of this check is to validate your index has the ACL fields

@pamelafox Thanks! This worked - we have the app service running again.
However, we are landing directly onto the app without the necessary routing onto the Login page using AZURE_USE_AUTHENTICATION=True and the "prompt": "request" loginRequest property in authentication.py both uncommented/commented. Is there anything I need to change in the backend/core code to get over this hump?
Other than that I can think than perhaps azd up with the .env set to the existing app registrations @vrajroutu mentioned may help?

I tried an az up with AZURE_USE_AUTHETICATION=true, client and app ids/secrets are set plus all the standard environment variable. I do have Owner permissions on both the registered applications. But receive the following error:
`AZURE_USE_AUTHENTICATION is set, proceeding with authentication setup...
Creating Python virtual environment "scripts/.venv"...
Installing dependencies from "requirements.txt" into virtual environment (in quiet mode)...
Setting up authentication...
Checking if application aa99a7bf-7d3e-47e2-bca9-243f3f9d9479 exists
Application already exists, not creating new one
Traceback (most recent call last):
File "/workspaces/self-deploy/./scripts/auth_init.py", line 209, in
asyncio.run(main())
File "/usr/local/lib/python3.11/asyncio/runners.py", line 190, in run
return runner.run(main)
^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/asyncio/runners.py", line 118, in run
return self._loop.run_until_complete(task)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/asyncio/base_events.py", line 654, in run_until_complete
return future.result()
^^^^^^^^^^^^^^^
File "/workspaces/self-deploy/./scripts/auth_init.py", line 184, in main
server_object_id, server_app_id, _ = await create_or_update_application_with_secret(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/workspaces/self-deploy/./scripts/auth_init.py", line 64, in create_or_update_application_with_secret
await update_application(auth_headers, object_id, app_payload)
File "/workspaces/self-deploy/scripts/auth_common.py", line 32, in update_application
raise Exception(response_json)
Exception: {'error': {'code': 'Authorization_RequestDenied', 'message': 'Insufficient privileges to complete the operation.', 'innerError': {'date': '2024-03-13T13:49:27', 'request-id': '282b17ea-001f-4705-a44d-d2536ce4c294', 'client-request-id': '282b17ea-001f-4705-a44d-d2536ce4c294'}}}
ERROR: failed running pre hooks: 'preprovision' hook failed with exit code: '1', Path: './scripts/auth_init.sh'. : exit code: 1
ERROR: error executing step command 'provision': failed running pre hooks: 'preprovision' hook failed with exit code: '1', Path: './scripts/auth_init.sh'. : exit code: 1`
Could you advise here @vrajroutu . As I am working in a client's Tenant (as a guest), I don't have absolute liberty to check all possible restrictions or policies that may overide/block typical operations. Could you suggest some places which I could pass to the admin to check/set as needed?
Thank you

I got that error once before as well, and I had to get the "Application administrator" role assigned to me: https://learn.microsoft.com/azure/active-directory/roles/permissions-reference#cloud-application-administrator

I'm afraid that additonal permission hasn't helped either. We will be reaching out to MSFT technical support. I'll update here should the core issue eventually be diagnosed.

@vrajroutu and @pamelafox
Being added as a member in the Tenant and initiating a completely fresh deployment of the application registrations (not referencing the existing ones) via azd up solved it. Thanks

Resolved.


Transform input from config files

Some configuration values that correspond to non-trivial types could benefit from having a transformation hook.  While reading the config input, the transformation hook would create the non-trivial type before assigning to the config object instance.

WIP in #8


TII-214 Improve error logging in logs and database

https://jira.sakaiproject.org/browse/TII-214
Currently we get only the request status code (ie, "400 Bad Request") in the lastError column for failed LTI submissions, etc. The only way to get more information out of this, is to bump your logger level way up to debug, or run your server in debug mode and step through the code to get more info out of the XML response.
This can be improved by refactoring the way the return logic and error handling is performed. In effect, we can get the reason from the XML response and put this into the lastError column in the database, as well as improve what information is logged at ERROR and WARN levels.

While I really like the tidier code of catching the checked exceptions I worry that the some unchecked exceptions are also getting caught in these catches, if you're pretty sure that they are good to go the safe thing todo is to add them in but also keep the more specific exception but log it as a warning or error when seen:
catch (Exception e) {
    log.warn("Unexpected exception getting grade.", e);
}

That way we don't end up failing in production if under some edge case they were needed.

Thanks @buckett, I'll push another commit soon

So what I did was to add the catch(Exception e) back underneath the more specific catch's if there was no special processing going on. If there was special processing, I just reverted back to catching all exceptions.


Automatic PR from RestAPI-PR675

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/675

Doc only


LeftJoin with Where statement (or Filterable dropdownbox)

Hi,
I am having the same issue as the previously closed Issue #818 , but the solution provided there is not working.
I am having a table with following data,
ID  Name    Active  Description
1   Mill Drum 1 NULL
2   Motor    0  NULL
5   TestEqu  0  NULL
6   Testfine     0  testedfine
I need only the Active rows to be displayed in the Dropdown.
I am using the following code,
[DisplayName("Equipment"), Column("EquipmentID"), NotNull, ForeignKey("[dbo].[tblEquipments]", "ID"), LeftJoin("jEquipment"), TextualField("EquipmentEquipmentName")]
[LookupEditor(typeof(TblEquipmentsRow), InplaceAdd = true, FilterField = "EquipmentActive", FilterValue = true), LookupInclude]
public Int64? EquipmentId
{
get { return Fields.EquipmentId[this]; }
set { Fields.EquipmentId[this] = value; }
}
    [DisplayName("Name"), Expression("jEquipment.[Name]")]
    public String EquipmentEquipmentName
    {
        get { return Fields.EquipmentEquipmentName[this]; }
        set { Fields.EquipmentEquipmentName[this] = value; }
    }

    [DisplayName("Equipment Active"), Expression("jEquipment.[Active]")]
    public Boolean? EquipmentActive
    {
        get { return Fields.EquipmentActive[this]; }
        set { Fields.EquipmentActive[this] = value; }
    }

Still nothing is appearing in the dropdown.

Add lookupinclude in your equipment row, not the row you are using editor on. Also filterfield is the field name in your equipment row not the row you are using editor on.....

Thank You so much. This works :)

sasinallatech, I've same problem, can you describe how do you resolved?
Thank you!

thanks, I've already resolved.


Create new crates.io Release

The last release on crates.io is 4 months old and there have been several features implemented since then. Please push a new release to crates.io with the latest updates.

Thanks for reaching out! We will work on adding a new release of ion-schema-rust.

ion-schema new version 0.2.0 is available now.


DiscordSRV無法讀取訊息

我的服務器主要玩家都是來自海外,所以都是透過Discord進行溝通,希望能修復DiscordSRV(https://www.spigotmc.org/resources/discordsrv.18494/)插件不能讀取聊天欄訊息的問題

请尝试最新构建是否修复

用你這個构建還是不可以

试试这个

好像還是讀不了訊息

DiscordSRV配置文件中可以設置服務器裡面聊天頻道的名字,trchat是不是也有對應的名字?

最新构建还是无法读取吗
尝试使用DiscordSRV的debug功能看看有什么消息

[INFO] ....[Async Chat Thread - #59] [ 管理員 ] HAPPYHIN: .
[INFO] ....[Craft Scheduler Thread - 735] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] Chat message received, canceled: true, channel: global
[INFO] ....[Craft Scheduler Thread - 736] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] Chat message received, canceled: true, channel: global
[INFO] ....[Craft Scheduler Thread - 735] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] User HAPPYHIN sent a message but it was not delivered to Discord because the chat event was canceled
[INFO] ....[Craft Scheduler Thread - 736] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] User HAPPYHIN sent a message but it was not delivered to Discord because the chat event was canceled
[INFO] ....[Server thread] Ghosts_Daniel blew up
[INFO] ....[Craft Scheduler Thread - 721] [DiscordSRV] [UNCATEGORIZED DEBUG] Constructed avatar url: https://crafatar.com/avatars/cd82b4d08c754a55baa717dc33ebb6fb.png?size=128&overlay#bd63fa2c1915e90863a9c19142d4927d527b52af3284b54e2de9dd186d4795f5 from https://crafatar.com/avatars/{uuid-nodashes}.png?size={size}&overlay#{texture}
[INFO] ....[Craft Scheduler Thread - 721] [DiscordSRV] [UNCATEGORIZED DEBUG] Avatar url is for uuid: cd82b4d0-8c75-4a55-baa7-17dc33ebb6fb. The texture is: bd63fa2c1915e90863a9c19142d4927d527b52af3284b54e2de9dd186d4795f5
[INFO] ....[Async Chat Thread - #59] [ 玩家 ] Ghosts_Daniel: W T F
[INFO] ....[Craft Scheduler Thread - 721] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] Chat message received, canceled: true, channel: global
[INFO] ....[Craft Scheduler Thread - 735] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] Chat message received, canceled: true, channel: global
[INFO] ....[Craft Scheduler Thread - 721] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] User Ghosts_Daniel sent a message but it was not delivered to Discord because the chat event was canceled
[INFO] ....[Craft Scheduler Thread - 735] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] User Ghosts_Daniel sent a message but it was not delivered to Discord because the chat event was canceled
[INFO] ....[Async Chat Thread - #59] [ 玩家 ] Ghosts_Daniel: 直接一堆臭蟲殺過來
[INFO] ....[Craft Scheduler Thread - 735] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] Chat message received, canceled: true, channel: global
[INFO] ....[Craft Scheduler Thread - 740] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] Chat message received, canceled: true, channel: global
[INFO] ....[Craft Scheduler Thread - 735] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] User Ghosts_Daniel sent a message but it was not delivered to Discord because the chat event was canceled
[INFO] ....[Craft Scheduler Thread - 740] [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] User Ghosts_Daniel sent a message but it was not delivered to Discord because the chat event was canceled


You should not need to recompile .ts files in node_modules

Hello,
Happen to come across this compiler error while using your directive.

ERROR in /node_modules/ng2-tooltip-directive/lib/tooltip.directive.ts
Module build failed: Error: Typescript emitted no output for \node_modules\ng2-tooltip-directive\lib\tooltip.directive.ts.
You should not need to recompile .ts files in node_modules.
Please contact the package author to advise them to use --declaration --outDir.
More https://github.com/Microsoft/TypeScript/issues/12358

For the time being, I included the node_modules folder in compile paths and it worked fine.

Would this require changes to the package.json? Also affected by this, ended up copy-and-pasting the directive code into my own project


Should usually be possible by passing in owner or instantiating using:
Bundle.main.loadNibNamed("CountryPickerView", owner: nil, options: [:])

What error do you get when you do this?

No error, it's simply due to NibView implicitly loading from bundle, rather than being able to define a view in storyboard/ib which subclasses CountryPickerView.
https://github.com/kizitonwose/CountryPickerView/blob/master/CountryPickerView/NibView.swift#L36

To be honest, I don't think I fully understand this issue. Can you please explain further?

I'd like to be able to load using my own xib.

By this do you mean like using the library in interface builder or what?

Closing this, feel free to comment if you still need assistance.


[BUG] Start Reading Now Button is not working on the home page.

Description
The Start Reading Now button is not working on the home page.

Screenshots
No response
Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

hey @ayushkumarbhadani  this is just a template and in the coming days we are planning to change so please go ahead if you have any other suggestions do suggest as of now am closing this issue  !!


preparing for beta deploy

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   96.25%   96.25%
=======================================
  Files          11       11
  Lines        1440     1440
  Branches      165      165
=======================================
  Hits         1386     1386
  Misses         31       31
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a19c33...0295206. Read the comment docs.


Cleanup: Remove unused member of Http2ClientSession

The total_write_len is incremented but not used after all.

Cherry-picked to v9.1.x branch.


Update for Laravel 8.0

Requiring the following package to update first:

laravel/nova
kalnoy/nestedset

This is now available in release 0.11.0.


Another code exposure was found in the document

Sandcastle example:none
Browser:all
Operating System:all

https://cesium.com/learn/3d-tiling/on-prem/on-prem-terrain/

Thanks @danchaotaiyang! I've fixed the error. The fix should be published soon.


feat(cli): expanded preview

Proposed changes
When previewing, being it thru the dedicated command or part of the push flow allow the user to analyze files to preview what's what.
To be precise:

We 'pull' the target organization configuration (i.e. create a new snapshot from org, pull it).
We compare each file using the resourceKeys.

Resource key present in the target but not in the source snapshot are added
Resource key present in the source snapshot but not in the target are kept unless using the -d flag.
If present in both, then the value of the resource from the source is applied on the target.

Testing
Ongoing 😅

CDX-347

@louis-bompart : Are these changes ready to review and merge ?

@olamothe, the PR description is up-to-date with the work that I think needs to be done (mainly, UT), but it is ready for review.

I saw your last comment about the backend not being ready and you preferring to wait. If that's the case, can you close this temporarily and re-open when it's ready (or switch it to draft).

I don't know which comment you are talking about 😕?

I don't know which comment you are talking about 😕?

This one:
And honestly, I don't think I would merge it till I can test it for real. (the more I coded it, the more I realized that there are a lot of places where it can go haywire, so I don't feel comfortable going forward till the backend is done and that I'm able to see what my code does.

But if it's ready, then 👍 Ill do the review.

Ready for full review. Incorporate part of #391 and needs it to be merged first

[ ] #391 merged


Text schema for CSV can't be read

With master (7a0d4d5), creating a simple virtualenv (Python 3.6.1) with just ipython and tabulator, I execute the following example from the readme:
In [1]: from tabulator import Stream

In [2]: source = 'text://id,name\n1,english\n2,中国人\n'

In [3]: stream = Stream(source, format='csv')

In [4]: stream
Out[4]: <tabulator.stream.Stream at 0x10d2a0c88>

In [5]: stream.read()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-5-33dca700fff6> in <module>()
----> 1 stream.read()

~/virtualenvs/tabulator/lib/python3.6/site-packages/tabulator/stream.py in read(self, keyed, extended, limit)
    206         result = []
    207         rows = self.iter(keyed=keyed, extended=extended)
--> 208         for count, row in enumerate(rows, start=1):
    209             result.append(row)
    210             if count == limit:

~/virtualenvs/tabulator/lib/python3.6/site-packages/tabulator/stream.py in iter(self, keyed, extended)
    187         iterator = chain(
    188             self.__sample_extended_rows,
--> 189             self.__parser.extended_rows)
    190         iterator = self.__apply_processors(iterator)
    191         for row_number, headers, row in iterator:

AttributeError: 'NoneType' object has no attribute 'extended_rows'

Thanks. Will fix tomorrow.

@brew
You haven't open the stream - https://github.com/frictionlessdata/tabulator-py#stream
I've create an issue for better error message - https://github.com/frictionlessdata/tabulator-py/issues/179

Oh! Thanks @roll.


Photoswipe fullscreen on desktop: caption and buttons at top take up space of image

hello i would like to see the image in fullscreen on a desktop when i use the fullscreen view.
on mobile devices this is working just fine but on desktop computers the images are not in fullscreen because the menu buttons at top and the caption at the bottom are not overlays anymore. The image is scaled down between the top and bottom instead.
How can i change this behaviour? I really like it how it is done for mobile devices.
See the screenshots below:
Correct fullscreen on iPad:

Wrong fullscreen on desktop computer:

i think this can be achieved with the following options
	_options,
	_defaultUIOptions = {
		barsSize: {top:0, bottom:0},

described here:
https://github.com/dimsemenov/PhotoSwipe/issues/1602#issuecomment-459862474


PR for adding a pre-req to check replication privileges

Learn Build status updates of commit 085c22a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/postgresql/migrate/concepts-single-to-flexible.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


android: Add monkey-test workload

monkey tests are very useful doing lot of activity in short period of time on the device and collecting traces to analyze frame drops and other behavior. It would be nice to have a workload in workloads/ do this. I have something I'll post soon, this issue tracks it.

It's worth noting that Workload Automation might be able to solve this use case already (some of the stuff we've been doing in LISA has been just because WA wasn't working with the latest Android, which may now be fixed).

Ok. maybe we're talking of different things? - this is basically the monkey apk launching an app and doing lots of activities (user interaction) to it, like 1000s of random touch, swipe events etc. The workload would essentially just call monkey.

@bjackman assign to me? (also let me know if/how I can assign to self)

Closing as workloads are now in WA


Use the correct MIME type application/vnd.vegalite.v2+json

Also use the correct function in the notebook.

Thanks!


3517: Bar access when session is in completed state

When a session is completed the sessionId is set to 'no-current-session' and
this should prevent a user from being view pages on the Hub.
Currently, this check is happening within our backend API and the FE is
receiving a 403 response, that's sent to Sentry, and which isn't very clear or
convenient.
By performing the check within the FE we remove the call to the API and the
Sentry output.

Looks good to me.


refactor docs into 2 layers

No no no ... this structure is totally wrong and mixed everything into a mess. There are some good examples of how to organize the sidebar:

https://docs.fluxcd.io/projects/helm-operator/en/stable/ Getting Started -> Concepts/Reference Doc -> Tutorial
https://shipper-k8s.readthedocs.io/en/latest/user/rolling-out.html Quick Started -> User Guide -> Operator Guide -> Limitations -> Reference Doc (this was the version we had before this PR)
https://kubernetes.io/docs/home/ Getting Started -> Concepts -> Tasks -> Tutorials -> Reference Doc

Let's revert it at least.


type arguments not shown in hover for generic instantiation

I have this code:
value array = Array { 1, 2 };

Hovering Array should show me the inferred type argument but it doesn't.

I fixed a few things but now it's not inferring the type argument everywhere, which is a little odd:
class Array<Integer>({Integer*} elements)
  extends Basic
  satisfies SearchableList<Element> & Ranged<Integer,Element,Array<Element>>
  given Element = Integer

I'll keep debugging...


Installing via Obsidian Community Plugins does not work

Using version 1.5.1 of Obsidian Webpage Export.
the error
Installing via the community marketplace does not seem to be working. I get an Error: Could not read text file at path and an Error: ENOENT no such file or directory

cause
the scripts folder, the assets folder, and the other files don't seem to be downloaded whilst downloading the plugin from the marketplace. Manually downloading the files and putting it into the \plugins\webpage-html-export folder makes it work!
Manual installation still works, just the marketplace one doesn't due to missing files for some reason. I've tried this on an empty test vault with no other plugin enabled, and two computers both running Windows 10 and Obsidian 1.1.16

Thanks for reporting this, I will fix this immediately!

Let me know if this is fixed in the latest version. Thanks again for reporting this!

I had the same issue. Seems fixed now, no errors.

Okay great, thanks!


How to easily access the type of the user returned from useAuth?

Sorry for diverging from the issue template but IMO this isn't a bug but more of a question.
I'm using the useAuth hook to log in users in a React + TS app. I then want to process the user object further before returning it from my custom hook:
export function useCustomAuth() {
    const { user: fronteggUser } = useAuth();

    function mapUser(user: /* Which type to use here? */) {
        // do something with the user
    }

    return {
        user: fronteggUser ? mapUser(fronteggUser) : null,
    };
}

My problem is that accessing the type of the user returned from useAuth is hard. I can't easily get the type from the return type of useAuth directly due to useAuth being overloaded and TS not being able to pick the correct overload in this case AFAIU:
// In this case the type of userFromFrontegg is `unknown` ...
function mapUser(
  userFromFrontegg: Exclude<ReturnType<typeof useAuth>, null | undefined>
) {
  // do something with the user
}

type HookReturnType = ReturnType<typeof useAuth>; // ... because this is `unknown`

type HookType = typeof useAuth; // ... because this is `{ (): AuthState; <S>(stateMapper: AuthStateMapper<S>): S; }`

I can get the type from a variable but this seems suboptimal:
const { user: fronteggUser } = useAuth();

function mapUser(
  userFromFrontegg: Exclude<typeof fronteggUser, null | undefined>
) {
  // do something with the user
}

My suggestion is to export the types AuthState, the return type of useAuth, and User from @frontegg/react to allow users to easily type the data returned by this hook. What do you think? Is there an easier way make this work maybe?
Thanks in advance for the help :)

I'd like to see this too


Add Content-Type application/json to requests

@alex-slynko observed that one can't pass JSON playload to the curl command.
The suggested fix, adds a Content-Type: application/json to all outgoing request. This fixed our issue.

LGTM 💯


nginx: Enable HSTS when forceSSL is on

The only option I think is feasible to create a separate option to enable HSTS and maybe make max-age and includeSubDomains configurable.

Ok, in this case I’ll add a separate option and mention it in the documentation for forceSSL.

It's very easy to lock users out of the website, I would never enable HSTS by default, but we can make it optional.

It's very easy to lock users out of the website

Well, personally I do not think that HSTS is that scary, it does not pin a certificate and obtaining a valid certificate nowadays is incredibly easy.
Anyway, I’m thinking about something like:
virtualHosts."example.com" = {
  sslStrict = {
    enable = false;
    maxAge = 31536000;
    includeSubDomains = true;
  };
};

I am also inclined towards always sending the header, but setting max-age=0 if enable is false. That way changing enable to false will actually disable HSTS, not just stop sending the header.

In case someone wonders, I still hope to get to this some time soon.

Anyway, I’m thinking about something like:
virtualHosts."example.com" = {
  sslStrict = {
    enable = false;
    maxAge = 31536000;
    includeSubDomains = true;
  };
};

Yeah, that looks good!
We probably shouldn't, like the others mentioned, turn it on by default. But I think we can make the case that recommendedTlsSettings turns it on.
Oh and includeSubDomains should be false by default.
We should also probably set the default maxAge to a low number (like an hour) and also recommend in the docs to set it higher. (Which recommendedTlsSettings could do)

I am also inclined towards always sending the header, but setting max-age=0 if enable is false. That way changing enable to false will actually disable HSTS, not just stop sending the header.

Hmm, no I think people wouldn't expect that. You don't want to mess with the entire domain if not explicitly opted in.

Given the complications around disabling HSTS, I wouldn't like to see it enabled implicitly (like by recommendedTlsSettings), but I would love to have an option just like the suggested sslStrict for doing it manually, but easily.
(Incidentally, are there any functions in nixpkgs for dealing with units of time? It would be cool to have maxAge = lib.daysToSeconds 365 (or something more structured) instead of 31536000.)
Is anyone else working on this? If not, I will make a PR for sslStrict when I find the time.
About sending max-age=0 by default
I am also in favor of not sending the header at all if enable = false (i.e. by default). I'm not an expert on this, but I believe in some imperfect configurations, some pages on a domain might provide max-age=31536000 while other pages (perhaps served by a different server) serve no HSTS header at all - the browser will still force those non-HSTS pages to load as HTTPS as long as it has seen any HSTS page on the domain previously within the max-age window. But if those non-HSTS pages were to send max-age=0 by default, without the sysadmin's knowledge, HSTS would effectively be getting turned on and off depending on which pages are visited.
tl;dr: We should only send max-age=0 when the sysadmin specifically chooses to do so, because I think it's a non-trivial decision and we can't be certain the default won't cause problems.

I would prefer this to be a seperate option rather than beeing included by default.


Change the modelling of the aerosols

the VAOD parameter is taken at 500 nm.
the angstrom exponent is now positive (default 1.2)

Thanks @sylvielsstfr . Now I think it corresponds to the Libradtran parametrization as stated in their documentation


Tweaks for public launch

Discussing at BlinkOn.

Replace the image and prose on the landing page currently the box between the red warning and "The Catalog". In its place, put "This dashboard is intended for browser engineers to locate low-level differences in support for APIs and to coordinate work."
Make the prose text smaller, 16px or so. Maybe smaller headings to match.

For the confluence metrics graph, make the text smaller (like a caption) and put it after the graphs.

All fixed, thanks @mdittmer!


change the header of navbar and allign pathsphere as same allign as o…

##change the header of pathsphere
Closes: #816
Description
Enhances user experience by providing clear feedback on successful registration.
Ensures users are properly guided to log in after creating an account.
Makes the registration process more interactive and user-friendly without any disruption to the existing functionality.
Details
This pull request updates the navigation bar to improve its layout and usability:
Navbar Width: The overall width of the navbar is reduced by setting a max-width of 1000px to make it more compact and centered.
Logo Alignment: Aligned the "PathSphere" logo with the navigation items using display: flex in the #navbar container to ensure a uniform alignment with the rest of the menu items.
Button Spacing: Reduced the space between the navigation links by adjusting the margin-right to 10px for more compact buttons.
Compact Buttons: The padding around the navigation links is reduced to make the buttons smaller and closer together.
Mobile Optimization: Ensured the hamburger menu is hidden on larger screens and appears only on smaller screens using a media query.
Types of Changes
Please check the boxes that apply

[☑ ] Bugfix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Please check the boxes that apply

[ ☑] My code follows the style guidelines of this project
[ ☑] I have performed a self-review of my own code
[☑ ] I have commented my code, particularly in hard-to-understand areas
[☑ ] I have made corresponding changes to the documentation
[☑ ] My changes generate no new warnings
[☑ ] My changes do not break the current system and pass all existing test cases
[☑ ] I have added tests tha

t prove my fix is effective or that my feature works
[ ☑] New and existing unit tests pass locally with my changes

Screenshots
If applicable, please attach screenshots of the changes made to the user interface.
Additional Information
Please provide any other information that is relevant to this pull request.

resolve conflicts @harshitgupta0910

if i dont get reply by tomorrow i will be closing this pr


merge

What is the purpose of the change
Brief changelog
Verifying this change

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #7 (24400d0) into master (3e02287) will increase coverage by 0.01%.
The diff coverage is 52.15%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e02287...24400d0. Read the comment docs.


Keybind support.

This PR introduces a basic keymap system. the system has the following components:

Commands: constants that defines an action like MoveUp, Quit. Should be used in input handlers to execute something when the command is sent.
Bind: A struct holding a Key and a Command. This struct is used as the actual mapping between a key and command.
Keymap: A collection of bindings. also provides a function for translating a key to a command that should be used in input handlers. the collection of bindings can be changed at runtime (loaded from config or something else in the future).

After this PR. there is 2 more functions to implement:

load bindings from config
have the ? key (this should be hardcoded) display a modal with information on what keys are binded to what commands.

That's an awesome PR, i'll check it out a bit more and come back with an approve/suggestion.
Thanks.


cannot delete aK/sK in s3Credentials

There is not a set method for me to build a S3Credential. When modify a user's aK/sK, I want to maintain only one pair of aK/sK, so I need to delete a S3Credential in the list or just build a new S3Credential. But I cannot build a S3Credential via setAk and setSk

Hi could you say more about why you need to change the key pair by S3Credential setter? How about
rgwAdmin.removeS3Credential("userId", "keyToDelete")
rgwAdmin.createS3Credential("userId")

@dearboll I will reopen this if you could provide more information.


[e2e]: delegator-generic tag main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v44.0.48
Run: https://github.com/slsa-framework/example-package/actions/runs/6011478687
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-generic.tag.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-generic.tag.main.default.slsa3.yml
Trigger: push
Branch: v44.0.48
Date: Tue Aug 29 11:17:53 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v44.0.49
Run: https://github.com/slsa-framework/example-package/actions/runs/6024101251
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-generic.tag.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-generic.tag.main.default.slsa3.yml
Trigger: push
Branch: v44.0.49
Date: Wed Aug 30 11:21:08 UTC 2023
Tests are passing now. Closing this issue.


sputnikdao2: fix vote before full amount of Ⓝ available

Fixes #25 although it's possible we want to take a different approach.

Doesn't allow someone to create a new Transfer proposal where the payout is in NEAR and exceeds the account balance of the contract
Doesn't allow anyone to vote for a Transfer proposal where the payout is in NEAR and similarly exceeds the account balance (because they might be the final vote that attempts to trigger the payout)
Adds a view method proposal_voting_ready where you give a parameter for the proposal ID and get a tuple back on whether the vote is ready and if not, why not (a warning code that can be used by the frontend to, for instance, disable the vote button)

Added a couple unit tests to check for the new errors.
Here is a helpful shell file to run or copy/paste showing how it works with the changes in this PR:
#!/bin/sh

# Change these to your account ids
export CONTRACT_ID=sputnikdao2.mike.testnet
export CONTRACT_PARENT=mike.testnet

# Redo account (if contract already exists)
near delete $CONTRACT_ID $CONTRACT_PARENT
near create-account $CONTRACT_ID --masterAccount $CONTRACT_PARENT

# Set up
near deploy $CONTRACT_ID --wasmFile ~/near/sputnik-dao-contract/sputnikdao2/res/sputnikdao2.wasm
export COUNCIL='["'$CONTRACT_ID'"]'
near call $CONTRACT_ID new '{"config": {"name": "genesis2", "purpose": "test", "metadata": ""}, "policy": '$COUNCIL'}' --accountId $CONTRACT_ID

# Add proposal for a Transfer kind that pays out 19 NEAR
near call $CONTRACT_ID add_proposal '{"proposal": {"description": "test", "kind": {"Transfer": {"token_id": "", "receiver_id": "demo.testnet", "amount": "19000000000000000000000000"}}}}' --accountId $CONTRACT_ID --amount 1

# Show the balance
near state $CONTRACT_ID

# Show that voting is ready
near view $CONTRACT_ID proposal_voting_ready '{"id": 0}'

# Transfer enough NEAR such that the Transfer proposal cannot complete successfully
near send $CONTRACT_ID $CONTRACT_PARENT 90

# Show that voting is not ready
near view $CONTRACT_ID proposal_voting_ready '{"id": 0}'

# Show error when a user tries to vote along with log
near call $CONTRACT_ID act_proposal '{"id": 0, "action": "VoteApprove"}' --accountId $CONTRACT_ID

We can't really check at the proposal creation time as it's possible that funds arrive later.
Also given the check at approval time - it will fail with the same mistake if there is not enough available funds as current asset.
Going to close this and instead focus on recovery from failed proposal completion


Functional tests: stop asserting against output and only look at file output

This would allow us to drop the --rerun-tasks flag from the build invocation, which should make the functional tests much faster.
There may still be some cases where it makes sense to verify console output. For example, the buildHealth task itself is just a default task that always prints to stdout, after executing its dependencies.

This was recently resolved.


docs: site footer + banner changes

Overview

What is it?

[ ] Feature / enhancement
[ ] Bug
[ ] Docs / tests / types / typos

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why

One use case

Another use case

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Thanks for reviewing @gioboa !
@thejackshelton we need to also add the "special sponsor" section above the fold, let's sync about it today

Thanks for reviewing @gioboa !
@thejackshelton we need to also add the "special sponsor" section above the fold, let's sync about it today

Sounds good. Will reach out.

That's great @thejackshelton Thanks

Thanks for the review Giorgio!


iPhone 6 is not supported?

Hi
I'm using this great scan tool to implement my app. very nice and fast.
no problem if I use iPhone 5s to scan QR code.
but once I use iPhone 6 to scan,  the API of QRCodeReader.isAvailable() returns false. could you tell me why? thanks

Hi,
I have an iPhone 6 and it works fine. Have you authorized the camera in your setting?

thanks for your feedback, the message was send by my user, i will confirm with him

yes, the user has not authorized the camera... thanks for your msg

:+1:


builder: darwin/arm lldb needs to pass SIGSEGV

The darwin/arm builder runs programs via lldb. (It is the only way to remotely dial the device running the binary.) The debugger likes to intercept signals that Go needs for normal operation. For example, there is a hidden panic inside the html/template tests that jams lldb. The obvious command does not work:
process handle SIGSEGV --stop false --pass true --notify false
It looks like passing on these signals may not be supported yet:
http://lists.cs.uiuc.edu/pipermail/lldb-dev/2013-July/002009.html

could we simply supply a stream of "continue" command to
lldb?
or make lldb do "continue" upon reception of the SIGSEGV
signal (gdb can do "catch signal SIGSEGV", and then we
can define command to be executed when SIGSEGV is
received.)

I tried that manually. Giving lldb a continue instruction does not seem to work. (Even several times.)

LLDB engineer says its a long standing OS X bug and recommends we work around it:
https://llvm.org/bugs/show_bug.cgi?id=22868


The newly generated libstdcxx.modulemap clashes with the libc++ modulemap on Android

Describe the bug
#41953 added a new C++ module map, but it is not needed for Android and causes errors like these on the Android CI:
/home/ubuntu/jenkins/workspace/oss-swift-RA-linux-ubuntu-16.04-android-arm64/buildbot_linux/swift-linux-x86_64/lib/swift/android/aarch64/libstdcxx.modulemap:19:8: error: redefinition of module 'std'
module std {
/home/ubuntu/android-ndk-r19c/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/c++/v1/module.modulemap:8:8: note: previously defined here

To Reproduce

Run one of the failing CI tests or the equivalent.

Expected behavior
Be able to import C++ without this error.
Environment:

OS: Android

Additional context
I've submitted a fix in #58497.

The community Android CI no longer shows this error, after my fix in #58497, so this works now.


Probability function returned NaN

Good morning,
I have an issue on emcee. The EnsembleSampler crashes after a few iterations and raises a ValueError: Probability function returned NaN. The thing is my user-defined probability function cannot return NaNs, as it defined something like this:
def my_probability_function(x):
    prob = logP(*x)
    if prob > 0 or np.isnan(prob): return -np.inf
    return prob

where logP is basically an evaluation of a beforehand-constructed RBF interpolator.
I call the EnsembleSampler like this:
import emcee
import numpy as np
from pathos.pools import ProcessPool

NW = 64 #Number of workers
ND = 7 #Number of dimensions
MCMC_PATH = 'path/to/backend.h5'
backend = emcee.backends.HDFBackend(MCMC_PATH)
backend.reset(NW, ND)
with ProcessPool(nodes=8) as pool:
    pool.restart()
    sampler = emcee.EnsembleSampler(NW, ND, my_probability_function, pool=pool, backend=backend)
    sampler.run_mcmc(p0, 5000, progress=True)

Changing the logP function to e.g. a nearest interpolator solves the problem, so I guess the issue comes from a bad interaction between emcee and scipy's RBF interpolator?
I tried advancing the MCMC iteration by iteration and comparing at each step the manual and emcee-stored evaluation of the probability function:
sampler.run_mcmc(pp, 1, skip_initial_state_check=True)
pp = sampler.get_chain(flat=True)[-NW:]

logP_manual = [my_probability_function(p) for p in pp]
logP_emcee, _ = sampler.compute_log_prob(pp)

diff = np.abs(1. - logP_manual/logP_emcee)

and at some point, diff was not identically zero, meaning that my_probability_function sometimes returns different results depending on if one evaluates it outside or inside emcee!
Can you help me please? Unfortunately, I was not able to replicate the problem in a minimalist example, as it only emerges when the RBF interpolator is constructed on my personal 2M data points in 7 dimensions.
Many thanks in advance.

I'm not too sure what to say here. There isn't any real reason why emcee would cause different behavior with your interpolator - it just directly calls the function you provide: https://github.com/dfm/emcee/blob/afba7a505b391b74d1eb2f27f1b1129c31a29948/src/emcee/ensemble.py#L489
Some thoughts:

There isn't any strong reason why a probability density needs to be less than 1, so you probably don't want the prob > 0 check in your function.
The only processing that emcee does with the results of your function call is to pass it though a Python float, so perhaps there's some numerical instability there, but if there is that suggests that there's probably something else wrong with your function. You might want to debug what's happening there?
Do you find the same behavior if you don't use multiprocessing? Perhaps there's an issue with multiprocessing and your interpolator.

Thank you very much for your answer. I'll try your suggestions and let you know.

Hi,
I was wondering if there are any updates on this issue?
I am seeing the same error while running the emcee fitter with the scipy skewed normal function, but not always. It seems to depend on the bounds I use for one of the parameters and the number of steps I use in the fit.


swift-reflection-test: correct typo in windows function name

Correct the spelling for the pipe function.  Windows prefixes the
remnant POSIX functions with _.  Fix the spelling to build on Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge


Add strategy to generate fastq file strings

Add strategy to generate fastq file strings [closes #33 ]
Rename original fastq function to fastq_entry
Add min and max length parameters to fastq_entry and fastq_quality strategies

As an aside, I wonder why the CI doesn't run for you at all. This is annoying.

I know. I can't figure out why. It runs on my fork. But for some reason not on the PRs. Super annoying. It's my first time working with them, but I'm not a big fan of these GitHub Actions

I tried to use GH actions since I have admin privileges on the repo but not on the L41 Travis so I figured it would make life more convenient. So much for that idea

On Oct 20, 2019, at 10:26 AM, Michael Hall<EMAIL_ADDRESS>wrote:
I know. I can't figure out why. It runs on my fork. But for some reason not on the PRs. Super annoying. It's my first time working with them, but I'm not a big fan of these GitHub Actions
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/Lab41/hypothesis-bio/pull/75?email_source=notifications&email_token=ADH4YHMJ4UPTZNPXUU6K6JLQPSIEJA5CNFSM4JCVC3MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYPEIQ#issuecomment-544272930, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADH4YHKCI36PO3IJA5DOT2LQPSIEJANCNFSM4JCVC3MA.


generic output ds share their description string

Trivial refactoring.

Another option is to have a base class for config with an output dataset.  This way you keep the description close to where it is needed.

+1


xWebAdministration: Move example from README.md to examples folder

This example https://github.com/PowerShell/xWebAdministration#registering-php should be moved to the Examples folder. Preferably in the root of the Examples folder as an end-to-end example.
Please note that examples are tested so they can be compiled.

I think I'd like to take a crack at this. Is this literally just taking the example and putting it in it's own ps1 file in the examples folder? I'm assuming that you'd still want the PHP instructions on the page, with a link to the example.

@Tuxhedoh Yeah, just put in the root of the Examples folder. Make sure the name says something with end-to-end so we can differentiate it from the individual resource examples (that should go in separate folders mentioned in another issue).
For the text, please add a comment-based help block as seen here.
https://github.com/PowerShell/ActiveDirectoryDsc/blob/3e96da395d40c8667702b03a6b8665dc1ee35486/Examples/Resources/ADComputer/1-ADComputer_AddComputerAccount_Config.ps1#L20-L24

All text goes in the comment-based help block, and remove it from the README.md entirely.

What's the proper etiquette when it comes to handling multiple issues in one repo? Make one PR and resolve them all? There seems to be quite a bit of low hanging fruit in this project. I recognize with Hacktoberfest there will probably be quite a few people clamoring for the issues to get their 4 pr's.

Just mention in an issue that your are working on it, then you may send in one PR that resolves them all or several PR's that solves one each. Normally I personally send in a PR fixing a bunch of PR's.
I expect during October to get small PR's resolving one issue. That was my meaning with all these hacktoberfest issues. I also hope new contributors (to GitHub) feel they want to try send in their first PR too.

I have not seen a PR for this issue so I have labeled it help wanted so that anyone can pick it up.


Some preparation for binary patterns

Follow up #178: improved the generalization of BinOpParser so it can be used in patterns more easily

bors r+

Build succeeded:

gradle-check

Thank you! Mamamia!


Ability to identify iCloud Private Relay not by string comparison

Hi, according to Maxmind docs, an IP can be tagged as iCloud Private Relay (string value) in ISP database. Would it be possible to introduce a boolean field instead to identify such IPs? For a high traffic load and latency sensitive proxy, it will be wasteful to perform string comparisons on each request.

This repo is specific to this library. I would suggest directing data questions to<EMAIL_ADDRESS>That said, I would expect the cost of the string comparison to be quite small compared to the cost of the lookup. For both booleans and strings, you could avoid the cost of deserializing by caching the offsets tot he data records.


[BUG] Entities stop responding after Core update to 2024.5.2

Describe the bug
After I update HA Core from 2024.3.0 to 2024.5.2 the entities stop responding and are no longer showing results.
Account type

[x] Installer
[ ] DIY / DHZ
[ ] Home Owner (This integration is not (fully) functional with a home owner account!)

Envoy

[x] Metered with CTs installed

[ ] Metered without CTs

[ ] Standard

FW version: D7.xxx

Amount of micro inverters connected: 22

Home Assistant

Version: 2024.3.0

Additional context
Relevant snippet of Home Assistant error log.

Hi. Please check if there is any relevant errors in the HA logs. Otherwise you can try to remove and reconfigure.

I loaded a backup of 2024.3.0 and then it works again...i will check for errors

I'm running into the same, I'll see if I can grab the logs for you from HASS

Hi @MatthewWaanders. And this started happening directly after upgrading HA? Can you maybe send the diagnostics file for the integration?

for me it started directly after upgrading HA. I eliminated all other updates as to this specific update. (iow I updated all other components I had without issues until HA Core was updated.)

Hi @vincentwolsink. I cannot confirm that for me it started after 2024.05.02 since I've only installed the integration recently and I was already on 2024.05.02. But the behaviour described in the bug is exactly what I'm also seeing: devices going unavailable and their entities reflecting this (and thus not displaying state information).
For me it has been quite erratic, sometimes it is available for larger amounts of time with only small blips of unavailability in between, but yesterday it was unavailable for 3+ hours.
I've attached the requested file to this comment
config_entry-enphase_envoy-def964ccfe93b27017df98e0b226a79c.json

yes, correct, when I look at individual entities it seems they are online for a short time but went offline again for a longer period. With my current version of HA I have no issues.

yes I run ipv4, is that the problem?

@vincentwolsink would a diagnostic file from a moment when the integration was not available help still?
I do have IPv4 and IPv6 enabled for my networks (Ubiquiti UDM SE) with no way of disabling it. The HA box as well as the Enphase Envoy have static IPv4 addresses in the network though. (And they're on the same VLAN) Also HA is set to IPv4 automatic and IPv6 disabled.
There's also some new messages in the logs regarding fetching the meter stream which results in HTTP 502 status codes being returned from /stream/meter upon reconnection attempts.

There has been an issue in the past where the integration would alternate between the ipv4 and ipv6 address due to zeroconf on a dualstack network. Maybe you can check which IP it has configured when the integration is not working (easiest method is to click the visit button at the envoy device page in HA). And at the same time you can check if you can actually open the Envoy page while HA cannot connect to it.

clicking visit on the device page, it says "blocked"

@suave123, which url does it go to? And can you make a screenshot?

browser says: about:blank#blocked

On my side this has magically disappeared and has been running stable for days now without me making any changes to the network or HA so that's welcome.

all inverters are still visible and reporting, but all the sensors have stopped reporting (like L1 L2 L3 etc.)


Add Trigger to simplify validating that an event occurred

Add a static method Trigger.Create() and Trigger.Create<TValue> which return an interface with a single Set()  or Set(TValue) method respectively.
Goal is to be able to react to events, e.g.
var trigger = Trigger.Create<int>();
var sut = new MyObject();
sut.OnValueReceived += (e, v) => trigger.Set(v.Value);

await Expect.That(trigger).IsSetWithin(200.Milliseconds()).AndValueShould().Be(5);

For this interface, we should have extension methods:

IsSetWithin(TimeSpan) which will wait the specified timeout for the trigger to be set
AndValueShould() for triggers with value, to get expectations on the value.

The trigger interface should not implement IDisposable directly, as this would lead to lots of unnecessary warnings in the test.

Maybe an alternative syntax would be
await Expect.That(sut).Should().Trigger(e => e.OnValueReceived).While(() => sut.ExecuteCommand("foo"));

Which would have to register on the OnValueReceived event, trigger the callback from While and then de-register itself from the callback.


Add University of Tsukuba, Japan (tsukuba.ac.jp)

This PR adds "University of Tsukuba" in Japan.
Here is the official website of the university: http://www.tsukuba.ac.jp/en/
Thank you.

@shuuji3 Pull request merged. Thank you!

@philipto Thank you for the very quick merging! 😄


Update runc to v1.1.15

What type of PR is this?
/kind dependency-change
What this PR does / why we need it:
Update runc to the latest release.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
None

/approve
/lgtm

Could we use dependabot or Renovate for this?


Add option to disable map/image zooming

There should be an option for disabling the zooming in when you hover over an athlete picture or map.

Is this not "enlarge on hover" ?

Huh, sorry about that, completely didn't see it. However:

and yet:

(pointer is over the avatar)

However

Can't reproduce that unfortunately.

Assuming is fixed, otherwise please re-open :)


Work to change any community uses of the phrase "Weaveworks Flux" to "(CNCF) Flux"

Various community blog posts, podcasts, etc prefix "Flux" with "Weaveworks". It should not be that way, now that Flux is a vendor-neutral CNCF project. Example search.
This is easy to accidentally overlook, since there are places where it makes sense to refer to both in the same sentence. For example "talking with folks from Weaveworks about Flux" is accurate and ok. But it's easy to shorten titles for marketing purposes, and the more examples out there like this the easier it is for new posts to follow in that vein.
This issue is to help consolidate efforts to fix existing incorrect references out in the wild.

Thanks @christianh814 and @chris-short for doing this from the Red Hat side 💯

I think this has been resolved


Bin the typesafe_config_base container

Currently our Scala apps fetch some metadata from ECS before they start: https://github.com/wellcomecollection/dockerfiles/blob/master/typesafe_config_base/bootstrap/bin/get_metadata
This is a holdover from when we used Logstash inside our app containers to do logging. Now we run Firelens in a separate container, I think we can ditch this.

See discussion here: https://wellcome.slack.com/archives/C3TQSF63C/p1594027719153000

This is our java11 container:
# Debian GNU/Linux 9 (stretch) - Includes Python2.7
FROM openjdk:11

LABEL maintainer = "Wellcome Collection<EMAIL_ADDRESS>LABEL description = "A Docker image for running Java"

RUN apt-get update
RUN apt-get install -y vim python-pip jq
RUN pip install awscli==1.16.213

and this is one of our typesafe_config_base definitions:
FROM wellcome/java11:121

LABEL maintainer = "Wellcome Collection<EMAIL_ADDRESS>LABEL description = "A Docker image base for Typesafe Wellcome apps"

RUN mkdir -p /opt/docker

EXPOSE 8888

COPY bootstrap/bin /bootstrap/bin

ENTRYPOINT ["/bootstrap/bin/start"]

There are three copies of typesafe_config_base floating around, and it's not clear where they come from – part of this is about reducing that confusion.

I believe this is done.


Split ResourcePage into multiple files

Split out chunks of <ResourcePage> into multiple files
Moved all of the resource page components into the "/resource/" folder
Moved a bunch of shared components into the "/components/" folder
Mostly a pure code cleanup refactor
One functional change is that the "Apps" tab will now always be visible, and a short message is displayed if there are no apps/questionnaires for that resource type
This is prep work for adding a new "Subscriptions"/"Bots" tab

Coverage decreased (-0.007%) to 94.564% when pulling e6a328946f3832d5f5cc77e75731ad2cd64fa398 on cody-app-resource-page-reorg into fb5730ef1cb7972d2607a3193cbf532f34cebe8e on main.


Add custom naming to schema generation

Environment

Nuget Package: JsonSchema.Net.Generation

Can this library make doing something simpler?

Add support for the JsonPropertyName attribute.

This is already implemented.  (I thought it was.)


Typo on Specify Upper and Lower Number of Matches page

Describe your problem and how to reproduce it:
The word spoiler is misspelled on the guide page linked below. I could not find on github how to fix/pull this page to fix the typo, but I'd be happy to if someone pointed me in the right direction.
Add a Link to the page with the problem:
https://guide.freecodecamp.org/certifications/javascript-algorithms-and-data-structures/regular-expressions/specify-upper-and-lower-number-of-matches/

This is a non-issue as the current version on the master branch no longer looks like this (see below).  We will be porting these articles to the forum soon, so you will see the changes there in the near future.  I am closing this, because we are just waiting for the guide to be ported.


implement --tree -d

Was looking at #295 and decided to have a crack

Codecov Report

Merging #426 into master will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   77.57%   77.47%   -0.10%
==========================================
  Files          34       34
  Lines        3304     3308       +4
==========================================
  Hits         2563     2563
- Misses        741      745       +4

Impacted Files
Coverage Δ

src/app.rs
95.91% <ø> (ø)

src/core.rs
0.00% <0.00%> (ø)

src/display.rs
25.36% <0.00%> (-0.51%)
:arrow_down:

src/meta/mod.rs
17.92% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b0aad6...b5b6e27. Read the comment docs.

there is probably a cleaner way to do it and have the logic together, ill have a look

I'm not sure why I get the clippy errors, I dont get them locally

Hey, there has been a relatively big change in how flags are managed due to the introduction of config file. Could you rebase this on top of current master.

i can only reproduce the clippy error on 1.43.1, not 1.46

Codecov Report

Merging #426 into master will increase coverage by 0.65%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   77.74%   78.39%   +0.65%
==========================================
  Files          34       34
  Lines        3329     3347      +18
==========================================
+ Hits         2588     2624      +36
+ Misses        741      723      -18

Impacted Files
Coverage Δ

src/app.rs
96.07% <ø> (ø)

src/core.rs
0.00% <0.00%> (ø)

src/flags.rs
0.00% <0.00%> (ø)

src/meta/mod.rs
17.43% <0.00%> (-0.50%)
:arrow_down:

src/flags/display.rs
90.90% <100.00%> (+1.51%)
:arrow_up:

src/flags/layout.rs
92.00% <100.00%> (+2.44%)
:arrow_up:

src/display.rs
25.49% <0.00%> (-0.39%)
:arrow_down:

src/flags/color.rs
89.15% <0.00%> (+1.20%)
:arrow_up:

src/flags/sorting.rs
92.40% <0.00%> (+1.26%)
:arrow_up:

src/flags/recursion.rs
78.03% <0.00%> (+1.33%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4991436...962bb50. Read the comment docs.

@meain this is ready if you're happy with it

maybe we should do a rebase or squash to remove the unnecessary commits before merging this?
it would be more complicated for others to rebase on top of many small commit and got an unclear commit history

Yeah just squash it

done!

Closing in favor of https://github.com/Peltoche/lsd/pull/456 . Thanks @0jdxt for getting it started.


Sustains heal even if base note missed

Describe your bug here.
The sustains heal you even after missing the original note, letting you to just hold down the key to heal.
This should not be intended behaviour as it lets you just hold down keys to pass anything that includes long notes.
In the example below, I just held down the keys. Pressed a few times but other than that I just held them down and passed it by healing from that mechanic.
Example:
https://user-images.githubusercontent.com/38793386/147571131-0a7dff83-db59-4e88-a8a7-b761b00a964e.mp4
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.

That's not a bug.

Shouldn't be intended either.

Stop ranting
go back with your loved engine if you want

I already gave you a fix if you want pull the PR and build the engine
there you have a working kade engine copy

I already gave you a fix if you want pull the PR and build the engine
there you have a working kade engine copy
dude this thread's been dead for a while, leave it alone


Wrong labels used for Layers tool

type labels are taken from the parent type (Classification) rather than the Name section:

Support info
Mon Nov 09 2020 09:23:06 GMT+0000 (Greenwich Mean Time)
Chrome 86.0.4240.183 [1920,1000]
https://v2.virtualflybrain.org/org.geppetto.frontend/geppetto?id=VFB_00000002%26i=VFB_00101567,VFB_00102162,VFB_00102280,VFB_00102119,VFB_00102135,VFB_00102146,VFB_00102148,VFB_00102271,VFB_00000002,VFB_00102107
%0A%0A%60%60%60diff%0A%2B Loading 18 slices/tiles...%0A%2B Loading 154 slices/tiles...%0A%2B medulla requested%0A%2B superior lateral protocerebrum requested%0A%2B Adding superior lateral protocerebrum%0A%2B adult gnathal ganglion requested%0A%2B Adding adult gnathal ganglion%0A%2B adult mushroom body alpha%2Dlobe requested%0A%2B Adding adult mushroom body alpha%2Dlobe%0A%2B ellipsoid body requested%0A%2B Adding ellipsoid body%0A%2B anterior ventrolateral protocerebrum requested%0A%2B Adding anterior ventrolateral protocerebrum%0A%2B posterior ventrolateral protocerebrum requested%0A%2B Adding posterior ventrolateral protocerebrum%0A%2B saddle requested%0A%2B Adding saddle%0A%2B medulla requested%0A%2B medulla requested%0A%2B anterior ventrolateral protocerebrum requested%0A%2B medulla requested%0A%2B adult gnathal ganglion requested%0A%2B medulla requested%0A%2B superior lateral protocerebrum requested%0A%2B superior lateral protocerebrum requested%0A%2B superior intermediate protocerebrum requested%0A%60%60%60%0A

Maybe not a blocker as these won't be wrong.
I guess this also shows potential rendering issue with long lists of lables?


Update order of actor and critic

It seems that you update critic before actor.
As far as I know, the actor_loss is calculated through critic network, so the backward of actor_loss will influence the grad of critic parameters.
Should we update actor first, and then update critic using both actor_loss and critic_loss?

In the original paper, they update critic first tho.


[Core] Add attributes

Every root concept should have a list of attributes accessed by "has" property.
Attributes are not only related to instances, it defines what kind of attributes a certain concept can have.
It can be extremely helpful to describe definitions.
Something handy is having some pre-defined attributes.
Every being has an attribute action born and the place can be earth.

[ ] Concepts should be moved from the knowledge package, some refactoring is needed.
[ ] Transform every class in the being package into attributes

Eg:
Being has name
Being has specie
Being can die
Specialized concepts can define default values
Eg:
Spider has legs, qty 8

[ ] Transform every class in the being package into attributes

[ ] Transform every class in the being package into attributes

Reference: https://www.researchgate.net/publication/222459556_Concepts_attributes_and_arbitrary_relations_Some_linguistic_and_ontological_criteria_for_structuring_knowledge_bases

Reference: https://www.researchgate.net/publication/222459556_Concepts_attributes_and_arbitrary_relations_Some_linguistic_and_ontological_criteria_for_structuring_knowledge_bases


remove unnecessary vertexAttribDivisorANGLE

When attribute's divisor is 0 (mostly), it doesn't need to call vertexAttribDivisorANGLE

duplicate of #571 , closing


Fix #7596: make sure context and system prompt is included in prompt for first chat

Description
Made changes to messages_to_prompt since previous behaviour was that the system prompt (which also includes the context if using the "context" chat engine) was not included in the prompt if it was the first chat interaction. The reason for this is because previously, there is a for loop over zip(messages[::2], messages[1::2]).
In the first chat interaction with the engine, messages should be a list of two ChatMessage objects, the first being a system message, the second being a user message. In the function, if the first message in messages was a system message, it would pull that out and messages = messages[1:].
This means that we never enter the for loop in the function since messages[::2] is a list of length 1 storing the user message, and messages[1::2] is an empty list, []. As a result, the system prompt is never included, and we only add the message at the end (with last_message=messages[-1]).
Therefore, any time we enter a chat using this messages_to_prompt function, we would never include the context or system prompt.
This PR attempts to solve this.
Fixes #7596 (and potentially #7057).
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Converting to draft to add some unit tests!

We've added some unit tests for messages_to_prompt (to ensure the system prompt/context is correctly being added into the first and later chats) and completion_to_prompt.

Interesting bug, thanks for fixing this!


Inconsistent COMMAND: COMMAND INFO DONT BEHAVE SAME WHEN USED ON SELF (ALSO NO RECURSION ON SUB COMMANDS WHEN USED INFO)(eg: COMMAND INFO COMMAND )

Steps to reproduce
COMMAND INFO COMMAND
Expected output
redis behaviour :

Observed output
The observed output when the above set of commands when run on DiceDB

Expectations for resolution
This issue will be considered resolved when the following things are done

register them based on commands not on command name or change in cmdMeta.Name for command .
make sure to recurse subcommands in case of command info .
addition of relevant test case to ensure we catch the regression.

i am working on command docs which will face same issue so i would like to get this assigned so i will do it in correct way for docs and correct it for info also , thanks

@sa-k-shore assigned, thanks for contributing.

i have raised a Merge Request  #993   with changes for #641 . please review, thanks.

Hello @sa-k-shore,
There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.

hi @arpitbbhayani we have merged this issue and websocket test cases i missed and i am picking it as another task


Reading the Documentation on Creating Configuration file

Provide a description of requested docs changes
Its not very clear on what that feature is and how i can create a configuration file on my own to setup all the projects with just click of a button

WinGet Configuration is documented at Microsoft Learn.


docker localhost needs to be exposed

So, localhost (<IP_ADDRESS>) needs to binding to the docker containers...
However, the hist adress should be configurable.

Fix docker localhost binding
Make host adress (server) configurable)

The Mac works in mysterious ways...

currently the server listens and servers on <IP_ADDRESS> (all interfaces) within the docker container. It is exposed with <IP_ADDRESS> (localhost) which will be a clients address for the server.  Maybe the listeners adress(<IP_ADDRESS>) needs to be configurable.


Hiding activity

Feature Description
Is there a way to remove the game name without using extra metadata logos and remove the activity panel?
Thanks
Screenshots

The GameActivity extension controls can be disabled in the GameActivity extension settings, although currently I think the panel itself won't disappear so that needs to be fixed.

Yeah, there doesn't seem to be any option for hiding the panel fully. The reason that I am requesting it is because right now I have to scroll down to see the news section, and I don't want to remove the activity extension since I use it to track my progress. I know it's a small issue but I still wanted to request it since that has been the only nitpick I have had, and outside of it, it's a really great theme.


Occasional bug gst_buffer_resize_range

module-1          | (python:1): GStreamer-CRITICAL **: 13:46:36.541: gst_buffer_resize_range: assertion 'bufmax >= bufoffs + offset + size' failed
module-1 exited with code 0

When the module restarts, it works normally. But I saw a situation when it did not restart.

Not reproduces


Only a few images loading on HDD

is it only here? or is it happening with everyone?
also, lots of similar images
@kodadot/internal-dev

@preschian

for images similar with this https://github.com/kodadot/nft-gallery/issues/10144#issuecomment-2080369550
puppeter on workers not perfectly fine. should we use that vercel one for capture? @vikiival
for items that doesn't have serial numbers will be fixed in here https://github.com/kodadot/private-workers/issues/121#issuecomment-2088442621

If puppeteer on Deno can give the same capabilities as node.js, I can try to spin up on Deno

most of them should be already backfilled

cc @preschian

https://github.com/kodadot/private-workers/issues/136

updated

preview images
for now. Let's use Puppeteer on non-serverless infra

serial numbers
fixed here:
https://assethub-polkadot.subscan.io/extrinsic/6210495-2
https://assethub-polkadot.subscan.io/extrinsic/6210576-3
currently, some scripts are running every hour to address this issue. Once the script looks good, I will move the script to the private-workers


Save Error

Error: Service Unavailable
Error: Service Unavailable
    at Request.<anonymous> (https://homebrewery.naturalcrit.com/homebrew/bundle.js:71831:19)
    at Request.Emitter.emit (https://homebrewery.naturalcrit.com/homebrew/bundle.js:1764:20)
    at XMLHttpRequest.xhr.onreadystatechange (https://homebrewery.naturalcrit.com/homebrew/bundle.js:72140:10)
{
  "status": 503,
  "method": "POST",
  "url": "/api/newGoogle/"
}

Take a look at the help info in discussion #1580 -- if that doesn't do it for you, come back here and the issue can be re-opened. For now, closing as duplicate.


Uncaught Error: ENOENT: no such file or directory, lstat '~/Desktop\ModelisationBlocOperatoire'

Open a project folder
Delete it on Windows Explorer
Close Atom
Reopen it
It should work

Atom: 1.25.0 x64
Electron: 1.7.11
OS: Windows 10 Familial (Version 10.0.16299 Number 16299)
Thrown From: Atom Core
Stack Trace
Uncaught Error: ENOENT: no such file or directory, lstat 'C:\Users\rochr\Desktop\ModelisationBlocOperatoire'
At fs.js:961

Error: ENOENT: no such file or directory, lstat 'C:\Users\rochr\Desktop\ModelisationBlocOperatoire'
    at fs.lstatSync (fs.js:961:11)
    at Object.fs.lstatSync (ELECTRON_ASAR.js:244:16)
    at Proxy.realpathSync (fs.js:1641:21)
    at Proxy.fs.realpathSync (ELECTRON_ASAR.js:321:29)
    at atom.project.getPaths.map (~/AppData/Local/atom/app-1.25.0/resources/app/node_modules/fuzzy-finder/lib/path-loader.js:16:73)
    at Array.map (native)
    at Object.startTask (~/AppData/Local/atom/app-1.25.0/resources/app/node_modules/fuzzy-finder/lib/path-loader.js:16:56)
    at Object.startLoadPathsTask (~/AppData/Local/atom/app-1.25.0/resources/app/node_modules/fuzzy-finder/lib/main.js:109:43)
    at get_process.nextTick (~/AppData/Local/atom/app-1.25.0/resources/app/node_modules/fuzzy-finder/lib/main.js:25:45)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

Commands

Non-Core Packages
atom-beautify 0.32.2
atom-clock 0.1.16
atom-ide-ui 0.9.4
atom-python-run 0.9.6
autocomplete-python 1.10.5
autocomplete-xml 0.9.4
autumn-highlighter-syntax 1.13.0
busy-signal 1.4.3
highlight-selected 0.13.1
Hydrogen 2.3.0
ide-csharp 0.6.2
intentions 1.1.5
kite 0.74.0
linter 2.2.0
linter-ui-default 1.7.1
linter-xmllint 1.4.3
package-switch 0.5.0
python-tools 0.6.9
sync-settings 0.8.5
webbox-color 0.5.9
xml-formatter 0.11.0

Thanks for contributing!
Based on the stack trace I'll go ahead and close as a duplicate of https://github.com/atom/fuzzy-finder/issues/255 so you can subscribe there for updates if you'd like.
About your repro steps, I gave it a try and I don't see the same error I get https://github.com/atom/atom/issues/16645 which I kinda expect?

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


After update to vscode 1.20.0 'launch.json does not exist' on debugger startup

VSCode Version: 1.20.0
OS Version: macOS Sierra 10.12.6

After updating to VSCode 1.20.0, I tried to run my debugger, but got a "'launch.json' does not exist" error. I have the following configuration in my 'User Settings' file:
"launch": {
        "version": "0.2.0",
        "configurations": [
            {
                "type": "node",
                "request": "launch",
                "name": "Mocha",
                "program": "${workspaceFolder}/node_modules/.bin/gulp",
                "args": [
                    "mocha"
                ],
                "internalConsoleOptions": "openOnSessionStart"
            }
        ]
    }

The same error is found in all my projects. I tried creating a 'launch.json' file, but got the same result.
Does this issue occur when all extensions are disabled?: Yes

I encountered the same error as you.
Please fix it as soon as possible.

As a workaround: copy launch config into launch.json, comment out launch config in user settings, and quitting/relaunch gets you running again.

@matthewlein Yes, now it works.
I add launch config to user.settings before:

"launch": {
    "version": "0.2.0",
    "configurations": [
        {
            "type": "python",
            "request": "launch",
            "name": "Python",
            "program": "${file}"
        }
    ]
},

When I deleted, it works now.

Duplicate of https://github.com/Microsoft/vscode/issues/43461
As explained in that issue
"
The fix will be in vscode insiders tomorrow. I understand this is breaking behavior compared to our stable, however the fix is a bit tricky and I speculate that the number of users depending on this feature are quite small, thus I decided to not make this a candidate (even though it is a regression). Users depedning on this feature can use the insiders from tomorrow
"
So please try the latest vscode insiders and let me know if that fixes the issue.
Apart from that I am now investigating into a minimal fix to push as a candidate release.

This issue will be fixed in the stable recovery release.
Verifier check:

You can debug in a no folder workspace
You can debug using a user launch json in a single folder workspace
You can debug in a multi folder workspace using multi folder compounds

Note that user settings are not support in mulit folder workspace(this was behavior in the previous stable) and this will be fixed in the next stable release.

FWIW the current Insiders build does not solve this issue for me.
I work in a single folder workspace, and have all my launch options set up in my user preferences. I get this overtime I enter debug mode :
Failed to launch the Python Process, please validate the path '/path/to/anaconda3/envs/py3/bin/python'

@nbara that is an unrelated issue. You can file it against the python extension, or find more details here https://github.com/Microsoft/vscode/issues/43303


Make the password change successful box size dynamically to text content

Is your feature request related to a problem? Please describe.
The password change successful popup can only fit a small amount of text in it's current state. It a great place to add additional information for users.
Describe the solution you'd like
Remove the fixed size box cdk-overlay-3 or make it larger say
current:
width: 300px
height: 300px
proposed:
width:85%
remove the height limit

I would also prefer to not autoclose error messages or at least to have a configuration option on this behaviour
regards


v0.2.4 missing drivers

Hi
Thanks for this repository!
The newest version seems to be missing some files. I've tested doing a mkdir build / cd build / cmake .. / make on both v0.2.3 and v0.2.4. v0.2.3 succeeds, but v0.2.4 errors on the cmake with:
CMake Error at examples/breakout_bme688/bme688_parallel.cmake:3 (add_executable):
  Cannot find source file:

    /Users/william/Pi/pimoroni-pico-2.4/drivers/bme68x/src/bme68x.c

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc
Call Stack (most recent call first):
  examples/breakout_bme688/CMakeLists.txt:2 (include)

CMake Error at examples/breakout_bmp280/bmp280_basic.cmake:3 (add_executable):
  Cannot find source file:

    /Users/william/Pi/pimoroni-pico-2.4/drivers/bmp280/src/bmp280.c

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc
Call Stack (most recent call first):
  examples/breakout_bmp280/CMakeLists.txt:1 (include)

CMake Error at examples/breakout_bme280/bme280_basic.cmake:3 (add_executable):
  Cannot find source file:

    /Users/william/Pi/pimoroni-pico-2.4/drivers/bme280/src/bme280.c

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc
Call Stack (most recent call first):
  examples/breakout_bme280/CMakeLists.txt:1 (include)

and then fails on make with:
In file included from /Users/william/Pi/pimoroni-pico-2.4/examples/breakout_bme688/bme688_parallel.cpp:5:
/Users/william/Pi/pimoroni-pico-2.4/drivers/bme68x/bme68x.hpp:5:10: fatal error: bme68x.h: No such file or directory
    5 | #include "bme68x.h"
      |          ^~~~~~~~~~
compilation terminated.
make[2]: *** [examples/breakout_bme688/CMakeFiles/bme688_parallel.dir/bme688_parallel.cpp.obj] Error 1
make[1]: *** [examples/breakout_bme688/CMakeFiles/bme688_parallel.dir/all] Error 2

Oh scratch that -- it needed a git submodule update --init which I hadn't thought to try
So I think the issue is actually that https://github.com/pimoroni/pimoroni-pico/blob/main/setting-up-the-pico-sdk.md needs an update

Ooof! Yes. I will get the documentation updated. Relied too much on the continuous integration telling me it worked and totally neglected that!


Add filename and filepath to classname and title templates strings

This is useful for making the combination of classname + title unique, which need depend on at Dropbox.

@samertm thanks again for the contributions! If you wouldn't mind would you also add a test (if possible) here for this? https://github.com/palmerj3/jest-junit/blob/master/tests/buildJsonResults.test.js

Yup!

Just updated the commit.

Perfect thank you!

@samertm just published 3.4.1 with these changes. Thanks again!

Thanks for the fast turn-around!


Hash map and hash set (deprecated headers)

Hi, this is an attempt to replace the deprecated headers to avoid a bunch of compiler warnings. This is required for the R repository (CRAN) where my derived R package is hosted, so it would be great to get it fixed in the actual upstream code.
I think (hope) the fix works for the code in the actual library, but I'm not sure about the tests. The changes are mainly based on a bunch of search and replace work with sed, and not reflecting much understanding about what is really going on in the code.
The tweak to CMakeLists.txt was necessary to set the C++11 compiler flag (even though I thought the old CMakeLists.txt already did set this correctly).

Thanks, but I'm shutting down this repository.
Please send PRs to either @yjwong's repository instead, or consider using Google's version new version of S2.


Add TypeScript typings

These come from the @types/long NPM package, originally written by Denis
Cappellin @cappellin, I only made a few modifications when I brought these over.
The dtslint tool lints the index.d.ts file and tests it by compiling (but not running) the test file, compiling using the tsconfig.json file. See the dtslint docs for more info on that.
I modified this because import Long from 'long'; was not working in a different project. I did not include the custom tslint file (didn't take the time to read the modifications; it's already being linted by dtslint). I'm pretty new to TS so there may be something wrong, but having it here should allow for a better feedback loop to correct any issues.

Looking good so far, thanks! Just a few comments, and let me also suggest to place typing at ./index.d.ts so that requiring the package by path will automatically provide the typings as well.

Thank you! :)

@dcodeIO Could you release a new version please?

@dcodeIO Could you publish this please?

@decodeIO Can you please publish this? Current 4.0.0 version does not have the type definitions. What is the use of keeping the type definition in the repo and not publishing it to npm?

@dcodeIO Can you please publish this? Current 4.0.0 version does not have the type definitions. What is the use of keeping the type definition in the repo and not publishing it to npm?


FIX: sentinel path

niworkflows/utils/tests/test_misc.py::test_fs_license_check2 SKIPPED

this shouldn't be happening...

looking good now. i'm gonna merge this in and release so 20.1.1 isn't breaking anymore
niworkflows/utils/tests/test_misc.py::test_fs_license_check2 PASSED

niworkflows/utils/tests/test_misc.py::test_fs_license_check3 PASSED


Package broken?

Hi and thanks for making this ! it seems like the only option for truly incorporating latex into Makie plots!
I tried running the example in "Quick Start" but it did not work.
Is it something that can be fixed?

It seems not working on my machine too.
After using MakieTex, it do not process latex string by compiling a stand-alone LaTeX document to PDF.
versioninfo:
julia> versioninfo()
Julia Version 1.8.1
Commit afb6c60d69 (2022-09-06 15:09 UTC)
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: 12 × Intel(R) Core(TM) i5-10400 CPU @ 2.90GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, skylake)
  Threads: 6 on 12 virtual cores
Environment:
  JULIA_NUM_THREADS = 6
  JULIA_PKG_SERVER = https://mirrors.tuna.tsinghua.edu.cn/julia
  JULIA_EDITOR = code
pkg> st Makie MakieTeX
  [ee78f7c6] Makie v0.17.13
  [6d554a22] MakieTeX v0.2.3

any progress?


Any reason why serial is not as an option

The moment I saw parallel, next option that came to my mind, was serial. On error, realized, that it should sequential.
It would be great to have serial as a synonymous option for sequential
Happy to raise a PR, if you are convinced.
Thanks!!

Thank you for the proposal.
I appreciate the PR.
Since I'm not familiar with English, I hadn't noticed that word...


Report remote configs in breakage report

Task/Issue URL: https://app.asana.com/0/488551667048375/1203162345927883/f
Description
Send the remote configs in the breakage reports for better debugging
Steps to test this PR
Test breakage report

[ ] install/update from this branch
[ ] filter logcat by m_atp_breakage_report
[ ] report AppTP breakage for any app
[ ] copy the value for breakageMetadata (it's base64)
[ ] ensure the unencoded json contains the remoteConfigInfo object with a map of config/value pairs (you can use https://onlinestringtools.com/convert-base64-to-string to unencode the base64)

Current dependencies on/for this PR:

develop

PR #2414   👈

This comment was auto-generated by Graphite.


Update ELB Name Length Limit

This needed to be 32 character because that was the limit of an ELB's name. Now this exists as a tag, so the length can be up to 255 characters.

👍


Generation of files in "examples/direct/expected"

Hi, I am adding some more direct test ASMs to the project so xxxx_expected.txt should also be added.
I'd like to know, how the files in "examples/direct/expected" are generated? I didn't see any info about this in docs.

Ran the code, checked the output matched my expectations, copy/pasted into the expected output.
The idea being that I only have to manually check the output once, and then any deviations from that will cause a test failure.

Yeah, sounds reasonable, and thanks.