can we configure gitleaks as a global level hook/template

Hi Team,
I can understand that gitleaks can be confgired as  a pre-commit hook as per below instructions .
Create a .pre-commit-config.yaml file at the root of your repository with the following content:
repos:

repo: https://github.com/zricethezav/gitleaks
rev: v8.2.0
hooks:

id: gitleaks

here my question is instead of creating a .pre-commit-config.yaml file at root of the project, is there any chance to copyset as pre-commit hook  into inside the project hooks directory itself i.e. projectname/.git/hooks/pre-commit
and also another query is , can we configure gitleaks as global hook template.
git config --global init.templatedir '~/.git-templates'
mkdir -p ~/.git-templates/hooks
Write your hooks in ~/.git-templates/hooks.
chmod a+x ~/.git-templates/hooks/post-commit
so that we no need to set up the hooks for every project manually.whenver we create a new project it will directly copy the hooks from the global hook tempalte.
we are trying to use gitleaks in our project, and we are looking to reduce the manual work..Could you please help to answer the above two questions.
thanks
venkat

This global hook install helper does exactly that, but since "Git currently only allows to have a global or a local githook folder […] we can't chain global and local pre-commit hooks". So, you have to decide between global & local pre-commit hooks.

Hi Team,
Thanks a lot for your kind response. As per your guidelines i have followed to install gitleaks as a pre-commit hook at global level as per listed command
bash <(curl https://gitlab.com/gitlab-com/gl-security/security-research/gitleaks-endpoint-installer/-/raw/main/install.sh)
After that i have done the commit on WebGoat repo and getting below message. could you please let me know where can i find the report?
[brsubbareddy123@gitleaksone ~]$ git config --global --list
user.name=xxxxxxxxxxx
<EMAIL_ADDRESS>core.hookspath=/home/brsubbareddy123/.gitlab-gitleaks/hooks
[brsubbareddy123@gitleaksone ~]$ pwd
/home/brsubbareddy123
[brsubbareddy123@gitleaksone ~]$ cd .gitlab-gitleaks/
[brsubbareddy123@gitleaksone .gitlab-gitleaks]$ cd hooks
[brsubbareddy123@gitleaksone hooks]$ ls -ltr
total 4
-rwxrwxr-x. 1 brsubbareddy123 brsubbareddy123 359 Aug 22 09:54 pre-commit
[brsubbareddy123@gitleaksone hooks]$ cd
[brsubbareddy123@gitleaksone ~]$ cd testone/
[brsubbareddy123@gitleaksone testone]$ cd WebGoat/
[brsubbareddy123@gitleaksone WebGoat]$ ls -ltr
total 116
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123  4417 Aug 22 09:56 CODE_OF_CONDUCT.md
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123  7701 Aug 22 09:56 RELEASE_NOTES.md
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123  4454 Aug 22 09:56 README.md
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123  1846 Aug 22 09:56 README_I18N.md
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123    55 Aug 22 09:56 PULL_REQUEST_TEMPLATE.md
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123   996 Aug 22 09:56 LICENSE.txt
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123  1048 Aug 22 09:56 Dockerfile
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123   990 Aug 22 09:56 CREATE_RELEASE.md
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123  1003 Aug 22 09:56 COPYRIGHT.txt
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123  7799 Aug 22 09:56 CONTRIBUTING.md
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123  6609 Aug 22 09:56 mvnw.cmd
-rwxrwxr-x. 1 brsubbareddy123 brsubbareddy123 10078 Aug 22 09:56 mvnw
-rwxrwxr-x. 1 brsubbareddy123 brsubbareddy123   131 Aug 22 09:56 mvn-debug
drwxrwxr-x. 2 brsubbareddy123 brsubbareddy123    41 Aug 22 09:56 docs
drwxrwxr-x. 4 brsubbareddy123 brsubbareddy123    48 Aug 22 09:56 config
drwxrwxr-x. 2 brsubbareddy123 brsubbareddy123    41 Aug 22 09:56 robot
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123 28736 Aug 22 09:56 pom.xml
drwxrwxr-x. 5 brsubbareddy123 brsubbareddy123    40 Aug 22 09:56 src
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123    22 Aug 22 09:57 file1.txt
[brsubbareddy123@gitleaksone WebGoat]$ git commit -m "test the code"
/home/brsubbareddy123/.gitlab-gitleaks/hooks/pre-commit: line 9: /home/brsubbareddy123/.gitlab-gitleaks/gitleaks: No such file or directory
Commit failed.
gitleaks has detected some secrets in your commit.
Please see https://about.gitlab.com/handbook/engineering/security/gitleaks.html for more details.[brsubbareddy123@gitleaksone WebGoat]$ ^C
[brsubbareddy123@gitleaksone WebGoat]$
after that I have a created a directory  as "gitleaks" under ".gitlab-gitleaks"  to overcome the "/home/brsubbareddy123/.gitlab-gitleaks/hooks/pre-commit: line 9: /home/brsubbareddy123/.gitlab-gitleaks/gitleaks: No such file or directory"
[brsubbareddy123@gitleaksone ~]$ cd .gitlab-gitleaks/
[brsubbareddy123@gitleaksone .gitlab-gitleaks]$ ls -ltr
total 2364
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123    1809 Aug 22 09:54 Readme.md
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123    1076 Aug 22 09:54 LICENSE
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123    2209 Aug 22 09:54 CONTRIBUTING.md
-rwxrwxr-x. 1 brsubbareddy123 brsubbareddy123      77 Aug 22 09:54 setup_hook.sh
-rwxrwxr-x. 1 brsubbareddy123 brsubbareddy123    1283 Aug 22 09:54 install.sh
-rwxrwxr-x. 1 brsubbareddy123 brsubbareddy123     708 Aug 22 09:54 install_gitleaks.sh
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123    1187 Aug 22 09:54 checksums.txt
-rw-rw-r--. 1 brsubbareddy123 brsubbareddy123 2390525 Aug 22 09:54 gitleaks_8.5.2_linux_x64.tar.gz
drwxrwxr-x. 2 brsubbareddy123 brsubbareddy123       6 Aug 22 11:30 gitleaks
drwxrwxr-x. 2 brsubbareddy123 brsubbareddy123      24 Aug 22 11:34 hooks
[brsubbareddy123@gitleaksone .gitlab-gitleaks]$ pwd
/home/brsubbareddy123/.gitlab-gitleaks
[brsubbareddy123@gitleaksone .gitlab-gitleaks]$ cd gitleaks
[brsubbareddy123@gitleaksone gitleaks]$ pwd
/home/brsubbareddy123/.gitlab-gitleaks/gitleaks
[brsubbareddy123@gitleaksone gitleaks]$
but still getting the error as below and unable to see the report...
[brsubbareddy123@gitleaksone WebGoat]$ git commit -m "test"
/home/brsubbareddy123/.gitlab-gitleaks/hooks/pre-commit: line 9: /home/brsubbareddy123/.gitlab-gitleaks/gitleaks: Is a directory
Commit failed.
gitleaks has detected some secrets in your commit.
Please see https://about.gitlab.com/handbook/engineering/security/gitleaks.html for more details.[brsubbareddy123@gitleaksone WebGoat]$
Could you please let me know how to get the report? Does something need to change in the pre-commit file?
thanks
venkat

Hi @venkatn087, please note that that GitLab tool is not affiliated with gitleaks. The output of ls -ltr above shows, that your gitleaks is not the expected binary, but a directory. Possibly, the installer script didn't complete.
My apologies for providing this not-working-after-all tip. It's probably best to uninstall ~/.gitlab-gitleaks completely and wait for official support.

A global pre-commit hook installer sounds like a good idea. gitleaks install pre-commit or something. I'm not sure when I can work on this but happy to review a PR if someone wants to work on this


docs(customizing_deis): remove unused registry secret key

This key was removed in a recent release of the docker registry so it
is no longer in use.

If it isn't used, we should probably clean up https://github.com/deis/deis/blob/8826c83b28a573334083edc83571488238857924/registry/bin/boot#L45 as well.

good catch, done

Code LGTM.

Cleaning up the unused registry secret key is good, I always like to see negative LOC. Code LGTM.


Save augmentations

This PR aims at only saving the augmented rows.

Closes Issue : #504

Checklist:

[ ] I've added Google style docstrings to my code.
[ ] I've used pydantic for typing when/where necessary.
[ ] I have linted my code
[ ] I have added tests to cover my changes.

LGTM 🚀

Thanks for the review !


Implement trunk rendering

This PR implements rendering for trunk roads.

Once trunk rendering is complete, the next step is to look across motorway and trunk to see how we can refactor out all the copy/paste in the road layer (after just two highway classes so far!)

I've got a refactor branch in progress, recommend you hold off until I post it so we don't get cross-threaded.


Error while building on Mac

Getting error while building on MAC OS Catalina 10.15.7

Hi Initially i got this error, the below error regarding subdirectories does not contain a CMakeLists.txt file. So, I copied the clickhouse-odbc/CMakeLists.txt to clickhouse-odbc/contrib/ssl and clickhouse-odbc/contrib/poco subdirectories path manually.

(base) miraj@Miraj-13inch-mac build % cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DOPENSSL_ROOT_DIR=$(brew --prefix)/opt/openssl -DICU_ROOT=$(brew --prefix)/opt/icu4c ..
The C compiler identification is AppleClang <IP_ADDRESS>00032
The CXX compiler identification is AppleClang <IP_ADDRESS>00032
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- CMAKE_BUILD_TYPE: RelWithDebInfo
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found iODBC: TRUE
-- Using ODBC: iODBC
-- 	ODBC_DIR=/usr/local/Cellar/libiodbc/3.52.13
-- 	ODBC_CONFIG_SCRIPT=/usr/local/bin/iodbc-config
-- 	ODBC_IODBC_IODBCTEST=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctest
-- 	ODBC_IODBC_IODBCTESTW=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctestw
-- 	ODBC_APP_DEFINES=
-- 	ODBC_APP_INCLUDE_DIRS=/usr/local/Cellar/libiodbc/3.52.13/include
-- 	ODBC_APP_COMPILER_FLAGS=
-- 	ODBC_APP_LINKER_FLAGS=-L/usr/local/Cellar/libiodbc/3.52.13/lib;-liodbc
-- 	ODBC_DRIVER_DEFINES=
-- 	ODBC_DRIVER_INCLUDE_DIRS=/usr/local/Cellar/libiodbc/3.52.13/include
-- 	ODBC_DRIVER_COMPILER_FLAGS=
-- 	ODBC_DRIVER_LINKER_FLAGS=-L/usr/local/Cellar/libiodbc/3.52.13/lib;-liodbcinst
-- Found ODBC: TRUE
-- Found the following ICU libraries:
--   uc (required)
-- Found ICU: /usr/local/opt/icu4c/include (found version "67.1")
CMake Error at contrib/CMakeLists.txt:21 (add_subdirectory):
The source directory
/Users/miraj/Downloads/clickhouse-odbc/contrib/ssl

does not contain a CMakeLists.txt file.
CMake Error at contrib/CMakeLists.txt:54 (add_subdirectory):
The source directory
/Users/miraj/Downloads/clickhouse-odbc/contrib/poco

does not contain a CMakeLists.txt file.
CMake Error at contrib/CMakeLists.txt:67 (add_library):
add_library cannot create ALIAS target "Poco::Net" because target "Net"
does not already exist.
CMake Error at contrib/CMakeLists.txt:68 (add_library):
add_library cannot create ALIAS target "Poco::Foundation" because target
"Foundation" does not already exist.
CMake Error at contrib/CMakeLists.txt:69 (add_library):
add_library cannot create ALIAS target "Poco::Util" because target "Util"
does not already exist.
CMake Error at contrib/CMakeLists.txt:72 (set_property):
set_property could not find TARGET Net.  Perhaps it has not yet been
created.
CMake Error at contrib/CMakeLists.txt:73 (set_property):
set_property could not find TARGET Foundation.  Perhaps it has not yet been
created.
CMake Error at contrib/CMakeLists.txt:116 (add_subdirectory):
The source directory
/Users/miraj/Downloads/clickhouse-odbc/contrib/googletest

does not contain a CMakeLists.txt file.
CMake Error at contrib/CMakeLists.txt:121 (set_target_properties):
set_target_properties Can not find target to add properties to: gtest
CMake Error at contrib/CMakeLists.txt:122 (set_target_properties):
set_target_properties Can not find target to add properties to: gtest_main
CMake Error at contrib/CMakeLists.txt:123 (set_target_properties):
set_target_properties Can not find target to add properties to: gmock
CMake Error at contrib/CMakeLists.txt:124 (set_target_properties):
set_target_properties Can not find target to add properties to: gmock_main
CMake Error at contrib/CMakeLists.txt:140 (add_subdirectory):
The source directory
/Users/miraj/Downloads/clickhouse-odbc/contrib/nanodbc

does not contain a CMakeLists.txt file.
CMake Error at contrib/CMakeLists.txt:142 (set_target_properties):
set_target_properties Can not find target to add properties to: nanodbc
-- clickhouse-odbc: ANSI
-- clickhouse-odbcw: Unicode
install_driver(ODBC) failed: Can't locate DBD/ODBC.pm in @INC (you may need to install the DBD::ODBC module) (@INC contains: /Library/Perl/5.18/darwin-thread-multi-2level /Library/Perl/5.18 /Network/Library/Perl/5.18/darwin-thread-multi-2level /Network/Library/Perl/5.18 /Library/Perl/Updates/5.18.4 /System/Library/Perl/5.18/darwin-thread-multi-2level /System/Library/Perl/5.18 /System/Library/Perl/Extras/5.18/darwin-thread-multi-2level /System/Library/Perl/Extras/5.18 .) at (eval 8) line 3.
Perhaps the DBD::ODBC perl module hasn't been fully installed,
or perhaps the capitalisation of 'ODBC' isn't right.
Available drivers: DBM, ExampleP, File, Gofer, Proxy, SQLite, Sponge.
at /Users/miraj/Downloads/clickhouse-odbc/test/detect_driver_manager.pl line 11.
-- ODBC Driver Manager used by Perl's DBD::ODBC:
Traceback (most recent call last):
File "/Users/miraj/Downloads/clickhouse-odbc/test/detect_driver_manager.py", line 5, in
import pyodbc
ImportError: No module named pyodbc
-- ODBC Driver Manager used by Python 2's pyodbc:
-- ODBC Driver Manager used by Python 3's pyodbc: unixODBC
-- Testing with:
TEST_DSN_LIST=ClickHouse DSN (ANSI);ClickHouse DSN (Unicode)
PERL=/usr/bin/perl
PERL_USES_MDAC=0
PERL_USES_UNIXODBC=0
PERL_USES_IODBC=0
PYTHON2=/usr/bin/python2
PYTHON2_USES_MDAC=0
PYTHON2_USES_UNIXODBC=0
PYTHON2_USES_IODBC=0
PYTHON3=/Users/miraj/opt/anaconda3/bin/python3
PYTHON3_USES_MDAC=0
PYTHON3_USES_UNIXODBC=1
PYTHON3_USES_IODBC=0
ODBC_UNIXODBC_ISQL=
ODBC_UNIXODBC_IUSQL=
ODBC_IODBC_IODBCTEST=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctest
ODBC_IODBC_IODBCTESTW=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctestw
SQLCMD=SQLCMD-NOTFOUND
-- Configuring incomplete, errors occurred!
See also "/Users/miraj/Downloads/clickhouse-odbc/build/CMakeFiles/CMakeOutput.log".

Then i got the errors in include, as below, which i fixed by putting the full path in include of these files contrib/ssl/CMakeLists.txt and cmake/Modules/FindiODBC.cmake files.

(base) miraj@Miraj-13inch-mac build % cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DOPENSSL_ROOT_DIR=$(brew --prefix)/opt/openssl -DICU_ROOT=$(brew --prefix)/opt/icu4c ..
-- CMAKE_BUILD_TYPE: RelWithDebInfo
-- Using ODBC: iODBC
-- 	ODBC_DIR=/usr/local/Cellar/libiodbc/3.52.13
-- 	ODBC_CONFIG_SCRIPT=/usr/local/bin/iodbc-config
-- 	ODBC_IODBC_IODBCTEST=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctest
-- 	ODBC_IODBC_IODBCTESTW=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctestw
-- 	ODBC_APP_DEFINES=
-- 	ODBC_APP_INCLUDE_DIRS=/usr/local/Cellar/libiodbc/3.52.13/include
-- 	ODBC_APP_COMPILER_FLAGS=
-- 	ODBC_APP_LINKER_FLAGS=-L/usr/local/Cellar/libiodbc/3.52.13/lib;-liodbc
-- 	ODBC_DRIVER_DEFINES=
-- 	ODBC_DRIVER_INCLUDE_DIRS=/usr/local/Cellar/libiodbc/3.52.13/include
-- 	ODBC_DRIVER_COMPILER_FLAGS=
-- 	ODBC_DRIVER_LINKER_FLAGS=-L/usr/local/Cellar/libiodbc/3.52.13/lib;-liodbcinst
-- Found the following ICU libraries:
--   uc (required)
CMake Error at contrib/ssl/CMakeLists.txt:5 (include):
include could not find load file:
cmake/prevent_in_source_builds.cmake

-- CMAKE_BUILD_TYPE: RelWithDebInfo
CMake Error at contrib/ssl/CMakeLists.txt:119 (include):
include could not find load file:
cmake/arch.cmake

CMake Error at contrib/ssl/CMakeLists.txt:120 (include):
include could not find load file:
cmake/sanitize.cmake

CMake Error at cmake/Modules/FindiODBC.cmake:30 (include):
include could not find load file:
cmake/extract_flags.cmake

Call Stack (most recent call first):
cmake/Modules/FindODBC.cmake:121 (find_package)
contrib/ssl/CMakeLists.txt:123 (find_package)
CMake Error at cmake/Modules/FindiODBC.cmake:35 (message):
ODBC iODBC: Only one of ODBC_IODBC_DIR and ODBC_IODBC_CONFIG_SCRIPT can be
specified at the same time.
Call Stack (most recent call first):
cmake/Modules/FindODBC.cmake:121 (find_package)
contrib/ssl/CMakeLists.txt:123 (find_package)
-- Configuring incomplete, errors occurred!
See also "/Users/miraj/Downloads/clickhouse-odbc/build/CMakeFiles/CMakeOutput.log".

Thereafter, getting that ODBC iODBC: Only one of ODBC_IODBC_DIR=/usr/local/Cellar/libiodbc/3.52.13  and ODBC_IODBC_CONFIG_SCRIPT=/usr/local/bin/iodbc-config can be specified  at the same time.. So, i explicitly set one (tried with indeed setting one by one both) of the variables to FALSE in cmake/Modules/FindiODBC.cmake

(base) miraj@Miraj-13inch-mac build % cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DOPENSSL_ROOT_DIR=$(brew --prefix)/opt/openssl -DICU_ROOT=$(brew --prefix)/opt/icu4c ..
-- CMAKE_BUILD_TYPE: RelWithDebInfo
-- Using ODBC: iODBC
-- 	ODBC_DIR=/usr/local/Cellar/libiodbc/3.52.13
-- 	ODBC_CONFIG_SCRIPT=/usr/local/bin/iodbc-config
-- 	ODBC_IODBC_IODBCTEST=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctest
-- 	ODBC_IODBC_IODBCTESTW=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctestw
-- 	ODBC_APP_DEFINES=
-- 	ODBC_APP_INCLUDE_DIRS=/usr/local/Cellar/libiodbc/3.52.13/include
-- 	ODBC_APP_COMPILER_FLAGS=
-- 	ODBC_APP_LINKER_FLAGS=-L/usr/local/Cellar/libiodbc/3.52.13/lib;-liodbc
-- 	ODBC_DRIVER_DEFINES=
-- 	ODBC_DRIVER_INCLUDE_DIRS=/usr/local/Cellar/libiodbc/3.52.13/include
-- 	ODBC_DRIVER_COMPILER_FLAGS=
-- 	ODBC_DRIVER_LINKER_FLAGS=-L/usr/local/Cellar/libiodbc/3.52.13/lib;-liodbcinst
-- Found the following ICU libraries:
--   uc (required)
-- CMAKE_BUILD_TYPE: RelWithDebInfo
CMake Error at cmake/Modules/FindiODBC.cmake:35 (message):
ODBC iODBC: Only one of ODBC_IODBC_DIR=/usr/local/Cellar/libiodbc/3.52.13
and ODBC_IODBC_CONFIG_SCRIPT=/usr/local/bin/iodbc-config can be specified
at the same time.
Call Stack (most recent call first):
cmake/Modules/FindODBC.cmake:121 (find_package)
contrib/ssl/CMakeLists.txt:123 (find_package)
-- Configuring incomplete, errors occurred!
See also "/Users/miraj/Downloads/clickhouse-odbc/build/CMakeFiles/CMakeOutput.log".

But now i am stuck, with this error, any help would be great: . CMake Error at cmake/Modules/FindODBC.cmake:199 (add_library): add_library cannot create imported target "ODBC::App" because another target with the same name already exists.

(base) miraj@Miraj-13inch-mac build % cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DOPENSSL_ROOT_DIR=$(brew --prefix)/opt/openssl -DICU_ROOT=$(brew --prefix)/opt/icu4c ..
-- CMAKE_BUILD_TYPE: RelWithDebInfo
-- Using ODBC: iODBC
-- 	ODBC_DIR=/usr/local/Cellar/libiodbc/3.52.13
-- 	ODBC_CONFIG_SCRIPT=/usr/local/bin/iodbc-config
-- 	ODBC_IODBC_IODBCTEST=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctest
-- 	ODBC_IODBC_IODBCTESTW=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctestw
-- 	ODBC_APP_DEFINES=
-- 	ODBC_APP_INCLUDE_DIRS=/usr/local/Cellar/libiodbc/3.52.13/include
-- 	ODBC_APP_COMPILER_FLAGS=
-- 	ODBC_APP_LINKER_FLAGS=-L/usr/local/Cellar/libiodbc/3.52.13/lib;-liodbc
-- 	ODBC_DRIVER_DEFINES=
-- 	ODBC_DRIVER_INCLUDE_DIRS=/usr/local/Cellar/libiodbc/3.52.13/include
-- 	ODBC_DRIVER_COMPILER_FLAGS=
-- 	ODBC_DRIVER_LINKER_FLAGS=-L/usr/local/Cellar/libiodbc/3.52.13/lib;-liodbcinst
-- Found the following ICU libraries:
--   uc (required)
-- CMAKE_BUILD_TYPE: RelWithDebInfo
-- Using ODBC: iODBC
-- 	ODBC_DIR=/usr/local/Cellar/libiodbc/3.52.13
-- 	ODBC_CONFIG_SCRIPT=/usr/local/bin/iodbc-config
-- 	ODBC_IODBC_IODBCTEST=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctest
-- 	ODBC_IODBC_IODBCTESTW=/usr/local/Cellar/libiodbc/3.52.13/bin/iodbctestw
-- 	ODBC_APP_DEFINES=
-- 	ODBC_APP_INCLUDE_DIRS=/usr/local/Cellar/libiodbc/3.52.13/include
-- 	ODBC_APP_COMPILER_FLAGS=
-- 	ODBC_APP_LINKER_FLAGS=-L/usr/local/Cellar/libiodbc/3.52.13/lib;-liodbc
CMake Error at cmake/Modules/FindODBC.cmake:199 (add_library):
add_library cannot create imported target "ODBC::App" because another
target with the same name already exists.
Call Stack (most recent call first):
contrib/ssl/CMakeLists.txt:123 (find_package)
CMake Error at cmake/Modules/FindODBC.cmake:203 (target_link_libraries):
Cannot specify link libraries for target "ODBC::App" which is not built by
this project.
Call Stack (most recent call first):
contrib/ssl/CMakeLists.txt:123 (find_package)
-- Configuring incomplete, errors occurred!
See also "/Users/miraj/Downloads/clickhouse-odbc/build/CMakeFiles/CMakeOutput.log".

odbc.ini File

Insert the content of this file into ~/.odbc.ini or /etc/odbc.ini files.
[ODBC Data Sources]
ClickHouse DSN (ANSI)    = ClickHouse ODBC Driver (ANSI)
ClickHouse DSN (Unicode) = ClickHouse ODBC Driver (Unicode)
[ClickHouse DSN (ANSI)]
Driver      = ClickHouse ODBC Driver (ANSI)
Description = DSN (localhost) for ClickHouse ODBC Driver (ANSI)
New all-in one way to specify connection with [optional] settings:
Url = https://default:password@localhost:8443/query?database=default&max_result_bytes=4000000&buffer_size=3000000
...or minimal (will connect to port 8443 if protocol is "https://" or 8123 if it is "http://"):
Url = https://localhost
Old way:
Server = <IP_ADDRESS>
Database = default
Port = 8123
Proto = http
[ClickHouse DSN (Unicode)]
Driver      = ClickHouse ODBC Driver (Unicode)
Description = DSN (localhost) for ClickHouse ODBC Driver (Unicode)

odbcinst.ini File

[ODBC Drivers]
PostgreSQL Unicode              = Installed
Cloudera ODBC Driver for Impala = Installed
ClickHouse ODBC Driver (ANSI)    = Installed
ClickHouse ODBC Driver (Unicode) = Installed
[PostgreSQL Unicode]
Description = PostgreSQL ODBC driver
Driver      = /usr/local/lib/psqlodbcw.so
[Cloudera ODBC Driver for Impala]
Driver = /opt/cloudera/impalaodbc/lib/universal/libclouderaimpalaodbc.dylib
[ClickHouse ODBC Driver (ANSI)]
Description = ODBC Driver (ANSI) for ClickHouse
Driver      = /usr/local/lib64/libclickhouseodbc.so
Setup       = /usr/local/lib64/libclickhouseodbc.so
UsageCount  = 1
[ClickHouse ODBC Driver (Unicode)]
Description = ODBC Driver (Unicode) for ClickHouse
Driver      = /usr/local/lib64/libclickhouseodbcw.so
Setup       = /usr/local/lib64/libclickhouseodbcw.so
UsageCount  = 1

Try removing the entire source tree, and cloning afresh with this command:
git clone --recursive git@github.com:ClickHouse/clickhouse-odbc.git

Thanks @traceon .. --recursive cloning worked. I can connect to clickhouse from Tableau using ODBC datasource now.


Testing against latest 2.5 version

Description
Testing against latest 2.5 version

Why was this change required?
Since 2.6 was released, ruby 2.5 is not ruby-head anymore

Thanks for this! The help is much appreciated. Sorry for the late reply.


Moment's measurement key objs and control keys should be frozen

Moments are, or should be, immutable.  However currently the return type of _measurement_key_objs_ returns a set and not a frozenset.  This means one could change this set and modify the Moment.
This is, however, a breaking change in terms of types, i.e. we would change the return type for _measurement_key_objs_ to FrozenSet.  I'm not sure we have a great way to deprecate return types?

We can leave the return type as AbstractSet and return FrozenSet, which is a subtype. I would not consider this a backward-incompatible change.

They're copied before the public protocol returns https://github.com/quantumlib/Cirq/blob/6f5c11e48d98968f5884f3f4efb844d4a1bc930d/cirq-core/cirq/protocols/measurement_key_protocol.py#L182
So this only affects the private method. (Ideally we should have specified the dunder to return a frozenset, then avoid the extra allocation in the public protocol implementation, though that might have created its own issues).


[[FIX]] Disable futurehostile option by default

When enabled, this option generates a new warning for code that would
otherwise pass. Therefore, it should not be enabled by default until the
next major release of this library.

Coverage remained the same at 96.3% when pulling 3cbd41f560bad988adcb4bcf14d549843f653dcb on jugglinmike:disable-futurehostile-by-default into 02c2628de6401363fad48b3cc7668eef2c2d7c1a on jshint:master.


Resolves #255 feature duplicate tab as incognito

I set the shortcut to be Alt + B since Shift + B was already taken. Duplicates tab if already in incognito, tries to open duplicated tab in existing incognito window otherwise, creating one if none exist.

This completes the bounty as bountify.co but you haven't gotten paid and it's been a month?

Yep, because the pull request needs to be merged and the issue closed first.


[QUERY] Azure Search Results Boosting

Library name and version
Azure Search
Query/Question
This is in continuation of closed query #27574 where I had asked some questions and got some nice feedback from @dereklegenzoff. I tried in my local but couldn't get the expected results
Our requirement is that we have to do a fuzzy search, partial term search and exact matches where we should order search results in way that we should first display exact matches (if any), then partial term matches and then fuzzy search results. We were given the suggestion of using Term Boosting but unfortunately, it is not working out as expected.
Following are the two examples/search queries we are trying:
(Ben~) OR (/.Ben./^3) OR "Ben"^4
(Jeferson~ Medical~ Center~) OR (Jeferson^2 Medical^2 Center^2) OR (/.Jeferson./^3 /.Medical./^3 /.Center./^3) OR "Jeferson Medical Center"^4
I am setting searchMode to all and queryType to full in our search query syntax.
There is a possibility I might be doing something wrong for which I am curious to know how to correct it.
Environment
No response

@ssghoda - could you clarify what isn't working as expected?
The only issue i see off the bat is that you should be using /.*Ben.*/ rather than /.Ben./

Oh I think it removed the "*" in my post. I should have wrapped that line in code tag.
Following are the two examples/search queries we are trying:
(Ben~) OR (/.*Ben.*/^3) OR "Ben"^4
(Jeferson~ Medical~ Center~) OR (Jeferson^2 Medical^2 Center^2) OR (/.*Jeferson.*/^3 /.*Medical.*/^3 /.*Center.*/^3) OR "Jeferson Medical Center"^4
Our requirement is that we have to do a fuzzy search, partial term search and exact matches where we should order search results in way that we should first display exact matches (if any), then partial term matches and then fuzzy search results.
So in the case of (Ben~) OR (/.*Ben.*/^3) OR "Ben"^4, we should get all the Ben at the top in Azure Search API response, following them all the names containing "Ben" in it such as Benjamin and then fuzzy searches such as Bean.
We were given the suggestion of using Term Boosting but unfortunately, it is not working out as expected. So wanted to know if I am doing something wrong, or something else we have to do here.

Got it. So it sounds like you're just not getting the results in the expected order.
One thing you're potentially running into is that partial term searches always contribute a consistent amount to the query score while typical term searches will contribute a particular amount based off of BM25:

An example illustrates why this matters. Wildcard searches, including prefix searches, are ambiguous by definition because the input is a partial string with potential matches on a very large number of disparate terms (consider an input of "tour*", with matches found on “tours”, “tourettes”, and “tourmaline”). Given the nature of these results, there is no way to reasonably infer which terms are more valuable than others. For this reason, we ignore term frequencies when scoring results in queries of types wildcard, prefix and regex. In a multi-part search request that includes partial and complete terms, results from the partial input are incorporated with a constant score to avoid bias towards potentially unexpected matches.

That snippet comes from this doc: Full text search in Azure Cognitive Search
With this, you could consider trying to experiment with a higher boost for the exact term matches. You also have the ability to tweak some of the parameters that impact BM25 scoring. More details on that here. You could tweak the k1 and b parameters to try to make the score from the term matches more comparable to the partial term search matches.

I see. So changing k1 and b values would change the way search scores are computed and we will get results in expected order which is first all full name matches, then partial term matches and then fuzzy matches?

What I'd recommend trying first is adding a stronger boost to the exact term queries--that's probably the simplest approach. If you still can't get that to work as expected, then you could start to mess around with k1 and b parameters.

That information was very helpful. Giving a stronger boost seems to be working and giving expected results. I changed our search query as follows:
(Ben~) || (/.*Ben.*/^80) || 'Ben'^90
We will try some more examples like this and see if we need to raise the boost factor even higher. If not, we will discuss k1 and b parameters.


fix xunit reporter crash when used with parallel mode

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.

Description of the Change
See this comment https://github.com/mochajs/mocha/issues/4453#issuecomment-812936325
This change fixes the various issue encountered when using parallel mode with the xunit reporter when error happens.
All the changes are in Test, Suite and Hook's serialize function

serialized parent fully by calling serialize (also call serialize for Hook's ctx.currentTest as well)
force serialization of the value for  $$isPending to boolean to remove the possiblity that it is undefined which is not serialized.
Add state to the value that is serialized in Hook.prototype.serialized()

Why should this be in core?
Fixes broken functionality in the core
Benefits
xunit reporter can be used in parallel mode
Possible Drawbacks
I didn't fully look at all the possible reporters mentioned in #4453 and more fixes may be needed to address the full scope.
Applicable issues
Partial bug fix to #4453

Oops.  Need to figure out the CLA first.  Closing the PR for now.

Coverage remained the same at 94.201% when pulling 8261ea88f9f0f5fa7e0a969302b76159644f5747 on curtisman:parallel-xunit into 34643e4c0821aeb8d6977c1942bc106c9363789a on mochajs:master.

Rebased and signed the CLA

Reactivating PR after signing CLA

@juergba I believe this should fix #4624

+1

@curtisman thank you for this PR. Sorry for the delay, are you still around?
The communication between processes (IPC) with its de-/serialization is a time-costly matter. We have to be very selective with the data we are transmitting, otherwise the parallel mode turns out to be slower than a serial run.

serialized parent fully by calling serialize (also call serialize for Hook's ctx.currentTest as well)

This is too generous. I will have a look which properties we will need. At a first look, adding just $$fullTitle: this.parent.fullTitle() seems to be sufficient.

I reverted the change to fully serialized nested objects.  Although, I feel like this will just turn in the whack-a-mole, as I don't think there is a good documentation on what reporter are expected to have access to in these objects, and other reporters might us a fuller set of data here.
I tested out my original repro in https://github.com/mochajs/mocha/issues/4453#issuecomment-812936325 with the json reporter as well, and discover a set of property that needed to be added to the Hook as well (currentRetry(), fullTitle(), duration, file)

Although, I feel like this will just turn in the whack-a-mole [...]

Yes, I feel the same way. This entire IPC implementation with its de-/serialization appears so clumsy to me. "speed" is the only argument which could justify the additional maintenance burden we have with parallel mode. I don't want to risk loosing any speed.
So be prepared for more nagging on your JSON fix.

I don't want to risk loosing any speed.

I totally hear you there.  For now, I am fully ok with just getting this PR in following the pattern of what is there already, to fix the bug to unblock people.
I poked around the code a little bit (specifically deserialization), and there are some pretty easy improvements that can be made to speed that part up, but I don't know whether it will have any effect on the overall scenarios that people care about.
What scenarios are we looking at for measuring speed? Any data on which part of it causing speed issues (serialization? deserialization? IPC between worker and main process?  contention on the main process?...)

[...] and there are some pretty easy improvements that can be made [...]

yes please, go ahead, your PRs are very welcome.

What scenarios are we looking at for measuring speed?

Nothing sophisticated, just the total time. The user sitting in front of his/her terminal: serial vs parallel.
The communication main process=>worker is small (just the options?)
You can't really influence or customize the IPC chanel.
So the leverage point is worker=>main, the de-/serialization of the workers' event data.
Back on main, there is little happening. Just emitting the buffered events and creating the report.
I can recommend to read:

essay: by the author of parallel mode
mochawesome: implementing parallel, with too little event data


The “models" cannot display the return results of non streaming transmission models.

I created an “openai function call” under the “custom_host” , but its output is not streaming. When I made the following choices while creating the model, an error occurred: “Assistant model ****** does not support streaming”.
Properties
Function call
× Indicates if the model supports function call.
Streaming
×Indicates if the model supports streaming of text chunks.

Thank you for your help. Looking forward to your reply.


Add readme for azure spring cloud plugin

Codecov Report

Merging #881 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #881   +/-   ##
==========================================
  Coverage      44.46%   44.46%
  Complexity       766      766
==========================================
  Files            135      135
  Lines           5184     5184
  Branches         748      748
==========================================
  Hits            2305     2305
  Misses          2705     2705
  Partials         174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa442c7...c475228. Read the comment docs.


enchementmc catalog append netowrk config (#44194)

bp #44194
What problem does this PR solve?
Since there may be some network problems when accessing maxcompute, in order to provide a better user experience, we introduce some parameters to help users better adapt to the network.
You can add these parameters when creating a catalog: mc.connect_timeout :  Connection timeout, default is 10s. mc.read_timeout : Read timeout,default is 120s.
mc.retry_count : Number of retries after failure,default is 4.
Release note
MaxCompute catalog add three parameters : mc.connect_timeout , mc.read_timeout,mc.retry_count help users better adapt to the network between MaxCompute and Doris.
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall


(machine_charm) grafana-agent not restarted after loki relation is removed

Bug Description
If you remove the relation from grafana-agent to loki, the systemd service never gets restarted after the config is updated.
To Reproduce

Relate to principal
Relate to Loki
Unrelate to Loki

Environment

Relevant log output
-

Additional context
No response

Confirmed I am no longer seeing this.


ESBuild errors starting dev server on new project with drizzle and auth enabled

Creating a brand new project with drizzle and lucia auth gives me this error when starting the dev server. I've tested this on a bunch of different nodejs versions. I tried deleting node_modules and .svelte-kit dirs and cleared pnpm cache.
I could not find any related issues in the esbuild package.
> vite dev "--host" "<IP_ADDRESS>"

✘ [ERROR] Expected identifier but found "import"

    (define name):1:0:
      1 │ import.meta.dirname
        ╵ ~~~~~~

✘ [ERROR] Expected identifier but found "import"

    (define name):1:0:
      1 │ import.meta.filename
        ╵ ~~~~~~

✘ [ERROR] Expected identifier but found "import"

    (define name):1:0:
      1 │ import.meta.url
        ╵ ~~~~~~

failed to load config from /home/oluijks/Code/test-auth-drizzle/vite.config.ts
error when starting dev server:
Error: Build failed with 3 errors:
(define name):1:0: ERROR: Expected identifier but found "import"
(define name):1:0: ERROR: Expected identifier but found "import"
(define name):1:0: ERROR: Expected identifier but found "import"
    at failureErrorWithLog (/home/oluijks/Code/test-auth-drizzle/node_modules/.pnpm/esbuild@0.24.1/node_modules/esbuild/lib/main.js:1476:15)
    at /home/oluijks/Code/test-auth-drizzle/node_modules/.pnpm/esbuild@0.24.1/node_modules/esbuild/lib/main.js:945:25
    at runOnEndCallbacks (/home/oluijks/Code/test-auth-drizzle/node_modules/.pnpm/esbuild@0.24.1/node_modules/esbuild/lib/main.js:1316:45)
    at buildResponseToResult (/home/oluijks/Code/test-auth-drizzle/node_modules/.pnpm/esbuild@0.24.1/node_modules/esbuild/lib/main.js:943:7)
    at /home/oluijks/Code/test-auth-drizzle/node_modules/.pnpm/esbuild@0.24.1/node_modules/esbuild/lib/main.js:970:16
    at responseCallbacks.<computed> (/home/oluijks/Code/test-auth-drizzle/node_modules/.pnpm/esbuild@0.24.1/node_modules/esbuild/lib/main.js:622:9)
    at handleIncomingPacket (/home/oluijks/Code/test-auth-drizzle/node_modules/.pnpm/esbuild@0.24.1/node_modules/esbuild/lib/main.js:677:12)
    at Socket.readFromStdout (/home/oluijks/Code/test-auth-drizzle/node_modules/.pnpm/esbuild@0.24.1/node_modules/esbuild/lib/main.js:600:7)
    at Socket.emit (node:events:524:28)
    at addChunk (node:internal/streams/readable:561:12)
 ELIFECYCLE  Command failed with exit code 1.

System:
  OS: Linux 6.12 Arch Linux
  CPU: (16) x64 13th Gen Intel(R) Core(TM) i7-1360P
  Memory: 7.46 GB / 15.21 GB
  Container: Yes
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 22.12.0 - ~/.nvm/versions/node/v22.12.0/bin/node
  npm: 10.9.0 - ~/.nvm/versions/node/v22.12.0/bin/npm
  pnpm: 9.14.4 - ~/.local/share/pnpm/pnpm
  bun: 1.1.37 - ~/.bun/bin/bun
Browsers:
  Chromium: 131.0.6778.204
npmPackages:
  @sveltejs/adapter-auto: ^3.0.0 => 3.3.1
  @sveltejs/kit: ^2.9.0 => 2.13.0
  @sveltejs/vite-plugin-svelte: ^5.0.0 => 5.0.3
  svelte: ^5.0.0 => 5.15.0
  vite: ^6.0.0 => 6.0.4

Seems to be an issue with esbuild 0.24.1 just released one hour ago. Resolved with this in package.json:
	"overrides": {
		"esbuild": "0.24.0"
	}

I think I missed the update from an hour ago. Yes, overriding esbuild to 0.24.0 works.

vite 6.0.5 pinned esbuild to 0.24.0, we are going to unpin esbuild after the fix has been released. this step has been taken to reduce the number of affected users and make it easier than adding a local override.
i'll close this issue as regular update flow get people out of it, still recommend interested parties to follow esbuild and vite release notes over the next hours/days.


Set world attributes

Not really just settting world attributes, this branch actually refactors all rotation-related code into quaternions. In the editor the user changes rotations just as before, but behind the scenes all calculations are made with quaternions. This also fixes the issues having to do with widgets.
fixes #306
fixes #612
fixes #613

SonarQube analysis reported 18 issues

 17 minor
 1 info

Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 RenderManager.cpp#L325: Variable 'name' is assigned a value that is never used.
 RenderManager.cpp#L335: The function 'GetAnimations' is never used.
 RenderManager.cpp#L353: The function 'GetDirectionalLights' is never used.
 RenderManager.cpp#L372: The function 'GetLenses' is never used.
 RenderManager.cpp#L392: The function 'GetMaterials' is never used.
 RenderManager.cpp#L410: The function 'GetMeshes' is never used.
 RenderManager.cpp#L429: The function 'GetPointLights' is never used.
 RenderManager.cpp#L450: The function 'GetSpotLights' is never used.
 ScriptManager.cpp#L63: Variable 'function' is assigned a value that is never used.

SonarQube analysis reported 18 issues

 17 minor
 1 info

Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 RenderManager.cpp#L325: Variable 'name' is assigned a value that is never used.
 RenderManager.cpp#L335: The function 'GetAnimations' is never used.
 RenderManager.cpp#L353: The function 'GetDirectionalLights' is never used.
 RenderManager.cpp#L372: The function 'GetLenses' is never used.
 RenderManager.cpp#L392: The function 'GetMaterials' is never used.
 RenderManager.cpp#L410: The function 'GetMeshes' is never used.
 RenderManager.cpp#L429: The function 'GetPointLights' is never used.
 RenderManager.cpp#L450: The function 'GetSpotLights' is never used.
 ScriptManager.cpp#L63: Variable 'function' is assigned a value that is never used.


Streaming decode

Hello,
Is it possible to make streaming tts with your architecture? We already made streaming Griffin-Lim and now we need a streaming decoder.
What do yo think about it? Can we pass cell status to decoder and solve the problem of using bi-directional RNN in encoder?

@MrDiplodocus how to implement streaming  Griffin-Lim algo?


Run taskRun without a Task by adding TaskSpec

Fixes #249
Proposed Changes

Add a TaskSpec field to the TaskRun which is mutually exclusive with taskRef
validation for not having taskRef and taskSpec together but having one of them
Changed TaskRef field in taskRun to a pointer now that's optional
Unit tests for running TaskRun without a task
if TaskSpec includes sources it doesn't need to be defined as a Resource

now with this feature, users can run TaskRun without a task as demonstrated by the following example:
apiVersion: pipeline.knative.dev/v1alpha1
kind: PipelineResource
metadata:
  name: go-example-git
spec:
  type: git
  params:
  - name: url
    value: https://github.com/pivotal-nader-ziada/gohelloworld
---
apiVersion: pipeline.knative.dev/v1alpha1
kind: TaskRun
metadata:
  name: build-push-task-run-2
spec:
  trigger:
    triggerRef:
      type: manual
  inputs:
    resources:
    - name: workspace
      resourceRef:
        name: go-example-git
  taskSpec:
    inputs:
      resources:
      - name: workspace
        type: git
    steps:
    - name: build-and-push
      image: gcr.io/kaniko-project/executor
      command:
      - /kaniko/executor
      args:
      - --destination=gcr.io/my-project/gohelloworld

@bobcatfish addressed the comments, ready for another look

Looks great to me! Thanks for adding the docs also ^.^
/lgtm
I'm going to add a hold here b/c @ImJasonH opened the issue and might have some opinions about us removing sources
/hold
/meow space

/hold cancel
since I made a small fix and rebased which removed the lgtm

/lgtm
Sounds like there are some more streaming changes we should make, but those definitely don't belong in this PR.
Thanks for doing this work Nader, this should definitely improve the basic getting-started experience, and will make Serving usage simpler, once we get there.


Add console timing functions for benchmarking.

https://developer.mozilla.org/en-US/docs/Web/API/Console/time
Would be nice to have the three time related functions available :)

Hi @IceReaper - you can already access them in the dom console (which is not the same as the System.Console class)
using static H5.Core.dom;

// ....

console.time("Time this");

for (var i = 0; i < 10000; i++) {
  // Your stuff here
}

console.timeEnd("Time this");


Is there any way to specify commands to be executed without  specify  generator

[Enter feedback here]
I do remote linux development via VS, I don't specify a generator, I use my own compile commands. In this case, I found that the command in remotePreGenerateCommand is not executed. Is there any way to specify commands to be executed?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee4cb5d3-4f66-32e8-8b74-522738eb5215
Version Independent ID: ae7afcc9-5c5e-6dc5-cd6a-9b1aa25ac149
Content: CMake predefined configuration reference
Content Source: docs/build/cmake-predefined-configuration-reference.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

@Frankenstein-bit
I don't know. This might be a good question for Developer Community.
@sinemakinci1 Do you have any insights to add here?

@bobbrow Any info to share here?

I'm afraid I don't quite understand how you are configuring your project. Can you provide a small example to demonstrate what you are trying to do?

Given a month without feedback, and a consensus that this isn't a supported scenario, I'm closing the issue.


Matching request header names are case sensitive

X-API-KEY should match with X-API-Key

Still not working fully, its fine on the values but not on the keys. So if you store a header with "Content-Type", the request must also send the header with that casing.


feat: add resubscribe PML and HML layouts

Heads up @kumikoiwamoto. This will get added soon. I'm not sure if this repo is in our normal translation cycle.

Thanks for the heads up.  Our next translation update starts on Friday,
7/26.  I'll check the repo then and include the updates.
On Wed, Jul 17, 2019 at 1:20 PM Adil Delawalla<EMAIL_ADDRESS>wrote:

Heads up @kumikoiwamoto https://github.com/kumikoiwamoto. This will get
added soon. I'm not sure if this repo is in our normal translation cycle.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Pardot/email-layouts/pull/11?email_source=notifications&email_token=ABALAACBXDRX6BD3PDN4ZE3P755KNA5CNFSM4IESTLQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2GPAXY#issuecomment-512553055,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABALAACI7REM7O3FBIYAWXLP755KNANCNFSM4IESTLQA
.

--
Kumiko Jacobs (Iwamoto)
Lead Localization Program Manager
Salesforce

This looks good to me. 👍


Added support for loading image from bundle on iOS

This works on Android, but iOS handles this a bit differently.
In our loader we check if we're trying to load by name without and extension, and if so we assume it is an image and try to load the resource using iOS UIImage methods.
fixes #1366
fixes #1069
fixes #861

I'll make some simple tests for this - I believe we can use our tests under Android / iOS without any troubles and also see about documentation and detection of png / jpg.


Implement a Service Bus Shared Access Key Credential

Summary
Service Bus allows for authorization using a shared key and shared access signature that is currently only supported when using a connection string.  To align with best practices, we would like to guide library users to down the path of using Identity credentials for production applications.   In order to provide a unified approach to authorization around the use of a credential for all scenarios, a service-specific credential type that mimics the API of the TokenCredential is desirable.
Scope of Work

Design and implementation of a ServiceBusSharedAccessKeyCredential type where the API mimics the TokenCredentail form.

The credential should NOT derive from TokenCredential to avoid accidentally attempting to use it with another service.

The credential should support creation using a shared key name and shared key value combination.

The credential should support creation using a shared access signature.

The credential should allow the shared key and value or the shared access signature to be updated without stopping or recreating the associated clients.

The proposed surface area of the credential, as well as changes to the client API to accept it should be reviewed with the language architect, and approval obtained.  Full board review is not necessary.

Success Criteria

The design of a credential type detailed by the scope has been completed and approved by the language architect.

The credential has been implemented according to the design and is exposed as part of the public API of the library.

All clients that accept a TokenCredential also accept the new ServiceBusSharedAccessKeyCredential in a similar manner,

The tests necessary for its validation have been created or adjusted and pass reliably.

The existing test suite continues to produce deterministic results and pass reliably.

References

Follow-Up: Client Creation Discussion
Client Creation Discussion

Proposal 1:

simply expose both credential types as they exist under the cover (one for key/value, one for token)

Proposal 2:

Have a single credential type, with from_* adapters.

Leaning towards proposal 1, even though it clutters signatures slightly, because the latter pattern doesn't seem to have precedent elsewhere in identity.

Note for posterity: The work for this change is completed here waiting for this task to be brought up again for synchronized release between language-sdks.  When this is taken on, it will simply need to be approved past architects and aligned with whatever consistency is needed cross-SDK.


Add sample for validator

Signed-off-by: Frank Lou<EMAIL_ADDRESS>Description
Create a sample Setting in Hello World Extension package, and using the RegexValidator form the Setting on Opensearch side the validate the value of sample Setting.
Needs OS #6221 to be merged first.
Issues Resolved
Fixes https://github.com/opensearch-project/opensearch-sdk-java/issues/350
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mloufra Can you rebase this PR with main?

sure

@mloufra Can you rebase this PR with main?

Done


Feature Request: Support custom IServiceProvider factory in DI implementation

Hi all - just getting started with Chromely, building a UI for a pre-existing project in which I'm already fairly heavily committed to using Autofac as my DI container rather, and had a devil of a time getting it to play nicely with Chromely. It's quite possible there's already an easier solution available than the one I came up with but if not, I'd like to propose a small enhancement that would make this kind of DI container substitution easier. Here's what I think would have made the integration easier:
The problem:
Autofac (and possibly other third party IoC libs) provides an implementation of IServiceProvider (AutofacServiceProvider) but no implementation of IServiceCollection so there is no way to create an IServiceCollection from an Autofac container or container builder for use in Chromely's AppBuilder.UseServices method. I can instantiate my own instance of ServiceCollection and add it's services into my Autofac container builder, but there is then no way (that I could find) to use the resulting IServiceProvider with Chromely, because the AppBuilder.Run is coded to construct it's service provider directly from the IServiceCollection. What I needed was a way to define my own function to return a custom implementation of IServiceProvider, effectively replacing the above line. This is what I came up with:
Create a clone of AppBuilder.cs in my own app and make the following changes:
Add this:
private Func<IServiceProvider> _serviceProviderFactory;

public AppBuilder UseServiceProviderFactory(Func<IServiceProvider> serviceProviderFactory) {
    _serviceProviderFactory = serviceProviderFactory;
   return this;
}

and replace
 _serviceProvider = _serviceCollection.BuildServiceProvider();

with
_serviceProvider = _serviceProviderFactory != null
    ? _serviceProviderFactory()
    : _serviceCollection.BuildServiceProvider();

Usage is then like this:
// Create a new service collection instance
var services = new ServiceCollection();

MyCustomAppBuilder
	.Create()
	// Use our services collection so that all Chromely registrations are added to it
	.UseServices(services)
        // Use our custom Autofac service provider factory
        .UseServiceProviderFactory(() => {
		// Create an Autofac container
		var builder = new Autofac.ContainerBuilder();

		// Register services with all the power of Autofac
		builder.RegisterModule<MyAutofacModule>();
		builder.Register<MyService>().As<IMyService>();

		// Add Chromely services into the pot
		builder.Populate(services);

		// Build the container
		var container = builder.Build();

		// Return a new Autofac-based provider that can provide both services added
                // to IServiceCollection and services registered directly with Autofac
		return new AutofacServiceProvider(container);
	})
	.UseConfig<DefaultConfiguration>(config)
	.UseApp<MyChromelyApp>()
	.Build()
	.Run(args);

My implementation is obviously quite smelly because I've copied a class from Chromely and taken on responsibility for keeping it up to date, but if the project could provide the UseServiceProviderFactory(Func<IServiceProvider> serviceProviderFactory) I've proposed above, I could get rid of my local class. If the maintainers think this is a viable solution I'd be happy to submit a pull request with the implementation.

@wwarby
Use of external IOC like Autofac is what I worry about too myself at the beginning, but my little research at the time, I felt what we have will take care of that. Apparently not.
I will suggest that we make it a bit more generic and consistent with what we have - pattern wise.
Something like ...
public abstract class ChromelyServiceProviderFactory
{
      public abstract IServiceProvider BuildServiceProvider(IServiceCollection services);
}

public AppBuilder UseServiceProviderFactory(ChromelyServiceProviderFactory serviceProviderFactory)
{
     _serviceProviderFactory = serviceProviderFactory;
      return this;
 }

I just did this, on the fly, I may have missed something...

Sure that'd work perfectly well and has the added benefit of not requiring the user to instantiate their own ServiceCollection instance (which I don't need to do except for the fact that I needed to get a reference to it when creating my provider). What you've proposed above will definitely facilitate using Autofac as a third party IoC container - I can't speak authoritatively for other containers, but in principal it should work for any container because it should be possible to wrap any arbitrary container in a custom implementation of IServiceProvider even if the container doesn't provide a ready-to-use implementation of the interface. For example:
public class CustomServiceProvider : IServiceProvider {

    private readonly IThirdPartyContainer _container;

    private readonly IServiceProvider _wrappedServiceProvider;

    public CustomServiceProvider(IThirdPartyContainer container, IServiceCollection services) {
        _container = container;
        _wrappedServiceProvider = services.BuildServiceProvider();
    }

    public object GetService(Type serviceType) {
        try {
            return _container.Resolve(serviceType);
        } catch() {
            try {
                return  _wrappedServiceProvider.GetService(serviceType);
            } catch() {
                return null;
            }
        }
    }

}
public class CustomServiceProviderFactory : ChromelyServiceProviderFactory {

    public IServiceProvider BuildServiceProvider(IServiceCollection services) {
        var builder = new ThirdPartyContainerBuilder();
        builder.Register(); // Custom registrations using third party's service registration APIs
        var container = builder.Build();
        return new CustomServiceProvider(container, services);
    }

}

The above is written on the fly so may not be 100% right but I'm pretty sure the principle would hold for any arbitrary IoC container you might want to use.

Great! Looks like we are on the same page. You suggested submitting a PR, sure you can go ahead with it. Alternatively I can make the change and you help test. Either way we are good. Thanks.

Great - thanks. I'll put together the change as a PR and test it in my own app to make sure it behaves as expected. Leave it with me ;)

I've submitted the pull request with the changes exactly as you proposed - I've tested locally and can confirm it works as expected with Autofac, so I'm confident this will give others what they need to be able to integrate others the third party IoC containers. Thanks for collaborating with me on this, I really appreciate it :)

@wwarby thanks for making Chromely better.


Update README.md

For future users, this updates the forked gem documentation and links to be commensurate with the new maintained gem.

Hmm. I think the Gemfile needs an explicit require:
gem 'trix-rails', require: 'trix'

Also, I haven't yet setup TravisCI, so that'll currently be a dead link. But it's something I hope to do soonish: https://github.com/kylefox/trix/issues/3

Thanks for taking a look. I reverted the travis-ci changes pending #3 , updated the require line, and squashed the commits into one.

Thank you!


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#342 03b782e Thanks @threepointone! - create-partykit: use latest version of partykit/partysocket

<EMAIL_ADDRESS>Patch Changes

#346 58fe7e2 Thanks @mellson! - pass custom port to dev from CLI correctly

#345 9990c2c Thanks @threepointone! - add a lint rule for not using deprecated APIs

#347 3d05975 Thanks @threepointone! - use the right config/options in dev
We weren't reading config correctly in dev, this fixes it

#348 08a1caa Thanks @jevakallio! - Fix partykit login with new bundled imports

<EMAIL_ADDRESS>Patch Changes

#345 9990c2c Thanks @threepointone! - add a lint rule for not using deprecated APIs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Pushing this out there


HTML5 comments seems to overwrite facepiles

@dshanske it seems that the html5 implementation (https://github.com/pfefferle/wordpress-semantic-linkbacks/blob/master/includes/class-linkbacks-walker-comment.php#L77) in the comment walker is disabling the facepile feature in some way.
Conversation: https://wordpress.org/support/topic/unable-to-show-facepile/

So I installed https://github.com/pfefferle/Autonomie on my site and tested it, and I still don’t get a facepile: https://imgur.com/a/n3F7aJV (my theme on this page )
Also, I double-checked, I am on version 3.9.3 of this plugin.

@prtksxna if you checked other themes, it seems not what I thought.

@prtksxna can you please send me a picture of your settings?

I will have a look at this when I can to see if I see something. I haven't been in this code in ages.

@pfefferle Here you go:

Let me know if you'd like to see any other setting/page too.

Hey o/ Any updates on this? I recently updated the plugin but still get the same issue.

This can be closed now that #240 is fixed.


SPEC: Visual Studio & Toolset Discovery

Currently the logic to find out where MSBuild is located has grown in complexity and is not coupled to Visual Studio discovery. Unfortunately these two are more intermingled than we originally thought and must be revisited to fix some issues.
This discovery is required for MSBuild to operate because depending on environment (or mode) MSBuild behaves slightly different for things like extensions path and other items defined in the toolset.
I am proposing that we detect and operate in one of three modes: VS, Standalone, and None. The logic to discover the environment could be as follows:
Entry = Entry point process exe
DevConsole = Directory Exists (%VSINSTALLDIR%) && VisualStudioVersion == '15.0'

if (Entry == 'devenv.exe')
{ // Case #1
  Mode = 'VS'
  ToolsPath = Entry.Directory\..\..\MSBuild\15.0\Bin\
  ToolsPath64 = %ToolsPath%\Amd64
  MSBuildExtensionsPath = Entry.Directory\..\..\MSBuild
  VisualStudioDir = Entry.Directory\..\..\
}
if (Entry == 'MSBuild.exe')
{
  if (Entry.Directory like '%\MSBuild\15.0\Bin\%')
  { // Case #2
    Mode = 'VS'
    ToolsPath = Entry.Directory  // Note: We may be already in Amd64\MSBuild.exe. Must account for this.
    ToolsPath64 = %ToolsPath%\Amd64
    MSBuildExtensionsPath = Entry.Directory\..\..\
    VisualStudioPath = Entry.Directory\..\..\..\
  }
  else
  { // Case #3
    Mode = 'Standalone'
    ToolsPath = Entry.Directory
    ToolsPath64 = Entry.Directory  // 64 not supported
    MSBuildExtensionsPath = Entry.Directory
    VisualStudioPath = null
  }
}

if (Entry != MSBuild && Entry != VS)
{
    if (Entry.Directory like '%\MSBuild\15.0\Bin\%)
    {
      Mode = 'VS',  Case #2
    }
    if (File Exists: Entry.Directory\'MSBuild.exe' )
    {
      Mode = 'Standalone', Case #3   // Even in DevConsole
    }
    if (NOT File Exists: Entry.Directory\'MSBuild.exe' )
    {
      if (DevConsole)
      { // Case #4
        Mode = 'VS
        ToolsPath = DevConsole.VSPath\MSBuild\15.0\Bin
        MSBuildExtensionsPath = DevConsole.VSPath\MSBuild
        VisualStudioPath = DevConsole.VSPath
      }
      else if (VS Setup COM API)
      {
        Mode = 'VS', Case #4
        if (VSSetup.Count > 1) Warn
      }
      else if (Exists: AppContextBaseDir \ MSBuild.exe)
      {
        Mode = 'Standalone', Case #3
      }
      else
      {
        Mode = 'None'
      }
    }
}

Principles in each Mode:
VS:

Toolsets are read from the process called. If you call into MSBuild.exe it should use the toolset that ships with that instance of Visual Studio
Extensions path set to %VSINSTALLDIR%\MSBuild path with fallback to c:\Program Files (x86)\MSBuild.

Standalone:

Toolsets are read locally (or hard coded locally in .NET Core).
Should never be aware of Visual Studio knowledge or SDKs.

None:

This is the case where you reference (for example) Microsoft.Build.dll. Very few things should work.
Toolsets not read locally, only fallback to registry

Action items:

[x] Implement spec in BuildEnvironmentHelper.cs.
[ ] Add warning when more than once instance of Visual Studio is found using the Setup COM API.
[x] When in None mode, ensure that the toolset reader does not throw. Likely nothing will build successfully, but for example the construction API should function. No project evaluation or build will work.
[ ] Potential idea: Publish NuGet package to help a standalone app find MSBuild. This would check if we're in DevConsole or use the Setup COM API to find VS and add AssemblyLoad logic to the current AppDomain to find Microsoft.Build.*.dll.

Looks good overall. Comments/questions:
Your pseudocode breaks my brain :)
VS version >= 15.0 for all checks there.
What's case 4?
What is the case-3 "even in devconsole" case?
Unify language around "disconnected" -> "none".

@kirillosenkov -- you've asked questions related to our current confusing behavior in this area before. Does this sound reasonable to you?

Sorry about the bad pseudocode, quick attempt to capture what we did on the whiteboard :)
I would say VS version == 15.0 (CurrentVisualStudioVersion). If VS version is 16 or 17 and MSBuild is built for 15 we should probably ignore it?
Case 4 is from the DevConsole, so we find VS by the environment variable.
The case-3 even in devconsole was a note because we had a discussion if we should do something different. But in that case you included an MSBuild.exe (or .dll) so you're intending to be in Standalone mode. So in that case we should not know about VS toolsets. So we would ignore VSINSTALLDIR, etc.

Ok, sounds reasonable.

Related to https://github.com/Microsoft/msbuild/issues/114

Quick question: is there an extensibility point (escape hatch) for the None mode? If I'm running MSBuild in a complete vacuum, I should be able to set some state or pass the path to my own toolset somehow.
Also, I remember that VS exe is not always 'devenv.exe', but I can't remember the case. Was it Blend, or Express? Or iso shell? Not sure now but worth checking.

It's hard to tell from the pseudocode, but does this mean if an import isn't found in the DevEnv install location, it should/will fallback to the Program Files msbuild directory?
Basically, shouldn't MSBuildExtensions be the aggregate of the DevEnv install and program files?

@mletterle Yes, that's how it works: it'll be searched for in the VS instance install, then fall back to progfiles.

Closing this because I think it's currently fully implemented. Please reopen if I'm wrong @AndyGerlicher.

Potential idea: Publish NuGet package to help a standalone app find MSBuild. This would check if we're in DevConsole or use the Setup COM API to find VS and add AssemblyLoad logic to the current AppDomain to find Microsoft.Build.*.dll.

I would love to have this. In OmniSharp, we end up calling TryFromSetupApi via reflection in order to determine whether we should set environment variables to use MSBuild in Standalone mode. In VS Code, we only want to be standalone as a last resort.


Update Logo SVG & Readme

[x] Update both logos to remove the "weird" shadow on it
[x] Update readme to mention the chromatic deploy

Previous (the bad one)

New one

LGTM


Characters from regular expressions are taken as trigger characters

FAQ

[X] I have checked the FAQ and it didn't resolve my problem.

Announcement

[X] I have checked Breaking change announcement.

Minimal reproducible full config

Will provide it latter, I promise
Description
Given the following snippets:
  s({ trig = "(%w+)tmap", dscr = "Wrap current table with a map method", regTrig = true }, {
    t "vim.tbl_map(",
    l(l.CAPTURE1, {}),
    i(0),
    t ")",
  }),

I don't expect it to appear when I type a literal parenthesis as an expansion option, but it does:

Steps to reproduce
Just trigger the snippets using part of the snippet regex
Expected behavior
I expect to not get suggestions when typing parts of the capture group
Actual behavior
When I type a parenthesis the snippet appears
Additional context
Thank you for this awesome extension.
Related issue on LuaSnip repo: L3MON4D3/LuaSnip/issues/563

You should open issue on cmp_luasnip repo (The L3MON4D3 was intented this).

@L3MON4D3 suggested that I should open an issue in this repository, so that's why  did because I trust he understands the issue better tahn me

Oh nono, I did mean cmp_luasnip, it's where the completion-items for Luasnip-snippets are generated, and where this can be addressed

Oh sorry, how dumb from my side! Thanks for pointing it out


Bump fast-safe-stringify to v1.2.0, fixes #46

thanks @fhemberger !

@vdeturckheim Could you please push a new release to npm as well?

@fhemberger done :)


Properly serialize state to prevent xss attack

Can be tested by returning "This is an Art " as the quote from the GET /api/quote endpoint as well as by setting the same value as the process.env.API_ENDPOINT var.

Coverage remained the same at 98.039% when pulling ec77c39e6fec121f8be57dfafb5ff60785259812 on bug/xss into ddd9f64b5c258cf0abf52b3af9d45b4e297302e1 on master.


protractor --capabilities.version command line option error with version as integer type

Bug report

protractor --capabilities.version=<VERSION> parses version as integer type.  That gets error from Selenium WebDriver.  If you change version to string type, then the browser version works correctly, without error.

Node Version: 4.6.0
Protractor Version: 4.0.9
Angular Version: Not relevant
Browser(s): chrome
Operating System and Version Windows 7 x64
protractor configuration file

exports.config = {
  capabilities: {
    'browserName': 'chrome',
    'version': '47',
  },

A relevant example test

protractor --capabilities.version=51 protractor.conf.js

Output from running the test

"C:\Program Files\nodejs\node.exe" .\node_modules\protractor\built\cli.js --capabilities.version=51 protractor.conf.js
[10:26:29] I/hosted - Using the selenium server at http://hub.example.com:4444/wd/hub
[10:26:29] I/launcher - Running 1 instances of WebDriver
[10:26:29] E/launcher - Error forwarding the new session null
[10:26:29] E/launcher - WebDriverError: Error forwarding the new session null
    at WebDriverError (c:\Users\username\my-project\node_modules\selenium-webdriver\lib\error.js:27:10)
    at Object.checkLegacyResponse (c:\Users\username\my-project\node_modules\selenium-webdriver\lib\error.js:639:15)
    at parseHttpResponse (c:\Users\username\my-project\node_modules\selenium-webdriver\http\index.js:538:13)
    at c:\Users\username\my-project\node_modules\selenium-webdriver\http\index.js:472:11
    at ManagedPromise.invokeCallback_ (c:\Users\username\my-project\node_modules\selenium-webdriver\lib\promise.js:1379:14)
    at TaskQueue.execute_ (c:\Users\username\my-project\node_modules\selenium-webdriver\lib\promise.js:2913:14)
    at TaskQueue.executeNext_ (c:\Users\username\my-project\node_modules\selenium-webdriver\lib\promise.js:2896:21)
    at c:\Users\username\my-project\node_modules\selenium-webdriver\lib\promise.js:2820:25
    at c:\Users\username\my-project\node_modules\selenium-webdriver\lib\promise.js:639:7
    at process._tickCallback (node.js:369:9)
From: Task: WebDriver.createSession()
    at Function.createSession (c:\Users\username\my-project\node_modules\selenium-webdriver\lib\webdriver.js:329:24)
    at Builder.build (c:\Users\username\my-project\node_modules\selenium-webdriver\builder.js:458:24)
    at Hosted.DriverProvider.getNewDriver (c:\Users\username\my-project\node_modules\protractor\built\driverProviders\driverProvider.js:37:33)
    at Runner.createBrowser (c:\Users\username\my-project\node_modules\protractor\built\runner.js:198:43)
    at c:\Users\username\my-project\node_modules\protractor\built\runner.js:277:30
    at _fulfilled (c:\Users\username\my-project\node_modules\q\q.js:834:54)
    at self.promiseDispatch.done (c:\Users\username\my-project\node_modules\q\q.js:863:30)
    at Promise.promise.promiseDispatch (c:\Users\username\my-project\node_modules\q\q.js:796:13)
    at c:\Users\username\my-project\node_modules\q\q.js:556:49
    at runSingle (c:\Users\username\my-project\node_modules\q\q.js:137:13)

Steps to reproduce the bug

protractor --capabilities.version=51 protractor.conf.js

If you insert this line after built\cli.js:77:
// Convert int to string
if (argv.capabilities && argv.capabilities.version && Number.isInteger(argv.capabilities.version)) { argv.capabilities.version = argv.capabilities.version.toString(); }

Then the error does not happen, and it launches the correct browser version as specified.

The URL you are running your tests against (if relevant):
Not relevant

Very interesting, thanks for bringing this up. So just to be clear, running protractor with the configuration file you've specified works, but when you override it via the cli it does not.

I'm not able to reproduce this with the latest protractor and the example config. Going to go ahead and close for now.


Use language-diff package

Use language-diff package

:bell: @diiq this fix works perfectly for me.


Update policy-overview.md to fix small grammactic mistake.

fixed grammar, simply adding a missing "is" on the first line. :)

@mattselkey : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Merging the typo fix. Thanks @mattselkey.


Deciding on Licensing

I'm opening this issue to start the discussion about the preferred licensing model for the fusionscript package.
Currently I've adopted the license from Pymel as it has been adopted widely in pipelines and I haven't heard any issues about studios not adopting it because of its license. I think it's a pretty liberate and free license (plus it's super short!) so it should be fine. But I'm keeping this Issue open for some time to see where we land.

Which license does PyMEL have? Looks like MIT.
I typically go for LPGL, primarily motivated by this article, written by a genious. But MIT is also good. Both are widely used everywhere, including the VFX industry.
Have a look here for some more reference.

http://choosealicense.com/


linux errors when open project (install/setup)

tried code and get warnings about 3 versions of same function? deleted 2 to test and get other error idk? should this work from Linux too idk thanks
what is the process? i am supposed to load that sceneButtons and build a debug dll and generate a unity package and copy that to my project?
sorry idk thanks

PrecompiledAssemblyException: Multiple precompiled assemblies with the same name OdinSerializer.dll included for the current platform. Only one assembly with the same name is allowed per platform. Assembly path: {0}
UnityEditor.Scripting.ScriptCompilation.EditorBuildRules.CreateTargetAssemblies (System.Collections.Generic.IEnumerable1[T] customScriptAssemblies, System.Collections.Generic.IEnumerable1[T] precompiledAssemblies) (at /home/builduser/buildslave/unity/build/Editor/Mono/Scripting/ScriptCompilation/EditorBuildRules.cs:251)
UnityEditor.Scripting.ScriptCompilation.EditorCompilation.UpdateCustomTargetAssemblies () (at /home/builduser/buildslave/unity/build/Editor/Mono/Scripting/ScriptCompilation/EditorCompilation.cs:701)
UnityEditor.Scripting.ScriptCompilation.EditorCompilation.SetAllCustomScriptAssemblyJsonContents (System.String[] paths, System.String[] contents, System.String[] guids) (at /home/builduser/buildslave/unity/build/Editor/Mono/Scripting/ScriptCompilation/EditorCompilation.cs:1011)
UnityEditor.Scripting.ScriptCompilation.EditorCompilationInterface.SetAllCustomScriptAssemblyJsonContents (System.String[] allAssemblyJsonPaths, System.String[] allAssemblyJsonContents, System.String[] guids) (at /home/builduser/buildslave/unity/build/Editor/Mono/Scripting/ScriptCompilation/EditorCompilationInterface.cs:241)

i have the store bought one too and that seems to work without errors but i only wanted the serialize to be distributable

I believe recent changes should have fixed this, but if you can confirm that this is not the case, please comment here to reopen the issue.


feat: rewrite todo cards logic

Description
To fix and simplify Todo cards logic I refactored it's logic. Now cards list derived from state, rathen than be stored in redux state. No more addTodo and removeTodo actions.
For example:

show PIN card if no PIN has been set
show Lighning Transfer in progress card if claimedBalance > 0

All cards logic is now in todosFullSelector and there are tests for it.
Also I've replaced lodash/* libs with one.
Linked Issues/Tasks
closes #1162
Type of change
Refactoring
Tests
Unit test

Nice, way cleaner than before. Just a couple of findings:

'lightningReady' and 'Instant Payments Ready' toast should only show for the first channel, for every extra channel 'transferToSpending' and no toast message
'Reset Suggestions' button is not resetting all cards, shows 'lightningReady' card if there is a open channel
When I disable my PIN code the green card shows again, I think it should stay hidden
After restore, 'profile' card shows again

'lightningReady' and 'Instant Payments Ready' toast should only show for the first channel, for every extra channel 'transferToSpending' and no toast message

Lets keep it for now. It is still nice to have this confirmatioln when you channel is finally open, even if you already have one

'Reset Suggestions' button is not resetting all cards, shows 'lightningReady' card if there is a open channel

fixed

When I disable my PIN code the green card shows again, I think it should stay hidden

fixed

After restore, 'profile' card shows again
will fix in #398 someday :)

Lets keep it for now. It is still nice to have this confirmatioln when you channel is finally open, even if you already have one

Fine with me but maybe check with Aldert as this is not how it is in the design.

'Reset Suggestions' button is not resetting all cards, shows 'lightningReady' card if there is a open channel

This issue is still there:
https://github.com/synonymdev/bitkit/assets/8538369/2062b364-c0f3-4893-8920-d2d2868a8a93

This issue is still there:

I don't think this is an issue, you have already setup lightning. "Fixing" this requires more complexity.


Suggestion: in task options change private roll/complications to say blind instead

Private is a little ambiguous, blind is clearer.

While I can agree that private does not necessarily convey a clear meaning, these options are labeled as such to align with their Foundry roll modes as found here: https://foundryvtt.com/article/dice/
Importantly, private rolls allow the player & the GM to see it, while blind rolls only allow the GM to see it. At this point, I believe sticking to the Foundry terms might be the best route to go, but I'm open to suggestions.

While I can agree that private does not necessarily convey a clear meaning, these options are labeled as such to align with their Foundry roll modes as found here: https://foundryvtt.com/article/dice/
Importantly, private rolls allow the player & the GM to see it, while blind rolls only allow the GM to see it. At this point, I believe sticking to the Foundry terms might be the best route to go, but I'm open to suggestions.

Yes that is my point though.. It's not clear because it's all doing different stuff not aligning with foundry roll modes.
The options in a tasks set up are called 'Private Roll' and 'Private Complication' which one would assume should both allow GM and Player can see...
Problem 1 however is when 'Private Roll' " is checked, the players skill rolls are output as public (or whatever default roll mode they have selected) ignoring the private roll option in the module. Only the final task result is kept private. If that can't be overridden, perhaps rename the option to say "Private GM Result" so it's clear that it doesn't inude the skill checks.
Problem 2 is that when "Private Complication" is checked, the complications are output as BLIND and the player cannot see them, only the GM. Hence that option is labelled as 'private' wrong because they are in fact output as 'blind', and Should be labelled as "Blind GM Complication" if that is the intention.

Yes that is my point though.. It's not clear because it's all doing different stuff not aligning with foundry roll modes.
The options in a tasks set up are called 'Private Roll' and 'Private Complication' which one would assume should both allow GM and Player can see...
Problem 1 however is when 'Private Roll' " is checked, the players skill rolls are output as public (or whatever default roll mode they have selected) ignoring the private roll option in the module. Only the final task result is kept private. If that can't be overridden, perhaps rename the option to say "Private GM Result" so it's clear that it doesn't inude the skill checks.
Problem 2 is that when "Private Complication" is checked, the complications are output as BLIND and the player cannot see them, only the GM. Hence that option is labelled as 'private' wrong because they are in fact output as 'blind', and Should be labelled as "Blind GM Complication" if that is the intention.

My bad for glossing over the issue. I definitely see the problems now. Reopening and I'll but it back on the todo list. Thanks for being able to explain more!

My bad for glossing over the issue. I definitely see the problems now. Reopening and I'll but it back on the todo list. Thanks for being able to explain more!

No partially my bad, I was on an issue writing spree at the time and looking at the original post I didn't write the issue with much clarity to begin with 😆

No partially my bad, I was on an issue writing spree at the time and looking at the original post I didn't write the issue with much clarity to begin with 😆


"4RELAY INIT ERROR" with Module_4RELAY_M5Core2.ino

Describe the bug
Example didn't work because wrong I2C-Pins for I2C-PortA in Core2.
Core2 uses IO 32, 33 instead of 21, 22 for PORTA.
21, 22 is internal I2C and 4Relay could not be connected to internal I2C as I know.
The line:
while (!RELAY.begin(&Wire1, MODULE_4RELAY_ADDR, 21, 22, 200000L)) {
Should be changed to:
while (!RELAY.begin(&Wire, MODULE_4RELAY_ADDR, 32, 33, 200000L)) {
To reproduce

Arduino IDE 2.2.1
M5StackCore2 0.1.6 or 0.1.7
Hardware: Core2 and 4-Relay UNit connected to PORTA.
Compile the example sketch "Module_4RELAY_M5Core2.ino"

Expected behavior
Core2 should initalize and relay should make sound.
Screenshots
No response
Environment

OS:
IDE &IDE Version:
Repository Version:

Additional context
No response
Issue checklist

[X] I searched for previous reports in the issue tracker
[X] My report contains all necessary details

Sorry I tried with "Unit 4Relay" and not with "Module 4Relay".
I missed the fact, that there are two hardwares and two repos/libs.

Hi @sigmaeo ,
Yes, module and unit is different, the I2C interface module normally use the intSDA and intSCL pin, but if you connect the I2C interface UNIT to PortA, it use PA_SDA and PA_SCL in Core2/CoreS3 device.
So, i will close this issues, feel free to reopen this if you still have issues.


⚠ Beamable Leaderboards (Basic) has degraded performance

In 2aef38d, Beamable Leaderboards (Basic) (https://api.beamable.com/basic/leaderboards/platform/docs) experienced degraded performance:

HTTP code: 200
Response time: 1237 ms

Resolved: Beamable Leaderboards (Basic) performance has improved in 5ba5940 after 9 minutes.


Size returned by (*PointAffine).SetBytes for bw761

Shouldn't it be equal to sizePointCompressed? https://github.com/ConsenSys/gurvy/blob/master/bw761/twistededwards/point.go#L127
Likewise are the lengths in the comments on lines 95-96 correct?

It seems indeed the comments don't match the function (ie compressed vs not compressed).
Thanks for raising the issue :) --


RecordRTC.invokeSaveAsDialog mishandles dots in filename

test.test.test.webm downloads as test.test, is there any way to escape dots in the filename?

I can confirm this bug.
The behavior can be traced to https://github.com/muaz-khan/RecordRTC/blob/ebae1da10f50a521000cbcced5c5adfb96f32411/dev/Cross-Browser-Declarations.js#L160-L164
The easiest fix would be to change it to
var splitted = fileName.split('.');
fileName = splitted.slice(0, -1).join('.'); // all except last element
fileExtension = splitted[splitted.length - 1]; // last element

Then, test.test.test.webm would result in the expected filename of test.test.test.webm.
But what if you want to have a dot in your filename, but also want the library to pick the file extension for you? For example if you want to do a timestamp with milliseconds like this: 2021-10-17T122910.042 and the library should then pick the best extension, resulting in a filename of e.g. 2021-10-17T122910.042.webm.
To accomodate this use case in a backwards-compatible manner, I'd propose adding an optional parameter to the function signature:
/**
 * @param {Blob} file - File or Blob object. This parameter is required.
 * @param {string} fileName - Optional file name e.g. "Recorded-Video.webm"
 * @param {string} appendFileExtension - Optional. Set true to always append a file extension to the
 * fileName, even if it contains a dot.
 * @example
 * invokeSaveAsDialog(blob or file, [optional] fileName);
 * @see {@link https://github.com/muaz-khan/RecordRTC|RecordRTC Source Code}
 */
function invokeSaveAsDialog(file, fileName, appendFileExtension = false)

Thoughts?


(GH-535) Provide ability to not use Coveralls

Previously, it was assumed that you would always publish to Coveralls,
and the only way to prevent it was to hack the environment variable to
be something that couldn't be found.  This new parameter allows
controlling whether Coveralls should be used.  It will default to true,
since that is how things work just now.
Fixes #535

@gep13 your changes have been merged, thanks for your contribution 👍


switch to MurmurHash3.arrayHash

Switches the hashCode implementation for SmallHashMap
to call MurmurHash3.arrayHash instead of relying on
the implementation from the super class which calls
MurmurHash3.mapHash. The array variant is much faster
(3-4x) and greatly reduces allocations.

Allocations for mapHash:

Allocations for arrayHash: