[BUG] Artifacts on Smooth Filter

Environment
Operating System: Windows 10
Version / Commit SHA: 8
Describe the bug
I found that a Smooth Filter creates artifacts on a vdb grid which was created from polygons. I just added some boxes, converted them to a VDB Grid and applied smooth filter.

Without the Smooth Fillter all looks fine.

Here my example of the result. OBJ File.
objects_test.zip
Here is my VDB file without the Smooth Filter.
vdb_out_0.zip
To Reproduce
Steps to reproduce the behavior:

Load my file (vdb_out_0.vdb) as a grid.
Apply Smooth Filter like this:

openvdb::tools::Filter<openvdb::FloatGrid> lsf(*grid);
lsf.setGrainSize(1);
lsf.gaussian(3, 1);

And you will see artifacts.
You can also reproduce this issue with Houdini usin SmoothSDF Node. I assume it will show the same issue.
Expected behavior
No Artifacts.

Another one note. When I converted the mesh from polygons to VDB I set HalfWidth = 6.0.
My code looked like this:
std::vector<openvdb::Vec3s> parseVerts;
std::vector<openvdb::Vec3I> parseTris;
std::vector<openvdb::Vec4I> parseQuads;

openvdb::math::Transform::Ptr xform = openvdb::math::Transform::createLinearTransform(py_vdb_data->voxelSize);
grid = openvdb::tools::meshToLevelSet<openvdb::FloatGrid>(*xform, parseVerts, parseTris, parseQuads, 6.0);
grid->setName("density");

Hey @mifth, thanks for this. I believe that this is a problem with the original polygons->SDF conversion and not an issue with the openvdb::tools::Filter class. I've typically seen this when you have polygons which are intersecting and coplanar, which seems to be the case here.
In Houdini there is a node called the VDB Visualize Tree SOP. This lets you look at the topology of a VDB. Using this on the SDF created from your geometry (and removing redundant data) you'll observe some weird artefacts at the intersections of the coplanar faces:

The best way to fix these is typically to convert back to geometry then back to a SDF. This sounds counter intuitive, but by re-generating the mesh it ensures that artefacts like these are removed. This workflow is encapsulated by the tool in openvdb/tools/LevelSetRebuild.h
openvdb::math::Transform::Ptr xform = openvdb::math::Transform::createLinearTransform(py_vdb_data->voxelSize);
grid = openvdb::tools::meshToLevelSet<openvdb::FloatGrid>(*xform, parseVerts, parseTris, parseQuads, 6.0);

// rebuild the level set using the tools in LevelSetRebuild.h
grid = openvdb::tools::levelSetRebuild(*grid, 0.0, 6.0);

openvdb::tools::Filter<openvdb::FloatGrid> lsf(*grid);
lsf.setGrainSize(1);
lsf.gaussian(3, 1);

grid->setName("density");

This is obviously not ideal. In this trivial case you're unlikely to lose much information with the secondary conversion, but in cases where high fidelity is important you may find that you naturally lose some additional detail as you go back and forth between mesh and volume. I'm not confident in saying why meshToLevelSet is producing these issues yet, but I've seen it before and suspect it's to do with floating point tolerance distances with overlapping coplanar polygons.

I should also mention that, in your case, were you to generate an SDF per box and then combine then with a csgUnion operation, this would most likely fix the issue you're seeing from the original conversion.

Hi @Idclip , thank you so much for this idea. I'll take into account the rebuild node.
I also found another one solution:

Convert a mesh to a grid with halfSize=2.0
Dilate the grid to 3
Smooth the grid with the filter
Erode the grid to 3 (just to revert voxels back)

The result looks nice.

But I don't know which variant is better/faster/proper. Rebuild halfSize=6.0 or Dilate/Erode withhalfSize=2.0? What do you think?

About the csgUnion is a good way but it will be much slower. as there could be tenths of unions/defferences.

Anyway, I'm closing the bug. Thank you.


Add tests to pr 43 59e7250c

/describe

/describe

/ask what is this PR about?

/ask will this have any performance impact?


Add Map: Mirage

!Lore
Hundreds of years ago, a pyramid was discovered that led to a totally new world, a world that connected several other realities. In that place, a war between good and bad was fought. Nowadays only remains of what was once a Mayan temple.
In this world, corrupt guardian adepts inhabit, who protect the place.
!Aesthetic
This map, has the proposal to unite elements Aztec and Mayan ruins, adopting the tropical vegetation of the region.

!Map

Black marking symbolizes the player's vision.
Enemies:

Initially appear in tier 1, reappearing and becoming stronger after X minutes, passing between tier 2 and 3.
Enemies initially have little health and little damage, statuses that vary with their tier. Upon being killed they reward players with:
A percentage of the ultimate whoever kills him.
An amount of the game's currency, which is used to purchase items, characters, etc
Some enemies reward players with some kind of bonus in the match [TODO].

Heal:

The player who catches healing, receives a percentage, while the healing becomes a circle, healing everyone in the area (including enemies).
Secondary Healing: This healing comes from the second tier of monsters.

Portals:
Portals spawn after tier 2 enemies spawn. Portals enter a sleeping mode for a specified time

Boss:
Stay asleep until 30 seconds after the tier 3 monsters appear. The boss has a lot of health, but does NOT deal a lot of damage.
[TODO]
[TODO]

After the boss's death, the team that killed him gains 100% of his ultimatum bar. In addition, the count of the uped gas circle and a gas circle is triggered, which squezes to the center of the map (boss's lair)

Fog:

Bushes hide the current location of those inside them for those outside
Characters who are inside the bush have a reduced field of view around them. [Add vignette effect to the HUD]

!Mechanics

Players select a location on the minimap where they want to appear at the beginning of the game.
Ultimates will be released after a period of appearance of the first wave of enemies on the map.
Players have 2 lives with a waiting time until they can appear again in the game (unless the death is caused by gas at the end of the game).
The last player to survive, wins.

!Balancing
All elements of the map, as well as enemies, healings and portals are equivalent for the two halves of the map.

!Technical information.

There may be animated objects within the map, these contribute to the dynamism of the game.
The map has a 32x32 voxel grid, and it is based on this grid that assets are built.
The map is 1760 x 2464 in size (55 x 77 tiles ), and may vary slightly based on how much the player can see from the map on his screen.
The camera must follow the player.
In the collision of objects, it consists of objects that occupy the entire tile (32x32) and others that are rotated 45º, having a collision diagonally.
It will be necessary to develop in addition to assets, also enemies that make up the scenario.

!Team

Alexandre Avila (Game Designer)
@marcmotta  (Art Director)
@Dxnjo (Voxel Artist)
@voxelando (Voxel Artist)
Team can be expanded as needed.

All this content was decided in a metting with the whole team.
There is also avaible in portuguese in this document: Mirage.pdf

Version 0.3
Some concepts has been updated, by the feedback of the other artists, and speacilly @MaisaMilena . As:

Lore ramake
Aesthetic remake
Map structure implement
Lookdev development


Highlight the current tab

Almost impossible to tell which is the active tab if you have many files opened.

I've no plan of changing the default contrasts of active/inactive tabs but it's very easy to customize, you can follow my comment here.
Active tab is the only one with a visible close button (unless you hover any tab with your mouse cursor), so I usually will just look at that, also currently focused file is on the window title.

What I think it would be a good idea is to provide with ecode some high contrast themes by default. Which can be helpful for people with visual difficulties.


ADDED: Google Profile Picture support

all modified index.jade for prioritizing google profile picture over github

Merged. Thanks @praneetmehta !


Search Results do not appear

See: http://gaming-thrones.tumblr.com/search/cribs
scroll to bottom

Oh no!

chads.website
LinkedIn https://linkedin.com/in/chadfurman
Github https://github.com/shadelotus
Twitter https://twitter.com/chadfurman

On Fri, Oct 9, 2015 at 9:52 AM, Joyananda<EMAIL_ADDRESS>wrote:

See: http://gaming-thrones.tumblr.com/search/cribs
scroll to bottom
—
Reply to this email directly or view it on GitHub
https://github.com/ShadeLotus/tumblr-template-sass/issues/77.

I think this is resolved.


[docs] added the Best Practices rules (refs #4)

Closing this one again, let's do it from scratch.


Map underscore to camel case for SqlColumn objects

When I query data with CommonSelectMapper.selectManyMappedRows() method, it can't map underscore to camel case automatically, I have to specify an alias for every cloumn, I think we can do something to improve this.
The way I can think of is to add a method like asCamelCase for SqlColumn class, which can convert the name of the column to camel case, and return a new SqlColumn object, what do you think?

Thanks - I think this is a good idea. I'm doing some experimentation with it, then will commit something.


Add SEARCH IN GOOGLE IMAGE command

I add this google image search function  :heavy_plus_sign: . I only tried with the Command-line interface mode, but seems to work.
Issue : #17
Hope It will suit you @mertyildiran  :)

@ValentinChCloud thanks for this contribution :trophy:
How can I contact you? Could you share your email address? Also could you please make your membership status "Public" from our organization page? :blush:


Avoid silent overflow for numpy compatibility

NumPy 2.0 disallows silent overflow when converting to unsigned dtypes which was causing parsing to fail when reading timestamped registers.
This PR introduces an early explicit conversion to prevent overflow and ensure full compatibility with NumPy 1.26+ and NumPy 2.0+.
Fixes #32

@bruno-f-cruz Good catch, I have used the default int type rather than specifically int32 but it shouldn't really matter. Adding regression testing for this is important, but since that required quite a significant refactoring to get right (!) I will add it in the next PR.


Web Chat supports Adaptive Cards 1.1 but doesn't render video

Screenshots

Version
<script src="https://cdn.botframework.com/botframework-webchat/master/webchat.js"></script>

Describe the bug
Adaptive Cards 1.1 introduced media elements. Web Chat supports Adaptive Cards 1.1 but doesn't render those elements. However, Emulator uses Web Chat and does render them. This is impacting at least one customer: https://stackoverflow.com/a/56177322/2122672
To Reproduce
Steps to reproduce the behavior:

Build a bot that sends an Adaptive Card with a media element
Observe that the media is displayed correctly in Emulator
Observe that the media is not displayed in Web Chat

Expected behavior
Any channel that supports Adaptive Cards 1.1 should render media elements
Additional context
Example card:
{
  "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
  "version": "1.1",
  "type": "AdaptiveCard",
  "body": [
    {
      "type": "TextBlock",
      "text": "Sample"
    },
    {
      "type": "Media",
      "poster": "https://adaptivecards.io/content/poster-video.png",
      "sources": [
        {
          "mimeType": "video/mp4",
          "url": "https://adaptivecardsblob.blob.core.windows.net/assets/AdaptiveCardsOverviewVideo.mp4"
        }
      ]
    }
  ]
}

[Bug]

Thanks @v-kydela.
We actually began investigations over Teams. Let me share what I was looking into. I still haven't found the cause of this discrepancy.

My initial thought was that Emulator is using attachment middleware to render  the video, but I wasn't able to find corresponding code in the Emulator repo. I also think this is the wrong approach because the host config is probably what controls this rendering.
I know that Web Chat's host config doesn't have the MediaConfig prop defined for Adaptive Cards. i was wondering if the host config for Emulator happens to define MediaConfig, but it looks like Emulator is depending on Web Chat's.

looping in @tonyanziano

@corinagum I looked through the Emulator code for handling attachments and I was unable to find any special logic for the rendering of video / media cards. Also, like you said, we are relying on Web Chat's default host config and do not pass a custom one in when rendering Web Chat.

@tonyanziano thanks for the help

I'm having the same issue with videos in AdaptiveCards, but VideoCard attachments are working fine.
@v-kydela  Might be a viable solution to unblock the customer for the moment.
const card = CardFactory.videoCard(
    '2018 Imagine Cup World Championship Intro',
    [{ url: 'https://adaptivecardsblob.blob.core.windows.net/assets/AdaptiveCardsOverviewVideo.mp4' }],
    [{
        type: 'openUrl',
        title: 'Lean More',
        value: 'https://channel9.msdn.com/Events/Imagine-Cup/World-Finals-2018/2018-Imagine-Cup-World-Championship-Intro'
    }],
    {
        subtitle: 'by Microsoft',
        text: 'Microsoft\'s Imagine Cup has empowered student developers around the world to create and innovate on the world stage for the past 16 years. These innovations will shape how we live, work and play.'
    }
);

await turnContext.sendActivity({
    attachments: [card]
});

Also seems related to this Adaptive Cards issue https://github.com/microsoft/AdaptiveCards/issues/2272

Thank you @tdurnford
I did see that issue, but it looks like the discussion ended before Adaptive Cards 1.1 were ever supported in Web Chat

It looks like the media element is being stripped out of the Adaptive Card somewhere between the Bot and DirectLineJs.
AdaptiveCard
{
  "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
  "version": "1.1",
  "type": "AdaptiveCard",
  "body": [
    {
      "type": "TextBlock",
      "text": "**AdaptiveCard with Video**"
    },
    {
      "type": "Media",
      "poster": "https://adaptivecards.io/content/poster-video.png",
      "sources": [
        {
          "mimeType": "video/mp4",
          "url": "https://adaptivecardsblob.blob.core.windows.net/assets/AdaptiveCardsOverviewVideo.mp4"
        }
      ]
    }
  ]
}

DirectLine
import { DirectLine } from 'botframework-directlinejs';

global.XMLHttpRequest = require('xhr2');
global.WebSocket = require('ws');

var directLine = new DirectLine({
    secret: '<WEBCHAT_SECRET>'
});

directLine.postActivity({
  from: { id: 'myUserId', name: 'myUserName' },
  type: 'message',
  text: 'start'
}).subscribe();

directLine.activity$
.filter(activity => activity.from.name !== 'myUserName' && activity.attachments)
.subscribe(
    ({ attachments: [{content}] }) => console.log("Card ", content)
);

Output
Card  {
  type: 'AdaptiveCard',
  version: '1.1',
  body: [ { type: 'TextBlock', text: '**AdaptiveCard with Video**' } ]
}

The Adaptive Card sent by the bot has a media element, but the attachment received and processed by DirectLineJs does not.

@tdurnford is correct.  The WebChat and Direct Line connector service Adaptive Cards version is 1.0.6
WebChat is on version ~1.1.3 https://github.com/microsoft/BotFramework-WebChat/blob/master/packages/bundle/package.json#L36  and is able to render the card.  Since the emulator is receiving messages directly, and not through the connector service: it can render these cards.
This issue should be moved to https://github.com/microsoft/BotFramework-Services/

Good catch @EricDahlvang. But why would the connector service even have an Adaptive Cards version if it's not responsible for rendering anything? Also, stripping out elements is useless because if the Adaptive Cards version is higher than the channel client supports, the card won't render even with the special elements removed.


Add DM API generator and ability to include/exclude features

Prelude to adding some new functionality.

Adds Cargo features, allowing consumers to exclude unused portions of the library

cargo build --release --all-features to get everything
cargo build --release --features dmi,log to get what /tg/ is currently using

Adds a DM API file which can be placed into a project

Only includes calls from enabled features
Observes RUSTG_OVERRIDE_BUILTINS define to use rust_g instead of some builtins

Example of rust_g.dm when --all-features is used (not yet thoroughly tested):
// rust_g.dm - DM API for rust_g extension library
#define RUST_G "rust_g"

#define rustg_dmi_strip_metadata(fname) call(RUST_G, "dmi_strip_metadata")(fname)

#define rustg_file_read(fname) call(RUST_G, "file_read")(fname)
#define rustg_file_write(text, fname) call(RUST_G, "file_write")(text, fname)

#ifdef RUSTG_OVERRIDE_BUILTINS
#define file2text(fname) rustg_file_read(fname)
#define text2file(text, fname) rustg_file_write(text, fname)
#endif

#define rustg_hash_string(algorithm, text) call(RUST_G, "hash_string")(algorithm, text)
#define rustg_hash_file(algorithm, fname) call(RUST_G, "hash_file")(algorithm, fname)

#define RUSTG_HASH_MD5 "md5"
#define RUSTG_HASH_SHA1 "sha1"
#define RUSTG_HASH_SHA256 "sha256"
#define RUSTG_HASH_SHA512 "sha512"

#ifdef RUSTG_OVERRIDE_BUILTINS
#define md5(thing) (isfile(thing) ? rustg_hash_file(RUSTG_HASH_MD5, "[thing]") : rustg_hash_string(RUSTG_HASH_MD5, thing))
#endif

#define rustg_log_write(fname, text) call(RUST_G, "log_write")(fname, text)
/proc/rustg_log_close_all() return call(RUST_G, "log_close_all")()

#define rustg_url_encode(text) call(RUST_G, "url_encode")(text)
#define rustg_url_decode(text) call(RUST_G, "url_decode")(text)

#ifdef RUSTG_OVERRIDE_BUILTINS
#define url_encode(text) rustg_url_encode(text)
#define url_decode(text) rustg_url_decode(text)
#endif

It doesn't, someone was on IRC with this problem

Odd, what distro? Ubuntu and debian both do


cannot unmarshal number into Go value of type string

Seeing this issue with the most recent image. Was not seeing this error previously with the same configuration in the same cluster
2017-09-06T01:30:17.028605154Z   INFO Starting controller
  | 2017-09-06T01:30:17.028756809Z   INFO ACME server url is 'https://acme-v01.api.letsencrypt.org/directory'
  | ERROR: logging before flag.Parse: W0906 01:30:17.028786       1 client_config.go:481] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
  | 2017-09-06T01:30:17.032524381Z   INFO AcmeController bootstraping DB
  | 2017-09-06T01:30:17.032552688Z  TRACE AcmeController bootstraping DB finished duration=40.403775ms start=2017-09-06T01:30:17.032552956Z end=2017-09-06T01:30:17.072956731Z
  | 2017-09-06T01:30:17.073004363Z   INFO AcmeController initializing
  | 2017-09-06T01:30:17.073057872Z   INFO AcmeController started
  | 2017-09-06T01:30:17.073306846Z   INFO Http-01: server listening on http://[::]:5000/
  | 2017-09-06T01:30:17.076501091Z   INFO RouteController initializing
  | 2017-09-06T01:30:17.076537988Z   INFO RouteController started
  | 2017-09-06T01:30:17.076562431Z   INFO RouteController: watching namespace ''
  | 2017-09-06T01:30:17.079674842Z  ERROR route.go:115 json: cannot unmarshal number into Go value of type string
  | 2017-09-06T01:30:17.079733483Z  ERROR route.go:192 RouteController: doWatchIteration failed: RouteController: failed to unmarshal Route: 'json: cannot unmarshal number into Go value of type string'
  | 2017-09-06T01:30:27.082780726Z   WARN route.go:98 RouteController: resetting resourceVersion: caused by 'ERROR' (unversioned.Status{TypeMeta:unversioned.TypeMeta{Kind:"Status", APIVersion:"v1"}, ListMeta:unversioned.ListMeta{SelfLink:"", ResourceVersion:""}, Status:"Failure", Message:"too old resource version: 2366 (10997)", Reason:"Gone", Details:(*unversioned.StatusDetails)(nil), Code:410})
  | 2017-09-06T01:30:27.082814043Z  ERROR route.go:192 RouteController: doWatchIteration failed: RouteController ResultChannel closed
 ```

Same symptoms in OpenShift Container Platform 3.5 and 3.6

@sabre1041 do you have a Route which has port of type int instead of string?
I don't think this is connected to newer image as this was problem from the beginning.
https://github.com/tnozicka/openshift-acme/blob/master/pkg/openshift/api/route.go#L17
I am working on plumbing in the clientsets from OpenShift which should fix all of those issues.

@tnozicka you are right. Had a few routes that defined a targetPort with Integer type. Modified them to be defined as integers and the errors went away.
Glad to hear that they should be removed with the future work you are developing
How do you want to handle this issue?

Let's keep it open so people know there is a workaround and I will close it when that's properly fixed.
(I will close the older dupe as this one is more descriptive.)

What's the workaround here? I just hit the same Issue :-/
$ oc get route --all-namespaces -o json | jq -r '.items[] | select(.metadata.annotations | has("kubernetes.io/tls-acme")) | .spec.port.targetPort'
8080-tcp
null
waf
pspdfkit
https-endpoint

@tnozicka I just hit this issue on a multi-tenant cluster I manage. I've fixed the services/routes on the cluster but an end-user is still able to create a service/route combo with an integer targetPort which could cause openshift-acme to stop working.
Would it be possible for openshift-acme to skip over the routes it can't unmarshal and keep going instead of crashing?

probably just replacing this return with continue https://github.com/tnozicka/openshift-acme/blob/4c651088dbbc6658f2bfef5d2b340379c8989984/pkg/openshift/controllers/route/route.go#L116
@jfchevrette I am in process of re-writing the whole controller to shared informers, workqueue and openshift client so the fix for all the important issues including this one is on the way

fixed in https://github.com/tnozicka/openshift-acme/pull/48


widthArr or flexArr for cells

How to set different width sizes for each cells ?

having the same issue. Can't set widthArr to cell.

I have a working solution. It involves editing the cell.js file and then passing in the width prop. So it is like this:
width={widthArr[cellIndex]}
the widthArr is used for the header component of the table (as you know), then I pass it as a prop to the cell after editing the cell.js file like this:
const textDom = React.isValidElement(data) ? (       <Text style={[textStyle, styles.text]} {...props}>         {data}       </Text>     ) : (       <Text style={[textStyle, styles.text]} {...props}>         {data}       </Text>     );
I do have a concern that under certain conditions this will break but I have tested it with the following as the data prop:
// not sure why, but this does work even though to me it looks like it should not. maybe when the prop is destructured?
data={example(cellData, index)}
// only cell data
data={cellData}

This is actually a better solution using a partial:
` const textDom = React.isValidElement(data) ? (
<>
{data}
</>
) : (
<Text style={[textStyle, styles.text]} {...props}>
Also the cell.js file is in the actual npm module.
{data}

);`

I have a working solution. It involves editing the cell.js file and then passing in the width prop. So it is like this: width={widthArr[cellIndex]}
the widthArr is used for the header component of the table (as you know), then I pass it as a prop to the cell after editing the cell.js file like this:
const textDom = React.isValidElement(data) ? ( <Text style={[textStyle, styles.text]} {...props}> {data} </Text> ) : ( <Text style={[textStyle, styles.text]} {...props}> {data} </Text> );
I do have a concern that under certain conditions this will break but I have tested it with the following as the data prop:
// not sure why, but this does work even though to me it looks like it should not. maybe when the prop is destructured? data={example(cellData, index)}
// only cell data data={cellData}

Can provide example of this implementation?
Thank you.

@KevinMac19
So I will try to walk you through this.
This was a solution as of the original posting date.

You must make edits to the actual npm module. So under you node-modules folder in you project find react-native-table-components module and then go to this file path:

node-modules/react-native-table-component/components/cell.js

find the variable named textDom in the cell.js file and replace that code with the following

const textDom = React.isValidElement(data) ? ( <> {data} </> ) : ( <Text style={[textStyle, styles.text]} {...props}> {data} </Text> );

After making the above changes then go to the component in your project (not in the node-modules folder) and add a width as a prop to the import Cell component from react-native-table-components (see below code for an example):

                       <Cell
                            key={cellIndex}
                            style={}
                            textStyle={}
                            data={}
                            width={widthArr[cellIndex]} // this
                            height={40}
                            borderStyle={}
                          />

The widthArr variable is an array. For example is you have 3 rows and then within those rows 3 cells then you would pass the widthArr into the row as a prop
I create this widthArr variable within a useEffect so I can dynamically change the widths depending on the data. But for testing I would recommend just making a variable
For example
const widthArr = [60,60,60] // this is pixels I believe
<React.Fragment>
     <Row
        widthArr={widthArr}
     />
          <TableWrapper>
                   {rowData.map((cellData, cellIndex) => (
                         <TouchableOpacity>
                                    <Cell
                                       key={cellIndex}
                                       style={}
                                       textStyle={}
                                       data={}
                                       width={widthArr[cellIndex]} // this
                                       height={40}
                                       borderStyle={}
                                    />
                         </TouchableOpacity>
                   ))}
          </TableWrapper>
<React.Fragment>

The above code does not include all of the props that are necessary but should give you an idea of how it works. The reason I did not include all of my code is it is quite complex and it is for a production application. Sorry it took a few days to get back to you.

@KevinMac19
So I will try to walk you through this.
Please read the entire post before changing any code
This was a solution as of the original posting date.

You must make edits to the actual npm module. So under your node-modules folder in you project find react-native-table-components module and then go to this file path:

node-modules/react-native-table-component/components/cell.js

find the variable named textDom in the cell.js file and replace that code with the following

const textDom = React.isValidElement(data) ? ( <> {data} </> ) : ( <Text style={[textStyle, styles.text]} {...props}> {data} </Text> );

After making the above changes then go to the component in your project (not in the node-modules folder) and add a width as a prop to the import Cell component from react-native-table-components (see below code for an example):

                       <Cell
                            key={cellIndex}
                            style={}
                            textStyle={}
                            data={}
                            width={widthArr[cellIndex]} // this
                            height={40}
                            borderStyle={}
                          />

The widthArr variable is an array. For example if you have 3 rows and then within those rows 3 cells then you would pass the widthArr into the row as a prop
I created this widthArr variable within a useEffect so I can dynamically change the widths depending on the data. But for testing I would recommend just making a variable and keeping it simple.
For example
//one row example
const widthArr = [60] // this is pixels I believe
<React.Fragment>
     <Row
        widthArr={widthArr}
     />
          <TableWrapper>
                   {rowData.map((cellData, cellIndex) => (
                         <TouchableOpacity>
                                    <Cell
                                       key={cellIndex}
                                       style={}
                                       textStyle={}
                                       data={}
                                       width={widthArr[cellIndex]} // this
                                       height={40}
                                       borderStyle={}
                                    />
                         </TouchableOpacity>
                   ))}
          </TableWrapper>
<React.Fragment>

The above code does not include all of the props that are necessary but should give you an idea of how it works. The reason I did not include all of my code is it is quite complex and it is for a production application. Sorry it took a few days to get back to you.
The main thing to understand is that making the change in the node-module component gives react something (a partial in this case) something to apply a width too. Before it was just rendering the data but now with the partial the code has some structure and can add a width to it.
Let me know if you have anymore questions. Also you might have to rebuild your project after making your changes to the node-module before moving ahead with the rest of the code in your own project.

Thank you for your response @jmsbrett 👍
It helped me and also I have updated the code for my requirement.


Prisma can't reach Planetscale behind a VPN

Bug description
When doing local development with a VPN on, I get this error:
Error:
Invalid `prisma.playlist.findMany()` invocation:

  Can't reach database server at `{{    DB INFO HERE   }}`

This occurs on initial load of localhost for the app as well as Prisma studio. I can still connect to Planetscale just fine using the Pscale CLI. I am using ProtonVPN and tested with servers in US and Netherlands.
How to reproduce

Turn on a VPN
Start Application server
Go to wherever your app is loaded in localhost (or open Prisma Studio)
See error

Expected behavior
I should be able to connect to Planetscale without timing out.
Prisma information
generator client {
  provider = "prisma-client-js"
  previewFeatures = ["referentialIntegrity"]
}
datasource db {
  provider = "mysql"
  url = env("DATABASE_URL")
  referentialIntegrity = "prisma"
}

model Video {
  id String @id
  lastUpdated DateTime @updatedAt
  name String
  viewCount String
  thumbnail String
  playlist Playlist @relation(fields: [playlistId], references: [id])
  playlistId Int

  @@index([playlistId])
}

model Playlist {
  id Int @id @default(autoincrement())
  youtubeId String?
  name String
  createdAt DateTime
  thumbnail String
  type PLAYLIST_TYPE
  videos Video[]
}

enum PLAYLIST_TYPE {
  PLAYLIST
  CHANNEL
}

Environment & setup

OS: Windows
Database: Planetscale
Node.js version: Tested on both v17.5 and  v16.3.1

Prisma Version
prisma                  : 3.11.1
@prisma/client          : 3.11.1
Current platform        : debian-openssl-1.1.x
Query Engine (Node-API) : libquery-engine 1a2506facaf1a4727b7c26850735e88ec779dee9 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 1a2506facaf1a4727b7c26850735e88ec779dee9 (at<EMAIL_ADDRESS>Introspection Engine    : introspection-core 1a2506facaf1a4727b7c26850735e88ec779dee9 (at<EMAIL_ADDRESS>Format Binary           : prisma-fmt 1a2506facaf1a4727b7c26850735e88ec779dee9 (at<EMAIL_ADDRESS>Default Engines Hash    : 1a2506facaf1a4727b7c26850735e88ec779dee9
Studio                  : 0.458.0
Preview Features        : referentialIntegrity

I assume you are using the connection string you get via the PlanetScale web UI to connect with Prisma?
Can you connect with any other tool using that connection string when connected to your VPN? (e.g. DBeaver or some other database GUI)

Ping @timotius02 - Can you reply to my questions please?

Once more @timotius02, can you please help us out here by providing more information so we can potentially reproduce and fix this? Thank you.

Hello sorry for the late response. I was able to connect using MySQL Workbench but it works only when my VPN is off, similar to my experience with Prisma.

That then sounds like this is not a problem with Prisma, but generally with the the server or connecting via VPN - do you agree?


Landing Page Improvements

The current landing page is nice, but not something that you wish to keep looking at.
Maybe we can give it a revamp, change the background, or center the current one (it is not centered), change the search bar and the button, maybe center it?
Open to discussion, feel free to drop in your suggestions for improving the front-end further.

I would like to contribute to this issue

The splash screen design is under construction. So for the landing page we have now, what we can do is:

Revamp the search bar, maybe have some animations
On pressing the enter key on typing the username, the user is not searched. We have to manually press the go ahead button. Add the enter key functionality also.
center the current one (it is not centered)
Have some background ideas
Animate the whole thing how the resume appears on pressing the button

@ShauryaBhandari add anything if I missed. Also, put it in medium category as we will keep adding UI changes when needed to this issue.

I would like to work on this issue.

Assigned to both. The PR with a better implementation would be merged.

i would like to work on this issue , and i can try to revamp it ..
can you please assign this to me..

@garimasingh128  I have got some ideas and animations just ready to be added but since I'm a beginner with react can you tell me where to find the code of search bar and button..I'm not able to see it in index.html.

It's present here from Line no 31.

i would like to work on this issue


[Event Request] Report 393 - OnBeforeUpdateGnlJnlLineDimensionsFromVendorPaymentBuffer

change parameters from:
local procedure OnBeforeUpdateGnlJnlLineDimensionsFromVendorPaymentBuffer(
var GenJournalLine: Record "Gen. Journal Line";
TempVendorPaymentBuffer: Record "Vendor Payment Buffer" temporary;
SummarizePerVend: Boolean)
to
local procedure OnBeforeUpdateGnlJnlLineDimensionsFromVendorPaymentBuffer(
var GenJournalLine: Record "Gen. Journal Line";
TempVendorPaymentBuffer: Record "Vendor Payment Buffer" temporary;
SummarizePerVend: Boolean;
DocNoPerLine: Boolean;
var NextDocNo: Code[20])
This will allow inspection of the Vendor via TempVendorPaymentBuffer; and if vendor has requirements concerning NextDocNo (e.g. they want a single doc no. per invoice, whereas all other vendors are ok with Single doc. no per invoice), it can be handled here.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 52728.

@JesperSchulz (Thank you for including build#... so helpful to track when clients are eagerly awaiting. Cheers.)


chore: use logical CSS properties instead of physical properties throughout the app

implements TECH-1294
Changes in this PR
Use logical CSS properties instead of physical properties to make localisation to right-to-left (and vertical) languages easier.
Background and useful links

Mapping for margins and borders

Mapping for floating and positions

Browser support - https://caniuse.com/css-logical-props

Why we need logical properties

Note
A followup PR will enforce the use of logical operators in CI checks

Note: I didn't add changes for sizing mappings .. they affect vertical languages only, and I personally found the mapping hard to follow and rationalise (but maybe subconscious bias since I know rtl languages but not vertical ones) .. do we support such languages right now?

Good question. There's an overview of the translation/localisation coverage on this page on DHIS2.org. Chinese and Korean are included, which I know were traditionally vertical languages. I'm not sure if this is the standard for localized webapps though, would be worth looking into. The changes to the interface components to support vertical directionality would be a big lift for a lot of apps though.


[Bug]: Activity list isn't accurate

Describe the bug
Today I created a transaction (onchain) but it's listed on "this month"
Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording
https://github.com/user-attachments/assets/da55dab8-4064-4f7d-ba07-7f2bcbd67c63
Operating system
GrapheneOS
Bitkit version
v133
Log output
No response

I see that this is the same transaction as in https://github.com/synonymdev/bitkit/issues/2171. There are several things wrong if I understand correctly:

It's marked as a transfer even though it should be a normal send (to self)
the fees are wrong
it's grouped in 'This Month' even though it was sent 'Today'

Could be related to https://github.com/synonymdev/bitkit/issues/2217

Tried to reproduce this with 1.0.5 (137) by creating send to self around the same time as a transfer. Never did I see an activity duplicated or have wrong information.


/sit fails to remove armorstand, /sit works while seated

When the player uses the /sit command to sit down on a non-slab/ non-stair block, the invisible armorstand is not deleted after they get off. I think this issue may be related to Issue#3. Also, the /sit command does not check if the player is already sitting, so the player can /sit multiple times, resulting in them sinking into the ground. This can be used to clip into places the player is not supposed to be. I like this mod, however, and it fulfills the need I had, just these issues need to be fixed.

I have patched the /sit spam however I cannot reproduce the issue where the armour stand is left behind.
Do you mind giving more details on how that occurs?

I just tried it out, the armorstand was left behind only when you do /sit again, so with the patch it shouldn't be an issue.

Thank you!

Alright good to hear, ill publish the patch after I fix #3


A new Univeral app utility for Redux

I've built a small utility called redux-wait for helping to write universal redux apps.  It relies on asynchronous middleware returning a promise for when the action has been handled, but if that's the case, it's pretty much a seamless transition from client side to universal.
I wrote up the steps I went through to convert the real-world example into a universal application in https://github.com/ForbesLindesay/redux-wait/tree/master/example  It's also worth mentioning that step 1 can be removed if #537 is merged.
Would it be possible to add this to the "ecosystem" part of the docs?

How is this different than redux-promise?

@phated The idea here is that you can dispatch as any actions as you want - as long as they return a promise your application will not be rendered until all of them have been resolved. redux-promise on the other hand translates a returned promise into an action. So they can be use in conjunction.

@ForbesLindesay I'm curious though what the performance is for cascading actions, when you have to call React.renderToString mutliple times on the server.

I'm not sure, that's definitely a good question.  One thing I'd like to try is some sort of "render to undefined" that would do the render but ignore the results, then do one final render at the end.
If we did that we might also be able to fix the multiple calls to componentWillMount, which would allow the real-world example to work pretty much out of the box.

My feedback: it's better not to provide your own applyMiddleware. It's exactly the situation we had in https://github.com/rackt/redux/issues/678#issuecomment-137432086: each helper wanting to “own” applyMiddleware isn't the right way.
For now, there is nothing actionable for Redux team here, the issue has been inactive for a while, so I'm closing. Thanks for sharing!


Merge stable back into master

merge stable into master after v0.19.0 release

is this PR still a need to merge?


Step.8 add ICEServer fail in step-05 folder

Hello everybody,
I use coturn server to build stun and turn server.
Then I check the server is working or not on Trickle ICE on Firefox.

I already do npm install in step-05 folder. Setp-08 is workable in localhost:8080
I work in step-05 folder and I replace pcConfig in step-05/js/main.js

I run coturn server , node index.js  and Web Server for Chrome (already change to my working folder)

How to know ICEServer is successful and workable?
Thanks

did u solve your problem, can u share ?


Add back timestamp precondition by wrapping global slot

This PR: https://github.com/MinaProtocol/mina/pull/12234
removes the timestamp precondition. However, that precondition is a very user-friendly way to access the current time in a smart contract. We should bring it back on the berkeley branch by adding a wrapper around globalSlotSinceGenesis

needs mini RFC


broken links

please fix the 404s on the device samples :( or just point out that it is included in the package under the folder devicesample ;)

Fixed. The HTML page should reflect the link changes in the next hour or so.
Thanks!


Suggestion: Improved Website

What I'm proposing is a better website UI design. The goal is to have the logs to look like a discord chat. Ex:
I've already begun work on this with my branch here. This is mainly broken and any ideas as to how to fix this would be greatly appreciated.
(BTW this new version does use pug as its method to the logs.)

I would probably prefer it in plain html or something like ejs rather than pug, but I like the idea! That being said, I think it should be an option or have both available somehow (e.g. appending /pretty to the log URL).
You said your branch is currently "mainly broken" - how so?

The reason I’m using pug is so I can have a template then fill in the messages. The bot is broken in the way logs are displayed, at first it would only show as [object, Object]. Lastly I might just make the pretty option a config var as /pretty would have to be manually added to each log instead of just having it auto do it.

Perhaps the option could change the link that's posted? That way both options would be available, and the option would control which is the "default".

Should be able to template it with HTML and in-line CSS. Keeps things simple. It's just text logs, after all, no need to go crazy.
v / r
Robert Klebes
Mobile:<PHONE_NUMBER>
https://keybase.io/sporkwitch
https://www.linkedin.com/in/klebes
On August 7, 2019 11:53:16 AM EDT, Miikka<EMAIL_ADDRESS>wrote:

Perhaps the option could change the link that's posted? That way both
options would be available, and the option would control which is the
"default".
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/Dragory/modmailbot/issues/330#issuecomment-519158397

It is just text logs but the current version is very tedious to read. Also I’ll look into using ejs instead.

I'm working on making it looks like the Discord interface. Not sure if I'm going to release it though.

That was and is my goal, I just haven't gotten to fixing my code and adding the css.


Request for tools to be added to a dev/runtime container

It would be nice to have a consistent dev environment for the plugin developers where all of the typical dev tools would be available.  This would save some time for individual developers to find and copy over tools that will be typically used.
For CI and CM we'd want to keep the size of the container down as much as possible, as such we're looking for a second container where development can happen and all the tools used by Plugin developers would be installed and ready to use.
Tools/Libraries requested
Internal: IQT, ICT, PluginEmulator, Sarpyvalidator, BmvTool
External: Perf, Nvidia-nsight, Cuda-gdb (as a minimum, but since this likely wouldn't be the build container it's probably worth it to deal with the bloat of including all the cuda toolkit libraries)
Final details would be based on design that happens.

I'm seeing a request for 2 docker buildpro images here, so please correct me if I'm misinterpreting this

minimal image with only the set of packages needed to build plugins and PluginSdk (the rocky85-pin.dockerfile of the 24.10 release https://github.com/externpro/buildpro/blob/24.10/public/rocky85-pin.dockerfile)
plugin developer image that has the entire cuda-toolkit installed (what I am likely to call rocky85-pdv for "plugin development/developer")

does the cuda-toolkit include Nvidia-nsight and Cuda-gdb? because I haven't seen anything from you guys that provides a link to where these can be obtained separately)
all publicly available packages will be part of the publicly available rocky85-pdv image
internal tools (only available on isrhub) will be built into a local docker image (and not published to a container registery) the same way CRTool and webpro are handled today -- we can determine where the denv.sh script will look for what version of these tools to install (could be in PluginLibraries so everything uses the same version or could be controlled by each plugin independently)
rocky85-pdv could ditch LaTeX and perhaps a few other packages (doxygen? lcov for coverage? others?) that are in rocky85-pin if plugin developers aren't likely to utilize the functionality they provide but are required for CI and officially building the software)

perf is small and easy to obtain with dnf, so I may include it in both rocky85-pin and rocky85-pdv
I'll consult with @camerbam to learn whether VantageCI relies on docker-compose.sh -g to start a GPU container to run plugin device_test's -- perhaps the -g option can be the mechanism for a developer to start a container based on the rocky85-pdv image https://github.com/externpro/externpro/blob/24.10/compose.gpu.yml#L48 or I may need to add another option to the compose.gpu.[sh|yml] to support starting up a container that's based on the rocky85-pdv image https://github.com/externpro/externpro/blob/24.10/compose.gpu.sh#L10

also, just to clarify on the issue title "Request for tools to be added to a dev/runtime container" -- I'm assuming you aren't asking for a dev and a runtime container (I'm going to call it an image from here on out because the dockerfile that will specify all these requested tools will build a docker image and it becomes a container when instantiated) -- that instead of asking for two images (dev and runtime) you are asking for a single image and you didn't know whether to call it a dev or a runtime image
I would prefer to reserve any use of the word "runtime" to an image that doesn't include any developer tools or packages... just the base Rocky image and any packages that are necessary for a plugin to run (using the CI-produced plugin tar.xz) -- this is what VantageDocker provides for our microservices: a runtime image -- and if the plugin team desires something similar I would suggest this should be separate and independent of buildpro-based docker images

Yes, I'm looking for 2 different images.  Buildpro was acceptable as the small light weight image, but if a plugin specific build image is easy to make and maintain that would be a good option.
I'd have to check with Levi/Blake again, but I believe that the cuda toolkit would contain the cuda-gdb and a cuda-nisight.  I'm unfortunatley out tomorrow, but I'll get with them to get the answers to your question and update on Monday.

Latex we should be able to remove.  We don't build any pdfs and release them with our products.  I don't think we use doxygen at all.  We do still run and look at the unit test line coverages to focus on where we need to improve our unit tests.  I'll have to take a look at the other packages that are currently included to see if any more could be dropped.

I was a little unclear on the image/container.  I remember having the conversation with you before about these definitions, but when you had said that we have an image and then load up the internal tools (like CRTool) it made it sound like CRTool was not part of the image, but it would be part of the container.  Clearly there's more to the definitions that I didn't pick up on.  As to runtime vs dev images, we hadn't needed to deal with the distinction previously so I wasn't aware.  The title was left general so that you could provide a suggested solution without forcing you to work within my limited .

Buildpro was acceptable as the small light weight image

I'm going to clarify this, because using the term "Buildpro" is not specific enough to have any meaning here -- I'm assuming you're referring to the -bld image from before the last release (24.10)... so this image https://github.com/externpro/buildpro/blob/24.09/public/rocky85-bld.dockerfile
and yeah, as of the 24.10 release plugins no longer use the -bld image -- it is now the much more lightweight image used for building vantage microservices
as of the 24.10 release the -pin image is now the minimal amount of packages needed to build plugins and the PluginSdk
going forward the -pin image will remain the same (minimal amount of packages needed to build plugins and PluginSdk) and a new pdv image will contain packages requested for plugin development purposes
LaTeX is necessary to build the PluginSdk. So you are correct that no plugin products use LaTeX, but we do have a (plugin-related) product (PluginSdk) that does require LaTeX.
Regarding image vs container: anything specified in a dockerfile is going to create a docker image. When that image is instantiated by docker compose (if you're using the provided docker-compose.sh script), it becomes a container.
I'm not sure why you closed this issue... but it's okay for it to remain closed -- I'll take the information you provided here and compose other issues that the changes will reference

I was trying to get out the door last Thursday and my browser was acting really slow.  I had an edit I was trying to make before I left.  I must have accidentally hit the close.  Since we're moving forward with https://github.com/externpro/buildpro/issues/95 I'll leave it closed.

does the cuda-toolkit include Nvidia-nsight and Cuda-gdb?
Levi said the Cuda toolkit does include both of these.

Let us know on this issue or on #95 if you have additional questions.


chore: add coming soon tag to solana onramp

Description
Adds "Coming soon" tag to onramp on Solana
Type of change

[X] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues
Closes  APKT-783
Showcase

Checklist

[X] Code in this PR is covered by automated tests (Unit tests, E2E tests)
[X] My changes generate no new warnings
[X] I have reviewed my own code
[X] I have filled out all required sections

@tomiir Sorry I didn't know about this PR, handled this in another one. I think we could close 🙏🏽


Reset form after valid submit

Hello!
I tried to follow this
https://github.com/christianalfoni/formsy-react/blob/master/examples/reset-values/app.js
but to run function reset after user changed his password - but that doesn't work
I think in this example <button type="reset" manage action - not function onClick={this.resetForm}

I'm having trouble with this too. I can't seem to get this.refs.form.reset() to work at all, inside the submit() method or otherwise.

same here! anyone found a solution for this?
Also .. the link on the first post is incorrect .. the correct one is https://github.com/christianalfoni/formsy-react/blob/master/examples/reset-values/app.js

@jarussi-luizalabs did you make sure the fields all have initial values set in value= or defaultValue=?

@acomito thank you very much! That did the trick for me! 👍

Thats what got me too

@acomito thanks! just got this thanks to you. was so close to giving up and writing less pretty code

i have same issue, and I fix it like this
submitForm(data) {
  alert(JSON.stringify(data, null, 4));
  this.areaForm.reset();
}

resetForm() {
  this.areaForm.reset();
}

render () {
  return (
      <Formsy.Form
        ref={(event) => { this.areaForm = event; }}
        onValid={this.enableButton}
        onInvalid={this.disableButton}
        onValidSubmit={this.submitForm}
        onInvalidSubmit={this.notifyFormError}
      >
        .................
        .................
       <RaisedButton
          primary={true}
          style={{marginTop: 32}}
          type="submit"
          label="Simpan"
          disabled={!this.state.canSubmit}
          value={this.state.nameForm}
        />
        <RaisedButton
          secondary={true}
          onClick={this.resetForm}
          style={{marginTop: 32,marginLeft:32}}
          type="reset"
          label="Reset"
          value={this.state.nameForm}
        />
      </Formsy.Form>

That solution is working! Why doesn't this automatically happen? Is it broken or a feature request?

I am still not able to reset my form after valid submission even though I have set an initial value of the fields.
I have even tried setFormPristine method. That too doesnt work.


fix: pin adapter versions in adapter-auto

MUST be released before #8740 is merged
version is used to pin the installed adapter version and should point to the latest version of the adapter that is compatible with adapter-auto's current peerDependency version of SvelteKit. Will prevent adapter-auto from accidentally installing adapter versions that are possibly incompatible with the user's SvelteKit version.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Another idea - what if we downloaded the latest major version of the adapter from npm and checked its peer dependency. If it's not compatible we decrement the major version and try again

That assumes that there won't be any other types of breaking changes besides peerdep bumps, which doesn't sound safe to me.

Maybe we could add a lint check that checks if you have a major changeset for an adapter you've also updatedpackages/adapter-auto/adapters.js?

Would only work for the adapters in this monorepo. I think it's probably more complexity than its worth, I don't anticipate breaking changes happening often

Yeah, probably won't be too frequent. Though I do think that bumping the adapters' major version will happen more (e.g. if we change some options) than we add new API in kit. Maybe instead of introducing these versions we should bump the peer dependency version that adapter auto specifies on kit. Then we know anyone who's using the latest adapter-auto will have access to the new API added in kit.

That doesn't work, because without a version restriction you would get the latest version of an adapter which might have a newer peerDependency requirement than adapter-auto

You'd have to bump the adapter-auto peer dependency to be the highest of any of the adapters it can install. The advantage is that you'd have to do that less frequently than you'd have to bump the major version of an adapter

Maybe we are talking past each other. This PR suggests exactly that:

each time an adapter has a major release that bumps its peerDependency on SvelteKit, adapter-auto will also get a major release that bumps its peerDependency of SvelteKit (to the highest of all adapters it can install)
in order to not accidentally install adapter-vercel version 2.0 which needs SvelteKit 1.5 through adapter-auto version 1.2, we need a way to tell the adapter what maximum version of each adapter to install, and this PR does that.


[Feature request] Change extension name shown in address bar to HNTP

Is it possible to leave the extension name in "about:addons" as is (Humble New Tab Page), but change the name in the address bar to HNTP?
On narrow screens, opening a new tab makes it difficult/impossible to access the address bar because most space is being used by Firefox displaying "Extension (Humble New Tab Page)".
In times of wide screens, this might not seem important. However, it can become a problem on smaller secondary displays or in small Firefox windows.

Not a bad idea. There is an open request in the Firefox bug tracker to use the extension short_name in the address bar: https://bugzilla.mozilla.org/show_bug.cgi?id=1477800
I'll see if it's possible to have the address bar show HNTP, but still have it listed as "Humble New Tab Page" at addons.mozilla.org

I changed the extension name to "HNTP" in today's update, should save some space in the address bar.

I noticed :-)
Thanks a lot!


Options are not passed to socket-io

According to the docs, options can be passed to engine-io
app.configure(socketio(options [, callback]))
Sets up the Socket.io transport with the given Socket.io options object and optionally calls the callback described above.
Steps to reproduce
const socketio = require("feathers-socketio")
const feathers = require("feathers")
const app = feathers()
app.configure(socketio({ pingTimeout: 500 }, (io) => { })

Expected behavior
Options should be passed to engine-io
Actual behavior
Options are not passed (pingTimeout is still default 60000)
engine handshaking client "Pc2Haio7MvD9rkT5AAAA" +0ms
engine:socket sending packet "open" ({"sid":"Pc2Haio7MvD9rkT5AAAA","upgrades":[],"pingInterval":25000,"pingTimeout":60000}) +2ms
engine:socket flushing buffer to transport +0ms
engine:ws writing "0{"sid":"Pc2Haio7MvD9rkT5AAAA","upgrades":[],"pingInterval":25000,"pingTimeout":60000}" +0ms

System configuration
Tell us about the applicable parts of your setup.
Module versions (especially the part that's not working):
feathers-socketio 2.0.1
NodeJS version:
8.9
Operating System:
MacOS
Browser Version:
React Native Version:
0.46.4
Module Loader:

Setting options is being tested in https://github.com/feathersjs/socketio/blob/158e067aff7e5597d281c4bc1f5231d2b1bffb29/test/index.test.js#L91, I'm not sure where the issue might be at the moment.

False alarm...was due to a bad import which set pingInterval to undefined.


Internal ChangeFeed: Adds adoption of pagination library

Internal ChangeFeed: Adds adoption of pagination library
Description
This PR adds the adoption of the new pagination library to ChangeFeed. This will enable us to have a single common code base for pagination across partitions, which has split proofing and the ability to simulate the service fabric emulator.
This is done by adding CrossPartitionChangeFeedAsyncEnumerator which implements IAsyncEnumerator<TryCatch<ChangeFeedPage>>. ChangeFeedIteratorCore now is just a wrapper around this class to provide API compact with FeedIterator internal.
While I was making this change I added a laundry list of improvements:

Added ChangeFeedException, so that we have a base type that a visitor can convert to the proper CosmosException. This is in preparation for this enumerator to run in compute.
Refactored the request option populators to take in a request option as input to avoid having to new one up per request.
Added proper continuation token support for StartFromBeginning, StartFromTime, and StartFromNow.
Switched over to CosmosElement for continuation token parsing and serialization
** This make the code exceptionless instead of throwing a newtonsoft exception
** Allows for continuation tokens to be composed
** Allows for continuation tokens to be serialized in binary
ChangeFeed does not modify HasMoreResults on 304s.
** This avoids having to serialize to a continuation token and rehydrating the iterator everytime this happens.
** Also allows the user to write a customer retry handler on 304s and also implement client side long poll if they want
Correctly aggregates the charge for 304 pages that we skipped for the user
Buffers exceptions and returns an empty page with the aggregated stats
Added ChangeFeed logic to InMemoryContainer so that we can unit test without the emulator.

The grammar for the cross partition change feed token is:
<composite_change_feed_token> : '[' <change_feed_token>, ... <change_feed_token> ']'
<change_feed_token> : '{' "FeedRange" ':' <feed_range>, "State" ':' <state> '}'
<feed_range> : '{' "type" ':' <feed_range_type>, "value" ':' <feed_range_value> '}'
<feed_range_type> : "Logical Partition Key" | "Physical Partition Key Range Id" | "Effective Partition Key Range"
<feed_range_value> : <logical_partition_key_json_string> | <physical_partition_key_id> | <epk_range>
<epk_range> : '{' "min": <string>, "max": <string>'}'
<state> : <start_from_begining_state> | <start_from_now_state> | <start_from_time_state> | <start_from_continuation_state>

An example token is:
[
    {
        "FeedRange":{
            "type":"Effective Partition Key Range",
            "value":{
                "min":"BF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF",
                "max":"DF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF"
            }
        },
        "State":{
            "type":"beginning"
        }
    },
    {
        "FeedRange":{
            "type":"Effective Partition Key Range",
            "value":{
                "min":"DF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF",
                "max":""
            }
        },
        "State":{
            "type":"continuation",
            "value":"88"
        }
    },
    {
        "FeedRange":{
            "type":"Effective Partition Key Range",
            "value":{
                "min":"7F-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF",
                "max":"9F-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF"
            }
        },
        "State":{
            "type":"now"
        }
    },
    {
        "FeedRange":{
            "type":"Effective Partition Key Range",
            "value":{
                "min":"3F-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF",
                "max":"5F-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF-FF"
            }
        },
        "State":{
            "type":"time",
            "value":"2020-10-14T08:00:45.0937045Z"
        }
    }
]

Blocking on three things:

The Emulator ContractTest change (see comment)
responded to in comments.
The new behavior is throwing exceptions on 304, we don't throw exceptions on Not Modified currently. Why do are we doing it now? The previous behavior would simply return an empty page and HasMoreResults would be false, so the loop ended. What is the reasoning to add exceptions now?
responded to in comments.
ChangeFeedOptions.EmitOldContinuationToken: What is the use case and what happens if the user leaves it enabled continuously?
please read doc comments in source code.


fromHTML() method doesn't format document

I know it's still a beta option right now, but am I correct in stating that the fromHTML option will not format the text with any colors or additional styles that are noted with CSS?
For instance, if I make a h2 red, it seems to always render in black when the pdf is generated. Is this expected behavior at this point?

But this will make huge, non-searchable PDF files right?

@axos88 yes, the PDFs are very large and contain no text.  For my particular project, I was able to work within those confines, but I realize that could be an issue for other folks.

but the quality is too low! :-(

If anyone has made any progress on this problem please let me know. I am attempting to solve this styling problem as well. I am constructing a WYISYG editor that works in conjunction with jsPDF so that even basic styles can be ported over to the document.

@englep10 It's an inelegant solution, but rasterizing the HTML was the only thing I was ever able to get working consistently.
I thought about trying my hand at just writing some postscript and creating my own recently.

There's a function that renders the styled HTML onto a 2d canvas but as
vector.
On Tue, 18 Apr 2017 at 20:56, Thomas Gebert<EMAIL_ADDRESS>wrote:

@englep10 https://github.com/englep10 It's an inelegant solution, but
rasterizing the HTML was the only thing I was ever able to get working
consistently.
I thought about trying my hand at just writing some postscript and
creating my own recently.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MrRio/jsPDF/issues/91#issuecomment-294961011, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC5s88HrbgFQJnaEezbPAcgwY5FlcDDks5rxRVZgaJpZM4Am6m7
.

--
James Hall
Director
Parallax Agency Ltd
M.<PHONE_NUMBER>0

I appreciate the response. Are you referring to the html2canvas or rasterizeHTML.js work arounds? (need to be able to search the PDF) Or is there another function that I am not privy enough to know about yet? I've noticed you accomplished the ability to search the PDF though because I can do so from the PDF I downloaded from your demo site: (http://rawgit.com/MrRio/jsPDF/master/) the HTML Render (early stages) option.
I really do appreciate your help. If I am able to accomplish the same functionality that is being used on the demo site; I will be one happy camper.

Thanks @MrRio I was able to get a lot of my problems solved today! You were able to point me in the right direction when it came to using canvg. I cannot thank you enough; its really awesome to get this working.

@englep10  Hi dude I have the same problem as you had, can you precisely tell me how you solved it? I need to use basic styles at least for the table...

Searching for the solution for the same problem. Can anyone let me know the solution ?

i have the same problem, but this not have solution?

So it was a half solution. It returned the PDF as we wanted visually but still wasnt able to search against the pdf. We ended up doing a backend workaround in combination with OCR to achieve what we completely wanted.

I dont for the pdf to be searchable, nevertheless, I still cant use html2pdf as it breaks down while creating large pdf files due to canvas limit. Did anyone find any solution to retain css?

I dont care for the pdf to be searchable, nevertheless, I still cant use html2pdf as it breaks down while creating large pdf files due to canvas limit. Did anyone find any solution to retain css?

@antoniorrm i just moved on from this API and opted for a open-source Java solution which is more stronger, flexible and faster than this API.

Is there any solution discovered on this?

How to add custom CSS while generating PDF ?

How to add custom CSS in jsPDF ?


It is better to use the repository field in Cargo.toml

To allow Crates.io , lib.rs and the Rust Digger to link to it. See the manifest for the explanation.

Seems reasonable to me! I also un-aligned the fields in the Cargo.toml, to make for smaller diffs in the future.


Class path.database does not exist

I'm trying to use Cashier with my Lumen application, but creating the migration isn't working well.
% ./artisan cashier:table certificates

  [ReflectionException]
  Class path.database does not exist

@taylorotwell why was this closed?

how would i resolve the same problem ? thanks for your response


Extract function seems to extract to file

I've been looking for something like this for a while - particularly just being able to extract to a local function.
The "extract function" from the packages menu (and context menu) seems to extract the function to a file though, and "extract function to file" from the packages menu doesn't seem to do anything?
Looks promising though!

@Gruntfuggly thanks for the insterest, I should put in the readme that this is very early version. I have been working on extracting into a file first. Will add extracting into a function this evening hopefully

@Gruntfuggly I have implemented first version of extracting a raw function, you can try it out in 0.0.2, closing this issue, but if you have any other remarks or insights how to make it better, please open another issue


Not all routes being loaded

For some reason, only some of the routes are being used for my site. There should be around 70, but only two are being used and have entries in the rss feed.

This turned out to be that I didn't have published explicitly set on the blog posts. I was thinking Scully added that but it apparently wasn't available, so once I added that then it started to pick up the posts.


Getting error on while creating token

turso db create tokens recipe-book

Error: accepts at most 1 arg(s), received 2

@santoshgistto The above error has nothing to do with the project itself. Please check if you have the latest version of the Turso CLI. Or you could simply run turso update.


librarian-puppet can't download dependencies from puppet forge on Windows

Environment: Windows 7, Puppet 3.4.3, Ruby 1.9.3p484, librarian-puppet 1.0.1, librarian 0.1.2.
When installing puppet-modules from puppet forge using librarian-puppet 1.0.1, install silently fails and doesn't download the puppet modules. It works fine for dependencies from git though. I have also tested it with librarian-puppet 0.9.17 and same result. The only puppet module in the modules directory after librarian-puppet install is ldapdn, there is no sign of stdlib from the example below.
Librarian-puppet 0.9.10 works fine, it can download dependencies from forge, git and also resolve transitive dependencies. So it's broken sometime after 0.9.10.
My Puppetfile looks like:
forge "http://forge.puppetlabs.com"
mod 'gtmtechltd/ldapdn', git: 'https://github.com/gtmtechltd/puppet_ldapdn.git'
mod 'puppetlabs/stdlib'

For Puppetfile.lock and verbose output see https://gist.github.com/balrajs/322e94ce21e7ebbea85d.

I am curious if this is related to an issue I have been having.
I ran the install multiple times and it fails on the same gem both times.
One possibly interesting twist... I normally run librarian-puppet via sudo. When I did a manual run with a clean root env ( sudo su - ) and ran install everything ran fine and updated. Simply sudo bash and running resulted in the exception with spawn.
I'm now wondering if there is some catch/issue when running this via sudo like I'm doing. ( doubtful this sudo bit would apply to windows but it may share commonality? )

@bilsch your issue is that the puppet binary can't be found in the path

@carlossg not sure how I missed that but you are right thanks!


Information Architecture overhaul for the Admin UI

Background: https://airtable.com/tblD3oZPLJgGhCmch/viwchkdQkRUw6hZ3z/recIs3ktTDB785A97?blocks=hide
PM: @piyush-singh

Closing per @piyush-singh as there will be granular issues created corresponding to each page update.


Deterministic Destruction is incorrect

9.2.1 Deterministic Destruction states:

In Corinna, fields are indended to be destroyed in reverse order of
declaration, instance fields and then class (common) fields, from parent to
child. Consider the following (note that the syntax for :common might
change):
class Parent {
    field $one;
    field $two;
    field $three :common;
}

class Child :isa(Parent) {
    field $four;
    field $five :common;
    field $six;
}

The destruction order should be guaranteed to be:

$six
$four
$five # class data
$two
$one
$three # class data

This does not make sense. Destruction of class data should not be mixed with destruction of object data. It should always happen last. Consider that normal object destruction would not destroy class data at all - it would only be destroyed during global destruction.

Sorry, didn't see this comment earlier.
Yes, you're absolutely correct. I wasn't thinking.
In the future, this might apply if classes become "first class" and the class itself can fall out of scope, but clearly that cannot apply now.

Addressed in 9.2.1.

Important: at the current time, class data will only be destroyed in global destruction. In the future, if Corinna classes can become "first class" in the Perl language, if a class can fall out of scope prior to global destruction, then yes, class data can be destroyed prior to global construction (e.g, for an anonymous class created a runtime).


URL in description and README broken

The URL in the repository description and README are pointing to githubschool's copy of the game instead of yours.
Please fix both so they point to your copy of the game at https://githubschool.github.io/github-games-ctyler123

This was fixed in #3


Updates/corrections to README.md

First off, thanks for sharing this code -- I really needed it!  As a relative newbie to RN, iOS and Android dev I followed your readme quite closely and noticed two corrections:

we need to add some flags as well, so search for Other Linker Flags and add -Objc and -lc++

-Objc should be properly cased to capital O and capital C:  -ObjC (good thing there was a screenshot, but my eagerness to blindly copy/paste sent me down a debugging rabbit-hole for a day or so :) You only get an error indicating there's a problem if you run in Xcode with the extension as the target -- if you run with the app as the target, it fails silently.
Second, minor correction, in your code snippet for MyShareEx.m:

now go back to MyShareEx.m and paste the following code there.

...
@interface MyShareEx : ReactNativeShareExtension
@end
@implementation MyShareEx
- (UIView*) shareView {
..

need to include 'RCT_EXPORT_MODULE();' in between '@implementation MyShareEx' and
'- (UIView*) shareView {'  to read:
...
@interface MyShareEx : ReactNativeShareExtension
@end

@implementation MyShareEx
RCT_EXPORT_MODULE();
- (UIView*) shareView {
...

RCT_EXPORT_MODULE(); is in the actual file, but again, if someone copy/pasted from the readme, they would have missed it...luckily this was not a showstopper and did not break the module.

thanks @allenrl. Would you send me a PR for those typo. Example was the best source of truth.
One more thing. if you need to share some data between your app and the share extension you can take a look at react-native-swiss-knife. Look into RNSKBucket.

d'oh you beat me to it, @alinz !  thanks and i'll be sure to check out RNSBucket.


Test Post v0.0.5

This post should not come up with default labels.
This post should be listed when labels are set to include "testing"

Test passed


Support URL.createObjectURL

https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL
Implementing this API permits the creation of browser addressable urls for File and Blob.
These examples provide some tangible use cases.
https://developer.mozilla.org/en-US/docs/Web/API/File_API/Using_files_from_web_applications#example_using_object_urls_to_display_pdf
A drag is the need to also implement URL.revokeObjectURL which deallocates a url resource to refer to the object.
https://developer.mozilla.org/en-US/docs/Web/API/URL/revokeObjectURL

Hey @JasonKoopmans,
That sounds interesting. Especially how that relates to the lifetime of the reference to it. It is the plan to implement the entire File API in which these methods are defined. I will ensure that I update you when that is accomplished. 🙂

An update on this is that I have started the development of the FileAPI wrapper as its own project. Once that is more featureful and published to Nuget this package will be updated to use it.
https://github.com/KristofferStrube/Blazor.FileAPI

This was fixed as a part of #28 and has been published in version 2.0.0 to NuGet.
From the Blazor.FileAPI you can use the URLSerivce to call CreateObjectURLAsync on some Blob.


BUG - logic for finding a service needs to be enhanced

Description
The existing logic
https://github.com/SAP/open-ux-tools/blob/23ff77e63d288932a4fc26ade39115b2ac75a20f/packages/axios-extension/src/abap/catalog/v2-catalog-service.ts#L93-L106
needs to be enhanced, because it doesn't consider that a service URI can contain also segment parameters, e.g. path/to/backend/SERVICENAME;v=0001/, where v stands for version. If such path is passed to the findService method, then the logic inside will derive SERVICENAME;v=0001 as service title, which is wrong.
Additionally when searching for a service it is better to include also the service version in the query, for the case when they are multiple service versions.
Expected results
Correct filter parameters are used when searching for a service
Actual results
Wrong filter parameters used when searching for a service
Screenshots
If applicable, add screenshots to help explain the problem.
Version/Components/Environment
Add any other context about the problem here
OS:

[ ] Mac OS
[ ] Windows
[ ] Other

Root Cause Analysis
Problem
{describe the problem}
Fix
{describe the fix}
Why was it missed
{Some explanation why this issue might have been missed during normal development/testing cycle}
How can we avoid this
{if we don’t want to see this type of issues anymore what we should do to prevent}

FYI: Information about segment parameter https://www.ietf.org/rfc/rfc2396.txt section 3.3

@zdravko-georgiev it looks to me like #925 is fixing this issue, so I am closing it. Please reopen and explain what is missing if I was wrong.


Remove character

I removed '`' character in nouns.txt

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 4 committers have signed the CLA.:x: nlpenguin:x: Will Hohyon Ryu:x: festinalente91:x: MechanicKimWill Hohyon Ryu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


make codebase deno-first

the code has been ported to deno environment, but can still generate npm builds via dnt.
the major gain by moving to deno is the decrease in boilerplate configuration files needed for the library code to run/work/test/compile.
moreover, deno vscode extension does a far better job at type analysis than tsc.

alright, I approve of your-self request

sheesh I screwed up


After archive, the subtasks become indented by two levels, resulting in rendering abnormalities.

before archive

after archive

Hello, @ribber

What do you have Settings -> Editor

Are you using a linter plugin or another editor to edit your files?

I did not use a lint plugin or any other editor.

data.json

I'm sorry, I found my "Tab indent size" is 6, and When I changed this setting to 2, the execution was right


FreeIPA Support

This is probably at the bottom of the barrel in terms of priority. Please add in FreeIPA support. The only change require is a better method for the search filter.
the fix to get this working with freeipa was to change
search_filter = '(&(objectClass=user)({}={})(memberof={}))'.format(
settings.UID_ATTRIB, str(ldap_user), group_dn)
to
search_filter = '(&({}={})(memberof={}))'.format(
settings.UID_ATTRIB, str(ldap_user), group_dn)
This is working with my freeipa and mezzanine setup.
I'm not a good programmer, or I would just post the full fix.
Maybe a variable like
AUTH_LDAP_ADMIN_SEARCH_FILTER =

We could certainly implement this. I like the idea of placing the search
filter as a configuration option. We could then add documentation examples
for common filters.
Leave it with me.
Thanks!
On 12/12/2015 12:51 PM, "Donny Davis"<EMAIL_ADDRESS>wrote:

This is probably at the bottom of the barrel in terms of priority Please
add in FreeIPA support The only change require is a better method for the
search filter
the fix to get this working with freeipa was to change
search_filter = '(&(objectClass=user)({}={})(memberof={}))'format(
settingsUID_ATTRIB, str(ldap_user), group_dn)
to
search_filter = '(&({}={})(memberof={}))'format(
settingsUID_ATTRIB, str(ldap_user), group_dn)
This is working with my freeipa and mezzanine setup
I'm not a good programmer, or I would just post the full fix
Maybe a variable like
AUTH_LDAP_ADMIN_SEARCH_FILTER =
—
Reply to this email directly or view it on GitHub
https://github.com/sjkingo/django_auth_ldap3/issues/10.

Hmm looking closer at this it seems we already do a more broad search when binding for the user at backends.py#L228. Perhaps we should implement that for group membership testing also (except &(... memberOf(...)).
I don't see this causing an issue with AD or OpenLDAP but I'll test that change and if all goes well, I can push it to master.

Sorry, I haven't forgotten about this change - I will do some work on it shortly as it requires some extensive testing to ensure we don't break existing known behaviour.


An error occurred (InvalidParameterValueException) when calling the CreateFunction operation: Unzipped size must be smaller than 262144000 bytes

I am using zappa with a conda virtual environment. I could manage to deploy other apps before this one using conda environments by doing first export VIRTUAL_ENV=/path/to/conda/env/
This app contains a deep learning model that is itself (101M) so not surprised at all if the zip itself exceeds the allowed 250M. Is there a way to get around it? If so, which command should I run?
My goal is to use Zappa to deploy severless deep learning applications.

The limit is 250MB because the AWS storage limit of a lambda is 500MB. The only effective workaround I'm aware of is creating a layer with the model and then using that layer in the lambda. That way the zip and decompressed files don't have to fit inside the lambda, just the uncompressed one.Hope this helps,João

@gloriamacia  use "slim_handler": true, in your zappa_settings.json file. I've deployed large apps using that. There's some documentation about it in the readme.


Move network package to be a part of siad?

If we move CatchUp() to siad instead of being in siacore, then we should also be able to move the network package over right?
Just something I was thinking about. Seems to make sense to me that the networking code would be in the same library as the daemon. Maybe not though.

I'm going to close this, as the ideas have changed and it's now covered by issue #234


toolchain: Recommend using the gnu-mcu-eclipse distro over gnuarmemb

Change the recommended GNU ARM Embedded toolchain distribution to
gnu-mcu-eclipse instead of the release maintained by ARM.
This change is done for two reasons, either of which individually
justifies changing the recommended distribution.
The official release does not do bugfix releases, but gnu-mcu-eclipse
does. For instance, a fix to #12257 was developed 8. January and
released by gnu-mcu-eclipse on the 20. January, but has as of 7. March
still not been released by ARM.
The official release of the gcc compiler is significantly slower at
compiling than the gnu-mcu-eclipse release is. Both clean ninja builds
and individual source files are measured to build over twice as fast
with gnu-mcu-eclipse (measured on Linux).
This fixes #12257.
gnu-mcu-eclipse claims to be a drop-in replacement for the official
release, and AFAICT from comparing them this is correct. But more
testing will be needed to be sure.
Signed-off-by: Sebastian Bøe<EMAIL_ADDRESS>

I am reluctant to switch to a different Arm toolchain at this point in the process to be honest. I do get the advantages in performance and frequency of updates, but I am worried that we are switching to a non-official source of binaries for the toolchain that builds most of the boards in Zephyr

Sorry, closed by mistake

IMHO the quality of the release is more important than whether the source is official/non-official, but I can understand postponing this change until after the stabilization phase.

I am reluctant to switch to a different Arm toolchain at this point in the process to be honest. I do get the advantages in performance and frequency of updates, but I am worried that we are switching to a non-official source of binaries for the toolchain that builds most of the boards in Zephyr

I think I agree on this. Better to stress that the used toolchain has a bug in the latest release, and offer this toolchain as alternative only.

I think I agree on this. Better to stress that the used toolchain has a bug in the latest release, and offer this toolchain as alternative only.

Please clarify @ioannisg. Do you agree that it shouldn't be switched at this point in the process, or that it shouldn't be switched?

Temporarily closing. The timing for this change is not right due to being in the stabilization phase. Will re-open after release.

Codecov Report

Merging #14158 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14158   +/-   ##
=======================================
  Coverage   52.68%   52.68%
=======================================
  Files         307      307
  Lines       45473    45473
  Branches    10530    10530
=======================================
  Hits        23956    23956
  Misses      16640    16640
  Partials     4877     4877

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb1c900...fcf3460. Read the comment docs.

Can we still use *gnuarmemb * or not?

You can.


Add network probe results recognition

Now server recognizes network probe results from agent keep-alive message. This data is now the part of agents information that is provided on /api/v1/agents/ request. It can be used to provide corresponding metrics.
Related: https://github.com/Mirantis/k8s-netchecker-agent/issues/11

This change is

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

-(in progress)

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Fix CPU-driven churn once Text-to-CAD toast appears in the app

Closes #3505 with two solutions:

Properly cut off recursive loop created by animate() function by clearing the requestAnimationFrame reference and canceling it before clearing
Set up THREE.js animation loop to not run unless the user's mouse is on the canvas, since we only animate it for mouse interactions

Before performance graph

After graph

Nice, only PW failures are Windows Electron (expected, working on getting that green), and a flakey sketch one, no text-to-cad issues.


Is this repo updating with the recent code changes?

In the beginning of the repo, the news were that The entire Service Fabric runtime is being open sourced on GitHub – everything needed to build and run Service Fabric
Since then, it hasn't been updated in a few years, only announcements were made in the readme files.
Is the product still considered open source?
Or it is still being developed just in private repos internally within Microsoft?

Not MSFT here: They don't bother with the OSS thing. Its very much maintained but the team engagement is non-existing and OSS is not something they commit to in an significant way (they keep saying they want to, but nothing happens).

I have a sinking feeling that the open source goal will disappear early next year.

While extremely unfortunate I would rather they skip it than tey to
convince everyone its opensource when its really not.
On Wed, 7 Dec 2022, 20:08 Big Jake, @.***> wrote:

I have a sinking feeling that the open source goal will disappear early
next year.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/service-fabric/issues/1399#issuecomment-1341456323,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKQP7Q7QVIHXYDA7VBHYXDWMDOELANCNFSM6AAAAAARP5VZ2E
.
You are receiving this because you commented.Message ID:
@.***>

@esbenbach I agree.