Unable to reproduce the results mentioned in the paper.

Hello, I am very interested in your work and find it remarkable. So, I tried to reproduce it based on the code you provided. However, even after training multiple times with the default configuration file, I couldn't achieve the excellent results mentioned in the paper. The mAP I obtained is as follows:62.19% (D2SA),33.30% (COCOA),30.01% (KINS). This differs from the results reported in the paper.
Therefore, I have a few questions for the authors, and I hope you can help clarify my confusion:

Can the results mentioned in the paper be reproduced based on the configuration file given in the source code? If so, could you provide the weight files?
According to #1，I learned that you used Mask-RCNN weights trained on COCO dataset then finetuned on COCOA-cls. Could you please confirm if the same weights were used for training on the D2SA and KINS datasets, or if any other method was employed?
Sincerely looking forward to your reply！ @trqminh

您好，您复现的过程中遇到
ValueError: not enough values to unpack (expected 2, got 0)
您有遇到这样的情况吗？

您好，您复现的过程中遇到 ValueError: not enough values to unpack (expected 2, got 0) 您有遇到这样的情况吗？

Sorry, could you please be more specific?

您好，您复现的过程中遇到 ValueError: not enough values to unpack (expected 2, got 0) 您有遇到这样的情况吗？

Sorry, could you please be more specific?

Thank U for your reply. but  I have resolved it .


[Hub Generated] Publish private branch 'IoTOperationsDataProcessor'

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[x] New API version. (Such PR should have been generated with OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/14717

@rkmanda PTAL and let us know if you have any questions on this PR

@rkmanda I see that you added ARMSignedOff tag, does that mean that once we are ready (by removing the DoNotMerge tag), this PR will be ready to merge in right after?

@rkmanda I see that you added ARMSignedOff tag, does that mean that once we are ready (by removing the DoNotMerge tag), this PR will be ready to merge in right after?

I see the description above. this seems to be the case, just need to remove the DoNotMerge tag and add requestMerge which we can merge the PR when ready

/pr RequestMerge


Update logging

Adds a logging hook. It will let us do better in buildbot.
Also - in reviewing this I suspect that there is something around the buildbot doing async uploads.
Hopefully it will give us insight into:
problem 1: running another build when the deploy isn't completed. If the deploy goes into async mode, it will unblock that call causing the second build to get triggered.
problem 2: "hung build" - if the deploy goes into async it could mean that the build gets acknowledged (closing it) but the deploy completes. Could this cause an issue around the deploy not getting closed/auto-deploying?

LGTM but jenkins is complaining


Pretrained models

Hi ,
Can you please provide one drive or Google drive links for the pre-trained  models .

Thank you for supporting our work. We will be synchronizing all Baidu Pan content to One Drive in the near future (about today). If you find our repo useful for your work, please give star, thanks!

We have already synchronized all Baidu Pan datasets and weights to One Drive now! Thanks your issue.


Why i cannot use my NUM pad keys in the shortcut instead of upper  numeric keys on the keyboard

Environment
Windows build number: [run "ver" at a command prompt]
PowerToys version:
PowerToy module for which you are reporting the bug (if applicable):

Steps to reproduce

Expected behavior

Actual behavior

Why i cannot use my NUM pad keys in the shortcut instead of upper  numeric keys on the keyboard
While using shortcuts i cannot use my num pad keys in the shortcut i have to use the upper numeric keys in the shortcut instead
Screenshots

Was this when you remapped a shortcut with Keyboard Manager? Can you give an example?

Nope so when we use Shortcut Guide i want to maximize or minimize a app from taskbar so we use the Win+Numeric keys so in that i cannot use my Numpad keys i have to use the Upper section numeric keys. That is the problem.

Thanks for the clarification @Techvellar

It is very important issue.
numpad keys are much more ergonomic to use because they are right next to my mouse.
Please make it so both numpad and upper section numeric keys can be used for win+# shortcuts.

@enricogior I'm not sure if this actually is an issue with Shortcut Guide, but rather with those windows shortcuts itself, because if I press Win+NumPad 3 nothing happens (when num lock is on or off).

Windows distinguishes number line and numpad keys. Only line ones handle taskbar, when used with Win. And additionally, with other modifiers for more actions - like new window or context menu for particular taskbar button.
You can use Keyboard Manager to bind numpad shortcuts to number line ones.
Thus it has nothing to do with the scope of Shortcut Guide.

@arjunbalgovind
if I'm not mistaken, ShortcutGuide doesn't process the Win + num, it only shows the number, but it's Windows itself that takes care of processing the shortcut.

This is Windows, outside our scope


Use column index rather than column name for feature binning, selection and one-hot module.

Is your feature request related to a problem? Please describe.
Since guest party can start a task and config the cols param for host, it is better to use index instead of column name in cols parameters. This is due to guest party may not be able to get column names from host.

Already finished


Config file for testing bert sizes

Can you share the length of time needed to run through this tuning configuration file? It's hard to figure how many valid configurations were actually used. Thanks.

I'm not sure how long it takes to run in this format, I ran parts of this incrementally to measure performance changes with each feature. There is a rather large number of valid configurations though, and running the full file would take a number of hours. @amdkila is currently running this with additional sizes. Do you need precise numbers for run-time or configurations included?

Can you share the length of time needed to run through this tuning configuration file? It's hard to figure how many valid configurations were actually used. Thanks.

I'm not sure how long it takes to run in this format, I ran parts of this incrementally to measure performance changes with each feature. There is a rather large number of valid configurations though, and running the full file would take a number of hours. @amdkila is currently running this with additional sizes. Do you need precise numbers for run-time or configurations included?

I assume you're covering a small subset of the BERT sizes in this file, right?  Are you saying even with the small subset of the sizes you picked, it's going to take hours to run through this file?  That's the concern I had.  Normally we ran a tuning configuration, looked at the winners (and almost winners) to decide which options offered very little, if any, benefit, then we prune them to reduce tuning time.  Oh well, as long as @amdkila isn't complaining, I'm happy.

Can you share the length of time needed to run through this tuning configuration file? It's hard to figure how many valid configurations were actually used. Thanks.

I'm not sure how long it takes to run in this format, I ran parts of this incrementally to measure performance changes with each feature. There is a rather large number of valid configurations though, and running the full file would take a number of hours. @amdkila is currently running this with additional sizes. Do you need precise numbers for run-time or configurations included?

I assume you're covering a small subset of the BERT sizes in this file, right? Are you saying even with the small subset of the sizes you picked, it's going to take hours to run through this file? That's the concern I had. Normally we ran a tuning configuration, looked at the winners (and almost winners) to decide which options offered very little, if any, benefit, then we prune them to reduce tuning time. Oh well, as long as @amdkila isn't complaining, I'm happy.

I have all the sizes in a larger yaml file available here. I can add these to the PR, but I haven't had the chance to run through all the kernels yet.


Neurodesktop play (on Europe server) cannot load new containers

Hi,
this seems to be a new problem, since it worked just a couple of hours ago.
When I try to start a new container in Neurodesktop Play, I get this message. It is hard to catch since it is only on screen for half a second or so.
Hope this helps you debugging the error.
Best,
Dario

Dear @dabosch - thank for flagging this. We are looking into the issue.


put meta tags for social media previews into block

This PR puts social media preview tags into block. This makes it easier to customize templates.
Currently on about page (https://mybinder.org/about), there is only description info for social media previews: <meta property="og:description" content="Reproducible, sharable, open, interactive computing environments.">. I also changed it, so about page has the same tags as index page for social media. I can also totally remove it from about page. What do you think?

Happy to merge this if you can fix the conflict, @bitnik

This is done :)

Thanks, @bitnik!!! I'll try deploy this soon too

This seems to work ok, @bitnik. Thank you!


Disabled test results

Adds better descriptions for tests that are disabled
Detects and ignores disabled tests in report instead of failing \
Adds back TLS and DNS tests removed in a disabled state

The output of this PR is as below:

If a test is disabled, we do not want it to be present in the test list - especially as the user does not have the ability to enable or disable tests from the UI. Instead, disabled tests should not be present or run at all.

I think we need to differentiate here what a user can do vs what the UI can do.  The user has every capability of disabling tests, the UI does not.  Skipping a test within a module and indicating it makes sense.  Removing any indication a disabled test exists in the system seems like something that would cause confusion in the results.

Our primary user is manufacturers who use the user interface. With this current setup, we are telling the user about tests which do not exist within qualification (or will not in 4.5). I am not opposed to have the tests available for labs or other users to run but it seems counter productive to have them present.

Maybe we just need to add this as a configurable option in the report to show/hide disabled tests hiding by default.  I can look into that and add to this PR.
Not sure we should remove any tests that might get removed from 4.5 until it's finalized but should continue to use 4.4 as the reference for test generation until then.

Maybe we just need to add this as a configurable option in the report to show/hide disabled tests hiding by default. I can look into that and add to this PR.
Not sure we should remove any tests that might get removed from 4.5 until it's finalized but should continue to use 4.4 as the reference for test generation until then.

With this in mind, I'm happy to have the tests re-added and enabled by default - provided that we add an option in the config to hide disabled tests (prevent them from running at all) which should be enabled by default. Once 4.5 is released, we will set the test status to disabled.

These re-added tests are no longer present in the device qualification test plan so I will close this PR now. In the future, I would like to add a module with just informational tests that provide us with additional info about devices. I will leave the branch present.

Re-opening as this is not just adding tests in disabled state,  it is fixing disable tests state detection.  Regardless of current test plan, we shouldn't remove tests if they are not part of the test plan, we should only ever disable them unless they are fully removed for some other reason.

Right now it marks the tests as disabled in their description and with a skipped state.  If we want them hidden from the report, we should probably move that to it's own update so we can prevent merge conflicts with all the other recent updates to the report format.


ZeroTier and ecowitt integration

Ecowitt service is not available in my ZeroTier network.

Sorry, I'm going to need more details.  What is zero tier?  is the station making http connection requests to wherever you want it to?


Fix Example project on React Native Web

After quickly trying to get useSharedValueEffect work on web, I decided to disable the example for now.

Does this mean that the web doesnt support useSharedValueEffect?


spdk: Reinstate linking to event_nvmf.a

This re-enables the default nvmf target in SPDK to hopefully address
CI test failures that cannot be reproduced locally.

bors try

Seems to get a little further with starting Mayastor in the mocha test:
2020-09-30T12:39:27.993757394+00:00  INFO mayastor::subsys::nvmf::target: nvmf target accepting new connections and is ready to roll..💃
2020-09-30T12:39:27.994054768+00:00  INFO mayastor::core::reactor: scheduled nvmf_tgt_poll_group_0 0x55aea06023b0 on core:0

but the test still times out. The cargo tests do pass so it's looking like a CI infrastructure issue.


Android UI

Implements the encryption to match the server again, and improves the UI of the Android client.

The current PR makes the Android client work with the server on dev, without the nonce tweak.

Is there anything that can be done to get this PR merged? I am trying to package Ultrablue in NixOS at the moment and it seems like our only choice is to either package this PR to generate the Android app or to use the fosdem-2023 tag in the meantime.

Is there anything that can be done to get this PR merged? I am trying to package Ultrablue in NixOS at the moment and it seems like our only choice is to either package this PR to generate the Android app or to use the fosdem-2023 tag in the meantime.

Hi @RaitoBezarius, thanks for trying to package it in NixOS, we can definitely do something to help, we could create a first stable tag but will have to review a bit more the android client code before merging it.
I'm not quite sure to understand why you need to generate the Android app in order to package it though. Could you explain a bit more ?

Is there anything that can be done to get this PR merged? I am trying to package Ultrablue in NixOS at the moment and it seems like our only choice is to either package this PR to generate the Android app or to use the fosdem-2023 tag in the meantime.

Hi @RaitoBezarius, thanks for trying to package it in NixOS, we can definitely do something to help, we could create a first stable tag but will have to review a bit more the android client code before merging it.

FWIW: https://github.com/NixOS/nixpkgs/pull/222068 is our integration in initrd and https://github.com/NixOS/nixpkgs/pull/222062 is the binary (a stable tag would be awesome).

I'm not quite sure to understand why you need to generate the Android app in order to package it though. Could you explain a bit more ?

I don't know exactly your plans, but currently, from what I am seeing:
FOSDEM-2023 Android app is incompatible with master.
This PR seems to solve the issue.
If in the future, it is possible to have protocol incompatibilities, in nixpkgs, we can package the server with the Android app such that a user can do something like nix-build -A ultrablue-server.android-app and get his own APK compatible to this very specific ultrablue-server whatever revision or version it might be.
It also take care of something which would probably be interested in Ultrablue scope: proper reproducibility and source provenance tracking of the Android application for such a "critical" piece of software.
Of course, it's possible with F-Droid and all that stuff, it is just not too hard to do in nixpkgs. :)

Anyway, I am not going to merge the PR too soon, but it would be awesome if Ultrablue made it in the upcoming release of NixOS (23.05), at end of May, meaning, I probably have ~one month if I want to make this part of the next stable release.

Also, for completeness, I am working on SecureBoot in NixOS and a bit of TPM2, and we would like to make this part of the next stable release, so having also Ultrablue would make the first release with somewhat of a SecureBoot support -- very interesting for our users. :)

FOSDEM-2023 Android app is incompatible with master.
Oh thats true, will try to merge soon, sorry for that.

@nbouchinet-anssi Hey there, did you have any time on this? Nixpkgs will be shipping a stable release with the FOSDEM tag at the moment, I believe.

Hi there, I see you had successful presentations in Pass the Salt, any news on this PR?

Hello @RaitoBezarius, I'm starting a code review now. Sorry for the delay.

Hello @RaitoBezarius, I'm starting a code review now. Sorry for the delay.

Great news, don't hesitate to ping when you will have a release, in the meantime, I have suspended all integration of Ultrablue in NixOS.

What is the latest revision where the server and client are compatible?

Since the project is in a WIP state, we have not yet clearly defined its scope nor its roadmap, we will work on this clarification after the summer holidays, until that day, no stable tags for clients and server will be released and you should not use the project in production.
However, @Tecol87 if you want to test the project, you should be able to use the fosdem branch.
Anyway, thank's for your interest for the project and sorry for this issue.

@nbouchinet-anssi
Thank you very much for the clarification and your work on this project!
Then I will setup my new production system with tpm2-totp and cryptographic-id.
On my testsystem I will test this project until it is production ready.

Hi there @nbouchinet-anssi , hope you had great summer holidays. It would be helpful on my side to understand if the project has still interest from ANSSI for further development or was it deprioritized or something.
We are moving on with TPM2 in NixOS and it would be a nice showcase to offer Ultrablue to our users.


Added Decode VBE

This will allow the decoding of Microsoft VBE files. Wasn't sure where to put this so I put it in "Data Format".

I was just looking at the issues. I guess this would solve #165. Maybe it should be renamed Microsoft Script decoder.

Yea, it should. Haven't seen anything saying different.


Heuristic to guess residues in a topology

In the same spirit as the guess_bonds function, we could try to guess the residues in a topology. The simplest version could simply assume residues == molecule, and just follow the bonds graph. A more elaborated version could try to match sub-graphs to known residues like amino-acids.

I now think this is out of scope for chemfiles itself. It can be implemented on top of it if someone is interested!


Sometimes fails to display language breakdown labels until you click in

I can reliably reproduce this just by visiting /insights on .com and refreshing until I get a load with the label missing. A customer also ran into this recently and was wondering why there were no labels.

Transferring this to the main repo as it is a problem with all pie charts (e.g. codecov too), not just this insight. I think this is something between the interplay of our grid library and the recharts library (both use JS to layout and measure outer containers, and there could be a race condition).


Cache linked shader programs instead of just vertex and fragment shaders

We're already caching VS and FS compilations, but a final gl.linkProgram is not under that cache, and the following WebGL calls are very heavy.
As seen by @makella , when doing something as trivial as removing a lot of style from a comment inside the editor, the program gets linked once per letter, and the performance is completely destroyed, with pauses of more than 20 seconds. It seems that on top of that, something is making each call slower than the one before:

We should cache the linked programs too to avoid this problem.
PS: great profiling image :joy:

Fixed by https://github.com/CartoDB/carto-vl/pull/461 and https://github.com/CartoDB/carto-vl/pull/463


Update model/schema of article

Resolve #59

@KevinDangVN I think, you get me wrong. I will close this pull request, the only valuable is asset model that's all we need for now. All other changes were reversed my changes.


Fix wrong ordering on when clauses in audit.rb

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew tests with your changes locally?

It looks like a rebase/merge conflict remmenet. I'm not totally sure if I got it right, but it is definitely not right as is.

There's a brew style complaint after this I'm not sure I understand: https://bot.brew.sh/job/Brew/2444/version=any_sierra/testReport/junit/brew-test-bot/sierra/style/

I think I get it, any splats when clauses e.g. when FOO* must come last since they catch more then the plain ones. I'll fix it right away.


feat(db) Support for Cassandra 3.x - lua-cassandra 1.x

Summary
Implement support for Cassandra 3.x by upgrading lua-cassandra support to
1.x. This is waiting on a lua-cassandra 1.1.0 release before being merged.
In the meanwhile, manually install the master branch of
lua-cassandra.
Full changelog

Support for lua-cassandra 1.x
Support for Cassandra 3.x (2.x is still supported)
Configurable Load Balancing policy for the C* cluster. We now support
Datacenter-aware round robin with the cassandra_lb_policy and
cassandra_local_datacenter properties in kong.conf
Rework the rate-limiting and response-ratelimiting plugins "cluster"
policies (those are using the DAO). We now pass the DAO as an argument instead
of extending the plugin's DAO.
Get rid of classic.lua pattern to create DB modules. We now use
kong.dao.db.init
Prevent using a C* cluster made of nodes with different major release
versions
Implement a mock ngx.shared.DICT API for use in resty-cli because
lua-cassandra 1.x depends on an shm. Waiting on
https://github.com/openresty/resty-cli/pull/12 to get rid of it.
Better Lua idioms for DAOs and the Factory (Factory.new() instead of
Factory())
slightly rework the codestyle of the C* and Postgres DB modules

Issues resolved
Fix #1294
Missing

Bump lua-cassandra to 1.1.x

Tests: waiting on lua-cassandra 1.1


The clangd does not recognize file included from different include tree.

Hello,
I have a simple structure, with two header files header-a and header-b, both placed in different include tree.
/tmp/include-a/
  |- header-a

/tmp/include-b/
  |- header-b

/tmp/impl
  |- main.cpp
  |- .clangd
  |- compile_commands.json

I configured .clangd with two include dirs /tmp/include-a and /tmp/include-b.
// .clangd
CompileFlags:
  Add: [-xc++, -I/tmp/include-a, -I/tmp/include-b]
  Remove: []
  Compiler: clang++

These include files are used by main.cpp. They are both properly recognized by clangd. There are no errors for these includes and I can hover over them and ctr+click to open any of them. So far so good.
// main.cpp
#include <header-a> // this is recognized properly (can open file when hovering over it)
#include <header-b> // this is recognized properly too

The header-a file includes header-b, and when I open header-a file, clangd can't recognize included header-b:
// header-a
#include <header-b> // "'header-b' file not found" error - not possible to open file with hovering

The main.cpp compiles fine with gcc with added these two include paths:
 /usr/bin/g++ -std=c++17 -I/tmp/include-a -I/tmp/include-b  -o main.cpp.o /tmp/impl/main.cpp
How to reproduce.

Extract the structure to /tmp

Open folder with code /tmp/impl

Open main.cpp -> all headers resolvable

Open header-a  -> header-b not recognized

The whole structure for reproduction:
tmp.zip
And the clangd log:
clangd.log
Thanks in advance!
Cheers,
Roman
System information
Output of clangd --version:
clangd version 18.0.0git (https://github.com/llvm/llvm-project c014454f43bf523fee2bf695c075882b1cefd21c)
Features: linux+grpc
Platform: x86_64-unknown-linux-gnu
Editor/LSP plugin:
VSCode Version: 1.85.1
Operating system:
PopOs 22.04

I found an answer in similar issue #1615.
The solution is to add these includes to user config, in my case ~/.config/clangd/config.yaml:
CompileFlags:
  Add: [-xc++, -I/tmp/include-a, -I/tmp/include-b]
  Remove: []
  Compiler: clang++

I don't know the rationale, why does it work this way, but IMO it is confusing, as the header-a is properly recognized in one file, while it is not in the other. The only difference is that the first time it is included by file sitting inside project (.cland file) hierarchy, while the other time it is outside. For gcc it is irrelevant ...
I spent the whole day solving this misery ...

An alternative solution that I find a bit easier to work with is:

Make sure the -I flags are in the commands in compile_commands.json (for example, by using Bear to generate the compile_commands.json file).
Run clangd with the --compile-commands-dir option as discussed at https://clangd.llvm.org/faq#how-do-i-fix-errors-i-get-when-opening-headers-outside-of-my-project-directory.

Note that with this solution, neither .clangd nor ~/,config/clangd/config.yaml is needed.

@HighCommander4 thanks for your comment above. Do you know how --compile-commands-dir is specified in an VS Code environment.
clangd seems to use the .clangd file that is within the directory tree of the source code or the clangd/config.yaml file.  This is explained here https://clangd.llvm.org/config#files

Do you know how --compile-commands-dir is specified in an VS Code environment.

In vscode settings, under "clangd.arguments".

Thanks @HighCommander4.  it seems to specify a config.yaml file (with similar content as .clangd), i.e. --compile-commands-dir=<path>/config.yaml. However even with this option, it failed to recognize files outside the directory tree.
/config/clangd/config.yaml works, however it is system wide and not specific to a VS Code workspace.
Any hints are welcome.

@ReinhardKeil The argument to --compile-commands-dir is not a path to a config.yaml file. Please have a look at clangd --help which says the following about it:
  --compile-commands-dir=<string>     - Specify a path to look for compile_commands.json. If path is invalid, clangd will look in the current directory and parent paths of each source file

@HighCommander4 thanks this was very helpful!


Plugin not workling anymore? API changes?

Description of Issue
The plugin stopped working for me since november 10.
Did AEG changes to the API again?
Is it working for you @thoukydides?
Plugin Version
2.2.4
AEG/Electrolux Appliance(s)
AEG RX9-1-IBM 900 277 268, AEG RX9-2-4-ANM 900 277 479, AEG RX9-2-6-IBM 900 277 480
HomeKit App(s)
No response
Diagnostic Checks

[X] AEG iPhone app is able to control the appliance.

Log File
No response

There appears to have been some server-side issues on 11th and 12th November, which required me to generate new Access and Refresh Tokens. However, since then it has been working fine for me.
What issues are you seeing?

Ah good hint!
I had to generate a new API key as well as Access and Refresh Tokens.
Now it works again, thanks!

It looks like the authentication servers had some problems. I am using two access/refresh token pairs with the same API key - one for my production Homebridge setup, and one for testing this plugin. The token refresh for the production setup appears to have returned invalid tokens requiring new ones to be issued manually. The test token pair was refreshed successfully and remain valid.
The API documentation does mention that "there is an upper limit on the amount of token pairs a user can have at the same time" but without any explanation of what happens when the limit is reached... and unlike almost every other OAuth implementation the dashboard does not list the currently issued tokens or allow their revocation. Perhaps you hit that limit and generating a new API Key would have started afresh.
Many other OAuth implementations keep the same refresh token and only rotate the access token. That approach avoids this problem since when things recover a new token refresh will automatically yield a good access token. But with that approach the Dashboard would need to provide a revocation mechanism in case the refresh tokens leak.

Thanks for the explanation.
I am glad it works again. ;-)

Is it necessary again to get a new API code?
[03/12/2024, 05:03:33] [Homebridge AEG Robot Vacuum] [AEG RX9-1-IBM] Lost connection to cloud servers: Appliance state watchdog timeout

You are right, they are back up. ;-)


Should with_clean_env zap the RUBYOPT additions?

From what I can tell Bundler.with_clean_env tries to go one step further than Bundler.with_original_env by removing all of Bundler's influence on sub-processes. Shouldn't the additions to RUBYOPT also be removed when executing in the context of Bundler.with_clean_env?

I think the idea is that with_original_env will take care of RUBYOPT. If you have a use-case that needs RUBYOPT cleaned, please tell us about it.

Yes, I have a use case. Process A does the bundler setup. Then spawns Process B (not cleaned). Process B then wants to spawn process C in a clean environment. RUBYOPT will remain dirty despite calling with_clean_env. I understand why with_original_env still has a dirty RUBYOPT (since it is just restoring the process as it was when B was started). But it seems like with_clean_env should go one step further and actively clean the env in cases like this (since it is actively removing other Bundler changes).
My above setup might sound contrived but it is a simplification of a real world problem. When running my testing, my Rakefile is under Bundler's influence (i.e. it has require 'bundler/setup' at the top so I can then import the bundler tasks). But I am also using the standard Rake TestTask. The TestTask spawns a new ruby process (this would be process B in my above description). Now my tests call my library code which needs to spawn a ruby script without Bundler influence (as it is it's own script with it's own dependencies). I attempt to spawn this final process in a clean environment but the script errors out because it cannot load it's dependencies since it is still under Bundler influence because of the dirty RUBYOPT.
For now I have a workaround of the following:
  Bundler.with_clean_env do
    # Ensure Bundler isn't influencing subprocess
    ENV['RUBYOPT'] = (ENV['RUBYOPT'] || '').gsub %r{-r\s*bundler/setup}, ''
    `some ruby script`
  end

You don't need to require bundler/setup to require the rake tasks. You point about subprocesses seems valid, though. Would you be interested in patching with_clean_env and submitting a pull request? Thanks!
On Jan 3, 2012, at 12:21 PM, Eric<EMAIL_ADDRESS>wrote:

Yes, I have a use case. Process A does the bundler setup. Then spawns Process B (not cleaned). Process B then wants to spawn process C in a clean environment. RUBYOPT will remain dirty despite calling with_clean_env. I understand why with_original_env still has a dirty RUBYOPT (since it is just restoring the process as it was when B was started). But it seems like with_clean_env should go one step further and actively clean the env in cases like this (since it is actively removing other Bundler changes).
My above setup might sound contrived but it is a simplification of a real world problem. When running my testing, my Rakefile is under Bundler's influence (i.e. it has require 'bundler/setup' at the top so I can then import the bundler tasks). But I am also using the standard Rake TestTask. The TestTask spawns a new ruby process (this would be process B in my above description). Now my tests call my library code which needs to spawn a ruby script without Bundler influence (as it is it's own script with it's own dependencies). I attempt to spawn this final process in a clean environment but the script errors out because it cannot load it's dependencies since it is still under Bundler influence because of the dirty RUBYOPT.
For now I have a workaround of the following:
 Bundler.with_clean_env do
   # Ensure Bundler isn't influencing subprocess
   ENV['RUBYOPT'] = (ENV['RUBYOPT'] || '').gsub %r{-r\s*bundler/setup}, ''
   `some ruby script`
 end

Reply to this email directly or view it on GitHub:
https://github.com/carlhuda/bundler/issues/1604#issuecomment-3345485

Hmmm, don't know why I have been using require 'bundler/setup'. Probably just picked it up somewhere and have been using it ever since. Maybe it avoids having to type bundle exec before rake some_task? Regardless, as you said it is still and issue and I can put together a pull request.
Question: Bundler adds both a -I and a -r option. The -r is really the killer as that causes code to execute. The -I is mostly harmless. Should I remove both options or just the -r option like my work-around does until we encounter a real need to remove the -I option. My guess is both. While we are in there might as well make the environment truly clean.

Closing this since #1611 now has the actual patch (couldn't figure out how to add a pull request to an existing issue).


Report 5752 "Picking List" | "Expiration Date"

The Report 5752 "Picking List" should include the field(6503; "Expiration Date"; Date) from the table 5767 "Warehouse Activity Line" with the Serial No. and Lot No..
It would need to be implemented under the same conditions as the  Serial No. and Lot No. in the dataitems WhseActLine , WhseActLine2 and the Layout since its an important field for the Item Tracking.

Hello! This is probably a good idea, bug we cannot process such requests here. It should be created on aka.ms/bcideas to get prioritized for implementation after partner voting.


Typeface change

Turns out nobody can use Google Sans (aka Product Sans) and Google Sans Text legally except for Google themselves because these fonts don't have open source license.

You can refer anything in Material Design 3, but only their fonts cannot. So before this whole project turns into a real thing, let's get rid of them.
They do have substitute fonts in the world that looks pretty similar and have personal/commercial license available, the best one of them is: https://tipotype.com/mundial/. But just look at the price.
And we should have a branding design now, so -
Introducing the new typefaces
Display Font - Hanson Bold Behance, Hanson Method Website
Headline Font - Arvo: Google Fonts
Body Font - Rubik: Google Fonts
All three of them are personal/commercial free fonts.
https://www.figma.com/proto/sr7kxGpFQP8yBu52f3ejuz/Material-3-Design-Kit---Lifeline-Version?page-id=49823%3A12141&node-id=49848%3A6285&viewport=1295%2C481%2C0.57&scaling=min-zoom&starting-point-node-id=49848%3A6285&show-proto-sidebar=1
Typefaces in use:

Oh that's a bummer. Liking the new options though, just not too sure about Hanson Bold. Judging by the Behance page and how it looks on our webpage, I feel it's a little too overpowering
Thoughts on this maybe? https://fonts.google.com/specimen/Archivo+Black?preview.text=YOUR FAVOURITE CALENDAR&preview.text_type=custom&category=Sans+Serif

Here's for comparison.
I think I still prefer Hanson Bold as a better option. Archivo creates more harmony with the other two typefaces but also make them look a bit dull. The difference in wider shape of Hanson Bold creates a sense of creativity is what I was aiming for, and I love when it still comes along with the other two fonts. Appreciate the suggestion though!
I really hope Hanson font has other font weights available or I can find substituting font with various font weights to it. I will replace it when I encounter another font that suits even better.
And since Hanson Font is a display font only, the only use case for this font is very big font size and in "marketing" pages, so the frequency of appearance for this font is quite low and limited so it won't take over the design.


go 1.18.8 throwing High and Critical CVEs

What happened:
A clear and concise description of what the bug is.
What happened:
Container scans reveal high and critical CVEs with current golang version of go go-1.18.8
What you expected to happen:
Update go to the newest version which to mitigate the vulnerabilities.
How to reproduce it (as minimally and precisely as possible):
Running a security scan for CVEs against the containers
Environment:

KubeVirt version (use virtctl version): v0.59.2
Kubernetes version (use kubectl version): 1.26.1
VM or VMI specifications: N/A
Cloud provider or hardware configuration: N/A
OS (e.g. from /etc/os-release): N/A
Kernel (e.g. uname -a): N/A
Install tools: N/A
Others: N/A

/cc @EdDev

@shwanbekas , release-0.59 is using go 1.19.2 [1].
So I am not clear why you ref Go 1.18.
[1] https://github.com/kubevirt/kubevirt/blob/e175af729a29aa97ac9706226561416678800d3c/WORKSPACE#L155

the kubevirt-cdi issue is with go go-1.18.8
the kubevirt-virt  has CVEs with go-1.19.2
kubevirt/virt-api
[CVE-2022-41717] CVE-2022-41717)
go-1.19.2
/usr/bin/virt-api
An attacker can cause excessive memory growth in a Go server accepting HTTP/2 requests. HTTP/2 server connections contain a cache of HTTP header keys sent by the client. While the total number of entries in this cache is capped, an attacker sending very large keys can cause the server to allocate approximately 64 MiB per open connection.
cdi-uploadserver
[CVE-2022-41723] CVE-2022-41723
ABC Failure
go-1.18.8
/usr/bin/cdi-uploadserver
A maliciously crafted HTTP/2 stream could cause excessive CPU consumption in the HPACK decoder, sufficient to cause a denial of service from a small number of small requests.

Here is a CDI repo https://github.com/kubevirt/containerized-data-importer

@shwanbekas , this issue is now resolved, both stable branches (0.59 and 1.0) have been updated.
I'm closing this issue.
Feel free to re-open if you find that something is missing.
/assign @EdDev
/close


Add Tushar to the team page

Fixes #4090.

Hey @tusharshahrs -- take a look at the preview link above ☝ and if it looks good, give it an approve, and I'll merge it in!


Applies localization to credential types on data types page

Signed-off-by: Akiff Manji<EMAIL_ADDRESS>Fixes #69

Doh...I see it now.  #75 :-)


Student handbook is not downloadable (link is broken )

Course Name: AZ-140-Configuring-and-Operating-Microsoft-Azure-Virtual-Desktop
Problem: Student handbook is not downloadable (link is broken )

MOC Labs Review confirms this issue.

MOC Labs Review confirms this issue.

Removed - downloads are available by using the standard GitHub functionality
rgds
Marcin


Synced with template and updated box version 0.6.0

Closes #34

Synced with template
Updated box version 0.4.0 -> 0.6.0

Should 022-update-nomad-write-default-policy.yml be named 030 instead of 022 as per execution sequence?

Regarding the execution sequence:
Should 00-create_dir_for_persisting_data.yml and 022-update-nomad-write-default-policy.yml be named 030 and 031 instead of 00 and 022?

these numbers just to define seq. And try to have some room, you might need in the future. So I recommend 030 and 040


Doesn't recognize my workspace

Describe the issue
I created a pipeline to create an artifact, containing the .pbix file.
With the artifact created, I'm trying to publish it to a premium workspace at the company I work for.
(maybe this is the problem:  personal workspaces vs. work workspaces)
However, I am getting the error:
2023-10-09T22:08:38.4847323Z ##[debug]Exception:
2023-10-09T22:08:38.4893064Z ##[debug]System.Management.Automation.RuntimeException: Power BI Workspace: CTIC - Indicadores BI - Desenvolvimento does not exist
2023-10-09T22:08:38.5158798Z ##[error]Power BI Workspace: CTIC - Indicadores BI - Desenvolvimento does not exist
2023-10-09T22:08:38.5165302Z ##[debug]Processed: ##vso[task.logissue type=error]Power BI Workspace: CTIC - Indicadores BI - Desenvolvimento does not exist
2023-10-09T22:08:38.5166820Z ##[debug]Processed: ##vso[task.complete result=Failed]

However, the workspace exists!!!

I noticed the error because I saw, in the logs, that the extension was trying to create the workspace when the creation option was enabled... I thought it was strange, since the workspace in question exists!
When the option was enabled I received an "Invalid Request" message
Then I disabled the option and started getting this error.

Extension

Extension: Power BI Actions
Version: 5.4.44

Expected behavior
Considering that Security Goup is already enabled in the workspace, I expected the dashboard to be published in the workspace.
Note: here is a video containing explanations for configuring Power BI Actions
Note2: I'm trying to publish to a workspace owned by the company I work for. I have already configured the application and security group registration in the company's Azure Portal!

Situation (please complete the following information):

Agent type: windows-2019
Autentication: Service Principal

Log info
Attachment ReleaseLogs_14.zip

I enabled the option to create the Workspace! But it gives the following error: "InvalidRequest".
I attach the log ReleaseLogs_16.zip
I also thought the problem was with permissions, but I have ALL permissions enabled for the Service Principal (in section "Power BI Service") and still the error remains.

I had already selected all possible permissions in "Delegated Permissions" and the two possible ones in "Application Permissions", trying to make pbix publishing work...
The only thing I couldn't change (because I don't have permission) is that in the options "Tenant.ReadWrite.All" and "Tenant.Read.All" there is an alert stating that "Not granted for {org}"..

...however, I don't believe this could be related...
I don't know where I'm going wrong...

@maikvandergaag ,
I appreciate the help!
I've been studying more and more... and I found the error!!
I detail it here to help someone who is also making the error.
I had added Admin permissions to the Group I created in the Azure Portal. It didn't work.

I chose to include the Application (Main Service) as Admin! Now it worked! I did this after reading this suggestion in the issue #153


Small updates

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 99.501%

Totals

Change from base Build<PHONE_NUMBER>2:
0.09%

Covered Lines:
1747

Relevant Lines:
1754

💛  - Coveralls


Should DevKit be bundled with Ruby Installer?

When trying to get started with Ruby on Rails, creating a new Rails app, this problem below appears. Should the DevKit just be bundled with the Ruby installer? This would lower the barrier to entry.
---------Ruby Installer 2.2.3
Installing json 1.8.3 with native extensions
Gem::InstallError: The 'json' native gem requires installed build tools.
Please update your PATH to include build tools or download the DevKit
from 'http://rubyinstaller.org/downloads' and follow the instructions
at 'http://github.com/oneclick/rubyinstaller/wiki/Development-Kit'
An error occurred while installing json (1.8.3), and Bundler cannot continue.
Make sure that gem install json -v '1.8.3' succeeds before bundling.

@TigerMint This is something comes up every so often, The short answer is there are too many valid reasons it shouldn't.
The biggest reason is that multiple versions of Ruby use the same version of the DevKit. But, RubyInstaller is also repackaged by many different distributions, and the DevKit isn't necessary to run Ruby itself.
Plus with things like RailsInstaller, I feel like there's a pretty good basis for not needing to necessarily bundle the DevKit. Engineyard + contributors do a pretty awesome job on it.
But I do wish that the whole DevKit installation process was easier.

Closing this, but could provide some context for a future discussion.


CRAB-29308: stop instances without stop after tag without warning

Description: Instances that do not have a "stop after" tag and are in a "stopped" state should be stopped immediately without giving any warnings.

Code makes sense to me, but to be clear is the idea that if an instance is running and there is no "Stop after" tag, then the instance should be immediately stopped?

Yes. Stop all instances running without "Stop After" tag.


Move handlers out of Alt stores and into handlers namespace

Handlers don't belong in the Alt stores, need to move them to a separate namespace that dispatches actions.  These can also be passed from the top level stateful view (ref #217)

Testing: cannot verify this.


Added a locale property to date and datetime widgets

Summary
Replaces pull request #2617 since the date widget has been deprecated in favor of the datetime widget.
The popup calendar for date and datetime widgets are always using en as locale. With a minor tweaks, react-calendar and momentjs make it easy to support other locales. That makes the calendar easier to use and less error prone for people being accustomed to week starting on Monday.
Test plan
https://drive.google.com/open?id=1JSgjPAsiFoOnZMld0mWq6CTpEA9asNWw

Just remembered why we left locales out in the first place - this bumps our bundle up by 200kb (50 gzipped, 862kb -> 912kb) by including every locale 🤦♂
Need to consider how to avoid bloating the build for everyone.

It might be possible to extract locales' data to another file so that interested users could add another script tag in their html doc ?

Right, it would have to be something like that.

We can re-visit this now that https://github.com/netlify/netlify-cms/pull/2870 is merged.
I think we might be able to import specific moment locales in each translation file, e.g.
const moment = require('moment');
require('moment/locale/ja');

moment.locale('ja');

Source: https://github.com/jmblog/how-to-optimize-momentjs-with-webpack/tree/2a3a9ab796455fe3a644473911aa2fe6f0ddf7e4#using-ignoreplugin
This will help with the bundle size for netlify-cms-app, but not netlify-cms

@erezrokah yeah, agreed.
@clamb thanks for raising this! Here's what's needed from here:

Rebase to latest master
Default to locale config so that setting locale on the widget itself is optional
Update docs accordingly

Changing the locales for the date/datetime widgets can actually be achieved with no code changes.
As one can set the moment locale globally doing the following works:
import moment from 'moment';
import 'moment/locale/ja';
moment.locale('ja');

@erezrokah I think that branch is a great approach, let's do it.

Closed in favor of https://github.com/netlify/netlify-cms/pull/2985


Sync up with the original source and add new prompts

Sync up with the original source, https://github.com/skillrepos/copilot-hands-on
Add more prompts such as in the Lab 01 - Use GitHub Copilot to learn how to use GitHub Copilot section.

At this point, all changes are completed and desk-checked. Time to do a dry-run as the next part of the review.

The dry-run is complete after making a few corrections and refinements.


[3.2.12] Ability to disable unused-method-temp compiler warnings during load/filein

On filein, as as I recall on project load, every method that has unused method temps puts up a dialog that I have to click on yes to.  My historic non-jadeite code is teeming with method temps, and filein is very painful. I just pressed enter continuously until it was over.
I think on filein or load you should never have to see compiler warning dialogs for unused method temps; watcha gonna do, and they create no particular harm.  Other kinds of compiler warnings we can discuss.
Failing that, a preference at least!

My $0.02.
When you want CompileWarnings, you want all warnings ... so I'm inclined to have have a Warnings preference ... on second thought, I never want to see 'not optimized' warnings, because there's nothing you can do to to fix the Warning ... on third thought when you want CompilerWarnings, you want them all ... on fourth thought (quietly) writing Warnings to the Transcript is probably a better way to go ... if someone asks for Warnings, we an tell them that they are written to Transcript and we're done ...
End $0.02.

[3.2.13] I've disabled CompileWarning's on file in. If we want a preference instead, let's open a new issue.

They are still causing me great suffering on project load. Please make these go away.
Confirmed that filein doesn't put up warnings, but it doesn't write anything to the transcript either.  Was it supposed to?  It would be handy - I don't mind fixing the problems but I don't know how I'd figure them out.

Found another path that needed to suppress warnings. Testing manually against Lisa's AAA project showed successful suppression.


feat(index): do not send 500 status for GraphQL execution errors

Background: https://github.com/graphql/express-graphql/issues/427
We don't want to send 500 status code on GraphQL execution errors as the status code error doesn't matches most of the cases with the type of errors we send back and it indirectly disallows clients to implement retry strategies and others network features based on status code.
Note, this doesn't change the rest of the behaviour, only the case where an execution error happens and we have { data: null, errors: [ ... ] }.
Follows GraphQL specs.

Replaced Travis to have tests running here 👍

Published as<EMAIL_ADDRESS>


[Snyk] Fix for 6 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

619/1000  Why? Has a fix available, CVSS 8.1
Prototype Pollution SNYK-JS-AJV-584908
Yes
No Known Exploit

696/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Denial of Service (DoS) SNYK-JS-DECODEURICOMPONENT-3149970
Yes
Proof of Concept

761/1000  Why? Mature exploit, Has a fix available, CVSS 7.5
Denial of Service (DoS) SNYK-JS-DICER-2311764
Yes
Mature

644/1000  Why? Has a fix available, CVSS 8.6
Prototype Pollution SNYK-JS-JSONSCHEMA-1920922
Yes
No Known Exploit

479/1000  Why? Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-MINIMATCH-3050818
Yes
No Known Exploit

696/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Prototype Poisoning SNYK-JS-QS-3153490
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: express-fileupload
    The new version differs by 250 commits.

9f22db7 version bump
9fca550 Merge pull request #240 from AmazingMech2418/patch-1
1530cf5 Make Travis happy
e43bfcf Fix typo
8bf7427 Update processNested.js
fd40389 version bump
94c9cf9 prototype pollution fix #2
829f395 version bump
db49535 Merge pull request #237 from richardgirges/fix-236-proto-pollution
d81bee9 Upgrade latest packages; run npm audit fix; add logic to prevent prototype pollution in parseNested
e9848fc Update package-lock.json
d536cfb Update package.json
c7a6b9c Merge pull request #233 from RomanBurunkov/master
a53b93f Update tests to support empty files
d8c00c5 Add empty files support for tempFileHandler
b24233d Comment extra condition in fileFactory(issue #1), add more logging
d57ee02 Formatting utilities
b6097df Merge pull request #232 from RomanBurunkov/master
05004b7 Merge pull request #230 from Code42Cate/readme-timeout
1afa527 Update dependencies
880c2b7 Improve timeout option documentation
3f130b0 Add timeout option to README.MD
d55fa83 Merge pull request #222 from wbt/patch-1
d61f02f Fix some small typos

See the full diff

Package name: tap
    The new version differs by 250 commits.

8f2baa7 16.0.0
65e599e drop support for node v10
84fc6df docs: changelog for v16
e6acf7b update coveralls documentation to say to install it
3c7b3ef document coveralls removal in the cli help output
43bf1df undocument synonyms
1ff75a4 make coveralls an optional peer dep
3f1ae47 Add eslint for linting
162c1a8 Support Typescript for --before and --after
28d2d03 Fix script on using node-tap with codecov
3a0e81c docs: fix broken link
1b636b2 Add jsonpath-faster
c4bdeef fix typo `than` to `that`
20fbd40 Update Node.js min version to 10.x in CONTRIBUTING
90dda0b update cli doc
636ab18 15.2.3
e609d8f docs: changelog for 15.2
c182328<EMAIL_ADDRESS>f576a60 docs: setting t.snapshotFile
d9fa241<EMAIL_ADDRESS>a02f33e update cli doc
d1500b6 15.2.2
b784d77 tap-parser@11
567384e update cli doc

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution
🦉 Denial of Service (DoS)

Checkmarx One – Scan Summary & Details – 04248274-62a0-4c53-af54-65372419d7b8
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2023-46234
Npm-browserify-sign-4.0.4
Vulnerable Package

CVE-2022-22984
<EMAIL_ADDRESS>Vulnerable Package

CVE-2022-22984
Npm-snyk-sbt-plugin-2.11.0
Vulnerable Package

CVE-2022-22984
Npm-snyk-python-plugin-1.16.0
Vulnerable Package

CVE-2022-22984
Npm-snyk-mvn-plugin-2.7.0
Vulnerable Package

CVE-2022-22984
Npm-snyk-gradle-plugin-3.2.2
Vulnerable Package

CVE-2022-22984
Npm-snyk-docker-plugin-1.33.1
Vulnerable Package

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 57
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-test-sarif.yml: 8
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-code-manual.yml: 13
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-code.yml: 15
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 71
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-code.yml: 8
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 46
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-test-sarif.yml: 15
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity
Issue
Source File / Package

CVE-2019-10746
Npm-mixin-deep-1.3.1

CVE-2019-10747
Npm-set-value-2.0.0

CVE-2019-10747
Npm-set-value-0.4.3

CVE-2019-20149
Npm-kind-of-6.0.2

CVE-2020-7699
Npm-express-fileupload-0.0.5

CVE-2021-23440
Npm-set-value-2.0.0

CVE-2021-23440
Npm-set-value-0.4.3

CVE-2021-3918
Npm-json-schema-0.2.3

CVE-2022-3517
Npm-minimatch-3.0.4

CVE-2022-38900
Npm-decode-uri-component-0.2.0

CVE-2023-26136
Npm-tough-cookie-2.4.3

Cx2937c64c-029b
Npm-coveralls-3.0.9

Cx687ca332-0af8
Npm-express-fileupload-0.0.5

Cx9fce0189-774f
Npm-handlebars-4.0.11

Cxac192d90-742c
Npm-mem-1.1.0

CVE-2020-15366
Npm-ajv-6.10.2

CVE-2020-7608
Npm-yargs-parser-9.0.2

CVE-2020-7608
Npm-yargs-parser-8.1.0

CVE-2023-28155
Npm-request-2.88.0


src/Illuminate/Auth/SessionGuard.php logoutOtherDevices is not compatible with non Eloquent model objects

Laravel Version: 8.44.0
PHP Version: 7.4.19
Database Driver & Version: N/A

Description:
Session Guard user() function return an Illuminate\Contracts\Auth\Authenticatable
The logoutOtherDevices() function expects the user() object to be an Eloquent model.
This means that logoutOtherDevices() can only work if your application uses an eloquent model for your Illuminate\Contracts\Auth\Authenticatable.
As far as i know  this should not be a constraint.
The way i think it should work is that logoutOtherDevices can only use functions that are defined in the interface.
protected function rehashUserPassword($password, $attribute)
{
    if (! Hash::check($password, $this->user()->$attribute)) { // should be probably be $this->user()->getAuthPassword()

for forceFill:
 return tap($this->user()->forceFill([
            $attribute => Hash::make($password),
        ]))->save();

we should probably create a new function in the lluminate\Contracts\Auth\Authenticatable  interface
something along the line
return $this->user()->setAuthPassword()
Steps To Reproduce:

Use a non eloquent model for the application Illuminate\Contracts\Auth\Authenticatable
try to use Auth::logoutOtherDevices()

This sounds more like a feature request. Welcoming PR's 👍

Well it leads to fatal error if you dont have an eloquent model as illuminate\Contracts\Auth\Authenticatable so personally i think it is a bug, except if somewhere in the laravel documentation it says that all Authenticatable should be eloquent models


Backport the Dart SASS compiler

Ticket Link
GROUPINGS-1647
List of squashed commits

Backport the Dart SASS compiler

Test Checklist

[x] Exhibits Clear Code Structure:
[x] Project Unit Tests Passed:
[x] Project Jasmine Tests Passed:
[x] Executes Expected Functionality:
[x] Tested For Incorrect/Unexpected Inputs:

Why does Codacy Static Code Analysis fail?

Why does Codacy Static Code Analysis fail?

Codacy is not configured to run on devrc-2-5-0, so you can ignore it.


Switch our omnisci/modin branch to Arrow1.0

Omnisci master already made that switch and Modin will switch also(see #1844).
For switching we need to merge omnisci master into our modin branch

Changes merged into our modin branch. There is an issue with one geospatial test now (ExecuteTest/Select.GeoSpatial_Geos) when omnisci built through conda, that will be fixed separately. Will close this after somebody else will check omnisci conda dev build


Uncaught TypeError: this.durationSelector is not a function

RxJS version:
5.0.0-rc.1
Code to reproduce:
https://jsfiddle.net/98mq5u13/2/
Expected behavior:
throttle should work normally
Actual behavior:
throttle throws the error in the title
Additional information:

This is because supplied time delay into throttle which expects durationSelector. v5 splits throttle's polymorphic behavior to throttle(durationSelector) and throttleTime(delay), so in this case throttleTime is probably what you expected. (https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md)
p.s: I noticed operator split missing throttleTime in migration document..it need to be updated.


(PUP-10604) Guard against JRuby FIPS

Puppetserver still loads all types and providers during catalog compilation,
and JRuby with FIPS enabled cannot require rubygems. So guard the require
statement like we do in puppet/ssl/openssl_loader.
The /opt/puppetlabs/bin/puppetserver gem install command will fail
when running with JRuby with FIPS, so confine the provider when
fips_enabled is false. That way trying to manage a puppetserver gem
will print:
Error: /Stage[main]/Main/Package[uuid]: Provider puppetserver_gem is not functional on this host

instead of:
Error: Execution of '/opt/puppetlabs/bin/puppetserver gem install --no-document <gem>' returned 1:
  ERROR:  Loading command: install (NameError)
  cannot load (ext) (org.jruby.ext.openssl.OpenSSL)

We definitely don't expect this to be used on server right? Just loaded?


Adds package gdal and 16 other dependency packages

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Adds the following packages in SPECS-EXTENDED:

gdal
freexl
libgeotiff
proj
gpsbabel
hdf
netcdf
libkml
uriparser
blosc
qt5-qtserialport
shapelib
CharLS
cfitsio
ogdi
libgta
liblerc

Change Log

Does this affect the toolchain?

NO
Test Methodology

Pipeline build id: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=410746&view=results,
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=410771&view=results

Can we break this PR in smaller chunks. This feels a little difficult to review. Also, think revert case. If one of the packages needs to be reverted for some reason, reverting this squashed-merge would revert the entire 17-18 packages.

I started out by creating singled out PRs, was advised to create single one with all dependencies.
I agree with the revert case. Sure, I will break it down for easy review.

Can we break this PR in smaller chunks. This feels a little difficult to review. Also, think revert case. If one of the packages needs to be reverted for some reason, reverting this squashed-merge would revert the entire 17-18 packages.

I started out by creating singled out PRs, was advised to create single one with all dependencies. I agree with the revert case. Sure, I will break it down for easy review.

I would say .. group all packages that depend on each other in a single PR .. and maybe the leaf nodes can go as a seperate PR.


Introduce a dual-bar display for network stats

Display network upload/download as a single, dual-color bar in prometheus stats.

duplicate https://github.com/kyma-project/busola/issues/980


Get Prometheus to monitor itself and export a dashboard

The default Prometheus config monitors itself anyway, but a
dashboard must be sent back to Grafana for visibility to make this
useful. Grafana "includes" a Prometheus dashboard, but it does not
include Juju topology, and isn't as complete as the one included
here.

The PR is unfortunately borked: the job that self-scrapes Prometheus is NOT adding the Juju topology labels and that breaks ofc the dashboard:

Also, what about PromQL alerting rules?

Topology is now added to self-monitoring, ad well as the relation for Grafana-agent. Alert rules next

Topology is now added to self-monitoring, ad well as the relation for Grafana-agent. Alert rules next

It’s soooo cool :-)

9 votes for self-*, let's go with that and only use it for the ones that also provide that relation organically, ie. self-metrics-endpoint for Prometheus, self-logs for Loki, self-logs for Grafana Agent, and self-dashboards for Grafana itself.

Closing this as it's already present through @Abuelodelanada's PR


代码在CPU上运行

您好，请问这份代码是否有在纯CPU上运行过呢？

The deformable conv op is supported by CUDA only. If you want to run on CPU, you may disable all deformable convs in our model and retrain yourself.

OK, thank you.


✨ Plugin Manager

Closes #49

Some comments:

Config settings are set programmatically.
New config setting (by installing package) require an Atom restart (Settings Views cache needs to be cleared for the setting to appear).
By default all plugins are enabled (backwards compatible).
Disabling & enabling works instantly (see screenie).
All plugins settings in the Settings View are grouped in a section named "Plugins".
Groups can't have description, but I think the plugin setting descriptions are sufficient.
I don't think we can remove the config setting when plugin is uninstalled (needs confirmation).
Ideas "borrowed" from Minimap package.
This opens support for custom button types.

TODO:

[x] Implement plugin manager.
[x] Figure out why plugin setting description don't show up anymore.
[x] Specs.
[x] Documentation.
[x] Remove console-messages.
[ ] Test, test, test.

I've been running this PR for a few weeks now and I'm quite happy with it.
@suda @cakecatz @zertosh I would love if you guys could review and test before merging...

Looking

Oh man, there are a lot of perf killers in here, that are only going to make things worse. Here's a CPU profile of what happens during init while tool-bar is adding buttons:

As you can see, for just 13 buttons (and 2 spacers), tool-bar is taking +100ms. Unfortunately this doesn't show up in time-cop as being attributed to tool-bar- but rather to the individual packages that added the buttons. Atom tallies up service consumption under activationTime for the consumer, not the provider. However, a quick profile shows you where the work is happening.
The reason this is happening is because DOM ops happen after every button is added. The way "Plugin Manager" is implemented, makes you still pay the price of adding a button, but then double penalizes you by touching the DOM to take it out. To make matters worse, explicitly writing to the config (i.e. atom.config.set/atom.config.unset) is very expensive (though these are batched by Atom, and run after packages load - but still).
IMHO, if a breaking change like Plugin Manager is going to be implemented, it makes sense to also add some sort of DOM queue (along with other DOM optimizations).

Thank you so much for your reply. I really have to learn more about profiling.
How does this PR compare, performance-wise, to the current situation? I don't want to introduce new performance killers, but this PR isn't focused about fixing existing ones.
You opened my eyes about the penalty by adding a button and then removing again. Will have a look how to improve that.
atom.config.set only happens once, when the plugin is for the first time is registered. A small overhead to register a plugin is expected.
atom.config.unset only happens when a plugin calls destroy. Clean-up when a plugin requests this I belief should be done.
This change is fully backwards compatible, so I don't understand your comment about "breaking change"...
Do you have an example of DOM queue solution?
This PR is open for maintainers, so if you want and have the time I would value your contribution.

@jerone 👍
Current disabling of plugin is not working at next running.
I think good if plugin disabling will disable package actually.

@cakecatz An unchecked plugin checkbox should disable the plugin immediately and still at next startup. Can you confirm that your config file contains a key tool-bar.plugins.<plugin> with the value false...

I think good if plugin disabling will disable package actually.

I don't think that's a good idea. Some packages (e.g. Nuclide and menu-manager) provide button(s) as an extra service, while their primary goal is doing something different.

How does this PR compare, performance-wise, to the current situation?

If a button is hidden, then you're increasing its cost because it gets added to the DOM first, then removed.

atom.config.set only happens once, when the plugin is for the first time is registered.

So perf aside on this one, I know many people (including myself) that version control ~/.atom/config.cson. This going to cause churn :( From looking at the code, I can guess that you're doing this because immediately below you call atom.config.observe and that was giving you undefined?
You can't access the defaults for exported configs during load. We've had that problem too. If you know what the default is supposed to be, then use that if you get undefined from atom.config.get (that means the user hasn't set a value). See https://github.com/facebook/nuclide/blob/8c8206d/lib/main.js#L188-L194.

This change is fully backwards compatible, so I don't understand your comment about "breaking change"...

At least Nuclide assumes that buttons always have a parent node. If a user chooses to hide one, that's no longer true. This is fine, but def a breaking change :)
So now would be the time to implement the queue since that implies that consumers can't assume that a button in the DOM. I think the current implementation of enabled/disabled living as a separate, yet tightly coupled module, tool-bar-plugin-manager.js, makes the queue more complicated. I generally really like the idea of the user having control over the buttons, but maybe that logic belongs in tool-bar-manager.js. I have to think about it.

Do you have an example of DOM queue solution?

Let me think about it, because the tricky part is only applying the queue during Atom's init. Or always applying it, but flush it on a requestAnimationFrame. I don't know what the profile of that is. I'll fiddle with it tomorrow and put up a RFC PR.

This PR is open for maintainers, so if you want and have the time I would value your contribution.

Thank you :) I'll give this time tomorrow!

I think good if plugin disabling will disable package actually.

I don't think that's a good idea.

Plus, group name != package name. You really have no way of knowing that name of the package that's adding a group.

@zertosh commented on 29 sep. 2016 05:09 CEST:

How does this PR compare, performance-wise, to the current situation?

If a button is hidden, then you're increasing its cost because it gets added to the DOM first, then removed.

Oh sorry, I meant other then adding-and-then-removing-issue (fully agree on that, am looking into that)...

atom.config.set only happens once, when the plugin is for the first time is registered.

So perf aside on this one, I know many people (including myself) that version control ~/.atom/config.cson. This going to cause churn :(

Actually I'm syncing my config too.

From looking at the code, I can guess that you're doing this because immediately below you call atom.config.observe and that was giving you undefined?

You can't access the defaults for exported configs during load. We've had that problem too. If you know what the default is supposed to be, then use that if you get undefined from atom.config.get (that means the user hasn't set a value). See https://github.com/facebook/nuclide/blob/8c8206d/lib/main.js#L188-L194.

Thinking about it, I could probably remove that block as the default is already true. The idea was copied from Minimap. I have to check if it's not required for the dynamic config schema.

This change is fully backwards compatible, so I don't understand your comment about "breaking change"...

At least Nuclide assumes that buttons always have a parent node. If a user chooses to hide one, that's no longer true. This is fine, but def a breaking change :)

In an early draft the buttons where hidden with display: none for this reason. I removed that solution; because it was just to easy to force show the button again. Right now they are indeed removed from their parent. I've not seen any other package having issue with that. Would something break for Nuclide if you've build an extra parentnode check around it?

So now would be the time to implement the queue since that implies that consumers can't assume that a button in the DOM. I think the current implementation of enabled/disabled living as a separate, yet tightly coupled module, tool-bar-plugin-manager.js, makes the queue more complicated. I generally really like the idea of the user having control over the buttons, but maybe that logic belongs in tool-bar-manager.js. I have to think about it.

:+1:

Do you have an example of DOM queue solution?

Let me think about it, because the tricky part is only applying the queue during Atom's init. Or always applying it, but flush it on a requestAnimationFrame. I don't know what the profile of that is. I'll fiddle with it tomorrow and put up a RFC PR.

This PR is open for maintainers, so if you want and have the time I would value your contribution.

Thank you :) I'll give this time tomorrow!

Really value your input :heart: (and others)!

Ok so I was thinking about this, and I really do think it makes sense to merge the functionality from tool-bar-plugin-manager.js into tool-bar-view.js. The two are so tightly coupled that they really should be one and the same.

I'm not sure I can see the benefit from that. If anything I like to move more things from tool-bar-view to tool-bar-manager and from tool-bar-manager to tool-bar-plugin-manager.
This is how I see it:

The PluginManager takes care of registering and unregistering plugins. It's the public interface that plugins can use.
The ToolBarManager takes care of the plugin request to add/remove buttons/spacers at the correct index in the correct tool-bar. At one point I like to extend this class with custom buttons and multiple tool-bars.
The toolBarView takes care of adding DOM elements to the tool-bar.

I've not worked-out everything, as this is an ongoing process and not set in stone.
Can you elaborate why you want to combine tool-bar-plugin-manager.js into tool-bar-view.js?

Why is this closed?

@aminya commented on Nov 10, 2019, 7:07 AM GMT+1:

Why is this closed?

Because I moved away from Atom and no one took over this PR in 3 years.
If anyone is interested in continuing, the branch is still there.

@suda could you merge this?

@aminya it's been a while so if you're willing to continue Jeronen's work on this feature, we'd love a fresh PR 😊 The branch probably needs rebasing and most importantly testing 👍🏻

I created a fresh up-to-date branch with this PR being on wait. Let's see if I find time to work on this:
https://github.com/aminya/tool-bar/pull/1

@aminya the URL you provided does not work, also judging by the structure of the URL it looks like you opened the Pull Request on your fork of the repository rather than to this repository :thinking:

@suda I cloned my branch into this repo. This way other people can work on it, after I delete my fork. Feel free to delete the branch if I was out of line.

@ericcornelissen Oh sorry. I removed as I can't work on this for near future.


Create a consul adapter for Meshery

An initial bare bones version can be found here

Hello @venilnoronha, it has been a while we heard from you. Hope you are doing well.
One qq to you: would you be interested to take a stab at this adapter?

Hi @girishranganathan! What needs to be changed in the existing one?

hey @venilnoronha what exists is just a bare bones one. Doesn't have much functionality.

@venilnoronha @girishranganathan which is to say that it needs the provisioning flow initially addressed.

@nicholasjackson and @eveld, it'd be good to get your eyes on this adapter as we go to release a v0.1.

Consul adapter released.


Address more code review feedback for the SwiftIfConfig library

Address some of the remaining feedback on https://github.com/swiftlang/swift-syntax/pull/1816:

Improve comments for SyntaxProtocol.configuredRegions and isActive to show when "unparsed" occurs
Describe how thrown errors from build configurations are handled
Add tests for canImport(ModuleName, _version: NotAVersion)

@swift-ci please test


Fix: Syntax highlighting for various issues

To be honest this PR doesn't fully fix the whole syntax highlighting problems, because there are still a lot of more complex issues around there (e.g. #2095). But at least the simple stuff should be correct now...as far as I could test. Unfortunately I'm unsure if this has negative side effects to other previously working stuff, but this can be found out by more wide tests. ;)
Most probably the whole highlighting needs a re-work or clean-up now, since the flag controlling the start/end handling seems to be quite useless now.
 Only Emacs seems to improve the syntax highlighting there due to a different coloring, but no coloring for this scenario isn't fully wrong too. ;)
Please test this fix/workaround to further improve the current situation!

@zyedidia
Did you already had some time to have a look at this?

Yeah the syntax highlighting system needs a rework, which was in-progress (https://github.com/zyedidia/flare) but has been stalled for lack of time. At this point the rework mostly just needs language files.
Regarding this patch, what is the rationale for marking all canMatchStart/canMatchEnd as true?

Regarding this patch, what is the rationale for marking all canMatchStart/canMatchEnd as true?

While debugging with additional logs I found out that find(All)Index() will already be called with some kind of tokenized lines/strings containing every time a new start (^) and end ($) and therefore I disabled these checks to check every tokenized string and his indices again.
The result proof me somehow true, since the rules remain the same as proposed and I only exchanged true, true with start == 0, canMatchEnd for reproduction purpose:

vs

vs

vs

vs

I could show all of the examples I've copied from the bugs (I try to solve) and created by my own.
As I already proposed, there is then no sense to track these checks within these functions any longer and thus the parameters and additional conditions should be removed.

As long as it's not merged I will update the PR when I or someone else finds a new issue.
But I hope that it will be merged sometime, since it would already close 13 issue reports.

Okay, sounds good. I think this may compromise some incremental highlight performance, but it is probably worth doing to improve the highlighting since most people aren't editing huge files. Hopefully at some point I can sit down and properly implement the new syntax highlighter.


Docker container with diesel CLI

It would be cool to have an official diesel-cli container, so I can deploy an application as a docker-compose setup.
My idea is to start the database first, mount the migrations and a .env file into the diesel-cli container, execute diesel migration run, wait for the container to terminate and start the application afterwards.
This would enable painless updates of the application.

At least for me that's out of the scope of the current project. We don't have the bandwidth to maintain a docker container on top of the actual code. So I close this issue as not actionable.
Beside of that: You probably want to look into diesel_migrations::embed_migrations! which would remove the need of diesel migration run in your docker container.

Thanks for pointing out diesel_migrations::embed_migrations. This solves my problem


Puppeteer fails to launch on Windows

Steps to reproduce

Puppeteer version: 1.12.2
Platform / OS version: Windows 10 / 1809
Node.js version: v11.6.0

await puppeteer.launch()

  Error {
    code: 'UNKNOWN',
    errno: 'UNKNOWN',
    syscall: 'spawn',
    message: 'spawn UNKNOWN',
  }

Running chrome.exe manually

The application has failed to start because its side-by-side configuration is incorrect. Please see the application event log or use the command-line sxstrace.exe tool for more detail.

I'm not sure this is a Puppeteer/Chromium bug

click the GIF to zoom
Make sure to watch the whole GIF till the end.
Sometimes if I copy chrome-win manually into node_modules\puppeteer\.local-chromium\win64-624492 I get that error too. So I believe its Windows fault, just not sure what to do with such information... This occurs randomly.

If someone wonders if my SSD is broken, the answer is no.

Indeed a Windows bug. Running md5sum * will show identical sums.

If you extract it and compress it again, it will show even different sums! :O Not sure what is happening.

@meotimdihia Can you please try downloading chromium from https://download-chromium.appspot.com/ and extract it directly at .local-chromium/win64-n/chrome-win? (remember to rename the old chrome-win before)

Let keep this closed - there's nothing we can do regarding this on Puppeteer-side.
Feel free to keep discussion going though.

@szmarczak I downloaded your link and run it and the same alert appear.

@meotimdiha Did you try unpacking it on desktop?

@szmarczak my mistake, I just try to unzip and run chrome.exe, and chromium is work with no problem.

Don't know if it's related to the initial issue or not, but having the same problem (same error from chrome.exe), I realized in my case it is caused by the project folder having the case sensitive attribute enabled.
Fixed it by running fsutil.exe file setCaseSensitiveInfo . disable in the project folder, then reinstalling dependencies

I'll let you know in a few days if that works for me. Not at home ATM.

@Volune Indeed, your fix works! Thank you very much :heart:
@aslushnikov Can you reopen this issue as it can be fixed on Puppeteer side? Just run the command on the node_modules/pupeteer folder before Chromium installation.

@Volune that did the trick, thank you!
Just make sure to remove the entire node_modules folder first (or run the command inside that folder I guess). I tried only running yarn remove puppeteer, then the command, then yarn add puppeteer and it didn't work, probably because the attribute was still set on node_modules.
Would be lovely to do something with this automatically though.


AOT build fails

I get the following error during AOT build.
ERROR in ../@zxing/ngx-scanner/zxing-ngx-scanner.ts(9,2): Error during template compile of 'NgxZxingModule'
  Function calls are not supported in decorators but 'ɵmakeDecorator' was called in 'NgModule'
    'NgModule' calls 'ɵmakeDecorator'.

To the npm test the aot build should be added.

Could you share the version of the packages you're using?

#34 solved this issue, too.


BP008 may not be working as intended.

After execute bump-pydantic --diff app/ I received the following output:
 class UpscaleTaskOutput(ImageProcessTask):
     task_id: str
-    scale_factor: conint(ge=1, le=4)
+    scale_factor: Annotated

But I expect something like this:
 class UpscaleTaskOutput(ImageProcessTask):
     task_id: str
-    scale_factor: conint(ge=1, le=4)
+    scale_factor: Annotated[int, Field()]

class ImageProcessTask(BaseModel):
    samples: Optional[int] = 1
    steps: int = 1
    content_container_id: Optional[str] = None

Python: 3.11.4
bump-pydantic version: 0.8.0
Maybe I am doing something incorrect?

I don't know... 🤔
Do you have an error? Sorry the delay here!
I've tried to run bump-pydantic main.py on this:
from pydantic import BaseModel, conint

class UpscaleTaskOutput(BaseModel):
    task_id: str
    scale_factor: conint(ge=1, le=4)

And it becomes...
from pydantic import Field, BaseModel
from typing_extensions import Annotated

class UpscaleTaskOutput(BaseModel):
    task_id: str
    scale_factor: Annotated[int, Field(ge=1, le=4)]

If you have more details, I'm happy to reopen this!