December 1 Review Ticket

Palette Puzzle
When we thought about what to make for this project, we considered how. some people can mix colors together to create the perfect shade of a certain color just by sight. We wanted to test people's ability to determine how much red, green or blue was in a certain color just by looking at it. Our project ended up with three parts that are described below.
Sorting - Algorithms, Inheritance, Abstraction
Drew was responsible for this part of the project.
Two pages of our project use sorting algorithms, since it's the core of the game we're working on. All four sorting algorithms (bubble, selection, insertion and merge) are fully functional in the backend and accommodate an unlimited number of colors to sort.
Inheritance and Abstraction
Because we were asked to collect certain analytical data on each sort, we decided to use a parent class SortingAlgorithm to accommodate timing the sort, incrementing comparisons and incrementing swaps/insertions.
public class SortingAlgorithm {
    protected int swaps;
    protected int comparisons;
    protected long executionTime;

    public SortingAlgorithm() {
        this.swaps = 0;
        this.comparisons = 0;
        this.executionTime = 0;
    }
    // ... etc.
    public Integer[][] sort(HashMap<Integer, Integer[]> colorValues, int chosenColor) {
        this.swaps = 0; // this method is used to get the execution time
        this.comparisons = 0;
        long startTime = System.nanoTime();
        Integer[][] steps = performSort(colorValues, chosenColor);
        long endTime = System.nanoTime();
        executionTime = endTime - startTime;
        return steps; // we log the steps of the sorting process for one of our pages
    }

    protected Integer[][] performSort(HashMap<Integer, Integer[]> colorValues, int chosenColor) {
        // this method is overwritten by each subclass to be their specific type of sort
        return null;
    }

    protected void swap(Integer[] array, Integer i, Integer j) { // this is used by multiple that swap
        Integer temp = array[i];
        array[i] = array[j];
        array[j] = temp;
        swaps++;
    }

    protected int compare(HashMap<Integer, Integer[]> colorValues, int i, int j, int chosenColor) {
        comparisons++; // this is used in all sorting algorithm subclasses
        return Integer.compare(colorValues.get(i)[chosenColor], colorValues.get(j)[chosenColor]);
    }

Algorithms
Rather than paste the code here, see the table below for all sorting algorithms in full.

Sort Type
Link

Bubble
Click here

Selection
Click here

Insertion
Click here

Merge
Click here

We would like to highlight some usage of the parent attributes and methods in these sorting algorithms.
// bubble sort
  for (int i = 0; i < colorValues.size(); i++) {
      boolean swapped = false; // flag to track whether any swaps were made in this pass
      for (int j = 0; j < colorValues.size() - i - 1; j++) {
          if (compare(colorValues, indices[j], indices[j + 1], chosenColor) > 0) {
              swap(indices, j, j + 1);
              swapped = true;
          }
      }

// selection sort
    for (int i = 0; i < colorValues.size() - 1; i++) {
        int minIndex = i;
        for (int j = i + 1; j < colorValues.size(); j++) {
            if (compare(colorValues, indices[j], indices[minIndex], chosenColor) < 0) {
                minIndex = j;
            }
        }
        swap(indices, i, minIndex);

Implementation
At the time of writing this, we haven't been able to deploy our backend, but it works locally for use in the live demonstration. Click here for the 5000-color sorting page.
The actual Palette Puzzle sorting game was second priority, since it did not incorporate the important analysis data like the big sort did. However, because the backend works identically between the two pages, all that is missing is the remaining frontend work for this page.
Fibonacci
Haseeb was responsible for most of this portion of the project.
For our two additional fibonacci sequence algorithms, we decided to use the Golden Ratio Formula and Matrix Exponentiation. Other methods are finished in notes but not yet implemented into the backend, since these two were the first priority. Both of them are now fully implemented on the backend, each using the parent class Fibonacci to its advantage.

Fibonacci Method
Link

Golden Ratio
Click here

Matrix Exponentiation
Click here

Inheritance and Abstraction
Like the sorting algorithms, the fibonacci methods make use of an overarching parent class. It is show below:
public class Fibonacci {
    protected long executionTime;

    public Fibonacci() {
        this.executionTime = 0;
    }

    public long getExecutionTime() {
        return executionTime;
    }

    public long calculate(Integer num) {
        long startTime = System.nanoTime();
        long result = performCalculation(num);
        long endTime = System.nanoTime();
        executionTime = endTime - startTime;
        return result;
    }

    protected long performCalculation(Integer num) {
        // to be implemented by each fibonacci algorithm
        return 0;
    }
}

Once again, this allows us to time all methods in the same manner.
Implementation
Click here for the fronted site that works locally and will be universally functional after deployment.
Analysis - Calculations and Measurements
AJ was largely responsible for assisting with frontend-to-backend connections, which included formatting the sort data on the big sort simulation page.
On the big sort page, data on execution time, comparisons and swaps are collected in a table below as the sorting process is visualized. Since 5000 different colors are being sorted, we met expectations with the size of the sort.

Fibonacci timing stats from the parent class work perfectly with the currently finished methods (see image below) and, because of the use of inheritance, all future methods will continue to function.

Individual: Key Commits
Drew
The commit I wanted to highlight the most is this one. This was my initial attempt at putting all of the sorting algorithms I had created separately in a Jupyter Notebook into the Springboot repository and connecting it to an API Controller. I was very excited to discover that, aside from a minor problem with comparisons and swaps not resetting when occurring in multiple sorts, everything worked extremely well.
Aside from fully-functional and consistent sorting algorithms, which I touched on earlier, I wanted to point out some efficient use of class declarations in the API Controller page. I created an array of all of the different subclass Objects, but declared it as an array of SortingAlgorithms. If I hadn't done this, I wouldn't have been able to iterate through with the for loop below and use class methods, since using a more general declaration like Object would make the method unrecognizable.
      SortingAlgorithm[] algorithmArray = {bigBubbleSort, bigSelectionSort, bigInsertionSort, bigMergeSort};
      long[] averageTimes = {0, 0, 0, 0}; // indexes: 0 = bubble, 1 = selection, 2 = insertion, 3 = merge
      // 100 sorts
      for (int i = 0; i < 100; i++) {
          for (int j = 0; j < 4; j++) {
              algorithmArray[j].sort(data, chosenColor);
              averageTimes[j] += (algorithmArray[j].getExecutionTime() * 0.01);
          }
      }

I also added a boolean big to the SortRequest mapping object that allowed for this one API to be used for both the smaller-scale Palette Puzzle game and the large-scale demonstration. Using the big boolean, many different runs of the sorts can be used to get a more accurate average runtime for the sorts. This is implemented on the big sort page shown earlier.
Haseeb
There's two major commits I would like to highlight in lieu of this project. The first being this one, which pertains to Palette Puzzle.
function colorBoxes(){
        var totalSlots = [_0, _1, _2, _3, _4, _5, _6, _7];
        for(let i = 0; i < 8; i++){
            rgbGen();
            RGB = [`${r}`, `${g}`, `${b}`];
            console.log(RGB);
            totalSlots[i].style.backgroundColor = `rgb(${r}, ${g}, ${b})`;
        }
    }

This commit was important as it helped me clean up the code for efficiency purposes. Previously, I had super rough frontend code that was super messy, as there were a lot of things just repeated/copy-pasted. I realized I could just use recursion by putting all the slots in an array and applying changes on all of them using a for loop.
The second commit I would like to highlight is this one, which is related to the addition of the Fibonacci methods.
        public static void main(String[] args) {
            Instant timerStart = Instant.now();
            int n = 20;
            double goldenRatio = (1 + Math.sqrt(5)) / 2;
            long fibonacciNumber = calculateFibonacciWithGoldenRatio(n, goldenRatio);
            System.out.println("Fibonacci number at position " + n + ": " + fibonacciNumber);
            Instant timerStop = Instant.now();
            Duration elapsedTime = Duration.between(timerStart, timerStop);
            System.out.println("elapsed time: " + elapsedTime.toNanosPart() + " nanoseconds");
        }

        private static long calculateFibonacciWithGoldenRatio(int n, double goldenRatio) {
            double phiToN = Math.pow(goldenRatio, n);
            double negativePhiToMinusN = Math.pow(-goldenRatio, -n);
            double result = (phiToN - negativePhiToMinusN) / Math.sqrt(5);
            return Math.round(result);
        }

This code is for the first extra method I coded for the Fibonacci requirements, in which I utilized the Golden Ratio formula to calculate the specific number at the specified index of the Fibonacci Sequence. I also added a timer, which shows how long the process takes, this was implemented for the second method too.
AJ
AJ was not present on December 1 to add comments about his commits.
What's Left
There are a few things that remain to be done.
First priority is implementing the other fibonacci methods into the backend. We have methods that work, but they haven't been brought over yet. We also plan to make the frontend page a bit nicer.
We had some trouble with deployment due to issues with the backend, but we plan to have it deployed by the end of the day.
The frontend for the Palette Puzzle game itself is another priority, since it adds another layer to the sorting algorithm by explaining it step-by-step.

Everything looks close to being done. Some possible improvements could be to include more of a visual aspect to the fibonacci part of the project, if there is time (ill add more comments later)


ES7 Class Properties throws 'Unexpected token ='

Jeff Morrison's stage 0 class property initializers proposal fills the void of property composition on classes.
Currently when using:
class Person {
  firstName = 'John'; // jshint error 'Unexpected token ='
  static lastName = 'Doe';
}

console.log(new Person().firstName); // "John"
console.log(Person.lastName); // "Doe"

Any plans to support such feature? Or maybe I'm missing an option? Thanks!

It would be unwise for JSHint to commit to supporting any stage 0 proposals.

You can prevent the error by demarcating non-standard portions with an ignoreDelimiter:
class Person {
  //start-non-standard
  firstName = 'John';
  static lastName = 'Doe';
  //end-non-standard
}

.jshintrc
...
ignoreDelimiters: [
  { start: "start-non-standard", end: "end-non-standard" },
],
esnext: true
...

@rwaldron thanks!

@voronianski you're welcome!

It's up to stage 1 now: https://github.com/jeffmo/es-class-static-properties-and-fields
I know that's still not very far along, but I would love to use this without littering my code with start-non-standards in every class!

@hackel In the time since this feature request was made, we've formalized our requirements for new language features:
http://jshint.com/blog/new-lang-features/
We'll be happy to accept patches once the "class properties" proposal reaches stage 2!

Just an update, it's at stage 2 now: https://github.com/tc39/proposals. Perhaps time to re-open this issue?

Now that this proposal has reached stage 2, I have created an issue to track support within JSHint. See gh-3139.


Can't use warp plugins

After the new versions of Multiverse it seems I can't use any of my warp plugins. The error message is the same for both RB 1337 and 1.0.1. I use Multiverse-Core version 2.1-b326 and Multiverse-Portal 2.1-b295 (copied from the cmd).
The obvious wanted outcome is for me to be able to warp and warp between worlds like I used to.
-The error from the cmd is this:
16:11:02 [SEVERE] Could not pass event PLAYER_TELEPORT to Multiverse-Core
java.lang.NullPointerException
at com.onarandombox.MultiverseCore.listeners.MVPlayerListener.onPlayerTe
leport(MVPlayerListener.java:133)
at org.bukkit.plugin.java.JavaPluginLoader$9.execute(JavaPluginLoader.ja
va:321)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:58)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:339)
at org.bukkit.craftbukkit.entity.CraftPlayer.teleport(CraftPlayer.java:2
97)
at org.bukkit.craftbukkit.entity.CraftEntity.teleport(CraftEntity.java:1
56)
at cz.Plague.bukkit.PlgWarp.PlgWarpWorker.warpTo(PlgWarpWorker.java:105)
    at cz.Plague.bukkit.PlgWarp.PlgWarp.onCommand(PlgWarp.java:46)
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:40)
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:16

 at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:3

at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.

java:757)
at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:722)
    at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:715)
    at org.getspout.spout.SpoutNetServerHandler.a(SpoutNetServerHandler.java

:180)
at net.minecraft.server.Packet3Chat.a(Packet3Chat.java:33)
at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:93)
at org.getspout.spout.SpoutNetServerHandler.a(SpoutNetServerHandler.java
:550)
at net.minecraft.server.NetworkListenThread.a(SourceFile:108)
at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:527)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:425)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)
16:11:02 [SEVERE] Could not pass event PLAYER_TELEPORT to Multiverse-Portals
java.lang.NullPointerException
at com.onarandombox.MultiversePortals.utils.PortalManager.isPortal(Porta
lManager.java:42)
at com.onarandombox.MultiversePortals.PortalPlayerSession.playerDidTelep
ort(PortalPlayerSession.java:209)
at com.onarandombox.MultiversePortals.listeners.MVPPlayerListener.onPlay
erTeleport(MVPPlayerListener.java:55)
at org.bukkit.plugin.java.JavaPluginLoader$9.execute(JavaPluginLoader.ja
va:321)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:58)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:339)
at org.bukkit.craftbukkit.entity.CraftPlayer.teleport(CraftPlayer.java:2
97)
at org.bukkit.craftbukkit.entity.CraftEntity.teleport(CraftEntity.java:1
56)
at cz.Plague.bukkit.PlgWarp.PlgWarpWorker.warpTo(PlgWarpWorker.java:105)
    at cz.Plague.bukkit.PlgWarp.PlgWarp.onCommand(PlgWarp.java:46)
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:40)
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:16

 at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:3

at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.

java:757)
at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:722)
    at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:715)
    at org.getspout.spout.SpoutNetServerHandler.a(SpoutNetServerHandler.java

:180)
at net.minecraft.server.Packet3Chat.a(Packet3Chat.java:33)
at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:93)
at org.getspout.spout.SpoutNetServerHandler.a(SpoutNetServerHandler.java
:550)
at net.minecraft.server.NetworkListenThread.a(SourceFile:108)
at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:527)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:425)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)
Sorry for not finding any better to quote in the error.
I know this could just as well be a problem for the warp plugins, but when several of the warp plugins bug the same way with Multiverse I think this might be a fault on your plugin.

A. Update to 2.2 (our dev versions at ci.onarandombox.com) and see if you can. I'd imagine that the outdated version is causing issues.

Sorry but it seems it still bugs with 2.2, same error.
I even tried a server with only the plugins: PermissionEX, Chatmanager (coming with PEX), Modifyworld (coming with PEX), Multiverse-Core, Multiverse-Portal and PlgWarp (made by a bukkit moderator). These are only the most needed plugins to test this.
I have also tried with RB 1337 and all plugins in versions fit to this RB, still the same bug.

2.1 == 1337
2.2 == CB 1.0.1-R1
Make sure you have the appropreate MV version for your CB server. I won't have time to look at this one for a little bit. sorry.

Ok problem solved, sorry to bother you with a unnecessary ticket.
The new version of Multiverse thinks the setpoints for the warps  belongs to a non-existing world cause they were set before I updated Multiverse. All I had to do was to remove the warp plugin config and set up all the warp once again.

Care to post the problem configs? I'd like to get some better error checking in for the future. Thanks!

Do you mean the config for the warps? Cause the problem wasn't really your plugin, just needed to update the warps by setting them once more (and delete the old config). The config on the warp plugin is a DB file so I don't really know how to send them, sorry...
I guess I shouldn't call it a config, but it is where the setpoints are saved.


SCI KIT UFMPACK not working in python 3.6.6

dir(scikits)
Out[4]:
['builtins',
'cached',
'doc',
'file',
'loader',
'name',
'package',
'path',
'spec']
import scikits.ufmpack
Traceback (most recent call last):
File "", line 1, in
import scikits.ufmpack
ModuleNotFoundError: No module named 'scikits.ufmpack'
Getting following error in Python 3.6.6
I need to install sfepy.. as per installation document it says following packagings
Python packages required for using SfePy:
• Pyparsing,
• SciPy,
• scikit-umfpack for enabling UMFPACK solver for SciPy >= 0.14.0,
• Matplotlib for various plots, GTKAgg for live plotting via log.py,
• PyTables for storing results in HDF5 files,
• SymPy for some tests and functions,
• Mayavi for postproc.py,
• Pysparse for schroedinger.py (currently available for Python 2.7.x only),
• igakit for script/gen_iga_patch.py - simple IGA domain generator,
• petsc4py and mpi4py for running parallel examples and using parallel solvers from PETSc,
• pymetis for mesh partitioning using Metis,
• wxPython for better IPython integration.
i am stuck with scikit-ufmpack

it works for other people, please provide more details like how you installed it and what error you are seeing

Hi rgommers,
Thanks for reply.
I installed using
PIP install scikit-ufmpack
it got installed properly.but later when tried for checking some example code, it is saying
**import scikits.ufmpack
Traceback (most recent call last):
File "", line 1, in
import scikits.ufmpack
ModuleNotFoundError: No module named 'scikits.ufmpack'**
I was having Python 3.7 , i want to install sfepy as i said above , so when i was in the step of installing,clinicalgraphics, wxpython and mayavi through  Anaconda command
"conda install -c anaconda mayavi"
my python got automatically downgraded to 3.6.6
Also i attempted to install scikit-ufmpack also through anaconda command but it didnt work so i tried with "PIP install scikit-ufmpack",it installed but giving above error

Hi @monikrish2605, did you install umfpack with pip inside your conda environment?
Also note, that scikit-umfpack is only an optional dependency of sfepy - you do not need it to run it. Anyway, this is not a place to discuss sfepy installation.

yes i installed using PIP ..because "conda install -c conda-forge scikit-umfpack" this was available for only linux and mac OS

If you're on Windows, you really want a wheel for scikit-umfpack. The 0.3.2 release is source-only, hence it's trying to build from source (needs a Fortran-compiler etc., don't go there). For Python 3.6 there is a wheel available for 0.3.1, so do:
pip install scikit-umfpack=='0.3.1'

inside your conda environment.
And as @rc says, you don't really need it for SfePy so if my suggestion above still doesn't work for you then best to just skip installing this package.

Thanks @rc and @rgommers  , i will try with .whl which you mentioned above.if  that doesnot work , i will skip that as you said, but if i skip it ,what i should do when i encountered to use  solver option in that module , is there any alternate for that ?

Sorry i am new to python env(for using FEM), hence please bare with me if my question is apparently naive

what i should do when i encountered to use solver option in that module , is there any alternate for that ?

The SciPy solver that uses scikit-umfpack under the hood will still work, just slower likely. So you should not notice. If you do get an exception, it's likely a SfePy bug.

Thanks rgommers

FYI: thanks to @matthew-brett's help, the 0.3.2 wheels are now available for linux and os x.

I am not very knowledgeable in CI/build issues, especially on windows, so any help would be appreciated, see https://github.com/scikit-umfpack/scikit-umfpack-wheels/issues/2 for a background.


Switch from Java to Kotlin?

@jcgruenhage
Should we do that?

I am not that familiar with Kotlin (contrary to Java, which I am very familiar with), so I wouldn't do it... I've heard a lot of good things about people liking Kotlin though, so I might look into it. Focusing my language learning on rust though atm.

@jcgruenhage
Okay then I'll close it.
It's not so important to do that.


Make sure Zendesk is sending emails consistently and successfully to customers [waiting for Zendesk update]

In order to ensure customers receive reply mail from<EMAIL_ADDRESS>we need to get SPF and DKIM/DMARC records in GSA's DNS system which will prevent customer SMTP agents from silently dropping our mails.
To test this:
Go to https://cloud-gov.zendesk.com/agent/admin/email
Click "SPF does not include Zendesk Support"
See if it still says "This will soon be replaced by the DNS records. During the transition period you should set up both sets of records."

See also:
https://support.zendesk.com/hc/en-us/articles/203683886-SPF-Learn-More
https://support.zendesk.com/hc/en-us/articles/203663326-Digitally-signing-your-email-with-DKIM-or-DMARC
We can test that the change was made successfully here (our instance name is cloud-gov.zendesk.com):
https://support.zendesk.com/hc/en-us/articles/360000371588

There's some additional info in this 🔒support processes flow diagram as notes.

Got back to this and emailed GSA email folks about next steps.

@hillaryj will write up next steps (and create issues) and close out this story.

Closing in favor of #1127


fix: fix ci not run

We missed these CI steps for pydantic v2 changes. This fixes it. Hopefully this allows you to create a release.

@yuval9313 please review


[DirectLine] Attachment ContentUrl contains placeholder URL after uploading image

Repro Steps:

Upload image through DirectLine channel using URL:
https://directline.botframework.com/v3/directline/conversations/{CONVERSATION_ID}/upload?userId={USER_ID}

Verify bot is able to receive attachment and download file from generated URL

User receives activity from DirectLine channel containing uploaded attachment, but attachment ContentUrl contains
"https://docs.botframework.com/static/devportal/client/images/bot-framework-default-placeholder.png" instead of URL to image.

The URL of the image is only seen by the bot, but any historical view of the activities will have it replaced with a placeholder URL. Is this by design? I assumed the URLs of attachments would be visible to users as well.

@RootOfAllEval I'm not quite sure if this is by design or not. I'm looking into that and will let you know what I find.

This is by design. I'll see if I can get some more info for you.

This design is due to security.
To further explain; someone could upload an attachment with malicious content, have it echoed back to them from a URL that had microsoft.com in the URL, then copy THAT URL and share it with someone and make them think the malicious content was trustworthy because it had microsoft.com in the URL.
I am closing this as resolved, but please let us know if you have further questions.


Adds databuilder and fixes model issue discovered by test

BUG: PA Manager should be of Manager type - Closes #17
FEAT: Databuilder based on @franciscobmacedo's HfU framework - Closes #14

Also fixes some config issues in running database tests on github


Preserve Github Flavor Markdown code block language information

Take two - https://github.com/xijo/reverse_markdown/pull/40
The previous pull request wasn't technically incorrect i.e. Github did/does recognise the highlighting when a space is included before the language identifier. However, looking at the official documentation it would seem that the preferred form is not to include a space (https://help.github.com/articles/github-flavored-markdown/).
NOTE: Compared to my previous pull request I've also swapped to stream style string concatenation, for consistency with the existing code.

@Benjamin-Dobell sorry this took me so long. There is PR #43 that addresses this issue in a generic way - I'll take a look at that first and see if it covers your issue as well, alright?
Thanks for contributing anyway and again: sorry for the delay.

@Benjamin-Dobell please take a look at #44 and let me know what you think, alright?

Version 0.7.0 is released and include this feature, I'll close the PR. Thanks for your help!


Update entrypoint

Codecov Report

Merging #20 (803b1de) into main (00a3b36) will increase coverage by 0.19%.
The diff coverage is 100.00%.

:exclamation: Current head 803b1de differs from pull request most recent head 8b65747. Consider uploading reports for the commit 8b65747 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   90.35%   90.54%   +0.19%
==========================================
  Files          10       10
  Lines         197      201       +4
==========================================
+ Hits          178      182       +4
  Misses         19       19

Impacted Files
Coverage Δ

pv_site_production/app.py
92.68% <100.00%> (ø)

pv_site_production/models/cos/cos_model.py
100.00% <100.00%> (ø)

pv_site_production/models/psp.py
100.00% <100.00%> (ø)

pv_site_production/utils/config.py
95.00% <100.00%> (+0.26%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


chore: point to official sd-jwt lib release

This PR adjusts the version of sd-jwt pulled to be the official release now published to PyPI: https://pypi.org/project/sd-jwt/

@swcurran I think it would be good to get this in for 0.11.0; assuming tests pass, I think it's a pretty innocuous change and removes the only "unofficial"/git dependency we have, which should make integrating with ACA-Py from plugins or elsewhere simpler.

Before or after 0.11.0-rc0?  Does it matter?

Either way works for me!


Argument t_max in PCL misused

According to the docstring below, t_max in PCL is equivalent to update_interval in DQN.
https://github.com/chainer/chainerrl/blob/4ca100cd8f0dab5e5e333cf3bdc65fb6e6e30651/chainerrl/agents/pcl.py#L49
However, if t_max == None by default (also in the example script), line 388 (below), the update, will never be executed.
https://github.com/chainer/chainerrl/blob/4b051a4cc0e13634b9b0f521c0ad18db91019d40/chainerrl/agents/pcl.py#L388
In addition, when sampling from the replay buffer, I think that max_len should be set with another parameter, at least not with t_max unless we change the docstring.  (I also think there is no such limit on the length of episode in the original paper)
https://github.com/chainer/chainerrl/blob/4b051a4cc0e13634b9b0f521c0ad18db91019d40/chainerrl/agents/pcl.py#L284

When t_max is set to None, PCL is expected to work as the original paper does, i.e. sampling a full episode.
When t_max is set to non-None value, it is expected to work like ACER with PCL's loss function.
It seems the docstring of PCL is wrong, not only in t_max but also in other points. We should fix this. Thank you for pointing it out.


One to one messaging (private or direct thread)

Hi,
I trying make chat for my app and, you said i can use one-to-one message, i see should all the code but i don't found who i can make this.
I trying make chat one-to-one, like facebook chat. Without subject, only direct chat.
You can post a example?
Thanks!

All the backend is there the only thing that you really have to make is the front end.
If that is too much I'd suggest that you start some courses on laravel or php in general a Google search will give you something to get started.

Please also check out closed issue #29 for some additional information


How do I do associations between tables?

Is it possible do associations between tables using feather vuex as appears in https://docs.feathersjs.com/help/faq.html#how-do-i-do-associations
Note: I want to make a join between two tables

Feathers-Vuex can handle the associations by making sure the populated data from a single service call gets split out into the correct service stores, but it doesn't actually populate anything for you.  I'll be sharing a project that I built which I consider to be the simplest way to setup these relationships in a scalable and high-performance way.  I built it for my feathers-vuex projects, but it will work with any front end, so it will be a separate project.  I just need to finish the docs.
In the meantime, look into feathers-shallow-populate.  It's about to come out of deprecation.  ;)

@marshallswain any update about the separate project.

@juancampuzano hot off the press: https://feathers-graph-populate.netlify.com/

Thank you @marshallswain!


Ensure we reset vfortio state between runs.

This might be working properly now, but we should double check.

KillFortio should be handling this for us.


[container-registry] Remove references to 'Premium' SKU from Tokens and Scope Maps feature

Feature is GA and available from all SKUs.
Fix minor lint errors

#sign-off

@tejaswikolli-web
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


CLA Database Cleanup - DEV

Summary
CLA Database Cleanup - DEV
Background
Before database migration to support v1 and v2 integration, we should remove all unused CLA Groups in the DEV database.
Acceptance Criteria
The "done" criteria when this feature or problem is resolved. Such as:

Unit Tests added and running in CI
Functional Tests updated to cover feature, if applicable
Demonstrate the set of capabilities to the product team while the code is running in the STAGING environment.

References

Related to CLA Migration Script: https://app.zenhub.com/workspaces/lfx-easyclav2-5ed619832c71a855a76ef404/issues/communitybridge/easycla/1265

Any CLA Groups created in DEV before September ->

Identify CLA Groups created before September 2020
Record the CLA Group ID (project_id)
Remove CLA Group - do a query using project table, project_id, remove record.
Remove Project CLA Group Mapping (if exists) - do a query using cla_group_id, remove record(s).
Remove Repositories associated with CLA Group (if exists) - do a query using project_id, remove records.
Remove Signatures associated with CLA Group (if exists) - do a query using project_id, remove records.
Remove Audit Log Entries associated with CLA Group (if exists) - do a query using project_id, remove records.
Remove Metrics associate with CLA Group - do a query using project_id, remove records.

Consider adding this cleanup tool to the https://github.com/LF-Engineering/easycla-tools repository.

Any updates @rinkeshbhutwala ?

Closing issue due to inactivity.


[SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException

What changes were proposed in this pull request?
Handle the case when ParsedStatement subclass has a Map field but not of type Map[String, String].
How was this patch tested?
Add 2 unit tests.

Test build #106173 has started for PR 24800 at commit 4b1692b.

It is also possible to use TypeTag to fix the issue.

Can one of the admins verify this patch?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11425/
Test PASSed.

Test build #106173 has finished for PR 24800 at commit 4b1692b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106173/
Test PASSed.

+1, I think this is an effective and simple solution.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11539/
Test PASSed.

Test build #106293 has started for PR 24800 at commit 2e00113.

Test build #106293 has finished for PR 24800 at commit 2e00113.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106293/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11580/
Test PASSed.

Test build #106334 has started for PR 24800 at commit 5cb8542.

Test build #106334 has finished for PR 24800 at commit 5cb8542.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106334/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11602/
Test PASSed.

Test build #106355 has started for PR 24800 at commit 1055a22.

Thank you for updating, @jzhuge !

@dongjoon-hyun thanks for the meticulous and comprehensive reviews! Very helpful, especially to a new contributor to Spark like me.

Test build #106355 has finished for PR 24800 at commit 1055a22.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106355/
Test PASSed.

Thanks @dongjoon-hyun @rdblue @srowen  @gatorsmile @HyukjinKwon  for the review!


⚠ WSINGRESOS - OXXO has degraded performance

In 4d77cef, WSINGRESOS - OXXO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/compartido/wspagosoxxo.r) experienced degraded performance:

HTTP code: 200
Response time: 22582 ms

Resolved: WSINGRESOS - OXXO performance has improved in de6883e after 16 minutes.


fix(chat): fix "invalid JWT" error (Issue #2003)

Description:
fix "invalid JWT" error
Issues:

Issue #2003

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review

/deploy-review

/deploy-review


Update Contact details, commented out poster popup

Updated the contact details of Core members in footer and commented out the Event poster popup

Done


Implementing 3.0 Shock Effect and Duration in Calcs Tab

Not sure why all of those other merges were put in, my apologies


Support MGC requirements to configure Redis' URL for limitador

This is possibly impacting #164

@maleck13 Did you have something on this already? i.e. how would Kuadrant's Limitador server be configured to use the Elasticache instance?

No I think we just worked around it by configuring redis in limitador directly cc @R-Lawton.
I guess if installing kuadrant the question is whether we expose it from the kuadrant CR or not. My thoughts would be that we use a secret to store the connection credentials and a ref can be passed to that secret in the kuadrant cr?

We're currently pondering multiple options, as discussed in the weekly meeting (see Petr's item). @eguzki will start with #164 to address this "in its entirety", but start with this bit. So that this issue will try to have the parts of the full solution for MGC to use… hopefully - so whatever comes out of this is to be "draft", but address the problem.

A proposed solution to this problem is outline in https://github.com/Kuadrant/architecture/pull/25, it would be good if everyone could have a look at it.


Proposal: Add a function to automatically switch node version according to the project root configuration file.

What is the problem this feature will solve?
I am using Node on windows 10 and I maintain several projects with different versions of Node. I have installed NVM to control the Node version, which is convenient but not enough. It would be nice if Node versions could be switched automatically according to the project!
What is the feature you are proposing to solve the problem?
I have an idea, which I don't know if it's possible to implement, and it goes like this

When a program calls Node, this shell will first determine whether the program is in the root directory with a configuration file specifying the Node version, and if so, the corresponding version of Node will be used, otherwise the globally specified Node version will be used.

I guess this feature will help a lot of people to improve their work efficiency, and I look forward to getting attention for this requirement, tks.
What alternatives have you considered?
No response

Transferring seems to be stuck. I'm going to close this and we'll just leave it in the node main repo.


Add Caching to Inqusition REST API

The Inquisition REST API, part of the Celestial module, should implement a caching layer for improved performance.

I think using the Redis database already needed for Anatomizer for this caching as well would be a very good choice for this.
That also means that this depends on the completion of issue #82


Consider validation of incompatible request modifiers.

Some modifiers do not make sense together (e.g. IfGenerationMatch and IfGenerationNotMatch), maybe we should reject requests in the client if they are invalid, e.g.:
https://github.com/GoogleCloudPlatform/google-cloud-dotnet/blob/59cf05b52d914d687327aadbf0213b5e213ea07d/apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/GetObjectOptions.cs#L76
On the other hand, in general we prefer the server to validate things (because the server is the source of truth).
Think about it and record the decision, maybe as a ADR.

This was done in #748.


OpenROAD Code Coverage

Added Code Coverage to OpenROAD regression tests. I added a separate jenkins file called CoverageJenkinsfile that includes the pipeline stages for code coverage analysis. After this Pull requests is accepted, a separate pipeline would be created on Jenkins that is linked to this repo/branch and it would be operating the CoverageJenkinsfile.

@osamahammad21 is this PR requested by someone on the team? I don't have merge privileges and I'm not sure this kind of change would be accepted at this time due to lack of reviewer availability.

closing per discussion.

@tspyrou maybe we push this to a code_coverage branch to do some more testing before merging it into openroad?


Dark background under the Remember the Milk logo on web app

Hi,
I use the Remember the Milk web app on last stable version of Firefox and I have a bug when the shadowfox theme was installed (I just try on Windows 10 with last version of shadowfox updater) :

I should look more like this :

I try to inspect the web app to see which CSS rules do the bug but I found nothing for the moment.
Thank you.

Hi @DanielChesters, thanks for reporting this!
It should now be fixed if you want to update and give it a try.

Never mind, that fix causes some other problems.  Reverting and re-opening until a better solution is found

Should be resolved with the latest commit - let me know if not

It is fine now, thank you.


python3.exe crush after running python script with tensorflow

Hello ,
I'm setting and cloned the this project :
https://github.com/yinguobing/cnn-facial-landmark
But when i run:

python3 landmark.py

I get this bug :

when i debug , i get this :

Note : I test tensorflow with code mentionned in the readme and it work perfectly .

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform: Windows 10 x64
TensorFlow installed from (binary):
TensorFlow version (1.13)
Python version:(3.6)
CUDA/cuDNN version: 10.0/7.5
GPU model and memory: Nvidia Geforce 840m 4.00 Go

How can i solve this error ?

Can you give us some more info on the error you are facing ? Could not able to read the actual error message. Thanks!

I think that the error will gone , i missed some tensorflow files ( train.record , test.record , valid.record )  that should be generated by Tensorflow , I follow this tuto :

https://github.com/faust690226/cnn-facial-landmark-tutorial

Good to hear that. I will be closing this issue since it is resolved. Thanks!


Implement tender/bindings ABI versioning

You are wandering around the dark corners of the ELF toolchain.
You are likely to be eaten by a grue.

As outlined in https://github.com/Solo5/solo5/issues/372#issuecomment-525272670.

This change introduces an additional Solo5-owned ELF note, "ABI1", which is used to embed information about the backend target (hvt, spt, ...) and internal tender/bindings ABI version of a unikernel binary linked with the Solo5 bindings.
The internal ABI version is defined as a single uint32_t value, starting at 1. The spt and hvt tenders now refuse to load a binary whose ABI version does not match that of the tender.

This is a first draft, and the scheme we are using may yet change. I need to consult with some GCC / LLVM toolchain experts over the next days to be sure that our approach to ELF NOTEs is correct and won't break unexpectedly in the future.
@ricarkol Note that in it's current state, this will need linker script changes for libOSes not using the Solo5 linker scripts. No way around that unfortunately, as the default linker behaviour is to pack all input .note sections into a single output PT_NOTE segment.
@Kensan The Muen linker script is speculative, but I expect that you will need the built-in MFT1 in a R/W segment (:data).
@ehmry Probably doesn't concern Genode, but you may or may not want a similar scheme.
@cfcs Please take a look.

Useful references, so that I don't lose them:

A recent GNU ld manual is hard to find online, this is 2.30.52: http://docs.adacore.com/live/wave/binutils-stable/html/ld/ld.html#Scripts
A linker script using custom PHDRS: https://github.com/google/snappy-start/blob/master/elf_loader_linker_script.x
LLVM discussion of OpenBSD use of a similar scheme (one PT_NOTE output per input SHT_NOTE): https://reviews.llvm.org/D59531

(OpenBSD build is passing, stuck in pending due to Node.js crap)

I've tested this some more on an OpenBSD LLVM/clang-based system and the results (in terms of executable PHDRS) are identical to the GCC ones. In the light of that, and also because I have other changes pending that are building on top of this / touch the same parts of the code, I'm going to merge this as-is now and consult toolchain folks asynchronously over the next days.


Update FancyZones telemetry event for settings changed

Update https://github.com/microsoft/PowerToys/blob/master/src/modules/fancyzones/lib/trace.cpp#L67
to include all the current settings.

Fix available in 0.15.0 https://github.com/microsoft/PowerToys/releases


What do you think about this "actor's concurrency model"

function* pong({ payload: { pid, ...args } }) {
   const payload = `Hello ${pid}`;
   put({ type: pid, payload });
}

function* ping() {
  const self = uuid(); // some random string
  const payload = { pid: self };
  yield put({ type: 'PONG', payload  });
  const { payload: message } = yield take(pid);
  console.log(payload);
}

The interesting part here is the ability to coordinate 2 sagas with just passing actions;

perhaps related to https://github.com/redux-saga/redux-saga/issues/886 and https://github.com/redux-saga/redux-saga/issues/891

If the pattern solves your problem then its fine :) Dont have anything against it. Its just leveraging the redux protocol (actions) to coordinate various parts of the system, its exactly where redux shines.

@Andarist Thank you very much for your feedback ;)


Tidy up pombe-embl/external_data/disease/

There are now some unused files that could be moved into an "Archive"/"Old" sub-directory.

Can you remember what needs archiving here?

I've archived the files I think aren't used anymore.


Grafana after acknowladge

Hello, I need a function. I have a dashboard with an issue with Zabbix. I want the issue to not be visible on the dashboard when I tick acknowledge

Hey!
The plugin actually has this function already when querying problems (under the options tab)

Thanks @LumePart for answering this.


Fix scroll to results

Remove smooth behavior from scroll
fix #20795
https://user-images.githubusercontent.com/34872381/194920337-7f63e790-a761-4fcc-99eb-023393a9e5d8.mov

Doesn't this also fix https://github.com/microsoft/azuredatastudio/issues/20488 ?

Doesn't this also fix #20488 ?

That one is fixed by this PR https://github.com/microsoft/azuredatastudio/pull/20580


Remove vendor prefixes

I suggest using Autoprefixer to add all vendor prefixes

Hi @marcobiedermann Makes sense. Would appreciate a PR for this if possible :)


export slices of files

Even with aggressive stripping and pre-filtering, the export of a crawl will be ~64GB. (Not bad, considering the input was 54TB!)
Still, I suspect we can do an order of magnitude better. Maybe: look for the $, then grab some amount of HTML tags surrounding it.

Actually, this is probably good enough.


Autocomplete not working

I just downloaded the latest version of atom, 1.33.1, on linux and installed the logstash grammar. I created a new file saved as logstash.conf. I typed "in" and pressed ctrl-space and got no autocompletion. What am I doing wrong?
Craig

And, i am using 1.40.1 (recent version as of now).. autocomplete seesms to be not working yet with ctrl+space.
what am i missing ??

And, i am sorry guys.. the restart of the Atom fixed the issue.. Package is great and i love it... <3


Connecting to Bugsnag Timeout from Lambda functions?

There are a 1000+  register calls being per second made from a Cloud lambda function and some of them timeout on your side?
2017-10-22 14:45:35.179 (-06:00)	a5c3541f-b769-11e7-b614-9506af7ecadd	Bugsnag:  { Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at Object.exports._errnoException (util.js:1018:11)
    at exports._exceptionWithHostPort (util.js:1041:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1086:14)
  code: 'ETIMEDOUT',
  errno: 'ETIMEDOUT',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 443 }

Your status page didn't have any issues currently.

Hi @cggaurav!
I've taken a deeper look into the metrics around the time of your logged example, and per the status page everything seems normal on our end.
You mention 1000+ register calls – register() doesn't actually perform any network requests, it configures the notifier. Only notify() (manual or automatic) actually makes a request to notify.bugsnag.com. register() should only be called once per process.
How many timeouts do you get? How many events (errors) are being sent to Bugsnag?
Occasional timeouts are unavoidable (due to networking and the public internet) but should be statistically insignificant compared with the number of succesfully delivered reports.

Hey @bengourley I realized that this was an issue with Lambda not having access to the internet with my VPC settings!


Add privacy policy and terms of service

The Terms of Service is ready to be incorporated and we should go ahead with that.
The Privacy Policy is waiting on updates from IRIS.

Re-opening because the Privacy Policy still needs to be added.

Privacy Policy needs to be finalized by IRIS.

Now that https://github.com/chinleung/laravel-multilingual-routes/issues/75 has been fixed, we can take the opportunity to update to the latest release of Laravel-multilingual-routes as we're making changes for the routes related to the ToS and Privacy policy when editing for them is moved into filament.


V7R3 installation failure...

bash-5.1$ system "CRTRPGMOD MODULE(CRTFRMSTMF/crtfrmstmf) SRCSTMF('QSOURCE/crtfrmstmf.rpgl                                      e') TEXT('Create From Stream File') REPLACE(*YES) DBGVIEW(*SOURCE) TGTRLS(V7R3M0                                      ) TGTCCSID(*JOB)"
CPD0043: Keyword TGTCCSID not valid for this command.
CPF0006: Errors occurred in command.
gmake: *** [makefile:17: crtfrmstmf.rpgle] Error 255
warning: %post(bob-2.2.8-0.ppc64) scriptlet failed, exit status 2
CPD0043: Keyword TGTCCSID not valid for this command.
CPF0006: Errors occurred in command.
It looks like the V7R3 installation is using a V7R4 command.  simple fix, but I have not idea how to do it.

Turns out the prerequisites need to be updated by ensuring that PTF SI62605 is installed.  Since that's not on the groups or cumulative, it would need to be applied separately.

Hi Jim, thanks for bringing this to our attention.  We have updated the wiki to document this prerequisite on the RPG compiler.

https://github.com/IBM/ibmi-bob/wiki/Installing-IBM-i-prerequisites#ile-rpg-prerequisites


Replay block failure: 19645342

This block produces a different result. At least the receipts root is different (it might have other differences, but I could only spot that one on my phone).
Edit: 19652658 fails too, also with a receipts root difference.

I confirmed locally that block number 19652658 works too after the fix.

Ah, sorry, I didn't realize that the PR wasn't merged yet. Thanks!


Some Small Quality of Life Improvements + Rushed The Ability To Save Data in separate watcher directory

Added new options for the DiagramWatcher which enables it to save data as numpy arrays
Fixed citation in main README.md so that we differentiate from Drake
Updated some of the motion planning scene's function signatures in preparation for a simplification

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.40%. Comparing base (5935ef8) to head (57f37d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   90.22%   90.40%   +0.18%
==========================================
  Files          77       77
  Lines        2680     2732      +52
==========================================
+ Hits         2418     2470      +52
  Misses        262      262

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Switching to nlohmann_json breaks OpenEmbedded builds

After https://github.com/windytan/redsea/commit/81eea4b26b60fecbc6496fbac924ebd8816819a6, redsea can no longer be built by OpenEmbedded, because it's meson build class uses --wrap-mode nodownload.
Log data follows:
| DEBUG: Executing python function extend_recipe_sysroot
| NOTE: Direct dependencies are ['/data/oe/kirkstone/meta-openpli/recipes-multimedia/liquid-dsp/liquid-dsp.bb:do_populate_sysroot', '/data/oe/kirkstone/openembedded-core/meta/recipes-core/glibc/glibc_2.35.bb:do_populate_sysroot', '/data/oe/kirkstone/openembedded-core/meta/recipes-devtools/gcc/gcc-cross_11.4.bb:do_populate_sysroot', '/data/oe/kirkstone/openembedded-core/meta/recipes-devtools/gcc/gcc-runtime_11.4.bb:do_populate_sysroot', '/data/oe/kirkstone/openembedded-core/meta/recipes-devtools/qemu/qemu-native_6.2.0.bb:do_populate_sysroot', '/data/oe/kirkstone/openembedded-core/meta/recipes-devtools/quilt/quilt-native_0.67.bb:do_populate_sysroot', '/data/oe/kirkstone/openembedded-core/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.31.bb:do_populate_sysroot', 'virtual:native:/data/oe/kirkstone/meta-openpli/recipes-devtools/meson/meson_1.3.1.bb:do_populate_sysroot', 'virtual:native:/data/oe/kirkstone/openembedded-core/meta/recipes-core/gettext/gettext_0.21.bb:do_populate_sysroot', 'virtual:native:/data/oe/kirkstone/openembedded-core/meta/recipes-devtools/ninja/ninja_1.10.2.bb:do_populate_sysroot', 'virtual:native:/data/oe/kirkstone/openembedded-core/meta/recipes-devtools/patch/patch_2.7.6.bb:do_populate_sysroot', 'virtual:native:/data/oe/kirkstone/openembedded-core/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb:do_populate_sysroot', 'virtual:native:/data/oe/kirkstone/openembedded-core/meta/recipes-devtools/pseudo/pseudo_git.bb:do_populate_sysroot', 'virtual:native:/data/oe/kirkstone/openembedded-core/meta/recipes-devtools/python/python3_3.10.14.bb:do_populate_sysroot']
| NOTE: Installed into sysroot: []
| NOTE: Skipping as already exists in sysroot: ['liquid-dsp', 'glibc', 'gcc-cross-arm', 'gcc-runtime', 'qemu-native', 'quilt-native', 'libsndfile1', 'meson-native', 'gettext-native', 'ninja-native', 'patch-native', 'pkgconfig-native', 'pseudo-native', 'python3-native', 'xz-native', 'glib-2.0-native', 'zlib-native', 'attr-native', 'libtool-native', 'python3-installer-native', 'python3-wheel-native', 'python3-setuptools-native', 'linux-libc-headers', 'libgcc', 're2c-native', 'texinfo-dummy-native', 'gettext-minimal-native', 'openssl-native', 'libtirpc-native', 'ncurses-native', 'readline-native', 'sqlite3-native', 'libffi-native', 'bzip2-native', 'gdbm-native', 'util-linux-libuuid-native', 'libnsl2-native', 'flac', 'alsa-lib', 'libogg', 'libvorbis', 'binutils-cross-arm', 'gnu-config-native', 'mpfr-native', 'gmp-native', 'flex-native', 'libmpc-native', 'zstd-native', 'util-linux-native', 'libpcre-native', 'python3-flit-core-native', 'unzip-native', 'perl-native', 'm4-native', 'libcap-ng-native', 'libpcre2-native', 'make-native']
| DEBUG: Python function extend_recipe_sysroot finished
| DEBUG: Executing shell function do_configure
| NOTE: Executing meson ...
| DEPRECATION: "pkgconfig" entry is deprecated and should be replaced by "pkg-config"
| DEPRECATION: "pkgconfig" entry is deprecated and should be replaced by "pkg-config"
| The Meson build system
| Version: 1.3.1
| Source dir: /data/oe/kirkstone/build/tmp/work/armv7ahf-neon-oe-linux-gnueabi/redsea/gitAUTOINC+12819d0275-r0/git
| Build dir: /data/oe/kirkstone/build/tmp/work/armv7ahf-neon-oe-linux-gnueabi/redsea/gitAUTOINC+12819d0275-r0/build
| Build type: cross build
| Project name: redsea
| Project version: 1.0
| C++ compiler for the host machine: arm-oe-linux-gnueabi-g++ -march=armv7-a -mfpu=neon -mfloat-abi=hard --sysroot=/data/oe/kirkstone/build/tmp/work/armv7ahf-neon-oe-linux-gnueabi/redsea/gitAUTOINC+12819d0275-r0/recipe-sysroot (gcc 11.4.0 "arm-oe-linux-gnueabi-g++ (GCC) 11.4.0")
| C++ linker for the host machine: arm-oe-linux-gnueabi-g++ -march=armv7-a -mfpu=neon -mfloat-abi=hard --sysroot=/data/oe/kirkstone/build/tmp/work/armv7ahf-neon-oe-linux-gnueabi/redsea/gitAUTOINC+12819d0275-r0/recipe-sysroot ld.bfd 2.38.20220708
| C++ compiler for the build machine: g++ (gcc 11.4.1 "g++ (GCC) 11.4.1 20231218 (Red Hat 11.4.1-3)")
| C++ linker for the build machine: g++ ld.bfd 2.35.2-43
| Build machine cpu family: x86_64
| Build machine cpu: x86_64
| Host machine cpu family: arm
| Host machine cpu: arm
| Target machine cpu family: arm
| Target machine cpu: arm
| Configuring config.h using configuration
| Compiler for C++ supports arguments -Wno-unknown-pragmas: YES
| ../git/meson.build:29: WARNING: Consider using the built-in option for language standard version instead of using "-std=c++14".
| Found pkg-config: YES (/data/oe/kirkstone/build/tmp/work/armv7ahf-neon-oe-linux-gnueabi/redsea/gitAUTOINC+12819d0275-r0/recipe-sysroot-native/usr/bin/pkg-config) 0.29.2
| Run-time dependency sndfile found: YES 1.0.31
| Found CMake: NO
| Run-time dependency nlohmann_json found: NO (tried pkgconfig and cmake)
| Looking for a fallback subproject for the dependency nlohmann_json
|
| ../git/meson.build:42:7: ERROR: Automatic wrap-based subproject downloading is disabled
|
| A full log can be found at /data/oe/kirkstone/build/tmp/work/armv7ahf-neon-oe-linux-gnueabi/redsea/gitAUTOINC+12819d0275-r0/build/meson-logs/meson-log.txt
| WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
| ERROR: meson failed

Hi! Thank you so much for the report. Glad to hear redsea being used in a new platform. Unfortunately I'm not familiar with OpenEmbedded; can you explain to me

How does one usually install libraries like nlohmann-json onto OpenEmbedded?
Do you have to compile them yourself, normally?
Is there a packaging system?
What would be an ideal solution to this problem?

Oh, just one more question @WanWizard : you mentioned that it 'breaks the build' - does this mean there is a build pipeline for building redsea on OpenEmbedded somewhere? Can I see the whole pipeline and set of commands?

We use OpenEmbedded as OS for DVB compliant set top boxes, on which we run a custom application to provide all A/V functionality. Amongst which is support for RTL-SDR USB audio.
OpenEmbedded uses bitbake ( https://github.com/openembedded/bitbake ) to build, which is a very complex "make" system, which uses python classes to support a variety of build environment, like meson ( https://github.com/openembedded/openembedded-core/blob/kirkstone/meta/classes/meson.bbclass ), so in the actual build recipe, you only have to define you want to use meson, and bitbake does the rest: https://github.com/OpenPLi/openpli-oe-core/blob/Kirkstone/meta-openpli/recipes-multimedia/redsea/redsea.bb
The bitbake meson.bbclass hardcoded defines "--wrap-mode", I'm currently looking at ways to override it.

Managed to override the meson.bbclass and removed the "nodownload", but now got stuck with the download failing:
Looking for a fallback subproject for the dependency nlohmann_json
Downloading nlohmann_json source from https://github.com/nlohmann/json/releases/download/v3.11.2/include.zip
<urlopen error [Errno -2] Name or service not known>
WARNING: failed to download with error: could not get https://github.com/nlohmann/json/releases/download/v3.11.2/include.zip is the internet available?. Trying after a delay...
<urlopen error [Errno -2] Name or service not known>
WARNING: failed to download with error: could not get https://github.com/nlohmann/json/releases/download/v3.11.2/include.zip is the internet available?. Trying after a delay...
<urlopen error [Errno -2] Name or service not known>
WARNING: failed to download with error: could not get https://github.com/nlohmann/json/releases/download/v3.11.2/include.zip is the internet available?. Trying after a delay...
<urlopen error [Errno -2] Name or service not known>
WARNING: failed to download with error: could not get https://github.com/nlohmann/json/releases/download/v3.11.2/include.zip is the internet available?. Trying after a delay...
<urlopen error [Errno -2] Name or service not known>
WARNING: failed to download with error: could not get https://github.com/nlohmann/json/releases/download/v3.11.2/include.zip is the internet available?. Trying after a delay...
<urlopen error [Errno -2] Name or service not known>
A fallback URL could be specified using source_fallback_url key in the wrap file

../git/meson.build:42:7: ERROR: could not get https://github.com/nlohmann/json/releases/download/v3.11.2/include.zip is the internet available?

which is rubbish, as it can clone the redsea repo without problems,. and also a wget of that URL works fine.
More work to do...

Just a thought, would it be possible to install the nlohmann-json library via the same mechanism that provides the liquid and sndfile dependencies? In that case, meson would find the library and not fall back to its own http fetch.
Meson has its own http fallback here only because I provided a "wrap file" for nlhomann-json, just in case it's not available in all distros.

Always handy to have a second pair of eyes look at it. Creating the dependency at bitbake level, like sndfile, fixed the build, thanks !
Still puzzled though why python wasn't able to resolve github and download the zip though...


Add small description before TOC on index.html

it feels more welcoming. Great inspiration here:
https://users.fmrib.ox.ac.uk/~paulmc/fsleyes/userdoc/latest/index.html

I added this text:
Welcom to the user documentation for qMRLab, a quantitative MR image analysis open-source software.
The modularity of the implementation makes it easy to add any additional modules and we encourage everyone to contribute their favorite recipe for qMR!
You can either read the Getting started section or search for the desired section.
Is it ok? @jcohenadad

pls replace with:
Welcome to qMRLab, a software for quantitative MR image analysis. You can either read the Getting started [MAKE IT A LINK] or search for the specific qMR section.
thanks

Done! It's not visible in the documentation because redthedocs is not reponding when trying to build a documentation. But the description is in the document and ready to be transformed into a html file.

@gab-berest is read the docs working now?

@ileppe can you please add us to readthedocs with Agah also. currently you are the only owner and we cannot build:

ok, pls send me an e-mail with your readthedocs usernames

@ileppe it's tanguyduval


Add a "Unit Testing" guide to the Common Use Cases

🚀 Feature
It would be great if we could create a set of tools + documentation for unit-testing a LightningModule. Unit-testing is something that a lot of researchers don't really do, and so if we can make this easy for folks I think that'd be a big win for the community.
One example of how this is currently difficult -- I'd like to be able to do is to unit-test LightningModule.training_step with something like:
loss = module.training_step(...)
assert loss_is_correct(...)
assert right_things_were_logged(...)

but right now it's unclear how to do this -- it's not clear how to implement right_things_were_logged without having to mock a bunch of Lightning internals that I'm not comfortable with, and even naively calling module.training_step(...) can fail because of https://github.com/PyTorchLightning/pytorch-lightning/issues/8509#issuecomment-926209172.
I assume this is already possible somehow in Lightning (since Lightning itself looks like it's extensively unit-tested), but I think having a dedicated user guide would be suer helpful.

Regarding the "right_things_were_logged", I recommend you don't try to test the self.log implementation (that's on us!) and instead test the inputs given. An example:
from unittest import mock

import torch

from pytorch_lightning import LightningModule

class MyModel(LightningModule):
    def training_step(self, batch, batch_idx):
        loss = sum(batch)
        self.log("loss", loss)
        return loss

model = MyModel()
x = torch.tensor([1,2,3])

with mock.patch.object(model, "log") as log_mock:
    loss = model.training_step(x, 0)

assert loss == 6
log_mock.assert_called_once_with("loss", 6)

Dear @alanhdu,
Would you be willing to make a PR with those additions ?
Best,
T.C

@tchaton
I'm not sure I'm qualified! I don't know too much about the Lightning's design and what the appropriate ways to unit-test the different hooks are.
@carmocca

Regarding the "right_things_were_logged", I recommend you don't try to test the self.log implementation (that's on us!) and instead test the inputs given. An example:

Yeah, this makes a lot of sense to me, and for log I agree that a simple mock patch should work well.


class path for running text example

I have struggled for several hours now to get the text example to run. No matter what I do with the class path, I can not get it to find the classes required. Would it be possible to add a couple of lines to say how it is normally run e.g. is the library built and installed, or should the example point at it in its target dirctory. I am not sure whether there is a mistake in one of the pom.xml fles or maybe the build sequence I am using is not matching the authors expectation. It is also not clear to me if I need the library signed if I am just running this on  my local machine.

We update Readme. We hope that instruction will help you.


Show closed bounties as closed on projects page

Describe the bug
Although there is an automation in place in the _data folder, it does not seem to tell the website visitor about what bounties have been closed.
To Reproduce
As an example, look at the Mitiq project page, https://unitaryhack.dev/projects/mitiq/, where the test issue, https://github.com/unitaryfund/mitiq/issues/1298, was closed by another test PR, which contained [unitaryhack] in the PR title and that has been flagged with the label unitaryhack-accepted, https://github.com/unitaryfund/mitiq/pull/1317.
Cc @crazy4pi314.

This could be addressed partly using the solution used for the bounties page, cfr. https://github.com/unitaryfund/unitaryhackdev/commit/29ad3ce5fe608990a202327724aa2605be11869b


change cfg macros to remove redundancy

created #42 to deal with the runtime errors, will merge this for now


Multiple GraphQL Files and Relay

Premise:

Ent generates ent.graphql with definitions derived from schema
I want to add another root query
Since ent.graphql's file is not supposed to be edited, create new schema.graphql file with extend type Query { new_root_query }
Relay's compiler does not support multiple schema files

Problem:

Since relay compiler does not support multiple schema file, generate one schema file by concatenating ent.graphql and schema.graphql
The combined file has both type Query { ... } and extend type Query { ... } declarations
Now using new_root_query in any graphql query will instruct relay to generate a client side query. The query using new_root_query  will never result in a network call

This is also part relay compiler issue. But IMO it's also because ent's design forcing to extend Query type.

Hello @sanketplus, we already facing the same case as you when we develop our services.
We write a small script to combine those files into a single schema and then put it in the frontend directory for Relay to use. The script basically uses @graphql-tools/merge to combine files.
However, you can do it with a more simple script. Let's take a directory with 3 files: schema/foo.gql, schema/bar.gql and schema/ent.gql. Then you can combine it with the cat command.
cat schema/*.gql > ui.gql

Please note each file should have an EOF character. (\n). ;)
If you need more help, please let me know. I'm happy to support you.

Thanks @giautm for the tip to merge files and pointing the small EOF gotcha :D Does the  @graphql-tools/merge also combine/merge the extended definitions? Ie: type Query and extend type Qurey gets merged into one? Because that issue persisted even after concatenating the files, and it also breaks the whole app.

Which version of Relay are you using? Relay able to handle the extend keyword without any error. Can you share the error you have?

Relay version: 14.1
There's no issue with merging. But I think it's a special case when merging type Query?
The query:
const GetDevices = graphql`
  query DashboardGetDevicesQuery {
    devices {
    ...

The query def where the devices root field is now in extend type Query instead of type Query which generates this diff in the generated relay file (it changes from the concreteRequest to ClientRequest) which results into no network call being made. So likely a bug for relay-compiler? (or I do not understand the schematics enough behind the extended types and how relay is supposed to work)
- import { ConcreteRequest, Query } from 'relay-runtime';
+ import { ClientRequest, ClientQuery } from 'relay-runtime';

Anyway, I am trying the merge lib as you suggested. Will update back soon :)

  schema: './schema.graphql',
  schemaExtensions: ['./src/schema'],

@sanketplus: please double check the relay.config.js, do you have the schemaExtensions here? It's the option to let relay known the type is local.

tried that too @giautm but the afaik the fact is that the extend type Query is not local? Relay may be mistaking any extend type as local but extending Query should not be?

Also the module does the trick, ie: merges the type and extended type defs. leaving the script here for future ref :)
#!/usr/bin/env node

const { loadFilesSync } = require('@graphql-tools/load-files')
const { mergeTypeDefs } = require('@graphql-tools/merge')
const { print } = require('graphql')
const fs = require('fs')

const loadedFiles = loadFilesSync(`${__dirname}/*.graphql`)
const typeDefs = mergeTypeDefs(loadedFiles)
const printedTypeDefs = print(typeDefs)
fs.writeFileSync('joined.graphql', printedTypeDefs)

#thanks @giautm a ton for a pointer to the library :)


An error occurred while installing libv8-node (<IP_ADDRESS>), and Bundler cannot continue.

C:\git\dzikrisyairozi.github.io>bundle install
Fetching gem metadata from https://rubygems.org/........
Resolving dependencies...
Installing libv8-node <IP_ADDRESS> with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
current directory:
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/libv8-node-<IP_ADDRESS>/ext/libv8-node
C:/Ruby32-x64/bin/ruby.exe extconf.rb
creating Makefile
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/libv8-node-<IP_ADDRESS>/ext/libv8-node/builder.rb:12:in
build_libv8!': failed to download node 18.16.0 (Libv8::Node::BuilderError) from C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/libv8-node-<IP_ADDRESS>/ext/libv8-node/location.rb:30:in        install!'
from extconf.rb:15:in `'
==== in
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/libv8-node-<IP_ADDRESS>/ext/libv8-node
==== running
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/libv8-node-<IP_ADDRESS>/libexec/download-node
extconf failed, exit code 1
Gem files will remain installed in
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/libv8-node-<IP_ADDRESS> for inspection.
Results logged to
C:/Ruby32-x64/lib/ruby/gems/3.2.0/extensions/x64-mingw-ucrt/3.2.0/libv8-node-<IP_ADDRESS>/gem_make.out
C:/Ruby32-x64/lib/ruby/site_ruby/3.2.0/rubygems/ext/builder.rb:119:in run' C:/Ruby32-x64/lib/ruby/site_ruby/3.2.0/rubygems/ext/ext_conf_builder.rb:28:in build'
C:/Ruby32-x64/lib/ruby/site_ruby/3.2.0/rubygems/ext/builder.rb:187:in
build_extension' C:/Ruby32-x64/lib/ruby/site_ruby/3.2.0/rubygems/ext/builder.rb:221:in block
in build_extensions'
C:/Ruby32-x64/lib/ruby/site_ruby/3.2.0/rubygems/ext/builder.rb:218:in each' C:/Ruby32-x64/lib/ruby/site_ruby/3.2.0/rubygems/ext/builder.rb:218:in build_extensions'
C:/Ruby32-x64/lib/ruby/site_ruby/3.2.0/rubygems/installer.rb:846:in
build_extensions' C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/rubygems_gem_installer.rb:72:in   build_extensions'
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/rubygems_gem_installer.rb:28:in
install' C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/source/rubygems.rb:202:in install'
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/installer/gem_installer.rb:54:in
install' C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/installer/gem_installer.rb:16:in install_from_spec'
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/installer/parallel_installer.rb:156:in
do_install' C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/installer/parallel_installer.rb:147:in block in worker_pool'
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/worker.rb:62:in
apply_func' C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/worker.rb:57:in block in process_queue'
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/worker.rb:54:in
loop' C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/worker.rb:54:in process_queue'
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.18/lib/bundler/worker.rb:90:in
`block (2 levels) in create_threads'
An error occurred while installing libv8-node (<IP_ADDRESS>), and Bundler cannot
continue.
In Gemfile:
mini_racer was resolved to 0.8.0, which depends on
libv8-node
found this error while doing bundle install

Any idea?

How to solve it?

How to solve it?

Got it, we need comment mini-racer in gemfile, and run bundler install.


Add codespell config, action + fixed typos

Saw opentelemetry-go use codespell, checked out opentelemetry - saw that this repo doesn't use it.

@svrnm @chalin what are your thoughts and feels here?

Thanks for your PR @yarikoptic !

@svrnm @chalin what are your thoughts and feels here?

Fun fact: I was trying out misspell the other day, since the java repo is using it, I was not aware that go has yet another tool ;-)
On this PR: First of all I would think that we should separate the content changes from the tooling changes. @yarikoptic: can you put everything which touches files in content/en/docs/... into a new PR and remove it from this one, so we can take in those changes while having the discussion on the tooling.
On the tooling:
We have some setup for cSpell in place already, there is also some stuff for textlint I added additionally to make sure certain things are written in the right way (open source without a hyphen, OpenTelemetry, K8s, gRPC, etc.), so we should be careful by adding yet another tool in that domain. Saying that, I personally have no issue to use something better, so if codespell can do all of that + give us easy PR checks for spelling (i.e. by copying that from the go repo) I am in.
Finally, I want to hear @chalin's point of view, since he has the best overview and insights on the infra.

@yarikoptic: would you be open to give the cspell-action as an alternative a try?

Unfortunately not - but feel welcome to just close this PR in favor of some other.  Just let me know final verdict/instructions

As discussed during the SIG call we have agreed that we don't want to add a spell checking github action right now, because it imposes more requirements to contributors to satisfy and we want to keep the bar low for people to contribute. What would be great is some tooling that we can use post-merge or on a regular basis to scan the repo for spelling issues and fix them.
Apologies for the back-and-forth @yarikoptic

What would be great is some tooling that we can use post-merge or on a regular basis to scan the repo for spelling issues and fix them.

FWIW: sounds like a suggested codespell action just ran on cron on main instead of PRs ;-)


[WIP] analytics.js addition

Work in progress for adding an analytics singleton that has track & bucket calls abstracted out of needing to know the analytics system (by sniffing for globals).
Also should have an enable / disable flag for sending all calls to $.noop so that 100%'s are a simple true / false change instead of ripping out code.

Closing as dupe of goals.js


Show number of golds, silvers, bronzes

Optionally tie them to the path they came from - I am not sure that this is currently possible without reading every single DC?

I think this is infeasible. I think we'd probably check your charsheet for how many badges you have and then traverse path leaderboards until they're all accounted for.

Going to close until someone can come up with a smarter way of doing this


Synthesis Table shows essentia requirements even with no target

As of <IP_ADDRESS>, the Synthesis Table shows essentia requirements even if there is no target inserted. It seems to be using the formula for cobalt ingots here. This didn't occur in previous versions, so it must be a regression introduced by some Minecraft changes since.

Fixed in 1.0-rc1.


Show currency symbol instead of currency code in installments

Greetings, again. This is more of a feature request than an issue, but one of our customers is requiring us to display the currency symbol instead of the currency code in the installments (for example, "R$" instead of "BRL"), and I'm not finding the exact spot to change that.

Hi LemosT,
Sorry for the late answer. The currency symbol is inserted here: https://github.com/Adyen/magento/blob/master/app/code/community/Adyen/Payment/Helper/Installments.php#L238
Regards,
Rik
Adyen

Hi LemosT,
To get the symbol you can do:
$currenctySymbol = Mage::app()->getLocale()->currency($currency)->getSymbol();
after the line $currency = $quote->getQuoteCurrencyCode();
Then change
$result[(string)$i] = $i."x ".$currency." ".number_format($partial_amount,2);
To:
$result[(string)$i] = $i."x ".$currenctySymbol . number_format($partial_amount,2);
Regards,
Rik
Adyen

Worked like a charm. Thanks a bunch.


[UI] Change icon for going to Etherscan / wallet

Currently the icon to go to etherscan / block explorer / wallet looks like you can share a link.
Instead would be better to potentially show an icon of a chain.

I've changed it to cube


Inspector: Fix texture preview in WebGPU

See https://forum.babylonjs.com/t/texture-preview-does-not-work-in-the-latest-webgpu-playground/53729

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

I agree with your changes, but it was working in my testing... Let me have a look!

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15626/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15626/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15626/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15626/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15626/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15626/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15626/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15626/merge#BCU1XR#0

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15626/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15626/merge/testResults/webgl2playwright/index.html


Update MSAL to latest version

1.1.0

Appears to be a dupe of https://github.com/Azure/azure-sdk-for-java/issues/6175


AzureDevOps Invalid argument value. Parameter name:A description for a pull request must not be longer than 4000 characters.

Maybe related with https://github.com/dependabot/dependabot-core/pull/2349
Using:
FROM dependabot/dependabot-core:0.125.2
gem 'dependabot-omnibus', '~> 0.125.2'
Package manager/ecosystem
javascript
Manifest contents prior to update
package.json
{
  "name": "azure-devops-bug",
  "version": "0.1.0",
  "private": true,
  "engines": {
    "node": "^12.13 || ^14.15",
    "yarn": "^1.15.2"
  },
  "license": "UNLICENSED",
  "dependencies": {
    "history": "^4.10.1"
  },
  "scripts": {
    "build": "yarn lint:ts && yarn build:ts",
    "build:ts": "react-scripts build"
  }
}

Updated dependency
https://www.npmjs.com/package/history
What you expected to see, versus what you actually saw
Error already fixed/covered in code, but still failing:
{"$id"=>"1", "innerException"=>nil, "message"=>"Invalid argument value.\r\nParameter name: A description for a pull request must not be longer than 4000 characters.", "typeName"=>"Microsoft.TeamFoundation.SourceControl.WebServer.InvalidArgumentValueException, Microsoft.TeamFoundation.SourceControl.WebServer", "typeKey"=>"InvalidArgumentValueException", "errorCode"=>0, "eventId"=>0}

Images of the diff or a link to the PR, issue or logs

Thanks, it is indeed related to #2349. It's a little confusing that the GitHub UI shows that PR as merged, but the commits were actually part of a different PR but where reverted in that same branch, so those changes never actually made it into the codebase.
I've opened up https://github.com/dependabot/dependabot-core/pull/2752 which I think should fix this, but I'll need a bit of time to add test coverage etc for it to verify this actually works.

thx @jurre , let's enjoy the update! :D

This should have been resolved by #2752

Pretty late to the party, but this issue doesn't seem to be resolve just yet.
While trying to update CommunityToolkit.Mvvm (https://github.com/CommunityToolkit/dotnet/releases) from 8.2.0 to 8.2.1,
I get the following error and the PR doesn't get created.