Fix typos in tutorials

Description
Minor fixes, mostly typos
Types of changes

[ ] Bugfix
[ ] New feature
[ ] Refactor / Code style update (no logical changes)
[ ] Build / CI changes
[ ] Documentation Update
[x] Other (explain)

Does this address any currently open issues?

Thanks Tommy! Could you also update the RST files under doc/? These are used to built the website.
Edit: and can you fix the same typos in variable names in flygym/mujoco/examples if applicable?

Done!


filter for fontconfig warnings in ImageFormatter

(Original issue 1188 created by radiation on 2016-01-07T13:01:35.716532+00:00)
In my Mac, using fc-list gives me
Fontconfig warning: ignoring UTF-8: not a valid region tag
at the very beginning.
With the current implementation of _get_nix_font_path in img.py, this fails. As there seems to be no flag in fc-list that disables warnings, add a filter that checks for this.

(Original comment by birkenfeld on 2016-02-02T10:28:49.984980+00:00)
Fixed image formatter font searching on Macs (closes #1188)
→ <<cset 0bd6ffbb80bf>>


0.955 (Added Chinese Simplified localization)

Based on 0.955(#139), added Chinese Simplified localization
基于0.955(#139) 添加kp_Liberation简体中文翻译

Conflicting with 0.96.
As talked about in the chat: Please always use the actual dev version for contributions :)
Looking forward for the 0.96 pull from your side and many thanks for the localization. It's great.


schedule: add more dimension for filter metrics (#1746)

What problem does this PR solve?
cherry-pick #1746 to release-3.0
What is changed and how it works?
This PR adds a new dimension named ActOn for each filter to indicate that each scheduler or checker is affected by the kind of the filter.
Also this PR removes two unused filters: disconnectFilter and rejectLeaderFilter
Check List
Tests

Unit test

Related changes

Need to update the tidb-ansible repository
Need to be included in the release notes

/run-all-tests


Restart default corsair rainbow idle?

After setting this up and testing it (which works well) I wanted to switch back occasionally to the 'default idle rainbow' that the lighting node pro used before being controlled. Any idea how to do that? I tried resetting the usb interface, rebooting, and fully powering down. No luck yet.

I went ahead and worked up four variants of 'rainbow' animations to make what I wanted to do work, in the animations.js:
animations.txt
Rainbow cycles through colors in large steps
Rainbow2 cycles through colors in small steps
Rainbow3 and Rainbow4 support variable brightness and step size, and by default Rainbow4 is 1/5 max brightness.
If you do find a way to re-activate the 'default' passive color cycling, that would be cool to do too.

I do know how to do it, but it's a bit odd.

add a process.exit(0); between lines 53 and 54 here

https://github.com/benburkhart1/lighting-node-pro/blob/master/index.js#L53

Set a color/animation

Control+C out of it

after 1 minute or so it will default to the original rainbow wave pattern and won't require a running process to keep it active. It's hacky, and I have planned to run wireshark and see what it does via USB when it does the rainbow pattern, but that's the easiest route I know to it currently.

Interesting! Ok, thank you. I think i'll be able to use that so that I can tone down my rgb overnight but then have it come back on in the morning. Thank for the help!


Update using-the-windows-mixed-reality-simulator.md

OPS Build status updates of commit 75548b4:
:clock10: Preparing: average preparing time is 50 sec(s)

OPS Build status updates of commit 75548b4:
:clock10: Incremental building: average incremental building time is 26 sec(s)

OPS Build status updates of commit 75548b4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/using-the-windows-mixed-reality-simulator.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Navigating to property changes parent properties

When accessing the navigation property of an entity that I've used AutoFixture to put into a test method, it changes non-navigation properties of the parent type that are related to the navigation property I accessed.
For example, if I had these two related entities, not related by convention but rather by attributes:
public class First
{
    [Key]
    public int FirstKey { get; set; }

    public int SecondKey { get; set; }

    public virtual Second Second { get; set; }

    public string SomeOtherProperty { get; set; }
}

public class Second
{
    [Key]
    public int SecondKey { get; set; }

    ... other stuff
}

Then passing these through the ModelMetadataGenerator.LoadFromCoadFirstContext(...) and customizing my fixture...
When I put it in a test, like so...
// Using NUnit 3 and NSubstitute
[Test]
[AutoNSubstituteData] //This is my custom class that adds the AutoFixture.NSubstitute customization
public void Test(First first)
{
    var firstKey = first.FirstKey; //Returns an auto-generated number, say 10
    var someOtherProperty = first.SomeOtherProperty; //Returns an auto-generated string, say "abc123"
    var firstKeysSecondKey = first.SecondKey; //Returns, say, 105

    var secondKey = first.Second.SecondKey; //Returns, say, 75
    var afterAccessingNavigation = first.FirstKey; //Now returns 75
    var anotherProperty = first.SomeOtherProperty; //Returns a different auto-generated string, say "123abc"
}

If that didn't make sense, basically when accessing navigation properties that have a relationship back to the accessing member, that member is re-generated completely.
Of course, this keeps the "integrity" of the property constraints, which is probably desired in most cases.
However, I might expect first.SecondKey to remain 105, and the first.Second.SecondKey to also be generated as 105, and SomeOtherProperty to not change from the original value.
Scouring through the metadata that ModelMetadataGenerator created, I found it made these contraints:
OneToManyPropertyConstraint<Second,First>
  PropInfo = ICollection<First>
  _inverse = Second

The workaround is to access navigation properties up-front/immediately, as in make a first.Second.SecondKey call first, and then reference/use/expect/test against/etc the other variables as they will no longer change.

It makes sense, thanks for the detailed explanation. I believe what's happening is the initial key you're getting was generated by the fixture, then is overwritten when our constraints hooks in on the navigation property. I have a fix in mind, just copying the key in the other direction, since the navigation properties key can't have been accessed yet.
I'd be happy to look at a pull request if you have time, but it shouldn't take me too long to get this fixed otherwise.

Hi! Awesome, thanks for the response. Unfortunately I've not got the additional time right now to create the solution and PR. For now I'm doing my work around by calling up-front the navigation properties that I'm expecting to use later.

@brazilianldsjaguar Sorry for the long delay. I added some unit tests to capture this behavior, but it's not occuring:
https://github.com/dbroudy/LazyEntityGraph/blob/5f462c04c6d4c0992b36fd4384ed9360e3575072/src/LazyEntityGraph.EntityFramework.Tests/EndToEndTests.cs#L44
I've seen it in the debugger, but it might just be some observer effect in the debugger accessing properties differently.
Would you mind checking out version 2.3.0 and see if this is still occurring?


[BUG] what's the difference between floor and trunc?

Both functions do the same thing on x86 as far as I can see

did you get my mail answer ?

did you get my mail answer ?

I don't believe I did.

so, trunc is a truncature it removes the fractional part and is equal to floor if x >=0
floor is the greatest integral less or equal to x
trunc(-1.5) == -1 floor((-1.5)==-2
ceil must be obvious now?!

Ok - so trunc is round to zero  and floor is round to lower, gotcha.
Then this is wrong, right? https://github.com/jfalcou/eve/blob/d667de375b05ed9a8b0bbb2c79f8dd6f86f3d242/include/eve/module/real/core/function/regular/simd/x86/floor.hpp#L26
And it should be '_MM_FROUND_TO_NEG_INF'?

you're right


Feature request-Dog vs Cat Classification using Transfer Learning

I would like to propose the addition of a Dog vs Cat Image Classification System utilizing Transfer Learning to the project. This feature demonstrates the efficient reuse of pre-trained models for image classification tasks, helping contributors and users explore transfer learning concepts in deep learning with Python.
please assign this to me.

I have already created an advanced project on this topic Cat vs Dog Image classification using Transfer Learning algorithm. Please assign me this issue and i promise to deliver an exceptional and efficient ML model for the same . My test accuracy for the model has come around 97% without tested evidence of no overfitting . My model feature demonstrates the efficient reuse of pre-trained models for image classification tasks as well

I m working on it.

@UppuluriKalyani I have completed this one .As I had received a mail from github regarding this project .Kindly confirm it once.


sqlite order error.hope to fix this bug

Information

v1.6
SQLite
Windows

Describe the Problem
A clear and concise description of what the problem is.
Detail Code
ORDER did not work
  $data = db()->select('log','*',[             "ORDER" => [                 'id'=>'desc'             ],             'LIMIT' => [$start, $pageSize]         ]);

You should use DESC not desc.
[
    "ORDER" => ['id' => 'DESC'],
    "LIMIT" => [$start, $pageSize]
]

got it
it does work .thanks very much
倚楼听风雨，淡看江湖路
On 5/31/2021 21:34，Angel @.***> wrote：
You should use DESC not desc.
[
"ORDER" => ['id' => 'DESC'],
"LIMIT" => [$start, $pageSize]
]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Remaining time smart water control

Hello, is it possible to add state with remaining time for the smart water control? Like it is in the smartgarden garden adapter for IOBroker?

I would also be very much interested in that. In addition, I would like to somehow grab the information how much time it will take until the scheduled watering will start, if not planned to be skipped?


Bump for an official release with CDN_VERSION feature

Figured this may cause the next release :D
Great stuff btw! Works like a charm!

If anyone needs this I'm using this in my requirements.txt in the meantime:
git+git://github.com/paylogic/flask-cdn@5b6d7180ee96acfb807adc77e1ca3e578abf6610#flask-cdn


Show GIT SHA from Commit

Is this possible? Also would be nice to right click copy the sha of the commit

Yeah this is possible. I'll look into adding this on the next release. thanks for the feedback.

happy to help. will look into the code.

I would love to get this!

Yes, I would also need this.

I'd like to see the git SHA so that I could copy/paste it into other tools to view the content of the commit. Thanks.

I like this idea. Added to the backlog.

Very good feature!

I think you can mark this as closed (with PR #12). Great addition!


Add SES Session Token again to Symfony Mailer

https://github.com/symfony/symfony/pull/42982 was merged into 5.4 of Symfony (still waiting to be merged into 6.0) which adds support for the temporary credentials of AWS.
Because in the ses section of the Laravel mail-config the session_token is named token we need to rename the config key while passing the options to the SES-Factory.
Another option would be to add this to the upgrade guide that the config entry needs to be renamed.
The SesFactory only respects the session_token and region option right now therefor I would recommend renaming the token to session_token in the config.
@driesvints what is your opinion on that?

And I don't know why the tests are failing 😅😂

@Jubeki try rebasing with master and they'll pass again.

@Jubeki let's keep the rename to avoid the breaking change

@Jubeki ow sorry, I should have first rebased the symfony mailer PR and you should have rebased with that 🤦♂
I've just merged master into symfony-mailer. Can you send this in anew? Sorry for the mess.

Yeah I will do that


Install extension with HTTP Proxy with Basic authentification not working

Hello,
trying to use proxy settings with basic authentification http://user1:mypa$$1@proxy1.company.com:3128 results in errors .
Looking into dev tools I see entries similar to this one:
connect EAFNOSUPPORT <IP_ADDRESS>:3128 - Local (undefined:undefined): Error: connect EAFNOSUPPORT <IP_ADDRESS>:3128 - Local (undefined:undefined)
    at Object.exports._errnoException (util.js:837:11)
    at exports._exceptionWithHostPort (util.js:860:20)
    at connect (net.js:838:14)
    at net.js:981:7
    at GetAddrInfoReqWrap.asyncCallback [as callback] (dns.js:62:16)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:81:10)e.onUnexpectedError @ /C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:113
/C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:27 WARNING: Promise with no error callback:7

other programs that use http_proxy/https_proxy environment variables work with the current env settings(ex curl).
Does someone have a clue?

What do you get if you run node and in its interactive prompt run require('url').parse('YOUR PROXY URL')?
Namely, do the host and auth parameters look OK to you?

I have node 4.3.1 in windows 7 with vs code 10.10 and I get :
Url {
  protocol: 'http:',
  slashes: true,
  auth: 'user1:pa$$1',
  host: 'proxyhost.company.com:3128',
  port: '3128',
  hostname: 'proxyhost.company.com',
  hash: null,
  search: null,
  query: null,
  pathname: '/',
  path: '/',
  href: 'http://user1:pa%24%241@proxyhost.company.com:3128/' }

I have
Also running with code 10,08 same problem .

Is there any functionality that seems broken? Can you for example install extensions?

That is where I get the error , trying to install an extension , in the autocomplete  listing.
I also have multiple network interfaces from vagrant and OpenVPN . I have no ideea where to start looking at.
I also  have another funky network related application:  http://widecap.com/ , It can may any application proxyfiable even if it doesn't support poroxying .I use it for apps that don't support proxying.

The error code EAFNOSUPPORT is what gets me worried. There's something about your system that doesn't let Code talk to <IP_ADDRESS>:3128, which looks like a decently normal IPv4 address to me.

Ns lookup on the proxy host gives me <IP_ADDRESS>.
I tried again with widecap software and the error I get is :
connect EAFNOSUPPORT **<IP_ADDRESS>:443** - Local (undefined:undefined): Error: connect EAFNOSUPPORT <IP_ADDRESS>:443 - Local (undefined:undefined)
    at Object.exports._errnoException (util.js:837:11)
    at exports._exceptionWithHostPort (util.js:860:20)
    at connect (net.js:838:14)
    at net.js:981:7
    at GetAddrInfoReqWrap.asyncCallback [as callback] (dns.js:62:16)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:81:10)

Which is gives me some wierd IP address <IP_ADDRESS>:443.
I also have :"http.proxyStrictSSL": false in vscode user settings

This is really strange.
Can you run this simple NodeJS script by putting in script.js and running node script.js from the Command Prompt?
http.get('http://www.google.com/index.html', (res) => {
  console.log(`Got response: ${res.statusCode}`);
  // consume response body
  res.resume();
}).on('error', (e) => {
  console.log(`Got error: ${e.message}`);
});

What do you get from it?

node doesn't seam to use proxy settings from environment variables. I get:
c:\PRJ\Temp>node script.js
Got error: getaddrinfo EAI_AGAIN www.google.com:80

EAI_AGAIN is also not an error related to proxying... Try that snippet again later.

nslookup command doesn't work at all also
C:\Users\myuser>nslookup google.com
Server:  internalhost.company.com
Address:  <IP_ADDRESS>

*** internalhost.company.com can't find google.com: Server failed

Other programs after I set them to use proxy they work also solving dns queries through proxies.
Can this be a issue with vscode ?

Not sure, since Code appears to try to reach your proxy <IP_ADDRESS>:3128 but fails in doing so. Something is definitely up.
Can you try the Atom editor, which also has a proxy setting?

Hello, sorry for the late reply,
After Atom testing I got  the same behavior  I think:

Fetching featured packages failed.Hide output…
tunneling socket could not be established, cause=getaddrinfo ENOTFOUND

I also urlencoded the password and @ symbol  for passwords.
There is no error in the Dev tools console (unlike Vscode).
I am not really sure if I placed the settings in the right config  file location.
Setting http-proxy strict-ssl in the http  the ~\.atom\.apm\.apmrc seams to resset to default almost empty file after I restart atom.
I copyied  .apmrc up one level since I have read somewhere that there it should be , so I have ~\.atom\.apmrc. and the settings seam to stay there and the error (first image) is shown.
Deleting the proxy configuration from ~\.atom\.apmrc gives me a different error shown bellow:

Fetching featured packages failed.Hide output…
tunneling socket could not be established, cause=connect EAFNOSUPPORT

So a different error message meaning that proxy setting is somehow taken into account.
Do you have any suggestions on what to try next

I am really not sure. Seems like a bug for nodejs/node, those guys would be able to help you out. Just describe what you described here.

Hello, sorry for commenting on a closed issue. I just want to try an extra scenario.
It is most probably related to : https://github.com/nodejs/node/issues/1490 , To also tunnel DNS requests through proxy.
Can I store dc.services.visualstudio.com and vortex.data.microsoft.com
in the config next to the proxy settings somehow ,similar co etc/hosts , but without modifying windows etc/hosts ?

What do you mean by store? What do you intend to accomplish?

I updated the comment. I meant something like :
dns : {
  "dc.services.visualstudio.com" : "<IP_ADDRESS>",
  "vortex.data.microsoft.com": "<IP_ADDRESS>"
}

And use somehow those ip's ... but this is again an aspect of node js. But maybe there is some way .

So what do you get when running this in the command line?
node -e "require('dns').resolve4('dc.services.visualstudio.com', (err, result) => console.log(err, result))"

I get :
{ [Error: queryA ESERVFAIL dc.services.visualstudio.com]
  code: 'ESERVFAIL',
  errno: 'ESERVFAIL',
  syscall: 'queryA',
  hostname: 'dc.services.visualstudio.com' } undefined

I get this regardless of etc/hosts ip mappings . (I tried with mappings and without mappings)

How about:
node -p "require('dns').getServers()"

And also:
node -e "require('dns').lookup('dc.services.visualstudio.com', (err, result) => console.log(err, result))"

I get this (I think it is safe to show them) :
[ '<IP_ADDRESS>',
  '<IP_ADDRESS>',
  'fec0:0:0:ffff::1',
  '<IP_ADDRESS>',
  '<IP_ADDRESS>',
  '<IP_ADDRESS>',
  '<IP_ADDRESS>',
  'fec0:0:0:ffff::1',
  '<IP_ADDRESS>',
  '<IP_ADDRESS>' ]

How about the last snippet?

Last snippet : node -e "require('dns').lookup('dc.services.visualstudio.com', (err, result) => console.log(err, result))"
returns :
{ [Error: getaddrinfo EAI_AGAIN]
  code: 'EAI_AGAIN',
  errno: 'EAI_AGAIN',
  syscall: 'getaddrinfo',
  hostname: 'dc.services.visualstudio.com' } undefined

(I have no ip mappings in etc/hosts)

It works now. It was a problem with an "WideCap" proxyfier app i had installed . Which made this and some other software (office) not work .


Add package NimNN

Please merge this, been waiting for a while now. If not, please tell me what is the issue, I shall fix the issue.

Please merge this, been waiting for a while now

Sorry, it is/was a holiday time :)

Sorry to disturb you :)   Thank you.


feat: alt text for all images in the workshop

Great job adding all the alt-text and little fixes, Nick! That must've taken a while. I only saw a couple of minor typos (see below):
github.qmd line 113:
"Screenshot of a GitHub repository landing page where the 'add file' button has been clicked and a yellow circle surrounds the 'create new file' and 'upload files' buttons in the sub-menu that created"
I feel like you meant, "...that was created" or "... in the sub-menu created" ?
branches.qmd line 145:
"Screenshot of a pull request on GitHub after the 'delete branc' button has been clicked and replaced by a 'restore branch' button"
Typo in "branc"
milestones.qmd line 58:
"Screenshot of the creation phase for a new GitHub milestone with an open field for a title and description as well as an option due date field"
I feel like you meant, "optional" instead of "option".
Okay that was all I saw! 👍


Support for PostgreSQL 9

Hey all!
Is there any chance to add support for older versions of PostgreSQL (like 9.x)?
I'm willing to send a PR if the possibility exists :)
And keep up the good work!

Hey @lealhugui 👋
PostgreSQL 9.x got to its end of life 3 months ago, and I'm not how common it is. Do you use it?

I'm willing to send a PR if the possibility exists :)

I can support you with that. Please, feel free to join our Discord server and ping me there.

PostgreSQL is now EOL, therefore I am closing this issue. Don't hesitate to re-open if this is still an issue for you.


Point to vault_agent_token_file from template

As detected in banzaicloud/bank-vaults#1635, recent bank-vaults makes consul-template fail as it can no longer find the vault token file.
This change mitigates issue by making example in documentation refer to vault_agent_token_file.

Re-added the original commit from https://github.com/bank-vaults/bank-vaults.dev/pull/95 to adjust for the path change of the modified file


procedure to set isCitable

https://github.com/research-software-directory/backend/blob/8301bc1662e64745890a68bd42c78aa5a4635328/schema-fixtures/software1.json#L41
regarding isCitable
this key should be filled in by software, according to the following steps:

check if there is exactly one item in githubURLs for which isCitationcffSource is true
try to retrieve the corresponding CITATION.cff
validate the CITATION.cff
see if it has a doi, if so, set isCitable to true
iff isCitable === true, show the 'cite this software' box on in the frontend.

We need to decide if we still want to do citeas.org as fallback, might be better to have just one approach.
Can we/should we differentiate between different 'modifiers' (private/publiuc/read-only/etc) for keys? e.g. using underscores? -> _isCitable or something?

should be part of nlesc-tasks task that fills the citation information.

issue is being worked on here https://github.com/research-software-directory/tasks-nlesc/commit/c2667c069bc7c3818817c0430ecbc1c1da864402


Postcss config has deprecated syntax

Describe the bug
https://vitejs.dev/guide/features.html#postcss
vite support postcss.config.js with outdated syntax
  plugins: {
    // Plugins for PostCSS
    "postcss-short": { prefix: "x" },
    "postcss-preset-env": {},
  },

New syntax
    plugins: [
      // Plugins for PostCSS
      ["postcss-short", { prefix: "x" }],
      "postcss-preset-env",
    ],

from here https://webpack.js.org/loaders/postcss-loader/
proof https://github.com/postcss/postcss-load-config/issues/224
Reproduction
new syntax not support in Vite
    plugins: [
      // Plugins for PostCSS
      ["postcss-short", { prefix: "x" }],
      "postcss-preset-env",
    ],

System Info
win10, vite 2.6.0

Used Package Manager
npm
Logs
No response
Validations

[x] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

@Alexufo I'm confused about what to take action here. Are there code/documentation to update?

new syntax not support in Vite

In what way Vite isn't supporting it? Vite uses postcss-load-config to load the postcss config.

If the object format is outdated, it should be logged by postcss-load-config instead. Currently it's still supported there, which normalizes the output into an array of plugins for Vite to use, so it would be hard to know if the syntax is outdated either. Closing as there hasn't been any response too.


Latest YarnRunner fails on Windows

This fix worked for me on Windows.
  private ProcessExecutor command(String... cmd) {
    if (isWindows()) {
      List<String> args = new ArrayList<>(Arrays.asList("cmd", "/c"));
      args.addAll(Arrays.asList(cmd));
      return new ProcessExecutor().command(args);
    }
    return new ProcessExecutor().command(Arrays.asList(cmd));
  }

Whoops sorry! Forgot about Array.asList returning an immutable list!

That being said the code is really ugly, any way to make it better ?

This might be a little cleaner and seems to work on Windows.
  private ProcessExecutor command(String... cmd) {
    List<String> args = new ArrayList<>(Arrays.asList(cmd));
    if (isWindows()) {
      args.addAll(0, Arrays.asList("cmd", "/c"));
    }
    return new ProcessExecutor().command(args);
  }


Report usb device status in case of msg error from host to device

Return EFI_DEVICE_ERROR to the caller if USB_REQ_GET_STATUS request fails
Test Done:
fastboot can work after running 400 times below commands: fastboot reboot bootloader
fastboot devices
Tracked-On: OAM-115637

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web  for more details. For Binaries: /cactus-absp-or-local/celadon_smr0_apollo-merge/22


processor_alpaca.py: function:  def fetch_latest_data() can be limited to downloading 1 data point?

Currently extending the paper trading with a new data processor so as to integrate with my broker ig.com
They only support downloading a maximum of 10K data points per week (across all stocks), so extremely limited.
I am experimenting downloading data from Yahoo Finance, for training, testing and also fetching the latest data for the state as part of trading ops.
In processor_alpaca.py there's a function:
def fetch_latest_data(
    self, ticker_list, time_interval, tech_indicator_list, limit=100
) -> pd.DataFrame:

I notice it only uses the latest price even though it downloads 100.
    latest_price = price_array[-1]
    latest_tech = tech_array[-1]

It looks like this function will still work properly if I set the limit to 1 - please would you confirm?
If this is the case why download 100 anyway?
Many thanks

No, I think you should download 100. The last 100 days would help you to calculate the technical indicators. So in the fetch_data function, the latest technical indicators are also returned, so for its calculation, you need the historical data. However, you can download with a smaller limit, as the indicators are calculated at max for the past 24 days (like for MACD).

@Athe-kunal thank you for your guidance.
I am trading at 1min, but don't see a way to download the last 100 in yf.download()?


Add custom configuration: istiod-configMap-name

Add custom configuration: istiod-configMap-name

@chong19951021 Thank you for contributing. Looks good to me. This PR can be merged as long as you sign the commit as https://github.com/aeraki-mesh/aeraki/pull/297/checks?check_run_id=10515804064 points out and fix the lint.


Update core team

alphabetized the core team and core team alumni lists (this is in its own commit and was done automatically, so there shouldn't be any changes in that commit other than the alphabetizing)
updated the current list to match the wiki page, and the alumni list to include people who'd been removed in the wiki page change history

there are probably people missing here, but the wiki list seems to be the most canonical so this is at least a start

@nmorduch could you please add me to the core contributor list as well?

Yes, my mistake! I had managed to note only deletions rather than additions. Fixing that now!


App Crashing on ios 10.0.1, 10.0.2

I'm crashing when saveImageToGallery function called.

Could you provide some more information and details on what is happening exactly? E.g. what device, what OS and version, what are you doing when it's "crashing"? Some code snippet would also be helpful for understanding what is happening.

it's work fine on IOS < 10 and when i check on IOS >= 10 . it's crashing the app.i'm using iphone 6s.
i'm downloading image through cordova-plugin-file-transfer and then use SaveImage plugin to save image in photo Gallery.

@Haideralee We have just released an updated version 0.2.3 using which any iOS 10 issues should be resolved. Could you therefore please use this updated version and check if your issue is still occuring?

@leschirmeur ok .

@leschirmeur Yeah it's working Thank You.


cant find the 'worldPosition' : undeclared identifier

fan from the video, and i try to use the first part in my project, but it shows this error
ERROR: 0:330: 'worldPosition' : undeclared identifier
export class Fog{
    constructor(){
        this.init()
    }

    init(){

        THREE.ShaderChunk.fog_fragment = `
        #ifdef USE_FOG

        // #ifdef FOG_EXP2
        //     float fogFactor = 1.0 - exp( - fogDensity * fogDensity * fogDepth * fogDepth );
        // #else
        //     float fogFactor = smoothstep( fogNear, fogFar, fogDepth );
        // #endif

        vec3 fogOrigin = cameraPosition;
        vec3 fogDirection = normalize( vWorldPosition - fogOrigin );
        float fogDepth = distance( vWorldPosition, fogOrigin );

        float heightFactor = 0.05;
        float fogFactor = heightFactor * exp( -fogOrigin.y * fogDensity) * ( 1.0 - exp( -fogDepth * fogDirection.y * fogDensity) / fogDirection.y);

        fogFactor = saturate( fogFactor );

        gl_FragColor.rgb = mix( gl_FragColor.rgb, fogColor, fogFactor );
        #endif

        `

        THREE.ShaderChunk.fog_pars_fragment = `
        #ifdef USE_FOG
	uniform vec3 fogColor;
	// varying float fogDepth;
	varying vec3 vWorldPosition;
	#ifdef FOG_EXP2
		uniform float fogDensity;
	#else
		uniform float fogNear;
		uniform float fogFar;
	#endif
#endif
        `

        THREE.ShaderChunk.fog_vertex = `
        #ifdef USE_FOG
            // fogDepth = - mvPosition.z;
            vWorldPosition = worldPosition.xyz;
        #endif
        `

        THREE.ShaderChunk.fog_pars_vertex = `
        #ifdef USE_FOG
            // varying float fogDepth;
            varying vec3 vWorldPosition;
        #endif
        `
    }

}

and in the scene class

this.scene.fog = new THREE.FogExp2(0xDFE9F3, 0.0000005);

I don't check issues filed on these projects, since I just dump the code here. From the error, it sounds like whatever shader you're using doesn't have "worldPosition" declared in the vertex shader. I only tested this on a handful of shaders, most of them the MeshStandardShader, so ymmv. If I were you and trying to debug this, I'd see what the vertex shader does declare, and see if you can modify the fog code to be more robust.

I had the same problem. A line is missing in the vertex shader:
THREE.ShaderChunk.fog_vertex =     #ifdef USE_FOG       vec4 worldPosition = modelMatrix * vec4(position, 1.0); // From local position to global position       vWorldPosition = worldPosition.xyz;     #endif  ;

I figure it out, it works in the video because Simon used shadowMap, and directionalLight cast shadows. It seems like these combo will add worldPosition into fog_vertex shader chunk.


Update to raven 7.2.3

This PR updates raven to the latest (7.2.3) and also adds some properties were added.

hi @homerovalle, apologies for missing this. I just merged an update which changes the dependency to raven 7.6 and will ship in a new release shortly. Thanks!


Allow running integration tests without arguments

High Level Description
Modifies the integration test suite to be triggerable from the commandline with nothing more than:
source /opt/mesosphere/environment.export
cd /opt/mesosphere/active/dcos-integration-test/
pytest

The cluster topology arguments can still be provided via the same method, but now they only need to be provided when one wants to verify that provisioning has been successful.
Note: This PR depends on https://github.com/dcos/dcos/pull/1507
Related Issues
https://jira.mesosphere.com/browse/DCOS-13464
Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

NOTE: This PR must be shipped with its downstream counterpart:
https://github.com/mesosphere/dcos-enterprise/pull/866


Consider banning use of std::queue due to potential slowness with MSVC

By default std::queue uses a std::deque as the underlying container.
Some past experience with MSVC runtimes have shown that block sizes for std::deqeue could be quite small and you could end up jumping around memory a lot.
Need to investigate!
The optimizer and compressor use std::deque, in possibly performance-critical parts of the code.

cc: @dj2
Same applies to std::deque as well.


Daily task reminders corrected for "Relog" message

close #8308

Everything except for Essence did not need the user to Relog

I'm fairly certain the staves require a relog

The staves were checked and it didn't require a relog.

I'm fairly certain the staves require a relog

Can confirm this is not the case. I'm always waiting at the barrel when they magically pop up.

@ksergio39 did you verify all of these do not require relogging ingame?

@Adam-  Yes, they were all checked and all except for Essence did not require relogging ingame.

@adam would you like a Screen recording showing that they don`t need a relog?


train error

thank your code.
info: No module named 'json_tricks'

thank your code.
info: No module named 'json_tricks'
did you solve this problem?


fix: updated link to PR Velocity

Description
closes #219
This PR resolves the issue of "page not found" for link "PR velocity" in the Dev Card part of the docs.
I have updated the document with correct link.
What type of PR is this?
📝 Documentation Update
Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?
NA
Added to documentation?

[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
No
[optional] What gif best describes this PR or how it makes you feel?
NA

HI @MrCyberlord !
I updated your post to include the closes keyword which will automatically link the issue with the PR and close it when it gets approved and merged.
You can learn more about that here
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
Hope that helps 👍


Cannot get it to work with build

It runs perfectly on dev but after I build my project I always get the error in the browser:
TypeError: Failed to construct 'URL': Invalid URL

Tracking it back to the generated .js file where the init() method relies on import.meta.url to construct the url of the wasm file. But that doesn't seem to be available after building.
Interestingly I get the exact same issue when I build your Vue 3 example.
Is there something I'm missing?

Hello, the vue3 sample code dependency has not been upgraded. Please make sure that the vite-plugin-rsw version is the latest and try again.
The rsw plugin will rewrite the internal code of pkg when it is built.
https://github.com/lencx/vite-plugin-rsw/blob/main/src/index.ts#L54
The steps to use the rsw plugin, take yarn as an example:

yarn dev (generate pkg)
yarn build (executed at least once step 1)

This is still happening for me
"vite": "^2.1.5",
"vite-plugin-rsw": "^1.2.7"

It does work when the crate is in the same path as the vite project. It doesn't work when the crate is outside of the project, eg crates: ["../../my-crate"]

@kabouzeid

crates: package name, support npm organization(not a directory path).
the rust crate all start with the project root path.

Can refer to my other project: https://github.com/lencx/learn-wasm
Chinese articles: WebAssembly入门

Why doesn't it work with directory paths?

The path that meets the agreement will be automatically matched inside the plug-in, that is, the package name in the crate is equivalent to the folder name under the root path.

so any way to put all crates in crate dir instead of project root?

any way to set crate root to crates/ instead of Vite project root or @npm-org/?

@audacioustux
This directory structure can meet your requirements do
[my-wasm-app]
|- [crate] # rust - custom path, starting from the project root path.
|	  |-[rsw-test] # npm package
|	  |-[@rsw] # npm org
|	  	  |-[hey] # npm package
|	  	  |-[other] # npm package
|	  	  `-... # other package
|-[src] # front-end
|- vite.config.ts
`...

// vite.config.ts
import { defineConfig } from "vite";
import ViteRsw from "vite-plugin-rsw";

export default defineConfig({
  plugins: [
    ViteRsw({
+	  root: 'crate', // TODO: rust - custom path, starting from the project root path.
      mode: "release",
      crates: ["@rsw/hey", "@rsw/other", "rsw-test"],
    }),
  ],
});

@lencx exactly... I've tried with root: "crates" but that didn't work

@audacioustux
This has not yet been achieved, can be included in the plan, please stay tuned to the project.

Thanks for the fast response! I think in our case it was because we had the crate named "rust". We had in a subfolder with that name before when we used Webpack to build everything and there it didn't give any errors but here it seems to be different. It works now. Thanks!

@audacioustux
Please install version v1.3.0, rust crates supports custom paths, you can use relative or absolute paths.
https://github.com/lencx/vite-plugin-rsw/issues/3#issuecomment-818820824

@lencx waiting for the CI/CD + cargo workspace support :(

Awesome, thanks for addressing this! Although I don't need it myself, I think it makes more sense to have the root on a per crate basis. For example:
export default defineConfig({
  plugins: [
    ViteRsw({
      mode: "release",
      crates: [
        { root: 'path_1', name: '@rsw/hey' },
        { root: 'path_2', name: '@rsw/other' },
        { root: path.resolve("."), name: 'rsw-test' },
      ],
    }),
  ],
});

@audacioustux could you elaborate what you mean exactly? :) I might be able to help. Also, if this is something completely different, it would be best to open a new issue for this.

@kabouzeid  https://github.com/lencx/vite-plugin-rsw/issues/5

Ah yes, this is bugging me too 😅


"skip to main content" appears at the bottom of the pdf page

The file exported with "Print with retained formatting" has a text block "skip to main content" at the bottom of each page (see picture), which obscures the original text.
The last page does not have this text block in the same place.

Do you have any other plug is installed?
On 7 Sep 2022 at 10:55 AM +0400, 袁野ANNO @.***>, wrote:

The file exported with "Print with retained formatting" has a text block "skip to main content" at the bottom of each page (see picture), which obscures the original text.
The last page does not have this text block in the same place.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

I'm seeing the same issue on macOS 12.6 and 0.8.6. I have uninstalled all other plugins to rule that out. I have also tested using several different themes, including the default light theme, bear light and Bonofix Theme. It only appears on documents that are longer than one page. Also note, when using the Dev Theme the plugin will not generate a PDF longer than a single page (even if the content is).

If you scroll to the bottom does it work?
On 14 Sep 2022 at 3:04 AM +0400, Walter Chisenski @.***>, wrote:

I'm seeing the same issue on macOS 12.6 and 0.8.6. I have uninstalled all other plugins to rule that out. I have also tested using several different themes, including the default light theme, bear light and Bonofix Theme. It only appears on documents that are longer than one page. Also note, when using the Dev Theme the plugin will not generate a PDF longer than a single page (even if the content is).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Scrolling to the bottom does not resolve either issue. On multi-page content, you still get the Skip to main content message on each page. As for the Dev Theme, it still prints only a single page with the content you have displayed in Logseq itself.

I haved test uninstalling all plugin, using default theme and scroll to the bottom avoid lazy-load.
None of them work, the question still there 😿.

friends any progress on this? :) kind regards from Switzerland

try the latest version :)

try the latest version :)

THANKS


Zip file directory structure issue

Driver version
8.4 through 11.2
Client Operating System
Windows 10
Problem description
Using 7-Zip, if you look at the folder structure in the released zip file, you can see that there is an issue in the directory separator between the sqljdbc_<version> folder and the language folder, making the folders appear as one:

This is causing problems for Chocolatey: https://github.com/dgalbraith/chocolatey-packages/issues/448
Expected behavior
The zip package should extract into sqljdbc_<version>\<language using 7-Zip (and Chocolatey).
Actual behavior
The zip package extracts into sqljdbc_<version><language> using 7-Zip.
You can use https://download.microsoft.com/download/d/1/9/d194dc5c-4db6-4fb6-8ba2-219c93272b7b/sqljdbc_<IP_ADDRESS>_enu.zip as an example.
Any other details that can be helpful
The Windows built-in Compressed Folder Tools extracts the zip file correctly.

thanks @David-Engel

we have identified and fixed the issue, this will be fixed in the next release.


⚠ Panoramas has degraded performance

In f09bac1, Panoramas ($SITE_URL_PANORAMAS) experienced degraded performance:

HTTP code: 200
Response time: 6198 ms

Resolved: Panoramas performance has improved in d2d66ae after 6 minutes.


KeyError 24

When I run endGameReplay.py I get this error:

I have attached 2 .save game files to replicate the error.
auto.zip

I will look into it

Should be fixed now. You can update via git commands or with nonGitUpdater.py code.

Yeah, it works.
Thank you for the quick help.


Add city to locations.txt

In workshop and decided to change something.

Hi gary, that looks cool!

Good stuff.


fix: update Dockerfile entrypoint to use Anexia webhook

Previously the entrypoint into the docker images was not correctly set up. It was still the path carried over from the ionos implementation.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.926%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
323

Relevant Lines:
539

💛  - Coveralls


Allow ScorllViewer to manage PointerWheel Event

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[x] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Avaloniaui.net with user documentation

Breaking changes

Fixed issues

Is there a similar setting in WPF/UWP? If there is we should prefer to use the same API.

Could we get a description on this? I think I can see what it does, but could you explain:

Why one would need this?
Whether its present on other frameworks?
Why no unit tests?

You may have noticed PRs by the core team being opened and merged without good descriptions; that's less than ideal but happens because it's something we have discussed in chat so everyone is on the same page. For PRs from non-core contributors, especially PRs that haven't been talked about before in chat, a good description will help enormously to get a prompt review (btw our contributing guidelines do mention that it's best to chat with us to about a feature/fix before starting work).

Is there a similar setting in WPF/UWP? If there is we should prefer to use the same API.

There is no equivalent in PointerWheelScrollMode in WPF

* Why one would need this?

Because it is faster to scroll with the wheel on the desktop than to move the mouse

* Whether its present on other frameworks?

WPF

* Why no unit tests?

Because there are already Unit Tests that check Offset and this functionality is closely linked to it. If you want I add a test.

You may have noticed PRs by the core team being opened and merged without good descriptions; that's less than ideal but happens because it's something we have discussed in chat so everyone is on the same page. For PRs from non-core contributors, especially PRs that haven't been talked about before in chat, a good description will help enormously to get a prompt review (btw our contributing guidelines do mention that it's best to chat with us to about a feature/fix before starting work).

Sure, but in any case I would have implemented it because I need it, so I have to share it.


Implementation of FDICA

Summary
In this PR, frequency-domain independent component analysis (FDICA) is implemented.
The following update rules are included:

Gradient descent
Natural gradient descent
Auxiliary function

close #8, #9, #21

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@7eb09ce). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #22   +/-   ##
==========================================
  Coverage           ?   86.17%
==========================================
  Files              ?       11
  Lines              ?     1020
  Branches           ?        0
==========================================
  Hits               ?      879
  Misses             ?      141
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb09ce...067b4e1. Read the comment docs.


Unable to edit site content via Paneron/Aperis

Ping @strogonoff .

@strogonoff @TRThurman is waiting for this.

On it.

Apologies for delay. New version of Aperis was released Monday; it (1) is functional for editing static doc pages and (2) uses an updated site/data structure that accommodates news roll (a blog-like timeline).
Two outstanding items are: (A) migrate this repository to the new data structure (ETA today), and (B) finish & enable post drafting & publishing interface.

Hi @TRThurman. Should we schedule a chat/walkthrough on how to edit ap210.org start to end? I’m thinking a 30-minute call with screensharing. Could do this Friday or the next convenient for you day.
(cc @ronaldtse)

Hi
That would be wonderful.
If we could also record the session, that would be even better.
Then I could better remember the process and share with a couple other folks I want to permit to add content.
How about 9AM Mountain Time Friday?
Tom

On Sep 16, 2021, at 3:35 AM, Anton Strogonoff @.***> wrote:
Hi @TRThurman https://github.com/TRThurman. Should we schedule a chat/walkthrough on how to edit ap210.org start to end? I’m thinking a 30-minute call with screensharing. Could do this Friday or the next convenient for you day.
(cc @ronaldtse https://github.com/ronaldtse)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/expresslang/ap210.org/issues/1#issuecomment-920744489, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMMKVD5ULFO3S5VHL5ZBIDUCG26TANCNFSM5AGHMGVQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Time works for me, accept event invite!


Add version uint type support

fix panic when use version with uint32 type #1124

it's my pleasure


Culling Thread crashed

assembling a ship on a multiplayer server and had a crash on the client, but the server was running fine. crash-log gave the description "Culling Thread crashed", crash report is attached
crash-2022-02-03_17.39.05-client.txt
.

Looks like an incompatibility with the "entity culling" mod


Fix failing bundle-size reporter workflow

Related to #320
Fix the bundle-size reporter workflow for PRs from non-tscircuit org members.

README.md

Add a note about the GITHUB_TOKEN requirement for the bundle-size reporter workflow.

.github/workflows/bundle-size.yml

Ensure GITHUB_TOKEN is passed to the sticky-pull-request-comment action.
Define necessary permissions (pull-requests: write, issues: write) in the workflow file.
Add a conditional check to skip the "Update comment" step for non-members.

/claim #320

You didn't fix it you disabled it...


I'd reallly like a way to limit/specify the special characters set to use

Feel free to submit a pull request containing this functionality.  I would suggest making a prop to pass in the special characters regex, defaulting to the current one on https://github.com/sators/react-password-checklist/blob/master/src/index.tsx#L60

Now available in v1.5.0


[BUG]  Unrestricted Access to website.

Description
Without user authentication, any user can access the home and other pages.
Screenshots

Any additional information?
This misconfiguration can increase the risk of unauthorized access to sensitive information and potential security breaches.
I can work on this feature, please assign this issue to me.
Thank You.
What browser are you seeing the problem on?
No response

Description
Without user authentication, any user can access the home and other pages.
Screenshots

### Any additional information?
This misconfiguration can increase the risk of unauthorized access to sensitive information and potential security breaches.
I can work on this feature, please assign this issue to me.
Thank You.
What browser are you seeing the problem on?
No response

Hey, could you show me the exact issue that the website is experiencing in video form?

Just like Without logging in, I can visit every page of your website even the particular user's page too, which can lead to unauthorized access and can be harmful for all the users.

please assign this issue to me. @Nishitbaria


Regional slots - Overworld, Nether, End

Since the clock and the compass are the most common items to use with this mod, it would be great to have the slots with these items disabled in the Nether (only) where they are useless! You should add a toggle in the whitelist to hide specific items when the player is the overworld, or nether or end.

I could add dimension ID whitelisting. So you would define minecraft:clock@0 to whitelist the clock for dimension 0 (the overworld), or minecraft:clock@0,1 to whitelist it for dimensions 0 and 1 (the overworld and the end)

It should work for now but in the future you'll have to make it simpler, just for noob users. I like it like this

I try to describe the configs in as much detail as possible within the file (and in-game config when you mouse-over the labels). Any new features will be self-explanatory and I have no intention of dumbing down configuration for "noob users", sorry.

¯_(ツ)_/¯ whatever you'll decide is fine for me
keep up the good work


Environment Variables for Deployment

Hi!
I'm curious how I can deploy my app using this package with keys set as environment variables?
I don't see anything in documentation regarding this, and would be very appreciative if you can point me in the right direction.
My environment is Kubernetes based, so this is rather important that I can get the keys from a runtime environment variable.
Thanks!

hey @Flinty916  hope you are doing good .
I believe you should be able to achieve that by using your env variables
https://github.com/fuentesloic/nuxt-stripe?tab=readme-ov-file#configuration
setup the key using the imports.meta or process.env depending on what do you use
Tell me how it goes

I am close this issue as I believe it is answerd with the new documentation :) If not please re open it @Flinty916


[Decompiler] Get used variables, handle function calls better, and minor cleanup

Pull Request Test Coverage Report for Build 497477617

171 of 239 (71.55%)  changed or added relevant lines in 10 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.04%) to 62.609%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

decompiler/IR2/cfg_builder.cpp
12
15
80.0%

decompiler/ObjectFile/ObjectFileDB_IR2.cpp
0
4
0.0%

decompiler/IR2/Form.cpp
108
133
81.2%

decompiler/IR2/AtomicOp.cpp
28
64
43.75%

Files with Coverage Reduction
New Missed Lines
%

decompiler/ObjectFile/ObjectFileDB_IR2.cpp
1
0%

Totals

Change from base Build 497291909:
0.04%

Covered Lines:
24825

Relevant Lines:
39651

💛  - Coveralls

Pull Request Test Coverage Report for Build 497477617

171 of 239 (71.55%)  changed or added relevant lines in 10 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.04%) to 62.609%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

decompiler/IR2/cfg_builder.cpp
12
15
80.0%

decompiler/ObjectFile/ObjectFileDB_IR2.cpp
0
4
0.0%

decompiler/IR2/Form.cpp
108
133
81.2%

decompiler/IR2/AtomicOp.cpp
28
64
43.75%

Files with Coverage Reduction
New Missed Lines
%

decompiler/ObjectFile/ObjectFileDB_IR2.cpp
1
0%

Totals

Change from base Build 497291909:
0.04%

Covered Lines:
24825

Relevant Lines:
39651

💛  - Coveralls


UX glitch in language selector component

Expected is that the language selector is a rounded rectangle. Observed is that part of the rectangle is not visible on my android device.
Acceptance Criteria

[ ]  Language selector looks correct on the device

Observed on my Android phone

Improved dialog for @cherrielam  to review

Looks good to me


Unstable Routing

Hi.
I added about.html inside Views/Home/ and in Home controller added a aboutAction() method which does render twig view file (about.html) then finally register for routing in index.php:
$router->add('about', ['controller' => 'Home', 'action' => 'about']);
and yet I receive error:
Fatal error
Uncaught exception: 'Exception'

Message: 'No route matched.'

Stack trace:

#0 /home/php-mvc/public/index.php(35): Core\Router->dispatch('about')
#1 {main}
Thrown in '/home/php-mvc/Core/Router.php' on line 130

Anyway I tried to change error handlers code inside echo just to see what loads, but no changes shows up, too.
I changed the config line like below but still getting the same errors:
const SHOW_ERRORS = false;
This is strange. I cant figure it out. I thought that It may be rendered twig files but I cleared all caches and did autoload dump composer thing. No luck.

sorry for this trash issue, I figured that I didn't uncomment the .htaccess rewrite base rule. it works now.

How can I add  other routes .

#22

Please see my response to the other issue.


Text Alignment Doesn't Seem to be WYSIWYG

https://playcanvas.com/project/540564/overview/textbugdemo
In attempting to make a Screen with 2 text elements: 1 anchored to the top as a title, and one anchored to the bottom as content, allowing the layout to be easily adjusted by simply changing the screen height if either element's content changes -- the following was discovered:
The expected behavior is found in the editor, however, upon launch (in both desktop and mobile (Mobile Safari and Chrome Mac) the expected alignment, especially of the top-anchored element, does not match what is seen in the editor.  Desired results can be achieved by manually changing the y-value of the text elements, but that destroys the automation provided by the anchoring attributes.

I think @daredevildave or @vkalpias are best placed to advise you here. But if I select the Title under screen 1 and set to 'Bottom Left' and then set Y translation to -57, it looks fine and seems to work as expected. Same for Title under screen 2. Set preset to Bottom Left and Y position to -57.

Was hoping to keep the Y positions at 0.  :)   Semi-Liquid Layout.

On Mar 10, 2018, at 2:06 PM, Will Eastcott<EMAIL_ADDRESS>wrote:
I think @daredevildave https://github.com/daredevildave or @vkalpias https://github.com/vkalpias are best placed to advise you here. But if I select the Title under screen 1 and set to 'Bottom Left' and then set Y translation to -57, it looks fine and seems to work as expected. Same for Title under screen 2. Set preset to Bottom Left and Y position to -57.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/playcanvas/engine/issues/1126#issuecomment-372070987, or mute the thread https://github.com/notifications/unsubscribe-auth/AIJrhfHQdEeenFK_H6EZhmsVWfo84KMoks5tdE6CgaJpZM4SlVr_.

Does it work if you make sure your margin is 0?

My goal was to keep all margin, alignment, and anchor values at 0 or 1, as they apply to floating the given element to the top, or sinking it to the bottom.  So that the only real arbitrary values were the actual width and height of the elements themselves, and the width and height of the encompassing canvas.
In the editor of the project I supplied, you’ll notice that the Y values of both title and subtitle are 0, yet they stick to the top and bottom, respectively.  And you can control the spacing simply by changing the height of the canvas.  But in the player, it’s not reflected as such.

On Mar 11, 2018, at 8:50 AM, Vaios Kalpias Ilias<EMAIL_ADDRESS>wrote:
Does it work if you make sure your margin is 0?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/playcanvas/engine/issues/1126#issuecomment-372125404, or mute the thread https://github.com/notifications/unsubscribe-auth/AIJrhXwLUhTcoNkS0WB0FEJC3qgDfe8aks5tdUfUgaJpZM4SlVr_.

I'm not sure I completely follow what you are trying to achieve here.
However your project as I can see it today is set up incorrectly. Your title elements have anchors set to [0,1,0,0] which means your bottom anchor is larger than your top anchor. (We should prevent this in the Editor). You'll notice if you select the anchor gizmo in the viewport it snaps back to 0.
To anchor your title to the top set your anchors to [0,1,0,1] and set the pivot to [0,1] and your text alignment to [0,1].
I don't see any bug here.


Fix no "data-server" DNS record for VPC router

Description
This PR adds the capability to VPC VR to answer "data-server" DNS queries based on the source IP of the VM.

Creates a new record for "data-server" translated to VR IP of newly create subnet in /etc/hosts file
Configure dnsmasq to send response of "data-server" query based on source IP of VM

STEPS TO REPRODUCE

1. Create a VPC
2. Add an isolated network with UserData service with VirtualRouter as provider
3. Create a VM in this network
4. Run "nslookup data-server" command from inside of VM
5. Run "cat /etc/hosts" command from inside of VR

EXPECTED RESULTS

Running "nslookup data-server" command returns IP address of router
Running "cat /etc/hosts" command from inside of VR shows "data-server" record and the VR NIC IP

ACTUAL RESULTS

Running "nslookup data-server" command returns "No answer"
The result of running "cat /etc/hosts" command from inside of VR, don't have any record about "data-server"

Fixes: #4865

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[X] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Apply the patch directly to VPC VR.
Add new subnet to VR, then add a new VM and check the record existance.
Restart VPC and check recreation of records.
Remove all VMs from the subnet and check the record is deleted.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: debian. SL-JID 303

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-337)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33043 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4873-t337-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_migrate_VM_and_root_volume
Error
82.59
test_vm_life_cycle.py

test_02_migrate_VM_with_two_data_disks
Error
51.18
test_vm_life_cycle.py


Docs restructuring

DO NOT MERGE
This restructures our documentation and splits it into two parts:

General "Starlite website"
Documentation

The main purpose of this was to be able to only version the documentation and not the whole page.
The split achieves several things:

Allows us to change and develop the main page in a way that viewing the docs for an old version won't also get you old content for non-documentation pages
Changes to theme and such will be available in old versions of the docs as well
Makes the versioning future proof, in that we can still opt to re-do the whole thing, and serve a snapshot of an old documentation from within it, while the old docs can also link to the newer version

Also adds a landing page, which is only temporary and aims to be "good enough" for now. @JacobCoffee will take care of creating something more visually appealing at some point.
Preview is available at https://provinzkraut.github.io/starlite/.
I'd like some feedback on the content of the landing page specifically, since I'm not entirely sure about its content and phrasing.
Todo before merge

[ ] Backport changes to the v1.51 branch
[ ] Manually do initial deploy to GH pages

Can you attach some pictures to the PR?

Just check out the link, it's live there.

In mobile i have to open a menu to switch to dark mode. Also, it doesn't switch to my device default theme automaticall.

I'll check if the new theme supports this. On desktop the navigation should be a bit easier, and to be honest, it's what I aimed for mostly. Mobile should work, but it's not the main target really.

In mobile i have to open a menu to switch to dark mode. Also, it doesn't switch to my device default theme automaticall.

I'll check if the new theme supports this. On desktop the navigation should be a bit easier, and to be honest, it's what I aimed for mostly. Mobile should work, but it's not the main target really.

I strongly disagree. I read docs on mobile often, and so do many others.

@peterschutt, @cofin, @JacobCoffee it'd be great if one of you native speakers could check on the wording an grammar and such of the landing page.

I strongly disagree. I read docs on mobile often, and so do many others.

I'll see what I can do!

@Goldziher Can you check the mobile header again?

@Goldziher Can you check the mobile header again?

It's perfect!

@JacobCoffee it'd be great if one of you native speakers could check on the wording an grammar and such of the landing page.

will look. everything looks very good at a glance


Rebase master to release 0.3

What is the purpose of the change

Sync commits in master branch to release-0.3

Brief change log
(for example:)

Sync commits in master branch to release-0.3

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-0.3@8993d0c). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-0.3     #301   +/-   ##
==============================================
  Coverage               ?   66.89%
==============================================
  Files                  ?      207
  Lines                  ?    15604
  Branches               ?     2342
==============================================
  Hits                   ?    10439
  Misses                 ?     4599
  Partials               ?      566

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8993d0c...d3bc758. Read the comment docs.


Reason for ctrl+q binding to workbench.action.quickOpenView

We just bound ctrl+q to quit the application on Linux, I think it would make sense to bring that to Windows too. Also being very similar to how ctrl+tab works, I find ctrl+q to open the quickOpenView feels a bit weird when ctrl+shift+q opens the debug console. Holding ctrl+q and using arrows feels strange to me.

I assigned it to Ctrl+Q a) because it is one of the few free keybindings on most OS and b) because it is very close to Ctrl+Tab so you do not need to do lots of exercises to navigate between files and between views.
I do not think that Ctrl+Q is the standard keybinding for Windows, that is why I did not assign it there. I am looking at references like these:

https://support.microsoft.com/en-us/help/12445/windows-keyboard-shortcuts

Best I could find is Alt+F4 as outlined in https://support.microsoft.com/en-us/kb/126449 but most applications I saw use it to close a window, which will only close the application if the last window was closed.


Add a pretty print option

add a generic type argument that specifies what to do for each new elem (new line or no new line). Default to no new line


Fix in STM32F4 over-drive configuration.

Summary
Some MCUs of the STM32F4 family have the ability to operate up to 180MHz, but only if core over-drive is enabled.
The current code indeed enables the core over-drive, but not for all MCUs that need it.
The MCUs in need of over-drive to reach their maximum clock are:
STM32F427
STM32F429
STM32F437
STM32F439
STM32F446
STM32F469
STM32F479
Impact
For some of the aforementioned MCUs, core over-drive was not enabled, resulting in invalid clocking configuration.
Unfortunately as tested, at least on my board, the MCU happily accepted 180MHz without over-drive enabled and worked OK.
Thus it is very possible that many users of this chip are not aware of this miss-configuration. The chip though may be unstable in certain conditions.
Testing
Tested on a custom board, using an STM32F427VI.
After the change, the respective code is indeed enabled. After boot, the core over-drive is enabled as it should, checked by the respective register value.

Hi @davids5
Indeed STM32F437, STM32F439, STM32F479 are not included in Kconfig. I can remove those.
Certainly STM32F427 was missing though...
PWR_CR_VOS is not affected. It is a requirement though to be set to scale 1 or 2 only. Currently it is set to scale 1 specifically, so this change shouldn't be a problem. It would be best to have PWR_CR_VOS configurable in Kconfig, but this is another PR...
Indeed the code previously was not checking the frequency before enabling over-drive. So I left it as is. But then also PWR_CR_VOS is not configurable...
I will check a bit later regarding STM32_HAS_OVERDRIVE.
I am will somehow improve this PR, and then maybe work separately on making power scale and over-drive configurable, as it may affect other MCUs than just the STM32F4.

I added the option STM32_HAVE_OVERDRIVE for all the mentioned MCUs, cleaning things up.
Now regarding how this feature will be enabled. What do you think is best?

Add an option in Kconfig. The user explicitly chooses whether they want over-drive enabled or not.

Have the code to parse the RCC settings, determine whether the clock frequency will be greater than 168MHz, and automatically enable the over-drive if needed.

@fjpanag - nice would be able to squash and force push, when you are done?

I added the option STM32_HAVE_OVERDRIVE for all the mentioned MCUs, cleaning things up.
Now regarding how this feature will be enabled. What do you think is best?

Add an option in Kconfig. The user explicitly chooses whether they want over-drive enabled or not.
Have the code to parse the RCC settings, determine whether the clock frequency will be greater than 168MHz, and automatically enable the over-drive if needed.

I think the 3rd option is to uses the STM32_SYSCLK_FREQUENCY > 168 Mhz

nice would be able to squash and force push, when you are done?

OK, I will do it.
Don't merge yet, let's just fix how/when over-drive will be enabled first.

@fjpanag I set it to Draft. When you are done just un-Draft it

I added the option STM32_HAVE_OVERDRIVE for all the mentioned MCUs, cleaning things up.
Now regarding how this feature will be enabled. What do you think is best?

Add an option in Kconfig. The user explicitly chooses whether they want over-drive enabled or not.
Have the code to parse the RCC settings, determine whether the clock frequency will be greater than 168MHz, and automatically enable the over-drive if needed.

I think the 3rd option is to uses the STM32_SYSCLK_FREQUENCY > 168 Mhz

This however means that I will have to include <arch/board/board.h> in stm32f40xxx_rcc.c. Is this acceptable, architecturally?

This however means that I will have to include <arch/board/board.h> in stm32f40xxx_rcc.c. Is this acceptable, architecturally?

Yes, board.h is a "public" header file and may be included from anywhere in the system.  That is because arch/board is a symbolic link to the board/include directory.

I feel that this completes the changes related to over-drive.
I will work on another branch (possibly after vacation) on making regulator scale configurable too.
However, as I touched the files arch/arm/src/stm32/stm32_pwr.h & arch/arm/src/stm32/stm32_pwr.c CI complains about styling issues. I fixed as much as I could, but I am not sure what to do with this last error.
Any hint?

However, as I touched the files arch/arm/src/stm32/stm32_pwr.h & arch/arm/src/stm32/stm32_pwr.c CI complains about styling issues. I fixed as much as I could, but I am not sure what to do with this last error.

Any hint?

@xiaoxiang781216 or @patacongo - Would you advise @fjpanag on what the style issues.

@fjpanag you can change "Public Functions" to "Public Function Prototypes"


Black screen after clicking "Continue" on Health and Safety Warning in 1.13.5

Describe the Bug
When launching Beat Saber 1.13.5 with Counters+ installed, the game only displays a black screen after clicking "Continue" on the Health and Safety Warning. The menu music plays but the monitor and headset only display a black screen.
Attach or Link Files
_latest.log
CountersPlus.json.txt
Additional context
After uninstalling Counters+ my game works fine, so either Counters+ is broken in 1.13.5 or it's conflicting with another mod. My complete mod list can be found in the latest.log file.

Counters+ is not yet updated for Beat Saber 1.13.4 and 1.13.5. Please be patient!


Add ZBRENT error to stream

I get ZBRENT error  in VASP 5.4.4, and added to stream.yml.
I ran pre-commit run --all-files locally which auto-updated docstring format of test functions in test_stream.py little bit.
I used pathlib instead of os.path.

@zhubonan, could you review this PR?

Can a PR be merged automatically by @JPchico's approval?


Don't clear console to show budhud info

Because having the console cleared can be annoying. Also increments last updated.

Alright.


Add installer to winget-pkgs

Is your feature request related to a problem? Please describe.
It'd be nice to non-interactively install the BetterDiscord installer from the terminal in Windows (winget install BetterDiscord)
Describe the solution you'd like
Package the installer as an MSI for Windows so it may be added to winget-pkgs
Describe alternatives you've considered
Never being able to ever automate installation :(

Here are the related issues and the reasons this probably will not happen anytime soon:
https://github.com/BetterDiscord/BetterDiscord/issues/1252#issuecomment-1107358452
https://github.com/BetterDiscord/BetterDiscord/issues/382
https://github.com/BetterDiscord/BetterDiscord/issues/1215

This project could easily use https://github.com/electron-userland/electron-installer-windows to create a Windows installer

that completely misses the point of the installer, having to install the installer first is just nonesense, the installer is portable for a reason.

It isn't mutually exclusive, an application can provide both a system installer and portable program. Using a package manager to install applications is the way to go. Less fuss when you reformat you computer since you can simply import a list of the previous packages/apps you had installed. Less wasted time

how can a client modification be a portable app.

Chocolatey makes this possible...
betterdiscord

Sorry we don't wish to make this into a windows installer at this time. We'd rather have package managers use our CLI once it releases to the public. CLI installs with electron don't make much sense imo

@virtualex-itv I appreciate you making a chocolatey package for this, I could not figure it out myself. Would you be willing to help out when the CLI releases?

@virtualex-itv I appreciate you making a chocolatey package for this, I could not figure it out myself. Would you be willing to help out when the CLI releases?

@rauenzi - I'd be happy to help.  the chocolatey package leverages a tool called AutoHotkey to handle the silent installation steps from the GUI automagically since there is no native silent install parameter.
When can we expect a 1.21 or 1.3 of this installer as 1.2 is plagued by the "black screen" bug which then impacts the installation via chocolatey?  It seems to work fine on my machine but on a few others, including test VMs, they are experiencing the black screen bug.

Yeah I saw your use of AHK in the choco package you published, was interesting to look through. The next version will probably be within the next couple of days. Feel free to reach out on Discord if you want more info, we've gotten a bit off topic here


[Question] Relation with konstruktoid/ansible-role-hardening

Hello!
This is a simple question of whether this is a subset of ansible-role-hardening or is this repo meant to be executed before?
Thank you again for sharing all this great work!

Hi @jdaln, and thanks,
This role is just a subset and is meant to be a starting point.
The hardening role is a big one, and sometimes it's more manageable to have multiple smaller roles.


ESP32-V2 Webflasher Connects then locks

Describe the bug
Adafruit Discord Discussion
I tried https://adafruit.github.io/WipperSnapper_Firmware_Uploader but it cuts me off immediately after a reboot.
Wippersnapper Firmware Uploader loaded.
Connecting...
Connected successfully.
Try hard reset.
Error: Oops, we lost connection to your board before completing the install. Please check your USB connection and click Connect again. Refresh the browser if it becomes unresponsive.

WipperSnapper connects to the board and locks it before Webflasher has time to begin the process of erasing flash... would be my guess.  Was able to erase flash manually with python esptool first try.  The latency from the internet between bootup and reflashing sequence is my guess.
I have no problem locally getting under that window after bootup, up arrow in cmd prompt, erase flash.  There is a small window where you can erase it.  I only know this from fighting with it so many times in the past.  If you time the entry in esptool command prompt just right you can beat WipperSnapper to erase the flash before it locks you out.
The latency from the webflasher makes that time window... almost impossible.. a few seconds, 3 seconds tops with my internet speeds to where ever web flasher is running from. It isn't enough to start the flash erase procedure apparently.
Arduino board
Feather ESP32-V2
To Reproduce
Steps to reproduce the behavior:

Have an ESP32-V2 with latest updated WipperSnapper
Click on webflasher url listed above
Connect to board (paired) and attempt to flash
It will connect successfully and 1-3 seconds later disconnect.

Expected behavior
Update firmware using webflasher
Desktop (please complete the following information):

OS: Windows 10
Browser Chrome

Additional context
I might not remember all of the steps that happened in exact order. It was 4 days ago and my memory is horrible.

@DJDevon3 I am unable to reproduce this issue with the latest version of io.adafruit.com and wippersnapper. We've updated/upgraded the web flasher as well, it now runs from io.adafruit.com instead of elsewhere. Please try that out and feel free to re-open this issue if you are still having trouble.

The updated one with adafruitio works much better. Yep can close this one. 👍


Scorec nosimdep

@zhang-alvin this merges in recent changes to master and the stack. We should start being able to add automated regression and unit tests to run with travis.

@cekees Thanks for this. I'll look into creating regression tests on Travis.


Translate l10n/po/zh_CN/_guides/security.adoc.po

@zhfeng This is done. Please help review if it is ok. Thanks.


Use JSON Schema validations from SDK

Summary
JSON Schema used for validation has been extracted into SDK and Ghost needs to take advantage of this.
Implementation notes
When migrating to use @tryghost/admin-api-schema in the validation layer, the error handling needs extra work as the library no longer returns a promise rejection with Ignition.ValidationError, but rather information about validation. Error handling has to be done on Ghost's side.

Not stale


Udp transport abstraction improvement

This patch removes a lot of duplicated code
The ExternalProject_Add are easy to cause build failure across platform.
And also the the Debug/Release build are not working at the same time on Windows at least

changing the transport bindings is not something we want. Also, this is unnecessary and does not make things cleaner nor better. Thanks, but no thanks.


feat: add nuclio/nuclio

https://github.com/aquaproj/aqua-registry/pull/6007 nuclio/nuclio: High-Performance Serverless event and data processing platform
$ aqua g -i nuclio/nuclio

@suzuki-shunsuke What if it does not have a ".exe" extension?
https://github.com/nuclio/nuclio/releases/tag/1.10.4

https://aquaproj.github.io/docs/reference/registry-config/complete-windows-ext
complete_windows_ext: false # disable completion

Thanks.

I fixed supported_envs.
When we generate code by aqua-registry gr, supported_envs is correct.
$ aqua gr nuclio/nuclio
packages:
  - type: github_release
    repo_owner: nuclio
    repo_name: nuclio
    asset: nuctl-{{.Version}}-{{.OS}}-{{.Arch}}
    format: raw
    description: High-Performance Serverless event and data processing platform
    supported_envs:
      - darwin
      - linux
      - amd64
    rosetta2: true

https://github.com/aquaproj/aqua-registry/pull/6007#issuecomment-1236500374
Oh, complete_windows_ext isn't set properly. I'll create an issue.

I mistakenly thought that "windows" was not included.
aqua-registry scaffold results were corrected, but it was not necessary 😅😅
Thanks for the correction!

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.48.0


changed np.asscalar to object.item fixes #252

fixed the issue with np.asscalar that seems to be deprecated in numpy future versions. "AttributeError: module 'numpy' has no attribute 'asscalar'"

@wingenium-nagesh Thank you for the PR. It turns out this fix was already made on a branch that was just merged into master.


asp-fallback-href tag helper not working

Moved from https://github.com/aspnet/Home/issues/656
@developer1998
I have missing library at href so technically asp-fallback-href should kick in, but it does not. bootstrap-touch-carousel.min.css is missing, and it won't pick up bootstrap-touch-carousel.css
        <link rel="stylesheet" href="~/lib/bootstrap-touch-carousel/css/bootstrap-touch-carousel.min.css"
              asp-fallback-href="~/lib/bootstrap-touch-carousel/css/bootstrap-touch-carousel.css" />

I think you need to set a test value so that the generated code can determine whether the original script failed. E.g. <link rel="..." ........ asp-fallback-test-class="someCssClassToTest" .... />
The generated JavaScript code will test for the existence of a CSS class, property, or value, and if it's not there, it'll load the fallback style.

Yup @Eilon is 100% correct. Example link tag with functional fallback by specifying:
    <link href="site.min.css" rel="stylesheet"
          asp-fallback-href="~/site.css"
          asp-fallback-test-class="someClass"
          asp-fallback-test-property="visibility"
          asp-fallback-test-value="hidden" />

We should make it an error case to specify a fallback href without a test value. We should consider doing the same thing for the script tag helper.

Thank you for addressing this.

This code is not easy to test and that will leed to not functional or not optimal code. See the typo's in VS2015RC
Bootstap should not test on window.jQuery but on window.jQuery().modal
<script src="//ajax.aspnetcdn.com/ajax/bootstrap/3.0.0/bootstrap.min.js"
                    asp-fallback-src="~/lib/bootstrap/js/bootstrap.min.js"
                    asp-fallback-test="window.jQuery">

And jQuery is wtih capital Q
<script src="//ajax.aspnetcdn.com/ajax/mvc/5.2.3/jquery.validate.unobtrusive.min.js"
               asp-fallback-src="~/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js"
               asp-fallback-test="window.jquery && window.jquery.validator && window.jquery.validator.unobtrusive">

As Developer I like to see some warnings.

Before loading resource the test should not succeed
After loading the test should succeed.
And a check if the fallback resource is available incl all reference to image and fonts
An easy way to sync CDN version with fallback version

@Anderman I think the templates in RC had some bugs and I believe those are fixed for the next update of VS2015 RTM. Sorry about that!

@danroth27. Is it possible to take that depency one step higher and make it intellisence aware.
In the old way we create something like @HTML.someMethode(p1,p2). So HTML attributes should have compareble intelliense

Note: This case is already being logged as warning in both Link and Script tag helper.

As @ajaybhargavb said, this is already a warning case. We'll be adding a new logger in future template updates to ensure these warnings are seen by default when debugging in VS. Our approach so far has been to not throw runtime exceptions for cases like this but rather log warnings as we want to minimize the error logic introduced by tag helpers over and above normal HTML & C# use (which is what Razor is all about).
We can certainly look at enhancing IntelliSense however to make completing logical groups of attributes simpler. I've made aspnet/razor#443 to track that idea.


'backtrace' is forcing an increased MinSRV; pin 'backtrace' to version = "= 0.3.30"

'failure' is using backtrace = "0.3.3", which by semantic version auto-upgrade was pulling in 'backtrace' > v0.3.30 (specifically, v0.3.40 most recently). 'backtrace' v0.3.31 introduces use of #[cfg(target_vendor = ...)] which requires rust v1.33.0. So, 'backtrace' is forcing an upgrade of MinSRV to rust v1.33.0 with the change from backtrace v0.3.30 to backtrace v0.3.31.
So, using backtrace > v0.3.30 forces MinSRV to be rust v1.33.0.
Technically, by being less than v1.0.0, 'backtrace' has no semantic version requirement. And there is debate about whether increasing MinSRV is a semantic change. But, in my strong opinion, the surprise disruption of other crate's MinSRV statements downstream is definitely a semantic change.
At the least, I would pin all external crates with version < 1.0.0 to a specific version, hopefully minimizing furture surprise increases in MinSRV.

ref: https://github.com/rust-lang/rust/blob/master/RELEASES.md

Usually only binaries should pin a dep to a specific patch. Otherwise if failure pins to =0.3.30 and a different one of my dependencies pins to =0.3.20 then nothing will build.
You should add backtrace = "=0.3.30" to your Cargo.toml and failure will build with that version, since its Cargo.toml is compatible with anything >=0.3.3.

Otherwise if failure pins to =0.3.30 and a different one of my dependencies pins to =0.3.20 then nothing will build.

Which is why its generally better to constrain with the broadest range that works, rather than pin to one version:
backtrace = ">=0.3.3, <0.3.31"

If some other dependency requires backtrace ≥ 0.3.31 then its MSRV is also greater than yours, and you would need to constrain that dependency as well, in a similar fashion.

Thanks for the attention and discussion.
I did not know that I could pin a transitive crate version. That's a trick I'll be using immediately in coreutils.
And I do see the merits of pinning a range instead of a specific version, as well. Still though, unless I'm misunderstanding the dependency rules, I think that setting a version range restriction for 'backtrace' here in 'failure' would be a good thing to avoid violating the stated MinSRV.

I would not want a <0.3.31 constraint, that forcibly blocks all downstream crates from using new features of backtrace even if they do not care at all about supporting rustc 1.32 and older. The current dependency specification is accurate because failure works with any backtrace >=0.3.3. In general only binaries should be using <constraints. CI of library code can use cargo update --precise to make version selections on old toolchains.
The msrv discussion has been hashed out many many many times and is not worth having again, it suffices to say that there is not widespread agreement that raising msrv needs a major version after fully considering the tradeoffs.
Longer term, tooling that understands msrv requirements (https://github.com/rust-lang/rust/issues/65262) is the right solution.

As you wish. But since you have an MinSRV statement about 'failure' that is currently incorrect when used without a transitive dependency restraint, shouldn't you update the 'failure' MinSRV to be 1.33.0 now?

Yes, but this crate is not exactly maintained right now. :wink:


能支持其他Pytorch版本吗？

目前仅支持2.4，2.4以下版本会报错，但我们的集群环境目前还不支持这么新的版本。

try pip install git+https://github.com/huggingface/transformers.git@27903de
The constraint torch>2.4 is not introduced by qwen2-vl, but stems from a recent bug in transformers. Although the fix has been proposed, it has not yet been merged.
As a temporary workaround, you can install transformers from a commit before PR #31502.

是不是nn.RMS 不支持的问题
可以在 /transformers/pytorch_utils.py 中把
# ALL_LAYERNORM_LAYERS = [nn.LayerNorm, nn.RMSNorm]
这一行注释掉

the fix has been merged. now, you can try qwen2-vl with torch<2.4.


Use Spring Security Integrated CORS Support

Description
Replace the existing CORS implementation for the REST API with the Spring Security CORS integration.
See the Spring Security reference guide for details.

Code complete.


Declarative table component fixes

Fixes https://github.com/microsoft/azuredatastudio/issues/14048
We now :

Don't add duplicate items to container components. If an item is attempted to be added that already exists then we just skip it (and log a warning since that should not be a normal case)
Clear out the declarative table component when setting new data values

please fix the unit test failure

Pull Request Test Coverage Report for Build 742392656

33 of 92 (35.87%)  changed or added relevant lines in 1 file are covered.
9 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.006%) to 43.554%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/api/common/extHostModelView.ts
33
92
35.87%

Files with Coverage Reduction
New Missed Lines
%

src/sql/workbench/api/common/extHostModelView.ts
9
35.28%

Totals

Change from base Build 734125201:
0.006%

Covered Lines:
26187

Relevant Lines:
54951

💛  - Coveralls


Split the Always Show Grid checkbox into 3 options inside sub menu.

This splits the Always Show Grid checkbox into 3 options:

Show
Show When Snapping To Grid
Hide

Toggle Grid hides the grid when it's visible, when it's invisible it sets the visibility to Show When Grid Snapping, if grid snapping is enabled and Show, when grid snapping is disabled.
This allows disabling the 2D Grid when grid snapping is enabled, fixes #34386.

@MightyPrinny Is this still desired? If so, this needs to be rebased on the latest master branch.

@MightyPrinny Is this still desired? If so, this needs to be rebased on the latest master branch.

Superseded by #57848.


[CP] Cherry-Pick "[cfe] Ensure default values in synthesized function nodes"

Commit(s) to merge
https://github.com/dart-lang/sdk/commit/54031e2752d76a95fa7fa069bf1b41a21260b5e9
Target
beta
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/365580
Issue Description
Without this fix some apps run into crashes of the dart2wasm compiler, see https://github.com/dart-lang/sdk/issues/55529
What is the fix
The fix is to ensure synthetic functions created by CFE have default values for parameters where needed.
Why cherry-pick
We don't want customers to run into dart2wasm crashes in next stable branch.
Risk
If we run all CI tests on cherry-pick requests then risk is low. /cc @johnniwinther @chloestefantsova wdyt?
Issue link(s)
https://github.com/dart-lang/sdk/issues/55529
Extra Info
No response

LGTM

lgtm

@mkustermann go ahead and merge please.

@itsjustkevin The cherry-pick landed last week. That will ensure it will be included in the stable release for I/O, correct? If so, we can close this issue.

We can close this issue @mkustermann.  This cherry-pick missed the cutoff for the next release.  If we create the cherry-pick again on top of the stable branch, we can get it in the first hotfix release.
CC @kevmoo

We can close this issue @mkustermann. This cherry-pick missed the cutoff for the next release. If we create the cherry-pick again on top of the stable branch, we can get it in the first hotfix release.

Filed a CP for stable here: https://github.com/dart-lang/sdk/issues/55714


simplify things

Codecov Report

Merging #9 into master will increase coverage by 21.1%.
The diff coverage is 47.72%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   25.61%   46.72%   +21.1%
==========================================
  Files           4        4
  Lines         121      122       +1
==========================================
+ Hits           31       57      +26
+ Misses         90       65      -25

Impacted Files
Coverage Δ

src/AlgebraOfGraphics.jl
100% <ø> (ø)
:arrow_up:

src/utils.jl
13.88% <ø> (+8.48%)
:arrow_up:

src/algebra.jl
50% <25%> (ø)
:arrow_up:

src/spec.jl
63.49% <50%> (+35.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c565e18...f412220. Read the comment docs.