Regression: open-in-browser redraws the article list

Newsboat version (copy the output of newsboat -v or the first line of git show): r2.21-175-g3bee9
Config file (copy from ~/.newsboat/config or ~/.config/newsboat/config):
mark-as-read-on-hover yes
show-read-articles no
browser firefox

Steps to reproduce the issue:

start Firefox (to avoid Newsboat blocking);

open a feed with four unread items (or more, but adjust the numbers below, then);

move to the second item. (Note: both the first and the second items are now marked read because of mark-as-read-on-hover);

press o to open the second item in Firefox.

Expected behaviour: Newsboat's screen quickly flashes while Firefox command runs, and then I'm back to the article list with two read items and two unread items. The cursor is on the second one.
Actual behaviour: the screen flashes, and then I'm back to the article list with just two items — the ones that were on the third and fourth positions before. The cursor is now on the second (i.e. last) item, and it's marked read.
Other info you think is relevant:
I bisected this to 9aa2e7e5edfb14d38b7a1cb9d8799edadcddb5be, but haven't investigated who exactly redraws the list.
Note that the new behaviour is actually in alignment with how show-read-feeds no always behaved. This makes this issue a very interesting one: should Newsboat be consistent (both settings have similar effects), or should it be more useable (I find the new behaviour of show-read-articles disorienting).

I bisected this to 9aa2e7e, but haven't investigated who exactly redraws the list.

I'm pretty sure the redraw is caused by the set_redraw(true) call near the end of pop_current_formaction().
It wasn't hit before because we pushed a nullptr on the FormAction stack, causing f == nullptr to be true:
https://github.com/newsboat/newsboat/blob/3bee937fe8ea0de48a0b166107c720f0f0a6be67/src/view.cpp#L926-L964
This made me aware of another problem. With the provided configuration, messages are also marked as read when resizing the terminal.
Yet another problem, maybe (not yet tested), is that any error message from open_in_browser() might get overwritten by the f->get_form().set("msg", ""); call.
I think the issue is that do_redraw(true) is used for two separate reasons:

Redrawing the form (after a ^L press or after a terminal resize)
Updating the items which should be shown

It might make sense to introduce a do_update() option next to the do_redraw() option.

Yet another problem, maybe (not yet tested), is that any error message from open_in_browser() might get overwritten by the f->get_form().set("msg", ""); call.

Never mind, error messages from a failing call to open_in_browser() are set after it returns, e.g.:
https://github.com/newsboat/newsboat/blob/4fa0572e0b589d8b7e7b93da6eca4fb91ee4ed8f/src/itemlistformaction.cpp#L138-L145

This made me aware of another problem. With the provided configuration, messages are also marked as read when resizing the terminal.

Yep :(
I agree that do_redraw serves two purposes, and should be split. invalidate() in itemlist kind of tries to do something similar, but it turns into a full redraw after invalidate_everything().
Would you work on this? Since it's a regression, it better be fixed before the release. If not, I can revert the PR that introduced it, and then the deadline moves from "2.22" to "whenever".

Would you work on this?

I expect to have time for this next week.

Since it's a regression, it better be fixed before the release.

Agreed, so I added it to the 2.22 milestone.


CTRL+C to stop doesn't work in python -m aiohttp.web

Long story short
After launching a server with ``python -m aiohttp.webon my machine, theCTRL+C` key sequence doesn't stop the server as expected. Instead, the server keeps running and I have to manually kill the process.
Steps to reproduce
I launch with this command:
> python -m aiohttp.web glotpod.api:make_app
======== Running on http://localhost:8080/ ========
(Press CTRL+C to quit)

And here's the application that I'm running:
# SNIPPED-IMPORTS
from aiohttp import web
from glotpod.api.rpc import RPCHandler

class Application(web.Application):
    def __init__(self):
        super().__init__()

        # Expose the config dict
        self.config = Config()

        # Setup the executor
        if 'executor' in self.config:
            if 'threads' in self.config['executor']:
                self['executor'] = ThreadPoolExecutor(
                    self.config['executor']['threads'])
            else:
                self['executor'] = ProcessPoolExecutor(
                    self.config['executor']['processes'])
        else:
            self['executor'] = None

def make_app(_):
    return Application()

Your environment
Windows 10 64-bit
32-bit Python
aiohttp 0.22.0a0 (from master branch)

I believe its a problem with executors -- you should manually shutdown them on application finish.
See gracefull shutdown section in docs.
I think on_cleanup signal is the one you need to stop executors.

Hey @popravich, I removed all of my own code entirely and I still experience the same problem. The script now looks like this:
def make_app(_):
    return web.Application()

Do you use proactor event loop on Windows?
Maybe it's related to https://github.com/python/asyncio/issues/191

That's entirely possible. I don't set the loop explicitly so maybe it gets used by default.


Please add support for the Smartmi Ventilation System (XFXT01ZM)

Please add support for the Smartmi Ventilation System:
Model: zhimi.airfresh.va2
Region: cn

Should be straight forward. Will add it in the next update!

Also please note that this is an older miio device which will require MiCloud

ok

The device is now added in version 0.9.16

yes. it appear, but how to disable it?

You cannot disable it since it is not an extra switch but part of the accessory.

ok


How to fix the tunnel address of a device (100.64. *. *)

A device's tunnel address changes after each reconnection to the headscale due to frequent system reboots
How to fix the tunnel address of a device (100.64. *. *)

Please ask support questions in Discord (https://discord.gg/c84AZQhmpx)


[ci][chore] Update CI for versioned docs

Description
someengineering/resoto.com#350 adds docs versioning.

Latest release version is now tracked locally in the someengineering/resoto.com repo, so latestRelease.json needs to be updated with the tag and release notes link when publishing a new stable release
API docs for latest stable release and main/edge are now maintained separately in the someengineering/resoto.com repo, so these two files both need to be updated as appropriate (main/edge version on every commit)

This PR also fixes these issues:

API docs were not being updated at all
We weren't publishing release notes for prereleases, which would result in a weird empty "Release Notes" section with no link on GitHub
Remove v version prefix throughout for consistency

Note 1: peter-evans/create-pull-request exits silently when there are no changes. It will also update the existing branch/PR, which is why the non-release PR action specifies a static branch name.
Note 2: We haven't been merging CI and release note generator changes into the releases/2.4 branch. This should probably be handled so that any further 2.X releases properly handle website updates.
Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

@aquamatthias I ended up separating the logic for edge and releases/prereleases, as this makes more sense and is easier to follow. Can you help take a look at the failing checks? 👀  The only files modified were the workflow file and release notes script...

(Should those failing tests even be running on this PR when the relevant components were not modified?)


CCPP-ize PUMAS

This issue is here to help track the CCPP-ization of the current CAM interface to the PUMAS microphysics package, with the eventual goal of having a version of PUMAS runnable in CAM-SIMA.
Also notifying @Katetc and @andrewgettelman that I'll start work on this soon, and so may have some questions for them at some point.

The following is a list of needed tasks to assist with tracking progress on PUMAS CCPP-ization:
Tasks needed explicitly in the ESCOMP/PUMAS repo:

[ ] Remove all uses of CESM-specific source code from internal PUMAS routines (except the qsat_X routines, which will need to be a dependency).
[ ] Create a CCPP cap for the main PUMAS routine (and ensure it works in CAM).
[ ] Create Metadata files for the PUMAS CCPP cap and the "proc_rates_type" DDT.
[ ] Create Github Action which validates the metadata files whenever a PR is made.
[ ] Add PUMAS submodule to NCAR/ccpp-physics repo, along with needed dependencies.

Tasks needed for a complete PUMAS interstitial scheme that lives in NCAR/ccpp-physics:

[ ] Register all constituents needed by PUMAS.
[ ] Subset variables into expected microphysics dimensions (e.g. subcolumns, when enabled).
[ ] Convert microphysics-dimensioned variables back into regular-dimensioned variables.
[ ] Apply any associated tendencies to their states,  possibly in several subcycling steps.
[ ] Calculate (and apply if necessary) the "final", post-subcycle microphysics tendencies.
[ ] Calculate size distribution parameters and Liquid Water Path needed for diagnostics and radiation (i.e. the size_dist_param_X subroutine calls in CAM)
[ ] Calculate remaining diagnostic variables, such as precipitation efficiency.
[ ] Output diagnostics using CAM-SIMA-specific method(non-portable)

Tasks needed to fully-implement a CCPP-ized PUMAS in ESCOMP/CAM-SIMA :

[ ] Create a CAM-SIMA-specific pumas_namelist.xml file to support PUMAS namelist variables in CAM-SIMA.
[ ] Develop the correct directory structure between PUMAS, ccpp-physics, atmospheric_physics, and CAM-SIMA, which will likely require at least small modifications in all repos.
[ ] Create a PUMAS SDF needed to properly test PUMAS in CAM-SIMA and implement it in the CAM7 SDF.  This will likely include the use of the "subcyle" CCPP-framework feature.

Any additional tasks that are discovered during the development process will be added to this list accordingly.


[Event Request] Application “Tests-ERM”, Codeunit 134327 "ERM Purchase Order"

[Event Request] Application “Tests-ERM”, Codeunit 134327 "ERM Purchase Order"

Could you please insert the Initialize procedure or an OnTestInitialize Event at the beginning of the procedures CreatePurchaseLineWithJobTaskFCY?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Remove concept of bundles

Now that everything comes from external repositories and once the final packages to be moved Copr  is complete, we can retire the concept of bundles/repos.

We need to make sure we support existing users of bundles who are using them to skip Lustre installs, (I.E. they already have Lustre on the node, and do not want to install / rebuild or add ZFS).

This will probably slip from 4.1

This will be addressed by work for #799


Example of sum inconsistent with its definition

The example of sum towards the end of "Interlude 1: The More We Extend the Less Tensor We Get"  is inconsistent with the definition on the previous page. With the definition as given
(define sum
  (lambda (t)
    (summed t (sub1 (tlen t)) 0)))

(define summed
  (lambda (t i a)
    (cond ((zero? i) (+ (tref t 0) a))
          (else (summed t (sub1 i) (+ (tref t i) a))))))

the example evaluates to
(sum (tensor (tensor (tensor 1 2)
                     (tensor 3 4))
             (tensor (tensor 5 6)
                     (tensor 7 8))))
;; => (tensor (tensor 6 8)
;;            (tensor 10 12))

One definition of sum which is consistent with the example could be
(define sum
  (lambda (t (r #f))
    (if r
        (if (= 1 r)
            (sum1 t (sub1 (tlen t)) 0)
            (sumn t r (sub1 (tlen t)) '()))
        (sum t (rank t)))))

(define sum1
  (lambda (t i a)
    (if (zero? i)
        (+ a (tref t 0))
        (sum1 t (sub1 i) (+ a (tref t i))))))

(define sumn
  (lambda (t r i a)
    (if (zero? i)
        (apply tensor (cons (sum (tref t 0)) a))
        (sumn t r (sub1 i) (cons (sum (tref t i) (sub1 r)) a)))))

This gives
(sum (tensor (tensor (tensor 1 2)
                     (tensor 3 4))
             (tensor (tensor 5 6)
                     (tensor 7 8))))
;; => (tensor (tensor 3 7)
;;            (tensor 11 15))

Hi Bon, thanks for your patience with our response. Here is the definition of sum as it appears in the book and the code:
(define sum-1
  (λ (t)
    (summed t (sub1 (tlen t)) 0.0)))

(define summed
  (λ (t i a)
    (let ((next-a (+ a (tref t i))))
      (cond
        ((zero? i) next-a)
        (else (summed t (sub1 i) next-a))))))

(define sum
  (ext1 sum-1 1))

The definition at the end of the interlude is for sum-1 (which appears in the text as sum^1), and the extension is implied but later introduced using ext1. Using this, the answer we get is:
(tensor (tensor 3.0 7.0) (tensor 11.0 15.0))


Allow processing class constants

This patch updates the Constant processor to allow processing class constants, including the ::class pseudo-constant; additionally, it ensures that both the Token and Constant processors can apply to Config keys as well as the values by calling their enableKeyProcessing() methods.
To allow this to work, I've changed the visibility of Token::doProcess() from private to protected, to allow overriding the method within the Constant class. I've also added the new test case ZendTest\Config\Processor\Constant to cover the behavior.
Essentially, this allows the following to work (assuming the provided classes and constants exist):
{
    "Acme\\Component::CONFIG_KEY": {
        "host": "Acme\\Component::CONFIG_HOST",
        "dependencies": {
	    "Acme\\Foo::class": "Acme\\FooFactory::class",
        }
    }
}

Via:
$config = new Config(Factory::fromFile('config.json'), true);
$processor = new Processor\Constant();
$processor->enableKeyProcessing();
$processor->process($config);

I really don't like the fact that a string may now possibly change meaning with a version upgrade.
This should be mentioned as BC Break because of that.
Still, feature is awesome and worth pursuing.

This should be mentioned as BC Break because of that.

I'll update the class to accept a flag for enabling the behavior instead, and have that disabled by default; that way we can introduce the feature without requiring a major version bump.

Removed BC break flag, as I've made the key processing opt-in at this time.

There are already three optional constructor arguments; I can add it, but I
think the method call also makes sense.
On Feb 17, 2017 12:10 PM, "Marco Pivetta"<EMAIL_ADDRESS>wrote:

@Ocramius requested changes on this pull request.
In doc/book/processor.md
https://github.com/zendframework/zend-config/pull/37#discussion_r101813442
:

@@ -107,6 +131,14 @@ echo $config->foo;

This example returns the output: Value is TOKEN,Value is bar.
+As of version 3.1.0, you can also tell the Constant processor to process keys:
+
+```php
+$processor->enableKeyProcessing();
A constructor argument would be preferrable
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zendframework/zend-config/pull/37#pullrequestreview-22556617,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABlV9KiOQSMjijzwMQSm_XP951GLE78ks5rdeKhgaJpZM4MEdNe
.


Global restriction on Strings: AlphaNumeric Strings

For many applications, strings are always restricted.
For example, only alpha numeric string are used.
Strings in TorXakis can also contain control characters.
Model 2 Model transformation might want to map
a language that restricts Strings more than TorXakis
directly on TorXakis strings,
but does not want to add an isValidString function at every place a string is used.
A possible solution could be to make allowed character values a configurable choice for TorXakis
Note: the printable characters do NOT form a range (\t and \n fall outside the range 32-127)
Ranges are to limited: Allowed Characters should be the union of ranges and specific values.
Like regexes [A-Za-z0-9_], and [a-z$#%]

related to #418


PTV-1890: Fix login bug wrt anonymous IDs

Somehow missed updating the getUser(RemoteIdentity) method when I updated getUser(UserName). Sloppy.
One other issue is I still don't understand is why the ExceptionHandler didn't print out the full stacktrace from the NPE thrown by UUID.fromString like it does for all the other exceptions in the log.

Since logins are broken in CI, I'm going to merge this and deploy, but will make any necessary changes based on @briehl 's review here

I hereby grant this Pull Request the height of my esteem and provide my humble approval.


sanitizeHtmlInternal fails mXSS test

String testInput = 'CLICKME';
String expected = 'CLICKME';
expect(sanitizeHtmlInternal(testInput), expected);

test: pub run test -N mXSS -p firefox test/security/html_sanitizer_test.dart

Sorry this has gotten ignored quite a bit. I think it's unlikely we will get to it immediately, given it doesn't seem any clients have run into this.

Re-opening to keep this active.

This hasn't gotten a lot of traction, so I'm closing for now.


Clarify status of JSON-RPC api explorer

This is a very useful tool, but since it is not in scope for v1 we should make sure it doesn't take too much time. It was decided in the meeting today that this will provided as-is, without any tests or code reviews. This issue is to add a note to this effect to the documentation.

Documentation is updated @EyalLavi and part of #48 Propose closing this issue after you check if the warning at https://benchmarkstt.mikesmith.eu/api.html is ok for you.


Challenge instructions are not precise.

Describe your problem and how to reproduce it:
I was helping a member on the forum with a challenge.
The instructions (link below) are to place an image after the main element, but a moderator told them to put it inside where there are two empty lines. The mod suggested that the instructions be improved and I report it on Github.
Whether the code is placed inside or outside the main element results in a pass.
Add a Link to the page with the problem:
https://www.freecodecamp.org/learn/responsive-web-design/basic-html-and-html5/add-images-to-your-website
Here's the forum thread:
https://www.freecodecamp.org/forum/t/i-couldnt-get-through-uploading-an-image/340110/16
Tell us about your browser and operating system:

Browser Name:
Browser Version:
Operating System:
Irrelevant

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

@leebut @ArielLeslie  What about something like the following for the instructions section.

Let's try to add an image to our website:
Within the existing main element, insert an img element before the existing p elements.
Now set the src attribute so that it points to the following url:
https://bit.ly/fcc-relaxing-cat
Finally, don't forget to give your img element an alt attribute with applicable text.

@RandellDawson, that is much clearer, thank you. Perhaps adding a  comment in the code like other challenges would also guide the learner to the correct location.
As it stands, the code passes no matter where the image is in relation to the main element. Should that be fixed so that it fails when the img element is misplaced?


Add HydraDX Bounties to README.md

This PR adds the HydraDX Grants and Bounties program to the section Other Grant Programs in README.md

Thanks for the PR. I will also integrate it into the open grants program.

thank you @Noc2


As a robotics developer, I want a smooth joint controller for my robot arms

Design requirements
Port over the joint_trajectory_controller plugin from ros-controls/ros_controllers.
Use the existing ROS2 proof of concept version to build upon.

Can you list what's missing from the current ROS2 implementation?


Update README and metadata.json for 7.0.4 release

Update the README and metadata.json files to refer to the PS 7.0.4 patch release.

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

I don't see the metadata change

I don't see the metadata change

@TravisEz13 metadata was updated separately with this PR.

@TravisEz13 metadata was updated separately with this PR.

Restarted CIs for what looked like temporary failures.

Restarted CIs for what looked like temporary failures.


docs(examples): Remove lifetimes from the List example

Simplify the List example by removing lifetimes not strictly necessary to demonstrate how Ratatui lists work. Instead, the sample strings are copied into each TodoItem. To further simplify, I changed the code to use a new TodoItem::new function, rather than an implementation of the From trait.
Lifetimes are one of the more confusing things people learning Rust have to understand. The goal here is to remove that concern from the example. The From trait, also, is something a person new to Rust may not fully understand.

move the code that converts from Vec to ListItem into a method on TodoList (this really should be impl From for Vec and not a bare method).

Help me understand this. Is impl From<TodoList> for Vec<ListItem> considered a method on TodoList? I sort-of view the From and Into traits as great for expressing conversions between value types that are expected to be used in many places and commonly converted to and fro. For bespoke conversions, perhaps a named method is better? Outside of an IDE it isn't always clear what is happening when reading .into() in code.

move the code that converts from Vec to ListItem into a method on TodoList (this really should be impl From for Vec and not a bare method).

Help me understand this. Is impl From<TodoList> for Vec<ListItem> considered a method on TodoList? I sort-of view the From and Into traits as great for expressing conversions between value types that are expected to be used in many places and commonly converted to and fro. For bespoke conversions, perhaps a named method is better? Outside of an IDE it isn't always clear what is happening when reading .into() in code.

It's a trait implementation. It's similar but not the same. If you look at what List::new() accepts, you'll see that it accepts Iterator<Item = Into<ListItem>>, which means if you implement the appropriate conversion traits then you can just create the list using e.g. List::new(self.todo_list). You shouldn't have to write .into() at all here. I'd say that implementing a conversion trait is the idiomatic and correct way to write code that does a conversion like this (I'd generally refactor towards it in pretty much any situation where it makes sense). I'm surprised there's not a "This looks like a conversion, implement From" clippy lint.

Personal thought on when to use From/Into and when not: When its a simple thing INto something else (= no clones, pure moves / copy) and is rather simple / discoverable. When it involves pairs for example it's almost always easier to understand with names on functions (or putting into a struct).
From/Into is hard to understand without IDE and with tooling its still somewhat annyoing to see what exactly is done. It can also be annoying on refactorings as it silently changes the implementation which might do unexpected stuff (especially annoying when they involve cloning or performance critical things -> dont implement stuff like that in From/into)

I went ahead and renamed StatefulList to TodoList. Feel free to squash commit as you see fit!

From/Into is hard to understand without IDE and with tooling its still somewhat annyoing to see what exactly is done. It can also be annoying on refactorings as it silently changes the implementation which might do unexpected stuff (especially annoying when they involve cloning or performance critical things -> dont implement stuff like that in From/into)

Yes, this was my thinking too. In this case, allocating a temporary vector with potentially no visual artifact in code where this allocation might be occurring is arguably confusing and not very desirable, in my opinion.
I did experiment with adding a method to TodoList that returned impl Iterator<Item=ListItem> + '_ but this ran into borrow check issues later on with the call to StatefulWidget::render.  I think it is best left alone, or a considered in a separate PR.


Allows versions of ffi (1.9.22, 1.9.23) that throw SIGABRT (RHEL/Centos) or Segfault (MacOS)

I recently updated a Rails 5.1 bundle on systems running Centos 6 and RHEL7 and then my DelayedJob workers would abort when I tried to start the commands.
$ bin/delayed_job start
pid-file for killed process 22998 found (/rails_app/pids/delayed_job.pid), deleting.
delayed_job: process with pid 16048 started.
Aborted (core dumped)
$

I chased the bundle update down gem by gem and determined that bundle update spring-watcher-listen was causing the Aborted on DelayedJob startup.
There are issues Segfault on macOS with ffi > 1.9.21 and SIGABRT on Centos/RHEL 6+7 open or FFI for this, but it may make sense to modify the gemspec to exclude ffi versions 1.9.22 and 1.9.23.
I also just tried a fresh rails new testapp and ffi locks at 1.9.23, so any new Rails 5.1.x app generated on  Centos, RHEL, and possibly MacOS (not confirmed) could be affected.
Changing spec.add_dependency "ffi", "~> 1.0" to spec.add_dependency "ffi", "~> 1.0", '!= 1.9.22', '!= 1.9.23' solved the issue for me locally.

We are running our apps on CentOS 7 with Phusion Passenger via Apache. We also recently updated a few Rails apps to Ruby 2.5.1 and Rails 5.2.0 and have seen sporadic "Incomplete response received from application" Apache error pages. Looking at the logs, I see this:
/usr/local/rvm/gems/ruby-2.5.1@earlywashingtondc/gems/rb-inotify-0.9.10/lib/rb-inotify/notifier.rb:54: [BUG] Segmentation fault at 0x0000000000000000

Our Gemfile.lock reads ffi (1.9.21) so we're trying the suggested changes to version constraints. Thanks @msducheminjr for your notes.

Has upstream ffi fixed this issue yet?

I see the latest version is 1.9.25 - does this fix the issue?

Assuming this is no longer a problem, as ffi has released new versions.


Parse cloud evidence for partitions

@aarontp This is likely not the solution we want.
Since we're handling three different evidence types in the one task, it makes the required states difficult.
We don't want to mount raw disks, but we do want to mount cloud disks when they have an image embedded.
Let's set some time to discuss tomorrow.

@aarontp I've updated the logic for the evidence processor as we discussed.
Feel free to take a look for initial comments, but still WIP.
I've only tested in hybrid setup on a RawDisk (and it worked fine). I'll test on cloud evidence tomorrow. May need some changes.
If testing on cloud evidence also works, I plan to update tasks to accept partition evidence rather than disks.

@aarontp Ready for final review.
Docker enumeration is working now.

Also fixed two bugs:

Artifact extraction was using device_path, so would fail for docker containers (which can't be attached)
When output_manager was copying files to GCS, it would raise an exception for empty files. This would interrupt the post-processing and stop evidence from being detached.


Issue scores auto-debugging in PaLM model

https://github.com/google/BIG-bench/blob/d79641377d74b81054ef9cf68f25ebc9ade4a109/bigbench/benchmark_tasks/auto_debugging/results/scores_PaLM_535b.json#L38
Score with 5 shots lower than score with 3 shots.
Score with 540B model 5 shots is exactly the same as score with 60B model 5 shots : literally exactly the same.

Auto-debugging only consists of 34 questions. I strongly suspect that you are seeing small-n fluctuations, and that both models happened to get 13 problems correct on this task, and the two scores are identical just by chance.

Ok, you're right. Also, score with 2 shots higher than one with 5 shots may also come from what you say..
That's problematic, but is more an issue with the dataset than the results in themselves.


[WIP] Better module resolution of external LinkEnv

Fixes #773.

I'm still in the process of testing this. I'll report back when done.

This is maybe not quite what we want.

We should try getting the module name via nameModule_maybe even when we aren't merging. This is easy to fix.

Haddock is now a bit too good at selecting finding the module in which data types are defined.As the CI failures show, it insists on linking Int to ghc-prim's GHC.Types instead of Data.Int.

Closing this for now since I have not made any progress on it.


Pytorch model registration

Link to any related issues, companion PRs, or blockers. eg, Fixes #37
https://github.com/Garden-AI/garden/issues/216
Overview
When a Pytorch model has extra python file dependencies, a user can link these files for mlflow to process.
e.g. garden-ai model register model_name model_path pytorch -e python_file_path
Discussion
Any additional context that you think is important for reviewers or future users/contributors looking at this PR.
Testing
How did you test this? If a reviewer pulled this branch down and wanted to kick the tires, how would they do so?
Tested it on the BraggNN model example.
Documentation
Does this PR update any docs pages? Should it?

:books: Documentation preview :books:: https://garden-ai--248.org.readthedocs.build/en/248/

Codecov Report

Merging #248 (62933e6) into main (e867a89) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 68.18%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   78.62%   78.62%   -0.01%
==========================================
  Files          48       48
  Lines        3303     3321      +18
==========================================
+ Hits         2597     2611      +14
- Misses        706      710       +4

Files Changed
Coverage Δ

garden_ai/mlmodel.py
72.07% <41.66%> (-1.03%)
:arrow_down:

garden_ai/app/model.py
88.52% <100.00%> (+0.19%)
:arrow_up:

tests/test_mlmodel.py
100.00% <100.00%> (ø)


Can you tag v0.3.2?

So that I can do (I can install master):
(@v1.8) pkg> add --preserve=all<EMAIL_ADDRESS>   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package MFCC [ca7b5df7]:
 MFCC [ca7b5df7] log:
 ├─possible versions are: 0.3.1 or uninstalled
 └─restricted to versions 0.3.2 by an explicit requirement — no versions left

I'm though not sure why this happened:

(@v1.8) pkg> add --preserve=all MFCC
 SpecialFunctions [276daf66] log:
 ├─possible versions are: 0.7.0-2.1.7 or uninstalled
 ├─restricted to versions 2.1.7 by an explicit requirement, leaving only versions 2.1.7
 └─restricted by compatibility requirements with MFCC [ca7b5df7] to versions: 0.7.0-0.10.3 — no versions left
   └─MFCC [ca7b5df7] log:
     ├─possible versions are: 0.3.1 or uninstalled
     └─restricted to versions * by an explicit requirement, leaving only versions 0.3.1

I would, if I could, but I am currently in version hell, where the Julia section is taking up larger and larger amounts of space.

So, I tagged this commit for registration, see if that works...

We should still have 0.3.3 available, with updated dependencies


Enhancement: Enhancement the contact page with borders.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I think if the contact page had a border-bottom in every text item, it would have better UI and also it is not aligned and padding properly. I would also like to make it responsive.
Please Assign me this issue with the label and level of GSSOC.
Use Case
it would have better UI and also it is not aligned and margin  properly. I would also like to make it responsive.
Benefits
No response
Add ScreenShots
before:

After:

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

I think this issue is already in progress.
You can work on different issues.
Ping me for assigning the one.


merge button works, but I get a message: BUG: Invalid Path

Here is the message:
BUG: Invalid Path. If this is actually a valid path then please update the URL_VALIDATOR. path=/repos/MYORG/MYREPO/pulls/28/merge

Thanks! f50b17b2cd808d7573e2cc6942cc88098c1dc279 should fix that. From #97 it seems you were working on committing multiple files using ES7; do you by chance have a code snippet you could share?


Maps become blank after scrolling FlatList

The issue happens when adding a map item in a FlatList. The map renders correctly firstly but after scrolling far away, it becomes blank.

I think the problem is in using TextureMapView as the base class for HMSMapView. When I changed it to MapView, the issue disappears. There's some flicker when there's multiple maps in sequence in the list but I think because of the lite mode is not supported yet.

Yeah you're right. We are looking for the ways to use it with TextureMapView. If this has a work around we will notify you for the solution.

Please, Is there's a plan when the lite mode will be available?

Hello @abdelmagied94 we're working hard to implement lite mode, we'll release this feature as soon as possible, stay tuned 🎄🎄

@aktug Is the issue fixed with TextureMapView?

@aktug Is the issue fixed with TextureMapView?

the next version will be released end of the January 2021, there will be a lot of improvements/fixes and new features, stay tuned 🎁

the next version will be released end of the January 2021, there will be a lot of improvements/fixes and new features, stay tuned 🎁


specific package version

Thank you for sharing the code!
I got the "sparse tensors do not have storage" error message when running the code. I suspect it is caused by the incorrect torch-sparse version.
Can you share the specific version information of the following packages?
torch (requirements.txt shows 1.8.1)
torch-cluster
torch-scatter
torch-sparse
torch-spline-conv
torch-geometric (requirements.txt shows 1.7.2)
Thank you!

Hi, torch-sparse should be around 2.0.4. That's the only external package we use for PyG.
You can also try to deploy the newest PyG lib and see if it works. And if the error continues to be raised, you can try our new implementation which should work well in more recent PyG libs.

Thanks for your prompt reply! Actually, I also tried the new implementation, and I did not encounter this error. But I ran into a new issue here.


feature request: mix tableau.new --version

It would be nice to have a version flag for tableau_new.
mix tableau.new --version

PR welcome!

Gladly - it will take me a week or so to find some free time...


Feature/Live Photo

Implemented live photo feature on this lib.
Fifth example hits the first live photo and show it with buffer ios image viewer.
Any comments will be welcomed.

Wow - huge apoligies on my end for not seeing this @OEA that's totally on me! I've got it on my list to relieve this and will take care of updating it against master, thanks so much!

Fixed conflicts and added defensive check to live photo example. Thanks for your contribution to open source community 👍

Thanks @OEA - shutting this one down as I used your branch and added some tweaks and merged that in 👍


⚠ mainnet - Auth API has degraded performance

In b6f0acb, mainnet - Auth API (https://auth-api.pro.cf-explorer-mainnet.eu-west-1.beta.explorer.cardano.org/api/v1/user/info) experienced degraded performance:

HTTP code: 504
Response time: 10616 ms

Resolved: mainnet - Auth API performance has improved in 4a2ad9e after 13 minutes.


SoapUI is causing entire eclipse to freeze on rightclick on project

Due to some strange dead-lock situation with com.eviware.x.impl.swt.support.AwtEnvironment (from SoapUI) a I right click on projects  causes my entire eclipse to freeze and stall making it useless.

As I have finally enough with things like this, I have to agree to what Malte was already saying and proposing:
We should only install a minimum and stable set of required plugins for eclipse by default.  Lets get rid of SoapUI, SonarLine, STS, Lombok, etc.

I just checked and these plugins are no more installed by default already.
https://github.com/devonfw/devon-ide/blob/master/scripts/src/main/resources/scripts/command/eclipse#L57
So the current list is:

startexplorer
regexutil
templatevariables
spotbugs
checkstyle
cobigen
terminal

(while cobigen and tm-terminal are not yet working)
Should we also omit any of these?

templatevariables
spotbugs
checkstyle

for me sonar and checkstyle is critical as well as QuickSearch.

We have tons of issues with SonarLine. It is fine if projects configure this plugin in their project settings via git but IMHO this should not come by default.
For checkstyle I will leave it in. It does not hurt and is stable for years.
QuickSearch is not included by default but we can try to do so.

The actual issue was to exclude SoapUI which is already done. As we also do not need more exclusions, I will close this. Feel free to create PR adding QuickSearch by default.


Don't store cert backups

Those are inconvenient if you don't want to run Redis as LRU cache. We are more interested in not silently discarding any certificates, and scaling Redis with increasing number of domains, so we don't.
If this change is not acceptable, another scheme could be to store the previous (":old") certificate in addition to the current one (":latest"). This way we'd only be storing at most two certificates per domain in Redis, and not a growing number due to renewals.

Apologies for the delay on this one too, but I’ll try to take a look at this in the next couple weeks. Thanks again!

Ah, I had forgotten that we were indefinitely storing all the previous certificates, so thanks for catching this! I can see how this could become an issue with lots of certificates, particularly for in-memory stores like Redis.
That being said, I would like to retain the ability to keep previous certificates for debugging purposes by making this more configurable, instead of getting rid of the backups completely. I might be overly paranoid, since I'm not sure I've actually ever had to use the old certificates, but I'd probably prefer to keep a few old copies around for my own installations (again, I just personally tend to be overly-paranoid about deleting things :).
So my general idea for how we could maybe make this more configurable might be something like:

Keep the timestamped certs as-is.
Introduce a new keep_previous_certs option that you could use to tune how many previous certs to keep. We could maybe default it to 3 (or maybe that's just me still being overly-paranoid), but you could set it to 0 for your use-case of not wanting any backups.
After storing a new latest cert, we'd run a cleanup process to delete all the old certs except the last keep_previous_certs ones. This cleanup process would also help prune old certs from existing installations.

Does something like that approach make sense to you? If so, I know this more configurable approach might not be something you need for your use-case, so while you're more than welcome to implement it, I'm also happy to implement these changes at some point.
Thanks again!

@GUI Thanks for having a look!
From the point of our use-case: I feel that the benefit of having extra backups in Redis is limited unless there is a built-in mechanism to fall back to those backups in the event of an issue. We never had any issues with storing certificates - and I believe even accidentally deleting and re-requesting one is much less of an issue in terms of Let's Encrypt rate-limits, compared to the rate-limits one runs during other failure modes (e.g. Too Many Pending Authorizations).
So I believe in case of a problem we would most likely simply switch to a day-old backup, and study the differences with help of the log file. But any scheme that limits the amount of backups being held per-domain is certainly acceptable for us!
On our systems, I purged all backups from Redis (after harvesting their timestamps to set expiry) with:
EVAL "local keys = redis.call('keys', ARGV[1]) \n for i=1,#keys,5000 do \n redis.call('del', unpack(keys, i, math.min(i+4999, #keys))) \n end \n return keys" 0 *:15*

I have 800mb of certs clogging a redis instance....I'd love to see the keep_previous_certs setting make it to the next release

This is finally part of a release in v0.13.0 that's now published. Thanks!


how to upgrade package manager itself

Clear and concise description of the problem
I would like to upgrade pnpm before installing it. It would be nice if I could use the command npx @antfu/ni upgrade self to upgrade the version of pnpm on my CI instead npm install -g pnpm
Suggested solution

npx @antfu/ni upgrade self

Alternative
if [[ -f "pnpm-lock.yaml" ]]; then
   npm install -g pnpm
fi;

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

ni -g @antfu/ni

ni -g pnpm like this?
I would suggest using antfu/contribute#corepack so you don't even need to worry about that

The only slightly inconvenient aspect is that if I don't use Corepack or other tools to lock the package manager version, I can only manually determine which package manager is being used to perform global installation and upgrades, for example：
if [[ -f "pnpm-lock.yaml" ]]; then
   npm install -g pnpm
elif [[ -f "package-lock.json" ]]; then
   npm install -g npm
fi;

em... what should I do in this situation? Thank you!

Use run npm install -g pnpm && npm install -g npm && npm install -g yarn - it's not that hard. I don't think it's belong to the scope of this project.

This is a good approach, but there are situations where it is not possible to update the versions of both npm and other package managers simultaneously. Therefore, I am looking for a tool that can call the package manager to solve this problem, and I am still looking for possible answers. Thank you for your response.


Failed to resolve: com.github.melihaksoy:HoldToLoadLayout:1.0.7

Running on minimumSdkVersion 21 and targetSDKVersion 32


Automatically upload documentation to github.io

This will make it easier to look at the documentation
and fix issues. It is also a good prototype to disable
one of the Travis builds for google-cloud-cpp.
Fixes #8.

PTAL.


support unicode?

it would be nice when illwill also supports unicode.
Looking at the (posix) code part it also could be simple to capture them
eg:
https://www.utf8-chartable.de/
the german letter: "Ö" is encoded as 195.int 150.int
and the current getKeyAsync captures it correctly as
charsRead = 2
[195, 150 .....]

but since the current getKeyAsync returns a Key it will not compose properly.
Maybe implement a
getKeyUnicode(): tuple[key: Key, rune: string]

function that has the representation of the key in the rune string?
The inputSeq IS the correct rune!
      var inputSeq = ""
      for i in 0..<charsRead:
        inputSeq &= char(keyBuf[i])

echo inputSeq
Ö

+1, this would also enable easy async text input like GLFW's char callback.

i was thinking about this, and i'll try to explain my thoughts in another issue.
There are other issues with the current getKey implementation, mainly: there is for eg. ShiftA and CtrlA but, at least windows, posix  i have not checked yet, can detect both modificator keypresses at once.
Maybe its a good idea to depricate getKey in favor of a getInput proc that returns the rune + all modificators to the keypress and/or  the mouse with all modificators.
I'll try to get a pr done when the mouse one is merged.

Yeah, I haven't really investigated the UTF-8 issue to be honest. I was just happy to get it working with an English layout. If you can get this working reliably on all platforms, then yeah why not! Also a reminder, keyrepeat needs to work properly. From memory, UTF-8 handling with the standard windows terminal is a bit of a nightmare, so good luck :)

@johnnovak the good thing is the mouse pr already implements the windows console input (in fact the code already captures all events, but filters them for only mouse events).

@enthus1ast Yeah from memory using the windows console directly is the way to go (as opposed to stdin/stdout).

sorry @johnnovak i'm busy with other projects right now, but maybe when the time comes :)

@enthus1ast sure :) btw, i don't need unicode myself, i'm happy with latin1, but i can see why it can be a problem with German letters. a PR is welcome whenever you get around to doing it :)

@johnnovak any feelings about pulling in winim?

@johnnovak what do you think, should i upgrade getKey to also handle unicode or introduce a completely new getInput proc (that does mouse, unicode, old Key styles, maybe even modifiers)

If you are planning to do such thing, think long and hard first whether you're willing to implement Unicode support properly for Windows, Linux & Mac.

wip https://github.com/enthus1ast/illwill/tree/municode

what i'm currently aiming for is:
that it do not crash cmd.exe when typing non ascii eg: öäü
keep the old api (getKey) working if you wish and/or i could deprecate it
in favour of:
eg.:
- getKeyUnicode
-  or
- getInput (my favorite)
the new api currently looks like this:
type KeyUnicode* = tuple[key: Key, rune: string]
proc getKeyUnicode(): KeyUnicode
the key is the old Key from illwill the rune string is the unicode symbol(s).
I like the getInput name more, since we're not getting just keys, but also eg.: mouse.
Another thing i would like to change, is the modifier keys reporting.
Currently we have CtrlA but i think it would be better to provide an Object with every input
that lists the state of the Modifier keys. A little like the Mouse Input currently works:
type Modifier = object
    ctrl*: bool ## ctrl was down on event
    shift*: bool ## shift was down on event

the downside of this is, that you then cannot have a big case that reacts on CtrlA,
but must check on A + modifier.
I have to check if posix can report both at the same time.
Another good addition would be, to also let illwill report resize events.
Windows can report these in their events, for posix i have to again check.
What do you think?
I i have a little more stable api, i would create a draft pr, where we could better talk about the code.

@enthus1ast  Did you manage to solve the umlaut problem in your fork?
I'm new to nim, but I like it. My very first project should be a simple directory chooser command-line utility.
I thought I'd use illwill or your illwillwidgets library to create a simple TUI for it, but as soon as I hit e.g. the ä key, the terminal crashes. ATM this is a show-stopper for all non-english users.
I understand that @johnnovak isn't eager to solve this. But did you solve it?
If yes, am I missing something obvious?
I tried the illwill program showing the key names. I also tried chcp 65001 before calling it.
As soon as I hit an umlaut key, the whole console windows closes.

@hvbargen

As soon as I hit an umlaut key, the whole console windows closes.
Yes the terminal crashes.

Have a look at this branch:
https://github.com/enthus1ast/illwill/tree/municode
there i was working on unicode, but i do not know in which state i left it.
I'm not actively working on this atm.
If you like you could try it and maybe fork it.

OK (I'm the same person), I'll take a look at it.
Yesterday I found out that the easiest way to avoid the terminal crashes was to use _wgetch from conio.h instead of _getch.
This seems to return an integer which, if not negative, directly means the Unicode code point.

If anyone wants to solve this, the solution must be cross-platform and work ewually well on Linux and macOS in addition to Windows if you want it to get merged.
I haven't used the library for years now, so it won't be coming from me in foreseeable future, but happy to receive PRs.


rocketchat (3.0.0-1876) deb does not work on Xubuntu 18.04

My Setup

Operating System: Xubuntu 18.04 (with XFCE desktop)
App Version: rocketchat_3.0.0_amd64.deb 3.0.0-1876
Installation type:  deb file downloaded from github, installed with dpkg -i

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description
Error message produced on console, no GUI window appears.
Previous client (and before) works fine on this system, i.e. rocketchat_2.17.11_amd64.deb, reverting back to this version and all is good.
Current Behavior
Following error appears on console when running with existing "./.config/Rocket.Chat" and no gui window shows, client nonfunctional:
rocketchat-desktop
[bugsnag] Loaded!
xdg-settings: default-url-scheme-handler not implemented for xfce
SyntaxError: Unexpected token o in JSON at position 1
    at JSON.parse (<anonymous>)
    at /opt/Rocket.Chat/resources/app.asar/app/main.js:1344:42
    at Generator.next (<anonymous>)
    at /opt/Rocket.Chat/resources/app.asar/node_modules/tslib/tslib.js:114:75
    at new Promise (<anonymous>)
    at Object.__awaiter (/opt/Rocket.Chat/resources/app.asar/node_modules/tslib/tslib.js:110:16)
    at setupServers (/opt/Rocket.Chat/resources/app.asar/app/main.js:1280:46)
    at /opt/Rocket.Chat/resources/app.asar/app/main.js:3225:11
    at Generator.next (<anonymous>)
    at fulfilled (/opt/Rocket.Chat/resources/app.asar/node_modules/tslib/tslib.js:111:62)
[bugsnag] Unhandled rejection…
TypeError: Error processing argument at index 0, conversion failure from
    at BrowserWindow.setBounds (electron/js2c/browser_init.js:29:405)
    at applyRootWindowState (/opt/Rocket.Chat/resources/app.asar/app/main.js:760:20)
    at /opt/Rocket.Chat/resources/app.asar/app/main.js:3241:5
    at Generator.next (<anonymous>)
    at fulfilled (/opt/Rocket.Chat/resources/app.asar/node_modules/tslib/tslib.js:111:62)

when running after renaming  "./.config/Rocket.Chat" a slightly different error appears, but the GUI window does not show still:
rocketchat-desktop
[bugsnag] Loaded!
xdg-settings: default-url-scheme-handler not implemented for xfce
[bugsnag] Unhandled rejection…
TypeError: Error processing argument at index 0, conversion failure from
    at BrowserWindow.setBounds (electron/js2c/browser_init.js:29:405)
    at applyRootWindowState (/opt/Rocket.Chat/resources/app.asar/app/main.js:760:20)
    at /opt/Rocket.Chat/resources/app.asar/app/main.js:3241:5
    at Generator.next (<anonymous>)
    at fulfilled (/opt/Rocket.Chat/resources/app.asar/node_modules/tslib/tslib.js:111:62)

Expected Behavior
No error message in terminal, rocketchat GUI window appears as per previous client versions.

same here using rpm version in CentOS 7 x86_64

Same problem on Ubuntu Desktop 20.04.1

same problem on Ubuntu 20.04.1 LTS with KDE

Same type of error on windows

Fixed?

Seems that no...
I have the same problem on my Fedora. RocketChat client installed via Flatpak
Rocket.Chat                                          chat.rocket.RocketChat                  3.0.2      stable  system

Updated today to 3.0.4 using flatpak and the bug has gone. Client works perfectly.

@zogith Any updates?

Hi @tassoevan
Sorry for the delay in responding.
I just tried rocketchat_3.0.7_amd64.deb and it works OK.. it did hang for me (didn't connect to server) until I selected "disable GPU" though, and produced more text errors on startup, but now works. After selecting "disable GPU" (which is now greyed out with no way to unselect) it runs without those text error messages being displayed.
I have an nvidia GPU with the nvida drivers loaded.
Initial error produced:
rocketchat-desktop
[bugsnag] Loaded!
xdg-settings: default-url-scheme-handler not implemented for xfce
SyntaxError: Unexpected token o in JSON at position 1
at JSON.parse ()
at /opt/Rocket.Chat/resources/app.asar/app/main.js:1358:42
at Generator.next ()
at /opt/Rocket.Chat/resources/app.asar/node_modules/tslib/tslib.js:114:75
at new Promise ()
at Object.__awaiter (/opt/Rocket.Chat/resources/app.asar/node_modules/tslib/tslib.js:110:16)
at setupServers (/opt/Rocket.Chat/resources/app.asar/app/main.js:1319:46)
at /opt/Rocket.Chat/resources/app.asar/app/main.js:3320:11
at Generator.next ()
at fulfilled (/opt/Rocket.Chat/resources/app.asar/node_modules/tslib/tslib.js:111:62)
.. but essentially rockechat client 3.0.7 is functioning for me so I would consider this bug resolved, thanks.

Rocketchat 3.3.0 - some problem:
[bugsnag] Uncaught exception, the process will now terminate…
TypeError: Error processing argument at index 0, conversion failure from
    at BrowserWindow.setBounds (electron/js2c/browser_init.js:29:405)
    at applyRootWindowState (/nix/store/31jlqar6r4s1jzdbd3dsxg90xmmlpf55-rocketchat-desktop-3.3.0/resources/app.asar/app/main.js:405:23)
    at BrowserWindow.<anonymous> (/nix/store/31jlqar6r4s1jzdbd3dsxg90xmmlpf55-rocketchat-desktop-3.3.0/resources/app.asar/app/main.js:573:13)
    at BrowserWindow.emit (events.js:310:20)
    at BrowserWindow.EventEmitter.emit (domain.js:482:12)
    at electron/js2c/browser_init.js:157:10844
    at processTicksAndRejections (internal/process/task_queues.js:79:11)

Rocket.Chat.Electron on  master [3…] via  v14.17.0

I had the same issue today after a weird shutdown.
Investigation:
% grep -A1 bounds .config/Rocket.Chat/config.json
		"bounds": {
			"x": -0,

By default in chromium, -0 is not a valid integer. SetConvertNegativeZeroToInt can be used to force a different chromium behaviour (ref).
What is the best solution for Rocket.Chat.Electron? Avoiding saving -0 to config.json? Using SetConvertNegativeZeroToInt (if it can be done) ?


[6.x] Fix CookieJar's docs

This PR fixes (like #30741, but this time it really simplifies the if-else statement):

The docblock spaces
Prevents the duplicated head usage

Just fix the docs only. I don't understand the need for this other change. The code is fine as it is.


Fix #1196 and other waypoint refactoring

Refactor so all waypoint operations are done through the Cache object.
Check for editing a waypoint when adding.
Save cache after waypoint operations so finalDefined is set correctly.
Fixes #1196

I'll merge and then change that deletion by myself. No need for you reworking the pull request.

Sorry, commented on the inline code before I saw you merged it.
Its fine to change it to delete or not.


Last slide of some lectures has formatting issue

When rendered the last slide Your turn header sometimes has a formatting problem with showing the laptop graphic thing
Affects slides: nowcasting, joint nowcasting, forecasting as an epi problem, forecasting models
Doesn't affect slides: biases, convolutions, intro to Rt

closed by #308


chore: Update github action

Updates github action configs.

Switches to dtolnay/rust-toolchain from actions-rs/toolchain as it is outdated.
Switches to use run: from actions-rs/cargo as it is outdated.
Switches to baptiste0928/cargo-install from actions-rs/cargo when install a tool.
Update Swatinem/rust-cache to v2 from v1.

The failed ci kani isn't changed in this pull request.


Cannot save the trained ckpt file.

Hi,
I am trying to train the VOC2007 dataset for test. But found that the ckpt file cannot be saved.
I am running this test through docker container and trying to save the ckpt to the bind mounted path on the host machine(Ubuntu).
The code seems working fine, without any error message.
And the log also seems showing no specific problems.

Wrote snapshot to: /data/notebook/faster-rcnn/output/test3/VGGnet_fast_rcnn_iter_100.ckpt
done solving

But only the ckpt file cannot be saved. The other four files can be found in the same output directory.
(iter was set as 100 just for test)

At first, I thought it might caused by the conflict between host ownership and docker container ownership.
So I checked the ownership of docker container which is consistent with host machine root ownership.

I cannot figure out what is the reason for causing this problem?
Do you have any suggestion for solving this problem?
Thank you very much.

第二个文件就是啊，

second  file is this

I don't know if the chinese guy answered your question, because, hey, he answered in chinese, but basically those files together form the ckpt file (or somehting like that) you can just adress the information as VGGnet_fast_rcnn_iter_100.ckpt

@ideaplat @TheLaurens Thanks mate.

Do you solve the problem? When we restore the model,just use VGGnet_fast_rcnn.cpkt.index?

Nope, just refer to it as  VGGnet_fast_rcnn.cpkt, that should just work, if not, maybe try using an absolute path?

@chenjing8023 Just as TheLaurens replied, VGGnet_fast_rcnn.cpkt works.( In my sample case, VGGnet_fast_rcnn_iter_100.cpkt)

The exported .meta/.index/.data-00000-of-00001 cannot be restored for test session, which repeatedly printing 'Waiting for VGGnet_fast_rcnn_iter_100.ckpt to exist...'. And the test session won't start.
I am not sure if this only happens on me.
After some research, I found out that you have to specify write_version=tf.train.SaverDef.V1 in tensorflow 0.12, which I am using. And the .ckpt file is saved and can be restored in the test session.
You can add this args to /lib/fast_rcnn/train.py.
Reference:
https://www.tensorflow.org/api_docs/python/tf/train/Saver

Yes,you are right . I have specify write_version=tf.train.SaverDef.V1,but I have this error when I restore the model in the test session. I don't know how to solve it.
cudaCheckError() failed : invalid resource handle

@chenjing8023 Although I am not sure your error is caused by CUDA version, but maybe you can check the CUDA version of your environment. For me, CUDA 8.0/cudnn 5 works fine. ...

@chenjing8023  Also, this post is similiar to your problem. #19

@YutingLin could you please tell me what to what file should I add this line of code?

Hi,
Since it has been a while for my post, I have modified the code a little
bit.
Thus, I may be wrong with the accurate line where I changed.
Anyway, my  modification as follows:
lib/fast_rcnn/train.py
line 42:  self.saver = saver ⇒ self.saver = tf.train.Saver(max_to_keep=100,
write_version=tf.train.SaverDef.V1)
Actually, it should depend on which version of tensorflow you have
installed.
Best regards,
Lin
2018-03-15 17:09 GMT+09:00 LK1711<EMAIL_ADDRESS>
@YutingLin https://github.com/yutinglin could you please tell me what
to what file should I add this line of code?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/smallcorgi/Faster-RCNN_TF/issues/139#issuecomment-373293842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMZBpCDNnljn-MgCXtJ04v2WSjBap_iuks5teiG8gaJpZM4NM3dz
.

@YutingLin Thank you ^_^


this._prunedBabelOptions is not a function

https://travis-ci.org/bread-maker/bread-maker-ember-frontend/builds/257435506
this._prunedBabelOptions is not a function
TypeError: this._prunedBabelOptions is not a function
    at EmberApp._processedTemplatesTree (/home/travis/build/bread-maker/bread-maker-ember-frontend/node_modules/ember-cli-asset-sizes-shim/lib/shim-app.js:191:29)
    at EmberApp.appAndDependencies (/home/travis/build/bread-maker/bread-maker-ember-frontend/node_modules/ember-cli/lib/broccoli/ember-app.js:1109:26)
    at EmberApp.hookedJavascriptTree (/home/travis/build/bread-maker/bread-maker-ember-frontend/node_modules/ember-cli-asset-sizes-shim/lib/shim-app.js:249:30)
    at EmberApp.toArray (/home/travis/build/bread-maker/bread-maker-ember-frontend/node_modules/ember-cli/lib/broccoli/ember-app.js:1672:12)
    at EmberApp.toTree (/home/travis/build/bread-maker/bread-maker-ember-frontend/node_modules/ember-cli/lib/broccoli/ember-app.js:1694:38)
    at module.exports (/home/travis/build/bread-maker/bread-maker-ember-frontend/ember-cli-build.js:83:14)
    at Builder.setupBroccoliBuilder (/home/travis/build/bread-maker/bread-maker-ember-frontend/node_modules/ember-cli/lib/models/builder.js:56:19)
    at new Builder (/home/travis/build/bread-maker/bread-maker-ember-frontend/node_modules/ember-cli/lib/models/builder.js:30:10)
    at BuildTask.run (/home/travis/build/bread-maker/bread-maker-ember-frontend/node_modules/ember-cli/lib/tasks/build.js:15:19)
    at Promise.resolve.then (/home/travis/build/bread-maker/bread-maker-ember-frontend/node_modules/ember-cli/lib/models/command.js:243:46)
error Command failed with exit code 1.

Ember CLI 2.14.0

When running ember build or ember asset-sizes.

Same in ember-cli 2.13.1

It's related to this:
https://github.com/ember-cli/ember-cli/commit/bf757cc68ca02212c4aed1e28f46593da475a713#diff-392bb207fea8bcbeb4a084bb445f7cc7
Looks like this[INTERNAL_BABEL_OPTIONS]() would work...


align_dataset_mtcnn.py

Does your python version of MTCNN have face coordinate correction?
Thanks

Does your python version of MTCNN have face coordinate correction?
Thanks
excuse me , what do you mean~ ?


refactor build clusters logic

This PR does the following

Removes GenerateDeltas - I did not see a need for it. It is actually lot of boiler plate and many generates do not care about it. Changed the existing Generate signature to return DeletedResources also which will be used in case of incremental Xds like Delta

Removed usedDelta flag that indicates whether deltas have been actually used. All we care about is whether there are removedResources. We can just rely on length of removedResources

Refactor buildCluster logic so that is used by both BuildClusters and BuildDeltaClusters

Some other minor refactors to simplify the code.

[ ] Configuration Infrastructure

[ ] Docs

[ ] Installation

[X] Networking

[ ] Performance and Scalability

[ ] Policies and Telemetry

[ ] Security

[ ] Test and Release

[ ] User Experience

[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[X ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
4cce684cfc4b7eb10cca91f60700749c289206c1
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
4cce684cfc4b7eb10cca91f60700749c289206c1
link
/test lint_istio

unit-tests_istio
4cce684cfc4b7eb10cca91f60700749c289206c1
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b988a5c4e604f2221597f817ff8faf25f5c9fb27
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b988a5c4e604f2221597f817ff8faf25f5c9fb27
link
/test unit-tests_istio

integ-cni-k8s-tests_istio
b988a5c4e604f2221597f817ff8faf25f5c9fb27
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b988a5c4e604f2221597f817ff8faf25f5c9fb27
link
/test unit-tests_istio

integ-cni-k8s-tests_istio
b988a5c4e604f2221597f817ff8faf25f5c9fb27
link
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
b988a5c4e604f2221597f817ff8faf25f5c9fb27
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b988a5c4e604f2221597f817ff8faf25f5c9fb27
link
/test unit-tests_istio

integ-cni-k8s-tests_istio
b988a5c4e604f2221597f817ff8faf25f5c9fb27
link
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
b988a5c4e604f2221597f817ff8faf25f5c9fb27
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
b988a5c4e604f2221597f817ff8faf25f5c9fb27
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cc @howardjohn

Should we be changing the existing Generate API at all?

Since this is internal to Istio I think it should be fine unless some external dependency is there. Is there any contract from Istio side for this? @howardjohn may know better.

Should we be changing the existing Generate API at all?

Since this is internal to Istio I think it should be fine unless some external dependency is there. Is there any contract from Istio side for this? @howardjohn may know better.

fine to change

Need to be more careful, I prefer to leave two separate paths and resue some functions.

Two seperate paths at actual cluster, listener makes sense but at Generator level it is lot of boiler plate code and most of the generators not implement delta at all. And We can simplify Generate interface once we fully implement delta.

@howardjohn @adiprerepa brought usedDelta flag back. PTAL

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
58b2ed407efeec026751a3b0f07b0df264066478
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster-tests_istio

I'm fine with this as long as you can confirm delta still works

Are there any manual testing needs to be done to confirm this?

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7da5737a52a40fd2c90eeb4d70a12822d0484a3d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

Closing this in favour of https://github.com/istio/istio/pull/34513


Add support for sortables of irregular sizes.

Currently when sortables that aren't of the same width in case of horizontal sortable lists when dragging the layout breaks and elements stack on top of each other. This happens because the element that takes place of the one currently being dragged takes it's x position without taking into account the differences in size

What if, when a sortable element is over another sortable element, emit an event with the same data as for onDragEnd handler, so it will be easy to change the order of those two elements and the whole sortable list will be re-rendered? In most cases the For or Index components are used to draw lists, so there won't be much performance loss.
Sticking with the current behaviour when elements are repositioned with the translate3d CSS property is not sufficient, because in order to show correct positions other elements have to be moved also.
@martinpengellyphillips what do you think?

@Kapelianovych isn't that already possible with onDragOver?
Note that I did have an implementation in the past for computing the transforms for different sizes. Might be inspirational https://github.com/thisbeyond/solid-dnd/issues/32#issuecomment-1115021365
At some point you do end up re-implementing the browser layout engine for the css transforms. It might be worth seeing how performance is with directly moving the target nodes 🤔 We do that already in the "board" example when an item moves across boards.

I tried to re-render the list with onDragOver and this is it. It simply works 👍I noticed that while the list is re-rendering a dragged item freezes for a moment. And that is with 3 items in the list. I am using Index and trying to avoid replacing a whole DOM subtrees though. Well, an item component is complex enough to make impact on the transition 😔.

Has there been any updates/progress on this? Trying to implement the dragging of horizontal sortables with different widths and not sure if this is possible without forking the library.


fix: code coverage report generation

Description
Code coverage report generation has been stopped for a while due to toolchain upgrade. This PR fixes the report generation command cmake -DCOV=ON and make cov
Please release a set of build image after the merge.
Fixes # (issue)
Type of change (select or add applied and delete the others)

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] API change with a documentation update
[ ] Additional test coverage
[x] Code cleanup or just sync with upstream third-party crates

How has this been tested?
Code coverage report has been generated successfully at https://gist.github.com/dingelish/186ecb02002bb273a47e0cbfd1196483
Checklist

[x] Fork the repo and create your branch from master.
[x] If you've added code that should be tested, add tests.
[x] If you've changed APIs, update the documentation.
[x] Ensure the tests pass (see CI results).
[x] Make sure your code lints/format.

TVM build failed. Upstream fix is https://github.com/apache/tvm/pull/10147

rebased on #606


[M3] IHL endpoint for fees and exchange rates

The mobile app needs to be able to query IHL for fees and exchange rates for a transfer.
For now, IHL can return a hardcoded response since I am 99% sure Finclusive does not offer an endpoint to surface this information at the moment.
AC:

IHL endpoint exists returning fees and exchange rates, given a proposed transfer (crypto currency, fiat currency, amount)

should try to keep this close to the FiatConnect spec for the query endpoint


Error with retinanet model

Hi, @ZFTurbo!
I tryed convert retinanet model with backbone resnet50 and it faled.
I used https://github.com/fizyr/keras-retinanet.
  File "/usr/local/lib/python3.6/dist-packages/kito/__init__.py", line 330, in reduce_keras_model
    new_layer = clone_model(layer)
  File "/usr/local/lib/python3.6/dist-packages/keras/models.py", line 251, in clone_model
    return _clone_functional_model(model, input_tensors=input_tensors)
  File "/usr/local/lib/python3.6/dist-packages/keras/models.py", line 106, in _clone_functional_model
    new_layer = layer.__class__.from_config(layer.get_config())
  File "/usr/local/lib/python3.6/dist-packages/keras/engine/base_layer.py", line 1109, in from_config
    return cls(**config)
  File "/usr/local/lib/python3.6/dist-packages/keras/legacy/interfaces.py", line 91, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/keras/layers/convolutional.py", line 490, in __init__
    **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/keras/layers/convolutional.py", line 118, in __init__
    self.bias_initializer = initializers.get(bias_initializer)
  File "/usr/local/lib/python3.6/dist-packages/keras/initializers.py", line 508, in get
    return deserialize(identifier)
  File "/usr/local/lib/python3.6/dist-packages/keras/initializers.py", line 503, in deserialize
    printable_module_name='initializer')
  File "/usr/local/lib/python3.6/dist-packages/keras/utils/generic_utils.py", line 138, in deserialize_keras_object
    ': ' + class_name)
ValueError: Unknown initializer: PriorProbability

I would be grateful for any help.

Hi @ZFTurbo , great work here. I can see you have contributed in the keras-retinanet repo of fizyr too and also tried to support that here. Still facing the same issue as above. Any workaround for this?

@tonmoyborah
Current code supports retinanet. Here is the example. I will add it in test_bench later:
def get_RetinaNet_model():
    from keras.models import load_model
    from keras.utils import custom_object_scope
    from keras_resnet.layers import BatchNormalization
    from keras_retinanet.layers import UpsampleLike, Anchors, RegressBoxes, ClipBoxes, FilterDetections
    from keras_retinanet.initializers import PriorProbability

    custom_objects = {
        'BatchNormalization': BatchNormalization,
        'UpsampleLike': UpsampleLike,
        'Anchors': Anchors,
        'RegressBoxes': RegressBoxes,
        'PriorProbability': PriorProbability,
        'ClipBoxes': ClipBoxes,
        'FilterDetections': FilterDetections,
    }

    with custom_object_scope(custom_objects):
        model = load_model("../retinanet_resnet50_500_classes_0.4594_converted.h5")
    return model, custom_objects

from keras.utils import custom_object_scope
model, custom_objects = get_RetinaNet_model()
with custom_object_scope(custom_objects):
    model_reduced = reduce_keras_model(model)

I'll try this. I made it work by changing deserealize function in keras code but the resulting model didn't provide any speedup. Models other than retinanet are showing huge improvements

I observed the same behaviour for RetinaNet. While many BN layers were removed speed of inference stays the same.
P.S. Added RetinaNet in test_bench.


drivers: usb_dc_rpi_pico: implement remote wakeup support

drivers: usb_dc_rpi_pico: implement remote wakeup support

This change implements the following, necessary for remote wakeup to be
supported:

- implement usb_dc_wakeup_request() call to trigger remote wakeup
- implement interrupts to detect supsended/resumed state
- implement extra logic to simulate resumed state when the resume
  is a result of remote wakeup. In this case the rp2040 chip doesn't
  send a USB_INTR_DEV_RESUME_FROM_HOST interrupt, or any other
  interrupts when the resume condition is detected to be extended
  by the upstream port, so we need to simulate this event when we
  see activity on the bus.

Note that this PR has https://github.com/zephyrproject-rtos/zephyr/pull/54030 as it's base. For now when reviewing, please look directly at the top-most commit only on this branch. I will rebase, once #54030 is merged.

The dependency of this PR is now merged. So I have cleanly rebased this PR on top of main.


Anti Clockwise Support

I have added anti Clockwise support, because of my Issue ( #10 )
Please review and merge, thank you !

Thanks!


show when a muted account will expire

https://docs.joinmastodon.org/entities/Account/#mute_expires_at

only available in getMutedAccounts


Youtube video link broken

Video link explaining how to use azure monitor for containers is broken

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ac3c529f-fe57-558f-bd90-02162ff531e8
Version Independent ID: 8300d958-120e-16c1-09cc-29740e6fae00
Content: Overview of Azure Monitor for containers
Content Source: articles/azure-monitor/insights/container-insights-overview.md
Service: azure-monitor
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

I'm not able to replicate your issue and I've not had any similar feedback.  This is the link to it from YouTube - https://www.youtube.com/watch?v=RjsNmapggPU&feature=youtu.be
#please-close.


Make console top-nav sticky

would be nice if the nav was sticky/fixed when scrolling page content

Thanks @mistermoe!

I think we have all places covered for this issue now @mistermoe.


Elm and GraphQL work together?

https://github.com/jahewson/elm-graphql
https://alpacaaa.net/blog/post/elm-graphql-client/

It can work very well with CQRS approach in the backend as well. More clarification at https://gist.github.com/OlegIlyenko/a5a9ab1b000ba0b5b1ad

Use this https://github.com/evancz/react-elm-components


Handle possible null Target properties in BackendData

Summary
BackendData.coupling_map and BackendData.drive_freqs assumed that Target.build_coupling_map() and Target.qubit_properties were iterable, but these attributes can also be None. These properties were changed to return None and [] in those cases.
Details and comments
These changes should allow @DanPuzzuoli to load a DynamicsBackend with only partial metadata using Calibrations.from_backend.
It's possible coupling_map should return [] instead of None. That would let qiskit-experiments code iterate without checking for None. I wasn't sure whether it was better to favor convenience or faithfully reflecting the underlying data in that case.
Closes #1035

Currently for Mirror RB, full connectivity is assumed unless backend_data.coupling_map is not None, and [] would lead to the experiment only running single-qubit Cliffords on backends without complete metadata. So at least in this case, returning None would be better, but of course if there are other considerations, this behavior can be changed.

@coruscating I hadn't thought about it before, but having None for the coupling map imply all to all connectivity makes a lot of sense, so we can leave the PR as is (passing up None rather than substituting in an empty list).

I added some tests at @nkanazawa1989's request. I started off adding some BackendData tests but then decided to make them Calibrations.from_backend tests since that is where the original motivation for fixing this came from and there were no existing BackendData tests.

I added one more functional change -- control_channel returns [] instead of None when there is no control channel data. I think this makes more sense. It is supposed to be a list of control channels so if there is no data there should be an empty list.


Add log details for metadata load when app startup

ShardingSphere need database and table metadata when app startup.
It will spend lots time if there are lots of amount databases and tables.
It is better to log more details about metadata load when app startup.
The log may include:

[ ] Start to load metadata.
[ ] Verify sharding table or not.
[ ] Number of tables and details of each table name.
[ ] Finish to load metadata and log the total loading time.

I want to try to do this.

Thank you, assigned

Verify sharding table or not.
Which link is this? As far as I know, the sharding is not checked for correctness at startup.


feat: add example

Add one example, package.json and so on. Could you add zig version?

To be honest, I am puzzled, your example does not use original code at all.
Also, you have some entirely different implementation and also you are downloading C headers which I've intentionally wanted to avoid. It looks like you've missed the fact that there are already implementations for those things.

To be honest, I am puzzled, your example does not use original code at all.
Also, you have some entirely different implementation and also you are downloading C headers which I've intentionally wanted to avoid. It looks like you've missed the fact that there are already implementations for those things.

I'm so sorry. I will modify these files to adapt yours.

no problem, maybe wait until I finish my current changes, I'm adding few more features, and also the API will be a little bit different.

Closing, example is already in the tree


Added explanations to frontend environment variables

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.19%. Comparing base (0105679) to head (8cb9f5b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   96.19%   96.19%
=======================================
  Files          10       10
  Lines         420      420
  Branches       71       70    -1
=======================================
  Hits          404      404
  Misses         16       16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Also added and fixed some unit tests :)


Build kernel with net.core.bpf_jit_enable

Is your feature request related to a problem? Please describe.
It seems that the kernel is currently not built with net.core.bpf_jit_enable.
sudo sysctl -w netsudo sysctl -w net.core.bpf_jit_enable=1
sysctl: cannot stat /proc/sys/net/core/bpf_jit_enable: No such file or directory

Describe the solution you'd like
Built kernel so that enabling bpf jit is possible.
Describe alternatives you've considered
Additional context

The sysctl is not accessible but BPF JIT is always enabled.


Fixed #htpasswd link

Fixed #htpasswd link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:luislobo/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

LGTM


@Kami @cognifloyd i will aim to push a pr to address kami's comments tomorrow, as they were raised after merge.
But will do before I do corresponding doc change.


Updated value not displaying in IE11

My users have reported that when they update an  field in IE11 that the updated value isn't displaying when leaving the field, the previous value is displayed instead.  The code works in other browsers, particularly in Safari which doesn't support that input type natively.
I can see in my debugger that the value is being set when onChange is called and that when that part of the form is rerendered that the updated value is set on the value= field.
My app is a React app with redux and react-bootstrap but the generated html looks good.  I'll attach a screenshot showing where I'd changed the value to 1974-11-13 but the value in the field is still showing the previous value 1974-11-08.
I wondered if perhaps there's a different polypill that's missing which is needed to make the code work.  I'm using babel-polyfill to load them.

i have that problem too, but in both browsers (Safari 120.1 & IE 11)


Add a show confidence toggle to expanded sample view

A common workflow is to filter detections and classifications based on their confidences.
Currently, the only way to inspect object confidences from the App is to view the sample JSON, but it would be desirable to see the confidences directly on the image, to inform filtering via the label filter, for example (dragging the confidence slider).
I propose that we add a “show confidence” toggle to the expanded sample view that controls whether confidences (if present) are rendered on all Label instances that have confidences.
Note that this applies to both object detections and the frame-level label attributes rendered in the attribute panel of Player51, as both Detection and Classification instances can have confidences.
When this mode is enabled, labels with confidences should be rendered as "%s (%.2f)" % (label, confidence). Objects with no confidence (or when this mode is disabled) should be rendered as label.
We may have more such options in the future, but, until then, this can be positioned as a Show/Hide Confidences button in the bottom right next to the Show/Hide JSON button:

This may actually be easiest to implement under the player51 settings menu (gear icon), and fits with some of the existing object-related settings there. Agreed that a temporary design for this is fine.
Looks like confidence is already passed into player51: https://github.com/voxel51/fiftyone/blob/772d750e885b93262d3e0560dc973888264eb86e/electron/app/components/Player51.tsx#L15
Hopefully displaying it isn't too hard, but it depends on how this is passed around within player51.

This may actually be easiest to implement under the player51 settings menu (gear icon), and fits with some of the existing object-related settings there. Agreed that a temporary design for this is fine.

yeah that makes sense, I like it


chore(docs): Update README

Description
Summary*
Preliminary update of the library README, not meant to be perfect:

Add and reorganize sections
Add installation instructions
Add a simple sum example
Add BigNum struct explanation
Add TODOs for further documentation

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Preview of README: https://github.com/noir-lang/noir-bignum/blob/ss/readme/README.md

@zac-williamson I'm merging this in, but do feel free to give it a quick pass and let me know if I had misinterpreted any of your code 🙌


Fix cmake uninitialized variables

This commit solves CMake --warn-unitialized warnings
Fixed typos

Closing this , since this issue will be fixed in https://github.com/Microsoft/openenclave/pull/1483


Search ignores underscores in text strings

If a search string contains an underscore (e.g., NT_SUCCESS), using the DMC search does not return results containing only that string. It doesn’t matter whether or not you put quotes around the string.
Steps to reproduce the behavior:

Go to https://docs.microsoft.com/en-us/search/index?search=NT_SUCCESS&scope=OpenSpecs
Look at results
See error - hits for nt, success.

Expected behavior
Results for the string NT_SUCCESS

@sudeepku Can you please take a look at this issue?


Module caches aren't updated sometimes when using require.context

There seems to be an issue where, if you're using require.context to pull in a glob of files, and are also using caching and re-running the compilation, you get some weird behavior. It takes two compilations for the changes from a module to propagate to the output bundle.
I've created a little reproduction branch on my fork of webpack: https://github.com/diurnalist/webpack/tree/bug/require-context-caching

Ran into this as well. Using webpack with gulp-watch:
gulp.task("webpack:watch", function() {
  watch(["lib/**/*"], function() {
    devCompiler.purgeInputFileSystem();
    gulp.start("webpack:build");
  });
});

Makes more sense for webpack to make that call on each run..

I have ran into this issue as well with gulp watch. Would be good to solve it by calling 'purgeInputFileSystem' internally on each run or maybe at least add 'compiler.purgeInputFileSystem();' to example gulp file here

Maybe it's useful to call purgeInputFileSystem on each run call. Is it possible to do that from within a webpack.config.js?

compiler.plugin('invalid', function(stats) {                 console.log('Purging');                 this.purgeInputFileSystem();             });
Is not convincing the webpack dev server that something has actually changed in one of the files required by require.context..
[WDS] nothing changed


feat(SearchBar): improve focus for search bar

Coverage decreased (-0.2%) to 76.61% when pulling 5dda3cec49b94d57dd0bfdf44b4989bc9051cb50 on Goregius:focus into dd1f33b3a8401222bd0b1c4755891dd28304bd88 on easyops-cn:master.

@Goregius Thanks! But Can you modify your commit message by feat: ...? Since our release-bot can only recognize this format.

I changed that for you, thanks again 🍻


React:    Masthead Overflow feature request

This epic will contain a description of the overall scope, development instructions and links to all of the issues required to complete the work.
Additional Information

Olivia is working on the design.
Planned Schedule

Olivia delivers the designs
Functional specs are documented and reviewed in the Sept 14 engineering meeting for implementation discussions and sizing
Development:  Sprint 20-19
Visual QA:  Sprint 20-20
Prod QA;  Sprint 20-20

Acceptance criteria

[ ] Additional stories are created, if needed, for any work to be done in future sprints.
[ ] Designs and functional specs are reviewed with the DDS developers for sizing and issue refinement.

Here are the functional specs.
https://ibm.box.com/s/h99kmmqe260ibrb8of8pu8rxizemlypt


[BUG] pie::hac::nca::ContentType enum has wrong values

About
In this commit where the code style was changed (https://github.com/jakcron/libpietendo/commit/7dae44a609ce0be0baf231bcbaa4490948366ac7) pie::hac::nca::ContentType didn't survive the transition.
Program,
Meta,
Control,
Manual,
Data,
PublicData

Became:
ContentType_Program = 0,
ContentType_Meta = 2, // <- should be 1
ContentType_Control = 3, // <- should be 2
ContentType_Manual = 4, // <- should be 3
ContentType_Data = 5, // <- should be 4
ContentType_PublicData = 6 // <- should be 5

Requirements

Fix the enum typo

This has been addressed in v0.5.0 of libpietendo.
Please see the release notes here: https://github.com/jakcron/libpietendo/releases/tag/v0.5.0


BGE: Internal Server Error when using Custom Field Mapping in Batch

Thread 1 and 2 from the Hub.
Issue:
Using custom mapped fields in BGE is preventing the batch from being created properly, and giving an Internal Server error.

To Reproduce:

Create a custom date field on the Opportunity, say Custom Date 1, Type of Date, with API Name as Custom_Date_1__c

Create a custom date field on the NPSP Data Import object, say Custom Date 1, Type of Date, and ensure the help text is Opportunity.Custom_Date_1__c

Create a new BGE batch, called Test Batch 1, and only include the standard fields (don't include your new custom date field). Notice the batch saves correctly and you can add New Gifts.

Create a new BGE batch, called Test Batch 2, and include the new Custom Date 1 field. Click save to save/close the batch and note the error. Expected behaviour is that the batch will save and allow data to be entered into the custom mapped fields.

Impact:
This is having an impact on our customers as they cannot save batches that include custom fields.

**lurch: add

Tracking W-032724

Included in beta release 1.0 (Beta 2)


msal-react logout request is getting cancelled. It redirects to home page

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.19.0
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.1.1
Description
When I click on logout button it redirects to application homepage. Microsoft logout url is getting cancelled.
If I manually clear the cookies and try, then it works. Also it works if I manually redirects to Microsoft logout url using window.location.href .
Error Message
No response
Msal Logs
No response
MSAL Configuration
export const msalConfig = {
  auth: {
    clientId: CLIENTID,
    authority:
      'https://login.microsoftonline.com/*****************************',
    redirectUri: window.location.origin,
    postLogoutRedirectUri: window.location.origin,
  },
  cache: {
    cacheLocation: 'localStorage',
    storeAuthStateInCookie: true,
  },
  system: {
    loggerOptions: {
      loggerCallback: (level, message, containsPii) => {
        if (containsPii) {
          return;
        }
        switch (level) {
          case LogLevel.Error:
            break;
          case LogLevel.Info:
            break;
          case LogLevel.Verbose:
            break;
          case LogLevel.Warning:
          default:
            break;
        }
      },
    },
  },
};

Relevant Code Snippets
async function login(instance, handleMSGraph, graphMeInfo) {

  const accounts = instance.getAllAccounts();
  if (accounts.length === 0) {
    sessionStorage.removeItem('accessToken');
    sessionStorage.removeItem('idToken');
    await instance.handleRedirectPromise();
    await instance.loginRedirect();
  } else {
    msalInstance.setActiveAccount(accounts[0]);
    const activeAccount = accounts[0];
    msalInstance.acquireTokenSilent({
      ...loginRequest,
      account: activeAccount,
    }).then((response)=>{
      sessionStorage.setItem('accessToken', response.accessToken);
      sessionStorage.setItem('idToken', response.idToken);
      if(!graphMeInfo.id){
        handleMSGraph();
      }
    }).catch(error => {
      if (error instanceof InteractionRequiredAuthError) {
          // fallback to interaction when silent call fails
          return msalInstance.acquireTokenRedirect(request)
      }
    });
  }

  msalInstance.addEventCallback((message) => {
    console.log(message);
    // if (message.eventType === EventType.LOGIN_SUCCESS) {
    // }
  });
}

const handleLogout = async event => {
      await instance.logoutRedirect(logoutRequest);
};

Reproduction Steps
Trigger logout function.
Expected Behavior
This should ideally redirect to microsoft logout page and user's session should get cleared.
Identity Provider
Azure B2C Basic Policy
Browsers Affected (Select all that apply)
Chrome, Firefox, Edge, Safari
Regression
No response
Source
External (Customer)

@muthurnd3 When you say the logout request is cancelled, do you mean the network request (in your browser's network tab) is showing "cancelled" or it's getting skipped entirely? Can you please share the code that calls your handleLogout function and verbose logs from MSAL? Thanks!

@tnorling  Yes you are right. The network call for logout request is cancelled.

Here is code for logout :
event.preventDefault();
localStorage.clear();
sessionStorage.clear();
msalInstance['browserStorage'].clear();
await instance.logoutRedirect();

@muthurnd3 You have 2 login calls after the logout. The 1st login call is cancelling the logout and the 2nd login is cancelling the first login. Check that your react components aren't re-rendering and unintentionally calling login. You should make sure you always check that inProgress === InteractionStatus.None before calling interactive methods.
Also, you don't need to manually clear local/session storage as the logout APIs do this for you.


TypeScript Codegen - Autogenerated Header, Unquoted AppFeatures Keys

Hello,
I hope it's ok to send over this small proposed change. I found myself wishing the generated types file contained a header marking it as machine-generated.
The other change here might be more controversial. I'm not sure how particular it is to the tooling I'm accustomed to and it seems fraught for the GrowthBook CLI to try to satisfy all parties with the formatting of the generated file. In my case, Prettier/ESLint was catching and fixing the generated type file to remove unnecessary quotes around keys. I figured we could try to generate non-quoted keys where it is safe to do so and fall back to quoted keys if necessary.
It's not a big deal - but I think it's quite popular to avoid quoted keys unless necessary.
Open to your feedback!

Thanks for your contribution.
The header change makes sense. Can you link only to the top-level "Generating Types" on that page? I just realized there's 2 and the 2nd one has a -1 suffix which is not ideal. We will probably change that.
I don't think the quote change makes sense as different ESLint and Prettier configurations will use different quote styles, for example, the main GrowthBook project uses double quotes so we'll still need to have our formatter run over it and make changes, and we do that anyways. If we went with double quotes as the preferred style, you'd still need to do this. I'd prefer to not include that change especially with the added complexity.

@tinahollygb That makes sense and is honestly what I expected to hear. I've removed the formatting change and fixed up the URL. Appreciate the quick review 🙏

Thanks @solomonhawk 🚀

@tinahollygb Is there an upcoming release scheduled that might include this change?

@solomonhawk I just published it now, it should be available, thanks for the reminder.

Thanks a bunch 🎉