Feature Request: Faster Fraction typing

Right now a+b/c gets translated to a+\frac{b}{c}. If one wants to write \frac{a+b}{c} one has to write {a+b}/c. To be faster,
would it be possible to have a+b/c be translated to \frac{a+b}{c} but a+[space]b/c be translated to a+\frac{b}{c}? That way, the bracket typing could be avoided.

Yeah, this is intended behaviour, since if I want to write $a+\frac{b}{c}$ then I can just type a+b/c; I don't have to bother adding a space after the +. I agree it's not ideal when you want to write $\frac{a+b}{c}$!
Sadly I can't think of a clean and simple solution that would allow one to quickly type both $\frac{a+b}{c}$ and $a+\frac{b}{c}$.
I can add a setting where users choose "breaking characters" that distinguish the start of a new fraction. Then, removing the + character from this list would achieve the behaviour you describe.

But wouldnt typing one space in between + and b be faster/more convenient than having to type brackets in the other case? I had a bigger idea in mind that would make typing fractions very convenient:
Whenever one types "/" everything until the most recent space gets inserted in the numerator part of the fraction:
a[space]bc/ -> a\frac{bc}{[cursor]}
abc/ -> \frac{abc}{[cursor]}
a-[space]bc/ -> a-\frac{bc}{[cursor]}
a -bc/ -> a\frac{-bc}{[cursor]}
As the cursor is then in the denominator part of the fraction, there is no similar ambiguity in the denominator that has to be specified, one just types whatever goes into the denominator in the brackets and tabs out (just as now). One problem arises if one wants to put a product of variables and greek letters in the numerator. Without a space in between e.g. \alpha and i (i.e. \alphai) the latex compiler throws an error. Right now, when i type @ai the plugin automatically adds a space in between \alpha and i. If i type @a[space]i, the plugin does not add another space. One could use that behaviour to fix the problem:
@ai -> \alpha[u00A0]i
@a[space]i -> \alpha[space]i
Where [u00A0] is an unbreakable space added by the plugin. That space renders in latex (to my knowledge) just like a normal space. However, by distinguishing between the two kinds of spaces, the plugin knows if both \alpha and i should go in the numerator, or just i. For the user, it is a nobrainer they just know: if space between characters -> breaking of fraction. So for example:
@ai/ -> \alpha[u00A0]i/ -> \frac{\alpha i}{[cursor]}
@a[space]i/ -> \alpha[space]i/ -> \alpha \frac{i}{[cursor]}
Same behaviour could be implemented for \bar or \hat. Everything until the most recent [space] goes under the bar/the hat.
That being said, i am not a pro in programming at all and have no idea if these changes are hard to implement. I just wanted to get the idea out there, your solution sounds good too. Thank you again for all the work the plugin is great.

But wouldnt typing one space in between + and b be faster/more convenient than having to type brackets in the other case?

Yeah, you're completely right! Perhaps I just write $a+\frac{b}{c}$ more often than the other case. I can consider changing the default behaviour.

Whenever one types "/" everything until the most recent space gets inserted in the numerator part of the fraction...

That's an interesting idea. It does seem like it'd make typing fractions very convenient. I can think of a couple small issues though:

When typing @ai, a space is automatically inserted between the a and i, as you say. This is actually achieved via a snippet (as can be seen in the default snippets). So unless we force all users to press the "reset to default snippets" button, all previous users of the plugin will still have the old snippet that inserts a normal space. We want to insert a non-breaking space, but most users will be stuck with the old behaviour.
A space and non-breaking space would look identical to the user, but exhibit slightly different behaviours.
We probably want to use normal spaces in our LaTeX code.

Thank you again for all the work the plugin is great.

No problem, glad you enjoy the plugin :)

I see your point. Could it maybe become an option that one can turn on?

That seems reasonable. It'd take a bit of effort to implement. Maybe in a future release!

sounds good :)

Now that i have thought longer about it i think the unbreakable space approach is probably not necessary. I think it would suffice to be able to decide weather a+b/c should produce a+\frac{b}{c} or \frac{a+b}{c} via a switch in the settings.

I see! I will try to implement this in one of the next releases.

I can add a setting where users choose "breaking characters" that distinguish the start of a new fraction. Then, removing the + character from this list would achieve the behaviour you describe.

This is added in 1.5.2.

Amazing :)


[BUG] Azure Java libs gets several dependencies creating conflicts

Describe the bug
I find Azure SDK Java libs pretty demanding. It has been a constant pain point.
In a larger project, the role of Azure-SDK is not core to what one is trying to build. But quite often it plays a spoilt-sport in creating conflicts, as it brings along several dependencies.
Let's say when we pull in: azure-identity, you can look at the number of dependencies it gets along: https://mvnrepository.com/artifact/com.azure/azure-identity/1.4.3 . It fetches 30+ dependencies to include some popular ones like Netty (and family), Jackson, Guava. These are pretty well-known libraries and usually create conflicts.
This makes us force-fit the above libs versions in our app, to be compatible against what Azure java libs get. And sometimes it is not feasible.
I understand Azure-SDK has tried mitigating problems by releasing BOM. BOM resolves issues within azure's own jars. But in a larger project, where similar dependencies are also fetched, it becomes really difficult to resolve conflicts (particularly netty and jackson related ones). Some of these issues would not have occurred if these dependencies weren't used (Simple ones like Guava, to begin with, are completely avoidable). In fact, Azure's own libs are not very compatible with each other (check references).
Let's do a comparison against AWS.

Name
Number of Dependencies

aws-java-sdk-core
11

azure-storage-blob
31

attached is dependency tree for both (dependencyList.txt)
Suggestion: Minimize external dependencies. Make it lean. Get rid of Netty/jackson and use something else instead. It will increase the adoption.
References:
Some of the challenges that we have faced with Azure Java Libs:

https://github.com/Azure/azure-sdk-for-java/issues/25734#issuecomment-990384836
Synapse due to netty conflicts because of its own dependency. io.netty.handler.ssl.SslProvider can be found at netty-all-4.1.51.Final.jar and TokenLibrary-assembly-1.0.jar . Both are available at runtime, so there is nothing we can do
Synapse Runtime is not compatible with several azure libs like EventGrid etc.
Cases where azure-analytics-synapse-spark is neither compatible with azure-sdk-bom 1.0.6 nor 1.1.0.
Guava and azure-core-http-netty conflicts here: https://stackoverflow.com/a/70738201/894565

Common cause in some of the conflicts above: Netty.

Thank you so much for sharing this, @purijatin.  @pallavit could you follow up with @purijatin on the challenges and suggestions above?

I agree.  Frustrating to use.

Is there some resolution? I am trying to use the Azure libs for Java to use Event Hubs Schema Registry but after hours of various versions of a handful of azure libraries it always ends in a failed Maven build (Stack Overflow error). It seems like there is some endless dependency recursion.


Enable GPU Tracing

Original date: 2018-10-02 03:28:08
Original PR: https://charm.cs.illinois.edu/gerrit/4560

Use NVIDIA's CUPTI Activity API to trace GPU operations.
Change-Id: I1012fde2cad498551ef4264827671f99c2d8f8b0

Converting to draft, will need this for GPU-aware load balancing.

Converting to draft, will need this for GPU-aware load balancing.

Closing for now, revive when needed.


Active?

Is this project still actively maintained?

+1

I'm going to guess no. It hasn't been updated in 7 years


Add ability to define number of working days per year

The simulator is assuming no time off.
Ideally we should be able to take some time off.

True. This should only be relevant when user chooses monthly or daily income I think

In this case, the number of business days per month would be equally reduced/increased for each month? I mean, divide the number of business day per year (set by the user) by the number of months nrMonthsDisplay also set by the user?
Or would there be another way to handle this?
I understand this would be relevant to calculate the monthly and daily-equilavent income.
For example, if the user set 240 days/year, would this mean 20 business days/mo (when 12 months are set)?


Fixed/screenshot on additional sessions

This fixes issue that screenshot on failed cases only with first session not the current one. Now, it will take screenshot of the current one. https://github.com/Codeception/CodeceptJS/issues/1266

Thanks


Update cri-tools.

Update cri-tools to build new crictl into release tarball.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

/test pull-cri-containerd-node-e2e


Update C# readme.

Miscellaneous improvements to C#'s readme.
Fixes #6919.

Only documentation changes.

LGTM


Directory Structure

Right now, the directory structure of the School folder is very convoluted.
As of 9/2/2019, it is: School / <Subject> / <Assignments|Finished>.
I'd like to change it to something more like:
School / Term <number> / <Subject> / <Unit>  / <Assignments|Finished>
This will require rewriting of all the major functions.

Branch created for this.

I also dilsike the way that the user has to split up the directory paths for hoot finish, so I'll change that in this branch as well.

PR Soon.


is latest eesen version very different from eesen-master

when i use the TLG created using eesen-master to decode the model trained on latest version gives a poor WER, can you help me with comments regarding this.

Can you be a bit more specific which code you are using for each of the steps, and which results you are seeing? This is kind of hard to debug! Thanks, Florian

sorry there was a mistake in my system i figured it out. thank you


Want to pick a licence?

First of all, thanks a lot for providing this code, looks super helpful!
Since I wanted to mess around with the code a bit, I was wondering if it is possible to pick a license for the project? I'd assume without a license, forks are legally a gray area due to the default "all rights preserved".

Same! I would like to use some of this code for a research project.

I have added an Apache 2.0 License to reflect the one defined in magenta/ddsp

Thank you so much!


Prepare for 0.9.1 release

With #66 merged, IMHO it is time to release a new minor release so that users who need sftp subsystem can pick up this crate.
Signed-off-by: Jiahao XU<EMAIL_ADDRESS>

This change is


"[!] Unable to find a pod with name matching `YYModel'"

Met this warning when use 'pod search YYModel' command.

Update cocoapods to the latest version.
Run pod update -verbose and see the logs.

If the problem can not be solved, try add this line to your podfile:
pod 'YYModel', :git => 'https://github.com/ibireme/YYModel.git'

pod update -verbose works for me, thank you.


fix viash test bugs

Describe your changes
fix failing component test
Checklist before requesting a review

[x] I have performed a self-review of my code

Check the correct box. Does this PR contain:

[ ] Breaking changes
[ ] New functionality
[ ] Major changes
[ ] Minor changes
[x] Bug fixes

[x] Proposed changes are described in the CHANGELOG.md

[x] CI Tests succeed and look good!

temporary disable label projection test see #207


Make gha-buildevents-step to simplify working with steps

Proposal:
  # install buildevents, captures the start of the build
  # sets env variables: BUILD_ID, STEP_ID, STEP_START
- uses: kvrhdn/gha-buildevents@master
  with:
    apikey: ${{ secrets.BUILDEVENTS_APIKEY }}
    dataset: my-dataset
    job-status: ${{ job.status }}

... do some work here...

  # this will simply call 'buildevents step' for you
- uses: kvrhdn/gha-buildevents-step@master
  with:
    name: initialize

... do some more work here, i.e. build the app...

- uses: kvrhdn/gha-buildevents-step@master
  with:
    name: build-app

... and do some more work here, i.e. deploy the app...

- uses: kvrhdn/gha-buildevents-step@master
  with:
    name: deploy-app

  # end of workflow, gha-buildevents automatically wraps up and builds the trace

Thank you for submitting this issue! In an effort to better respond to new issues, we're closing old, inactive issues like this one. If you feel this issue is still important to consider, please feel free to reopen it.


feat: Ensure services indicate their dependencies through identifiers

As suggested in https://github.com/libp2p/js-libp2p/discussions/2135 In order for services to indicate their dependencies so that consumers can utilize the libp2p stack effectively, we should have each service return a list of other services it requires, which would be verified on startup.
Related: https://github.com/libp2p/js-libp2p/pull/1762

related to https://github.com/libp2p/js-libp2p/issues/2263


Is it possible to bridge to multiple discord accounts?

The readme doesn't really specify.
Thanks for such an awesome tool!

yeah, just run link multiple times with multiple tokens

2021 15:36:42 Joe Hermaszewski @.***>:

The readme doesn't really specify.
Thanks for such an awesome tool!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub[https://github.com/matrix-discord/mx-puppet-discord/issues/157], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AASSEVHNUQNPFKFAAK65V7DTVW6EVANCNFSM47WXYDOQ].
[data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEgAAABICAYAAABV7bNHAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAArSURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAA+DFFIAAEctgHwAAAAAElFTkSuQmCC###24x24:true###][Sledovací obrázek][https://github.com/notifications/beacon/AASSEVB6ET3MPHSUXOM3GVTTVW6EVA5CNFSM47WXYDO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4N6G3JDA.gif]

Great, thanks :)
On Fri, 2 Jul 2021, 11:05 pm Sorunome, @.***> wrote:

yeah, just run link multiple times with multiple tokens

2021 15:36:42 Joe Hermaszewski @.***>:

The readme doesn't really specify.
Thanks for such an awesome tool!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub[
https://github.com/matrix-discord/mx-puppet-discord/issues/157], or
unsubscribe[
https://github.com/notifications/unsubscribe-auth/AASSEVHNUQNPFKFAAK65V7DTVW6EVANCNFSM47WXYDOQ
].

[data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEgAAABICAYAAABV7bNHAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAArSURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAA+DFFIAAEctgHwAAAAAElFTkSuQmCC###24x24:true###][Sledovací
obrázek][
https://github.com/notifications/beacon/AASSEVB6ET3MPHSUXOM3GVTTVW6EVA5CNFSM47WXYDO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4N6G3JDA.gif
]

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/matrix-discord/mx-puppet-discord/issues/157#issuecomment-873066526,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGRJXCPJA3CTV24RYODC4DTVXIS5ANCNFSM47WXYDOQ
.


Wrong property name?

I think in the code example here: run-outside-angular , there is a call to a property that doesn't exist?

Would you open a PR to update?


Add hungarian translation

Hungarian language support for the program. 😃

Thank you for taking the time to add Hungarian translation, it's been appreciated!

I noticed that this PR didn't add the key inside src/constants.py. I've just added that in the latest commit 01b45a0.


Splash Only Returns Timeout When Using Crawlera

Problem
I've been looking at using Splash to render JS-centric pages for scraping.
I am also using Crawlera as a proxy so that I don't have to worry about getting banned from pages.
Unfortunately, these two services do not work together at all and only return timeout errors, regardless of how high I increase the timeout.
This is extremely problematic as it means that I cannot use both services together, even on something as simple as trying to scrape from google.com.
Any help would be appreciated here!
Example Code
The following is my Python code that performs a post request against a Splash instance running in docker on my machine:
import requests

def get_lua_proxy_script():
    with open('proxied_splash_request.lua') as f:
        proxy_script = ''.join(f.readlines())
        return proxy_script

def get_json_args(url, lua_source, timeout):
    return {
        'url': url,
        'lua_source': lua_source,
        'timeout': timeout
    }

print('Reading Lua Script...')
proxy_script = get_lua_proxy_script()
print('Lua Script Read!')
print('Creating JSON Arguments...')
json_args = get_json_args('https://google.com/', proxy_script, 300.0)
print('JSON Arguments Created!')

splash_url = 'http://localhost:8050/execute'
print('Starting Post Request...')
response = requests.post(splash_url, json=json_args)
print('Post Request Completed!')
print(response.text)

And here is the Lua script that I am using, it is the exact one from the example that ScrapingHub provides:
function use_crawlera(splash)
    -- Make sure you pass your Crawlera API key in the 'crawlera_user' arg.
    -- Have a look at the file spiders/quotes-js.py to see how to do it.
    -- Find your Crawlera credentials in https://app.scrapinghub.com/
    local user = '<CRAWLERA-API-KEY>'

    local host = 'proxy.crawlera.com'
    local port = 8010
    local session_header = 'X-Crawlera-Session'
    local session_id = 'create'

    splash:on_request(function (request)
        -- The commented code below can be used to speed up the crawling
        -- process. They filter requests to undesired domains and useless
        -- resources. Uncomment the ones that make sense to your use case
        -- and add your own rules.

        -- Discard requests to advertising and tracking domains.
        if string.find(request.url, 'doubleclick%.net') or
           string.find(request.url, 'analytics%.google%.com') then
            request.abort()
            return
        end

        -- Avoid using Crawlera for subresources fetching to increase crawling
        -- speed. The example below avoids using Crawlera for URLS starting
        -- with 'static.' and the ones ending with '.png'.
        if string.find(request.url, '://static%.') ~= nil or
           string.find(request.url, '%.png$') ~= nil then
            return
        end

        request:set_header('X-Crawlera-Cookies', 'disable')
        request:set_header(session_header, session_id)
        request:set_proxy{host, port, username=user, password=''}
    end)

    splash:on_response_headers(function (response)
        if type(response.headers[session_header]) ~= nil then
            session_id = response.headers[session_header]
        end
    end)
end

function main(splash)
    use_crawlera(splash)
    splash:go(splash.args.url)
    return splash:html()
end

any solution so far?

Have you seen https://support.scrapinghub.com/support/solutions/articles/22000188428-using-crawlera-with-splash-scrapy ?

i'm afraid I've tried it all..no luck so far

I am using crawlera and splash instance on scrapinghub and am having the same issue. 50%-ish of crawlera requests timeout for seemingly no reason. Changing the speed of requests and/or number of requests has no effect on the issue in my experience...

Having same issues as @johndavidsimmons and getting pretty frustrated. Seems like this service is just being left to die which is odd given all the marketing push saying "No need to manage your own scraping and proxy infrastructure ... use ScrapingHub and pay us a whole bunch of money ..."

Has anyone found a solution? If so, would you mind sharing?

Has anyone found a solution? If so, would you mind sharing?

urghh, still no solution for this?


fix: revert pyyaml changes

Issue #, if available:
N/A
Description of changes:
Reverts this: https://github.com/aws/aws-sam-build-images/commit/f8c7b912e4fcf3426f7785128b168a8042d77476
And part of this: https://github.com/aws/aws-sam-build-images/commit/19b58fdefbf5ec45626ec05109d1e5a8c8d1b750
which was added to mitigate the PyYaml issue.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

See: https://github.com/aws/aws-sam-build-images/pull/100


Sourcemaps issue with partial import

Please accept my apologies in advance if this is not the right place to report this.
With the following task:
let cssSrc = "src/**/*.scss";
let cssDest = "dist/styles";

gulp.task("build-css", () => {
    return gulp.src(cssSrc)
        .pipe(sourcemaps.init({debug:true})) //tmp debug
        .pipe(sass().on("error", sass.logError))
        .pipe(sourcemaps.write(".", {debug:true})) //tmp debug
        .pipe(gulp.dest(cssDest));
});

A file /src/a.scss that has @import "b"; will have a map that includes "sources":["a.scss","_b.scss"].
A file /src/app/styles/a.scss that has @import "b"; will have a map that includes "sources":["app/styles/a.scss","_b.scss"].
Which results in:
gulp-sourcemap-write: source file not found: D:\Programming\Projects\x\src\_b.scss
I assume it's supposed to include the full path to _b.scss in sources?

can you reproduce the problem without gulp-sass? Also it would be good to have a small repository with minimal test files to reproduces this.

I'm not able to repro using node-sass directly. Would this be a gulp-sass or gulp-sourcemaps issue?
Sorry. :fearful:

I think it's this.
Closing.


feat(tutorial): complete step 2 - RTP

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

👍 Looks good - 🎉 You are one step closer to completion of the Carbon React tutorial and earning the digital credential.


Editing a farmer report prompts error

Description
Upon clicking a farmer report in the farmer report management page, it displays a null error exception on "farmschool_name" variable.

Reproduction steps

Go to farmer report management page
Click an existing farmer report
See bug

Expected behavior
It should redirect to the edit screen of the farmer report and should display the existing report's details.
Relevant log output
No response
Affected browsers (if applicable)
Chrome

Please verify, @AldwinVergara. Thanks!

The bug is now fixed! Thank you @jg-rivera!


adding getGameHighScores support

This looks perfect to me. Completes the Games implementation in this library. Fixes issues #208 and #203.
Thanks @jishnu7 for keeping your promise. :+1:
Only thing missing now is its accompanying tests. :cry:


Bug: Logout with two clicks

Note: this works.  The only slightly off thing is that on logout you get a toast saying "your session expired" which is a bit strange for the user

Is this happening when it is deployed? When I run the webapp locally, I am
not getting this.
[image: image.png]
On Thu, Mar 30, 2023 at 2:02 PM Dave Horton @.***>
wrote:

Note: this works. The only slightly off thing is that on logout you get a
toast saying "your session expired" which is a bit strange for the user
—
Reply to this email directly, view it on GitHub
https://github.com/jambonz/jambonz-webapp/pull/223#issuecomment-1490182880,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APHFGQQESK4YATNP4VKHL2LW6VY35ANCNFSM6AAAAAAWM5O3W4
.
You are receiving this because you authored the thread.Message ID:
@.***>

well you already gave me a different PR that fixed this


Fixing CF 8.1 refering int types

See issue cf-convention/discuss#202 for discussion of these changes.
Complements #244 #294 #243
Release checklist

[ ] Authors updated in cf-conventions.adoc?
[ ] Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
[ ] history.adoc up to date?
[ ] Conformance document up-to-date?

For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then main always is a draft for the next version.

might be relevant: #374

I think the material changes of this PR has been taken care of in PR #456 related to issue #374. @cofinoa can we close this PR?

Closing this PR because it as been covered by other PRs.


Add config option to set name cook connects to mesos with

Currently cook connects to mesos with name: "cook-". This is fine when there is only one cook connected to that mesos cluster but is confusing when there are multiple. Having a config option to set the name would be much nicer. Bonus points if it still allows a way to add in the git hash.

Completed with #233


[PURCHASE-1519] Fixes issue where the Artwork page would show a refresh animation on re-appear

Tracked here: https://www.notion.so/artsy/When-viewing-a-modal-i-e-the-Attribution-Class-one-going-back-to-the-artwork-page-triggers-a-ref-295d8c5c0d204f748ee1da194fa4c607

Looks good! #mergeongreen


Router accepts anything before /index.php/

Hi,
I've found that, even if I use URL rewriting, I can still access the site using domain/index.php/my/route/url.
Is there a way to disable this ? I think if I want to put an HTTP cache in front of my site, It would store two cache items for one single page. And it leads to duplicate content issues.
I also found that in this case, anyone can create many URLs for a single page. See  http://laravel.com/HELLO-I-AM-THERE/index.php/docs/5.0
Is that a possible bug, or do you have some strategies to avoid this ?
Thank you

This belongs on the foums please, not the bug tracker


SLING-5741 discarding complete ResourceBundleCache in case of JSON di…

…ctionary

@kwin IMO "if" clause is needed to check which bundle does the path (for which event is generated) belongs to.

With the upcoming migration to git this repository will be deleted. If the pull request contains data that should be re-submitted I suggest that you save the changes locally and resubmit them after the migration, which will likely happen on Monday the 9th of October.


wrong type for the body parameter of the grpc directive

Prerequisites

[x] I have checked the existing issues to ensure this is not a duplicate.
[x] I am running the latest version of Tailcall.

Describe the bug
The type for the body parameter of the GRPC directive is string, but the comment around its decleration indicates that static objects should work. I beleve the type should be JSON to support flat objects in the same way that the args parameter for the call directive.
https://github.com/tailcallhq/tailcall/blob/main/generated/.tailcallrc.graphql#L112

/bounty 100$

/attempt

Thanks @nekinie you are right, I think this is a quick fix. BTW have you checkout our auto-generation guide — https://tailcall.run/docs/graphql-configuration-generation-with-tailcall/
It should reduce your onboarding time drastically!

fixed in https://github.com/tailcallhq/tailcall/pull/2383

I gave this a test today and everything looks great, thank you :)


Explicitly set output device in rdpsnd Mac backend

A Royal TSX customer recently alerted me of the fact that Micro Snitch, a microphone monitoring tool for macOS reported that his microphone was active when playing (NOT recording) audio in an RDP session. That happens even when the audin channel is not even loaded so it's definitely a false positive.
I did some debugging and was able to reproduce the behavior. I then found the culprit in this commit.
The problem basically is this: If the output device is NOT explicitly set, AVAudioEngine activates both, input and output channels leading to the behavior that CoreAudio sends notifications of the activation of both devices, even if no audio is recorded through the input channel.
A demo project demonstrating the issue is available here.
The fix is quite easy: Bring back the code that explicitly sets the output device to the default audio output device. Code for this can be found either in the FreeRDP commit I mentioned above or my sample project.

@mfleisz @akallabeth Unfortunately I have to re-open this issue.
After pulling in the changes from https://github.com/FreeRDP/FreeRDP/commit/4d8a4d39ba566f8a5e5f592fcb9559afad8dd42a I'm unable to get any sound output from FreeRDP.
As soon as I comment out the line which explicitly sets the output device (https://github.com/FreeRDP/FreeRDP/commit/4d8a4d39ba566f8a5e5f592fcb9559afad8dd42a#diff-81bf742aadc5d6ed432a42c812d1af2fR170) it starts working again.
I have no clue what's wrong as the code looks good to me and is pretty much the same as before and as in my sample project.
Can you guys reproduce this or do you get sound output with the changes in place?

@lemonmojo currently no 10.15 machine available (only 10.14) but it is working on these for me.

@lemonmojo can you give https://github.com/mfleisz/FreeRDP/tree/mac_rdpsnd_fix a try and see if this works for you? I checked on my Macbook and audio works after adding the AudioUnitGetProperty call (not sure why this fixes the problem but I guess it initializes something internally which is required by the following AudioUnitSetProperty call).

Hm on my Macbook it looks like sound is sometimes working and sometimes it doesn't with this PR. So back to debugging ... :-/

@mfleisz Just tried it but on my iMac Pro I cannot get any sound to play at all using your patch. With an older FreeRDP build (before https://github.com/FreeRDP/FreeRDP/commit/52af56d956e4e725f62030b6c990683158de5733#diff-81bf742aadc5d6ed432a42c812d1af2fL157) the same connection and same audio file plays fine.

@lemonmojo for now I merged a small workaround (https://github.com/FreeRDP/FreeRDP/pull/5811) until we figure a proper way to disable the microphone on Catalina.

@mfleisz Yeah, better than no sound at all. Unfortunately I don’t have enough time to debug this further at the moment. Might be able to continue in a couple of weeks.

I just submitted a ticket for the same issue to the Royal TS team but was referred here. I definitely view it as a potential privacy concern and would love to know that it's not an issue. Any update or plans to roll out the bug fix?

@drewwats unfortunately we currently have no working fix for this issue and I can't tell you when someone of us gets time to have a look at this - sorry ... :-/

@drewwats unfortunately we currently have no working fix for this issue and I can't tell you when someone of us gets time to have a look at this - sorry ... :-/

I see 3 minor updates since the OP's post and not a single item on the release notes should be as high priority as users mic being involuntarily activated. "Visual artifacts" and "improved logging" aren't borderline illegal surveillance.
I use and appreciate your product but I'm also a person that cares about privacy. Please consider getting this moved up on the backlog and possibly requesting mic permissions to cover liability in the meantime.

@mfleisz @akallabeth So I think I found a fix for this. If I move the call to rdpsnd_mac_set_format after creating the AVAudioPlayerNode, sound is playing again and there's no false positive regarding microphone activation.
Could you please check out this patch and see if it works on your hardware as well?

@mfleisz @akallabeth After further testing, this only fixes the problem sometimes. Seems to be some kind of timing problem as I'm sometime able to get sound output and sometimes not.

@lemonmojo I had similar things happen with my initially proposed fix - sometimes it worked but then sometimes it didn't ... :-/

@mfleisz @akallabeth Had another go at this today and think I finally came up with a workable solution.
I stumbled over the following hack on SO: https://stackoverflow.com/a/39936853/1025706
And indeed, if I put a sleep just before starting the AVAudioEngine, sound was playing again and the microphone wasn't activated. So it appears that the engine needs some time for the configuration to "sink in" before starting it and playing anything. Unfortunately, the way it currently works is that the rdpsnd module is only initialized on-demand just before playing a sound, so putting an artificial delay here is not the best idea. ;-)
So I continued debugging. I set a breakpoint in rdpsnd_mac_start and immediately noticed that the engine's isRunning property returned NO which, obviously, is not good if we're just about to play sound.
While I'm still not 100% sure why that happens, I have a workaround which at least on my machine works all the time.
I added a check for AVAudioEngine.isRunning in rdpsnd_mac_start before starting the player and if the engine is not running for whatever reason, I start it "again" at that point. After making that change I have not been able to reproduce the issue anymore. Tried at least 30 times on 3 different Windows hosts and sound started playing every single time.
Here's the patch with the changes: https://gist.github.com/lemonmojo/fb5342e370c331e2c5f6059fae912ba3
Can you please verify if this works for you too?
For a proper fix it would make sense to initialize the rdpsnd module early, before attempting to play any sound to give it enough time to properly start. But for now I guess my solution does the trick.

@lemonmojo Nice finding! I will give the patch a go as soon as I get my hands on my Mac development machine and let you know if it works for me as well!

@mfleisz Thx! FYI: Just tested against some more Windows hosts and on another Mac and still haven't been able to reproduce the issue.

Sounds great - hope this is finally fixed with your patch! 👍

@mfleisz @akallabeth Did you get the chance to test my patch? Would love to see this being fixed for good...

@lemonmojo Finally had time to give this a go - works like a charm! Can you submit a PR so we can get this finally fixed? Thanks a lot for your contribution! 👍

@mfleisz Here ya go: https://github.com/FreeRDP/FreeRDP/pull/6467


Improve message for cyclic dependencies

Related problem
When a component has a cyclic (constructor) dependency which cannot be resolved, a CyclicComponentException is thrown. This formats the error message as .. path: ComponentA -> ComponentB -> ComponentC -> ..., see:
https://github.com/Dockbox-OSS/Hartshorn/blob/6b532c535ea5b0d875289c10226f1c736b5a4390/hartshorn-core/src/main/java/org/dockbox/hartshorn/inject/CyclicComponentException.java#L27-L29
This is fine when there are only a few components in the path, but quickly becomes unreadable when the path is longer. Additionally, this does not display the full type, but only the name. As a result ambiguity may arise when inspecting the cause of these exceptions.
Requested feature
Re-format the message to display the cyclic path more clearly, this should be done in two steps:

Display the qualified name of the types, instead of just their simple name (e.g. com.example.components.ComponentA instead of ComponentA)
Display the cyclic path vertically instead of horizontally, to make better use of screen space when long paths occur

For example:
Cyclic dependency detected in constructor of ComponentA. Complete dependency path:
 ┌───┐
 |  com.example.components.ComponentA
 ↑   ↓
 |  com.example.components.ComponentB
 ↑   ↓
 |  com.example.components.ComponentC
 ↑   ↓
 |  com.example.components.ComponentD
 ↑   ↓
 |  com.example.components.ComponentE
 └───┘

Resolved in #988


Validation: Add missing author

This PR addresses missing author and description metadata.

Docs Build status updates of commit bbe6bee:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/webapi/Alternate-Key.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/abstract-entity-types.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/action-parameter-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/attribute-routing.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/Alternate-Key.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/abstract-entity-types.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/action-parameter-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/attribute-routing.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 871be2d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/webapi/Alternate-Key.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/DeltaFeed_support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/abstract-entity-types.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/action-parameter-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/attribute-routing.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/autoexpand-attribute.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/basic-auth.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/batch.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/bind-custom-urifunctions-to-clr-methods.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/built-in-routing-conventions.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/capabilities-vocabulary-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/concurrencymode-and-etag.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/continue-on-error.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/convention-model-builder.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/custom-routing-convention.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/custom-url-parsing.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/date-and-timeofday-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/datetime-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/ComplexTypeWithNavigationProperty.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/caseInsensitiveAndQualifiedFunctions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/customize-formatter.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/date-timeofday-with-entity-framework.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/debugging.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/Alternate-Key.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/DeltaFeed_support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/abstract-entity-types.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/action-parameter-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/attribute-routing.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/autoexpand-attribute.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/basic-auth.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/batch.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/bind-custom-urifunctions-to-clr-methods.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/built-in-routing-conventions.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/capabilities-vocabulary-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/concurrencymode-and-etag.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/continue-on-error.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/convention-model-builder.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'convention model builder' is duplicated in 'webapi/convention-model-builder.md(3,14)', 'webapi/model-builder-abstract.md(3,14)', 'webapi/model-builder-nonconvention.md(3,14)', 'webapi/model-builder-untyped.md(3,14)'.

Odata-docs/webapi/custom-routing-convention.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/custom-url-parsing.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/date-and-timeofday-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/datetime-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 188d731:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/webapi/Alternate-Key.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/DeltaFeed_support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/abstract-entity-types.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/action-parameter-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/attribute-routing.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/autoexpand-attribute.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/basic-auth.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/batch.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/bind-custom-urifunctions-to-clr-methods.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/built-in-routing-conventions.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/capabilities-vocabulary-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/concurrencymode-and-etag.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/continue-on-error.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/convention-model-builder.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/custom-routing-convention.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/custom-url-parsing.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/date-and-timeofday-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/datetime-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/filter-in-expand.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/function-parameter-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/getting-started.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/httpRequest-message-extension-method.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/ComplexTypeWithNavigationProperty.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DependencyInjection.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/caseInsensitiveAndQualifiedFunctions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/customize-formatter.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/date-timeofday-with-entity-framework.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/debugging.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/enable-no-dollar-queryoptions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/Alternate-Key.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/DeltaFeed_support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/abstract-entity-types.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/action-parameter-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/attribute-routing.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/autoexpand-attribute.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/basic-auth.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/batch.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/bind-custom-urifunctions-to-clr-methods.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/built-in-routing-conventions.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/capabilities-vocabulary-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/concurrencymode-and-etag.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/continue-on-error.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/convention-model-builder.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'convention model builder' is duplicated in 'webapi/convention-model-builder.md(3,14)', 'webapi/model-builder-abstract.md(3,14)', 'webapi/model-builder-nonconvention.md(3,14)', 'webapi/model-builder-untyped.md(3,14)'.

Odata-docs/webapi/custom-routing-convention.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/custom-url-parsing.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/date-and-timeofday-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/datetime-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/filter-in-expand.md

Line 3, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/function-parameter-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/getting-started.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/httpRequest-message-extension-method.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f12371a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/webapi/Alternate-Key.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/DeltaFeed_support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/abstract-entity-types.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/action-parameter-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/attribute-routing.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/autoexpand-attribute.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/basic-auth.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/batch.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/bind-custom-urifunctions-to-clr-methods.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/built-in-routing-conventions.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/capabilities-vocabulary-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/concurrencymode-and-etag.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/continue-on-error.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/convention-model-builder.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/custom-routing-convention.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/custom-url-parsing.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/date-and-timeofday-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/datetime-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/filter-in-expand.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/function-parameter-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/getting-started.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/httpRequest-message-extension-method.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/ComplexTypeWithNavigationProperty.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DependencyInjection.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/caseInsensitiveAndQualifiedFunctions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/customize-formatter.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/date-timeofday-with-entity-framework.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/debugging.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/enable-no-dollar-queryoptions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/Alternate-Key.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/DeltaFeed_support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/abstract-entity-types.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/action-parameter-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/attribute-routing.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/autoexpand-attribute.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/basic-auth.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/batch.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/bind-custom-urifunctions-to-clr-methods.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/built-in-routing-conventions.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/capabilities-vocabulary-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/concurrencymode-and-etag.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/continue-on-error.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/convention-model-builder.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'convention model builder' is duplicated in 'webapi/convention-model-builder.md(3,14)', 'webapi/model-builder-abstract.md(3,14)', 'webapi/model-builder-nonconvention.md(3,14)', 'webapi/model-builder-untyped.md(3,14)'.

Odata-docs/webapi/custom-routing-convention.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/custom-url-parsing.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/date-and-timeofday-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/datetime-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/filter-in-expand.md

Line 3, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/function-parameter-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/getting-started.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/httpRequest-message-extension-method.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d7014a9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/webapi/basic-auth.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/batch.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/bind-custom-urifunctions-to-clr-methods.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/built-in-routing-conventions.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/capabilities-vocabulary-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/concurrencymode-and-etag.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/continue-on-error.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/convention-model-builder.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/custom-routing-convention.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/custom-url-parsing.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/date-and-timeofday-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/datetime-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/filter-in-expand.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/function-parameter-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/getting-started.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/httpRequest-message-extension-method.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/Alternate-Key.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/ComplexTypeWithNavigationProperty.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DeltaFeed_support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DependencyInjection.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/abstract-entity-types.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/action-parameter-support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/attribute-routing.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/autoexpand-attribute.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/caseInsensitiveAndQualifiedFunctions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/customize-formatter.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/date-timeofday-with-entity-framework.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/debugging.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/enable-no-dollar-queryoptions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/basic-auth.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/batch.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/bind-custom-urifunctions-to-clr-methods.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/built-in-routing-conventions.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/capabilities-vocabulary-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/concurrencymode-and-etag.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/continue-on-error.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/convention-model-builder.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'convention model builder' is duplicated in 'webapi/convention-model-builder.md(3,14)', 'webapi/model-builder-abstract.md(3,14)', 'webapi/model-builder-nonconvention.md(3,14)', 'webapi/model-builder-untyped.md(3,14)'.

Odata-docs/webapi/custom-routing-convention.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

Odata-docs/webapi/custom-url-parsing.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/date-and-timeofday-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/datetime-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/filter-in-expand.md

Line 3, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/function-parameter-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/getting-started.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/httpRequest-message-extension-method.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 0ce4abe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/webapi/date-and-timeofday-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/function-parameter-support.md
:bulb:Suggestion
View
Details

Odata-docs/webapi/Alternate-Key.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/ComplexTypeWithNavigationProperty.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DeltaFeed_support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DependencyInjection.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/abstract-entity-types.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/action-parameter-support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/attribute-routing.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/autoexpand-attribute.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/basic-auth.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/batch.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/bind-custom-urifunctions-to-clr-methods.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/built-in-routing-conventions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/capabilities-vocabulary-support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/caseInsensitiveAndQualifiedFunctions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/concurrencymode-and-etag.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/continue-on-error.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/convention-model-builder.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/custom-routing-convention.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/custom-url-parsing.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/customize-formatter.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/date-timeofday-with-entity-framework.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/datetime-support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/debugging.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/enable-no-dollar-queryoptions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/filter-in-expand.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/getting-started.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/httpRequest-message-extension-method.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/date-and-timeofday-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/webapi/function-parameter-support.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 40c8d81:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/webapi/Alternate-Key.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/ComplexTypeWithNavigationProperty.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DeltaFeed_support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DependencyInjection.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/abstract-entity-types.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/action-parameter-support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/add-nextpage-link-and-count-for-collection-property.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/attribute-routing.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/autoexpand-attribute.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/basic-auth.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/batch.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/bind-custom-urifunctions-to-clr-methods.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/built-in-routing-conventions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/capabilities-vocabulary-support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/caseInsensitiveAndQualifiedFunctions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/concurrencymode-and-etag.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/continue-on-error.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/convention-model-builder.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/custom-routing-convention.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/custom-url-parsing.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/customize-formatter.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/date-and-timeofday-support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/date-timeofday-with-entity-framework.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/datetime-support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/debugging.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/enable-no-dollar-queryoptions.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/filter-in-expand.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/function-parameter-support.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/getting-started.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/httpRequest-message-extension-method.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@xuzhg
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!

Looks good to me. Merged it.


[Navigation Material] Crash in BottomSheetNavigator when user goes back

We have some crashes that, as far as I can see when looking at the logs, happen when a user goes back on any of our bottom modals. The version of Navigation Material library we currently use is 0.32.0. I looked into the newest version (0.34.0) and by looking into the code I think we would have the same crashes with that version too, even though the code changed to some degree.
I tried a lot of ways to reproduce this crash, but I didn't succeed in reproducing it. That's why I can't know for sure why this happens and what is the edge case that keeps popping up. This crash happens to around 1% of our users, so it's not that uncommon.
This is the crash stack trace:
Fatal Exception: java.lang.NullPointerException
com.google.accompanist.navigation.material.BottomSheetNavigator$sheetContent$1$2.invoke (BottomSheetNavigator.kt:224)
com.google.accompanist.navigation.material.BottomSheetNavigator$sheetContent$1$2.invoke (BottomSheetNavigator.kt:223)
androidx.activity.compose.BackHandlerKt$BackHandler$backCallback$1$1.handleOnBackPressed (BackHandler.kt:89)
androidx.activity.OnBackPressedDispatcher.onBackPressed (OnBackPressedDispatcher.kt:276)
androidx.activity.ComponentActivity.onBackPressed (ComponentActivity.java:678)
android.app.Activity.onKeyUp (Activity.java:3976)
android.view.KeyEvent.dispatch (KeyEvent.java:2925)
android.app.Activity.dispatchKeyEvent (Activity.java:4329)
androidx.core.app.ComponentActivity.superDispatchKeyEvent (ComponentActivity.java:120)
androidx.core.view.KeyEventDispatcher.dispatchKeyEvent (KeyEventDispatcher.java:85)
androidx.core.app.ComponentActivity.dispatchKeyEvent (ComponentActivity.java:138)
com.android.internal.policy.DecorView.dispatchKeyEvent (DecorView.java:420)
android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent (ViewRootImpl.java:6735)
android.view.ViewRootImpl$ViewPostImeInputStage.onProcess (ViewRootImpl.java:6601)
android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:6059)
android.view.ViewRootImpl$InputStage.onDeliverToNext (ViewRootImpl.java:6116)
android.view.ViewRootImpl$InputStage.forward (ViewRootImpl.java:6082)
android.view.ViewRootImpl$AsyncInputStage.forward (ViewRootImpl.java:6247)
android.view.ViewRootImpl$InputStage.apply (ViewRootImpl.java:6090)
android.view.ViewRootImpl$AsyncInputStage.apply (ViewRootImpl.java:6304)
android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:6063)
android.view.ViewRootImpl$InputStage.onDeliverToNext (ViewRootImpl.java:6116)
android.view.ViewRootImpl$InputStage.forward (ViewRootImpl.java:6082)
android.view.ViewRootImpl$InputStage.apply (ViewRootImpl.java:6090)
android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:6063)
android.view.ViewRootImpl$InputStage.onDeliverToNext (ViewRootImpl.java:6116)
android.view.ViewRootImpl$InputStage.forward (ViewRootImpl.java:6082)
android.view.ViewRootImpl$AsyncInputStage.forward (ViewRootImpl.java:6280)
android.view.ViewRootImpl$ImeInputStage.onFinishedInputEvent (ViewRootImpl.java:6460)
android.view.inputmethod.InputMethodManager$PendingEvent.run (InputMethodManager.java:3708)
android.view.inputmethod.InputMethodManager.invokeFinishedInputEventCallback (InputMethodManager.java:3217)
android.view.inputmethod.InputMethodManager.finishedInputEvent (InputMethodManager.java:3208)
android.view.inputmethod.InputMethodManager$ImeInputEventSender.onInputEventFinished (InputMethodManager.java:3685)
android.view.InputEventSender.dispatchInputEventFinished (InputEventSender.java:154)
android.os.MessageQueue.nativePollOnce (MessageQueue.java)
android.os.MessageQueue.next (MessageQueue.java:342)
android.os.Looper.loopOnce (Looper.java:182)
android.os.Looper.loop (Looper.java:357)
android.app.ActivityThread.main (ActivityThread.java:8088)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:957)

As can be seen in the stack trace above, the crash happens when executing these lines:
BackHandler(retainedEntry != null) {
    state.popWithTransition(retainedEntry!!, false)
}

This crash doesn't make sense to me, since state.popWithTransition(retainedEntry!!, false) shouldn't execute if retainedEntry is null. Can someone please look into this and check if it can be fixed by adding an additional check inside of BackHandler?

Attempting to fix this here 🙏🏼

With the release of Compose Material 1.7.0-alpha04, the Material team has added a new artifact: androidx.compose.material:material-navigation, which fully replaces Accompanist Navigation Material.
As such, we are closing all issues here on Accompanist and will be fully deprecating Accompanist Navigation Material in an upcoming release.
A number of issues were fixed as part of the migration, but if you're still seeing an issue, please file an issue with a sample project that reproduces your issue and the Material team will take a look.

Since the issue is present in Compose Material 1.7.0-alpha04 too, can it be moved over?


Failing to recognize MacOS 11.0 beta 3

Apple has changed the xml file with Big Sur beta 3 and is reporting 11.0 instead of 10.16. This is causing the OS check line 110 to fail. I added a secondary check and it seems to work.
if [[ "$installer_qualifies" -lt 1012 ]] && [[ $macOS11 -eq 0 ]]; then
Edit: I just checked the dmg and realized it was empty. I am getting an error when trying to mount empty disk image:
hdiutil: attach failed - Resource busy /Volumes/C1EF3958-1C88-47F1-809D-346D1950BFB7 is not a valid volume mount point.

Updated script to address both the OS and disk sizing issues.


Carousel Responsive Issue In Chrome

Hello there,
I have created a Carousel and when responsive in Chrome it squashes the image rather than scale down. Does anyone else have this issue? This is happening on all my desktop devices in Chrome.
Here is an image to highlight it.
http://imgur.com/a/5lOr8
This is also happening on BS4 doc Carousel page:
https://v4-alpha.getbootstrap.com/components/carousel/#options
Cheers

Same as #21611 I think.

Yes thanks it is and you have helped me. Thanks so much. This should be fixed tho right??

This should be fixed tho right??

I hope they fixe. In my opinion they should, but it's not added to milestone v4.0.0-beta yet...
I have just added an example on JSFiddle too, in case they want that.

Wicked, yeah they should at some point do that. What is the link to the fiddle if you do not mind me asking? Cheers.

It's in my last post at #21611 ofcourse, but is: https://jsfiddle.net/josmaissan/5jsonocq/15/

24 Feb 17
Confirm the carousel "image squashing" is still an issue, on Chrome Version 56.0.2924.87 (Windows 7)
Carousel worked fine in A5.
To demo:

Go to URL:
https://v4-alpha.getbootstrap.com/components/carousel/
Narrow the viewport
Observe the image crush. Images do not resize.

@kwhdever Your right! #21611 is still open. 😉


Slider changes activity colorPrimaryDark to transparent

Because slider's progress circle nail based on dialog with translucent theme it changes colorPrimaryDark above ActionBar and a can do nothing with it.

fixed. Replace Theme_Translucent style by my own Dialog theme with this parameters:
@color/blue_1
@color/blue_1_semitransparent
@color/blue_1
May be it will help someone

also you can replace Theme_Translucent style in values-v21 like this


[doc] Create readme

Created a basic readme for you. Lemme know if you want changes.

Should probably add some info about how you would like contributions to be submitted. Ex. message you on reddit? Open a PR on github? Send to an email address?

Hey thanks for compiling all the information together!
It would probably make sense to open an issue first and say you are working on it so no one works on the same thing. You could probably just open a PR here


[turborepo] turbo prune ${APP_NAME} --docker doesn't generate out/full/ directory

What version of Turborepo are you using?
1.10.14
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Describe the Bug
Hello
I wanted to build a app as a docker image, I faced an error.
Here's my part of a Dockerfile
...

FROM base AS builder
RUN apk add --no-cache libc6-compat
RUN apk update

WORKDIR /app
RUN pnpm add --global turbo
COPY . .
RUN turbo prune ${APP_NAME} --docker

FROM base AS installer
RUN apk add --no-cache libc6-compat
RUN apk update
WORKDIR /app

COPY .gitignore .gitignore
COPY --from=builder /app/out/json/ .
COPY --from=builder /app/out/pnpm-lock.yaml ./pnpm-lock.yaml
RUN pnpm install

COPY --from=builder /app/out/full/ .
COPY turbo.json turbo.json

RUN pnpm turbo run build --filter=${APP_NAME}...

...

CMD PORT=3001 node apps/themoney/server.js

build with a command docker-compose -f docker-compose.yml build
That showing a error message below.
=> ERROR [${APP_NAME} installer  8/10] COPY --from=builder /app/out/full/ .

failed to solve: cannot copy to non-directory: /var/lib/docker/overlay2/jyeh57zocu3oubs242uhygyyv/merged/app/apps/${APP_NAME}/node_modules/${MY_PACKAGE}

BUT I removed the flag --docker in turbo prune. and changed COPY --from=builder /app/out/full/ . to COPY --from=builder /app/out/ .
It was worked clearly
Expected Behavior
Build a docker image
❌ (failed to build)
turbo prune ${APP_NAME} --docker

COPY --from=builder /app/out/full/ .

✅ (success to build)
turbo prune ${APP_NAME}

COPY --from=builder /app/out/ .

To Reproduce
https://github.com/AshtonYoon/turbo-prune-docker-reproduce
sample repoduce repo,
clone and run
docker compose build

you can see a error message like this
thank you for reading
Reproduction Repo
https://github.com/AshtonYoon/turbo-prune-docker-reproduce

Duplicate of:

#5462
#1997

See https://github.com/vercel/turbo/issues/1997#issuecomment-1273565773 to resolve:
Add **/node_modules to your .dockerignore.

Closing in favor of #1997

I has solved by https://github.com/vercel/turbo/issues/1997#issuecomment-1273565773.
Thank you for fast responding!!


Observables cannot be passed between window contexts.

RxJS version: 5.4
Code to reproduce:
if (window.opener) {
  window.myObservable = window.opener.myObservable;
} else {
  window.myObservable = Rx.Observable.of(1, 2, 3);
  window.open(location.href);
}

window.myObservable
  .switchMap(function(x) {
    return Rx.Observable.of(x);
  })
  .subscribe(function(x) {
    console.log(x);
  });

Expected behavior:
Both parent and child window should print 1, 2, 3 to the console.
Actual behavior:
The child window throws an exception because myObservable from the parent window's context cannot be identified as an Observable in the child window's context.
Additional information:
The issue is caused by a reliance on instanceof for determining if an object is an Observable which fails for objects passed between javascript contexts. Instead, a more robust solution would test for the shape of an Observable, perhaps using a type guard similar to isPromise

I'm feeling kind of similar to what bacon.js did. Checking properties in observable is not robust way (yes, even isPromise is same but promise is external dependency we can't control). My 5 cent is adding same description as bacon.js and let consumer should deliver instances between.

At the end of the issue I referenced, bacon.js accepted a PR which eliminated the use of instanceof for testing Observable identity. After a quick browse at their HEAD, master still seems to have those changes incorporated.
Also, this project already acknowledges the interop point defined by the es7-observable spec, which I interpret as implying compatibility with external implementations of Observable. Currently, such compatibility is broken due to use of instanceof.

I agree that we should rely less on instanceof and use duck-typing. I know it's not robust, but JavaScript itself isn't robust.

@goldsam @staltz I agree with the changes proposed here.  We should be relying on the subscribe method here much as the Promise relies on then.  The usage of instanceof is far from ideal here and shouldn't really be used.

When instrumenting Rx for RxFiddle i've stumbled on this issue too. RxFiddle possibly uses a different instance of Rx than the instrumented target, which might be a small minified and treeshaken module that contains a small subset of Rx. I've not really settled how to solve solve it. For now I just use only the types of Rx (import * as RxType from "rxjs") and make sure that the instrumentation module not actually uses RxType other than as a type. The I just take the provided Rx object or the globally available Rx object (window.Rx) to apply instanceof.
I agree with @goldsam however that Rx should interop with the es6 Observables just out of the box and by only looking at the contract (subscribe, next, error, complete).

We should be relying on the subscribe method here much as the Promise relies on then. The usage of instanceof is far from ideal here and shouldn't really be used.

Actually we should not rely on subscribe for duck typing. That's an ES Observable method, and there many other libraries that support the ES Observable interface, such as Most.js, xstream, Kefir. Under duck typing, all those streams from those libraries would be considered RxJS Observables. This would actually break real software for people using Cycle.js which allows both RxJS and xstream co-existing.
I'd argue for using a combination such as checking for lift plus subscribe, or _isScalar.

The idea of Rx is to have a subscribe method on the Observable taking an Observer with a next, error and complete method. As long as you put in something that works with that we should be fine right?
In what cases does Rx use instanceof? Mostly in cases where we need to check whether we can use some optimization?
Why should Rx not work directly with Most, xstream, etc?

Why should Rx not work directly with Most, xstream, etc?

@hermanbanken through the ES Observable spec it indeed does work directly. The problem is when a window context receiving an Observable expects that Observable to be a real RxJS v5 Observable including things like the lift method. If that window context assumes that lift exists on the Observable, because ES Observable doesn't prescribe lift, then that window context will break if it receives an ES Observable from Most or xstream. In other words, RxJS Observable != ES Observable. You can pass ES Observables safely between window contexts, but you cannot pass RxJS Observables safely between window contexts, even if every Rx Observable is an ES Observable.

I might not have been clear.

The problem is when a window context receiving an Observable expects that Observable to be a real RxJS v5 Observable

When does this occur? The original question gives this example:
window.myObservable
  .switchMap(function(x) {
    return Rx.Observable.of(x);
  })
  .subscribe(function(x) {
    console.log(x);
  });

here we see that it is switchMap receiving a foreign object.

including things like the lift method

The only thing that switchMap needs to verify is that Rx.Observable.of(x) has a subscribe method, is a Promise or is convertible to an Observable in some way. It does not need to have lift, it only needs subscribe.
I think the danger comes from use cases like this:
import map from "rxjs/operators/map"

let mappedOnce = window.parent.myObservable.map(x => x * x)
let mappedTwice = map.call(mappedOnce, x => x + 1)

That way two unrelated (by prototype) Observables are joined by creating one with composed selectors. Users of rxjs need to know how map is implemented in that case to understand what scope mappedTwice belongs to.

@hermanbanken I'm not so sure I understand, pardon me if I say something that doesn't make sense.
As far as I understand,
window.myObservable
  .switchMap(function(x) {
    return Rx.Observable.of(x); // <----- this line
  })
  .subscribe(function(x) {
    console.log(x);
  });

runs in the same window context as the switchMap:
window.myObservable
  .switchMap(function(x) { // <----- this operator
    return Rx.Observable.of(x);
  })
  .subscribe(function(x) {
    console.log(x);
  });

and the switchMap receives window.myObservable as the source Observable, which is the this here, expected to have the lift method.

They run in the same window context, but originate from a different window I believe. Let's differentiate between window A and window B, with A.opener == B.
The window.myObservable is from context B (window.myObservable = window.opener.myObservable;) and the switchMap method is as a result from the prototype of Observable from context B.
window.myObservable  // <---- from context B
  .switchMap(function(x) {  // <---- from context B
    return Rx.Observable.of(x); // <----- run in window A, using Rx from context A
  })
  .subscribe(function(x) {
    console.log(x);
  });

switchMap uses lift from context B because it's prototype is from B.
Or am I mistaken?

Understood, you're correct. And I just went through many operators and I don't think we will have a case where we would need to duck-type check for the existence of lift.

Ah good to see that I was not just going crazy 😜 .
I think this is related to #2489 too, since things would get more complicated if we do this:
import switchMap from 'rxjs/somewhere/switchMap'

window.myObservable  // <---- from context B, previously assigned
  .pipe(switchMap(function(x) {  // <---- from context B
    let X = Rx.Observable.of(x); // <----- run in window A, using Rx from context A
    return X;
  }))
  .subscribe(function(x) {
    console.log(x);
  });

at that point switchMap is from context B and for everything done during the setup phase of the Observable it can only assume valid what is from context B, while it is asked to work on something from context A, through pipe.

A few things:

instanceof checking is much faster than property look-ups.
We'd need to check for more than just subscribe here. The instanceof check ensures that this is an Observable from the same library with all of the same properties... this includes optimizations like _isScalar, and the presence of important pieces of infrastructure like lift. And even if so, there's no guarantee it's the same version with the same semantics.

You can solve the problem outlined in your original post with a simple Observable.from:
if (window.opener) {
  window.myObservable = Rx.Observable.from(window.opener.myObservable);
} else {
  window.myObservable = Rx.Observable.of(1, 2, 3);
  window.open(location.href);
}

Covering this corner case that has a simple workaround is probably not worth the performance cost.

@benlesh Observable.from has a problem similar to the original issue due to the observable symbol not evaluating equal across window contexts. The first conditional in the following excerpt from FromObservable.ts below always evaluates false:
...
if (typeof ish[observable_1.observable] === 'function') {
  if (ish instanceof Observable_1.Observable && !scheduler) {
    return ish;
  }
  return new FromObservable(ish, scheduler);
} ...

Do you see a way to easily work around this without library support?

@benlesh Any help on this would be appreciated, trying to get the exact same piece work for my app - ng4.0, rxjs 5.0.2


Implement Better Discord Errors

Summary
This PR implements parsing of the JSON error messages received by discord, it also deprecates ApplicationCommandException as this is no longer needed.
This PR makes major changes to the HttpException including:

Changing Error to Errors and changing the type of it to IReadOnlyCollection<DiscordJsonError>.
Changing the type of DiscordCode from int? to DiscordErrorCode

The DiscordErrorCode enum is kept up to date with the Official docs, it contains all the error codes and is parsed thru the request bucket.
The DiscordJsonError class contains a path of the json as well as a string message and code that tells the executer what went wrong with the request.

Fun


az login never happens even after disabling all the security tools

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Related command

Describe the bug

To Reproduce

Expected behavior

Environment summary

Additional context

The login never happens after I installed the latest version of AZ CLI (2.42.0), downloaded from the official site.
After the security code is generated, the prompt remains forever like shown in the image.

I encountered a similar issue on wsl2,  there are no outputs and no browser opened.

I use this as a workaround, 'az login --use-device-code'

@dylanw-oss but this is a workaround, and not a solution. I could use the device code to login. But it is a genuine issue which we have to accept.

I can't reproduce.
The error image indicates that your browser failed to open locahost:3565 as https page. In fact, it's a http page.
Can you copy the url to see if it's http or https?
I guess it's a browser or anti-virus app setting problem.

@bebound I tried both HTTP and HTTPS with the same port, after disabling the firewall, anti-virus and all other software. I had the same error.

@sesa577179  When the page redirect to localhost:xxxxx, if you copy the url from address bar, it starts with http or https?

It starts with http.

Maybe your browser used to open another https://localhost page, and bowser remember it as a HTTPS website.
Can you clear the browser cache using below method and try again?
https://stackoverflow.com/a/60561350/2251785


Clientd

Did clean up stuff by writing it again but use decent commits this time. I'm not quite sure if my get_active_issuances in mint/mod makes sense because theres already a list_active_issuances but I needed  CoinFinalizationData rather than OutPoint (if anybody sees how to sum up pending transactions and get the total 'value' with OutPoint I can remove this. Also I still used StructOpt because I thought it would be better refactoring to clap in one PR for all files istead of file by file (if this is even wanted, I heard that it is advised to switch)

just fyi : I just noticed that the API design is extremely bad and want to refactor it all using this as a reference :
https://www.jsonrpc.org/specification
https://www.youtube.com/watch?v=yobsLtsMPL8&list=WL&index=1
takes longer than expected tho because the rust I'll need for that is kind of a leap for my current skill

just fyi : I just noticed that the API design is extremely bad and want to refactor it all using this as a reference :

Ah, had missed that comment

I just noticed it would be a bad idea to work on the jsonrpc-client in this branch/PR so I'll remove (https://github.com/fedimint/minimint/pull/55/commits/730e77699cdb736afeaf65b380f328c5f46d5adc) in a later rebase. I'd like to get feedback on how I want to approach things from now:
In the end the mint-client crate should look like this:
---src
   ---bin
      ---clientd
            ---main.rs
            ---lib.rs
      ---cli
            ---main.rs
            ---lib.rs
   ---jsonrpc
            ---clients.rs  <-- the client which makes https requests to the server doMethod()
            ---json.rs  <-- holds data structures for interacting with the API, Request/Response and also API Results (not API Errors)
            ---error.rs  <-- organizes errors (RpcError, JsonError, RPCClientError ..?)
   --- (...)

The now existing rpc crate would be removed and the 'router' would move to clientd/lib, the Request/Response structs would move in jsonrpc/json and the StandartError/RpcError would move in jsonrpc/error. Also the data structures for the API results (and some others) would also move in jsonrpc/json (right now in clients/user.rs).
I'll start a new jsonrpc branch for this and later also an jsonrpc-cli branch. I'd love to hear feedback on my organization approach since I'm still very confused on where to put things.
Also just fyi: I'll try to use https://github.com/apoelstra/rust-jsonrpc as the main 'role model' for the jsonrpc

Opening another clientd PR soon


Overwriting scene using "save as scene" causes node to get replaced with existing scene

Operating system or device - Godot version:
Windows 7, godot ver 2.1.2
Issue description:

Tried to save node as a scene, given prompt "scene exists, overwrite?", chose to overwrite, node I tried to save was replaced. Unable to recover lost data.
Steps to reproduce:
Follow steps above
Link to minimal example project:

I wasn't able to reproduce this on W10, Godot 2.1.3.

Ah it seems that the save isn't outputting, it should be mentioned that if you use save as it doesn't load the scene from the file deleting your work (which is what I thought was being described). Rather if you then open the saved file it was never overwritten.

I was unable to reproduce with the given steps on Linux.
Having the other scene opened and modified, sometimes, showed the previous on the tree (solved by changing tabs to update the tree).

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about its current status here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

I tested on v3.0.2.stable.mono.official on W10 and everything was working as expected.

Created a new scene
Added a 2DNode to the scene
Saved the scene
Replaced the 2DNode with a Node and a child Control component
Used the save as feature overwriting the previously saved scene
Closed the scene
Reloaded the scene from the saved file
The scene showed a Node with a child Control component and not a 2DNode.

@Renari thank you for testing this! Closing, if anyone still have the problem please let us know.