Logtext first implementation

tensorboard frontend takes care of rendering markdown. We only need to log the String.
This is how it looks:

@PhilipVinc  Please elaborate on how you'd like to handle matrices and lists of Strings. Should matrix be converted to a table in markdown?

Cool
The following should be of interest:
https://discourse.julialang.org/t/how-to-get-a-markdown-repr-of-an-object-mime-type-fallbacks/23242
Right now the best solution I have is at the bottom, and that solution is Ok.
not great, but Ok.  Might be the best that is possible with people writing poorly behaved repr implementations.

Nice!
Does it also work if in the string you've got some Unicode symbols/emojis?
Right now you only defined the function text_summary(....text::String, ...). I think it would be a good idea to also define a more general function to convert arbitrary types to strings.
function text_summary(name::String, text::Any)
      str = ... # convert any to markdown, maybe use Lyndon's trick ATM
      return text_summary(name, str)
end

Then you can also weaken the constraint of log_text(logger, name, text::String; ...) to text::Any.
If there is no native way to do that in Julia, I believe that converting Matrix{String}  and Vector{String} to MD tables natively is a sane idea. It does look similar to the default REPR behaviour.

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is 0%.

@@         Coverage Diff          @@
##           master   #12   +/-   ##
====================================
  Coverage       0%    0%
====================================
  Files           7    19   +12
  Lines         120   175   +55
====================================
- Misses        120   175   +55

Impacted Files
Coverage Δ

src/protojl/function_pb.jl
0% <0%> (ø)

src/protojl/op_def_pb.jl
0% <0%> (ø)

src/protojl/tensor_pb.jl
0% <0%> (ø)

src/protojl/node_def_pb.jl
0% <0%> (ø)

src/protojl/versions_pb.jl
0% <0%> (ø)

src/Loggers/LogText.jl
0% <0%> (ø)

src/protojl/resource_handle_pb.jl
0% <0%> (ø)

src/protojl/graph_pb.jl
0% <0%> (ø)

src/protojl/types_pb.jl
0% <0%> (ø)

src/protojl/attr_value_pb.jl
0% <0%> (ø)

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9cbedf...c003dc7. Read the comment docs.

@shashikdm if you implement the "improved version"  I think this should be good to merge.

I forgot, could you also add a bunch of simple tests?

Yes. I will add tests soon. My end semester exams will end on 3rd May, I will begin right after that

Please note that codecov is failing because of unused Protobuf files. These are needed to compile Tensor.proto for log_text and will be actually used in future when log_graph will be implemented.

Yes I noticed.
I will add a rule to ignore those two folders for coverage.
I’ll have a last look at this between today and tomorrow but I should merge this soon.
Il 27 apr 2019, 09:39 +0200, Shashikant Kadam<EMAIL_ADDRESS>ha scritto:

Please note that codecov is failing because of unused Protobuf files. These are needed to compile Tensor.proto for log_text and will be actually used in future when log_graph will be implemented.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks a lot!


fix(watcher): look for SBOMFiltered instanceIDs in the annotations

Overview
Previously the watcher assumed that the instance ID of a FitleredSBOM would be stored in the resource name. Now, as the naming scheme changed, the watcher relies on having it in the annotations.
Additional Information
Ideally, fetching the instance ID should be available from either our custom types via a dedicated method, e.g SBOMSPDXv2p3Filtered.InstanceID() or extracted to the k8s-interface package. But doing this is faster.

Checklist before requesting a review

[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have performed a self-review of my code
[x] If it is a core feature, I have added thorough tests.
[x] New and existing unit tests pass locally with my changes

It would be more reliable to check the annotation with the same name...

That’s exactly what I’m doing here. I understand the confusion came from the labels parameter of the function. I will rename this.

I also want to add validation to the Storage APIServer that will ensure that all the values we expect in the annotations / labels are there. So you will help me a lot by providing a list of these values.
Can I expect that all key names defined in the k8s interface should be included when creating SBOMs, Filtered SBOMs and Vulnerability Manifests?


ci(anvil): disable build for main branch

@tuler should I add a changeset with a patch release?

I don’t think so


Update the version number.

:+1:

Coverage remained the same at 67.645% when pulling d8e9bc438a3b5b2579078a8546863943e3eafaf7 on version-0.5.1-aleksi into 638e504615551266823bf30d432172df92b56ef3 on master.


Grid and Inverter Data

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Voltage from Inverter and Grid not in the right Positions

My House have this Configuration
Grid -> SDM230 Powermeter 1 -> Hybrid Inverter -> SDM230 Powermeter 2 -> LOAD
If the Powermeter 1 say we have Power Cut. The Dashbord show me 230V and 50 Hz on the Grid Tab.
First i think i do some entities  on the wrong possession but then i check all the entities and there is nothing wrong.
Expected behaviour
Inverter Output Voltage and Frequency over the Inverter in the Tab
Grid Voltage and Frequency in the Gird Tab

If Grid Voltage or Frequency 0 / None / Unknown = Off-Grid
And maybe connect the Grid Line to the inverter like in the "Lite" version.
Possible Solutions
No response
Mode
full
Context / Reason
Values on the right position make more sense.
Thank you

Hi. Yes that would make more sense but this becomes a problem when three phase is enabled as there is no more space. The trade off is to provide the sensors you would prefer to see. i.e. SDM230 Powermeter 1 to the red box and only monitor inverter power out and amps.


tenant_id no longer logged for config updates since 5227

INFO request{method=PUT path=/v1/tenant/config request_id=9bc81d88-e2f6-4898-b066-63816b621a9f}: Handling request
INFO request{method=PUT path=/v1/tenant/config request_id=9bc81d88-e2f6-4898-b066-63816b621a9f}:tenant_config{tenant_id=X}: configuring tenant X
INFO request{method=PUT path=/v1/tenant/config request_id=9bc81d88-e2f6-4898-b066-63816b621a9f}: Request handled, status: 200 OK

INFO version: git-env:82027e22dd42107aaedffaafde9a0f5737e88c19 failpoints: true, features: [] launch_timestamp: 2024-04-03 12:30:24.713685917 UTC build_tag: build_tag-env:release-5227

INFO request{method=PUT path=/v1/tenant/config request_id=00aefa58ef24aaa6f5abed7936c20561}: Handling request
INFO request{method=PUT path=/v1/tenant/config request_id=00aefa58ef24aaa6f5abed7936c20561}: Request handled, status: 200 OK

Now logging is completely useless for the config update.

Need to add a span to the request handler that includes tenant_id, since it's not in the request URL

@koivunej @jcsp looks like its fixed as part of https://github.com/neondatabase/neon/pull/6059, can you please point me to some tests that can verify this ?

The way to verify this is the debug_assert_current_span_has_tenant_and_timeline_id macro: if we add that to a code path and the tests still pass, we know our spans are okay.


node-gyp rebiuld of<EMAIL_ADDRESS>fails with clang on debian

Just found out that the node-gyp rebiuld of<EMAIL_ADDRESS>fails on clang. Changing default cc and cc+ to gcc.
The actual fail is clang: error: unknown argument: '-fno-tree-sink'.
Logs and info
$ ./script/build
Node: v0.10.35
npm: v1.4.28
Installing build modules...
clang: error: unknown argument: '-fno-tree-sink'
make: *** [Release/obj.target/minidump_stackwalk/deps/breakpad/src/third_party/libdisasm/ia32_implicit.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/opt/n_node/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Linux 3.16.0-4-amd64
gyp ERR! command "node" "/opt/n_node/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/victor/Downloads/atmmm/build/node_modules/minidump
gyp ERR! node -v v0.10.35
gyp ERR! node-gyp -v v1.0.1
gyp ERR! not ok

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the minidump package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls minidump
npm ERR! There is likely additional logging output above.
npm ERR! System Linux 3.16.0-4-amd64
npm ERR! command "/usr/local/bin/node" "/usr/local/bin/npm" "--userconfig=/home/victor/Downloads/atmmm/.npmrc" "install" "--quiet"
npm ERR! cwd /home/victor/Downloads/atmmm/build
npm ERR! node -v v0.10.35
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR! not ok code 0
1:36.10s total, 44.93s user, 4.38s system, 51% cpu

$ clang -v
Debian clang version 3.5.0-9 (tags/RELEASE_350/final) (based on LLVM 3.5.0)
Target: x86_64-pc-linux-gnu
Thread model: posix

$ node --version
 v0.10.35

$ npm --version
1.4.28

$ uname -a
Linux minos 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt2-1 (2014-12-08) x86_64 GNU/Linux

Would you mind reopening this on the https://github.com/atom/node-minidump repo?

Sure, here it is https://github.com/atom/node-minidump/issues/7.


Natalie's meetup writeup (2 meetups)

Nice writeups!  I'm glad you were able to reflect on your first experience and have a better experience the second time around.  There are events that are more focused on teaching (workshops, for instance) that might help you feel more comfortable. But the feelings you had of not understanding what people are talking about are normal.  That's a part of interacting with people who are more experienced than you with a technology, and that happens all the time- for everyone!  No one is an expert in everything.


Platform is always overriden to Node.js

Expected Behavior
When setting platform it is never received as sent
Current Behavior
Platform is always overridden to "Node.js"
Possible Solution

Steps to Reproduce

Send this event to amplitude with the sdk:

{
  user_id: '60245c08b45ec4007022ec13',
  device_id: 'c3dae446-7d15-44fb-9751-16e4b38df58b',
  event_type: 'ACTION_INSERT_TOPIC_THREAD_COMMENT',
  insert_id: 'bbe59f0d-2bc2-47a7-8543-684072e7785d',
  time:<PHONE_NUMBER>714,
  session_id: '1612996076612',
  app_version: '<EMAIL_ADDRESS>  language: 'en-US',
  ip: '<IP_ADDRESS>',
  platform<EMAIL_ADDRESS>  os_name: 'Mac OS',
  os_version: '10.15.7',
  device_brand: undefined,
  device_model: undefined,
  event_properties: {
    viewId: 'e155c739-3f77-46f7-8123-2dd5dea599fc',
    originTopicId: 'e155c739-3f77-46f7-8123-2dd5dea599fc',
    originUserEmail: undefined,
    originUserName: 'Amplitude2',
    isUserAction: false,
    actionType: 'INSERT_TOPIC_THREAD_COMMENT',
    actionId: 'bbe59f0d-2bc2-47a7-8543-684072e7785d',
    isServerGenerated: undefined,
    userAgent: {
      ua: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.146 Safari/537.36',
      browser: { name: 'Chrome', version: '88.0.4324.146', major: '88' },
      engine: { name: 'Blink', version: '88.0.4324.146' },
      os: { name: 'Mac OS', version: '10.15.7' },
      device: { vendor: undefined, model: undefined, type: undefined },
      cpu: { architecture: undefined }
    },
    payload: {
      threadId: '01cdebcd-39b5-4714-9321-c5644da49f32',
      archived: false,
      topicId: 'e155c739-3f77-46f7-8123-2dd5dea599fc',
      participantEmails: [ [length]: 0 ],
      name: 'Amplitude2',
      id: '2c916ba6-ec74-4632-9a54-c5ca652102ec',
      body: 'test2',
      userId: '60245c08b45ec4007022ec13',
      timestamp:<PHONE_NUMBER>918
    }
  },
  user_properties: {
    originUserEmail: undefined,
    originUserName: 'Amplitude2',
    userAgent: {
      ua: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.146 Safari/537.36',
      browser: { name: 'Chrome', version: '88.0.4324.146', major: '88' },
      engine: { name: 'Blink', version: '88.0.4324.146' },
      os: { name: 'Mac OS', version: '10.15.7' },
      device: { vendor: undefined, model: undefined, type: undefined },
      cpu: { architecture: undefined }
    }
  }
}

Note that the event received from the amplitude event stream "raw" log now has reset platform to Node.js:

{
  "$insert_id": "9eb32219-3af0-47dd-91f6-359438c901dc",
  "$row_source": "realtime",
  "$schema": 12,
  "_time":<PHONE_NUMBER>311,
  "adid": null,
  "amplitude_attribution_ids": null,
  "amplitude_event_type": null,
  "amplitude_id":<PHONE_NUMBER>69,
  "app": 310020,
  "city": "San Francisco",
  "client_event_time": "2021-02-10T22:37:05.311",
  "client_upload_time": "2021-02-10T22:37:15.619",
  "country": "United States",
  "data": {
  },
  "device_brand": null,
  "device_carrier": null,
  "device_family": null,
  "device_id": "c3dae446-7d15-44fb-9751-16e4b38df58b",
  "device_manufacturer": null,
  "device_model": null,
  "device_type": null,
  "display_name": "ACTION_INSERT_TOPIC_THREAD_COMMENT",
  "dma": "San Francisco-Oakland-San Jose, CA",
  "event_id": 854747387,
  "event_properties": {
    "actionId": "9eb32219-3af0-47dd-91f6-359438c901dc",
    "actionType": "INSERT_TOPIC_THREAD_COMMENT",
    "isUserAction": false,
    "originTopicId": "e155c739-3f77-46f7-8123-2dd5dea599fc",
    "originUserName": "Amplitude2",
    "payload.archived": false,
    "payload.body": "test",
    "payload.id": "0743bb3b-cf46-47c3-aaf6-bd2a3f820683",
    "payload.name": "Amplitude2",
    "payload.participantEmails": [
    ],
    "payload.threadId": "01cdebcd-39b5-4714-9321-c5644da49f32",
    "payload.timestamp":<PHONE_NUMBER>513,
    "payload.topicId": "e155c739-3f77-46f7-8123-2dd5dea599fc",
    "payload.userId": "60245c08b45ec4007022ec13",
    "userAgent.browser.major": "88",
    "userAgent.browser.name": "Chrome",
    "userAgent.browser.version": "88.0.4324.146",
    "userAgent.engine.name": "Blink",
    "userAgent.engine.version": "88.0.4324.146",
    "userAgent.os.name": "Mac OS",
    "userAgent.os.version": "10.15.7",
    "userAgent.ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.146 Safari/537.36",
    "viewId": "e155c739-3f77-46f7-8123-2dd5dea599fc"
  },
  "event_time": "2021-02-10T22:37:05.311",
  "event_type": "ACTION_INSERT_TOPIC_THREAD_COMMENT",
  "group_properties": {
  },
  "groups": {
  },
  "idfa": null,
  "ip_address": "<IP_ADDRESS>",
  "is_attribution_event": false,
  "language": "English",
  "library": "amplitude-node/1.3.2",
  "location_lat": null,
  "location_lng": null,
  "os": "Mac OS 10.15.7",
  "os_name": "Mac OS",
  "os_version": "10.15.7",
  "paying": null,
  "platform": "Node.js",
  "region": "California",
  "sample_rate": null,
  "server_received_time": "2021-02-10 22:37:15.619000",
  "server_upload_time": "2021-02-10T22:37:15.641",
  "session_id":<PHONE_NUMBER>612,
  "start_version": "<EMAIL_ADDRESS>  "timeline_hidden": false,
  "user_creation_time": "2021-02-10T22:19:55.227",
  "user_id": "60245c08b45ec4007022ec13",
  "user_properties": {
    "originUserAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.146 Safari/537.36",
    "originUserName": "Amplitude2",
    "userAgent.browser.major": "88",
    "userAgent.browser.name": "Chrome",
    "userAgent.browser.version": "88.0.4324.146",
    "userAgent.engine.name": "Blink",
    "userAgent.engine.version": "88.0.4324.146",
    "userAgent.os.name": "Mac OS",
    "userAgent.os.version": "10.15.7",
    "userAgent.ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.146 Safari/537.36"
  },
  "uuid": "8771ca20-6bf0-11eb-9ed4-0231551a9deb",
  "version_name": "<EMAIL_ADDRESS>}

Environment

SDK Version: 1.3.2
Node version: 12.14.1

For some reason your built files are incorrect. When I go to<EMAIL_ADDRESS>I see:

Yet this code has been patched:
https://github.com/amplitude/Amplitude-Node/blob/1a11d01fe142663327a9a02ae49e19e52f178a9c/packages/node/src/nodeClient.ts#L132
Yet the version I have installed is the latest version:

Hey @tommedema !
We haven't published those changes - apologies. I'll go ahead and publish the newest version and close this once Node 1.3.3 is available!

Ok, thanks @kelvin-lu  -- and now that I have you, where am I supposed to set the user's browser and browser version?
If os_name and os_version (which is really odd naming), where am I supposed to define the operating system name and version?

@tommedema Let me confer with our dataPL team if we have any best practices but it looks close to what you have here - linking to what our Web SDK does here; we put the browser in the OS space and the OS info in the device.
what is userAgent.device.vendor look like? I don't think I see it in your available data

Hmm, what you referred to me is actually different from what we're doing. It seems a bit awkward to say that the device model is MacOS, Windows, etc.? MacOS is an operating system, not a device. A device might be an iPhone, Samsung Galaxy S8, etc.
Even though it might not make sense to set the OS as the device, should we do this anyway since this seems to be what the web sdk does?


rtk query integration makes unnecessary api import for fragments

Describe the bug
when generating code with the rtk toolkit plugin in conjunction with near-operation-file-preset graphql files for fragments are generated with an attempt to inject an endpoint into the rtk api, despite fragments not being operations.
To Reproduce
repro here: https://github.com/hkasemir/gql-codegen-issue
in particular, the generated file for the fragment: https://github.com/hkasemir/gql-codegen-issue/blob/main/queries/user-fragment.generated.ts
it does not import the api, but it does try to export it with an injected endpoint, which causes compile errors.
Expected behavior
fragment files should not include an attempt to export the api with an injected endpoint, similarly to how the api is not imported into the generated file if the graphql file does not include operations: (https://github.com/dotansimha/graphql-code-generator/blob/c11011e7b46483909965d51e486ab41933b340e9/packages/plugins/typescript/rtk-query/src/visitor.ts#L48)
Environment:

OS:
"@graphql-codegen/add": "^3.1.0",
"@graphql-codegen/cli": "^2.3.0",
"@graphql-codegen/near-operation-file-preset": "^2.2.2",
"@graphql-codegen/typescript": "^2.4.1",
"@graphql-codegen/typescript-operations": "^2.2.1",
"@graphql-codegen/typescript-rtk-query": "^2.2.1",
NodeJS: 17.2.0

Hi @hkasemir!
Thank you for your contribution! ⚡
Your patch has been released in<EMAIL_ADDRESS>📦


nuget.config to fix actions ci restore failure

What kind of change does this PR introduce?
Adds a nuget.config to fix an issue where the actions runner can fail to restore packages, which is being seen in #693
What is the current behavior?
fail to restore packages because it opts for local store
What is the new behavior?
enforce nuget.org
What might this PR break?
n/a
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
https://github.com/actions/virtual-environments/issues/1090

All our repos will need it I think due to some GitHub actions server change.


Value of a map element(ArrayMapAccessExpr) can be directly assign to any type

In bellow sample, string value is assigned as int value without any error.
function main(string[] args) {
map cmd = {"key1":"val1", "key2":"val2"};
int i ;
//here string value is assigned to int variable
i = cmd["key1"];
}

Fixed in v0.89. Now it has to be explicitly cast to int.
var i,_ = (int) cmd["key1"];


⚠ Processors has degraded performance

In 84619a7, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 116 ms

Resolved: Processors performance has improved in 94d70a3.


Add non default docker daemon path support

Looks promising!
But is there a way to set the docker daemon path if it is non standard?
I run my docker in user mode which is why I have a different path to the daemon. With a Quick Look into the code I could not find out if it is possible to change it via the config.
I could create a pull request once I tested it and you tell me where I should change that value.

Hey!
I need some more info.
By user mode, do you mean non-root mode? Or you have installed the daemon in a different path?
I tried searching up the latter but couldn't find much info about it.
Also, is this on windows ?

Thats valid, I could add support for custom contexts in the next release. Thanks for your input!!!

Allowing connections to remote sockets would also be really helpful, either over tcp or ssh. I don't know about docker, but for podman, the bindings offer a method to do remote connections

@benniekiss I might be able to add that with podman support in the next release 👀

Had the same issue using docker with colima. I'm on darwin and used nix to install everything, though I notice it's only on version 1.4 there. Anyway I've found two workarounds that work for me:

Create a symlink to the default location

E.g. sudo ln -sf $HOME/.config/colima/default/docker.sock /var/run/docker.sock

Set the DOCKER_HOST env var to unix://${HOME}/.config/colima/default/docker.sock

I believe If you didn't use nix to install stuff your socket might live in {$HOME}/.colima/default


:class for b.label not applied

Looks like :class for b.label is not getting picked up by simple_form:
  config.wrappers :tag => :div, :class => :"control-group",
                  :error_class => :field_with_errors do |b|
    b.use :label, :class => :"control-label"
    b.use :hint,  :tag => :span, :class => :hint
    b.use :error, :tag => :span, :class => :error
    b.use :tag => 'div', :class => "controls" do |bi|
      bi.use :input
    end
  end

I expected labels in the generated forms to have the control-label class but they don't.

Maybe this is a bit confusing, but the options given to b.use :something are used to wrap the :something. For instance:
b.use :error, :tag => :span, :class => :error

And:
b.use :tag => :span, :class => :error do |be|
  be.use :error
end

Are equivalent. The reason we allow the first form is just to be more succinct but maybe we should remove it in order to avoid confusion?

I see. So how can I add a class to labels?

Yes, label_class config option is still available, you should go with that to add a class to all labels. Thanks.

/cc @rafaelfranca wdyt? I remember you suggested something along those lines. If we are going to do this, it needs to be now, otherwise we will have to live with it.


Update docs to reflect newly support shells with autocompletions

Update Windows docs to use Powershell instead of zsh

Reflect changes made in kubernetes/kubernetes#103758 & kubernetes/kubernetes#92989
I'm not well versed in fish, so I'll leave that part for someone else to get an easy contribution in.

adding a /lgtm despite my membership still pending

/hold
is this really supposed to be open against dev-1.23?
/cc @jlbutler

I appreciated @zikhan s comment that the existing instructions are quite outdated. How about we wrap the new instructions with some sort of version flag?

/hold
is this really supposed to be open against dev-1.23?
/cc @jlbutler

I'm not sure about the branch logistics but powershell and fish won't ship until 1.23 so shouldn't be live before then.

/hold

is this really supposed to be open against dev-1.23?

/cc @jlbutler

I'm not sure about the branch logistics but powershell and fish won't ship until 1.23 so shouldn't be live before then.

that answers my question, thank you!
/milestone 1.23
the hold can be lifted by a reviewer from docs release whenever it's done

I proposed some capitalization corrections. ...

I've made the changes you've proposed.

I have verified the instructions work on Windows Server 2019 and kubectl built from k/k/main

I have verified the instructions work on Windows Server 2019 and kubectl built from k/k/main
/lgtm

/label tide/merge-method-squash

/approve


DI Reflectionexception php 7.0.0b

Php7 seems to have a new way of showing ReflectionExceptions. Its not very informative. I would suggest to give more support about the error, because you have to investigate whats going on.
Minor thing, but useful. Monday Ill do a PR.

should better be reported to PHP so that they adjust the error message. PHP7 is not stable yet so they can fix it without the need for yii to create a workaround.

Done. Thx https://bugs.php.net/bug.php?id=70282


Make the queue automatically refresh

I think you are right that it will be called two times, but I don't know of a way to avoid it. There are two PlanLists, one on the home page, and one on the acquire page. Updating one, doesn't update the other one. Props aren't passed from home to acquire or vise versa. Both Home and Acquire get their plan from the store which the method getQueuedPlans. Do you know a better way to do it?
The required attribute is unrelated.


Support simultaneous remote execution

Currently, the software raises an error when two remote simultaneous executions on a server is processed. It will be more reliable if the script file name stored in the remote tmp directory is generated randomly so that it will have no conflict anymore.

PcapRemoteSniffer must be also support simultaneous connection  when we execute get_packets.
Note: As an improvement, we can delete skrinked pcap file in the remote server.


Content Item horizontal with media whitespace to right of video

Detailed description

Describe in detail the issue you're having.
When using Content Item Horizontal with media in AEM the video image is not expanding to fill the width of the grid.  An image is better but I think a width:100% is not getting carried forward and will fix the issue.

Is this a feature request (new component, new icon), a bug, or a general
issue?
Bug

Is this issue related to a specific component?
Content item horizontal with media

What did you expect to happen? What happened instead? What would you like to
see changed?
Here is the an example of the issue.  Note the purple area to the right of the image when I highlight the div with bx--content-item-horizontal__row.

If I add width: 100% directly in the browser here, it fills in that space with the image
.bx--content-item-horizontal__row {     display: grid;     column-gap: 2rem; }
If I got to storybook https://ibmdotcom-web-components.mybluemix.net/?path=/story/components-content-item-horizontal--with-media it behaves better but still does not have that width: 100%
There is a width: 100% here for the content item horizontal  without media but I do not think it is getting carried forward with the media.  https://github.com/carbon-design-system/carbon-for-ibm-dotcom/blob/ed414d195c1f91065e375845716557d7db4173d1/packages/styles/scss/components/content-item-horizontal/_content-item-horizontal.scss#L112

What browser are you working in?
Chrome

What version of Carbon for IBM.com are you using?

   "@carbon/ibmdotcom-styles": "1.20.0-rc.1",     "@carbon/ibmdotcom-web-components": "1.5.0-rc.1",     "@carbon/type": "^10.18.0",

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

This is part of the solutions template for AEM
Steps to reproduce the issue

Step one
Step two
Step three
etc.

Additional information

Screenshots or code
Notes

Hi @gregj0 I believe the Content item horizontal with media is behaving as expected according to the design specs.
Within the design spec file you can see at the max breakpoint there is a max width of 640px for any media and the last column is left blank. This might be why you are seeing extra space to the right of the media.
Max breakpoint design spec

Max breakpoint in storybook

At the xl breakpoint, the media is spanning 8 columns and goes to the edge of the browser
Xl breakpoint design spec

Xl breakpoint in storybook

From the screen shot you provided I couldn't tell which breakpoint you were viewing, let us know if the gap is happening below the max breakpoint of 1584px and if this answers your question, thanks!

Here is two pages, you should be able to access using it.
Using the image it does match what you have https://dev-publish.np-roks.cms.cis.ibm.net/gjtest/solution-item-horiz1

But with a video is it does not https://dev-publish.np-roks.cms.cis.ibm.net/gjtest/solution-item-horiz2

Christian had looked at it and suggested that it needed the width 100% and maybe that is not right.  But it does seem to fix the video and have no impact on the image

In the example page links shared above, the content-item-horizontal-media component is used within content-group-horizontal which could be causing the layout for the video variation to look weird

That's how our design team wants to use it on the solutions page.  And while I cannot create a page on the server, with a content-item-horizontal-media component outside content-group-horizontal, I can locally and it behaves the same.  This page might demonstrate it better as it has one with an image and another with video. https://dev-publish.np-roks.cms.cis.ibm.net/gjtest/solution-item-horiz-both  They match in size on large breakpoint but medium is not close.  Here is a similar local page without the content-group-horizontal on medium breakpoint

Hey @gregj0, a fix has been merged yesterday and will be part of the web-components 1.6.0 release. You'll be able to text out the fix when we release a release candidate (1.6.0-rc.0) some time tomorrow


WIP: Add probe for HTTP requests with Seahorse

Looking for early input. It's hard to find out how to hook into Seahorse correctly - I did it by reverse-engineering; maybe I should have searched for documentation more thoroughly.

Which tests would you like to see?

Please make the version configurable

I took care of almost all but one comment and added a line to the build configuration.
I am now working on adding more test cases, and actually testing this on my local system.

Update: @Dome-GER and I found a way to hook into the AWS SDK in such a way that even requests with their S3 API client are properly instrumented.
However, the integration is quite brittle in that it depends on the load order of aws-sdk-core, aws-sdk-s3 and mnemosyne itself.
We tabled this for now and instead explicitly added the instrumentation to our internal S3 wrapper, but we could continue integration here at a later date, e.g. by going the monkey-patching route instead.

@franzliedke I'd fine with adding e.g. a seahorse middleware that needs to be installed manually but keeping and testing it in the client gem.

I pushed the current version that tries to auto-inject. The test will succeed when the example with tracing runs before the untraced one, but not vice versa. :speak_no_evil:

@franzliedke, could you provide a list of missing tasks for this MR to remove the WIP status from it? It would help others to jump into the issue.

Hi @martinstiago, thanks for looking into it!
Basically, what's left is this:

The test will succeed when the example with tracing runs before the untraced one, but not vice versa.

That's currently the thing that's wrong about this PR, and needs to be fixed. Either that, or instead don't do auto-injection and require consumers of this library to manually enable Seahorse tracing. @jgraichen said he would be fine with that. Would need to be documented in the README as well.

You might need to change the PR target to the main branch as of now.


Add lint step similar to --coverage

How do I add linting to jest in --watch mode? Something similar to how --coverage would be nice, printed before the tests run

I'd depends on your build system, you can run linter before the watch or coverage script, e.g. through npm scripts. Either way it has nothing to do with Jest.

You can try chokidar to do it for you easily through npm scripts without any webpack, gulp or something. Good luck!

A --lint option would be really nice here. I found an in-jest solution:
const path = require('path');
const { exec } = require('child_process');

describe('linter', () => {
  it('lints the src', (done) => {
    const src = path.resolve(__dirname + '/../src');
    exec(`jshint ${src}`, (err, stdout, stderr) => {
      console.log(stdout.replace(/^\s+/mi, ''));
      done();
    });
  });
});

However it won't work for me since jshint does not support ES7's async/await, which is a deal killer for me. You should probably finish off the function.


Documentation example not working

Hello,
when following the documention in README.MD, when getting to the command npm run webpack-serverside, npm errors out with Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.  - configuration.output.path: The provided value "./app/Resources/webpack/" is not an absolute path!
See screenshot below.

Thanks for reporting this, @MichaelHindley!
Webpack config doesn't accept relative paths anymore. Fixed.

Hello,
I've tested the example and its working fantastic, but unfortunately not on my smartphone (Android 6).
See screenshot below.

This is an urelated issue, right? I mean, the original issue has nothing to do with this one. Or am I missing anything?
If this is the case, could you open a separate issue?


StorageService Unit testing - adding Mocks and Tests

Need to add more unit tests for the AWS3StorageService class. Some happy path cases can be added now, while some failure cases can come after finalizing on error mapping. ie. Mock dependency to return a failed task with HttpStatus error with code 403, verify that the StorageError coming from AWS3StorageService is AccessDenied. etc.

we can cover this over in https://github.com/aws-amplify/amplify-ios/issues/22


Support converting '.NET TP Worker' to the numeric thread ID on .NET 8+

Any chance this can be merged, so that we don't have to fork.

@fluffynuts can you take a look?

@erikmav, @michal-ciechan, @FreeAndNil, log4net is in great need of maintainers. @fluffynuts, the only active maintainer, and whom I believe will soon take care of this PR, can definitely use some help. Would any of you be willing to step up as a maintainer? If so, could you share this in an email to dev@, please? I cannot speak for the rest of the PMC, but IMO, we can grant a volunteer the committer rights. Equipped with that, they can merge PRs, commit changes, etc. The release cannot be done by committers; there PMC members are needed for reviewing and performing the release anyway.

@michal-ciechan merged - I can't make any guarantees of a release date though, but perhaps after I've finished some other opensource PR I've been working on in the little spare time I have for the last 3 weeks (:

Hi, when will this fix get released?! It's a really hot fix.
We already had similar issues twice. 1-wrong thread name in updating to.net 6; 2-wrong process name after migrating to.net 7.
Why should we see this again? It would be nice if we carefully tracked our previous issues.

Considering my constrained time, and even though @FreeAndNil recently stepped up to be a maintainer, I don't see any time really soon. You can, in the meantime, check out the repo, build, and distribute a dll with your app if it's that important. It's not convenient, I'll admit, but if it's urgent, it's an option.

@fluffynuts actually, if we replaced ThreadName with our customized property field, then we wouldn't need to replace the library anymore.

@erikmav, @michal-ciechan, @poormonfared we've released https://www.nuget.org/packages/log4net/2.0.16


Microsoft.Data.SQLite: Reader is not correctly closed when an exception occurs on DbCommand.ExecuteScalar() with 3.0.0-preview8

When using Microsoft.Data.SQLite version 3.0.0-preview8.19405.11, when executing a command with ExecuteNonQuery, ExecuteScalar or ExecuteReader causes an exception, we cannot change the CommandText on the DbCommand any more.
Steps to reproduce

Create a new .NET Core 3.0 console project on Windows using .NET Core SDK 3.0.100 - preview8.
Add <PackageReference Include="Microsoft.Data.SQLite" Version="3.0.0-preview8.19405.11" />
Add the following code in Program.cs:

using System.Data.Common;
using Microsoft.Data.Sqlite;

namespace Test
{
    class Program
    {
        static void Main(string[] args)
        {
            var conSb = new SqliteConnectionStringBuilder();
            conSb.DataSource = ":memory:";

            using (var con = new SqliteConnection(conSb.ConnectionString)) {
                con.Open();

                using (var cmd = con.CreateCommand()) {
                    cmd.CommandText = "SELECT 1 FROM NonExistent;";
                    try {
                        cmd.ExecuteScalar();
                    }
                    catch (DbException) {
                    }

                    cmd.CommandText = "SELECT 1;"; // fails
                    cmd.ExecuteScalar();
                }
            }
        }
    }
}

Expected behavior: Runs without exception.
Actual behavior:
Exception message: System.InvalidOperationException: 'An open reader is associated with this command. Close it before changing the CommandText property.'
Stack trace:
   at Microsoft.Data.Sqlite.SqliteCommand.set_CommandText(String value)
   at Test.Program.Main(String[] args) in C:\Users\developer4\Desktop\DebugMicrosoftSqlite\Program.cs:line 24

This problem doesn't occur when using version 2.2.6 of Microsoft.Data.SQLite.
Workaround: Close the DbCommand and create a new one for executing the next command.
Further technical details
EF Core version: 3.0.0-preview8.19405.11
Database Provider: Microsoft.Data.SQLite
Operating system: Windows 10 Version 1903 x64
IDE: Visual Studio 2019 16.2.3
Thanks!

This is a by-design side effect of fixing #13830. (which had a few other subtle breaking changes like this)
I think #14044 will enable us to go back to the previous, more flexible behavior.

Oh wait, you called ExecuteScalar, so there shouldn't be an open data reader after the error. We should investigate.


formula_auditor: fix macOS system dependency false positive

Fixes #15645

Good catch, thanks again @Bo98!


Strict channel enabling

This PR enables strict channel enabling in lnd. This means that similarly to how we disable channels, we require a disabled link to stay active for 20 minutes (default) before re-enabling it.
This is done in two steps:

The path finding algorithm is modified to take into account an extra set of active local channels, that it will use when considering whether to ignore local channels. This improves the current path finding logic when using mission control, as we will no longer attempt to route over local channels that are inactive. Split into https://github.com/lightningnetwork/lnd/pull/2115
The channel re-enabling logic carried out when a peer connects is removed, as we will now instead let the server's re-enabling logic take care of enabling the disabled channels when they have been stable for 20 minutes.

This essentially decouples the graph's disabled status from the local path finding, as the local channel status will be more up-to-date than what is found in the graph.
Builds on https://github.com/lightningnetwork/lnd/pull/2115
Replaces https://github.com/lightningnetwork/lnd/pull/2080

The disable bit decoupling is now split into a separate PR, to reduce the size of this one, and since they are really do different discussions: #2115


Adding a video category and the Vimeo Unity SDK

Adding a video category and the Vimeo Unity SDK into it 🙌

Thanks! 👍


Demo Login details

Hey we are looking for a starting point for ticking for our upcoming event series. Would love to look at the capabilities of your system.

Hi @wesleypearson, Events is still in development and isn't ready for production. We're doing our first beta test with an event in 2 weeks, but the earliest I we'd be able to offer any services publicly likely would be in mid December.
Aside from that, is there any chance you can give us a little bit more insight on your use case? Our goal is to build a dead simple platform for event ticketing (that's free under 75 tickets). There's some complexity to it such as multiple event times, custom questions for tickets, etc. but we want to make sure that the features we decide to build matter to our users rather than adding features for the sake of adding features.

I'm closing this for now, feel free to respond and I'll be happy to reopen!


Add rack A and B under cables page

As ...
Isabella - Infrastructure Owner
I want ...
Hi, we just migrated from Netbox to Nautobot and started to fill up a new rack/cables. We added a lot of 'planned' cables and we would like to export these for our datacenter operations guy to start cabling, with termination racks included.
Under /dcim/cables we filtered the site, racks and status='planned' and got all the cables. Perfect. But it only shows the device names (as 'Side A') and port (as 'Termination A'), but since most of the cables are actually between different racks, we would like to have a column 'Termination Rack A' and 'Termination Rack B'. I tried adding these columns under 'Configure', but it is not a options there.
Could Terminal rack A and B columns be added as optional under 'Configure' in /dcim/cables?
So that ...
An export shows which racks the device for Side A and Side B are in.
I know this is done when...
I can select 'Rack A' and 'Rack B' under 'Configure' in the /dcim/cables page.
Optional - Feature groups this request pertains to.

[ ] Automation
[ ] Circuits
[X] DCIM
[ ] IPAM
[ ] Misc (including Data Sources)
[ ] Organization
[ ] Plugins (and other Extensibility)
[ ] Security (Secrets, etc)
[ ] Image Management
[ ] UI/UX
[ ] Documentation
[ ] Other (not directly a platform feature)

Database Changes
No response
External Dependencies
No response

Sounds like a reasonable enhancement request to me! I think the most challenging part will be accounting for the fact that cables can terminate to objects other than Interfaces on Devices (such as circuit terminations), some of which may not have the possibility of an associated Rack.


Make integration tests independent of sample data

Problem
The API integration tests used by the CI workflow use the sample data. This makes them tightly coupled and causes problems when updating the sample data to match changes in models.
Description
The integration tests should use QA indices search-qa-images and search-qa-audio that are created programmatically.
Alternatives

The test cases need to be updated every time there is a change in the sample data.
The tests should do some computation on the sample data first and then adjust the requests accordingly.

Implementation

[ ] 🙋 I would be interested in implementing this feature.

While working on #3931, I had to update the sample data to include the new audio provider with a different shape of the alt_files (some fields, such as bit_rate, were absent). I replaced the last 10 items, and the integration tests that, as it turned out, rely on them started failing. Updating sample data CSV is not easy, and it would be nice to create the public data programmatically. Provided that we know all of the data inconsistencies or have normalized all of them already.
I wonder if something like Schemathesis exists for synthetic data creation.


Subatomic Particle Visualization in Quantum Mechanics.

[ Project Lead ] @SOFTowaha
[ GitHub Repo ] https://github.com/SOFTowaha/Quantum_Mechanics
[ Track ] Open Educational Resource: you're collaborating on curriculum or other educational resources, Open Data: you have data others can use and play with during the sprint
[ Level ] Beginner
[ Timezone ]
Description
This project will help physics student and others to visualize the sub atomic particles and their motions .

Want to Contribute?
Join us at the Global Sprint June 2-3. Leave a comment in this issue to let the project lead know you're interested in contributing during #mozsprint 2016!

Note to the Project Lead
Congrats, @SOFTowaha! This is your official project listing for the Mozilla Science Global Sprint 2016. To confirm your submission, please complete the following:

[x] Provide a GitHub repository for work and discussion on your project
[ ] Confirm in a comment that at least one person will be available to review and answer questions on this project from 9-5 in their timezone on both June 2 & 3.

Do you want to become a featured project? :tada:
Here are some exercises that will help your project be more inviting to new contributors. We hope you'll try to complete some of these as you prepare for #mozsprint.
If you complete all the exercises, your project will be eligible to be featured in our collection of open source science projects! Once you've finished this list, contact @acabunoc to submit your project for review.

[ ] README.md:
[ ] LICENSE:
[ ] CONTRIBUTING.md:
[ ] Roadmap or an Issue Tracker (with tasks to complete):
[ ] Data Reuse Plan (if applicable):
[ ] Code of Conduct:
[ ] Personas:

Thank you @acabunoc ;
Other than the 'personas'
I'll submit rest of the information ASAP :)
I might need a meeting with you to get few things clear :) Let me know when you are free.

Thanks @SOFTowaha! Happy to answer questions on the exercises -- my calendar is up to date
Please confirm that at least one person will be available to review and answer questions on this project from 9-5 in their timezone on both June 2 & 3.

This sounds very interesting, @SOFTowaha, and I will ask some folk at CERN if they'd like to participate. There were also some particle-visualisation projects here but I'm not sure what happened with them.

What are the coding requirements for being part of this group?

Hello @RaoOfPhysics, It'd be so nice of you if you could do this for this project; I'm stuck in this project due to lack of potential people :)

Hello @Andromedanita , are you interested in this project? It would be nice if you can share your thoughts with me over email or here. If you want to do the coding parts, you are welcome; I will guide :)

Hi,
What are the coding languages used in this project? I am know Python and some C++.
Please let me know.
Regards,
Anita
Sent from my iPhone

On Jun 1, 2016, at 6:04 AM, Towaha<EMAIL_ADDRESS>wrote:
Hello @Andromedanita , are you interested in this project? It would be nice if you can share your thoughts with me over email or here. If you want to do the coding parts, you are welcome; I will guide :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I'll share this on the CERN Study Group Gitter room and see if anyone wants to pick up on it.

This seems pretty interesting. Are there any more details for this project or is it still in early development?

Hi everyone,
I'm currently at the Seattle, WA site looking for a project to start on.  This one looked particularly interesting.  I have good experience with C++ (and Java, JavaScript if need be) and am hoping I can contribute in some way.  Is this project in action/ is there any way I can get involved?


[Sema] Warn unhanded errors in empty catch block

What's in this pull request?
This issue addresses SR-978. It warns when an empty, unguarded catch block is the only sink of an error.
do {
    try something()
} catch { // error: 'catch' block is empty, errors thrown in 'do' block are unhandled
}

It does not warn when there are more than 1 catch block, as in patterns like below, as the user is giving thought to handling errors.
do {
    try something()
} catch let error as SomeError {
    // …
} catch {
    // discard
}

It emits a FIXIT to remove the catch block, this deviates from the initial design (to remove the do/catch pattern and replace all try expressions with try!)  for a few reasons:

I implemented it here; I walk the subtree and transformtry expressions to try!; removing the catch block; and replace throw expressions with breaks. I decided against this in the end as it often does not produce code which is safer, or with more explicit error handling — even if limited to small blocks it seemed unreasonable.
try! may not be the sensible behaviour to encourage; there is precedent for introducing traps in FIXITs (unexpected optionals offer to insert a ! for example). However there are no cases where FIXITs promote try!, or introduce traps throughout a whole block stmt.
A FIXIT offering to remove the catch {} highlights the need to handle the error, whilst making the user consider and implement the error handling.

Thanks for your help so far, what are your thoughts @jckarter?
Resolved bug number: (SR-978)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing

Platform
Comment

All supported platforms
@swift-ci Please smoke test

OS X platform
@swift-ci Please smoke test OS X platform

Linux platform
@swift-ci Please smoke test Linux platform

Validation Testing

Platform
Comment

All supported platforms
@swift-ci Please test

OS X platform
@swift-ci Please test OS X platform

Linux platform
@swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

Implementation for https://bugs.swift.org/browse/SR-978
A warning is emitted when the only catch on a do/catch statement is
unguarded and has no body. A fixit is also offered to remove the catch
block. The tests were updated to fix new warnings and to add cases for
this new functionality.

This seems more in the space of a code style checker (e.g. a theoretical tool that people could opt into warning about any use of force unwraps) rather than being an on-by-default part of the compiler.  For this to be acceptable, we would need some pattern for someone to write when they really really do want to ignore thrown errors.
Here's a more basic question though: if someone wrote this, is it more likely to be a bug or an intentional omission of the handling logic?  I don't see how this could be an accidental omission.

Well, there's also _ = try? for swallowing errors. Since do { ... } catch {} is the common "shut up the compiler" idiom in Java, it seems worth it to me to nudge people away from that toward try! for that kind of sloppy-mode programming.

try! means something fundamentally different though.  It is closure to "_ = try?", except that that you have to use if/let or some other pattern to get:
do {
let x = try foo()
use(x)
} catch {}
This seems clearly in the domain of a style checker, not something we'd include by default in the compiler.

I disagree that this is similar to warning about uses of the ! family of operators; optional!, as!, and try! show explicit assertions about the code, and trap if it fails, making the code safer.  catch {} does not, it just discards information; I see this problem as distinct from people’s stylistic beef with !.
I’m not sure if this is done often by accident, but this bug was filed after a teacher was worried the ease of writing catch {} goes against what swift is trying achieve in how it makes behaviour predictable and promotes strong design patterns (here in the error handling model) to beginners.
We already warn when the do block doesn’t throw, warning when the catch block doesn't handle errors doesn't seem unreasonable to me.

This patch turned a year old a month ago and has fallen behind mainline.  @joewillsher I'm going to close this for purely administrative purposes.  Please reopen it after rebasing.
I also think to resolve this argument you should try to post something to swift-dev or swift-evolution to see what the community thinks about this change.


Need update for Z2-N-V1.1 module running v1.0.4

I have a WP9 power strip that has a Z2-N-V1.1 in it that reports as having both Main and MCU running v1.0.4
reading through https://github.com/tuya-cloudcutter/tuya-cloudcutter/issues/598 they appear to be the exact same module except with different versions loaded. Is it possible to get an OTA update to include v1.0.4 for the Z2-N-V1.1 or is there more information needed from the device? Please let me know an I'll pull down what ever i can.

That's not a different version, it's a different firmware.  A dump would be needed to support it.  You could try LightLeak or doing a serial dump.

I have a file that I read (ltchiptool flash info bk7231n; and ltchiptool -v flash read bk7231 ghome-wp9.bin) from a recently purchased "GHome WP9".  I can share it if it's useful, just tell me where to put it.  Never booted it into the Tuya stuff, just flashed it w/ OpenBK.

Here's the file referenced above: ghome-wp9.bin.gz

Thanks for supplying the dump.  Unfortunately, WP9 firmware 1.0.4 is patched, and serial flashing will be the only option for this device.

FWIW, flashing this via hardware is pretty straightforward.  I made a post about it in the OpenBK forums.

FWIW, flashing this via hardware is pretty straightforward. I made a post about it in the OpenBK forums.

Hey,
I have the UK version of this, are you able to help me with this?


Update privacy toggle to be per site

Task/Issue URL: https://app.asana.com/0/72649045549333/559623300949085
Steps to test this PR:
TEST 1: Test new toggle text and behavior

Navigate to a page e.g cnn.com
Open the privacy dashboard and ensure that the toggle text is "Site Privacy Protection"
Switch privacy protection off and press back
Ensure page reloads
Ensure page is now in whitelist
Ensure that mp_wla pixel is fired
Navigate to another page e.g facebook.com
Check that privacy toggle is on
Navigate back cnn.com and ensure that the privacy/site protection toggle is back off
Switch the toggle back on
Ensure that  mp_wlr pixel is fired
Ensure page is no longer in whitelist

TEST 2: Test new buttons

Navigate to a page and open the privacy Dashboard
Tap the Manage Whitelist button and ensure whitelist page is launched
Ensure the "mp_mw" pixel fires
Go back
Tap the Report Broken Site button and ensure that the broken site button in launched
Ensure the "mp_rb" pixel fires

TEST 3: Test new pixels browsing pixels

Browse to a site
From the browsing menu, add it to the whitelist and ensure that "mb_wla" fires
From the browsing menu, remove it from the whitelist and ensure that "mb_wlr" fires

TEST 4: Test new whitelist settings pixel

Open Settings
Tap Privacy Protection Whitelist
Ensure "ms_mw" fires

TEST 5: Test whitelist page

Open Settings
Tap Privacy Protection Whitelist
Add, edit and delete entries and ensure these behave as expected
Go back to settings and switch theme
Now repeat step 3 to ensure UI still works as expected (note dialogs are universally white as per bookmarks UI)
Repeat this test on API 21`

TEST 6: Test database migration

Cleanly install the app from develop and run the app to ensure the db is initialized
No install this branch over the top to ensure
Run the app and ensure the migration succeeds without anything breaking

Internal references:
Software Engineering Expectations
Technical Design Template

Overflow icon color in whitelist page is rendered with pink color

Thanks! This was introduced by another PR and has subsequently been fixed globally by https://github.com/duckduckgo/Android/pull/814.

Testing with destroy activities enabled: Having a whitelisted site, every time I visit "whitelist page" or "report broken site" or "trackers found"...mp_wla is sent without any interaction

Good catch! Fixed.

Every time I visit privacy dashboard from a whitelisted site, I see the toggle moving from enabled to disabled

The visible ui update as the user enters the screen is preexisting behavior. We have had no feedback about and as we expect to either completely redesign or even delete this screen we have no plans to fix it.

If I go to privacy dashboard and I switch the toggle twice (interacting but keeping the original state), and going back to the browser, page will reload. is that expected?

Yes. It's it is an easier implementation this way and I don't think users will find it odd that the page reloads after they have interacted with the toggle. I like your idea of being smarter and only reloading when the value has truly changed (on an odd number of toggles) however I don't think it's worth investing in that level of polish when we are soon deprecating this screen. If we receive feedback that this is unacceptable, we can reconsider. Let me know if you feel strongly otherwise.

If I visit a website -> then I whitelist that site from settings -> I go back to the browser -> website doesn't reload. Is that something we expect? or should we detect the change and reload the site?

Yes this is expected. If the user is in the context of a site and they toggle protection either through the dash toggle or the whitelist menu button then we reload. If the go to whitelists screen via settings however and start adding and removing entries, the user is now outside the context of the current page. We could make this fancier but it also adds complexity. Let me know if you feel strongly about this though.

When switching the site privacy protection toggle, should we change somehow the privacy grade to the user

Again this is preexisting behavior and as we expect to be deprecate this screen this isn't something we plan to change right now.

Noticed we removed the trackers statistics from the privacy dashboard

Oh no that shouldn't happen, thanks for catching it. Fixed! Beware though there is another outstanding issue in develop in this area due to a change from percentage to ratio for prevalence in the backend API. To see any results you'll need to update Entiry.kt to have MAJOR_NETWORK_PREVALENCE = 0.7

Thanks for the awesome review 🙏


Add Support and Documentation for Kerberos Constrained Delegation

Description of the Change
Adds Support and Documentation for Kerberos Constrained Delegation to use the current user session against a backend application like a SQL Database
Related Issue
Closes #667
Examples
Pode can impersonate the user that requests the webpage using Kerberos Constrained Delegation (KCD).
This can be done using the following example:
[System.Security.Principal.WindowsIdentity]::RunImpersonated($WebEvent.Auth.User.Identity.AccessToken,{
    $newIdentity = [Security.Principal.WindowsIdentity]::GetCurrent() | Select-Object -ExpandProperty 'Name'
    Write-PodeTextResponse -Value "You are running this command as the server user $newIdentity"
})

Alright, Pull Request ready to be merged.

Alright, Pull Request ready to be merged.

LGTM!

LGTM!


Fix FmtToIoWriter::write_str to call write_all

I experienced bytes being silently dropped when serializing large objects to compressed files using serde_yaml and flate2/bzip2. I believe this PR will fix the issue, but I haven't tested it yet to confirm. Regardless, it's clear that this change is necessary so that FmtToIoWriter meets the contract of std::fmt::Write.
Previously, the implementation could silently fail to write some bytes. Now, the implementation should either write all the bytes or return an error.
The docs for std::fmt::Write::write_str say, "This method can only succeed if the entire string slice was successfully written, and this method will not return until all data has been written or an error occurs." So, FmtToIoWriter::write_str must call std::io::Write::write_all instead of std::io::Write::write on the inner writer in order to ensure that all the bytes are written.

Thanks for merging the fix and releasing a new version so quickly! Thanks also for writing and maintaining the serde_yaml crate. It's been really useful to me.


hit UnhandledPromiseRejectionWarning when using this module with https://github.com/IBM/cloudant-node-sdk

I'm working on change cloudant module to https://github.com/IBM/cloudant-node-sdk, and for authentication purpose, I'm using
const { CloudantV1 } = require('@ibm-cloud/cloudant');
const { IamAuthenticator } = require('ibm-cloud-sdk-core');
cloudantDB = CloudantV1.newInstance({
	authenticator: authenticator,
	httpsAgent: keepAliveAgent,
	serviceName: cloudantIamClientId || "pipeline-ui",
	serviceUrl: config.cloudantUrl
});

when I testing my code locally, I hit the following UnhandledPromiseRejectionWarning, do I need to be worried?

I think I need a bit more context to understand what is going on. Are you seeing this error when executing just that small snippet above, initializing the client instance? If not, can you share more of the code?

no, I hit the error when there's a request need to get data from cloudant.  Basically when cloudant node module need to talk to cloudant the fetch data. I can't really tell when that happened, but I'm sure it's not during initialization.  I spotted that later on when I looking through the logs

that is not my case. All our cloudant code looks like
		return cloudantDB.getDocument({db: DB_NAME, docId: pipelineId}).then(
			(response) => {
				toCollectData.result = response.result;
			},
			(error) => {
				toCollectData.error = error;
			}
		)

and it is very clear from my original message that the uncaught exception is from ibm-cloud-sdk-core module

that is not my case

Thanks for showing the code you are using. The Object Not Found and not_found parts of the error are consistent with the 404s produced by CouchDB/Cloudant and not, for example, the IAM authenticator. So I'd still recommend trying to find which request is receiving the 404 as it might indicate the path by which an error can bubble up unhandled.

it is very clear from my original message that the uncaught exception is from ibm-cloud-sdk-core module

I don't think it is very clear. The code sample missing the catch I used reproduces the same UnhandledPromiseRejectionWarning at the core lines 290 & 275:
(node:28631) UnhandledPromiseRejectionWarning: Object Not Found: not_found
    at RequestWrapper.formatError (.../node_modules/ibm-cloud-sdk-core/lib/request-wrapper.js:290:21)
    at .../node_modules/ibm-cloud-sdk-core/lib/request-wrapper.js:275:45
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

and the stack in the screenshot doesn't reveal which function ultimately made the request that gets rejected.

I see, I will look through our code again then. Thanks. But it's kinda strange that 404 is not thrown from cloudant module but from ibm-cloud-sdk-core.

Btw, isn't
(error) => {
	toCollectData.error = error;
}

the catch? I'm kinda sure it does the same thing as catch.. https://dmitripavlutin.com/javascript-promises-then-vs-then-catch/

I see, I will look through our code again then. Thanks. But it's kinda strange that 404 is not thrown from cloudant module but from ibm-cloud-sdk-core.

Any exception due to an error status code being received from the server (such as a 404) will result in the node core's request processing code throwing the exception as you have experienced.   That exception will be thrown by the core and then propagaged up through any generated SDK code (i.e. the code within the cloudant SDK) to your application code that invoked the operation.   One way to diagnose this further would be to enable debug logging of requests/responses so you can see the http traffic for each invocation.  You should be able to see the 404 response coming back and identify exactly which operation it was.   More details about this can be found here: https://github.com/IBM/node-sdk-core#logging

I think I found what's going on.. There's a call path that doesn't have try/catch on the outmost layer.
I'm ok to close this issue now.. Thanks for the help.


HIVE-24408: Upgrade Parquet to 1.11.1

What changes were proposed in this pull request?

Upgrade Parquet version from 1.11.0 to 1.11.1
Why are the changes needed?

Parquet 1.11.1 has some important bug fixes so it would be beneficial to upgrade to it.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

N/A

Thank you so much, @sunchao !

Do you think we can merge this to master, @sunchao ?

@dongjoon-hyun yes we'll need this to be approved by a committer first though - @jcamachor could you review this? since you have done something similar earlier by upgrading Parquet to 1.10.0

Thank you, @jcamachor and @sunchao !

Thanks @jcamachor for merging!


azd down: error deleting Azure resources: no resources found for deployment

Hi, I'm testing out Azure HCI (Azure Local) Jumpstart - HCIBox.
I have successfully created and deployed environment, but now I want to delete all resources via azd down command.
https://arcjumpstart.com/azure_jumpstart_hcibox
I have not closed the power shell that I have used to deploy HCIBox.
So in the same opened shell when I enter azd down I get error:
azd down

Deleting all resources and deployed code on Azure (azd down)
Local application code is not deleted when running 'azd down'.

ERROR: deleting infrastructure: error deleting Azure resources: no resources found for deployment, 'crayonhcibox-1733261629'

Since Im still in the same shell that I used to deploy HCIBox with azd up this was the link generated for deployment:
azd up
? Select an Azure Subscription to use:  1. subscription (<MY SUB ID>)
? Select an Azure location to use:  2. (Europe) West Europe (westeurope)
? Enter a value for the 'windowsAdminPassword' infrastructure secured parameter: [? for help] **************

Packaging services (azd package)

Connecting to Azure...
Setting Azure context with subscription id <MY SUB ID> and tenant id <MY TENANT ID>...
Setting Azure CLI context to the same subscription as Azure PowerShell...
Registering Azure providers...

Checking for available capacity in westeurope region...

✅ There is enough VM capacity in the westeurope region to deploy the Jumpstart environment.

Enter the Windows Admin Username [arcdemo]: crayondemo
Configure Azure Bastion for accessing HCIBox host [Y/N]?: y
Attempting to retrieve Microsoft.AzureStackHCI provider id...
Configure automatic Azure Stack HCI cluster validation and creation? [Y/N] : y
Automatically download and install updates to cluster nodes if available? [Y/N] : y
Checking for existing stored Azure service principal...
Attempting to create new service principal with scope /subscriptions/<MY SUB ID>...

Provisioning Azure resources (azd provision)
Provisioning Azure resources can take some time.

Subscription: MVP Azure subscription (<MY SUB ID>)
Location: West Europe

  You can view detailed progress in the Azure Portal:
  https://portal.azure.com/#view/HubsExtension/DeploymentDetailsBlade/~/overview/id/%2Fsubscriptions%2<MY SUB ID>%2Fproviders%2FMicrosoft.Resources%2Fdeployments%2Fcrayonhcibox-1733261629

  (✓) Done: Resource group: crayonhcibox-rg (2.065s)
  (✓) Done: Virtual Network: HCIBox-VNet (3.023s)
  (✓) Done: Log Analytics workspace: HCIBox-Workspace (16.715s)
  (✓) Done: Storage account: hciboxhtvodlufq7ing (22.794s)

Deploying services (azd deploy)

SUCCESS: Your up workflow to provision and deploy to Azure completed in 17 minutes 37 seconds.

If I open that link I can see in portal all the resources deployed, so it is available:

I have tried to reauth to that opened shell with both azd auth and Connect-AzAccount with setting context to the correct subscription used for deployment - still the same error.
Can I just delete RG with all resources and be done with it?

Yes, you can just delete the resource group directly.


fix: add missing functions on native

Fixes: https://github.com/withered-magic/starpls/issues/248
Adds the missing register_toolchains() and register_execution_platforms() functions on the native type.

Checked that it works with this change. Thanks!


Highlighting logic was decoupled from the component TRNG-1479

Description

This PR decouples highlighting logic.
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Just try all the combinations possible with the highlight behavior, highlight property, and the highlight interactable.
Relates

https://github.com/Innoactive/Basic-Interaction-Component/pull/44

/azp run

:tada: This PR is included in version 1.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


getting errors while using terminal

when i load terminal it gives me below errors.
bash: error importing function definition for `scl'
/bin/sh: scl: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `scl'
/bin/sh: module: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `module'
/bin/sh: scl: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `scl'
/bin/sh: module: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `module'
/bin/sh: scl: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `scl'
/bin/sh: module: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `module'

OS : FEDORA 26
ATOM : 1.18.0-0.1

I have this exact error as well.
OS: Fedora 26
Atom: 1.18.0

Hmm... This does not appear if atom is launched via terminal. Only occurs (for me) if launched from Gnome

This problem is a user misconfiguration in Fedora, try the solution of @cnicodeme (https://github.com/AtomLinter/linter-flake8/issues/165)
For all others that have the same issue here, and are using Fedora, the solution is simple :

Remove scl-utils : sudo dnf remove scl-utils. Don't worry, it's not useful on Fedora (it's more RHEL related)
Reboot, and you won't have the problem again. This is important, if you don't reboot, nothing will change. (Don't ask me why!)

Please retest again with platformio-atom-ide-terminal 2.9.0 is using node-pty-prebuilt instead unmaintained and outdated pty.js

@alexfornuto see https://github.com/platformio/platformio-atom-ide-terminal/commit/f64888d6d134f7e06bbb13a762dfd45335e8a4ba
Its a considerable change in the application, this project no longer uses pty.js, any previous reports are invalid against node-pty-prebuilt version which start at 2.9.0.
If that doesnt fix the issue, a new report with the requested/required information will be necessary.

@the-j0k3r thanks, that clears up my confusion.
For reference, my issue wasn't with the technical decisions made. Your sentence simply lacked the form (punctuation, etc) required to convey the information. Now I understand, and if and when I use Atom again and hit an issue with the newer versions I will open a new issue.


Temperature Converter in native-JS

Temperature Converter using Javascript, css, html

Temperature Converter is a webpage that converts celsius to fahrenheit (vice-versa)

Hello, can I work on this issue for you! Im doing a school project, and find this intresting.

@sadanandpai There are some issue while importing navbar in the way you suggested under javascript, so i am converting that code in react for temperature converter and then making a pr.

@sadanandpai There are some issue while importing navbar in the way you suggested under javascript, so i am converting that code in react for temperature converter and then making a pr.

if all good plz close the issue

Please assign me this issue

@sadanandpai @arpansaha13 Assign this issue to me

in this i need to add a additional challenges of temperature  converter like currently we have the same in react case ??

what additional challenge?

Currently this challenge doesn't exist in native-js section. So you need to create a new one and then add the code in its respective folder in machine-coding/. You can refer to JavaScript Challenges Contributing guidelines.

I mean to say that the task is to add a card / feature of temperature converter in case of native one right?

yes

Can I take up this task?

Can I take up this task?

Sure, just open a PR with your solution

Closing due to inactivity


response headers with content-type json?

Quick question...
isnt dingo supposed to return responses with content-type application/json? I'm getting text/html; charset=UTF-8 Anyone has any clues about this?

Just figured it out.
The issue was not on the Dingo package.

What was it ?


Add a sidenav navigator to the documentation pages (WIP behind a feature flag, off by default)

Bug/issue #, if applicable: 89031049
Summary
This PR introduces a few new UI changes, that are scoped only to the documentation pages. The features are all DISABLED, by default, but can be enabled by a feature flag in the theme-settings.json file, under features.docs.navigator.enable:

New adjustable layout
A sidebar tree navigator
Updated nav layout and breadcrumbs logic

This work covers both of the proposals:
https://forums.swift.org/t/new-swift-docc-content-styling/55326
https://forums.swift.org/t/swift-docc-sidebar/55250
Dependencies
https://github.com/apple/swift-docc/pull/84
Testing
Make sure you download and unzip the .doccarchive - SlothCreator.doccarchive.zip
Steps:

run VUE_APP_DEV_SERVER_PROXY=/path/to/SlothCreator.doccarchive npm run serve
Visit http://localhost:8080/documentation/slothcreator
Assert that a sidebar tree navigator is rendered.
Assert that you can open/close items and click on the links to navigate to a page
Assert that navigating across pages does not loose open/closed state. Even on refresh.
Assert that going back/forward works and re-highlights the current item you are on, opening all parents so its visible.
Assert you can filter on items and its not slowing down the browser even for very broad queries.
Assert that the navigation layout does not go outside of the content container
Assert that the navigation breadcrumbs reduce in size and collapse, based on screen size.
Assert that the content has a maximum width, after which it gets centered (around 1800px)

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

@mportiz08

I also have one very high level concern that we should think about for this: what should the UX for this be when rendering older content (content with no index data yet). I realize that we won't be able to display any useful content in the sidebar in this situation, so maybe we should consider disabling/hiding the sidebar when that happens. Also, is there anything in the render JSON for the page itself that we can check that gives us an indicator that the index exists? If not, we could get into a situation where we get a 404 for the index on every page of older content where it hasn't been generated yet.

Very good question. Currently it just says there are no children available. We could hide the entire navigator in such cases, like we do for IDE targets, but then we might need to tune the css for content a bit.
As for the RenderJSON, apart from the schema version, I dont think there is anything else, right @ethan-kusters?

As for the RenderJSON, apart from the schema version, I dont think there is anything else, right @ethan-kusters?

Correct- we could consider bumping the patch version of the RenderNodeJSON when we enable emitting a RenderIndexJSON by default. That would be less than ideal since this isn't actually a change in the RenderNode schema though.
Is it possible to just check for the existence of the index file or would that cause a page flicker?

Is it possible to just check for the existence of the index file or would that cause a page flicker?

Well unless we delay the entire page until we have the sidebar stuff, it would flicker, yes.

@swift-ci test

@swift-ci test

@swift-ci test

We have hidden this new navigator UX by default for now and have provided a feature flag to enable it and opt-in to the new experience.
This will allow us to merge this PR as-is for now, and we can continue to iterate on the feedback that has been brought up in the forums and the PR.
Thanks everyone!


Various updates to witness plugin

These changes remove deprecated Gradle features that make the plugin incompatible with Gradle >= 5.0.
With this, we upgrade to Gradle 5.4.1.
We also take this chance to move from Groovy to Kotlin:

we first migrate the build script (build.gradle -> build.gradle.kts)
then, we migrate the plugin implementation (WitnessPlugin.groovy -> WitnessPlugin.kt)

We also remove the reproducibility custom tasks in favor of Debian's strip-nondeterminism tool. Here are the reproducible build steps: https://github.com/rsksmart/reproducible-builds/pull/12.

Why should we migrate the implementation?

We have more people with experience in Kotlin than in Groovy in the company. Kotlin also brings benefits such as type-safety and better IDE integration.
https://blog.gradle.org/kotlin-meets-gradle
https://guides.gradle.org/migrating-build-logic-from-groovy-to-kotlin/
https://dev.to/jmfayard/how-kotlin-makes-editing-your-gradle-build-less-frustrating-232l

I agree the gradle upgrade and removing the reproducible gradle task. Not changing a language just because you like it and want to.
Gradle already uses groovy, so your are just adding another language and complexity, not solving any problem.
This a security plugin and changes has not to be taken lightly.

The issue you mention about complexity doesn't sound right. Gradle is written in loads of different languages:

Maybe these changes can be audited so we can move forward?

Hi everyone,
I'll be reviewing this changes to make sure we have not introduce any unintended change on the move from Groovy to Kotlin. This should be fairly quick so you can move on with other, more interesting tasks :)
I'll also be reviewing more generally our whole implementation of reproducible builds to make sure we are correctly checking our dependencies. I'm sure I'll need your help @collheesi & co, so I'll probably be approaching you guys one of these days so I'm positive I understand our current strategy.
Also, and for future reference, I think it would be better for everyone if  changes on critical security components like these are discussed with security before work on them is started. This is so we can all agree on an optimal strategy to move forward the codebase and no one wastes times working on a feature which may be problematic :).
I'll get to it!

LGTM :). Kotlin code effectively does the same as the previous Groovy code.

Thanks, my fault!

As requested:

I added functional tests using Gradle's TestKit
I implemented #2, with an exclude list for snapshot dependencies

CC @bcodesido @joaquinlpereyra-iov


Promo codes activation API method

You should implement logic for fake code activation and store history of codes activation (add new model with mongoose and write data to DB).
Appropriate test located in

test/api/routes/partner-service/client-service.js:128

Case: if client activate code "SOMETEXT1900" then he got message "Code with discount 1900 was activated successfully" (last digits in code is value of fake code). In test I use random number.
Example of response body you can found in

api/routes/partner-service/client-service.js:52

PS. Sorry for my English.

Fake activation code service is done.
Method takes string -> cut discount amount from that string -> saves CodeName and DiscountValue.


Method syntax not accounted for in object literal completion filtering

interface I {
    a(): void;
    b(): void;
}

var x: I {
    a: () => { },
    /**/
}

Request completion at the /**/. a should not appear in the list.
Now change the declaration of a to a method declaration:
interface I {
    a(): void;
    b(): void;
}

var x: I {
    a() { },
    /**/
}

Request completion at the /**/. a now does appear in the completion list.

Thanks @DanCorder!


Add simple validation for Name and URL in the settings page

For #181.
Tested on Windows 10. The appearance is below.

It's only for the appearance of html, so I think it's enough if we have one tester. Artifacts are available at https://circleci.com/gh/yuya-oc/desktop/7#artifacts

Thanks @yuya-oc!
During testing, I expected to be able to click on the 'Add' button, after which the error would be shown.
I actually didn't see the Name is required on my first read.
Not sure if others have thoughts?

Ah, surely we didn't define the timing to show validation. I expected the user can't click 'Add' until all input fields are validated. The user can know what is wrong before clicking the button.

Thanks @yuya-oc, makes sense.
Showing the error message after a user attempts to add the team would be more consistent with the rest of the Mattermost experience.
Would it be a lot of work adding this change?

@jasonblais Thanks for feedback. Probably it's not hard, so I'll try later.

Updated. The artifacts are here. https://circleci.com/gh/yuya-oc/desktop/10#artifacts

Tested on Windows 10, looks great. Thank you @yuya-oc !


Can run custom tasks in Gobblin.

This PR allows running custom tasks in Gobblin.
To use custom tasks, implement a TaskFactory and use TaskUtils.setTaskFactoryClass(WorkUnitState, Class<? extends TaskFactory> in the Source. Tasks need to implement TaskIFace.

@ydai1124 @htran1 can you take a look?

@ydai1124 thanks for the comments. Addressed them.


oopsyraidsy doesn't work on KR 6.31

Description
oopsyraidsy only prints information like this:
Username: unkown_0000 (10000/10000)
Username2: unkown_0000 (10000/10000)
Username3: unkown_0000 (10000/10000)
it doesn't print gimmick mistake, it only prints wierd damage taken messages

Can you include a network log for some content that has oopsy support?

@quisquous omega's skill name is not properly parsed by act.
21|2023-07-26T16:39:21.1790000+09:00|40001600|오메가|7BFD|unknown_7bfd|1016DC86|Name|730003|0|0|0|0|0|0|0|0|0|0|0|0|0|0|0|108346|108346|7800|10000|||100.14|109.10|0.00|3.14|8424620|8557964|10000|10000|||100.02|100.82|0.00|0.01|0000015D|0|1|1a6ceac4d686df90
20|2023-07-26T16:39:29.0220000+09:00|40001600|오메가|7B03|unknown_7b03|40001600|오메가|3.700|100.02|100.82|0.00|3.13|6445ec63b5274f73
21|2023-07-26T16:39:47.0170000+09:00|40001600|오메가|7B07|unknown_7b07|40001600|오메가|1B|7B078000|0|0|0|0|0|0|0|0|0|0|0|0|0|0|5526693|8557964|10000|10000|||100.02|100.82|0.00|0.00|5526693|8557964|10000|10000|||100.02|100.82|0.00|0.00|0000025A|0|1|6b8fa328c7a78417

Is that a line break? Can you attach a network log for me to look at? https://github.com/quisquous/cactbot/blob/main/docs/FAQ-Troubleshooting.md#how-to-find-a-network-log

Network_24201_20230803.zip
@quisquous this is full network log

OH! I'm sorry for taking so long to figure this out. I completely misunderstood what the issue is. This is something that Ravahn needs to fix.  I filed https://github.com/ravahn/FFXIV_ACT_Plugin/issues/317 for this.  Feel free to follow up there or in the ffxiv act discord.


feat: add gio-confirm-dialog component

Description
Add a ConfirmDialog component that could be embedded in a model to ask for confirmation from the user.
Once the dialog is closed, we received a boolean that allows us to know if the user has confirmed or canceled.
Screenshots

Additional informations
The component comes from APIM

📚  View the storybook of this branch here

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

I've removed to much comments 🙈
To install the pre-released version:
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

I've just asked the UI/UX team to provide feedback about the design

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:tada: This PR is included in version 3.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix(ngRoute): dont duplicate optional params into query

When calling updateParams with properties which were optional, but
previously undefined, they would be duplicated into the query params as
well as into the path.
jsfiddle reproduction
From #updateParams docs:

Provided property names that match the route's path segment definitions will be interpolated into the location's path, while remaining properties will be treated as query params.

In the actual implementation of updateParams the "remaining properties" are determined prior to interpolation by checking if the pathParam for the given key has a value; however, optional parameters may not exist in pathParams.
Alternative fixes might include

(probably better) running interpolate before separating searchParams, since it will remove matched keys from the passed in newParams object.
(maybe more correct?) include undefined optional params in the pathParams object (switchRouteMatcher L536, if (key && val) -> if(key)) and then check for the property as opposed to truthiness

This sounds reasonable to be but I think the implementation can be much more simple:
updateParams: function(newParams) {
  if (this.current && this.current.$$route) {
    newParams = angular.extend({}, this.current.params, newParams);
    $location.path(interpolate(this.current.$$route.originalPath, newParams))
      .search(newParams);
  }
  else {
    throw $routeMinErr('norout', 'Tried updating route when with no current route');
  }
}

Corporate CLA just sent over

@shahata Yeah that was my first alternative suggestion - I'll push the change

We sent over details about the new Google Group based CLA authorization on Monday. Haven't heard back, but maybe we're good to go?

@shahata - can you check with the guys in the office that the CLA is good then look at merging this when you are happy with it?

@shahata @petebacondarwin  Alright, actually got the e-mail back now, CLA should be good to go


All the links in contribution guideline is broken

The contributing guidelines need to be fixed immediately. Issue creation guideline specially. We need to enforce adding label as one of the behaviours while creating a new issue.
cc- @tsov

Hello there, can I take up this issue?


Ascender on first line number appear slightly when collapsed.

The top part of the "1" for the first line number appears partially when the code block is collapsed. See example.

I found the problem, when the font was too small it would show.
I will try to fix the problem.


Top-right context switcher navigation dropdown

In order to model the context concepts for our various luigi customers (environment selector in kyma, tenant switcher in cds, etc.), we need to have a context switcher ui control, see "Context Switcher" on https://sap.github.io/fundamental/demo-pages/sidebar-app-demo.html

Still two issues:

If path starts with some value as the context switcher parentNodePath, the remaining part is considered by context switcher as a subpath.
if you navigate to environments, the route is set to environments/:environmentId, which is obviously wrong.

 If there are no options loaded, use FallbackLabelResolver to get the label for the closed context switcher.


Release 0.1.1

@JuliaRegistrator register(branch=release)

Registration pull request created: JuliaRegistries/General/11615
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.1 -m "<description of version>" 5594231ae59315e4ea3e09bd80661e7ca59d33dd
git push origin v0.1.1


Is there naywhere that explains what the visual settings are

Just a question, sorry couldn't find this anywhere:
Is there anywhere we can adjust settings to change like, the animation speed, blur, etc.?

Nevermind


Question: is the project on hold?

Quote from readme:

This project, a Dart binding for llama.cpp, is currently on hold as we await the porting of llama.cpp helpers code to C

Is there a link, potentially to the github issue in the llama.cpp repository so we can understand and follow on the status of the dependency?
Thank you very much for this project!

@yuvalr1 yes, but not for long as https://github.com/ggerganov/llama.cpp/issues/5214 was resolved lately, this will allow generate binding without C wrappers.

Thanks @netdur!
I'm ok with closing the issue unless you want to leave it open.

@ArachnaDigitalLtd dev branch is now available for review. while it's still a work in progress, the implementation is functional and ready for testing
@yuvalr1 I will close once with release of v0.0.8

Congrats for resuming work on this project @netdur  !
Highly beneficial for the Flutter community. I will give it a try as I wish to move from my prev implementation to yours. Hope to contribute one day if I get to use it.
Is there any details on what is actually supported from the official current llamacpp API / what is not?
Thank you again


RemoveRowsOrColumsAndShift Throws: System.OverflowException: 'Arithmetic operation resulted in an overflow.'

This happens when I try to delete any row.
I can't reproduce this with anything but my own code :(
https://github.com/ADefWebserver/BlazorDatasheet/blob/main/src/BlazorDatasheet.SharedPages/Pages/DataEditor/DataEditor.razor

Any ideas?

The only thing I think is different is I did add a custom renderer to my project.

I removed the custom renderer and it still throws the same error.
I'm basically stuck :(
This is what Copilot says...

I'll have a look. I made some changes last week to row/column removals that may have caused this.

I found my problem:
sheet.Cells.SetType(new ColumnRegion(i), objDatabaseColumn.ColumnType);
If I take this line out the problem goes away. I suspect ColumnRegion(i) is creating the huge value.
The reason I put it in is that it allows my custom renderer to show up on new rows;

My full code:
https://github.com/ADefWebserver/BlazorDatasheet/blob/main/src/BlazorDatasheet.SharedPages/Pages/DataEditor/DataEditor.razor
private void LoadTableHeadersAndData(List<DTODatabaseColumn> paramDatabaseColumns, DataTable paramDataTable)
{
    // Create sheet with the number of columns
    sheet = new Sheet(paramDataTable.Rows.Count, paramDatabaseColumns.Count);

    // Turn off history
    sheet.BatchUpdates();
    sheet.Commands.PauseHistory();

    // Hide the _Id column
    sheet.Columns.SetWidth(0, 0);

    int i = 0;
    foreach (DTODatabaseColumn objDatabaseColumn in paramDatabaseColumns)
    {
        // Set the column headings
        sheet.Columns.SetHeadings(i, i, objDatabaseColumn.ColumnName);

        // Set the column types
        // *** If I take this out the problem goes away ***
        sheet.Cells.SetType(new ColumnRegion(i), objDatabaseColumn.ColumnType);

        if (UseValidation)
        {
            // Integer Validator
            if (objDatabaseColumn.ColumnType.Contains("int"))
            {
                sheet.Validators.Add(new ColumnRegion(i), new NumberValidator(false));
            }

            // Length Validator
            if (objDatabaseColumn.ColumnLength > 0)
            {
                if (objDatabaseColumn.ColumnType.Contains("char"))
                {
                    sheet.Validators.Add(new ColumnRegion(i), new LengthValidator(objDatabaseColumn.ColumnLength, true));
                }
            }
        }

        i++;
    }

    // Load the data into the sheet
    int ii = 0;
    foreach (DataRow dataRow in paramDataTable.Rows)
    {
        i = 0;
        foreach (DTODatabaseColumn objDatabaseColumn in paramDatabaseColumns)
        {
            // Set the cell value
            sheet.Cells[ii, i].Value = GetCellValue(dataRow[i].ToString(), objDatabaseColumn.ColumnType);

            if (objDatabaseColumn.IsPrimaryKey)
            {
                // Set the cell to read only if it is a primary key
                sheet.Cells[ii, i].Format = new CellFormat() { IsReadOnly = true, BackgroundColor = "lightgrey" };
            }

            i++;
        }

        ii++;
    }

    // Wire up a method to catch cell changes
    sheet.Cells.CellsChanged += CellChanged;

    // Wire up a method to catch row changes
    // Do not allow the last row to be deleted
    sheet.Rows.RowRemoved += (sender, args) =>
    {
        // Turn off history
        sheet.BatchUpdates();
        sheet.Commands.PauseHistory();

        if (sheet.NumRows == 0)
        {
            sheet.Rows.InsertRowAt(0);
        }

        // Turn off history
        sheet.EndBatchUpdates();
        sheet.Commands.ResumeHistory();
    };

    // Turn on history
    sheet.EndBatchUpdates();
    sheet.Commands.ResumeHistory();
}

Thanks, adding as a column region is the correct way to add the type, I had a silly mistake whereby I was trying to sum areas of column/row regions which caused the overflow. Should be fixed now.

@anmcgrath - Fixed! Thank you so much for fixing this so fast. Normally I would diagnose and provide a proposed solution, but it would have taken me several weeks to study and understand the complexities of how this code works. This is a REALLY advanced control. It took all my free time this week to comprehend how the custom renderer works and that is actually straightforward once you understand it :)

No worries. I think a lot of the complexity in the data structures comes from having to implement undo/redo which I've found really hard.
Yeah sorry it took you so long for the custom renderer, it would help if I had some better documentation for the project, which I'm planning on putting together.


add tunnelbroker endpoint updater

Please check your repo changes ... Testing fails
https://travis-ci.org/ioBroker/ioBroker.repositories/builds/519746881#L498

Please check your repo changes ... Testing fails
https://travis-ci.org/ioBroker/ioBroker.repositories/builds/519746881#L498

Done

Hey, welcome in the repo :-)
A small review note:

if you do not need "On object change" then remove it.
same for on state change


[BUG] Theme does not work with the new Spicetify 2.7.1 version

Describe the bug
The theme does not seem to work with the new Spicetify version at all.
To Reproduce
Steps to reproduce the behavior:

Upgrade to 2.7.1
Open Spotify

Screenshots

Desktop (please complete the following information):

OS: macOS Big Sur 11.6
Version: <IP_ADDRESS>0.g4585142b

No it is not the official light theme one. Once you update to 2.7.1 and you hit spicetify apply the theme goes completely into light mode even though my settings are dark mode and the dribblish settings are also completely gone and the theme no matter which song is played does not change at all. I have redownloaded the latest DribbblishDynamic multiple times and attempted to apply it several times but it still does not work.


Add local participant to onRoomDidConnect (#472)

ios change

update ts file

Add localParticipant to the onRoomDidConnect event on android

fix

fix 2

Update docs

@matiasrb97 Just would like to note that need to make sure the new JS part will work seamlessly with old binaries, i.e. when roomDidConnect doesn't return localParticipant arg, otherwise autoupdates will crash the current binaries.

Can you change your base branch to evisit-main? I just created this branch to track the lastest.