Routing breaks when using Frame.goBack(to: BackstackEntry)

From @abinici on March 21, 2017 20:39
Tell us about the problem
Lets say we have an app that consists of 4 pages, and lets name these pages page1, page2, page3 and page4. And lets say that we have navigated from page1 to page4, visiting page2 and page3 along the way.
Now, I wish to go back to page2 using Frame.goBack(to: BackstackEntry) by looking up page2 this way frameModule.topmost().backStack[1]. Then if I try to navigate to page3 nothing will happen. Navigating back to page1 works, but navigating forward still doesn't work.
If, instead of navigating to page2, I navigate to page1 or page3, routing will not break.
Which platform(s) does your issue occur on?
Both
Please provide the following version numbers that your issue occurs with:

CLI: 2.5.0
Cross-platform modules: 2.5.2
Runtime(s): iOS and Android: 2.5.0

Please tell us how to recreate the issue in as much detail as possible.
I have created a sample app that reproduces this issue: https://github.com/abinici/ns-goback-issue
Copied from original issue: NativeScript/NativeScript#3848

Hi @abinici,
Thank you for your interest in NativeScript.
This is something expected when using FrameModules in this way in NativeScirpt Angular 2 project.
Using frameModule for navigation is a concept used in NativeScirpt core project. Regarding this module, the purpose of goBack() method is to give you simple way to navigate to the previous page. In case you would like to make navigation  in a pure NativeScirpt project, you should use navigate(<page_name>) method, where you should specify the page name.
In your case, when you are using NativeScript Angular 2 template, there is another way to making navigation. First of all to in this type of project you should use angular Router module or RouterExtensions, which extends the angular one. For example:
Navigate to another page.
import { Component, OnInit } from "@angular/core";
import { ActivatedRoute, Router } from "@angular/router";
import {RouterExtensions} from "nativescript-angular/router"

import frameModule = require("ui/frame");

@Component({
    moduleId: module.id,
    selector: "page4",
    templateUrl: "./page4.component.html",
})
export class Page4Component implements OnInit {
    constructor(
        private route: ActivatedRoute,
        private router: Router,
        private routerExt:RouterExtensions
    ) {}

    ngOnInit(): void {

    }

    goback() {
        this.router.navigate(["page2"]);
    }
}

Navigate to the previous page.
import { Component, OnInit } from "@angular/core";
import { ActivatedRoute, Router } from "@angular/router";
import {RouterExtensions} from "nativescript-angular/router"

import frameModule = require("ui/frame");

@Component({
    moduleId: module.id,
    selector: "page4",
    templateUrl: "./page4.component.html",
})
export class Page4Component implements OnInit {
    constructor(
        private route: ActivatedRoute,
        private router: Router,
        private routerExt:RouterExtensions
    ) {}

    ngOnInit(): void {

    }

    goback() {

        this.routerExt.back();
    }
}

For further info, you could also review the documentation.

Hi @abinici,
You could still use NativeScirpt  RouterExtensions module and its navigate method in combination with clearHistory option, which will allow you to disable saving the page to the back stack history.
For example:
login() {
    // app logic here ...
    this.routerExtensions.navigate(["/main"], { clearHistory: true });
}

For more info review the documentation.
Hope this helps.

From @abinici on March 23, 2017 9:55
Hi @tsonevn,
I understand that the routing in Navigation Core and Angular is different. But Nativescript Angular is missing the functionality I needed. Thats why I began using Framemodule, because it had the method goBack(to: BackstackEntry), which I was hoping could solve my problem.
And to elaborate this, I dont want to go to previous page. I wish to go 2 or more pages back in history. So, when I navigate from page4 to page2, I want the pages page4 and page3 removed from the stack, in one single action. How can this be accomplished with Nativescript Angular?
I am guessing that the only way resolve this with Nativescript Angular is by calling routerExt.back() multiple times, but this is not optimal.
I think methods like these would help a lot: routerExt.goBack(url: string) or routerExt.goBack(steps: int)

From @abinici on March 28, 2017 14:15
Maybe this issue should be moved to https://github.com/NativeScript/nativescript-angular?

From @abinici on March 28, 2017 13:34
Hi @tsonevn,
I tried your suggestion, when navigating from page2 to page3, but then my back navigation button disappears on page3, which prevents the user from navigating back to page2.
What I am trying to accomplish, is that the pages that the user navigates to, such as page2, page3 and page4, should all be put on the stack so that user is not prevented from navigating back from page4 to page3 and page2.
But when hitting a button on page4, I would like the user to be taken back to page2 without having to visit page3.
The function I am looking for is something like popToRoot in Ionic2: http://ionicframework.com/docs/v2/api/navigation/NavController/#popToRoot
You use setRoot() to set a root for the current navigation stack.
Currently, I am forced to use Frame.goBack(to: BackstackEntry) and then I have to call pop() x times in this.routerExtensions.locationStrategy, to keep things in sync (I have added a pop-method to NSLocationStrategy). Obviously, this is an ugly hack, but I dont know the implementation well enough to make things the pretty way.
Maybe you could give me some directions so that I or someone else could implement this functionality in a PR, with something like back(steps: int) or back(url: string)?

Hi @abinici,
Indeed this is a valid feature - an ability to navigates back to the specific page.
While building the router navigation in NativeScript Angular 2 project, we have not thought about supporting this feature.
Regarding that, I will change the label of the issue to Feature request and we will research, what is the best way to implement this functionality for  NativeScript Angular 2.
In the meantime, you could call goBack()  method to navigate back to the needed page as you have suggested in your previous comment.
You could also keep track on the issue for further.

From @jogboms on July 12, 2017 21:32
This feature would make so much sense if added. I had to use a workaround when I needed a similar feature. Using the navigationFrom and checking for BackButton navigation to route to the desired page. Angular's implementation of skipLocationChange would have simply done the much-needed trick.

From @phattranky on April 24, 2017 8:51
Need same feature like @abinici  :)

From @bhavincb on April 5, 2018 7:1
+1

From @cindy-m on January 29, 2018 13:21
Is there any indication when this feature will be available? We would also really like to use it instead of using tricks with the clear history and self made back buttons or other hacks to get it to work as intended

From @ThunderAnimal on June 4, 2018 15:54
+1

From @ThunderAnimal on June 4, 2018 16:19
@abinici how is you pop method looks like? I want to solve the issue with the same workaround. But actually I have no Idea how to solve it, first i was thinking to just pop the state array, but it is not working pretty well :D
One solution to extend the NSLocationSrategy without change the file itself could be that:
(<any>NSLocationStrategy.prototype).pop = function() {
            // YOUR CODE TO POP
        };

(<any>this._router.locationStrategy).pop();

For our app we depended on back navigation to a specific page in history without editing any of the core classes. It took a while to figure out the exact choreography of all events that are triggered, but this is the solution we came up with:
public navigateBackTo(depth: number): void {
  let largeBackStack: boolean = false;
  const arrayLength: number = this.routerExtensions.frame.backStack.length;
  this.routerExtensions.frame.backStack.map((backstackEntry: BackstackEntry, index: number) => {
    if (index > depth && backstackEntry.resolvedPage) {
      const page: any = backstackEntry.resolvedPage;
      setTimeout(() => {
        if (page.isLoaded) {
          page.onUnloaded();
        }
        if (index + 1 === arrayLength && !largeBackStack) {
          page.onNavigatedFrom(true);
        } else {
          largeBackStack = true;
          page.onNavigatedFrom(false);
        }
      }, index - depth * 100);
    } else if (index === depth) {
      this.routerExtensions.frame.goBack(backstackEntry);
    }
  });
}

We are still updating the code to move the check for largeBackStack outside the lambda method, but in the meantime this is a solution that works like a charm for us.
Hope this works for you guys as well

@FBorgonjen thanks for your code sharing.
Meanwhile I just solved my problem by re-order my navigation structure and using <router-outlet> with routerExtensions.backToPreviousPage() or just routerExtensions.back().
The Navigation is now more straight forward and consistens for the users. But I saved  your code, for one day when i really need to go back more the one page. So thanks!

@ThunderAnimal it's more straightforward but haven't you lose animation when routing and the ability to swipe back?

Is there any estimation on when this feature will be implemented? Our solution as proposed above is breaking when navigating back more than 3 pages.

I'm also waiting on this feature to be implemented. I'm currently using one of the hacks described above, but I would love to throw away the difficult-looking code and replace it with a simple goBackTo or something like it.

@AliKalkadelen, as said on September 3rd the proposed method is not always working when navigating back more than 3 pages. But if that is not your case, it works :) Good luck implementing!
@tsonevn, is there any news on this issue. Will it be fixed? I am actually quite surprised that Nativescript has reached version 5.0 (and NS-Angular 6+) and there are still basic navigation flows missing in the code. Especially since this feature is requested on March 21, 2017 20:39

Hi @FBorgonjen,
This feature request is still under review. I can not commit to the exact time when this functionality will be available.  I would suggest keeping track on the issue for more info.

Hi @tsonevn,
Thank you for your reply. I've created a NativeScript Playground example showing the same problem with this back navigation issue for iOS. For me this is a perfect example of a basic navigation flow which I would have expected to be in Nativescript-Angular
https://play.nativescript.org/?template=play-ng&id=1b2EFM&v=3
Usecase:

Navigating 2 levels or deeper into a tab
Tap on the active tab item (you will be navigated back to the root of the tab)
Result: the router state will not be updated correctly and you will not be able to navigate to the child pages again.

@tsonevn I'm currently working on an app that has many pages. But this bug hinders me in the development of the app. So I'm hoping you can give me some a time when this will be implemented. You have mentioned multiple times that the feature request is under review, but now it is already 3/4 year ago since your last mention on this. (And 2 years ago since the first time someone requested this  feature.)
I'll think with implementing this feature will serve the community. The first request is already from 2017, https://github.com/NativeScript/NativeScript/issues/3848. And there are more people wanting this feature see for example https://github.com/NativeScript/nativescript-angular/issues/1167.
Thank you for your effort in the project!

Any update or workaround on this feature?


Type generation from dashboard or CLI results in error

Bug report
Describe the bug
When I try to generate types from the supabase dashboard I get this inexplicable error. Unfortunately, since my instance of supabse is self hosted with docker, I can't use the cli to generate types instead.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Create an instance of supabase using the self hosting instructions
Add some dummy data/tables
Click on "API Docs"
Click on "introduction"
Click "Generate & Download Types"
Get an error wall

Expected behavior
I expected to have types generated from my tables.
Screenshots

System information

OS: MacOS
Browser (if applies) Brave
Version of supabase-js: 2.8.0
Version of Node.js: 19.4.0

Additional context
N/A

Hey @Gravy59, you can use supabase gen types typescript --db-url to generate types from your self-hosted database.

I'm unable to do that because I get a connection refused error.
supabase gen types typescript --db-url "postgresql://postgres:your-super-secret-and-long-postgres-password@localhost:5432/postgres" gives me an ECONNREFUSED. I haven't modified any base settings in supabase, and I've tried using postgresql:// and postgres://.

Hmm, could be because the typegen itself is running from a container, so localhost doesn't resolve to the host. Can you try replacing localhost with host.docker.internal? (I'm assuming you use Docker Desktop.)

That solved the issue for me. Thanks!


Implement interp-net training part code

Let's training internet on our dataset which from https://github.com/SkywardAI/paper_gallery/issues/7.
I'd like to share more tips for this:

We respect the original code, but the code is inefficient is the truth. So, we can't run it directly, it's waste our time and also the computing resources like GPU.
Based on the first one, that's why we did a slice of our dataset.
And although we must to twisted their code and we should know all the parameters means. Otherwise we will can't repeat the result.

The next step
Please run the code on Kaggle notebook with GPU.
https://github.com/mlds-lab/interp-net/blob/af2dbb8a23ba3584706c079432cc00568c68fd99/src/multivariate_example.py#L114-L207
Note:
And it looks like that it only support single GPU, see https://github.com/mlds-lab/interp-net/blob/af2dbb8a23ba3584706c079432cc00568c68fd99/src/multivariate_example.py#L148
We argue 5 years ago code quality of research is 0 sense. So, we should run it by only using a slice with 10 records.

I will build a dataset for mimic_iii all-in-one on Kaggle. It would be easier for us to do the next step.

@Micost @wangyuweikiwi We already implemented all the process by ourself, here is a minimal demo with fake data https://www.kaggle.com/code/aisuko/dl-of-interpolation-nn-for-icu-prediction


add package.xml for poco_vendor

As we have control over this repository I figured it would be better to have the package.xml leaving alongthe code rather than a patch on the release repository.
@nuclearsandwich I removed 2 dependencies that didn't appread to be necessary on my bionic machine
https://github.com/ros2-gbp/poco_vendor-release/blob/7c74e1bfa5d5596fa957817c06cca3ee3b19862c/xenial/package.xml#L14-L15
I tested it by ensuring that these 2 packages were not present and building up to the "composition" package and ran the test of "composition" successfully (couldnt test it on CI as these deps are brought in transitively by other packages like opencv or python3-dev).

Linux
Linux-aarch64
macOS
Windows

format 3?

Oh do we have a preference for format 3 ?
I usually use format 3 only when I need format 3 features, but am totally fine changing it to format 3 if it's preferred

Dunno, I always use format 3 in ROS 2. No reason, just using the latest and greatest.

Dunno, I always use format 3 in ROS 2. No reason, just using the latest and greatest.

Fine by me https://github.com/ros2/poco_vendor/pull/15/commits/49e4ab01cf503e4c91210725fdd102f1cff47c83


Windows 10 and resolving paths

Hi,
I was trying to run simple build task on Windows 10. Unfortunately there is error with executing command. Are you aware of this issue. I suppose this is error related to Windows 10 this same code executed on Win8 runs without any errors.
[I] 2016-02-02 18:17:37 [ServerName/username]: (Build-MsBuild.ps1/Build-MsBuild/120) Building package 'ProjectName'. [I] 2016-02-02 18:17:37 [ServerName/username]: (Invoke-ExternalCommand.ps1/Invoke-ExternalCommand/134) Running external command: "C:\Program Files (x86)\MSBuild\14.0\bin\amd64\msbuild.exe" "C:\Users\username\Projects\ProjectName\ProjectName.sln" /p:Configuration="Release" /p:DeployOnBuild="True" /p:DeployTarget="Package" /p:AutoParameterizationWebConfigConnectionStrings="false" /p:PackageLocation="C:\Users\username\Projects\ProjectName\bin\ProjectName\ProjectName.zip" /nologo /maxcpucount /nodeReuse:false '""C:\Program' is not recognized as an internal or external command, operable program or batch file. [E] 2016-02-02 18:17:37 [ServerName/username]: (Invoke-ExternalCommand.ps1//239) External command failed with exit code '1'.

Fixed in build #549.


Horizontal scrollable widget

Hi
is it possible to provide a Text-box widget with a horizontal scrollbar?
Thanks

I am interested in contributing to this feature if you are open to it.

I am interested in contributing to this feature if you are open to it.


notsodeep on OpenWrt, not working

Hi, I am trying to get notsodeep working on OpenWrt. My goal is to apply DPI circumvention network wide, and because of that I intend to run notsodeep in my router. I have successfully compiled the source code, and the executable appears to be running.
root@mywrt:/# ps | grep notsodeep
 3265 root      1132 S    ./notsodeep

root@mywrt:/# cat /proc/net/netfilter/nfnetlink_queue
  200   3265     0 2 65531     0     0      169  1

However, it seems that it isn't working; blocked websites are still not opening. I have entered the iptables rules that you have specified, but it appears to do nothing.  Do I need a different rule? Is it possible that the code is simply incompatible with my router's CPU (mips_24kc)? For what it's worth, I compiled notsodeep using the -D_GNU_SOURCE flag. I am attaching the compiled binary, just in case you need it.
notsodeep-openwrt-mips24kc.zip
Thank you for your attention.

can you share how did you compile it?
I cant compile it for openwrt with the guide provided by openwrt.
I get this error
notsodeep.c:8:10: fatal error: libnetfilter_queue/libnetfilter_queue.h: No such file or directory
#include <libnetfilter_queue/libnetfilter_queue.h>

how did you run it on openwrt?
I compiled it but when I run it it just exits.


[Bug-Fix 5692] Fix schedule time for completion.

Fix https://github.com/apache/dolphinscheduler/issues/5692

hi, thanks for your contribution, can you resolve the CI error?

Codecov Report

Merging #5695 (d164d6e) into dev (b31ba7e) will increase coverage by 0.01%.
The diff coverage is 88.23%.

@@             Coverage Diff              @@
##                dev    #5695      +/-   ##
============================================
+ Coverage     45.36%   45.37%   +0.01%
  Complexity     3688     3688
============================================
  Files           607      607
  Lines         24855    24868      +13
  Branches       2825     2828       +3
============================================
+ Hits          11275    11284       +9
  Misses        12498    12498
- Partials       1082     1086       +4

Impacted Files
Coverage Δ

...ache/dolphinscheduler/server/utils/ParamUtils.java
91.07% <88.23%> (-2.27%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.35% <0.00%> (-1.70%)
:arrow_down:

...olphinscheduler/plugin/alert/email/MailSender.java
72.91% <0.00%> (-1.39%)
:arrow_down:

...inscheduler/spi/plugin/DolphinPluginDiscovery.java
0.00% <0.00%> (ø)

...inscheduler/api/service/impl/UsersServiceImpl.java
74.66% <0.00%> (+0.05%)
:arrow_up:

...er/master/processor/queue/TaskResponseService.java
68.05% <0.00%> (+4.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31ba7e...d164d6e. Read the comment docs.

Hi @wordhardqi Please check the latest code again. This pr will be closed because no update for a long time, you can reopen it if need.


Support for higher order functions and lambdas

This would be very useful to open up a more flexibility with numba.
I understand a major issue is inferring the type of a function passed as an argument.  A solution suggested by @sklam what to explicitly type the function.
However, as shown here: https://github.com/JuliaLang/julia/pull/13412, it doesn't seem to be necessary for the user to manually type functions in order to generate very fast code.
I wonder if Numba can get some ideas from that PR that would facilitate higher order programming.
Here are some potential usecases:
https://groups.google.com/a/continuum.io/forum/#!topic/numba-users/YE12tE2dIwY
https://github.com/QuantEcon/QuantEcon.py/issues/216
@albop @jstac and @oyamad might be interested in this.
@pzwang a numbatoolz facilitated by resolving this issue could  help with this mailing mailing list topic that you participated in: https://groups.google.com/a/continuum.io/forum/#!searchin/blaze-dev/toolz/blaze-dev/4yElecF1URw/2tnKiX0aBgAJ

@datnamer, I have questions about the Julia PR and I don't have much experience with it.  Do you know if the example still works (with the same performance) if the functor to map is passed as an argument to foo in the first example, instead of declaring locally as an anonymous function?

In general, Julia has a very different type inference algorithm.  I am starting to study it.  I will see if I can learn something from it.

I'm not sure, but I think so. Its fast enough with non lambda functions that they will be replacing magical vectorization by simply mapping functions over arrays: https://github.com/JuliaLang/julia/issues/8450
It's also being used for fast generator comprehensions.

Has this issue been resolved by #2801?
Also shouldn't the answer to the question "Can I pass a function as an argument to a jitted function?" be "Yes you can" now?
@jit(nopython=True)
def f(g, x):
    return g(x) + g(-x)

@jit(nopython=True)
def my_g_function(x):
    return x

result = f(my_g_function, 1)

Yes, numba can handle function as an argument now.  We need to update the FAQ.  Closing.

Actually, #2801 only handled passing top-level function as argument.  Inner-function/closures/inline-labmdas have minimal support (see https://numba.pydata.org/numba-doc/dev/reference/pysupported.html#inner-function-and-closure).  Please open new issues regarding them for specific use-cases.


feat: include tokenId in revoke errors

We have seen some errors revoking tokens
lease revocation failed: lease_id=artifactory/token/jenkins/2y6wgde6HysH32XXt7h0Nccd.RmD7j error="failed to revoke entry: resp: (*logical.Response)(nil) err: could not revoke token: HTTP response 204"

... and would like to see the tokenId in the response.
This would tell us whether the tokens are actually being revoked or not, and would also give us a way to take action based on the error (manually revoke by ID)
See also: Support Case #238590
I am requesting clarification (since we can't actually see artifactory code) as to what "204" means in this case. I am leaning towards 204 being a "tokenId does not exist" 404? We may want to handle a "204" as a success.

@TJM I actually ran into this very same issue couple of weeks ago, troubleshooting another issue. The 204 here is actually HTTP status and the code currently is too specific in error checking. It should check for >= 400 instead.
See https://github.com/jfrog/artifactory-secrets-plugin/blob/master/artifactory.go#L63
(I suspect the API response status code changed from 200 to 204, for the better)


fix device selection logic

return null if no device found but backend found

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.

Project coverage is 46.65%. Comparing base (a733d25) to head (86bfeaa).
Report is 5 commits behind head on master.

Files with missing lines
Patch %
Lines

clic/src/openclbackend.cpp
11.76%
12 Missing and 3 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   46.65%   46.65%
=======================================
  Files         199      199
  Lines        3972     3972
  Branches     1815     1813    -2
=======================================
  Hits         1853     1853
+ Misses        714      713    -1
- Partials     1405     1406    +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


no such package 'util/hash': BUILD file not found

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No.
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): FreeBSD 12.0-ALPHA3
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 1.11.0
Python version: 2.7.15
Bazel version (if compiling from source): 0.17.1
GCC/Compiler version (if compiling from source): clang version 6.0.1
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce: bazel fetch --repository_cache=/path/to/empty/bazel_cache //tensorflow:libtensorflow.so

Describe the problem
I'm doing the port for tensorflow and trying to fetch everything that's required for build first. After extracting tensorflow tarball I run bazel fetch --repository_cache=/path/to/empty/bazel_cache //tensorflow:libtensorflow.so and get the following error:
ERROR: /wrkdirs/usr/ports/science/tensorflow-core/work/tensorflow-1.11.0/tensorflow/core/common_runtime/eager/BUILD:215:1: no such package 'util/hash': BUILD file not found on package path and referenced by '//tensorflow/core/common_runtime/eager:attr_builder'
ERROR: Evaluation of query "deps(//tensorflow:libtensorflow.so)" failed: errors were encountered while computing transitive closure

@arrowd Looks like some files are missing, try to install TensorFlow from the binary.

I doubt there are binaries for FreeBSD. This is why I'm doing the port, after all. Can you point me to FreeBSD binaries?

I already have the latest bazel. The problem is not with bazel, but TensorFlow.

TensorFlow works on a score of platforms as shown in this link. You can also try to install TensorFlow on FreeBSD following this.

I don't quite get what you are saying. I'm simply trying to compile latest TensorFlow release with latest Bazel release and https://www.tensorflow.org/install/source is exactly steps I'm following. Is this supported?
The manual you provided uses ancient Bazel to build old version of TF. I don't need it, I want to create a package of recent TF for FreeBSD users.

Ping? Maybe I'm just doing something wrong? Is
bazel fetch --repository_cache=/path/to/empty/bazel_cache //tensorflow:libtensorflow.so

command supposed to work at all?

I'd like to add a confirmation that I have this issue, too. In NixOS we try to use bazel by fetching, patching, then building. I am using a built-from-source version of AMD's ROCm patches to tensorflow, but had to ultimately create a new bazel wrapper to apply the needed patches during the build since the fetch command fails with this problem.

@arrowd The instructions can be adapted to the newer TensorFlow version but it won't be trivial.
In the meantime, you may need to check whether all protobuf patches are applied from ports before fetching and building, after which you can build again. bazel fetch does work on most Linux systems.
@acowley glad you found a solution. Applying all needed patches is essential to get around this problem. Installing TensorFlow from source is usually challenging which is why we recommend binary.

In the meantime, you may need to check whether all protobuf patches are applied from ports before fetching and building

Can you please elaborate on this? What protobuf patches?

Was just hit with this as well.
@acowley I'm using Nix to build TF as well, how did you end up working around this? Did you override buildBazelPackage?

FWIW versions 1.11, 1.10.1, and 1.10.0 are affected. Version 1.9.0 isn't, it seems.

@TravisWhitaker Yes, exactly, I used a custom buildBazelPackage. I abandoned bazel fetch due to this Issue, and baked the patches to the hard coded /usr/bin/ar paths used by bazel into src/main/tools/process-wrapper-legacy.cc (part of the bazel source) itself. This is horribly gross, but I also needed to patch dozens of other paths in tensorflow, so I could stomach it as a temporary fix.
rocm-bazel = (pkgs.bazel.override {enableNixHacks = true;}).overrideAttrs (old: {
    # Packages that bazel fetches often include hard-coded paths to
    # /usr/bin/ar. We in turn hard code a fix for that here. If
    # bazel's fetch command works for your build, then this is not
    # needed as these paths can be patched after download but before
    # build. If fetching does not work, and you need to rely upon
    # downloads during the build phase, this can help.
    postPatch = old.postPatch + ''
      find -type f -name CROSSTOOL\* -exec sed -i -e 's,/usr/bin/ar,${pkgs.binutils.bintools}/bin/ar,g' {} \;
      sed -e 's|if (execvp(opt.args\[0\]|if (execvp(strcmp(opt.args[0], "/usr/bin/ar") == 0 ? "${pkgs.binutils.bintools}/bin/ar" : opt.args[0]|' \
          -e 's|\(#include <vector>\)|\1\n#include <cstring>|' \
          -i src/main/tools/process-wrapper-legacy.cc
    '';
  });

@acowley Ah nice, I'll give that a go. Thanks!

Thanks for sharing your fix for NixOS @acowley.
The patches that may be helpful for FreeBSD case can be found in https://svnweb.freebsd.org/ports/head/devel/protobuf/files/, locate the correct files that match with the FreeBSD version installed.

Nagging Assignee @wt-huang: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Closing this out since I understand it to be resolved, but please let me know if I'm mistaken. If the issue is persists again, please open a new ticket. Thanks!


Sampling strategy (new sampler)

Hi @tomaarsen. This is still WIP but thought I'd share with you at this stage..
We now have sampling_strategy that accepts oversampling (default) undersampling and I've left the "unique_pairs" unbalanced option in there for now as unique (the code for this is very similar so left for now but can easily be removed later if desired).
We've discussed backwards compatibility... I've left num_iterations as an optional, for now this can be dropped to 0 to give the new default "oversampling" num pairs.
It's worth noting the sampling is not exactly the same as before.. For example:
Previous: ["Sent A L0", "Sent B L1", Sent C L1"] positive samples @num_iterations=2 could result in:

{"Sent A L0"-"Sent A L0"} , {"Sent B L1"-"Sent C L1"} , {"Sent C L1"-"Sent B L1"}
{"Sent A L0"-"Sent A L0"} , {"Sent B L1"-"Sent C L1"} , {"Sent C L1"-"Sent B L1"}

While now might result in:

{"Sent A L0"-"Sent A L0"} , {"Sent B L1"-"Sent B L1"} , {"Sent C L1"-"Sent C L1"}
{"Sent A L0"-"Sent A L0"} , {"Sent B L1"-"Sent C L1"} , {"Sent B L1"-"Sent B L1"}

The randomness of the second sentence section instead will randomly draw new perturbations first. The net effect over lots of num_iterations is slightly less random drawing of samples, it shouldn't impact scores but is not truly backwards compatible with the old sampler this way. There's no nice way to do this, unless you bring back in all the old sampling functions which I'd rather not. I can produce some tests to show the accuracy are very much aligned with <v1.0? But exact sampling will differ slighter...

@danstan5
Hello!
Apologies for the delay, I've been busy. This is looking quite slick, definitely looking forward to merging this. I have a few questions:

How does unique differ from undersampling right now? I think zip continues until the shortest argument is exhausted, so even if the positive and negative pairs are identical, then I think this line means that the number of positive and negative pairs are still equally sampled:
https://github.com/tomaarsen/setfit/blob/567f1c928aaeb3a534361d878e503027573e7539/src/setfit/sampler.py#L139

Can we get roughly <v1.0.0 performance if we add:

        if sampling_strategy == "random":
            self.len_pos_pairs = len(self.sentences)
            self.len_neg_pairs = len(self.sentences)

Then this still needs a few tests and presumably trainer_unique_pairs.py has to be removed.
And I'll add sampling_strategy to the TrainingArguments, and I'll consider fully removing num_iterations if we can add the "random" strategy.

Tom Aarsen

Hey @tomaarsen. In answer to your Qs:

Your right ! 🐞 The logic is broken here should be zip_longest so the unique case works correctly

[ ] I will add tests for this to confirm logic works as expected after adding the fix.

Roughly <v1.0.0 performance is reproducible by setting num_iterations (which will now default to None). This draws the same no. & ratio of pairs as previous:
https://github.com/tomaarsen/setfit/blob/567f1c928aaeb3a534361d878e503027573e7539/src/setfit/sampler.py#L86-L88
The underlying sampler here has changed (it's slightly less random now). There's no work around for this without keeping all the <v1.0.0 code for complete reproducibility. I suggest the following:

[ ] Run evaluation dataset comparison pre/post new sampler: to show the metrics are within the margin error that would occur before from the random sampling.

I'll get these tests/ comparisons added + TrainingArguments added (as need them in place to run the tests).


Very high CPU load with serialport input

I have a problem with Electron in combination with serialport. I need to talk to a device which emits frames of 519 bytes at an interval of 27ms and a baudrate of 115200. So nothing spectacular really.
When I run the test code directly in Node it runs fine and uses less than 2% cpu. If I then run the exact same code in Electron my CPU goes through the roof at 130%.
I've tested the code on OSX with iojs v1, v2 and more recently node v4.1.1. The behavior is exactly the same. Also it doesn't make a difference if I run the code in the Electron main or renderer process.
I've shared my test code here. Of course without the device you can't use the serialport test code without altering it a little.
I'm hoping someone can give me pointers on how to investigate further, maybe by profiling the main process? I would love to use Electron for the project but with this bug it's not an option.

We have some issues with low level modules like serialport since the way they post events is keep waking up our Node.js message loop, fixing this is impossible or extremely hard.
A popular way to work around this is to fork a Node process to use serialport and then post things back, in Electron child_process.fork should work perfectly in this case. Maybe this will work for you?

Thanks for the feedback. A process fork seems like a plausible workaround. Could you be a bit more specific about what is going on with these events? I'd love to understand the problem with serialport a bit more in-depth. How are these events in Electron handled differently from a regular Node environment and what kind of modules are affected?

Electron has its own message loop, so we get notified of Node's events by listening to Node's message loop's backend fd. However when some modules like serialport or pty.js add a few special events to Node's message loop, we will keep getting notified in Electron even when there is nothing happened. This problem is OS X only and I think it is a bug OS X's kqueue implementation.
If you are interested in this you can look at the atom/common/node_bindings_* to have an idea of the implementation of Node integration.

Thanks for this info. Do you think this is something that can be solved by the libraries by not using these special events? Then I would report this to serialport so they can consider it for a future update.
The fork works well. In a previous naive attempt I launched two node processes manually and had them talk over TCP. A fork is much more convenient and efficient.

No, those special events are required for their implementations, it is not possible for those libraries to remove that.

OK thanks a lot for your help!

I am getting this error when I try child_process.fork with serialport, and I get really lost about it.
"Uncaught Error: The system cannot find message text for message number 0x%1 in the message file for %2. \\?\C:\Users\user\Documents\electron-quick-start\node_modules\serialport\build\Release\node-v47-win32-x64\serialport.node", source: ATOM_SHELL_ASAR.js (159)
Im using Windows 7x64 and  0.36.7

@leyenda, were you able to get this to work? :D
I'm having similar trouble while in normal execution ("require"), without even forking, and on this exact same platform.
Thank you in advance!

Hello @ruipimentel, unfortunately I give up on forking, and that was the specific action giving this error message to me. I end up sending  the data to my other program over tcp. I am sorry for not being helpful.

I understand! (so much that I'm actually reconsidering the whole stuff, too!)
And I appreciate that you answered, anyway, so thank you!

for those of you who needs help on using serialport, i built a little tool here for serialport run inside electron https://github.com/weiway/node-serialport-worker

This should have been fixed with #5378.


Improved gherkin highlighter

@Golmote @LeaVerou What do you think?

All these translations looks quite ugly to me, but I guess this is the only way to handle the localisation of the language. And I like the idea of Prism being able to handle it.
I'm also not opposed to you taking the "ownership" of the language (<- is that proper English? :confused: ) since it appears you improved it a lot!
In any case, the final decision is up to @LeaVerou.

The owner of a language is the person expected to provide support, so given that @hason seems willing, that’s perfectly fine for me.
Thanks, merging!


chore: display grid items with fixed ar

Before this PR

The grid item would scretch to fill the available space
Only 14 items were displayed at a time

After this PR

grid items have a fixed 1:1 aspect ratio
20 items are displayed at a time

Video
before
grid-before.mov
after
grid-after.mov

Current dependencies on/for this PR:

next

PR #300   (this PR)

This comment was auto-generated by Graphite.


Split definition into different modules

issue #60
Add a new optional argument with_idents for graphql_schema_from_file!. The usage is as fallowing:
graphql_schema_from_file!(
    "tests/schemas/complex_schema.graphql",
    with_idents: [Character, Droid, Human]
);
pub struct Human { }
impl HumanFields for Human {
    /* implementation */
}
pub struct Droid { }
impl DroidFields for Droid {
    /* implementation */
}
// Character is a graphql interface, hence no need to implement it.

tests suits:

tests/compile_pass/with_idents.rs
tests/compile_fail/wrong_with_ident_value.rs
tests/split_mod_test.rs

p,s. Some test suits have already failed since I forked them, don't know if I should fix them.

Some test suits have already been wrong since I forked them. I don't know if I should modify them.

Sorry for taking so long to review this, but I think I'm going to close this PR and the related issue. I think it makes more sense to look into when Juniper has a good solution for it. This is also not a feature I can see myself using so while I'm the sole maintainer of crate I wouldn't feel good about taking on feature.
Hopefully you understand 😊 You're of course welcome to experiment with this in a fork and submit a new PR once you have something you're happy with.

@davidpdrsn I totally understand your maintenance concern.
What could we do to make you more comfortable with a change like this? I'm trying to think on a reasonable middle ground where we can get the features this crate offers today without putting a big burden on you.
Any Ideas on how to make the code generation more modular? In my case I have separate definitions for the various types but would just implement the Query in juniper directly (and consequently QueryTrail too.
I'm happy to assist with a PR, although I want to make sure this is something you would be ok with vs me maintaining a private fork with a feature that will never see the light of the day :)

Sorry for taking a while to answer.
I can’t really think of any good approaches at the moment tbh. I guess someone would have to experiment in a fork or a new crate. Keep in mind that this crate doesn’t do anything you cannot do by hand with straight juniper. So it is a about finding a structure that works well and then seeing how that can be incorporated.


Consider switch to lightweight jackson-jr for JsonObject implementation

Given Vert.x focus to being lean and mean a switch from jackson-databind to jackson-jr also from FasterXML might be worthwhile to consider.
Maybe in combination with #166 and #167

How would this work with something like: https://github.com/eclipse/vert.x/pull/1274

There is no module support in jackson-jr. It is explicitly a feature minus version of jackson-databind.
So while it can fit current JsonObject implementation, it doesn't fit this PR.
The registerModule addition would be quite valuable. You can handle advanced serialization cases with it, like serializing bi-directional relationships, recursion, etc.
So a switch now does not seem the best choice. If going for #166 Vert.x could have the lean Jr. implementation by default and a full Jackson plug-in alternative.
BTW, if honoring this PR that would also not be possible, as you'll have forever bound vert.x core to jackson-databind by exposing it on the API of core.

This would be trouble for things like Kotlin which require a module.  Jackson-jr support for Kotlin is possible, but was a fair amount of work when I last looked at starting it, involving a PR to jr and then the ability to plugin something to take over metadata management and creating objects.

Yes, I agree. The jr thing is not a good idea. It might be a separate json implementation, together with https://github.com/vert-x3/issues/issues/166#issuecomment-236839646

io.vertx.core.json.Json exposes the Jackson API:
  public static <T> T decodeValue(String str, Class<T> clazz) throws DecodeException {
    try {
      return mapper.readValue(str, clazz);
    }
    catch (Exception e) {
      throw new DecodeException("Failed to decode:" + e.getMessage());
    }
  }

the decode API calls are also supported by jackson-jr from the documentation the only thing I haven't saw yet was if we could register custom encoders that we need for JsonObject/JsonArray

I've looked at the API and this would be possible to implement keeping the existing API but it would require that JsonObject would implement a Map interface and JsonArray a List interface since jackson-jr does not have the concept of custom serializers.
Also it would introduce a small functional change by not allowing C style comments in JSON (which by the way are not supposed to be allowed but we do have enabled by default.
So if we would like to reduce the jar footprint and simplify the interop of JsonObject/JsonArray with say groovy/js this could be a interesting feature otherwise I'm not sure if it is worth the work without breaking what we already have.

in short it can be resumed as : "is it worth to break the API for 1mb" ?

yes that and maybe simplify the usage of JsonObject/JsonArray across languages

Since this would be a big breaking change (we would remove the jackson mapper (which is public at the moment) this feature will not be implemented. It could be revived for a 4.x cycle.


Required Libraires

Hello,
I have just downloaded the zip folder and attempted to " download the required libs" but was unsuccessful. Can you help me understand what you mean by download the required libs? I read thru the read.me but could not find any further information. Thanks!

Hello, I have just downloaded the zip folder and attempted to " download the required libs" but was unsuccessful. Can you help me understand what you mean by download the required libs? I read thru the read.me but could not find any further information. Thanks!

sure!
You should be able to install them with
pip install ast requests selenium climage cv2 multiprocessing argparse, (assumin you have pip installed already). If you run the program and get a dependency issue, just find the specific package not installed and run pip install DEPENDENCY_NAME to get it.
If you have any further issues with this, I will be able to help more via discord (my username is BLUND3R#0088), where I can screen share the process.

Further in this issue, I just merged a pull request which will allow you to install them easier.
pip install -r requirements.txt


Revert "Revert "update vm_service_client to 0.2.2+4""

Reverts flutter/flutter#6918. Looks like this wasn't the actual cause.
cc @yjbanov, @abarth

Is this PR still current?


[IMPROVEMENT] Improve communication between components (GRPC)

We need to improve the overall communication handling between components.
For the GRPC handling there are currently issues like:

one shot connections, we end up opening/closing a new connection for a single action (costly)
reuse connections and rely on the grpc multiplexer to bypass connection establishment (reduces latency)
better error handling and retry mechanisms

For longhorn-manager <-> engine is using binary invocations as part of the controller reconcile loop.

the binary invocations should be replaced with grpc communication
the monitoring should run Independent from the the controller reconcile loop

Basically one refactor at a time will get us there slowly :)
I layed the ground work for grpc connection reuse here:
https://github.com/longhorn/longhorn-engine/pull/644
This also has an example on replacing the task methods.
The goal should be to eventually turn all task methods into free functions where the consumer passes the client in.

See if need to have a LEP for this. Assigned to @c3y1huang.

Assigned back to @joshimoo who is working on this.


BFB 13/14 - must check for two-letter strings in comments? (e.g. [PW], [8B], [4])

Hello,
With the release of BFB 13 (and given the lack of a working live vote counter at the moment), I was trying to see what the vote counts were so far for this episode. These votes in this episode are done using a two-character code (or, for some, a one-character code) - like "[PW]", "[LY]", "[CK]", "[8B]", etc. but for some a one-character code like "[4]" or "[X]".
I tried to fiddle with the code for the votes collector on my own computer, but to no avail (mostly because I know very little about Js or code in general, haha). I know in index.js there's a string that someone can change on their own if they need to change up the alphabet they're using, but I'd have no idea how to get it to use two-character strings. Given that this might be how voting is done in the future (who knows), it might be beneficial to implement the ability to search for codes of a different length. Nonetheless, how would someone search for a non-monocharacter code if they wanted to?
Thanks!
-Paintspot Infez

That's a very interesting idea, I'll look into that. Though, I don't think that's how the voting's going to be done in the next episodes, because "voting" in BFB 13 won't affect BFB 14, and is probably done to see which characters to develop in the future.
I can suggest using an object instead of array in config.json, but that might decrease user-friendliness.


ModuleNotFoundError: No module named 'model.utils.cython_bbox'

when I run python main.py --dataset vmrdcompv1 --frame mgn --net res101 --cuda directly, I meet the following error:
Traceback (most recent call last):
File "main.py", line 24, in
from roi_data_layer.roidb import combined_roidb
File "/content/drive/MyDrive/VMRN-Pytorch/roi_data_layer/roidb.py", line 9, in
from datasets.factory import get_imdb
File "/content/drive/MyDrive/VMRN-Pytorch/datasets/factory.py", line 14, in
from datasets.pascal_voc import pascal_voc
File "/content/drive/MyDrive/VMRN-Pytorch/datasets/pascal_voc.py", line 23, in
from .imdb import imdb
File "/content/drive/MyDrive/VMRN-Pytorch/datasets/imdb.py", line 19, in
from model.utils.cython_bbox import bbox_overlaps
ModuleNotFoundError: No module named 'model.utils.cython_bbox'
In model.util file, I do not find the cython_bbox file, so how can I fix this problem?

Hello, I have a similar problem. Have you solved it?

I have a similar problem，too. Have you solved it?

I have a similar problem，too. Have you solved it?


add verbiage to reduce confusion for new azure function developers copying code from docs

PR to address confusion for new Azure Function Developers which copy & paste code from the Azure Docs to bootstrap their app. You can see this confusion in issue #100912.
This adds a simple NOTE below the code sample in an effort to make it more obvious that the confusing line of code is only relevant in the referenced sample and is not needed in a production app.
Offending line:
s.AddSingleton<IHttpResponderService, DefaultHttpResponderService>();

In my opinion the primary cause of the confusion is that the name of the sample class and interface (IHttpResponderService and DefaultHttpResponderService) are named similarly to what one expects from BCL / Framework / SDK code leading one to believe this is recommended configuration.
Adding to this confusion is that the other lines in the code snippet actually are recommended practice.
Link to published docs for convenience.

#sign-off

@ggailey777
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@ggailey777 @Court72
Friendly reminder. Not sure how long these normally take 😄 . Happy to make modifications and hope to do so while the information is still fresh in memory.

Friendly reminder @ggailey777 @Court72


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc we don't use Prow
/assign we don't use Prow
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/hack 96aac1c...128cf01:
  > 128cf01 Allows to see tag from build_release func (# 104)
  > e1db8b2 chore: further explain knative CRD-generation support (# 105)

Codecov Report

Merging #339 (76f783d) into main (006b25b) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   80.31%   80.57%   +0.26%
==========================================
  Files          20       20
  Lines         767      767
==========================================
+ Hits          616      618       +2
+ Misses        137      135       -2
  Partials       14       14

Impacted Files
Coverage Δ

pkg/vsphere/adapter.go
64.12% <0.00%> (+1.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 006b25b...76f783d. Read the comment docs.


consider new structure for spaghetti

May consider new structure for .py files and import in the repo...
- spaghetti
        | - network.py
        | - analysis.py
        | - connectivity.py -- connectivity stats
        | - network_voronoi.py -- network-constrained voronoi diagrams
        | - XX util.py -- break into seperate files (below)
        | - allocate.py -- snapping --> singular/multiple, pp2n, etc.
        | - shortest_path.py -- tree generation + dijkstra/(maybe A*)?
        | - plus.py -- "plus" functionality including geopandas stuff

related:  #76, #126 , #195, #373, #392
Also: Refactor:-spaghetti-v2.0

At over 3000 lines, network.py is getting a bit unwieldy and would benefit from putting more utility-type functionality in a separate file.
Some ideas:

_network.py
net_utils.py
build.py
builder.py
netbuilder.py

Now there are 3 functions for extraction/creation in network.py:

extract_components()
element_as_gdf()
regular_lattice()

Maybe move these into a separate file --> features.py


Prim's Algorithm in C

Feature :
Prim's Algorithm is a greedy algorithm that is used to find the minimum spanning tree from a graph.
This algorithm is present in C++, Java and Python but is missing in C.
Description of solution :

Will add Prim's algorithms with adequate comments and proper documentation for readers to get a clear understanding.
To be added in C language.

Alternatives Considered :

Online Resources and Tutorials
External Libraries or Frameworks

Additional context

@Kumar-laxmi I would like to work on this issue. Could you please assign it to me. Thank!

@Kumar-laxmi Please assign this issue to me. I would like to work on it.

@Kumar-laxmi  please assign this to me under SSOC'23. I'm ready to contribute in all 4 languages

Assigned!
@brandonszeto : C

hey ,is this issue availabe please assign me


Problem with @types and components nesting.

Hi.
Your repo is great. But I found two main problems:

First the @app/types have problem when using npm : npm i && npm build && npm start:
" Cannot create property 'fileName' on string 'Error: Failed to install @app/types.
at PromiseQueue.install [as process] (/home/wiciu/Code_Projects/Hyperapp/hyperapp-starter/node_modules/parcel-bundler/src/utils/installPackage.js:46:11)
at
at process._tickCallback (internal/process/next_tick.js:188:7)'"
and
"hyperapp-starter/src/main.tsx:2:31: Failed to install @app/types."
(although here yarn passes installing, building and app starting processes)

Other issue is about nesting components there is TypeScrpt 2605 error :

First the @app/types have problem when using npm : npm i && npm build && npm start:
" Cannot create property 'fileName' on string 'Error: Failed to install @app/types.
at PromiseQueue.install [as process] (/home/wiciu/Code_Projects/Hyperapp/hyperapp-starter/node_modules/parcel-bundler/src/utils/installPackage.js:46:11)
at
at process._tickCallback (internal/process/next_tick.js:188:7)'"
and
"hyperapp-starter/src/main.tsx:2:31: Failed to install @app/types."
(although here yarn passes installing, building and app starting processes)

This happens due a known issue with parcel-plugin-typescript. See this thread.
One workaround is install a @babel/preset-typescript instead.
I will do an update for it.

2. Other issue is about nesting components there is TypeScrpt 2605 error :

Because the project is using Typescript v2.9.2. In your VSCode chose "Select Typescript version" > "Use workspace version (v2.9.2)"

Check out v1.0.0


Request: Store Music Unlocks

This information would be useful for those looking to unlock music tracks, allowing for automatic filtering of locked and unlocked tracks on the wiki.
This would also be useful from a wiki-perspective to see what music tracks are commonly unlocked by players, and the least commonly unlocked music tracks.

We actually have the capability for this now, but there isn't really a compelling use case (afaik) on the wiki for this. We don't want to use this project to aggregate data on players since that isn't really what they are signing up for here. We actually already do gather music unlocks (indirectly) via crowdsourcing.
If there's a good use case for this on wiki, I would be interested in exploring it though.

Hey mate, I just came here to make essentially the exact same post minus the commonly unlocked tracks.
PLEASE ADD THIS.
I have only 40 songs to go, and I was going to go for the music cape today but then I realised I would have to filter through 675 songs manually.
If you already have the capability, please please add this. It would make life so much easier if it automatically highlighted the ones you've finished on the wiki.

Just to clarify, the plugin already has the capability to transmit this data (music unlocks are just stored in varps), but there is a decent chunk of work that would need to be done on the wiki side of things. Most likely what we would do is something similar to the leagues tasks, where we highlight ones you already have.

Yeh that's essentially exactly what I'm asking for.
Just like how when you click on a music track it highlights it green, ideally it'd highlight all of your completed tracks green automatically.
I think it'd definitely be beneficial as well as being probably one of the most useful functions it can offer.

Any update?

Nope. There are other things about the plugin that we are trying to change that have much higher priority right now.

This is implemented now at https://oldschool.runescape.wiki/w/Music


site: guideline (DO / DON'T) badge color rethink

We should discuss how to maintain the theming and still get our guideline block badges to look as they did previously

Proposing this alternative to iron our the support for badge styles across themes.

Pros:

Less limitation when stronger/subtler badges are appropriate in context.
Alleviates the discrepancy of 'stroke' appearance not being promoted (discouraged) in light theme docs.
Removes the possibility to use 'Stroke/Neutral' badge in the light theme, which isn't contrast compliant.

Cons:

Renaming 'stroke' appearance to 'subtle' problematic? "Subtle" is an appearance type we use in Forms.

Fixed.


Feature Request: Command pallet command to force the update

Often I am editing in a hurry, and often am done before the minimum timeout (1m) is complete.  It would be nice to have a button or something in the command pallet to simply force this update on the currently open file.
Also, and sort of related it would be nice to disable automatic update and just rely on the command pallet command.

There was not a way, but I have changed the way updates are written to the file, so this shouldn't be needed as, as soon as you save, it will update the file time in the frontmatter
Closing this one in favor of #47 to centralise the discussion


Fixed #27309 -- Added CallableBool.hash().

Add hash function to CallableBool to support membership test operations for sets.

Could you add a note to docs/releases/1.10.3.txt, similar to the note in 1.10.1: Allowed User.is_authenticated and User.is_anonymous properties...

buildbot, add to whitelist.


Rel v1.1.1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Try re-running when numpy v2.0.1 is available on conda.


Izumi_gate+vground

CC0 License Agreement

[X] I agree to the terms of the CC0 License.

Function should look better now 👍 I hope it's good like this

Oh yeah and I reverted the .md file


Ghost notifications from edits not actually saved

I've seen another ghost notification appear again. The notification seems legit, except:

The diff is from the last edit of the page, that was done months ago
The user name (in this case) is an IP address, that looking at contributions has no contributions
The edit summary is not present in the comment table. The edit has never existed!

Since the actor is an IP address, this time I've looked at the webserver access logs, and I've discovered an edit attempt for that IP address, that apparently hasn't been saved.
I have ConfirmEdit installed, and I suspect the IP address has posted a link that triggered the captcha, it blocked the edit, but DiscordNotifications received it anyway.
I have ConfirmEdit loaded before DiscordNotifications in LocalSettings, which apparently should fire before, unless they're using different hooks that trigger at different times...

Sorry for taking so long to respond to this – This should now be fixed in the latest commit. Can you check it out @prodigion?


text lineheight value did not have effect

Describe the bug
set text lineheight but did not have effect.
version about 20240706
os freebsd 14.1

How to reproduce
set text lineheight
Example code
No response
Relevant output
No response
Platform
Linux

Thank you for filing this. Apologies if I am incorrect, but it does look like it is having an effect; there is more vertical space around the line of text. You may want to set the s.Font.Size property instead if you are trying to increase the size of the text. I confirmed that both properties are working. You can also try changing the Type to something larger like TextHeadlineLarge or TextDisplayMedium, which will change both the font size and line height for you.

I set s.Font.Size=units.Dp(48), now it showing are OK.


WIP: move transaction_hash into an EventContext

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

Refactoring (no functional changes, no API changes)

What is the current behavior?

Resolves: #NA
What is the new behavior?

Does this introduce a breaking change?

Other information

Related to #510

Closing this in favor of #714


[SPARK-21170] [CORE] Utils.tryWithSafeFinallyAndFailureCallbacks throws IllegalArgumentException: Self-suppression not permitted

What changes were proposed in this pull request?
Not adding the exception to the suppressed if it is the same instance as originalThrowable.
How was this patch tested?
Added new tests to verify this, these tests fail without source code changes and passes with the change.

Can one of the admins verify this patch?

Looks OK but I guess we should guard against this corner case everywhere addSuppressed is called

Thanks @sowen for taking a look into this.
There are other two classes where addSuppressed  being used,
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/Task.scala#L116
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L673
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L676
But I don't see a case that the same instance being suppressed in both of the classes, Do you think still we need to add the check in those places?

@srowen I removed spaces around imports, please check now.

Test build #3808 has started for PR 18384 at commit 371933d.

Test build #3808 has finished for PR 18384 at commit 371933d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #3810 has started for PR 18384 at commit 371933d.

Test build #3810 has finished for PR 18384 at commit 371933d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #3811 has started for PR 18384 at commit 371933d.

Test build #3811 has finished for PR 18384 at commit 371933d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #3812 has started for PR 18384 at commit 15b77df.

Test build #3812 has finished for PR 18384 at commit 15b77df.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #3813 has started for PR 18384 at commit 15b77df.

Test build #3813 has finished for PR 18384 at commit 15b77df.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

@srowen, I am not able to reproduce this failure in my local env, seems this test is not related to the change and also passed in the previous run, can you trigger the test once? Thanks
org.apache.spark.scheduler.SparkListenerSuite.local metrics

Test build #3818 has started for PR 18384 at commit 15b77df.

Test build #3818 has finished for PR 18384 at commit 15b77df.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #3822 has started for PR 18384 at commit b733e93.

Test build #3822 has finished for PR 18384 at commit b733e93.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Test build #3823 has started for PR 18384 at commit b733e93.

Test build #3823 has finished for PR 18384 at commit b733e93.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

merged to master/2.2


Unable to create file on windows

Stash v0.10.1 on windows fails with the following error.

Message: touch() [function.touch]: Unable to create file C:\wamp\www\clickfortime.com\httpdocs/application//cache/1952a01898073d1e/561b9b4f2e42cbd7/a8b72798beb911ae/98c8c8907d45950a/b2eb734903575495/3b57a32e2841bda5/dc960c46c38bd16e/953d97cdeefdbc68/e9772a20f09b5d13/28a579892c11a4c8/cfcd208495d565ef/66e7dff9f98764da.php because Invalid argument

My best guess is because it is not using the correct path directory separator.

There is a use case where this problem is not resolved: Right now we have an exception on windows systems thrown when the path is too long. But I discovered the problem on a linux system: CentOS on a vm (virtualbox / vagrant on windows host with shared drive) The vagrant synced folders are tied to windows limitations.

@xgathos in my own experience, Vagrant synced folders have always been problematic: slow to use, prone to problems when dealing with symlinks, etc. I have always been much better off with storing the codebase within the VM itself and sharing it to the windows host via Samba (only downside: you need the VM to be on to access the files)


:recycle: Chore: Update default for tevm/bundler

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1208  👈
#1205 : 1 other dependent PR (#1206 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on  Graphite


Relax version constraints to work with Laravel 5

@theduke have you tested it with symfony 4 packages?

@seyfer everything seems to be working fine with Laravel 5.6 in my manual testing.
How extensive is the test suite?
Because the 7.1 and 7.2 tests will use the latest packages with the 4.x versions too.

@theduke you can see in https://github.com/Ph3nol/NotificationPusher/blob/master/.travis.yml
that it runs on 7.1 and 7.2 also. Shall work. :) will tag new version soon with this PR.

btw. realistically this library build pass only with this deps for Symfony - >=2.3,<=3.4


[Spike] Skip start page, redirect users to ID

Changes proposed in this pull request
Redirects users to the location returned by the OmniAuth request phase call to the identity service. Checks that this redirect is a valid identity service URL. Renders the existing start page if Faraday encounters an error when making the call.

Guidance to review

Link to Trello card
https://trello.com/c/dwGZgtlE/1385-redirect-users-from-govuk-directly-to-id

Checklist

[ ] Attach to Trello card
[x] Rebased main
[ ] Cleaned commit history
[x] Tested by running locally

 Redirect users from GOV.UK directly to ID

Closing, we're not doing this now


Improved sample for Use in README.md

Thanks for these interfaces, it's working well for me.
Your starting sample in the Use section of the README.md was not updating the tracking numbers for me, just repeating the same numbers 100 times.
This might be a Vive/Rift difference.  My test case here is a CV1 Rift.  Python 3.5.
I tweaked the code by adding the creation of the Compositor object, and then use waitGetPoses, as it seems required to update the head tracking positions.
Here is the sample with the two added lines. While running in my test case, it updates the tracking numbers.
Please feel free to use this or not as you prefer.
import sys
import time
import openvr

vr_system = openvr.init(openvr.VRApplication_Scene)
vr_compositor = openvr.IVRCompositor()

for i in range(100):
    poses = vr_system.getDeviceToAbsoluteTrackingPose(
        openvr.TrackingUniverseStanding,
        0,
        openvr.k_unMaxTrackedDeviceCount)
    pose = poses[openvr.k_unTrackedDeviceIndex_Hmd]
    vr_compositor.waitGetPoses(poses, openvr.k_unMaxTrackedDeviceCount, None, 0)
    print(pose.mDeviceToAbsoluteTracking)
    sys.stdout.flush()
    time.sleep(0.2)

openvr.shutdown

This is the first I've heard of anyone trying the Rift with pyopenvr. I'm pleased it's working for you.
Even with the HTC Vive, VRSystem.getDeviceToAbsoluteTrackingPose(...) spews nonsense for about 10 seconds before actually tracking the headset position. I think it's a bug in openvr and VRSystem.getDeviceToAbsoluteTrackingPose(...) is just broken.
Instead of IVRCompositor(), we should probably use VRCompositor(), which in recent versions of pyopenvr returns a singleton instance which maybe gets updated when the headset changes or something, just like in the C++ API.
I assume you are using pyopenvr instead of pyovr because you want to support both Rift and Vive?
I'll update the examples and Readme after I get a chance to test this. Thanks.

Yes, I want to use pyopenvr so that I get both Rift and Vive with one interface, and my app is not performance sensitive so I think using Python should be fine.
On the Rift, the VRSystem.getDeviceToAbsoluteTrackingPose() shows legitimate numbers from the start (probably calls into the Oculus SDK).  They just never change, which led me to look into the Oculus SDK. That suggests that it needed the waitGetPoses() in a loop to actively update the tracking.
IVRCompositor: Oops!  Yeah, using VRCompositor() is clearly the right choice.  I tested that change with Rift, and it works like expected.

Rather than mysteriously creating but subsequently not using VRCompositor(), I felt it would be simpler to just use waitGetPoses() for this example.
import sys
import time
import openvr

openvr.init(openvr.VRApplication_Scene)

poses_t = openvr.TrackedDevicePose_t * openvr.k_unMaxTrackedDeviceCount
poses = poses_t()

for i in range(100):
    openvr.VRCompositor().waitGetPoses(poses, len(poses), None, 0)
    hmd_pose = poses[openvr.k_unTrackedDeviceIndex_Hmd]
    print(hmd_pose.mDeviceToAbsoluteTracking)
    sys.stdout.flush()
    time.sleep(0.2)

openvr.shutdown()

I update README.md and src/samples/track_hmd.py this way.
Fixed in revision 858181f16454b32d2bc27350a8bb30ee188eb706


Sync eng/common directory with azure-sdk-tools for PR 3212

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/3212  See eng/common workflow

/check-enforcer override

I am overriding this single failing check because the error does not original from this eng/common update.


fix typo

(My first "contribution")

Good find, thanks!

Hi Dana - Thanks for all that you do! Looking really forward to joining
your movement. :)
Sincerely,
Gideon
On Sun, May 21, 2017 at 7:11 AM, Dana Lewis<EMAIL_ADDRESS>wrote:

Good find, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openaps/docs/pull/834#issuecomment-302913964, or mute
the thread
https://github.com/notifications/unsubscribe-auth/APYgo3vp4amX-ZlXWQnt5ydlo4H1zrl9ks5r77l3gaJpZM4NhfKG
.


Improve test coverage of AUTO expansion

Tests header port sorting in AUTO expansion
Refactors AUTO expand testing
Adds another AUTO kind expansion test

Handles two of the three issues found in https://github.com/chipsalliance/verible/pull/1774 (see comments there).

Codecov Report
Patch and project coverage have no change.

 Consider uploading reports for the commit db3e109 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1798   +/-   ##
=======================================
  Coverage   93.03%   93.03%
=======================================
  Files         353      353
  Lines       25710    25710
=======================================
  Hits        23920    23920
  Misses       1790     1790

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


3+DC add delete current execution in workflow deletion process

Two things need to be updated:

Cassandra is using TTL to delete current execution. Move this logic to delete workflow execution (Have new API)
Mysql deletes workflow and current execution in the DeleteWorkflowExecution. Split to two steps.

Completed in #1779 #1789


Material with alpha scissor does not cast a shadow

Godot version:
Godot 3 master commit c4dfef58d9cca9d9112f5f8d8db9dcc1bd9dfaae
OS/device including version:
Windows 10, but don't think it matters
Issue description:
I have a material for my grass, just a texture on a plane, that has an alpha scissor applied so I only render the blades of grass.
Without this turned on, my plane casts a nice rectangular shadow.
With this turned on, no shadow.
I'm expecting a shadow in the shape of the grass particles.
I think it is because its treating the material as a transparent material.
Steps to reproduce:
Create a plane, add a material with a texture and turn alpha scissor on.
(obviously, create something the shadow is cast on and create a light so there is a shadow)

Duplicate of https://github.com/godotengine/godot/issues/13350?

@zireael07 yup, that's my understanding of how it should work, but it may not be detecting it properly and ending up getting rendered in the transparency pass

@Zylann could be related but setting render_mode to depth_draw_alpha_prepass does not make a difference for me.

Made some progress on this, @reduz could use your input.
The main issue seems to be around this code:
#if defined(ALPHA_SCISSOR_USED)
	if (alpha<alpha_scissor) {
		discard;
	}
#endif

#ifdef USE_OPAQUE_PREPASS

	if (alpha<0.99) {
		discard;
	}
#endif

( https://github.com/godotengine/godot/blob/master/drivers/gles3/shaders/scene.glsl#L1676 )
The alpha scissor nicely discards the fragment at the correct scissor value,  but for the shadow to be rendered during the opaque prepass a hardcoded value of 0.99 is used.
In my example the grass' alpha is causing most of the fragments to be discarded.
As a workaround I'm applying the scissor directly in my fragment shader and avoiding the use of alpha:
	if (color.a < 0.3) {
		discard;
	}

I think the solution would be to do something like this:
#if defined(ALPHA_SCISSOR_USED)
	if (alpha<alpha_scissor) {
		discard;
	}
#else
#ifdef USE_OPAQUE_PREPASS

	if (alpha<0.99) {
		discard;
	}
#endif
#endif

Does the shader support nested ifdefs? or have an #elifdef ?

Does the shader support nested ifdefs? or have an #elifdef ?

Apparently, yes. I've seen something like this in scene.glsl for instance:
#ifdef SHADOW_MODE_PCF_13
    ...
#elif defined(SHADOW_MODE_PCF_5)
    ...
#else
    ...
#endif

I think this was fixed by ad8897984183d29b52128d8ad5db6ca7d2ff8278


Add a macro benchmark command

Description
This pull request adds a new command to the CLI. The command allows us to execute a macro benchmark independently. Just like what we already do for microbench, we will not have to only go through the exec command in order to start macro benchmarks.
Why do we need this
I came up with four main reasons why we need to implement this change. First of all, it offers more consistency in the codebase, we were already treating micro benchmark with a unique command, so why not macro benchmark. Secondly, it allows easy local debugging and increases reproducibility, there is no need to spin up the infrastructure and wait for it to be configured. Thirdly, it enables us to deal with results and errors in a better way, everything is executed and controlled within the Golang code, not third-party shell scripts. And finally, it brings us closer to a system with centralized configuration, we configure macro benchmark from our main config.yaml using Cobra.
Being a tenth skeptical at first about removing the responsibility of executing Sysbench to Ansible and passing it on to the Golang code, those four reasons are what drove me anyhow.
The new command
The new command usage is:
go run ./go/main.go  macrobench run --help
Usage:
  arewefastyet macrobench run [flags]

Flags:
      --db-database string                      Database to use.
      --db-host string                          Hostname of the database
      --db-password string                      Password to authenticate the database.
      --db-user string                          User used to connect to the database
  -h, --help                                    help for run
      --macrobench-git-ref string               Git SHA referring to the macro benchmark.
      --macrobench-skip-steps strings           Slice of sysbench steps to skip.
      --macrobench-source string                The source or origin of the macro benchmark trigger.
      --macrobench-sysbench-executable string   Path to the sysbench binary.
      --macrobench-type MacroBenchmarkType      Type of macro benchmark.
      --macrobench-working-directory string     Directory on which to execute sysbench.
      --macrobench-workload-path string         Path to the workload used by sysbench.

Configurability
As I mentioned, this command offers increased configurability of the macro benchmarks. Instead of declaring variables for both OLTP and TPCC inside Ansible inventories, we define a single set of variables that can apply to both OLTP and TPCC in a single place. This set of variables will be read by the Golang code and transformed into a list of arguments that we pass to Sysbench. Below is an extract of a configuration file containing macro benchmarks configuration.
#### MACRO BENCHMARKS CONFIGURATION

macrobench-sysbench-executable: /usr/local/bin/sysbench
macrobench-workload-path: oltp_read_only
macrobench-skip-steps:
macrobench-type: oltp
macrobench-source: local
macrobench-git-ref: head

## ALL
macrobench_all_mysql-db: main
macrobench_all_mysql-host: <IP_ADDRESS>
macrobench_all_mysql-port: 13306
macrobench_all_db-ps-mode: disable
macrobench_all_db-driver: mysql
macrobench_all_luajit-cmd: "off"
macrobench_all_threads: 1
macrobench_all_auto-inc: "off"
macrobench_all_tables: 50
macrobench_all_table_size: 10
macrobench_all_range_selects: 0
macrobench_all_rand-type: uniform

## PREPARE
macrobench_prepare_time: 30
macrobench_prepare_report-interval: 10

## WARM UP
macrobench_warmup_time: 10
macrobench_warmup_report-interval: 10

## RUN
macrobench_run_time: 10
macrobench_run_report_json: true
macrobench_run_verbosity: 0

Variables are prefixed with macrobench_ followed by the name of the sysbench step on which this variable applies. As we can see, the variables at the top of the file, those without a step prefix, are used to control the execution. They are not passed down to sysbench. Those can be configured through CLI flags, as well as a configuration file like that one.
The sysbench workload used by the macro benchmark is now configurable too through the macrobench-workload-path key. This takes the lua file that sysbench will use.
Sysbench
We use forks of sysbench and sysbench-tpcc, they have been modified to generate JSON reports:

https://github.com/planetscale/sysbench
https://github.com/planetscale/sysbench-tpcc

Testing
To test you'll need a sufficient configuration, with the following items:

Here showing a config.yaml file used to execute TPCC macro benchmarks.

equinix-token: <equinix token>
equinix-project-id: <equinix project id>
equinix-instance-type: m2.xlarge.x86

# database information is not mandatory, the command can ignore storing results
db-host: <your db hostname>
db-user: <your db user>
db-password: <your db password>
db-database: <your db name>

infra-path: ./infra/terraform/

ansible-inventory-files: macrobench_sharded_inventory.yml
ansible-playbook-files: macrobench.yml
ansible-root-directory: ./ansible/

#### MACRO BENCHMARKS CONFIGURATION

macrobench-sysbench-executable: /usr/local/bin/sysbench
macrobench-workload-path: /src/sysbench-tpcc/tpcc.lua
macrobench-skip-steps:
macrobench-type: tpcc
macrobench-source: local
macrobench-git-ref: head
macrobench-working-directory: /src/sysbench-tpcc

## ALL
macrobench_all_mysql-db: main
macrobench_all_mysql-host: <IP_ADDRESS>
macrobench_all_mysql-port: 13306
macrobench_all_db-ps-mode: disable
macrobench_all_db-driver: mysql
macrobench_all_luajit-cmd: "off"
macrobench_all_threads: 1
macrobench_all_tables: 1
macrobench_all_scale: 1
macrobench_all_rand-type: uniform
macrobench_all_use_fk: 0
macrobench_all_mysql-ignore-errors: all

## PREPARE
macrobench_prepare_time: 5
macrobench_prepare_report-interval: 10

## WARM UP
macrobench_warmup_time: 5
macrobench_warmup_report-interval: 10

## RUN
macrobench_run_time: 10
macrobench_run_report_json: "yes"
macrobench_run_verbosity: 0

New inventories are added, they will permanently replace old ones in future PRs. Both ./ansible/macrobench_sharded_inventory.yml and ./ansible/macrobench_unsharded_inventory.yml can be used. Here is a sample of the configuration needed to execute those files:
...
ansible-inventory-files: macrobench_sharded_inventory.yml
ansible-playbook-files: macrobench.yml
ansible-root-directory: ./ansible/
...

You can then execute the commands with two methods:
go build ./go/main.go

## Method 1: Execution from A to Z using Terraform and Ansible as interfaces
./main exec --config ./config/config.yaml

## Method 2: Local execution using the new command - Requires Sysbench to be installed
./main macrobench run --config ./config/config.yaml

Cleaning and future work
Some housecleaning will need to be done in the future, some of the files located in ./ansible/ are redundant.
Future work includes setting up a cleaner configuration file and variables for sysbench's params. YAML supports arrays, I think that's something we can look at to make files look cleaner.
Related issues
Resolves #115.

overall looks good.
few nits

add flag description where missing
export the functions which are used outside of the package, others you can make it internal.

Fixed those nits in 2a28dcd52b07d6ff8d342f2fa1acc435e671b294, 82c480402f53d1a0f92730c34d24f630ef3894fd and a2b3e5576fa57acbdb93921dc75d1ad23f4fb934.


Changed "search" to "search this site" on front page

a feature request to replace "search" with "search this site"
label  #43291

pinging @natalisucks for approval

@Gauravpadam I am new to open-source contributing, so why is this issue still not closed?

Thanks for the PR @Royal-Dragon! Please be patient while approvers review your PR, Refrain from pinging them unless the PR goes unnoticed for a couple of days. In such cases, You can reach out in Kubernetes Slack Channel

/retitle Changed "search" to "search this site" on front page

/lgtm

/approve


Clickable monitor name in status page

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature
🔖 Feature description
It would be great to add an optional "public URL" field, to allow users to open the app by simply clicking on the monitor name in the status page
✔ Solution
Add an optional field to make the monitor clickable
❓ Alternatives
Monitors remain unclickable
📝 Additional Context
Some monitors may be for internal use only or not offer a link at all

This has been implemented in #1741 to use the URL field for selected monitors

This will be in the next release

Ok, thank you

I saw that this feature was added quite a while back, and I am surprised no one said this till now,
The URL for the clickable link is the same URL that is used to monitor. For all of my services, I use a healthcheck endpoint as the URL, and this causes that healthcheck endpoint to be that clickable URL.
I thought it should be obvious to define a second public URL as a link to that service just for this feature.
Would love to see this implemented in future.


Input devices lost when doing vt switch (FreeBSD)

 Issue by johalun
Tuesday Jan 10, 2017 at 04:57 GMT
Originally opened as https://github.com/Cloudef/wlc/issues/223

Have anyone seen anything similar on Linux?
After resume (vt switch back) libinput_resume is called and /dev/input/event[0-4] is being re-opened as expected but each device is immediately closed again except for the last one which is neither kb or mouse so I lose input methods...
(sorry for the excessive udev output...)
log snippet from when switching back to vt9 where Sway is running.
01/09/17 20:52:04 - [main.c:43] [wlc] fd.c fd_open: Open path /dev/input/event4. Stored fd 4 to index 0
udev_device_get_udev(0x80d95d7a0(/dev/input/event3))
udev_device_get_syspath(0x80d849140) ukbd0
udev_device_get_syspath(0x80d95d980) /dev/input/event3
udev_device_get_devnode(0x80d95d980) /dev/input/event3
udev_device_get_udev(0x80d95d980(/dev/input/event3))
udev_device_get_syspath(0x80d849780) ukbd0
udev_device_get_syspath(0x80d95d7a0) /dev/input/event3
udev_device_get_syspath(0x80ba3b450) /dev/input/event4
udev_device_unref(0x80d95d7a0//dev/input/event3) 1
01/09/17 20:52:04 - [main.c:43] [wlc] fd.c wlc_fd_close 20
udev_device_unref(0x80ba3b450//dev/input/event4) 1
01/09/17 20:52:04 - udev_list_entry_get_name() /dev/kbdmux0
[main.c:43] udev_device_new_from_syspath(/dev/kbdmux0)
[wlc] fd.c handle_requestudev_device_get_syspath(0x80ba3b450) /dev/kbdmux0

udev_device_get_sysname(0x80ba3b450(/dev/kbdmux0)) kbdmux0
01/09/17 20:52:04 - udev_device_get_udev(0x80ba3b450(/dev/kbdmux0))
[main.c:43] udev_device_get_syspath(0x80d849680) kbdmux0
[wlc] fd.c handle_request: FD_CLOSEudev_device_get_sysname(0x80ba3b450(/dev/kbdmux0)) kbdmux0

udev_device_unref(0x80ba3b450//dev/kbdmux0) 1
01/09/17 20:52:04 - udev_list_entry_get_name() /dev/sysmouse
[main.c:43] udev_device_new_from_syspath(/dev/sysmouse)
[wlc] Close index 1, fd 6udev_device_get_syspath(0x80ba3b450) /dev/sysmouse

udev_device_get_sysname(0x80ba3b450(/dev/sysmouse)) sysmouse
udev_device_get_udev(0x80ba3b450(/dev/sysmouse))
udev_device_get_syspath(0x80d95a550) sysmouse
udev_device_get_sysname(0x80ba3b450(/dev/sysmouse)) sysmouse
udev_device_unref(0x80ba3b450//dev/sysmouse) 1
udev_list_entry_get_name() /dev/ukbd0
udev_device_new_from_syspath(/dev/ukbd0)
udev_device_get_syspath(0x80ba3b450) /dev/ukbd0
udev_device_get_sysname(0x80ba3b450(/dev/ukbd0)) ukbd0
udev_device_get_udev(0x80ba3b450(/dev/ukbd0))
udev_device_get_syspath(0x80d849780) ukbd0
udev_device_get_sysname(0x80ba3b450(/dev/ukbd0)) ukbd0
udev_device_unref(0x80ba3b450//dev/ukbd0) 1
udev_list_entry_get_name() /dev/ums0
udev_device_new_from_syspath(/dev/ums0)
udev_device_get_syspath(0x80ba3b450) /dev/ums0
udev_device_get_sysname(0x80ba3b450(/dev/ums0)) ums0
udev_device_get_udev(0x80ba3b450(/dev/ums0))
udev_device_get_syspath(0x80d849600) ums0
udev_device_get_sysname(0x80ba3b450(/dev/ums0)) ums0
udev_device_unref(0x80ba3b450//dev/ums0) 1
udev_enumerate_unref(0x80ba316f0) refcount=1
udev_unref(0x80ba39650) refcount=14
01/09/17 20:52:04 - [main.c:43] [wlc] fd.c wlc_fd_activate
01/09/17 20:52:04 - [main.c:43] [wlc] fd.c handle_request
01/09/17 20:52:04 - [main.c:43] [wlc] fd.c handle_request: TYPE_ACTIVATE
01/09/17 20:52:04 - [main.c:43] [wlc] Activate: Iterate fd 0, value 4
01/09/17 20:52:04 - [main.c:43] [wlc] Activate: FD_INPUT
01/09/17 20:52:04 - [main.c:43] [wlc] Activate: Iterate fd 1, value -1
01/09/17 20:52:04 - [main.c:43] [wlc] Activate: Iterate fd 2, value -1
01/09/17 20:52:04 - [main.c:43] [wlc] Activate: Iterate fd 3, value -1
01/09/17 20:52:04 - [main.c:43] [wlc] Activate: Iterate fd 4, value -1
01/09/17 20:52:04 - [main.c:43] [wlc] Activate: Iterate fd 5, value 10
01/09/17 20:52:04 - [main.c:43] [wlc] Activate: FD_DRM
01/09/17 20:52:04 - [main.c:43] [wlc] Set drm master

fd 1,2,3,4 should contain input devices (they do before vt switch).
As can be seen in the log, for some reason FD_CLOSE requests are coming in and closing the input devices....
Until doing vt switch Sway works fine with all input devices.

 Comment by johalun
Tuesday Jan 10, 2017 at 06:39 GMT

Cleaner log:
01/09/17 22:37:09 - [main.c:43] [wlc] SIGUSR2
01/09/17 22:37:09 - [main.c:43] [wlc] wlc_set_active 1
01/09/17 22:37:09 - [main.c:43] [wlc] udev.c activate_event: active 1
01/09/17 22:37:09 - [main.c:43] [wlc] libinput: resume
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c wlc_fd_open /dev/input/event0
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request: FD_OPEN
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c fd_open: Open path /dev/input/event0. Stored fd 4 to index 0
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c wlc_fd_open /dev/input/event1
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request: FD_OPEN
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c fd_open: Open path /dev/input/event1. Stored fd 6 to index 1
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c wlc_fd_close 20
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request: FD_CLOSE
01/09/17 22:37:09 - [main.c:43] [wlc] Close index 0, fd 4
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c wlc_fd_open /dev/input/event2
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request: FD_OPEN
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c fd_open: Open path /dev/input/event2. Stored fd 4 to index 0
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c wlc_fd_close 20
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request: FD_CLOSE
01/09/17 22:37:09 - [main.c:43] [wlc] Close index 1, fd 6
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c wlc_fd_open /dev/input/event3
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request: FD_OPEN
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c fd_open: Open path /dev/input/event3. Stored fd 6 to index 1
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c wlc_fd_close 20
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request: FD_CLOSE
01/09/17 22:37:09 - [main.c:43] [wlc] Close index 0, fd 4
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c wlc_fd_open /dev/input/event4
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request: FD_OPEN
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c fd_open: Open path /dev/input/event4. Stored fd 4 to index 0
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c wlc_fd_close 20
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request: FD_CLOSE
01/09/17 22:37:09 - 01/09/17 22:37:09 - [main.c:43] [main.c:43] [wlc] fd.c wlc_fd_activate[wlc] Close index 1, fd 6

01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request
01/09/17 22:37:09 - [main.c:43] [wlc] fd.c handle_request: TYPE_ACTIVATE
01/09/17 22:37:09 - [main.c:43] [wlc] Activate: Iterate fd 0, value 4
01/09/17 22:37:09 - [main.c:43] [wlc] Activate: FD_INPUT
01/09/17 22:37:09 - [main.c:43] [wlc] Activate: Iterate fd 1, value -1
01/09/17 22:37:09 - [main.c:43] [wlc] Activate: Iterate fd 2, value -1
01/09/17 22:37:09 - [main.c:43] [wlc] Activate: Iterate fd 3, value -1
01/09/17 22:37:09 - [main.c:43] [wlc] Activate: Iterate fd 4, value -1
01/09/17 22:37:09 - [main.c:43] [wlc] Activate: Iterate fd 5, value 10
01/09/17 22:37:09 - [main.c:43] [wlc] Activate: FD_DRM
01/09/17 22:37:09 - [main.c:43] [wlc] Set drm master

 Comment by Cloudef
Tuesday Jan 10, 2017 at 09:44 GMT

I've seen this in rare cases so there is probably race condition somewhere. Whole tty switching is flaky.

 Comment by johalun
Tuesday Jan 10, 2017 at 17:23 GMT

Some more debugging gave me this output:
[wlc] opening input device '/dev/input/event0' failed (Operation not permitted)
That would explain why they're closed again after opened.


I'm asking the community for help editing the code for the themes I've added

I added 4 themes from 4 developers, but I didn't know what to put in the Preferences and Theme Styles boxes, so I left them empty and put a - sign. This 4 theme addition was automatically marked as closed by the bot. However, software developer friends should support and add the necessary codes to these boxes. I am not a programmer or developer, I don't understand. Please help me with the codes to be written in these boxes. I will edit the title content.
Here are the header links I created to add 4 themes:
https://github.com/zen-browser/theme-store/issues/620
https://github.com/zen-browser/theme-store/issues/619
https://github.com/zen-browser/theme-store/issues/617
https://github.com/zen-browser/theme-store/issues/616
The github links of the themes respectively:
https://github.com/black7375/Firefox-UI-Fix
https://github.com/bmFtZQ/edge-frfox
https://github.com/muckSponge/MaterialFox
https://github.com/rafaelmardojai/firefox-gnome-theme/

Your issue is not posting it the right way, you need to compress their CSS and image into 1 single file to submit to Zen Store

The issue template you used is for submitting created themes, not for suggesting them.


Fix version to v1 in the install command of v1 Nextjs docs

Subject
Getting Started with Nextjs
Description
I wanted to use Chakra UI in a Next.js project with React 17 so I ended up here:
https://v1.chakra-ui.com/guides/getting-started/nextjs-guide
The install command mentioned is:
npm i @chakra-ui/react @emotion/react@^11 @emotion/styled@^11 framer-motion@^6

This install Chakra UI v2. I figured out after I started getting weird errors and noticed that I had Chakra v2 installed.
The command should be changed to use @chakra-ui/react@^1 so it installs v1.
I'd be happy to make the change but I can't find the source code of v1 docs.

Good to be worked on!


test: Automation script update to fix PromisesSpec failure

Description
This PR fixes the Promises spec failure to validate both possible values in Deploy Toast
Fixes PromisesSpec failure in CI runs
Type of change

Fix for failure case (non-breaking change which adds functionality)

How Has This Been Tested?
Release - CI
Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
No changes to code coverage between the base branch and the head branch

/ok-to-test sha=2e2a900

/ok-to-test sha=2e2a900


[SP-4838] Backport of BACKLOG-26907 - Race condition in Trans.addStep…

…PerformanceSnapShot (8.2 Suite)
Cherry-pick of #6115 into 8.2 branch.
@smmribeiro

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/Trans.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.checksum.CheckSumMeta

Branch Change: -1.3% :small_red_triangle_down:
Complexity Change: -1.4% :small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change: -8.7% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down: