READMEs Render Programming Language Names Incorrectly

See discussion here: https://github.com/TheRenegadeCoder/sample-programs/pull/2528

This bug is still here, rip: https://github.com/TheRenegadeCoder/sample-programs/tree/main/archive/t/ti-basic.

Not sure if this is an issue here or in subete. I'll look into it later.


Use deprecated-react-native-prop-types

Platforms affected
All
What does this PR do?
RN 0.68 has deprecated and will eventually remove ViewPropTypes (see post). This adds the deprecated-react-native-prop-types package and uses that instead.
What testing has been done on this change?
Local testing, to ensure the deprecation warning has been removed.

hey @i6mi6 , can we get this merged please? your lib isn't usable with the latest react native version, it fails builds.

+1 to this I'm completely blocked on this unfortunately

+1 to this I'm completely blocked on this unfortunately

I ended up "resolving" the issue by applying the following patch that you can use the patch-package for. The good thing is since it's a React native patch it will work for any library with this issue not just this one:
`
diff --git a/node_modules/react-native/index.js b/node_modules/react-native/index.js
index d59ba34..8023167 100644
--- a/node_modules/react-native/index.js
+++ b/node_modules/react-native/index.js
@@ -435,32 +435,16 @@ module.exports = {
},
// Deprecated Prop Types
get ColorPropType(): $FlowFixMe {

invariant(

 false,

 'ColorPropType has been removed from React Native. Migrate to ' +

   "ColorPropType exported from 'deprecated-react-native-prop-types'.",

);

return require("deprecated-react-native-prop-types").ColorPropType
},
get EdgeInsetsPropType(): $FlowFixMe {

invariant(

 false,

 'EdgeInsetsPropType has been removed from React Native. Migrate to ' +

   "EdgeInsetsPropType exported from 'deprecated-react-native-prop-types'.",

);

return require("deprecated-react-native-prop-types").EdgeInsetsPropType
},
get PointPropType(): $FlowFixMe {

invariant(

 false,

 'PointPropType has been removed from React Native. Migrate to ' +

   "PointPropType exported from 'deprecated-react-native-prop-types'.",

);

return require("deprecated-react-native-prop-types").PointPropType
},
get ViewPropTypes(): $FlowFixMe {

invariant(

 false,

 'ViewPropTypes has been removed from React Native. Migrate to ' +

   "ViewPropTypes exported from 'deprecated-react-native-prop-types'.",

);

return require("deprecated-react-native-prop-types").ViewPropTypes
},
};

`

+1 to this I'm completely blocked on this unfortunately

I ended up "resolving" the issue by applying the following patch that you can use the patch-package for. The good thing is since it's a React native patch it will work for any library with this issue not just this one:
diff --git a/node_modules/react-native/index.js b/node_modules/react-native/index.js
index d59ba34..8023167 100644
--- a/node_modules/react-native/index.js
+++ b/node_modules/react-native/index.js
@@ -435,32 +435,16 @@ module.exports = {
   },
   // Deprecated Prop Types
   get ColorPropType(): $FlowFixMe {
-    invariant(
-      false,
-      'ColorPropType has been removed from React Native. Migrate to ' +
-        "ColorPropType exported from 'deprecated-react-native-prop-types'.",
-    );
+    return require("deprecated-react-native-prop-types").ColorPropType
   },
   get EdgeInsetsPropType(): $FlowFixMe {
-    invariant(
-      false,
-      'EdgeInsetsPropType has been removed from React Native. Migrate to ' +
-        "EdgeInsetsPropType exported from 'deprecated-react-native-prop-types'.",
-    );
+    return require("deprecated-react-native-prop-types").EdgeInsetsPropType
   },
   get PointPropType(): $FlowFixMe {
-    invariant(
-      false,
-      'PointPropType has been removed from React Native. Migrate to ' +
-        "PointPropType exported from 'deprecated-react-native-prop-types'.",
-    );
+    return require("deprecated-react-native-prop-types").PointPropType
   },
   get ViewPropTypes(): $FlowFixMe {
-    invariant(
-      false,
-      'ViewPropTypes has been removed from React Native.

In react native version - 0.72.0 in index.js file we have same line of code you have provided above still its showing same error

In react native version - 0.72.0 in index.js file we have same line of code you have provided above still its showing same error

this line of code
diff --git a/node_modules/react-native/index.js b/node_modules/react-native/index.js
index d59ba34..8023167 100644
--- a/node_modules/react-native/index.js
+++ b/node_modules/react-native/index.js
@@ -435,32 +435,16 @@ module.exports = {
},
// Deprecated Prop Types
get ColorPropType(): $FlowFixMe {

invariant(

 false,

 'ColorPropType has been removed from React Native. Migrate to ' +

   "ColorPropType exported from 'deprecated-react-native-prop-types'.",

);

return require("deprecated-react-native-prop-types").ColorPropType
},
get EdgeInsetsPropType(): $FlowFixMe {

invariant(

 false,

 'EdgeInsetsPropType has been removed from React Native. Migrate to ' +

   "EdgeInsetsPropType exported from 'deprecated-react-native-prop-types'.",

);

return require("deprecated-react-native-prop-types").EdgeInsetsPropType
},
get PointPropType(): $FlowFixMe {

invariant(

 false,

 'PointPropType has been removed from React Native. Migrate to ' +

   "PointPropType exported from 'deprecated-react-native-prop-types'.",

);

return require("deprecated-react-native-prop-types").PointPropType
},
get ViewPropTypes(): $FlowFixMe {

invariant(

 false,

 'ViewPropTypes has been removed from React Native. Migrate to ' +

   "ViewPropTypes exported from 'deprecated-react-native-prop-types'.",

);

return require("deprecated-react-native-prop-types").ViewPropTypes
},
};


Checking which versions are installed

It would be helpful to include an example of how to check the version(s) that is/are installed, e.g.
Import-Module AzureRM
Get-Module -Name AzureRM

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 140cfec3-6b83-ceac-f220-94319dc78d67
Version Independent ID: a1f76299-1832-cd86-b4f5-f7635ed62492
Content: Install Azure PowerShell on Windows with PowerShellGet
Content Source: docs-conceptual/azurermps-6.3.0/install-azurerm-ps.md
Product: powershell
GitHub Login: @sptramer
Microsoft Alias: sttramer

What would be the reason for needing this information during the install process?

The Update-Module command doesn't require any specific version information, and is safe to run at pretty much any point. Your comment about being able to look up the installed versions is both important for loading specific versions or our uninstall instructions though, and will be added there.

Thanks.  Re: the Update-Module command - as you say, it doesn't require specific version information.  I was referring to me wanting to work out whether I need to run the command or not.  Maybe I am in the minority, but I prefer to know the version I have before I run an update.  I don't like running commands blind.

@sdwheeler Is it common for PowerShell users to want to check version information before running any module upgrades? This isn't a standard practice I've seen with any other package management system I've used.

@sptramer - Yes it is common. I had instructions in the setup article to check your version of PowerShellGet. Because there are version requirements to have the -AllowClobber parameter. It looks like you took it out. I must have missed that deletion in the review.

I originally took them out because Update-Module does not require -AllowClobber that I could see, and no Install-Module run did either. Are there particular environment configurations I need to be testing to make sure that issues like these are caught?

Install-Module will require -AllowClobber if there is another version of the module already installed. Here is the common scenario.

Install AzureRM vX.0 using the MSI or WebPI. You use this for sometime and don't really remember how you installed.
A new version is released.
You try to run Update-Module. That fails because there is not a version of AzureRM that was installed using PowerShellGet.
You run Install-Module to install the latest version from the Gallery. That fails telling you to use AllowClobber because an older version exists on the system.

If you are running the version of PowerShellGet that shipped in Windows 10, you don't have a version that supports AllowClobber. Get-Module shows you the versions you have installed on your system.
PS C:\Users\SWHEELER\Desktop> Get-Module PowerShellGet,PackageManagement -list | select Name,Version

Name              Version
----              -------
PackageManagement <IP_ADDRESS>
PackageManagement <IP_ADDRESS>
PowerShellGet     1.6.5
PowerShellGet     <IP_ADDRESS>

The <IP_ADDRESS> versions of these modules ship in Windows 10 and cannot be uninstalled. Since they were not installed using PowerShellGet you cannot use Update-Module to get the new version. You have to use Install-Module.

Now that we have uninstall instructions, it seems like this is much more easily handled by directing users to uninstall their old MSI/WebPI install (which is easy to see if the install was done this way) rather than encouraging use of a destructive feature like -AllowClobber. It also keeps the documentation shorter.

You will get support feedback asking about that error message. It needs to be in the troubleshooting section at least. Also, -AllowClobber is not "destructive". Each version is installed in its own version folder. The old version is not overwritten. Its just that the latest version has load preference when you Import the module.

OK, that actually wasn't clear from the documentation (-AllowClobber implies a destructive operation in its name, and the PowerShell docs don't say what's clobbered.) It sounds like a lot of pain can be resolved by adding this back in, along with the requirement for 1.6.5 PowerShellGet.


Improve tests to make sure a voucher is executed to complete a withdrawal

📚 Context
Test Withdraw request from WITHDRAW_ADDRESS results in a voucher does not test the full procedure, which could include the execution of the voucher itself.
✔ Solution
Add the following steps to the test:

Finish the epoch
Execute the voucher
Check Bob's balance to make sure the funds were transferred correctly

📈 Subtasks

[ ] Advance time
[ ] Execute the voucher
[ ] Check Bob's balance

🎯 Definition of Done

[ ] Test passes and Bob's balance matches what is expected
[ ] All tests pass

Tks you


[Request] Add page for read the article of wikipedia without leave the site

make it simple without leave the site, just add the page for reading the article on your site
if you need help check my profile @fiandev and let's be friend 🙂.

alright sir


Node version?

I just tried npm install with 10.6.2 and it bombs out. Which version of node are you using to build?

I'm using v8.9.4, but I've just tried with v10.6.0 and it seems to install just fine. Can you attach some logs or errors you get, as well as output node -v?

I'm closing the issue due to inactivity. Feel free to reopen if you'll get the same problems if the future.


Unpin pytorch-lightning<1.2

pytorch-lightning<1.2 was added in #549 to avoid the following errors.
Description of errors with pytorch-lighting>=1.2
On the current master, the following tests:
test_logistic_regression_model
test_cli_run_log_regression[--max_epochs 1 --max_steps 2]
test_cli_run_self_supervised_simclr[--data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --gpus 0 --fp32 --max_epochs 1 --max_steps 3 --fast_dev_run 1 --batch_size 2 --online_ft]
test_cli_run_self_supervised_byol[ --data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --max_epochs 1 --max_steps 3 --fast_dev_run 1 --batch_size 2 --num_workers 0 --online_ft]
test_cli_run_self_supervised_simsiam[ --dataset cifar10 --data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --max_epochs 1 --max_steps 3 --fast_dev_run 1 --batch_size 2 --num_workers 0 --online_ft --gpus 0 --fp32]

fail with the error:
ValueError: The `preds` should be probabilities, but values were detected outside of [0,1] range.

(Found while fixing ssl tests in https://github.com/PyTorchLightning/pytorch-lightning-bolts/pull/541/.)

Yeah, we shall get compatibility with PL 1.2

I got the same error, to solve it:
pip uninstall pytorch-lightning
pip install pytorch-lightning==1.1.8

@ananyahjha93 any update here?

@ananyahjha93 Could you look into it? Would like to try new Lightning features with models in Bolts.

Hi, still not working with main and nightly version. It works with 1.1.8

Any solution with v1.2.6?
Indeed it works on v1.1.8.
While some features I want lose in v1.1.8

Still not working for v1.3.1
I wanted to use CombinedLoader feature, but had to go back to v1.1.8.

Still not working for v1.3.1
I wanted to use CombinedLoader feature, but had to go back to v1.1.8.

acc_metric = torchmetrics.Accuracy()
...
acc_now = acc_metric(preds.argmax(dim=1), labels)

For now, this works well for me.

Still not working for v1.3.1
I wanted to use CombinedLoader feature, but had to go back to v1.1.8.

acc_metric = torchmetrics.Accuracy()
...
acc_now = acc_metric(preds.argmax(dim=1), labels)

For now, this works well for me.

Thanks! Now working on the latest version :D

Still not working for v1.3.1
I wanted to use CombinedLoader feature, but had to go back to v1.1.8.

acc_metric = torchmetrics.Accuracy()
...
acc_now = acc_metric(preds.argmax(dim=1), labels)

For now, this works well for me.

but this would not work for multilabel F1 score

Mind update to the latest TM, shall be fixed and all logits

Mind update to the latest TM, shall be fixed and all logits

almost. Version 0.4.1 still has the issue with:
ValueError: The highest label in preds should be smaller than num_classes.
although that issue seems to be fixed in master...

although that issue seems to be fixed in master...

new TM release is coming next week :]


How to improve cascade.xml, and distortion correction before CNN?

It is a amazing work.
But I find the library can't recognize plates when the plates is oblique in photos.
How to improve cascade.xml, and distortion correction before CNN?

you can train your own harr cascade model, or you can try mtcnn.


[SPARK-25720][WEBUI] Support auto refresh page for the WEBUI

What changes were proposed in this pull request?
Currently spark webui doesn't have an option of auto refresh page. Because of this, user has to reload
every time to see the updates in the page.
For SQL page and Streaming page, currently we are passing the refresh interval, but it is not implemented in the 'headerSparkPage' method. This PR, added the refresh functionality to the webui.

How was this patch tested?
Manually verified.
Every 5 seconds the SQL page is refreshing.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @srowen @cloud-fan . Kindly review.

Can one of the admins verify this patch?

Shouldn't it go in commonHeaderNodes?
Looks like this was added waaay back in https://github.com/JoshRosen/spark/commit/6aa08c39cf30fa5c4ed97f4fff16371b9030a2e6 by @tdas but never used. Only a few call sites set it. The problem I can see is that those hard-code it to 5 second refreshes.
I think we'd have to introduce a new parameter to control this, like spark.ui.refreshInterval or something, and then stop passing it into this method and just read it in this code somewhere?

Thank you @srowen for the comment. Yes, we should not hard-code the refresh interval and we let the user to enable the parameter. I will update the code accordingly.

can this be passed in as a param in the url?

BTW there is another approach: https://github.com/apache/spark/pull/21512

I am closing the PR, since already one PR is there for the webui auto refresh. Thanks.


ComfyRoll's Multi Controlnet Stack not working?

Checking weights
✅ controlnet-canny-sdxl-1.0.fp16.safetensors exists in ComfyUI/models/controlnet
✅ albedobaseXL_v13.safetensors exists in ComfyUI/models/checkpoints
✅ ZoeD_M12_N.pt exists in ComfyUI/custom_nodes/comfyui_controlnet_aux/ckpts/lllyasviel/Annotators
✅ depth-zoe-xl-v1.0-controlnet.safetensors exists in ComfyUI/models/controlnet
✅ artificialguybr/PS1Redmond-PS1Game-Playstation1Graphics.safetensors exists in ComfyUI/models/loras
====================================
Randomising seed to<PHONE_NUMBER>
Running workflow
[ComfyUI] got prompt
[ComfyUI] Failed to validate prompt for output 5:
[ComfyUI] * CR Multi-ControlNet Stack 68:
[ComfyUI] - Value not in list: controlnet_1: 'depth-zoe-xl-v1.0-controlnet.safetensors' not in ['None']
[ComfyUI] - Value not in list: controlnet_2: 'controlnet-canny-sdxl-1.0.fp16.safetensors' not in ['None']
[ComfyUI] Output will be ignored

These are supported weights and nodes, what am I doing wrong?
"68": {
    "inputs": {
      "switch_1": "On",
      "controlnet_1": "depth-zoe-xl-v1.0-controlnet.safetensors",
      "controlnet_strength_1": 1.0,
      "start_percent_1": 0,
      "end_percent_1": 1,
      "switch_2": "On",
      "controlnet_2": "controlnet-canny-sdxl-1.0.fp16.safetensors",
      "controlnet_strength_2": 1.0,
      "start_percent_2": 0,
      "end_percent_2": 1,
      "switch_3": "Off",
      "controlnet_3": "None",
      "controlnet_strength_3": 1,
      "start_percent_3": 0,
      "end_percent_3": 1,
      "image_1": [
        "49",
        0
      ],
      "image_2": [
        "69",
        0
      ]
    },
    "class_type": "CR Multi-ControlNet Stack",
    "_meta": {
      "title": "🕹 CR Multi-ControlNet Stack"
    }
  },

PS: Can't use Load ControlNet Model node with CR Multi-ControlNet Stack

I tried converting the widget to input but still can't connect the fields controlnet_1 and controlnet_2 to a Load ControlNet Model node

I'll take a look


Query params after factory call

Is it possible to show the factory call in the browser's address bar?
For example, when I say,
$scope.bearFails = BearSettlement.getBearFails({filters: $scope.filters, checkbox_status: $scope.checkboxStatus}, function(response) {  .... });
I want to show this url in the address bar so that it can be saved and also helps in the back button functionality. Please help.
Thanks

@shash8787, this sounds like a general support question. Please, use one of the appropriate support channels for these types of questions.
GitHub issues are reserved for bug reports and feature requests.
Thx !


Multiple Select: Selected Option not removed from Options since 4.0

On the Demo-Page, after selecting "Alaska" from the dropdown in the multiple select demo, Alaska is still under the options. If selected again, it is removed from the selected tags..
A quick fix:
[aria-selected="true"] {
  display:none;
}

This is a duplicate of https://github.com/select2/select2/issues/1538.
It's a new feature in 4.0.0 that was introduced largely for accessibility reasons.


how to use sub-menu in hope-ui?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
how to use sub-menu in hope-ui? I can't find any documents. ‘
Also, I can't find some components like sub-menu?
Is it possible to use sub-menu in hope-ui?

Hi, currently there is no support for sub-menu.

Do you have any plan on Hope UI 1.0 Release?
Expecting...

I expect to reach feature parity with the v0.x at the end of the year but it might take longer depending on the amount of time I can devote to open source.
I will publish a first prerelease probably next week.
If you want, you don't have to wait the final 1.0 to be released, just track the progress here and move when all the components you need are ported.

many thanks.


Adding a required config to the examples

Fixes #814
Tried the steps in the quickstart

Codecov Report

Merging #815 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #815      +/-   ##
============================================
- Coverage     66.65%   66.64%   -0.02%
+ Complexity     4150     4147       -3
============================================
  Files           354      354
  Lines         27217    27217
  Branches       3440     3440
============================================
- Hits          18142    18139       -3
- Misses         8130     8131       +1
- Partials        945      947       +2

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com.github.ambry.store/BlobStoreStats.java
69.61% <0%> (-2.64%)
80% <0%> (-3%)

....github.ambry.clustermap/StaticClusterManager.java
75.79% <0%> (-1.83%)
80% <0%> (-1%)

.../java/com.github.ambry.router/DeleteOperation.java
91.72% <0%> (-1.51%)
43% <0%> (-1%)

...ain/java/com.github.ambry.router/PutOperation.java
89.52% <0%> (-0.65%)
70% <0%> (-1%)

...va/com.github.ambry.replication/ReplicaThread.java
71.46% <0%> (-0.46%)
47% <0%> (-1%)

.../main/java/com.github.ambry.router/PutManager.java
85.13% <0%> (+0.67%)
22% <0%> (ø)
:arrow_down:

...m.github.ambry.clustermap/HelixClusterManager.java
94.68% <0%> (+0.7%)
34% <0%> (+1%)
:arrow_up:

...java/com.github.ambry.store/CompactionManager.java
91.79% <0%> (+0.74%)
17% <0%> (ø)
:arrow_down:

.../main/java/com.github.ambry.store/HardDeleter.java
81.93% <0%> (+1.93%)
42% <0%> (+1%)
:arrow_up:

...github.ambry.rest/AsyncRequestResponseHandler.java
90.87% <0%> (+2.28%)
23% <0%> (ø)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c51a57...4625cdf. Read the comment docs.


from_openmm GAFF molecule cannt write to AMBER

Description
Build GAFF molecule in openmm, load interchange from openmm, write amber file
Reproduction
#!/usr/bin/env python
# coding: utf-8

# # Preparing a ligand with `openmmforcefields` and Interchange
#
# [`openmmforcefields`](https://github.com/openmm/openmmforcefields) is a Python package that provides OpenMM implementations of some small molecule force fields via small molecule template generators.

# ## Validating the implementation of SMIRNOFF force fields
#
# `openmmforcefields` provides SMIRNOFF force fields via its infrastructure, internally calling the OpenFF Toolkit and using SMIRNOFF force fields provided by its `ForceField` class. Before doing novel things, let's validate that this implementation provides the same result as directly using OpenFF tools.

# In[ ]:

from openff.toolkit import Molecule
from openff.units import unit
from openff.units.openmm import ensure_quantity
from openmm.app import ForceField as OpenMMForceField
from openmmforcefields.generators import SMIRNOFFTemplateGenerator

molecule = Molecule.from_smiles("O=S(=O)(N)c1c(Cl)cc2c(c1)S(=O)(=O)NCN2")
molecule.generate_conformers(n_conformers=1)

topology = molecule.to_topology()
topology.box_vectors = unit.Quantity([4, 4, 4], unit.nanometer)

smirnoff = SMIRNOFFTemplateGenerator(molecules=molecule)
forcefield = OpenMMForceField()
forcefield.registerTemplateGenerator(smirnoff.generator)

system = forcefield.createSystem(
    topology.to_openmm(),
    nonbondedCutoff=ensure_quantity(0.9 * unit.nanometer, "openmm"),
    switchDistance=ensure_quantity(0.8 * unit.nanometer, "openmm"),
)

# `openmmforcefields` has provided us an (OpenMM) force field with SMIRNOFF parameters included as a template generator. The end goal of this setup is to create an `openmm.System`, which we can get a single-point energy of.

# In[ ]:

from openff.units import unit
from openff.units.openmm import ensure_quantity

from openff.interchange.drivers.openmm import _get_openmm_energies, _process

energy_openmmforcefields = _process(
    _get_openmm_energies(
        system,
        box_vectors=None,
        positions=ensure_quantity(molecule.conformers[0], "openmm"),
        round_positions=None,
        platform="Reference",
    ),
    system=system,
    combine_nonbonded_forces=False,
    detailed=False,
)

energy_openmmforcefields

# We can compare this to an analogous series of operations that use OpenFF tools (the toolkit's `ForceField` class and Interchange) to create an `openmm.System` that one would hope has identical contents.

# In[ ]:

from openff.toolkit import ForceField

from openff.interchange import Interchange
from openff.interchange.drivers.openmm import get_openmm_energies

sage = ForceField("openff_unconstrained-2.0.0.offxml")
interchange = Interchange.from_smirnoff(sage, [molecule])

energy_openff = get_openmm_energies(interchange)

energy_openff

# Manually inspecting the energies shows zero or marginal differences between them. We can also programmically compare these `EnergyReport` objects with `.compare`, which raises an error if there are significant differences, or `.diff`, which reports differences whether or not they are significant.
#
# In this case, valence energies are exact to nearly machine precision. Non-bonded energies differ slightly due to approximations in how electrostatics are handled with PME.

# In[ ]:

energy_openff.compare(
    energy_openmmforcefields,
    {"Nonbonded": 0.002 * unit.kilojoule_per_mole},
)

energy_openff.diff(energy_openmmforcefields)

# ## Comparing to GAFF parametrization
#
# `openmmforcefields` also provides a (partial) implementation of GAFF, using AM1-BCC in place of RESP to generate partial charges. The API for using `GAFFTemplateGenerator` is analogous to using `SMIRNOFFTemplateGenerator`.

# In[ ]:

from openmm.app import PME
from openmmforcefields.generators import GAFFTemplateGenerator

gaff = GAFFTemplateGenerator(molecules=molecule)
forcefield_gaff = OpenMMForceField()
forcefield_gaff.registerTemplateGenerator(gaff.generator)

system_gaff = forcefield_gaff.createSystem(
    topology=topology.to_openmm(),
    nonbondedMethod=PME,
)

# From here, one could use `from_openmm` to import this `openmm.System` into an `Interchange` object, which then could be combined with other `Interchange` objects generated by different paths.

# In[ ]:

from openff.interchange.interop.openmm import from_openmm

gaffInterchange =  from_openmm(
    molecule.to_topology().to_openmm(),
    system_gaff,
    box_vectors=None,
    positions=ensure_quantity(molecule.conformers[0], "openmm"),
)

gaffInterchange.to_prmtop("gaff.prmtop")

THROWS ERROR.  I moved error causing line into try, except.
This is the cause
key_: id='0-1-3-17' mult=0 associated_handler=None bond_order=None Missing value
If you comment out that line, the prmtop is written, but it's pretty different from the ACPYPE prmtop.
$ acpype -i "O=S(=O)(N)c1c(Cl)cc2c(c1)S(=O)(=O)NCN2" -a gaff2
Output
Please include the output, including full tracebacks of any errors, resulting from the reproduction.
Software versions

Which operating system and version are you using?
linux
How did you install Interchange?
conda

Most of the difference can be derived from different number of atom types, except the dihedral information is just missing from interchange's parmtops
ACPYPE
%FLAG DIHEDRAL_FORCE_CONSTANT
%FORMAT(5E16.8)
  3.13333333E+00  1.30000000E+00  3.62500000E+00  1.05000000E+00  0.00000000E+00
  3.00000000E-01  1.10000000E+00
%FLAG DIHEDRAL_PERIODICITY
%FORMAT(5E16.8)
  2.00000000E+00  2.00000000E+00  2.00000000E+00  2.00000000E+00  2.00000000E+00
  3.00000000E+00  2.00000000E+00
%FLAG DIHEDRAL_PHASE
%FORMAT(5E16.8)
  0.00000000E+00  3.14159400E+00  3.14159400E+00  3.14159400E+00  0.00000000E+00
  0.00000000E+00  3.14159400E+00

INTERCHANGE
%FLAG DIHEDRAL_FORCE_CONSTANT
%FORMAT(5E16.8)

%FLAG DIHEDRAL_PERIODICITY
%FORMAT(5E16.8)

%FLAG DIHEDRAL_PHASE
%FORMAT(5E16.8)

Thanks for the report. I've found the cause of this failure and think I have a fix. Commenting out a line around where you seems to have commented something out causes will cause no dihedrals to be written, which seems to be what you've found.


Add resource properties structure and validation

Description of changes:
Adds resource properties structure, new traits, and new validation.
This PR is a combination of the following:

https://github.com/awslabs/smithy/pull/1272  (resource tagging changes)
https://github.com/awslabs/smithy/pull/1246 (Specification documentation for resource properties)
https://github.com/awslabs/smithy/pull/1245 (Design doc for resource properties)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Looks like we need to update the IDL parser too so that it can use type elision with resource properties: https://github.com/awslabs/smithy/blob/idl-2.0/smithy-model/src/main/java/software/amazon/smithy/model/loader/SetResourceBasedTargets.java#L74


Portrait Mode in Fragment !

Description of the problem:
Hello there, the scan works well, problem is that I only can use it in landscape mode (I'm inside a fragment). And it's impossible to put the portrait mode.   qrScan.setOrientationLocked(true);  doesn't work :/
If you have any idea... Thank's :)
Which library version are you using? E.g. 3.4.0.
**Which phone/tablet are you using, and which Android version does it run? Emulator api 25 and Redmi
Does the same happen on other devices or an emulator? Yes
Can you reproduce the issue in the sample project included with the library? If not, can you
provide your own sample project or sample code that produces this error?
In the case of an error do you have a stack trace or adb logs?

I finally succed to managed it, using the option        qrScan.setCaptureActivity(CustomScannerActivity.class);
It makes the job. Thank's !


Implementing functionality for arguments

Optimize code based on the presence of a computer.
Change the game ending score based on the argument. : Currently the default is 15

Close ce71a0a8cd94df01cff6686d7436ab84b50d7db0 cb485b046837e44d9d9f109bcdc2baf7a270620b


Multitick actions

How are action that take multiple ticks/frames (e.g. movement) supposed to be implemented? Running the whole tree for many actors each frame isnt performant enough.

I've actually a little more about behavior trees (while looking for Java implementations).
It seems a better implementation would be to track the current node so that you skip parsing the entire tree every tick. I also didnt understand what the blackboard was intended for previously.
This library needs some more love I think

Sorry to say this, but without that feature this is a broken plugin. I think it should be removed from the asset store, because I am sure many like myself were looking for that feature in particular. I am not sure how to fix your code looking at it, because the documentation is not very good and the variable names are often cryptic.
Sorry if that sounds mean, I don't really mean it that way, I just don't think people want the wild goose chase.
With that in mind I may poke at your code some more, or simply write one from scratch that supports multi-tick operations.

Looking closely the error in in your logic for _execute() in the bt_base.gd, only that specific node knows that it is busy and open, because of the way you have hidden the memory of blackboard down to the level of the specific executing leaf/action node. If "isOpen" was exposed in the root memory for blackboard and had a pointer to the last executing Node then I think you could fix this.

This is a fork that I tried to cleanup and understand myself
This is an MIT open-source project
Feel free to submit a PR, happy to merge
Feel free to fork it yourself if you want to totally change it
Not sure what you're referring to with cryptic variable names. I reviewed multiple gd files and I don't see anything cryptic, the code is fairly small. Any specifics?

It's not like there are many Godot / GDScript options available. One should probably understand behavior trees and how they work before trying to use. I didn't realize myself how this needs to be optimized until I started poking around implementations in Java.

1 Understood from looking at the commits.
2 ✓
3 I tried but like I said it appears to be a deep problem, one of architecture, the code was not created with multi tick in mind.
4 Thank you.
5 This is always a taste/personal preference thing. But in my opinion everything in this code is referred to as a tick, and with so many tick things it gets confusing to sort out.
6 True. True. Makes sense. Sorry I was too harsh.
7 I am making a system for myself, if it works well I will share it with all.

@brandonlamb I come bearing gifts, will you please give me some early feedback? I would like to know if you feel this is a good implementation and if I should continue to expand it out to include the other Behavior Tree Types.
A few notes about this implementation, it was designed with iteration in mind. In a deeper tree it will only travel a few nodes down, but composite trees will automatically open and and execute their children as this is a fairly inexpensive operation. Action Nodes can wait with ERR_BUSY and the rest of the tree is capable of state across multiple frames. The previous context stored in blackboard has been integrated into the root of the behavior tree to overall simplify the structures. This code includes rudimentary Integration testing, the test code is capable of much more and the Behavior Trees can handle a deeper trees than what is run in the test scene. To run the tests, just run the "TestRunnerScene.tscn" in the tests folder.
I am sorry for being rude earlier.

Ping @brandonlamb .

I was planning to try this plugin but you are saying it's not possible to use it for movement?

Its possible to do movement and anything else thats expected from a behavior tree with this plugin, but there is room for improvement in the implementation @AnderRasoVazquez.

Thanks for clarifying =) Now I have something to play with during this quarantine... Greetings from Spain.

@brandonlamb @DagobertDev I have a solution for this that i'm using in my own project. I've mentioned it in #28 - I can submit a PR if there's interest.

Dang, somehow i totally missed seeing updates to this, I'm coming back from a long hiatus myself and trying to do some updates to some of the addons in this org. I've updated the FSM and a new FSM with stack (pushdown automaton), so today I was wanting to do a total look over this behavior tree addon based on the new learnings I've had over the past year.
I'll create a PR so we can look at the changed files

@brandonlamb that's awesome, I'm interested in the pushdown FSM, I was going to implement it myself after this week's Godot Wild jam. I'll submit the PR to fix this issue once the jam is over. It's getting lots of testing in the jam and on my side project.

Yea I remember reading on pushdown automaton way back when, but didnt really understand it at the time. I created an issue on the FSM repo to also add links to other FSM implementations that I've stumbled upon for Godot (there are like 5)

@brandonlamb I misunderstood this issue so the solution I'm referring to isn't correct.


Don't need to create destination VM

use the following command to get Source VM's outbound IP.  I don't think we need destination VM.
curl ifconfig.me

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a2bbaaa6-eae8-49b3-bb2b-4efcf2da30e4
Version Independent ID: 047b57e3-47c4-99be-abd4-c82574860604
Content: Tutorial: Create and test a NAT gateway - Azure CLI
Content Source: articles/virtual-network/tutorial-create-validate-nat-gateway-cli.md
Service: virtual-network
GitHub Login: @asudbring
Microsoft Alias: allensu

Hi!
Can you elaborate on your question?  The destination VM is there to show the outbound traffic out of the NAT to an oubound public IP.
Thanks!

@haoxin We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

the destination VM was provided to create a complete e2e to avoid any issues in the path between the source and destination or any destination rate limiting etc. this tutorial is intended to be completely self contained.  of course, you can target any destination you want in your validation.


Segmentation Fault?

Hello. Thanks for your amazing work.
If I run the example in your README:
import torch
from torch import nn
from mixture_of_experts import MoE

moe = MoE(
    dim = 512,
    num_experts = 16,               # increase the experts (# parameters) of your model without increasing computation
    hidden_dim = 512 * 4,           # size of hidden dimension in each expert, defaults to 4 * dimension
    activation = nn.LeakyReLU,      # use your preferred activation, will default to GELU
    second_policy_train = 'random', # in top_2 gating, policy for whether to use a second-place expert
    second_policy_eval = 'random',  # all (always) | none (never) | threshold (if gate value > the given threshold) | random (if gate value > threshold * random_uniform(0, 1))
    second_threshold_train = 0.2,
    second_threshold_eval = 0.2,
    capacity_factor_train = 1.25,   # experts have fixed capacity per batch. we need some extra capacity in case gating is not perfectly balanced.
    capacity_factor_eval = 2.,      # capacity_factor_* should be set to a value >=1
    loss_coef = 1e-2                # multiplier on the auxiliary expert balancing auxiliary loss
)

inputs = torch.randn(4, 1024, 512)
out, aux_loss = moe(inputs) # (4, 1024, 512), (1,)

then I get a segmentation fault:
[1]    16777 segmentation fault (core dumped)
Can you help me with this?
I'm using torch 1.3.0 on CUDA 10.1.
Thanks.

The problem was resolved when I upgraded the pytorch version to 1.4.0. I think previous versions were buggy. Thanks anyway.


Correctly report indices and aliases

Improve the reporting on indices and aliases that match index naming.
Before
Indices created via Chewy without a suffix would fail to report themselves as an index or alias for the Chewy index.
DummyIndex.create! # => {'acknowledged' => true}
DummyIndex.indexes # => []
DummyIndex.aliases # => []

Indices created via Chewy with a suffix would correctly report the suffixed index but would fail to report the alias
DummyIndex.create!('2013') # => {'acknowledged' => true}
DummyIndex.indexes # => ['dummies_2013']
DummyIndex.aliases # => []

After
Indices created via Chewy without a suffix will correctly report themselves as an index.
DummyIndex.create!
DummyIndex.indexes # => ['dummies']
DummyIndex.aliases # => []

Indices created via Chewy with a suffix will correctly report the alias
DummyIndex.create!('2013') # => {'acknowledged' => true}
DummyIndex.indexes # => ['dummies_2013']
DummyIndex.aliases # => ['dummies']

It was rebased at https://github.com/toptal/chewy/pull/757 and some details were changed in order to avoid some false positives on indexes when two distinct classes are named with containing names.
It is waiting a little to merge, just to make sure that breaking changes introduced will not affect other stuff


Items that are not ImageViews cause disorted photos

When I'm trying to wrap ImageView with, say, RelativeLayout, the items becomes disorted.
Why is that ? I want to add views on top of imageView so I need a container but that makes thing look very bad.
Any idea why ?

Never mind, got that working.

@eshkoliGilad I have the same issue, when my ImageView is wrapped with another layout it is disorted. How did you fix that please ?

I've just made sizeForChildAtPosition() method of GreedoLayoutManager static and I call it in OnBind in the adapter:
    holder.mImageView.getLayoutParams().width = GreedoLayoutManager.sizeForChildAtPosition(position).getWidth();
    holder.mImageView.getLayoutParams().height = GreedoLayoutManager.sizeForChildAtPosition(position).getHeight();

@eshkoliGilad Ok so you had to update the library code. In that case your issue is still valid. I opened a similar one here #16

@eshkoliGilad  It will helpful if you share  GreedoLayoutManager class, I'm also struggling to over come this issue.
thanks

@The-RobinHood
The only thing I did for setting sizeForChildAtPosition() static and then in you onBind() function just calling:
holder.mImageView.getLayoutParams().width = GreedoLayoutManager.sizeForChildAtPosition(position).getWidth();
holder.mImageView.getLayoutParams().height = GreedoLayoutManager.sizeForChildAtPosition(position).getHeight();
You may consider using this on your main container also if this doesn't help you.
I know it is not the perfect solution, but it was the quickest one.

@eshkoliGilad  can you share your GreedoLayoutManager class, if you don't mind?

@eshkoliGilad  hey, it will really helpful to me if you share your GreedoLayoutManager class, I'm stuck with this issue for a week. thanks

@The-RobinHood can u please tell us, how u solved the issue ? #21

Just changing the method to static will not work, as it accesses instance variables which of course aren't valid in a static context.
What I did instead was to give the GreedoLayoutSizeCalculator (which can be retrieved by GreedoLayoutManager#getSizeCalculator()) to my adapter. I just added a member variable and a setter. After that you can just do the following within your onBindViewHolder(...) method:
    Size imageViewSize = mSizeCalculator.sizeForChildAtPosition(position);
    holder.itemView.getLayoutParams().width = imageViewSize.getWidth();
    holder.itemView.getLayoutParams().height = imageViewSize.getHeight();

I still don't really like this because I feel like it doesn't really match the concept of adapters and layout managers, but if I remember correctly I didn't have to change any library code.


[Event Request] Codeunit 5763 "Whse.-Post Shipment": Handled Pattern in TryPostSourceDocument Functions

Hi,
please add handled patterns to

OnBeforeTryPostSourcePurchDocument  in TryPostSourcePurchDocument()
OnBeforeTryPostSourceTransferDocument  in TryPostSourceTransferDocument()

In TryPostSourceSalesDocument(), there is already a handled pattern with the event publisher OnPostSourceDocumentOnBeforeSalesPost so it would make sense to equalize all these publishers.
In my specific use case, I need to run the whole posting process in a single transaction (using CommitBehavior::Ignore), so the if Codeunit.Run() statements in the TryPostSourceDocument functions will raise a runtime error and I need a way to skip them/replace them with Codeunit.Run() calls. For sales this already works, so it would be great if this would work for the other document types aswell.
Alternatively you could provide a way to change the WhseSetup."Shipment Posting Policy" in PostSourceDocument, but I think the first approach is more sensible.
Thanks and kind regards!

Version: DE Business Central 19.2 (Platform 19.0.32956.34411 + Application 19.2.32968.34456)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


updated installation file for win

#24  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mAmineChniti and the rest of your teammates on  Graphite


Memory leaks with detectAllFaces

Hi,
I have this coffeescript code snippet :
# Analyse the new frame
    analyseFrame: (next = _.noop) ->

        @testCount = 200 unless (typeof(@testCount) is 'number')

        # Skip if not capturing
        return unless Service.isCapturing

        # get frame
        _frame = Service.videoCapture.getFrame()

        # get frame date
        @currentFrameTime = Date.now()

        # clear old faces in history
        @refreshFaceHistory(@currentFrameTime)

        #convert frame to a tensor
        try
            _data = new Uint8Array(_frame.cvtColor(cv.COLOR_BGR2RGB).getData().buffer)
            _tensorFrame = tfjs.tensor3d(_data, [_frame.rows, _frame.cols, 3])
        catch _err
            @log.error "Error instantiating tensor !!!"
            @log.error _err.message

        faceapi.detectAllFaces(_tensorFrame, @faceDetectionOptions).then (_detectedFaces) =>
            @log.debug _detectedFaces

            # fill face history with detceted faces
            _detectedFaces = @fillFacesHistory(_detectedFaces)

            # draw boxes on image
            Service.videoCapture.drawFaceBoxes(_frame, _detectedFaces)

            # Get partial time
            Service.frameDuration = Date.now() - @currentFrameTime

            # write latency on image
            Service.videoCapture.writeLatency(_frame, Service.frameDuration)

            # show image
            Service.faceRecoUtils.showImage(_frame)

            # Call next
            _delayNextFrame = Math.max(0<EMAIL_ADDRESS>- Service.frameDuration)

            # DEBUG MEMORY DUMP every 30 sec
            if @testCount > (5*30)

                @testCount = 0

                _dumpPath = path.resolve(__dirname + "./../memoryDump/" + @currentFrameTime + '.heapsnapshot')
                heapdump.writeSnapshot _dumpPath

            setTimeout =>
                # console.log "Next frame : #{_delayNextFrame}ms - TOTAL : #{_frameDuration}ms"
                @analyseFrame()
            , (_delayNextFrame)

        @testCount++

I feel like detectAllFaces is causing memory leaks. In deed, the corresponding nodejs process gains approximately 0.5 to 1% memory usage for each processed frame ! So my RAM get totally filled really quickly. I tried to get memory dump using heapdump but I don't see anything anormal (all my dumps have same size on Google Chrome inspector). So this could means that memory leaks come from the C++ size of face-api.js, right ?
At first, I thought the leak could comes from combination of loops and promises or from Service.videoCapture. But I get similar results with the below code. The only difference being that RAM is filled slower. Which seems normal since the image used is smaller than my webcam's frames.
# Analyse the new frame
    analyseFrame: (next = _.noop) ->

        # Skip if not capturing
        return unless Service.isCapturing

        _currentFunctionCallTime = Date.now()

        # get frame
        _frame = Service.videoCapture.getFrame()

        # if analyzer is ready, we can take a frame from webcam and process it
        if @analyzerIsReady

            @analyzerIsReady = false

            # get frame date
            @currentFrameTime =_currentFunctionCallTime

            # get frame
            _analyzedFrame = _frame

            # clear old faces in history
            @refreshFaceHistory(@currentFrameTime)

            @log.debug "faceHistory.length = ", Service.faceHistory.length

            _analyzedFrame = cv.imread('/home/loophole/eventbots-packages/eb/tiki-service-facedetection/models/bbt3.jpg')

            #convert frame to a tensor
            try
                _data = new Uint8Array(_analyzedFrame.cvtColor(cv.COLOR_BGR2RGB).getData().buffer)
                _tensorFrame = tfjs.tensor3d(_data, [_analyzedFrame.rows, _analyzedFrame.cols, 3])
            catch _err
                @log.error "Error instantiating tensor !!!"
                @log.error _err.message

            faceapi.detectAllFaces(_tensorFrame, @faceDetectionOptions).then (_detectedFaces) =>

                # fill face history with detceted faces
                _detectedFaces = @fillFacesHistory(_detectedFaces)

                # Get partial time
                Service.frameDuration = Date.now() - @currentFrameTime

                # Call next
                _delayNextFrame = Math.max(0<EMAIL_ADDRESS>- Service.frameDuration)

                setTimeout =>
                    @analyzerIsReady = true
                , (_delayNextFrame)

        _callDuration = Date.now() - _currentFunctionCallTime

        _delayNextCall = Math.max(0<EMAIL_ADDRESS>- _callDuration)

        setTimeout =>
                @analyseFrame()
            , (_delayNextCall)

If you do not dispose the tensors you create, you will always leak memory. Try tracking tf.memory(), if the number of allocated tensors is growing with each frame,  you are leaking memory.

Hi!
I having similar issue with this code in a loop:
		img = await commons.canvas.loadImage(data);
		detections = await faceapi.detectAllFaces(img, faceDetectionOptions).withFaceLandmarks().withFaceDescriptors();

In few seconds I fill all my RAM, how can I dispose something to avoid memory leak?
Thanks!

Solved!, only happend when run in debug mode, maybe never dispose because of that.
Thanks!


Persistent layer for threads data

Hello. Thx for this project.
Our use case:
We created links between Teams channels off-topic/town square in same instance.
Is your feature request related to a problem? Please describe.
After restart of matterbridge it lost threads links/relation to parent message
Describe the solution you'd like
Maybe some persistent layer for storing this data.
Describe alternatives you've considered
Some kv storage
Additional context

Duplicate of https://github.com/42wim/matterbridge/issues/541 :)


Remove repetitive error wrapping from internal/cache

What does this PR change? What problem does it solve?
Many instances of errors.Wrap in this package would produce messages like "Open: open : no such file or directory"; those now omit the first "Open:" (or "Stat:", or "MkdirAll"). The function readVersion now appends its own name to the error message, rather than the function that failed, to make it easier to spot. Other function names (e.g., Load) are already added further up in the call chain.
I tested this by writing small test programs that trigger errors in os functions.
Was the change discussed in an issue or in the forum before?
I considered opening an issue for this, as this pattern occurs in several places throughout the codebase, but I decided against it because the issue would be very open-ended. I'll submit separate PRs if and when I find more occurrences.
Checklist

[x] I have read the Contribution Guidelines
[x] I have enabled maintainer edits for this PR
[ ] I have added tests for all changes in this PR
[ ] I have added documentation for the changes (in the manual)
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

I hadn't considered the stack traces. I pushed a new version that uses WithStack and added a few more calls to that, thought not where errors come from functions in the same package. The error handling is still not entirely consistent in how it works.


Replace actions-rs uses with toolchain install

Proposed changes

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Codecov Report

Merging #67 (9865603) into main (c330596) will decrease coverage by 5.03%.
The diff coverage is 63.66%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   77.66%   72.64%   -5.03%
==========================================
  Files         278      279       +1
  Lines       30315    30630     +315
  Branches        0    30630   +30630
==========================================
- Hits        23545    22252    -1293
- Misses       6770     6781      +11
- Partials        0     1597    +1597

Impacted Files
Coverage Δ

.../tedge_config/src/tedge_config_cli/tedge_config.rs
50.48% <0.00%> (-0.85%)
:arrow_down:

crates/common/tedge_utils/src/file.rs
66.83% <ø> (-5.90%)
:arrow_down:

crates/core/plugin_sm/src/plugin.rs
9.97% <0.00%> (+9.97%)
:arrow_up:

crates/extensions/c8y_http_proxy/src/actor.rs
33.18% <0.00%> (-5.78%)
:arrow_down:

crates/extensions/c8y_mapper_ext/src/converter.rs
76.32% <0.00%> (-10.52%)
:arrow_down:

crates/common/download/src/error.rs
28.57% <20.00%> (-25.98%)
:arrow_down:

plugins/tedge_apt_plugin/src/main.rs
25.00% <45.33%> (+8.92%)
:arrow_up:

crates/core/c8y_api/src/smartrest/operations.rs
73.98% <55.00%> (-15.09%)
:arrow_down:

...s/common/download/src/download/partial_response.rs
55.10% <55.10%> (ø)

crates/common/download/src/download.rs
76.33% <74.85%> (-12.65%)
:arrow_down:

... and 6 more

... and 165 files with indirect coverage changes


Create ISO timestamps from metadata for file names

we need to use ISO timestamps to properly name the downloaded GeoTiffs

done with #13


feature/add github workflow

in the future I need to add code to test and build the projec

added workflow in develop branch, all changes (commit or pull request) will be pushed to master branch


Docs refresh

Update to add docs for the new v8 file picker, removes docs for versions older than 7.2 (based on usage data these aren't used).

Docs Build status updates of commit 2135160:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/controls/file-pickers/index.md
:warning:Warning
View (>= odsp-graph-online)
Details

docs/controls/file-pickers/v8-schema.md
:warning:Warning
View (>= odsp-graph-online)
Details

docs/index.md
:warning:Warning
View (>= odsp-graph-online)
Details

docs/controls/file-pickers/js-v72/index.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/TOC.md
:white_check_mark:Succeeded
View (>= odsp-graph-online)

docs/controls/file-pickers/android/android-picker-saver.png
:white_check_mark:Succeeded

docs/controls/file-pickers/android/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/open-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/save-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/unified-js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/open-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/save-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/unified-js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/react/customization.md
:white_check_mark:Succeeded

docs/controls/file-pickers/react/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/react/select-files.md
:white_check_mark:Succeeded

docs/controls/file-pickers/index.md

Line 33, Column 80: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/sharepoint/dev/spfx/use-aadhttpclient#request-permissions-to-an-azure-ad-application' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 33, Column 80: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/sharepoint/dev/spfx/use-aadhttpclient#request-permissions-to-an-azure-ad-application' will be broken in isolated environments. Replace with a relative link.

docs/controls/file-pickers/v8-schema.md

Line 1, Column 1: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs/index.md

Line 46, Column 93: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/sharepoint/dev/spfx/viva/get-started/build-first-sharepoint-adaptive-card-extension' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 46, Column 242: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/sharepoint/dev/spfx/extensions/get-started/building-simple-cmdset-with-dialog-api' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 46, Column 384: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/overview-client-side-web-parts' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 46, Column 495: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/sharepoint/dev/spfx/extensions/overview-extensions' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 46, Column 93: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/sharepoint/dev/spfx/viva/get-started/build-first-sharepoint-adaptive-card-extension' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 242: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/sharepoint/dev/spfx/extensions/get-started/building-simple-cmdset-with-dialog-api' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 384: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/overview-client-side-web-parts' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 495: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/sharepoint/dev/spfx/extensions/overview-extensions' will be broken in isolated environments. Replace with a relative link.

docs/controls/file-pickers/js-v72/index.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7a3f6d2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/file-pickers/index.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/controls/file-pickers/js-v72/index.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/controls/file-pickers/v8-schema.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/index.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/TOC.md
:white_check_mark:Succeeded
View (>= odsp-graph-online)

docs/controls/file-pickers/android/android-picker-saver.png
:white_check_mark:Succeeded

docs/controls/file-pickers/android/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/open-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/save-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/unified-js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/open-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/save-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/unified-js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/react/customization.md
:white_check_mark:Succeeded

docs/controls/file-pickers/react/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/react/select-files.md
:white_check_mark:Succeeded

docs/controls/file-pickers/index.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 33, Column 80: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/use-aadhttpclient#request-permissions-to-an-azure-ad-application' will be broken in isolated environments. Replace with a relative link.

docs/controls/file-pickers/js-v72/index.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs/controls/file-pickers/v8-schema.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs/index.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 46, Column 93: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/viva/get-started/build-first-sharepoint-adaptive-card-extension' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 236: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/extensions/get-started/building-simple-cmdset-with-dialog-api' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 372: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/web-parts/overview-client-side-web-parts' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 477: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/extensions/overview-extensions' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 181525b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/file-pickers/index.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/controls/file-pickers/js-v72/index.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/controls/file-pickers/v8-schema.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/index.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/TOC.md
:white_check_mark:Succeeded
View (>= odsp-graph-online)

docs/controls/file-pickers/android/android-picker-saver.png
:white_check_mark:Succeeded

docs/controls/file-pickers/android/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/open-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/save-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/unified-js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/open-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/save-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/unified-js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/react/customization.md
:white_check_mark:Succeeded

docs/controls/file-pickers/react/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/react/select-files.md
:white_check_mark:Succeeded

docs/controls/file-pickers/index.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 33, Column 80: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/use-aadhttpclient#request-permissions-to-an-azure-ad-application' will be broken in isolated environments. Replace with a relative link.

docs/controls/file-pickers/js-v72/index.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs/controls/file-pickers/v8-schema.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs/index.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 46, Column 93: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/viva/get-started/build-first-sharepoint-adaptive-card-extension' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 236: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/extensions/get-started/building-simple-cmdset-with-dialog-api' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 372: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/web-parts/overview-client-side-web-parts' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 477: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/extensions/overview-extensions' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9191fba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/file-pickers/index.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/controls/file-pickers/js-v72/index.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/controls/file-pickers/v8-schema.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/index.md
:bulb:Suggestion
View (>= odsp-graph-online)
Details

docs/TOC.md
:white_check_mark:Succeeded
View (>= odsp-graph-online)

docs/controls/file-pickers/android/android-picker-saver.png
:white_check_mark:Succeeded

docs/controls/file-pickers/android/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v5/js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/open-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/save-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v6/unified-js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/js-sample.css
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/open-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/save-file.md
:white_check_mark:Succeeded

docs/controls/file-pickers/js-v7/unified-js-sample.js
:white_check_mark:Succeeded

docs/controls/file-pickers/react/customization.md
:white_check_mark:Succeeded

docs/controls/file-pickers/react/index.md
:white_check_mark:Succeeded

docs/controls/file-pickers/react/select-files.md
:white_check_mark:Succeeded

docs/controls/file-pickers/index.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 33, Column 80: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/use-aadhttpclient#request-permissions-to-an-azure-ad-application' will be broken in isolated environments. Replace with a relative link.

docs/controls/file-pickers/js-v72/index.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs/controls/file-pickers/v8-schema.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs/index.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 46, Column 93: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/viva/get-started/build-first-sharepoint-adaptive-card-extension' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 236: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/extensions/get-started/building-simple-cmdset-with-dialog-api' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 372: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/web-parts/overview-client-side-web-parts' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 477: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/spfx/extensions/overview-extensions' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@ThomasMichon - thanks for the review - cleaned up the latest two items you noted. Ready for a final review. Thanks!


Neo-tree integration explodes on invalid read of remote location

Today I had the fun experience of my work VPN dying while trying to connect to a remote server over ssh. In that process, netman fails to read the ssh server I told it to and properly tosses an error (though maybe not the best one)

Unable to read ssh://$SERVERNAME///, received error / doesn't exist

This is good! However, it looks like something is mildly broken with how we integrate those "results" into Neo-tree as immediately after this error, we get the following failure
E5108: Error executing lua: ...re/nvim/lazy/netman.nvim/lua/netman/ui/neo-tree/init.lua:1017: bad argument #1 to 'ipairs' (table expected, got nil)
stack traceback:
        [C]: in function 'ipairs'
        ...re/nvim/lazy/netman.nvim/lua/netman/ui/neo-tree/init.lua:1017: in function 'navigate'
        ...vim/lazy/netman.nvim/lua/netman/ui/neo-tree/commands.lua:14: in function 'func'
        ...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:782: in function <...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:780>

We need better nil handling on results within our Neo-tree integration it seems

I'm not sure which commit this was resolved in, but it has been addressed in the #143


Fix release fail

The version string parsed from __init__.py is '0.8.34'

Coverage remained the same at 94.213% when pulling 89bd813bc4e1abecb1d8e705b3f8471c59d86cea on feature/fix_typo into 1b677c06a92f075055f9f8fc93cb6023eed10109 on develop.


LazyOperations should not return nested Eval but simply Maybe< >

Maybe is already lazy and represents a value that may or may not be present.

Going to move to 1.0.3 as bug

Merged


Bugfix: since and before filtering for docker images

Signed-off-by: Jules Testard<EMAIL_ADDRESS>

@jtestard can you rebase your PR on the master branch?


It should be possible to load session IDs from the user profile

In the case of a user having an important ID in their profile, it should be possible to load the ID from there.

Added


Maven Repository

I'd like to use this in my project to have the same result as the Markdown Navigator plugin.
I don't see this plugin on the maven repository? Do you plan to publish it there?
Is there any simple example code to generate a html output for given markdown file?

@kiru, I have not setup the project at maven central. I was focused on getting it complete and releasing the plugin first. Now that it is done I will work on getting it released on maven central.
If you want I can make a jar for you of all the modules and give you the sample code to setup all the options that the plugin uses to setup the parser/renderer.
Default parser/renderer configuration is commonmark compliant which does not work well for GFM.
Let me know if you want the jar or will wait for the maven central release. It might take a few days since I have to add rudimentary javadocs to all the classes.

@vsch Thank you for the quick reply. I can wait for the maven realease. Don't hurry, take your time to.


Additional behaviour for scrolling

Hey, I have some ideas for possible add-ons, that would help to customize the graph:

option to move the graph when scrolling on the mouse (instead of zooming) -> maybe that you can choose if you either want to move, zoom or do nothing when scrolling
possibility to disable a certain direction for moving, e.g. that you only allow to move the graph vertically
when mouse scrolling triggers to move the graph, you could add the option to zoom on scroll+keypress

Hi There! We would love to see a scrollable canvas with the mouse! We are currently building a flow builder, and when it's becoming bigger and bigger our users expect to use the scroll to move the canvas. Are there any plans to work on this feature?

Hi  @ThomasVlaar  , Did you use ReactFlow for this.If so,Is it possible  handles and draw edges?.please let me know.Iam curious about that.

We added a onPaneScroll handler. This could help you to implement a custom scroll logic.

@moklick - Any tips on best way to implement this?

@moklick Hey, I'm a colleague of Emiel and Thomas.  First of all thanks for the work you're doing with Reactflow, we really like the package :).
There is one thing we are struggling with, we tried implementing the onPanelScroll to fix scrolling in the canvas but this didn't give us the result we are looking for.
screenrecordings of the scrolling implementations
Option 1: Scrolling using the onPaneScroll function
In the first screen recording you can see that the entire page is being scrolled because the browser can't know that this is a spot that can be scrolled. This is a bit of an exaggeration, we can of course speed up the scroll speed but this will always be an issue with this approach I think.
Another issue we encountered with this option is that scrolling with a mouse wheel needs a much higher speed to scroll effectively trough the canvas as oppose to a trackpad. We couldn't find a happy medium for both mouse and touchpad scrolling.
Option 2: Scrolling using native scrollbars
We tried to add native scrollbars to check if this would be a viable option and to see what works and what doesn't.
To test this we added the following to the ReactFlow component:
style={{ maxHeight: '100%', overflow: 'scroll' }}
I think we do prefer option 2 to use native scroll behaviour but there are things that will break with this implementation as you can see in the second screencast.
What do you think? and what are your plans to create scroll functionality in ReactFlow if there are any? Perhaps this is something we could wait for?

We have not yet started working on this but it is definitely something we want to have in the library. I think both of your versions look quite good already. Can you explain what is not working in option 2 exactly? Did you try fixing the behaviour in option 1 with CSS (something like position: fixed for the root element)?
Anyway, is there any way you can reproduce both examples in a codesandbox or so? That may be very helpful for us to implement the scrolling feature into the library.
Thanks!

@chrtze Hey Christopher, thanks for the quick response. If it is possible to fix option 2 easily, we're very interested.
I created a codesandbox with the two options, hope this helps to explain: https://codesandbox.io/s/reactflow-scrolling-implementation-2kuro?file=/src/App.js
Thanks for your efforts, we appreciate it very much!

We have implemented a first version of the scroll to pan feature. You can try it out by installing the pre-release: npm install react-flow-renderer@next. The feature is enabled like this: <ReactFlow elements={elements} panOnScroll />.
Feedback is very appreciated :)

@chrtze Hey Christopher, wow very nice 👍
I tried this in the codesandbox as well and it works great: https://codesandbox.io/s/reactflow-scrolling-implementation-using-next-xhgq6?file=/src/App.js
Couple of questions:

As you can see in the codesandbox the rest of the page is still scrolling when you scroll a lot, do you know a solution for this? Maby we could fix this with CSS like you suggested before? I tried a couple of things but I couldn' t get this to work.

Would it be possible to change the speed of the scrolling?
If this isn't easy to implement I think it's fine as it is now.

Great that you implemented this so quickly, we're very happy and impressed :)

@chrtze Hey Christopher, wow very nice 👍
I tried this in the codesandbox as well and it works great: https://codesandbox.io/s/reactflow-scrolling-implementation-using-next-xhgq6?file=/src/App.js
Couple of questions:

As you can see in the codesandbox the rest of the page is still scrolling when you scroll a lot, do you know a solution for this? Maby we could fix this with CSS like you suggested before? I tried a couple of things but I couldn' t get this to work.

Would it be possible to change the speed of the scrolling?
If this isn't easy to implement I think it's fine as it is now.

Great that you implemented this so quickly, we're very happy and impressed :)

@roywillemse 1: I can reproduce that the page is "bouncing" when I use the trackpad to scroll the graph. with a regular mousewheel, it works fine. I fixed this in our examples by using body { overflow: hidden }. but not so sure if this is a good approach in your case. https://stackoverflow.com/questions/28103125/disable-inertia-scroll-for-single-page-webapp
2: That's a good idea. I think it would not be too complicated to implement it, we would need some parameter like scrollSpeed={1.5}. Maybe d3-zoom has something built in, I will check that.

@chrtze 1: Thanks for the link, I tested this and we can add: `overscroll-behavior-y: none; on the body to fix this. Very nice.
2: If that would be possible and easy to implement that would be awesome, a scollSpeed parameter would be perfect.
Thanks!

There is a possibility in d3-zoom to change the wheelDelta: https://github.com/d3/d3-zoom#zoom_wheelDelta
I only need to figure out how a property for this could look like in react-flow.

released in 7.0.0. we also introduced a new property panOnScrollSpeed to control the speed of the movement. The page bounce when using the trackpad has also been fixed in this version by using event.preventDefault and event.stopPropagation, same as in d3-zoom.

Awesome job, this solution perfectly fits our needs. Really appreciate the effort 🚀.

Thank you very much @chrtze ! We're very happy with the end result. Keep up the good work!


Update native names

sorry for the mistakes, i'm newbie with github

Since pull request #356 does include these changes, I'll close this one.


Add all device families to DeviceFamilyAdaptiveTrigger

The DeviceFamilyAdaptiveTrigger supports the Phone, Desktop and universal families but not

[x] Team (Surface Hub).
[ ] Xbox
[ ] IoT (currently returns 'Universal' but that's a bug in current release)
[ ] HoloLens

@robertos Updated issue to contain all device types. Unfortunately don't have these devices or APIs to test on. Feel free to send me a Surface Hub so I can test it ;-)

Now that the description says "all families", the issue is not fixed. Leave it open?

Xbox family is Windows.Xbox, as per published sample: https://github.com/Microsoft/Windows-universal-samples/blob/master/xaml_statetriggers/CS/MainPage.xaml#L141

Yup leave it open. Github has a weird way of auto closing issues is there are certain words the PR

HoloLens (Holographic) added:
https://github.com/dotMorten/WindowsStateTriggers/commit/3a97a7a45b9c997e4f59e4afd98dc1ee7e0d8a49


Add a footer for disclaimers

We need to add the following footer to every page on the site:
"Apache Kafka, Apache Kafka Connect, Apache Kafka MirrorMaker 2, Apache Flink and Apache Cassandra are either registered trademarks or trademarks of the Apache Software Foundation in the United States and/or other countries. M3, M3 Aggregator, OpenSearch, PostgreSQL, MySQL, Redis, InfluxDB, Grafana are trademarks and property of their respective owners. All product and service names used in this website are for identification purposes only and do not imply endorsement."

I think we can just add it directly to the template, but we probably need to style it differently from normal text.

Note that the actual text to be included is still under review. See the internal slab page for the most current version.

@lornajane @TibsAtWork WDYT? The disclaimer is added here - emphasized and 2 size smaller fonts.

I like the italics, and the positioning. I think I'd perhaps only go down 1 font size - there's a balance between making it not too obtrusive, but letting it be obvious. But I'd want to see it at that size...


Wildcard in the route

Is there any option to set the wildcard to the route or to the part of it?
While inspired by Nesta CMS which is based on Sinatra, I didn't find such feature in your framework (did I miss something?).
In Nesta it is used to catch all URLs ant to retrieve specific template file.
    get '*' do
      set_common_variables
      @heading = @title
      parts = params[:splat].map { |p| p.sub(/\/$/, '') }
      @page = Nesta::Page.find_by_path(File.join(parts))
      raise Sinatra::NotFound if @page.nil?
      @title = @page.title
      set_from_page(:description, :keywords)
      cache<EMAIL_ADDRESS>:layout => @page.layout)
    end

The difference is that in your framework it parse URL parameters by word (\w), so you can not make some common rule with unknown amount of parameters or words.
I like your framework a lot, so could we see something similar?

I've been meaning to add this for a while. This isn't an immediate concern, but I'll add it to the Road Map.

I don't recommend this but what I did was use the notFound method as my catchall since it isn't implemented as yet.

Yes, I've considered this possibility, but still hope there will be native support for wildcards, as it could be greate to use it more flexible than simple '*'.


conversion of String -> CharSequence does not handle null

This code results in a runtime error:
value maybeString = Java.getStringOrNull();
Java.soWithCharSequence(maybeString);

Because the generated code to convert String -> CharSequence doesn't account for null.

@FroMage Gotta be super-easy to fix.

Done.

Thanks.


Game Center not working in Godot editor

I am unable to use the Game Center plugin in the editor (v3.3.4 on MacOS). I have downloaded the latest release (plugins_3.3.zip) and copied the gamecenter directory into the ios/plugins folder under res://. I have added the following code to my project in my scene's _ready function:
if Engine.has_singleton("GameCenter"):
        game_center = Engine.get_singleton("GameCenter")
        game_center.authenticate()
else:
        print("iOS Game Center plugin is not available on this platform.")

This always fails to find the GameCenter singleton (prints out "iOS Game Center plugin is not available on this platform."). Perhaps there is some step I am missing? I do see 'GameCenter' under plugins when I got to Export/IOS.
I do not know if this is working on device as I am unable to build for iOS at the moment due to Fastlane issues.

iOS plugins are iOS specific, so they are available only on iOS device or simulator. You have to export the game to iOS and run it.


whereDate casting of Carbon unexpected behaviour

Laravel Version: 5.7+
PHP Version: 7.2
Database Driver & Version: Mysql/MariaDb/Amazon Aurora

Description:
whereDate() casting of Carbon objects causes unexpected results
whereDate('starts_at', '>', new Carbon());
becomes
DATE('starts_at') > 2019-09-10
becomes
DATE('starts_at') > 2000
This appears to happen because \Illuminate\Database\Query\Builder since 5.7 does:
WhereDate()....
if ($value instanceof DateTimeInterface) {
    $value = $value->format('Y-m-d');
}

But doesn't enclose the $value in quotes when passing it to the bindings.
A fix for this is to drop the minus symbols, so that $value->format('Ymd') is used, at least according to https://dev.mysql.com/doc/refman/8.0/en/date-and-time-literals.html

Date and time values can be represented in several formats, such as quoted strings or as numbers, depending on the exact type of the value and other factors. For example, in contexts where MySQL expects a date, it interprets any of '2015-07-21', '20150721', and 20150721 as a date.

As a more real world example:
    public function __construct(Carbon $from, Carbon $to)
    {
        $this->from = $from->copy();
        $this->to   = $to->copy();
    }

...
return $builder->whereDate('starts_at', '<=', $this->to)
->whereRaw('DATE(IF(terminated_at, terminated_at, ends_at)) >= \'?\'', $this->from->format('Y-m-d'));

The whereRaw is working just fine, the wereDate does not.

@staudenmeir As the description demonstrates, although it could be more verbose, so here you go:
Actual:
whereDate casts a Carbon object into a string via format('Y-m-d') which is then assembled into the SQL DATE('column') > Y-m-d This string isn't encapsulated in quotes, so MySQL see it as an arithmetic expression, Y minus m minus d = value.
e.g.
DATE('starts_at') > 2019-09-10 which MYSQL sees as arithmetic and turns into DATE('starts_at') > 2000
as you can see, start_at > 2000 isn't the same as start_at > 2019 so leads to many side effects.
Expected:
DATE('starts_at') > '2019-09-10' or DATE('starts_at') > 20190910 or DATE('starts_at') > '20190910'
Hope that makes it clearer.

Please provide a complete example with migration, sample data and query.
Are you overriding PDO::ATTR_EMULATE_PREPARES?

Are you overriding PDO::ATTR_EMULATE_PREPARES
Nope.

Can you reproduce it on a fresh Laravel installation? I can't.

This string isn't encapsulated in quotes, so MySQL see it as an arithmetic expression, Y minus m minus d = value.

Since Laravel passes the string as a binding, it doesn't need to be wrapped in quotes.

And that's why the problem occurs.  Please read the problem that's happening..

That's the core of the issue, because the time is being converted into a string with minus symbols in it, and it's not in a format that MySQL sees as a date, it does a mathematical operation on the string.

Please do. I've never seen such behavior.
Even before Laravel introduced support for DateTimeInterface objects, people were successfully using whereDate() with Y-m-d-formatted strings.

@staudenmeir This bug report is not correct and whereDate is working fine.
Environement:

Ubuntu 16.04
Laravel 6.0
MySql 10.3.14-MariaDB-1:10.3.14+maria~bionic

Steps:

Install fresh Laravel 6.0
Go to tinker: php artisan tinker
Create 10 users: factory(\App\User::class, 10)->create();
Enable query log in MySQL using below command:

set global general_log=ON;
set global general_log_file='/tmp/query.log';

execute the below query that includes whereDate:
\App\User::whereDate('created_at', new \Carbon\Carbon())->inRandomOrder->first();
Open the log file by this command tail -f /tmp/query.log. The result is:

                   466 Query    use `laravel`
                   466 Prepare  set names 'utf8mb4' collate 'utf8mb4_unicode_ci'
                   466 Execute  set names 'utf8mb4' collate 'utf8mb4_unicode_ci'
                   466 Close stmt
                   466 Prepare  set session sql_mode='ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'
                   466 Execute  set session sql_mode='ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'
                   466 Close stmt
                   466 Prepare  select * from `users` where date(`created_at`) = ? order by RAND() limit 1
                   466 Execute  select * from `users` where date(`created_at`) = '2019-09-16' order by RAND() limit 1
                   466 Close stmt

Consider the last line before close. There is a quoted date string.

@SlyDave seems like we can't reproduce this. Feel free to submit a PR with a failing test if you can prove that way that there's a bug.


SPIKE: Investigate kserve monitoring and metrics

As a part of the kserve integration into ODH, we need to look into how monitoring and metrics work in kserve and consider how they will fit into the monitoring story for ODH

[ ] https://github.com/opendatahub-io/kserve/issues/31
[ ] https://github.com/opendatahub-io/kserve/issues/32
[ ] https://github.com/opendatahub-io/caikit/issues/3

Update :

deployed kserve stack according to what will be used in watsonx : https://github.com/Xaenalt/caikit-serving/blob/main/docs/demo/kserve/Kserve.md#kserve-with-caikit--tgis-runtime
Applying the servicemonitors according to the instructions here https://knative.dev/docs/serving/observability/metrics/collecting-metrics/#setting-up-prometheus do not work. The resulting targets in OCP Observe are Down due to connection refused or connection reset by peer

First pass of manual instructions for metrics is done.
This spike needs some extra work according to new requirements to be able to see network metrics

https://github.com/opendatahub-io/odh-model-controller/pull/65
https://github.com/opendatahub-io/caikit-tgis-serving/pull/46
https://github.com/opendatahub-io/odh-manifests/pull/912


Construct sentiment analysis of text data

Create a basic sentiment analyzer and then plot it

unresolved..closing the issue


Use implicit codecov version?

Cookiecutter uses @codecov to check and publish our coverage numbers. Right now we specify the version, which is fine. However, as it is not included in Cookiecutter's requirements, but as part of our test harness, it may be more expedient to define it without a version number. That way the @codecov team (@stevepeak, et al) can make changes to their API and client, and Cookiecutter just keeps moving along.
This means we're doing less maintenance commits (2.0.2 to 2.0.3), but doesn't prevent us from spotting serious problems (like the PyYAML failure on Windows and AppVeyor that @hackebrot identified).
Note: PyYAML failing on @AppVeyor had nothing to do with @AppVeyor, rather it was caused by the somewhat unsupported nature of PyYAML in general).

Thanks @pydanny for brining up this discussion. I'll be happy to answer any questions that come up.
We did just deploy our new release and had couple bugs in the uploader that we solved. We will continue to improve the python uploader and add new features and improvements. Which is an advantage. Clearly the disadvantage is issues like this, though solved within 24 hours like they typically are.
Codecov welcomes all feedback, pull requests and suggestions 👍  Thank you

I'm 👍  on removing versions from all our development dependencies.
I think the value of spotting issues and contributing to upstream bugs/issues outweighs the inconvenience of builds sometimes failing...

I believe almost all of our problems with CI resulted either from GitHub downtimes (caused by DDoS) or YAML. Either of these issues can be identified fairly quickly. 😁
So I'm 👍 on not pinning test requirements.
On a side note: Great work @stevepeak and team! Amazed by how fast you've rolled out a bugfix version after I posted on twitter.


Frozen Deploying contract . . . message for an inactive account

Trying to deploy a contract with an account that had not been transitioned to the 'Active' state prompts an message that does not provide any details.
Possible solution: notify the user of an attempt to deploy from an inactive account.

@bitspresso I tried with the OpenMask inactive account with some balance in it. I was able to deploy the contract and account automatically became active. Could you help me to replicate the issue?


flaky test: ServerThrowsHubExceptionIfHubMethodCannotBeResolved

Failed on our internal CI:
System.TimeoutException : Operation in ServerThrowsHubExceptionIfHubMethodCannotBeResolved timed out at /_/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs:466
   at System.Threading.Tasks.TaskExtensions.<OrTimeout>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.SignalR.Client.FunctionalTests.HubConnectionTests.<ServerThrowsHubExceptionIfHubMethodCannotBeResolved>d__15.MoveNext() in /_/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs:line 474
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.SignalR.Client.FunctionalTests.HubConnectionTests.<ServerThrowsHubExceptionIfHubMethodCannotBeResolved>d__15.MoveNext() in /_/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs:line 478
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
------- Stdout: -------
| [2018-04-09T18:09:22] TestLifetime Information: Starting test ServerThrowsHubExceptionIfHubMethodCannotBeResolved_json_WebSockets_dynamic
| [2018-04-09T18:09:22] Microsoft.AspNetCore.Http.Connections.Client.Internal.WebSocketsTransport Information: Starting transport. Transfer mode: Text. Url: 'ws://<IP_ADDRESS>:53033/dynamic'.
| [2018-04-09T18:09:27] Microsoft.AspNetCore.Http.Connections.Client.HttpConnection Information: HttpConnection Started.
| [2018-04-09T18:09:27] Microsoft.AspNetCore.SignalR.Client.HubConnection Information: Using HubProtocol 'json v1'.
| [2018-04-09T18:09:28] Microsoft.AspNetCore.SignalR.Client.HubConnection Information: HubConnection started.
| [2018-04-09T18:09:27] Microsoft.AspNetCore.SignalR.Client.FunctionalTests.HubConnectionTests Error: System.TimeoutException from test
|    at System.Threading.Tasks.TaskExtensions.<OrTimeout>d__2.MoveNext()
| --- End of stack trace from previous location where exception was thrown ---
|    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
|    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
|    at Microsoft.AspNetCore.SignalR.Client.FunctionalTests.HubConnectionTests.<ServerThrowsHubExceptionIfHubMethodCannotBeResolved>d__15.MoveNext() in /_/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs:line 468
| [2018-04-09T18:09:28] TestLifetime Information: Finished test ServerThrowsHubExceptionIfHubMethodCannotBeResolved_json_WebSockets_dynamic in 6.400074s

Seems to be resolved