Episodes with special characters

This is very much like the closed issue https://github.com/dbr/tvnamer/issues/16 but I have a recent version, 2.3 and upgrading to the latest was the fix for the closed issue.   In my case, a returned episode title has the "é" character in it - which causes the script to fail.
The command is run through a script and tvnamer is launched as follows:
/usr/local/bin/tvnamer -b -m --force-move -d "/home/sean/video/TV/%(seriesname)s/Season %(seasonnumber)d" "Another Period S03E02.mp4" 2>&1 | tee -a "/tmp/Another Period S03E02.log"

####################
# Starting tvnamer
# Found 1 episode
####################
# Processing file: Another Period S03E02.mp4
# Detected series: Another Period (season: 3, episode: 2)
####################
Old filename: Another Period S03E02.mp4
New filename: Another Period - [03x02] - Séance.mp4
New path: /home/sean/temp/daaef588/Another Period - [03x02] - Séance.mp4
Traceback (most recent call last):
  File "/usr/local/bin/tvnamer", line 9, in <module>
    load_entry_point('tvnamer==2.3', 'console_scripts', 'tvnamer')()
  File "build/bdist.linux-x86_64/egg/tvnamer/main.py", line 458, in main
  File "build/bdist.linux-x86_64/egg/tvnamer/main.py", line 364, in tvnamer
  File "build/bdist.linux-x86_64/egg/tvnamer/main.py", line 227, in processFile
  File "build/bdist.linux-x86_64/egg/tvnamer/main.py", line 92, in doRenameFile
  File "build/bdist.linux-x86_64/egg/tvnamer/utils.py", line 1088, in newPath
  File "/usr/lib/python2.7/genericpath.py", line 37, in isfile
    st = os.stat(path)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 53: ordinal not in range(128)

The tvnamer command line in the script works flawlessly except for this one episode so far.
Please let me know if you need any more info...

I ran into this same issue. I managed to workaround it by editing the following line in my config file:
    "normalize_unicode_filenames": true,

This does a simple convert from é to e.
While I would prefer to have the unicode characters in my filenames, this was an acceptable workaround for me.

Hmm, could you test with the latest version 2.5 release? Don't recall if there was anything to do with the non-ASCII support changed since 2.3, but latest version appears to work for me, under both Python 2.7 and 3.7:
$ touch 'Another Period S03E02.mp4'
$ tvnamer Another\ Period\ S03E02.mp4
####################
# Starting tvnamer
# Found 1 episode
####################
# Processing file: Another Period S03E02.mp4
# Detected series: Another Period (season: 3, episode: 2)
TVDB Search Results:
1 -> Another Period [en] # http://thetvdb.com/?tab=series&id=284219&lid=7 (default)
Automatically selecting only result
####################
Old filename: Another Period S03E02.mp4
New filename: Another Period - [03x02] - Séance.mp4
Rename?
([y]/n/a/q)
Renaming
New path: /Users/dbr/code/tvnamer/Another Period - [03x02] - Séance.mp4
rename /Users/dbr/code/tvnamer/Another Period S03E02.mp4 to /Users/dbr/code/tvnamer/Another Period - [03x02] - Séance.mp4

I've also noticed this issue with names with an apostrophe ' in it.  Example is Tom Clancy's Jack Ryan which tvnamer fails to find on tvdb and when you force it with the --series-id= flag, it names it "Tom Clancy's Jack Ryan

I noticed a similar issue with '.'
Example: Magnum P. I. was failed to be identified. It searched for Magnum P I and didn't find any results for some reason. Works fine if I force the series name

Closing old ticket, don't think the encoding issue should still be a problem (especially in latest v4.0-dev under Python 3 as none of the ASCII string code will exist any more)

Example: Magnum P. I. was failed to be identified. It searched for Magnum P I and didn't find any results for some reason. Works fine if I force the series name

This is a different issue - not sure if it's improved in the last year or so, but the TVDB API search is fairly basic, and can be confused by differing punctuation (or even things like & versus and). Not much tvnamer can do to work around this as a fix which might work for one show may break another


Update docs about schema.(:types)

Since this commit, __schema__(:types) in Ecto.Schema returns a map.

Thank you! :heart:
I missed the docs when I changed that.


fix: tree view in main page with expando

:tada: This PR is included in version 0.318.9 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(apps/prod/goproxy): deploy goproxy

deploy goproxy on prod env

/hold I will review it deep later

/unhold
/lgtm

/approve


CSV Export - Commas not Escaped

From https://github.com/ucam-cl-dtg/rutherford-content/issues/435

Commas in question titles are a problem when the assignment progress is downloaded as a csv file. Can the comma in titles be ignored? sorry, I don't have an example as I removed the commas from the question that was causing problems.

I don't think this will affect may questions, but could do with fixing.

Fixed in https://github.com/ucam-cl-dtg/isaac-api/commit/978b4c3ae14dc6330debe31f739d9ae70b4fb063


Add unit tests for TO_BOOL() and unary not with a whole document

Did not test it yet

It's green, so I merged it.
FYI: if you create feature branches for PRs like these you work on more than one PR at a time. Sorry about deleting your devel branch temporarily :fearful: :wink:

I know. I don't use the devel branch in my fork anyway.


Choice of technology

This is fairly self-explanatory.
Specifically, decisions need to be made on:

Language choice
CLI input parser
CLI UI renderer
Should YAML be the format-of-choice for representing a "view"
???

I'm personally leaning towards Python.It's a fun language and I'm quite keen to play with Rich. I haven't built many CLI tools in Python, but I suppose Click is the go-to for command parsing?

Perhaps NodeJS would be a better choice due to ink. It seems like a better alternative to Rich?
Some other useful tech build in Node:

oclif
commander


cli: program: Extract auto_extend logic into a function

do_process_program_upgrade() is already huge.  It is better to put sufficiently self-contained chunks of logic into individual functions.
Also, restructured the "staircase" pattern using early exits.  It seems to be more readable this way.

CI test failure seems consistent

CI test failure seems consistent

Sorry about that, fixed now.

Codecov Report
Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 82.1%. Comparing base (57f92b7) to head (96cf6a3).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1164   +/-   ##
=======================================
  Coverage    82.1%    82.1%
=======================================
  Files         886      886
  Lines      236394   236381   -13
=======================================
+ Hits       194205   194206    +1
+ Misses      42189    42175   -14

In future, please use separate commits for diffs that move code, and diffs that change that code (including renaming variables). Makes review a lot easier 😅

Thanks for letting me know.  I will try to.
The process that produced this PR was not exactly as straightforward...
And I already spend quite a lot of time rewriting the change history :)

I noticed that the error message was not completely accurate, as it did not account for the header size, when computing the maximum program size.
While it probably does not matter in practice, I think, it makes the code a bit more accurate overall.


Using .local domains inside containers

Discussed in https://github.com/orgs/orbstack/discussions/841

Originally posted by friartuck6000 December  1, 2023
Let's say I have two Docker Compose projects turtles and ducks, and each is running a webserver — their OrbStack domains are:

web.turtles.orb.local
web.ducks.orb.local

The ducks project has another service that is trying to make API requests to turtles's webserver. Is there any way to leverage OrbStack's domain resolution within that container, so it can resolve requests to web.turtles.orb.local? Or would my only option be placing the two on a shared network and manually mapping the domain to the target container's IP with extra_hosts?
cc @friartuck6000

Duplicate of #762


docs: rename Actual True Range to Average True Range

As described in #359, I think the indicator name is slightly wrong in the docs, but correct in the code itself.
This adjusts the docs accordingly.
Closes #359
Describe Request
Please describe your request.
Fixed # (issue)
Change Type
What is the type of this change.

Codecov Report

Merging #360 (04847f7) into main (306893d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   64.64%   64.64%
=======================================
  Files          93       93
  Lines        1533     1533
  Branches      183      183
=======================================
  Hits          991      991
  Misses        529      529
  Partials       13       13

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thank you very much! Good catch! One minor comment, if you can make that quick change, I'll merge this right after. Many thanks!

One minor comment, if you can make that quick change

I just got around to checking this PR on my laptop, I thought I'd just not see the comment on my phone. But… I can't see any comment 😄  Can you check again if you have sent it?

It is actually at the top, let me copy it here:
In src/indicator/volatility/index.md could you also update the link target to also point at the right section?
- [Actual True Range (ATR)](#actual-true-range-atr)
- [Average True Range (ATR)](#actual-true-range-atr)

Not a big deal, I can also fix it after merging, but just wanted to check if you make that quick change and then I can merge?

Yes sure, I’ll check tomorrow and update that part.

Done :)


Reconnect websocket on random connection failures

It's really common for websockets to drop the connection specially after long sessions, we should port over hyperion-history-api's reconnect machinery https://github.com/eosrio/hyperion-history-api/blob/v3.3.7/connections/state-history.ts

This was already addressed in #4 and #6 but JT just reported this new one:
[READER] 2 block/s | Blocks: 0 (0.0%) | Actions: 0 | Deltas: 0
2023-11-16T14:07:08.625Z [PID:523520] [info] : 310360890 pushed, at 2 blocks/sec
2023-11-16T14:07:08.828Z [PID:523520] [info] : drained 2 operations.
2023-11-16T14:07:08.828Z [PID:523520] [info] : broadcasting 1 blocks...
2023-11-16T14:07:08.828Z [PID:523520] [info] : done.
2023-11-16T14:07:09.326Z [PID:523520] [info] : drained 2 operations.
2023-11-16T14:07:09.326Z [PID:523520] [info] : broadcasting 1 blocks...
2023-11-16T14:07:09.327Z [PID:523520] [info] : done.
2023-11-16T14:07:09.625Z [PID:523520] [info] : 310360892 pushed, at 2 blocks/sec
2023-11-16T14:07:09.827Z [PID:523520] [info] : drained 2 operations.
2023-11-16T14:07:09.827Z [PID:523520] [info] : broadcasting 1 blocks...
2023-11-16T14:07:09.827Z [PID:523520] [info] : done.
2023-11-16T14:07:10.324Z [PID:523520] [info] : drained 2 operations.
2023-11-16T14:07:10.324Z [PID:523520] [info] : broadcasting 1 blocks...
2023-11-16T14:07:10.324Z [PID:523520] [info] : done.
[READER] 2 block/s | Blocks: 0 (0.0%) | Actions: 0 | Deltas: 0
2023-11-16T14:07:10.625Z [PID:523520] [info] : 310360894 pushed, at 2 blocks/sec
2023-11-16T14:07:10.825Z [PID:523520] [info] : drained 2 operations.
2023-11-16T14:07:10.825Z [PID:523520] [info] : broadcasting 1 blocks...
2023-11-16T14:07:10.825Z [PID:523520] [info] : done.
2023-11-16T14:07:11.122Z [PID:523520] [info] : drained 2 operations.
2023-11-16T14:07:11.122Z [PID:523520] [info] : broadcasting 1 blocks...
2023-11-16T14:07:11.122Z [PID:523520] [info] : done.
2023-11-16T14:07:11.625Z [PID:523520] [info] : 310360896 pushed, at 2 blocks/sec
2023-11-16T14:07:11.791Z [PID:523520] [info] : drained 2 operations.
2023-11-16T14:07:11.791Z [PID:523520] [info] : broadcasting 1 blocks...
2023-11-16T14:07:11.791Z [PID:523520] [info] : done.
[READER] 1.5 block/s | Blocks: 0 (0.0%) | Actions: 0 | Deltas: 0
2023-11-16T14:07:12.625Z [PID:523520] [info] : 310360897 pushed, at 1 blocks/sec
2023-11-16T14:07:13.626Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:14.626Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:15.626Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:16.626Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:17.626Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:18.626Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:19.627Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:20.627Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:21.627Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:22.627Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:23.627Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:24.628Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:25.628Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:26.628Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:27.628Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:28.629Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:29.629Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:30.629Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:31.629Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:32.629Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:33.629Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:34.629Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:35.630Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:36.631Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:37.632Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:38.633Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:39.633Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:40.633Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:41.633Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:42.633Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:43.633Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:44.633Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:45.634Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:46.634Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:47.634Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:48.635Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:49.635Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:50.636Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:51.636Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:52.638Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:53.638Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:54.639Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:55.639Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:56.639Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:57.640Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:58.641Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:07:59.641Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:00.642Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:01.642Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:02.642Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:03.642Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:04.643Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:05.644Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:06.644Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:07.644Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:08.644Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:09.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:10.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:11.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:12.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:13.645Z [PID:523520] [info] : stall detected... restarting ship reader.
2023-11-16T14:08:13.645Z [PID:523520] [warn] : restarting SHIP reader!...
2023-11-16T14:08:13.646Z [PID:523520] [warn] : reader stopped, waiting 2 seconds to restart.
2023-11-16T14:08:13.646Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:13.647Z [PID:523520] [warn] : SHIP Reader disconnected.
2023-11-16T14:08:14.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:15.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
[READER] Restarting...
2023-11-16T14:08:16.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:17.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:18.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
[READER] Connecting to ws://<IP_ADDRESS>:19000...
Connecting to ws://<IP_ADDRESS>:19000...
2023-11-16T14:08:18.650Z [PID:523520] [info] : SHIP Reader connected.
[READER] Head block: 310361029
[READER] Requesting blocks from 309853135 to<PHONE_NUMBER>
2023-11-16T14:08:19.644Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:20.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
[READER] Connecting to ws://<IP_ADDRESS>:19000...
Connecting to ws://<IP_ADDRESS>:19000...
2023-11-16T14:08:20.652Z [PID:523520] [info] : SHIP Reader connected.
DecodingError: Unknown variant idx: 123
    at decodeInner (/home/jbuice/telosevm-translator-mainnet/node_modules/@greymass/eosio/src/serializer/decoder.ts:215:27)
    at decodeBinary (/home/jbuice/telosevm-translator-mainnet/node_modules/@greymass/eosio/src/serializer/decoder.ts:181:16)
    at Object.abiDecode [as decode] (/home/jbuice/telosevm-translator-mainnet/node_modules/@greymass/eosio/src/serializer/decoder.ts:131:20)
    at HyperionSequentialReader.handleShipMessage (file:///home/jbuice/telosevm-translator-mainnet/node_modules/@eosrio/hyperion-sequential-reader/lib/esm/reader.js:184:35)
    at file:///home/jbuice/telosevm-translator-mainnet/node_modules/@eosrio/hyperion-sequential-reader/lib/esm/reader.js:140:18
    at WebSocket.<anonymous> (file:///home/jbuice/telosevm-translator-mainnet/node_modules/@eosrio/hyperion-sequential-reader/lib/esm/state-history.js:27:41)
    at WebSocket.emit (node:events:514:28)
    at Receiver.receiverOnMessage (/home/jbuice/telosevm-translator-mainnet/node_modules/@eosrio/hyperion-sequential-reader/node_modules/ws/lib/websocket.js:1192:20)
    at Receiver.emit (node:events:514:28)
    at Receiver.dataMessage (/home/jbuice/telosevm-translator-mainnet/node_modules/@eosrio/hyperion-sequential-reader/node_modules/ws/lib/receiver.js:560:14) {
  ctx: {
    types: {
      bool: [Object],
      string: [Object],
      asset: [Function],
      symbol: [Function],
      symbol_code: [Function],
      block_timestamp_type: [Function],
      bytes: [Function],
      checksum160: [Function],
      checksum256: [Function],
      checksum512: [Function],
      extended_asset: [Function],
      float128: [Function],
      float32: [Function],
      float64: [Function],
      int128: [Function],
      int16: [Function],
      int32: [Function],
      int64: [Function],
      int8: [Function],
      name: [Function],
      public_key: [Function],
      signature: [Function],
      time_point: [Function],
      time_point_sec: [Function],
      uint128: [Function],
      uint16: [Function],
      uint32: [Function],
      uint64: [Function],
      uint8: [Function],
      varint32: [Function],
      varuint32: [Function]
    },
    strictExtensions: false,
    codingPath: [ [Object] ]
  },
  underlyingError: Error: Unknown variant idx: 123
      at decodeInner (/home/jbuice/telosevm-translator-mainnet/node_modules/@greymass/eosio/src/serializer/decoder.ts:215:27)
      at decodeBinary (/home/jbuice/telosevm-translator-mainnet/node_modules/@greymass/eosio/src/serializer/decoder.ts:181:16)
      at Object.abiDecode [as decode] (/home/jbuice/telosevm-translator-mainnet/node_modules/@greymass/eosio/src/serializer/decoder.ts:131:20)
      at HyperionSequentialReader.handleShipMessage (file:///home/jbuice/telosevm-translator-mainnet/node_modules/@eosrio/hyperion-sequential-reader/lib/esm/reader.js:184:35)
      at file:///home/jbuice/telosevm-translator-mainnet/node_modules/@eosrio/hyperion-sequential-reader/lib/esm/reader.js:140:18
      at WebSocket.<anonymous> (file:///home/jbuice/telosevm-translator-mainnet/node_modules/@eosrio/hyperion-sequential-reader/lib/esm/state-history.js:27:41)
      at WebSocket.emit (node:events:514:28)
      at Receiver.receiverOnMessage (/home/jbuice/telosevm-translator-mainnet/node_modules/@eosrio/hyperion-sequential-reader/node_modules/ws/lib/websocket.js:1192:20)
      at Receiver.emit (node:events:514:28)
      at Receiver.dataMessage (/home/jbuice/telosevm-translator-mainnet/node_modules/@eosrio/hyperion-sequential-reader/node_modules/ws/lib/receiver.js:560:14)
}
2023-11-16T14:08:21.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:22.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:23.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:24.645Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec
2023-11-16T14:08:25.646Z [PID:523520] [info] : 310360897 pushed, at 0 blocks/sec

https://pastebin.com/j9Xu6KzU


dylib error on Big Sur with UE4

Engine version 4.22.3
Macos Big Sur,
error:
/System/Library/PrivateFrameworks/MultitouchSupport.framework/Versions/Current/MultitouchSupport no paths with that name

This has nothing to do with discord?

This has nothing to do with discord?

Sorry I don't think I was being specific enough. The issue is upon using the RPC, it'll say "following assets are missing or built with a different version of the engine", then when you click ok, it'll build, until it crashes. That is the last line of the log before the build crashes
"/System/Library/PrivateFrameworks/MultitouchSupport.framework/Versions/Current/MultitouchSupport no paths with that name"

Sorry I don't think I was being specific enough. The issue is upon using the RPC, it'll say "following assets are missing or built with a different version of the engine", then when you click ok, it'll build, until it crashes. That is the last line of the log before the build crashes
"/System/Library/PrivateFrameworks/MultitouchSupport.framework/Versions/Current/MultitouchSupport no paths with that name"

@Lachee I downgraded to macOS Catalina today, worked like a charm, however there is another issue. Everything works in the game editor, however when I package it, it gives me this error.
  Referenced from: /Users/mootbing/Desktop/Unreal_Completed/MacNoEditor/SubwayChaos.app/Contents/MacOS/SubwayChaos
  Reason: image not found
zsh: abort```

@Lachee I downgraded to macOS Catalina today, worked like a charm, however there is another issue. Everything works in the game editor, however when I package it, it gives me this error.
  Referenced from: /Users/mootbing/Desktop/Unreal_Completed/MacNoEditor/SubwayChaos.app/Contents/MacOS/SubwayChaos
  Reason: image not found
zsh: abort```


Master should dispatch the configuration files to all worker when Mount command and worker register

Is your feature request related to a problem? Please describe.
Now, we can mount a ufs to alluxio easily by execute a simple command line, for example
./bin/alluxio fs mount \
  --option alluxio.underfs.hdfs.configuration=<DIR>/ozone-site.xml:<DIR>/core-site.xml \
  /ozone o3fs://<OZONE_BUCKET>.<OZONE_VOLUME>/

But we have to dispatch the config files to all of the workers manually, that is Inefficient and error-prone.
Describe the solution you'd like
Alluxio master can maintain mount table now, so it can maintain the configuration files related each mount point by the way, workers should ask for mount point configuration files update when heartbeat if needed.
Describe alternatives you've considered
Modify the worker module code, when worker need access ufs and found configuration file does not exist, just ask master to request the lost configuration file. During each heartbeat, worker can send its configuration files fingerprint to master to check if the files updated from master.
Urgency
LOW
Additional context
Improve user interface feelin.

Sounds a good feature to have. Assign it to you for now and let me know if you have plan to implement it


Types not being included when using modules linked using npm link

TypeScript Version:  3.7.0-dev.20190917

Search Terms: linked npm module
Code
This is a build problem, not a code problem. Let me know if this issue should be moved to ts-loader or something like that!
The problem can be reproduced here: https://github.com/callumacrae/typescript-bug
It seems to lie in the tsconfig.json, where in the include I am trying to include the typings from generic-minimal, a repository that will contain (untranspiled) code and modules common between my projects.
Direct link to tsconfig.json: https://github.com/callumacrae/typescript-bug/blob/master/tsconfig.json#L31
When generic-minimal is installed through npm install, this works fine. When it is symlinked in using npm link, I get a type error caused by the vue-meta types not being brought in—and vue-meta is installed in the parent repository, not in generic-minimal. I don't see how the two things should have any effect on each other at all.
I might have got what exactly is causing this issue slightly incorrect but I have been on this since Friday now and this is as small a repro as I've managed to come up with :(
Expected behavior:
Actual behavior:
see above
Related Issues:
This issue seems to be related to https://github.com/microsoft/TypeScript/issues/31527, although it isn't the same issue.

We're not able to investigate repros that rely on third-party build tools like vue-cli-service build. If you can reproduce the problem with tsc or something directly equivalent, we can take a look.
Also, please provide direct commands to run in your instructions; it is unnerving for us to execute npm run build from an arbitrary repo without knowing what's happening under the covers, so we have to check what's in package.json anyway.

Alright, will try to replicate with tsc :)


Integration cli c assert updates

update my branch to test the integration-cli cAssert changes i will be adding

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "integration-cli-cAssert-updates" git@github.com:zelahi/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~6
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.


Security - Permission operation 'Read' against the resource: database.cluster.*

Target: Delete edge as a restricted user
A user gets a role via an edge. User created the edge himself which works without issues. Delete of the edge fails.
Expected result
The edge should get deleted, should not give error and confirm it has been deleted.
ALSO: If I would not have permissions on a specific resource (I might have configured it wrong) then I would not expect a general database.cluster.* error but something like: database.cluster.hasrole DELETE not allowed.
SQL command
DELETE EDGE FROM #5:3 TO #17:5

also tested with same negative result:
DELETE EDGE HasRole FROM #5:3 TO #17:5

Query validated and works when sent in as admin via web tool.
Error:
Orient returned exception: 401 - com.orientechnologies.orient.core.exception.OSecurityAccessException: User 'xxxxxxxxxx' has no the permission to execute the operation 'Read' against the resource: database.cluster.*

Rights in role setup (slimmed down)
{
    "database": 2,
    "database.schema": 2,
    "database.cluster.internal": 2,
    "database.class.ouser": 15,
    "database.cluster.ouser": 15,
    "database.command": 15,
    "database.hook.record": 15,
    "database.cluster.myrole": 7,
    "database.class.myrole": 7,
    "database.cluster.hasrole": 15,
    "database.class.hasrole": 15,
}

Also tested with same negative result:
"database.cluster.myrole": 15,
"database.class.myrole": 15,

Rights setup target I have
User is allowed to create and delete edges between them.
User is not allowed to delete myrole.
User should be allowed to edit only it's own user. (not implemented yet, gave 15 on ouser as test).
User should not be able to read all data off course. So I did not give: cluster.* read access.

Cannot reproduce it.


HDFS-17544. [ARR] The router client rpc protocol PB supports asynchrony.

Description of PR
Please see :  https://issues.apache.org/jira/browse/HDFS-17544
NOTE:
This is a sub-pull request (PR) related to HDFS-17531(Asynchronous router RPC). For more details or context, please refer to the main issue HDFS-17531
More detailed documentation: HDFS-17531 Router asynchronous rpc implementation.pdf and Aynchronous router.pdf
How was this patch tested?
new UTs:
1.TestAsyncRpcProtocolPBUtil
2.TestRouterClientSideTranslatorPB
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@KeeProMise Hi, sir. The code in this PR contains HDFS-17543's change.  Can we seperate them for better reviewing.

@KeeProMise Hi, sir. The code in this PR contains HDFS-17543's change. Can we seperate them for better reviewing.

@hfutatzhanghb Hi, It does include HDFS-17543. The main reason is that this PR needs to use AsyncUtil of HDFS-17543. We should first review and merge HDFS-17543 and then review this PR. Before HDFS-17543 is merged, this PR is only used as an example of subsequent use of AsyncUtil.

@goiri @simbadzina @Hexiaoqiao @sjlee @ayushtkn
Hi, if you have time, please help to take a look at this PR, thanks!

Modifications related to ipc.client, please see to HDFS-17552.https://github.com/apache/hadoop/pull/6888

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 20s

https://github.com/apache/hadoop/pull/6870 does not apply to HDFS-17531. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6870

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6870/13/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ HDFS-17531 Compile Tests _

+0 :ok:
mvndep
13m 59s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 41s

HDFS-17531 passed

+1 :green_heart:
compile
2m 55s

HDFS-17531 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
2m 49s

HDFS-17531 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 44s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 56s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 56s

HDFS-17531 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 50s

HDFS-17531 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 12s

HDFS-17531 passed

+1 :green_heart:
shadedclient
20m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 47s

the patch passed

+1 :green_heart:
compile
2m 49s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
2m 49s

the patch passed

+1 :green_heart:
compile
2m 41s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
2m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 36s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 2 new + 22 unchanged - 1 fixed = 24 total (was 23)

+1 :green_heart:
mvnsite
0m 48s

the patch passed

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 13s

the patch passed

+1 :green_heart:
shadedclient
20m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 44s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
27m 23s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

135m 25s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

hadoop.hdfs.server.federation.router.TestRouterRpc

hadoop.hdfs.server.federation.router.TestRouterMultiRack

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6870/16/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6870

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux aff8b889771a 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / c311ab602a44936d5ed9f7efdf5c5bc8e65aeb88

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6870/16/testReport/

Max. process+thread count
3709 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6870/16/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ HDFS-17531 Compile Tests _

+0 :ok:
mvndep
14m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 11s

HDFS-17531 passed

+1 :green_heart:
compile
2m 50s

HDFS-17531 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
2m 46s

HDFS-17531 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 44s

HDFS-17531 passed

+1 :green_heart:
mvnsite
1m  2s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 54s

HDFS-17531 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 48s

HDFS-17531 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 10s

HDFS-17531 passed

+1 :green_heart:
shadedclient
20m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 50s

the patch passed

+1 :green_heart:
compile
2m 50s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
2m 50s

the patch passed

+1 :green_heart:
compile
2m 39s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
2m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 37s

hadoop-hdfs-project: The patch generated 0 new + 22 unchanged - 1 fixed = 22 total (was 23)

+1 :green_heart:
mvnsite
0m 51s

the patch passed

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 15s

the patch passed

+1 :green_heart:
shadedclient
20m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 45s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
26m 56s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

128m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6870/17/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6870

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fe27c75d2ac5 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / 21a1b1acfb2ef00ded98839bea0bcac3d44f7497

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6870/17/testReport/

Max. process+thread count
3684 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6870/17/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri @simbadzina @Hexiaoqiao @sjlee @ayushtkn
Hi, if you have time, please help to take a look at this PR, thanks!

LGTM

Hi, if no comments here, please help to merge it, thanks!

Committed to HDFS-17531, Thanks @KeeProMise !

Committed to HDFS-17531, Thanks @KeeProMise !

@Hexiaoqiao Thank you for your review and merge!


⚠ Bofrost.at has degraded performance

In 28ee32c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1436 ms

Resolved: Bofrost.at performance has improved in 52b7219.


pkg/shelf: implement body parsing similar to http_server package

This issue was originally filed by @Andersmholmgren

Shelf currently only exposes the body as a string or byte stream.
http_server provided a sophisticated parser of the body in relation to the request headers content type.
A similar function is sorely missing from shelf

This issue has been moved to dart-lang/shelf#34.


No SLF4J providers were found.

zipkin 실행 시

  # SLF4J(W):
  # SLF4J(W): Defaulting to no-operation (NOP) logger implementation
  # SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
  # SLF4J(W): Class path contains SLF4J bindings targeting slf4j-api versions 1.7.x or earlier.
  # SLF4J(W): Ignoring binding found at [jar:nested:/C:/Users/pooh1/zipkin.jar/!BOOT-INF/lib/log4j-slf4j-impl-2.21.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
  # SLF4J(W): See https://www.slf4j.org/codes.html#ignoredBindings for an explanation.

slf4j 버전문제인거 같은데 classpath 어디 파일을 대체해 줘야할지 모르겠다...?

Class path contains SLF4J bindings targeting slf4j-api versions 1.7.x or earlier
Planning for the advent of Jigsaw (Java 9), slf4j-api version 2.0.x and later use the ServiceLoader mechanism. Earlier versions of SLF4J relied on the static binder mechanism which is no longer honored by slf4j-api version 2.0.x.
In case SLF4J finds no providers targeting SLF4J 2.0.x but finds instead bindings targeting SLF4J 1.7 or earlier, it will list the bindings it finds but otherwise will ignore them.
This can be solved by placing an SLF4J provider on your classpath, such providers include logback version 1.3.x and later, as well as one of slf4j-reload4j, slf4j-jdk14, slf4j-simple version 2.0.0 or later.
See also the FAQ entry What has changed in SLF4J version 2.0.0? for further important details.

https://www.slf4j.org/codes.html#ignoredBindings

apach lib 에 있는 버전

maven-slf4j-provider-3.8.8
slf4j-api-1.7.36

https://www.slf4j.org/faq.html#changesInVersion200
https://repo1.maven.org/maven2/org/slf4j/
여기서 2.0.x 버전 api, simple 둘다 받아서 넣어봤는데 안됨...!!

도커에서 실행할때도 똑같은 문제 발생!


TextService.FilterStringAsync wrong undefined return type

API Reference (https://developer.roblox.com/en-us/api-reference/function/TextService/FilterStringAsync) says that TextService.FilterStringAsync returns a TextFilterResult (and not nil), but the return type here is TextFilterResult | undefined.

For reference, custom definition was first added in https://github.com/roblox-ts/types/commit/a3aa48d156a520d4d6c92dc2a92e7492d8aa15ed with no further type changes after that.

Actually it was https://github.com/roblox-ts/types/commit/7003fdd9ae90efc9236aeeacfac7393ff5db632f

Looks like I changed it by mistake? The documentation from 2019 is pretty much the same as it is today. I'm surprised no one noticed in 3 years.  I wonder if anyone wrote a check in their code to make sure the return result is defined because of these types, or would they just have used type assertions?

I wonder if anyone wrote a check in their code to make sure the return result is defined because of these types, or would they just have used type assertions?

Considering this is an HTTP request and a critical part of user safety, I would say this is a good thing and have just kept the type with undefined, considering, as you say, no one ran into it for 3 years. Sometimes an overly restrictive type can be good for code style.

Well, if it's impossible for the API to return nil, there isn't any point to checking it. I don't see how it could be beneficial to write extra code and take up mental resources to deal with a situation that could never happen. I went ahead and changed it back to being always defined.


Nostr Wallet Connect support

https://github.com/nostr-protocol/nips/blob/master/47.md
There is a PR to the rust-nostr library for adding better support. Once that is released we can clean up this code a lot.

Put in a loop and added support for stop


Meeting Live Code Interview 2nd PR For Nodejs Sample Toolkit Fixes

Issue Link : https://github.com/OfficeDev/Microsoft-Teams-Samples/issues/1105
Sample Fixed and Running Screenshots
Configurable Tab

Side Panel with Share to Stage view

Build status - All builds passed
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/7499582102


DeploySPList [BUG]: not all lists are being propagated correctly

**when running the imported SPDeploylist flow on a Dutch freshly created teamsite in Dutch language (o365 online) the flow does not create all lists. Lists CI_configAdminSetup and CI_LogosAssets are created correctly, however It fails at Scope Contact list
"with error in header: I could not get the addContentType to work. So we may have to do the columns manually._api/web/lists/getByTitle('List%20Name')/contenttypes/AddAvailableContentType("0x0106") all following lists are also not being propagated to SP **
To Reproduce
I ran test in power automate with the same result, started a new flow with same result...
Steps to reproduce the behavior:
Expected behavior
I would like to see that all neccasarry lists are being propagated the way the video and documentation shows,  or I suggest to hand out a document where you explain how to manually setup the neccesarry coloms and variables. this is not for the faint of heart I believe 👎
Screenshots
If applicable, add screenshots to help explain your problem.

Interface(please complete the following information):

Browser  EDGE Versie
Version date 80.0.361.109 (Officiële build) (64-bits)

Did not test smartphone jet :(
Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Solved the issue , created the teamsite in English. have to look into the depenencies when calling the API differences I Guess


Add warning if element passed to PianoRollSVGVisualizer isn't svg #281

Please let me know if this isn't the correct way to do it - I'm still learning typescript.

I signed it


[CI] [Chore] Increase browser container timeout

Purpose of the pull request
https://github.com/apache/dolphinscheduler/actions/runs/5609218597/jobs/10263005834?pr=14604

Codecov Report

Merging #14608 (5870480) into dev (1d0d85b) will increase coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 5870480 differs from pull request most recent head af24826. Consider uploading reports for the commit af24826 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14608      +/-   ##
============================================
+ Coverage     38.51%   38.52%   +0.01%
+ Complexity     4562     4561       -1
============================================
  Files          1260     1260
  Lines         43791    43746      -45
  Branches       4829     4800      -29
============================================
- Hits          16864    16853      -11
+ Misses        25054    25022      -32
+ Partials       1873     1871       -2

see 31 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


DropdownButton seems buggy when centered at bottom of screen, and isDense = true

Tapping on a dropdown that has isDense set to True when its centered at the bottom center of the screen throws errors.  If you don't center the DroppdownButton, you don't get the error.  Also works OK as long as isDense is false.
Steps to Reproduce

Execute flutter run on the code sample <!-- (see "Code sample" section below)
Tap on the dropdown, and note flutter throws exceptions when the dropdown opens

Expected results: dropdown should open upwards to display the items w/o throwing errors
Actual results: Flutter throws exceptions, and dropdown opens up in upper LH corner of the screen

Code sample
import 'package:flutter/material.dart';

class SecondScreen extends StatelessWidget {
  const SecondScreen({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    String dropdownValue = 'Choose view...';

    return Scaffold(
      resizeToAvoidBottomInset: false,
      appBar: AppBar(
        title: const Text('Second Route'),
        toolbarHeight: kToolbarHeight / 1.5,
      ),
      body: Column(
        mainAxisAlignment: MainAxisAlignment.end,
        children: [

          Align(
            alignment: Alignment.center,
            child: DropdownButton<String>(
            value: dropdownValue,
// set isDense to false to make error go away
            isDense: true,    // doesn't seem to work when at bottom of screen
            dropdownColor: Colors.greenAccent,
            icon: const Icon(Icons.keyboard_arrow_down),
            onChanged: (String? newValue) {
              print('Val: $newValue');
            },
            items: <String>['Choose view...', 'Two this is a test of it', 'Zulu', 'Four']
                .map<DropdownMenuItem<String>>((String value) {
              return DropdownMenuItem<String>(
                value: value,
                child: Text(value),
              );
            }
            ).toList(),
          ),
          //   ),

          )
        ],
      ),
    );
  }
}

Logs

The following assertion was thrown during performLayout():
'package:flutter/src/material/dropdown.dart': Failed assertion: line 363 pos 16: 'menuLimits.top + menuLimits.height <= size.height': is not true.

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.md

The relevant error-causing widget was:
  Scaffold Scaffold:file:///C:/Users/User/AndroidStudioProjects/FlutterProjects/startup_namer/lib/main.dart:70:19
When the exception was thrown, this was the stack:
#2      _DropdownMenuRouteLayout.getPositionForChild.<anonymous closure> (package:flutter/src/material/dropdown.dart:363:16)
#3      _DropdownMenuRouteLayout.getPositionForChild (package:flutter/src/material/dropdown.dart:366:6)
#4      RenderCustomSingleChildLayoutBox.performLayout (package:flutter/src/rendering/shifted_box.dart:1363:41)
#5      RenderObject.layout (package:flutter/src/rendering/object.dart:1915:7)
#6      _RenderLayoutBuilder.performLayout (package:flutter/src/widgets/layout_builder.dart:318:14)
#7      RenderObject.layout (package:flutter/src/rendering/object.dart:1915:7)
#8      RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#9      RenderObject.layout (package:flutter/src/rendering/object.dart:1915:7)
#10     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#11     RenderObject.layout (package:flutter/src/rendering/object.dart:1915:7)
#12     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#13     RenderObject.layout (package:flutter/src/rendering/object.dart:1915:7)
#14     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#15     RenderObject.layout (package:flutter/src/rendering/object.dart:1915:7)
#16     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#17     RenderObject.layout (package:flutter/src/rendering/object.dart:1915:7)
#18     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#19     RenderOffstage.performLayout (package:flutter/src/rendering/proxy_box.dart:3462:13)
#20     RenderObject.layout (package:flutter/src/rendering/object.dart:1915:7)
#21     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:116:14)
#22     RenderObject.layout (package:flutter/src/rendering/object.dart:1915:7)
#23     _RenderTheatre.performLayout (package:flutter/src/widgets/overlay.dart:749:15)
#24     RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1757:7)
#25     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:887:18)
#26     RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:504:19)
#27     WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:892:13)
#28     RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:370:5)
#29     SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1146:15)
#30     SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1083:9)
#31     SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:997:5)
#35     _invoke (dart:ui/hooks.dart:151:10)
#36     PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:308:5)
#37     _drawFrame (dart:ui/hooks.dart:115:31)
(elided 5 frames from class _AssertionError and dart:async)
The following RenderObject was being processed when the exception was fired: RenderCustomSingleChildLayoutBox#6705b NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
...  parentData: offset=Offset(0.0, 0.0) (can use size)
...  constraints: BoxConstraints(w=480.0, h=642.4)
...  size: Size(480.0, 642.4)
RenderObject: RenderCustomSingleChildLayoutBox#6705b NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
  parentData: offset=Offset(0.0, 0.0) (can use size)
  constraints: BoxConstraints(w=480.0, h=642.4)
  size: Size(480.0, 642.4)
...  child: RenderAnimatedOpacity#58a16 relayoutBoundary=up1 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
...    parentData: offset=Offset(0.0, 0.0) (can use size)
...    constraints: BoxConstraints(w=252.0, 0.0<=h<=546.4)
...    size: Size(252.0, 208.0)
...    opacity: AnimationController#1e5f9(▶ 0.000; for _DropdownRoute<String>)➩ProxyAnimation➩Interval(0.0⋯0.25)ₒₙ/Interval(0.75⋯1.0)
...    child: RenderCustomPaint#a0fec relayoutBoundary=up2 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
...      parentData: <none> (can use size)
...      constraints: BoxConstraints(w=252.0, 0.0<=h<=546.4)
...      size: Size(252.0, 208.0)
...      painter: _DropdownMenuPainter#c5891(AnimationController#1e5f9(▶ 0.000; for _DropdownRoute<String>)➩ProxyAnimation➩Interval(0.25⋯0.5)ₒₙ/Threshold)
...      child: RenderSemanticsAnnotations#f4304 relayoutBoundary=up3 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
...        parentData: <none> (can use size)
...        constraints: BoxConstraints(w=252.0, 0.0<=h<=546.4)
...        size: Size(252.0, 208.0)
...        child: RenderClipPath#14ead relayoutBoundary=up4 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
...          parentData: <none> (can use size)
...          constraints: BoxConstraints(w=252.0, 0.0<=h<=546.4)
...          size: Size(252.0, 208.0)

flutter doctor -v
[√] Flutter (Channel stable, 3.0.0, on Microsoft Windows [Version 10.0.19043.1706], locale en-US)
    • Flutter version 3.0.0 at C:\tools\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ee4e09cce0 (2 weeks ago), 2022-05-09 16:45:18 -0700
    • Engine revision d1b9a6938a
    • Dart version 2.17.0
    • DevTools version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\User\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.1)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.11.31613.86
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] Connected device (4 available)
    • SM N975U1 (mobile) • RF8NA20GQZL • android-arm64  • Android 12 (API 31)
    • Windows (desktop)  • windows     • windows-x64    • Microsoft Windows [Version 10.0.19043.1706]
    • Chrome (web)       • chrome      • web-javascript • Google Chrome 101.0.4951.67
    • Edge (web)         • edge        • web-javascript • Microsoft Edge 101.0.1210.39

[√] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @g-regoz, it looks like there's a similar issue addressing this in https://github.com/flutter/flutter/issues/104678.
Kindly follow up there for more info.
Closing from here as duplicate.
Thank you


Add cupy-cuda102

Jenkins, test this please

Jenkins CI test (for commit cfb5e62c636e17b8de0b02946fbb4d5eb688434d, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit cfb5e62c636e17b8de0b02946fbb4d5eb688434d, target branch master) succeeded!


Path to focus is invalidated because comment line wrapped.

If the path to an expression to highlight with "focus" includes a comment line which will be wrapped because it extends beyond the width, the path will either fail or lead to different expression.

Fixed in 0.4.4.


Remove "fx_variable" from recipe_wenzel14jgr.yml

Description
Remove the call to "fx_variables" in the recipe.
That change should take care of the the changes necessary for https://github.com/ESMValGroup/ESMValTool/issues/3056

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

New or updated recipe/diagnostic

[ ] 🧪 Recipe runs successfully -> This recipe has some issues with running, but I thought I fix the call to the "fx_variables" anyway so that that is not the reason for the recipe to not run when we get around to fix it.
[x] 🧪 Recipe is well documented
[x] 🧪 Figure(s) and data look as expected from literature
[x] 🛠 Provenance information has been added

@esmvalbot please run recipe_wenzel14jgr.yml


Flyteplugins v0.4.8 #patch

TL;DR
Upgrade to Flyteplugins v0.4.8 for sagemaker custom training
Type

[ ] Bug Fix
[ ] Feature
[x] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[x] Code documentation added
[ ] Any pending items have an associated Issue

Tracking Issue
https://github.com/lyft/flyte/issues/451

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is n/a.


Reference environment variable in oidc-issuer-url

Hello guys,
I'm curious to know if there is any way to use environment variables to reference the oidc-issuer-url in the helm chart. What I am trying to achieve is to mount a variable from a secret and reference it as such:
alternative one (mounting tenant id from secret):
oidc-issuer-url: https://login.microsoftonline.com/${tenant}/v2.0

alternative two (mounting entire url from secret):
oidc-issuer-url: ${url}

I've tried both approaches but the error message is something of this sort:
[2023/02/03 12:14:30] [main.go:60] ERROR: Failed to initialise OAuth2 Proxy: error intiailising provider: could not create provider data: error building OIDC ProviderVerifier: could not get verifier builder: error while discovery OIDC configuration: failed to discover OIDC configuration: unexpected status "400": {"error":"invalid_tenant","error_description":"AADSTS90002: Tenant '${tenant}' not found. Check to make sure you have the correct tenant ID and are signing into the correct cloud. Check with your subscription administrator, this may happen if there are no active subscriptions for the tenant.

Not sure why this does not work. I have used the same approach when defining my Azure tenant in the same config and this works exactly as expected.
Current configuration:
extraArgs:
  provider: oidc
  azure-tenant: ${tenant}  # Azure AD OAuth2 Proxy application Tenant ID
  pass-access-token: true
  email-domain: "*"
  upstream: file:///dev/null
  http-address: <IP_ADDRESS>:4180
  oidc-issuer-url: https://login.microsoftonline.com/${tenant}/v2.0
  session-store-type: redis
extraEnv:
  - name: oidc-issuer-tenant
    valueFrom:
      secretKeyRef:
        name: oidc-issuer-url
        key: tenant
  - name: oidc_issuer_url
    valueFrom:
      secretKeyRef:
        name: oidc-issuer-url
        key: url

Am I going about this the wrong way? My goal is to hide the tenant ID (and other sensitive information) from the values file itself.
Thanks.

Hi @deggja,
you can mount directly a secret.
To create the secret:
kubectl create secret generic ${YOUR_SECRET_NAME} \
  --namespace ${NAMESPACE_OF_OAUTH2_PROXY} \
  --from-literal=client-id="${OAUTH2_APP_ID}" \
  --from-literal=client-secret="${OAUTH2_APP_PASSWORD}" \
  --from-literal=cookie-secret="${COOKIE_SECRET}"

or you can inject it from any vault/secret manager.
And then:
https://github.com/oauth2-proxy/manifests/blob/main/helm/oauth2-proxy/values.yaml#L18
config:
  existingSecret: <YOUR_SECRET_NAME>

Another option is to use a configMap to inject a config file.
Ref:
https://github.com/oauth2-proxy/manifests/blob/main/helm/oauth2-proxy/values.yaml#L45
https://github.com/oauth2-proxy/oauth2-proxy/blob/master/contrib/oauth2-proxy.cfg.example
Does this answer your doubts?
However, the tenant ID is not strictly a secret (e.g. https://www.whatismytenantid.com/)

https://www.whatismytenantid.com/

Hello @pierluigilenoci - thanks for replying.  I tried mounting the secret directly but it somehow gave me the error even then, so somehow it was not picked up.
Anyway - good point about the tenant ID not being a secret in the first place, I did not think about that.. and I think that basically revokes my need for this to work. I'll close the issue.
Thanks for pointing that out :see_no_evil:


APP-1213 / APP-1214

Create an enricher for "assign ticket" JIRA's action - search for users dialog and assign a ticket to a chosen user

Codecov Report

Merging #84 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #84   +/-   ##
=======================================
  Coverage   89.03%   89.03%
=======================================
  Files          41       41
  Lines        1122     1122
  Branches      130      130
=======================================
  Hits          999      999
  Misses         84       84
  Partials       39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9bcb89...3f5b317. Read the comment docs.

This code is covered in another PR #87


The description of the .rc file is incorrect and confusing

This statement about the .rc cannot be correct: "This file is overwritten by the .aps file whenever you save."
The script file, which is a text file, is not overwritten by a binary file. It would be very nice to have a better, more detailed description of how Viusal Studio uses all these files, along with a recommendation of which files should be included in Source Control and which should not.
I found some more detailed description, which could be incorporated into this page: https://social.msdn.microsoft.com/Forums/vstudio/en-US/acda5b17-b06a-4c20-8bdb-f4955c76358e/regarding-apssdf-files-in-vs2010?forum=vcgeneral

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58bf9b07-0cfc-1f77-28cb-0c2cda7ed3e3
Version Independent ID: edaf4af6-aaa2-0e5b-f3f4-ca1c065822a4
Content: Files Affected by Resource Editing
Content Source: docs/windows/files-affected-by-resource-editing.md
Product: visual-cpp
GitHub Login: @mikeblome
Microsoft Alias: mblome

@ScottHutchinson thanks for taking the time to report this! It looks like the current version of the topic already has info from that link you suggested. I added notes about which files to include in source control. Should be live by end of day on 6-19. Let me know if you are still seeing errors on that page.


Deployment of the new aws-login app with domain name on lz2

Describe the Issue
We have updated the aws-login app module on forge and assembly.
It hasn’t been deployed on lz2 because of some downtime du to migration and DNS propagation.
We have decided to do the migration off-hours this sprint
Additional Context

It has to be done off hours to minimize user impact.

Acceptance Criteria

The new aws-login app version has been deployed on lz2
The Overlay repo has been migrated
The workspace repo has been migrated

.
.
.
.
.
.
.
.
.
.
.
Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
It should be testable with no room for interpretation
It should be either “pass” or “fail”
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

The Migration has been done successfully.


[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 55)

Applying sensitive terms with GUID changes as part of Content SFI and outlined in Overview - Writing content securely - Platform Manual. Changes are part of the Microsoft-wide SFI effort. Point of contact: @CelesteDG
DocuTune v<IP_ADDRESS>
CorrelationId: ac15aa43-4e2b-437f-ab1c-fdd7e79cd4db
#docutune

#docutune-review

LGTM


[IBM] Fix tagging for all of resources

IBM

Fixed all of wrong tagging logics of IBM.
Fixed for all of resources.
Tested for all of resources with creating, getting and deleting.
Tested with TagHandler.

+Fixed VM zone


update mobile support documentation

Docs Build status updates of commit e86eb4e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:bulb:Suggestion
View
Details

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:bulb:Suggestion
View
Details

msteams-platform/resources/bot-v3/bots-files.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md

Line 12, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /graph/api/resources/communications-api-overview?view=graph-rest-beta NOTE: This Suggestion will become a Warning in early December, 2020.
Line 18, Column 3: [Suggestion-duplicate-alt-text] Alt text 'Call Types' is duplicated. Within an article, alt text must be unique. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 24, Column 3: [Suggestion-duplicate-alt-text] Alt text 'Call Types' is duplicated. Within an article, alt text must be unique. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 36, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /graph/api/resources/communications-api-overview?view=graph-rest-beta NOTE: This Suggestion will become a Warning in early December, 2020.

msteams-platform/task-modules-and-cards/cards/cards-reference.md

Line 278, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.bot.connector.herocard?view=botbuilder-dotnet-3.0 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 489, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/javascript/api/botframework-schema/receiptcard?view=botbuilder-ts-latest NOTE: This Suggestion will become a Warning in early December, 2020.
Line 490, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.bot.connector.receiptcard?view=botbuilder-dotnet-3.0 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 509, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /javascript/api/botframework-schema/signincard?view=botbuilder-ts-latest NOTE: This Suggestion will become a Warning in early December, 2020.
Line 510, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /dotnet/api/microsoft.bot.connector.signincard?view=botbuilder-dotnet-3.0 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 584, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/javascript/api/botframework-schema/thumbnailcard?view=botbuilder-ts-latest NOTE: This Suggestion will become a Warning in early December, 2020.
Line 585, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.bot.connector.thumbnailcard?view=botbuilder-dotnet-3.0 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 595, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /azure/bot-service/dotnet/bot-builder-dotnet-add-rich-card-attachments?view=azure-bot-service-3.0 NOTE: This Suggestion will become a Warning in early December, 2020.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 82e0dc1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-files.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1cc9814:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/bots/mobile-bot-file-consent-card.png
:white_check_mark:Succeeded
View

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-files.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7373e39:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/bots/mobile-bot-file-consent-card.png
:white_check_mark:Succeeded
View

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-files.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 5e380d9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/bots/mobile-bot-file-consent-card.png
:white_check_mark:Succeeded
View

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-files.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Support PHPRedis 6.0

Is there a technical reason why the PHPRedis extension is not being used in the latest version, which is 6.x?
https://github.com/phpredis/phpredis

Currently it is fixed version 5.3.7, and the latest version theoretically should not have compilation problems.
I've tested building 6.0.2 on my Linux server, and the only things need to do is supporting COPYING moved to  LICENSE problem.


Conflict with marshmallow install

Currently toasted-marshmallow is messing with the marshmallow install and causing errors. I'm pretty sure that modifying other named packages in site-packages/ is pretty bad form.
It should either use the system version of marshmallow (perhaps with constraints on which version) or install a custom version of marshmallow somewhere else.
Current behaviour:
Try uninstalling toasted-marshmallow and you get:
pip uninstall toastedmarshmallow
Uninstalling toastedmarshmallow-0.2.6:
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__init__.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/__init__.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/base.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/class_registry.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/compat.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/decorators.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/exceptions.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/fields.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/marshalling.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/orderedset.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/schema.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/utils.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/__pycache__/validate.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/base.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/class_registry.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/compat.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/decorators.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/exceptions.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/fields.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/marshalling.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/orderedset.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/schema.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/utils.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/marshmallow/validate.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow-0.2.6.dist-info/DESCRIPTION.rst
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow-0.2.6.dist-info/INSTALLER
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow-0.2.6.dist-info/METADATA
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow-0.2.6.dist-info/RECORD
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow-0.2.6.dist-info/WHEEL
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow-0.2.6.dist-info/metadata.json
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow-0.2.6.dist-info/top_level.txt
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow/__init__.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow/__pycache__/__init__.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow/__pycache__/compat.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow/__pycache__/jit.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow/__pycache__/utils.cpython-36.pyc
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow/compat.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow/jit.py
  /home/samuel/code/pydantic/env/lib/python3.6/site-packages/toastedmarshmallow/utils.py

In other works toasted-marshmallow is installing it's own version of marshmallow to site-packages/marshmallow, then I'm getting an error if I install the real marshmallow:
from marshmallow import SchemaJit

(I want both marshmallow and toastedmarshmallow installed for my benchmarks of other frameworks)

This really is bad practice. You guys should fork marshmallow, not overwrite it. This is not a drop-in replacement for marshmallow - it broke my project.  Even when I disabled toasted marshmallow's version of jit, my project was still broken, and I had to force reinstall marshmallow to get it working again.
People's projects may rely on a specific version of marshmallow - how would they know that this project overwrote their marshmallow with it's own specific version?

Kind of mad this ever happened and madder still that it hasn't been fixed and no one has responded.
Use pydantic instead. It's faster than toasted-marshmallow and more elegant IMHO.


fix: fixed an issue with variable replacement #221

This proposal is a breaking change but it fixes an issue where the curly brackets in the regex matcher conflict with i18next variable replacement. This change proposes to completely remove them having the translation right after the round brackets for count.
Checklist

[x ] only relevant code is changed (make a diff before you submit the PR)
[x ] run tests npm run test
[x ] tests are included
[ ] documentation is changed or added

Coverage increased (+0.4%) to 88.235% when pulling 668eca7a3d431a100cfeb239b1fb8a38399ae6b4 on nejcm:pr/fix-variable-replacement into 3fcdc025365597b93ea7cfda3e660c4f2c1764ce on i18next:master.

Coverage increased (+0.4%) to 88.235% when pulling 668eca7a3d431a100cfeb239b1fb8a38399ae6b4 on nejcm:pr/fix-variable-replacement into 3fcdc025365597b93ea7cfda3e660c4f2c1764ce on i18next:master.

rather sure there is a way to fix the regex to keep it compatible (not allowing })
intervalRegex: /\((\S*)\).*{([^}]+)}/,
Preferring your option - you still can pass your regex as init options. But I would prefer not breaking the current syntax.

rather sure there is a way to fix the regex to keep it compatible (not allowing })
intervalRegex: /\((\S*)\).*{([^}]+)}/,
Preferring your option - you still can pass your regex as init options. But I would prefer not breaking the current syntax.

rather sure there is a way to fix the regex to keep it compatible (not allowing })
intervalRegex: /\((\S*)\).*{([^}]+)}/,
Preferring your option - you still can pass your regex as init options. But I would prefer not breaking the current syntax.

Agree. Nice catch.

rather sure there is a way to fix the regex to keep it compatible (not allowing })
intervalRegex: /\((\S*)\).*{([^}]+)}/,
Preferring your option - you still can pass your regex as init options. But I would prefer not breaking the current syntax.

Agree. Nice catch.

rather sure there is a way to fix the regex to keep it compatible (not allowing })
intervalRegex: /\((\S*)\).*{([^}]+)}/,
Preferring your option - you still can pass your regex as init options. But I would prefer not breaking the current syntax.

Agree as this would need to be a major version release.
I tried finding a different solution but as I see it it is not possible. The value that is received inside the process function is not correct because i18next already tries replacing the value before but it does not do it successfully. This is before the regex runs.
Open for suggestions as there might be a solutions I am not seeing.

rather sure there is a way to fix the regex to keep it compatible (not allowing })
intervalRegex: /\((\S*)\).*{([^}]+)}/,
Preferring your option - you still can pass your regex as init options. But I would prefer not breaking the current syntax.

Agree as this would need to be a major version release.
I tried finding a different solution but as I see it it is not possible. The value that is received inside the process function is not correct because i18next already tries replacing the value before but it does not do it successfully. This is before the regex runs.
Open for suggestions as there might be a solutions I am not seeing.

I see - in that case it's more an issue with i18next interpolation regex that can't correctly handle {{{tripleCurly}}}?!?

I see - in that case it's more an issue with i18next interpolation regex that can't correctly handle {{{tripleCurly}}}?!?

https://github.com/i18next/i18next-intervalPlural-postProcessor/issues/206

https://github.com/i18next/i18next-intervalPlural-postProcessor/issues/206

I see - in that case it's more an issue with i18next interpolation regex that can't correctly handle {{{tripleCurly}}}?!?
update:
Not sure if that can be fixed to correctly pick the inner {{}} -> so your solution might be the best option even while breaking...

Yes. I believe it is probably not correctly handled on the i18next side.

I see - in that case it's more an issue with i18next interpolation regex that can't correctly handle {{{tripleCurly}}}?!?
update:
Not sure if that can be fixed to correctly pick the inner {{}} -> so your solution might be the best option even while breaking...

Yes. I believe it is probably not correctly handled on the i18next side.

v3.0.0 BREAKING changes regex from /\((\S*)\).*{((.|\n)*)}/ to /\((\S*)\).*?\[((.|\n)*)\]/ -> from (condition){value} to (condition)[value] to fix #206 and #221

v3.0.0 BREAKING changes regex from /\((\S*)\).*{((.|\n)*)}/ to /\((\S*)\).*?\[((.|\n)*)\]/ -> from (condition){value} to (condition)[value] to fix #206 and #221


FEATURE REQUEST: update feature description of simple.server package and documentation

Package description for https://chocolatey.org/packages/chocolatey.server and the corresponding documentation could improve expectation levels with a more detailed feature list and non-feature list, i.e.
FEATURES:
FOSS!
Runs on IIS
Only minor configuration necessary (configuration link here)
blah blah
NOTE:
Chocolatey Simple Server is NOT the same as the chocolatey.org website, it is much SIMPLER. It has all the basics you need to push and host Chocolatey packages on your equipment in your environment. It does NOT have the same built in management functions as the chocolatey.org. Some notable differences include no moderation, no package search, simple package list display via RSS/Atom, and (fill in more here). These features may come in some future release.
A roadmap would be nice to see what's planned coming down the road.

Sounds good. Should we get it all ironed out here?

Fine by me.
Is there a way to pull other relevant people into this? Or do I/we just run with it?

I'm hoping for (right now)  comments on this issue and then we can decide how best to implement that information.


Contribute an Armeria example to Okta Java REST Comparison repository

Blog: https://developer.okta.com/blog/2020/01/09/java-rest-api-showdown
Repository: https://github.com/oktadeveloper/okta-java-rest-api-comparison-example
/cc @mraible

Perhaps after #2840 by @max904-github is merged.


Coupon properties should not be accessed directly

product_ids, exclude_product_ids, product_categories and exclude_product_categories properties should not be accessed directly

Fixed via 5474c3c.


fatal: this operation must be run in a work tree

Hi, I'm trying to use this workflow, and this error is appearing. I'm using the default workflow and inputs specified.
Changing the strategy to input instead of clone made no difference. Any ideas on what could be the solution?
error messages:
Run Andrew-Chen-Wang/github-wiki-action@v4
Run "${GITHUB_ACTION_PATH%/}/src/$INPUT_STRATEGY.sh"
Initialized empty Git repository in /tmp/tmp.Haneogu7ZO/
fatal: this operation must be run in a work tree
Error: Process completed with exit code 128.

While trying to use this action, I ran into the same error. The fix for me was to create the wiki directory (default value for parameter path) in the repository the action runs on. Note that - at the time of writing this comment - v4.4.0 (v4) is significantly different that the current master/commit https://github.com/Andrew-Chen-Wang/github-wiki-action/commit/86138cbd6328b21d759e89ab6e6dd6a139b22270.
It turns out that the action (v4) works differently than I expected. I was expecting that this does a checkout of the <repo>.wiki repository.  Finally, the action - in a post action hook - would commit/push the changes.
The way this actually works is that the files in the path specified by the path (wiki by default) are mirrored to the wiki-repository. This means that any files which are in the wiki-repository which are not in the wiki directory, are deleted.
The mentioned current master/commit https://github.com/Andrew-Chen-Wang/github-wiki-action/commit/86138cbd6328b21d759e89ab6e6dd6a139b22270 does a regular clone instead of a bare one and then copies all files from the wiki directory to wiki-clone and committed. Note that any existing files are not removed by this action. This works for my flow which mixes hand written files combined with automatic generated files.


My lint-staged seems a little bit slow

Description

First thanks for this library!
I am wondering how long does it usually takes for the pre-commit hook using lint-staged. For me, one staged file can takes around 15 seconds.
When I look the video in the readme, I thought it might only takes a few seconds.
Steps to reproduce
You can fork this repo.
And npm run setup, then try to change something in api/src/app.ts file and commit.
Based on the log below, seems this step takes most time

Adding task modifications to index...

It does run only on staged file which is correct.
If you run npm run lint:js:fix on all files, it will about 20 seconds, which means lint-staged does help save some time.
Is this normal? Thanks
Debug Logs

expand to view
  lint-staged:bin Running<EMAIL_ADDRESS>+0ms
  lint-staged:bin Options parsed from command-line: {
  allowEmpty: false,
  concurrent: true,
  configPath: undefined,
  debug: true,
  maxArgLength: 131072,
  stash: true,
  quiet: false,
  relative: false,
  shell: false,
  verbose: false
} +1ms
  lint-staged Loading config using `cosmiconfig` +0ms
  lint-staged Successfully loaded config from `/Users/hm/Clouds/Git/hongbomiao.com/lint-staged.config.js`:
  lint-staged {
  lint-staged   '*.css': 'npm run lint:css:fix',
  lint-staged   '*.{js,ts,tsx}': 'npm run lint:js:fix'
  lint-staged } +42ms
  lint-staged:cfg Validating config +0ms
Running lint-staged with the following config:
{
  '*.css': 'npm run lint:css:fix',
  '*.{js,ts,tsx}': 'npm run lint:js:fix'
}
  lint-staged Unset GIT_LITERAL_PATHSPECS (was `undefined`) +2ms
  lint-staged:run Running all linter scripts +0ms
  lint-staged:resolveGitRepo Resolving git repo from `/Users/hm/Clouds/Git/hongbomiao.com` +0ms
  lint-staged:resolveGitRepo Unset GIT_DIR (was `undefined`) +0ms
  lint-staged:resolveGitRepo Unset GIT_WORK_TREE (was `undefined`) +0ms
  lint-staged:git Running git command [ 'rev-parse', '--show-toplevel' ] +0ms
  lint-staged:resolveGitRepo Resolved git directory to be `/Users/hm/Clouds/Git/hongbomiao.com` +15ms
  lint-staged:resolveGitRepo Resolved git config directory to be `/Users/hm/Clouds/Git/hongbomiao.com/.git` +0ms
  lint-staged:git Running git command [ 'log', '-1' ] +14ms
  lint-staged:git Running git command [ 'diff', '--staged', '--diff-filter=ACMR', '--name-only', '-z' ] +27ms
  lint-staged:run Loaded list of staged files in git:
  lint-staged:run [ 'api/src/app.ts' ] +58ms
  lint-staged:chunkFiles Resolved an argument string length of 54 characters from 1 files +0ms
  lint-staged:chunkFiles Creating 1 chunks for maxArgLength of 131072 +1ms
  lint-staged:gen-tasks Generating linter tasks +0ms
  lint-staged:gen-tasks Generated task:
  lint-staged:gen-tasks { pattern: '*.css', commands: 'npm run lint:css:fix', fileList: [] } +1ms
  lint-staged:gen-tasks Generated task:
  lint-staged:gen-tasks {
  lint-staged:gen-tasks   pattern: '*.{js,ts,tsx}',
  lint-staged:gen-tasks   commands: 'npm run lint:js:fix',
  lint-staged:gen-tasks   fileList: [ '/Users/hm/Clouds/Git/hongbomiao.com/api/src/app.ts' ]
  lint-staged:gen-tasks } +3ms
  lint-staged:make-cmd-tasks Creating listr tasks for commands 'npm run lint:css:fix' +0ms
  lint-staged:task cmd: npm +0ms
  lint-staged:task args: [ 'run', 'lint:css:fix' ] +0ms
  lint-staged:task execaOptions: { preferLocal: true, reject: false, shell: false } +0ms
  lint-staged:make-cmd-tasks Creating listr tasks for commands 'npm run lint:js:fix' +2ms
  lint-staged:task cmd: npm +1ms
  lint-staged:task args: [ 'run', 'lint:js:fix' ] +0ms
  lint-staged:task execaOptions: { preferLocal: true, reject: false, shell: false } +0ms
  lint-staged:chunkFiles Resolved an argument string length of 54 characters from 1 files +6ms
  lint-staged:chunkFiles Creating 1 chunks for maxArgLength of 131072 +0ms
[STARTED] Preparing...
  lint-staged:git Backing up original state... +0ms
  lint-staged:git Getting partially staged files... +0ms
  lint-staged:git Running git command [ 'status', '-z' ] +27ms
  lint-staged:git Found partially staged files: [] +42ms
  lint-staged:git Backing up merge state... +0ms
  lint-staged:file Reading file `/Users/hm/Clouds/Git/hongbomiao.com/.git/MERGE_HEAD` +0ms
  lint-staged:file Reading file `/Users/hm/Clouds/Git/hongbomiao.com/.git/MERGE_MODE` +0ms
  lint-staged:file Reading file `/Users/hm/Clouds/Git/hongbomiao.com/.git/MERGE_MSG` +0ms
  lint-staged:file File `/Users/hm/Clouds/Git/hongbomiao.com/.git/MERGE_HEAD` doesn't exist, ignoring... +0ms
  lint-staged:file File `/Users/hm/Clouds/Git/hongbomiao.com/.git/MERGE_MODE` doesn't exist, ignoring... +0ms
  lint-staged:file File `/Users/hm/Clouds/Git/hongbomiao.com/.git/MERGE_MSG` doesn't exist, ignoring... +0ms
  lint-staged:git Done backing up merge state! +0ms
  lint-staged:git Getting deleted files... +1ms
  lint-staged:git Running git command [ 'ls-files', '--deleted' ] +43ms
  lint-staged:git Found deleted files: [] +24ms
  lint-staged:git Running git command [ 'stash', 'create' ] +24ms
  lint-staged:git Running git command [
  'stash',
  'store',
  '--quiet',
  '--message',
  'lint-staged automatic backup',
  '3ca8f99aee41a923130b961d7b0b44346559cf89'
] +58ms
  lint-staged:git Done backing up original state! +80ms
[SUCCESS] Preparing...
[STARTED] Running tasks...
[STARTED] Running tasks for *.css
[STARTED] Running tasks for *.{js,ts,tsx}
[SKIPPED] No staged files match *.css
[STARTED] npm run lint:js:fix
[SUCCESS] npm run lint:js:fix
[SUCCESS] Running tasks for *.{js,ts,tsx}
[SUCCESS] Running tasks...
[STARTED] Applying modifications...
  lint-staged:git Adding task modifications to index... +14s
  lint-staged:git Running git command [
  'add',
  '--',
  '/Users/hm/Clouds/Git/hongbomiao.com/api/src/app.ts'
] +15s
  lint-staged:git Done adding task modifications to index! +15ms
  lint-staged:git Running git command [ 'diff', '--name-only', '--cached' ] +15ms
[SUCCESS] Applying modifications...
[STARTED] Cleaning up...
  lint-staged:git Dropping backup stash... +31ms
  lint-staged:git Running git command [ 'stash', 'list' ] +31ms
  lint-staged:git Running git command [ 'stash', 'drop', '--quiet', 'refs/stash@{0}' ] +26ms
  lint-staged:git Done dropping backup stash! +73ms
[SUCCESS] Cleaning up...
  lint-staged Tasks were executed successfully! +15s

Environment

OS: macOS 11.2.3
Node.js: 15.13.0
lint-staged: 10.5.4

That doesn't seem right. What is your git version? That part of the workflow is basically just running git add <file>.

Hi @iiroj it is git version 2.24.3 (Apple Git-128).

I'm sorry, I misread your logs! The 14 secs at the start of the git add stage refers to the previous thing, which was running your commands.
It looks like your command is npm run lint:js:fix. Maybe it's linting all files instead of only the staged?
lint-staged passes a list of filenames to the command, so for example eslint --fix becomes eslint --fix staged-file.js. If your command already includes something like eslint --fix ., it will then match all files because of the . because it will be eslint --fix . staged-files.js.

Ah, I see, my npm run lint:js actually runs eslint . --ext .js,.ts,.tsx --fix.
I have changed my lint-staged.config.js from
module.exports = {
  '*.{js,ts,tsx}': 'npm run lint:js',
};

to
module.exports = {
  '*.{js,ts,tsx}': 'eslint --fix',
};

Now it total only takes 5 seconds now.
Thanks for clarification, @iiroj !

@iiroj isn't 5 seconds a bit too much to run eslint on a single file (180 lines)?
Given vscode linting is more or less instant, I would expect the eslint to be too. What's your average response time?


add croatia

This change is

Coverage remained the same at 46.423% when pulling 124e5ae3c62ad1ba97138c5bb46fd136b1e6dc41 on sofiiashnyr:a490451185141804_add_croatia into 5e6d6911c6e0a2e569ccf873460b74081fb7342f on openprocurement:production.