Fix loop making too many instances

When testing, I noticed that the loop created a new sound instance each time it played the audio. This slowly causes memory usage to rise, stopping the audio fixes this as the sound instance gets destroyed then. Perhaps there should be a check if the same sound is already playing on the same parent?

This is definitely a problem, but I'm don't think this is the right solution. There is a problem with Sound instances persisting when they shouldn't.

In ClientSound, this might be fixable by replacing
...
ReplicationValue:GetPropertyChangedSignal("Parent"):Connect(function()
        if ReplicationValue.Parent then return end
        self.Sound:Stop()
...

to
...
ReplicationValue.Destroying:Connect(function()
        self.Sound:Stop()
...

My guess is the issue is due to a race condition of the value being destroyed and the event firing.

In ClientSound, this might be fixable by replacing
...
ReplicationValue:GetPropertyChangedSignal("Parent"):Connect(function()
        if ReplicationValue.Parent then return end
        self.Sound:Stop()
...

to
...
ReplicationValue.Destroying:Connect(function()
        self.Sound:Stop()
...

My guess is the issue is due to a race condition of the value being destroyed and the event firing.

That did fix it 👍


Add a prefetch example that uses a combination of fetch and mutate

This PR adds a basic example of how one could prefetch data using a combination of fetch and mutate.
Related to https://github.com/zeit/swr/issues/118.

Apologies, it looks like #120 beat me to it 🙃
I can look into switching the example from prefetch to preload.


[gbc] Rename Types_Comm_cpp to Comm_cpp

Renamed the file, the module, and the functions.

C++ build timeouts again... Closing and re-opening to re-run.


Random slideshow and the ability to randomly display all resources

Discussed in https://github.com/RouHim/this-week-in-past/discussions/152

Originally posted by joe128 December 17, 2024
Problem
If the config RANDOM_SLIDESHOW is enabled, a random image is fetched for each slideshowTick. So there is a very high chance that an image will be displayed twice before all resources have been displayed.
This behaviour isn't suitable if you want to display a slideshow over a small number of images.
(I have mentioned this issue and my usecase under https://github.com/RouHim/this-week-in-past/issues/138#issuecomment-2334762370)
Solution
Perhaps we could introduce a config that allows a kind of "shuffle and display all resources" (SHUFFLE_ALL)?
Another possibilities

refactor the existing config RANDOM_SLIDESHOW
introduce a config SHOW_ALL (with optional RANDOM_SLIDESHOW)

I have already implemented a POC and tested it with a small set of images.
Minimal config example to reproduce:
rm -rf testresources \
  && mkdir testresources \
  && rm -rf devdatafolder \
  && mkdir devdatafolder \
  && wget -O testresources/pic1.jpg https://picsum.photos/500/500 \
  && wget -O testresources/pic2.jpg https://picsum.photos/500/500 \
  && RESOURCE_PATHS=testresources DATA_FOLDER=devdatafolder RANDOM_SLIDESHOW=true SLIDESHOW_INTERVAL=3 ./this-week-in-past

RANDOM_SLIDESHOW now plays an actually shuffled slideshow.

Thanks a lot, but why the limitation to 1000 images? I think it should be at least 10.000.
Unfortunately, during the Christmas holidays I discovered the next missing feature: Display all images chronologically.  Last week I described a solution in discussion #152 with a SHOW_ALL parameter, perhaps this approach can also be considered?

There should be definitely a limitation, which value do you think could be a good idea?

If you have the time, you could raise a feature request for your chronological sorting feature.

There should be definitely a limitation, which value do you think could be a good idea?

1000 should be more than fine, because after the default refresh interval, which is 1 hour per default, and a default slideshow interval of 30 seconds, we just need 120 images right?
But this should not be hardcoded, thus it should be calculated by this formula:
(60/SLIDESHOW_INTERVAL)*REFRESH_INTERVAL
Optional: * 10% buffer

I think this approach works well, thank you.


I want to add sources

Can you explain to me how to add resources to the application?

You can see the contributing guide for setting up the environment.
Then you can take a loot at sources folder.
Create a new file with the name of source in it's language folder. You can pick the template from any other source and just edit the selectors. If the source's website follows a common format such as Madara, etc. go to the multiSrc  folder and create a new object in the generator file.
Once you have done that import your source in src/sources/sources.js and add it to the scrapers object and also add a new object  for your source in src/sources/sources.json.
If you have any doubts or face an issue feel free to ask.


Various improvements in workflow engine performance + E2E test fixes

Various improvements that came out of a debugging session. It includes a number of perf improvements too:

Use state bulk get operations when loading the workflow state.

This replaces the current loops that load each key individually, performing possibly hundreds of roundtrips to the state store
It is implemented by adding a GetBulkState method to the actors interface. This method is only used by internal actors and not exposed to end-users (e.g. not callable by regular actors). Should that be desirable, it can be done in the future.

Allow running E2E tests outside of Kubernetes for a faster debug loop experience. How to do that is explained in a comment; TLDR:

Run the E2E app with the Dapr CLI: ASPNETCORE_URLS=http://*:3000 dapr run --app-id workflowsapp --resources-path ./resources -- dotnet run
Run the test: WORKFLOW_APP_ENDPOINT=http://localhost:3000 DAPR_E2E_TEST="workflows" make test-clean test-e2e-all
Locally, tests use SQLite

Changed various log levels: debug logs are moved to "debug", and errors are moved to "error"
When deleting leftover state, use a single transaction per each actor ID. This can help reducing roundtrips to the state store.
DecodeInternalActorData processes data as a stream directly without first buffering in-memory
Some cleanups in the E2E test code

/ok-to-test

/test-sdk-all

After I hit approve, I noticed you have a conflict @ItalyPaleAle. Let me know when you take care of it so I can look at that file again :)

After I hit approve, I noticed you have a conflict @ItalyPaleAle. Let me know when you take care of it so I can look at that file again :)

Should be fixed now, thanks!

/ok-to-test

/test-sdk-all


Create a Custom 404 Page

Create a Custom 404 Page
Purpose:
This pull request introduces a custom 404 error page aimed at enhancing user experience. The design is user-friendly and aims to keep users engaged even when they encounter an error. Key features of the new 404 page include:
Changes Made:
To solve the problem of user experience when encountering a 404 error, I have developed a custom 404 error page for the website. Here is the step-by-step solution:

Design of the Custom 404 Page:

User-Friendly Interface: The page is designed to be visually appealing and easy to understand, helping users quickly grasp that the requested page is not available.
Clear Messaging: The page includes a prominent error message stating "404 - Page Not Found," along with a friendly suggestion to guide users back to useful areas of the site.

Navigation and Engagement:

Quick Links: The custom 404 page provides direct links to essential sections such as Home, Events, Team, and Gallery, allowing users to easily navigate the site instead of leaving.
Search Functionality: A search bar is included for users to look for specific content on the site, improving overall usability and keeping users engaged. When a user types a query and clicks the search button, they are redirected to a search results page, allowing them to find the content they need without leaving the site.

Visual Consistency:

Styling and Branding: The page maintains consistent styling with the rest of the website, utilizing similar colors, fonts, and layouts. This ensures a seamless transition for users who might navigate from the error page back to the main site.

Implementation Details:

HTML Structure: The 404 page is structured using HTML5, with semantic elements for better SEO and accessibility.
CSS Styling: Custom CSS is applied to enhance the visual appeal, including hover effects for buttons and a responsive layout to ensure usability across devices.
JavaScript Functionality: A small script is included to handle search functionality. When a user enters a query and clicks the search button, they are redirected to a search results page, maintaining a smooth user experience.
Testing Instructions:
Access a non-existent URL to view the new 404 page.
Use the search bar to test its functionality.

Notes:

Please let me know if there are any improvements needed or if any additional features are required!

Custom 404 Page Added
Description:

Created a custom 404 error page to improve user experience and site navigation.
The page includes helpful messaging and a link to return to the homepage.

Merging into:
main
This update enhances the user experience by providing a friendly 404 page, guiding users back to the main site.


Allow reconnection window to reconnect

When an individual session ends, we need to decide how to handle it. Two candidate options:

kick user to a reconnect page
allow reconnection to the server from the reconnect window

A short note about a thought I had: kill the websocket after n moments, but keep the container up a while; this way the socket is still possible.

Chalk this up to a can't fix/won't fix; once the proxy is dead, it's not really possible to coerce the application to make a request outside of itself.


Auto tab formatting pasted code

Issue Type: Feature Request
When I paste code into the Visual Studio Code IDE, the code needs to be tabbed or have tabs deleted so that the code aligngs fine. This is happening when working with Python.
Thank you, great program, keep up the great work!
VS Code version: Code 1.69.2 (3b889b090b5ad5793f524b5d1d39fda662b96a2a, 2022-07-18T16:12:52.460Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

It sounds that you would like to use "editor.formatOnPaste": true.


1.12.2 Slime Monster Reanimation Crashes Game

General Information
Describe the bug:

Whenever you perform the monster reanimation ritual for slimes in Minecraft 1.12.2 the altar glows purple for a few seconds and then crashes the whole game.
To Reproduce:

Set up altar with mundane and attuning stones surrounding the altar
Put incense burners with one containing a nether wart and the other coal and light with flint and steel (I have lit both before and after next step)
Place three slime balls on the altar and left click with no item in hand (this causes the purple light from altar and then game crash).

Expected behavior:

It is expected that a slime would spawn after the purple glowing light disappears.

Environment Versions

I have only tried to do this with minecraft 1.12.2 (RootsClassic-1.12.2-1.1.5) and the hexxit modpack installed as well. I have not tried any other versions.
Mystic Mods Versions

I do not believe I have any installed as far as I can see should they contain the word mystic in the name

Other Versions:

Conflicting mod (if regarding mod integration):
Other mods you think could cause issues:
Forge: CurseForge
Minecraft: 1.12.2
Modpack (if available): Hexxit
I have a couple backpack mods, minihud, etc. installed as well, but none that I believe would conflict.

Logging Information
Please Use gist, paste.ee, pastebin or some other log sharing service
Crash Report (if available):

https://gist.github.com/ECubeD1/60a6340c306deef56282bdacebbf504e
(I believe I did this right)
Latest Log (if necessary):

Additional Information
Screenshots (if available):

Additional context (optional):

I can summon every other mob, but a slime crashes it. I have tried out in the open and below y = 39. I have also tried summoning them both above and below y = 39 in a slime chunk and with all other entities killed as well as them being there

Ah, I didn't realise this was for Roots Classic. I'm afraid this is only for Roots 3.1 and later.


orphan delete-strategy on a resource with child resources does not delete successfully

I have an app that I deploy and teardown all the time as part of an automated test process. Part of my app includes certificates generated by cert-manager and provisioned by Let's Encrypt.
Up until now, I excluded the certificate resources from the automated test environment  because the act of creating and deleting the certificate resources leads to exceeding Let's Encrypt's rate limits, which causes my deployments to stop working.
I noticed kapp features a kapp.k14s.io/delete-strategy annotation that I might be able to use on the certificate to "skip deleting" it and reuse it on the next deployment. I thought this would be better for me because having the certificates in my test environment just like every other environment  would make my test environment more production-like and simplify my test process by letting it assume there will always be valid certificates in any environment.
I ran into issues with the generated, "child resources" of the certificate.
What steps did you take:
I applied the kapp.k14s.io/delete-strategy: orphan annotation to my certificate.cert-manager.io resource.
I deployed the app.
I deleted the app.
What happened:
When the app deployed, cert-manager created the accompanying certificaterequest.cert-manager.io and order.acme.cert-manager.io resources (normal, desired behavior of cert-manager). A kubectl describe command for each of the generated resources shows that they have inherited the kapp.k14s.io/delete-strategy: orphan annotation. I don't know what mechanism applied that annotation to them (maybe cert-manger or k8s itself?), but that's exactly what I wanted so I'm happy about it. The three resources work as a unit so I wanted to treat all of the same way (i.e. leave them orphaned on delete).
Name:         my-app-qcmbr
Namespace:    my-app
Labels:       kapp.k14s.io/app=1619283995411166000
              kapp.k14s.io/association=v1.8dd04f03c81055b2dff27e72ffe84719
Annotations:  cert-manager.io/certificate-name: my-app
              cert-manager.io/certificate-revision: 1
              cert-manager.io/private-key-secret-name: my-app-tjh4z
              kapp.k14s.io/delete-strategy: orphan 👈 😁
              kapp.k14s.io/identity: v1;my-app/cert-manager.io/Certificate/my-app;cert-manager.io/v1
              kapp.k14s.io/original:
                {"apiVersion":"cert-manager.io/v1","kind":"Certificate","metadata":{"annotations":{"kapp.k14s.io/delete-strategy":"orphan"},"labels":{"kap...
              kapp.k14s.io/original-diff-md5: 58e0494c51d30eb3494f7c9198986bb9
API Version:  cert-manager.io/v1
Kind:         CertificateRequest

However when I deleted the app, kapp's diff didn't show the orphan strategy for the generated child resources.
Namespace  Name                     Kind                Conds.  Age  Op      Op st.  Wait to  Rs  Ri
(cluster)  my-app                   Namespace           -       9m   delete  orphan  delete   ok  -
my-app     api                      Deployment          2/2 t   19s  delete  -       delete   ok  -

... (abbreviated)

^          my-app                   Certificate         1/1 t   9m   delete  orphan  delete   ok  -
^          my-app-qcmbr             CertificateRequest  1/1 t   9m   -       -       delete   ok  - 👈 🤔
^          my-app-qcmbr-1942737023  Order               -       9m   -       -       delete   ok  - 👈 🤔

Oh no! This diff from kapp isn't representing kapp.k14s.io/delete-strategy: orphan annotations on CertificateRequest and Order resources! I went ahead and deleted the app anyway to see what would happen.
$ kapp -n apps delete -a my-app
... (abbreviated)
10:17:51AM: ---- waiting complete [28/28 done] ----

kapp: Error: Expected all resources to be gone, but found: order/my-app-qcmbr-1942737023 (acme.cert-manager.io/v1) namespace: my-app, certificaterequest/my-app-qcmbr (cert-manager.io/v1) namespace: my-app
$ echo $?
1

So, it seems it didn't delete the resources (yay) but  printed a sad error message and exited unsuccessfully (boo).
What did you expect:

show the delete strategy on the child resources in kapp's diff
kapp delete doesn't delete the child resources (current behavior, I guess)
kapp delete exists successfully

Anything else you would like to add:
The Carvel team rocks.
Environment:

kapp version (use kapp --version): 0.36.0
OS (e.g. from /etc/os-release): Alpine and macOS
Kubernetes version (use kubectl version): 1.19.7

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

hey @lnhrdt,
thanks for a detailed question. here is whats happening: kapp knows about resources it creates vs resources that get created by controllers/cluster as a response to kapp created resources.
if you take a look at the delete summary, there is a column called "Op" that indicates what operation kapp will take against that resource. in your case, 2 resources that were created by cert-manager are not owned by kapp directly, hence by default kapp will not explicitly delete them (though it will try to wait for them to be deleted -- wait to column shows that).
one possible solution here is to try adding owned-for-deletion annotation (https://carvel.dev/kapp/docs/latest/apply/#kappk14sioowned-for-deletion). im guessing that cert-manager copies down annotations from certificate resource to child resources so it should copy over this annotation as well. this annotation would tell kapp to consider these resources as owned by kapp. by combining it with delete-strategy annotation to orphan resources (instead of actually deleting it), you ll get desired combination.
ive not tried doing this myself but do let us k ow how this pans out.

Hey @cppforlife
Your suggestion worked great! I applied the kapp.k14s.io/owned-for-deletion: "" annotation to my certificates. Something (presumably cert-manager) copied them over to the generated CertificateRequest and Order resources. When I used kapp to delete the app, it identified all 3 resources as having an orphan strategy and successfully deleted the app while leaving those 3 behind. Thanks for helping me find a solution to what I needed!
I don't know if it's too much of an edge case to care about, but I feel it might be worth pointing out what was kind of unexpected behavior along the way. When the resources generated by cert-manager (CertificateRequest and Order) had the Certificate resource's annotations:
kapp.k14s.io/delete-strategy: orphan
kapp.k14s.io/identity: v1;my-app/cert-manager.io/Certificate/my-app;cert-manager.io/v1
kapp.k14s.io/original:
  {"apiVersion":"cert-manager.io/v1","kind":"Certificate","metadata":{"annotations":{"kapp.k14s.io/delete-strategy":"orphan"},"labels":{"kap...
kapp.k14s.io/original-diff-md5: 58e0494c51d30eb3494f7c9198986bb9

A few weird things happened when deleting the app:

they showed up in kapp's diff, despite not being owned by the app
their presence failed the delete operation

Again, I don't really need resolution on that for my needs but thought it might be worth pointing out what I noticed along the way before closing this issue. And thanks again for the quick help @cppforlife!

they showed up in kapp's diff, despite not being owned by the app

since we marked them with "owned-for-deletion" they are owned by the app (for deletion at least) from kapp's pov. if you have a diff snippet (with summary) it might be useful to see how it looks.

their presence failed the delete operation

can you tell me a bit more about this one? any errors that popped up?


proposal to separate netbsd 10 release from its predecessors which

will be still used for a while.

We should discuss and define the support policy for NetBSD before this.


Highlight the whole line (lines) of code by mouse click

I suggest to add feature to highlight the whole line (or lines) of code by mouse click left off the sql editor text (the area with line numbers).
Here is an example how it works in SSMS:
https://github.com/user-attachments/assets/b4a2642e-cf73-445e-a76c-7ecbc657a1f7
It is much easier to work with code, select some parts of code or subqueries for copy-paste, moving lines up/down, etc...

For now to do this you can use triple-click %-)

some issues should report upstream: eclipse platform😂

OK. Sorry, I have never used eclipse platform before.
I hope someday I'll get to it to explore.

OK. Sorry, I have never used eclipse platform before. I hope someday I'll get to it to explore. If it is related to the Eclipse platform, feel free to close the issue with mentioning it. Later on I'll try to send it to Eclipse.

To be honest, you didn't miss too much :D Not the best platform I ever used. But yeah, Eclipse provides most of the UI capabilities that DBeaver use. You can enable the block select mode with alt+shift+a, it a powerfull tool but sometimes works funny as it converts the selected part into a multi selection.
How:
Hit alt+shift+a, notice your cursore chagned to a crosshair
Draw a block on the top of your code, which will draw a square like this:

Then you can work as you are in the multi selection.
Why is it working funny and not the same as you asked for? Because it will populate the empty space with white spaces when you copy the code. So, you have to advance copy it as unformatted text.
I like to select the area I would like to interact with like this:

And hit ctrl+shift+down arrow on windows (Moves lines Down), and if you wana keep it where it was, then ctrl+shift+up to move it back. This selects the whole row I want.
Also, "next query" and "previous query" are something I often use, these select the whole next or previous query.

Thank you for sharing these tips.
I only knew about alt + mouse click before, but alt + shift + A is another interesting feature.

Thank you for request.


[Bug] Template Editor Caching Issue

When editing a template file in the "template editor" interface (in PUI), the template data is fetched from the file (on the server), from the raw file URL e.g. /media/report/label/part_label.html
However the server can cache this file, meaning that the file returned may not be the correct "up to date" file, if the template has been very recently edited.
This can lead to potential issues if the template editor is opened / closed rapidly, and overwriting the upstream file with an out-of-date cached copy.

@SchrodingersGat is this related to PUI or the underlying report generation?

This is not related to the UI it is based on caching of uploaded files by the backend


fix debug data function for out of index if debug >1

Thanks for the pull request, can you rebase against the latest version. It contains some changes that are not present in your pull request.
Please check the usage of tabs vs spaces while identifying. It should be in line with the style that is used  (spaces)

Should be ready now for merge


Configure Excludes is too aggressive, will not allow my project

The Curse of the Dreaded Configure Excludes
After a random delay... Maybe 2 hours... Suddenly I get:

I have configured all possible excludes.
I have excluded all possible module directories.
I have excluded all possible build directories.
I've added numerous specific path to exclude even more things.
in jsconfig.json
    "exclude": [
        "node_modules",
        "**/node_modules",
        "**/build",
        "more_excludes",
        "**/even_more_excludes",

Please allow the project to continue without the curse of the dreaded configure excludes.

Please provide more info about your project structure or check the tsserver logs to see which files are being included incorrectly:

Set "typescript.tsserver.log": "verbose",
Restart VS Code and reproduce the problem
In VS Code, run the TypeScript: Open TS Server log command
This should open a folder with a tsserver.log file in it

Look at the end of the logs for long lists of files that are included in your project. Do these files match your expectation?

Closing as more information is needed to investigate this

@mjbvz Sorry I didn't respond yet. Can you please re-open the issue?

@mjbvz Sorry I didn't respond yet. Can you please re-open the issue?
This is a very serious problem, it is the #1 problem in VSCode
I didn't respond because the situation "improved" for a few days with an Insiders build and I was trying to find out if it was working

So does it work on insiders? If not please take a look at the logs as I suggested and share the results

@mjbvz On it right now

@mjbvz tsserver.log shows the list of source files match my expectations.
But there's also 10,000 .d.ts files.
The indexed .d.ts files do not utilize the jsconfig.json excludes, so the log shows every possible **/node_modules/**/*.d.ts
Is that normal?
On a side note, TypeScript: Open TS Server log command is not existing anymore

My response may have been wrong, I'm trying to figure it out. The log has more stuff, I need to sort out the caches

@mjbvz As far as I can tell, you smart Microsofters made this problem disappear on the most recent Insiders build.
Suddenly I am unable to even reproduce the issue.
I just opened 50 files across different yarn workspaces and I can't even get the Excludes warnings to pop up. Maybe the problem will return after VSCode runs for a number of hours. I can report back.


Update sbt-antlr4 to 0.8.3

Updates com.simplytyped:sbt-antlr4 from 0.8.2 to 0.8.3.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.simplytyped", artifactId = "sbt-antlr4" } ]

labels: sbt-plugin-update, semver-patch

Codecov Report

Merging #71 (0dbd399) into master (c68d563) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   35.24%   35.24%
=======================================
  Files          21       21
  Lines        1132     1132
  Branches       18       18
=======================================
  Hits          399      399
  Misses        733      733

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68d563...0dbd399. Read the comment docs.


Settings - On clear after never, status save does not work

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.13-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open the app
If status already set then open the status by clicking besides settings OR set status from settings->profile->status and reopen status page
Set 'clear after' to never and save
Again open status and make any changes to message or emoji
Click on save and observe that now app does nothing

Expected Result:
App should save the status on click on save on status page
Actual Result:
App does nothing on click on save when clear after is set to Never on last save
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/33c66ad4-197a-4caf-afae-ae629c612de9
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Once we set a status with clear never option, updating status again isn't working
What is the root cause of that problem?
For a clear after Never option we are setting an empty string here.
https://github.com/Expensify/App/blob/990815f84567f39d4b84c45bf1952b306d0c4bfe/src/pages/settings/Profile/CustomStatus/StatusPage.js#L82-L86
But on mount while setting the draft status we are not using an empty string as Never here.
https://github.com/Expensify/App/blob/990815f84567f39d4b84c45bf1952b306d0c4bfe/src/pages/settings/Profile/CustomStatus/StatusPage.js#L108-L113
What changes do you think we should make in order to solve the problem?
On mount logic consider an empty string as a value Never for draft custom status bcoz the else block will executes when we have existing status details.
User.updateDraftCustomStatus({clearAfter: currentUserClearAfter || CONST.CUSTOM_STATUS_TYPES.NEVER});

https://github.com/Expensify/App/blob/990815f84567f39d4b84c45bf1952b306d0c4bfe/src/pages/settings/Profile/CustomStatus/StatusPage.js#L112

We discussed here and decided this isn't a deploy blocker since it's a back-end issue

@jasperhuangg isn't this a front-end issue where we are not setting the correct value for draft status clearAfter?

@Pujan92 I've clarified with @stitesExpensify since he's been in charge of the back-end fix for this.

Waiting on the above &

@thesahindia can you please evaluate the proposals? After coming back and looking at this again, I believe this is a front end issue 😅

Proposal
Please re-state the problem that we are trying to solve in this issue.
App does nothing on click on save when clear after is set to Never on last save
What is the root cause of that problem?
We have inconsistency between FE and BE when we set clear after: never

In FE, we save clear after: never as draft

But when calling API we pass clear after:'' as a parameter and the BE also returns clear after:''

So that we should accept both values: 'never' and empty string for this case
https://github.com/Expensify/App/blob/f268c39c331305c49dbb80a0d0e59984289ecb25/src/pages/settings/Profile/CustomStatus/StatusPage.js#L78
But here we don't check if  clearAfterTime isn't empty string
What changes do you think we should make in order to solve the problem?
I think we only should make it consistent and only use one value: "never" or empty string for both FE and BE

If using empty string, we don't need to update from BE. We only need to update draft value in the FE to empty string instead of "never" and replace the condition to empty string instead of "never"
If using "never" value (I think it will be more clear), we need to update from BE side to return clear after: never in FE we also replace some places to use "never" value instead of empty string

What alternative solutions did you explore? (Optional)
NA

PR is ready
cc: @thesahindia

Holding on payment still

Payouts due:
Contributor: $500 @bernhardoj (Upwork)
Contributor+: $500 @thesahindia (NewDot)
Upwork job is here.

$500 approved for @thesahindia


Deep copy object before saving

It looks like node-gcloud modifies Objects in some scenarios when
saving them to the datastore. The case I was able to reproduce is
it modifying arrays to be of type 'arrayValue' when the array is
inside another class. This case is represented in the included
test case.
On our current state, a shallow copy of the object would be enough,
but since the problem could arise again if we have the class
instance with an array deeper in the object structure. A test case
has also been added to cover this case.

@juliantoledo @ithinkihaveacat PTAL.

Can you fix the lint error?
Do I need to delete my old db objects to test it? (otherwise I get an error).

Fixed the lint error. You shouldn't have to delete any db object. It looks like the list test is flacky. Does the update one work for you?

LGTM


swiper-pagination-bullets position needs to be customizable

Bug Report
Ionic Info
<EMAIL_ADDRESS>
Describe the Bug
I have a full screen slider, when it appears on iPhone X, the pagination bullets are too close to the bottom. I'd like to move them up using env(safe-area-inset-bottom). Note: If you don't have a full screen slider, you probably won't need to move the bullets.
Steps to Reproduce

Create slider
swiper-pagination-bullets are part of shadow dom so you can't style

Expected Behavior
css var available to customize bottom positioning of bullets.
Additional Context

@mhartington

Any updates?

If you want, you can create a PR so that it can be merged :)

I faced the same issue and I use global.scss for the moment
global.scss
.swiper-pagination {
bottom: 20px !important;
bottom: calc(env(safe-area-inset-bottom) + 20px) !important;
}

Workaround: if you have multiple slides with different layouts, you can add the modifierClass to the slide options.
slideOpts = {
pagination: {
el: '.swiper-pagination',
modifierClass: 'nameyourspecialclass'
}
};
You are still required to position your 'nameyourspecialclass' in the global.css.

Thank you for the issue! I took a look into this and since slides are no longer shadow this should not be an issue using normal CSS. It does require users to target the pagination classes, but due to the complexity of swiper's implementation there isn't a good way to assign a CSS variable for the pagination without doing it on the actual pagination element. For example, swiper styles bullets one way here:
.swiper-container-horizontal > .swiper-pagination-bullets {
  bottom: 10px;
  left: 0;
}

and styles the dynamic bullets differently:
.swiper-container-horizontal > .swiper-pagination-bullets.swiper-pagination-bullets-dynamic {
  left: 50%;
}

Because of the fact that the .swiper-pagination-bullets-dynamic class isn't on the host element, we would have to set the CSS variable inside of this rule, which would defeat the purpose because you would still have to target the above class to override it.
However, this is possible by using CSS and targeting the pagination classes: https://codepen.io/brandyscarney/pen/RwwJgxG
I'm going to close this since the original issue dealt with shadow and that is no longer an issue. Please open a new issue if you strongly feel that the above doesn't cover your use case. Thanks!


Unable to load paml.ttl into robot ontology tool

I have had a couple of problems trying to use robot to translate paml.ttl into a different format:

robot was confused by the turtle files importing prefix IRIs instead of Ontology IRIs.  Honestly, I don't know if robot is right or paml is, but this diff fixes imports (note that I had to do this for uml.ttl and opil.ttl, as well) -- almost:
<http://bioprotocols.org/paml> rdf:type owl:Ontology ;
-                              owl:imports uml:, sbol: , om:, prov:;
+                              owl:imports <http://bioprotocols.org/uml> ,
+                                          <http://sbols.org/v3> , <http://www.ontology-of-units-of-measure.org/resource/om-2>,
+                                          <http://www.w3.org/ns/prov> ;
                           rdfs:comment "Protocol Activity Modeling Languge (PAML) ontology." ;
                           owl:versionInfo "0.3" .

I now get this error message, about something going on with the provenance ontology. I really don't understand it:
(paml) rpg@rpg-macbook-pro: ~/projects/xplan/paml/paml $ robot convert --catalog catalog-v001.xml --input paml.ttl --output paml.ofn
2021-10-09 17:02:05,027 ERROR uk.ac.manchester.cs.owl.owlapi.OWLOntologyManagerImpl - OWLOntologyManagerImpl.checkForOntologyIDChange() existing:Ontology(OntologyID(OntologyIRI(<http://www.w3.org/ns/prov#>) VersionIRI(<null>))) [Axioms: 0 Logical Axioms: 0] First 20 axioms: {}
2021-10-09 17:02:05,030 ERROR uk.ac.manchester.cs.owl.owlapi.OWLOntologyManagerImpl - OWLOntologyManagerImpl.checkForOntologyIDChange() new:Ontology(OntologyID(Anonymous-16)) [Axioms: 7 Logical Axioms: 0] First 20 axioms: {Declaration(AnnotationProperty(rdfs:seeAlso)) Declaration(AnnotationProperty(rdfs:comment)) Declaration(AnnotationProperty(rdfs:label)) Declaration(AnnotationProperty(owl:versionInfo)) Declaration(ObjectProperty(owl:topObjectProperty)) Declaration(Class(owl:Thing)) Declaration(AnnotationProperty(rdfs:isDefinedBy)) }
org.semanticweb.owlapi.model.UnloadableImportException: Could not load imported ontology: <http://www.w3.org/ns/prov-aq#> Cause: Ontology already exists. OntologyID(OntologyIRI(<http://www.w3.org/ns/prov#>) VersionIRI(<null>))

seems like <http://www.w3.org/ns/prov#> and <http://www.w3.org/ns/prov-aq#> should be the same and are not, or are the same and should not be....  The only mention of prov I see is in paml.ttl, and it refers to the first of the two IRIs.  I have no idea where the prov-aq one is coming from.

Trying to load paml.ttl into Protege gives me some different errors pertaining to provenance:
   INFO  17:17:45  Imported ontology document http://www.w3.org/ns/prov was not resolved to any documents defined in the ontology catalog.
   INFO  17:17:45  Notice: root element does not have an xml:base. Relative IRIs will be resolved against http://www.w3.org/ns/prov
   INFO  17:17:45  Imported ontology document http://www.w3.org/ns/prov-o# was not resolved to any documents defined in the ontology catalog.
   WARN  17:17:45  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#wasRevisionOf in punning not allowed [ObjectProperty: wasRevisionOf, AnnotationProperty: wasRevisionOf]
   WARN  17:17:45  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#specializationOf in punning not allowed [ObjectProperty: specializationOf, AnnotationProperty: specializationOf]
   INFO  17:17:45  Finished loading imported ontology at http://www.w3.org/ns/prov-o#
   INFO  17:17:45  Imported ontology document http://www.w3.org/ns/prov-o-inverses# was not resolved to any documents defined in the ontology catalog.
   INFO  17:17:45  Notice: root element does not have an xml:base. Relative IRIs will be resolved against http://www.w3.org/ns/prov-o-inverses#
   WARN  17:17:45  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#wasRevisionOf in punning not allowed [ObjectProperty: wasRevisionOf, AnnotationProperty: wasRevisionOf]
   WARN  17:17:45  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#specializationOf in punning not allowed [ObjectProperty: specializationOf, AnnotationProperty: specializationOf]
   INFO  17:17:45  Finished loading imported ontology at http://www.w3.org/ns/prov-o-inverses#
   INFO  17:17:45  Imported ontology document http://www.w3.org/ns/prov-aq# was not resolved to any documents defined in the ontology catalog.
   INFO  17:17:46  Notice: root element does not have an xml:base. Relative IRIs will be resolved against http://www.w3.org/ns/prov-aq#
   INFO  17:17:46  Finished loading imported ontology at http://www.w3.org/ns/prov-aq#
   INFO  17:17:46  Imported ontology document http://www.w3.org/ns/prov-dc# was not resolved to any documents defined in the ontology catalog.
   INFO  17:17:46  Notice: root element does not have an xml:base. Relative IRIs will be resolved against http://www.w3.org/ns/prov-dc#
   WARN  17:17:46  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#wasRevisionOf in punning not allowed [ObjectProperty: wasRevisionOf, AnnotationProperty: wasRevisionOf]
   WARN  17:17:46  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#specializationOf in punning not allowed [ObjectProperty: specializationOf, AnnotationProperty: specializationOf]
   INFO  17:17:46  Finished loading imported ontology at http://www.w3.org/ns/prov-dc#
   INFO  17:17:46  Imported ontology document http://www.w3.org/ns/prov-dictionary# was not resolved to any documents defined in the ontology catalog.
   INFO  17:17:46  Finished loading imported ontology at http://www.w3.org/ns/prov-dictionary#
   INFO  17:17:46  Imported ontology document http://www.w3.org/ns/prov-links# was not resolved to any documents defined in the ontology catalog.
   INFO  17:17:46  Notice: root element does not have an xml:base. Relative IRIs will be resolved against http://www.w3.org/ns/prov-links#
   WARN  17:17:46  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#wasRevisionOf in punning not allowed [ObjectProperty: wasRevisionOf, AnnotationProperty: wasRevisionOf]
   WARN  17:17:46  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#specializationOf in punning not allowed [ObjectProperty: specializationOf, AnnotationProperty: specializationOf]
   INFO  17:17:46  Finished loading imported ontology at http://www.w3.org/ns/prov-links#
   WARN  17:17:46  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#wasRevisionOf in punning not allowed [ObjectProperty: wasRevisionOf, AnnotationProperty: wasRevisionOf]
   WARN  17:17:46  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#specializationOf in punning not allowed [ObjectProperty: specializationOf, AnnotationProperty: specializationOf]
   INFO  17:17:46  Finished loading imported ontology at http://www.w3.org/ns/prov
   INFO  17:17:46  Unparsed triple: _:genid-nodeid-node1fhji47rcx21 -> http://www.w3.org/2002/07/owl#allValuesFrom -> http://www.w3.org/2001/XMLSchema#string
   WARN  17:17:46  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#wasRevisionOf in punning not allowed [ObjectProperty: wasRevisionOf, AnnotationProperty: wasRevisionOf]
   WARN  17:17:46  Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/prov#specializationOf in punning not allowed [ObjectProperty: specializationOf, AnnotationProperty: specializationOf]
   WARN  17:17:46  Annotation property domain axiom turned to data property domain after parsing. This could introduce errors if the original domain was an anonymous expression: http://bioprotocols.org/paml#mask is the new domain.

The "was not resolved to any documents defined in the ontology catalog" messages just mean that Protege pulled the remote copy instead of using a local copy (I think). The redeclarations warnings suggest that somewhere we are using provennace relations like wasRevisionOf somewhere that does not import the ontology, so that Protege initially assumes that these properties are annotations, and only later realizes they are object properties.  I don't know if this is related to some issue loading the provenance sub-ontologies.

WRT the Provenance ontology, this screen grab from the "Imported Ontologies" window of Protege looks odd, and perhaps problematic:

You'll see that the document Protege thinks corresponds to the provenance ontology as a whole is just the one for the provenance-dictionary.

See #61

Ugh.  Turns out that the provenance ontology is ill-formed OWL and this fact has been known since at least 2017.   Surprising that such an important one should be abandonware, though.

I think that last clears up all of the notes here, so closing.


fix(tabs): do not close if tabs are left

📃 Summary
close https://github.com/shortcuts/no-neck-pain.nvim/issues/370
we do not account for remaining tabs when determining if we should quit nvim or just disable the plugin

oh wow there must've been a bc on mini.test while I was off, lots of unrelated red


lastpass-cli: v1.3.6 -> v.1.6.0

Description of changes
Upgrade lastpass-cli to latest version v.1.6.0 and resume maintainership.
https://github.com/lastpass/lastpass-cli/releases/tag/v1.6.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 334703 run on x86_64-linux 1

1 package built:

lastpass-cli

Please use the commit conventions: https://github.com/NixOS/nixpkgs/tree/master/pkgs#commit-conventions

Thanks for the review. I've updated my commits and PR. Would you please have a look?

Result of nixpkgs-review pr 334703 run on x86_64-darwin 1

1 package built:

lastpass-cli

Please post here if no other member merges this in a timely manner (normally we have a second member merging):
https://discourse.nixos.org/t/prs-already-reviewed/2617/1919

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1922

The commit message should not contain the v prefix.


[Suggestion] Make links work

Hi!
I'm using your plugin and I would love it if you could make <a href="www.google.com" /> work! You could make it use Device.OpenUri("");
Thanks for the amazing plugin!
-Luca

For me, it works on iOS on simulators and devices but on the Android links do not work, I tested on the Android Emulator Nexus 5 (Android 7.1.1) and on the device Huawei P9 (Android 7.0)


test use of docker for CI

user docker images for creating exist-db instanced and running test.
Let's see if these are faster or not

depends on #18

:tada: This issue has been resolved in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Improve Index.of to also accept class files and JAR files

Any thoughts on a directory with jar files? Easily done by the client, but just for convenience.

I didn't have a need for that yet :-) The things I'm adding here are things I've frequently used over past months.

Just thinking of the situation "here's my app .jar and here's my lib/*.jar"

It could be useful, but I think I'll let anyone who actually has a use for it add it :-)


[Student View] Able to view the responses of CRUD for the modules on the study plan

Resolved with #92, #93, #94, #98, #99


Connecting to libvirt daemon failed:  /var/run/libvirt/virtqemud-soc

What happened:
{"component":"virt-launcher","level":"info","msg":"Collected all requested hook sidecar sockets","pos":"manager.go:88","timestamp":"2024-08-17T11:55:00.775925Z"}
{"component":"virt-launcher","level":"info","msg":"Sorted all collected sidecar sockets per hook point based on their priority and name: map[]","pos":"manager.go:91","timestamp":"2024-08-17T11:55:00.775975Z"}
{"component":"virt-launcher","level":"info","msg":"Connecting to libvirt daemon: qemu+unix:///session?socket=/var/run/libvirt/virtqemud-sock","pos":"libvirt.go:565","timestamp":"2024-08-17T11:55:00.776199Z"}
{"component":"virt-launcher","level":"info","msg":"Connecting to libvirt daemon failed: virError(Code=38, Domain=7, Message='Failed to connect socket to '/var/run/libvirt/virtqemud-sock': No such file or directory')","pos":"libvirt.go:573","timestamp":"2024-08-17T11:55:00.776583Z"}
{"component":"virt-launcher","level":"info","msg":"libvirt version: 9.5.0, package: 6.el9<EMAIL_ADDRESS>2023-08-25-08:53:56, )","subcomponent":"libvirt","thread":"43","timestamp":"2024-08-17T11:55:00.809000Z"}
{"component":"virt-launcher","level":"info","msg":"hostname: win10-test","subcomponent":"libvirt","thread":"43","timestamp":"2024-08-17T11:55:00.809000Z"}
{"component":"virt-launcher","level":"error","msg":"Unable to open /dev/kvm: Permission denied","pos":"virHostCPUGetCPUID:1422","subcomponent":"libvirt","thread":"43","timestamp":"2024-08-17T11:55:00.809000Z"}
{"component":"virt-launcher","level":"error","msg":"internal error: Unable to get session bus connection: Cannot spawn a message bus without a machine-id: Unable to load /var/lib/dbus/machine-id or /etc/machine-id: Failed to open file “/var/lib/dbus/machine-id”: No such file or directory","pos":"virGDBusGetSessionBus:126","subcomponent":"libvirt","thread":"43","timestamp":"2024-08-17T11:55:00.809000Z"}
{"component":"virt-launcher","level":"error","msg":"internal error: Unable to get system bus connection: Could not connect: No such file or directory","pos":"virGDBusGetSystemBus:99","subcomponent":"libvirt","thread":"43","timestamp":"2024-08-17T11:55:00.809000Z"}
{"component":"virt-launcher","level":"info","msg":"Connected to libvirt daemon","pos":"libvirt.go:581","timestamp":"2024-08-17T11:55:01.278418Z"}
{"component":"virt-launcher","level":"info","msg":"Registered libvirt event notify callback","pos":"client.go:563","timestamp":"2024-08-17T11:55:01.281830Z"}
{"component":"virt-launcher","level":"info","msg":"Marked as ready","pos":"virt-launcher.go:75","timestamp":"2024-08-17T11:55:01.281959Z"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Executing PreStartHook on VMI pod environment","name":"win10-test","namespace":"default","pos":"manager.go:684","timestamp":"2024-08-17T11:55:03.825948Z","uid":"c6ec80cb-06f0-41a1-bfc1-f08ae58002f8"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Starting PreCloudInitIso hook","name":"win10-test","namespace":"default","pos":"manager.go:705","timestamp":"2024-08-17T11:55:03.825984Z","uid":"c6ec80cb-06f0-41a1-bfc1-f08ae58002f8"}
{"component":"virt-launcher","level":"info","msg":"Found nameservers in /etc/resolv.conf: \ufffd\ufffd\u0019\n","pos":"network.go:171","timestamp":"2024-08-17T11:55:03.826660Z"}
{"component":"virt-launcher","level":"info","msg":"Found search domains in /etc/resolv.conf: default.svc.cluster.local svc.cluster.local cluster.local <IP_ADDRESS>","pos":"network.go:172","timestamp":"2024-08-17T11:55:03.826678Z"}
{"component":"virt-launcher","level":"info","msg":"Starting SingleClientDHCPServer","pos":"server.go:65","timestamp":"2024-08-17T11:55:03.826719Z"}
{"component":"virt-launcher","level":"error","msg":"failed to run DHCP Server: Search domain is not valid: '<IP_ADDRESS>'","pos":"common.go:192","timestamp":"2024-08-17T11:55:03.826789Z"}
panic: Search domain is not valid: '<IP_ADDRESS>'
{"component":"virt-launcher-monitor","level":"info","msg":"Reaped pid 12 with status 512","pos":"virt-launcher-monitor.go:198","timestamp":"2024-08-17T11:55:03.831925Z"}
{"component":"virt-launcher-monitor","level":"error","msg":"dirty virt-launcher shutdown: exit-code 2","pos":"virt-launcher-monitor.go:216","timestamp":"2024-08-17T11:55:03.832069Z"}
{"component":"virt-launcher","level":"info","msg":"Collected all requested hook sidecar sockets","pos":"manager.go:88","timestamp":"2024-08-17T11:55:00.775925Z"}
{"component":"virt-launcher","level":"info","msg":"Sorted all collected sidecar sockets per hook point based on their priority and name: map[]","pos":"manager.go:91","timestamp":"2024-08-17T11:55:00.775975Z"}
{"component":"virt-launcher","level":"info","msg":"Connecting to libvirt daemon: qemu+unix:///session?socket=/var/run/libvirt/virtqemud-sock","pos":"libvirt.go:565","timestamp":"2024-08-17T11:55:00.776199Z"}
{"component":"virt-launcher","level":"info","msg":"Connecting to libvirt daemon failed: virError(Code=38, Domain=7, Message='Failed to connect socket to '/var/run/libvirt/virtqemud-sock': No such file or directory')","pos":"libvirt.go:573","timestamp":"2024-08-17T11:55:00.776583Z"}
{"component":"virt-launcher","level":"info","msg":"libvirt version: 9.5.0, package: 6.el9<EMAIL_ADDRESS>2023-08-25-08:53:56, )","subcomponent":"libvirt","thread":"43","timestamp":"2024-08-17T11:55:00.809000Z"}
{"component":"virt-launcher","level":"info","msg":"hostname: win10-test","subcomponent":"libvirt","thread":"43","timestamp":"2024-08-17T11:55:00.809000Z"}
{"component":"virt-launcher","level":"error","msg":"Unable to open /dev/kvm: Permission denied","pos":"virHostCPUGetCPUID:1422","subcomponent":"libvirt","thread":"43","timestamp":"2024-08-17T11:55:00.809000Z"}
{"component":"virt-launcher","level":"error","msg":"internal error: Unable to get session bus connection: Cannot spawn a message bus without a machine-id: Unable to load /var/lib/dbus/machine-id or /etc/machine-id: Failed to open file “/var/lib/dbus/machine-id”: No such file or directory","pos":"virGDBusGetSessionBus:126","subcomponent":"libvirt","thread":"43","timestamp":"2024-08-17T11:55:00.809000Z"}
{"component":"virt-launcher","level":"error","msg":"internal error: Unable to get system bus connection: Could not connect: No such file or directory","pos":"virGDBusGetSystemBus:99","subcomponent":"libvirt","thread":"43","timestamp":"2024-08-17T11:55:00.809000Z"}
{"component":"virt-launcher","level":"info","msg":"Connected to libvirt daemon","pos":"libvirt.go:581","timestamp":"2024-08-17T11:55:01.278418Z"}
{"component":"virt-launcher","level":"info","msg":"Registered libvirt event notify callback","pos":"client.go:563","timestamp":"2024-08-17T11:55:01.281830Z"}
{"component":"virt-launcher","level":"info","msg":"Marked as ready","pos":"virt-launcher.go:75","timestamp":"2024-08-17T11:55:01.281959Z"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Executing PreStartHook on VMI pod environment","name":"win10-test","namespace":"default","pos":"manager.go:684","timestamp":"2024-08-17T11:55:03.825948Z","uid":"c6ec80cb-06f0-41a1-bfc1-f08ae58002f8"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Starting PreCloudInitIso hook","name":"win10-test","namespace":"default","pos":"manager.go:705","timestamp":"2024-08-17T11:55:03.825984Z","uid":"c6ec80cb-06f0-41a1-bfc1-f08ae58002f8"}
{"component":"virt-launcher","level":"info","msg":"Found nameservers in /etc/resolv.conf: \ufffd\ufffd\u0019\n","pos":"network.go:171","timestamp":"2024-08-17T11:55:03.826660Z"}
{"component":"virt-launcher","level":"info","msg":"Found search domains in /etc/resolv.conf: default.svc.cluster.local svc.cluster.local cluster.local <IP_ADDRESS>","pos":"network.go:172","timestamp":"2024-08-17T11:55:03.826678Z"}
{"component":"virt-launcher","level":"info","msg":"Starting SingleClientDHCPServer","pos":"server.go:65","timestamp":"2024-08-17T11:55:03.826719Z"}
{"component":"virt-launcher","level":"error","msg":"failed to run DHCP Server: Search domain is not valid: '<IP_ADDRESS>'","pos":"common.go:192","timestamp":"2024-08-17T11:55:03.826789Z"}
panic: Search domain is not valid: '<IP_ADDRESS>'
{"component":"virt-launcher-monitor","level":"info","msg":"Reaped pid 12 with status 512","pos":"virt-launcher-monitor.go:198","timestamp":"2024-08-17T11:55:03.831925Z"}
{"component":"virt-launcher-monitor","level":"error","msg":"dirty virt-launcher shutdown: exit-code 2","pos":"virt-launcher-monitor.go:216","timestamp":"2024-08-17T11:55:03.832069Z"}
Environment:

KubeVirt version (use virtctl version): 1.2.2
Kubernetes version (use kubectl version): 1.26.10
VM or VMI specifications: N/A
Cloud provider or hardware configuration: N/A
OS (e.g. from /etc/os-release): ubuntu 22.04
Kernel (e.g. uname -a): N/A
Install tools: N/A
Others: N/A

:"failed to detect VMI pod: dial unix //pods/5a09a32f-6c04-4542-ac96-a72ad644020f/volumes/kubernetes.io~empty-dir/sockets/launcher-sock: connect: connection refused","timestamp":"2024-08-17T15:31:59.305779Z","uid":"2c755b20-2e90-4a5c-9dfe-da4e85c7642c"}
{"component":"virt-handler","kind":"","level":"error","msg":"Could not get owner Pid of socket //pods/5a09a32f-6c04-4542-ac96-a72ad644020f/volumes/kubernetes.io~empty-dir/sockets/launcher-sock","name":"vm-cirros","namespace":"default","pos":"detector.go:93","reason":"dial unix //pods/5a09a32f-6c04-4542-ac96-a72ad644020f/volumes/kubernetes.io~empty-dir/sockets/launcher-sock: connect: connection refused","timestamp":"2024-08-17T15:31:59.975257Z","uid":"2c755b20-2e90-4a5c-9dfe-da4e85c7642c"}
{"component":"virt-handler","kind":"","level":"error","msg":"Synchronizing the VirtualMachineInstance failed.","name":"vm-cirros","namespace":"default","pos":"vm.go:1940","reason":"failed to detect VMI pod: dial unix //pods/5a09a32f-6c04-4542-ac96-a72ad644020f/volumes/kubernetes.io~empty-dir/sockets/launcher-sock: connect: connection refused","timestamp":"2024-08-17T15:31:59.975345Z","uid":"2c755b20-2e90-4a5c-9dfe-da4e85c7642c"}
{"component":"virt-handler","kind":"","level":"error","msg":"Could not get owner Pid of socket //pods/5a09a32f-6c04-4542-ac96-a72ad644020f/volumes/kubernetes.io~empty-dir/sockets/launcher-sock","name":"vm-cirros","namespace":"default","pos":"detector.go:93","reason":"dial unix //pods/5a09a32f-6c04-4542-ac96-a72ad644020f/volumes/kubernetes.io~empty-dir/sockets/launcher-sock: connect: connection refused","timestamp":"2024-08-17T15:32:01.287079Z","uid":"2c755b20-2e90-4a5c-9dfe-da4e85c7642c"}
{"component":"virt-handler","kind":"","level":"error","msg":"Synchronizing the VirtualMachineInstance failed.","name":"vm-cirros","namespace":"default","pos":"vm.go:1940","reason":"failed to detect VMI pod: dial unix //pods/5a09a32f-6c04-4542-ac96-a72ad644020f/volumes/kubernetes.io~empty-dir/sockets/launcher-sock: connect: connection refused","timestamp":"2024-08-17T15:32:01.287164Z","uid":"2c755b20-2e90-4a5c-9dfe-da4e85c7642c"}
{"component":"virt-handler","kind":"","level":"error","msg":"Could not get owner Pid of socket //pods/5a09a32f-6c04-4542-ac96-a72ad644020f/volumes/kubernetes.io~empty-dir/sockets/launcher-sock","name":"vm-cirros","namespace":"default","pos":"detector.go:93","reason":"dial unix //pods/5a09a32f-6c04-4542-ac96-a72ad644020f/volumes/kubernetes.io~empty-dir/sockets/launcher-sock: connect: connection refused","timestamp":"2024-08-17T15:32:03.879148Z","uid":"2c755b20-2e90-4a5c-9dfe-da4e85c7642c"}
{"component":"virt-handler","kind":"","level":"error","msg":"Synchronizing the VirtualMachineInstance failed.","name":"vm-cirros","namespace":"default","pos":"vm.go:1940","reason":"failed to detect VMI pod: dial unix //pods/5a09a32f-6c04-4542-ac96-a72ad644020f/volumes/kubernetes.io~empty-dir/sockets/launcher-sock: connect: connection refused","timestamp":"2024-08-17T15:32:03.879224Z","uid":"2c755b20-2e90-4a5c-9dfe-da4e85c7642c"}

Actually this looks like a configuration issue, see https://github.com/kubevirt/kubevirt/issues/3187
/close
Please reopen if you disagree.


Dependency conflict in stone & six

The version of 'stone' in my installation requires a version of 'six' that's equal to or greater than 1.12.0. Your requirements.txt has the 5 year old 1.11.0. Please consider bumping the version or creating laxer version requirements like a minimum version or a fixed major version.

Please make a pull request and I will accept it.
On Tue, Apr 19, 2022, 12:02 PM Mies van der Lippe @.***>
wrote:

The version of 'stone' in my installation requires a version of 'six'
that's equal to or greater than 1.12.0. Your requirements.txt has the 5
year old 1.11.0. Please consider bumping the version or creating laxer
version requirements like a minimum version or a fixed major version.
—
Reply to this email directly, view it on GitHub
https://github.com/koenbuyens/securityheaders/issues/11, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AECCSHELTGGXCPPM6S5URZTVF2ADNANCNFSM5TYJ27EA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Note to self: also include 'burp' in requirements.txt


Help to correct data errors

Help section for each data error should be extendable by users (i.e.: crowdsourced) via an easy interface (i.e.: github editor over markdown files)
Tasks

[ ] Add a help content folder to goodtables-web
[ ] each file in this folder corresponds with the ID of a result
[ ] each file in this folder editable via github editor
[ ] The main help page is auto generated from the list of available result types in goodtables. We now add the additional steps of:

[ ] resolving a help text from the available markdown files
[ ] Adding UI to encourage users to "edit this help section"

@rgrp I just realised a (big) disadvantage of having this data in the codebase: exposes code editing rights to anyone who we allow to edit the data. I know that the pull request pattern would negate this; not sure how easy that would be for non-tech users.

@pwalsh i would go for request pattern - they just have to fork and then PR. I'd live with that for the time being - we can revisit if a problem.


Object reference not set to an instance of an object Exception

Hi, I am getting an object reference exception using the static method Parse.
I set the DbPath to the json file (I had no trouble generating it successfully with the DbGen tool.
Any help is greatly appreciated.
"message": "Object reference not set to an instance of an object.",
"stackTrace": "     at GlobalPhone.Territory.Possible(String str)
   at GlobalPhone.Territory.ParseNationalString(String str)
   at GlobalPhone.Parsing.Parse(String str, String territoryName)
   at GlobalPhone.Context.Parse(String str, String territoryName)
   at GlobalPhone.GlobalPhone.Parse(String number, String territoryName)

I've added a branch where we can see the regression : https://github.com/GlobalPhone/GlobalPhone/tree/null_reference_exception

The issue looks like it's due to change of xml format in libphonenumber.
A quick-fix is to either download an old version of the xml and generate a new db from that or use something else. It looks like there is a stable c# port libphonenumber-csharp that could be used? It looks like @twcclegg puts a lot of effort into it. However, I've not tried out.

Thank you for the suggestion. The port works quite well.

Another alternative is to provide extension methods et.c. in order to give a nicer c# API for libphonenumber, see https://github.com/twcclegg/libphonenumber-csharp/issues/57#issuecomment-370910150


"Inferred object" error message needs to be more clear

What message did you have in mind?

Not sure yet, but something that better communicates to users of the library what is going on. @jsmestad pointed out that it's very difficult to understand what that message means when you get it.

I'll take a shot since I wrote that code (I did didn't I?)

Yea, i believe you did. Thanks d00d.


Expand copybooks

Optionally expand copybooks, with support for nested COPY statements and COPY REPLACING. This functionality was not included in the proof of concept but it is necessary in some circumstances. We consider it part of the initial functionality.

This was done in mid-December 2020. Don't know why it wasn't closed at that time.


There is a deck editing view, which allows users to change deck properties (name, public/private)

closed by https://github.com/sopra-fs22-group-10/client/commit/0afae4858bd0933a00b5587da09fbfc9d96d17bd


Infinite loop on Gauge#angleRangeProperty

If the angleRange property of a Gauge is changed when the Gauge is shown, the Gauge goes into an infinite loop between Gauge.calcAutoScale, Gauge.setMajorTickSpace, Gauge.fireUpdateEvent and GaugeSkin.registerListeners. So having created a Gauge gauge and a button angleRangeButton with angleRangeButton.setOnAction(e -> gauge.angleRangeProperty().set(90));, the button will cause the program to go into an infinite loop and crash with a stack overflow.
I've not been able to identify a workaround.

Yep I know that problem...did you try the GaugeBuilder?

Yep I know that problem...did you try the GaugeBuilder?

I'm just experimenting with Medusa at the moment. I built the gauge with
the builder (using your sample - I assume you already know the bugs in that
because it won't compile as it is!) and I'm trying out each property to get
a feel for what it does. I might have a nice little gauge demonstration
when I'm done, if you want a copy. So I've no actual requirement to change
the angleRange dynamically, I merely discovered that the feature was there
but didn't work.
On 1 January 2017 at 16:34, Gerrit Grunwald<EMAIL_ADDRESS>wrote:

Yep I know that problem...did you try the GaugeBuilder?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HanSolo/Medusa/issues/52#issuecomment-269909591, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEpiCIR39_1D7wtIAK4oJY2rMrLbBlPLks5rN9WqgaJpZM4LYuDz
.

--
Tim Rowe

I'm just experimenting with Medusa at the moment. I built the gauge with
the builder (using your sample - I assume you already know the bugs in that
because it won't compile as it is!) and I'm trying out each property to get
a feel for what it does. I might have a nice little gauge demonstration
when I'm done, if you want a copy. So I've no actual requirement to change
the angleRange dynamically, I merely discovered that the feature was there
but didn't work.
On 1 January 2017 at 16:34, Gerrit Grunwald<EMAIL_ADDRESS>wrote:

Yep I know that problem...did you try the GaugeBuilder?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HanSolo/Medusa/issues/52#issuecomment-269909591, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEpiCIR39_1D7wtIAK4oJY2rMrLbBlPLks5rN9WqgaJpZM4LYuDz
.

--
Tim Rowe

Yes, but that doesn't help in the dynamic case.

Yes, but that doesn't help in the dynamic case.

Great, you know it's just a fun side project of mine. So please file issues whenever you find something and if you need something special (e.g. special featured or designs) please let me know. I'm currently on vacation so it might take some time before I'll be able to fix the problems but keep filing... :)
Cheers, Gerrit

Great, you know it's just a fun side project of mine. So please file issues whenever you find something and if you need something special (e.g. special featured or designs) please let me know. I'm currently on vacation so it might take some time before I'll be able to fix the problems but keep filing... :)
Cheers, Gerrit

It's a fun project for me, too, so enjoy your vacation (and yes, I'll file
anything else I file).
On 1 January 2017 at 17:05, Gerrit Grunwald<EMAIL_ADDRESS>wrote:

Great, you know it's just a fun side project of mine. So please file
issues whenever you find something and if you need something special (e.g.
special featured or designs) please let me know. I'm currently on vacation
so it might take some time before I'll be able to fix the problems but keep
filing... :)
Cheers, Gerrit
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HanSolo/Medusa/issues/52#issuecomment-269910691, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEpiCFxneGIUnp5zXhBICJaA3drqM8aAks5rN9zagaJpZM4LYuDz
.

--
Tim Rowe

It's a fun project for me, too, so enjoy your vacation (and yes, I'll file
anything else I file).
On 1 January 2017 at 17:05, Gerrit Grunwald<EMAIL_ADDRESS>wrote:

Great, you know it's just a fun side project of mine. So please file
issues whenever you find something and if you need something special (e.g.
special featured or designs) please let me know. I'm currently on vacation
so it might take some time before I'll be able to fix the problems but keep
filing... :)
Cheers, Gerrit
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HanSolo/Medusa/issues/52#issuecomment-269910691, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEpiCFxneGIUnp5zXhBICJaA3drqM8aAks5rN9zagaJpZM4LYuDz
.

--
Tim Rowe

So I've made some adjustments and had no problems with setting the angleRange when the Gauge is shown using your button example. Could you give it a try again with the latest source?

The issue still seems to be present with the latest source. Demonstration program attached.
MedusaAngleRangeBug.zip

Ok, found the problem and now it works, thanx for reporting.


Add notebooks

Hi Morvan
I was doing your video tutorial these days and at the same time I created some notebooks, I think perhaps you want to have them in your code base as well? So people can see those output and plot directly github without running the code.
Such as this example:
https://github.com/liufuyang/PyTorch-Tutorial-1/blob/cdd6704b8632afc882aacd19681261d9fba0edc1/tutorial-contents-notebooks/401_CNN.ipynb
If you think it's not necessary, then just close this PR :)

I think it is necessary. Thank you.
Too busy recently, I'll try to do that once I get time.

@liufuyang Oh, I see, you did them all. That is a great help! I will merge it.

Thank you :)


Added effect name to JSON 'serverinfo' output in activeEffects

Please be lenient with me, because this is the first pull request i had ever made.
I have added a name property in the Effect class to make it possible to get the name of the active effect in the 'serverinfo' JSON command results. I wouldn't name it a feature, it's more a bugfix, because without these changes, it isn't easily possible to get the current effect and compare it with a list of available effects.
Output before changes:
{   'info': {   'activeEffects': [   {   'args': {   'blobs': 5,
                                                     'color': [0, 255, 0],
                                                     'hueChange': 60.0,
                                                     'reverse': False,
                                                     'rotationTime': 60.0},
                                         'priority': 100,
                                         'script': '/root/hyperion/effects//mood-blobs.py',
                                         'timeout': 0}],
                'activeLedColor': [],
                'adjustment': [   {   'blueAdjust': [0, 0, 255],
                                      'greenAdjust': [0, 255, 0],
                                      'id': 'default',
...

Output after my changes:
{   'info': {   'activeEffects': [   {   'args': {   'blobs': 5,
                                                     'color': [0, 255, 0],
                                                     'hueChange': 60.0,
                                                     'reverse': False,
                                                     'rotationTime': 60.0},
                                         'name': 'Green mood blobs',
                                         'priority': 100,
                                         'script': '/root/hyperion/effects//mood-blobs.py',
                                         'timeout': 0}],
                'activeLedColor': [],
                'adjustment': [   {   'blueAdjust': [0, 0, 255],
                                      'greenAdjust': [0, 255, 0],
                                      'id': 'default',
...

Please note that the 'name' property of the active effect is now available in the JSON result of the 'serverinfo' command.
I think this fix was requested in this issue: #548

Sorry for the delay, change looks good and merging 👍


Breaking change in Websocket 6.0 release

Hi,
Just pipenv installed sanic and it pulled down the new websocket 6.0 release. Making a simple websocket server will now throw a AttributeError on connection of a websocket client.
Here's a simple websocket sanic app along with the stack trace.
from sanic import Sanic

app = Sanic()

@app.websocket('/feed')
async def feed(request, ws):
    while True:
        data = 'hello!'
        print('Sending: ' + data)
        await ws.send(data)
        data = await ws.recv()
        print('Received: ' + data)

if __name__ == "__main__":
    app.run(host="<IP_ADDRESS>", port=8000)

Here's the stack trace produced:
[2018-07-18 11:39:04 +0100] [63160] [INFO] Goin' Fast @ http://<IP_ADDRESS>:8000
[2018-07-18 11:39:04 +0100] [63160] [INFO] Starting worker [63160]
[2018-07-18 11:39:06 +0100] [63160] [ERROR] Traceback (most recent call last):
  File "venv/lib/python3.7/site-packages/sanic/app.py", line 556, in handle_request
    response = await response
  File "venv/lib/python3.7/site-packages/sanic/app.py", line 259, in websocket_handler
    ws = await protocol.websocket_handshake(request, subprotocols)
  File "venv/lib/python3.7/site-packages/sanic/websocket.py", line 63, in websocket_handshake
    key = handshake.check_request(get_header)
  File "venv/lib/python3.7/site-packages/websockets/handshake.py", line 83, in check_request
    connection = parse_connection(headers.get('Connection', ''))
AttributeError: 'function' object has no attribute 'get'

[2018-07-18 11:39:06 +0100] - (sanic.access)[INFO][1:2]: GET ws://<IP_ADDRESS>:8000/feed  500 144

I can confirm this as well. I have an instance that is running websockets==5.0.1 that works fine. When websockets is upgraded to 6.0, I get the same exception.

Looks like this has already been picked up by someone on master, though on the latest 7.0 release those checks are missing.
So this might be worth cherry picking those requirements into a point release to prevent those newly pip installing from getting a version of sanic with broken websockets, until sanic is updated to play nice with websockets>=6.0.

Equally, ran across some more things that may help others. pytest-sanic also has a related issue around Sanic's websockets. Which requires to have websockets<5 instead of websockets<=6.
websockets 4.x also uses async in its code which also makes it incompatible with Python 3.7's upgrade of async to a keyword. So currently I'm running this setup:
# Pipfile
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
sanic = "*"
websockets = "<5.0"  # Sanic breaks on 6.0, pytest-sanic breaks on 5.0

[dev-packages]
pytest-sanic = "*"

[requires]
python_version = "3.6"  # websockets 4.0 uses async keyword from python 3.7

I was able to get sanic master + websockets 6 to allow websocket connections with some small tweaks to sanic/websockets.py.

the solution of james9837 worked for me!

will this fixed be merge to the version ?

I spent my weekend rebuilding my phone websocket gateway to run in websockets alone scraping sanic. It was not fun, but necessary because of this.

@rubik I'm not a sanic project owner or collaborator. I can't do releases. People have been wanting a new release to for months. Nothing I can do about it.

@garyo I appreciate that... but for a variety of reasons it's not an option for us.

@ashleysommer Sorry, I was mistaken. Can we ping @r0fls then?

@ahopkins Im replying to your comment in this thread: https://github.com/channelcat/sanic/issues/1245#issuecomment-413761378
I have the same issue at my workplace.
Inspired by this, a few weeks ago I created a new project.
https://github.com/ashleysommer/pynecktie
PyNecktie is serious Sanic for serious business. It literally just relies on Sanic master, and inherits and extends every class with new names to make it look like its not Sanic. It has its own small test suite to ensure it is working correctly. Its aimed at devs who want to pitch this tool to their boss for use in an upcoming project, while hopefully avoiding the stigma of Sanic. It advertises it self as a "High Performance Python 3 Microservices Framework" rather than a HTTP server in an attempt to appeal to a non-tech-savvy audience.
The project is still in its infancy, I did have it pinned to<EMAIL_ADDRESS>but but yesterday I rebased it to sanic@master, and fixed a bunch of issues.
I intend to release regularly, whenever new features or fixes are added to Sanic.

@ashleysommer looks awesome... I had even toyed with the idea of doing something similar. Checking it out now!

I'm using python 3.7 for my project, and I want to use both sanic and websockets(for the websocket client). Problem is, pre-6.0 websockets client breaks in 3.7, so I need the 6.0 version. So I guess I can't use sanic(or use something else for the websocket client) until the next release.

This is addressed in PR#1304

Closing this with the merge of #1304

I can confirm problem persists with Python 3.7 and 3.6. I temporarily fixed the issue by downgrading websockets to websockets==6.0

The problem should not exist in 0.8.3 or 18.12LTS, can you provide example code you're using, along with platform so that I can test and verify?


Parse RPT series without document sequence numbers

closes #101

@mico ah you're right. Don't know why I got sent to another document. In this case it is a report without a report number...

@mico please help merge. Thanks!


Fix: Q77（README-zh_CN.md）& Need Help

const sum = (a, b) => a + b
// this is not a pure function, in some case, it could have side effects.

Lint to issue: https://github.com/lydiahallie/javascript-questions/issues/369
Need help: translate to english

嘤嘤嘤


Add additional questions and answers to FAQ on About us page

Adding the additional text from the CCIDI One Pager to fill out the FAQ section.
One-Pager Text
┆Issue is synchronized with this Trello card by Unito

text to copy&paste https://docs.google.com/document/d/1Bw7zHDSaKWcpX9VbhocQmGKPM75hhyRZQq3xv6QqXaQ/edit


Feature Request: New Device approval

As middle ground, between only privileged users creating devices or allowing all users to create devices, another option would be a big help:
Allowing devices to be created by unprivileged users, but those devices are disabled until approval by a privileged user.

Thanks for the suggestion! Things are in flux at the moment as we work to build our own platform apps, and I imagine this may be better managed in another way then.

For us we probably won't be able to use the platform apps since I'm assuming we are not a typically setup. Our WireGuard clients are chromebooks, and for paranoia we are restricting the portal with our own Nginx proxy to authenticate first with client ssl certs if the vpn isn't engaged.

Closing in favor of #1329.


unsupported operand type(s) for *: 'NoneType' and 'float'

Hey @Natgho, would you be able to add steps to reproduce the issue please? Never seen this one.

I'm also experiencing this error, it seems to be here: https://github.com/Tijani-Dia/dj-tracker/blob/b600d7de58931c541ce529d404f107234bef545d/src/dj_tracker/models.py#L142
I'm guessing because average_duration is None (e.g. null=True on its field allowing this). There needs to be some kind of check before passing this into the round function @Tijani-Dia (happy to provide a PR for this)

I think you're right @charliemday. A PR would be very welcome.


Tests failing 2024-10-21

For two different reasons:
Leak check is failing with
In file included from v8go.cc:5:
In file included from ./v8go.h:10:
In file included from ./deps/include/v8-profiler.h:15:
In file included from ./deps/include/v8-local-handle.h:13:
In file included from ./deps/include/v8-handle-base.h:8:
./deps/include/v8-internal.h:1433:28: error: missing 'typename' prior to dependent type name 'Iterator::iterator_concept'
./deps/include/v8-internal.h:[14](https://github.com/tommie/v8go/actions/runs/11448462621/job/31852033612#step:5:15)46:28: error: missing 'typename' prior to dependent type name 'std::iterator_traits<Iterator>::iterator_concept'

which seems related to https://chromium-review.googlesource.com/c/v8/v8/+/5774729. So this is fine on 24.04, but not 22.04? Makes no sense.
Test is failing with
type-parser.cc:(.text._ZN2v88internal8compiler10turboshaft10TypeParser9ParseTypeEv+0x7b2): undefined reference to `__isoc23_strtoul'
/usr/bin/ld: type-parser.cc:(.text._ZN2v88internal8compiler10turboshaft10TypeParser9ParseTypeEv+0xadb): undefined reference to `__isoc23_strtoull'

Probably because ubuntu-latest was reverted back to ubuntu-22.04, so the static lib was built on 24.04, and tests are running on 22.04.
What a mess.

The link issue worked out after libv8 was rebuilt.

Leakcheck uses clang++, so that's why the normal test runs pass.

Reply from pkasting on https://chromium-review.googlesource.com/c/v8/v8/+/5774729 that this is likely due to an old Clang (15) and that he'll add typename.
Given how long it took for V8 changes to propagate to Chromium stable last time, perhaps I should patch this for now.

Leakcheck passes. https://chromium-review.googlesource.com/c/v8/v8/+/5957255

v8 is currently at ~Oct 14 cutoff, Peter's fixes were in on Oct 24.
Ccache does its job, reducing a 3h build to 30m. But since releases are normally ~2w apart, the 1w cache retention at GitHub means we rarely get to use it.


log display incomplete

Describe the bug
A clear and concise description of what the bug is.
log display incomplete;I have conducted a large number of transactions, but can only retrieve a small portion
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
See error
/tradelog
Expected behavior
A clear and concise description of what you expected to happen.
I can turn the page or do something else
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
Discord contact: #

The log command has been moved to TradeAudit. Please implement your own SQL queries for individual calculations.


pagination format

Hello @chingor13 ,
according to last spec
The page query parameter is reserved for pagination.
Servers and clients SHOULD use this key for pagination operations.

And
For example, a page-based strategy might use query parameters such as page[number]
and page[size], an offset-based strategy might use page[offset] and page[limit],
while a cursor-based strategy might use page[cursor].

Do you have plans to support it ?

Yes, when I was doing the updates for RC3, there was no guidance/spec for what the pagination params should look like. I didn't have time to actively make changes along with each version. It does look like they just finalized 1.0, so I will get back to working on matching that spec

@chingor13 , sounds good, we all are looking forward for stable 1.0 complied ruby gem


Update error-severity-transact-sql.md

Text revisions to tighten and optimize the reading flow of the material. I deleted a duplicated SQL Server example.

@fbsolo : Thanks for your contribution! The author, @edmacauley, has been notified to review your proposed change.

Thanks @fbsolo #sign-off


Adds support for Astar and Fuse

Description
Adds support for Astar and Fuse chain.
How to test
Same as other EVM chains
Types of changes

Checklist

[x] Create pull request as draft initially, unless its complete.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

[x] I have read the guidelines for adding a new blockchain.

Any good to add those two?

Yes @hewigovens
You can check out Fuse and Astar on DefiLama.

Let's revisit this later


Move readme to index

Pull request checklist

[x] Did you bump the project version?
[x] Did you add a description to the Pull Request?
[ ] Did you add new tests?
[ ] Did you add reviewers?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.78%. Comparing base (e95995e) to head (f4d615b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   71.78%   71.78%
=======================================
  Files          24       24
  Lines        1056     1056
=======================================
  Hits          758      758
  Misses        298      298

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


RecycleView should not use a global cache

I'm getting weird errors in my application because I use many recycleviews with similar data structures (dict names etc match), and sometimes a 'wrong' cached view is picked up.
Problem happens within the same view, but is especially jarring when two different views start interfering with each other.
I'd like the cache to be owned by each instance of recycleview (is there really much need for multiple instances to access the same cache?), at least optionally. As for the picking up of 'wrong' views (yes I've checked to make sure dict values don't overlap) I'll just have to do more debugging, hard to identify the root cause.

I guess there's no real reason to make it global. That may also fix your view mixup.

Unfortunately I do get view mixups even with only one recycleview, so I doubt it would fix it totally (may get better). Still investigating that, really.

@matham are you the point person for Recycleview? Am imagining some changes which could be useful for my own project, and would like to run them by someone who can comment on whether its worth the effort to modify Recycleview itself rather than just subclassing for my own use (which I've already started doing). Especially in terms of roadmap for how recycleview will look like, feature set, etc.

See https://github.com/kivy/kivy/issues/5913.


Mongoose runs array-level validators on the array and its elements

var mongoose = require('mongoose');
var Schema = mongoose.Schema;

mongoose.connect('localhost');

var A = new Schema({str: String});
var B = new Schema({a: [A]});
B.path('a').validate(function(val, next) {
  console.log('val', val);
  next();
});

var b = mongoose.model('b', B);

var p = new b;
p.a.push({str: 'asdf'});
p.save();

If you run this code, you'll see that the validator is called twice.  Once with the entire array as val, and once for each element in the array.
I'm not sure which one is the intended behavior (it used to just run on the whole array), but it certainly shouldn't be both.

Hmm is this in master?

@vkarpov15  Yes this is happening in the latest version of master.


Potential synchronization issue for accessing driving_mode_ of VehicleController in canbus module

Describe the bug
Here is the code snippet:
ErrorCode VehicleController::SetDrivingMode(
    const Chassis::DrivingMode &driving_mode) {
  ...
  // vehicle in emergency mode only response to manual mode to reset.
  if (driving_mode_ == Chassis::EMERGENCY_MODE &&
      driving_mode != Chassis::COMPLETE_MANUAL) {
    AINFO
        << "Vehicle in EMERGENCY_MODE, only response to COMPLETE_MANUAL mode.";
    AINFO << "Only response to RESET ACTION.";
    return ErrorCode::CANBUS_ERROR;
  }

  // if current mode is same as previous, no need to set.
  if (driving_mode_ == driving_mode) {
    return ErrorCode::OK;
  }
  ...
  return ErrorCode::OK;
}

Here the member variable driving_mode_ is accessed directly.  However, inside SecurityDogThreadFunc() for each specific vehicle controller, this member variable driving_model_ can be changed if Emergecy() is called.
void LincolnController::Emergency() {
  set_driving_mode(Chassis::EMERGENCY_MODE);
  ResetProtocol();
  if (chassis_error_code() == Chassis::NO_ERROR) {
    set_chassis_error_code(Chassis::CHASSIS_ERROR);
  }
}

Solution: it should call VehicleController::driving_mode() to access the variable since it is mutex guarded as the following:
Chassis::DrivingMode VehicleController::driving_mode() {
  std::lock_guard<std::mutex> lock(mode_mutex_);
  return driving_mode_;
}

Do you mind submitting a pull request for the fix you suggest?


revision add-on config is not read from disk

fixed, required a FeatureConfig and Producer to tie in with CDI configuration system.


Implement repN and repExactN

Implement repN and repExactN instances that collect either (N or more) or N instances of the given parser, by analogy with rep, rep1

Let's merge this into #27, which is more general


Can't use Swashbuckle.AspNetCore.Cli with SwaggerHostFactory to generate swagger.json correctly in Asp.net 6 without Startup class

@domaindrivendev,
I am trying to use Swashbuckle.AspNetCore.Cli and SwaggerHostFactory to generate swagger.json.
The generated swagger.json always empty for path and compoments, which is strange.
I used the new host model without startup to create host.
public class SwaggerHostFactory
{
    public static IHost CreateHost()
    {
        var builder = WebApplication.CreateBuilder();
        builder.Services.AddControllers();
        builder.Services.AddEndpointsApiExplorer();
        builder.Services.AddSwaggerGen();

        var app = builder.Build();
        if (app.Environment.IsDevelopment())
        {
            app.UseSwagger();
            app.UseSwaggerUI();
        }
        app.UseHttpsRedirection();
        app.UseAuthorization();
        app.MapControllers();
        return app;
    }
}

As you can see the path is empty.
{
  "openapi": "3.0.1",
  "info": {
    "title": "dotnet-swagger",
    "version": "1.0"
  },
  "paths": { },
  "components": { }
}

But if I used the old style with Startup from SwaggerHostFactory and it worked fine. Feels like it is a bug.

Can you test if DotSwashbuckle solves this issue?

Duplicate of #2290


Would be nice to be able to set base headers for all requests

Heya thanks for this lib, I'm currently using qwest in my React data framework Trux and it's quite good!
One thing I was thinking was it would be nice to be able to set a base headers object that will get used for all requests. The reason for this is if you are integrating the requests with an API of some sort, it becomes troublesome to set the headers for every request with your authorisation header if its required. I guess what I'm proposing is something similar to jQuery's $.ajaxSetup method.

It's an interesting option to implement! I'm planning it for the next release ;)

Awesome!

Also being able to set the responseType for all requests would be good too!

:+1:

Fixed with latest release


Cask request: Screencast

Cask details
(Please fill out as much as possible)
Name - Screencast
Homepage - https://github.com/soh335/Screencast
License - unlicensed
Download URL - https://github.com/soh335/Screencast/releases/download/0.0.4/Screencast.dmg
Description -

https://github.com/caskroom/homebrew-cask/pull/24612


Add ouiaId for create topic

Which issue the PR resolves
https://issues.redhat.com/browse/MGDSTRM-8695

The changes look good. I made a small change to the "card-controlplanetable" ... please change this to "card-table" instead.


Property path as Object

How do you feel about letting propertyPath be an Object?
// Source Object
var collection = {
  foo: {
    bar: {
      baz: 'qux',
      asdf: 'qwerty'
    }
  }
};

_.deepGet(collection, {
  foo: {
    bar: {
      baz: 'localBazName',
      asdf: 'localAsdfName',
      wat: 'localWatName'
    }
  }
});

Result:
{
  "localBazName": "qux",
  "localAsdfName": "qwerty",
  "wat": undefined
}

I don't think this makes much sense. If you would want this you could write your own mixin to support this.

Yeah, that's essentially what I did. Thanks!


Need step by step documentation on how to run AzOps using Azure Pipelines

Hi Team,
I followed the AzOps wiki (https://github.com/azure/azops/wiki/azure-pipelines ) where most of the content is about the configurations of pipelines .
Can you please guide or add step by step document on how to use and run the pipelines ?
Which pipeline needs to run first and and how to observe changes and do modifications so that it will help to try this AzOps

Couple of links that might help @sssangle .
I have (scripted)[https://github.com/Gordonby/Snippets/blob/master/EntScale/Prepare-ADO-Project.sh] that entire setup using the az devops cli. It creates a new project, does almost all the config, and uses the Multi Environment sample, and it leverages the new Verify workflow that's super cool. 🚀

@Gordonby : The configuration part is mostly clear with the wiki document (https://github.com/azure/azops/wiki/azure-pipelines ) but after that need step which pipeline should triggered first to get the current Azure state and which pipeline to run for modifications. In configurations and wiki document only 2 pipelines are mentioned (Pull and Push) and nothing mentioned about validate pipeline . I am looking for steps on how to start after configuration complete


[QUESTIONS] syntastic: python pylint checkers

Is it allowed to use two customized configuration files ?

Is it possible to use two checkers with the same name?

Imagine this:
I have the following configuration in my .vimrc file
1256 let g:syntastic_debug = 1
1257 let g:syntastic_debug_file ="~/syntastic.log"
1258 :filetype on
1259 let g:syntastic_quiet_messages = { "level": "errors", "type": "style"}
1260 let g:syntastic_python_pylint_quiet_messages = { "level" : []  }
1261 let g:syntastic_aggregate_errors = 1
1262 let g:syntastic_python_checkers = ['pylint', 'flake8']
1263 let s:args = [
1264     \ '--rcfile=/.repo_requirements/linit_hook/travis/cfg/travis_run_pylint_pr.cfg',
1265     \ '--rcfile=/.repo_requirements/linit_hook/travis/cfg/travis_run_pylint.cfg'
1266     \ ]
1267 for s:file in s:args
1268     let g:syntastic_python_pylint_args = s:args[s:file]
1269 endfor

The problem is that I have to use both configuration files travis_run_pylint_pr.cfg and travis_run_pylint_pr.cfg to display the errors. But the first file has all the native pylint checks disabled and another customized checks enabled. The second file has some native pylint checks disabled not all.
So, when I tried with the code above (using the for) only the checks for the first file are displayed, but I need both config file's checks.
This is the result after debugging:
Messages maintainer: Bram Moolenaar<EMAIL_ADDRESS>"create_csv_file.py" 422L, 19484C
"create_csv_file.py" 422L, 19484C written
syntastic: 16.415497: &shell = '/bin/sh' (!), &shellcmdflag = '-c', &shellpipe =
 '2>&1| tee', &shellquote = '', &shellredir = '>%s 2>&1', &shellslash = 0, &shel
ltemp = 1, &shellxquote = '', &shellxescape = ''
syntastic: 16.416261: UpdateErrors (auto): default checkers
syntastic: 16.416650: CacheErrors: default checkers
syntastic: 16.417725: g:syntastic_aggregate_errors = 1
syntastic: 16.417952: getcwd() = '/root/build/projects/repo/module
/wizard'
syntastic: 17.109837: system: command run in 0.663365s
syntastic: 17.110635: CacheErrors: Invoking checker: python/pylint
syntastic: 17.111873: SyntasticMake: called with options: {'errorformat': '%A%f:
%l:%c:%t: %m,%A%f:%l: %m,%A%f:(%l): %m,%-Z%p^%.%#,%-G%.%#', 'makeprg': 'pylint -
-rcfile=/.repo_requirements/linit_hook/travis/cfg/travis_run_pylint_pr.cfg --loa
d-plugins=pylint_odoo -e all -f text --msg-template="{path}:{line}:{column}:{C}:
 [{symbol}] {msg}" -r n create_csv_file.py', 'env': {'TERM': 'dumb'}, 'returns':
 [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21,
22, 23, 24, 25, 26, 27, 28, 29, 30, 31]}
syntastic: 19.636474: system: command run in 2.523660s
syntastic: 19.638766: getLocList: checker python/pylint returned 30
syntastic: 19.639793: getLocList: checker python/pylint run in 2.528851s
syntastic: 19.641128: CacheErrors: Invoking checker: python/flake8
syntastic: 19.642302: SyntasticMake: called with options: {'errorformat': '%E%f:
%l: could not compile,%-Z%p^,%A%f:%l:%c: %t%n %m,%A%f:%l: %t%n %m,%-G%.%#', 'mak
eprg': 'flake8 create_csv_file.py', 'env': {'TERM': 'dumb'}}
syntastic: 20.335433: system: command run in 0.692423s
syntastic: 20.336262: getLocList: checker python/flake8 returned 0
syntastic: 20.337127: getLocList: checker python/flake8 run in 0.695645s

As you can see SyntasticMake only takes in account the first pylint config file.
I tried naming it equally but is the same result:
let g:syntastic_python_pylint_args =
    \ '--rcfile=/.repo_requirements/linit_hook/travis/cfg/travis_run_pylint_pr.cfg'

let g:syntastic_python_pylint_args =
    \ '--rcfile=/.repo_requirements/linit_hook/travis/cfg/travis_run_pylint.cfg'

Could you guide me to make this work? What I can do to use both files?
Thanks in advance.

Is it allowed to use two customized configuration files ?

Yes, just not at the same time.

Is it possible to use two checkers with the same name?

No.  There is only one checker, and it runs pylint with the set of options you give it.  You can set g:syntastic_python_pylint_args to load a config file, run the checker, and fix any problems.  Then set it to load the other config file, run the checker again, and fix any problems again.  Just as humans can't do two things at the same time, neither can Vim.

let g:syntastic_quiet_messages = { "level": "errors", "type": "style"}

I strongly suspect you don't want this.  It kills all errors, and all style errors and warnings.  It doesn't kill just style errors.

Hi @lcd047
How can I set the first file in args, run the checker and after that, set the second file in args and run it again? I appreciate a good example, because my problem is if I pass the config file value into let g: syntasitic_python_pylint_args the checker only reconizes the first value that find with that name, it means that the checker use the first config file, but it never run the checker again with the second file.
I'll take a look about the piece code that quiet the errores, ;) thanks. It was a PoC
So, could you help me again please? :)

let g:syntastic_python_pylint_args = '--rcfile=/.repo_requirements/linit_hook/travis/cfg/travis_run_pylint_pr.cfg'
:SyntasticCheck
fix some / all problems reported by 2.
let g:syntastic_python_pylint_args = '--rcfile=/.repo_requirements/linit_hook/travis/cfg/travis_run_pylint.cfg'
:SyntasticCheck
fix some / all problems reported by 5.

@lcd047 With :SyntasticCheck you  run the checker manually into vim. There is a way to run it the checker automatically, e.g. when you save the file, displays the first config file errors. And then it run with the second file and displays the errors of the second file.

You can replace :SyntasticCheck with :w at 2. and 5. above.
If you want some command that would bring together in the same list the errors from 2. and 5., then no, there is no such thing.  Such a feature could be added, with some refactoring of the core.  But that won't happen in the near future, there are other, more urgent things to fix first.

Thanks @lcd047 it will be nice a new feature to allow this.
Regards.

As I said, it isn't completely trivial, and it won't happen for a while.  Sorry about that.


[Bug]: Infrastructure lint failed

Contact Details
<EMAIL_ADDRESS>What happened?
invalid path iac
Service Type
Pipeline
Relevant log output
No response

resolved