Change networkErrorPolicy

Be permissive in case of MuxBearerClosed && IOExceptions (during read
/ write operations).
The change is well explained in the code.  Currently, when a remote peer is not interested in our chain it will close the connection and the node shuts down connection to the peer for 20s - not long but there's no need to do that at all.

In this case the remote node will only suspend its consumer.  The consensus error policy is here

In this case the remote node will only suspend its consumer. The consensus error policy is here.

Consensus has consumer and producer running on different ports, so they are in effect different peers.

That's true for now, but in the future this might not be the case any more.

I think you're not right: we bind the address and the PeerState is per address not per connection: so both inbound and outbound connections for that remote peer will use the same key in PeerStates map.

That's true for now, but in the future this might not be the case any more.

I know, since I'm very much working on that. :)
https://github.com/input-output-hk/ouroboros-network/tree/karknu/i_and_r
https://github.com/input-output-hk/ouroboros-network/tree/karknu/mux_lazy

I think you're not right: we bind the address and the PeerState is per address not per connection: so both inbound and outbound connections for that remote peer will use the same key in PeerStates map.

The subscription worker is run with port 0, so will get a free ephemeral port. The server will bind to the configured port number.
However in the future they will use the same port number, see the karknu/i_and_r branch.

You're right then :).  Is there a reason why we're not binding to the actual port?
Still this change will protect us in the future.  I'll update the comment though.

You're right then :). Is there a reason why we're not binding to the actual port?
We do bind to the ephemeral port too, sorry I should have made that clear.


Error in "/api/v1/forget" endpoint

The message that recieved in mail doesn't have username and it's email and the link of reset password button is invalid.

I have fixed this issue by adding the following two lines to the main.py file.
        message_body = message_body.replace("__EMAIL__", user_email)
        message_body = message_body.replace("__FIRST_NAME__", first_name)


Allow installing into cluster

[x] Hide cluster list, be able to work without kubeconfig
[x] Hide power-off
[ ] View-only flag in values with proper permissions
[ ] Persistent volume to store the cache, list of repos etc
[ ] A process to build and publish container image, mind multi-arch for Macs
[ ] A process to publish the chart into repo
[ ] Documentation page with details

@undera
Is it possible for me to contribute to this PR?


split_axis.backward fails on incomplete gradients

When there is a None in the grad_outputs, split_axis fails to backprop the incomplete gradients.

minimum reproducing example:
import chainer
from chainer import cuda
import chainer.functions as F
from chainer import optimizers
import numpy as np

xs = chainer.Variable(np.array([i for i in range(100)],dtype=np.float32))
_, smaller, _ = F.split_axis(xs, [24,47], axis=0)
smaller.backward()

result:
$ python split.py
Traceback (most recent call last):
  File "split.py", line 11, in <module>
    smaller.backward()
  File "build/bdist.linux-x86_64/egg/chainer/variable.py", line 189, in backward
  File "build/bdist.linux-x86_64/egg/chainer/function.py", line 317, in backward
  File "build/bdist.linux-x86_64/egg/chainer/functions/split_axis.py", line 88, in backward_cpu
ValueError: zero-dimensional arrays cannot be concatenated


cycles third coin is a frame-perfect input

Describe the bug
title
How to reproduce
go to where the third coin is and try to collect it (it's a frame-perfect input so good luck doing it without savestates/rewind)
Screenshots e/o videos
https://github.com/famidash/famidash/assets/140995410/517c862d-d886-4423-85dd-1aa46f951a9f
Emulator(please complete the following information):

Device: [e.g. PC, Phone]: samsung laptop from 2013 / everdrive n8 pro on real famicom hardware
Emulator [e.g. RetroArch, Mesen]: mesen
Core [ONLY if you use RetroArch]:

I can hit it pretty consistently...skill issue
https://github.com/famidash/famidash/assets/95717282/ec740555-c04a-4384-9797-49680288e058


Run as root by default on Linux

Proposed Change

In order to support reading log files out of the box, we need the collector to run as the root user on Linux. The observiq-otel-collector does not have permission to read arbitrary log files. For example: Elasticsearch, Mongodb, Mysql, Nginx, Postgres, Rabbitmq, and redis are all owned by different users.
Changes

Updated systemd unit file to use root user
Updated post install script to configure the log file permissions

The logger will not modify permissions. If the file does not exist, the log file will be owned by root. We want to pre configure the permissions in order to allow users to switch to the observiq-otel-collector user.

Updated linux doc to reflect these changes, and documented the process to switching to the unprivileged user.

I have tested the following

Fresh install Runs as root
Upgrades from v1.0.0 switch from oiq user to root user
Documented systemd override procedure works (switching to unprivileged user)
Log file rotates and maintains it's permissions (owned by observiq-otel-collector user)
Manager config maintains its permissions (owned by observiq-otel-collector user) after being re-written by opamp.

Checklist

[x] Changes are tested
[ ] CI has passed

Please hold off merging this until we reconcile discussion with product.


⚠ Bofrost.fr has degraded performance

In 12885a6, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1039 ms

Resolved: Bofrost.fr performance has improved in e59f983 after 6 minutes.


Download go modules before building

Fixes #14
Since go 1.16 build no longer  updates go.sum and so we get errors such as:
go<EMAIL_ADDRESS>missing go.sum entry; to add it:\n\tgo mod download github.com/open-telemetry/opentelemetry-collector-contrib/processor/routingprocessor\n"

This change runs go mod download to update go sum before the compile

I've reverted the version changes from this pull request but hope it doesn't revert them in main when merged. Not sure why by branch had these changes in as I branched from a previous commit

It will revert the ones from the main branch :-)


Change tab indented keywords to space indented in package.json

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   90.17%   90.17%
=======================================
  Files          22       22
  Lines         784      784
=======================================
  Hits          707      707
  Misses         77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa5b28...332c21d. Read the comment docs.

Thank you !!1


Nodes created outside C# can become null within C#

Godot version
4.0_beta16
System information
Windows 10
Issue description
Certain node types when created within GDScript, or as part of the Editor (presumably C++), turn into nulls when passed to C#. This includes HTTPRequests, GpuParticles2D, and presumably certain other types.
Somewhat notably, this includes calls from C# to GetChildren(), which can be a trap for code assuming GetChildren() does not return nulls.
The following error print statements are printed when GpuParticles2D are passed to C#
E 0:00:00:0595   ScriptManagerBridge.cs:101 @ IntPtr Godot.Bridge.ScriptManagerBridge.CreateManagedForGodotObjectBinding(Godot.NativeInterop.godot_string_name* , IntPtr ): System.InvalidOperationException: Wrapper class not found for type: GPUParticles2D
  <C# Error>     System.InvalidOperationException
  <C# Source>    /root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/Bridge/ScriptManagerBridge.cs:101 @ IntPtr Godot.Bridge.ScriptManagerBridge.CreateManagedForGodotObjectBinding(Godot.NativeInterop.godot_string_name* , IntPtr )
  <Stack Trace>  ScriptManagerBridge.cs:101 @ IntPtr Godot.Bridge.ScriptManagerBridge.CreateManagedForGodotObjectBinding(Godot.NativeInterop.godot_string_name* , IntPtr )
E 0:00:00:0595   GDScript.gd:8 @ _ready(): Parameter "strong_gchandle.value" is null.
  <C++ Source>   modules/mono/csharp_script.cpp:1229 @ setup_csharp_script_binding()
  <Stack Trace>  GDScript.gd:8 @ _ready()
E 0:00:00:0595   GDScript.gd:8 @ _ready(): Condition "!script_binding.inited" is true. Returning: { nullptr }
  <C++ Source>   modules/mono/glue/runtime_interop.cpp:234 @ godotsharp_internal_unmanaged_get_instance_binding_managed()
  <Stack Trace>  GDScript.gd:8 @ _ready()

Steps to reproduce
Can be reproduced by creating an HTTPRequest in GDScript, then passing it to C#. Sample project included below, which should output something like
[GD] Created <GPUParticles2D#26860323872>, Sending to C#...
[C#] Received null
[C#] Created <GPUParticles2D#26877101205>, Sending to GDScript...
[GD] Received <GPUParticles2D#26877101205>, Sending to C#...
[C#] Received <GPUParticles2D#26877101205>
[C#] Created <GPUParticles2D#26893878303>, Sending to GDScript...

along with the above errors in the debugger tab
Minimal reproduction project
HttpRequestRepro.zip

Good chance this is related to https://github.com/godotengine/godot/pull/69547

...And only now do I find https://github.com/godotengine/godot/issues/72203 and https://github.com/godotengine/godot/pull/72205, closing this as a dupe


Avoid logging at root and prefer debug to info level for code in loops

The current graphite code clutters logs with info level log entries each time it pushes. On top of that, since it logs at the root level there is no way to disable this logging without disabling info level logging for all other code. This PR has two changes:

Log using the module name so that the log level could be configured specifically for this module
Switch from info to debug so that the following lines don't appear in info level logs every 60 seconds:

Graphite pusher is sleeping for 60 seconds
Pushing stats to Graphite
Done pushing stats to Graphite
Thanks!

Looks like this is a popular issue; I just merged https://github.com/Cue/scales/pull/39 which made almost exactly the same changes. :-)
I'll get an updated release on PyPI later today. Thanks!


Include isMarkdown feature in Text component

Release Type: non-braking changes
Fixes https://x-team-internal.atlassian.net/browse/XP-3086
Description
Adapt Text to render Markdown content and apply basic typography styles.
Checklist

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective JIRA issue to the IN REVIEW column
[x] fill out Is a breaking change and Release Type Reason (if required) fields for the ticket. This is accessible when editing an issue in JIRA
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] Snapshots tests passed (npm run jest)
[x] check cleanup tasks (https://github.com/x-team/xp/labels/cleanup) and take a suitable small one (if exists) in a related area of the current changes
[x] component's documentation (.stories.js file) is changed or added accordingly to reflect any new or updated use cases or variants usage
[x] if you've fixed a bug, make sure to also include a new story that will expose declarations with problematic data that caused the bug in the first place, so that we can assure that no regressions will pop up on future interactions
[x] if any snapshots have been changed, verify that component still works and looks as expected and update the changed snapshot
[x] manually tested the app by running it in several different browsers (Firefox, Chrome, Opera, Safari, MS IE/Edge, etc.) and checked nothing is broken and operates as expected!

Related PRs

branch
PR

XP-3086-render-typography-with-text-on-strapisection-component
XP REG

Steps to Test or Reproduce
XP UI

Make sure to run npm install first
Run npm start
Go to http://localhost:9001/?selectedKind=UI Components%2FText%2FDemos&selectedStory=content with Markdown
Observe that the Markdown is rendered and styled as expected

XP

Copy xp-ui lib files to xp node modules (e.g. in xp directory run cp -R ../xp-ui/lib/ node_modules/xp-ui/lib/ && npm run watch)
Navigate in the app and observe that Text usages didn't have any regression
Compare applicant-facing screens presentation with the same ones in xp-registration

XP Registration

Make sure to follow instructions from this PR https://github.com/x-team/xp-registration/pull/53
Copy xp-ui lib files to xp-registration node modules
Navigate in the app and compare the presentation of xp's applicant-facing screens

Impacted Areas in Application

Text component
Theme colours palette

Screenshots

@nicksp

I'm also wondering whether we need to point this PR against a xp-ui branch that is used in xp-regisration instead? develop isn't used in xp-registration.

This is a good question. Because these are general improvements in the Text component, so would be good to have on both branches. A second PR based on lite branch maybe?

This is a good question. Because these are general improvements in the Text component, so would be good to have on both branches. A second PR based on lite branch maybe?

We can cherry pick the commit over to lite branch. Let's put it into Deploy Notes section in a PR description so we don't forget about that at least 😄

@bernardodiasc I replied to all the comments, so please take a look. Moving back to In Progress.

@nicksp I created a second PR based on lite branch https://github.com/x-team/xp-ui/pull/401


Camera2Video - Fix crash on start/stop recording

fix https://github.com/android/camera-samples/issues/290

Added mutex to prevent start/stop action conflicts asynchronously.
Hides recording button while stop to prevent creating new unexpected recording session.
Added reinitialization for MediaRecorder to record again after stopped.

See StackOverflow for detail: https://stackoverflow.com/questions/21632769/setoutputformat-called-in-an-invalid-state-4-where-and-why/21709635

Fixed the problem where animation would sometimes not stop.

Hi @ecoopnet, I'm not sure this is the appropriate solution to the issue you linked. To keep the sample very simple, we exit the fragment after recording completes. So there should be no need to re-initialize the recorder.

@owahltinez Thanks for your reply, I agree with what you wrote in comment https://github.com/android/camera-samples/issues/254#issuecomment-650179685, you're planning to fix the UI, so I don't think a PR here is necessary.


Release resources in PortUnificationServerHandler

Buffer has to be released before closing a connection. See also Norman's answer

This is incorrect... my Answer was about ChannelInboundHandler. ByteToMessageDecoder will manage the life-cycle by itself.

Thanks, haven't noticed that handling is done in ByteToMessageDecoder


Incorrect dates for Entry links

Incorrect month and year

Just create a separate file for domain logic regarding calendar.


Change the color of Circuit Verse logo in navbar of simulator to match the theme

Is your feature request related to a problem? Please describe.
It would be better if we update the color of CircuitVerse logo to other color like Green to match the theme.
Describe the solution you'd like
Change the color to green
Describe alternatives you've considered
Additional context

Are you working on this? (Yes/No)
I am willing to work on this if confirmed

@vedant-z the white logo is used intentionally to make the UI standardize, if you see every text in the navbar/toolbar is of color white!
Thanks for suggesting!


Docs site is down

THIS PROJECT IS DEPRECATED
The project is not maintained anymore. Thanks everyone for helping me on building this theme at the time where there were no good Hugo theme for documentation.
Consider migrating to another theme such as Relearn which seems to be a good maintained alternative.

we are adding new theme in coming release which will fix this issue: issue#113.


RedissonBloomFilter

Error code
RedissonBloomFilter.java
Line 123 and Line 174
for (Boolean val : result.subList(1, result.size()-1)) {
shouldn't Minus 1
Because of the parameters of this method is “toIndex” ，not “length”
Expected behavior
Actual behavior
Steps to reproduce or test case
Redis version
7.0.11
Redisson version
3.20.1
Redisson configuration

Fixed. Thanks for report


[ERROR] RuntimeError: populate() isn't reentrant

I am trying to deploy a Django project with Zappa and a PostgreSQL database on Amazon AWS RDS but I am running into this error:
$ zappa manage dev create_db
[START] RequestId: ac91cbb6-9026-44d5-9136-3e4db8c0878c Version: $LATEST
[DEBUG] 2020-09-22T11:16:57.834Z ac91cbb6-9026-44d5-9136-3e4db8c0878c Zappa Event: {'manage': 'create_db'}
[ERROR] RuntimeError: populate() isn't reentrant
Traceback (most recent call last):
  File "/var/task/handler.py", line 609, in lambda_handler
    return LambdaHandler.lambda_handler(event, context)
  File "/var/task/handler.py", line 243, in lambda_handler
    return handler.handler(event, context)
  File "/var/task/handler.py", line 404, in handler
    app_function = get_django_wsgi(self.settings.DJANGO_SETTINGS)
  File "/var/task/zappa/ext/django_zappa.py", line 20, in get_django_wsgi
    return get_wsgi_application()
  File "/var/task/django/core/wsgi.py", line 12, in get_wsgi_application
    django.setup(set_prefix=False)
  File "/var/task/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/var/task/django/apps/registry.py", line 83, in populate
    raise RuntimeError("populate() isn't reentrant")[END] RequestId: ac91cbb6-9026-44d5-9136-3e4db8c0878c
[REPORT] RequestId: ac91cbb6-9026-44d5-9136-3e4db8c0878c
Duration: 2.28 ms
Billed Duration: 100 ms
Memory Size: 512 MB
Max Memory Used: 101 MB

Error: Unhandled error occurred while invoking command.

Pretty meaningless error. I google'd this and tried some of the solutions in  other tickets but could not resolve this. I tried psycopg2 and psycopg2-binary but both no luck. Did anyone ever solve this? Because all the articles/issues covering this are old and outdated.
Zappa settings:
{
  "dev": {
    "aws_region": "eu-central-1",
    "django_settings": "dserverless.settings",
    "profile_name": "default",
    "project_name": "dserverless",
    "runtime": "python3.8",
    "s3_bucket": "django-serverless",
    "vpc_config": {
      "SubnetIds": ["subnet-2cef773346", "subnet-023527a", "subnet-6agbcb21"],
      "SecurityGroupIds": ["sg-87325d"]
    }
  }
}

The DB command:
class Command(BaseCommand):
    help = 'Creates the initial database'

    def handle(self, *args, **options):
        self.stdout.write(self.style.SUCCESS('Starting db creation'))

        dbname = settings.DATABASES['default']['NAME']
        user = settings.DATABASES['default']['USER']
        password = settings.DATABASES['default']['PASSWORD']
        host = settings.DATABASES['default']['HOST']

        con = None
        con = connect(dbname=dbname, user=user, host=host, password=password)
        con.set_isolation_level(ISOLATION_LEVEL_AUTOCOMMIT)
        cur = con.cursor()
        cur.execute('CREATE DATABASE ' + dbname)
        cur.close()
        con.close()

        self.stdout.write(self.style.SUCCESS('All Done'))

Pip freeze:
appdirs==1.4.3
argcomplete==1.12.0
asgiref==3.2.10
autopep8==1.5.4
boto3==1.15.2
botocore==1.18.2
CacheControl==0.12.6
certifi==2019.11.28
cfn-flip==1.2.3
chardet==3.0.4
click==7.1.2
colorama==0.4.3
contextlib2==0.6.0
distlib==0.3.0
distro==1.4.0
Django==3.1.1
django-s3-storage==0.13.4
durationpy==0.5
future==0.18.2
hjson==3.0.2
html5lib==1.0.1
idna==2.8
ipaddr==2.2.0
jmespath==0.10.0
kappa==0.6.0
lockfile==0.12.2
msgpack==0.6.2
packaging==20.3
pep517==0.8.2
pip-tools==5.3.1
placebo==0.9.0
progress==1.5
psycopg2-binary==2.8.6
pycodestyle==2.6.0
pyparsing==2.4.6
python-dateutil==2.6.1
python-slugify==4.0.1
pytoml==0.1.21
pytz==2020.1
PyYAML==5.3.1
requests==2.22.0
retrying==1.3.3
s3transfer==0.3.3
six==1.14.0
sqlparse==0.3.1
text-unidecode==1.3
toml==0.10.1
tqdm==4.49.0
troposphere==2.6.2
urllib3==1.25.8
webencodings==0.5.1
Werkzeug==0.16.1
wsgi-request-logger==0.4.6
zappa==0.51.0

Any particular reason you don't want to just log into the RDS instance?  You'll probably need to eventually anyways.

@rafrasenberg have you managed to solve this? Facing the same issue

@rafrasenberg have you managed to solve this? Facing the same issue


Unable to push local code using ssh

getting bellow error
$ git push origin react-step-1
ERROR: Permission to carbon-design-system/carbon-tutorial.git denied to nabaraj.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
using ssh key

got resoleved

hi @nabaraj how did you resolve this issue ?


Upload 42Coin

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[ ] Filename in the lowercase format
[ ] Image format: png
[ ] Image size: 256 by 256 px

Can you make it square ?


2811: Readd screenshots

Short description

Readd the screenshots we removed in #2819 without the problematic wording.
Resolved issues

Fixes: #2811.

Hmh, it was like this before, but I do not like that the screenshots are always in englisch and only the heading is different. One of the key features of the app ist, that it supports different languages, so I would highly perfer if the app constants and content is in the language the screenshot is for, instead of english.

I agree. Could you open a separate issue for that though please? I also already commented something that the screenshots are quite outdated/not showing all our features in mattermost.

Hmh, it was like this before, but I do not like that the screenshots are always in englisch and only the heading is different. One of the key features of the app ist, that it supports different languages, so I would highly perfer if the app constants and content is in the language the screenshot is for, instead of english.

I agree. Could you open a separate issue for that though please? I also already commented something that the screenshots are quite outdated/not showing all our features in mattermost.

Created this one: https://github.com/digitalfabrik/integreat-app/issues/2830
Feed free to add your thoughts there.


Adding a row to datatable

Can we add row to datatable ?
Unable to add row in javascript dynamically.
var t = $('#table').DataTable();
t.row.add( ["1","2","3","4","5"] ).draw();

This gem only add the Datatables jquery to Rails assets path.
Please, ask this question at StackOverflow using the tag DataTables.
Thanks.


build: Update repo to Node version 16 to match the other Fluid repos

Updates lockfiles to the npm v8 format, and updates some READMEs to clarify usage instructions.

I don't think I can come up with a great answer myself, but do we want to keep these in sync with the development in main or with the latest GA version? I kind of lean towards the latter...

I don't think I can come up with a great answer myself, but do we want to keep these in sync with the development in main or with the latest GA version? I kind of lean towards the latter...

Hmm. That's an interesting point. Since no code changes are required, it may not matter too much in this case. But I definitely see your point. @ssimic2 what do you think?

I don't think I can come up with a great answer myself, but do we want to keep these in sync with the development in main or with the latest GA version? I kind of lean towards the latter...

@alexvy86, I agree that we should keep the examples here on the latest GA release. IMO for a few reasons:

It is costly to update the examples every time we have a new internal release
It is a good exercise for our GA major/minor releases to update the examples here and observe any pain points
Since these examples are intended for users new to Fluid, it feels appropriate to use the GA releases

I think Alejandro's point was that our current GA release was developed on Node v14, rather than 16. So maybe we should not do this update until we release 2.0.0 GA? Since no code changes were required to make this migration, I suspect it might not matter much either way, but I think it's a good general question for us to answer.

Correct, I should have been more explicit. I was just thinking of the node version (14 vs 16), certainly not "update this example for every internal minor". If we went with the 16 option, if anything I'd update these for every internal major, and even that seems like maybe too much for non-GA versions.

@ssimic2 Interested in your opinion on this. We should probably have an explicit policy on it.

I think Alejandro's point was that our current GA release was developed on Node v14, rather than 16. So maybe we should not do this update until we release 2.0.0 GA? Since no code changes were required to make this migration, I suspect it might not matter much either way, but I think it's a good general question for us to answer.

Correct, I should have been more explicit. I was just thinking of the node version (14 vs 16), certainly not "update this example for every internal minor". If we went with the 16 option, if anything I'd update these for every internal major, and even that seems like maybe too much for non-GA versions.

Actually, now that Node 14 is no longer being supported, I think this is a change we should move forward on. But I think I agree that future migrations should be dependent on the highest common denominator between minimum Node support and what fluid-framework was using at the time of the release.
@alexvy86 @ssimic2 thoughts?

Actually, now that Node 14 is no longer being supported, I think this is a change we should move forward on. But I think I agree that future migrations should be dependent on the highest common denominator between minimum Node support and what fluid-framework was using at the time of the release.
@alexvy86 @ssimic2 thoughts?

Yeah, that makes sense.


get_parser not used in combination with val_mapping

If you encounter a bug use the following template.
If you have a feature request feel free to freestyle.
Steps to reproduce

make parameter with

        self.add_parameter('is_quenched',
                           get_cmd='QU?',
                           get_parser=str,
                           val_mapping={False: '0', True: '1'})

use instrument.is_quenched()

Expected behaviour
no error
Actual behaviour
I get the error (see below):
from which it is apparent it uses  _valmapping_get_parser for which the docstring says:
"""
        Get parser to be used in the case that a val_mapping is defined
        and a separate get_parser is not defined.

        Tries to match against defined strings in the mapping dictionary. If
        there are no matches, we try to convert the val into an integer.
        """

So it seems to me that it ignores my get_parser
error traceback:
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
d:\pycharmprojects\qcodes\qcodes\instrument\parameter.py in _valmapping_get_parser(self, val)
    831             val = int(val)
--> 832             return self._get_mapping[val]
    833         except (ValueError, KeyError):

KeyError: 0

During handling of the above exception, another exception occurred:

KeyError                                  Traceback (most recent call last)
<ipython-input-9-e839900e5e48> in <module>()
----> 1 station.AMI430_3D._magnet_x.is_quenched()

d:\pycharmprojects\qcodes\qcodes\instrument\parameter.py in __call__(self, *args)
    127         if len(args) == 0:
    128             if self.has_get:
--> 129                 return self.get()
    130             else:
    131                 raise NotImplementedError('no get cmd found in' +

d:\pycharmprojects\qcodes\qcodes\instrument\parameter.py in get(self)
    809         except Exception as e:
    810             e.args = e.args + ('getting {}'.format(self.full_name),)
--> 811             raise e
    812
    813     def _valmapping_get_parser(self, val):

d:\pycharmprojects\qcodes\qcodes\instrument\parameter.py in get(self)
    804     def get(self):
    805         try:
--> 806             value = self._get()
    807             self._save_val(value)
    808             return value

d:\pycharmprojects\qcodes\qcodes\utils\command.py in __call__(self, *args)
    175             raise TypeError(
    176                 'command takes exactly {} args'.format(self.arg_count))
--> 177         return self.exec_function(*args)

d:\pycharmprojects\qcodes\qcodes\utils\command.py in call_by_str_parsed_out(self, *args)
    128     def call_by_str_parsed_out(self, *args):
    129         """Execute a formatted string with output parsing."""
--> 130         return self.output_parser(self.exec_str(self.cmd_str.format(*args)))
    131
    132     def call_by_str_parsed_in(self, arg):

d:\pycharmprojects\qcodes\qcodes\instrument\parameter.py in _valmapping_with_preparser(self, val)
    835
    836     def _valmapping_with_preparser(self, val):
--> 837         return self._valmapping_get_parser(self._get_preparser(val))
    838
    839     def _set_get(self, get_cmd, get_parser):

d:\pycharmprojects\qcodes\qcodes\instrument\parameter.py in _valmapping_get_parser(self, val)
    832             return self._get_mapping[val]
    833         except (ValueError, KeyError):
--> 834             raise KeyError('Unmapped value from instrument: {!r}'.format(val))
    835
    836     def _valmapping_with_preparser(self, val):

KeyError: ('Unmapped value from instrument: 0', 'getting AMI430_X_is_quenched')

System
operating system
win7
qcodes branch
local, related to driver/AMI_430
qcodes commit
latest merge with master
de88c36

@damazter  quick comment of which I am not sure about: isn't the val mapping supposed to be the other way around ?  {'0':False,'1':True }

@giulioungaretti I think it's right how it is now.
@damazter Can you check if it's running through _valmapping_with_preparser?

@Rubenknex
It is also running through  _valmapping_with_preparser so maybe I am fundamentally misunderstanding how this part of parameter works

@alexcjohnson  can explain you 🦄

@giulioungaretti
from the docstring
"""
        val_mapping (Optional[dict]): a bidirectional map data/readable values
            to instrument codes, expressed as a dict:
            ``{data_val: instrument_code}``
            For example, if the instrument uses '0' to mean 1V and '1' to mean
            10V, set val_mapping={1: '0', 10: '1'} and on the user side you
            only see 1 and 10, never the coded '0' and '1'
"""

also from the docs:
You can use ``val_mapping`` with ``get_parser``, in which case
``get_parser`` acts on the return value from the instrument first,
then ``val_mapping`` is applied (in reverse).

You CANNOT use ``val_mapping`` and ``set_parser`` together - that
would just provide too many ways to do the same thing.

So yeah, it should work. Seems like for whatever reason the value it's getting is something that will cast to 0 but isn't '0'... perhaps it's getting '0\n' or something? If that's it, you can either:

use integers in the val_mapping, ie: val_mapping={False: 0, True: 1} and take advantage of the implicit casting to integer.
fix the string version - perhaps the instrument would benefit from defining a terminator?

To make it easier to debug in the future, we should keep track of the original value passed into _valmapping_get_parser and report that instead of after attempting to cast it to integer.
Anyway get_parser=str, while I don't think it's the problem here, isn't going to do anything if you already have a string that you read from the instrument.

@alexcjohnson  thanks!

@giulioungaretti
@Rubenknex
@alexcjohnson
Comparing integers fixes all my problems, I made a pr to the relevant driver. For me this closes the issue, but if you want to solve the underlying problem as well 'giulio' you can keep this open, otherwise, just close it

Ah I see, your AMI430 driver is an IPInstrument - and it looks like we don't strip terminators on read for IPInstruments, even though you have one defined. Perhaps another thing we should fix...

@damazter  I think I will  close this. The get_parser is indeed working as expected!
For posterity sake:
in this case the instrument was returning something like:
 "0\n"

which is not equal to  "0"
but  casting to int:
int("0\n")

which is equal to  0


Tag relation table not cleaned up in retention service

The retention service deletes jobs from the Job archive and also offers to delete the jobs from the database. Still in this case the links between tags and deleted jobs are currently not cleaned up.

The current DB Schema for jobtag already sets ON DELETE CASCADE.
NOTE: If sqlite PRAGMA option foreign_keys must be explicitly set to ON. If using the sqlite3 console it is per default set to false!
On every console session you must set:
sqlite> PRAGMA foreign_keys = ON;


Entering portals adds dimension

This pull request makes it so that any world that is missing the Nectere dimension will automatically get one when a player tries to enter a Nectere Portal.
This is a potential fix for #3.

Note: This may cause incompatibilities or strange behavior with any mods that cache the results of MinecraftServer.getWorld(...).

I looked over all the places Minecraft itself is calling MinecraftServer.getWorld(...) and it doesn't seem to be caching it anywhere. So I don't believe this will cause any issues with vanilla Minecraft.

I deleted the system for scanning for the old flag-file because that's not needed anymore, since the dimension is generated automatically. I also removed the system for yelling at the players and server admins about missing the Nectere dimension.


Tags without closing

How to define for example the tag [hr] to replace with  ? Without closing tag.

Have you been able to do it?
At the moment I have not found the correct way, but what I have done is str_replace ('[hr]', '[hr] [/ hr]', $bbcode)

Should change this to an enhancement request to allow for self-closing tags


Load balancer does not respond: timeout

Hi. I'm facing similar issue as #14 , load balancer is not connecting  - request expires with a timeout. I tried suggestions from there: seems like I got it right with subnets, and also I checked a running task in a cluster via aws console, it shows a bunch of 200 health check responses, but not mysfits responses. How can I investigate further? Is there a way to see some logs on load balancer itself?

Hi @ArtemKushnerov - sorry you're having this issue.  When we've seen the symptoms you're describing in the past, it has almost always been due to at least one of the subnets being misused when creating the NLB and/or ECS service.
Can you confirm that the CloudFormation describe-stacks output that includes your subnetIds shows both public subnetIds as matching the ones used for the NLB and both private subnetIds as the ones matching the ECS service?

Hi @abaird986! I was writing response to you with all my configs and all of a sudden it started working. This is weird though. Thanks!

Hi, I am doing the tutorial and in module 2 I am stuck with the Step 4, where I have to test the service. The NLB doesnt respond.


pythonPackages.pysnmp: 4.2.5 -> 4.3.2 + new package pythonPackages.pysmi

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

separate commit per package please

Done.

Merged through https://github.com/NixOS/nixpkgs/pull/16843.


[RFE] Allow for retirement based on date and time or delay

When setting future retirement on service or VM, the effective retirement happens on the specified date at 00:00 GMT. This behaviour is a bit limited and would gain being extended to handle delays or date and time.
When one wants to preset retirement on a service or VM, he clicks on Lifecycle > Set retirement date,
then specifies a date in the date picker and save. Then the service or VM is retired on the specified date at 00:00 GMT.
It would be great to have more options than a date :

A delay to say, "I want my service/VM to be retired in X/Y minutes/hours/days/months"
A date and time to say "I want my service/VM to be retired on XX/YY/ZZZZ at AA:BB TZ"

This would allow for a more fine grained behaviour suiting the user needs.
The documentation should also mention that the retirement date means the VM will be retired at 00:00 GMT. In Europe it doesn't have a big impact, but in NA or APAC regions it can be confusing.

@mzazrivec can you link in the PR that adds this feature?  Thx, Dan

Addressed in
https://github.com/ManageIQ/manageiq-ui-classic/pull/2250

and
https://github.com/ManageIQ/manageiq-ui-classic/pull/2282

Closing issue since this RFE has now been implemented!


"yield" parsing inside function name and parameters

Q
A

Bug fix?
yes

Breaking change?

New feature?

Deprecations?

Spec compliancy?
yes

Tests added/pass?
yes

Fixed tickets

License
MIT

Currently I have only written some tests. Babylon fails to parse the ignored ones, I will fix them in the following commits.
I have create a new folder (fixtures/es2015/yield) even if there was already fixtures/esprima/es2015-yield, to keep there only the original esprima tests. Some of them are wrong, I will remove them later.
Many of the tests I addedd already works in Babylon, but I added them to prevent possible regressions and to have all the tests about yield in the same place.

I think this PR will allow us to remove the following tests from `test262_whitelist.txt`:
language/expressions/arrow-function/param-dflt-yield-expr.js(default)
language/expressions/arrow-function/param-dflt-yield-expr.js(strict mode)
language/expressions/function/param-dflt-yield-strict.js(strict mode)
language/expressions/generators/param-dflt-yield.js(default)
language/expressions/generators/yield-as-generator-expression-binding-identifier.js(default)
language/expressions/generators/yield-as-parameter.js(default)
language/expressions/object/method-definition/generator-param-id-yield.js(default)
language/expressions/object/method-definition/generator-param-init-yield.js(default)
language/expressions/object/method-definition/yield-as-parameter.js(default)
language/statements/function/param-dflt-yield-strict.js(strict mode)
language/statements/generators/param-dflt-yield.js(default)
language/statements/generators/yield-as-parameter.js(default)
language/expressions/arrow-function/syntax/arrowparameters-bindingidentifier-yield.js(default)
language/statements/generators/yield-as-function-expression-binding-identifier.js(default)
language/statements/generators/yield-as-function-expression-binding-identifier.js(default)

TODO:

[x] Fix the bugs with normal and generator functions.
[x] Fix the bugs with arrow functions (this is trickier, it requires some backtracking)
[x] Remove the tests from the whitelist and check the esprima tests
[x] Make the error messages more consistent. Currently for yield binding in strict mode we have:

Binding yield in strict mode (function yield() { "use strict"; })
yield is a reserved word ("use strict"; function yield() {}, "use strict"; let yield;)
yield is a reserved word in strict mode (function fn(yield) { "use strict"; })

[ ] await has similar semantics, maybe it has the same bugs?

(Thanks Logan for having helped me on Slack to understand the correct semantics!)

This PR is ready for review. Some tests are duplicated in esprima/es2015-yield and es2015/yield. I prefer to have all the tests related to yield inside function name/parameters together; if you think that it is better to not have duplicated tests, I can delete them from es2015/yield.

Effectively all these commits are quite a mess, sorry 😂
I will reorganize the changes of this PR when I get home, so that it can be reviewed commit-by-commit more easily

@jridgewell I reorganized the commits to make it easier to review them. They do not overlap, so they can effectively be reviewed grouped in chunks (I added some labels that I think represent a good way of suddivising the commits for an easier review: funct, arrow and err msg)

@danez Do you want that I rebase this PR?

That would be nice, can also remove my two merges, somehow github cannot handle this here.


How to use the pretrained discriminator and generator files

With the pretrained generators and discriminators we can jump to result evaluations, but the program includes a certain structure of folders within which the trained architectures are to be placed. Could you please provide that hierarchy so that we could use the trained resources

Hi,
For training with pretrained discriminators: you could run the training script (i.e., source/main.py) by specifying the --load_dir to be the directory where you store the downloaded pretrained discriminators (it could be like 'results/mnist/pretrain/ResNet_default').
For evaluating with pretrained generator: you need to first generate samples (e.g., using the save_gen_data function from source/utils.py) and then provide the --gen_data accordingly to be the file path for the generated data.


[fix] count variable's scope

I fixed count's variable scope.
It may used v:count so I explicitly point out l:.
This patch may fix Issue #2080 .

thanks

Thanks for merging.


[HOLD for payment 2024-11-01] [GR Phase 1] Create reusable “PushRowWithModal” component

Design doc section: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.xg4d4oaa55we

Hi, I'm Eugene from Callstack - expert contributor group. I’d like to work on this issue.

Not overdue

Payment summary above is correct. @hungvu193 please request on NewDot. Thanks everyone!

$250 approved for @hungvu193


RTX_*  from ~/.config/rtx/config.toml not taking effect for rtx itself

Describe the bug
RTX_GO_SET_GOROOT and RTX_GO_SET_GOPATH do not seem to take effect for rtx itself when set in ~/.config/rtx/config,toml. They do get set, but so do GOROOT and GOPATH.
If set in a shell startup file, they do work as expected and prevent GOROOT and GOPATH from being set.
Perhaps the env settings from rtx config.toml take effect too late?
To Reproduce
$ cat .config/rtx/config.toml
[env]
RTX_GO_SET_GOROOT = "0"
RTX_GO_SET_GOPATH = "0"

[tools]
go = "1.20.7"
$ ssh localhost
$ env | grep GO
GOROOT=/home/scop/.local/share/rtx/installs/go/1.20.7/go
RTX_GO_SET_GOPATH=0
RTX_GO_SET_GOROOT=0
GOPATH=/home/scop/.local/share/rtx/installs/go/1.20.7/packages

Expected behavior
GOROOT and GOPATH should not have been set.
rtx doctor output
rtx version:
  1.35.8 linux-x64 (2589c72 2023-08-02)

build:
  Target: x86_64-unknown-linux-gnu
  Features: DEFAULT, NATIVE_TLS
  Built: Wed, 02 Aug 2023 20:25:37 +0000
  Rust Version: rustc 1.71.0 (8ede3aae2 2023-07-12)
  Profile: release

shell:
  /bin/bash
  GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)
  Copyright (C) 2019 Free Software Foundation, Inc.
  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

  This is free software; you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.

rtx data directory:
  /home/scop/.local/share/rtx

rtx environment variables:
  RTX_GO_SET_GOPATH=0
  RTX_GO_SET_GOROOT=0
  RTX_SHELL=bash

settings:
  {"always_keep_download": "false", "always_keep_install": "false", "asdf_compat": "false", "disable_default_shorthands": "false", "disable_tools": "[]", "experimental": "false", "jobs": "4", "legacy_version_file": "true", "legacy_version_file_disable_tools": "[]", "log_level": "INFO", "missing_runtime_behavior": "warn", "plugin_autoupdate_last_check_duration": "10080", "raw": "false", "trusted_config_paths": "[]", "verbose": "false"}

config files:
  /home/scop/.config/rtx/config.toml

plugins:
  go       (core)
  java     (core)
  node     (core)
  python   (core)
  ruby     (core)

toolset:
<EMAIL_ADDRESS>
No problems found

Additional context
Add any other context about the problem here.

this is the same root cause as https://github.com/jdxcode/rtx/issues/702
unfortunately it isn't an easy fix. The entire env var code needs to not be globally memoized like it is now which won't be a simple fix.

sort of related to #533 too. I think I want to completely refactor config/settings/env alongside config files and CLI flags. I think all of these should be able to output a map of configuration, something like:
{
  "gopath": "...",
  "verbose": 1
}

for all config settings regardless of where they come from. Then as the CLI is initialized it can layer on each type. This way what we can do with env vars is load the initial env vars we need, then once we parse a config file we can reset that env var config and replace it with new env vars from a config file.
Not sure if that makes sense, it's more notes for myself than it is for you since I'll probably need to make this change. It's significant.
The nice thing is it will clean up the settings code which is probably the worst part of the codebase right now.

Thanks for consideration. I saw #702 and thought it's related, but I'm too new to rtx's workings that I'd be able to tell if it was the same thing. Feel free to close this if you think it's more noise than useful to have around.


Does xhtml2pdf support Python3.3?

we are moving our projects to python 3, does xhtml2pdf support python 3?

I'm working on it at https://github.com/GildedHonour/xhtml2pdf-py3

Longer supported, I've used python django 3.4 and 1.7.
work at https://github.com/ebar0n/xhtml2pdf and already updated the main repository https://github.com/chrisglass/xhtml2pdf

The code in the main repository is not python 3 compatible. At least one of the packages specified in requirements.txt do not work in Python 3 (reportlab==2.5).
When I run the command:
nosetests
I get four errors on my machine.

:+1:

I use reportlab == 3.0, these days, I returned to supports the file requerimientos.txt not actualize as there are many using python 2.7
For my part libraria use smoothly under python 3.4 in my Django project
Upgrade reportlab apart, anything you mention me.

Hi,
I'm getting this error:
Exception Value: 	string argument expected, got 'bytes'
Exception Location: 	/mypath/python3.4/site-packages/xhtml2pdf/document.py in pisaDocument, line 184
Any help is much appreciated

The development version supports Python 3, albeit not necessarily Python 3.3 as I don't think that's a widespread version anymore.
I regret that we don't have better documentation of the usage, but I invite everyone to use the latest alpha with Python 3 and make PRs that fix their issues.
Other than that, please rest assured that xhtml2pdf is in production in a lot of systems and is not broken as such, it just needs a kind loving hand :)


duScrollspy not working and other strange behaviour

Hi,
When I added this to my navigation controller to be run before view change:
$document.scrollTop(top, duration).then(function() {
  console && console.log('You just scrolled to the top!');
});

I get console errors:
Error: $document.scrollTop(...).then is not a function
$scope.selectView@https://myapp.loc/pkg/myapp/js/controllers.js:604:3
$parseFunctionCall@https://myapp.loc/pkg/angular/js/angular13.js:12133:15
ngEventHandler/</callback@https://myapp.loc/pkg/angular/js/angular13.js:22518:17
$RootScopeProvider/this.$get</Scope.prototype.$eval@https://myapp.loc/pkg/angular/js/angular13.js:14123:16
$RootScopeProvider/this.$get</Scope.prototype.$apply@https://myapp.loc/pkg/angular/js/angular13.js:14221:18
ngEventHandler/<@https://myapp.loc/pkg/angular/js/angular13.js:22523:17
x.event.dispatch@https://myapp.loc/pkg/jquery/js/jquery.js:5:9453
x.event.add/y.handle@https://myapp.loc/pkg/jquery/js/jquery.js:5:6271

For some reason "du-scrollspy" is not working at all, no errors in console. I have tried in on several different elements, only one at a time and no other directives or functionalities of this library in use. I encountered the above mentioned error when trying other functionality to ensure the library has been properly loaded as it was failing silently.

Aha, chinging scrollTop to duScrollTo solved the first issue as mentioned in the doc. But the main problem is open that why du-scrollspy is not doing anything.

Does the demo work? If so, then you're doing something wrong but it's hard for me to tell what without any code. Can you post a plunker?
On Fri, Jul 3, 2015 at 8:29 AM, Janne Kurkinen<EMAIL_ADDRESS>wrote:

Aha, chinging scrollTop to duScrollTo solved the first issue as mentioned in the doc. But the main problem is open that why du-scrollspy is not doing anything.
Reply to this email directly or view it on GitHub:
https://github.com/oblador/angular-scroll/issues/130#issuecomment-118250061

I would need scrollspy feature for just so simple task that a sub-navigation element would be applied a class / fixed position after it is scrolled over the top. Perhaps this library is overkill for it?
I just tried to strip the demo off all the scrollspy features except one element having du-scrollspy directive applied. No active class was applied then.

du-scrollspy relies on the href attribute to find it's target so if you remove that you need to define it like this instead: du-scrollspy="anchor"

I found a weird hidden issue in my code that my be relevant to you, mentioned here.

@envision @homerjam  what AngularJS version do you have? I have the same issue with Angular 1.5.5

Sorry can't recall what I was using then but certainly pre 1.5.5. Checkout my comment in the other thread - it was down to the component/view/controller being compiled twice for some reason.


Service-level configuration

There are service-level configuration properties that cannot be specified in any k8s or service-apis resources currently.
The community seems to have a consensus that core.Service is an overloaded resource with features concerning different areas and the more fields should not be added to further bloat the Service abstraction.
This issue tracks all fields/features that relate to core.Service but are currently missing.
While these are laid out with Ingress in mind, some of these configurations are also valid in other areas as well:
Load balancing
Some examples of load balancing features are (not exhaustive):

Algorithm to use for load-balancing (L4/L7)
Draining of endpoints as they are added/removed
Timeouts (more in the Misc section)

core.Service has some aspects of load balancing using fields like SessionAffinity, and ExternalTrafficPolicy. The existing fields are (intentionally?) not exhaustive but also don’t provide any extension mechanisms.
Related issues:

https://github.com/kubernetes-sigs/service-apis/issues/98
https://github.com/kubernetes-sigs/service-apis/pull/184

Health checking
While kubernetes performs health checking of pods that are associated with a Service, it is common for proxies and Load Balancer to perform health checking on their part as well.
There have been some implementations which derive the health checking info from the liveliness or readiness probes but those seem incorrect as the reasons/concerns for kubelet and the proxy are different.
Related issues:

https://github.com/kubernetes-sigs/service-apis/issues/97
https://github.com/kubernetes-sigs/service-apis/issues/99

Misc
Other service-level features need to be specified to communicate with Ingress proxies or client of the service. The client could be running inside the same k8s cluster or outside.
Some examples of such properties (not exhaustive):

Timeouts: these can be TCP connect timeouts, or read timeouts
Retry behavior: If a request fails, should it be retried (L4/L7)
Limits on open connections/requests
Configuring a keep-alive pool and policies around idle connections

Most of these properties have an overlap with other sections as these generic networking properties.
Related issues/PRs:

https://github.com/kubernetes-sigs/service-apis/pull/184

Conclusion
Currently, there is no good place to put these configurations anywhere.
This has led to various implementations putting these in networking.Ingress like resources:
There have been duplication of above configurations into Ingress-like objects or using annotations, because there is no other place to add them:

https://projectcontour.io/docs/v1.4.0/httpproxy/
https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/
https://docs.nginx.com/nginx-ingress-controller/configuration/virtualserver-and-virtualserverroute-resources/
https://github.com/Kong/kubernetes-ingress-controller/blob/master/docs/concepts/custom-resources.md#kongingress

Such duplication causes:

Fragmentation in the ecosystem where common properties have to defined in multiple places
Defining service-level properties in Ingress or CRDs for configuring routing rules often collide when multiple routes are pointing to the same service. Proxies resort to creating an upstream pool for each route that points to a service, which defeats the purpose of having the Service abstraction.

/remove kind/feature

cc @bowei

Thanks @hbagdi this is a great write up.

I think I've missed a few things so we will have to get feedback and add more to the list.
I've intentionally not included TLS-level settings and AppProtocol to the list because I'm not sure if they are service-level or not. Some of those are but not all.

cc @danehans
Sorry, forgot to cc you earlier, Daneyon.

/assign

/cc @jpeach @youngnick

Discussion from office hours:
Common use case where different teams (e.g. cluster op vs app author), cluster op wants to "fix" up application settings due to regulatory, resource issues:

Cap timeouts, retries
Number of simultaneous connections

It is likely that we can't do 100% of these use cases (use Open Policy Agent) but we should keep this use case in mind.

A couple of questions/comments:

Is Retry a route-level or service-level configuration?
More specifically, is Retry policy specific to a route? Say if multiple routes point to the same service, shall they use the same Retry policy?

Capacity is also service-level configuration.
Capacity can be maximum number of requests per second, max number of simultaneous connections. Probably want to see if there exist common use cases that require this information.

Is Retry a route-level or service-level configuration?
More specifically, is Retry policy specific to a route? Say if multiple routes point to the same service, shall they use the same Retry policy?

@yiyangy, great question. I've seen this being done at both-levels in different setups. I defined this on the service-level because that's what I've seen more widely adopted. We can certainly revisit.
@youngnick mentioned in one of the meetings about how users use Gateway or proxies to fix up things. Meaning, if services haven't implemented retries or timeouts correctly, or if all services have different behavior around this, gateway is used to fix things up.

Re. Timeout and similar: https://istio.io/docs/reference/config/networking/destination-rule/

Composing by name seems like a very clean and simple solution - on 'server' namespace they would match the Service name, on client namespace they would be based on the qualified service name ( svc.namespace.svc )

My notes from the 5/28/20 meeting:

Adding these settings to a Service is not preferred due to the existing complexity of the resource.
One or more separate resources should be considered to express client and server, i.e. Service, settings.
A client and server may reside in a separate namespaces where RBAC prevents a single resource from being used to express client and server settings.
Client settings should be able to override server settings.
Gateway and HTTPRoute may override these settings.

One thing to note, I think there are two distinct but related topics here. All of these examples are based on client and server having an Envoy sidecar since I am familiar with this model but should generally apply.
First is where the config is actually applied. This can be

Client-side only. For example, LB algorithm can only be set by the client.
Server-side only. For example, authn/authz (technically this could be on the client, but its not actually secure).
Both sides. For example, timeouts. A server may want to set a timeout of 5s to protect itself, but a client may chose to limit their own requests to only 1s.

The second is where the config comes from. For "server-side only", the only reasonable location for the config is alongside the server (in Service or a related resource - certainly in the same namespace). However for client settings its reasonable to be able to configure defaults in the server namespace, but overrides in the client namespace.
You can also potentially have global defaults for all of these settings.

Hello all,
I've incorporated the feedback I've heard in this thread and from the weekly meetings into the original issue. The issue has a few new sections so please give it another pass. Thanks!

I threw together a couple of ideas here:
https://docs.google.com/document/d/1Kz2X7zKfaSGW9YTlzqFeFuTCj5uDxdB9D363nMkB6xk/edit#

/remove-lifecycle stale

@hbagdi
we also have LoadBalancerSourceRanges in Service for firewall or policy related configurations.

@hbagdi This issue has become pretty large in scope, would it be possible to split this up into smaller issues so it is easier to track progress on each part?

Update:
As Rob said, this umbrella issue has become large and served its purpose.
Some specifics before closing this issue:

Load balancing is tracked in #98
Traffic management (canarying, mirroring) are implement as HTTPRouteFilters as of v1alpha1
Healthcheck related features are already tracked in #97 #99 #89
Global defaults can be set in an implementation-speicfic CRD that is specified in the GatewayClass.Spec.ParametersRef.

Please let me know if something was missed here.
/close


Fix Grover init_state num_qubits initialization

Summary
Details and comments

PR closed since more refactoring will be done.

addressed in https://github.com/Qiskit/qiskit-aqua/pull/370/commits/b60fa8acfa00f3458ad668f6c5ca51051257a9d3


[HW] George Cross V

Name: George Cross V
Email<EMAIL_ADDRESS>Linkedin Profile: https://www.linkedin.com/in/george-cross-206990136/
Attach the homework screenshots below for both step II and step III:

Great Job, thank you for your work.
Here is your badge:
<EMAIL_ADDRESS>


Map Context Editor: ZoomToExtent

When the first layer is inserted into the tree, it zooms out from the representation of the entire world to the extent of the layer.

at each mapContextLayer the function for Zoom2Extent is integrated in the context menu.

if no rendering layer is linked to the mapContextLayer, the function is grayed out in the context menu


Add SHOW METRICS INFO query

Description
New query has been added SHOW METRICS INFO, which expose the same metrics like from the HTTP endpoint, over a query
Pull request type
Please check what kind of PR this is:

[X] Fix or improvement of an existing page
[ ] New documentation page, release related

Related PRs and issues
PR this doc page is related to:
(especially necessary if the PR is related to a release)

Closes:
X
Checklist:

[X] Check all content with Grammarly
[X] Perform a self-review of my code
[X] Make corresponding changes to the rest of the documentation (consult with the DX team)
[X] The build passes locally
[X] My changes generate no new warnings or errors
[X] Add a corresponding label
[X] If release-related, add a product and version label
[X] If release-related, add release note on product PR

Please link the blocking PR


[core] Replace getInitialProps with getStaticProps

Related to https://github.com/mui/material-ui/pull/33196#discussion_r927522667
We still need getInitialProps on the non-page files, like _document.js, _app.js etc.

I couldn't make this work in the past for all locales. So I would recommend also running export for all locales.

Yep, using require.context wouldn't be possible in that scenario. It'd need to be replaced with regular filesystem access. Just mentioning it as it seemed to be the obvious choice for implementing this. Not having tried this, I'm probably overlooking some more potential blockers.

I tried it multiple times but never took the time writing down why. It all came down to vervel considering our use case exotic and not helping with guidance etc. It might work now and I would definitely recommend doing it long term. Just be sure to test how master would be deployed not just branches. And test /api and other routes separately.

I couldn't make this work in the past for all locales. So I would recommend also running export for all locales.

@mnajdova The point of Sebastian is confirmed. This PR broke the SEO structure when it comes to the translations. For example in https://mui.com/material-ui/api/table-pagination/, it says:
<link rel="alternate" href="https://mui.com/zh/material-ui/api/table-pagination/" hrefLang="zh"/>

But this page is a 404 https://mui.com/zh/material-ui/api/table-pagination/. Chinese users will directly get a 404. Google Search console started to raise flags about it: https://search.google.com/search-console/index/drilldown?resource_id=sc-domain:mui.com&item_key=CAMYMiAD&utm_source=wnc_10030322. I could find a bit of documentation about it on the React's side: https://github.com/vercel/next.js/issues/15315#issuecomment-661074532.
What I would propose is to:

Revert this PR (trading a deprecation for a working SEO structure sounds like a good deal)
Have a look at https://nextjs.org/docs/basic-features/data-fetching/get-static-paths as suggested by Jan.

Otherwise:
a. Add 301 for all the URLs that are now 404
b. Remove the alternate hrefLang
c. Remove the automatic redirection to these missing URL
d. Do point 2.

I don't really have bandwidth to look into this more. I can revert the PR and delegate to someone else on the team to handle.

@mnajdova Ok, sounds great. It will likely be for once we need to upgrade Next.js or considering the direction https://www.notion.so/mui-org/Docs-localization-what-s-next-3f370280b58f446fbb5559dfc08fe03e#78cff2012415476abe79b013c85e4f64 is heading (no translations in production), we would need to change SEO structure too.


Dev 3.5.8 test

Merged in all previous JVF’s pull requests. (Made on deployment templates)
Upgraded run time from ~3 to ~4 and Node version from 12 to 18 (the latest working version. Node 20 will break functions)
Integrated core repo (release 3.5.1, the latest working version) into fortigate-autoscale-azure. Yay! No need to make 2 releases if we need to make any changes to the core functions.

Newer version available


Composer create-project does not work

Reproducible steps:
composer create-project --prefer-dist limoncello-php/app app_name && cd app_name

Expected result:
Some file structure is created without error.
Actual result:
Installing limoncello-php/app (0.3.4)
  - Installing limoncello-php/app (0.3.4)
    Downloading: Failed
    Failed to download limoncello-php/app from dist: The "https://api.github.com/repos/limoncello-php/app/zipball/2ecc97d1361321fd1cad9205799822fef21a781d" file could not be downloaded (HTTP/1.1 302 Found)
    Now trying to download from source
  - Installing limoncello-php/app (0.3.4)
    Cloning 2ecc97d1361321fd1cad9205799822fef21a781d
    2ecc97d1361321fd1cad9205799822fef21a781d is gone (history was rewritten?)

  [RuntimeException]
  Failed to execute git checkout '2ecc97d1361321fd1cad9205799822fef21a781d' -- && git reset --hard '2ecc97d1361321fd1cad9205799822fef21a781d' --
  fatal: reference is not a tree: 2ecc97d1361321fd1cad9205799822fef21a781d

create-project [-s|--stability STABILITY] [--prefer-source] [--prefer-dist] [--repository REPOSITORY] [--repository-url REPOSITORY-URL] [--dev] [--no-dev] [--no-custom-installers] [--no-scripts] [--no-progress] [--no-secure-http] [--keep-vcs] [--no-install] [--ignore-platform-reqs] [--] [<package>] [<directory>] [<version>]

I accidently broke some GitHub project settings. Now it's fixed and project creation should work.

I have confirmed this problem is fixed.


[Request for Modification] codeunit 8898 "Map Email Source" - InsertAttachment - Possibility to add attachments from external storage

Currently the codeunit Map Email Source contains a subscriber which inserts related e-mail attachments based on the Document Attachment table:
    [EventSubscriber(ObjectType::Codeunit, Codeunit::Email, 'OnGetAttachment', '', false, false)]
    local procedure InsertAttachment(AttachmentTableID: Integer; AttachmentSystemID: Guid; MessageID: Guid)
    var
        TenantMedia: Record "Tenant Media";
        DocAttachment: Record "Document Attachment";
        EmailMessage: Codeunit "Email Message";
        AttachmentInStream: InStream;
        AttachmentGuid: Guid;
        FileName: Text;
    begin
        if (AttachmentTableID <> Database::"Document Attachment") then
            exit;

        if not DocAttachment.GetBySystemId(AttachmentSystemID) then
            exit;

        EmailMessage.Get(MessageID);

        AttachmentGuid := DocAttachment."Document Reference ID".MediaId();
        TenantMedia.Get(AttachmentGuid);
        TenantMedia.CalcFields(Content);
        TenantMedia.Content.CreateInStream(AttachmentInStream);
        FileName := StrSubstNo(FileFormatTxt, DocAttachment."File Name", DocAttachment."File Extension");

        EmailMessage.AddAttachment(CopyStr(FileName, 1, 250), TenantMedia."Mime Type", AttachmentInStream);
    end;

We'd like to implement external storage types (sharepoint, azure blob,...) that not use the Document Reference ID field to store the attachments.
Please extend the Document Attachment table with the following code:
    internal procedure ExportToTempBlob(var TempBlob: Codeunit "Temp Blob")
    var
        TenantMedia: Record "Tenant Media";
        AttachmentGuid: Guid;
        OutStr: OutStream;
        AttachmentInStream: InStream;
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeExportToTempBlob(Rec, TempBlob, IsHandled);
        if IsHandled then
            exit;

        AttachmentGuid := "Document Reference ID".MediaId();
        TempBlob.CreateOutStream(OutStr);
        TenantMedia.Get(AttachmentGuid);
        TenantMedia.CalcFields(Content);
        TenantMedia.Content.CreateInStream(AttachmentInStream);
        CopyStream(OutStr, AttachmentInStream);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeExportToTempBlob(var DocumentAttachment: Record "Document Attachment"; var TempBlob: Codeunit "Temp Blob"; var IsHandled: Boolean)
    begin
    end;

..and adjust the InsertAttachment function in codeunit Map Email Source as following:
    [EventSubscriber(ObjectType::Codeunit, Codeunit::Email, 'OnGetAttachment', '', false, false)]
    local procedure InsertAttachment(AttachmentTableID: Integer; AttachmentSystemID: Guid; MessageID: Guid)
    var
        TenantMedia: Record "Tenant Media";
        DocAttachment: Record "Document Attachment";
        EmailMessage: Codeunit "Email Message";
        AttachmentInStream: InStream;
        AttachmentGuid: Guid;
        FileName: Text;
        TempBlob: Codeunit "Temp Blob";
    begin
        if (AttachmentTableID <> Database::"Document Attachment") then
            exit;

        if not DocAttachment.GetBySystemId(AttachmentSystemID) then
            exit;

        EmailMessage.Get(MessageID);

        DocAttachment.ExportToTempBlob(TempBlob);
        TempBlob.CreateInStream(AttachmentInStream);
        FileName := StrSubstNo(FileFormatTxt, DocAttachment."File Name", DocAttachment."File Extension");

        EmailMessage.AddAttachment(CopyStr(FileName, 1, 250), TenantMedia."Mime Type", AttachmentInStream);
    end;

This will allow partners to use the document attachment table to retrieve e-mail attachments from other sources than the Document Reference ID field.

Hello! I can see you have created multiple requests to modify Email/Attachment story with regards to using of other external storage options. Although few requests have been already classified as Event Requests, I am starting to think it will be more productive to have our internal team to process your PR for all required changes, confirm and accept it and check-in to our code base as a whole solution.
@JesperSchulz - what do you think? Can we manage this feature now?

We do not have capacity to take on larger extensibility requests at this point in time, but I wonder if this would be a good open source candidate. A combined PR would allow us to see the full picture of the change request.


StatisticsBackend::get_type [11666]

StatisticsBackend::database_ changed to static.
Added /TestUtils/ for test with similar database setup.
After merge change load_database to use /TestUtils/.

Please, complete also the documentation for this API, removing the Warning notice and completing any other information you deem necessary.

Please, complete also the documentation for this API, removing the Warning notice and completing any other information you deem necessary.

Check when push, please.


opencv-contrib-python==<IP_ADDRESS> - sha256 signature doesn't match

Describe the bug
When trying to install opencv-contrib-python with pip3, I get the following error:
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
opencv-contrib-python==<IP_ADDRESS> from https://files.pythonhosted.org/packages/ae/49/3cd68054c9925fef8e7c4c64fce603202277996d561689c02c1edfcd10e5/opencv_contrib_python-<IP_ADDRESS>-cp38-cp38-manylinux2014_x86_64.whl#sha256=9ea70355894c9897d194db3e80c109c9a674106b1c0270256c5d7e0811f71ef8 (from -r requirements.txt (line 26)):
Expected sha256 9ea70355894c9897d194db3e80c109c9a674106b1c0270256c5d7e0811f71ef8
Got        6a61ab7aa8e0f7cb0d6f6ae7e7424de285463d4ca27b11ba48dd088aae47fcb5
I also tried downloading the wheel directly from https://files.pythonhosted.org/packages/ae/49/3cd68054c9925fef8e7c4c64fce603202277996d561689c02c1edfcd10e5/opencv_contrib_python-<IP_ADDRESS>-cp38-cp38-manylinux2014_x86_64.whl, checked its sha256 hash, and confirmed that it was 6a61ab.... instead of the expected 9ea703...
Expected behavior
The published hash should match the actual hash of the file
To Reproduce
Download the file at https://files.pythonhosted.org/packages/ae/49/3cd68054c9925fef8e7c4c64fce603202277996d561689c02c1edfcd10e5/opencv_contrib_python-<IP_ADDRESS>-cp38-cp38-manylinux2014_x86_64.whl
(on MacOS) shasum -a 256 ....path to downloaded file....
My Platform
found the issue in a Docker container with Ubuntu 20.04, Python 3
reproduced locally on my Mac

I'm unable to reproduce:
$ wget https://files.pythonhosted.org/packages/ae/49/3cd68054c9925fef8e7c4c64fce603202277996d561689c02c1edfcd10e5/opencv_contrib_python-<IP_ADDRESS>-cp38-cp38-manylinux2014_x86_64.whl
--2023-04-25 21:13:52--  https://files.pythonhosted.org/packages/ae/49/3cd68054c9925fef8e7c4c64fce603202277996d561689c02c1edfcd10e5/opencv_contrib_python-<IP_ADDRESS>-cp38-cp38-manylinux2014_x86_64.whl
Resolving files.pythonhosted.org (files.pythonhosted.org)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to files.pythonhosted.org (files.pythonhosted.org)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 57430726 (55M) [application/octet-stream]
Saving to: ‘opencv_contrib_python-<IP_ADDRESS>-cp38-cp38-manylinux2014_x86_64.whl’

opencv_contrib_python- 100%[=========================>]  54.77M  58.8MB/s    in 0.9s

2023-04-25 21:13:53 (58.8 MB/s) - ‘opencv_contrib_python-<IP_ADDRESS>-cp38-cp38-manylinux2014_x86_64.whl’ saved [57430726/57430726]

$ shasum -a 256 opencv_contrib_python-<IP_ADDRESS>-cp38-cp38-manylinux2014_x86_64.whl
9ea70355894c9897d194db3e80c109c9a674106b1c0270256c5d7e0811f71ef8  opencv_contrib_python-<IP_ADDRESS>-cp38-cp38-manylinux2014_x86_64.whl

Can you share the file that's giving you the 6a61ab hash?

I also can't reproduce it anymore - must have been an intermittent issue. Noticing that while this was an issue, the downloaded file was much smaller - 4.2 MB instead of 57.4 MB. All is well that ends well, I guess.

all good now.


"Sihlea", "Bogza", "Căiata" and "Voetin" are listed in the drop-down menu

The villages are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar

Step 1
Type "Sihlea" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Sihlea, VRANCEA (Sihlea)".

Step 2
Type "Bogza" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Bogza, VRANCEA (Sihlea)".

Step 3
Type "Căiata" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Căiata, VRANCEA (Sihlea)".

Step 4
Type "Voetin" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Voetin, VRANCEA (Sihlea)".


add known failure annotations

Waiting on Travis to merge.

@smccarthy788 can you reduce this PR to just the mv known failure annotation? the repair_tests one was added in another one and the one Philip noted as unnecessary has been fixed.


Does not find collection adders methods

Method such as
List<Object> elements;

public void addNewElement(Object element) {
    this.elements.add(element);
}
Won't be considered as a collectionAdder, and they are crucial for Extract Class refactoring.

Resolved in https://github.com/JetBrains-Research/IntelliJDeodorant/pull/52


Memory leak when changing window size in Linux

Godot version:
3.1 stable
OS/device including version:
Ubuntu 18.04.2
Issue description:
When I changing size of window with project which contains only Node2D, then I see that Godot memory increase.
https://streamable.com/p7xh6

Please run valgrind with --leak-check=full and try to reproduce, then provide valgrind log.

Dokument bez nazwy.txt

valgrind --leak-check=full godot >> /home/rafal/F.txt
otherwise your report is not very usable

F.txt

==27020== 32 bytes in 1 blocks are possibly lost in loss record 1,496 of 5,328
==27020==    at 0x580CB0F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==27020==    by 0x32DDA77: Memory::alloc_static(unsigned long, bool) (memory.cpp:85)
==27020==    by 0x15D2F81: CowData<wchar_t>::resize(int) (cowdata.h:274)
==27020==    by 0x1B2440B: String::resize(int) (ustring.h:148)
==27020==    by 0x321658C: String::copy_from(char const*) (ustring.cpp:145)
==27020==    by 0x321AB1B: String::String(char const*) (ustring.cpp:1605)
==27020==    by 0x322D070: Variant::Variant(char const*) (variant.cpp:2198)
==27020==    by 0x3245800: register_variant_methods() (variant_call.cpp:1495)
==27020==    by 0x31D1BF1: register_core_types() (register_core_types.cpp:105)
==27020==    by 0x1195926: Main::setup(char const*, int, char**, bool) (main.cpp:339)
==27020==    by 0x1167145: main (godot_x11.cpp:48)
==27020==
==27020== 32 bytes in 1 blocks are possibly lost in loss record 1,497 of 5,328
==27020==    at 0x580ED2F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==27020==    by 0x32DDCC7: Memory::realloc_static(void*, unsigned long, bool) (memory.cpp:140)
==27020==    by 0x11D3828: CowData::resize(int) (cowdata.h:282)
==27020==    by 0x11D2EB5: Vector::resize(int) (vector.h:84)
==27020==    by 0x11D354D: Vector::push_back(StringName const&) (vector.h:152)
==27020==    by 0x3274025: _VariantCall::addfunc(bool, Variant::Type, Variant::Type, bool, StringName const&, void ()(Variant&, Variant&, Variant const**), Vector const&, _VariantCall::Arg const&, _VariantCall::Arg const&, _VariantCall::Arg const&, _VariantCall::Arg const&, _VariantCall::Arg const&) (variant_call.cpp:172)
==27020==    by 0x3245886: register_variant_methods() (variant_call.cpp:1495)
==27020==    by 0x31D1BF1: register_core_types() (register_core_types.cpp:105)
==27020==    by 0x1195926: Main::setup(char const, int, char**, bool) (main.cpp:339)
==27020==    by 0x1167145: main (godot_x11.cpp:48)
==27020==
==27020== 32 bytes in 1 blocks are possibly lost in loss record 1,498 of 5,328
==27020==    at 0x580ED2F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==27020==    by 0x32DDCC7: Memory::realloc_static(void*, unsigned long, bool) (memory.cpp:140)
==27020==    by 0x11D3828: CowData::resize(int) (cowdata.h:282)
==27020==    by 0x11D2EB5: Vector::resize(int) (vector.h:84)
==27020==    by 0x11D354D: Vector::push_back(StringName const&) (vector.h:152)
==27020==    by 0x3274025: _VariantCall::addfunc(bool, Variant::Type, Variant::Type, bool, StringName const&, void ()(Variant&, Variant&, Variant const**), Vector const&, _VariantCall::Arg const&, _VariantCall::Arg const&, _VariantCall::Arg const&, _VariantCall::Arg const&, _VariantCall::Arg const&) (variant_call.cpp:172)
==27020==    by 0x3245A2B: register_variant_methods() (variant_call.cpp:1496)
==27020==    by 0x31D1BF1: register_core_types() (register_core_types.cpp:105)
==27020==    by 0x1195926: Main::setup(char const, int, char**, bool) (main.cpp:339)
==27020==    by 0x1167145: main (godot_x11.cpp:48)
@akien-mga might you look in to this or I can do that early April? Sorry I'm too busy these days :(

Also Valgrind show other definitely lost objects
432 bytes in 1 blocks are definitely lost in loss record 99 of 126
   at 0x581274F: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0x379A457: Memory::alloc_static(unsigned long, bool) (memory.cpp:85)
   by 0x379A400: operator new(unsigned long, char const*) (memory.cpp:42)
   by 0x1E260AB: RasterizerSceneGLES3::environment_create() (rasterizer_scene_gles3.cpp:766)
   by 0x340D2CA: VisualServerRaster::environment_create() (visual_server_raster.h:496)
   by 0x344B615: VisualServerWrapMT::environment_create() (visual_server_wrap_mt.h:423)
   by 0x2FCC714: Environment::Environment() (environment.cpp:1303)
   by 0x289BC0B: Object* ClassDB::creator<Environment>() (class_db.h:146)
   by 0x35DCB17: ClassDB::instance(StringName const&) (class_db.cpp:540)
   by 0x30C27F4: ResourceInteractiveLoaderText::poll() (resource_format_text.cpp:561)
   by 0x3862F2D: ResourceFormatLoader::load(String const&, String const&, Error*) (resource_loader.cpp:197)
   by 0x3864834: ResourceLoader::_load(String const&, String const&, String const&, bool, Error*) (resource_loader.cpp:272)

480 bytes in 1 blocks are definitely lost in loss record 100 of 126
   at 0x581274F: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0x999F15F: glXChooseFBConfig (in /usr/lib/x86_64-linux-gnu/libGLX_nvidia.so.430.14)
   by 0x6D23B20: glXChooseFBConfig (in /usr/lib/x86_64-linux-gnu/libGLX.so.0.0.0)
   by 0x137E5D0: ContextGL_X11::initialize() (context_gl_x11.cpp:156)
   by 0x1380859: OS_X11::initialize(OS::VideoMode const&, int, int) (os_x11.cpp:298)
   by 0x13B3623: Main::setup2(unsigned long) (main.cpp:1098)
   by 0x13B1E4A: Main::setup(char const*, int, char**, bool) (main.cpp:1046)
   by 0x137D950: main (godot_x11.cpp:48)

It probably can be closed, because I have only this leaks, which are probably Nvidia drivers bugs:
Direct leak of 6280 byte(s) in 3 object(s) allocated from:
    #0 0x7f3966d98ce6 in calloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dce6)
    #1 0x7f3957976995  (/lib/x86_64-linux-gnu/libnvidia-glcore.so.435.21+0xe39995)

Direct leak of 512 byte(s) in 1 object(s) allocated from:
    #0 0x7f3966d98f1e in __interceptor_realloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10df1e)
    #1 0x7f395797628f  (/lib/x86_64-linux-gnu/libnvidia-glcore.so.435.21+0xe3928f)

Direct leak of 4 byte(s) in 1 object(s) allocated from:
    #0 0x7f3966d98ce6 in calloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dce6)
    #1 0x7f39667f7842 in pa_xmalloc0 (/lib/x86_64-linux-gnu/libpulse.so.0+0x3b842)

Direct leak of 1 byte(s) in 1 object(s) allocated from:
    #0 0x7f3966d98ae8 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8)
    #1 0x7f39669498af in XGetWindowProperty (/lib/x86_64-linux-gnu/libX11.so.6+0x258af)
    #2 0x9f5f4ff in InputEventMIDI::get_class_ptr_static()::ptr (/usr/bin/godots+0x9f5f4ff)

Indirect leak of 72672 byte(s) in 224 object(s) allocated from:
    #0 0x7f3966d98ce6 in calloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dce6)
    #1 0x7f3957976995  (/lib/x86_64-linux-gnu/libnvidia-glcore.so.435.21+0xe39995)

Indirect leak of 2478 byte(s) in 179 object(s) allocated from:
    #0 0x7f3966d98ae8 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8)
    #1 0x7f3957976b5b  (/lib/x86_64-linux-gnu/libnvidia-glcore.so.435.21+0xe39b5b)

Indirect leak of 752 byte(s) in 6 object(s) allocated from:
    #0 0x7f3966d98f1e in __interceptor_realloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10df1e)
    #1 0x7f395797628f  (/lib/x86_64-linux-gnu/libnvidia-glcore.so.435.21+0xe3928f)


Global on_paste event listener

Describe the Custom Component

What is the purpose of the custom component?
Event handler that's called when anything is pasted in, e.g. text or files

What is the expected behavior of the custom component?
Handle data that's pasted in via the user clipboard

What are the use cases for the custom component?
Allow users to paste files to upload directly without having to open a file explorer.
E.g. I make a screenshot, save it to my clipboard and then wanna paste it in the reflex app

Specifics (please complete the following information):

Do you have a specific react package in mind? (Optional): No

Additional context
The idea comes from the functionality on ChatGPT UI, where images can be pasted in to be used for Vision LLMs.

Please assign this to me


Create sidecar.hostname and sidecar.ipAddress

In addition to eureka.instance.hostname property you can now defined sidecar.hostname in order to set different hostname from application and its sidecar.
However if eureka.instance.hostname is present it will override sidecar.hostname (due to  @ConfigurationProperties("eureka.instance"))
Moreover we also now re-calculate ip address from sidecar.hostname (except if sidecar.ipAddress is defined) to correctly have ip address on eureka registry.
Fixes #981

PS: About tests I can't really test ip recalculation because I'm not able to mock InetAddress.getByName() without PowerMock or something else.

@kakawait Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@kakawait Thank you for signing the Contributor License Agreement!

Current coverage is 74.10% (diff: 37.50%)

Merging #1561 into master will decrease coverage by 0.12%

@@             master      #1561   diff @@
==========================================
  Files           193        193
  Lines          5937       5950    +13
  Methods           0          0
  Messages          0          0
  Branches        893        896     +3
==========================================
+ Hits           4407       4409     +2
- Misses         1206       1213     +7
- Partials        324        328     +4

Powered by Codecov. Last update c380039...ebc29cc


implemented elseStatementNewLine

Description

Checklist

[x] I’ve added tests to confirm my change works.
[ ] (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
[ ] (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
[ ] I’ve read the contributing guidelines.

✨Try the playground for this PR✨

Looks good, but why the const { hardline } = require("../../document/doc-builders.js"); in misc.js?


HMR doesn't work in a monorepo

Hello there, I vue init a fresh webpack project and couldn't get HMR to work. Here are the steps to reproduce:
git clone https://github.com/sammkj/vue-webpack-hmr-repro
yarn install
cd client/apps/web-test
yarn run dev

Then try to edit any files under src. HMR is not triggered.

To me, nothing about HMR is working :\
I have to run "npm run dev" every time

disable your auto-save feature of your ide
use ctrl + s  to trigger HMR

The normal installation works well for me, just tested a could of hours ago for #1054
I will test this specific case when I get home - until then: can you provide me with details aboiut your environment? Virtual Machines? synced folders  ()google drive etc.)?

Dell Ubuntu 16.04 LTS is my development environment. after a few trial and errors (rm -rf node_modules, edit webpack config, etc.), I finally got it working.


ZipZap causes some static analyzer warnings

If you run Xcode 8 Static Analyzer on ZipZap, some warnings result. Particularly, some properties and methods which are annotated as nonnil, are returning nil:

Some ideas:

If the methods returning nil are part of an abstract class and are never supposed to be called, this can be resolved by adding NSAssert(...) before returning nil.
As for the properties, these shouldn't be set to nil, or they should be annotated as nullable.

Thanks!

I'll take a look, it may take a while for me to fix since I'm the middle of transitioning from Xcode 7 to 8.
Feel free to submit a pull request to fix these errors. In particular, ZZArchiveEntry is an abstract class but ZZArchive and ZZInflateInputStream are not.


add some documentation for FixedArray::unsafe_blit

Pull Request Test Coverage Report for Build 4044
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.43%

Totals

Change from base Build 4043:
0.0%

Covered Lines:
4377

Relevant Lines:
5442

💛  - Coveralls


Make sure that return_bytes function returns int value. Fix tabs.

php_admin_value[post_max_size] in PHP fpm pool config set to big integer (i.e. 106954752) causes fb-client to crash if file is bigger than 10485760 bytes with traceback
Traceback (most recent call last):
[...]
 File "/usr/bin/fb", line 138, in upload_files
    if self.serverConfig is not None and (currentChunkSize + filesize > self.serverConfig["request_max_size"] \
TypeError: unorderable types: int() > str()

because api/v2.1.0/file/get_config returns "request_max_size" as string
Server specs:

Ubuntu 16.04
Nginx 1.10
PHP FPM 7.0.8

Merged as 47ad013fb3cdbac5f0b1276b0197d6def055e95e and f988ee7facaa3d389dd55eb2c86cc476e8ee7b6f. Thanks!


https://github.com/channelcat/sanic-openapi/issues/51

replace default responses with status code 200 by ones from decorator:
@doc.response(201, 'Created')
@doc.response(404, 'Not found')
def ...
if no responses declared by decorator default one is used:
{ "200":
{"description": None,
"examples": None,
"schema": serialize_schema(route_spec.produces) if route_spec.produces else None
}
}

implemented in #58
Eg
@doc.response(404, {"message": str}, description="When the garage cannot be found")


wip

test action

closing since we found what the issue is and checks are failing, opened #13 instead


[SPARK-6066] Make event log format easier to parse

Some users have reported difficulty in parsing the new event log format. Since we embed the metadata in the beginning of the file, when we compress the event log we need to skip the metadata because we need that information to parse the log later. This means we'll end up with a partially compressed file if event logging compression is turned on. The old format looks like:
sparkVersion = 1.3.0
compressionCodec = org.apache.spark.io.LZFCompressionCodec
=== LOG_HEADER_END ===
// actual events, could be compressed bytes

The new format in this patch puts the compression codec in the log file name instead. It also removes the metadata header altogether along with the Spark version, which was not needed. The new file name looks something like:
app_without_compression
app_123.lzf
app_456.snappy

I tested this with and without compression, using different compression codecs and event logging directories. I verified that both the Master and the HistoryServer can render both compressed and uncompressed logs as before.

Test build #28098 has started for   PR 4821 at commit 8db5a06.

This patch merges cleanly.

Tests will fail to compile. I'm fixing this in the mean time.

Looks reasonable, will wait for tests.

Test build #28098 has finished for   PR 4821 at commit 8db5a06.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28098/
Test FAILed.

Test build #28102 has started for   PR 4821 at commit ef69276.

This patch merges cleanly.

Test build #28103 has started for   PR 4821 at commit 519e51a.

This patch merges cleanly.

Test build #28102 has finished for   PR 4821 at commit ef69276.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28102/
Test FAILed.

Test build #28103 has finished for   PR 4821 at commit 519e51a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28103/
Test PASSed.

I took a pass on this with some feedback. Overall, it would be good to really minimize the scope of the changes since this is so late in the game. There is some clean-up and renaming etc that would be best just left out of the patch.
The main thing I'm wondering is why we need this header at all. It doesn't even ever get used by our own replay - we just ignore it. It seems like it was added for the purpose of conveying the compression codec to bootstrap replaying the file, however just having an extension seems like a better, much more standard way of doing that. The only argument I see for it is that the header could be used in the future to encode things that are necessary for proper replay of the logs. However, in that case I don't see why we can't just add it later if and when those things occur.
I guess I don't see a good argument against a straw man of just not having the header. Curious to hear thoughts from @andrewor14 and @vanzin.

Test build #28157 has started for   PR 4821 at commit 40e1ff6.

This patch merges cleanly.

As of the latest commit I have removed the Spark version and the metadata. Please have a look.

Test build #28158 has started for   PR 4821 at commit 59abee9.

This patch merges cleanly.

Test build #28159 has started for   PR 4821 at commit 7d6aa61.

This patch merges cleanly.

Test build #28157 has finished for   PR 4821 at commit 40e1ff6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28157/
Test PASSed.

Test build #28158 has finished for   PR 4821 at commit 59abee9.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class MatrixFactorizationModel(JavaModelWrapper, Saveable, JavaLoader):
class Saveable(object):
class Loader(object):
class JavaLoader(Loader):
        java_class = ".".join([java_package, cls.__name__])

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28158/
Test PASSed.

Test build #28159 has finished for   PR 4821 at commit 7d6aa61.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28159/
Test PASSed.

@pwendell the header is needed because it contains potentially useful information for the code parsing the logs. For example, now it contains the Spark version, which might be needed to tell the parsing code which properties to expect in the logs.
The original version of the change (the one that got rid of the directories and used a single file) encoded all metadata in the file name. The feedback was that it was ugly (long, cryptic file names) and brittle, since if you change the file name, you lose that information. I agree with that and thus the header was born.
Now we're back to encoding metadata in the file name. A simple extension is not to bad, though, espcially since you can probably figure out the compression codec by looking at the first few bytes of the file. But the header still provides useful information.
So I'm a little worried that the latest patch removes the metadata completely. Especially since it's common for the first event of the log to not be the one that contains the spark version (SparkListenerEnvironmentUpdate?), and instead be SparkListenerBlockManagerAdded.

@vanzin so just to be clear - you are anticipating a future case where we need to read the version to correctly parse the logs? Is that the argument for it? I am only making a simple observation that here we write something and never read it.

@pwendell yes, that's what I'm trying to say. Even today, logs generated by Spark 1.0, 1.1 and 1.2 (and soon 1.3) are not exactly the same - events have different properties. The metadata allows the parsing code to know what to expect.
(That is not a problem internally in Spark because the code handles all added/changed event properties using optionals and things like that, but there's no way to know whether we'll make a change in the future that prevents code like that from working without knowing the version of the data.)

Test build #28180 has started for   PR 4821 at commit 7f537cd.

This patch merges cleanly.

Test build #28180 has finished for   PR 4821 at commit 7f537cd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28180/
Test FAILed.

@vanzin okay then, let's add back a JSON metadata header to the file.

By the way I gained first-hand experience of the flakiness of FsHistoryProviderSuite from this patch. The tests passed locally but failed here, and I suspect that it has something to do with the modification time not varying enough between the file writes, though this is something we should fix separately.

Test build #28182 has started for   PR 4821 at commit 654883d.

This patch merges cleanly.

flakiness of FsHistoryProviderSuite

Do you have any theories for why this would be related to the log's modification time? The only place where it's used in FsHistoryProvider is for filtering entries in checkForLogs, and it's already a conservative check (it uses >= so that it picks up any new logs that show up with the same mod time as the last check, at the expense of re-parsing logs that haven't changed).

Test build #28182 has finished for   PR 4821 at commit 654883d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28182/
Test FAILed.

Test build #28198 has started for   PR 4821 at commit fdae14c.

This patch merges cleanly.

LGTM.

Test build #28201 has started for   PR 4821 at commit 8511141.

This patch merges cleanly.

Okay I took a close look through this and it LGTM

Test build #28198 has finished for   PR 4821 at commit fdae14c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28198/
Test PASSed.

Test build #28201 has finished for   PR 4821 at commit 8511141.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28201/
Test PASSed.


improve code style

@SunsetTechuila I checked your improvements and found nothing wrong. But for better security I might wait until @windowz414 review the code

@windowz414 could you please review this improvements for us?
Take your time.
Sorry If we are disturbing

Yes, I did

@nimsandu sorry for no replies, I was kind of busy with school matters and such. Let me have a quick glance at what this PR has in the store for us.

It's all right. You must consider your priorities

Yes, I did

No problems at all right?

of course, otherwise I would close this pull request or amend the commit

@SunsetTechuila SORRY for keep you waiting


@ options are illegible in light-mode

Which API Provider are you using?
Anthropic
Which Model are you using?
Claude 3.5 Sonnet
What happened?
In Light+ mode, there is too little difference between text color and highlight color when selecting in the @ menu.

Steps to reproduce

Set vscode color theme to Light+
Start new task
Type @

Observe that you can't read the selected item
Relevant API REQUEST output
No response
Additional context
No response

Thank you for reporting!

Fixed in the latest v3.0.4


Release 2.4

Motivation/Description of the PR
Applicable helpers:

[ ] Webdriver

[ ] Puppeteer

[ ] Nightmare

[ ] REST

[ ] Appium

[ ] Protractor

[ ] TestCafe

Description of this PR, which problem it solves

A link to the corresponding issue (if applicable).

Type of change

[ ] Breaking changes
[ ] New functionality
[ ] Bug fix
[ ] Documentation changes/updates
[ ] Hot fix
[ ] Markdown files fix - not related to source code

Checklist:

[ ] Tests have been added
[ ] Documentation has been added (Run npm run docs)
[ ] Lint checking (Run npm run lint)
[ ] Local tests are passed (Run npm test)

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/rerun.js  4

Clones added
============
- lib/rerun.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/rerun.js  4

Clones added
============
- lib/rerun.js  1

See the complete overview on Codacy