Custom UserClass without "username" errors out

I have a custom Account in my app, when we started the project we didn't needed a "username", we just wanted email addresses.
#Account Model

class Account(AbstractUser, PermissionsMixin):
    username = None
    first_name = None
    last_name = None
    email = models.EmailField("email", unique=True, blank=False)
    ...

USERNAME_FIELD = "email"
REQUIRED_FIELDS = [
        "name",
        "city",
..
]

So with this setting, when I try to start the project with your plugin integrated I always get an error:
django.core.exceptions.FieldError: Unknown field(s) (username) specified for Account
This is because you are checking if there is a "username" that is None.
What is a workaround for this? I cannot remove them because then I'll inherit the old ones which I don't have in the DB.
Adding values to them is also not a good idea, because I don't have anything in the DB related to them, so it crashes my app also.
Edit:
Just for the fun of it, I've changed them to Char
class Account(AbstractUser, PermissionsMixin):
    username = models.EmailField("username", blank=True)
    first_name = models.EmailField("first_name", blank=True)
    last_name = models.EmailField("last_name", blank=True)
    email = models.EmailField("email", unique=True, blank=False)
    name = models.CharField("name", max_length=30, blank=False)
    ....

    USERNAME_FIELD = "email"
    EMAIL_FIELD = "email"

I've set both username and email fileds to "email" because that is what I actually have in the DB, no username in the DB.
Just to test out how this works.
But now I receive the error:
 "message": "'ObtainJSONWebTokenInput' object has no attribute 'email'",
I guess it expects a "username" or something there.
I feel like your plugin is linked very much to this "username" field, which actually many apps don't use, and they have custom user/account classes that ignore that "username".
What solution do you propose to this problem?

I successfully setup gql_auth with the same requirement. It's a configuration issue.
try to add the following to your settings.py.
from gqlauth.settings_type import GqlAuthSettings, username_field, email_field, password_field
GQL_AUTH = GqlAuthSettings(
ALLOW_LOGIN_NOT_VERIFIED=False,
LOGIN_FIELDS={email_field, password_field},
LOGIN_REQUIRE_CAPTCHA=False,
REGISTER_MUTATION_FIELDS={email_field},
REGISTER_REQUIRE_CAPTCHA=False,
CAPTCHA_EXPIRATION_DELTA=timedelta(seconds=120),
CAPTCHA_MAX_RETRIES=5,
# CAPTCHA_TEXT_FACTORY=default_text_factory,
# CAPTCHA_TEXT_VALIDATOR=default_captcha_text_validator,
FORCE_SHOW_CAPTCHA=False,
CAPTCHA_SAVE_IMAGE=False,
UPDATE_MUTATION_FIELDS={},
)

from gqlauth.settings_type import GqlAuthSettings, email_field, username_field, password_field

AUTH_USER_MODEL = 'users.CustomUser'

GQL_AUTH = GqlAuthSettings(
    LOGIN_REQUIRE_CAPTCHA=False,
    REGISTER_REQUIRE_CAPTCHA=False,
    JWT_TIME_FORMAT="%Y-%m-%dT%H:%M:%S",  # A valid 'strftime' string for the token payload
    JWT_LONG_RUNNING_REFRESH_TOKEN=True,  # Enable refresh tokens
    JWT_EXPIRATION_DELTA=timedelta(minutes=60),  # Token expiration time
    JWT_REFRESH_EXPIRATION_DELTA=timedelta(days=7),
    EXPIRATION_ACTIVATION_TOKEN=timedelta(minutes=60),
    LOGIN_FIELDS={email_field, password_field},
    # LOGIN_FIELDS = {username_field},

)

# users/models.py

from django.contrib.auth.models import AbstractUser
from django.db import models

from gallery.models import Image

# Create your models here.

class CustomUser(AbstractUser):
    email = models.EmailField(unique=True, blank=False, max_length=254, verbose_name="email address")
    profile_image = models.OneToOneField(Image, on_delete=models.SET_NULL, null=True, blank=True,
                                         related_name='user_profile_image')  # Add this line

    USERNAME_FIELD = "username"  # e.g: "username", "email"
    EMAIL_FIELD = "email"  # e.g: "email", "primary_email"

    def __str__(self):
        return self.email

# users/schema.py
import strawberry
from gqlauth.user.queries import UserQueries
from gqlauth.core.middlewares import JwtSchema
from gqlauth.user import arg_mutations as mutations
from django.contrib.auth import get_user_model
from strawberry.extensions import QueryDepthLimiter, AddValidationRules
from gallery.schema import ImageType
from gallery.models import Image
import typing
from graphql.validation import NoSchemaIntrospectionCustomRule

@strawberry.django.type(model=get_user_model())
class CustomUserType:
    id: strawberry.auto
    username: strawberry.auto
    email: strawberry.auto
    first_name: strawberry.auto
    last_name: strawberry.auto
    profile_image: typing.Optional[ImageType]

@strawberry.type
class Query(UserQueries):
    @strawberry.field
    def whoami(self, info) -> CustomUserType:
        user = info.context.request.user
        if user.is_anonymous:
            raise Exception("Authentication Failure: You must be signed in")
        return user

    @strawberry.field
    def users(self, info) -> list[CustomUserType]:
        user = info.context.request.user
        if not user.is_authenticated:
            raise Exception("Authentication Failure: You must be signed in")
        return get_user_model().objects.all()

@strawberry.type
class Mutation:
    register = mutations.Register.field
    verify_token = mutations.VerifyToken.field
    update_account = mutations.UpdateAccount.field
    archive_account = mutations.ArchiveAccount.field
    delete_account = mutations.DeleteAccount.field
    password_change = mutations.PasswordChange.field
    token_auth = mutations.ObtainJSONWebToken.field
    verify_account = mutations.VerifyAccount.field
    resend_activation_email = mutations.ResendActivationEmail.field
    send_password_reset_email = mutations.SendPasswordResetEmail.field
    password_reset = mutations.PasswordReset.field
    password_set = mutations.PasswordSet.field
    refresh_token = mutations.RefreshToken.field
    revoke_token = mutations.RevokeToken.field

    @strawberry.mutation
    def set_profile_image(self, info, image_id: int) -> CustomUserType:
        user = info.context.request.user
        if user.is_anonymous:
            raise Exception("Authentication Failure: You must be signed in")

        try:
            image = Image.objects.get(id=image_id)
            user.profile_image = image
            user.save()
            return user
        except Image.DoesNotExist:
            raise Exception("Image not found")

schema = JwtSchema(
    query=Query,
    mutation=Mutation,
    extensions=[
        QueryDepthLimiter(max_depth=7),
        # AddValidationRules([NoSchemaIntrospectionCustomRule]),
    ]
)

the error above is the response I get

stale


Enable "NONEwithRSA" signatures with RSADigestSigner mechanism

This is same patch as the attachment on bcgit#485

Now RSADigestSigner works alike ...rsa.DigestSignatureSpi.
Specifically the derEncode() method works alike, and RSADigestSigner's constructor allows Null Digester to be used.
A side-effect is that any unknown digester will also produce unwrapped RSA signatures.
Should that be somehow detected?

Merged. Thanks. I've added a check to ensure the "null" hash can be parsed as a DigestInfo at least.


Enable/disable bots plugin by setting

Hi, any chance this could be added in future updates?
thanks


Update active-directory-passwords-writeback.md

updated overview to clarify pw writeback is supported for PTA users.

@benpahl : Thanks for your contribution to the Azure documentation! The author, @MicrosoftGuyJFlo, has been notified to review your proposed change.

#sign-off


Add Microsoft Live Oauth2 provider

@paulnice I think it's better to add this provider as a separate addon, for 2 reasons:

It avoids adding code to torii that is not used by all users, thereby keeping it lightweight.
You're not dependent on the maintainers of this repo to get your code published :-).

You can find examples of such addons on the third-party addons section of the readme.


[MM-58561] Calls: Add stop recording confirmation; update call screen

Summary

3 main changes:

Recording & Recording with transcription confirmation to match https://github.com/mattermost/mattermost-plugin-calls/pull/760
Update the call screen to balance the header with/without the loading and recording badge, following designs: https://www.figma.com/design/9HL2HADCQ0lLmn1RBOBGGV/Calls%3A-Recording?node-id=13-90030&m=dev
The call screen's duration timer needs to be changed from mm:ss to hh:mm (removing the ss) when duration goes over an hour (there isn't enough space)

call screen
rec loading
rec active
new stop rec confirmation

Ticket Link

https://mattermost.atlassian.net/browse/MM-58561

Checklist

[ ] Added or updated unit tests (required for all new features)
[x] Has UI changes
[x] Includes text changes and localization file updates
[x] Have tested against the 5 core themes to ensure consistency between them.
[x] Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

Android: 13, Pixel 6
iOS: 16.5.1, iPhone 14

Release Note
Calls: Added stop recording confirmation; redesigned the header of the call screen to better display recording badge

@abhijit-singh Can you take a look now? I made some changes: the left and right padding stays at 24 now. When the rec badge pops in, we increase the left and right width (but keep the collapse icon in the same place), which keeps the center title in the same position but reduces its width symmetrically. This way we can keep left/right balance, but maximize the center title size. Let me know what you think? We can go back to the original if you would prefer the time to not change (but then the center title will always be smaller).

Thanks @cpoile! Looks great visually now!


Allow shortcode content to be processed by Blackfriday etc.

I think the hardest part about this issue is to create an API that is both simple and not in conflict with what people use in the wild.
Currently, we have:

{{% myshortcode %}} which renders the inner content as markdown. This is the orignal Hugo syntax.
{{< myshortcode >}} Hugo does nothing to the inner content. This is the most useful, as shortcodes are built for creating inline HTML snippets, and Blackfriday have a tendency to do odd thing to those.

The common thing with the above is that Blackfriday (or Asciidoctor etc.) will never see the rendered shortcode content. We create temporary shortcode placeholders that plays nicely with Blackfriday. This is almost always what you (or I) want, as you can use any HTML constructs and not have to worry about it getting trapped in Blackfriday's smartypants filter etc. In the first versions of Hugo we did it the "other way", and people had all sorts of trouble.
But there are obvious use cases where you want your shortcodes to be part of the markdown files as rendered by Blackfriday. The most obvious is the inclusion of raw markdown data (e.g. from a page: (Site.GetPage ...).RawContent). What you would do today is typically to use .Content (already rendered) or readFile "somefile" | markdownify, but that content will not participate in the "global context" with table of contents numbering etc.
I think this will be even more useful once we get time set aside to do the Blackfriday v2, where one of the planned benefits is to provide a proper data structure for the ToC for you to present in any way you want (and get rid of the hard-to-style HTML we have today).
So,

In my head it should not be too hard to implement.
But we need a way to "mark a shortcode" to behave "like this". This should probably be in the shortcode definition? As opposed to when you use it?
So, if we give this thing the keyword name "foo" then we could do ... {{< myshortcode h-foo "other params" >}} or maybe layouts/shortcodes/myshortcode.foo.html...

Not pretty ... I don't want to add another delimiter for this unless I really have to.

/cc @digitalcraftsman @kaushalmodi @regisphilibert @anthonyfok @moorereason @onedrawingperday  and gang

I know you said you don't want to, but the most intuitive option to me is to use a different action/behavior modifier.
{{# myshortcode #}}

@moorereason for this fundamental case you are probably right ... Why the "#"?

I made it up.  Makes me think of Markdown titles.

I just realized the difference between the existing delimiters...
I'd like to stress the facts that the "editors", very much unfamiliar with Hugo templating and shortcode limitations, may already have a hard time remembering the difference in usage of both delimiters.
I suspect (but I may be wrong) that only the programmer will need to be aware of this third variation. So I would suggest we leave the editors out of it and don't add a third delimiter.
I would push for the use the template file naming suggested by @bep (myshortcode.foo.html) but since https://github.com/gohugoio/hugo/pull/3434 we already use the file naming for Output Formats, woudn't this lead to potential conflicts?

@bep,
I took another look at this today. I may be backing off of my previous suggestion, but I need some clarification on this proposal.
Here's what I take your proposal to be:

The HTML-shortcodes ({{< >}}) are out of scope for this proposal.
The markdown-shortcodes ({{% %}}) are in scope for this proposal.
Allow shortcode output to effect the BF Table of Contents.
Allow the full, after-shortcode-rendering Markdown be visible in .RawContent.

Shortcode
## mysection - {{ .Get 0 }}

Content
# Title 1

{{% section "Section A" %}}

Expected .RawContent
# Title 1

## mysection - Section A

So, am I incorrect on any of this?
I haven't looked at the shortcode rendering pipeline, but would it make sense to not render the shortcode with BF (only do text/template rendering) if the parent template is also Markdown?  Just merge the shortcode output into the parent and render once on final?
(Not sure I'm finished with my thought here, but I gotta run.)

@moorereason I read your post and started a reply about "I don't think that would work ..." But I deleted my comment. Thinking harder about it, I think you are spot on.
There are some challenges here (output formats, mainly), but it is the obvious best solution.

if the parent template is also Markdown

I think the important part here is that if the root shortcode is markdown then send it as part of the surrounding content to Blackfriday.

We render shortcodes inside out, so you will have support for nested HTML shortcodes if you want
The nested HTML shortcodes are included in what is sent to the MD processor today, so there should not be any change there.

There are some old issues here and threads in the forums about the TOC not picking up headings from shortcodes. Am I understanding correctly the outcome of this issue will solve the TOC thing? If so I can just link to here as reference.


Sparse reconstruction with GPU

After reading this MR, I understand that I need to build COLMAP manually to have CUDA support, and that I will be able to use CUDA in feature extraction and matching.
But I'm not sure if CUDA can be utilized also in sparse reconstruction? From what is see during the execution, CUDA is not utilized during the sparse reconstruction?

No, sparse reconstruction does not use CUDA, but MVS does. However, ceres starting from v2.1.0 supports CUDA for dense matrix factorizations, and could be used for small bundle adjustment problems.


Need help automatically running tracker with the game

I'm trying to run untapped tracker when I start MTGA. I'm able to run untapped manually with "protonhax run", but wasn't able to figure out how to make it run by itself

I am not familiar with the game, or how this untapped tracker automatically opens on Windows.
But a few options to do that are:

create a shortcut that starts the steam game and the untapped tracker.
create a bash script, and pass as launch option to steam.
update protonhax to init both at the same time, add an option that merges init  and  run.

For options 1 and 2, it will be something like

exec steam  steam://rungameid/12345  #alternatives: 1- steam -applaunch <appID> / 2- "$@"

exec  "execution of untapped" #ie: 1- "protonhax run untapped"

https://developer.valvesoftware.com/wiki/Command_line_options#Steam


proposal: deprecate Broadcast and Simple dispatcher

For broadcast -- it is only used by chain node, and only useful when chain node has single parallelism. If there are multi-parallelism chain actors, we should use multi-dispatcher to ensure each set of chain fragment gets its desired distribution.
For simple -- I didn't know why it exists. Seems only useful when exchange distribution is single. We can use NoShuffle exchange instead.

From my simple understanding of dispather, the connection between them should look like this, right?
        Dispatcher  -->  MergeNode B Actor Dispatcher
ActorA  Dispatcher  -->  MergeNode B Actor Dispatcher
        Dispatcher  -->  MergeNode B Actor Dispatcher

A Actor Dispatcher -->
A Actor Dispatcher ---> MergeNode B Actor Dispatcher
A Actor Dispatcher -->

Actors can have multiple outputs, and downstream actors can have multiple inputs. The illustration looks correct, but doesn't cover all cases.

Not sure.
There are also some other cases need Broadcast, e.g. NLJ with a small stream.


[FEATURE] Read side caching

We can implement a read side caching in the engine, to increase the read performance and lower the latency if the data was cached.

cc @keithalucas @derekbit

Rough design note

a LRU cache

configurable cache size
key: offset, value: block

IO path

read handleRead
  -> s.data.ReadAt
       -> cache.ReadAt(offset)
           -> foreach block
               -> hit, read data from cache
               -> miss, read data from replica
                    -> cache.Update
           -> merge and truncate block data to the request size
           -> return data

write handleWrite
  -> s.data.WritedAt
       -> cache.Invalidate(offset, size)
       -> generic write path

TBD

cache drop, need or not?

Rough design note

a LRU cache

It seems like we want to have this cache in the longhorn-engine controller process not the replica, correct?   @yasker did some analysis of other storage solutions and found that they do caching.  It might be useful to look at several them to see if they use LRU caching or one of the other caching approaches.
We should investigate implementing the cache with lock free algorithm because the cache will be accessed by multiple goroutines constantly.

configurable cache size

I think we will need to determine a default cache size eventually.

key: offset, value: block

IO path

read handleRead
  -> s.data.ReadAt
       -> foreach block
             -> cache.ReadAt(offset)
                   -> hit, read data from cache
              -> miss, read data from replica (generic read path)
                   -> cache.Update

The longhorn-engine controller doesn't have a fixed block size; it can handle ReadAt and WriteAts with any offset and length.   The longhorn-engine controller currently requests the same offset and length from the longhorn-engine replica that it receives from tgtd.   One of the bottlenecks in the longhorn-engine is the communication between the longhorn-engine controller and the longhorn-engine replicas.
I don't think it should have break up that ReadAt received by the longhorn-engine controller into multiple ReadAt messages with the cache block size to be sent to the longhorn-engine replica;  we should find which intervals in the request are not covered by the cache (i.e. the biggest offset length pairs that aren't covered by the cache).  For example, if our cache block size is 100, and the controller receives a ReadAt at offset 0 and length of 1000.  If offset 100 is in the cache, we should send the replica ReadAt(0, 100) and ReadAt(200, 800) not ReadAt(0, 100), ReadAt(200, 100), ReadAt(300, 100), ReadAt(400, 100), etc.
With the current design, there are a maximum of sixteen goroutines for handling ReadAt or WriteAt operations in the longhorn-engine controller.  The controller makes a new goroutine for each message received from tgtd, and tgtd has sixteen threads.  When a ReadAts received by the controller is broken up into multiple ReadAts to be sent to the replica, I'm not sure if we should use goroutines to send the individual ReadAts to the replica simultaneously or not use goroutine and send them sequentially.  Depending on the how much  ReadAts are broken up, if they are sent simultaneously,  it could result in a replica handling many more simultaneous operations being handled by a replica.
I think it does make sense to have the longhorn-engine controller have a fixed block size if we are going to add read side caching.  I feel like it may make sense to have the block size that is used for the cache to be big, maybe 4MiB to 16MiB.  I don't think we should make this configurable. This will result in reading more than the ReadAt requests.   Hopefully this could almost predict the next ReadAts; if data is being read sequentially, we may have the data for the next read operation in the cache already.   However, in this scenario, the multiple requests being processes at the same time may result in the same expanded ReadAt being sent to the replica.  For example, if the controller receives a ReadAt(0, 100) and a ReadAt(100, 100), if our block size was 1000, we could generated a ReadAt(0, 1000) for the replica for both of those operations.   Somehow we should have a mechanism to not send duplicate requests to the replica and have the second request use the result of the expanded ReadAt.   If we have to break up a ReadAt operation, a bigger block size in the cache will minimize how much we have to break it up.

       -> merge and truncate block data to the request size
       -> return data
```

write handleWrite
  -> s.data.WritedAt
       -> cache.Invalidate(offset, size)

Should put the WriteAt in the cache if we have enough to fill a block in the cache?

       -> generic write path
```

TBD

cache drop, need or not?

In generally, I think this is a good idea.  I think we need to have tests to demonstrate the amount of improvement this causes.   https://github.com/yasker/kbench was used to compare the performance between longhorn and other storage solutions.

After investigation the cache design in the open source storage projects, I found we need to pay lots of effort if we'd like to implement the read side cache in the longhorn-engine controller side.
Thus, I plan to introduce the dm-cache as our cache solution.
To achieve the read side cache, the steps are:

Create an empty file on the controller node's drive or memory for the cache device
Mount the empty file as a lookback block device
Turn the loopback block device as a cache device using dm-cache
Add the cache device on the top of the iSCSI block device

dm-cache supports writeback, writethrough and passthrough modes now, so the writethrought mode is suitable for our read side cache.
I'm implementing the PoC and will update the preliminary performance results.
@joshimoo @keithalucas
Do you have any suggestions and something I need to pay attention to?

@derekbit is it ok to lose the device for dm-cache? The engine is designed to be stateless and losing the engine should result in no data loss.

We need to have an LEP for future reference as well.

@yasker
Yes, I will use the writethrough mode, so the cache device is dedicated for the read cache. Each write is simultaneously updated to the cache device and replicas. Thus, losing the device is okay.
@innobead
No prob. After having the preliminary results, I'll draft it.

Environment

Kubernetes: v1.21.6+k3s1
Master node: 1
Worker nodes: 3

Volume setting

Volume size: 100 GiB
Number of replicas: 1 (pod and replica are on the same node to eliminate extra network overhead)

Cache setting

cache size: 25 GiB

Fio test
Refer to the test steps in https://lkml.org/lkml/2013/6/12/18

Warm up
Read the data into cache.
fio --direct=1 --size=90% --filesize=20G --blocksize=4K --ioengine=libaio --rw=rw --rwmixread=100 --rwmixwrite=0 --iodepth=64 --filename=/data/file --name=WarmUp --output=/tmp/warm-up.txt

Measure
fio --direct=1 --size=100% --filesize=20G --blocksize=4K --ioengine=libaio --rw=randrw --rwmixread=90 --rwmixwrite=10 --iodepth=64 --numjob=4 --group_reporting --filename=/data/file --name=Measure --random_distribution=zipf:1.2 --output=/tmp/fio-result.txt

Result

25G from memory is really big. We need to design a way to make it usable to the end user.
Also, does the result from kbench change? By design, it shouldn't. But we can add more benchmarks to it with the cache considered.

@yasker

25G from memory is really big. We need to design a way to make it usable to the end user.

25G is not from the memory. It's a file on engine node's filesystem and mounted as a loop device.
In this test, the advantages of the cache

the data is read into the cache device, the overhead of engine-replica is eliminated
the cache block size is 128 KB and result in the pre-read effect.

does the result from kbench change?

No. Because the cache test needs a warm up phase, I didn't use the kbench to test the performance.
I also plan to add the cache test part in kbench.

LEP is proposed.
https://github.com/longhorn/longhorn/pull/3448

Did a benchmark comparing the 100% rand read/write performance using ramdisk/SSD as a cache device.
The randwrite results were different from previous tests (randread:randwrite = 90:10), which might have been affected by read operations.
Setup

OS: ubuntu 18.04 (kernel: 4.15.0-162-generic)
Kubernetes: v1.21.6+k3s1
volume size: 100 Gi
file size: 10 Gi
cache block size: 32Ki

Performance

Randread (bs=4K, iodepth=16, numjobs=4)

#!/bin/bash

source_device="/data/file"
fio_blocksize="4K"
file_size="10G"
iodepth="16"
numjob="4"
output_path="fio-result"
hit="90"
loops=3

for ((i=0; i<${loops}; i++));
do
    # Warm up the cache
    fio --direct=1 --size=${hit}% --filesize=${file_size} --blocksize=${fio_blocksize} --ioengine=libaio --rw=rw --rwmixread=100 --rwmixwrite=0 --iodepth=${iodepth} --filename=${source_device} --name=${hit}_Hit_${fio_blocksize}_WarmUp --output-format=json --output=/tmp/WarmUp.${i}.txt
    # Run test
    fio --direct=1 --size=100% --filesize=${file_size} --blocksize=${fio_blocksize} --ioengine=libaio --rw=randrw --rwmixread=100 --rwmixwrite=0 --iodepth=${iodepth} --numjob=${numjob} --group_reporting --filename=${source_device} --name=${hit}_Hit_${fio_blocksize} --random_distribution=zipf:1.2 --output-format=json --output=/tmp/${output_path}.${i}.txt

    rm -rf ${source_device}
done

Randwrite (bs=4K, iodepth=16, numjobs=4)
Set --rwmixread=0 and --rwmixwrite=100

Then, check whether the sequential write performance degrades using bs=1M, iodepth=16, numjobs=1

Summary

Randread performs as expected.

Larger cache device enhances the randread performance because of the avoidance of the demotion/promotion operations.

Randwrite performance degrades.

Both the cache device and the iSCSI block device are updated in  writethrough mode.
Another possible factor is the demotion/promotion operations of dm-cache.

Seqwrite performance does not degrade because dm-cache detects the sequential write and does not write data to the cache device.

@derekbit it is sat that write get negative impacted. READ normally not an issue for longhorn, write is the real problem in my use cases for longhorn.

@liyimeng Thanks for your feedback. This is a preliminary investigation/study internally. The read-side cache targets some cases/scenarios such as low storage/network bandwidth or multiple applications contentions for storage resources. But as you mentioned, the Longhorn's write performance is not outstanding.

Moving back to the backlog, and will revisit in the future.


Add physics process delta timing to signals.

Adds new arguments to the physics and process signals.

Can break compatibility with methods directly connected to it.

These delta times can be easily accessed via a node's get_process_delta_time() and get_physics_process_delta_time().
If you want to access these from outside the node system, I think a better option is to expose SceneTree's get_process_time() and get_physics_process_time().

If you want to access these from outside the node system, I think a better option is to expose SceneTree's get_process_time() and get_physics_process_time().

You can do Engine.get_main_loop().root.get_process_delta_time().

This was attempted and abandoned previously:

https://github.com/godotengine/godot/pull/86858

See https://github.com/godotengine/godot/pull/86858#issuecomment-1879756929


Rent distribution

Implemented the monthly rent distribution:

The hook checks that

the number of payments is greater than 0
the free balance of the virtual account is greater or equal to the rent.

If both conditions are satisfied, one month's rent is distributed between the owners, according to their asset's share.
Maintenance fees are removed from the rent before distribution and reserved.

Codecov Report

Merging #242 (6c56048) into main (913468b) will increase coverage by 0.00%.
The diff coverage is 84.37%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   82.58%   82.59%
=======================================
  Files          69       69
  Lines        6737     6820   +83
=======================================
+ Hits         5564     5633   +69
- Misses       1173     1187   +14

Impacted Files
Coverage Δ

pallets/asset_management/src/lib.rs
76.96% <ø> (ø)

pallets/asset_management/src/mock.rs
92.00% <0.00%> (-3.84%)
:arrow_down:

pallets/payment/src/lib.rs
76.98% <ø> (-0.19%)
:arrow_down:

pallets/tenancy/src/lib.rs
80.00% <ø> (ø)

runtime/src/lib.rs
10.28% <0.00%> (-0.10%)
:arrow_down:

pallets/asset_management/src/functions.rs
88.01% <77.19%> (-3.34%)
:arrow_down:

pallets/payment/src/tests.rs
99.50% <100.00%> (-0.01%)
:arrow_down:

pallets/share_distributor/src/types.rs
100.00% <100.00%> (ø)

pallets/tenancy/src/functions.rs
87.23% <100.00%> (+2.61%)
:arrow_up:

pallets/tenancy/src/mock.rs
95.45% <100.00%> (+0.21%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


TypeError: Cannot read property 'default' of undefined

Describe the bug
TypeError: Cannot read property 'default' of undefined.
To Reproduce
Steps to reproduce the behavior:

Clone this repo react-native-elements-storybook
Run yarn storybook, everything works fine
Run yarn build-storybook
Serve

✗ npx serve .
npx: installed 78 in 2.953s

   ┌────────────────────────────────────────────────────┐
   │                                                    │
   │   Serving!                                         │
   │                                                    │
   │   - Local:            http://localhost:5000        │

Open localhost:5000 in the browser

Expected behavior
Work flawlessly the same as yarn storybook.

Screenshots
See above.
Code snippets
Anything is here.
System:

OS: MacOS
Device: Macbook Pro 2017
Browser: chrome
Framework: react-native-web
Version: 5.06

Additional context
I tried to make storybook for React Native Elements and React Native Web.

It was due to wrong webpack.config.js.
// add your custom rules.
{
  test: /\.js$/,
  include: [
    path.resolve(__dirname, '../node_modules/react-native-elements/'),
    path.resolve(__dirname, '../node_modules/react-native-ratings/'),
    path.resolve(__dirname, '../node_modules/react-native-vector-icons/'),
    path.resolve(__dirname, '../'),
  ],
  use: {
    loader: 'babel-loader',
    options: {
      cacheDirectory: false,
      presets: ['module:metro-react-native-babel-preset'],

Fixes, this commit:
// add your custom rules.
{
  test: /\.js$/,
  include: [
    path.resolve(__dirname, '../node_modules/react-native/'),
    path.resolve(__dirname, '../node_modules/react-native-elements/'),
    path.resolve(__dirname, '../node_modules/react-native-ratings/'),
    path.resolve(__dirname, '../node_modules/react-native-vector-icons/'),
  ],
  use: {
    loader: 'babel-loader',
    options: {
      cacheDirectory: false,
      presets: [
        ['module:metro-react-native-babel-preset', { 'disableImportExportTransform': true }]
      ],

build-storybook work flawlessly now. Result: http://rne-storybook.surge.sh
@shilman You can close this issue 🤝


fixes #12 Diff/Compare only selected file

this fixes the #12

Looks good, I will most likely merge as soon as I have tested it locally.


Software auto-update/update button

Hi,
A auto update feature or a update link to the GitHub page etc in the help menu would be awesome :)

This feature is already available. It was added a few days ago. You should get notified when new updates are available. @R9anSmart

Is there no easy link to the Github page etc that can be added to the windows version or something so I dont need to bookmark the page each time?

Is there no easy link to the Github page etc that can be added to the windows version or something so I dont need to bookmark the page each time?

You should be able to update from within the app when it is available. That said, the buttons in the help menu link to the github. I can add another button for releases in the future


contourf on curvilinear grid stretches (even without crs/projection)

import xarray as xr
ds = xr.tutorial.open_dataset('rasm')
ds.hvplot.contourf('xc', 'yc')

If I select a certain slice, the problem disappears
import xarray as xr
ds = xr.tutorial.open_dataset('rasm')
ds = ds.isel(x=slice(1, 230))
ds.hvplot.contourf('xc', 'yc')

Contour is fine though

So I don't understand how matplotlib fixes this without projecting. The fact is some quads indeed wrap around so the behavior is "correct" in some sense, even if it's not desirable.


Ai data masking fix

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.61%. Comparing base (ef31e09) to head (df21d5e).
Report is 157 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1420      +/-   ##
==========================================
+ Coverage   35.91%   43.61%   +7.70%
==========================================
  Files          69       76       +7
  Lines       11576    12320     +744
==========================================
+ Hits         4157     5373    +1216
+ Misses       7104     6614     -490
- Partials      315      333      +18

see 69 files with indirect coverage changes


How to disable seeking on media response?

How can I disable seeking on media responses? So the user cannot seek forward/backwards in the current playing track?
This is how I currently do it:
conv.add(new Media({
        mediaObjects: [{
        name: 'Trance Track 1',
        description: 'Media description',
        url: 'https://my-url.de/Trance1.mp3',
        image: {
          large: new Image({
            url: 'https://somewhere/whateverimage.jpg',
            alt: 'my image here'
          })
        }
    }],
        mediaType: MediaType.Audio,
        optionalMediaControls: [OptionalMediaControl.Paused, OptionalMediaControl.Stopped],
        startOffset: '0s'
    }));

I didn't find anything in the documentations on https://developers.google.com/assistant/conversational/prompts-media
Also didn't find anything on stackoverflow and didn't get any answer on stackoverflow, yet:
https://stackoverflow.com/questions/65039702/how-to-disable-manual-seeking-on-google-actions-assistant-conversations-media
So my last option is to ask here.

Is there a strict need for the user to be unable to seek? Potentially you can use a livestream of an mp3 rather than a static media file, which would make the content play as if it was live.

@Fleker, yes, there is a strict need, as it will be an action for a radio station but the files are static media files.

Any news here? Or any other suggestions than streaming?
Because seeking by code at the start should be possible, but not by the user. This is because it simulates radio streaming and should start at the same offset where the current "stream" is.

From my understanding sending a standard media file will always show seeking.

But how does tunein and the others solve this - do all a "real" stream? For example SWR1 - there is no "live" icon like on tunein so is this still a stream?
We would really need to disable seeking, as this is a licensing limitation.

TuneIn to my knowledge actually streams radio live.

Mhm... what can I do? As far as I know, there is no Developer Support contact mail address.

What developer support are you looking for?

Like amazon is providing direct support for alexa skill developers in a ticketing system. Which such a support I was able to solve several problems with alexa already. For example devices behaving different or other problems.
Because without being able to disable seeking we cannot use google assistant. :-(

I've filed a ticket internally.

Any news here?

Additionally I would need to disallow "next" (and "previous"). As skipping to the next track must be prevented, too.
(later I should be able to enable track skipping but with a very complex rule set)

@Fleker do you have any status update on that?

I don't have an update to share.

Hello @Fleker , and now? How could we get forward here?
Streaming isn't an alternative, as it has two problems:

Metadata for changing tracks will not be shown
the player uses "Content-Length" as stream length, this cannot be disabled.

It would be nice to hear from you.


Memory Leak

I've been using noble and bleacon for a while, for recording data from a few hundred BLE beacons broadcasting fairly frequently and have run into a memory leak with running simple tasks.
const noble = require('noble')

noble.on('stateChange', function (state) {
	if (state == "poweredOn") {
		noble.startScanning()
	}
})

noble.on('discover', function (perip) {
	console.log(perip.id)
})

And after half a day of running i get the following crash.

<--- Last few GCs --->
[2535:0x31dd550] 40825511 ms: Mark-sweep 1327.0 (1350.3) -> 1326.9 (1350.3) MB, 2171.0 / 0.0 ms  allocation failure GC in old space requested
[2535:0x31dd550] 40827774 ms: Mark-sweep 1326.9 (1350.3) -> 1326.9 (1348.8) MB, 2262.2 / 0.0 ms  last resort
[2535:0x31dd550] 40830039 ms: Mark-sweep 1326.9 (1348.8) -> 1326.9 (1348.8) MB, 2265.5 / 0.0 ms  last resort
<--- JS stacktrace --->

==== JS stack trace =========================================
Security context: 0xa2cb70a66a1 <JS Object>
    1: onDiscover [/home/avatar7/beacon_listener/node_modules/noble/lib/noble.js:~109] [pc=0x12f4b33a57bc](this=0x2b54c19c5ec9 <a Noble with map 0x390337a29299>,uuid=0x2d80e2fbf7f9 <String[12]: f074d2f5287e>,address=0x2d80e2fbf889 <String[17]: f0:74:d2:f5:28:7e>,addressType=0x1636abc12c29 <String[6]: random>,connectable=0x1636abc02421 <false>,advertisement=0x2d80e2fbf841 <an Object...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x134e91c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::NameDictionary, v8::internal::NameDictionaryShape, v8::internal::Handle<v8::internal::Name> >::New(v8::internal::Isolate*, int, v8::internal::MinimumCapacity, v8::internal::PretenureFlag) [node]
 7: v8::internal::Dictionary<v8::internal::NameDictionary, v8::internal::NameDictionaryShape, v8::internal::Handle<v8::internal::Name> >::EnsureCapacity(v8::internal::Handle<v8::internal::NameDictionary>, int, v8::internal::Handle<v8::internal::Name>) [node]
 8: v8::internal::Dictionary<v8::internal::NameDictionary, v8::internal::NameDictionaryShape, v8::internal::Handle<v8::internal::Name> >::Add(v8::internal::Handle<v8::internal::NameDictionary>, v8::internal::Handle<v8::internal::Name>, v8::internal::Handle<v8::internal::Object>, v8::internal::PropertyDetails, int*) [node]
 9: v8::internal::LookupIterator::ApplyTransitionToDataProperty(v8::internal::Handle<v8::internal::JSObject>) [node]
10: v8::internal::Object::AddDataProperty(v8::internal::LookupIterator*, v8::internal::Handle<v8::internal::Object>, v8::internal::PropertyAttributes, v8::internal::Object::ShouldThrow, v8::internal::Object::StoreFromKeyed) [node]
11: v8::internal::Object::SetProperty(v8::internal::LookupIterator*, v8::internal::Handle<v8::internal::Object>, v8::internal::LanguageMode, v8::internal::Object::StoreFromKeyed) [node]
12: v8::internal::Runtime::SetObjectProperty(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::LanguageMode) [node]
13: v8::internal::Runtime_SetProperty(int, v8::internal::Object**, v8::internal::Isolate*) [node]
14: 0x12f4b2c043a7

As a "hack fix" I've been using a cron to manually GC, but it's not a propper solution.
If you want me to grab the heap as it grows let me know.
Thanks for all the great work you've done in the Beacon space.

Which OS, node version, and noble version?

@duncanhoggan also what beacons are you using, do they advertise with (rotating) random addresses?

@jrobeson
OS: Ubuntu 16.04 LTS
Node: 7.10.0
Noble: 1.8.1
@sandeepmistry Using the estimote stickers through bleno and noble and yes they appear to be using the rotating addresses. I suspect that that is where the memory is going now that you mention it.

Hello,
I'm also experiencing the same thing.
I did some heap snapshots and I can see that "Peripheral" object is constantly growing. I would expect that if I set duplicates=False in startScanning
raspi-0-W
npm: 3.10.10
Node: v6.11.0

I noticed that here:
https://github.com/sandeepmistry/noble/blob/master/lib/noble.js#L167
The UUID is pushed into an array, but nothing I can see ever removes them. If allowDuplicates is true, this should probably be skipped, and if it isn't, there should probably be some sort of cleanup process to remove things that are old.
I'd also recommend using a hash instead of an array for _discoveredPeripheralUUids, with the UUID as key and an update time as value, so you can easily go through the keys and remove the old ones.

what do other bluetooth libs do to handle this situation? What heuristic do they use to clean up in the situation of rotating addresses?

I'm testing a set of changes that ages out cached peripheral information after a set amount of time. For the moment, I have it set to do this only when allowDuplicates is true and you are actively scanning.
I'll publish information about my fork and submit a pull request after I've tested it a little more.

I'm till testing, but I have a preliminary working version here, if anyone wants to look at it or test it out:
https://github.com/Atollogy/noble/tree/memory-leak-fix
In this branch, I've moved all the peripheral caching to a separate class. When allowDuplicates is false, the behavior should be the same as at present. When allowDuplicates is true, the cache is reset each time you startScanning(), and the cache is periodically swept, removing any entries that are not currently connected and have not been accessed or modified in more than 5 seconds.
That behavior should prevent the cache from growing indefinitely when allowDuplicates is true.
@duncanhoggan It sounds like you have a test case. If you could point the noble dependency for your test at that branch and re-run your test, that would be very helpful (also, make sure you set allowDuplicates to true when you start scanning). Here's a line you can copy into the dependencies section of your package.json file to make that easy:
"noble": "github:atollogy/noble#memory-leak-fix"

So I've been running this a while, and it helps, but it looks like the next layer (Gap) may also be caching advertisements by address. This appears to cause some memory growth over time, although it is slower than before the above changes.
The strategy of caching a previous advertisement and notifying with a mix of new and cached data is pervasive in this library, and can lead to some misleading results. Consider a beacon that sends an advertisement followed by a scan response. This library will notify once with the advertisement data, and then again with a mix of the original advertisement data and the scan response data. When a client receives a discovery notification from Noble, it isn't easy to determine if the advertisement being discovered is in the first category or the second.
The easiest way to fix the memory growth problem would be to not have the lower layers cache anything and just pass events through. If there must be caching and merging of events, centralize the logic for it in one place, such as the noble.js layer where (in my branch, linked above) I've added a cache that is managed and swept. It's probably difficult to change this behavior, though, without potentially breaking existing code.
If anyone has some thoughts about how to go about this, I'd love to hear them. I'm planning to proceed along these lines as I am affected by both the memory growth and double notification bugs.

In working through this, I'm assuming that the advertisement property of a Peripheral should contain the merged historical advertisement state, since that's sort of what it does currently. My plan is to add a second parameter to Noble's onDiscover() event (the first is the Peripheral) that contains just the current advertisement contents, in case a consumer wants to manage their own state.

I've added the pull request to address this issue.
As described above, and in the PR, there's a minor change to the interface for onDiscover(), where a second parameter has been added to contain the actual advertisement contents. The new cache behavior should be in effect when allowDuplicates is true. When allowDuplicates is false, the cache is not swept or cleared, leaving the behavior similar to the way it was before.
These changes also addressed some inconsistencies in how scan responses were being handled relative to the Bluetooth spec.


Navigator Stack doesn't work because of "RNReanimated" dependency

Description
Pod Install fails with error message :
[!] Unable to find a specification for React-RCTActionSheetdepended upon byRNReanimated``
React Native version
System:
    OS: macOS 11.4
    CPU: (8) arm64 Apple M1
    Memory: 107.31 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 15.11.0 - /opt/homebrew/bin/node
    Yarn: 1.22.10 - /opt/homebrew/bin/yarn
    npm: 7.8.0 - /opt/homebrew/bin/npm
    Watchman: 4.9.0 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Xcode: 12.5.1/12E507 - /usr/bin/xcodebuild
  Languages:
    Java: Not Found
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1
    react-native: Not Found
    react-native-macos: Not Found
    react-native-tvos:  0.64.2-1
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

Make a new build using react-native init TestApp --template=react-native-tvos@latest
yarn add @react-navigation/native
pod install (success)
yarn add react-native-reanimated react-native-gesture-handler react-native-screens react-native-safe-area-context @react-native-community/masked-view
pod install (fails with "Unable to find a specification for `React-RCTActionSheet" error)

Expected Results
It should successfully pod install. This error does not occur in normal ios react native projects.

same issue

same issue

It used to work, so I will try older versions of either RN-tvos or RNreanimated.

I have been testing Reanimated on TV this week, and found this issue.  I'm not sure why the dependency is there.  If I remove the ActionSheet and Vibration dependencies from the Reanimated podspec, everything compiles just fine.  I am considering whether or not to submit this as a bug on react-native-reanimated.

I have been testing Reanimated on TV this week, and found this issue. I'm not sure why the dependency is there. If I remove the ActionSheet and Vibration dependencies from the Reanimated podspec, everything compiles just fine. I am considering whether or not to submit this as a bug on react-native-reanimated.

It pod installs successfully if I use ^1.0.0 version of reanimated, but I cannot test if it builds because build is failing with now another Navigator Stack related error (dont know if I missed it before, or if I am doing something wrong now). Now im getting several build fail errors related to "react-native-screens" and things being "unavailable to tvOS" like "'searchTextField' is unavailable: not available on tvOS".

same issue

see my post above for workarounds that work until a fix is made.

react-native-screens has never compiled on tvOS without some patches, as far as I know.
In order to help people get past this and other issues with Reanimated, I've started a demo project, https://github.com/dlowder-salesforce/TVReanimated . It has the patches needed for Reanimated, screens, and svg packages, so that the tvOS target will compile and run at least some of the Reanimated examples.

The demo project https://github.com/react-native-tvos/TVReanimated now works correctly with the 2.2.0 version of react-native-reanimated and the latest react-navigation, on iOS, tvOS, and Android phone and TV.  The project uses patch-package to apply the small podspec and source code changes needed for Apple TV on a few packages.


Sealing API for v2

[ ] Removing type_map from public API??? -> Go through docs basically.
[ ] Don't construct DataType types in macro instead use accessors and setters and adding non_exhaustive on types.
[ ] specta::ts vs specta::export::ts -> it make autoimport annoying
[ ] Prune out TODO's

Is sealing good or bad? We really need to decide!


net/http: something about 100-continue

If client http header contain  Expect: 100-continue
client post multipart/form-data Sometimes there will be
"multipart: Part Read: WSARecv tcp ..138.250:80: i/o timeout"  ParseMultipartForm(102400) -> /mime/multipart/multipart.go 239
This is immediately returned error.
Did not arrive ReadTimeout
The same service, the same machine, open the IIS running do not have this problem.

I'm having trouble understanding your problem. Can you rephrase?

Duplicate of #3665?
Brad, if so, and you don't want to fix this now, change to milestone Unplanned.

I think this is a duplicate. Any use of Expect: 100-continue in client code is currently not going to work the way expected and OP calls this out immediately.

Closing as duplicate of #3665


Suggestion

I would be immensely grateful if this could be enhanced to block the "sponsored posts" as well. Nothing else can do this on mobile, so it would be greatly appreciated. Thanks!

Huh? It should be blocking the sponsored posts. Can you post a screenshot of the post in question? A logcat dump would also be helpful:
adb logcat -s "TumblrAdAway"

Actually, never mind. It is blocking them now. An older version wasn't
doing it but just confirmed it is working. Thanks!
On Thu, Mar 10, 2016, 23:35 Andrew Sun<EMAIL_ADDRESS>wrote:

Huh? It should be blocking the sponsored posts. Can you post a screenshot
of the post in question? A logcat dump would also be helpful:
adb logcat -s "TumblrAdAway"
—
Reply to this email directly or view it on GitHub
https://github.com/apsun/TumblrAdAway/issues/1#issuecomment-195201452.

Ah, okay. If it starts acting up again feel free to re-open this issue, I haven't updated the module in quite a few Tumblr versions since their ad loading code hasn't changed, so if the problem occurs again it's likely a bug in the module.

Thanks again! I'm also testing the Soundcloud module. Seems good so far...
can't stand those ads!
On Fri, Mar 11, 2016, 00:19 Andrew Sun<EMAIL_ADDRESS>wrote:

Ah, okay. If it starts acting up again feel free to re-open this issue, I
haven't updated the module in quite a few Tumblr versions since their ad
loading code hasn't changed, so if the problem occurs again it's likely a
bug in the module.
—
Reply to this email directly or view it on GitHub
https://github.com/apsun/TumblrAdAway/issues/1#issuecomment-195212748.


Crashes on startup on FreeBSD

Describe the bug
I've just installed Spotify-Player inside a freeBSD jail. It has been built with the default options. On calling spotify_player my it'll start rendering the "window" but then fails fatally creating a core dump.
To Reproduce
Install on FreeBSD and run.
Expected behavior
Application not crashing.
Log and backtrace
Core dump can be provided upon request. Buildlog:
spotify-player-0.16.3.buildlog.txt
Screenshots

Environment

OS: FreeBSD 13.2 (jailed)
Application version: spotify_player 0.16.3
Application features:  see buildlog

Additional context
This device has no sound connected. In the end it's meant to create a stream to another device that'll ultimately output the audio.

Can you see any logs/backtraces in the .cache/spotify_player folder?

Hi any updates on this issue? Otherwise, I'll close it.

Sorry, I was very sure I had sent an answer. The only thing I can see there is the core dump I was mentioning in the original ticket. It's a bit too big to add it to the ticket, but if anyone can use it I'm happy to figure out a way to provide the dump to someone working on it.

Can you send me the core dump to<EMAIL_ADDRESS>I can take a look to see if there is a problem.

Sorry, I was very sure I had sent an answer. The only thing I can see there is the core dump I was mentioning in the original ticket

Very weird because normally if you can spawn the UI window, there should be a log and backtrace created in the cache folder.

Probably not related, but had similar issue -- in my case spotify_player just exited after a couple of seconds. The issue was an already running spotifyd instance. In the logs I had this error:
ERROR spotify_player: Encountered an error when running the application: Failed to initialize the Spotify data: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.

Used v0.16.3 on NixOS.

Maybe it's jail related?
Running on FreeBSD 14 outside a jail and it works perfectly.
Installed with pkg.


Resharding

@enisoc @aaijazi
The doc is a starting point, really. If you have comments on it, maybe just LGTM this PR, and then let me merge it, and you can fix the doc directly... would probably be faster. :)

LGTM


fix benches, export codecs

Codecov Report

Merging #1528 (f83737c) into main (1a2ba70) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
- Coverage   93.81%   93.80%   -0.01%
==========================================
  Files         247      247
  Lines       45839    45839
==========================================
- Hits        43002    43000       -2
- Misses       2837     2839       +2

Impacted Files
Coverage Δ

fastfield_codecs/src/lib.rs
99.03% <ø> (ø)

src/fieldnorm/writer.rs
96.96% <0.00%> (-1.52%)
:arrow_down:

src/fastfield/multivalued/mod.rs
96.37% <0.00%> (-1.04%)
:arrow_down:

src/store/index/mod.rs
98.37% <0.00%> (+0.54%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[ts] useKeyboardJs arguments type error

Accroading keyboardJS docs,
the bind function accepts string or strings[] (it's equal to or operator)
keyboardJS.bind(['a + b > c', 'z + y > z'], function(e) {
  console.log('a and b then c or z and y then z is pressed');
});

But useKeyboardJs.ts only accepts string argurment
https://github.com/streamich/react-use/blob/a53c8c5e0e91e26b4fe0a5e4e05f623b2c0ec672/src/useKeyboardJs.ts#L4-L19

the useKeyboardJs storybook is broken in my chrome
maybe something wrong with it
https://github.com/streamich/react-use/blob/1c84e7e03c7590eac55086fb73ca428b44b9d4fd/src/__stories__/useKeyboardJs.story.tsx#L4

:tada: This issue has been resolved in version 10.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update thorvg to 0.8.3

Simply changed the version in the script file and ran it.
fire mentioned this fixes some bugs in Godot itself.

I have added a few lines to update-thorvg.sh that add newlines to sources if they are missing.

Thanks!


shell: source codel cleanup

Minor style and formatting updates in shell source files.
Removed obsolete '\r' characters.
Static functions cleanup.

Codecov Report

Merging #12067 into master will decrease coverage by 0.01%.
The diff coverage is 41.31%.

@@            Coverage Diff             @@
##           master   #12067      +/-   ##
==========================================
- Coverage   48.05%   48.03%   -0.02%
==========================================
  Files         281      281
  Lines       43414    43453      +39
  Branches    10404    10412       +8
==========================================
+ Hits        20862    20873      +11
- Misses      18403    18428      +25
- Partials     4149     4152       +3

Impacted Files
Coverage Δ

subsys/shell/shell_wildcard.c
78.66% <ø> (ø)
:arrow_up:

subsys/shell/shell_utils.h
80% <ø> (ø)
:arrow_up:

subsys/shell/shell_help.c
74.39% <100%> (ø)
:arrow_up:

subsys/shell/shell_cmds.c
44.53% <100%> (ø)
:arrow_up:

subsys/shell/shell_utils.c
45.25% <100%> (+1.25%)
:arrow_up:

subsys/shell/shell.c
22.1% <36.84%> (-2.43%)
:arrow_down:

subsys/shell/shell_ops.c
26.22% <42.85%> (+3.15%)
:arrow_up:

subsys/shell/shell_ops.h
47.16% <47.22%> (-5.47%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea1e23...f131a87. Read the comment docs.


[Bug] Ability modifiers in attack bonuses do not seem to work on ammunitions

I was fiddling around trying to setup a custom ammunition in my campaign, trying to hack my way around making the "Magic Stone" cantrip work as-is without having to fiddle with the ammo or duplicate my player's weapon 😄 So I used the following process to make it as simple as possible:
@mod - @abilities.dex.mod
But then I was greeted with the following error:

So, I thought that maybe using @mod could be the culprit for some reason, so I tried expanding it into @abilities.wis.mod

No luck yet... I made a bunch more tests, including only adding a single attribute in the attack bonus to check if making calculations was an issue in this specific scenario, but it was still refusing to work :(
I checked to see if the "summary" bulletpoints on the left were perhaps glitching (which would have given me a clue), but... the equation was actually calculating the bonus correctly!

So my conclusion was, "If the computation on the item's card is correct, it means the equation is supposedly parsed as it should, so could it be a bug from one of the latest releases?"
I made one last test, which is to put the same equation onto a weapon, NOT onto a piece of ammunition. And it worked!
So if my testing is correct, interpolation equations do not work on attack rolls for ammunition exclusively - it still works on weapons though
EDIT: I forgot to mention, but of course the bug was replicated on a fresh table with no module, Foundry v11 Build 315 and DnD5 3.0.1

I guess we're not evaluating ammo bonuses against the weapon's rollData? I think we do add ammo bonuses to weapon attack and damage rolls so this seems like a bug.


Deadline submission- Review my Project 1

/cc @codepathreview

:+1: Nice work! The point of this homework was to get a chance to implement a TableView (one of the most common views in iOS) and to work with real data over the network (in this case from the Movies Database API).
A key part of these projects is that you add additional features and tweak the UI / UX because that will provide the most learning opportunities. We encourage you to complete the projects early each week with the required stories and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.
We have a detailed Project 1 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.
If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at<EMAIL_ADDRESS>


[Scheduler][Storageelement] Byte conversions are inconsistent and mostly wrong

Size conversions of Bytes are inconsistently converted to MiB and GiB, etc.
In storageelement.py it is consistently converted with factors of 1000.
In scheduler.py this is sometimes converted with factors of 1000 for memory or 1024 for disk.
This should be consistently changed to 1024.

@HerrHorizontal, attention here! It is not the internal usage that is inconsistent but the imported types. So it is on purpose that we sometimes use 1000 or 1024. However, internally we should always deal with Bytes.

Closing this, as the conversions are intentionally.


Standardize terminology in API endpoints

Some endpoints expect a "query" parameter and other expect a "word" parameter. This should be standardized (probably to "query", in order to support multi-word queries)

Likewise output formats should be standardized: compare list of strings from getNumberSystems vs list of JSON objects from canParse

Closing. commodities.json endpoint still needs restructuring but that belongs to issue #12


two requests: bitcoin and french stock market

Hello, everyone.
As a part of my studies in AI, I am trying to develop a "proof of concept" for a project right now,
I would like to use qlib for two goals:
1 Forecast and predict the bitcoin prices.
2 Forecast and predict stocks in the French stock market.
I downloaded the required data for both cases (all daily changes for bitcoin since its inception, the last 11 years for the 26 more important stocks in the French Stock Market), then I successfully transformed the csv files into qlib format and place the qlib data in the corresponding subdirectories.
However, I do not know how to run the qlib models against it.
I modified the .yaml configuration files for several models (mostly the dates in them), but I get dozens of execution errors. I would like to know what I should do in order to make it work.
For region, I chose REG_US in both cases as the parameters fit in these two cases.
In the case of CAC40 French market, I got the following error:
[12904:MainThread](2022-02-23 12:49:06,766) ERROR - qlib.workflow - [utils.py:38] - An exception has been raised[IndexError: list index out of range].
Too little data, perhaps?
In the case of bitcoin, I get the following message:
ValueError: operands could not be broadcast together with shapes (3613488,) (0,)
The configuration files should be modified for both cases, but I do not know what changes need to be done.
Any help would be appreciated.
Johnny

@johnnytorresm Hi,

You can use the following code to see if the data is successfully dumped:

before the csv data is dumped, the datetime field of each stock needs to be matched to its calendar in the exchange

import qlib
from qlib.data import D

qlib.init(provider_uri="your qlib data dir", expression_cache=None, dataset_cache=None)
df = D.features(D.instruments("all"), ["$close", "$open", "$high", "$low", "$volume"])
print(df.head())

Thank you so much, sir.
Very useful information.
best regards,

Johnny Torres
<EMAIL_ADDRESS>Mobile: +33 (0) 6 14 35 45 83
Skype : johnnytorresm
CyberSysNet - True Business Intelligence
<EMAIL_ADDRESS>
From: Pengrong Zhu @.>
Sent: Monday, February 28, 2022 2:36 PM
To: microsoft/qlib @.>
Cc: johnnytorresm @.>; Mention @.>
Subject: Re: [microsoft/qlib] two requests: bitcoin and french stock market (Issue #927)
@johnnytorresmhttps://github.com/johnnytorresm Hi,

You can use the following code to see if the data is successfully dumped:

before the csv data is dumped, the datetime field of each stock needs to be matched to its calendar in the exchange
import qlib
from qlib.data import D
qlib.init(provider_uri="your qlib data dir", expression_cache=None, dataset_cache=None)
df = D.features(D.instruments("all"), ["$close", "$open", "$high", "$low", "$volume"])
print(df.head())
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/qlib/issues/927#issuecomment-1054264497, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APJZO2KD6DXHJH7LJK5DF3TU5N27FANCNFSM5PEF5ERQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>


add aar-doc to tools

This tool can be used to automate the creation of documentation for roles by reading the meta-files from roles

@rndmh3ro could you please rebase the PR?

Thanks, rebased.

@rndmh3ro cool, thanks for the contribution!


Update logic on Automatic Import deletes Bone Attachment

Operating system or device - Godot version:
Windows 10, Godot 2.1.2, and Blender 2.78c with the Better Collada Exporter.
Issue description:

On Blender, I have created a basic model/animation, and exported to Godot.
On Godot, I have Attached a "Bone Attachment" as a child of the Skeleton node, as the documentation says.
Everything works fine, but if I need change anything on my model, when export in Blender, Godot will automatic update everything, and the "Bone Attachment" will be deleted.
I have worked with Unity before, but I have to say that I never had problem updating changes, but I'm having a hard time to understand the best workflow with Godot... how I'm supposed to work with "Bone Attachment", if everytime I update a scene get lost?
My english is not that good, sorry :D... so here a short video for help -> https://www.youtube.com/watch?v=3fzDFM5AE8g
Also the documentation is not really useful on this... so i'm not sure if is a issue or not.
In any case, I would like to suggest a better explanation on how deal with that on the documentation.
Thanks <3

I think you should have posted this on QA or forums, since it is a question rather than an issue with the underlying code.
If I remember correctly, once ago we had a system to detect changes to imported scenes and preserve them, but, as you can probably guess, it hardly worked properly, so it was removed.
This means that no changes to the imported scene will be persisted.
That's why you should generally use "inherited" scenes, which would get all nodes and data from a base scene (in this case the imported one), and can have additional nodes on top of it.
If you think it is about the documentation, you can reopen it on godotengine/godot-docs, since this repository is only about the C++ code of the engine, editor, and a few selected modules.

If the logic update has removed, this is a big problem and BIG change... OMG i losed so much time because of this -> Update Logic Documentation :sob:

That's why you should generally use "inherited" scenes, which would get all nodes and data from a base scene (in this case the imported one), and can have additional nodes on top of it.

I'm already doing this, the problem is that "Bone Attachment" (Documentation) needs to be used inside the imported 3D scene...
Maybe a possible solution would be make "Bone Attachment" works outside of the imported 3D scene, adding a option to the user choose to witch "Skeleton" wants to work, and then you can choose the "Bone"?

@rafaela-ip Sorry for not replying, was doing other stuff so far...
Would you mind opening an issue on https://github.com/godotengine/godot-docs for the Update Logic documentation while at it?
In post-2.1, we usually do this by creating a new "inherited" scene, which inherits the imported scene, and then just add the node we want into it.
Because it is possible to do this, I'm not absolutely sure how useful a boneattachment "skeleton" property would be, but I guess it might have some future, so feel free to discuss.

Yeah this is not an issue with bone attachment, more with not proper work-flow. In 3.0 the editor almost forces user to create inherited scene for imported models so don't think any more actions are necessary.

Closing, as the import workflow has changed a lot since Godot 3.0.


create-uaa-creds job in pipeline fails if another deployed product matches cf-

Found an issue where create-uaa-creds fails to extract the UAA credentials from opsman when another product includes the text cf-
In this case we had Hazelcast tile installed which shows up as hazelcast-pcf-abcde12345
As a result this line https://github.com/pivotal-cf/prometheus-on-PCF/blob/master/pipeline/tasks/create-uaa-creds.sh#L10
Returns: cf-abcde12345 hazelcast-pcf-abcde12345
It then tries to query for UAA Admin credentials using the above as $cf_id which of course fails.
Query should be improved to account for Hazelcast (and any other tile involving cf in the name).

Thanks Éamon! I've implemented a partial fix for now - should work in your case and most other I guess. Technically still not perfect but I'm not sure a perfect fix is possible (I guess a regex would be better but still potentially someone can deploy another cf-XXXXXXXX alongside actual PCF ERT deployment).


Question: about gRPC

Hi, first, you are doing a great work. keep it up.
i did read about the gRPC introduction to FE. gRPC exits because of its speed and most of all its interoperability.  When you say the feature is built based on grpc core and uses messagepack.  what does it keep and what does it leave out ? can you explain it further please ? can proto still be used with FE? (not vouching for it as i prefer messagepack actually)
thank you in advance.

FE gRPC offerring trades interoperability for convenience. i.e. both client and server components can only be .NET apps. similarly to magiconion.
messagepack's contractless resolver is used. so each message contains the propery/field names. this increases the message payload size a bit. but requires less effort from the developer to code/maintain. basically behaves like json serialization.
so yeah, at the expense of increased payload size and the loss of interoperability, you get a very developer friendly way to do remote procedure calls/pub-sub messaging via gRPC communication protocol.
and... when you do need iteroperability + leanest possible message payload size, there's nothing stopping you from doing regular gRPC in your FE application as usual.
this feature was built mainly because 99% of the time, i don't have non-dotnet applications/microservices communicating with my dotnet apps and maintaining .proto files was just a waste of energy.
hope that clears things up. let me know if you have anymore specific questions.
cheers!

thank you.. that clears it.


Add sample table owner data to quick start (#139)

Summary of Changes
Sample quickstart data for table owners (and possibility of ingestion custom data using sample_table_owner.csv file).
TableOwner init method API changed to accept both List and comma-separated str of owners.
Tests
Existing TableOwner test has been extended.
Documentation
No new documentation.
closes lyft/amundsen#139

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #150   +/-   ##
======================================
  Coverage    83.3%   83.3%
======================================
  Files          57      57
  Lines        2798    2798
  Branches      295     296    +1
======================================
  Hits         2331    2331
  Misses        378     378
  Partials       89      89

Impacted Files
Coverage Δ

databuilder/models/table_owner.py
75.6% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d69b6a...bbf6ffd. Read the comment docs.

Oh yeah - and one small GitHub trick:
If you edit the text in https://github.com/lyft/amundsendatabuilder/pull/150#issue-329701419 above and add for example

closes https://github.com/lyft/amundsen/issues/139

...it will automatically close that issue on merge. See https://help.github.com/en/articles/closing-issues-using-keywords

thanks, lgtm


Submission Process Quartz Job

Will function as the record of all of the actions the users take while walking through the Submit Process to give an official record of each individual process.

Requirements

[ ] One Endpoint to POST JSON Payload all of the records they are trying to submit, with records of when they click cert statements, verified check box, etc.

After May 15th Deadline


Add license file

License file seems missing from the repo, see https://help.github.com/articles/licensing-a-repository/

License have been added, https://github.com/kyushy/kibana-xlsx-import/commit/b3ae714617b8b9bce5e4d41a2aa5d7d7108a49f5


Remove top-level kmeans example

At the moment, there's a repeat example of the k-means algorithm example: one in the linfa-clustering package, and one in the top-level crate examples/ directory.
With a limited number of algorithms, I suppose it's possible to have an example of each in the top-level crate, but I think it will be neater if examples are kept in their respective packages.
I'm doing a review of the -clustering module at the moment, so would be happy to take care of this when I'm ready to submit that PR.

done in #38


MacOS github runner deprecated

The workflow for publishing the PyPI package currently uses the macos-11 runner for making the MacOS build. It looks like this was just recently deprecated: https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/. The publishing workflow is now just hanging forever.
There are several replacing runners: macos-12, macos-13, macos-14, and macos-latest. I don't use Mac so I don't know what the differences between the versions are. @yakutovicha I think you were using ppafm on a Mac. Do you have any opinion on this?

I tested and it seems to build on macos-latest. I cannot test whether the built wheel actually works, so I'll just assume it's fine. I'll make a PR with this.

Unfortunately, the build didn't work. The downloaded package didn't contain the '*.so' files.
The latest version of the application that worked for me (Mac, Apple M1 Max chip) is 0.2.2. The installation, however, does the compilation of the code directly on my computer.


ENH: default value for locationcodes.to_description

Problem
An error being raised when trying to get a descriptor can be annoying to deal with.
Solution
Default value.

Fixed in v0.0.5.dev. See comment on PR


Fix the entrypoint of asn1ate

As defined in setup.py, asn1ate define an entry point 'asn1ate' which is probably more straightforward than looking for the full path to the script.

Codecov Report

Merging #145 into master will decrease coverage by 17.17%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #145       +/-   ##
===========================================
- Coverage   85.68%   68.51%   -17.18%
===========================================
  Files          29       29
  Lines        4074     5095     +1021
===========================================
  Hits         3491     3491
- Misses        583     1604     +1021

Impacted Files
Coverage Δ

pyasn1/codec/ber/decoder.py
52.83% <0%> (-33.53%)
:arrow_down:

pyasn1/codec/der/decoder.py
62.06% <0%> (-32.67%)
:arrow_down:

pyasn1/codec/native/decoder.py
57.14% <0%> (-27.71%)
:arrow_down:

pyasn1/type/char.py
65% <0%> (-27.13%)
:arrow_down:

pyasn1/debug.py
68.96% <0%> (-25.16%)
:arrow_down:

pyasn1/codec/der/encoder.py
56.75% <0%> (-24.02%)
:arrow_down:

pyasn1/codec/cer/decoder.py
69.76% <0%> (-23.99%)
:arrow_down:

pyasn1/codec/native/encoder.py
65.04% <0%> (-22.88%)
:arrow_down:

pyasn1/codec/ber/encoder.py
69.63% <0%> (-20.27%)
:arrow_down:

pyasn1/codec/ber/eoo.py
80% <0%> (-20%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d435a...1d73e3b. Read the comment docs.

Makes sense, thank you!


[2023 API call Social media Quarterly reminders] MP Telemetry

Yearly Spreadsheet Media Inventory
Media Description
#MicroProfileTelemetry enables @jakartaee RESTful Web Services automatically to be traced if configured.
Join its weekly Monday discussions. Your participation ensures the continued growth & development of a well-governed, vendor-neutral #opensource API.
https://bit.ly/calendar-zoom-minutes
Quarterly reminder
1 every quarter
Ideally, a reminder goes out 4 times per year, always on a Monday before the call.
Design Card
Highlight Monday
6 to 6:30 AM PDT- time needs to be transferred to EU time
Notes


[Feature] Store position of labels after dragging

What problem does this feature solve?
We are using dragable labels, so that a user can fine-tune his visualisation (esp. overlapping labels).
    labelLayout: (params: any) => {
      return {
        align: 'left',
        x: params.labelRect.x,
        y: params.labelRect.y,
        draggable: true
      }

When we toggle between hide and show labels, the position of the labels is reset - and a user needs to drag the labels again.
Also, all labels are resetted when a new data point is added. This makes sense when the overall scale of the chart changes, but with fixed x-/y-axis there should be no harm keeping the label positions as well.
Thank you very much!
What does the proposed API look like?
?

Hi, @snibbo (or anyone else interested in this issue), did you ever figure out a solution for this issue? I have a similar use-case for storing the label positions. Thank you!


Accents in TextField widget do not work (Flutter 2.0.1 Desktop Windows - Beta Channel)

Hi,
Accents in TextField widget do not work.
For example, the word "camión" (Spanish) when written is displayed as follows:  "cami¨¨on".
Neither Flutter version of either channel solves this problem.
Therefore, flutter desktop windows cannot be used to develop desktop windows applications in Spanish.
Regards,
Jose.

/cc @cbracken

Seems like duplicate of https://github.com/flutter/flutter/issues/75510?

Yep, missed that one. https://github.com/flutter/flutter/issues/75510


Maroom - Interior Design Landing Page

Is your feature request related to a problem? Please describe.
The feature is to add a landing page for a interior design brand named Maroom.
Describe the solution you'd like
This is built using HTML, CSS and Bootstrap

@Ayush7614 I would like to work on this as a part of HCSSoC'21


User Input using Java

I have a small program that uses user input, nothing fancy. When typing my input in the field nothing happens and i don't know how else to provide the input. Whats important is that i do not want to change or modify the code in any way.

this code does in fact run perfectly fine when trying it out on my mac, did this to be sure there weren't any errors. Now the question is what to do on my IPad, since i can't carry my Mac Mini around.


Add retry logic for docker pull / configure docker pull behavior

Integration tests demonstrate that docker pull failures occur due to retries..
Should add simple logic to retry docker pulls if they fail due to timeouts.
Additionally should provide IfNotPresent/Always/Never control for pulls made for a build.

closed by #75


Fix crash when setting text-inactive-pixel in rcfile

Prior to fix:
[lambdadog@taiga:~/devel/worm]$ DISPLAY=:1 ./worm
19:40:33 | INFO | wm.nim:35 | Opened display
19:40:33 | INFO | worm.nim:25 | config file found, loading...
19:40:33 | INFO | worm.nim:27 | config file loaded!
19:40:33 | INFO | clientmessage.nim:211 | Chaging text inactive pixel to -16777216
/home/lambdadog/devel/worm/src/worm.nim:29 worm
/home/lambdadog/devel/worm/src/events.nim:36 eventLoop
/home/lambdadog/devel/worm/src/events.nim:28 dispatchEvent
/home/lambdadog/devel/worm/src/events/clientmessage.nim:213 handleClientMessage
/nix/store/k66ff7hq2g0zllyjdv6ll1w8m18h38xj-nim-unwrapped-1.6.4/nim/lib/pure/options.nim:222 get
Error: unhandled exception: Can't obtain a value from a `none` [UnpackDefect]

thanks!

@codic12 did you mean to merge this?

I did, but I got locked out of my github account apparently... will merge when I get access back.


fix(@angular-devkit/build-angular) changing order of event and coverage reporters

Fixing an issue when event reporter is executed before coverage reporter, which was causing the test command to pass even though unit testing coverage thresholds were not met. Closes https://github.com/angular/angular-cli/issues/10940

@hansl has this been released? in version 6.1.0 I am still seeing this issue occur.


Fix periodic square_lattice point

Description
Fix square_lattice from https://itensor.discourse.group/t/multiple-exchange-interactions-in-2d-lattices/692
Previously the point pair was (x,1)->(x,1+Ny) and now will be (x,1)->(x,Ny)

Perfect, thanks Ryan!


Fix Objective-C compatibility

Thanks for creating ARSLineProgress and maintaining it!
I noticed that on version 3.0.0 (after the Swift 4.2 migration) some public methods are no longer accessible from Objective-C. This PR exposes the missing members to Objective-C.

Thank you for your PR Johannes! 👍


Cannot assign anymore to material.clipSpaceTransform

In everything up to and including 1.8.1 it was possible to have a vertex block like
vertex {
    void materialVertex(inout MaterialVertexInputs material) {
        material.clipSpaceTransform = mat4(2.0);
    }
}

In the current main branch, this makes matc bail out with
ERROR: depth_main.vs:24: 'material' : undeclared identifier
ERROR: depth_main.vs:24: 'getClipSpaceTransform' : no matching overloaded function found
ERROR: depth_main.vs:24: '' : missing #endif
ERROR: depth_main.vs:24: 'assign' :  cannot convert from ' const float' to ' gl_Position highp 4-component vector of float Position'
ERROR: depth_main.vs:24: '' : compilation terminated
ERROR: 5 compilation errors.  No code generated.

Seems to happen independent of platform or api.
Has this api changed or is this a regression? Thanks!

It's a regression. The clip space transform wasn't applied to depth shaders, looks like the fix introduced its own issue. We'll fix it.

I just pushed a fix in https://github.com/google/filament/commit/3092063ebba2cb24a6dfc5ff97121fdfa09e1da1. Sorry for the trouble.


openocd: rework configuration flags

Description of changes
I noticed that some of the configure flags passed to openocd were no longer supported by version 0.12. These were removed. Additionally, I felt it was inappropriate for nixpkgs to select 2 hardware platforms to enable without having any support for others. To avoid having to mess with overrideAttrs, I added an optional list of strings with the names of the hardware configure flags that can be passed to openocd with override.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Is there a reason why not to enable ALL hardware platforms?

At least we can enable the ones most used, so the default in hardwareSupport ? [] is not empty, but can be still overridden.

Defaults are already added by the upstream configure script (see below). Additionally, there might be some incompatibilities between hardware platforms (speculation on my part). Finally, there are some deprecated boards that will be disabled upstream, but can still be enabled this way.
OpenOCD configuration summary
--------------------------------------------------
MPSSE mode of FTDI based devices        yes
ST-Link Programmer                      yes (auto)
TI ICDI JTAG Programmer                 yes (auto)
Keil ULINK JTAG Programmer              yes (auto)
Altera USB-Blaster II Compatible        yes (auto)
Bitbang mode of FT232R based devices    yes (auto)
Versaloon-Link JTAG Programmer          yes (auto)
TI XDS110 Debug Probe                   yes (auto)
CMSIS-DAP v2 Compliant Debugger         yes (auto)
OSBDM (JTAG only) Programmer            yes (auto)
eStick/opendous JTAG Programmer         yes (auto)
Olimex ARM-JTAG-EW Programmer           yes (auto)
Raisonance RLink JTAG Programmer        yes (auto)
USBProg JTAG Programmer                 yes (auto)
Espressif JTAG Programmer               yes (auto)
Andes JTAG Programmer (deprecated)      no
CMSIS-DAP Compliant Debugger            yes (auto)
Nu-Link Programmer                      yes (auto)
Cypress KitProg Programmer              yes (auto)
Altera USB-Blaster Compatible           yes (auto)
ASIX Presto Adapter                     yes (auto)
OpenJTAG Adapter                        yes (auto)
Linux GPIO bitbang through libgpiod     yes
SEGGER J-Link Programmer                yes (auto)
Bus Pirate                              yes
Use Capstone disassembly framework      no

This PR was tested on a FPGA (RTA-7 w/ RISC-V debug hub) and works by default (with the empty hardwareSupport list).

Defaults are already added by the upstream configure script (see below).

Make sense, now I understand. Maybe just rename hardwareSupport to extraHardwareSupport to make it more obvious?

Make sense, now I understand. Maybe just rename hardwareSupport to extraHardwareSupport to make it more obvious?

Great suggestion, done!


Update cats-effect to 3.3.4

interesting situation :)
https://github.com/BrainHorse/scache/pull/1

I moved cancelation to a separate fiber, checking additionally that it was actually canceled.
Please let me know if you have any other checks in mind.


Middle portal is outside of the navmesh

Can't teleport straight to it.

Moved it inside the navmesh boundaries.


Add V2_4 MTLLanguageVersion and macOS_ReadWriteTextureTier2 feature

Trivial commit, macOS_ReadWriteTextureTier2 feature is needed to fix wgpu's  read_write_texture_tier .
Added two comments above MTLFeatureSet and MTLGPUFamily because someone confused the relationship between the two.

Please see CI failures

Please see CI failures

Sorry, fixed now.


Redirect directly to specified path when pulling from Github

Right now, hitting a url like:
https://data8.berkeley.edu/hub/interact?repo=data8assets&path=labs/lab01

Results in the student being redirected to the root of the repo: data8assets.
Instead, it'd be more convenient if the student were redirected to the path given in the URL: data8assets/labs/lab01.
Since you can specify multiple values for path in the URL, eg.
https://data8.berkeley.edu/hub/interact?repo=data8assets&path=labs/lab01&path=labs/lab01/lab01.ipynb

The last path will be chosen to redirect to. In the above example, the student will be sent directly to the notebook.
See the discussion in #15 and data-8/DS8-Interact#3 .

Works beautifully for me.  Thanks Sam.


pre-trained PLBART model  checkpoint

Hi, thanks for the contribution, one more pre-trained LM with code corpora！
Is there any new progress on the release of PLBART checkpoint?  Can't wait to try!

We are committed to releasing the code/checkpoint/documentation before the NAACL conference (6th June). Due to some workload, we are delaying the release of the codebase with proper documentation.

We have released all checkpoints with documentation.


FFI Bindings for maliput::api::rules::RangeValueRule

[x] const Id& id() const   ----- From Rule #113
[x] const TypeId& type_id() const  ----- From Rule #113
[x] const LaneSRoute& zone() const ----- From Rule https://github.com/maliput/maliput-rs/pull/122
[x] const std::vector& states() const #113

closed as completed


Better Structure

The structure of the repository should be changed like , We should create different folders or java , python and c++.
Mostly students use this three languages so it will be easy to keep all three different language problems separately.
Please assign me this issue under hacktoberfest label @ayushi-ras

@ayushi-ras hey can you add hacktoberfest label to it


11523 layer without visualization protection

Fixes #11523
Context
We have changed some stuff regarding layer cleanup lately. We must have stirred something up and some layers without visualizations appear here and there.
This PR aims to make some routines in Carto::UserTable resistant to this unexpected nilness.
Acceptance
I can't think how to provoke these layers without maps, and there is an automated suite to check it works. Check instead that all layer operations work:

[x] Add a layer
[x] Remove a layer
[x] Create a map from a dataset and the remove the dataset (you should get warned about the map)
[x] Delete a map
[x] Delete a dataset

Moved to deploy after successful acceptance. I can't deploy right now, I'll do later if it's still there.


Changed domain of 99liga

Describe the bug
They changed the website to liga.esl-meisterschaft.de, so the plugin doesn't work automatically anymore.
To Reproduce
Steps to reproduce the behavior:

Go to the league website
Open a team page
Doesn't work

Expected behavior
It should show all the stats

I would contribute to this by changing the necessary lines, but I think the domain is hardcoded in a lot of places and I would rather let you change it in an organized manner.

If this is just about replacing some URLs, I can take a look at it later today.

I think it is, I have no experience with writing browser extensions, but the only think 99damage changed, is the domain, so for me it would be logical to update the URI's

@blssed Check out #82. reactivating the extension was, like you suggested, just changing a few URLs. However, I noticed that there are some more changes with the switch to ESL Meisterschaft. Since I am not active in the community right now, I don't see these things right away.  I opened #85 but unfortunately don't have time to work on this right now.
Version 2.2.0 is published and at least activates the extension again.

At least the extension now kinda works again. :-) If I have the time, I will have a look at this and check if I can help solving this.


Feature typehead rxjs

I updated and refactored the rxjs integration in the typeaheads  #99. kudos to @buchslava
If this is merged, the other one can be closed.

Was merged into another branch. The merge in the develop branch will follow soon.

@Dinistro modals in place

@valorkin I will take a look soon.


Google auth does not work on iOS

Describe the bug
All instructions have been followed and authentication does not happen.
flutter: serverpod_auth_google: GoogleSignIn
flutter: serverpod_auth_google: serverAuthCode is null. Trying auth.idToken.
flutter: serverpod_auth_google: Signing out from google
flutter: serverpod_auth_google: Failed to authenticate with Serverpod backend: 0. Aborting.
Expected behavior
session maganager callback on auentication
Serverpod versions

CLI Version: 1.2.7
Library version: 1.2.7

It sounds like you haven't setup the serverside secret. But this is too little information to go on, please provide the steps you have taken and the logs from the server.
A full tutorial can be found here: https://medium.com/serverpod/integrating-google-sign-in-with-serverpod-authentication-part-2-6fade3099baf

All steps on the tutorial have been followed and it does not authenicate.

@mike-novarca you have to give me more than that if you want me to help you debug. When I wrote the tutorial I also completed each step so I know for a fact that they worked when it was written.
Please explicitly list what you have tried, what steps you took, and where it failed including the logs from the server.


Fix for a rare bug when ProductID=0 on an OrderItem

Its a bit hairy when a Product_OrderItem doesn't have a Product. I can see how it could happen when a product is deleted for example.
This fix makes sense for when this happens. Id also like to have more confidence as to what happens as data is isolated like this and db starts to get invalid. Its the whole immutability thing, which I've had some thoughts on before - see #10

I agree. I'm not at all sure how it happened but it did happen on one of our staging sites and then you couldn't add or remove anything from the cart. It was really confusing because it was only happening for the one browser session. Thanks for reviewing this.


UPDATE BADGE REQUEST [USERNAME#0001]

What is your Discord Tag?
Laurino108#9563
What is your UID (User ID)?
433698489462161408
What is the image for the badge that you want? Please make sure that the image is hosted on a trusted domain, such as i.imgur or cdn.discordapp.
https://i.imgur.com/YQyZwow.png
Additional Confirmation:

[x] My badge does not contain any NSFW material.
[x] My badge is not a badge that signifies that I am an official developer / staff for Discord or client mod communities.

updated!


Capabilities using AttachCapabilitiesEvent

Seems like it could easily be done with hasCapablity()/getCapability() for both items and tile entities. Isn't really a problem for TileEntities, but new ItemStack instances are created constantly, especially when there is AE/RS system.
Some places where its used:
https://github.com/SleepyTrousers/EnderIO/blob/6720c7319f1c53863d74e3ca99aaadd9bc97c83b/enderio-base/src/main/java/crazypants/enderio/base/item/darksteel/upgrade/energy/EnergyUpgradePowerAdapter.java#L19-L29
https://github.com/SleepyTrousers/EnderIO/blob/f026ef9c35a56159b4fef7b6c1990055014ac61a/enderio-base/src/main/java/crazypants/enderio/base/power/forge/ForgeAdapter.java#L66-L76

[x] DS Items
[ ] Other Items
[ ] Old plugable cap infrastructure
[ ] TEs

If we do that we move the boilerplate into the implementation, requiring any subtype of IDarkSteelItem etc to copypaste code that can be done generically in this event instead.

AttachCapabilitiesEvent replaced with MixIn acouple weeks ago.