User Review of test tokenDashboard

Below you can find my User Review of test tokenDashboard (which I believe will be almost identical with mainnet?)
Keep in mind, that 1) I'm not a professional designer, so this is all from regular user POV.
2) I tried to glance quickly through issues that are already present in this branch but may have missed or forgot that I've seen some of them and this would be the reason why I added it in my review. Tried to submit it today in the morning (you can see time in one of the screenshots, I'm in UTC+3), but somehow wasn't successful. Hope that it will still be helpful
Wallet connection banner
There's no issue with the current one, just thought about improving it a bit. Below you can find my suggested version.
If you like it, please let me know and I could prepare Vector version and for every wallet too(Ledger, Trezor, etc.)

Language tumbler
I know, that is a big thing and need lots of prework and translation check, but it would be much easier for other folks to use token dashboard in their native language. Luckily we have enough people willing to submit translations.
Signing in
Can confirm that I have the same issues as other users (for example @nahuus123): metamask disconnects after refreshing. My environments - MacOS + Chrome browser and Windows 10 + Chrome browser.
Add keep button in "Delegate Tokens From" page
Hovering over Add keep button and seeing "why can't I add any more keep" tip would be useful (as a "?", or something like that)
Links at the bottom of the page
-Discord button at the bottom of the page is absent, while it is certainly one of the main current communication channels for community
-Fork button - needed or not? Or at least quick GitHub link would be definitely useful
-Team + Advisors link at the bottom of the page. Is it necessary to have advisors there? If so, why there also no "Our stakers link" which is at the same page with Team and Advisors
Loading time
-Slow time of upload mainly for Random Beacon Rewards page - was waiting for a few minutes
-Token Overview page
-"Delegate Tokens From" page
-as for tBTC application page - first (upper) half loads quite quickly, but for bottom half to load you have to wait some time.
Random beacon rewards page issues
Random Beacon rewards - overlaying (hovering over text)

"Accumulating sticker" might be colored in a different tone or color (yellow or smth like that as it's in the process)
-Left side of token dashboard goes over bottom black part at the Random Beacon Rewards page.

Other suggestions
-Possibility to add another color from the Keep palette (might be like with purple one, which is already there)
-"Success!Transaction hash: 0x79cf337d7926225874cd1a71bc457fdf2f1cf86391df437b45e1255f6e0e5a27" - remains there all the time after it happened. Should it be like that?
-Email us / support button below. -- Functional support button which can make a screenshot of the error/bug immediately after you press it and then it's easier for support to sort out the problem
-for Top-ups "?" tip would be helpful at "Delegate Tokens From:" page. I actually don't know what this is intended for, so I'm curious too
-Contrast/intensity on unavailable buttons - they're borderline not visible. For people with low contrast monitors or weak eye vision this will be just like plain white background. This will improve accessibility if you could add a bit more of contrast for these buttons. Please see examples below

Example how it may be done so we could still see that it's unavailable but still there

-"A Thesis* Build © 2020 Keep, SEZC. All Rights Reserved." - also borderline not visible
-Privacy Policy, Terms of Use and Playing for Keeps terms - is this necessary or not? Since I've seen this on main Keep Network site and was wondering whether it should be at Token dashboard too
For the moment that's everything I found. Also today in the morning I asked my designer friend (who is not in Crypto) to check out this dashboard and overall he was very positive about it. For him it looks like everything is at the right place and dashboard is user-friendly and informative. So, really good job, Keep team!

Thanks for the feedback @saltypalo ! 🎊  A few initial comments:

Wallet connection banner: this is an interesting idea. I like the additional visual cue of the icon of the wallet connection type. I've got vector icons for all of those so no need to prepare vectors, but ty

Language tumblr/ internationalization: good point, this is on the roadmap but not sure of timeline for this yet.

Links at bottom of page: 100% agree that Discord should be linked here. This is being addressed here with the updates to the footer: https://github.com/keep-network/keep-core/issues/2001
Fork button is an interesting idea... 🤔
Agreed that team / advisors / etc don't make much sense in context here, have removed those in favor of a general link to the Keep website

Random beacon rewards: yup, got this issue logged here: https://github.com/keep-network/keep-core/pull/2050
That's a good point about the accumulating sticker color, since it's similar to a pending status (which is indicated by a yellow)

Left side of token dashboard goes over bottom black part at the Random Beacon Rewards page. <- I'll log this as a bug

for Top-ups "?" tip would be helpful at "Delegate Tokens From:" page. I actually don't know what this is intended for, so I'm curious too
Noted. This section is meant to show a log of KEEP that's been added to an existing KEEP delegation (a "top up")

Contrast/intensity on unavailable buttons
Yup, one thing that's come out of the creation of the Community Design System is addressing accessibility of the colors and contrast issues. The disabled state color scheme could use revisiting to make sure it's actually visible.

@liz-shinn glad that you found some useful points in the review!

@liz-shinn there's much going on in the design section of discord, so just thought of duplicating it here so you would definitely see it.

Tried to play a bit with "disabled" button style. Looks like it has different visability in the design kit and when actually on the site, i don't know why it's like that. But I still tried to add some tweaks and they didn't hurt, it definitely becomes more visible, however it's possible to see that it's "disabled" and a bit transparent
Also found additional bug connected with the fact that transaction confirmation remains on the screen, it actually starts hovering over everything else. Please see screenshot


2 worker pools failing to create cluster in AWS

Use the following config for worker pool
worker_pool "pool-1" {
    count         = var.workers_count
    instance_type = var.workers_type
    ssh_pubkeys   = var.ssh_public_keys
    labels        = "foo=bar"
    taints	  = "nodeType=storage:NoSchedule"
  }

  worker_pool "pool-2" {
    count         = var.workers_count
    instance_type = var.workers_type
    ssh_pubkeys   = var.ssh_public_keys
    labels        = "lolum=ipsum"
    taints	  = "nodeType=storage:NoSchedule"
  }

Bootkube starts but then it fails with following error.

CC @johananl

For more context pr-aws

If we want to route HTTP traffic to multiple worker pools, I think we have the following options:

Use one NLB per pool.
Use a single NLB with multiple listeners (which means some pools won't be able to use port 80 and 443.
Use an ALB and do HTTP-based routing.

I think this is more of a design question than a bug. We should think about the functionality we want to have and then build things accordingly.

BTW, the failure isn't related to Bootkube. bootkube-start actually completed successfully in the output above.

BTW, the failure isn't related to Bootkube. bootkube-start actually completed successfully in the output above

yes, so if we want users to work with the present config. We should atleast document it. But what if user creates 3 pools. Then they have to set lb_http_port and lb_https_port differently for each pool

If we want to route HTTP traffic to multiple worker pools, I think we have the following options:

We can also use the CCM to set up the load balancing for us.

I think this is more of a design question than a bug.

The bug is, that we do not validate if the 2 pools have colliding ports and we do not document this (implied) requirement.

From a quick glance at the Terraform code, I have a feeling, that with current implementation, it would make sense to move the aws_lb_listener resources into the controller module and collect there the aws_lb_target_group.workers_http.arn from all worker pools by default into forward action block. This way, by default you get a LB on ports 80 and 443 and all worker pools participate in it.
Then, if lb_http_port or lb_https_port is set for the worker pool, create separate listeners for this worker pool and don't export the worker pool into the 80/443 listeners.
This way, we fix the colliding 2 worker pools and don't modify existing behavior.

Alternatively, we could just reject such configuration for now and document the limitation. We should also mention, that if only one worker pool handles the ingress traffic, node selector and labels should be used on this pool and contour component, so contour (or envoy?) pods only run on this worker pool.

Finally, I think ideally we should be just using the CCM to set up the Load Balancers for us and remove this all code from Terraform, as IMO it doesn't really "fit" into Kubernetes setup.

From a quick glance at the Terraform code, I have a feeling, that with current implementation, it would make sense to move the aws_lb_listener resources into the controller module and collect there the aws_lb_target_group.workers_http.arn from all worker pools by default into forward action block.

I think it makes more sense to expose the load balancer's ID as an output in the controllers module and have each worker pool create its own target group and attach itself to the LB. My rationale:

Code that's related to a specific worker pool should reside in the workers module. This way we don't have to re-apply the controllers module when modifying/removing a worker pool.
Making the controllers module depend on the workers module can be a source for trouble given that the workers module depends on the controllers module.

Finally, I think ideally we should be just using the CCM to set up the Load Balancers for us and remove this all code from Terraform, as IMO it doesn't really "fit" into Kubernetes setup.

One advantage of the current setup is that it allows the user to utilize a single NLB for both the API server and user applications. I like relying on CCM for LBs in general, however we would still need an LB for the API server.

Thanks for tipping in @johananl. I think it make sense what you're saying. @knrt10 would you like to look into it so maybe we could ship it with v0.4.0?

Sure, I can take a look into this

Following an offline discussion with @knrt10, here is what we're proposing:
We deploy an NLB for the API server (let's call it the "API NLB" here). By default, we don't provision LB resources for worker pools.
If they so choose, the user can enable LB provisioning at the worker pool level:
cluster "foo" {
  ...
  worker_pool "one" {
    load_balancing = [
      mapping {
        protocol = "TCP"
        listener_port = 80
        target_port = 30080
      }

      mapping {
        protocol = "TCP"
        listener_port = 443
        target_port = 30443
      }
    ]
  }

  worker_pool "two" {
    load_balancing = [
      mapping {
        protocol = "TCP"
        listener_port = 7777
        target_port = 8888
      }

      mapping {
        protocol = "UDP"
        listener_port = 12001
        target_port = 12001
      }
    ]
  }

  worker_pool "three" {
    # Don't provision LB resources for this pool.
    ...
  }
}

When the load_balancing block is specified, we do the following:

Create a listener (of type TCP!) on the API NLB for every mapping block using the specified listener_port.
Create a target group for every mapping block using the specified target_port.
Create routing rules on the API NLB to "wire" the listeners to the correct target groups.

In the docs we instruct the user to create a NodePort service with the same node ports as specified in the target port knobs.
When the load_balancing block isn't specified, we don't create any LB resources on behalf of the user.
In addition to the above, the user is free to deploy services of type LoadBalancer (optionally with annotations to control the type and config of the created LB) and we ensure a CCM is present to provision load balancers on behalf of the user.
Caveats which should be documented:

The Lokomotive-provisioned LB only supports TCP and UDP routing. If the user wants to terminate TLS on the AWS LB they have to manage the LB themselves.
All listener_port values must be unique.

Any feedback is welcome.

@rata @surajssd - I'd love to know what you guys think about the proposal in my previous comment.

@johananl thanks for the proposal. I think it make sense, though it is very similar to what we have right now. But it seems to be that implementation might be too complex to include that in v0.4.0.
Maybe we just implement a validation rule to reject conflicting ports right now (including the defaults) and we schedule that for later?

I have no opinion regarding which release to put this in. I'm fine with either rejecting the "bad" config for now or even just documenting the constraints.

I think if we want to do this, we should do this correctly and for 0.4.0, we should just document the constraints for using different lb_https_port. If everyone agrees, I can create a PR for the same.

I'd implement a validation rule for it. It's not difficult to do so and will prevent confusing behavior (users tend not to read the documentation :smile:)

Finally, I think ideally we should be just using the CCM to set up the Load Balancers for us and remove this all code from Terraform, as IMO it doesn't really "fit" into Kubernetes setup.

I like this idea. I don't think there is harm in having two LBs for HA reasons. If we really want to use one LB for both app traffic and control plane traffic, do we have knobs in CCM where it can do the magic for us?

Finally, I think ideally we should be just using the CCM to set up the Load Balancers for us and remove this all code from Terraform, as IMO it doesn't really "fit" into Kubernetes setup.

I like this idea. I don't think there is harm in having two LBs for HA reasons. If we really want to use one LB for both app traffic and control plane traffic, do we have knobs in CCM where it can do the magic for us?

I don't think you can modify an existing LB using the CCM. AFAIK the AWS CCM either owns an LB or doesn't. AFAICT if we want to allow using a single NLB for both the API server and application traffic, the CCM can't help there.

I'm just coming back from holidays, but I think:

Creating load balancers for apps, IMHO, is out of scope for lokomotive. The only valid reason, IMHO, is to create them when configuring the ingress lokomotive component. For the ingress component, though, It can be via the CCM too (is that already merged and working?). I think that is a valid solution (not the only one).

However, I might be missing some context. In particular, why options like this were discarded. I can see some problems and some work-arounds to such approach:

Move the resource "aws_lb_listener" that are here to the controller module.
The workers just add/remove target groups attachments to the NLB when a worker pool is created/deleted using an output from the controller module
I guess one complication would be that the listener default_action is required (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb_listener) in the controller module, before any target group is created. We can do something like use the type "fixed-response" and return something like "no target group configured/healthy". IIUC, that path only will be taken if no target groups are found and healthy

Wouldn't something like this work and be simpler than the following proposals? Is there a downside this have that I'm not aware of?
After such option was discarded, the next proposa seems to have several downside IMHO:

Creates the mapping block, which is just confusing and probably something only relevant for AWS that we can avoid. Furthermore, the user needs to go too much into the details, when it just wants a load balancer that forwards traffic. There is even no need for the user to specify the mappings with "random" ports and sync with all the mappings. That is a complexity that can be avoided IIUC
We need to have a step, as the comment says: In the docs we instruct the user to create a NodePort service with the same node ports as specified in the target port knobs.. This seems very fragile UI and very bad UX, IMHO. Specially if we can avoid it.
Is there a reasonable way to achieve what is described in the comments without breaking existing users? It is not crystal clear to me.

But, IIUC, there is a simpler way to do this if the CCM provision load balancer for us: just use service type load balancer with the annotations documented in contour docs. IOW, do what is explained here: https://projectcontour.io/guides/deploy-aws-nlb/.
IMHO, I don't know why the first option was discarded, but seems simpler and have a better UX, IMHO. The second option (rely on CCM) if that is working, seems to be the best way (and if not, might be the best way when that is working).
In any case, oif either of the two options I propose was discarded for good reasons (I really lack the information to know :-D) or there is no consensus in the short term, I'm totally fine having a validation rule for now that will the original bug report not fail at the terraform layer, but give a clear error message in lokoctl.
Other questions due to lack of context:

The user should be able to access the API servers. Not sure why the at some comments of the issue there are discussions about a NLB for the API server. AFAIK (maybe it changed in the last days I was away? :)) we are not using a NLB, just DNS records (with 3 IPs if there are 3 controllers, etc.). Why do we need/want a load balancer for the API server? I'm lacking some context regarding why was this even mentioned. I think we are fine without a NLB for the API server. Am I missing something?

Thanks!

The user should be able to access the API servers. Not sure why the at some comments of the issue there are discussions about a NLB for the API server. AFAIK (maybe it changed in the last days I was away? :)) we are not using a NLB, just DNS records (with 3 IPs if there are 3 controllers, etc.). Why do we need/want a load balancer for the API server? I'm lacking some context regarding why was this even mentioned. I think we are fine without a NLB for the API server. Am I missing something?

@rata we are using an NLB for the API server on AWS: https://github.com/kinvolk/lokomotive/blob/27ec5679af223bb48bf73d37fffc724def6c0f47/assets/terraform-modules/aws/flatcar-linux/kubernetes/nlb.tf#L17
This is Typhoon heritage.

Given that #889 is merged and we no longer fail to create 2 worker pools, I would like to close this issue.
However, I think information about LBs on AWS here are valuable. @johananl @surajssd @knrt10 could one of you capture the essence of the discussion here and create a new enhancement issue to track this?

I'll close this then and we continue the discussion in #1248.


release 02-29-24

Make styling of site conditions page larger and changed the color from gray to black
Make crops more obviously clickable in the calendar and list views
Display multiple values properly on the information sheet
Fix descriptions in info sheet
Fix crop window on firefox

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.


Fix Reporting K8s configurations.

Specify dev public Kingdom API target in dev config.
Fix typo in _reportingConfigs field.
Drop DB secret from dev config.
Extract common fields to definitions.
Run formatters.

This change is

Depends on world-federation-of-advertisers/common-jvm#144.


Mark KafkaSource as ready when all initial offsets have been committed

Fixes #411

Proposed Changes

Move InitOffsets out of the ST adapter to the source controllers
Add two new conditions in KafkaSourceStatus: ConnectionEstablished, InitialOffsetsCommitted.

Release Note

🎁 KafkaSource is marked as ready when the connection to Kafka has been established and when all consumer group offsets have been initialized.

Docs

/lgtm

/cherry-pick release-0.23


Missing 4.0.0-beta1 tag

Hello
I am running into a build issue described in detail here(https://github.com/stepfunc/dnp3/issues/131) root cause of which seems to be that this repo is missing a tag called 4.0.0-beta1.
Seeing that there's now a tag called 4.0.0-beta2 tag I'm assuming beta1 used to exist but doesn't anymore?
I was wondering if you could restore the tag, since this was a breaking change
Thank you

Tag should be restored, not sure how it got removed.  Certainly wasn't intentional.

very quick turnaround, thank you!

I'm actively hacking on the repos at the moment :)  Trying to be careful because I know many people have been pointing a the repos directly due to my lack of published releases, but this probably won't be the last time something like this happens

Huh I'm thinking maybe something else was the root cause of the build issue.
(the tag might have just been a red herring, I am not seeing the same issue anymore :( )
Getting the following build error now:
...

Caused by:
  failed to load source for dependency `mio-serial`

Caused by:
  Unable to update https://github.com/berkowski/mio-serial?branch=v4.0

Caused by:
  failed to find branch `v4.0`

Caused by:
  cannot locate remote-tracking branch 'origin/v4.0'; class=Reference (4); code=NotFound (-3)

looks like the branch is now missing?
here's the package pointing to the branch
https://github.com/stepfunc/tokio-serial/blob/f527f73e412c643fe3e691b27b4280e7b831d6d9/Cargo.toml#L27
possibly it makes more sense for it to point to a tag instead.
What's confusing to me about this error message, too is that the commit it's referring to

No, it's certainly related to my work on mio-serial and tokio-serial this last week, and my long absence of any work before that.  All long-outstanding feature branches worth continuing have been merged to master at this point, and feature branches themselves deleted.
@stepfunc is using a forked version of tokio-serial before those changes were merged and beta versions pushed to crates.io.  I would encourage whatever project is using that forked version to try the posted betas on crates.io

Sigh ok.
Do you know if it would be possible to restore state to make the project build (I know the project definitely built this past Thursday on the 15th)? (i.e. have the [presumably] previously existing branch v4.0 exist and point to the same commit...
I don't think I have the commit hash, my cargo git cache from a previously working version is wiped :( )
I understand that it's probably against best practices to not to either:

use a pinned version (something like a tag)
or use master to make sure that library is using most recent version

but I have a deadline this upcoming Tuesday and not being able to build the project adds quite a twist. While I might be able to get away without re-building, it is extremely inconvenient and if any bugs are spotted, would be very unfortunate.
If it's not possible [to restore to the version at which the repo was on July 15th], I would understand and chat with the folks at stepfunc to use the newest version of the library (I will do that anyhow, since it seems like a good thing to do).
It's just, given the timeline I would really want to prioritize just getting to a state where I can build a binary...
Appreciate your help with this one!

Luckily I still have the v4.0 branch locally.  I just pushed it back to github and can build dnp3 on my laptop.

you are amazing, thanks for all your help.
I feel like I know so much more about the cargo build system after this whole story!

In the meantime it seems like the changes to get dnp3 compiling against tokio-serial 5.4.0-beta1 are minimal.  I've submitted stepfunc/dnp3#133


Add style

Requirements

When the game is fully functional, elements meant to be event targets must look like buttons
When an event target is hovered over or clicked, it should change colours
Header elements should be aligned to either side of the top of the screen
The quiz questions and answers should be centered on the page, but aligned to the left of the element

Added simple styling


[On-hold] Add accept terms and conditions pop-up to Vortex

✅ Add disableNativeEvents, hideCloseButton parameters to  component
✅ Make onClose optional in  component
✅ Add T&C dialog
The url to the T&C has to be changed. (Not url has been provided)

@prayagd could you add the page to the VortexFinance website and add the link for tech to link to?


Question about the parameter delta

Thanks for your implementation of mamba-minimal. What a great job!
I'm really confused about the dimension of the parameter delta. I understand that delta is used for the discretization of A and B in SSM. However, I don't understand that why delta are first shaped in (b,l,dt_rank) and then project into (b,l,d_inner) as in the algorithm 2 of mamba in the paper. Why do we need to shape delta into (b,l,dt_rank)  and then 𝜏Δ (Parameter+𝑠Δ (𝑥)).
(delta, B, C) = x_dbl.split(split_size=[self.args.dt_rank, n, n], dim=-1)  # delta: (b, l, dt_rank). B, C: (b, l, n)
delta = F.softplus(self.dt_proj(delta))  # (b, l, d_in)
Can you explain the reason for this operation in the code? I'm looking forward to your reply.

I have same question。please explain to me if you have answer or advice.Thank you very much


meson: 0.63.1 -> 0.64.0

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Why is this marked as a draft?
This should target staging
Any idea why does the ofborg-eval-lib-tests CI check fails?

Why is this marked as a draft?

Sorry, should've made a note: I didn't manage to properly test this, so I figured I'd at least open the draft PR as a conversation starter :)

This should target staging

Yes, sorry, I suspected as much but lost track of this PR before ofborg reported on the number of rebuilds. Is there a way to count rebuilds without waiting for ofborg?

Any idea why does the  ofborg-eval-lib-tests  CI check fails?

No - hmm, seems OK now that you retargeted to  staging ?

This should target staging

Yes, sorry, I suspected as much but lost track of this PR before ofborg reported on the number of rebuilds. Is there a way to count rebuilds without waiting for ofborg?

I think it's the command listed here but you should expect it uses a lot of RAM and time so IMO it's not worth it.

Any idea why does the  ofborg-eval-lib-tests  CI check fails?

No - hmm, seems OK now that you retargeted to  staging ?

Yes it does :), only the x86_64-darwin build is failing, not due to the meson update I think.

Systemd will require a patch (or update to 252): https://github.com/systemd/systemd/issues/24323

So we'll wait for https://github.com/NixOS/nixpkgs/pull/201558 .

Rebased and force pushed with https://github.com/NixOS/nixpkgs/pull/201558 merged now.

BTW, there is 0.64.1 now.

BTW, there is 0.64.1 now.

Thanks! Pushed.

Is it possible to test this update without building the world? systemd-minimal builds fine with this update.

We may drop a few line from the cross-files too: https://github.com/mesonbuild/meson/commit/8a8ab9a8e0c2cefb6faa0734e52803c74790576c

We may drop a few line from the cross-files too: mesonbuild/meson@8a8ab9a

Our cross-file doesn't seem to include references to these binaries:
https://github.com/NixOS/nixpkgs/blob/4b6303bf3d6f3ee2d2a20a8ba69678e3fc5e0f6f/pkgs/stdenv/generic/make-derivation.nix#L385-L399


[release-v1.7] Retry failed reconciliations on the data plane (#3009)

Data plane reconciliation might fail for many reasons, especially when using Istio with EKB and namespaced broker that creates data plane automatically when a broker is created the first reconciliation on startup often fails since istio proxy might not have started yet.

/lgtm
/approve


Create 2023_001.md

@Abinash-Sharma
Please visit https://cla.developers.google.com/ and sign the CLA to contribute :)


App crashes during attempt to print when another device is connected to the Bluetooth printer

I was trying to run my APK from android tablet, it worked fine initially but suddenly it started crashing while trying to print using QL820NWB on bluetooth, I discovered that my iPhone was paired and connected, when I disconnected my iPhone, problem was OK.  Question is if it is possible to have multiple devices paired and printing using this library ?

Hi @devkumarkatta ,
Thanks for reaching out about this and apologies for the late reply. Could I trouble you to share the logs you see when the crash happens?
Thanks in advance,


Recursive calls crashing application

Hi @victorgarciaesgi , I followed a couple of your examples and wanted to do something like this.
https://codesandbox.io/s/intelligent-meninsky-eeqnd?file=/src/components/HelloWorld.vue
It gives me this error
Maximum recursive updates exceeded. This means you have a reactive effect that is mutating its own dependencies and thus recursively triggering itself. Possible sources include component template, render function, updated hook or watcher source function.

I suspect It has something to do with the options being reactive when passed to the component. If the options are removed, everything works fine
In the codesandbox link, even though the console logs a warning and it works fine. I get an error of the same type and it breaks

Hi again @TheCelebrimbor, I'm not having the problem with Vue 2 so it seems again to be a Vue 3 problem :(, I will look at it. I can disable reactive options in the meantime

I updated to vue 3.1.2. Now it does not throw error but warns about it in the console as in the sandbox.

If think it's because in your code you have a circular dependency here
let options: any = ref(barOpt);

 let selectedValue = ref("bar");

    const component = computed(() => {
      if (selectedValue.value === "bar") {
        options.value = barOpt;
        return Bar;
      } else {
        options.value = donutOpt;
        return Doughnut;
      }
    });

component is depending on options, and component is changing options back. So it's what makes the call stack.
Also it is not advised to modify refs inside computed, use watch instead!

@victorgarciaesgi  Never mind! :) :). Seems to be a ref issue.
I asked about this on discord.
It seems we need to us computed if we want to mutate any refs and not watch
here is a link to the fixed sandbox. Notice how the value of options is not a ref but computed
https://codesandbox.io/s/keen-rhodes-mi84j?file=/src/components/HelloWorld.vue

@victorgarciaesgi Exact words
"There are times where mutating reactive state in watchers is appropriate, like here.
Rule of thumb is that it shouldn't be used to derive state from other state, that's what we've got computeds for."


minor maintenance

I like the ide behind this library but I couldn't use it becuase an issue on dependencies.
This pull request pretend give a simple solution to an issue between py-gfm and mardwon libraries, it looks like they are not compatible in their last version.
At the same time decide to migrate the code to python3.

I was able to release. https://pypi.org/project/markdown-server/0.1.4/
📝 Note for me:

see https://packaging.python.org/tutorials/packaging-projects/
Use python3 -m twine upload --repository-url https://upload.pypi.org/legacy/ dist/*

I understand because I also have problems to give time to my personal projects but I am happy that this little effort could help to someone else.
Thanks for take your time to do this release.


Using objc-encode crate?

This seems to be a improved version of objc type encoding: https://github.com/SSheldon/rust-objc-encode.
Is there a plan to switch to that?

Hey @ubolonton! I had prototyped a switch in c2ec92a, but the ergonomics aren't great until #52 is done, and it's a breaking change. So it's mostly just sitting around on hold indeterminately 😛

Ah sorry for dropping off! But yeah, I meant I wanted to make sure I had the best possible API before subjecting users to a breaking change. And with some new feature in rust, a much better way to handle this did arise :)
At this point I'm confident with the objc-encode API and there are some other breaking changes I want for objc (updating to rust 2018), so on master I've updated to use objc-encode in 6092caa.

Awesome! I hope it will be released soon :)


Feature request: File-selection capabilities

Right now the only way to select a file to use in LOAD81 is at the command line.  On the Open Pandora, we have the PickleLauncher tool:
http://pandorawiki.org/PickleLauncher
This is a generalized launcher for cmd-line programs which only accept filenames on the arguments, and for now it works very well as an 'outer shell' for LOAD81 - picklelauncher -> [user selects file] -> LOAD81 -> [user ESCAPES LOAD81] -> picklelauncher -> etc.  The 'piped-tools' approach could be used for this feature, or LOAD81 could have its own file-selector capability built in as the Editor functionality expands.

Just wanted to add that you can see a (brief) demo of PickleLauncher in action in this demo video:
http://www.youtube.com/watch?v=Q5mxSaFoSgk
Its right at the beginning - in this video, picklelauncher has been customized (its fully skin'able) with DOOM artwork - obviously it doesn't have to look like this for LOAD81.  If PickleLauncher is considered as the 'outer shell' for LOAD81, we could create a custom LOAD81 skin that features artwork more along the style of LOAD81 (C64'ish, etc).


TOOL: The user is not displayed with any error messages and can upload a form with the same title, name or path of an existing form.

Background: The user is not displayed with any error messages and can upload a form with the same title or path of an existing form.
Steps to Reproduce:

Log in to the PSA-Digital-Journey portal on dev as an admin with valid credentials.
Download a copy of an existing form.
Edit the name and path, but do not edit the title; save the json file.
Click on "Upload Form".
Select the file.
Actual Behavior: The user is not displayed with any error messages and can upload multiple copies of a form with the same title.

Expected Behavior: Each form's title should be unique, and the user should be displayed with an error message "The form title/name must be unique".

Edit only the path, but do not edit the title and name; save the json file.
Click on "Upload Form".
Select the file.
Actual Behavior: The user is displayed with the "Forms Upload Confirmation" pop-up with continuous loading indicator. The same behavior happens if only name is edited.

Expected Behavior: Each form's name should be unique, and the user should be displayed with an error message "The form name must be unique".

Edit the title and name, but not the path; save the json file.
Click on "Upload Form".
Select the file.
Actual Behavior: The user is able to upload the form with the same path as an existing form.

Expected Behavior: Each form's path should be unique, and the user should be displayed with an error message "The form path must be unique".

@iman-jamali-fw can you please add an estimate for this ticket please? Thanks!

closing as this is only an issue for form designers/devs


grpcio does not have ARM64 pre-built wheels

There's no ARM64 wheels being built at the moment. While it can be installed through compiling, it's tedious. This affects Apple M1/M2, especially Docker builds on the platform.
Would be fantastic to have grpcio ARM64 wheels, for both musllinux and glibc.

We do offer prebuilt arm64 manylinux wheels (for example
grpcio-1.51.1-cp310-cp310-manylinux_2_17_aarch64.whl). With the release of 1.52.0, we'll also be offering universal2 wheels, which support both arm64 and x86-64 on Mac OS (pre-release artifact). However, arm64 with musl libc is not currently on our road map.

Thank you for getting back to me! I guess I was testing on Python 3.11 with Docker on ARM64, which was having to compile the wheel. It looks like it works on 3.10.
For the pre-release, it looks like there's also no ARM64 wheels for 3.11. Do you know when we might see ARM64 glibc wheels for 3.11?

 We cannot support aarch64 + 3.11 + Linux without significant effort due to this issue, which it looks like you're already aware of.

Ah, that's right! I was looking through grpcio issues, thinking something might ring a bell.
I appreciate your help and work on this project.

Looks like that issue was taken care of!


CUTLASS upgrade

Are you planning to upgrade the version of CUTLASS you are using in the near future? If not, are you willing to accept a pull request from us with such an upgrade? We would like to use the latest version of FasterTransformer, but in our project we use CUTLASS version 2.11, which makes it impossible to update FasterTransformer.

Hi, @jellysnack . We don't have plan to upgrade the version of CUTLASS recently. If you want to help upgrading, it is very welcome. But it is better to wait until next version release.


RESEARCH: Monitor syslog for Errors

Use grep error -i -A5 /var/log/syslog to check for any other errors happening in background and see how we can support the user in fixing these.

This made me think we could automate error log collection and reporting as well.  I saw LinuxMint guys were using this site termbin.com which makes it easy to upload log files and any text on the command line user netcat (nc) like the following.  It auto generates a URL that can then be put in the git issue:
admin@RaspiBlitz:/var/log $ sudo grep -ai failed syslog | nc termbin.com 9999
https://termbin.com/h08r
So a script such as /home/admin/XXuploadLogs.sh can be run to do this.
Prob good not to abuse the service though with constant uploading of huge files. But this might help debugging.

Thats a nice tool - have to see were integration makes sense.


[Bug]: Background cannot be overwritten for fireworks preset

Contact Details
<EMAIL_ADDRESS>What happened?
We are trying to use the fireworks preset, but would like to override the background.  It is now black and we would like it transparent.
We tried the following code (while including this bundle: https://cdn.jsdelivr.net/npm/tsparticles-preset-fireworks@2.10.0/tsparticles.preset.fireworks.bundle.js):
async function loadParticles(options) {
  await loadFireworksPreset(tsParticles);

  await tsParticles.load(options);
}

const configs = { preset: "fireworks", background: { color: "transparent"} };

loadParticles(configs);

We get the fireworks, but the background remains black.
tsParticles Version
2.10.0
tsParticles Configuration
{ preset: "fireworks", background: { color: "transparent"} };

What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Duplicate of #4882, #4576, #3495, #3078, #4870, #2446


Outputs full source file path

Describe the bug
I am using this plugin to load SVG files into my lib.
When I look at the generated files I can see comments like :
// raw-loader:B:\Projects\misc\esbuild-raw\icon.svg?raw

=> the plugin is outputing the full file path into the generated files. Beside being not very clean, I think it could lead to information leak (something something about system structure on a corporate computer).
I tried to replace this line
https://github.com/hannoeru/esbuild-plugin-raw/blob/1698f08e3761d7d3e9378cf837d4f6fe354d690d/src/index.ts#L11
by path: args.path and it seems to continue working without any issue and now the comment is simply
// raw-loader:./icon.svg?raw

I guess the path resolution is here to handle more complex cases, perhaps it could be done only in onLoad
Reproduction
https://github.com/mistic100/temp-esbuild-raw
System Info
Windows 10

Used Package Manager
yarn
Validations

[X] Follow the Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A please open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

Will I noticed (after reading esbuild doc) that this plugin might not be useful in many basic cases. The same result can be obtained with the loader option.
esbuild --plugin:.svg=text

// tsup.config.js
export default defineConfig((options) => {
  return {
    entryPoints: ['src/index.ts'],
    esbuildPlugins: [
      // rawPlugin(),
    ],
    esbuildOptions(options, context) {
      options.loader = {
        '.svg': 'text',
      };
    },
    clean: true,
  }
});


Add support for message transformation during replication

Make validation true always while replicating (get rid of the config)
Add support for message transformation in MessageSievingInputStream. If the
StoreKeyConverter is non-null, then a message will be transformed into another
with the original storeKey replaced with the converted storeKey. If there is
no mapping for a key as per the StoreKeyConverter, then the corresponding
message will be discarded when creating the transformed stream.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@63d963d). Click here to learn what that means.
The diff coverage is 84%.

@@            Coverage Diff            @@
##             master     #970   +/-   ##
=========================================
  Coverage          ?   67.75%
  Complexity        ?     4486
=========================================
  Files             ?      368
  Lines             ?    29119
  Branches          ?     3698
=========================================
  Hits              ?    19731
  Misses            ?     8362
  Partials          ?     1026

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/com.github.ambry/config/ServerConfig.java
0% <0%> (ø)
0 <0> (?)

...ava/com.github.ambry/config/ReplicationConfig.java
100% <100%> (ø)
1 <0> (?)

...ls/src/main/java/com.github.ambry.utils/Utils.java
70.7% <100%> (ø)
82 <1> (?)

...m.github.ambry.replication/ReplicationManager.java
37.6% <66.66%> (ø)
11 <0> (?)

...va/com.github.ambry.replication/ReplicaThread.java
71.83% <81.25%> (ø)
46 <0> (?)

...ambry.messageformat/MessageSievingInputStream.java
83.07% <85.52%> (ø)
18 <14> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d963d...e32a78e. Read the comment docs.

@dharju @vgkholla merged with David's changes and made other changes to use configs to instantiate Transformers. Built and tested. The only thing remaining is to unify the key converter with the transformer as part of a single factory, which can be done later.
Built and tested.

Looks like the BlobIdTransformer changes need to be pulled in / rebased on top of?

@vgkholla @dharju rebased, built and tested.

@pnarayanan Bumped up the comments that needed addressing (just 2)

@vgkholla addressed comments.

Yes, this was built. It was tested before the latest set of changes (which were minor and should not affect the tests).


Need to put the "to URL" address at the top of the envelope

In a working example of using the envelope with the Sandbox we found an assistant that reported (with its reply envelope) the wrong origin URL (not the one we messaged it with). It created problems with the Sandbox logging because we could not match the envelope to an existing assistant on the call stack (e. g. to match it to its render color). If the envelope had (instead of a "sender") rather a "participant" with sub elements "to" and "from". The envelope is sent as a complete unit to the destination so putting that at the top seems more logical. If the reply has a "from" then the linkage between the sent/response can be verified.

This should be discussed in our meetings.


Dependency "ZXingObjC" has no shared framework schemes for any of the platforms: iOS

In iOS terminal can't build successfully

I receive the same error.

rm -rf ~/Library/Caches/org.carthage.CarthageKit; rm -rf Carthage; carthage update --platform ios did the job!


feat: support JWKS with updated types

Fixes #26 and implements #29
I adapted the code to match the way that other, more recently modified plugins have been implemented such as @elysiajs/elysia-cron.
See example implementation: https://gist.github.com/acrois/8f9c6a0e2d3b6ee6744a0b7a87a2fa56
This updates to latest version of Elysia and adds the ability to install this package from source (if there is no dist, install dev deps & build). 🐈
This does regress the instance seeding. 🐈⬛
I tried to keep the changes minimal, this is simply the result of the combination of changes I got working with no errors and with JWK support.

Can we have this pull request merged?


The max_iteration for small star and large star in minhash_spark.py

How to set a proper num of max_iteration to get a better trade-off between efficiency and accuracy? As normally when we're using spark clusters, we may deal with TBs of data which is time consuming.

Thanks! I'll try it.


Replace problematic DOI with PMID

Closes #24150
GO:0061971 references the article "Development of the cranium and paired fins in the zebrafish Danio rerio (Ostariophysi, Cyprinidae)" by its DOI (10.1002/(SICI)1097-4687(199608)229:2<121::AID-JMOR1>3.0.CO;2-4 ), which has lots of weird characters in it and is problematic for downstream consumption. This PR switches this reference to the associated PubMed identifier for the article https://pubmed.ncbi.nlm.nih.gov/29852585/

Thanks @cthoyt!


Update sites.yml

This PR is:

[x] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

[x] I used the uncompressed size of the site
[x] I have included a link to the Cloudflare report
[x] This site is not an ultra minimal site
[x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[x] Check to confirm

- domain:
  url:
  size:
  last_checked:

Cloudflare Report:
Cloudflare Report URL

The Cloudflare  link in the description doesn't lead to the report. Could you check that?

Seems like i somehow got to another Cloudflare URL scanner. I checked the FAQ again, used the provided URL and got the summery.
summery

Thank you!


Handle DefaultChannelsOverride

cc @buoyad for gui changes/arg rename

K UI changes are done. cc @keybase/y2ksquad


Kinematic body (3d) not using layer/mask correctly

Operating system or device - Godot version:
Windows 7, custom build from November
Issue description (what happened, and what was expected):
My understanding is that a physics object that has it's layer set to 1, and it's mask set to 2 will only collide with an object that has it's own layer set to 2
In the demo project I've attached, both kinematic bodies have their layers set to 1 and their masks set to 2. As far as I'm aware, this should mean that the two bodies shouldn't collide, yet they both stop when they reach each other.
Conversely, if you set the first objects layer to 1 and it's mask to 2, and the other objects layer to 2 and mask to 1, they should technically collide with each other, but instead they pass straight through.
Wondering if it was related to this issue? https://github.com/godotengine/godot/issues/872
Steps to reproduce:
Download and run the attached project. The first scenario I've described is already set up to run, but you'll have to manually edit the two bodies to test the second scenario I mentioned.
Link to minimal example project (optional but very welcome):
https://dl.dropboxusercontent.com/u/3292249/kinematic3d_bug.zip

Can you confirm that the same thing works fine for KinematicBody2D? (if it is, the I introduced this bug... ops)

Just tested it with KinematicBody2D and it works correctly

The issue is on 2.1.1 too (KinematicBody against kinematic or rigid on any mode), happens when using move against anything on the same layer.
Maybe move or the server is checking layer instead of mask because it also pushes rigids on other layers.

Wait, you mean that Rigid-Rigid works fine, right? :smiley:
If so, that would limit the bug to the move function...

@bojidar-bg Rigid moving (impulse) against kinematic or rigid works fine, Kinematic moving (move) against rigid collides (same layer, any mode) or pushes it (different layer, rigid mode).
So, yes, probably move is the first place to look (but all the KinematicBody code looks old compared to the 2D one).

I'm wondering if this ever worked for KinematicBody 3d? Looking at the code, I can't see it making any use of the collision mask in the move function, just the body's layer

Ah this explains some behaviour i saw, this is a thing that would be really good to have fixed!

Move is broken on KinematicBody on Godot 3 too, but now it seems to be inverted the layer-mask check (the moving body checks for masks on its layers instead of other layers on its mask).

This should be fixed now, would be nice if someone could check

Issue persist with Bullet cc @AndreaCatania

To resume, using bullet:
Kinematic on layer 2, mask 1, using move and slide:

Collides with anything on layer 2 (should ignore)
Collides with anything on mask 1 (should ignore)

I can see dropbox link with reproduction is not working anymore. @sketchyfun could you reupload?
Also tip for the future, you can upload directly on github by drag and dropping zip to the browser.

I haven't checked if it still works but here's the link https://www.dropbox.com/s/dwp6qx1d64x8t7t/kinematic3d_bug.zip?dl=0

@sketchyfun this project is not for godot 3

I've checked it with either Godot and Bullet physics and it works correctly

Okay, so I just recreated the project in 3.0 and I can't reproduce my original issues, so it looks like this is
no longer a problem.
I've uploaded the project just in case anyone else wants to try it, but it seems to be working now.
kinematic_bug.zip

I'm going to close this as it seems to be fixed, thanks @AndreaCatania !


ログイン・ユーザ登録時トースト表示のエラーをユーザに理解できる文章に変更した。

Codecov Report

Merging #73 (f2cfec1) into master (84ecee8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #73   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           46        46
=========================================
  Hits            46        46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ecee8...f2cfec1. Read the comment docs.


Create NPM Package

What needs to be done to turn this library into an npm package?

You'll probably want to tweak / add these files:

gitignore
npmignore
PUBLISH_NPM.md
package.json

Working on a PR for your review.

Bam, working npm installation. https://www.npmjs.com/package/crunker
Should verify it is in fact working by testing with another project, but, all in good time.


is is possible to define css with inlined-svg definitions, rather than referencing a sprite file as a background image?

is it possible to define css with inlined-svg definitions, rather than referencing a sprite file as a background image?
I would like to use the 'fill' style in css to alter the appearance of svg I am using, but loading the sprite as a background image does not allow me use the 'fill' style.
Would you recommend the best approach for me?

@iambumblehead I'm not sure if I understand you question correctly. What I can say is:
node-iconizr
With "CSS with inlined SVG definitions" you probably mean that the SVG code should be contained as data URIs inside the CSS, correct? For that purpose you should have a look at my node-iconizr project which creates several different CSS files for a set of icons. One of these formats is probably the one you're looking for. However, there are some drawbacks:

Please be sure to use the dev branch of node-iconizr as only that one builds upon the latest version of svg-sprite.
Unfortunately the latest node-iconizr is only poorly documented so far as I simply didn't find any time to actively work on in for a long time now. Your best bet would probably be the the configuration docs, and you should be familiar with svg-sprite to understand it.
I'm not able to provide specific support for node-iconzr at the moment.

Inline SVG & styling
As far as I know it is not possible to style SVG by means of CSS when it's embedded into CSS (please correct me if I'm wrong). You'd have to inline the SVG into your HTML code instead. That, however, is nothing you'd need node-iconizr for. Instead, create a sprite using the defs or symbol mode and enable the inline option to make it a special variant suitable for HTML embedding. Then you should be able to style the SVG code by CSS.
Please let me know if this helps. Thanks.

@jkphl thank you for the thoughtful answer...
'symbols' are mentioned in your documentation here, but I did not know what symbols were. For me, the best approach appears to be using svg-sprite to build an svg file with symbols in it, and referencing those symbols with inline html/svg nodes that are styled with css.
Using symbols gives the following advantages over the sprite-style svg I was using:
1. continue using a single svg file
2. style svg images using css (no need for separate color versions of same image)
3. proportionally scale svg images to any size (no need for large and small versions of the same image)
4. use exact-fit svg images (no percent-based sprite positioning that almost fits)

@iambumblehead AFAIK the only problem could be that CSS styling capabilities for an external symbol SVG sprite  in combination with <use> are somewhat limited and browser dependent. But you might give it a go in any case.


Add missing install to the jlab command

A quick README fix for the JupyterLab extension installation command.

Thanks!


Added support for the new 3 gang Tuya switch, needed some enchantment and missing input clusters.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 82.899%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
6302

Relevant Lines:
7602

💛  - Coveralls

Codecov Report
Base: 82.89% // Head: 82.89% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (f57aa87) compared to base (c2de1b2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1899   +/-   ##
=======================================
  Coverage   82.89%   82.89%
=======================================
  Files         245      245
  Lines        7599     7602    +3
=======================================
+ Hits         6299     6302    +3
  Misses       1300     1300

Impacted Files
Coverage Δ

zhaquirks/tuya/ts001x.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Mixed feelings about splitting the file. Tuya folder already has a lot of files, but in the other hand file is growing up unordered...
I believe that I would prefer keeping all in the same file, but I don't have a strong opinion.

Let's not split the file for now.

@bramdan can we put these back in the other file for now please? We can reassess splitting at a later date.

@bramdan can we put these back in the other file for now please? We can reassess splitting at a later date.

@bramdan any chance you can do this?

Hi, is this quirk usable as-is?  Would love to tweak whatever is necessary locally if I can. Thanks!

If your device is having the same signature it is very likely fixing your problem with the device then its casting the tuya magic that shall fixing it.

@bramdan @ufanders Can either of you provide the device signature (or diagnostic information) for these unsupported Tuya switches?

Rebased to fix merge conflict. Also merged all Tuya switches into one file again.
Fixed the comment for clusters and renamed the class (although the "naming scheme" completely varies in that file already, so I'm not sure what I chose is the best option).
Should be ready for another review now.

Hi Julian,
if I haven't missed anything, TuyaTripleNoNeutralSwitchVar2 is exactly the same as TuyaTripleNoNeutralSwitch_2 (added in #2091?)

Yep, thanks for catching that! We should probably have a test for duplicate quirks
Closing as this is already implemented then.


Minimalistic Hoftix for Tweak Problem

Type of Change

[x] Hotfix

Description
Another minimalistic way of fixing the Tweaks problem

As #2720 was merged already, I'm closing this as it was simply an alternative solution to fix the same problem and illustrate what went wrong in the first place


Gradle Build Issues on Amazon EC2

Hi there,
Installing on an EC2 server running Amazon Linux, with the user set as "ec2-user", I've cloned the git repo, made everything in the airpal folder executable, and tried running the ./gradlew script with:

useLocalNode (tried v0.10.33, v0.12.0, v0.12.2)
Gradle's own Node version (i.e. no flags on "clean shadowJar" command)

Both ways end in a build failure at the same point, with the following error message (see gist):
https://gist.github.com/curry36/ee6e3bdd788a58db761b
Thanks!

I’ve got the same issue on OS X 10.9.5 (node v0.10.38, gradle 2.3). Any ideas how to fix that?

Related to BrowserSync/browser-sync#594
Possible fix:
edit src/main/resources/assets/package.json and change browser-sync to ~2.6.5

Thanks so much! That fixed the problem for me as well.

Sorry for the delays in responding! This seems to be the same issue as in #112. I'll follow up in that thread. If bumping the browser sync version is all it takes, we can easily do that.

I have the same problem!


search help about py4vasp on Mac jupyter

Dear developer,
I encountered a problem when using py4vasp on jupyter installed on Mac OS 10.15, when reading .h5 file, it said there was no access, while this file can be read on Linux jupyter. I dont know why

Perhaps you can try the solutions in this thread. In particular the h5debug
Tool and downloading the file again.
https://stackoverflow.com/questions/38089950/error-opening-file-in-h5py-file-signature-not-found
On Sat, 13 May 2023, 08:17 billcsu, @.***> wrote:

Dear developer,
I encountered a problem when using py4vasp on jupyter installed on Mac OS
10.15, when reading .h5 file, it said there was no access, while this file
can be read on Linux jupyter. I dont know why
[image: image]
https://user-images.githubusercontent.com/133481966/238116646-a751c052-cee4-4214-bca3-d0784f8ebf85.png
—
Reply to this email directly, view it on GitHub
https://github.com/vasp-dev/py4vasp/issues/89, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF67WIMSTESOFBYTDMDXNYDXF4RORANCNFSM6AAAAAAYAJRDXE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks very much, it is the problem that I was not downloading the .h5 file correctly.

Additional question related to this one:  whether py4vas can be installed on Windows anaconda enviroment.  I've tried, but failed when getting requirements to build wheel.


which formatter to use

I am starting to create PRs. Which formatter shall I use? I usually use black.

In the past I have used Eclipse with PyDev and have used the built-in PyDev formatter.
But I have changed to the black formatter and VSCode for the next update, which is coming soon. Some of the examples are not yet formatted with black.
So the black formatter matches.

awesome, thanks!


Added filter callback on dropdown menu

I added a callback on DropDown Menu for filtering options. I needed this feature because I wanted to filtered data using a custom way and that was not possible. For searching there was already a callback that helped, but none for filtering.
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is test-exempt.
[X] I followed the breaking change policy and added Data Driven Fixes where supported.
[X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@QuncCccccc any idea when you can look over this PR?

@QuncCccccc any idea when you can look over this PR?

Hi! Sorry for the late response! Overall this is a reasonable feature, will take a look very soon!

@QuncCccccc can you take one more look here, please?

@QuncCccccc any updates?

@QuncCccccc are you still around? @HansMuller  Should I contact someone else?

@QuncCccccc I reverted the changes.
I'm still not sure about the reverting of line:
if (_enableFilter) {
      filteredEntries = filter(widget.dropdownMenuEntries, _localTextEditingController!);
    }

Maybe I should add this condition in my if clause:
    if (widget.enableFilter) {
     ...
    }

And transform it into:
if (_enableFilter && widget.enableFilter) {
...
}

I wonder if the enableFilter parameter is redundant now. What if we remove it and use only filterCallback? For users that want the previous enableFilter: true behavior, we could expose the filter function that they could pass to filterCallback.

Yeah, I was also thinking about whether two properties for filter is a little too much. If we deprecate enableFilter, users need to explicitly pass a filter function to get the original filter result; otherwise, leaving it as null means no filter at all, right? I was just worried about the breaking change but deprecating enableFilter will definitely make apis simpler!

@justinmc @QuncCccccc
I think that we should keep some consistency here as well. I chose to add filterCallback and keep enableFilter so the feature will work the same as searching with enableSearch and searchCallback.
I also think there is some redundancy and we can make the callback nullable and remove the enable... flag. But if we do this for filtering I think we should do this for search as well.
What do you think?

Ah I didn't realize there was already enableSearch and searchCallback. I don't want to overly complicate things then. @QuncCccccc did you originally write enableSearch and serachCallback? Do you think it's worth it to migrate all of them or just keep everything as-is?

Ah I didn't realize there was already enableSearch and searchCallback. I don't want to overly complicate things then. @QuncCccccc did you originally write enableSearch and serachCallback? Do you think it's worth it to migrate all of them or just keep everything as-is?

I think we can just keep it as-is for now, but at the same time we might want to add an assertion to make sure when filterCallback is not null, enableFilter must has been set to true, something like assert(filterCallback == null || filterCallback != null && enableFilter == true). Thanks @justinmc for your suggestions!

@QuncCccccc I added it. Wasn't sure if I needed to add a comment there or not.

LGTM with some suggestions below.
Just noticed I didn't click Approve last time. I will ask the second review when the comments are fixed:)! Thanks again for the contribution!

No worries @QuncCccccc ! I fixed the comments!
Thank you too for helping me getting it done!


Fix link to latest released version

The URL to the latest version seems to be incorrect. I replaced it using as reference the URL to the development version in this same document.

Thank you @PabloDeAlbu


Run importer and resolver in tests.

I don't think that crates can depend on compiler. Wouldn't this be a circular dependency? Maybe it's fine for the tests.


v2: Plugin can't modify webpack config

Please reference to following code, the first param of onCreateWebpackConfig hook is an immutable object.
https://github.com/doczjs/docz/blob/c72c57574142334846e7aad63ad3e72d07f9ddca/core/gatsby-theme-docz/lib/onCreateWebpackConfig.js#L31

I'm sorry I'm not sure I understand the issue.
Are you looking to modify docz's webpack config in a project ?

I'm experiencing the same issue.
At the root of my project i've added a custom gatsby-node.js file:
 const path = require('path'); exports.onCreateWebpackConfig = ({  actions }) => {   actions.setWebpackConfig({     resolve: {       alias: {          theme: path.resolve(__dirname, '../src/lib/theme'),       },     },   }); };
However, when I run yarn docz:dev my components are not able to resolve theme.
I've tried several variations of this command, with no success. Either I'm doing something wrong or docz just isn't able to resolve this configuration.
Was going to come here to report this, but then spotted this issue, so it looks like indeed there's a bug.
Help appreciated, thanks!

Thanks for @josebrito for clearing that up.
I might have an idea what's causing that, checking and will update here.

Is the project a Gatsby app ?

@rakannimer in my case, no. Docz is the only package dependent on Gatsby.

Should be fixed in 2.0.0-rc.28
Please give it a try and let me know

@rakannimer
I try to rewrite the less plugin for v2 and then meet this problem.
In the v1, the first parameter of "modifyBundlerConfig" is an object of "webpack-chain".
however, the parameter of v2 is an independent object. you can't add new module rule for webpack by modify the parameter.
https://github.com/doczjs/docz-plugin-css/blob/3f0c9a06de58f550011723c0fd0619c09f0538c7/src/index.ts#L134
following code from v2.
https://github.com/doczjs/docz/blob/2f29e1d4a18854bd32618960c97a697df13a85d7/core/gatsby-theme-docz/lib/onCreateWebpackConfig.js#L13
https://github.com/doczjs/docz/blob/2f29e1d4a18854bd32618960c97a697df13a85d7/core/gatsby-theme-docz/lib/onCreateWebpackConfig.js#L31
v1
https://github.com/doczjs/docz/blob/b2091fb1cf9ff3d2e648066a6ea0018df0ae57ae/core/docz-core/src/bundler/config.ts#L18
https://github.com/doczjs/docz/blob/b2091fb1cf9ff3d2e648066a6ea0018df0ae57ae/core/docz-core/src/bundler/config.ts#L179

Hey @hvsy
You're right you can't modify the config object directly, to modify the webpack config you can use actions.setWebpackConfig
Example :
exports.onCreateWebpackConfig = ({
 stage, getConfig, rules, loaders, actions
}) => {
  actions.setWebpackConfig({
    module: {
      rules: [
        {
          test: 'my-css',
          use: [loaders.style(), loaders.css()]
        },
      ],
    },
  });
}

More info can be found here : https://www.docz.site/docs/creating-plugins
Does that address your issue ? Or am I missing something ?

@rakannimer
please check following code
https://github.com/doczjs/docz/blob/2f29e1d4a18854bd32618960c97a697df13a85d7/core/gatsby-theme-docz/lib/onCreateWebpackConfig.js#L31
the first parameter is not "actions" but "config"

Ok understood 😅!
I will add params as an additional argument to avoid breaking any existing v2 plugins. Would that work ?

No need to add additional argument.
because the current "config" object is immutable. existing v2 plugins hasn't a working.

Changed https://github.com/doczjs/docz/pull/1072/commits/66546a4e2ec2bb90847e137f8159b1784c26f04d in 2.0.0-rc.32

Changed 66546a4 in 2.0.0-rc.32

it is working well now.
but the document inconsistent with code.

Also onCreateBabelConfig does not seem to work.
exports.onCreateBabelConfig = ({ actions }) => {   actions.setBabelPlugin({     name: '@babel/plugin-proposal-decorators',     options: {       legacy: true     },   }); };

@hvsy, yep replaced actions with params now to match docs.
@nikitpatel24 this looks like a separate problem, params are passed down correctly for onCreateBabelConfig. Could you open another issue to pin down your problem ?

Hi, sorry for the lack of updates, just wanted to confirm that issue is fixed. Thanks!


minor changes on the ECR code to view the report more precisely

Proposed changes
The Earlier code would show the report with and without vulnerabilities tags on the cloudreport.
The code is now updated with two features

Get the Images and the tag of those only with the vulnerabilities and does not show the TAGs/Images without issues/vulnerabilities .
The code also shows the tags that with same SHA's as the comma separated tags. This mean when the same SHA of the image is used on the different environments, the image tag is now counted as a new vulnerabiliy.
-->

Issues for these changes

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (changes to code, which do not change application behavior)

Checklist

[ ] I have filled out this PR template
[x] I have read the CONTRIBUTING doc
[ ] I have added automated tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

Relevant Links

Further comments

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sainath Devulapally seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

reportscan.log

@bjfish25 Updated the notes and added the log report as an example. Please review. Thank you.

@sainathdev Can you update the doc page here to include an example of a finding with an image that has more than one tag?

@shubydo  I have updated the md file. please review.


Issue with man pages

Loving this plugin! :rocket:
One issue I have is that I use MANPAGER='nvim +Man!' to use nvimfor man pages. However if I runman nvimin anvim`-terminal I just get an empty buffer. Any idea how to solve this?

I might not have time to look into this for a bit. One thing that you could do as a band-aid is set the man pager to also pass the flag to disable unception in addition to the +Man flag. That should at least allow you to open a man page, even if it's nested.

Thanks for the suggestion @samjwill! I tried setting:
export MANPAGER="nvim +'let g:unception_disable=1' +Man!"

instead but still getting the same behaviour unfortunately. Any thoughts of why that might be? But no problem at all if you don't have the time :)

Alternatively, I know the developer for nvim-flatten, which is based on unception with some feature additions/code tweaks, was working on support for piping text. There might be something you can throw together to pipe text directly into a Neovim buffer using that and set the file type to a man page for syntax highlighting.

Thanks a lot for the input, really appreciate it! I'll try this out and see if I can get it working 👍

Thanks again @samjwill, using --cmd indeed did the trick. I hadn't realised that + and --cmd are executed at different times. It indeed creates nested sessions but I can at least now open the man pages like this again.

I also tried setting my MANPAGER to a bash script of the form:
file=$(mktemp)
cat > $file
nvim +Man! $file

which at least opens the man page but the Man! command is not passed to the original session so the formatting is off.


Add liveliness and readiness probes in the manifests

None required

Don't merge this yet

@gunjan5 I think this is worth a release note :)

I thought release notes would be from Felix/Typha repos but now as I'm typing this I realize it'd be in this repo. I'll add one


[INTERNAL][WIP] Versioninfo enrich with manifest infos

For the task generateVersionInfo,
the version-info.json file should contain in the libraries the information about manifestHints (dependencies, fully resolved) if available.

Coverage decreased (-0.06%) to 93.233% when pulling 8cbb2ca52e64db1c9e985c95c0b31508c7e4f2c1 on versioninfo-enrich-with-manifest-infos into 9067e11adae828f910963da3f43b35255f6ce55c on master.

Coverage decreased (-0.06%) to 93.233% when pulling 8cbb2ca52e64db1c9e985c95c0b31508c7e4f2c1 on versioninfo-enrich-with-manifest-infos into 9067e11adae828f910963da3f43b35255f6ce55c on master.


Create a new model in merlin to work with Keras framework

Make use of Keras framework to train the models and use it with merlin.
Something, in the lines of "models/deep_rnn.py"

Hi,
I was trying to model LSTM using keras along the lines of merlin LSTM example. I bumped into one issue-
Does merlin uses "stateful" LSTM akin to Keras i.e cell states(activations) are propogated through successive batches, instead of resetting it for every batch. Similar approach was used by Alex Graves: Generating Sequences With Recurrent Neural Networks, where cell states are reset after every 100 epochs.
"Stateful" defined in Keras Docs:
stateful: Boolean (default False). If True, the last state for each sample at index i in a batch will be used as initial state for the sample of index i in the following batch.
I went through merlin code, but I was unable to develop an intuition. It would be helpful if you can clarify it.
Thanks!

If I understand correctly  RNN/LSTM implementation in Merlin, it's not stateful as in Keras. Since we are not saving the previous cell states after each batch. In RNN/LSTM, the batch size is equal to utterance size  and after each utterance the cell-states will reset. Thus, if you want to implement the LSTM model in Keras with stateful then you have to modify the dataprovider script in merlin to format the data in fixed batch size (batch_size, n_in, n_out, input_length).

I think we need to modify the dataprovider script for sequential model training to gain the computational performance as mention in the https://github.com/CSTR-Edinburgh/merlin/issues/22, even if it's not for Keras.

@bajibabu @ronanki Remembering cell states should increase performance in theory. Each batch will prime the activations, thus accounting for long term dependencies. As far as I understand, currently merlin is using a kind of truncated BPTT i.e BPTT over a single utterance as cell states are reset after each batch.

I agree on what you said. But it is good to do a small study on how much the performance is increased and how much computational time and memory are increased.

@ishank26 As @bajibabu said, the issue #22 has to be implemented first before doing anything else. At the moment, the batch size for sequence modelling is 1 utterance and all utterances are shuffled before passing it to dataprovider script. This has to be changed -- w.r.t batch size (in terms of no. of utterances), the shuffle has to be done accordingly and then should be passed to dataprovider script.


version conflict

Does this support only on laravel 5.3 or lower version too? I am working on laravel 5.2, and I am getting error.

@vijay-kumar-rana please update to last laravel version , we don't have plan to support old laravel version as we have limited resource


fix multi IP addr on host network

fix docker run --network host issue

What issue is this? Can you give a little bit more information about the issue this tries to resolve?

Looked good, had to test on the normal type and host network types just to make sure they both worked out. Thank you for this contribution.


[HDInsight] Support new feature:  create kafka cluster with kafka rest proxy

This PR is related  with swagger PR [HDInsight] Support kafka rest proxy feature

Support new feature:  create kafka cluster with kafka rest proxy
update azure-mgmt-hdinsight version from 1.1.0 to 1.3.0

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@Juliehzl  Could you please help us review this PR? Can we join S162? I added  S162 milestone by myself.

@haroldrandom  @Juliehzl  Is there someone can help review our PR? It's already 3 work days since we submitted the PR.

Bump SDK version need to updating tests I think?

@haroldrandom The SDK is backward compatible. The newer SDK only adds a few properties to support this new feature. So in general it is not necessary to update tests due to SDK version change.

@haroldrandom The SDK is backward compatible. The newer SDK only adds a few properties to support this new feature. So in general it is not necessary to update tests due to SDK version change.

We know the newer SDK should be backward compatible, but I think the new SDK may have api version number change, right? Re-recording your tests in hdinsight module based on the new SDK can help double-check the functionality of new SDK and update the request url to make it consistent with the new SDK used. We really recommend you re-record your tests here.

LGTM in general. Please resolve all my comments and if CI agrees I will approve.

@haroldrandom The SDK is backward compatible. The newer SDK only adds a few properties to support this new feature. So in general it is not necessary to update tests due to SDK version change.

We know the newer SDK should be backward compatible, but I think the new SDK may have api version number change, right? Re-recording your tests in hdinsight module based on the new SDK can help double-check the functionality of new SDK and update the request url to make it consistent with the new SDK used. We really recommend you re-record your tests here.

Hi Zunli, I have added a test for the new properties. Thanks

/azp run

Hi @Juliehzl , how do you like our PR?


operator project-quay (3.9.0-nightly.20230314)

Add 3.9.0-nightly.20230314 to community operators

/merge possible

/merge possible


Add hook conditions to route level hooks

Description
Updates the getRouteHooks method to return only hooks that should be run based on the RouteHookType

@stackoverfloweth I think this is ready based on what we talked about. I didn't implement the onBeforeLocationUpdate in this PR but that will be the next piece I work on. We'll need a little more functionality in navigation to account for actually aborting navigation. So should have a fairly small PR to implement that. I also need to write tests for the component and global hooks. So this will probably be a few PRs before this is buttoned up.


Enabling ARM builds

Description
Enabling ARM builds for macOS
Motivation and Context
To be able to test on ARM machines.
Checklist:

[x] My pull request is properly named
[x] The changes respect the code style of the project ($ npm run lint)
[x] I tested/previewed my changes locally

@kytwb - with this PR, can we now focus on getting the appveyor builds fixed please?

@vraravam does this invalidate https://github.com/getferdi/ferdi/pull/1277?

Duplicate of #1277  - closing


version 0.2.2.post4 lost some functionalities version 0.1.9 had. An example included

I upgraded this amazing component today.
Testing using the example themes_and_pre_selection.py gives:
version 0.2.2.post4

version 0.1.9

It looks like I have all requirements satisfied.

python = 3.9.4
Pandas = 1.3.4
simplejson = 3.17.2
numpy = 1.20.3

Thanks for the great work!

I couldn't reproduce it here...


Fix Upstream Sync

Error: fatal: could not read Username for 'https://github.com/': terminal prompts disabled
Error: The process '/usr/bin/git' failed with exit code 128

Source

[!CAUTION]
I need to fix the funding wallet for this org so will do that when somebody takes on this task.


Minify Bundled Entry Point Script

This issue recommends minifying the bundled entry point script. To achieve this, one can utilize the --minify or -m parameter when using the ncc command to bundle the script.

After careful consideration, minifying the bundled script for a GitHub Action project appears impractical. This is because committing the minified script to this repository could potentially increase the repository's size with each change, even for minor modifications.


[BUG] judged wrong app type when buildcontext is both have yaml and shell files

What happen?
If the app type cannot be judged, user needs to write APPCMDS in the kubefile.
for example:
i have a app contains yaml file and shell:
ls buildcontext:
nginx.yaml
ns.yaml
start.sh

i just want to copy all yaml and shell files , then use start.sh to launch my app.
kubefile:
FROM scratch
APP myapp local://buildcontext
LAUNCH myapp

this will judge myapp its a yaml type.
Relevant log output?
No response
What you expected to happen?
No response
How to reproduce it (as minimally and precisely as possible)?
No response
Anything else we need to know?
No response
What is the version of Sealer you using?
No response
What is your OS environment?
No response
What is the Kernel version?
No response
Other environment you want to tell us?

Cloud provider or hardware configuration:
Install tools:
Others:

Duplicated issue with #1993


Define labeled items recursively

Hi again!
I'm at a point where I need to parse all of the labels for a node from the devicetree source but currently the additional node yields an error.
Examples
> parser.parse('foo: bar {};').rootNode.toString()
'(document (labeled_item label: (identifier) item: (node name: (identifier))))'
> parser.parse('foo: bar: baz {};').rootNode.toString()
'(document (labeled_item label: (identifier) (ERROR (identifier)) item: (node name: (identifier))))'

I'm sure my solution isn't suitable so this is partly a question of the intended difference between labeled_node and labeled_item and how the aliasing should work. Originally the only way I got the recursion working for arbitrarily many labels was to delete the labeled_node rule and make define labeled_item recursively.
Alternative approach:
Locally I've just tried another change where both rules are recursive versions of themselves:

labeled_node: ($) =>
	seq(
		field('label', $.label_identifier),
		':',
		field('item', choice($.labeled_node, $.node))
	),

labeled_item: ($) =>
	seq(
		field('label', $.label_identifier),
		':',
		field('item', choice($.labeled_item, $.node, $.property))
	),

This doesn't cause errors, but the results for the same test committed in this branch differ:
    (document
      (labeled_item
        label: (identifier)
        item: (labeled_node
          label: (identifier)
          item: (labeled_node
            label: (identifier)
            item: (labeled_node
              label: (identifier)
              item: (node
                name: (identifier)))))))

The three nested labels are picked up as labeled_node this time instead of labeled_item like the outermost. Is this because the aliasing of the rule only applies to top level items? I'm not sure what you would consider to be more appropriate.

@joelspadin I'm doing some more work with managing/editing labels and realized it makes more sense to treat multi-labeled nodes as a single labeled_item node with multiple label fields.
I've made a separate branch to show the relevant changes here: https://github.com/joelspadin/tree-sitter-devicetree/compare/main...nickcoutsos:tree-sitter-devicetree:feature/multi-labeled-nodes-alternate

Thanks!

Hi Joel!
Did you have any thoughts on the two approaches? I feel like multiple label fields in a single labeled_item node makes more sense, and it's the approach I'm using now, but I neglected to update this PR to propose that instead.

Oh, true. I do think that might make more sense.


Search bookmarks

I would really like it if my bookmarks were included in the suggesstions when searching from the address bar.

That's a really good idea! Thanks for raising this. I'll pass this idea on to the rest of the team for consideration.
Internal issue: https://app.asana.com/0/608920331025315/793359964050426

This has now been released in 5.30.0


cuelang.org: preprocessor: scripts/serve.bash usually fails to serve updated content

What page were you looking at?
https://cuelang.org/
What version of the site were you looking at?
https://github.com/cue-lang/cuelang.org/commit/9adb346c4051adcbb933db4ba9bcf5a31c1acc8b
What did you do?
I ran _scripts/serve.bash, and waited for the site to be served at http://localhost:1313.
I updated some prose source (i.e. not code-related) inside the content/ hierarchy.
What did you expect?
I expected that, when the locally served page refreshed itself, its rendered form would always reflect the updated source.
What did you see instead?
At least half the time I follow this process, the on-page content doesn't reflect the updated source in content/. The hugo process emits debug output that says "Change detected, rebuilding site", and the rendered page refreshes itself automatically (as expected), but the rendered content matches what was present when scripts/serve.bash was initially invoked.
To fix this, I have to rerun _scripts/serve.bash until the behaviour changes.
For each run (and rerun), the behaviour is internally consistent: if the changes aren't reflected on-page, they never will be. If the changes are reflected, then the process is in a good working state until the next time I stop it for some reason.
The "wrong" behaviour kicks in somewhat more than 50% of the time. I'm unable to find a consistent trigger, but it's easy to observe happening, several times each editing session.
I've recorded a screen capture video of the problem striking. (Note that the wall clock timings experienced in the video are over an order of magnitude slower than when I'm not performing a screen capture - my machine doesn't seem to enjoy recording video!). The video is a split screen of a terminal on the left, and http://localhost:1313 on the right, to demonstrate the problem in action.
Video timings:

00:00 - context (current tip of master; script recording of script/serve.bash output (attached to this issue)).
00:25 - running script/serve.bash for the first time; the problem does strike this invocation.
01:00 - the site is being served.
01:08 - making a change to content/docs/_en.md.
01:23 - the favicon on the browser window flickers, indicating that Hugo has prompted a page reload after a content update. The rendered page doesn't reflect the amended content.
01:27 - making a second change to the same source page.
01:37 - the page reloads again.
01:42 - restarting the script.
02:18 - the site is being served; the page is reloaded manually.
(to the end) - changes in the markdown source are reflected in reloads of the site, though due to the slow site render speed they get out of "sync". This is not the issue being reported here, and isn't in effect in normal (non-screen-captured) operation.

Attachments:

serve.out: https://github.com/cue-lang/cue/files/15404901/serve.out.txt
Video: https://drive.google.com/file/d/1UYYMpRX2n8Jms1kCBq9D8shZboTZQZ6q/view.

I've upgraded from Hugo 0.124.0 to 0.126.1, which appears on first glance to have resolved the issue. I'll close this if the problem doesn't strike again over the next few hours.

I think you can close this issue regardless, because the updated file was (per your offline comment) being written to the hugo directory structure. As such, if there is an issue here, it's almost certainly a Hugo issue.


Add Veloren

Adds Veloren dedicated server.
Note:

No settings are configured as the server uses RON files that AMP cannot write to, and doesn't have command line flags for settings.
The consequence of the above is that the ports need to be manually adjusted in the settings file after the server is started the first time, if the instance is created on non-default ports. This could result in initial server start failures if the default ports are already being used by something else on the system.
The update stages are a little clunky given that the FetchURL update stage does not allow the target file name to be specified, and accordingly the file downloaded is missing the .zip extension and is not recognised as a ZIP by AMP for extraction purposes. This requires the file to copied first to a file with a .zip extension, and then extracted. The result is that the original download is left behind.
The template is affected by this bug, relating to tracking user joins and leaves by sessionid.

One suggestion for the YAML file. I used the same trick on Empyrion since JSON is a subset of YAML. Run the contents through a site like this, then include the converted with your config if it works. AMP can then write to it since it's JSON and the game can probably write to it since it's also still a type of YAML. (That's the idea anyways)
https://jsonformatter.org/yaml-to-json

I misspoke, the format is RON. Corrected above.

Lol I should have known that, but slept since we talked about it. Is this ready for testing?

Yep. ThisIslandEarth on Discord has put it through its paces too.
The lack of ability to specify the ports in advance bothers me. I asked in their discord whether there were any undisclosed command line params for setting ports, but they confirmed there weren’t and that they had no plans to add any params (which I find weird). The only way that AMP could in theory work with the file is via a template merge (both because of the RON format and the way the port is specified in the file along with the IP), but then that becomes a problem in terms of user control of the file, which will be needed for certain settings. More fundamentally, in some cases the AMP config manifest just won’t be able to accommodate the values required, which defeats the purpose of a template merge. Plus also a maintenance issue.

What about putting the template in the same directory as the server's config file and naming it something obvious like "...EDITME"?

I don’t follow. The server generates its own config file on first start, and the contents differ depending for example whether IPv6 is enabled on the system. The devs are also adding settings over time - even “The Book” (their online manual) doesn’t have all the settings that are currently in the config file that is generated by the server

I'm suggesting to include a template config that if the user wants to make changes to the config file manually, they make it to the template file instead of the one the server is using. AMP would overwrite the server config file with the changes made in the template file.
I just don't see any other way than a template config to have this one be merged. I understand, it'd take more maintenance over time, but that's true of all game servers that have a setting file included. I wasn't aware the contents of the file changes. Is it possible to include a majority of the settings? Then if any minor ones are missing or get added by the devs, the user can easily add them into the template file themselves?

I see what you mean now, but it is still messy, say with the IPv6 binding.
And many settings use the RON Option type. Which means that a setting can either be None or Some(123) or Some(“text”). None is used when you want it to be null or empty, such as an empty string, and Some is where you want an actual value. The config manifest can’t handle that.

That's so terribly messy. Who designed this document format? Don't answer that, it's rhetorical.
What if it only handles the main settings like ports and server name? Put the IPv6 binding as [{{$IPv6Binding}}] and default value of ::. Then the user can change that through the GUI. But the ports and IPv4 binding is set by AMP? Just trying to think of ideas that would make this one work without being a total manual process for the users.

Template merge is all or nothing - you can’t have only some settings configured via the manifest. And the IP and port are not single settings, they are combined settings IP:port

I don't follow now. You can leave the other settings as they come. Don't have AMP manage those and it will copy it verbatim. If the user edits the template then the server config gets replaced with their manual edits as well. You can also specify two variables in one line (Can't you?)

Right, you want them to edit the AMP template rather than the server config directly. I can see that becoming confusing. Plus if an assumption is made that IPv6 is configured, but it is not, it will probably bork the server. But if you leave it to the user to add, they have to figure out how independently (not currently documented)

@IceOfWraith, you've shamed/inspired me into adding the template merge for key settings :)

I'm glad you were shamed into doing it. Heh I'll take a look tonight and try out the remaining configs you have waiting!

I note the Start/Wait/Stop update stages that I would otherwise have included in this have been removed because the Start stage fails when it immediately follows the Set Executable stage.
Unless this issue can be fixed, a pause stage would be a workaround: https://github.com/CubeCoders/AMP/issues/684

Thanks @IceOfWraith. I've updated the GH path for the config file download, so please review again :)


Remove timeout from Geocoding fixes #3619

@Kartones CR please
I'll figure out another implementation, but it'll have to be "suicide" in each implementation of geocoding (internal and high-res classes).

Frontend tests were OK :+1: (details)

Well, doing a quick check, geocoder/lib/geocoder.rb does Typhoeus calls without timeouts, probably adding them there, and maybe keeping an internal timer inside TableGeocoder, etc. you can very roughly keep track of elapsed time and error if exceeded a given limit.
Just thinking loud about a crappy solution, but to not give up on trying to control too long runs.
Other than that, :+1:  to this changeset

Yeah, well basically there should be 2 cases x 2 cases: (batched, non-batched) x (internal x hi-res). The thing is to control that

non-batched have always a network timeout (the actual work is done by a remote service, thus setting it should be enough)
batched should always have network timeouts for each batch and check the running time between batches.


access backend ply files on the frontend

by using the srorage media system, the files can be accessed
https://github.com/naturerobots/HSOS-SEP-PlantMap-2022/commit/905d3f8b13f6a6a6a6bc63412f62c2f9ee05c620


Update freebsd vm to latest version

Looks like the macOS failure is from a different cause. I'll resolve that later after merging.

Thanks for sending the PR!


Error handling

Handle offline/online status change
Proxy errors (301 etc)
Video didnt load on video page
Connection dropped or timed out
5XX errors from the server
Forbidden errors or unauthenticated

Need UI for: 1,2,4 (functionally offline) - whole page notice with buttons disabled or grey disabled overlay?
3,5 (server offline for some reason) - inform the user of the situation and offer options
6 - inform the user of permission error and offer to give up

Added disabled state for buttons and video player faild to load video: https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=2-466&t=KYlUj6pngVhB0APk-1
https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=909-14702&t=KYlUj6pngVhB0APk-1
The rest I think I need to know a bit more detail about

Added examples in Figma.
Offline: https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=925-19906&t=Y7ZXHPhd2Uo6hYzQ-1
Forbidden: https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=925-20181&t=Y7ZXHPhd2Uo6hYzQ-1

@mykhailodanilenko Made some slight updates the draft @mblomdahl posted yesterday. One variant for no thumbnail loaded, one for no video info fetchabe at all. Any other cases we need to support?
https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=1031-12837&t=vdB9kgNy04WroJEY-1


pydata.org/project/project-jupyter/ page renders incorrectly

I looked, but couldn't find a pydata.org repo for their site source. But I thought folks here might care to know that https://pydata.org/project/project-jupyter/ appears to have rendering issues. Screenshot attached.

maybe @aterrel could advise?

This is a Wordpress issue. I’ll bug the folks at<EMAIL_ADDRESS>in the morning. Martey or Walker will need to look into it.

FYI, I haven't heard back from the NumFOCUS staff that manages the word press. I believe some folks have been displaced by the weather. Will keep following up.

Thanks @aterrel no worries

This should be fixed now.

FIxed indeed, thanks.


nvAlt won't launch

This issues should be named: nvAlt won't launch on new MacBook Pro with OSX 10.14.1.
I've been using nvAlt with no problem after upgrading to Mojave. But I recently got a new laptop and just now tried to run nvAlt. It simply won't open. I tried downloading and installing a new copy to no avail. No error. Just 'application not responding'. I'll try it yet again and wait longer to see if it comes to live. I didn't see any other issue like this. But perhaps it is not being reported.

It was a dropbox issue. I am closing.