'backward' in itemRender will not display correctly

If itemRender is defined and backward is specified, it will not be displayed correctly.
The rightRender is passed in src/components/pagination.tsx:L153, but I think it should be leftRender.
The example below will appear as shown in the picture.

import { Button, forwardRef } from "@chakra-ui/react"
import ChocPaginator from "@choc-ui/paginator"
import React, { ComponentProps } from "react"

type ItemRenderFn = ComponentProps<typeof ChocPaginator>["itemRender"]

const PrevButton = forwardRef((props, ref) => (
  <Button ref={ref} {...props}>
    Prev
  </Button>
))

const NextButton = forwardRef((props, ref) => (
  <Button ref={ref} {...props}>
    Next
  </Button>
))

const BackwardButton = forwardRef((props, ref) => (
  <Button ref={ref} {...props}>
    Backward
  </Button>
))

const ForwardButton = forwardRef((props, ref) => (
  <Button ref={ref} {...props}>
    Forward
  </Button>
))

export const Pagination: React.FC = () => {
  const itemRender: ItemRenderFn = (_, type) => {
    if (type === "prev") return PrevButton
    if (type === "next") return NextButton
    // This will not be rendered.
    if (type === "backward") return BackwardButton
    if (type === "forward") return ForwardButton
  }

  return (
    <ChocPaginator
      colorScheme="blue"
      defaultCurrent={5}
      itemRender={itemRender}
      pageSize={10}
      paginationProps={{
        display: "flex",
      }}
      total={500}
    />
  )
}

I tried to fix it, but gave up because it fails to test on the master branch.
Would be great to see this fixed.

After cloning the code, I ran the yarn test
Here are the results
❯ yarn test
yarn run v1.16.0
$ tsdx test --passWithNoTests
 FAIL  test/blah.test.tsx
  ● Test suite failed to run

    src/index.tsx:34:26 - error TS2322: Type '{ currentPage: number; setCurrentPage: React.Dispatch<React.SetStateAction<number>>; pageSize: number; setPageSize: React.Dispatch<React.SetStateAction<number>>; ... 24 more ...; focusRing?: string | ... 1 more ... | undefined; }' is not assignable to type 'Pagination'.
      Types of property 'responsive' are incompatible.
        Type 'boolean | Partial<Record<Responsives, boolean>> | null' is not assignable to type 'boolean | Partial<Record<Responsives, boolean>>'.
          Type 'null' is not assignable to type 'boolean | Partial<Record<Responsives, boolean>>'.

    34     <PagContext.Provider value={value}>
                                ~~~~~

      node_modules/@types/react/index.d.ts:331:9
        331         value: T;
                    ~~~~~
        The expected type comes from property 'value' which is declared here on type 'IntrinsicAttributes & ProviderProps<Pagination>'

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        5.512s
Ran all test suites.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

There are no actual tests in this repo, I merely rendered an example component. Feel free to add tests if you wish.


LB healthcheck and policy configuration

@ibuildthecloud Darren, the PR is ready. Let me know if you are OK with the APIs


Only copy existing kube-apiserver requests but not limits

How to categorize this PR?
/area auto-scaling
/kind bug
What this PR does / why we need it:
Ensures that only requests but not limits of an existing kube-aserver deployment are copied when HVPA is enabled to allow limits to be removed from existing deployments.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:
Only requests but not limits of an existing `kube-aserver` deployment are copied when HVPA is enabled to allow limits to be removed from existing deployments.

/cherrypick release-v1.44

/milestone v1.45

/retest

Affected by https://github.com/gardener/gardener/issues/5833
/retest
now that https://github.com/gardener/gardener/pull/5834 has been merged


Handling Sorted Versions Files

Before we can swap over entirely, we need to make certain all the existing package version info is up to date with the new methodology. I am going to use a one-off script to make this update across the board.

Transitioned all existing docs.


Is a scale bar possible in atlas?

Add small scale indicator to atlas
Additional info
Please answer these questions before submitting your feature request.
Is your feature request related to an issue? Please include the issue number?
No
Does this feature exist in another product or project? Please provide a link.
NO
Do you have a screenshot? Please add screenshots to help explain your idea.
Probably not needed to illustrate the request but I think a simple scale bar, perhaps held to around 1 inch in size would be a nice addition

Yes it's possible. https://developers.arcgis.com/javascript/latest/api-reference/esri-widgets-ScaleBar.html


Create iesdoctorbalmis.txt

Instituto de Educación Secundaria "Doctor Balmis"

@josejpg Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!


Add ResearchGate in people's social

Add ResearchGate (https://www.researchgate.net/) to the list of social sites for each member.

Added Research Gate. Now you just need to add your link


add CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d6964d0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   89.01%
=========================================
  Files             ?        4
  Lines             ?      173
  Branches          ?        0
=========================================
  Hits              ?      154
  Misses            ?       19
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6964d0...77cb4d0. Read the comment docs.


Update index.html

Hi there,
Here's a summary of the changes I've made:

Improved code formatting and organization for better readability and maintainability.
Updated image source handling in the project section for flexibility.
Kept the same functionality and output as the original code.

Please review the changes and let me know if there are any additional adjustments needed.
Thank you!

Thank you for taking the time to make these changes.
While this site is open source, we are not actively making substantial changes to it; we have significant processes inside Microsoft to manage accessibility and other aspects.
If you'd like to contribute in the future, would suggest opening an issue to discuss the type of work and collaborate first.


Sleigh: logic for parallel-encoded opcode is ignored

In my architecture I have a parallel instructions encoding. It means that you can do some logic along with some moving in parallel. Here is an example:
parallel_move: reg1,reg2 is reg1; reg2 { reg2 = reg1; }

:lsl reg3 parallel_move is reg3; parallel_move {
 reg3 = reg3 << 1;
}

In result such an instruction should do both left shift and register assigning. But when I'm trying to implement this logic in sleigh, it just ignores left shift and only does a register assigning in the decompiler listing.

Adding build parallel_move; AFTER shifting has solved the problem.

I am not a Sleigh guy.  Is there still a problem or can we close this?

It seems strange that the ordering would matter. That's not a sleigh issue. What if you explicitly put the build parallel_move; before the reg3 assignment?
Also, what are the assigned registers for reg1, reg2, and reg3?

Putting build parallel_move before the shift don't help.
Registers are just an example. The same happens for STORE and LOAD operations.

The reason I was asking was in case the decompiler was simplifying things out for the registers being the same.

i have enabled register space in globals to see every single assigning.

Could you provide the pcode for the disassembly and the decompiler output?

I will, but during this weekend.

Okay, my fault. It seems that specifying the build parallel_move; is mandatory in this case.


Upversion to 4.18

Looks like we forgot to upversion rbac proxy here too. No impact to d/s, but still good to keep it consistent.

/retest


IME: TextEdit widget cannot support CompositionEnd only input character

Describe the bug
Can not input CompositionEnd character directly into TextEditor.
when input no-latin character such as Chinese into TextEditor, i must first input some word to trigger CompositionStart/CompositionUpdate event, then input some mark to trigger CompositionEnd event.
if i just want to type in a single character that trigger CompositionEnd event, TextEditor won't insert this character to text.

To Reproduce
1.Setup a demo app containing a TextEdit
2.Use Chinese PinYin input.
3.Do not type in any other word, just press [shift+1] , [shift+6] , [,], [.], [?] or any other CompositionEnd character.
4.Nothing typed into TextEdit
Expected behavior
Expected to type in Chinese character directly such as ！……，。《》、【】without need to trigger CompositionStart/CompositionUpdate event.
Desktop (please complete the following information):
 - OS: Windows11 Naive
 - Browser Naive App
 - Version 0.24.1 and master branch
/crates/egui/src/widgets/text_edit/builder.rs L1061.
if prediction != "\n" && prediction != "\r" && state.has_ime
this line ensure that i cannot input any CompositionEnd character unless input something to trigger CompositionStart to make has_ime as true.
tried to modify this line to
if prediction != "\n" && prediction != "\r"
if don't ensure has_ime be true, input CompositionEnd character directly successfully. Also, following some CompositionStart/CompositionUpdate character works too.

Can you check if window.set_ime_allowed is called at the correct time in crates/egui-winit/src/lib.rs?

Can you check if window.set_ime_allowed is called at the correct time in crates/egui-winit/src/lib.rs?

add log after L732 in crates/egui-winit/src/lib.rs
when mouse focus in textedit, window.set_ime_allowed is called, allow_time is true and self.allow_time is false.
when mouse focus outside textedit,
called again, allow_time is false and self.allow_time is true.

Ok, so that at least seems to work.
So as far as I understand you, you see CompositionEnd events with the correct characters (！ etc), and though the TextEdit has focus and set_ime_allowed(true), the characters don't show up in the TextEdit field?
It looks to me the use of state.has_ime in crates/egui/src/widgets/text_edit/builder.rs may be wrong.
Since you seem to know how IME should work (I don't 😅), could you please take a look, and perhaps make a PR if you figure out a fix? 🙏

Ok, so that at least seems to work.
So as far as I understand you, you see CompositionEnd events with the correct characters (！ etc), and though the TextEdit has focus and set_ime_allowed(true), the characters don't show up in the TextEdit field?
It looks to me the use of state.has_ime in crates/egui/src/widgets/text_edit/builder.rs may be wrong.
Since you seem to know how IME should work (I don't 😅), could you please take a look, and perhaps make a PR if you figure out a fix? 🙏

Thank you for your help. I'll make a PR later.😀

Here is a PR for this bugfix. https://github.com/emilk/egui/pull/3768


InfoBadge does not show in compact state when in NavigationView.PaneFooter without template

Describe the bug
Currently the InfoBadge does not show in compact states of NavigationView when it is defined in the PaneFooter. In the below images, the first "Downloads" item is defined in PaneFooter as a static element and the second one is a MenuItemsSource object with a DataTemplate in MenuItemTemplate.
If this is supposed to be managed myself, I'm not sure how to go about dynamically switching the badge states from expanded to collapsed upon changing NavigationView states.

Collapsed NavigationView

Expanded NavigationView

NavigationView items should be placed in either MenuItems/MenuItemsSource or FooterMenuItems/FooterMenuItemsSource. Items added to things like PaneFooter are not visible to the NavigationView and thus don't know about changing states.

Is it possible to create a "button" type template for a menu item that opens a flyout / browser url without actual navigation pages? I was thinking of creating a dummy view model type for the footer button and associated DataTemplate, but that would still cause navigation to the empty content

How are you triggering navigation? Are you binding to SelectedItem, using the selection changed or item invoked events?
If you're using selection based triggers, you can create a NavigationViewItem with SelectsOnInvoked set to false to prevent that item from selecting, then handle the ItemInvoked event on the NavigationView to do whatever you want. The EventArgs give you the item and some other information to know which item was invoked and you can handle it accordingly.
If you're already using ItemInvoked, again just scan for your specific item and do whatever you want.


Friendly name in configuration

Is your feature request related to a problem? Please describe.
Friendly name
Describe the feature you want
Instead of/in addition to watch ID, have a input for a friendly name in the config window popup
Additional context
No response

@hauard Hi, could you make me format suggestions?!

I'm not sure what you mean, but I have attached an image with the config-popup (watchID blurred), where I think it would be nice to have a friendly name for each watch, in addition to the watch ID.

Should the name be displayed instead of the ID or should an additional field be displayed for entries?

I suggest both, like this:


What's new / FRE page design bug fixes

Dev Home version
No response
Windows build number
No response
Other software
No response
Steps to reproduce the bug
Design feedback from recent meeting
Tighten padding at the top
Left-align single banner images (light and dark) to respond nicely across app widths
Center container
remove background container color -- should match the acrylic like the nav pane
Expected result
No response
Actual result
No response
Included System Information
No response
Included Extensions Information
No response

Fixed by #265


Creating UI for the project tab

I am looking for designs for the different projects to be listed in the projects tab on the website.

Assigned work -  completed.
Issue - Fixed


Fix docstrings (outdated interface names, other name errors)

Codecov Report

Merging #424 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   95.98%   96.07%   +0.08%
==========================================
  Files          34       34
  Lines       10707    10707
==========================================
+ Hits        10277    10286       +9
+ Misses        430      421       -9


(PUP-3771) Acceptance remove use of hosts array

This commit removes the use of the hosts array in tests where it
should not be assumed that all hosts should be tested. In most cases,
it is replaced by the agents array.

i'm good with this other than the help test removal.
we should really ensure puppet help help help help help works :egg:

Hey @er0ck I have restored the help test.

CLA signed by all contributors.


Unit test for tooltip on SVG element fails in Chrome+Safari under jQuery 3

Specifically, https://github.com/twbs/bootstrap/blob/1956146787d686f5771ae51f7b96f3a3ad62ce09/js/tests/unit/tooltip.js#L1042 fails.
Refs #16834.

It seems like jQuery 3 gives incorrect results for the .offset() of an SVG element:
http://jsbin.com/papobuk/1/edit?html,js,console,output

Looks like they're aware of this and deemed it WontFix 😢:
https://github.com/jquery/jquery/issues/3137

This should do a jQuery version check, as it now breaks tooltip placement for previous supported jQuery versions.

@drewskig Presumably you want #20381.

Whoops, that's correct (just went to the issue noted in the code).


Automatically downloads appropriate chromedriver version

It uses the package chromedriver-autoinstaller (https://pypi.org/project/chromedriver-autoinstaller/).

Thank you for your contribution! I also added updated readme and added you as a contributor  :raised_hands: :raised_hands:


New wrapper class

This PR implements the basic prediction functionality of a new OccCANINE wrapper class. A lot of polishing still needed. But it is timely to agree on the overall structure now.
Most important changes:

self.predict() is now itself just a wrapper of three specific other predict types: a) self._predict_flat(): Classical flat prediction b) self._predict_greedy(): Greedy prediction for seq2seq. c) self._predict_full(): Seq2seq probabilites for each of the 1919 potential HISCO codes.
Autodetection of model type based on features of loaded structure and numerous checks to ensure compatability between chosen prediction type, model type, and intended behavior
Entirely new Trie-based decoder for the full prediciton.

Checked new commits by @TorbenSDJohansen. Looks good.

Added suite of unit-tests (accidently not pushed in d4c0591), all of which pass -- but multiple of which pass due to "expected" NotImplementedError (with warnings raised). This is useful to keep track of any "outstanding" cases we may want to cover.
If you agree this appears to cover what we currently wants, I am ready to merge this into dev @christianvedels.

Great! With caveats noted above, I think this should be merged. If you agree, please go ahead.


[Feature Request] option to remap lighten/darken tool to two-button mouse

Suggest allowing L & R clicks to be mapped to separate functions (Lighten/darken) respectively. Could also apply to select tool (L to move select field, R to move selected contents) reducing required key combinations.

Hi, johnthehappyjohn,
There's a little problem with your suggestion. You specify that secondary clicks would move selected contents, but this can already be accomplished by using the 'Shift' key. The command/Ctrl key can be use similarly to darken with the lighten/darken tool.
Hope this helps!
Opie

On Oct 24, 2020, at 8:05 PM, johnthehappyjohn<EMAIL_ADDRESS>wrote:
Suggest allowing L & R clicks to be mapped to separate functions (Lighten/darken) respectively. Could also apply to select tool (L to move select field, R to move selected contents) reducing required key combinations.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/piskelapp/piskel/issues/972, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXQG3N6XKLTMTNIWNPGIYTSMNTT7ANCNFSM4S55YOZQ.

Many thanks!
I am aware; however, both right and left clicks do the same thing with those two functions. Seems odd to require a keyboard combination when there's a perfectly viable mouse button crying out for a secondary function (altfire!) as it is for the brush tool. I am unable to bind specific functions of tools to the mouse buttons; only to select the tool itself, and then, only to keyboard inputs.
Hope this clarifies.
JoHaJo

From: Sir Vyvre the Lone<EMAIL_ADDRESS>Sent: 25 October 2020 01:22
To: piskelapp/piskel<EMAIL_ADDRESS>Cc: johnthehappyjohn<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [piskelapp/piskel] [Feature Request] option to remap lighten/darken tool to two-button mouse (#972)
Hi, johnthehappyjohn,
There's a little problem with your suggestion. You specify that secondary clicks would move selected contents, but this can already be accomplished by using the 'Shift' key. The command/Ctrl key can be use similarly to darken with the lighten/darken tool.
Hope this helps!
Opie

On Oct 24, 2020, at 8:05 PM, johnthehappyjohn<EMAIL_ADDRESS>wrote:
Suggest allowing L & R clicks to be mapped to separate functions (Lighten/darken) respectively. Could also apply to select tool (L to move select field, R to move selected contents) reducing required key combinations.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/piskelapp/piskel/issues/972, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXQG3N6XKLTMTNIWNPGIYTSMNTT7ANCNFSM4S55YOZQ.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/piskelapp/piskel/issues/972#issuecomment-716072999, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARQCETM5HDQU76C4GUMAYHLSMNVTTANCNFSM4S55YOZQ.

You taught me a new power. Piskel surprises me every time I use it.
I had forgotten it could even do secondary clicks! I probably stopped doing that when I learned that I could just use the x shortcut key and focus on positioning of my clicks without worrying whether my use of two fingers might redirect the placement (I use Piskel on a MacBook Pro with a trackpad, and I don't use the 'control+click' method for secondary clicks).
That said, I think that the way it is mapped is strictly to color. I get what you mean about how that would be helpful in lightening and darkening; however, that's brightness, not hue, and the shift key does what you're requesting in that regard. Understand that as soon as there is more than one function for a primary action (such as clicking and secondary clicking), bugs will arise.
Also, as a trackpad user, I don't find it very easy to draw with two fingers on the trackpad at once… so just for the sake of universal design, I don't think mapping more functions to secondary clicks would be a step in the right direction.
There are alternatives, though, in the area of making selections:
There is a request for a 'select all pixels of the same color' expansion to the shape selection tool. Perhaps a key command could be used while making selections that will invert the selection? I'm not sure how practical that would be, but it might be worth exploring.
Anyway, here's the tl:dr…
clicking < typing
Most fluent users prefer to use the modifier keys (command/ctrl, alt/option, shift, etc.) to perform tasks than to click.
I recommend you request a non-click option. Thanks for your consideration of my feedback.

On Oct 25, 2020, at 11:46 AM, johnthehappyjohn<EMAIL_ADDRESS>wrote:
Many thanks!
I am aware; however, both right and left clicks do the same thing with those two functions. Seems odd to require a keyboard combination when there's a perfectly viable mouse button crying out for a secondary function (altfire!) as it is for the brush tool. I am unable to bind specific functions of tools to the mouse buttons; only to select the tool itself, and then, only to keyboard inputs.
Hope this clarifies.
JoHaJo

From: Sir Vyvre the Lone<EMAIL_ADDRESS>Sent: 25 October 2020 01:22
To: piskelapp/piskel<EMAIL_ADDRESS>Cc: johnthehappyjohn<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [piskelapp/piskel] [Feature Request] option to remap lighten/darken tool to two-button mouse (#972)
Hi, johnthehappyjohn,
There's a little problem with your suggestion. You specify that secondary clicks would move selected contents, but this can already be accomplished by using the 'Shift' key. The command/Ctrl key can be use similarly to darken with the lighten/darken tool.
Hope this helps!
Opie

On Oct 24, 2020, at 8:05 PM, johnthehappyjohn<EMAIL_ADDRESS>wrote:
Suggest allowing L & R clicks to be mapped to separate functions (Lighten/darken) respectively. Could also apply to select tool (L to move select field, R to move selected contents) reducing required key combinations.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/piskelapp/piskel/issues/972, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXQG3N6XKLTMTNIWNPGIYTSMNTT7ANCNFSM4S55YOZQ.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/piskelapp/piskel/issues/972#issuecomment-716072999, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARQCETM5HDQU76C4GUMAYHLSMNVTTANCNFSM4S55YOZQ.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/piskelapp/piskel/issues/972#issuecomment-716168499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXQG3NQGJO2LHX2VG6Y5ATSMRB4NANCNFSM4S55YOZQ.

Fair enough; this might become less necessary over time with familiarity. As you say, the modifier keys are already there and functional! An 'invert selection' modifier is an excellent shout though!! Perhaps it's just time to shell out for Aseprite...As I've no points in coding, I can't appreciate the inevitable bugs I'm probably implying. Thanks anyway!JoHaJoOn 25 Oct 2020 16:05, Sir Vyvre the Lone<EMAIL_ADDRESS>wrote:
You taught me a new power. Piskel surprises me every time I use it.
I had forgotten it could even do secondary clicks! I probably stopped doing that when I learned that I could just use the x shortcut key and focus on positioning of my clicks without worrying whether my use of two fingers might redirect the placement (I use Piskel on a MacBook Pro with a trackpad, and I don't use the 'control+click' method for secondary clicks).
That said, I think that the way it is mapped is strictly to color. I get what you mean about how that would be helpful in lightening and darkening; however, that's brightness, not hue, and the shift key does what you're requesting in that regard. Understand that as soon as there is more than one function for a primary action (such as clicking and secondary clicking), bugs will arise.
Also, as a trackpad user, I don't find it very easy to draw with two fingers on the trackpad at once… so just for the sake of universal design, I don't think mapping more functions to secondary clicks would be a step in the right direction.
There are alternatives, though, in the area of making selections:
There is a request for a 'select all pixels of the same color' expansion to the shape selection tool. Perhaps a key command could be used while making selections that will invert the selection? I'm not sure how practical that would be, but it might be worth exploring.
Anyway, here's the tl:dr…
clicking < typing
Most fluent users prefer to use the modifier keys (command/ctrl, alt/option, shift, etc.) to perform tasks than to click.
I recommend you request a non-click option. Thanks for your consideration of my feedback.

On Oct 25, 2020, at 11:46 AM, johnthehappyjohn<EMAIL_ADDRESS>wrote:

Many thanks!

I am aware; however, both right and left clicks do the same thing with those two functions. Seems odd to require a keyboard combination when there's a perfectly viable mouse button crying out for a secondary function (altfire!) as it is for the brush tool. I am unable to bind specific functions of tools to the mouse buttons; only to select the tool itself, and then, only to keyboard inputs.

Hope this clarifies.

JoHaJo

From: Sir Vyvre the Lone<EMAIL_ADDRESS>

Sent: 25 October 2020 01:22

To: piskelapp/piskel<EMAIL_ADDRESS>

Cc: johnthehappyjohn<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>

Subject: Re: [piskelapp/piskel] [Feature Request] option to remap lighten/darken tool to two-button mouse (#972)

Hi, johnthehappyjohn,

There's a little problem with your suggestion. You specify that secondary clicks would move selected contents, but this can already be accomplished by using the 'Shift' key. The command/Ctrl key can be use similarly to darken with the lighten/darken tool.

Hope this helps!

Opie

On Oct 24, 2020, at 8:05 PM, johnthehappyjohn<EMAIL_ADDRESS>wrote:

Suggest allowing L & R clicks to be mapped to separate functions (Lighten/darken) respectively. Could also apply to select tool (L to move select field, R to move selected contents) reducing required key combinations.

—

You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub https://github.com/piskelapp/piskel/issues/972, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXQG3N6XKLTMTNIWNPGIYTSMNTT7ANCNFSM4S55YOZQ.

—

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHubhttps://github.com/piskelapp/piskel/issues/972#issuecomment-716072999, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARQCETM5HDQU76C4GUMAYHLSMNVTTANCNFSM4S55YOZQ.

—

You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/piskelapp/piskel/issues/972#issuecomment-716168499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXQG3NQGJO2LHX2VG6Y5ATSMRB4NANCNFSM4S55YOZQ.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

I'll stick with Piskel, it's a solid software that works on Mac. I don't know what updates have come out lately, but I trust that some are in the works! Hope you come back soon!

On Oct 25, 2020, at 12:36 PM, johnthehappyjohn<EMAIL_ADDRESS>wrote:
Fair enough; this might become less necessary over time with familiarity. As you say, the modifier keys are already there and functional! An 'invert selection' modifier is an excellent shout though!! Perhaps it's just time to shell out for Aseprite...As I've no points in coding, I can't appreciate the inevitable bugs I'm probably implying. Thanks anyway!JoHaJoOn 25 Oct 2020 16:05, Sir Vyvre the Lone<EMAIL_ADDRESS>wrote:
You taught me a new power. Piskel surprises me every time I use it.
I had forgotten it could even do secondary clicks! I probably stopped doing that when I learned that I could just use the x shortcut key and focus on positioning of my clicks without worrying whether my use of two fingers might redirect the placement (I use Piskel on a MacBook Pro with a trackpad, and I don't use the 'control+click' method for secondary clicks).
That said, I think that the way it is mapped is strictly to color. I get what you mean about how that would be helpful in lightening and darkening; however, that's brightness, not hue, and the shift key does what you're requesting in that regard. Understand that as soon as there is more than one function for a primary action (such as clicking and secondary clicking), bugs will arise.
Also, as a trackpad user, I don't find it very easy to draw with two fingers on the trackpad at once… so just for the sake of universal design, I don't think mapping more functions to secondary clicks would be a step in the right direction.
There are alternatives, though, in the area of making selections:
There is a request for a 'select all pixels of the same color' expansion to the shape selection tool. Perhaps a key command could be used while making selections that will invert the selection? I'm not sure how practical that would be, but it might be worth exploring.
Anyway, here's the tl:dr…
clicking < typing
Most fluent users prefer to use the modifier keys (command/ctrl, alt/option, shift, etc.) to perform tasks than to click.
I recommend you request a non-click option. Thanks for your consideration of my feedback.

On Oct 25, 2020, at 11:46 AM, johnthehappyjohn<EMAIL_ADDRESS>wrote:
Many thanks!
I am aware; however, both right and left clicks do the same thing with those two functions. Seems odd to require a keyboard combination when there's a perfectly viable mouse button crying out for a secondary function (altfire!) as it is for the brush tool. I am unable to bind specific functions of tools to the mouse buttons; only to select the tool itself, and then, only to keyboard inputs.
Hope this clarifies.
JoHaJo

From: Sir Vyvre the Lone<EMAIL_ADDRESS>Sent: 25 October 2020 01:22
To: piskelapp/piskel<EMAIL_ADDRESS>Cc: johnthehappyjohn<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [piskelapp/piskel] [Feature Request] option to remap lighten/darken tool to two-button mouse (#972)
Hi, johnthehappyjohn,
There's a little problem with your suggestion. You specify that secondary clicks would move selected contents, but this can already be accomplished by using the 'Shift' key. The command/Ctrl key can be use similarly to darken with the lighten/darken tool.
Hope this helps!
Opie

On Oct 24, 2020, at 8:05 PM, johnthehappyjohn<EMAIL_ADDRESS>wrote:
Suggest allowing L & R clicks to be mapped to separate functions (Lighten/darken) respectively. Could also apply to select tool (L to move select field, R to move selected contents) reducing required key combinations.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/piskelapp/piskel/issues/972, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXQG3N6XKLTMTNIWNPGIYTSMNTT7ANCNFSM4S55YOZQ.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/piskelapp/piskel/issues/972#issuecomment-716072999, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARQCETM5HDQU76C4GUMAYHLSMNVTTANCNFSM4S55YOZQ.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/piskelapp/piskel/issues/972#issuecomment-716168499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXQG3NQGJO2LHX2VG6Y5ATSMRB4NANCNFSM4S55YOZQ.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/piskelapp/piskel/issues/972#issuecomment-716175320, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXQG3PGD2SKC6QSDMGUDMDSMRHXHANCNFSM4S55YOZQ.


Añadir variables al entorno de Proxy.

Some environment variables were added to the proxy conf file to allow listen to a given port and redirect traffic to the specific host and port were the Django application is running.

NGINX_PORT
BLUEXOLO_HOST
BLUEXOLO_PORT


Proposal: separate messages for custom enums

We have several instances of this pattern in the schema:
enum Preparation {
  COMPOUND_PREPARATION_UNKNOWN = 0;
  NONE = 1;
  REPURIFIED = 2;
  SPARGED = 3;
  DRIED = 4;
  SYNTHESIZED = 5;
}
Preparation preparation = 7;
// Custom preparation, used only when 'type' field is UNKNOWN.
string preparation_custom = 8;

Here's an alternative suggestion:
message Preparation {
  enum PreparationType {
    UNSPECIFIED = 0;
    NONE = 1;
    REPURIFIED = 2;
    SPARGED = 3;
    DRIED = 4;
    SYNTHESIZED = 5;
  }
  oneof kind {
    PreparationType type = 1;
    string custom = 2;
  }
}

This has a few advantages:

It is unambiguous when a custom type is used.
Groups everything related to the preparation together nicely.
Allows use of UNSPECIFIED in all enums so we can ditch all the prefixes.
The field names can be reused for consistency much like we do for the unit messages.

Thoughts?

Note that several messages already are close to this pattern. For instance, ReactionIdentifier is just like what I've shown above minus the oneof (which I think improves readability).

Some of these are tricky; I think it will be clearer if I send a PR along with this. Stay tuned.


issue_36_serviceCriteria Constrain explicitly on dockerServiceName the results from criteria-based /services request

Define ServiceFilter package, interface and hierarchy
Use ServiceFilter to constrain explicitly on dockerServiceName the results from criteria-based /services request
Reduce level of some log outputs from INFO to FINE

Commits are in to remedy the issues you raised.  PR build is underway.
For the service/spec null check I chose try/catch in order to retain fluency.

PR build is green.

Thanks!

@robinroos also see https://github.com/bitsofinfo/hazelcast-docker-swarm-discovery-spi/issues/39 one other item is needed on this please


[SPARK-35220][SQL] DayTimeIntervalType/YearMonthIntervalType show different between Hive SerDe and row format delimited

What changes were proposed in this pull request?
DayTimeIntervalType/YearMonthIntervalString show different between Hive SerDe and row format delimited.
Create this pr to add a test and  have disscuss.
For this problem I think we have two direction:

leave it as current and add a item t explain this  in migration guide docs.
Since we should not change hive serde's behavior, so we can cast spark row format delimited's behavior to use cast  DayTimeIntervalType/YearMonthIntervalType as HIVE_STYLE

Why are the changes needed?
Add UT
Does this PR introduce any user-facing change?
No
How was this patch tested?
added ut

Gentle ping  @cloud-fan @MaxGekk @maropu

Test build #137920 has started for PR 32335 at commit ab94c21.

Test build #137921 has started for PR 32335 at commit 9f1bd02.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42441/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42441/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42441/

Test build #137920 has finished for PR 32335 at commit ab94c21.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137920/

Test build #137921 has finished for PR 32335 at commit 9f1bd02.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137921/

Merged to master.

@HyukjinKwon Since you just merged this, I think I need to add a follow up one to add this behavior in migration guide? ok?

please go ahead.


initialized repo, added react code frame, did not initialize server f…

…iles

Also ran all package updates in repo, included all lock.json files. Json name descriptions can change later. Should initalize with heroku sooner than later. API keys need to be added in process.env (did not add).


propagate random walk in mgparms, catchability, and selectivity into forecast

Imported from redmine, Issue #12710
Opened by @RickMethot on 2016-04-19
Status when imported: Feedback

I believe this is resolved.


For getting all persistent volume claims

:) you need to update the script to actually have it. there's going to be a bazillion kg*pv* combinations. :)


docs(customizing_deis): clarify usage of registrationMode

Fixes #3653

Thanks @Joshua-Anderson! Looks like there's a formatting issue:
Warning, treated as error:
/var/lib/jenkins/jobs/test-ec2/workspace/src/github.com/deis/deis/docs/customizing_deis/controller_settings.rst:113: WARNING: Title underline too short.

@carmstrong Sorry about that, should be fixed now.

Muchas gracias, @Joshua-Anderson. Docs LGTM!

Code LGTM.


Unwrap option

Description
By default all results are returned as array. The unwrap option -u|--unwrap unwraps it from array and prints raw output to the terminal, separated by newlines

Closed as part of 63f7d75ebca4d85e537246480cf57e3da77f2f9c


make ComponentIterator a struct

Currently, the return of get components is a ComponentIterator{T} defined as
const ComponentIterator{T} = Base.Iterators.Flatten{Vector{Vector{T}}} where {T <: Component}

It will be good to make this as struct that includes a length field such as:
struct ComponentIterator{T <: Component}
    it::Base.Iterators.Flatten{Vector{Vector{T}}}
    length::Int64
end

such that a method
length(it::ComponentIterator) = it.length

can also be defined

is it possible to add this to #233? it will be very useful to be able to infer the size of the device arrays


docs: update the roadmap doc

Signed-off-by: Starnop<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Adjust the doc of ROADMAP to make it look more reasonable.
Ⅱ. Does this pull request fix one issue?

None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Just docs.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #837 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
- Coverage   39.64%   39.62%   -0.02%
==========================================
  Files         109      109
  Lines        6432     6432
==========================================
- Hits         2550     2549       -1
  Misses       3674     3674
- Partials      208      209       +1

Impacted Files
Coverage Δ

supernode/daemon/mgr/scheduler/manager.go
24.06% <0%> (-0.76%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6bdc2...3026c0d. Read the comment docs.

LGTM


CI: Run on pull requests

Run the CI also on pull requests, to be able to validate them before merging

Just merged some pretty significant refactors. If you go ahead and update this PR, I'd be happy to approve!

Done, rebased on the master branch

Do you need anything from my side before this can be merged?

Thank you for the contribution @EwoutH


TryGetAsciiString can be streamlined and vectorized

Should be more efficient and less messy

(Assigning to @halter73  who's already reviewing the PR)


Add back opendistro prefixed sweeper enabled field to alerting stats response

Signed-off-by: Mohammad Qureshi<EMAIL_ADDRESS>Issue #, if available:
Description of changes:
The opendistro prefixed field response for sweeper/scheduled jobs enabled in the Alerting Stats API was inadvertently changed to plugins during the migration to OpenSearch. This change reintroduces the legacy field back alongside the existing plugins one to maintain backwards compatibility and to not break behavior for anyone using the current field.
This PR also updates the existing tests asserting on the response of the stats API to use hardcoded values for the scheduled jobs enabled field instead of referring to the Setting.key so it can catch a change like this in the future. We should also see if any other tests are currently checking API responses this way. Fixing those, however, is out of scope for this particular PR.
CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #283 (0d15bf1) into main (f92dec0) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@            Coverage Diff            @@
##               main     #283   +/-   ##
=========================================
  Coverage     78.63%   78.64%
+ Complexity      218      217    -1
=========================================
  Files           173      173
  Lines          6968     6971    +3
  Branches        915      916    +1
=========================================
+ Hits           5479     5482    +3
+ Misses         1002     1001    -1
- Partials        487      488    +1

Impacted Files
Coverage Δ

...search/alerting/transport/SecureTransportAction.kt
39.02% <0.00%> (+8.25%)
:arrow_up:

...ing/core/action/node/ScheduledJobsStatsResponse.kt
65.38% <100.00%> (+1.38%)
:arrow_up:

...ing/destination/client/DestinationEmailClient.java
72.50% <0.00%> (-5.00%)
:arrow_down:

...ing/model/destination/DestinationContextFactory.kt
66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 813f836...0d15bf1. Read the comment docs.


Edge tpu PCIe on 32-bit armv7 ?

We are investigating if it would be possible to use the PCIe version of the Edge TPU on an armv7 system (32-bit arm).
We have already integrated your out-of-tree gasket driver into our v5.9 mainline Linux kernel. The gasket driver cannot be built, because it depends on ARM64:
 config STAGING_GASKET_FRAMEWORK
        tristate "Gasket framework"
        depends on PCI && (X86_64 || ARM64)

After removing the dependency, the driver still does not build, because it's using readq/writeq, functions which atomically read/write a quadword (64-bit) on the PCIe bus. These are not supported on 32-bit Linux.
Is there a fundamental reason why 32-bit is not supported? Would it be possible to add support by making modifications to the driver? For example. readq/writeq can be replaced by 2x readl/writel. Of course the operation is then no longer atomic.
Very grateful for any insights.

@TheSven73 we currently don't plan on supporting 32 OS for the pcie module. Although other have open issues similar to this. You can take a look at this one for more info:
https://github.com/google-coral/edgetpu/issues/280#issuecomment-760907539


Add Google Tag Manager

https://app.clubhouse.io/larder/story/2501/add-intercom-to-roadie-io

Gatsby instructions: https://www.gatsbyjs.com/plugins/gatsby-plugin-google-tagmanager/
As far as I can tell I'm supposed to leave the Google Analytics tracking plugin installed. 🤷♂


singularity workers

What's the point of using singularity, I thought mist is able to spawn workers by its own?
Is it to avoid multiple workers eating up worker container's resource limits?

@ishabalin Yes. if worker has ben killed, other workers will can work fine and this worker  just be restart in other place. It will increase isolation between Spark contexts. Each context will be start in own node, docker.
@mbhewitt That is the default behavior in JDK 7u4 and later releases. Also after worker will be completed  docker with Spark context will be killed and free all it resource.  GC clean up may be not so important in this case.


[TODO] support host name resolving for directive proxy_connect_address

The requirement comes from https://github.com/chobits/ngx_http_proxy_connect_module/issues/96.

TODO: proxy_connect_address directive: support dynamic domain resolving when handling CONNECT request.
TODO: proxy_connect_address directive: support static domain resolving when nginx starts.

TODO: proxy_connect_address directive: support dynamic domain resolving when handling CONNECT request.

fixed in https://github.com/chobits/ngx_http_proxy_connect_module/pull/103

TODO: proxy_connect_address directive: support static domain resolving when nginx starts.

We are not supporting this feature currently, which makes source not easy to maintain.
But I have supported dynamic domain resolving, and the following nginx.conf can works now.

<host name> can be used in proxy_connect_address directive.

    resolver <IP_ADDRESS>;

    server {
        listen       8090;

        proxy_connect ;
        proxy_connect_allow all;

        ### It will proxy request to github.com.
        ### upstream address of github.com will be resolved while request comes.
        proxy_connect_address github.com;

    }


Bug: commas understood as words, meaning you can't backtrack

At least that's what I think happened here:

I accidentally typed an Oxford comma after "actors" and realized, when the "space" was underlined to show an error (nice visual hint, by the way!). I tried to backtrack and deleted a letter, but it still showed the red underline. When I started typing, only some letters turned red, so my position is not clear to me any more. Not sure how to recover from this either. ;)

The way it works is by pressing space you submit a word. For the sake of simplified development, in most cases you can't change words you have submitted (kinda similar to monkeytype and 10fastfingers) I am still trying to come up with an implementation, where it is possible to change already submitted words.
Unfortunately, I wasn't able to fix the visual bug yet, i.e. red 'space' indicator remains even after pressing backspace. Maybe I did something wrong with the curses library

Ah, that makes more sense. Well then it's a non-critical bug. :)


Use custom element for chart

Use a custom element for the GDPR chart instead of encapsulating all of the chart's data in closures
New chart is functionally the same, but code is tidier

If this PR creates bugs that PR #65 fixes, wouldn't it be better to just get rid of this PR and merge the two together into one PR that works?

@gracetian6 I guess; I was just trying to split everything into small pieces. However, I also don't really consider this PR to introduce a bug, it's just not intended to be complete by itself.


emit cloud events to multiple url

Feature request
Tekton’s controllers emits cloud events when TaskRuns and PipelineRuns execute (https://tekton.dev/docs/pipelines/events/),
However, now, we can only specify one webhook api in configmap with default-cloud-events-sink field.
Can we change it to support sending cloud events to multiple webhook api, so the execution state change can notify multiple services?

Hello @LilyHolms, thank you for your feature request.
The way you can achieve this today is by using a message bus/router, like knative eventing.
You send all messages to a single bus and define subscription for each client that needs to receive the message. I appreciate that that may be a viable approach for everyone, but it may be a work around for now at least.
In terms of multiple targets, are you looking for a list of targets in the global config or a per PipelineRun target?

/reopen still outstanding

/lifecycle frozen


请问 第二个参数传了false，为什么还是会递归子目录呢，require.context('./', false, /.js$/)

When using the require.context method, the second parameter determines whether to recursively search subdirectories. If you pass false as the second parameter, it means that subdirectories will not be searched. However, this parameter only applies to files in the current directory. If there are subdirectories in the current directory with files that meet the criteria, the require.context method will still recursively search them, regardless of the value of the second parameter.
Therefore, if you want to limit the require.context method to only search files in the current directory, you can set the first parameter to the absolute path of the current directory, like require.context(__dirname, false, /\.js$/). This way, it will only search for js files in the current directory and will not recursively search subdirectories.

Thank you for your reply, but I used require.context(__dirname, false, /.js$/) and it still didn't work.

Please create issues in English with proper steps to reproduce.


Slider seems not working.

The slider seems not working. Please check the the below GIF

Browser:
Chrome ( Version 56.0.2924.87 (64-bit) ) on OSX 10.12.3

It's just not implemented

The slider was implemented when I deployed the app last. Confirmed latest isn't working. I'm going to investigate whether this is fixed in later versions of MDL.

Hi @addyosmani, I am interested to fix this issue.

Thanks, @shidhincr. Closed by your PR!

@addyosmani Thanks goes to @cheralathann 👍


TypeError: undefined is not an object (evaluating '_reactNative.Image.propTypes.source')

Hi I am facing the following error after installing react-native-vlc-media-player. My react native version is "react-native": "0.69.2".
App has not been started due to this error. The complete error message is :
ERROR  TypeError: undefined is not an object (evaluating '_reactNative.Image.propTypes.source')
ERROR  Invariant Violation: Module AppRegistry is not a registered callable module (calling runApplication). A frequent cause of the error is that the application entry file path is incorrect.
This can also happen when the JS bundle is corrupt or there is an early initialization error when loading React Native.
If I remove the following line then issue solved:
import { VLCPlayer } from 'react-native-vlc-media-player';
But I have to import VLCPlayer for playing .webm video in ios. I am working in IOS platform. Please help me to solve the issue.

I'm facing the same issue :(

What version of react-native-vlc-media-player do you use ?


Infer PADDLE_VERSION macro value from Git tag

I noticed the following code snippet in /CMakeLists.txt file:
# add PaddlePaddle version
if(DEFINED ENV{PADDLE_VERSION})
    add_definitions(-DPADDLE_VERSION=\"$ENV{PADDLE_VERSION}\")
else()
    if(EXISTS ${PROJ_ROOT}/.svn/)
        find_package(Subversion REQUIRED)
        if(SUBVERSION_FOUND)
            Subversion_WC_INFO(${PROJ_ROOT} Project)
            add_definitions(-DPADDLE_VERSION=${Project_WC_REVISION})
        endif()
    endif()
endif()

It seems that the source code was managed by SVN, but migrated to Git later.  So the idea of getting the PADDLE_VERSION macro value from .svn revision does no longer work.
I saw a workaround before above code snippet:
set(PADDLE_MAJOR_VERSION 0)
set(PADDLE_MINOR_VERSION 8)
set(PADDLE_PATCH_VERSION 0b)
set(PADDLE_VERSION ${PADDLE_MAJOR_VERSION}.${PADDLE_MINOR_VERSION}.${PADDLE_PATCH_VERSION})

To understand how the macro PADDLE_VERSION is used, I did:
$ for i in $(du -a | cut -f 2); do if [[ -f $i ]]; then if grep PADDLE_VERSION $i; then echo === $i ===; fi; fi; done
set(CPACK_PACKAGE_VERSION ${PADDLE_VERSION})
=== ./cmake/package.cmake ===
set(PADDLE_VERSION ${PADDLE_MAJOR_VERSION}.${PADDLE_MINOR_VERSION}.${PADDLE_PATCH_VERSION})
if(DEFINED ENV{PADDLE_VERSION})
    add_definitions(-DPADDLE_VERSION=\"$ENV{PADDLE_VERSION}\")
            add_definitions(-DPADDLE_VERSION=${Project_WC_REVISION})
=== ./CMakeLists.txt ===
        echo "PaddlePaddle @PADDLE_VERSION@, compiled with"
=== ./paddle/scripts/submit_local.sh.in ===
#ifndef PADDLE_VERSION
#define PADDLE_VERSION "unknown"
  os << "paddle version: " << PADDLE_VERSION << std::endl << std::boolalpha
=== ./paddle/utils/Version.cpp ===
      version='${PADDLE_VERSION}',
=== ./python/setup.py.in ===

It seems that PADDLE_VERSION is used some way, and it would be reasonable if we can infer its value from Git tags.
I confirm that we can find the tag we are on by running
git describe --tags --abbrev=0

Yes, PaddlePaddle source code was managed with svn previously. So, paddle version is actually svn version number. And, we have migrated to git a few days ago.
Your advice is really appreciated, we will add paddle version with git later.

Basically done


Fix readme.md fix

Add to changelog
add all features and examples to the readme.md

would I be able to work on this and get it assigned to me?


feat:

Prerequisites

[X] I have searched for existing issues that already include this feature request, without success.

Describe the Feature Request
is there gonna be an autobuyer for fifa 23 and if so how soon
Describe the Use Case
hello i really appreciate the job you guys do for the fifa  community just wanted to ask for any update on the autobuyer for fifa 23
Describe Preferred Solution
No response
Describe Alternatives
No response
Additional Information
No response

https://github.com/ckalgos/FUT-Auto-Buyer/releases/tag/1.2.5 - This release has FIFA 23 support


[113 Proposal] Separate benchmarking, integration, and unit tests using file extensions

This is a proposal for #113 applied to the language-js package.

In this proposal, files in __tests__ directories should have one of several extensions that determines its test type/strategy, for now:

.bench.ts: For benchmark tests.
.intg.ts: For integration tests.
.unit.ts: For unit tests.

In the future, new extensions can be added for other test strategies (e.g. .fuzz.ts for fuzz testing or .prop.ts for property testing).
The test runner and test configuration file have been updated to provide backwards compatibility for running tests on packages that have not yet been updated in accordance with this proposal. I.e. where the .test.ts extension is still used.

Closing this in favor of #158


Playback failed  ,No links were found

Hii @elgatito
Firstly i would like to express my gratitude to you for  open sourcing your work and even if you have mentioned that the development has stopped and dont expect fast support you still go out of your regular call of duty to help resolve issues,so thanks a lot ! it really helps a lot of us .  i have been using elementum for quite few years now and it worked fine .yesterday i updated my kodi version from( 20.2 )to (20.3 )and burst cannot find links from the TV shows etc links and  ,however when i copy magnet link in elementum and paste  it works .i am using the latest version of elementum . no chnages have been made on my end the proxy setting have been same throughout ,looking forward for your help ..
Thanks in Advance ..

when you created issue there was the template, that template has the link to the guide about how to create a log file.
it is impossible to understand your issue without log file.

@ajay01994 if you will open that log you will see hundreds of
Caused by ProxyError('Cannot connect to proxy.', RemoteDisconnected('Remote end closed connection without response'))
so looks like your proxy is dead (or you computer can't reach your proxy for some reason). i also can not connect to proxy IP that i see in log.
it is not a script.elementum.burst addon issue, but network issue on your side.

Thanks for taking out your valuable time to look at the logs and letting me know about the possible issue . Could you help me in giving some guidelines over settings up proxy in elementum or solutions around it ?
Thanks in advance

I do not understand what you mean. Either disable proxy if you do not need it (e.g. your ISP do not block torrent sites) or use a new proxy. As I said - the proxy you currently use is dead (as i can see).

@ajay01994

This is not the correct place for issues related to search addons. For Burst related issues use Burst repository - https://github.com/elgatito/script.elementum.burst/issues
There are connectivity issues for at least one provider, and it was causing you to wait for timeout to happen.
Check your Burst settings whether any proxy is used, because your log has many errors saying it cannot connect to a proxy. Also you can try to disable Elementum as a proxy in Burst settings.
Use latest Burst 0.0.83 version, that should ignore failed providers and cause a timeout.

Hi guys ..
After updating burst 2 providers are coming now ..which is better however a lot of them are still not coming there is no change in proxy settings as it remains the same I am using libreelec .moving the conversation to burst issue


Remove UI references from Model namespaces

I was thinking of adding an interface "IUserInterface" which could be passed to model code which does things, and which potentially needs to display information to users, and ask them questions.
Then, there is the "TextUserInterface" implementation which just writes messages to an output stream, and if a user gets asked a question, it assumes that the user gave the default response.
And there is "GraphicalUserInterface" implemented in Skyline which displays message boxes using AlertDlg, etc.
I am not sure whether this is a good approach in terms of removing UI code from SkylineDataSchema and SkylineViewContext.

This seems like its headed in the right direction. I wonder if we could minimize code changes by requesting an interface from the document container at point of use, rather than passing it in?

Typically, I prefer polymorphism where the model simply supplies a message
it wants to show the user, and the interface decides how to show it. Often
we achieve this by throwing an exception out of the model and letting the
caller decide how to show the message in the exception. Also, we should
never be using MessageBox because our test framework can't handle it. Any
use of MessageBox implies error handling code that is never tested.
On Wed, Aug 17, 2022 at 11:27 AM nickshulman @.***>
wrote:

I was thinking of adding an interface "IUserInterface" which could be
passed to model code which does things, and which potentially needs to
display information to users, and ask them questions.
Then, there is the "TextUserInterface" implementation which just writes
messages to an output stream, and if a user gets asked a question, it
assumes that the user gave the default response.
And there is "GraphicalUserInterface" implemented in Skyline which
displays message boxes using AlertDlg, etc.
I am not sure whether this is a good approach in terms of removing UI code
from SkylineDataSchema and SkylineViewContext.
You can view, comment on, or merge this pull request online at:
https://github.com/ProteoWizard/pwiz/pull/2214
Commit Summary

5cc64dc
https://github.com/ProteoWizard/pwiz/pull/2214/commits/5cc64dcfb992455afdc4d8b0e6a979296fd4dd45
Add interface IUserInterface which can be passed to things which controls
whether message boxes should be displayed or just written to an output
stream.

File Changes
(45 files https://github.com/ProteoWizard/pwiz/pull/2214/files)

M pwiz_tools/Shared/Common/CommonUtil.csproj
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-ccafcdbe6476e8d0054086f704a90187fadb5bd8143af51783c7214ae9348e24
(4)
M pwiz_tools/Shared/Common/DataBinding/AbstractViewContext.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-5a62868f4b0b46ac71936f2fd48f97042c5fec0487a53d080efd4b114adea0ba
(40)
M
pwiz_tools/Shared/Common/DataBinding/Controls/Editor/ChooseViewsControl.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-be3d478cf2538018451a6665ea42afed63eff1012a08e429fc904383792fe746
(4)
M
pwiz_tools/Shared/Common/DataBinding/Controls/Editor/ManageViewsForm.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-c2a8cb1affdabb513dd02243ba243575f89d471d4da5eb335e9a0937d0c1cf0e
(2)
M
pwiz_tools/Shared/Common/DataBinding/Controls/Editor/ViewEditor.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-9ceb623e04da86f3a32835cb007e0070de8290728a7cf45eb56e5e351482e498
(2)
M pwiz_tools/Shared/Common/DataBinding/Controls/NameLayoutForm.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-545e40a3457e93b76fac91e4ac5df5b2caa82c3fe69e5cc906173ebe77868434
(4)
M pwiz_tools/Shared/Common/DataBinding/Controls/PivotEditor.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-6870ba505694df6e0c3fb8d35a8c5fafb74bf72b74385f752fc76ed7e0b5f2bb
(2)
M pwiz_tools/Shared/Common/DataBinding/Controls/QuickFilterForm.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-8b9bac7d6925a8ca9ef20e4aca8ccd0b5b0bac311b1e4415271e62a068555486
(2)
M pwiz_tools/Shared/Common/DataBinding/IViewContext.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-8828c59a791ffb89c8db3dff21145095be2d8501ab09efa6337f5aeb578e161e
(4)
A
pwiz_tools/Shared/Common/UserInterfaces/AbstractGraphicalUserInterface.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-301dca8c82b5148a872facf8d689c2c115e11d48bd7b54194003e33e21e3c312
(25)
A pwiz_tools/Shared/Common/UserInterfaces/AbstractUserInterface.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-a23cfb25a579c6e278f9fad3990d805963bb75aea6f9c3b29bbb4fb6d01a27c9
(23)
A pwiz_tools/Shared/Common/UserInterfaces/IUserInterface.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-98bfe9c9afedd126cef8ca239ee3745d88db0fa788da16fd7d0d21e41eb60f11
(24)
A pwiz_tools/Shared/Common/UserInterfaces/TextUserInterface.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-76acd6597db35fdab6c5bede7c884982c6037022c8f9ec251e610337e641020e
(48)
A pwiz_tools/Skyline/Alerts/GraphicalUserInterface.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-a3b59f7781d7d9db6862a8eddfe360111510e1ca180b246889b1fa8238f60bf2
(48)
M pwiz_tools/Skyline/CommandLine.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-25d8f475c2a1cb8078884e11f0677fcb80782b6a2684a877955a265befc8f2df
(3)
M
pwiz_tools/Skyline/CommonTest/DataBinding/SampleData/TestViewContext.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-ac382b425d14e58afe7af3edb57f36b5f04721183f3713d99a7063335143efae
(16)
M pwiz_tools/Skyline/Controls/AuditLog/AuditLogForm.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-ce4a712ff8afeb53dcc04c1f644470e0d3bd096f05704804c89575efe539566d
(2)
M pwiz_tools/Skyline/Controls/Databinding/CandidatePeakForm.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-8049b7669322f13357d2fd98f29f736e028bc5663ba2d94572913dd79fd953dc
(3)
M pwiz_tools/Skyline/Controls/Databinding/DocumentGridForm.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-7b8c67cd16e99d27f91d3e41292398f02d7011138608950cfbe3adba85496894
(3)
M pwiz_tools/Skyline/Controls/Databinding/ExportLiveReportDlg.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-3fb5ad10d7def6e60bf9472131df1553cb93d5f7caaacf5c272b254d33ab85c7
(5)
M pwiz_tools/Skyline/Controls/Databinding/LiveResultsGrid.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-48cdcc5a22971e7c50d51b9ec1e137ceec98b3d071646f182fc443a719cb3f9d
(3)
M
pwiz_tools/Skyline/Controls/GroupComparison/FoldChangeBindingSource.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-ea9d781d7e6c62401f381e70ac325f965707cdb9e268eb85beedfd9679c0bb30
(3)
M
pwiz_tools/Skyline/Controls/GroupComparison/GroupComparisonViewContext.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-e6f27934d5cdbee74012c54544d371f37b68838254e1845a2346473a941855ba
(5)
M pwiz_tools/Skyline/Controls/Lists/ListGridForm.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-6247de2b4acbfd718052dc3b86e20bebd428667b757a06009e351248a844d044
(3)
M pwiz_tools/Skyline/Model/Databinding/DocumentGridViewContext.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-47d2818d3cafe1e691e4365cded9463ae1013a5456554b49a70703882c241ff0
(9)
M pwiz_tools/Skyline/Model/Databinding/ReportSharing.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-beb9c436fc93f3f2fae6b3cb72bd22d8fd40aa6e27688e73fb88a73f1ae4a60d
(5)
M pwiz_tools/Skyline/Model/Databinding/ResultsGridViewContext.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-d798824cb69bc190b7db2b9bb8c0fb29259b1f60ee87ea8a03fda0619a1c49e6
(3)
M pwiz_tools/Skyline/Model/Databinding/SkylineViewContext.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-cb7b71aa06d675f7e0b88f7464a5d003c64d756b5e67b280b7202c0852a502ab
(37)
M pwiz_tools/Skyline/Model/Lists/ListViewContext.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-28e7c5e5a197a7cc27d50b9570053f82f0a030f9102f8299e323c25d02c97106
(9)
M pwiz_tools/Skyline/Model/ToolService.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-02525a0051d3a7a68341dcbe5ea9b663565986eb10aab56b36cabd20d7d4d6f2
(3)
M pwiz_tools/Skyline/Model/Tools/ToolDescription.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-ca35115a8c9ba587206951c19983c027f7cd560bfa8c526977c50f83b87caf10
(3)
M pwiz_tools/Skyline/SettingsUI/DocumentSettingsDlg.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-5d4e883d6dc911a976830e233efab70f6132455e58e9ac69045082c0531b7d97
(6)
M pwiz_tools/Skyline/SettingsUI/MetadataRuleEditor.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-2ebe9696b6eefd25aa13e2ecf0c0f7d7d852490baae6e4a45a0a423ecd793a96
(3)
M pwiz_tools/Skyline/SettingsUI/MetadataRuleSetEditor.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-d3d6d03db977fdf08311ab7a6ad17b3f3a6ad6dea5e5153ffc9518fcf0f39b8b
(5)
M pwiz_tools/Skyline/Skyline.csproj
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-4e4e9fde5a3ebbc47996a0c534185b17c5752af478304a9cf5ae3ec0fbe49015
(1)
M
pwiz_tools/Skyline/Test/MSstats/Normalization/MsStatsNormalizationTest.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-c768cde13a1cf5610255b0a236443343d4ceaa941387da22dcb7f6aed4566373
(3)
M pwiz_tools/Skyline/Test/PeakBoundaryTest.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-4053cf2384b1d260448df5120162f683192a461124fe3395fd0a1d05e80b2756
(3)
M pwiz_tools/Skyline/Test/Reporting/DsvWriterTest.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-2209631618e87176b48dd1ae41994a377739431a34fa17550013fac2a0a77dde
(5)
M pwiz_tools/Skyline/Test/Reporting/LiveReportPivotTest.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-a05372f66f68d06205882926916c9054be0ae0e62aa91af65bc1a09a164b76de
(3)
M pwiz_tools/Skyline/TestData/CommandLineTest.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-134b5c6e9b0a6eca09f577bdb94fd34effe41b75604573cc225b1036d645f148
(3)
M pwiz_tools/Skyline/TestUtil/CheckReportCompatibility.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-e451f33da90df916cf79808b225a4945507184e325be9344e5f7192e40670eda
(3)
M pwiz_tools/Skyline/ToolsUI/ConfigureToolsDlg.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-9a68a8ae1d81c370408060101ab053a8161f9b759095d42a209e85faeb16d227
(2)
M
pwiz_tools/Topograph/TopographApp/DataBinding/TopographViewContext.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-07e9b3832732bad54440a3becc407dc626fe6f195ceee79ea7ef653731e1f374
(42)
M pwiz_tools/Topograph/TopographApp/TopographApp.csproj
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-7dde15b60a3ac05159585f465a255de478c734851a22d39dfd4a622846495faf
(1)
A pwiz_tools/Topograph/TopographApp/TopographUserInterface.cs
https://github.com/ProteoWizard/pwiz/pull/2214/files#diff-09dbe4c83ce427b3ace49f7cc65766d5538897057fa3b369c6da402d6db7e6e8
(61)

Patch Links:

https://github.com/ProteoWizard/pwiz/pull/2214.patch
https://github.com/ProteoWizard/pwiz/pull/2214.diff

—
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/2214, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUAXIWPVZMAJC3JUJ2TVZUVHRANCNFSM562QF5TA
.
You are receiving this because your review was requested.Message ID:
@.***>

Any use of MessageBox implies error handling code that is never tested.

We do have a code inspection test for that, FWIW

I think you may have forgotten to add something to git:
Z:\pwiz\pwiz_tools\Skyline\Alerts\GraphicalUserInterface.cs(10,43): error CS0246: The type or namespace name 'AbstractGui' could not be found (are you missing a using directive or an assembly reference?) [Z:\pwiz\pwiz_tools\Skyline\Skyline.csproj]

Replaced by PR#2344


Undo/Redo UI buttons in vertical playground is broken.

Expected Behavior
Undo and Redo buttons in the vertical playground should work exactly as the context menu.
Actual Behavior
When undo and redo buttons are clicked repetitively in the vertical playground, the blocks in the workspace are incorrectly restored.
Steps to Reproduce

place a repeat block in the workspace.
place another block inside the repeat block as shown in the first attachment.
detach the inner block of the repeat block.
press undo (in the left side menu) and notice the block goes back inside the repeat block. (correct behavior)
press redo (in the left side menu) and notice the block now goes to a different location then it was before (incorrect behavior)
now press undo again (in the left side menu) and notice the inner block now is in a broken state.

NOTE: the Undo and Redo works as expected when using the context menu.
Operating System and Browser
_e.g. Mac OS 10.11.6 chrome 55.0.2883.95

@rachel-fenichel @picklesrus This is a little odd. Any thoughts?

Nothing comes to mind.

Yeah, this is weird. The behavior using the right-click menu on the workspace to undo/redo (instead of the buttons on the playground page) seems correct though.

I have found that if the the right click context menu is used first to perform undo/redo task, then use the undo/redo buttons, then the behavior is correct. The bug only occurs if the context menu is not used at all.

We are also running into this.

Not sure if this is the same problem, but it seems similar enough so I'm commenting it here instead of opening a new issue. If I should open an issue, tell me.
Steps to Reproduce
In the vertical playground:
Not sure if I found a new

Make this:

Move the abs of list block out of the move x steps
Move it back in
Undo
Move the  abs of list block anywhere

Expected Behavior
When following the steps to reproduce, the undo should work as expected and not disconnect the abs of list block.
Actual Behavior

Interestingly, moving around the abs of      will also move the relative position of the list.
Operating System and Browser
Firefox 57.0.1 and Chrome 63.0.3239.108 Linux


Error playing video -  Trying to create a platform view of unregistered type: tv.mta/NativeVideoPlayer - 2.0.2-rc1

[ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: PlatformException(error, java.lang.IllegalStateException: Trying to create a platform view of unregistered type: tv.mta/NativeVideoPlayer
E/flutter (10424): 	at io.flutter.plugin.platform.PlatformViewsController$1.createVirtualDisplayForPlatformView(PlatformViewsController.java:199)
E/flutter (10424): 	at io.flutter.embedding.engine.systemchannels.PlatformViewsChannel$1.create(PlatformViewsChannel.java:107)
E/flutter (10424): 	at io.flutter.embedding.engine.systemchannels.PlatformViewsChannel$1.onMethodCall(PlatformViewsChannel.java:59)
E/flutter (10424): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:262)
E/flutter (10424): 	at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:296)
E/flutter (10424): 	at io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$DartMessenger(DartMessenger.java:320)
E/flutter (10424): 	at io.flutter.embedding.engine.dart.-$$Lambda$DartMessenger$TsixYUB5E6FpKhMtCSQVHKE89gQ.run(Unknown Source:12)
E/flutter (10424): 	at android.os.Handler.handleCallback(Handler.java:938)
E/flutter (10424): 	at android.os.Handler.dispatchMessage(Handler.java:99)
E/flutter (10424): 	at android.os.Looper.loopOnce(Looper.java:201)
E/flutter (10424): 	at android.os.Looper.loop(Looper.java:288)
E/flutter (10424): 	at android.app.ActivityThread.main(ActivityThread.java:7842)
E/flutter (10424): 	at java.lang.reflect.Method.invoke(Native Method)
E/flutter (10424): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
E/flutter (10424): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
E/flutter (10424): , null, null)
E/flutter (10424): #0      StandardMethodCodec.decodeEnvelope
package:flutter/…/services/message_codecs.dart:607
E/flutter (10424): #1      MethodChannel._invokeMethod
package:flutter/…/services/platform_channel.dart:177
E/flutter (10424):
E/flutter (10424): #2      TextureAndroidViewController._sendCreateMessage
package:flutter/…/services/platform_views.dart:1061
E/flutter (10424):
E/flutter (10424): #3      AndroidViewController.create
package:flutter/…/services/platform_views.dart:771
E/flutter (10424):
E/flutter (10424): #4      RenderAndroidView._sizePlatformView
package:flutter/…/rendering/platform_view.dart:191
E/flutter (10424):
E/flutter (10424):

Hello Lucas, so it seems the plugin need to be registered in your app's MainActivity class. Please see below how to do this.
Java
public class MainActivity extends FlutterActivity {

    @Override
    public void configureFlutterEngine(@NonNull FlutterEngine flutterEngine) {
        GeneratedPluginRegistrant.registerWith(flutterEngine);

        /* video player */
        tv.mta.flutter_playout.video.PlayerViewFactory.registerWith(
                flutterEngine.getPlatformViewsController().getRegistry(),
                flutterEngine.getDartExecutor().getBinaryMessenger(),
                this);

        /* audio player */
        tv.mta.flutter_playout.audio.AudioPlayer.registerWith(
                flutterEngine.getDartExecutor().getBinaryMessenger(),
                this,
                this.getContext());
    }
}

Kotlin
class MainActivity: FlutterActivity() {
    override fun configureFlutterEngine(flutterEngine: FlutterEngine) {
        tv.mta.flutter_playout.video.PlayerViewFactory.registerWith(
                flutterEngine.platformViewsController.registry,
                flutterEngine.dartExecutor.binaryMessenger,
                this)

        tv.mta.flutter_playout.audio.AudioPlayer.registerWith(
                flutterEngine.dartExecutor.binaryMessenger,
                this, context)
    }
}

thanks, good work

error: cannot find symbol
public void configureFlutterEngine(@NonNull FlutterEngine flutterEngine

This is causing error in  await Firebase.initializeApp();

same error


expect: Symlink libexpect5.45.dylib to lib/

libexpect5.45.dylib is installed in lib/expect5.45/libexpect5.45.dylib and not symlinked into lib, which causes trouble for Linuxbrew as per Homebrew/linuxbrew#306.
It seems common to install this library in lib/
Debian
Fedora
Linux From Scratch

Thanks, Jack.


Snap zoom in

[ ] Set up viewports at three scales: statewide, city and district. (Double clicking on statewide map zooms in to the citywide scale)
[x] Add zoom bar

@nupoormonani I could use a little more guidance on how this will work. This is a slippy map interface, so users are able to pan and zoom anywhere. I've added a zoom bar, but I'm not sure how the first bullet point will work. By default, double-click adjusts the zoom level by one. So, it sounds like we could override that default where double-clicking adjusts the zoom level by five, but it could put users in a random part of the map.
I think having the cities on the left zoom to their respective district bounding boxes when clicking (instead of just centering) would accomplish what we need for this issue. Thoughts? Feel free to sketch some things out here if you need: https://wireframe.cc.

@allthesignals I think icon clustering solves this issue - at the state-wide zoom, a user would intuitively click on the cluster marker, which snaps to the district-scale.


init: Fix crash when mode isn't explicitly specified

I just feel better about making the caller specify it explicitly.  Seems like returning an error is better on an empty string.

Anyway feel free to close this PR when you submit a fix as you wish.

Closed via b6f2053f.


Revert "Work around for jenkins_plugin module bug"

This reverts commit 0ab15b94b53b19ea3b3e115af45b36da1b2ce458.
Closes https://trello.com/c/Ne3rA9In/
Applying
This will need to be applied by running make jenkins TAGS=jenkins and restarting the Jenkins EC2 instance.
Testing
We can then test it worked by running make jenkins TAGS=plugins and making sure we get no errors from the jenkins_plugin steps.

How are we going to test that everything now works ok without the workaround?

How are we going to test that everything now works ok without the workaround?

I've updated the PR description with this info

I've applied this to Jenkins successfully, and when running make jenkins TAGS=plugins I don't get the No valid crumb error we were seeing before, but I do get a different error 😥
PLAY [Setup Jenkins CI, config and dependencies] ***************************************************************************************************

TASK [Gathering Facts] *****************************************************************************************************************************
ok: [ci.marketplace.team]

TASK [jenkins : Check if Github OAuth is set up yet so we can use the correct credentials] *********************************************************
ok: [ci.marketplace.team]

TASK [jenkins : Set credentials to jenkins github user if it exists] *******************************************************************************
ok: [ci.marketplace.team]

TASK [jenkins : Set credentials to admin user if jenkins github user does not exist] ***************************************************************
skipping: [ci.marketplace.team]

TASK [jenkins : Install plugins] *******************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: FileNotFoundError: [Errno 2] No such file or directory: b'/tmp/tmpki7g9i1r' -> b'/var/lib/jenkins/plugins/ansicolor.jpi'
failed: [ci.marketplace.team] (item=ansicolor) => {"ansible_loop_var": "item", "changed": false, "item": "ansicolor", "msg": "Could not replace file: /tmp/tmpki7g9i1r to /var/lib/jenkins/plugins/ansicolor.jpi: [Errno 2] No such file or directory: b'/tmp/tmpki7g9i1r' -> b'/var/lib/jenkins/plugins/ansicolor.jpi'"}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: FileNotFoundError: [Errno 2] No such file or directory: b'/tmp/tmprcuem2x5' -> b'/var/lib/jenkins/plugins/audit-trail.jpi'
failed: [ci.marketplace.team] (item=audit-trail) => {"ansible_loop_var": "item", "changed": false, "item": "audit-trail", "msg": "Could not replace file: /tmp/tmprcuem2x5 to /var/lib/jenkins/plugins/audit-trail.jpi: [Errno 2] No such file or directory: b'/tmp/tmprcuem2x5' -> b'/var/lib/jenkins/plugins/audit-trail.jpi'"

I've applied this to Jenkins successfully, and when running make jenkins TAGS=plugins I don't get the No valid crumb error we were seeing before, but I do get a different error 😥

I get the same error  with or without this PR applied to Jenkins 🤔

I've applied this to Jenkins successfully, and when running make jenkins TAGS=plugins I don't get the No valid crumb error we were seeing before, but I do get a different error 😥

I get the same error with or without this PR applied to Jenkins 🤔

I think the problem is that the jenkins_plugin Ansible module is trying to copy plugins to the Jenkins home directory /var/lib/jenkins (and expecting a folder plugins there) when in fact it should be copying to the Jenkins installation directory /data/jenkins.
It's not clear to me why it would have worked before though...

It's not clear to me why it would have worked before though...

Looking at the creation date of the current Jenkins EC2 instance (2019/07/11) and the last commit date of the plugins job (2019/07/12) it's possible we (I) didn't fully test it 😬 😅 😂

Adding jenkins_home: "{{ jenkins_data_dir }}" to the jenkins_plugin step works without this PR applied.

I've added the fix for jenkins_plugin to this PR, pushed it to Jenkins and tested it without issues.
Going to merge this PR now.


Add neo_f3kdb mode=5 support

neo_f3kdb has recently added mode=5. This is current unsupported and returns the following error:
2022-12-20 08:54:52.091: root: ERROR: Traceback (most recent call last):
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\site-packages\vsengine\vpy.py", line 219, in _execute
    runpy.run_path(str(script), module.__dict__, module.__name__)
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 269, in run_path
    return _run_module_code(code, init_globals, run_name,
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 96, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\site-packages\vspreview\core\vsenv.py", line 19, in _monkey_runpy_func
    glob_dict = orig_runpy_run_code(*args, **kwargs)
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "E:\Anime\Fansubbing\Git Repositories\Encoding Projects\[Kaleido-subs]\Work in Progress\!On-hold\-snip-[BD]_hidden\-snip-_NCOP1.py", line 207, in <module>
    FILTERED = filterchain(PREFILTER)
  File "E:\Anime\Fansubbing\Git Repositories\Encoding Projects\[Kaleido-subs]\Work in Progress\!On-hold\-snip-[BD]_hidden\-snip-_NCOP1.py", line 144, in filterchain
    deband_wk = F3kdb.deband(csharp, radius=24, thr=[40, 32], blur_first=True, sample_mode=5)
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\site-packages\vstools\types\utils.py", line 110, in _wrapper
    return self.function(obj, *args, **kwargs)
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\site-packages\vsdeband\f3kdb.py", line 170, in deband
    step = sample_mode.step
AttributeError: 'int' object has no attribute 'step'

As this is a neo_f3kdb-only mode, an additional check must also be added to ensure regular f3kdb users can't trigger it without error. Furthermore, it seems neo has updated some things regarding the thresholds which may need additional looking at as well.

in addition to this, the new f3kdb build scales differently which vsdeband needs to account for,


do not always install latest version of Chocolatey when using the WebLauncher

fixes GH-537

closed b/c I've based to hotfix branch on develop rather than master

Just to let you know... there was no need to create a new PR here, it is possible rebase and re-target the PR to a different branch.


Animations are not show after call a setDiv().

I'm submitting a ...  (check one with "x")

[ ] question
[X] any problem or bug report

OS:  (check one with "x")

[x] Android
[X] iOS
[ ] Browser

cordova information:  (run $> cordova plugin list)
cordova-android-firebase-gradle-release 3.0.0 "cordova-android-firebase-gradle-release"
cordova-android-play-services-gradle-release 3.0.0 "cordova-android-play-services-gradle-release"
cordova-android-support-gradle-release 3.0.1 "cordova-android-support-gradle-release"
cordova-open-native-settings 1.5.2 "Native settings"
cordova-plugin-actionsheet 2.3.3 "ActionSheet"
cordova-plugin-advanced-http 2.1.1 "Advanced HTTP plugin"
cordova-plugin-camera 4.0.3 "Camera"
cordova-plugin-core-android-extensions 2.0.0 "CoreAndroidExtensions"
cordova-plugin-device 2.0.3 "Device"
cordova-plugin-dialogs 2.0.2 "Notification"
cordova-plugin-emma-sdk 1.0.1 "EMMA"
cordova-plugin-file 6.0.1 "File"
cordova-plugin-file-transfer 1.7.1 "File Transfer"
cordova-plugin-filepath 1.5.5 "cordova-plugin-filepath"
cordova-plugin-geolocation 4.0.1 "Geolocation"
cordova-plugin-googlemaps 2.6.2 "cordova-plugin-googlemaps"
cordova-plugin-headercolor 1.0 "HeaderColor"
cordova-plugin-inappbrowser 3.0.0 "InAppBrowser"
cordova-plugin-ionic-webview 1.1.16 "cordova-plugin-ionic-webview"
cordova-plugin-localization-strings 3.1.0 "Localization"
cordova-plugin-nativeaudio 3.0.9 "Cordova Native Audio"
cordova-plugin-network-information 2.0.3-dev "Network Information"
cordova-plugin-screen-orientation 3.0.2 "Screen Orientation"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-statusbar 2.4.3 "StatusBar"
cordova-plugin-transparent-status-bar 1.0.1 "Transparent status bar"
cordova-plugin-whitelist 1.3.4 "Whitelist"
cordova-support-android-plugin 1.0.1 "cordova-support-android-plugin"
cordova-support-google-services 1.1.0 "cordova-support-google-services"
cordova.plugins.diagnostic 5.0.0 "Diagnostic"
es6-promise-plugin 4.2.2 "Promise"
ionic-plugin-deeplinks 1.0.20 "Ionic Deeplink Plugin"
ionic-plugin-keyboard 2.2.1 "Keyboard"
phonegap-plugin-mobile-accessibility 1.0.5-dev "Mobile Accessibility"
phonegap-plugin-multidex 1.0.0 "Multidex"
phonegap-plugin-push 2.2.3 "PushPlugin"

If you use @ionic-native/google-maps, please tell the package.json (only @ionic-native/core and @ionic-native/google-maps are fine mostly)
@ionic-native/core : 4.4.0
@ionic-native/google-maps : 4.4.2

Current behavior:
As it's explained on docs we call setDiv() to get out of the page, for detaching map, in this way when you come back to the page you can reattach it again.
From a commit post below, it can not be seen anymore the out of page animations.  that means the page doesn't slide to left/right (see video)
Expected behavior:
After call a setDiv(), we expect the plugin don't do a hard DOM refresh and let run the animations transitions again as before the commit happens.
https://github.com/mapsplugin/cordova-plugin-googlemaps/commit/4ef4e5ce68716f1a916f5138ff745d7ed9523f76
We try 2 things i write you the results

A more conservative approach removing these lines from refreshLayout(),  to avoid a hard DOM refresh:

    div.style.display = 'none';
    div.offsetHeight;
    div.style.display = '';

Put inside the refreshLayout() these one:
document.body.style.transform = 'rotateZ(0deg)';
Result: the transition is fix but the map is not seen:
2-Second try
We remove the lines from refreshLayout(),
    div.style.display = 'none';
    div.offsetHeight;
    div.style.display = '';

And  after call setDiv()  we call from our app code:
document.body.style.transform = 'rotateZ(0deg)';
That works transition is seen and map is seen on IOS
We wonder if you could get a fix to have all working !!!
Screen capture or video record:

1 - First video shows slides animations working getting out of the page
https://youtu.be/U5dPZqZ2mxA
2- Second video shows getting out page 3 times and the animation can hardly seen it get out of the page abruptly without sliding out left as usual.
https://youtu.be/3Y7MqZMtPvE
Note: On Ios the transition are showed but in Android not. i post the videos on android case.
Support this plugin activity
I appreicate if you give me a beer :beer: from here

Video must upload to YouTube or server please. I don't open zip file.

Video must upload to YouTube or server please. I don't open zip file.

ok i've upload now to youtube

update videos screens to improve explanation any else say me  please

If you don't help me, I don't help you.

say what you need please

I can't open zip file on mobile phone.

i update the ticket with youtube linnks look
1 - First video shows slides animations working getting out of the page
https://youtu.be/U5dPZqZ2mxA
2- Second video shows getting out page 3 times and the animation can hardly seen it get out of the page abruptly without sliding out left as usual.
https://youtu.be/3Y7MqZMtPvE

Did you read this section?
https://github.com/mapsplugin/cordova-plugin-googlemaps#how-does-this-plugin-work-android-ios

Map is a not HTML element. Thus, map can't follow css animation (transition).

Thanks for reopening the ticket very much, sorry for the mess before I will try to explain it better.
yes, I've read the documentation that you refer, Let me put in context, we have an app publish already using the plugin  from version 2.1.1 forked:
https://github.com/goinnn/cordova-plugin-googlemaps/tree/v2.1.1%23custom
This is the link app in case you want have a look:
https://play.google.com/store/apps/details?id=com.joinuptaxi.passenger&hl=en
Now we are updating to the last version and work much better but the only thing we see is the issue comment before.
Yes, as you say the map is not an HTML element and the map, so the maps redraw o refreshes must no be a problem with other CSS animation on HTML page... but I see the next things until now:
We test the app before the commit and was working, I think that the change on commit adding the lines refreshLayout function() force a "Webkit redraw"  as you explain in the code, and that could be the cause to interference with other animations running in the same moment...
I did some trials that point in that direction ...
1- I removed from refreshLayout() the lines that do "Webkit redraw". This done the CSS animation appears again.  Here is my fork (https://github.com/zarelint/cordova-plugin-googlemaps.git)
that I did where I' removed that lines basically in the state before the commit.
The issue from removing that lines as you know broke the map in IOS leaving the screen map in black as you explain in the commit.
I've tried 2 things, Sure, may here you have better ideas...

I try replacing the redraw lines inside the function refreshLayout()  by forcing a rotation to refresh the map doing this:
document.body.style.transform = 'rotateZ(0deg)';

With no success on point 1, in this second this time  after calling the setDiv() I force that refresh with  'rotateZ(0deg)' but this time from the app itself that fix the issue map but this is bad deal because  I have to use the fork I paste before.

[Current official plugin: no animation] (https://youtu.be/3Y7MqZMtPvE)
[Our solution fork URL FORK + after setDiv for iOS document.body.style.transform = rotateZ(0deg)]  (https://youtu.be/U5dPZqZ2mxA)
The difference could be hard to see on both videos because the animation goes faster, I words would be getting out page the page slide left instead show the other page directly that is the animation that is lost. Any test or clarification say us.
Maybe you can have another approach to avoid "Webkit redraw" and at the same the get the maps working IOS. that would be great
We appreciate your work,  we will send you a donation as soon as possible, Thanks very much for your time.

Thank you for the further update. The code of refreshLayout() is very old. It might not be necessary for the recent iOS. I will test it more details.

ok, it would be great could be removed it,  if you need any else, tell me. Regards.

This is already fixed.


Can't load the pretrained model from open-mmlab

Several days ago, I have trained the model with config file: configs/fcos3d/fcos3d_r101_caffe_fpn_gn-head_dcn_2x8_1x_nus-mono3d.py. but today when I train the model, the code raise below error:

If any changes happened on open-mmlab pretrained model, I don't remember I have changed the code

Thank you, as modify the config file to close the DCN, the code successfully run.


Add optional ObjectId field

Issue #1826
An initial version of the optional ObjectId and UUID fields, along with a few others. I'll add some comments/tests, and push more classes. Just wanted to push an early PR to make sure it's going as expected.

Going to nominate @eltimn for review here since I don't understand record particularly well. haha =)

@eltimn Thanks. Will go ahead and make the rest of the changes over this week.

@eltimn Would you be okay with changing MongoCaseClassField to CaseClassField, just to be consistent with how some of the other classes are named (e.g. JObjectField)?

@Bhashit that's fine with me.

I haven't done a thorough review yet, just a few things I noticed:

We don't want to seal the XXXTypedField class. We want users to be able to extend them.
This will not make it into 3.1, so the deprecations should be 3.2.

Yeah, I was thinking about those parts. Will make the necessary changes.

I think we should standardize on owner

Absolutely. I have been thinking about doing that too. Thanks for bringing that up and removing my confusion about whether or not I should do it. I am sometimes concerned about making too many changes without asking about it first. Although, I did make some changes without asking. :grinning:

Hey @Bhashit, just a friendly reminder about this pr. Let me know if you need any help! :)

Thanks @farmdawgnation. Yeah, I have been meaning to wrap this one up for the past two weekends, but ended up with much less time than I expected. Not much work remains here. I'll try an wrap this one up over this work week instead of waiting for the weekend. :)

I'm on this. Some really unexpected few weeks. Didn't get to warp this up.

@farmdawgnation I think this is ready for a review now.

The 'override' modifier removed from places where it wasn't really overriding anything.

Alright, seems unlikely we'll get further review here since @eltimn and I have been the primary reviewers. Let's ship it! 🚢


Bug when change a page size

OS:  Windows 10
Browser  Microsoft Edge, Chrome

https://user-images.githubusercontent.com/5357178/128163754-8fd774f6-05fc-4fb0-a678-c6acadffd6a4.mp4

I have already reacted to this problem.  use div class instead of mudhide！ see mudblazor project code.
Have you used the framework in your projects and have you had performance issue? I feel that very slower then html page.

Will be addressed in the next release

Your issue already on this link https://github.com/blazorhero/CleanArchitecture/issues/258


Three styling fixes

Based on Kimberly's feedback here:
https://www.figma.com/file/Dev3ulmslbUYJPkaCLDnJm/Innovation.ca.gov-screens?type=design&node-id=2581-13748&mode=design&t=1w7tx3Ox3ms0k9Kt-0

Removed margin from bottom of hero figure.
Increased spacing on top of h2s by about 2x.
Added 10px padding to content section to match the padding on headers and footers.

The last two fixes affect many other pages on the site (not just project pages), which have the same issues.  Please check a few other pages to confirm that these changes are desired there as well.

Approved by Kim via Slack.


[BEAM-13894] Unit test utilities in the ptest package

Updates the ptest package to unit test the utility transforms provided.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lostluck @damccorm