etcdctl flags should be able to passed as env vars

etcdctl should function just like etcd itself: you can provide either a flag or environment variable for all config options.
https://github.com/coreos/etcd/pull/4196 adds a little bit more documentation about the current set of flags that have env vars, but it also highlights the gaps.

@robszumski I think for configuration related flags, we should enable env. But we do not need to do this for all flags. For example, we have -i (interactive mode) flag for watch subcommand. Making -i an env does not really make sense to me.
/cc @heyitsanthony

@xiang90 Agreed; that's what curl does.


Patch 11

Please answer the following questions for yourself before submitting a pull request. YOU MAY DELETE UNUSED SECTIONS.
Rule Submission
Website: example.tld

[ ] I have made the rule as simple as possible ( K.I.S.S )
[ ] I have run the rule myself for a period of time to spot any bugs

Bugfix/Enhancement

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you successfully ran tests with your changes locally?

Fixes #
Proposed Changes

I just had a thought, using the reformat command you could pass the url through another url.
It's a bit complicated but the www.golem.de filter in the configuration example might be of some help. Let me know if you still want to submit this PR

Looks like it doesn't even matter WSJ.com has it hardcoded in now, no way to bypass unless you login/pay

Reformat not readability, it's is part of the base and allows you to modify the url's. I do remember talk of wsj establishing a hard paywall.


refactor(hesai_hw_interface): remove mention of Velodyne sensors in Hesai code

NebulaModelToHesaiModelNo was explicitly handling Velodyne models, while it should really just handle everything that is not Hesai the same. Because of this, PR #77 and future sensor additions cause warnings in this piece of code (enum value XYZ not handled).
PR Type

Improvement

Description
The function on question now has a generic default case for any non-Hesai sensors. Functionally it is exactly the same as before.
Review Procedure
Confirm there are no build warnings like "Enum value XYZW not handled in switch statement", confirm in the diff that the code is equivalent.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR: Required to pass before the merge.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (71e7d0e) 8.29% compared to head (0f22ed8) 3.96%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #100      +/-   ##
========================================
- Coverage   8.29%   3.96%   -4.33%
========================================
  Files         87      27      -60
  Lines       8455    5952    -2503
  Branches     852     463     -389
========================================
- Hits         701     236     -465
+ Misses      7179    5304    -1875
+ Partials     575     412     -163

Flag
Coverage Δ

differential
3.96% <ø> (?)

total
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Images used in viva topics documentation do not reflect the current state of viva topics in the M365 admin center.

[The images used in demonstrating the setup of viva topics from m365 org settings option under settings, doesn't reflect the same naming convention used in the admin center ]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7d27e1f6-9c0d-3264-0d0c-31479c102981
Version Independent ID: 7d27e1f6-9c0d-3264-0d0c-31479c102981
Content: Topic center overview in Microsoft Viva Topics
Content Source: Viva/topics/topic-center-overview.md
Service: viva
Sub-service: viva-topics
GitHub Login: @ruthholls
Microsoft Alias: ruthhollands

Happy to update this with snapshots from my demo tenant.

Hello @UdokaVrede
Screenshots of Viva Topics option under Settings have been updated recently.

Perfect, thank you
On Wed, Apr 26, 2023, 5:49 PM Andres Mariano Gorzelany <
@.***> wrote:

Hello @UdokaVrede https://github.com/UdokaVrede
Screenshots of Viva Topics option under Settings have been updated
recently.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/Viva/issues/581#issuecomment-1523747717,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APFTMSG2EZSS3ZPTLFVLP6LXDFG2JANCNFSM6AAAAAAXFGP63Y
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you for your feedback


Configure enableIMEPersonalizedLearning for a scope

Use case
Users have requested that I allow using the incogito keyboard for my application.
However, my application contains many TextField and TextFormField.
It would therefore be a lot of work to change the enableIMEPersonalizedLearning value for all my test fields.
Proposal
Allow configuring the enableIMEPersonalizedLearning for a scope (through BuildContext and some InheritedWidget).
I have thought about where specifically this value would go and InputDecoration comes to mind. This would easily allow configuring this value for a larger area of TextField. However, I am not sure if InputDecoration is the correct place.
If not, I am not sure where exactly this value would live.
Other values like enableInteractiveSelection are also not available on InputDecoration, so maybe this is not the right place.
This functionality can technically be added from the outside but would require a wrapper around every single TextField in the app, making this not a real solution to the aforementioned problem.

I hear you on this, but I think that your proposal here is a specific solution for a general problem. We could add a one-off way to set enableIMEPersonalizedLearning for some widget tree, but the same problem still exists for nearly every other widget parameter in Flutter. Adding one-off things like this could lead to a confusing API.
One option for today
You could create a wrapper for TextField that hardcodes this parameter.
class MyTextField extends StatelessWidget {
  const MyTextField({super.key});

  @override
  Widget build(BuildContext context) {
    return const TextField(
      enableIMEPersonalizedLearning: false,
    );
  }
}

Then use MyTextField everywhere instead of TextField. The downside is that you'll have to manually pipe through all of the constructor parameters that you care about.
An upcoming solution: static metaprogramming
It looks to me like this new Dart feature will solve the problem of the wrapper widget (spec). It seems like you could pipe through all of the constructor parameters automatically, so you wouldn't have to worry about new parameters being added to TextField, etc. Or you might even be able to come up with other solutions to your original problem with this.

Thank you for your reply.
I was aware of wrapper classes, but unfortunately, they do not solve my problem.
Whether I use a wrapper class, or adjust all textfields manually, I will have to make many changes across my entire app, just to support this feature.
The macro approach, which yet not available, suffers the very same problem as manual widget wrapping.
I dont think that there should be an InheritedWidget just for this single parameter, but I do think it would be useful to have one that either sets this and other parameters, e.g. enableInteractiveSelection, or include this in the Theme (though, again, I am unsure which parameters truly belong into a Theme object, and which don't. I haven't spotted a pattern in other Theme objects).
While it is true that technically each and every parameter might be useful to be configurable across the entire app, I do believe enableIMEPersonalizedLearning is an important one for all kinds of apps that may work with sensitive personal data.

Assuming this issue to probably not be important enough to get an implementation,
I consider this to be discussed sufficiently and will close it now.
I will solve this problem the manual way in my app. However, I do believe an option like this would be valuable, even in the future.


feat: inhibit screensaver

since running zwift doesn't require any keyboard/mouse input, the screensaver/screen lock, etc may be triggered in the middle.
afaik, the standard for inhibiting the screensaver is to periodically call the dbus service org.freedesktop.ScreenSaver with the Inhibit method, for example, with xscreensaver
This is what Firefox does.
The easiest way to achieve this, is to use xdg-screensaver reset from the xdg-utils package.
I've been running this separately in another terminal each time I start zwift, but I think it's a good idea to add support for it for anyone who's running a dbus server.
Edit: lutris may have done something similar: https://github.com/lutris/lutris/issues/2424#issuecomment-609976923

hm... well, as it is, it is completely transparent from the user perspective, so I'm not sure what I would mention in the readme, other than to add a paragraph introducing this feature?

Maybe just mention that every 30 seconds x screensaver is inhibited on the host machine if the env variable is defined.


Don't crash if no permissions

cc @inducer

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Patch upstreamed in https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/pull/94


Find a way to run OpenCL tests on AppVeyor

Not sure how to do this, but it would be a huge benefit to the ongoing development of this library.

Fixed in #13


Create meteor sortable using API, not template?

Hi @dandv, is it possible to create a sortable instance via the api in my templates' onrendered callback?
I.e.
Template.x.rendered = function () {
var $grid = $('#' + Template.instance().gridId);

Sortable.create($grid[0], {
    group: Template.instance().gridId,
    animation: 500,
    ghostClass: 'ghost',
    filter: '.grid-sub-heading',
    scroll: true, // or HTMLElement
    scrollSensitivity: 5, // px, how near the mouse must be to an edge to start scrolling.
    scrollSpeed: 50 // px
});

Thanks

Hey @dcworldwide, I have been creating sortable on onrendered function. Did you have any problems with above code? Did try it out?

Dear all! Meteor is moved to the separate repository. If this issue is still actual, please create it there once again.
For your info: this project needs a maintainer.


feat: add dedupeEnums option

Changes
reference：#1683
How to Review
The tests should pass
Checklist

[x] Unit tests updated
[x] docs/ updated (if necessary)
[ ] pnpm run update:examples run (only applicable for openapi-typescript)

when could this me merged? really looking forward to this feature!

Let me know if you’d rather publish as a patch or minor; either is fine.


Alternative way to fix the stack.

Create a template function bn_div_safe and allocate buffer in stack accordingly.

For some reason I cannot make the GMP to work on my machine for now. Maybe someone else can try it.
In fact, de we really need GMP? it's only used in one place....

I was trying to build with GMP but I have this link issue (installed gmp10-dev):
[11/14] Linking CXX executable bench/chia_bench
FAILED: bench/chia_bench
: && /usr/bin/g++-12 -D__USE_GMP -O3 -DNDEBUG -lgmp bench/CMakeFiles/chia_bench.dir/chia_bench.cpp.o -o bench/chia_bench  libbls12-381.a && :
/usr/bin/ld: libbls12-381.a(scalar.cpp.o): in function `bls12_381::bn_divn_low(unsigned long*, unsigned long*, unsigned long*, int, unsigned long*, int)':
scalar.cpp:(.text+0x9e9): undefined reference to `__gmpn_tdiv_qr'
collect2: error: ld returned 1 exit status

I think I found a bug in bn_divn_low. at the beginning we do:
norm = (64 - __builtin_clzll(b[sb - 1])) % 64;
but the doc says:
"Built-in Function: int __builtin_clz (unsigned int x)
Returns the number of leading 0-bits in x, starting at the most significant bit position. If x is 0, the result is undefined."
So we should probably check if b[sb - 1] == 0 before calling __builtin_clz

yeah @greg7mdp good call, that doesn't look good
Since we have C++20 we can use std::countl_zero which is well defined and generates optimal asm on latest compilers when BMI2 is available. But.. to squeeze out that optimal asm we'll need something like target_clones on the function.. and as we've learned recently ASAN doesn't like IFUNC resolvers :weary:

I made #7 to track the __builtin_clzll() problem @greg7mdp discovered

In fact, de we really need GMP? it's only used in one place....

Yeah, I think it should be removed.. it's not clutched in for any test to know if it's rotting away, and we're trying to avoid GMP usage in leap anyways.

In fact, de we really need GMP? it's only used in one place....

Yeah, I think it should be removed.. it's not clutched in for any test to know if it's rotting away, and we're trying to avoid GMP usage in leap anyways.

Should I remove that here in this PR

Since we have C++20 we can use std::countl_zero which is well defined and generates optimal asm on latest compilers when BMI2 is available. But.. to squeeze out that optimal asm we'll need something like target_clones on the function.. and as we've learned recently ASAN doesn't like IFUNC resolvers 😩

It is not 100% clear to me what the value of norm is expected to be (in bn_divn_low) if b[sb - 1] == 0, between 0 and 64. I tried both and the unittests pass for both values.

I believe that's because in our tests the value never really go to zero.

GMP removed

Now this PR will also resolve #7


fix: Morphing Issues with Preview Badge

Fixes #370
Changes:

Updates to Preview Badge

@yashk2000 @iamareebjamal @mariobehling Review

Unclear what problem you are solving.

@mariobehling when you use this layout with other layouts, the behaviour is not what you expect. It will cut it's end from one side because the left and right offset are not fixed. Let me give you the screenshot asap

@mariobehling Check the issue, I've added the image of the issue

@iamareebjamal @mariobehling plz get this merged


Does REST API work with workspace email id which is integrated with outlook?

Hi,
I want inbox mail list from id<EMAIL_ADDRESS>which is integrated with Outlook.
I just did the above Outlook REST API integration and It works fine with my outlook email id<EMAIL_ADDRESS>My question is  one of my client has integrated his workspace id let say<EMAIL_ADDRESS>with outlook. Now will this workspace email id work with above developed Outlook REST API?

The requirement is that<EMAIL_ADDRESS>be either an Office 365 mailbox or an Outlook.com mailbox. If it is one of those, then it will work. If it is hosted by some other system, it will not.

Thank you so much for your valuable response.


File dialog gets stuck on the path of the first selected preset in export dialog

Godot version:
afecc0b
Issue description:
On the "Export" dialog, the first selected preset's export path will always be the one showing in the file dialog when exporting a project, while selecting others unable to change it.
From the testing I did, the problem seems to be with the EditorFileDialog itself, as the select paths are sent to it, but it fails to acknowledge them. Here's the line if anyone want to try their luck:
https://github.com/godotengine/godot/blob/afecc0bc2283dfbfbce70ae95c28e0ed4ecd4160/editor/project_export.cpp#L944

I Cannot reproduce this on the latest master ...

It happens in the file dialog, not in the export dialog.

CC @SonerSound

Will work on it this weekend starting today. Thanks for the catch!

@YeldhamDev I'm having trouble either reproducing or understanding the issue. Do you mean that when both paths are set, and when pressing the path button, the path thats default is not the one from the currently selected export path?

By the way, that line was reverted sometime ago. Is it possible thats fixed now?

I'm having trouble either reproducing or understanding the issue.

Consider that you have multiple export presets, and each one has a different export path.
The first time you click in "Export Preset", the file dialog will correctly set its path to export path of the preset, but it will make it get stuck in said path, so this in any other preset will always show that first path.

By the way, that line was reverted sometime ago.

The commit that commented that line out was closed.

The commit that commented that line out was closed.

I was talking about the commit that I made that reverted the line you transcribed in the your first post. That whole if block was reverted by my merge request. (#31586)

The code in "editor/editor_export.cpp" is actually what's causing the bug.


[REQUEST] Debrid-Link

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Could you kindly integrate Debrid-Link alongside Real-Debrid? I currently have a Debrid-Link account and would greatly appreciate the option to utilize this service with your exceptional software. Thank you for your dedication and efforts.
Describe alternatives you've considered
.
Additional context
API: https://debrid-link.com/api_doc/v2/introduction

seria legal para esse aqui tb
https://docs.alldebrid.com/#general-informations

+1

Also interested


[Feature Request] Auto save average

When the team is happy with the average, it would be nice to have a feature to save the average directly, instead of having to type it manually.
This could come in the form of simply leaving the input blank and clicking save, or a separate "Save average" button.

@BenjaBobs  Thanks, good suggestion.


A new build for our production Docker images

wait where's the config changes?

wait where's the config changes?

Whoops. I had not pushed.


zkWilly - Sybil Account Detection Assistance

🌟 Feature Request
📝 Description
We are aware of a large amount of sybil activity on the zkSync main net. On the surface, we guess this is automated/bot activity for individuals looking to qualify for some expected future airdrop of the zkSync governance token.
A week ago, we launched a zkSync whale tracker called zkWilly (https://twitter.com/zkwilly). We process mainnet transactions to detect and report on large transactions.
Whilst looking at the data we process, we have been noticing a lot of potential sybil behaviour where a string of connected accounts transfer amounts between themselves, supposedly to try and qualify for some suspected airdrop in future.
If this data/processing could be of assistance to zkSync then we would be happy to share 🤝
🤔 Rationale
Identification of on-chain sybil activity can be valuable to bolster analytics and preventative mechanisms.
📋 Additional Context
Not a feature per se, but an interesting topic potentially.

Closing as a stale issue


Example working with EF Core

Could you please provide an example of using graphql-dotnetcore working with EF Core, for a query and mutation

Hi, sure I can create an example during the upcoming weekend.  I'll post a link here afterwards.

+1 for this. Looking forward to the sample.

Created a repo at https://github.com/mkmarek/graphql-dotnetcore-ef-example for now it contains just one query and one mutation but it should still explain one of the possibilities how to use it. I'll add more stuff  and some furter explanation during the weekend hopefully. It went to be a little bit more difficult than I initially expected. But it's quite simmilar to a way how we use this library for real projects.
But basically it uses the CQRS pattern which I think works with GraphQL really well. For DB I used MSSQL but you can surely change that to whatever suits you. For the database layer I picked unit of work pattern using https://github.com/arch/UnitOfWork library.
It also uses the ASP.NET core DI container quite heavily. You can notice that the graphql schema class doesn't really have anything. The flow is inverse. The types themselves are registering into the schema. The reason for that is here Another workaround would be of course possible if It managed those schema types outside the DI container.
I'm running quite old version of .NET core on my current laptop so you might have to upgrade the project.
To run it you need to:

change the connection string at appsettings.json
run the dotnet ef database update to populate your database
run it with dotnet run or through visual studio

Then if you go to http://localhost:/public/index.html you should see the GraphiQL interface and there you can play around.
Enjoy!
Marek


ARTEMIS-2648 - audit logging improvements

https://issues.apache.org/jira/browse/ARTEMIS-2648
A description of what I have done can be found on the Jira. Id like however some feedback on something, where I have added new logging I have removed the log message that was previously in the same place so where  there was a log message for creating a queue I have added a success and failure log. If anyone thinks this is a big deal i can add back the old messages but this will mean there are multiple logs potentially occurring.

ArtemisFeatureTest fails as we talked about.
just using the tag to avoid someone to merge it before it's fixed.
let me know when it's updated and I will remove the tag.

this branch has no test failures now. We just need to address asynchronous operations and the thread local that was needed.


Fix waterbox off behaviour (#764)

Resolves https://github.com/homebridge-xiaomi-roborock-vacuum/homebridge-xiaomi-roborock-vacuum/issues/764#issuecomment-1712083333

It should be fixed in https://github.com/homebridge-xiaomi-roborock-vacuum/homebridge-xiaomi-roborock-vacuum/releases/tag/v0.29.1. Please, let me know if it isn't.

It does not work, at least for me, with my Q Revo.  The mop spins and the floor gets mopped, even with the waterbox set to off.  Changing the level on the waterbox does not seem to change the amount of water getting fed to the mops either, but I may be wrong given my limited observations testing that portion of the fonctionalities.

@pelletip, do you get any errors in the logs when setting the waterbox to off?

No errors listed in the logs.
Also, it does not look like there is an option to send the robot on a "mopping only" routine.  If I press the waterbox button, it does not start... I need to press the Robot Vacuum button for it to get started, once it starts, it's always the combo (mop and vacuum) running

wait, I clicked the plugin option to see more logs:  some waterbox related logs:
[08/09/2023, 19:22:12] [Robot Vaccum] [Model=roborock.vacuum.a75] getWaterSpeed | WaterBoxMode is undefined over miIO. Converting to HomeKit
[08/09/2023, 19:22:12] [Robot Vaccum] [Model=roborock.vacuum.a75] getWaterSpeed | WaterBoxMode is undefined over miIO. Converting to HomeKit

yeah... I think that model didn't have any listed WaterBox-compatible in modes in the plugin. I hope v0.30.0 fixes it for you

it definitely is better, I can now do vacuum only by setting the 'water box' button 'off'.  Thank you so much for fixing!   I guess there is no option to do a mop only routine?  the only way to initiate a cleaning is to press the vacuum button, if I slide the vacuum to zero, it returns to the dock.

I can look into that. I created https://github.com/homebridge-xiaomi-roborock-vacuum/homebridge-xiaomi-roborock-vacuum/issues/791 to track this additional request :)

maybe a moot point anyways... it's probably a good idea to at least have minimal vacuum ahead of mopping... I assume it can be done technically, because the Mi app allows for this type of routine to be executed, but this may be a bit of a rare use case, comes to think of it.


st

Sorry, this issue wasn't intentional. I was just looking at another issue in this repo, and ended up creating this one because of GH's keyboard shortcuts. >.< Apologies!


schema_json does not output None as null in unions

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
Nones get dropped from JSON schema when used in a union of any kind but work correctly when alone. Seems to be related to #4619 but a bit more extensive than described in just that issue. It would also be quite nice for this to be the documented behavior in 1.x if it won't/can't be fixed.
Example Code
from typing import Optional, Union

from pydantic import BaseModel

class Foo(BaseModel):
    a0: dict[str, None]
    a1: dict[str, Optional[str]]
    a2: dict[str, Union[str, None]]
    a3: dict[str, str | None]

    b0: list[None]
    b1: list[Optional[str]]
    b2: list[Union[str, None]]
    b3: list[str | None]

print(Foo.schema_json(indent=2))

Python, Pydantic & OS Version
pydantic version: 1.10.4
            pydantic compiled: True
                 install path: /usr/lib/python3.10/site-packages/pydantic
               python version: 3.10.9 (main, Dec 19 2022, 17:35:49) [GCC 12.2.0]
                     platform: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.37
     optional deps. installed: ['typing-extensions']

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[X] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

It should be noted that Literal[None] does not work either. 😞
Could it be possible for 1.x to support Literal[None] as a hack for this specific case?
from typing import Literal, Optional, Union

from pydantic import BaseModel

class Foo(BaseModel):
    a0: dict[str, None]
    a1: dict[str, Optional[str]]
    a2: dict[str, Union[str, None]]
    a3: dict[str, str | None]
    a4: dict[str, str | Literal[None]]

    b0: list[None]
    b1: list[Optional[str]]
    b2: list[Union[str, None]]
    b3: list[str | None]
    b4: list[str | Literal[None]]

print(Foo.schema_json(indent=2))

I'll just note that this should be fixed in v2.

As @dmontagu mentioned it fixed in V2


optional client certificate for mutual TLS

Description:
Hi, we have a use case of securing one of the APIs with mutual TLS while keeping other APIs with TLS only. currently, mutual TLS is applied on gateway objects where it will protect the listener level.
by making client certificate validation optional, we can add make 1 domain support both mutual TLS and TLS and we can filter APIs that require mTLS with https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/headers#x-forwarded-client-cert later.
[optional Relevant Links:]
most API gateways support this mechanism, for example, Kong or Tyk.

https://docs.konghq.com/hub/kong-inc/mtls-auth/
https://tyk.io/docs/basic-config-and-security/security/mutual-tls/client-mtls/

this use case is also highlighted in the upstream GEP for this feature https://gateway-api.sigs.k8s.io/geps/gep-91/#deferred
also makes sense to add this knob into CTP https://gateway.envoyproxy.io/v1.0.1/api/extension_types/#clientvalidationcontext

xfcc is being tracked with https://github.com/envoyproxy/gateway/issues/2599

I am working on this

closed via #3199


fix(renderer): optimize function ProtoName

Following #341:
Small optimization: avoids going through the condition first, start with protocol lookup.
Combine the if/else
cc @marioschaefer / @DerInti

makes sense


fix: tokens metadata is now resolved from more than one source/metadata standard

Checklist

[X] JIRA - LW-10829
[ ] Proper tests implemented
[ ] Screenshots added.

Proposed solution
TBD
Testing
TBD
Screenshots
TBD

Allure Report
allure-report-publisher generated test report!

smokeTests: ❌ test report for e342260f

passed
failed
skipped
flaky
total
result

Total
32
1
0
0
33
❌


chore(ci): fix web identity token path for aws s3 assume role test

Hi, CI won't be triggered from a forked repo. Let's me help debug this issue.


A few questions about best practices

Sorry if this is the wrong place to ask this. I've got things up and running with proto3 using protobuf JS in the browser and rust-protobuf for my server. It feels a bit clunky so I want to see if there are any suggestions for how I might improve my design. Basically I'm building a simple game where all the logic runs in rust, and protobuf is used over a websocket to communicate with the UI which runs in a browser (designed to run on the same machine to minimize latency). In the Server->Client direction it's mostly just streaming state updates which are always the same type, so no problem. However, in the Client->Server direction there are different types of messages that can be sent. Some are just a simple command with no payload, others have various payloads. I'm currently handling like this:
.proto
message UiMessage {
    oneof {
        CommandType1 command_type_1 = 1;
        CommandType2 command_type_2 = 2;
    }
}

message CommandType1 {
    // no payload
}

message CommandType2 {
    int32 payload = 1;
}

rust
if let Ok(ui_message) = parse_from_bytes::<UiMessage>(&raw_message) {
    if ui_message.has_command_type_1() {
        //...
    }
    else if ui_message.has_command_type_2() {
        let payload = ui_message.get_command_type_2().get_payload();
        //...
    }
}

There are a couple things that I don't like about this:

Having to use if-else rather than being able to match on the message type. Does rust-protobuf have a way to do this?
Naming the subcommands the same as their types seems weird, and makes me think I might be using the wrong approach to accomplish my task.

Any suggestions?

Having to use if-else rather than being able to match on the message type. Does rust-protobuf have a way to do this?

rust-protobuf has an expose_oneof codegen option. It's off by default, but should be public in the next release.
Currently you need to include rustproto.proto and specify options in your .proto file, but in later versions this could be turned on programmatically (which won't be necessary, because oneof should be on by default).

Naming the subcommands the same as their types seems weird, and makes me think I might be using the wrong approach to accomplish my task.

I think this is standard way to do it protobuf.
Sorry for late reply, I overlooked it.
Hope I helped.


Update aspect ratio on canvas resize

Hi there!
I was trying to integrate this gcode viewer into the SlicerA and observed an issue when I attach window resize events to the canvas.

Would it be possible for you to add an automatic logic for adjusting the aspect ratio when the DOM element resized? Thanks!

Just call renderer.resize(width, height) whenever you want to resize it. Then the camera will be recalculated.

I have updated the implementation of gcode viewer in SlicerA using your website source code as example. Thanks so much for the tips!


使用4.3.6 转化har文件失败

Describe the bug

Please give a brief description of the bug;
attach the running command and the stack information when the error is reported

Versions
Please complete the following information:

OS Type: [e.g. macOS, Linux, Windows]
Python version: [e.g. 3.9]
Go version: [e.g. 1.18]
HttpRunner version [e.g. 3.1.8]

Project files (If possible)
Provide your project files to help locate and debug bugs faster. This is not mandatory.
NOTICE: Before uploading your project files, don't forget to remove sensitive data, e.g. IP, username and password, key info etc.

WRN skip file expectExtensions=[".json"] path=test.har

试试这样转换
hrp convert --from-har har/test.har --to-yaml --output-dir ./testcases


1440p Broken

First, it wouldn't let me download a preset until I turned on debug mode, the download button was just greyed out.
Now, it seems it only scans bottom left of my screen, no matter what 1440p preset I choose.
When I'm in game it just constantly makes my cursor flicker.
It works when I select a 1080p preset and move D4 to my other monitor.

Perhaps this is somehow because my 2nd non-primary monitor is 1080p? Or that my 1440p monitor is 165Hz?

Hi @curtiola

First, it wouldn't let me download a preset until I turned on debug mode

You can't update the preset while the overlay is active. The button will be enabled when you turn it off.

Now, it seems it only scans bottom left of my screen, no matter what 1440p preset I choose.

That is normal. It only needs the bottom part to find the tooltip.

The other debug images will have a complete view of the tooltip.

When I'm in game it just constantly makes my cursor flicker.

Not sure about this one. Any other overlays active?

It works when I select a 1080p preset and move D4 to my other monitor.

Could you try a 1440p preset again that matches your font settings? Then check the debug window if it recognizes the Shift key.

Apologies, it is working properly when I select the small font preset. I must have screwed up when I was testing it.
Though it's still flickering, andI'm not using any other overlays at the moment. I tried reducing the refresh rate to 60 to match my other monitor, no luck.

If you like to do some testing and have some time. You could disconnect your other monitor and only use the 1440p one.
Just to test if that influences the flickering.
I'm also using two monitors, but both at 1440p, no mouse flickering ingame.
But now that you mention it I do notice some flickering while I'm typing this message.
When is your mouse cursor flickering, ingame? Or only outside the game when you the normal windows cursor?

If it's only outside the game you can quickly turn the overlay on/off using the hotkeys.

When the overlay is enabled it flickers in and out of the game, on both monitors. Unplugging the 1080p monitor has no effect, though unplugging the 1440p one completely removes the flicker. It's a Benq EX2710Q, HDR is off. No DLSS or NVIDIA Reflex settings are enabled in game. I tried plugging it into a different displayport just in case, no difference.
I'm totally fine with disabling the overlay until it's time to sort through my stash dumps.

I found the culprit, it's Discord!

Thank you for the extra details!
If I find some more info on how Discord is causing issues I'll let you know.

Also curious why unplugging the 1440p 165Hz monitor would fix the issue.

Maybe g-sync is causing problems?

Oh, it does! Disabling G-SYNC stops the flicker in game, now it's just when I Alt Tab

Appreciate this overlay a ton btw, stash sorting is so much faster now, solid idea, excellent execution.
Flickering isn't really an issue, it's easy enough to just enable it when I need it.

Good to hear, glad you like it.
I'll keep this issue open for others that experience flickering as well.


Release v2.21.2

Coverage increased (+0.003%) to 97.801% when pulling f53e872540dfc13b129f456844373b451fa540f3 on ljharb:release-2.21.2 into 63d2a3f8c0d9ef874680c3150d1c14925fb1f36b on benmosher:release.

Coverage increased (+0.003%) to 97.801% when pulling f53e872540dfc13b129f456844373b451fa540f3 on ljharb:release-2.21.2 into 63d2a3f8c0d9ef874680c3150d1c14925fb1f36b on benmosher:release.

Coverage increased (+0.003%) to 97.801% when pulling f53e872540dfc13b129f456844373b451fa540f3 on ljharb:release-2.21.2 into 63d2a3f8c0d9ef874680c3150d1c14925fb1f36b on benmosher:release.

Coverage increased (+0.003%) to 97.801% when pulling f53e872540dfc13b129f456844373b451fa540f3 on ljharb:release-2.21.2 into 63d2a3f8c0d9ef874680c3150d1c14925fb1f36b on benmosher:release.

Coverage increased (+0.003%) to 97.801% when pulling f53e872540dfc13b129f456844373b451fa540f3 on ljharb:release-2.21.2 into 63d2a3f8c0d9ef874680c3150d1c14925fb1f36b on benmosher:release.


TypeError: __WEBPACK_IMPORTED_MODULE_0_react___default.a.createContext is not a function

I want to used context with two component, created context in parent as :+1:
export const settingContext = React.createContext(null);
created context and use that context with settingValue which is true, ProviderInfo is component
<settingContext.Provider value={settingValue}>

</settingContext.Provider>
I have setstate the settingValue to true.
And in ProviderInfo component use it like :
<settingContext.Consumer>
{this.props.settingValue? :''}
</settingContext.Consumer>
But I'm getting this kind of error.

@Ashwini-Kadam looks like this has to do with the React version installed. It is available only with React versions > 16.3.
Checkout more info here

this might help
npm update react react-dom

this might help
npm update react react-dom

Its works

Updating react and react-dom did not work for me. I even tried downgrading react-redux from 7.2.0 to 5.x.x and that didn't work for me either.
I'm using react 16.13.1 and react-redux 7.2.0. Still getting this error. Any suggestions??

thanks guys the above command really worked for me ....................

npm update react react-dom Perfect!!!!

Thanks, this worked for me too!

this might help
npm update react react-dom

perfectly works!

yes it works

Thanks !

yes it worked! Thank you!

It worked. Thanks!

thanks this worked for me also

Thanks! That was really helpful :)

ohhhhh!!!! si funcionó!!!!

this might help
npm update react react-dom

Thank you, the command solved my issue.

thanks......updating react and react-dom work.....

thank you..! it works by updating react and react-dom as well. (y)

Impressive!!! It works

I hit a similar error using react v16.9.0 and react-dom 16.13.1... Upgrading was moot (already using one of the latest), and did not solve the issue.

this might help
npm update react react-dom

you saved my day!! Thank you!

this might help
npm update react react-dom

Thank you

this might help
npm update react react-dom

it really works, thank you

did not work for me. also did npm cache verify after. still giving error.

npm update react react-dom is working for me
Thank you

It didn't work for me. I still get the error.

It didn't work for me. I still get the error.

Yay me too

I got the same issue but updating react and react-dom didn't help. I was using NextJS 13 with react-hook-form and the problem was that I forgot to put "use client" on the top of the page. This error occurred because you can't use hooks in server components.

thanks it work mate

no work


Need a carousel for the website's homepage

The homepage has a carousel that will be displayed right below the top navigation bar. Contributors may take a look at the wireframe for the website here

Hey I could make a carousel. Could you assign this to me ?

hi! sir can u please assign this issue to me..?
I want to work on this....

PLease go through Contributing.md and follow it for further communication. Thank you.

@shikha-16 So sorry for the removal of your assignment. I just think @chinmaikaveti2001 would be more suitable than me since I am a beginner. But thank you so much for providing me an opportunity for selecting me and Good luck !

@RidhikGovind no problem, please do contribute in other issues if you can!

@chinmaikaveti2001 ?? Please join discord grp

@RidhikGovind , @chinmaikaveti2001 hasn't been responding for a while now, any chance you're still willing to take this up?

yes....@shiksha-16

@shikha-16  ... I  want to work on this issue ....but  can u pls  help me to find the way  to work on it

Because , i'm an absolute begineer to this open source contributions

Please join the discord server @chinmaikaveti2001 , we can talk there
https://discord.gg/xvzbAXk

@shikha-16 i have worked on your repo before and one of my pr is in pending so if there is no problem i can take up the issue
And if so please assign me the task

@shikha-16 i have worked on your repo before and one of my pr is in pending so if there is no problem i can take up the issue
And if so please assign me the task

Yes sure

I am unable to push the code can someone help me or send some documentation that how can i push the code. Its really very irritating when u have done the thing and cannot push the code to the repo

@umang-sinha please look into this

@qwerty-rgb if you forked this Repo and then cloned it.  Then after create a branch through your terminal ‘git checkout -b website’.   After do ‘git pull origin website’ —

I am unable to push the code can someone help me or send some documentation that how can i push the code. Its really very irritating when u have done the thing and cannot push the code to the repo

we have addressed it, please look properly

i did both of that but then also git push is denying access.

Error :(

#46

@qwerty-rgb  you need to push changes to the repository that you forked from the original repository. You are unable to push code into it because you do not own the repository.

thanks @umang-sinha #47

#52


fix(exports): fix strategy exports

:tada: This PR is included in version 1.0.2-alpha.5 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove redundant Ok(()) and explicitly specify StorageKey buffer type

Follow up to #2184, addressing grumbles.
Explicitly specifying StorageKey type alias when initialising the buffer will protect against size changes.

We can ignore the check-runtime test for this pr :) So you don't need to alter the spec or impl version.


Move xDS task out of Proxy, add Agones as another discovery task

This PR removes the requirement of using management server when in a single cluster. Now Quilkin can now watch for Agones changes in the proxy instance directly. This also moves the xDS client from being inside the proxy, to be run alongside it as a configuration discovery provider along with agones. This layout also opens the pathway in the future to support other configuration discovery providers such as Docker or Consul, if desired.
With #661 you'd now write the proxy as the following for agones and xDS
quilkin proxy agones

quilkin proxy xds http://quilkin-management-server

I'll update the documentation once CI passes.

Oh that makes sense! Very neat!
I'm in the middle of writing an Agones + xDS quickstart, but that's still useful if you want to have a full xDS API (say if you want to run your proxies outside of your cluster), and then we can add another one that's just Agones + quilkin proxy agones (may be able to include from one into the other too if we want).
One question I did have, which I couldn't quite see from the code - with quilkin proxy agones you still need to provide the ConfigMap with the Filter configuration? Or is there some kind of file mount instead, like you would for a static config?

xDS API (say if you want to run your proxies outside of your cluster), and then we can add another one that's just Agones + quilkin proxy agones (may be able to include from one into the other too if we want).

Exactly, this makes xDS' role here more clear to me. When you have everything in a single cluster a proxy should be able to work just on it's own, and xDS is for when you want to share configuration across multiple clusters.

Closing because it's so old, if we still want it, we can open a new PR.


Mock GitHub API requests in tests

[x] Adds a MockAsyncHTTPClient, which may use recorded responses, if provided
[x] use recorded responses for api.github.com if GITHUB_ACCESS_TOKEN is not set (e.g. pull requests on Travis)
[x] add records for api.github.com from a local run to the repo so they can be used in PRs
[x] gitignore http-response files created by tests
[x] skip GitHub API tests when running in helm without GitHub API token

Once finished, this should result in PRs passing on Travis again, as the GitHub rate limit will no longer be hit. The cached responses will not be used from master, which has GitHub credentials.

Tests passed! That doesn't necessarily confirm that the github rate limit issue is entirely fixed, since we could have been lucky, but I think it is.

woot! here's to fewer "known failing" tests!

Fantastic work @minrk.


Flexible provenance tracking for state commitments

Closes #3349
This PR removes the previous NoteSource, a stuffed transaction hash, with
a new, extensible CommitmentSource, and makes managing commitment sources the
responsibility of the SCT component that manages state commitments.  This
allows several important use cases:

We can track provenance of funds as they enter the chain, by recording the
sender address, packet number, and channel for NotePayloads created by the
ICS20 handler. This is particularly important because there is no "transaction"
to download to fetch extended information there.

Clients have an easier time deciding whether they need to do an extended
fetch of block data, they just need to see if any detected payload was from a
Transaction source.

We can save space in the compact block by "dehydrating" the transaction
sources and removing the transaction hashes.  Clients already have to fetch
a full block's worth of transactions, because nullifiers don't have source info
attached, so we gain nothing by including detailed source info in the CompactBlock.

Clients have an easier time working with Penumbra data, since there's no more
ad-hoc stuffing.

In addition, it does various other cleanup along the way.

Demo of this support in pcli:


Does not seem to work on Edge or IE 11

Edit: Using the latest v0.6 :)

please confirm it's fixed and, if that's the case, close this.
Thank you

Sorry for the terseness of the issue when created, looking back it wasn't the best report.
Used 0.6.1 in IE11 and Edge and seems to work great! thanks @dartess and @WebReflection!


Solver.build rhs

Preview

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

284 of 311 (91.32%)  changed or added relevant lines in 15 files are covered.
20 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.01%) to 87.678%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qutip/solver/integrator/krylov.py
10
11
90.91%

qutip/solver/integrator/qutip_integrator.py
1
2
50.0%

qutip/solver/mesolve.py
30
31
96.77%

qutip/solver/brmesolve.py
26
29
89.66%

qutip/solver/multitraj.py
0
4
0.0%

qutip/solver/solver_base.py
30
34
88.24%

qutip/solver/mcsolve.py
53
58
91.38%

qutip/solver/stochastic.py
36
44
81.82%

Files with Coverage Reduction
New Missed Lines
%

qutip/solver/mcsolve.py
1
92.64%

qutip/solver/solver_base.py
2
89.24%

qutip/solver/brmesolve.py
2
80.14%

qutip/solver/multitraj.py
5
90.0%

qutip/core/superop_reps.py
10
92.22%

Totals

Change from base Build<PHONE_NUMBER>9:
-0.01%

Covered Lines:
12794

Relevant Lines:
14592

💛  - Coveralls


Added alt tags to images according to #88

According to #88 every img tag should have an alt text.

Great stuff! Thanks. I'll merge this shortly and release with next version


can not get wifi ssid

I am use andriod 13 device to debug NetworkInfo.OnAppearing method.
I get unkonw ssid.

And this code get list cout=0
var response = await CrossWifiManager.Current.ScanWifiNetworks();

Can you confirm that you are testing the code on a physical device and that the location service for the device is turned on?

Resolves with version 1.0.2

thank you


machines.txt

I created 4 arm based virtual machines in the google cloud and they all are in same nic. I'm working on creating machines.txt for this setup, I'm little confused on the value i have to give for the POD_SUBNET, do i need to give the nic's subnetwork range (which would be same for all the nodes

Hey @vranga0812 I got stuck in the step Copy the SSH public key to each machine: while running command
while read IP FQDN HOST SUBNET; do
  ssh-copy-id root@${IP}
done < machines.txt

I always get Permission denied (publickey), how did you get through that step? Thanks!

i had the same issue, i copied the ssh keys manually

That makes sense, thanks @vranga0812!

I ran into the same issue. However, I noticed that the format shown is not correct. It's supposed to be like this:
XXX.XXX.XXX.XXX server  server.kubernetes.local
XXX.XXX.XXX.XXX node-0 node-0.kubernetes.local  <IP_ADDRESS>/24
XXX.XXX.XXX.XXX node-1  node-1.kubernetes.local <IP_ADDRESS>/24
Once I made that change, the loop executed with no errors


脚本管理页面空白，打开报错

Qinglong version
V2.16.5
Steps to reproduce
脚本管理页面无法加载，打开就提示报错
"ELOOP: too many symbolic links encountered, stat '/ql/data/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/scripts/node_modules/.pnpm/<EMAIL_ADDRESS>errno: -40,
syscall: 'stat',
code: 'ELOOP',
What is expected?

What is actually happening?
之前版本也出现同样的问题。
System Info
No response
Any additional comments?
No response

宿主机执行 docker run --rm -v  /var/run/docker.sock:/var/run/docker.sock  containrrr/watchtower -cR <容器名>
确保有映射 data 目录


When each i/IDR frame has SPS/PPS will be crash.

static int transcode_nalu(h264_sps_id_patcher_t* h, const unsigned char* src, int nalu_bytes, unsigned char* dst)
{
    int old_id;

    ......

    switch (payload_type)
    {
    .......
    case 8:
    {
        int cb = patch_pps(h, bst, bdt, 0, &old_id);
        int id = find_mem_cache(h->pps_cache, h->pps_bytes, MINIMP4_MAX_PPS, dst + 1, cb);
        if (id == -1)
            return 0;
        h->map_pps[old_id] = id;
        patch_pps(h, bs, bd, id, &old_id);
    }
    ......
}

    typedef struct
    {
        .......
        int map_sps[MINIMP4_MAX_SPS]; // MINIMP4_MAX_SPS equal to 32
        int map_pps[MINIMP4_MAX_SPS];

    } h264_sps_id_patcher_t;

Access to array 'pps' overflow cause by variable 'old_id' can be greater than 32.

Thanks for the issue)
Yes, there definitely typo here. Can you test if https://github.com/lieff/minimp4/commit/9d3fca973ac14386c9cfcf5f75d757fc9947b183 fixes it?

Thanks for the issue)
Yes, there definitely typo here. Can you test if 9d3fca9 fixes it?

Retested and fixed

Good) Resolved then.


jni.h : No such file or directory

I just set up a linux virtualbox with the android sdk/ndk etc. When I try to run cargo apk build, the following error is printed:
/home/pim/android-ndk-r16/sources/android/native_app_glue/android_native_app_glue.c:18:17: fatal error: jni.h: No such file or directory
 #include <jni.h>
                 ^
compilation terminated.
error: process didn't exit successfully: `/home/pim/android-ndk-r16/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc /home/pim/android-ndk-r16/sources/android/native_app_glue/android_native_app_glue.c -c -o /home/pim/GitHub/project/target/android-artifacts/arm-linux-androideabi/android_native_app_glue.o --sysroot /home/pim/android-ndk-r16/platforms/android-18/arch-arm` (exit code: 1)

Any idea why? I've set ANDROID_HOME and NDK_HOME to the corresponding root directories.

Does the /home/pim/android-ndk-r16/platforms/android-18/arch-arm/include directory contain a jni.h?

Nope, the directory does not even exist. There is one inside home/pim/android-ndk-r16/sysroot/usr/include/ though.

And does /home/pim/android-ndk-r16/platforms/android-18/arch-arm contain any directory at all (eg. lib)?

Yes, usr.

Well, what does usr contain? Does it contain include by chance?

No, only a few .so and .o files.

Hello. What version of NDK you have? I have this problem with 16 NDK. But working of 15 is good.
15 NDK(android-ndk-r15c)
16 NDK(android-ndk-r16)

I have the same problem and searched a bit: r15 defaults to unified sysroots, the platform specific sysroots are deprecated. r16 removed them entirely.

Any updates? Just ran into this issue. Is there a working fix yet or should I downgrade my NDK?

@wmww downgrading to NDK r15c works fine, and is fairly quick and easy. https://developer.android.com/ndk/downloads/older_releases
This repo isn't very active, and I'm too busy elsewhere in the ecosystem to do anything about it, so it could be a while before this is really fixed.

This should no longer be an issue with the current cargo apk nightly or docker image. Recommend closing.


useFetch credentials not work on server

Environment
- Operating System: Darwin
- Node Version:     v20.8.0
- Nuxt Version:     3.8.1
- CLI Version:      3.9.1
- Nitro Version:    2.7.2
- Package Manager<EMAIL_ADDRESS>- Builder:          -
- User Config:      experimental, colorMode, runtimeConfig, app, dev, debug, telemetry, css, plugins, modules, gtm, svgo, image, imports, vue, vite, devtools
- Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>- Build Modules:    -

Reproduction
none
Describe the bug
My plugin init.server.ts
for init auth user

export default defineNuxtPlugin(async () => {
  const config = useRuntimeConfig();
  const store = useAuthStore();

  const { data: user, error } = await useFetch('/api/v1/auth/user', {
    baseURL: config.public.API_BASE_URL,
    credentials: 'include'
  });
}

does not pass cookies to the api.
such an error in setup
<script lang="ts" setup>
  import { UrlGenerator } from '~/shared/api/url-generator';

  const urlGenerator = new UrlGenerator();
  const route = useRoute();
  const config = useRuntimeConfig();

  const SHOP_SLUG = String(route.params.shop);

  const { data } = await useFetch(urlGenerator.getShopBySlug(SHOP_SLUG), {
    baseURL: config.public.API_BASE_URL,
    watch: false,
    credentials: 'include',
  });

 </script>

Additional context
No response
Logs
No response

@danielroe sent invite
in 3.8.0 work

The issue is that previously we were sending all credentials (wrongly) even if you had a custom baseURL. We fixed that bug in https://github.com/nuxt/nuxt/pull/23884, which is why the credentials aren't being sent. You can manually set $fetch: useRequestFetch() to reproduce previous behaviour.

@danielroe
I don't quite understand. Maybe there is an example?

@maksimdrosdov
  const { data } = await useFetch(urlGenerator.getShopBySlug(SHOP_SLUG), {
	$fetch: useRequestFetch()
    baseURL: config.public.API_BASE_URL,
    watch: false,
    credentials: 'include',
  });

This code may work.
I think it's a confusing behavior though, after we set credentials: 'include', cookies should be passed by default.

credentials is a native fetch option and isn't related to sending headers on the server in this case.

credentials is a native fetch option and isn't related to sending headers on the server in this case.

Well, indeed.
But it's a very common requirement for requests to bring cookies to the target site.
I noticed that useRequestFetch doesn't appear at all in nuxt's documentation, so maybe it should be added.

In Nuxt 3, you should use useRequestEvent() or useRequestHeaders() functions to get the request headers:
const { cookie } = useRequestHeaders(["cookie"]);
// or
const event = useRequestEvent();
const cookie = event?.node.req?.headers.cookie;

if (import.meta.server && cookie) {
  // Your logic; like setting request options
}


Feature suggestion - Grouped tag counts per user

Suggested by @JessCappadonna
User profile page should offer a breakdown of tag counts per user - so they can see how many of which species they have annotated.
This idea may be extended to the global stats page:

Top users (privacy issues)?
Most popular tags?

Sensible suggestions. This would need #162 and a re-work of the queries used to populate the global stats page. I agree that there are potential privacy issues around users names.

Not going to do top users or most popular tags on stats page.
Also have not done caching.


[SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName

What changes were proposed in this pull request?
Spark SQL exists some function no elegant implementation.
For example: BitwiseCount override the sql method show below:
override def sql: String = s"bit_count(${child.sql})"
I don't think it's elegant enough.
Because Expression gives the following definitions.
  def sql: String = {
    val childrenSQL = children.map(_.sql).mkString(", ")
    s"$prettyName($childrenSQL)"
  }

By this definition, BitwiseCount should override prettyName method.
This PR will correct the issue for some function as follows:

TimeWindow
MaxBy
MinBy
UnaryMinus
BitwiseCount

Why are the changes needed?
Improve the implement of some expression.
Does this PR introduce any user-facing change?
'No'
How was this patch tested?
Jenkins test.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25704/
Test PASSed.

Test build #121013 has started for PR 28164 at commit 08f0906.

Test build #121013 has finished for PR 28164 at commit 08f0906.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121013/
Test FAILed.

Test build #121019 has started for PR 28164 at commit 7b7f8bf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25710/
Test PASSed.

Test build #121019 has finished for PR 28164 at commit 7b7f8bf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121019/
Test FAILed.

Test build #121036 has started for PR 28164 at commit 67c868b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25727/
Test PASSed.

Test build #121036 has finished for PR 28164 at commit 67c868b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121036/
Test PASSed.

cc @HyukjinKwon

Test build #121142 has started for PR 28164 at commit 43beb20.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25830/
Test PASSed.

Test build #121142 has finished for PR 28164 at commit 43beb20.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121142/
Test FAILed.

Test build #121144 has started for PR 28164 at commit 67c868b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25832/
Test PASSed.

Test build #121144 has finished for PR 28164 at commit 67c868b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121144/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26801/
Test PASSed.

Test build #122129 has started for PR 28164 at commit d549c3c.

Test build #122129 has finished for PR 28164 at commit d549c3c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class AuthRpcHandler extends AbstractAuthRpcHandler
public class SaslRpcHandler extends AbstractAuthRpcHandler
public abstract class AbstractAuthRpcHandler extends RpcHandler
class AbortableRpcFuture[T: ClassTag](val future: Future[T], onAbort: Throwable => Unit)
public class JavaUserDefinedScalar
public class SparkAvroKeyOutputFormat extends AvroKeyOutputFormat<GenericRecord>
 static class SparkRecordWriterFactory extends RecordWriterFactory<GenericRecord>
class AvroDeserializer(rootAvroType: Schema, rootCatalystType: DataType, rebaseDateTime: Boolean)
class AvroSerializer(
 class FMClassifierWrapperWriter(instance: FMClassifierWrapper) extends MLWriter
 class FMClassifierWrapperReader extends MLReader[FMClassifierWrapper]
 class FMRegressorWrapperWriter(instance: FMRegressorWrapper) extends MLWriter
 class FMRegressorWrapperReader extends MLReader[FMRegressorWrapper]
 class LinearRegressionWrapperWriter(instance: LinearRegressionWrapper) extends MLWriter
 class LinearRegressionWrapperReader extends MLReader[LinearRegressionWrapper]
class ExecutorResourceRequest(object):
class ExecutorResourceRequests(object):
class ResourceProfile(object):
class ResourceProfileBuilder(object):
class TaskResourceRequest(object):
class TaskResourceRequests(object):
case class AggregateWithHaving(
abstract class CurrentTimestampLike() extends LeafExpression with CodegenFallback
case class CurrentTimestamp() extends CurrentTimestampLike
case class Now() extends CurrentTimestampLike
case class YearOfWeek(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
case class DatetimeSub(
case class DateAddInterval(
case class Extract(field: Expression, source: Expression, child: Expression)
case class LengthOfJsonArray(child: Expression) extends UnaryExpression
case class JsonObjectKeys(child: Expression) extends UnaryExpression with CodegenFallback
case class Rand(child: Expression, hideSeed: Boolean = false)
case class Randn(child: Expression, hideSeed: Boolean = false)
case class ShowViews(
class CacheManager extends Logging with AdaptiveSparkPlanHelper
case class AdaptiveExecutionContext(session: SparkSession, qe: QueryExecution)
case class ShowViewsCommand(
  class JDBCConfiguration(
class ParquetReadSupport(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122129/
Test FAILed.

Test build #122154 has started for PR 28164 at commit 2cd091e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26825/
Test PASSed.

Test build #122159 has started for PR 28164 at commit f048601.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26831/
Test PASSed.

Test build #122154 has finished for PR 28164 at commit 2cd091e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122154/
Test PASSed.

Test build #122159 has finished for PR 28164 at commit f048601.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122159/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26970/
Test PASSed.

Test build #122300 has started for PR 28164 at commit cc4ee4c.

Test build #122300 has finished for PR 28164 at commit cc4ee4c.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaFValueTestExample

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122300/
Test FAILed.

retest this please

Test build #122309 has started for PR 28164 at commit cc4ee4c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26979/
Test PASSed.

Test build #122309 has finished for PR 28164 at commit cc4ee4c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaFValueTestExample

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122309/
Test PASSed.

cc @HyukjinKwon

cc @gatorsmile

Merged to master and branch-3.0.

@HyukjinKwon Thanks!


Ability to filter ADD / COPY during docker build, based on DIFF

Hi
This follows a short discussion on IRC with @duglin
Goal: Minimize docker images
Method: Not copying files that already exist in the base image (or top layer), unless they are different
Use case:
We have a base image, 'multicloud/common'. It includes a whole bunch of stuff, including a set of files under /workdir/lib (a bunch of .jar files, to be specific).
We use maven to run our builds, and maven copies dependencies to ./lib, for both the 'common' project, and the projects that depend on it. One of these projects, for example, is called 'agent', and is packaged in a docker image called 'multicloud/agent', which is FROM multicloud/common.
As mentioned before, when building 'agent', maven copies all of its dependencies (files) to /lib, including all of those that have been packaged under multicloud/common's workdir/lib.
Of course, in the dockerfile for 'agent', I do a COPY (or ADD) ./lib /workdir/lib.
99% of the files copied, are exactly the same (CRC-wise, and probably timestamp-wise) as those that are already on the top layer of the docker image file system. However, copy-on-write adds them to a new layer, effectively increasing the docker image size (dramatically, in some cases).
It would be great, if docker build's ADD or COPY command, had something similar to 'cp -u' - or even better - something that would calculate CRC32 of the files and copy them only if changed.
IMO this could potentially dramatically decrease image sizes in many other use cases as well.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

ping @docker/maintainers   would like to hear what other people think about this.
Note that this would not impact upload time of the build context as we'd still need to uploaded everything to the daemon, and would increase build time due to the amount of time it would take to do the diff (although we'd probably catch 95%+ of the delta cases quickly by just checking sizes).
Also, since this is about reducing layers I think we need to consider this within the context of the squash discussions.
my 2 cents: until we allow for more control during docker build for people to better control the number of layers created (e.g. via a Dockerfile squash command, or by allowing multiple Dockerfile commands to be run within a layer), I think we need to look for ways to help people in situations like this.
@yaronr question for you... since this seems to be about the number of layers, are you looking to keep your base image separate from the resulting build image so that it can be shared at deploy/runtime, or would you be happy with just a single image that merged your base image with the output of the maven build?  Because, if the latter is ok, then perhaps #13929 might be part of the answer for you.  If the former, then I don't think any of the squash variants discussed so far would help you and you would still need a flag on COPY/ADD.

@duglin I'm interested in keeping the base image separate. The reason is - there are multiple child images that start from this image. Merging kinda misses the whole point in this case.
I have 4-5 images that start from this image. If the base image is shared, and only diffs are persisted on the child images, I save 4-5 X (full - diff) per server that runs these 4-5 images.

I think this makes sense, especially since the focus is on not needlessly copying files that already exist in the fs, rather than anything specifically related to layers.

Interesting proposal. If this can be agreed on, I think this should be used as default, not an "option". +1

If we did add support for --update would it be like cp and just look at timestamps? or would it also take into account the contents? Or just contents ignoring timestamps (like we did for the cache stuff) ?
I can see this one causing lots of discussions.
I'm leaning towards playing it safe and checking both (contents and timestamps (a/c/m-time)).

I would just use the same comparison as checking the context against the image cache.

so just content and not mtime.  Note, that cache would play no role here, just to be clear.

by that I mean, caching would be be used when appropriate, but we can't use the cache as part of this feature.

I should clarify... if content differs, then check time, if content doesn't differ, don't bother.

@cpuguy83 seems backwards, I would check the quick things first, like timestamps, size, etc.. then if all of those matched I would do the time consuming one, diff the contents.

Yeah, ok makes sense. I was thinking about it backwards.

I wonder if time should be taken into account. Chances are that with the use-case described here, all files would still be added if the "copy" step changes timestamps;

when building 'agent', maven copies all of its dependencies (files) to /lib

It's an important decision though; should docker preserve timestamps when COPY/ADD-ing files to a container, or is it okay if a file is not updated if the checksum is the same and only the timestamp differs?

I assumed preserving timestamps was a given, and its the "checking timestamps" question that's the harder one.

maven copies dependencies to ./lib, for both the 'common' project, and the projects that depend on it.
...
when building 'agent', maven copies all of its dependencies (files) to /lib, including all of those that have been packaged under multicloud/common's workdir/lib.

Just so that I understand correctly, the build for multicloud/agent adds files to ./lib that were already present in the multicloud/common base image? In the same location or a different location? In either case, why can't your build script be more knowledgeable about which entries of the context to copy into the container and just not add the ones that you know to already be in the base image?
Perhaps an example Dockerfile would make the problem more clear to me. Also, if the new layers were squashed together then the new layer wouldn't include files that were already present in the same location in the base image rootfs.

Also, if the new layers were squashed together then the new layer wouldn't include files that were already present in the same location in the base image rootfs.

really? If we have /a in a base image, and then in some (or all) of the additional layers a new /a was created, if we then squashed just those new layers (and not the base image), wouldn't the newly squashed layers contain the new /a ?

Also, if the new layers were squashed together then the new layer wouldn't include files that were already present in the same location in the base image rootfs.

really? If we have /a in a base image, and then in some (or all) of the additional layers a new /a was created, if we then squashed just those new layers (and not the base image), wouldn't the newly squashed layers contain the new /a ?

I think that if the file content hasn't changed, and the name and metadata haven't either, then it won't be detected as a change. I'll check just to be certain.

ok that may make sense, I thought you meant it wouldn't be there even if some of those things were changed.  Phew  :-)

This sounds like an optimization. This should not be optional. A differential tree, like rsync, would be optimal, but it can cause file io (reads) on either side.
My only suggestion is that this not be implemented with CRC32. The hash should be sha256.

@jlhawn

Just so that I understand correctly, the build for multicloud/agent adds files to ./lib that were already present in the multicloud/common base image?
Yes. Since multicloud/agent, as well as a number of other projects inherit from multicloud/common, I would like to have a layer that has most of the libraries in it, and then have inheriting projects just add /change what they need.

why can't your build script be more knowledgeable about which entries of the context to copy into the container and just not add the ones that you know to already be in the base image
I'm afraid Maven doesn't know how to look inside docker images and diff. The same goes for many other use cases, btw.

BTW. Just out of curiosity. If I 'touch' a file (just change it's timestamp) in a base image, does it re-copy the file in the created layer? If the file is 100MB, will 'touch' add 100MB to the image?

Hello!
We are no longer accepting patches to the Dockerfile syntax as you can read about here: https://github.com/docker/docker/blob/master/ROADMAP.md#22-dockerfile-syntax
Mainly:

Allowing the Builder to be implemented as a separate utility consuming the Engine's API will open the door for many possibilities, such as offering alternate syntaxes or DSL for existing languages without cluttering the Engine's codebase

Then from there, patches/features like this can be re-thought. Hope you can understand.

Oh well..
On Fri, Jul 10, 2015 at 10:04 PM Jessie Frazelle<EMAIL_ADDRESS>wrote:

Hello!
We are no longer accepting patches to the Dockerfile syntax as you can
read about here:
https://github.com/docker/docker/blob/master/ROADMAP.md#22-dockerfile-syntax
Mainly:
Allowing the Builder to be implemented as a separate utility consuming the
Engine's API will open the door for many possibilities, such as offering
alternate syntaxes or DSL for existing languages without cluttering the
Engine's codebase
Then from there, patches/features like this can be re-thought. Hope you
can understand.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/13982#issuecomment-120495300.


CardsDataTemplateSelector not updating when IsHidden changed.

CardsDataTemplateSelector is working initially but not updating when IsHidden property changed.

Fixed in d950c2a9eb3a0ed750dc7168c67965f5cf9b69c2 fix


Change of TeamsUserActivity report column names

Dear MS Docs,
I noticed  TeamsUserActivity report column names have changed today.  How likely are they to change again?
This change broke a  workflow we have
:-(
Because I'm pretty busy & don't have time to look deeply into this I've assumed the old to -->  new mappings are as follows.  Is this correct?

"MeetingsOrganized" | MeetingsOrganizedScheduledOneTime
"MeetingsOrganizedScheduled" | MeetingsOrganizedScheduledRecurring
"MeetingsOrganizedAdhoc" | MeetingsOrganizedAdhoc
"TotalMeetings" | TotalMeetingsOrganized

     **  new field  | MeetingsParticipatedScheduledOneTime

"MeetingsParticipatedScheduled" | MeetingsParticipatedScheduledRecurring
"MeetingsParticipatedAdhoc" | MeetingsParticipatedAdhoc
MeetingsParticipated? | TotalMeetingsParticipated

?
Jago

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2758a3d6-c646-dcb0-2a31-c7b9b84e780b
Version Independent ID: 8704c9fe-f8b0-82d2-bd83-3fd1a9ad638d
Content: Microsoft Teams user activity report - Microsoft Teams
Content Source: Teams/teams-analytics-and-reports/user-activity-report.md
Service: msteams
GitHub Login: @cichur
Microsoft Alias: v-cichur

@jagobrown @ Please let us know if you still have any question regarding the issue you have raised initially.
The issue is being closed since your question seems to be answered. Feel free to re-open this issue if you feel that it hasn't been answered or that there are further suggestions to improve the documentation itself.
Thanks.

Thanks for response VLG17.  It was useful to have mappings confirmed
It is a really useful/rich report  - so hopefully there will mostly be additional cols added rather than changes to existing in future
Jago


support backend point weight for maglev based on v1.10

Add maglev hash weight feature.
The old pr at https://github.com/cilium/cilium/pull/13943.
This brach rebase from the latest master. We testd using cilium command line tool with kernel 4.19.
@lrouter

@TicktW are you going to push your changes to the #13943 PR?


fix(playground): type error on vite config plugin option

fixed type error
before:

after:

Your node_modules might be stale, try to run pnpm i or remove it then re-run.


nixos-container doesn't have restart subcommand

Issue description
Instead of nixos-container restart test I have to write for i in stop start; do nixos-container $i test; done. This isn't critical, but is very incovenient
Technical details

System: 16.03.1025.17a777c (Emu)

It is possible to directly use systemctl as a workaround:
$ systemctl restart container@test

Ok, I'll use this workaround, but leave issue open ("inconvenient" part).

Actually, because of some quirks, systemctl restart isn't same as stop && start
root@iron-test ~$
# systemctl stop container@pvk

root@iron-test ~$
# systemctl start container@pvk

root@iron-test ~$
# systemctl restart container@pvk
Job for<EMAIL_ADDRESS>failed because the control process exited with error code.
See "systemctl status<EMAIL_ADDRESS>and "journalctl -xe" for details.

Sep 06 10:23:03 iron-test container pvk[28672]: Sending SIGTERM to remaining processes...
Sep 06 10:23:03 iron-test container pvk[28672]: Sending SIGKILL to remaining processes...
Sep 06 10:23:03 iron-test container pvk[28672]: Powering off.
Sep 06 10:23:03 iron-test container pvk[28672]: Container pvk has been shut down.
Sep 06 10:23:03 iron-test systemd[1]: Stopped Container 'pvk'.
Sep 06 10:23:03 iron-test systemd[1]: Starting Container 'pvk'...
Sep 06 10:23:03 iron-test container pvk[29093]: Spawning container pvk on /var/lib/containers/pvk.
Sep 06 10:23:03 iron-test container pvk[29093]: Press ^] three times within 1s to kill container.
Sep 06 10:23:03 iron-test container pvk[29093]: /etc/localtime does not point into /usr/share/zoneinfo/, not updating container timezone.
Sep 06 10:23:03 iron-test container pvk[29093]: Failed to register machine: Machine 'pvk' already exists
Sep 06 10:23:03 iron-test systemd[1]<EMAIL_ADDRESS>Main process exited, code=exited, status=1/FAILURE
Sep 06 10:23:03 iron-test container pvk[29107]: cat: /run/containers/pvk.pid: No such file or directory
Sep 06 10:23:03 iron-test systemd[1]<EMAIL_ADDRESS>Control process exited, code=exited status=1
Sep 06 10:23:03 iron-test systemd[1]: Failed to start Container 'pvk'.
Sep 06 10:23:03 iron-test systemd[1]<EMAIL_ADDRESS>Unit entered failed state.
Sep 06 10:23:03 iron-test systemd[1]<EMAIL_ADDRESS>Failed with result 'exit-code'.

I'm running containers in machine, provisioned via NixOps, if that does matter.

fixed in https://github.com/NixOS/nixpkgs/pull/39717


CLOUD-56717 make salt scripts aware of upstart

@akanto

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2492/


OTT fixes

Just need to confirm world blacklist is working but should fix existing issues

This would seem to grant everyone a single use of OTT regardless of whether they're a new player or have been playing since SOTW. It also removes any time limit on the use of OTT, meaning that, in a year's time, they could possibly use this to get out of a sticky fight in a war.

Superseded by #70 , if we want the dimension blacklist this PR will need to be redone I believe?

Superseded by #70 , if we want the dimension blacklist this PR will need to be redone I believe?

Yeah, the dimension blacklist felt like an XY solution: that the goal was to fix pealed players from OTT'ing out of the nether, so the proposed solution here was to blacklist the nether. I figured it'd be better to check whether the player is pearled instead. I also added a configurable option to limit OTTs to within the same world. But yes, if you'd like to prevent OTTs to and from the nether regardless, this PR could serve as the addition to that feature, after having rebased, of course.

Already fixed a while ago


Modification of the method "replaceAtIndex" in Navigator.js to allow adding new routes to the end and creation of new method "removeAtIndex"

replaceAtIndex
Old behavior:

if specified index is smaller than currentRouteStack.length, it will replace existing route
if specified index is equal to currentRouteStack.length, it will return
if index is larger than currentRouteStack.length, it will return

New behaior:

if specified index is smaller than currentRouteStack.length, it will replace existing route
if specified index is equal to currentRouteStack.length, it will add a new route to the end of the routeStack
if index is larger than currentRouteStack.length, it will return

Test:

Used the following app for testing: https://rnplay.org/apps/cm53mA/

removeAtIndex

added new method "removeAtIndex" which deletes a route from the routeStack specified by its current index

I think the change to replaceAtIndex looks totally reasonable.
I'm a bit concerned about removeAtIndex, mostly because I want to keep complexity down right now, and this will expose us to more edge cases. Do you have a strong use case for the new method?
It will be easier to commit the replaceAtIndex change in a separate PR from removeAtIndex

Hi,
I currently have a scenario in which I need to remove routes from the routeStack without being able to use pop - especially after adding them via the new replaceAtIndex method.
Basically IMO its the counterpart to the (new) replaceAtIndex method and would thus make sense to exist as well.
Anyway, I can make two PRs out of it, but Id prefer to handle any edge cases you can think of in the remiveAtIndex method. :)

Am 03.08.2015 um 16:33 schrieb Eric Vicenti<EMAIL_ADDRESS>I think the change to replaceAtIndex looks totally reasonable.
I'm a bit concerned about removeAtIndex, mostly because I want to keep complexity down right now, and this will expose us to more edge cases. Do you have a strong use case for the new method?
It will be easier to commit the replaceAtIndex change in a separate PR from removeAtIndex
—
Reply to this email directly or view it on GitHub.

Especially because i cant use popToRoute() as this will remove ALL routes between the route i come from and the target route and not only the route I come from.

Am 03.08.2015 um 16:33 schrieb Eric Vicenti<EMAIL_ADDRESS>I think the change to replaceAtIndex looks totally reasonable.
I'm a bit concerned about removeAtIndex, mostly because I want to keep complexity down right now, and this will expose us to more edge cases. Do you have a strong use case for the new method?
It will be easier to commit the replaceAtIndex change in a separate PR from removeAtIndex
—
Reply to this email directly or view it on GitHub.

@hedgerwang, any thoughts on this?

@PhilippKrone: there are some edge cases such as the nagative index used and it matches no route.
In the new API that we're working on, the index has to be a valid index that must match a route in the stack otherwise it will throw an "IndexOutOfBound" Error.
By default, we don't want to make the navigation too tolerant with navigation error (e.g. invalid index, invalid route, ...etc). However developer can escape  the navigation errors easily by using the default API to do that.
For instance, your case can do done via something like this:
class Example extends React.Component {
  doAction(route, index) {

    var navigationContext = this.context.navigationContext;
    var maxIndex = navigationContext.routeStack.size - 1;
    if (index === maxIndex) {
      // if the specified index is equal to currentRouteStack.length,
      // it will add a new route to the end of the routeStack
      navigationContext.push(route);
      return;
    }

    if (index <= maxIndex) {
      // if specified index is smaller than currentRouteStack.length,
      // it will replace existing route
      navigationContext.replaceAtIndex(route, index);
      return;
    }
  }
}

Alternatively, we're building an event system that shall allow you to implement the same behavior with something like this:
class Example extends React.Component {
  componentDidMount() {
    this.context.navigationContext.addListener(
      'action',
      this._onNavigationAction
    );
  }

  _onNavigationAction(event: NavigationEvent) {
    if (event.data.action !== 'replace') {
      return;
    }

    if (event.target !== this.context.navigationContext) {
      return;
    }

    var navigationContext = event.target;
    var index = event.data.index;

    if (index >= navigationContext.stack.size) {
      // stop the `replace` action.
      event.preventDefault();
    }

    if (index === navigationContext.stack.size) {
      // if specified index is equal to currentRouteStack.length, it will add a
      // new route to the end of the routeStack
      // this shall emit another event loop for the action `push`.
      navigationContext.push(event.data.route);
      return;
    }
  }

  doAction(route, index) {
    // this shall emit an event loop for the action `replace`.
    this.context.navigationContext.replaceAtIndex(route, index);
  }
}

Note that different people may want to build different navigation system that
behaves differently, and we should enable people to do that instead of forcing
people to adapt to only one type of behavior.

@hedgerwang thanks for your reply. The new API looks really good, looking forward to that. However, I'm currently unable to see the connection to the new methods I have written. Basically those two new (one new and one modified) methods give you the possibility to add and remove new routes to a route stack, which will - as far as I understand your code examples - not be possible with the new API as well.
What I basically need is to be able to modify the route stack without doing any kind of transitions, including adding and removing routes. The way I tried to code the new methods is exactly to allow:

Note that different people may want to build different navigation system that
behaves differently, and we should enable people to do that instead of forcing
people to adapt to only one type of behavior.

so that everyone can use them the way they need it for their navigation behaviour. Up to now, there are some things that are not possible with the current implementation (as e.g. easily adding / removing routes without transition, and some other things).
Concerning the negative indizes: I can gladly remove that from the coding, I was just adding it out of consistency reasons with the other methods. I've never used it to be honest. :)

@ericvicenti @hedgerwang How shall we continue here? :)

@PhilippKrone :
If specified index is equal to currentRouteStack.length, it will add a new route to the end of the routeStack
My concern is that we'll break your code by throwing IndexOutOfBound Error in the upcoming version.
IMHO, it's safer to write a helper function that handles this type of customization separately:
For instance:
// make your own navigation logic here.
function replaceAtIndex(navigator, route, index) {
  var length = navigator.getCurrentRoutes().length;
  if (index === length) {
    navigator.push(route);
  } else if (index < length) {
    navigator.replaceAtIndex(route, index);
  }
}

@hedgerwang I get that, but the point is that your and my code have a different functionality: My code adds something to the routeStack without transitioning to it. Same with removing from routeStack without having a transition (nor a scene change). Contrary to that, your code (using push()) automatically transitions towards the new scene - what I dont want. Currently, there is no way to manipulate the routeStack (except replacing existing routes) without triggering an active route change. I'm adding this functionality with my PR.
Concerning breaking my code by throwing IndexOurOfBound errors: perhaps then we should add a function "addSceneToRouteStack" which adds to the end of the routeStack and which does not trigger the "IndexOutOfBound" error?

@hedgerwang with navigator.push the route is being added to the route stack after the active route, not at the end of the route stack:
https://github.com/facebook/react-native/blob/master/Libraries/CustomComponents/Navigator/Navigator.js#L908-L912
var activeLength = this.state.presentedIndex + 1;
    var activeStack = this.state.routeStack.slice(0, activeLength);
    var activeAnimationConfigStack = this.state.sceneConfigStack.slice(0, activeLength);
    var nextStack = activeStack.concat([route]);

Routes in the route stack after the current active route are deleted.
Is there a way of adding a route to the end of the route stack without @PhilippKrone 's solution?

@PhilippKrone : Would  navigagtor.immediatelyResetRouteStack help?
// adds something to the routeStack without transitioning to it.
var routes = navigagtor.getCurrentRoutes();
var index = routes.indexOf(navigator.getNavigationContext().currentRoute);
routes.push(route);
navigagtor.immediatelyResetRouteStack(routes);
navigatro.jumpTo(index);

@hedgerwang I get an error that navigator.getNavigationContext() is not a function.

@nikhilaravi
Sorry I forgot that navigator.getNavigationContext isn't a valid public API yet.
Please use navigator.navigationContext instead.

@hedgerwang would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

@ericvicenti : this PR looks reasonable to me. We can accept it.

@PhilippKrone : this PR has some conflicts. could you please update your PR? thanks.

In this case, I believe the navigator is getting deprecated in favor of NavigationExperimental, would it make sense to make the changes there?

@PhilippKrone do you have any updates for this pull request? It's been a while since the last update so wanted to check in and see if you've looked at the requested changes.

This pull request hasn't seen activity in a while. If you still want to merge this, please open a new pull request.


exports StatusList to leverage revocation utility methods

This PR addresses this issue by exporting StatusList in order to leverage revocation utility methods.

Thanks! I'll push out a new release with this in it shortly.

No problem and thanks for the prompt release @dlongley! Also, for what it's worth, after playing around with this library a bit more, I realized that the decodeList function exported from main.js returns a fresh instance of StatusList, which can then be used to access all instance methods in StatusList. This means that we should not really need this update, but I suppose it doesn't hurt to keep it.


Please add free private Channels

There are lots of private german and international Channels, which are accessible for free online from the Channels homepages or the channels youtube pages - without geoblocking, for example the german News Channel N24, Euronews (Germany), MTV, France24, Sky TG24 Italia, RAINews24, BBC World News, Franceinfo and others. Please add these Channels.

Sorry, but I won't do that. The legal situation is wonky enough without adding private channels.


listenlocalhost test fails on ARM Linux

The same issue didn't allow me to use passivedns-rs.
The final part of the strace looks like this:
socket(PF_PACKET, SOCK_DGRAM, 768)      = 3
ioctl(3, SIOCGIFINDEX, {ifr_name="lo", ifr_index=1}) = 0
setsockopt(3, SOL_PACKET, PACKET_AUXDATA, [1], 4) = 0
getsockopt(3, SOL_PACKET, PACKET_HDRLEN, [36], [4]) = 0
setsockopt(3, SOL_PACKET, PACKET_VERSION, [2], 4) = 0
setsockopt(3, SOL_PACKET, PACKET_RESERVE, [4], 4) = 0
setsockopt(3, SOL_PACKET, PACKET_RX_RING, "\0\0\2\0\20\0\0\0\0\0\2\0\20\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", 28) = 0
mmap2(NULL, 2097152, PROT_READ|PROT_WRITE, MAP_SHARED, 3, 0) = 0xb6ae1000
setsockopt(3, SOL_SOCKET, SO_ATTACH_FILTER, "\1\0\0\0\374\341\352\266", 8) = 0
fcntl64(3, F_GETFL)                     = 0x2 (flags O_RDWR)
fcntl64(3, F_SETFL, O_RDWR|O_NONBLOCK)  = 0
recv(3, 0xbeb81234, 1, MSG_TRUNC)       = -1 EAGAIN (Resource temporarily unavailable)
fcntl64(3, F_SETFL, O_RDWR)             = 0
setsockopt(3, SOL_SOCKET, SO_ATTACH_FILTER, "\32\0\0\0008\345\362\266", 8) = 0
setsockopt(3, SOL_PACKET, PACKET_RX_RING, {block_size=0, block_nr=0, frame_size=0, frame_nr=0}, 16) = -1 EINVAL (Invalid argument)

Was using crate version 0.5.6 and rust 1.10.
The savefile test also fails, like this:
# RUST_BACKTRACE=1 target/debug/examples/savefile
thread '<main>' panicked at 'called `Result::unwrap()` on an `Err` value: TimeoutExpired', src/libcore/result.rs:785
stack backtrace:
   1: 0xb6f72a57 - std::sys::backtrace::tracing::imp::write::h82353b94d9957b5a
   2: 0xb6f73a97 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hd08c9fd28a21a931
   3: 0xb6f7374f - std::panicking::default_hook::h9f5ce461fe95b992
   4: 0xb6f73c8b - std::panicking::on_panic::h72ebaabe6df491a5
   5: 0xb6f748d7 - std::sys_common::unwind::begin_unwind_inner::hf3b309d035c8a630
   6: 0xb6f75263 - std::sys_common::unwind::begin_unwind_fmt::h93bb4d1d4be19775
   7: 0xb6f751af - rust_begin_unwind
   8: 0xb6f81133 - core::panicking::panic_fmt::h5f695b461e45588f
   9: 0xb6f688fb - core::result::unwrap_failed::h04300aeb8da3ddc6
                at src/libcore/macros.rs:29
  10: 0xb6f6abfb - _<std..result..Result<T, E>>::unwrap::hbf942d7177bccc5a
                at src/libcore/result.rs:723
  11: 0xb6f682eb - savefile::main::heb6383c973898e7a
                at examples/savefile.rs:14
  12: 0xb6f75c03 - std::sys_common::unwind::try::hcfd1e9f9a0a0d375
  13: 0xb6f758ef - std::rt::lang_start::h801b666f82634252
  14: 0xb6f6bbcf - main
  15: 0xb6dd0631 - __libc_start_main

@ebfull Any suggestions? BTW, does this crate put any constraints on the underlying library version?

Not sure! I don't have an ARM development device to test with. :(

It's your regular ARM Linux and the pcap library works OK with the C version of passivedns. That's why I asked about the library version the crate might expect.

@petevine Why closed?


map is not stable.

I am new to Node-Red & use  worldmap.
When first time deploy, it's usually fine. But I try to close explorer to reconnect,it often failed to show map.
For now, when I find failed,I redeploy. It's so bad idea.
Please help me to  solve it. Thanks a lot.
node version : V12.21.0
node-red  version: V1.2.9
node-red-contrib-web-worldmap   version : 2.12.1
error message is as attach file.

I use the sample of  embed Map in Dashboard.
When embed Map failed, I try Ctrl+Shift+M  it works fine.

None of those errors relate to the map - and are not significant.
You need to inject the info to the template AFTER the map has connected. The easy way to do that is to either use a worldmap in node set to output connect events only - to trigger the sending of the data. Or to use a dashboard worldmap node

In general it is much easier to get help via either slack or the discourse forum, leaving the issues for actual code issues. thanks


:bug: fix debugger single-instruction stepping mode

This PR fixes the single-instruction (stepi) stepping issue explained in https://github.com/stnolting/neorv32/pull/327#issuecomment-1140450822: when doing single-instruction-stepping the debugger does not halt at every single instruction.
ℹ This bug has been introduced with version <IP_ADDRESS> by PR https://github.com/stnolting/neorv32/pull/327.

Hey @GideonZ,
I need to get this merged to continue with some other hardware modifications. I have tested this PR and I could not find any situations where we have the concurrent trap situation again.
However, if you happen to find any problems with the modifications please let me know. :wink:


Flat normals calculation of obj without normals

Now is possible to execute the loading with normals calculation. These normals nowadays are flat, I am looking for a smooth normals calculation.
Regards,
Alejandro

Coverage decreased (-50.4%) to 0.0% when pulling 0dcc72239d9f593b7347ed45ce2d71feefff3f6b on Vazquinhos:master into 9c81fcb4ccd58eeac762543ac1f55edec3f412fc on syoyo:master.

Coverage decreased (-2.4%) to 47.943% when pulling 9aee576b99e38f05cc2e3af804650484358fe3b8 on Vazquinhos:master into 9c81fcb4ccd58eeac762543ac1f55edec3f412fc on syoyo:master.

Cool! Thanks!


Add favicon

Add path to a favicon in base.html.
Add the icon itself to the static dir.
Make sure the header data type is an icon in the HTML.
Use the jinja markup for static files.

on it :)