Having a few issues with LedFX

Hi there, I've been testing out LED FX and have run into a few issues so far that have made my experience pretty unimpressive
I'm on a Mac using Chrome, if that matters. ledfx 0.7

The lack of any notion of range for any of the settings is really confusing. The default brightness value is 1, does that mean it's 0-1? The default blur setting is empty, what range is allowed? If the value ranges are consistent, why aren't there sliders?
The form error checking prevents me from typing any values between 0 and 1. I've noticed some settings do have values between 0 and 1, but when I try to type in another setting, the form doesn't enter anything for "0" and then when I type "." it goes NaN. This can be worked around by pasting in a value, but this is not a good experience obviously
I think there's something wrong with thee way the audio is processing my mic. I'm a bit confused because I thought this had a non-web version of the app, but there are some caveats when using mics from a browser. Basically my mic only seems to be picking up bass, and not a lot of it. This means that 90% of the time the reactive effects are lighting upu the first 10% of my strip only, even when playing music loud. I'm going to make an assumption that you're using the webkit audio API. Having tinkered with it a bit myself, I'm wondering if maybe you need to disable echoCancellation and noiseSuppression otherwise the music is low-passed. It's not really well documented but here's a stack overflow post with (some info)[https://stackoverflow.com/questions/29936416/webrtc-disable-all-audio-processing]
Lastly I noticed in my STDERR after playing around that there's a consistent AttributeError: Couldn't find 'wavelength' in the effect registry that gets logged, presumably when I tried to load that effect.

oh also, ledfx initially completely failed to start when I first ran it with the following error:
$ ledfx
Loading configuration file from /Users/rclough/.ledfx
Traceback (most recent call last):
  File "/Users/rclough/.pyenv/versions/ledfx/bin/ledfx", line 8, in <module>
    sys.exit(main())
  File "/Users/rclough/.pyenv/versions/3.6.9/envs/ledfx/lib/python3.6/site-packages/ledfx/__main__.py", line 88, in main
    ledfx = LedFxCore(config_dir = args.config)
  File "/Users/rclough/.pyenv/versions/3.6.9/envs/ledfx/lib/python3.6/site-packages/ledfx/core.py", line 39, in __init__
    port=self.config.get('port', None))
  File "/Users/rclough/.pyenv/versions/3.6.9/envs/ledfx/lib/python3.6/site-packages/ledfx/http.py", line 26, in __init__
    host = socket.gethostbyname(socket.gethostname())
socket.gaierror: [Errno 8] nodename nor servname provided, or not known

I went and tested some of the code by hand. socket.gethostname() returns my username for my macbook, which maybe my organization sets as my hostname? but in any case, it was not able to resolve this name because it is not an actual host name. I had to add it to my /private/etc/hosts file pointing to <IP_ADDRESS> to get it to work, not super obvious.
I'd suggest just defaulting to <IP_ADDRESS> since that's pretty standard, not sure if there's a more canonical way of achieving that this code is trying to do, but I've run a lot of software on this laptop and never run into that issue before.

I don't know much about anything, but the web interface is just that, an
interface, no audio is processed through the browser. Try listening to the
input you have plugged in, likely you don't have the correct cable and the
input isn't getting the full spectrum of sound. Can you record the music
you are playing and play it back?
Also remember this is open source software provided at no charge made by
people for no monetary gain. yeah its rough around the edges, but in my
opinion its pretty fucking rad.
Adrian Stucker
513.341.LENS
On Mon, Sep 28, 2020 at 6:59 PM Ryan C<EMAIL_ADDRESS>wrote:

oh also, ledfx initially completely failed to start when I first ran it
with the following error:
$ ledfx
Loading configuration file from /Users/rclough/.ledfx
Traceback (most recent call last):
File "/Users/rclough/.pyenv/versions/ledfx/bin/ledfx", line 8, in
sys.exit(main())
File "/Users/rclough/.pyenv/versions/3.6.9/envs/ledfx/lib/python3.6/site-packages/ledfx/main.py", line 88, in main
ledfx = LedFxCore(config_dir = args.config)
File "/Users/rclough/.pyenv/versions/3.6.9/envs/ledfx/lib/python3.6/site-packages/ledfx/core.py", line 39, in init
port=self.config.get('port', None))
File "/Users/rclough/.pyenv/versions/3.6.9/envs/ledfx/lib/python3.6/site-packages/ledfx/http.py", line 26, in init
host = socket.gethostbyname(socket.gethostname())
socket.gaierror: [Errno 8] nodename nor servname provided, or not known
I went and tested some of the code by hand. socket.gethostname() returns
my username for my macbook, which maybe my organization sets as my
hostname? but in any case, it was not able to resolve this name because it
is not an actual host name. I had to add it to my /private/etc/hosts file
pointing to <IP_ADDRESS> to get it to work, not super obvious.
I'd suggest just defaulting to <IP_ADDRESS> since that's pretty standard, not
sure if there's a more canonical way of achieving that this code is trying
to do, but I've run a lot of software on this laptop and never run into
that issue before.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ahodges9/LedFx/issues/136#issuecomment-700378819, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJFUGINLD2YF5ECFFRVBLDTSIE5QJANCNFSM4R5F7WHA
.

Ah, I made the assumption that since it was a web interface that it would be using WebRTC, but makes sense that it's pulling the inputs directly from the system. No idea then why then the audio input is poor - it's a pretty standard macbook mic, which should have a decent spectrum of sound
And yes, I know, I work on open source as well, bugss do need to be reported, I'm trying to be constructive

No mater what having the macbook mic capturing sounds you'll never get good
results. It really needs a direct line in, or if you are playing music off
the computer, use a virtual line in. I'm on pc but I'm sure there's a
solution for mac.
Adrian Stucker
513.341.LENS
On Mon, Sep 28, 2020, 7:26 PM Ryan C<EMAIL_ADDRESS>wrote:

Ah, I made the assumption that since it was a web interface that it would
be using WebRTC, but makes sense that it's pulling the inputs directly from
the system. No idea then why then the audio input is poor - it's a pretty
standard macbook mic, which should have a decent spectrum of sound
And yes, I know, I work on open source as well, bugss do need to be
reported, I'm trying to be constructive
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ahodges9/LedFx/issues/136#issuecomment-700387712, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJFUGIJJML2BD2GS6OECND3SIFAW7ANCNFSM4R5F7WHA
.

Hey guys,
We have done quite a bit of development and documentation work. Have a look at the readme on: https://github.com/ahodges9/LedFx/tree/dev & https://ledfx.readthedocs.io/en/docs/index.html
Your welcome to join the LedFx community on Discord and we can help you out from there: https://discord.com/invite/wJ755dY
Have a discord chat with THATDONFC, as he is our mac dev expert.


may share links to similar functionality code but in python?

may share links to similar functionality code but in python?

I'm afraid I don't have any examples, but perhaps other people can post here if they do.


Move eight_mile out of the repo and put on PyPI

We want to move eight mile to its own repo, we should use git submodules to make this move transparent to users but we should also put the package on pypi and in the baseline setup.py include it as an install requires

We decided to leave it in the repo for now but have it as a separate pip install-able thing, uploading to pypi is going to be done at the same time as all of mead-baseline


PowerToys does not work at all

Microsoft PowerToys version
0.63.0
Running as admin

[X] Yes

Area(s) with issue?
Always on Top
Steps to reproduce
microsoft OneNote application always on top does not work
✔ Expected Behavior
No response
❌ Actual Behavior
when i use onenote book (office 2016) its firstly work but when i type something  then i go another screen  it's does not work
Other Software
No response

The issue happens because OneNote resets topmost flag for some reason.
/dup of https://github.com/microsoft/PowerToys/issues/19168


Permission error

Hello,
I´m trying to install pyautogui and while the installation I got a Permission error. Is there a sudo like command to solve this issue?

pyautogui will not work on an iPhone.

Ok, is there another library that can do this? Or is it just not possible?

Apple’s app sandboxing will prevent this. There might be some options if you jailbreak your device, but even then they will not be Python.
(I am assuming you have exhausted the possibilities of Shortcuts automations.)

I am closing the issue, since pyautogui isn't supported and there hasn't been any further discussion for nearly 2 month. Please re-open if necessary.


generated decoding function is broken?

Hi,
given following cddl file:
handshake_response = (
    return_code: int,
    protocol_version: bstr .size 41
)
diversify_response = (
    return_code: int,
    key: bstr .size 16
)
;---
response_payload = diversify_response
                  / handshake_response

protocol_response = (
    request_id: uint,
    payload: response_payload
)

And this sample code:
    protocol_response response = {
        .request_id = 22,
        .payload  =
        {
            .diversify_response_m = {
                .return_code = 0,
                .key = {
                    .value = (std::uint8_t*)"1234567891234567",
                    .len = 16,
                },
            },
            .response_payload_choice = response_payload_r::response_payload_diversify_response_m_c,
        }
    };

    uint8_t buff[100];
    size_t len_out = 0;
    cbor_encode_protocol_response(buff, sizeof(buff), &response, &len_out);

    protocol_response r2 {};
    cbor_decode_protocol_response(buff, len_out, &r2, nullptr);
    printf("type: %d\n", r2.payload.response_payload_choice);
    printf("%s", response.payload.handshake_response_m.protocol_version.value);

The decoded r2.payload.response_payload_choice is wrong. This has to do with the generated code. Because it first attempts to decode a handshake_response and then sets the response_payload_choice  accordingly. Since both types have the same layout it will decode a handshake_response even though a diversify_response was encoded. In my opinion it should have fist looked at the enum value and then attempted to decode the correct type...

Hi, I'm not sure I understand. When I run your code (after converting to C), it prints
type: 0
1234567891234567%

which is what I expect (0 is response_payload_diversify_response_m_c).

In my opinion it should have fist looked at the enum value and then attempted to decode the correct type...

The only way to differentiate between handshake_response and diversify_response is by the length of the bstr, so it has to decode the bstr to differentiate. The enum value found in the struct is created by zcbor and is not encoded in the data. The data is only what the CDDL says, i.e. an int followed either by a 41-byte or a 16-byte bstr. If you want an "enum value" to differentiate by, you can add a literal to the CDDL, e.g.:
handshake_response = (
    id: 1,
    return_code: int,
    protocol_version: bstr .size 41
)
diversify_response = (
    id: 2,
    return_code: int,
    key: bstr .size 16
)


Move & rename check for problem to display

Changes Unknown when pulling dba1f968b0ce152f80eb3f8b89c179edf1aa8bbe on giulio/fix-invideoquiz-js into ** on master**.

Changes Unknown when pulling 711472fc86adf23215ed8c988c1b58d19ba71948 on giulio/fix-invideoquiz-js into ** on master**.


[Feature Request] FlowController<T> should implement ValueListenable<T> instead of Listenable

Is your feature request related to a problem? Please describe.
Currently flow_builder can't be used to build widgets. Although flow_builder's responsibility is building the navigation stack, users could also benefit from being able to use ValueListenableBuilder with a FlowController.
Describe the solution you'd like
FlowController<T> should implement ValueListenable<T> instead of Listenable.
The only downside is this would force FlowController to override ValueListenable's value. Right now the value's role is played by the state property. Couple of options to overcome this:

override value with:

@override
T get value => _notifier.value;

and leave the rest of the implementation as it is. Weird solution to say the least, but I guess it's the only way to keep the state naming 🙄

override value with:

@override
T get value => _notifier.value;

and deprecate state for the next release; we could then remove state and keep value to better align with flutter naming conventions. I'd prefer this route.
If you like this change I'm willing to open a PR.

@narcodico thanks for opening an issue!
There have been some recent changes to refactor FlowController to extend ChangeNotifier rather than to implement Listenable (see #61). As a result, you should be able to use an AnimatedBuilder with the FlowController to rebuild some UI based on the state (available in flow_builder v0.0.5).
Let me know what you think, thanks!

@felangel that will also do the job! 👍

Awesome, closing for now but let me know if you have any additional feedback/suggestions and I'm happy to reopen this 👍


Fix table location URL

What changes are proposed in this pull request?

If the table is created from a URI, and that URI does not end with a trailing slash, then subsequent operations (i.e. deriving the path to the _delta_log folder) overwrite the last URL path segment.
The implemented fix is not very "nice", I'd be happy to do a more elaborate fix (e.g. wrapping table location in a newtype and exposing methods like delta_log(), last_checkpoint(), etc. All depending on your appetite for change and review bandwith of course.

How was this change tested?

Added unit test

Thanks, this is a good catch. I don't love that "feature" of the url crate, but we do need to work within it. I think it would make more sense though to do this in resolve_uri_type

I tend to agree... pushing it down would fix path handling as well, tho maybe our path handling was already hardened previously?
Code golf nitpick:

you could do something like:
    let url = if table_uri.ends_with('/') {
        Url::parse(table_uri)
    } else {
        let mut s = table_uri.to_string();
        s.push('/');
        Url::parse(&s)
    };
    if let Ok(url) = url {
...

Or just
let table_uri = if table_uri.ends_with('/') {
  Cow::Borrowed(table_uri)
} else {
  Cow::Owned(format!("{table_uri}/"))
}
if let Ok(url) = Url::parse(&table_uri) {

Thanks for the suggestions - applied the changes. From my personal experience, the subtle differences between std::path::Path, url::Url and object_store::path::Path often lead to little bugs like these!


Revert "[docs] Fix layout regression"

Reverts mui-org/material-ui#27266 which was accidentally merged. There was no reproduction provided and we don't merge "fixes" that are unconfirmed.
Broke layout on

Chrome Version 91.0.4472.114 (Official Build) (64-bit) Ubuntu 20.04
Firefox Version 89.0.2 Ubuntu 20.04
Chrome Version 91.0.4472.114 (Official Build) (64-bit) macOS Catalina
Safari Version 14.1.1 (Official Build) (64-bit) macOS Catalina

@eps1lon Nice spotted, I can reproduce the issue on the API pages. 👍 for fixing it. If we revert this one, I propose, we revert the issue from the root: #27138. Otherwise, we can work on a solution that cover these two constraints.

We can revert https://github.com/mui-org/material-ui/pull/27138 once we have identified the issue.

@eps1lon Nice spotted, I can reproduce the issue on the API pages.

This reproduces on /api, /components, /guides etc. Including the page that was you claimed was fixed.

The PR leads to this issue:

Open https://deploy-preview-27269--material-ui.netlify.app/guides/migration-v4/ on any browsers, make sure your window is over 1200px
See that the toc is not visible

I might have figured out why you couldn't reproduce my bug report, and why I couldn't understand what information was missing. It seems that it's about the screen width. Do you have a large display by any chance? Mine is small. I have updated https://github.com/mui-org/material-ui/pull/27269#issuecomment-879765203 accordingly.

We can discuss the repro of the your bug somewhere else. The screen size is not the problem. I've resized all the way from 1px to 2510px and could not reproduce it. You're missing some more information about your environment. Might be pixel density.

It's especially confusing since now you report a different issue. I can only encourage you to go through the bug report steps since you seem to be unable to write a coherent bug report.


Process territory subdivisions only for CLDR 32+

What is your motivation for not including them? I can think of a few pros and cons, but I'm just curious.
The subdivision names in CLDR 31 were English only (except for England, Scotland and Wales), but the subdivisionContainment was present.

What is your motivation for not including them?

As you guessed, the subdivision names in CLDR 31 were only in English. IMHO it's better to not offer a feature if we don't have the data
You didn't add the subdivisions data to the docs\1\31 directory

Off course, I'm not authoritative with this pull request... Well, I'm never authoritative, I usually only express what I think and I'm very open to other opinions :wink:

Makes sense :-) There probably wont be anybody using the next version of Punic who wants to use an older version than CLDR 32.


clear global_context after shutdown

The global_context incrementally generates the fed task id. It should be reset after calling fed.shutdown so that the fed task id can grow from 0 again.

One potential risk is that in multiple controller mode, we don't barrier the controll flow at the node fed.shutdown, so party A may send a fresh data from the new session, but another party is still receiving the old data.

Indeed, I've considered this case, will file a new issue and mention it in the next coming barrier PR.

Indeed, I've considered this case, will file a new issue and mention it in the next coming barrier PR.

Great! Maybe you could take a look at this one https://github.com/ray-project/rayfed/issues/66 , which is similar.


How to Trigger a Function when Scrolling to an Element in React Intersection Observer

Proposed title of article
How to Trigger a Function when Scrolling to an Element in React Intersection Observer
Proposed article introduction
You can detect if someone scrolled to an element by adding an event listener that fires a function any time someone scrolls. But that alone doesn’t give us a lot to work with, still needing a way to figure out where on the page we’re at, and it can end up eating precious resources without complicated throttling or debouncing problems.
Instead, we can use the intersection observer which provides a way to asynchronously observe changes in the intersection (overlapping) of elements. This can be in relation to other elements, or the viewport. In this article, we’ll take a look at a few demos and discuss the relevance that Intersection Observer will play in the future for web developers.
Key takeaways

Creating a new Next.js app from a demo starter
Accessing DOM node Ref in React with UseRef and UseState
Using intersection observer to detect when HTML element is in view
Storing visibility status of an element with UseState
Using the React intersection Observer hook to detect visibility
Triggering a CSS element when an element is in view

Article quality
This article will give the learner a step-by-step guide on how to  Trigger a Function when Scrolling to an Element in React Intersection Observer and an overview of  Intersection Observer  along with its features.
References
N/A

Good afternoon and thank you for submitting your topic to the EngEd program.
After some careful consideration, it struck us that this topic may be a bit over-saturated throughout other blog sites and official documentations.
We typically refrain from publishing content that is covered widely on the net or other blogs. We're more interested in original, practitioner-focused content that takes a deeper dive into programming-centric concepts.
But in order to approve the topic, it has to serve value to the larger developer community at large.
An option and a great way to write this as an in-depth article and make it more add value to the greater developer community at large would be to walk the reader through the USE of methods and functions by building a unique, different, useful project.

We would love to learn your thought process behind the solution you arrived at using these concepts and topics.

That way a developer could see them in action.
As mentioned above - we believe this topic is widely covered on other blog sites.
The best way for students to build a great portfolio is by building what does not exist and what can provide the most value.


Vector store feature: improve test coverage

Hybrid search

[ ] one basic test with every embedder

[x] user provided
[x] Hugging Face
[x] OpenAI

[x] basic test
[x] search with wrong API key
[x] search with very long query

[x] REST

[x] basic test
[x] search with wrong API key
[x] search with wrong URL

[ ] ollama

[ ] basic test
[ ] search with wrong API key
[ ] search with wrong URL

[x] passing wrong vector dimensions
[ ] test all q, vector, hybrid configurations:

Tested/Configuration
q
vector
hybrid

❌
missing
missing
missing

✅
missing
missing
present

❌
missing
present
missing

✅
missing
present
present

❌
present
missing
missing

✅
present
missing
present

✅
present
present
missing

✅
present
present
present

[x] test offset and limit
[ ] test page and hitsPerPage
[ ] test attributesToRetrieve
[x] test retrieveVectors
[ ] test attributeToCrop
[ ] test cropLength
[x] test attributesToHighlight
[ ] test filter
[ ]  test showMatchesPosition
[x] test showRankingScore
[x] test showRankingScoreDetails
[ ] test sort
[ ] test distinct
[ ] test facets
[x] test highlight_pre_tag
[x] test highlight_post_tag
[x] test crop_marker
[ ] test matchingStrategy
[ ] test attributesToSearchOn
[x] test rankingScoreThreshold
[ ] test hybrid

[x] test semanticRatio
[ ] test embedder

[x]  basic test
[ ] passing wrong embedder
[ ] without any embedder

[x] test experimental feature check

Embedder configuration

[ ] source doesn't exist
[ ] model

[x] model is not in the list of available models for OpenAI
[ ] model is not available on the ollama side
[ ] model does not exist for a Hugging Face model
[x] model is not a BERT model for a Hugging Face model
[ ] model was specified for a user provided embedder
[ ] model was specified for a rest embedder
[x] ... was not a string

[ ] revision

[ ] revision was specified for OpenAI
[ ] revision was specified for ollama
[ ] revision does not exist for a Hugging Face model
[ ] revision was specified for a user provided embedder
[ ] revision was specified for a rest embedder
[ ] ... was not a string

[ ] apiKey

[x] API key was incorrect for OpenAI
[ ] API key was incorrect for ollama
[ ] API key was specified for Hugging Face
[ ] API key was specified for a user provided embedder
[ ] API key was incorrect for a REST embedder
[x] ... was not a string

[ ] dimensions

[ ] dimensions was specified for a model that doesn't support custom dimensions in OpenAI
[x] dimensions was specified higher than the natural model's dimensions, for OpenAI
[ ] dimensions was specified wrongly for ollama
[ ] dimensions was specified wrongly for Hugging Face
[ ] dimensions was specified wrongly for a user provided embedder
[ ] dimensions was not specified for a user provided embedder
[x] dimensions was specified wrongly for a REST embedder
[x] ... was not a number
[ ] ... was a non-integer

[ ] documentTemplate

[x] document template was not valid liquid syntax
[x] document template contained context variables other than fields or doc
[x] document template references fields but with an invalid subscript in field
[ ] document template references a field that a document doesn't have
[ ] document template is specified for a user provided embedder
[ ] ... was not a string

[ ] url

[ ] url was specified for an OpenAI embedder
[ ] url was specified for a Hugging Face embedder
[ ] url was specified for a user provided embedder
[x] url was specified in an invalid format (missing scheme)
[x] url was specified to point to a non existing server
[ ] ... was not a string

[ ] query

[ ] ... was specified for an OpenAI embedder
[ ] ... was specified for an ollama embedder
[ ] ... was specified for a Hugging Face embedder
[ ] ... was specified for a user provided embedder
[ ] ... was not a JSON map

[ ] inputField

[ ] ... was specified for an OpenAI embedder
[ ] ... was specified for an ollama embedder
[ ] ... was specified for a Hugging Face embedder
[ ] ... was specified for a user provided embedder
[ ] ... was not an array
[ ] ... contains an item that is not a string

[ ] pathToEmbeddings

[ ] ... was specified for an OpenAI embedder
[ ] ... was specified for an ollama embedder
[ ] ... was specified for a Hugging Face embedder
[ ] ... was specified for a user provided embedder
[ ] ... was not an array
[ ] ... contains an item that is not a string
[ ] ... describes a path that cannot be accessed in the response

[ ] embeddingObject

[ ] ... was specified for an OpenAI embedder
[ ] ... was specified for an ollama embedder
[ ] ... was specified for a Hugging Face embedder
[ ] ... was specified for a user provided embedder
[ ] ... was not an array
[ ] ... contains an item that is not a string
[ ] ... describes a path that cannot be accessed in the response

[ ] inputType

[ ] ... was specified for an OpenAI embedder
[ ] ... was specified for an ollama embedder
[ ] ... was specified for a Hugging Face embedder
[ ] ... was specified for a user provided embedder
[ ] ... is not a string
[ ] ... is different from text or textArray

[ ] distribution

[ ] has a negative mean
[ ] has a mean > 1
[ ] has a 0 sigma
[ ] has a negative sigma
[ ] has a sigma > 1

Hello @suous :wave:
thank you for the detailed report :heart:
so you're aware next time: we prefer that bugs are reported on their own GitHub issue
However this time it won't be necessary, as your report is not a bug, but more a limitation of the REST embedder.
In v1.9, the REST embedder can only fetch arrays of embeddings in the answer if the query is an array of texts as well.  This can be set with the inputType parameter, which must be set to textArray.
This way, it works perfectly with OpenAI.
By the way, we have an OpenAI source for embedder, which uses the REST embedder implementation internally, and which adds specialized error handling. You might want to simply use the openAi embedder source instead of the more flexible but more complex to configure rest embedder source:
curl \
  -X PATCH 'http://localhost:7700/indexes/movies/settings' \
  -H 'Content-Type: application/json' \
  --data-binary '{
    "embedders": {
      "default": {
        "source": "openAi",
        "apiKey": "SOURCE_API_KEY",
        "model": "MODEL_NAME",
        "dimensions": 512,
        "documentTemplate": "A document titled {{doc.title}} whose description starts with {{doc.overview|truncatewords: 20}}",
      }
    }
  }'

As you can see it is a bit simpler to use this way.

Work started in v1.10, will be continued in v1.11


Envoy 1.17.1 backport v1.7

#14754 -- envoy: Update to release 1.17.1 (@jrajahalme)

Once this PR is merged, you can update the PR labels via:
$ for pr in 14754; do contrib/backporting/set-labels.py $pr done 1.7; done

test-backport-1.7

test-backport-1.7

test-backport-1.7

test-1.12-4.9

FYI @jrajahalme I don't think the "test-1.12-4.9" makes sense, we can probably ignore it. See my comment here: https://github.com/cilium/cilium/pull/15183#issuecomment-791612872

FYI @jrajahalme I don't think the "test-1.12-4.9" makes sense, we can probably ignore it. See my comment here: #15183 (comment)

Good to know, it shows up as "required" :-)

Added a commit discarding Envoy API v2 deprecation warnings unless flowdebug is enabled. We are intentionally using Envoy API v2 on v1.8 and v1.7 releases.


add calendar year period to relevant metrics

add calendar year period to relevant metrics for cryptocurrency trading case (365 vs 252 trading days).

I've implemented the same functionality in 0.0.33 - although using a different approach.
You can now pass the number of days per year in reports – so you can use trading_year_days=365 if you're trading crypto, or any other number for intl. markets.


Improve local testability

Testing this package in the usual way, on one's local machine, does not work:
using Pkg
Pkg.activate(temp=true)
Pkg.add("MLFlowClient")
Pkg.test("MLFlowClient")

     Testing Running tests...
createexperiment: Error During Test at /Users/anthony/.julia/packages/MLFlowClient/Szkbv/test/test_experiments.jl:1
  Got exception outside of a @test
  HTTP.Exceptions.StatusError(403, "POST", "/api/2.0/mlflow/experiments/create", HTTP.Messages.Response:
  """
  HTTP/1.1 403 Forbidden
  Content-Length: 0
  Server: AirTunes/620.8.2

Obviously the error thrown in not helpful. I expect one needs an active MLflow service running on your machine, and that it must have the appropriate uri.
Here is a related issue with a suggestion for remedy: https://github.com/JuliaAI/MLJFlow.jl/issues/20

@ablaom do you think is a good idea to replicate the environment variable approach implemented in MLJFlow testing suite? I think it can ensure the user to run all the tests correctly.

Sure, unless you have a better suggestion.

#38 should do what has been discussed.

Helpful comments, @deyandyankov, thank you.

Another way to go would be to mock the mlflow endpoints. This will not require an mlflow instance at all. That's probably the correct way in general and it will allow Pkg.test() to execute without any service dependencies.

Do you mean a fully functioning mock up of an mlflow service? This would have these drawbacks:

A bit of work to set up, no?
Possibility that bugs in the mock mean some wrong behaviour of MLFlowClient.jl is not caught.
Adds a maintenance burden to testing for breaking releases of mlflow

As maintenance on this site has become exceedingly thin, this doesn't make this realistic option just now, in my view. (Side note: I did actually created a baby mock-up for the POC at #41.)
@deyandyankov I might have missed something, but is there anything proposed in #38 that upsets the testing workflow you just described?

To improve the project testability, I suggest to use BrokenRecord.jl. It brings us a "cassette" approach to record the HTTP requests, removing the necessity of having a mlflow instance running on our local machine.
However, this can include a new environment variable USE_TEST_RECORDS, because testing using a true server is still being required for the CI job (and locally if required).

This sounds like a nice idea!


UX + Security current user password reset

Follow up to https://github.com/go-gitea/gitea/pull/5034
I'll annotate these a little later, but it's combos for these states:

not logged in
logged in as expected user
logged in as an unexpected user
valid code
invalid code (or expired code)

Default Condition

Not logged In
Valid Reset Code

Result

Shows email of user for whom the password is to be reset
Shows "Remember me"
Signs in the user

Logged In

Already Logged In
Valid Reset Code

Result

Shows email of user for whom the password is to be reset
Doesn't show "Remember me"
Renews user session

Invalid Code

Login Status N/A
Invalid Code

Result

Error about invalid code
Submits to same error page (could probably just disable submit)

Invalid User

User Logged in as FOO USER
Valid Code for BAR USER

Result

Error about mismatch user
Submits to same error page (could probably just disable submit)

@daviian The "Remember me" felt a little weird to me too.
What I came to was that it's actually the form was incorrectly labeled. "Password Reset" is the process that happens on the Account page. This process is actually "Account Recovery", which is a different user flow.
The user isn't coming to this page with the intent to change their password (that is already on the Account page), but rather to be able to login to their account. In this case, with the current configuration, that implicitly includes setting a password. However, once more secure options are available the user will still want to recover their account but a password won't be part of the process.
I'll post new screenshots a little later.

Two more things that should change for increased clarity:

[ ] "New Password" instead of "Password"
[ ] "Remember this device" instead of "Remember me"

I'm back on the scene. I'll see what I can do to get this stuff cleaned up and PR'd again.

Rebased and ready for re-review!

@daviian need your approval


gitleaks: 8.5.1 -> 8.5.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gitleaks/versions.
meta.description for gitleaks is: "Scan git repos (or files) for secrets"
meta.homepage for gitleaks is: "https://github.com/zricethezav/gitleaks"
meta.changelog for gitleaks is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/gwfaij12zdbk1ijn2ksfpc5i0z5a1is3-gitleaks-8.5.2/bin/gitleaks had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 8.5.2 in filename of file in /nix/store/gwfaij12zdbk1ijn2ksfpc5i0z5a1is3-gitleaks-8.5.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
gitleaks

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gwfaij12zdbk1ijn2ksfpc5i0z5a1is3-gitleaks-8.5.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gitleaks https://github.com/r-ryantm/nixpkgs/archive/f92c7b80372f3c1d14ef2f1f17daf471431a212a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gwfaij12zdbk1ijn2ksfpc5i0z5a1is3-gitleaks-8.5.2
ls -la /nix/store/gwfaij12zdbk1ijn2ksfpc5i0z5a1is3-gitleaks-8.5.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gitleaks

Maintainer pings
cc @fabaff @kalbasit for testing.

Result of nixpkgs-review pr 166296 run on aarch64-darwin 1

1 package built:

gitleaks


feature: add metric name prefix option

Implemented a feature that allows setting a prefix to metric names.
For issue #56

@Klem3n : Can you please fix the findings in the CI actions, e.g. https://github.com/christiangalsterer/mongodb-driver-prometheus-exporter/actions/runs/6890539524/job/18761906292?pr=57. Even better can you maybe create the branch not in a fork but directly in this repo. Then also the Snyk builds would run. Thanks in advance.

No worries, I made the changes quickly myself and will create a new release soon.


Regenerate yarn.lock and ensure prepublish is run on CI

Hopefully this fixes the issues with CI. As far as I can tell, Yarn is no longer running the prepublish script on install which is responsible for linking the test engines to their proper locations.

Apparently I was wrong. Going to try removing ember-cli-dependency-checker and see if the tests pass, as that is preventing them from running at all.

Thanks for working on this @trentmwillis.

So it runs without the dep checker, but the tests fail for not having the right output files, which would be a byproduct of what the dep checker was warning against. Trying some other tweaks now...

Does it have the same issues locally?  I'm wondering if we are being trolled by recent changes to ember-try (whcih was to not use yarn without a useYarn: true flag) or possibly by getting npm@5 incompatibilities...

I have now fixed the Ember tests, which was due to the ember-try changes from what I can tell.

Everything is passing now! 🎉
@rwjblue a review from you before merging would be much appreciated :) then we can land https://github.com/ember-engines/ember-engines/pull/492 which will unblock my fastboot integration work


alerts with nothing in them and since/touched 00s ago

i often get stuff like this on the dashboard:

interesting remarks:

subject rendered fine, but not body
status is empty
since and touched 00s ago
expr is empty

looking at js console in chromium -> no errors
network tab:

/api/status?ak=requests_by_country%7B%7D
-> 200 OK with 9.5MB of data txferred,  though chromium says "failed to load response data"

/mini-profiler-resources/results
200 OK

{"Id":"49246820296ae271","Name":"bosun.org/cmd/bosun/web.func·015","Started":1429734332000,"MachineName":"graphite1","Root":{"Id":"4871be7dd0744567","Name":"GET http://bosun.vimeows.com/api/status?ak=requests_by_country%7B%7D","DurationMilliseconds":17468.56982,"StartMilliseconds":0,"Children":null,"CustomTimings":null},"ClientTimings":null,"DurationMilliseconds":17468.56982,"CustomLinks":{}}

We see this as well. Greg was going to file an issue today actually..
On Apr 22, 2015 4:31 PM, "Dieter Plaetinck"<EMAIL_ADDRESS>wrote:

i often get stuff like this on the dashboard:
[image: weird]
https://cloud.githubusercontent.com/assets/20774/7284492/160b45b8-e90c-11e4-8241-0fb614a68333.png
interesting remarks:

subject rendered fine, but not body
status is empty
since and touched 00s ago
expr is empty

looking at js console in chromium -> no errors
network tab:

/api/status?ak=requests_by_country%7B%7D
-> 200 OK with 9.5MB of data txferred, though chromium says "failed to
load response data"
/mini-profiler-resources/results
200 OK
{"Id":"49246820296ae271","Name":"bosun.org/cmd/bosun/web.func·015 http://bosun.org/cmd/bosun/web.func·015","Started":1429734332000,"MachineName":"graphite1","Root":{"Id":"4871be7dd0744567","Name":"GET http://bosun.vimeows.com/api/status?ak=requests_by_country{}","DurationMilliseconds":17468.56982,"StartMilliseconds":0,"Children":null,"CustomTimings":null},"ClientTimings":null,"DurationMilliseconds":17468.56982,"CustomLinks":{}}
—
Reply to this email directly or view it on GitHub
https://github.com/bosun-monitor/bosun/issues/917.

FIRST!

The issue I filed was regarding a specific empty dialog I saw. See #915 although they both may be related to the loading issue #869

Assuming this is fixed since the two referenced issues are fixed, please reopen if you still see this.


Project Status

Hi there!
Swarm, along with RON (https://replicated.cc) look very promising. Im confused as to why Swarm isn't going anywhere :(
You guys had some great ideas – what made you stop? Are there other CRDT project(s) that use the RON spec? What are your thoughts on Automerge and Yjs?
Also http://swarmdb.net/ is down so if you guys had a blog there, its not available.
Thanks

This seems to be an alternative: https://github.com/amark/gun

Hello
I guess, I logged out of GitHib couple years ago. OK, I am back.
So, RON is evolving and I like it. Just not on GitHub.
 I have that. It is implemented in C++ because C++ is much much more convenient when you want things bit-precise. Also, I wanted a library to use in all higher-level languages through bindings. So C++ it was.
Of course, there is a little problem here: all good C++ developers are employed at Googles and Facebooks for very big $$$ and they are unlikely to contribute to open source projects like mine (I guess, there is a specific clause in the contract). Hence, putting things on GitHub does not help at all. The only two consequences would be (1) a stream of suggestions to rewrite it in Rust (no actual attempts) and (2) a couple copycats would pop up immediately.
So that is probably the reason I logged out from GitHub.

There is a live libron demo I put online earlier this year: http://doc.replicated.cc/^Wiki/ron.sm
It has a full loop: RON op log <--> Chronofold <--> Versioned text <--> Markdown <--> HTML, including its own HTTP server (which was like 1% of the effort, thanks Ragel). It hangs on the public internet since March (?) with no crashes, so I guess the code is pretty stable (thanks libfuzzer).
What's next?
I will probably release a RON based real-time revision control system in some observable future (it was used in the demo).
I may put a RON spec online (I mean, update it).
I may do other interesting things.


utter_* action creation through interactive learning is not working

Rasa version: rasa-core==0.14.1
Python version: Python 3.6.7
Operating system (windows, osx, ...):
Distributor ID: Ubuntu
Description: Ubuntu 18.04.2 LTS
Release: 18.04
Codename: bionic
Issue: Getting following error when trying to create a new utter_ action through interactive learning.
2019-05-08 13:55:01 ERROR    rasa_core.server  - Encountered an exception while running action 'utter_test'. Bot will continue, but the actions events are lost. Make sure to fix the exception in your custom code.
? WARNING: You have created a new action: 'utter_test', which was not successfully executed. If this action does not return any
 events, you do not need to do anything. If this is a custom action which returns events, you are recommended to implement this
 action in your action server and try again.  (Y/n)

I think this has been fixed in rasa master branch as part of 3178. But, It would be great if you could fix th issue in rasa_core version also, since the rasa master version is not released yet?

we won't be releasing this in a minor, too much code has changed since then. Right now you can just ignore this warning and add the template to your domain file


FR: HTTP interact with the file system

Is your feature request related to a problem?
No response
Describe the solution you'd like.
It would be great if HTTP commands could work with the file system.
For example:

AT+HTTPCGET could straight download the file into ESP32 file system
AT+HTTPCPOST and AT+HTTPCPUT could straight post/put the specified file from ESP32 file system to a url

This feature is similar to the AT+UHTTPC command provided by the U-Blox R510S module.
Describe alternatives you've considered.
No response
Additional context.
No response

Dear repo owner/maintainer,
Is there any update for this Feature Request?
We probably could have a discussion about it.
Cheers,
Paul

@pauldeng thanks for your feature request. We will consider it with low priority because the default flash available is very limited and can only store very small files.

Dear @ustccw,
Thanks for your reply.
This feature is not intended to be used to download a movie. In my use case, it is a binary file that is < 1MB.
Can I ask how to prioritise this feature? Or do you allow contribution from other personal/company, so that I probably can work on this.
We can discuss how to proceed if you are interested.
Cheers,
Paul

Dear @ustccw,
If I would like to contribute, how do I proceed?
Cheers,
Paul

@pauldeng I apologize for the delayed response. If you urgently need this feature, it might be more appropriate for you to undertake secondary development and implement custom AT commands. We also have plans for this feature, but it's scheduled for 2024.Q2.

That is great!
Appreciate.


Update system-contracts.md -

Since you have open sourced the bootloader contract it needs to be updated, some devs or researchers who wants to build on a top of zkSync Era may be confused with this paragraph: "For now, you do not have to know any details about it, but knowing that it exists is important when you develop using the account abstraction feature. You can always assume that the bootloader is not malicious and it is a part of the protocol. In the future, the code of the bootloader will be made public and any changes to it will also mean an upgrade to the protocol."
It would be better to share the audit and the codebase at your docs.
#

I totally agree with your friend.


[Candidate 1v1 Bozic Destruction ZH v6] Trees are placed inside Oil Refinery

Issue Description
Trees are placed inside Oil Refinery.
Expected behavior
There are no trees inside the Oil Refinery.
Screenshots

I also suggest to rotate the Oil Refinery a bit to that its flag is better visible, like the Oil Derrick. Currently it is hidden by the tree.


Chat: Failures and retries

@keybase/react-hackers

When Gregor tells us that a message send failed, update its messageState to failed

When retry is clicked on a failed message, send the retry RPC.  (When the retry succeeds, we'll get an incoming message for that message and update the state to success.)

Existing core bugs being worked on:

It takes a long time for Gregor to detect that you've gone online or offline.

Gregor sends failure messages even for some messages that succeeded.

The commits 1d28cfcbb13a...543a443c7f14 introduce visual changes on linux. :mag_right: 1 changed

Changed: unlock_folders-Single (before) (after)

@keybase/react-hackers bump

@chrisnojima Thanks!  Made both of those changes.


Failing updating registration token with Github organization app

I'm currently using option 2 - the "personal access token" way of authenticating. Everything is working in this way.
However, when i try to do a fresh install using a github app created by an organization, i can't seem to get it to work at all. Not sure where the error is likely to be. I suspected permissions but all those seem to be ok? I have read & write for Actions, Checks Workflows in addition to the mandatory ones (Org Self-hosted runners is also read & write). Maybe the issue is still there?
logs from the controller manager:
2020-08-13T16:10:07.510Z	DEBUG	controller-runtime.manager.events	Warning	{"object": {"kind":"Runner","namespace":"actions-runner-system","name":"recsyslabs-runner-deployment-z9n69-49mlq","uid":"19725e67-d746-434e-ad32-a4d922e2968e","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersion":"27540708"}, "reason": "FailedUpdateRegistrationToken", "message": "Updating registration token failed"}
2020-08-13T16:10:07.510Z	ERROR	controller-runtime.controller	Reconciler error	{"controller": "runner", "request": "actions-runner-system/recsyslabs-runner-deployment-z9n69-49mlq", "error": "failed to create registration token: Post https://api.github.com/orgs/recsyslabs/actions/runners/registration-token: could not refresh installation id 8388012's token: request &{Method:POST URL:https://api.github.com/app/installations/8388012/access_tokens Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Accept:[application/vnd.github.machine-man-preview+json application/vnd.github.machine-man-preview+json] Authorization:[Bearer eyJ...w] Content-Type:[application/json]] Body:{Reader:} GetBody:0x7d5c40 ContentLength:5 TransferEncoding:[] Close:false Host:api.github.com Form:map[] PostForm:map[] MultipartForm:<nil> Trailer:map[] RemoteAddr: RequestURI: TLS:<nil> Cancel:<nil> Response:<nil> ctx:0xc000114200} received non 2xx response status &{%!q(*http.body=&{0xc0004d5280 <nil> <nil> false false {0 0} false false false <nil>}) {'\\x00' '\\x00'} %!q(bool=false) <nil> %!q(func(error) error=0x7d7500) %!q(func() error=0x7d7490)} with body &{Method:POST URL:https://api.github.com/app/installations/8388012/access_tokens Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Accept:[application/vnd.github.machine-man-preview+json application/vnd.github.machine-man-preview+json] Authorization:[Bearer eyJ...w] Content-Type:[application/json]] Body:{Reader:} GetBody:0x7d5c40 ContentLength:5 TransferEncoding:[] Close:false Host:api.github.com Form:map[] PostForm:map[] MultipartForm:<nil> Trailer:map[] RemoteAddr: RequestURI: TLS:<nil> Cancel:<nil> Response:<nil> ctx:0xc000114200} and TLS &{Version:772 HandshakeComplete:true DidResume:false CipherSuite:4865 NegotiatedProtocol:http/1.1 NegotiatedProtocolIsMutual:true ServerName: PeerCertificates:[0xc000b0f600 0xc000b0fb80] VerifiedChains:[[0xc000b0f600 0xc000b0fb80 0xc000d7b700]] SignedCertificateTimestamps:[] OCSPResponse:[] ekm:0x7303f0 TLSUnique:[]}"}
github.com/go-logr/zapr.(*zapLogger).Error
	/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:258
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:232
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:211
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
	/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:152
k8s.io/apimachinery/pkg/util/wait.JitterUntil
	/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:153
k8s.io/apimachinery/pkg/util/wait.Until
	/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:88

Some more potentially relevant info:
This is on v0.7.2 release, using my own custom runner image which is up to date (v2.272.0), it's on mircok8s v1.18 installed on ubuntu 18.04 with snap.
Not really sure what else to try. I'll continue using the personal access token for now.

@igorbrigadir Hey! Could you check for clock drift on the machine on which your controller pods are running?
AFAIK this happens when your clock is drifted, like seen in https://github.com/palantir/bulldozer/issues/158

@igorbrigadir Hey! Could you check for clock drift on the machine on which your controller pods are running?

Thanks! I tried that but unfortunately the error is the same.
I synced the system time on the node, but could the time still be out of sync in the pod? Maybe the way microk8s runs things it's a possibility? i don't really know what way i could check from inside the pod.

Same issue here with organizational token. I set up the runners and had them working in a different cluster, but after I got it running and tried to bring it up in the production cluster I get this:
 2020-09-24T23:01:32.140Z        DEBUG   controller-runtime.manager.events       Warning {"object": {"kind":"Runner","namespace":"github-runner","name":"github-runner-8hsrb-khch2","uid":"ae5e4e96-714b-45d2-a06d-338e98b1f683","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersion":"630311"}, "reason": "FailedUpdateRegistrationToken", "message": "Updating registration token failed"}
2020-09-24T23:01:32.140Z        ERROR   controller-runtime.controller   Reconciler error        {"controller": "runner", "request": "github-runner/github-runner-8hsrb-khch2", "error": "failed to create registration token: Post https://api.github.com/orgs/cyndx/actions/runners/registration-token: could not refresh installation id 11971006's token: request &{Method:POST URL:https://api.github.com/app/installations/11971006/access_tokens Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Accept:[application/vnd.github.machine-man-preview+json application/vnd.github.machine-man-preview+json] Authorization:[Bearer eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJleHAiOjE2MDA5ODg1NTIsImlhdCI6MTYwMDk4ODQ5MiwiaXNzIjoiODE3OTcifQ.JLlFH4Fqq0MedwuPuUhSi8fIBDlEdEq5ToWeMeObc-mlIEtyna_DSe6QlHLClwljoOX0Uv-7UklP4LoFb-ffeT87hG5imcJRWrBcpYebnj8q1AEOVvHIWaRNWkz3YsojxPGcvMPswhtQ2p0AuPWyIE6RAE2zCLW0C6MZJC10hdIDgRVE5e7htIapew7xP1FQhQZbFvLYcJ8qZvGZ2gCf7O_Qz4poC71Cgs9MJAmvWiU6atlQO7cRQkNTNddv0rMP_4gaiCyLgok_XhFxE14rhgQ7IYEerIsBiryynl3Nf5E7JCPBNgVmDBGgK8jOiWKHigaKfeIkqMiRKL1oSYRxHw] Content-Type:[application/json]] Body:{Reader:} GetBody:0x7d5c40 ContentLength:5 TransferEncoding:[] Close:false Host:api.github.com Form:map[] PostForm:map[] MultipartForm:<nil> Trailer:map[] RemoteAddr: RequestURI: TLS:<nil> Cancel:<nil> Response:<nil> ctx:0xc0000be210} received non 2xx response status &{%!q(*http.bodyEOFSignal=&{0xc000099180 {0 0} false <nil> 0x7d7500 0x7d7490}) %!q(*gzip.Reader=<nil>) <nil>} with body &{Method:POST URL:https://api.github.com/app/installations/11971006/access_tokens Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Accept:[application/vnd.github.machine-man-preview+json application/vnd.github.machine-man-preview+json] Authorization:[Bearer eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJleHAiOjE2MDA5ODg1NTIsImlhdCI6MTYwMDk4ODQ5MiwiaXNzIjoiODE3OTcifQ.JLlFH4Fqq0MedwuPuUhSi8fIBDlEdEq5ToWeMeObc-mlIEtyna_DSe6QlHLClwljoOX0Uv-7UklP4LoFb-ffeT87hG5imcJRWrBcpYebnj8q1AEOVvHIWaRNWkz3YsojxPGcvMPswhtQ2p0AuPWyIE6RAE2zCLW0C6MZJC10hdIDgRVE5e7htIapew7xP1FQhQZbFvLYcJ8qZvGZ2gCf7O_Qz4poC71Cgs9MJAmvWiU6atlQO7cRQkNTNddv0rMP_4gaiCyLgok_XhFxE14rhgQ7IYEerIsBiryynl3Nf5E7JCPBNgVmDBGgK8jOiWKHigaKfeIkqMiRKL1oSYRxHw] Content-Type:[application/json]] Body:{Reader:} GetBody:0x7d5c40 ContentLength:5 TransferEncoding:[] Close:false Host:api.github.com Form:map[] PostForm:map[] MultipartForm:<nil> Trailer:map[] RemoteAddr: RequestURI: TLS:<nil> Cancel:<nil> Response:<nil> ctx:0xc0000be210} and TLS &{Version:772 HandshakeComplete:true DidResume:false CipherSuite:4865 NegotiatedProtocol:http/1.1 NegotiatedProtocolIsMutual:true ServerName: PeerCertificates:[0xc000303b80 0xc000b0a000] VerifiedChains:[[0xc000303b80 0xc000b0a000 0xc00099c000]] SignedCertificateTimestamps:[] OCSPResponse:[] ekm:0x7303f0 TLSUnique:[]}"}
github.com/go-logr/zapr.(*zapLogger).Error
        /go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:258
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:232
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:211
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
        /go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:152
k8s.io/apimachinery/pkg/util/wait.JitterUntil
        /go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:153
k8s.io/apimachinery/pkg/util/wait.Until
        /go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:88

Somehow my installation ID changed. Once I upddaed it all worked.

I'm having the same problem - the server is running NTP and the time is accurate. I can get a registration token using curl
I'm using the suggested method to set the secret:
kubectl create secret generic controller-manager     -n actions-runner-system     --from-literal=github_token=${GITH\
UB_TOKEN}

and I'm deleting and re-creating the 'runner' after I set the secret.
Is the secret supposed to be base64 encoded or just the cut & paste from Github (I've tried both, no change).

I'm having the same problem - the server is running NTP and the time is accurate. I can get a registration token using curl
I'm using the suggested method to set the secret:
kubectl create secret generic controller-manager     -n actions-runner-system     --from-literal=github_token=${GITH\
UB_TOKEN}

and I'm deleting and re-creating the 'runner' after I set the secret.
Is the secret supposed to be base64 encoded or just the cut & paste from Github (I've tried both, no change).

This appears to be an issue with the proper authorizations. Using the directions at https://github.com/myoung34/docker-github-actions-runner that indicates the following rights are needed, I was able to get things working. I'll file a PR to update the documentation.
Creating GitHub personal access token (PAT) for using by self-hosted runner make sure the following scopes are selected:
repo (all)
admin:org (all) (mandatory for organization-wide runner)
admin:public_key - read:public_key
admin:repo_hook - read:repo_hook
admin:org_hook
notifications
workflow
Also, when creating a PAT for self-hosted runner which will process events from several repositories of the particular organization, create the PAT using organization owner account. Otherwise your new PAT will not have sufficient privileges for all repositories.

This appears to be an issue with the proper authorizations. Using the directions at https://github.com/myoung34/docker-github-actions-runner that indicates the following rights are needed, I was able to get things working. I'll file a PR to update the documentation.
Creating GitHub personal access token (PAT) for using by self-hosted runner make sure the following scopes are selected:
repo (all)
admin:org (all) (mandatory for organization-wide runner)
admin:public_key - read:public_key
admin:repo_hook - read:repo_hook
admin:org_hook
notifications
workflow
Also, when creating a PAT for self-hosted runner which will process events from several repositories of the particular organization, create the PAT using organization owner account. Otherwise your new PAT will not have sufficient privileges for all repositories.


Link all the pages to footer in all pages

For Example - The partner Store page should be linked to "Become our partner" in the footer.

Can you assign it to me?

For Example - The partner Store page should be linked to "Become our partner" in the footer.

For Become our partners we should have separate page I think so. Like a form page where the company will fill his information to collaborate with Apnidukaan.com.

Also many pages were not created for ex:- for reporting an issue, cancellation and return etc.

What should I do then can you guide me further?

Link all the pages that are already available.
As for those pages that are not yet created.
You can go ahead and open issues to create those pages.
You can also try to create those pages.
And about the submission form idea for become our partners page.
You can go ahead and try to add more features and your ideas to improve the partners page.
But as of now just linking the partners page to the footer will be fine.


Update Makefile of 'src/' folder

Hi, I'm updating the makefile of 'src/' folder with lots of improvements.
I've opened a pull request to notify @raysan5 about my work, because it is not finished, and, obviously, to discuss about what I'm doing.
My objectives:

[x] adjust the name of targets;
[x] add install / unistall targets for GNU/Linux platform;
[x] add possibility to compile web and shared versions of raylib;
[x] review clean target;
[x] review the compiling of modules (maybe I will use a wildcard).

Wow! It's been close, I was just going to update Makefile also! I've been doing some changes too... :P
I'm revieweing output folder for all platforms to point to release folder (src/.../release).
I will wait for your changes to integrate mines.

@raysan5 ok, I think I will complete these points by two-three days.

I have a question @raysan5: the file external/stb_vorbis.c must be compiled?

Hi @LelixSuper, yes external/stb_vorbis.c must be compiled to support OGG audio loading.

I've seen you have group the compilation of all modules into one line, it's ok... I just did the other way to use the file for teaching pourposes (and keep it simple)... but I think that at this point the file has changed so much that it doesn't matter...

I have discovered that I can't compile all modules into one line, because each module requires special prerequisite. I'm fixing this problem.

Just a note, some modules (camera.c, gestures.c) do not require the header because functions are already declared in raylib.h. Headers (camera.h, gestures.h) are provided if someone wants to use the module independently of raylib (hooking their own input functions).
The same way, many modules depend on header-only modules (stb_image.h, sbt_truetype.h...). And some header-only modules are also provided with raylib (some of them not compiled within raylib - physac.h, raygui.h, easings.h) to be used independently of the library (if someone needs them).
That's done that way to keep raylib as much clean and self-contained as possible and modular. The only problem is that some of those modules are never noticed by users...

You can read a bit more on raylib structure here: https://github.com/raysan5/raylib/wiki/raylib-arquitecture

@raysan5 now the makefile can compile raylib (not standalone modules) to shared (Linux), web and static version.
To compile standalone modules, makefile needs other works, meanwhile I'm about to write the docs to compile the library.

Great addition @LelixSuper! Don't worry about standalone modules, they are intended to be dropped into user project (and custom pipeline). They are not intended to be compiled with raylib as standalone.
Is it possible to add DLL compilation with MinGW? It would be great...
Anyway, thank you very much for your effort!

@raysan5 I don't know how DLL works on Windows, so I will inform.

Don't worry @LelixSuper, I can take a look later... I'd need to close this pull-request to add it to raylib 1.5, I'm about to publish this new version! Have you finished on your side?

@raysan5 I will finish by today.

That's great! Thank you very much @LelixSuper!

By the way, could you upload libraylib.a to release folder, it would be great to make it available to the users... :)

@raysan5 I have finished. Maybe it needs improvements, I will review him in the future.

Amazing @LelixSuper! Thank you very much for your update! :D


Init new Geo provider for geographical and spatial data. Move longitu…

Init new Geo provider for geographical and spatial data. Move longitude() and latitude() from Address to Geo.

If not for seeding DB, generating random values then what is a responsibility of this library?
P.S. this is only the beginning, there would be new generators associated with spatial data. I made this because currently there are no Geo provider at all. Talking about long/lat, their location in address/translations is not the best place also. Now there is primitive Geo provider.
There is similar repository with geo provider https://github.com/bobthecow/Faker where you can see more generators but there are still much more functionality exists in GIS.

Faker takes care of generating raw data. The actual formatting of the data is up to the user. Whether it's XML, JSON, SQL, or whatever format out there, it' not Faker's responsibility.
If you want to make a SQL formatter for all of Faker's data, be my guest. This will just have to live outside of the Faker Core.


[8.x] Added class to create matrix sequences for factories

Adds a new MatrixSequence class that helps cross joining multiple sequences.
Usage:
User::factory(4)
    ->state(
        new MatrixSequence(
            [['first_name' => 'Thomas'], ['first_name' => 'Agent']],
            [['last_name' => 'Anderson'], ['last_name' => 'Smith']],
        ),
    )
    ->create();

// Results in

[
    ['first_name' => 'Thomas', 'last_name' => 'Anderson'],
    ['first_name' => 'Thomas', 'last_name' => 'Smith'],
    ['first_name' => 'Agent', 'last_name' => 'Anderson'],
    ['first_name' => 'Agent', 'last_name' => 'Smith'],
]

Current way of achieving this:
->sequence([
    ['first_name' => 'Thomas'],
    ['first_name' => 'Thomas'],
    ['first_name' => 'Agent'],
    ['first_name' => 'Agent']
])
->sequence([
    ['last_name' => 'Anderson'],
    ['last_name' => 'Smith'],
    ['last_name' => 'Anderson'],
    ['last_name' => 'Smith'],
])

More complex example:
new MatrixSequence(
    [['a' => 1]],
    [['b' => 1], ['b' => 2]],
    [['c' => 1], ['c' => 2], ['c' => 3]],
);

[
    ['a' => 1, 'b' => 1, 'c' => 1],
    ['a' => 1, 'b' => 1, 'c' => 2],
    ['a' => 1, 'b' => 1, 'c' => 3],
    ['a' => 1, 'b' => 2, 'c' => 1],
    ['a' => 1, 'b' => 2, 'c' => 2],
    ['a' => 1, 'b' => 2, 'c' => 3],
];

Should we name it CrossJoinSequence since it has a clear correlation with Arr::crossJoin? Or does that not make sense?

I like the idea. And I think both names MatrixSequence and CossJoinSequence are fine.
What is the expected behaviour of:
new MatrixSequence(
    [['a' => 1]],
    [['b' => 1], ['b' => 2]],
    [['c' => 1], ['a' => 2], ['c' => 3]], // Here is the second element changed.
);

// Later has a higher priority
[
    ['a' => 1, 'b' => 1, 'c' => 1],
    ['a' => 2, 'b' => 1],
    ['a' => 1, 'b' => 1, 'c' => 3],
    ['a' => 1, 'b' => 2, 'c' => 1],
    ['a' => 2, 'b' => 2],
    ['a' => 1, 'b' => 2, 'c' => 3],
];

// Earlier has a higher priority
[
    ['a' => 1, 'b' => 1, 'c' => 1],
    ['a' => 1, 'b' => 1],
    ['a' => 1, 'b' => 1, 'c' => 3],
    ['a' => 1, 'b' => 2, 'c' => 1],
    ['a' => 1, 'b' => 2],
    ['a' => 1, 'b' => 2, 'c' => 3],
];

What do you think about this alternative?
new MatrixSequence([
    'a' => [1],
    'b' => [1, 2],
    'c' => [1, 2, 3],
]);

// Results in
[
    ['a' => 1, 'b' => 1, 'c' => 1],
    ['a' => 1, 'b' => 1, 'c' => 2],
    ['a' => 1, 'b' => 1, 'c' => 3],
    ['a' => 1, 'b' => 2, 'c' => 1],
    ['a' => 1, 'b' => 2, 'c' => 2],
    ['a' => 1, 'b' => 2, 'c' => 3],
];

Marking as draft pending response to feedback.

Should we name it CrossJoinSequence since it has a clear correlation with Arr::crossJoin? Or does that not make sense?

CrossJoinSequence was a second choice 👍. However now my Matrix example with Thomas Anderson and Agent Smith seems so unrelated 😿.

new MatrixSequence([
    'a' => [1],
    'b' => [1, 2],
    'c' => [1, 2, 3],
]);

This indeed feels like a nice alternative. It prevents human error and is much easier to read/understand. However for unknown reasons and possibly lack of knowledge about defining a matrix I don't feel that convinced about its signature. Have you seen this somewhere before?
I would at least rename the current class to CrossJoinSequence. Should I also add ->crossJoinSequence as helper method?

Sorry @thomasowow I forgot to answer.
I made my an example like multiple foreach loops:
foreach ([1] as $a) {

    foreach ([1, 2] as $b) {

        foreach ([1, 2, 3] as $c) {

            Model::create([
                'a' => $a,
                'b' => $b,
                'c' => $c,
            ]);

        }

    }

}


use pkg-config libdir variable instead of hardcoding lib

this fixes garden test in the case where the libdir is lib64 rather than the lib that was hard coded.

I think this looks fine, but the DCO needs to pass first. I've assigned this to @davvid since he's the main person behind this project.

Ahh, I hadn't seen that DCO had failed, should be fixed now.

Thanks!


Migration Guide

Removed SetShadowViewBindGroup, queue_shadow_view_bind_group(), and LightMeta::shadow_view_bind_group in favor of reusing the prepass view bind group.

bors retry


Provide shortcuts to open text and Kaoto side-by-side

similar to Split editor

Opening a .MD file we can see a [Open Preview To The Side] button

Now this workflow starts from the text file, in our case, we're gonna need to start from Kaoto itself :thinking:

This Open Preview to the side is a generic feature in VS Code that we cannot reuse because we are not a preview but an editor.
A specific action will need to be provided

Several possibilities and steps:

[ ] Provide command in the palette to open textual editor in another editor group when Kaoto editor is active
[ ] Provide quick action in editor menu bar to open textual editor in another editor group when Kaoto editor is active
[ ] Provide keyboard shortcut to open textual editor in another editor group when Kaoto editor is opened
[ ] Provide contextual menu on Kaoto editor title to open textual editor in another editor group
[ ] Provide contextual menu in explorer to open textual editor and kaoto editor side by side on yaml files


check if alt tags are truly there

i checked everywhere and added them, but might be smart to check again :)

Done


tobiko-app image size reduced from 3GB to 1.3GB

Hey, Team! Came across your repository and thought I could help in optimizing the Docker image size.

@singulart thanks for the PR. since this docker image is used for development and never shipped to the user, I don't think we need to add complexity to reduce the size of the image.
so for now i'm going to close this pr.

@singulart thanks for the PR. since this docker image is used for development and never shipped to the user, I don't think we need to add complexity to reduce the size of the image.
so for now i'm going to close this pr.

Sure @tobymao! Should the Docker image size become an issue going forward, you know how to solve it. Good luck!

thanks so much


Create new content blocks on a separate page

New content blocks are now created by clicking the CREATE button in content/cms and a new row appears in the table.
This is rather unintuitive. It would be better if the user was led to a new page when clicking the CREATE button. The consequence of this is that there would be no empty content blocks, which causes #36. It would also make #24 possible.

Fixed in 	682f107. Closing


Breaking a pry do_after uproots the tile

You'd think it'd do nothing and just pretend it's handled anyway.
Also prying a tile itself should probably have a do_after to slow down the greytide.

Dupe nerd https://github.com/space-wizards/space-station-14/issues/5762


Automatically add Wikimedia Commons links

Description
Wikimedia Commons is a wiki project for hosting open media (pictures, videos...).  It is increasingly being used to add media files to PoCs in openstreetmaps.  As of April 2023, there are more than 112k uses of this tag in openstreetmaps (and growing fast, it was only 20k in 2020!).
See taginfo page
We make it easier for contributors to add wikimedia tags.  When someone adds a wikipedia tag, ID automatically adds the corresponding wikidata tag.  The same works in the other direction as well, the wikipedia tag is added automaticaly when one adds the wikidata tag in ID.
We can add the wikimedia commons tag automatically at the same time.  Wikimedia commons categories are often available in the wikipedia or wikidata pages.  For example:
wikidata page: https://www.wikidata.org/wiki/Q15533769

Screenshots
No response

I think there is huge benefit to linking notable features in OpenStreetMap to a Wikidata identifier, and I've been a supporter of this effort going back years..
But I don't see any additional benefit to adding more tags for more links to things that can just be linked through that Wikidata identifier - and the Wikimedia Commons category is one of these things.  It's just an extra link that needs to be maintained right?

Unfortunately we have to maintain a wikimedia commons tag in openstreetmaps, we can't just use wikidata.  There are many PoCs that are not prominent enough to have a wikidata entry, but still have images in wikimedia commons.  We can't just add the wikidata and be done with it.

There are many PoCs that are not prominent enough to have a wikidata entry, but still have images in wikimedia commons.

can you give an example?

There are many PoCs that are not prominent enough to have a wikidata entry, but still have images in wikimedia commons.

can you give an example?

Of course, it's easy to find many examples.
I ran a query in my hometown for PoCs that have wikimedia commons but no wikidata linked.  It's here: https://overpass-turbo.eu/s/1uC9
I then selected one at random: https://www.openstreetmap.org/node/2532890476
It's a nice statue in Kadıköy: https://commons.wikimedia.org/wiki/File:VecihiHürkuşStatueKadıköy.JPG
It has an image in wikimedia commons but is not prominent enough to have a wikidata entry.

That definitely is notable enough for Wikidata, even if it isn’t notable enough for Wikidata. You can make the item fulfill the “structural need” criterion by adding structured data to the image that references the item: go to the Structured Data tab on the file description page, then add the item in a depicts statement. The file currently says it depicts Sabiha Gökçen, but it’s more accurate to say that it depicts the statue depicting Sabiha Gökçen.
The Wikidata and Commons communities might not appreciate it if you mass-added a photo and item about each individual cobblestone in town, but as long as you exercise the same discretion you exercise in uploading to Commons, it should be fine.

That definitely is notable enough for Wikidata, even if it isn’t notable enough for Wikipedia. You can make the item fulfill the “structural need” criterion by adding structured data to the image that references the item: go to the Structured Data tab on the file description page, then add the item in a depicts statement. The file currently says it depicts Sabiha Gökçen, but it’s more accurate to say that it depicts the statue depicting Sabiha Gökçen.
The Wikidata and Commons communities might not appreciate it if you mass-added a photo and item about each individual cobblestone in town, but as long as you exercise the same discretion you exercise in uploading to Commons, it should be fine.

I don't quite understand the argument you are making.  There is no guarantee that anything on wikimedia commons will also be on wikidata.   By enforcing this arbitrary constraint that everything has to come from wikidata, you are excluding from openstreetmaps of useful (and increasingly popular) tags.  Also I'm not sure how happy the wikidata community will be if we started adding items just so they could be linked in openstreetmaps.

There is no guarantee that anything on wikimedia commons will also be on wikidata.

You’re right, but my point is that Wikidata’s notability criteria is so low – and automated edits are so welcomed on Wikidata – that creating Wikidata items could be a viable alternative to ensuring comprehensive coverage of wikimedia_commons tags in OSM through iD.

By enforcing this arbitrary constraint that everything has to come from wikidata, you are excluding from openstreetmaps of useful (and increasingly popular) tags.

To be clear, iD is not stripping out wikimedia_commons tags. It even has a dedicated field for these tags. So there are no constraints to speak of.
If I understand correctly, your proposal is to automatically add the tag. Automatically adding wikidata based on wikipedia was already controversial at one point (somewhere in these discussions); adding wikimedia_commons based on wikidata might need a pretty strong justification to overcome skepticism of Wikidata.

There is no guarantee that anything on wikimedia commons will also be on wikidata.

You’re right, but my point is that Wikidata’s notability criteria are so straightforward for real-world features to satisfy – and automated edits are so welcomed on Wikidata – that creating Wikidata items could be a viable alternative to ensuring comprehensive coverage of wikimedia_commons tags in OSM through iD.

By enforcing this arbitrary constraint that everything has to come from wikidata, you are excluding from openstreetmaps of useful (and increasingly popular) tags.

To be clear, iD is not stripping out wikimedia_commons tags. It even has a dedicated field for these tags. So there are no constraints to speak of.
If I understand correctly, your proposal is to automatically add the tag. Automatically adding wikidata based on wikipedia was already controversial at one point (somewhere in these discussions); adding wikimedia_commons based on wikidata might need a pretty strong justification to overcome skepticism of Wikidata.

If I understand you correctly, you are saying that openstreetmaps contributors should stop adding wikimedia_commons tags to the maps, but instead add the same items to the wikidata (and then link wikidata instead).  I'm not aware of any community decision in this direction.  In fact, most wikimedia tags in openstreetmaps do not have an accompanying wikidata tag (39% have wikidata, 61% don't), as seen in taginfo https://taginfo.openstreetmap.org/keys/wikimedia_commons#combinations.
I don't quite get what the controversy is.  wikidata and wikimedia_commons are separate tags, that sometimes appear together (currenly about 39% of the time).  When they do appear together, ID should make it easier for the mapper and add both.

If I understand you correctly, you are saying that openstreetmaps contributors should stop adding wikimedia_commons tags to the maps, but instead add the same items to the wikidata (and then link wikidata instead).

That is not what I’m saying. It’s one thing for mappers to manually add a wikimedia_commons tag using either the existing Wikimedia Commons Page field or the raw tag editor; it’s another matter for iD to add it automatically. I was only pointing out that the community would need to be comfortable with an editor adding this key in potentially large numbers.

sometimes appear together (currenly about 39% of the time)

In fact, according to that link, less than 2% of features with wikidata have wikimedia_commons, but this number could rise with the proposed feature.


[Bug] when specified calendar.monthLabel.nameMap option, echarts halts with error

Version
5.5.1
Link to Minimal Reproduction
https://echarts.apache.org/examples/en/editor.html?c=area-pieces&version=5.5.1&code=PYBwLglsB2AEC8sDeAoWsAeBBDEDOAXMmurGAJ4gCmRA5JALZW0A0J6ARsAK7QAmAQwBO5AOICQRAGYCANniokAvm3Tkc-IqlJlKNWLQBuc7s1WkuvQSPGTYAbQAMLAwGZHAUloBdZeYDGclT8wlrssAwwYAAWADICHFSyYTro0AJMALISRPYARACMeSx5AEzFea4VACwVAKwVAGwVAOwVABwVAJwVBY69RSUF5d7m6Ep-JIb43HLZdtqkFNR0IBBU_lQA7vhm4XjRwFvScgpjsHwQTNB4UNBEzvtUQut4AJL8VBgP52sbVIQHOF0ItUrAAOZgIgFc46WRQ2CuWGkfzAWTAIR0ITgjgCAAUzlghIK7UJjgAdNUAJS0YGwFR00GpSFEOrI9DwogtdmwVHozEGbG4gkuYmk0WUml0iY6XzjcwKF4A3LhJnoZb6WiyCDQPZgvCRYAxB7kxrIvDkBhcZIGaAwPWpbW6gDKFFk-jVKLRGLoAGI6tUWo4AMKNVh09A7PjG2B1aXIhjCADWsR1HojsAtVrRuVodt1rFt9p8PNkCSSWkzh2OsBk8io9J5gjAAlySEwGkBBUbyA7uEBrh77ew_dZQ77mlgLXpctSDLBwioAld5HdWnnqWbraBYPQ9jxuq2sAAIgIwFQ8bRSo4Cl0ALR9B-OWhUqnk8FUMAAFSuF6pLmvRxRgzfdDxPM8LyvG97wKAoHwKF83w_b9fzxf9Y0aICeVA7ZwPPS9r1vB9SmIxD30_H8mDQlwWjqLCQIPXDT3wqDrzvG8H1cMjkMov8XDqUlgN3BxGKPZjIOvNjHBIgpqm4ijUPQ0o6KE3ccLEiCCOkxx2PaB86nklCqPQ9x6OE9S8Ik7T2JgsNX3Ioy-NgaoVOw0TLK0tjYIfFpDN46jEUcMy1Pc8TPLg6SH3aPzFJcPogLpWdxhIXwlAAbiAA
Steps to Reproduce

make table with x-axis as timestamp (milliseconds from 1970-01-01T00:00:00Z)
include option calendar.monthLabel.nameMap as array of string (example: ["1", "2", ..., "12"])
draw chart

Current Behavior
no chart appears.
in console, an error (accessing undefined.toString()) is reported.
Expected Behavior
chart appears, its x-axis label is based on nameMap option.
Environment
- OS: Windows 11 23H2
- Browser: Mozilla Firefox 129.0.2
- Framework: of official editor's

Any additional comments?
When you remove calendar object from the option, it works and a chart appears.

calendar.range is required, but missing in your code.
📌 please close issue if problem solved.

Thank you, I confirmed adding calendar.range enables Echarts work again.
I close this issue, but I'd be happy if remark like 'make sure setting calendar.range' to the nameMap option document.


Removing COM substrate correction & bugfix with phase_cross_correlation

After discussions with the NIRCam Team we are removing the COM substrate correction as it had already been accounted for in the JWST pipeline photometric calibration (@mperrin @AarynnCarter).

Ok, I did not realize that I cannot make two separate PRs from the same branch. Anyway, the second change is going back to the integer pixel centering. There are several reasons for that. Firstly, the injection-recovery module only works correctly if the ImageTools recenter function uses the same absolute center as pyKLIP. This is obviously a little buggy, but that is how it works for now. We could also change the entire ImageTools recenter code to center on the pixel corner, but that was not done intentionally since we also want to use this function to get the peak value of PSFs for contrast curve calculations. In general, I prefer centering on an integer pixel instead of the pixel corner for that reason. One immediately gets the peak value of the centered PSF which is needed by pyKLIP. Of course, for the KLIP algo itself it doesn't really matter where the center is, but to be consistent throughout all of the code, I recommend always using integer pixel centering.
@AarynnCarter Opinions? Would your calibrated contrast curves code still work?

@kammerje I just noticed this was merged into develop but I don't think we've reached a consensus on the pixel centering. Could you give my earlier message a read through and let me know what you think? I'm really not sure that the current approach is correct.


Add 'maxRowsInGroup' parameter to join query

One too big group of join can make whole system holt. Throw exception for that case.

Done


version check logic error

Brief description of your issue
When I perform a winget upgrade on my computer, I find that the installed version of multiple software listed is greater than the available version, but it still appears in the list, which is incorrect
Steps to reproduce
1. winget upgrade

For example, in Stardock Fences 4 here, the installed version is <IP_ADDRESS>, and the available version is 4.07.02. Obviously, my current installed version is greater than the available version, so it should not appear in this list
Expected behavior
Properly check the installed and available versions, when the installed version is greater than the available version, it should not be listed
Actual behavior
a wrong version is listed
Environment
[winget --info]

Windows 程序包管理器 v1.5.2201
版权所有 (C) Microsoft Corporation。保留所有权利。

Windows: Windows.Desktop v10.0.25931.1000
系统体系结构: X64
软件包: Microsoft.DesktopAppInstaller v1.20.2201.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

链接
----------------------------------------------------------------------------
隐私声明             https://aka.ms/winget-privacy
许可协议             https://aka.ms/winget-license
第三方声明           https://aka.ms/winget-3rdPartyNotice
主页                 https://aka.ms/winget
Windows 应用商店条款 https://www.microsoft.com/en-us/storedocs/terms-of-sale

管理员设置                                状态
------------------------------------------------
LocalManifestFiles                        已禁用
BypassCertificatePinningForMicrosoftStore 已禁用
InstallerHashOverride                     已禁用
LocalArchiveMalwareScanOverride           已禁用

For example, in Stardock Fences 4 here, the installed version is <IP_ADDRESS>, and the available version is 4.07.02. Obviously, my current installed version is greater than the available version, so it should not appear in this list

The comparison logic does seem to be working properly. Breaking down the version comparison, by parts the installed version breaks down to {4, 2, 1, 2} and the available version breaks down to {4, 7, 2, 0}. Then, going through one at a time 4 is equal to 4, so move to the next part. 2 is less than 7, so the versions are not equal. Since 7 is greater than 2, then 4.07.02 should be a higher version than <IP_ADDRESS>.
This may be a case where the publisher does not use semantic versioning, in which case this won't be able to be truly solved until either marketing versions are added, or the publisher moves to use Semantic versioning. What we can do as a temporary fix is to remove 4.07.02 from the available packages

Related to #3061


Is the dpo loss wrong?

Why is loss assigned three consecutive values?

Sorry I know it's confusing, this part of the code is not maintained and we didn't use them anywhere... will clean that up later

As Zhili mentioned, we did not use this loss as it was not converging well for us and the general idk and KL losses worked better. I have fixed the thing we used for debugging in the latest commit https://github.com/locuslab/tofu/commit/80159d8ea39edf147fb09cd82aefa08e506e6718
Thanks for pointing it to us!

As Zhili mentioned, we did not use this loss as it was not converging well for us and the general idk and KL losses worked better. I have fixed the thing we used for debugging in the latest commit 80159d8 Thanks for pointing it to us!

Thank you for answering.
I want to ask another question: why this dpo fail to train models to answering "I don't know"?
I'd appreciate it if you could help me with that.


32 applicant list filter component

Responds to #32, and its bind to this issue.
This component is used in auto as a filter for filtering applicants rendered with one of this three status: pending|accepted|excluded.
Receives 4 parameters, the amounts to be shown and a function to be executed once we check one of the boxes. If you want to execute different functions from the incoming checkbox, the way is to pass a function that receives an input parameter, this way:
handleCheck ({ target }: { target: HTMLInputElement }) {
  // target contains in 'name' property the name of the input coming from the executed change.
  (...)
}

For the reviewer: I took this PR in advantage to also change some styles from ApplicantBadge.js component.

👌 🚀

@falcoagustin looks good. I made one change here: https://github.com/x-team/auto-ui/pull/33/commits/9c229860a0723f5944a27f2718aa5d95da7bc3af
Since the 3 items have almost identical code, I've replaced the duplication with a map

@joshwnj Yeah I thought about that but as it were only three items I thought it wasn't needed and it was clearer to explicitly add the 3 types instead of a map, either way though was fine for me 🙂

@falcoagustin no worries :)
For future reference, here's the reason I would argue that a map is clearer than longhand: when the 3 sections are written out explicitly, you have to look very closely to understand what the differences are between the 3.  There might be one small sneaky difference that you miss at first glance.  But if we use a map you can instantly see which parts are the same and which are not.


This project is supported by: BrowserStack

In what way?

I initially had the plan to build a webinterface. To test this, i used a BrowserStack account. To get this account they want you to put this on the project page.


Make download-secure-migrations script govcloud only

Description
The download-secure-migration script (https://github.com/transcom/mymove/blob/master/scripts/download-secure-migration) pulls secure migrations from the commercial cloud. Now that we've switched over completely to GovCloud, however, this script has been change to accommodate.
Reviewer Notes
I pulled out the run command. I don't know why (found the same thing in the upload script) but it fails when I use that but works perfectly well without. Please some person more familiar with bash inform me why and how to use! TY
Setup
Follow instructions here: https://github.com/transcom/mymove/wiki/migrate-the-database#downloading-secure-migrations
Add any steps or code to run in this section to help others prepare to run your code:
download-secure-migration <production_migration_file>

Code Review Verification Steps

[ ] Secure migrations have been tested following the instructions in our docs
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Fails

:no_entry_sign:
Yarn Audit Issues Found:
high - Prototype Pollution in node-forge
Package node-forge
Patched in >= 0.10.0
Dependency of react-scripts
Path react-scripts > webpack-dev-server > selfsigned > node-forge
More info https://npmjs.com/advisories/1561
1 high vulnerabilities and 0 critical vulnerabilities found

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against e4058bdbd4b79091b6c63ad06682280f6648504e


Xocde 11

When upgrading to Xcode11, the FlagKit throw an error:
"Distill Failed for unknown reason.
FlagKit .xcassets"

Is the name of your bundle "FlagKit .xcassets"?
Does anything in this thread help you solve it?

Hi,
yes it is FlagKit.xcassets , what do you think the issue is?

I even tried to test the FlagKitDemo-iOS on same Xcode version 11 with same error result.

Hi,
I managed to resolve the issue. it was because macOS Catalina beta version with xocde 11 production is not able to detect the bundle.
i downgrade it to Mojavi and gets back to work fine.
P.S. if you have Catalina beta version with Xocde 10 version, you will not get such bug. it is only if upgraded to Xocde 11 production version.

Oh, interesting, thanks for the research! Hopefully this gets resolved with the Catalina GM.


ta cusor size(height) display not right when set ta's child label style

1、My littlevgl version is the latest 5.3(2019-03-01 code)
2、The test code is the lv_test_kb_2, i want to set ta fixed size: width 200pix, height 60pix，
and set the ta's child label style：talabelstyle.text.font = &lv_font_dejavu_40;
the corresponding effect could be that the height of cursor is 40pix(or 60pix ？)。
In the result of test in first display，the height of cusor is not right。

And the height is right when i input some char by kb.

i follow the code to find the height is 20pix。
my test code is：
void lv_test_kb_2(void)
{
	lv_obj_t * ta = lv_ta_create(lv_scr_act(), NULL);
	//lv_ta_set_text(ta, " ");
	lv_obj_align(ta, NULL, LV_ALIGN_IN_TOP_MID, 0, 30);
	lv_obj_set_size(ta, 200, 60);
	static lv_style_t talabelstyle;
	lv_style_copy(&talabelstyle, lv_obj_get_style(lv_ta_get_label(ta)));
	talabelstyle.text.font = &lv_font_dejavu_40;
	lv_obj_set_style((lv_ta_get_label(ta)), &talabelstyle);
        ...
}

how to make the cursor height shows be right in first display ？
or how to make the cursor height be synchronized with ta size ？
Thank you very much。

@HinsunRan This problem was fixed in dev-6.0 but not in master. I just applied the fix to the master branch, can you test that it works now?

Great! It is working now. The height of cursor is right in first display.
And the height be synchronized with ta size, i will solve it by refering to your method.
Thank you very much.


ProtonDrive

https://proton.me/drive/download

https://community.chocolatey.org/packages/protondrive


Add timeline token to config

Hey,
I've been working on an openHAB action that can push pins to the timeline on Pebble watches. More information can be found in this forum post: https://community.openhab.org/t/pebble-timeline-action/4916/1
To use this, you need the timeline token from the openHAB watch app. This pull request display this token on the configuration page. I first wanted to show this token on the watch app, but copying this from the tiny screen is not that easy :smiley:
This pull requests needs two additional actions:

Update of the configuration HTML page, see #15
Enable timeline functionality for the app in the pebble dev center. This is described here: https://developer.getpebble.com/guides/timeline/timeline-enabling (just one push of a button)

Let me know if you need any more information.

This seems like a pretty cool addition.  What's the status of getting the action merged into the openHAB server codebase?

Thanks for merging this! I still have to submit a pull request for the action, I'll get to that in the next few days.


Remove unnecessary assert

(since we allow already open file to be opened again even through openFile command - partially) from updateOpen command
Fixes #35034

@typescript-bot cherry-pick this to release-3.8 branch


pantheon.elementary-mail: 6.4.0 -> 7.0.0

Description of changes
#170361
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

pantheon.elementary-mail: 6.4.0 → 7.0.0

[ ] ComposerWidget: Make ACTION_ENTRIES private (#765)
[ ] Round app icon (#780)
[ ] Update io.elementary.mail.appdata.xml.in
[ ] Fix FolderThreadNode use after free crash (#770)
[ ] Fix #764: Mail Account Duplication (#769)
[ ] Flatpak: update to Platform 7 (#782)
[ ] Show recipient in Sent folder instead of sender (#771)
[ ] MainWindow: Use multiple headerbars (#776)
[ ] Update screenshot
[ ] Actions: bump release to horus
[ ] Release 7.0.0 (#781) Tagged: 7.0.0

@ofborg test pantheon

Let me backport...:woman_facepalming: 6.x is mostly not usable due to all those crashes and UI freezes.