Use sdc submit button to submit questionnaire in catalog app.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1211
Description
Remove Submit questionnaire menu from catalog app, and related files and resources.
Use datacapture Submit questionnaire button.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10
current pr is follow up pr of below pr.
can you please review pr https://github.com/google/android-fhir/pull/1201?

#1201 is merged.

Working on review comments.

https://user-images.githubusercontent.com/86107848/171109278-95d102f8-381c-468c-a10d-335d95058c51.mov

love how the results api makes everything simpler! 👍
can you add some tests to the datacapture lib?

Actually, there is separate issue https://github.com/google/android-fhir/pull/358 for Questionnaire Fragment tests, there is no QuestionnaireFragment test suite yet #358, thinking to have separate pr for code coverage once above pr in.
is that okay?

love how the results api makes everything simpler! 👍
can you add some tests to the datacapture lib?

Actually, there is separate issue #358 for Questionnaire Fragment tests, there is no QuestionnaireFragment test suite yet #358, thinking to have separate pr for code coverage once above pr in. is that okay?

i really don't want to set this precedent - but given how long this pr has been around this is ok. Please do a follow-up PR immediately!

love how the results api makes everything simpler! 👍
can you add some tests to the datacapture lib?

Actually, there is separate issue #358 for Questionnaire Fragment tests, there is no QuestionnaireFragment test suite yet #358, thinking to have separate pr for code coverage once above pr in. is that okay?

i really don't want to set this precedent - but given how long this pr has been around this is ok. Please do a follow-up PR immediately!

Sure, Thanks!


'message.latlons()' raises MemoryError on rotated lat-lon grids

latlons() raises a MemoryError on grib files/messages that contain a rotated lat-lon grid, which is supported according to the docstring.
Code that reproduces the problem:
msg = pygrib.open("example.grb2")[1]
msg.latlons()

example.grb2 with rotated lat-lon grid: example.zip
Output:
  File "test.py", line 10, in main
    msg.latlons()
  File "pygrib.pyx", line 1808, in pygrib.gribmessage.latlons
  File "[...]/lib/python3.6/site-packages/numpy/lib/function_base.py", line 4698, in meshgrid
    output = [x.copy() for x in output]
  File "[...]/lib/python3.6/site-packages/numpy/lib/function_base.py", line 4698, in <listcomp>
    output = [x.copy() for x in output]
MemoryError

Tested with:

Pygrib 2.0.3
Python 3.6
Cython 0.29.1
Ubuntu 18.04

The error does not occur with files (from same origin) that contain a regular lat-lon grid.

OK, here's my hypothesis.  The pygrib code assumes that distinctLatitudes and distinctLongitudes are the 1D arrays of lats and lons in the rotated coordinate system.  ecCodes (formerly grib_api) used to provide this info, but it no longer does.  I don't know what those arrays are populated with any more.  We do have a test_rotated_ll.py test script - it used to work but now produces the same MemoryError.
In summary, somewhere along the line the behavior of the C lib changed for the rotated lat/lon grid.

Potential fix in pull request #100 (branch issue99).  Please give it a try and let me know if it solves it for you.

Thanks for the quick fix. And sorry for the delay. I'll test it...

OK, it solves the issue. Thank you.
I'm not familiar with the C lib, so I can't tell whether this is the "right" fix.


testcontainers is unable to start in CodeBuild

I have a simple test starting postgres container:
describe('Test', () => {
    let pgContainer: StartedPostgreSqlContainer

    beforeAll(async () => {
        pgContainer = await new PostgreSqlContainer("public.ecr.aws/docker/library/postgres:14.2-alpine")
            .withWaitStrategy(Wait.forLogMessage('database system is ready to accept connections'))
            .start()
    })

    afterAll(async () => pgContainer.stop())

    it('should connect to pg', async () => {
        // test
    })
})

It works perfectly well on my laptop.
Expected Behaviour
I expect this test to run successfully in AWS CodeBuild.
Actual Behaviour
CodeBuild build hangs while starting the container and eventually times out.
Testcontainer Logs
testcontainers DEBUG Found applicable registry auth locator for registry "public.ecr.aws": Auths
testcontainers DEBUG Found applicable Docker client strategy: UnixSocketStrategy
testcontainers DEBUG Testing Docker client strategy URI: unix:///var/run/docker.sock

thrown: "Exceeded timeout of 120000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

Environment Information

Operating System: Amazon Linux 2 x86_64 standard image, version 4.0
privileged flag is set to true (as stated in https://stackoverflow.com/questions/72278034/aws-codebuild-how-to-run-tests-that-require-starting-docker)
Node version: 16
Testcontainers version: 8.12.0

Important note
I tried running the same test written in Java, within the same CodeBuild env, and it completes successfully, without any issues / timeouts. It leads me to think that the issue comes from testcontainers-node and not env configuration.

I tried running the same test written in Java, within the same CodeBuild env, and it completes successfully, without any issues / timeouts. It leads me to think that the issue comes from testcontainers-node and not env configuration.

Interesting, thanks for raising, I will take a look when I can.

Facing the same issue. Any updates @cristianrgreco?
The testcontainer works like a charm on my local machine but hangs on AWS CodeBuild. I checked to make sure the docker daemon on aws codebuild, with privileged access, but facing the same issue.
Environment Information

Amazon Linux 2, version 5
Node version: 16
Testcontainers version: 8.13.0

+1

Hi, should be fixed in version 8.13.2, please confirm

Hey @cristianrgreco, can confirm, this update fixed the issue. Many thanks!

Now everything works very well! Thank you!

I can confirm this has solved same issue when running test-containers with our self hosted Github runners.


Save the world - Tapping "I am a teacher" user is prompted to update the email address

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/23063
Action Performed:

Go to https://staging.new.expensify.com/
Log in to your Gmail account
Tap Fab
Tap Save the world
Tap " I know a teacher"
Enter all required fields
Tap Let's do this
Tap back button
Tap fab
Tap save the world
Tap " I am a Teacher"

Expected Result:
User must be redirected to the registration screen as in expensifail account
Actual Result:
User is prompted to update the email address
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.59
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/81e5744b-fe3e-489f-8c43-ff2d90a8ff4e
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

This is expected behavior, when signing up as a teacher, the email must belong to a private domain.


global: use inspire-schemas for countries

Depends on https://github.com/inspirehep/inspire-schemas/pull/397

@harunurhan updated


Overrides classification

Following a discussion related to the iOS implementation, we defined 4 types of overrides:

chrome (UI);
chrome advanced;
user overrides;
user overrides UI.

It would be great if we could reach a consensus so that this classification can become some sort of recommendation.
Chrome

reading modes
paged/scrolled view

Chrome advanced

number of columns
margins
custom reading modes (background and text color)
filters (darken and invert for night mode)

User overrides

font-family
font-size

User overrides advanced

line-height
text-align and hyphens (those two should work together)
paragraph spacing
paragraph indent
letter-spacing
word-spacing
type scale
all bold (that should probably be a typeface in the humanist stack though)
no italics

Opinions?
[edit] We’ll also probably have extra a11y-related settings e.g. “all bold”, “strip italics”, etc. That could be automatic flags we add when the user picks a theme or even a typeface, or advanced user overrides.

I think the last two (currently labeled as "Undefined") should be listed under "User overrides advanced".

Yeah, probably. I’ll edit so that we don’t have undefined, we can move settings if needed anyway.

We also have to keep in mind that for certain user profiles, dyslexic people in particular, access to font-family, line-height, letter/word/paragraph-spacing and text-align will be of paramount importance and a very good UX will be required.

And we don’t currently cover themes in this classification, which are a set of user overrides (both “normal” and advanced) e.g. there could be a theme with presets for dyslexia the user would then be able to customize/fine-tune.

Added “a11y flags” (see edit)
An interesting development there is variable fonts.
Sadly there are still in their early days and support + catalog of fonts are lacking at the moment, but that could help tremendously with such flags. I.e. a conditional UI telling something like “Oh I can see you’re making the font bolder, do you wish to strip italics?”

FYI I’m planning to modularize the user settings settings based on those categories. We indeed have quite a monolithic stylesheet at the moment and it’s all or nothing so, should implementers choose not to offer some settings, there’s a lot of removal to do at the moment (and we can probably help by providing them with more flexibility e.g. not using the advanced user overrides at all).

This has been documented in the alpha version and can consequently be closed.


I want to know the usage scenarios of "edge.To" and "edge.From" so that I can better understand how to use it correctly。

The description of the document is not convenient for me to understand, I don't understand when I should use edge.From instead of edge.To. Because you can establish a relationship using edge.To.

Hi @TNED ,
Thanks for reaching out.
In general, edge.To is the "owner" of the edge, and edge.From is not mandatory, provides a "virtual" backreference that is very convenient to use.  With O2M, relations for example, the entity that has the .To side of the edge will have the FK column.
You can find the full documentation including full examples on how to establish relations between two entities in the Edge Relationships Guide.
Let me know if this answers your question or if you need any more assistance.


FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

Related to #21041 that has been closed.
Issue is still present, but goes away as soon as sourceMaps is set to false inside angular.json.

Duplicate of https://github.com/angular/angular-cli/issues/21779


The --owner flag in ign fuel list switches the command to search only cached models

Environment

OS Version: Ubuntu 18.04
Source or binary build? Binary 5.1.1

Description

Expected behavior: ign fuel list -o openrobotics -t model should list all models from openrobotics available on Fuel.
Actual behavior: It only lists locally cached models when run with a non-empty cache.

Steps to reproduce

mkdir /tmp/fuel_test1

IGN_FUEL_CACHE_PATH=/tmp/fuel_test1 ign fuel list -o openrobotics --type model | wc -l
815

mkdir /tmp/fuel_test2

IGN_FUEL_CACHE_PATH=/tmp/fuel_test2 ign fuel download -u "https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/Tunnel Tile 4 Lights"

IGN_FUEL_CACHE_PATH=/tmp/fuel_test2 ign fuel list -o openrobotics --type model | wc -l
8

This is at least unexpected. I'd expect either a switch that would allow me choosing between all and cached models, or a warning/info message, that would tell me that the command uses only what it found in the local cache.
When called without the --owner flag, the command seems to always contact the fuel database and downloads the list of all models.

I agree that it's not a behaviour the user would expect. Here's where the cache is checked:
https://github.com/ignitionrobotics/ign-fuel-tools/blob/4bb5bfa8eabad7f11669d6296f6b59ff921427ff/src/FuelClient.cc#L383-L388
At a minimum, I think we could offer a flag to only check the cache, or check the server.

I think a CLI flag would be the best. I just can't decide what should be the default behavior. But I'm a little bit more inclined for searching the online DB by default.

As a user, I'd expect to get all of an owner's models with that invocation, online or otherwise. So I agree that searching online would be a good default behaviour.


🐛 ScaffoldPage wrong background color if there is no NavigationView

Describe the bug
With a light theme we had a black background color if no NavigationView is present.
With a dark theme, the page come more black.
Screenshots

Additional context
The problem came with the version 3.10.0 with this commit: https://github.com/bdlukaa/fluent_ui/commit/50419a187aeb1d1487afab216099fae80c2840e1
As @bdlukaa said:

scaffolds need a rework

So far I have encapsulated all my ScaffoldPage in a NavigationView and it works fine. We need to see if there is a way to simplify things so that we don't need a NavigationView. But it doesn't seem to be a priority anymore.

I noticed the same, I have a few pages that are shown outside of a navbar context. For now I've just created a widget that replicates the same behavior, putting a Mica behind it with the same approach for picking a color. Probably using a NavigationView also like you mention would have been OK instead of this widget.
class StandaloneAppPage extends StatelessWidget {
  final Widget child;
  const StandaloneAppPage({
    Key? key,
    required this.child,
  }) : super(key: key);

  @override
  Widget build(BuildContext context) {
    final theme = FluentTheme.of(context);
    return Mica(
      backgroundColor: theme.navigationPaneTheme.backgroundColor ??
          theme.micaBackgroundColor,
      child: child,
    );
  }
}

This issue is not reproducible on the latest master. Can this be closed?


Preliminary runoff model

Purpose
Lays the groundwork for including surface runoff (applied as part of the boundary condition for soil) and for subsurface runoff (applied as a sink term for the soil model).
In this implementation, we assume that

a single runoff model struct will specify both surface and subsurface runoff parameterizations (these are often linked)
and that the use case is
modeling runoff (or not) with Richards model or with the full soil model, either in standalone mode or as part of an LSM.
only modeling runoff for the special cases of a simulation which prescribes precipitation (Richards model) or precip+atmospheric conditions+radiation conditions (which in turn leads to a computation for evaporation, SHF, LHF, radiative fluxes...; EnergyHydrology model).

I.e. we wont support:

just adding subsurface runoff, but not surface runoff, or vice versa
somehow combining runoff with other types of boundary conditions

See Issue #266
Contents
More major changes:

introduces RichardsAtmosDrivenFluxBC which serves the same role as AtmosDrivenFluxBC, but for Richards equation. New boundary_flux method for this BC. Not currently used - should we add now? but I think this could be useful to have.
methods for soil_boundary_fluxes for bc::AtmosDrivenFluxBC and boundary_flux for bc::RichardsAtmosDrivenFluxBC compute infiltration using a function defined in runoff.jl (soil_surface_runoff())
Both richards and energy hydrology model constructors add the subsurface flow sink term to the equations based on the type of the boundary condition at the top - i.e. it will only do so if the BC is of type RichardsAtmosDrivenFluxBC or AtmosDrivenFluxBC. It has to add something of type AbstractSoilSource - use soil_subsurface_source().

Minor changes

Adds docstrings/updates APIs
fixes the same bug appearing in two files: docs/tutorials/Usage/LSM_single_column_tutorial.jl and tests/integrated/soil_energy_hydrology_biogeochemistry related to how boundary conditions are specified.
additional type signatures for boundary_flux methods, minor changes in arguments to boundary_flux, soil_boundary_fluxes, and ClimaLSM.source! methods.

soil_boundary_fluxes(bc, boundary, model, dz, Y, p, t)
boundary_flux(bc, boundary, model, dz, Y, p, t)
ClimaLSM.source!(dY, src, Y, p, model)

Review checklist
I have:

followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
checked that this PR does not duplicate an open PR.

In the Content, I have included

relevant unit tests, and integration tests,
appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

[X] I have read and checked the items on the review checklist.

bors r+


indicate ongoing upgrade

this makes it easier for the crowbar api to determine if the upgrade
is running.
also use a variable for the crowbar install directory.

+1

+1

Please backport to 3.0


only some of affiliation being stored

email doesn't seem to be saving properly either

Debug tracing:

data is stored properly in DocumentDB

Affiliation display issue fixed in https://github.com/digitallinguistics/dlx-org/commit/185ff27972b099f9dbb628130db905bd773f2952


Face mesh landmark points for nose when draw connections

Please make sure that this is a solution issue.
System information (Please provide as much relevant information as possible)

Have I written custom code (as opposed to using a stock example script provided in Mediapipe):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04, Android 11, iOS 14.4):
MediaPipe version:
Bazel version:
Solution (e.g. FaceMesh, Pose, Holistic):
Programming Language and version ( e.g. C++, Python, Java):

Describe the expected behavior:
Standalone code you may have used to try to get what you need :
If there is a problem, provide a reproducible test case that is the bare minimum necessary to generate the problem. If possible, please share a link to Colab/repo link /any notebook:
Other info / Complete Logs :
Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached:
I want to draw the outer nose when using face mesh landmarks. There are points in face_landmarks_to_render_data_calculator.cc file that can connect lips, eyes and eyebrows, but no for nose. Are there nose points for the 468 face landmarks? Thank you.

I'll talk to the team about formally exposing a set of nose connections, but you can already use the points to define your own outline.  You'll see that I just record the points as a set of array pairs specifying starting point and ending point.


This Fixes #85  'angular.merge is not a function .controller'

Need some tests for pfUtils.

Also, why don't we just use angular.extend()

The extendDeep copy does not clone the second argument's (defaultConfig) fields when copying to the dst object. This causes the defaultConfig to be modified if the dest object is modified for fields that are objects or arrays.

"Also, why don't we just use angular.extend() instead of angular.merge()?"
angular.extend() doesn't do a deep copy.

"Need some tests for pfUtils."
There chart and view objects which use pfUtils do have unit tests which verify pfUtils is working correctly.

There chart and view objects which use pfUtils do have unit tests which verify pfUtils is working correctly.
No they don't, they verify that angular.merge() is working correctly (or in the case of 1.3, _.merge).  If we're going to keep this approach it needs to be tested, especially this new extendDeep() function.

angular.extend() doesn't do a deep copy.

Then what about _.extend()?  Since we're requiring underscore can't we just use that and get rid of the need for pfUtils?

Underscore extend is a shallow copy, we need a deep copy.  pfUtils is need for those customers who are < angular-js 1.4 and are using underscore (not lodash).  In this case, we need to make our own 'extendDeep' function.

Underscore extend is a shallow copy, we need a deep copy. pfUtils is need for those customers who are < angular-js 1.4 and are using underscore (not lodash). In this case, we need to make our own 'extendDeep' function.

How long will we support < angular 1.4?  Should we file an issue to get rid of pfUtils at some point in the future?  I don't think we want to support this indefinitely and it introduces extra dependencies that will not be needed once people upgrade.

Hi, I believe my latest push addressed all issues.
If so, @jeff-phillips-18 please merge
-thanks

Hi @jeff-phillips-18, latest push address you last comment  -thanks


KOGITO-9646: cli kn workflow output is missing workflow string in output

Jira: https://issues.redhat.com/browse/KOGITO-9646 (detailed description of the issue).
The issue was that cobra.Command{Use: is not taking names with spaces. This is fixed in this PR by using \u00A0 (no-break space) instead of space in kn workflow. The same approach is used in kn-admin.
In this PR:

fix of kn\u00A0workflow
alias for kn-workflow
a test that ensures command output contains the correct kn workflow
a test that checks that all the subcommands (except the Cobra-generated ones) are present
update of knative.dev/client/pkg/kn/plugin to v0.38.0

Output of running kn-workflow or kn workflow after the fix from this PR:
Manage SonataFlow projects

Usage:
  kn workflow [command]

Aliases:
  kn workflow, kn-workflow

Available Commands:
  completion  Generate the autocompletion script for the specified shell
  create      Creates a new SonataFlow project
  deploy      Deploy a SonataFlow project on Kubernetes via SonataFlow Operator
  help        Help about any command
  quarkus     Manage SonataFlow projects built in Quarkus
  run         Run a SonataFlow project in development mode
  undeploy    Undeploy a SonataFlow project on Kubernetes via SonataFlow Operator
  version     Show the version

Flags:
  -h, --help      help for kn workflow
  -v, --version   version for kn workflow

Use "kn workflow [command] --help" for more information about a command.


Do I have to have the other node apps on?

Let's say that I have 3 apps; #1 is the proxy and using this http-proxy-rules, #2 nodeapp1 was built using Restify and #3 nodeapp2 was built using Restify as well. I'm using PM2 to keep them alive.
My proxy server's main.js looks like this:
var proxyRules = new HttpProxyRules({
     rules: {
         '.*/test': 'http://localhost:8081', // Rule (1)
         '.*/test2/': 'http://localhost:8082' // Rule (2)
    },
    default: 'http://localhost:8080' // default target
});
...
http.createServer(function(req, res) {
   var target = proxyRules.match(req);
   if (target) {
       return proxy.web(req, res, {
             target: target
  });
}

   res.writeHead(500, { 'Content-Type': 'text/plain' });
   res.end('The request url and path did not match any of the listed rules!');
}).listen(8080, cb);

As you can see, I didn't follow your example. In your example, you used port 6061 on the proxy server which is a different number from the test and test2 which both have the same port number 8080 because your specific example didn't work for me.
Question #1: I would like to know how you did this. If possible, I would like to know how to use the same hostname and the same port number for all 3 apps.
Question #2: How did you come up with the a url that has the same hostname and port number but different different paths which are cool and cool2?
Question #3: If I copy exactly your example, do I have to have nodeapp1 and nodeapp2 running or do I just have the proxy server run?
My nodeapp1's app.js ends in this:
app.listen(8081, function() {
    console.log('nodeapp1');
 });

Same for nodeapp2:
app.listen(8082, function() {
    console.log('nodeapp1');
 });

Hey @junerockwell , to answer your questions,
A1. (ans to Q1) You can have different apps running on the same hostname + port as long as they are served through different url paths.
A2. (ans to Q2) Hm, I'm not sure what you mean by this. The proxy server lives on port 6010 in the example and forwards requests to a particular url based on the original request url path. e.g., in my examples, if the proxy server was running with hostname example.com and it received a request for http://example.com:6010/test/duck, the server would forward the request to http://localhost:8080/cool/duck.
See these tests for more examples of url path translation.
A3. (ans to Q3) You only need a total of one web service running at a minimum. You can think of http-proxy and http-proxy-rules as just normal node modules. They can run on top of an existing web service (e.g., an http server) or you can use the http-proxy module to spawn your own webserver by invoking .listen() on the proxy instance.


The link to "EF Core with MVC, existing database" is broken

When I hover over the link to "Data Access - EF Core with Razor Pages - EF Core with MVC, existing database it shows https://docs.microsoft.com/en-us/ef/core/get-started/aspnetcore/existing-db?toc=%2Faspnet%2Fcore%2Ftoc.json&bc=%2Faspnet%2Fcore%2Fbreadcrumb%2Ftoc.json&view=aspnetcore-3.0 However, it redirects me to Get started (Tutorial 1 of 8) page that is code-first tutorial

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a54c97f-ddd4-b041-5e5f-a2df009ace50
Version Independent ID: fa488196-1f98-08ea-adcc-17d9dac86727
Content: Razor Pages with Entity Framework Core in ASP.NET Core - Tutorial 1 of 8
Content Source: aspnetcore/data/ef-rp/intro.md
Product: aspnet-core
Technology: aspnetcore-data
GitHub Login: @tdykstra
Microsoft Alias: riande

@tdykstra  please advise.


Server 2003 to a clustered file server seemingly not possible

I think this should be noted somewhere. Unless I'm wrong, you need to not have KB4512534 to migrate from Server 2003, and you need KB4512534 to migrate to a clustered file server.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f348eda3-6195-cd36-9bf9-769b6c37927b
Version Independent ID: a2255385-394e-7ee0-a90d-dcaca017a3d4
Content: Storage Migration Service known issues
Content Source: WindowsServerDocs/storage/storage-migration-service/known-issues.md
Product: windows-server
Technology: storage
GitHub Login: @nedpyle
Microsoft Alias: nedpyle

@steved0x this content referenced was removed months ago. Please close this.

#please-close


[Taskflow] fix task flow for qwen2

PR types

Bug fixes
PR changes

APIs
Description

增加qwen2到taskflow

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix avoid table not exist error (#37593)

Query following createting table would throw table not exist error.
For example.
t1: client issue create table to master fe
t2: client issue query sql to observer fe, the query would fail due to not exist table in plan phase.
t3: observer fe receive editlog creating the table from the master fe
After the pr:
query at t2 would wait until latest edit log is received from master fe in the observer fe.
Proposed changes
Issue Number: close #xxx

run buildall


[BUG]: Document Asset missing option to send to another project

Scenario: Manipulate assets in a project
Step: 4 Send asset to another project
Link to the project: https://app.staging.terarium.ai/projects/a2a48418-dc22-4e72-a7b6-45ae28e3998c/overview

Issue:

The menu with the option to send the pdf document to another project is missing

Need confirmation that this is intended behaviour. Because sending a document to another project would require copying the document in s3

Nice to have!


Windows node pool not supported in kubernetes

Lab/Demo: 01 Deploy applications to Azure Kubernetes Service (AKS)
Task: 02  Create an Azure virtual network and an AKS cluster
Step: 10 Add node pool
Description of issue
You're instructed to use Windows OS for the new node pool, but Azure's own platform says Windows nodes are not supported on kubernetes [p1].
[p1]

This is resolved
rgds
Marcin


Pod Install --repo-update Fails with "Remote branch 5.0.3 not found in upstream origin"

Prerequisites

[X] This is not a Security Disclosure, otherwise please follow the guidelines in Security Policy.
[X] I have searched in this repository's issues to see if it has already been reported.
[X] I have updated to the latest released version of the SDK and the issue still persists.

Bug summary
When running the command pod install --repo-update in the iOS directory of my project, I am encountering the following error:
warning: Could not find remote branch 5.0.3 to clone. fatal: Remote branch 5.0.3 not found in upstream origin Failed to install Pods:   command failed with exit status 1 (pod "_1.15.2_" "update" "--no-repo-update"):     [!] [Codegen] warn: using experimental new codegen integration     [!] Error installing AEPEdge     [!] /opt/homebrew/bin/git clone https://github.com/adobe/aepsdk-edge-ios.git /var/folders/7l/rszmbrmd6tv4pg52z6ql_5rc0000gn/T/d20241023-10432-fzshxw --template= --single-branch --depth 1 --branch 5.0.3 Retrying with pod repo update...
It appears the branch 5.0.3 does not exist in the remote repository, which is causing the pod installation to fail.
Environment
OS: iOS
SDK(s): AEPEdge
Steps to reproduce

Create a new React Native project.
Install npm dependencies.
Navigate to the iOS directory.
Run the command: pod install --repo-update.

Current behavior
warning: Could not find remote branch 5.0.3 to clone.
fatal: Remote branch 5.0.3 not found in upstream origin
Failed to install Pods:
command failed with exit status 1 (pod "1.15.2" "update" "--no-repo-update"):
[!] [Codegen] warn: using experimental new codegen integration
[!] Error installing AEPEdge
[!] /opt/homebrew/bin/git clone https://github.com/adobe/aepsdk-edge-ios.git /var/folders/7l/rszmbrmd6tv4pg52z6ql_5rc0000gn/T/d20241023-10432-fzshxw --template= --single-branch --depth 1 --branch 5.0.3
Retrying with pod repo update...

Expected behavior
The pods should install successfully without any errors related to missing branches.
Anything else?
No response

Same issues with mine: https://github.com/adobe/aepsdk-edge-ios/issues/506


[VL][1.2] Port Fix shuffle spill triggered by evicting buffers during stop (apache#6422)

… stop (#6422)
In VeloxHashBasedShuffleWriter::stop, evict partition buffers can allocating extra memory and triggers spill. In this case the target partition buffer should not get shrunk.
Added UT for this case.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

cc: @weiting-chen


GHSA-5crp-9r3c-p9vr in Newtonsoft.Json 13.0.1

responding to a vulnerability in NewtonSoft 13.0.1

/azp run


Revert "Merge pull request #166 from Geequlim/4.1"

This reverts commit 9a3cd3fe74ebb2dcc26ad496c55a8ae3db9cfe4b.

Something is wrong. It is not using 3.4 master from godotengine organization.


Remember last wire timing

New wires should have the same timing as whatever you previously set a wire to

this was kinda annoying? dunno

done


Uses Geolocation API to get the users location

This PR fixes issue #3
When the site is loaded for the first time, the user's current location is detected and the weather for that location is shown.
@akshgpt7

@akanshaaa19 can you fix the merge conflicts here?


Add suitable comments for GoDoc

Resolves #76

@ayushjn20 Build is failing with this. Can you fix it so we can merge?

Got it. I opened a PR from my own fork, that's why the continuous-integration/travis-ci/pr is failing on snap login, but the continuous-integration/travis-ci/push build is passing.
I have pushed a branch on the original repo too, the build is passing. Kindly check here
@agentmilindu @apoorvam I think we are good to go with this PR.


testing (minor modification for changelog)

Please ignore, for testing purposes only

@g1eny0ung Just testing, sorry to disturb

Never mind. You can close this PR at any time after testing.


Expanding Code Snippets to relate to Web Page Items

Expand on the current functionality for Tag Management to relate Custom Snippet items to Web Page Items to reduce the need for deployments to add custom JavaScript functionality to a specific page or pages in the Website Channel.
Technical Requirements

[ ] Extending the WebPageLayout with a UIPage to manage tags pertaining to the selected WebPageItem, if the WebPage is root or is a folder tags should not be able to be added
[ ] Tags can have a 1:1 or 1:* relationship to WebPageItems to reduce redundancy in loading the same "Tag" multiple times
[ ] Ability to wait to load tags based on DOM events ie) DOMContentLoaded
[ ] Ability to enable and disable this snippets without having to remove them
[ ] Ability to see a listing of website channel related pages the snippet is applied to in the Tag Management Module similar to that of the functionality of how you could see the what pages forms were on in Kentico Portal <=12
[ ] (Optional) Tags can also be inherited or applied from parent item to the children under a page

This feature request would be utilized to extend the site to add new client side functionality or style changes to a page or site overall without the need for deployments.
Use Cases
I have created a landing page utilizing a current prebuilt template on the site, I as a marketer would like to add custom tracking events to the page which would require a developer to add JavaScript functionality to the main sites JavaScript file or create a Custom LandingPage.js file that loads on that specific page template warranting a deployment to take place.
With the expanded functionality I would be able to ask the developer to add this custom code to the site and they would be able to upload a LandingPage.js file to the media library and then Navigate to the webpage in the channel and the appropriate script tag to that page.

I have created a landing page utilizing a current prebuilt template on the site, I as a marketer would like to add an external form via Marketo to the site which utilizes the Marketo JavaScript library to load the form on page load.
With the expanded functionality I would be able to ask the developer to add this custom code to the site and they would be able to add a snippet to the new landing page with the appropriate loaded that would load on DOMContentLoaded at the end of the body content.

I as a marketer would like to add sharing buttons via JavaScript integration to specific pages on the site, I would like to be able to create a snippet for the ShareThis.js library once that I can link to as many pages as I would like throughout the Website Channel, if I need to go back and enable/disable/modify this snippet I can.
With the expanded functionality I would be able to add a Code Snippet to the Tag Management Module and then be able to select an existing one to add to the Web Page Items of my choosing, then if the need arises and I need to disable this functionality I can go back to the Tag Management module to disable this tag or delete it
Optional Use Case - Inherit/Load tags from parent
I as the developer have gotten a request to add Social Sharing buttons to every page under a Blogs section on the site, this would require me currently to modify the rendering view for the Blog Post content type and then deploy the code to production.
With the expanded functionality I would be able to navigate to the blogs path in the Tree and have to ability to apply that snippet to all children under that path

Thank you for highlighting this request. We will review it internally and keep you informed of any developments.

Hello @jkerbaugh, I would like to ask you to specify some things more in detail please.

What do you mean by WebPageLayout with a UI page ?
Is that administration layout as there should be a section in a page builder which is a placeholder for a Tag,
or one subpage in the pagebuilder, where you can add multiple tags to that site ?
Is it an admin module, where you could manage all tags and each tag would display all webpageitems where it is used ?

In the tag configuration, should you be able to select a specific DOM event on which the tag loads ?

On top of this, you talk about "I as a marketer would like to add sharing buttons via JavaScript integration to specific pages on the site".
Do you want to configure where the button would be added through pagebuilder ?

@bkapustik
Please see below, let me know if there is anything else I need to go further into detail on

In my opinion it should be another button added to the listing in the layout when viewing a website channel, by including a UIPane for tags that would list the "Custom Snippets" that are related to the selected webpage where you can create/edit/add existing/delete snippets related to the selected webpage (see image below), labeling it Tags may be confusing since tagging via Taxonomy may be a conflicting term.

Yes tags should be able to be configurable to load via DOM events such as DOMContentLoaded, or loaded immediately where it was placed (top head, bottom head, top body, bottom body)
This was more of a use case to explain a specific scenario, to elaborate more, I would be adding a JavaScript library to a page (named ShareThis.js) using the Tag Management integration, this script would have the logic in it already to create/modify buttons that currently exist on the page to do the social sharing, it wouldn't need to be configured where to place them as we would do that with widgets such as Rich Text or a Static Text/Html widget already. With that in mind you should be able to reuse that snippet and relate it to multiple pages so it only needs to be updated one time.

Hi @jkerbaugh. Unfortunately, it was decided this is not going to be implemented on the Kentico side. If you would like implement this yourself feel free to contribute to this repository.
Thank you.
Closing as Won't fix.


[ENH] Save unpreprocessed data and target for libsvm

Also cleaned up code in climate.py

Codecov Report

Merging #110 into master will increase coverage by 2.35%.
The diff coverage is 54.9%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   77.01%   79.36%   +2.35%
==========================================
  Files          11       11
  Lines         683      664      -19
  Branches       96       97       +1
==========================================
+ Hits          526      527       +1
+ Misses        126      105      -21
- Partials       31       32       +1

Impacted Files
Coverage Δ

celer/datasets/climate.py
24.52% <21.05%> (+8.08%)
:arrow_up:

celer/datasets/libsvm.py
73.13% <75%> (-1.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca543e...d9c691f. Read the comment docs.


{"message":"unauthorized"} when using JS SDK with Parse-Server

Environment Setup
My issue is very similar to this one.
I'm using "parse-server": "^2.2.7" with "parse": "^1.8.3".
I forked the Parse-Server-Example and everything works fine locally and on Heroku with the Rest API.  As soon as I try to use the javascript sdk I get {"message":"unauthorized"}.
I've tried with and without a javascriptKey, with or without initializing parse, with and without useMasterKey = true.
Steps to reproduce
This curl works:
  -H "X-Parse-Application-Id: myAppId" \
  -H "Content-Type: application/json" \
  http://localhost:1337/parse/classes/_User```

But this query gets `{"message":"unauthorized"}`:

    ```var User = Parse.User; //also tried Parse.Object.extend("_User");

        var query = new Parse.Query(User);
        query.useMasterKey = true; //tried it like this or by passing an object into find
        query.find().then(function(result) {
            if(result != null) console.log(JSON.stringify(result));
            else renderInvalidLogin(res);
        },
        function(error) {
            console.log(JSON.stringify(error));
            renderInvalidLogin(res);
        });```

#### Logs/Trace

No logs to trace.  I'm really at a loss, I posted on SO 2 days and no comments or answers.  So I'm posting here.  Thanks!

You can enable logging using verbose: true in the configuration of your server. Please do that and then post any logs you see.

I've done that and nothing changes.  No new logs, just {"message":"unauthorized"} returned from the error function of the above query.

In that case the error is probably not in Parse Server. Check your SDK initialization to make sure you the right server URL and keys.

Parse.serverURL = process.env.SERVER_URL || 'http://localhost:1337/parse';```

I'm not using a JS key.  Is this a good init?

As long as that URL, app ID, and master key are all actually correct, then yes that seems fine.

The error is coming from middlewares.js.  The req.body contains the _ApplicationId but it never gets parsed at line 50 because req.body is a string.
At line 57 req.body._applicationId is undefined and the invalidRequest is returned.

That shouldn't be the case. Can you post the JS SDK version you are using and the Parse Server version?

Have you try setup jskey on parse-server and init it in jssdk?
This error usually cause by keys not matched

I'm using "parse-server": "^2.2.7" with "parse": "^1.8.3".  I tried it with the jskey and still the same.

Looks like the only way I can access is through the REST api.
The Parse-Dashboard is unauthorized as well.

Those should work. How did you find out where the error is if you can't see any logs?

I stepped through with the debugger ...
Well, the problem has been found.  The 'body-parser' middleware I was using seems to have been mangling the requests.
The jssdk and parse-dashboard are working.
I appreciate your time.


APEXCORE-606-RV: review only: optimise kryo output stream.

This is a prototype of optimize kryo output stream. The main focus is avoiding memory copy and garbage collection to increase the performance.

SerializationBuffer is the the class extends kryo Output which use the WindowedBlockStream to manage the memory.
WindowedBlockStream is the memory management class which support manage memory blocks based windows. The windowed related function can be ignored now
BlockStream is the super class of WindowedBlockStream which manage blocks
CodecPerformanceTest is the class which test the performance. Please change the CodecPerformanceTest.loop to a number bigger than 100 before really do the performance test. And test the use case one by one as initialize impact the performance.
PartitionSerde is the class serialize partition and object which can be used by BufferServerPublisher.
BufferServerPublisher.put_new(Object) is the implementation use new stream.

@vrozov @PramodSSImmaneni Please review


Kuramanime

Source information
kuramanime 14.13 (Indonesia)
Source language
Indonesia
Steps to reproduce
1.Open the kuramanime extension
2.And it shows no results found
Expected behavior
It should show anime
Actual behavior
Shows only results not found
Aniyomi version
<IP_ADDRESS>
Android version
13
Other details

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

To anyone who tries to fix it:
The URL in popularAnimeRequest at line 41 needs fixing:
    // ============================== Popular ===============================
    override fun popularAnimeRequest(page: Int) = GET("$baseUrl/anime?page=$page")

Update it to:
    // ============================== Popular ===============================
    override fun popularAnimeRequest(page: Int) = GET("$baseUrl/anime?order_by=most_viewed&page=$page")

I've checked that the HTML tags and attributes are all good until:
    // ============================== Episodes ==============================
    override fun episodeListParse(response: Response): List<SEpisode> {
        val document = response.asJsoup()

        val html = document.selectFirst(episodeListSelector())?.attr("data-content")
            ?: return emptyList()

        val newDoc = response.asJsoup(html)

        val limits = newDoc.select("a.btn-secondary")

I didn't bother checking past val limits as I thought, if I could somehow get the popular/latest list, or the search queries first that would be the first step (which I failed in obv).
I got no clue if it's the site acting up, or some library messing up, or the wrong implementation of libraries (which doesn't seem the case to me).
YOU WOULD NEED TO DO PROPER DEBUGGING (which i didn't)


Add PR title checker

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Add title checker to CI

New functionality

...

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Current dependencies on/for this PR:

#1761  👈
main

This stack of pull requests is managed by Graphite.


Problem with accents during Release

Required Information
Question, Bug, or Feature?
Bug
Enter Task Name: IISWebAppDeploymentOnMachineGroup
Environment
TFS on-premise: Azure DevOps Server Version Dev17.M153.5
Issue Description
I have files in my Repo with accents (in concrete case: "caminhão 01.JPG", but happen with files with "ç" like "conceição"), the resultant file after Release in my IIS server turns to be named "caminh�o 01.JPG".
I downloaded the Build file "drop.zip" and the file inside still is "caminhão 01.JPG". So if i use the "IIS web app deploy" task, this break my accentuated file names.

Seems like this occurs with words inside files too, not only with file names.
Right now i uploaded an ASPX file that have this:
Data publicação:
The file when browsering from TFS/AzureDevOps still have "publicação".
The file after publishing to IIS server using the deploy task have this:
Data publica��o:
I can confirm that the "drop.zip" (the artifact after building the code) has inside the file with "publicação", so it's also changing the text inside files, breaking every "ç", "ã", "á".

@RomBrz : We tried to reproduce this issue by creating a file conceição.html that also contains the text "conceição" and deployed it using the task. This seems to be working as expected on our end. Can you check the encoding in your web.config file and ensure it set to Unicode character encoding?

Need more information to debug the issue. Closing it for now. Feel free to re-open if required with above required info.

I had this problem too, it sees it's because zip archive. when I deploy iis web app without zipping it works fine


⚠ ClamAV has degraded performance

In fa4990c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 110 ms

Resolved: ClamAV performance has improved in 9cb2c30.


Amount value on EditTransaction modal has scale of 4

When editing a transactions, we want to have the amount value with a scale of 2:
12.3400 should be 12.34
This is also the case on recurring groups list view and edit modal.

PR #37 will fix this!


Remove unnecessary else statement.

Cleanup AuthManager::resolve() protected method by removing the else statement.

Sorry, we don't accept PRs like this.

frustrates me every time I see an else statement like that


Web pr

PR for front end code review
Main js files are in JS folder inside front end folder
index.html, utility.js, app.js, main.js, schema-conversion.js are the custom js files

@13shreya I have resolved my comments. looks good to me. only two comments are still not resolved.


Revert "Remove exact error message from the metric in bench driver (#…

…6924)"
This reverts commit 25ccd551a91c47460951633933d45686bfaa24fa.

mlogan-monitor-epoch


username and password for demo don't work 😭

hey there! looks like an amazing tool! i'd love to test the demo out but the username and password are not letting me in.
please help!
❤ with love from the lunie team

@jbibla missed this totally. Can you try now? updated the credentials.


[Bug]: No way to prevent default behaviour of the parent form

Which packages are impacted?

[X] remix-validated-form
[X] @remix-validated-form/with-zod
[X] @remix-validated-form/with-yup
[ ] zod-form-data

What version of these packages are you using?
4.6.7
Please provide a link to a minimal reproduction of the issue.

Steps to Reproduce the Bug or Issue

Expected behavior
I intend to make certain fields editable via a "popup" portal, where the popup itself is managed by a form. When you "submit" the nested form, the field updates.
However, the onSubmit prop of the ValidatedForm won't prevent the parent form from submitting.
Here's my code:
const onSubmit = async (data: any, e: FormEvent<HTMLFormElement>) => {
  e.preventDefault()
  e.stopPropagation()

  // Do something with data
}

return (
  <ValidatedForm
    validator={validator}
    defaultValues={defaultValues}
    onSubmit={onSubmit}
  >
	// Fields
  </ValidatedForm>
)

This is used as a component within another ValidatedForm. If I submit the popup form, it'll also submit the parent one.
Is there a way to change that? Not sure if the asynchronous nature of the onSubmit function is the issue here.
Screenshots or Videos

Platform

OS: [macOS]
Browser: [Chrome]
Version: [105]

Additional context
No response

It won't work even if the nested form is moved away to a separate DOM node using portals:

Yeah, this is definitely related to onSubmit being asynchronous. And unfortunately, I think the only way to actually fix this is in userland, not in this library.
Without portals I'm pretty sure you're not supposed to nest form elements.
With portals, this happens because React bubbles events up through the portal as though it was nested without a portal.
One thing you could do is listen to the submit event on another element in your popover and stopPropagation there. I do this a lot with click events to prevent clicks inside portals from bubbling up into unexpected places. Here's an example:
<div onSubmit={e => e.stopPropagation()}>
  <ValidatedForm {...etc} />
</div>

That said, I think it's unideal though that there's a stopPropagation on the event we provide and it doesn't do anything. I think we should:

Tweak the type of the event we pass to onSubmit to deprecate stopPropagation.
Remove stopPropagation in the next major version and throw an error if you try to call it.
Even though this is technically a breaking change, we're not breaking any real use-cases since it doesn't do anything as-is.

For completeness, I've thought through a couple other ideas I don't like:

We could always stop propagation.

Having the submit event not bubble past the form could be unexpected behavior. It's also a breaking change.

We could stop propagation then re-dispatch the event if you don't stop propagation in your onSubmit

This isn't good because it will result in two submit events in the capture phase

Thanks @airjp73
Your workaround fixed the issue!


fix(parameters): get_secret correctly return SecretBinary value

Issue number: #1713
Summary
Changes
parameters.get_secret can now fetch Binary Secrets.
User experience
Before this patch, calling parameters.get_secret to get a Binary Secret will throw a GetParameterError since it would only try to retrieve the SecretString value from the secret value. Ref: #1713
Now, get_secret will correctly fetch Binary Secrets.
Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
Base: 99.27% // Head: 99.27% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (c82d6d2) compared to base (8862e69).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1717   +/-   ##
========================================
  Coverage    99.27%   99.27%
========================================
  Files          129      129
  Lines         6056     6059    +3
  Branches       402      403    +1
========================================
+ Hits          6012     6015    +3
  Misses          20       20
  Partials        24       24

Impacted Files
Coverage Δ

..._lambda_powertools/utilities/parameters/secrets.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

thank you so much @mangoes-git - I've just added tests and a minor code style (removed else). Merging


docs: remove no longer needed spelling exceptions

Motivation

Several of the .spelling exceptions are no longer needed
Modifications

in particular, since mentoring docs were removed in #11805, several of these are no longer needed

names and usernames, GSoC, etc

also remove other exceptions that are no longer used

words that are in backticks do not need exceptions

Verification

make docs-lint and make docs-spellcheck pass

I bumped TestStopBehavior again here as it failed here. I bumped it in #11753, which did dramatically reduce flakes, but there were still a few here and there.
Now there's a different CI failure that seems more like a bug and is not due to a timeout. Left a comment on https://github.com/argoproj/argo-workflows/pull/10307#issuecomment-1720028813 about it

Good question, though unfortunately it doesn't seem like the library has options for that. There are some related issues (didn't find quite the same) like https://github.com/lukeapage/node-markdown-spellcheck/issues/54 that have been open for several years.
There is a manual workaround for sorting, but there isn't an explicit way to output the "word list" for a manual workaround. As in, to automate, you'd need to check the entire corpus's set of words against the .spelling file, and if the .spelling list is not a subset, then can remove the extraneous ones. The main problem is that word boundaries can be defined differently, so ideally using the same library would be optimal.
I could potentially hack together a script that tries to use similar word boundaries to automate this, but it may not be perfect and likely not worth the effort at this time. Here's a simple implementation I wrote up quickly but that doesn't quite work (my GNU is a bit rusty):
all_words=$(tail -n +6 .spelling) # skip the first 5 lines that are comments
words=(${all_words}) # convert string to array
for word in ${words[*]}; do
  grep -rqv $word docs
done

It's pretty rare that we remove substantial portions of the docs, so usually there's few reasons for removal; normally it only grows. The removal of the mentoring page was a pretty big one (that also contained a lot of ignores for things like usernames etc) as I mentioned in my opening comment.
Ignore files in general (like .gitignore, .dockerignore, etc) don't often have automation around them 🤔

Won't some of them be useful in the future even if they're not being used now? Then we would need to re-add those?

90% of the ones removed here are mentoring related (with 80% of those being usernames), another 5% are from incorrect usage of backticks, and then a few unrelated. So I don't think most would ever be needed again, but we can always add them back if we ever need them.


Include metadata/description in the intellisense lookup when tab completing parameters in modules

When tab completing parameters it would have been nice to see the metadata/description defined for the param.

Yes, we're planning to include descriptions. This is related to #668.

In a vein awfully related to this, where is the best place to leave feedback about less-than-stellar document descriptions (where it can best be scooped by Bicep as part of this effort)?
For example, the groupIds property when creating a PrivateLink varies based on the resource you're aiming to link, but no other service appears to document what these are (and the UI in the Portal instead calls this a "sub-resource"). The only place I've found to get a list of these values is by creating a resource in the Portal and copying the values out of the generated template.
It'd be awfully handy if the Intellisense was smart enough to parse the following:
resource storageAccountPrivateEndpoint 'Microsoft.Network/privateEndpoints@2021-02-01' = {
name: 'myStorageAccountPE'
location: resourceGroup().location
properties: {
subnet: {
id: privateEndpointSubnetId
}
privateLinkServiceConnections: [
{
name: 'myStorageAccountPE'
properties: {
privateLinkServiceId: storageAccountResourceId
groupIds: [
'blob'
]
}
}
]
}
}
And when my cursor lingers in the groupIds array, it'd be great if it could:

Realize that I'm referencing the groupIds on a Microsoft.Network/privateEndpoints resource
Evaluate the value of storageAccountResourceId (in my case as being passed into this module and resolved to a storage resource's id value) to realize the groupIds should be limited to those as related to storage accounts
Show only the list of valid groupIds available (and in-line documentation about each in case their names are unclear).

@WhitWaldo see #4449 for proposal to add lookup for privateLink as well as the link for current docs with the reference to the groupid/dns names.


GH-35363: [C++] Fix Substrait schema names and for segmented aggregation

See https://github.com/apache/arrow/issues/35363

Closes: #35363

cc @westonpace, @icexelloss

@rtpsw LGTM. Can you fix the lint error?

@westonpace, @icexelloss: is this good to go?

Thanks @rtpsw - LGTM.


.luaurc filetype detection

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
Vim currently doesn't set a filetype for .luaurc file (Luau's analysis config file)
Describe the solution you'd like
Set jsonc filetype when entering a file with name .luaurc

How about a patch then?


disk_root check is unset with "" rather than "false"

Most checks appear to follow the standard of being removed when set to false, but disk_root requires setting to '' which apparently causes others appear to revert to default value.

(by aieri)
An empty string being a synonym for "disabled check" seems to be used pretty consistently within the nrpe charm (e.g. zombies, load, swap, mem, etc.), although we could additionally allow 'False' to mean the same thing.


Enumerable Methods Project First Pull Request To Development Branch

This project is about learning, understanding, and implementing some of the commonly used enumerable methods which include my_each, my_count, my_map, my_inject, my_select, my_any, my_none, my_all, and the use of block and proc.

👋 Change Required 😭  💅
Hey, team,
Nice job to make it this far, let's keep it up! 💯 😄
However, there is still 1 glitch needs to fix, so let's get into it. 🤝

#my_any - As defined in Here or Here.

Ruby adds an implicit block of { |obj| obj } that will cause #any? to return true if at least one of the collection members is not false or nil.

Which it means when [nil, 99, false].any? should return true.
While [nil, false, nil].any should return false.

But this is not the case for your my_any method yet, so please find a way to fix it, thanks!
That will be it!  Good luck and happy coding! 😄 👨💻 👩💻
Best,
Kelvin
Please Note:
Feel free to contact me at slack by @Kelvin or email<EMAIL_ADDRESS>if you have any questions on this request, thanks!


denizen save file

hello
in my save file i have ID's instead of player names, is it possible to change it ?
or have UUID's instead of these weird ID's ?
thank you

That would be silly because players can change their names.  You could put a players name in the save  under the UUID and update it as needed if you want visual reference.

yeah but the ID's in the file are not the UUID's given by mojang
i have diferent ID's

If you use  you will get UUID, <player.name> will give you a name.  I'm not sure how are doing your IDs.

o my bad
they are in fact UUID's
didn't realize
sorry ^^'

thanks


Chat history usage is 4x times bigger than the configured --max-chat-history-tokens

Issue
Hello,
I re-opened an older issue because I'm not sure that this is expected.
Chat history is the biggest contributor to my Claude Sonnet costs.
You can find a screenshot in the below issue.
https://github.com/Aider-AI/aider/issues/1963
Version and model info
Latest aider with Claude Sonnet.

Thank you for filing this issue.
Part of the problem seems to be that you changed the defaults and allowed the chat history grow so big in the first place. The LLM seems to fail to summarize the chat if it gets too large. In doubt use /clear the chat history.
A huge chat history is not a benefit, it is ballast. It may contain many outdated ideas and rejected code paths. It will only confuse the LLM, not help it. Please try to use /clear as often as possible.

Hello,
Which defaults are you referring when you say "you changed the defaults"? I did not change any default I just used --max-chat-history-tokens hoping to limit the chat history and to avoid exactly what you are saying "allow the chat history grow so big"
But, as visible in the screenshot, after I used --max-chat-history-tokens hoping to limit the history the chat history still became 4x bigger vs. what I configured.

Actually I don't care if I do --max-chat-history-tokens or not.
What I care is to limit the size up to which the chat history is growing.
How I can do that?

What I care is to limit the size up to which the chat history is growing.
How I can do that?

Use /tokens and /clear regularly.

Use /tokens and /clear regularly - This I do but I forgot sometimes and it breaks the flow to keep remember to /clear
because of that I looked for something like --max-chat-history-token to limit the history. Actually I noticed that many times even when there is not history at all aider responses are very good sometimes better than when there is a lot of history.
Because of that I was thinking "If I can limit the history to stop growing" it will be perfect I don't ever need to be worry about the history (most of the times the history is the single most expensive part of the costs more than the files I manually add with /add) - I do /reset and /clear but ... if --max-chat-history-token would work it would be perfect.


Upgrade QT dependency to version 5.9.6

This seems to fix the issue we are seeing on macOS High Sierra/Mojave when installing macOS wallet generated by gitian. The idea came from this PIVX PR: https://github.com/PIVX-Project/PIVX/issues/364
PIVX used to have the same issue until they upgraded to QT 5.9.6, this patch therefore extracts this specific upgrade from a bigger PIVX PR that does a lot more stuff.
I tested this build successfully on Mojave, I would recommend some other people give it a try on several more mac machines including ones running High Sierra.

People who want to give it a try and trust me enough with it, here is a link to download a package I built: https://drive.google.com/open?id=1bV_B2SYtnpolURX1v8HgwxmmFBB1eFR4
Other solution would be to wait for @msg768 to create an "official" testable package, or build it manually.

Tested on Mojave and High Sierra. Looks good!


Feature: Notifications for community features

@aapeliv could you add a little more detail so I understand what you are thinking?


Why only RDMA is used for GPU-to-GPU communication?

Hello! It seems that only the RDMA technique is implemented for peer-to-peer (P2P) communication of GPUs, but I notice that there are well-presented PCIe functions to build the basic interconnect infrastructure. The PCIe P2P function is also supported in Akita.
So why PCIe P2P is not used here for local P2P communications? In my understanding, RDMA is more often used in remote scenarios, e.g., cross-node transmission, with the involvement of NIC or other network-related fabrics. In the context of MGPUSim, it is more like the single node setting since there is only one driver managing multiple GPUs.
Particularly, the RDMA functions here are used for data transmission in (local) page migration. I'd like to know why PCIe P2P is not used for this part. Thanks in advance!

Good question, the RDMA is a component of the GPU, and the PCIe or the NVLink is much more related to the bus. All of them are used in P2P communication, the RDMA takes charge of sending/receiving data to/from the PCIe bus.

Thank you! So does this mean that the RDMA engine here takes on some functions of the PCIe controller on a GPU? In this way, a unified interconnect interface can be created through RDMA regardless of in local or remote scenarios. Are there other reasons behind this design choice? Forgive me if my guess is wrong.

In my opinion, the answer is no. RDMA takes charge of receiving messages or preparing to send messages from the GPU phase. The PCIe takes charge of fetching messages from RDMA, routing, and sending messages to the proper destination.

I understand a bit now. Therefore, the PCIe functions are actually "silently" called under the RDMA layer.
But I still don't quite understand what "remote" means in RDMA here? In other words, what is the difference between a RMDA engine here (with PCIe backed) and a DMA engine? Can RDMA engines bypass the PCIe infrastructure for direct p2p communication in MGPUSim? I have read the MGPUSim paper and re-searced source code, but couldn't find any indication. Please correct me if I miss something. Thanks!


HDDS-8879. Cleanup SecurityConfig and related class initialization

What changes were proposed in this pull request?
This is a fairly large refactor mainly due to moving files around in different modules/packages.

OzoneSecurityException moved from hdds-server-framework to hdds-common and from o.a.h.hdds.security to o.a.h.hdds.security.exception package.
KeyStoresFactory interface moved from hdds-server-framework to hdds-common, but remained in the same package along with its implementation
Reloading key and trust manager moved from hdds-server-framework to hdds-common, but remained in the same package
CAType enum moved from hdds-server-framework to hdds-common but remained in the same package
CertificateClient and CertificateNotification interfaces moved from hdds-server-framework to hdds-common, they have remained in the same package.
CertificateCode, CertificateSignRequest, SelfSignedCertificate is moved from hdds-server-framework to hdds-common they remained in the same package
CertificateException moved from hdds-server-framework to hdds-common but remained in the same package
SecurityConfig moved from o.a.h.hdds.security.x509 to o.a.h.hdds.security package.

Besides all these moves the following significant changes were made:

PemFileBasedKeyStoresFactory implementation was changed to avoid findbugs warning about exposing internal structure.
Everything under the packages org.apache.hadoop.hdds.security and any derived classes rely only on the SecurityConfig object, and the OzoneConfiguration and its descendants are not used there anymore.
block token duration related sanity check was bought into the SecurityConfig, sanity check had to be disabled because of this change in quite a lot of tests. Also this reveals a possible follow up JIRA, as we does not seem to have a similar check for container token lifetime.
OZONE_S3_AUTHINFO_MAX_LIFETIME_KEY removed from OzoneConfigKeys after removing the only usage of it in SecurityConfig along with the associated getter that is not used anymore anywhere in the code. It was not added to ozone-default.xml either.
TokenHelper used by EC reconstruction now uses SecurityConfig in its constructor, and its code have been changed to delegate understanding the configuration to the SecurityConfig object, and just use the proper getters to get values.
HddsDatanodeService lost its two static creation method, and now the costructors are called directly, as there was no further logic or any other use of the static creator methods.
CertificateClient construction has changed, it relies on a SecurityConfig instance from now on, and also it relies to get the SCMSecurityProtocol client from outside. This has an effect on all certificate client instantiation, and there was a need to change the order of doing UGI login and initializaton due to some assumptions in tests that I did not changed.
Moved the utility method that sets up the SCMSecurityProtocol client from HddsServerUtil to HASecurityUtils
OmCertificateClient now relies on OzoneManagerDetailsProto via its constructor, and does not call the static method on OzoneManager class directly to figure it out.

Why I would like to change all of these?
This is one of the steps to simplify and reduce external dependencies of the CertificateClient and related codebase. The final aim is to get to a stage where we can separate the code that is responsible to create the certificate sign request for a service and send it to the SCM, the code that is responsible to store the certificate and key material of a particular service, the code that is responsible to gather the rootCA certificate from SCM, and the code that provides means to set up the different type of secure connections.
Also, by centralizing all the security related configuration and its handling, we have a single pane of glass to see what configurations we use, and what rules we apply to these configuration values.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8879
How was this patch tested?
Existing JUnit and integration tests.

Thank you @fapifta for working on this. LGTM +1


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/83808

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/116286


Local link doesn't work if the permalink is from a fork

Testing #5646
Example: https://github.com/microsoft/vscode-docs/pull/6962#discussion_r1463158177

I'm still the permalink opening in the browser and not in my workspace when I checked out the pr mentioned above and clicked on the permalink mentioned in the comments.

I can't repro this. @ntrogh could you try verifying this?

Unable to repro this either (running on GHPRI v0.79.2024012510 ) @alexr00 @bhavyaus


Example should follow the style guide

From https://github.com/alexeagle/closure-compiler-angular-bundling/issues/25

maybe @thelgevold would like to help curate the example?

@alexeagle What did you have in mind for the sample? Are you thinking we should add a more interesting demo component?

This issue is just to make the current example conform to the style guide.
I think separately, there's an interesting project in making a broader
example that shows more stuff, like dev RTT at scale, server-side
rendering, routing, etc.
On Fri, Feb 9, 2018 at 4:59 PM Torgeir Helgevold<EMAIL_ADDRESS>wrote:

@alexeagle https://github.com/alexeagle What did you have in mind for
the sample? Are you thinking we should add a more interesting demo
component?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alexeagle/angular-bazel-example/issues/6#issuecomment-364611440,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC5I4syYbiCU3e9_xtNppjLmqnN440jks5tTOnYgaJpZM4PeBJY
.

Hm.. Maybe I am missing something, but isn't the sample already following the style guide pretty closely?
Looks like the only thing I am seeing is import { SomeSymbol } vs import {SomeSymbol} convention. The style guide seems to favor trailing and leading spaces in import statements.
From what I can tell, the auto formatter removes this though.

I see some file name violations as well. I can make a PR.

We can change the formatter to prettier.
On Mon, Feb 12, 2018 at 6:01 PM Torgeir Helgevold<EMAIL_ADDRESS>wrote:

I see some file name violations as well. I can make a PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alexeagle/angular-bazel-example/issues/6#issuecomment-365126896,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC5I0zUeTpLVMJomry2S2aIgoOl3-9uks5tUOz3gaJpZM4PeBJY
.

I think this is good enough!


Let add a description to model fields

Problem
Name in table columns tend to be short and concise, also tables and columns tend to be in a large number. Remembering the use of each field is challenges, and to find the use a lot of code should be reviewed.
Suggested solution
Add an extension to provide a description for tables and fields. These descriptions should be added to the generated DDL to persist them in the Database.
This way when you open the database in a database browser you can have a little more information about the columns.
Alternatives
One possibility is to add a new columns attribute @description() accepting a string
For example:
model Business {
  @@description("Legal Person that is an organization")
  id    Int  @Id @default(autoincrement())
  taxId String @description("RFC / RUT/ CUIL or other valid tax identifier")
  name  String @description("Legal name")
  dba   String @description("Doing Business As, name used in marketing")
}

These values then translate to proper DLL:
CREATE TABLE Business (
    id INT,
    taxId VARCHAR(191) COMMENT('RFC / RUT/ CUIL or other valid tax identifier')
    name VARCHAR(191) COMMENT('Legal name')
    dba VARCHAR(191) COMMENT('Doing Business As, name used in marketing')
) COMMENT 'Legal Person that is an organization';

Additionally these comments can be used in other generated code.
Additional context
N/A

Thanks for this issue. This feature request is already tracked elsewhere, so I'm closing this as a duplicate of https://github.com/prisma/prisma/issues/10972 and https://github.com/prisma/prisma/issues/8703.


IMPORTANT: breaking changes

This issue will track any updates to Executor.nvim which are breaking and may need attention or updates to your dotfiles.

As of https://github.com/google/executor.nvim/pull/25, the UI for text input (used for ExecutorRun) and selects (for history and presets) now use Vim's built in vim.ui.input and vim.ui.select.
This library still depends on nui.nvim for the split and popup views, but will now defer to vim.ui for user input.


Fixed api key and also added favorites to config

Fixed the api key according to https://github.com/plintx/mopidy-radionet/issues/5#issuecomment-746602563 and also added the possibility to set favorites in the config.
The favorites are set by a list of names:
favorite_stations =
The first results of a search in radio.net are added to this list.

Coverage decreased (-4.0%) to 55.789% when pulling 340279a8a2048eb631b00103c1e3f14f5b7f844c on miesli:master into b728e9db3f2535df5acbab14b16c66a74883338d on plintx:master.

Hello, merged, thanks a lot! Please at next time, remove unnecessary commented lines of code :)


Fix Android TalkBack double tap behavior with TableView/ListView highlight selection

Closes #2512
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to the ListView/TableView "selectionStyle: highlight" story
Using Android TalkBack, select a row via moving the cursor to a row cell and double tapping
Move the cursor to the row and double tap. Verify that the previously selected row isn't deselected and that the new row is selected as well
Go to the ListView/TableView "selectionStyle: highlight, onAction" story
Move the cursor to the row. If in the ListView story do this by tapping on a row and swiping left once (this moves the cursor from the cell to the row)
Double tap. Verify that onAction is fired and the row isn't selected

🧢 Your Project:
RSP

shoot, from what I can tell iPad returns 0 for pressure zzz, lemme see if I can add some other checks to distinguish (worse case I add width === 1 and height === 1)

Is this new with this change or something I haven't seen previously?

@ktabors what repro steps and what stories? I'd be surprised if those were introduced in this PR since there aren't any css changes but maybe the press stuff affects some styles that are applied? Can you reproduce these in main?

Yeah, this are both in master and I didn't recall seeing them before.
To reproduce both it is basically just tab into the list or table. List shows that is ever row, table is only the top row.

@ktabors Would be good to file it in a separate issue if it exists in main.

TODO: revert 3ddac42 after testing

@ktabors

I'm able to get the voiceover selection box on an item, "Item 4", then I double finger tab on item 1 and then all the items get checkboxes. Once I get the checkboxes I'm able to check all the rows. I turn off voiceover and I'm not able to repeat this.

Are you doing a double tap and keeping your finger pressed down on the second tap? The behavior shown looks like the long press being triggered thus showing those checkboxes. Does a long press not bring up the checkboxes when you turn off voiceover?

In voiceover when I double tap on an item, it calls on action on the row above my tap and the row I'm tapping. When in the checkbox selection mode both rows are checked. It's a double tap so it should be the same position. I'm able to confirm this by looking at the addon tab and I see two actions one for each row.

Possibly https://bugs.webkit.org/show_bug.cgi?id=223202? Does if you open the story outside the storybook iframe?
Either way, you can file separate issues for these if these occur in main as well, shouldn't be a blocker for this PR.

Either way,

@LFDanLu For the VO going into the checkbox mode. I can't get long press to work in VO to enter that mode. I'm not leaving my finger down when I double tap, but maybe I'm doing them in rapid enough succession that it is reading a long press?
And for the other one it is probably that Safari bug, but opening it in a window doesn't let me test it because I can't see if onAction is being called when opened in an iframe on mobile. :(

Don't merge for now, trying to fix a bug that will happen if this is merged with the datepicker PR


Using iceriver ks0 to build a self built mining pool solo in Kaspa stratum bridge, the ASIC machine will crash and must be reset to repair

Using iceriver ks0 to build a self built mining pool solo in Kaspa stratum bridge, the ASIC machine will crash and must be reset to repair. I consulted with iceriver technicians and they said it may be a pool adaptation issue. May I ask if it is possible to adapt the ASIC machine again? Thank you. https://t.co/MgVBJc5yIk This is the mining agreement announced by iceriver, and I hope it can be helpful.

I have also run into this issue with my ks0 units.


Use same alphabetize props as ESLint sort-imports

ESLint's native sort-imports does the sorting I want, but doesn't care about the grouping of imports. On the other hand, import/order gives me the ordering I want, but not the powerful alphabetization sort from sort-imports.
For sort-imports, this is the config I use:
{
  'sort-imports': [
    'warn',
    {
      ignoreCase: true,
      memberSyntaxSortOrder: [
        'single',
        'all',
        'multiple',
        'none',
      ],
    },
  ],
}

I'd like to do something similar with import/order:
{
  alphabetize: {
    caseInsensitive: true,
    memberSyntaxSortOrder: [
      'single',
      'all',
      'multiple',
      'none',
    ],
    order: 'asc',
  },
}

I would like this functionality because I'm grouping them differently than the default:
{
  groups: [
    [
      'builtin',
      'external',
    ],
    [
      'index',
      'parent',
      'sibling',
    ],
  ],
}

Here's an example I'd expect to see:
import PropTypes from 'prop-types'
import React from 'react'

import useMediaQuery from './useMediaQuery'
import useMediaQueryState from './useMediaQueryState'
import { * as actions } from './actions'
import { breakpointsList } from './breakpoints'
import './styles.css'

import/order has alphabetize, does that not do what you want?

It does alphabetize, but the ordering is based on the from string (from what I can tell), not the characters of the variables you're importing.
That's why I was suggesting similar functionality to what's in the memberSyntaxSortOrder from the official ESLint import sorting. It allows you to say where the { should be ordered and where * and "no from" statements get ordered.

Ah, thanks for clarifying.
I don't see value in sorting by the identifier names - especially since you can have multiples. What would you sort by in this:?
import { a as z, b, d }, c from 'e';

In your example, I'd keep c in front and sort the inside has you have it. I never even thought the default export could be after deconstruction.
// Sorted deconstruction
import c, { a as z, b, d } from 'e';

Right, but then you're sorting by the exported names, but the importing default name. If the name the importer chooses is the primary bit, then i'd expect as z to win out over a.

That is a really good point!
My main concern is being able to quickly find things. If everything's alphabetical, it's in the same order each time no matter the component. It also needs to be something I could reasonably fix without
I have no opinion on sorting by a or z in a as z as long as it's easy to spot when skimming imports.
Are we in agreement on the other parts or is there more contention?

What's the use case tho? Like, what are you hoping to quickly find that you're not using grep ("find" in your editor), or "go to definition" jumping from a usage site?

Alphabetizing anything where order doesn't matter makes it easier to skim unimportant parts of PRs. There's also improved compression ratio because there are more situations where we have repeat code.
My main thing for me is having similar functionality to the official ESLint rule, but separating node_modules/ from local imports like eslint-plugin-import provides.
Would it help if I provided the PR myself? I completely understand if that's the determining factor here.

I appreciate that, and providing the PR certainly helps! While I strongly agree with the sentiment in making it easier to skip unimportant parts of PRs (reducing diff churn, eg), to me it's more important that the lint rule make sense on its own. Just sorting things for the sake of sorting them doesn't seem particularly compelling to me.

Just playing devil's advocate here, but couldn't you apply your rationale about "sorting things just for the sake of sorting" to the entire idea of grouping and sorting imports in general?  If I'm looking to modify an existing import or looking over a PR that made such a modification, it seems just as nice to be able to find an import group as it is to find a imported member/identifier within a single statement.
There are rules to order object keys, vars, and as was pointed out here, rules in tslint or other eslint plugins to order the imported members.  And this plugin orders and groups imports, so why would you not order the identifiers within?  As for your example, I also don't particularly care about which way you choose to order, as long as it's consistent.

I'd also like to have the imports inside the group sorted.

just two cents from TypeScript world, in TSLint there was a rule ordered-imports and there was an option named-imports-order: "lowercase-first". As soon as TSLint is dead and everyone somehow migrates to eslint it would be nice to have this option for compatibility.

I'd also like to have the imports inside the group sorted.

Same!

What I want:

imprts get grouped by path (the groups setting)
groups get sorted by syntax (the sort-imports memberSyntaxSortOrder setting)
syntax groups get sorted alphabetically by path
the variables inside a multiple import statement get sorted

I have the following config:
    'sort-imports': [
      'warn',
      {
        memberSyntaxSortOrder: ['multiple', 'single', 'all', 'none']
      },
    ],
    'import/order': [
      'warn',
      {
        'groups': ['builtin', 'external', 'parent', 'sibling', 'index'],
        'pathGroups': [
          {
            pattern: 'react*',
            group: 'external',
            position: 'before',
          },
          {
            pattern: '@react*',
            group: 'external',
            position: 'before',
          },
        ],
        'pathGroupsExcludedImportTypes': ['builtin'],
        'newlines-between': 'never',
      },
    ],

example:
import React from 'react'
import anotherNodeModule from 'another-node-module'
import otherNodeModule from 'other-node-module'
import Something from '../something'
import {xSibling, ySibling, zSibling} from './lettered-siblings'
import sibling from './sibling'

This makes sort-imports complain anotherNodeModule should come before React. If memberSyntaxSortOrder would be included in this plugin, I could disable sort-imports.

@ThaJay : this is pretty close to what I want. Fortunately in my case, the rules do work without conflict, but I lose auto fixing  for the memberSyntaxSortOrder part.
Basically, I'm trying to emulate Python's isort. But isort has an easier time because you cannot combine default/namespace/named imports into one statement. It's all or nothing.
My platonic ideal:
import * as fs from "fs";

import * as reactivated from "reactivated";
import {Router, browserHistory} from "react-router";
import React from "react";

import * as typography from "@client/shared/typography";
import Login from "@client/scenes/Login";
import {useSceneSubmitHandler} from "@client/scenes/utils";

import * as constants from "./constants";
import * as style from "./style";
import {Thunk} from "./reducer";

First broken up by chunks (builtin, external, internal, relative). Then within that, grouped into import syntax. Then alphabetized.
Currently, this plugin can automate all but the last step. If I turn on alphabetize, I get this:
import * as fs from "fs";

import React from "react";
import {Router, browserHistory} from "react-router";
import * as reactivated from "reactivated";

import Login from "@client/scenes/Login";
import {useSceneSubmitHandler} from "@client/scenes/utils";
import * as typography from "@client/shared/typography";

import * as constants from "./constants";
import {Thunk} from "./reducer";
import * as style from "./style";

And that to be looks a lot worse. Moreover, I the need to disable memberSyntaxSortOrder otherwise I get a conflict.
So currently I can either: fully automate but lose grouping syntax, or almost fully automate but need to manually group syntax.

@ThaJay : this is pretty close to what I want. Fortunately in my case, the rules do work without conflict, but I lose auto fixing  for the memberSyntaxSortOrder part.
Basically, I'm trying to emulate Python's isort. But isort has an easier time because you cannot combine default/namespace/named imports into one statement. It's all or nothing.
My platonic ideal:
import * as fs from "fs";

import * as reactivated from "reactivated";
import {Router, browserHistory} from "react-router";
import React from "react";

import * as typography from "@client/shared/typography";
import Login from "@client/scenes/Login";
import {useSceneSubmitHandler} from "@client/scenes/utils";

import * as constants from "./constants";
import * as style from "./style";
import {Thunk} from "./reducer";

First broken up by chunks (builtin, external, internal, relative). Then within that, grouped into import syntax. Then alphabetized.
Currently, this plugin can automate all but the last step. If I turn on alphabetize, I get this:
import * as fs from "fs";

import React from "react";
import {Router, browserHistory} from "react-router";
import * as reactivated from "reactivated";

import Login from "@client/scenes/Login";
import {useSceneSubmitHandler} from "@client/scenes/utils";
import * as typography from "@client/shared/typography";

import * as constants from "./constants";
import {Thunk} from "./reducer";
import * as style from "./style";

And that to be looks a lot worse. Moreover, I the need to disable memberSyntaxSortOrder otherwise I get a conflict.
So currently I can either: fully automate but lose grouping syntax, or almost fully automate but need to manually group syntax.

if I add ignoreDeclarationSort: true, to 'sort-imports' and add more pathGroups like so it works well enough:
'pathGroups': [
  {
    pattern: 'react',
    group: 'external',
    position: 'before',
  },
  {
    pattern: 'react-native',
    group: 'external',
    position: 'before',
  },
  {
    pattern: 'react*',
    group: 'external',
    position: 'before',
  },
  {
    pattern: '@react*',
    group: 'external',
    position: 'before',
  }
]

if I add ignoreDeclarationSort: true, to 'sort-imports' and add more pathGroups like so it works well enough:
'pathGroups': [
  {
    pattern: 'react',
    group: 'external',
    position: 'before',
  },
  {
    pattern: 'react-native',
    group: 'external',
    position: 'before',
  },
  {
    pattern: 'react*',
    group: 'external',
    position: 'before',
  },
  {
    pattern: '@react*',
    group: 'external',
    position: 'before',
  }
]

Came here looking for the ability to sort impors within a single import:
import { b, a } from './alphabet'
to
import { a, b } from './alphabet'
Any luck on the PR @Sawtaytoes or was there any suggested workarounds for this ?

No luck on my end. Someone will need to patch it.

I have the following setup with "sort-imports" and "import/order" and they seem to be working well together:
{
    "import/order": [
        "error",
        {
            "alphabetize": {
                "caseInsensitive": true,
                "order": "asc"
            },
            "groups": [
                ["builtin", "external", "object", "type"],
                ["internal", "parent", "sibling", "index"]
            ],
            "newlines-between": "always"
        }
    ],
    "sort-imports": [
        "error",
        {
            "allowSeparatedGroups": true,
            "ignoreCase": true,
            "ignoreDeclarationSort": true,
            "ignoreMemberSort": false,
            "memberSyntaxSortOrder": ["none", "all", "multiple", "single"]
        }
    ]
}

@KevinNovak Thanks a lot - that got it working for me. I didn't notice the ignoreMemberSort: true config in sort-imports.
Looks like that will allow import/order to do it's thing but add the member sorting from sort-import.

I encourage the development of this new feature. I believe it is necessary. I don't think it's right to have to use two plugins to achieve it.

Loads had changed in the meantime. So I thought it may be useful for someone to share my current config.
    'import/first': 'error',
    'import/newline-after-import': 'error',
    'simple-import-sort/exports': 'error',
    'simple-import-sort/imports': [
      'error',
      {
        groups: [
          ['^\\u0000'],
          ['(?=^.)react(?!.)', '(?=^.)react(?!.).*\\u0000$', '(?=^.)react-native(?!.)', '(?=^.)react-native.*\\u0000$'],
          ['^node:', '^node:.*\\u0000$'],
          ['^react', '^@?\\w', '^react.*\\u0000$', '^@?\\w.*\\u0000$'],
          ['(?<!\\u0000)$', '(?<=\\u0000)$'],
          ['^\\.', '^\\..*\\u0000$'],
        ],
      },
    ],

This is what it looks like:


Revert "Temporary change in logic for G12"

Reverts alphagov/digitalmarketplace-api#1054

The PR this is reverting doesn't have much detail. Why did we do this originally, and why do we now need to revert?

Let's not go there.


Request being made with a different protocol is leading to a "Your session has timed out. Log in again to continue." on each login.

Rancher Versions:
Server: v1.3.1
Tried to update to v1.4.1 but it didn't solved.
Docker Version:
ubuntu@aws-rancher-a:~$ sudo docker info
Containers: 6
 Running: 6
 Paused: 0
 Stopped: 0
Images: 568
Server Version: 1.12.6
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 598
 Dirperm1 Supported: false
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: host null bridge overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: apparmor
Kernel Version: 3.13.0-66-generic
Operating System: Ubuntu 14.04.3 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 3.859 GiB
Name: aws-rancher-a
ID: VGIK:ZDWD:K7OV:XCT5:423C:LWQY:FRO5:RYGW:2O7L:AJRW:Q2HV:SOAZ
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Labels:
 provider=amazonec2
Insecure Registries:
 <IP_ADDRESS>/8

OS and where are the hosts located? (cloud, bare metal, etc):
AWS Cloud
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Don't know
Results:
I was getting this issue intermittently, but know I am unable to login on my Rancher setup.
Whenever I login on it, it does redirect to github, which redirects back to rancher, which is normal, but then it tries to reach /identities, which fails (image above), and the cattle ui redirects back to the login page warning that the session has timed out. (it also seems like a bad FE error handling)
PoC:

It seems that (blocked:mixed-content) is happening due to the /v2-beta/identities request is being made with the http protocol instead of https.
Could you please confirm if that's a CattleUI issue?

seems like a duplicated of #7804


Fix #623, Replace OS_FS_* return codes with common definitions

Describe the contribution
Removed The following OS_FS* defines from osapi-os-filesys.h:
OS_FS_SUCCESS, OS_FS_ERROR , OS_FS_ERR_INVALID_POINTER, OS_FS_ERR_NO_FREE_FDS , OS_FS_ERR_INVALID_FD, and OS_FS_UNIMPLEMENTED
Fixes #623
Used sed to perform a bulk find/replace on each one to swap with common definitions.
Testing performed
Steps taken to test the contribution:
Ran unit tests.

Expected behavior changes
None
System(s) tested on
Oracle VM VirtualBox
OS: ubuntu-19.10
Versions: cFE <IP_ADDRESS>, OSAL <IP_ADDRESS>, PSP <IP_ADDRESS>
**Contributor Info **
Dan Knutsen
NASA/Goddard

CCB 20200422 - APPROVED

@dmknutsen check conflicts, might want to rebase


'RCTBridge.h' file not found

Issue Description
"'RCTBridge.h' file not found" error in "CKGalleryCustomCellCollectionViewCell.h"
Steps to Reproduce / Code Snippets / Screenshots
drag and drop ios/lib files into project and import them and ad the .a file in the link binarys build phase to the master project

Environment

React Native Navigation version: 4.4.2
React Native version: 0.63.3
Platform(s) (iOS, Android, or both?): iOS
Device info (Simulator/Device? OS version? Debug/Release?): N/A

@supremevance, if you add the lib as a pod you shouldn't have this issue. I will work on updating the docs shortly, but the gist of it is doing a yarn or npm install of the project should autolink the library to your project, no need to manually add it in Xcode. Let me know if you have any other issues.


Add MAINTAINERS file

This change is

Coverage increased (+0.009%) to 45.454% when pulling 51921a6e4cfb6e0e6e2493a088b31b68bd96df39 on pr/tgraf/add-maintainer-file into 2586d5902b3ae7b369794fb06b95313cb2d9fd86 on master.