All three example fail to compile due to recent API change (objects -> planets)

All three examples (BL2009, CoRoT7, many_planets) yield an error message during compilation (appened below).  It looks like the error is caused by the recent renaming of RVmodel():objects into RVmodel():planets (cf. commit ffbc79264644c853abd79e0fdcf0086b5ea40ba2).
This issue will be easy to fix, but it demonstrates that this software will benefit from having the examples tested automatically upon each change (e.g. using Travis).  I will be opening a separate issue about this.
~/dev/kima/examples/CoRoT7 $ make
g++ -c -I../../src -I../../DNest4/code -I../../eigen -I../../celerite/cpp/include -o kima_setup.o kima_setup.cpp -pthread -std=c++11 -O3 -w
kima_setup.cpp: In constructor ‘RVmodel::RVmodel()’:
kima_setup.cpp:22:6: error: class ‘RVmodel’ does not have any field named ‘objects’
     :objects(5, 5, false, RVConditionalPrior())
      ^
kima_setup.cpp:24:58: error: no matching function for call to ‘DNest4::RJObject<RVConditionalPrior>::RJObject()’
     ,C(Data::get_instance().N(), Data::get_instance().N())
                                                          ^
In file included from ../../DNest4/code/RJObject/RJObject.h:129:0,
                 from ../../DNest4/code/DNest4.h:18,
                 from kima_setup.cpp:2:
../../DNest4/code/RJObject/RJObjectImpl.h:2:1: note: candidate: DNest4::RJObject<ConditionalPrior>::RJObject(int, int, bool, const ConditionalPrior&, DNest4::PriorType) [with ConditionalPrior = RVConditionalPrior]
 RJObject<ConditionalPrior>::RJObject(int num_dimensions, int max_num_components, bool fixed,
 ^
../../DNest4/code/RJObject/RJObjectImpl.h:2:1: note:   candidate expects 5 arguments, 0 provided
In file included from ../../DNest4/code/DNest4.h:18:0,
                 from kima_setup.cpp:2:
../../DNest4/code/RJObject/RJObject.h:27:7: note: candidate: DNest4::RJObject<RVConditionalPrior>::RJObject(const DNest4::RJObject<RVConditionalPrior>&)
 class RJObject
       ^
../../DNest4/code/RJObject/RJObject.h:27:7: note:   candidate expects 1 argument, 0 provided
../../DNest4/code/RJObject/RJObject.h:27:7: note: candidate: DNest4::RJObject<RVConditionalPrior>::RJObject(DNest4::RJObject<RVConditionalPrior>&&)
../../DNest4/code/RJObject/RJObject.h:27:7: note:   candidate expects 1 argument, 0 provided
Makefile:23: recipe for target 'kima_setup.o' failed
make: *** [kima_setup.o] Error 1

(This issue is part of openjournals/joss-reviews#487)

Thanks, @barentsen. Indeed this particular error is an easy fix, as you noted, but I also agree the long-term solution is to build the examples in Travis. I will take care of that ASAP.


Google Advanced Protection issue?

I have several Google accounts, both regular and G-Suite accounts, and I've enabled Advanced protection on all of them.
Thankfully, Mozilla Thunderbird is certified to work with Google accounts even if Advanced Protection is enabled.  In that regard, I have 0 issues with getting my mail, sending mail, etc.
I followed the wiki to set up an OAuth for the project I created (named GMail Sig Sync) and copied the OAuth ID in the options page to try to get it to connect, but I'm getting the following:

When I go to the URL mentioned to visit, I get the following:

I can run through the settings of the OAuth, but I followed it pretty closely - only difference was that I was forced to do the Consent screen with scopes before I could even add the OAuth Client.
Please let me know anything that I need to provide.

Hi!
Thanks for the report!
From the end: please not the URL of Google console is longer than you see in the window. I did a test, looks like you just didn't copy the whole address.
Anyway, the issue is with the redirect domain. Could you please verify the redirect URL in your Google project? It should looks like this:

PS. Not related, but please be aware of the issue https://github.com/kam193/thbrd-signature/issues/1 - I'm going to work on it this week.

Ahhh, it needs a forward slash.  Gotcha.  Trying it now.
Aaaaand - it broke.  This time directly because of Advanced Protection.

I've had plenty of small issues like this with AP enabled, but I cannot disable it for various reasons.  Hence my report.
Anyhoo - this may be a lot tougher to figure out.  I've tried to create a few working API calls and whatnot for a few different programs before, and AP has broken every single one of them.  May need to get a Google Cloud Engineer involved to try to fix it.

Yeah, it looks like working with the AP may be difficult. I'm also using the lowest possible permissions request :/ I think it would need a kind of special certification, but I'm struggling with the normal currently

Yup.  Had a feeling that AP would get in the way.
Sigh.
You'd think that Google would have a way for its own Cloud to work with its own Advanced Protection.
At any rate - if you need help testing further implementations of this add-on (which I absolutely love the idea of) with both regular Google accounts and G-Suite accounts (across 4 different domains) then let me know - I've been using the GMail web interface for a while but it's gotten old trying to maintain that many accounts via a browser, especially since a single Chrome profile instance only allows for 10 different logins - and I have 4 accounts each for the domains alone ... hence my move to using Thunderbird again.

Thank you :) I'm using it mostly with G-Suite accounts, I hope I'll find time to fix the long-time sync issue & force official certification process soon. I was surprised that similar extension didn't exist yet

I was surprised as well.   And since I just started using it and I cannot get it working yet, I haven't had a chance to encounter the long-time sync issue - yet.
Question:  does each Thunderbird profile need its own OAuth set up, or can you use a single one for every account / profile?
because if 1 can be used for many, I could (theoretically) create a new Google / G-Suite account that does not have AP enabled and use that across all the profiles and accounts, right?

OAuth/Google accounts are totally independent of Thunderbird profiles/accounts. So yes, you should be able to use 1 OAuth multiple times. Emails don't need to match, extension is always pulling the default signature from the Google Account. Let me know if this workaround works.

I'll give it a shot.  Worth testing at any rate :D

Ahhh, it needs a forward slash. Gotcha. Trying it now.
Aaaaand - it broke. This time directly because of Advanced Protection.

I've had plenty of small issues like this with AP enabled, but I cannot disable it for various reasons. Hence my report.
Anyhoo - this may be a lot tougher to figure out. I've tried to create a few working API calls and whatnot for a few different programs before, and AP has broken every single one of them. May need to get a Google Cloud Engineer involved to try to fix it.

Sorry for the late reply - RL gets in the way sometimes :D
OK, I created a new account that is NOT protected by Advanced Protection, and went through all of the steps to get a new OAuth Client ID (and enabled the free credit in Cloud for the new account).
I got the exact same message as above in the quotation.
So, the presence of Advanced Protection on an account is disabling access to the Signature in GMail, as noted by the documentation that you linked to, which is odd, because it specifically says most non Google apps (unless it is because it is marked as testing?  I really think we need to get a Google Cloud Engineer involved in this discussion).

OK, I created a new account that is NOT protected by Advanced Protection, and went through all of the steps to get a new OAuth Client ID (and enabled the free credit in Cloud for the new account).

Hmm, I don't think credits are needed for OAuth Client ID :)

I then tried to sync the signature for the newly created account not protected by Advanced Protection. While it connected just fine, it won't actually sync the signature that I created.

When you click on "Sync now" in add-on's preferences, do you see a note "Sync failed at..." with the current timestamp below requested account? And could you try to open the console (see screens below), then click on "Sync now" and show me, what you get?

I feel like there is something that stopped working recently. I need to investigate, so please give me a while to get into & eventually fix it :)

Yeah, I know the credits are not needed - but another application I used to use that made Google API calls through a Cloud account stopped working a couple of years ago, and I never once thought to point the finger at Advanced Protection, so I'm going to be testing that app as well, seeing if I can get it working again.
As for your addon - yes, exactly, "Sync failed at {current UNIX time}".
Since this is a throwaway account, I can share the console output - How should I send it to you?

You can send me the log console log on email<EMAIL_ADDRESS>I think I know what is the trouble (I'm looking for the solution now), but I wanted to confirm. I'm expecting you see  Error: Requires user interaction in the console.
I see you're using Daily on your previous screens :) Don't need to try on stable, I see the same issue on both versions.

Actually, no.
Email coming.

After working with @kam193 for a few days, I'm closing this issue as ver 2.x solves all issues with Advanced Protection on Google / G_Suite accounts.


chore: automated PR to update VHDVersion for 202305.23.0 VHD

This is an automated PR to bump VHDVersion for the VHD release with image version 202305.23.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.973%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
2544

Relevant Lines:
4105

💛  - Coveralls

closing since Mariner kata vhd's are fubar


az aks get-credentials: FAILURE.

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az aks get-credentials
Errors:
400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 206, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 608, in execute
    raise ex
cli/core/commands/__init__.py, ln 666, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
...
python3.6/site-packages/msrestazure/azure_active_directory.py, ln 486, in get_msi_token
    result.raise_for_status()
python3.6/site-packages/requests/models.py, ln 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az aks get-credentials --resource-group {} --name {}

Expected Behavior
Environment Summary
Linux-4.15.0-1077-azure-x86_64-with-debian-stretch-sid
Python 3.6.5

azure-cli 2.2.0 *

Additional Context

aks

hi @newwinagain have you installed aks-preview extension?

Hello! Please try again with the latest Azure CLI version. Feel free to reopen an issue if it still doesn't work.
https://docs.microsoft.com/en-us/cli/azure/install-azure-cli?view=azure-cli-latest


New project inquiries

Hello :)
I am totally new at programming, and wanted some advice.
I want to create a program using the google maps api.
Is Python the adequate programming language to use?
Thanks in advance for your answer :)

Hey inoxstasy, you are currently posting on a platform that is solely for issues related to the TensorFlow application and not at all meant for general programming questions like this. Try posting your question on https://www.reddit.com/r/learnprogramming/ or https://stackoverflow.com/. Good luck with your project.

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
Hence moving this to closed status.


Not working on Firefox

I'm using the version 42.0 of Firefox for Mac and the lazyload doesn't work well

By not work well do you mean there is not lazy load effect at all, or any other issue? Which version of react-lazyload are you using? Is there any console error? Can you share some snippets how you're using this library?
This might help debugging.

closing for no further information provided.

Same problem here.
I tried 2.1.0 - 2.1.6 but seems like none of them work.
There was no console error as far as I could notice.
I used react-lazyload with placeholders.
In Chrome it worked as expected and placeholders were replaced by actual contents when scroll down.
In Firefox, placeholders were there forever and no content was showen.

Is the demo working for you on Firefox? Which exact version of Firefox are you using? OS version appreciated too.


Jamie's Prettify Optimize redone

Description
Jamie's branch had a bunch of merge conflicts as well as some changes that needed fixing up and some changes that needed reverting.
Rather than dealing with this i just grabbed relevant code into this new branch.
Please ensure that youre happy with this!

Remember to delete the appropriate PR from @jamiewaese-uncharted as not overwrite this one.


Removing Travis

Now that Actions is running the standard CI we can remove the .travis.yml config
Signed-off-by: Chris Patterson<EMAIL_ADDRESS>

Now that we're doing this, we should also replace Travis URL in the README build badge with one that points to Action.

Yes we should do that.


Complete report of all queries

I used the following command and got the report as expected...
./pgbadger --format redshift find /tmp/mylogs/ -name "tylog"  --dbname vadb --outfile myq1.txt
As per the overall stats, there are 72,470 queries in the log files. How do I return all of these queries instead of concise report?

Overall statistics ---------------------------------------------------
Number of unique normalized queries: 7,388
Number of queries: 72,470
Total query duration: 0ms
First query: 2020-02-29 23:16:04
Last query: 2020-03-31 22:41:02
Query peak: 1,107 queries/s at 2020-03-04 21:13:38
Number of events: 0
Number of unique normalized events: 0

You can not, unless you just want the 7,388 normalized query. In this case use option --normalized-only.

Can you please consider adding a feature that will return all queries? It will help me a lot because even if the queries are there in the log files, it is very difficult to extract them using linux commands!

Commits c6ace51 and 67e63fb add this feature through a new query:
    --dump-all-queries     : dump all queries found in the log file replacing
                             bind parameters are included in the queries at
                             their respective placeholders position.

Note that queries are not sort by uniqueness, this must be done by an external command.

Thanks for considering the feature request. Can you remove line breaks and return a single query per line?

Thanks for considering the feature request. Can you remove line breaks and return a single query per line?

Or can you add a blank line between 2 queries?

Actually adding a blank line will not help because you can also have blank line in multi line queries, to help parsing the output script I have added a new option -Q | --query-numbering used to add numbering of queries to the output when using options --dump-all-queries or --normalized-only.
By this way you will have an identifiable separator between each line. Example:
# Query #1
SELECT * FROM table1;
# Query #2
DELETE FROM table1;
...

Forgot to give the commit: dd4b134


Add k8s installation method in infra setup

Update the infrastructure setup guide with instructions for installing the k8s deployment

This looks great! I did some rewording / formatting, and have a few questions. Otherwise this is good to merge :)


change lax_str and lax_int to support enum values that don't inherit from str or int

Use the ob_type.rs logic, should be faster too.

Hi, could I work in this issue?

@ThanhChinhBK Hello! Of cause you could. Just go for it!:)
If you'd encounter some difficulties you could submit a work in progress PR and ask for any advise you need.
Cheers!


Support for macOS 10.13.1(17B1003)

Changed the required OS version.
It worked in my environment.

@huntrax11 thanks


Add bootstrapping support

Issue #, if available:
Description of changes:
This PR is tracking the progress of adding bootstrapping to the Lattigo branch. It should always pass CI, and when all the checkboxes have been ticked, it will be merged into the lattigo-backend branch.
Adds bootstrapping support to the Lattigo branch.
Updated evaluators:

[x] API
[x] OpCount
[x] Plaintext
[x] DepthFinder
[x] ScaleEstimator
[x] Parameterization
[x] RotationSet API
[x] Homomorphic
[x] Debug
[x] LinearAlgebra
[x] Serialization
[x] Update Examples
[x] Update README

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This branch just collected other reviewed PRs; merging.


update deployment specialized knowledge text

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gargana Please take a look at this PR as per Sheryl's request. thanks

I will be reviewing with the tech writer team tomorrow AM.


add column name normalization

In reference to #22
Primary code taken from MIT licensed CSV.jl[1], originally written by @quinnj I think.
I am having a hard time getting test to run - I think I am not utilizing Snoop correctly. I get a lot of errors similar to this when trying to run the tests as is:
 MethodError: no method matching TableReader.ParserParameters(::Char, ::Char, ::Bool, ::Bool, ::Int64, ::Bool, ::Nothing, ::Bool, ::Bool, ::Int64)

I tried running the /tools/snoop.jl and copying the output to the end of the TableReader.jl file, but that didn't seem to work. Reading the documentation of SnoopCompile.jl, it seems like there should be a /tmp/precompile folder created that I should also bring into /precompile/ but I don't see that folder get generated (I do get a compiles.csv). (I did not include the changes I attempted related to Snoop.jl in the initial commit).
Also, this is my first real attempt at an issue/pull request on GitHub, so please let me know if I'm going about it wrong.
1: https://github.com/JuliaData/CSV.jl/blob/da5bcbb53a3f4b02eb1d71b0849a5f88e1d12fe0/src/filedetection.jl#L8

Great! I think this feature is nice. Let me add a few comments:

Description of the normalizing behavior is required in the docs.
If you take the code from another repository, you need to mention it and clarify the range of it.
Precompiled files will be generated at the current directory where you are working; please check precompile/precompile_TableReader.jl file.

I think you need the RESERVED list of words, right? Here: https://github.com/JuliaData/CSV.jl/blob/master/src/filedetection.jl#L1. Also, don't worry about attributing here; I'm pretty sure I took a start from some DataFrames and enhanced it for CSV.jl. Really, someone should just put this in Base since it's generally useful.

Codecov Report

Merging #23 into master will decrease coverage by 2.61%.
The diff coverage is 39.28%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   76.35%   73.73%   -2.62%
==========================================
  Files           4        4
  Lines         981      990       +9
==========================================
- Hits          749      730      -19
- Misses        232      260      +28

Impacted Files
Coverage Δ

src/tokenizer.jl
67.04% <ø> (+0.75%)
:arrow_up:

src/TableReader.jl
78.83% <27.27%> (-11.17%)
:arrow_down:

src/parser.jl
84.76% <83.33%> (-0.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9bcb54...0b76fb8. Read the comment docs.

I think this should be good to go - I added some test cases, documentation in TableReader.jl, and updated the precompile block with the newly generated Snoop output. Please let me know if you have thoughts/feedback.

Great work! This looks good. I will merge this and close #22.

Thanks for the help with the PR, @bicycle1885


KAFKA-6054: Code cleanup to prepare the actual fix for an upgrade path

Small change in decoding version 1 metadata: don't upgrade to version 2 automatically

@bbejeck @vvcephei @guozhangwang @dguy
This is almost a pure code cleanup PR -- required to get clean code for introducing next metadata version.
One change: we should not auto-upgrade the received subscription info (from 1 to 2), otherwise the leader does not know what it received and what encoding to use for the assignment to send back (must send back version 1 encoding if at least one version 1 subscription was received).

one meta-comment might be worth commenting in AssingmentInfo why we need to call encodeVersionOne from encodeVersionTwo (and for decode... as well) like you did in the PR description above.
Otherwise LGTM.

@mjsax Just clarifying that with this patch, KAFKA-6054 is still not resolved right?

Correct. This is not a fix for KAFKA-6054 -- I plan to piggyback a fix with the RocksDBs upgrade story -- we need to add a config to fix it and thus need a KIP.

Updated this. @bbejeck I followed Guozhang's suggestion to rename the encoding-methods -- this should address your comment, too?

LGTM! Left a minor comment on the PR, please feel free to merge after addressing it

Updated. Will wait for build to pass.


Problem with SelectDateComponent on chapter 17

Hello, I am having problems trying to use the SelectDateComponent as a modal.
Every time I tapped into  <TextField [text]="page.BirthDate | date:'shortDate'" class="input" editable="false" (tap)="onBirthDateTap()" hint="Enter a birth date..."> via onBirthDateTap() the modal won't open and the following error appears on the console.
JS ERROR TypeError: value.getFullYear is not a function. (In 'value.getFullYear()', 'value.getFullYear' is undefined)
My setup:
Component        │ Current version │ Latest version │ Information   │
│ nativescript     │ 3.4.1           │ 3.4.1          │ Up to date    │
│ tns-core-modules │ 3.4.0           │ 3.4.0          │ Up to date    │
│ tns-android      │                 │ 3.4.1          │ Not installed │
│ tns-ios          │ 3.4.1           │ 3.4.1          │ Up to date

Hello, I have the same problem. Did you fix it maybe and how?


Check for hyper training legality

Checks for...

31 (cannot be hyper trained)
6IV pokemon (cannot be hyper trained)
Hyper trained when not level 100

No nitpicks pls :P


search in projects windows doesnt filter path names

Godot version: v3.2.1.stable.official
OS/device including version: Debian/testing
Issue description: Type something included in the path, it doesnt filter them

This is intended behavior. If the filter doesn't contain a slash, it will only search in the last path component (i.e. the project folder name). If it contains at least one slash, the entire path will be searched for. See #31356 for details.

Having to add a / to the search to include paths in the search works but is very convoluted and virtually undiscoverable unless somebody tells you about it
I have projects filtered by folders years. It just felt like a bug when typing 20 didnt yield any result... Although /2018 did worked
Also, it happened a few time where i knew the name of the folder but not the name of the project and it felt really weird that it couldnt find it on the list
Your example is also weird. People were having issues because all your projects were showing... Who was searching for Documents or Godot?
I admit it wont happen again now that i know the / trick :)
But a checkbox "path" next to the search box would be more discoverable for new users
Such as

[ ] path

Optimal solution would be fuzzy search, that allows you to type several strings and filters anything that contain any of those strings anywhere
Like this: https://github.com/farzher/fuzzysort

Having to add a / to the search to include paths in the search works but is very convoluted and virtually undiscoverable unless somebody tells you about it

I'll add a tooltip about it.


Add examples: cypress/base, cypress/browsers and GitHub Actions

This is an enhancement suggestion.
Suggestion
Create simple Cypress E2E projects in the existing examples directory:

[x] E2E project with Cypress dependency for use with cypress/base and cypress/browsers
[ ] E2E project with no Cypress dependency for use with cypress/included

Create a workflow:

[ ] GitHub Actions workflow which demonstrates use of cypress/base, cypress/browsers and cypress/included images

[ ] Document the examples in the appropriate README files.

Why is this needed
Gaps in example coverage make it more difficult to learn how to use the Cypress Docker images effectively.
The repo is missing examples for

cypress/base
cypress/browsers

Examples in

README cypress/included are missing an example project to run against.

The linked GitHub Actions example mentioned in README > cypress/included > GitHub Action which is linked to https://github.com/cypress-io/github-action#docker-image covers only the use of cypress/browsers and does not demonstrate:

cypress/base
cypress/included

PR #1110 is the first step to implement this suggestion

PR https://github.com/cypress-io/cypress-docker-images/pull/1113 extends the example documentation

Due to https://github.com/cypress-io/cypress-docker-images/issues/1119 there is a delay in implementing this suggestion for cypress/included.

PR #1118 adds the suggested project

https://github.com/cypress-io/cypress-docker-images/issues/1119 is resolved by following the instructions in https://github.com/cypress-io/github-action/pull/1202 to set the environment variable CYPRESS_INSTALL_BINARY=0.


showMode should use jQuery's show method

Lines 1425-1429, within the showMode method, look like this:
this.picker
  .children('div')
  .hide()
  .filter('.datepicker-' + DPGlobal.modes[this.viewMode].clsName)
    .css('display', 'block');

This is making the implicit assumption that jQuery's hide method is just changing the display property of the selected elements. If you're going to use hide to hide the divs, why not use show to show them?
This isn't merely pedantic. I'm raising this issue because it legitimately caused me trouble recently. I had overwritten the $.fn.hide and $.fn.show methods to add and remove (respectively) a Bootstrap class, .hidden. Overwriting library methods might be a questionable practice, but it was a working hack until I incorporated the datepicker. My suggestion is to change the code to
this.picker
  .children('div')
  .hide()
  .filter('.datepicker-' + DPGlobal.modes[this.viewMode].clsName)
    .show();

That will work regardless of the implementation of $.hide and $.show, provided that they undo each other.

feel free to mage a pull request.

Shall do. Thanks for the rapid response!

For the record I would tag this as a bug, not a feature request. Don't you think?

@milotoor seleted the wrong label ;)

Pull request: #1427. Please let me know if there are any changes you would like! I'm not very familiar with qUnit, but tried my best to follow conventions.

Incidentally, two tests were failing on my local machine that don't appear to be failing in the CI build. I'll look into that.


ARROW-15665: [C++] Add error handling option to StrptimeOptions - follow up

As reported by @dragosmg the following:
std::string input2 = R"(["5-1-2020", "12/13/1900"])";
std::string output2 = R"([null, "1900-12-13"])";
Strptime(input2)

Would cause:
Expected:
  [
    null,
    1900-12-13 00:00:00.000000
  ]
Actual:
  [
    null,
    1970-01-01 00:00:00.000000
  ]

This was due to out_data pointer not updating on failed parsing.
This change fixes the issue and adds a test.

@lidavidm I'm a bit embarrassed by this one :)


Increase precision to microsecond when using time 0.3.x

Hi @blackbeam.
Thank you very much for maintaining this crate.
Is it possible to increase precision of time::PrimitiveDateTime, time::Time to microsecond when using time 0.3.x?
As far as I understand time supports up to nanosecond precision, and so we just need to provide the necessary formatting.
time = { version = "0.3.11", features = ["serde", "parsing", "formatting", "local-offset", "serde-human-readable", "macros"] }
#[cfg(test)]
mod tests {
    use time::{format_description, PrimitiveDateTime};
    use time::macros::datetime;

    #[test]
    fn test_time() {
        let format = format_description::parse("[year]-[month]-[day] [hour]:[minute]:[second].[subsecond]").unwrap();
        let datetime = "2020-01-02 03:04:05.123456";
        let parsed = PrimitiveDateTime::parse(datetime, &format).unwrap();
        assert_eq!(parsed, datetime!(2020-01-02 03:04:05.123456000));
        println!("{parsed:?}");

        let formatted = parsed.format(&format).unwrap();
        println!("{formatted}");

        assert_eq!(datetime, formatted);
    }
}

There is also https://time-rs.github.io/api/time/format_description/modifier/enum.SubsecondDigits.html if it's somehow helpful.
Thanks!
Edit: I just found that there a modifier for a strict number of digits in subsecond: let format = format_description::parse("[year]-[month]-[day] [hour]:[minute]:[second].[subsecond digits:6]").unwrap();.
https://github.com/time-rs/time/discussions/418

Published as v0.29.1

Thank you for such quick turnaround!


Collapse db should requests user intervention before to remove local accounts

moved here https://github.com/Ks89/My-MEAN-Website-client/issues/7


Address incorrect AssertNotNull calls

Codecov Report
Base: 86.60% // Head: 86.58% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (a238001) compared to base (aa1d3ea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   86.60%   86.58%   -0.02%
==========================================
  Files         183      183
  Lines        4823     4817       -6
  Branches     1085     1082       -3
==========================================
- Hits         4177     4171       -6
  Misses        353      353
  Partials      293      293

Impacted Files
Coverage Δ

Source/SuperLinq/Pad.cs
100.00% <100.00%> (ø)

Source/SuperLinq/PadStart.cs
100.00% <100.00%> (ø)

Source/SuperLinq/Partition.cs
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Unexpected/Missing Course Description for Texas A&M International University CSV file

The Texas A&M International University CSV file has the following issues.
AI Course Crawler Extract link: https://master.ai-course-crawler.development.c66.me/datasets/courses/15
Extract file in Google Sheets with comparison to expected: https://docs.google.com/spreadsheets/d/1T-R2UudsM2KdzZtQHX5Xrvo8y8lr4ON6lz6ZJ7L1sME/edit?usp=sharing
The information below is applicable to the majority of courses with this data set.
ALL ISSUES

Unexpected URL for InCatalog
Missing Prerequites for course (should be a Condition Profile format)
Missing credit hours on the URL page referenced InCatalog

EXPECTED, see highlighted row in the "Comparison to Correct Bulk Upload" tab in this spreadsheet
Using ARTS 3330 18th & 19th Century Art course as example (it's the example highlighted in the Google sheet linked above)

Expected description: Selected areas of study in the arts of Europe and North America from about 1700 to about 1860. The evolving cultural and economic roles of art, artists, and audiences in the modern era will provide an organizing theme.

Expected URL: https://catalog.tamiu.edu/course-descriptions/arts/

Expected Condition Profile with ConditionProfile: Description: ENGL 1302 or consent of instructor.

Here is what was listed for this course in the URL provided to the crawler:

Here is what was listed for this course in the URL included as InCatalog for ARTS 3330:

As with other issues, I was able to improve extraction with some changes to recipe detection.
However, even with a correctly configured recipe, the catalogue URL isn't yielding very good results. It looks like that catalogue management system is a little tricky because better data about the courses does exist (see for example ACC 2301 which I found by using the search page), but an index for the data isn't easy to access.
Using that link I found by searching the website, I managed to find an index here but I'm not sure whether that's being linked to anywhere.
I added a configuration for the more complete index here and started an extraction which seems to yield much better results as there's more data to work with.
When that extraction finishes, please check it out - we can keep using this issue.
For the course requisites see #43.


Avoid unnecessary calls to listeners

This PR is a better version of #1626.
Please see the original comment for explanation of aims and proposed solution (mainly related to efficiency and effectiveness of code).
In my opinion the present proposal lowers the computational complexity of the recursive dispatch mechanism and prevents listeners to be notified more than once with the very same state value during the same call to dispatch.
The cost to be paid is the use of slice and shift operations on listener arrays which is anyway O(N) (with N the number of registered listeners) and usually in the order of microseconds.
There is another interesting issue which is solved by the present proposal. Consider the following example:
var unsubscribe2
const store = createStore(myReducer)

store.subscribe(() => {
  const state = store.getState()

  if (condition1) {
    unsubscribe2()
  }

  if (condition2) {
    store.dispatch(actionYYY())
  }
})

function listener2() {
  // ...
}
unsubscribe2 = store.subscribe(listener2)

store.dispatch(actionXXX())  // --> making true both condition1 and condition2

With the current code, in case both condition1 and condition2 result true at the same time for a particular state, listener2 will be notified with the new state value as set because of actionYYY and not as it was set because of actionXXX (when the first listener decided it was the right time to unsubscribe listener2...).
With the new code, listener2 will be notified its last time right before its actual unsubscription, hence with the state as set by actionXXX.
But that's not all.
As a general note I think we should provide a more detailed contract for the subscribe and unsubscribe API calls and listeners notifications.
With the present proposal we could be able to state:

listeners will not be notified with state changes in response to calls to dispatch occurred before their subscription (trivial...).
listeners will not be notified with state changes in response to calls to dispatch occurred after unsubscription requests.
listeners will be notified at least once with the most recent state after a call to dispatch.
in case of nested calls to dispatch, listeners could be notified more than once with updating state values but this is not guaranteed and can easily vary depending on the order of subscriptions.
listeners will be notified at most once with the very same state in response to the very same call to dispatch.

By further modifying dispatch to look like this:
function dispatch(action) {

  let nextState
  try {
    isDispatching = true
    nextState = currentReducer(currentState, action)
  } finally {
    isDispatching = false
  }

  if (nextState !== currentState) {
    currentState = nextState
    listeners = currentListeners.slice()
    while (listeners.length) {
      listeners.shift()()
    }
  }

  return action
}

at no additional cost, we could change 5. to:
5. listeners will never be notified twice with the same state value
Obvioulsy, secific tests should be added to support these statements.
...and I'll be happy to add them in case you're interested to proceed further with this.

listeners will never be notified twice with the same state value

I'm really not liking this part of the proposal. Many times subscribers are used to integrate external libraries with Redux. And these external libraries normally have some of their own state that is stored externally and make conditional decisions based on that external state, particular to the needs of that library. react-redux does this, using a subscriber and it's own local state.
By attempting to optimize on the user's behalf, we take away some control that they have to behave different depending on state external to the store. This would end up breaking certain types of integrations. It's simpler and more powerful to leave the referential equality check as an option to the user.

Also, definitely see #1729, as it is directly related to this. I know @acdlite also wants to nail down the exact contract provided by subscribe.
For this effort, as @gaearon has stated, we should rewrite the tests (and allow them to break) to ensure that contract is codified. A test-first approach is best here because once that test suite passes, we can know we have the expected behavior. We just need a comprehensive set of tests.

I'm really not liking this part of the proposal. Many times subscribers are used to integrate external libraries with Redux.

Fair enough!
I was not aware of this, my fault

Ok, this seems the golden proposal to me :-)
No use of slice nor shift, more or less is like before.
The crucial differences are:

notify a listener in case it is being unsubscribed during dispatch notification and it was not yet notified about the last state change (see here); a specific test was added to ensure this (see here)
use global listeners and listenerId to reset the notification cycle from zero at every new nested call to dispatch (see here)
mark the end of notifications when the deepest nested call to dispatch completes the cycle so that shallower paused cycles will be abandoned straight away (see here)
align currentListeners to nextListeners at the end of notifications to forget the old list of listeners and possibly free some resources; this is effective only in case during the notification cycle some subscriptions/unsubscriptions happened (see here)

Thanks @timdorr for your comments: without them I wouldn't have pushed too much for the optimization of array copies!

Let's see what happens in #1729 for now. I would submit some PRs to https://github.com/acdlite/change-emitter to get the ball moving.


[HDRP] Peristent little waves even with all spectrum pushed to 0

As the title says there is persistent little waves even with all sliders pushed to 0.
Keep hard work guys ! ( with the particle fx ? ... :) )

Thanks for reporting. Is this what you are seeing? All spectrum component sliders at 0 but the spectrum weight is at 1.

Hi @VizzzU and @daleeidd !! You mean with this problem that I opened ( https://github.com/crest-ocean/crest/issues/519#issue-623875617 ), in which the waves produced by the shader normals are those that exist in motion when all the waves of the spectrum are at 0?
In this video I have all the waves of the spectrum at 0 but there are still ripples in the water that move due to the Crest Shader Normal ...
https://youtu.be/byi7G2PXrxk
Regards

@ftejada17 ,  that's it ! I m sorry   I use to check issues posts before pushing one but i ve missed yours . Think that @daleeidd  Can close this one

I think there are 2 ways to interpret the above issue.
@daleeidd i think you have identified one issue in your screenshot, this is the issue i would think of when reading this title. i think we should fix this. I think its a case of extending the min spectrum power range, it was laziness/dodginess on my part that the above is happening. The min power is not low enough to stop short wavelengths appearing :/. If you do look at it, it would be good to verify that no waves are rendering - HasWaves should be false after the update function is called (_gerstner.UpdateBatch(this, _batchIndex);), if all sliders are set to min values.
the second interpretation which i think is referred to in 519 is connecting the normal maps to the spectrum values, it would be cool if the strength of the normal maps were connected to the spectrum values, so that when you turn down the spectrum the normal maps also go away. i guess they could be keyed off whatever spectrum values are below the current lowest LOD scale (i.e. if the current lods have waves down to 1m wavelength, the normal maps are keyed off the 0.5m wavelength spectrum slider?). it could be interesting to experiment with this to see if it works or not. what are your thoughts?

I think its a case of extending the min spectrum power range

Sounds good.

Fix proposed in referenced PR


how to config ABM for this situation?

Hi,
I wanna first thank you for this project, it's indeed easier to use than Unity's abm, and I use it in my project.  I had some question about how to config the ABM for this scenario.
our project use asset bundle browser to build asset bundles.
Q:

After build the asset bundles, we put all abs in to a asset server and put some of the abs into streaming asset folder which can be load and played offline,
how can I configure the ABM to enable it can check the asset bundle cache version, if it's cache, it just load from streamingasset folder, if the cache version is old , it will download from server.

I try this code
abm = new AssetBundleManager();		 		abm.SetPrioritizationStrategy(AssetBundleManager.PrioritizationStrategy.PrioritizeStreamingAssets);         abm.SetBaseUri(GameConfig.GetBaseURI());
I'm not sure it's going to work,

Asset bundle browser build generate the manifest for every asset, in our project, most asset has no dependency, It there any interface that can skip check the manifest dependency globally or for a specific asset bundle ?

3.If I put the IOS, and IOS meanfest bundle in streammingAsset folder,  when game start up, It should always to load the IOS ab from asset server, How can I make sure it work in this way when the network is connectable.?

when I use abm.UseStreamingAssetsFolder(), and the IOS path is correct, it always show host is not connectable ?   how can i fix this ?

sorry for ask so many questions in a time.
thanks

The behavior you're looking for is the default behavior.  ABM will use the remote bundles if they are different from the streaming bundles.  When ABM downloads the remote bundles it caches them for use later (with the exception of the manifest bundle which is always downloaded)  You don't need to change the prioritization strategy.  PrioritizeStreamingAssets tells ABM to always use StreamingAssets if they exist.

When you try to download a bundle ABM will check the primary manifest to see if there are any dependencies and download those as well.  If the bundle has no dependencies then nothing extra will be downloaded.  This operation is all done locally and should have minimal to no impact on performance.  Why don't you want it to check for dependencies?

This should be the default behavior.  Are you seeing something different?

When you call UseStreamingAssetsFolder then ABM will only use that folder, it will not try to connect to a remote server.  Can you provide some code and a log of what you're seeing?

Hi Fodder,
thanks for your explanation.
Currently I build all the asset bundles by ABB, and copy all file to streammingAsset folder, including the platform file (iOS, iOS.manifest...),
abm = new AssetBundleManager();
abm.SetBaseUri(GameConfig.GetBaseURI());
use this code to initialize abm.
when I install the builds and run on devices.
what is want is all the download files should be cached (except iOS.manifest), and should load from streamingAsset folder to fast loading asset.
but the log says all files are uncached , and load from remote server.

and also when disconnect the network, the abm still try to downloading from remote server, didn't try to load from StreammingAsset folder.
"
The behavior you're looking for is the default behavior. ABM will use the remote bundles if they are different from the streaming bundles. When ABM downloads the remote bundles it caches them for use later (with the exception of the manifest bundle which is always downloaded) You don't need to change the prioritization strategy. PrioritizeStreamingAssets tells ABM to always use StreamingAssets if they exist.
"
how abm check the difference between the remote server and streammingasset folder ?

but the log says all files are uncached , and load from remote server.

I'll test this scenario out this weekend.  It might be helpful if you include the full log as well.

how abm check the difference between the remote server and streammingasset folder ?

Asset bundle manifest files contain hashes for every bundle.  When you tell ABM to get a bundle it compares the hash for that bundle in the remote location against the one in the StreamingAssets folder.  If the hash is the same it uses the bundle in StreamingAssets, otherwise it download the bundle from the remote location.

Hi Fodder,
I've found the issue, it's the problem when build iOS project, the streamingasset folder doesn't copy to device correctly, so every time abm has to load from server.
you don't need to test that.
except that, I found this method in ABM.cs
`
private void GenerateUnhashToHashMap(AssetBundleManifest manifest)
{
unhashedToHashedBundleNameMap.Clear();
        var splitChar = new[] { '_' };
        var allBundles = manifest.GetAllAssetBundles();

        for (int i = 0; i < allBundles.Length; i++) {
            var split = allBundles[i].Split(splitChar, 2);
            if (split.Length != 2) continue;
            unhashedToHashedBundleNameMap[split[0]] = allBundles[i];
        }
    }`

I'm not totally understand what's this function do and why the bundle name has to be "x_x", I found my bundle name is not that but still works fine.
do we have the name rules for bundle name ?

AssetBundleBrowser has the option Append Hash, which will add the bundle hash to the bundle file name.
When they are built like this the end result is a file with a name like FILENAME_HASH.  The function above is to split out the hash from the filename.  You shouldn't need to worry about this if you are not making bundles with Append Hash checked.


LiteDB query in 2 related Collections

I have a LiteDB database with 2 POCO classes
Author that includes "Id" and "Name", as Properties
Book that includes "Title" "Id" and "Author"(this property has a bson reference to the Author's collection)
I'm trying to query the book collection in order to retrieve all authors named "John" that wrote one or more books.
class Author // collection "authors"
{
[BsonId]
public int id {get; set;}
public string Name{get; set;}
}
class Book //collection "books"
{
[BsonId]
public int id {get; set;}
public string Title{get; set;}
[BsonRef("authors")]
public Author author {get; set;}
}
Thank you for the help
P.S. I know that it's not for what litedb is been made for but I have to do this.

You can use Linq to do this:
db.Query<Authors>()     .Include(x => x.Books)     .Where(x => x.Name.Containes("John")     .ToList()
Or you can do it this way with LiteDB expressions:
var result = Authors     .Include(x => x.Books)     .Find(Query.Contains("Name", "John")

@cese01 I believe the answer of @Brannos1970 resolves your question so I'm closing the issue. If you feel like you're question hasn't been answered yet, you can re-open the issue.


Add worker spec for 302 response from Zendesk

Trello card

build failure, otherwise looks good :) :+1: :shipit: -- I assume the build failure is because the helper isn't available yet because the GdsZendesk gem hasn't been updated per the other PR?


Options not available under current master?

I just ran this right now:
wget https://github.com/devttys0/binwalk/archive/master.zip; unzip master.zip; (cd binwalk-master && sudo python setup.py uninstall && sudo python setup.py install)
It installed and runs successfully, showing the following:
Binwalk v2.1.2b
It appears several options, such as --deflate or --lzma, are not available in this version; they result in the following:
surfrock66@sr66-darter:~/Downloads$ binwalk --deflate chipdump1
General Error: Cannot open file : [Errno 2] No such file or directory: '--deflate'
These options also do not appear in the help text.  Is there something I must do to enable those?

Some binwalk options are disabled if their required dependencies are not installed on the local system. Adding some output indicating which options are disabled is on my todo list, but I haven't gotten around to it yet.
Binwalk's raw decompression module (which handles the --deflate and --lzma options) requires the Python lzma module, which is not installed by default with Python 2.x. Python3 does include the lzma module by default, or you can install the lzma module for Python2 (e.g., sudo apt-get install python-lzma).

If Python can import lzma, then the -X and -Z options should be enabled. The fact that you aren't getting -Y either, even though you installed capstone, which -Y relies on, suggests to me that this may be a system-specific issue. Possibly an problem with your Python paths?
As a test, install binwalk under Python3; there, you should at least have the -X and -Z options, since the lzma module is standard in Python3.


fix(opossum): Get license texts via the provider

Do not directly call the low-level getLicenseText() function, but get the license texts via the provider passed as part of reporter input.

Merging despite the unrelated (temporary) test failures.


Restrict CloudSQL instances with public IP

Initial commit of forbiding CloudSQL instances from having a public IP

@morgante @t12g  based on our last discussion, it seems to be more natural to fit this to the gcp external ip access constraint template, is that still the case?
https://github.com/forseti-security/policy-library/blob/master/policies/templates/gcp_external_ip_access_v1.yaml

@joecheuk I think that constraint should actually be specifically for VMs while we add this new CloudSQL one.
Eventually we could consider a super-constraint for all resource types.


Update for October 23, 2018

I've also deployed it to https://slides.hacksoc.net from the fork

Looks good to me, thanks for remembering these needed updating too 😛


Action right after screenshot is taken

I wanted to play sound right after taking screenshot. Right now I'm using edit_command for this:
edit_command="paplay .camera.wav &"
edit="true"

It doesn't seem right because when I want to use editor I can't just use -e true. I have to insert whole command, for example -i "paplay .camera.wav & gimp %img".

Sorry for the (very) late response. You should be able to achieve this by using something like this:
screenshot_select_command="scrot -s %img && paplay .camera.wav"


Bonsai with Bridge?

Hello, I am simulating a cluster with background gas potential and till now I was using ph4 for the N-body solver and bridge to couple the gas and the particles. However, I am thinking to use Bonsai to run the simulations for bigger clusters (>= 10^4) particles. I am just making sure that Bonsai can be used with Bridge the same way ph4 can be?

Yes, this is possible. Bridge will work with any gravity code.
You might also want to consider PeTar, which is a hybrid tree/direct Nbody code.

@rieder Thank you. Yes Petar might be worth trying but can you guide me how to install it? I am having trouble to just use the make clean and then make like rest of the community packages.

Bonsai should work fine with Bridge - it's just important to be aware of its limitations as a tree code.
To use PeTar you need to install AMUSE via the "development" installation documented here: https://amuse.readthedocs.io/en/latest/install/howto-install-AMUSE.html#development-build
Please let us know if you run into issues with this.

When I am trying to use the make inside petar I am getting the following error @rieder @spzwart
downloading finished
unpacking 3370a770cb444eab106c81a6ebbc4cb9ef5226d6.tar.gz
done
cp src/PeTar/amuse-interface/interface.py ./
cp src/PeTar/amuse-interface/interface.h ./
cp src/PeTar/amuse-interface/interface.cc ./
type=c interface.py petarInterface -o worker_code.cc
/bin/sh: interface.py: command not found
Makefile:86: recipe for target 'worker_code.cc' failed
make: [worker_code.cc] Error 127 (ignored)
type=H -i amuse.support.codes.stopping_conditions.StoppingConditionInterface interface.py petarInterface -o worker_code.h
/bin/sh: -i: command not found
Makefile:89: recipe for target 'worker_code.h' failed
make: [worker_code.h] Error 127 (ignored)
sed 's/@VERSION@/'cat src/PeTar/VERSION'_'cat src/SDAR/VERSION'/g' src/PeTar/src/get_version.hpp.in >src/PeTar/src/get_version.hpp
mpicxx -I src/PeTar/src -I src/SDAR/src -I src/FDPS/src  -fPIC -O2 -Wall -std=c++11  -fopenmp -march=core-avx2 -D INTRINSIC_X86 -D USE_SIMD -D DIV_FIX -D PARTICLE_SIMULATOR_THREAD_PARALLEL  -D PARTICLE_SIMULATOR_MPI_PARALLEL -D MPICH_IGNORE_CXX_SEEKC -D SOFT_PERT -D AR_TTL -D AR_SLOWDOWN_TREE -D AR_SLOWDOWN_TIMESCALE -D CLUSTER_VELOCITY -D USE_QUAD -D STELLAR_EVOLUTION -D PROFILE -D HARD_CHECK_ENERGY -D TIDAL_TENSOR_3RD -D INTERFACE_DEBUG_PRINT -D INTERFACE_DEBUG  -c -o interface.o interface.cc
In file included from interface.cc:2:0:
interface.h:2:22: fatal error: stopcond.h: No such file or directory
#include <stopcond.h>
^
compilation terminated.
Makefile:95: recipe for target 'interface.o' failed
make: *** [interface.o] Error 1


Sprint1 cleanup

Moved getRegionExtent to spatialUtils. Also added conus_extent to the config for both mapUtils and spatialUtils. Going to merge.


Enable pre-encoded mixup

Enable using CutMix/MixUp with pre-encoded labels

Todo:

[x] update test
[x] check for already encoded inputs

Thanks for the PR @mahdilamb .
Supporting labels that are already one-hot-encoded sounds OK to me, but instead of adding a new parameter, it seems that we could instead just check the shape of the labels and only call one_hot if the ndim != 2?
We would also need to add a few tests here https://github.com/pytorch/vision/blob/8b6c5e74b08c18ec21d98c6e65513025263da335/test/test_transforms_v2.py#L2170

Hi @NicolasHug makes sense to me. I'll get that moving

Hi @NicolasHug , that's updates as requested... it breaks Compose though!

Hi @mahdilamb  - I've made a few changes to the PR locally but when I cannot push to update the PR, because you created from your main branch, so I don't have the permissions.
Would you mind closing this one and re-opening a new PR from a dev branch (i.e. do git checkout -b my_branch before committing)?
Alternatively you could also apply this diff to the current PR:
diff --git a/test/test_transforms_v2.py b/test/test_transforms_v2.py
index 190b590c89..07235333af 100644
--- a/test/test_transforms_v2.py
+++ b/test/test_transforms_v2.py
@@ -2169,29 +2169,30 @@ class TestAdjustBrightness:

 class TestCutMixMixUp:
     class DummyDataset:
-        def __init__(self, size, num_classes, encode_labels:bool):
+        def __init__(self, size, num_classes, one_hot_labels):
             self.size = size
             self.num_classes = num_classes
-            self.encode_labels = encode_labels
+            self.one_hot_labels = one_hot_labels
             assert size < num_classes

         def __getitem__(self, idx):
             img = torch.rand(3, 100, 100)
-            label = torch.tensor(idx)  # This ensures all labels in a batch are unique and makes testing easier
-            if self.encode_labels:
-                label = torch.nn.functional.one_hot(label, num_classes=self.num_classes)
+            label = idx  # This ensures all labels in a batch are unique and makes testing easier
+            if self.one_hot_labels:
+                label = torch.nn.functional.one_hot(torch.tensor(label), num_classes=self.num_classes)
             return img, label

         def __len__(self):
             return self.size

-    @pytest.mark.parametrize(["T", "encode_labels"], [[transforms.CutMix, False], [transforms.MixUp, False], [transforms.CutMix, True], [transforms.MixUp, True]])
-    def test_supported_input_structure(self, T, encode_labels: bool):
+    @pytest.mark.parametrize("T", [transforms.CutMix, transforms.MixUp])
+    @pytest.mark.parametrize("one_hot_labels", (True, False))
+    def test_supported_input_structure(self, T, one_hot_labels):

         batch_size = 32
         num_classes = 100

-        dataset = self.DummyDataset(size=batch_size, num_classes=num_classes,encode_labels=encode_labels)
+        dataset = self.DummyDataset(size=batch_size, num_classes=num_classes, one_hot_labels=one_hot_labels)

         cutmix_mixup = T(num_classes=num_classes)

@@ -2201,10 +2202,7 @@ class TestCutMixMixUp:
         img, target = next(iter(dl))
         input_img_size = img.shape[-3:]
         assert isinstance(img, torch.Tensor) and isinstance(target, torch.Tensor)
-        if encode_labels:
-            assert target.shape == (batch_size, num_classes)
-        else:
-            assert target.shape == (batch_size,)
+        assert target.shape == (batch_size, num_classes) if one_hot_labels else (batch_size,)

         def check_output(img, target):
             assert img.shape == (batch_size, *input_img_size)
@@ -2215,10 +2213,7 @@ class TestCutMixMixUp:

         # After Dataloader, as unpacked input
         img, target = next(iter(dl))
-        if encode_labels:
-            assert target.shape == (batch_size, num_classes)
-        else:
-            assert target.shape == (batch_size,)
+        assert target.shape == (batch_size, num_classes) if one_hot_labels else (batch_size,)
         img, target = cutmix_mixup(img, target)
         check_output(img, target)

@@ -2273,7 +2268,7 @@ class TestCutMixMixUp:
         with pytest.raises(ValueError, match="Could not infer where the labels are"):
             cutmix_mixup({"img": imgs, "Nothing_else": 3})

-        with pytest.raises(ValueError, match="labels tensor should be of shape"):
+        with pytest.raises(ValueError, match="labels should be index based"):
             # Note: the error message isn't ideal, but that's because the label heuristic found the img as the label
             # It's OK, it's an edge-case. The important thing is that this fails loudly instead of passing silently
             cutmix_mixup(imgs)
@@ -2281,22 +2276,21 @@ class TestCutMixMixUp:
         with pytest.raises(ValueError, match="When using the default labels_getter"):
             cutmix_mixup(imgs, "not_a_tensor")

-        with pytest.raises(ValueError, match="labels tensor should be of shape"):
-            cutmix_mixup(imgs, torch.randint(0, 2, size=(2, 3)))
-
         with pytest.raises(ValueError, match="Expected a batched input with 4 dims"):
             cutmix_mixup(imgs[None, None], torch.randint(0, num_classes, size=(batch_size,)))

         with pytest.raises(ValueError, match="does not match the batch size of the labels"):
             cutmix_mixup(imgs, torch.randint(0, num_classes, size=(batch_size + 1,)))

-        with pytest.raises(ValueError, match="labels tensor should be of shape"):
-            # The purpose of this check is more about documenting the current
-            # behaviour of what happens on a Compose(), rather than actually
-            # asserting the expected behaviour. We may support Compose() in the
-            # future, e.g. for 2 consecutive CutMix?
-            labels = torch.randint(0, num_classes, size=(batch_size,))
-            transforms.Compose([cutmix_mixup, cutmix_mixup])(imgs, labels)
+        with pytest.raises(ValueError, match="When passing 2D labels"):
+            wrong_num_classes = num_classes + 1
+            T(alpha=0.5, num_classes=num_classes)(imgs, torch.randint(0, 2, size=(batch_size, wrong_num_classes)))
+
+        with pytest.raises(ValueError, match="but got a tensor of shape"):
+            cutmix_mixup(imgs, torch.randint(0, 2, size=(2, 3, 4)))
+
+        with pytest.raises(ValueError, match="num_classes must be passed"):
+            T(alpha=0.5)(imgs, torch.randint(0, num_classes, size=(batch_size,)))

 @pytest.mark.parametrize("key", ("labels", "LABELS", "LaBeL", "SOME_WEIRD_KEY_THAT_HAS_LABeL_IN_IT"))
diff --git a/torchvision/transforms/v2/_augment.py b/torchvision/transforms/v2/_augment.py
index 48daa271ea..1d01012654 100644
--- a/torchvision/transforms/v2/_augment.py
+++ b/torchvision/transforms/v2/_augment.py
@@ -1,7 +1,7 @@
 import math
 import numbers
 import warnings
-from typing import Any, Callable, Dict, List, Sequence, Tuple, Union
+from typing import Any, Callable, Dict, List, Optional, Sequence, Tuple, Union

 import PIL.Image
 import torch
@@ -142,7 +142,7 @@ class RandomErasing(_RandomApplyTransform):

 class _BaseMixUpCutMix(Transform):
-    def __init__(self, *, alpha: float = 1.0, num_classes: int, labels_getter="default", labels_encoded: bool = False) -> None:
+    def __init__(self, *, alpha: float = 1.0, num_classes: Optional[int] = None, labels_getter="default") -> None:
         super().__init__()
         self.alpha = float(alpha)
         self._dist = torch.distributions.Beta(torch.tensor([alpha]), torch.tensor([alpha]))
@@ -150,7 +150,6 @@ class _BaseMixUpCutMix(Transform):
         self.num_classes = num_classes

         self._labels_getter = _parse_labels_getter(labels_getter)
-        self._labels_encoded = labels_encoded

     def forward(self, *inputs):
         inputs = inputs if len(inputs) > 1 else inputs[0]
@@ -163,10 +162,21 @@ class _BaseMixUpCutMix(Transform):
         labels = self._labels_getter(inputs)
         if not isinstance(labels, torch.Tensor):
             raise ValueError(f"The labels must be a tensor, but got {type(labels)} instead.")
-        elif not 0 < labels.ndim <= 2 or (labels.ndim == 2 and labels.shape[1] != self.num_classes):
+        if labels.ndim not in (1, 2):
             raise ValueError(
-                f"labels tensor should be of shape (batch_size,) or (batch_size,num_classes) " f"but got shape {labels.shape} instead."
+                f"labels should be index based with shape (batch_size,) "
+                f"or probability based with shape (batch_size, num_classes), "
+                f"but got a tensor of shape {labels.shape} instead."
             )
+        if labels.ndim == 2 and self.num_classes is not None and labels.shape[-1] != self.num_classes:
+            raise ValueError(
+                f"When passing 2D labels, "
+                f"the number of elements in last dimension must match num_classes: "
+                f"{labels.shape[-1]} != {self.num_classes}. "
+                f"You can Leave num_classes to None."
+            )
+        if labels.ndim == 1 and self.num_classes is None:
+            raise ValueError("num_classes must be passed if the labels are index-based (1D)")

         params = {
             "labels": labels,
@@ -225,7 +235,8 @@ class MixUp(_BaseMixUpCutMix):

     Args:
         alpha (float, optional): hyperparameter of the Beta distribution used for mixup. Default is 1.
-        num_classes (int): number of classes in the batch. Used for one-hot-encoding.
+        num_classes (int, optional): number of classes in the batch. Used for one-hot-encoding.
+            Can be None only if the labels are already one-hot-encoded.
         labels_getter (callable or "default", optional): indicates how to identify the labels in the input.
             By default, this will pick the second parameter as the labels if it's a tensor. This covers the most
             common scenario where this transform is called as ``MixUp()(imgs_batch, labels_batch)``.
@@ -273,7 +284,8 @@ class CutMix(_BaseMixUpCutMix):

     Args:
         alpha (float, optional): hyperparameter of the Beta distribution used for mixup. Default is 1.
-        num_classes (int): number of classes in the batch. Used for one-hot-encoding.
+        num_classes (int, optional): number of classes in the batch. Used for one-hot-encoding.
+            Can be None only if the labels are already one-hot-encoded.
         labels_getter (callable or "default", optional): indicates how to identify the labels in the input.
             By default, this will pick the second parameter as the labels if it's a tensor. This covers the most
             common scenario where this transform is called as ``CutMix()(imgs_batch, labels_batch)``.

Hi @NicolasHug, that's diff applied!
Hope you have a great weekend.
Mahdi

Thank you @mahdilamb
Before I can merge, do you mind fixing this one linting issue:
  torchvision/transforms/v2/_augment.py:213: error: Argument "num_classes" to
  "one_hot" has incompatible type "Optional[int]"; expected "int"  [arg-type]
                  label = one_hot(label, num_classes=self.num_classes)
                                                     ^~~~~~~~~~~~~~~~
  Found 1 error in 1 file (checked 235 source files)

I think adding a simple # type: ignore[arg-type] comment will be enough - mypy is just not undersanding that self.num_classes can't be None at that point, so we should just silence it.
Thanks!

@NicolasHug, made the change, but if it fails will look into it properly. Also added you as a collaborator on the fork so you can mess about!

Thank you @mahdilamb !


Door status

I want to get door status (Open/Close), how can i get this?

You might need another sensor for that. Maybe something like?: https://arduinogetstarted.com/tutorials/arduino-door-sensor
I think the access controller only unlocks/locks the latch via the relay (and only for a set amount of time). So, you can track whether you told the relay to open/close, but it probably won't know whether the door is actually within the latch.

The RFID board have the door contact.


Comparison with cs3org/charts

What is the difference between this repo and https://github.com/cs3org/charts ?

Mentioned in https://github.com/cs3org/charts/issues/38#issuecomment-1210621389. More information can be found in the Section 4: Reference Deployment of the IOP paper

@SamuAlfageme thanks!
CC @navid-dada


Automated cherry pick of #10633: fix: private cloud sku attached disk count

Cherry pick of #10633 on release/3.5.
#10633: fix: private cloud sku attached disk count

Codecov Report

Merging #10636 (8436ed3) into release/3.5 (6a15e02) will decrease coverage by 1.80%.
The diff coverage is 0.41%.

@@               Coverage Diff                @@
##           release/3.5   #10636       +/-   ##
================================================
- Coverage         5.98%    4.18%    -1.81%
================================================
  Files              796      164      -632
  Lines           125693    25208   -100485
================================================
- Hits              7522     1054     -6468
+ Misses          117504    24062    -93442
+ Partials           667       92      -575

Flag
Coverage Δ

aFlag
4.18% <0.41%> (-1.81%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/jointbase.go
0.00% <ø> (ø)

pkg/cloudcommon/db/metadata.go
5.04% <0.00%> (ø)

pkg/cloudcommon/db/opslog.go
1.36% <0.00%> (-0.01%)
:arrow_down:

pkg/cloudcommon/db/rbac.go
0.75% <0.00%> (-0.03%)
:arrow_down:

pkg/cloudcommon/db/sharablebase.go
6.01% <0.00%> (-0.06%)
:arrow_down:

pkg/cloudprovider/cloudprovider.go
0.72% <ø> (+0.01%)
:arrow_up:

pkg/cloudprovider/instance.go
0.00% <ø> (ø)

pkg/cloudprovider/objectstore.go
2.11% <0.00%> (-0.46%)
:arrow_down:

pkg/cloudprovider/route_table.go
0.00% <0.00%> (ø)

pkg/cloudprovider/securitygroup.go
0.00% <0.00%> (ø)

... and 560 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4056dfa...8436ed3. Read the comment docs.


README.md - Use of LinterCop.json in pipeline

Just a small addition to README.md, telling where to put the LinterCop.json file if you need it inside a pipeline.
More details found in #263

Hey @StefanMaron,
I cannot add reviewers - maybe you might be able to review this?


Order of auth methods for 250-AUTH EHLO Response

Should EHLO 250-AUTH response have PLAIN and LOGIN first?
I was having trouble getting Authelia to use mox as its submissions server for a notification service.
I kept getting this error when trying to use mox: error="failed to dial connection: SMTP AUTH failed: unsupported SMTP AUTH types: ", however it worked when I used gmail.
I had a look at the responses of both gmail and mox and it seems that gmail returns LOGIN and PLAIN before the others:
Response from gmail:
220 smtp.gmail.com ESMTP 41be03b00d2f7-7e6db292aafsm8896834a12.14 - gsmtp
EHLO localhost
250-smtp.gmail.com at your service, [<IP_ADDRESS>]
250-SIZE 35882577
250-8BITMIME
250-AUTH LOGIN PLAIN XOAUTH2 PLAIN-CLIENTTOKEN OAUTHBEARER XOAUTH
250-ENHANCEDSTATUSCODES
250-PIPELINING
250-CHUNKING
250 SMTPUTF8

Response from mox v0.0.11
220 my.domain.com ESMTP mox v0.0.11
EHLO localhost
250-my.domain.com
250-PIPELINING
250-SIZE 104857600
250-REQUIRETLS
250-AUTH SCRAM-SHA-256-PLUS SCRAM-SHA-256 SCRAM-SHA-1-PLUS SCRAM-SHA-1 CRAM-MD5 PLAIN LOGIN
250-FUTURERELEASE 5184000 2024-11-30T23:25:13Z
250-ENHANCEDSTATUSCODES
250-8BITMIME
250-LIMITS RCPTMAX=1000
250 SMTPUTF8

After building a dev mox, and placing PLAIN and LOGIN before the others, Authelia worked.
This line:
https://github.com/mjl-/mox/blob/b0c4b090102cfdcb3a2ef112fc3f4487ec21ea40/smtpserver/server.go#L906
diff --git a/smtpserver/server.go b/smtpserver/server.go
index 38fa205..575edc8 100644
--- a/smtpserver/server.go
+++ b/smtpserver/server.go
@@ -899,7 +899,7 @@ func (c *conn) cmdHello(p *parser, ehlo bool) {
                        // authentication. The client should select the bare variant when TLS isn't
                        // present, and also not indicate the server supports the PLUS variant in that
                        // case, or it would trigger the mechanism downgrade detection.
-                       c.bwritelinef("250-AUTH SCRAM-SHA-256-PLUS SCRAM-SHA-256 SCRAM-SHA-1-PLUS SCRAM-SHA-1 CRAM-MD5 PLAIN LOGIN")
+                       c.bwritelinef("250-AUTH PLAIN LOGIN SCRAM-SHA-256-PLUS SCRAM-SHA-256 SCRAM-SHA-1-PLUS SCRAM-SHA-1 CRAM-MD5")
                } else {
                        c.bwritelinef("250-AUTH ")
                }

This reponse from mox resulted in successful login by Authelia:
220 my.domain.com ESMTP mox (devel)
EHLO localhost
250-my.domain.com
250-PIPELINING
250-SIZE 104857600
250-REQUIRETLS
250-AUTH PLAIN LOGIN SCRAM-SHA-256-PLUS SCRAM-SHA-256 SCRAM-SHA-1-PLUS SCRAM-SHA-1 CRAM-MD5
250-FUTURERELEASE 5184000 2024-12-01T00:47:52Z
250-ENHANCEDSTATUSCODES
250-8BITMIME
250-LIMITS RCPTMAX=1000
250 SMTPUTF8

I'm not sure if I should raise this with mox or Authelia, and I dont know the spec of how these auth options should be ordered, so if this is fully within spec I can raise this with Authelia instead.

go-mail dev here. I know that Authelia uses go-mail under the hood and I recognize that error message from our auth modules. Turns out this issue is actually related to go-mail.
It has nothing to do with the order of the supported methods, this is just a coincident. It has to do with the LOGIN auth mechanism specificly and how we handle it. The PLAIN auth should work fine and you should be able to verify that in your installation - I believe Authelia has a config option for that.
The issue is, that in go-mail we expect the server to respond with a base64 encoded representation of either "Username:", "username:" or "User name\x00". I believe there is no formal IETF RFC for "AUTH LOGIN", but there is draft. Mox does not reply with the base64 encoded representation of "Username:" but just responds with an empty 334. Since go-mail expects a different response, it will reject the authentication try with the error message you are seeing.
I suggest that Mox follows this approach. Unless of course @mjl- has a valid point to not do so- in that case I'd be happy to adept mox's behaviour in go-mail.
For refernece, I've checked some mail server implementations/popular mail services and it looks like the common agreement is to send the 334 with the "Username:" in the response:
Postfix:
250-AUTH=LOGIN PLAIN
250-ENHANCEDSTATUSCODES
250-8BITMIME
250 DSN
AUTH LOGIN
334 VXNlcm5hbWU6

Dovecot:
250-AUTH LOGIN PLAIN SCRAM-SHA-1 SCRAM-SHA-256
250-ENHANCEDSTATUSCODES
250-SIZE
250 PIPELINING
AUTH LOGIN
334 VXNlcm5hbWU6

Google:
250-AUTH LOGIN PLAIN XOAUTH2 PLAIN-CLIENTTOKEN OAUTHBEARER XOAUTH
250-ENHANCEDSTATUSCODES
250-PIPELINING
250-CHUNKING
250 SMTPUTF8
AUTH LOGIN
334 VXNlcm5hbWU6

Zoho mail:
250-AUTH LOGIN PLAIN
250 SIZE 53477376
AUTH LOGIN
334 VXNlcm5hbWU6

Yahoo mail:
250 AUTH PLAIN LOGIN XOAUTH2 OAUTHBEARER
AUTH LOGIN
334 VXNlcm5hbWU6

iCloud mail:
250-AUTH LOGIN PLAIN ATOKEN ATOKEN2 WSTOKEN WETOKEN XOAUTH2
250-ENHANCEDSTATUSCODES
250-8BITMIME
250-DSN
250-SMTPUTF8
250 CHUNKING
AUTH LOGIN
334 VXNlcm5hbWU6

Additional note: While writing a test to adept this behaviour in go-mail, I just noticed that mox, on the second response, answers with "Password". Commonly servers respond with "Password:", "password:" or "Password\x00". Maybe also something to consider here.
Side note: in the next release go-mail will support SCRAM-SHA, so this will become a no-brainer for Authela ;)

Last side note (I promise): After reading the draft again (especially https://datatracker.ietf.org/doc/html/draft-murchison-sasl-login-00#section-2.1 and https://datatracker.ietf.org/doc/html/draft-murchison-sasl-login-00#section-2.2) I see that it's vage as usual... The clients "SHOULD" ignore any server response (which go-mail does not do) but then again the server "MAY" send responses following one widely deployed client which requires that the challenge strings transmitted by the server be "Username:" and "Password:" respectively
I'll file an issue for go-mail to address the "SHOULD" part in #2.1 but still it might be advisable to follow the common behaviour for mox to follow.

Ill update the title of this issue to be clearer

Created: https://github.com/wneessen/go-mail/issues/311

This was resolved in aead73883601ecb259e7a27d834bcbaf8e4af07a
https://github.com/mjl-/mox/commit/aead73883601ecb259e7a27d834bcbaf8e4af07a#diff-0d8b40a06936984b2af0c9839ccdc0e3f3c7e0ce0896b6bb85b2cea56de879a5R1026

Thanks for the report & analysis! I changed mox to write the "Username:" and "Password:" challenges. Closer to what others services are doing, the internet-draft is just a draft (and it says essentially anything goes). Should improve interoperability.


Mail is not sent from an Ace command

Package version
5.2.3
Node.js and npm version
Node.js: v14.16.1
Npm: 6.14.12
Sample Code (to reproduce the issue)
import { BaseCommand } from '@adonisjs/core/build/standalone'
import Mail from '@ioc:Adonis/Addons/Mail'

export default class SendMail extends BaseCommand {

	/**
	 * Command Name is used to run the command
	 */
  public static commandName = 'send:mail'

	/**
	 * Command Name is displayed in the "help" output
	 */
  public static description = ''

  public static settings = {
    loadApp: true,
  }

  public async run () {
    this.logger.info('Hello world!')
    await Mail.sendLater((message) => {
     try {
          await Mail.sendLater((message) => {
            message
<EMAIL_ADDRESS><EMAIL_ADDRESS>              .subject('Votre offre arrive à expiration : ')
              .text('Hello World')
          })
        } catch(error) {
          console.log(error)
        }
  }
}

I get no errors, but the mail si not sent (I use mailtrap but it works when I send one throug an HTTP Controller).
And the offer title is correctly printed on my console.

I get no errors, but the mail si not sent (I use mailtrap but it works when I send one throug an HTTP Controller).
And the offer title is correctly printed on my console.

Someone helped me with this. I had to replace sendLater with send in order to make it work. 👍🏻

Does anyone know why this error occurs with sendLater?

Does anyone know why this error occurs with sendLater?

The sendLater command implies that your mail will be queued in memory and sent later. An Ace command is a short-lived script. The command ends and therefore cleans the process memory before the mail is sent.
There's no reason to use sendLater in an Ace command since it is not dealing with HTTP.
From the documentation:

This ensures that the email is sent in the background and doesn't block the ongoing HTTP request


File Upload Component

Issue #56
Added FileUpload component and corresponding construct.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Could you run pnpm changeset in the root of the GB repo and create a minor change for both ui and infra?


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/1042 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 549584c:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_main_2022-02-16-06-04-52 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fix case sensitive directory name for chromium zip

Description
For chromium zip, changes the opensearch-dashboards name to be lowercase to account for case-sensitivity in Linux.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

can you also include the osd-version renaming fix in this PR?

Also, this PR should be submitted to dev branch

Also, this PR should be submitted to dev branch

Changed base- will also include osd version fix


Make maximum database connections configurable

The number of allowable database connections can be a bottleneck in how quickly API tasks are processed, so the pooling options should be configurable to a degree.

Is this referring to Postgres, Redis, or both?


MODLD-442: Properties used for fingerprint are not sorted - Results i…

…n random fingerprint for a resource

I've used BeanPostProcessor in the fingerprint module to enable FingerprintEntrySerializer so that here we don't need to modify the ObjectMapperConfig.


Can't see that a code cell is collapsed

Testing #141222.
When a code cell as a first line that causes a horizontal scrollbar and you collapse the cell, there is no visual indication anymore that the cell is collapsed.

Isn't it enough that you don't have the editor border/background color? If you hover, you will get a tooltip hint to double click. What else do you want to see?

For reference - narrower cells get the ... button

We could

Make sure the ... is always visible - it would float to the right side
Show some other decoration, icon, or color to indicate that a cell is collapsed

Yeah, but the alternative is adding more space between cells which I also don't want to do


"Invalid number of params for this command" is too technical

Can we replace the text "Invalid number of params for this command" with something more clear and intuitive to all users?

This could be replaced with something like "One or more fields is missing to run the command. Please run /servicenow help for more information"

This issue is fixed in the latest release v2.3.1. Please confirm and close this issue. @DHaussermann

Thanks @ayusht2810 confirmed fixed on 2.3.1.
Closing.


rusty_secrets::sss::generate_shares returns Strings?

Appears rusty_secrets::sss::generate_shares returns Result<Vec<String>>, which sounds odd for ciphertext.  In fact, collections::string::String says "Strings are always valid UTF-8. This has a few implications, the first of which is that if you need a non-UTF-8 string, consider OsString. It is similar, but without the UTF-8 constraint."  I suppose your encoding via protobuf makes all that fine though and you mean to send this over text channels anyways?

Hey @burdges!
Thanks for looking into RustySecrets.
The reason it was done this way is because in the context of an application that relies on RustySecrets we wanted to return shares in the format described in the README.
I guess you're right that in the sss module we could return data and leave it to library consumers to choose how to deal with that.

Cool.  I'll close this since it sounds like everything makes sense.


ReferenceError: last is not defined, it conflicts with lodash last

After introducing vite-plugin-node-polyfills  , it conflicts with  lodash last

Hi @laterdayi. 👋 Would you mind adding a StackBlitz or CodeSandbox reproduction of this issue for me to debug? Thanks!


Redirecting error while running on prefix

Describe the bug
Missing slash in bookstack homepage address
Steps To Reproduce
Steps to reproduce the behavior:

Install bookstack on domain prefix (eg.: https://example.com/bookstack/)
Try to login
You will be redirected not to https://example.com/bookstack/ but to https://example.com/bookstack
(Same problem found when I want to go back from settings to homepage by clicking to top left button)

Expected behavior
Login OK, I'm redirected to homepage
Your Configuration (please complete the following information):

Exact BookStack Version (Found in settings): v0.27.4
PHP Version: 7.0.33
Hosting Method (Nginx/Apache/Docker):  Apache behind Apache reverse proxy

Since the last comment on this issue is relatively old I'm going to close this. If the issue remains and is something you still require to be fixed please open a new issue, referencing this one.


Make a Duster GitHub action

That way users wouldn't have to composer install in their GitHub Actions just to get the config files out of this repo.

Solved by: https://github.com/tighten/duster-action


Cross Compiling mediapipe on Ubuntu

OS Platform and Distribution
Ubuntu 22.04.2 LTS
Compiler version
gcc 11.4.0
Programming Language and version

Installed using virtualenv? pip? Conda?(if python)
No response
MediaPipe version
current
Bazel version
6.3.2
XCode and Tulsi versions (if iOS)
No response
Android SDK and NDK versions (if android)
No response
Android AAR (if android)
None
OpenCV version (if running on desktop)
No response
Describe the problem
A bug happened!
Complete Logs
root@c339f15c76d1:/mediapipe# pwd
/mediapipe
root@c339f15c76d1:/mediapipe# bazel build \
>     --crosstool_top=@crosstool//:toolchains \
>     --compiler=gcc \
>     --cpu=aarch64 \
>     --define darwinn_portable=1 \
  --defi>     --define MEDIAPIPE_DISABLE_GPU=1 \
>     --define MEDIAPIPE_EDGE_TPU=usb \
>     --linkopt=-l:libusb-1.0.so \
>     mediapipe/examples/coral:face_detection_tpu build
2023/10/17 15:01:23 Downloading https://releases.bazel.build/6.1.1/release/bazel-6.1.1-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
WARNING: Download from http://mirror.tensorflow.org/github.com/bazelbuild/rules_closure/archive/cf1e44edb908e9616030cc83d085989b8e6cd6df.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/tensorflow/runtime/archive/dcffa4094e13d56a30b2cdcdb709ce5d71b38953.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/1c154bd755153b5c6ada4bbed58facf23f6abffc.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_absl' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_benchmark' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'flatbuffers' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'pybind11_bazel' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_googlesource_code_re2' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_protobuf' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_googletest' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_github_gflags_gflags' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'zlib' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'build_bazel_rules_apple' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'build_bazel_rules_swift' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'build_bazel_apple_support' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'xctestrunner' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'pybind11' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'pybind11_protobuf' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_github_glog_glog' because it already exists.
ERROR: Skipping 'build': no such target '//:build': target 'build' not declared in package '' defined by /mediapipe/BUILD.bazel (Tip: use `query "//:*"` to see all the targets in that package)
WARNING: Target pattern parsing failed.
ERROR: no such target '//:build': target 'build' not declared in package '' defined by /mediapipe/BUILD.bazel (Tip: use `query "//:*"` to see all the targets in that package)
INFO: Elapsed time: 78.435s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (2 packages loaded)
root@c339f15c76d1:/mediapipe#

Hi @phil-fill , could you share how you managed to solve this problem?

OS Platform and Distribution
Ubuntu 22.04.2 LTS
Compiler version
gcc 11.4.0
Programming Language and version
Installed using virtualenv? pip? Conda?(if python)
No response
MediaPipe version
current
Bazel version
6.3.2
XCode and Tulsi versions (if iOS)
No response
Android SDK and NDK versions (if android)
No response
Android AAR (if android)
None
OpenCV version (if running on desktop)
No response
Describe the problem
A bug happened!
Complete Logs
root@c339f15c76d1:/mediapipe# pwd
/mediapipe
root@c339f15c76d1:/mediapipe# bazel build \
>     --crosstool_top=@crosstool//:toolchains \
>     --compiler=gcc \
>     --cpu=aarch64 \
>     --define darwinn_portable=1 \
  --defi>     --define MEDIAPIPE_DISABLE_GPU=1 \
>     --define MEDIAPIPE_EDGE_TPU=usb \
>     --linkopt=-l:libusb-1.0.so \
>     mediapipe/examples/coral:face_detection_tpu build
2023/10/17 15:01:23 Downloading https://releases.bazel.build/6.1.1/release/bazel-6.1.1-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
WARNING: Download from http://mirror.tensorflow.org/github.com/bazelbuild/rules_closure/archive/cf1e44edb908e9616030cc83d085989b8e6cd6df.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/tensorflow/runtime/archive/dcffa4094e13d56a30b2cdcdb709ce5d71b38953.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/1c154bd755153b5c6ada4bbed58facf23f6abffc.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_absl' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_benchmark' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'flatbuffers' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'pybind11_bazel' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_googlesource_code_re2' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_protobuf' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_googletest' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_github_gflags_gflags' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'zlib' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'build_bazel_rules_apple' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'build_bazel_rules_swift' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'build_bazel_apple_support' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'xctestrunner' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'pybind11' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'pybind11_protobuf' because it already exists.
DEBUG: /root/.cache/bazel/_bazel_root/4884d566396e9b67b62185751879ad14/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_github_glog_glog' because it already exists.
ERROR: Skipping 'build': no such target '//:build': target 'build' not declared in package '' defined by /mediapipe/BUILD.bazel (Tip: use `query "//:*"` to see all the targets in that package)
WARNING: Target pattern parsing failed.
ERROR: no such target '//:build': target 'build' not declared in package '' defined by /mediapipe/BUILD.bazel (Tip: use `query "//:*"` to see all the targets in that package)
INFO: Elapsed time: 78.435s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (2 packages loaded)
root@c339f15c76d1:/mediapipe#

Hi @phil-fill , could you share how you managed to solve this problem?I have the same problem with this issue。
https://github.com/google-ai-edge/mediapipe/issues/5625


Clarify whether attribution is required

As I see it, the most confusing part of the MIT license as it applies to this project, is this line:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

So what counts as copies or substantial portions? Suppose you take a few icons and add them to a webpage. It appears, then, that attribution is required. But what kind of attribution? On the page, or in the code? Is the software just the code, or also the rendered icons?
I think it's for this reason that most open fonts use the SIL Open Font License, including Font Awesome, though Font Awesome no longer requires attribution.
I believe the MIT license could hold some people back from using the icons, even in ways that the author would deem acceptable, simply due to ambiguity of the license. Personally, I would favor an attribution-not-required license, simply because it's not nice to have to make sure you have attribution if you just copy an icon or two into a page (attribution in the source code is a different matter; I don't really have an opinion).
Very nice icons by the way. I really love being able to copy a couple lines instead of adding a dependency.

@Nateowami Good points. While this project will remain under the MIT license for now, attribution is encouraged but not required.
I added a line to the README to clarify.

@danklammer Thanks. That's a helpful change.

@danklammer I think I have a solution to the licensing conundrum here. 0BSD. With Zero Clause BSD those using your software can omit the license and choose to attribute if they like (not a requirement of the current license anyway).

FYI https://github.com/edent/SuperTinyIcons/issues/214

While this project will remain under the MIT license for now, attribution is encouraged but not required.

That's thoughtful, but not legally binding. My suggestion would be to change to an unconditional license such as the 0BSD or Unlicense.


Standardize & automate Ensemble Modules

As an Ensemble user, I want to easily include and exclude sensitive capabilities from my app so I can build fast without triggering app reviews.
As an Ensemble customer, I want to contribute new capabilities to Ensemble without impacting the core framework.
As an Ensemble owner, I want to add premium development features in a modular fashion.
Background
Currently we break up sensitive capabilities into different flutter packages and dynamically inject them into Ensemble projects as needed. This is a very manual and painful process, and is not well defined or apparent in code how it works.
Acceptance Criteria

Define an interface for an Ensemble module entry point
Create an object to manage the lifecycle of Ensemble modules based on the interface
Create a build script to automate the generation of dev and config files (e.g. info.plist) based on included modules

@kmahmood74 @vusters @amin-nas

@snehmehta has been working on it with @vusters and I believe most if not all of it has been done. The #865 is part of it as well. @snehmehta please close this if done or dup of other work


Document is not defined.

Hitting this error while trying to use your library:
ReferenceError: document is not defined
at Object.testTree [as default] (node_modules/react-test-tree/lib/testTree.js:14:19)
at Context. (test/InfiniteScroller.js:88:19)
I didn't see jsdom being referenced anywhere. Is it necessary to have the DOM for this module to work?

Hi, yes it is necessary to have a DOM. If you are testing in Node then you will need to run something like jsdom. This is due to React itself, not test-tree. Even React's own test utilities require you to have a DOM in order to render in tests: https://facebook.github.io/react/docs/test-utils.html
I will add a note to the readme