Get coordinates or visualize the most activated voxels from Sybil’s attention scores

This is a great tool to estimate lung cancer risk. In the appendix to the paper describing Sybil, it is mentioned that the authors measured Sybil’s ability to localize a cancerous nodule on an LDCT. To do it, the most activated voxel from Sybil’s attention scores were selected. Would it be possible to indicate which section of the code lists which voxels were the most activated in the input image or was an external tool used?

Hi,
Thanks for reaching out!
The localization results were meant for analysis rather than real-time use, so this repo doesn't include a way to directly obtain those attention scores since it's main purpose is deploying and integrating the model in clinical workflows. However, it is possible to extract the attentions with a little bit of coding.
Specifically, the output of the SybilNet model contains the attention scores. The output is a dictionary and contains the keys image_attention_1 and volume_attention_1 which correspond to (1) an attention learned over the 2D space for all slices in a CT and (2) an attention learned over the slices (the z-axis, i.e., how much to weigh each slice), respectively. Together, they can be used to measure the attention over the full 3D volume. Of note, these scores are returned as log-values in the code, so you would exponentiate them (torch.exp) to get the scores as values between 0 and 1. In the CLI Sybil model (i.e., from sybil import Sybil), the output dictionary can also be extracted from this line.
Hope this helps!

Thank you, @pgmikhael. I tried this other idea too:
This line seems to store the result of the ResNet part of Sybil into the "activ" key of the output dictionary (I noticed it has 512 channels or features). This other line seems to store what I interpreted as the weight given to each channel/feature into the "hidden" key of output (I observed output["hidden"] is a vector with 512 values).
Do you think it would be valid to just do a weighted sum of "activ" and "hidden" to find the voxels that were the most activated?

Hi,
These represent the volume itself in a projected space rather a weighting of it. The activ are learned features from the ResNet and the hidden are pooled features of the entire volume itself. So I think you would still want to use the image and volume attentions if you want to look at how the different parts of the CT are weighted.

Thank you for the explanation.


[BUG] service bus sometimes crashes with ClassCastException

Describe the bug
Snippet from ServiceBusMessage.java
    public OffsetDateTime getScheduledEnqueueTime() {
        Object value = amqpAnnotatedMessage.getMessageAnnotations().get(SCHEDULED_ENQUEUE_UTC_TIME_NAME.getValue());
        return value != null
            ? ((OffsetDateTime) value).toInstant().atOffset(ZoneOffset.UTC)
            : null;
    }

The OffsetDateTime cast is not safe.
Exception or Stack Trace
com.azure.messaging.servicebus.ServiceBusException: class java.util.Date cannot be cast to class java.time.OffsetDateTime (java.util.Date and java.time.OffsetDateTime are in module java.base of loader 'bootstrap')
	at com.azure.messaging.servicebus.ServiceBusSenderAsyncClient.mapError(ServiceBusSenderAsyncClient.java:914)
	at reactor.core.publisher.Mono.lambda$onErrorMap$31(Mono.java:3811)
	at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:94)
	at reactor.core.publisher.MonoFlatMap$FlatMapMain.secondError(MonoFlatMap.java:192)
	at reactor.core.publisher.MonoFlatMap$FlatMapInner.onError(MonoFlatMap.java:259)
	at reactor.core.publisher.MonoFlatMap$FlatMapMain.onError(MonoFlatMap.java:172)
	at reactor.core.publisher.MonoFlatMap$FlatMapMain.secondError(MonoFlatMap.java:192)
	at reactor.core.publisher.MonoFlatMap$FlatMapInner.onError(MonoFlatMap.java:259)
	at reactor.core.publisher.MonoStreamCollector$StreamCollectorSubscriber.onError(MonoStreamCollector.java:150)
	at reactor.core.publisher.MonoStreamCollector$StreamCollectorSubscriber.onNext(MonoStreamCollector.java:137)
	at reactor.core.publisher.Operators$ScalarSubscription.request(Operators.java:2400)
	at reactor.core.publisher.MonoStreamCollector$StreamCollectorSubscriber.onSubscribe(MonoStreamCollector.java:121)
	at reactor.core.publisher.FluxJust.subscribe(FluxJust.java:68)
	at reactor.core.publisher.MonoFromFluxOperator.subscribe(MonoFromFluxOperator.java:81)
	at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:157)
	at reactor.core.publisher.Operators$ScalarSubscription.request(Operators.java:2400)
	at reactor.core.publisher.MonoFlatMap$FlatMapMain.onSubscribe(MonoFlatMap.java:110)
	at reactor.core.publisher.MonoJust.subscribe(MonoJust.java:55)
	at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
	at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
	at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:157)
	at reactor.core.publisher.MonoPeekTerminal$MonoTerminalPeekSubscriber.onNext(MonoPeekTerminal.java:180)
	at reactor.core.publisher.SerializedSubscriber.onNext(SerializedSubscriber.java:99)
	at reactor.core.publisher.FluxRetryWhen$RetryWhenMainSubscriber.onNext(FluxRetryWhen.java:174)
	at reactor.core.publisher.SerializedSubscriber.onNext(SerializedSubscriber.java:99)
	at reactor.core.publisher.FluxTimeout$TimeoutMainSubscriber.onNext(FluxTimeout.java:180)
	at reactor.core.publisher.FluxPeekFuseable$PeekFuseableSubscriber.onNext(FluxPeekFuseable.java:210)
...

To Reproduce
Unsure why this happens, but our pod sometimes crashes with this.
Code Snippet
this happens in the library.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: Kubernetes/Linux
IDE: IntelliJ
Library/Libraries: "com.azure" % "azure-messaging-servicebus" % "7.17.0",
Java version: 21
App Server/Environment: Kubernetes
Frameworks: cats-effect, Scala

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

Thank you for reporting this @hamnis!
Could you please provide a few more details:

do you know which clients are used to send messages to the Service Bus? Their languages/SDKs/versions?
is it something that started happening recently, e.g. on a specific version of ServiceBus SDK, or did it happen previously?

Thanks!

Thank you for reporting this @hamnis!
Could you please provide a few more details:
* do you know which clients are used to send messages to the Service Bus? Their languages/SDKs/versions?

I think it's some f# thing, but I am not sure.

* is it something that started happening recently, e.g. on a specific version of ServiceBus SDK, or did it happen previously?

We upgrade all libraries every week, and this has been crashing multiple times per day for some time, but with different reasons.

@hamnis
I believe I have a fix in the #40642 . Could you please confirm my assumption about your application:

first schedules a message to be sent to a service bus queue/topic
then receives the message (in the java service that crashes with cast exception)
uses this received message to create a new ServiceBusMessage
sends this message to a different servicebus entity

Is this right?
If my assumption is correct, you should be able to workaround this issue (until the fix is released) by removing the value under SCHEDULED_ENQUEUE_UTC_TIME_NAME message property with the following code:
ServiceBusMessage messageToSend = new ServiceBusMessage(receivedMessage);
messageToSend .getRawAmqpMessage().getMessageAnnotations().remove(AmqpMessageConstant.SCHEDULED_ENQUEUE_UTC_TIME_NAME.getValue());


Added Windows Support

We've been running a fork with this added code for 6 months on both linux and windows. Chef clients have upgraded as expected every time.
Due to the latest updates from HW I reforked this repo and reapplied my changes so as to not conflict with the recent updates.

This should take care of pull requests #57, #67, and #88 as well as issue #32

Thanks for the updated PR!

:+1:

I did a quick review of the commit and it looks solid. Would be awesome to have this merged and pushed to Supermarket soon!

I'd like to run these through test-kitchen, and add windows as a platform in the .kitchen.yml
The setup is a little involved, so I'll do it as soon as I have a free hour or two. If someone beats me to it, all the better.

@luckymike  Fair enough! Test Kitchen in Windows IS a little more involved but I've got some local vagrant / test kitchen action so I'll try and run this ASAP myself as well. I'll report back if I can get it done. Cheers!

Yeah I'm fairly new to chef and ruby and haven't fully figured out test kitchen especially in windows yet. I usually test by knifing a new server aws against my dev account then work out the kinks and publish to our production chef-server when ready.

I was able to run the current test suites to confirm no regressions to tested resources. I added what should be an equivalent windows platform and the converge failed:
https://gist.github.com/luckymike/814b66f4b470990dbbff
@Stromweld are you setting any additional attributes via a role, wrapper cookbook, or environment in your working setup? Do you have anything configured in your client.rb that might result in non-default behavior in the Chef run?

we do have some attributes set in a base wrapper cookbook that we use for all windows machines and we set:
node.default['omnibus_updater']['prevent_downgrade'] = true
node.default['omnibus_updater']['force_latest'] = true
node.default['omnibus_updater']['restart_chef_service'] = true
Looking at the code I'm not totally sure why ours works though. Looking at your gist a simple fix for the windows_package resource would be to change remote_path variable to File.join(node[:omnibus_updater][:cache_dir], File.basename(remote_path)). I'm currently spinning up a VM and testing this cookbook without anything else in the runlist. If successful I'll commit the change to this PR.

Here is the fix in place. The below gist is the output from the chef-client runs. When the installer kicks off it does send SIGINT to the current running process chef throws an error about process exit. Subsequent chef-client run in the output you can see is the updated version of chef-client.
https://gist.github.com/Stromweld/4ee67970b0a567443f39

I'm still running into that error on every converge in test-kitchen. Which windows server version are you using, and have you been able to converge successfully the first time, or only after failing first?

I'm testing on Windows server 2012 r2. It always throws that error during the install step as the installer calls the current chef run to exit. I've been testing adding ignore_failure true to the Windows package as well and it'll let the chef client finish after the exit error but the client does get updated. It'd be like enabling the kill chef attribute that causes chef client to raise an exception and stop the current chef run after update. Just not sure how to get around that on Windows installer.

Looking at msiexec that is used to install the msi package I haven't found an option or anything that would cause it to suppress the sigint exit signal. When running chef-client as a service the run that updates the client throws the error but completes the install and then the next scheduled run is on the new client version and converges correctly.

This threw an error for me as well on Windows 7:
Recipe: omnibus_updater::installer
  * windows_package[Chef Client v12.7.2] action install

    ================================================================================
    Error executing action `install` on resource 'windows_package[Chef Client v12.7.2]'
    ================================================================================

    Mixlib::ShellOut::ShellCommandFailed
    ------------------------------------
    Expected process to exit with [0], but received '1603'
    ---- Begin output of msiexec /qn /i "c:\chef\cache\omnibus_updater\chef-client-12.7.2-1-x86.msi"  ----
    STDOUT:
    STDERR:
    ---- End output of msiexec /qn /i "c:\chef\cache\omnibus_updater\chef-client-12.7.2-1-x86.msi"  ----
    Ran msiexec /qn /i "c:\chef\cache\omnibus_updater\chef-client-12.7.2-1-x86.msi"  returned 1603

    Resource Declaration:
    ---------------------
    # In C:/chef/cache/cookbooks/omnibus_updater/recipes/installer.rb

     26:   windows_package "Chef Client v#{version}" do
     27:     source File.join(node[:omnibus_updater][:cache_dir], File.basename(remote_path))
     28:   end
     29: else

    Compiled Resource:
    ------------------
    # Declared in C:/chef/cache/cookbooks/omnibus_updater/recipes/installer.rb:26:in `from_file'

    windows_package("Chef Client v12.7.2") do
      action [:install]
      retries 0
      retry_delay 2
      default_guard_interpreter :default
      package_name "Chef Client v12.7.2"
      version "<IP_ADDRESS>"
      timeout 600
      source "c:\\chef\\cache\\omnibus_updater\\chef-client-12.7.2-1-x86.msi"
      returns [0]
      declared_type :windows_package
      cookbook_name "omnibus_updater"
      recipe_name "installer"
    end

Running handlers:
Running handlers complete
Chef Client failed. 2 resources updated in 01 minutes 20 seconds

What version of chef client did you have prior to chef trying to update it? I ran into the same issue when I ran this cookbook on a machine with chef 12.6.0. The msiexec program would uninstall chef but runs into access denied error trying to remove some files in c:\opscode\embeddded.... But in my testing 12.5.1 and 11.14.6 etc... have not had the issue. Googling I found there was a similar issue with the msi installer back in 2014 after MS released a patch. Later MS released another patch that fixed the issue.

@luckymike Have you had any better luck testing? Any suggestions for me on where to go from here?

Yea it was from 12.6.0

I've had the same error every single time. I haven't admined a Windows server since 2000, so I'm afraid I won't be much help in diagnosing how to adjust things for Windows.

So, if this is a known problem with upgrading a chef install from 12.6.0 to anything higher I'd say this is incomplete. It either needs to work everywhere or fail safely. In my case it left a broken local chef client install, which would be very annoying for anyone trying to this in production. We can't exactly have a cookbook that fails chef runs some of the time.
@Stromweld Any thoughts on why it fails based on what you've seen so far?

when manually running the chef client on the node and it hits the upgrade step I see a seperate command line box open up that executest the msiexec command for the install. While it's running you see it going through the uninstall process and gets access denied errors on several files under c:\opscode\embedded. Then it finishes up the uninstall step and throws the error and stops. Doesn't execute the install. I wouldn't say it's a chef or cookbook issue as I would either a windows or msi package issue. You can see this reference when this happened before due to a bad patch windows released. https://github.com/chef-cookbooks/windows/issues/130 later a subsequent windows patch release fixed it. I have verified the test systems I've been running are fully patched.

So far I have only found this particular issue only on clients with 12.6.0. I've tested a few other older clients with the upgrade and this hasn't been an issue. I'm thinking of looking at possibly running the installer inside a seperate powershell script to possibly get around this issue and the sigint exit command that's sent to chef client when an upgrade succeeds but stops chef from fully converging.

looking again at that issue I linked, codesilverback mentions "The chef bootstrapper uses a workaround of creating a scheduled task to run the installer, and that seems to work, but wow. What a hack!" and this cookbook is using that method as well, https://github.com/biola/chef-omnibus_updater_windows/blob/master/recipes/installer.rb. Could do it this way too.

ok this process has worked and fully converges without errors on first run for updating chef clients 11.14.6 and 12.5.1. Still have to test 12.6.0 and updating with service running.

Ok so this latest commit I have tested clients 11.14.6, 12.5.1 and confirmed working whether manual chef-client run or it's ran and updated as a service. No errors, etc... Very hacky though but keeps install process in the chef-client run instead of outside in a scheduled task etc...
Something is wrong with windows uninstaller for 12.6.0 though. No matter how I run uninstall it leaves locked files behind in c:\opscode\embedded\ and then the install step fails with 1603 error due to access being denied on those files. Tomorrow I'll try bootstrapping a fresh 12.6.0 node and test my updates to the cookbook some more.

Also added attribute to specify ADDLOCAL parameter to msiexec and set default to install chef-client and chef-client service with a comment recommending adding chef powershell modules for clients about 12.4.0.

For the life of me I have not been able to come up with a work around for the 12.6.0 upgrade. There is something really weird in windows with that version of chef installed. I've tried adding command line commands to remove the left over files after the uninstall step, I've tried changing permissions and ownership to be able to remove the files and all attempts for the past 2 days have resulted in access denied on the files during the chef client run and then the install of the updated client fails due to the files stuck there. I can manually browse to the files and remove them after the chef client run fails so I don't know what's going on. Files even throw access denied when I use the force flag with the delete command.
Testing with older version of the chef client older than 12.6.0 have worked fine though. @luckymike can you try your test kitchen test again?

Yes, I'll try the test kitchen run this afternoon, I hope. Can you open an issue with Chef about the 12.6.0 failures?

Yeah I'll open the issue with chef.

issue opened https://github.com/chef/chef/issues/4623 for the 12.6.0 update failure

:+1: Tested with default[:omnibus_updater][:version] = '12.5.1' and it worked!

Sweet. Anybody have any code comments and or suggestions? I'm still fairly new to ruby, chef, and programming in general so definitely open to feedback.

Confirmed no regressions as well :)

Anecdotal but your fork worked on a Windows Server 2008 node to upgrade from 11.12 to 12.5.1, only chef_client was installed and updated though, chef service is not installed on that node. I can test a number of other nodes if needed

Yeah that'd be great. The more testing the better.

Note, this passes the tests in #104

What do you guys think about getting this code merged to develop and adding a note in the readme about the 12.6.0 upgrade issue?

Yep, I'm leaning that direction.

What about a catch in the default.rb recipe to halt the cookbook if it detects 12.6.0 is installed? that way you don't bork your install if you don't read the documentation.
i think checking node['chef_packages']['chef']['version'] would be able to determine that.

@cpoole My concern with that approach is the longterm maintainability. We don't really have a way of knowing if this bug/issue will continue to exist with future versions. It may or may not be fixed in 12.6.1 or 12.7.0, etc, so that catch may or may not protect operators upgrading beyond 12.6.0. If we take a pessimistic view, and exit on >= 12.6.0, then we risk exiting with versions that don't have this issue.
Beyond noting known issues, we can't take responsibility for errors introduced by Chef. I'm happy to include a node in both the Changelog and the Read Me warning Windows users.
As this is the first introduction of Windows support in this cookbook, there shouldn't be anyone out there using this already who will be bit by a surprise.

It was mentioned that a specific patch fixed the issue? Has that been tested further?
If we know the kb number maybe it would be possible to query for it and provide a safeguard?
If kb_installed? && installed_chef_client_is_12.6.0
A query example is here:
https://github.com/criteo-cookbooks/ms_dotnet/blob/master/attributes/ms_dotnet4.rb
See the end of the attributes, around 4.5.2 attribute setting

In the past a specific kb patch introduced a similar error. We have to confirmed that is the case this time or what kb it may be. But I think instead of a catch for >= 12.6.0 a catch for == 12.6.0 is reasonable since the uninstall step will run otherwise and then the install may fail leaving a chef-client without chef installed. We don't however know if the issue still exists or not with 12.7.2 since there is nothing higher to upgrade to yet.

In case we do want to proceed with the catch, here is what it looks like in action. Not super graceful, but it works.
`[2016-03-01T19:27:47-08:00] INFO: *** Chef 12.6.0 ***
[2016-03-01T19:27:47-08:00] INFO: Chef-client pid: 15140
[2016-03-01T19:27:57-08:00] INFO: Run List is [role[role_bamboo], role[test_role]]
[2016-03-01T19:27:57-08:00] INFO: Run List expands to [omnibus_updater]
[2016-03-01T19:27:57-08:00] INFO: Starting Chef Run for
[2016-03-01T19:27:57-08:00] INFO: Running start handlers
[2016-03-01T19:27:57-08:00] INFO: Start handlers complete.
[2016-03-01T19:27:57-08:00] INFO: Loading cookbooks<EMAIL_ADDRESS>[2016-03-01T19:27:57-08:00] FATAL: Omnibus updater cannot upgrade or downgrade a Windows 12.6.0 installation

================================================================================
Recipe Compile Error in c:/chef-rm/cache/cookbooks/omnibus_updater/recipes/default.rb
================================================================================
RuntimeError
------------

Cookbook Trace:
---------------
c:/chef-rm/cache/cookbooks/omnibus_updater/recipes/default.rb:28:in `from_file'
Relevant File Content:
----------------------
c:/chef-rm/cache/cookbooks/omnibus_updater/recipes/default.rb:

 21:    Chef::Log.warn 'Omnibus updater disabled via disabled attribute'
 22:  elsif(node[:platform] == 'debian' && Gem::Version.new(node[:platform_version]) < Gem::Version.new('6.0.0'))
 23:    Chef::Log.warn 'Omnibus updater does not support Debian 5'
 24:  elsif(node[:platform] == 'raspbian')
 25:    Chef::Log.warn 'Omnibus updater does not support Raspbian'
 26:  elsif((node[:chef_packages][:chef][:version] == '12.6.0') && node[:os].downcase.include?('windows'))
 27:    Chef::Log.fatal 'Omnibus updater cannot upgrade or downgrade a Windows 12.6.0 installation'
 28>>   raise
 29:  else
 30:    include_recipe 'omnibus_updater::downloader'
 31:    include_recipe 'omnibus_updater::installer'
 32:  end
 33:
 34:  if(node[:omnibus_updater][:remove_chef_system_gem])
 35:    include_recipe 'omnibus_updater::remove_chef_system_gem'
 36:  end
 37:
[2016-03-01T19:27:57-08:00] ERROR: Running exception handlers
[2016-03-01T19:27:57-08:00] ERROR: Exception handlers complete
[2016-03-01T19:27:57-08:00] INFO: Sending resource update report (run-id: 63c3890c-230e-4d11-8892-d06a75e3540e)
[2016-03-01T19:27:58-08:00] FATAL: Stacktrace dumped to c:/chef-rm/cache/chef-stacktrace.out
[2016-03-01T19:27:58-08:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2016-03-01T19:27:58-08:00] FATAL: RuntimeError: `

cpoole gave me this https://github.com/Stromweld/omnibus_updater/pull/1#issuecomment-191044186 pr adding the check to the default recipe. Let me know what you think and I can merge it in or leave it out.

While I appreciate @cpoole's efforts, I really don't want us to go down the path of adding logic to route around Chef's bugs. If we include that, then we have to own it going forward, which becomes a maintenance headache for us, and encourages users to open issues here rather than with Chef's maintainers who should be responsible for prevention breaking changes between minor versions.
I do think we should note the known issue in the README and CHANGELOG, and we can also include example code for skipping the upgrade in case someone wants to implement it in a wrapper.
How does that sound?

That makes sense too, you guys are ultimately the primary maintainers so I'm cool with either way. I'll leave it as is.

:+1: Merging! Thanks for your effort on this. I'll make the README and CHANGELOG updates directly in develop, b/c Github does not play great with merging .md changes.

woohoo! thanks for the great work @Stromweld, the readme changes make me happy too :+1:


pdfjs-dist npm update from 2.0.489 to 2.0.943 causes webpack error: Can't resolve 'babel-runtime/regenerator'

After updating our npm package for pdfjs-dist from 2.0.489 to 2.0.943, webpack fails to build.
If we downgrade back to version 2.0.489 all is well again and the errors go away.
Here's a copy of the webpack build log showing the failures:
 10% building 1/1 modules 0 activei ｢wds｣: Project is running at http://localhost:8081/
i ｢wds｣: webpack output is served from /
i ｢wds｣: Content not from webpack is served from C:\xxxxxx\Website\dist                                                                                × ｢wdm｣:    2471 modules
ERROR in ./node_modules/pdfjs-dist/lib/core/pdf_manager.js
Module not found: Error: Can't resolve 'babel-runtime/regenerator' in 'C:\xxxxxx\Website\node_modules\pdfjs-dist\lib\core'

ERROR in ./node_modules/pdfjs-dist/lib/core/evaluator.js
Module not found: Error: Can't resolve 'babel-runtime/regenerator' in 'C:\xxxxxx\Website\node_modules\pdfjs-dist\lib\core'

ERROR in ./node_modules/pdfjs-dist/lib/core/obj.js
Module not found: Error: Can't resolve 'babel-runtime/regenerator' in 'C:\xxxxxx\Website\node_modules\pdfjs-dist\lib\core'

ERROR in ./node_modules/pdfjs-dist/lib/display/fetch_stream.js
Module not found: Error: Can't resolve 'babel-runtime/regenerator' in 'C:\xxxxxx\Website\node_modules\pdfjs-dist\lib\display'

ERROR in ./node_modules/pdfjs-dist/lib/display/network.js
Module not found: Error: Can't resolve 'babel-runtime/regenerator' in 'C:\xxxxxx\Website\node_modules\pdfjs-dist\lib\display'

ERROR in ./node_modules/pdfjs-dist/lib/display/node_stream.js
Module not found: Error: Can't resolve 'babel-runtime/regenerator' in 'C:\xxxxxx\Website\node_modules\pdfjs-dist\lib\display'

ERROR in ./node_modules/pdfjs-dist/lib/display/transport_stream.js
Module not found: Error: Can't resolve 'babel-runtime/regenerator' in 'C:\xxxxxx\Website\node_modules\pdfjs-dist\lib\display'

ERROR in ./node_modules/pdfjs-dist/lib/shared/message_handler.js
Module not found: Error: Can't resolve 'babel-runtime/regenerator' in 'C:\xxxxxx\Website\node_modules\pdfjs-dist\lib\shared'

ERROR in ./node_modules/pdfjs-dist/lib/web/ui_utils.js
Module not found: Error: Can't resolve 'babel-runtime/regenerator' in 'C:\xxxxxx\Website\node_modules\pdfjs-dist\lib\web'
i ｢wdm｣: Failed to compile.

Configuration:

Chrome: latest
Windows 10 Professional: Latest updates
PDF.js version: 2.0.943
Is a browser extension: No

What is the expected behavior? (add screenshot)
For the webpack build to succeed.
What went wrong? (add screenshot)
The webpack build fails, citing errors in the pdfjs-dist npm package for:
Module not found: Error: Can't resolve 'babel-runtime/regenerator'
Package.json excerpt follows:
{
 ...
 "engines": {
    "node": ">= 8.9.0"
  },
  "private": true,
  "devDependencies": {
    "@babel/core": "^7.1.6",
    "@babel/plugin-proposal-class-properties": "^7.1.0",
    "@babel/plugin-syntax-dynamic-import": "^7.0.0",
    "@babel/preset-env": "^7.1.6",
    "babel-eslint": "^10.0.1",
    "babel-loader": "^8.0.4",
    "clean-webpack-plugin": "^1.0.0",
    "copy-webpack-plugin": "^4.6.0",
    "css-loader": "^1.0.1",
    "eslint": "^5.9.0",
    "file-loader": "^2.0.0",
    "html-loader": "^0.5.5",
    "html-webpack-plugin": "^3.2.0",
    "http-server": "^0.11.1",
    "less": "^3.8.1",
    "less-loader": "^4.1.0",
    "mini-css-extract-plugin": "^0.4.4",
    "optimize-css-assets-webpack-plugin": "^5.0.1",
    "style-loader": "^0.23.1",
    "webpack": "^4.26.0",
    "webpack-cli": "^3.1.2",
    "webpack-dev-server": "^3.1.10"
  },
  "dependencies": {
    "@babel/polyfill": "^7.0.0",
    "bootstrap": "^3.3.7",
    "font-awesome": "^4.7.0",
    "jquery": "^3.3.1",
    "jquery-ui": "^1.12.1",
    "moment": "^2.22.2",
    "pdfjs-dist": "^2.0.943",
    "popper.js": "^1.14.5",
    "uuid": "^3.3.2",
    "whatwg-fetch": "^3.0.0"
  }
}

Coincidentally, version 2.0.550 works fine and does not give webpack build errors.

I think this is because babel-runtime/regenerator is necessary for supporting the async/await syntax with Babel; refer to https://github.com/mozilla/pdf.js/commit/099ed0885239f070f7c7e1d703b57cc64c3f634d#diff-b9e12334e9eafd8341a6107dd98510c9R185. It looks like the problem is that we require Babel 6 (refer to https://github.com/mozilla/pdf.js/blob/master/package.json#L7) whereas in your package.json you're requiring Babel 7, which may lead to a conflict. This could perhaps be resolved by us upgrading to Babel 7, but that is already tracked in #10229 for a different reason, so we can close this.

@timvandermeij Babel 6 or 7, doesn't really matter. If your code requires something, it should have it listed as a dependency. As such, I consider all currently released versions as faulty in that matter, and I suggest to add @babel/runtime as a dependency of pdfjs-dist. Another idea is to get rid of @babel/runtime dependency (probably the best approach).
May you consider reopening this?

None of this will be a problem if you actually use the pre-built library; please see the files distributed in https://github.com/mozilla/pdfjs-dist/tree/master/build respectively in https://github.com/mozilla/pdfjs-dist/tree/master/web, which are officially supported and won't suffer from the issues described here.

I'm a little confused. The versions at https://github.com/mozilla/pdfjs-dist/tree/master/build and https://github.com/mozilla/pdfjs-dist/tree/master/web are still version 2.0.489 at the time of this writing and this version is devoid from the issue I was reporting here.
Assuming @Snuffleupagus means that we should be using the pdfjs-dist version over pdfjs then I'm confused even more because the npm package for pdfjs-dist is at version 2.0.943 which has the issue (see https://www.npmjs.com/package/pdfjs-dist)
We are needing to pin the pdfjs-dist npm package at "2.0.550" as anything more recent breaks.
Am I missing something?

The versions at https://github.com/mozilla/pdfjs-dist/tree/master/build and https://github.com/mozilla/pdfjs-dist/tree/master/web are still version 2.0.489 at the time of this writing and this version is devoid from the issue I was reporting here.

See https://github.com/mozilla/pdfjs-dist/releases for the latest version, the other issues described here (non-updating master branch) is being tracked in issue #10391.

That actually helps. Thanks for clearing up.


[Question] Boolean values casted to string

Considering the following example code:
route('collector.get-messages', {
    body: true,
    collector: 1
});

It's currently (v0.9.4) rendered as: http://example.com/collector/1/messages?body=true
In PHP it's considered to be a string, and both "true" and "false" strictly equals to the boolean value true. I think this comes from the qs dependency stringify() function, if I want to send a PR, should I send it to this repository, or to qs ?

Would $request->boolean('body') in your Laravel app do the trick? That will treat "true" as true and "false" as false.

@bakerkretzmar Indeed, while $request->boolean('body') correctly converts it back to strict boolean, the validation rule boolean doesn't.
Generally speaking, boolean true shouldn't be sent as "true"

I think for query strings your best bet is to do this formatting yourself. There's no way to actually send it as a boolean because everything in the query string is a string. It looks like people have asked about this in the qs repo and they left it up to users to implement the encoding/decoding they needed: ljharb/qs#91, ljharb/qs#214.
If you want to use the boolean validation rule you could send 1 or "1" instead of true. If you have to send true you could manually convert it to a boolean before validation, either in your controller or in a form request:
$request->merge(['body' => $request->boolean('body')]);

// now $request->input('body') is a boolean

$request->validate(...);

@bakerkretzmar The fact that the discussion in still ongoing since 5 years on qs is a proof that it's still a debate.
I personally think that the purpose of serialization is to keep at least a boolean value. IMO, laravel/framework's boolean validation rule should support "true" and "false" as strings, but they won't as it's said to be a breaking change in behavior. qs shouldn't transform a boolean to its string representation, but rather to a int representation (as "0" and "1" are the base values we know before the boolean keywords).
Back to Ziggy, being a bridge (I don't mean to reduce Ziggy to "a bridge") between Laravel and qs, should it blindly bridge these 2 projects or should it bridge with sugar syntax? Knowing that Laravel may never validate "true" and "false" strings as being booleans, isn't it Ziggy's responsibility to implement an encoder, translating boolean strings to 0 and 1?
Still IMO, this is an issue 90% of users using boolean validation would face, while I don't see any downside to it

Actually, I think you might be right. My main goal for Ziggy's route() function is for it to work as closely as possible to how Laravel's route() helper does, so I tried this in PHP... and it turns out Laravel's route() helper already does exactly what you're suggesting:
<?php

route('collector.get-messages', [
    'body' => true,
    'collector' => 1,
]);

// returns
"http://example.com/collector/1/messages?body=1"

Unfortunately we'll have to implement our own encoder and decoder to pass to qs, but it looks like we may just be able to ignore all non-boolean values.
If you're already working on a PR for this or you want to, that would be awesome! (Please target the develop branch since this would go into v1). Otherwise I'll look into it when I have time in the next couple weeks.

If Laravel’s route didn’t change Boolean values to an int, I would have been surprised ^^’
I would happily submit a PR, I will to read about encoders on qs and submit something.
Thanks for the debate

Sorry for the delay, I got stuck on projects and couldn't look at it for now.

No worries! I got it working, it'll be included in v1.


Add exclude and includepkgs to every repo

ping @stahnma

I had some questions initially about this working with DNF, but then remembered that earliest I need to deal with that is RHEL 8, which is probably a few years out. Reviewing now.

@stahnma any news on this?

Wow, I swore I merged this in. I may have and not pushed it up yet. Let me check my work computer tomorrow.

@stahnma any news on this PR?

ping @stahnma

@stahnma could you please merge this?

Released 1.1.0 on the Forge today. Sorry this took so long. Thanks for bugging me enough :tada:


User Favorites

Hi, short question, within the Handy App you can define User Favorite programms and Names.
If i configure something on my Phone (apple), my wife can also see this on her Phone (Andoid).
Do you know if it's also possible to make this available here ?
EDIT
This question is regarding Washing Programs .....

Hey, I just have a look at it and it's possible :slightly_smiling_face:
I will add favorites as additional programs in the future :+1:

Hey, can you please test v0.8.0-beta.8? Favorites should be shown now :slightly_smiling_face:

Hi, yes they are shown. Will try functionallity next days.
many thx..

I can select a Favorite, but on some of them, selection jumps over to the next one. After selecting a Programm and pressing the Washingmaschine button ,program starts, but sensors showing not the right program.
Since i selected "All in one '59" the sensor reports "Active Wash + Steam". Also the selected Opions(Vorspülen) are not reported by the sensors.
On my Phone App it looks ok.

Since today i receive:
Dieser Fehler wurde von einer benutzerdefinierten Integration verursacht
Logger: homeassistant.config_entries
Source: custom_components/hon/init.py:31
Integration: Haier hOn (documentation, issues)
First occurred: 08:40:46 (2 occurrences)
Last logged: 17:04:36
Error setting up entry<EMAIL_ADDRESS>for hon
Error setting up entry<EMAIL_ADDRESS>for hon
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 387, in async_setup
result = await component.async_setup_entry(hass, self)
File "/config/custom_components/hon/init.py", line 31, in async_setup_entry
hon = await Hon(
File "/usr/local/lib/python3.10/site-packages/pyhon/hon.py", line 61, in create
await self.setup()
File "/usr/local/lib/python3.10/site-packages/pyhon/hon.py", line 91, in setup
for appliance in (await self.api.load_appliances())["payload"]["appliances"]:
File "/usr/local/lib/python3.10/site-packages/pyhon/connection/api.py", line 69, in load_appliances
async with self._hon.get(f"{const.API_URL}/commands/v1/appliance") as resp:
File "/usr/local/lib/python3.10/contextlib.py", line 199, in aenter
return await anext(self.gen)
File "/usr/local/lib/python3.10/site-packages/pyhon/connection/handler/base.py", line 44, in get
async with self._intercept(self._session.get, *args, **kwargs) as response:
File "/usr/local/lib/python3.10/contextlib.py", line 199, in aenter
return await anext(self.gen)
File "/usr/local/lib/python3.10/site-packages/pyhon/connection/handler/hon.py", line 58, in _intercept
kwargs["headers"] = await self._check_headers(kwargs.get("headers", {}))
File "/usr/local/lib/python3.10/site-packages/pyhon/connection/handler/hon.py", line 49, in _check_headers
await self.auth.authenticate()
File "/usr/local/lib/python3.10/site-packages/pyhon/connection/auth.py", line 245, in authenticate
if not (url := await self._login()):
File "/usr/local/lib/python3.10/site-packages/pyhon/connection/auth.py", line 182, in _login
await self._error_logger(response)
File "/usr/local/lib/python3.10/site-packages/pyhon/connection/auth.py", line 83, in _error_logger
raise exceptions.HonAuthenticationError("Can't login")
pyhon.exceptions.HonAuthenticationError: Can't login
{"event":{"descriptor":"markup://aura:systemError","attributes":{"values":{"message":"[AuraClientInputException from server] Unexpected request input. Expected input format: "Data in a request must be a valid JSON Object and must be in the expected format.".","showOverride":false}},"eventDef":{"descriptor":"markup://aura:systemError","t":"APPLICATION","xs":"G","a":{"message":["message","aura://String","G",false],"error":["error","aura://String","G",false],"auraError":["auraError","aura://Object","I",false,null],"timestamp":["timestamp","aura://Integer","I",false],"showOverride":["showOverride","aura://Boolean","I",false,false]}}},"exceptionMessage":"[AuraClientInputException from server] Unexpected request input. Expected input format: "Data in a request must be a valid JSON Object and must be in the expected format.".","exceptionEvent":true}/ERROR/ ========================================
{'error': {'message': 'not valid jwt ISS', 'code': 'VFJWTI', 'statusCode': 400}}

Logon issue is fixed.
Here you can see, what happens if i select "Buntwäsche" it jumps directly to the second one "Bärchen".
https://drive.google.com/file/d/1vNXo3uqkxn1tZiJPsraf25ky2QwNoZAS/view

Hi, okay I understand and will have a look. Is "Bärchen" based on "Buntwäsche"? You can remove it if you want :+1:

but sensors showing not the right program.
The program name thing is a bit tricky, I will have a look at it.

I'am missing some settings here, this mashine has an option to select a dirt level (0,1,2) and provides an option named "Hygiene".

Can you show your device log? Maybe we could add these settings.

What happens, if you select an Favorite and this options are not implemented ?
It should be use the programs default value and for favorites it should use the configured value :slightly_smiling_face:

Hi, okay I understand and will have a look. Is "Bärchen" based on "Buntwäsche"? You can remove it if you want

Don't know if "Bärchen" is based in "Buntwäsche" but both are based on the same original program.

Can you show your device log? Maybe we could add these settings.

Something like this ? https://github.com/Andre0512/hon/issues/42#issuecomment-1546900135

How do you get the Favorit settings ? in pyhOn.py i only see the names, but no info about the program details.


Android App won't work with my device

Hi,
I've got a Garmin HUD and want to to use it with Google Maps.
I've downloaded your app but unfortunately it don't display any navigation information on the HUD.
Paring with the HUD and reading(/parsing) notification work with my device.
I've already tryed to import the code in Android Studio to get further debug information, but the main part of the app is missing.
My device is a Google Pixel 2 running Android 8.1.0. Language is set to German (but tried already with english language).
May you can figure out, what the issue is.
If I could help you somehow, it would be a pleasure.
Niklas
Somehow can't attach a picture, displayed Maps notification is:
LeaveRoundaboutUp 110 m 0:9 9,3 km Ankunft ca. 22:39 (period: 1280)

I solved the issue for myself. I took the source code of version 0.1.2 and looked for the issue(s).
The main problem was, that one String that is essentaelly needed for working, has to be translated into the language each phone is using.
The app is looking in the notification content of the Google Maps Notification for the keyword "EXIT NAVIGATION". Based on the keyword the app assign the individual sections of the notification.
Another problem was, that the notification hasn't been parsed correctly. Curiously there were some spaces between distance and distance unit, that shouldn't been there according to the code.
Another issue was the decimal seperator. In some countries (like in Germany) we use a comma to seperate the decimal. The Garmin HUD need the distance with a point seperated the decimals.

Any chance that you could share the compiled apk with us?
Many thanks

The biggest bug of Garminuino is language difference.
I had meet the problem many times.
The app is involving with localization mechanism, this can solve part of this problem.
But different language/country setting can lead different format of navigation message.
NEED EVERYBODY'S HELPING.
If you cannot run app work well, try switch to english language first, if it works....
A Language problem, again....

@Niklas04 - many thanks! I'll try switching to German for a test and see

@skyforcetw looked and played a little bit through the source-code. I think I understand, what you mean with problems caused by language differences.
But I think there are some other bugs, too.
Maybe I can try to help you, to get the app working for most/some languages. Will make a pull request withing the next days.
@wokawoka ok, I'l be exited to hear from you


Deploy version 6.4.4-beta.0 to Docker Hub

Currently the most recent deployment to Docker Hub (https://hub.docker.com/r/trufflesuite/ganache-cli/builds) is v6.4.3, and in the past v6.4.3-beta.0 was deployed. Please deploy the current beta branch, which has the version 6.4.4-beta.0, to Docker Hub.
[x] I asked about this on gitter
[x] Link to my question on gitter: https://gitter.im/ConsenSys/truffle?at=5ced79679b50f63935434cfe
Context
There is a bug with ganache-core with estimating gas fees that crashes ganache. This was fixed in the current beta for ganache-core which the beta for ganache-cli has updated to.

Docker builds are a completely automated process, and it looks like our docker account got unlinked from our github recently and has been unable to access our repositories. I've gone in and clicked the button in docker to enable github access again and things looks to be building now.
I've also enabled build failure email notifications so I can catch issues like this sooner.
Let me know if this new beta build works for you.
Thanks!


fix: script parameter error under macos

Signed-off-by: shaowenchen<EMAIL_ADDRESS>An error occurs while I compile the project under macos 11.2.3 (20D91).
BUILD_WITH_CONTAINER=0 make clean

BUILD_WITH_CONTAINER=0 make init

ISTIO_OUT=/Users/shaowenchen/Code/github/istio/out/darwin_amd64 ISTIO_BIN=/Users/shaowenchen/.gvm/pkgsets/go1.16/global/bin GOOS_LOCAL=darwin bin/retry.sh SSL_ERROR_SYSCALL bin/init.sh
script: illegal option -- -
usage: script [-adkpqr] [-t time] [file [command ...]]
Unexpected failure
make: *** [/Users/shaowenchen/Code/github/istio/out/darwin_amd64/istio_is_init] Error 1

It should use script -q -r file cmd of script --flush --quiet --return file --command cmd under macos.
[ x] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @shaowenchen. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Is there a reason you are using BUILD_WITH_CONTAINER=0? Maybe you don't want to install Docker? We have moved to building within a build container, except for proxy, so that we don't need to have script checks, etc for all operating systems. For example, on MacOS  sed and grep also behave differently, and we would need script changes for those (or require developers to install/overlay versions of those as well).

/ok-to-test

@shaowenchen: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
491cde69efbe444c44c2387b883257749bc849d9
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The change looks good. It should help with running local dev builds on MacOS (not a supported dev environment as the community moved to containers), and will not affect non MacOS builds. I started the tests. I know the Release Note test will fail. You need to add a x in the [ ] Does not have any user-facing changes.  box, which should cause a release-notes-none label to be added to the PR. At that point, re-run the test and it should pass.

fixed.
/ok-to-test

@shaowenchen: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
491cde69efbe444c44c2387b883257749bc849d9
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shaowenchen: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
491cde69efbe444c44c2387b883257749bc849d9
link
/test release-notes_istio

integ-pilot-k8s-tests_istio
491cde69efbe444c44c2387b883257749bc849d9
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@shaowenchen: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
491cde69efbe444c44c2387b883257749bc849d9
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
491cde69efbe444c44c2387b883257749bc849d9
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shaowenchen: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
491cde69efbe444c44c2387b883257749bc849d9
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
491cde69efbe444c44c2387b883257749bc849d9
link
/test release-notes_istio

integ-operator-controller-tests_istio
491cde69efbe444c44c2387b883257749bc849d9
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Consistent Luigi spelling in docs

Description
Capitalizes all instances of Luigi in the docs.
Motivation and Context
The majority of the time, Luigi is capitalized, so I thought it would be nice to be consistent 😄
Note
I only did this for the doc files, not the docstrings. Maybe a future PR.

[Current coverage][cc-pull] is 76.17%

Merging [#1723][cc-pull] into [master][cc-base-branch] will decrease coverage by 2.67%

@@             master      #1723   diff @@
==========================================
  Files            95         95
  Lines         10358      10358
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           8167       7890   -277
- Misses         2191       2468   +277
  Partials          0          0

Powered by Codecov. Last updated by [b871e9d...8c2236c][cc-compare]
[cc-base-branch]: https://codecov.io/gh/spotify/luigi/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/spotify/luigi/compare/b871e9d29c2d16a3e55cf296ef48c2903478c251...8c2236c03986f21ef01b553e9590593d53ec20fa
[cc-pull]: https://codecov.io/gh/spotify/luigi/pull/1723?src=pr

LGTM, thanks for doing this!


drrun throws error invalid target function offset

I compiled Winafl like this:
mkdir build64
cd build64
cmake -G"Visual Studio 16 2019" x64 .. -DDynamoRIO_DIR=..\path\to\DynamoRIO\cmake -DINTELPT=0 -DUSE_COLOR=1 -DUSE_DRSYMS=1
cmake --build . --config Release
-DINTELPT=0 because AMD processor
DynamoRIO-Windows-9.0.1; Windows 10
Then, after compiling, I decided to run drrun.exe and test the test.exe program. Entered the following:
drrun.exe -c C:\Users\andre\Desktop\winafl-master\build64\bin\Release\winafl.dll -debug -target_module C:\Users\andre\Desktop\winafl-master\bin64 -target_offset 0x1610 -fuzz_iterations 10 -nargs 2 -- C:\Users\andre\Desktop\winafl-master\bin64\test.exe C:\Users\andre\Desktop\winafl-master\bin64\test.txt
And then got the output of one iteration. The log was:
Module loaded, dynamorio.dll
Module loaded, winafl.dll
Module loaded, drx.dll
Module loaded, drreg.dll
Module loaded, drmgr.dll
Module loaded, drwrap.dll
Module loaded, drsyms.dll
module loaded test.exe
Module loaded, VCRUNTIME140.dll
Module loaded, ucrtbase.dll
Module loaded, KERNELBASE.dll
Module loaded, KERNEL32.dll
Module loaded, ntdll.dll
Module loaded, msvcrt.dll
Module loaded, RPCRT4.dll
Module loaded, AppCore.dll
WARNING: Target function was never called. Incorrect target_offset?
Coverage map follows:
I checked the offset both through Ida and through WinDBG, an attempt to use target_method main does not help either. Tried to change versions of DynamoRIO does not help

Made a small typo in -target_module C:\Users\andre\Desktop\winafl-master\bin64\test.exe

Solved the problem by moving the winafl.dll library, the program file and the test file to the folder of the current directory -c winafl.dll, -target_module test.exe and -nargs 2 -- test.exe test.txt


Paste in Find doesn't work

When copied a text and then pressed cmd+v on mac, the copied text is not pasted on the Find bar. whereas when pasted using right click it does paste.

If you are running the application from temporary location certain actions are prohibited by TCC, given issue does not repro when running from /Applications, closing as non-actionable.


Improve DataStore settings implementation

There is a problem that I didn't mention in #45 because the PR had been merged before I thought about it.

value in GenericDataStoreSettingValueState is not changed when the value with a key bound to GenericDataStoreSettingValueState is changed. I think one who uses the library may expect that a change in preferences should be visible to GenericDataStoreSettingValueState and therefore to composables that uses the state.

Example:
@Composable
fun Composable() {
    val context = LocalContext.current

    val dataStore = remember(context) {
        context.composeSettingsDataStore
    }

    AppScaffold(
        scaffoldState = scaffoldState,
        title = { Text(text = "Screen") }
    ) {
        val storage= rememberDataStoreBooleanSettingState(
            key = "switch",
            defaultValue = false,
            dataStore = dataStore
        )

        SettingsSwitch(
            state = storage,
            title = { Text(text = "Switch") }
        )

        Button(onClick = {
            toggleState(dataStore)
        }) {
            Text("Toggle")
        }
    }
}

private fun toggleState(dataStore: DataStore<Preferences>) {
    runBlocking {
        dataStore.edit {
            val key = booleanPreferencesKey("switch")
            it[key] = !(it[key] ?: true)
        }
    }
}

I'd expect that switch's state is changed, but it's not.
This PR fixes that problem by launching a coroutine that collects the latest value of a property and assigns the collected value to _value. Also, the PR makes the code prettier a little bit.
@alorma Can you take a look? I'm not 100% sure that it's really a big problem (or a problem at all), but I think it's better to be fixed.

I approve and merge it.
Yes, it make sense about datastore value


[Feature Request / Enhancement] Traffic Compression to save money

Hey AWS Labs guys.  You've done a terrific job with this utility for replicating DynamoDB tables across several regions. We've been using it for quite some time and it works just fine.  Our DynamoDB tables are so huge and they are constantly changing, so the traffic generated by the tool to keep the tables replicated is huge as well, we are talking about several TBs monthly, which is leaving its mark on the AWS bill.
It would be nice to be able to enable some sort of compression on the traffic received/sent from/to DynamoDB, so we would be able to save a lot of money.
I'd appreciate any feedback/comments on this request.
Thanks a lot

DynamoDB supports GZIP compression for the response payload. By default this is off in the Java SDK. When enabled, a client header is sent with the HTTP request to DynamoDB saying the client will accept a GZIP'd response. DynamoDB will only GZIP its response to your client if it's above a certain size - if my memory is correct this is 4KB - and your client has the accept encodings gzip header.
LOC where the client is made:
https://github.com/awslabs/dynamodb-cross-region-library/blob/fc336053be0ae0df4cc82c6b107c53fbdfc45474/src/main/java/com/amazonaws/services/dynamodbv2/streams/connectors/DynamoDBReplicationEmitter.java#L88
Would you like to fork this repo and test out the GZIP compression? I think we use the default client configuration when we create AmazonDynamoDBASync, so you'll need to make a client config and then update the tests.
This might save you a few hundred dollars per month in DTO (data transfer out).


Support smartstring

I tried using the https://docs.rs/smartstring/1.0.1/smartstring/ crate together with sqlx but that string type is not supported when binding variables. Are there any plans to support such small string crates as optional feature?

Hey @gitmalong, if I am not mistaken, you should still be able to use the smartstring crate with sqlx. As you can see from their documentation, SmartString implements AsRef<str>, which means that it dereferences into, you guessed it, the native Rust string slice type &str.
How is that useful to you? Well, it means that when you write a query, you are able to still use SmartStrings in places where sqlx expects a string. For example:
query("INSERT INTO shitty_code_examples(author, code) VALUES ('xfbs', ?)")
    .bind(&your_smart_string_here)
    .execute(&pool)
    .await?;

I hope this makes sense. If this didn't answer your question, feel free to give more context and/or show me what code you are trying to run.

Hi @xfbs . Thanks for your explanation. I'll give that a try tomorrow and report back!

My response here is the same as https://github.com/launchbadge/sqlx/pull/1922#issuecomment-1162499216
Every external crate we add is another semver hazard, so it needs to be very compelling to make it worthwhile. smartstring may be at 1.0 now, but what happens if/when the author releases a 2.0?

I just gave CompactString a try
  sqlx::query(
        "
            INSERT INTO public.my_table(value, current_value)
            SELECT *, $4 FROM UNNEST($1::text[], $2::decimal[])
        ",
    )
    .bind(data.values) # of type: Vec<CompactString, Global>
    .bind(data.numbers)
    .execute(pool)
    .await

Error:
the trait bound `for<'a> &'a [CompactString]: Encode<'_, sqlx::Postgres>` is not satisfied
the following other types implement trait `Encode<'q, DB>`:
  <&[T] as Encode<'q, sqlx::Postgres>>
  <&[u8] as Encode<'_, sqlx::Postgres>>
required because of the requirements on the impl of `Encode<'_, sqlx::Postgres>` for `Vec<CompactString>`rustc[E0277](https://doc.rust-lang.org/error-index.html#E0277)
dao.rs(23, 6): required by a bound introduced by this call
query.rs(79, 32): required by a bound in `sqlx::query::Query::<'q, DB, <DB as HasArguments<'q>>::Arguments>::bind`


UDP.payload is wrongly assumed to be NUL-terminated

UDP.payload is wrong if the payload contains a NUL (b'\x00') character.
>>> from pcapfile.protocols.transport import udp
>>> u = udp.UDP(b'\x00\x00\x00\x00\x00\x01\x00\x00\x00')
>>> u.payload    # Should be b'\x00'
b''

This is because of the use of c_char_p, which is for NUL-terminated strings, but UDP payloads in general can contain NUL characters. Why is c_char_p used for payload? What is the purpose using ctypes and ctypes.Structure for the UDP class?

Fixed in #53.


Improve Github Actions to respect yarn.lock

Currently, yarn install installs always the newest dependencies without respecting yarn.lock.
This makes build not easily reproducible and might trigger false positives errors in PRs.
Apart from that, reworked the Actions file a bit to remove unnecessary npm install -g yarn as well as testing for both NodeJS 12.x and 14.x

probably a good idea, thanks @grische
@all-contributors please add @grische for tool

one thing i actually realized after merging it is you removed the npm install -g yarn command - do Actions include yarn by default now? it seems to have passed with that change


Fixes and documentation updates

Changes

Fixes #146, #229, #364 and #392
Updates changelog
Add changelog for edge
Moves part of documentation in DOCS.md for stable
Adds Readme.md for edge
Added logo.png to display on addon page automatically

Fixes value for startup according to documentation.
This should delay the add-on startup until after Home Assistant is up, and possibly also Mosquitto
Later edit: Used to be before and after but got documented later. Seems before is aliased as services and after as application according to code but it's best to use the official documentation suggestion.
Checklist

[x] Change the version number in zigbee2mqtt/Dockerfile: ENV ZIGBEE2MQTT_VERSION="$NEW_VERSION"
[x] Change the version number in zigbee2mqtt/config.json: "version": "$NEW_VERSION"
[x] Add any new configuration options to zigbee2mqtt/config.json and zigbee2mqtt-edge/config.json.
[x] Update the changelog, including any breaking changes, changes to underlying libraries, or new configuration options

@danielwelch I was just looking at versioning. What do you think of changing versioning from X.Y.Z.A to X.Y.Z-A?

After merging this PR, we should create a dev branch and start any new PRs in that branch

@danielwelch I'll release this today and any changes you need, i'll get them in the next iteration.

Thanks, sorry for the delay on my end, busy week.
Thanks,
Danny Welch
On Sep 22, 2020, 12:02 AM -0500, Marius<EMAIL_ADDRESS>wrote:

Merged #394 into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


⚠ Processors has degraded performance

In 8a6baac, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 47 ms

Resolved: Processors performance has improved in 526c726.


Hydrate pagination parameters with StartingToken

This initializes next_token with the value that is in the starting
token when a page iterator is created. This allows it to properly
pass on any previous service pagination token.

Codecov Report

Merging #1276 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1276      +/-   ##
===========================================
+ Coverage    98.09%   98.09%   +<.01%
===========================================
  Files           45       45
  Lines         7389     7391       +2
===========================================
+ Hits          7248     7250       +2
  Misses         141      141

Impacted Files
Coverage Δ

botocore/paginate.py
97.26% <100%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec9a37...a8bed2f. Read the comment docs.


FFImage on UWP (non-forms) has non-adjustable alignments

In the UWP version (not Xamarin Forms) the Image inside FFImage is given fixed horizontal and vertical alignments of 'Stretch'. The alignments of the FFImage itself can be adjusted, as these are exposed by its base classes.
Because the actual alignment of the inner image cannot be set, problems occur when one wants to use a stretch of UniformToFill and have the fit occur from the center. Setting the alignment of the FFImage does nothing, as it does not affect the actual image.
Ideally any changes to the FFImage's alignment properties would be passed on to the Image, but I'm not sure that's possible (the properties are part of the framework). An alternative aproach, adding extra bindable properties, is easily done - I'll add a pull request for this.

I've added a pull request at #502 for a fix

Any feedback on the suggested enhancements (or alternatives)? I can't release an app on UWP in its current state, unless I compile it together with the the adjusted FFImageLoading source.

It's merged, sorry it took so long.


FIX: random pca solver in sklearn v.18

closes #3582

LGTM, +1 for merge once CIs are happy. The previously-failing test passes here now.
In case you're up for another, I still have this warning:
Test TimeDecoding ... /home/larsoner/.local/lib/python2.7/site-packages/sklearn/cross_validation.py:43: DeprecationWarning: This module was deprecated in version 0.18 in favor of the model_selection module into which all the refactored classes and functions are moved. Also note that the interface of the new CV iterators are different from that of this module. This module will be removed in 0.20.
  "This module will be removed in 0.20.", DeprecationWarning)

So somewhere we're still using an old module. But I can also make a separate issue for that.

ok, I'm going to stop now, I need to work a bit

Current coverage is 86.95% (diff: 70.00%)

Merging #3587 into master will decrease coverage by 0.33%

@@             master      #3587   diff @@
==========================================
  Files           341        341
  Lines         60142      60144     +2
  Methods           0          0
  Messages          0          0
  Branches       9187       9188     +1
==========================================
- Hits          52496      52297   -199
- Misses         4899       5086   +187
- Partials       2747       2761    +14

Powered by Codecov. Last update f350bd4...7a7dce4

mmmh, what is the error?

All better locally and on the CIs, thanks for the quick fix @kingjr
It says there is a coverage drop but I find it hard to believe for this PR. Looking at the actual diff on CodeCov I don't see it.


Tradeding service not work

Current in my inentory

No trade create , so is the trade  function work  correct !!!

Trade offers are created to balance the amount of goods from the same era. Additionally there are selled the "green" goods only.

Ok I see, let me monitor and report later if there is something wrong  , thanks you very much. By the way how about the automation build military , this function will  help me very much to Expedition war  . Is there any plan about it ? . Or just show me the createServerRequest format , I will do it by myself :)


No default export

In my Sveltekit app I successfully installed Geocoder with npm install --save @maplibre/maplibre-gl-geocoder.
However when I try to import with import MaplibreGeocoder from '@maplibre/maplibre-gl-geocoder'; it throws an error saying that

[vite] The requested module '@maplibre/maplibre-gl-geocoder' does not provide an export named 'default'

Is this an issue with the build or do I overlook something?

It's probably a "type": "module" issue with sveltekit that it thinks it's es instead of commonjs.
I'm not sure how to solve it with Svelte...

@vvvyyynet is this still relevant? Can I close this issue?

@vvvyyynet I was able to import it via dynamic import:
onMount(async () => {     const { default: MaplibreGeocoder } = await import('@maplibre/maplibre-gl-geocoder');

No response, closing...


NS_ERROR_NOT_AVAILABLE in Firefox 38.0.1

html2canvas does not seem to work in Firefox 38.0.1. To reproduce, it's enough to simply run:
html2canvas(document.body);

Chrome seems to still work, so the problem shouldn't be in my setup.

Probably #95. Is this on any particular page?

It's indeed on a page that contains SVG, custom fonts, etc.

NS_ERROR_NOT_AVAILABLE: this is a Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=700533 (AFAICT) there is a testpage that highlights the issue (linked from the bug) http://phrogz.net/SVG/svg_to_png.xhtml
A workaround / fix would be greatly appreciated. Or maybe someone could poke somebody @mozilla to get this fixed :)
@hoxu : Try adding width and height attributes to the svg images if you can - that should make them work in Firefox too.

Also moving the drawImage call from https://github.com/niklasvh/html2canvas/blob/f3b6df267e24aa9e38730ac304c352a5c743be53/src/renderers/canvas.js#L51 into the try below it would actually improve the bahavior in that the screenshot would continue without the broken image.


integration with github repository

How do you automatically upload the changes that livecheck generates?
Have you thought about the possibility of a flag to commit, del and add new files?
This way it automatically uploads new ebuilds to github

It's in scripts in my tatsh-overlay repo. It's very basic and only checks that the prepare stage passes. For 99% of packages that is enough.

Hold off on this feature please. Or make a separate branch and be prepared to rebase.


refactor: deprecate vault-stats zapper endpoint [WEB-727]

Deprecate zapper's vault-stats endpoint in favor of new token-market-data

@x48-crypto could you review this when you get a chance?


Implement "Beam Summit 2022" banner

Imported from Jira BEAM-14527. Original Jira may contain additional context.
Reported by: Alexander Zhuravlev.

Unable to assign user @miamihotline. If able, self-assign, otherwise tag @damccorm so that he can assign you. Because of GitHub's spam prevention system, your activity is required to enable assignment in this repo.

.take-issue

.close-issue


[fix] Prevent presence unknown, set qos=1

Not sure why there's no review. @baylanger if you request me I will approve


Add nextauthjs

This pull request introduces several updates to the project, focusing on environment setup, dependencies, and authentication integration. The most important changes include updating the development container image, adding environment variables, configuring Git attributes, updating dependencies, and integrating MongoDB with NextAuth for authentication.
Environment and Configuration Updates:

Updated the development container image to a newer version in .devcontainer/devcontainer.json.
Added sample environment variables for MongoDB and Google authentication in .env.sample.
Configured Git attributes for line endings in .gitattributes.

Dependency Updates:

Updated various dependencies in package.json, including next, react, react-dom, tailwindcss, and added new dependencies for MongoDB and NextAuth. [1] [2]

Authentication Integration:

Implemented NextAuth with MongoDB adapter and Google provider in src/app/api/auth/[...nextauth]/route.ts. (src/app/api/auth/[...nextauth]/route.tsR1-R18)
Created a MongoDB client connection utility in src/lib/mongodb.ts.

Will submit a new one after Tom's content


[DO NOT MERGE] Change for links in header and footer

change 'Forum' title in footer section to 'Community'
change 'Rravel buddies and for sale' link to 'Travel Companions' in footer
reorder links in 'Community' section in footer
remove '/airport-transfers' link from global header Bookings section

Details: https://trello.com/c/fNRcOqdf/1550-as-john-i-want-changes-in-global-footer

@WunderBart @thomasthesecond  can anybody of you confirm that these changes are doing what I described above 💃 ?
I am not 100% sure that I know how rizzo + rizzo-next works but I was trying to fin all the places where the change should be made. Let me know if there is anything else ;)

@thomasthesecond what is the process for publishing new package (I will need it for rizzo)?

@nidalaa After you merge this, I can go ahead and make a new release.

Cool, thanks 🙇♀  Let's publish it then 🎉


Tos screen add undetected screen resolution

current issue
When using tos screen resolution you can only set resolutions supported by xrandr. However sometimes the correct resolution can't be found (due to cheap or badly implemented monitors) if this resolution is not found it should be created instead using a new command
solution
Instead of soly relying on xrandr detected resolutions you should implement a add resolution feature. Here is a short explanation.
$ cvt <horizontal> <vertical> # get screen timing info based on resolution

$ cvt 1280 1024
# 1280x1024 59.89 Hz (CVT 1.31M4) hsync: 63.67 kHz; pclk: 109.00 MHz Modeline "1280x1024_60.00" 109.00 1280 1368 1496 1712 1024 1027 1034 1063 -hsync +vsync

Based on the output of cvt you can generate the apropriat xrandr command
$ xrandr --newmode "1280x1024_60.00" 109.00 1280 1368 1496 1712 1024 1027 1034 1063 -hsync +vsync

Now you have added a new resolution to your screen. Be carefull when using this xrandr command because if the resolution is not supported by your screen you can get very unexpected results. Luckily a reboot wil bring you back to the old screen resolution
I propose that the tos syntax is the following
tos screen add resolution 1920x1080 or in short tos s a r 1920x1080

This feature should be present in the 1a4027d commit. The current syntax is slightly different than predicted. It is the following tos screen add HDMI-0 1920x1080 Where HDMI-0 is the screen to change and 1920x1080 is the resolution to make.

Before closing this we should add one change to the current way tos handles screen adding. The refresh rate should also be customizable in the following way. tos screen add HDMI-0 11920x1080 59.9 where 59.9 is the refresh rate at which the screen should work

The frequency option has been added in commit version 36b7b82


LocationActivity crashes on Configuration change when App ask for location permission.

On Step-4 :
As mentioned above, When the configuration is changed when App is asking for Location Permission, the onRequestPermissionsResult() method will be called again where it will find grantResults as empty array, so the grantResult[0] will result in ArrayOutOfBoundIndex Exception.
Fix:
@Override
public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions,
@NonNull int[] grantResults) {
super.onRequestPermissionsResult(requestCode, permissions, grantResults);
if (requestCode == REQUEST_LOCATION_PERMISSION_CODE && grantResults.length > 0) {
... < all code remaining same >
}
}

Checking if the grantResult is empty or not.

Thanks for reporting this and the feedback! Added the check to protect against the exception. Thank you!


Error creating pods about pulling images

Description
Have a problem with pulling images, when using the latest cri-o. Some error with progress bars ?
Steps to reproduce the issue:

sudo crictl pull k8s.gcr.io/pause:3.1

Describe the results you received:
First time (only) gets:
FATA[0002] pulling image failed: rpc error: code = Unknown desc = error creating progress-bar pool: Can't set terminal settings: input/output error
Second time (and on):
FATA[0004] pulling image failed: rpc error: code = Unknown desc = error creating progress-bar pool: Bar pool was started
The actual non-minimized context looks more like this:
  Type     Reason                  Age                  From               Message
  ----     ------                  ----                 ----               -------
  Normal   Scheduled               14m                  default-scheduler  Successfully assigned kube-system/coredns-7748f7f6df-5h62t to box
  Warning  FailedCreatePodSandBox  14m                  kubelet, box       Failed create pod sandbox: rpc error: code = Unknown desc = error creating pod sandbox with name "k8s_coredns-7748f7f6df-5h62t_kube-system_944f653b-53cc-11e9-bc34-a284975d7303_0": error creating progress-bar pool: Can't set terminal settings: input/output error
  Warning  FailedCreatePodSandBox  4m2s (x41 over 14m)  kubelet, box       Failed create pod sandbox: rpc error: code = Unknown desc = error creating pod sandbox with name "k8s_coredns-7748f7f6df-5h62t_kube-system_944f653b-53cc-11e9-bc34-a284975d7303_0": error creating progress-bar pool: Bar pool was started

Describe the results you expected:
It should have worked without errors.
Going to back to a version before the gopkg.in/cheggaaa/pb.v1 update still works OK.
i.e. dfd0faa709b5369f8bb66a11c68cc5cf68fed862^
Additional information you deem important (e.g. issue happens only occasionally):
Output of crio --version:
crio version 1.14.0-dev
commit: "7a329fc0a6198e611ad862a67aca3380406dfc83-dirty"

Additional environment details (AWS, VirtualBox, physical, etc.):
VirtualBox

If I understand correctly, the unlockEcho fails to unlock and then it remains lockEcho forever.
https://github.com/kubernetes-sigs/cri-o/blob/master/vendor/gopkg.in/cheggaaa/pb.v1/pb_x.go#L57:L105
		if err := unix.IoctlSetTermios(fd, ioctlWriteTermios, origTermStatePtr); err != nil {
			return fmt.Errorf("Can't set terminal settings: %v", err)
		}

		if origTermStatePtr != nil {
			return shutdownCh, ErrPoolWasStarted
		}

Sadly I still don't know why it failed initially, other than getting an I/O error (for some reason)

Referenced changes:

https://github.com/kubernetes-sigs/cri-o/commit/dfd0faa709b5369f8bb66a11c68cc5cf68fed862

** https://github.com/containers/image/commit/911d1f5a61eaa1aaca9ef9ae9efa8ef46c0c02cf
*** https://github.com/cheggaaa/pb/commit/5f971f1c90c4e7c9e5b7578cb4d114eaee3eb0b0
The old code unlocked before unix.IoctlSetTermios, the new code unlocks after (or never).

cc: @vrothberg

Hi @afbjorklund, thanks for the great report! The newer versions of containers/image do not use this library anymore. I have a PR open (https://github.com/kubernetes-sigs/cri-o/pull/2195) to update the vendored dependencies from containers/*. Once that's in, the problem will be fixed.

Okay, I will try 9afd50caf052c1bb6909130818744865a6a48a4e out and see if that fixes it

That worked much better, no progress bar etc - but no errors either.
tc@box:~$ sudo crictl rmi k8s.gcr.io/pause:3.0
Deleted: k8s.gcr.io/pause:3.0
tc@box:~$ sudo crictl pull k8s.gcr.io/pause:3.0
Image is up to date for k8s.gcr.io/pause@sha256:0d093c962a6c2dd8bb8727b661e2b5f13e9df884af9945b4cc7088d9350cd3ee
tc@box:~$ crio --version
crio version 1.14.0-dev
commit: "9afd50caf052c1bb6909130818744865a6a48a4e-dirty"
tc@box:~$

The 3.1 was now in use (by a pod), so used 3.0 to test with...

The upstream e2e tests introduced a regression which should be fixed now. #2195 should be merged today :)


bug: Errors showing up after making everything correctly

NativeWind not working at all for some reason

hey @LansPeti , could you please attach the errors you are getting?

Strange, works on my end.
Would you mind sharing some more context around the issue?

Feel free to reopen with a repro / more context


Determination of VCPKG_CROSSCOMPILING is insufficient

Describe the bug
The value for VCPKG_CROSSCOMPILING seems to be determined here
https://github.com/microsoft/vcpkg/blob/83972272512ce4ede5fc3b2ba98f6468b179f192/scripts/cmake/vcpkg_common_definitions.cmake#L1
by comparing the target triplet with the host triplet.
This will pretend that cross-compilation is active simply because the triplet was named differently. However, simply using a variant of an existing triplet will trigger this (at least it does for x64-osx-release).
Expected behavior
Whether or not crosscompiling is active should be determined by checking the target architecture and OS (which are part of the triplet, but other things might be as well).
Additional context
The toolchain files (scripts/toolchains)  seem to do actual checking based on the target and host architecture but this doesn't seem to affect the main build (based on my tests this is only used for determining the compiler to use).

Nope that is cross-compiling for vcpkg. If you don't want this behavior specify --host-triplet (with newer version of vcpkg specifying the host triplet is enough to get the wanted target triplet.)

Ah okay. My bad

There seems to be general abuse of the triplet system in vcpkg. For example, linkage specifiers sometimes make their way into the triplet (x64-mingw-dynamic vs x64-mingw-static), which touches on the other major issue that static and dynamic libraries cannot be intermixed or specified in project files unless the port name is handled specially in the triplet file (https://github.com/microsoft/vcpkg/issues/906)


Docker-Hub reduce deployment from master and develop branch

limit the images deployed to master, tagged latest

deploy develop branch as staging, tagged development

Migrate to CircleCI 2.0

done


iframe URL ignores baseURL

🐛 The bug
Comments on issue #237 seem to indicate that PR #386 would allow the iframe to be relative to baseURL, but the iframe still points to /__nuxt_devtools__/client/ - this makes nuxt devtools go 404 when the application is accessed through a reverse proxy.
🛠 To reproduce
https://stackblitz.com/edit/nuxt-starter-s8vyfn?file=nuxt.config.ts
🌈 Expected behavior
Setting baseURL=/prefix/ in nuxt.config.ts
export default defineNuxtConfig({
  app: { baseURL: '/prefix/' },
  devtools: { enabled: true },
});

the iframe should point to /prefix/__nuxt_devtools__/client/ but opening the browser's network monitor or DOM inspector will show that it still points to /__nuxt_devtools__/client/
ℹ Additional context
No response

same for me!

Also seeing a 404 when launching the dev tools. Fixing this would be super useful as we are currently unable to use the dev tools for a project that is hosted under a prefix URL.

Great work. Thank you!


chore: return RTE toolbar id for feature tests

FX-4172
Description
For backward compatibility, we need to keep the HTML structure closest as possible to the previous version. In feature tests, they are using the id of the toolbar as a selector.
How to test

Temploy
FIXME: Add the steps describing how to verify your changes

Screenshots

Before.
After.

Insert screenshots or screen recordings
Insert screenshots or screen recordings

Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
Covered with tests

Breaking change

codemod is created and showcased in the changeset
test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers


Create Video modul

Create multiple image upload form in the application
Create Embed a Collection of Forms
Create VideoType Class
Update form template for collection
Create javascript functions for tricks videos
Update TrickController Class

Done


Add an implicit not found message for Codec[T]

Coverage remained the same at 83.297% when pulling 3d06e731c583a2eabece9d20aa1c5b52b48d52fd on lloydmeta:feature/codec-implicit-msg into 141f86d985504625ae4e921a341cf36201df8de6 on alexandru:master.

Looks good.


[FEAT] Tree style tab extension keeps tab padding

How do remove the tabs bar? I have hidden them because I prefer to use Tree Style Tab (like Safari on iPadOS 15), but it remains visible empty.

The buttons for window are a little too small, and sometimes I miss click, how do I reset the default to Windows or make them bigger?

It sounds like you have two questions:
For the first one, the following CSS code may fix your issue:
#TabsToolbar{  height:0px !important; } toolbar{ min-height: 0px !important; }
To resize the menubar icons, you can edit the padding here:
https://github.com/AdamXweb/WhiteSurFirefoxThemeMacOS/blob/a6dad249809c45124e5ea0f060f06a710ea8d431/chrome/WhiteSur/parts/windows.css#L4-L12
You can follow these instructions to edit the browser live:
https://www.reddit.com/r/FirefoxCSS/comments/73dvty/tutorial_how_to_create_and_livedebug_userchromecss/


Reading in date from CSV file

Short description explaining the high-level reason for the new issue.
Current behavior
In the forcing file (CSV format), time appears to be a standard datetime string like:
2015-12-01 00:00:00
but it is being read and treated as a variable with "long" type.
Steps to replicate behavior (include URLs)
function in bmi_cfe.c to parse the datetime string called parse_aorc_line_cfe(), but it isn't finished (has a TODO).
There is also this line in bmi_cfe.h:
long int time; //TODO: type?           // seconds since 1970-01-01 00:00:00.0 0:00
It looks like the goal was to convert the datetime string in the CSV file to  "seconds since 1970-01-01 00:00:00.0 0:00".

jmframe's branch has fixed this with Fred's origional parser. https://github.com/jmframe/cfe/blob/3a320046c5d8eb58e3f57d34f255562fd23673a8/src/bmi_cfe.c#L1942, but this creates a Julian date. Is it necessary to have the date in 'Seconds since 1900'? I don't think so, because the frameowork is supposed to be in charge of the clock, when running BMI. right?
Review of code in progress before pull request is submitted.


How do I configure Annotation Processing with this plugin?

Hello,
Thank you for providing this plugin.
Background: One of my users reported an error when compiling a project that uses one particular feature in MapStruct Spring Extensions using Eclipse. Turns out that ECJ handles one part of the annotation processing differently to Javac (but still spec-compliant). So obviously I'd like to fix this and found this plugin which I'd like to help me in reproducing the error. However, it already fails on a previous hurdle. I configured it in this example.
Building the example results in this error:
> Task :examples:external-conversions:compileJava FAILED
----------
1. ERROR in /Users/raimundklein/development/GitHub/mapstruct-spring-extension/examples/external-conversions/src/main/java/org/mapstruct/extensions/spring/example/externalconversions/LocaleInfoDtoMapper.java (at line 6)
	@Mapper(config = MapstructConfig.class, uses = ConversionServiceAdapter.class)
	                                               ^^^^^^^^^^^^^^^^^^^^^^^^
ConversionServiceAdapter cannot be resolved to a type
----------
1 problem (1 error)

The "missing" class is generated during annotation processing. Please note that this part works well inside Eclipse if I remove the @ExternalConversion section which is the one reported as erroneous. If I remove the plugin and use Javac instead, everything is fine. Do I need to add another line for annotation processing, and if so which one?

Hi @Chessray,
I reproduced the issue and can confirm that annotation processors do not work correctly with this plugin. Specifically, no code is generated despite the processors being recognized. I don't know what is causing this issue yet and, unfortunately, I probably won't get around to investigating this until the end of the month.
I've found that a quick (but dirty) fix might be adding the processor to the compileOnly configuration. So, for example
    compileOnly("org.mapstruct:mapstruct-processor:1.5.5.Final")
    annotationProcessor("org.mapstruct:mapstruct-processor:1.5.5.Final")

works.

Here are some clues:
With ECJ (without compile dependency):
Round 1:
	input files: {org.mapstruct.example.SourceTargetMapper,org.mapstruct.example.Target,org.mapstruct.example.Foobar,org.mapstruct.example.Source}
	annotations: [org.mapstruct.Mappings,org.mapstruct.InheritInverseConfiguration,org.mapstruct.Mapper]
	last round: false
Round 2:
	input files: {}
	annotations: []
	last round: true

With ECJ (with compile dependency):
Round 1:
	input files: {org.mapstruct.example.SourceTargetMapper,org.mapstruct.example.Target,org.mapstruct.example.Foobar,org.mapstruct.example.Source}
	annotations: [org.mapstruct.Mappings,org.mapstruct.InheritInverseConfiguration,org.mapstruct.Mapper]
	last round: false
Discovered processor service org.mapstruct.ap.MappingProcessor
  supporting [org.mapstruct.Mapper]
  in jar:file:/C:/Users/linha/.gradle/caches/modules-2/files-2.1/org.mapstruct/mapstruct-processor/1.5.5.Final/897f6f115930b936287bef552bf5fe28cc64717d/mapstruct-processor-1.5.5.Final.jar!/
Processor org.mapstruct.ap.MappingProcessor matches [org.mapstruct.Mapper] and returns false
Round 2:
	input files: {org.mapstruct.example.SourceTargetMapperImpl}
	annotations: [javax.annotation.processing.Generated,java.lang.Override]
	last round: false
Processor org.mapstruct.ap.MappingProcessor matches [] and returns false
Round 3:
	input files: {}
	annotations: []
	last round: true

With Javac:
Round 1:
	input files: {org.mapstruct.example.Foobar, org.mapstruct.example.Source, org.mapstruct.example.SourceTargetMapper, org.mapstruct.example.Target}
	annotations: [org.mapstruct.Mapper, org.mapstruct.Mappings, org.mapstruct.InheritInverseConfiguration]
	last round: false
Processor org.gradle.api.internal.tasks.compile.processing.TimeTrackingProcessor matches [/org.mapstruct.Mapper] and returns false.
Processor org.gradle.api.internal.tasks.compile.processing.SupportedOptionsCollectingProcessor matches [/org.mapstruct.Mappings, /org.mapstruct.Mapper, /org.mapstruct.InheritInverseConfiguration] and returns false.
Round 2:
	input files: {org.mapstruct.example.SourceTargetMapperImpl}
	annotations: [javax.annotation.processing.Generated, java.lang.Override]
	last round: false
Processor org.gradle.api.internal.tasks.compile.processing.TimeTrackingProcessor matches [] and returns false.
Processor org.gradle.api.internal.tasks.compile.processing.SupportedOptionsCollectingProcessor matches [java.compiler/javax.annotation.processing.Generated, java.base/java.lang.Override] and returns false.
Round 3:
	input files: {}
	annotations: []
	last round: true


Revised dispatching code ported to v7

Fixes #888.

Are the .travis.yml changes required for this PR?

Yes. See comments here in the thread for #888. A relatively recent compiler is required, even for Swift 3, so the test configuration has to change.
This .travis.yml also has some support for harvesting build artifacts (for Travis debugging) and auto-building arbitrary branches. Those features have no effect if you don't define Travis environment variables to enable/configure them. But if you don't want to accept those changes, you can just reverse commits 0b936fd, f78eaf1, and 0da820a. (Or I can prepare a branch with those changes.)

K I see, is it possible to lose all the rearrangements? It's hard for me to reason about the changes in the travis file because of this. And I'm nervous about the changes there because I have spent gosh knows how many hours on it and it's fiddly and flakey and breaks mean that are CI testing is less certain.

I have pushed the start of v7, and I have stripped it quite a bit, my thinking being that v7 can be modernized, and we'll maintain v6 as the back-compat version.
This means we have a lot less worry about older versions having ambiguity for this patch.
Sorry that the branch now needs merging again. If you like, I can do it.

There doesn’t seem to be an Xcode project at the current V7 tip. Is this the intended state?

There doesn’t seem to be an Xcode project at the current V7 tip. Is this the intended state?

Yes, you have to generate it: swift package generate-xcodeproj

Don’t worry about CI, it's not going to work until Travis have an Xcode 10.2 image.

Looks ready to merge to me, what you say?

Yes, OK to merge if you're ready for it.
There are a couple of issues (that we already talked about) yet to address, so I want to be sure you're aware that this is still WIP code from my perspective. (Though it should be 100% working and near-final API.) If you'd rather defer until I have something that looks completely done to me, that would be fine too. I mostly just wanted to get synced with the v7 line and get a sense of the v7 changes before finalizing.


Add terminology param to tsne db visualization method

@mehmetcanay We need this for pdataviewer right?

Nice to have, but only if you have time :)


Handling of Ensemble Model output in CovJson responses

Ensemble Predictions Systems (EPS) are common datasets in the Met. CovJSON has no domain to handle them. EPS are handled as normal timeseries with an extra dimension (members)
It is possible to define new domains or dimensions by using extensions ( check https://covjson.org/cookbook/ )
Extensions should be grouped in prefixes. If one registers prefixes at https://covjson.org/prefixes/ it would be interoperable.
An attempt for a prefix based domain/axis is made in the repsonses of
https://interpol-dev.met.no/collections/roms-barents-eps/instances
{
"type": "Coverage",
"domain": {
"type": "Domain",
"domainType": "eps:EnsemblePointSeries",
}}

with an axis:
"ranges": {
"current_direction": {
"type": "NdArray",
"dataType": "float",
"axisNames": [
"t",
"eps:member"
],

This is just work at a dev-state. There is a need for handling EPS in the community - the important thing is to agree on something

This should probably be synced with allowing for custom dimensions for ensemble members in collections, so the naming is consistent.

It might make sense to register a prefix common to this profile or rather to EUMETNET, so if we extend CoverageJSON with multiple properties we can reuse that prefix. Like eumetnet:EnsemblePointSeries and eumetnet:foo

How about using coverageCollections instead?

It would be a big advantage if ensemble data can be represented without defining a custom domainType, so I think its worth exploring. @juerg1s Could you create an example CoverageJSON for this?


Remove events from ActivityHandler that are too channel specific

This is a Javascript port of the changes in dot-net#1380
Remove all but message, event, and conversationupdate handlers, allow all other incoming activities to be handled by the unrecognizedactivity handler.

Pull Request Test Coverage Report for Build #1968

3 of 6 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 87.458%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-core/src/ActivityHandler.ts
3
6
50.0%

Totals

Change from base Build #1966:
0.05%

Covered Lines:
2995

Relevant Lines:
3295

💛  - Coveralls


openrr-gui: Improvement of joint_position_sender

Features

[ ] Add text box(?) to set the duration. https://github.com/openrr/openrr/issues/101#issuecomment-777147645 (Currently I ordered to use 100msec)
The unit of time should be f64 sec.

Bugfixes

[x] Depending on how to move slider, response on urdf-viz side is very slow #108; fixed by #130

Resolve TODOs

[ ] https://github.com/openrr/openrr/blob/1896893a5bed82ae0843188e864f8891054e2ccf/openrr-gui/src/joint_position_sender.rs#L52-L53

[ ] https://github.com/openrr/openrr/blob/1896893a5bed82ae0843188e864f8891054e2ccf/openrr-gui/src/joint_position_sender.rs#L139-L142

[ ] Decide how to handle errors.
https://github.com/openrr/openrr/blob/1896893a5bed82ae0843188e864f8891054e2ccf/openrr-gui/src/joint_position_sender.rs#L208-L209
https://github.com/openrr/openrr/blob/1896893a5bed82ae0843188e864f8891054e2ccf/openrr-gui/src/joint_position_sender.rs#L301-L302

[x] done in #134. https://github.com/openrr/openrr/blob/1896893a5bed82ae0843188e864f8891054e2ccf/openrr-gui/src/joint_position_sender.rs#L238-L239

[ ] (Blocked on upstream) https://github.com/openrr/openrr/blob/1896893a5bed82ae0843188e864f8891054e2ccf/openrr-gui/src/joint_position_sender.rs#L367

[ ] (Blocked on upstream; done in https://github.com/hecrj/iced/pull/719; waiting for new release of iced) https://github.com/openrr/openrr/blob/1896893a5bed82ae0843188e864f8891054e2ccf/openrr-gui/src/error.rs#L16-L18

[ ] (Blocked on upstream) https://github.com/openrr/openrr/blob/1896893a5bed82ae0843188e864f8891054e2ccf/openrr-gui/src/style.rs#L1-L2

Request:
Add text box(?) to set the duration. (Currently I ordered to use 100msec)
The unit of time should be f64 sec.

We also need to rethink when to apply the joint position text box updates.
Perhaps it is preferable to request an explicit enter key (using iced::TextInput::on_submit).
Currently, it is updated every time you type a new character. (For example, if you try to type 1.35, joint_position_sender will send 1, 1.3, and 1.35.)


feat: Adding CDC sample

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #2331  ☕
If you write sample code, please follow the samples format.

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.284 s <<< FAILURE! - in com.example.bigquerystorage.JsonWriterStreamCdcIT
[ERROR] com.example.bigquerystorage.JsonWriterStreamCdcIT.testJsonWriterStreamCdc  Time elapsed: 1.277 s  <<< ERROR!
java.io.FileNotFoundException: src/test/resources/NewCustomers.json (No such file or directory)
	at java.io.FileInputStream.open0(Native Method)
	at java.io.FileInputStream.open(FileInputStream.java:195)
	at java.io.FileInputStream.<init>(FileInputStream.java:138)
	at java.io.FileInputStream.<init>(FileInputStream.java:93)
	at java.io.FileReader.<init>(FileReader.java:58)
	at com.example.bigquerystorage.JsonWriterStreamCdc.getRecordsFromDataFile(JsonWriterStreamCdc.java:164)
	at com.example.bigquerystorage.JsonWriterStreamCdc.main(JsonWriterStreamCdc.java:79)
	at com.example.bigquerystorage.JsonWriterStreamCdcIT.testJsonWriterStreamCdc(JsonWriterStreamCdcIT.java:70)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	```


missing documentations for cli package

Currently no available documentation. Would be nice to have docs. Maybe, create a make docs folder.

I would be helpful to move the examples currently shown here to a new docs directory