Supporting multiple api keys for multiple apps

Hey,
Current implementation resolves fcm channel with the fcm key from the services config, which, at least within my knowledge with the framework, stops me from setting a custom api key (or an alias for that api key for that matter) for a specific notification.
What would be the best way to achieve supporting multiple api keys within a single laravel project?

That functionality currently doesn't exist with this package.

https://github.com/ankurk91/fcm-notification-channel


[Bug]: panic: runtime error: invalid memory address or nil pointer dereference

TLS client version
v1.4.0
System information
windiows 10
Issue description
when i use streamOutputPath options
Steps to reproduce / Code Sample
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x7ff936f0fcb4]
goroutine 17 [running, locked to thread]:
github.com/bogdanfinn/tls-client/cffi_src.(*TLSClientError).Error(0x1148c31d745a6199?)
/Users/bogdan/Development/Solem8s/tls-client/cffi_src/types.go:20 +0x14
github.com/bogdanfinn/tls-client/cffi_src.(*TLSClientError).Error(...)
/Users/bogdan/Development/Solem8s/tls-client/cffi_src/types.go:20
main.handleErrorResponse({0xc00001c5d0, 0x24}, 0x1, 0xc00005d270)
/Users/bogdan/Development/Solem8s/tls-client/cffi_dist/main.go:283 +0xcf
main.request(0x0?)
/Users/bogdan/Development/Solem8s/tls-client/cffi_dist/main.go:259 +0x795

@imblowsnow i pushed a commit on the master branch adressing this issue. please let me know if it fixes the problem for you.

Can you release a version?

@imblowsnow i pushed a commit on the master branch adressing this issue. please let me know if it fixes the problem for you
@bogdanfinn Can you release a version?


Add $ReadOnlyArray to accepted input types

I use $ReadOnlyArrays extensively for immutability safety, this change allows us to use them with maybe!

Thanks @Leeds-eBooks ! 👍


i18n(zh-cn): update guides/styling.mdx

What kind of changes does this PR include?

Do some minor content fixes,translate the part of  Production.

Description

update the translation

@liruifengv pls review

PR 描述分类改一下


Source links are broken

Every link for my project that I've clicked from codetriage is a 404.
For example, https://www.codetriage.com/doc_methods/353453
The source link goes to https://github.com/wikieducationfoundation/wikiedudashboard/blob/6f95bf57b52e382f7212723fb5a9daace5271743/#L65

It looks like that's a valid SHA https://github.com/WikiEducationFoundation/WikiEduDashboard/commit/6f95bf57b52e382f7212723fb5a9daace5271743
However it needs a file too.
It looks like this is due to the way that i'm generating the file name.
i'm downcasing the repo names but not the file url
irb(main):016:0>     _absolute, _match, relative = raw_file.partition(/(\/|^)#{repo.name}\//)
=> ["/tmp/d20171121-4-ncqlpn/WikiEduDashboard/app/models/classroom_program_course.rb", "", ""]
irb(main):017:0> repo.name
=> "wikiedudashboard"

Patch is incoming

Fixed, we've got auto deploy enabled with passing builds on master, should be live in 30 minutes or so.


Add license info

Adds MIT license info to the CSS guide since it was missing before.
Addresses https://github.com/airbnb/css/issues/62
@lencioni @ljharb

Thanks! What do you think about adding this as a separate LICENSE.md file instead? e.g. https://github.com/airbnb/javascript/blob/master/LICENSE.md


Enable passing a list for DPatch's patch_shape

Is your feature request related to a problem? Please describe.
The DPatch attack requires  that the patch_shape arg passed is a tuple, however it'd be very convenient if one could pass a list for this arg given that patch_shape (in my case, and likely many cases) is being pulled from a JSON file.
Describe the solution you'd like
The check could be written as if not isinstance(self.patch_shape, (tuple, list)):  as opposed to the current  if not isinstance(self.patch_shape, tuple):

I've verified that np.random.randint(), where patch_shape is passed to, can take a list or tuple for the size arg (Numpy 1.19.1).


[Suggestion] Text streaming for OpenAI

This PR implements real-time text streaming capability for the OpenAI provider, allowing users to see LLM responses as they are generated - similar to the ChatGPT interface.
Validation

I self-validated it through the example in examples/generate_stream_text.py. The newly created generate_stream_text() prints to the console via streaming, chunk by chunk.

Future

If this PR accepted, I'd like to implement it for other providers.

#33

Summary by CodeRabbit

New Features

Introduced real-time text generation and streaming functionality.
Added a generate_stream_text method to facilitate immediate output from specified language models.
Enhanced the OpenAI integration to support streaming responses.

Bug Fixes

No bug fixes were included in this release.

Documentation

Updated documentation to reflect the new streaming text generation capabilities.

why don't we change it to generate_text(..., stream=True)? Thoughts?

Merged this into streaming branch in the meantime. Will play with it.

✨🍰✨

why don't we change it to generate_text(..., stream=True)? Thoughts?

I think that can work as well. I'm indifferent between two choices. In case they're to be merged, the return type should become Generator | str, instead of str and Generator separately. Also, the response return logic should be conditioned by if/else. Another consideration is when adding logging and caching mechanisms. For the streaming, they should collect all the chunks, and then combine them when the streaming ends.
I'm not sure which decision would make it easier to handle caching/logging situations.

already merged and released :)

Ah, okay :)


First part of the layers content view

Instead of creating a super huge PR, I've decided to start with this and then keep going with the proper analysis form. In short:

Show the content of the selected layer (screenshot above ^^^).
Updated CartoAssets to the last version (cc @piensaenpixel).
Keep the state of the first stack layout view (fixes #6722).
Fixes a problem related with vizJSON overlays (fixes #6833).

CR: @viddo
cc @javierarce

I have pending to add first tests for layer-view and layers-view classes.

Created a ticket for layers-view and layer-view tests (https://github.com/CartoDB/cartodb/issues/6891).
How do you like it?

:shipit:


Verbs w 0 copies

Verbs implementation to use direct tensor writes (0 copies)
Motivation:
Following HKUST research on the use of GPU direct, and their GDR implementation, we wish to adopt the 0 copies approach and apply it to the current verbs implementation, while keeping the current implementation advantages, such as configurability and the use of RDMA for control messages.
Performance:
Compared with the current GRPC, verbs and GDR implementation, the result implementation gave the best performance for every model, with any number of nodes. For VGG16 on 8 nodes with 4 P100 GPUs each, the prototype beat the second place by over 15%.
Implementation requirements:

Tensor writes need to be done directly from the source Tensor to the destination Tensor, with no memory copies in between. This should be done for all DMAble tensors which are located either on CPU or on a RDMA compatible GPU device (GPU direct).
Non DMAble tensors (CanMemCopy == false) will be serialized to proto on the sender side, RDMA written to a registered buffer on the receiver side, and then deserialized by the receiver.
Tensors which are located on a non-RDMA-compatible GPU, will be RDMA written to a registered CPU proxy buffer on the receiver side, and then copied to GPU by the receiver.

Implementation constrains:
For best stability and proof of correctness, we will divide the implementation to two stages:

At first stage we will keep changes to the current implementation to the minimum possible. The expense will be that we may have unused or unnecessary code leftovers, which may also affect performance.
At second stage, we will re-iterate over the code and remove irrelevant code parts.
The design of the solution aims that we will achieve both stages with relative ease.

Design guidelines:

Since we do not want to do any unnecessary memory copying, we will no longer allocate a fixed CPU buffer as the destination for the RDMA write. Instead we will do the writing directly to the result tensor, or if the result tensor is on a device which does not support RDMA, we will do the writing to a proxy CPU tensor and then copy its content to the result tensor.
The address of the destination Tensor needs to be sent to the sender side for writing, meaning that the result/proxy tensor should be pre-allocated on the receiver side, prior to sending the tensor request. In order to do that, we need to know its meta-data, i.e. shape and data-type for DMAble tensors, and proto-size for serialized tensors. Unfortunately, this information is only available on the sender side which complicates manners. In order to avoid sending extra messages for querying the meta-data on each step, we store a local meta-data cache per tensor. Based on the assumption that the meta-data of a tensor rarely changes between steps, we expect that on most times the cache will only be updated once. When the sender receives a request for a tensor, if it is the first time this tensor is requested, or in the rare case that the meta-data did change, the sender will first send a meta-data response, on which the receiver will update the local cache, and reallocate the result/proxy tensors if required. When the receiver sends the tensor request, it will contain also the meta-data currently stored in its local cache, so the sender can compare it to see if there was a change.
When the sender writes the tensor content to the result tensor, no additional data is being written with it. That means we need to reside on ibverbs immediate (uint32_t) to indicate which request we are responding to (in order to trigger the receive callback). The easiest and most elegant way is to key the recv callback with a unique request_index (uint32_t), instead of the current key_with_step_id (string).
Since the sender no longer writes the tensor from/to fixed buffers, we no longer need to schedule the writes using the local/remote status. In addition we no longer rely on the RmdaTensorBuffer members as the source/destination addresses and rkey/lkey. Instead, each RdmaTensorBuffer will hold multiple "Response" objects (one per step-id), from which we derive destination address and rkey. The source address and lkey are always the ones of the source Tensor.
With the addition of tensor pre-allocation, we noticed there is a large code similarity between sending the first tensor request and re-sending the request in case of meta-data changes. After implementing a common method for tensor pre-allocation, it turned out that implementation becomes much simpler by encapsulating the process of request sending/re-sending, meta-data response callback and content response callback, all in a single "Request" class. The request class holds all the relevant request information, which reduces excessive parameter passing and lambda capturing. This decision is purely for elegance and code simplicity, and we decided to implement it in first stage because it makes the implementation much easier.
At phase 2, we adopt that approach for the sender side as well, by encapsulate all the send and resend logic in the "Response" class (and remove the RdmaTensorBuffer class completely). This should make our design easier to understand, and also hold common notions with the rest of the distributed implementations.

New types/classes:

enum RdmaImmDataType - Immediate types to distinguish between different RDMA writes on the remote side. Ack writes and control-message writes have a fixed immediate value. The rest of the writes are tensor writes and the immediate value is the relevant request index.
enum  RdmaWriteIDType    - Types to distinguish between different RDMA write-complete events: Ack, control message, tensor DMA write and tensor proto write.
class RdmaWriteID        - Context for RDMA write complete events. Holds the RdmaWriteIDType and additional data.
class RemoteAddressContext - Remote address information (address + mr). Will be passed as write context for tensor proto writes.
class RdmaTensorMetaData - Meta-data for a tensor (type, shape, is_dead, proto_size).
class RdmaMemoryMgr      - Manages the meta-data cache, and the registered memory regions.
class RdmaTensorRequest    - Holds and manages information for a single tensor request throughout the entire receive cycle. API:

Start()                - Start the request sequence.

Allocate the result tensor (and proxy tensor if required).
Send RDMA_MESSAGE_TENSOR_REQUEST to the remote side.

RecvTensorMetaData()   - Receive meta-data from the remote side.

Update the local meta-data cache.
Reallocate the result tensor (and proxy tensor if required).
Re-send the request to the remote side.

RecvTensorContent()    - Receive tensor content from the remote side (RDMA write was completed).

Decode proto if required and/or move to GPU if the content was not written to it directly (GPU direct is not avaliable).
Invoke the done callback.

class RdmaTensorResponse   - Holds and manages information for a single tensor response throughout the entire send cycle. API:

Start()                - Start the response sequence.

Find the tensor in the local tag-match table.
Compare the tensor's meta-data to the meta-data in the message (taken from the requester's local cache).

If meta-data changed:

Clone the tensor to be sent later.
Send a meta-data update message and wait for re-request.

Else:

Send the tensor's content (using direct RDMA write).

Resume()               - Resume the response sequence after a re-request. Send the tensor's content that was cloned earlier.
Destroy()              - Destroy the response's resources and remove it form the pending list.

Protocol changes:
The protocol messages themselves will remain mostly unchanged at the first stage, but will be used differently, as described below. The current messages structures already have most of the required fields for the new implementation. The only change is the "buffer_size" field which is no longer used since we are no longer sending additional information with the tensor, and thus it is now always equal to the "tensor_bytes" field. Instead, we use that field to pass the "request_index".
Message structure:

type
name_size
name
step_id
request_index
remote_addr
rkey
is_dead
data_type
tensor_shape
tensor_bytes

1B
2B
512
8B
8B
8B
4B
1B
XB
XB
8B

RDMA_MESSAGE_TENSOR_REQUEST  - (receiver ==> sender) The original tensor request.

type - The message type.
name (name_size) - Name of the requested tensor.
step_id - Step ID.
request_index - Request index.
remote_addr/rkey - Address/rkey of the result/proxy tensor. Irrelevant for first-time request.
is_dead/data_type/tensor_shape/tensor_bytes - The current meta-data as stored in the receiver local cache. The sender will use that information to know if the receiver's cache requires updating.

RDMA_MESSAGE_BUFFER_REQUEST  - (sender ==> receiver) The meta-data update message in case meta-data had changed (or if it is the first time the tensor is requested).

type - The message type.
request_index - Request index.
is_dead/data_type/tensor_shape/tensor_bytes - The up-to-date meta-data.

Note: At phase 2 this message is renamed to - RDMA_MESSAGE_META_DATA_UPDATE.

RDMA_MESSAGE_BUFFER_RESPONSE - (receiver ==> sender) Tensor re-requset after meta-data update and reallocation of result/proxy tensors.

type - The message type.
name (name_size) - Name of the requested tensor.
step_id - Step ID.
request_index - Request index.
remote_addr/rkey - Address/rkey of the reallocated result/proxy tensor.
is_dead/data_type/tensor_shape/tensor_bytes - The new meta-data. Will be removed in the next phase.

Note: At phase 2 this message is renamed to - RDMA_MESSAGE_TENSOR_RE_REQUEST.

RDMA_MESSAGE_TENSOR_WRITE    - (sender ==> receiver) No longer sent. There is only a direct write of the tensor content to the result/proxy tensor. Request index passed as the immediate value of the write.

RDMA_MESSAGE_TENSOR_IDLE     - (receiver ==> sender) No longer sent.

Phase 1:

Phase 2:

Second stage optimizations:

Remove unused code leftovers - Done.
Remove the ACK buffer completely, since we can rely completely on its immediate value - Done.

Future optimizations:

Map the tensor names to indexes, to significantly reduce the request message size.
Understand the purpose of empty tensors and if we can skip remote fetching for them.
Consider concatenating multiple requests and/or using multiple message buffers.
Consider a no-request architecture.

@eladweiss  Thanks for your job.
Why not change MklCPUAllocator to VisitableAllocator ？

@sunnygao1980 @byronyi @yanivbl6 Indeed, it would be the best solution. However it will require us to extend outside of the contrib zone. @byronyi  do you think it is the best approach?

See relavant discussion here: https://github.com/tensorflow/tensorflow/pull/11392#issuecomment-320142984, https://github.com/tensorflow/tensorflow/pull/11392#issuecomment-320273255, and https://github.com/tensorflow/tensorflow/pull/11392#issuecomment-320324981.

@byronyi @yanivbl6 @shamoya Thanks. This is super relevant.

I think the comment https://github.com/tensorflow/tensorflow/pull/11392#issuecomment-320273255 is wrong. The MklCpuAllocator is not visitiable. At least not on latest version.
@poxvoculi mentioned here https://github.com/tensorflow/tensorflow/pull/11392#issuecomment-320324981 that there might be a discussion about making MklCpuAllocator and DefaultCpuAllocator visitiable. Any updates about that?

I've started testing an internal change to convert MklCpuAllocator to a VisitableAllocator.  I don't foresee any problem with making this change, but it's possible there's a difficulty somewhere.  I'm less confident that DefaultCPUAllocator can be changed that way, since it may need to be a very simple type for use in some contexts, e.g. mobile devices.   @eladweiss : would your needs be satisfied by changing just MklCpuAllocator?

@poxvoculi Yes, that would be great.
We'll still need to override the CPU registration for DefaultCPUAllocator, like Bairen mentioned here, but other than being a little hacky, I don't see it posing a real problem.


Pod to pod communication through team network only uses one interface at a time instead of all in parallel

Our 3 node k8 cluster uses a bonded network consisting of 4 25Gbps interfaces (setup for loadbalancing) for internal communication and 1Gbps interface for external communication . When we ran parallel iperf3 node-to-node tests we are able to achieve an overall bandwidth much greater than 25Gbps. The iperf3 tests consisted of setting up 4 iperf3 servers on each node and 4 clients on each node and ensured node-to-node communication with the following iperf3 client to server relationship  (node1->node2, node2->node3, node3->node1)
We also ran the above iperf3 test within a pod on each of the 3 nodes

pod1 on node1, pod2 on node2, pod3 on node3
4 iperf3 server on each pod
4 iperf3 clients on each pod
iperf3 client-to-server relationship: pod1->pod2, pod2->pod3, pod3->pod1

Expected Behavior
We should be getting > 25Gbps bandwidth for pod to pod communication
Current Behavior
We summed up the individual test bandwidths and got ~22Gbps which seems to imply that pod to pod communication only uses one of the 25Gbps interfaces at time
Also, ethtool on a calico interface gives us Speed: 10000Mb/s
Possible Solution
Not sure how to configure calico to use multiple interfaces in the team network for pod to pod communication
Steps to Reproduce (for bugs)

Context

We want to ensure that we get the network performance between pods that we are expecting
Your Environment

calico v3.9
kubernetes version: 1.15.4
RHEL 7.6
Calico v3.9 manifest changes

veth_mtu=9000
CALICO_IPV4POOL_IPIP=Never
CALICO_IPV4POOL_CIDR=<IP_ADDRESS>/16 (to match kubeadm init value)

Did you configure auto-detection to run Calico on the bonded interface? By default, it may not select it depending on how Calico's interface auto-detection selects the interface.

We verified that calico is using the proper interface by measuring bandwidth for the device and through calicoctl. Further tests seem to indicate that the multiple interfaces in the team network interface are all used for pod to pod communication but the speed is throttled if a calico interface is used by more than one iperf test at a time.  Performing 2 iperf tests between 2 separate pairs of pods allows us to get 50Gbps while 2 iperf tests in parallel from a single pair of pods doesn't.

@xsaardo I'm not sure I understood your scenario correctly but if you have two iperf sessions sharing the same 50Gb pipe, I'd expect throughput to be around 25Gb/s. Could you please clarify if that's the case?

@rafaelvanoni We were able to get 50Gbps for host to host communication with 2 parallel iperf tests but only 25Gbps for pod to pod communication. However, we resolved the issue by assigning more cores/memory to those pods and saw 50Gbps as well. Thanks though!


externalpipe patch

hi i wanted to apply the externalpipe patch, it's not a big patch or anything and reading the code it adds/modifies it looks as if it should work smoothly, the make install showed no errors, but every time i try running the externalpipe with a script it just segfaults which is strange

these are the config.h lines added:
static char *copyoutput[] = { "/bin/sh", "-c", "st-copyout", "externalpipe", NULL };

{ MODKEY,               XK_o,           externalpipe,   {.v = copyoutput } },

and this is the script used with externalpipe (st-copyout):
#!/bin/sh
# Using external pipe with st, give a dmenu prompt of recent commands,
# allowing the user to copy the output of one.
# xclip required for this script.
# By Jaywalker and Luke
tmpfile=$(mktemp /tmp/st-cmd-output.XXXXXX)
trap 'rm "$tmpfile"' 0 1 15
sed -n "w $tmpfile"
sed -i 's/\x0//g' "$tmpfile"
ps1="$(grep "\S" "$tmpfile" | tail -n 1 | sed 's/^\s*//' | cut -d' ' -f1)"
chosen="$(grep -F "$ps1" "$tmpfile" | sed '$ d' | tac | dmenu -p "Copy which command's output?" -i -l 10 | sed 's/[^^]/[&]/g; s/\^/\\^/g')"
eps1="$(echo "$ps1" | sed 's/[^^]/[&]/g; s/\^/\\^/g')"
awk "/^$chosen$/{p=1;print;next} p&&/$eps1/{p=0};p" "$tmpfile" | xclip -selection clipboard

Please make a repository with the patch applied and I'll fix it there.


unable to start a WebDriver session

when I exec 'npm run protractor', I got 'unable to start a WebDriver session'.
Error is below:
Using the selenium server at http://localhost:4444/wd/hub
[launcher] Running 1 instances of WebDriver
ERROR - Unable to start a WebDriver session.

d:\xinliangwang\repo\angular-seed\node_modules\protractor\node_modules\selenium-
webdriver\http\index.js:145
      callback(new Error(message));
               ^
Error: ECONNREFUSED connect ECONNREFUSED
    at ClientRequest.<anonymous> (d:\xinliangwang\repo\angular-seed\node_modules
\protractor\node_modules\selenium-webdriver\http\index.js:145:16)
    at ClientRequest.emit (events.js:95:17)
    at Socket.socketErrorListener (http.js:1552:9)
    at Socket.emit (events.js:95:17)
    at net.js:441:14
    at process._tickCallback (node.js:442:13)
==== async task ====
WebDriver.createSession()
    at Function.webdriver.WebDriver.acquireSession_ (d:\xinliangwang\repo\angula
r-seed\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\web
driver.js:149:22)
    at Function.webdriver.WebDriver.createSession (d:\xinliangwang\repo\angular-
seed\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\webdr
iver.js:123:30)
    at Builder.build (d:\xinliangwang\repo\angular-seed\node_modules\protractor\
node_modules\selenium-webdriver\builder.js:294:22)
    at DriverProvider.getNewDriver (d:\xinliangwang\repo\angular-seed\node_modul
es\protractor\lib\driverProviders\driverProvider.js:50:7)
    at Runner.createBrowser (d:\xinliangwang\repo\angular-seed\node_modules\prot
ractor\lib\runner.js:178:37)
    at d:\xinliangwang\repo\angular-seed\node_modules\protractor\lib\runner.js:2
59:24
    at _fulfilled (d:\xinliangwang\repo\angular-seed\node_modules\protractor\nod
e_modules\q\q.js:797:54)
    at self.promiseDispatch.done (d:\xinliangwang\repo\angular-seed\node_modules
\protractor\node_modules\q\q.js:826:30)
    at Promise.promise.promiseDispatch (d:\xinliangwang\repo\angular-seed\node_m
odules\protractor\node_modules\q\q.js:759:13)
[launcher] Process exited with error code 1

Config is below:
exports.config = {
  seleniumAddress: 'http://localhost:4444/wd/hub',

  allScriptsTimeout: 11000,

  specs: [
    '*.js'
  ],

  capabilities: {
    'browserName': 'chrome'
  },

  baseUrl: 'http://localhost:8000/app/',

  framework: 'jasmine',

  jasmineNodeOpts: {
    defaultTimeoutInterval: 30000
  }
};

@iamisti i ran 'webdriver-manager start' command on command prompt but it didn't fix my issue? Could you please take a look on http://stackoverflow.com/questions/29294282/protractor-error-unable-to-start-a-webdriver-session

@NilapuAnusha I'm sure you didn't start 'webdriver-manager' or at least you close it before you run your tests.
Make sure you open it in an other command prompt, and when it runs, run your selenium tests and it should work.

@iamisti Yes. That is true. When i start protractor test case running before that i need to run webdriver-manager parallel in other command prompt but my doubt is previously i didn't ran webdriver-manager start parallel to protractor. I just started webdriver-manager after that i stopped. Every time i didn't that webdriver-manager only once first time installation

replace:
seleniumAddress: 'http://localhost:4444/wd/hub'

with:
seleniumServerJar: '../node_modules/protractor/selenium/selenium-server-standalone-2.45.0.jar'

This solves the problem by launching the selenium standalone server jar directly.


when execute “cleos push transaction”，generate an "Error 3200006: invalid http request"error

when execute “cleos push transaction”，generate an "Error 3200006: invalid http request"error

Judging by the name of the json file you're trying to use, you're trying to upload a contract to the chain.  Use cleos --print-request set code <account> <contract-dir> to see the format of the JSON required to do so.  The contents of the file you are using is substantially incomplete.


System.Data.SqlClient project in solution view is distorted in main

Comparing the last state of changes in branch (my copy): https://github.com/dotnet/maintenance-packages/tree/cheena/sds-new
to latest in main, I am observing the System.Data.SqlClient project is now distorted in main branch (both src and test projects).
I think the last set of changes added to the PR have changed things for System.Data.SqlClient project, and excluded source files.
Below commits I'm looking at are likely causing issues:
https://github.com/dotnet/maintenance-packages/pull/115/files/d149b98940f1800f2c006ac91753ee94edd6aa5b..31110cdf4cee678762ce753b903f48022e552741
cc @ViktorHofer

That's a project-system / VS issue: https://github.com/dotnet/project-system/issues/935
Submitted https://github.com/dotnet/maintenance-packages/pull/148 to work around that.


Add flag : no need sort raw query data

this branch is very good. gorequest can change my query sort.


stop replacing colon ':' with space+-

Hi
I notice when i download videos contains colon : youtube-dl auto replace it with  - = space + -
i need to only replace : with - as stander not space + -
Why
For Example When i download this play list  https://www.youtube.com/watch?v=tpIctyqH29Q&list=PL8dPuuaLjXtNlUrzyH5r6jN9ulIgZBpdo
Notice most of videos contains : so when i download this playlist from any site or software which use stander replacement of : with -
i get name as 02.Early Computing- Crash Course Computer Science #1.mp4
but when i try to get subtitles i get 02.Early Computing - Crash Course Computer Science #1.en.vtt
Now Subtitle Does Not match video name so no-media will auto-attach it
i use youtube-dl.exe --write-sub --skip-download --yes-playlist --sub-lang="en,ar" -o %(autonumber)02d.%(title)s.%(ext)s https://www.youtube.com/playlist?list=PL8dPuuaLjXtNlUrzyH5r6jN9ulIgZBpdo
So How To Do that and why this strange behavior

Windows does not support : in filenames.

@dstftw i know that it's not my question i ask why the strange behavior of replacing colon with two characters space + dash all download-sites and even Internet Download Manager (IDM) only replace colon with one character which dash

Cause this it's the only way to get idiomatic and file safe form of Section: Subsection as Section - Subsection.


BE AS CLEAR AND CONCISE AS POSSIBLE.
describe the bug
When using the "Focus Mode" enhancement, and the sidebar is collapsed (i.e. focus mode is active) there is a blank bar at the bottom of the window which reduces the visible area of the window. This issue does not occur when the "Focus Mode" enhancement is disabled.
expected behaviour
Even with the sidebar collapsed, the entire window rea should be visible as it was before collapsing it
screenshots
Sidebar Open - Focus Mode Enabled:

Sidebar Closed - Focus Mode Enabled (Notice the blank bar at the bottom):

Expected Behaviour when Sidebar Closed:

platform
Windows 10
Notion Enhancer build 0.10.0-wip

This is intentional - focus mode is intended to be used when in full-screen and you want a no-distraction/blank canvas just to write on, and so if you have empty space on 3 sides it makes sense to make that consistent it with a 4th.
I'll add an option to turn it off, though, because it has confused a couple people.

Thanks a lot!
I get where you're coming from but I personally found that to be quite jarring, having the content terminate before the window/screen edge.
I was having some trouble updating it but after I did it works wonderfully!


Indicate loading when the registration form submits

It will always take bit of time to check if a voter is registered so we should show this visually.
This is especially noticeable when pressing enter to submit the form.

Closing this in favor of the new chat bot concept.


Support need for TCP : +RECEIVE missed event

Hello @MaJerle,
I have send a request on TCP and expecting server to respond.
The server respond too but missed the first reveive to call the function callback.
I have marked the breakpoint in the attached log.
For simulation when i send dummy data from server the 2nd time, it hit the marked breakpoint.
I have tested manytimes and tried many approach. But it always miss the 1st response from the server.
Can you please support. In my real application the server is actually responding once. if missed the important data is lost.
Can you suggest any alternatives to track this receive buffer by application?
Regards,
Samir

Hi @gxnt-samir more info would be necessary. We need to see 2 things:

Actual data from modem
Data visible by your microcontroller or computer. Are you sure that you are not missing any bytes received from the modem?

Hello @MaJerle ,
Thank you for your response.
I am attaching the actual MCU - Modem communication log.

As you can see, the +RECEIVE has been received from Modem interface with the response data, but this received data didnot triggered the event.

Question is rather, did MCU really got these data from the modem? Or was there read data processing error?

This print is executed by the MCU at just before passing to lwgsm_input_process API. You can see my iostream write API just before it.

So, Yes the data is actually receiced by MCU, and its 1460 bytes. The image is croped so the data is not showing full. Do you have any way i can debug further. any specific function or value that can give me any clue.

It is super strange. Would be good to see if you go in to input_process function.


Lambda value regarding relevant topics

I noticed that the Lambda value for relevant words section was always reset to default value (0.6) whenever you change the topic number to show in the visualization. Do you know what might be causing that and how that could be fixed? I tried to change the default value in the visualization in the code, but it did not seem to change that behavior of showing relevant topics. BTW, I was using the bitermplus for TM.

Hello! Could you please post the versions of your packages? (ipywidgets, jupyterlab-widgets, jupyterlab, notebook)
I can't reproduce this bug.


[CI Implementation] - Run unit tests

This resolves #54 and #57
Travis configuration
Run unit tests in Travis
Implemented build status in the readme file

Approved already? Did you really code review this? :scream:

Approved already? Did you really code review this? scream

I really code reviewed the CI part of this PR
My and Martin's commits related to the car, on the other hand, are NOT final, but are already in this branch, and so they were ignored for the purpose of reviewing the code, as it would be pointless to review code that is known to be incomplete

If this pull request is about setting up the CI, why are you also including unrelated (and to make things incomplete) code?

That said, your comments had not come up in my feed before I merged, although they now show as being before the merge

Probably because I started reviewing while this was still not merged.

If this pull request is about setting up the CI, why are you also including unrelated and (to make things worse) incomplete code?

That said, your comments had not come up in my feed before I merged, although they now show as being before the merge

Probably because I started reviewing while this was still not merged.

I understand, I was just saying that I didn't ignore your comments intentionally

If this pull request is about setting up the CI, why are you also including unrelated and (to make things worse) incomplete code?

Because when one makes a PR from a branch, it includes all commits on the branch, and I don't think anyone on the team knows how to remove a commit that has been merged in from another branch. There was a merge in order to get an update to the pom.xml from my personal branch

If this pull request is about setting up the CI, why are you also including unrelated and (to make things worse) incomplete code?

Because when one makes a PR from a branch, it includes all commits on the branch, and I don't think anyone on the team knows how to remove a commit that has been merged in from another branch. There was a merge in order to get an update to the pom.xml from my personal branch

:exploding_head:
I see. Time to let the team know about cherry pick then! :)

I see. Time to let the team know about cherry pick then! :)

Thank you, we will try to improve our practises in the upcoming sprints


[Feature Request]: Add PWA support

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Add support for Progressive Web Application
Record

[X] I agree to follow this project's Code of Conduct
[x] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

please assign me this issue.

@BlossomBreeze25 Have u understood this issue

the server-side infrastructure that powers a PWA


Define: Maturity/Experimental: The project is new, innovative, and in the early stages of development

Define what this means and where we are going to source the data for this
this should be defined like a simple if statement like if number_commits > 100 & project_age > 1year

if (releases_in_last_year <= 2 and
        (monthly_downloads_pypi < 1000 and monthly_downloads_conda < 1000) and
        project_age < 1*365 and
        github_stars <= 50 and
        github_forks <= 10 and
        maintainer is not None and
        license is not None):
        return True

monthly_downloads_pypi < 1000 and monthly_downloads_conda < 1000

what if this package is not hosted by conda?

That should have been an OR statement, thank you for catching that

Definition of Maturity/Experimental can be on these basis :
The package is in early stages of development. It may have frequent breaking changes, limited documentation, and a small user base.
Maturity Parameters:
To determine if a package is "experimental" in terms of maturity, you can define specific conditions based on the parameters discussed. Here are some example conditions you might use in your code:
Conditions for Maturity / Experimental :

Age of the Package:  Checks if the first release date is less than 1 year old.

First Release Date: Less than 1 year old.
Recent Release Date: Frequent recent updates might indicate ongoing development.

Release Frequency:  Checks if the number of releases is fewer than 5.

Number of Releases: Fewer than 5 releases.
Release Interval: Irregular release intervals.

Versioning: Checks if the current version is a pre-release (alpha, beta, RC).

Current Version: Pre-release versions (e.g., alpha, beta, RC).

Development Status: Checks if the development status is marked as "Alpha" or "Beta".

Classifier: Development status marked as "Alpha" or "Beta".

Community and Support:  Checks if the number of contributors is fewer than 3.

Number of Contributors: Fewer than 3 contributors.
Issue Tracker Activity: Checks if the number of open issues is greater than closed issues.


Remove unused RPC commands

I'm currently trying to remove dead code and I noticed that there seems to be a lot of RPC commands that are not listed on the wiki. It could be a documentation miss but if those commands are not currently in use or are obsolete we should consider removing them. It seems that some functionality are only tied to these commands so freeing commands could free up some code.
For example:

joindao
readfeedvalue
daowithdrawalrequest
sendfeed

Would this also involve the removal of the btc & grc price quotes? debug2.log sometimes mentions these.

@grctest If we don't need them we should remove them as well. They are a part of the "getmininginfo" and "network" RPC commands and are not used elsewhere. They have no impact on the client besides that.

Do we need the "cleanchain" command? It's not documented anywhere, not used by any scripts and it's making it trickier to do other changes.

I have started to put together a list of commands and check if they are either used by Gridcoin itself or if they are mentioned on the wiki. It seems that some commands aren't even working.
https://docs.google.com/spreadsheets/d/1H5eadS5c0vD3iFVdY68kan_bRizphBzFmZUyHPt4KNY/edit?usp=sharing
I'll try to finish this list today.

after some searching, i found another instance of it: https://github.com/moxie0/AndroidPinning/blob/master/src/org/thoughtcrime/ssl/pinning/CertificateChainCleaner.java
does that give you any ideas about what it may do/is supposed to do? looks like x.509 something. :)

But please leave in some command to get Team RAC of projects that are in NN.


Adding a new DoubleConstant or LongConstant to the constants pool doesn't make them take up 2 slots

The current Add and Insert methods don't add the same constant twice if needed like this.
This will result in constant indices being misaligned.

The same is true for Remove.


KAFKA-15366: Modify LogDirFailureTest for KRaft

This commit modifies LogDirFailureTest to be compatible with KRaft based JBOD functionality.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

This is the cherry-pick of #14977

Closing this, it was merged in another commit.


[BUILD] will not build with openexr/Imath 3

This is with 8.0.1 and 7.2.3.
[    4s] -- ----------------------------------------------------
[    4s] -- ------------- Configuring OpenVDBCore --------------
[    4s] -- ----------------------------------------------------
[    4s] CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:218 (message):
[    4s]   Could NOT find IlmBase (missing: IlmBase_INCLUDE_DIR) (Required is at least
[    4s]   version "2.2")
[    4s] Call Stack (most recent call first):
[    4s]   /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:582 (_FPHSA_FAILURE_MESSAGE)
[    4s]   cmake/FindIlmBase.cmake:258 (find_package_handle_standard_args)
[    4s]   openvdb/openvdb/CMakeLists.txt:49 (find_package)

Build log here:
https://build.opensuse.org/package/live_build_log/home:pgajdos:openexr3/openvdb/openSUSE_Factory_openexr3/x86_64

The logs indicate that you are having trouble building OpenVDB. But this issue is on the OpenImageIO project. I think maybe you posted to the wrong project?

FYI I'm in the same situation. Most of the packages in Fedora have failed to build with OpenEXR 3.0 but some (many?) of them may be due to Ilm being included in the new imath library. I'll open a new issue if it's something I can't fix on my own.

@lgritz not sure how that happened. Perhaps I had both bug trackers opened. Sorry for the noise.


tor: <IP_ADDRESS> -> <IP_ADDRESS>

Motivation for this change
https://blog.torproject.org/new-release-tor-0415
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Works fine, thank you.


MSAL for Angular 0.1.4 is not recognizing SSO

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Browser:

[x ] Chrome Version 78.0.3904.108 (Official Build) (64-bit)
[ ] Firefox version XX
[ ] IE version XX
[ ] Edge version XX
[ ] Safari version XX

Library version

Library version: MSAL for Angular 0.1.4

Current behavior

Our application (app1) using MSAL for Angular doesn’t recognize the SSO from our other application (app2 non MSAL) when it should.  Our app2 application sign in has set the x-ms-cpim-sso cookie but the SSO is not successful. Our B2C configuration is correct. So from app2 (non MSAL) to app1(MSAL) SSO does not work. But from app1(MSAL) to app2(non MSAL) the SSO is recognized.
I tried setting the login_hint. Put this didn’t work and it is unclear in the documentation on how to do this on the MSAL for Angular API's. It should detect the SSO and authorize the signed in user.
Expected behavior

The request should not have the prompt=select_account and MSAL is setting this. It should detect the SSO and authorize the signed in user.
Minimal reproduction of the problem with instructions

@pasanenl This is a known shortcoming of MSAL Angular, but will be addressed soon, as we are currently working to upgrade MSAL Angular to use MSAL 1.x, where this works as expected. I'll post an update here when there is a version you can try.
We'll also make sure to make it more clear in the documentation how to do this.


Add a space after a dot

Making the world more typographically pleasant to the eye, one space at a time. 💖

Thanks, @jpetazzo :)


System.Text.Json should replace Newtonsoft.Json

System.Text.Json is built-in to .NET now (and is available as a package otherwise). Should probably be recommended learning over the older Newtonsoft.Json package.
Article to link to for learning how to migrate: https://learn.microsoft.com/dotnet/standard/serialization/system-text-json/migrate-from-newtonsoft

Yes, I agree! Will update. Thanks!

Fixed


Docker run behind proxy

There is a way to setup kerberos agent to work behind a nginx proxy in the same server on subfolders? i tried differents configuration on nginx without luck.

hey @mattgaviota  can you elaborate a bit more on the use case?

Yes @cedricve, thanks for asking.
I have been trying kerberos agents on docker with kerberos hub pro. For that, i used a docker compose with the agents i needed, then with a nginx i made a reverse proxy to had agent1.mydomain.com, agent2.mydomain.com and so on.
This solution works perfectly, but i noticed that if i want to add more agents, i'll have to do all the configuration, including a new service, new server and a new subdomain.
For those reason i tried to make a single server on nginx, and had different location for different agents, something like agents.mydomain.com/agent1, agents.mydomain.com/agent2 and so on, and at least avoid the subdomain part. And that configuration i couldn't make it work because i  always miss something, 404 errors, redirects, etc.
Thanks in advance, sorry if my english is not clear

Hi @mattgaviota,
I encountered a similar issue with 404 errors and redirects when setting up a reverse proxy.
Have you tried setting the Host header to ensure proper routing?
Here’s an example NGINX configuration (converted from my setup using Caddy as a reverse proxy):
server {
    listen 80;
    server_name agents.mydomain.com;

    location /agent1/ {
        proxy_pass http://agent1.internal/;
        proxy_set_header Host $host;  # Prevent redirect issues

        # Additional configuration...
    }

    location /agent2/ {
        proxy_pass http://agent2.internal/;
        proxy_set_header Host $host;  # Prevent redirect issues

        # Additional configuration...
    }
}

Let me know if this works for your setup!


set seqkit sequencing type in configuration file

When a fastq has a missing 1st entry (due to short reads and trimming) seqkit seq infers that the type of sequences in the file is "unlimit" rather than "dna": https://bioinf.shenwei.me/seqkit/usage/#seq
"unlimit" type sequences cannot be complemented and the files currently returned by --read_transform "reverse_complement" are just reversed. This will mean no reads match template libraries for quantification.
Specify -t dna or --seq-type dna will fix. This could limits quants from working with RNA sequences - is this a potential issue?

Several ways we could tackle this:

code change to seq-kit module -> ideally avoid this so we keep the module generic and working for all sequencing types
update the seqkit module default commands in the configuration file (https://github.com/cancerit/QUANTS/blob/develop/conf/modules.config) -> would require a new release
add the seqkit_seq_options to the parameter JSON we supply at run time -> wouldn't require a new release

@jamieb63 does (3) work ok with a test set of data?


fix(curriculum): update text to include truthy value

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #54541

Description text only

Description and hint text

nn


Use semver as release version standard

Now we are getting close to a stable release it's maybe a good time to switch to semantic versioning
the "rules" are easy en will make the life of the users of this tool easier (on upgrading to versions etc)
X.Y.Z
X: major release - BC breaks possible
Y: minor release - this version bumps will introduce new features without BC break
Z: patch release - bugfix release without features
Don't know if you like this kind of versioning system but it's just a suggestion ;)

I do like semver; PGXN requires it and I wrote SemVer. But it's not great for Perl modules. I plan to switch to  1.xx format with 1.0; it's the simplest version you can have (other than a single integer, I guess).

Ok no problem! But why is semver not great for Perl modules? Just curious :)

It's just asking for more trouble than it's worth, though I have made it work okay for the SemVer module itself. Anyway, I more or less follow these recommendations by @dagolden, though I admit I haven't read it in a while.


Sideberry navigation-sidebar not opening

Hi scientiac,
thanks a lot for this very sleek theme!
Unfortunatly, i'm currently having an issue with the sidebar (configured with sideberry, using your suggested settings) not opening. So sideberry is active, but when hover the mouse over the tab column on the left, it doesn't expand to the right anymore (after a Firefox restart, not sure if an update was installed).
I'm on Windows, and currently using the lates stable Firefox version 133.0 (64-bit).
What might be helpful context: I was previously (~ a month ago) signed up for the beta version of the stable release, in which I encountered this same issue, because of which i "downgraded" to the stable release. So this might indeed be subject to an update which may just have been rolled out.

I have pushed an update, can you please try and give me a response if it works.

It's working again, thanks for the quick update.
Have a nice day!


distributive: remove healthcheck for resolv.conf

[x] Installs cleanly on a fresh build of most recent master branch
[x] Upgrades cleanly from the most recent release
[x] Updates documentation relevant to the changes

Fixes #1461

This is on hold; this might not actually be an issue (see #1461)


Fix LinkNode paths for getByteSizeVisitor

This PR fixes an issue in the getByteSizeVisitor where complex link node paths would be incorrectly resolved due to the fact that the NodeStack would follow in invalid path in the tree. The new methods to save and restore NodePaths inside the NodeStack help us fix this.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#284
#283
#282  👈
#281
#280
#275
#274
#270
#269
#266
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lorisleiva and the rest of your teammates on  Graphite

Merge activity

Nov 4, 8:46 AM EST: A user started a stack merge that includes this pull request via Graphite.


Traps

Trap items could be fun.
Ideas:

Place a mimic somewhere in the surrounding scenes.
Replace a Grub with a mimic, but still grant the Grub.
Bee trap: spawn bees on player.

I worry if u have the client open the mimic trap will be predictable with it going through the text client if opened and if it doesn’t that could be seen as the item wasn’t sent though I’m not super knowledgeable on hollow knight but based on what I’ve seen that seems to be true.

Fixing Mimic Shuffle would be nice.  However, the native IC behavior is to just play the mimic SFX when you 'receive' a mimic.
One of my ideas is to have sent mimics pick a random position near the player and spawn there, but this might make them spawn OOB (which admittedly won't break anything) or over spikes/acid).  This might be problematic in certain scenes where the player isn't expected to die, but DeathLink is already fixing/catching a lot of that.

Many people have requested "lore traps" which just freeze you in place. I think this is kinda janky and probably creates opportunities for text storage so instead we could include something like "scream traps" where a boss scream plays and takes control away during the scream

Ooma core trap, idea from discord

Zotelubra/Zote's Curse trap: spawn the eternal ordeal enemy that floats in the air and drains soul like a reverse Salubra's Blessing


Current Packaging Plan Does Not Support Gradual Adoption from Libraries

Hello 👋
I am the maintainer of nodestream which is a declarative framework for Building and Maintaining graph data. As a result, a core workflow that nodestream integrates with neo4j is ETL-ing data into the graph.
I was considering allowing users to opt-in to the rust extensions. For a lot of reasons, including the possibility of needing rust build tools, users may prefer the pure python driver over the rust extensions. However, the current packaging pattern does not provide a clean way to do that. Here are the options I've considered

Require the user to explicitly install which package they want instead of depending on neo4j or the neo4j-rust-ext directly. This is clunky because it adds a step for all users of the package, including those that don't know what the rust driver extensions do.
Have extras that allow the user to install the right dependency. However, you can't enforce either a default or a mutually exclusive dependency.

Ideally I'd like to be able to give our users the ability to opt-into the rust extensions with an extra that installs a certain version of the driver. For instance, pip install nodestream-plugin-neo4j[rust] extra pulls in neo4j-rust-ext as opposed to just neo4j.

Hi and thanks for reaching out.
Sorry for the late reply, I was on leave last week and was very deep in the process of rethinking the packaging of the Rust extensions. I was hoping to find a clean way to give users the Rust extensions when installing neo4j but without forcing them to have a Rust toolchain available by gracefully falling back to the pure Python implementation if the extensions were not available. Your issue came just in time to make me reconsider my first approach. So thanks for that.
We've settled on ditching my plans for now as with the limitations of Python's packaging system that you mentioned plus others I couldn't come up with a clean solution. So for now the packing will stay as it is.
As a matter of fact, you can install the driver together with the Rust extensions and it will work. I just deliberately chose not to document it that way as it's way too easy to end up with an incompatible version combination. Further, I wanted to leave myself more options for packaging. However, I know see that this is a really bad idea for downstream libraries like yours.
Would adding the following to the README of this project (and of course also committing to supporting this) be a solution to you problem?

ℹ Since the driver is a simple Python dependency of this package, you can also manually install/specify both packages at the same time without issues.
However, make sure to the versions match if you do so or leave the version of one of the two unspecified to let the package manager pick a compatible version for you (resolution might be slow, however).

That way, you'd be able to specify optional dependencies in you pyproject.toml or wherever. Along the lines of
[project]
name = "nodestream-plugin-neo4"
# ...
dependencies = [
    "neo4j == X.Y.Z"
]

[project.optional-dependencies]
rust = ["neo4j-rust-ext == X.Y.Z.*"]

and users could just either pip install nodestream-plugin-neo4j[rust] or pip install nodestream-plugin-neo4j.


More helpful error message when encountering missing modules while reading .miyagi.js

I just installed the extension in VSCode and got the following error:
2024-07-11 22:24:09.496 [info] Error: Cannot find module '@miyagi/twig-drupal'

VSCode Details
Version: 1.91.0 (Universal)
Commit: ea1445cc7016315d0f5728f8e8b12a45dc0a7286
Date: 2024-07-01T18:54:18.541Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0

Thank you for reporting. This usually means that npm dependencies are not yet installed and the extension encountered a missing module when trying to read the .miyagi.js configuration.
Can you try installing npm dependencies and then run the “miyagi: Reload” command from the VS Code Command Palette?
I’ll put it on my to do list to output a more helpful error message with the above-mentioned information.

miyagi: Reload

Aha! I found what the problem was here. I installed it at the root of a Circle Dot based project. Here it throws the error no matter whether the dependencies are already installed or not. When I open VSCode to just the relevant theme (web/themes/custom/theme), everything works as expected.
I wonder whether one could add the ability to provide a setting that is the path to a theme directory and the extension would then look for the NPM modules inside this directory. I would be happy to contribute if this makes sense. Thanks!

In theory the extension supports miyagi projects that are not in the root folder and even multiple projects opened at the same time.
The extension searches for all .miyagi.js or .miyagi.json files in the currently opened workspace and uses the miyagi config file to determine what a “project root” is:
https://github.com/miyagi-dev/vscode-miyagi/blob/c25b736f650c62b16010a1a22d2ae7dc4a9fbcff/src/lib/projects.ts#L46
I’m not sure why this didn’t work in your case 🤔

In theory the extension supports miyagi projects that are not in the root folder and even multiple projects opened at the same time.
The extension searches for all .miyagi.js or .miyagi.json files in the currently opened workspace and uses the miyagi config file to determine what a “project root” is:
https://github.com/miyagi-dev/vscode-miyagi/blob/c25b736f650c62b16010a1a22d2ae7dc4a9fbcff/src/lib/projects.ts#L46
I’m not sure why this didn’t work in your case 🤔

I will create a fresh clone over the weekend and try it again to see if I can replicate.


adding Edge Video svg logo

Build failed because of:
No cached entry, and Edge Video has issues with logo: edge_video_logo.svg, Cannot read property 'elem' of undefined


Gamepad stops working after reconnecting

Problem
Gamepad class stops working after specific sequence of events.
Moreover it can cause crash on calling it's destructor. Now hold on... after application is restarted gamepad still does not work until dmw.exe process is restarted! 😨
Environment
OS: Windows 10 21H2 (OS Build 19044.2075)
Controller: Xbox Series S/X Controller or Xbox One Controller (tested on both) connected with usb cable
DirectXTK: https://github.com/microsoft/DirectXTK/releases/tag/jul2022
Experiment: Preparation
I have created simplest Win32 application and changed the main loop to include some traces
    MSG msg;
    // Create GamePad instance
    auto pGamepad = std::make_unique<DirectX::GamePad>();

    // Main message loop:
    do
    {
        // Pump some messages
        while (TRUE == ::PeekMessage(&msg, NULL, 0, 0, PM_REMOVE))
        {
            if (msg.message == WM_QUIT)
            {
                return 0;
            }

            ::TranslateMessage(&msg);
            ::DispatchMessage(&msg);
        }

        // Read Gamepad current state and trace to outpu info that 'A' button has been pressed
        auto state = pGamepad->GetState(0);
        if (state.buttons.a)
        {
            ::OutputDebugStringA("Pressed\n");
        }
    }
    while (true);

I have also included a simple trace to Gamepad::OnGameInputDevice
        std::string trace = "Callback " + std::to_string(currentStatus) + "\n";
        OutputDebugStringA(trace.c_str());

Experiment: Execution

Start the application with one controller connected
It is traced as connected: Callback 7: ✔
Disconnect controller
It is traced as disconnected: Callback 0: ✔

ℹ This is just a control check to see that the disconnection event is reported

Reconnect controller
It is traced as connected: Callback 7: ✔
Press 'A' button
It is traced as pressed event a few times: Pressed : ✔
Disconnect controller
There is no disconnection event reported: ❌
Reconnect controller
There is no connection event reported: ❌
Press 'A' button
There is no button press event reported: ❌

Now to make things even worse

Restart the whole application with controller connected
There is a stream of traces reporting connection and disconnection of a controller that goes on and on ❌

Press 'A' button
There is no button press event reported: ❌
Close main window (graceful shutdown)
Application crashes and the Access Violation error is reported ❌

Callstack:

⚠ I have to close the dwm.exe process to make the application report controller events.
😨
I think this might be a problem with dmw.exe or GameInput library from GDK, but I have no idea how to diagnose it.
What can I do to find the source of this problem?

Which version of the Microsoft GDK are you using?

June 2022 Update 2 (220602). Currently it od the latest o e

I have noticed one more weird thing, trying to get input using Game Input API from GDK.
Code below gets current gamepad input readings
        ComPtr<IGameInputReading> pReading;
        HRESULT hr = m_pInput->GetCurrentReading(GameInputKindGamepad, nullptr, &pReading);

Disonnect gamepad and the hr equals GAMEINPUT_E_READING_NOT_FOUND. Fine.
Connect gamepad and the hr equals S_OK. Fine
Press some buttons and disconnect Gamepad. The hr is still S_OK.
Moreover, after restarting whole application it is still S_OK for disconnected gamepad untill dwm.exe process is restarted.

It seems like Game Input has some problems with handling gamepad disconnections.
Is there anything I can do to help in diagnosing this behavior?

Can you try out the October 2022 release from https://github.com/microsoft/GDK/tree/2210_OCTOBER

Almost good news. I did manage to install 'June 2022 Update 4 Public Release' (https://github.com/microsoft/GDK/releases/tag/June_2022_Update_4) and the problem seems to be gone.
I am not able to install the October update :(
I get an error and I do not how to install this from git repository.

Unable to verify integrity of downloaded content. It might be corrupted. Please check your network connection and try again.

I think we can close this issue, since it is a problem with GDK.
BTW do you have any hint how to install October version from git repository?

Sorry, I should've mentioned that the GDK repository uses git-lfs.
In any case, sounds like it's fixed in newer GDK builds which is great.


tables intermittently remain in a 'loading' state after rendering their contents

Some tables will load their contents, but fail to remove the 'loading' overlay, preventing any interaction. The variant tag list on Gene views also have this problem. Problem is intermittent, but appears to only occur after a component's initial instantiation and query, so refreshing the browser will (temporarily) solve the issue.
This might be due to a query's 'isLoading' observable  failing to send a final 'false', which would trigger removal of the loading overlay.

I am still able to replicate this with the library updates on the variants menu. Load a gene page, click a variant, then click "back."


Distribution set up

Purpose of this PR
Adds to the web player by including some npm and cdn config and examples. Also attempts to fix a texture sync issue.
Changes made in this PR

Github workflow added that will push the latest version of the web player to npm
Example showing how to import player through cdn created
Added three js player in the wasm folder (that be imported with npm/cdn)
Changed how the player calculates the required mesh number

Testing Summary
Using examples/05_vol_geom_wasm_threejs/cdn_test.html I could test cdn.
Risk Introduced and any Breaking Changes
Maybe some cleaning to do before merge
Pre-Merge Checklist

If you have a problem with the review process (e.g. it's taking too long, or the reviewers forgot) get in touch with the Team Lead of the project!

[ ] Before making your PR, refresh your branch with a merge from its parent in case of conflicting changes since you started your branch.
[ ] This PR description is written clearly so that reviewers can understand the why/what/how of the work done.
[ ] Reviewed your own PR and checked your changed code.
[ ] Invited a range of good reviewers.
[ ] Wait for a PR to be properly reviewed. Responded to all questions, and made any required changes.
[ ] Received one other reviewer's approval. Ideally wait for 2+ approvals, especially if you didn't get a thorough reivew on the first approval.
[ ] If a reviewer asks a question, even if you have another approval, got the approval of the other reviewers as well before merging.
[ ] Made sure existing reviewers approved any changes to the PR.
[ ] Resolved any merge conflicts after making the PR.
[ ] CI/CD builds are not reporting any errors.

Looks pretty neat to me.
I can help fix that failing docker / avcodec download tomorrow (it seems to do this every now and again?).
And give it a test.
And help update the Readme.

For the CI issue, it loos like we should always run an apt-get update before an install https://docs.github.com/en/actions/using-github-hosted-runners/customizing-github-hosted-runners#installing-software-on-ubuntu-runners

Note: Always run sudo apt-get update before installing a package. In case the apt index is stale, this command fetches and re-indexes any available packages, which helps prevent package installation failures.

I can help with that @patrick-volograms @capnramses , unless you are already on it.


Increase readiness and liveness probe timeouts, introduce an initial delay

Currently the default timeout of 1 second and no initial delay is applied to the probes of the runner pods. Depending on the startup time this can cause random Pod errors causing a whole TestRun to fail.
At some point it might also make sense to introduce a startupProbe to cover the longer initial startup time a K6 instance (Pod) might need instead of every increasing the runtime liveness and readiness checks.
Fixes #306

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@yorugac Since you opened the issue (https://github.com/grafana/k6-operator/issues/306) PTAL at this proposed fix / mitigation.
As commented, I believe a startup probe would make some sense and also distinguishing between liveness and readiness checks (which is a different thing).

any eta when this will go live ? ie increase the timeout of probes


[Orders] Metamask error when finalizing a crypto offer

Kay ran into the following error while trying to finalize an order paird with crypto from the admin Orders page.
"BigNumber Error: new BigNumber() not a number: null
    at Q (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui.js:1:800541)
    at A (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui.js:1:806026)
    at new V (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui.js:1:798446)
    at a (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui.js:1:3210034)
    at o (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui.js:1:3210093)
    at s (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui.js:1:3210134)
    at u (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui.js:1:3210238)
    at d (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui.js:1:3210953)
..."

I was not able to reproduce it on my own test shop.
A made an offer in crypto and was able to accept it then finalize it on the merchants admin Orders page.
@kayyoo23 During the next round of testing, do you mind retrying this scenario? Please do make sure to publish your shop before trying (otherwise it will still be using the old code).

I was not able to reproduce it on my own test shop.
A made an offer in crypto and was able to accept it then finalize it on the merchants admin Orders page.
@kayyoo23 During the next round of testing, do you mind retrying this scenario? Please do make sure to publish your shop before trying (otherwise it will still be using the old code).

yep will certainly do @franckc

Closing this since no new instance of this issue have ben reported in the last 5 days.


Update error.tsx

In this updated code:
Errors are logged to a server or service using the logErrorToServer function (you should implement this function to suit your needs). The page is only refreshed if the user explicitly clicks the "Refresh Page" button, giving them more control. A user-friendly message is displayed in case of an error.
i want to make a note to make you remind that implement the logErrorToServer function to log errors to a backend service, as it's not included in the code.

You should use sentry.


undefined is not an object (evaluating 'e[t].call')

🐛 Bug Report
Sentry reports error about not being able to find module. It happens for a lot of people. I am having problem with reproducing it even, because it works for me. Tried for about a hour to cause a error and it happen only once.
TypeError: Cannot read property 'call' of undefined
  at __webpack_require__(webpack/bootstrap:84:22)
  at call(resources/pages-Home-160eba.js:26:26)
  at __webpack_require__(webpack/bootstrap:84:22)
  at call(resources/pages-Home-160eba.js:15:17)
  at __webpack_require__(webpack/bootstrap:84:22)
  at requireSync(./src/Boot/App.tsx:35:22)
  at loadSync(./node_modules/@loadable/component/dist/loadable.esm.js:185:35)
  at new h(./node_modules/@loadable/component/dist/loadable.esm.js:135:17)

Error coming from here.
// Execute the module function
 		modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);

I checked issues and problem has been resolved in 5.11.0 release when it comes to chunks.
Any idea what could be a cause ?
Expected behavior
Should not happen.
Run npx envinfo --system --binaries --npmPackages @loadable/component,@loadable/server,@loadable/webpack-plugin,@loadable/babel-plugin --markdown --clipboard
Paste the results here:
## System:
 - OS: macOS 10.15.4
 - CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
 - Memory: 1.34 GB / 16.00 GB
 - Shell: 5.7.1 - /bin/zsh
## Binaries:
 - Node: 11.12.0 - ~/.nvm/versions/node/v11.12.0/bin/node
 - Yarn: 1.21.1 - ~/.yarn/bin/yarn
 - npm: 6.7.0 - ~/.nvm/versions/node/v11.12.0/bin/npm
 - Watchman: 4.9.0 - /usr/local/bin/watchman
## npmPackages:
 - @loadable/babel-plugin: ^5.12.0 => 5.12.0
 - @loadable/component: ^5.12.0 => 5.12.0
 - @loadable/server: ^5.12.0 => 5.12.0
 - @loadable/webpack-plugin: ^5.12.0 => 5.12.0

I am also facing same issue. In my case i am getting below error
react-dom.production.min.js:5058 TypeError: Cannot read property 'call' of undefined     at u (bootstrap:83)     at Object.230 (ReviewCard.js:1)     at u (bootstrap:83)     at Object.234 (index.js:1)     at u (bootstrap:83)     at Module.96 (applyhomepage.4f1a6611.chunk.js:1)     at u (bootstrap:83)     at Object.e [as requireSync] (Loadable.js:9)     at o.h.loadSync (loadable.esm.js:183)     at new o (loadable.esm.js:133)

Could you (both) clarify when the issue is happening:

on the initial page load (that means loadable is not waiting for all used chunks to load)
on the transition (that means loadable is thinking that something is ready while it is not)

And I also need an example of how you import component which is breaking - something inside ReviewCard in the second example, and why not moduleId in the first.

This bug is occuring for me after loadableReady is resolved.
Scenario,
Suppose a project has 3 chunks a,b & common chunk a~b and each chunks has 5 modules in it. 1-5 belongs to a, 6-10 to b & 11-15 to a~b.
So, imagine a scenario in which chunk a gets loaded first and then chunk a~b and then some part of chunk a start looking for module 11 but at that time module is still to be the part of modules.
`
function webpackJsonpCallback(data) {
// 		var chunkIds = data[0];
// 		var moreModules = data[1];
// 		var executeModules = data[2];
//
// 		// add "moreModules" to the modules object,
// 		// then flag all "chunkIds" as loaded and fire callback
// 		var moduleId, chunkId, i = 0, resolves = [];
// 		for(;i < chunkIds.length; i++) {
// 			chunkId = chunkIds[i];
// 			if(Object.prototype.hasOwnProperty.call(installedChunks, chunkId) && installedChunks[chunkId]) {
// 				resolves.push(installedChunks[chunkId][0]);
// 			}
// 			installedChunks[chunkId] = 0;
// 		}
// 		for(moduleId in moreModules) {
// 			if(Object.prototype.hasOwnProperty.call(moreModules, moduleId)) {
// 				modules[moduleId] = moreModules[moduleId];
// 			}
// 		}
// 		if(parentJsonpFunction) parentJsonpFunction(data);
//
// 		while(resolves.length) {
// 			resolves.shift()();
// 		}
//
// 		// add entry modules from loaded chunk to deferred list
// 		deferredModules.push.apply(deferredModules, executeModules || []);
//
// 		// run deferred modules when all chunks ready
// 		return checkDeferredModules();
/******/ 	};
`
function __webpack_require__(moduleId) { /******/ /******/ 		// Check if module is in cache /******/ 		if(installedModules[moduleId]) { /******/ 			return installedModules[moduleId].exports; /******/ 		} /******/ 		// Create a new module (and put it into the cache) /******/ 		var module = installedModules[moduleId] = { /******/ 			i: moduleId, /******/ 			l: false, /******/ 			exports: {} /******/ 		}; /******/ 		// Execute the module function /******/ 		modules[moduleId].call(module.exports, module, module.exports, __webpack_require__); /******/ /******/ 		// Flag the module as loaded /******/ 		module.l = true; /******/ /******/ 		// Return the exports of the module /******/ 		return module.exports; /******/ 	}
which leads modules[moduleId] as undefined.
P.S. : sorry for my bad english.

Error stack trace
react-lifecycles-compat.es.js:46 TypeError: Cannot read property 'call' of undefined     at __webpack_require__ (bootstrap:86)     at Module.96 (applyhomepage.a6b11d8a.chunk.js:1241)     at __webpack_require__ (bootstrap:86)     at Object.requireSync (Loadable.js:9)     at InnerLoadable.loadSync (react-lifecycles-compat.es.js:46)     at new InnerLoadable (react-lifecycles-compat.es.js:46)     at Ug (react-lifecycles-compat.es.js:46)     at ui (react-lifecycles-compat.es.js:46)     at gk (react-lifecycles-compat.es.js:46)     at fk (react-lifecycles-compat.es.js:46)

For me it's also happening after loadableReady on initial page load. Currently moved to react-universal-component, which works without any problems.

@theKashey  As I am using React streaming api and loadable-components yet not support prefetching for same. Please refer below line
It only works with renderToString API. Since <link> must be added in the <head>, you can't do it using renderToNodeStream.
so because all chunks are getting loaded in async manner it may be possible whenever runtime~main chunk is getting loaded after all or almost all other required chunks for a page to hydrate then it is leading to this error. As, I intentionally put a delay of 5 sec for runtime~main chunk which made it the last chunk to get loaded and thereafter leading to loadableReady which means loadableReady is working as expected but in this scenario, I am getting same above specified error with more frequency like 7 times out of 10.

Ok. So the root cause it that loadable is trying to require modules in a sync way (it actually thinks it can call them synchronously), while they are not yet present.
webpack instruments dynamic import with all the required chunks to handle the requests, which is not the case here.
So the questions:

why loadable  thinks that it could call it sync. 👉 because it checks module existence in the cache and have no idea about module's requirements.
once it was proposed that only modules in the SSR-ed chunks should be the subject for cache based isReady - any other, or anything after loadableReady should remember was it loaded or not. Look like this has to be done.

chunks are getting loaded in async manner it may be possible whenever runtime~main chunk is getting loaded after all or almost all other required chunks for a page to hydrate then it is leading to this error.

Webpack controls chunks execution and will not run the "main" one until it's dependencies are resolved, no matter how you do load them.
However, the list of chunks to be "awaited" has to be known before calling loadableReady
👉 try to run your code on DOMReady. That would ensure that all variables, and actually HTML to hydrate, is ready.

@theKashey
point_right try to run your code on DOMReady. That would ensure that all variables, and actually HTML to hydrate, is ready.
you mean instead of hydrate after loadableReady I should try below
window.addEventListener('DOMContentLoaded', (event) => {     //'hydrate'; });
correct me if I am wrong.

I have completed all required task for migration from https://github.com/jamiebuilds/react-loadable to this library but this bug is a road blocker to make it to production.
So the questions:
* why loadable thinks that it could call it sync. point_right because it checks module existence in the cache and have no idea about module's requirements.
* once it was proposed that only modules in the SSR-ed chunks should be the subject for cache based isReady - any other, or anything after loadableReady should remember was it loaded or not. Look like this has to be done.

Early solution to this bug would be a great justification to all my work involved in migration to this library.

@theKashey @gregberge  Are we planning to get this fixed?
along with this bug i am facing below bug too
https://github.com/gregberge/loadable-components/issues/553

So, just to clarify:

there are a few chunks - main, page1, page2, somestuff, someotherstuff
you can load page1, it will also load, page2 and somestuff
then you will try to load page2, it will be in the cache, so loadable will try to load it, but not all dependencies would be "ready"
💥

And the solution is not to "trust" any non initial page.
Sounds like a small change to isReady - it should bailout for:

all this.resolved[key] === false before LoadableReady event (as right now)
all this.resolved[key] !== true after LoadableReady event (should fix this case)

@theKashey I am not much aware of internal working of this library. So, Please help me in understanding some of the points

Difference between loadSync & loadAsync

What are possible values for this.resolved[key]?

That was just breadcrumbs for myself. The PR with the fix for the current problem has been already raised.

@theKashey
Referring your previous comment
https://github.com/gregberge/loadable-components/issues/558#issuecomment-627848227
Just to be on same page in term of understanding

there are a few chunks - main, page1, page2, page1~page2.

So required chunks for Page 1 is main, page1 and page1~pag2

<script id="__LOADABLE_REQUIRED_CHUNKS__" type="application/json">[page1,page1~pag2]</script>

Here main will bootup the process and then loadable-components with the help above line will be able to know page level dependencies and hold the hydration until all required chunks got loaded. This is done via below lines
loadableReady(() => { //'hydrate'; });

before hydration everything is working fine but while hydration this error occurs and this can be occured for any page for there 1st or nth load as this bug is dynamic in nature.
Below is the number of times this bug is happening for me in last 24 hours

So, just to double check - error is happening during hydrate? Not any time later?
This means that the problem is inside loadableReady, which is actually very simple function (so I don't know what could be broken here, thus how to fix it)

@theKashey
No loadableReady is working fine, As it is doing its task of telling all chunks got loaded perfectly fine.
The problem here is not with chunk loading but with module loading as each chunk can have multiple modules and the scenario i tried to explain in https://github.com/gregberge/loadable-components/issues/558#issuecomment-620398117
You have mentioned in a comment https://github.com/module-federation/module-federation-examples/pull/19#issuecomment-629717388 i.e.

Meanwhile - loadable overrides webpack's jsonp_callback for living, and is it working for already bundled remote as well?

I dnt know exactly how  loadable overrides webpack's jsonp_callback for living works but modules loading is handled by it, so It may be possible something related to it causing the issue.
In meanwhile,I will try to apply changes of PR https://github.com/gregberge/loadable-components/issues/568.

Every module is brought by a some chunk. If chunk is loaded - then all modules inside it are loaded. So if just after loadableReady you are getting an error - that means it's not actually ready, which is only possible if one more chunk is not loaded, and the question is why.

But I have tried blocking one of required chunk say page1 from below example then in that case loadableReady is not getting fired as expected.
<script id="__LOADABLE_REQUIRED_CHUNKS__" type="application/json">[page1,page1~pag2]</script>

Hi @theKashey ,
I'm experiencing a similar issue.
Say a particular page on our site (SSR) needs 4 chunks: main.js, vendor.js, page.js, page-dependency.js.
page-dependency.js normally loads before vendor.js and everything is fine. If for some reason page-dependency.js loads after vendor.js, it will throw TypeError: Cannot read property 'call' of undefined.
So the following loading orders are fine:
main.js ->  page.js -> page-dependency.js -> vendor.js
main.js ->  page-dependency.js -> page.js -> vendor.js
page-dependency.js -> page.js -> main.js -> vendor.js
and these will error:
main.js ->  page.js -> vendor.js -> page-dependency.js
page.js -> main.js -> vendor.js -> page-dependency.js
After investigation I found the cause:
main.js waits until vendor.js is loaded and executes, which executes page.js. However the dependency (page-dependency.js) for page.js is not ready at the moment, causing the type error - it tries to run
modules[moduleId].call(module.exports, module, module.exports, webpack_require);butmodules[moduleId]is undefined (not loaded yet). Further investigation found this is because loadable component checksoptions.ssr !== false && ctor.isReady && ctor.isReady(props)andisReadyreturnstrue` because it checks:
if (typeof __webpack_modules__ !== 'undefined') {
      return !!(__webpack_modules__[key])
}

This key here is the moduleId for one of the modules in page.js and it will exist in __webpack_modules__ because page.js is loaded. However it doesn't mean that page.js is safe to execute because page-dependency.js is not loaded yet. isReady gives false positive to loadable to use loadSync. It only checks whether the module itself is loaded but misses its dependencies.
I read your PR https://github.com/gregberge/loadable-components/pull/568. From my limited understanding of loadable library, I'm not sure if it will solve the issue in the above case:
isReady will still return true in our case. Also LOADABLE_SHARED.initialChunks[ctor.chunkName(props)] will be true because page.js is loaded from SSR process. So loadSync will still be called causing the type error.
Although not very frequent, this bug is causing production issue for our app. We would really appreciate it if the bug can be fixed soon.
I can put up a sample project if the information is not enough. Thanks a lot.

@Joey-z-rp - look like you are close to the solution. We have just find a real root cause. Here is what not working right (as PR #568):

isReady will still return true in our case. Which is possible only if it is loaded using requireAsync. Which could never fail (but we could not use async for the initial hydrate)

   if (this.resolved[key] !== true) {
      return false;
    }
  // ...
  requireAsync(props) {
    this.resolved[key] = false;
    return this.importAsync(props).then(resolved => {
      this.resolved[key] = true;
    });
  },

LOADABLE_SHARED.initialChunks[ctor.chunkName(props)] will be true because page.js. Which is also means - loadableReady is done, and all chunks need for the application start were loaded. And you are clearly state that page-dependency.js was not yet loaded.

As a result the problem is hidden:

or in __LOADABLE_REQUIRED_CHUNKS__ - could you check that all "required" chunks are inside
or in loadableReady
or in third place. Right now loadableReady is waiting only in chunks listed in __LOADABLE_REQUIRED_CHUNKS__ and that might not all required. Dependencies of dependencies might not be tracked.

or in LOADABLE_REQUIRED_CHUNKS - could you check that all "required" chunks are inside

Yes for my case.

@theKashey
It turned out that we didn't use loadableReady in our client side code :cry: . After I put it in, the app works correctly. Sorry for the false alarm.
Although it would be nice if the documentation have more information about what would happen if loadableReady is not used properly. In our case, the loadable component "setup" was done a while ago and it had been working fine (because we didn't have page-dependency.js at that time) until now. Even without loadableReady it works fine the majority of times. Those a few times it throws type error (because page-denpendency.js loads after vendor.js for whatever reason), the error message Cannot read property 'call' of undefined doesn't give useful information about what/where went wrong. It took me quite a digging to find out the cause and realised I need to use loadableReady.
Thanks very much for your help!

Ok. So component should throw if loadableReady is not finished work or was not even called. Good catch.

@theKashey
Just FYI, I am using
optimization: {
    // Keep the runtime chunk seperated to enable long term caching
    // https://twitter.com/wSokra/status/969679223278505985
    runtimeChunk: true,
  },

and error happens in below cases
main.js -> page.js -> vendor.js -> page-dependency.js->runtime~main.js
page.js -> main.js -> vendor.js -> page-dependency.js->runtime~main.js
Sample Code to Assure the order
router.use("/js/page.js", (req, res, next) => {
    setTimeout(next, 2000);
});
router.use("/js/vendor.chunk.js", (req, res, next) => {
    setTimeout(next, 3000);
});
router.use("/js/page-dependency.js", (req, res, next) => {
    setTimeout(next, 4000);
});
router.use("/js/runtime~main.js", (req, res, next) => {
    setTimeout(next, 5000);
});

So there is a little problem:

loadable uses babel plugin to inject webpackChunkName to the every import
this gives it an ability to know those chunk names
webpack could easily split one chunk to many smaller ones, like runtime~main.js
server should collect all child scripts and still report them LOADABLE_REQUIRED_CHUNKS

Like what is vendor.js and runtime~main.js in your case? They are not in LOADABLE_REQUIRED_CHUNKS! As a result, loadableReady says "I am ready" while it is not.
So two ways to fix:

fix LOADABLE_REQUIRED_CHUNKS / chunk collection
solve it in any other way.

The simples solution would be to import any "expected to be loaded" loadable component, but full dynamic import is not letting you do that without knowing props.
So @prateekr1 - could you share your stats.json. We have to find how chunks are connected, and why their connection was not discovered by the loadable/server

@theKashey Because of my firm policy I would not be able to share stats.json but I am trying to create a sample example.

As main, vendor and runtime~main are application initial requirement without any of it application does not boot up.

While page & page-dependency are page level dependency and application is not aware of these dependencies so to make application aware of these dependencies this library takes help of LOADABLE_REQUIRED_CHUNKS and hold the loadableReady event untill all chunks specified in LOADABLE_REQUIRED_CHUNKS got loaded.

After loadableReady event we hydrate the application.

So, I feel this library intelligently populating LOADABLE_REQUIRED_CHUNKS with page level dependencies only, not with initial application level dependencies i.e. main, vendor and runtime~main as LOADABLE_REQUIRED_CHUNKS will only come into picture once application got boot up.
So, here runtime has the code
/******/ 	function webpackJsonpCallback(data) {
/******/ 		var chunkIds = data[0];
/******/ 		var moreModules = data[1];
/******/ 		var executeModules = data[2];
/******/
/******/ 		// add "moreModules" to the modules object,
/******/ 		// then flag all "chunkIds" as loaded and fire callback
/******/ 		var moduleId, chunkId, i = 0, resolves = [];
/******/ 		for(;i < chunkIds.length; i++) {
/******/ 			chunkId = chunkIds[i];
/******/ 			if(Object.prototype.hasOwnProperty.call(installedChunks, chunkId) && installedChunks[chunkId]) {
/******/ 				resolves.push(installedChunks[chunkId][0]);
/******/ 			}
/******/ 			installedChunks[chunkId] = 0;
/******/ 		}
/******/ 		for(moduleId in moreModules) {
/******/ 			if(Object.prototype.hasOwnProperty.call(moreModules, moduleId)) {
/******/ 				modules[moduleId] = moreModules[moduleId];
/******/ 			}
/******/ 		}
/******/ 		if(parentJsonpFunction) parentJsonpFunction(data);
/******/
/******/ 		while(resolves.length) {
/******/ 			resolves.shift()();
/******/ 		}
/******/
/******/ 		// add entry modules from loaded chunk to deferred list
/******/ 		deferredModules.push.apply(deferredModules, executeModules || []);
/******/
/******/ 		// run deferred modules when all chunks ready
/******/ 		return checkDeferredModules();
/******/ 	}

function __webpack_require__(moduleId) {
/******/
/******/ 		// Check if module is in cache
/******/ 		if(installedModules[moduleId]) {
/******/ 			return installedModules[moduleId].exports;
/******/ 		}
/******/ 		// Create a new module (and put it into the cache)
/******/ 		var module = installedModules[moduleId] = {
/******/ 			i: moduleId,
/******/ 			l: false,
/******/ 			exports: {}
/******/ 		};
/******/ 		// Execute the module function
/******/ 		modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);
/******/
/******/ 		// Flag the module as loaded
/******/ 		module.l = true;
/******/
/******/ 		// Return the exports of the module
/******/ 		return module.exports;
/******/ 	}

Out of which below code is responsible for loading all moduleId of each chunk to modules chunk by chunk.
/******/ 		for(moduleId in moreModules) {
/******/ 			if(Object.prototype.hasOwnProperty.call(moreModules, moduleId)) {
/******/ 				modules[moduleId] = moreModules[moduleId];
/******/ 			}
/******/ 		}

So, particularly in below sequence as soon as runtime~main.js gets loaded
main.js -> page.js -> vendor.js -> page-dependency.js->runtime~main.js
It leads to

Loading all moduleId in modules from main.js then

Loading all moduleId in modules from page.js then

Loading all moduleId in modules from vendor.js and hence leading to application bootup and also to loadableReady as all required chunks all already there but

Loading of all moduleId in modules from page-dependency.js is still pending let say moduleId 154 is one of moduleId of chunk  page-dependency.js then

As loadableReady already got fired and hence call from page.js looking for moduleId 154 came.

/******/ 		// Execute the module function
/******/ 		modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);
/******/

and moduleId 154 is not yet part of modules and hence leading to error
react-dom.production.min.js:5058 TypeError: Cannot read property 'call' of undefined
    at __webpack_require__ (bootstrap:84)
    at Module.96 (page.js:1248)
    at __webpack_require__ (bootstrap:84)
    at Object.requireSync (Loadable.js:9)
    at InnerLoadable.loadSync (loadable.esm.js:183)
    at new InnerLoadable (loadable.esm.js:133)
    at Lg (react-dom.production.min.js:3174)
    at fi (react-dom.production.min.js:4307)
    at Rj (react-dom.production.min.js:6700)
    at Qj (react-dom.production.min.js:6150)

Let's just answer one question - it is breaking during initial hydrating (which means loadableReady is not working), or later?
#568 was created to fix only "later", and there is really problem with that "later", however look like the bigger issue is hidden inside chunk tracking.

Let's just answer one question - it is breaking during initial hydrating (which means loadableReady is not working), or later?

Yes, it is breaking during initial hydration.
And, It is only breaking when In webpack I use below config i.e. it create a separate chunk for runtime information in runtime~main.js instead of keeping the runtime information in main.js and why of it, has already been explained in depth in my previous comment https://github.com/gregberge/loadable-components/issues/558#issuecomment-631198226
optimization: {
    // Keep the runtime chunk seperated to enable long term caching
    // https://twitter.com/wSokra/status/969679223278505985
    runtimeChunk: true,
  },

Ok. I'll try to update one of examples here to break them.

After digging transpiled code via webpack. I found in page.js below code, where most of the time it is breaking when order of load of chunks is
 main.js -> page.js -> vendor.js -> page-dependency.js->runtime~main.js
// EXTERNAL MODULE: ./src/utils/validation.js
var validation = __webpack_require__(1);

where moduleId 1  is in page-dependency.js.
so, interested to know when webpack put EXTERNAL MODULE comment
// EXTERNAL MODULE: ./src/utils/validation.js

P.S.: knowledge of this may help me in creating an example for this bug.

@theKashey can you help me with this https://github.com/gregberge/loadable-components/issues/558#issuecomment-631873651.

I am not a webpack expert. Sorry @prateekr1

FYI, we ran into this issue with a project that mixes SSR and pure client-side pages depending on the context (we identify the SSR scenario and use loadableReady where appropriate). For some non-SSR pages, it was in one case consistently reproducible by first doing a clear cache + reload followed by a regular reload. The latest release from master indeed seems to have fixed it.

That's good news. Sounds like the latest master should be published to npm.

@theKashey would be great if you release master to npm a bit more frequently.
I like the fact that loadable-components is stable, but last release was in January and it misses a lot of fixes.

On it...


Save directly to SD or USB

Would be possible to save directly to an SD-Card or USB-stick without choosing the correct directory?

We currently do not support automatic direct storage of mobile storage devices, but we will consider adding your proposal in the following updates. Thank you for your feedback


Error with company controlled AppleID

Just installed xcodes from brew and tried downloading xcode 16.1 and after providing correct creds this is what I get:

@cbazza see pinned issue: https://github.com/XcodesOrg/xcodes/issues/395#issue-2624226924 - workaround for now is to change your password.
This should hopefully be fixed via https://github.com/XcodesOrg/xcodes/pull/398 at some point in the future.

@MattKiazyk Thank you for the quick reply.
Just to clarify my company AppleID is integrated into our SSO (Microsoft) which also requires Authenticator app (6 digit code). When I go to change AppleID password, it sends me to Microsoft site for that so changing password is invisible to Apple. I can only see this working if after providing AppleID (email address) it went to the same sequence of popups I go through when logging in to Apple connect for example.

If possible, can you install the Xcodes app and see if you can log in with that. If you can it would tell me that P is the fix.


Blog monthly analytics

@lpgoldstein Blog monthly analytics are ready for your review. I added the new Looker Studio monthly reports :)
https://github.com/DOI-ONRR/blog-nrrd/wiki/Analytics

@cthomasONRR looks good! I love the new reports!


Clarification on Power vs. Energy in CodeCarbon Calculations

Description
How does CodeCarbon differentiate between 'power' and 'energy' in its calculations? Could someone clarify how CodeCarbon handles these two concepts?
What I Did
After a quick search, I got the feeling that these terms are used interchangeably in some contexts.

Thanks for reporting this.
We try to consistently use Energy = Power * Time but can you tell where there still have mistake ?

Actually, after a quick review, I couldn't find out if they are dealt with differently and what the tracker returns: power or energy. I assumed power, but for confirmation, I had a quick review and couldn't find it

Is there any possibility to get the mean of all power for a specific task same like we get the energy?

You could divide the energy by the duration to get the mean power. So I don't know if implementing a mean by adding a sum and a counter make sense.

According to the question about mean power: isn't cpu_power, gpu_power and ram_power the average use of Watt per second? So if I add these 3 values, I am getting the average power for gpu, cpu and ram per second?

Looking at the code, I think it's only the last measured power that is stored.


Add revision + build timing in the version information

For the moment the version of the compiler is just a simple number.
$ clawfc --version
CLAW Fortran compiler 0.1

It is than sometimes hard to know if we are using the latest build especially in development phase. The version should include the revision and the build time.
$ clawfc --version
CLAW Fortran compiler 0.1 rev. f06990e build<PHONE_NUMBER>1104

For the releases, the version can be simpler with just the release number.
$ clawfc --version
CLAW Fortran compiler 0.1 release

Only git hash is fine


Error deploying contract

Throws errors like rpc invalid url when deploying contract

Okay, solution is having enough gas fees in your wallet and probably speeding up the transaction using the aggressive option


[Docs]: Java heap specs which Appsmith is hosted

Users would like to know about necessary resources for hosting Appsmith, and information about improving Appsmith instance performance by increasing available resources (via the `APPSMITH_JAVA_HEAP_ARG` variable in the .env file).
Discord thread here: https://discord.com/channels/725602949748752515/760761686549463060/991580506988748893

@sum35h - Could you please help with the statistics that we can add to docs?


"Empty" comments shouldn't require review, and show up in the "read comment" (internal and external)

Hey team! Please add your planning poker estimate with Zenhub @djnunez-aot @jadmsaadaot

Hey team! Please add your planning poker estimate with Zenhub @tiagograf-AOT @VineetBala-AOT

If no comments found in a submission it should be automatically approved.
Filter out submissions that have no comments in the listing pages (list and read all).