Pulsar Client has no support in Mac 10.14.5 (18F132) ?

Describe the bug
Python Pulsar Client say import _pulsar ImportError Reason: image not found
To Reproduce
Steps to reproduce the behavior:
In Mac: pip install pulsar-client --upgrade
python consumer.py
Traceback (most recent call last):
  File "consumer.py", line 1, in <module>
    import pulsar
  File "/Users/chethan/anaconda3/lib/python3.7/site-packages/pulsar/__init__.py", line 99, in <module>
    import _pulsar
ImportError: dlopen(/Users/chethan/anaconda3/lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so, 2): Library not loaded: /usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/Python
  Referenced from: /Users/chethan/anaconda3/lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so
  Reason: image not found

Desktop (please complete the following information):

OS: Mac 10.14.5 (18F132)

Additional context
Tried in both normal env and Conda env: 3.7, 2.7
Whats the possible solution?
Also, In official docs: pip install pulsar-client==2.3.2
But, I got error while installing:
Collecting pulsar-client==2.3.2
  ERROR: Could not find a version that satisfies the requirement pulsar-client==2.3.2 (from versions: 1.18.dev1, 1.19.dev1, 1.19.dev2, 1.19.0, 1.20.0, 1.21.0, 1.22.0, 2.0.1, 2.1.0, 2.1.1, 2.2.0, 2.2.1, 2.3.0, 2.3.0.post1, 2.3.1)
ERROR: No matching distribution found for pulsar-client==2.3.2

Thanks!.

Ah I see. we didn't upload the python clients for mac for 2.3.2 release. Can you try 2.3.1 client to get around the problem for now?
@jerrypeng since you were releasing 2.3.2, can you please check why we didn't upload the python clients for mac for 2.3.2?
2.3.2: https://pypi.org/project/pulsar-client/2.3.2/#files
2.3.1: https://pypi.org/project/pulsar-client/2.3.1/#files

This issue also occurs with 2.4.0. I'm unable to use any version greater than 2.2.1.
With 2.3.0 I see when running a test that import pulsar:
E   ImportError: dlopen(../lib/python2.7/site-packages/_pulsar.so, 2): Symbol not found: _ZN6icu_636LocaleC1ERKS0
E     Referenced from: ../lib/python2.7/site-packages/_pulsar.so
E     Expected in: flat namespace
With 2.3.1 I see no error but pytest fails to run:
I see Empty test suite.
I don't see any errors, but this impacts pytest in a way that it fails to discover tests. This issue doesn't occur with

Any updates on this?

Is this still an issue ?
It's working fine for me.

We met the some problem.

Mac OS 10.14.6
python 3.7.4
pulsar-client 2.4.1
I can install it perfectly, but when I run the server locally, it shows me the following error

lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so
  Reason: image not found

@lxy1992 try this
brew install protobuf

I will take a look at why the static linking didn't work correctly

same error for me in mac 10.14.6
import pulsar
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/xxx/miniconda/lib/python3.7/site-packages/pulsar/__init__.py", line 102, in <module>
    import _pulsar
ImportError: dlopen(/Users/xxx/miniconda/lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so, 2): Library not loaded: /usr/local/opt/protobuf/lib/libprotobuf-lite.20.dylib
  Referenced from: /Users/xxx/miniconda/lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so
  Reason: image not found

i already installed protobuf with brew.

@nathan-zhu try this
pip3 install pulsar-client==2.4.1.post1

for me it's still not working

only works with python 3.6 and pulsar 2.0.1 but missing mandatory updates

@nathan-zhu try this
pip3 install pulsar-client==2.4.1.post1

works on python 3.7, Mojave

I am having the same issue, just following the documentation trying to product some messages.

MacOS: 10.15.2
Pulsar: 2.4.2 on Docker 19.03.5
Python: 3.7.2
protobuf: stable 3.11.2
pulsar-client: 2.4.2

pulsar-env ❯ python consume.py
Traceback (most recent call last):
  File "consume.py", line 1, in <module>
    import pulsar
  File "/Users/me/.pyenv/versions/pulsar-env/lib/python3.7/site-packages/pulsar/__init__.py", line 102, in <module>
    import _pulsar
ImportError: dlopen(/Users/me/.pyenv/versions/pulsar-env/lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so, 2): Library not loaded<EMAIL_ADDRESS>  Referenced from: /Users/me/.pyenv/versions/3.7.2/envs/pulsar-env/lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so
  Reason: image not found

And contents of the consume.py script:
import pulsar

client = pulsar.Client('pulsar://localhost:6650')
consumer = client.subscribe('my-topic',
                            subscription_name='my-sub')

while True:
    msg = consumer.receive()
    print("Received message: '%s'" % msg.data())
    consumer.acknowledge(msg)

client.close()

I tried changing the protocol from pulsar:// to http://, but the import call is failing so it doesn't reach that point.
Any suggestions?

I also tried compiling & installing the Python library from source after brew install libpulsar MacOS C++ libraries documentation and Python documentation but I got the following error:
pulsar-env ❯ python setup.py install
running install
running bdist_egg
running egg_info
writing pulsar_client.egg-info/PKG-INFO
writing dependency_links to pulsar_client.egg-info/dependency_links.txt
writing requirements to pulsar_client.egg-info/requires.txt
writing top-level names to pulsar_client.egg-info/top_level.txt
reading manifest file 'pulsar_client.egg-info/SOURCES.txt'
writing manifest file 'pulsar_client.egg-info/SOURCES.txt'
installing library code to build/bdist.macosx-10.14-x86_64/egg
running install_lib
running build_py
running build_ext
error: [Errno 2] No such file or directory: '_pulsar.so'

Latest update with this line up working on MacOS 10.14.6
MacOS: 10.14.6
Python 2.7.16
Pip 19.3.1 from /Library/Python/2.7/site-packages/pip-19.3.1-py2.7.egg/pip (python 2.7)
Pulsar client: 2.4.1
I had to manually install these software. Probably you may not need sudo pip which I could have messed up originally with my python install from brew.
brew install libpulsar
sudo pip install -U --ignore-installed six
sudo pip install pulsar-client==2.4.1.post1

I also did try to uninstall 2.4.1.post1 and install pulsar-client=2.4.1 too. It seems not to make any difference. I speculate it all depends whether _pulsar.so can be accessible by python. Producer and consumer with SSL enabled with our production were tested and I just manually copied the root CA certificate in PEM format to a local file as following.
trust_certs='./ca-certificates.crt'
client = pulsar.Client(service_url,
                        authentication=pulsar.AuthenticationToken(token),
                        tls_trust_certs_file_path=trust_certs)

I hope this helps.

Any other work arounds for this? None of the above work for me (have not attempted to build from source). Thanks

I am getting same error.  I tried everything mentioned above and didn't work.
_pulsar.cpython-37m-darwin.so, 2): Symbol not found: __Py_tracemalloc_config
E     Referenced from: .tox/py37-osx/lib/python3.7/site-packages/_pulsar.cpython-37m-darwin.so
E     Expected in: flat namespace

We have already started supporting 10.14 since 2.5.x. I have verified that 2.5.2 works locally at my laptop. (10.14.6).
Can you try the latest release?

still getting this.
pulsar-client=2.8.0
python3.9

Closed and cannot reproduce.
I suggest new version and new symptom can indicate different root cause. Close this issue as an umbrella for different issues.


chore(backend): update sentry from 7 to 8 and improve error handling

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Removed MAS macro from this script

Purpose
MAS should not be defined in this script
Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test
run the script on a linux device

It is there in the 32bit version

It is there in the 32bit version
Ack! you're right that should be fixed too!

We aren't downloading the binaries for MAS in those scripts!
With this PR I'm just trying to fix the current state which is broken. We can improve the scripts later.

Is it broken, or just wrong?
From my testing it was working, I agree it should be changed.


Make it clear that university students should specify school (uni) as well

Hey, I would like to help with this issue. Can you assign it to me ?


CPU: Im2Col performance drop between 0.9.1 and 1.0.0-SNAPSHOT

Machine: Windows 10, Native backend, 5960x @ 4GHz
CUDA 8 (to compare w/ 0.9.1), Titan X (Pascal)
Native:
0.9.1: (5 runs)
Average im2col: 5.77
Average im2col: 6.52
Average im2col: 5.53
Average im2col: 6.61
Average im2col: 6.28
1.0.0-alpha:
Average im2col: 156.53
Master:
Average im2col: 158.46
CUDA 8:
0.9.1:
Average im2col: 0.14
Average im2col: 0.12
Average im2col: 0.13
1.0.0-alpha:
Average im2col: 10.21
Average im2col: 10.11
Average im2col: 9.96
Master:
Average im2col: 10.24
Average im2col: 10.15
Average im2col: 10.07
public class SimpleIm2ColBenchmark {

    public static void main(String[] args) {

        int[] inputShape = new int[]{16, 3, 224, 224};
        INDArray input = Nd4j.create(inputShape);

        //First im2col call (first AlexNet layer)
        int miniBatch = 16;
        int outH = 55;
        int outW = 55;
        int inDepth = 3;
        int kH = 11;
        int kW = 11;
        int sx = 4;
        int sy = 4;
        int ph = 2;
        int pw = 2;
        boolean isSameMode = false;

        INDArray col = Nd4j.createUninitialized(new int[]{miniBatch, outH, outW, inDepth, kH, kW}, 'c');
        INDArray col2 = col.permute(0, 3, 4, 5, 1, 2);

        int nIter = 100;

        long start = System.currentTimeMillis();
        for (int i = 0; i < nIter; i++) {
            Convolution.im2col(input, kH, kW, sy, sx, ph, pw, isSameMode, col2);
        }
        long end = System.currentTimeMillis();

        double avg = (end - start) / (double) nIter;
        System.out.println("Average im2col: " + avg);
    }
}

Looks like Col2Im is similarly affected:
Native:
0.9.1:
Average col2im: 23.59
Average col2im: 23.56
Master:
Average col2im: 93.63
Average col2im: 93.43
CUDA 8:
0.9.1:
Average col2im: 0.13
Average col2im: 0.13
Master:
Average col2im: 9.55
Average col2im: 9.86
    public static void main(String[] args) {

        int[] inputShape = new int[]{16, 3, 224, 224};
        INDArray input = Nd4j.create(inputShape);

        //First im2col call (first AlexNet layer)
        int miniBatch = 16;
        int inH = 224;
        int inW = 224;
        int outH = 55;
        int outW = 55;
        int inDepth = 3;
        int kH = 11;
        int kW = 11;
        int sx = 4;
        int sy = 4;
        int ph = 2;
        int pw = 2;

        INDArray eps6d = Nd4j.create(kW, kH, inDepth, outW, outH, miniBatch);
        eps6d = eps6d.permute(5, 2, 1, 0, 4, 3);
        INDArray epsNext = Nd4j.create(inDepth, miniBatch, inH, inW).permute(1, 0, 2, 3);

        int[] expEps6dShape = new int[]{16, 3, 11, 11, 55, 55};
        if(!Arrays.equals(expEps6dShape, eps6d.shape())){
            throw new RuntimeException();
        }

        int[] epsNextShape = new int[]{16, 3, 224, 224};
        if(!Arrays.equals(epsNextShape, epsNext.shape())){
            throw new RuntimeException();
        }

        int nIter = 100;

        long start = System.currentTimeMillis();
        for (int i = 0; i < nIter; i++) {
//            Convolution.col2im(eps6d, epsNext, sy, sx, ph, pw, inH, inW, 1, 1);
            Convolution.col2im(eps6d, epsNext, sy, sx, ph, pw, inH, inW);
        }
        long end = System.currentTimeMillis();

        double avg = (end - start) / (double) nIter;
        System.out.println("Average col2im: " + avg);
    }

CPU I guess?
With best regards,
Vyacheslav K.

On Apr 17, 2018, at 14:57, Alex Black<EMAIL_ADDRESS>wrote:
Looks like Col2Im is similarly affected:
Native:
0.9.1:
Average col2im: 23.59
Average col2im: 23.56
Master:
Average col2im: 93.63
Average col2im: 93.43
CUDA 8:
0.9.1:
Average col2im: 0.13
Average col2im: 0.13
Master:
Average col2im: 9.55
Average col2im: 9.86
public static void main(String[] args) {

    int[] inputShape = new int[]{16, 3, 224, 224};
    INDArray input = Nd4j.create(inputShape);

    //First im2col call (first AlexNet layer)
    int miniBatch = 16;
    int inH = 224;
    int inW = 224;
    int outH = 55;
    int outW = 55;
    int inDepth = 3;
    int kH = 11;
    int kW = 11;
    int sx = 4;
    int sy = 4;
    int ph = 2;
    int pw = 2;

    INDArray eps6d = Nd4j.create(kW, kH, inDepth, outW, outH, miniBatch);
    eps6d = eps6d.permute(5, 2, 1, 0, 4, 3);
    INDArray epsNext = Nd4j.create(inDepth, miniBatch, inH, inW).permute(1, 0, 2, 3);

    int[] expEps6dShape = new int[]{16, 3, 11, 11, 55, 55};
    if(!Arrays.equals(expEps6dShape, eps6d.shape())){
        throw new RuntimeException();
    }

    int[] epsNextShape = new int[]{16, 3, 224, 224};
    if(!Arrays.equals(epsNextShape, epsNext.shape())){
        throw new RuntimeException();
    }

    int nIter = 100;

    long start = System.currentTimeMillis();
    for (int i = 0; i < nIter; i++) {

//            Convolution.col2im(eps6d, epsNext, sy, sx, ph, pw, inH, inW, 1, 1);
Convolution.col2im(eps6d, epsNext, sy, sx, ph, pw, inH, inW);
}
long end = System.currentTimeMillis();
    double avg = (end - start) / (double) nIter;
    System.out.println("Average col2im: " + avg);
}

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Can you please modify both tests, and run again on CUDA 8.
Add Nd4j.getExecutioner().commit(); right after im2col/col2im calls within loop.

Also, please measure on Linux, not Windows. Windows do not have values < 1ms for timers, so result of Average col2im: 0.13 is bs by definition.

Updated:
int nIter = 100;

long start = System.currentTimeMillis();
for (int i = 0; i < nIter; i++) {
	Convolution.im2col(input, kH, kW, sy, sx, ph, pw, isSameMode, col2);
	Nd4j.getExecutioner().commit();
}
long end = System.currentTimeMillis();

Windows
0.9.1, CUDA 8 (Titan X):
Average im2col: 9.32
Average im2col: 9.26
Master, CUDA 8 (Titan X):
Average im2col: 9.86
0.9.1, Native:
Average im2col: 5.8
Average im2col: 5.32
Average im2col: 5.78
Master, Native:
Average im2col: 153.96

Partially fixed and merged. col2im is significantly faster now for all cases, im2col is meh... Probably we'll have to do something else.


Running pr checks outside of containers

Summary
Attempting to run pr checks without docker potentially reducing the wait time dramatically.

/retest


Zooniverse

[ Project Lead ] @mrniaboc
[ GitHub Repo ] https://github.com/zooniverse
[ Track ] Citizen Science: you're looking for participants in your citizen science project
[ Level ] Beginner
Description
The Zooniverse is the world’s largest and most popular platform for people-powered research. This research is made possible by volunteers—hundreds of thousands of people around the world who come together to assist professional researchers. Our goal is to enable research that would not be possible, or practical, otherwise. Zooniverse research results in new discoveries, datasets useful to the wider research community, and many publications.

Want to Contribute?
Join us at the Global Sprint June 2-3. Leave a comment in this issue to let the project lead know you're interested in contributing during #mozsprint 2016!

Note to the Project Lead
Congrats, @mrniaboc! This is your official project listing for the Mozilla Science Global Sprint 2016. To confirm your submission, please complete the following:

[x] Provide a GitHub repository for work and discussion on your project
[ ] Confirm in a comment that at least one person will be available to review and answer questions on this project from 9-5 in their timezone on both June 2 & 3. Please specify timezone. :clock1:

Do you want to become a featured project? :tada:
Here are some exercises that will help your project be more inviting to new contributors. We hope you'll try to complete some of these as you prepare for #mozsprint.
If you complete all the exercises, your project will be eligible to be featured in our collection of open source science projects! Once you've finished this list, contact @acabunoc to submit your project for review.

[ ] README.md:
[ ] LICENSE:
[ ] CONTRIBUTING.md:
[ ] Roadmap or an Issue Tracker (with tasks to complete):
[ ] Data Reuse Plan (if applicable):
[ ] Code of Conduct:
[ ] Personas:

Hi, I'd like to contribute to this project.

hi, i would like to contribute to this project

Hi guys,
That's amazing, thanks! There are a couple of ways you can help us out with documentation or play around on the Zooniverse Project Builder and make your own citizen science project.
Check out this repo for more details https://github.com/aliburchard/ProjectBuilderDocumentation, and I'll be here to answer any questions that come up.

I would like to work on the documentation. May you please provide more details regarding these bulleted points:

document what still needs documenting (help much appreciated!)
figure out how to more effectively parse/organize the existing tutorial

I am interested to contribute in.
On Jun 3, 2016 9:19 PM, "Kaira Villanueva"<EMAIL_ADDRESS>wrote:

I would like to work on the documentation. May you please provide more
details regarding these bulleted points:

document what still needs documenting (help much appreciated!)

figure out how to more effectively parse/organize the existing
tutorial

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mozillascience/global-sprint-2016/issues/57#issuecomment-223616597,
or mute the thread
https://github.com/notifications/unsubscribe/AH95f4CMWm9hrdFlXgPxjez1hwJsV4hUks5qIE0ggaJpZM4Isfnz
.


Introduce generic_handle_cmd() and add ceph rbd handler

Currently storage engine plugins tightly couple with the iscsi command handling
which not only duplicate lines of code but also make plugin writing painful.
we can avoid it by adding one more indirction, a generic_handle_cmd(), which is
optional and can coexist with current command handling logic. With this added,
the command process can be split into two category:

one can register .handle_cmd to take the full control of command handling as
before
or else one can register .{read, write, flush} to only handle storage IO
stuff.

and then iscsi command handling can sit on top of the storage layer, meaning
that we can handle most of the commands without involving plugins, for e.g
COMPARE AND WRITE is implemented just by generic_handle_cmd().
What make it complex is how we deal with async storage APIs. We could start with
async APIs and build sync ones on top of them to have storage plugin only
implement async APIs. But initially I plan to start with sync APIs instead of
async ones because

it's simple and easy to verify the correctness.
it's easy to add async api later once upper iscsi layer is matured.
Pre-optimization is root of eveil.

Following patches will implement a rbd handler from scratch and adopt glfs
handler to generic_handle_cmd, leaving file and qcow handlers alone.
Todo:

add unmap(discard) operation
handle more commands (WRITE SAME, WRITE VERIFY, etc.)
redesign with or add async APIs.

@agrover any comments?

The ceph parts look ok to me.
Some comments for later versions when the basics are merged.
For compare and write, we actually do not want it common. It is easier for ceph to pass the command to the OSD and have it do its normal locking/serialization as long as the request is within an object which seems like the common case for the major user ESX. We then do not have to take an extra target side lock, when doing async in the future, or cluster type of lock for HA targets. So for future versions, when we get async support back, we do not have to worry about locking in tcmu for ceph at least.
Here is the compare and write PR for ceph. It needs work for librbd support still:
https://github.com/ceph/ceph/pull/8911
For write same, we have something similar where the OSD does most of the work:
librbd support
https://github.com/ceph/ceph/pull/10019
lower level librados
https://github.com/ceph/ceph/pull/8568

@mikechristie Thanks for your comments! Sounds great ceph is becoming more and more iscsi-aware by implementing the low level iscsi semantics APIs. Once these APIs are added, I think it is easy to add pass-through function into generic_cmd_handle(). For e.g, we can register command set in the plugin, then  generic_cmd_handle() check if the plugin have registered command set in the first place, and if yes, simply pass through the command that is one of the registered command set to the plugin, otherwise it goes to generic switch cases handling. For some other non-iscsi aware storage like glusterfs, sheepdog, we can simply register nothing and have generic_cmd_handle() handle the iscsi stuff.

hi @liuy sorry for the delay.
I think this looks really good. Please change all references in code or commitlogs from iscsi to SCSI, since that is more accurately what we're working with here.
We also need to document that there are now two ways to implement a tcmu-runner plugin handler. The current description of options is at the bottom of README.md. Add text to the README.md similar to the explanation you give above in this PR?
Finally, it would be great to emit a warning message in tcmur_register_handler if both handle_cmd and any of the new function pointers are set, which should never normally happen.
Much thanks!

@agrover I've addressed your comments and update the master branch :)

thanks!


Failed building IOS demo

Please make sure that this is a build/installation issue and also refer to the troubleshooting documentation before raising any issues.
System information (Please provide as much relevant information as possible)
OS Platform and Distribution (e.g. Linux Ubuntu 16.04, Android 11, iOS 14.4): MacOS 11.0.1
Bazel version: 5.1.1
XCode and Tulsi versions (if iOS): Xcode <IP_ADDRESS>E507, Tulsi
Describe the problem:
I am trying to build the IOS demo of mediapipe using tulsi. But when I pressed the "generate" button, it failed.
Failed to retrieve information about the Bazel workspace. This usually means that the contents of a BUILD file are incorrect or flags are missing. Read the message log carefully for details.
Project generation failed.
Generate[FAIL]: 0.1275s
Failed to create Xcode project.
A fatal error occurred. Please check the message window and file a bug if appropriate.
ERROR: /Users/cheungbh/Documents/mediapipe/mediapipe/examples/ios/helloworld/BUILD:34:16: in entitlements rule //mediapipe/examples/ios/helloworld:HelloWorldApp_entitlements: Traceback (most recent call last):
File "/private/var/tmp/_bazel_cheungbh/9c36f3b1980dc004d7818f2036a5cae3/external/build_bazel_rules_apple/apple/internal/entitlement_rules.bzl", line 270, column 40, in _entitlements_impl
bundling_support.validate_bundle_id(bundle_id)
File "/private/var/tmp/_bazel_cheungbh/9c36f3b1980dc004d7818f2036a5cae3/external/build_bazel_rules_apple/apple/internal/bundling_support.bzl", line 100, column 25, in _validate_bundle_id
fail("Invalid character(s) in bundle_id: "%s"" % bundle_id)
Error in fail: Invalid character(s) in bundle_id: "SEE_IOS_INSTRUCTIONS.mediapipe.examples.HelloWorld"
ERROR: /Users/cheungbh/Documents/mediapipe/mediapipe/examples/ios/helloworld/BUILD:34:16: Analysis of target '//mediapipe/examples/ios/helloworld:HelloWorldApp_entitlements' failed
ERROR: Analysis of target '//mediapipe/examples/ios/helloworld:HelloWorldApp' failed; build aborted:
General failure: Bazel aspects could not be built.

I have seen the issue https://github.com/google/mediapipe/issues/2084 and https://github.com/google/mediapipe/issues/50. The 2084 doesn't have any ideas, and 50 is totally unrelated.
Also, I am exactly following the step https://google.github.io/mediapipe/getting_started/ios.html
to build, and such an error occurs.

Hi @CheungBH ,
Marking it as duplicate https://github.com/google/mediapipe/issues/3342 and we are following up this with the team to get resolution.


how to provide a default value for a type when associated field is missing? (aside from new case defaults)

So, https://github.com/zio/zio-json/issues/181 seems to be one way.
BUT, my reading of how the option[A] implicit is written made me think that if i've marked a field as having that type,
missing field OR Null will both yield None. (which would be VERY VERY helpful for me). I've tried to do that with my code, but its clearly not working.
concretely: in https://github.com/zio/zio-json/blob/974132cc411fd0bf46d9206b68d793a07835c333/zio-json/shared/src/main/scala/zio/json/decoder.scala#L256-L277
specificaly:
  // Option treats empty and null values as Nothing and passes values to the decoder.
  //
  // If alternative behaviour is desired, e.g. pass null to the underlying, then
  // use a newtype wrapper.
  implicit def option[A](implicit A: JsonDecoder[A]): JsonDecoder[Option[A]] =
    new JsonDecoder[Option[A]] {
      private[this] val ull: Array[Char] = "ull".toCharArray

      override def unsafeDecodeMissing(trace: List[JsonError]): Option[A] =
        Option.empty

      def unsafeDecode(trace: List[JsonError], in: RetractReader): Option[A] =
        (in.nextNonWhitespace(): @switch) match {
          case 'n' =>
            Lexer.readChars(trace, in, ull, "null")
            None
          case _ =>
            in.retract()
            Some(A.unsafeDecode(trace, in))
        }
    }

so in my code, i wrote:
 implicit def decoder[A](implicit decoding : JsonDecoder[A]): JsonDecoder[Assumed[A]]
            = JsonDecoder.option[A].map(x =>
                  x match {
                      case None => MissingAssumed[A]()
                      case Some(v )=> FoundAssumed[A](v) }

yet i'm consistently seeing the .fieldName(missing) error from the parser for a field that has the type Assumed[A]
is this an error in my part, or that of the parser or the comments?

to be concrete, i've a type
case class Example(
  fieldName : Assumed[Bool]
)

(which is essentially an Option[Bool]),
i want to just have things be populated with my analogue of None when the field is missing.
I thought that provided instance for option handles this, but my experiments seem to point to know.
The default missing value support in current snapshot releases helps, but makes what would otherwise be a type directed definition turn into hand providing defaults across  hundreds of fields in many dozens of case classes.
Am i doing something wrong or is this just not working?

i guess phrased different, #181 provides a way to do defaults top down from the field definition. I'm hoping theres a bottom up mechanism using the right type instances for the decoders!

cc @fsvehla  :)

Correct me if I’ve misunderstood the requirements (a more complete example would be helpful in this case), but is this not what you’re looking for?
test("carazio") {
  import zio.json._

  sealed trait Assumed[+A]

  object Assumed {
    case object MissingAssumed        extends Assumed[Nothing]
    case class  FoundAssumed[A](v: A) extends Assumed[A]
  }

  implicit def decoder[A](implicit decoding: JsonDecoder[A]): JsonDecoder[Assumed[A]] =
    JsonDecoder.option[A].map { x =>
      x match {
          case None     => Assumed.MissingAssumed
          case Some(v ) => Assumed.FoundAssumed[A](v)
      }
    }

  case class Example(fieldName : Assumed[Boolean])
  implicit val exampleDecoder: JsonDecoder[Example] = DeriveJsonDecoder.gen[Example]

  assert("""{ "fieldName": null }""".fromJson[Example])(isRight(equalTo(Example(Assumed.MissingAssumed)))) &&
  assert("""{ "fieldName": true }""".fromJson[Example])(isRight(equalTo(Example(Assumed.FoundAssumed(true))))) &&
  assert("""{ "fieldName": false }""".fromJson[Example])(isRight(equalTo(Example(Assumed.FoundAssumed(false)))))
}

@cartazio I see, I’ve missed the requirement of the null case.
The derivation code calls the Option[A] decoder’s unsafeDecodeMissing first, which will throw.
This will require some more careful thinking; The example below should help for your use case though
test("carazio") {
  import zio.json._
  import zio.json.JsonDecoder.JsonError
  import zio.json.internal.RetractReader
  import scala.annotation.switch

  sealed trait Assumed[+A]

  object Assumed {
    case object MissingAssumed        extends Assumed[Nothing]
    case class  FoundAssumed[A](v: A) extends Assumed[A]
  }

  implicit def decoder[A](implicit A: JsonDecoder[A], opt: JsonDecoder[Option[A]]): JsonDecoder[Assumed[A]] =
    new JsonDecoder[Assumed[A]] {
      override def unsafeDecodeMissing(trace: List[JsonError]): Assumed[A] =
        Assumed.MissingAssumed

      def unsafeDecode(trace: List[JsonError], in: RetractReader): Assumed[A] =
        opt.unsafeDecode(trace, in) match {
          case None    => Assumed.MissingAssumed
          case Some(v) => Assumed.FoundAssumed[A](v)
        }
    }

  case class Example(fieldName : Assumed[Boolean])
  implicit val exampleDecoder: JsonDecoder[Example] = DeriveJsonDecoder.gen[Example]

  assert("""{ "fieldName": null }""".fromJson[Example])(isRight(equalTo(Example(Assumed.MissingAssumed)))) &&
  assert("""{ "fieldName": true }""".fromJson[Example])(isRight(equalTo(Example(Assumed.FoundAssumed(true))))) &&
  assert("""{ "fieldName": false }""".fromJson[Example])(isRight(equalTo(Example(Assumed.FoundAssumed(false))))) &&
  assert("""{ }""".fromJson[Example])(isRight(equalTo(Example(Assumed.MissingAssumed))))
}

I think I’ll have a few soon as well.

Yea this last example is exactly what I’m hitting/wanting!

I’ll double check and confirm after some rest

style question: i thought implicit resolution worked better when you put them in the associated object object Assumed here, and that, aside from namespacing, the actual case/object class instances neednt be in that object?
this example should help me a great deal, i'll try it out and get back to you on that

I think this solves my problem (and works around that bug in the composition of the option parser for now)
thank you very very much! this has made a monstrous migration a teeny bit more humane for me :)

style question: i thought implicit resolution worked better when you put them in the associated object object Assumed here, and that, aside from namespacing, the actual case/object class instances neednt be in that object?

The codecs should be in the case object to be picked up by Scala’s implicit resolution.
Enclosung the subtypes of the sealed trait in the case object is a purely stylistic choice.

so i think your second example might be slightly incorrect,
that
       opt.unsafeDecode(trace, in) match {
          case None    => Assumed.MissingAssumed
          case Some(v) => Assumed.FoundAssumed[A](v)

should instead be
       JsonDecoder.option(A).unsafeDecode(trace, in) match {
          case None    => Assumed.MissingAssumed
          case Some(v) => Assumed.FoundAssumed[A](v)

?

OR theres a bug in the generic deriving codes, i'm not sure which

looks like i had defined / rederived Option[A] instances and forgot about it

hrm, should this all be marked fixed? :)

Good call.


Online tool to customize the iconset

Use https://github.com/PolymerLabs/polyicon and replace the Material design icons with our Vaadin icons, and deploy somewhere under vaadin.com (as an MVP deploy in GitHub).

Another, possibly better alternative (which we might actually be able to adopt, as the current maintainer has lost interest): https://github.com/ilikerobots/polyicon


Func as method param gives compiler error

Consider the following code
[Zomp.SyncMethodGenerator.CreateSyncVersion]
public async Task FooAsync(Func<int, Task> bar)
{
    await bar(5);
}

It will generate the following
public void Foo(global::System.Func<int> bar)
{
    bar(5);
}

This will fail to compile because the int has suddenly become a return value instead of a param for the delegate error CS1593: Delegate 'Func<int>' does not take 1 arguments
A Func<..., Task> should probably be transformed to a Action when Task is the return value.

Will be available in 1.3.36 in the next 10 minutes.
This case was already being handled in the local variable declaration, so the same logic was reused for parameter.

Thanks for submitting


Add additional user information

While designing a bit, I wondered, why we don't have fields/columns for the following user information data:

name
lastname

Moreover I'd suggest to make the name unique as well, because a username should of course be unique, not just the email.
What do you think @bambamboole

name unique is ok. But I dont like the first name last name thingy.

I'll close this for now.


Make list layout on desktop be two column and arrange by state

@saikat i've pushed a PR for this ;-)

Can we close this?


fix(all): add missing feature flags

Fixes #302

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.007%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
3930

Relevant Lines:
6140

💛  - Coveralls


Use provided three.js canvas ID in three.js helper

Currently, the API of the three.js helper allows a canvas ID to be passed in for the three.js canvas, but that parameter is ignored when finding the canvas in the DOM. This change fixes that behavior to respect the canvas ID that is passed in.

Hi,
Thank you for this PR proposal but to keep backward compatibility you need to provide a default value for spec.threejsCanvasId which would be 'threejsCanvas'. I suggest something like:
 const threejsCanvasId = (typeof(spec.threejsCanvasId)==='undefined')?'threejsCanvas':spec.threejsCanvasId;
 threejsCanvas=document.getElementById(threejsCanvasId);

I cannot accept your PR as this since it may break some demos where spec.threejsCanvasId is undefined.
Best,
Xavier

If spec.threejsCanvasId is undefined it should never hit this code block since it's wrapped in an if statement, correct? However, we could add a check to make sure spec.threejsCanvasId is of type string if we're concerned about that.

Yes you are right I didn't read the wrapping if statement


Fix data races

Add race detection on Travis CI. Thanks to @ppknap for the suggestion. I also updated the settings in AppVeyor to test Windows.
An additional test by @ppknap. See #102.
Fix for race condition in inotify test suite on Linux (tested).
Fix for race condition in Close with kqueue on Mac and BSD (tested). #99

I've rebased in squashed commits to (somewhat) avoid test failures in the history.

LGTM :+1:

Thanks for your review.


Update dlp-policy-reference.md

@Pulkit-Sachan Thanks for your feedback! New issues and pull requests for this content are closed while we update this content to support upcoming feature improvements.


propagate errors during async refresh

resolves #636

Thanks for this contribution. Changing the return type of the triggerAsyncRefresh method from void to CompletableFuture<Void> would cause binary backwards incompatibility. Is there a reason to not simply use the synchronous flavor triggerRefresh/triggerRefreshTo in your application?

Is there a reason to not simply use the synchronous flavor triggerRefresh/triggerRefreshTo in your application?

We have been following the reference implementation. We have since switched to the sync alternative since dicsovering this issue but it may lead to false assumptions when you pass in a refreshExectutor to your consumer that isn't used.
I just noticed that the same method is also used during the getInitialLoad() which wont trip the catch block.
Would an alternative solution be to deprecate these methods and add new ones with the new return type?


Add routes/filters that take just request, just response, and neither:

RequestRoute: handle(request)
ResponseRoute: handle(response)
EmptyRoute: handle()
RequestFilter: handle(request)
ResponseFilter: handle(response)
EmptyFilter: handle()

Also, overload get/post/before/after with Request/Empty Route/Filter for lambdas

Just curious, why to not let OOP to do the job?
Just leave generic Route\Filter methods like public static void get(String path, Route route)
Imho, the Spark is greate cos it simple there is no need in complication by adding RequestRoute\RequestFilter it can be done on user side if needed.

The commit mostly just adds some simple boilerplate and overloads. Are you worried that having these extra interfaces will confuse users?
Being able to do:
get("/hello", () -> "Hello");
get("/hello", req -> "Hello");

EmptyRroute route = () -> {
   // Whatever is returned is independent of request/response
}

RequestRoute route = (Request req) -> {
   // Whatever is returned depends only on request
}

Is good for conveying the intent of the programmer, and it makes it a lot easier to read for someone who is unfamiliar with the code.
It's hard to draw a line between what users should implement themselves and what should be in the framework, but in this case I don't see how anyone would implement it themselves without adding a big chunk of non-project code to their projects.

Thanks for the answer!
In my opinion KISS for Spark is the 1st target - we already had Spring.
Referring to #513, get("/hello", () -> "Hello") can be implemented with standard Supplier<T> and additional method in builder.
class Route{
 static class Builder{
   ...
   static Buider buildGet(String path, Supplier<String> handler){
     handler = (req, resp) -> handler.get();
   }

   Builder accept(MimeType type){...}

   //allows to "clone" similar routes
   Route toBuilder(){}
 }
}

Will not be added to core.


Suppress compiler warning on potential buffer overflow

The compiler gives the warning at (this issue):
error: '__atomic_load_8' writing 8 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=]

In file included from /janus/3p/mimalloc/include/mimalloc/internal.h:17,
                 from /janus/3p/mimalloc/src/heap.c:9:
In function 'mi_heap_page_is_valid',
    inlined from 'mi_heap_page_collect' at /janus/3p/mimalloc/src/heap.c:95:3:
/janus/3p/mimalloc/src/heap.c:62:22: error: '__atomic_load_8' writing 8 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=]
   62 |   mi_assert_internal(segment->thread_id == heap->thread_id);
      |                      ^~~~~~~

It is detecting a potential buffer overflow when accessing the thread_id in the segment structure. The warning suggests that the compiler believes the thread_id is being accessed in a way that could lead to reading or writing beyond the allocated memory of the structure.
This PR suppress this warning as I believe the code is safe (the false positive)

I think the warning is due to reading the atomic directly -- I added a mi_atomic_load_relaxed -- hopefully that fixes the warning? Let me know. (I am always hesitant to add compiler specific pragma's etc)


Mask a token in ktrain

Hi, I just want to check, if I want to simplify my model and mask some tokens with "[MASK]", is it a correct way to do it? When I try to do predictor.explain, it prints out "mask" token without square bracket so I wonder if it treats the token as a "masked token" or a normal word "mask". Thanks in advance!

Hello:  Do you mean that you're supplying "[MASK]" as input to predictor.explain?

Yes, that's right.

Hi @aphuongle95 : The explain method uses the eli5  (and lime) to generate the explanation.  It is model-agnostic and not specific to BERT, so does not understand "[MASK]" as a mask token.    Although this isn't supported right now, it may be possible for you to mask tokens yourself by invoking eli5 yourself and using MaskingTextSampler. I haven't used or tried it myself, though.


Continuous Prompt for LaraDumps Package Update Despite Acknowledgment

Currently, on Windows 11 with the LaraDumps app installed, there seems to be an unexpected behavior. Upon utilizing the ds() call, a dialog prompt appears, notifying about a LaraDumps package update availability. Despite clicking "OK" to acknowledge the update, the prompt keeps reappearing with every ds() call.
Expected Behavior:
The LaraDumps package update prompt should only appear once, and subsequent occurrences should be suppressed after acknowledgment.
Steps to Reproduce:

Install LaraDumps app on Windows 11.
Utilize the ds() call in a Laravel project.
Observe the continuous appearance of the LaraDumps package update prompt with each ds() call.

Additional Information:

Operating System: Windows 11
LaraDumps Package Version: ^3.0
Laravel Project Version: ^10.0
Reproducibility: Consistently occurs with each ds() call.

This issue disrupts workflow and may lead to inconvenience for users. Any insights or resolutions on resolving this matter would be greatly appreciated. Thank you.

Hello. Can you send a screenshot of laradumps with the modal open? This behavior is standard in laradumps in all calls to prevent using the app if it is outdated. But there seems to be a problem in your case. What version of laradumps-core was installed?

Hi @luanfreitasdev, thanks for your quick response

Here it is, also in this project these are the package versions:
"laradumps/laradumps": "3.0",
"laradumps/laradumps-core": "2.0",

It's also worth noting that I've reinstalled the app, but the situation remains the same.

If you update the dependencies, will this still happen?
composer require laradumps/laradumps --dev -W

yeah, I've updated both based on the modal, but it still persist


"Grebănu", "Homești" and "Livada" are listed in the drop-down menu

Description:
"Grebănu", "Homești" and "Livada" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Grebănu" in the search bar.

Expected results
The location is listed in the drop-down menu as "Grebănu, Buzău(Grebănu)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Homești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Homești, Buzău(Grebănu)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Livada" in the search bar.

Expected results
The location is listed in the drop-down menu as "Livada, Buzău(Grebănu)".


DeadDataFlowElimination will add type hint when removing a connector

Issue #1150 that DeadDataflowElimination removes a connector from a Tasklet which leaves a variable without type hint.
This PR tries to fix this bug by adding a type hint expression for a variable which is used in the tasklet. It adds the type hint only if the variable is used inside the tasklet code (I checked using ASTFindReplace).
The PR also adds a test which is literaly the code presented in #1150 and asserts the presence of the type hint and checks if it compiles.
May need confirmation

[ ] Did I use ASTFindReplace correctly?
[ ] If the type inference fails no type hint is added. Is it the right solution?
[ ] Does the test even make sense? (I don't have much experience in unit testing).

This is my first PR for this project so be patient with me.

@tbennun can you please approve the workflows?

Thank you for the PR! Unfortunately our CI is currently undergoing fixing so failing tests may not mean that your PR broke them.

@luca-patrignani as for your questions:

It is a bit of a nonstandard use for ASTFindReplace, but should be OK. Please add comments annotating what the try/except block means so that future developers can easily see that you do not intend to replace anything.
If done correctly, type inference should always pass, and if not the code generator will use the auto keyword (which was done before this PR and not always correct).
The test looks good. If you're already compiling the SDFG, I would also run it with random numpy arrays and verify that it produces the correct output (np.where will produce the same answer in the Python world).

@tbennun can you please approve the workflows once again?

@tbennun when you have some free time can we continue this PR review?

@luca-patrignani please stop merging the master branch to this one. When merging the PR, we will squash and merge the updated version as necessary.


[Bug] the network will crash if no edge provided

Version
1.8.4
Current Behavior
If edges is []:

then clicking the network chart with empty edges will cause crash:

Expected Behavior
Related code:
https://github.com/hypertrons/hypertrons-crx/blob/37ee797c269f0f5915c3a12c7996f560da698817/src/components/Graph.tsx#L44-L55
Environment
- OS: whatever
- Browser: whatever

Any additional comments?
I found this bug when exploring OpenGalaxy. Put the following code at the beginning of generateEdges should works:
    if (edges.length === 0) {
      return [];
    }

I can fix it~

/self-assign


advanced options not appearing

in my world, the options for NEI like healing yourself, changing the time of day, and changing gamemode, they do not appear in my inventory, but all the items do. i have tried every single option on NEI, but they still do not appear.

I've tried the options . Magnet mode does not work at this point in time. Here are the steps to follow:

Go to your inventory
Go down to where you see options and click on that
Go to Inventory button click on that
Click on Global then the letter W should show up on each of the options
Click on the w to enable them
Click on the global option at top right again and the options should show up.

If I missed some steps I will have to redo what I did before and see if I can figure out what I missed.

Indeed, you need to configure what widgets are enabled when in recipe mode.


[HUDI-1226] Fix ComplexKeyGenerator for non-partitioned tables

What is the purpose of the pull request
ComplexKeyGenerator getPartitionPath doesnt seem to work well with non-partitioned tables. Fix it and add test case
Brief change log

Ignore empty string for partition path fields
Return "" for partitionPath if there are no partition path fields defined

Verify this pull request
This change added tests
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@satishkotha was it throwing an exception before this change ?

From https://issues.apache.org/jira/browse/HUDI-1226,

If we pass empty string(-hoodie-conf hoodie.datasource.write.partitionpath.field=), generator returns 'default' as partitionpath
if we pass delimiter alone (-hoodie-conf hoodie.datasource.write.partitionpath.field=,), it throws
java.lang.StringIndexOutOfBoundsException: String index out of range: -1

at java.lang.AbstractStringBuilder.deleteCharAt(AbstractStringBuilder.java:824)
at java.lang.StringBuilder.deleteCharAt(StringBuilder.java:253)
at org.apache.hudi.keygen.KeyGenUtils.getRecordPartitionPath(KeyGenUtils.java:80)
at org.apache.hudi.keygen.ComplexKeyGenerator.getPartitionPath(ComplexKeyGenerator.java:52)
at org.apache.hudi.keygen.BuiltinKeyGenerator.getKey(BuiltinKeyGenerator.java:75)

@satishkotha was it throwing an exception before this change ?

From https://issues.apache.org/jira/browse/HUDI-1226,

If we pass empty string(-hoodie-conf hoodie.datasource.write.partitionpath.field=), generator returns 'default' as partitionpath
if we pass delimiter alone (-hoodie-conf hoodie.datasource.write.partitionpath.field=,), it throws
java.lang.StringIndexOutOfBoundsException: String index out of range: -1

at java.lang.AbstractStringBuilder.deleteCharAt(AbstractStringBuilder.java:824)
at java.lang.StringBuilder.deleteCharAt(StringBuilder.java:253)
at org.apache.hudi.keygen.KeyGenUtils.getRecordPartitionPath(KeyGenUtils.java:80)
at org.apache.hudi.keygen.ComplexKeyGenerator.getPartitionPath(ComplexKeyGenerator.java:52)
at org.apache.hudi.keygen.BuiltinKeyGenerator.getKey(BuiltinKeyGenerator.java:75)

@n3nash ^


Add links from reference manual to source code on GitHub

List of Changes

Enable links from reference manual to source code on GitHub

Explanation for Changes
The actual work is carried out by the codelink extension of Sphinx, in order to work the function linkcode_resolve is added. The way this is currently written ensures (in theory) that deployed documentation at RTD links to the correct versions, and when building everywhere else it links to our current master.
Testing Status
Links work in locally built documentation.
Further Comments
It is not (easily?) possible to have correct links for documentation previews deployed from merge requests.
Acknowledgement

[x] I have read the Contributing Guidelines

But on readthedocs theme it is done automatically. How? And why not in this theme?

I don't know.

I believe some themes come with pre-defined extensions. So maybe RTD theme is doing this already.
@behackl can you post an image of what the end product looks like? Where does the link show up and how? etc

Here is how it looks locally:

... and while writing this, RTD has also finished deploying, see it in action here: https://manimce--703.org.readthedocs.build/en/703/reference/manim.mobject.mobject.Mobject.html#manim.mobject.mobject.Mobject

Eventhough for PR it doesnt work but ok.

Ah, let me be more precise: for PRs, it also just defaults to link to our master branch. The links will still be there!

... ah, that was wrong; maybe I can do something. I'll investigate some more and send a follow-up PR in case this can be fixed.

Hmm, I get a 404 page when I tried it. The version number was the PR number?


Add support for dist-info directories

If using PEP517 directly (or for other reasons), it's possible to create a directory with the wheel metadata without doing a full build.
Please support parsing this information?

Support for parsing *.dist-info directories has been added in v1.6.0 via the inspect_dist_info_dir() function.


Join packages

Are this package related to this one - https://github.com/satya164/react-native-in-app-purchase ?
can u join them?
it looks like it has android support
@satya164 what do u think about it? ur package support monthly subscriptions ?(https://github.com/chirag04/react-native-in-app-utils/issues/25)

I'm not actively working on it anymore. Open to hand it over to anyone who wants to continue working on it.

@sibelius initial goal was to merge the two packages. Happy to accept a PR here or on satya's package that merges the two codebases.


[FEATURE REQUEST] Add new command to move/rename folder

Issues

[X] I have checked existing issues and there are no existing ones with the same request.

Feature description
We have TSLspRenameFile for file, could we also get TSLspRenameFolder to rename/move a folder, which contains other files? Probably, you could rename the folder and run TSLspRenameFile for each file in that folder and its subfolders.
Help
Yes, but I don't know how to start. I would need guidance
Implementation help
No response

So this (theoretically) already works–if you enable update_imports_on_move and rename a folder, it should handle everything correctly.
:TSLspRenameFile doesn't currently allow specifying a source (it always uses the current file) but I am planning on updating all of the commands once 0.7.0 is released, since the new nvim_add_user_command API makes defining commands in Lua a lot friendlier. If I have time, I may start working on this earlier, but this feature would only work on 0.7.0.

I gave this a shot but am actually not sure whether the language server supports this in the first place or whether there's some kind of conflict with how Neovim handles the relevant notification (it seems to require buffers to be loaded in order to apply text edits, but these are folders, so the concept of a buffer doesn't apply).
I don't plan on adding this here, but if someone wants to investigate and give it a shot, I think typescript.nvim is the place for it, since it's using the new command API and is generally much easier to work with.


Implement Member password verification

Depends on: https://github.com/molgergo01/BBG-Pictures-Repository-Backend/issues/13

Invalid dependency issue link, please check again


Add logic for card deletion

Resolves #43

Pull Request Test Coverage Report for Build 135

0 of 21 (0.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 68.331%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/AnakinParser/AnakinParser.java
0
1
0.0%

src/main/java/seedu/address/logic/AnakinParser/AnakinDelCardCommandParser.java
0
6
0.0%

src/main/java/seedu/address/logic/AnakinCommands/AnakinDelCardCommand.java
0
14
0.0%

Totals

Change from base Build 126:
-0.7%

Covered Lines:
1437

Relevant Lines:
2103

💛  - Coveralls


[Bug] Default libraries won't display

Describe the bug
Cannot get any libraries whose name is prepended with a space to load. Since HASS auto formats the yaml and removes the extra space when I try to prepend I cannot manually work around this. (Libraries & Collections not prepended with a space work as expected.)
To Reproduce
Steps to reproduce the behavior:

Set up with Plex server that prepends library name with a space
Try to create card using said library

Expected behavior
What happens makes sense (not an exact string match). Would be nice if it was possible to prepend spaces in the library name in the yaml or if the code would trim()
Screenshots
See value of library name bottom right:

Value in JSON payload directly from Plex server:

Checks
Please check below if true:
[X] I am running Home Assistant on HTTP protocol
[ ] I am running BOTH Home Assistant AND Plex on HTTPS protocol
[X] My Plex server is accessible through protocol, port and ip/hostname I have specified for the card.
[X] My Plex server is running on HTTPS and has a valid certificate.
Card Version
2.4.2
Plex Version
<IP_ADDRESS>33-757abe6b4
Additional context
Add any other context about the problem here.

What is the use case to have space in a library in Plex?
It is technically a bug and I will fix it, just wondering...

Could you do Code editor and then
libraryName: ' Movies'

Does the selection of library with prefixed space not work in UI configurator?

I don't necessarily think there is a use-case for having a prepended space. The Plex server is run by a friend of mine who shared his content with me so I don't have access to it to debug why it's prepended.
I tried manually adding the space via the code editor but as soon as the YAML validation runs it automatically trims it.
I was able to get it working locally by adding 3 trim()s but arguably what I did was a workaround as I'm no longer truly matching strings. I'd put in a PR with the changes but I'm pretty new to HASS and don't know enough about the ecosystem to know if the YAML validation is handled by HASS itself or custom components.

I just started looking into this, it

Cool, that feels 'more correct' to me to truly match the library name coming from Plex. I'll give these changes a try when I get home tonight.

Just a heads up, I have to leave soon so fix will not be available today, maybe during the weekend I will be able to get to it.

No rush, my local changes mean it's technically working at the moment. I'll follow up early next week.

@paco3346 should be working now in the latest main branch - not released yet. I need to clean it up and will release it during the weekend. Please let me know if you get the chance to test. I tested through UI config.


fix: Remove support to python3.6 due to jinja2

Codecov Report

Merging #1021 (3f2a42c) into develop (6f1e690) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1021   +/-   ##
========================================
  Coverage    90.98%   90.98%
========================================
  Files          173      173
  Lines         4860     4860
========================================
  Hits          4422     4422
  Misses         438      438

Flag
Coverage Δ

py3.8-ubuntu-latest-pandas
90.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

setup.py
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


review SigninRequest.isOidc

It's looking for response_type='id_token', which is now incorrect w/ code+pkce.

this isn't really a bug, it's just a poorly named API -- it should be called "requiresNonce". will address in 2.0 as breaking change.


Wrong Sleep time in ATKDEFMode

Current behavior:
Switch delay time is set to 50ms for the "switch back to def set" step instead to this.switchDelay
https://github.com/4RTools/4RTools/blob/afe6fc06e8e47071b6af409db5cb52c6157e1e46/Model/ATKDEFMode.cs#L74
This Value is correct for "switch to ATK set" step.
https://github.com/4RTools/4RTools/blob/afe6fc06e8e47071b6af409db5cb52c6157e1e46/Model/ATKDEFMode.cs#L56
Expected behavior:
"switch back to def set" step should press each key for the DEF set each this.switchDelay

Thank you, @nahuelr!! Do you mind open a PR for this one?

@nahuelr
Are you there?!

Thank you, @nahuelr!! Do you mind open a PR for this one?

Sure, i will work on this

@nahuelr Any updates?


Update regsvr32 page to include exit code definitions

Please update to include return code definitions
These were found on https://devblogs.microsoft.com/oldnewthing/20180920-00/?p=99785#:~:text=What do the various regsvr32 exit codes mean%3F,DllRegisterServer%2C DllUnregisterServer%2C or ... 5 Call it.

Exit code
Meaning

0
Success

1
Error parsing command line

2
OleInitialize failed

3
LoadLibrary failed

4
GetProcAddress failed

5
Registration function failed

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ba03ce5-dfcb-8492-9938-3eef9a744c3a
Version Independent ID: b3b1fe77-7cb2-cb83-c986-cbfb9a569d1a
Content: regsvr32
Content Source: WindowsServerDocs/administration/windows-commands/regsvr32.md
Product: windows-server
Technology: windows-commands
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Update Composer dependencies (2020-06-03-00-08)

Visual regression test passed!
View the visual regression test report


Python Guidelines: Add code samples to guidelines sections

Description
For the MQ Guidelines effort, we'd like the language guidelines to include code samples for API basics to the relevant sections.
Details:
Please add code samples for areas indicated by TODOs.  These include:

[ ] Code sample showing the basic Azure SDK API Shape
[ ] Code sample for client creation/construction
[ ] Code sample for setting the service version
[ ] Code sample for service method return type
[ ] Code sample for model types
[ ] Code sample for authentication

@salameer FYI


What about Swift Documentation?

New issue checklist

[ ] I have read the README, documentation, and FAQ.
[ ] Contributing guidelines confirmation: ____
[ ] I have searched existing issues and this is not a duplicate.

General information

JSQMessagesViewController version:
iOS version:
Devices/Simulators:
Reproducible in the demo project? (Yes/No):
Any related issues:

What happened?
Looking for Swift documentation, what about it? API is not the best way for understanding your product. Thanks.

@dartkinselok For Swift docs, what features of JSQMessageViewController do you want to know about it?

A document outlining basic chat operations should be enough and/or an example implementation in Swift should be really helpful.

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Include boot logs with mayday

Current situation
Mayday does not include boot logs.
Impact
We have to SSH to machines to view boot logs on machines that panic.
Ideal future situation
Automatically include boot logs.
Implementation options
Run journalctl -b -1 and record the output.

A PR for that is in https://github.com/flatcar-linux/mayday/pull/6 (both for the current boot and the previous boot).

Merged and scheduled for inclusion in the next Alpha and Edge release, then the following Beta and Stable releases.


[DOC] Broken link to one example.

Report incorrect documentation
This is a trivial issue. Please fix it if needed.
Location of incorrect documentation
Second example of https://github.com/rapidsai/notebooks-contrib#intermediate-notebooks
"Dask_with_cuDF_and_XGBoost_Disk"
Describe the problems or issues found in the documentation
Now, the link URL is below but this is 404.
https://github.com/rapidsai/notebooks-contrib/blob/master/intermediate_notebooks/examples/Dask_with_cuDF_and_XGBoost_Disk.ipynb
Steps taken to verify documentation is incorrect
Only click the link...
Suggested fix for documentation
The URL should be
https://github.com/rapidsai/notebooks-contrib/blob/master/intermediate_notebooks/examples/Dask_with_cuDF_and_XGBoost_from_Disk.ipynb
The current file name is "Dask_with_cuDF_and_XGBoost_Disk.ipynb" but correct name should be "Dask_with_cuDF_and_XGBoost_ from_ Disk.ipynb".

Hey @lazykyama, we updated the links in a recent readme update, and this notebook was retired (removed form the readme).  we're deciding on whether or not to have archived notebooks.  Thanks for the heads up though!


Run blocking tasks in parallel

By default io.vertx.core.Vertx#executeBlocking(java.util.concurrent.Callable<T>) is run tasks sequentially. That can cause performance degradation.
Replace all occurrences in the code with order=false to run tasks parallel.

fixed by https://github.com/epam/ai-dial-core/pull/329


Next release?

Is there any ETA on the next release to Puppet Forge? It looks like 1.5.0 is the latest available.

Hi @JamieCressey
On the forge, you are able to download 1.6.0.
But, this weekend I'll try to create release 1.7.0, with the pull requests which I accepted the last few weeks...
Kind regards,
Werner


Add trigger support for EventSub stream.online and stream.offline events

It would be great to have support for triggering stream.online and stream.offline events so I can easily test my applications using EventSub.

Definitely on the shortlist- goal is to get complete parity short-term, but will try and get this prioritized. :)

Definitely on the shortlist- goal is to get complete parity short-term, but will try and get this prioritized. :)

I appreciate it. Would definitely go back and update some blog posts. Would have attempted to add it but Go is not a language I know well enough.

I appreciate it. Would definitely go back and update some blog posts. Would have attempted to add it but Go is not a language I know well enough.


support  hex integers

Description
fix #3435
add support for receiving integers as decimal string or hex string, and outputting in these same formats
How was this PR tested?
added some unit tests

it was brought to my attention the goal is to support hex bytestrings, not hex integers. I'm closing this PR, and will create a new one with the right changes soon


CARDS-2495: Speed up queries involving forms for a specific subject

Tested live on YE.
To test:

build, start in prems mode
create two visit information forms
generate a token for one of the subjects
on the dashboard check that filtering the subjects by visit time, and filtering the forms by subject and visit time works

Yes, it is due to milliseconds, but the error seems to be on the frontend.

That filter error is fixed in #1725


Cannot create image from raw RGB data, unable to specify size

When trying to obtain a wand.image.Image object from a blob of raw RGB data, I get the following error::
>>> img = image.Image(blob=img['data'], format='RGB')
....
OptionError: must specify image size `buffer.RGB' @ error/rgb.c/ReadRGBImage/142

Setting the 'width' and 'height' parameters doesn't work either, as those seem to be reserved for creating blank images:
>>> img = image.Image(blob=img['data'], format='RGB', width=img['width'], height=img['height'])
TypeError: blank image parameters cant be used with image opening parameters

My previous version with PIL/Pillow worked flawlessly:
>>> img = Image.fromstring('RGB', (img['width'], img['height']), img['data'])

Been a while with no updates. What is the status of this issue? Is it still blocking on the API design discussion? Thanks.

Pull requests are always welcome, while I have no enough spare time to do this.

Thanks for the update. Will see what I can do.


The member 'FileList' in the module manifest is not valid

I followed the C# sample to connect to Exchange Online PowerShell.  I got this error:
The member 'FileList' in the module manifest is not valid: The path is not of a legal form.. Verify that a valid value is specified for this field in the 'C:\Program Files\WindowsPowerShell\Modules\ExchangeOnlineManagement\3.1.0\ExchangeOnlineManagement.psd1' file.
Do you have any idea what might be the reason?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 75e7a156-cd45-796e-b916-912fd0377668
Version Independent ID: d6afee4b-3324-705c-ddb9-a9f232146cb9
Content: Use C# to connect to Exchange Online PowerShell
Content Source: exchange/docs-conceptual/connect-to-exo-powershell-c-sharp.md
Service: exchange-online
GitHub Login: @chrisda
Microsoft Alias: chrisda

Checking

Thanks! I thought it was caused by old .Net Framework. My projects were using .Net Framework 4.6.1. I am getting the same errors after switching to .Net Framework 4.8.

@chriszohno Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Add config options to customize SpyMemcached's internal queues

I would like to provide custom implementations for Spy's operation queues, so I added some configuration options.
Default arguments are provided, and the default behavior is to use Spy's default queue implementations, so backwards compatibility is preserved. For existing Shade users, behavior will not change.

Done. It's on master.


Bugs with "Import/Update from URL"

"Import from URL" has wrong country field ID in JavaScript
Something's wrong with for example this event: https://amy.software-carpentry.org/workshops/event/2015-02-09-ucdavis (it uses remote that redirects to somewhere else, plus when we use the remote after redirection we get some errors). The officially saved URL is https://datacarpentry.github.io/2015-02-09-ucdavis/
Fix spaces around URLs

Thanks for this - I was just about to put in an issue to strip leading/trailing whitespace around urls.


DateTime answer type issue when date or time not specified

For a datetime answer type if the date or time part is not specified. The value for that node is empty.
e.g

For a date and time specified

<tmpllWhG5 id="tmpllWhG5"><my_date_time>2015-01-26T21:45:00.000+06:30</my_date_time>             <meta> <instanceID>uuid:63b84ef2-af71-406f-80c2-4a4c7787bc09</instanceID></meta></tmpllWhG5>

When date or time are not specified
<tmpllWhG5 id="tmpllWhG5"><my_date_time/><meta> <instanceID>uuid:63b84ef2-af71-406f-80c2-4a4c7787bc09</instanceID></meta></tmpllWhG5>

Expected: When the date or time part is not specified default the corresponding date or time part but the selected part should be retained.

Yes, that's actually by design but I am open to discussing an alternative.

When the date or time part is not specified default the corresponding date or time part but the selected part should be retained

I don't think I agree. It would cause an issue with the reliability of the submitted data as you won't be able to detect whether that part is a default-entered-by-enketo or value-entered-by-user. What should the default be?

Currently the date or time part selected is retained on the UI but the submitted data is empty. IMO the UI is a bit misleading, because the entered data is there on the widget but not submitted to the server.
Let me relate this to the number field.
When text is entered into a number field and the user tabs out to the next widget the text gets cleared. As user there is some visual feedback that the data won't be sent to the server.
Could something along those lines be done here?
One possible value for the default could be the current browser date/time.

Yes, I see what you mean. If the field is not required, the user could be thinking a value was entered and will be submitted.
It might be best to create an all-in-one datetime widget and whether we use defaults or not, never show an incomplete value in the UI.
Ideally, we should find a more comprehensive date/time/datetime picker library.

Do have a look at https://github.com/bevacqua/rome too.

Thanks. That looks quite interesting! At first glance the problems look to be:

no year selector (selecting a birthday is pretty tedious unless I'm missing a trick)
would need to add appearance=month-year and
appearance=year selector functionality

May still be a significant amount of work to solve those issues.

Thats true, the year and month-year would need customization.

If #1 is available #2 and #3 are probably not much work.


Update terms-of-use.md

@MicrosoftGuyJFlo

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


v4: Build issues in CI

Describe the bug
I was experiencing the following error when building in CI
error Unable to resolve module [SNIP]/node_modules/.cache/nativewind/global.css.native.css from [SNIP]/src/global.css:

None of these files exist:
  * node_modules/.cache/nativewind/global.css.native.css(.native|.ios.js|.native.js|.js|.ios.jsx|.native.jsx|.jsx|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx|.ios.css|.native.css|.css)
  * node_modules/.cache/nativewind/global.css.native.css/index(.native|.ios.js|.native.js|.js|.ios.jsx|.native.jsx|.jsx|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx|.ios.css|.native.css|.css)
> 1 | @tailwind base;
  2 | @tailwind components;
  3 | @tailwind utilities;
  4 |.

To Reproduce
rm -rf node_modules/.cache/nativewind
node node_modules/react-native/cli.js bundle --entry-file index.js --platform ios --dev false --minify false --bundle-output /tmp/main.jsbundle --assets-dest /tmp/dev.app --sourcemap-output main.jsbundle.map

Expected behavior
The app builds without any issues
Expo Snack
N/A
Screenshots
N/A
Additional context
This was a marathon debugging session, as I could only replicate it in CI.
This is what happens during the bundling process

node_modules/.cache/nativewind/global.css.native.css doesn't exist
Metro builds a cache of the file tree https://github.com/facebook/metro/blob/main/packages/metro-file-map/src/index.js#L336-L406
tailwind-cli runs and creates global.css.native.css
metro tries to use the file. The file map doesn't have it cached even though it exists on disk so it fails to find it

I think the difference to react-native start is that the same thing happens but watchman is run by the file-map and picks up the new file.
A workaround in CI is to do the following
mkdir -p node_modules/.cache/nativewind
touch node_modules/.cache/nativewind/global.css.native.css

In terms of a proper fix, perhaps touch the file at https://github.com/marklawlor/nativewind/blob/main/packages/nativewind/src/metro/index.ts#L52

Which version are you using?
Be aware that carat ^ versioning does not work for pre-releases. If you are using a carat in your package.json, please remove it and specify the latest version.

Which version are you using?

"nativewind": "4.0.0-alpha.25"

I just tested with .26 same issue

With Expo we do the follwing, maybe a similar hook to be used with bare RN project (to generate CSS file after installing dependencies)
https://github.com/marklawlor/nativewind/issues/591#issuecomment-1777414561

Should be fixed in the latest alpha. If your still having issues can you please follow this comment https://github.com/marklawlor/nativewind/issues/591#issuecomment-1783662675
Closing in favour of #591

the options.hot fix from a few days ago fixed this for me

This issue persists for me when running expo export -p web with "nativewind": "^4.0.22" when i haven't build the project before (like in CI).
Running tailwindcss -i ./assets/main.css -o ./node_modules/.cache/nativewind/global.css.native.css before building works though.
my metro config looks like this:
// Learn more https://docs.expo.io/guides/customizing-metro
const { getDefaultConfig } = require("expo/metro-config");
const { withNativeWind } = require("nativewind/metro");

/** @type {import('expo/metro-config').MetroConfig} */
const config = getDefaultConfig(__dirname, {
  isCSSEnabled: true,
});

config.resolver.assetExts.push(
  "woff",
  "woff2",
);

module.exports = withNativeWind(config, {
  input: "./assets/main.css"
});

@jongbelegen thanks for the solution!! With the default metro.config.js from 4.0.1 nativewind, this work for me when I am exporting my app
yarn tailwindcss -i ./src/global.css -o ./node_modules/.cache/nativewind/global.css.web.css && npx expo export -p web


Firezone GUI does not react to close the key generation window

OS: Windows 10
Browser: Google Chrome Version 109.0.5414.75 (Official Build) (64-bit) - Latest
Firezone: 0.7.4 dockerized
There is a little bug - after the generation of the WireGuard key in the GUI Firezone, the generation window does not close. GUI does not react to close the window.

Thanks for the report @kinseii.

Does the modal close if you press the escape key or click outside the modal?
Could you share any browser console logs that appear at the time of click that may be relevant?

That'll help debug the issue. We do have an #1356 that helps ensure the modal is dismissed, but there could be another issue with your browser or session.

I updated to version 0.7.5 today and the problem is gone

Perhaps you can close Isuue

@jamilbk
Please reopen the Issue. I have a clarification - when you open the Add Device window, you can close it with a cross or with the Esc key. But when you press Download WireGuard configuration the window stops closing, you have to close the browser tab.

Thanks for the clarification.

If you could post relevant browser console logs and firezone container logs at the time of occurrence that would help us diagnose the issue.

I opened the browser console, but it's blank. I tried reloading the page, but it also stayed blank.

Nothing appears in the server logs when you click on the cross, there are only login logs
data-firezone-1  | 19:45:41.493 request_id=FzxqkxlnnnMccFgAAAyS [info] GET /
data-firezone-1  | 19:45:41.495 request_id=FzxqkxlnnnMccFgAAAyS remote_ip=20.25.hidd.en [info] Sent 302 in 2ms
data-firezone-1  | 19:45:41.597 request_id=Fzxqkx-WXdqAI08AAAyi [info] GET /user_devices
data-firezone-1  | 19:45:41.604 request_id=Fzxqkx-WXdqAI08AAAyi remote_ip=20.25.hidd.en [info] Sent 200 in 6ms
data-firezone-1  | 19:45:42.186 [info] CONNECTED TO Phoenix.LiveView.Socket in 48µs
data-firezone-1  |   Transport: :websocket
data-firezone-1  |   Serializer: Phoenix.Socket.V2.JSONSerializer
data-firezone-1  |   Parameters: %{"_csrf_token" => "GGUBI1wvFR9jGDE********************************ReV", "_live_referer" => "undefined", "_mounts" => "0", "_track_static" => %{"0" => "https://vpn-users-hidd.en/dist/unprivileged-f5863ffa9667a9***********************.css?vsn=d", "1" => "https://vpn-users.hidd.en/dist/unprivileged-407b7514465bcf******************b.js?vsn=d"}, "vsn" => "2.0.0"}
data-firezone-1  | 19:45:42.472 [info] CONNECTED TO FzHttpWeb.UserSocket in 169µs
data-firezone-1  |   Transport: :websocket
data-firezone-1  |   Serializer: Phoenix.Socket.V2.JSONSerializer
data-firezone-1  |   Parameters: %{"token" => "SFMyNTY.g2gDbQAA***********i1lYjdhLTQyZj*********************************NuEjH8K7_VsxfUdMqj32y3ehaI6_eTiw", "vsn" => "2.0.0"}
data-firezone-1  | 19:45:42.571 [info] JOINED notification:session in 757µs
data-firezone-1  |   Parameters: %{"token" => "SFMyNTY.g2gDbQ**********1lYjdhLT************************3VhQFiAAFRgA.Y2qHNZZ-9iDvglxWIeGJl7MTpbunXBMCe422cf-4cOE"}

@jamilbk
Please give me the instructions and I will make the necessary report. Thank you!

Hi @kinseii -- sorry but I'm having trouble reproducing. Tested with Firefox and Chrome on macOS. Is it possible you have a browser extension loaded that's conflicting somehow?
https://user-images.githubusercontent.com/167144/214430443-585a56e8-3f7d-45b8-b9e7-75eccdbe276c.mov

@jamilbk Hi, have you clicked on Download WireGuard configuration?

https://user-images.githubusercontent.com/74458264/214949782-e85fce64-6e5a-4ece-95d1-dad6f0c7af6f.mov

None of the plugins are enabled.

Thanks! I was able to reproduce.


Can't replicate usage

Hello!
I've tried playing around with your project, however, after following the instructions in the README file, I can't get it to run.
After running $ vgo mod -vendor, this is the output in the console: https://gist.github.com/Oxyrus/82e1111479f757d954a3e3121bfe1d07
And once I run $ docker-compose up -d --build this is the output/error:
Building account_db
Step 1/3 : FROM postgres:10.3
 ---> b5ed9a4ab65b
Step 2/3 : COPY up.sql /docker-entrypoint-initdb.d/1.sql
 ---> Using cache
 ---> ade6d4dab6a2
Step 3/3 : CMD ["postgres"]
 ---> Using cache
 ---> 18ec8160de75

Successfully built 18ec8160de75
Successfully tagged spidey_account_db:latest
Building account
Step 1/11 : FROM golang:1.10.2-alpine3.7 AS build
 ---> 44ccce322b34
Step 2/11 : RUN apk --no-cache add gcc g++ make ca-certificates
 ---> Using cache
 ---> dab491024018
Step 3/11 : WORKDIR /go/src/github.com/tinrab/spidey/account
 ---> Using cache
 ---> d8621f59b3f2
Step 4/11 : COPY vendor ../vendor
ERROR: Service 'account' failed to build: COPY failed: stat /var/lib/docker/tmp/docker-builder453847030/vendor: no such file or directory

My Go version is 1.10.3, I wonder if this is related to vgo because I've never used it before. Thanks a lot for any help provided!

It works for me.
$ go version
go version go1.10.3 linux/amd64
$ vgo version
go version go1.10.3 linux/amd64 vgo:2018-02-20.1
$ docker --version
Docker version 18.05.0-ce, build f150324
$ docker-compose --version
docker-compose version 1.21.2, build a133471

Does vendor directory exist? Try deleting vendor and go.mod, then update vgo and vgo mod -vendor again. I have no idea what's going on with that gist you linked :grin:

The vendor directory doesn't exist. I tried deleting go.mod and running vgo mod -vendor again and this was the output, just a bunch of errors: https://gist.github.com/Oxyrus/2ad6a71dc4f3808bcdd199e9bdbc664b


Allow null trees on Diff.treeToTree

Also, update Commit.getDiff to diff when no parents exists eg. the initial commit of a repository.

Looks good. I'll merge it in after tests green-light.

I left a few comments regarding the tests.

@tbranyen Check out the tests, just updated.

Perfect! Thanks :)

Thanks for the PR!


When multiple locales (in Next.js) getPathsFromContext() creates 404 paths for untranslated (in Drupal) nodes.

From https://next-drupal.org/docs/reference#getpathsfromcontext:
"If you have locales configured in your next.config.js file, it will automatically create localized routes."

When multiple locales (in Next.js) getPathsFromContext() creates 404 paths for untranslated (in Drupal) nodes.

Can you share the next.config.js?

Yes. And I also use next-i18next for i18n. Here is both configs.
next.config.js:
/** @type {import('next').NextConfig} */

const withPlugins = require("next-compose-plugins");
const { i18n } = require("./next-i18next.config");
const withPWA = require("next-pwa");

const nextConfig = {
  publicRuntimeConfig: {
    canonicalDomain: "https://greenwise.ru",
  },
  reactStrictMode: true,
  images: {
    domains: [process.env.NEXT_IMAGE_DOMAIN],
  },
  i18n,
  experimental: {
    outputStandalone: true,
  },
};

module.exports = withPlugins([
  [
    withPWA,
    {
      pwa: {
        dest: "public",
        disable: process.env.NODE_ENV === "development",
        register: true,
        sw: "/sw.js",
      },
    },
  ],
  [nextConfig],
]);

next-i18next.config.js:
const path = require("path");

module.exports = {
  i18n: {
    defaultLocale: "ru",
    locales: ["ru", "en"],
    localeDetection: false,
  },
  localePath: path.resolve("locales"),
};

I will try to reproduce this issue on clean next/drupal setup with the same language configuration.

@TheRuslan what does the pattern (path alias) for the node type looks like?
You should use [node:source:title] so that Next.js can automatically create the paths.

@shadcn I used [node:title] and tried [node:source:title]. I think in this case it doesn't matter.
I made an example with 2 nodes:

1 product which is translated node with the russian original and english translation
1 blog post which is untranslated node with the russian original only

In accordance with next-drupal documentation here https://next-drupal.org/docs/reference#getpathsfromcontext

If you have locales configured in your next.config.js file, it will automatically create localized routes.

So getPathsFromContext returns such result:
[
    {
        "params": {
            "slug": [
                "blog",
                "test-article-original-node-russian-without-translation"
            ]
        },
        "locale": "ru"
    },
    {
        "params": {
            "slug": [
                "blog",
                "test-article-original-node-russian-without-translation"
            ]
        },
        "locale": "en"
    },
    {
        "params": {
            "slug": [
                "product",
                "testovyy-produkt-original-node-russian"
            ]
        },
        "locale": "ru"
    },
    {
        "params": {
            "slug": [
                "product",
                "test-product-translated-node-english"
            ]
        },
        "locale": "en"
    }
]

We can see that it work fine with translated product, but for untranslated blog post it returns inexistent path for "en" locale (second path in this example).
And the more locales you have, the more non-existent paths will be returned.
That triggers another problems with next-sitemap for example.

Maybe we can check node for system field "content_translations" somewhere in getPathsFromContext or buildPathsFromResources and return only such path which is exist in both nextjs and drupal locales?

We could. I'll look into it.
For now, I think what you could do is use two different calls for paths.
const pathsWithLocale = await getPathsFromContext("node--product", context)
const pathsWithoutLocale = await getPathsFromContext("node--blog", {})

const paths = [
    ...pathsWithLocale,
    ...pathsWIthoutLocale,
]

Can you give this a try and let me know?

hi , have a selimlar problem with the stater kit :
in my drupal 10 ( varbase ) i have tow languages , defaut  /fr and /es .
the articles are not translated . every language has  it own articles .
in the starter kit the default language works fine but i get 404 in full es articles .
how can we deal with that ? is there any solution ?


Silence ToH PDB Building Output

Building a ToH PDB outputs a lot of logs which I think should be hidden by default.
There are generally two ideas I think about, and one that can be used (very) long term:

Have a bool silence parameter which will silence all logging from the PDB.
Have u_int verbosity which will give us some finer control, though as it stands, it will be identical to the silence.
Have a proper logging framework / set of macros which then the logging verbosity will be defined as part of the compilation (like a headless version).
Option 3 will take a lot of time, so which of options 1 and 2 do you prefer @nathansttt? Of course there is always the option of keeping things as-is and then I'll simply silence it in private repos.

I looked at it, and it seems like a verbosity flag was indeed added to the BuildPDB function.


Update countries.json

Jerusalem

Just like your last PR about this issue:, please see..
https://github.com/webpatser/laravel-countries/pull/25


Refactor ratechecker

This branch is currently still in development, please do not merge yet.  I would like to check how it does with code coverage.  Will flag when ready.
Ratechecker now uses serializer to do a lot of the parameter validations.  It seems to slow the performance a bit, like 10ms, but I am not sure if it is because the framework is slow or just that it does a lot of more validation than what we had before.

Coverage decreased (-0.41%) to 88.47% when pulling a627443a2febd3a5b2e4df4c3774445d43958814 on amymok:refactor-ratechecker into 2c5697542b4da0d54ed75cebba8882a9f4d91f33 on cfpb:master.

Coverage decreased (-0.19%) to 88.69% when pulling b90ccf6db08b13a05e6cfb84808741c12f3f5be2 on amymok:refactor-ratechecker into 2c5697542b4da0d54ed75cebba8882a9f4d91f33 on cfpb:master.

@fna I am done for now.  There are more I can do, but I think it is good for now and will refactor more later in another pull request.

:100: merging

I think New Relic would be a great tool to help you optimize and isolate slow queries,, Steve Sayre has the scoop on New Relic


Add a classifier property to the Distribution type(fixes #18698)

Signed-off-by: Xin Wang<EMAIL_ADDRESS>
Fixes #18698
Context

Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest (some tests failed, but seem not relavent)

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

I'm going to update it and add some more tests.

I found a potential problem with this implementations that would be nice to handle in some way:
If multiple distributions have the same distributionBaseName and only different archiveClassifiers, then the directories that their install*Dist tasks will put the distribution contents are still the same.
This could be fixed by appending the archiveClassifier to the installTask.into(...) directory here. If we go with this fix, the archiveClassifier will probably not be the best name, as the classifier will not only affect the archive.
Before this change, multiple distributions could have the same distributionBaseName, too, but that would hardly have valid use cases. With this change, the use case of building multiple distributions that have the same base name and only different classifiers is the one that can realistically lead to this issue.

@bot-gradle test ReadyForNightly

OK, I've already triggered the following builds for you:

ReadyForNightly build

@bot-gradle test and merge

No milestone for this PR. Please set a milestone and retry.

@bot-gradle test and merge


Feat: Add docker compose file for local development

Changes include:

Added docker compose file for local postgres instance
Added documentation for local development
Changed default config for auth enabled

Thanks for this PR @cbridges1 ! Do you mind adding missing code coverage as reported by codecov - https://github.com/guidewire-oss/fern-reporter/pull/132/checks?check_run_id=30480049150 ?

Thanks for this PR @cbridges1 ! Do you mind adding missing code coverage as reported by codecov - https://github.com/guidewire-oss/fern-reporter/pull/132/checks?check_run_id=30480049150 ? Once that is green, this should be ready to be approved and merged.

This should be ready now.


Scrollable div is not updated properly

From Ric Wright:
I am making progress with my widget (when I get time).  I got the messages starting to work.  I have two scrollable “windows”.  One is the iFrame the other is a div.
The controller’s div is:
<div id="controllerDiv" style="width:90%; height:400px;overflow:scroll;
         border-style:solid;border-width:1px;border-color:gray">

</div>

The controller div gets updated thusly:
	// Update the div element to display the sent-message.
	var newMsg = document.createTextNode("Message Sent: " + new Date());
	controllerDiv.appendChild(newMsg);
	controllerDiv.appendChild(document.createElement("br"));
	controllerDiv.scrollTop = controllerDiv.scrollHeight;

It almost works except that it only scrolls PART of the div:

The part below 13:25:01 never gets updated.  It’s like its scrolling only the upper part?

Ryan replied:
I can't reproduce the problem. See this jsfiddle that tries and emulates it. http://jsfiddle.net/mh06peg1/1/. Seems to work fine.

Ric replied:
Yes, in the browser is works fine.  In our RS it doesn’t.  See my email of a few minutes ago.  That snippet also works fine in the browser, but the equivalent doesn’t in our RS.  There is something about our implementation that causes problems. I’m not saying it is a bug, but it is a limitation.
The code has been pushed to the IDPF github repository here:
https://github.com/IDPF/scriptable-components/tree/feature/logger-widget/Samples/readium/logger-demo/embedded/logger-demo
Note that in iBooks there are no rendering artifacts in the controller window (unlike us) but the logger window doesn’t scroll “right” which I take to mean that I misunderstand how it should work.

Additional note: It works fine in the SDKLauncher-OSX.  That is, the left hand pane scrolls seamlessly. The right hand pane doesn't scroll properly but I assume that is because there is something I don't understand about iFrames and scrollTop.

Poked at this a bit more and it gets stranger.  What in  fact is not being updated is an area of the div.  And that area varies depending on what is being written, i.e how long the line is. In this example, the area outlined in red doesn't get updated.  UNTIL the button ("Send Message") loses the focus.  Then the scrollable div gets updated correctly...

Appears that this is a Chrome bug?

Ok, good news, bad news.  I noticed that when I adjusted the width of the window way down - to where the actual pixel width of the containing window was smaller than the fixed layout specified width, then it all worked fine. So I switched from the release version (2.18.1) to the develop branch.  And the scroll artifacts disappeared and the scrolling was fine.
BUT...  the right side of the page was clipped to the point that the scroll bars disappeared:

And it gets worse.  The clipping of the right side begins as soon as the width of the containing window is larger than the width of the fixed layout page.

I can only reproduce the update issue when the zoom level is above 100%.
There is nothing wrong with the extension or your html. It's definitely a chrome bug. It happens if I try to scroll the div without pressing the button. It may be related to this bug
I am unable to hide the scrollbars of the scrollable div. The containing frame either produces scrollbars or shrinks the content.

Right.  I only see the issue when the zoom level exceeds 100%.  In the released version, I see this scrolling artifact.  In the development branch, no scrolling artifact, but it gets clipped on the right.  Sounds like scaler-div land to me.
BTW, it's a fixed layout EPUB and the layout settings don't make any difference.

In the current version in the web store, the scroll mode affects fixed layout epubs. Not by much but it does change the html on the page that is displaying the content. Not sure if that is intentional

So this is a browser bug, right? Shall we close this issue?

Closing since it is out of our hands.


Add Plugins submit button

Adds a "Submit a plugin" to the plugins page.
Starts using more Typescript.
Makes the button component more convenient to use

uhh does this just redirect to the repo?

It just links to the plugins.toml.
Which looks like this now: https://github.com/hyprwm/hyprland-website/pull/76/files#diff-852d21b436f6f946d0ffbfe6b1a28aab321e2d3e6b1fcfc6740c38da8b6802f1
Do you have other ideas?

yep thats's fine, I was just scared you have made some form or whatever. That's cool


Don't emit raw binary in error messages

Codecov Report

Merging #984 into master will increase coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
+ Coverage    49.6%   49.65%   +0.04%
==========================================
  Files          29       29
  Lines        2038     2038
==========================================
+ Hits         1011     1012       +1
+ Misses        847      846       -1
  Partials      180      180

Impacted Files
Coverage Δ

core/client/verify.go
57.74% <0%> (ø)
:arrow_up:

core/client/client.go
28.07% <0%> (+0.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a158ae...ad26561. Read the comment docs.


Update media-center to v23

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

@commitay is it a common thing to trash folders in document instead of deleting them?

is it a common thing to trash folders in documents instead of deleting them?

trash is a relatively new feature but it is preferred in most cases.