Invalid topic name error when launching zed_camera.launch.py

Preliminary Checks

[X] This issue is not a duplicate. Before opening a new issue, please search existing issues.
[X] This issue is not a question, feature request, or anything other than a bug report directly related to this project.

Description
Hello, i have encountered this error when launching the wrapper with the command:
ros2 launch zed_wrapper zed_camera.launch.py camera_model:=zed2i
[component_container-2] [INFO] [1733414829.790032321] [zed.zed_node]: Camera-IMU Translation:
[component_container-2]  -0.002 -0.023061 0.000217
[component_container-2] [INFO] [1733414829.790224267] [zed.zed_node]: Camera-IMU Rotation:
[component_container-2] FFFFD08A1670
[component_container-2] 0.999985 0.004895 -0.002594
[component_container-2] -0.004901 0.999986 -0.002006
[component_container-2] 0.002584 0.002019 0.999995
[component_container-2]
[component_container-2] [INFO] [1733414829.790310928] [zed.zed_node]: *** Subscribers ***
[component_container-2] terminate called after throwing an instance of 'rclcpp::exceptions::InvalidTopicNameError'
[component_container-2]   what():  Invalid topic name: topic name must not be empty string:
[component_container-2]   ''
[component_container-2]    ^
[component_container-2]
[ERROR] [component_container-2]: process has died [pid 102219, exit code -6, cmd '/opt/ros/foxy/lib/rclcpp_components/component_container --ros-args -r __node:=zed_container -r __ns:=/zed'].

Steps to Reproduce

git clone  --recursive https://github.com/stereolabs/zed-ros2-wrapper.git
sudo apt update
rosdep update
rosdep install --from-paths src --ignore-src -r -y
colcon build --symlink-install --cmake-args=-DCMAKE_BUILD_TYPE=Release --parallel-workers $(nproc)
source the workspace

Expected Result
The wrapper node is launched correctly
Actual Result
This is the full log of after launching the node:
ros2 launch zed_wrapper zed_camera.launch.py camera_model:=zed2i
[INFO] [launch]: All log files can be found below /home/wrapper/.ros/log/2024-12-05-17-07-03-003395-wrapper-desktop-102203
[INFO] [launch]: Default logging verbosity is set to INFO
Using common configuration file: /home/wrapper/ros2_ws/install/zed_wrapper/share/zed_wrapper/config/common_stereo.yaml
[INFO] [robot_state_publisher-1]: process started with pid [102217]
[INFO] [component_container-2]: process started with pid [102219]
[robot_state_publisher-1] Parsing robot urdf xml string.
[robot_state_publisher-1] Link zed_camera_center had 2 children
[robot_state_publisher-1] Link zed_left_camera_frame had 1 children
[robot_state_publisher-1] Link zed_left_camera_optical_frame had 0 children
[robot_state_publisher-1] Link zed_right_camera_frame had 1 children
[robot_state_publisher-1] Link zed_right_camera_optical_frame had 0 children
[robot_state_publisher-1] [INFO] [1733414824.703258184] [zed.zed_state_publisher]: got segment zed_camera_center
[robot_state_publisher-1] [INFO] [1733414824.703679550] [zed.zed_state_publisher]: got segment zed_camera_link
[robot_state_publisher-1] [INFO] [1733414824.703799717] [zed.zed_state_publisher]: got segment zed_left_camera_frame
[robot_state_publisher-1] [INFO] [1733414824.703904394] [zed.zed_state_publisher]: got segment zed_left_camera_optical_frame
[robot_state_publisher-1] [INFO] [1733414824.703965294] [zed.zed_state_publisher]: got segment zed_right_camera_frame
[robot_state_publisher-1] [INFO] [1733414824.704017776] [zed.zed_state_publisher]: got segment zed_right_camera_optical_frame
[component_container-2] [INFO] [1733414824.803875680] [zed.zed_container]: Load Library: /home/wrapper/ros2_ws/install/zed_components/lib/libzed_camera_component.so
[component_container-2] [INFO] [1733414825.055269395] [zed.zed_container]: Found class: rclcpp_components::NodeFactoryTemplate<stereolabs::ZedCamera>
[component_container-2] [INFO] [1733414825.055590948] [zed.zed_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<stereolabs::ZedCamera>
[component_container-2] [INFO] [1733414825.517992398] [zed.zed_node]: ********************************
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/zed/zed_node' in container '/zed/zed_container'
[component_container-2] [INFO] [1733414825.518255196] [zed.zed_node]:       ZED Camera Component
[component_container-2] [INFO] [1733414825.518334464] [zed.zed_node]: ********************************
[component_container-2] [INFO] [1733414825.518396067] [zed.zed_node]:  * namespace: /zed
[component_container-2] [INFO] [1733414825.518506569] [zed.zed_node]:  * node name: zed_node
[component_container-2] [INFO] [1733414825.518602254] [zed.zed_node]: ********************************
[component_container-2] [INFO] [1733414825.569349521] [zed.zed_node]: *** DEBUG parameters ***
[component_container-2] [INFO] [1733414825.569906863] [zed.zed_node]:  * SDK Verbose: 1
[component_container-2] [INFO] [1733414825.570390536] [zed.zed_node]:  * Debug Common: FALSE
[component_container-2] [INFO] [1733414825.570841888] [zed.zed_node]:  * Debug Simulation: FALSE
[component_container-2] [INFO] [1733414825.571222580] [zed.zed_node]:  * Debug Video/Depth: FALSE
[component_container-2] [INFO] [1733414825.571463137] [zed.zed_node]:  * Debug Control settings: FALSE
[component_container-2] [INFO] [1733414825.571703822] [zed.zed_node]:  * Debug Point Cloud: FALSE
[component_container-2] [INFO] [1733414825.572069313] [zed.zed_node]:  * Debug GNSS: FALSE
[component_container-2] [INFO] [1733414825.572307054] [zed.zed_node]:  * Debug Positional Tracking: FALSE
[component_container-2] [INFO] [1733414825.572515225] [zed.zed_node]:  * Debug sensors: FALSE
[component_container-2] [INFO] [1733414825.572690466] [zed.zed_node]:  * Debug Mapping: FALSE
[component_container-2] [INFO] [1733414825.575436756] [zed.zed_node]:  * Debug Object Detection: FALSE
[component_container-2] [INFO] [1733414825.575666432] [zed.zed_node]:  * Debug Body Tracking: FALSE
[component_container-2] [INFO] [1733414825.576306754] [zed.zed_node]:  * Debug Streaming: FALSE
[component_container-2] [INFO] [1733414825.576953060] [zed.zed_node]:  * Debug ROI: FALSE
[component_container-2] [INFO] [1733414825.577516066] [zed.zed_node]:  * Debug Advanced: FALSE
[component_container-2] [INFO] [1733414825.577981403] [zed.zed_node]: *** GENERAL parameters ***
[component_container-2] [INFO] [1733414825.579872351] [zed.zed_node]:  * Camera model: zed2i - ZED 2i
[component_container-2] [INFO] [1733414825.580401531] [zed.zed_node]:  * Camera name: zed
[component_container-2] [INFO] [1733414825.581200742] [zed.zed_node]:  * Camera SN: 0
[component_container-2] [INFO] [1733414825.581484245] [zed.zed_node]:  * Camera timeout [sec]: 5
[component_container-2] [INFO] [1733414825.582211259] [zed.zed_node]:  * Camera reconnection temptatives: 5
[component_container-2] [INFO] [1733414825.582423494] [zed.zed_node]:  * Camera framerate: 15
[component_container-2] [INFO] [1733414825.583201520] [zed.zed_node]:  * GPU ID: -1
[component_container-2] [WARN] [1733414825.584166467] [zed.zed_node]: Not valid 'general.pub_resolution' value: 'MEDIUM'. Using default setting instead.
[component_container-2] [INFO] [1733414825.584296714] [zed.zed_node]:  * Publishing resolution: NATIVE
[component_container-2] [INFO] [1733414825.584733921] [zed.zed_node]:  * OpenCV custom calibration:
[component_container-2] [INFO] [1733414825.585346881] [zed.zed_node]:  * Camera self calibration: TRUE
[component_container-2] [INFO] [1733414825.585781657] [zed.zed_node]:  * Camera flip: FALSE
[component_container-2] [INFO] [1733414825.586578563] [zed.zed_node]:  * [DYN] Publish framerate [Hz]:  15
[component_container-2] [INFO] [1733414825.586758604] [zed.zed_node]: *** VIDEO parameters ***
[component_container-2] [INFO] [1733414825.586957527] [zed.zed_node]:  * [DYN] Brightness: 4
[component_container-2] [INFO] [1733414825.587604313] [zed.zed_node]:  * [DYN] Contrast: 4
[component_container-2] [INFO] [1733414825.587938955] [zed.zed_node]:  * [DYN] Hue: 0
[component_container-2] [INFO] [1733414825.588495624] [zed.zed_node]:  * [DYN] Saturation: 4
[component_container-2] [INFO] [1733414825.589077095] [zed.zed_node]:  * [DYN] Sharpness: 4
[component_container-2] [INFO] [1733414825.589265809] [zed.zed_node]:  * [DYN] Gamma: 8
[component_container-2] [INFO] [1733414825.589874482] [zed.zed_node]:  * [DYN] Auto Exposure/Gain: TRUE
[component_container-2] [INFO] [1733414825.590395565] [zed.zed_node]:  * [DYN] Exposure: 80
[component_container-2] [INFO] [1733414825.590824740] [zed.zed_node]:  * [DYN] Gain: 80
[component_container-2] [INFO] [1733414825.591349728] [zed.zed_node]:  * [DYN] Auto White Balance: TRUE
[component_container-2] [INFO] [1733414825.591619982] [zed.zed_node]:  * [DYN] White Balance Temperature: 42
[component_container-2] [INFO] [1733414825.591717139] [zed.zed_node]: *** DEPTH parameters ***
[component_container-2] [INFO] [1733414825.592089703] [zed.zed_node]:  * Depth mode: ULTRA [3]
[component_container-2] [INFO] [1733414825.592279921] [zed.zed_node]:  * Min depth [m]: 0.2
[component_container-2] [INFO] [1733414825.592707464] [zed.zed_node]:  * Max depth [m]: 10
[component_container-2] [INFO] [1733414825.592925523] [zed.zed_node]:  * Depth Stabilization: 1
[component_container-2] [INFO] [1733414825.593204194] [zed.zed_node]:  * OpenNI mode (16bit point cloud): FALSE
[component_container-2] [INFO] [1733414825.593519091] [zed.zed_node]:  * [DYN] Point cloud rate [Hz]: 15
[component_container-2] [INFO] [1733414825.593748447] [zed.zed_node]:  * [DYN] Depth Confidence: 50
[component_container-2] [INFO] [1733414825.593916744] [zed.zed_node]:  * [DYN] Depth Texture Confidence: 100
[component_container-2] [INFO] [1733414825.594197783] [zed.zed_node]:  * [DYN] Remove saturated areas: TRUE
[component_container-2] [INFO] [1733414825.594330942] [zed.zed_node]: *** GNSS FUSION parameters ***
[component_container-2] [INFO] [1733414825.594496775] [zed.zed_node]:  * GNSS fusion enabled: FALSE
[component_container-2] [INFO] [1733414825.594581131] [zed.zed_node]: *** POSITIONAL TRACKING parameters ***
[component_container-2] [INFO] [1733414825.594721459] [zed.zed_node]:  * Positional tracking enabled: FALSE
[component_container-2] [WARN] [1733414825.594982528] [zed.zed_node]: 'pos_tracking.pos_tracking_mode' not valid (''). Using default value.
[component_container-2] [INFO] [1733414825.595216717] [zed.zed_node]:  * Positional tracking mode: GEN 2
[component_container-2] [INFO] [1733414825.595395734] [zed.zed_node]:  * Map frame id: map
[component_container-2] [INFO] [1733414825.595605442] [zed.zed_node]:  * Odometry frame id: odom
[component_container-2] [INFO] [1733414825.595893841] [zed.zed_node]:  * Broadcast Odometry TF: TRUE
[component_container-2] [INFO] [1733414825.596157887] [zed.zed_node]:  * Broadcast Pose TF: TRUE
[component_container-2] [INFO] [1733414825.596433581] [zed.zed_node]:  * [DYN] Depth minimum range: 0
[component_container-2] [INFO] [1733414825.597170516] [zed.zed_node]:  * [DYN] TF timestamp offset: 0.05
[component_container-2] [INFO] [1733414825.597504550] [zed.zed_node]:  * [DYN] Path publishing rate: 2
[component_container-2] [INFO] [1733414825.597870778] [zed.zed_node]:  * Path history lenght: -1
[component_container-2] [INFO] [1733414825.598497819] [zed.zed_node]:  * Initial pose: [0,0,0,0,0,0,]
[component_container-2] [INFO] [1733414825.599015606] [zed.zed_node]:  * Area Memory: TRUE
[component_container-2] [INFO] [1733414825.599577588] [zed.zed_node]:  * Area Memory DB:
[component_container-2] [INFO] [1733414825.600182900] [zed.zed_node]:  * Camera is static: FALSE
[component_container-2] [INFO] [1733414825.600693679] [zed.zed_node]:  * Gravity as origin [not for ZED]: FALSE
[component_container-2] [INFO] [1733414825.601176201] [zed.zed_node]:  * IMU Fusion [not for ZED]: TRUE
[component_container-2] [INFO] [1733414825.601592575] [zed.zed_node]:  * Floor Alignment: FALSE
[component_container-2] [INFO] [1733414825.602012277] [zed.zed_node]:  * Reset Odometry with Loop Closure: TRUE
[component_container-2] [INFO] [1733414825.602467373] [zed.zed_node]:  * 2D mode: FALSE
[component_container-2] [INFO] [1733414825.602857378] [zed.zed_node]: *** Region of Interest parameters ***
[component_container-2] [INFO] [1733414825.603050636] [zed.zed_node]:  * Automatic ROI generation: FALSE
[component_container-2] [INFO] [1733414825.603692846] [zed.zed_node]:  * Manual ROI polygon: []
[component_container-2] [INFO] [1733414825.603807540] [zed.zed_node]: *** SENSORS STACK parameters ***
[component_container-2] [INFO] [1733414825.604193641] [zed.zed_node]:  * Broadcast IMU TF [not for ZED]: TRUE
[component_container-2] [INFO] [1733414825.604362642] [zed.zed_node]:  * Sensors Camera Sync: FALSE
[component_container-2] [INFO] [1733414825.604514426] [zed.zed_node]:  * Sensors publishing rate: 400 Hz
[component_container-2] [INFO] [1733414825.604603359] [zed.zed_node]: *** Spatial Mapping parameters ***
[component_container-2] [INFO] [1733414825.604783272] [zed.zed_node]:  * Spatial Mapping Enabled: FALSE
[component_container-2] [INFO] [1733414825.604949585] [zed.zed_node]:  * Spatial Mapping resolution [m]: 0.05
[component_container-2] [INFO] [1733414825.605089592] [zed.zed_node]:  * 3D Max Mapping range [m]: 10
[component_container-2] [INFO] [1733414825.605222976] [zed.zed_node]:  * Map publishing rate [Hz]: 1
[component_container-2] [INFO] [1733414825.605391720] [zed.zed_node]:  * Clicked point topic:
[component_container-2] [INFO] [1733414825.605531216] [zed.zed_node]:  * Plane Det. Max Dist. Thresh.: 0.15
[component_container-2] [INFO] [1733414825.605673207] [zed.zed_node]:  * Plane Det. Normals Sim. Thresh.: 15
[component_container-2] [INFO] [1733414825.605752860] [zed.zed_node]: *** Object Det. parameters ***
[component_container-2] [INFO] [1733414825.605871618] [zed.zed_node]:  * Object Det. enabled: FALSE
[component_container-2] [WARN] [1733414825.606188243] [zed.zed_node]: The value of the parameter 'object_detection.model' is not valid: ''. Using the default value.
[component_container-2] [INFO] [1733414825.606283736] [zed.zed_node]:  * Object Det. model: MULTI CLASS BOX FAST
[component_container-2] [INFO] [1733414825.606416511] [zed.zed_node]:  * Object Det. allow reduced precision: FALSE
[component_container-2] [INFO] [1733414825.606590184] [zed.zed_node]:  * Object Det. maximum range [m]: 15
[component_container-2] [INFO] [1733414825.606972092] [zed.zed_node]:  * Object Det. min. confidence: 40
[component_container-2] [INFO] [1733414825.607220489] [zed.zed_node]:  * Object Det. prediction timeout [sec]: 0.5
[component_container-2] [INFO] [1733414825.607421044] [zed.zed_node]:  * Object Det. tracking: TRUE
[component_container-2] [INFO] [1733414825.607595389] [zed.zed_node]:  * Object Filtering mode: 1 - NMS3D
[component_container-2] [INFO] [1733414825.608377063] [zed.zed_node]:  * MultiClassBox people: TRUE
[component_container-2] [INFO] [1733414825.608567793] [zed.zed_node]:  * MultiClassBox vehicles: TRUE
[component_container-2] [INFO] [1733414825.608700216] [zed.zed_node]:  * MultiClassBox bags: TRUE
[component_container-2] [INFO] [1733414825.608824414] [zed.zed_node]:  * MultiClassBox animals: TRUE
[component_container-2] [INFO] [1733414825.608945701] [zed.zed_node]:  * MultiClassBox electronics: TRUE
[component_container-2] [INFO] [1733414825.609071948] [zed.zed_node]:  * MultiClassBox fruits and vegetables: TRUE
[component_container-2] [INFO] [1733414825.609196466] [zed.zed_node]:  * MultiClassBox sport-related objects: TRUE
[component_container-2] [INFO] [1733414825.609269398] [zed.zed_node]: *** Body Track. parameters ***
[component_container-2] [INFO] [1733414825.609421630] [zed.zed_node]:  * Body Track. enabled: FALSE
[component_container-2] [INFO] [1733414825.610081281] [zed.zed_node]:  * Body Track. model: HUMAN BODY FAST
[component_container-2] [INFO] [1733414825.610342927] [zed.zed_node]:  * Body Track. format: BODY 38
[component_container-2] [INFO] [1733414825.610705666] [zed.zed_node]:  * Body Track. allow reduced precision: FALSE
[component_container-2] [INFO] [1733414825.610902125] [zed.zed_node]:  * Body Track. maximum range [m]: 15
[component_container-2] [INFO] [1733414825.611563120] [zed.zed_node]:  * Body Track. KP selection: FULL
[component_container-2] [INFO] [1733414825.611804957] [zed.zed_node]:  * Body fitting: TRUE
[component_container-2] [INFO] [1733414825.612096524] [zed.zed_node]:  * Body joints tracking: TRUE
[component_container-2] [INFO] [1733414825.612435262] [zed.zed_node]:  * Body Track. prediction timeout [sec]: 0.5
[component_container-2] [INFO] [1733414825.612824403] [zed.zed_node]:  * Body Track. confidence thresh.: 50
[component_container-2] [INFO] [1733414825.613165061] [zed.zed_node]:  * Body Track. min. KP thresh.: 10
[component_container-2] [INFO] [1733414825.613265066] [zed.zed_node]: *** Streaming Server parameters ***
[component_container-2] [INFO] [1733414825.613511511] [zed.zed_node]:  * Streaming Server enabled: FALSE
[component_container-2] [INFO] [1733414825.613882763] [zed.zed_node]:  * Stream codec: H264
[component_container-2] [INFO] [1733414825.614180955] [zed.zed_node]:  * Stream port:30000
[component_container-2] [INFO] [1733414825.614480490] [zed.zed_node]:  * Stream bitrate: 12500
[component_container-2] [INFO] [1733414825.614785851] [zed.zed_node]:  * Stream GOP size: -1
[component_container-2] [INFO] [1733414825.614957156] [zed.zed_node]:  * Stream Chunk size: 16084
[component_container-2] [INFO] [1733414825.615235955] [zed.zed_node]:  * Adaptive bitrate: FALSE
[component_container-2] [INFO] [1733414825.615685066] [zed.zed_node]:  * Target frame rate:0
[component_container-2] [INFO] [1733414825.615768303] [zed.zed_node]: *** Advanced parameters ***
[component_container-2] [INFO] [1733414825.616024316] [zed.zed_node]:  * Thread sched. policy:
[component_container-2] [INFO] [1733414825.616458323] [zed.zed_node]: *** SERVICES ***
[component_container-2] [INFO] [1733414825.619690495] [zed.zed_node]:  * '/zed/zed_node/reset_odometry'
[component_container-2] [INFO] [1733414825.621548993] [zed.zed_node]:  * '/zed/zed_node/reset_pos_tracking'
[component_container-2] [INFO] [1733414825.626276220] [zed.zed_node]:  * '/zed/zed_node/set_pose'
[component_container-2] [INFO] [1733414825.628981579] [zed.zed_node]:  * '/zed/zed_node/enable_obj_det'
[component_container-2] [INFO] [1733414825.630900817] [zed.zed_node]:  * '/zed/zed_node/enable_body_trk'
[component_container-2] [INFO] [1733414825.632879354] [zed.zed_node]:  * '/zed/zed_node/enable_mapping'
[component_container-2] [INFO] [1733414825.634644376] [zed.zed_node]:  * '/zed/zed_node/enable_streaming'
[component_container-2] [INFO] [1733414825.637241505] [zed.zed_node]:  * '/zed/zed_node/start_svo_rec'
[component_container-2] [INFO] [1733414825.639028032] [zed.zed_node]:  * '/zed/zed_node/stop_svo_rec'
[component_container-2] [INFO] [1733414825.641396574] [zed.zed_node]:  * '/zed/zed_node/set_roi'
[component_container-2] [INFO] [1733414825.643201566] [zed.zed_node]:  * '/zed/zed_node/reset_roi'
[component_container-2] [INFO] [1733414825.643632532] [zed.zed_node]: ***** STARTING CAMERA *****
[component_container-2] [INFO] [1733414825.777592596] [zed.zed_node]: ZED SDK Version: 4.2.2 - Build 95990_fb77e75e
[component_container-2] [2024-12-05 16:07:05 UTC][ZED][INFO] Logging level INFO
[component_container-2] [INFO] [1733414825.791615228] [zed.zed_node]: *** CAMERA OPENING ***
[component_container-2] [2024-12-05 16:07:06 UTC][ZED][INFO] Logging level INFO
[component_container-2] [2024-12-05 16:07:07 UTC][ZED][INFO] Using USB input... Switched to default resolution HD720
[component_container-2] [2024-12-05 16:07:07 UTC][ZED][INFO] [Init]  Depth mode: ULTRA
[component_container-2] [2024-12-05 16:07:08 UTC][ZED][INFO] [Init]  Camera successfully opened.
[component_container-2] [2024-12-05 16:07:08 UTC][ZED][INFO] [Init]  Camera FW version: 1523
[component_container-2] [2024-12-05 16:07:08 UTC][ZED][INFO] [Init]  Video mode: HD720@15
[component_container-2] [2024-12-05 16:07:08 UTC][ZED][INFO] [Init]  Serial Number: S/N 36513009
[component_container-2] [2024-12-05 16:07:08 UTC][ZED][WARNING] [Init]  Self-calibration failed. Point the camera towards a more textured and brighter area. Avoid objects closer than 1 meter (Error code: 0x01)
[component_container-2] [INFO] [1733414829.010677840] [zed.zed_node]: ZED SDK running on GPU #0
[component_container-2] [INFO] [1733414829.010948222] [zed.zed_node]:  * Camera Model  -> ZED 2i
[component_container-2] [INFO] [1733414829.011062884] [zed.zed_node]:  * Serial Number -> 36513009
[component_container-2] [INFO] [1733414829.011427544] [zed.zed_node]:  * Focal Lenght -> 2.09102 mm
[component_container-2] [INFO] [1733414829.011550110] [zed.zed_node]:  * Input	 -> USB
[component_container-2] [INFO] [1733414829.011688741] [zed.zed_node]:  * Camera FW Version  -> 1523
[component_container-2] [INFO] [1733414829.011761225] [zed.zed_node]:  * Sensors FW Version -> 777
[component_container-2] [INFO] [1733414829.011881840] [zed.zed_node]:  * Camera grab frame size -> 1280x720
[component_container-2] [INFO] [1733414829.011991733] [zed.zed_node]:  * Publishing frame size  -> 1280x720
[component_container-2] [INFO] [1733414829.012233474] [zed.zed_node]: *** TF FRAMES ***
[component_container-2] [INFO] [1733414829.012305510] [zed.zed_node]:  * Map			-> map
[component_container-2] [INFO] [1733414829.012370634] [zed.zed_node]:  * Odometry		-> odom
[component_container-2] [INFO] [1733414829.012435693] [zed.zed_node]:  * Base			-> zed_camera_link
[component_container-2] [INFO] [1733414829.012501136] [zed.zed_node]:  * Camera			-> zed_camera_center
[component_container-2] [INFO] [1733414829.012565492] [zed.zed_node]:  * Left			-> zed_left_camera_frame
[component_container-2] [INFO] [1733414829.012629911] [zed.zed_node]:  * Left Optical		-> zed_left_camera_optical_frame
[component_container-2] [INFO] [1733414829.012695291] [zed.zed_node]:  * RGB			-> zed_left_camera_frame
[component_container-2] [INFO] [1733414829.012787840] [zed.zed_node]:  * RGB Optical		-> zed_left_camera_optical_frame
[component_container-2] [INFO] [1733414829.012856323] [zed.zed_node]:  * Right			-> zed_right_camera_frame
[component_container-2] [INFO] [1733414829.012920903] [zed.zed_node]:  * Right Optical		-> zed_right_camera_optical_frame
[component_container-2] [INFO] [1733414829.013034861] [zed.zed_node]:  * Depth			-> zed_left_camera_frame
[component_container-2] [INFO] [1733414829.013142482] [zed.zed_node]:  * Depth Optical		-> zed_left_camera_optical_frame
[component_container-2] [INFO] [1733414829.013212406] [zed.zed_node]:  * Point Cloud		-> zed_left_camera_optical_frame
[component_container-2] [INFO] [1733414829.013315452] [zed.zed_node]:  * Disparity		-> zed_left_camera_frame
[component_container-2] [INFO] [1733414829.013380767] [zed.zed_node]:  * Disparity Optical	-> zed_left_camera_optical_frame
[component_container-2] [INFO] [1733414829.013475204] [zed.zed_node]:  * Confidence		-> zed_left_camera_frame
[component_container-2] [INFO] [1733414829.013542472] [zed.zed_node]:  * Confidence Optical	-> zed_left_camera_optical_frame
[component_container-2] [INFO] [1733414829.013607019] [zed.zed_node]:  * IMU			-> zed_imu_link
[component_container-2] [INFO] [1733414829.013676303] [zed.zed_node]:  * Barometer		-> zed_camera_center
[component_container-2] [INFO] [1733414829.013742770] [zed.zed_node]:  * Magnetometer		-> zed_imu_link
[component_container-2] [INFO] [1733414829.013808278] [zed.zed_node]:  * Left Temperature	-> zed_left_camera_frame
[component_container-2] [INFO] [1733414829.013872313] [zed.zed_node]:  * Right Temperature	-> zed_right_camera_frame
[component_container-2] [INFO] [1733414829.014006944] [zed.zed_node]: *** PUBLISHED TOPICS ***
[component_container-2] [INFO] [1733414829.467506161] [zed.zed_node]: Advertised on topic: /zed/zed_node/rgb/image_rect_color
[component_container-2] [INFO] [1733414829.467741950] [zed.zed_node]: Advertised on topic: /zed/zed_node/rgb/camera_info
[component_container-2] [INFO] [1733414829.482124601] [zed.zed_node]: Advertised on topic: /zed/zed_node/rgb_gray/image_rect_gray
[component_container-2] [INFO] [1733414829.482315299] [zed.zed_node]: Advertised on topic: /zed/zed_node/rgb_gray/camera_info
[component_container-2] [INFO] [1733414829.495767052] [zed.zed_node]: Advertised on topic: /zed/zed_node/rgb_raw/image_raw_color
[component_container-2] [INFO] [1733414829.495965271] [zed.zed_node]: Advertised on topic: /zed/zed_node/rgb_raw/camera_info
[component_container-2] [INFO] [1733414829.511638358] [zed.zed_node]: Advertised on topic: /zed/zed_node/rgb_raw_gray/image_raw_gray
[component_container-2] [INFO] [1733414829.511835840] [zed.zed_node]: Advertised on topic: /zed/zed_node/rgb_raw_gray/camera_info
[component_container-2] [INFO] [1733414829.531952107] [zed.zed_node]: Advertised on topic: /zed/zed_node/left/image_rect_color
[component_container-2] [INFO] [1733414829.532155254] [zed.zed_node]: Advertised on topic: /zed/zed_node/left/camera_info
[component_container-2] [INFO] [1733414829.550110030] [zed.zed_node]: Advertised on topic: /zed/zed_node/left_gray/image_rect_gray
[component_container-2] [INFO] [1733414829.550319961] [zed.zed_node]: Advertised on topic: /zed/zed_node/left_gray/camera_info
[component_container-2] [INFO] [1733414829.569081724] [zed.zed_node]: Advertised on topic: /zed/zed_node/left_raw/image_raw_color
[component_container-2] [INFO] [1733414829.569282823] [zed.zed_node]: Advertised on topic: /zed/zed_node/left_raw/camera_info
[component_container-2] [INFO] [1733414829.587852736] [zed.zed_node]: Advertised on topic: /zed/zed_node/left_raw_gray/image_raw_gray
[component_container-2] [INFO] [1733414829.588074283] [zed.zed_node]: Advertised on topic: /zed/zed_node/left_raw_gray/camera_info
[component_container-2] [INFO] [1733414829.607608951] [zed.zed_node]: Advertised on topic: /zed/zed_node/right/image_rect_color
[component_container-2] [INFO] [1733414829.607881414] [zed.zed_node]: Advertised on topic: /zed/zed_node/right/camera_info
[component_container-2] [INFO] [1733414829.626536067] [zed.zed_node]: Advertised on topic: /zed/zed_node/right_gray/image_rect_gray
[component_container-2] [INFO] [1733414829.626734989] [zed.zed_node]: Advertised on topic: /zed/zed_node/right_gray/camera_info
[component_container-2] [INFO] [1733414829.645109532] [zed.zed_node]: Advertised on topic: /zed/zed_node/right_raw/image_raw_color
[component_container-2] [INFO] [1733414829.645320903] [zed.zed_node]: Advertised on topic: /zed/zed_node/right_raw/camera_info
[component_container-2] [INFO] [1733414829.664779663] [zed.zed_node]: Advertised on topic: /zed/zed_node/right_raw_gray/image_raw_gray
[component_container-2] [INFO] [1733414829.664988282] [zed.zed_node]: Advertised on topic: /zed/zed_node/right_raw_gray/camera_info
[component_container-2] [INFO] [1733414829.682111846] [zed.zed_node]: Advertised on topic: /zed/zed_node/depth/depth_registered
[component_container-2] [INFO] [1733414829.682313009] [zed.zed_node]: Advertised on topic: /zed/zed_node/depth/camera_info
[component_container-2] [INFO] [1733414829.687258487] [zed.zed_node]: Advertised on topic: /zed/zed_node/depth/depth_info
[component_container-2] [INFO] [1733414829.701147160] [zed.zed_node]: Advertised on topic: /zed/zed_node/stereo/image_rect_color
[component_container-2] [INFO] [1733414829.715993995] [zed.zed_node]: Advertised on topic: /zed/zed_node/stereo_raw/image_raw_color
[component_container-2] [INFO] [1733414829.718679961] [zed.zed_node]: Advertised on topic: /zed/zed_node/confidence/confidence_map
[component_container-2] [INFO] [1733414829.724795614] [zed.zed_node]: Advertised on topic: /zed/zed_node/disparity/disparity_image
[component_container-2] [INFO] [1733414829.729157733] [zed.zed_node]: Advertised on topic: /zed/zed_node/point_cloud/cloud_registered
[component_container-2] [INFO] [1733414829.733111063] [zed.zed_node]: Advertised on topic: /zed/zed_node/pose
[component_container-2] [INFO] [1733414829.735987055] [zed.zed_node]: Advertised on topic: /zed/zed_node/pose/status
[component_container-2] [INFO] [1733414829.739439526] [zed.zed_node]: Advertised on topic: /zed/zed_node/pose_with_covariance
[component_container-2] [INFO] [1733414829.743911891] [zed.zed_node]: Advertised on topic: /zed/zed_node/odom
[component_container-2] [INFO] [1733414829.748014285] [zed.zed_node]: Advertised on topic: /zed/zed_node/path_map
[component_container-2] [INFO] [1733414829.751840472] [zed.zed_node]: Advertised on topic: /zed/zed_node/path_odom
[component_container-2] [INFO] [1733414829.756601300] [zed.zed_node]: Advertised on topic: /zed/plane_marker
[component_container-2] [INFO] [1733414829.760196083] [zed.zed_node]: Advertised on topic: /zed/plane
[component_container-2] [INFO] [1733414829.763840148] [zed.zed_node]: Advertised on topic: /zed/zed_node/imu/data
[component_container-2] [INFO] [1733414829.766367258] [zed.zed_node]: Advertised on topic: /zed/zed_node/imu/data_raw
[component_container-2] [INFO] [1733414829.770057502] [zed.zed_node]: Advertised on topic: /zed/zed_node/temperature/imu
[component_container-2] [INFO] [1733414829.773978190] [zed.zed_node]: Advertised on topic: /zed/zed_node/imu/mag
[component_container-2] [INFO] [1733414829.778009540] [zed.zed_node]: Advertised on topic: /zed/zed_node/atm_press
[component_container-2] [INFO] [1733414829.781007523] [zed.zed_node]: Advertised on topic: /zed/zed_node/temperature/left
[component_container-2] [INFO] [1733414829.785315975] [zed.zed_node]: Advertised on topic: /zed/zed_node/temperature/right
[component_container-2] [INFO] [1733414829.789749938] [zed.zed_node]: Advertised on topic: /zed/zed_node/left_cam_imu_transform
[component_container-2] [INFO] [1733414829.790032321] [zed.zed_node]: Camera-IMU Translation:
[component_container-2]  -0.002 -0.023061 0.000217
[component_container-2] [INFO] [1733414829.790224267] [zed.zed_node]: Camera-IMU Rotation:
[component_container-2] FFFFD08A1670
[component_container-2] 0.999985 0.004895 -0.002594
[component_container-2] -0.004901 0.999986 -0.002006
[component_container-2] 0.002584 0.002019 0.999995
[component_container-2]
[component_container-2] [INFO] [1733414829.790310928] [zed.zed_node]: *** Subscribers ***
[component_container-2] terminate called after throwing an instance of 'rclcpp::exceptions::InvalidTopicNameError'
[component_container-2]   what():  Invalid topic name: topic name must not be empty string:
[component_container-2]   ''
[component_container-2]    ^
[component_container-2]
[ERROR] [component_container-2]: process has died [pid 102219, exit code -6, cmd '/opt/ros/foxy/lib/rclcpp_components/component_container --ros-args -r __node:=zed_container -r __ns:=/zed'].

ZED Camera model
ZED2i
Environment
OS: Ubuntu 20 - L4T 35.4.1 - Jetpack 5.1.2
ZED SDK Version: v4.2.2
GPU: Nvidian Jetson Xavier
ROS: ROS2 Foxy

Anything else?
No response

Hi @creix the problem is caused by a problem with ROS 2 Foxy when loading parameters from the YAML files. I recommend you read this GitHub thread and modify the YAML files to solve the problem.

Hello, I read the thread and saw also your reply on the thread. What of the two approaches explained would you suggest to apply, the one with remapping or having plain YAML files? Will there be anything else that i have to modify in order to have everything functioning?

Other users successfully solved the problem with "plain" YAML files.

I tried right now to remove all the nestings from the YAML files and rebuilding the package but i'm still having the same error. Do you have any other suggestion?

I tried right now to remove all the nestings from the YAML files and rebuilding the package but i'm still having the same error. Do you have any other suggestion?我现在试图从YAML文件中删除所有嵌套并重建包，但我仍然有同样的错误。你还有其他建议吗？
Have you solved this problem? I also encountered this problem.

[component_container-2] [INFO] [1733895069.607470620] [zed.zed_node]: Camera-IMU Translation:
[component_container-2]  -0.002 -0.023061 0.000217
[component_container-2] [INFO] [1733895069.607649215] [zed.zed_node]: Camera-IMU Rotation:
[component_container-2] 7FFF506D40F0
[component_container-2] 0.999985 0.005382 -0.000591
[component_container-2] -0.005386 0.999967 -0.006086
[component_container-2] 0.000558 0.006089 0.999981
[component_container-2]
[component_container-2] [INFO] [1733895069.607899644] [zed.zed_node]: *** Subscribers ***
[component_container-2] terminate called after throwing an instance of 'rclcpp::exceptions::InvalidTopicNameError'
[component_container-2]   what():  Invalid topic name: topic name must not be empty string:
[component_container-2]   ''
[component_container-2]    ^
[component_container-2]
[ERROR] [component_container-2]: process has died [pid 140342, exit code -6, cmd '/opt/ros/foxy/lib/rclcpp_components/component_container --ros-args -r __node:=zed_container -r __ns:=/zed'].

Hello @kamdkslansgka , currently i was not able to solve this specific error. The workaround i've adopted is to use the docker container running Ubuntu 22 and ROS2 Humble.

@kamdkslansgka I had simular issue on humble. I solved it by updating the YAML files to the ones provided by example repo. Some missing parameter can cause the tobic name to become empty.

Hello @kamdkslansgka , currently i was not able to solve this specific error. The workaround i've adopted is to use the docker container running Ubuntu 22 and ROS2 Humble.

OK, thank you for your reply

@kamdkslansgka I had simular issue on humble. I solved it by updating the YAML files to the ones provided in the repo. Some missing parameter can make the topic name empty.

Thanks for your suggestion, I'll try it out.

I also encountered the same problem


NotSnakeCaseMemberVar complains about core cat_ID

cat_ID is still returned with that name in core's category objects (as opposed to term_id).
I've tried adding it to $whitelisted_mixed_case_member_var_names, but for some reason it didn't take so might be issue in implementation.
135 | ERROR | Variable "cat_ID" is not in valid snake_case format
     |       | (WordPress.NamingConventions.ValidVariableName.NotSnakeCaseMemberVar)

@Rarst I think this is by design. The sniff is designed to whitelist object properties that have mixed cases, but variables themselves are supposed to have the proper case. I suppose the only place where you'd be forced to use mixed case for a variable name is if you use compact() to construct an array to pass into a core function.
Take a look at #551. This includes the missing cat_ID for the whitelisted names, but it also allows all these whitelisted names to be used as variable names in addition to object properties. Is this something we want to do? Maybe we should introduce a variant error code for NotSnakeCase like NotSnakeCaseCore which could be used if a variable is snake case but it is among the whitelisted terms.

Hm, to be clear it was a property name like $category->cat_ID, so the sniff's message isn't entirely precise. Maybe that's the reason for the quirk, it confuses variable/property distinction somehow?

@Rarst you're right. The error message was not great. I've fixed this in d8d7942da1516c78e76eddee43ad44c0b48210a5. I've also amended the PR to make it clear that using $cat_ID is bad, but $category->cat_ID is ok. Please review #551.


fix: treat blank env credentials as missing

Motivation and Context
Blank environment variable credentials should be disregarded.
AWS_ACCESS_KEY_ID="" AWS_SECRET_ACCESS_KEY=""
Some existing automation I work with deliberately sets these to blank so that alternative credentials providers are used.
Using the aws-sdk-rust, these blank env vars were picked up and auth fails rather than using profile credentials.
Description
aws-sdk-js-v3 has this behaviour:
https://github.com/aws/aws-sdk-js-v3/blob/1aae04fcd420f9532f63b009090f97754cd0d631/packages/credential-provider-env/src/fromEnv.ts#L20
aws-sdk-java-v2 has this behaviour:
https://github.com/aws/aws-sdk-java-v2/blob/c8c1fd4a138d8602cd2905b0f59d2a3913efb5df/core/auth/src/main/java/software/amazon/awssdk/auth/credentials/internal/SystemSettingsCredentialsProvider.java#L52
Testing
Automated tests added together with the change. These fail if the change does not exist.
Checklist

[x] I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

this looks great! It may also be worth adding a JSON based test for this so that other SDKs can be sure to match the same behavior. (aws-config/test-data/default-provider-config)

@rcoh I've added one but couldn't get the tests to run correctly locally.

Rebased on latest git@github.com:awslabs/smithy-rs.git main.

Hey @elrob, it looks like the formatter is unhappy. Could you run rustfmt on your changes and commit/push?

this looks great! It may also be worth adding a JSON based test for this so that other SDKs can be sure to match the same behavior. (aws-config/test-data/default-provider-config)

@rcoh I've added one but couldn't get the tests to run correctly locally.

you need to add it here: https://github.com/awslabs/smithy-rs/blob/4ff8dc6d8b95cc816043a9f178c603f9a6434173/aws/rust-runtime/aws-config/src/default_provider/credentials.rs#L314

The issue causing the tests not to work locally may be that aws-config depends on the generated SDK. You would need to run ./gradlew :aws:sdk:assemble from the repo root. The test runs fine locally for me though, so no worries.

For rustfmt, you may find it helpful to install pre-commit which will lint everything.

I've appeased rustfmt, rebased on awslabs/main and updated this branch.

Thank you!

likewise! This will be available in an hour or so on the "next" branch of aws-sdk-rust if you would like to use it before we cut a release


Usage Example/Getting Started Documentation

What?
Readme needs a usage example for people interested in getting started with the package
Why?
Would love to test drive this package but it's lacking clear explanation of how to get started. Would be great if this could be added to the README or the website.

Note: The api documentation is great but not the best reference for getting started.

This would also be solved if you had code for an example project.

There is incoming documentation. It will be published once the first release in out.

And how src directory co- works  with node.js? Can't see any node.h If require('./mediasoup-server') then must be mediasoup-server.node file.

You should not care about the src directory at all. You just install mediasoup and use it via Node by following its API.
Also, check this: http://mediasoup.org/faq/#is-mediasoup-a-native-addon

@ibc  many thanx. Please tell me what kind of a file extension have the mediasoup-worker* ? so, exe, node? First time in linux world.. but the command file outputs 'lsb executables'

When you start a server with debug you can see worker's PID number in console. PID is Process ID. You can find this PID in the process list and get all the info you want.

Hi, I do agree that example is more than needed to get people involved here

Regarding the new WebRTC 1.0 API, there is already doc and usage example:
http://mediasoup.org/api/#webrtc


Support class stores

I cannot store class instances in my react-easy-state store.
import { store, view } from `react-easy-state`;
import { Post } from `./spraypaint-models.ts` // models for the API query library: https://www.graphiti.dev/js/introduction

const store = store({});

store.post = (await Post.where({ slug: 'home' }).first()).data // fetch a post and store it as an instance of the Post typescript class.

view(function UpdatePost() {
  ...
  handleSubmit(values) {
    Post.content = values.content
    Post.save() // error because method is not available, because classes aren't proxied
  }
})

Graphiti + Spraypaint is great. I want to be able to use it with react-easy-state, but you must be able to store instances of classes in the store first.
I would like an update that enables the store to proxy class instances.
The alternative solution using react-easy-state that fits best is to have two stores. One store is wrapped in store() and one store is not. If I need to access some specific instance of Post and use it's class methods, then I can use the unwrapped store.
Other state management libraries that would work are Redux and redux-bundler or basically any other state management library. However the only thing that I want from my state management library is reactivity and nothing else, which your very nice library provides.
However I think I'll be using react-simplified for now. It appears to handle storing class instance in the store (haven't tested it as of yet).

Closing this because I may have spoken too soon. That I cannot access class methods might be a problem on my end, not yours.


Enabling the mod causes a hard reboot

If I enable this mod, it reboots my machine as soon as the first splash screen appears.
Just bought it from Steam.

I played the game a little without the mod and then reinstalled the 1.0.3 release and this time it worked.
Thanks for this, the game is much more enjoyable now.

This is still an issue. I just applied the latest Nvidia hotfix and when I tried to start the game it hard rebooted my machine.
Maybe it has to do with the game recreating the shaders when a new version of the driver is installed.


Help Wanted: Jira plugin: Troubleshooting "/jira install" error in local developer environment

Mattermost user jason.blais from https://community-release.mattermost.com has requested the following be documented:
Problem:  After enabling Jira plugin for Mattermost and running /jira install with site URL set to LOCALHOST, an error about an invalid site URL is received.
Solution:

Setup an Ngrok connection to your local developer environment. This exposes your local web server to Jira.
Setup your Mattermost SITEURL in the system console to the ngrok connection URL you are assigned.
Then try run /jira install

Note: This may also use an accompanying update to the error message to clarify the error to the admin running /jira install
See the original post here.
This issue was generated from Mattermost using the Doc Up plugin.

CMIIW, but it seems that the change needs to be done in a different repo.
It's because the relevant page on docs.mattermost.com says that it's moving to gitbook, which uses the other repo as the content source.

@aaronrothschild - Is this still an active issue that users would encounter?

@cwarnermm It's a fairly edge case, but can certainly be a complexity an admin testingout MM and Jira could encounter if they have them both on their local machines.  We should simply say somewhere: "You cannot use LOCALHOST to connect the Jira plugin to your server, you can use a proxy if needed"


enableReplicatedSubscriptions is not used.

It seems that "Replicated Subscriptions" is always enabled because enableReplicatedSubscriptions is not used.

https://github.com/apache/pulsar/search?q=enableReplicatedSubscriptions&unscoped_q=enableReplicatedSubscriptions
https://github.com/apache/pulsar/blob/22b8923a251c3356401090dacb8ff97fd37d14c1/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java#L688

Is the behavior decided when Replicated Subscriptions is OFF ?
I think the behavior is as the following in the case:

Brokers send NotAllowedException to consumers that subscribe with replicated subccription.
Replicators don't send marker messages and deal with them.

I will try to implement the above behavior by the following ways.
Please let me know if there are any problems.
Brokers send NotAllowedException to consumers that subscribe with replicated subccription.
Like Key_Shared, send NotAllowedException in PersistentTopics#subscribe:
https://github.com/apache/pulsar/blob/v2.6.1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L533-L539
Replicators don't send marker messages and deal with them.
Broker do not create ReplicatedSubscriptionsController instance that sends marker messages.
Fix to enter the following if statement:
https://github.com/apache/pulsar/blob/v2.6.1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L2158-L2162

It is fixed by #8144


ESLint: Invalid Options: - Unknown options: experimentalDecorators

I've just setup a new typescript project with Next.js, but somehow i always get this error message when opening a .tsx fille:

I already tried the solutions from this issue: https://github.com/microsoft/vscode/issues/28097 but it's still showing.
my tsconfig.json:
{
  "compileOnSave": false,
  "compilerOptions": {
    "rootDir": ".",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "importHelpers": true,
    "target": "es2015",
    "module": "esnext",
    "lib": ["es2017", "dom"],
    "skipLibCheck": true,
    "skipDefaultLibCheck": true,
    "baseUrl": ".",
    "paths": {}
  },
  "exclude": ["node_modules", "tmp"]
}

my .eslintrc.json:
{
  "extends": ["airbnb", "airbnb-typescript", "plugin:prettier/recommended", "plugin:@typescript-eslint/recommended"],
  "ignorePatterns": "**/*.js",
  "parserOptions": {
    "project": "./tsconfig.json"
  },
  "rules": {
    "react/react-in-jsx-scope": "off"
  }
}

and i also set this in my settings.json:
{
  "js/ts.implicitProjectConfig.experimentalDecorators": true
}

how can i disable this error or fix it?

@Elanum  does the validation happen correctly when you use eslint in the terminal. If this is the case can you please provide me with a GitHub repository I can clone that demos what you are experiencing.

@Elanum does the validation happen correctly when you use eslint in the terminal. If this is the case can you please provide me with a GitHub repository I can clone that demos what you are experiencing.

When i run yarn lint or npx eslint . then everything works.
Here is the branch that i created: https://github.com/Elanum/Elanum/tree/feature/nx-setup

Works for me using the repository you provided. Any additional information you can share?

Is there anything special in the ESLint Output channel?

@dbaeumer here is my output console:

Hi, I've been facing the same issue and fixed it myself because it was an user env problem.
I previously added this option "experimentalDecorators" in one of my VSCode's settings JSON file, issue was coming from there.
So be sure to check all of them : user, workspace and folder.
Search for this option in the JSON files and try to deleting it. :)

Hi, I've been facing the same issue and fixed it myself because it was an user env problem.
I previously added this option "experimentalDecorators" in one of my VSCode's settings JSON file, issue was coming from there. So be sure to check all of them : user, workspace and folder.
Search for this option in the JSON files and try to delete it. :)

Oh my god, this fixed it. Thank you so much @MrR4P70R !


Fix typo in 'banana'

Thanks for the fix. Please sign off your commit, see contributing.md for details.

Merged


Eager_load won't trigger with includes() for inherited classes

Consering :
class Thing
  include Mongoid::Document

  has_many :tasks
end

class Kase < Thing
end
class Deal < Thing
end

class Task
  include Mongoid::Document

  belongs_to :thing
end

My Thing class is never instantiated. Only Deal & Kase.
Doing :
@tasks = Task.includes(:thing)
@tasks.each do |task|
  puts task.thing.name #for example
end

won't trigger the eager load :
MONGODB max_simple_crm_development['tasks'].find({"tenant_id"=>BSON::ObjectId('4e7618e6f581f90c73000001'), :done_at=>nil}, {"thing_id"=>1})
MONGODB max_simple_crm_development['things'].find({"_id"=>{"$in"=>[BSON::ObjectId('4e6a6ca8f581f95883000003'), BSON::ObjectId('4e9bdd56f581f90a5d000004'), BSON::ObjectId('4dc80859f581f90944000014')]}})

MONGODB max_simple_crm_development['tasks'].find({"tenant_id"=>BSON::ObjectId('4e7618e6f581f90c73000001'), :done_at=>nil}).limit(50).sort([[:due_at, :asc]])

MONGODB max_simple_crm_development['things'].find({:_id=>BSON::ObjectId('4e6a6ca8f581f95883000003')}).limit(-1).sort([[:_id, :asc]])

The document with id=4e6a6ca8f581f95883000003 is loaded via the includes special criteria (1st & 2nd line of the log).
But, it is still fetched from DB as the last line of the log shows.
And as its class is Kase, it is stored in the Kase "identity_map repository" (documents_for(:kase)).
https://github.com/mongoid/mongoid/blob/master/lib/mongoid/relations/referenced/in.rb#L129
But on the criteria emerging from the relation to fetch the Kase (that is referenced as a Thing in the metadata),
the "from_map_or_db" fucntion looks in the "Thing identity_map repository" (documents_for(:thing)).
At less, that is what i understood.

I have submitted a pull request for this issue here:
https://github.com/mongoid/mongoid/pull/1381

Well, I tought the fix would be more complicated.
Thanks for stopping by ;-)
I'll try it this afternoon and i let you know.

Closing in favor of #1381.


Split the LICENSE and NOTICE as source-release version and binary-release version

@JulianFeinauer  I think once our mentor confirm the correctness of the files, we need to cherry-pick the changes to release/0.8.0 and the master branch.

+1

I would merge this now if there are no concerns left?

+1

has been cherry-picked to master by #309


\mmlToken doesn't allow attributes whose defaults are false or blank

For example
\mmlToken{mglyph}[src="abc.png"]{}

should allow setting the src attribute but it generates an error instead.

==> In Testsuite
LaTeXToMathML/non-standard/issue913.html


Bad subtitle rendering

Have you read the FAQ and checked for duplicate open issues? yes
What version of Shaka Player are you using? 2.5.7
Can you reproduce the issue with our latest release version? Yes
Can you reproduce the issue with the latest code from master? Yes
Are you using the demo app or your own custom app? Both
If custom app, can you reproduce the issue using our demo app? Yes
What browser and OS are you using?
Chrome 79 macOS
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?

I can send the stream if necessary, but I have attached the ttml file that fails.
What did you do?

Load a stream
What did you expect to happen?
Subtitles are rendering correctly
What actually happened?

Bad subtitle rendering in 2.5.7

Rendering in 2.5.6

Rendering in Dash.js 3.0.0

TTML file
<?xml version="1.0" encoding="UTF-8"?>
<tt ttp:cellResolution="50 30" ttp:timeBase="media" xml:lang="en" xmlns="http://www.w3.org/ns/ttml" xmlns:ebutts="urn:ebu:tt:style" xmlns:ttp="http://www.w3.org/ns/ttml#parameter" xmlns:tts="http://www.w3.org/ns/ttml#styling" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">

    <styling>


Incorrect routing when UpstreamHost is specified and UpstreamHttpMethod is empty

Fixes #419

@davidni this looks good, pulled the code so I could understand it better. These tests are not very easy to understand which is my fault! I have made a note to look at them and see if I can separate the functionality out so they dont need so much setup one day!


refactor: simplify EmulationManager

EmualationManager used to be injecting touch hooks to properly
support touch emulation.
However, these are no longer necessary, since https://crbug.com/133915
is long fixed.

Can we add a test for emulating a touchscreen (not mobile) without refreshing and make sure it still appears that touch is enabled on the page. I’m skeptical.

Nice catch!

Nah, no functional change - you didn't let me to do one.


Junk pr

Alright, lets try this again, with even more junk and a proper golangci file

well, this is highly embarrassing. My apologies. This works for me when I do it on my project :( For example, see here: https://github.com/nutanix/terraform-provider-nutanix/pull/145
I'll open up an issue with the golangci team real quick.

I've filed an issue on the central tracker for golangCI here to see if we can figure out why this isn't flagging (anything) in this pile of garbage PR - https://github.com/golangci/golangci/issues/9

as you can see golangci is now required

fantastic, thanks! Let's use this to drive to conclusion with upstream to figure out why its not doing what it should be doing

They've got an issue with their service for this repo, they are fixing it per: https://github.com/golangci/golangci/issues/9#issuecomment-397671873

As you guys can see, they fixed up the issue that I wrote about in the ticket on their system, and this is how they work for other PRs
happy hunting!


No siop-oid4vp classes in the new npm package version 0.15.0

Since the did-auth-siop repo has been moved into the OID4VC, I expected classes like OP, OPBuilder, RP, ... to be included in the @sphereon/oid4vci-client npm package. I have not been able to find any of those in version 0.15.0. Is this intended?

No not yet. The packages have stayed the same for this version (0.15.0). So you still need to keep the current imports from the old location. Soon we will start the actual refactoring of this package, where we will extract into new modules and have more common classes.
This was a first step, where there has been some initial refactor work on the SIOP/VP part only, to not make it depend on DIDs. The next round will be a larger refactor

Thank you for the clarification


Is there any option for HLS re-streaming on Nginx-rtmp module like rtmp edge server ?

Anybody guide me to set up of HLS re-streaming on Nginx-rtmp server.  (like rtmp edge stream)

add_header "X-Hls-Cache-Status" "Cached TS";

This does not work for me, it always MISS on cache status.


Why the KO percentage is not correct

I use gatling Java DSL to do some simulation. it works well but I found that some of my API KO percentage is not correct in the report.  some other API KO percentage is correct, could you please give me some hints ? The KO number is not zero but the KO percentage is 0%
The global report as follow

one of the detail report as follow (The KO number is 21)

Hi @fingerdancer

The KO number is not zero but the KO percentage is 0%

How do you expect that gatling compute the percentage?
By definition, the percentage is count / total * 100 %.
For instance, for your "Payment Page(OPF)" line:

total is 5000
count (of KO) is 24

The computation is:

count / total * 100 %
24 / 5000 * 100 %
0.0042 * 100 %
0.42 %

As usual with percentage, gatling rounds them to the nearest integer.
As the value is less than 0.5 the nearest is... 0
What is effectively displayed in the reports.
So, what is the error exactly?
For any question, I suggest to ask them on our community forum, as the GitHub tracker is only for Bugs and validated Feature Requests.
Cheers!

@Isammoc  got it. thanks for you reply, that is to say, if value less than 0.5%, it will be 0%. is it gatling default behavior ? can I let it to show 0.42% througn some configuration ?

Re-opening. I'm investigating displaying doubles with 2 digits.

I need wait for the future new version which have fixed this issue, right ?

Yes. The next release will be 3.11.0.


React native 0.72-rc6 android relase error What went wrong: A problem was found with the configuration of task ':app:lintVitalAnalyzeRelease' (type 'AndroidLintAnalysisTask').

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.

Here is the diff that solved my problem:
diff --git a/node_modules/react-native-vector-icons/fonts.gradle b/node_modules/react-native-vector-icons/fonts.gradle
index 5485fac..bff75a2 100644
--- a/node_modules/react-native-vector-icons/fonts.gradle
+++ b/node_modules/react-native-vector-icons/fonts.gradle
@@ -25,7 +25,11 @@ afterEvaluate {
     }

     android.applicationVariants.all { def variant ->
-        def targetName = variant.name.capitalize()
+       def targetName = variant.name.capitalize()
+        def lintVitalAnalyzeTask = tasks.findByName("lintVitalAnalyze${targetName}")
+            if (lintVitalAnalyzeTask) {
+                lintVitalAnalyzeTask.dependsOn(fontCopyTask)
+            }
         def generateAssetsTask = tasks.findByName("generate${targetName}Assets")
         generateAssetsTask.dependsOn(fontCopyTask)
     }

This issue body was partially generated by patch-package.

@qnit82
@tri-bao
To fix this ,follow these step

remove apply from: file("../../node_modules/react-native-vector-icons/fonts.gradle") from android/app/build.gradlew
go to node_modules/react-native-vector-icon/Fonts and copy all the fonts
go to android/app/src/main and create a folder named assets if not exist then inside then assets create one more folder named fonts and paste all the fonts from   node_modules/react-native-vector-icon/Fonts to here
now you can use the vector icon as usual and also you can create a build which won't failed

We’ve just released a major new version with significant changes and improvements. If you’re still experiencing this issue after upgrading, please open a new issue with updated details. We're closing all the very old issues to get on top of things. Thanks for your patience!


add metrics support

How to categorize this PR?

/area monitoring
/kind enhancement
/priority normal
What this PR does / why we need it:
Expose default metrics collected by the controller-runtime for  landscaper-controller to gain more insights and enable basic monitoring.
Additionally metrics for the oci cache(s) are registered and collected.
The landscaper config & helm chart have been extended to make the metrics port configurable.
Which issue(s) this PR fixes:
partially fixes #48
Special notes for your reviewer:
Release note:

Expose controller-runtime metrics for landscaper-controller and add oci cache metrics.

wait until we have discussed the pattern
/hold


Let branch/tag name be a valid ref to get CI status

fix #16384

Codecov Report

Merging #16400 (7922b97) into main (4ce32c9) will increase coverage by 0.02%.
The diff coverage is 65.71%.

@@            Coverage Diff             @@
##             main   #16400      +/-   ##
==========================================
+ Coverage   45.43%   45.46%   +0.02%
==========================================
  Files         710      711       +1
  Lines       83952    83956       +4
==========================================
+ Hits        38142    38167      +25
+ Misses      39661    39644      -17
+ Partials     6149     6145       -4

Impacted Files
Coverage Δ

routers/api/v1/repo/status.go
57.89% <50.00%> (+7.89%)
:arrow_up:

routers/api/v1/utils/git.go
66.66% <66.66%> (ø)

routers/api/v1/repo/git_ref.go
76.92% <100.00%> (-0.22%)
:arrow_down:

services/mailer/mail_comment.go
77.77% <0.00%> (-7.41%)
:arrow_down:

modules/process/manager.go
72.83% <0.00%> (-2.47%)
:arrow_down:

modules/log/event.go
59.90% <0.00%> (-1.89%)
:arrow_down:

models/repo_list.go
77.04% <0.00%> (-0.78%)
:arrow_down:

modules/queue/workerpool.go
53.05% <0.00%> (-0.77%)
:arrow_down:

models/error.go
39.68% <0.00%> (+0.46%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce32c9...7922b97. Read the comment docs.


Specify the image file for image build/push.

The default is prow/.prow-images.yaml, which made sense when Prow was in k8s/test-infra since it was nested in a subdirectory, but doesn't make sense anymore now that the files are unnested in their own repo. We could update the default instead, but I think having the argument here explicitly is clearer in this crops up again in future.
I believe this should fix the image push job for Prow images (post-k8s-infra-prow-images), which doesn't have any published images in k8s-staging-test-infra yet.
Ref https://github.com/kubernetes/test-infra/issues/32432

/lgtm

/approve

Update: I am actually just bad at finding images, and confused the default in k8s/test-infra with the default in this repo's version of hack/prowimagebuilder (which correctly points to the same file).
In any case, this job has been working and is still working after the change (which should be a no-op). Sorry for the confusion!


Fixes #757

(also note: this inspired the creation of #857)

Hello @apdavison! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file neo/core/imagesequence.py:

Line 174:17: E122 continuation line missing indentation or outdented
Line 175:17: E122 continuation line missing indentation or outdented

This looks good can I merge ?


Files

Hello
Why bot can't handle many files that are sent from users? it shows message on startup but will not work anymore and messages will not received by my bot. Actually it stuck in endless loop.

Please, rather than closing and reopening the issue to catch my attention (which sometimes works :laughing: ), could you write the stack race? Thanks

Sry :laughing:, if i send lots of files to the bot, i will repeat message on last message received and wont work anymore (actually no errors show up, just wont receive any message anymore).
and the output is like this:
{ message_id: 982,
  from: { id: 82433927, first_name: 'Vahid', username: 'vhdmsm' },
  chat: { id: 82433927, first_name: 'Vahid', username: 'vhdmsm' },
  date:<PHONE_NUMBER>,
  document:
   { file_name: '2.1-Electronic Retailing.ppt',
     mime_type: 'application/vnd.ms-powerpoint',
     file_id: 'BQADBAADCwADh9fpBJukTAewkIlsAg',
     file_size: 557568 } }
{ message_id: 982,
  from: { id: 82433927, first_name: 'Vahid', username: 'vhdmsm' },
  chat: { id: 82433927, first_name: 'Vahid', username: 'vhdmsm' },
  date:<PHONE_NUMBER>,
  document:
   { file_name: '2.1-Electronic Retailing.ppt',
     mime_type: 'application/vnd.ms-powerpoint',
     file_id: 'BQADBAADCwADh9fpBJukTAewkIlsAg',
     file_size: 557568 } }
{ message_id: 982,
  from: { id: 82433927, first_name: 'Vahid', username: 'vhdmsm' },
  chat: { id: 82433927, first_name: 'Vahid', username: 'vhdmsm' },
  date:<PHONE_NUMBER>,
  document:
   { file_name: '2.1-Electronic Retailing.ppt',
     mime_type: 'application/vnd.ms-powerpoint',
     file_id: 'BQADBAADCwADh9fpBJukTAewkIlsAg',
     file_size: 557568 } }
....

Can you run your code with DEBUG='*'? To see the debug messages


Storing nested object properties in separate columns

Support hierarchical property expressions like Property.SubProperty in PropertyName of AdditionalColumns to allow sub-properties of log event properties be logged into separate columns easily following the structured logging paradigm.
This feature was requested in #207, #435, #419 and #292.

Thanks a lot for taking the time to review @jonorossi. Greetings to down under!


Is there any difference between BufferSize and BufferSizeMB arguments?

The User Guide mentions both. They are the same thing?

They are the same thing.    /BufferSize was the old form, and later PerfView adopted the convention of including units on most things to be clear.    We left the old form to avoid unnecessarily breaking scripts.


HDDS-8960. Hold the rootCA's private key only in memory for the time of initialization/rotation, then forget it

What changes were proposed in this pull request?
Saving the root ca certificate public/private key can be avoided by only storing it in memory.
This also involves changing the certificate structure for the system as the only certificate signed by the root ca certificate is the first scm's sub-ca and later we use that certificate to sign other scm's sub-cas. This results in the full trust chain becoming 1 certificate longer.
Lot of code was removed around building a CA list, which no longer needs to be an actual list. This method's goal was providing the basis for the trust chain, but as we are using certificate paths now only the root ca certificate is needed to for verifying a full chain.
HDDS-8960
Testing was done using CI as well as observing the root ca keys missing. Here is a green CI run:
https://github.com/Galsza/ozone/actions/runs/6221002097

Hi @Galsza , can you extract the buildCAX509List part into a new patch? I think it's not related with the goal of this one.
Also, I'm kind of understand the new logic of DefaultCAServer why rootCaKeyPair is needed. But it's not that straight forward. I'm think if we can do some refactor of this DefaultCAServer. Currently it's mixed with root CA function with sub CA function. Is it possible that we separate it into two class, one for root CA and another for sub CA in this patch, so that it will be natural that root CA doesn't persist key materials, while sub CA do?

Hi @ChenSammi , some changes to the buildCAList are necessary, but I can extract it later. I have reverted back the changes to a basic version now.
Regarding the root CA key generation I'm not sure how this separation can be done better. I've inlined the generateKeys function to make it clearer that it's not invoked from any other place. The SUB-CA certificate keys are generated and stored in an entirely different manner, during signing and storing the certificates. Do you have any advice on how to improve this?

Hi @ChenSammi , some changes to the buildCAList are necessary, but I can extract it later. I have reverted back the changes to a basic version now.

I know it's necessary. I just say we can submit these part of changes with a new JIRA of a proper title.

Converted to draft because compatibility issues require further examination.

/pending


Package request: catppuccin-sddm

Project description

🔒 Soothing pastel theme for SDDM
Metadata

homepage URL: www.github.com/catppuccin/sddm
license: mit
platforms: linux

Add a :+1: reaction to issues you find important.

This was merged into nixpkgs yesterday. Nvm


[TechDocs] Increase timeout for anchors to work on Chromium browsers

Signed-off-by: Laura Ceconi<EMAIL_ADDRESS>Hey, I just made a Pull Request!

This PR fixes https://github.com/backstage/backstage/issues/11003
Increasing the timeout for scrollIntoView to be triggered was enough to fix the behaviour in Chromium browsers.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hey @lceconi, thank you for this PR! Out of curiosity, how did you arrive at 500 as the new value?

@agentbellnorm thanks for your feedback and sorry for the delay!
What I'm experiencing is that some documentation content is taking longer to load than others. If you have a slow internet connection the anchors won't work at all (setting the network speed to Fast 3G in Chrome Dev Tools is showing this).
So with the 500 I'm just increasing a bit the time needed to wait for the content to load. Any value above 500 seemed to be sufficient in my tests. This is probably not the best solution for the problem, but then I would have to go deeper the code and do some refactor 😅
Let me know if this makes sense to you.

Hey @lceconi, sorry for the long delay.
The reason i'm a little reluctant to this approach is that it will make the user experience worse, since there will be a longer delay and then a scroll.
One suggestion is that we use some kind of retry mechanism, with a delay and a maximum number of attempts. Something like this:
const retry = (action: () => boolean, attempts: number, interval: number) => {
  if (attempts >= 0 && !action()) {
    window.setTimeout(() => retry(action, attempts - 1, interval), interval);
  }
};

That way we wouldn't wait longer than necessary. Do you think this would be a good idea? Can you test it if you agree?


dist/common/cassandra.in.sh: add cassandra_storagedir

On our package, we specify empty parameter on "-Dcassandra.storagedir"  for
Java based programs, it because dist/common/cassandra.in.sh does not
initialized it.
Seems like tools/bin/cassandra.in.sh does initialize it, we can do same in
dist/common/cassandra.in.sh too.
(dist/common/cassandra.in.sh is for package, tools/bin/cassandra.in.sh is for
built from source code)

cc: @glommer

@syuu1228 What issue does this fix?


chore: rename prisma-fmt-wasm to prisma-schema-wasm

Part of https://github.com/prisma/prisma-engines/pull/4033

Note: ignore the "The system cannot find the path specified." for Windows run, it looks like it started with https://github.com/prisma/prisma/pull/19427 and I'm checking what is the problem there.


LanceDb not working?

Trying to follow the docs (as a nodejs noob), and can't get it to work using LanceDb:
[`Waiting for the debugger to disconnect...
node:internal/modules/esm/resolve:265
throw new ERR_MODULE_NOT_FOUND(
^
Error [ERR_MODULE_NOT_FOUND]: Cannot find module 'C:\Users\sivebjor\OneDrive - Viaplay Group\Desktop\p4chat-nodejs\node_modules@llm-tools\embedjs\vectorDb\lance' imported from C:\Users\sivebjor\OneDrive - Viaplay Group\Desktop\p4chat-nodejs\app.js
at finalizeResolution (node:internal/modules/esm/resolve:265:11)
at moduleResolve (node:internal/modules/esm/resolve:933:10)
at defaultResolve (node:internal/modules/esm/resolve:1169:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:227:38)
at ModuleWrap. (node:internal/modules/esm/module_job:87:39)
at link (node:internal/modules/esm/module_job:86:36) {
code: 'ERR_MODULE_NOT_FOUND',
url: 'file:///C:/Users/sivebjor/OneDrive%20-%20Viaplay%20Group/Desktop/p4chat-nodejs/node_modules/@llm-tools/embedjs/vectorDb/lance'
}`]
Any ideas? It's missing the vectorDb-folder inside node_modules.

The library had a refactor recently and the docs were not yet updated. Could you look at the updated documentation here - https://llm-tools.mintlify.app/components/vector-databases/lancedb and see if that addresses the issue for you?

I ended up using a different solution, but that seems like the fix. Will test it in the future. Thanks!


White pixel visible when choosing to hide code for account starting with 'T'.

Title is pretty self explanatory. I know it's not that important, but it does trigger me to unknown horizons hehe.
You can see it at the top left here>

Not sure what other capital letters could trigger the same effect, might be worth checking that out.

Thanks I cant unsee it.

fixed with latest gh and store fix coming soon


What are these temporary IDs? And where can I find the compact ID's

hasTemporaryId ilxtr-NeuronHuang2017-0-ilxtr-hasExpressionPhenotype-NCBIGene-12308-0-ilxtr-hasExpressionPhenotype-NCBIGene-20604-0-ilxtr-hasInstanceInTaxon-NCBITaxon-10090-0-ilxtr-hasNeurotransmitterPhenotype-CHEBI-16865-0-ilxtr-hasSomaLocatedIn-UBERON-0001950

Has temporary id is the id generated deterministically from the bag of phenotypes. The compact ids are subjects of all the triples, of course Protege completely fails to make those accessible anywhere in the interface except in the little strip above class annotations in the entities tab (sigh). I can add them as an annotation property if that would help.


Missing function signatures in typescript.d.ts

TypeScript Version:  4.0.2

Search Terms: getMutableClone cloneNode createThrow createNew NodeFactory
Code
ts.factory.cloneNode(someNode);

Expected behavior:
The compiler should compile the code just fine without error.
Actual behavior:
The compiler signal an error saying that the cloneNode function does not exists on NodeFactory.
On ts.getMutableClone the deprecated notice says we should use factory.cloneNode instead.  Unfortunately, there is no cloneNode function defined on NodeFactory according to the declaration file (typescript.d.ts).
However, if I trick the compiler with the following code, I see that a cloneNode function do exist on the object that implements the NodeFactory interface at runtime.
(ts.factory as any).cloneNode(someNode);

Related Issues:
I have seen a few deprecated notices that are a bit misleading on many functions in the ts namespace.  I have not checked all functions, but to name a few:

createThrow says to use factory.createThrow instead of factory.createThrowStatement.
updateThrow says to use factory.updateThrow instead of factory.updateThrowStatement.
...
The same goes for createNew, updateNew, createTry, updateTry

same with createObjectLiteral, createCall as well :(

I hit this today while trying to update tsickle to use the new NodeFactory API.
I need to use nodeFactory() to replace getMutableClone(), but cannot.
The misleading method names were annoying, but I was able to find the ones I needed.
Is this likely to be fixed in a 4.0.x release?
I'm tempted to put off the whole migration of tsickle to NodeFactory until this is fixed so I don't end up with partially migrated code.

getMutableClone wasn't safe to use, in general, since AST nodes should be treated as if they are immutable. I don't recommend using cloneNode as isn't all that safe to use either, and I've been trying to reduce its use within the compiler itself. You're generally better off using one of the update methods if you need to get an updated Node. The most of the uses of cloneNode in the compiler today are to essentially clone identifiers for unique comment/source map positions, which I intend to clean up.
What are your use cases for getMutableClone that aren't served by the various update methods?

I'd like to further clarify why cloneNode shouldn't be used and isn't available in the published API. In the TypeScript compiler we track the set of necessary transformations on a Node using a bitmask known as TransformFlags. Prior to 4.0, we would dynamically compute the transform flags for a Node during bind and whenever returning from a call to visitNode or visitNodes, however we've had multiple issues in the past with flags not being calculated in certain cases.
When we refactored the node factory API so that we could use it in the parser, we changed the behavior so that we calculate these transform flags as the tree is created. The logic behind how these flags are calculated is now baked into the various create... (and update...) methods on the factory. If you previously used getMutableClone to copy a node so that you could replace a child (which was the case in several places in the compiler), transformation flags would no longer be correctly calculated. While cloneNode does copy the transform flags of the source node, if you were to attempt to use it in the fashion I just described it would result in incorrect emit. Since this is a practice we'd like to discourage (which is why most child nodes in the TypeScript AST are now readonly), we elected to not make cloneNode available as part of our public API.
The only safe use of cloneNode would be to clone a keyword, token, identifier, or literal. If we do make it public, it will likely only be available for use with those specific cases.

I just put up a PR that fixes the messages, though it does not expose cloneNode as I still need further information on existing getMutableClone use cases.

So the use case that we have to it is effectively ease of use: With cloneNode we can freely manipulate its children regardless of type & depth while with update* API it seems like we've have to return a new visitor that does the traversal & update separately. Coupled that w/ the fact that if we want to pass some parent state to the visitor we've have to hoist/nest it.

Here's a use case for getMutableClone/cloneNode that I've had:
https://github.com/airbnb/ts-migrate/blob/8c1f8c1e48d43f7bc6f9e03cf7f8ba743ac5257c/packages/ts-migrate-plugins/src/plugins/member-accessibility.ts#L80-L84
I have a ClassElement of some kind and I want to update only its accessibility modifier. Without cloning, I have to figure out which specific type of class element I have (PropertyDeclaration, MethodDeclaration, GetAccessor, or SetAccessor) and call its respective update function. It's doable, but it's significantly more verbose and less convenient.

In my case, the fact that the old API had a getMutableClone function make me doubt that the AST nodes were truly immutable and so I was cautious when it was time to mutate nodes.  My knowledge of the compiler internals is limited.  I have built it from the few documentations I found, some blog posts, code examples, trials and errors and code tracing.  Most of the documentation I found was minimal and refered to older versions, so it was probably outdated.
Anyway, in my application, I am cloning nodes at 2 places.  One of the 2 place is already using the update* functions and so, I guess I may safely remove the call to the cloning function since, the way I understand it, the update* functions are returning new immutable nodes.
For the other place, I am unaware if I must clone the node or not.  Without getting into details, let say that I am creating a tool for internal usage that generates a single dts file to expose our public API.  I needed some private fields and functions to be removed from the dts since they are refering types that are not publicly available.  Furthermore, most of theses types came from or were imported from packages that once bundled, are not accessible to the consumer.  Basically, with the help of the TypeChecker, I identify the types that need to be part of our public API, extract their AST nodes, transform them and put them all in a single SourceFile.
I had an issue when I asked the Printer to generate the source code of this SourceFile made of AST nodes coming from different files.  For example, the Printer did not generate the values of the enum members.  After tracing the code, I figured out that the Printer tried to read the enum member values directly from the original source file and failed instead of consulting the AST nodes which have everything it needs.
In order to fix this issue, I created a transformer that removes all links or informations about the original source file.  So I invoke the following functions on the nodes:

ts.setOriginalNode
ts.setTextRange
ts.setSourceMapRange
ts.setCommentRange

I don't know if these functions work like the update* functions and return a new immutable node or if it mutates it.  Right now, I am just cautious and clone the node first.
Thank you


Empty traefik/provider.yaml on worker nodes

Summary
Worker nodes sometimes loose access to api server and become Not Ready, likely during and after restart of control plane nodes.
The situation is that traefik/provider.yaml is present but empty. Restoring traefik/provider.yaml by copying it from another worker node and doing snap restart microk8s is sufficient to recover the worker node.
Reproduction Steps

We can't reproduce reliably but the problem occurs regularly (it did in 1.25, and persists after upgrading the cluster to 1.27).
It seems to happen when we restart dqlite nodes, or when they are upgraded.
Here is a the worker node log when it starts failing:
Sep 08 05:00:01 odoo-k8s-test-worker-3 microk8s.daemon-kubelite[2506]: E0908 05:00:01.609453    2506 controller.go:193] "Failed to update lease" err="Put \"https://<IP_ADDRESS>:16443/apis/coordination.k8s.io/v1/namespaces/kube-node-lease/leases/odoo-k8s-test-worker-3?timeout=10s\":>
Sep 08 05:00:24 odoo-k8s-test-worker-3 microk8s.daemon-apiserver-proxy[2922]: 2023/09/08 05:00:24 updating endpoints
Sep 08 05:00:24 odoo-k8s-test-worker-3 microk8s.daemon-apiserver-proxy[2922]: 2023/09/08 05:00:24 Config file changed on disk, will restart proxy
Sep 08 05:00:24 odoo-k8s-test-worker-3 microk8s.daemon-apiserver-proxy[2922]: Error: proxy failed: failed to load configuration: empty list of control plane endpoints
Sep 08 05:00:24 odoo-k8s-test-worker-3 microk8s.daemon-apiserver-proxy[2922]: Usage:
Sep 08 05:00:24 odoo-k8s-test-worker-3 microk8s.daemon-apiserver-proxy[2922]:    apiserver-proxy [flags]
Sep 08 05:00:24 odoo-k8s-test-worker-3 microk8s.daemon-apiserver-proxy[2922]: Flags:
Sep 08 05:00:24 odoo-k8s-test-worker-3 microk8s.daemon-apiserver-proxy[2922]:   -h, --help                        help for apiserver-proxy
Sep 08 05:00:24 odoo-k8s-test-worker-3 microk8s.daemon-apiserver-proxy[2922]:       --kubeconfig string           path to kubeconfig file to use for updating list of known control plane nodes (default "/var/snap/microk8s/5891/credentials/kubelet.config")
Sep 08 05:00:24 odoo-k8s-test-worker-3 microk8s.daemon-apiserver-proxy[2922]:       --refresh-interval duration   refresh interval (default 30s)
Sep 08 05:00:24 odoo-k8s-test-worker-3 microk8s.daemon-apiserver-proxy[2922]:       --traefik-config string       path to apiserver proxy config file (default "/var/snap/microk8s/5891/args/traefik/traefik.yaml")

Introspection Report
Introspection report on the failing worker node available if needed.

I have exactly the same issue.
Fresh  installation (v1.28.1) with 18 nodes.
3 nodes had empty provider.yaml , coping it from another node and restart helped

Same for me with a fresh cluster (v1.28.1) with 3 master and 2 worker nodes. One of the workers had after joining the cluster an empy /var/snap/microk8s/current/args/traefik/provider.yaml file. After copying the content of it from the other worker node and restarting the service snap restart microk8s it startet working.

I only have one worker node. ...traefik/providers.yaml is empty.

Similar issue, the workers are suddenly reported as Not Ready when I restarted them, v1.28.1. Turns out the provider.yaml is empty, but a bit late for me as I already re-joined one of the worker nodes with fresh microk8s snap package.
Seems a serious issue for production environment.

Same situation during upgrade from 1.27.6 to 1.28.2 on a worker node after the upgrade of the dqlite nodes

Same here with fresh installation of microk8s 1.28.3/stable.
It reappears randomly, Only occurs for some worker nodes while other worker nodes works fine.
I'll observe more

I have the same situvation, and updating the "provider.yaml" with APISERVER endpoints did not fixed the issue.
kubernetes versions i used was 1.28.3 and 1.29.0
I have a six node HA cluster.
microk8s status
microk8s is running
high-availability: yes
datastore master nodes: <IP_ADDRESS>:19001 <IP_ADDRESS>:19001 <IP_ADDRESS>:19001
datastore standby nodes: <IP_ADDRESS>:19001 <IP_ADDRESS>:19001 <IP_ADDRESS>:19001
When any of the datastore nodes are shutdown, other nodes moves to NotReady status. This happens occasionally
xaa@ha-02:~$ date
Fri  2 Feb 12:28:23 UTC 2024
xaa@ha-02:~$ kubectl get nodes -o wide
NAME            STATUS   ROLES    AGE   VERSION   INTERNAL-IP     EXTERNAL-IP   OS-IMAGE                               KERNEL-VERSION                 CONTAINER-RUNTIME
ha-05   Ready       66m   v1.29.0   <IP_ADDRESS>           Red Hat Enterprise Linux 8.9 (Ootpa)   4.18.0-513.11.1.el8_9.x86_64   containerd://1.6.15
ha-01   Ready       83m   v1.29.0   <IP_ADDRESS>            Red Hat Enterprise Linux 8.9 (Ootpa)   4.18.0-513.11.1.el8_9.x86_64   containerd://1.6.15
ha-06   Ready       61m   v1.29.0   <IP_ADDRESS>           Red Hat Enterprise Linux 8.9 (Ootpa)   4.18.0-513.11.1.el8_9.x86_64   containerd://1.6.15
ha-04   Ready       71m   v1.29.0   <IP_ADDRESS>           Red Hat Enterprise Linux 8.9 (Ootpa)   4.18.0-513.11.1.el8_9.x86_64   containerd://1.6.15
ha-03   Ready       75m   v1.29.0   <IP_ADDRESS>           Red Hat Enterprise Linux 8.9 (Ootpa)   4.18.0-513.11.1.el8_9.x86_64   containerd://1.6.15
ha-02   Ready       78m   v1.29.0   <IP_ADDRESS>            Red Hat Enterprise Linux 8.9 (Ootpa)   4.18.0-513.11.1.el8_9.x86_64   containerd://1.6.15
xaa@ha-02:~$
Every 2.0s: kubectl get nodes                                                                                ha-03: Fri Feb  2 12:30:04 2024
NAME            STATUS     ROLES    AGE   VERSION
ha-03   Ready         76m   v1.29.0
ha-02   Ready         79m   v1.29.0
ha-06   NotReady      62m   v1.29.0
ha-01   NotReady      85m   v1.29.0
ha-04   NotReady      73m   v1.29.0
ha-05   NotReady      68m   v1.29.0
It takes 15 to 20 mints to recover automatically, and the applications are not accessiable during this window.
systemctl stop snap.microk8s.daemon-k8s-dqlite; sleep 2; systemctl start snap.microk8s.daemon-k8s-dqlite
Restarting the dqlite service on the nodes that shows "NotReady", can bring the node to "Ready" state quickly
Any fix for this issue..?

FWIW, this seems to happen occasionally on worker nodes when dqlite nodes reboot.
I found this code which manipulates provider.yaml but this seems to be used on join only?

Does the configuration here.  I KNOW it needs to be present in the worker-node in order for the node to connect and show "Ready".

Does this providers.yaml need to be applied in all the master-node args for it to persist to the worker node during resets?  Or would this disrupt the functioning of the nodes on the control plane? Should I try it? Thoughts?

Ok I think I fixed this.
The issue was that I had inconsistent traefik provider.yaml args on my control-nodes (aka nodes on the control plane)
/var/snap/microk8s/current/args/traefik/provider.yaml
So I went through each of my control nodes (4) and applied the SAME provider.yaml on each control node, and then restarted microk8s from the master node.
Then did a "sudo snap microk8s stop && sudo snap microk8s start" on the affected worker node.
The worker node got the provider.yaml as I defined them on the control nodes.
I'm hoping that this is going to be persistent. If I'm back here in two weeks I'll let you know if it worked.

Hi. still got same problem on v1.29.7
14 servers with 6 of them is control planes.

Little update. We got some network outage. and our nodes go through about 15-20 minutest cycle NotReady-Ready every time one of control planes drops. And changing /var/snap/microk8s/current/args/ha-conf to one failure-domain for all controlplanes seems fixing the issue (firstly there was two zones as we have 2 DC near by) So now only one node that dropped due to network is not ready. and all workers not changed status at all. if I return second  failure-domain problems starts again.
Not completely shure what's going on, but whis issue may be related to failure-domains

Confirming same issue here. Looks like the traefik/provider.yaml is losing data.
Possibly this happens in case reboot of the nodes coincides with refresh interval updating the file and file is not being correctly saved?
Can we possibly make this refresh interval logic more resilient to ensure accidental reboots during refresh do not end up in empty file after reboot?

I have just had a case of provider.yaml becoming empty on a worker node.
The logs at the time were absolutely quiet, and all there was is this
microk8s.daemon-apiserver-proxy[50117]: 2024/09/18 12:22:00 updating endpoints
microk8s.daemon-apiserver-proxy[50117]: 2024/09/18 12:22:00 Config file changed on disk, will restart proxy
microk8s.daemon-apiserver-proxy[50117]: Error: proxy failed: failed to load configuration: empty list of control plane endpoints

I've tried looking at the code but so far could not find the place that is responsible for this updating endpoints  message. My hypothesis is that there is some incorrect error handling code there that leaves the file empty.

Woke up this morning to an empty provider.yaml on one of my worker nodes.
HA Cluster, 3 control-planes and 7 workers.
Same logs as observed before
microk8s.daemon-apiserver-proxy[252757]: 2024/10/16 00:10:32 updating endpoints
microk8s.daemon-apiserver-proxy[252757]: 2024/10/16 00:10:32 Config file changed on disk, will restart proxy
microk8s.daemon-apiserver-proxy[252757]: Error: proxy failed: failed to load configuration: empty list of control plane endpoints
microk8s.daemon-apiserver-proxy[252757]: 2024/10/16 00:10:32 proxy failed: accept tcp [::]:16443: use of closed network connection

I do however observe this log line on one of my control-planes
microk8s.daemon-kubelite[820226]: W1016 00:10:31.058031  820226 lease.go:265] Resetting endpoints for master service "kubernetes" to [192.168.x.x 192.168.x.x]

Thank you all for your time and effort in bringing attention to this issue and for sharing your workarounds. I sincerely apologize for the inconvenience and the fact that this issue is still not resolved. We are currently working on identifying a solution, and we will provide updates as soon as we have more information.

I suspect this line to be responsible for this issue.
Unfortunately I was not able to reproduce this scenario so far. Even tried with a 13 node cluster (3 CP,s 10 workers, Microk8s v1.28) running on LXD containers and did a bunch of chaotic things to the cluster (restarting containers, removing, rejoining, etc.), yet still the problem didn't surface.
We'll start working towards a fix and post further updates here.

Hopefully with the proposed fix we won't see this issue anymore. The change will soon be promoted to stable.
Let us know if you were still experiencing this issue.

Thanks you @HomayoonAlimohammadi !
By the way, how can one identify the updates that are released on the stable channel?

Hi @sbidoul! Sorry that I completely missed your question.
Unfortunately it's a bit hard to tell, but any snap of 1.28 up to 1.31 should contain the fix.


feature(region): support AWS organization

这个 PR 实现什么功能/修复什么问题:
新增：支持AWS organization

是否需要 backport 到之前的 release 分支:

release/3.7

/cc @ioito @tb365  @zexi @yousong
/area region

Codecov Report

Merging #10213 (aec00f3) into master (3587659) will increase coverage by 5.83%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #10213       +/-   ##
===========================================
+ Coverage    5.93%   11.77%    +5.83%
===========================================
  Files         860      234      -626
  Lines      133693    26299   -107394
===========================================
- Hits         7939     3097     -4842
+ Misses     125048    22891   -102157
+ Partials      706      311      -395

Flag
Coverage Δ

aFlag
11.77% <ø> (+5.83%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/validators/validators_cert.go
37.06% <0.00%> (ø)

pkg/compute/models/schedtags.go

pkg/cloudcommon/db/tablespec.go

pkg/compute/models/loadbalancer_common.go

pkg/mcclient/options/servers.go

pkg/monitor/models/notification.go

pkg/compute/models/zoneresource.go

pkg/compute/models/scheduledtask_activity.go

pkg/util/fileutils2/fasthash.go

pkg/cloudcommon/policy/token.go

... and 600 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3587659...aec00f3. Read the comment docs.

/lgtm


Using relative url for submoduling.

Issue: https://github.com/FreeRTOS/FreeRTOS/issues/21

Thanks!

Anything blocking this?

🎉


Add normals to mesh

I noticed that vertex, faces, and vertex color can be passed in for decimation. It it possible to also pass in vertex normals?

Hi @FreakTheMighty! No, the calculation of the normals is not implemented in the C++ source code, and it is not planned to add it. It would only add minor benefits, as normals can easily be re-calculated using other tools. Furthermore, different approaches to check for the right orientation of the normals can be implemented, and if the mesh is non-watertight, it is non trivial to orient the normals.
Concerning the vertex colors, they are passed as an argument in the setMesh method, but only as a reminder that passing and tracking vertex colors is still to be implemented as seen in this issue .

You can use mean_vertex_normals to recompute normals:
import pyfqmr
import trimesh as tr
bunny = tr.load_mesh('./example/Stanford_Bunny_sample.stl')
mesh_simplifier = pyfqmr.Simplify()
mesh_simplifier.setMesh(bunny.vertices, bunny.faces)
mesh_simplifier.simplify_mesh(target_count = 1000, aggressiveness=7, preserve_border=True, verbose=10)
vtx, fc, normals = mesh_simplifier.getMesh()
mesh = tr.Trimesh(vertices=vtx,faces=fc)
mesh.export("~/simple.obj")
norm = tr.geometry.mean_vertex_normals(len(mesh.vertices), mesh.faces,mesh.face_normals)
mesh = tr.Trimesh(vertices=vtx,faces=fc, vertex_normals=norm)
mesh.export("~/simple_w_normals.obj", include_normals=true)


Ignores Correlations

This is a sort of subtle bug.  Consider the following two expressions.
*Data.Uncertain> 10 `withPrecision` 2 - 10 `withPrecision` 2
0.0 +/- 1.
*Data.Uncertain> let x = 10 `withPrecision` 2 in x - x
0.0 +/- 1.

The first of these is giving the right answer, because the uncertainty of the two 10s is independent. But the second should give 0 +/- 0 because regardless of your uncertainty about its true value, x minus x is zero.
Tricky, eh?
This trick can also be used in the other direction, by the way, to get the system to underestimate rather than overestimate uncertainties.  E.g., x*x*x*x*x.

It's been almost a year, but I think I've begun to hit on a solution with 9453e7a7fec that's different from the probability monad solutions.  It's a monad that keeps track of variances and covariances and values as a State.
Example usage:
test :: Floating b => [Uncertain b]
test = getCorrelateds $ do
    x <- fromUncertain (3.24 +/- 0.01)
    (y, z) <- fromUncertain2 (11 +/- 4) (15 +/- 6) 0.9    -- 0.9 is the correlation coefficient
    return [x + y, x - y, x + z * y, (x * y) * z, x * (y * z), 2 * x, x + x]

the Correlated Monad keeps track of a covariance matrix and updates all of the covariances whenever a new value is added or requested.  The "uncertainty" of x + x is preserved as if it was 2 * x, not two independent samples from identical distributions.
The example in the original post would be translated as:
test :: Floating b => [Uncertain b]
test = getCorrelateds $ do
    y <- fromUncertain (10 `withPrecision` 2)
    z <- fromUncertain (10 `withPrecision` 2)
    x <- fromUncertain (10 `withPrecision` 2)
    return [y-z, x - x]

The result of y - z should be 0 +/- 1 and the result of x - x should be 0 +/- 0...and you should get as a result
ghci> test
[0 +/- 1, 0 +/- 0]

As of now the implementation is not complete, as full back-propagation of the covariances and correlations has to be worked out with pen and paper.  But so far I think this shows a lot of promise.

With https://github.com/mstksg/uncertain/releases/tag/v<IP_ADDRESS> , i implemented a "probability monad" type interface that kept track of correlations, but instead of using monte carlo sampling, uses ad to calculate uncertainties, taking into account correlations between values :)  It's exported in the Data.Uncertain.Correlated module.  I think, with the ad-based solution, I'd consider this issue addressed! :D

Cute!


Feature/sign in flare

Description
Fixes Bug #6 Default Behavior on Sign Up/In Screen
Trello card: https://trello.com/c/c7mEbnie/120-bug-6-default-behavior-on-sign-up-in-screen
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Change Status

[x] Complete, tested, ready to review and merge

How Has This Been Tested?

[x] Manually tested with simulator (iPhone 8)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] There are no merge conflicts

 Bug #6 Default Behavior on Sign Up/In Screen


game on unfocus workspace behavior

i normally use two monitors, so i use to put my game in one while keep discord or web, terminal, etc in another.
but recently i been using only one. so i keep my game in a workspace while iterate to other workspaces while loading screens are (of course) "loading". then i found that games doesn't progress the load process until i return to the workspace game is.
tested with WoW and MTGA. both runs under wine, lutris.

That's down to the game. Many games do that.

Ok, don't want to blame the wm for this behavior. But help me here. It's probably related to a workspace going inactive. I really don't understand much about this, so I ask you to explain me or at least point me where to read about.

The app loses focus and the game pauses itself on lost focus. Most likely.

But isn't happen when a second monitor is in use, that's why i mention it. Literally a different workspace is been used on second monitor, so game isn't focused and it is in a different workspace on the first monitor , but behaves correctly, the "freeze" behavior is only if workspace with the game is in the back.

By design, in Wayland, we suspend rendering to surfaces that are not visible. If the game can't handle that, it may freeze.


store the blockchain in a local database

This Draft PR is a proof-of-concept for storing the blockchain in a local database.
For this POC, leveldb was used.
There are some good and bad news:

Good: this reduces memory requirements as seen in issue #109
Good: this also fixes the "diverges for 1 blocks" issue seen in #110
Bad: leveldb is not portable, I was not able to get it working on Linux ARM
Bad: leveldb is a very simple key/value db, we can't index by address for instance to speed up balance operations

I do not recommend merging this until at least the portability issue is resolved.
Publishing as a draft in case someone is able to assist, or in case you need an emergency workaround for #109

Closing in favor of sqlite3 solution due to LevelDB not working on ARM Linux.


Test The model on a single image

Hello,
please can you show how to test the final model on a single image
Thank you
Lafi

I meet the same problem.

@carpedm20 Could you guide us towards how we could do this? Seems like an issue for a lot of us.

"--sample_per_image 1", it will be OK

@vtgist @happsky @shadow111


Add govee/H601C LED Downlight

Device information

https://us.govee.com/products/govee-smart-rgbww-recessed-lights-4-pack
Home Assistant Device information

H601C
by Govee
Connected via [Govee to MQTT]
Checklist

[X] I have created a single PR per device. When you have multiple submissions please create separate PR's.
[X] For lights - I have only included the gzipped files (*.gz), not the raw CSV files.
[X] For lights - I have provided a CSV file per supported color mode. Look that up in Developer Tools -> States

Additional info

Added gitignore file to avoid accidentally adding cvs files.

Thanks again @brianegge.
Good idea to add csv extension to gitignore as well.


is this work on ios

I want to know that is this work on ios and also how can I  implement running process like start and end button

Hi, it's Android only module,
// Start button:
GoogleFit.startRecording((res) => {
// do something here
})

// Stop button:
GoogleFit. unsubscribeListeners()


better way to skip tests

Description
a better way to skip tests from the documentation
Purpose

Wow that's really neat! LGTM


[Doc]Fix broken link

Fixes https://github.com/apache/pulsar/issues/5493
Master Issue: https://github.com/apache/pulsar/issues/5493
Motivation
Currently, due to the change of file name, the old version of the document cannot be connected to the document, resulting in a large number of 404
Modifications

Fix broken links and maintain compatibility with old versions.

Verifying this change
run command yarn build
Warnings that begin with the following do not appear
[WARN] unresolved links in file

run cpp tests

run cpp tests