Discount code rule not working?

How is the "discount code rule" intended to work?
Both Manual and Generate doesn't seem to add content to "Discount codes:" and "Unused discount codes:" ..  and the download link returns:
The specified argument value for the function is not valid. [ Argument # = 1,Name of function(if known) = isnull ]

.. maybe because the discount code is null?
I should mention i have tested with SQL CE.

I also think it's a bit confusing, when you had a manual code and how many times it can be used you see:
Discount codes: 1
Unused discount codes: 1
The text file contains 1 code, but you can't see how many times the code was set to be used.. and how many times left it can be used. The same when the codes are generated - they are added, but the "Max uses" needs to be more clear afterwards.
Furthermore when added manual codes it isn't clear how they should be separated.. with comma? with space?

Hi Bjarne
Your second comment is more an enhancement than a bug. Could you make a new issue. Thanks.

Have you tried to use MS SQL and see if that works. Just to be sure if it is the SQL CE that make problems.

Hi Anders
I think it was a bit confusing because you can add discount codes, but you can't edit them (and see them without downloading the txt file). And I think I got the error, when adding an empty code and click on download (or just download before codes were added).
I think I got the error when using SQL CE - I'll check it later or in this weekend.

When I SQL CE locally in Umbraco 7 and click generate for a discount code rule, I get this error:
POST http://localhost:34226/umbraco/backoffice/teacommerce/discountcodes/generate 500 (Internal Server Error)

Response from server:
{"Message":"An error has occurred.","ExceptionMessage":"The specified argument value for the function is not valid. [ Argument # = 1,Name of function(if known) = isnull ]","ExceptionType":"System.Data.SqlServerCe.SqlCeException","StackTrace":"   at System.Data.SqlServerCe.SqlCeCommand.ProcessResults(Int32 hr)\r\n   at System.Data.SqlServerCe.SqlCeCommand.CompileQueryPlan()\r\n   at System.Data.SqlServerCe.SqlCeCommand.ExecuteCommand(CommandBehavior behavior, String method, ResultSetOptions options)\r\n   at System.Data.SqlServerCe.SqlCeCommand.ExecuteDbDataReader(CommandBehavior behavior)\r\n   at System.Data.Common.DbCommand.System.Data.IDbCommand.ExecuteReader()\r\n   at TeaCommerce.Api.Persistence.Database.<Query>d__c`1.MoveNext()\r\n   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)\r\n   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)\r\n   at TeaCommerce.Api.Persistence.Marketing.Repositories.DiscountCodeRepository.GetInternal(String sql, Object[] args)\r\n   at TeaCommerce.Api.Persistence.Marketing.Repositories.DiscountCodeRepository.GetAll(Int64 storeId, Nullable`1 ruleId)\r\n   at TeaCommerce.Api.Marketing.Services.DiscountCodeService.Generate(Int64 storeId, Int64 ruleId, Int32 numberToGenerate, Nullable`1 maxUses, Int32 length, String prefix, String postfix)\r\n   at TeaCommerce.Umbraco.Application.Controllers.DiscountCodesController.Generate(GeneratePostData postData)\r\n   at lambda_method(Closure , Object , Object[] )\r\n   at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.<>c__DisplayClass13.<GetExecutor>b__c(Object instance, Object[] methodParameters)\r\n   at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.Execute(Object instance, Object[] arguments)\r\n   at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.<>c__DisplayClass5.<ExecuteAsync>b__4()\r\n   at System.Threading.Tasks.TaskHelpers.RunSynchronously[TResult](Func`1 func, CancellationToken cancellationToken)"}

I think it a SQL CE thing, when generating the discount codes.

It is a similar issue first time you add a discount code rule before you have added any discount codes.

Response from server:
{"Message":"An error has occurred.","ExceptionMessage":"The specified argument value for the function is not valid. [ Argument # = 1,Name of function(if known) = isnull ]","ExceptionType":"System.Data.SqlServerCe.SqlCeException","StackTrace":"   at System.Data.SqlServerCe.SqlCeCommand.ProcessResults(Int32 hr)\r\n   at System.Data.SqlServerCe.SqlCeCommand.CompileQueryPlan()\r\n   at System.Data.SqlServerCe.SqlCeCommand.ExecuteCommand(CommandBehavior behavior, String method, ResultSetOptions options)\r\n   at System.Data.SqlServerCe.SqlCeCommand.ExecuteDbDataReader(CommandBehavior behavior)\r\n   at System.Data.Common.DbCommand.System.Data.IDbCommand.ExecuteReader()\r\n   at TeaCommerce.Api.Persistence.Database.<Query>d__c`1.MoveNext()\r\n   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)\r\n   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)\r\n   at TeaCommerce.Api.Persistence.Marketing.Repositories.DiscountCodeRepository.GetInternal(String sql, Object[] args)\r\n   at TeaCommerce.Api.Persistence.Marketing.Repositories.DiscountCodeRepository.GetAll(Int64 storeId, Nullable`1 ruleId)\r\n   at TeaCommerce.Api.Marketing.Services.DiscountCodeService.GetAll(Int64 storeId, Nullable`1 ruleId)\r\n   at TeaCommerce.Umbraco.Application.Controllers.DiscountCodesController.GetCount(Int64 storeId, Int64 ruleId)\r\n   at lambda_method(Closure , Object , Object[] )\r\n   at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.<>c__DisplayClass13.<GetExecutor>b__c(Object instance, Object[] methodParameters)\r\n   at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.Execute(Object instance, Object[] arguments)\r\n   at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.<>c__DisplayClass5.<ExecuteAsync>b__4()\r\n   at System.Threading.Tasks.TaskHelpers.RunSynchronously[TResult](Func`1 func, CancellationToken cancellationToken)"}

but I am not sure you want to support SQL CE? .. I mostly use it only for test purposes and easy setup, but in that case it seems to have some issues when using SQL CE.


Clean up the spec to remove narrative not implemented and no longer relevant

A clean up of the peer:did spec to simplify the spec and in preparation for additional PRs to come in the near future.
This PR removes asperational sections of the spec that have not come to pass, and are not expected to ever come to pass. The biggest removal is the idea that the DID peer method will ever support updates to peer DIDs. Instead, the "Update" process for a peer DID is "DID Rotation", rather than "key rotation". While a general goal of changing the identifier for a DID, in the case of did:peer DIDs, this is less of a problem because of how the DID is used -- in a relationship. In most (all?) implementations, the (locally defined) ID of the relationship needs persist, and the DIDs can be easily changed.
In removing the major sections of the spec, I've revised the remaining text to remove references to those sections and the concepts they outlined.
By removing the asperational text from the specification, and focusing only on what is "real" in the communities using Peer DIDs, we simplify the DID Method and make it easier for developers to create new implementations as needed.
We anticipate further updates to the specification to simplify it, including:

Deprecate numalogos that have found not to be useful/popular -- notably did:peer:0 and did:peer:1.
Convert the spec to use DIF's SpecUp
Simplify and clarify the handling of the did:peer:2/3 combination

Signed-off-by: Stephen Curran<EMAIL_ADDRESS>

FYI -- @dhh1128 @dbluhm @TelegramSam @peacekeeper @Jsyro @andrewwhitehead

How about we PDF the current document and put it in the repo.  The content is, of course, preserved by the magic of GitHub.  We could also tag the version at the commit before the merge of this PR.
If the PDF idea works, I can add that to my PR.

@dhh1128 -- is the PDF idea sufficient?  Or do you have another idea?  We'd like to get this merged, if possible.

Sorry that I didn't respond earlier. Yes, PDF works great.

I'll just raise a PR that adds the PDF as a different task. Let's get this merged.

Thanks! Just caught me as I was going to do that.


bug: With format_on_save, timeout_ms must be set really high to have prettier working

Neovim version (nvim -v)
v0.10.0-dev
Operating system/version
WSL (Windows Subsystem Linux), Ubuntu 20.04.6 LTS
Add the debug logs

[X] I have set log_level = vim.log.levels.DEBUG and pasted the log contents below.

Log file
15:14:08[DEBUG] Running formatters on /home/user/my-project/Test.tsx: { "prettier" }
15:14:08[INFO] Run prettier on /home/user/my-project/Test.tsx
15:14:08[DEBUG] Run command: { "/home/user/my-project/node_modules/.bin/prettier", "--stdin-filepath", "/home/user/my-project/Test.tsx" }
15:14:08[DEBUG] Run CWD: /home/user/my-project
15:14:09[WARN] Formatter 'prettier' timeout
15:14:09[INFO] prettier exited with code 143
15:14:09[DEBUG] prettier stdout: { "" }
15:14:09[DEBUG] prettier stderr: { "" }

Describe the bug
I was expecting that the suggested conf of 500 ms had worked just fine, but I had a timeout.
The same result setting timeout_ms = nil, or removing it (so getting the default 1 sec, I guess.
It seems that like just the async option is not set to false as documented.
What is the severity of this bug?
minor (annoyance)
Steps To Reproduce

nvim /hove/user/my-project/Test.tsx
mess up the file
:w

Expected Behavior
I was expecting to have the file formatted by prettier and next saved by nvim. Only save succeed, and Conform reports the errors above. The only way to make it work is set to a very hight value like timeout_ms = 999999

The default value of 500ms should be plenty of time for most formatters, and since formatting freezes the UI you probably don't want it to be larger than 500ms anyway. The quick fix for you that I would recommend is try using format_after_save instead of format_on_save (these are documented here).
Both format_on_save and format_after_save are just convenience wrappers that set up some autocmds for you. format_on_save uses a BufWritePre autocmd, which means that it executes in between the :w and Neovim actually writing the buffer to disk. For this reason, we must complete the formatting synchronously and block all processing in the meantime, otherwise Neovim will write the unformatted buffer to disk while we are still formatting.
format_after_save uses the BufWritePost autocmd. After Neovim writes the buffer to disk, we try to format the file. This happens asynchronously and does not need to block the UI. Once formatting is completed, it applies the changes to the buffer and re-saves the buffer to disk. If the user has modified the buffer at all between formatting start and formatting completion, we abandon the changes (to avoid overwriting your edits).
When your formatter takes a long time to run, the recommended way to handle this is via async formatting (such as format_after_save).

Crystal-clear @stevearc, thank you so much for your detailed answer. It works like a charm!

I was struggling with this same issue, and what fixed this for me was using prettierd instead of prettier.
Much faster than prettier, and cleaner than running after save.
    conform.setup({
      formatters_by_ft = {
        javascript = { "eslint_d","prettierd" },
        typescript = { "eslint_d","prettierd" },
      }
     })


<EMAIL_ADDRESS>import_meta.glob is not a function

The latest Vite release<EMAIL_ADDRESS>breaks and the browser throws Uncaught TypeError: import_meta.glob is not a function.
Seems to be related to the esbuild major update.
https://github.com/vitejs/vite/issues/3617
In the meatime stick to<EMAIL_ADDRESS>

After running a npm init vite-plugin-ssr@latest, I'm also getting this same error:
pageFiles.ts:5 Uncaught TypeError: import_meta.glob is not a function
    at pageFiles.ts:5

And nothing happens when clicking on the Counter.
I've tried with node 16 / vue-ts, node 14 / vue, node 14 / react, same problem.
I also tried to bump vite to 2.6.2.
Not sure what I did wrong.

@cedric25 I'm having a look

I can reproduce

Temporary solution: pin to "vite": "2.5.10" (note the missing ^).

It's not the same issue, closing in favor of https://github.com/brillout/vite-plugin-ssr/issues/156


Support both ESM and CJS modules

This may be trickier than it looks. My first attempt at shipping .mjs and .cjs builds failed as it broke some build systems. For example, shipping an .mjs build with module mapping broke CRA, but not parcel.
Others seem to have similar issues as well:
https://twitter.com/sebmarkbage/status/1498850329156329472
https://twitter.com/_rschristian/status/1498859530444320772
https://github.com/preactjs/preact/issues/3220#issuecomment-1038467450

Related: #59 and #99

So, I just took a look at the build pipeline, and I think it has enough documentation to explain how it works. I suggest starting with the yarn build script to see how each package's build script works.

For what it's worth, I've found this to be enough of a pain that I'm trying to only ship ESM in new libraries, particularly libraries meant for web. I think three.js will eventually drop its pseudo-CJS builds as well. Unless I need separate web / node.js builds, then I might do the node.js version as CJS.
If you do go forward though, I've found microbundle's defaults to be quite helpful.

Came across this by chance (always funny seeing myself quoted in the wild), but certainly feel free to ping if you ever need help pushing it forward.
Just some forewarning, NextJS in particular will always be difficult as it frequently invokes the dual package hazard. This is something that routinely breaks every few months so shipping dual module output does often require some push back on users and telling them to go file upstream unfortunately.
Microbundle's recommendation works with every modern build tool, but it would probably be better to keep package type as CJS and instead ship .mjs (if using "exports", shipping .mjs for "module" risks breakages for no real gain as that field does not need to be bound by Node semantics) if you'd like to support older build tools. .mjs was picked up and popularized before .cjs, so there are some tools that support only the former.

For 0.5 we are going to support CJS for Core and Studio; and both CJS and ESM for the r3f extension. I tested this configuration of packages with NextJS (it successfully avoid the dual package hazard that @rschristian mentioned), Parcel, Vite, and Create React App.

I attempted, but failed to add support ESM wrappers for CJS from Core and Studio. I failed to fix the dual package issue in NextJS when both ESM and CJS exports are available.

Is Next.js still blocking ESM support? If it's mainly Next.js holding things back, and compiling CJS/ESM builds isn't a problem otherwise, perhaps it would be possible to create a second entrypoint:
// package.json
"type": "module",
"types": "./dist/index.d.ts",
"main": "./dist/cjs/index.cjs",
"exports": {
  "./cjs": {
    "types": "./dist/index.d.ts",
    "default": "./dist/cjs/index.cjs"
  },
  "types": "./dist/index.d.ts",
  "require": "./dist/cjs/index.cjs",
  "default": "./dist/modern/index.js",
}

Then Next.js users can opt into the CJS entrypoint, and other users can have a more modern installation. Or the reverse of that, with a .//modern entrypoint. I'm having some trouble getting @theatre/core to interact well with some ESM environments, particularly where @theatre/core is a dependency of a dependency.

Hey @donmccurdy, is it possible to share a repro of this? We'd then put it in /compat-tests and fix it.

Thanks @AriaMinaei! See https://github.com/theatre-js/theatre/pull/453.

In addition to the test failure in #453, I'm also seeing builds where:
// ✅ ok
import * as theatre from '@theatre/core';
const { getProject, onChange } = theatre;

// ❌ fails
import { getProject, onChange } from "@theatre/core";

Which you'd sure think would be equivalent, but the second line prints this error:
import { getProject, onChange } from "@theatre/core";
         ^^^^^^^^^^
SyntaxError: Named export 'getProject' not found. The requested module '@theatre/core'
is a CommonJS module, which may not support all module.exports as named exports. CommonJS
modules can always be imported via the default export, for example using:

import pkg from '@theatre/core';
const { getProject, onChange } = pkg;

I'm not sure yet how to reduce that to a simple test, though. I am using Vite and SvelteKit SSR.

Thanks for the PR.
And yeah, this is interesting. import {getProject} from "@theatre/core" seems to work with vite2/cra/parcel/next, and we do have a vite4 test that worked as of 0.7. I'll run this test on the 0.7 commit and see if it still works.

@grischaerbe 0.8 will fix this. But from what I remember from our chat, you mentioned that this particular problem was a bundler misconfiguration issue, right?
Either way, the fix is merged in 0.8 so it'll be in the next release.

@grischaerbe 0.8 will fix this. But from what I remember from our chat, you mentioned that this particular problem was a bundler misconfiguration issue, right?
Either way, the fix is merged in 0.8 so it'll be in the next release.

This changed again with vite 5 which is the default for new SvelteKit projects. I can't seem to find a configuration that works at all unfortunately, usual CJS/ESM can of worms 🫠
Great to hear that this is fixed in 0.8, is there a timeline or even a canary release for that?

@AriaMinaei I managed to get it working with this intermediate theatre export / barrel file. It's cumbersome, but solves the immediate issue. Thanks for the heads up and sorry for the confusion 👍

@AriaMinaei any news on this? struggling as well.


Tutorials + Associated Deployment Issues

This will be the final PR for to finish up the ESIP tutorials. The tutorials themselves are in pretty decent shape, but the infrastructure deployment needs a little bit of work.

One issue revealed here is that the current Terraform configuration (https://github.com/acannistra/planet-snowcover/blob/rework-terraform/deployment/resources.tf) relies upon the AWS IAM user represented bye the provided credentials to have basically Admin access to the account (in particular it needs IAM user creation abilities, a relatively permissive set of permissions). This may prevent some users from using the terraform build (it prevented me from using the new DLT-managed account to test, for example).

The most recent changes require specific IAM permissions, which I'm going to keep track of here:

iam:CreatePolicy


Add german translations

Hello everyone!
In order to contribute to https://github.com/HospitalRun/hospitalrun-frontend/issues/141 (i18n) I added translations for German.

@cfleschhut Thanks for the PR and for fixing the delete user text.
I am going to go ahead and merge this PR.


[CLOUD-1511] - Use secrets for password variables to hide their displ…

…ay in the OpenShift console

@spolti, could you please rebase.  sorry.

outdated.


Fix concat task dependencies for Variational and EnKF

Description
This PR fixes the dependency for the concat task in the Variational and EnKF applications. The HofX was fixed some time ago but I missed fixing these two as well.
Issue closed
None
Tests completed
Tier 1:

[x] 3denvar_O30kmIE60km_WarmStart
[x] eda_OIE120km_WarmStart
[x] getkf_OIE120km_WarmStart

Tested by using 3denvar scenario for several cycles. The concatenated files were successfully generated, and the workflow moved to the next cycle without issues. Many thanks for fixing this.

Thanks so much for testing, @junmeiban!


Do not immediately close QPACK decoder and encoder streams

The logic for locating the control stream accepted all pending streams,
took ownership, and immediately dropped everything but the control
stream.  The streams are closed on drop.
Closing critical QPACK streams will trigger an H3_CLOSED_CRITICAL_STREAM
error on the other end and scupper the connection:
https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#name-encoder-and-decoder-streams
To fix this, transfer ownership of the two accepted QPACK streams to the
connection object.  This doesn't do anything to make dynamic QPACK work,
but it seems to be enough to interoperate with at least neqo and firefox.

(rebased so rustls works in CI)


MB-16351 add sit fsc details on TOO view

Jira ticket
Summary
This tickets adds SIT FSC details to the service items tables.

[ ] Make sure relevant information is visible on the table
[ ] Run through manual test plan to verify functionality

this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Login as prime simulator
Look at MISHIP or any other move with approved shipments
Click on Add Service Item button
Select Origin SIT for service item type field and fill out form
Click Create Service Item button
Repeat steps 4 and 5 for Destination SIT service item type
Login as TOO
Look at the MISHIP and make sure that service item details are there for FSC

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-16351

  Generated by :no_entry_sign: dangerJS against ed0fc21846d877822d59efa20a17533e074136a2


Plugin support - Marshmallow

Is it possible to get Marshmallow integration?   I could possibly do this if someone pointed me in the right direction to add it:
Similar to this project but Flasgger is better since it provides all the html (no secondary server is required)
https://github.com/marshmallow-code/apispec

I guess it is in #40 someone need to try

implemented. added new app in examples/


Is it possible to spawn task to be executed in specific thread?

I want to have something like broadcast but which allows to execute a task in a specific thread, using result of rayon::current_thread_index as a selector.
Context: it would allows to access something like bevy_ecs::NonSend soundly while running event loop entirely inside rayon threadpool.

Do you really want any specific thread, or usually just the current thread? If it's the latter and that's blocking like broadcast, then you might as well just call whatever you wanted directly.

No, I want any specific thread.
E.g. if I am running a game and have 2 non-send non-sync objects, e.g. native not-threadsafe Audio library in thread 2 and non-send Rhai VM in thread 3. I want to be able detect in thread 4 that there is nothing blocking execution of audio update and scripts update, so I spawn from thread 4 two tasks which must be executed exactly on thread 2 and thread 3, possibly in parallel to each other.
The reason why I want to do it this way instead of, e.g. execute non-sync parts on main thread and all other code in rayon, because I found out that if I put main event loop of a game into rayon threadpool, there is less jitter in FPS. Probably because time for waking main thread after finishing rayon tasks may vary wildly, and then there is need to wake rayon threads after starting new frame and submitting new tasks. When I run my main gameplay loop inside rayon thread pool, there is always at least one thread that never really blocks and keep working on tasks.

No, I want any specific thread.
E.g. if I am running a game and have 2 non-send non-sync objects, e.g. native not-threadsafe Audio library in thread 2 and non-send Rhai VM in thread 3. I want to be able detect in thread 4 that there is nothing blocking execution of audio update and scripts update, so I spawn two tasks from thread 4 which must be executed exactly on thread 2 and thread 3, possibly in parallel to each other.

Ok, and do you want to block (with work stealing) to wait for a return value like broadcast? Or fire-and-forget like spawn_broadcast? (possibly with a lifetime like Scope::spawn_broadcast)

The reason why I want to do it this way instead of, e.g. execute non-sync parts on main thread and all other code in rayon, because I found out that if I put main event loop of a game into rayon threadpool, there is less jitter in FPS. Probably because time for waking main thread after finishing rayon tasks may vary wildly, and then there is need to wake rayon threads after starting new frame and submitting new tasks. When I run my main gameplay loop inside rayon thread pool, there is always at least one thread that never really blocks and keep working on tasks.

Regarding the latency from the main thread, note that you can also make that act as part of the pool with ThreadPoolBuilder::use_current_thread.

P.S. And I also want to have this thread-specific tasks to have bigger priority to normal tasks, because normal tasks can be stolen and executed by other threads while those are limited to one.

That would be different than the current broadcasts, which are currently checked between local queue exhaustion and remote work stealing. Note that even if we add a new higher-priority queue that goes before normal tasks, we don't have any means of interrupting anything that's already executing, like an OS scheduler would with preemption. If you have that kind of need, it would probably be better to use dedicated threads outside of the pool.

Ok, and do you want to block (with work stealing) to wait for a return value like broadcast? Or fire-and-forget like spawn_broadcast? (possibly with a lifetime like Scope::spawn_broadcast)

I personally want Scope::spawn_broadcast for my use case.

That would be different than the current broadcasts, which are currently checked between local queue exhaustion and remote work stealing.

Well, it was something that nice to have but not crucial.


Handling of generic response types and IEnumerable is different in 5.0.0-rc5

In order to use core 3.1 I upgraded swashbuckle from version 4.0.1 to 5.0.0-rc5. After fixing some issues that were introduced due to the breaking changes I got it up and running.
I'm producing V2 swagger files using this configuration:
app.UseSwagger(c => c.SerializeAsV2 = true);

But I have an action inside a controller that returns a generic type PagedResult<T> that implements IEnumerable<T>. This leads to two problems.

The generic type is ignored and the return type is specified as a simple array.
Version 4.0.1 returned this

"responses": {
    "200": {
        "description": "Success",
        "schema": {
            "$ref": "#/definitions/PagedResult[ApplicationListItem]"
        }
    }
}

Since upgrade to 5.0.0-rc5 I get this response:
"responses": {
   "200": {
      "description": "Success",
      "schema": {
         "type": "array",
         "items": {
            "$ref": "#/definitions/ApplicationListItem"
         }
      }
   }
}

The generic type is not taken into account, which hides all the properties of this class.
I tried decorating the class with
[JsonObject]
[ProducesResponseType(typeof(PagedResult<>), (int)System.Net.HttpStatusCode.OK)]

but with no success.
When I remove the IEnumerable<T> interface from the PagedResult<T> the result seems fine, but this leads me to my 2nd issue:

Previously the generated definition was PagedResult[ApplicationListItem]. This changed to ApplicationListItemPagedResult which breaks all my client code.

How would I address these issues?

Which serializer are you using - Newtonsoft or System.Text.Json? When you have a DTO that implements IEnumerable<T>, I believe both of these will serialize instances to a JSON array. So, they may have additional properties in the C# world, but externally they will be emitted as simple arrays. Therefore, it seem 100% correct for Swashbuckle to describe them as simple arrays.
Could you provide a screenshot of the JSON that your API returns when PagedResult<T> is used as the underlying action return type? If it's not a simple JSON array, then I think you must have customized the serializer behavior (perhaps using a JsonConverter?), and therefore would need to customize Swashbuckle accordingly aswell.

Closing due to lack of activity.


docs: add contributing

Add a contributing document to ease first-time contributors

Closed as I haven't seen it was already there.


New Plugin: AzulPatcher4600

This kext fixes a new issue (since 10.12.4) with the mobile HD4600 which, on some systems, causes the system to be unresponsive for an arbitrary timeframe after boot, as an added bonus this makes displays attached to HDMI initialize earlier because of the nature of the patch.
It also patches HDMI audio to work properly because it's sorta related.
Repo: https://github.com/coderobe/AzulPatcher4600

Hi, thanks for your research. We already have something for Intel HD graphics, perhaps it is best to keep things in one place?
Your patch does not have apple logo/pavp fixes, which still need to be applied, and IntelGraphicsFixup has no fixes you made. Might it be a better idea to merge all your changes into IntelGraphicsFixup, since it is larger/more general? Thanks!

I thought about it, but without additional hardware checks this wouldn't work out. This patch will most certainly only work on mobile haswells afaik. Some systems might even require a slightly modified version of the patch to work correctly, because of different connector topology.
So without a huge rewrite with proper HW checking & more tests on different hardware i really wouldn't want this to be in IntelGraphicsFixup for now.
This is a kind of niche patch in that sense.

I'm all for implementing more patches for different setups, but i'd have to come up with a way to reliably figure out the topology of the ports - automatically.

There is some example code on how to detect the hardware in AppleALC, could use it as a base? There also is mobile/desktop detector, but I think device-id should be enough.
As for HDMI fixes, maybe it is best to put them into AppleALC, after all it is designed for audio patches?
As for ports, I am unaware what happens there, but would not they be the same amongst one device-id?
Could temporarily add your work to the list though, so that people could find it until you make a better solution?

I will take a look at AppleALC's HW detection, thanks for the info.
I'm gonna look into submitting a PR to AppleALC regarding the HDMI fix as well - sounds like a great idea!
And the ports do not seem to be the same. It depends on how the laptop vendor connects them. The mobile hd4600 appears to have 3 ports, but most vendors connect 2 (internal display & 1 hdmi/dp port) and it's up to them on which to connect. This disables the DP port, which appears to be the least frequently used one, but it heavily depends on the laptop model - and i wouldn't know which vendor/model does what to cover even a small fraction of every haswell laptop out there 😉
In the end it's up to you whether to include this kext to the plugin list or not - it might be useful for people with this setup though, so why not?

Hmm, given this situation I feel that the best idea will be to add a boot argument to IntelGraphicsFixup to decide which port to patch. This way will be flexible, and we will not have to deal with extra code requirements. What do you think?


Invoice::hasStartingBalance() should account for a negative amount

Cashier Version: 8.0.1
Laravel Version: 5.7.28
PHP Version: 7.1.23
Database Driver & Version: MySQL v5.7.22

Description:
The Invoice::hasStartingBalance() method returns false if the user has a negative starting balance — I would expect that a negative starting balance is still a starting balance, and therefore should return true. Suggested fix is to change the following:
public function hasStartingBalance()
{
    return $this->rawStartingBalance() > 0;
}

to:
public function hasStartingBalance()
{
    return $this->rawStartingBalance() != 0;
}

Steps To Reproduce:
You would need to create a negative starting balance in Stripe; and then the description above is  self-explanatory.

Please fill out the issue template when posting issues.

Please fill out the issue template when posting issues.

Updated, thank you.

Starting balance in this case means at least some amount of money so a negative balance doesn't makes much sense here. What you want is a method to determine if the starting balance isn't zero. You can achieve this with your snippet above which you may do in your own code.
Is there a particularly reason/situation why you want this to be changed?

Thanks, that is what I am currently doing in the receipt.blade.php file to conditionally display the Starting Balance line item:
@if ($invoice->rawStartingBalance() != 0)

        Starting Balance

        {{ $invoice->startingBalance() }}

@endif

I suppose it's a matter of semantics, but I personally would think that if I asked if an invoice had a starting balance, the answer would be yes/true even if that balance was negative.
I'll just continue to use rawStartingBalance().
Thank you

Okay no worries. I think rawStartingBalance is twtg here and a custom check is in order. Good luck.


Fix example diff CI

What does this PR do?

Update the diff file for the text-generation example.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


MX8 Developer Portal updates (except App Store)

Rename of Modelers to Studios

Preparing Development for Mx 8


PR #141 broke Google2Client

It appears that merge caused Google Client to fail automated tests as well as production failures with the same error, so I can not update to the latest version of the production jar.
https://github.com/pac4j/pac4j/issues/141
maven test -Dtest=org.pac4j.oauth.client.Google2ClientIT
...
12:53:34.694 [main] DEBUG org.pac4j.core.client.ClientIT - callbackUrl : https://accounts.google.com/ChangePassword?continue=https%3A%2F%2Faccounts.google.com%2Fo%2Foauth2%2Fauth%3Fresponse_type%3Dcode%26scope%3Dprofile%2Bemail%26redirect_uri%3Dhttp%3A%2F%2Fwww.pac4j.org%2F%26state%3DwtmFjIylmN%26client_id%3D682158564078-ndcjc83kp5v7vudikqu1fudtkcs2odeb.apps.googleusercontent.com%26hl%3Den-US%26from_login%3D1%26as%3D1d94c92567336a52&service=lso&sarp=1&scc=1&checkedDomains=youtube&pstMsg=0
12:53:34.694 [main] DEBUG o.p.oauth.client.BaseOAuth20Client - sessionState : wtmFjIylmN / stateParameter : null
12:53:34.694 [main] ERROR o.p.oauth.client.BaseOAuth20Client - Missing state parameter : session expired or possible threat of cross-site request forgery
I haven't debugged this much, but it doesn't appear this was tested at all.  Part of the reason is the automated test in pac4j-oauth have what appears to be an infinite recursion problem, so the tests never go anywhere and have to be aborted manually.

You're right: there might be a regression. Integration tests simulate real authentication processes and maintaining them is really complicated. So they don't run by default.
There are also bench tests which take some time but don't output anything in my case because of this: https://github.com/pac4j/pac4j/blob/master/pac4j-core/src/test/resources/logback.xml#L23.
Maintaining pac4j and all *-pac4j libraries takes me a lot of time: any help will be appreciated.

Someone reported the same problem: https://groups.google.com/forum/?fromgroups#!topic/pac4j-users/40FhzXrK3Z8

I made a test using this demo: https://github.com/kristiankime/play-pac4j-heroku and it works.
Would you mind joining the thread on the mailing list or opening a new one with your logs (DEBUG on org.pac4j)?


Apply conversion for value that matches regex

I'm not sure if there's a way to do so currently.
I have a yaml file with some timestamps:
created_at: 2018-03-13 08:51:54.654332512 Z

Is there any way to have this value converted to Date?
Maybe applying a regex, for example? Would be very expensive to do so but still.

What you're looking for is the !!timestamp tag that's a part of YAML 1.1 schema, but not of the core YAML 1.2 schema. If you're okay with following the 1.1 version of the spec (there are differences), the easiest way to get a Date object out of your input is by specifying the schema:
const src = 'created_at: 2018-03-13 08:51:54.654332512 Z'
const obj = YAML.parse(src, { version: '1.1' })
obj.created_at instanceof Date === true

If you'd prefer to keep the 1.2 semantics and just add date handling with a custom tag, here's how to do that:
import { timestamp } from 'yaml/types/timestamp'

const src = 'created_at: 2018-03-13 08:51:54.654332512 Z'
const obj = YAML.parse(src, { tags: [timestamp] })
obj.created_at instanceof Date === true

Note that the latter API should be getting a bit simpler with the next release, but it's not quite ready yet.


Refactor bot.py a bit

Here's the main thing:

add HTTP 404 error checking (#2) to the $tutorial command. this doesn't address the other concerns about a more rich embed, nor does it address the possibility of spell-check/correction. I'd be willing to discuss those though

As I was working on the main thing, I got... a little sidetracked with these things:

[mostly] refactored for PEP8 compliance (there were various issues, mostly that lines were too long or there was odd spacing)
use f-string literals as specified in PEP498, instead of string concatenation (or even "{}".format(x) syntax!)
refactor duplicated code in on_message and on_message_edit... not sure how well this will work, but it certainly cleans up the code a little (willing to strip if it's broken). Needs testing

Note that I'm definitely willing to roll back the latter three changes if necessary (especially the last one)

not sure where that merge conflict came from?

$tutorial still doesn't 404 check under testing :pensive:

Now it works


livepeer in a box v3

Much better than before.

Closing in favor of https://github.com/livepeer/catalyst/pull/590


deeplog.predict() isnt forwading the input

When executing your example script, I always get the same top 3 predictions. Than I took a look into the torchtrain predict function (module.py) and there nothing gets forwarded through the trained network.

You just pass the batch to the torch constructor, which does nothing but initializing and then append this batch to the result without forwarding anything.
Maybe I understand something wrong, but I think this isn't working at all.

Ok but than I still dont quite understand why I get the same top 3 predictions, when running your hdfs_example.py on your HDFS datasets:

Do you have any idea?


[BEAM-1074] Set default-partitioner in SourceRDD.Unbounded.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

@jbonofre I tried simply setting the default partitioner in the first commit but it fails on some not-so-clear reasons...
My guess is that if a partitioner of type HashPartitioner has x partitions, it should match somehow the RDD's number of actual partitions.. but again, the failure is unclear.
Instead, I'm "padding" the RDD partitions (with empty Iterators where necessary).
This is the best way I could find to match the default-partitioner to avoid post-mapWithState shuffle, since passing a specific partitioner to mapWithState is "static" and won't change between microbatches (while the RDDs generated each interval could change, if cluster resources change for example).
Anyway, while I'm not yet certain about this solution, I thought I'd put it out there and get some feedback. Thanks!

After further testing, it seems as if the number of partitions in the (eventual) action of the first stage (where read happens), the number of partitions must match the number of partitions set in the HashPartitioner.
This solution seems valid enough, also tested in local-cluster (separate JVMs).
The "price" to pay here is having empty partitions in the first step, which shouldn't be too much anyway as it is bound by the number of source splits.

R: @jbonofre

@jbonofre pushed an improvement that is not directly related to this ticket but since this is still in review, I allowed myself to push.
The main improvement here is to counting the entire stream to report size, and sum "partition-size"s instead.
It's a separate commit so if this seems out-of-place to you I can cherry-pick this into a separate commit.

Closing for now, until we're sure how we want to do this.


fix legend of rectangles by using area instead of ybar

Currently, the following code
import matplotlib
matplotlib.use("agg")
import matplotlib.pyplot
import matplotlib.patches
import tikzplotlib

rectangle = matplotlib.patches.Rectangle(
    xy=(0.2, 0.2), width=0.1, height=0.3, label=r"thx\_nschloe"
)

fig, ax = matplotlib.pyplot.subplots()
ax.add_patch(rectangle)
tikzplotlib.save("/tmp/test.tex", standalone=True)

produces the following

See the weird legend?
With this fix, we now obtain the following

@nschloe this seems to break some tests. could you recommend a way to solve this without breaking the tests?

The tests are failing because the legends in some histogram/bar charts are changing to area legends. This is not what we want.

I understand. Modifying the style of the legends for every case of a rectangle is not what we want.
Do you think we can come up with an extra setting that controls the style of the legend of rectangle patches? Or do you believe that ybar should be used for all legends that involve a rectangle patch? I personally think this should not be the case.

In the case of patches -- your case -- I think it should look like you proposed. You'd have to find out via properties of the figure if it's a bar plot or not. I'm not sure how this is possible, but you can play around a little bit.

Ok, I will come up with a proposal soon!


Create an Issue template

Add templates for bug reports and for feature requests.

Done at the Organization level. To customize, create issue templates in the repo.
Closing.


Blurry output?

I used fluxgym to make a lora on my 3060 12GB, following all instructions, and keeping most defaults. I had 36 good images, 512x512, all captioned. The sample images during training look nice and sharp. But when I go to use the lora in Forge, it produces blurry noisy results every time. Why would the samples during training look ok, but then look blurry/noisy in Forge?

I've been using the Q8_0 GGUF version of Flux-dev most of the time, since it is fast and most similar to fp16. But I wondered if that might be the cause of the issue. So I switched to the NF4 version, and the images are much sharper. The fp8 version is also ok. Why would the 8-bit quant version of flux produce bad results with the lora?

I think I might have had "Diffusion in low bits" set at Automatic. I switched it to "Automatic (fp16 LoRA)" and that seems to have fixed it.


Make removes the repo from FS

What I do:

Git clone (my exact copy of benchmark repository):

git clone git@github.com:volodya-lombrozo/benchmark.git

cd benchmark

Run make:

make

I get the following logs:

set -e
base=before
mvn --activate-profiles "${base}" --update-snapshots clean package "-DfinalName=${base}" "-Ddirectory=${base}" \
		-Djeo.version=0.2.18 \
		-Deo.version=0.34.4 \
		-Dopeo.version=0.1.2 \
		-Dineo.version=0.1.6
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------< org.eolang:benchmark >------------------------
[INFO] Building benchmark 0.0.0
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- clean:3.2.0:clean (default-clean) @ benchmark ---
[INFO] Deleting /Users/lombrozo/Workspace/EOlang/benchmark
[INFO]
[INFO] --- resources:3.3.1:resources (default-resources) @ benchmark ---
[INFO] skip non existing resourceDirectory /Users/lombrozo/Workspace/EOlang/benchmark/src/main/resources
[INFO]
[INFO] --- compiler:3.11.0:compile (default-compile) @ benchmark ---
[INFO] No sources to compile
[INFO]
[INFO] --- resources:3.3.1:testResources (default-testResources) @ benchmark ---
[INFO] skip non existing resourceDirectory /Users/lombrozo/Workspace/EOlang/benchmark/src/test/resources
[INFO]
[INFO] --- compiler:3.11.0:testCompile (default-testCompile) @ benchmark ---
[INFO] No sources to compile
[INFO]
[INFO] --- surefire:3.1.2:test (default-test) @ benchmark ---
[INFO] No tests to run.
[INFO]
[INFO] --- jar:3.3.0:jar (default-jar) @ benchmark ---
[WARNING] JAR will be empty - no content was marked for inclusion!
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.900 s
[INFO] Finished at: 2024-01-23T11:05:56+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:3.3.0:jar (default-jar) on project benchmark: Error assembling JAR: /Users/lombrozo/Workspace/EOlang/benchmark/pom.xml isn't a file. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
make: *** [before.jar] Error 1

benchmark folder is removed and I have to repeat all the steps again

Make version:
benchmark git:(master) make --version
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i386-apple-darwin11.3.0

@yegor256 Could you help here?

Btw, I run brew upgrade make and got the following output:
Warning: make 4.4.1 already installed

But make --version is still:
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i386-apple-darwin11.3.0

Which is weird.
So I found out, that brew installs gmake. And using gmake (instead of make) works good.

@volodya-lombrozo so, with gmake all works as expected?

@volodya-lombrozo I added a check to Makefile: f47ffb3

@volodya-lombrozo in general, in order to make GNU bins (installed by Homebrew) available first, add this to your $PATH: /opt/homebrew/opt/make/libexec/gnubin
I have this in my ~/.profile:
export PATH="/opt/homebrew/opt/make/libexec/gnubin:$PATH"

@volodya-lombrozo so, with gmake all works as expected?

Yes

@yegor256 This solution didn't help me.

@volodya-lombrozo in general, in order to make GNU bins (installed by Homebrew) available first, add this to your $PATH: /opt/homebrew/opt/make/libexec/gnubin
I have this in my ~/.profile:
export PATH="/opt/homebrew/opt/make/libexec/gnubin:$PATH"

Ok, seems it is the problem with make version and I have to fix my environment. And for now I can just use gmake instead. Since you added the check I can close the issue. Thank you!


Remove MemberSelector

What does the pull request do?
As described in #2333:

MemberSelector was mainly added in order to support TabControl and since this was rewritten, MemberSelector should not strictly be needed. In addition, it has problems (#483) in some cases because it was written for a single specific use-case.

WPF and UWP have DisplayMemberPath which has subtly different semantics. We should look into replacing MemberSelector with DisplayMemberPath in order to gain greater compatibility.

This PR implements the first part of this, by removing MemberSelector. It does not however add DisplayMemberPath, but as described here, DisplayMemberPath is in effect just shorthand for a template for a single property. We need to decide if we want to add the complexity of DisplayMemberPath or just ask users to write a simple ItemTemplate.
Also added a TabStrip page to the control catalog to make sure that everything was still working with `TabStrip.
Breaking changes
Removes MemberSelector.
Fixed issues
Fixes #2333
Closes #483

For DisplayMemberPath we could reuse the PropertyPath work for compiled setters and compiled bindings.


Added more missing annotations to Typescript definition file

Changed ref argument to Component
Added defaultValue for inputs
Added context property to Component

LGTM but I've basically never used TypeScript.
Maybe @jrf0110 or @kruczy can confirm 😀


(c++) CMake improvemets

Added missing find_package calls to CMakeLists file. Also created separate library that can be exported/installed in future.

Thank you so much! I really appreciate this.


HOSTEDCP-1051 addition of grace period for aws infra destruction

What this PR does / why we need it:
Adds InfraGracePeriod timeout flag for deleting AWS infrastructure resources so that if something goes wrong with deleting the infrastructure resources, the deletion process is not stuck.
Which issue(s) this PR fixes
Fixes #
HOSTEDCP-1051
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/retest-required

/retest-required

Thanks! can you please squash commits and update the message to follow conventions in https://hypershift-docs.netlify.app/contribute/?

/lgtm
/approve

/retitle HOSTEDCP-1051: addition of grace period for aws infra destruction


CAMEL-10701 - Use proper classloader for loading authentication settings in Kafka

Looks good to me. I guess we need to merge on 2.18.x too.
@davsclaus what do you think?

Yeah sure +1

Thanks. The PR has been merged. Can you close this? :-)

Thanks for merging it !


When updating ThreadLocalRandom used the old sun.misc.Unsafe rather than jdk.internal.misc.Unsafe

And a change in build.xml that I guess it was just forgotten to revert maybe when reverting the other jdk17 stuff.

nope, build.xml is expected.  arch_x86 is needed to build on j8 on M1 Macs, and the rest are cleanups (optional); stuff like adding better error message when you run on a unsupported JDK

So I think this needs squash, rebase and final run

pushed latest changes

We need to test also that if jobs are added or changed, the generate.sh will pick them up from diff as others and they will be pushed in a loop in CI to check for flakies

now that the repeat jobs got deleted by default I don't know how to run them so I never run them anymore... how do you run it now?


ReferenceError: TestCafe is not defined

Are you requesting a feature or reporting a bug?
Reporting a bug.
What is the current behavior?
I install TestCafe in my project directory using:
npm install testcafe
Then I make a JS script in the same folder to start TestCafe:
var testCafe = require('testcafe');

var testCafe = new TestCafe({
    controlPanelPort: 8000,
    servicePort: 8080,
    testDir: 'tests'
});

Then I call this script using the following script (also in the same directory):
#!/bin/sh -eu
node run.js "$@"

I've also tried using this instead:
#!/bin/sh -eu
NODE_PATH=`realpath node_modules` node run.js "$@"

But both give me the following output:
/home/redacted/testcafe/node_modules/brotli/build/encode.js:3
ocess.on("uncaughtException",function(a){if(!(a instanceof y))throw a;});b.ins
                                                                    ^
ReferenceError: TestCafe is not defined
    at Object.<anonymous> (/home/redacted/testcafe/run.js:3:20)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:906:3

What is the expected behavior?
No errors, and I can proceed to expanding my script to run my tests.
How would you reproduce the current behavior (if this is a bug)?
Re-run the steps I mentioned.
Specify your

Debian Testing x64
0.12.0
v4.6.1

Hi @WillemMali,
It seems you have found this example in the documentation for the previous TestCafe version.
The new open-source TestCafe has different API (see documentation). In the Programming Interface article you can find how to use TestCafe from your Node.js modules.
Also there is a typo in your code for the previous version, it should be:
var TestCafe = require('testcafe');

var testCafe = new TestCafe({
    controlPanelPort: 8000,
    servicePort: 8080,
    testDir: 'tests'
});

Hi @AlexanderMoskovkin, thank you very much for the support! I wasn't aware that there were two sets of docs, neither of them indicate a version or that one is deprecated.
Shall I flesh out an issue for "Add deprecation/out-of-date notice to documentation on testcafe.devexpress.com", or would you consider that "pollution" of the open-source issue tracker? A one-word response will do fine.

I put it wrong in my previous post. testcafe.devexpress.com is a website dedicated to the paid version of TestCafe, not the previous one. So, the documentation at testcafe.devexpress.com is recent but it doesn't relate to the open-source TestCafe.


Example of choropleth legend

The closer legend we have for choropleth or color gradient maps is this example. But that is still kind of a "bullet point map". IMHO it would be very very useful to have a basic example building something like this:

@ramiroaznar going to close this on the VL side... I'm wondering if there are possibilities to do this with the data VL sends that is consumed by Airship legends (?). The other option is to modify the styling inside of your application.

Yes, maybe this is more an Airship issue/request. cc @ivanmalagon

as a note, putting in the gradient legend example that @elenatorro made.. maybe we can add this to the examples with some class breaks. i think offering a couple of other styles will be good..
https://bl.ocks.org/elenatorro/d642e6c9a81d9261e9cdc382f5ff1a5a

Yes, please!

Nice! We can add it at least as an example without Airship as Mamata suggests.

Just a comment here. If we are going to use buckets for the classification in those examples, it would be great if the legends (or 'colorbars') could reflect those buckets, as in this: https://gka.github.io/palettes/#colors=lightyellow,orange,deeppink,darkred|steps=7|bez=1|coL=1
The gradient mode could be incorrectly interpreted as "all color steps in the bar are used"

Yes, sorry about my initial enthusiasm. I think we should show discrete color values, not a gradient.

@VictorVelarde totally! thank you for pointing that out.
You bring up an excellent point. There are two versions:

Gradient with meaningful stops labeled for interpolation through color
A class-based legend with each class break colored and labeled (no gradient)

In Builder, we always did the gradient even though we didn't have maps other than classed so definitely take your point to avoid that pitfall!
Basically, I think the legends below, horizontal (modified to be a little more traditionally rectangular) with appropriate labeling:
Choropleth:
https://carto.com/developers/carto-vl/examples/#example-choropleth-legend
Unclassed choropleth (even though this is points not polygons so not really choropleth but unclassed):
https://carto.com/developers/carto-vl/examples/#example-unclassed-legend
That brings up the point too, that "choropleth" would be only for polygons. I can see times where you would want to use a similar style for points/lines, but we should think about those differently.
With regards to Airship, I did contribute a lot of information on a legends ticket. Could be good to look through to see what additional examples we could use (point and line classed map ideas in there)... one that comes to mind is point size, line size, etc. and the way @elenatorro and David set the legends up, we have them organized by geometry type and map type so we have a good foundation to build off of.
https://github.com/CartoDB/airship/issues/157


Color theme abruptly changes when editing an unrelated setting

Version: 1.64.0-insider (Universal)
Commit: 807bf598bea406dcb272a9fced54697986e87768
Date: 2021-12-20T05:14:16.036Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.1.0
Steps to Reproduce:

Make sure you don't have the default theme (my theme is GitHub Light)
Edit settings.json (I started typing remote)
See weird color theme switch which stays until I delete the half written setting.

This happened both in the extension host and the main VS Code instance.
My theme comes back once I successfully complete the half-written setting or I delete it.

The settings file becomes broken and no settings are applied. But I think there is something that is supposed to prevent the settings from being reloaded in this scenario.

JSON parser tries its best to provide a valid JSON in case the file is syntactically not correct. It seems, complete content below that half entered setting is not parsed and the theme setting seems to be below and hence the theme switches. Once setting got fixed everything becomes normal.
I would say this is like this from beginning and the behaviour is understood and expected. Hence closing this as designed


Multithreading/parallelize?

Hi,
Your software works great, but it is a little bit slow when searching for queries on google scholar. Is it possible to parallelize for example the search on the single pages?

Hi @Niemand112233,
Yes for the next version (as soon as I have time or new collaborators) I'll try to introduce multithreading(even though it's not the best thing of python) at least during the downloads so that the tool will continue searching while downloading papers.
There is also a random timeout 1-10sec after each request to Crossref (When you see on the prompt "Searching paper x of y on Crossref.."). I've put it as I think that it helps to not get blocked by crossref for API abuse. On the next version, I think I'll put this timeout optional

Yes of course, even if the gain is not maximum

Hi,
sorry for the late reply, but PyPaperBot had been on standby until now.
I've decided to resume development to improve it.
I've created a Telegram channel where you can suggest improvements, report bugs, or request custom data mining scripts. Feel free to join if you're interested with the following LINK
Thanks!


ENH: Suppress user warnings from BayesSearchCV.fit()

Coverage decreased (-0.3%) to 95.117% when pulling 7eb194c2b626784fd84dc3af0b16faf17f269a73 on enh/suppress-user-warnings into 0aa37004bdf4ffe78fb62bba5e124a9aa2ecb3b2 on main.


Zoom postition not accurate

there is small issue with the position for zoomed image can anyone give the solution

@Siddaramappa your parent element should be relative

if we don't have any top bar or nav bar in top it working fine... but the issue is if we place the navbar on top this issue is happening.. as you suggest i tried the parent element is relative but we getting same result...

@Siddaramappa are you using bootstrap?

yes i using  Bootstrap 4
For any further queries please leave us message. We’d love to chat.
Thanks & Regards
Siddaramappa N N | Sr. Front End Developer
Appnings Software Solutions Pvt Ltd
#4F, 4th Floor, Rich Homes, Richmond Road, Bangalore - 560025
L:<PHONE_NUMBER> | www.appnings.com
https://www.google.com/url?q=http://www.appnings.com&sa=D&source=hangouts&ust=1535616362761000&usg=AFQjCNFU5z9HiIgE8Kx117oGUdBQGEWe0g
On Tue, Jun 11, 2019 at 11:07 AM Raymond Cheng<EMAIL_ADDRESS>wrote:

@Siddaramappa https://github.com/Siddaramappa are you using bootstrap?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/akulubala/vue-product-zoomer/issues/33?email_source=notifications&email_token=AJ37QJW6365HM3ENIRZ4ZGDPZ423LA5CNFSM4HWRG3EKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXL7Y3Y#issuecomment-500694127,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ37QJVQ4EKXAHJH7OCI263PZ423LANCNFSM4HWRG3EA
.

Yes i using bootstrap 4

@Siddaramappa , there hava some issue with bootstrap grid system, I remeber its child div inherit parent position strategy. you can try to solve it by investigate from there.Or using other css framework like bluma.

okay thanks we try it out thank you so much!!


Parameter override: 'TypeError: Cannot read property 'type' of undefined', make sure it follows JavaScript Object Notation (JSON)

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question
Type: I want to override parameters but cannot get it to work. Could use some support.
Enter Task Name: AzureResourceGroupDeployment@2
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Taskshttps://github.com/microsoft/azure-pipelines-tasks/tree/master/Tasks/AzureResourceGroupDeploymentV2
Environment

Agent - Hosted (windows-latest)

Issue Description
- task: AzureResourceGroupDeployment@2
  displayName: Validate ADF Template
  inputs:
    azureSubscription: DataPlatform Deploy SP - Staging
    resourceGroupName: $(RESOURCE_GROUP)
    deploymentMode: Validation
    csmFile: $(Pipeline.Workspace)/DataFactory_ARM/ARMTemplateForFactory.json
    csmParametersFile: $(Pipeline.Workspace)/DataFactory_ARM/ARMTemplateParametersForFactory.json
    overrideParameters: -factoryName "$(DATAFACTORY_NAME)"
      -Storage_01_RCE_accountKey "$(cedl2-key1)"
      -Storage_02_Curated_accountKey "$(curdl2-key1)"
      -Storage_03_LandingZone_connectionString "$(lnzsa-conn-string)"
      -Storage_04_AzFunction_connectionString "$(funcsa-conn-string)"
      -CT-Reload-ST_properties_CT_Customers_reload_parameters_KafkaTopic "dapl-acc-ct-customers"
      -DW_Optimove-DE_properties_pl_demandware_dim_product_parameters_env "$(ENV)"
      -DW_Optimove-DE_properties_pl_demandware_dim_account_parameters_env "$(ENV)"
      -DW_Optimove-DE_properties_pl_demandware_fact_order_parameters_env "$(ENV)"
      -DW_Optimove-DE_properties_pl_demandware_dim_product_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-DE_properties_pl_demandware_dim_account_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-DE_properties_pl_demandware_fact_order_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-IT_properties_pl_demandware_dim_product_parameters_env "$(ENV)"
      -DW_Optimove-IT_properties_pl_demandware_dim_account_parameters_env "$(ENV)"
      -DW_Optimove-IT_properties_pl_demandware_fact_order_parameters_env "$(ENV)"
      -DW_Optimove-IT_properties_pl_demandware_dim_product_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-IT_properties_pl_demandware_dim_account_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-IT_properties_pl_demandware_fact_order_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-UK_properties_pl_demandware_dim_product_parameters_env "$(ENV)"
      -DW_Optimove-UK_properties_pl_demandware_dim_account_parameters_env "$(ENV)"
      -DW_Optimove-UK_properties_pl_demandware_fact_order_parameters_env "$(ENV)"
      -DW_Optimove-UK_properties_pl_demandware_dim_product_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-UK_properties_pl_demandware_dim_account_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-UK_properties_pl_demandware_fact_order_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-RU_properties_pl_demandware_dim_product_parameters_env "$(ENV)"
      -DW_Optimove-RU_properties_pl_demandware_dim_account_parameters_env "$(ENV)"
      -DW_Optimove-RU_properties_pl_demandware_fact_order_parameters_env "$(ENV)"
      -DW_Optimove-RU_properties_pl_demandware_dim_product_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-RU_properties_pl_demandware_dim_account_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-RU_properties_pl_demandware_fact_order_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-FR_properties_pl_demandware_dim_product_parameters_env "$(ENV)"
      -DW_Optimove-FR_properties_pl_demandware_dim_account_parameters_env "$(ENV)"
      -DW_Optimove-FR_properties_pl_demandware_fact_order_parameters_env "$(ENV)"
      -DW_Optimove-FR_properties_pl_demandware_dim_product_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-FR_properties_pl_demandware_dim_account_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-FR_properties_pl_demandware_fact_order_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-JP_properties_pl_demandware_dim_product_parameters_env "$(ENV)"
      -DW_Optimove-JP_properties_pl_demandware_dim_account_parameters_env "$(ENV)"
      -DW_Optimove-JP_properties_pl_demandware_fact_order_parameters_env "$(ENV)"
      -DW_Optimove-JP_properties_pl_demandware_dim_product_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-JP_properties_pl_demandware_dim_account_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-JP_properties_pl_demandware_fact_order_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-IE_properties_pl_demandware_dim_product_parameters_env "$(ENV)"
      -DW_Optimove-IE_properties_pl_demandware_dim_account_parameters_env "$(ENV)"
      -DW_Optimove-IE_properties_pl_demandware_fact_order_parameters_env "$(ENV)"
      -DW_Optimove-IE_properties_pl_demandware_dim_product_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-IE_properties_pl_demandware_dim_account_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-IE_properties_pl_demandware_fact_order_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-ES_properties_pl_demandware_dim_product_parameters_env "$(ENV)"
      -DW_Optimove-ES_properties_pl_demandware_dim_account_parameters_env "$(ENV)"
      -DW_Optimove-ES_properties_pl_demandware_fact_order_parameters_env "$(ENV)"
      -DW_Optimove-ES_properties_pl_demandware_dim_product_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-ES_properties_pl_demandware_dim_account_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -DW_Optimove-ES_properties_pl_demandware_fact_order_parameters_cluster_id "$(DATABRICKS_CLUSTERID_DEMANDWARE)"
      -OM-API-ETL-ST_properties_OM_reload_parameters_Env "acc"

$(ENV is set as stage variable:
ENV: acc
$(DATABRICKS_CLUSTERID_DEMANDWARE) is set as job variable
DATABRICKS_CLUSTERID_DEMANDWARE: 1234-123456-abcd123
Error logs
task.log
Troubleshooting
I have tried replacing "$(ENV)" with "acc" but. same error.
Also tried adding a single quote before the first -key and after the last -key.

Can anyone help me with this issue? @bishal-pdMSFT maybe?

Have not been able to fix it.. The team using the pipeline has removed the validation step to proceed.

Hi @bramvdklinkenberg Goede morgen :wink:
This morning I had the same problem. The issue with this error is that it is not obvious what is going on.
Your ARM file is parsed and the override parameters are applied to that file, that happens here
As you can see, it tries to cast the override parameter to the type defined in the parameters part of the ARM file. When that file doesn't contain the parameters, it doesn't know what to do with them and the error "cannot read property 'type' of undefined" is thrown. It would be more logical if it mentioned that the parameter is not found in the template :wink:
You can find this in your log file:
2021-01-28T11:24:16.1593514Z ##[error]Deployment template validation failed: 'The template parameters
(....)
in the parameters file are not valid; they are not present in the original template and can therefore not be provided at deployment time. The only supported parameters for this template are

there you see that all the parameters are not known.
In my case the problem was that the pipeline I was working on was setup in a different way than our other pipelines. The pipeline used the ARM template from a build and that was not triggered (I don't know why), usually we just checkout another git repository with the ARM template. The problem was that the ARM template used was an old one, the repository contained a newer version of the template, but the build didn't. Changing the pipeline to checkout the repository solved the issue.
Good luck 😄

Just in case this helps anyone...
I had a similar "error" but the deployment succeeded:
"There was an error while overriding 'EnvironmentName' parameter because of 'TypeError: Cannot read property 'type' of undefined', make sure it follows JavaScript Object Notation (JSON)"
My issue was that the casing of the parameter name in the yaml pipeline definition was different from the template i.e. EnvironmentName vs environmentName.
- task: AzureResourceGroupDeployment@2
  displayName: 'Deploy Infrastructure'
  inputs:
    azureSubscription: ...
    resourceGroupName: ...
    location: ...
    csmFile: '../ARM/azuredeploy.resources.json'
    overrideParameters: '-EnvironmentName $(environmentName)'


Question: How to persist keyboard on hardware KeyDownEvent Press?

Hi, Does BackHandler has any event listener I can add to KeyDownEvent Press? How should I persist keyboard on hardware KeyDown Press?

@gaearon help please?


Invalid Syntax

Hello, new to programming so please bare with me
I don't understand what is wrong here, but i have downloaded the code and installed the requirements but whenever i run any code from it, it states invalid syntax and this error.
File "instagram.py", line 30
browser_option.add_argument(f'user-agent={ua}')
^
SyntaxError: invalid syntax
Whenever I enter this, python instagram.py username

Hi!, Can you tell me what version of Python you're using and if you made any changes to script?


Add skipShade option

Add skipShade option, so that it is still activeByDefault, and can be turned off with -DskipShade or -DskipShade=true

In which scenario, you wanna skip this shade?

Codecov Report

Merging #5053 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5053      +/-   ##
============================================
+ Coverage     58.47%   58.49%   +0.01%
  Complexity       12       12
============================================
  Files          1182     1182
  Lines         63135    63167      +32
  Branches       9287     9294       +7
============================================
+ Hits          36921    36952      +31
- Misses        23502    23503       +1
  Partials       2712     2712

Impacted Files
Coverage Δ
Complexity Δ

...impl/dictionary/DoubleOnHeapMutableDictionary.java
47.56% <0%> (-19.52%)
0% <0%> (ø)

...elix/core/relocation/RealtimeSegmentRelocator.java
23.68% <0%> (-15.79%)
0% <0%> (ø)

.../impl/dictionary/FloatOnHeapMutableDictionary.java
64.63% <0%> (-12.2%)
0% <0%> (ø)

...mpl/dictionary/DoubleOffHeapMutableDictionary.java
45.16% <0%> (-10.76%)
0% <0%> (ø)

...org/apache/pinot/broker/queryquota/HitCounter.java
92.3% <0%> (-7.7%)
0% <0%> (ø)

...e/segment/index/readers/OnHeapFloatDictionary.java
94.73% <0%> (-5.27%)
0% <0%> (ø)

...config/instance/InstanceAssignmentConfigUtils.java
67.5% <0%> (-5%)
0% <0%> (ø)

...a/org/apache/pinot/common/config/TagNameUtils.java
82.75% <0%> (-3.45%)
0% <0%> (ø)

...e/operator/dociditerators/MVScanDocIdIterator.java
63.49% <0%> (-3.18%)
0% <0%> (ø)

...e/pinot/core/query/reduce/BrokerReduceService.java
89.09% <0%> (-2.12%)
0% <0%> (ø)

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 157f128...ace3e53. Read the comment docs.

In which scenario, you wanna skip this shade?

when we don't need to use/build/upload the fat jar


FutureWarning: split() requires a non-empty pattern match

hey, I'm getting this message when using lime. haven't dug in further but hopefully this gives a start.
potomac-api_1  | /usr/local/lib/python3.6/re.py:212: FutureWarning: split() requires a non-empty pattern match.
potomac-api_1  |   return _compile(pattern, flags).split(string, maxsplit)

thanks!

I don't remember why I put the '|$' in the split expression, it doesn't seem to do anything.

I'm a bit late to the party, but I found out the hard way that it does do something: it adds the split expression itself to as_list. When you split on whitespace, 'foo bar' becomes ['foo', ' ', 'bar'], if you split on comma's, 'foo,bar' becomes ['foo', ',', 'bar'], etc. Without '|$' it would simply become ['hello', 'world'].
Also, as it seems relevant, I noticed the python 3.7 changelog saying:

re.split() now supports splitting on a pattern like r'\b', '^$' or (?=-) that matches an empty string.

I haven't been able to check whether this warning is gone on 3.7 or not, but this suggests so.


Add support for Append only persistence

This adds a $VERSION-aof tag, which enables Append Only File persistence, in addition to RDB persistence.  The benefit here is that AOF will sync data to disk much more frequently, by default every 1 second,
This frequency can be changed in $CONFIG_EXTRA_FILE,  Redis supports three different modes for the appendfsync

no: don't fsync, just let the OS flush the data when it wants. Faster.
always: fsync after every write to the append only log. Slow, Safest.
everysec: fsync only one time every second. Compromise.

The current image tags and Enclave descriptions are:

Tag
description
default
visible
indexable

4.0
Redis 4.0
true
true
true

4.0-nordb
Redis 4.0 - NO PERSISTENCE
false
false
true

We intend to make this the default Redis database type, and update image descriptions (for all versions) as follows:

Tag
description
default
visible
indexable

4.0
Redis 4.0 - RDB Persistence
false
false
true

4.0-nordb
Redis 4.0 - NO PERSISTENCE
false
false
true

4.0-aof
REDIS 4.0
true
true
true

In case AOF corruption causes a database not to start (recovery throttled warning), it may be an AOF corruption issue. The Redis documentation recomends:
It is possible that the server crashes while writing the AOF file (this still should never lead to inconsistencies), corrupting the file in a way that is no longer loadable by Redis. When this happens you can fix this problem using the following procedure:

* Make a backup copy of your AOF file.
* Fix the original file using the redis-check-aof tool that ships with Redis:
    $ redis-check-aof --fix
* Optionally use diff -u to check what is the difference between two files.
* Restart the server with the fixed file.

I've simulated a possible corruption here for reference, the final diff I would recommend providing to the customer to say "this AOF record was corrupted and needed to be truncated(removed) to start your server, perhaps you can fix or account for it".
https://gist.github.com/UserNotFound/c8534eefb614e53dd4675622e6fc1e28

@thomas if the proposed image description and default setting is correct, i'll prepare a transaction to update this for all versions, for further review.

Thanks @krallin !

@UserNotFound what's our status here?

@UserNotFound as we discussed, please:

Merge this.
Once all images have built, register the AOF + RDB variants (and make them the default).


Docs: external link refactoring

Description
This PR refactor the documentation replacing external links with valid ones.
This avoids broken links or redirections.

Really, we had so many broken links?

Really, we had so many broken links?

No, the only broken link is https://docs.projectcalico.org/getting-started/kubernetes/flannel/flannel, the other ones are old links that redirect to newer ones.

/test

/merge


[EZPROX ] : (JS-0263) Detected the use of process.exit()

Description
The process.exit() method in Node.js is used to immediately stop the Node.js process and exit. This is a dangerous operation because it can occur in any method at any point in time, potentially stopping a Node.js application completely when an error occurs. For example:
Occurrences
There is 1 occurrence of this issue in the repository.
See all occurrences on DeepSource → app.deepsource.com/gh/dswan36/ezprox/issue/JS-0263/occurrences/

Bad Practice
process.exit(1);
process.exit(0);

Recommended
Process.exit();
var exit = process.exit;


fix(resolve): deep import resolvedId error

Description
fix #12997
rel #12461

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines.
[ ] Read the Pull Request Guidelines and follow the PR Title Convention.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy leaving a reference of why we are adding the extension to the original id here: https://github.com/vitejs/vite/pull/8348#issuecomment-1139103437
I was never sure if this was the right approach though, and it has continued to bring issues. We could merge this PR as a temporal patch if it fixes the issue at hand but we need to review how we handle externalization in a holistic way in the next minor or Vite 5. Hopefully removing the need for the current double resolve we nee to know if it should externalize in SSR.


backbone-assocations problem... that well, works but throws error

        UUID
        Device Type
        Enclave
        Hostname
        IP
        Status

tabledevices is a collection of Backbone Models.. of type device with association
    {
      type:Backbone.One,
      key:'connection',
      relatedModel: DeviceConnection
    },

So.. It renders the table, correctly.. and pulls the enclave from the associated connection.  YAY!
But, it also then crashes with the error in the console:
Uncaught Error: Unable to parse bindings.
Message: TypeError: Cannot read property 'enclave' of null;
Bindings value: text: connection().enclave

So it appears it can READ it.. but then fails on the association or something (this happens at render time)
Thoughts?

To note, if I do a kb.viewModel on a single device, and then do a template with connection().enclave it prints out the correct value, but does not through the error.
So it definitely seems to be isolated to collectionObservable

annnnnd i'm a dummy.
Don't forget your DEFAULT props on model objects!  backbone basics! ;)


Roles list & Add role

https://xd.adobe.com/view/411d4b53-b8fd-4cb6-77dd-d41a1dc50173-372c/

No add roles or detail pages.

add and detail created: https://xd.adobe.com/view/411d4b53-b8fd-4cb6-77dd-d41a1dc50173-372c/


Add Support for Tekton Pipeline v1 APIs

Changes

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[ ] Tested your changes locally (if this is a code change)
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

/hold

/test pull-tekton-results-build-tests

/test pull-tekton-results-unit-tests

/test pull-tekton-results-integration-tests

/test pull-tekton-results-build-tests

/test pull-tekton-results-build-tests

/test pull-tekton-results-build-tests

/test pull-tekton-results-build-tests

/test pull-tekton-results-build-tests

/test pull-tekton-results-build-tests

/test pull-tekton-results-build-tests

/test pull-tekton-results-unit-tests

/test pull-tekton-results-unit-tests

/test pull-tekton-results-integration-tests

/test pull-tekton-results-integration-tests

/test pull-tekton-results-integration-tests

e2e tests are passing locally.  I upgraded kind version to resolve this.

/test pull-tekton-results-unit-tests

/test pull-tekton-results-build-tests

/test pull-tekton-results-unit-tests

/test pull-tekton-results-build-tests

/test pull-tekton-results-build-tests

@avinal @enarha @vdemeester
Let's review and merge this.

@vdemeester @avinal @enarha Let's try to merge this.

/test pull-tekton-results-unit-tests

/test pull-tekton-results-build-tests

/test pull-tekton-results-go-coverage

/test pull-tekton-results-unit-tests

/test pull-tekton-results-integration-tests

/retest

/retest

/retest

/test pull-tekton-results-unit-tests

/test pull-tekton-results-unit-tests

/test pull-tekton-results-unit-tests

/lgtm


Add back ZTD calculation

This commit fixes an earlier bug that removed the ability to calculate conventional zenith delays when passed lat/lon files.
The code is still not optimized and takes a long time to run.
Fixes some related bugs in data types
Fixes some argument flag bugs (e.g. some args that specified whether to download the DEM)

@jlmaurer do you want to add in a unit test for this as well? could be a 1 point lon lat using the same data as before.

Hey @dbekaert that is a good idea; I will add one and push to this PR.

======================================================================

ERROR: test_makePoints3D_Cython_values (test_utilFcns.FcnTests)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/root/project/test/test_utilFcns.py", line 145, in test_makePoints3D_Cython_values

    with open('test_result_makePoints3D.pik', 'rb') as f:

FileNotFoundError: [Errno 2] No such file or directory: 'test_result_makePoints3D.pik'

======================================================================

ERROR: test_makePoints3D_Python_values (test_utilFcns.FcnTests)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/root/project/test/test_utilFcns.py", line 113, in test_makePoints3D_Python_values

    with open('test_result_makePoints3D.pik', 'rb') as f:

FileNotFoundError: [Errno 2] No such file or directory: 'test_result_makePoints3D.pik'

----------------------------------------------------------------------

Ran 17 tests in 0.256s

FAILED (errors=2)

Exited with code exit status 1

CircleCI received exit code 1

@dbekaert this should be ready to look over!

@dbekaert I can remove them, they were automatically generated with the files so I was wasn't sure if they were required.

i do not think they are needed.

@dbekaert Just pushed the update with xml files removed.


Highlighting events, remapping movements, custom time intervals

Splitted issue with #78 and #79
I was wondering if gcal events can be colored by their event color instead of the calendar color.
e.g. I have a calendar for my school schedule with individual events colored whereas Calendar.vim draws events to the Gcal color.
Also what option would have the bg of events filled instead of boxed?
As for remapping keys, instead of making changes in mapping.vim what would go in my .vimrc to remap {h,j,k,l}  to {j,k,l,;}?
Lastly I see that the time intervals of week/day view changes as per the window ratio. Is there a way to specifically set it so it always shows from 8am to midnight?

Sorry but please split this issue into the individual problems...

As for mappings, use the following settgins

augroup calendar-mappings
  autocmd!
  autocmd FileType calendar nmap j <Plug>(calendar_left)
  autocmd FileType calendar nmap k <Plug>(calendar_down)
  autocmd FileType calendar nmap l <Plug>(calendar_up)
  autocmd FileType calendar nmap ; <Plug>(calendar_right)
augroup END

That works, thank you and splitted to multiple issues.


Generate HTML5 console link

What are you trying to do and what's not working?
Command:
knife vsphere vm htmlconsole <vm_name> -f "Folder name with spaces"
Output:
http:........//link_to_console/
Question
Is there a way to generate a html5 console url from the console?
I saw this gist using rbvmomi:
https://gist.github.com/bthornto/bfce98039e845fa44e9b
Thanks,
Peter

Interesting idea. Most of the work seems to be in generating the token and thumbprint, otherwise you'd be able to get the other pieces out of show.
Do you have any interest in giving that a shot? Happy to help walk you through it if needed.

Can you help me through with it?

Of course! Fork this repo, have a look at the README in the "Developing" section in lib/chef/knife.
I'd start by copying https://github.com/chef-partners/knife-vsphere/blob/master/lib/chef/knife/vsphere_vm_show.rb to your own file -- by line 33 it has found the VM you asked for, so you can start from there. Have a look at the name of the file and the class name, and see how it name of the command you type is reflected in those. e.g. knife vsphere foo bar will be called vsphere_foo_bar.rb and be a class called VsphereFooBar.

I have created a script generating a console url. But, when I am not loggedin at vSphere with my browser. It shows the vCenter login page. Any idea how to get around it?

I thought the token was supposed to take care of that. Do you have some sample code I can try? I can run it by some of my contacts at VMWare.

Sure thing, it is:
# Author:: Peter Steenbergen<EMAIL_ADDRESS># License:: Apache License, Version 2.0

require 'chef/knife'
require 'chef/knife/base_vsphere_command'
require 'rbvmomi'
require 'netaddr'
require 'socket'
require 'openssl'
require 'digest/sha1'

class Chef::Knife::VsphereVmConsoleHtml < Chef::Knife::BaseVsphereCommand
  banner "knife vsphere vm console html VMNAME"

  common_options

  def get_thumbprint(vc)
    ssl_context = OpenSSL::SSL::SSLContext.new
    tcp_client = TCPSocket.new vc, 443
    ssl_client = OpenSSL::SSL::SSLSocket.new tcp_client, ssl_context
    ssl_client.connect
    certificate = ssl_client.peer_cert
    thumbprint = Digest::SHA1.hexdigest(certificate.to_der).upcase.scan(/../).join(':')
    thumbprint
  end

  def build_url(vm_host, vm_id, vm_name, server_guid, ticket, thumbprint, locale = 'nl_NL')
    url = "https://#{vm_host}:9443/vsphere-client/webconsole.html?vmId=#{vm_id}&vmName=#{vm_name}&serverGuid=#{server_guid}&locale=#{locale}&host=#{vm_host}:443&sessionTicket=#{ticket}&thumbprint=#{thumbprint}"
    url
  end

  def build_url_http(vm_host, vm_id, vm_name, server_guid, ticket, thumbprint, locale = 'nl_NL')
    url = "http://#{vm_host}:7331/console/?vmId=#{vm_id}&vmName=#{vm_name}&serverGuid=#{server_guid}&locale=#{locale}&host=#{vm_host}:443&sessionTicket=#{ticket}&thumbprint=#{thumbprint}"
    url
  end

  def build_url_https(vm_host, vm_id, vm_name, server_guid, ticket, thumbprint, locale = 'nl_NL')
    url = "https://#{vm_host}:7343/console/?vmId=#{vm_id}&vmName=#{vm_name}&serverGuid=#{server_guid}&locale=#{locale}&host=#{vm_host}:443&sessionTicket=#{ticket}&thumbprint=#{thumbprint}"
    url
  end

  def build_vmrc_url(vm_host, vm_id, vm_name, server_guid, ticket, thumbprint, locale = 'nl_NL')
    url = "vmrc://clone:#{ticket}@#{vm_host}:443/?moid=#{vm_id}"
    url
  end

  def connect(url)
    if RbConfig::CONFIG['host_os'] =~ /mswin|mingw|cygwin/
      system "start #{url}"
    elsif RbConfig::CONFIG['host_os'] =~ /darwin/
      system "open \"#{url}\""
    elsif RbConfig::CONFIG['host_os'] =~ /linux|bsd/
      system "xdg-open #{url}"
    end
  end

  def run
    $stdout.sync = true
    vmname = @name_args[0]
    if vmname.nil?
      show_usage
      fatal_exit('You must specify a virtual machine name')
    end

    vim_connection

    dc = datacenter
    folder = find_folder(get_config(:folder)) || dc.vmFolder

    vm = traverse_folders_for_vm(folder, vmname) || abort("VM #{vmname} not found")

    ticket = vim_connection.serviceContent.sessionManager.AcquireCloneTicket
    thumbprint = get_thumbprint(get_config(:vsphere_host))
    url = build_url_https(get_config(:vsphere_host), vm.summary.vm.to_s.split('"')[1], vmname, vim_connection.instanceUuid, ticket, thumbprint)

    connect(url)
    puts url
    sleep 60
  end
end

As you can see I tried multiple URLs for this. The VMRC link works, but then again you need additional software. We are trying to open an url to the console, with is once valid.

Do you have any idea's?

Hi Peter, I dropped the ball on this. Currently fighting some vcenter web problems of my own but will try this out ASAP.

def build_url_https(vm_host, vm_id, vm_name, server_guid, ticket, thumbprint, locale = 'nl_NL')
url = "https://#{vm_host}:7343/console/?vmId=#{vm_id}&vmName=#{vm_name}&serverGuid=#{server_guid}&locale=#{locale}&host=#{vm_host}:443&sessionTicket=#{ticket}&thumbprint=#{thumbprint}"
url
end
This one turned up to be working fine, as well as the vmrc_url method. Will clean it up a little and make a PR for it.


Error sending event to spawned machine in initial context

Description
Send an action after spawn a machine in the context result in an error: Unable to send event to child 'spawnedMachine' from service 'toggle'.
Expected Result
Send an action to the spawned machine
Actual Result
Error telling that isn't possible to send the event
Reproduction
https://codesandbox.io/s/lazy-spawn-forked-uxeux?file=/src/toggleMachine.ts
Press the Update Spawned Machine button

Verified to be working with the latest XState (4.25.0)


can no longer activate sollumz

Did you restart your blender after uninstalling the previous version and before installing the new one? That allowed me to do so.

yes sir.