Missing tests

In the context of testing I would like to talk about two things

Hitting Notion API to fetch block contents now to successfully run this tests we will be depending on notion API and need an API key and also the database has to follow a pattern which will be hard to test locally every time anyone clones the repo.
Secondly we are parsing the block JSON object and converting it into markdown flavored string, I think this is something we can test effectively and should mock the block data structure to do so.

I think we can do unit tests with jest or other testing framework and just mock the structure of notion blocks. In this way we can make sure that the output is as expected.

I'm not sure if that'll work as each method depends on the notion client SDK. So internally recursive API calls are being made to fetch the child blocks.
I guess we can create a dummy notion document and pass the auth token as an environment variable to the CI/CD. If someone wants to run locally then probably they have to provide theirs.

I've created a base jest infra in #17 we can expand it and create mocks to the notion client API easily with jest.


Update library function "docstrings" for nixdoc generation

Motivation for this change
This extracts the changes to documentation comments that previously were in #49275 into a new pull-request. These changes should be backportable to 18.09.
Please see the other PR for more discussion, background information and examples of rendered documentation.
Files covered:

lib/lists.nix
lib/strings.nix
lib/trivial.nix
lib/debug.nix
lib/options.nix

cc: @grahamc

Please open a backport pr with git cherry-pick -x these,commit,hashes to the release-18.09 branch


Add introduction to vscode and how to create and execute python scripts

should this be a standalone presentation or would you like it incorporated into the introductory lesson?

This should be a standalone presentation.  Probably in a different folder like "supplemental material"


testing: Creating sub-benchmark with b.Run means that parent will not show anything from b.ReportMetric

Go version
go version go1.21.6 darwin/arm64
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/Harald/Library/Caches/go-build'
GOENV='/Users/Harald/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/Harald/go/pkg/mod'
GONOPROXY='github.com/dietdoctor/*'
GONOSUMDB='github.com/dietdoctor/*'
GOOS='darwin'
GOPATH='/Users/Harald/go'
GOPRIVATE='github.com/dietdoctor/*'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/opt/homebrew/Cellar/go/1.21.6/libexec'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/opt/homebrew/Cellar/go/1.21.6/libexec/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.21.6'
GCCGO='gccgo'
AR='ar'
CC='cc'
CXX='c++'
CGO_ENABLED='1'
GOMOD='/Users/Harald/dd/hive/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/j2/0w9hqz1x01g3j4_yz0w0sw780000gp/T/go-build4150210059=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?
func BenchmarkTest(b *testing.B) {
	for _, name := range []string{"Test"} {
		b.Run(name, func(b *testing.B) {
			for _, subName := range []string{"Subtest"} {
				b.Run(subName, func(bb *testing.B) {
					bb.ReportMetric(100, "sub_test_metric")
				})
			}
			b.ReportMetric(200, "some_metric")
		})
	}
}

What did you see happen?
BenchmarkTest
BenchmarkTest/Test
BenchmarkTest/Test/Subtest
BenchmarkTest/Test/Subtest-8<PHONE_NUMBER>	         0.0000002 ns/op	       100.0 sub_test_metric
PASS

What did you expect to see?
I want to see some_metric be reported on the BenchmarkTest/Test benchmark.

CC @neild @adonovan

@aclements Was this effect an unexpected consequence of ResetTimer's clearing of the extra mapping, or was it intended, perhaps on the groups that b.Run has all kinds of performance effects that render the outer benchmark invalid as anything other than a container for subbenchmarks?

@adonovan Any updates on this? 🤗

When I looked at the benchmark code, I was under the impression that this was expected, since if a benchmark has subbenchmarks, then it itself is not a benchmark and thus reports no metrics at all.

@seankhliao It could be by design in the code. I got around it by not using sub-benchmarks at all.
But in that case, maybe it should be documented?  A benchmark that calls Run at least once will not be measured itself and will be called once with N=1.


Add GetTransactionsByBlockID and GetTransactionResultsByBlockID

Closes: #???
Description

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the standards mentioned here.
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Codecov Report

Merging #332 (37e11b8) into master (b25c7cc) will decrease coverage by 0.94%.
The diff coverage is 28.88%.

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   65.31%   64.37%   -0.95%
==========================================
  Files          21       21
  Lines        1975     2007      +32
==========================================
+ Hits         1290     1292       +2
- Misses        564      594      +30
  Partials      121      121

Flag
Coverage Δ

unittests
64.37% <28.88%> (-0.95%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

access/grpc/client.go
0.00% <0.00%> (ø)

access/grpc/grpc.go
74.90% <0.00%> (-8.66%)
:arrow_down:

access/http/client.go
79.74% <0.00%> (-2.08%)
:arrow_down:

address.go
91.04% <0.00%> (ø)

flow.go
50.00% <ø> (ø)

transaction.go
85.84% <ø> (ø)

access/grpc/convert.go
84.94% <100.00%> (+0.10%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add a "FETCH" option to the local branch context menu

Adding a "FETCH" option to the branch context menu would greatly enhance the user experience. Currently, when switching to a local branch different from the one in checkout, there's no option to synchronize with the remote. While the repository's FETCH command exists, it doesn't achieve this synchronization.
My suggestion is to include a "FETCH" command within the local repository's context menu. This would execute the FETCH command, effectively syncing the local branch with its remote counterpart. For example, if you're on the "develop" branch and notice two commits on the "master" branch, clicking on "master" and selecting "FETCH" would execute the following command, downloading the two commits and applying them to the "master" branch:
git fetch origin master:master

I've just submitted a pull request for this: #618

I've pushed my implementation of this feature. Compared to PR #618, there are the following differences:

Add a new constructor of Commands.Fetch, which means it has no impact on existing Fetch calls (we don't need to modify existing Fetch calls).
Fetch {REMOTE_BRANCH} into {LOCAL_BRANCH} will only be available when:

The selected local branch is not current branch, since we can use Pull {REMOTE_BRANCH} for current branch instead.
The selected local branch has an upstream.
The selected local branch is not a check-outed worktree, since git fetch modifies the index but does not update the worktree files - this operation will introduce a large number of staged changes on that worktree.
The selected local branch should not has ahead commits.


Different formats on valarm trigger duration, list available?

Hi,
i have a question about the different formats of trigger duration, do you have a list of all possible formats where from the different programs are used?
I have written a php valarm function to parse the valarm component, but now i am getting more and more different formats on duration.
Example for a day duration at the moment 3 different formats detected:
-P1D
-PT1D
-P1DT
it would be really awesome if you have a list where are all the possible duration formats are listed!

Just refer to the spec:
https://tools.ietf.org/html/rfc5545#section-3.3.6
vobject also comes with a parser:
https://github.com/fruux/sabre-vobject/blob/master/lib/DateTimeParser.php#L92


Merge next v2.0.3 into main

Merge next into main.
Details regarding the included changes are provided in the release notes and the CHANGELOG.

:tada: This PR is included in version 2.0.4-next.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


sql: performance difference between forward (ASC) and reverse scans (DESC)

Jesse Seldess (jseldess) commented:
Call out in SELECT as well as troubleshooting/SQL optmization docs.
See https://github.com/cockroachdb/cockroach/issues/13935#issuecomment-286895436 for details.

Also depends on the encoding - if keys are encoded in descending order, then a reverse scan is the better one (because on the kv level it turns once again into a forward one). I.e. going against the index direction is what's slow.

Yeah, just to second @tschottdorf, If the index is sorted in DESC order, then DESC SELECTs will be fast. It's just when the SELECT order doesn't match the index order that things are slower.

Thanks for the clarifications, @a-robinson and @tschottdorf.

I'm surprised reverse iteration is so much slower. Internally, RocksDB caches the decoded block the iterator is currently pointed at. So accessing the next or previous key should be about the same speed. But now I'm remember that MVCCIterate is a bit slower for reverse iteration though I can't recall why.

We have closed this issue because it is more than 3 years
old. If this issue is still relevant, please add a comment and reopen
the issue. Thank you for your contribution to CockroachDB docs!


multiple re-renders of sub-sections - updated results affect across the board, investigate

ok, there was a misplaced '/' on the url string that caused an additional componentWIllReceiveProps.
that is corrected. However, there are still double the amount of RESOLVED actions received for each fetch action. This could be an artifact of the createIndexedAsyncReducer?  see attached image

also prevent another update by checking pathname field in urlQueryString versus whole object

this is fixed


Version 3.4.0

Adding box_intact_types that allows preservation of selected object types (thanks to pwwang)
Adding limitations section to readme

Hello @cdgriffith! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file test/test_functional_box.py:

Line 703:80: E501 line too long (85 > 79 characters)
Line 820:80: E501 line too long (83 > 79 characters)
Line 824:80: E501 line too long (80 > 79 characters)

Coverage decreased (-0.8%) to 98.31% when pulling bf3516c85e3ee6bead09fda302f94ccbe1486407 on development into 86a11e162e63690a014235d07de04807dfa05b6c on master.


feat: add env for plugins

Discussed about this with @nerfZael and decided it would be nice if the dev experience of using env would be similar to wasm polytwrappers.

Discussed about this with @nerfZael and decided it would be nice if the dev experience of using env would be similar to wasm polytwrappers.

Opened the issue #603 for supporting separate resolvers and w3 per modules for plugins to support this.


docs: Replace obsolete Prisma adapter link

Closes #1346
✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[x] I performed a functional test on my final commit

Changelog
Change the link from https://next-auth.js.org/adapters/models/ to https://authjs.dev/reference/adapter/prisma/ in all current document translations.
💯

LGTM


🐛 [firebase_messaging] onBackgroundMessage is not getting called on iOS.

In iOS when the app is in the background

if we send a notification from the server then the notification is displayed but the onBackgroundMessageHandler is not called.
if we send a data message from the server then that is also not received as the onBackgroundMessageHandler is not called.

Below is the code to send the data message to the device.
function sendDueDateNotification(){
  // notification topic
  var topic = "due_date_12_11_2020";
  var type = "Due Date";
  var tag = "DUE_DATE";

  // message to send
  var message = {
    data: {
      tag: tag,
      topic: topic,
      type: type,
      title: 'O vencimento é amanhã!',
      body: 'Se já pagou, fique tranquilo(a).',
    },
    android: {
      ttl: 24*60*60*1000, // 1 day expiration (milliseconds)
      priority: 'normal',
    },
    apns: {
      payload: {
        aps: {
          contentAvailable: true,
        }
      },
      headers: {
        "apns-push-type": "background",
        "apns-priority": "5", // Must be `5` when `contentAvailable` is set to true.
        "apns-topic": "bundle_id", // bundle identifier,
      },
    },
    topic: topic
  };

  admin.messaging().send(message).then((response) => {
    // Response is a message ID string.
    console.log('Successfully sent message:', response);
  });
}

Here is the sample code where the above issues are reproducible https://github.com/deepak786/flutter_notifications_issue

For iOS; you must have a physical iOS device to receive messages.
Firebase Cloud Messaging integrates with the Apple Push Notification service (APNs), however APNs only works with real devices.
I've run it on the physical iOS device but still not working

Ofcourse I have tested it on real device.
That's why Im receiving the notifications. But the issue is onBackgroundHandler is not getting called.

@deepak786
There's similar open issue describing your case, ie, onBackgroundMessage is not invoked when app is in background, https://github.com/FirebaseExtended/flutterfire/issues/6290.
Please follow-up there for updates.
Closing this as duplicate. If you disagree, write in comments and I'll reopen it.


WordPress Check does not give Vulnerability info

The token has a daily limit.The issue is not valid.


distro

I'm going to manually merge this in since there is something wonky going on with the squahsed merges.

Coverage remained the same at 37.732% when pulling b3ef29008269312a4de868646003e4212318eaba on distro into 95617db0bde342f7b15ca47b49542fb0d176860f on release/1.21.


mpc-hc-fork: Update to <IP_ADDRESS>, fix checkver

Relates to Excavator unable to update due to reusing the releases tag for multiple further releases: https://github.com/ScoopInstaller/Extras/runs/6224966985?check_suite_focus=true#step:3:231

Similar method for checkver as https://github.com/ScoopInstaller/Extras/pull/8392

[x] I have read the Contributing Guide.

/verify


Implement VertexID system semantic

VertexID and a few other system values are actually already supported via ShaderBuiltins: https://github.com/mellinoe/ShaderGen/blob/master/src/ShaderGen.Primitives/ShaderBuiltins.cs#L88-L93
When you call one of those properties, extra variables are automatically injected into your method, and you don't need change your input signature. https://github.com/mellinoe/ShaderGen/blob/master/src/ShaderGen.Tests/TestAssets/BuiltInVariables.cs#L12-L13

Oops. The worst part is, I actually saw that when I was initially investigating ShaderGen, and then completely forgot about it (and apparently didn't search for it).


chore: Upgrade Storybook to v4

Closes IBM/carbon-components-react#1496
This upgrades storybook to v4. Webpack & babel upgrades, theming, along with a new, backward-compatible parameters API.
Changelog
New

@storybook/addon-links (this was registered in addons.js but never added as a dependency)
@babel-loader necessary for backward-compatible babel 6 stuff.

Changed

Updated all of the @storybook deps to 4.0.0

Thanks for doing this! Will take a look tomorrow to make sure we're good to merge in 🎉

Thank you for doing this @vpicone! One question - Is knobs in <Button> working at your end? Just quickly fiddling with this PR and haven't been able to see non-primary buttons, so wanted to make sure I'm not missing anything. Happy to see new stuffs in Storybook BTW!

@asudoh No, you're right they changed how select works for knobs. I'll dig in to this.

ugh yarn.lock merge conflicts?

On the plus side, it looks like the update to addon-info fixes the 'multiple named import' issue that took the descriptions away.

Hey @vpicone! For yarn merge conflicts, just pull down the changes and re-run yarn. It will resolve them automatically 😄

Passing stories directly into withInfo() is deprecated, so I'm gonna swap it out in favor of the info option and then we should be good to go.

Let us know when you're ready for us to review btw @vpicone!

@joshblack Should be good to go now. Switched everything off the deprecated withInfo syntax.

Thank you for the updates @vpicone! Things seems to work very well except that CARBON_REACT_STORYBOOK_USE_EXTERNAL_CSS=true (ref) seems broken due to Webpack4 move associated with Storybook4 move. Some search tells me that extract-text-webpack-plugin has to be replaced with mini-css-extract-plugin, like below. Could you please try CARBON_REACT_STORYBOOK_USE_EXTERNAL_CSS=true and ensure it works? Thanks!
diff --git a/.storybook/addons.js b/.storybook/addons.js
index 5837958..139bbfe 100644
--- a/.storybook/addons.js
+++ b/.storybook/addons.js
@@ -1,7 +1,7 @@
 import '@storybook/addon-actions/register';
 import '@storybook/addon-knobs/register';
 import '@storybook/addon-links/register';
-import 'storybook-addon-a11y/register';
+import '@storybook/addon-a11y/register';
 import '@storybook/addon-options/register';
 import 'storybook-readme/register';
 import '@storybook/addon-storysource/register';
diff --git a/.storybook/webpack.config.js b/.storybook/webpack.config.js
index 7d67d05..a634c6d 100644
--- a/.storybook/webpack.config.js
+++ b/.storybook/webpack.config.js
@@ -1,5 +1,6 @@
 const path = require('path');
 const ExtractTextPlugin = require('extract-text-webpack-plugin');
+const MiniCssExtractPlugin = require('mini-css-extract-plugin');

 const useExperimentalFeatures =
   process.env.CARBON_USE_EXPERIMENTAL_FEATURES === 'true';
@@ -88,17 +89,16 @@ module.exports = {
         test: /\.scss$/,
         use: !useExternalCss
           ? [{ loader: 'style-loader' }, ...styleLoaders]
-          : ExtractTextPlugin.extract({
-              use: styleLoaders,
-            }),
+          : [{ loader: MiniCssExtractPlugin.loader }, ...styleLoaders],
       },
     ],
   },
   plugins: !useExternalCss
     ? []
     : [
-        new ExtractTextPlugin({
-          filename: '[name].[contenthash].css',
+        new MiniCssExtractPlugin({
+          filename: '[name].css',
+          chunkFilename: '[id].css',
         }),
       ],
 };
diff --git a/package.json b/package.json
index 0411d97..42b64e1 100644
--- a/package.json
+++ b/package.json
@@ -155,6 +155,7 @@
     "@babel/plugin-transform-object-assign": "^7.0.0",
     "@babel/preset-env": "^7.1.0",
     "@babel/preset-react": "^7.0.0",
+    "@storybook/addon-a11y": "^4.0.0",
     "@storybook/addon-actions": "^4.0.0",
     "@storybook/addon-info": "^4.0.0",
     "@storybook/addon-knobs": "^4.0.0",
@@ -192,6 +193,7 @@
     "jest-circus": "^23.6.0",
     "lcov2badge": "^0.1.0",
     "lint-staged": "^7.3.0",
+    "mini-css-extract-plugin": "^0.4.4",
     "node-sass": "4.9.2",
     "object-assign": "^4.1.1",
     "postcss-loader": "^3.0.0",
@@ -212,7 +214,6 @@
     "rollup-plugin-uglify": "^3.0.0",
     "sass-loader": "^7.1.0",
     "semantic-release": "^15.0.0",
-    "storybook-addon-a11y": "^3.1.9",
     "storybook-readme": "^4.0.2",
     "string-replace-loader": "^2.1.0",
     "validate-commit-msg": "^2.10.1",

There were a few things that required web pack as a peer dependancy. It got installed eventually as a regular dependency of storybook but installing it as a regular dependency gets rid of a few of those errors.

@vpicone I saw a similar error - Which seems to have caused by WebPack3 installation still being there by old version of Storybook a11y add-on installation. Upgrading that add-on fixed the issue for me, though your solution is fine for now.

@asudoh I could be wrong, but I think the loader needs it as a peer dependency at the same level rather than as a dependency of some other peer. Without installing it I get a lot of peer deps warnings.

@vpicone Great point, I see at least one dependency having webpack as a peer dependency. Thank you for articulating where your earlier comment came from!

Had to revert this PR. Tried several, including rewinding back to @vpicone's original code, but no luck as of now. Need further investigation - One possibility is that v4 move was too soon. @vpicone Sorry for this and great if you have any ideas - Thanks!

Oh no! Sorry we didn't catch this during review. Is this related to the change from extract-text-webpack-plugin?

Hmm weird! everything in the custom web pack config looks correct. Sorry I didn't include the static generation in my testing. I'll definitely be more aware of that next time.

Also https://github.com/storybooks/storybook/issues/4645 could be related. I think you were right about jumping the gun @asudoh might have to wait for the dust to settle about.
I was having so much fun with theming too haha.

@asudoh Hey just wanted to make sure this branch didn't actually get released haha. Carbon-bot might just be overzealous.

@vpicone I think this commit was included alongside the revert commit so technically it was included, but the effect was not 😅

@vpicone @joshblack I think you both got the point - The code was not released. The code won't affect the NPM release either because the stuffs are not in files list.


Plot and style option name clashes

The new .options method relies on unique names for plot and style options. At least in one case that is currently not true, namely the width option on Bars is both a plot options (controlling the width of the plot) and a style option (setting the width of the bars). We need to validate that these do not clash, and in the case of width rename the width style option to bar_width.

I hope this is the only example of a clash we find.

There's a few more, but it's not too bad:
from itertools import combinations

def option_intersections(backend):
    options = hv.Store.options(backend)
    for k, opts in options.items():
        if len(k) > 1: continue
        eltype = k[0]
        valid_options = {k: set(o.allowed_keywords)
                         for k, o in opts.groups.items()}
        for g1, g2 in combinations(['plot', 'style', 'norm'], 2):
            intersection = valid_options[g1] & valid_options[g2]
            if intersection:
                print('%s element %s and %s %s backend options intersect on: %s'
                      % (eltype, g1, g2, backend, intersection))

for backend in hv.Store.renderers:
    option_intersections(backend)

Bars element plot and style bokeh backend options intersect on: {'width'}
BoxWhisker element plot and style bokeh backend options intersect on: {'width'}
Arrow element plot and style matplotlib backend options intersect on: {'fontsize'}
Text element plot and style matplotlib backend options intersect on: {'fontsize'}
Curve element plot and style plotly backend options intersect on: {'width'}
ErrorBars element plot and style plotly backend options intersect on: {'width'}

Maybe for Arrow it could be called textsize. Not sure about all the others though.

Bokeh Bars: width -> bar_width
Bokeh BoxWhisker: width -> box_width
Matplotlib Arrow: fontsize -> textsize
Matplotlib Text: fontsize -> textsize
Plotly Curve/ErrorBars: delete width as a style option

Those suggestions seem reasonable enough. The problem then is retaining the old names (and therefore the clashes) for backwards compatibility...

Okay, I've come up with a plan for this, I'm going to make sure that plot options take precedence over style options in the expand_options method, since those are more common. For now we will leave the clashing style options registered, which means that they can still be set using opts or the magic but I will also register the new non-clashing names as aliases. Eventually we can deprecate the clashing options.

Matplotlib Arrow: fontsize -> textsize
Matplotlib Text: fontsize -> textsize

These two were actually never used since the element defines that parameter.

I'd consider those options deprecated immediately; deprecated just means "don't use in new code", right?  So as soon as we know they shouldn't be in new code, shouldn't they be deprecated?

So as soon as we know they shouldn't be in new code, shouldn't they be deprecated?

True, I wasn't sure whether to add warning, but I suppose we should.

Whether to add a warning is a different matter than deprecating them.  I'd say the thing to do immediately is to mark them deprecated in the release notes.  Then in the following release, there can be a warning.

I'd say the thing to do immediately is to mark them deprecated in the release notes. Then in the following release, there can be a warning.

Sounds good.


DOM is not updating after mouse click event

Blazor Web assembly --> package : z.Blazor.Diagram

@if(ShowComponent){
//Load table
}
@code{
public bool ShowComponent { get; set; }
diagram.MouseClick += MouseClickEvent;
private void MouseClickEvent(Model sender,MouseEventArgs e)
{
ShowComponent=true;
}
}
mouse click event is working and showcomponent property is setting to true, but this property change is not render on DOM, any variables inside the mouseclick is not render on DOM.
What is the wrong in this code, please let me know

Hi, try adding InvokeAsync(StateHasChanged); after ShowComponent=true;.


Fix #100

Permit built-in (C implemented) methods and functions to be used as
event callbacks. Given that prototype introspection is not available for
such routines, assume that they take no (mandatory) parameters.

Why are built-in functions not seen to be callable?

@lurch D'oh - absolutely correct - I'll fix that in a mo

Built-ins do register as callable, but you can't inspect their parameter
prototype which is why the existing code failed. The new code assumes that
built in callables have no mandatory parameters
On 4 Nov 2015 3:10 p.m., "Ben Nuttall"<EMAIL_ADDRESS>wrote:

Merged #102 https://github.com/RPi-Distro/python-gpiozero/pull/102.
—
Reply to this email directly or view it on GitHub
https://github.com/RPi-Distro/python-gpiozero/pull/102#event-454571480.

Just out of curiosity - is that a "known issue" and something that might potentially get fixed in a future Python3 version?

Not going to happen as far as I can see. In order to introspect the prototype of the function, the inspect module needs to be able to query the metadata of the function. For Python functions, that's easy enough - it just looks up co_argcount et al in the function's object. But these things don't exist for builtin/external C functions (in either Python 2 or 3).
When builtin/external modules register themselves with Python they just pass in a load of PyModuleDef structures (one for each module-level function). Note that there's nowhere in that structure for specifying the names (or even number) of parameters of the function call. Instead, the external implementation is called with a tuple and optional dict of args and is expected to unpack them in its implementation (presumably using PyArg_ParseTuple or PyArg_ParseTupleAndKeywords although there's no absolute requirement for it to do so).
So, the argspec of the function is effectively within the implementation of the builtin/external function. There's no way to get at it without disassembling the function's implementation (and even if that were feasible there's no guarantee you'd even find a simple call to PyArg_ParseTuple or PyArg_ParseTupleAndKeywords).
Basically, it's by design (presumably for speed and efficiency which is largely the point of builtin/external functions) so I doubt there's an impetus to fix it.
As it is, I don't think there's any great problem with the kludge I've used here (the assumption that any external function used as a callback takes no mandatory parameters). The only parameter we would pass is a gpiozero object; given gpiozero is relatively new we can reasonably assume no builtin/external implementations currently use or rely upon being passed a gpiozero object (in any circumstance). We can also reasonably assume there are plenty of builtin/external functions which take no (mandatory) parameters (like pygame.mixer.Sound.play) which would be of use as callbacks.
This does impose the burden that any external implementations wishing to work with gpiozero in future need to ensure their callbacks take no mandatory parameters, but given it's trivial to wrap an external implementation in a Python function in order to pass a parameter I don't think that's an excessive cost.


OBS Studio manifest should point to obsproject/obs-studio

Pretty self-explanatory. The manifest itself is at https://github.com/obsproject/obs-studio/blob/master/CI/flatpak/com.obsproject.Studio.json.

We're waiting for https://github.com/obsproject/obs-studio/pull/8233/files to ship, will close this for now, as we have nothing more to do.


react-datetime dependency throwing error in @storybook/addon-knobs

See bug:
https://github.com/storybooks/storybook/issues/4135#issuecomment-419584105

React-datetime has been removed from that repo, so I think we can close this. Sorry for the delay in replying.


[Android] v0.22.5 doesn't compile with RN 0.33

Compilation fails (both dev and release) for version 0.22.5, with error: cannot find symbol import com.facebook.react.bridge.BaseActivityEventListener:
/Users/david/...../node_modules/react-native-image-picker/android/src/main/java/com/imagepicker/ImagePickerActivityEventListener.java:6: error: cannot find symbol
import com.facebook.react.bridge.BaseActivityEventListener;
                                ^
  symbol:   class BaseActivityEventListener
  location: package com.facebook.react.bridge
/Users/david/...../node_modules/react-native-image-picker/android/src/main/java/com/imagepicker/ImagePickerActivityEventListener.java:10: error: cannot find symbol
public class ImagePickerActivityEventListener extends BaseActivityEventListener {
                                                      ^
  symbol: class BaseActivityEventListener
/Users/david/...../node_modules/react-native-image-picker/android/src/main/java/com/imagepicker/ImagePickerActivityEventListener.java:15: error: incompatible types: ImagePickerActivityEventListener cannot be converted to ActivityEventListener
        reactContext.addActivityEventListener(this);

Hard to believe...I was just working on this yesterday. Don't forget to npm install and run a gradle sync again.

Your example works indeed, will try to find why it fails in my project and let you know.

A few things to check:

In the project build.gradle, make sure the allProjects declaration looks like this:

A few things to check:

In the project build.gradle, make sure the allProjects declaration looks like this:

A few things to check:

In the project build.gradle, make sure the allprojects declaration looks like this:

allprojects {
    repositories {
        mavenLocal()
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
    }
}

In the app build.gradle, ensure react-native is compiled like this:

compile "com.facebook.react:react-native:+"  // From node_modules

And for good measure, run ./gradlew clean inside the android/ directory.

Thanks @marcshilling !
Indeed, I had a build.gradle from an older react-native version, with url "$projectDir/../../node_modules/react-native/android".
I changed it and now it works perfectly.
Thank you for your quick response.

Hi! I have the same problem, but I couldnt fixed, please @hirviid could you be more specific?

Hi @mcatmos, I created a new project with react-native init tempProject and compared the android specific files with my project (initially created with RN 0.27.2). For me, changing url in android/build.gradle to "$rootDir/../node_modules/react-native/android" fixed it.

Hi! I changed to "$rootDir/../node_modules/react-native/android" but still the same problem. I'm with RN 0.26.2

i met this issue a week ago,so sad

@liuliangsir2016 your code is incorrect. Your build.gradle url needs to be exactly url "$rootDir/../node_modules/react-native/android". Then run clean and build.

@marcshilling thx,it works

Today I learned you can't do this:
android/build.gradle
allprojects {
    repositories {
        mavenLocal()
        jcenter()
        maven {
          url "$rootDir/../node_modules/react-native/android"
          url 'https://github.com/500px/500px-android-blur/raw/master/releases/'
        }
    }
}

gotta split up the maven stuff (I didn't even know what maven was)
allprojects {
    repositories {
        mavenLocal()
        jcenter()
        maven {
          url "$rootDir/../node_modules/react-native/android"
        }
        maven {
          url 'https://github.com/500px/500px-android-blur/raw/master/releases/'
        }
  }
}


decl_storage decl_... not valid anymore

decl_storage decl_... not valid anymore, please update:
https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/blob/source/docs/tutorials/add-a-pallet/configure-a-pallet.md
We can find e.g. :
"Because it uses the decl_storage! macro." or "Because it uses the decl_event! macro"
But when we look at "Nicks pallet"
https://github.com/paritytech/substrate/blob/master/frame/nicks/src/lib.rs
it uses:
#[pallet::storage] etc.

These are actually backwards compatible. If you look at master on substrate, there are many using FRAME V1 macros like this. I agree, everything should move to V2 ASAP. #1075 fixes the mismatched style 😁


Add Code path support to the project

If the projects is not configured with code coverage we should add the setting. We should also run the script to upload coverage to Scope for Code Path functionality

Closed by #7


No error when login doesn't works on iOS

When trying to login to an invalid url (invalid publickey or so), nothing happen when touching the emoji on the app. An error reporting would be nice, even for user to know something is wrong and for developer to know what's wrong :p

User will now receive a bit more information, thanks!


Unable to read from /dev/ptmx

Hey!
With this simple test program:
package main

import (
	"log"

	"github.com/scrapli/scrapligo/driver/options"
	"github.com/scrapli/scrapligo/platform"
)

func main() {
	p, err := platform.NewPlatform(
		"nokia_srl", "<IP_ADDRESS>",
		options.WithAuthNoStrictKey(),
		options.WithAuthUsername("admin"),
		options.WithAuthPassword("NokiaSrl1!"),
		options.WithPort(57401),
	)
	if err != nil {
		log.Fatalf("NewPlatform() error:\n%+v", err)
	}
	d, err := p.GetNetworkDriver()
	if err != nil {
		log.Fatalf("GetNetworkDriver() error:\n%+v", err)
	}
	err = d.Open()
	if err != nil {
		log.Fatalf("Open() error:\n%+v", err)
	}
	defer d.Close()
	r, err := d.SendCommand("show version")
	if err != nil {
		log.Fatalf("SendCommand(show version) error:\n%+v", err)
	}
	log.Printf(
		"sent command '%s', output received (SendCommand):\n %s",
		r.Input,
		r.Result,
	)
}

And a Docker container with SRLinux running and 57401 mapped to 22. I get:
 00:10 ❱ go run main.go
2024/01/07 00:10:54 Open() error:
read /dev/ptmx: input/output error
exit status 1

SSH works fine:
 00:11 ❱ ssh<EMAIL_ADDRESS>-p 57401 "show version"
<EMAIL_ADDRESS>password:
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Hostname             : e8a4de3b8e0a
Chassis Type         : 7220 IXR-D3L
Part Number          : Sim Part No.
Serial Number        : Sim Serial No.
System HW MAC Address: 6A:03:02:FF:00:00
Software Version     : v23.7.1
Build Number         : 163-gd408df6a0c
Architecture         : x86_64
Last Booted          : 2024-01-06T22:19:59.338Z
Total Memory         : 64214175 kB
Free Memory          : 52309761 kB
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Hey there!
This popped up once before here I believe -- short fix is to use standard transport (go crypto vs subprocess wrapper). Otherwise can probably mess with passing some other ssh flags to see (thinking -t or maybe its -T or two of them... can't recall off the top of my head!) to mess w/ pty things.
Would standard transport be ok fix for now?

Or maybe there is some more reading things for future me to look at when I have some more time :) stuff like this and maybe this

I have tried to enable logging to debug more and discovered that I don't get a password when running the SSH command manually:

Switching to standard transport works.

can you see if adding -tt to your ssh command feels better? here is where that was sticking in my head from, wonder if its relevant?

Switching to standard transport works

ok cool. crappy "fix", but better than nothing :)

Received disconnect from <IP_ADDRESS> port 57401:2: Too many authentication failures

too many auth failures feels bad, does that happen every time? wonder if the ssh server is just upset at something we're doing?

In fact, because of -F /dev/null, this removes my IdentitiesOnly yes I am using to workaround problems like this, where some SSH servers do not like to receive too many key attempts. I have 14 keys in my agent. I would suggest to add this option to avoid using the SSH keys inside the agent without an explicit mention?

we always use /dev/null for config unless you tell it not to -- you can pass an explicit config or have it lookup default config file paths with these options! that should sort that out for ya I think ya?

yeah I now as well having too many keys in my agent and got burnt by this as well

Would it be OK to unconditionally add -o IdentitiesOnly=true before the configuration file?

I don't recall from the top of my head but I'd say more appropriate would be to set this ssh client option when we define the options for the platform

yeah I think hope that these two options here should give ya what you need to tune things to whatever is best for your environment. let us know if that works ok?

I had a brief look at it, and when we use the StandardTransport then you shouldn't have any issues with agent bombing the server with many keys, so this should be all good and also solving your problem with ptx mystique.


Installer crashes

Installer crashes on Extract: root.img
installer.log

I re-wiped my partitions and re-did the install and it worked this time.


manim-slides: Init at v5.0.0

Description of changes
This adds Manim-slides, a tool used for live presentations using manim, fixing #251914.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Does this not work? Why's it in draft status?

Opened up alternative PR using pdm and also exposing as a python package for to use ipython magics #298198
feel free to use as reference
It works well enough. I don't want to be a maintainer of this, but I did want to tinker

Looks good, thanks!


Drop support for .mdb files in Mono

Debugging F# applications in Visual Studio for Mac works better now with portable pdb files than it does with .mdb files (even for purely Mono apps, not just dotnet core).
The mono runtime and mono debugger supports ppdb really well. All that is needed currently is a targets file tweak.
Development on .mdb has ceased completely now and C# switched over to using portable pdb files only a few months back.
I propose that I patch the Mono MSBuild targets to switch <DebugType>full</DebugType> over to <DebugType>portable</DebugType> now (this is what C# on Mono currently does as Roslyn has no awareness of .mdb files)
Maybe we should remove .mdb support from the F# compiler completely at some point in the future?

@nosami So the Mono C# compiler took a breaking change where MDB files are no longer produced?
Yes, if so then we can do the same thing, and people just have to take the pain I suppose, or use a previous version of F#
Please submit a PR?

@nosami PR can go to here (for full CI testing) or to Microsoft/visualfsharp (for root integration in to targets etc.)

The Mono C# compiler hasn't been used for some time now, it's all Roslyn.
I'll create a PR. I just want to spend a bit of time dogfooding first :)

@nosami OK, thanks
What I mean is that after this change, a build that expects a "mdb" file to be produced (e.g. for a nuget package) will fail, right?
Anyway, I'll wait for the PR(s) and we can discuss

What I mean is that after this change, a build that expects a "mdb" file to be produced (e.g. for a nuget package) will fail, right?

Yes, that would fail. Not sure how common that is though, I only ever see Windows old-style pdb files.
Mono will use whatever it finds in the output folder, either ppdb or mdb.

OK.  You can also put the portable debug information in the DLL itself, right?

I believe that works ok, but haven't tried it.

Portable pdb debugging will likely be the default in Mono 5.4 but there will be a switch to change it back to .mdb if for some reason it doesn't work. Will wait and see what the reaction is like.


v3: GET notification endpoint

User Story - Business Need
The v3 POST sms/email endpoints require a new v3 GET notification endpoint to properly handle notification validation failures. Work in ticket #1512 create a new table to store notification validation failures; now we want to create a new GET v3/notifications/{notification-id} endpoint to retrieve the notifications that succeed (data returned from existing notifications table) and that failed (data returned from new notifications failure table).

[ ] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)
As a  VANotify engineer
I want  to create a new v3 GET notification route
So that notification failures are properly handled, without returning 500 Internal Server Errors
As a  VANotify client
I want  the option to use the new v3 GET notification route
So that to understand why my notification might failed
Additional Info and Resources

Engineering Checklist

[ ] create GET v3/notifications/{notification-id} endpoint
[ ] This route should first try to retrieve data from the existing notification table and, if the id is not there, retrieve data from the new notifications failure table
[ ] The data is returned in the GET route as expected, including a valid status and status_reason
[ ] Update Swagger
[ ] Update Postman

Acceptance Criteria

[ ] When I send a v3 email or sms with the wrong template type, and I call his new GET route, then I get back all the expected fields with a status of permanent-failure and a reason that informs me I used the wrong template type
[ ] When I send a v3 email or sms with a non-existent template_id, and I call this new GET route, then I get back all the expected fields with a status of permanent-failure and a reason that informs me that the template id could not be found
[ ] When I use the v2 route to GET a notification id that has failed validation, I can expect a 404 Not Found instead of a 500 Internal Server Error
[ ] Fields returned for v3 GET requests should match v2

QA Considerations

[ ] Regression passes
[ ] Manually test the above
[ ] Postman is accurate
[ ] Swagger is accurate
[ ] Either automate or create ticket for automation

Hey team! Please add your planning poker estimate with Zenhub @babyjunior56 @cris-oddball @EvanParish @k-macmillan @kalbfled @ldraney @nikolai-efimov

We need first to fix #1501 so we can create e-mail notifications to GET.

Will re-address with va-enp-api.


Help running with Geth

I'm running the docker instance.
I can see it runs with Parity.
I'm trying the same with Geth, but couldn't find anything on the documentation. Can you please help me ?
Ideally I would like to have the command line docker run command, and the config json changes
Thanks in advance

@emartinezagra you need to enable JSON RPC on geth, and point to it with APP_NODE_URL. Although I can confirm I have problems with geth, but didn't try parity.


dirchooser crash when click browser button

dirchooser crash when click browser button, it's strange because old version works well, it happend just after i update the packages, info. of the issue:

OS - both win7x64 and win10x64
Python Version - both 3.5.4 and 3.6.4
Gooey Version - 1.0.0
code:   mygroup.add_argument('--dir_name', widget="DirChooser", default='.', help='...')
the same codes works well in "old" version (don't remember version)

Thanks! ^_^

I'm unable to reproduce. Could you provide code that demonstrates the issue as well as the stacktrace you're seeing?
Thanks!

thanks for your reply!
the code is simple, it works on old version of gooey.
also i already see the GUI with both filechooser and dirchooser,
filechooser browser button works but dirchooser not,
i can only image it maybe because it's caused by i installed some other packages like
https://github.com/tschoonj/GTK-for-Windows-Runtime-Environment-Installer/releases
(i installed both gtk2 and gtk3) maybe that's the reason, even still problem after i uninstall them

maybe not uninstall cleanly. ..

Could you provide the code, even if it is 'simple' ? It helps debugging quite a bit ^_^ Also, any stack trace or error that pops out after crashing would be super useful. Without an error, it's a bit of a shot in the dark as to what could be causing the problem.


DO NOT MERGE: CMS-9 Geolocation and language selection

Codecov Report

Merging #110 into master will decrease coverage by 0.14%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage    94.3%   94.15%   -0.15%
==========================================
  Files          22       23       +1
  Lines         509      565      +56
==========================================
+ Hits          480      532      +52
- Misses         29       33       +4

Impacted Files
Coverage Δ

invest/templatetags/language_tags.py
100% <100%> (ø)

invest/helpers.py
95.12% <92%> (-4.88%)
:arrow_down:

invest/middleware.py
91.11% <94.73%> (+0.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee86117...4cf10df. Read the comment docs.


Bump default nozzle version to 1.4.0

Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
SSIA
Motivation
What inspired you to submit this pull request?
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
Anything else we should know when reviewing?

Closing this. Will open a new PR for the re-versioned nozzle.


[DOC-2981] HCE versus Litmuschaos

Signed-off-by: Smriti S<EMAIL_ADDRESS>

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Would be great to get the review from @umamukkara  on this.

@umamukkara - please review

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


README:  Outdated link

Link for 'pkg-config package' takes you to a 404 page.

Yeah. No clue how to use properly use it.


Dragging on chart does not interact well with swipe refresh and swipe to go back

One good option to start would be to not allow these gestures to start when the drag is started on top of a chart.

https://github.com/xh/hoist-react/blob/00b62ee70f820734f9e0118006687fd0963c9fe2/mobile/cmp/navigator/impl/swipe/Swiper.js#L141


Minimally fix the known unsoundness in bevy_mikktspace

Objective

0.8 is coming soon, and our mikktspace implementation is unsound - see https://github.com/gltf-rs/mikktspace/issues/26
Best not to ship that

Solution

Fix the unsoundness in a minimal way
Obviously there might be others, but it seems unlikely we have any way to know about those

bors r+

bors retry

bors retry

two previous CI failures are due to lack of disk space on windows


[Swift] Code checker script fails correct code and might confuse new students.

In the Swift / Exercises / Lasagna layer track, on line 50, 55, and 60 of the LasagnaTests.swift file the code is written as follows:
XCTAssertEqual(totalTimeInMinutes(elapsedMinutes: placeholder, layers: placeholder), placeholder)
The issue that I have with this code, is that it is explicitly checks that the totalTimeInMinutes function is passed the argumentlabels in the order of:
layers: elapsedMinutes
The issue with this order, is that this will falsely fail code in which the arguments are passed in a different order like
elapsedMinutes: layers
While this may not seem like a big issue this could be a major issue for new students as in the exercise the previous function's variables are defined in the order of elapsedMinutes: then layers:
So consequently new students may want to pass the arguments to the final function in this order, which sadly would fail students who had just completed the code correctly.
Also I would like to state that it is never explicitly stated on the website which order to pass the arguments, so this is more of a design issue than a user miss interpreting something.
Also I don't care how small of an edge case this may seem, it is important. Code incorrectly throwing errors is a major issue, especially if it could hinder students. Please don't ignore this as a complaint and actually fix the issue by check for both instances.

Hi!
So, if you work in the online editor, you will see the test file after you run the tests. This means that you should be able to solve the exercise only by what is given to you from the instructions and introduction to the concept.
And an example of the function being called is provided in the order:
## 4. Calculate the total working time in minutes

Define the function `totalTimeInMinutes(layers:elapsedMinutes:)` that takes two arguments: the `layers` parameter is the number of layers you added to the lasagna, and the `elapsedMinutes` parameter is the number of minutes the lasagna has been in the oven.
The function should return the total number of minutes you've worked on cooking the lasagna, which is the sum of the preparation time in minutes and the time the lasagna has spent in the oven at the moment.

```swift
totalTimeInMinutes(layers: 3, elapsedMinutes: 20)
// Returns 26
```

As well does the Swift compiler tell you if you put the arguments in the wrong order:

But if you want me to flip the order of the arguments, I have no problem doing that, but I think that is the extent to which the tests should be changed.

Most other tracks (Python, Ruby, etc) feature the same order as the Swift tracks, but Swift will throw a compile error if you use the wrong order. Personally, I think that is better since it tells the student exactly what is wrong with their solution. Compile errors are often a lot nicer than run-time errors.

This has been resolved from a thread on discord.
Issue can be closed now.


Allow dynamic actions to be matched with permit_action

Fixing https://github.com/punditcommunity/pundit-matchers/issues/101
3.0.0 broke the permit_action matcher for policies with dynamic actions. Here's an attempt to bring back the pre-3.0.0 behaviour.

@tagliala anything I can do on my end to make the CI run pass?

Run bundle and commit Gemfile.lock which will contain the new gem version number.

Sorry folks, it's impossible to resolve the last conversation because I force pushed my branch and the relevant commit is now out of reach.

Thank you @tagliala @chrisalley for the guidance/help!


Add Thanks

Thanks to @BendingBender, @orblivion, @rnhmjoj, @dundarious, and @vyings!

$(...) strips trailing linefeeds, concerning when scripts embed raw binary content at the end of file

This is more an issue for non-binary content like scripts, where trailing linefeeds are far more common, and variable in number.


why serde_json::value::to_value(&10i64).is_u64() == true ?

serde_json::value::to_value(&10i64) should be Value::I64 instead of Value::U64

Probably because it doesn't have a sign

There's no way for serde_json to distinguish between i64 and u64, mainly because json does not have signs. Maybe Value should be changed to have a single Numeric variant, which inside contains an object that can be converted to various target types.

Thank you for the information.
@oli-obk Agree. Value should only use F64 variant. Because f64 can convert to other numeric types without losing precision.

You will loose precision for large integer values, so thats a nogo. I meant to create an inner ttype that has accessor methods giving options when the conversion was successful

The confusing behavior comes from here:
fn serialize_i64(&mut self, value: i64) -> Result<(), Error> {
    if value < 0 {
        self.value = Value::I64(value);
    } else {
        self.value = Value::U64(value as u64);
    }
    Ok(())
}

What if we remove the check and always treat i64 as i64? This is a breaking change so I am tentatively scheduling this for 0.9.0.

I fixed this (sort of) in #188 by clarifying the meaning of is_u64. As we know, JSON does not distinguish between signed and unsigned numbers. The new Value uses an opaque Number type which is a JSON number but is not guaranteed to be any particular Rust number type.
pub enum Value {
    Null,
    Bool(bool),
    Number(Number),
    String(String),
    Array(Vec<Value>),
    Object(Map<String, Value>),
}

The is_u64 method is commented:
/// Returns true if the `Value` is a number that can be represented by u64.

So to_value(10i64).is_u64() is true as before but to_value(-10i64).is_u64() is false because -10 cannot be represented as u64. I think this is the right balance of practical to use while still respecting the vaguery of JSON.


Bubble chart label's offset

OS: Mac OSX
OS Version: 10.10.3
Browser: Chrome
Browser Version: 43.0.2357.132 (64-bit)
Bubble chart currently does not provide the visually optimized offset for labels:

If you look at how labels are set in our printable version, you can get a better picture of it:

Good feedback :+1: We should improve the initial positioning of labels

@IncoCode i've been experimenting with using force layout for that purpose a while ago =)
I got it disapproved by @olarosling back then, and i see you have the same issues in #486. i merged and then i had to revert it #488
some of the issues i found after a quick look:

when a label appears, other labels should not jump or move, because that distracts. Action should only happen when the data implies so
when playing, labels should follow bubbles without adjusting their positions (it's ok if they overlap)
when trails are off, labels follow the bubbles, when trails are on, labels follow the earliest visible bubble
it should be possible to manually replace the label, then manual placement is relative. that means labels still follow their bubbles or the earliest trail bubble when manually replaced
labels should not go off screen, they clip to the edge instead
preferably, the labels should not obscure the bubbles

my own comment:

The initial position of a label can be top left, top right, bottom left and bottom right, with different offset. Here you can contribute! Take median of the bubbles Xs and Ys. Put the new label to the right if your bubble is to the right from the X median, top if it's above Y median, and so on...


Test Class with annotation @RunWith(Parameterized::class) not being picked up in Firebase Test Run after upgrading from v4x to v21x

Describe the bug

A clear and concise description of what the bug is.

We have a few test classes which are being annotated by @RunWith(Parameterized::class) After upgrading from v4 to v21 of Flank Test Runner we observed the test which is paramterized is not being picked up and run in FTL
To Reproduce

Steps to reproduce the behavior:

Upgrade from Flank v4 to v21
Create a basic test class without Parameterized class
Create a test class with @RunWith(Parameterized::class) and import import org.junit.runners.Parameterized
Run both tests in Firebase

Expected behavior

A clear and concise description of what you expected to happen.

Observe only the none Parameterized class gets picked up and run in FTL
Details (please complete the following information):

Have you tested on the latest Flank snapshot?
Post the output of  flank --version.

Additional context

Add any other context about the problem here.

Works fine with v4 but not with v21

Please check https://github.com/Flank/flank/blob/master/docs/test_sharding.md#parameterized-tests

@shawnshaligram Do you have any additional questions about the https://github.com/Flank/flank/blob/master/docs/test_sharding.md#parameterized-tests or the issue itself? If not we will close this issue after few days.


feat: exporter plugin system

Description
We need the ability for us to add functionality to export data by aether dynamically, it amekes sense to cerate a plugin systems for this so that other users can extend aether as they see fit. Looking at the two options we have:

dynamic linking
RPC Based

The Dynamic Linking option is part of Go's standard library, while the RPC Based approach would be using Hashicorps go-plugins library
There is quite a lot of details of the cons around using Gos plugin systems, mostly:

You need to match the versions of the plugin with the application
There needs to be the same GOPATH
You cannot build static Binaries

The RPC methods cons are:

Added Network calls

We should do some looking into what this would look like

I think one big issue i've found is that if we do RPC, plugins will not be able to listen to the bus.
We could have a subscriber on the bus that pushes data to each of the plugins that have been registered :thinking:

Another issue I forsee is that using the RPC method, its very difficult to dynamicly load plugins. We would essentially need to iterate over a directory and start a async process that runs that plugin :thinking:


Add ability to Write to GCP PubSub with an orderingKey

There was a prior email dev thread about PubSub ordering key[1] but that was in reference to reads. It should be possible to support pubsub Write with ordering key. We might be able to have users supply a serializable function to extra the ordering key from each message, for example?

[1]<EMAIL_ADDRESS>Imported from Jira BEAM-13148. Original Jira may contain additional context.
Reported by: egalpin.

Any updates on this? Python api has this but Java api lacks it. Can't it be prioritised?

@egalpin may have context

Yes publishing messages with an ordering key is now supported in the Java SDK as well, added by https://github.com/apache/beam/pull/22216. I believe this should be included in SDK v2.43.0 and higher.
Using ordering key is supported by employing PubsubIO.writeMessages[1], where messages will need to be instantiated using the appropriate constructor[2] that accepts ordering keys. It’s also worth noting that pubsub write can make use of regional endpoints[3], which might be required for your use case to fully ensure ordering.
[1] https://beam.apache.org/releases/javadoc/2.43.0/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.html#writeMessages--
[2] https://beam.apache.org/releases/javadoc/2.43.0/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessage.html
[3] https://beam.apache.org/releases/javadoc/2.43.0/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.Write.html#withPubsubRootUrl-java.lang.String-

Interesting, I used 2.43 with the appropriate constructor that takes messageId and orderingKey but no messageId and orderingKey was in Pubsub. I am using dataflow runner.
Could it be related to #23525 ?

Note that, as far as I understand, any messageId set on a pubsub message to be published will be dropped before being published. This is because message IDs are assigned on the server side of pubsub (again, this is my own understanding and may not be factual)

I used PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder on the PCollection of Pubsub messages but still messageId(I don't care it) and orderingKey is null.
I used it as follows:
results.setCoder(new PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder())
                .apply("Write Result updates to PubSub", PubsubIO.writeMessages().to(options.getLitResultTopic()));

Am I not using it correctly?

This is indeed correct usage, and I was under the impression that this should work. Based on what you're saying/seeing, I'm suspicious that the coder might not be propagated through the PubsubIO/write code path.  I'll try to trace the code to confirm and/or validate behaviour as well.
@codertimu you could try to set the default coder for the pubsub message class[1] to see if that will unblock you:
PipelineOptions options = PipelineOptionsFactory.create();
Pipeline p = Pipeline.create(options);

CoderRegistry cr = p.getCoderRegistry();
cr.registerCoder(PubsubMessage.class, PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder.class);

[1] https://beam.apache.org/documentation/programming-guide/#setting-default-coder

@egalpin registerCoder does not exist. Do you mean like this:
cr.registerCoderForClass(PubsubMessage.class, new PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder());

Tried above and this:
cr.registerCoderForType(TypeDescriptor.of(PubsubMessage.class), new PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder());

but nothing changed.

Thanks for confirming.  I haven't yet had time to trace/validate.  One other option you could try depending on your level of comfort would be to modify the beam source and vendor in the pubsubIO module.  I noted my steps for doing so, specifically with dataflow, previously:  https://lists.apache.org/thread/c6929ms0bjxtcw9ho4tdb5y3t8wnwnfy.  This is not a long-term solution, but rather would be a stopgap solution until the same change can be made in the official SDK as per https://github.com/apache/beam/issues/23525.  Given that setting the coder on the PCollection appears to be insufficient, the priority of https://github.com/apache/beam/issues/23525 is increased in my opinion.
You'd want to modify the PubsubCoderProviderRegistrar[1] such that the PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder appears first in the list (or as the sole list element), then follow the vendoring steps mentioned.
[1] https://github.com/apache/beam/blob/9a22bf68767b8fa27aa381d6ff84e381a21af5a4/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubCoderProviderRegistrar.java

@codertimu can you confirm whether your pipeline is bounded or unbounded? It may help me trace

It is unbounded but I was using the test pipeline for the last few examples I tried here. I didn't attempt to run in dataflow.

@egalpin just to clarify, in my test pipeline, PubsubIO is not involved at all. Even in simple ptransform, the orderingkey and messageid are not preserved in the pcollection.

thanks @codertimu , I can reproduce the issue of lost orderingKey locally as well using something like this:
        pipeline.apply(
            Create.of(
                new PubsubMessage(
                    "{\"baz\": \"jazz\"}".getBytes(StandardCharsets.UTF_8),
                    Collections.singletonMap("foo", "bar"),
                    null,
                    "1")))
        .setCoder(PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder.of());

        ...

Attaching a debugger and stepping through, I can see that the Coder in Create is  PubsubMessageWithAttributesCoder (the first element in the PubsubCoderProviderRegistrar).
This obviously needs to be fixed, and I believe will be fixed by altering the registrar to use PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder as default (i.e. fixing https://github.com/apache/beam/issues/23525), but if you're able to could you verify if this behaviour persists with any runner which is not the test runner?

I confirm that the issue persists with the dataflow runner as well.

@codertimu @egalpin is this issue still of interest to you?
I believe #31608 fixes it. Feel free to review!


Use scopes & trigger "best guess" docblock from anywhere

Currently DocBlockr parses the content after the cursor and uses regular expressions to extract the appropriate content for the docblock.
For example, most parsers use \\((?P<args>.*)\\) to extract a function arguments which means edge cases fail.
class x
{
    /**|
    public function functionName($a, $b) { return new ClassName(); }

}

\\((?P<args>.*)\\) matches something like $a, $b) { return new ClassName( which is obviously wrong, but the only way to parse these edge cases correctly is with recursive regular expression.
One possible solution is to use syntax scopes, which are recursive, to extract function names and arguments.
All syntaxes should be similar enough to use this method of extraction, and those that are not should be fixed.
public function functionName($a, $b) { return new ClassName(); }
                ^^^^^^^^^^^^ source.php meta.function.php  entity.name.function.php
                             ^^^^^^ source.php meta.function.php  meta.function.arguments.php

All syntaxes should be able to match the function name with meta.function entity.name.function and the arguments with meta.function meta.function.arguments.
What could be really good, and I have a very ugly custom macro that does this, is to trigger a docblock from anywhere inside, before or anywhere near the function declaration.
1  class x
2  {
3      public function a()
4      {
5
6      }
7
8
9
10
11
12    public function b()
13    {
14
15
16
17
18
19    }
20 }

When the cursor is on any line 7-19:

the whitespace on lines 7-11 is removed (could be optional)
and a docblock to triggered for function b on line 12

If lines 14-18 contained actual code then the docblock that gets triggered might be something else e.g. a variable. However, a specific keybinding for a function docblock would always do the above.
When on line 6-3:

a dockblock is triggered for function a

The current context is key to what docblock is triggered.
The above is possible because docblockr moves either forward or backwards based on the current context looking for a syntax scope function declaration or variable or class, etc. and does some best guess work to figure out what the intention might be. Most of the time it's unambiguous, though I'm sure there will be edge cases in which case do nothing or prompt with the options.
It's a lot of work and requires some significant changes.
Feedback, suggestions, questions?

DoxyDoxygen, an alternative to this great plugin, use non regexp parser. Perhaps you may be interested in it.
Here a possible result of your example using future 0.8.4 version (please note that php support is poor compared to others languages)
class x
{
    /*----------------------------------------------------------------------*//**
     * { description }
     *
     * @param      <type>  $a
     * @param      <type>  $b
     *
     * @return     <type>
     */
    public function functionName($a, $b) { return new ClassName(); }
}

In my approach, I haven't choose to use directly tmLanguage:

hard to test
hard to extend (tmLanguage have to cover all languages aspect).
not exactly similar. For example, in Python, inside a function body "meta.function" is unset
hard to parse body (even if I not parse PHP body for now ;) ).
...

Your second suggestion is really interesting...
I just implement it in DoxyDoxygen and it will be available in the next release of this package (0.8.4+).
You don't speak about key mapping. In my package, I will probably map this function on Alt+Q (my current key to reparse / wrap comment).
Thanks again for this suggestion and if you test DoxyDoxygen, feedbacks are welcomed.

A feedback, if you decide to implement in DocBlockR:

the main problem is to detect the insertion point
tmLanguage have really strange behaviour (example in c++: fn() is a "meta.function", fn/**/() not)
as expected, new way of writing comments is really pleasant


Harukanaru Toki no Naka de Ultimate [PCSG01157]

App summary

App name: Harukanaru Toki no Naka de Ultimate
App serial: PCSG01157
App version: 1.0

Vita3K summary

Version: v0.1.5
Build number: 2647
Commit hash: https://github.com/vita3k/vita3k/commit/d2e99945
CPU backend: Dynamic

Test environment summary

Tested by: othmanead
OS: Windows 11
CPU: Intel i5-10300H
GPU: RTX 3060 mobile
RAM: 16 GB

Issue:

Game displays a black screen and crashes after

Screenshots:

Log
vita3k.log
Recommended labels

Bootable
Crash

can now go to menu as of https://github.com/Vita3K/Vita3K/commit/5c3754e3aedd7a0310164d8b91a5ccee8a771b17. refused to go to new game because it had a problem accessing files.
Screenshots

Log
vita3k.log
Recommended Labels

Menu
io error?

@GamingDucking Did you select はじめから？

haven't, but will test it tomorrow if i can


Fix legacy export wins migration flaky test.

Description of change
This fixes a flaky test where expected win adviser would not always be matched.
Checklist

[x] Has this branch been rebased on top of the current main branch?

Explanation
The branch should not be stale or have conflicts at the time reviews are requested.

[x] Is the CircleCI build passing?

General points

Other things to check

Make sure fixtures/test_data.yaml is maintained when updating models
Consider the admin site when making changes to models
Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.39%. Comparing base (49d6ce9) to head (db1edc4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5446      +/-   ##
==========================================
- Coverage   96.41%   96.39%   -0.02%
==========================================
  Files         947      947
  Lines       22451    22451
  Branches     2018     2018
==========================================
- Hits        21646    21642       -4
- Misses        657      659       +2
- Partials      148      150       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove redundant example of optional vs default.

Change Summary
Remove redundant example of optional vs default.
Rename the examples in the table to have distinct names.
Related issue number
I see this as a trivial fix.
Checklist

[ ] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review


Cargo build script - build PA as a static lib + Linux support

This PR contains a squash of #37 plus my own changes to make it play nicely with Linux's pkg-config.
This downloads and builds portaudio as a static library (unless it is found on the system via pkg-config), taking care to use pkg-config on linux to pick up extra dependencies (such as libasound).
I tested this on Ubuntu 14.04 and Fedora 21. OS X was reportedly working fine on #37, but it would be great if someone could test it again to make sure I didn't break anything :)
Fixes #33

Hey thanks for this PR!
This seems to be really cool stuff, I will check on OS X as soon as I can !

@jeremyletang ping :)

@renato-zannon I just checked this on my mac and it seems to work fine! Nice work :)


Update SE-class2023

I apologize this is the wrong FORK. Please fork https://github.com/NAIST-SE/SocialDeveloper and try again. Sorry!


Removed deprecated methods

Signed-off-by: Patrik Stas<EMAIL_ADDRESS>

Codecov Report

Merging #275 (59dfc3f) into master (f5f3586) will increase coverage by 0.35%.
The diff coverage is 50.53%.

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   45.06%   45.41%   +0.35%
==========================================
  Files         148      148
  Lines       18845    18633     -212
  Branches     5886     5802      -84
==========================================
- Hits         8493     8463      -30
+ Misses       6199     6029     -170
+ Partials     4153     4141      -12

Flag
Coverage Δ

unittests
45.41% <50.53%> (+0.35%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

libvcx/src/api/credential.rs
27.54% <ø> (+0.28%)
:arrow_up:

libvcx/src/api/disclosed_proof.rs
34.60% <ø> (+0.41%)
:arrow_up:

libvcx/src/api/issuer_credential.rs
28.97% <ø> (+0.35%)
:arrow_up:

libvcx/src/api/proof.rs
44.87% <ø> (+0.79%)
:arrow_up:

libvcx/src/init.rs
26.02% <0.00%> (-2.73%)
:arrow_down:

libvcx/src/libindy/utils/wallet.rs
52.14% <0.00%> (+2.93%)
:arrow_up:

libvcx/src/utils/provision.rs
42.33% <0.00%> (ø)

libvcx/src/api/vcx.rs
47.95% <54.28%> (+3.08%)
:arrow_up:

libvcx/src/libindy/utils/callback_u32.rs
50.56% <66.66%> (+1.16%)
:arrow_up:

libvcx/src/api/wallet.rs
42.00% <70.00%> (+2.69%)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f3586...59dfc3f. Read the comment docs.


Update testing image workflow to use Austin's packages

Currently the docker image is stored on my account -- it should be stored by @austin-mroz

Done by #26


ConfigOnSwitch example flawed?

I think your ConfigOnSwitch example might be flawed but I cannot be exactly sure (yet). The issue is that if the device cannot connect to one of the configured WiFi networks it keeps looping ignoring that pressed button to start the config portal.
I took your example and simplified it for my needs:

remove the ESP8266/ESP32 if-defs as I only need ESP32
remove the features I don't need
refactored duplicated code into dedicated functions
put all code into a wifimanager.h that I can use from my main setup()/loop()

-> see Gist https://gist.github.com/marcelstoer/914ff2ac58a42a957dfa071c9c5c8acd
-> use as below
void setup() {
  Serial.begin(115200);

  initWifiManager(String(deviceId));
  log_i("WiFi manager initialized.");
}

void loop() {
  // check button status here (to see if to start config portal)

  // internally checks WiFi connectivity in an interval i.e. not necessarily every time you call
  // this function
  checkWifiStatus();

  // app functions go here
}

As far as I understand the problem is the while-loop in connectMultiWiFi() at https://github.com/khoih-prog/ESPAsync_WiFiManager/blob/master/examples/Async_ConfigOnSwitch/Async_ConfigOnSwitch.ino#L388.
The function sequence is like this: loop() -> check_status() -> check_WiFi() -> connectMultiWiFi(). While trying to connect to one of the WiFis in that while-loop pressing the button to start the config portal has no effect! You would have to press the button for a really long time until the loop ends, the sequence above returns to loop() and the button status is evaluated again.

Thanks again for your interest in the library and your nice and clean code. The library's examples are normally over-crowded with too many definitions trying to demonstrate to as many use cases as possible.
The Async_ConfigOnSwitch example is just a simple example to demonstrate the ESPAsync_WiFiManager library's feature and certainly can not be expected to be perfect in all use cases.
To make sure to enter the Config Portal whenever a button is pressed, it's suggested you use either

Interrupt for the button to change a flag, then use the flag to exit the WiFi while loop when the button is pressed.
Async_ConfigOnDoubleReset example

Please check these examples

ISR_Timer_4_Switches
ISR_Switch
SwitchDebounce

for how to use Button Interrupt in ESP8266/ESP32.


Make a Java 7 compilable version of the library

The library requires Java 1.8 in order to build.  However, most (all?) versions of Android are limited to Java 1.7 (with only very limited support of certain 1.8 features).   This makes the distribution .jar files useless for Android development.
The compilation problems are not very serious.  In au.edu.federation.utils.Util there is a reference to Float.BYTES that only exists in 1.8.  Hardcoding that value to "4" fixes the issue.  I've only done this in my local copy of the core, but it appears during the maven build that similar issues exist in demo and visualization as well.

While Float.BYTES might be the only core issue, Java 1.7 doesn't support lambda functions which are used elsewhere in the code. These could be worked around - will have a think / chat with people about the best way to do this and get back to you.

Yep, you are right.   At the time I was only interested in the core (which after making the Float.BYTES -> 4 change builds correctly).   So I ignored the demo and visualization packages--the mvn build errors only showed the same "Float.BYTES" symbol missing error.   But that was because the compiler exited after that pass.   If I fix the symbols in demo and visualization the compiler then shows the construct errors.
Remember, though, that my issue is that the jar files were unusable for android development.   Demo and Visualization wouldn't be usable in android anyway because of the use of OpenGLWindow.  It would be nice if they built anyway so that desktop Java 1.7 environments could see that wonderfully constructed demo.

Working on it - expect updates =D

If I was to maintain Java 7 compatibility then the best way would likely be to rewrite the methods which use lambda functions to use standard callback methods and then perhaps do a maven replace of Float.BYTES with the value 4. However, why don't you just upgrade to Java 1.8 and gain the speed, flexibility and security of it?
Also, not sure how the demos would work on Android without modification away from glfw. Input especially would need a massive rewrite to use onTouchEvent shenanigans.

The objective of the project was to interface the mechanics of the arm with an android phone.   Unfortunately, Android does not support Java 8.  Android will only compile and run using Java 7.   The important thing about the project was your Caliko core (which works nicely with Java 7 with changes)--the demo/virtualization is unimportant because all of it would have to be re-engineered for the mobile environment; and that level of effort is unnecessary for Android.  However, switching a developer environment in Windows from 1.7 to 1.8 (to run your demo) and back again (to run Android Studio and build projects) is burdensome, so it would be nice if the demo would run in 1.7 so Android Developers wouldn't have to keep switching.
On the other hand, I would just be happy with a "core only" branch that built/ran in 1.7 so I don't have to include the entire core source tree in my project just to change one line of code.
Oh by the way, I am making a video of the final result.  It is kind of cool being able to move the arm meaningfully using android gestures.  It'll take a while because I have to first clean up my office--or people would see what kind of pig I am.

So you only need a caliko core JAR built with 1.7 bytecode ?
I am not familiar with Android development, but:

I presume you can take a pre-built JAR from a non-Android environment, and use the JAR in your Andriod app. If that is the case, and since caliko core does not have any other Maven dependencies ( apart from junit and mockito for unit testing ), then you can try adding a source 1.8 and a target of 1.7 in the maven-source-plugin in caliko/pom.xml ( not the aggregate POM ), like so:

  <plugin>
   <groupId>org.apache.maven.plugins</groupId>
   <artifactId>maven-source-plugin</artifactId>
   <configuration>
     <source>1.8</source>
     <target>1.7</target>
   </configuration>
 </plugin>

... in order to override the 1.8 target from the aggregate POM. Then build it in Linux / Windows, take the generated JAR artifact to your Android development, etc.

If you want to build caliko itself in Android and you are limited to Java 1.7, then change the above so that both source and target are 1.7 ( Then of course you remove the dependency on / remove the modules visualisation and demo ).

Since the core library does not rely on 1.8 syntax, either way will work ( tried both locally in that the demo still works ).

Yes that works, but it will only compile in a 1.8 environment (obviously).   For android development, I always use a 1.7 environment.   We also try not to include jar files in our git source; we'd rather pull dependencies from projects... but I suppose an exception could be made.  It would be nice if the distributed .jar files you have already had a 1.7 compatible core.

See pull request:
https://github.com/FedUni/caliko/pull/12

So cool!   I'll check it out as soon as I can.

Note that to use the 1.7 artifact, you will hace to use a classifier of jdk7

dai-ichi, are you happy to close this issue - or does it require any further work?

Perfect.  Have you considered publishing it in the Maven repository?


"attemped to divide by zero" in the admin page when displaying a team without players

Fixed in 0fed0794fdc981fc46d37dc9943f1277761ad857.


Minor Fixes After Makefile rewrite

Fixes syntax errors, missing variables, and enforces a set version for converge version.

LGTM!


Can we change the global index(UnpaddedInternalThreadLocalMap.nextIndex) to thread scope in FastThreadLocal?

@coinary1 ah ok... yeah its an optimisation as this allows us to ensure we never have a clash without doing any heavy locking etc.
Originally posted by @normanmaurer in https://github.com/netty/netty/issues/8271#issuecomment-419892698
As it was discussed in the issue 8271（above）, the InternalThreadLocalMap will waste memory(space).
But I have a question. Why don't we change the global index(UnpaddedInternalThreadLocalMap.nextIndex) to thread scope.
In this case , every InternalThreadLocalMap instance has an individual nextIndex. That means every thread has an individual nextIndex. That will make sure every FastThreadLocal instance has a unique index in a thread and InternalThreadLocalMap.indexedVariables doesn't waste space., moreover we don't need to use heavy lock.
Can we do like this?

@hilaryfrank please open a PR with the code changes you suggest. It is hard for me to follow your thoughts here.


Add ordering system for auto-mode-alist

As title, currently jcs-add-auto-mode-alist uses append to order mode alist. I think is much better to use some kind of dedicated ordering system for sorting the mode alist.
https://github.com/jcs090218/jcs-emacs/blob/85b9356b357886c9c0417b70ea59bd19aa2cfbb6/.emacs.jcs/jcs-mode.el#L545

Use append function to the whole list instead to save performance. The newly appended list should prior to the default settings/value.


Registry Integration

I am opening an issue here to dump some thoughts on how to take this addon a bit further, and how things like this can work in the future.
Random musings / brain dump:

registration should use the registry and ember-cli-babel should be getting the available plugins out of the registry.
This prevents users from having to manually edit the Brocfile.js as described in the README here, and also allows super easy infrastructure for future babel plugins in the Ember CLI world.
ember-cli-htmlbars does this exact thing to allow addons to add HTMLBars AST plugins (see here).

Use ember-cli-htmlbars's to do the precompilation (or at least provide the options to compile so that AST plugins are available to precompilation).

Add to ember-cli apps/addons by default as a devDep.  Once the above items are resolved, I would like to add this to ember-cli's default out of the box setup.

@pangratz - Does this all make sense?  Can you help spearhead these changes?

registration should use the registry and ember-cli-babel should be getting the available plugins out of the registry.

this may also enable this to work correctly in nested-addons

this may also enable this to work correctly in nested-addons

Exactly!

I think when we nail ^^, we should include this by default in ember-cli.

Thank you so much for the directions @rwjblue :heart_eyes:. Your outline of using a registry for the plugins is definitely the way to go. I'll open a PR on ember-cli-babel shortly so we can see if I understood everything correctly.

Use ember-cli-htmlbars's to do the precompilation (or at least provide the options to compile so that AST plugins are available to precompilation).

I think I am gonna need help with that since I am not sure how to exactly reuse the precompilation functionality from ember-cli-htmlbars within ember-cli-htmlbars-inline-precompile...

I think I am gonna need help with that since I am not sure how to exactly reuse the precompilation functionality from ember-cli-htmlbars within ember-cli-htmlbars-inline-precompile

I think we just need to expose a mechanism to the registered plugin, to preprocess a given string (without broccoli tree).  So adding a compileString to this object that is registered should do the trick.  Then ember-cli-htmlbars-inline-precompile could grab the ember-cli-htmlbars's wrapper object out of the registry and call plugin.compileString('whatever string I have here');.

Ah, right. Thanks, will do that.

<EMAIL_ADDRESS>has the tweaks suggested above, should be ready for testing here...

<EMAIL_ADDRESS>has the tweaks suggested above, should be ready for testing here...

:heart_eyes:
I opened a PR which refactors the htmlbars-inline-precompile setup according to this issue #9. Once ember-cli/ember-cli-htmlbars#53 is merged and a new version of ember-cli-babel is released, I will update ...


Facilitate docker 'layering'

Problem description
To speed up docker image building, it is fairly typical to separate "things that change often", to "things that don't".
For dependency management, this usually means it is recommended to install dependencies in a docker layer first (as they do not change often), then install the local package(s) (as it changes at ~each build, so a lot more often).
A very simple python Dockerfile may look like
FROM python:3.12.2-slim

WORKDIR /app

COPY requirements.txt .

RUN pip install -r requirements.txt

COPY sample.py .

where requirements are installed before copying local code, to maximise cache hit.
It is not clear how something similar could be achieved with pixi currently. A couple of options that come to mind

Not include local code in an environment, and use this environment to install dependencies. In that case, local code would need to be installed by something else than pixi, which does not feel ideal
Have two environments, one 'dependencies-only' and one 'dependencies + local code' and start by installing one, then copy the code, then install the second one. this may be better, but feels like a bit of a hack, having two environments when we actually only need one, and pixi will do extra work to solve environment.

Another alternative (and better?) option could be extra options for pixi install. For instance --no-path-dependencies and --only-path-dependencies to respectively exclude path dependencies from solve & install, or deal only with them (ideally without doing any solve work, bypassing as many steps as possible to speed things up).
The Dockerfile may then look like
FROM python:3.12.2-slim

WORKDIR /app

COPY pixi.lock pixi.toml .

RUN pixi install --locked --no-path-dependencies

COPY sample-package .

RUN pixi install --locked --only-path-dependencies

Thanks for the issue, seems like something we should facilitate @pavelzw could you chime in here with your experience?

Hmm, I get the advantage of this, although i'm worrying a bit that this makes the CLI more complicated and cluttered. I can't think of any better solution than Olivier's so I guess this could make sense in pixi...
Side note: i've not really used path dependencies because of https://github.com/prefix-dev/pixi/issues/1046 and https://github.com/prefix-dev/pixi/issues/1340#issuecomment-2107093071

With the postinstall method that I am using until now, we can just ship around this problem:
FROM ghcr.io/prefix-dev/pixi

WORKDIR /app
COPY pixi.lock pixi.toml .
RUN pixi install --locked
COPY pyproject.toml my_app .
RUN pixi run postinstall

But since postinstall could be considered a hack as well, this might not be what we want.

Thanks @pavelzw for your thoughts on this!
As additional context, looking at other tools:

conda install has --no-deps --only-deps options
pip install has --no-deps options
poetry install has --no-root --only-root options

conda and pip options are a bit different from what is proposed here, which can be explained by the fact they do not use lockfiles. poetry option however feel very similar to what is proposed here (but limited to a single 'root' package).

@ruben-arts I agree on the lower usefulness of —no-deps. This tends to be done to bypass costly checks, and/or defer the installation of dependencies to a later step/stage.

I am not sure using the same command pixi install for both environment level operation (as it is today) and package level is the best option; I feel it may be confusing.
Maybe a separate command for package level operation would be better ? e.g. pixi force or something like that? After all, these operations at likely outside of the « happy path ».


Use parity multiaddr?

Research weather or not multiaddr can be replaced by parity multiaddr. multiaddr doesn't look like it's maintained any more

Hey @ferristseng
Good thinking. I gave it a shot here:
https://github.com/ferristseng/rust-ipfs-api/pull/45


first commits

Initialize this repo by pulling the latest binary from con-pca-tasks repo
🗣 Description
Update dockerfile & docker compose to pull and run the latest binary from con-pca-tasks
Initialize other files to reflect the scope of this project
💭 Motivation and context
🧪 Testing
testing by building and running the docker image locally
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] All new and existing tests pass.

@itsmostafa - Once the tests are passing, and assuming I don't see any issues with the changes that are made make that happen, I will approve.

@jsf9k tests pass now with @mcdonnnj suggestion to add gcompat lib dependancy in Dockerfile

@jsf9k tests pass now with @mcdonnnj suggestion to add gcompat lib dependancy in Dockerfile

Can you or @mcdonnnj add a comment (either in this PR or in the Dockerfile) explaining why that is necessary and sufficient here?  I know that Alpine uses musl instead of glibc, and in the past I've treated this sort of failure as a good indicator that Alpine isn't a good fit.

@jsf9k tests pass now with @mcdonnnj suggestion to add gcompat lib dependancy in Dockerfile

Can you or @mcdonnnj add a comment (either in this PR or in the Dockerfile) explaining why that is necessary and sufficient here? I know that Alpine uses musl instead of glibc, and in the past I've treated this sort of failure as a good indicator that Alpine isn't a good fit.

@jsf9k i actually dont need glibc. I just removed it with commit 3410827
Per @mcdonnnj suggestion, i installed gcompat instead which is a C Library compatibility layer for musl


[Map] AS-UTOceanFloorOld

Something very odd here - a lot of Leo's conversions of maps made for an early UT version to UT99 have been categorised as being for Unreal.  There are several clues that they are not for Unreal - in this case, for example, there is no Unreal Assault game type (true there is [SP]Assault but that would require the map to have the relevant actors from that game type).
There are 4 DOM maps and, again, there is no Unreal Domination gametype.
The UT prefix to the map names is another clue and the readmes that I have looked at indicate that the conversions are for UT as Unreal weapons have been replaced by UT weapons.
So possibly all the recent additions of maps with the UT prefix in the map or archive title need to be examined more closely?  There are too many for me to look at and raise an Issue on each one.

URL: https://unrealarchive.org/maps/unreal/assault/U/as-utoceanfloorold_8b739be8.html
Hash: 8b739be8fb8ee006bc9f3f9424b9550adbbfdea9
Current name: AS-UTOceanFloorOld

Hmm, interesting.
So I assume the "221 version" in the title of some of these refers to the "source" version - not the intended runtime version?
I changed them all to UT.

Yes they are conversions from the UT v221, made compatible with current UT versions with their packages + other minor fixes iirc.


Use bare module specifiers in the P3 conversion

Connected to vaadin/components-team-tasks#332

This change is

Reviewed 13 of 13 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Ability to display average response time for the last n minutes

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
I'm missing the ability to view the average response time for a limited time window only in træfik's dashboard. Currently, when one request takes unusally long, the whole average response time is skewed until I restart træfik. It would be great if we could choose to display the average response time for the last 1 minute, hour or day to see if e.g. fixing a bug resulted in lower response times.

Hi,
Thanks for your interest in the Traefik.
We want to keep the statistics on the Traefik webui simple. If you want more information about your requests etc... You should use the metric system to have those information.
https://docs.traefik.io/configuration/metrics/