Add the LICENSE file to the binary archives in releases

Hi,
I would like to make a suggestion about the binary archives content of the different releases.
I think they should include the LICENSE file in addition to the binary (like dnote does for instance).
Indeed, the best practice in terms of licensing implies to include the license file with your project, which is not the case when installing lowcharts via release as you only get the binary (and not the LICENSE).
In addition to that, including the LICENSE file into the binary archives will make the maintenance of the lowcharts-bin AUR package easier and cleaner on my side.
Indeed, lowcharts being protected by the MIT license, I have to include the LICENSE file (in addition to the binary) during the installation process (see https://wiki.archlinux.org/title/PKGBUILD#license). As it is not included in the binary archive itself, I have to get it directly from the GitHub repo.
While grabbing the LICENSE file directly from the GitHub repo is not an issue from a technical stand point, the Arch-Linux packaging guidelines and best-practices imply to check the integrity of every download resources through their hashes before the installation process for obvious security reason.
According to that, the installation process of the lowcharts-bin AUR package depends on the integrity of a file that is subject to change without necessarily leading to a new release. In other words, a change of the LICENSE file can make the build fail even tho there's no new release nor changes to the binary (until I update the hash of the LICENSE file accordingly in the PKGBUILD and publish the update).
If the file was provided in the binary archive directly, I would not have to rely on its hash, as verifying the integrity of the archive itself would be enough (preventing the possibility of a failed build because of a change in the LICENSE file on the GitHub repo).
I'm aware that the LICENSE file shouldn't be modified too frequently and thus the above case might be pretty rare.
On the other hand, I assume this change is fairly easy to do and would improve the binary archives structure and the maintenance of the lowcharts-bin AUR package, hence my suggestion :)
Thanks for your awesome work BTW !

Thank you for adding the LICENSE file to the assets of release 0.5.3 and 0.5.4.
I updated the lowcharts-bin AUR package accordingly to avoid the scenario I described in this issue (it is now grabbing the LICENSE file from the release's assets and not directly from the repo).
BTW I updated, all lowcharts* AUR packages to V0.5.4 ;)
Thanks a lot for you quick actions !

Thanks to you for reporting those issues.
I did not close that issue after doing the LICENSE related changes because I wanted to ask you if LICENSE file should be inside tar.gz file too.  If that is the case, please let me know and I will include it there.

Thanks for your answer and actions !
Having the license into the assets is okay but, in my opinion, the LICENSE file should primarily be inside the tar.gz archives actually.
As of now, if the user downloads lowcharts via release, he will not get the license unless he downloads it manually from the release's assets as well.
As far as the maintenance on my side is concerned, having the LICENSE file directly in the tar.gz archives would be easier for me as I only have to download and check the integrity of the tar.gz archive to deliver both the binary and the LICENSE file to the end user.
My opinion would be to include the LICENSE file inside the tar.gz archives only (and not necessarily into the release's assets):

Users downloading lowcharts via local compilation will automatically get the LICENSE as they clone the entire repo (that already contains the LICENSE file).
Users downloading lowcharts via release will automatically get the LICENSE inside the tar.gz archive (without having to download it manually from the assets).
Users downloading lowcharts via the AUR will only have to download the tar.gz archive to get the LICENSE as well (less resources to download for them, less resources to manage and check for me on the maintenance side).

I created v0.5.6 with your suggestion: including the LICENSE file inside the tar.gz archives only

Thanks a lot, that's perfect !
I updated the AUR packages accordingly.
I guess the issue can be close now :smile:

I am closing the issue then.
Thanks again for raising this issue

First fan in the AUR though :smile: :

https://aur.archlinux.org/packages/lowcharts-bin#comment-881610


[service-bus] add api docs link for v1 library

Fixes #8087

That means a lot given there are 3 other 1.1.5 links in that README!


Update cask from 0.6.7 to 0.9.1

About this PR
📦 Updates com.lihaoyi:cask from 0.6.7 to 0.9.2
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (0.6.7).
You might want to review and update them manually.
readme/Footer.scalatex

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "cask" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lihaoyi", artifactId = "cask" }
}]

labels: library-update, early-semver-major, semver-spec-minor, old-version-remains, commit-count:1

cask 0.9.2 will depend on a newer version of undertow, which requires Java 11.


TUI Image Editor Dynamic Images Button Problems

Version
Most Recent
Development Environment
Firefox, Chrome, Windows, iOS
Current Behavior
I'm stuck on an issue with the TUI Image Editor where the buttons don't work after using the loadImageFromURL function.
Currently, I load images from a gallery beneath the TUI editor with the exception of the first image using the scripts below:
My initialization
window.onresize = function() {
             instance.ui.resizeEditor();
         }

            var instance = new tui.ImageEditor('#tui-image-editor', {
     includeUI: {
         theme: blackTheme, // or whiteTheme
         menu: ['rotate'],
         menuBarPosition: 'bottom'
     },
     loadImage: {
                     path: 'data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7',
                     name: 'Blank'
                 },
    cssMaxWidth: 700,
    cssMaxHeight: 500,
    selectionStyle: {
        cornerSize: 20,
        rotatingPointOffset: 70
    }
});

            // Patch the loadImageFromURL of our tui instance instance:
         instance.loadImageFromURL = (function() {
             var cached_function = instance.loadImageFromURL;
             function waitUntilImageEditorIsUnlocked(instance) {
                 return new Promise((resolve,reject)=>{
                     const interval = setInterval(()=>{
                         if (!instance._invoker._isLocked) {
                             clearInterval(interval);
                             resolve();
                         }
                     }, 100);
                 })
             }
             return function() {
                 return waitUntilImageEditorIsUnlocked(instance).then(()=>cached_function.apply(this, arguments));
             };
         })();

 // Load an image and tell our tui imageEditor instance the new and the old image size:
         instance.loadImageFromURL("{{ url('/') }}{{Storage::url('manifests/'.$images->first()->name)}}", "SampleImage").then(result=>{
             instance.ui.resizeEditor({
                 imageSize: {oldWidth: result.oldWidth, oldHeight: result.oldHeight, newWidth: result.newWidth, newHeight: result.newHeight},
             });
         }).catch(err=>{
             console.error("Something went wrong:", err);
         })

        /*  instance.loadImageFromURL("{{ url('/') }}{{Storage::url('manifests/'.$images->first()->name)}}",'{{$images->first()->name}}').then(result => {
     console.log('old : ' + result.oldWidth + ', ' + result.oldHeight);
     console.log('new : ' + result.newWidth + ', ' + result.newHeight);
});*/

My script to select other images:
$(document).on('click', '.selectImage', function() {
    var path = $(this).data('path');
    $('#image_id').val($(this).data('image_id'));
    instance.clearObjects().then(() => {
            console.log('cleared');
            instance.loadImageFromURL("{{ url('/') }}"+path,'name').then(result=>{
             instance.ui.resizeEditor({
                 imageSize: {oldWidth: result.oldWidth, oldHeight: result.oldHeight, newWidth: result.newWidth, newHeight: result.newHeight},
             });
             console.log(result);
         }).catch(err=>{
             console.error("Something went wrong:", err);
         })
  });

});

Now, oddly enough, the images load fine. But the buttons don't do anything. If I highlight over the rotate button, it'll show a help popup of "Rotate" but won't actually do anything.
Do I have to reset the canvas somehow when loading the images?
Thanks!
Expected Behavior
Should be able to use buttons.

If the image size is too small, it may not work properly. But maybe that will work well.

Bump. Changing the images using imageEditor.loadImageFromURL() changes the image but the editor UI buttons does not work. The canvas size does change as per the loaded image.

anyone has fixed this issue the button edit not working on loadurl

Doesnt work either if using loadImageFromFile()

The issue is still there. Editor freezes

The issue is still there....Can anyone fix it please


⚠ Bofrost.nl has degraded performance

In 49b5027, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1607 ms

Resolved: Bofrost.nl performance has improved in ce6e300.


drivers/gpio/gpio_rzt2m: Handle trig == GPIO_INT_TRIG_WAKE

Fix a build warning due to the enumerate for the trigger polarity possibly being (from the point of the compiler) also GPIO_INT_TRIG_WAKE.
We fix it by simply returning a not valid argument error which is what most other drivers do if they do something smart enough.
Fixes #74213

@fabiobaltieri @henrikbrixandersen @tgorochowik this is a relatively trivial fix for a high priority bug (due to the issue failing in CI blocking PRs). You are very welcome to take a quick look.
Note that what this fix does is what the original PR did for the other drivers which similarly handled this with a switch case.


Rolling back static python and scipy for python3.8 support

As the title

Merging because I needed after changes in ansys actions.


Add setTLSCertificate to WebUI

@hassandraga Unfortunate on my custom certificate I was not able to test, probably due to issue with my certificate ...
Could you verify it ?

To test it, you need the TLS version of WebUI. Windows MSVC example: nmake WEBUI_USE_TLS=1 WEBUI_TLS_INCLUDE="C:\Program Files\OpenSSL-xxx\include" WEBUI_TLS_LIB="C:\Program Files\OpenSSL-xxx\lib"
More details: https://github.com/webui-dev/webui#build

Yeah, I have already generated certificate but probably it was already expired


Settings API minor improvements

For commands with no arguments, argument_names attribute can return an empty list. Currently, that attribute is not available.

contour1 = solver.results.graphics.contour.create("contour-1")
del contour1

In the above, the __del__ method can call __delitem__ on the container.

the point 1 of this task is done. Need to figure out ways to do point 2.


Test for single test scenario

When I run test scenario, I will click run button (Test Runner extension) or run command:" mvn clean test ".
Have any way to test single row testcase in .scesim file? I have tried to use run for single case but it doesn't work.

@nvthanh02 At this moment this use case is not supported.


Option to disable sound effects

Some UI components have a click sound effect. This annoys me and I would like to turn it off.

Nevermind! I turned it off completely.

Hi Larivact - I think the click sounds is coming from the WebBrowser control used for the "Rendered" mode of response bodies. It looks like there may be a code solution where I can turn it off for all users (I don't think an option is needed, because I think it probably just annoys everybody): http://stackoverflow.com/a/737280/236255
May I asked how you turned it off for yourself?

I disabled all my Windows sounds in the Windows 7 "Sound" setting. Then the tab "Sounds" and there you can change every windows sound effect. I just changed everything to none.
And I can't imagine the click sound coming from the WebBrowser because I got the click sound when I:
Hit the submit button. Sent the request by hitting enter. Canceled the request. Even File > New gave me a click sound.

All of those actions actually trigger the WebBrowser control to "navigate", thus producing the sound.
Yes, thanks for reporting / re-opening, I do agree this would be a worth while fix (I keep my computer sounds off most of the time, so I think the noise never "got to me" the way I can see it doing).


Move off hacky parsers

The formatting library uses several small hacky parsers (mainly to parse composite formatting strings). We should create a real non-allocating parsing library and use it instead.

@KrzysztofCwalina : Is this still a valid issue or does it need to be closed?

it's still an issue

I think it's fixed now.


Adds new NotificationTypes - VM destroy, Cloud Volume and Cloud Volume Snapshot actions

In order to have actions in OpenStack provider create Notifications we need new NotificationTypes for them. Associated PR for OpenStack provider is https://github.com/ManageIQ/manageiq-providers-openstack/pull/85

@miq-bot assign @skateman

This is needed for https://github.com/ManageIQ/manageiq-providers-openstack/pull/85

@petrblaho is there any reason in not using the subject where possible?

@skateman thank you for your review and chat help. Looking into how to use that now.

@skateman hi! could you take a look at petr's updates and see if this looks good now?

@skateman Please Help!!!

Well, if @skateman and the sea lion approve!

@blomquisg he's my "seal of approval" :wink:

@miq-bot add_label fine/yes

Marked fine/yes. Needs to be backported for https://bugzilla.redhat.com/show_bug.cgi?id=1524356


Radar not publishing firmware version 2018 Honda fit ex

Comma 2 states on screen car not supported. Support says radar isn't publishing firmware version so it's causing this.
Dongle id: 81ed6773e542b743
Route: 81ed6773e542b743|2021-05-14--17-07-24

Please add your Dongle ID and a route as stated in the template when you create a bug.

Please add your Dongle ID and a route as stated in the template when you create a bug.

Just edited

@el11nene11 is this still an issue? I don't see any recent routes from your device.

No. This isn't an issue anymore. With the replacement comma two the issues were resolved. Thanks


Godot crashes when resetting exported string array variable

Godot version:
3.1.1.stable.official
OS/device including version:
Arch Linux 5.0.13
Issue description:
Trying to reset an exported variable of type PoolStringArray to it's default values crashes godot.
Steps to reproduce:
Create a simple node, with a simple child node
Add script to child node and export a variable of type PoolStringArray
Modify values of the PoolStringArray in the inspector
Click on arrow to reset.
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /usr/lib/libc.so.6(+0x378b0) [0x7efc7cabb8b0] (??:0)
-- END OF BACKTRACE --

Minimal reproduction project:
Sample project

Full log:
OpenGL ES 3.0 Renderer: GeForce GTX 970/PCIe/SSE2
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /usr/lib/libc.so.6(+0x378b0) [0x7fc1aec1e8b0] (??:0)
[2] EditorProperty::get_minimum_size() const (/home/guilherme/Workspaces/godot/editor/editor_inspector.cpp:74 (discriminator 3))
[3] Control::_update_minimum_size_cache() (/home/guilherme/Workspaces/godot/scene/gui/control.cpp:160)
[4] Control::get_combined_minimum_size() const (/home/guilherme/Workspaces/godot/scene/gui/control.cpp:180)
[5] Control::_update_minimum_size() (/home/guilherme/Workspaces/godot/scene/gui/control.cpp:276)
[6] MethodBind0::call(Object*, Variant const**, int, Variant::CallError&) (/home/guilherme/Workspaces/godot/./core/method_bind.gen.inc:61 (discriminator 4))
[7] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/guilherme/Workspaces/godot/core/object.cpp:940 (discriminator 1))
[8] MessageQueue::_call_function(Object*, StringName const&, Variant const*, int, bool) (/home/guilherme/Workspaces/godot/core/message_queue.cpp:256)
[9] MessageQueue::flush() (/home/guilherme/Workspaces/godot/core/message_queue.cpp:305)
[10] SceneTree::iteration(float) (/home/guilherme/Workspaces/godot/scene/main/scene_tree.cpp:476 (discriminator 2))
[11] Main::iteration() (/home/guilherme/Workspaces/godot/main/main.cpp:1862)
[12] OS_X11::run() (/home/guilherme/Workspaces/godot/platform/x11/os_x11.cpp:3030)
[13] /home/guilherme/Workspaces/godot/bin/godot.x11.tools.64(main+0xdc) [0x1379972] (/home/guilherme/Workspaces/godot/platform/x11/godot_x11.cpp:56)
[14] /usr/lib/libc.so.6(__libc_start_main+0xf3) [0x7fc1aec0ace3] (??:0)
[15] /home/guilherme/Workspaces/godot/bin/godot.x11.tools.64(_start+0x2e) [0x13797de] (??:?)
-- END OF BACKTRACE --

@guilhermefelipecgs How do you get a full log?

I use godot compiled directly from source, this way it's possible to trace the files.


deep_linking example's Show notification now and in 5 seconds does nothing on Flutter Web

Steps: clone repo, cd in to example/deep_linking, run with flutter run -d chrome.
Expected behavior: see notification now and in 5 seconds respectively.

Mobile only I"m guessing.


tp_ -> slot_

tp_ prefix is originated from CPython code, which conventionally use those kind of type prefixes for member fields.
RustPython is not following the naming policy, so it doesn't give any meaning to readers.
Renaming it will give more clear meanings about the type PyTypeSlots and slot implementation methods name.

so it doesn't give any meaning to readers

I'd say it helps to be able to cross-reference with CPython. Then again, I really don't mind the rename, I always mentally think of the 'slot' whenever I see tp_. You work with many new time contributors so they might be better suited to say how much similar names help them.

Yes, I missed that point.
Still, CPython has member prefix convention across the whole project. I think keeping just this prefix while removing every other prefixes doesn't make that much sense.
Probably we'd better to get the cross-reference advantage from comments.


Add Error System Integration

Advanced error handling integration is fundamental towards the creation of a successful program
Implementation

The three basic node functions ready(), process(), and terminal() should return a custom error type, and it should be able to handle custom user errors as well as hardcoded errors, and should create a custom stacktrace that could be integrated with a visual of the NodeTree of where the issue occured.
Logging should be implemented, with the function/macro push_to_log() being implemented along with the enum Log dictating what kind of message is being sent to the logger:

#[derive(Debug, Clone)]
pub enum Log<'a> {
    Debug(&'a str),
    Info(&'a str),
    Warn(&'a str),
    Panic(&'a str)
}

(Note, if a macro is used instead, then the enum can be replaced with macro rules.)
The logger will be run at the NodeTree level, and its verbosity can be set by a node_tree function:
#[derive(Debug, Clone)]
pub enum LoggerVerbosity {
    All,
    NoDebug,
    OnlyIssues,
    OnlyPanics
}

A visual of how the log could look is as follows:
<TIME> | [..\GrandParent\Parent\Node] (DEBUG) | This is a debug message.
<TIME> | [RegisteredSystemName] (DEBUG) | To make things less verbose, system names can be registered with NodeTree.register_sys().
<TIME> | [..\GrandParent\Parent\Node] (INFO) | This is an info message.
<TIME> | [..\GrandParent\Parent\Node] (WARN) | This is a warning.
<TIME> | [..\GrandParent\Parent\Node] (PANIC!) | This is a crash message.

[Custom Header Crash Message! - Can be configured with NodeTree.set_default_header_on_panic(). Default Message Below]
Unfortunately the program has crashed. Please contact the development team with the following crash report as well as the attachment of the log posted during the time of the crash.

[NodeTree Graphic Here]

Time of Crash: [TIME]
Exit Code: [CODE]

[Custom Footer Crash Message! - Can be configured with NodeTree.set_default_footer_on_panic(). Default Message Below]
Goodbye World! (Program Exited)

As a more developed idea; The NodeTree graphic could highlight nodes that gave off warnings on the same process frame that a node or system panicked, and that could be listed in detail below the graphic.

Finished in the latest commit


Create a tutorial on how to set cookies

https://github.com/Michele0303/tiktok-live-recorder/blob/main/GUIDE.md#how-to-set-cookies


stop_gradient_p -> ad_util.py, re-enable some mypy

New mypy releases have a tendency to trigger failures, so it can be nice to pin the version of mypy used in CI and update it manually. This is actually advised in their "getting started" guide: https://mypy.readthedocs.io/en/stable/existing_code.html#continuous-integration

I've pinned the mypy version here: https://github.com/google/jax/pull/2811


Update spacing and some translations

Made some more minor improvements and corrections.
(Sorry for the many small PR's, everything should be good now with these changes!)

No worries, all changes welcome!


error creating database with name starting with "f" in console

OrientDB v2.1.11 (fresh) on Windows10 64bit
error creating database with name starting with "f" in console
see screenshot

Hi @seriouslyEnter
The problem seems to be related to the \f, my feeling is that it's being interpreted as a form feed character. The problem does not happen on Linux/Mac because they use forward slash.
I'll let you know soon for a fix
Thanks
Luigi

It might help to always use a forward slash regardless of the operating system, since the path is only ever interpreted by Java code.

Will do.
Thanks


Chat/Commands: Increase output token limit for PLG

Description
Part of https://github.com/sourcegraph/cody/issues/3648
This PR:

Increases the output limits for Sourcegraph.com Cody usage from 1000 to 4000 tokens
Removes a redundant reduction in context size that will add an extra 1000 tokens to our context window. This is only necessary on certain enterprise models where the input + output lengths are computed together.

[!NOTE]
This PR requires that https://github.com/sourcegraph/sourcegraph/pull/61872 is merged first

Test plan

Run https://github.com/sourcegraph/sourcegraph/pull/61872 locally
Trigger long context responses (e.g. "Show me 300 lines of typescript code")
Expect that everything functions as normal

@sourcegraph/cody-security Guessing this was triggered because of the merge commit? Maybe we should exclude those?

@umpox Ah yeah probably, we use git diff --name-only origin/main. Rebasing would probably help. I’m not sure how to work around this easily and this should resolve itself once all PRs are branched-off of the latest main so maybe we can just life with some more notifications to review for a few days? 😬

@umpox Ah no this is because we look at the files and not just the modified ranges within those files. Shoots. This actually needs a much more sophisticated approach (we need to know which ranges were modified and only emit linter issues in those places).
Hmmm maybe as a temporary workaround we can extract the unsafe_ calls in "hot" paths (like in SimpleChatPanelProvider.ts in this case) into a separate module that we don't need to touch so often? cc @sourcegraph/cody-security
I will research how other linters do that. Sorry for the churn @umpox and please ignore it for now in this PR 🥺 🙏

:D @philipp-spiess No probs


Fix #2591: stopSubmit removes pending promise from reduxForm.

Codecov Report

Merging #2731 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2731   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          67      67
  Lines        1384    1388    +4
======================================
+ Hits         1384    1388    +4

Impacted Files
Coverage Δ

src/reduxForm.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a24ad...44f2efe. Read the comment docs.

Please wait before approving the PR. I'm working on some unit tests to ensure this works properly.

Ok, tests have been comited and are passing.

Published in v6.6.1.


Best practice for destroying sink_to_list sink

Normal sinks return a reference to the node so they can be destroyed, but sink_to_list returns the list to which data is being appended. What is the best way of getting a handle on a specific sink_to_list node so it can be destroyed?
(Should we consider changing the API to return the sink's reference too?)

Since this is mostly used in testing as a convenience, I think it's fine to leave it as it is. We could add somewhere how to do this by hand and maintain that link:
l = []
sink = source.sink(l.append)


feat!: register device attributes when set

Closes: https://github.com/customerio/issues/issues/7296
Why this change is being proposed
Now that we have a background queue and we can make synchronous changes in the SDK, let's make an enhancement to the SDK in regards to custom device attributes.
The SDK today behaves like this.

Customer sets custom device attributes in the SDK
Custom device attributes do not get sent to CIO until the next time that registerDeviceToken() is called

This could cause customer confusion where they try to add custom device attributes and wonder why they are not added to CIO.
Proposal is to change the behavior of the SDK to:

Customer sets custom device attributes in the SDK
If a push device has already been registered with the SDK, add a task to the background queue to register device token again with these newly set custom device attributes.

This change increases the chances that the device attributes will be sent to CIO.
Breaking change
This PR has a breaking change in the API.
Previously, to add custom device attributes in the SDK, you would call:
CustomerIO.instance().deviceAttributes.putAll(mapOf(...))

This PR changes the API to syntax that is more familiar to Kotlin developers:
CustomerIO.instance().deviceAttributes = mapOf(...)

Because this PR will be deployed to the current 2.0 release, this breaking change PR will not require a bump to the semantic version of the SDK.
Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

[x] Assign members of your team to review the pull request.
[x] Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
[ ] Wait until the pull request has been reviewed and approved by a teammate
[ ] After pull request is approved, and you determine it's ready add the label "Ready to merge" to the pull request and it will automatically be merged.

Pull request title looks good 👍. If this pull request gets merged, it will cause a new release of the software.
Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 2.0.0.
To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

:tada: This PR is included in version 2.0.0-alpha.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Videos take too long to start

Very good library with just one problem and big one and that is it takes 60-70 seconds to start an online video even if it's a 2-3 secs video. How do i fix this. How do i fix it with code. Thank you

android.media.MediaPlayer maybe takes a lot of time to load your url, you can on line code to change to ijkplayer, see demo.

demo where?


Enable overflow scroll on edit dialog

Fixes #99.

Thanks @DieterHolvoet for this!
It's a way to cover the issue. But I'm annoyed that a scroll placed here could hide the actions buttons (save and cancel).
I have a different approach to this problem to suggest.
Right now an empty div is created when the element form is inserted, and this specific div prevent the styles of the parent to apply. It could work if this div has a height of 100% but it has no style or class.
So I think it will be better if we avoid to create an empty div in the script:
diff --git a/assets/js/app.js b/assets/js/app.js
index 93ea492..da05688 100644
--- a/assets/js/app.js
+++ b/assets/js/app.js
@@ -409,12 +409,8 @@ global.MonsieurBizRichEditorManager = class {
   }

   drawEditForm(formHtml, uiElement) {
-    let form = document.createElement('div');
-    form.innerHTML = formHtml;
-
-    let formContainer = this.editPanel.dialog.querySelector('.js-uie-content');
-    formContainer.innerHTML = '';
-    formContainer.append(form);
+    this.editPanel.dialog.querySelector('.js-uie-content').innerHTML = formHtml;
+    let form = this.editPanel.dialog;

     this.wysiwyg.load(form);
     this.initUiCollectionForm(form);

With that, the scroll is applied to the form and not to the entire panel. What do you think about this?

Great, that seems to work as well! You know the codebase better than I do :)

Thank you @DieterHolvoet ! 🎉
and @Guirec :)


Prompt System.ArgumentNullException: The parameter "unevaluatedValue" cannot be null.

未经处理的异常:  System.ArgumentNullException: 参数“unevaluatedValue”不能为 null。
在 Microsoft.Build.Shared.ErrorUtilities.VerifyThrowArgumentNull(Object parameter, String parameterName, String resourceName)
在 Microsoft.Build.Construction.ProjectTaskElement.SetParameter(String name, String unevaluatedValue)
在 Embeddinator.XamarinAndroidBuild.GenerateJavaStubsProject(List`1 assemblies, String outputDirectory)
在 Embeddinator.Driver.WriteFiles()
在 Embeddinator.Driver.Run()
在 Embeddinator.CLI.Main(String[] args)

Thanks for the feedback.
It looks like you hit an exception while compiling an android project.
Could you please attach the project in question and build logs so we can look into th

Thanks for the feedback.
It looks like you hit an exception while compiling an android project.
Could you please attach the project in question and build logs so we can look into th
ClassLibrary1.zip

This is actually an Android class library project created, nothing changed

Can you please also post the tool invocation you used to try to bind that library?

Can you please also post the tool invocation you used to try to bind that library?

Are you uploading my local Embeddinator-4000 tool?

No, what command did you use to build it from the command line?

No, what command did you use to build it from the command line?

Embeddinator-4000.exe -gen=Java --platform=Android -out=foo ClassLibrary1.dll

No, what command did you use to build it from the command line?

Hi, this problem was solved by adding a -c option, but now there is a new problem!

I had the same problem.
Try to run the command again with the -v option.
Embeddinator-4000.exe -gen=Java --platform=Android -out=foo ClassLibrary1.dll -v
The output should show that the Android Ndk registry key is missing.
What if have done was to add the missing key and pointed to the android ndk.


does not work  ENABLE_TX_WHEN_AM             := 0       allow TX (always FM) when RX is set to AM

So as the title says
ENABLE_TX_WHEN_AM             := 0       allow TX (always FM) when RX is set to AM
Does not work properly
It will work until you recieve and AM TX after that it will continue to say TX disabled no matter what FRQ you are using. only way to resolve in most cases  is to reboot radio. Sometimes it will work after around a 30sec or so if NO AM has been recieved.

if it's set to '0', then it should always say TX DISABLED if you try and transmit on a channel/freq that is set to AM mode ?

TX on an FM band.. will work if no AM trans or no AM trans for quite some time.. BUt if there has been  an AM tran it will either take 20-30s before I can TX or will not let me till I reboot radio... Noticed it the other day but forgot to mention. To day was using K5 and was listeninig on AM  and FM  but could not trans on FM band when I needed

oh right, it wasn't letting you TX on an FM chan/freq .. okey doke

oh right, it wasn't letting you TX on an FM chan/freq .. okey doke

It used to work.. so it is a recent thing(I think lol)

I did recently edit that bit of code, I'll go look in a bit, doing too many things at once at the mo

I did recently edit that bit of code, I'll go look in a bit, doing too many things at once at the mo

LOL thats what happens when you have possible the best FW for the K5/6 range lol
Whilst it is import, Just take your time buddy..  I can work with it for now...

:)
I think I've fixed it, let me know if not

:)
I think I've fixed it, let me know if not

stows as TXing but nothing is actually happening

I don't suppose you can do a quick video ?

I don't suppose you can do a quick video ?

just flashing stock.27

confirmed the issue is still on .27  I suspect it possiblydue to switching modulation from FM to AM and back.. so possible not fixable

slightly offtopic but just been posted in telegram grou
Bricky, [28/09/2023 19:06]
Think I noticed a mistake in 1o11's lower squelch-1 code. The close RSSI is bigger than the open when it's not airband. Changing it to be smaller makes my radio closer to what my stock 5R picks up.
Bricky, [28/09/2023 19:07]
I'm glad I have a supermarket warehouse nearby to test it out. Spent way too much time trying to make it better.

The NOISE and GLITCH squelch setting are the inverse of the RSSI squelch.
so ..
Lower RSSI value = more sensitive squelch.
Higher NOISE value = more sensitive squelch.
Higher GLITCH value = more sensitive squelch.

Not sure if I'm missing something but I can't reproduce this on latest git build.

Not sure if I'm missing something but I can't reproduce this on latest git build.

set chan 1 to AM band
now set chan to to any FM   (You can switch the chans it makes no dfference)
Make sure your TX chan is the Fm one
Now trans
Now try trans  during or jjst after an AM RX
it will fail  and it will either continue to fail(warning text states TX disabled)  or after a 10-20 seconds you can TX again providing you had not RX any further AM band

Is Dual-RX (Dual Watch) enabled, and if it is, which is set to the main one (solid black little triangle marker) ?

Is Dual-RX (Dual Watch) enabled, and if it is, which is set to the main one (solid black little triangle marker) ?

For me with or withot dual watch it happens. the main channel wil always be FM for trans(Black triangle) I never trans on AM band... I have a proper HT for that

The radio does as you say if dual-watch is enable, when stops on the AM channel thats when the TX is disabled when you try to transmit.
If I disable dual-watch, the 'problem' vanishes because you will always transmit on the FM channel.

I'll have to see how the original QS firmware operates.

I'll have to see how the original QS firmware operates.

Actually stated it is the same (see above)

I can't reproduce this when dual-watch is disable :(

I can't reproduce this when dual-watch is disable :(

hmmmmmmmmmmmmmm odd but ok..

Is Dual-RX (Dual Watch) enabled, and if it is, which is set to the main one (solid black little triangle marker) ?

For me with or without dual watch it happens. the main channel wil always be FM for trans(Black triangle) I never trans on AM band... I have a proper HT for that

Try it now, just uploaded

Try it now, just uploaded

Given the AM issues on current FW's  for me I am now using older comps, So even though there is the issue (but not a major one) I don't use newer builds....

okey doke

I don't use DW, might be why I couldn't reproduce. Will try after the compile errors are fixed.

There is still a slight problem with TX'ing when dual-watch is enabled. I'll find the bug, just trying to chill today, so being lazy :)


Security advisories fixed in version 26

There was one security vulnerability in 25.0 (and below) fixed in 26 (and 25.1). Thanks to Greg Sanders for writing up the advisory.
This is the last batch of historical disclosures. From now on we'll publicly disclose reported disclosures as per the policy.

self-ACK

Addressed @murchandamus's suggestions. Thanks for the close review.

ACK https://github.com/bitcoin-core/bitcoincore.org/pull/1080/commits/834800040d0ddb1213542a5b271df65c1cf2721d


Brotli: Don't leave errors behind if loading library failed.

If brolti support is dynamic then it is loaded at runtime and may fail if the library is not available. The library can be loaded even if the user did not ask for it, for instance via SSL_CTX_new_ex() -> ossl_comp_has_alg().
Leaving an error record can have other side effects if the user is poping the stack and notices and aborts due it.
Use ERR_set_mark()/ ERR_pop_to_mark() to avoid leaving marks if library loading failed.
Fixes: #23558

On 2024-02-13 19:04:25 [-0800], Shane wrote:

This doesnt seem quite right since
(1) The brotli code for loading was based off the other files i.e zlib
and zstd which have almost identical code, so applying the change to
just 1 seems inconsistent

I am aware of this and mentioned in #23558 that I would follow up on the
other two once we settled on something here.

(2) In the case where it returns 0 it should not be removing errors,
if it does it in the case where it returns 1 then that is ok. (So you
would need to use clear_mark).

I'm not following here. In ossl_comp_brotli_init() I'm setting a marker
and before return (regardless if sucessfull or not) I'm clearing the
marker again. So the error code is no leaking to the caller.
If I am not removing any errors that occured in the process, why do it?

(3) Depending on (2) it may indicate that this is not the appropriate
place to do the error handling (it may be that the caller i.e.
ossl_comp_alg() is a better place to handle this).

That is probably the debate.
Pushing the mark/clear to ossl_comp_has_alg() would require to audit
more places wheather or not an error is okay or not and
ossl_comp_has_alg() has no idea either so it will its caller. That would
not only require touch more users but also do this push/pop thingy each
time the request happens. Doing it in ossl_comp_brotli_init() (and for
the other algos, too) would limit it one invocation only and only if it
is really needed.
Also if brotli is not enabled at build-time, then there will be no error
at all.
Sebastian

What I was trying to indicate was - A function MAY return an error on the error stack if it fails (returns 0), but it should not return something on the error stack if it passes (returns 1).
If a caller ignores the return result being zero then that is where the issue is.
If the error stack is not useful in ANY situation where it can be called from then your approach would be ok.

On 2024-02-14 14:59:59 [-0800], Shane wrote:

What I was trying to indicate was - A function MAY return an error on
the error stack if it fails (returns 0), but it should not return
something on the error stack if it passes (returns 1).
If a caller ignores the return result being zero then that is where
the issue is.
If the error stack is not useful in ANY situation where it can be
called from then your approach would be ok.

I think I understood. Let's see ;)
Sebastian

hold on for a sec

okay, all good.

Do the above changes address your problem?

On 2024-02-15 16:21:16 [-0800], Shane wrote:

Do the above changes address your problem?

Yes.
Sebastian

On 2024-02-16 07:59:32 [-0800], Tomáš Mráz wrote:

@t8m requested changes on this pull request.
You have the ERR_pop_to_mark() and ERR_clear_last_mark() inverted. The
mark needs to be cleared if we are returning an error from the
functions. But errors need to be popped out of the queue up to mark if
we are returning success.

No, this doesn't work then.
SSL_CTX_new_ex() -> ossl_comp_has_alg() asks for all compressions. I
have selected brotli-dynamic at compile time and libbrotli is not
installed. So DSO_load() fails rightfully and SSL_CTX_new_ex() does not
not return an error. And then dovecot notices later an error on stack
and aborts. Supressing the error here avoids the problem. Doing it as
you suggested "leaks" the error again.
Sebastian

No, this doesn't work then.

Then this is a wrong fix and something else must be done because clearing the error stack and returning an error return (0) is wrong. The error stack cleanup must be done at some further level up where the error returned is being ignored.
Or, alternatively, we should never return 0 from these init functions.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is waiting for the creator to make requested changes but it has not been updated for 30 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 61 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR has been closed.  It was waiting for the creator to make requested changes but it has not been updated for 90 days.


Require zone arg if no default set (fixes #2191)

On second thought, this doesn't really fix the problem (or do anything of use) and this kind of problem should be fixed at argument-parsing time - something that I think would be better addressed with the provisioner refactor.


Fix issue with images not rendered inside a tabnav, in Safari

Bug/issue #, if applicable: 105363672
Summary
This fixes a bug where images are not rendered inside tabnavs, for Safari only.
This only happens if the image is a display: block, and has some element before it. Really strange, but removing the loading: lazy fixes it.
Dependencies
NA
Testing
Compile and try with this:
@TabNavigator{
  @Tab("Image With Title"){
    **Strong Title**

    @Image(source: example.png)
  }
  @Tab("Image with Caption"){
    @Image(source: example.png){ Some text as a placeholder }
  }
}

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

I think we could potentially take these changes as a workaround, but I'm wondering if there's a simpler problem happening here.
It looks like the overflow: hidden rule from the .tabs-content-container element is the main thing preventing the image from being loaded. If I uncomment that one style, the image loads as expected—since it is technically overflowing, it seems like Safari is the only browser considering the image as not being visible and thus not loading it since we're using the lazy loading strategy.
Can you remind me if that rule is strictly necessary and what scenario it prevents? I'm sure there is one, just curious if it might be better to consider a solution at the CSS level for this or not.

When switching between tabs, there is a slight transition.
When sections have different heights, for example you go from a long section to a short section, the overflow rule ensures the long section does not spill out into the next elements, below the tabnav.
This would not be an issue if there is no animation at all, but since for a brief moment both sections are visible at the same time, one is absolutely positioned while the other takes the space it needs.

@swift-ci test

@swift-ci test


Player view not presented , only audio

I have an app where I need to present mediaplayer from modal viewcontroller which is placed in UITabViewController, when I do so, the player view isn't presented and the audio only work and this warning is presented
Warning: Attempt to present <MPMoviePlayerViewController: 0x16b68d70> on <EventsTabBarController: 0x156dc960> whose view is not in the window hierarchy!

I have figured out the problem, in my case my rootviewcontroller is a UITabbarViewController, but the view controller that is used to fire up the movieplayer is a modalviewcontroller which is presented above the UITabbarController.
The problem is YKMediaPlayerKit is calling the root of the window and not the visible one which cause this issue when this is called
    [[UIApplication sharedApplication].keyWindow.rootViewController presentMoviePlayerViewControllerAnimated:self.player];

My workaround was to change the above line to the following
    [[self topViewController] presentMoviePlayerViewControllerAnimated:self.player];

#pragma mark - Get topMost viewController
- (UIViewController *)topViewController{
    return [self topViewController:[UIApplication sharedApplication].keyWindow.rootViewController];
}

- (UIViewController *)topViewController:(UIViewController *)rootViewController
{
    if (rootViewController.presentedViewController == nil) {
        return rootViewController;
    }

    if ([rootViewController.presentedViewController isMemberOfClass:[UINavigationController class]]) {
        UINavigationController *navigationController = (UINavigationController *)rootViewController.presentedViewController;
        UIViewController *lastViewController = [[navigationController viewControllers] lastObject];
        return [self topViewController:lastViewController];
    }

    UIViewController *presentedViewController = (UIViewController *)rootViewController.presentedViewController;
    return [self topViewController:presentedViewController];
}

Which call the presentation on the visible top most view controller

worked ! thanks a lot


enter key submits instead of breaking the line

In some apps (e.g. slack) pressing enter (the bottom quadrant) sends the message, instead of introducing the line break. Other keyboard (builtin, FUTO, etc) don't have such behaviour. It is not universal accross apps (e.g. in Signal it does introduce line break as expected), so maybe it is slack shenanigans, but other keyboards somehow are not affected, so it puts 8vim at disadvantage (i have to switch to other keyboard to compose anything longer than one line). Ctrl and Fn modifier are not the reason (toggled them on and off in all combinations).

OS: android
Browser: no browser, official slack app
Device: Pixel 7

Same in unexpected keyboard: https://github.com/Julow/Unexpected-Keyboard/issues/822


Fix Makefile

Fix makefile to allow program to be installed cleanly

The author has made these changes in the devel branch. Considering closing this PR @cass-e-design ?

Happily, thanks


Missing records

None of the items that were uploaded in the last batch are showing up in the backend currently. It was about 39 items. I was trying to just unpublish and delete 4 of them. The others all show on the front end and worked as of late week.
Content is not showing up in DB or admin index.  Showing up in public index only.

Records were indeed in the DB, but failed to index into the new ES cluster.  The index timer has been throttled up to 250ms per record.


Fixes #557 - Improves Daemonset Node Selector

Description
This PR makes improvements to specifying the nodeSelector based on oddities QE noticed on BZ 1853534:
Some observations so far:
When you specify the nodeSelector in the MigrationController CR Ansible is replacing dashes in the key with underscores. node-role becomes node_role, which is not a valid DNS-1123 name.
When you specify a value of true or false we get hung up because the value needs to be sent as a string and not a bool.
node-role.kubernetes.io/master=true or node-role.kubernetes.io/worker=true do not work for me at all. It looks like it should be as you found node-role.kubernetes.io/worker='', which will schedule.
By supplying it as a string you were overcoming all of these issues.
After dealing with the above I did not encounter a problem with:
topology.kubernetes.io/zone: us-east-1b
I can successfully define the daemonset_node_selector like so:
spec:
  daemonset_node_selector:
    node-role.kubernetes.io/worker: ""
    topology.kubernetes.io/zone: us-east-1b

Instructions on how to use this parameter have been added, especially since removing selectors is counterintuitive.
Check each of the following when appropriate to help reviewers verify work is complete.
Modifying an existing version

[ ] I modified operator permissions in the OLM CSV and operator.yml
[ ] I modified the operator deployment in the OLM CSV and operator.yml
[ ] I modified operand permissions in the OLM CSV and ansible role
[ ] I modified CRDS in the OLM CSV and ansible role

Adding a new release version

[ ] I created a new z release directory in deploy/olm-catalog/konveyor-operator
[ ] I updated channels in the konveyor-operator.package.yaml
[ ] I created a new release directory in deploy/non-olm
[ ] I created or updated the major.minor link in deploy/non-olm
[ ] I updated the spec.skips parameter in the CSV

The snake case conversion is actually coming from ansible-operator not ansible itself.
There is a workaround:
https://github.com/operator-framework/operator-sdk/issues/1770#issuecomment-573022243

Documentation for the _cs_spec parameter such as it is https://sdk.operatorframework.io/docs/building-operators/ansible/development-tips/#extra-vars-sent-to-ansible


CSL Noble Aviation B738

🔗 Upload or paste a link to the CSL file(s) that you want me to add.
https://drive.google.com/file/d/1Mrn9OSith3RIx_HAzoj0AA3Vtrf5muZV/view?usp=sharing
⚠ I need you to provide the files, as I do not make them myself. I will only add files that are repaints of models that are already in the package.
🛑 You grant me a license to redistribute the files, and you affirm that you have the legal right to grant that license under copyright law.
yes
✈ Write here the corresponding aircraft and airline ICAO codes.
aircraft code: B738
airline ICAO: NOA

Name of Model: Boeing 738 with winglets
Name of Livery: Noble Aviation Special Livery
Name of Airline: Noble Aviation
The ICAO Code for the airline: NOA
Your name and email: Christoph Diem<EMAIL_ADDRESS>The name and email of the painter: Tony Vann, BRAVO 737<EMAIL_ADDRESS>Any airplaine specific data needed: Standard B738 with winglets and cfm53 engines
Contact informatoin of author/painter:
Tony Vann, BRAVO 737
email<EMAIL_ADDRESS>web: http://www.BRAVO737.com

NOA.CSL Package.zip

FYI.
In the X-CSL pack are 3 Noble Aviation CSLs with NOB as ICAO code.
I can add them in the DB with an NOA code.

Hi Mat
This one is ready to go in BB\BB_Virtual
BB_Noble_Aviation_VA.zip

Thanks for the information!


Update aws-java-sdk-core to 1.12.385

Updates com.amazonaws:aws-java-sdk-core from 1.12.336 to 1.12.385.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #199.


CMO: Bug: Update View modal is not triggered on the shipment that was canceled

Do not start yet.  I still have to check the steps.
Steps:

SPO: Create Order
CMO: Review it and remain on the page
SPO Approve the order
CMO: Click Update View
CMO: Click Prepare Shipment - > Click View Shipment
SPO: Cancel Shipment & Order
Nothing happens on the Single Shipment view and the user still can click on the Scan Shipment.

reviewing is no longer available


Propagator solvers are cached on slighlty changing delta_t

Both the sesolve and mesolve propagator solvers are cached on the time step delta_t to take, which should be constant for linearly spaced t_save. Thus, the propagator should be computed only once. However, due to numerical imprecisions, the delta_t changes slightly even when t_save is linearly spaced, resulting in frequent recomputations of the same quantity.

For example for t_save = np.linspace(0.0, 0.1, 11), adding a print statement in the base Propagator class we see the uneven spacing:
0.0
0.1
0.1
0.10000001
0.099999994
0.099999994
0.100000024
0.099999964
0.100000024
0.099999964
0.100000024

But the caching works well, if we add a print statement in mesolve propagator, we see that the value for a time spacing of 0.1 is correctly cached.
0.0
0.1
0.10000001
0.099999994
0.100000024
0.099999964
0.100000024
0.099999964
0.100000024


az container exec in azure devops throws (25, 'Inappropriate ioctl for device')

Az version 2.3.1
Describe the bug

When trying to use Azure DevOps Pipelines Azure CLI task az container exec the shell outputs errors.
To Reproduce

az container exec --resource-group myRG --name myImageName --exec-command ./run.sh
Expected behavior

To be able to display the output of the container.
Environment summary

Azure Devops free agent running Ubuntu 18.04
Additional context

This error message is thrown:
 [command]/bin/bash /home/vsts/work/_temp/azureclitaskscript1588671209398.sh
 The command failed with an unexpected error. Here is the traceback:

 (25, 'Inappropriate ioctl for device')
 Traceback (most recent call last):
   File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 215, in invoke
     cmd_result = self.invocation.execute(args)
   File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 625, in execute
     raise ex
   File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 689, in _run_jobs_serially
     results.append(self._run_job(expanded_arg, cmd_copy))
   File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 682, in _run_job
     six.reraise(*sys.exc_info())
   File "/opt/az/lib/python3.6/site-packages/six.py", line 693, in reraise
     raise value
   File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 659, in _run_job
     result = cmd_copy(params)
   File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 324, in __call__
     return self.handler(*args, **kwargs)
   File "/opt/az/lib/python3.6/site-packages/azure/cli/core/__init__.py", line 531, in default_command_handler
     return op(**command_args)
   File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/container/custom.py", line 621, in container_exec
     _start_exec_pipe(execContainerResponse.web_socket_uri, execContainerResponse.password)
   File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/container/custom.py", line 655, in _start_exec_pipe
     oldtty = termios.tcgetattr(sys.stdin)
 termios.error: (25, 'Inappropriate ioctl for device')

 To open an issue, please run: 'az feedback'

Was there any progress on this issue?

@peturh This issue only seems to occur when executing az container exec from an Azure CLI task on an Ubuntu Agent.  These tasks succeed (or at least do not fail from an ioctl error) when run from a vs2017-win2016 agent, which may serve as a workaround.

@peturh This issue only seems to occur when executing az container exec from an Azure CLI task on an Ubuntu Agent. These tasks succeed (or at least do not fail from an ioctl error) when run from a vs2017-win2016 agent, which may serve as a workaround.

That stopped the ioctl error, however, now the logs are cut of half way. Any idea?

Is there any movement on this issue (and linked here)? I'm still seeing it in ubuntu-latest (I think it is 20.04) and az version 2.16 in the agents... Is there any other workaround?
BTW same commands issued from my local computer's shell work well...

Is there any movement on this issue (and linked here)? I'm still seeing it in ubuntu-latest (I think it is 20.04) and az version 2.16 in the agents... Is there any other workaround?
BTW same commands issued from my local computer's shell work well...

Any news?

container instance service team should look into this

tagging appropriate person for followup! @macolso

I get a similar error when running az container exec using the Azure/CLI Github action (https://github.com/marketplace/actions/azure-cli-action)
ERROR: The command failed with an unexpected error. Here is the traceback:
ERROR: (25, 'Not a tty')
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 657, in execute
    raise ex
  File "/usr/local/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 720, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/usr/local/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 691, in _run_job
    result = cmd_copy(params)
  File "/usr/local/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 328, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/usr/local/lib/python3.8/site-packages/azure/cli/command_modules/container/custom.py", line 624, in container_exec
    _start_exec_pipe(execContainerResponse.web_socket_uri, execContainerResponse.password)
  File "/usr/local/lib/python3.8/site-packages/azure/cli/command_modules/container/custom.py", line 658, in _start_exec_pipe
    oldtty = termios.tcgetattr(sys.stdin)
termios.error: (25, 'Not a tty')

@macolso - any update on this?

Still facing this error now.

In the end I emulated tty using the following
script --return --quiet -c "az container exec --resource-group myRG --name myImageName --exec-command ./run.sh'" /dev/null

This is still a problem even with Azure CLI 2.29.0 using Azure DevOps agent ubuntu-latest image. This issue has been open for over a year and a half and we still can't run 'az container exec' commands on linux.
As a workaround I will try to run the task on a windows agent but most of the steps need to run on a Linux agent so I will have to split this one out.

I noticed something strange about this, I can run container exec commands on my Ubuntu 20.04.3 LTS shell ok while I'm logged in via SSH. I only see this error when I try to schedule via cron.

@peturh Apologies for the late reply. Could you please confirm if you are still running into this issue ? Awaiting your reply.

Hi,
I don't have exactly the same error but it looks like it. On my pipeline with the ubuntu-latest hosted agent and with the az container exec command :
az container exec --resource-group $rgContainer --name $containerControllerName --exec-command $command
ERROR: The command failed with an unexpected error. Here is the traceback:
ERROR: (25, 'Inappropriate ioctl for device')
Traceback (most recent call last):
File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 231, in invoke
cmd_result = self.invocation.execute(args)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 658, in execute
raise ex
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 721, in _run_jobs_serially
results.append(self._run_job(expanded_arg, cmd_copy))
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 692, in _run_job
result = cmd_copy(params)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 328, in call
return self.handler(*args, **kwargs)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
return op(**command_args)
File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/container/custom.py", line 637, in container_exec
_start_exec_pipe_linux(execContainerResponse.web_socket_uri, execContainerResponse.password)
File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/container/custom.py", line 673, in _start_exec_pipe_linux
old_tty = termios.tcgetattr(stdin_fd)
termios.error: (25, 'Inappropriate ioctl for device')
To open an issue, please run: 'az feedback'
The command work perfectly on the azure cloud shell

I have this error on 2.34.1 az cli version
azure-cli                         2.34.1 *

core                              2.34.1 *
telemetry                          1.0.6

Dependencies:
msal                              1.16.0
azure-mgmt-resource               20.0.0

@navba-MSFT this is still an issue, please reopen this issue.

We had the same yesterday, a project with the exact same setup on azure devops.

I've just had the exact same issue yesterday, using az containerapp exec

Same issue here!

Why is this issue closed?

Same issue here

Faced the same issue and managed to work around it by switching to Invoke-AzContainerInstanceCommand

Still seeing issue

only way I could get this to work at all was using ubuntu-latest image on azure pipeline, and thanks to @gary-x0pa's answer above. Previously had setup linux vm and had used ntfy to trigger post commands but was unable to get past that even with  script --return --quiet
- task: AzureCLI@2
  displayName: 'Run Post-Install Script in Container'
  inputs:
    azureSubscription: 'EdgeService'
    scriptType: 'bash'
    scriptLocation: 'inlineScript'
    inlineScript: |
      script --return --quiet \
        -c "az container exec \
            --resource-group group_name \
            --name $(imageName) \
        /dev/null

Getting this issue running against container app on an azure devops Ubuntu 22.04 agent
 az containerapp exec -n my-container -g my-rg   --command "./manage.py my_command"

Please ensure there is an alive replica.
Exception in thread Thread-1 (read_ssh):
Traceback (most recent call last):
  File "/opt/az/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
    self.run()
  File "/opt/az/lib/python3.11/threading.py", line 975, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/az/lib/python3.11/site-packages/azure/cli/command_modules/containerapp/_ssh_utils.py", line 123, in read_ssh
    _resize_terminal(connection)
  File "/opt/az/lib/python3.11/site-packages/azure/cli/command_modules/containerapp/_ssh_utils.py", line 154, in _resize_terminal
    size = os.get_terminal_size()
           ^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 25] Inappropriate ioctl for device
ERROR: The command failed with an unexpected error. Here is the traceback:
ERROR: (25, 'Inappropriate ioctl for device')
Traceback (most recent call last):
  File "/opt/az/lib/python3.11/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
             ^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
    mode = tcgetattr(fd)
           ^^^^^^^^^^^^^
termios.error: (25, 'Inappropriate ioctl for device')
To check existing issues, please visit: https://github.com/Azure/azure-cli/issues

I'm trying to
az containerapp exec --subscription subscription -g group -n name --command "cat /etc/hosts" >> test.log and it fails...
Exception in thread Thread-1 (read_ssh):
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 1045, in _bootstrap_inner
    self.run()
  File<EMAIL_ADDRESS>line 982, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/command_modules/containerapp/_ssh_utils.py", line 123, in read_ssh
    _resize_terminal(connection)
  File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/command_modules/containerapp/_ssh_utils.py", line 154, in _resize_terminal
    size = os.get_terminal_size()
           ^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 25] Inappropriate ioctl for device


when user is on ropstern, the ETA is taken from mainnet

When I am on ropstern, the with the default gas it showed around 300 mins ETA.
So I clicked OK anyway thinking I can wait 5 hours.
Then it gets included in the blockchain in 1 minute.
This hint that perhaps the ETA is taken from the mainnet, not the current (ropstern)
recommend: If you don't have a reliable ETA for ropstern, make ETA go away except for the chains you have ETA.

@JamesSmartCell if you can confirm my guess is right (that ETA is only for mainnet), consider passing this issue to Chintan


Not showing lines between \n separated lines

is there is a way to solve the discountinuity in the lines as shown above ?
also why the code structure must be perfectly right for the plugin to work at all, in other words i use a code prettifier coc-prettier in order to bringe the code to the right shape and only then indentLine starts to make sense where to put the indent lines.
is there is any way so that the indentLine shows the indentation lines regardless of the code structure?
( Note : VSCode is perfectly capable of doing that ), this is really helpfull to spot some missing opening or closing tags or brackets here and there.
Amazing plugin BTW @Yggdroot, appreciated.
Any help is much appreciated.

IndentLine shows indent lines according to shiftwidth and tabstop, if you are not satisfied with the place showing the indent lines , it is probable that you don't set the value of shiftwidth properly.
the discountinuity can not be solved.

thanks alot for the replay @Yggdroot,
as for the discountinuity issue I guess I've found a way around it, simply by filling in the new lines with spaces as needed.
here is an example :

before :

After :

however am not entirely sure how to implement such thing, since am not into vim plugins scripting; I genuinely think that I'ts doable so I might possibly give it a try using some sort of a bash / python script.
and it would be amazing if this can be done right in indetLine plugin.
Best regard

the discountinuity can not be solved.

The indent-blankline.nvim plugin cleverly uses Neovim's virtual text feature to render indent markers on blank lines. This is a Neovim only feature.
@xradiation, I would not recommend inserting spaces, check out the indent-blankline.nvim plugin in combination with Neovim.
P.S. I have no affiliation with the indent-blankline plugin.

well, it's kind of strange that I've actually never heard of this plugin before, but I guess here we go.
am really greatful @bluz71 for your suggestion, it does exactly what I wanted to do :

however, as it seems in lines +1 & +8 at the second and fourth columns respectively, the plugin has some strage "bug" where it's not supposed to render indent lines, any ways it's just a little thing that I can live with for now.
I really hope that @Yggdroot will merge this plugin, if possible that is.
again really appreciated you help @bluz71 , @Yggdroot .


Workaround hack so it can be used from an external crate

This is a small hack to make it usable from a different crate. Without this the build fails as it can't find libminiz_oxide when added as a dependency.
I used this to see how it compared, so I thought it might be useful.

Thanks, it is useful.


Add a global disable for Hugo

The scenario I am concerned about is unit testing on the PC using the new unit testing support in the gradle plugin. Unit testing a method with @DebugLog is very difficult. I ended up having to use PowerMock to mock some static methods in Looper and the Log.d method itself. Would be a lot handier if I could just set a static somewhere to turn off Hugo.

#93.


Error in usage of k commands

When I'm executing any of "k web", "k gen" or "k ef" i get the following errors

I can't figure out what the problem could be, I'm executing the commands on a fresh new Web Site Asp.Net 5 template.
Not being able to use these command is greatly reducing my developement speed, especially for the inabilty of applying migrations.
Thank you
Giacomo

All the k commands are renamed: https://github.com/aspnet/Announcements/issues/4.

So in order to use command line scaffolding what should I do?

dnx . ef

You need the new runtime as well. See the readme.

thank you very much @henkmollema , really appreciate, keep up the good work and have a wonderful day!

Welcome! :+1:


Update some dependency versions

In new rsa version, VerifiyingKey::new_with_prefix is deprecated, so update that as well

okay, merged.


[fix][client] fix producer/consumer perform lookup for migrated topic

Motivation
Right now, during blue-green cluster migration, broker sends redirect url of green cluster to the client and producer/consumer tries to reconnect with new URL to create producer or subscribe consumer. However, it doesn't perform lookup so, if topic is not loaded on the green cluster then green cluster never perform topic assignment and client will keep seeing below error that topic is not owned by the new cluster
2023-05-16T18:23:16,859-0700 [pulsar-client-io-1-1] WARN  org.apache.pulsar.client.impl.ClientCnx - [id: 0xb4862e31, L:/<IP_ADDRESS>:63224 - R:localhost/<IP_ADDRESS>:6652] Received error from server: Namespace bundle for topic (persistent://migration-test1/ns1/t1-2) not served by this instance. Please redo the lookup. Request is denied: namespace=tenant/ns1

Therefore, client should perform topic-lookup with the new green-cluster URL by having a lookup-service created for green-cluster URL and perform lookup with new broker and successfully create producer/consumer with new broker that owns the topic.
Result
Client will be to reconnect producer/consumer to the new broker in green cluster once topic is migrated from blue cluster.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report

Merging #21356 (50ce42c) into master (1a352f1) will increase coverage by 39.29%.
Report is 2 commits behind head on master.
The diff coverage is 40.00%.

@@              Coverage Diff              @@
##             master   #21356       +/-   ##
=============================================
+ Coverage     33.49%   72.78%   +39.29%
- Complexity    12257    32529    +20272
=============================================
  Files          1636     1876      +240
  Lines        127789   140116    +12327
  Branches      13963    15443     +1480
=============================================
+ Hits          42798   101980    +59182
+ Misses        79372    30067    -49305
- Partials       5619     8069     +2450

Flag
Coverage Δ

inttests
24.14% <5.00%> (-0.01%)
:arrow_down:

unittests
72.54% <40.00%> (+40.53%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...g/apache/pulsar/client/impl/ConnectionHandler.java
86.23% <16.66%> (+15.48%)
:arrow_up:

...rg/apache/pulsar/client/impl/PulsarClientImpl.java
74.48% <50.00%> (+14.90%)
:arrow_up:

... and 1501 files with indirect coverage changes


Split model into a separate module

Do you want to request a feature or report a bug?
Feature / proposition
I found that this was already suggested two years ago https://github.com/facebook/draft-js/issues/26, but maybe discussion could be re-opened.
What is the current behavior?
I am currently implementing a native input based on the draft model for react native and I have to import everything separately :
import EditorState from "draft-js/lib/EditorState";
import convertToRaw from "draft-js/lib/convertFromDraftStateToRaw";
import convertFromRaw from "draft-js/lib/convertFromRawToDraftState";
import ContentState from "draft-js/lib/ContentState";

What is the expected behavior?
import { EditorState, convertToRaw, convertFromRaw, ContentState}  from "draft-js-model";

I think that separating the model from the browser components would have two other benefits :

help newcomers better understand how draft works (documenting the raw data model for persisting),
lead to a wider range of use cases.

Hi @maxaggedon, thanks for your interest in Draft.js and for bringing this up. I see @hellendag envisioned splitting the model into a separate package or at least making it easier to cherry pick. In fairness I prefer the former approach, as it would enable a number of scenarios e.g. plugging in different implementations of the model in the editor. A number of internal and external users would like to remove a dependency on immutable and rely on lightweight typechecker enforced read-only structures. Let me bring this up for discussion with the other maintainers.

Hey @claudiopro, has this been discussed amongst maintainers ?


Gauge FromColor and ToColor seems inverted

If I declare the following:
<lvc:Gauge Width="200" From="0" FromColor="Red" To="100" ToColor="Green" Value="10">
I expect the gauge will display a 18 degres (10% of 180 degres) red arc, but the arc is green.
Is it really the expected behavior?

No it is not, it really seems inverted, thanks for reporting!

The previous commit fixes this inverted color issue,
<IP_ADDRESS> will include this patch

Woa... that was fast.

Welcome to LiveCharts :smile:


Fixed typo in docs/releases/1.10.txt

The 'collectstatic' command doesn't have an option named '--ignore_patterns'.
It should be '--ignore' instead.

I combined this with https://github.com/django/django/pull/9010.


Conceptual mismatch in uSubscription service definition

Hi,
while reading through the uSubscription service spec I stumbled across sections 3.1. and 3.2 which seem to restrict the topics that the subscribers and publishers are allowed to receive change notifications for.
However, at the beginning of section 3 I found

The uSubscription service notifies observers when there is a change in a subscription states by publishing notification events to the topic up:/core.usubscription/2/subscriptions#Update.

In typical pub/sub implementations (like MQTT) you would expect that a subscriber to that topic will actually receive all messages being published to that topic. However, the spec seems to restrict the messages that subscribers are allowed to receive based on (internal) state like the list of topics that the client has created/subscribed to. I do not see how this kind of subscription filtering could be implemented using existing MQTT broker implementations.
In general, to me it seems that the way that the uSubscription service's behavior is defined in the spec does not match what is generally considered pub/sub but instead calls for a dedicated notification mechanism based on subscriber/producer specific topics.

Hi @sophokles73 , the subscription Update notification is a notification of changes to subscription states for subscribers (subscriber goes from SUBSCRIBED to UNSUBSCRIBED, etc...). This is used to handle remote subscriptions for a subscriber (to go from SUBSCRIBE_PENDING or SUBSCRIBED).
This notification is also used when say a producer only wants to produce events (because it is costly to the system), when subscribers subscribe. The producer will register for notifications for their topic and as soon as a subscriber is subscribed, the producer is notified and the events are then produced

AFAIK (and I'm happy to be corrected), even with other pub/sub solutions don't allow subscribers to be aware of subscriptions of other subscribers, only the broker (or producer) can be aware of the subscribers subscriptions. What we are saying is:

Subscriber is aware of all of their subscriptions
Subscription service (i.e. central broker) is aware of all subscriptions
Producer can be aware of all subscribers to topics it produces and NOT subscriptions to what other producers produce

Subscriber is aware of all of their subscriptions

This is what the spec says:

Subscribers MUST NOT call the RegisterForNotifications() as they are not permitted to receive notifications for subscription changes by other subscribers

Doesn't this mean that a Subscriber MUST NOT receive any updates to other clients' subscriptions (to other topics)? If this is the case then how could this be implemented based on a standard pub/sub message broker infrastructure (e.g. MQTT)?

Subscription service (i.e. central broker) is aware of all subscriptions

Are you implying that the Subscription service implementation is the central broker? Or even, that the central (MQTT) broker would need to implement the Subscription Service? Maybe this is the overall problem here. Standard message brokers will not be able to do this because of the conceptual mismatch regarding the general concept of pub/sub and the behavior defined in the spec which I tried to point out earlier.

Producer can be aware of all subscribers to topics it produces and NOT subscriptions to what other producers produce

This is what the spec says

(Producers) MUST NOT be permitted to call RegisterForNotifications() for topics they do not create through the CreateTopic(), only the topics they produce

This, of course, is easy to ensure at the API level. However, at the messaging infrastructure level this would, again, mean that the messages on the subscription update topic would need to be filtered per consumer. Again, AFAIK this kind of functionality is not available in standard message broker implementations ...

If we wanted to implement dispatcher + uSubscription using MQTT then there is are no notifications. MQTT has only SUBSCRIBE and SUBSCRIBEACK messages which would map to the uSubscription.subscribe() RPC flow.

Hmm, my understanding had been that the L3 uSubscription service is defined on top of the L2 uTransport. So regardless of the concrete transport implementation, there would always be a uSubscription service, or am I mistaken?

Ideally yes but it is not always the case (a standalone service) as we are learning trying to map uProtocol to Zenoh without loosing the benefits of zenoh.
Our existing transport implementations are not pub/sub protocols (binder, HTTP, MQTT described above) so uSubscription is a standalone service attached to homegrown event dispatchers (i.e. EventHub in Azure). When the transport is a pub/sub protocol, it gets tricky as the lines are blured for where uTransport ends and uSubscription begins. What always has to remain the same is:
a) The APIs used by uEs (how they talk to the uPlatforms through uLink libraries and the core uE APIs)
b) Functionality of the uPlatforms (ability to subscribe to local/remote topics, etc...)
b) Platform-2-Platform communication (through streamers)

a) The APIs used by uEs (how they talk to the uPlatforms through uLink libraries and the core uE APIs)

Ok, I guess we need to start being a little more precise when we refer to uEs. Let's use the Rust SDK as an example. My feeling is that my client code will always only depend on the functions of the UTransport trait, i.e. it will use send, register_listener etc in order to publish events and make RPC calls. However, this still allows my client to invoke operations of the Subscription service, doesn't it? The question now is: is there any need for my client code to do so? Is invoking the uSubscription service a required step? In the spec it looks like my client needs to invoke createTopic before it is allowed to/can publish events.
On the other hand, if I understand your earlier comment correctly, then my client code does not need to do that when using MQTT as the transport (because an MQTT broker implicitly creates an MQTT topic when a client starts publishing to it)?

I also had similar questions about the usage / role of uSubscription over here. Wish I would have seen this first. Perhaps we're asking the same kinds of things.
It seems to me from that other issue

Or worded differently, is the uSubscription more a means of ensuring that the topic we'd like to receive is active and healthy, and potentially being multicated into our uDevice? It doesn't handle actually publishing / receiving and that's handled by using uP-L1 in an application. Is that correct?

I have an additional questions in this context (not that we're done with the discussion so far, mind ;-) ):
Looking at usubscription.proto, specifically the EventDeliveryConfig.type and EventDeliveryConfig.attributes properties: do we maybe define the type and property names of some popular options somewhere centrally? I.e., what would we call a mosquitto-type EventDeliveryConfig?

a) The APIs used by uEs (how they talk to the uPlatforms through uLink libraries and the core uE APIs)

Ok, I guess we need to start being a little more precise when we refer to uEs. Let's use the Rust SDK as an example. My feeling is that my client code will always only depend on the functions of the UTransport trait, i.e. it will use send, register_listener etc in order to publish events and make RPC calls. However, this still allows my client to invoke operations of the Subscription service, doesn't it? The question now is: is there any need for my client code to do so? Is invoking the uSubscription service a required step? In the spec it looks like my client needs to invoke createTopic before it is allowed to/can publish events.
On the other hand, if I understand your earlier comment correctly, then my client code does not need to do that when using MQTT as the transport (because an MQTT broker implicitly creates an MQTT topic when a client starts publishing to it)?

uSubscription is used to manage (across devices) subscriptions
uTransport allows you to send & receive messages

Publishers call uSubscription.CreateTopic() to "register" their topic with the the subscription manager, then call uTransport.send() to publish their topic
Subscribers call uSubscription.subscribe() to communicate with the subscription manager that it wants to subscribe to a topic (local and/or remote), then calls uTransport.registerListener() to setup the pipe to receive the published events. uPClient implements the interface for a given uProtocol implementation and takes care of the platform (communication middleware) nuances that are different for MQTT vs zenoh vs Android Binder, etc...

I have an additional questions in this context (not that we're done with the discussion so far, mind ;-) ):
Looking at usubscription.proto, specifically the EventDeliveryConfig.type and EventDeliveryConfig.attributes properties: do we maybe define the type and property names of some popular options somewhere centrally? I.e., what would we call a mosquitto-type EventDeliveryConfig?

EventDeliveryConfig was a snowflake, pre-dating uTransport, requested by Cloud implementation of uProtocol to indicate where to consume the events (pull vs push in the car). We are reevaluating the need/use of this config as it could be handled within the uPClient library (and not exposed to the uE).

Ok that makes sense!On Jan 22, 2024, at 16:00, Steven Hartley @.***> wrote:
I have an additional questions in this context (not that we're done with the discussion so far, mind ;-) ):
Looking at usubscription.proto, specifically the EventDeliveryConfig.type and EventDeliveryConfig.attributes properties: do we maybe define the type and property names of some popular options somewhere centrally? I.e., what would we call a mosquitto-type EventDeliveryConfig?
EventDeliveryConfig was a snowflake, pre-dating uTransport, requested by Cloud implementation of uProtocol to indicate where to consume the events (pull vs push in the car). We are reevaluating the need/use of this config as it could be handled within the uPClient library (and not exposed to the uE).
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Can we close this issue?

Closing, please reopen if still needed


MAINT: prepare for SciPy 1.8.0rc4

backport the two merged PRs with a backport label

this needs to fix the remaining conda-forge PROPACK issues

@mckib2 I don't see a submodule change here? was the maintenance branch already ahead of main in that regard? Not sure I fully trust current submodule settings/situation, so good to double check we have the right submodule commit in use here (seems to be the latest one you can get locally).

cc @h-vetinari

I'm still slightly confused about how PROPACK related issues could remain at this point--my objective was to turn off (skip) all propack related tests in rc3 with the env variable--I still think some are not getting skipped properly as I noted in the rc3 backport PR

For the submodule business, it looks like that snuck in with the REL commit before this to bump to rc4, which wasn't really intentional (I thought we added a guard to make this harder to do...):

Anyway, the net result there is acceptable I suppose.

Things I still plan to check here:

scipy/sparse/linalg/tests/test_propack.py tests need to be skipping when USE_PROPACK is not set; I was convinced this was true already for test_svds, but never really understood why the skip was supposed to happen for test_propack.py, and indeed the segfault on OSX conda-forge seemed to happen in that set of tests (the MKL backport may solve this, but is orthogonal to the intention--those tests shouldn't be running at all unless the user opts in to use PROPACK at runtime); I'm almost certain that I'm going to restore the skip I wanted to add in the rc3 backport PR here: https://github.com/scipy/scipy/pull/15432 (using the environment variable, NOT the import check since we can always import)
.gitmodules submodule update machinery is consistent with main (more PROPACK patches may come for Windows support on maintenance branch, having this work reliably would be useful)

For remaining failures on conda-forge:

the first point above and the MKL patch here should prevent the segfaults in two ways for OSX + MKL
for Windows, conda-forge needs to turn off pythran, we gave up on trying to support binaries with pythran on Windows in the short term with distutils mysteries
for their aarch64 linux failure, it is a single test failure I haven't seen before, maybe they can vendor a patch to skip one test

This does what I want now re: PROPACK skipping. python runtests.py -t "scipy/sparse/linalg/tests/test_propack.py" -- -rsx doesn't run a single test when USE_PROPACK is not set. It properly runs 40 tests when USE_PROPACK is set.
I double checked the diff here--looks right to me. If CI passes, I will merge and proceed with the rc4 release.

Ok, two timeouts in CI are just the usual for this maintenance branch, so let's merge and hope we don't need a fifth rc.

1.8.0rc4 wheel builds are underway; I'm a little concerned about some activity I saw in the NumPy wheel repo related to MacOS Azure changes--perhaps there's a decent chance I'm going to have replicate the NumPy wheels patches as well.. (cc @charris ?).
This is the patch I may need to "mimic" for our wheels: https://github.com/MacPython/numpy-wheels/pull/149

well, the Azure MacOS jobs seem to be passing.. so maybe SciPy is "ok" for this for now...

So the mechanism is now working, but I'm now wondering if the environment variable shouldn't be called SCIPY_USE_PROPACK rather than USE_PROPACK...? Too late for 1.8.0, but just thinking out loud...

more encouragement to fix the problem and delete the variable entirely I suppose


Generate text from grammar

I have an EBNF grammar, I can use Lark to parse text according to the grammar spec. My question is, is there a way to go from a parsed AST back to pure text, using the grammar specs?

Hello, I have a basic question about the generated parse tree. For my understanding, the result of lark without the ast_utils(?) extension is a concrete parse tree (CST), right?
After all, the reconstruction example you have shared refers to the CST.
I have seen the other example to get an AST from CST.
For the reconstruction of the source code a conversion from CST to AST is not necessary at all or am I wrong?
Thank you.


Make spell patching more robust in the face of out-of-order execution

Currently it behaves in strange ways if the patch runs first. It should at least fail with an error in this situation, and ideally it should try to defer the patch so it can run after the core data has loaded.

This issue was moved to symposion/roll20-shaped-scripts#10


Statistics over repos, orgs and overall

Also fixes issue with incorrect internal and external contribution

Works as expected 👍


magic-wormhole: make usable with Python 3.12

Description of changes
magic-wormhole-mailbox-server, magic-wormhole-transit-relay

add setuptools as dependency, as pkg_resources is referenced at runtime
use meta.broken instead of disabled in order to make magic-wormhole usable with Python 3.12

magic-wormhole:

disable tests using magic-wormhole-mailbox-server and magic-wormhole-transit-relay when these dependencies are not available (Python 3.12)

nixos/magic-wormhole-mailbox-server:

use Python 3.11
adopt

fixes #325854
build failure in tahoe-lafs is caused by a different broken dependency
Result of nixpkgs-review run on x86_64-linux 1

4 packages marked as broken and skipped:

python312Packages.magic-wormhole-mailbox-server
python312Packages.magic-wormhole-mailbox-server.dist
python312Packages.magic-wormhole-transit-relay
python312Packages.magic-wormhole-transit-relay.dist

1 package blacklisted:

nixos-install-tools

4 packages failed to build:

tahoe-lafs
tahoe-lafs.dist
tahoe-lafs.doc
tahoe-lafs.info

10 packages built:

gnome-keysign
gnome-keysign.dist
magic-wormhole (python312Packages.magic-wormhole)
magic-wormhole.dist (python312Packages.magic-wormhole.dist)
python311Packages.magic-wormhole
python311Packages.magic-wormhole-mailbox-server
python311Packages.magic-wormhole-mailbox-server.dist
python311Packages.magic-wormhole-transit-relay
python311Packages.magic-wormhole-transit-relay.dist
python311Packages.magic-wormhole.dist

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 325951 run on x86_64-linux 1

4 packages marked as broken and skipped:

python312Packages.magic-wormhole-mailbox-server
python312Packages.magic-wormhole-mailbox-server.dist
python312Packages.magic-wormhole-transit-relay
python312Packages.magic-wormhole-transit-relay.dist

2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

4 packages failed to build:

tahoe-lafs
tahoe-lafs.dist
tahoe-lafs.doc
tahoe-lafs.info

10 packages built:

gnome-keysign
gnome-keysign.dist
magic-wormhole (python312Packages.magic-wormhole)
magic-wormhole.dist (python312Packages.magic-wormhole.dist)
python311Packages.magic-wormhole
python311Packages.magic-wormhole-mailbox-server
python311Packages.magic-wormhole-mailbox-server.dist
python311Packages.magic-wormhole-transit-relay
python311Packages.magic-wormhole-transit-relay.dist
python311Packages.magic-wormhole.dist

Thanks for taking a look at this so quickly! <3 Let me know if I can help with review/testing locally etc. :)


Optimizations

I have not found any place to ask general questions , so dropping them here..
UglifyJs
It is too slow for some reason, uglify using command line is 10 times faster then webpack.
Loaders
We can pass regular expressions to match file extension , why not specific file extension inside a directory.
loaders: [
        {
          test: /\.js$/,
          loader: 'some-loader'
       }
]

Can i pass something like core/*.js or 'core/app.js'

test is just a regular expression. You can do all the magic you want. Want you're asking for are glob patterns (which imho provide not enough flexibility in this situation)

No issues with that, later i was able to build better regExp , any thoughts on UglifyJs

Remove the use of sourcemaps when you're minifying and it will speed up.

@thetutlage Did generating sourcemaps explain the difference?

Closing. Feel free to open specific questions at Stack Overflow.


Project is not building

The error says Gradle JDK is not correct.

The error could be because a different Gradle JDK version than required.
Go to Android Studio Menu > Preferences > Build, Execution, Deployment > Build Tools > Gradle > Gradle JDK > set v11