fix(stable-results): Order results to protect against changing result…

… set ordering. Increase page size for better performance

:tada: This PR is included in version 1.0.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adds a script to run the tests

Code Pull Requests
Adds a simple script to run the tests. This avoids forgetting to use the latest Ludwig build.

@msaisumanth - add a section to the docs at the same time?


Cleaned up code and added some text to output

Added a user prompt for the number of people you want to pick.

Awesome, thanks @bahadasx !


Add Metrics Logging for Kruize Recommendations

Pull Request Description: Add Metrics Logging for Kruize Recommendations
Summary
This pull request introduces the KruizeNotificationCollectionRegistry class, which is responsible for logging and creating metrics for notifications related to Kruize recommendations. The class processes recommendation notifications at various levels (container, timestamp, term, and model) and creates appropriate counters using Micrometer.
Key Features

Class KruizeNotificationCollectionRegistry: This new class handles the collection and logging of recommendation notifications.
Constructor: Initializes the class with experiment name, interval end time, and container name.
Method logNotification: Logs notifications from ContainerData by iterating through its recommendation structure and creating counters.
Method createCounterTag: Creates a counter with tags for the given level, term, model, and list of recommendation notifications.

Detailed Description

Class KruizeNotificationCollectionRegistry:

This class is introduced to streamline the process of logging recommendation notifications and creating metrics.
It holds information about the experiment name, interval end time, and container name, which are essential for tagging metrics.

Constructor:

Initializes the object with necessary parameters: experiment_name, interval_end_time, and container_name.

Method logNotification:

Accepts a ContainerData object as input.
Iterates through the nested structure of recommendations within the ContainerData.
For each level (container, timestamp, term, model), it collects notifications and calls createCounterTag.

Method createCounterTag:

Accepts parameters such as level, term, model, and a collection of RecommendationNotification objects.
Checks if the notification type is configured to be logged based on KruizeDeploymentInfo.log_recommendation_metrics_level.
Creates additional tags using the provided information and formats them according to KruizeConstants.KRUIZE_RECOMMENDATION_METRICS.
Finds or creates a counter for the metric and increments it.

Benefits

Enhanced Observability: By logging metrics for recommendations, this feature improves the observability and monitoring of Kruize recommendations.
Granular Metrics: Metrics are logged at various levels, providing detailed insights into different aspects of the recommendation process.
Configurable Logging: Only logs notifications that match the configured logging levels, ensuring flexibility and control over what gets logged.

Notes

Ensure that the necessary dependencies for Micrometer and other related utilities are available in the project.
This PR addresses the need for detailed metrics in Kruize recommendations, aiding in performance monitoring and debugging.

Testing

Thorough testing should be conducted to ensure that the metrics are correctly logged at each level.
Verify that the counters are created and incremented accurately based on the incoming notifications.
Ensure that the tags are properly formatted and include all relevant information.

Related Issues

References to any related issues or enhancement requests can be mentioned here.

Please review the changes and provide feedback. Your input is valuable to ensure that this feature integrates seamlessly and functions as expected.
test Image : quay.io/vinakuma/autotune_operator:metrics

Would be good to include the overhead of the notifications in updateRecommendations API with a scalability run.

I agree , @chandrams we might need short scalability run for this... But please ensure each experiment creating at least one error or critical notifications.

@chandrams  this sample results json create some error notifications
https://privatebin.corp.redhat.com/?3b171fbe1bbb3244#8ZnjimR1QbfKUksj9qGZegAGCPMJUkhSFdidVvrmV3gv

@msvinaykumar - Updated the kruize metrics script to capture the notifications and I have triggered a short scalability run with the new image that you provided - quay.io/vinakuma/autotune_operator:metrics2 and the results json that you shared.

@msvinaykumar - The scalability 5k / 15 days run took 3 hrs 16 mins which is lesser than the scale test run on the same cluster with 0.0.22_mvp which was 3 hrs 50 mins.  Does your build contain all the latest changes along with this PR?
Summary of the test run
exp_count / results_count / reco_count = 5000 / 7200000 / 300000
Postgres DB size in MB = 21767
Results count - 7200000
total_kruizeMetrics-20.csv
Update Reco Latency Max / Avg value: 0.61 / 0.39
Update Results Latency Max / Avg value: 0.13 / 0.11
LoadResultsByExpName Latency Max / Avg value: 0.2 / 0.16
Generate Plots Latency Max / Avg value: 0.0 / 0.0
Kruize memory Max value: 33.11 GB
Kruize cpu Max value: 6.92
Execution time - 03:15:30

The logs have these errors
scaletest250-2.log:psql: error: connection to server on socket "/var/run/postgresql/.s.PGSQL.5432" failed: FATAL:  sorry, too many clients already
scaletest250-2.log:AN ERROR OCCURED: too many values to unpack (expected 2)

Summary of the test run with 0.0.23_mvp on the same cluster
Summary of the test run
exp_count / results_count / reco_count = 5000 / 7200000 / 300000
Postgres DB size in MB = 21760
python3 parse_metrics.py -d /home/jenkins/kruize_scale_test_results_0.0.23_mvp_5k_15days/remote-monitoring-scale-test-202406262204/results -r 7200000
Directory path - /home/jenkins/kruize_scale_test_results_0.0.23_mvp_5k_15days/remote-monitoring-scale-test-202406262204/results
Results count - 7200000
total_kruizeMetrics-20.csv
Update Reco Latency Max / Avg value: 0.63 / 0.39
Update Results Latency Max / Avg value: 0.24 / 0.17
LoadResultsByExpName Latency Max / Avg value: 0.35 / 0.25
Generate Plots Latency Max / Avg value: 0.0 / 0.0
Kruize memory Max value: 32.59 GB
Kruize cpu Max value: 4.52
Execution time - 03:51:01

@chandrams can you please confirm kruizeRecommendation_total counts

This error occurs when the PostgreSQL server has reached the maximum number of allowed client connections. we can increase the max_connections setting in your PostgreSQL configuration or optimize your application to use fewer connections. But however we can ignore this error
bcoz there is no data a loss
exp_count / results_count / reco_count = 5000 / 7200000 / 300000
we can consider this as warning

Build is having this PR change and please confirm we have generated enough KruizeRecommendations metrics

total_kruizeMetrics-20.csv
@msvinaykumar - You can check the last column in this spreadsheet, was expecting values to be present for all entries but it stopped after a while.

total_kruizeMetrics-20.csv
@msvinaykumar - You can check the last column in this spreadsheet, was expecting values to be present for all entries but it stopped after a while.

This looks good. The count is over 500k, so the idea is to generate more notifications without impacting execution time. Based on the results, performance is unaffected, so we're good to proceed. We also have a flag to disable it just in case any issues arise.


UltraNest support

Would you be interested to add support for https://johannesbuchner.github.io/UltraNest/ ?
The interface should be very similar to dynesty.
UltraNest is a very reliable tuning-parameter-free algorithm. It can be faster than dynesty, especially if you take advantage of vectorization.
It also supports resuming from disk and MPI parallelisation, if that is useful to you.

I would be interested, especially if the uncertainty estimates could be more reliable. This package is still bottlenecked by the runtime of the underlying fortran program, so the speed advantages are probably hindered by that. I'll look into it.


Remove environment store

What this PR does / why we need it:
This is a part of removing the Environment concept from PipeCD project. I planned to do it later but looks like we have to do extra work for keeping this unused store, so I remove the EnvironmentStore and every place where its interface is used. The Environment model and APIs related to that model still exist and will be removed later.
Which issue(s) this PR fixes:
Part of #3221
Does this PR introduce a user-facing change?:

NONE

Before this, I think we have to remove it from pipectl and piped to ensure that no one is using any RPC related to it.

That's true, lets me hold this pull and remove environment-related parts in pipectl and piped first.
/hold

Since PR #3229 is merged, and there is no place that calls Environment-related gRPC directly from pipectl source, I think it's safe to un-hold this pull, PTAL when you guys have time @nghialv @knanao
/hold cancel

/hold cancel

/rebase

Looks good!
/lgtm

Since PR #3229 is merged, and there is no place that calls Environment-related gRPC directly from pipectl source, I think it's safe to un-hold this pull, PTAL when you guys have time @nghialv @knanao

I think we still have to hold this PR. The #3229 is merged but it is not being released yet. That means our users still using the old Pipeds.
Once this PR got merged, all old Pipeds will face the error due to the lack of those gRPC implementations. So we have to wait until all our users move their Pipeds to the upcoming version first.
What do you think?

Oh, I got you. That's make sense.

Since PR #3229 is merged, and there is no place that calls Environment-related gRPC directly from pipectl source, I think it's safe to un-hold this pull, PTAL when you guys have time @nghialv @knanao

I think we still have to hold this PR. The #3229 is merged but it is not being released yet. That means our users still using the old Pipeds. Once this PR got merged, all old Pipeds will face the error due to the lack of those gRPC implementations. So we have to wait until all our users move their Pipeds to the upcoming version first. What do you think?

oops, I get your point. Mostly, the environment-related removed code from piped source is used by notification feature, but for older version piped, it may have something more than that, it's safer to ensure at least all our direct customers update their Piped to the latest version (the one that not yet being released). Tbh, I make this PR cause I don't want to keep this unneeded EnvironmentStore as part of the server code before I start refactoring API's stub, but looks like there is no another way for that. I'm thinking about closing this pull and refactoring EnvironmentStore (remove UpdateEnvironment function) as I did with others, wdyt 🤔

I will close this since there will be a lot of conflicts until this is merged (we have some already, lol). Will open another later when we are ready to remove the Environment concept on the server side.
/close


Microsoft.Resources/checkResourceName/action is not defined in swagger

There is no swagger definition for POST /providers/Microsoft.Resources/checkResourceName

Swagger Updated in this PR: https://github.com/Azure/azure-rest-api-specs/pull/9185


Feature: Group named import/export kinds (type/value) on sort-named-imports/exports

What rule do you want to change?
sort-named-imports & sort-named-exports
Describe the problem
Hey, first of all, love this plugin!

Currently, there's no way to configure sort-named-imports and sort-named-exports to group inline type import/exports.
Code example
When using this rule to sort named imports alphabetically, we get:
import { A, type B, C, type D} from 'rurouni-kenshin'

This is fine, but IMO we should have an option to group inline type imports before/after value imports to improve readability.
Same goes for named exports.
Additional comments
I've implemented this by adding an option called group-kind with possible values mixed (default, current behavior), values-first, and types-first.
// group-kind: mixed
import { A, type B, C, type D} from 'rurouni-kenshin'

// group-kind: values-first
import { A, C, type B, type D } from 'rurouni-kenshin'

// group-kind: types-first
import { type B, type D, A, C } from 'rurouni-kenshin'

Not sure how https://github.com/azat-io/eslint-plugin-perfectionist/pull/113 will affect it, but I've opened https://github.com/azat-io/eslint-plugin-perfectionist/pull/115 anyway. If we agree that this should be doable on this plugin, I can reimplement it on v3.
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Released in v2.7.0.


Gulp Build Error, Angular / Bower

Error in plugin 'gulp-ng-annotate'
scripts/app-92785c13.js: error: couldn't process source due to parse error
Line 848: Delete of an unqualified identifier in strict mode.
at Transform._transform (/Users/user_name/Work/dev/folder_name/2015/node_modules/gulp-ng-annotate/index.js:34:26)
at Transform._read (/Users/user_name/Work/dev/folder_name/2015/node_modules/gulp-ng-annotate/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:184:10)
at Transform._write (/Users/user_name/Work/dev/folder_name/2015/node_modules/gulp-ng-annotate/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:172:12)
at doWrite (/Users/user_name/Work/dev/folder_name/2015/node_modules/gulp-ng-annotate/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:237:10)
at writeOrBuffer (/Users/user_name/Work/dev/folder_name/2015/node_modules/gulp-ng-annotate/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:227:5)
at Transform.Writable.write (/Users/user_name/Work/dev/folder_name/2015/node_modules/gulp-ng-annotate/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:194:11)
at write (/Users/user_name/Work/dev/folder_name/2015/node_modules/gulp-filter/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:623:24)
at flow (/Users/user_name/Work/dev/folder_name/2015/node_modules/gulp-filter/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:632:7)
at DestroyableTransform.pipeOnReadable (/Users/user_name/Work/dev/folder_name/2015/node_modules/gulp-filter/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:664:5)
at DestroyableTransform.emit (events.js:92:17)

Hey, I get the same error but different line. How do I check which line the error at? I can't find Line 848 as there's no such file. What's the best way to go about debugging such errors.


Navigator pages api DefaultTransitionDelegate didn't work on master branch

Navigator#pages api has no animation effect on the master branch, but it is normal on the stable branch.
Steps to Reproduce

I wrote a simple demo application here:
https://github.com/boyan01/flutter_navigator_pages_api
Expected results:
pages changed should have transition animation.
Actual results:
pages changed, but didn't have any animation

Logs

Running "flutter pub get" in flutter_app...                        697ms
Analyzing flutter_app...
No issues found! (ran in 2.7s)

[✓] Flutter (Channel master, 2.3.0-17.0.pre.421, on Microsoft Windows [Version 10.0.19043.1052], locale zh-CN)
    • Flutter version 2.3.0-17.0.pre.421 at C:\Users\yangbin\dev\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c3822edbe8 (9 hours ago), 2021-06-21 18:46:02 -0700
    • Engine revision 9520bb15b3
    • Dart version 2.14.0 (build 2.14.0-228.0.dev)
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31205.134
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 4.2.0)
    • Android Studio at C:\Users\yangbin\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\202.7351085
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.1)
    • IntelliJ at C:\Users\yangbin\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\211.7442.40
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.57.1)
    • VS Code at C:\Users\yangbin\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.23.0

[✓] Proxy Configuration
    • HTTP_PROXY is set
    • NO_PROXY is localhost,<IP_ADDRESS>,storage.flutter-io.cn,127.0.*,10.0.*,192.168.*
    • NO_PROXY contains <IP_ADDRESS>
    • NO_PROXY contains localhost

[✓] Connected device (5 available)
    • SM G9730 (mobile)       • RF8M71K7DQD • android-arm64   • Android 11 (API 30)
    • Windows (desktop)       • windows     • windows-x64     • Microsoft Windows [Version 10.0.19043.1052]
    • Windows (UWP) (desktop) • winuwp      • windows-uwp-x64 •
    • Chrome (web)            • chrome      • web-javascript  • Google Chrome 91.0.4472.106
    • Edge (web)              • edge        • web-javascript  • Microsoft Edge 91.0.864.54

! Doctor found issues in 1 category.

close due to https://github.com/flutter/flutter/pull/82596


[TODO] Scroll

Ideally we want an infinite canvas where you can draw anywhere. In order to avoid people from getting lost, we could only make the canvas exist for half a screen around the closest object. If you draw something on the edge, it automatically expands it.

How this will interact with the #13 ? The zoom in/out will be handled with mouse wheel or not?
I think, we need even to allow the expansion of the canvas by an interaction that is not drawing a shape, maybe a button at the bottom edge.

How this will interact with the #13 ?

I'd zoom using Alt+WheelUp/WheelDown (or Ctrl/Cmd).


loader needs to use object allocators passed by application for memory allocations

Moved from gitlab 111

Changes committed: aa32dbbf147d86257a0c9e091258e0ea2be5a013.  Now passes conformance allocator tests as well.


Reuse worker daemons across builds

Pulls WorkerDaemonClientsManager and WorkerProcessFactory up to gradle user home scope and reuses worker daemons across builds.

@oehme I was able to hunt down the issue with the hung builds and it was related to the way we were stopping worker daemons on log level change.  I've changed this so that we instead expire "duplicate" worker daemons (i.e. we do the expiration only if we are going to start a new daemon that would be compatible except for the log level).  This is a lot cleaner and allows for more opportunity for reuse.  In any event, this is only temporary until we can just tell the daemon to update its log level instead.
Can you give the latest changes a once-over before I merge?  I'll capture the other items you've identified in a follow-up story.


feat: use crescent mint mod and update inflation calculation

Description
Closes: #XXXX

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[x] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[x] targeted the correct branch
[ ] provided a link to the relevant issue or specification
[x] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[x] reviewed "Files changed" and left comments if necessary
[x] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

:exclamation: No coverage uploaded for pull request base (chains/crescent/mainnet@4463d50). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             chains/crescent/mainnet     #435   +/-   ##
==========================================================
  Coverage                           ?   56.28%
==========================================================
  Files                              ?       19
  Lines                              ?     1409
  Branches                           ?        0
==========================================================
  Hits                               ?      793
  Misses                             ?      516
  Partials                           ?      100


You can "successfully" add duplicates to a remote collection if you do not click into it first

MB returns 200 but it won't actually add the duplicate
We show a snackbar saying it was successfully added
This issue happens because we don't download all of the collection's entity ids when we fetch all collections. This is because we would have to possibly make an unreasonable amount of network calls if a collection is massive (thus having to page through it all).
We only check whether an entity's id is already in our local database to consider it a duplicate

Possible solutions:

Show a different copy
Download collection's entire contents

Can't think of a non-confusing copy for this. Will have to accept this possible discrepancy.


Detailed statistics on the coverage data branch

It would be nice to use the coverage data branch not only for storing the data, but also to display other stats there.
For example, the HTML reports generated by pycoverage could be used for this.

We may need to use https://htmlpreview.github.io/ because we probably won't be able to serve arbitrary html in GitHub.
The alternative is if we manage to have all the reports in markdown format, though I don't think it will let us display code in a readable way (with line numbers, line colors for coverage status etc)


Fix Nested Parameters, Update Training script, and Document dSprites Experiment

Fixed the issue of nested parameters in the sweep config.
Updated the configuration to use a timestamp as the default run_id.
Updated the training source to handle the creation of the checkpoint directory if it does not exist.
Documented the results of the dSprites mice training experiment.

Todo

[x] Upload checkpoints on hugging face

I added the model checkpoint paths for all the dSprites models.

Excellent ty!


Fetch Interceptor

Is your feature request related to a problem? Please describe.
I need interceptor feature to intercept request or response.

You could use many approaches for interceptor


Not possible to filter with optional value

Hi,
I have a table where the GeographicPoint2D property is optional and it is not possible to use filterGeometryDistanceWithin with this property without force-unwrapping it. I made a unit test to showcase this situation:
func testOptionalLocation() throws {
    struct UserGeographicLocation: PostgreSQLModel, Migration {
        var id: Int?
        var name: String
        var location: GeographicPoint2D?
    }
    let conn = try benchmarker.pool.requestConnection().wait()
    conn.logger = DatabaseLogger(database: .psql, handler: PrintLogHandler())
    defer { benchmarker.pool.releaseConnection(conn) }

    try UserGeographicLocation.prepare(on: conn).wait()
    defer { try! UserGeographicLocation.revert(on: conn).wait() }

    let point: GeographicPoint2D = GeographicPoint2D(longitude: 1, latitude: 2)

    var user = UserGeographicLocation(id: nil, name: "My User", location: point)
    user = try user.save(on: conn).wait()

    // Crash:
    // Fatal error: Unexpectedly found nil while unwrapping an Optional value
    // without the `!`, it will not build
    let all = try UserGeographicLocation.query(on: conn).filterGeometryDistanceWithin(\UserGeographicLocation.location!, point, 1000).all().wait()
    XCTAssertEqual(all.count, 1)
}

I tried to look the code to find a solution, but couldn't find any way to workaround or fix it.

Found a solution: use Database.QueryField. Here is the test without errors:
func testOptionalLocation() throws {
    struct UserGeographicLocation: PostgreSQLModel, Migration {
        var id: Int?
        var name: String
        var location: GeographicPoint2D?
    }
    let conn = try benchmarker.pool.requestConnection().wait()
    conn.logger = DatabaseLogger(database: .psql, handler: PrintLogHandler())
    defer { benchmarker.pool.releaseConnection(conn) }

    try UserGeographicLocation.prepare(on: conn).wait()
    defer { try! UserGeographicLocation.revert(on: conn).wait() }

    let point: GeographicPoint2D = GeographicPoint2D(longitude: 1, latitude: 2)

    var user = UserGeographicLocation(id: nil, name: "My User", location: point)
    user = try user.save(on: conn).wait()

    let all = try UserGeographicLocation.query(on: conn).filterGeometryDistanceWithin(.keyPath(\UserGeographicLocation.location),
                                                                                PostgreSQLDatabase.queryFilterValueGeometry(point),
                                                                                1000).all().wait()

    XCTAssertEqual(all.count, 1)
}


Unable to Import

        XMLHttpRequest.prototype.send = function(a,b) {
            if (!a) a ='';
            if (!b) b ='';
            tap._origSend.apply(this, arguments); // <-- 500 response
            if(tap.method.toLowerCase() == 'post') tap.data = a;
            if (tap.sendcallback) {
                tap.sendcallback(this);
            }
            if (tap.loadcallback) {
                this.addEventListener("load",tap.loadcallback,false);
            }
        };

i'm a backend, not a frontend dev, so feel free to help me debug this better.  i used chrome dev tools and looked at the Console, Sources, and Network tabs to gather info about what's happening when i try to import.
used to import old grooveshark playlists all the time, still have about twenty more to go.  went to import one of them today, and it didn't work, but didn't say why.  when i say it didn't work, it attempts to import, shows 0/n completed, and then spits out a file containing the failed imports with a bunch of nulls.
network tabs shows his html response to that call:

<TITLE>Internal Server Error</TITLE>

Internal Server Error

Error 500

not an auth error like others had reported a lil while back.  is this an api change from google that needs a code update here?

I've seen 500 errors before when google gets overloaded.  It may be worth waiting a little bit and try again.  Another thing to try is seeing if you can import the example playlist file.
There may be something going on with google's servers because when I imported the example playlist file it only imported about half of the songs where I'm sure it used to import all of them.

Even example.csv won't import - 0/24 from that playlist get found :(

Do you know if something has changed on your account?
Has your subscription expired?  In the past I've gotten odd behavior from google when my credit card that the subscription was setup with expired.  The fact that the card had expired was not obvious from the errors I was getting.

no, nothing's changed on my account.  i still use it actively, and since it's a family account, my wife uses it as well.  when i try to import, it'll create empty playlists with the correct names, so some of the google music api is working, and auth is evidently not an issue here.  it's making me think something changed with the search api perhaps.

I am also having the same issue
The Chrome console shows a "500" error when it sends the POST

it'll create empty playlists with the correct names
Chrome console shows a "500" error when it sends the POST

I'm experiencing the same issue:

POSTing to services/createplaylist results in a 200 response.
POSTing to services/addtrackstoplaylist results in a 500 error.

I did a little digging into the Python gmusicapi repo repo, and found it is POSTing to https://play.google.com/music/services/addtoplaylist which is different from what's being used here.
Thinking this could potentially be the source of the issue, I changed my local script to POST to services/addtoplaylist instead of services/addtrackstoplaylist. Unfortunately, this resulted in a 404 error instead of a 500 error.
So it seems like the services/addtrackstoplaylistis the correct URL to POST to. This leads me to believe something isn't right with the payload.

i wonder if its not getting the ids for the songs right.  since it seems to work for songs in the library, im suspecting something may have changed in googles search responses.

got it working again.  it should be good to go until the next time google changes their response and request formats.
0271ef7


feat: add firmware update for Inovelli LZW31-SN

This is an initial device commit to make sure the formatting is correct and that everything is in order.

@InovelliUSA let me know if you want to add other files to this PR or if I should merge this

Can we merge this product by itself? I'd like to check the process and make sure everything is in good order and then I will submit the rest of the products in a different PR.

Sure thing!

This should be live in a few minutes up to an hour.


Log4jLoggingNode jar is not available in version 2.x

Description
currently our logging framework is implemented with 1.2.17 log4j jar. we have got vulnerability from security team to use latest version 2.x of Log4j but current version doesn't have Log4jLoggingNode jar.
[A clear and concise description of what the bug is.]
Configuration
Version: [Log4j version]
1.2.17
Operating system: [OS and version]
Redhat Linux
JDK: [JDK distribution and version]
Logs
[Stacktraces, errors, etc. relevant applications logs.]

Reproduction
[An isolated test reproducing the test.
JUnit tests similar to the ones in the code base are extremely appreciated.]

HI,
is there any workaround for this. how can we log4jLogging node jar in latest Log4j version 2.x

@nagkalgur,
Log4jLoggingNode.jar seems to be a private library at your company. Can you explain what it does? Maybe it is possible to replace it with standard components.

this github location has the details log4jLogging node
https://github.com/ot4i/node-for-log4j

Well, that repo is NOT part of Log4j and never has been. I have no idea what it does but if it is missing something I suggest you ask the maintainers of that project.


Add the Gradle wrapper

See here for info on the gradle wrapper: http://www.gradle.org/docs/current/userguide/gradle_wrapper.html

Sorry but this is a maven project. You can reference nanohttpd from gradle by using the dependencies to the central repo. If you know a way to automatically keep the gradle stuff in sync with the all the POM's, we can discuss this anew.


Add a new index node GraphQL server

Resolves #1121.
This adds a new GraphQL server specifically for indexing information. This server runs at port 8030 by default. Its first version includes an indexing status feature, that allows to query the indexing status of all or a subset of deployed subgraphs:
For example, the query
{
  indexingStatuses {
    subgraph
    failed
    synced
    error
    chains {
      network
      ... on EthereumIndexingStatus {
        chainHeadBlock {
          number
          hash
        }
        latestBlock {
          number
          hash
        }
        earliestBlock {
          number
          hash
        }
      }
    }
  }
}

might return the following result:
{
  "data": {
    "indexingStatuses": [
      {
        "chains": [
          {
            "chainHeadBlock": {
              "hash": "70a1737e45dcbe60d841e262a41d8718a5fd08093f949667d2a7259c94b7460c",
              "number": "6204937"
            },
            "earliestBlock": {
              "hash": "41941023680923e0fe4d74a34bdac8141f2540e3ae90623718e47d66d1ca4a2d",
              "number": "0"
            },
            "latestBlock": {
              "hash": "8d4d913fa0fcb75fd8ec8a9b2d79d5ce7377a25002baab979cf30f6a547d0b35",
              "number": "2300000"
            },
            "network": "ropsten"
          }
        ],
        "error": null,
        "failed": false,
        "subgraph": "QmTk7hoDDFuo7BVh4v4EUFHk8PdpcSNajfkMhGXttdZhjj",
        "synced": false
      }
    ]
  }
}

One general comment: do we want this to be on a new port, or just use a new URL on an existing port? Generally, exposing more ports just complicates setup.

Alternatively, another port makes it clearer to control how this server is exposed (i.e. only exposing it on the local instead of the public network)

Apollo injects the __typename into each request with default configuration, so the __typename field is requested on all entities in the GraphQL responses.

@lutter Yeah, I would like to keep this separate from the other servers. The index node server should contain all the APIs/endpoints required for index nodes. Think of it like Ethereum nodes exposing their JSON-RPC API at 8454 and the network communication at 30303.
@olibearo I've added the missing __typename, will add docs for the new env var next.

@olibearo Comments addressed! Would be great if you could re-run your local test to see if the __typename issue is fixed.

@Jannis I've pull down the latest and I'm still getting missing__typename errors from Apollo:
GraphQL error: Null value resolved for non-null field `__typename

@olibearo I think I've fixed it. Can you try again?

The __typename issue is resolved, thanks


[folding] Add keyboard shortcut to jump between #region and #endregion

How difficult would it be to add a keyboard shortcut to jump between #region and #endregion, the same way you can jump between opening and closing brackets [], braces {}, and parentheses ()? I would prefer the same keyboard shortcut, so just adding this to editor.action.jumpToBracket would be perfect. However, I can imagine that some might prefer it to be a separate command, or it may be better to do that from an implementation standpoint.
I apologize if I'm missing an existing shortcut, but I couldn't find anything in the current keybindings.

This is a very reasonable request. Any progress?

Very old request, but I didn't see anything in the docs, so I am wondering if this is still outstanding?

As a potential alternative / workaround, maybe a configuration that would allow for quickly jumping to a region by name would suffice; for example workbench.action.gotoSymbol could include regions as another symbol type. If implemented it should probably be configurable so that the menu wouldn't be polluted with named regions / marks for anyone who prefers the current behavior.


refactor os requirements

Move OS requirements for testing to the testing package

what's the bump for?

what's the bump for?

18.0.0 includes this change. Not bumping will cause the base package build to fail.

that change does not modify the base package though, only tests & ddev

that change does not modify the base package though, only tests & ddev

The build will still fail


Move test execution to runner file, refactor output

Closes #121.
TODO:

[x] Migrate runtime.Start to it's own file runner.go
[x] Stream TestResults to output in runtime
[x] Aggregate TestResults to a single struct Result
[x] Add FileName to TestCase struct when executing against a dir
[x] Define a single OutputWriter to be used in both Runtime and for out.PrintSummary
[x] Test runner.go
[x] Converge struct Results in Test_Command when executing against a dir
[x] Switch output to go/template

Checklist

[x] Added unit / integration tests for windows, macOS and Linux?
[ ] Added a changelog entry in CHANGELOG.md?
[ ] Updated the documentation (README.md, docs)?
[x] Does your change work on Linux, Windows and macOS?

Mainly just trying to organize my thoughts.
I elected to implement runner.go in the runtime package do to moving runner into it's own package would require a major refactor of runtime. Pulling the execution out currently causes a circular dependency as all the executors reside in runtime. runtime be broken up could beneficial as well.

@SimonBaeumer when you get a chance would you mind taking a look. My above comment explains some of my decisions. I'm hesitant to write tests. I'm not a big fan of my go/template implementation, it's kinda tough to implement the output colors and still get the benefit of using template.  I will implement test based upon how your feedback goes. I will enjoy moving execution to runner.go as passing the the channel doesn't feel very forced anymore.
Let me know what you think, Im looking forward to your feedback. I hope all is well
Cheers

Hey @dylanhitt!
Nice to see your pull request, it looks really good to me for a first approach!

If you need any help on formatting issues let me know - I can help you with the annoying tasks ;)

@SimonBaeumer I believe this ready for review

@SimonBaeumer should be good to go now. I don't know if you want an update to the changelog since this is a just refactor. Unless you plan on incrementing versions. If so let me know.

Merge! :)


Persistent Replace All tooltip

Hi,
I love using atom - well done!
I've just noticed a problem which affects me when I'm attempting to find and replace in a single file (using CTRL+F key binding).
After you've hit "Replace All" to replace all instances within a file the button becomes disabled and the tooltip fails to disappear.  It hangs around and obscures the buttons above it:

The only way to get rid of it (it seems) is to change the content of the "find" input so it matches something in the current file. Then the "Replace All" button becomes enabled once more and the tooltip stops persisting.
I'm using Windows 8.1.

Would you mind reopening this on https://github.com/atom/find-and-replace? Thanks!
Also take a look at https://discuss.atom.io/t/id-like-to-report-an-issue-request-an-enhancement-for-atom-where-on-github-do-i-do-that/19290 for a guide on where to post issues.

Done! - apologies for raising in the wrong place.


fix when cursor in prefix,generate wrong result

This fix is for issue28
Live demo: http://output.jsbin.com/pasulefepu/
Edit it: http://jsbin.com/pasulefepu/edit?html,css,js,console,output

@cht8687 maybe worth to add a test?

Neat fix +1


Correction for raw affiliation Equipe Recherche ENDSUM, Cerema, Les Ponts de Cé, 49136, France

Correction needed for raw affiliation Equipe Recherche ENDSUM, Cerema, Les Ponts de Cé, 49136, France
raw_affiliation_name: Equipe Recherche ENDSUM, Cerema, Les Ponts de Cé, 49136, France
new_rors: 03s0gj002;05k0nvr25
previous_rors: 03s0gj002;05k0nvr25;02nwvxz07
works_examples: W4288045373
contact: bdef3297740a06766f95950d5e365965:5663bedd828e284a32508a3b0cd1bb @ recherche.gouv.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


language detection error

Just had the following output from commitlint, where it has incorrectly detected the language:
input: feat(commitlint-config-default): add default commitlint rules
⚠   commit must be in languague "eng", was one of: fra, cat, src, spa, sco [lang]
⚠   found 0 problems, 1 warnings

Running npx franc-cli "feat(commitlint-config-default): add default commitlint rules" yields cat as the result 😖
(Also note the minor typo in the error message)

Yeah, all the rules based on natural language processing are rather flaky. I see the following options:

Experiment with remote API solutions and see if those yield better results
Deprecate, then remove the NLP rules: body-tense, footer-tense, lang, subject-tense

So for my use-case the first option would be a no-go because of an air gapped environment.
To be honest I'd leave them as is, it doesn't matter too much if they're in warning mode, but might be worth updating the docs to say you might get problems in error mode, if the text sample is relatively short ?

Thanks for bringing the unknown constraints of development environments to the table, that rules out remote API usage.
My goal for commitlint is being as seamless as eslint, possibly adding autofix capabilities and commit message suggestions in the very long run. Keeping around flaky rules will prevent the tool from achieving that.
That being said I'd do this by deprecating them in some of the 2.x releases by warning on stderr if they are used and remove them with the 3.0 release the earliest.

https://github.com/marionebl/commitlint/commit/fd56dff98926a730292053c4bf61f1064dc53b01

I ran into this too immediately after initially setting up.
⧗   input: chore(*): suggest project setup
⚠   ...
⚠   commit must be in language "eng", was one of: src, fra, spa, por, bos [lang]
⚠   found 0 problems, 2 warnings

You'd said back in July you planned to address this in 3.0, did that not happen? Every commitlint dependency I have is > 3, I'm using these:
"@commitlint/cli": "^4.1.1",
 "@commitlint/config-angular": "^3.1.1",
"@commitlint/config-lerna-scopes": "^4.1.1",

Due to other breaking changes I bumped to 3.0 earlier - the plan is to remove the functionality because the false positives are to frequent for texts as short as commits.
The removal will happen with one of the next major bumps, one of the releases before then will contain new deprecation warnings.

I just recently adopted commitlint, and the lang and subject-tense rules result in false negative warnings for every commit. I'd definitely love to see them removed/improved, so that my commit lint runs were "clean". Ideally, any error or warning would be actionable, so that they're worth paying attention to.


build: add __load_patch and symbol in zone_extern for closure

add __load_patch and __symbol__ in zone_extern.js for closure compiler.
In PR https://github.com/angular/angular/pull/30533, we use Zone.__symbol__ function to get the native delegate, so we need those API to be reserved by closure compiler.

@mhevery, please review, after this is merged, we need to cut a new release to make https://github.com/angular/angular/pull/30533 work! Thanks!


Pipe Esri service area validation variables through the deploy system

In order for for Esri address correction and service area validation features to be fully configurable and available for testing in staging, we need to be able to set them in the deploy config file and pass them through our deployment system. Some service area validation vars are lists, and we do not currently have a pattern for passing list type variables through our deployment system. (See https://github.com/civiform/civiform/issues/2800 for the same issue but related to languages.)
See all Esri server vars here
Note: this is blocking for Seattle to launch their new staging environment

Update: Determined with @bion that we can't set list variables in our config file. New plan is to pass through vars as a string of comma separated values and parse them into a list in the Java code.

This will be covered by autogeneration of server variables: https://github.com/civiform/civiform/issues/4612


Add alignment matrix learning

Added alignment matrix learning to training. See issue #1105 for more details.
Added command line arguments
--alignment-matrix for specifying a file to read alignments from.
--alignment-matrix-weight for specifying loss coefficient for alignment matrix cross entropy.
--attention-alignment-layer for specifying layer of decoder in which attention alignment will happen.
--align-attentions for telling model to learn alignments when that's impossible to infer from other command line arguments.
--shift-alignments for telling data preparation to shift alignments one target token forward, and translation one target token backward.
Report on performance impact:
Sockeye_Alignment_Matrix_Report-6.pdf
Pull Request Checklist

[x] Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
until you can check this box.
[x] Unit tests pass (pytest)
[x] Were system tests modified? If so did you run these at least 5 times to account for the variation across runs?
[x] System tests pass (pytest test/system)
[ ] Passed code style checking (./style-check.sh)
[x] You have considered writing a test
[x] Updated major/minor version in sockeye/__init__.py. Major version bump if this is a backwards incompatible change.
[x] Updated CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

So I ran the style_check.sh (My appologies that I didn't do it before the pull request) (ᗒᗣᗕ)՞.
.
One of the issues is a type error.
I modified TransformerDecoder.decode_seq to return Tuple[Tensor, Tensor] istead of the previous Tensor.
This is necessary because the decoder now has to return both the translation and the attention matrices.
But it doesn't fit what the abstract class Decoder.decode_seq expects of the function.
I see a couple paths forward here:

Make decode_seq return a dictionary of results where keys correspond to different tensors.
Make Decoder.decode_seq return Tuple[Tensor, Tensor]
Make a new function called decode_seq_and_attention, and modify the logic everywhere that calls decode_seq.
Perhaps something completely different?

Which approach do you think might be most pleasing?
Thanks,
IP

Hi Ingus,
It looks like you've created a thorough implementation and tested it extensively. Given the size of the pull request and our current priorities, it may be some time before we get to this. We'll follow up when we start to review the code and your report.
Best,
Michael

Hello Michael.
Before You do the code review, can you please give a quick opinion on the type error, so I can fix it up? ༼ つ ◕.◕ ༽つ
Thanks,
IP

Hi Ingus,
Thank you for your interest in using and contributing to Sockeye!
Unfortunately, we were not able to include your new feature before the cutoff for transitioning Sockeye to maintenance mode. We appreciate the amount of work that went into developing and testing this feature and encourage you to share your extended version of Sockeye with others.
Best wishes on your future projects!
--Michael


SaaS Manager - User Status Change

Description
initial release of SaaS Manager - User Status Change policy
Contribution Check List

[x] All tests pass.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:
Policy Template path should be lowercase. saas/fsm/user_status_change/fsm-user_status_change.pt

  Generated by :no_entry_sign: Danger

          1 Error

:no_entry_sign:
The URL is not valid: http://docs.rightscale.com/policies/ in saas/fsm/user_status_change/fsm-user_status_change.pt Status: 301

  Generated by :no_entry_sign: Danger


Option to edit or add countries/state flags?

I'm looking for a way to (somewhat)easily add flags to display the subregions of my state. It's probably the last big feature to pull me from my streamcontrol layout permanently. I've tried editing countries+states+cities.json, but must be missing something as I'm not a very proficient coder.

Well, giving a context about the regional flags:

The program automatically updates countries+states+cities.json coming from https://github.com/dr5hn/countries-states-cities-database
The flags themselves come from this repository I made, which tries to download regional flags from Wikipedia: https://github.com/joaorb64/world-state-flags. Some may be wrong or missing, but 2584 flags I could never do by hand, so it helps a lot. I update these flags on TSH before each release, usually

Now, which region are we talking about? If it's somewhere missing in the json we could work on adding it to that, or if it's just missing flags we could even add them manually. If it's a more specific case... then we'd have to work on some kind of custom region support.

If its that integrated and complex to change, then I'll just forget out about it. We in the Maine Smash scene are pretty spread out through our large state, so I made North, South, Central, East icons for my previous overlay. It's not really a big deal.


[+] Manage group member

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


showTimePicker does not allow for use of 12-hour format for locales that default to a 24-hour format

Hello guys, I am using showTimePicker in my application. Also, I am using Internationalizing for my flutter app with two languages(English 'en' & Spanish 'es').

Code for present showTimePicker:

Padding(
              padding: EdgeInsets.all(2),
              child: MaterialButton(
                minWidth: double.infinity,
                onPressed: () async {
                  TimeOfDay picked = await showTimePicker(
                    context: context,
                    initialTime: TimeOfDay.now(),
                    builder: (BuildContext context, Widget child) {
                      return MediaQuery(
                        data: MediaQuery.of(context)
                            .copyWith(alwaysUse24HourFormat: false),
                        child: child,
                      );
                    },
                  );
                },
                child: Text(
                  S.of(context).set_time,
                  textAlign: TextAlign.center,
                  style: TextStyle(
                      color: Theme.of(context).primaryColor, fontSize: 14),
                ),
              ),
            ),

Issue what I am facing is Initially when I run my App with the English language it's working fine and showing timePicker with 12 hours formate. But when I am changing App language to Spanish from the App then it will start showing timePicker with 24 hours formate. Please find the below screenshots for the same.
1.  When App language is English:

2. When App Language is Changed to Spanish:

Hi @DhavalRKansara
Checked, yes, format depends on the chosen locale. I'll label it as proposal, possibility to set always use 12 hour format, not only alwaysUse24HourFormat property

flutter doctor -v
```
[✓] Flutter (Channel dev, v1.18.0-dev.5.0, on Mac OS X 10.15.4 19E287, locale
    en-GB)
    • Flutter version 1.18.0-dev.5.0 at /Users/nevercode/dev/flutter_dev
    • Framework revision 7f56b53de4 (3 days ago), 2020-04-12 12:00:01 -0400
    • Engine revision beb8a7ec48
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 89b0f67261)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/nevercode/Library/Android/sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.4, Build version 11E146
• CocoaPods version 1.9.0
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 45.1.1
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build
1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.43.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.9.1
[✓] Connected device (6 available)
• Redmi Note 7              • 6345c469                             •
android-arm64  • Android 9 (API 28)
• Android SDK built for x86 • emulator-5554                        •
android-x86    • Android 10 (API 29) (emulator)
• iPhone 11 Pro Max         • 5D5365D0-C0F6-4440-B758-FFA83896129E • ios
• com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)
• macOS                     • macOS                                •
darwin-x64     • Mac OS X 10.15.4 19E287
• Chrome                    • chrome                               •
web-javascript • Google Chrome 81.0.4044.92
• Web Server                • web-server                           •
web-javascript • Flutter Tools
• No issues found!

</details>

@VladyslavBondarenko But I have marked alwaysUse24HourFormat false while opening the dialog.

CC @darrenaustin

I found that I am facing this issue while I change supportedLocales value to Locale('es', '') from Locale('en', ''). But I have no idea how I can fix this.

CC @rami-a

hey @DhavalRKansara, the time picker decides whether to use 12 or 24hr clock depending on the locale. Is your application primarily targeting the US only? I found that if you specify the country in the locale (like Locale('es', 'US')), you can get Spanish translations and the 12 hour clock.

hey @DhavalRKansara, the time picker decides whether to use 12 or 24hr clock depending on the locale. Is your application primarily targeting the US only? I found that if you specify the country in the locale (like Locale('es', 'US')), you can get Spanish translations and the 12 hour clock.

@rami-a  Thanks for the reply. I tried to set Locals with their country code but when I am setting Locale('es', 'ES') for my MaterialApp the app starts running in the English language on behalf of Spanish.

Hmm this seems like a separate issue. How are you specifying the locale?

Previous code before thisreply:
MaterialApp(
              navigatorKey: _scaffoldKey,
              debugShowCheckedModeBanner: false,
              locale: this.locale,
              localizationsDelegates: const [
                S.delegate,
                GlobalMaterialLocalizations.delegate,
                GlobalWidgetsLocalizations.delegate,
              ],
              supportedLocales: S.delegate.supportedLocales,
              // ignore: missing_return
              localeResolutionCallback: (deviceLocale, supportedLocales) {
                S.delegate.resolution(fallback: deviceLocale);
              },
              localeListResolutionCallback:
                  S.delegate.listResolution(fallback: const Locale('en', '')),
              theme: ThemeData(
                primaryColor: const Color(0xFF2090A6),
                accentColor: const Color(0xFFFF7043),
                fontFamily: 'Quicksand',
              ),
              home: Home()),

For the value of this.local in above code I am getting one language parameter from the backend and according to that I am setting Local as below:
 _fetchLocale() async {
    int language = await SharedPrefPharmacy()
        .getSharedProperty(key: SharedPrefKeysEnum.language);
    if (language == 0) {
      // English
      return Locale('en', '');
    } else if (language == 1) {
      // Spanish
      return Locale('es', '');
    } else {
      return Locale('en', '');
    }
  }

Calliing _fetchLocale from the initState:
_fetchLocale().then((locale) {
      setState(() {
        this.localeLoaded = true;
        this.locale = locale;
      });
    });

@rami-a any update?

hey @DhavalRKansara, unfortunately I'm not sure how to fix the problem you're seeing. If I'm understanding correctly, you are specifying the spanish locale but seeing english strings correct? @shihaohong any ideas?

No @rami-a for the Spanish local ShowTimePicker comes up with 24 hours formate on behalf of 12 hours.

Oh I see. Well like I mentioned earlier, the time picker displays 24 or 12 hour depending on which locale is being used. Since users in those locales expect either a 12 or 24 hour clock.
If you want to override this behavior entirely, I suggest wrapping your widget tree with a MediaQuery copy that sets the alwaysUse24HourFormat to false. Something like:
return MediaQuery(
  data: MediaQuery.of(context).copyWith(alwaysUse24HourFormat: false)
  child: RestOfYourApp
)

Oh I see. Well like I mentioned earlier, the time picker displays 24 or 12 hour depending on which locale is being used. Since users in those locales expect either a 12 or 24 hour clock.
If you want to override this behavior entirely, I suggest wrapping your widget tree with a MediaQuery copy that sets the alwaysUse24HourFormat to false. Something like:
return MediaQuery(
  data: MediaQuery.of(context).copyWith(alwaysUse24HourFormat: false)
  child: RestOfYourApp
)

I have already tried to set alwaysUse24HourFormat: false in the for showTimePicker as shown in  showTimePicker Documentation. You can see my that in my question. Still, I for Spanish local TimePicker comes in 24 hr formate.

I see, something is certainly wrong here. If I follow that documentation with english set, it does make the picker 24hr format, but if I do it with spanish set and then use false for alwaysUse24HourFormat it still stays 24hr. Off the top of my head, I'm not sure why this is the case, so I'll have to look into it. Thanks for pointing this out!

Sorry about the delay, I've been working on other issues and have finally gotten to this one!
@DhavalRKansara, I did some digging and found that it's because if you use Locale('es'), the designated time format is the 24 hour format as described in material_es.arb. Unfortunately, there is no way to shake this default value due to the way timeOfDayFormat is defined.
As a hack, you can do something like the following:
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_localizations/flutter_localizations.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      supportedLocales: <Locale>[
        const Locale('en', 'US'),
        const Locale('es', 'ES'),
      ],
      localizationsDelegates: <LocalizationsDelegate>[
        GlobalMaterialLocalizations.delegate,
        GlobalWidgetsLocalizations.delegate,
        GlobalCupertinoLocalizations.delegate,
      ],
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Time Picker localization demo'),
      ),
      body: Center(
        child: RaisedButton(
          onPressed: () async {
            await showTimePicker(
              initialTime: TimeOfDay.now(),
              context: context,
              builder: (context, child) {
                final Widget mediaQueryWrapper = MediaQuery(
                  data: MediaQuery.of(context).copyWith(
                    alwaysUse24HourFormat: false,
                  ),
                  child: child,
                );
                // A hack to use the es_US dateTimeFormat value.
                if (Localizations.localeOf(context).languageCode == 'es') {
                  return Localizations.override(
                    context: context,
                    locale: Locale('es', 'US'),
                    child: mediaQueryWrapper,
                  );
                }
                return mediaQueryWrapper;
              },
            );
          },
          child: Text('Show time picker'),
        ),
      ),
    );
  }
}

That being said, maybe we should rethink the way that timeOfDayFormat is defined, since this doesn't allow a developer to override the default localization setting if the default format is a 24-hour format. The fix would unfortunately be a breaking change.

@shihaohong @rami-a Thanks for your replies...
For the above issues as I found one library(flutter_rounded_date_picker) and using it, I am able to fix my problem. It is not a solution but we can use it as a workaround.
Code for ShowTimer:

 TimeOfDay picked = await showRoundedTimePicker(
                        context: context,
                        theme: ThemeData(primaryColor:Theme.of(context).primaryColor),
                        initialTime: TimeOfDay(
                            hour: _doseTime.hour, minute: _doseTime.minute),
                        locale: Locale("en", "")
);

As shown in the above code using flutter_rounded_date_picker we can pass the locale and I am passing Locale("en", "") for Spanish and English. So It is showing 12 hours timePicker for any locale.

Flutter Team can provide such one optional parameter for the passing locale in the showTimerPicker as they are providing for the [showDatePicker](https://api.flutter.dev/flutter/material/showDatePicker.html).

@DhavalRKansara adding locale so that the time picker API matches date picker's seems like a reasonable idea.
Doing what @shihaohong mentioned and overriding the locale inside the builder parameter will work as well.

TimeOfDay time = await showTimePicker(
context: context,
initialTime: TimeOfDay.now());
MaterialLocalizations localization = MaterialLocalizations.of(context);
String formattedTimeOfDay = localization.formatTimeOfDay(time);
Use formatTimeOfDay() to get time in 12hr format

hi @DhavalRKansara I think you accidentally closed this issue while posting your message :)


[1.11.0-rc3] Mounting /dev breaks the host tty

Steps to reproduce the issue:

docker run -v /dev:/dev busybox
start new terminal (e.g. run xterm)

Describe the results you received:
Unable to start new terminal, strace shows there's no pty's available.
So far I can see that when mounting /dev as in step 1, /dev/ptmx is changed to a symlink
All the pts mounts are in place, everything else seems to be normal.
Describe the results you expected:
mounting /dev into a container should not break the host's pty
Additional information you deem important (e.g. issue happens only occasionally):
This does not happen on 1.10

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Confirmed, it does seem to be this new symlink which replaces /dev/ptmx and points to /dev/pts/ptmx which has no perms: c---------

What patch?

@crosbymichael patch?
btw, cannot repro on docker for mac.
Seeing this on debian jessie.
Containers: 16
 Running: 0
 Paused: 0
 Stopped: 16
Images: 36
Server Version: 1.11.0-rc3
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 137
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 3.16.0-4-amd64
Operating System: Debian GNU/Linux 8 (jessie)
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 3.871 GiB
Name: deb
ID: RVSK:ICZK:FZKT:2VUO:NWBA:4NJC:BM4I:FWPX:2Q7Z:UBTP:BCC4:4AL4
Docker Root Dir: /var/lib/docker
Debug mode (client): false
Debug mode (server): false
Registry: https://index.docker.io/v1/

This is not really a new issue, its always been a bad idea to mount host dev because of the tty and we have to create things inside it so its happens.  I don't recall anything changing around it recently.

Well, I can uninstall rc3 and install 1.10 and it doesn't happen, re-upgrade to rc3 and it happens :(

Identical to #20670?

@AkihiroSuda Maybe similar symptoms, but ultimately this is a new issue in 1.11.

@cpuguy83 Thank you for information.
I also confirmed it is even reproducible with 1.11-rc4 on Ubuntu 15.10 (MountFlags=slave), and it is completely differs from #20670.
As mentioned in the original report, /dev/ptmx became a weird symlink:
lrwxrwxrwx   1 root root             8  Apr  8 10:29 ptmx -> pts/ptmx

(Original ptmx was as follows:)
crw-rw-rw-   1 root tty         5,   2  Apr  8 10:29 ptmx

This code seems symlinking ptmx. Perhaps should be tracked as a containerd issue?
https://github.com/docker/containerd/blob/b4c901f34a8cd5b892796732a4e5c34d70dc6ec1/vendor/src/github.com/opencontainers/runc/libcontainer/rootfs_linux.go#L554

ping @mrunalp Maybe you have some idea where this change may have occurred.
The best I can see is potentially config.Devices was populated in 1.10 and now it's not populated since /dev/ptmx is not symlinked when mounting /dev in 1.10.

In https://github.com/opencontainers/runc/blob/master/libcontainer/rootfs_linux.go#L35

@cpuguy83 We used to set this to config.Devices to nil when we had a user mount over /dev. See https://github.com/docker/docker/pull/16639/files. We need an equivalent fix for 1.11.

@cpuguy83 I think we should move the /dev detecting logic to runc/libcontainer since we introduced default devices.

@cpuguy83 Could you PTAL https://github.com/opencontainers/runc/pull/732 ?

Reopening, because the required changes are not yet vendored here

they are now


StackOverflow error on filter method

In some cases, a StackOverflowError happens on bblfsh.filter method:
Exception in thread "Executor task launch worker for task 2273" java.lang.StackOverflowError
at org.bblfsh.client.libuast.Libuast.filter(Native Method)
at org.bblfsh.client.BblfshClient.filter(BblfshClient.scala:34)
at tech.sourced.api.udf.QueryXPathUDF$$anonfun$queryXPath$2.apply(QueryXPathUDF.scala:46)
at tech.sourced.api.udf.QueryXPathUDF$$anonfun$queryXPath$2.apply(QueryXPathUDF.scala:44)
at scala.collection.TraversableLike$$anonfun$flatMap$1.apply(TraversableLike.scala:241)
at scala.collection.TraversableLike$$anonfun$flatMap$1.apply(TraversableLike.scala:241)
at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
at scala.collection.TraversableLike$class.flatMap(TraversableLike.scala:241)
at scala.collection.AbstractTraversable.flatMap(Traversable.scala:104)
at tech.sourced.api.udf.QueryXPathUDF$.queryXPath(QueryXPathUDF.scala:44)
at tech.sourced.api.udf.QueryXPathUDF$$anonfun$apply$1.apply(QueryXPathUDF.scala:25)
at tech.sourced.api.udf.QueryXPathUDF$$anonfun$apply$1.apply(QueryXPathUDF.scala:24)
at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIterator.processNext(Unknown Source)
at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
at org.apache.spark.sql.execution.WholeStageCodegenExec$$anonfun$8$$anon$1.hasNext(WholeStageCodegenExec.scala:395)
at org.apache.spark.sql.execution.SparkPlan$$anonfun$2.apply(SparkPlan.scala:234)
at org.apache.spark.sql.execution.SparkPlan$$anonfun$2.apply(SparkPlan.scala:228)
at org.apache.spark.rdd.RDD$$anonfun$mapPartitionsInternal$1$$anonfun$apply$25.apply(RDD.scala:827)
at org.apache.spark.rdd.RDD$$anonfun$mapPartitionsInternal$1$$anonfun$apply$25.apply(RDD.scala:827)
at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:287)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:87)
at org.apache.spark.scheduler.Task.run(Task.scala:108)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:335)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

Can you provide some additional insight? Which query causes the problem, how to reproduce it, etc.?

I've made some stress tests and I cannot reproduce this.

@ajnavarro if you're parsing complex files probably is using more stack than configured (typically 512KB or 1MB), could you try to increase it with -Xss8M?

If I'm not mistaken, we've got this error with the tests, which is a 1 line python script:
with open('somefile.txt') as f: contents=f.read()

After a nice debugging session, I'm almost sure that this and #19 were caused because I wasn't locking the access to filter() with a mutex.
Based on my tracing of the problem, this almost surely caused the random errors we've been seeing with the "NoClassDefFound" randomly on random unittests, which in turn caused a lot of recursive calls if you have a big enough stack, or a StackOverflow if don't.
PR #23 should fix this when merged.


[Interlinks] - Integrate with Quais

Requirement;
Integrate with Quais so we can verify the interlink proofs

This ticket will need to integrate quais with the header changes that are here: https://github.com/dominant-strategies/go-quai/issues/1386


Table index is nil

The error:
2019-08-19 13:28:30: ERROR[Main]: ModError: Failed to load and run script from /home/happysmash27/Minetest/minetest/bin/../mods/moreblocks-master/init.lua:
2019-08-19 13:28:30: ERROR[Main]: ...Minetest/minetest/bin/../builtin/common/misc_helpers.lua:562: table index is nil
2019-08-19 13:28:30: ERROR[Main]: stack traceback:
2019-08-19 13:28:30: ERROR[Main]: 	...Minetest/minetest/bin/../builtin/common/misc_helpers.lua:562: in function 'copy'
2019-08-19 13:28:30: ERROR[Main]: 	...n/../mods/moreblocks-master/stairsplus/registrations.lua:57: in main chunk
2019-08-19 13:28:30: ERROR[Main]: 	[C]: in function 'dofile'
2019-08-19 13:28:30: ERROR[Main]: 	...netest/bin/../mods/moreblocks-master/stairsplus/init.lua:85: in main chunk
2019-08-19 13:28:30: ERROR[Main]: 	[C]: in function 'dofile'
2019-08-19 13:28:30: ERROR[Main]: 	...Minetest/minetest/bin/../mods/moreblocks-master/init.lua:21: in main chunk
2019-08-19 13:28:30: ERROR[Main]: Reviziu debug.txt por detaloj.

It appears that debug.txt has the exact same text as in my console.
This is on a freshly-built copy of Minetest 5.0, and happens with both the git and zip version of the mod. Another error occurs on the older version of Minetest.

I am having the same problem.

I am having the same problem.

Which Minetest version are you using? Is this in singleplayer or on a server you're hosting? Are you doing anything specific to trigger the crash?


Multiple episodes from different datasets

Hi, I saw you have an instance EpisodicRLDSDataset of how to load episodes from one dataset. However, I want to load mixed episodes from multiple datasets, could you elaborate me more on this? Thanks!!

The EpisodicRLDSDataset does not currently support loading from multiple datasets -- it's not made for training. If you really want to sample at random from multiple datasets you can just make N separate datasets and sample with a separate random process?


VSCode Stop Working

VSCode Version: 1.1.1
OS Version: Windows 10

Steps to Reproduce:

Open VSCode
I get the following screen

![image](https://cloud.githubuserc

ontent.com/assets/527813/15509095/4617558a-21a0-11e6-9d73-90ce05fcc77a.png)

VSCode stop working after I intalled VS2015 updates

It works but very very slow


Remove EndToEndJob

This is an old artifact from before FileFetcherJob and UpdateFilesJob
existed...
We've long wanted to get rid of these, there are at least two PR's I
found in our internal repo from before we open sourced this code.
But the blocker was that we didn't have integration tests that tested
the combination of FileFetcherJob + UpdateFilesJob, so we wanted
to refactor the integration tests to test the handoff between the two.
To be clear: We do have unit tests that test each of those individual
components, so we can still refactor internally knowing that we're
protected by individual unit tests for a fast dev/test cycle. It's just
the combination of the two that's not tested.
However, we now have the full smoke test suite which tests everything
end to end. So rather than refactoring the integration tests, it's now
safe to simply remove them.

Go for it @brrygrdn !

Switch to draft based on discussion in:

https://github.com/dependabot/dependabot-core/pull/6760#issuecomment-1450644241

Closing as https://github.com/dependabot/dependabot-core/pull/6760 handled everything we need here.


Architecture

Remove lblockindex model
Splite LoadBlockIndexDB to chain's init and persist's init
Add initTestEnv to some testcases
Remove conf.cfg.DataDir

Good Job, LGTM @fffreedom @georgefff


Add docker micro benchmark into kubernetes contrib.

Add docker micro benchmark into kubernetes contrib.
The description and usage of the tool is in README.md.
Even though the tool is quite simple now, it could be a start. I'll add more benchmark when we need it in the future.
@kubernetes/sig-node

Still reviewing. Sorry for the delay.

@yujuhong Thanks! Don't rush~ :)

/cc @pwittrock @liangchenye
This is a docker benchmark tool. Hope this could help you a bit. :)

:) Thanks

@Random-Liu, could you merge the first and the third commits? I'd like to go through the code once without the godeps changes.

@yujuhong Sure. Will do soon.

@Random-Liu, thanks!

@yujuhong Squashed 1st and 3rd commits.

Let's get this in first and iterate later (if we need to). Thanks for putting this together!

SGTM. I'll squash the commits. :) Thanks for reviewing~


Fixes Redmine integration

Hi!
Your Redmine integration seems to be obsolete.
In some projects it will work but create the issue in the wrong project, while in other projects issue creation will return a 422 error.
I tracked down the error to this same bug: http://www.redmine.org/issues/20119. You're submitting the "project_id" field inside the "issue" object:
{"issue": {
  "subject": "Test subject",
  "project_id": "myProject",
  "description": "foobar"
  }
}

but new Redmine versions don't expect the project_id there, and will return a 422 "Project cannot be blank" error.  This fix moves the "project_id" field outside the "issue" object:
{"issue": {
  "subject": "Test subject",
  "description": "foobar"
  },
  "project_id": "myProject"
}

This is my test case to verify this applies to my Redmine installation:
11:02:05 ~$ curl -sX POST https://redmine.xxxxxxx.com/issues.json?key=XXXXXXXXXXXXXXXXXXX -H 'Content-type:application/json' --data '{"issue":{"subject":"Fabric Integration Test [Crashlytics]", "project_id":"parkapp-app", "description":"Crashlytics detected a new issue.\n*Fabric Integration Test* in @some_crashed_method@\n\nThis issue is affecting at least 0 users who have crashed at least 0 times.\n\nMore information: http://example.com/path/to/fabric/issue", "tracker_id":"2", "status_id":"1"}, "key":"XXXXXXXXXXXXXXXXXXX"}' | json_reformat
{
    "errors": [
        "Project cannot be blank"
    ]
}

11:02:27 ~$ curl -sX POST https://redmine.xxxxxxx.com/issues.json?key=XXXXXXXXXXXXXXXXXXX -H 'Content-type:application/json' --data '{"issue":{"subject":"Fabric Integration Test [Crashlytics]", "description":"Crashlytics detected a new issue.\n*Fabric Integration Test* in @some_crashed_method@\n\nThis issue is affecting at least 0 users who have crashed at least 0 times.\n\nMore information: http://example.com/path/to/fabric/issue", "tracker_id":"2", "status_id":"1"}, "project_id":"parkapp-app", "key":"XXXXXXXXXXXXXXXXXXX"}' | json_reformat
{
    "issue": {
        "id": 13205,
        "project": {
            "id": 346,
            "name": "App Android"
        },
        "tracker": {
            "id": 2,
            "name": "Desarrollo"
        },
        "status": {
            "id": 1,
            "name": "Nueva"
        },
        "priority": {
            "id": 4,
            "name": "Normal"
        },
        "author": {
            "id": 167,
            "name": "Crashlytics Bot"
        },
        "subject": "Fabric Integration Test [Crashlytics]",
        "description": "Crashlytics detected a new issue.\r\n*Fabric Integration Test* in @some_crashed_method@\r\n\r\nThis issue is affecting at least 0 users who have crashed at least 0 times.\r\n\r\nMore information: http://example.com/path/to/fabric/issue",
        "start_date": "2017-06-02",
        "done_ratio": 0,
        "custom_fields": [
            {
                "id": 33,
                "name": "Gravedad",
                "value": "Moderada"
            },
            {
                "id": 42,
                "name": "Relación Administrativa",
                "value": "Interna"
            },
            {
                "id": 43,
                "name": "Facturado",
                "value": "0"
            },
            {
                "id": 44,
                "name": "Nº de Factura",
                "value": ""
            }
        ],
        "created_on": "2017-06-02T09:02:48Z",
        "updated_on": "2017-06-02T09:02:48Z"
    }
}

Thanks for providing the fix @RazZziel. We'll get this deployed right away.

@RazZziel, your fix has been deployed to production, thanks again!

Confirmed, productions works on my Redmine installation, thanks!


Retrieves Cardano blocks with chainsync in pallas PoC

Why
We want to retrieve blocks from the Cardano node by using the chainsync mini protocol instead of reading the immutable files: this will allow us to get data closer to the tip of the chain (e.g. volatile data). In order to get a better understanding of the constraints of finality of the chain (e.g. handling rollbacks), we want to experiment in a PoC the usage of this mini protocol.
See

Oura: worker thread writing to a queue in the background https://github.com/txpipe/oura/blob/29fed274e8dd46948bccf05ca1ed50705d60adf0/src/sources/n2c.rs#L92
https://ouroboros-network.cardano.intersectmbo.org/pdfs/network-spec/network-spec.pdf

What
Create a PoC PallasBlockReader that can interact with Cardano chainsync mini protocol and provide a clear interface so that we can integrate it in the core developments of Mithril. This PR will not be merged in the main branch.
How

[ ] Implement a prototype PallasBlockReader
[ ] Create a lightweight documentation

FYI, @falcucci is working on the issue :+1:

@jpraynaud 👍


Enhancements and Fixes in .NET Analysis, Error Handling, and Feature Extraction

This PR encompasses a series of targeted improvements and fixes aimed at enhancing the robustness, accuracy, and user experience of our .NET analysis framework. Below is a summary of the key changes included:
Key Improvements
.NET Analysis

Analysis Issues: Addressed critical bugs in .NET analysis, ensuring more accurate and reliable outcomes.
RwLock Usage: Transitioned to parking_lot for RwLock, enhancing concurrency control throughout the codebase.

Error Handling and Feature Extraction

Error Handling: Refined error handling mechanisms, particularly during feature extraction, to provide clearer insights into processing failures.
Feature Enhancements:

Improved internal naming conventions for class features, ensuring consistency and readability.
Enhanced the JSON output format, making the data more accessible and easier to integrate with other tools.
Fixed the handling of RuleFeatureType::Namespace, correcting inaccuracies in feature categorization.

Optimization and Refactoring

PE Header Parsing: Replaced carve_pe with find_embedded_pe_headers, streamlining the extraction process.
Extractor Optimization: Modified the extractor to minimize redundant reads, improving performance.
New Features: Added StringFeature and updated extract_insn_api_features to include ApiFeature split by ::, broadening the analysis scope.

Code Quality

Number Parsing Logic: Fixed sign handling errors and introduced parse_operand_to_number for more efficient number parsing from instruction operands.
Export Name Extraction: Optimized the extraction of export names, enhancing the clarity and utility of the analysis results.

Impact
These changes are expected to significantly improve the framework's usability, accuracy, and performance. They address known issues, introduce new capabilities, and set the stage for future enhancements.
Testing
Comprehensive testing has been conducted to validate these changes. All modifications have been carefully reviewed to ensure they do not introduce regressions or adversely affect existing functionalities.
Feel free to provide feedback or ask for further clarifications on any of the changes introduced in this PR.

This is absolutely awesome!
Thank you so much for using this library and your very valuable contribution. gratitude to you :)
Thanks


Allow Custom Skins from URL for NPC

Example

Cool idea, but this is not possible unfortunately as the client only accepts textures from minecraft.net or mojang.com. This means that a skin needs to be uploaded on the Minecraft website to be displayed.


[#104625852] Don't audit updated passwords

See: https://www.pivotaltracker.com/story/show/104625852
Currently the data stored with audit events involving a password update includes the un-hashed plain-text password.  We need to not do that.

:+1:


Add parameters for ERT db creds

This fixes an issue in GCP where if the opsman and ERT DB creds are different then the pipeline fails.

I'd like to keep the sed usage over perl, but there is a conflict as that file has changed.
I won't pull in the database password changes as they need to be different values, not just the same value repeated.

@dlapiduz Do you have the permissions to unassign this PR from me? Trying to clean up my 'assigned' PR list.

Closing it for now


Suggested actions with word wrap and max height is off on macOS Safari

Screenshots
This is on macOS Safari.

This is on Windows with Edge/Chrome.

This is on IE11.

Version
R12 candidate.
Describe the bug
Given the following style options are set, if the content of the suggested actions is larger than the button itself, it display differently between Edge/Chrome and macOS Safari.
suggestedActionLayout: 'stacked',
suggestedActionHeight: 40,
suggestedActionsStackedLayoutButtonTextWrap: true,
suggestedActionsStackedLayoutButtonMaxHeight: 55

Steps to reproduce

Go to https://corinagum.github.io/WebChat-release-testing/01.create-react-app/index.html?customization=suggested-actions-multiple-lines&buttonHeight=true

Expected behavior
Suggested actions on all platforms should appears the same.
Additional context

[Bug]

This will be hard for me to work on since I don't have a mac. We'll have to coordinate later on.


the useDefaultIfNull paramter in ToCharOrDefault method is useless

https://github.com/zzzprojects/Z.ExtensionMethods/blob/master/src/Z.Core/System.Object/Convert/ToValueType/Object.ToCharOrDefault.cs#L53
Convert.ToChar(null) will throw a ArgumentNullException，So no matter the useDefaultIfNull  is true or false  the defaultValue always return

Hello @Sunzhuokai ,
Thank you for reporting,
We will look at it since the pull provided seems to change the default behavior.
Best Regards,
Jonathan

Help us to keep this library free: Donate

Hello @Sunzhuokai ,
After investigating this issue, we found at that
Convert.ToChar(null)

throw an error since the null constant is used.
However, when using a variable such as
object obj = null;
var ch = Convert.ToChar(obj);

No error is thrown.
Unless I'm wrong, the method works as intended and adding the change from your pull will do nothing since a parameter is used and not a null constant.
Let me know if the explanation is clear enough .
Best Regards,
Jonathan

Help us to keep this library free: Donate

I mean the 'useDefaultIfNull' parameter is useless
object obj = null;
obj.ToCharOrDefault('a',true); // return 'a'
obj.ToCharOrDefault('a',false);  // return 'a'

Hello @Sunzhuokai ,
That's not what my test is returning me.
object obj = null;
var ch1 = obj.ToCharOrDefault('a', true); // return 'a'
var ch2 = obj.ToCharOrDefault('a', false);  // return '\0'

There is a big difference on my side.
Best Regards,
Jonathan

you are right


chore: Generate valid header values for Bearer auth by construction rather than by filtering

Codecov Report

Merging #1148 (02e7018) into master (d414477) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
- Coverage   99.34%   99.26%   -0.09%
==========================================
  Files          69       69
  Lines        5189     5144      -45
  Branches      851      851
==========================================
- Hits         5155     5106      -49
- Misses         17       19       +2
- Partials       17       19       +2

Flag
Coverage Δ

unittests
99.26% <100.00%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/schemathesis/specs/openapi/_hypothesis.py
100.00% <100.00%> (ø)

src/schemathesis/extra/pytest_plugin.py
98.21% <0.00%> (-1.79%)
:arrow_down:

src/schemathesis/cli/callbacks.py
98.24% <0.00%> (-1.76%)
:arrow_down:

src/schemathesis/serializers.py
97.87% <0.00%> (-0.15%)
:arrow_down:

src/schemathesis/lazy.py
95.28% <0.00%> (-0.05%)
:arrow_down:

src/schemathesis/runner/impl/core.py
97.31% <0.00%> (-0.02%)
:arrow_down:

src/schemathesis/models.py
99.14% <0.00%> (-0.02%)
:arrow_down:

src/schemathesis/hooks.py
100.00% <0.00%> (ø)

src/schemathesis/targets.py
100.00% <0.00%> (ø)

src/schemathesis/stateful.py
100.00% <0.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d414477...02e7018. Read the comment docs.


Firebase permission issue?

https://www.dropbox.com/s/tqp515vejikbjah/Screenshot 2016-08-13 11.46.50.png?dl=0

Thanks for spotting this. I was able to reproduce it with a newly-created Firebase database, which appears to have security rules that require authentication by default now. You can get the app working by changing the security rules to:
{
  "rules": {
    ".read": true,
    ".write": true
  }
}

I've updated the README to reflect needing to make that Firebase change.

Closing this since I think the README update addresses it, but feel free to reopen if that doesn't fix it for you.


In Travis use latest ruby releases + trusty

The nice rvm aliases in Travis (2.1, 2.2, etc) have never been updated
and point to some really old releases. We should specify the latest
releases of these feature releases. Also if we require sudo then we're
running the GCE environment and we can also specify that we want to run
on the Trusty "beta" image which has much newer deps all around.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

I spent some time yesterday tracking this down https://github.com/travis-ci/travis-rubies/issues/19

i think this is now colliding with work that keiser is doing to be doing, at any rate should probably get done after that lands...


Running node under sudo doesn't use the default node.js version

If I install node.js under version X, then install nvm and install version Y and make it the default, things work fine if you just run node. But if you use sudo node, version X is run instead of version Y. I'm even using a root user to do all these things, so its much less likely there's weird user issues going on.
How can I make sudo node run the right version?

This is by design. With nvm, you never need sudo - nvm is for a single user on a single shell.
If you want to use node as root (which is a very bad idea) then you need to install nvm as root.

Thanks for the quick response.
Right, but I did install nvm as root - root's the only user on this system.

The purpose of sudo is to run as a different user - when you're already root, there's never a need to use sudo.
That said, I'd recommend making a limited user account, and running nvm and node under that.

Definitely agree that I shouldn't need root or sudo, but there are some other unrelated barriers to that I don't want to troubleshoot at the moment. I suppose I don't need to use sudo in this particular case, but if I do run into such a case, isn't it strange that using sudo while you are root does something different than the same command without sudo while you're root?

Specifically it's because sudo starts a new shell environment, which has a different PATH and won't likely have nvm loaded at all. I'm sure there's a way to make it work, but I haven't researched it since it's not often advisable or desired.

Yeah, nvm isn't available at all under sudo. Ok, well thanks for your help! I just won't use sudo if i'm root, that works.

Sorry to post on an old thread but all the info is here.
I installed nvm as a user (pi) and I want to run a node file with root permissions.
I have set the default alias as described in this issue so that both of these work
pi user: node -v result: v5.3.0
then sudo su
node -v result: v5.3.0
but if I am the pi user and try to run sudo node I get the sudo: node: command not found error
Why doesn't this work? I dont want to be root all the time (as suggested in this issue) But I need to run this node instance as root. Any suggestions?

@NickBolles nvm is intended to be per-user, per-shell. Why do you think you ever need to run node as root? You may find https://thomashunter.name/blog/using-authbind-with-node-js/ helpful.

According to https://github.com/beyondscreen/node-rpi-ws281x-native#needs-to-run-as-root the module needs to run as root to have direct access to the physical memory, in order to control the raspberry pi  PWM and DMA-modules.

@ljharb Its not just some newbie mistake that one would expect nvm to work with sudo and be a bit lost as to how to use node without the ability to sudo. Linux doesn't make it easy and the know-how is unfortunately not very widespread. So I could ask you why you're at all surprised that someone might think they should be able to, or need to, run node as root or with sudo? The idea that its unsafe to install node globally so any user can use it is kind of a huge failing of linux (not that other OSes do it great either), not a huge failing of linux users.

It's unsafe to install anything globally so any user can use it.

@NickBolles no, nvm is per-user/per-shell, nave is per-user/per-subshell, and n is global/system-wide.

@ljharb I agree with you - you're 100% right. But doing things the right way isn't a smooth process.

I'm about to genuinely buy a rope, a stool and hang myself with the process of using NVM with a system service to run my program at startup.


ThreadSafeReference crash when set readonly-configuration

Hi, anyone can fix help me this bug. app crashed when I used ThreadSafeReference with readonly configuration. I use realm database in bundle. Below code crash.

thread_safe_reference.cpp#39:
m_version_id = get_source_shared_group().pin_version();

Hey @phuocmobytelab , could you provide is with a bit more information/context? A code sample / stack trace would be useful for debugging here.

Hi @jsflax I think the same bug with #5475. Can you check help me please?

@phuocmobytelab In order to help you we need the following information:

Version of Realm that you are using.
Are you using Sync.
What platforms are you targeting
Some code showing how you are using the ThreadSafeReference

Thanks.

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@phuocmobytelab Just to confirm your assumption. This is indeed a duplicate of #5475. We'll continue our works there.


Can't register more than one class?

Consider this (rudimentary) project: https://github.com/Des-Nerger/GodotZigBindings-demo-projects/tree/52240ff/dodge_the_creeps
It has a player scene with a class defined in a Zig GDExtension; all work fine. However, if I clone this same class giving it a different name:
$ sed 's/Player/ExactSamePlayer/' player.zig >exact_same_player.zig

And then try to register this new class along with the old one:
--- a/dodge_the_creeps/lib.zig
+++ b/dodge_the_creeps/lib.zig
@@ -11,4 +11,5 @@ fn gdextension_initialize(init_level: gi.GDExtensionInitializationLevel) callcon
         inline for (.{
+            @import("exact_same_player.zig").ExactSamePlayer,
             @import("player.zig").Player,
         }) |user_class|
             ClassDB.registerClass(user_class, false, false); // _, is_virtual, is_abstract

, the old one just stops working: it doesn't react to input, etc.
Do you have an idea why this is happening?

Hm, interesting. Looks the order of the imports is significant. If I import Player first, and only after do ExactSamePlayer, then the things don't break out. :thinking:


Add spellcheck and remove  opencl from CI as it is not needed

Signed-off-by: Krasi Georgiev<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 607879775

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 38.742%

Files with Coverage Reduction
New Missed Lines
%

pkg/tracker/psrs.go
2
81.69%

Totals

Change from base Build 598659030:
-0.05%

Covered Lines:
1509

Relevant Lines:
3895

💛  - Coveralls


Add Grey UI Buttons

Adds grey UI Buttons that are more pleasant to look at in the Code Editor and Export Configuration.

Added:

The "Cancel" and "Export" buttons should remain blue. OTOH this new theme should be applied to color_edit, color_field, enum_field, and number_field_with_slider.

This gave me a different idea.

Superseded by #231


Implement test suite and CI

API code should be tested with an automated test suite that runs for every pull request.

Closed by #7


Kitchen tests. SSL. Java CA certs. Project creation.

Fixes #92 , #93 , #94 , and #95
It might be good to review individual commits for some of these changes so that things don't get conflated.

@ChiefAlexander Would you be able to log an issue that describes what we were fixing here? https://github.com/Webtrends/rundeck/commit/1887bbdd74132f98e0d64f16d3240ebf306b6a8a
Thanks!

Rubocop offenses have been fixed.

⚠ During the merge, I'd like to remove the (obvious) Jira identifiers in the commit messages.

@pcross616 As discussed outside the pull request, I know this is a big one but do you know when you'll be able to take a look at this? I could try breaking this apart if needed.

Discussed with Pete offline, we are good to merge this and do a release.


Pursue parity between fixed_point and int

In particular:

compound assignment
bitwise operations
shift operators - static and dynamic
basically anything in this list that can be overloaded

division


IGNITE-11922 Register ClusterMetricsMXBeanImpl metrics

Please, solve merge conflicts
We should cache specific Counters instead of query it from registry on each access.
Please, double check usages of add and set. add - ads some value to the counter while set sets it. Seems, we have issues with it in the PR.