Thread page restyle and overall theme tweaks

Restyled the view a thread page
Moved links on threads and posts into an "action bar" with icons for actions like add, edit, delete, report, etc.
Restyled answered questions
Tweaked dark and light styles.
Fixed ordering of columns by a person's "handed-ness"

Known issue:
The "delete" methods for threads and posts were just stubbed out. It was going to be a bigger task to make those work correctly and update the UI correctly than should be included in this PR.
Note: I tried simplifying the "handedness" of classes into a common function, but that didn't work with Tailwind since it didn't know the style should be included in the built stylesheet because it couldn't find the styles on the page.

Thanks for the comments.
What role is your user? Edit and delete should only show up for the author or an admin. I know my default user was not an admin when I started messing with that.

I did do most of my work while logged in as an admin.
Refactoring the action bar into a Cell so it can be more easily tested. Better in the long run, especially when we start working on the Trust system.

Refactor of the Action Bar is complete.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

109 of 125 (87.2%)  changed or added relevant lines in 11 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.3%) to 78.833%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/Cells/ActionBarCell.php
24
26
92.31%

app/Controllers/Discussions/ThreadController.php
0
3
0.0%

app/Cells/action_bar.php
62
73
84.93%

Files with Coverage Reduction
New Missed Lines
%

app/Controllers/Account/AccountController.php
1
63.95%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
2283

Relevant Lines:
2896

💛  - Coveralls

First - I ran cs-fix and rector-fix before pushing this code up. Bastards.
Second, and more important: @michalsn how would you feel if I ripped Psalm out? I've been thinking for a bit that I don't know that it's worth the squeeze when you compare what it catches vs how much BS you have to do and write to make the analyzer happy that really doesn't impact us developers.

Oh... I feel the frustration over Psalm - I have been there and struggled too. You have to rename the cell view to: action_bar_cell.php (and declare a custom view name in the cell class) so it catches the rule: https://github.com/lonnieezell/forum-example/blob/develop/phpunit.xml.dist#L29 - it will solve the issue.
For me, most of the time Psalm is painless, so unless you are really determined to ditch it, I would keep it around.

ad. 1 - I see it now. It's all just because we check the "old" permission. Easy fix.

You have to rename the cell view to: action_bar_cell.php (and declare a custom view name in the cell class) so it catches the rule...

Why does CI have it setup like that? I'm guessing that's old and never got switched over after we switched up how we rename views in Cells? If you use our command to generate the rule it should not get caught by our robotic overlords. But I'll do that for now.

For me, most of the time Psalm is painless, so unless you are really determined to ditch it, I would keep it around.

My problem wasn't so much this, but I based on #132 I went through to start cleaning it up a week or two ago and there were like 1800 errors, or something ridiculous. I spent a  little while starting to wade through, but just realized I have zero interest in teaching it how to read my code. :) I know it has some benefits, but I get so exhausted watching the issues come through from CI where it feels like 1/3 of them is us changing stuff just to make our tools happy, which is a huge loss in doing something worthwhile and the gain doesn't feel like much, especially with all of the other tooling we have in place. Maybe I'm just old and grumpy :)

The last thing is the tags in the thread list. I can't see them even if they are assigned to a thread. I see them only after entering the thread. Is this the way it is supposed to be?

I did remove them from the list just to clean things up. I am not convinced they are really helpful on that screen as it is. However, I've also been thinking that it would be nice if that list was more helpful and you could do more from that screen instead of having to click through to other pages. Still debating it but I might end up making it so they can be expanded so you can read the article in place, and maybe the latest few posts, or something. Not sure, but that page feels lacking to me.  I guess it feels too static and that we could take a few cues from social media to improve it instead of just being a forum.

Why does CI have it setup like that? I'm guessing that's old and never got switched over after we switched up how we rename views in Cells? If you use our command to generate the rule it should not get caught by our robotic overlords. But I'll do that for now.

Yes, exactly. I keep renaming view names for cells since I don't know how else I can automatically set a rule to exclude them from the PHPUnit scan.

My problem wasn't so much this, but I based on https://github.com/lonnieezell/forum-example/issues/132 I went through to start cleaning it up a week or two ago and there were like 1800 errors, or something ridiculous.

Fair enough, I wasn't paying much attention to it since I thought it was related to the errorLevel we set in the psalm.xml. And depending on the level we set, it will be treated as an error or simply an issue. If that is not the case, then it sucks 😜 Anyway, I'm fine with removing Psalm.

I did remove them from the list just to clean things up. I am not convinced they are really helpful on that screen as it is.

Okay, I get it.

However, I've also been thinking that it would be nice if that list was more helpful and you could do more from that screen instead of having to click through to other pages.

Yes, we can definitely experiment with this.

Still debating it but I might end up making it so they can be expanded so you can read the article in place, and maybe the latest few posts, or something. Not sure, but that page feels lacking to me. I guess it feels too static and that we could take a few cues from social media to improve it instead of just being a forum.

We could add an option to bookmark the thread, and then the latest posts would show up after login, however, this is a feature only for logged-in users - not everyone.

Fair enough, I wasn't paying much attention to it since I thought it was related to the errorLevel we set in the psalm.xml. And depending on the level we set, it will be treated as an error or simply an issue. If that is not the case, then it sucks 😜 Anyway, I'm fine with removing Psalm.

That's a fair point and I'm not sure if all of the other Info entries were what would be included at other levels. That might be the case. I'll probably remove it anyway. I don't see the need for 2 static analyses tools.
I'm on a bit of a "how can we simplify everything" kick right now. :)

We could add an option to bookmark the thread, and then the latest posts would show up after login, however, this is a feature only for logged-in users - not everyone.

Definitely something to consider.
I've also had an idea for a couple of years as I've played with forum software that it would be nice if the page you hit after logging in was more of a social network style feed, where it would know what you're watching/interacting with/etc and have the default view sorted for you. That sounds more like something that could be done down the road and easily added as another view on the main discussions list page.


Output Discrepancy in TensorFlow XLA Compilation with Operand Order Swap in Addition with tf.rev + tf.math.argmax

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
2.15.0
Custom code
Yes
OS platform and distribution
Ubuntu 22.04.3 LTS
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
In TensorFlow 2.15.0, a inconsistency arises when swapping the order of operands in an addition operation followed by tf.math.argmax, under XLA compilation.
This error is seen both on cpu and gpu.
Standalone code to reproduce the issue
import tensorflow as tf
import numpy as np

class Model1(tf.keras.Model):
    @tf.function(jit_compile=True)
    def __call__(self, inp1, inp2):
        mul = tf.matmul(inp2, inp1)
        rev = tf.reverse(mul, axis=[1])
        add = tf.add(rev, mul)
        argmax = tf.math.argmax(add, axis=1)
        return add, argmax,

class Model2(tf.keras.Model):
    @tf.function(jit_compile=True)
    def __call__(self, inp1, inp2):
        mul = tf.matmul(inp2, inp1)
        rev = tf.reverse(mul, axis=[1])
        add = tf.add(mul, rev)
        # add = tf.add(rev, mul) <- this will not trigger error
        argmax = tf.math.argmax(add, axis=1)
        return add, argmax,

inputs = [
tf.random.uniform(shape=[1, 18], dtype=tf.float32),
tf.random.uniform(shape=[34, 1], dtype=tf.float32),
]
model1 = Model1()
model2 = Model2()
device = "cpu"
with tf.device(device):
    tf.config.run_functions_eagerly(True)
    out1 = model1(*inputs)
    out2 = model2(*inputs)
    print(f'=========eager_output(version:{tf.__version__})================')
    try :
        for i in range(min(len(out1),len(out2))):
            np.testing.assert_allclose(out1[i].numpy(), out2[i].numpy(), rtol=0.001, atol=0.001, err_msg=f'at checking {i}th')
        print("XLA_eager does not trigger assertion")
    except AssertionError as e:
        print("XLA_eager triggers assertion")
        print(e)
    tf.config.run_functions_eagerly(False)
    out1 = model1(*inputs)
    out2 = model2(*inputs)
    print(f'=========compiled_output(version:{tf.__version__})================')
    try :
        for i in range(min(len(out1),len(out2))):
            np.testing.assert_allclose(out1[i].numpy(), out2[i].numpy(), rtol=0.001, atol=0.001, err_msg=f'at checking {i}th')
        print("XLA_complie does not trigger assertion")
    except AssertionError as e:
        print("XLA_complie triggers assertion")
        print(e)

Relevant log output
=========eager_output(version:2.15.0)================
XLA_eager does not trigger assertion
2023-11-30 17:52:36.159568: I external/local_xla/xla/service/service.cc:168] XLA service 0x55bc4ba863c0 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2023-11-30 17:52:36.159586: I external/local_xla/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1701366756.171765 2872023 device_compiler.h:186] Compiled cluster using XLA!  This line is logged at most once for the lifetime of the process.
2023-11-30 17:52:36.171907: E external/local_xla/xla/stream_executor/stream_executor_internal.h:177] SetPriority unimplemented for this stream.
=========compiled_output(version:2.15.0)================
XLA_complie triggers assertion

Not equal to tolerance rtol=0.001, atol=0.001
at checking 1th # indicates that errors happen after applied tf.math.argmax
Mismatched elements: 11 / 34 (32.4%)
Max absolute difference: 3
Max relative difference: 0.42857143
 x: array([ 7,  7,  7,  7,  7,  7, 10,  7,  7,  7,  7,  7,  7,  7,  7,  7, 10,
        7,  7,  7,  7,  7,  7,  7,  7, 10, 10,  7,  7,  7,  7,  7,  7,  7])
 y: array([ 7,  7,  7,  7,  7,  7,  7,  7,  7,  7,  7, 10,  7, 10,  7,  7,  7,
       10, 10,  7,  7,  7,  7, 10,  7,  7,  7,  7, 10,  7,  7,  7, 10,  7])```

@sachinprasadhs I was able to replicate this issue on colab, please find the gist here.
Thank you!

Hi,
This behavior is expected, since the change in order of operation results in the different code path for numerical computations. Thanks!


Import geology KML file

[ ] Leanne to provide files
[ ] Load into Arches

File name in gis_data: FRPC_BR_20210419.kml, FRPC_OVB_20210419.kml

There are some massive geometries in these files that we'll need to figure out how to deal with. The geometry sizes are currently causing performance issues in the application.

Not importing the geometries for now due to the geometry sizes. The process is there, but the insert is commented out. Performance issue to be handled in #214.

Try removing OVB from load to see if this sorts out performance issue.


Reorganize RequestMapper and friends

The goal of this PR is to properly split RequestMapper into different classes, one for each concern. The final result of this PR looks like this:

The part of RequestMapper doing the reconciliation of the internal maps of producers is moved inside the class called IngressProducerReconciliableStore.
The logic of the request handling is not organized anymore in decorators and then RequestMapper as the final step, but it's "orchestrated" by the ReceiverVerticle.handle method as follows:

A bunch of "pre handlers" are executed, these includes the method not allowed check, the probe handler and potentially other checks/headers put in future, like the webhoook stuff. These just implement Handler<HttpServerRequest> and do not wrap the next handler anymore.
The ReceiverVerticle owns the IngressProducerReconciliableStore, which it queries to find out the IngressProducer associated to that request
If the IngressProducer resolved is not null, the IngressRequestHandler is invoked, which will produce the record and end the request

cc @pierDipi how does it looks like? I still need to reorg the tests, but is it a bit more organized now?

General I like the notion of Ingress... on the class names. We should do for "egress" too (e.g. Egress...).
Just wondering should we also move that to dedicated packages?

Just wondering should we also move that to dedicated packages?

About package reorg, I think what we have in this PR is already good enough... Do you have something in particular?

There are failures https://github.com/knative-sandbox/eventing-kafka-broker/pull/1041/checks?check_run_id=2931263174
Error:  Errors:
Error:    RequestMapperTest.lambda$testStore$18:298->lambda$testStore$15:298 » NullPointer
Error:    RequestMapperTest.lambda$testStore$18:298->lambda$testStore$15:298 » NullPointer
Error:    RequestMapperTest.lambda$testStore$18:298->lambda$testStore$15:298 » NullPointer
Error:    RequestMapperTest.lambda$testStore$18:298->lambda$testStore$15:298 » NullPointer
Error:    RequestMapperTest.lambda$testStore$18:298->lambda$testStore$15:298 » NullPointer

/lgtm

/unhold

/lgtm

/lgtm


fix(vitest): ensure restoring terminal cursor on close

Description

Closes https://github.com/vitest-dev/vitest/issues/5247

I couldn't identify the actual cause of cursor not getting back only on typecheck run, so I went with using logUpdate.done to explicitly restore the cursor. There could be some deeper bug specific to typecheck run, but I couldn't see anything suspicious.
additional notes

log-update is used only for reporters such as dot and default reporters on TTY, so the bug doesn't occur when using --reporter=tap for example.
log-update internally uses cli-cursor, which in turn uses restore-cursor. Since we haven't used logUpdate.done, probably we're relying on restore-cursor's automatic restoration, which somehow doesn't work on typecheck mode.

test

run pnpm -C examples/typecheck test:run
verify cursor is restored

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[ ] Ideally, include a test that fails without this PR but passes with it.
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[ ] Run the tests with pnpm test:ci.

Documentation

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

If typecheck run is now interrupted with CTRL+c, does the cursor restore correctly?

I just tested now and surprisingly it restores correctly both before and after this fix.
I'd like to get to the bottom of it. I'm guessing something wrong with restore-cursor or signal-exit, but it would be still bizarre if typecheck + run would affect anything, so I might be looking at the wrong thing.


feat: tracer init defaults to stderr

Resolves https://github.com/infinyon/future-aio/issues/213

bump up cargo version?

bump up cargo version?

done


Add GetInactive() functions

Resolves issue #579

Coverage remained the same at 70.475% when pulling dbdf996db3832e0bdb026c566fee753d46c2fad8 on inactive-l1s into 71261c14c4347c545fd393362aaf65f03d33e089 on master.


RTL, Arabic Text Marker not rendering properly in PDF

In https://github.com/metanorma/isodoc/issues/166, I've decided to use Right to Left Text Marker and Arabic Text Marker, to delimit runs of inline Hebrew or Arabic script text within left to right text. I've chosen to use the Unicode characters, rather than markup, to yield a solution compatible with Word, which uses HTML 4 (and thus does not know about directionality markup.)
This works in HTML and DOC. It is not working in PDF, but it is not working for a roundabout reason.

Arabic text has in Unicode a distinct control character, https://en.wikipedia.org/wiki/Arabic_letter_mark. This was proposed in order to produce different behaviour of European Arabic numeral digits around Arabic text, as argued in https://unicode.org/L2/L2011/11432r-n4180r-alm-form.pdf . So the use of U+61C is not incorrect.
However, U+61C is absent in the font used by default for text in the PDF.
U+61C will clearly be present for a font specific to Arabic. Moreover, for Hebrew I use the RLM control character, https://en.wikipedia.org/wiki/Right-to-left_mark, and that is present in the default PDF font.

I can go to bidirectional markup instead of control markers if I need to (<bdi> or <xxx direction=rtl>), but I'd like to confirm that I need to, because I'll need to switch that solution out for Word. I am also introducing explicit language and script attributes for these interpolations in IEV, so that you can make sensible font choices.
Attaching sample document. Note also from the attached that <preferred> should NOT be prefixed with term numbers in PDF; only the first instance of <preferred> should do so, and I am already doing that in the Presentation XML markup.
hebrew-arabic.zip

@opoudjis DOC and HTML look differently in my environment (Win7 64-bit, Microsoft Office 2019, Arial font 5.22 - arial.ttf 774236 bytes):

HTML:

Done:

[x] IEC xslt updated
[x] @language processing added
[x] mn2pdf updated for replacing U+61C (Arabic Text Marker) to U+200B (Zero-width space)

PDF renders so:

Examples from https://unicode.org/L2/L2011/11432r-n4180r-alm-form.pdf:

Thank you for updating that. I may end up having to replace U+61C to RLM in Word too; the character was added in 2011, and we are using DOC, which dates from before 2008.


Reading log guidance

Hi I wanted to test various mitigation settings to compare performance and was wondering what was the best way going about to do that from inspecting logs, given a line sequence like:
2021-07-22 20:29:10.780	AnimationLockLatencyHandler	16f4: C2S_ActionRequest(0175): actionId=08cf sequence=0e22 delay=1358ms
2021-07-22 20:29:10.963	AnimationLockLatencyHandler	16f4: S2C_ActionEffect(0102): actionId=08cf sourceSequence=0e22 rtt=188ms pingLatency=33ms delay=75ms wait=600ms->487ms next=19:29:11.4507252
2021-07-22 20:29:11.451	AnimationLockLatencyHandler	16f4: S2C_ActionEffect(0102): actionId=0007 sourceSequence=0000 serverOriginated wait=108ms->100ms next=19:29:11.5517470
2021-07-22 20:29:12.214	AnimationLockLatencyHandler	16f4: C2S_ActionRequest(0175): actionId=1e8e8c sequence=0e23 delay=666ms

Also sometimes the wait value is not 600, even for non-single digit actionids (which I read on a comment somewhere to ignore)
2021-07-22 20:28:30.228	AnimationLockLatencyHandler	16f4: S2C_ActionEffect(0102): actionId=4976 sourceSequence=0e01 rtt=204ms pingLatency=34ms delay=75ms wait=349ms->220ms next=19:28:30.4481509
2021-07-22 20:28:30.510	AnimationLockLatencyHandler	16f4: C2S_ActionRequest(0175): actionId=4975 sequence=0e02 delay=76ms

What values are we trying to minimize here? is delay=X what the program "adjusts" our latency to be in terms of performing the actions locally?

actionId states which action you used, including auto attacks, weaponskills, spells, and abilities. When auto attack happens, wait value may be any value between previous action's animation lock duration and 100ms. delay is the simulated server response time. Note that it's not ping; the server may take longer than usual even when your ping itself is stable, like when you were moving around.

Thanks for responding. So in essence if we want to see whether the options such as Use Delay Detection and Use Latency Correction are better or worse, we want to minimize the wait value? (to ensure the lowest amount of time between animation lock and next action)?

Yes, that's correct.


Update Release

Update Release pls. I downloaded and for a long time could not understand why I did not have new features, until I realized that I had downloaded the old version.

Dd7to9 and DDrawCompat can work together?

with Dd7to9 in Space Rangers 2 Dominators not run planet battle.

Ok, this is something I will need to look at later.

Boot screen saver won't go away.

Are you saying that the screensaver sometimes comes on when playing a game?  I should be able to turn this off.

With only EnableDdrawWrapper game not run.

Could be a bug in the wrapper.

Why new version not in Release page.

I have several dozen games I test before releasing a new build.  This process can take a while and I have not had time to do that yet.

With DDdrawCompat work.

If DDdrawCompat works, why not just use that?

Could Github CI be set up and built daily with Actions?

Could Github CI be set up and built daily with Actions?

CI was setup.  But I don't always change the build each day.
The video card on my computer died and it will take longer to finish the testing. I plan to release an update before the end of the year.

Duplicate of #152.


Modular Module Loading

Hi everyone,
I'm relatively new to sails. Have been having fun with it now for a while and it's awesome. So thanx very much for the great work.
I see there has been a bit conversation going on regarding loading controllers and services from subfolders within the respective directories and so on.
I have a related question, it looks a bit different though in that I want to load modules in a modular way.
Let me explain.
Currently the my sails api looks something like this:

├── api
|    ├── controllers
|    |      ├── UserController.js
|    |      ├── ProductController.js
|    |      ├── ClientController.js
|    ├── models
|    |      ├── User.js
|    |      ├── Product.js
|    |      ├── Client.js

I would like to group all entity related code together, so that a single folder contains all the code of a specific entity. It would then look like this:

├── api
|    ├── User
|    |      ├── UserController.js
|    |      ├── User.js
|    ├── Product
|    |      ├── ProductController.js
|    |      ├── Product.js
|    ├── Client
|    |      ├── ClientController.js
|    |      ├── Client.js

I see the where and how is described in the moduleloader hook. Is what I'm trying to do possible out of box maybe? or should I go for implementing a custom hook of some sort?

@theocoria welcome!  And thanks for the detailed explanation.

should I go for implementing a custom hook of some sort?

That would be awesome.  The best/easiest way to tell whether something like this is going to work is to implement it as a hook and start using it when building real-world apps.
The cleanest approach is probably to copy the moduleloader hook from sails core into a new repo (like I did here for the orm hook), add the package.json for your hook, then make some changes.  To test locally, you can run npm link from inside your hook and e.g. npm link your-hooks-package-name-in-the-package-json from inside a test project.  Be sure to set hookName: 'moduleloader' and isHook: true in your hook's package.json.
Hope that helps, and good luck!  If you run into anything you suspect is a bug when overriding the hook, please let us know by opening a new issue.

@mikermcneil Fantastic, was hoping for a chance to contribute to the sails community.     Also, in case it's helpful, I just updated the core docs for this hook: https://github.com/balderdashy/sails/blob/master/lib/hooks/controllers/README.md

@mikermcneil hey man....I was hashing this out now for a while....followed the code everywhere....hehe
So, what I've seen thus far, and this is now with Sails version 0.11.4, is that when you define the custom hook with the same name as you described above, the moduleloader in sails core picks it up and says the core code is being over written. But it never gets executed. I eventually found the code in loadHooks.js (sails/lib/app/private) that seems to be the problem, for ease of view here is the relevant part:
    // First load the moduleloader (if any)
    moduleloader: function(cb) {
      if (!hooks.moduleloader) {
        return cb();
      }
      prepareHook('moduleloader');
      applyDefaults(hooks['moduleloader']);
      hooks['moduleloader'].configure();
      loadHook('moduleloader', cb);
    },

    // Next load the user config (if any)
    userconfig: function(cb) {
      if (!hooks.userconfig) {
        return cb();
      }
      prepareHook('userconfig');
      applyDefaults(hooks['userconfig']);
      hooks['userconfig'].configure();
      loadHook('userconfig', cb);
    },

    // Next get the user hooks (if any), which will be
    // added to the list of hooks to load
    userhooks: function(cb) {
      if (!hooks.userhooks) {
        return cb();
      }
      prepareHook('userhooks');
      applyDefaults(hooks['userhooks']);
      hooks['userhooks'].configure();
      loadHook('userhooks', cb);
    },

    // Prepare all other hooks
    prepare: function(cb) {
      async.each(_.without(_.keys(hooks), 'userconfig', 'moduleloader', 'userhooks'), function (id, cb) {
        prepareHook(id);
        // Defer to next tick to allow other stuff to happen
        process.nextTick(cb);
      }, cb);
    },

    // Apply the default config for all other hooks
    defaults: function(cb) {
      async.each(_.without(_.keys(hooks), 'userconfig', 'moduleloader', 'userhooks'), function (id, cb) {
        var hook = hooks[id];
        applyDefaults(hook);
        // Defer to next tick to allow other stuff to happen
        process.nextTick(cb);
      }, cb);
    },

    // Run configuration method for all other hooks
    configure: function(cb) {
      async.each(_.without(_.keys(hooks), 'userconfig', 'moduleloader', 'userhooks'), function (id, cb) {
        var hook = hooks[id];
        hook.configure();
        // Defer to next tick to allow other stuff to happen
        process.nextTick(cb);
      }, cb);
    },

    // Load all other hooks
    load: function(cb) {
      async.each(_.without(_.keys(hooks), 'userconfig', 'moduleloader', 'userhooks'), function (id, cb) {
        sails.log.silly('Loading hook: ' + id);
        loadHook(id, cb);
      }, cb);
    }

Am I correct in my understanding that even thought the module loader might have been overwritten it will never execute?

@mikermcneil Any thoughts so far?


Spankbang.com : some pages are not supported.

Hi,
They are some pages on spankbang.com which are not supported:
$ youtube-dl --ignore-config -v -F http://spankbang.com/1vt0/video/solvane+gangbang
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'--ignore-config', u'-v', u'-F', u'http://spankbang.com/1vt0/video/solvane+gangbang']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.02.01
[debug] Python version 2.7.8 - Linux-3.16.0-44-generic-x86_64-with-Ubuntu-14.10-utopic
[debug] exe versions: avconv 11.2-6, avprobe 11.2-6, ffmpeg N-77455-g4707497, ffprobe N-77455-g4707497, rtmpdump 2.4
[debug] Proxy map: {}
[SpankBang] 1vt0: Downloading webpage
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 666, in extract_info
ie_result = ie.extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 313, in extract
return self._real_extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/spankbang.py", line 38, in _real_extract
self._sort_formats(formats)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 826, in _sort_formats
raise ExtractorError('No video formats found')
ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Can you fix this ?

This issue has been fixed and fix will be incorporated in the next version of youtube-dl.


Query Builder::tap method not consistent with collection or helper

Laravel Version: 7.20.0
PHP Version: 7.4.8

Description:
The tap method, in both Collection and Support/helpers, returns the value that it was called with, ignoring the return value of the closure.  I believe this is the expected behaviour.  However, because the BuildsQueries::tap method defers to when, it will actually only return the expected value if the closure returns falsey/void.
Steps To Reproduce:
I modified the existing test in \Illuminate\Tests\Database\DatabaseConcernsBuildsQueriesTraitTest to illustrate the issue:
    public function testTapCallbackInstance()
    {
        $mock = $this->getMockForTrait(BuildsQueries::class);
        $result = $mock->tap(function ($builder) use ($mock) {
            $this->assertEquals($mock, $builder);
            return 1;
        });
        $this->assertEquals($mock, $result);
    }

This fails because $result === 1 here, when it should not.  This may seem a bit contrived.  The reason this issue popped up for me is I was using arrow functions, which always return a value.  e.g.
    public function testTapCallbackInstance()
    {
        $mock = $this->getMockForTrait(BuildsQueries::class);
        $result = $mock->tap(fn ($builder) => 1);
        $this->assertEquals($mock, $result);
    }

The reasoning here is that I want to be able to chain tap calls regardless of what they return.
User::where(...)
    ->tap(fn ($query) => collect([1,2])->each(fn ($i) => $query->orWhere('i', $i)))
    ->orWhere(...)
    ->get();

This fails because orWhere is called on the Collection instance instead of the Builder.
It's a simple fix, unfortunately this method has been around in its current form since v5.4.16 and fixing it would be a breaking change.

We could fix this but probably needs to go to master.

PR welcome on master.


Video filter not applied

ouput.mp4 Video stored in phone's storage location (storage/emulated/0/output.mp4).
But failted to convert video to filtered video.
Logcat error:-
E/cgeExt: Open /storage/emulated/0/output.mp4 failed!
I/cgeExt: generate over!
I/cgeExt: ####CGESharedGLContext Destroying context... ####
E/Surface: getSlotFromBufferLocked: unknown buffer: 0xb9ad97c8

Check if the app has the permission to read SD card.

I have used read and write permissions in mainfest:-

Getting Same error:-
E/cgeExt: Open /storage/emulated/0/output.mp4 failed!
I/cgeExt: generate over!
I/cgeExt: ####CGESharedGLContext Destroying context... ####
E/Surface: getSlotFromBufferLocked: unknown buffer: 0xb9ad97c8
In my App , i have used three categories for video recording: normal, fast and slow. But video filters works only, when video recorded by normal recording case.
In fast and slow video cases, video filters not working.
i am using FFMPEG library for convert video normal to fast or slow.
Fast video command:-
String[] command = {"-y", "-i", yourRealPath, "-filter_complex", "[0:v]setpts=0.25*PTS[v];[0:a]atempo=2.0[a]", "-map", "[v]", "-map", "[a]", "-b:v", "2097k", "-r", "60", "-vcodec", "mpeg4", outputPath};
Slow video Command:-
String[] command = {"-y", "-i", yourRealPath, "-filter_complex", "[0:v]setpts=2.0*PTS[v];[0:a]atempo=0.5[a]", "-map", "[v]", "-map", "[a]", "-b:v", "2097k", "-r", "60", "-vcodec", "mpeg4", outputPath};
These command are working fine and convert video to fast or slow video,  but only filters not working on it.
can you help in that.
Thanks

I have used read and write permissions in mainfest:-
uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"
uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"
Getting Same error:-
E/cgeExt: Open /storage/emulated/0/output.mp4 failed!
I/cgeExt: generate over!
I/cgeExt: ####CGESharedGLContext Destroying context... ####
E/Surface: getSlotFromBufferLocked: unknown buffer: 0xb9ad97c8
In my App , i have used three categories for video recording: normal, fast and slow. But video filters works only, when video recorded by normal recording case.
In fast and slow video cases, video filters not working.
i am using FFMPEG library for convert video normal to fast or slow.
Fast video command:-
String[] command = {"-y", "-i", yourRealPath, "-filter_complex", "[0:v]setpts=0.25*PTS[v];[0:a]atempo=2.0[a]", "-map", "[v]", "-map", "[a]", "-b:v", "2097k", "-r", "60", "-vcodec", "mpeg4", outputPath};
Slow video Command:-
String[] command = {"-y", "-i", yourRealPath, "-filter_complex", "[0:v]setpts=2.0*PTS[v];[0:a]atempo=0.5[a]", "-map", "[v]", "-map", "[a]", "-b:v", "2097k", "-r", "60", "-vcodec", "mpeg4", outputPath};
These command are working fine and convert video to fast or slow video, but only filters not working on it.
can you help in that.
Thanks

replace /storage/emulated/0/ with /sdcard/


warc2text tries to read large warc records into memory, causing OOM

When trying to warc2text this massive (29G) file on cirrus /beegfs/paracrawl/data/ia/wide00015-warcs/WIDE-20170107025349-crawl808/WIDE-20170107025349-02068.warc.gz it is killed by the OOM killer.
I know this is a design choice, and it's not really high priority, but it would be nice if there would be a way to deal with it without skipping the whole warc file. E.g.

partially read a record so we can parse the header and estimate whether it is of interest, and if not just skip over the rest of the record, not trying to store it in memory.
or easier, have WARCReader::getRecord skip a record if, while reading & deflating, it starts to become large.

I have implemented the easy fix for now, but it is definitely a good idea to refactor in the future and parse the WARC header before reading the entire body
I'm not sure what the max size of the record should be (I set it to 20MB), so feel free to change that value

I have implemented the easy fix for now, but it is definitely a good idea to refactor in the future and parse the WARC header before reading the entire body
I'm not sure what the max size of the record should be (I set it to 20MB), so feel free to change that value


archive 1.4 docs

CI failed (link checker) but thats not surprising given how old this branch is. The netlify build worked though, so this does add the banner as expected. Admin-merging.


Unknow block required_providers

Installation details

IDE version (Help->About->Copy to Clipboard)
PyCharm 2019.1.3 (Community Edition)
Build #PC-191.7479.30, built on May 29, 2019
JRE: 11.0.2+9-b159.60 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.15.0-54-generic
intellij-hcl plugin version (Settings->Plugins)
v0.7.5
Terraform version (terraform -v)
Terraform v0.12.5

Terraform Configuration Files
terraform {
  required_version = ">= 0.12"
  required_providers {
    aws = ">= 2.20"
    local = "~> 1.2"
    null = "~> 2.1"
    random = "~> 2.1"
    template = "~> 2.1"
  }
}

Expected Behavior
No warning for required_providers
Actual Behavior
Unknown block type required_providers less... (Ctrl+F1)
Inspection info: Reports blocks with unknown type (first literal)

Thank you for reporting, fixed, will be available in next release


Drop report.period.type param

Drop report.period.type param and instead deduce it
Parameterise report.period.offset as a webhook query param and default it to -1

Checked all files and code looks fine for me.


incompatible with React version below 0.13.0

attempting to load, I get the following error:
Uncaught TypeError: React.findDOMNode is not a function

The findDOMNode API was introduced in React 0.13, which is the root cause of the problem. I'd be happy to put in a fix, although perhaps the library is meant not to support older versions of React. interested to hear your thoughts.

Hi @raorao. This is something that was added in React 0.13. We're happy to support merge a PR that adds backward compatibility of the React 0.12 behaviour, but be aware that React is still in beta and you will continue having breaking changes until React hits 1.0.

As a related question, is there anything in React 0.14 that breaks this component? Just looking at what versions of React it allows in the package.json and wondering why. Regardless, it probably shouldn't allow versions below 0.13 if the error that @raorao mentioned is occurring on those versions.

I haven't tried it yet, but I'm happy to merge a PR that ups the React version :)

This works with 0.14 now.


Composer support by any chance?

@stephenmelrose Any chance for Composer support in this library?

Thanks @stephenmelrose :) Never had a chance to take care of the stuff yet though.


Java memory

Hi Brad,
When I ran bcbio tumor-normal somatic variant calling pipeline, I found the following error even after I upgrade the bcbio version from 0.9.7 development to 0.9.8. Could you help me to debug it?
Thanks!
INFO  13:13:19,205 ProgressMeter -     1:121485435   4300077.0    87.8 m      20.4 m        4.4%    33.1 h      31.7 h
INFO  13:13:57,509 GATKRunReport - Uploaded run statistics report to AWS S3
ERROR ------------------------------------------------------------------------------------------
ERROR A USER ERROR has occurred (version 3.5-0-g36282e4):
ERROR
ERROR This means that one or more arguments or inputs in your command are incorrect.
ERROR The error message below tells you what is the problem.
ERROR
ERROR If the problem is an invalid argument, please check the online documentation guide
ERROR (or rerun your command with --help) to view allowable command-line arguments for this tool.
ERROR
ERROR Visit our website and forum for extensive documentation and answers to
ERROR commonly asked questions http://www.broadinstitute.org/gatk
ERROR
ERROR Please do NOT post this error to the GATK forum unless you have really tried to fix it yourself.
ERROR
ERROR MESSAGE: An error occurred because you did not provide enough memory to run this program. You can use the -Xmx argument (before the -jar argument) to adjust the maximum heap size provided to Java. Note that this is a JVM argument, not a GATK argument.
ERROR ------------------------------------------------------------------------------------------
' returned non-zero exit status 1
[2016-06-10T18:13Z] ica1: Unexpected error
Traceback (most recent call last):
File "/user/parallel/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/ipythontasks.py", line 50, in _setup_logging
yield config
File "/user/parallel/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/ipythontasks.py", line 187, in postprocess_alignment
return ipython.zip_args(apply(sample.postprocess_alignment, *args))
File "/user/parallel/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/sample.py", line 197, in postprocess_alignment
data = _recal_no_markduplicates(data)
File "/user/parallel/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/sample.py", line 203, in _recal_no_markduplicates
data = recalibrate.prep_recal(data)[0][0]
File "/user/parallel/bcbio/anaconda/lib/python2.7/site-packages/bcbio/variation/recalibrate.py", line 44, in prep_recal
platform, dbsnp_file, intervals, data)
File "/user/parallel/bcbio/anaconda/lib/python2.7/site-packages/bcbio/variation/recalibrate.py", line 89, in _gatk_base_recalibrator
broad_runner.run_gatk(params, tmp_dir)
File "/user/parallel/bcbio/anaconda/lib/python2.7/site-packages/bcbio/broad/init.py", line 285, in run_gatk
log_error=log_error)
File "/user/parallel/bcbio/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 21, in run
_do_run(cmd, checks, log_stdout)
File "/user/parallel/bcbio/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 95, in _do_run
raise subprocess.CalledProcessError(exitcode, error_msg)
CalledProcessError: Command 'java -Xms681m -Xmx1g -XX:+UseSerialGC -Djava.io.tmpdir=/user/project/work/tx/tmpQJnSAR -jar /user/parallel/bcbio/toolplus/gatk/3.5-0-g36282e4/GenomeAnalysisTK.jar -T BaseRecalibrator -o /user/project/work/align/11349FFPE/tx/tmpps4Xug/11349FFPE-sort.grp -I /user/project/work/align/11349FFPE/11349FFPE-sort.bam -R /user/parallel/bcbio/genomes/Hsapiens/GRCh37/seq/GRCh37.fa --downsample_to_fraction 0.617578154176 --downsampling_type ALL_READS --knownSites /user/parallel/bcbio/genomes/Hsapiens/GRCh37/variation/dbsnp_138.vcf.gz -L /user/project/work/bedprep/11349FFPE-sort-callable-callableblocks.bed --interval_set_rule INTERSECTION -nct 16 -U LENIENT_VCF_PROCESSING --read_filter BadCigar --read_filter NotPrimaryAlignment

Sorry about the issue, it looks like you're not providing enough memory to GATK to make BaseRecalibrator happy. You can adjust this by increasing the memory per core specified in the gatk section of your bcbio_system.yaml file. More details are here:
http://bcbio-nextgen.readthedocs.io/en/latest/contents/parallel.html?highlight=Xmx#tuning-core-and-memory-usage
Hope this helps, feel free to reopen if you aren't able to get things working and happy to help more.

Hello Brad,
Thanks for the answer. As far as I saw, BaseRecalibrator is not parallelizing the work to cores while other parts which are using GATK do. So, what I wanted to ask is if there is an option to control specifically the memory used for BaseRecalibrator.
Many thanks

Thanks for following up. I dug a little deeper and realized that the latest code was not correctly scaling up cores along with memory. BaseRecalibrator cannot be scaled by machines, but does use multiple cores -- you can see this with the --nct 16 option in the commandline above, where it uses GATK multithreading to get 16 cores. It should also scale up the memory but there was a bug preventing that, which is now fixed in the latest development version (bcbio_nextgen.py upgrade -u development).
There isn't a specific memory option for BaseRecalibrator, but setting gatk to something higher than 1g/core will probably also help with this. Apologies again about the problem, hope that gets it working for you.

Thanks Brad


Affect on existing schedules

If we enable Continuous Crawling on a source that previously had Full and Incremental schedules set, what, if anything do we need to do with those schedules? are they deactivated automatically or do we need to make a change manually?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9f89352e-bd59-5b52-c0b8-4b5b19bf4d6b
Version Independent ID: 06a19e26-98c3-ca35-8bcb-8cad4eaf7ca9
Content: Manage continuous crawls in SharePoint Server
Content Source: SharePoint/SharePointServer/search/manage-continuous-crawls.md
Service: unspecified
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Incremental is automatically deactivated. Fulls shouldn't be used except under unusual circumstances after the initial full crawl.

It looks like crawl logs are only available after full crawl has completed
https://docs.microsoft.com/en-us/sharepoint/search/view-search-diagnostics
However i think what has been suggested above is that we do not really need full crawl schedule. So would we never have logs available for continuous crawls ?


x/build/env: Add builder for GOOS=wasip1 GOARCH=wasm

#58141 adds the new GOOS=wasip1 GOARCH=wasm port. This new port will require a new builder that can run the standard library tests.
I intend to submit a CL to add this.

cc @golang/release

Built the images and deployed the coordinator. Seems to be failing as expected.

Do the builders allow any caching of artifacts? Wazero is instructed to put it's native code in $TMP, so if we have a way to persist folders between runs we should get a speedup.

We may be able to support this kind of caching in the near(-ish) future, but could you clarify why you think it would help here?
Alternatively, would the wasmtime builder be faster (once it's fully on)? This is also worth exploring - after all our goal here is to test the wasip1 target, not the wasm VM. As well as some general profiling to see if the bot can be made faster.
Finally, we may consider whether this builder is needed in trybots at all (given that the wasm/js builder already runs), if the performance issues cannot be sufficiently addressed.

We may be able to support this kind of caching in the near(-ish) future, but could you clarify why you think it would help here?

I haven't tested this, but I assume most of the time consumed is in the native-code compilation step that wazero performs as part of its execution of the wasm. These artifacts are cached and could be reused between runs, so that subsequent test runs only need to rebuild those that have changed.
It is possible to run wazero in an interpreted mode, but in our testing that was significantly slower.
Wasmtime may be faster, I haven't spent any time comparing the runtime of the two yet, but it too will probably be spending most of the time in the native-code compilation step part of the execution, unless we introduce caching.

Finally, we may consider whether this builder is needed in trybots at all (given that the wasm/js builder already runs), if the performance issues cannot be sufficiently addressed.

I understand if we'd want to turn it off because it's too slow, but I don't know that wasm/js alone will be able to give us confidence that the wasip1 port isn't broken. I don't know enough about the builder system to say yet, but it may be enough to only run these on tip, is that what you mean? As long as we get notified about it breaking, that should be sufficient.

I haven't tested this, but I assume most of the time consumed is in the native-code compilation step that wazero performs as part of its execution of the wasm. These artifacts are cached and could be reused between runs, so that subsequent test runs only need to rebuild those that have changed.

But if the compiler itself changes in a CL, you can't reuse its JIT products from previous runs. Similarly with stdlib changes which may affect any test. So I'm not 100% how much this can save.

Wasmtime may be faster, I haven't spent any time comparing the runtime of the two yet, but it too will probably be spending most of the time in the native-code compilation step part of the execution, unless we introduce caching.

@dmitshur pointed out that in https://go-review.git.corp.google.com/c/go/+/498616 the wasmtime bot finished much quicker than wazero, and in fact wasn't the long pole in our trybots any more. If we can have a wasip1 trybot that's not the long pole, it's fine to keep it around if you feel it covers additional stuff that js/wasm does not.

What a timely comment to be making as we just had the wasmtime runner pass all the standard library tests. I would be happy to make the switch to wasmtime for all CLs as it should find any obvious breakages, but note that symlink tests are disabled on wasmtime because it doesn't really work with the standard library test assumptions, so we'll still want to pay attention to the wazero runner.

Indeed, the timing is fortunate :)
Yes, the wazero builder can remain on the post-submits of course, and run on tip, but for trybots that run on every CL and affect our compile-edit-test loop it would be nice to switch to the faster configuration.


Created new post for GFW Water Webinar

Added a post for a new webinar video on GFW Water.

It works perfectly, thanks !


Question: Connection Pool

Scenario: I'm using connection pool to connect to the database with a connectionLimit set to 10. During the day the pool only ever uses 5 simultaneous connections and thus they are 5 open connections in the pool.
Question: Will node-mysql always keep those 5 connections alive or do they close after a period of time of inactivity?

Hi @JoelV ! So the way this module handles idling connections is that it just leaves them there to idle (as in, this module does no active keep-alives). When ever you call pool.getConnection, this module will check if it is up by sending a ping packet. If it works, you get that connection back, otherwise it will automatically create a new connection.
This mechanism allows for minimal network traffic, and of course you can always build active keep-alives on top of this module if you wish.
I hope this helps!

Wouldn't this be a bit intrusive?
i.e I'm using a 2 pools with 200 connections each.
I see I have about 240 connection in the db which are in sleep mode. It looks like it makes the db really slow.
What may be the cause to that?


OAK-9564 (Bugfixed): Make the renewLease mechanism a bit more tolerant against unexpected updates

This PR #455, which is a revert of #359 because of a discovered bug after it was merged.
The new commit resolves the bug, improves the logging of the newly added field "Runtime_id", and adds new tests to reproduce and cover the detected bug to allow to acquire recovered and disposed clusters properly.

@mreutegg I think now for real, can you review? Thanks!


Develop a Mass Balance Test

Develop a test case in the tests folder in which initial conditions and boundary conditions are all set to 100 (arbitrary units).

Thanks @jrutyna - closing this thanks to recent PRs #32, #44. We can create new issues down the line if we want to make any specific changes or additional tests.


tracing_user: Add ISR nest level parameter

For tracing_user, the sys_trace_isr_enter() & sys_trace_isr_exit() block any nest interrupts & most SMP interrupts for the user. It is
hard to analyze the IRQ preemption(e.g., each IRQ counter and execution time). This commit adds ISR nest level for each CPU to the user instead of blocking user call back when nest interrupts.

This makes sense to me, needs a doc fix though

This makes sense to me, needs a doc fix though

Do you mean the CI Documentation Build? This pass after rebase.

This is a good addition, my only question is why are the two __ASSERT_NO_MSG asserts (in sys_trace_k_thread_switched_in/sys_trace_k_thread_switched_out) removed with this change? They seem like a good check to ensure that the nesting levels are kept correct.

This is a good addition, my only question is why are the two __ASSERT_NO_MSG asserts (in sys_trace_k_thread_switched_in/sys_trace_k_thread_switched_out) removed with this change? They seem like a good check to ensure that the nesting levels are kept correct.

Thanks for pointing out this. The original one doesn't support SMP. So let's change it to support SMP.
Moreover, I think the RISCV has some issues with it when enabling ASSERT. I open another issue for it(#41995).


Show icon when linting is in progress

I really like the analyzing text here: https://github.com/dart-atom/dartlang/issues/61#issuecomment-131282542

I was thinking about this today and believe that we should outsource this to a process running indicator service package. Something which would benefit both Linter and Build.
I think I may work on it this weekend.

@kepler0 I don't mind that, but what if the user doesn't have that package installed? Will the user have to install a whole build package just to see the indicator? I think I have a better idea, we already have a linter status icon which shows No Errors or X Errors, if we change it's icon to the loading icon while linting is in progress, it should do the job. What do you think?

What I was trying to say is that it would be a new service, we would consume. So say the service name is status-indicator, the user would then be able to use a indicator-bottom package which would provide a graphical interface for the statuses of packages consuming the service. So in this instance the linter, build, and dartlang packages would be consuming the service and indicator-bottom would display activity in the bottom bar.

I'll have a better use-case this weekend.

And probably a demo too.

I think that changing the Error indicator like that could work well, if a broader solution isn't made available.

Such indicator should at least only be displayed when linting is manually triggered, and not when it is automatically linting when typing. Anything else would just be disturbing.
And there are probably not many users calling lint manually. This is probably something that is most interesting for you who have a developer-relationship to this package. We users just want it to work and not disturb us on anything else than errors with our code :)
And if this is going to be used by very few people anyway, I agree with @kepler0 that it would be better to  consume some other package for this functionality.

@KnutHelland I might have not been much clearer in my messages above, let me fix that now :)
The indicator is going to be a tiny size, the same size that the x or tick icons are now in the bottom panel. I personally don't think it's gonna bother anybody or act as a distraction, even if it is, it'll be the same amount of distraction as is the x icon with changing count right now, most people including myself don't even notice it.
Even then if it bothers somebody, I guess you might have noticed that everything in linter is configurable, so this behavior will be configurable too! You can just opt out of it if you don't like it. Also even if it's used by very few people, we still won't be able to conditionally install the dependency and it would be an overkill, we already have an indicator, users will expect us to show linting status on that and only that indicator, users won't expect to have a linting indicator next to the git lines diff. It would create a lot of confusion and we, by all means, are trying to reduce that :)

Hehe, okay :+1: I just saw the indicator you linked to and thought that was very verbose. Something you would like to have when you manually start a background process, like for example a build process. But I think linting is another category of service. That's one of many background services in an editor that the end user in a perfect world shouldn't think of as a background service, but as a instant feature of the editor. It should ideally lint instantly without any latency and any need for an indicator.
There are probably dozens of other processes happening in the background of atom as well, without indicating anything to the user. Things like autosaving, garbage collecting, sending usage statistics to NSA, etc. I'm not saying that linting is comparable to these. But I think that displaying a loading indicator to a user is something that one generally shouldn't do unless it is valuable for the user to know that he is waiting on a result from an ongoing process. And 99.99% of the times linter runs, I'm not waiting for anything. I'm just coding.
But yeah, anyway. I don't really care. Don't know why I suddenly happened to write a comment here. And it is really nice that things are very configurable. Thumbs up! I would however vote for this one to be disabled by default, even if it is barely noticeable. I still think this is unnecessary information overload to the UI, and something the user shouldn't need to know. It goes against my personal "keep it simple" UI agenda :)

@KnutHelland Just to clear the confusion that I have not implemented an icon this far because I believed linting is instant and user wouldn't even notice it. But I've seen cases where a linting is in progress, user tries to lint again, his request is ignored in favor of already in progress linting and user thinks the linter is not responding. Currently there is no way for the user to know if something's happening, I just want to fill that gap :)

Moved to https://github.com/AtomLinter/linter-ui-default/issues/53


Cosmovisor setup instructions

There are going to be some upgrades, might be good to document cosmovisor setup. Or at least mention it?

Done.


Test non-default branches in sandbox

Per discussion in tech review session 8/29, non feature branches should be tested in sandbox. Only stable changes from the default branches are allowed in the internal cluster.

I believe that this MR is not necessary yet benign because these test flows do not affect the health of the cluster because they are simply flows that run and do not modify the cluster, and hence could run in NonProd.
Because it is benign, I think it's OK to move to MR runs in sandbox, until or unless they are blocking.


fix(publisher): display http error if connection failed

This fixes a confusing log message:
Jul 07 17:49:54 ip-10-21-1-91.us-west-2.compute.internal sh[3320]: 2015/07/07 17:49:53 healthcheck failed for http://<IP_ADDRESS>:32811/ (expected 200, got Get http://<IP_ADDRESS>:32811/: read tcp <IP_ADDRESS>:32811: connection reset by peer)

Now it should read
Jul 07 17:49:54 ip-10-21-1-91.us-west-2.compute.internal sh[3320]: 2015/07/07 17:49:53 healthcheck failed for http://<IP_ADDRESS>:32811/ (Get http://<IP_ADDRESS>:32811/: read tcp <IP_ADDRESS>:32811: connection reset by peer)

Code LGTM.

Code LGTM.

Code LGTM.


[#501] Downgrade version of activesupport (Cocoapods issue, CI/CD troubleshooting)

@ludovic35 is missing, need to fix this issue asap


Can't run build-web

Hi! I can't run npm run build-web.
I get a lot of errors like this:
ERROR in /.../eosjs/node_modules/jest-diff/build/index.
d.ts
[tsl] ERROR in /.../eosjs/node_modules/jest-diff/build/
index.d.ts(10,13)
TS1005: '=' expected.
I get this in npm logs:
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'run', 'build-web' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild-web', 'build-web', 'postbuild-web' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/Users/pav/Desktop/PROJECTS/V/Code/eosjs/node_modules/.bin:/usr/local/opt/php@7.2/sbin:/usr/local/opt/php@7.2/bin:/Library/Frameworks/Python.framework/Versions/3.6/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/opt/php@7.2/sbin:/usr/local/opt/php@7.2/bin:/Library/Frameworks/Python.framework/Versions/3.6/bin
9 verbose lifecycle<EMAIL_ADDRESS>CWD: /Users/pav/Desktop/PROJECTS/V/Code/eosjs
10 silly lifecycle<EMAIL_ADDRESS>Args: [
10 silly lifecycle   '-c',
10 silly lifecycle   'webpack --config webpack.prod.js && webpack --config webpack.debug.js'
10 silly lifecycle ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 2  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec build-web script
13 verbose stack Error<EMAIL_ADDRESS>build-web: webpack --config webpack.prod.js && webpack --config webpack.debug.js
13 verbose stack Exit status 2
13 verbose stack     at EventEmitter. (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:332:16)
13 verbose stack     at EventEmitter.emit (events.js:321:20)
13 verbose stack     at ChildProcess. (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:321:20)
13 verbose stack     at maybeClose (internal/child_process.js:1026:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd /Users/pav/Desktop/PROJECTS/V/Code/eosjs
16 verbose Darwin 17.4.0
17 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build-web"
18 verbose node v13.7.0
19 verbose npm  v6.13.6
20 error code ELIFECYCLE
21 error errno 2
22 error<EMAIL_ADDRESS>build-web: webpack --config webpack.prod.js && webpack --config webpack.debug.js
22 error Exit status 2
23 error Failed at the<EMAIL_ADDRESS>build-web script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 2, true ]

Can you try cloning this repo, then run build-web instead of trying to run that script from your app? https://github.com/EOSIO/eosjs#browser-distribution

Hi, thanks for the swift reply. This is what I did now:
git clone https://github.com/EOSIO/eosjs.git
cd eosjs
npm i
npm build-web
which produces:

<EMAIL_ADDRESS>build-web /Users/pav/Desktop/PROJECTS/eosjs
webpack --config webpack.prod.js && webpack --config webpack.debug.js

Hash: 7dc8c021b861537f4210
Version: webpack 4.29.5
Time: 18362ms
Built at: 05/18/2020 6:08:52 PM
4 assets
Entrypoint eosjs_api = eosjs-api.js
Entrypoint eosjs_jsonrpc = eosjs-jsonrpc.js
Entrypoint eosjs_jssig = eosjs-jssig.js
Entrypoint eosjs_numeric = eosjs-numeric.js
[3] (webpack)/buildin/global.js 472 bytes {1} {2} [built]
[7] ./src/eosjs-numeric.ts 13.9 KiB {0} {1} {2} {3} [built]
[8] ./src/ripemd.js 13.3 KiB {0} {1} {2} {3} [built]
[34] ./src/eosjs-rpcerror.ts 1.52 KiB {1} [built]
[69] ./src/eosjs-api.ts 21.3 KiB {0} [built]
[70] ./src/eosjs-serialize.ts 40.2 KiB {0} [built]
[71] ./src/abi.abi.json 4.79 KiB {0} [built]
[72] ./src/transaction.abi.json 2.94 KiB {0} [built]
[73] ./src/rpc-web.ts 268 bytes {1} [built]
[74] ./src/eosjs-jsonrpc.ts 18.6 KiB {1} [built]
[75] ./src/eosjs-jssig.ts 5.26 KiB {2} [built]
[87] util (ignored) 15 bytes {2} [built]
[89] util (ignored) 15 bytes {2} [built]
[99] util (ignored) 15 bytes {2} [built]
[101] util (ignored) 15 bytes {2} [built]
+ 121 hidden modules
ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/index.d.ts
[tsl] ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/index.d.ts(10,13)
TS1005: '=' expected.
ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/index.d.ts
[tsl] ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/index.d.ts(10,34)
TS1005: ';' expected.
ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/index.d.ts
[tsl] ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/index.d.ts(11,1)
TS1128: Declaration or statement expected.
ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/index.d.ts
[tsl] ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/index.d.ts(11,13)
TS1005: ';' expected.
ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/index.d.ts
[tsl] ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/index.d.ts(11,52)
TS1005: ';' expected.
ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/diffLines.d.ts
[tsl] ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/diffLines.d.ts(8,13)
TS1005: '=' expected.
ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/diffLines.d.ts
[tsl] ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/diffLines.d.ts(8,34)
TS1005: ';' expected.
ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/printDiffs.d.ts
[tsl] ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/printDiffs.d.ts(8,13)
TS1005: '=' expected.
ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/printDiffs.d.ts
[tsl] ERROR in /Users/pav/Desktop/PROJECTS/eosjs/node_modules/jest-diff/build/printDiffs.d.ts(8,57)
TS1005: ';' expected.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build-web: webpack --config webpack.prod.js && webpack --config webpack.debug.js
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build-web script.

Looks like this issue is caused by this: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/36299
You can fix this by upgrading the Typescript version to 3.8.3. If you want to run this script now, please update the Typescript version manually and then run the script. We'll release a fix for this soon.

Yes, upgrading Typescript to version 3.8.3 worked
thank you

Fixed in https://github.com/EOSIO/eosjs/pull/707

jest 24.0.0


Is the div block around textarea in template necessary?

Hi, Thanks for this awesome ckeditor integrator with django. I had some issues with the width setting of the textarea which was not being enforced and I found that the reason was the textarea was surrounded by a div block. Is this div block necessary? I removed it and the code seemed to work fine.

Maybe it's not strictly necessary, but we'd need more justification for removing this. Thanks, and please reopen if you want to continue the discussion!


[For Test; DO NOT MERGE] Add grpcio as a pip dependency of tensorflow

@inc0 this is related to an upcoming feature that requires the Python gRPC library. You'll hear about more about it.
Closing this PR. The same change has been submitted as an internal change and will be sync'ed to external soon.


can not find the file in "torch.load('B0050.pth')"

Hello author, I am doing research related to stroke and want to do a pre-processing with your code. But, I find that a weight file is missing when running the code, I hope you can tell me how to download this weight file, thank you!

same question here...

The weight file has been uploaded, and the ASPECTS atlas is a 2D atlas.


Handle tables and additional block like elements in innerText

Oops, sorry for the noise. Sent this PR too early.


Use OAuth 2 for logging in instead of login using WebView.

Describe the feature you'd like
Use OAuth 2 for logging in instead of login using WebView for a more native app experience.
Would you like to work on the issue?
No as of now.

Will not work on this till other features in the app are complete. Closing for now. Will re-open later.


Dependencies on fresh install cannot be resolved.

Adding blinker to Pipfile's [packages]…
Pipfile.lock not found, creating…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
Warning: Your dependencies could not be resolved. You likely have a mismatch in your sub-dependencies.
You can use $ pipenv install --skip-lock to bypass this mechanism, then run $ pipenv graph to inspect the situation.
Could not find a version that matches vine==1.3.0,==5.0.0
Tried: 0.9.0, 0.9.0, 0.9.1, 0.9.1, 1.0.0, 1.0.0, 1.0.1, 1.0.1, 1.0.2, 1.0.2, 1.1.0, 1.1.0, 1.1.1, 1.1.1, 1.1.2, 1.1.2, 1.1.3, 1.1.3, 1.1.4, 1.1.4, 1.2.0, 1.2.0, 1.3.0, 1.3.0, 5.0.0a1, 5.0.0a1, 5.0.0, 5.0.0

Not related to blinker, sorry for the inconvenience.


Improve Flow specificity for exported type definitions

See WPT-689 for more details.

Problem
We export many core types in fusion-core (e.g. base-app.js.flow) which have implications across all consumers of Fusion.js.  Unfortunately, many of these types lack the level of specificity that ensures our type checker is catching as many issues statically as possible.  In many cases, Flow will flag a subset of the issues that we want to catch and letting others that remain problematic pass the check.
For example, the following code will pass the type checker today:
const someToken: Token<number> = ...;
(app: FusionApp);
app.register(someToken, 5); // works, as expected
app.register(someToken, "hello"); // fails check, as expected
app.register(someToken, {}); // !!! should error, but it doesn't!

In this case, our definition for FusionPlugin is too general and technically allows an empty object to be defined as a plugin.
This is one example, but there are numerous types that are too weak for our type checker today.  Many of these are documented on TryFlow here.
Solution
Identify and improve types for all core types exported by fusion-core.  A simplified version of a proposed set of solutions can be found on TryFlow here.

!merge


Untangling your Webpack config

Suggested by user luckyleprechaun98 over Reddit (https://www.reddit.com/r/SideProject/comments/58antx/react_casts_weekly_short_videos_with_tips_tricks/)
To be honest, the suggested title was “Unfucking your Webpack config“.

Closing this issue - nowadays we have create-react-app to get started without needing to mess with webpack, and webpack's own documentation improved a lot.


Closes #15; Uses custom errors

Switches the require statements with custom errors, because they can be
more easily handled.

Please try with this new package-lock.json. Make sure you're using npm v7.x and run an npm install. The error thrown by solidity parser (a dependency of eth-gas-reporter) when running tests should be fixed.
However, running npm update will break this, so this is only a temporary solution. Already opened an issue in eth-gas-reporter (cgewecke/eth-gas-reporter#253, hopefully the maintainer will update it.

Thanks it works like this.


Running statically exported bundle on a sub-folder of the URL

I feel like I might be missing something obvious, but I'm having trouble running my statically exported Next.js app on a sub-folder. Or in other words, this is what I basically want to do:

Run next build && next export -o dist to create a <proj_root>/dist directory with my static bundle.
The user's browser requests should have the following behaviour:

http://example.com/portal will serve /dist/index.html
http://example.com/portal/orders will serve /dist/orders/index.html
this tag:  will serve up /dist/static/image.jps

[x] I have searched the issues of this repository and believe that this is not a duplicate.

The problem
The problem with the naive approach is that the image request:

will end up trying to make a request to:
http://example.com/static/image.jpg

instead of:
http://example.com/portal/static/image.jpg

assetPrefix
One way of making this work is to add the following to my next.config.js file:
assetPrefix: isProd ? "/portal" : ""

But this means that if the NGINX configuration ever changes, I'll have to update the assetPrefix and deploy accordingly.
This seems like a cross-cutting concern to me, especially since I was under the impression that a static bundle should be exportable with relative paths that would make it work anywhere.
The router (NGINX in this case) is supposed to do all the work, but alas I don't have much experience with NGINX (and on this project the client has not disclosed his nginx.conf to me).
Finally
Of course, this would all be easily solved if we used http://portal.example.com instead of http://example.com/portal, but this is not something I have a say in.
Is there a recipe for making this work? Perhaps an example nginx.conf that works for this use-case? Or is this something that must be set in the assetPrefix. As far as I'm aware, I thought the assetPrefix was for CDNs primarily, and not for this use-case.

Someone suggested the following nginx configuration:
server {
  # port, server name here, etc.
  location = / {
    index index.html;
  }
  location / {
    try_files /portal/$uri /portal/$uri.html /portal/index.html $uri $uri.html $uri/ /index.html;
  }
}

... which I don't really understand, but example.com/portal properly serves up /dist/index.html.
But it breaks Next.js's routing. For example, if I tried to do Router.push('/orders') inside index.js, I would get pushed from example.com/portal to example.com/orders instead of example.com/portal/orders.

@adrianmcli did you have any luck with this issue? I'm facing the same exact problem so I'm curious if you find some sort of solution.

We switched to http://portal.example.com but I am still interested in a solution as well.

I have a very valid use-case for needing to load NextJS via file:// URLs (performance), ideally without a server. A plan B is serving the out folder via a regular server npm i serve, python simpleHTTPServer... etc., but even that has issues.
Any advice towards the most lightweight method of pre-rendering and then exporting the app to be run locally would be greatly appreciated @timneutkens, I've got a week to make this happen 👍

Closing this in favor of tracking it here: #4998


Booting on EC2 fails with "Malformed boot parameter "ro""

I've made it to the point where I can almost boot a unikernel on EC2, but bootvar doesn't seem to like the boot parameters given to it in this case:
Xen Minimal OS!
  start_info: 0xac4000(VA)
    nr_pages: 0x26700
  shared_inf: 0x7decb000(MA)
     pt_base: 0xac7000(VA)
nr_pt_frames: 0x9
    mfn_list: 0x990000(VA)
   mod_start: 0x0(VA)
     mod_len: 0
       flags: 0x0
    cmd_line: root=/dev/sda1 ro 4
  stack:      0x94f860-0x96f860
MM: Init
      _text: 0x0(VA)
     _etext: 0x5ffbd(VA)
   _erodata: 0x78000(VA)
     _edata: 0x80ae0(VA)
stack start: 0x94f860(VA)
       _end: 0x98fe68(VA)
  start_pfn: ad3
    max_pfn: 26700
Mapping memory range 0xc00000 - 0x26700000
setting 0x0-0x78000 readonly
skipped 0x1000
MM: Initialise page allocator for c01000(c01000)-26700000(26700000)
MM: done
Demand map pfns at 26701000-2026701000.
Heap resides at<PHONE_NUMBER>-4026702000.
Initialising timer interface
Initialising console ... done.
gnttab_table mapped at 0x26701000.
Initialising scheduler
Thread "Idle": pointer: 0x2026702010, stack: 0x26640000
Initialising xenbus
Thread "xenstore": pointer: 0x20267027c0, stack: 0x26650000
Dummy main: start_info=0x96f960
Thread "main": pointer: 0x2026702f70, stack: 0x26660000
"main" "root=/dev/sda1" "ro" "4"
vbd 2049 is hd0
******************* BLKFRONT for device/vbd/2049 **********

backend at /local/domain/0/backend/vbd/538/2049
Failed to read /local/domain/0/backend/vbd/538/2049/feature-barrier.
Failed to read /local/domain/0/backend/vbd/538/2049/feature-flush-cache.
2097152 sectors of 512 bytes
**************************

    GNU GRUB  version 0.97  (629760K lower / 0K upper memory)

+-------------------------------------------------------------------------+||||||||||||||||||||||||+-------------------------------------------------------------------------+

    Use the ^ and v keys to select which entry is highlighted.

    Press enter to boot the selected OS, 'e' to edit the

    commands before booting, or 'c' for a command-line.  Mirage                                                                                The highlighted entry will be booted automatically in 1 seconds.     Booting 'Mirage'

root (hd0)

 Filesystem type is ext2fs, using whole disk

kernel /boot/mirage-os.gz

xc_dom_probe_bzimage_kernel: kernel is not a bzImage
close blk: backend at /local/domain/0/backend/vbd/538/2049
Xen Minimal OS!
Initialising timer interface
Initialising console ... done.
getenv(OCAMLRUNPARAM) -> null
getenv(CAMLRUNPARAM) -> null
getenv(PATH) -> null
Unsupported function lseek called in Mini-OS kernel
Unsupported function lseek called in Mini-OS kernel
Unsupported function lseek called in Mini-OS kernel
getenv(OCAMLRUNPARAM) -> null
getenv(CAMLRUNPARAM) -> null
getenv(TMPDIR) -> null
getenv(TEMP) -> null
getenv(DEBUG) -> null
getenv(OMD_DEBUG) -> null
getenv(OMD_FIX) -> null
Netif: add resume hook

OCaml Xenstore reading vm

OCaml Xenstore reading /vm/ec2952ba-efa5-2e3c-6d22-9b4a59a6fe3c/image/cmdline
Fatal error: exception Failure("Malformed boot parameter \"ro\"")
Raised at file "src/core/lwt.ml", line 789, characters 22-23
Called from file "lib/main.ml", line 58, characters 10-20
Called from file "main.ml", line 274, characters 5-10
Mirage exiting with status 2
Do_exit called!

Same issue here using latest commit today. I rolled-back to a previous commit from January (d65242c29031acbf65ff753ca51c316c25ab9330) to make it works for a training session about Unikernels. Any feedback about when the issue will be resolved in the last commit will be much appreciated.

Hi @jsianes, slightly off-topic, but can you give me more info about the training session you ran? (My email is in my GitHub profile).

Hi @amirmc . As part of some internal training sessions, during one of the session I'm introducing Unikernel concept to AWS Support engineers. At the end of the session, we create a 'hello world' AWS AMI using 'mirage-www' source code from Git. The example was working correctly following the steps in your official documentation last November, the first time we ran the session. But testing this week before next session, it seems the Xen unikernel generated with the last commit doesn't work showing "Fatal error: exception Failure("Malformed boot parameter "ro"")" at the end of the instance console output.
As I said in the previous message, rolling-back to a previous commit from January resolve the issue and it's enough as workaround for the next training session. But would be nice if you can fix it for the last stable version or, if there is required any kind of additional configuration, please update the official documentation.

For other people with this problem, a work-around is to disable bootvar support with:
opam pin add -y mirage-bootvar-xen 'https://github.com/talex5/mirage-bootvar-xen.git#qubes'
(I did this for Qubes, but it sounds like EC2 needs it too)

This should be fixed in version 0.3.2 -- @sgrove , can you confirm when you get a chance?


Fix #17964

Some browsers are lazy when updating dom elements after transition effects. This can be fixed by reading element properties such as offsetHeight or offsetWidth, which causes the browser to resync (reflow) the element.
However, creating a function using the Function constructor just to access such element properties, results in a violation of Content Security Policy (where applied), which in turn crashes the application. This fix actually reverts to the way this was handled in v3 and should work as intended.

Curious if I could get some eyes on this from other folks who've pushed JS changes—@cvrebert, @Johann-S, or @bardiharborow. Know it's a small change, but I don't know the full context here <3.

I actually did see this in the code and was wondering what we should do about it. The concern I have is that it was probably written in such a novel way because of a browser bug and I would want to ensure that it isn't still necessarily. So far I've traced it back to 834220e, but there is little indication why it was added.

I'll punt it to Alpha 6 until we know more then. We can always ping @fat to see if it needs to stay the same, but if this is coming from that Closure commit, I'm willing to bet it's not a weird browser thing. Thanks for looking!

I've found some references to this technique on StackExchange

Okay, so maybe we punt on this for now then @bardiharborow?

@mdo, I'd say merge this. The Function wrapper seems pointless based on everything I've read, it's more to stop Closure from being too smart and removing this entirely. The element.offsetHeight itself needs to be looked into by the Chrome team and should be removed eventually when the underlying bug is fixed.


Support for swagger-java

Hello,
Can you please add support for swagger-java.
Swagger-java replaces camel-swagger in 2.16.
See http://camel.apache.org/swagger-java.html and http://camel.apache.org/swagger
Thanks

Good call.
Our next release incorporating Camel 2.16 is imminent so this will be a good thing to get into the project.


⚠ GitLab Server has degraded performance

In 4b46cab, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6963 ms

Resolved: GitLab Server performance has improved in ff07f26.


For comments only.

Thank you for reading it and your feedbacks @gpdf

My apologies everyone, I either never got a notification, never saw it or forgot about it. My bad @hsinfang, very sorry you had to go through most of them. I've went through all remaining ones and closed what I could. Others have some questions and answers left open.
My apologies for the wait again, I wish someone pinged me earlier.


continuous-capture encoder drop frame

I find the encode video drop some frames in continuous-capture activity. Since the input came from camera preview, every frame is different from each other, but in encode output video, for example, frame 71 is same to frame 72, frame 99 is same to frame 100. Is anything wrong with continuous-capture activity?

I'm not aware of anything that would cause this. Sounds a little like issue #62. What device and version of Android?

android sdk version 23.0
device support android version 5.1.1

Your best bet is to post a question on stackoverflow.com.  Be sure to include your test methodology, i.e. how you're determining that the frames are identical, and whether you've made any changes to ContinuousCapture.  It would also be helpful to mention the details of the device you're testing with, in case there are chipset-specific bugs that people are aware of.  The [android], [mediacodec], and [grafika] tags are appropriate.


Removed GitlabJobId from BuildsDir and CacheDir

Please keep PRs limited to single change requests, this PR seem to include two separate issues.
Since the SSH issue has been addressed in a different PR, either close this one and open a new PR or modify to include only the changes relevant.

Please keep PRs limited to single change requests, this PR seem to include two separate issues.
Since the SSH issue has been addressed in a different PR, either close this one and open a new PR or modify to include only the changes relevant.

This can be closed. I had to merge to two to create a build for the customer to get unblocked.


Added confirm box for Delete All button

Fixes #63
Description
Added confirm popup after user clicks on Delete All button in the bookmarks section.
Checklist:

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Sorry for period of inactivity @makkoncept . I want to close this PR as I am busy in some urgent work. Thanks.


[Languages] Build data-driven and type-driven algorithms using pattern matching

Proposed title of article
Build data-driven and type-driven algorithms using pattern matching
Proposed article introduction
The practice of testing whether a specified sequence of characters/tokens/data exists among the given data is known as pattern matching. It can also be used to locate a matching pattern in a text or code and replace it with another text or code. Pattern matching is used in some fashion by every application that includes search capabilities.
In this article, we shall to understand some points like

To construct full algorithms, combine pattern matching with various approaches
To implement behavior depending on types and property values, use pattern matching expressions.
Recognize circumstances in which pattern matching is appropriate

The early versions of c-Sharp introduced the basic pattern matching features which have been continually extended to the later versions. You can create functionality that acts as if you were extending types from other libraries. Patterns can also be used to provide functionality to your application that isn't a core feature of the type being extended.
In this article, we are going to deeply have a look at this topic.
Key takeaways

Scenarios for pattern matching
Pattern matching designs
Implementing the basic toll calculations

Article quality
How is your article unique? Tell us what makes your approach different from similar articles that have published on the same topic?
Is yours more in-depth? Does it cover additional topics? Do you provide handy tips or anecdotal advice?
References
N/A
Conclusion
Finally, remove the Pre-Submission advice section and all our blockquoted notes as you fill in the form before you submit.
We look forwarding to reviewing your topic suggestion.

Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

I'm going to close this topic due to inactivity.
It can be reopened.

I'm just nearly completion and make a pr

Seems the PRs linked tp this issue were closed.


Add a static analysis tool

Add a static analysis tool to the workflow. PHPStan seems to be a good one.

The support of PHPStan static analysis tool was added in the release v5.0.1.


what is the possible reason for accelerate running on cuda 12.2 8xA100 with error accelerate multiprocessing.api:failed (exitcode: -9)

System Info
ubuntu 22.04
gpu A100 80G
cuda version 12.2
accelerate version 0.21.0

Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
running the demo script from diffusers train_text_to_image.py for 100k iterations with batch size 8 each gpu, 8 A100 gpus in total
Expected behavior
successful training without any problem

We need a full stack trace to know more

And as asked, the output of accelerate env

@muellerzr thanks for your reply!
the full stack trace is
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 43837 closing signal SIGTERM
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 43839 closing signal SIGTERM
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 43841 closing signal SIGTERM
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 43843 closing signal SIGTERM
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 43844 closing signal SIGTERM
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: -9) local_rank: 1 (pid: 43838) of binary: /home/gary/miniconda3/envs/blip2/bin/python
Traceback (most recent call last):
  File "/home/gary/miniconda3/envs/blip2/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/home/gary/miniconda3/envs/blip2/lib/python3.8/site-packages/accelerate/commands/accelerate_cli.py", line 45, in main
    args.func(args)
  File "/home/gary/miniconda3/envs/blip2/lib/python3.8/site-packages/accelerate/commands/launch.py", line 970, in launch_command
    multi_gpu_launcher(args)
  File "/home/gary/miniconda3/envs/blip2/lib/python3.8/site-packages/accelerate/commands/launch.py", line 646, in multi_gpu_launcher
    distrib_run.run(args)
  File "/home/gary/miniconda3/envs/blip2/lib/python3.8/site-packages/torch/distributed/run.py", line 785, in run
    elastic_launch(
  File "/home/gary/miniconda3/envs/blip2/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 134, in __call__
    return launch_agent(self._config, self._entrypoint, list(args))
  File "/home/gary/miniconda3/envs/blip2/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 250, in launch_agent
    raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
------------------------------------------------------
Failures:
  <NO_OTHER_FAILURES>
------------------------------------------------------
Root Cause (first observed failure):
[0]:
  time      : 2023-07-18_13:20:30
  host      : ubuntu-server-A205
  rank      : 1 (local_rank: 1)
  exitcode  : -9 (pid: 43838)
  error_file: <N/A>
  traceback : Signal 9 (SIGKILL) received by PID 43838

and the output of  accelerate env is
- `Accelerate` version: 0.21.0
- Platform: Linux-5.15.0-76-generic-x86_64-with-glibc2.17
- Python version: 3.8.16
- Numpy version: 1.24.4
- PyTorch version (GPU?): 2.0.1+cu117 (True)
- PyTorch XPU available: False
- PyTorch NPU available: False
- System RAM: 1007.72 GB
- GPU type: NVIDIA A100-SXM4-80GB
- `Accelerate` default config:
        - compute_environment: LOCAL_MACHINE
        - distributed_type: MULTI_GPU
        - mixed_precision: fp16
        - use_cpu: False
        - num_processes: 1
        - machine_rank: 0
        - num_machines: 1
        - gpu_ids: all
        - rdzv_backend: static
        - same_network: True
        - main_training_function: main
        - downcast_bf16: no
        - tpu_use_cluster: False
        - tpu_use_sudo: False
        - tpu_env: []

@garychan22 I think our issue here is you have "multi-gpu" selected, when you have a single process and a single machine. You can do vim ~/.cache/huggingface/accelerate/default_config.yaml, then modify the distributed_type key to be NO. Let me know if that fixes this

@muellerzr thanks for your help! correctly modifying the accelerate config resolved the issue.

I have the same error.
the output of  accelerate env is :

Accelerate version: 0.20.0.dev0
Platform: Linux-5.15.0-78-generic-x86_64-with-glibc2.35
Python version: 3.10.12
Numpy version: 1.24.2
PyTorch version (GPU?): 2.0.0+cu117 (True)
PyTorch XPU available: False
System RAM: 31.34 GB
GPU type: NVIDIA GeForce RTX 4090
Accelerate default config:

compute_environment: LOCAL_MACHINE
distributed_type: MULTI_GPU
mixed_precision: no
use_cpu: False
num_processes: 2
machine_rank: 0
num_machines: 1
gpu_ids: all
rdzv_backend: static
same_network: True
main_training_function: main
downcast_bf16: no
tpu_use_cluster: False
tpu_use_sudo: False
tpu_env: []

It gives
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 106507 closing signal SIGTERM
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: -9) local_rank: 1 (pid: 106508) of binary: /usr/bin/python3
Traceback (most recent call last):
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/home/dilara/.local/lib/python3.10/site-packages/torch/distributed/launch.py", line 196, in
main()
File "/home/dilara/.local/lib/python3.10/site-packages/torch/distributed/launch.py", line 192, in main
launch(args)
File "/home/dilara/.local/lib/python3.10/site-packages/torch/distributed/launch.py", line 177, in launch
run(args)
File "/home/dilara/.local/lib/python3.10/site-packages/torch/distributed/run.py", line 785, in run
elastic_launch(
File "/home/dilara/.local/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 134, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/home/dilara/.local/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 250, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:


rust: update geo crate to 0.26

New features

rust: bump geo dependency to version 0.26
workflow: add Rust release build in checks

How to test

Build in release mode
cargo clean
cargo build --release

Run the CopyCat example in release mode
cargo run --release --bin its-client -- -H <broker_host> -P <broker_port> -u <username> -p <password> --mqtt-client-id <client_id>

=> stdout logs tells that the copycat receives messages (cam, denm, ...)

Check the applicative logs
tail -F log/its-client_rCURRENT.log

=> Logs must tell about either copy/retain moving vehicle messages or stopped vehicle that are not copied

@nbuffon In addition to the rust issue, could you add the reference to
the corresponding geo crate issue as well: https://github.com/georust/geo/issues/1010

@nbuffon In addition to the rust issue, could you add the reference to the corresponding geo crate issue as well: georust/geo#1010

Done in corresponding commit's message


[BUG] Preview Overlaps Form Fields in Json Generator

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Description
When using the Json Generator page, after filling in the form fields and clicking the "Preview" button, the generated preview overlaps with the form fields. This overlap makes it difficult to view the preview clearly and interact with the form fields.
Expected Behavior:
The preview should be displayed in a way that does not overlap with the form fields, allowing users to view the result clearly and continue interacting with the form if necessary.
Actual Behavior:
The preview overlaps with the form fields, obstructing the view of the result and making the form fields partially or fully inaccessible.
Steps to Reproduce

Navigate to the Json Generator page.
Enter values in the form fields.
Click the "Preview" button.
Observe that the preview overlaps with the form fields.

Screenshots
Light

Dark

Do you want to work on this issue?
Yes
If "yes" to above, please explain how you would technically implement this
We will need to add a background color to the preview section/div. This will ensure that the preview area is visually distinct from the form fields and easier to read.

Thanks for raising the issue. I will look into it.

It should be fixed now

In darkmode its not in dark preview theme

In darkmode its not in dark preview theme

Thanks. I am going to fix it.

it should be fixed in #317

works like a charm 😎

I am very sorry, I just noticed now that you wanted to work on this issue. If you want you can work on another issue.

I am very sorry, I just noticed now that you wanted to work on this issue. If you want you can work on another issue.

It's fine. I updated it later after created the PR. So, not a big deal 😅.

I am very sorry, I just noticed now that you wanted to work on this issue. If you want you can work on another issue.

It's fine. I updated it later after created the PR. So, not a big deal 😅.

Okay


Replaced 'icon-' by the 'icon-[package name]'

I have replaced 'icon-' by the 'icon-[package name]' in each package folder's style.css. Changes are made on 28th and 29th line in style.css file in each package folder.

谢谢


[Bug fix] Fix readwrite test failed on graphscope.nx

What do these changes do?
Fix readwrite test failed on graphscope.nx
Related issue number
Fixes #1364

Codecov Report

Merging #1365 (33bce87) into main (b61457c) will decrease coverage by 33.29%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1365       +/-   ##
===========================================
- Coverage   73.57%   40.27%   -33.30%
===========================================
  Files          88       88
  Lines        9601     9601
===========================================
- Hits         7064     3867     -3197
- Misses       2537     5734     +3197

Impacted Files
Coverage Δ

python/graphscope/tests/unittest/test_lazy.py
0.00% <0.00%> (-100.00%)
:arrow_down:

python/graphscope/tests/unittest/test_java_app.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...ython/graphscope/tests/unittest/test_cython_ast.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...ython/graphscope/tests/unittest/test_serailaize.py
0.00% <0.00%> (-100.00%)
:arrow_down:

python/graphscope/analytical/udf/patch.py
3.47% <0.00%> (-96.53%)
:arrow_down:

...thon/graphscope/tests/unittest/test_scalability.py
0.00% <0.00%> (-96.16%)
:arrow_down:

python/graphscope/tests/unittest/test_app.py
0.00% <0.00%> (-95.53%)
:arrow_down:

...hon/graphscope/tests/unittest/test_create_graph.py
0.00% <0.00%> (-92.00%)
:arrow_down:

python/graphscope/tests/unittest/test_graph.py
0.00% <0.00%> (-84.73%)
:arrow_down:

python/graphscope/tests/unittest/test_context.py
0.00% <0.00%> (-81.04%)
:arrow_down:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61457c...33bce87. Read the comment docs.