Minitest/GlobalExpectations triggers google-cloud-storage unit test failures

Follow up https://github.com/rubocop-hq/rubocop-minitest/pull/65#issuecomment-596883141

Expected behavior
Minitest/GlobalExpectations auto-correction does not cause unit test failures.
Actual behavior
Minitest/GlobalExpectations auto-correct causes two google-cloud-storage unit test failures.
% bundle exec rubocop --only Minitest/GlobalExpectations -a test/google/cloud/storage/project_anonymous_test.rb

Inspecting 1 file
C

Offenses:

test/google/cloud/storage/project_anonymous_test.rb:25:7: C: [Corrected] Minitest/GlobalExpectations: Prefer using _(args.first).must_be_nil.
      args.first.must_be_nil # project
      ^^^^^^^^^^^^^^^^^^^^^^
test/google/cloud/storage/project_anonymous_test.rb:36:7: C: [Corrected] Minitest/GlobalExpectations: Prefer using _(args.first).must_be_nil.
      args.first.must_be_nil # project
      ^^^^^^^^^^^^^^^^^^^^^^
test/google/cloud/storage/project_anonymous_test.rb:56:5: C: [Corrected] Minitest/GlobalExpectations: Prefer using _(bucket.name).must_equal bucket_name.
    bucket.name.must_equal bucket_name
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
test/google/cloud/storage/project_anonymous_test.rb:74:5: C: [Corrected] Minitest/GlobalExpectations: Prefer using _(files.size).must_equal num_files.
    files.size.must_equal num_files
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
test/google/cloud/storage/project_anonymous_test.rb:77:7: C: [Corrected] Minitest/GlobalExpectations: Prefer using _(file.user_project).must_be :nil?.
      file.user_project.must_be :nil?
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
test/google/cloud/storage/project_anonymous_test.rb:96:5: C: [Corrected] Minitest/GlobalExpectations: Prefer using _(file.name).must_equal file_name.
    file.name.must_equal file_name
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
test/google/cloud/storage/project_anonymous_test.rb:97:5: C: [Corrected] Minitest/GlobalExpectations: Prefer using _(file.user_project).must_be :nil?.
    file.user_project.must_be :nil?
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 7 offenses detected, 7 offenses corrected
% bundle exec ruby -w -Itest test/google/cloud/storage/project_anonymous_test.rb                                                                                diag_rubocop_minitest_args
/Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/google-api-client-0.37.2/lib/google/apis/core/api_command.rb:132: warning: assigned but unused variable - a
/Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/google-api-client-0.37.2/lib/google/apis/core/batch.rb:171: warning: assigned but unused variable - length
/Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/httpclient-2.8.3/lib/httpclient/ssl_config.rb:370: warning: assigned but unused variable - pathlen
/Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/httpclient-2.8.3/lib/httpclient/ssl_config.rb:51: warning: method redefined; discarding old initialize
/Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/httpclient-2.8.3/lib/httpclient/ssl_config.rb:58: warning: method redefined; discarding old add_cert
/Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/httpclient-2.8.3/lib/httpclient/ssl_config.rb:58: warning: method redefined; discarding old add_file
/Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/httpclient-2.8.3/lib/httpclient/ssl_config.rb:58: warning: method redefined; discarding old add_path
/Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/google-api-client-0.37.2/lib/google/apis/core/base_service.rb:215: warning: method redefined; discarding old client
Run options: --seed 24803

# Running:

FDEPRECATED: global use of wont_be from test/google/cloud/storage/project_anonymous_test.rb:57. Use _(obj).wont_be instead. This will fail in Minitest 6.
/Users/yahonda/Desktop/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/bucket.rb:2210: warning: instance variable @lazy not initialized
.DEPRECATED: global use of must_be_kind_of from test/google/cloud/storage/project_anonymous_test.rb:76. Use _(obj).must_be_kind_of instead. This will fail in Minitest 6.
DEPRECATED: global use of must_be_kind_of from test/google/cloud/storage/project_anonymous_test.rb:76. Use _(obj).must_be_kind_of instead. This will fail in Minitest 6.
DEPRECATED: global use of must_be_kind_of from test/google/cloud/storage/project_anonymous_test.rb:76. Use _(obj).must_be_kind_of instead. This will fail in Minitest 6.
.FDEPRECATED: global use of wont_be from test/google/cloud/storage/project_anonymous_test.rb:98. Use _(obj).wont_be instead. This will fail in Minitest 6.
/Users/yahonda/Desktop/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/file.rb:1722: warning: instance variable @lazy not initialized
.DEPRECATED: global use of must_be_kind_of from /Users/yahonda/.rbenv/versions/2.6.5/lib/ruby/2.6.0/delegate.rb:83. Use _(obj).must_be_kind_of instead. This will fail in Minitest 6.
.

Finished in 0.025759s, 232.9283 runs/s, 582.3207 assertions/s.

  1) Failure:
Google::Cloud::Storage::Project::anonymous::mock_storage#test_0001_raises when creating a bucket without authentication [test/google/cloud/storage/project_anonymous_test.rb:30]:
[Google::Cloud::UnauthenticatedError] exception expected, not
Class: <NoMethodError>
Message: <"undefined method `_' for #<Object:0x00007fb26e827788>">
---Backtrace---
test/google/cloud/storage/project_anonymous_test.rb:25:in `insert_bucket'
/Users/yahonda/Desktop/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/service.rb:98:in `block in insert_bucket'
/Users/yahonda/Desktop/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/service.rb:631:in `execute'
/Users/yahonda/Desktop/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/service.rb:97:in `insert_bucket'
/Users/yahonda/Desktop/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/project.rb:379:in `create_bucket'
test/google/cloud/storage/project_anonymous_test.rb:30:in `block (3 levels) in <main>'
---------------

  2) Failure:
Google::Cloud::Storage::Project::anonymous::mock_storage#test_0002_raises when listing buckets without authentication [test/google/cloud/storage/project_anonymous_test.rb:41]:
[Google::Cloud::UnauthenticatedError] exception expected, not
Class: <NoMethodError>
Message: <"undefined method `_' for #<Object:0x00007fb26e91c120>">
---Backtrace---
test/google/cloud/storage/project_anonymous_test.rb:36:in `list_buckets'
/Users/yahonda/Desktop/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/service.rb:76:in `block in list_buckets'
/Users/yahonda/Desktop/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/service.rb:631:in `execute'
/Users/yahonda/Desktop/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/service.rb:75:in `list_buckets'
/Users/yahonda/Desktop/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/project.rb:153:in `buckets'
test/google/cloud/storage/project_anonymous_test.rb:41:in `block (3 levels) in <main>'
---------------

6 runs, 15 assertions, 2 failures, 0 errors, 0 skips
%

Steps to reproduce the problem
rbenv install 2.6.5 ; rbenv global 2.6.5 # or whatever use Ruby 2.6 because google-cloud-storage gem does not support Ruby 2.7 yet
gem install bundler
git clone -b diag_rubocop_minitest_args https://github.com/yahonda/google-cloud-ruby
cd google-cloud-ruby/google-cloud-storage/
bundle install
bundle exec ruby -w -Itest test/google/cloud/storage/project_anonymous_test.rb # to confirm this test passes before auto-correct
bundle exec rubocop --only Minitest/GlobalExpectations -a test/google/cloud/storage/project_anonymous_test.rb
bundle exec ruby -w -Itest test/google/cloud/storage/project_anonymous_test.rb

RuboCop version
$ [bundle exec] rubocop -V
0.74.0 (using Parser <IP_ADDRESS>, running on ruby 2.6.4 x86_64-darwin17)

I understand this is not the latest version of RuboCop, which is restricted by https://github.com/googleapis/ruby-style/blob/master/google-style.gemspec#L31

First of all, Thanks for your feedback!
As far as I've investigated, I think Minitest warnings cannot be fixed with simple substitutions.
The _ method defined by Minitest::Spec::DSL::InstanceMethods, and Object does not defined the method.
   it "raises when creating a bucket without authentication" do
+    p self.class.to_s #=> "Google::Cloud::Storage::Project::anonymous::mock_storage"
+    p self.respond_to?(:_) #=> true
+    p self.method(:_).owner #=> Minitest::Spec::DSL::InstanceMethods
     stub = Object.new
     def stub.insert_bucket *args
+      p self.class.to_s #=> "Object"
+      p self.respond_to?(:_) #=> false
       args.first.must_be_nil # project
       raise Google::Apis::AuthorizationError.new("unauthorized", status_code: 401)
     end

There are several possible approaches for the issue.

Change minitest usage for google-cloud-storage (Suggestion for google-gould-storage's code)
Make an Object instance respond to _ for Minitest (Suggestion for google-gould-storage or Minitest?)

I think the former is realistic.
Here is a simple quick fixes, but there is probably a better clean fix another approach.
diff --git a/google-cloud-storage/test/google/cloud/storage/project_anonymous_test.rb b/google-cloud-storage/test/google/cloud/storage/project_anonymous_test.rb
index 2767f361f..5fe3c3e35 100644
--- a/google-cloud-storage/test/google/cloud/storage/project_anonymous_test.rb
+++ b/google-cloud-storage/test/google/cloud/storage/project_anonymous_test.rb
@@ -20,7 +20,7 @@ describe Google::Cloud::Storage::Project, :anonymous, :mock_storage do
   let(:anonymous_storage) { Google::Cloud::Storage.anonymous }

   it "raises when creating a bucket without authentication" do
-    stub = Object.new
+    stub = self
     def stub.insert_bucket *args
       _(args.first).must_be_nil # project
       raise Google::Apis::AuthorizationError.new("unauthorized", status_code: 401)
@@ -31,7 +31,7 @@ describe Google::Cloud::Storage::Project, :anonymous, :mock_storage do
   end

   it "raises when listing buckets without authentication" do
-    stub = Object.new
+    stub = self
     def stub.list_buckets *args
       _(args.first).must_be_nil # project
       raise Google::Apis::AuthorizationError.new("unauthorized", status_code: 401)

Either way, I think it's difficult to solve with RuboCop Minitest. Thank you.

Thanks for the deep investigation. Agreed that these two failures addressed by google-cloud-storage gem or minitest.


Due in Full mission points to incorrect planet.

The Galbank Due in Full mission for "Kill delinquent Spacer orbiting Voll II Beta" points to Mars.

Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
No
Reproduction Steps
Proceed through the Galbank collection missions.
Obtain the above mission.  Follow it to Mars and realise you're in the wrong place. :)

I noted this a while ago and posted it on Reddit, hoping it would be resolved.
I had forgotten about it until I ended up on a different mission near the planet and saw "Ship" on my map, orbiting Vol II Beta.  I'm now flying around the planet, trying to find the ship.  The mission may be completely broken.

Yup, the mission is indeed incorrect.
The Spacer ship IS in orbit around Mars.  I remember now; I found it when I was flying a lesser vessel, and you end up 6-7k KM away from the ship, so it takes a long time to reach.

Yup, the mission is indeed incorrect.
The Spacer ship IS in orbit around Mars. I remember now; I found it when I was flying a lesser vessel, and you end up 6-7k KM away from the ship, so it takes a long time to reach.

FYI, there are other bugs with this quest as outlined here: https://www.reddit.com/r/Starfield/comments/16gvump/due_in_full_bugged/
And, in my own game, I cannot progress the quest because the ship was destroyed before the quest started. But the quest remains...

I encountered the same bug in my game and struggled to reproduce it on a new save. I had started the first mission and killed the target, but never turned it in, theoretically killing the second target before it should have been available to me. The way this quest works is weird... It's not a series of quests, rather, it is one quest that is being reset to act like a new quest (kind of like a procedural/radiant quest, but too specific). I think because it is the same quest, and the alias is filled at quest start (entering New Atlantis location) it spawns the delinquent spacer ship in the orbit of a settled system. Somehow it also gets the planet name wrong because that too is picked when the quest first started and not when it was needed and it somehow caches the planet name but targets a different planet. This quest is spaghetti AF, and I attempted to fix it here: RAD05 Due In Full Quest Fix (https://www.nexusmods.com/starfield/mods/7030). I'd like a second opinion from the SFCP team before it is implemented. I did confirm that my changes definitely don't break the quest. At worst, they are irrelevant - at best, they should resolve the issue. The proposed fix will not solve the issue for existing games where the quest is started, which most likely have because it is triggered by Story Manager Event Node of entering New Atlantis location. Existing saves can use console if they get stuck.
Purely speculating... Again, issue didn't present itself if I created a new save and quickly went through the questline - so maybe something is reset over time/not staying persistent? I had theories on this with the issues I had in my Better Courier mod for SSE where over time script filled aliases would eventually somehow become lost/unassigned.

There are so many bugs with this quest
For me the first stage completed without me ever going to the star system it was in, then when it told me to do this step there was NO spacer at Ganymede at all and I had to advange the quest stage with a console command to proceed, yesh

Same here except the quest location is constantly moving away from me and can never be reached. Starts at a few thousand KM away then with the distance rapidly increasing every second.
I also had the first stage completed without ever finding the target so maybe that's related to the cause of the bug; i.e. perhaps the locations get corrupted somehow leading to duplicate markers.

This is reportedly fixed officially in 1.14.


"detail": "Not authenticated" - when I use API

Hello
I had setup crawl4ai as a docker service.
When I try to call a request I get
"detail": "Not authenticated"
I had tried to edit .env file and put there api key, but this key gives me the same reply.
What could be wrong?
`POST /crawl/ HTTP/1.1
Accept: /
Accept-Encoding: deflate, gzip
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Host: ...
Content-Type: application/json
Content-Length: 33
{
"urls":"httts://www.onet.pl"
}and reply is{
"detail": "Not authenticated"
}`

@yacenty  Please refer to this issue https://github.com/unclecode/crawl4ai/issues/363


Not working when only a single player is present

I'm sory for that thats my 3th problem but i really need help. Everything is ok but while im ingame this program is not seeing that im alive or i have ult etc.

As you can see i have this problems, can u help me?

This application's information retrieval system works when there are a total of 10 players in the game. So a spike rush, unrated or competitive game would reflect that information, not for anything less than 10 players.

ok thank you im gonna try and give you feedback

still same problem

Is the 1920x1080 branch selected?

yep

No  I meant is that branch selected, not the resolution

my english is not so good can u explain me what is branch

When you clone this repository the main branch is selected which works for the 1920x1200 resolution. You have to type git checkout 1920x1080 to change to the 1920x1080 branch which would work for that resolution.

Where should i type this?

ups i found it thanks

git checkout 1920x1080

Where did you type this?


Update build commands

説明 / Description
ビルドコマンドの改善
チェックリスト / Checklist

MUST

[x] npm test passed
[x] npm run lint was applied without warnings
[x] changes of /docs/webapp not included (except release branch)
[x] console.log not included (except script file)

RECOMMENDED (it depends on what you change)

[ ] unit test added/updated
[ ] i18n

We're currently processing your upload.  This comment will be updated when the results are available.


Fix Theme Token Typing in vscode

Support VSCode Typing by issue
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] This change requires a documentation update

:tada: This PR is included in version 3.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


readme updates and added hjson to dependencies

+1 was going to submit exactly that. without hjson and npm run build this won't fly

sorry, just merging now

fixed in 2.5.2


azimuth' is not a valid attribute for

i have copied the jvrc_mj_description model from the commit proposed within this repo. It didn't get downloaded with the rest of the repo.
`python3 run_experiment.py train --logdir exp_dir --num_procs 12 --env jvrc_step
Wrapping in SymmetricEnv.
Modifying XML model...
Warning! Cannot use SymmetricEnv. Line 8: error while parsing element : 'azimuth' is not a valid attribute for
Modifying XML model...
Traceback (most recent call last):
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 213, in _parse_children
mjcf_child.set_attributes(**attributes)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 534, in set_attributes
old_value = self._get_attribute(attribute_name)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 507, in _get_attribute
self._check_valid_attribute(attribute_name)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 504, in _check_valid_attribute
attribute_name, self._spec.name))
AttributeError: 'azimuth' is not a valid attribute for
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "run_experiment.py", line 121, in
run_experiment(args)
File "run_experiment.py", line 41, in run_experiment
obs_dim = env_fn().observation_space.shape[0]
File "/home/sangramrout/LearningHumanoidWalking/envs/jvrc/jvrc_step.py", line 22, in init
builder(path_to_xml_out)
File "/home/sangramrout/LearningHumanoidWalking/envs/jvrc/gen_xml.py", line 12, in builder
mjcf_model = mjcf.from_path(JVRC_DESCRIPTION_PATH)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 106, in from_path
assets=assets)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 169, in _parse
_parse_children(xml_root, mjcf_root, escape_separators)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 219, in _parse_children
_parse_children(xml_child, mjcf_child, escape_separators)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 218, in _parse_children
f'<{xml_child.tag}>: {err}').with_traceback(traceback)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 213, in _parse_children
mjcf_child.set_attributes(**attributes)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 534, in set_attributes
old_value = self._get_attribute(attribute_name)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 507, in _get_attribute
self._check_valid_attribute(attribute_name)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 504, in _check_valid_attribute
attribute_name, self._spec.name))
AttributeError: Line 8: error while parsing element : 'azimuth' is not a valid attribute for `
`python3 run_experiment.py train --logdir exp_dir --num_procs 12 --env jvrc_walk
Wrapping in SymmetricEnv.
Modifying XML model...
Warning! Cannot use SymmetricEnv. Line 8: error while parsing element : 'azimuth' is not a valid attribute for
Modifying XML model...
Traceback (most recent call last):
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 213, in _parse_children
mjcf_child.set_attributes(**attributes)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 534, in set_attributes
old_value = self._get_attribute(attribute_name)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 507, in _get_attribute
self._check_valid_attribute(attribute_name)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 504, in _check_valid_attribute
attribute_name, self._spec.name))
AttributeError: 'azimuth' is not a valid attribute for
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "run_experiment.py", line 121, in
run_experiment(args)
File "run_experiment.py", line 41, in run_experiment
obs_dim = env_fn().observation_space.shape[0]
File "/home/sangramrout/LearningHumanoidWalking/envs/jvrc/jvrc_walk.py", line 22, in init
builder(path_to_xml_out)
File "/home/sangramrout/LearningHumanoidWalking/envs/jvrc/gen_xml.py", line 12, in builder
mjcf_model = mjcf.from_path(JVRC_DESCRIPTION_PATH)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 106, in from_path
assets=assets)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 169, in _parse
_parse_children(xml_root, mjcf_root, escape_separators)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 219, in _parse_children
_parse_children(xml_child, mjcf_child, escape_separators)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 218, in _parse_children
f'<{xml_child.tag}>: {err}').with_traceback(traceback)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/parser.py", line 213, in _parse_children
mjcf_child.set_attributes(**attributes)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 534, in set_attributes
old_value = self._get_attribute(attribute_name)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 507, in _get_attribute
self._check_valid_attribute(attribute_name)
File "/home/sangramrout/mambaforge/envs/rl/lib/python3.7/site-packages/dm_control/mjcf/element.py", line 504, in _check_valid_attribute
attribute_name, self._spec.name))
AttributeError: Line 8: error while parsing element : 'azimuth' is not a valid attribute for `

recreated a new env and this issue is gone


AggregateTarget dependencies aren't set as dependencies in Xcode

aggregateTargets:
  Agg:
    buildScripts:
      - name: Carthage Verify
        script: cd $SRCROOT && $SRCROOT/Carthage/carthage-verify.sh
targets:
  App:
    dependencies:
      - target: Agg1

I get the error Target "App" has invalid dependency: "Agg"
Related, there is no way to make an AggregateTarget depend on another AggregateTarget.

@yonaskolb Since this is new for the coming release, think we can get a fix for it? I looked a bit but wasn't 100% sure what was going on here.

They can be referenced, but the aggregate targets aren't actually set as target dependencies.

I didn't confirm why it's broken, but I think Xcode removes the dependency for being invalid for some reason.

It's a bug with transitivelyLinkDependencies. I'll work on a fix. Re-closing this.


New plugin - basemap switch control

New plugin featuring a basemap control with an integrated synchronized miniature map

Hello,
Thank you for the feedback! I’ve made the necessary updates: clarified the description, fixed the zoom level 0 issue, added disableClickPropagation, and updated to Leaflet 1.9.4.


Event handler with arguments raises error

This code works:
include karax/prelude

const maxMessageLength = 10
var buttonEnabled = true

proc renderTweetBox*(): VNode =
  buildHtml(tdiv):
    textarea():
      proc onkeyup(event: Event, n: VNode) =
        buttonEnabled =
          if n.value.len < maxMessageLength: true
          else: false

    if buttonEnabled:
      button():
        text "Tweet"
    else:
      button(disabled = "disabled"):
        text "Tweet"

setRenderer renderTweetBox

but line 11 gets underlined by nimsuggest in VSCode with the following error:
type mismatch: got <VNode, EventKind, proc (event: Event, n: VNode){.gcsafe, locks: 0.}, KaraxInstance>

but expected one of:
proc addEventHandler(n: VNode; k: EventKind; action: EventHandler;
kxi: KaraxInstance = kxi)
first type mismatch at position: 3
required type: EventHandler
but expression 'proc (event: Event; n: VNode) = buttonEnabled = if len(value(n)) < 10: true else: false' is of type: proc (event: Event, n: VNode){.gcsafe, locks: 0.}
proc addEventHandler(n: VNode; k: EventKind; action: proc (); kxi: KaraxInstance = kxi)
first type mismatch at position: 3
required type: proc (){.closure.}
but expression 'proc (event: Event; n: VNode) = buttonEnabled = if len(value(n)) < 10: true else: false' is of type: proc (event: Event, n: VNode){.gcsafe, locks: 0.}

expression: addEventHandler(tmp179021, onkeyup, proc (event: Event; n: VNode) = buttonEnabled = if len(
value(n)) < 10: true else: false, kxi)

There is no such problem with handlers without arguments.

That's a nimsuggest problem.


Spherical joint fix

I fixed the collision issue for spherical joints by adding a case to the jacobian calculation. I had to create 'apply' and 'apply_inverse' methods for 3x6 (Force/Motion matrices) in the transform class.
These are different for Force and Motion matrices so I implemented them using a flag indicating what they are. Is this an issue regarding differentiability?

Thanks a lot for the fixes! Will merge it now, the CI is very slow.


Auto sweep

solid progress. I've got AAAAAAA model worked out, but I'm still working out how to work with it? I think I'm messing something up still, but we'll have to see.


Remove unecessary padding around avatar

The circular avatar shape adds a bit of padding around the image. How can we remove it?

Thanks for your feedback. I've just published the 2.2.0 version of the package.
In this version you can use the margin parameter to remove the default card padding like this:
Avatar(
    margin: EdgeInsets.zero,
    name: 'Alberto Fecchi'
),

Let me know if you have other issues, thanks!


weave launch fails

david@david-Latitude-E6440:~/gocode/src/github.com/weaveworks/weave$ ./weave launch
The weave container has died. Consult the logs with 'docker logs weave' for further details.
david@david-Latitude-E6440:~/gocode/src/github.com/weaveworks/weave$ docker logs weave
weave 2015/06/25 21:34:01.490591 Command line options: map[iprange:<IP_ADDRESS>/10 name:e6:7a:d3:c6:7a:12 nickname:david-Latitude-E6440 port:6783 wait:20 iface:ethwe]
weave 2015/06/25 21:34:01.490630 Command line peers: []
weave 2015/06/25 21:34:01.490708 Communication between peers is unencrypted.
weave 2015/06/25 21:34:01.491020 Our name is e6:7a:d3:c6:7a:12(david-Latitude-E6440)
weave 2015/06/25 21:34:01.491023 Assuming quorum size of 1
INFO: 2015/06/25 21:34:01.491518 [docker] Using Docker API on unix:///var/run/docker.sock: &[Os=linux Version=1.5.0 ApiVersion=1.17 Arch=amd64 GitCommit=a8a31ef GoVersion=go1.3.3 KernelVersion=3.19.0-18-generic]
weave 2015/06/25 21:34:01.519788 ethwe: no IPv4 address assigned

Is the last line an error?

yes

do you get the same result with the official release?

No - the official release (where weave pulls the images) works OK.

I got these warnings when building:
/usr/lib/gcc/x86_64-linux-gnu/4.9/../../../x86_64-linux-gnu/libpcap.a(nametoaddr.o): In function `pcap_nametoaddrinfo':
(.text+0x82): warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/lib/gcc/x86_64-linux-gnu/4.9/../../../x86_64-linux-gnu/libpcap.a(nametoaddr.o): In function `pcap_nametoaddr':
(.text+0x5): warning: Using 'gethostbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/lib/gcc/x86_64-linux-gnu/4.9/../../../x86_64-linux-gnu/libpcap.a(nametoaddr.o): In function `pcap_nametonetaddr':
(.text+0xc5): warning: Using 'getnetbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/lib/gcc/x86_64-linux-gnu/4.9/../../../x86_64-linux-gnu/libpcap.a(nametoaddr.o): In function `pcap_nametoproto':
(.text+0x305): warning: Using 'getprotobyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/lib/gcc/x86_64-linux-gnu/4.9/../../../x86_64-linux-gnu/libpcap.a(nametoaddr.o): In function `pcap_nametoport':
(.text+0x109): warning: Using 'getservbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

That is normal.
Perhaps you have some out-of-date libs. try make update

go get -u -f -v -tags -netgo ./prog/weaver/ ./prog/weavedns/ ./prog/sigproxy/ ./prog/weaveproxy/ ./prog/weavewait/ ./prog/netcheck/
flag provided but not defined: -f
usage: get [-d] [-fix] [-t] [-u] [build flags] [packages]

It's probably my bad - which Go version do I need? I'm just using Go 1.3.3 (comes with Ubuntu 15.04)

I removed the -f, did make update but got the same result :(

From http://docs.weave.works/weave/latest_release/building.html: "Building weave requires Go 1.4.2"

You might want to try the containerized build (described in the "Building in a Docker container" section of the "Building Weave" page).  That isn't dependent on the environment of the host system.

@rade @dpw that's my bad then, sorry. I'll try Go 1.4.2 on Ubuntu.


capture url from textview click

is there any way to get the clicked url???

duplicate: https://github.com/SufficientlySecure/html-textview/issues/87


Avoid pulling entire result set into memory when constructing dataframe.

Closes #5859.

Just came across this. Ping us over at pandas-gbq if you have other performance thoughts / ideas
On this: I'm not sure this change will have that much impact, because pandas will coerce to in-memory python values regardless. Parsing each page and loading that into an array makes a big difference but I haven't implemented, in the hope that BQ has a step change in APIs from JSON-over-HTTP; full description: https://github.com/pydata/pandas-gbq/issues/133#issuecomment-383253436


New domain for Université de Corse Pascal Paoli

This is currently used along with univ-corse.fr.

@palindromordnilap Could you please confirm that the name of the university is "Université de Corse Pascal Paoli"? The official website says otherwise: UNIVERSITÀ DI CORSICA.

I went with the French name because this was the one already used for the other domain, but it turns out that the university seems to have changed all official communication to use the Corsican name, so I'm going to change both.

@palindromordnilap Thank you for the update! Pull request merged.


Add Activity Functionality

Please do work for this task in a branch called issue-74.
User should be able to add an activity, and see it in the opportunities page.

This issue has been implemented it is on the landing page.
Need someone to do UI/UX


Relax omniauth-oauth2 dependency

:tophat: What?
We were using a fixed verion of omniauth-redbooth. Which is a bad practice.

Improve dependency management (set things on gemspec)
Remove Gemfile.lock since it is supossed to be out of version control
for gems.

:ghost: GIF

:+1:

:+1:


Philipp Zimmer

When I first submitted the changes in time, I got some inconsistencies since I continued to use the old fork from the project proposal stage, so I basically had to indicate what content of the respective files was new and which was not relevant anymore (from proposal stage).


Basic Google Cloud support

Should be able to use S3 storage backend for Storehouse in conjunction with Google Compute Engine instances to run Scanner jobs. Doesn't have to be perfect (e.g. manually sshing into nodes is ok), but should allow hackathon users to run their own GPU cluster.

This will be awesome! Being able to spin up a bunch of nodes to churn through a large dataset would be incredibly useful.


Bugfix: When req.x.field is not set, the validator sets its value to 'undefined'

Coverage remained the same at 100.0% when pulling d4f055994310d276755ff579db1f8ec8409ddc2f on bugfix/undefined_values into 439d068a77f009c10e7fcfa293e83d7f37adfcd4 on master.


From source update

The idea here is to try and remove the snafu that's happening from the usage of the From Source runs requiring a metric ton of AdditionalModules. The changes are as follows:

For the From Source runs, build and install all of the client libraries. Note that the root pom.xml has both tracks in it, and because of that I generate a client only aggregate pom file to build.
Remove the -am switch from the From Source runs. This was over-running. When building libraries for a given sdk/area we don't about running tests for our dependencies, we only care about running tests for things that depend on us.
Remove the unnecessary AdditionalModules from ci.yml files. Note: in this case it's just identity's ci.yml for testing and concept purposes. If this works I'll flush the rest of the unnecessary additional modules.
When calling update_versions.py, we weren't passing in the --sr to skip readme/changelog updates. Because the changelog updates use common code which is powershell that means we're having to create a separate process to call this. This was adding 1-3 minutes onto a step that should take about 10 seconds to run.
Put the dependency checker for the bom file build inside of a profile. This is what we're doing in the azure-client-sdk-parent and we're passing in -Ddependency-checker on the command line. I did the same for the POM build so we're consistent here.
Move the allow list generation under the dependency-checker since it's not useful outside of the aggregate reports and though it takes several seconds to run, there are 100+ libraries to build.

/azp run java - identity - ci

/azp run java - spring - ci

/azp run java - spring

/azp run java - cosmos

/azp run java - cosmos

/azp run java - spring

/azp run java - spring

/azp run java - appconfiguration


PMM: Program Mgmt Module Objects & Data Model overview

This is a walkthrough of the objects. There is also an unfinished sample data-based walkthrough without any big picture info, based on same doc.
https://powerofus.force.com/s/article/PMM-Overview
https://docs.google.com/document/d/1IzyrLTJrQcaIGGl24OMQniAab9FmYnHPXVkNvZkSdc0/edit?usp=sharing

Ditto here @dacontaoi -- is this ready for me to pass to SFDO? Thanks!

@barbarachristensen  Moved this and #82 to "Peer Review Complete."

We took a look at this script and approved associated comments.

We made one additional change- we streamlined the example in the ending paragraphs to all be about Alex's Support Group.

@barbarachristensen back to you...looks great! I added a comment or two.

I am going to work on the data model diagrams for this at the sprint. @Billflorio  what is the software we have used  for making animations in the past? Thanks!

@barbarachristensen @coriobriensfdo @pkasolves I have a rough draft of an animated ERD with some text examples.  Please take a look on the sequencing and the examples.  Rewording the text is easy, if this is still not clear we may go back to the drawing board.  https://youtu.be/G6bCbX1uG6k

I think it should do 3 walk through examples start to finish for clarity.

Hi! Cool! Nice job, it's well laid out, clear in the diagrams. I think it's a bit too much info all at once with all 3 examples on screen together. Maybe using each of the 3 as the sample to explain a grouped idea (like just the service schedule for the support groups, just the main program/engagement object for the wildfire, etc). I'm not yet caught up on PMM in an intuitive way, so I'm a newbie mindset still, and I was a little lost towards the end. And some kind of illustration or story might help as well/either? Happy to chat about it "in person" if easier

We are moving this one backwards bc Justin has good ideas

See if Justin G is still interested in pulling this together


Upgrade ClickHouse <IP_ADDRESS>

Docker image supports ARM64

v<IP_ADDRESS> may has issue on ARM64
https://github.com/ClickHouse/ClickHouse/issues/36286

@martin-g The ClickHouse <IP_ADDRESS> passed integration test on x86_64, would you please check if the integration test works on ARM64?

The problem seems to be in the ARM64 image itself.
On x86_64 I can do:

docker run --rm -it clickhouse/clickhouse-server:<IP_ADDRESS> bash
root@5401f1d253f9:/# su-exec test
Usage: su-exec user-spec command [args]

But on aarch64 it fails with segfault:
docker run --rm -it clickhouse/clickhouse-server:<IP_ADDRESS> bash
/entrypoint.sh: line 39:    10 Segmentation fault      $gosu test -f "$CLICKHOUSE_CONFIG" -a -r "$CLICKHOUSE_CONFIG"
Configuration file '/etc/clickhouse-server/config.xml' isn't readable by user with id '101'

To enter in the docker container I need to override the entrypoint:
docker run --rm -it -v --entrypoint bash  clickhouse/clickhouse-server:<IP_ADDRESS>

and then trying to use su-exec segfaults:
 su-exec test
Segmentation fault

Sounds like another issue than https://github.com/ClickHouse/ClickHouse/issues/36286 of ClickHouse, would you mind report it to the ClickHouse? We can upgrade the version it once the upstream releases the patched version.

@pan3793 https://github.com/ClickHouse/ClickHouse/issues/36293


Upgrade kubernetes-client to latest

What is the feature request? What problem does it solve?
Currently, we use 16.0.2 version of kubernetes-client in control service project.
We cannot currently upgrade because we still need to support APIs from 1.20 and we still need V1beta1CronJob (which is removed in latest version.
And the following 3 need to be upgraded in one change:

io.kubernetes:client-java
io.kubernetes:client-java-api-fluent
org.yaml:snakeyaml (can be upgraded after above 2)

See PRs open by dependabot:

https://github.com/vmware/versatile-data-kit/pull/1712
https://github.com/vmware/versatile-data-kit/pull/1710
https://github.com/vmware/versatile-data-kit/pull/1700

Suggested solution
Create PR that upgrades to latest version after we remove support for V1beta1CronJob

Triaged. Closed as stale.
This work depends on the Internal VMWare deployment, to upgrade to a Kubernetes version, that supports the requirements here.


Paging Notification Queue Messages

Is your feature request related to a problem? Please describe.
If a notification queue receiver breaks down and the ingest queue builds up to the factor of hundreds of thousands of messages, Your only options are to grab 1 message or grab all messages.
Describe the solution you'd like
There are currently two methods of interacting with the ingest notification queues: /get_message and /get_message_list. It would be great if we could request x number of messages from the queue. This would be easier for "paging" the data on the receiver side.

This feature should included in <IP_ADDRESS>.


Upgrade vineyard to v0.11.0

What do these changes do?
as titled.
This pull request also tweak the k8s/Makefile a bit to make the hard-coded vineyard verison lesser and let the upgrade progress easier.
Related issue number
n/a

Codecov Report

Merging #2260 (df0cdad) into main (4f17777) will increase coverage by 27.00%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2260       +/-   ##
===========================================
+ Coverage   40.15%   67.15%   +27.00%
===========================================
  Files          87       89        +2
  Lines        9885     9922       +37
===========================================
+ Hits         3969     6663     +2694
+ Misses       5916     3259     -2657

Impacted Files
Coverage Δ

...aphscope/tests/kubernetes/test_resource_builder.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...on/graphscope/tests/kubernetes/test_demo_script.py
0.00% <0.00%> (-92.38%)
:arrow_down:

python/graphscope/deploy/kubernetes/utils.py
11.90% <0.00%> (-57.62%)
:arrow_down:

python/graphscope/deploy/kubernetes/cluster.py
23.01% <0.00%> (-51.70%)
:arrow_down:

...thon/graphscope/tests/kubernetes/test_with_mars.py
0.00% <0.00%> (-44.83%)
:arrow_down:

...n/graphscope/deploy/kubernetes/resource_builder.py
30.52% <0.00%> (-26.32%)
:arrow_down:

python/graphscope/interactive/query.py
69.51% <0.00%> (-14.64%)
:arrow_down:

python/graphscope/client/rpc.py
75.57% <0.00%> (ø)

python/graphscope/__init__.py
82.14% <0.00%> (ø)

python/graphscope/version.py
100.00% <0.00%> (ø)

... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f17777...df0cdad. Read the comment docs.


[CAT-707] Add call to register custom blueprints

Add a single class to register different types of custom blueprints.
Open question: do we need to do more thorough type-checking of the config dict at the SDK level, or is it ok to let the platform (fog) handle that?

Add a single class to register different types of custom blueprints.
Open question: do we need to do more thorough type-checking of the config dict at the SDK level, or is it ok to let the platform (fog) handle that?

fair question. definitely leave the decision to you and micah but my 2 cents is that the fog API should ideally give you back very good details about what is wrong with the config, thus you may not want to make redundant checks and instead surface the BE error messages directly and cleanly
Additionally, and there are 2 schools of thought:
If you keep the sdk model as simple as possible, it makes it easier for BE to introduce additions without SDK changes required
But if you keep the sdk model very complex, it could save us from making backwards-incompat changes to the config parser in the BE
I defer to y'all :)

Add a single class to register different types of custom blueprints.
Open question: do we need to do more thorough type-checking of the config dict at the SDK level, or is it ok to let the platform (fog) handle that?

I agree with astha that most of the time the back end should surface more complex config issues, but I also think some simple checks here for values we know are always required is a good idea.


Extension on gnome.org is corrupt

See below:

Cheers

Completely forgot system details.. Firefox stable 65.0.1 on Solus GNOME

You’re trying to install a GNOME Shell extension as a Firefox extension. That will never work. I don’t really understand how you even got Firefox to think that a GNOME extension was a Firefox extension.
You need to install the GNOME Shell extension for Firefox before you can install extensions from https://extensions.gnome.org
Alternatively, you can try to install it via the GNOME Web (“epiphany”) browser.


problems in building the project by eclipse in Mac OS X

build the project by eclipse in Mac OS X ,build error:
ld: library not found for -lSDL2
clang: error: linker command failed with exit code 1 (use -v to see invocation)
I have already install SDL ,Copy the SDL2.framework to /Library/Frameworks
Could you help me

Hi, I just started testing Littlevgl. I had the same issue as Jason, in order to succesfully compile on MacOS you need to download the SDL2 library and then configure Eclipse to as follows.
OPTION 1. Using SDL2 libraries directly from SDL2 website.

Need to include SDL headers
Open the pc_simulator project properties and go to C/C++ Build -> Settings, under Cross GCC Compiler select Includes and add the following /Library/Frameworks/SDL2.framework/Versions/A/Headers

You need to set configure the linker
Under the same screen select Cross GCC Linker -> Miscellaneous and add the following
-F/Library/Frameworks -framework SDL2 -framework Cocoa

Then select Libraries and remove the SDL2main and SDL2
OPTION2. Using SDL2 libraries from Brew.

Using brew install SDL2 from a terminal using
brew install sdl2
After installation is complete you should be able to compile successfully from Eclipse, but Brew libraries may not be up to date compared with SDL2 original source.

Now that you can compile, you will face another issue under MacOS I will report that on a different issue.

Thank you @margce .
As LittlevGL uses only the very basic features of SDL it's not problem if we don't use the latest version. I added these steps on the website to help others.
As OSX compatibility seems to be solved I close this issue.
Thank you very much  for the contribution!


clickhouse failed because of tpch data

More details may refer to https://github.com/juicedata/juicefs/runs/6084906534?check_suite_focus=true .

/usr/bin/ld: bm_utils.o: in function `yes_no':
bm_utils.c:(.text+0x5e): warning: the `gets' function is dangerous and should not be used.
*** invalid open call: O_CREAT or O_TMPFILE without mode ***: terminated
/home/runner/work/_temp/6a3efe4e-40bc-472f-8e7e-2ea28d81cb36.sh: line 5: 12322 Aborted                 (core dumped) ./dbgen -s 10 -T l -q

Looks like not a juicefs related issue. Besides, this action is deprecated.


Create Dapperdox API specifications for psc-filing-api

Instructions on how to download and configure DapperDox can be found here.
Once dapperdox is installed

set env var DAPPERDOX to the install directory (preferably in your shell's login script), e.g.

export DAPPERDOX=~/dev/dapperdox

run dapperdox with

./run_dapperdox.sh

navigate your browser to

http://localhost:4005

Should we refer to the 'filing resource' as the 'PSC filing resource' in all its occurrences?

Can we add a '415' response for the PATCH request?


Search user by email or name

Add a search function in User management page by email, first name or last name.

Implemented on both version 0.2 and 0.3


Unified logic for excel extraction

This introduces new cleaned up excel extractor (in extract/excel.py) and refactors extract/eia860.py and extract/eia923.py to use this common code instead of consisting largely of slightly-modified boilerplate code peppered with custom business logic.
This refactoring mostly keeps the external API as is. There are few points where I think the interaction with the other code is sub-optimal and might benefit from further refactoring/cleanup, specifically:

helpers.py:verify_input_files() - this is a monolith method for checking existence of files, aggregates business logic across datasets and basically just runs datastore method and see if they throw an exception. eia860 and eia923 were pulled out and verify_files() method is now called for these at call-sites. I do not quite like this solution but I'm also not yet sure how to solve this elegantly.

Pulling files from datastore is a place where API is also somewhat obscure. Right now, both datastore and extractor provide partial information about where the data is stored and this has to be combined. On top of this, Extractor needs to pass data_dir to the datastore. Ideally, we would want single module/component to be in charge of figuring out where the data lives (different modules may need different identifiers, e.g. page, year for spreadsheets but possibly something else for other inputs), which would clean up these interactions. I think this problem may be addressed with the planned refactoring of datastores.

Note that eia861 was not converted to use this new code and that the code still relies on the old-style non-transposed column_maps.

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 10

Complexity increasing per file
==============================
- src/pudl/extract/excel.py  7

Complexity decreasing per file
==============================
+ src/pudl/workspace/datastore.py  -1
+ src/pudl/extract/eia860.py  -4
+ src/pudl/extract/eia923.py  -7
+ src/pudl/helpers.py  -10

Clones added
============
- test/conftest.py  1
- test/datastore_test.py  1

Clones removed
==============
+ src/pudl/extract/eia860.py  -1
+ src/pudl/extract/eia923.py  -1

See the complete overview on Codacy

Hey @rousik thanks so much for this contribution! We're working on the two issues you bring up, in the context of switching the datastore over to using data packages containing the raw data that are pulled down from Zenodo. @ptvirgo has been the one primarily working on this. Sorry for all the auto-comments on the PR -- they're from the Codacy integration.
It looks like the Travis CI builds failed in the linting phase -- do you have Tox set up in your environment? To run the suite of Travis tests locally, without downloading new data or re-building the FERC 1 DB unnecessarily, you can do:
tox -v -e travis -- --fast --pudl_in=AUTO --live_ferc1_db=AUTO

and there's some documentation on the other (linting, docs, etc.) tests that are run and how to get all that stuff set up locally over here on Read The Docs.

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 5

Complexity increasing per file
==============================
- src/pudl/extract/excel.py  7

Complexity decreasing per file
==============================
+ src/pudl/workspace/datastore.py  -1
+ src/pudl/helpers.py  -10
+ src/pudl/extract/eia860.py  -4
+ src/pudl/extract/eia923.py  -7

Clones added
============
- test/datastore_test.py  1
- test/conftest.py  1

Clones removed
==============
+ src/pudl/extract/eia860.py  -1
+ src/pudl/extract/eia923.py  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 9

Complexity increasing per file
==============================
- src/pudl/extract/excel_test.py  1
- src/pudl/extract/excel.py  7

Complexity decreasing per file
==============================
+ src/pudl/extract/eia860.py  -4
+ src/pudl/helpers.py  -10
+ src/pudl/workspace/datastore.py  -1
+ src/pudl/extract/eia923.py  -7

Clones added
============
- test/conftest.py  1
- test/datastore_test.py  1

Clones removed
==============
+ src/pudl/extract/eia860.py  -1
+ src/pudl/extract/eia923.py  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 5

Complexity increasing per file
==============================
- src/pudl/extract/excel.py  7
- src/pudl/extract/excel_test.py  1

Complexity decreasing per file
==============================
+ src/pudl/extract/eia923.py  -7
+ src/pudl/helpers.py  -10
+ src/pudl/extract/eia860.py  -4
+ src/pudl/workspace/datastore.py  -1

Clones added
============
- test/conftest.py  1
- test/datastore_test.py  1

Clones removed
==============
+ src/pudl/extract/eia923.py  -1
+ src/pudl/extract/eia860.py  -1

See the complete overview on Codacy

Good progress toward standardizing the Excel extraction process for use across all the various EIA data. Thank you!


上架被拒提示HealthKit

上架被拒HealthKit，我想问下，在我们这个二维码扫描里，用到这个框架作用是什么呢？提示信息如下： identified one or more issues with a recent delivery for your app, "星河邦". Please correct the following issues, then upload again.
Missing Purpose String in Info.plist File - Your app's code references one or more APIs that access sensitive user data. The app's Info.plist file should contain a NSHealthShareUsageDescription key with a user-facing purpose string explaining clearly and completely why your app needs the data. Starting Spring 2019, all apps submitted to the App Store that access user data will be required to include a purpose string.If you're using external libraries or SDKs, they may reference APIs that require a purpose string. While your app might not use these APIs, a purpose string is still required. You can contact the developer of the library or SDK and request they release a version of their code that doesn't contain the APIs. Learn more (https://developer.apple.com/documentation/uikit/core_app/protecting_the_user_s_privacy).
Missing Purpose String in Info.plist File - Your app's code references one or more APIs that access sensitive user data. The app's Info.plist file should contain a NSHealthUpdateUsageDescription key with a user-facing purpose string explaining clearly and completely why your app needs the data. Starting Spring 2019, all apps submitted to the App Store that access user data will be required to include a purpose string.If you're using external libraries or SDKs, they may reference APIs that require a purpose string. While your app might not use these APIs, a purpose string is still required. You can contact the developer of the library or SDK and request they release a version of their code that doesn't contain the APIs. Learn more (https://developer.apple.com/documentation/uikit/core_app/protecting_the_user_s_privacy).

是不是使用了LBXPermission的权限的东西了，权限的不能全部包含，只能使用哪个权限，包含哪个代码

我看你的LBXPermissionHealth.h这里有用到，我将这几个类删除了，删除了对二维码扫描好像也没什么影响吧？

没有影响，这个只是用到相机权限，其他权限没用到，没用到的可以删除了

好的，谢谢大佬

emmmmmmm，没用到HealthKit，就不应该把HealthKit加入工程，避免更多开发者上线App被拒。


Title: Screen time analysis using Python

Using python data visalization we can analyze the relation between time screen and notifcayions
I have personally worked on this and is good for beginner to start with Data analysis. Looking to add this in the repo. .kindly assign me this issue

hey @Kushal997-das i have learnt python . i m a beginner and is looking forward for a opportunity to work upon this issue.kindly assign me this issue

hey @Kushal997-das i have learnt python . i m a beginner and is looking forward for a opportunity to work upon this issue.kindly assign me this issue

This issue you haven't open so it's not possible to assign you , but you can contact me . I'll help

@poojaharihar03 Explain your issue in more details.

@Kushal997-das
so the idea is for a given dataset, need to see the relation between the usage of devices to the number of notifications apps, etc.
It is a beginner level for data analysis in python and a useful way to dive in to the data analysis

@poojaharihar03 What category the project is? Under which folder are you going to add ?

@Kushal997-das
since it is data analysis i guess I can add it in machine learning basics right?

hey @Kushal997-das i have learnt python . i m a beginner and is looking forward for a opportunity to work upon this issue.kindly assign me this issue

This issue you haven't open so it's not possible to assign you , but you can contact me . I'll help

How can i open it ..  i dodnt get it. Can you please help

please assign me this issue

hey @Kushal997-das i have learnt python . i m a beginner and is looking forward for a opportunity to work upon this issue.kindly assign me this issue

This issue you haven't open so it's not possible to assign you , but you can contact me . I'll help

How can i open it .. i didnt get it. Can you please help

Contact me

@Kushal997-das since it is data analysis i guess I can add it in machine learning basics right?

Yes


Fixed #418, move the operation which create instances json array outs…

…ide of for each function.

Coverage remained the same at 17.393% when pulling 9987f5f7aa6a08b30b66948f1b1d5f393b27946f on fix/418 into e2e991d83d2f16ba4a039a15e516859791620773 on master.


Glyph corruption in sf::Font when using GL_SCISSOR_TEST

Subject of the issue
I have observed rendering artifacts when using sf::Font with GL_SCISSOR_TEST. I tracked it down to Texture::update(Texture&, ..)  performed internally in sf::Font when rendering new glyphs, in the codepath using GLEXT_framebuffer_blit. Copying glyphs to larger texture with GL_SCISSOR_TEST enabled may corrupt them and they will stay that way even if GL_SCISSOR_TEST is later disabled, resulting in seemingly random glyphs going permanently missing or corrupted for particular font sizes.
Your environment
Windows 10, Visual Studio 2019, master branch of SFML
Steps to reproduce
#include <SFML/Graphics.hpp>
#include <SFML/OpenGL.hpp>

int main()
{
    sf::RenderWindow okno( sf::VideoMode( {320, 240 }), "Scissors" );
    sf::Font font;
    // https://fonts.google.com/specimen/Charis+SIL/about
    if(!font.loadFromFile("CharisSIL-Regular.ttf"))
        return 0;

    sf::Text text(font, "0123456789ABCDEFGHIJKLMNOPQ", 30);
    text.setFillColor(sf::Color::White);

    glEnable(GL_SCISSOR_TEST);
    glScissor(0, 0, 30, 30);
    okno.draw(text); // Trigger caching several glyphs with GL_SCISSOR_TEST active.
    glDisable(GL_SCISSOR_TEST);

    while( okno.isOpen() )
    {
        sf::Event event;
        while( okno.pollEvent( event ) )
        {
            if( event.type == sf::Event::Closed )
                    okno.close();

        } //while
        okno.clear();
        okno.draw(text);
        okno.display();
    }
}

As mentioned on #2589 correctly handling of OpenGL states, while using the graphics module, is the user's responsibility. You can use pushGLStates() / popGLStates() or resetGLStates() to let SFML deal with its own OpenGL states, but you still have to enable/disable your own states, as SFML won't be tracking that.
See: https://www.sfml-dev.org/tutorials/2.6/window-opengl.php#using-opengl-together-with-the-graphics-module

As mentioned on #2589 correctly handling of OpenGL states, while using the graphics module, is the user's responsibility. You can use pushGLStates() / popGLStates() or resetGLStates() to let SFML deal with its own OpenGL states, but you still have to enable/disable your own states, as SFML won't be tracking that.
See: https://www.sfml-dev.org/tutorials/2.6/window-opengl.php#using-opengl-together-with-the-graphics-module

I set scissor test because I want to use it, render text with clipping. How should I know if SFML is going to internally call something that should not have scissor test enabled? Should application code render any text on scratch surface, just to be in the clear when performing proper render? Then perhaps optimize it by remembering size-style-character tuples that should already be safe to draw? This is quite a workaround. Perhaps it should be documented, to save trouble for the next guy?
I don't think it's that much to save. According to https://registry.khronos.org/OpenGL/extensions/EXT/EXT_framebuffer_blit.txt

The pixel copy bypasses the fragment pipeline.  The only fragment
operations which affect the blit are the pixel ownership test and
the scissor test.

Unfortunatley it's just a bad OpenGL global state handling. You can't really have any two users operate without making some assumptions about these states.
Switching states isn't exactly free either, so we don't really want to just switch all the possible states when rendering something with SFML "just to be safe". Instead we make not guarantees in general, leave the responsibility up to the user and offer the already mentioned options.
We're also currently in the process of adding native scissor testing to SFML: #1451


Fix IKEA dimmer device automation triggers

The dictionary was off by an indentation level.

Codecov Report

Merging #1466 (1fbfaa3) into dev (bbc69c0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1466   +/-   ##
=======================================
  Coverage   80.30%   80.30%
=======================================
  Files         227      227
  Lines        6687     6687
=======================================
  Hits         5370     5370
  Misses       1317     1317

Impacted Files
Coverage Δ

zhaquirks/ikea/dimmer.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc69c0...1fbfaa3. Read the comment docs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.305%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5370

Relevant Lines:
6687

💛  - Coveralls


fatal error: unexpectedly found nil while unwrapping an Optional value

When i call:
SCLAlertView().showError("Error", subTitle: "Please contact Administrator.")
My ViewController error in:
let rv = UIApplication.sharedApplication().keyWindow! as UIWindow
Please!

Do you call this on viewDidLoad?
Try on viewWillAppear

Thank you!

Having this problem even for a simple:
SCLAlertView().showInfo("Important info", subTitle: "You are great")
I tried it in viewDidLoad, viewWillAppear, I have used this library for a year without any problems,
Deployment target is: 9.3 with Xcode version 7.3


replace node_modules with package manifest

In order to avoid the 'works on my machine' scenario, it's best practice to not check in node dependencies and instead use manifest file with locked version of each dependency.
This PR deletes and ignores node_modules and adds a package-lock file with known-good dependency versions.

pleas am new to empire can anyone help me in setting up the GUI ?


Add Full Organization Report

Adding a script that can utilize the Octokit library to generate a report listing all organizations, their repositories, collaborators, effective permissions, teams, and team permissions.
This repository seems like a good place for this Organization report script to live!

@gjtorikian @nathos for your review :smile_cat:

Sorry for missing this earlier! This looks like some 😍  Ruby! I made a couple of suggestions around having the script make use of the ENV vars suggested in the comments, but otherwise, total 👍  to merge. Thank you!


Additional policies for Managed node group IAM Role

Hi,
I'm using latest version of module "20.31.0".
For adding additional IAM policies, the module have supported :

iam_role_additional_policies : Additional policies for Cluster IAM Role
node_iam_role_additional_policies : Additional policies for EKS Auto node IAM role

but in my (common) case, I would need add additional policies for EKS managed (not Auto) node IAM role. I tried to read https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/variables.tf#L667-L687 and in the code, looks like there is no support for this, please correct me If I'm wrong. Thank you.
Best Regards,
VietNC

it just goes inside the node group definition block https://github.com/terraform-aws-modules/terraform-aws-eks/blob/c63a57908d7b4d51895d3f8502d60daae758b761/tests/eks-managed-node-group/main.tf#L299-L302


Update CI permissions in GitHub Actions workflow

User description

Resolves #ISSUE_NUMBER

Before the change?

After the change?

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been reviewed and added/updated if needed (for bug fixes/features)

Does this introduce a breaking change?

[ ] Yes
[ ] No

Description

Enhanced CI configuration by updating permissions for GitHub Actions.
Changed contents permission from read to write.

Changes walkthrough 📝
Relevant filesConfiguration changes

ci.ymlUpdate CI permissions for GitHub Actions

.github/workflows/ci.yml

Changed permissions from 'read' to 'write' for contents.

+1/-1

Summary by CodeRabbit

Chores

Updated GitHub Actions workflow to allow write access to repository contents, enhancing the workflow's capabilities for managing files during the CI process.

@gstraccini review

@gstraccini review


only build docs if pushed to main

Don't know if this was intended by you

No code changes, just changed github action


Theme documentation to support Salt (Next) release note

From @bhoppers2008

We should aim to get an 'official' release note out on Salt Next docs at end of this week.
Making Salt (Next) available is opening the flood gates for theming. We need to document:

What is Salt theming? What is it not? What is it intended for?
What is a theme? How does it impact my product? What are the risks? (None/limited–same components different/new theme).
What is the Salt (Next) library? Who should use it? (Currently limited to new brand endorsed palettes–legacy palette a WIP).
How to use the Salt (Next) library? How do i set up my themes for my project?

Briefing arranged for 1530 (BST) today.

Docs shared for review with leads @origami-z @dplsek @joshwooding @mark-tate


Added converted rows filegroup declarative table (merge first)

Addresses
https://github.com/microsoft/azuredatastudio/issues/25209
https://github.com/microsoft/azuredatastudio/issues/25210
https://github.com/microsoft/azuredatastudio/issues/25130
Styling is not finalized, but it uses whatever is known of other declarative tables.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.758%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
30827

Relevant Lines:
69081

💛  - Coveralls

A follow PR for the filestream table will follow after this one

@smartguest  Do the Default checkboxes still work properly when toggling different rows? I remember someone else had issues integrating that behavior with the declarative table

Gif showing the current state:

I'm still seeing the rows disappear when toggling defaults with multiple file rows.

It's only when the new FileGroup has files in it, since that's when the default checkbox becomes enabled

Added a fix by clearing the dataValues right before setting the new data, this appears to alleviate the angular issue that happens when attempting to set the isDefault changes. (Might need to implement this as part of the extHostModelView but for now it will be only in this area)


DO NOT MERGE<<< HHH-12391

@sebersole this reverts your last commit, it was causing some test failures.
here a test that reproduces the issue.
finally here a possible solution

I don't follow.  How was my test causing other test failures?

@sebersole I haven't investigated but seems the changes you made cause
Failing tests
If run individually they pass but running the entire test suite they fail

That's so strange - I cannot fathom how that change would cause those failures.  But clearly they do (its the only change in that build) and the test is not needed anyway.

I'm not sure if it helps with this failure but should the rollback() + commit() methods be changed to always clear the rollbackOnly flag?  Currently, they look like they are not clearing the rollbackOnly flag.

@scottmarlow the rollback() method sets the rollbackOnly flag to false;
anyway the commit seems fixing the problem

@scottmarlow have you tested whether the changes here fix your failure?

@sebersole I haven't, I should be able to try that.

@dreab8 I meant that rollback() may not clear rollbackOnly, if for example we enter the method and don't reach the rollbackOnly=false.  Perhaps the entire method body should be in a try/finally {rollbackOnly=false;}
Commit() does not set rollbackOnly=false, that probably also needs a try {} finally {rollbackOnly=false} around the method body, to ensure that we do not leave rollbackOnly == true.  We might call rollback() or not.

@scottmarlow for the commit() method I think there is not need, when rollbackOnly=true the rollback() method is called.
For rollback() you may be right, probably rollbackOnly=false should be the first thing the rollback() method does.

@scottmarlow forget my last comment on the rollback() change, your idea of try/finally for setting the rollbackOnly=false is correct.
Running test and then I'll push the changes.

@sebersole thanks, I'm going to merge it.


Support for inline styles

Hey, I hope I not just missed some way of doing this that already exists, but I'd like to use inline styles. This comes with the nice benefit of being able to express your styles in terms of code and running optimizations, dead-code-eliminations etc. on it.
In purescript-react the Style modifier accepts arbitrary records. Could the same be done here?

I would like to work on something generic in the style of Clay, which could be implemented in another library and then used here and elsewhere.
If anyone wants to start working on something like that, I'd probably get involved...

Clay looks amazing indeed! Agreed with the type safety, especially since the keys would be unchecked strings.
But I wonder if a stop gap solution would be better than not supporting it at all until something like Clay comes into existence in PureScript land. :) When changing background images on the fly, for example, it's not possible to express that through static CSS.

Just quickly checked, to add support for the React attribute, this actually works:
diff --git a/src/Thermite/Html/Attributes.purs b/src/Thermite/Html/Attributes.purs
index 35027e8..461d2a6 100644
--- a/src/Thermite/Html/Attributes.purs
+++ b/src/Thermite/Html/Attributes.purs
@@ -276,6 +276,9 @@ start = unsafeAttribute "start"
 step :: forall action. String -> Prop action
 step = unsafeAttribute "step"

+style :: forall s action. { | s} -> Prop action
+style = unsafeAttribute "style"
+
 tabIndex :: forall action. String -> Prop action
 tabIndex = unsafeAttribute "tabIndex"

But I guess I can also use this as local helper function in my project instead.

I agree that a solution is needed, but using open records really goes against the goal of this library IMO. It should be straightforward to support this in a library though...

Okay, that's a totally valid call to make. Thanks for the explanation!
I don't know whether you want to keep this open for future roadmap plans, otherwise feel free to close it. :)

Yes, let's keep it open.

purescript-css might be helpful here /cc @puffnfresh

Now that Thermite uses purescript-react, I'm going to close this.


Cannot resolve dependency with Scala 2.12.0

If I write scalaVersion := "2.12.0" in my build.sbt, it cannot resolve the dependency "com.lihaoyi" %%% "scalatags" % "0.6.1"

the docs aren't updated. the latest version is 0.6.2,  which is published for scala 2.12.


static libraries include libSDLmain.a and libSDL.a, so breaking linking

This bug report was migrated from our old Bugzilla tracker.
Reported in version: 1.2.12
Reported for operating system, platform: Mac OS X (All), All
Comments on the original bug report:
On 2012-11-16 01:13:08 +0000,  wrote:

When compiling with the configure and makefile on Mountain Lion, libSDLmain.a and libSDL.a get somehow included in libSDL_image.a. This seems to confuse ld, as I ge tthe following message in the final linking with the application:
ld: warning: ignoring file lib/libSDL_image.a, file was built for archive which is not the architecture being linked (x86_64): lib/libSDL_image.a
otool and lipo still recognize the library as a x86_64 blob. It's only clang that seems to be upset at it.
The same happens with libSDL_mixer.a, but I won't report this bug twice.
I don't know whether this is related to # 1429.

This SDL-1.2 branch issue won't be fixed.


Error

npm start

<EMAIL_ADDRESS>start /root/whatsapp-stickers-bot
npm run dev

<EMAIL_ADDRESS>dev /root/whatsapp-stickers-bot
nodemon --config nodemon.json src/index.ts

[nodemon] 2.0.19
[nodemon] to restart at any time, enter rs
[nodemon] watching path(s): src/**/*
[nodemon] watching extensions: ts
[nodemon] starting ts-node src/index.ts
(node:76671) UnhandledPromiseRejectionWarning: Error: Failed to launch the brows    er process! spawn /root/whatsapp-stickers-bot/node_modules/puppeteer/.local-chro    mium/linux-982053/chrome-linux/chrome ENOENT
TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troublesh ooting.md
at onClose (/root/whatsapp-stickers-bot/node_modules/puppeteer/src/node/Brow    serRunner.ts:268:9)
at ChildProcess.<anonymous> (/root/whatsapp-stickers-bot/node_modules/puppet    eer/src/node/BrowserRunner.ts:257:9)
at ChildProcess.emit (events.js:315:20)
at ChildProcess.EventEmitter.emit (domain.js:485:12)
at Process.ChildProcess._handle.onexit (internal/child_process.js:274:12)
at onErrorNT (internal/child_process.js:468:16)
at processTicksAndRejections (internal/process/task_queues.js:84:21)

(Use node --trace-warnings ... to show where the warning was created)
(node:76671) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This     error originated either by throwing inside of an async function without a catch     block, or by rejecting a promise which was not handled with .catch(). To termin    ate the node process on unhandled promise rejection, use the CLI flag --unhandl    ed-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejecti    ons_mode). (rejection id: 1)
(node:76671) [DEP0018] DeprecationWarning: Unhandled promise rejections are depr    ecated. In the future, promise rejections that are not handled will terminate th    e Node.js process with a non-zero exit code.
[nodemon] clean exit - waiting for changes before restart

Hey @bkzutr90! How are you doing?
Could you try pulling the latest changes? Earlier today I committed 📌 Update @totigm/whatsapp-bot version due to WhatsApp web breaking changes.
Using @totigm/whatsapp-bot latest version (v1.0.9) should fix it.

Hey @bkzutr90! How are you doing?
Thanks for creating an issue. Could you try pulling the latest changes? Earlier today I committed pushpin Update @totigm/whatsapp-bot version due to WhatsApp web breaking changes.
Using @totigm/whatsapp-bot latest version (v1.0.9) should fix it.

:~/whatsapp-stickers-bot# npm start

<EMAIL_ADDRESS>start
npm run dev

<EMAIL_ADDRESS>dev
nodemon --config nodemon.json src/index.ts

[nodemon] 2.0.19
[nodemon] to restart at any time, enter rs
[nodemon] watching path(s): src/**/*
[nodemon] watching extensions: ts
[nodemon] starting ts-node src/index.ts
Error: Failed to launch the browser process!
[1112/151147.513533:ERROR:zygote_host_impl_linux.cc(90)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md
at onClose (/root/whatsapp-stickers-bot/node_modules/puppeteer/src/node/BrowserRunner.ts:268:9)
at Interface.<anonymous> (/root/whatsapp-stickers-bot/node_modules/puppeteer/src/node/BrowserRunner.ts:254:50)
at Interface.emit (node:events:525:35)
at Interface.emit (node:domain:489:12)
at Interface.close (node:readline:590:8)
at Socket.onend (node:readline:280:10)
at Socket.emit (node:events:525:35)
at Socket.emit (node:domain:489:12)
at endReadableNT (node:internal/streams/readable:1358:12)
at processTicksAndRejections (node:internal/process/task_queues:83:21)

[nodemon] app crashed - waiting for file changes before starting...

This was fixed on the 📌 Update @totigm/whatsapp-bot version commit.
Closing issue.


Update sbt-ci-release to 1.9.0

About this PR
📦 Updates com.github.sbt:sbt-ci-release from 1.5.12 to 1.9.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.sbt", artifactId = "sbt-ci-release" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.sbt", artifactId = "sbt-ci-release" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #125.


Importing typefaces

Although importing CSS is easy with the new version 2.0.0, it is still not possible to import fonts out-of-the-box. #40
The following could easily remedy the situation:

Adding font file extensions like .woff, .woff2, .eot, .ttf to the withFileLoader
Making the withFileLoader independent from the file extension by removing the test expression and by providing an exclude for .css and .js files
Providing a plugin out-of-the-box to load fonts e.g. withFontsLoader:

const withFontsLoader = config => {
	config.module.rules = config.module.rules.concat([
		{
			loader: 'url-loader',
			test: /\.(png|woff|woff2|eot|ttf|svg)$/,
			query: {
				limit: 10000,
				name: 'static/[name].[hash:8].[ext]',
			},
		},
	]);
	return config;
};

Thanks!

Would you like to make a PR to the plugins directory? It could include this
and also update the other file loader plugin with the changes you
mentioned.
On Sat, Oct 21, 2017 at 2:51 PM Calvin Reibenspieß<EMAIL_ADDRESS>wrote:

Although importing CSS is easy with the new version 2.0.0, it is still
not possible to import fonts out-of-the-box. #40
https://github.com/nozzle/react-static/issues/40
The following could easily remedy the situation:

Adding font file extensions like .woff, .woff2, .eot, .ttf to the
withFileLoader
Making the withFileLoader independent from the file extension by
removing the test expression and by providing an exclude for .css and
.js files
Providing a plugin out-of-the-box to load fonts e.g. withFontsLoader
:

const withFontsLoader = config => {
config.module.rules = config.module.rules.concat([
{
loader: 'url-loader',
test: /.(png|woff|woff2|eot|ttf|svg)$/,
query: {
limit: 10000,
name: 'static/[name].[hash:8].[ext]',
},
},
]);
return config;
};
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/70, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCSQpCZcA603iuU8c8H2oVyM7Hf4Dks5sullFgaJpZM4QBtjB
.

Funny how we are getting back to gatsbys plugin system 😅 I think requiring fonts is probably something that should also work "out of the box"

I don't necessarily see this as a path towards a react-static-plugin system (these are just webpack rules, after all), but it could be tough to constantly update the withFileLoader plugin with everything that should migrate to dist.
I think the default option should be one of the following:

Anything that is not supposed to be compiled (images, fonts, etc.) in src will move to dist (essentially following the 2nd option @calvinrbnspiess suggested)
Standard image filetypes in src will move to dist, but anything else has to be a custom loader.

I'm personally good with either, since webpack rules are relatively straightforward to implement, but the documentation should be updated to reflect what is and is not supported by default.

@tannerlinsley I think @alexiscordova and @D1no's arguments are really good and I also think that the most important file types should be requirable without any further configuration.
I will propose a PR that allows us to load the most important file types via file-loader, but allows us to opt-out and provide custom loaders via those webpack transformer functions.


Forge Project URL link broken

https://forge.puppetlabs.com/rtyler/puppet-jenkins is broken.

This is something that is fixed and will go with the next release, thanks for the report


Docs refresh

What type of pull request is this?

[ ] Non-breaking code change
[ ] Breaking code change
[x] Documentation change/addition
[ ] Tests change

Description

Updates documentation and various typing fixes from @Astrea49 and @silasary
Checklist

[x] I've formatted my code with Black
[x] I've ensured my code works on Python 3.10.x
[x] I've tested my code

This pr is ready for review.
The shortcomings coming from moving to Griffe are outweighed by the benefits of the new docs.
As a note, merging this pr will retire the RTD sites


support shadow root nested custom elements

Thanks for this wonderful library!  This PR makes sure to fire connectedCallback and disconnectedCallback even for custom elements contained within shadow roots of other custom elements.
When recursively firing connectedCallback and disconnectedCallback we need to traverse down through any shadow roots we find along the way.
And then when determining isConnected for a node within a shadow root, we need to traverse up through shadow root host elements to find our way to the owner document.  In order to facilitate this, we implement the host property for shadow roots.

@dchester nice and clean PR, good stuff! My only concern is around the closed mode ... I think a WeakMap with all element -> shadowRoot nodes, instead of trusting that SR will always be open and reachable, might be a better way forward ... what do you think?

Yes, good point.  I'll try that out.

Btw, this project is more for SSR than for testing headless pages, which is why I never cared much about shadowRoot, because it cannot be serialized as SSR (yet? who knows when) ... so please keep in mind as soon as shadow roots will be serializable as SSR the code around it might change.

I pushed up a commit that does better now with closed shadow roots.
It looks like there's already a shadowRoots WeakMap in place in element.js to help with this, but I had to extract it to its own module to avoid circular dependencies.  Not sure if there's a better way, but this at least does the trick.  What do you think?

Yes, makes sense.  Thanks much!


bin/proxy.py: cache incoming data, don't cache own translations

When I pull data for my location using ?format= I get different, old version of the data. At the moment it is about 45 minutes old. When I issue the command without the format, I get current results.
root@ZeroZ [~] curl wttr.in/~Maksimir?format="%t+%h+%w+%p+%P+%C"
+19°C 32% ?0km/h 0.0mm 1019hPa Sunny
root@ZeroZ [~] curl wttr.in/~Maksimir?0QT
    \  /       Partly cloudy
  _ /"".-.     18 °C
    \_(   ).   ? 0 km/h
    /(___(__)  10 km
               0.0 mm

I need as short input as possible since I will not be using data directly but fed it into my program. I tried several different computers from 2 different locations with different IP's, same thing. Same if I try  hr.wttr.in or several different languages.

Yes, it is possible, because wttr.in (and the datasource too) uses multi-layer caching (though 45 minutes sounds too much for me, but in the worst case scenario it is possible).
wttr.in handles many millions query daily (it is several hundreds each second at the peak times). Just imagine how would it be possible without a caching?
(a small trick for you to bypass caching: add several (random number of) + to the end of the location name  wttr.in/~Maksimir+++; but don't do it too often, because in this case the wttr.in load protection mechanism will block the IP)

This was 2 hours ago, and I still get the same results.
Adding +, ++ and ++ did not change the result. Still the same as 2 hours ago.

I expected caching. 2 hours it is not. When I change to
curl --compressed hr.wttr.in/Zagreb?format="%t+%h+%w+%p+%P+%C"
I get the current results. How often is to be tolerated well? Once in an hour? Every half hour? Even slower?

I think you are right, and there were a bug in the caching module indeed. Let us see if the problem disappeared now.
You can always check how old are the data like this:
$ curl -ks wttr.in/Maksimir?format=j1 | jq -r .current_condition[0].localObsDateTime
2020-05-04 03:55 PM

I have just now (3 hours after the initial request) received fresh data. I will be checking and will report back if suspiciously long caching occurs.
My payload is about 50 bytes :) Your service is great! I wanted to test if I can use it as a backup in case my primary local system looses connection to my external sensors (which occurs occasionally). The above requ3est fits me perfectly, I am happy with say, 30 or 60 minutes refresh.

I have just now (3 hours after the initial request)

I believe it was a bug indeed; I think that after it was fixed, the data will not be too old anymore.

My payload is about 50 bytes

Payload is not a problem, it would be ok even if you would fetch more.
The problem is that without the caching it would generate a lot of additional (and not necessary) work. Keep in mind that the server is being constantly used by many thousands people all over the world, and we still deliver 99.9% responses withing 100ms. That is because of the sophisticated caching system wttr.in has.

I am happy with say, 30 or 60 minutes refresh

You can send queries so often as you wish (there are even some crazy users who send a request each second); but reasonable update time would be around 5-10 minutes.
It is hard to say what is average lifetime of the data in the cache (because as I said before, the cache is multilayerd and with randomized expiration time to avoid peak loads), but in average it should be something around 10-15 minutes. What wanted to say with this: "don't do it too often, because in this case the wttr.in load protection mechanism will block the IP" — was about the random + trick, to bypass the caching system, and get the fresh data; normal queries are limited).

No point in doing it every second since I doubt any service will update temperature data at that rate. I set my program to pull the data every 30 minutes. Now, 4 hours later, I still get the same data!
I am currently querying two locations, Maksimir is the large park in the Zagreb and it has its own meteo station in my country. Normally it is about 2c colder than the city center (Zagreb).
``
curl -s --compressed hr.wttr.in/~Maksimir?format="%t+%h+%w+%p+%P+%C"
curl -s --compressed hr.wttr.in/Zagreb?format="%t+%h+%w+%p+%P+%C"

Something else is going on. When I try your command to get Java version, I get different data for Maksimir which I am getting for last several hours using the above commands!
My above commands obviously fetch some stale data. Java data from your previous post is correct.

It is not Java data, it is JSON data to be more precise, but you are right, I've already checked it,
and I see that the data is outdated indeed. I will investigate it. I acknowledge the problem; I hope to fix it soon

Data was changed for the first time after (local +2 time CET dst ) after 20:33 and before 21:03. That is some 5 hours.
With your above json version, I got new timestamp after one hour:
from:
2020-05-04 08:06 PM
to (I did not try in the meantime):
2020-05-04 09:17 PM

I think I've fixed it. Now the data should be in average not older than 30 min:
~$ curl -ks hr.wttr.in/Zagreb?format=j1 | jq -r .current_condition[0].localObsDateTime
2020-05-04 10:21 PM
$ curl -ks wttr.in/Zagreb?format=j1 | jq -r .current_condition[0].localObsDateTime
2020-05-04 10:21 PM
$ curl -ks wttr.in/Maksimir?format=j1 | jq -r .current_condition[0].localObsDateTime
2020-05-04 10:20 PM
$ curl -ks hr.wttr.in/Maksimir?format=j1 | jq -r .current_condition[0].localObsDateTime
2020-05-04 10:20 PM

One day later... I have setup pooling every 15 minutes, Maksimir and Zagreb from one location (Maksimir is part of the Zagreb). Plus, I did setup logging.
I can confirm I am getting new data in 30 minutes at the fastest for both locations. Never in 15 minutes.
There are two issues:

I get different data for different queries for the same location! I tried the following about 45 minutes ago (19:34 CET dst), one after the other:
`
curl hr.wttr.in/Zagreb?format="%t+%h+%w+%p+%P+%C"
+15°C 88% ?13km/h 0.7mm 1013hPa Light Rain

curl hr.wttr.in/Zagreb?0QT
.-.      Light Rain
(   ).    14..15 °C
(_()   ? 13 km/h
‘ ‘ ‘ ‘   10 km
‘ ‘ ‘ ‘    0.7 mm
curl -ks wttr.in/Zagreb?format=j1
...
"humidity": "82",
"localObsDateTime": "2020-05-05 07:31 PM",
"observation_time": "05:31 PM",
"precipMM": "0.7",
"pressure": "1013",
"temp_C": "14",
...
"windspeedKmph": "11",
...
`
Commands were issued in rapid sequence. As you can see, I got 3 different temperatures: "14", "14..15" and "15". Also, Humidity differs. Wind speed also. Something is not good here.
Second issue: I am asking for Croatian language, but am getting English. Croatian stopped working at 17:03 today and at 17:33 I have had only English answers (3 hours ago). Irrelevant, but off.
Also, occasionally I received a descriptions: "Rain, Light Rain" and "Light Rain" - the first one looks suspicious a bit :) Also irrelevant, but off.

Thank you for investigation!
Now I increased the update interval because of the high load, and it is likely that it will be not 30 minutes now, but rather 40-45; otherwise we can't fit the upstream capacity.
Regarding different results for the same location. I think it is a minor bug indeed, and I have to look at it. The problem here that the translation is cached, and not the original data. That is why we have different expiration times for different translations. That is not grave, but that should be fixed.
Regarding partial translations:
the problem is that some translations are missing here:
https://github.com/chubin/wttr.in/blob/master/share/translations/hr.txt

First, let me congratulate you on great service you created with wttr.in. It ix next to impossibly rare to see something now that works efficiently! Without needing many mb of transferred data :)
Update frequency is not a problem if it is occurring in known intervals. It can never be good if things occur without our control :) I guessed what happen when I started receiving that late night warnings.
As I am polling data on 15 minutes, I can confirm that currently refresh time is in between 45 and 60 minutes starting yesterday 20:48 (CET DST) when the last 30 min update occured for me (hr.wttr.in)
As for translations, it is clear how cache affects them. Not an important issue.
But, I do not feel "Rain, Light Rain" should exist. It is either "Rain" or "Light Rain". The second one is translated to Croatian "Lagana kiša". I do not see the Rain translated ("Kiša") if it should exist.

Thank you, @pilaGit
We (me and the other 90 contributors) are trying our best to make the best weather service for the console.
Regarding Rain, Light Rain: this descriptions comes from the data source, not from us, but probably you are right, that it should be automatically splitted at commas, and translated part by part.
I will add it to the todo list above


TimeoutError when starting a kernel still poping out

Description
What steps will reproduce the problem?

I started Spyder and hovered over one of those red "X" icons in the editor margin to see the tooltip, and this dialog box appeared
Traceback
  File "C:\Users\AlexStoll\Anaconda3\lib\site-packages\spyder\plugins\ipythonconsole\plugin.py", line 1083, in set_spyder_breakpoints
    cl.shellwidget.set_spyder_breakpoints()
  File "C:\Users\AlexStoll\Anaconda3\lib\site-packages\spyder\plugins\ipythonconsole\widgets\debugging.py", line 143, in set_spyder_breakpoints
    CONF.get('run', 'breakpoints', {}))
  File "C:\Users\AlexStoll\Anaconda3\lib\site-packages\spyder_kernels\comms\commbase.py", line 538, in __call__
    call_dict, call_data, self._comm_id)
  File "C:\Users\AlexStoll\Anaconda3\lib\site-packages\spyder\plugins\ipythonconsole\comms\kernelcomm.py", line 130, in _get_call_return_value
    with self.comm_channel_manager(comm_id, queue_message=not interrupt):
  File "C:\Users\AlexStoll\Anaconda3\lib\contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "C:\Users\AlexStoll\Anaconda3\lib\site-packages\spyder\plugins\ipythonconsole\comms\kernelcomm.py", line 87, in comm_channel_manager
    timeout)
  File "C:\Users\AlexStoll\Anaconda3\lib\site-packages\spyder\plugins\ipythonconsole\comms\kernelcomm.py", line 168, in _wait
    raise TimeoutError(timeout_msg)
TimeoutError: Timeout while waiting for comm port.

 Let's wait to see if more people reports it.

From issue #12037: steps to reproduce:

Launch python -m spyder_kernels.console on remote host
Conect to remote kernel in spyder using ssh creds and kernel json.

I experienced the same issue Spyder 4.1 / Python 3.7
File "E:\DEV\envs\LORA\lib\site-packages\spyder\plugins\ipythonconsole\plugin.py", line 569, in update_path
shell.update_syspath(path_dict, new_path_dict)
File "E:\DEV\envs\LORA\lib\site-packages\spyder\plugins\ipythonconsole\widgets\shell.py", line 223, in update_syspath
blocking=False).update_syspath(path_dict, new_path_dict)
File "E:\DEV\envs\LORA\lib\site-packages\spyder_kernels\comms\commbase.py", line 538, in call
call_dict, call_data, self._comm_id)
File "E:\DEV\envs\LORA\lib\site-packages\spyder\plugins\ipythonconsole\comms\kernelcomm.py", line 130, in _get_call_return_value
with self.comm_channel_manager(comm_id, queue_message=not interrupt):
File "E:\DEV\envs\LORA\lib\contextlib.py", line 112, in enter
return next(self.gen)
File "E:\DEV\envs\LORA\lib\site-packages\spyder\plugins\ipythonconsole\comms\kernelcomm.py", line 87, in comm_channel_manager
timeout)
File "E:\DEV\envs\LORA\lib\site-packages\spyder\plugins\ipythonconsole\comms\kernelcomm.py", line 168, in _wait
raise TimeoutError(timeout_msg)
TimeoutError: Timeout while waiting for comm port.

@impact27, we really need your help with this one. I don't understand why it's still happening.

I don't have access to a remote host now to try it but if it happens consistently I think it means the port used for comms is blocked by the firewall.

As I said in the other issue this is happening for me when running slow tests locally all the time and it happens randomly on CI systems so there is something going on beyond "your system is too slow".

@impact27, I think we need to show a kernel error message when this happens in the console, instead of raising a TimeoutError that people is compelled to report here.

As I said in the other issue this is happening for me when running slow tests locally all the time and it happens randomly on CI systems so there is something going on beyond "your system is too slow".

Yes the system would need to be very slow for the kernel to not launch in 45 seconds. There are no steps to reproduce so it is a bit hard for me to do a better guess. The local tests are passing on my machine.
Issue #12037: I think this might be related to the firewall blocking the port used for comms.
Issue #12247: I think this is unrelated to comms and happens because the kernel is not launching somehow (Not in 45 seconds anyway). The line where the tests are crashing is already a line that was added to handle slow-starting kernels in tests. It would be useful if you could confirm that by looking at the failing test and checking if the kernel comes up in a reasonable amount of time for the failing test. In practice I would record the screen to avoid having to look at the computer during the entire test procedure. As far as I know the tests only fail during the setups of the tests in test_mainwindow.py. Can you:
1 - Confirm whether the local tests only fail during the test setup in test_mainwindow.py?
2 - Send a video of a failing test setup if that is the case?

@impact27, I think we need to show a kernel error message when this happens in the console, instead of raising a TimeoutError that people is compelled to report here.

We could have a message saying:
"The communication with the kernel is unresponsive. Try restarting the kernel if this persists."

Will do late today! Thanks. The tests that fails is not always the same, it just changes everytime I run the slow test suite.

Will do late today! Thanks. The tests that fails is not always the same, it just changes everytime I run the slow test suite.

Yes I see but I think that what is failing is the setup for the tests, So any test in test_mainwindow.py might fail, but always during the setup.

might fail, but always during the setup.

Will check and let you know ;-)

I tried a lot things to reproduce this but I couldn't. Let's wait to see if more people reports it.

I ve got the same issue but not getting what and where is the problem...

I tried a lot things to reproduce this but I couldn't. Let's wait to see if more people reports it.

I ve got the same issue but not getting what and where is the problem...

My understanding is that the kernel dies for some reason and then the frontend can not communicate to the kernel any more, raising the TimeoutError. Is that the case for you? was the kernel alive when the error rose?

I tried a lot things to reproduce this but I couldn't. Let's wait to see if more people reports it.

I ve got the same issue but not getting what and where is the problem...

My understanding is that the kernel dies for some reason and then the frontend can not communicate to the kernel any more, raising the TimeoutError. Is that the case for you? was the kernel alive when the error rose?

no the kernel was dead...

no the kernel was dead...

Do you know why the kernel was dead?

no the kernel was dead...

Do you know why the kernel was dead?

well in IPython console this message appears and the kernel wasn't alive at the time and restarting it clearly states that it died...
However, I wrote this code a little earlier as follows...
if len(sys.argv) != 2:
sys.exit("Usage: txt file needed")
m = solve(sys.argv[1])
but changed it into something else that doesnt involve file handling...
after a while this error starts to appear...

After reviewing this thread that spyder-bot indicated was a duplicate of my #12900, I recalled that when I first loaded Spyder today (fresh install in a new venv, also; started via Anaconda) the kernel did not start, I had some kind of waiting error that I didn't take much note of (using "restart kernel" in the dropdown resolved it). After doing that, I had closed spyder and reopened it manually from command line with my new venv active, trying to determine if the fresh install in a different venv should load the files I had active in my previous venv or not (apparently it does).
Didn't know whether this might be relevant information so I figured I should include it.


Paper color

I prefer darkmode and it looks like the background is implemented, outside of:
<Color (editor-paper)>Paper</Color>
being included in settings.js around line 54. I wasn't sure if this was unintentional, but it appears to work well on Windows. Great tool by the way!

I think you have the wrong repo. No js files in this one.