Printing errors with an empty highlight span panics.

thread 'single_line_highlight' panicked at 'attempt to subtract with overflow', .../miette/src/printer/graphical_printer.rs:388:29

I can reproduce this with the existing test suite by changing the 4 to 0 here: https://github.com/zkat/miette/blob/7e76e2dea4adf0e4a1349e049495c1f5a0bdab87/tests/printer.rs#L44

I can make a run at fixing this, if you can weigh in with what the behaviour should be in this case. Clamping the length to at least 1 when rendering seems like a straightforward solution, if that works for you.

Yeah, whatever works! I've been abusing .saturating_sub() to avoid all sorts of weird off-by-ones, so maybe that's a good alternative here? Nice catch! And yeah, a PR is super welcome! :)

Sound great.
I tried the saturating sub, but letting it go to zero width looks odd:
────[oops::my::bad]────────────────────

    × oops!

   ╭───[bad_file.rs:1:1] This is the part that broke:
 1 │ source
 2 │   text
   ·
   ·   ╰─ this bit here
 3 │     here

    ‽ try doing it better next time?

This is what it looks like if I clamp with the width to at least 1:
────[oops::my::bad]────────────────────

    × oops!

   ╭───[bad_file.rs:1:1] This is the part that broke:
 1 │ source
 2 │   text
   ·   ┬
   ·   ╰─ this bit here
 3 │     here

    ‽ try doing it better next time?

Hmm. What do you think about using an up-arrow when the width is 0, instead of an underline + clamping?


EJoshuaS - Stand with Ukraine: Watch dhandepost.com

EJoshuaS - Stand with Ukraine requests the watch of the watch_keyword dhandepost\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

dhandepost\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

https://metasmoke.erwaysoftware.com/post/478158

Approved by tripleee in Charcoal HQ


Made errors in hook unit tests easier to debug

Also, removed some assertions that were not working under concurrent test runs

NetflixOSS » Hystrix » Hystrix-pull-requests #401 SUCCESS
This pull request looks good


ARM64 Image

Hi :)
Would you consider releasing arm64 based images? The existing on is amd64 only :(
Thanks!

Hi @manifestori, I can see macos-arm64 under releases. Are you asking for arm64 container image? Any examples you could share if that is the case?
https://github.com/CycloneDX/cdxgen/releases/download/v8.1.7/cdxgen-dist.zip

Yeah, I meant a docker for arm64; I run cdxgen in docker in docker setup and can't run it natively.

Cool. Any help in terms of other oss repos with a working workflow would be appreciated. I still have an old intel machine so do not have a way of building or testing this. My previous attempt to build using Azure Pipelines wasn't very successful.

@manifestori Turned out to be easier to configure. Could you try pulling the latest image and let me know how it looks?


Reimplement cupy.squeeze for increased NumPy compatibility.

Rel #1742. This PR reimplements cupy.squeeze to increase its compatibility to numpy.squeeze.
The latest cupy.squeeze has the following incompatibility to numpy.squeeze:

Raises RuntimeError when the dimension specified with axis is not one, numpy.squeeze raises ValueError
Does not work when axis is a tuple and is not sorted in ascending order
Does not work with negative indices

The new implementation of cupy.squeeze fairly follows that of numpy.squeeze:

numpy/core/src/multiarray/methods.c#L213
numpy/core/src/multiarray/conversion_utils.c#L241
numpy/core/src/multiarray/shape.c#L533
numpy/core/src/multiarray/shape.c#L585

and its test:

numpy/core/tests/test_multiarray.py#L1174

The PR's cython code is manually confirmed to produce C++ code with less boxing/unboxing as possible.

I've fixed for the comments!

LGTM


Question: Generic and Param based Custom Type Methods Support

Hello,
Thanks for the awesome work.
I'm using your lib to write json configurable rules. I want to used generic and param based custom type methods as Utility methods. Below is a sample json config snippet.
{"expression": "Utilities.ConvertToArray(\"xyz\",\"abc\")"}
and below is the method with param
 public static string[] ConvertToArray(params string[] values)
        {
            if (values == null)
            {
                return new string[0];
            }

            return values.ToArray();
        }

When I try to call DynamicExpressionParser.ParseLambda method with above expression it fails with an error saying "No method called ConvertToArray found in Utilities". Please not normal method without param works just fine.
I want to create an array but since that was not possible in the expression directly using your lib I tried using the Utility method.
Similarly, generic methods also doesn't work.
Please help in providing a solution.
Thanks

Thanks @StefH for the reply.
If I use your example of Class X the solution works but if I try to use y example I still get and error "System.Linq.Dynamic.Core.Exceptions.ParseException: 'No applicable method 'ConvertToArray' exists in type 'Utils''
"
In you example, Values prop is already a string array but what I am trying to do is pass string param and get the array back. Show below
Utility class
[DynamicLinqType]
   public static class Utils
   {
       public static string[] ConvertToArray(params string[] values)
       {
           if (values == null)
           {
               return new string[0];
           }

           return values.ToArray();
       }
   }

Usage

  var externals = new Dictionary<string, object>
            {
                {"Users", false},
                {"x", new[] { "a", "b", "c" } },
                {"y", 2},
            };

            string query = "Utils.ConvertToArray(\"a\",\"b\")";
            LambdaExpression expression = DynamicExpressionParser.ParseLambda(null, query, externals);
            Delegate del = expression.Compile();
            var result = del.DynamicInvoke();

Please tell how this issue can be resolved.
Thanks! in advance.

I think the params is not supported, so you can only use string[] values or string value.
Maybe you could just use object value and determine if it's an string or string-array yourself?
But I think that passing \"a\",\"b\" will be detected as 2 separate parameters, and not a params-string-array.

ok, Thanks.
For now I'm thinking to write overloaded methods to return string[], it should suffice for limited set of values.
public static string[] ConvertToArray(string value1, string value2)
public static string[] ConvertToArray(string value1, string value2, string value3)
public static string[] ConvertToArray(string value1, string value2, string value3, string value4)
public static string[] ConvertToArray(string value1, string value2, string value3, string value4, string value5)

Thanks

Hello @joshidp ,
Thank @StefH  for pointing us out the DynamicLinqType, we were not aware of it and seem to be very useful for plenty of scenarios.
The v1.1.3 has been released. The library should now support params parameter (You can pass it like in your example but cannot yet create an array such as new string[] { "a", "b" }).
Let us know if everything works as expected.

@JonathanMagnan
I think that the original method from @joshidp is still not recognized?
public static string[] ConvertToArray(params string[] values)
        {
            if (values == null)
            {
                return new string[0];
            }

            return values.ToArray();
        }

With
public class X
{
  public string[] Values { get; set; }
}

var list = new[] { new X { }, new X { Values = new[] { "a", "b" } } }.AsQueryable();
var result = list.Select(config, "Utils.ConvertToArray(Values)").ToDynamicList<string[]>();

Still throws:

Unhandled Exception: System.Linq.Dynamic.Core.Exceptions.ParseException: No applicable method 'ConvertToArray' exists in type 'Utils'

You are right, we forget probably the most essential case!
The v1.1.5 has been released

@StefH @JonathanMagnan
Hi team, this library is really powerful and I'm really appreciate your awesome work and support. Discussion within this issue has helped me to figure out how to define own custom static function and apply it in dynamic linq to object. However, I am wondering if there is a way we can apply C# extension function.

Hello @JimmyLzy ,
When you say C# extension function, you mean C# extension method right?
Unless I'm wrong, extension methods are not yet supported.
We will look if that's possible or not to support basic scenario at least.

What do you mean @JimmyLzy  by works fine in local.
Unless I'm wrong, the library doesn't support yet extension methods when I checked yesterday.

@JonathanMagnan I meant running code in my windows laptop

@JonathanMagnan  I managed to get more exception message Expression expected (at index 41).

Hello @JimmyLzy ,
Just to let you know that a first version to support the extension method has been made.
We are currently completing the testing phase and a new version should be available within a few days.

Hello @JimmyLzy ,
The v1.1.6 has been released which should now support extension methods.
See those unit tests example: https://github.com/zzzprojects/System.Linq.Dynamic.Core/blob/master/test/System.Linq.Dynamic.Core.Tests/Parser/DynamicLinqTypeTest.cs#L30
Let me know if everything works as expected.

@JonathanMagnan i think it does not work, if extension uses generics.

You are right @Feroks ,
We did it very basic for the first version. We support some simple scenarios.
I'm currently not sure if we wish to go further and support more scenario or redirect people to our other library C# Eval Expression which handle more complex overload resolution.
If you wish we try it, create a new issue with an example of a method and I will ask my developer to look at it. I believe it could be possible to handle one generic parameter (which is more than enough for a lot of cases) but supporting multiple generic parameters would be too long for now.


Replace "npm ls" in CheckNativeDep.js

In CheckNativeDep.js npm ls is used to find dependencies of native packages.
Unfortunately, npm ls fails as soon as there are unmet peer dependencies (see here).
I'd suggest replacing the command and checking the dependencies programmatically. If you agree I can give it a try and send a PR.

I agree! A PR would be awesome


Support alternative config formats

js and ts should be supported.

Done in https://github.com/dethcrypto/eth-sdk/pull/33


Extra HTML attributes management in Matomo module

I think that StatCan.OrchardCore.Matomo module should allow us to add extra HTML attributes to Matomo scripts.
It is useful for manual marking up of consent management platform, like Cookiebot and Iubenda (see the below links).
https://support.cookiebot.com/hc/en-us/articles/4405978132242-Manual-Markup-Guide
https://www.iubenda.com/en/help/1229-manual-tagging-blocking-cookies
Please let me know what you think about it, so I will develop the feature.

Hello, thanks for opening this issue. I recently changed jobs and am no longer maintaining this project. I might fork it and maintain a copy at some point but have little time currently.
Not sure if someone that works at StatCan can answer. @arnaudroystatcan ?

Hello, thanks for opening this issue. I recently changed jobs and am no longer maintaining this project. I might fork it and maintain a copy at some point but have little time currently.
Not sure if someone that works at StatCan can answer. @arnaudroystatcan ?

OK


Enable Copy/Paste for Gradient Fields

Thanks for the asset it works perfect.
I realized right click -> copy on gradient fields didn't work.
I'm not sure what GradientUsage(true) does but it disables right click on gradients.
Removed it and it worked!
https://github.com/mitay-walle/com.mitay-walle.gradient-texture/assets/3739536/6033a9a7-02a6-4ae5-958b-478d83c85cda

Thank you for a feedback. This Attribute allow select HDR colors in gradients. https://docs.unity3d.com/ScriptReference/GradientUsageAttribute-hdr.html
Of course it better to be optional. But I've tried to not over complicate inspector script (preview is exception).
Copy/paste support at this case fully on Unity-developers side, unfortunately.
Glad that you find solution for your case
😄
about pull request:
Some people can use this asset with direct git dependecy, so disabling hdr can corrupt their data.
Split this by versions can help safely support before/after states, but someone still can lose HDR-values if migrate with mistakes. So to behave consistant, I wouldn't merge it.
Better Unity implement copy/paste on GradientUsageAttribute + HDR-gradient. May be already with newer versions?
Thanks for participance! Good luck with your development

Thanks for the explanation. I disabled that in my code as I don’t need hdr for my project and shared as PR if anyone needs.
Yes, I agree that this is on unity :)


I am using photoAndVideo and multiple selectable settings. I want to be able to select only photos and only videos.How can i do

I ask a question for the first time.
First, I'm sorry if I make a mistake.
I am  planning to select multiple items such as config.library.maxNumberOfItems = 3.
But if you select a photo, you don't want to let the video select.
If you select a video, you don't want to let the photo select.
It may be possible to judge MediaType with the DidSelect method of CollectionView in YPLibraryVC + CollectionView.swift and process alerts and non-selection based on the judgment.
But I don't know after that.
I hope someone will support me.
thank you.
※　I had a similar question, but I don't know if it's solved.
・How does YPImagePicker set it to not be able to select both video and image at the same time #431
・How to disable multiple selection if video item is being selected? #486

Did you see ?
/// Choose what media types are available in the library. Defaults to `.photo`
    public var mediaType = YPlibraryMediaType.photo

@keiitix I'm afraid the feature you're describing does not exist.
Also, such a feature might look odd UX-wise, as after selection the first video, all pictures would disappear from the library screen.I think UX wise you might be better of solving that by having two buttons prior to showing the picker: "Choose videos" & "Choose photos" and customise each picker accordingly.
Hope this helps ( and congrats for your first question 👏 ) !


Position of Dark Mode icon

Describe the bug
In the project and contact section the dark mode icon is not placed properly

I can work on this under LGMSOC'21

go ahead @Diksha02 .

Hey @Ankita297, can you guide me where is it supposed to appear. As of right now it appears as shown below.

The dark mode icon has to be in top right corner.

The dark mode icon has to be in top right corner. Try zooming in and out. You'll realize the mistake.

Oh I see it now, thanks


Unable to change the coordinates in the list

Currently in ArcMap a user cannot change the coordinate type in the list:

This works in ArcGIS Pro, but not in ArcMap

Tested with build 1535 and coordinates do change in the batch conversion list. Please verify.

I have verified this on build 05-31-2017_1535.


217 | Contains Duplicate | Python

Title - 217 Contains Duplicate
What will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] Python

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

can you please assign me this?


GPIO

Good evening！ Could you share the code of GPIO? I encountered some unsolvable problems.

Try using this https://pypi.org/project/gpiozero/


View general info about manifest in separate dialog

Opens a dialog with info about the manifest with an "Ok" button to make it dissapear. It may also be preferable to display errors in this manner as well.
Information displayed should be similar to calling c2patool --info.

The information will be provided in #3


allow to view mmapped files

please use mmap via https://doc.qt.io/qt-5/qfiledevice.html#map to open files, instead of copying the data into memory

It can be implemented as backend

Hi
I agree one can add a new implementation of QHexBuffer and handle this (and other cases), but these is one issue: the QHexDocument constructor is private, which means the only way to pass a custom QHexBuffer is via one of the templated fromXXX functions in QHexDocument.
So, if one had a really special QHexBuffer backed by some custom data structure that does not fit in one of the fromXXX function, he could still create it but would not be able to pass it to the QHexDocument.

I can add a generic QHexDocument::fromBuffer() function that accepts a generic QHexBuffer* instance and it takes the ownership


incorrect and inconsistent ValueDeclaration.setter on JVM & JS

The docs for ValueDeclaration.setter state:

For modelling purposes variable reference values have a SetterDeclaration even though there is no such setter explicit in the source code.

So I would expect output of false false true true for:
shared class Model() {
    shared String constantProperty = "";
    shared String computedProperty => "";

    shared variable String variableProperty = "";
    shared String assignableComputedProperty => "";
    assign assignableComputedProperty {}
}

shared void testAssignability() {
    print(`Model.constantProperty`.declaration.setter exists);
    print(`Model.computedProperty`.declaration.setter exists);

    print(`Model.variableProperty`.declaration.setter exists);
    print(`Model.assignableComputedProperty`.declaration.setter exists);
}

Instead, on the JVM, I get:
false
false
false
true

and for JS:
true
true
true
true

@tombentley any memory of this?

No memory, I'm afraid. I think the JS output is definitely wrong and need fixing.
IIRC we now have ReferenceDeclaration, which means the metamodels of references are now more distinguishable from those of getters/setters. I guess we should stick to the model though, and set the setter should exist for a variable reference.

In fact, the docs are wrong and there's no setter unless the declaration (typechecker model, also respected by model loader) really has a setter (must be variable and transient). So I will fix the docs and let @chochos fix the JS.

Fixed it, and my first metamodel fix for JS :)

I'm so glad two human beings on this Earth have worked on that thing now.


"pdf: rename  .~qpdf-orig#: No such file or directory"

I'm trying to do  qpdf --empty --pages input.pdf 1 -- --replace-input. However, I get pdf: rename  .~qpdf-orig#: No such file or directory. It should be trying to get .~qpdf-temp#. Version 10.6.3.

--replace-input doesn't make sense with --empty. It would be better if qpdf just disallowed that combination of options. Are you trying to report that problem, or are you expecting this combination of options to do something?

I expected it to work. Why does that combination make no sense.

qpdf --help=--empty

Use in place of infile for an empty input. Especially useful
with --pages.

For detailed help, visit the qpdf manual: https://qpdf.readthedocs.io

qpdf --help=--replace-input

Use in place of outfile to overwrite the input file with the output.

For detailed help, visit the qpdf manual: https://qpdf.readthedocs.io

So one parameter says 'There is no input file.' and the other says 'Use the input file as the output file.'; Do you see now why they don't really fit well together?

Interesting: I just used the qpdf --empty --pages in.pdf paradigm without understanding why. Using qpdf in.pdf --pages . works. Maybe make it os that --pages doesn't need an additional input-file, and just use in.pdf?

Maybe make it os that --pages doesn't need an additional input-file, and just use in.pdf?

That's with . is for, which you used.

Please leave this open so I can fix the CLI parsing.

That's with . is for, which you used.
Yeah, but I meant that you shouldn't need to add ., but takes in.pdf. Why is there even an option to have another input at all?

Because you can use --pages to take pages from multiple files. I think you probably haven't looked at the documentation very carefully. There are plenty of examples of using --pages.

Suppose you have an existing file called revise.pdf and you want to use all pages(or some of the pages) of it and combine it with pages from different pdfs(say pages 1-2 of file.pdf) and you also want to replace revise.pdf with the newly formed pdf then the way to do that is:
qpdf revise.pdf --pages revise.pdf file.pdf 1-2 -- --replace-input
You have to place the replaceable file at the earlier --empty input.


GSB: Add some more assertions

These now all pass with the other fixes I landed previously.

@swift-ci Please smoke test

@swift-ci Please test source compatibility


Use sortperm instead of sorting players

This PR removes sorted_players in place of using sortperm, since this is type stable

bors r+


Build for nuttx problem, undefined reference to 'setjmp' and 'longjmp'

With latest JerryScript, cannot build for nuttx cause of
jerry-core/parser/js/parser.cpp:2917: undefined reference to `setjmp'
jerry-core/parser/js/syntax-errors.cpp:67: undefined reference to `longjmp'

How to reproduce: with iotjs build for nuttx.
Please refer https://github.com/Samsung/iotjs/wiki/Build-for-NuttX page.

@seanshpark, thank you for clarification of compiler options.
Could you, please, check size of jmp_buf buffer, used for storage of registers?
If jmp_buf size is enough for all registers, maybe, issue is not directly related to setjmp / longjmp. Could you, please, describe how to reproduce the failure? I'll try to figure out what is the cause.

BTW, can you please describe how's your build and test environment?
In pre-commit testing archive libraries are built, but linkage is not performed. So, pre-commit testing passes successfully.

@ruben-ayrapetyan , I'm not sure how to check jmp_buf size. if I search the code, I get
typedef uint64_t jmp_buf[12];

How to reproduce;

get iotjs gpio development branch from my repo.

git checkout -b seanshpark-gpio master
git pull https://github.com/seanshpark/iotjs.git gpio

get latest nuttx patch (I've uploaded it today), as you know it's described in https://github.com/Samsung/iotjs/wiki/Build-for-NuttX
please build debug version. release won't show any message
test sample application is now somewhat ready but not quite done so I've added to iotjs-app repo.
copy blinkled folder to sd-card
insert sd-card to STM32 BB board
run iojs with led.js
memory is critical factor.

jerry heap is set to 80K and led.js uses about 72K.
CCM RAM is also used for BSS so that 80K heap can be possible.
iotjs stack is about 20K and if less than that, parser won't work
system heap is almost at the limit so if few more k-bytes are used then iotjs won't work.

one more thing, file path for set_jmp is
nuttx/configs/stm32f4discovery/src/stm32_jerry-hf.S

@ruben-ayrapetyan ,
I'm don't know how to measure `jmp_buf. what I see from the source is
typedef uint64_t jmp_buf[12];

How to reproduce;

get latest iot.js
build for nuttx, follow https://github.com/Samsung/iotjs/wiki/Build-for-NuttX in debug version
edit nuttx/configs/stm32f4discovery/src/stm32_jerry-hf.S file so to enable vstm and vldm
build nuttx, flast to stm board
run very simple code, such as

console.log("hello world");

p.s. I've just deleted last message. how to reproduce was not correct.

@seanshpark,
size of the typedef uint64_t jmp_buf[12]; buffer is 96 bytes that is not enough, because, actually, there are 10 * 4 + 16 * 4 = 104 bytes stored. Maybe, it is the cause of the issue.

@ruben-ayrapetyan , I've changed it to typedef uint64_t jmp_buf[14]; and still same error.
but it was the sequence of push and pop. below code works.
        .global setjmp
        .type setjmp, %function
        .syntax unified
        .thumb
        .thumb_func
setjmp:
        /* Save registers in jump buffer.  */
        vstm    r0!, {s16 - s31}
        sub     r0, r0, #64     // + 16 * 4 = 64 bytes
        stmia   r0!, {r4, r5, r6, r7}
        mov     r1, r8
        mov     r2, r9
        mov     r3, r10
        mov     r4, fp
        mov     r5, sp
        mov     r6, lr
        stmia   r0!, {r1, r2, r3, r4, r5, r6}
        sub     r0, r0, #40
        /* Restore callee-saved low regs.  */
        ldmia   r0!, {r4, r5, r6, r7}
        /* Return zero.  */
        mov     r0, #0
        bx      lr
        .size setjmp, . - setjmp

        .global longjmp
        .type longjmp, %function
        .syntax unified
        .thumb
        .thumb_func
longjmp:
        /* Restore High regs.  */
        vldm    r0!, {s16 - s31}
        add     r0, r0, #16
        ldmia   r0!, {r2, r3, r4, r5, r6}
        mov     r8, r2
        mov     r9, r3
        mov     r10, r4
        mov     fp, r5
        mov     sp, r6
        ldmia   r0!, {r3} /* lr */
        /* Restore low regs.  */
        sub     r0, r0, #40
        ldmia   r0!, {r4, r5, r6, r7}
        vstm    r0!, {s16 - s31}
        sub     r0, r0, #64     // + 16 * 4 = 64 bytes
        /* Return the result argument, or 1 if it is zero.  */
        mov     r0, r1
        bne     1f
        mov     r0, #1
1:
        bx      r3
        .size longjmp, . - longjmp

the sequence in jerry-libc is opposite. have you checked with target board?
I'll make a small PR for [12] to [14].

@ruben-ayrapetyan , I've changed it to typedef uint64_t jmp_buf[14]; and still same error.
but it was the sequence of push and pop. below code works.

@seanshpark, the jmp_buf should be defined in setjmp.h in nuttx/nuttx/include folder.

Seems that code below writes {s16 - s31} and then overwrites them with {r4, r5, r6, r7}.
So, because of the changes, maybe it doesn't overflow jmp_buf, but maybe context wouldn't be restored successfully with the code:
     /* Save registers in jump buffer.  */
        vstm    r0!, {s16 - s31}
        sub     r0, r0, #64     // + 16 * 4 = 64 bytes
        stmia   r0!, {r4, r5, r6, r7}

A test that leads to call of longjmp is a test that raises SyntaxError.
For example:
try
{
  eval ('var var;');
  assert (false);
}
catch (e)
{
 assert (e instanceof SyntaxError);
}

@ruben-ayrapetyan
I fixed some mistake and the last code is
        .global setjmp
        .type setjmp, %function
        .syntax unified
        .thumb
        .thumb_func
setjmp:
        // Save registers in jump buffer.
        vstm    r0!, {s16 - s31}
        sub     r0, r0, #64     // + 16 * 4 = 64 bytes
        stmia   r0!, {r4, r5, r6, r7}
        mov     r1, r8
        mov     r2, r9
        mov     r3, r10
        mov     r4, fp
        mov     r5, sp
        mov     r6, lr
        stmia   r0!, {r1, r2, r3, r4, r5, r6}
        sub     r0, r0, #40
        // Restore callee-saved low regs.
        ldmia   r0!, {r4, r5, r6, r7}
        // Return zero.
        mov     r0, #0
        bx      lr
        .size setjmp, . - setjmp

        .global longjmp
        .type longjmp, %function
        .syntax unified
        .thumb
        .thumb_func
longjmp:
        // Restore High regs.
        add     r0, r0, #16
        ldmia   r0!, {r2, r3, r4, r5, r6}
        mov     r8, r2
        mov     r9, r3
        mov     r10, r4
        mov     fp, r5
        mov     sp, r6
        ldmia   r0!, {r3} // lr
        // Restore low regs.
        sub     r0, r0, #40
        ldmia   r0!, {r4, r5, r6, r7}
        vldm    r0!, {s16 - s31}
        sub     r0, r0, #64     // + 16 * 4 = 64 bytes
        // Return the result argument, or 1 if it is zero.
        mov     r0, r1
        bne     1f
        mov     r0, #1
1:
        bx      r3
        .size longjmp, . - longjmp

can you please fix the code so that it works ?

can you please fix the code so that it works ?

@seanshpark, I would gladly do this, but before this I should finish some activities. I'll do this as soon as possible.

@seanshpark, I think that code from https://github.com/Samsung/jerryscript/issues/231#issuecomment-116652062 should work if buffer size is enough.

@ruben-ayrapetyan , thank you very much. I'll try with adding setjmp.h in nuttx include with the code #231 tomorrow morning.

It works with https://github.com/Samsung/jerryscript/issues/231#issuecomment-116652062 !

@seanshpark, it's great!

I think this issue can be closed cause changes are for nuttx and added to 20150706 patch


Sample Code yields to a tiny container

See screenshot. Something is wrong with the CSS

This is the _index.html of the Blazor WebAssembly project (.NET 5.0, VS 2019)
I attached the index.html (renamed to index.txt).
index.txt
I did follow your instructions  - but something seems to be broken.

Try updating your app.css file to match the contents from the sample app in the github repo
https://raw.githubusercontent.com/serdarciplak/BlazorMonaco/master/SampleApp/wwwroot/css/app.css

This is a dupe of #24.
There's a div which wraps the editor that you have styling control over.
.monaco-editor-container { height: 100% }
Put this in your root app.css file for it to take effect.  If you're using css isolation I've had issues.

I have tried the solutions in #24 as well as in this item, but it doesn't work for me.
Created the same page as the sample page in my own solution. change the settings. but it keeps rendering it at 5px.
Everything else is working, by changing all the 5px heights and looking at the console.
any other options I can try?

I've the same problem. Anyone got any solution? Please help.

I've the same problem. Anyone got any solution? Please help.
Here's how I've fixed the issue:

<MonacoEditor Id="codeEditor" @ref="_editor" CssClass="monaco-editor-container" ConstructionOptions="EditorConstructionOptions" OnDidInit="EditorOnDidInit" OnContextMenu="OnContextMenu" />

<style>
    .monaco-editor-container {
    height: 300px;
    border: 1px solid gray;
}
</style>

Please see the note at the bottom of this README section : https://github.com/serdarciplak/BlazorMonaco#css-styling

I will as of this date and time of this reply here post what IS and WILL work in case anyone does have any issues with it showing up squishy instead of the height being appropriatly shown as the code intended to be:
Editor.tsx:
"use client";

import MonacoEditor from '@monaco-editor/react';

interface EditorPanelProps {
  language: string;
  code: string;
  setCode: (value: string) => void;
}

export default function EditorPanel({ language, code, setCode }: EditorPanelProps) {
  return (
    <div className="monaco-editor-container">
      <MonacoEditor
        height="100%"
        language={language}
        theme="vs-dark"
        value={code}
        onChange={(value) => setCode(value || '')}
        options={{
          minimap: { enabled: true },
          scrollbar: { vertical: 'hidden', horizontal: 'auto' },
          fontSize: 14,
        }}
      />
    </div>
  );
}

Of course, Im using @Tailwind because... wtf not. However you can use a regular style sheet, however you need to make sure something like this is added to your stylesheet:
globals.css:
@tailwind base;
@tailwind components;
@tailwind utilities;
/* Custom Global Styles */
html, body {
@apply bg-white text-gray-900 dark:bg-gray-900 dark:text-white;
height: 100%;
margin: 0;
overflow: hidden;
font-family: 'Inter', sans-serif;
}
#root, #__next {
height: 100%;
}
.monaco-editor-container {
  height: 500px;
  border: 1px solid gray;
}

And yes. I know that I did not code the first few lines of the globals.css, thats because the only important thing there I wanted to show that works is what IS in the ``` code.


Move  out from ErrorListItem component.

Summary | Résumé
Closes #668
When an error list was appearing, there was a warning in the console, indicating that Each child in a list should have a unique "key" prop.
Moving the key attribute directly into the  tag solves this.
This fix doesn't change any functionality or UI.
Test instructions | Instructions pour tester la modification

Load a form with required fields
Submit a blank form, generating a list of errors at the top of the page
Check the console to ensure the warning no longer appears
Testing against a previous branch will show the warning message

Pull Request Checklist
Please complete the following items in the checklist before you request a review:

[x] Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
[x] The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
[ ] If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
[x] Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
[ ] Does your code have adequate comprehensible comments? Do new functions have docstrings?
[ ] Have you modified the change log and updated any relevant documentation?
[x] Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
[ ] If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Thanks @timarney! I hadn't realized I could put the key on the component tag itself. Looks beautiful now!


feat: added Rene's Mastodon

I added my mastodon account. For some reason, a lot of other lines also suddenly changed, which might be due to my formatter, I believe it's a newline issue with mixed newlines (windows vs. mac)

@fharper I completely blanked here, thanks! I changed the PR and updated the script to support Mastodon, and fixed a trailing comma issue for socials.

Thanks for adding Mastodon, and fixing the rendering issue.


Read another issue where TOCO doesnt work for 1.8, I guess the issue is still not resolved for 1.9
Works fine with 1.7 though.

Same here if changed --input_files to --graph_def_files then it just shows error:

Try this one
toco
--graph_def_file=tf_files/retrained_graph.pb
--output_file=tf_files/optimized_graph.lite
--output_format=TFLITE
--input_shape=1,${IMAGE_SIZE},${IMAGE_SIZE},3
--input_array=input
--output_array=final_result
--inference_type=FLOAT
--inference_input_type=FLOAT

It works for me @tigrandev
Actually, for Tensorflow 1.9 you are supposed to change the --input_file to graph_def_file and not include the --input_format=TENSORFLOW_GRAPHDEF
But It is not updated in the  Codelabs's TFLite Tutorial

@PoojaB26 You can close the Issue if you want.

@Sagarsharma4244 I'll try it out, thanks.

@tigrandev what is the value  of input_shape


Compatible with web

NOw with flutter 2 the web is and readable version, is there any development to add compatibility with the web?

I'm welcome the pull request 👀


NLB-2508: use standard plan

Cannot be merged until GA day when the new plan will be available.
There will also be a delay in the terraform release, the new sku may not be valid until we get an updated terraform.

Can you add the standard plan to the SDK snippets as well?


[TypeScript Resolvers] Resolvers returned data type cannot be introspected

Describe the bug
Cannot introspect resolvers returned data
To Reproduce
Steps to reproduce the behavior:
Clone repository:
git clone -b graphql-ts https://github.com/swcarlosrj/SpaceX-API.git
Install deps & start server:
yarn && yarn start
Generate types:
yarn generate
Introspect src/schema/capsule/resolvers.ts resolvers returned data
Expected behavior
This would be the desired behaviour, it's not even real because I've hardcoded
QueryResolvers.CapsulesResolver
from
CapsulesResolver<...> = (Resolver<R, Parent, Context, CapsulesArgs>
to
CapsulesResolver<...> = Promise<Capsule[]>
I believe that it's a TypeScript thing but it'd be incredible if we could have that feature using QueryResolvers.Resolvers as here, does it's even possible?
Environment:
OS: macOS Mojave 10.14.2 (18C54)
Codegen: 0.15.2
Node: 10.10.0
Additional context
It looks like that when you check the returned data type, it's well formed (in this case Capsule[]) but I cannot see in VSCode the fields of my type/interface as here

So what you want to have is a Return Type of a resolver?
Turning that:
namespace QueryResolvers {
  export type CapsuleResolver = Resolver<R,...>;
}

into:
namespace QueryResolvers {
  export type CapsuleResolver = Resolver<R,...>;

  export type CapsuleResult = Capsule;
}

Right?

@kamilkisiela yep although not sure about how it'd should be the written in order to have the ability to introspect the resolver's returned data only using the QueryResolvers.Resolvers. That'd be the ideal case IMO but It could be added manually too!
Resuming, doing this, be able to do this (withouth adding QueryResolvers.CapsulesResolver)

introspect the resolver's returned data only using the QueryResolvers.Resolvers
What do you mean by that, to return data of some shape in the resolver use that shape in a child resolver? Treat TypeScript as the source of truth and not the GraphQL Schema?

@swcarlosrj
QueryResolvers.CapsuleResolvers is a type that represents a resolver and since resolver is a function, the type defines that function. What you want to have is a type that represents the shape of a returned value, which is a different story, in where you loose signatures of arguments, a root value and a context. I don't know why it could be useful.

👍, I though that it was possible to return the shape of a returned value without losing the signatures of arguments, a root value and a context.
The interesting point here is returning the shape of a returned value (in this case, Capsule), TypeScript could check if whatever you're returning matches the shape, which I've just checked it and it's doing it but it doesn't appear in VSCode as here
You can close this issue or tag it as a proposal feature, doesn't make sense put more time on it. Thanks anyways 😄

@swcarlosrj this is how TypeScript works.
When you do this:
type Foo = string;

const query = {
  foo(): Foo /* <-- */ {
  	return 'Foo';
  }
}

TypeScript treats that as a shape of a returned value, not as function's signature.
To have typed arguments and others, you would have to define that signature, otherwise it's any.

That's what I've supposed it. Ah, I'll try that out, having no idea about TS (goal for 2019 😬)


PySide Plot Axis Not Visible

The issue
When running the app with PyQt, it does work correctly. When running with PySide, everything works expect the axis. They are not displayed at all. Even after moving the pot, they are not shown.
(Same issue as reported in https://groups.google.com/forum/#!topic/pyqtgraph/sc_h7ZeKMCo)
Setup:
conda create -n testpyside python=3.4
activate testpyside
conda config --add channels conda-forge
conda install --show-channel-urls pyqtgraph
conda install --show-channel-urls pyside

conda env export
channels:
- conda-forge
- defaults
dependencies:
...
- libxslt=1.1.29=vc10_2
- pyqt=4.11.4=py34_2
- pyqtgraph=0.10.0=py34_0
- pyside=1.2.4=py34_vc10_3
- qt=4.8.7=vc10_6
- python=3.4.5=0

To see the issue and difference, run the following python (pysideissue.py) file:
# fails if we use pyside instead of pyqt4
import PySide
#import PyQt4

from pyqtgraph.Qt import QtGui, QtCore

import numpy as np
import pyqtgraph as pg

#QtGui.QApplication.setGraphicsSystem('raster')
app = QtGui.QApplication([])
mw = QtGui.QMainWindow()
mw.setWindowTitle('pyqtgraph example: PlotWidget')
mw.resize(800,800)
cw = QtGui.QWidget()
mw.setCentralWidget(cw)
l = QtGui.QVBoxLayout()
cw.setLayout(l)

pw = pg.PlotWidget(name='Plot1')  ## giving the plots names allows us to link their axes together
l.addWidget(pw)
pw2 = pg.PlotWidget(name='Plot2')
l.addWidget(pw2)
pw3 = pg.PlotWidget()
l.addWidget(pw3)

mw.show()

## Create an empty plot curve to be filled later, set its pen
p1 = pw.plot()
p1.setPen((200,200,100))

## Add in some extra graphics
rect = QtGui.QGraphicsRectItem(QtCore.QRectF(0, 0, 1, 5e-11))
rect.setPen(QtGui.QPen(QtGui.QColor(100, 200, 100)))
pw.addItem(rect)

pw.setLabel('left', 'Value', units='V')
pw.setLabel('bottom', 'Time', units='s')
pw.setXRange(0, 2)
pw.setYRange(0, 1e-10)

def rand(n):
    data = np.random.random(n)
    data[int(n*0.1):int(n*0.13)] += .5
    data[int(n*0.18)] += 2
    data[int(n*0.1):int(n*0.13)] *= 5
    data[int(n*0.18)] *= 20
    data *= 1e-12
    return data, np.arange(n, n+len(data)) / float(n)

def updateData():
    yd, xd = rand(10000)
    p1.setData(y=yd, x=xd)

## Start a timer to rapidly update the plot in pw
t = QtCore.QTimer()
t.timeout.connect(updateData)
t.start(50)
#updateData()

## Multiple parameterized plots--we can autogenerate averages for these.
for i in range(0, 5):
    for j in range(0, 3):
        yd, xd = rand(10000)
        pw2.plot(y=yd*(j+1), x=xd, params={'iter': i, 'val': j})

## Test large numbers
curve = pw3.plot(np.random.normal(size=100)*1e0, clickable=True)
curve.curve.setClickable(True)
curve.setPen('w')  ## white pen
curve.setShadowPen(pg.mkPen((70,70,30), width=6, cosmetic=True))

def clicked():
    print("curve clicked")
curve.sigClicked.connect(clicked)

lr = pg.LinearRegionItem([1, 30], bounds=[0,100], movable=True)
pw3.addItem(lr)
line = pg.InfiniteLine(angle=90, movable=True)
pw3.addItem(line)
line.setBounds([0,200])

## Start Qt event loop unless running in interactive mode or using pyside.
if __name__ == '__main__':
    import sys
    #pint("imported modules are", sys.modules.keys())
    if 'PyQt4' in sys.modules:
        print("pyqt4 also loaded")
    else:
        print("pyqt4 not loaded")
    if (sys.flags.interactive != 1) or not hasattr(QtCore, 'PYQT_VERSION'):
        QtGui.QApplication.instance().exec_()

How to run the code
# to run it with pyside, just do
python testpyside.py

# the graph should not show any axis

# now to run it with pyqt, uncomment the "import PySide" line from the testpyside.py file
# then run
python testpysdie.py

# now the axis should show up

The working and broken graph example:

Solution
When installing the pyside package from conda-forge (https://github.com/conda/conda-recipes/tree/master/python/pyside), the graph/plot axis are not working. But when downloading and installing pyside from qt(https://download.qt.io/official_releases/pyside/), this version (https://download.qt.io/official_releases/pyside/PySide-1.2.4-cp34-none-win_amd64.whl) using pip install... then the graph is working.
Therefore the issue seems to lie in the way conda-forge is compiling the pyside package. Indeed, the way is not the same,after checking the pyside compilation manuals (https://wiki.qt.io/Building_PySide_on_Windows) and comparing them with the conda-forge recipes.
Possible Solutions

Find out why this build fails copmared to official PySide package or
Use official PySide package as source for this conda recpie or
Use same way as official PySide package to build in this recipe

You forgot to mention this is windows-specific (or at least it works on linux, just tested here with py34, py35).
It's not obvious how the binaries could differ, I compile with the same options on linux and windows except for some path options. In the setup.py of pyside I don't see win32 specifics either apart from path stuff.

It is on Windows 10 64 bit with python 64 bit
On Jan 23, 2017 10:51, "Julien Schueller"<EMAIL_ADDRESS>wrote:

You forgot to mention this is windows-specific (or at least it works on
linux, just tested here with py34, py35).
It's not obvious how the binaries could differ, I compile with the same
options on linux and windows except for some path options. In the setup.py
of pyside I don't see win32 specifics either apart from path stuff.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/conda-forge/pyside-feedstock/issues/15#issuecomment-274443002,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdXU-aKeLE1bqFT2yNaYU5S2xq_4sh3ks5rVHg0gaJpZM4LqzLp
.

could you test python 3.5 ? it's not compiled with the same msvc version

I tested it with python 3.5 and it is working correctly (Both with pyqt and pyside).
Used environemnt
channels: !!python/tuple
- conda-forge
- defaults
dependencies:
- conda-forge::ca-certificates=2016.9.26=0
- conda-forge::certifi=2016.9.26=py35_0
- conda-forge::jpeg=9b=vc14_0
- conda-forge::libiconv=1.14=vc14_4
- conda-forge::libpng=1.6.28=vc14_0
- conda-forge::libtiff=4.0.6=vc14_7
- conda-forge::libxml2=2.9.3=vc14_9
- conda-forge::libxslt=1.1.29=vc14_2
- conda-forge::openssl=1.0.2h=vc14_3
- conda-forge::pip=9.0.1=py35_0
- conda-forge::pyqt=4.11.4=py35_2
- conda-forge::pyqtgraph=0.10.0=py35_0
- conda-forge::pyside=1.2.4=py35_vc14_3
- conda-forge::python=3.5.3=0
- conda-forge::qt=4.8.7=vc14_6
- conda-forge::setuptools=33.1.0=py35_0
- conda-forge::sip=4.18=py35_1
- conda-forge::vc=14=0
- conda-forge::vs2015_runtime=14.0.25420=0
- conda-forge::wheel=0.29.0=py35_0
- conda-forge::wincertstore=0.2=py35_0
- conda-forge::zlib=1.2.11=vc14_0
- mkl=2017.0.1=0
- numpy=1.11.3=py35_0

Just for reference, this were the packages used in the python 3.4. installation where it does not work:
channels: !!python/tuple
- conda-forge
- defaults
dependencies:
- conda-forge::ca-certificates=2016.9.26=0
- conda-forge::certifi=2016.9.26=py34_0
- conda-forge::curl=7.52.1=vc10_0
- conda-forge::cycler=0.10.0=py34_0
- conda-forge::freetype=2.6.3=vc10_1
- conda-forge::hdf4=4.2.12=vc10_0
- conda-forge::hdf5=1.8.17=vc10_8
- conda-forge::jpeg=9b=vc10_0
- conda-forge::libiconv=1.14=vc10_4
- conda-forge::libnetcdf=<IP_ADDRESS>=vc10_2
- conda-forge::libpng=1.6.28=vc10_0
- conda-forge::libtiff=4.0.6=vc10_7
- conda-forge::libxml2=2.9.3=vc10_9
- conda-forge::libxslt=1.1.29=vc10_2
- conda-forge::matplotlib=2.0.0=np111py34_1
- conda-forge::netcdf4=1.2.7=np111py34_0
- conda-forge::openssl=1.0.2h=vc10_3
- conda-forge::pip=9.0.1=py34_0
- conda-forge::pyparsing=2.1.10=py34_0
- conda-forge::pyqt=4.11.4=py34_2
- conda-forge::pyqtgraph=0.10.0=py34_0
- conda-forge::pyside=1.2.4=py34_vc10_3
- conda-forge::python=3.4.5=2
- conda-forge::python-dateutil=2.6.0=py34_0
- conda-forge::pytz=2016.10=py34_0
- conda-forge::qt=4.8.7=vc10_6
- conda-forge::requests=2.12.4=py34_0
- conda-forge::setuptools=32.3.1=py34_0
- conda-forge::sip=4.18=py34_1
- conda-forge::six=1.10.0=py34_1
- conda-forge::vc=10=0
- conda-forge::wheel=0.29.0=py34_0
- conda-forge::wincertstore=0.2=py34_0
- conda-forge::zlib=1.2.8=vc10_3
- mkl=2017.0.1=0
- numpy=1.11.3=py34_0
- scipy=0.18.1=np111py34_1
- vs2010_runtime=10.00.40219.1=2

how come there's some more packages for py34 ?

I think I installed something more. I can do a clean one again...

Here the clean test on py34 and the packages
channels: !!python/tuple
- conda-forge
- defaults
dependencies:
- conda-forge::ca-certificates=2016.9.26=0
- conda-forge::certifi=2016.9.26=py34_0
- conda-forge::jpeg=9b=vc10_0
- conda-forge::libiconv=1.14=vc10_4
- conda-forge::libpng=1.6.28=vc10_0
- conda-forge::libtiff=4.0.6=vc10_7
- conda-forge::libxml2=2.9.3=vc10_9
- conda-forge::libxslt=1.1.29=vc10_2
- conda-forge::openssl=1.0.2h=vc10_3
- conda-forge::pip=9.0.1=py34_0
- conda-forge::pyqt=4.11.4=py34_2
- conda-forge::pyqtgraph=0.10.0=py34_0
- conda-forge::pyside=1.2.4=py34_vc10_3
- conda-forge::python=3.4.5=2
- conda-forge::qt=4.8.7=vc10_6
- conda-forge::setuptools=32.3.1=py34_0
- conda-forge::sip=4.18=py34_1
- conda-forge::vc=10=0
- conda-forge::wheel=0.29.0=py34_0
- conda-forge::wincertstore=0.2=py34_0
- conda-forge::zlib=1.2.8=vc10_3
- mkl=2017.0.1=0
- numpy=1.11.3=py34_0
- vs2010_runtime=10.00.40219.1=2

does it work on py27 ? we're dropping py34 in conda-forge anyways

I don't see the point testing it for py27 if it will be dropped anyways. We just finally decided to mirror the recipes and fix it locally.

py27 will not be dropped right now

hi @plieningerweb, do you mind testing this one last time with py27 as it's still supported ?

clsing as py34 is not supported anymore in conda-forge


llvmPackages: cleanup orphaned files

Description of changes
I wonder why these files weren't gone.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

i think the llvm{8, 10} files were added back to resolve a merge conflict where they should've just been deleted.


Plugin-Version sending Midimessages twice

As far as I know this happens on all plugin versions (Win vst, Mac au, Mac vst). When sending Midimessages by Lua code this bug does not show (it will send messages once). So I guess it must be a bug of the Midi-Component.
Example1, IPR sysexmessage. Moving from value 00 to 06:
[09:52:44:000510]: RAW:[f0 41 39 00 24 30 01 12 00 f7]
[09:52:44:000510]: RAW:[f0 41 39 00 24 30 01 12 00 f7]
[09:52:58:000142]: RAW:[f0 41 39 00 24 30 01 12 01 f7]
[09:52:58:000142]: RAW:[f0 41 39 00 24 30 01 12 01 f7]
[09:52:59:000251]: RAW:[f0 41 39 00 24 30 01 12 02 f7]
[09:52:59:000251]: RAW:[f0 41 39 00 24 30 01 12 02 f7]
[09:52:59:000902]: RAW:[f0 41 39 00 24 30 01 12 03 f7]
[09:52:59:000902]: RAW:[f0 41 39 00 24 30 01 12 03 f7]
[09:53:00:000659]: RAW:[f0 41 39 00 24 30 01 12 04 f7]
[09:53:00:000659]: RAW:[f0 41 39 00 24 30 01 12 04 f7]
[09:53:02:000782]: RAW:[f0 41 39 00 24 30 01 12 05 f7]
[09:53:02:000782]: RAW:[f0 41 39 00 24 30 01 12 05 f7]
[09:53:04:000104]: RAW:[f0 41 39 00 24 30 01 12 06 f7]
[09:53:04:000104]: RAW:[f0 41 39 00 24 30 01 12 06 f7]
Example2, APR sysexmessage. Sent by a Lua script, no doubled messages:
[09:54:52:000798]: RAW:[f0 41 38 00 24 30 01 20 20 4c 4f 57 20 53 54 52 49 4e 47 20 50 41 44 20 20 06 4c 27 26 00 00 00 7f 14 1c 2d 09 00 00 4e 00 02 00 01 00 09 00 00 4c 01 7e 00 01 00 5a 01 1a 00 00 00 f7]
[09:54:52:000798]: RAW:[f0 41 38 00 24 20 01 20 53 54 52 49 4e 47 53 20 31 20 38 05 00 38 32 00 00 40 00 00 40 00 00 7f 7f 00 3c 00 00 00 02 67 69 43 67 00 00 00 00 00 00 00 00 00 00 00 00 7f 00 7f 00 7f 00 29 4b 00 34 58 56 24 48 00 00 00 60 00 60 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 50 50 60 50 50 40 60 40 20 00 20 00 00 00 00 20 00 00 f7]
[09:54:52:000798]: RAW:[f0 41 38 00 24 20 02 4c 4f 20 53 54 52 49 4e 47 53 20 38 05 00 38 48 00 00 40 00 00 40 00 00 7f 7f 00 3c 00 00 00 14 67 7f 43 61 00 00 00 00 00 00 00 00 00 00 00 00 7f 00 7f 00 7f 00 00 46 00 34 58 56 24 48 00 00 00 60 00 60 00 00 00 00 00 00 00 00 00 00 00 00 00 00 20 50 50 60 50 50 40 60 40 20 00 20 00 00 00 00 20 00 00 f7]
Just to show you that this is not a bug of the Midimonitor: Reaper and MidiOX connected through loopMIDI. MidiOX display:
 TIMESTAMP IN PORT STATUS DATA1 DATA2 CHAN NOTE EVENT
 0000E9DA   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 01 F7
 0000E9DA   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 01 F7
 0001043A   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 02 F7
 0001043A   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 02 F7
 00010A84   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 03 F7
 00010A84   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 03 F7
 00010E44   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 04 F7
 00010E44   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 04 F7
 000111AF   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 05 F7
 000111AF   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 05 F7
 000115BA   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 06 F7
 000115BA   9  --     F0  Buffer:    10 Bytes   System Exclusive
 SYSX: F0 41 39 00 24 30 01 12 06 F7

I found out that this only happens when using "output to pluginhost" instead of configuring a midi out port. "output to pluginhost" would be the much better way as it doesnt't lock the port so it stays available in the DAW.

i think i fixed this issue, so the next release build should have it fixed

Isn't this the same issue (or a related one) to https://ctrlr.org/forums/topic/midimessagereceived-executed-2-times/ ?
The issue was for the standalone version and I solved it by resetting the Input devices at panel load and this is working fine (no double execution of MidiMessageReceived for one message and bidi is OK):
-- Reset Midi INPUT devices to avoid having MidiMessageReceived method called twice
-- If resetting Controller devices then the bidirectional behaviour is lost (most probably a bug)
sMidiDevices = panel:getProperty("panelMidiInputDevice")
panel:setPropertyString("panelMidiInputDevice", "-- None")
panel:setPropertyString("panelMidiInputDevice", sMidiDevices)

@Possemo mentioned my fix above working well in standalone didn't solve the issue in the VST version.

No, this is another issue - only happens with vst plugin. There are not a lot of DAW's where "output to pluginhost" is working anyway. Reaper is one of them.

No, this is another issue - only happens with vst plugin. There are not a lot of DAW's where "output to pluginhost" is working anyway. Reaper is one of them.

I have just checked it with the newest ver 6.0.26:
vsti v2 x64 = bug ist still there
vsti v3       = feature does not seem work at all (output to pluginhost)
As Reaper is one of the very few DAW's where this does work halfways I'd suggest to remove it (input from plugin host, input from pluginhost to comparator, output to pluginhost). Also all MIDI-Thru pluginhost related entries.Btw. I have tested it with restricted instances.

I have just checked it with the newest ver 6.0.26:
vsti v2 x64 = bug ist still there
vsti v3       = feature does not seem work at all (output to pluginhost)
As Reaper is one of the very few DAW's where this does work halfways I'd suggest to remove it (input from plugin host, input from pluginhost to comparator, output to pluginhost). Also all MIDI-Thru pluginhost related entries.Btw. I have tested it with restricted instances.

Ok, as I am finally able to build with vs2019 I could see that you are right Roman. With vsti v2.4 this is finally working perfectly, no doubly messages anymore.
It seems that with vsti v3 this is not working, It looks like it does not pass sysex, both input and output. Maybe it is the DAW (Reaper) who does it wrong. There's happening weird things when looking at the output. Instead of sysex it sends all kinds of MIDI events - cc, noteoff, program change... but not sysex as it should.
As this is another issue I am closing this one here.


Feature/star experiment

Changes to the API to allow for starring feature.

Coverage decreased (-0.5%) to 71.286% when pulling ae2c594867f154971a716eef75afa400a6b9b0d8 on feature/star_experiment into 480670a5b504193989873773fe74aa15ee785fe7 on develop.

Coverage decreased (-0.4%) to 71.326% when pulling 6841c1b81bdffc659e9c6a9313c757a1234a568e on feature/star_experiment into 480670a5b504193989873773fe74aa15ee785fe7 on develop.

Coverage decreased (-1.2%) to 70.578% when pulling 2b16b18da0008132c9c25e9538c99308483dfb73 on feature/star_experiment into 480670a5b504193989873773fe74aa15ee785fe7 on develop.

Coverage decreased (-0.9%) to 70.871% when pulling f3efadb94423a6a71fdc732ab89db9b0c7de8ec8 on feature/star_experiment into 480670a5b504193989873773fe74aa15ee785fe7 on develop.

Coverage decreased (-0.6%) to 71.123% when pulling 58dd0b2ba02414c11f672c15265f6fadb6005cf1 on feature/star_experiment into 480670a5b504193989873773fe74aa15ee785fe7 on develop.

Coverage decreased (-0.6%) to 71.193% when pulling e9cbd6109ecbe7e0ea337f635479e2c14ba046d2 on feature/star_experiment into 480670a5b504193989873773fe74aa15ee785fe7 on develop.


Something went wrong

Microsoft PowerToys version
<IP_ADDRESS>
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce

✔ Expected Behavior
No response
❌ Actual Behavior
I tried to open as always and windows show me this message
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19042.0
IntPtr Length: 8
x64: True
Date: 5/24/2021 8:36:34 AM
Exception:
System.ArgumentException: Destination array was not long enough. Check the destination index, length, and the array's lower bounds. (Parameter 'destinationArray')
at System.Array.Copy(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length, Boolean reliable)
at System.Collections.Generic.List`1.System.Collections.ICollection.CopyTo(Array array, Int32 arrayIndex)
at System.Collections.ArrayList.InsertRange(Int32 index, ICollection c)
at System.Collections.ArrayList.AddRange(ICollection c)
at System.Windows.Data.ListCollectionView.b__1_0()
at MS.Internal.Data.SynchronizationInfo.AccessCollection(IEnumerable collection, Action accessMethod, Boolean writeAccess)
at System.Windows.Data.BindingOperations.AccessCollection(IEnumerable collection, Action accessMethod, Boolean writeAccess)
at System.Windows.Data.ListCollectionView.RefreshOverride()
at System.Windows.Data.CollectionView.RefreshInternal()
at System.Windows.Data.CollectionView.PostChange(NotifyCollectionChangedEventArgs args)
at PowerLauncher.ViewModel.MainViewModel.<>c__DisplayClass135_0.b__0()
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
Other Software
No response

Tracking in https://github.com/microsoft/PowerToys/issues/8921.

@callmehanu
When does it happen? When pressing Alt+space? Can you always reproduce it?


Fix balances endpoint ordering

Fixes the ordering of the balance items. The service was ordering by fiatBalance but as this is a string, it was ordering by lexicographic order. Hence, it needs to be converted to number before ordering (as done for the old implementation).
Modifies the associated tests. This sorting was tested, but the quantities used were already sorted in lexicographic order, so the test was adjusted to actually test the sorting.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 91.113%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
3
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
4807

Relevant Lines:
5152

💛  - Coveralls


refactor: Update messages boxes to account for L2 reorgs

@LHerskind to insert a larger description, we have most defined in the disco dingo doc, but can be clarified here a bit simpler than that entire doc. Generally should be fairly easy to address but need to actually have a timeliness requirement and cases where a reorg will happen to test it properly.

Easier to deal with if handled after #7594 and together with #7616 since we can then more easily deal test and actually do a reorg there 👍


Conflict between ng-disabled and promise button

Hello,
During the promise resolution, if ng-disabled value changes to false, then once the promise is resolved, the disabled attribute is always removed (not taking into account the state of ng-disabled).
We made a small fix on our local version:

We added ngDisabled in the directive's scope
We modified handleLoadingFinished to take into account ngDisabled value

So here it is:
function handleLoadingFinished(btnEl) {
    if ((!cfg.minDuration || minDurationTimeoutDone) && promiseDone) {
        if (cfg.btnLoadingClass) {
            btnEl.removeClass(cfg.btnLoadingClass);
        }
        if (cfg.disableBtn && !scope.ngDisabled) {
            btnEl.removeAttr('disabled');
        }
    }
}

AND
return {
    restrict: 'EA',
    priority: angularPromiseButtons.config.priority,
    scope: {
        promiseBtn: '=',
        promiseBtnOptions: '=?',
        ngDisabled: '='
    },
    ...

Could you include this as a feature in you next version of the directive ?
Thank you.

Hey! Thanks for the suggestion. I implemented your fix.


bug: wasm build error

Did you check existing issues?

[X] I have read all the tree-sitter docs if it relates to using the parser
[X] I have searched the existing issues of tree-sitter-php

Tree-Sitter CLI Version, if relevant (output of tree-sitter --version)
tree-sitter 0.22.1 (1c38d34deac5ae7ea797a559f596fb4ec9008eb4)
Describe the bug
run tree-sitter build-wasm ./temp/tree-sitter/php/php
scanner.c:1:10: fatal error: '../../common/scanner.h' file not found
#include "../../common/scanner.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
emcc: error: '/emsdk/upstream/bin/clang -target wasm32-unknown-emscripten -fignore-exceptions -fPIC -mllvm -combiner-global-alias-analysis=false -mllvm -enable-emscripten-sjlj -mllvm -disable-lsr -DEMSCRIPTEN -Werror=implicit-function-declaration --sysroot=/emsdk/upstream/emscripten/cache/sysroot -Xclang -iwithsysroot/include/fakesdl -Xclang -iwithsysroot/include/compat -Os -fno-exceptions -fvisibility=hidden -I. scanner.c -c -o /tmp/emscripten_temp_5w46mjsx/scanner_0.o' failed (returned 1)
emcc command failed

Steps To Reproduce/Bad Parse Tree

tree-sitter build-wasm ./temp/tree-sitter/php/php
throw error

Expected Behavior/Parse Tree
success build
Repro
// Example code that causes the issue
function foo() {
  // Code that fails to parse, or causes an error
}

docker issue w/ upstream, same issue in typescript/xml, I'll close as a dupe of the upstream https://github.com/tree-sitter/tree-sitter/issues/3233


Is it possible to collect state dict in cpu?

When I finish one epoch in trianing, the main_worker function will call ts.collect_state_dict(model, state_dict).
But because the limit of GPU resource, it will raise Out of Memory in my machine, when call ts.collect_state_dict(model, state_dict).
I found that will gather the state_dict in GPU,  is it anyway to gather in CPU?

It is impossible to perform gather operation in cpu because the operation is based on NCCL backend. But there is a way to avoid gathering in GPU on-the-fly, that is to save state_dict of each shard locally and then write a post process script to hub them together. For example, if using 16 GPUs within 16 ranks, save 16 checkpoints during training, like model_state_rank_001.pth, model_state_rank_002.pth, … and model_state_rank_016.pth. After finishing training, write a post process script to gather these 16 checkpoints into one. Pay attention to keep right order for each shard state and run the inference test to check result.

It is impossible to perform gather operation in cpu because the operation is based on NCCL backend. But there is a way to avoid gathering in GPU on-the-fly, that is to save state_dict of each shard locally and then write a post process script to hub them together. For example, if using 16 GPUs within 16 ranks, save 16 checkpoints during training, like model_state_rank_001.pth, model_state_rank_002.pth, … and model_state_rank_016.pth. After finishing training, write a post process script to gather these 16 checkpoints into one. Pay attention to keep right order for each shard state and run the inference test to check result.

It is an excellent solution! Thanks.


Provide correct typings for EntityManager.getContext()

The EntityManager class in the core package defines the getContext() method so that it returns an EntityManager instance without the driver type parameter, which means we lose typing when we call the method on a typed EntityManager such as the one exported from @mikro-orm/postgresql.
| mikro-orm | 5.1.3 |

PR welcome. I guess this is the moment when you tell me again how hard is to contribute, even when its about one line change in a file you know of, like last time, right? :]

Well... how do I put this.
The fix is 3 (literally three) characters.
In order to be able to send a PR, I'd need to:

fork & clone the almost 1GB repository (my hard drive has <10GB free space long term for some reason)
install Yarn, which I don't have & don't need otherwise
install Docker, which I don't have & don't need otherwise
install all the containers the test suite needs (more GB for my poor hard drive)

In other words I'd need to spend several hours just getting the necessary free disk space and then some more on setting up the toolchain before I could even try to compile the project with the three added characters. Then maybe I could send a PR.. my past experience sending PRs to any project was that PRs get almost universally rejected, often for idiotic reasons like code style which can be autofixed. So from my standpoint that seems like a huge investment of time and energy with a very uncertain outcome.

What do you want me to do, not report bugs?

I'm sorry, out of all the open source projects I use I'd like to get involved with MikroORM the most - I absolutely love the project and I think you're doing amazing work and I would really really like to help - but I'm stretched too thin as it is and I have deadlines to meet and only so much time & energy. So when I come across a bug I could just set it aside to work on sometime later, but then it could take weeks or months before I get around to actually doing it. Submitting a bug report might help others pinpoint their own issue in the meantime, or you or somebody else might fix it long before I could. I'm doing the best I can at the moment.

No worries, bug reports are of course welcome, as long as they are clear and easily reproducible, and I do get your points. I was just hoping to see PRs directly for such low hanging fruit, I don't mind fixing it myself.
Btw if you mind the git repo size, clone just the master branch via git clone ... --single-branch, its caused by the gh-pages branch most probably, if you clone just master its 56mb. I know I will need to find a way around this at some point, but you know, I also have other stuff to work on :]


Fix ZookeeperRegistry destroy by DestroyHook invoke error.

Motivation:
从DestroyHook的设计看，应当是调用真实的destroy方法前，先调用DestroyHook的preDestroy方法，再执行destroy。而不是前置调用DestroyHook的postDestroy方法。
Modification:
将前置调用的postDestroy方法替换为preDestroy。
Result:

@tiansxx See Contributing doc, you should run mvn clean compile to make sure your code has been formatted. Thanks!

Codecov Report

Merging #244 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #244      +/-   ##
===========================================
- Coverage     71.65%   71.6%   -0.06%
+ Complexity      963     961       -2
===========================================
  Files           341     341
  Lines         14240   14240
  Branches       2289    2289
===========================================
- Hits          10204   10196       -8
- Misses         2847    2852       +5
- Partials       1189    1192       +3

Impacted Files
Coverage Δ
Complexity Δ

...alipay/sofa/rpc/registry/zk/ZookeeperRegistry.java
61.71% <100%> (-0.4%)
0 <0> (ø)

.../main/java/com/alipay/sofa/rpc/tracer/Tracers.java
42.3% <0%> (-2.57%)
0% <0%> (ø)

...ent/aft/impl/ServiceHorizontalMeasureStrategy.java
84.44% <0%> (-2.23%)
26% <0%> (-1%)

.../sofa/rpc/registry/zk/ZookeeperRegistryHelper.java
75.86% <0%> (-1.38%)
0% <0%> (ø)

...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java
72.22% <0%> (-1.12%)
23% <0%> (-1%)

...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java
85.71% <0%> (+1.78%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d16f0ae...da900d2. Read the comment docs.


Add support for VoiceChannel region overrides

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[x] Library interface (affecting end-user code)
[x] Documentation
[ ] Other: _____

Closes Issue: #1570
Description
This pull request adds support for VoiceChannel region overrides

@MinnDevelopment is there something you'd like me to change?

I think this PR is still missing an event and it should deprecate Guild#getRegion and related features.

@MinnDevelopment I have deprecated Guild#getRegion, Guild#getRegionRaw and GuildManager#setRegion
If you know, if there are more methods involving Guild regions, please let me know.

Here are some more:

GuildAction#setRegion
GuildUpdateRegionEvent (and the overload in ListenerAdapter)

Also, the deprecation should include a @ReplaceWith rather than a @ForRemoval.

Here are some more:

GuildAction#setRegion
GuildUpdateRegionEvent (and the overload in ListenerAdapter)

Also, the deprecation should include a @ReplaceWith rather than a @ForRemoval.

Alright those are now deprecated and i fixed the annotation.
I'll look out for more methods regarding guild regions


Backport slo-monitor dependencies fixes

Backports #1482 and #1483 to unblock cherry-picking to release-1.19 branch.
/assign wojtek-t

/lgtm
/approve


API ID Causing Bans

It seems that the API information on the C# example is banned by telegram and causes accounts to be deleted.  I’ve successfully reproduced this using several burner numbers and each time, within seconds of logging in, the accounts are banned and the numbers blocked.  Using my own API ID/Hash, I can log in and successfully use the library as intended.
Can we remove the hard coded values in each of the examples and just point users to the correct location to generate their own?

There are a lot of factors which together can lead to account ban. Removing the hardcoded API ID can help someone, but some other users will be banned only if they will use their own API ID instead. By using burner numbers you act exactly like a spammer, so it's not surprising that the accounts was banned.
Currently, I want examples to be self-contained, so anyone can launch them without additional steps. But given that some innocent users are banned using examples, we definitely need to add an instruction to the examples on how the account can be restored in case of ban.

@levlam I can assure you that @MarcFreeman is not a spammer.

What about using official API information?  I just tried Android (ID 6) and I don’t get banned.  However, literally every number I’ve tried is being flagged.  It’s not an issue that the numbers are burners.  I first created the account successfully using TDesktop and everything was fine. It’s specifically THIS ID/Hash.

@YouTwitFace I haven't said that @MarcFreeman is a spammer, I've just said that creating new accounts using burner numbers and custom apps is exactly what spammers do, so chances to be blocked are much higher when doing this.
@MarcFreeman I don't want to go deep in details of how antispam system works, but I can ensure you that there are a lot of different factors, which can lead to or prevent an account ban. Most of users can safely use the examples with THIS ID/hash and some other users will not be able to use it with any API ID. Unfortunately, there are spammers, which use modified TDLib examples, so other users of the examples are more prone to ban. Removing the API ID will not help, because antispam system will just adapt and will be able to find and ban suspicious examples users anyway. So, the removal of API ID will just make example usage harder.
Usually antispam system is smart enough to not ban innocent accounts, but in the unlikely event of an innocent account ban the only thing we can do is to instruct users to write to<EMAIL_ADDRESS>for unbanning.

@levlam Why not remove the id and hash and put a link to https://my.telegram.org?

@YouTwitFace

"Currently, I want examples to be self-contained, so anyone can launch them without additional steps."
"Removing the API ID will not help, because antispam system will just adapt."

That's the problem
If you remove the id, there will be nothing to adapt to

Maybe leave a comment saying that there's a risk?

@YouTwitFace

It's not a problem, it's a requirement.
Assumption that spammers could just use unique API ID to be never banned is definitely wrong. The chance of account being banned will stay pretty the same.

@YouTwitFace this is not these specific api/id issue but common tdlib issue
https://github.com/tdlib/td/search?q=ban&type=Issues

Hi! Can an account get a ban for just querying TDLib? I mean if account does not post or upload anything. I am getting some strange reports for my app.

@x2bool If it is logged in, then it is possible.

@levlam Thanks for the quick reply. Is there a list of "do"s and "don't"s for TDLib? I mean you are probably not going to give out the details of your antispam system, but can we get some general description of things to avoid implying that the user is not spamming and in "read-only" mode. Because now i am super-confused about the reasons a user got banned, and I don't even know where to start looking.

Usually users are banned because they accounts looks like autoregistered, so the only "don't" is "don't register fake accounts". Some users can be wrongly classified as autoregistered bots, and their accounts are banned after that. In that case they just need to write to<EMAIL_ADDRESS>Every official client asks users to write to that email, whenever they try to log in back, so all real users supposed to do that and to be restored soon after the accidental ban.

Thanks. I'll ask him whether he registered a new account in my client. That would probably explain it.

I have the same problem. My account has been banned three times now, every time that I try using tdlib. I get a USER_DEACTIVATED_BAN error almost immediately and get disconnected from the Telegram app on my phone. I have a second account which works perfectly fine with the same tdlib code (which isn't posting anything, just observing channels). I'm running this code from a server on the clear (no Tor exit node). I wrote to<EMAIL_ADDRESS>every time and my account got re-activated in less than 24 hours, but no word from them. My account isn't fake or spam, it can easily be verified by email or sms. I would appreciate any tips from someone who struggled with the same issue.

@traderp if you're using the api id and hash from the example, try changing it.

I'm using my own api and hash.

This got squared away. Telegram finally replied to my email at<EMAIL_ADDRESS>and fixed the issue. I guess the solution is to be patient.

Since TDLib 1.5.0 if the account is banned by the server, TDLib will suggest through the log to contact<EMAIL_ADDRESS>That's all that can be done on the TDLib's side.


Add Typed PID Maker UI

[x] implement basic typed pid maker ui

[x] includes common header and config things

[x] attach to main page

Due to the different kind of images, the look is quiet different.

I see the following options:

Let it stay like it is. The card is of the same size, so we currently just take space we have.
At least change the background color (which is the CSS's default) to white or something.
Make all images in the same aspect ratio (with which background color?)

Due to the different kind of images, the look is quiet different.

I see the following options:

Let it stay like it is. The card is of the same size, so we currently just take space we have.
At least change the background color (which is the CSS's default) to white or something.
Make all images in the same aspect ratio (with which background color?)

I personally tend to option 3.

I see the following options:
1. Let it stay like it is. The card is of the same size, so we currently just take space we have.
2. At least change the background color (which is the CSS's default) to white or something.
3. Make all images in the same aspect ratio (with which background color?)

I'm also in favor of the third option.
Do you mean the image background color? I would suggest a transparent background where feasible (i.e. in case of the Typed PID Maker logo). This should work as long as we do not make the website background color too garish.

I'm also in favor of the third option.

Planning to do so :)

Do you mean the image background color? I would suggest a transparent background where feasible (i.e. in case of the Typed PID Maker logo). This should work as long as we do not make the website background color too garish.

I mean the color shown behind the transparent background of the logo. I did not set any, so it is some default, probably by semantic-ui. I can set the color to anything, using CSS. While white looks nice, it also removes the card feeling a little.

This is how it looks like now. Looks fine for me. The gray background is a nice neutral somehow and probably fits for most logos to come. Feel free to merge.

Main page:

First version of the Typed PID Maker UI (better table styling is on the way, not for this PR :) )


Redteam custom plugin (reading from yaml file) no longer working

Describe the bug
Redteam custom plugins which required custom plugin definition in a separate yaml file, no longer seems to work with [0.100.6, 0.99.1] - works with 0.96.1. Haven't tested on others but seems to have broken somewhere between 0.96.1 and 0.99.1
To Reproduce
Create any custom plugin as per steps in the docs - https://www.promptfoo.dev/docs/red-team/plugins/custom/
Relevant screenshot of the custom plugin definition example

Expected behavior
Newer version should run custom defined plugins, unless this feature was removed as planned.
Screenshots
N/A but please see relevant parts of the stdout below:
"message": "Expected string, received object"                   }                 ],                 "name": "ZodError"               }             ],             "path": [               "plugins",               0             ],             "message": "Invalid input"           }         ],         "name": "ZodError"       },       {         "issues": [           {             "received": "file://REDACTED.yaml",             "code": "invalid_enum_value",
System information:
N/A

Promptfoo version: 0.100.6, 0.99.1, possibly others

Additional context
Add any other context about the problem here.

Hi @Doitnowman, thanks for reporting this issue! The problem with custom plugins using a file:// protocol has been addressed in 0.101.2. Please update to this version, and your custom plugin should work as expected.
If the issue persists or you encounter anything else, feel free to reopen this issue or create a new one. Thanks for using Promptfoo!


Console warning

Describe the bug
A compilation warning is shown in the console on startup
To Reproduce
Steps to reproduce the behavior:

npm run storybook
View console

Expected behavior
No warning
Screenshots
./src/Models/Context/index.ts 2:0-137"export 'IDeeplinkContextProviderProps' was not found in './DeeplinkContext/DeeplinkContext.types'./src/Models/Context/index.ts 2:0-137"export 'IPublicDeeplink' was not found in './DeeplinkContext/DeeplinkContext.types'./src/Models/Context/index.ts 6:0-94"export 'ISceneThemeContextProviderProps' was not found in './SceneThemeContext/SceneThemeContext.types'./src/Models/Context/index.ts 8:0-91"export 'ISceneViewContextProviderProps' was not found in './SceneViewContext/SceneViewContext.types'
Browser (please complete the following information):

Browser [e.g. chrome, safari, edge] Edge

Additional context
Add any other context about the problem here.

I'm confused because these exports DO exist....


xChart, Black Screen

Hello,
I'm trying to figure out the basics of xChart Library before I move to write something much more complex. But I'm having troubles to make this basic Library Work. Here is my code and the Output I'm getting on the site. It's bit weird. Can you see any issues here?

    <figure style="width: 400px; height: 300px" id="myChart"></figure>
    <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
    <script src="js/d3.js"></script>
    <script src="js/xcharts.css"></script>
    <script src="js/xcharts.js"></script>
    <script type="text/javascript">
        var data = {
            "xScale": "ordinal",
            "yScale": "linear",
            "type": "bar",
            "main": [
                {
                    "className": ".pizza",
                    "data": [
                        {
                            "x": "Pepperoni",
                            "y": 12
                        },
                        {
                            "x": "Cheese",
                            "y": 8
                        }
                    ]
                }
            ],
            "comp": [
                {
                    "className": ".pizza",
                    "type": "line-dotted",
                    "data": [
                        {
                            "x": "Pepperoni",
                            "y": 10
                        },
                        {
                            "x": "Cheese",
                            "y": 4
                        }
                    ]
                }
            ]
        }
        var myChart = new xChart('bar', data, '#myChart');
    </script>
    <?php
    // put your code here
    ?>
</body>

Thanks.

+1 I had this issue too sometimes


Add option to enable concatenation

You may consider this to be beyond the scope of AssetPack but I think it would be hugely useful to add a concatenation step in the packing process. I've an Angular JS app with many dozens of files and while AssetPack does a great job of ensuring they all get loaded and minified, they're still many dozens of files which require many dozens of requests. Enabling AssetPack to concatenate would remove the need for me to have a separate Gulp stage in my workflow.
Any thoughts?

Hi,
All those multiple assets actually already get merged into a single one *when running in production mode
See The Modes Manual.
If I'm misunderstanding what you mean or you don't get a single file in production mode, please reopen the Issue.
Thanks.

Nope, my mistake, apologies!


Drop python3.8 support

Closes #
Python 3.8 EOL date was 2024-10-07.
See https://github.com/reddit/baseplate.py/pull/824 for prior art, dropping Python 3.7.
💸 TL;DR

Drops Python v3.8 support.
📜 Details
Design Doc
Jira

🧪 Testing Steps / Validation

✅ Checks

[x] CI tests (if present) are passing
[x] Adheres to code style for repo
[ ] Contributor License Agreement (CLA) completed if not a Reddit employee

Looks like updates are consistent with the 3.7 drop and test are 🟢 . Seems reasonable to me, would also like a 👍 from @chriskuehl before merging.

3.7 drop didn't require an updated poetry.lock but CI was failing without it, so I am keen to call that out her

3.7 drop didn't require an updated poetry.lock but CI was failing without it, so I am keen to call that out here

This looks good to me. Needing to update the poetry.lock is expected when you change the pyproject.toml since it contains a hash of the important fields, and also it may need to adjust the package versions if you change dependencies. You can use poetry lock --no-update to do a minimal update (should be fast as it only fixes the stuff it needs to), or poetry lock (which can be slow and pull in a ton of updates).
Worth saying explicitly that poetry.lock does not affect users of Baseplate in any way. It's only used for Baseplate's own tests and local development, and is not even included in the sdist or wheel. So, even if you run poetry lock and pull in more changes than necessary, it has no impact on users so there is zero risk here.


Chant Proofread page, in sidebar: replace "EDIT" with "PFRD" or something

It is currently not very obvious when one is editing a chant versus when one is proofreading the chant. On the Proofread Chant page, other than the URL, there's only a line of normally-sized text stating that one is proofreading that specific chant.
On the Chant Proofread page, in the sidebar, we currently display the same table as on the Chant Edit page, including an "EDIT" link. While one can technically edit the chant on the proofread page, the main point of the page is that one can check the "proofread" checkboxes. We should replace "EDIT" with something indicating that the user would not just be editing the chant.  This would also help differentiate the Edit and Proofread pages.
The challenge - finding something that fits in the tiny column! "PRF"? "PROOF"? "PRFRD"? "PFRD"?
Or maybe "EDIT" is close enough, and it's not worth trying to change it?

maybe there could be a non-text solution, like the background is pale blue instead of white...

With #1047, we no longer have a Chant Proofread page. Closing.


Revert "build(deps): bump minimatch from 3.0.4 to 3.1.2"

Reverts cloudforet-io/mirinae#174

:tada: This PR is included in version 1.1.0-beta.477 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update Linux Dependencies to libzip5

Starting Ubuntu 20.04 we must switch to libzip5.
After running ./scripts/install-dependencies.sh --runtime --compilation on clean 20.04, it exists with the following error:
E: Unable to locate package libzip4

fixed in tiscamera 0.13.1


feat(ML-595): add custom modelcomposition in exec

Context
Provide model composition for specific actions in exec() command. Model composition in Exec command will take precedence on the modelcomposition set inside askui-helper.ts.

Seems fine from my side. Did you tested it? And did you also changed this in askui-inference?

Yes tested it out. The inference is also in PR.


what pair a requester and a replier

I am trying to send a request to the replier, and the replier only replies to the requester. I have changed to mismatch replier and the requester to uxr_object_id(0x02, UXR_REPLIER_ID) and uxr_object_id(0x01, UXR_REQUESTER_ID) respectively. From the test, the requester and the replier still work. Does XRCE-DDS work that way?
Thank you
V

https://micro-xrce-dds.docs.eprosima.com/en/latest/getting_started.html?highlight=requester#requester-replier

Many thanks for that. Actually, I have read that and my interpretation is a requester-replier pair is formed by the uxr_object_id which both are set 0x01. However, obviously, I was wrong. Is it the "service_name" in XML? Any comments or suggestions?

I modified the participant ID 0x01 to 0x02. The requester and the replier still works. Again I was wrong about the one participant and many publishers and subscribers. How do we create two separate systems with XRCE_DDS in a computer system?

I changed the code to 0x02 and added _2

// Create entities
participant_id = uxr_object_id(0x02, UXR_PARTICIPANT_ID);
const char* participant_xml = ""
""
""
"default_xrce_participant"
""
""
"";
uint16_t participant_req = uxr_buffer_create_participant_xml(&session, reliable_out, participant_id, 0,
participant_xml, UXR_REPLACE);
replier_id = uxr_object_id(0x02, UXR_REPLIER_ID);
const char* replier_xml = "<dds>"
        "<replier profile_name=\"my_requester\""
        "service_name=\"service_name\""
        "request_type=\"request_type_2\""
        "reply_type=\"reply_type_2\">"
        "</replier>"
        "</dds>";

Now the requester not receiving any replies, but the replier still receives the request and sending out the reply.

My intention is to send a request to the replier, and the replier only replies to the requester. Can I achieve that in XRCE_DDS?

uxr_object_id is used for creating participant_id, requester or replier_id. What do they mean from the DDS perspective? I have changed the values to mismatch with the "publisher". However, my tests show that they still work. Appreciate your comments or suggestions!
Thank you


Unity error CS0433 (34 times) when trying to build

Hi I'm trying to build this project and I'm having 34 errors that are basically the same but in different files:
"Assets/UnityGLTF/Scripts/GLTFSceneImporter.cs(755,48): error CS0433: The imported type `GLTF.Schema.Scene' is defined multiple times"
I tried to build the project exactly how it is when cloned from the repository after compiling the .sln file. I opened the project on Unity 5.6.5 I'm able to run the "TestSceneScene" streaming the .gltf objects with no errors, but when I build the game into windows, webGL or IOS it throws me those 34 errors.
I'm doing something wrong? or there is a problem with the repository?
Could you please check this please.

The GLTFSerialization project generates two DLLs: one specifically for UWP, and one for everything else. You should make sure the DLLs are properly marked for the platforms they're compatible with. Likely, Unity is trying to include both DLLs in whichever platform you're trying to build for.
I've also noticed that 5.6.5 seems to be ignoring "Any Platform + Exclude WSAPlayer", but explicitly checking "Include Platforms" works for me.
The correct settings are in the readme, and pictured below.

It fixed the building issue!.
Thank you for the information. I checked out those ones but didn't realize that. I just checked the ones for GLTFSerialization, I'm not using WSA so that is fine.
When I try to build is not throwing me the previous errors, so that fixed the problem thanks!, but now I'm having the following errors on the build:

Do you know what it could be?

I made it work fine


Upstream API Analysis

This PR enables Annotator to compute effect of making a method @Nullable in target module on downstream dependencies without injecting any annotations. List of methods in upstream depencencies is given to NullAway as a .tsv file format which every row is the containing class and method symbol of the method declared in the upstream dependency.
While analysing the source code, NullAway will assume all methods of upstream dependency given in the list returns @Nullable.
To enable this feature, in the FixSerializationConfig, apiAnalysisFromUpstreamDependencyEnabled should be set to true along the path to the .tsv file which contains the list of methods in upstream dependency in upstreamDependencyAPIInfoFile.
The equivalent of the flags above in the .xml config files are:
<serialization>
     <apiAnalysisFromUpstreamDependency "active"=true, "path"="path_to_file.tsv">
</serialization>

Unfortunately I haven't been able to fully pass the test case added in this PR, the remaining error is due to not handling dataflow analysis correctly. I will resolve that as soon as I find a solution.

Very cool! I have a question. Could we do this instead via a LibraryModel that reads the list of methods? Then we would just stick the custom LibraryModel in the processor path. I'm wondering if we can achieve the same thing without modifying NullAway.

Very cool! I have a question. Could we do this instead via a LibraryModel that reads the list of methods? Then we would just stick the custom LibraryModel in the processor path. I'm wondering if we can achieve the same thing without modifying NullAway.

Hi @msridhar thank you very much for the comment, I am not familiar with LibraryModels , I will look into this and get back to you. Thank you.

Sure! @lazaroclapp can help 🙂

One thing is I'm not sure if a library model will work on annotated code. But even if not, we could add a flag just to enable that.

@msridhar @lazaroclapp I just had another look on this PR, it seems that what handlers suggest is only considered as a hint and it will be overridden by dataflow analysis results. Now please assume that Foo.bar() is an upstream method and consider the example below:
Foo foo = new Foo();
foo.bar().toString();

While processing foo.bar() we can successfully inform NullAway that Foo.bar() is an upstream method and make it Nullable which ends to entry (AccessPath root(foo) element(bar()) as Nullable) in Null-ness store. However while processing .toString() part of the expression at line 735 we forcefully update the store with entry AccessPath root(foo) element(bar()) as Non-null to set the receiver as Non-null. This new entry will override any other decisions made by handlers in future and will fail the test. This PR may need to modify other parts of NullAway outside handlers. Please let me know if I am wrong about this.

It is correct to update the access path to non-null after the call, since the call can only succeed with a non-null receiver. The receiver should still be nullable before the call which should lead to NullAway reporting an error.

It is correct to update the access path to non-null after the call, since the call can only succeed with a non-null receiver. The receiver should still be nullable before the call which should lead to NullAway reporting an error.

@msridhar Yes sure, the receiver is indeed nullable before the call and it generates a NullAway error successfully. However the test case requires two errors to be reported by NullAway to pass. Please see the example below:
1. Foo foo = new Foo();
2. foo.bar().deref(); // Should see NullAway error which is successfully reported.
3. Object nullableBar = foo.bar();
4. nullableBar.deref(); // Should see NullAway error which is Not reported.

Analyzing deref() at line 2 on , will lead to entry (AccessPath [root = foo, element = bar()], Nonnull) to make the receiver of deref() non-null.
Therefore when analyzing line 3, handler hints foo.bar() to be nullable, but because of the already existing entry in data flow store, it is neglected and nullableBar will be non-null and no error will be reported on line 4. Would you please tell me if I should work on introducing a new hint type (e.g. Force-Nullable) or follow a different approach ? Thank you very much.

For your example I would argue there should be no error on line 4.  Everywhere else in NullAway we assume that method calls are deterministic by default.  If foo.bar() is deterministic, then at line 3 it cannot return null, so line 4 is safe.  We want upstream API analysis to show the same potential errors that NullAway would report, not a different set.  So maybe you need to split your test case into 2?

For your example I would argue there should be no error on line 4. Everywhere else in NullAway we assume that method calls are deterministic by default. If foo.bar() is deterministic, then at line 3 it cannot return null, so line 4 is safe. We want upstream API analysis to show the same potential errors that NullAway would report, not a different set. So maybe you need to split your test case into 2?

Thank you very much for the suggestion, it makes sense to me now, I will split into two different tests.

Hi all @msridhar @lazaroclapp after the discussion we had here, I decided to split the test case into two separate test cases and this PR now passes all tests successfully and is ready for another review. I am also adding @ketkarameya as a reviewer on this PR.
We currently handle upstream api analysis through a handler, please let me know if we want to switch using LibraryModels Thank you.

I prefer investigating the LibraryModel approach to see if we can get it to work.  I don't think we should need another handler for this.

I looked into this, and the relevant code for library models is here:
https://github.com/uber/NullAway/blob/2c98f2bb5d54d15328775b297c8fd7481e79ff5a/nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java#L110-L112
So right now library models only apply to unannotated code.  But, I think we could extend things (maybe with a flag) so that at least some (or even all?) library models apply to annotated code.  Then, all the rest of the logic of this PR could be shifted to a new library model, that doesn't even need to live in the NullAway repo.
BTW, @nimakarimipour here are the docs on library models:
https://github.com/uber/NullAway/wiki/Configuration#library-models

I looked into this, and the relevant code for library models is here:
https://github.com/uber/NullAway/blob/2c98f2bb5d54d15328775b297c8fd7481e79ff5a/nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java#L110-L112
So right now library models only apply to unannotated code. But, I think we could extend things (maybe with a flag) so that at least some (or even all?) library models apply to annotated code. Then, all the rest of the logic of this PR could be shifted to a new library model, that doesn't even need to live in the NullAway repo.
BTW, @nimakarimipour here are the docs on library models:
https://github.com/uber/NullAway/wiki/Configuration#library-models

Thank you very much for the instructions, I am currently studying them and will update this PR as soon as possible.

@msridhar I looked into this, and I am now familiar with how it works, however I am not sure yet what is best way to facilitate the communication between Annotator and NullAway with this approach. I will get back to this as soon as I find a good way.

Ok, just going by the discussion so far:

We want upstream API analysis to show the same potential errors that NullAway would report, not a different set. So maybe you need to split your test case into 2?

Thank you very much for the suggestion, it makes sense to me now, I will split into two different tests.

This is the correct and cleanest way to do it, but I will also point out it doesn't need to be two different unit tests. Just different methods within the same unit test would have the same effect. For now, splitting is the right call, but if you have to test a dozen of related variations, then a single test case with each as a different method within the "sample" code, works to.

[Re: Library Models vs Handler discussion]

I think using Library Models makes sense, both to minimize upstream changes and also given that we have there a battle-tested API for overriding method information. That said, this will require somewhat more work to integrate with our build. Also, note that, ultimately, Library Models use LibraryModelsHandler, so the lower-level API is the handler API. Will share a document internally in a bit to continue this discussion.

Closing based on the discussion above and offline, in favor of the approach of using custom Library Models and allowing those models to override nullability for annotate/first-party code (see #624)