Feature request: Issue with TSR = 0 in BEM Solution and InflowWind Configuration for Larger Wind Farm

Dear OpenFAST Development Team,
I am currently working on a simulation using FAST.Farm for an experiment that includes 9 wind turbines. During my simulations, I encountered the following warning:
The BEM solution is being turned off due to low TSR. (TSR = 0). This warning will not be repeated though the condition may persist. (See GeomPhi output channel.)
I understand that this error occurs when the Tip-Speed Ratio (TSR) drops to zero, which effectively disables the Blade Element Momentum (BEM) method. This issue may indicate that there is a problem with either the wind speed, the rotor speed, or other aspects of the model setup.
What I Have Tried:
I attempted to edit all available FAST.Farm examples to fit the specifics of my experiment, but unfortunately, I haven't been able to resolve the issue. Below are some of the steps I took:
Adjusted Wind Parameters: I modified the InflowWind module, trying different combinations of wind speeds and directions, but it did not resolve the issue.
Inflow Wind Grid: My current grid setup seems to be too narrow and small. It only accounts for a few turbines (probably designed for a smaller number of wind turbines).
Turbine Count: My experiment involves 9 wind turbines arranged in a layout, which seems to be exceeding the capacity or assumptions made in the original farm examples provided with FAST.Farm.
Main Concerns:
InflowWind Module Configuration:
The inflow wind grid appears to be too limited for the 9-turbine setup. Based on the error message, I suspect the wind field is too constrained and may not be covering all turbines properly, especially for downstream turbines that need to interact with wakes from upstream turbines.
I tried adjusting the NX_Low, NY_Low, and NZ_Low parameters to widen the inflow grid, but I am not sure if my current settings are appropriate for a wind farm of this size.
Low TSR:
I believe the low TSR (TSR = 0) might be linked to insufficient wind input at some turbines, particularly those located downstream. This might be caused by wakes not being fully simulated or covered by the wind grid.
Could this issue be a result of the inflow wind grid not properly accounting for wake effects on the downstream turbines?
Questions for Improvement:
Wind Grid Expansion: How can I expand the InflowWind grid to cover all 9 turbines more effectively? What would be appropriate values for NX_Low, NY_Low, NZ_Low, NX_High, NY_High, and NZ_High to ensure better wind field coverage for a larger wind farm?
Addressing TSR = 0: What other steps can I take to address the low TSR issue and ensure that the BEM solution is not turned off prematurely? Is there any specific recommendation for tuning the turbine or rotor parameters to avoid this?
Best Practices for Larger Farms: Are there best practices or specific adjustments that should be made for running FAST.Farm simulations with more than a few turbines? For instance, should I increase the time steps, or adjust the resolution of the simulation to ensure proper wake modeling?
I would greatly appreciate any advice or guidance on how to solve this issue and improve the configuration of my simulation. I look forward to your feedback and suggestions on how to get the wind farm simulation working properly for my 9-turbine setup.
Thank you for your help and for all the work you do on OpenFAST and FAST.Farm!
Best regards,

here is the output:
Running: C:\Project\openfast-main\openfast-main\build\bin\FAST.Farm_x64_OMP.exe  C:\Project\openfast-main\openfast-main\reg_tests\r-test\glue-codes\fast-farm\TSinflow\FAST.Farm.fstf

FAST.Farm
Copyright (C) 2024 National Renewable Energy Laboratory
Copyright (C) 2024 Envision Energy USA LTD
This program is licensed under Apache License Version 2.0 and comes with ABSOLUTELY NO WARRANTY.
See the "LICENSE" file distributed with this software for details.

FAST.Farm-Unversioned from 6a6511adc44e0b35676e27e1a27caced1ae8c152
Compile Info:

Compiler: Intel(R) Fortran Compiler 2021
Architecture: 64 bit
Precision: single
OpenMP: Yes, number of threads: 20/20
Date: Sep 01 2024
Time: 19:46:14
Execution Info:
Date: 10/13/2024
Time: 18:43:42+0200

Heading of the FAST.Farm input file:
FAST.Farm input file, using two turbines separated by 3D downstream and an offset of 30m, with
a turbulent inflow given by one turbsim box
Running AWAE.
Running InflowWind.
Running WakeDynamics.
Running FASTWrapper.
Running OpenFAST.
OpenFAST input file heading:
FAST Certification Test #26: NREL 5.0 MW Baseline Wind Turbine (Onshore)
Running ElastoDyn.
Nodal outputs section of ElastoDyn input file not found or improperly formatted.
Running AeroDyn.
Running InflowWind.
Running HydroDyn.
Generating incident wave kinematics and current time history.
Adjusting incident wave kinematics for turbine offset from array origin.
Running SubDyn.
Fixed bottom case detected
Performing Craig-Bampton reduction 1056 DOFs -> 8 modes + 48 DOFs
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
Using static improvement method for gravity and ext. loads
SubDyn recommended dt: 0.00512 - Current dt: 0.01000 - Max frequency:    9.758
Calculating Full System Modes for output files
Exporting Summary file
Running ServoDyn.
Running ServoDyn Interface for Bladed Controllers (using Intel Visual Fortran for Windows).
Using legacy Bladed DLL interface.
Running OpenFAST.
OpenFAST input file heading:
FAST Certification Test #26: NREL 5.0 MW Baseline Wind Turbine (Onshore)
Running ElastoDyn.
Nodal outputs section of ElastoDyn input file not found or improperly formatted.
Running AeroDyn.
Running InflowWind.
Running HydroDyn.
Generating incident wave kinematics and current time history.
Adjusting incident wave kinematics for turbine offset from array origin.
Running SubDyn.
Fixed bottom case detected
Performing Craig-Bampton reduction 1056 DOFs -> 8 modes + 48 DOFs
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
Using static improvement method for gravity and ext. loads
SubDyn recommended dt: 0.00512 - Current dt: 0.01000 - Max frequency:    9.758
Calculating Full System Modes for output files
Exporting Summary file
Running ServoDyn.
Running ServoDyn Interface for Bladed Controllers (using Intel Visual Fortran for Windows).
Using legacy Bladed DLL interface.
Running OpenFAST.
OpenFAST input file heading:
FAST Certification Test #26: NREL 5.0 MW Baseline Wind Turbine (Onshore)
Running ElastoDyn.
Nodal outputs section of ElastoDyn input file not found or improperly formatted.
Running AeroDyn.
Running InflowWind.
Running HydroDyn.
Generating incident wave kinematics and current time history.
Adjusting incident wave kinematics for turbine offset from array origin.
Running SubDyn.
Fixed bottom case detected
Performing Craig-Bampton reduction 1056 DOFs -> 8 modes + 48 DOFs
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
Using static improvement method for gravity and ext. loads
SubDyn recommended dt: 0.00512 - Current dt: 0.01000 - Max frequency:    9.758
Calculating Full System Modes for output files
Exporting Summary file
Running ServoDyn.
Running ServoDyn Interface for Bladed Controllers (using Intel Visual Fortran for Windows).
Using legacy Bladed DLL interface.
Running OpenFAST.
OpenFAST input file heading:
FAST Certification Test #26: NREL 5.0 MW Baseline Wind Turbine (Onshore)
Running ElastoDyn.
Nodal outputs section of ElastoDyn input file not found or improperly formatted.
Running AeroDyn.
Running InflowWind.
Running HydroDyn.
Generating incident wave kinematics and current time history.
Adjusting incident wave kinematics for turbine offset from array origin.
Running SubDyn.
Fixed bottom case detected
Performing Craig-Bampton reduction 1056 DOFs -> 8 modes + 48 DOFs
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
Using static improvement method for gravity and ext. loads
SubDyn recommended dt: 0.00512 - Current dt: 0.01000 - Max frequency:    9.758
Calculating Full System Modes for output files
Exporting Summary file
Running ServoDyn.
Running ServoDyn Interface for Bladed Controllers (using Intel Visual Fortran for Windows).
Using legacy Bladed DLL interface.
Running OpenFAST.
OpenFAST input file heading:
FAST Certification Test #26: NREL 5.0 MW Baseline Wind Turbine (Onshore)
Running ElastoDyn.
Nodal outputs section of ElastoDyn input file not found or improperly formatted.
Running AeroDyn.
Running InflowWind.
Running HydroDyn.
Generating incident wave kinematics and current time history.
Adjusting incident wave kinematics for turbine offset from array origin.
Running SubDyn.
Fixed bottom case detected
Performing Craig-Bampton reduction 1056 DOFs -> 8 modes + 48 DOFs
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
Using static improvement method for gravity and ext. loads
SubDyn recommended dt: 0.00512 - Current dt: 0.01000 - Max frequency:    9.758
Calculating Full System Modes for output files
Exporting Summary file
Running ServoDyn.
Running ServoDyn Interface for Bladed Controllers (using Intel Visual Fortran for Windows).
Using legacy Bladed DLL interface.
Running OpenFAST.
OpenFAST input file heading:
FAST Certification Test #26: NREL 5.0 MW Baseline Wind Turbine (Onshore)
Running ElastoDyn.
Nodal outputs section of ElastoDyn input file not found or improperly formatted.
Running AeroDyn.
Running InflowWind.
Running HydroDyn.
Generating incident wave kinematics and current time history.
Adjusting incident wave kinematics for turbine offset from array origin.
Running SubDyn.
Fixed bottom case detected
Performing Craig-Bampton reduction 1056 DOFs -> 8 modes + 48 DOFs
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
[WARN] Complex eigenvalue found with small Im compare to Re
Using static improvement method for gravity and ext. loads
SubDyn recommended dt: 0.00512 - Current dt: 0.01000 - Max frequency:    9.758
Calculating Full System Modes for output files
Exporting Summary file
Running ServoDyn.
Running ServoDyn Interface for Bladed Controllers (using Intel Visual Fortran for Windows).
Using legacy Bladed DLL interface.
Running OpenFAST.
OpenFAST input file heading:
FAST Certification Test #26: NREL 5.0 MW Baseline Wind Turbine (Onshore)
Running ElastoDyn.
Nodal outputs section of ElastoDyn input file not found or improperly formatted.
Running AeroDyn.
Running InflowWind.
Running HydroDyn.
  WARNING:  The requested output channel is invalid: M1N1FAxi
  WARNING:  The requested output channel is invalid: M1N1FAzi
Generating incident wave kinematics and current time history.
Adjusting incident wave kinematics for turbine offset from array origin.
Running SubDyn.
Fixed bottom case detected
Performing Craig-Bampton reduction 948 DOFs -> 12 modes + 6 DOFs
Using static improvement method for gravity and ext. loads
SubDyn recommended dt: 0.00782 - Current dt: 0.01000 - Max frequency:    6.396
Calculating Full System Modes for output files
Exporting Summary file
Running ServoDyn.
Running ServoDyn Interface for Bladed Controllers (using Intel Visual Fortran for Windows).
Using legacy Bladed DLL interface.
FAST_InitializeAll:HydroDyn_Init:HydroDynInput_ProcessInitData: A requested output channel is
invalid
Running OpenFAST.
OpenFAST input file heading:
FAST Certification Test #26: NREL 5.0 MW Baseline Wind Turbine (Onshore)
Running ElastoDyn.
Nodal outputs section of ElastoDyn input file not found or improperly formatted.
Running AeroDyn.
Running InflowWind.
Running HydroDyn.
  WARNING:  The requested output channel is invalid: M1N1FAxi
  WARNING:  The requested output channel is invalid: M1N1FAzi
Generating incident wave kinematics and current time history.
Adjusting incident wave kinematics for turbine offset from array origin.
Running SubDyn.
Fixed bottom case detected
Performing Craig-Bampton reduction 948 DOFs -> 12 modes + 6 DOFs
Using static improvement method for gravity and ext. loads
SubDyn recommended dt: 0.00782 - Current dt: 0.01000 - Max frequency:    6.396
Calculating Full System Modes for output files
Exporting Summary file
Running ServoDyn.
Running ServoDyn Interface for Bladed Controllers (using Intel Visual Fortran for Windows).
Using legacy Bladed DLL interface.
FAST_InitializeAll:HydroDyn_Init:HydroDynInput_ProcessInitData: A requested output channel is
invalid
Running OpenFAST.
OpenFAST input file heading:
FAST Certification Test #26: NREL 5.0 MW Baseline Wind Turbine (Onshore)
Running ElastoDyn.
Nodal outputs section of ElastoDyn input file not found or improperly formatted.
Running AeroDyn.
Running InflowWind.
Running HydroDyn.
  WARNING:  The requested output channel is invalid: M1N1FAxi
  WARNING:  The requested output channel is invalid: M1N1FAzi
Generating incident wave kinematics and current time history.
Adjusting incident wave kinematics for turbine offset from array origin.
Running SubDyn.
Fixed bottom case detected
Performing Craig-Bampton reduction 948 DOFs -> 12 modes + 6 DOFs
Using static improvement method for gravity and ext. loads
SubDyn recommended dt: 0.00782 - Current dt: 0.01000 - Max frequency:    6.396
Calculating Full System Modes for output files
Exporting Summary file
Running ServoDyn.
Running ServoDyn Interface for Bladed Controllers (using Intel Visual Fortran for Windows).
Using legacy Bladed DLL interface.
FAST_InitializeAll:HydroDyn_Init:HydroDynInput_ProcessInitData: A requested output channel is
invalid
Farm_Initialize:Farm_ValidateInput:OutFmt produces a column width of 10 instead of 20 characters.
Farm_Initialize:For efficiency, NumPlanes has been reduced to the number of time steps (4).
Time: 0 of 90 seconds.
The BEM solution is being turned off due to low TSR.  (TSR = 0). This warning will not be
repeated though the condition may persist. (See GeomPhi output channel.)
The BEM solution is being turned off due to low TSR.  (TSR = 0). This warning will not be
repeated though the condition may persist. (See GeomPhi output channel.)
The BEM solution is being turned off due to low TSR.  (TSR = 0). This warning will not be
repeated though the condition may persist. (See GeomPhi output channel.)
The BEM solution is being turned off due to low TSR.  (TSR = 0). This warning will not be
repeated though the condition may persist. (See GeomPhi output channel.)
The BEM solution is being turned off due to low TSR.  (TSR = 0). This warning will not be
repeated though the condition may persist. (See GeomPhi output channel.)
The BEM solution is being turned off due to low TSR.  (TSR = 0). This warning will not be
repeated though the condition may persist. (See GeomPhi output channel.)
The BEM solution is being turned off due to low TSR.  (TSR = 0). This warning will not be
repeated though the condition may persist. (See GeomPhi output channel.)
The BEM solution is being turned off due to low TSR.  (TSR = 0). This warning will not be
repeated though the condition may persist. (See GeomPhi output channel.)
The BEM solution is being turned off due to low TSR.  (TSR = 0). This warning will not be
repeated though the condition may persist. (See GeomPhi output channel.)
T1:FARM_InitialCO:FWrap_t0:FWrap_CalcOutput:Nacelle-yaw error is undefined because the
rotor-disk-averaged relative wind speed is directed vertically
T2:FARM_InitialCO:FWrap_t0:FWrap_CalcOutput:Nacelle-yaw error is undefined because the
rotor-disk-averaged relative wind speed is directed vertically
T3:FARM_InitialCO:FWrap_t0:FWrap_CalcOutput:Nacelle-yaw error is undefined because the
rotor-disk-averaged relative wind speed is directed vertically
T4:FARM_InitialCO:FWrap_t0:FWrap_CalcOutput:Nacelle-yaw error is undefined because the
rotor-disk-averaged relative wind speed is directed vertically
T5:FARM_InitialCO:FWrap_t0:FWrap_CalcOutput:Nacelle-yaw error is undefined because the
rotor-disk-averaged relative wind speed is directed vertically
T6:FARM_InitialCO:FWrap_t0:FWrap_CalcOutput:Nacelle-yaw error is undefined because the
rotor-disk-averaged relative wind speed is directed vertically
T7:FARM_InitialCO:FWrap_t0:FWrap_CalcOutput:Nacelle-yaw error is undefined because the
rotor-disk-averaged relative wind spe

Aborting FAST.Farm.
The following simulations failed
C:\Project\openfast-main\openfast-main\build\bin\FAST.Farm_x64_OMP.exe  C:\Project\openfast-main\openfast-main\reg_tests\r-test\glue-codes\fast-farm\TSinflow\FAST.Farm.fstf
Error using runCommands (line 40)
1/1 simulations failed
Error in runFAST (line 52)
status = runCommands(commands);
Error in runFAST_example (line 33)
runFAST(FSTfilenames, FASTexe); %, 'flag','-VTKLin');

I also tried to make the inflow wind steady. It did not work!

Dear @bweiss222,
Regarding setting up the FAST.Farm model and inflow for a 9 turbine wind farm, the FAST.Farm documentation provides modeling guidance: https://openfast.readthedocs.io/en/main/source/user/fast.farm/ModelGuidance.html.  And I would suggest using the python scripts available in the OpenFAST toolbox to set-up the FAST.Farm domains and inflow: https://github.com/OpenFAST/openfast_toolbox/tree/main/openfast_toolbox/fastfarm.
Regarding the "TSR = 0" warning, I see that the warning appears already at time zero.  Are you initializing the rotor speed and blade-pitch angles for each wind turbine properly?  This warning could also be tied to the error I see about "the rotor-disk-averaged relative wind speed [being] directed vertically"
It sounds like you are using the TSinflow r-test model as a starting point: https://github.com/OpenFAST/r-test/tree/main/glue-codes/fast-farm/TSinflow.  This r-test example uses land-based versions of the NREL 5-MW baseline wind turbine.  However, your OpenFAST models appear to be offshore given that I see SubDyn and HydroDyn called.  Have you swapped the land-based NREL 5-MW OpenFAST model for one of the offshore models available from the OpenFAST r-test, such as the monopile: https://github.com/OpenFAST/r-test/tree/main/glue-codes/openfast/5MW_OC3Mnpl_DLL_WTurb_WavesIrr?
Given the many problems you are facing, I would suggest starting with a simpler model set-up, e.g., with only a single wind turbine included in the FAST.Farm model.  If you can't even get that to work, I would first verify that you can run standalone OpenFAST (uncoupled from FAST.Farm) without issues.
Best regards,


Upgrade JGit to version <IP_ADDRESS>812061821-r

@oscerd: Could you please add a line to CHANGELOG also regarding this?

Done


Error while running wpconfig() task

hi there,
when i run gulp for the first time in /dev after a complete and successful ./setup.rb i got this message
Error: Command failed: docker exec container_wp wp option get siteurl

and when i execute docker exec container_wp wp option get siteurl i should return something like http://localhost:32769 but nothing happen...
i'm trying to share a theme i made with FDK, but i don't know how to deal with docker

also when i go to the http://localhost:327** i got this :

Hi @maxperei, could you paste the full output from gulp please?

hi andrew 😌
output.txt

Did you make any changes in the src folder (specifically, PHP) after setup?

nothing at all

and this happens the same every time you run gulp?

yes unfortunately, i did not experienced this error with the previous version of FDK

could you paste a screengrab of the contents of the dev/build/ folder?

here it is :

Is there a vendor/ in dev/src/includes/? Can you try and running composer install there?

of course i should launch composer install from the very beginning, thank you

@maxperei setup.rb runs composer install automatically... did you get any error messages during the original install? Let us know what happens next time you set up a project? Thanks.


ebrock's stuff

:3

Still a ton of node_module files in this PR. These need to be cleaned up so I can port what code we actually did write into coffescript.

spoonfeeding rebase complete


I cannot access the app mentioned by you

Oh no.
Error running app. If this keeps happening, please contact support.
I was reading this paper:
https://betterprogramming.pub/making-music-from-images-with-python-81db627fd549
when I decided to accedd your webpage, but the link is broken.
Can you give me access to your web app?

@charlesstempniak That's odd, Streamlit marks the app as being online and it seems to be running fine. Here's the direct link for it:
https://victormurcia-making-music-from-images-music-to-images-ce4ydi.streamlit.app/
Let me know if it still gives you issues and I'll look into it further.
Best,
Victor


fix: removing @PipKat from *.md files - changelog fragments

I believe you were being tagged EVERYWHERE  unnecessarily as reviewer @PipKat - sorry for that!

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.23%. Comparing base (9800028) to head (7f2f907).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1098   +/-   ##
=======================================
  Coverage   90.23%   90.23%
=======================================
  Files          93       93
  Lines        6839     6839
=======================================
  Hits         6171     6171
  Misses        668      668

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


--coverage option is not compatible with --watch option

when you use them together tests still run after each change but test failures are no longer visible.
After each test, the console clears to the following
Using Jest CLI v13.2.3, jasmine2, babel-jest

You'd need to scroll up in the terminal buffer in order to view test failures, which makes --watch much harder to use.

cc @dmitriiabramov
Maybe we should have a short summary only (overall coverage) when using coverage and watch?

wait... why would you use --watch and --coverage at the same time? i used to throw an error in this case before, because the coverage will never be accurate

I have asked this question myself but people seem to want it.

Hmm fair question. @dmitriiabramov . Maybe we should document the fact that --watch and --coverage should not be used together?

@tonyxiao i think if there is any valid use for it, we should make it work. But if not, i think it's better to just throw an error and kill the process. Wrong information is worse than no information :)

@dmitriiabramov agreed. I'd be totally happy if we throw error and kill the process. The problem was not knowing that they shouldn't be used together and expecting it to work.

Ok, let's do this: instead of erroring, show a message on the top that says "coverage is enabled through the config but not active during --watch". People might have collectCoverage: true in their config and I don't want the process to throw if that is the case.

That would work too. 👍

So if I have coverage enabled via my config, is there a way to disable it when trying to run watch in command line?

Fixed in #1515 for Jest 15.

Was @calclavia's question even answered? I'm curious about this as well.

You are right, --no-coverage isn't currently supported. If you'd like to add it, please send us a PR! :)

Hi, I'm really interest in --watch and --coverage together. Why? Because I try always to have a good coverage and I have a lots of tests in this project that I'm working on. I Like to see the progress of the coverage and every time that I write some test I want to run the coverage and I've to wait a long time to receive the result.
Is there any chance to implement this feature? If not can you explain me why? Do you have any solution to my problem?

See #5601

See https://github.com/facebook/jest/issues/7331

Hi there and thanks for your awesome efforts for making jest a wonderful testing framework.
Just related to using --watch --coverage, my use case is I want to generate a "coverage-final.json" whenever there is a re-run tests, so I the vscode plugin "Code Coverage Highlighter" will show me, what other methods that are still don't have tests.
This is sure if you practice TDD, you can run jest with coverage on a separate terminal (not using --watch), because with TDD you will have a very good coverage usually, but if this is not the case and you wrote a lot of code then the combination of --watch --coverage + using a plugin for the IDE can help.
Also using --watch --coverage can increase the productivity instead of returning to the terminal and rerun the command line every time you do some tests.
Thanks again for your efforts

I finally got a working configuration.
When the configuration is set in the package.json it won't work. Therefore, I had to create jest.config.js file with the following contents:
module.exports = {
  collectCoverage: true,
  coverageReporters: [
    "html"
  ]
};

And in package.json:
"scripts": {
    "test": "jest --watchAll" // It doesn't work with --watch
}

Only with --watch will not work

Thanks @Abadii!
jest --watchAll --collect-coverage
does the job. TDD FTW!


Longpress shadow

Hello,
We want to make a shadow in selected cell on long-pressing in week/day view in add new mode but cannot see where and how to do this. This shadow must apply before trigger the long press event to indicate the user the hour that is selecting
Thanks.

https://youtu.be/e5FMJC-7mkU
We want to blur or apply shadow on the hour that user is selecting just after tap and before creating an event (during the long press).
Im trying to do this adding a gesture recognizer on tap event with cancelsTouchesInView set to false but cannot modify the background color of an empty hour, i will try to add a dummy element of collection view meanwhile.
Thanks

In the youtube video im long pressing the hours to create a new event, but cannot see nothing that indicates the hour that im pressing.

Didn't work, tap and long press are totally different events. Are there a way to simulate "onmousedown" javascript event like in swift?

https://www.youtube.com/watch?v=U9j5Kk6PaIc

I am still quite confused about your description.
Have you implemented the JZLongPressViewDelegate, JZLongPressViewDataSource?
https://github.com/zjfjack/JZCalendarWeekView/blob/master/JZCalendarWeekView/JZLongPressWeekView.swift

Could you show me the design or the requirements what you want to do?
Thanks


Inconsistent results in the published paper and the repo

In the original paper, the reported results of LVIS in Table 4: APm = 27.0 and APb = 27.6 , while in this repo, APm = 27.0 and APb = 26.4

Thanks for raising the question.
For the result in the original paper, we obtained it using an internal framework that is only for internal usage and cannot be open-sourced due to the company's policy.  Thus, we choose a popular codebase, detectron2 as the platform to open-source code.
The result cannot be matched exactly due to different implementation details. The result would also be quite different if you take mmdetection as the code-base. We only tune the configuration to match the major metric used in LVIS, AP mask, in detectron2 for open-source purposes. One may further tune the configuration in order to obtain a better result on LVIS.
Thank you.

I will close the issue for now. Feel free to reopen it if you have any further questions.


Implement an existing templating mechanism for ConfigurationIssueLevel and rework the messages.

vinjana 6 days ago Member
See comment in tests. Maximize information / character ratio.
@npeschke
npeschke 7 hours ago Member
I get this warning for the cvalues RODDY_JOBID, RODDY_JOBNAME, RODDY_QUEUE, scratchBaseDirectory and RODDY_SCRATCH which are not in direct control of the user. Therefore, it might be beneficial to either omit them from checking or rework the check to minimize users getting worried about the warning when running a job.
It might also be helpful to give a quick summary of the affected cvalues like
The values A, B, C in your configuration...

@vinjana
vinjana 3 hours ago Member
Yes, these values should not get warnings. The second option you propose I do not understand, but certainly users should not get worried unnecessarily.
@dankwart-de
dankwart-de just now Member
You are right and I'd like to change it. However, I'd like to postpone the changes and implement them together with a templating engine/mechanism (see below). I'll create an issue for it.

See https://github.com/TheRoddyWMS/Roddy/pull/307 for the original discussion.


WIP

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

/test  pull-kubevirt-e2e-k8s-1.19-sig-compute

@jean-edouard  The assumption seems to be correct

/close


Ingress.name_map to only change names of arguments

Didn't get to #11 yet, but since https://github.com/i2mint/front/issues/16 needs a to map names, I'll take care of that case -- though it might just be become a corollary of #11 later.
A classmethod of Ingress such as:
@classmethod
def name_map(cls, wrapped, **old_to_new_name):
    """Change argument names.
   ...

so that, for example:
>>> def f(w, /, x: float, y=2, *, z: int = 3):
...     return f"(w:={w}) + (x:={x}) * (y:={y}) ** (z:={z}) == {w + x * y ** z}"
>>> ingress = Ingress.name_map(f, w='DoubleYou', z='Zee')
>>> ingress
Ingress signature: (DoubleYou, /, x: float, y=2, *, Zee: int = 3)
>>> wrapped_f = ingress.wrap(f)
>>> wrapped_f(1, 2, y=3, Zee=4)
'(w:=1) + (x:=2) * (y:=3) ** (z:=4) == 163'

Closed by https://github.com/i2mint/i2/commit/a78add8fa77ced04d89ee695becbcb9b38a42f7c


Implement read-only state

Fixes #86

This change is

Good job! :thumbsup:

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Jwt invalid algorithm

I have got token from user signIn & signUp function. But when i set token in headers authorization, It returns
{
  "message": "invalid algorithm"
}

i am so curious to know what this is happening.
Also I double check config values are already loaded.
Thank you.

const isAuth = jwt({
  secret: config.jwtSecret, // The _secret_ to sign the JWTs
  algorithms: ['HS256'], // JWT Algorithm
  userProperty: 'token', // Use req.token to store the JWT
  getToken: getTokenFromHeader, // How to extract the JWT from the request
});

Change algorithms value to the example I posted above

It is working with HS256 Algorithm


Missing configs when cloning SwinjectStoryboard through Carthage

I'm getting the following errors when I try and build SwinjectStoryboard.framework after cloning with Carthage:
The file “Debug.xcconfig” couldn’t be opened because there is no such file. (/Users/mpdifran/Sandbox/Speedometer/Carthage/Checkouts/Swinject/Carthage/Checkouts/xcconfigs/Base/Configurations/Debug.xcconfig)
The file “iOS-Framework.xcconfig” couldn’t be opened because there is no such file. (/Users/mpdifran/Sandbox/Speedometer/Carthage/Checkouts/Swinject/Carthage/Checkouts/xcconfigs/iOS/iOS-Framework.xcconfig)
Build setting PRODUCT_NAME undefined

The SwinjectStoryboard.xcodeproj is included in my project as a sub-project. I'm also noticing that the Nimble and Quick subprojects are missing within SwinjectStoryboard.xcodeproj.

I am running the following Carthage command:
carthage update --use-ssh --platform iOS --no-use-binaries --no-build

My mistake, I was doing something screwy. Doesn't seem to be a real problem.


Add possibility to (un)watch a repository

Issues: github/android#544,  github/android#106
The GitHub Java lib hasn't been updated to the new watching API so that would need to be fixed first.

This should include unwatch too, I guess?

Yes, I meant both actions ;)


[FCC - Beta] Youtube Playback Error

Challenge build-a-survey-form has an issue.
User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36.
The error can be reproduced in Firefox & Google Chrome. Here's the Screenshot of the issue:

Refer https://github.com/freeCodeCamp/freeCodeCamp/issues/12753


Documentation mentions 1.5 as the LTM release for the 1.x major release

Nautobot Version: 2.0.1, but all others since LTM was introduced theoretically apply
The documentation mentions that 1.5 will be the LTM release for 1.x, where in reality this has become 1.6.

I would have quickly updated this myself but I lack the source for this image

I would have quickly updated this myself but I lack the source for this image

The source for the image is here


Failed to create ChartInfo through JAVA Emitter

code:

Error:
MetadataWriteResponse(success=false, responseContent={ "cause2":"org.springframework.web.client.HttpClientErrorException$UnprocessableEntity: 422 Failed to validate record with class com.linkedin.chart.ChartInfo: ERROR :: /inputs/0 :: union type is not backed by a DataMap or null\n", "cause1":"org.springframework.web.util.NestedServletException: Request processing failed; nested exception is org.springframework.web.client.HttpClientErrorException$UnprocessableEntity: 422 Failed to validate record with class com.linkedin.chart.ChartInfo: ERROR :: /inputs/0 :: union type is not backed by a DataMap or null\n", "servlet":"openapiServlet", "cause0":"javax.servlet.ServletException: org.springframework.web.util.NestedServletException: Request processing failed; nested exception is org.springframework.web.client.HttpClientErrorException$UnprocessableEntity: 422 Failed to validate record with class com.linkedin.chart.ChartInfo: ERROR :: /inputs/0 :: union type is not backed by a DataMap or null\n", "message":"javax.servlet.ServletException: org.springframework.web.util.NestedServletException: Request processing failed; nested exception is org.springframework.web.client.HttpClientErrorException$UnprocessableEntity: 422 Failed to validate record with class com.linkedin.chart.ChartInfo: ERROR :: /inputs/0 :: union type is not backed by a DataMap or null\n", "url":"/openapi/entities/v1/", "status":"500" }, underlyingResponse=HTTP/1.1 500 Server Error [Cache-Control: must-revalidate,no-cache,no-store, Content-Type: application/json, Content-Length: 1362, Connection: close, Server: Jetty(9.4.46.v20220331)] [Content-Length: 1362,Chunked: false])
SDK Version:0.8.36
DataHub Version:0.8.38

Modified code：

Error:
MetadataWriteResponse(success=false, responseContent={ "cause2":"org.springframework.web.client.HttpClientErrorException$UnprocessableEntity: 422 Failed to validate record with class com.linkedin.chart.ChartInfo: ERROR :: /inputs/0 :: union type is not backed by a DataMap or null\n", "cause1":"org.springframework.web.util.NestedServletException: Request processing failed; nested exception is org.springframework.web.client.HttpClientErrorException$UnprocessableEntity: 422 Failed to validate record with class com.linkedin.chart.ChartInfo: ERROR :: /inputs/0 :: union type is not backed by a DataMap or null\n", "servlet":"openapiServlet", "cause0":"javax.servlet.ServletException: org.springframework.web.util.NestedServletException: Request processing failed; nested exception is org.springframework.web.client.HttpClientErrorException$UnprocessableEntity: 422 Failed to validate record with class com.linkedin.chart.ChartInfo: ERROR :: /inputs/0 :: union type is not backed by a DataMap or null\n", "message":"javax.servlet.ServletException: org.springframework.web.util.NestedServletException: Request processing failed; nested exception is org.springframework.web.client.HttpClientErrorException$UnprocessableEntity: 422 Failed to validate record with class com.linkedin.chart.ChartInfo: ERROR :: /inputs/0 :: union type is not backed by a DataMap or null\n", "url":"/openapi/entities/v1/", "status":"500" }, underlyingResponse=HTTP/1.1 500 Server Error [Cache-Control: must-revalidate,no-cache,no-store, Content-Type: application/json, Content-Length: 1362, Connection: close, Server: Jetty(9.4.46.v20220331)] [Content-Length: 1362,Chunked: false])

This is still an issue, have not gotten to it yet.

May be the same type of problem as https://github.com/datahub-project/datahub/issues/5463


Be more gentle about unknown checks

Fixes https://github.com/sivakumar-kailasam/codeclimate-checkstyle/issues/13

🙇


Some of categories of group do not show members

Describe the bug
Some of categories of group do not show members.
To Reproduce
Steps to reproduce the behavior:

Go to https://testnet.app.astrodao.com/dao/octopus-dao.sputnikv2.testnet/groups/council-manager
See error.

Expected behavior
Should show account(octopus-council.registry.test_oct.testnet) in this page.
Screenshots

fixed on mainnet


Generate music?

It is a common trend to add music to mathematical visualizations. I have no idea, what to implement. Maybe a sound everytime a relator is applied? When multiple relators are applied after another the sounds can harmonize. :D
This would make groups with many relators sound different. Groups with high growth have fast vertex-generation so the frequency should increase.
I wonder how much patterns there are in the music, considering the generation is pretty random.

The idea comes from reddit.
https://www.reddit.com/r/math/comments/1aimjq8/understanding_groups_and_drawing_pretty_pictures/


use watchEffect should pauseTracking with array

Version
2.7.0-beta.3
Reproduction link
codesandbox.io
Steps to reproduce
pauseTracking with array length when length-altering mutaion
What is expected?
the first demo in Vue3 can show the [ 1, 2 ]
but in Vue2.7.0-beta.3 it shows [ 1, 2, 1, 2 ]
In the second demo will make page stop running.
it looks like https://github.com/vuejs/core/issues/2137
What is actually happening?
not same result and page stop running

Unfortunately this is a limitation of Vue 2's reactivity system. Array mutation methods work by triggering updates of effects that tracks the array itself. There's no way to fix this.


Xctest testable

Thanks Hasan.
Why have you closed this PR? Is it still under construction?

Hi @wojtysim, yeah it is, under development, I will re-open the PR soon


add new property allownone to a rule

allow to have None value for an element.
for instance an element can/must be in yaml file
but the value can be a string or None
data.yaml
property: null

or
property: 'foo bar'

data-schema.yml
type: map
mapping:
  property:
    type: str
    allownone: True

by default allownone is False

Coverage decreased (-0.4%) to 88.282% when pulling c5650afa028f419376f72711880479bfc8bd7684 on bneron:allownone into 92ea825cde64a9224aafa6fe964c09116cd135e6 on Grokzen:unstable.

Great idea that solves a common problem. What i currently miss is the following:

Tests for this new attribute, both Ok and fail tests should be included
Write about this property in the docs

@bneron Implemented in this commit 8d8c6eb4a6b579fa1e20392a45f8f9d94eb830d6.
Clsoing this one as fixed/implemented in favor of the mentioned commit.

@bneron I found out something interesting in the source code for kwalify that i must have missed completley and that is if you for example specify that it should be a str type but the value is null then it should actually pass validation so there is no real need for this allownone keyword becuase it should already be implemented and pass validation. There is however some cases where it should still be more "strict" and that is if required: True is set for the str type or if assert or enum is used but other then that it should pass. I kinda base this on this code part https://github.com/sunaku/kwalify/blob/b8084b389b262e767d7ba8333eb810ce69f70908/lib/kwalify/validator.rb#L180
I will remove this keyword and change the default code to behave correclty and your initial case should work ouf of the box without allownone keyword set.

@bneron Please see this commit e705f59c7c165d5cf3566ef7792e828d77647e9c It is major and contain alot of stuff but this is the correct way to move forward atleast.


feat: prompt user to enable multichain snap during trade

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5166

PR #5249   👈
PR #5169
PR #5167

This comment was auto-generated by Graphite.

functionally approved but requires some @reallybeard oil as she currently fugly

marking as ready to see CI

Re-worded the copy a little and used the link component.


CwlUtils.framework is missing in Products

I'm including CwlSignal as a sub-project, which worked well before the xcode10 merge, since now I can't reference CwlUtils framework in the Copy to Frameworks build step.

Hi @andreyz, I've replaced the "Aggregate" targets for building CwlUtils with hollowed out "Framework" targets (same approach used prior to the xcode10 branch). Please let me know if this helps – you should be able to add the CwlUtils.frameworks to link and copy phases as before.
I removed the Framework targets during the Xcode 10 betas because I was getting errors about multiple targets producing the CwlUtils.framework. I don't know if this was a bug fixed in later betas or if there was another cause – or if the problem might return – but the Framework targets are working for now.

Thank you Matt! Commit 9ec066c solved it for me. Hope that didn't mess things up for everyone else :)


📅 6/21 @ noon PT - Automating gr2m/helpdesk: comment on issue when show begins

💁🏻 Automating gr2m/helpdesk: comment on issue when show begins
📅 Monday, June 21, 2021
🕐 12:00pm Pacific Time (in your timezone)
🎙 no guests
🏷 Automation

Subscribe to this issues to get a notification before the show begins and a summary after the show concludes.
Automating gr2m/helpdesk: comment on issue when show begins
I've laid out the current process for this repository at https://github.com/gr2m/helpdesk/tree/f085060fb98f61a005c9e79df15fdad6466c6a1a#how-i-use-this-repository.
I've automated some of the steps in past automating helpdesk shows. In this episode, I want to automate a comment on the issue when the show begins, informing everyone who is watching the repository or the issue that the show is about to begin.
Outline

Recap the automation of the schedule cron triggers in the previous episode
Automatically comment on show issues when it goes live
If we still have time: let's replace the scheduling of tweets with just tweeting from GitHub actions, so we don't rely on two different scheduling mechanisms. Also Twitter's scheduling feature didn't work reliably.

Preparation

[x]  30 minute announcement tweet
[x] start of show tweet
[x] start of show issue
[ ]  recording available tweet

Recording
will be added after the show

Shownotes
will be added after the show

I'm now live on https://twitch.tv/gregorcodes

I'm now live on https://twitch.tv/gregorcodes
Sorry for the double comment, I'm just testing

I'm now live on https://twitch.tv/gregorcodes
Sorry for the double comment, I'm just testing

I'm now live on https://twitch.tv/gregorcodes
Sorry for the double comment, I'm just testing

Show is done for today, thank you all! Recording is coming up in a moment

Show is done for today, thank you all! Recording is coming up in a moment

Recording is now available on Twitch: https://www.twitch.tv/videos/1063341529

Recording is now up on YouTube: https://youtu.be/uVnfMTc8j8c


Reapplying custom-style

Description
When two lazy loaded elements use the same global css variable name --my-color with different values defined in their respective custom-style's is there a way to reapply the custom-style when we switch between elements? Right now the last loaded custom-style remains in effect and calling updateStyles does not seem to help.
Live Demo
http://plnkr.co/edit/hzaKtXOHhT4bRe9V93BQ?p=preview
Steps to Reproduce

"Page One" is loaded first - it has blue background
Click "Next Page" to load "Page Two" - it has purple background
Click "Next Page" to load "Page One" again - it now has purple background too

Expected Results
Page One to retain blue background
Actual Results
Page One becomes purple
Browsers Affected

[x] Chrome (others not tested)
[ ] Firefox
[ ] Edge
[ ] Safari 9
[ ] Safari 8
[ ] IE 11

Versions

Polymer: v2.0
webcomponents: v1.0

The custom-style elements happen to be in the same HTML imports as the element, but there's no other linkage between them. Once that HTML import has been loaded, it remains loaded. So this scheme is not going to work.
The easiest thing to do here would be to set --my-color in the element itself (only works for the pages and their descendants, so it can't affect any peers):
http://plnkr.co/edit/6QfejM2b7zs0Ivis0c4B?p=preview

Thank you - that works for me. I can put the vars in separate dom-modules and load them into pages with style include.
It's likely that loading/switching color themes dynamically will be requested at some point, so it would be interesting to know if it's supported.


fix: [CURLRequest] skip hostname checks if options 'verify' false

Supersedes  #8257
Description
When CURLRequest options 'verify' is set to false, some CURLOPT_SSL_... options should be disabled in such a way as to allow requests to pass through in case the destination is for example on private networks.
Avoids SSL errors: SSL: certificate subject name 'CA' does not match target host name 'localhost'
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Thank you!
But some checks were not successful.
Please fix the code to pass all checks.

Thank you!
But why did you send to 4.5?
This is a bug fix, so you can send to develop.
Do you think this is a breaking change?

I don't think it's breaking anything. It's just that that the label bug was added afterwards.
So I have to close this PR and open a new one while choosing branch develop? Is this ok?

I think this is a bug fix, so I added the label bug.
I'm okay that you change to develop.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#if-you-sent-to-the-wrong-branch

Completed the switch to branch develop.

@NicolaeIotu We don't use git merge in PR branches. Please use git rebase if you can.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

So in case verify it's a string then it can only be "the path to a CA bundle".
Also will try to make git rebase.

I'm doing some git action to revert my mistakes. Please ignore for a while.

I think it's ok now.

The last thing. Add short instruction how to change when upgrading in
https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/installation/upgrade_444.rst#breaking-changes
Although confusing with changelog, the changelog describes what has changed and the upgrading guide describes what users need to do when upgrading.

@NicolaeIotu Thank you!

@kenjis Thank you!


Add PIPENV_NOSPIN option for cleaner build logs

I would like to be able to clean up this noise on CircleCI:

@kennethreitz Thoughts on this?
It probably makes more sense to add a spinner.disable() API in blindspin, but this is start...

I can see the desire to have cleaner logs, but I don't think we need another variable specifically for the spinner. It's more surface area for the user to have to worry about for a pretty specific edge case.
If Kenneth wants to entertain this, I think there are two possibly simpler options:

a PIPENV_CLEAN (or PIPENV_NOFUN 😉)  that replaces and encapsulates both PIPENV_COLORBLIND and PIPENV_NOSPIN
placing the spinner inside of a if not bare check to actually leverage our --bare argument.

colorblind can disable the spinnner too.

@kennethreitz But I love the colors! 😄
I'll push a change that uses the same environment variable for you to consider.

this change is sane, i'll keep it.

✨🍰✨

released!

might be refactored in the future


Make registrant nullable on domains

This is the first step in migrating to the minimum registration data set. Note that our database model already permits null domain registrants, so this just makes the code accept it as well. Note that I haven't changed any requirements in EPP flows yet; a later step will be to check the migration schedule and then not require the registrant to be present if in a suitable state.
This does potentially affect the output of WHOIS/RDAP, but that's a NOOP so long as EPP commands and other tools continue to enforce the requirement of a registrant.

This change is

Looks like it needs another LGTM because of a last minute change.


Added Lillia and Yone champion ids to constants.

Added championIds from Lillia and Yone.
Found them here:
https://raw.communitydragon.org/pbe/game/data/characters/lillia/lillia.bin.json
https://raw.communitydragon.org/pbe/game/data/characters/yone/yone.bin.json

Update package.json version


docs: fix typing link

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[x] 🐛 Bug Fix
[ ] 🔧 Optimization
[x] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

If you have comments or can explain your changes, please do so below.
Link referring wrong doc page

Edit: Not sure if this was intended to be under api-reference (arguably not the best place to find it?!) - yet it is there and the link was another page

Double Edit: Marco is just to fast to merge 😂

Second edit: Marco is just to fast to merge 😂

😄 ah sorry! idk, I think it's part of the api in the sense that you can do from narwhals.typing import ... - but maybe it could be better placed somewhere else?

I think it's part of the api in the sense that you can do from narwhals.typing import ...

Then let's keep it there :)


where are the code and data?

@zhiweihu1103 code is in progress. we'll release the code and data in a few days.

great


Change ETS queue table permissions to protected

Sometimes realtime replication stops working, the reason why it has stopped is unclear, diagnosis is further complicated by the fact that the ETS queue table (buffer of objects due to be replicated to the sink) is private (can only be seen by the riak_repl2_rtq gen_server instance).
If it were possible to examine the contents of that table the support engineer could examine the queued objects and perhaps identify a large object causing head of line blocking. At the moment the only option is to kill the process and let the supervisor restart it, destroying all useful information in the process. The diagnostic information is opaque and needlessly so.
The table doesn't need to be changed to public as it's probably undesirable to modify state outside the public API for this gen_server.
I propose that the permissions be changed to 'protected' in order to improve visibility.

Not too late, was gonna yell "FREEZE!" on Monday. I'll double check it this afternoon, but it looks good to me, and makes good sense.

This would be good, I think we've had the same frustration when trying to diagnose why the queue is blocking but haven't been able to do anything because the table is private

Just realised, this should be against 2.2, and 2.2.5 should have been deleted. It was just a temporary branch while I got the build working. Sorry @binarytemple, can you re-open against develop-2.2?

Closing in favour of #782 (branch target mess up, and @binarytemple is AFK for a few days so this is quicker)


Rename things to make more sense

I think Imposer and Model names are too generic. Maybe let's use Criteria and CriteriaBuilder?
Ex:
interface SearchCriteriaInterface
{

}

class BedroomCriteria implements SearchCriteriaInterface
{
    public function getMin()
    {

    }

    public function getMax()
    {

    }
}

interface SearchCriteriaBuilderInterface
{
    public function build(SearchCriteriaInterface $criteria);
}

class BedroomCriteriaBuilder implements SearchCriteriaBuilderInterface
{
    /**
     * @var
     */
    protected $criteria;

    public function build(SearchCriteriaInterface $criteria)
    {
        $qb = $this->qb->where('bedroom', $criteria->getMin());
    }

    public function allowsCriteria(SearchCriteriaInterface $criteria)
    {
        return $criteria instanceof BedroomCriteria;
    }
}

I would change allowsCriteria to supportsCriteria, build to buildCriteria.
How about SearchingContext::getQueryBuilder is it ok for you?
FilterModelCollection would be changed to CriteriaBuilderCollection and FilterModelCollection to CriteriaCollection, right?
Would you be able to code review eventual PR when this issue will be implemented, @drgomesp, or you want to implement this by your own?

I would change allowsCriteria to supportsCriteria, build to buildCriteria.

That's good for me.

How about SearchingContext::getQueryBuilder is it ok for you?

Yes, that makes more sense.
FilterModelCollection would be changed to CriteriaBuilderCollection and FilterModelCollection to CriteriaCollection, right?
Yes, and things are looking more clear now! 😄

Would you be able to code review eventual PR when this issue will be implemented, @drgomesp, or you want to implement this by your own?

Both options. I would prefer to actually implement it, but not sure when I'll have the time. Let's discuss it later.

Ok, first PR to milestone 3.0.0 was merged #47. Now we need to document it properly. I'm closing this issue and documentation work can be done under issue #43. I'm starting working on branch milestone-3.0. Feel free to help

Sorry for the late reply,  but CriteriaBuilder seems a bit weird to me. You're not building any Criteria,  you are applying the Criteria to the QueryBuilder. Imho it now suggests that the CriteriaBuilder creates Criteria, which is obviously not the case. CriteriaApplier doesn't sound nice,. Buy something like CriteriaCompiler? As it compiles the Criteria into a query constraint.

Hi.
Thanks for the feedback!
At first there was ModelImposer, but Model was changed to Criteria and Imposer into Builder. I agree that CriteriaApplier does not sound well. If you think of compiling as translating criteria into some abstract query, then maybe CriteriaCompiler would make sense, but what do you think about CriteriaImposer - wouldn't it be better?
//cc @drgomesp


feat: add support for renv.lock

Resolves #642

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (521f59c) 78.50% compared to head (427c252) 78.00%.

:exclamation: Current head 427c252 differs from pull request most recent head a2e4de9. Consider uploading reports for the commit a2e4de9 to get more accurate results

Files
Patch %
Lines

pkg/lockfile/parse-renv-lock.go
92.85%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
- Coverage   78.50%   78.00%   -0.51%
==========================================
  Files          82       83       +1
  Lines        5890     5919      +29
==========================================
- Hits         4624     4617       -7
- Misses       1068     1101      +33
- Partials      198      201       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Investigate issues with stuck at "Please install an extension" screen

A refresh with clean cache solves the issue, but it should work more reliably

Hopefully closed by https://github.com/ChainSafe/Multix/pull/16


feat(http): Add a Helm user-agent string to the http getter

Adding a user-agent to the http getter will enable servers to
distinguish between helm (including various versions) and other
tools connecting to the server.
cc: @prydonius @viglesiasce

@bacongobbler updated per feedback.

thanks!


metro-serializer-esbuild: target ES6 with individual features disabled

As of esbuild v0.14.46, we can target ES6 and disable individual JS features that Hermes do not support.

Great news @tido64! the esbuild v0.14.48 now includes Hermes as a JavaScript engine target. With features that are supported.

Great news @tido64! the esbuild v0.14.48 now includes Hermes as a JavaScript engine target. With features that are supported.

This is great news indeed! Thanks for letting me know. Going to whip up a PR to enable this.


updateOptions Crashing in FirestoreRecyclerAdapter

The following commit added ##updateOptions##
https://github.com/firebase/FirebaseUI-Android/commit/d7aec385c2bbb807b39b4c3c444f161f55be17fc
https://github.com/firebase/FirebaseUI-Android/commit/d7aec385c2bbb807b39b4c3c444f161f55be17fc#r35785637
But it's half done. For example, the ##FirestoreRecyclerAdapter## constructor isn't updated and tested.
https://github.com/firebase/FirebaseUI-Android/commit/d7aec385c2bbb807b39b4c3c444f161f55be17fc#diff-5e8b0d86c8d693eb2093b88e08e1e76f

Steps to reproduce:
import com.firebase.ui.firestore.FirestoreRecyclerAdapter
and updateOptions on it
Observed Results:

What happened?  This could be a description, logcat output, etc.
NullPointerException on line 105: https://github.com/firebase/FirebaseUI-Android/commit/d7aec385c2bbb807b39b4c3c444f161f55be17fc#r35785637

Expected Results:

What did you expect to happen?
Options being actually updated

Relevant Code:
messagesInChatAdapter.updateOptions(messagesInChatOptions as FirestoreRecyclerOptions<MessageModel>)

@samtstern  @PatilShreyas Could you pl take a look at this?

@abhilashi Still can't understand What you want to do. Could you provide code?

@PatilShreyas thanks much for the quick reply. It's a simple issue.
There are two ##FirestoreRecyclerAdapters## not one. One in ##ui/firestore## directory and other in ##ui/database##
You added ##updateOptions## in both of them but forgot to change the constructor in one of them. In ##ui/database/FirestoreRecyclerAdapter## mOptions is updated and it works fine.
But the same isn't done in ##ui/firestore/FirestoreRecyclerAdapter##. See lines 38 and 39  https://github.com/firebase/FirebaseUI-Android/blob/d7aec385c2bbb807b39b4c3c444f161f55be17fc/firestore/src/main/java/com/firebase/ui/firestore/FirestoreRecyclerAdapter.java#L38
@PatilShreyas @samtstern Let me know if you need more details. I can give the code but this is more succinct way to get to the root of the issue.

First of all, there are different adapters

FirebaseRecyclerAdapter
FirestoreRecyclerAdapter

This API is tested before merging into repo. Can you provide your
implemention so that I can assist you further.
On Tue 5 Nov, 2019, 5:17 PM abhilashi<EMAIL_ADDRESS>wrote:

@PatilShreyas https://github.com/PatilShreyas thanks much for the quick
reply. It's a simple issue.
There are two ##FirestoreRecyclerAdapters## not one. One in
##ui/firestore## directory and other in ##ui/database##
You added ##updateOptions## in both of them but forgot to change the
constructor in one of them. In ##ui/database/FirestoreRecyclerAdapter##
mOptions is updated and it works fine.
But the same isn't done in ##ui/firestore/FirestoreRecyclerAdapter##. See
lines 38 and 39
https://github.com/firebase/FirebaseUI-Android/blob/d7aec385c2bbb807b39b4c3c444f161f55be17fc/firestore/src/main/java/com/firebase/ui/firestore/FirestoreRecyclerAdapter.java#L38
@PatilShreyas https://github.com/PatilShreyas @samtstern
https://github.com/samtstern Let me know if you need more details. I
can give the code but this is more succinct way to get to the root of the
issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/firebase/FirebaseUI-Android/issues/1707?email_source=notifications&email_token=AEVWFOG4XUYGILXGHLYCST3QSFMNRA5CNFSM4JIO6NY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDCR76A#issuecomment-549789688,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEVWFOGWNCJT7NITFMUZLSDQSFMNRANCNFSM4JIO6NYQ
.

@abhilashi First of all, there are different adapters
FirebaseRecyclerAdapter and
FirestoreRecyclerAdapter
This API is tested before merging into repo. Can you provide your implemention so that I can assist you further.

@PatilShreyas thanks again for quick response.
The problem is in FirestoreRecyclerAdapter
Request you to look at your commit history on this adapter: FirestoreRecyclerAdapter
The very first time updateOptions is called, mOptions is null.

Here is the exception trace:
java.lang.NullPointerException: Attempt to invoke virtual method 'androidx.lifecycle.LifecycleOwner com.firebase.ui.firestore.FirestoreRecyclerOptions.getOwner()' on a null object reference
        at com.firebase.ui.firestore.FirestoreRecyclerAdapter.updateOptions(FirestoreRecyclerAdapter.java:106)
        at com.feelr.MainActivity.initOrUpdateMessagesInChat(MainActivity.kt:378)
        at com.feelr.MainActivity.onChatChanged(MainActivity.kt:114)
        at com.feelr.MainActivity.access$onChatChanged(MainActivity.kt:52)
        at com.feelr.MainActivity$initOrUpdateFriendsInNavDrawer$1$onBindViewHolder$1.onClick(MainActivity.kt:407)
        at android.view.View.performClick(View.java:6597)
        at android.view.View.performClickInternal(View.java:6574)
        at android.view.View.access$3100(View.java:778)
        at android.view.View$PerformClick.run(View.java:25889)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6746)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

@PatilShreyas @samtstern pl let me know if you need more details.

@abhilashi Please provide full activity implementation to trace what is going on.

@PatilShreyas @samtstern here is the code snippet that's throwing up. The call to updateOptions below.

   messagesInChatOptions = FirestoreRecyclerOptions.Builder<MessageModel>()
        .setQuery(messagesInChatQuery, MessageModel::class.java)
        .setLifecycleOwner(this)
        .build()

    if (messagesInChatAdapter == null) {
        messagesInChatAdapter = object :
            FirestoreRecyclerAdapter<MessageModel, MessageInChatViewHolder>(
                messagesInChatOptions!!
            ) {
            override fun onBindViewHolder(
                holder: MessageInChatViewHolder,
                position: Int,
                model: MessageModel
            ) {
               <REDACTED>
            }

            override fun getItemViewType(position: Int): Int {
                <REDACTED>
            }

            override fun onCreateViewHolder(
                parent: ViewGroup,
                viewType: Int
            ): MessageInChatViewHolder {
                return MessageInChatViewHolder(view)
            }

            override fun onDataChanged() {

            }
        }
        messagesInChatRecyclerView.adapter = messagesInChatAdapter
    } else {
        messagesInChatAdapter?.updateOptions(messagesInChatOptions as FirestoreRecyclerOptions<MessageModel>)
    }

@PatilShreyas the code is very simple - just calls updateOptions on FirestoreRecylerAdapter. If you want me to provide a sample activity I'll need to write one to give you. But if you have already tested before committing the code, could you please re-run those tests?

@abhilashi Thank you for this. Now I actually came to know what exactly happened. In FirestoreRecyclerAdapter, assignment of options to mOptions is missing in constructor that's why NullPointerException is being thrown.
It's my mistake!
@samtstern This issue should be fixed before releasing the new version.

Noted, thank you!

This has been released in FirebaseUI 6.1.0


Replaced DOMNodeRemoved event by MutationObserver

Fixes #.
DOMNodeRemoved event is now deprecated an unsupported by Chrome browser, in favor of MutationEvent.
The issue is that the tooltip remains on screen and page has to be reloaded for it to disappear, which is very disturbing for the user experience.

Changes proposed in this pull request:
Replaced the deprecated event by MutationObserver

We would love this here


Invoking an actor method can corrupt the name of registered reminders

In what area(s)?

/area runtime

/area operator
/area placement
/area docs
/area test-and-release

What version of Dapr?

0.8.0

Expected Behavior
Invoking an actor method should not impact registered reminders.
Actual Behavior
Invoking an actor method can corrupt the name of a registered reminder. The name of the executed reminder is altered such that it contains a portion of the invoked method name.
Steps to Reproduce the Problem

Register a reminder with a frequent period.

PUT http://localhost:3500/v1.0/actors/ExampleActor/1/reminders/displayBalance HTTP/1.1
content-type: application/json

{
  "dueTime":"0h0m5s0ms",
  "period":"0h0m2s0ms"
}

Verify the reminder has been added to actor state (redis).

actors||ExampleActor
[
  {
    "actorID": "1",
    "actorType": "ExampleActor",
    "name": "displayBalance",
    "data": null,
    "period": "0h0m2s0ms",
    "dueTime": "0h0m5s0ms",
    "registeredTime": "2020-07-03T03:21:41Z"
  }
]

Observe the registered reminder execute.

time="2020-07-02T22:22:39.923850725-05:00" level=debug msg="executing reminder displayBalance for actor type ExampleActor with id 1" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0
time="2020-07-02T22:22:41.92260195-05:00" level=debug msg="executing reminder displayBalance for actor type ExampleActor with id 1" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0

Invoke an actor method around the time when the registered reminder should fire.

POST http://localhost:3500/v1.0/actors/ExampleActor/1/method/deposit HTTP/1.1
content-type: application/json

{
	"amount":100
}

Observe a change in the name of the executed reminder.

time="2020-07-02T22:22:43.923292453-05:00" level=debug msg="executing reminder ositlayBalance for actor type ExampleActor with id 1" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0
time="2020-07-02T22:22:43.928440311-05:00" level=debug msg="error execution of reminder ositlayBalance for actor type ExampleActor with id 1: error from actor service: {\"statusCode\":500,\"message\":\"Internal server error\"}" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0
time="2020-07-02T22:22:43.928468763-05:00" level=debug msg="error invoking reminder on actor ExampleActor||1: error from actor service: {\"statusCode\":500,\"message\":\"Internal server error\"}" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0
time="2020-07-02T22:22:45.922849144-05:00" level=debug msg="executing reminder ositlayBalance for actor type ExampleActor with id 1" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0
time="2020-07-02T22:22:45.927118101-05:00" level=debug msg="error execution of reminder ositlayBalance for actor type ExampleActor with id 1: error from actor service: {\"statusCode\":500,\"message\":\"Internal server error\"}" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0
time="2020-07-02T22:22:45.927157775-05:00" level=debug msg="error invoking reminder on actor ExampleActor||1: error from actor service: {\"statusCode\":500,\"message\":\"Internal server error\"}" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0

Verify the reminder in actor state is unchanged.

actors||ExampleActor
[
  {
    "actorID": "1",
    "actorType": "ExampleActor",
    "name": "displayBalance",
    "data": null,
    "period": "0h0m2s0ms",
    "dueTime": "0h0m5s0ms",
    "registeredTime": "2020-07-03T03:21:41Z"
  }
]

Stop and restart the actor app. Observe the executed reminder name is no longer corrupt but now executes twice for each period.

time="2020-07-02T22:51:35.639691463-05:00" level=info msg="dapr initialized. Status: Running. Init Elapsed 3890.906091ms" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime type=log ver=0.8.0
time="2020-07-02T22:51:37.667281911-05:00" level=debug msg="executing reminder displayBalance for actor type ExampleActor with id 1" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0
time="2020-07-02T22:51:37.675129908-05:00" level=debug msg="executing reminder displayBalance for actor type ExampleActor with id 1" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0
time="2020-07-02T22:51:39.667934685-05:00" level=debug msg="executing reminder displayBalance for actor type ExampleActor with id 1" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0
time="2020-07-02T22:51:39.678994512-05:00" level=debug msg="executing reminder displayBalance for actor type ExampleActor with id 1" app_id=example-nodejs-actors instance=ubuntu1804 scope=dapr.runtime.actor type=log ver=0.8.0

@cjlpowers are you always hitting this or is this:

Invoke an actor method around the time when the registered reminder should fire.

a necessary step?

I do not think that step is necessary. I can reproduce it locally and in AKS by invoking a method within the idle time of a 5s recurring reminder.

@LMWF I have been testing with v0.9.0 and have not been able to reproduce the problem so far. I could repo easily in v0.8.0.

@cjlpowers I believe this is not repro since v0.8.0?

@cjlpowers : I am trying to debug a similar issue. Could you share some details about your env?

Are you using any particular sdk?
Sample code from the client that you were able to repro the issue with?

This issue was caused by a bug in the fast http router introduced in release-0.7.0. PR: #1978 which pulled in the latest fast http router version fixed the issue.


Can you add bulk mark and unmark feature?

As I mentioned in the topic title, I don't want to dump all the functions.

Hey and thanks for the suggestion.
Have a look here: https://gist.github.com/StephenNneji/14bfc4e7a322ec89df7d30847fbf19b3
Happy to receive a PR for that. If it gets complicated, you can also add a simple button below that changes its text based on the item's status in the table. Also see comment here: https://github.com/giladreich/ida_migrator/blob/3893217e5d79d1ffb62b8742dafbf18ce94cb657/source/ida_migrator/migrator_dialog.py#L89-L101
I might have time to look at it in one of the next weekends.


Use of dot notation 'default' breaks IE8

Looks like this happened in the 4.0.1 release, might be related to the Babel 6 upgrade but I'm not positive.
dist/react-redux.js:
	function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

	exports.Provider = _Provider2.default;
	exports.connect = _connect2.default;

I think adding es3 transforms (es3-member-expression-literals, es3-property-literals) to the babel config will fix it, I'll check tonight.

I'm on it

Thanks :+1:

Unfortunately those transforms aren't currently helpful because of a bug: https://phabricator.babeljs.io/T2817. I'll have to go back to using CommonJS internally until this is fixed.

Ok, it's not a high priority issue for me, the webpack workaround isn't too bad:
// webpack config for string-replace-webpack-plugin
{
  pattern: /\.default(?=[^\w$])/g,
  replacement: function () {
    return "['default']"
  }
},
{
  pattern: /\{\sdefault:/g,
  replacement: function () {
    return "{ 'default':"
  }
}

It's still a breaking change we need to fix though. Which is not fun. :-( I think we'll go with requiring ES5 environment in the next version, and will ask people to es3ify or equivalent if they need IE8.

Please verify whether this is fixed in 4.0.6.

Verified fixed, thanks.


[BUG] Debug transcoding failures

Describe the bug
Some user uploads fail to transcode.  We should figure out why.
Related data
https://viame.kitware.com/#/folder/5e97308a95a54f6165d90dbf
There may be more info in girder logs or sentry.

This has not happened in many months.  Closing due to inactivity.

Above datasets have moved.  Here's another failure example unrealted to #426
https://viame.kitware.com/girder/#folder/60243f5c4d85a3cb4e2250c8


Providers from interfaces?

Describe the bug
When using wire on the following example code, it will fail:
To Reproduce
package main

import "github.com/google/wire"

type Thing struct{}

type Fooer interface {
	MakeThing() Thing
}

type foo struct{}

func (*foo) MakeThing() Thing {
	return Thing{}
}

func NewFoo() *foo {
	return &foo{}
}

func Init() (Thing, error) {
	wire.Build(
		NewFoo,
		wire.Bind(new(Fooer), new(*foo)),
	)
	return Thing{}, nil
}

...with
wire: /Users/stephan/go/src/github.com/srenatus/wire-example/wire.go:21:1: inject Init: no provider found for github.com/srenatus/wire-example.Thing, output of injector
wire: github.com/srenatus/wire-example: generate failed
wire: at least one generate failure

Expected behavior
It would have been nice if wire had figured out that the Fooer interface has a provider for Thing. Alternatively, there might just be something I've missed -- What do I need to add to the wire.Build call to make this work? 😃
Version

master as of yesterday, ed1f30e1e8cc03225f15f4bb986f870c4c6dd394

Additional context
System details
go version go1.11.3 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/stephan/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/stephan/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.11.3/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.11.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
GOROOT/bin/go version: go version go1.11.3 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.11.3
uname -v: Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.14.5
BuildVersion:	18F132
lldb --version: lldb-1<IP_ADDRESS>
  Swift-5.0

I think you can get this to work by adding a new provider for Thing given a Fooer:
func MakeThing(f Fooer) Thing {
  return f.MakeThing()
}

I don't think it's feasible to treat all interface methods (or, more broadly, all methods) as providers. They are too likely to conflict (e.g., two methods that both return string).

I don't think it's feasible to treat all interface methods (or, more broadly, all methods) as providers.

Is this so dissimilar from the struct case? Where either any selected struct field (or "*", all of them) can be marked as providers?
Just wondering 😃

Ah, I forgot we added FieldsOf. @shantuo / @zombiezen care to comment about whether it would be feasible to do something similar for interfaces?

I think this case would probably be covered by #7 - you could add Fooer.MakeThing to the Build call and it would act as a suitable function for making a Thing given a Fooer.
This is arguably related to a case I've been thinking about: function-valued field values as providers, but I think that's enough different that I'm going to raise another issue for that.

I agree with @rogpeppe: #7 is the right fix for this. Interface methods are valid for method expressions, so the wire.Build call in the above example would become:
wire.Build(
  NewFoo,
  wire.Bind(new(Fooer), new(*foo)),
  Fooer.MakeThing,
)

Thanks! Closing in favor of #7 then.


Improve UX when loading images

Backport https://github.com/Chainlit/chainlit/pull/1402 already merged from main/development branch 2.X into releases/1.3

Currently when adding images in the conversation, if the image is big and is not that clear, clicking in the image will attempt to download the image.
This PR attempts to improve the UX a bit by just opening the image in a new window (aka popup) to see the image larger. It has a download option on this new popup as well to preserve the original download behavior, but now the UX is a bit better

Thanks but... We're doing semver now, so the next release adding features would be 1.4 -- but we might just jump right to 2.0 (as we've limited capacity to maintain older code). 1.3 will receive only fixups.


Could not proxy command to the remote server

Getting could not proxy command to the remote server error on pretty much every other test run.  There is only one test that runs on one Mac mini so it shouldn't be a matter of resources.  Please help.
MacOS 12.4
Appium 2.0.0-beta.43
Xcode Version 13.4.1 (13F100)
Node v18.4.0
Appium Server start command:
appium --allow-insecure=apple_script -p 4723 --log appium.log
[HTTP] --> POST /session/2037b0d1-50ba-4fae-bf79-1b1f1da41b33/element
[HTTP] {"using":"-ios class chain","value":"**/XCUIElementTypeButton[`title == \"Profiles\"`]"}
[debug] [Mac2Driver@25bf (2037b0d1)] Calling AppiumDriver.findElement() with args: ["-ios class chain","**/XCUIElementTypeButton[`title == \"Profiles\"`]","2037b0d1-50ba-4fae-bf79-1b1f1da41b33"]
[debug] [Mac2Driver@25bf (2037b0d1)] Valid locator strategies for this request: id, name, accessibility id, xpath, class name, -ios predicate string, predicate string, -ios class chain, class chain
[debug] [WD Proxy] Matched '/element' to command name 'findElement'
[debug] [WD Proxy] Proxying [POST /element] to [POST http://<IP_ADDRESS>:10100/session/39D226D6-E7AE-473E-A7D3-7999E065006F/element] with body: {"using":"class chain","value":"**/XCUIElementTypeButton[`title == \"Profiles\"`]"}
[WD Proxy] connect ECONNREFUSED <IP_ADDRESS>:10100
[debug] [Mac2Driver@25bf (2037b0d1)] Encountered internal error running command: UnknownError: An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: connect ECONNREFUSED <IP_ADDRESS>:10100
[debug] [Mac2Driver@25bf (2037b0d1)]     at WDAMacProxy.command (/Users/gandalfqe/.appium/node_modules/appium-mac2-driver/node_modules/@appium/base-driver/lib/jsonwp-proxy/proxy.js:342:13)
[debug] [Mac2Driver@25bf (2037b0d1)]     at processTicksAndRejections (node:internal/process/task_queues:95:5)
[debug] [Mac2Driver@25bf (2037b0d1)]     at Mac2Driver.findElOrEls (/Users/gandalfqe/.appium/node_modules/appium-mac2-driver/lib/commands/find.js:17:10)
[debug] [Mac2Driver@25bf (2037b0d1)]     at Mac2Driver.findElOrElsWithProcessing (/Users/gandalfqe/.appium/node_modules/appium-mac2-driver/node_modules/@appium/base-driver/lib/basedriver/commands/find.js:80:16)
[debug] [Mac2Driver@25bf (2037b0d1)]     at Mac2Driver.findElement (/Users/gandalfqe/.appium/node_modules/appium-mac2-driver/node_modules/@appium/base-driver/lib/basedriver/commands/find.js:21:14)

https://github.com/appium/appium-uiautomator2-driver#socket-hangup-error

Thanks, Mykola.  So it seems as though I'm getting this issue because of the session replacement.  Does this happen when one session times out?
[debug] [WD Proxy] Got response with status 200: {"value":null,"sessionId":"9991B2D7-EC8A-4387-9E95-30B31AAD011A"} [WD Proxy] Replacing sessionId 9991B2D7-EC8A-4387-9E95-30B31AAD011A with b59608ae-8782-4867-ad0a-67cf6163115a [HTTP] <-- POST /session/b59608ae-8782-4867-ad0a-67cf6163115a/element/E28CA650-4625-43F4-B8E7-7B098279A867/click 200 763 ms - 65

No, this is a normal behaviour. the internal session identifier that the server has is different from the one your local client uses, so it must be replaced in order to proxy it properly

So is there a new session created for every application under test?  If so, does the client change the sessionid automatically?

A new session is created every time https://w3c.github.io/webdriver/#dfn-new-sessions request is received.

If so, does the client change the sessionid automatically?

Not sure what you mean

Thanks Mykola


make this cftime until the feedstock is created

@jhamman we will archive this feedstock once the proper one is created.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


PDCL-9192 - add propositionEventType to experience event for better proposition interaction handling

Description

Description of the problem this PR solves is in this wiki
https://jira.corp.adobe.com/browse/PDCL-9192

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[x] I have made any necessary test changes and all tests pass.
[x] I have run the Sandbox successfully.

Backend changes for this are due next sprint (Sept 14-28).  I've tested this change locally in sandbox app and verified it is backward compatible.

@dcottingham do we plan to update the documentation with the new way of sending display and click notifications? This is related to the notifications that are sent by the customer.

@dcottingham looks good to me! Thank you!
I would add only one general comment, ideally when we augment the existing functionality and it should be backward compatible, we should add a new functional test that would test the new behavior and leave the existing ones test the old behavior. cc: @jonsnyder @carterworks

@ninaceban Do you want me to revert all the updates I made to the functional test cases and create some new ones then?  I only added new assertions to the existing test cases.  I hadn't removed or modified existing assertions.  If I create new tests they will be functionally the same as the ones I updated, just different assertions.  But happy to do that if that's the preferred approach.

I think using the existing functional test is fine in this case. You are not adding functionality, but updating the format of the current functionality.


Use Imgur for image storage

Is it possible to modify the current models and stuff to use Imgur for file storage instead of needing to get a s3 container or something like that.

https://apidocs.imgur.com/

https://apidocs.imgur.com/

https://github.com/Imgur/imgurpython

https://github.com/Imgur/imgurpython

From what i understand all you need to do is change the save function add a few settings and change the url

From what i understand all you need to do is change the save function add a few settings and change the url

This would be amazing for someone who wants to use heroku for free hosting something like mongodb for 1 gigabyte of database storage and imgur for near unlimited image storage so someone could have a blog and it would only cost them the domain name (plus heroku hobbist but im sure theres a way to get arround that.)

This would be amazing for someone who wants to use heroku for free hosting something like mongodb for 1 gigabyte of database storage and imgur for near unlimited image storage so someone could have a blog and it would only cost them the domain name (plus heroku hobbist but im sure theres a way to get arround that.)

Sounds good. It could be done by using imgur as storage of django. e.g. https://github.com/preetamherald/django-imgur

Sounds good. It could be done by using imgur as storage of django. e.g. https://github.com/preetamherald/django-imgur


doc: "Go's New Brand" / Brand Book (pdf)

Most probably it's a non-issue, though changing to Go proportionally-spaced font from Go monospaced on p19 in the Brand Book (pdf) might make the Brand Book more branded.
https://golang.org/s/brandbook
What did you do?
Had a look at the pdf.
What did you expect to see?
When I saw the Go font mentioned, I expected the text in proportionally-spaced font.
What did you see instead?
Text in monospaced font.

CC @spf13

why do you think gofmt assumes a monospaced font?

https://play.golang.org/p/449FGn_GKVu

type Foo struct {
	Short            io.ReadWriteCloser // comment
	LongLongLongLong int                // comment
}

When gofmt formatted this, it assumes monospacing for printable characters and whitespace.

Although, the assumption breaks down with non-English characters, which tend not to be same length as space:
type Foo struct {
	_               io.ReadWriteCloser // comment
	X敏捷的棕毛狐狸从懶狗身上跃过 int                // comment
}

Fullwidth characters should be the same width as two spaces in a monospace font, although some browsers and platforms do not correctly align glyphs from fallback fonts for display (see https://crbug.com/807361 and  https://denisbider.blogspot.com/2015/09/when-monospace-fonts-arent-unicode.html), and a few characters have ambiguous widths.
If gofmt doesn't handle unambiguous fullwidth characters correctly, that's a separate bug we should file.

But I'm pretty sure the Go font doesn't support any fullwidth characters anyway, so that problem is more-or-less moot when that font is involved.

thanks!
It's funny, I just realised

for the last 8 years I've never needed to look at the first section of
golang.org/cmd/gofmt and
I've never cared for alignment, when grouping was rarely needed, I've
always grouped with explicitly descriptive names+descriptions.

On Fri, Apr 27, 2018, 20:01 Bryan C. Mills<EMAIL_ADDRESS>wrote:

why do you think gofmt assumes a monospaced font?
https://play.golang.org/p/449FGn_GKVu
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/25123#issuecomment-385048207, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AE6u4FfLVoUiFnGuVohfOqwgmUvKQXs0ks5ts10VgaJpZM4TqEKh
.

I've gone back and forth, eventually settling on the proportional one. The gofmt has never even been a consideration for the decision--it seems to do its job well regardless.
Most people I've asked find gomedium most visually-appealing.

As the usage of the Go font is intended for source code and the monospaced version of the font is designed for source code we believe the brand book is correct in using the monospaced one.


[Feature Request] Make it default to read from .env-files

Currently uv requires extra explicit settings to specify an .env-files, either by passing --env-file .env or an environmental variable UV_ENV_FILE. Since it has become a consensus to read environment variables from .env-files, it seems natural to make this a default behavior if any .env-file is detected, while allowing explicit setting --no-env-file flag or UV_NO_ENV_FILE environmental variable to disable this default loading. Node.js interpreter commands, like npm run and bun run, do the same thing.

There was a great deal of controversy about this when we added it initially, please see the discussion leading up to https://github.com/astral-sh/uv/issues/1384#issuecomment-2455270920.


Still using Ublue's Secure Boot key that built by this template?

I've noticed that my Secure Boot is still valid after I rebased to my custom images, it this a security concern?
Though your repo needs to be public to freely publish images to ghcr.io, but it can still being used by bad actors before it takedown by GitHub, isn't it?

This is not a security concern. Everything in the stack is still signed with Ublue's key, regardless of whether you're using a custom image or not.


[Hub Generated] Render v1/v2 reconciliation

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue as per review at azure-maps-render - rev 0
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. Services are already deployed.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[X] No refresh required for updates in this PR

Contribution checklist:

[X] I commit to follow the Breaking Change Policy of "no breaking changes"
[X] I have reviewed the documentation for the workflow.
[X] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy. Breaking changes according to not-yet-deployed Azure Maps Render services to address @tjprescott's review for azure-maps-render - rev 0
Please follow the link to find more details on PR review process.

@daniel-rocha: As per out discussion, this is probably good for @tjprescott review, will later look into possibility of adding the description functionality to x-ms-parameter-group extensions, so it can provide parameter description.

This explanation does not make sense to me. Otherwise, every service that releases a new API version would need to rename their operation IDs for documentation purposes, and the reality is that no services do that, so Maps should not do that either.

then the documentation preview will fail to generate if render.json from two versions are changed at the same time, is that fine?


Innr Plug not shown in overview

Hi, I bought an outlet from Innr, the Innr Smart Plug. I connected it to my Homebridge, and in the log output I can see that it connected successfully, and regularly it pings my outlet. But I can neither see the outlet in the web view not in the Home-App. I use the latest Homebridge, latest homebridge-zigbee and Node 10.

I've now added this code to the devices list in /lib/devices
const HomeKitDevice = require('../HomeKitDevice')

class InnrSmartPlug extends HomeKitDevice {
  static get description() {
    return {
      model: 'SP 120',
      manufacturer: 'innr',
      name: 'Innr Smart Plug',
    }
  }

  getAvailbleServices() {
    return [{
      name: 'Outlet',
      type: 'Outlet',
    }]
  }

  onDeviceReady() {
    this.mountServiceCharacteristic({
      endpoint: 1,
      cluster: 'genOnOff',
      service: 'Outlet',
      characteristic: 'On',
      reportMinInt: 1,
      reportMaxInt: 2,
      reportChange: 1,
      parser: 'onOff',
    })
  }
}

module.exports = InnrSmartPlug

Now the plug is listed in Homebridge. The problem with this code is that it ignores the capability of the plug to measure energy consumption, but I have no idea how to add this to the code.

You probably need to add the characteristic for energy consumption.
Check your zigbee.db, your device should have endpoints.clusters, one of them should be for that purpose.
Also take a look at lib/devices/lumi.ctrl_86plug.js which seems to have support for energy consumption.

I've noticed a problem. The official npm version 1.3.0 does not support energy consumption. The GitHub Version does, but the maintainer did not release a new version since then.

I managed to "use" the latest git version. But I saw that homebridge-zigbee doesn't have the right parser. I try to build one, but first I have to understand the technique behind it. Hopefully I manage to create a correct implementation.


paste image into flex container

Problem
Images are always inserted as absolute positioned elements when pasted, which can be a frustrating surprise when the image is pasted into a flex container
Fix
Check if the target parent is a flex container, and don't add any positioning props if it is.
TODO

[ ] tests

commit 0ea1d10 looks good, the rest of the diff seems like contains your other PR

thanks! 😬


Enable Link-Time Optimization (LTO)

Hi!
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.
I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.
Basically, it can be enabled with the following lines:
[profile.release]
lto = true

I have made quick tests (Fedora 41) by adding lto = true to the Release profile. The binary size reduction is the following:

lumen: from 5.1 Mib to 3.5 Mib

Thank you.

Hi. Appreciate your feedback.
Would you like to open a PR for this?

Would you like to open a PR for this?

Yeah: https://github.com/jnsahaj/lumen/pull/2


"sync_exclude" flag for Spends and Outputs

We want to be able to mark Spends/Outputs as not to be included in CompactBlocks after submission for high-volume applications, to make the view server more efficient on sync. We can do this by adding a new flag to Spends and Outputs, sync_exclude
To do this we can:

[x] Add another map() to note_payloads in finalize_compact_block to filter out relevant payloads based on this flag

[x] Modify Spend action to add the exclude flag

[x] Modify  SctManager:StateWrite:nullify to accept an additional argument to exclude from pending_nullifiers

[ ] https://github.com/penumbra-zone/penumbra/issues/4407

[ ] https://github.com/penumbra-zone/penumbra/issues/4408

[ ] Set CompactBlock cost to 0 where sync_exclude is true

[ ] Downstream the necessary modification side-effects to the web-side, if applicable

Questions

Do we want to store the associated notes and nullifiers in the view service on submission to maintain a historical record on the originating instance? Or do we need to provide for this at all?
Do we want to provide a "full sync" option that includes the "sync_exclude" transactions? This would allow someone to opt-in to the less efficient but more complete behavior currently implemented in the view server.

We'll want to consider how this affects FMD (currently we have a rule of 1 clue per output, this should probably be 1 clue per sync included output, right?) and what the plan for syncing is, so we can be sure the feature works end to end.


Compiling error when try to run linux default build via ninja

Hi perfetto team,
I'm facing a problem when I tried to build linux build with perfetto trunk resource by ninja:
../../src/profiling/memory/malloc_interceptor_glibc_preload.cc:102:7: error: no previous prototype for function 'reallocarray' [-Werror,-Wmissing-prototypes]
void* reallocarray(void* ptr, size_t nmemb, size_t size) {
^
../../src/profiling/memory/malloc_interceptor_glibc_preload.cc:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void* reallocarray(void* ptr, size_t nmemb, size_t size) {
^
is this a problem of my compiler or a breakage in code?
thanks

This is almost certainly a problem with your environment. My suspicion is that your glibc is older that 2.29 which is when reallocarray was first introduced in stdlib.h according to https://www.unix.com/man-page/linux/3/reallocarray/

HI Lalit, yes, you were right, after updating my glibc, no more compiling errors.
thanks and happy holiday