modify Mocha constructor to accept options.global or options.globals

Fixes https://github.com/mochajs/mocha/issues/3913
Description of the Change
The docs say:
Updated in v6.0.0; the option is --global and --globals is now an alias.
and the inline docs say:
 * @param {string[]} [options.global] - Variables expected in global scope.
(Note the singular options.global)
but when creating a Mocha instance programmatically, only options.globals is accepted. Test repo here: https://github.com/pascalpp/mocha-globals-repro

Alternate Designs
n/a
Why should this be in core?
Minor change to Mocha instance API to match documentation.
Benefits
Users who expect options.global to work the same as the command-line option will not wonder why it doesn't.
Possible Drawbacks
Not sure. All existing tests pass with this change. I also added some new tests to test this change directly.
Applicable issues
https://github.com/mochajs/mocha/issues/3913

Not sure if this should be considered a breaking change, an enhancement, or a bug fix.

Coverage increased (+0.07%) to 91.888% when pulling 59dece3f98e7a17c2a5850597c8c6f4b05f9987b on pascalpp:issue/3913 into ffbcbf63a447f67681b901979dde5d2c70919d24 on mochajs:master.

Working on a couple test additions now

@pascalpp thanks for this PR.
Option aliases are defined for command-line usage, I don't think we should allow all of them within Mocha's constructor. Some options have up to two aliases and camelcased versions are allowed as well. IMO we should allow only canonical option names within the constructor, no aliases. Unfortunately this would be a breakage change.
Nevertheless the constructor parameter names should fit the names used in the body. There are more options which seem to be wrong like reporterOption, useInlineDiffs.

@juergba Understood. Maybe just an update to the documentation is in order? At least here: https://github.com/mochajs/mocha/blob/master/lib/mocha.js#L79

No, just changing the documentation is too superficial. If you really want to solve this bug, then more investigations are required:

you can't easily change the parameter of the constructor, it's part of the API and would be a breaking change.
you can run mocha programmatically and per CLI, the solution has to work both ways.
.globals(options.globals);: after running this function, we have all entries doubled, why?
there are more buggy options (reporterOption, useInlineDiffs)

@juergba:

you can't easily change the parameter of the constructor, it's part of the API and would be a breaking change.
you can run mocha programmatically and per CLI, the solution has to work both ways.

Should both APIs be consistent with each other? The mocha CLI accepts--global or --globals, so I was trying to make the constructor API consistent with that. Allowing the constructor to accept both would also keep this from being a breaking change, as existing implementations using options.globals would continue to work.

.globals(options.globals);: after running this function, we have all entries doubled, why?

Hmm, yes that is odd. Looks like the constructor is caching the options on itself:
this.options = options

and then calling this.globals(options.globals), which is concatenating them onto the same array:
Mocha.prototype.globals = function(globals) {
  this.options.globals = (this.options.globals || [])
    .concat(globals)
    .filter(Boolean);
  return this;
};

I'm guessing it's done this way so the globals method could be called on an instance to add more globals after instantiation. So I think this method should filter unique entries. Although it's adjacent, I think that could be treated as a separate issue with its own PR. I'll open one and ping you on it.

there are more buggy options (reporterOption, useInlineDiffs)

Seems like it would be simpler to open separate issues for those?

Please don't open new issues/PRs for subareas of this topic, this may be helpful for complex tasks, but not for this one.
The current situation is buggy. I suggest:

options.global is our principal parameter.

CLI: global and globals are aliases, so there parsed values are identical
programmatically: the constructor asks for : @param {string[]} [options.global]

.globals(options.globals);: should therefore be .globals(options.global);
Mocha#globals: for backwards compability accepts also options.globals

Mocha.prototype.globals = function(global) {
  this.options.globals = []
    .concat(global || this.options.globals || [])
    .filter(Boolean);
  delete this.options.global;
  return this;
};

So the values don't get concatenated , it counts either options.global (or options.globals).
Your thoughts?

@juergba

Please don't open new issues/PRs for subareas of this topic, this may be helpful for complex tasks, but not for this one.
Gotcha, sorry, that's just how I'm used to working in my day job. : )

Is calling mocha.globals(array) on an existing mocha instance supported? Or should Mocha only allow adding globals in the constructor? The method is marked as public but I'm not clear on how useful it is to be able to call that method directly, or if any/many Mocha installs rely on that capability.
If it's correct for it to be public, then what should the expected behavior be? Currently calling it after instantiation just adds more globals to the list (even if they're dupes); but the solution you have above replaces the list with the new globals passed in. So that might be a breaking change?
I think the general pattern used in the constructor is a bit strange, stashing this.options = options and then calling various methods which also modify this.options. I think it would be cleaner for the constructor to just create this.options = {} and then call the various methods and let them handle updating this.options.
Anyway let me know your thoughts on whether Mocha#globals should be a public method, and whether it should add globals to the list, or replace the list.

Yes, you are right, it's a public function.
I don't know neither what the expected behavior should be. But ... I don't want a breaking change.
So, next try, close to your proposition:

.globals(options.global);: change to .globals(options.global || options.globals);
add a short comment like "options.globals for backwards compatibility" or similar
distinct values: I prefer this solution (it's not my creation):
.filter(function(elt, idx, arr) {return arr.indexOf(elt) === idx;});
delete this.options.global as above
please also fix the first (dead) link in the API doc

Okay that all makes sense. One thing I wonder though, is if the options.global || options.globals stuff should be handled in the constructor, which is where the options are originally consumed. Then Mocha.prototype.globals can just focus on adding whatever globals are passed in, and ensuring they're unique. I'll update this PR with that idea and you can comment in your review.

I'll update this PR with that idea [...]

Yes, go ahead. My comment above was meant your way, as you originally have proposed ...

oh i think I found what you're referring to: the API doc is linking to
https://mochajs.org/#--globals-names
which should be
https://mochajs.org/#-global-variable-name
will fix.


photoUrl is broken when using custom popup

Hi, the "photoUrl" feature seems to work only when using default popups.
https://github.com/dceejay/RedMap/blob/master/worldmap/worldmap.js#L1368
When using custom popups, wouldn't it be nice to have a $photoUrl, as there is e.g. $name for replacements in the contextmenu ?

If it's being passed a fully custom popup you can add whatever images/links you want, and set the size appropriately, whereas $photourl is/was a leftover from when that capability didn't exist and is/was a way to just add an image to the popup. If anything it should be deprecated I think.

I see, thanks !


unable to type backslash \ in terminal

Hello, this is by far the best terminal package for Atom. Nice work!
One issue I have is I can't type a backslash (\) in the terminal. I can get by without it, but thought I'd open an issue. Any ideas?

Hi @trusktr,
Sorry for the late reply. :smile: What OS/distro are you using? I can't replicate this on Windows 7 or any Linux distro I've tried.
Cheers!
Fred


Update deprecated and removed kernel options

Fixes: https://github.com/orgs/ManageIQ/discussions/23119

Is this compatible to older RHEL (el8 or even less) and non-RHEL, like Ubuntu - interestingly the changes you made in the specs just forced it into RHEL6 and ubuntu, but I'm not sure that's a "real" configuration.


Makyen: Watch iMusafir.pk

Makyen requests the watch of the watch_keyword iMusafir\.pk. See the Metasmoke search here and the Stack Exchange search here.

iMusafir\.pk has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Coverage remained the same at 65.558% when pulling cedcae4adad0d4c1c868c33440d898ddb38589ea on auto-blacklist-1522652996.4189343 into 35fa5a4afe11c4699e39d2a7a390d3dd42777bf6 on master.

!!/approve


Don't print console logs if all tests pass

If all the #[wasm_bindgen_test]s pass, then we shouldn't spam the console with the console.log output.

I could see some friction if whether or not I saw my quick little prints was determined by whether or not my tests were passing at that time.

You can always add an assert!(false) to a test to make it fail.
Although the --nocapture approach is much nicer.
I'd very much welcome console log output capturing. If you log a lot, it's very hard to see what's going on.

You can always add an assert!(false) to a test to make it fail.

Sorry not to bikeshed here ........ but this wouldn't work for me as I'll sometimes toss a quick log in just to see if a code path was followed so if I forgot to add a false assertion I'd wrongly think that it wasn't until I remembered that my logs were hidden at the moment because tests were failing.
--nocapture sounds like it works for everyone though!


Multiple footnotes on same slide out-of-order

When there are multiple footnotes on the same slide, the footnote will not be rendered in the order of when first appeared.
[^1] [^2] [^3]

[^1]: fn1
[^2]: fn2
[^3]: fn3

gets

I was able to get rid of this issue by removing the g flag in regex in footnote processor, although I am not sure why this flag is needed... 😶🌫

will be fixed with 1.7.0


Accept multiline as input in command palette

Accept multiple lines as input in command palette like for stash messages
currently only single line is supported.

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Computer shader support

Glad to see so many improvements. If async computer shader can be supported, that will be wonderful.
Also, wgpu supports render bundle now, using render bundle can get rid of generating draw calls repeatedly.
Great work.

Compute shader's are supported since the lighting refactor work that introduced froxels. I should write up an example showing how to use them however.
As for render bundles, I need to look into them a bit closer. I have some unanswered questions about them before I start adding them in or using them internally.


UserProperties is deprecated.

Class UserProperties is deprecated.
They are used in follow code.
https://github.com/Tetsunori-Mitarai/S3-for-Google-Apps-Script/blob/master/testSupport.gs
/**
 * sets a testing Env, that's accessible from test and demo functios; and persistent for user
 *
 * @param {Object} env the environment object to set for testing (should have awsAccessKeyId, awsSecretKey as properties)
 * @return {void}
 */
function setTestEnv(env) {
  var userProperties = PropertiesService.getUserProperties();
  userProperties.setProperty(TEST_ENV_NAME_, JSON.stringify(env))
  //just to this to check
  var env = getTestEnv();
}

/**
 * gets Test Env for the library, optionally skipping validing that all req constants are defined in that env
 *
 * @param {boolean}
 * @return {Object} key-value for the environment
 */
function getTestEnv(skipEnvValidation) {
  var propertiesService = PropertiesService.getUserProperties();
  Logger.log(propertiesService.getProperty);
  var env = JSON.parse(propertiesService.getProperty(TEST_ENV_NAME_))
  if (!skipEnvValidation) {
    var requiredKeys = ["awsAccessKeyId", "awsSecretKey"];

    if (env == null) {
      throw "Must set environment in UserProperties (see setTestEnvFromUI)";
    }

    for (var i=0, len=requiredKeys.length; i < len; i++) {
      if (typeof env[requiredKeys[i]] == 'undefined') {
        throw "Test Environment is missing required property '" + requiredKeys[i] + "'.  Define it object passed to setTestEnv().";
      }
    }
  }
  return env;
}

userProperties.setProperty is using just a instance.


Training crashes on second epoch with "Unable to unpickle data from other workers"

Hello team,
I would like to ask more info on an error that I hit when training on my 8GPUs machine. The problem is that the training crashes when it is almost at half of the second epoch, this is the interesting part of training log:
| epoch 002:  15200 / 41687 loss=3.211, nll_loss=1.497, ppl=2.82, wps=33227, ups=0, wpb=81220.032, bsz=4526.620, num_updates=56888, lr=0.000132584, gnorm=0.213, clip=0.000, oom=0.000, wall=141888, train_wall=135650
| epoch 002:  15300 / 41687 loss=3.211, nll_loss=1.497, ppl=2.82, wps=33230, ups=0, wpb=81221.187, bsz=4526.611, num_updates=56988, lr=0.000132467, gnorm=0.213, clip=0.000, oom=0.000, wall=142130, train_wall=135888
Traceback (most recent call last):
  File "/home/ubuntu/.local/bin/fairseq-train", line 11, in <module>
    load_entry_point('fairseq', 'console_scripts', 'fairseq-train')()
  File "/home/ubuntu/workspace/fairseq/fairseq_cli/train.py", line 403, in cli_main
    nprocs=args.distributed_world_size,
  File "/home/ubuntu/.local/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 167, in spawn
    while not spawn_context.join():
  File "/home/ubuntu/.local/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 114, in join
    raise Exception(msg)
Exception:

-- Process 5 terminated with the following error:
Traceback (most recent call last):
  File "/home/ubuntu/workspace/fairseq/fairseq/distributed_utils.py", line 151, in all_gather_list
    result.append(pickle.loads(bytes(out_buffer[2 : size + 2].tolist())))
_pickle.UnpicklingError: invalid load key, '\x16'.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/.local/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 19, in _wrap
    fn(i, *args)
  File "/home/ubuntu/workspace/fairseq/fairseq_cli/train.py", line 380, in distributed_main
    main(args, init_distributed=True)
  File "/home/ubuntu/workspace/fairseq/fairseq_cli/train.py", line 106, in main
    train(args, trainer, task, epoch_itr)
  File "/home/ubuntu/workspace/fairseq/fairseq_cli/train.py", line 141, in train
    log_output = trainer.train_step(samples)
  File "/home/ubuntu/workspace/fairseq/fairseq/trainer.py", line 221, in train_step
    [logging_outputs, sample_sizes, ooms, self._prev_grad_norm],
  File "/home/ubuntu/workspace/fairseq/fairseq/distributed_utils.py", line 155, in all_gather_list
    'Unable to unpickle data from other workers. all_gather_list requires all '
Exception: Unable to unpickle data from other workers. all_gather_list requires all workers to enter the function together, so this error usually indicates that the workers have fallen out of sync somehow. Workers can fall out of sync if one of them runs out of memory, or if there are other conditions in your training script that can cause one worker to finish an epoch while other workers are still iterating over their portions of the data.

The error is totally deterministic: if I re-run the training, it start from checkpoint 56000 and it will crash again after update 56988.
So my understanding is that one of the workers run out of GPU RAM and crashes. If this is the problem, how can it be possible? If the training has already seen the whole dataset (because no error has been thrown during first epoch), how can it crash on the same dataset?
Given this evidence, we suppose that, while the dataset is exactly the same, the batches are created differently for every epoch (but in a deterministic way!). So here, we are unlucky, and a new dataset created at epoch 2 is a combination of sentence pairs that is too large for our GPU RAM. Is this possible or are we're barking up the wrong tree?
Thanks for your help!

The order of the batches are completely deterministic for a given seed/epoch, so it’s good news that resuming from a checkpoint fails at the same time :) This is likely an OOM, which can sometimes happen if there is memory fragmentation due to PuTorch’s caching memory allocator. Can you try resuming training using a different --seed? If it works, then it’s probably just an unlucky arrangement of batches that causes OOM due to fragmentation. If it fails, then maybe something else is wrong...

Hi @myleott turns out you're right!
I copied the data on a V100 GPU machine and restarted the training just for the time of 1 more checkpoint. I noticed that for 2 GPUs the RAM was above 12G, that explains why training crashed on my 11G setup.
After the new checkpoint has been saved, I moved all back to my original setup and restarted the training. Everything works as expected!
Thanks for you help, I now understand a bit more how fairseq works internally :)


Currency processing

          Some regression seems to be caused by currency processing.

Originally posted by @olejandro in https://github.com/samwebster/times-excel-reader/issues/58#issuecomment-1473071509

[ ] update ground truth for TIM
[ ] remove process_currencies


Warn about missing host build binaries when compiling with a local engine

Fixes https://github.com/flutter/flutter/issues/15361

@goderbauer

LGTM


feat: Allow BeginDialog to use arbitrary dialog id

Description
Allows user to select 'Write Expression' from the select dialog dropdown and insert arbitrary dialog id.
Task Item
Closes #5820
Screenshots

Coverage decreased (-0.004%) to 53.716% when pulling c7c6cd11676964b7a9db5cb45e6ab78e2232ac6e on tdurnford:feat/begin-dialog into 66825eaf8062fd68c42595f86ea457261e8b15a3 on microsoft:main.


[BugFix] Fix CTAS profile bugs when profile is enabled

Fix bugs introduced by https://github.com/StarRocks/starrocks/pull/25261

handleDMLStmt  has already writeProfile , ignore writeProfile  in handleCreateTableAsSelectStmt and InsertOverwriteJobRunner

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[x] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 5 / 5 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
3
3
100.00%
[]

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0


Fix broken links

Purpose / why
Fills in the stub Audio and Video pages, addressing #2139
Fixes the broken link to Typed Relation, addressing #2141
What changes were made?
as listed above, plus

added a mention that Islandora Defaults provides a View for collection display.

Verification

does it build
do you know it to be inaccurate?

Interested Parties

@Islandora/documentation
@Islandora/committers

Checklist
Pull-request Reviewer
Pull-request reviewer should ensure the following:

[ ] Does this PR link to related issues?
[ ] Does the proposed documentation align with the Islandora Documentation Style Guide?
[ ] Are the changes accurate, useful, free of typos, etc?

Person Merging
The person merging should ensure the following:

[ ] Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
[ ] If pages are renamed or removed, have all internal links to those pages been fixed?
[ ] If pages are added, have they been linked to or placed in the menu?
[ ] Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

This looks pretty good. Need to look it over more closely.


Combining audio track with static image

We're looking at replacing our aging implementation of FFMpeg with this library, but I couldn't work out from the docs whether it was possible yet to combine a static image with an audio track into a video the length of the audio track. Is that possible?
Thanks

It is not yet supported out-of-the box, but I believe it is possible to implement without any code changes to core library. You should be able to create a new implementation of MediaSource and Decoder interfaces that will produce empty video frames (for the duration of audio track) and apply a "full screen" BitmapOverlayFilter on top.

Great, thanks!


Boundary key source path annotation fails on Windows when using notebooks from different drive

    annotate_source_path(nb, base_dir, path, boundary_key)
  File "C:\Users\pete\AppData\Local\Continuum\anaconda3\lib\site-packages\nbmerge\__init__.py", line 37, in annotate_source_path
    cells[0].metadata[boundary_key] = os.path.relpath(nb_path, base_dir)
  File "C:\Users\pete\AppData\Local\Continuum\anaconda3\lib\ntpath.py", line 584, in relpath
    path_drive, start_drive))
ValueError: path is on mount 'c:', start on mount 'D:'

Hey Pete. I'm a week away from my dissertation defense and very behind. If I haven't closed this in about two weeks, please ping me again. Thanks!

No sweat. I will see if I can figure out what's going on. Good luck with the defense!

Feel free to unsubscribe to reduce stress while you're getting ready. I will post some notes here.
https://stackoverflow.com/questions/40448938/valueerror-path-is-on-mount-c-start-on-mount-f-while-django-migrations-i

Best solution may be to catch the ValueError and simply use the notebook base name. Would like to create a test for this on AppVeyor, which may require creating a separate virtual disk.

Hope your dissertation defense went well! Just pinging this issue again since I haven't worked on it yet. It's not holding up the project I'm using it for, however.


Use collections.abc.Iterable instead of collection.Iterable

The latter is no longer present in Python 3.10+.
Addresses #58714

@swift-ci please smoke test

@swift-ci please smoke test Linux

@swift-ci please smoke test Linux


Unable to create Gateway using straight-console

Hello,
I've been trying to store the config of my Gateway in the database as per the README and Alexander advice.
I'm getting the following error and I'm not really versed enough in Ruby to understand sequel documentation:
straight-console  --config-dir=/usr/src/app/straight-server-config/
/var/lib/gems/2.1.0/gems/straight-1.0.0/lib/straight/faraday_monkeypatch.rb:1: warning: already initialized constant Faraday::SSLOptions
/var/lib/gems/2.1.0/gems/faraday-0.9.1/lib/faraday/options.rb:205: warning: previous definition of SSLOptions was here
Setting config dir to /usr/src/app/straight-server-config
irb(main):001:0> gateway = Gateway.new
NameError: uninitialized constant Gateway
	from (irb):1
	from /var/lib/gems/2.1.0/gems/straight-server-1.0.0/bin/straight-console:12:in `<top (required)>'
	from /usr/local/bin/straight-console:23:in `load'
	from /usr/local/bin/straight-console:23:in `<main>'

Using the 1.0 version from the gem file
Thanks for your help

Try StraightServer::Gateway

OK This works, then I'm entering values for :

gateway.pubkey                 = 'xpub1234'
gateway.confirmations_required = 0
gateway.order_class            = 'StraightServer::Order'
gateway.callback_url           = 'http://myapp.com/payment_callback'
gateway.save

But the save is failing with :
TypeError: no implicit conversion of nil into String
        from /var/lib/gems/2.1.0/gems/straight-server-1.0.0/lib/straight-server/gateway.rb:433:in `update'````

Reading from the code I thought this was due to not having a server_secret file in my config, but it is present with a secret in it

Am I missing something here ?

OK, found it, gateway.name also needs to be specified (not sure if secret is mandatory too but I've added it)

secret is not needed, thanks for you help, hope it serves others...
Great job on straight-server otherwise guys

Hi @MBuffenoir  can you help me? how do you set the secret and how do you get it? I'm stuck


Update optional-claims-reference.md to mention the optional value on idtype

@SHERMANOUKO this will also need to be propagated to 1P, ?What is your preference? shall I do another PR?

#sign-off

Hi @jmprieur - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. Would you make this content update in the private repo instead? Thank you! We'll close this PR.

@jmprieur, I've fixed this!


Implement authorization webhook cache

What this PR does / why we need it:
We can reduce the load caused by the authorization webhooks that affect response time.
Which issue(s) this PR fixes:

Fixes #192
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Additional documentation:

Checklist:

[x] Added relevant tests or not required
[x] Didn't break anything

@hackerwins Thanks for the additional feedback!
I was thinking of proceeding with issue #168 as the next task. And I was going to try to modify the AuthorizationWebhookXXX in the new PR. (expected PR title: Improve configs)
I think the correction part seems to overlap in #168 progress.
ex) AuthWebhookCacheAuthorizedTTLSec -> AuthWebhookCacheAuthorizedTTL
So, how about correcting the part you mentioned in my next PR after this PR is over?


[BUG]: can't register a feast stack component because the feast feature store flavor has an incorrect FlavorWrapper source module

Contact Details [Optional]
<EMAIL_ADDRESS>System Information
ZenML version: 0.9.0
Install path: /Users/shawnmorel/Code/rivian/me/factory-data/factory-data-algorithms/projects/common/process-health/.venv/lib/python3.9/site-packages/zenml
Python version: 3.9.9
Platform information: {'os': 'mac', 'mac_version': '12.4'}
Environment: native
Integrations: ['feast', 'kubeflow', 'scipy', 'seldon']
What happened?
From zenml.integrations.feast
FlavorWrapper(
    name=FEAST_FEATURE_STORE_FLAVOR,
    source="zenml.integrations.feast.feature_store.FeastFeatureStore",
    type=StackComponentType.FEATURE_STORE,
    integration=cls.NAME,
)

notice the incorrect ...feast.feature_store package name, should be ...features_stores to match reality.
May I suggest that the pattern used to define integrations be made less fragile rather than a human provided string, source should come from f{FeastFeatureStore.__module__}.{FeastFeatureStore.__qualname__}. This could be streamlined in the Integration base class.
Reproduction steps
zenml integration install feast
zenml feature-store register blah --flavor feast
Error: The feature_store flavor 'feast' is a part of ZenML's 'feast' integration, which is currently not installed on your system. You can install it by executing: 'zenml integration install feast'.

Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for reporting this. I was just going to write a quick reply to say that this has already been fixed, but when I go to the develop branch to confirm it then it seems like it wasn't fixed. Not sure what happened there. I'll pass on your suggestion on having a less flaky way to pass in that pattern to the core team. You're right it does seem error prone..


Fix blog post link

Hi there,
Thanks for the work & the blog post.
The link was not working. No it is :)

Hey, thanks for your kind words. I totally forgot to update the readme 😅
Thank you very much 😄🏆


How to do line break while using drawText method

I am inserting new page into an existing pdf, I did this part. I also added some text with drawText() method, but now I am in need of an automatic line break if the text is too long. Thanks

Hello @khanhubgit!
Currently, line wrapping requires a bit of manual effort. You must use the PDFFont.widthOfTextAtSize() method to determine when to insert a line break.
However, @multiplegeorges has done some great work to add a maxWidth option when drawing text. This feature hasn't yet been merged into pdf-lib. It'll probably be a few days or maybe weeks before this happens. But in the meantime, please feel free to pull it into your own codebase by extending PDFPage or manually additing the method to its prototype (also see https://github.com/Hopding/pdf-lib/issues/168).
I hope this helps. Please let me know if you have any additional questions!


strict config doesn't seem to work with 1.8.1

After upgrading to<EMAIL_ADDRESS>the strict config is not working at more. I have strict=none in my app and I still got the message=Guest customer with email already exists. Has anything changed regarding strict config in the latest version?
Here is how I use it:
{
    resolve: "medusa-plugin-auth",
    /** @type {import('medusa-plugin-auth').AuthOptions} */
    options: {
      strict: "none",
      google: {

Thanks

weird nothing has changed in that regards, I ll check that tomorrow

weird nothing has changed in that regards, I ll check that tomorrow

I had a quick look and it seems to be here:                                                                 passportCallbackAuthenticateMiddlewareOptions.failureRedirect + '?message=' + options.msg

not sure, cause the callback is already completed at that moment and already thrown the error that we access here

Just tested, and I get the strict properly set to the correct value I have in my config, so nothing should have changed in your behavior

I think the error you are getting comes from medusa and not the plugin itself, what I think is happening is that you have a guest customer created who didn't validate their account. therefore, the retreiveRegisteredAccount doesn't returns it and the customer is being created which is not allowed if a guest customer already exists in medusa

I could be totally wrong here but when a user creates an order in medusa without registering, medusa creates a guest customer (and as far as I've seen this is the only way to end up as a guest customer). If the same user later on decides to register an account in medusa, the backend creates a second account (with the same email) and has_account is set to true. My understanding was that medusa determines if account exists not just by email but by email + has_account. So if we assume that there is already a guest customer in the system, when the same user tries to login with google (for example), shouldn't we allow that customer to actually have a second account by setting has_account=true?
Thanks


Misleading and false compiler error on assignment count mismatch

What version of Go are you using (go version)?

$ go version
go version go1.15.7 linux/amd64

Does this issue reproduce with the latest release?
go1.15.7 is the latest stable at this time.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/tv/.cache/go-build"
GOENV="/home/tv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/tv/.cache/go-mod-cache"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/tv/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/nix/store/407lnd2j7cpzcdw53kvwqxy2pmhixp1z-go-1.15.7/share/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/nix/store/407lnd2j7cpzcdw53kvwqxy2pmhixp1z-go-1.15.7/share/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/run/user/1000/go-build860811162=/tmp/go-build -gno-record-gcc-switches"

What did you do?

https://play.golang.org/p/f99NWjvCqKW
package main

// note that foo returns 1 value
func foo() int { return 42 }

func main() {
	tmp := foo(), nil
	// ./main.go:7:6: assignment mismatch: 1 variables but foo returns 2 values
	_ = tmp
}

What did you expect to see?
assignment mismatch: 1 variables but right side has 2 values

What did you see instead?
An incorrect statement about a helper function.
I arrived at this from copy-pasting the body of log/syslog.NewLogger inline to my calling function, customizing what it does, and replacing the return in return log.New(s, "", logFlag), nil with logger := ..., without noticing the , nil at the end. The error message lead me to reading log.New, which I was quite sure returned only one value.

Dup of #43348.

Dup of #43348.

Yes, it is. I'm not thrilled that an existing bug is closed like that, but this dup adds no value.


Marionette Driver instead of FirefoxDriver

Hello @tourdedave is it possible to know more about marionette driver since FirefoxDriver is not working on latest Firefox version 47 and it is also said that marionette will be a standard in future?

@rahulmr According to the following docs it looks like Selenium 3 uses Marionette by default when Firefox is specified: https://developer.mozilla.org/en-US/docs/Mozilla/QA/Marionette/WebDriver
More information on Marionette:
https://developer.mozilla.org/en-US/docs/Mozilla/QA/Marionette


#159463797 lint back-end server with eslint

What does this PR do?
Lint the server folder with eslint using Airbnb style guide
Description of Task to be completed?

Run npm run lint
Adjust are the code to meet Airbnb style guide

How should this be manually tested?
After cloning the repo, cd into the directory. RUN 'npm install' to install dependencies.
RUN 'npm run lint' to start the app.
you will get clean.
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?

Story type: chore
Story title: Lint the all backend code with Airbnb standard
Story ID: #159463797

Screenshots (if appropriate)
N/A
Questions:
N/A

Pull Request Test Coverage Report for Build 85

19 of 26 (73.08%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 80.678%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server/src/middlewares/doesUserExist.js
0
1
0.0%

server/src/contollers/EntryController.js
6
8
75.0%

server/src/contollers/UserController.js
5
9
55.56%

Totals

Change from base Build 83:
0.9%

Covered Lines:
207

Relevant Lines:
236

💛  - Coveralls


Add code style settings and reformat the code

This PR adds Intellij code style settings, sets the scalastyle line length to 100 and tabSize to 2, and reformats the whole codebase based on that.

:+1: LGTM


Adds option to specify character set in responses (with http adapter)

We have a service that returns responses encoded with the ISO-8859-1 character set, and needed a way to decode these correctly. This change allows us to decode correctly in our server:
axios.post('http://service-with-latin-encoding.com', {}, { charset: 'latin1' })
  .then(/* do something */);

Coverage increased (+1.5%) to 93.719% when pulling 5c825a7e6cdca54485b08da9cddc6ae8cd6bc431 on johntron:master into f31317aeca8f7fa385d6aee94ef6ec8ac9d7c072 on mzabriskie:master.

@nickuraltsev @rubennorte thanks for maintaining this project. Would you mind taking a look at this PR? It's a simple, backwards-compatible improvement for server-side requests - even comes with updated README :D

Coverage remained the same at 93.734% when pulling 83406f8b50c6d3cdc70502ad851d44b2a56b3563 on johntron:master into 46e275c407f81c44dd9aad419b6e861d8a936580 on mzabriskie:master.

Coverage remained the same at 93.734% when pulling f600705f54af63192b9907c486480aebb6c65382 on johntron:master into 46e275c407f81c44dd9aad419b6e861d8a936580 on mzabriskie:master.

Coverage remained the same at 93.734% when pulling f600705f54af63192b9907c486480aebb6c65382 on johntron:master into 46e275c407f81c44dd9aad419b6e861d8a936580 on mzabriskie:master.

Thanks so much @rubennorte - I'll make those changes when I get home.

Updated

Coverage remained the same at 93.812% when pulling 7340c5d5fb48411ac49723b203273834cea90a5e on johntron:master into 07a7b7c84c3ea82ea3f624330be9e0d3f738ac70 on mzabriskie:master.

I think it would be better to extract charset from response header content-type. This way you don't have to manually pass the charset per request.

I think it would be better to extract charset from response header content-type. This way you don't have to manually pass the charset per request.

I agree, but that can be done in a future PR based on the work I've done
here. No reason we can't support both methods.
On Thu, Oct 5, 2017, 18:51 Tan Nhu<EMAIL_ADDRESS>wrote:

I think it would be better to extract charset from response header
content-type. This way you don't have to manually pass the charset per
request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/axios/axios/pull/869#issuecomment-334622767, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIDeZ8yLgTrdZNJcpc3T1npR5aNmg1fks5spWuXgaJpZM4NKcyk
.

@rubennorte I made those changes in August of last year. Can this be merged yet?

Hi @rubennorte ! Any progress on this? I have a similar use case.

@johntron Sorry for the delay! I'm going to merge it now.

No worries, thanks for the merge!

The implementation would be better in this way:

responseEncoding default value should be null
when responseEncoding has a value, use this encoding
otherwise use the charset in Content-Type header
fallback to utf-8

@lepture this PR has already been merged, but feel free to submit another PR. This one served my needs, and I would not like the added dependency for other encodings - I've never worked with an API that returned anything other than UTF-8 or latin-1.


Analysis Cleanup and Explicit Types

This is a number of changes to the analysis code.
One of the main changes is making all the types in the analysis explicitly declared instead of relying on a maze of .Elements with convoluted inheritance patterns. I personally find this makes the code easier to follow. I am curious for feedback here from @ailrst and @yousifpatti  - is this an improvement?
Other changes here:

Consolidates and cleans up parts of the analysis, to reduce the convoluted inheritance patterns
Enables procedure inlining in the CFG so that there are actually interprocedural edges in the CFG
Makes interprocedural analyses actually use the interprocedural edges (before they were in practice not meaningly different from the intraprocedural analyses) but this still doesn't seem to be completely working properly, there might be an issue with the inlining? It might make sense to just make the VSA an intraprocedural analysis for now? It isn't worth trying to fix the inlining since #141 is in the works.
Removes edges from the CFG (no longer necessary now that jumps don't have conditions)
Significantly improves the way intra/interprocedural analyses are handled so there isn't a boolean 'intra' flag carried around everywhere
Makes the SimpleMonotonicSolver obtain its initial set of nodes in a more modular way.

I am happy with these changes. Are you going to merge them soon I wish to merge the lifted lattice stuff as well?


How to use only EventBus?

I want to use only EventBus. I want to create an event and an event listener for that event like this:
https://github.com/josecelano/ddd-symfony-sample/tree/master/src/Matthias/User/App/Event
And I want to dispatch that event from a command handler like this:
https://github.com/josecelano/ddd-symfony-sample/blob/master/src/Matthias/User/App/Command/RegisterUserCommandHandler.php#L41
and I do not know how to do that becuase I have not found any sample using only the EventBus without using AggregateChanged or projectors.

More info about waht I am trying to do:
My config:
    'service_bus' => [
        'command_bus' => [
            'router' => [
                'routes' => [
                    \Prooph\Snapshotter\TakeSnapshot::class => \Prooph\Snapshotter\Snapshotter::class,
                    // list of commands with corresponding command handler
                ],
            ],
        ],
        'event_bus' => [
            'plugins' => [
                \Prooph\ServiceBus\Plugin\InvokeStrategy\OnEventStrategy::class
            ],
            'router' => [
                'routes' => [
                    // list of events with a list of projectors
                    'project_was_created' => \Modules\Projects\App\Event\Handlers\Mailer::class
                ],
            ],
        ],
    ],

Event:
final class ProjectWasCreated extends DomainEvent implements PayloadConstructable
{
    use PayloadTrait;
}

Event listener:
class Mailer implements ActionEventListener
{
    /**
     * @param ActionEvent $event
     */
    public function __invoke(ActionEvent $event)
    {
    }
}

Event creation and dispatch:
        $projectWasCreated = ProjectWasCreated::fromArray([
            'message_name' => 'project_was_created',
            'uuid' => Uuid::uuid4(),
            'version' => 1,
            'created_at' => new \DateTimeImmutable('now', new \DateTimeZone('UTC')),
            'payload' => ['event' => 'payload'],
            'metadata' => ['event' => 'metadata']
        ]);

        $this->eventBus->dispatch($projectWasCreated);

Error message:
MessageDispatchException in MessageDispatchException.php line 36:
Message dispatch failed during invoke-handler phase. Error: Argument 1 passed to Modules\Projects\App\Event\Handlers\Mailer::__invoke() must implement interface Prooph\Common\Event\ActionEvent, instance of Modules\Projects\App\Event\ProjectWasCreated given, called in /home/vagrant/Code/base-web-app/vendor/prooph/service-bus/src/EventBus.php on line 41 and defined

I have fixed the problem chaging these files:
New config section:
        'event_bus' => [
            'plugins' => [
                \Prooph\ServiceBus\Plugin\InvokeStrategy\OnEventStrategy::class
            ],
            'router' => [
                'routes' => [
                    // list of events with a list of projectors
                    'project_was_created' => [\Modules\Projects\App\Event\Listeners\Mailer::class]
                ],
            ],
        ],

Notice I am using now an array.
And the new listener looks like:
class Mailer
{
    /**
     * @param ActionEvent $event
     */
    public function __invoke(ProjectWasCreated $event)
    {
        ...
    }
}

Notice I do not implemet any interface now, and the __invoke method param has the event type.

Good work. Yes it was a config issue. Anyway, thanks for reporting and solving the issue. If you have any questions you can also join our Gitter channel.


Broken URL for Public Health Scotland

Broken URL: #https://www.opendata.nhs.scot/

Site looks fine. Appears to be a false positive. Closing.


Add opentelemetry support

Added context.Context to most API methods for span propagation
Spans are added to the parent (from context) when an API is called
Simple cache metrics can be registered with cache.RegisterMetrics()

Fixes: #146
Signed-off-by: Dave Tucker<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

40 of 58 (68.97%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 76.984%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cache/cache.go
8
26
30.77%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
3201

Relevant Lines:
4158

💛  - Coveralls


Option to only notify the input value changed on mouse click or key press

At the moment input value change is triggered as the scroll through the list via arrow keys.
In my case this would trigger a potentially expensive operation so I would prefer to only notify the input value changed if the mouse is clicked (see #1) or the return key is pressed.

Thanks for the comment!
V0.1.1 should fix this - input value is now only changed when the enter key is pressed after scroll.

Thanks for the quick fixes.


Does it support flow based dialog conversation?

Does it support flow based dialog conversation?

Hi @kenyeung128, could you describe what you mean by a "flow based" conversation? If you could provided an example or link to an article that describes it that would be perfect.

Am also facing the same problem.  if am right.
Lets take below scenario.
JSON:
[
"right",
"okay"
],
[
"i have problem with eye",
"which side",
"right",
"oh...thats bad. What happened to right eye.?"
]
conversation:
Me: I have problem with eye.
bot: which side
Me: right
Bot: Okay
In the above scenario. if am replying with "right" means I want the bot to reply "oh...thats bad. What happened to right eye.?". but instead of that it will reply "okay". because of the best match.
@kenyeung128 Please correct me if am wrong.
@gunthercox  Am facing this situation. :(
Thanks in advance.!

I'm closing this ticket as a duplicate of #276. Feel free to click the subscribe button on that page to follow the progress for when it is resolved.


Fix CMake Build for MSVC 15 2017

Build for MSVC 15 2017 does not work right out of the box and could be a little more documented.
CMake project configuration and generation is going fine.
cmake ../python-cmake-buildsystem
It generates project files for Visual Studio and Python.sln Solution.
It is worth documenting what one should do at this point to build the solution (i assumed i had to run this:)
MSBuild.exe python.sln
However i get an error when i let default configuration:

error MSB4126

So i tried to run with explicit configuration:
MSBuild.exe python.sln /p:Configuration=Release /p:Platform=x86
However i get the same error:

error MSB4126

Then i tried the following tip i saw somewhere on SO concerning the same error:
SET "PLATFORM="
MSBuild.exe python.sln

However i get the following error:

winnt.h(154): fatal error C1189: #error:  "No Target Architecture"

So i tried to include this patch:
in file _iomodule.c from Python 3.6.4 sources as pulled by default
From:

l.23: #ifdef MS_WINDOWS
l.24: #include <consoleapi.h>
l.25: #endif

To:

l.23: #ifdef MS_WINDOWS
l.24: //PATCH:START
l.25: #include <windows.h>
l.26: //PATCH:END
l.27: #include <consoleapi.h>
l.28: #endif

When doing so i get "build success" with output python.exe, python36.lib, pyconfig.h, so now i can get to chose which modules i want and get that static python for embedding
By the way i do not get any of these errors with the regular python build.
In short:
Is it possible to improve documentation for build on windows ?
Is it possible to add a patch for this ?

Thanks for reporting the issue :+1:
Here is a PR adding testing for VS 2017. See https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/pull/234

Is it possible to improve documentation for build on windows ?

Definitively
What about updating the "Build" section with the following:
# Unix
cd ~/scratch
mkdir -p python-build && mkdir -p python-install
cd python-build
cmake -DCMAKE_INSTALL_PREFIX:PATH=${HOME}/scratch/python-install ../python-cmake-buildsystem
make -j10
make install

# Windows
cd %HOME%/scratch
mkdir python-build
mkdir python-install
cd python-build
cmake -G "Visual Studio 15 2017 Win64" -DCMAKE_INSTALL_PREFIX:PATH=%HOME%/scratch/python-install ../python-cmake-buildsystem
cmake --build . --config Release -- /m
cmake --build . --config Release --target INSTALL

Build error

After, enabling testing for Visual Studio 2017
The build are successful: https://ci.appveyor.com/project/jcfr/python-cmake-buildsystem/build/1.0.348
I suggest you follow the approach suggested above

Thank you for your quick answers, indeed these build instructions for Windows seem to be what should work however i stumble on the same error as before during build, when running:
cmake --build . --config Release -- /m
I get:

winnt.h(154): fatal error C1189: #error: "No Target Architecture"

Which apparently has something to do with how windows API headers are included in python source code and can be solved with the patch i proposed for 3.6 in the first post for this issue.
Another issue i ran into before and that made me use MSBuild directly instead of cmake --build was that if i ran:
cmake --build .
instead of
'cmake --build . --config Release -- /m'
I would then get this error:

error MSB8020: Les outils de génération pour Visual Studio 2010 (ensemble d'outils de plateforme ='v100') sont introuvables.

in short cmake targets build tools for MSVC 2010 tools instead of MSVC 2017 even though i used the Generator "Visual Studio 15 2017 Win64".
I've had this issue on two different clean setups on Windows where only MSVC 2017 tools are installed, Maybe this command is wrong, or this might be an issue from CMake itself, but i do not experience this error with cmake builds for other libraries.
If the automated builds work, then a patch is illegitimate. In that case i am clueless about how to get the CMake Build System with MSVC 15 2017 on my configuration.

Ok so after spending too much time on that, here are more news ;) :
cmake --build .
targets debug build by default but the generator only generated a release config somehow so MSBUILD is lost and outputs obscure errors ( those related to MSVC 2010 )
I guess this can be overcome by setting CMAKE_BUILD_TYPE at generation / configuration time, that was a noob error here, although this behaviour is not standard for cmake library builds.
An interesting point is It seems that the error due to the include of <windows.h> in iomodule.c was solved in 3.7.0.
Actually my patch is exactly the same as the changes they made to that file.
So this is a change that is already taken into account in cpython that shouldn't be patched in the future here.
This change was made to solve problems due to windows SDK updates so it seems like your VMs from where you run your tests are a little outdated.
So i thought i could use your branch "support-build-37-and-38" since it would typically solve this, but it doesn't seem to be ready to work either ! + it has troubles with some external libs because it is looking for files that were removed from Python/Modules/zlib
To summarize:
The python cmake buildsystem is able to work under Windows and for Visual Studio 2017 although a patch is possible for 3.6 ( at least ), it corresponds to exact same changes that were already made in 3.7.0.
For my needs i will be using my patch.
Should i make another issue or push the patch for this specific system / generator / compiler ?
Thanks ;)

Thanks for following up.
Few comments

When using Visual Studio,  CMAKE_BUILD_TYPE should not be set at generation. Indeed, Visual Studio is a multi-configuration IDE and the config should be selected at build time. I will add a note to the README.

Debug build are not supported (yet) on windows. See #12

Which apparently has something to do with how windows API headers are included in python source code and can be solved with the patch i proposed for 3.6

Could you for the python-cmake-buildsystem/cpython project and push a commit one top of this branch: https://github.com/python-cmake-buildsystem/cpython/tree/3.6.2-patches
This would greatly help moving this forward.

Actually my patch is exactly the same as the changes they made to that file.

It would be great to reference here the commit from the upstream python github repository.
Test build
Could you try to build locally with the option BUILD_LIBPYTHON_SHARED:BOOL=ON ? This would allow to build like it was done on appveyor: https://ci.appveyor.com/project/jcfr/python-cmake-buildsystem/build/1.0.348
I would like to confirm that a build is successful for you when using the same settings.

I submitted a Pull-Request with the patch for Fixing Windows build of Python, reverberating changes that were made upstream for 3.7 here in the 3.6.2 patches in order to allow build using the latest WinSDK.
Here is the reference of the commit upstream, also mentionned in the commit & pull request i submitted.
https://github.com/python/cpython/commit/c0ee341b29bd7d978b49272a2c0e2dcfa77404d5
Test build
Unfortunately the build was not successful using these settings, due to the same error as before.
Merci d'avoir pris le temps de répondre, et merci pour ton travail sur le cmake buildsystem, ça simplifie beaucoup les choses pour builder python en static pour l'embarquer ! ;)

Build issue with new install of VS2017 has been fixed in https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/commit/2cd115b830e01305a0cd359e468630d1c6f2c9ed

To summarize:

Is it possible to improve documentation for build on windows ?

This was done in https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/commit/75b8384d73575eed2a46ac3e75c6690502380d04

Is it possible to add a patch for this ?

This was done in https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/commit/55c8825d9454d18796e409d2cb6df60fcee12aaf
Thanks again for your patience.


feat: cleans up build after adding semantic-release

What
feat: cleans up build after adding semantic-release

:tada: This PR is included in version 1.21.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.21.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Compute mesh quality indicators

We need to compute metrics including the following:

Ortogonality
Skewness
Aspect ratio
Smoothness

@dwastberg Should this be in dtcc-builder or dtcc-wrangler?

@anderslogg , I've made a Python implementation for the above quality metrics. The main issue was that while there is a concensus on the meaning of each indicator there are different definitions for their computation.
I describe the methods I used for each indicator to get some feedback before starting the C++ implementation.
For Surface Meshes:
1.  Aspect Ratio
In meshes with triangular faces is computed by measuring the ratio of the longest edge length to the shortest edge length within a triangle. A lower aspect ratio indicates a more regular and well-shaped triangle.
Aspect Ratio = L_max / L_min
2. Orthogonality
I measured a face's orthogonality as the minimum deviation of its angles from a right angle. The closer this indicator is to 0, the closer the face resembles a right triangle.
        oi_0 = abs(1 - (angle_between(AC, AB) / (np.pi / 2)))
        oi_1 = abs(1 - (angle_between(AB, BC) / (np.pi / 2)))
        oi_2 = abs(1 - (angle_between(AC, BC) / (np.pi / 2)))

        orthogonality[i] = min((oi_0, oi_1, oi_2))

3. Skewness
As a measure for skewness I used equiangular skew.
`Equiangle Skew = max(Θmax- Θc)/(180-θc),(Θc-Θmin)/θc)`

where:
- Θmax : is the largest angle in a face or cell
- Θmin : is the smallest angle in a face or cell
- θc :   is the angle for equi-angular face or cell i.e. 60 for a triangle and 90 for a square.

4. Smoothness
Smoothness measures the change in size between neighbour faces of the mesh. In the case of a surface mesh I measured smoothness as the standard deviation in area of all faces adjacent to a Vertex.
For Volume Meshes:
1. Aspect Ratio
I used three different metrics for AR in Volume Meshes:

As in surface meshes, checking the ratio of the longest edge length to the shortest edge length. Edge length check provides a lazy aspect ratio indicator for tetrahedron cells

Measuring AR as the Ratio of the longest edge length to the length of the inradius of the tetrahedron cell.

Measuring AR as the Ratio of the Circumradius of the tetrahedron cell to the inradius of the tetrahedron cell.

2. Orthogonality
As a metric for orthogonality I computed the normals of the cells faces and measure orthogonality as the RMS of the dot products between the cell's normals.
We could potentially also use the dot products of opposite edges of the tetrahedron.
3. Skewness
As a measure of skewness for tetrahedron cells I used the ratio:
Skewness = (V_ideal - V) / V_ideal
Where:

V is the volume of the tetrahedron cell.
V_ideal is the volume of regular tetrahedron with the same circumsphere as our cell.

4. Smoothness
Smoothness measures the change in size between neighbour cells of the mesh. In the case of a volume mesh I measured smoothness as the standard deviation in volume of all cells adjacent to a Vertex.
The functions above return arrays with metrics for each cell or vertex for further statistical analysis. Additionally, we can define specific thresholds for each indicator, helping us determine what constitutes a 'good' mesh.

@Georspai Great job and thanks for the complete and very informative overview. I think the next step should be to use the Python implementation on a couple of test cases (2-3 meshes) and compare the 4 indicators to what Mariya gets with Fluent. If possible, try choose the same indicators as in Fluent to get the exact same results. Then we have a working Python reference implementation that we know is correct. Then it's a matter of porting that to C++ and veryfying again that it gives the same as in Python.

@anderslogg actually the only missing thing is how to enable them in options. @Georspai has come up with a binary solution, but I am not really convinced.

@anderslogg @vbassn Since all parameters are mostly booleans , ints and some strings for paths, I wanted to follow the same mentality and use ints for the parameters that pick which metrics are going to be measured. I used the same logic as linux file permissions.
_parameters = {}

_parameters["model_name"] = "DTCC"
_parameters["auto_domain"] = True
_parameters["debug"] = False

_parameters["build_mesh"] = True
_parameters["build_volume_mesh"] = True

_parameters["save_protobuf"] = True
_parameters["save_json"] = False
_parameters["save_shp"] = False
_parameters["save_vtk"] = False
_parameters["save_stl"] = False
_parameters["save_obj"] = False

_parameters["ground_smoothing"] = 3

_parameters["metrics_report_level"] = 45
_parameters["metrics_report_level_volume"] = 927

def default():
    return _parameters.copy()

Essentially, we have:
Surface Meshes: 6 metrics, so the level ranges from 0 to 63.
Volume Meshes: 4 Cell-Based Metrics and 6 Face-Based Metrics, so the report level ranges from 0 to 1023.
In this case:
The metrics_report_level 45 is 101101, meaning all metrics except the second and the second last.
The metrics_report_level_volume 927 is<PHONE_NUMBER>, meaning all metrics except the sixth and the seventh.
When the level is zero, the "quick" check runs, which includes the two most significant metrics.
But upon some discussion with Vasilis, we realize that this design is concise but not user friendly at all. So I would like to discuss some other solution for how the parameter indicating the metrics should be.

@Georspai thanks! @anderslogg how do you feel about the options?

@Georspai @vbassn I don't think the binary system works. It's too cryptic. Is the problem that we need to pass too many parameters down the chain from the Python layer to C++?
It makes more sense to be explicit about the parameters. That also fills an additional purpose which is to expose which metrics are available, something like this:
_parameters["report_mesh_metric_aspect_ratio"] = True
_parameters["report_mesh_metric_orthogonality"] = False
...
_parameters["report_volume_mesh_metric_aspect_ratio"] = True
_parameters["report_volume_mesh_metric_orthogonality = False
...


[Bug] 5.110.2 crash ("A migration from 42 to 41 was required but not found")

Describe the bug
5.110.0 just this morning worked fine, upgrade to 5.110.2 later in the day doesn't run.
7f13598f73eacc1c975006c08d2e02b07e60c73f ? :thinking:
E AndroidRuntime: FATAL EXCEPTION: Thread-10
E AndroidRuntime: Process: com.duckduckgo.mobile.android, PID: 6438
E AndroidRuntime: java.lang.IllegalStateException: A migration from 42 to 41 was required but not found. Please provide the necessary Migration path via RoomDatabase.Builder.addMigration(Migration ...) or allow for destructive migrations via one of the RoomDatabase.Builder.fallbackToDestructiveMigration* methods.
E AndroidRuntime: 	at androidx.room.RoomOpenHelper.onUpgrade(RoomOpenHelper.java:117)
E AndroidRuntime: 	at androidx.room.RoomOpenHelper.onDowngrade(RoomOpenHelper.java:129)
E AndroidRuntime: 	at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.onDowngrade(FrameworkSQLiteOpenHelper.java:194)
E AndroidRuntime: 	at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:414)
E AndroidRuntime: 	at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:316)
E AndroidRuntime: 	at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.getWritableSupportDatabase(FrameworkSQLiteOpenHelper.java:151)
E AndroidRuntime: 	at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper.getWritableDatabase(FrameworkSQLiteOpenHelper.java:112)
E AndroidRuntime: 	at androidx.room.RoomDatabase.inTransaction(RoomDatabase.java:706)
E AndroidRuntime: 	at androidx.room.RoomDatabase.assertNotSuspendingTransaction(RoomDatabase.java:483)
E AndroidRuntime: 	at com.duckduckgo.app.httpsupgrade.store.HttpsBloomFilterSpecDao_Impl.get(HttpsBloomFilterSpecDao_Impl.java:63)
E AndroidRuntime: 	at com.duckduckgo.httpsupgrade.store.PlayHttpsEmbeddedDataPersister.shouldPersistEmbeddedData(PlayHttpsEmbeddedDataPersister.kt:25)
E AndroidRuntime: 	at com.duckduckgo.app.httpsupgrade.HttpsBloomFilterFactoryImpl.create(HttpsBloomFilterFactory.kt:45)
E AndroidRuntime: 	at com.duckduckgo.app.httpsupgrade.HttpsUpgraderImpl.reloadData(HttpsUpgrader.kt:121)
E AndroidRuntime: 	at com.duckduckgo.app.httpsupgrade.HttpsUpgraderImpl$onApplicationCreated$1.invoke(HttpsUpgrader.kt:74)
E AndroidRuntime: 	at com.duckduckgo.app.httpsupgrade.HttpsUpgraderImpl$onApplicationCreated$1.invoke(HttpsUpgrader.kt:74)
E AndroidRuntime: 	at kotlin.concurrent.ThreadsKt$thread$thread$1.run(Thread.kt:30)

How to Reproduce
1- Be on 5.110.2 (upgrade from 5.110.0 to 5.110.2 perhaps?)
2- Attempt to run the app
Expected behavior
The app should run just like it always has.
Environment
- DDG App Version: 5.110.2
- Device: Pixel 4a (5G)
- OS: GrapheneOS

It works on a clean install, it's only when upgrading from older version to newer version.

Thanks for reporting. Your assumption is correct. In our latest release, we reverted a feature that bumped the database version and that created a db migration bug for those who installed 5.100.0.
I've removed the apk from those versions to avoid crashes to other users, and we will try to avoid this again in the future. Thanks.


clisp: enable ASDF module

This is useful and expected by most downstream packages
Description of changes
allow users of clisp to directly call (require :asdf) without having to bring their own ASDF.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build clisp
@ofborg test clisp


Update compatibility matrix for Kotlin language 1.5

As a follow up to

#23015

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


[BUG] Game not showing when I launch.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?

I have the settings enabled and it doesnt work.

Are you using the desktop app? What do your privacy settings look like? You can find them at Settings -> Activity Privacy. Do you see a UAC prompt whenever you launch Discord?

Are you using the desktop app? What do your privacy settings look like? You can find them at Settings -> Activity Privacy. Do you see a UAC prompt whenever you launch Discord?

I do have the UAC Mode at Max. It seems not to be having any, just like normal ROBLOX. Could that be an issue of ROBLOX not appearing when I start it?

Are you using the desktop app? What do your privacy settings look like? You can find them at Settings -> Activity Privacy. Do you see a UAC prompt whenever you launch Discord?

I am using the desktop app for Roblox and Discord. All 4 of the settings in Activity Privacy are on. I do not see a UAC prompt when I launch Discord.

Alr so I have fixed my problem by putting an exception in a 3rd party app
that were modifying the session in ROBLOX, if speaking in Byfront manner.
No error appeared tho.
Do you have any of them?
Em sex, 29 de mar de 2024 18:13, GreyMatty @.***>
escreveu:

Are you using the desktop app? What do your privacy settings look like?
You can find them at Settings -> Activity Privacy. Do you see a UAC prompt
whenever you launch Discord?
I am using the desktop app for Roblox and Discord. All 4 of the settings
in Activity Privacy are on. I do not see a UAC prompt when I launch Discord.
—
Reply to this email directly, view it on GitHub
https://github.com/pizzaboxer/bloxstrap/issues/1516#issuecomment-2027742219,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BF375NF7GRP4I47BDIIZCTDY2XKORAVCNFSM6AAAAABFNWPLDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXG42DEMRRHE
.
You are receiving this because you commented.Message ID:
@.***>

Alr so I have fixed my problem by putting an exception in a 3rd party app that were modifying the session in ROBLOX, if speaking in Byfront manner. No error appeared tho. Do you have any of them? Em sex, 29 de mar de 2024 18:13, GreyMatty @.> escreveu:
…
Are you using the desktop app? What do your privacy settings look like? You can find them at Settings -> Activity Privacy. Do you see a UAC prompt whenever you launch Discord? I am using the desktop app for Roblox and Discord. All 4 of the settings in Activity Privacy are on. I do not see a UAC prompt when I launch Discord. — Reply to this email directly, view it on GitHub <#1516 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BF375NF7GRP4I47BDIIZCTDY2XKORAVCNFSM6AAAAABFNWPLDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXG42DEMRRHE . You are receiving this because you commented.Message ID: @.>

I have vencord and that is it. How do I go about putting an exception on it?

I am using the desktop app for Roblox and Discord. All 4 of the settings in Activity Privacy are on. I might be seeing a UAC prompt when I launch Discord and not be noticing it. I have no idea what I did but it started to work. Then started to not work.

You say it's currently not working? Since you're using Vencord, can you check to make sure you don't have the "NoRPC" plugin enabled?

I am using the desktop app for Roblox and Discord. All 4 of the settings in Activity Privacy are on. I might be seeing a UAC prompt when I launch Discord and not be noticing it. I have no idea what I did but it started to work. Then started to not work.

You say it's currently not working? Since you're using Vencord, can you check to make sure you don't have the "NoRPC" plugin enabled?

I will check shortly after I get home and edit this message which the results.


random update

👷 Deploy Preview for jihwan-jeong processing.

Name
Link

🔨 Latest commit
eb7ca76106a84192a8e9bf35a623af482dc794af

🔍 Latest deploy log
https://app.netlify.com/sites/jihwan-jeong/deploys/633f82910b1ca40008cdc564


Fix 3 Prisma Vulnerabilities

Pull Request Motivation
This PR fixes three vulnerabilities picked up by Prisma Cloud.  Hopefully fixing them will help cert-manager users with overly picky compliance teams.  The vulnerabilities are:
PRISMA-2023-0056  in github.com/sirupsen/logrus (medium severity)
PRISMA-2022-0270 in github.com/golang-jwt/jwt/v4 (medium severity)
PRISMA-2022-0227 in github.com/emicklei/go-restful/v3 (high severity)
Kind
cleanup

Release Note

NONE

/ok-to-test

@pmerrison could you rebase the PR?


Cannot find module

Hello,
After I installed the necessary modules by typing 'npm install' and run an example from the program "nodejs examples/blink.js" I get the following error: Cannot find module '/home/michel/Downloads/.msi-keyboard/node_modules/node-hid/build/HID/v0.5.1/Release/node-v11-linux-x64/HID.node'.
If I check the folders there is no node-v11-linux-x64. Only a node-v47-linux-x64
Please help

What is your node version?
It is an error with node-hid

Node version: 4.2.2
Nodejs version: 0.10.25
Tried with only node installed, no luck.
Tried with only nodejs installed, no luck.
Tried with both installed, no luck.
All the dependencies are met (I think).

Until node-hid fixes: https://github.com/node-hid/node-hid/issues/118 use node v12 or iojs v2.5.0


nextdns.io

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 98de6798-2cd1-b76b-176f-81e502655d03
Version Independent ID: cfdb586f-e832-551a-40ae-c7c42d8f5798
Content: Using dynamic DNS to register hostnames in Azure
Content Source: articles/virtual-network/virtual-networks-name-resolution-ddns.md
Service: dns
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

@BRAEVincent52bae
Thank you for reaching out. Can you please provide more details regarding the intended details here. Thank you!

@BRAEVincent52bae ,
Since we do not hear back from you. We will now proceed to close this issue out. Please tag me in your response if you have any additional questions here. Thank you!


Standardize statement execution

Fix bug where the execution profile name was not being set from the
configuration.
Move all statement execution to use an internal execution method.
Ensure all executed statements use the configured consistency level and
execution profile.

Just to let you know. I am planning to release this change end of this week or latest next week. Depends on how demanding my work is this week.


Don't show loader when you refresh with a plaid error

@Expensify/pullerbear
cc @nkuoch
Details
The conditions for showing the loader and error are not exclusive. So we could show both at the same time, as in this case.
I think we should clarify the condition for the loader. If we are loading something, always show it. However, if there is an error message, lets skip it
Fixed Issues
$ https://github.com/Expensify/App/issues/13985
Tests
Same as QA steps
Offline tests
From teh bank account step. Go offline. Verify when you pick "Plaid" you hit a full page blocker

QA Steps
First add a bank account payment method:

Go to Account Settings -> Payments. Click "Add Payment Method" button and select bank account type

Use plaid, choose Chase, and use user_good and pass_good to get past login.
Once through, select the account that ends with x1111 and submit. Verify that you successfully created a payment method

Test error:

Create a workspace
Go to Workspace Settings -> Connect Bank Account
Select Plaid. Choose Wells Fargo. And only select the account that ends in x1111

Complete the rest of the plaid steps
Verify that you see the error

Reload the page like in the issue.
Verify that you don't see an infinite spinner.

Regression Testing:

Go to Account Settings -> Payments. And delete the bank account payment method

Go back to Workspace Settings -> Connect Bank Account
Go through same steps as the tests above. Get through plaid. Choose a different bank this time. Only select the bank account with x1111.
You should now be able to add that account as a VBBA for the workspace
Verify you can get past the Bank account step.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

🚀 Deployed to staging by @arosiclair in version: 1.2.55-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

QA'ed, working as expected
Chrome: https://recordit.co/42dC34pjcg
Mobile Web: https://recordit.co/zHmpHLWarc
Desktop: https://recordit.co/dlhX1fctEf

🚀 Deployed to production by @AndrewGable in version: 1.2.55-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Update ClusterClaim to v1alpha2

Update ClusterClaim to v1alpha2

ClusterClaim upgraded to v1alpha2, with removeing the Name of it
meta.name in ClusterClaim can only be created as id.k8s.io or
clusterset.k8s.io
Deprecate ClusterClaim version v1alpha1

@luolanzone this can be reviewed, thanks!

@bangqipropel  Please don't forget to add your sign-off info.

/test-multicluster-dataplane-e2e

@luolanzone this can be reviewed again, thanks!

Please update your summary:

Update ClusterClaim to v1alpha2
1. ClusterClaim upgraded to v1alpha2, with removing the Name of it

2. metadata.name in ClusterClaim can only be `id.k8s.io` or
   `clusterset.k8s.io`

3. Deprecate ClusterClaim version v1alpha1

/test-multicluster-dataplane-e2e

@tnqn can this be reviewed? thanks!

@bangqipropel  Could you please resolve conflicts? and update the PR summary to link it with issue #3328. Thanks.

/test-multicluster-dataplane-e2e

@luolanzone it is good now, thanks!

@tnqn can this be reviewed? thanks!

@tnqn can this be reviewed? thanks!

will take a look tomorrow.

/test-multicluster-dataplane-e2e

@bangqipropel , e2e failed, could you check here http://<IP_ADDRESS>:8080/job/antrea-multicluster-e2e-for-pull-request/30/console and fix the error?

@bangqipropel Could you address quan's comment and resolve conflicts? I would suggest to merge this as early as possible. Thanks.

/test-multicluster-e2e

/skip-all
The change impacts only MC controller.


Getting compier

I have read the guidelines for contributing and I understand

My issue is happening in the latest version of SideMenu (older versions are no longer maintained).
My issue was not solved in the README.
My issue can not be answered on stackoverflow.com.
My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.

Describe the bug
Getting Compiler error
I just installed latest sidemenu version using pod and run the project it is showing the following error
To Reproduce
Steps to reproduce the behavior:

install the latest version SideMenu (6.4.8)
open the project
run the project
See error

Expected behavior
Compiler error should not happen
Screenshots

https://developer.apple.com/documentation/uikit/uiwindow/3197962-windowscene
windowScene exists in iOS13+. Please make sure you're using the latest version of Xcode.


acme: example.com contact emails are forbidden

I added a domain name in via the control plane and it borked my instance. In order to see the error message I tried starting caddy_init (the snowplow_mini_control_plane_api binary does not pass the output through):
ubuntu@ip-xxx.xx.xx.x:~/snowplow$ sudo service caddy_init start
Starting caddy_server
Activating privacy features...2019/02/27 02:21:13 registration error: acme: Error 400 - urn:acme:error:invalidEmail - Error creating new registration :: invalid contact domain. Contact emails @example.com are forbidden

Setting a valid email in the Caddyfile seems to fix things.

ah! nicely spotted :+1:


Does LC_API do anything for this mod?

asking because I would love to use this, as this makes the shotgun actually useful, but LC_API is a nuke to a lot of other mods, hence why a lot of others have weened off of it.

Not yet, I was planning on using it for networking to sync shotgun spread.
What's the issue with it?

Not yet, I was planning on using it for networking to sync shotgun spread.
What's the issue with it?

generally it isn't useful for a lot of use cases and what it does it isn't the best at, hence why mods like Employee Assignments have completely removed it. Since 3.0.0 it also has a chance of breaking entire modpacks/other mods even with the recent hotfixes. I know from experience haha

May as well drop the dependency for now and see if I need to actually use it later on.


[Workshop] There is a heart icon for SP on the workshop cards.

Environment: Windows 10, 64-bit, Google Chrome 107.0.5304.107.
Reproducible: always.
Preconditions
1.Go to https://oos.dmytrominochkin.cloud/#
2.Log in as SP ("Email" =<EMAIL_ADDRESS>"password" = 'Qazwsx789!')
Steps to reproduce

Go to the main page with workshop cards.
Click on the 'heart icon' on the workshop card.

Actual result
There is a heart icon for SP on the workshop cards.

Expected result
For SP, there is no heart icon on the workshop cards.
Labels to be added
"Bug", Priority ("low"), Severity ("low"), Type ("UI").

Fixed

Fixed


Cannot update css?

Hey!
I really like your template and I am hoping to use it as a website for myself! I'm new to web development, so I was hoping I could ask you a question that might be silly. I've been trying to add a menu to the landing page, however when I try to add anything to the main sass file (main.scss), nothing seems to change. Even simply trying to change the color of the font won't work. I use Linux, and I followed your README to install dependencies, but with no luck. I also tried installing and running the command 'gulp', for which I get an error:

default: 'default' errored after 873 ms
...
default: 'styles' errored after 842 ms
default: FAILED
default: TypeError in plugin "gulp-autoprefixer"
default: Message:
default: css.walkAtRules is not a function
....
default: The following tasks did not complete: , watchData, watchMarkup, watchScripts, watchStyles, stylesVendors, scripts, scriptsVendors
default: Did you forget to signal async completion

I was hoping that I am just missing something silly and small that you could point out for me. Anyways, thank you for your time and thank you for the cool site!

Well, I'm not sure what I did, but once I re-downloaded the files, everything seems to be working. Thanks anyway!


Publish v2.1.0 to HomeBrew + MacOS binary

Hi @erikgaal,
Would you be so kind as to publish v2.1.0 to Homebrew and maybe attach the binary for MacOS to the latest release?

https://github.com/Homebrew/homebrew-core/pull/46590

Hi @o2sh,
I'm looking into setting up a script using GitHub Actions that automatically published new version to Homebrew. But we (you) need to request access for it here. Would you like to do that?
Thanks!

Done :+1:

2.1.0 is now available on Homebrew


fix file modifying on windows

fix #105

@Fronkan any chance you could try this out? You can download the binaries from github actions here.
I'm installing windows as a VM so I can try it, but it's slowwww.

It seems to be working. Tried with both watch and awatch. Both now yields:
{(<Change.modified: 2>, 'C:\\...\\./watched\\myfile.txt')}

Thanks so much. I also fired up a windows VM and confirmed it's working, also confirmed #110 as I suspected.


Nil pointer dereference in /json/search-data.json with .File.BaseFileName after upgrading to v0.8.5

Description
After upgrading from Hextra v0.8.4 to v0.8.5, the site build fails due to an error in /json/search-data.json. The .File.BaseFileName property references a nil value, leading to a runtime error. The issue occurs on a multilingual site with English and a partial Spanish translation.
Steps To Reproduce

Upgrade Hextra to v0.8.5.
Run hugo server --buildDrafts --disableFastRender.
Observe the error in the console.

Expected Behavior
The site should build successfully without errors.
Actual Behavior
The build fails with a nil pointer dereference error.
Screenshots
N/A
Environment

Hugo Version: v0.136.0
Browser/OS: Firefox, Arch Linux
Theme Version: v0.8.5

Additional Context
The log error is:
Error: error building site: EXECUTE-AS-TEMPLATE: failed to transform "/json/search-data.json" (application/json): template: /json/search-data.json:14:51: executing "/json/search-data.json" at <$page.File.BaseFileName>: error calling BaseFileName: runtime error: invalid memory address or nil pointer dereference

Hi, thanks for reporting. Do you have the link to the site source or a minimal reproducible example?

Caused by this https://github.com/imfing/hextra/commit/a97a1791cc518d9d78d7fc54deead77d65877895#diff-878d857f7dcdc7fd275c8ebd8d44c3894aee03519344b2cc1b55c079314a4bfeL10
The error is caused by a page that doesn't have a file, previously excluded because it didn't have Content either.
It could be fixed if pages without a File are excluded (??), but I'm also curious to see en example.

Caused by this a97a179#diff-878d857f7dcdc7fd275c8ebd8d44c3894aee03519344b2cc1b55c079314a4bfeL10
The error is caused by a page that doesn't have a file, previously excluded because it didn't have Content either.
It could be fixed if pages without a File are excluded (??), but I'm also curious to see en example.

Right, that exclusion line is the only change we made. Not sure why page.File.BaseFileName would cause a nil pointer dereference panic, maybe could also be a Hugo bug?

@Gr3q i'll revert the search-data line change for now as I saw another person ran into the same issue

@Gr3q i'll revert the search-data line change for now as I saw another person ran into the same issue

done, cut a new release that reverts the change in search-data.json: https://github.com/imfing/hextra/releases/tag/v0.8.6
will look into the root cause when I have time.


CellsInserted event not raised when adding a cell from imported library

Hey guys,
when adding a cell from an imported library in the sidebar, no cellsInserted event is fired.
This is due to the fact, that in Sidebar.prototype.createDropHandler() the event is only fired when allowCellsInserted is true:
if (allowCellsInserted) { graph.fireEvent(new mxEventObject('cellsInserted', 'cells', select));}
The reason for this can be tracked down to diagramly's editorUI.libraryloaded(), where allowCellsInserted is set to false (last argument):
content.appendChild(this.sidebar.createVertexTemplateFromCells(cells, img.w, img.h, img.title || '', true, false, false));
Is this behaviour intentional?

Thanks for the report. This will be fixed in the next release. (We're moving towards firing the event for all inserted cells to support configurable defaults, which should always be used.)


docs: .spec.volumeName is set with name of PV and not PVC

In README.md, in section "How does it work?", there is this point:

Creates the new PVC with the .spec.volumeName set to the existing PVC

which I believe it should read

Creates the new PVC with the .spec.volumeName set to the existing PV

as .spec.volumeName takes name of PV, not PVC.

Yes, you are absolutely right. I have opened a PR to correct it (#73). Thanks for the issue 👍🏻

For a moment I lost confidence in my own understanding - rookie here :) Thanks!


implement update method for coef vector

added simple update method to feols object to update coefficient vector in online-learning settings. Use demonstrated in quickstart notebook.
Also fleshed out confint section of quickstart notebook.

Thanks for adding the tests @apoorvalal - should I merge this as is & we can add inference for the update method in a separate PR?

I think merging as is should be fine; the update method is largely about
coefficient vectors anyway. I think inference for new observations is a
bigger PR (might need either conformal inference or anytime-valid
regression methods for that).
--
Apoorva Lal
@.*** | apoorvalal.github.io
On Wed, 31 Jul 2024 at 12:40, Alexander Fischer @.***>
wrote:

Thanks for adding the tests @apoorvalal https://github.com/apoorvalal -
should I merge this as is & we can add inference for the update method in
a separate PR?
—
Reply to this email directly, view it on GitHub
https://github.com/py-econometrics/pyfixest/pull/567#issuecomment-2261297706,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC4G5DUFNYRBMPMGZALMQN3ZPE4TDAVCNFSM6AAAAABLSR5VIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRRGI4TONZQGY
.
You are receiving this because you were mentioned.Message ID:
@.***>


added metrics support for akeyless

Problem Statement
What is the problem you're trying to solve?
Added metrics for akeyless provider
Related Issue
Fixes #...
Proposed Changes
How do you like to solve the issue and why?
Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[x] My changes have reasonable test coverage
[x] All tests pass with make test
[x] I ensured my PR is ready for review with make reviewable

@renanaAkeyless - Can you please this review this PR as well?

Hi @rogertuma , can you please the PR?


No devices detected (Repository example)

For some reason the example in the repo isn't working on my device.
I'm running on a Samsung S21+.

Same issue on Samsung A52

turn on gps and rescan


Add kapp boxes and lines blog post

Looks good to me, let's squash when we merge this branch.

LGTM!


ocaml-ng.ocamlPackages_4_05.lablgtk: add -fcommon workaround

Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:
ld: ml_gtktree.o:(.bss+0x0): multiple definition of
  `ml_table_extension_events'; ml_gdkpixbuf.o:(.bss+0x0): first defined here

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval


Decoupling ROS packages from docker

Hi,
I've wanted to ask/suggest if it is possible to decouple docker git repository from ROS packages.
The main reason to do that would be easier pulling simulation updates (mbzirc_ros and mbzirc_ign) than constantly
rebuilding docker images as well as constantly recreating docker containers.
Currently, mbzirc_ros and mbzirc_ign are part of mbzirc repository which is used to build docker image.
Decoupling them in separate repositories would enable us to have up-to-date git repositories of ROS packages which could then
be updated inside of an existing docker container with something as follows:
cd <workspace>/mbzirc_ros
git pull
cd ../mbzirc_ign
git pull
cd <workpace>
colcon build

Which is quite more practical than pulling this repository and copying mbzirc_ign and mbzirc_ros into workspace.
Also, when copying packages,  we lose track of current package version.

hi, I would like to see if we can workaround the issue without separating the repositories since some of the infra work we're doing for evaluation requires them to be in a single repo.
I just want to check your use case here. You would like to work inside the docker container and keep mbzirc packages up-to-date without rebuilding a new docker image? You can do this without copying mbzirc_ign and mbzirc_ros into the workspace but just need to update some permissions. Not sure if the following helps with your use case:

Go to the mbzirc_ws directory, remove build directories, and change permission to developer
cd mbzirc_ws
sudo rm -fr build install log
sudo chown -R developer:developer *

Go to the mbzirc directory (there is a typo here but being fixed in a PR) and update url to https so you can pull the latest changes
cd ~/mbzirc_ws/src/mbzric # typo here
git remote set-url origin https://github.com/osrf/mbzirc.git
git pull

You should then be able to rebuild the workspace with latest changes
cd ~/mbzirc_ws/
IGNITION_VERSION=fortress colcon build --merge-install

Works.
Thanks a lot! :+1:

Regarding this issue,
At the time It worked, however when I built new docker image and did following:

Changed permissions as stated
Cloned newest mbzirc as instructed
Tried to run colcon build in the <workspace_path> however, I get this output:

CMake Error at CMakeLists.txt:11 (find_package):
  By not providing "Findmbzirc_ros.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "mbzirc_ros", but CMake did not find one.

  Could not find a package configuration file provided by "mbzirc_ros" with
  any of the following names:

    mbzirc_rosConfig.cmake
    mbzirc_ros-config.cmake

Then I went and checked command in docker and ran following commands:
rm -rf install build
bash -c 'source /opt/ros/galactic/setup.bash   && colcon info mbzirc_ros   && colcon build --merge-install

Build fails with following msg:
CMake Error at CMakeLists.txt:11 (find_package):
  By not providing "Findmbzirc_ros.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "mbzirc_ros", but CMake did not find one.

  Could not find a package configuration file provided by "mbzirc_ros" with
  any of the following names:

    mbzirc_rosConfig.cmake
    mbzirc_ros-config.cmake

  Add the installation prefix of "mbzirc_ros" to CMAKE_PREFIX_PATH or set
  "mbzirc_ros_DIR" to a directory containing one of the above files.  If
  "mbzirc_ros" provides a separate development package or SDK, be sure it has
  been installed.

Therefore I'm not to build mbzirc ROS packages. Bear in mind that ROS is sourced and I successfuly built workspace during docker build few weeks ago.
Help would be appreciated.

Managed to build it as follows:
cd <workspace>/src
git clone https://github.com/ignitionrobotics/ros_ign.git -b galactic
cd ..
colcon build


Typecheck declare and actual inline module types

This should finish the initial implementation of the module linking
proposal in this repository. The last piece that I can think of was to
validate the declared module types (the module section) against the
actual module types (the module code section).

Ok I'm gonna go ahead and merge this. I'll need to rebase #40 anyway for this and I'll make sure to add docs there as part of the rebase.