Fix "Train - My Name Is" test case

Refactored into our latest spec style
Fixed test case to add in an additional training in "My name is <name>" to account for latest LUIS behavior changes.
Put code in to fail the test once this bug has been fixed so that we remember to validate that condition.
Bug 1956: Replaced Entity Indicator has been lost when training, can still be seen when editing a training

:tada: This PR is included in version 0.347.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: fix missing mongo apt signing_key when install mongodb-mongosh

What type of PR is this?
bug fix/mongo install not sign

What this PR does / why we need it:
Move MongoDB GPG public key to the front

thanks for your pr!


TODO comment left in AccountCreateTransaction

There is a TODO comment left in the AccountCreateTransaction code. Not sure if there is something left here or if it should be removed. https://github.com/hashgraph/hedera-sdk-swift/blob/main/Sources/Hedera/AccountCreateTransaction.swift#L39
Additional TODO comments:

https://github.com/hashgraph/hedera-sdk-swift/blob/main/Sources/Hedera/AccountInfo.swift#L3
https://github.com/hashgraph/hedera-sdk-swift/blob/main/Sources/Hedera/AccountInfo.swift#L26

Fixed in https://github.com/hashgraph/hedera-sdk-rust/pull/204


"High Resolution Matrix Export" is not selecting regions of interest

Hello,
I am trying to select a specific region of a stereo-seq dataset using the instructions here: https://stereopy.readthedocs.io/en/latest/Tutorials/High_Resolution_Export.html
If I do:
ins = tissue_bin50_a2.plt.interact_spatial_scatter(width=500, height=500, poly_select=False)

and then use the lasso selection, the shaded lasso region appears, but then after dragging it over my region of interest and releasing my left mouse button, the region disappears and nothing happens. In contrast, in the tutorial GIF, the lasso region seems to remain while the rest of the dataset disapears but this does not happen for me.
I have also tried:
ins = tissue_bin50_a2.plt.interact_spatial_scatter(width=500, height=500, poly_select=True)

Here, I can select my region of interest using the PolyAnnotator Tool and I get the polygon coordinates after clicking the shaded region. I then try:
ins.add_selected_area()

But when I try to export the high resolution selected region, I get a message that says:
processing selected 1 area
selections not found, please choose a selection area

See the attached screenshot

It seems like the polygon coordinates are not ending up in the ins object I created. I even have tried clicking the "export" button but nothing happens.
What am I doing wrong?

Hello, I have not found your problem here yet. What version do you have? If it is not the latest version, please upgrade to the latest version and try.

Hi @Zhenbin24
I am using stereopy 0.12.1 installed via pypi. I can try updating the version and see if that helps.
Thanks,
Brendan

I just updated to version 1.0.0.
Now, when I do:
ins = tissue_bin50_a2.plt.interact_spatial_scatter(width=500, height=500, poly_select=True)

I create the polygon, select it, see the polygon coordinates appear. But then when I do:
ins.add_selected_area()

I get an Exception error:
The selected area's data cannot be empty
Any idea why it isn't working?
Thanks,
Brendan

Hello, you can refer to this reply to see if the steps you performed are correct.
I tried it here, if done correctly there will be no problem


Publish new release package to PyPI

Now that this repository has been moved to its new home at this organization, would someone please publish a new githubrelease package to PyPI so the fix in #73 can exist in a packaged release?

Hi folks. Any chance we can get a new github-release package published to PyPI?


[theme] Compact-RED: backport changes from master

RELENG_2_3_2 is a maintenance branch, we try to change it only when necessary. This is most a cosmetic change for a non-official theme


Enhancement, PlotRegion with background

set horizontal and vertical gaps around plot region
set plot region's background color
set border for the region plot
fixed image auto resize bug
added several code improvements

It seems that the resizing of the images does not work with every screen. Also the grey background should fill the whole gap between the datawindow and the sidebarmenu as well as the gap between the datawindow and the devices menu.

Do you mean this way, please?


The visual appearance and structure of the homepage could be better

The visual appearance and structure of the homepage is pretty basic at the moment and could be improved quite a bit, issues include:

There are no images to make the content feel richer and more inviting.
We are not taking advantage of the thoughtbot system of illustrations.
The hierarchy is quite basic, single column, mostly, meaning the page is quite long.
There is not enough visual variation to discern the difference between a list of exercises from a list of schedules.

Design: https://www.figma.com/file/VcLx6U0cNVQmeFrrfA6LPc/Design-Sprint-Guide?node-id=1157%3A201&t=Hnl6iOwWN1h6C3c6-1

@fatimaburke Is there any more work to be done on this issue?

@davidrnovak has done the latest work on this along with some structural refactors from @mijimenez but I'm not sure what's left.

@LkeMitchll I'm going to tackle the Resource & Glossary and CTA sections today. I'll update the issue when I'm done with those sections.

We're moving this to done. Anything that could be improved should have new, individual issues created for them. Thanks, all!


Unbale to execute know command.

**Description **
In two day i have received 300+ messages here is the
To Reproduce
Just monitor the serial terminal #124 this issue still excited, I think after updating MQTT value system rebooted.
Expected behavior
System should execute this command as this is trained string and the other suitable way is just asking time from orange pi #130 so i think we don't need to send this message to board.
Additional context
Kindly make sure this command executes and fix #124 as soon as possible.

Issue got fixed in #129


load modules when called from a remote session

when calling the run-tests.sh script from a remote session modules are not loadable
sourcing /etc/profile at the beginning of the test script will allow the modules to be used

Thanks @xpillons!


Operator gets killed because it runs out of memory

When following these instructions, I have noticed that the default settings for the operator do not provide enough memory to run it.
After running helm upgrade --install hivemq hivemq/hivemq-operator, the operator pod will be created but when monitoring with K9s, you can see that it crashes pretty soon due to an OOM error.
The pod will restart pretty quickly, however it does not seem to function properly after that.
I suggest increasing the default value for the operator memory limit.

Hi @florianluediger I will review this, we have not seen this behavior yet,  can you provide more context for the error, please?

Sure, just let me know what you need to know. Here is some more general information:
I have started minikube with 8192M of memory and 4 CPUs.
Then I have executed helm upgrade --install hivemq hivemq/hivemq-operator with no special values provided.
Here is the log of the first start of the hivemq operator pod (grabbed from k9s):
Picked up JAVA_TOOL_OPTIONS: -XX:+UnlockExperimentalVMOptions -XX:InitialRAMPercentage=30 -XX:MaxRAMPercentage=80 -XX:MinRAMPercentage=30                                                                       │
09:40:00.261 [main] INFO  com.hivemq.Application - Preparing SSL files                                                                                │
09:40:08.758 [main] INFO  com.hivemq.Application - Wrote converted key store to /tmp/store.p12                                                                                │
 __  __ _                                  _                                                                                │
|  \/  (_) ___ _ __ ___  _ __   __ _ _   _| |_                                                                                │
| |\/| | |/ __| '__/ _ \| '_ \ / _` | | | | __|                                                                                │
| |  | | | (__| | | (_) | | | | (_| | |_| | |_                                                                                │
|_|  |_|_|\___|_|  \___/|_| |_|\__,_|\__,_|\__|                                                                                │
  Micronaut (v2.4.2)                                                                                │
                                                                                │
Stream closed EOF for default/hivemq-hivemq-operator-operator-6fdb648d47-pbcbb (operator)

The log of the operator pod after restarting the pod is empty. It seems like after the restart, the micronaut service does not start anymore.
Here is the output of kubectl describe pod hivemq-hivemq-operator-operator-6fdb648d47-xv6rg:
Name:         hivemq-hivemq-operator-operator-6fdb648d47-xv6rg
Namespace:    default
Priority:     0
Node:         minikube/<IP_ADDRESS>
Start Time:   Wed, 10 Aug 2022 11:41:45 +0200
Labels:       app=hivemq-operator
              operator=hivemq-hivemq-operator
              pod-template-hash=6fdb648d47
Annotations:  <none>
Status:       Running
IP:           <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  ReplicaSet/hivemq-hivemq-operator-operator-6fdb648d47
Containers:
  operator:
    Container ID:   docker://3de23c5599f24957108136bceb2f5e4682a6c47ded9b16a4bcb83a4a6cd38dfd
    Image:          hivemq/hivemq-operator:4.7.1
    Image ID:       docker-pullable://hivemq/hivemq-operator@sha256:96faf436164ca20248587b37593308b9422bca71385063b3f2a4859b9a8666ef
    Port:           8443/TCP
    Host Port:      0/TCP
    State:          Running
      Started:      Wed, 10 Aug 2022 11:42:18 +0200
    Last State:     Terminated
      Reason:       OOMKilled
      Exit Code:    137
      Started:      Wed, 10 Aug 2022 11:41:45 +0200
      Finished:     Wed, 10 Aug 2022 11:42:17 +0200
    Ready:          True
    Restart Count:  1
    Limits:
      cpu:     800m
      memory:  512M
    Requests:
      cpu:     200m
      memory:  512M
    Environment:
      JAVA_TOOL_OPTIONS:       -XX:+UnlockExperimentalVMOptions -XX:InitialRAMPercentage=30 -XX:MaxRAMPercentage=80 -XX:MinRAMPercentage=30
      OPERATOR_LOG_LEVEL:      INFO
      CREATE_CRD:              false
      MICRONAUT_SERVER_PORT:   8443
      MICRONAUT_SSL_ENABLED:   true
      OPERATOR_SSL_PATH:       /etc/ssl/admission
      MICRONAUT_CONFIG_FILES:  /tmp/application.yml
      SSL_FQDN:                hivemq-operator-operator.default.svc
    Mounts:
      /etc/ssl/admission from ssl-secrets (rw)
      /templates from templates (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-tvw8l (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  templates:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      hivemq-hivemq-operator-operator-templates
    Optional:  false
  ssl-secrets:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  hivemq-hivemq-operator-admission
    Optional:    false
  kube-api-access-tvw8l:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type    Reason     Age                From               Message
  ----    ------     ----               ----               -------
  Normal  Scheduled  11m                default-scheduler  Successfully assigned default/hivemq-hivemq-operator-operator-6fdb648d47-xv6rg to minikube
  Normal  Pulled     10m (x2 over 11m)  kubelet            Container image "hivemq/hivemq-operator:4.7.1" already present on machine
  Normal  Created    10m (x2 over 11m)  kubelet            Created container operator
  Normal  Started    10m (x2 over 11m)  kubelet            Started container operator

Hello, @florianluediger. Thank you very much for your contribution. Unfortunately, your change is for a specific use case, so we will reject it for the time being. We suggest overriding the values using the command from the official documentation
helm upgrade --install -f myCustomValues.yaml hivemq hivemq/hivemq-operator
We will also recommend using smaller cluster and node requirements or providing more memory to the VM
hivemq:
  nodeCount: "1"
  cpu: "2"
  memory: "2Gi"

Best wishes,

@hurtadosanti I ran into the same issue and tbh I don't understand how this qualifies as a "specific use case". I tried installing the operator onto multiple clusters with its default configuration and k8s always ends up killing it due to an OOM issue.
Why are the default memory limits set to 512 MiB if 512 MiB are not sufficient for running the operator? I understand that I am able to override these limits but people who try out the operator expect it to run in its most basic default configuration first. This is obviously not the case.

Hi, @denniseffing thanks for the comment, can you please provide more information about the clusters you are testing?


[Bug] npu断点续训可能存在问题

Reminder

[X] I have read the README and searched the existing issues.

System Info
llama factory 0.8.2
NPU H910*16
Reproduction
训练qwen2
Expected behavior
在不打开load_best_model_at_end: true训练正常，打开后最后loss会出错，看上去是断点续训有问题。
[INFO|trainer.py:2642] 2024-08-12 18:23:46,712 >> Loading best model from /mnt/dolphinfs/hdd_pool/docker/user/414793833799687_dc1030be9f32be5a90d89477da7b1882/ckpts/adapter/checkpoint-500 (score: 0.7748436331748962).
18:23:59.474 Traceback (most recent call last):
18:23:59.474   File "/home/.local/lib/python3.8/site-packages/llamafactory/launcher.py", line 23, in <module>
18:23:59.474     launch()
18:23:59.474   File "/home/.local/lib/python3.8/site-packages/llamafactory/launcher.py", line 19, in launch
18:23:59.474     run_exp()
18:23:59.474   File "/home/.local/lib/python3.8/site-packages/llamafactory/train/tuner.py", line 47, in run_exp
18:23:59.474     run_sft(model_args, data_args, training_args, finetuning_args, generating_args, callbacks)
18:23:59.474   File "/home/.local/lib/python3.8/site-packages/llamafactory/train/sft/workflow.py", line 88, in run_sft
18:23:59.474     train_result = trainer.train(resume_from_checkpoint=training_args.resume_from_checkpoint)
18:23:59.474   File "/home/.local/lib/python3.8/site-packages/transformers/trainer.py", line 1948, in train
18:23:59.475     return inner_training_loop(
18:23:59.475   File "/home/.local/lib/python3.8/site-packages/transformers/trainer.py", line 2414, in _inner_training_loop
18:23:59.475     self._load_best_model()
18:23:59.475   File "/home/.local/lib/python3.8/site-packages/transformers/trainer.py", line 2711, in _load_best_model
18:23:59.475     model.load_adapter(self.state.best_model_checkpoint, active_adapter)
18:23:59.475   File "/home/.local/lib/python3.8/site-packages/peft/peft_model.py", line 1117, in load_adapter
18:23:59.476     load_result = set_peft_model_state_dict(
18:23:59.476   File "/home/.local/lib/python3.8/site-packages/peft/utils/save_and_load.py", line 395, in set_peft_model_state_dict
18:23:59.476     load_result = model.load_state_dict(peft_model_state_dict, strict=False)
18:23:59.476   File "/usr/local/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 2152, in load_state_dict
18:23:59.476     raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
18:23:59.477 RuntimeError: Error(s) in loading state_dict for PeftModelForCausalLM:
18:23:59.477  While copying the parameter named "base_model.model.model.layers.0.self_attn.q_proj.lora_A.default.weight", whose dimensions in the model are torch.Size([8, 3584]) and whose dimensions in the checkpoint are torch.Size([8, 3584]), an exception occurred : ('enable_peer_access:torch_npu/csrc/core/npu/NPUPeerToPeerAccess.cpp:39 NPU error, error code is 507899\n[ERROR] 2024-08-12-18:23:49 (PID:3502, Device:9, RankID:9) ERR00100 PTA call acl api failed\n[Error]: An internal error occurs in the Driver module. \n        Rectify the fault based on the error information in the ascend log.\nEL9999: Inner Error!\nEL9999  [drv api] halDeviceEnableP2P failed: devIdDes=9, phyIdSrc=0, drvRetCode=17![FUNC:EnableP2P][FILE:npu_driver.cc][LINE:3011]\n        TraceBack (most recent call last):\n        rtEnableP2P execute failed, reason=[driver error:internal error][FUNC:FuncErrorReason][FILE:error_message_manage.cc][LINE:53]\n        call rtEnableP2P failed, deviceId = 9, peerPhyId = 0, runtime result = 507899[FUNC:ReportCallError][FILE:log_inner.cpp][LINE:161]\n',).
18:23:59.477  While copying the parameter named "base_model.model.model.layers.0.self_attn.q_proj.lora_B.default.weight", whose dimensions in the model are torch.Size([3584, 8]) and whose dimensions in the checkpoint are torch.Size([3584, 8]), an exception occurred : ('enable_peer_access:torch_npu/csrc/core/npu/NPUPeerToPeerAccess.cpp:39 NPU error, error code is 507899\n[ERROR] 2024-08-12-18:23:49 (PID:3502, Device:9, RankID:9) ERR00100 PTA call acl api failed\n[Error]: An internal error occurs in the Driver module. \n        Rectify the fault based on the error information in the ascend log.\nEL9999: Inner Error!\nEL9999  [drv api] halDeviceEnableP2P failed: devIdDes=9, phyIdSrc=0, drvRetCode=17![FUNC:EnableP2P][FILE:npu_driver.cc][LINE:3011]\n        TraceBack (most recent call last):\n        rtEnableP2P execute failed, reason=[driver error:internal error][FUNC:FuncErrorReason][FILE:error_message_manage.cc][LINE:53]\n        call rtEnableP2P failed, deviceId = 9, peerPhyId = 0, runtime result = 507899[FUNC:ReportCallError][FILE:log_inner.cpp][LINE:161]\n',).

Others
No response

hi,我也遇到类似的报错，这个后面有解决方式吗？


openapi: Fix display of boolean types in examples.

Fixed boolean statements being displayed in camel case in API
documentations to match JSON format.

Fixes #18010
Testing plan:
Manually tested in browser
GIFs or screenshots:

Merged, thanks for tracking this down @ArunSankarKs!


Reenable scrolling on the login screen

It's hard to see because nibs are terrible, but the "scrollEnabled" flag was set to false

@mikekatz please review

:+1:

Merging since test breakage is unrelated.


Cloudflare Workers onOpen WebSocket event is not triggered

What version of Hono are you using?
4.6.3
What runtime/platform is your app running on?
Cloudflare Workers
What steps can reproduce the bug?
The onOpen websocket event is not called
steps:

npm create<EMAIL_ADDRESS>Select cloudflare workers
paste code:

import { Hono } from 'hono';
import { upgradeWebSocket } from 'hono/cloudflare-workers';

const websocketClients: WebSocket[] = [];

const app = new Hono();

app.get(
  '/ws',
  upgradeWebSocket((c) => {
    console.log('WebSocket upgrade requested');

    return {
      onOpen(event, ws) {
        console.log('WebSocket connection opened');
        websocketClients.push(ws.raw!);
      },
      onError(evt, ws) {
        console.error('WebSocket error:', evt);
      },
      onMessage(event, ws) {
        console.log(`Message from client: ${event.data}`);
        websocketClients.forEach((client) => {
          if (client !== ws.raw) {
            client.send(event.data + ' ' + JSON.stringify(websocketClients));
          }
        });
      },
      onClose: (_, ws) => {
        console.log('WebSocket connection closed');
        const index = websocketClients.indexOf(ws.raw!);
        if (index > -1) {
          websocketClients.splice(index, 1);
        }
      },
    };
  })
);

export default app;

What is the expected behavior?
console to print "WebSocket connection opened"
What do you see instead?
no "WebSocket connection opened"

Additional information
No response

Hi @imLymei
If I remember correctly, Cloudflare Workers does not support the open. For instance, the open is not listed the below doc:
https://developers.cloudflare.com/workers/runtime-apis/websockets/#events
Hey @naporin0624 Is it right?

 Thank you for clarifying things up!

That definitely look awful as the API: it going to produce a lot of shitcode. And after you fix that confirmed bug, the Hone shitcode not going anywhere from the projects codebases

I found a lot of fake documentation materials about onOpen callback. For example, this one
https://dev.to/yutakusuno/hono-simple-messaging-app-using-bun-and-websocket-mnk
How do I get the ws instance to send the message from the server side first?
  upgradeWebSocket((_) => ({
    onOpen(_, ws) {
      const rawWs = ws.raw as ServerWebSocket;
      rawWs.subscribe(topic);
      console.log(`WebSocket server opened and subscribed to topic '${topic}'`);
    },

That is bun code and seems to have nothing to do with cf workers, is it not?
Also, I think the restrictions on cf workers is not an issue that Hono can do anything about.


Remove check auth before each page load

Remove check auth before each page load, make it just check one when enter
#35

Closed

See comment on issue #35


Improve file sync service

file_sync: remove the unused symbols
file_sync: return 0 when state_process_send_header receive ID_DONE
file_sync: avoid memory copy in state_process_send_file

BTW, @spiriou do you plan migrate file sync service to libuv?

BTW, @spiriou do you plan migrate file sync service to libuv?

No. I thought about handling non-blocking IOs for FS but it adds a lot of complexity so I stopped.
I only plan to finish adb reverse/forward implementation for now.

BTW, @spiriou do you plan migrate file sync service to libuv?

No. I thought about handling non-blocking IOs for FS but it adds a lot of complexity so I stopped.
I only plan to finish adb reverse/forward implementation for now.

Nice, when you will finish the work?

BTW, @spiriou do you plan migrate file sync service to libuv?

No. I thought about handling non-blocking IOs for FS but it adds a lot of complexity so I stopped.
I only plan to finish adb reverse/forward implementation for now.

Nice, when you will finish the work?

Soon. The feature is in the draft branch but I was not happy with the API and libuv abstraction so it's still not in master.

BTW, @spiriou do you plan migrate file sync service to libuv?

No. I thought about handling non-blocking IOs for FS but it adds a lot of complexity so I stopped.
I only plan to finish adb reverse/forward implementation for now.

Nice, when you will finish the work?

Soon. The feature is in the draft branch but I was not happy with the API and libuv abstraction so it's still not in master.

Good, I will take a look.


Type Error with examples

Hello.
Thanks for this awesome work.
I tried the examples and I am getting an error similar to #5 with the updated code as well.
The error is
(pignet2) amin@BTX-CC1:~/softwares/PIGNet2$ python src/exe/predict.py ./src/ckpt/pda_0.pt -p examples/protein.pdb -l examples/ligand_single_conformation.sdf -o examples/case11.txt --no-prot-pdb --no-prot-sdf
Load from: /home/amin/softwares/PIGNet2/src/ckpt/pda_0.pt
Writing results to: /home/amin/softwares/PIGNet2/examples/case11.txt
device: device(type='cuda', index=0)
Traceback (most recent call last):
  File "/home/amin/softwares/PIGNet2/src/exe/predict.py", line 161, in <module>
    main(args)
  File "/home/amin/softwares/PIGNet2/src/exe/predict.py", line 106, in main
    data_list = [
  File "/home/amin/softwares/PIGNet2/src/exe/predict.py", line 107, in <listcomp>
    read_data(
  File "/home/amin/softwares/PIGNet2/src/exe/predict.py", line 68, in read_data
    datum = complex_to_data(ligand, mol_target, key=name, conv_range=conv_range)
  File "/home/amin/softwares/PIGNet2/src/data/data.py", line 271, in complex_to_data
    assert set(ligand.keys()) == set(target.keys())
TypeError: 'list' object is not callable

The torch-geometric version seems correct
mamba list | grep torch
torch                     1.9.1+cu111              pypi_0    pypi
torch-cluster             1.5.9                    pypi_0    pypi
torch-geometric           2.0.3                    pypi_0    pypi
torch-scatter             2.0.9                    pypi_0    pypi
torch-sparse              0.6.12                   pypi_0    pypi
torch-spline-conv         1.2.1                    pypi_0    pypi

I would be really grateful for any suggestions.
Best,
Amin.

Hello.
In your case, you need the other way around: the keys attribute should be used as-is, not with (); that is,
    assert set(ligand.keys) == set(target.keys)


Cache path param, and save cache with pretty name for offline usage

cache path can now be saved with rviz_satellite_cache_path
folders from cache path would be shown as map source option if Use Lcoal Folder is set to true
use can rename the folder in the cache path to more appropriate names (unlike the hash numbers)
and they would be listed in the dropdown option of local folders to choose from
sample data and launch generated to show features corresponding to existing sample bag

@jitrc I'm closing this now since this is outdated. Furthermore, you didn't provide any motivation behind your changes. I don't see why it's an advantage that the tiles have a pretty/ readable name.


[spi_device,rtl] Consider adding signalling mechanism to abort

Description
https://github.com/lowRISC/opentitan/blob/8da2b0d46e7dd24be4155fac83ee4fe3c7a956c2/hw/ip/spi_device/rtl/spi_device.sv#L204

@a-will is this related to https://github.com/lowRISC/opentitan/issues/20654?

@a-will is this related to #20654?

No, this issue appears to be about some kind of OT-triggered abort (which doesn't make sense to me). Notice that it's assigned by CSRs:
https://github.com/lowRISC/opentitan/blob/8da2b0d46e7dd24be4155fac83ee4fe3c7a956c2/hw/ip/spi_device/rtl/spi_device.sv#L424
The other issue is about being able to handle the host abandoning SPI TPM transactions before they have completed. The buffering architecture has a poor design for handling such sequences, since it adds ambiguity.

Ah I see. It looks like this is allocated for generic mode, which we plan to deprecate:
https://github.com/lowRISC/opentitan/blob/143098eec598e92bd7dd20939d5c7587f4039705/hw/ip/spi_device/data/spi_device.hjson#L407-L418
Hence this can be resolved by removing it entirely.

Closing, since we plan to remove firmware mode.


Some improvements ideas for minimal_non_dust()

It would be nice to add the following to the minimal dust function minimal_non_dust: https://github.com/rust-bitcoin/rust-bitcoin/blob/master/bitcoin/src/blockdata/transaction.rs#L538

Add tests
Replace magic numbers with consts
Use FeeRate type

Agree with adding tests. The code was effectively copied from Core (oh, I think I messed up the license! we need to fix that), but I doubt using constants/FeeRate is that helpful.

Also, it seems like this could be a standalone function?

oh, I think I messed up the license! we need to fix that

I highly doubt that a function that simply adds various fixed constants (which are defined with respect to an external protocol) is copyrightable by itself.

I doubt using constants/FeeRate is that helpful.

I tend to agree (though I almost always feel this way about the constants in this library..)

I tend to agree (though I almost always feel this way about the constants in this library..)

Having a small amount of experience with this library now, I'm starting to understand the magic numbers more and where they come from.  For example I've seen 32 + 4 littered all over the place which I can guess is the consensus size of an Outpoint.

https://github.com/rust-bitcoin/rust-bitcoin/blob/83cefefa45e4104d7de12800619c4b65f6287081/bitcoin/src/blockdata/transaction.rs#L549C55-L549C55
Are we sure we need the + 1?
Core compares the dust limit using < ... so = should be OK.

Also, there's a hidden 1 in the * 3 calculation for the MIN_RELAY_TX_FEE. (I checked recently, and the dust calculation does not use the current mempool ejection rate (dynamic) but rather always the MIN_RELAY_TX_FEE (which can be set in config or as a runtime parameter on startup of bitcoind)
Perhaps that should be configurable? I doubt many people are using a non-default value, though.

@junderw nice catch! Shame you didn't review the original PR, it already wasted some satoshis in production. :D
Regarding MIN_RELAY_TX_FEE - the specific purpose of the function is to adhere to the Core's policy because it's usful in smart contracts with presigned transactions where you don't know the fee rate beforehand so you use CPFP with package (LN with anchors, Firefish...) For dynamic dust I think effective_value can be used which is going to be added in #2230
@yancyribbens you could argue it could be a method on script returning the amount and I'd accept a PR that adds it. (Also is_dust method on TxOut to avoid off-by ones like we already have here.) However, this constructor is very useful too in smart contracts.


Tables B and D should be documented as optional

As far as I know, most partners don't implement the "recognition part" of the new EUC LA template. There is a place for this data in the XSD, but many partners won't be able to provide it. We should warn the client implementers about this, and make sure that server implementers know that this part is not required (but still recommended).

We could even think of taking it one step further and removing the "recognition part" from EWP.
As far as I know, the receiving HEI doesn't care about the exact contents of tables B and D. It does sign the LA, but it verifies only tables A and C. So, perhaps, we don't need to actually even suggest the exchange of this data? @erasmus-without-paper/all-members

We would be among those not using it in the near future, but we are good with both ways.

Where are these tables defined?

In the EUC LA template (attached in the repo).


Fetch cannot build

Something you did in the last 12h or so causes Fetch to fail building. The following is what I get back from the CSSWG API server:
Error running preprocessor, returned code: 1.
Traceback (most recent call last):
  File "/sites/api.csswg.org/bikeshed/bikeshed.py", line 5, in
    bikeshed.main()
  File "/sites/api.csswg.org/bikeshed/bikeshed/cli.py", line 193, in main
    doc.preprocess()
  File "/sites/api.csswg.org/bikeshed/bikeshed/Spec.py", line 171, in preprocess
    processBiblioLinks(self)
  File "/sites/api.csswg.org/bikeshed/bikeshed/unsortedJunk.py", line 626, in processBiblioLinks
    ref = doc.refs.getBiblioRef(linkText, status=refStatus, generateFakeRef=okayToFail, silentAliases=okayToFail, el=el)
  File "/sites/api.csswg.org/bikeshed/bikeshed/refs/ReferenceManager.py", line 483, in getBiblioRef
    bib = self.getBiblioRef(candidate["aliasOf"], status=status, el=el, quiet=True)
  File "/sites/api.csswg.org/bikeshed/bikeshed/refs/ReferenceManager.py", line 480, in getBiblioRef
    bib = biblio.StringBiblioEntry(**candidate)
  File "", line 22, in __init__
  File "/sites/api.csswg.org/bikeshed/bikeshed/biblio.py", line 31, in __attrs_post_init__
    self.preferredURL = config.refStatus.snapshot
  File "/sites/api.csswg.org/bikeshed/bikeshed/attr/_make.py", line 240, in _frozen_setattrs
    raise FrozenInstanceError()
bikeshed.attr.exceptions.FrozenInstanceError

I have bisected and this specific exception started happening in commit 3172faa20ddceadd964dc78f3e7f9f938db928ec, the the preceding commit 5cca8a7df56a49b1d4633971bc2b5fb2dc1b99e3 had another issue. On of those two commits are the cause, though.

Tested with make local in https://github.com/whatwg/fetch/commit/c19355984d7a1c110574c46c20a41901df973e5a

The problem applies to the master branch of fetch as well, but not dom. It must have something to do with this bit in the source:
    "HTTP": {
        "aliasOf": "HTTP11"
    },
    "HTTP-SEMANTICS": {
        "aliasOf": "RFC7231"
    },
    "HTTP-COND": {
        "aliasOf": "RFC7232"
    },
    "HTTP-CACHING": {
        "aliasOf": "RFC7234"
    },
    "HTTP-RANGE": {
        "aliasOf": "RFC7233"
    },
    "HTTP-AUTH": {
        "aliasOf": "RFC7235"
    },
    "REFERRER": {
        "aliasOf": "referrer-policy"
    },
    "SW": {
        "aliasOf": "service-workers"
    },
    "UPGRADE": {
        "aliasOf": "upgrade-insecure-requests"
    },
    "HSTS": {
        "aliasOf": "rfc6797"
    },
    "WSP": {
        "aliasOf": "WEBSOCKETS-PROTOCOL"
    },

@tabatkins, is there an open issue for regression testing using all known existing specs using Bikeshed? If the main problem is getting and keep a list of repos up-to-date, that's something I think might naturally fall out of other things I'd like to do, so I'm interested to help.

Fixed, sorry. Was testing against DOM, but it doesn't exercise this particular path, and none of my automatic tests were using a string-based biblio entry either; I'll fix that.
@foolip No open issue yet; I'll open one.


We need more details in the "Block malware on upload" paragraph

Can you please add licensing requirements (if any apart AAD Premium P1) in the paragraph "Block malware on upload" when protecting upload/download of malware to/from Microsoft first party saas app (i.e. OneDrive for Business) vs third party saas apps (i.e. Dropbox)? It's not clear if we need Defender for O365 Plan 1.
Can you also provide more details on how those checks done by MCAS works (i.e. detonation vs threat intellingence)?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 019ab0de-8c3b-7eba-3506-cc2ab655b4ed
Version Independent ID: 8f37cbfb-edce-a737-5bc8-17f2ed3d5958
Content: Create session policies in Cloud App Security
Content Source: CloudAppSecurityDocs/session-policy-aad.md
Service: cloud-app-security
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

Thanks for your question. We'll investigate and get back to you.


Something wrong with the diffusers model loader in the Ic-Light workflow

Got some problem with the diffusers model loader in the Ic-Light workflow.
Details are in the following picture.

Thoughts ???

This is not the repository for those nodes, you are using this: https://github.com/kijai/ComfyUI-IC-Light-Wrapper
I wouldn't recommend using the Wrapper version for anything but testing purposes, it doesn't support all features and was just an initial project to test and help comparing results with the native version (which is this current repository)


Fusion helper not starting

Everytime i try to run Fusion helper on my pc it does not load
When i do press run it appears for 1 second then it closes is there anyway i can fix this or?

Hello, This would mean you don't have .net 6.0 you can download it here: https://dotnet.microsoft.com/en-us/download/dotnet/6.0

I have that and i have the same problem

Check an online tutorial and make sure you do everything exactly the same.

Stale


Allow defining schemas for storages

So, this is something I'd really like, but it's also gonna be hard and complicated to implement.
Currently, dph+ is not able to provide auto-completion or sanity checking for storage (obviously).
A way to handle this could be to allow adding a directory (.datapack or something?) which lets you define schemas for the storages you are using.
I am not sure how NBT is defined in dph+ currently, but there has to be already at least an internal way to define the NBT structure of vanilla things. If this already is a format that could be "opened up", that would be cool.
Furthermore, it would be good if you could refer to a vanilla NBT "thing" in your storage. For example, I regularily store item data in storage and I obv. don't want to rewrite vanilla stuff.
Accessing data sources such as vanilla ids, or namespaced ids you define in your datapack to define a certain NBT type would be good as well.
This could also solve the linting problem when you store vanilla stuff in a storage and have to follow whatever random naming vanilla uses.

It might be desirable to use nbtdoc to describe storage format: https://github.com/Yurihaia/mc-nbtdoc

Hello GitHub? I clearly referenced this issue in ff9fef05ddaf551248cdc2d85a9ba02713752e74.


Structural Identifiability for Interpolation

Hello, i have the problem that i have a interpolation function on the righthand-side of one of my ODE terms. In order to have an analytical expression for it i used Lagrange polynomials. However, it seem that the StructuralIdentifiability doesn't really work in this case. Here is some example code:
using DifferentialEquations
using StructuralIdentifiability
using ModelingToolkit

days = [0, 2, 4, 6, 8, 10, 12, 14]
surface = [0, 2, 4, 6, 8, 10, 12, 14]
diam = [0, 2, 4, 6, 8, 10, 12, 14].*2

@variables t IB(t)  # Define the variables
@parameters k gamma thres pow  # Define the parameters
D = Differential(t)

ode = @ODEmodel(
    IB'(t) = k * sum(
        (
            begin
                (
                    prod((t .- days[1:end .!= i])) /
                    prod((days[i] .- days[1:end .!= i]))
                ) * diam[i]
            end
        ) ^ pow / (
            begin
                (
                    prod((t .- days[1:end .!= i])) /
                    prod((days[i] .- days[1:end .!= i]))
                ) * diam[i]
            end
        ) ^ pow + thres ^ pow
        * (
            begin
                (
                    prod((t .- days[1:end .!= i])) /
                    prod((days[i] .- days[1:end .!= i]))
                ) * surface[i]
            end
        )
        for i in 1:length(days)
    ) - gamma * IB,
    y(t) = IB(t)
)

measured = [IB]

# Assess structural identifiability
identifiability_result = assess_identifiability(ode, measured_quantities=measured)

Yes structural identifiability can only be performed on a reduced set of models (rational functions).

The problem is that ODEmodel macros does not really evaluate your Lagrange polynomials. I would suggest the following workarounds:

compute the polynomials separately and put them in explicit form in the macros
(perhaps less tedious) use ModelingToolkit interface (as described here), then you should be able to write such expressions.

Let me know if neither of these helps.

Hello, i tried both approaches, but neither of them seems to work unfortunately. Do you maybe have another idea ho to fix it? This is my attempt at the moment:
using DifferentialEquations
using StructuralIdentifiability
using ModelingToolkit
using Symbolics

# Data points
days = [0, 2, 4, 6, 8, 10, 12, 14]
diam = [0, 2, 4, 6, 8, 10, 12, 14].*2
surface = [0, 2, 4, 6, 8, 10, 12, 14]

# Compute the Lagrange polynomial and return as a symbolic expression
function lagrange_poly(t, x_points, y_points)
    n = length(x_points)
    sum_expr = 0
    for i in 1:n
        term = y_points[i]
        for j in 1:n
            if j != i
                term *= (t - x_points[j]) / (x_points[i] - x_points[j])
            end
        end
        sum_expr += term
    end
    return sum_expr
end

# Define the ODE using the Lagrange polynomial
@variables t IB(t)
@parameters k gamma thres pow
D = Differential(t)

interp_expr = lagrange_poly(t, days, diam)  # Use the computed polynomial here

# Ensure the polynomial expression is compatible with ModelingToolkit
interp_expr_sym = Symbolics.build_function(interp_expr, t)
interp_expr_fn = eval(interp_expr_sym[1])

ode = @ODEmodel(
    IB'(t) = k * (interp_expr_fn(t)^pow / (interp_expr_fn(t)^pow + thres^pow)) - gamma * IB,
    y(t) = IB(t)
)

# Rest of the code for problem setup and analysis
measured = [IB]
identifiability_result = assess_identifiability(ode, measured_quantities=measured)

Hey @pogudingleb,
thank you so much for your incredibly helpful response! Absolutely awesome that you made it work here. I am just trying to run your script with the following package specifications:
[0c46a032] DifferentialEquations v7.11.0
[961ee093] ModelingToolkit v8.73.1
[91a5bcdd] Plots v1.39.0
[220ca800] StructuralIdentifiability v0.5.1
[0c5d862f] Symbolics v5.10.0
But weirdly i get the following error message:
ERROR: LoadError: MethodError: no method matching getindex(::Expr, ::Int64)
Stacktrace:
[1] top-level scope
@ ~/Documents/Identifiability.jl:36
This is weird, because it seems that it is running through in your case.

@MaAl13
This isstrange, I have almost the same versions, it works fine for me. Your stacktrace seem to refer to getindex at the line eqs = ... which I do not see there. Could it be a typo while copying? Like some extra square brackets somewhere instead of parenthesis?

It was indeed a typo i think. It now runs for me :) This is absolutely genius, thank you very much. Also for your detailed explanation in the answers!

Do you also know a clever way to write dF/dt = k/(1+(G(t)/a)^b+(H(t)/c)^d) in rational form? I so far only managed to do it by including 3 ODEs instead of the original one:
dF/dt = -(b*A(t)G'(t)+dB(t)*H'(t))*F^2(t)
dA/dt = (b-1)*G'(t)*A(t)*G(t)/a
dB/dt = (d-1)*H'(t)*B(t)*H(t)/c
Also if i have instead of the Lagrange polynomial only a fraction of two polynomials that is given and only depends on x, not on x_points and y_points, would you include it directly in the equation, or do the same as with the Lagrange polynomial?

@pogudingleb Do you also know a clever way to write dF/dt = k/(1+(G(t)/a)^b+(H(t)/c)^d) in rational form? I so far only managed to do it by including 3 ODEs instead of the original one: dF/dt = -(b*A(t)_G'(t)+d_B(t)*H'(t))*F^2(t) dA/dt = (b-1)*G'(t)*A(t)*G(t)/a dB/dt = (d-1)*H'(t)*B(t)*H(t)/c

3 ODEs sounds a fair number in this case but I am not sure I understand the particular transformation you have performed. What are your A and B? I would take A(t) = (G(t)/a)^b and B(t) = (H(t) / c)^d. Note that in this case a and b should disappear from the equations. And this is how it should work: you "trade" two parameters for two new initial conditions A(0) and B(0), so the total dimension of the model stays the same, and you will be able to transfer identifiability results back and forth.

Also if i have instead of the Lagrange polynomial only a fraction of two polynomials that is given and only depends on x, not on x_points and y_points, would you include it directly in the equation, or do the same as with the Lagrange polynomial?

I would just include it explicitly.

Alright, thanks. So if i take A(t) = (G(t)/a)^b and B(t) = (H(t) / c)^d i get for the original equation k/(1+A(t)+B(t)) which is then rational you mean? Also just to be sure, since i am loosing the two parameters in my new system i get two new initial conditions for the two new equations. Do they have then a one to one correspondance to the two parameters and if so, which initial condition the corressponds to which parameter, is there a general way to find this out?

There is indeed a some sort of correspondence here: for example, a can be found if b and A(0) are known from the formula A(0) = (G(0) / a)^b, so identifiability of b and A would imply identifiability of a.
For the summation, I am not sure this can be incorporated in such generality. You can do computation for some fixed N or, if you can get a closed formula for the sum, use the closed formula.
For known initial conditions, I have an experimental branch in which you can specify some initial conditions to be assumed to be know under the assumption that their values are generic. Here is the relevant function.

Okay, i see. So i need to solve the equations with the initial conditions for the unknown parameters.
Thank you for providing me with the experimental branch for the initial conditions! I would the put just and array like [A, B, C] in the known_ic argument if A, B and C were states?
Also i get from the identifiability the identifiability of the states back, can you maybe tell me how i can interpret this? Does this mean that i will be able to recover the true trajectory given that we don't have any noise in the data? But that would also depend on the number of observations right? Or does this only tell me that the initial conditions are identifiable?

Also i have massive problems to run the identifiability for the following code
using DifferentialEquations
using StructuralIdentifiability
using ModelingToolkit
using Symbolics

@variables t X1(t) X2(t) X3(t) X4(t) X5(t) X6(t) X7(t) X8(t) X9(t) X10(t) X11(t) X12(t) X13(t) X14(t)
@parameters P1 P2 P3 P4 P5 P6 P7 P8 P9 P10 P11 P12 P13 P14 P15 P16 P17 P18 P19 P20
D = Differential(t)

eqs = [D(X1) ~ P1 * X14 - P2 * X1,
       D(X2) ~ P3 + P4 * X3 - P5 * X2,
       D(X4) ~ P6 + P7 * X5 * π *  X10 * X10 - P8 * X4,
       D(X6) ~ P9 * 1/(1+X7 + X8) + P10 * X9 - P11 * X6,
       D(X10) ~ P12 * X11 + P13 * X12 + P14 * X13,
       D(X3) ~ P6 * (P6 + P7 * X5 * π *  X10 * X10 - P8 * X4)/X4 * (1 - X3) * X3,
       D(X5) ~ P16 * (P12 * X11 + P13 * X12 + P14 * X13)/X10 * (1 - X5) * X5,
       D(X7) ~ P17 * X7 * (P1 * X14 - P2 * X1)/X1,
       D(X8) ~ P18 * X8 * (P6 + P7 * X5 * π *  X10 * X10 - P8 * X4)/X4,
       D(X9) ~ P19 * X9 * (1 - X9) * (P6 + P7 * X5 * π *  X10 * X10 - P8 * X4)/X4,
       D(X11) ~ P20 * X11 * (1- X11) * (P9 * 1/(1+X7 + X8) + P10 * X9 - P11 * X6)/X6,
       D(X12) ~ P15 * X12 * (1- X12) * (P3 + P4 * X3 - P5 * X2)/X2,
       D(X13) ~ P16 * X13 * (1- X13) * (P12 * X11 + P13 * X12 + P14 * X13)/X10]

ode = ODESystem(eqs, t, name = :ANONYMOUS)

identifiability_result = assess_identifiability(ode, measured_quantities = [X4, X6, X2, X10, X14], p=0.999)

# Print out the results
println("Identifiability analysis results:")
println(identifiability_result)

The local identifiability works, but the global one seems to blow up like crzy the memory and doesn't produce a result. Is this even possible in this case?


Css

Summary
Implement support for style elements when parsing svg xml content, or fetching from uri.
Test Plan
import React from 'react';
import {TouchableOpacity} from 'react-native';
import {parse} from 'react-native-svg';
import {inlineStyles, SvgCss} from 'react-native-svg/src/css';

const svgWithCssExample = `<svg xmlns="http://www.w3.org/2000/svg"
     width="100%" height="100%" viewBox="0 0 1000 500">
  <defs>
    <style type="text/css"><![CDATA[
      rect {
        fill: green;
        stroke: blue;
        stroke-width: 3
      }
    ]]></style>
  </defs>
  <rect x="200" y="100" width="600" height="300"/>
</svg>
`;

const App = () => {
  return (
    <TouchableOpacity
      style={{flex: 1, backgroundColor: 'blue'}}
      onPress={() => {
        const parsed = parse(svgWithCssExample, x => {
          let styled = inlineStyles(x);
          console.log({...styled});
          return styled;
        });
        console.log(parsed);
      }}>
      <SvgCss xml={svgWithCssExample} />
    </TouchableOpacity>
  );
};

export default App;

Checklist

[x] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

I'm thinking maybe this should be a separate module/package, then again, it might need changes in sync with the rest of the code from here. Wouldn't want to introduce runtime dependencies into this package. But perhaps it's better to have it for now, until tailor made implementations for this specific use-case can be made.

Simpler example:
import React from 'react';
import {SvgCss} from 'react-native-svg/src/css';

const xml = `
<svg
  xmlns="http://www.w3.org/2000/svg"
  width="100%"
  height="100%"
  viewBox="0 0 1000 500"
>
  <defs>
    <style type="text/css">
      rect {
        fill: lightgreen;
        stroke: blue;
        stroke-width: 5;
      }
    </style>
  </defs>
  <rect x="200" y="100" width="600" height="300" />
</svg>
`;

const App = () => <SvgCss xml={xml} />;

export default App;

@iqqmuT I've simplified CSSStyleDeclaration now, can you test it?

Tested ee4b0d5 and CSS support seems to work very well! I tested with different CSS selectors:
const App: () => React$Node = () => {
  const xml = `<?xml version="1.0" standalone="no"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
  "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg xmlns="http://www.w3.org/2000/svg" version="1.1"
     width="10cm" height="5cm" viewBox="0 0 1000 500">
  <defs>
    <style type="text/css">
      rect {
        fill: red;
      }
      g .cl-1, g rect {
	stroke: blue;
        stroke-width: 16
      }
      .cl-2.yellow {
        fill: yellow;
      }
    </style>
  </defs>
  <g>
    <rect class="cl-1" x="100" y="0" width="600" height="200" />
  </g>
  <g>
    <rect class="cl-2 yellow" x="100" y="350" width="600" height="200" />
  </g>
</svg>`;
  return (
    <SvgCss xml={xml} width="200" height="200" />
  );
};

Result:

@msand If you want, I can write a test case with Jest?

Ah, excellent, that sounds great!

:tada: This PR is included in version 9.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@iqqmuT Seems like making css-tree and css-select peerDependencies should keep the module dependency free for the users who do not use the css functionality, and the web bundle seems to have stayed the same<EMAIL_ADDRESS>

Seems my plan to keep the module dependency free failed, metro tries to resolve the module even if the new css components aren't used. Made them proper dependencies instead of peers now.

There you go: #1167
Just tell if you wish it to be more verbose.

This is good, thank you!


missing annotations

quite a large number of annotations are missing from this publication:
http://pombase2.bioinformatics.nz/reference/PMID:10348908
https://curation.pombase.org/pombe/curs/8e27bf8723065210
e.g cellular component: nucleus & a large number of phenotypes
last time it was approved was back in 2015.

(FYI i just added 2 extensions to the nucleus term)

Hi.  I think you were looking at the wrong preview page.  This looks OK:
http://pombase2.bioinformatics.nz/reference/PMID:11129048

ah that looks better but it is stil missing this anntation:
| prr1Δ | FYPO:0000280 | sterile
(that's what promted me to look at this paper...I was going to add that annotation, I thought I had missed it, but then I saw that it was present in the session).

prr1Δ | FYPO:0000280 | sterile

I've look into that.  Could it be that sterile isn't a cell phenotype and isn't a population phenotype so is not shown?

hmm, yeah...ste11 isn't showing sterile either

odd though...old site also sorts population/cell and it is showing there
http://www.pombase.org/spombe/result/SPAC8C9.14#fission_yeast_phenotype-single_allele-cell_phenotype

I checked Chado and the missing annotation is there.  I checked the parents of "sterile" and it isn't a descendant of the "population phenotype" term (FYPO:0000003) and it's not a descendant of the cell phenotype terms (FYPO:0000002 and FYPO:0000652).  So I think that explains it.

odd though...old site also sorts population/cell and it is showing there

I checked the code for the old site.  On the old pages anything the isn't a descendant of the population phenotype term (FYPO:0000003) is put in the "cell phenotype" section of the page.

Kim's right, sterile and other mating phenotypes are neither cell nor population phenotypes in FYPO. I kind of think that's biologically reasonable - it takes two to tango (or mate), so it's not strictly a cell-level process. Technically two can count as a small "population" but I suspect that's not very intuitive; certainly I tend to think of the population phenotypes as the ones you assay by looking at a big population in a culture.
There are other terms that aren't classified as either cell or population - the molecular function phenotypes, developmental process phenotypes (mainly because of the ascus, which isn't a single cell), and a handful of oddballs that defy categorization.
I don't remember explicitly requesting that mating phenotypes go under cell phenotype for the legacy pombase display, but that appears to be what it does.
I wouldn't object to putting anything that's not a population phenotype under cell phenotype for the pombase page displays if it's easy for Kim to do. That would be better than kludging up the ontology itself.

 wrong sodding button

that would work for me..

this rings a bell, I guess we must have had the same discussion eons ago :-)

this rings a bell, I guess we must have had the same discussion eons ago :-)

Yep! #259

I wouldn't object to putting anything that's not a population phenotype under cell phenotype for
the pombase page displays if it's easy for Kim to do.

Currently the code expects to be configured with a list of high level terms for each category.  So the quickest fix for "sterile" is to at another term to the config. like: FYPO:0000301 mating phenotype
If it helps I can do a query to find terms that still wouldn't appear in either category.

I found around sixty or so terms that don't fall under MF, cell or population phenotype, but I didn't check how many of those are under mating or developmental process.

I found around sixty or so terms that don't fall under MF, cell or population phenotype,

I get 62 so that consistent.
Only 29 of those have annotation:
abnormal ascus development
abnormal conjugation
abnormal telomeric repeat sequence
altered cytochrome absorption spectrum
conjugation without glucose starvation
conjugation without nitrogen starvation
decreased concentration of M-factor in growth medium
decreased concentration of P-factor in growth medium
decreased pH of growth medium
decreased queuosine level in tRNA
h- specific sterility
h+ specific sterility
increased Argonaute-associated RNA length
increased concentration of M-factor in growth medium
increased concentration of P-factor in growth medium
increased concentration of polysaccharide in growth medium
increased poly(A) tail length
normal ascus morphology
normal conjugation
normal conjugation frequency
normal frequency of conjugation with h+ cells
normal galactose:mannose ratio in glycoprotein glycan
normal minichromosome loss
normal monoacylglycerol phosphate chain length
normal poly(A) tail length
normal telomeric repeat sequence
normal topoisomerase-DNA adduct level
queuosine absent from tRNA
sterile
If I filter out FYPO:0000301 mating phenotype too there are only 20:
abnormal ascus development
abnormal telomeric repeat sequence
altered cytochrome absorption spectrum
decreased concentration of M-factor in growth medium
decreased concentration of P-factor in growth medium
decreased pH of growth medium
decreased queuosine level in tRNA
increased Argonaute-associated RNA length
increased concentration of M-factor in growth medium
increased concentration of P-factor in growth medium
increased concentration of polysaccharide in growth medium
increased poly(A) tail length
normal ascus morphology
normal galactose:mannose ratio in glycoprotein glycan
normal minichromosome loss
normal monoacylglycerol phosphate chain length
normal poly(A) tail length
normal telomeric repeat sequence
normal topoisomerase-DNA adduct level
queuosine absent from tRNA

I don't think it would be outrageous to lump those in with cell phenotypes for display.

I don't think it would be outrageous to lump those in with cell phenotypes for display.

I'll do that.
I tried looking for a short list of high level IDs I can add to the configuration to cover those.  Unfortunately there aren't many.
There are quite a few direct children of normal phenotype (FYPO:0000257).  Like:
normal galactose:mannose ratio in glycoprotein glycan - FYPO:0004942
normal ascus morphology - FYPO:0005157

I'll add those IDs to the config.
There are a couple of direct children of "normal vegetative phenotype" - FYPO:0001312
Is it OK to put all descendants of FYPO:0001312 in with the cell phenotypes?  There aren't many at the moment.  An example is:
normal monoacylglycerol phosphate chain length - FYPO:0005582

These two have only abnormal phenotype as a direct parent so there isn't a higher level grouping term that covers them:
decreased queuosine level in tRNA - FYPO:0003427
abnormal poly(A) tail length - FYPO:0002929

"abnormal ascus development" is a descendant of "abnormal biological process" - FYPO:0005447 and of "biological process phenotype" - FYPO:0000300.  Is there any problem with including either of those terms in the config for the cell phenotype section?
Apart from "normal vegetative phenotype" the only other high level term we can add is:
altered effect on growth medium - FYPO:0001155

which has a few child terms in the list.

The annotation to sterile is there now, but appears twice :-/
I'll fix that tomorrow or Monday.

erm, on some of the FYPO term pages it looks like everything is duplicated
examples:
population - http://preview.pombase.org/term/FYPO:0002344
cell - http://preview.pombase.org/term/FYPO:0003486

The annotation to sterile is there now, but appears twice :-/

The duplication is fixed now.


How can I access main stream notifications?

How can I get the same output with this library?
curl -v -u IonicaBizau:TOKEN https://github.com/IonicaBizau.private.json

See https://mikedeboer.github.io/node-github/#api-activity-getNotifications

@kaizensoze Is that the same with the private stream (/<username>.private.json)?

Actually it looks like the equivalent is the events stuff. If you hit https://github.com/kaizensoze.private.json in a browser you'll get:

{
"message": "Hello there, wayfaring stranger. If you’re reading this then you probably didn’t see our blog post a couple of years back announcing that this API would go away: http://git.io/17AROg Fear not, you should be able to get what you need from the shiny new Events API instead.",
"documentation_url": "https://developer.github.com/v3/activity/events/#list-events-that-a-user-has-received"
}

https://developer.github.com/v3/activity/events/#list-events-that-a-user-has-received then shows

List events that a user has received
These are events that you've received by watching repos and following users. If you are authenticated as the given user, you will see private events. Otherwise, you'll only see public events.
GET /users/:username/received_events

The library equivalent is https://mikedeboer.github.io/node-github/#api-activity-getEventsReceived

@kaizensoze Ah, that's really interesting. I guess this happened quite recently. Thanks for the info. ✨


Timelock/Expiration validation with a CommitmentInput

Closes https://github.com/iotaledger/iota-sdk/issues/1127

[ ] Need to reenable https://github.com/iotaledger/iota-sdk/pull/1421/files#diff-4837978b4d3d1c2f1b96b18e96e29ec5a50a32867735eb9bee9981528b888d5fR590

Replaced by https://github.com/iotaledger/iota-sdk/pull/1661


JAX Penalty Errors

I've found an issue in which 2011-2015 data (from what I can tell based on penalty counts) miscredits some plays away from JAX, when JAX plays at home.
EX: game_id 2013_01_KC_JAX, play_id 1053
desc:
(:52) (Punt formation) PENALTY on JAX-90-A.Branch, False Start, 5 yards, enforced at JAX 23 - No Play.
however the penalty_team == KC, not JAX

This is now monitored in nflfastR and will be fixed soon.
Thanks @williambjames


bump to v0.3.0

Signed-off-by: Peter Hunt~<EMAIL_ADDRESS>
What type of PR is this?

/kind other
What this PR does / why we need it:
Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?

none

@rphillips PTAL

flake?
/retest-required
/lgtm


Add Nick and Jared to CODEOWNERS

I'm now doing a fair amount of work in node, and we should have an approver in the US timezone(s).

bors merge


Merge hotfixes

Merges in changes from recent hotfixes #435, #421, and #384 to master branch so changes from production are up to date with development work of Journey + LC.
Additions

New links & corresponding browser tests for Explore interest rates page intro paragraph
Found a missed 'check interest rates' in the subject line of feedback email link and updated it to say Explore
Updated Journey links from "Check interest rates" to "Explore interest rates"

Changes

Updated Closing Form Explainer PDF from #435
Tell your Story links to new URL from #384
Check Rates is now Explore interest rates from #421

Testing

run updated browser tests:

behave -k  features/rate_checker_links.feature
behave -k  features/loan_special.feature
behave -k  features/navigation.feature

Review

@amymok for closing form + browser tests
@stephanieosan for interest rate content updates

Preview
Explore interest rates on new landing page

New sidebar link on landing page

Intro paragraph and headings on Explore interest rates page

The Explore rates copy in your screenshot matches what's on production :+1:

Looks good to me


Breaking backwards compatibility

There are many features in the gem that are no longer "desirable" and could be removed, to reduce complexity and make the project more maintainable. However they might break backwards compatibility.
For example:

Stringifying input (vs expecting the user to provide a stringified hash)
Auto-detecting whether an input string is a url (before downloading and parsing) or a JSON text (vs expecting the user to download and parse, and only accepting a valid JSON hash)
Setting global options on the JSON::Schema class itself (vs. passing parameters in as options to validate, at runtime)
Generating our own UUIDs (vs using SecureRandom)

I'm sure there are many others.
Lately I've been wondering whether supporting optional or infrequently used features (and functionality that can be done for us by the Ruby core lib or another gem) is a good thing, and whether the library would be easier to maintain without them. And if that is the case, should version 3 aim to strip out things we know are "legacy"? Another option might be for JSON schema to continue backwards compatibility, but be forked to produce a new gem which would have no need for backwards compatibility, and could have large parts of the code stripped out and be a more versatile base for the future. Or is the aim of the gem to preserve backwards compatibility for the sake of existing users?
Ideally I would like to see the gem doing as little as possible, sticking to the core requirement of validating JSON, and expecting the caller to write code for anything else that they might need, on a case-by-case basis (or by writing a separate gem for that).
I'd love to hear opinions on how we should handle optional or legacy features, especially from the core team.

Honestly, I agree and would love to see the move towards trying to be "just" validation moving forward. About the time I started losing the ability to spend a lot of time on this project was when I started just accepting all manner of feature requests, and the project became fairly bloated as a result. I'd prefer to keep this library be mostly just a validator that follow the spec as closely as possible with the added benefit of being able to define custom extensions.
Everything else is cruft.

Ah yes, being extendible would be a good idea. Maybe we could even refactor
some of the existing non-core features (inserting defaults?) out to
extension gems
On Sat, 14 Mar 2015 at 4:36 am, Kenny Hoxworth<EMAIL_ADDRESS>wrote:

Honestly, I agree and would love to see the move towards trying to be
"just" validation moving forward. About the time I started losing the
ability to spend a lot of time on this project was when I started just
accepting all manner of feature requests, and the project became fairly
bloated as a result. I'd prefer to keep this library be mostly just a
validator that follow the spec as closely as possible with the added
benefit of being able to define custom extensions.
Everything else is cruft.
—
Reply to this email directly or view it on GitHub
https://github.com/ruby-json-schema/json-schema/issues/246#issuecomment-79857424
.

I've added a wish list of things that would be good to have for the 3.0 release in #247. It'd be great to have some editing/feedback from other maintainers on that.

What is about the :list option? I think, this can also be easily done by the user and would simplify the code again.

Yes, I think that would also be good to remove (can you add it to #247? So
that we don't forget)
On Sun, 15 Mar 2015 at 9:19 pm, Jonas Peschla<EMAIL_ADDRESS>wrote:

What is about the :list option? I think, this can also be easily done by
the user and would simplify the code again.
—
Reply to this email directly or view it on GitHub
https://github.com/ruby-json-schema/json-schema/issues/246#issuecomment-81244847
.


Halo Combat Evolved Access Error

When packaging wine and halo combat evolved in gameimage the resulting gameimage produces an error that it cant write / read from my documents. After installing msxml4 during setup this works fine during the preview in gameimage but the resulting flatimage errors out
Just an update. Another game suffers from this.
Godfather II errors during the preview just after the titles complaining it cant find the profiles that are stored in the my documents folder.
If i run it bypassing gameimage it runs fine.
Could be an access problem when using my documents?

Thanks for reporting this issue @Blad3forc3 , currently I do not know why this would happen. Will investigate.

Thanks Ruan. Seems to be some kind of access error when my documents is involved. For the record the appimage works fine

Another game Messiah complains it cant read a file from the games install directory but runs fine from an old appimage. The Game is available on GoG

I am getting a few games that run when previewed or run from their own prefix but when packed into a flatimage error out.
Beyond Divinity is one that complains of accessing map 0 when run from a flatimage but this error doesnt exist during preview

Divine Divinity has the same problem. Works fine in preview, doesnt run in the built flatimage

Batman Arkham Knight works fine in a preview but the gameimage doesnt run complaining of an I/O error on files to run.
I've tried creating the flatimage three times and each time the game runs when previewed in gameimage but the resulting flatimage fails

Wing Commander III when running through dosbox using wine complains of an error creating the swapfile and not running in a flatimage. When creating the flatimage and running the preview it runs fine.
I think there must be write issues around the c drive with certain games after the flatimage is created with wine

Hi @Blad3forc3 , thanks a lot for the analysis! I'll try to replicate from my side :smile:

No problem Ruan.
I have investigated another game with this problem.
A game called Codename Eagle complains that it cant access certain files when made into a flatimage (even though the preview worked fine during creation)
What i have found is if i put all the game files in to location .Codename-Eagle/upperdir/wine/drive_c/wherever the game is installed dir then the game will run from the flatimage, so there is definitely a read/write issue going on

Just an update on this. I am getting a lot of  games that error out in a flatimage after running ok in the preview. They seem to point to a read/write issue in the my documents folder / c drive in general. A tough one to pinpoint but some of them correspond to making an old appimage when the actual games files were stored in the hidden folder and not in the appimage itself

Hi @Blad3forc3,  Let me know if this is still an issue with the current version of gameimage

Hi @Blad3forc3 , I'm going to assume this is fixed. If it is not, please re-open this issue, thanks!


Initial work

This creates the initial groundwork for MegaMock. The initial featureset is to be able to pass in objects, functions, methods, and even attributes to the MegaPatch.it(...) static method and return a MegaMock object.
TODO

[x] Additional test cases, such as nested classes
[ ] Improve documentation

I'm going to acknowledge the testing is a little light but things can get fixed as they come up


Expose parse command with a way to extract LABEL, ARG, ENV before the build

We have a Makefile based builder we use to build all our images. At a minimum, we have to specify the IMAGE_NAME and the IMAGE_VERSION and then include a base Makefile.mk where all rules are located. For more complex images with all kinds of dependencies, we end up having to add more metadata to our Makefiles.
Why not embed this metadata directly in the Dockerfile and provide a simple way for any build infrastructure to extract that information from it?
As far as I can see, all (most?) the relevant mechanisms already exist in a Dockerfile: namely ARG, ENV, LABEL, FROM, EXPOSE, etc. If there was an easy way to extract that information from a Dockerfile before the actual ```docker build````, we could have a generic builder without spreading metadata across two or more files.
For example, consider the following Dockerfile:
FROM java:8u92-jre-alpine

MAINTAINER frevvo Inc<EMAIL_ADDRESS>
ARG GIT_COMMIT

LABEL image.name docker-sample
LABEL image.version 2.1.0
LABEL git.commit=${GIT_COMMIT}

LABEL maven.dependencies=["org.apache.tomcat:tomcat-catalina-jmx-remote:7.0.65:jar"]

RUN ...
RUN ...

VOLUME /root/config
VOLUME /root/logs

ENTRYPOINT java -jar sample-exec.war

The builder could parse the Dockerfile and look for known (possibly required) labels, such as image.name and image.version that can be used to tag the image when building.
Or a Jenkins plugin could parse the FROM directive to automatically derive build dependencies: i.e. build this when that one builds/changes.
Or based on the Dockerfile args, automatically build a --build-arg list based on known arguments (GIT_COMMIT, SVN_COMMIT, etc) for inputs coming from the environment/context.
Warn or error when key required labels are not defined in the Dockerfile (granted this could be done after the build is done by inspecting the image.
This definitely could be provided as an external Dockerfile parser (the path we are taking now), but it is error prone, limited as it may not easily account for ARGS/ENVs interpolations, for instance, unless we start heading to a serious parser, which seems like a waste of time since Docker already has one. The only thing missing is a way to query (--filter) and export (--format) information out of it.

@ydewit the parser is in an importable package.
I'm not sure why this would be error prone.

I meant error prone in terms of rewriting the parser in your language of choice. But sure, if I were to create a parser in Go that imports the Docker parser, that is a different story.
I guess the question is mainly whether does it make sense to support such functionality in the Docker engine.

The definition of the Dockerfile syntax is now defined in the BuildKit repo: https://github.com/moby/buildkit.


README is out of date at Shared/HoloLensForCV?

The README at this location says:

Note that support for additional HoloLens sensors (ToF Depth, Visible Light, ...) is not currently available publicly. Stay tuned for updates!

I'm assuming these sensors are now exposed, and the README needs an update?

Right, thanks. This is fixed now.


Update Procedure.cs

Arity of the NativeProcedure Create had extended to 10 in whole range (6-th, 7-th, 9-th and 10-th numbers of params added)
I've just copied and pasted ))

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dotme sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Return application/problem+json

Hi:
How I return a application/problem+json format when the validation failed?
https://tools.ietf.org/html/rfc7807
Thanks

Hi lvillarino,
That is a good question! I suppose at the moment there isn't an easy or clean way of doing so as the ValidateJsonListener throws a BadRequestHttpException rather than a bundle specific exception. If the bundle threw an InvalidJsonException (for example) that extended BadRequestHttpException then in theory you could set up a Symfony exception handler that listened for that exception and then produced the problem+json format you mention.
The handling of that exception would be application specific rather than included in a bundle as introducing more exception handlers would likely cause more work for developers down the line; either that or controlled through a configuration parameter. As for the unique exception, that's a fairly quick fix however I probably won't be able to look at this until sometime next week due to other commitments I'm afraid. If you want to submit a pull request though that would be great!

Hi lvillarino,
This should be easy to implement in your Symfony application now. I've made the listener throw a JsonValidationException when there is a problem with the JSON or the schema. So to solve your problem you'd set up a new exception listener (Symfony docs) that specifically catches the JsonValidationException and would then output your application/problem+json.
Hope that makes sense!

Hi @lvillarino,
Just a quick update to let you know that I've implemented an exception listener that can return application/problem+json responses and this should be available in version 1.0.3. The README has been updated with details but hopefully this should answer your query.
Many thanks for raising an issue about this, I had no idea about the content type so it was great to learning about it.

Thanks


Not compatible with Wave 2nd Gen [Data structure have changed]

I have two Airthings wave, one is 1st Gen and newer one is 2nd Gen (it does display battery status in Airthings app).
The reason seems to be that data structure is not compatible between both versions. There is even two versions of read_wave.py in official Airthings github https://github.com/Airthings/wave-reader
It would be great if you consider to make a compatible version of your mqtt tool. It works great with my 1st gen wave

If someone sends me a 2nd Gen unit, I'd be happy to update the code.


Release 7.18.0

Hey there,
I'm just wondering if there will be a new release 7.18.0 of this extension?

Hi @strangelookingnerd,
yes there will be a new release 7.18.0 of this extension. Till the end of the year. I just had way too much to do in the last weeks and so didn't get around to doing any further updates.
However, there is no serious reason to wait for the update or to start your project without it: the extension itself is running on 7.18.x as well.

@VonDerBeck
That's great to hear, thanks for the quick response!


Rename admin to metrics in the config model

In the configuration we currently have:
adminHttp:
  endpoints:
    prometheus: {}

in reality it is not an admin interface at all.  It is just a just a interface for metrics.
I don't think we have any intent to introduce an Admin API any time soon (indeed, that would run contrary to the declarative direction we are going with the Operator).
I am suggesting we rework the configuration model so that it is in terms of metrics alone.

Closing this. We can always reopen if we decide to implement reloading in a different way.


Add list of extensions and packages for code editors

Make a list of helpful add-ons to the code editors listed, for better productivity

Closed with commit bce4238


Use sudo-prompt?

Tried implementing sudo-prompt (sudo-prompt) in order to get native dialog for password prompting but this does not seems to work on Ubuntu 18.04
Got error User did not grant permission which turned to be pkexec must be setuid root when trying to run the example code but pkexec has for setuid root already...
For the regular prompting, went for promptly (promptly) as it was the only one giving solid promise-based implementation

Not needed anymore, not working with portion of the file system which would require privileged access.


fix: vector constructor should not require DefaultInsertable value_type

small::vector's default constructor and allocator constructor should not require value_type to be DefaultInsertable.

Oh... vector(0, alloc) as an expression ends up requiring that, right?
Is this PR good to go?

Yes, good to go.

@alandefreitas can we get a 0.2.2 tag for this fix? Thank you.

Sure :)
https://github.com/alandefreitas/small/releases/tag/v0.2.2


swag init doesn't parse 'module' dependencies for types, they must be vendored

When a type is declared in a dependency, swag init fails with "cannot find type definition:  ..."
To successfully generate docs, dependencies must be vendored with go mod vendor and then use swag init -parseVendor
Is this intended/an unmentioned limitation?
Thanks!!
To Reproduce

Setup project: example.com/swagmodtest (within or outside of GOPATH):
~/swagmodtest/main.go or $GOPATH/example.com/swagmodtest/main.go

package main

import (
	"fmt"

	"go.mongodb.org/mongo-driver/bson/primitive"
)

// @id test
// @Router /test [get]
// @Success 200 {array} primitive.Binary
func main() {
	var t primitive.Binary
	fmt.Println(t)
}

go mod init example.com/swagmodtest
go mod tidy
swag init
[...]/main.go :cannot find type definition: primitive.Binary

Fix with vendoring

go mod vendor
swag init -parseVendor
swagger.yaml:

definitions:
  primitive.Binary:
    properties:
      data:
        items:
          type: integer
        type: array
      subtype:
        type: integer
    type: object
info:
  contact: {}
paths:
  /test:
    get:
      operationId: test
      responses:
        "200":
          description: OK
          schema:
            items:
              $ref: '#/definitions/primitive.Binary'
            type: array
swagger: "2.0"

Your swag version

swag version v1.16.2

Your go version

go version go1.18.3 linux/amd64

Desktop:

OS: debian bullseye

Additional context
The code builds/runs fine with go modules and no vendoring
$ rm vendor/ -rf
$ go run main.go
{0 []}

swag init --parseDependency

Well, doh!
That works
Maybe the documentation needs to be updated:
README.md indicates:
--parseDependency                   Parse go files in outside dependency folder, disabled by default
swag init --help indicates:
--parseDependency, --pd                    Parse go files inside dependency folder, disabled by default (default: false)
Go modules are not a single "dependency folder" AFAIK.
Is there any source other than go.mod that --parseDependency enables?
Maybe a better explanation would be:
--parseDependency, --pd                    Parse dependencies from go modules (go.mod); disabled by default (default: false)

I've found that --parseGoList does the job better, it allows you to reference any type without needing to do awkward "underscore" imports.


devmapper: udev sync is a requirement

Rather than disabling devmapper for static builds, this will get more at the root. Udev sync is a prerequisite for devicemapper. That sync is false on static builds as well.
See also https://github.com/docker/docker/issues/4036
closes #10664

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "vbatts-dm_sync_is_required" git@github.com:vbatts/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

perhaps this also needs a storage option parameter like dm.use_regardless_of_udev_sync_i_know_what_i_am_asking_for=true
for the folks that are using this on ubuntu and being affected, but we can't help due the version of their udev and libdevmapper...

we run tests on a fedora machine on every push to master we could make sure its tested there

@vbatts I think we need a special flag to allow this to be bypassed so that it can be tested.

Will do
On Mar 16, 2015 5:15 PM, "unclejack"<EMAIL_ADDRESS>wrote:

@vbatts https://github.com/vbatts I think we need a special flag to
allow this to be bypassed so that it can be tested.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11412#issuecomment-81945050.

@jfrazelle @unclejack @rhvgoyal added a flag

@vbatts
Few more suggestions for flag name.
"dm.ignore_udev_sync_check"
"dm.override_udev_sync_check"

@vbatts
Can we also modify tests to use above flag by default?

perhaps 'override...', because we are still checking it, so we can log in the daemon that it's an issue.

@vbatts
"dm.override_udev_sync_check" sounds good.

@rhvgoyal updated PTAL

and added a default for the tests to override the sync requirement

@vbatts
This patch looks good to me. I have a general question though about tests. Generic tests in docker are run with what graphdriver?
For example, say, I want to run integration tests and one of the test is whether container creation is successful or not. Will I run same test against all graph driver or there is a default graph driver which will always be used or something else?

vfs is the driver the Docker-in-docker daemon is running for tests.
On Tue, Mar 17, 2015 at 1:35 PM, Vivek Goyal<EMAIL_ADDRESS>wrote:

@vbatts https://github.com/vbatts
This patch looks good to me. I have a general question though about tests.
Generic tests in docker are run with what graphdriver?
For example, say, I want to run integration tests and one of the test is
whether container creation is successful or not. Will I run same test
against all graph driver or there is a default graph driver which will
always be used or something else?
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11412#issuecomment-82491526.

Ok, thanks.
LGTM.

@vbatts
Thinking more about it. Actually this change is not upgrade proof. Those who are using device mapper and when they upgrade docker, suddenly docker daemon will stop running and that's not good.

that's why the storage-opt flag is there. It's not supported in the way
they're running it presently.
if with the upgrade, they are then required to add the flag, it will be an
explicit indication that they're running it in an unsupported way, but
still have the ability to do so. Even if for migrating to a supported
setup, or switching to a docker binary that supports udev sync.
On Tue, Mar 17, 2015 at 1:41 PM, Vivek Goyal<EMAIL_ADDRESS>wrote:

@vbatts https://github.com/vbatts
Thinking more about it. Actually this change is not upgrade proof. Those
who are using device mapper and when they upgrade docker, suddenly docker
daemon will stop running and that's not good.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11412#issuecomment-82493921.

Generally I am not a big fan of such approach. Typically first we move users to a different storage driver slowly before switch is made.
Given that so many people are complaining, clearly lot of people are using it. They will be upset when upgraded docker suddenly does not start.
In kernel, we have a deprecated file where we put a feature which we want to deprecate. Send loud warnings if user is using those features in an effort to migrate them to alternate means. And once we are reasonably sure that most of the user's have migrated, we make the switch.
Personally, I would rather continue to give loud warnings and tell users to move to aufs or overlayfs or move to dynamic binary when they complain, instead of breaking working setup.  Yes, flag is there, but it is very annoying to figure out that one needs to pass a new flag before one can proceed.
All I am saying that existing users might not like this change.

Perhaps calling it something like unsafe_override_udev_sync_check would send a very clear message that this isn't safe, nor supported. Whatever it's called, we probably want to have something like unsafe or unsupported in the flag itself to make it clear this voids the warranty.

@unclejack
I don't think that naming of flag is an issue here. Problem is that docker 1.5 was working in a setup and same setup will suddenly stop working on 1.6. And that's a problem.
We agree that whatever was working in 1.5 is not supportable, but that ship has sailed and people are already using it. I think instead of failing it completely, a better approach is to just give loud warnings that is is not supported and will go away in future, write documentation and point people to documentation.
And once we are reasonably sure that people have migrated to different solutions, then make this switch, IMHO.

@rhvgoyal You're right, but those users also need to know as soon as possible that they're exposing themselves and any potential clients they may have to data corruption/loss on the Docker daemons where they're running such a setup.
We need to provide apt and yum repositories which are distro specific in order to be able to provide dynamically linked binaires. That's a requirement for getting this merged, IMO.

should we inverse this flag for now, so that we can make it available to
the pedantic. and once the requirements are met, we can switch this default
to fail support when udev sync is not supported?
On Wed, Mar 18, 2015 at 12:11 PM, unclejack<EMAIL_ADDRESS>wrote:

@rhvgoyal https://github.com/rhvgoyal You're right, but those users
also need to know as soon as possible that they're exposing themselves and
any potential clients they may have to data corruption/loss on the Docker
daemons where they're running such a setup.
We need to provide apt and yum repositories which are distro specific in
order to be able to provide dynamically linked binaires. That's a
requirement for getting this merged, IMO.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11412#issuecomment-83038585.

@vbatts
By inversing the flag you mean provide a flag to fail initialization of devicemapper if udev sync is not supported. And without presence of flag, you will allow devicemapper to initialize?
If yes, I am not sure how useful it is. If somebody knows this issue then flag does not help him. And if somebody does not know the issue, then he does not know the flag either and then its of no use to him.
I think right now we seem to have two choices only and we need to pick our poison.

Just continue to give loud warnings and write documentation to point to users in right direction.

Implement this flag and in error message tell user why daemon has failed and if they want to
override this behavior how to do it. That way, it will atleast make it easy for users to find this new
flag. So this will still be annoying but I guess less painful. One will have to still write documentation
to explain what are the alternatives.

@rhvgoyal will do

rebased and updated.
PTAL

LGTM

fixed

LGTM
Ping @unclejack

@unclejack once you're good, please move to docs-review, thanks!

LGTM

Ping @fredlf @moxiegirl @SvenDowideit

@moxiegirl I will update the wording. I see that it is not clear enough. :-)

docs updated PTAL

@vbatts Thanks for the update. You missed a few ticks around udev and devicemapper line 381 --- but I can clean those up later.  LGTM

ping @fredlf @SvenDowideit @jamtur01

@vbatts Did you push an update? Perhaps wait until I get a chance to finish the review? :) Makes it hard to go back and see what's changed.

@jamtur01 sorry! i thought i saw them slow down, so i pushed :-\

No worries - love the lightning fast fixes! :)

Notes formatting updated. PTAL

@jamtur01 ping back...let us know if you are satisfied. :D

Docs LGTM


Investigate removing inner sub_plans

On grids and rotations we have inner sub_plans of DO_FGS and GRIDSCAN_MAIN_PLAN. I believe that these are only needed so that we have a second thing to trigger zocalo on after the ispyb depositions have been made. Following https://github.com/DiamondLightSource/hyperion/pull/1198 the Zocalo plan can be sure that the depositions are made when it gets it's first start document as it has the ids in the metadata. This may mean we can remove the inner sub_plans and make the plans a lot tidier.
Notes

We would still need something to trigger the end off, this could be an event like the detector disarming (though does this work for multiple rotations in one arm)?
We would need to think about how we calculate processing time, this could be based on events from ZocaloResults?

Acceptance Criteria

We investigate why we still need inner sub-plans
If they are necessary we document them better
If not, we remove them

It probably still makes sense to have the plans split up as they are but they just don't need run_start/stop


Non-resumable subscriptions aren’t as polished as resumable

What?
Non-resumable subscriptions don’t reconnect, and they still fire this “state change error” on page refresh. If they behaved the same as resumable subscriptions that would be great!
Why?
Consistency.
How?
Similar reconnection strategy? And whatever you did to resumable subscriptions to suppress that page refresh error 🙂

CC @pusher/sigsdk

AFAIK this is fixed.


Confusing configuration for managing expand/collapse behaviour of nav ba

First, thanks a lot for starting this library. There are very few css libraries available right now that is built on lit-element. On top of that you've got a nice doc site available already.
I'm trying out the the responsive navigation bar following the guide here:
https://lit-element-bootstrap.dev/component/navbar
I noticed that the navigation menu is set to be expanded by default when the screen size changes. Users would have to click on the toggler icon to collapse the navigation menu. Couldn't find info in the docs on how to configure it. So, I looked at the source code here:
https://github.com/nik-christou/lit-element-bootstrap/blob/f98681f635efcd5954fd33671eaab76fdeb4d391/components/navbar/bs-navbar-collapse.js#L10-L11
I find the two properties on those lines confusing. We shouldn't need two booleans to dictate the state of expand/collapse. One variable should suffice. Either it's expanded or it's not. Furthermore, I tried to set the navigation bar to be collapsed by default as shown below, but that didn't work.
            <bs-navbar navbar-light expand-lg class="bg-light">
              <bs-navbar-brand-link>My Site</bs-navbar-brand-link>
              <bs-navbar-toggler>
                <bs-navbar-toggler-icon></bs-navbar-toggler-icon>
              </bs-navbar-toggler>

              <bs-navbar-collapse collapsed>
                <bs-navbar-nav class="mr-auto">
                  <bs-nav-item><bs-nav-link href="https://example.com">Link 1</bs-nav-link></bs-nav-item>
                  <bs-nav-item><bs-nav-link href="http://example.com/">Link 2</bs-nav-link></bs-nav-item>
                </bs-navbar-nav>
              </bs-navbar-collapse>
            </bs-navbar>
          </bs-container>

Hi amimas,
You are right the navbar collapse logic was not set correctly. I refactored bs-navbar-collapse to be in collapsed mode by default. I also removed the collapsed boolean attribute.


Ruby/OCR: add hints file with hint on trailing whitespace

See this discussion on Slack.

Do you also need to regenerate the readme to include the hints? Or is that done automatically again?

Aha, I never thought about that. According to this https://github.com/exercism/docs/blob/master/language-tracks/exercises/anatomy/readmes.md, yes, we need to regenerate. I'm trying to stay away from the configlet, for the time being.
What would you recommend: closing this PR and open an issue for the whole change? Or merging this PR and open an issue to regenerate the Readme?

Merge this one and then regenerate the readme.
(or add the regenerated readme commit to this PR and then merge.)


Game Test API

One of the most important addition for stronger testing!
This API is, well, the game test API, which allows mods to use the Minecraft test automation framework (keynote about it by Henrik Kniberg).
This API introduces a new entrypoint quilt:game_test of classes implementing QuiltGameTest. Any method annotated with GameTest in that class will be registered as a test, and you can implement a method from QuiltGameTest to programmatically register more test classes.
The API is partially a port from Fabric API's game test API, but extended to be more comfortable to use, and more powerful!
As you can see there's also some game tests implemented for Block Content Registries to show how it can be used (and its benefits).

Hm, as a precaution, we should probably consider merging this GameTest mappings PR before doing any further push for release

Hm, as a precaution, we should probably consider merging this GameTest mappings PR before doing any further push for release

that mappings PR doesn't target the version this PR targets anymore :)

Hm, as a precaution, we should probably consider merging this GameTest mappings PR before doing any further push for release

that mappings PR doesn't target the version this PR targets anymore :)

Not if we downgrade it back!

Hm, as a precaution, we should probably consider merging this GameTest mappings PR before doing any further push for release

that mappings PR doesn't target the version this PR targets anymore :)

Not if we downgrade it back!

And with some poking? My dreams became true! :P
But yeah, the PR has been merged on the 22w03a branch and backported to the 1.19.3 one on QM 1.19.3-build.18


samples: create an OLED example

Is your enhancement proposal related to a problem? Please describe.
There is no existing example to help get started with OLED modules like SSD1306. An example that demonstrates the use of lvgl would also be really useful.
Describe the solution you'd like
Write an example that will display "Hello World" on any display module connected via IIC to any board, since ```LVGL`` is a generic library/ module.
Describe alternatives you've considered
Something similar to u8g2 example can be provided within samples/drivers/.
Additional context
N/A.

We do not need samples for this specific display technology.
We have generic samples for cfb, lvgl: samples/subsys/display and display controller driver API: samples/drivers/display.
https://docs.zephyrproject.org/latest/samples/subsys/display/lvgl/README.html

I agree that display samples don't need to be dependent on a particular technology, but rather on API/libraries. One could use the same to display content on devices made using LCD or OLED technologies.
Closing this issue, as there are existing samples that can be used (samples/subsys/display/*).


Skinny Null Terminated String Functions Don't Allow Partial Reads

The wide string functions work how I would expect, however the ascii/UTF8 string read functions simply throw exceptions with no partial results if the string is longer than the requested bytes.

Thank you for reporting the problem!
Can you clarify the exact names of the functions you are calling? And perhaps more info about the exception? Just to make sure the problem is what I think it is.
At first I thought that I would not expect there to be any difference between the skinny and wide string reading at the dbgeng/mem-reading level, because they both funnel through ReadMemAs_String. But perhaps if you were reading a UTF8 string, and it got chopped at an inopportune point, the Encoding object might be throwing. In that case, you could try calling the overload that allows you to pass the Encoding object, and construct one that has throwOnInvalidBytes as false.
But then I realized that there is another set of functions:

One that funnels through ReadMemAs_szString, and those all call through dbgeng's IDebugDataSpaces.ReadMultiByteStringVirtualWide interface.
Another that funnels through ReadMemAs_wszString, which used to call through IDebugDataSpaces.ReadUnicodeStringVirtualWide, but the comments indicate that I ran into problems with it, and reimplemented the logic myself in terms of reading raw memory directly.

I'm guessing you ran into the difference between those two code paths (in which case the fix is probably to switch the first one to also be implemented in terms of reading memory directly (IDebugDataSpaces.ReadVirtualDirect).

The one I remember encountering it with most recently was ReadMemAs_putf8szString, so yeah, the ones that funnel through ReadMemAs_szString. When DbgEng read maxCch bytes without encountering a null terminator, it returned a buffer of maxCch length (which I presume contained the bytes of the string though I did not verify) and HR E_NOINTERFACE, which then becomes a DbgMemoryAccessException.

Okay, I tried an experiment, and the results from dbgeng are just wacky.
I dynamically allocated an ASCII string of length 1024 and filled it with stuff (with a null terminator at the end).
When calling $debugger.ReadMemAs_szString( $addr, 768 ), the dbgeng API returned E_INVALIDARG. But when I asked for one more byte, $debugger.ReadMemAs_szString( $addr, 769 ), it succeeded. (Those lengths in hex are 0x300 and 0x301.) I'm guessing that dbgeng internally reads a larger chunk than is asked for, and if it finds the null terminator anywhere in what it read, it considers things "fine", even if that null terminator is not going to be part of the [truncated] string that is returned to the caller.
I could file a bug on the dbgeng team... but even if they care, I don't know when they'll fix it; I think DbgShell will just need to implement its own string reading if it wants consistent, sensical behavior.


Add 2 YouTube Channels

I added 2 youtube channels, -

Edureka | Link : https://www.youtube.com/@edurekaIN
Apna College | Link : https://www.youtube.com/@ApnaCollegeOfficial

For anything, mail -<EMAIL_ADDRESS>

@arnabxbiswas We already have a ton of YT channels already. Please consider in some other category. Thanks!


Update to Rust 1.83

☝🏻

For now, we don't have an explicit MSRV policy. The toolchain file specifies a version which we definitely support. It will likely work with a range of other versions. When there's a problem we'll work out a policy (and corresponding CI).


Support for TensorRT as a first class framework

/kind feature
Describe the solution you'd like
What is TensorRT?
TensorRT is a ML Serving framework for DL supporting multiple frontends (TF, ONNX, etc), multi-model serving, GCS/NFS integration (needs S3, etc), Metrics.
They also have a protocol: https://github.com/NVIDIA/tensorrt-inference-server/blob/master/src/core/api.proto
How does it relate to KFServing?
It might make sense to support TensorRT as a top level framework. We may eventually wish to support multiple frontends (i.e., user submits a saved model.pb, we transform it to a tensorrt model in an init container, and then serve).
We may also want to consider adopting/modifying the TensorRT protocol.
Thoughts?

/assign rakelkar

I wanted to clarify some of the terminology in this issue.
TensorRT Inference Server  is an inference solution that allows you to deploy deep learning models while maximizing the utilization of your underlying hardware. It has features such as concurrent model executiono n a single GPU, dynamic batching, custom backend, HTTP or gRPC endpoints to interface with the client, etc.

@ellis-bigelow  Can you show me an example, how to modify the /etc/hosts, because i have
tried several methods, but the predict still do not work......