Allow passing existing subnet-group

Is it possible to allow existing subnet-group to be passed? I think its not much of  change just some more check.
change in resource "aws_docdb_cluster" "default" {:
db_subnet_group_name            = join("", aws_docdb_subnet_group.default.*.name)
to
db_subnet_group_name            = var.db_subnet_group ? va.db_subnet_group: join("", aws_docdb_subnet_group.default.*.name)
and
change in resource "aws_docdb_subnet_group" "default" {
count       = var.enabled ? 1 : 0
to
count       = var.enabled && !var.db_subnet_group? 1 : 0
I would make a pull request but I still have no idea how. So just suggestions.

@iaacautomation,
this feature is already available in the module. So, we should be able to pass our existing subnet group.
currently, the value of join("", aws_docdb_subnet_group.default.*.name)
https://github.com/cloudposse/terraform-aws-documentdb-cluster/blob/e498148e546652bd47521abf3b64c3c565f3dfa0/main.tf#L76
can be retrieved from the module resource aws_docdb_subnet_group.default..
https://github.com/cloudposse/terraform-aws-documentdb-cluster/blob/e498148e546652bd47521abf3b64c3c565f3dfa0/main.tf#L102
you can define your own subnet group through the variable subnet_ids, kindly check the example of the module 👍🏻
https://github.com/cloudposse/terraform-aws-documentdb-cluster/blob/e498148e546652bd47521abf3b64c3c565f3dfa0/examples/complete/main.tf#L48
in this context, the example of the module uses another cloudposse subnet module to generate the subnet resources. You can use that or define your own string value for the existing subnet resource in your AWS.
https://github.com/cloudposse/terraform-aws-documentdb-cluster/blob/e498148e546652bd47521abf3b64c3c565f3dfa0/examples/complete/main.tf#L26

subnet_ids  = ["YourSubnetID"]

So I tried this without making any changes to the module or in the module call file by just providing the subnet_ids and it is still trying to create the subnet. Here is the tfvars
subnet_ids                = ["subnet-00672e1368d52c275"]
Below is the full tfvars
clusters = [
  {
    id                        = "cluster1"
    vpc_id                    = "vpc-0123456789abcdef0"
    availability_zones        = ["us-east-1a", "us-east-1b"]
    db_port                   = 27017
    master_username           = "admin"
    master_password           = "secret"
    retention_period          = 7
    preferred_backup_window   = "07:00-09:00"
    preferred_maintenance_window = "Mon:09:00-Mon:09:30"
    final_snapshot_identifier = "final-snapshot-cluster1"
    skip_final_snapshot       = false
    deletion_protection       = true
    apply_immediately         = true
    storage_encrypted         = true
    storage_type              = "standard"
    kms_key_id                = "arn:aws:kms:us-east-1:123456789012:key/abcd1234-a123-456a-a12b-a123b4cd56ef"
    snapshot_identifier       = ""
    external_security_group_id_list = []
    subnet_ids                = ["subnet-0123456789abcdef0", "subnet-abcdef01234567890"]
    cluster_parameters        = [
      {
        name         = "parameter1"
        value        = "value1"
        apply_method = "immediate"
      }
    ]
    cluster_family            = "documentdb5.6"
    engine                    = "docdb"
    engine_version            = "5.6"
    enabled_cloudwatch_logs_exports = ["audit", "profiler"]
    allow_major_version_upgrade = true
    tags                      = {
      Name = "DocumentDB Cluster 1"
    }
    ssm_parameter_enabled     = true
    ssm_parameter_path_prefix = "/myapp/documentdb/"
    context                   = {
      env = "production"
    }
    cluster_size              = 3
    cluster_identifier        = "docdb-cluster-1"
  },
]

The plan is still proposing creation of all these resources which not all are needed
Terraform will perform the following actions:

  # module.documentdb["cluster1"].aws_docdb_cluster.default[0] will be created
  + resource "aws_docdb_cluster" "default" {
      + allow_major_version_upgrade     = true
      + apply_immediately               = true
      + arn                             = (known after apply)
      + availability_zones              = (known after apply)
      + backup_retention_period         = 7
      + cluster_identifier              = "docdb-cluster-1"
      + cluster_identifier_prefix       = (known after apply)
      + cluster_members                 = (known after apply)
      + cluster_resource_id             = (known after apply)
      + db_cluster_parameter_group_name = "documentdb-cluster"
      + db_subnet_group_name            = "docdb-poc-subnet"
      + deletion_protection             = true
      + enabled_cloudwatch_logs_exports = [
          + "audit",
          + "profiler",
        ]
      + endpoint                        = (known after apply)
      + engine                          = "docdb"
      + engine_version                  = "5.6"
      + final_snapshot_identifier       = "documentdb-poc-cluster"
      + hosted_zone_id                  = (known after apply)
      + id                              = (known after apply)
      + kms_key_id                      = "arn:aws:kms:us-east-1:123456789012:key/abcd1234-a123-456a-a12b-a123b4cd56ef"
      + master_password                 = (sensitive value)
      + master_username                 = "admin"
      + port                            = 27017
      + preferred_backup_window         = "07:00-09:00"
      + preferred_maintenance_window    = "mon:09:00-mon:09:30"
      + reader_endpoint                 = (known after apply)
      + skip_final_snapshot             = false
      + storage_encrypted               = true
      + tags                            = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + tags_all                        = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + vpc_security_group_ids          = (known after apply)
    }

  # module.documentdb["cluster1"].aws_docdb_cluster_instance.default[0] will be created
  + resource "aws_docdb_cluster_instance" "default" {
      + apply_immediately               = true
      + arn                             = (known after apply)
      + auto_minor_version_upgrade      = true
      + availability_zone               = (known after apply)
      + ca_cert_identifier              = (known after apply)
      + cluster_identifier              = (known after apply)
      + db_subnet_group_name            = (known after apply)
      + dbi_resource_id                 = (known after apply)
      + enable_performance_insights     = false
      + endpoint                        = (known after apply)
      + engine                          = "docdb"
      + engine_version                  = (known after apply)
      + id                              = (known after apply)
      + identifier                      = "documentdb-poc-cluster-1"
      + identifier_prefix               = (known after apply)
      + instance_class                  = "db.r4.large"
      + kms_key_id                      = (known after apply)
      + performance_insights_kms_key_id = (known after apply)
      + port                            = (known after apply)
      + preferred_backup_window         = (known after apply)
      + preferred_maintenance_window    = "mon:09:00-mon:09:30"
      + promotion_tier                  = 0
      + publicly_accessible             = (known after apply)
      + storage_encrypted               = (known after apply)
      + tags                            = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + tags_all                        = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + writer                          = (known after apply)
    }

  # module.documentdb["cluster1"].aws_docdb_cluster_instance.default[1] will be created
  + resource "aws_docdb_cluster_instance" "default" {
      + apply_immediately               = true
      + arn                             = (known after apply)
      + auto_minor_version_upgrade      = true
      + availability_zone               = (known after apply)
      + ca_cert_identifier              = (known after apply)
      + cluster_identifier              = (known after apply)
      + db_subnet_group_name            = (known after apply)
      + dbi_resource_id                 = (known after apply)
      + enable_performance_insights     = false
      + endpoint                        = (known after apply)
      + engine                          = "docdb"
      + engine_version                  = (known after apply)
      + id                              = (known after apply)
      + identifier                      = "documentdb-poc-cluster-2"
      + identifier_prefix               = (known after apply)
      + instance_class                  = "db.r4.large"
      + kms_key_id                      = (known after apply)
      + performance_insights_kms_key_id = (known after apply)
      + port                            = (known after apply)
      + preferred_backup_window         = (known after apply)
      + preferred_maintenance_window    = "mon:09:00-mon:09:30"
      + promotion_tier                  = 0
      + publicly_accessible             = (known after apply)
      + storage_encrypted               = (known after apply)
      + tags                            = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + tags_all                        = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + writer                          = (known after apply)
    }

  # module.documentdb["cluster1"].aws_docdb_cluster_instance.default[2] will be created
  + resource "aws_docdb_cluster_instance" "default" {
      + apply_immediately               = true
      + arn                             = (known after apply)
      + auto_minor_version_upgrade      = true
      + availability_zone               = (known after apply)
      + ca_cert_identifier              = (known after apply)
      + cluster_identifier              = (known after apply)
      + db_subnet_group_name            = (known after apply)
      + dbi_resource_id                 = (known after apply)
      + enable_performance_insights     = false
      + endpoint                        = (known after apply)
      + engine                          = "docdb"
      + engine_version                  = (known after apply)
      + id                              = (known after apply)
      + identifier                      = "documentdb-poc-cluster-3"
      + identifier_prefix               = (known after apply)
      + instance_class                  = "db.r4.large"
      + kms_key_id                      = (known after apply)
      + performance_insights_kms_key_id = (known after apply)
      + port                            = (known after apply)
      + preferred_backup_window         = (known after apply)
      + preferred_maintenance_window    = "mon:09:00-mon:09:30"
      + promotion_tier                  = 0
      + publicly_accessible             = (known after apply)
      + storage_encrypted               = (known after apply)
      + tags                            = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + tags_all                        = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + writer                          = (known after apply)
    }

  # module.documentdb["cluster1"].aws_docdb_cluster_parameter_group.default[0] will be created
  + resource "aws_docdb_cluster_parameter_group" "default" {
      + arn         = (known after apply)
      + description = "DB cluster parameter group"
      + family      = "documentdb5.6"
      + id          = (known after apply)
      + name        = "documentdb-cluster"
      + name_prefix = (known after apply)
      + tags        = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + tags_all    = {
          + "Name" = "DocumentDB Cluster 1"
        }

      + parameter {
          + apply_method = "immediate"
          + name         = "parameter1"
          + value        = "value1"
        }
    }

  # module.documentdb["cluster1"].aws_docdb_subnet_group.default[0] will be created
  + resource "aws_docdb_subnet_group" "default" {
      + arn         = (known after apply)
      + description = "Allowed subnets for DB cluster instances"
      + id          = (known after apply)
      + name        = "docdb-poc-subnet"
      + name_prefix = (known after apply)
      + subnet_ids  = [
          + "subnet-0123456789abcdef0",
          + "subnet-abcdef01234567890",
        ]
      + tags        = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + tags_all    = {
          + "Name" = "DocumentDB Cluster 1"
        }
    }

  # module.documentdb["cluster1"].aws_security_group.default[0] will be created
  + resource "aws_security_group" "default" {
      + arn                    = (known after apply)
      + description            = "Security Group for DocumentDB cluster"
      + egress                 = (known after apply)
      + id                     = (known after apply)
      + ingress                = (known after apply)
      + name                   = (known after apply)
      + name_prefix            = (known after apply)
      + owner_id               = (known after apply)
      + revoke_rules_on_delete = false
      + tags                   = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + tags_all               = {
          + "Name" = "DocumentDB Cluster 1"
        }
      + vpc_id                 = "vpc-0123456789abcdef0"
    }

  # module.documentdb["cluster1"].aws_security_group_rule.egress[0] will be created
  + resource "aws_security_group_rule" "egress" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + description              = "Allow outbound traffic from CIDR blocks"
      + from_port                = 0
      + id                       = (known after apply)
      + protocol                 = "-1"
      + security_group_id        = (known after apply)
      + security_group_rule_id   = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 0
      + type                     = "egress"
    }

  # module.subnets.aws_network_acl.private[0] will be created
  + resource "aws_network_acl" "private" {
      + arn        = (known after apply)
      + egress     = (known after apply)
      + id         = (known after apply)
      + ingress    = (known after apply)
      + owner_id   = (known after apply)
      + subnet_ids = (known after apply)
      + tags       = {
          + "Attributes" = "private"
          + "Name"       = "private"
        }
      + tags_all   = {
          + "Attributes" = "private"
          + "Name"       = "private"
        }
      + vpc_id     = (known after apply)
    }

  # module.subnets.aws_network_acl.public[0] will be created
  + resource "aws_network_acl" "public" {
      + arn        = (known after apply)
      + egress     = (known after apply)
      + id         = (known after apply)
      + ingress    = (known after apply)
      + owner_id   = (known after apply)
      + subnet_ids = (known after apply)
      + tags       = {
          + "Attributes" = "public"
          + "Name"       = "public"
        }
      + tags_all   = {
          + "Attributes" = "public"
          + "Name"       = "public"
        }
      + vpc_id     = (known after apply)
    }

  # module.subnets.aws_network_acl_rule.private4_egress[0] will be created
  + resource "aws_network_acl_rule" "private4_egress" {
      + cidr_block     = "<IP_ADDRESS>/0"
      + egress         = true
      + from_port      = 0
      + id             = (known after apply)
      + network_acl_id = (known after apply)
      + protocol       = "-1"
      + rule_action    = "allow"
      + rule_number    = 100
      + to_port        = 0
    }

  # module.subnets.aws_network_acl_rule.private4_ingress[0] will be created
  + resource "aws_network_acl_rule" "private4_ingress" {
      + cidr_block     = "<IP_ADDRESS>/0"
      + egress         = false
      + from_port      = 0
      + id             = (known after apply)
      + network_acl_id = (known after apply)
      + protocol       = "-1"
      + rule_action    = "allow"
      + rule_number    = 100
      + to_port        = 0
    }

  # module.subnets.aws_network_acl_rule.public4_egress[0] will be created
  + resource "aws_network_acl_rule" "public4_egress" {
      + cidr_block     = "<IP_ADDRESS>/0"
      + egress         = true
      + from_port      = 0
      + id             = (known after apply)
      + network_acl_id = (known after apply)
      + protocol       = "-1"
      + rule_action    = "allow"
      + rule_number    = 100
      + to_port        = 0
    }

  # module.subnets.aws_network_acl_rule.public4_ingress[0] will be created
  + resource "aws_network_acl_rule" "public4_ingress" {
      + cidr_block     = "<IP_ADDRESS>/0"
      + egress         = false
      + from_port      = 0
      + id             = (known after apply)
      + network_acl_id = (known after apply)
      + protocol       = "-1"
      + rule_action    = "allow"
      + rule_number    = 100
      + to_port        = 0
    }

  # module.subnets.aws_route.public[0] will be created
  + resource "aws_route" "public" {
      + destination_cidr_block = "<IP_ADDRESS>/0"
      + gateway_id             = (known after apply)
      + id                     = (known after apply)
      + instance_id            = (known after apply)
      + instance_owner_id      = (known after apply)
      + network_interface_id   = (known after apply)
      + origin                 = (known after apply)
      + route_table_id         = (known after apply)
      + state                  = (known after apply)

      + timeouts {}
    }

  # module.subnets.aws_route_table.private[0] will be created
  + resource "aws_route_table" "private" {
      + arn              = (known after apply)
      + id               = (known after apply)
      + owner_id         = (known after apply)
      + propagating_vgws = (known after apply)
      + route            = (known after apply)
      + tags             = {
          + "Attributes" = "private"
          + "Name"       = "private-use1a"
        }
      + tags_all         = {
          + "Attributes" = "private"
          + "Name"       = "private-use1a"
        }
      + vpc_id           = (known after apply)
    }

  # module.subnets.aws_route_table.private[1] will be created
  + resource "aws_route_table" "private" {
      + arn              = (known after apply)
      + id               = (known after apply)
      + owner_id         = (known after apply)
      + propagating_vgws = (known after apply)
      + route            = (known after apply)
      + tags             = {
          + "Attributes" = "private"
          + "Name"       = "private-use1b"
        }
      + tags_all         = {
          + "Attributes" = "private"
          + "Name"       = "private-use1b"
        }
      + vpc_id           = (known after apply)
    }

  # module.subnets.aws_route_table.public[0] will be created
  + resource "aws_route_table" "public" {
      + arn              = (known after apply)
      + id               = (known after apply)
      + owner_id         = (known after apply)
      + propagating_vgws = (known after apply)
      + route            = (known after apply)
      + tags             = {
          + "Attributes" = "public"
          + "Name"       = "public"
        }
      + tags_all         = {
          + "Attributes" = "public"
          + "Name"       = "public"
        }
      + vpc_id           = (known after apply)
    }

  # module.subnets.aws_route_table_association.private[0] will be created
  + resource "aws_route_table_association" "private" {
      + id             = (known after apply)
      + route_table_id = (known after apply)
      + subnet_id      = (known after apply)
    }

  # module.subnets.aws_route_table_association.private[1] will be created
  + resource "aws_route_table_association" "private" {
      + id             = (known after apply)
      + route_table_id = (known after apply)
      + subnet_id      = (known after apply)
    }

  # module.subnets.aws_route_table_association.public[0] will be created
  + resource "aws_route_table_association" "public" {
      + id             = (known after apply)
      + route_table_id = (known after apply)
      + subnet_id      = (known after apply)
    }

  # module.subnets.aws_route_table_association.public[1] will be created
  + resource "aws_route_table_association" "public" {
      + id             = (known after apply)
      + route_table_id = (known after apply)
      + subnet_id      = (known after apply)
    }

  # module.subnets.aws_subnet.private[0] will be created
  + resource "aws_subnet" "private" {
      + arn                                            = (known after apply)
      + assign_ipv6_address_on_creation                = false
      + availability_zone                              = "us-east-1a"
      + availability_zone_id                           = (known after apply)
      + cidr_block                                     = "<IP_ADDRESS>/24"
      + enable_dns64                                   = false
      + enable_resource_name_dns_a_record_on_launch    = false
      + enable_resource_name_dns_aaaa_record_on_launch = false
      + id                                             = (known after apply)
      + ipv6_cidr_block_association_id                 = (known after apply)
      + ipv6_native                                    = false
      + map_public_ip_on_launch                        = false
      + owner_id                                       = (known after apply)
      + private_dns_hostname_type_on_launch            = "ip-name"
      + tags                                           = {
          + "Attributes" = "private"
          + "Name"       = "private-use1a"
        }
      + tags_all                                       = {
          + "Attributes" = "private"
          + "Name"       = "private-use1a"
        }
      + vpc_id                                         = (known after apply)

      + timeouts {}
    }

  # module.subnets.aws_subnet.private[1] will be created
  + resource "aws_subnet" "private" {
      + arn                                            = (known after apply)
      + assign_ipv6_address_on_creation                = false
      + availability_zone                              = "us-east-1b"
      + availability_zone_id                           = (known after apply)
      + cidr_block                                     = "<IP_ADDRESS>/24"
      + enable_dns64                                   = false
      + enable_resource_name_dns_a_record_on_launch    = false
      + enable_resource_name_dns_aaaa_record_on_launch = false
      + id                                             = (known after apply)
      + ipv6_cidr_block_association_id                 = (known after apply)
      + ipv6_native                                    = false
      + map_public_ip_on_launch                        = false
      + owner_id                                       = (known after apply)
      + private_dns_hostname_type_on_launch            = "ip-name"
      + tags                                           = {
          + "Attributes" = "private"
          + "Name"       = "private-use1b"
        }
      + tags_all                                       = {
          + "Attributes" = "private"
          + "Name"       = "private-use1b"
        }
      + vpc_id                                         = (known after apply)

      + timeouts {}
    }

  # module.subnets.aws_subnet.public[0] will be created
  + resource "aws_subnet" "public" {
      + arn                                            = (known after apply)
      + assign_ipv6_address_on_creation                = false
      + availability_zone                              = "us-east-1a"
      + availability_zone_id                           = (known after apply)
      + cidr_block                                     = "<IP_ADDRESS>/24"
      + enable_dns64                                   = false
      + enable_resource_name_dns_a_record_on_launch    = false
      + enable_resource_name_dns_aaaa_record_on_launch = false
      + id                                             = (known after apply)
      + ipv6_cidr_block_association_id                 = (known after apply)
      + ipv6_native                                    = false
      + map_public_ip_on_launch                        = true
      + owner_id                                       = (known after apply)
      + private_dns_hostname_type_on_launch            = "ip-name"
      + tags                                           = {
          + "Attributes" = "public"
          + "Name"       = "public-use1a"
        }
      + tags_all                                       = {
          + "Attributes" = "public"
          + "Name"       = "public-use1a"
        }
      + vpc_id                                         = (known after apply)

      + timeouts {}
    }

  # module.subnets.aws_subnet.public[1] will be created
  + resource "aws_subnet" "public" {
      + arn                                            = (known after apply)
      + assign_ipv6_address_on_creation                = false
      + availability_zone                              = "us-east-1b"
      + availability_zone_id                           = (known after apply)
      + cidr_block                                     = "<IP_ADDRESS>/24"
      + enable_dns64                                   = false
      + enable_resource_name_dns_a_record_on_launch    = false
      + enable_resource_name_dns_aaaa_record_on_launch = false
      + id                                             = (known after apply)
      + ipv6_cidr_block_association_id                 = (known after apply)
      + ipv6_native                                    = false
      + map_public_ip_on_launch                        = true
      + owner_id                                       = (known after apply)
      + private_dns_hostname_type_on_launch            = "ip-name"
      + tags                                           = {
          + "Attributes" = "public"
          + "Name"       = "public-use1b"
        }
      + tags_all                                       = {
          + "Attributes" = "public"
          + "Name"       = "public-use1b"
        }
      + vpc_id                                         = (known after apply)

      + timeouts {}
    }

  # module.vpc.aws_default_security_group.default[0] will be created
  + resource "aws_default_security_group" "default" {
      + arn                    = (known after apply)
      + description            = (known after apply)
      + egress                 = (known after apply)
      + id                     = (known after apply)
      + ingress                = (known after apply)
      + name                   = (known after apply)
      + name_prefix            = (known after apply)
      + owner_id               = (known after apply)
      + revoke_rules_on_delete = false
      + tags                   = {
          + "Name" = "-default"
        }
      + tags_all               = {
          + "Name" = "-default"
        }
      + vpc_id                 = (known after apply)
    }

  # module.vpc.aws_internet_gateway.default[0] will be created
  + resource "aws_internet_gateway" "default" {
      + arn      = (known after apply)
      + id       = (known after apply)
      + owner_id = (known after apply)
      + tags_all = (known after apply)
      + vpc_id   = (known after apply)
    }

  # module.vpc.aws_vpc.default[0] will be created
  + resource "aws_vpc" "default" {
      + arn                                  = (known after apply)
      + assign_generated_ipv6_cidr_block     = true
      + cidr_block                           = "<IP_ADDRESS>/20"
      + default_network_acl_id               = (known after apply)
      + default_route_table_id               = (known after apply)
      + default_security_group_id            = (known after apply)
      + dhcp_options_id                      = (known after apply)
      + enable_dns_hostnames                 = true
      + enable_dns_support                   = true
      + enable_network_address_usage_metrics = false
      + id                                   = (known after apply)
      + instance_tenancy                     = "default"
      + ipv6_association_id                  = (known after apply)
      + ipv6_cidr_block                      = (known after apply)
      + ipv6_cidr_block_network_border_group = (known after apply)
      + main_route_table_id                  = (known after apply)
      + owner_id                             = (known after apply)
      + tags_all                             = (known after apply)
    }

Plan: 29 to add, 0 to change, 0 to destroy.

Please suggest if I am missing any changes

please ignore!
I was able to figure out myself and yes subnet_ids worked like a charm


Minor edit for Visual Studio DLL linkage

If you want to place tinyxml2 in a DLL, you will run into problems because the StrPair class is not exported. Three edits solve this problem:
XMLAttribute::Name() and XMLAttribute::Value() cannot be declared inline; the same applies to XMLNode::Value().
If you define these methods in the cpp file, tinyxml2 works fine in a DLL.

DLL supported added some time ago.


Add definitions for some public key and known hosts functions

Working on adding more but I have some unpublished code working with these now.

I'm sorry that I didn't give this a timely review, but I am willing to add such bindings if you'd like to reopen this...

I have more changes in progress and I need to complete some paperwork for my employer before contributing.  Will reopen once that's complete.


start up redis 7

This makes Kaiser start up a redis 7 instance, letting us start standardizing on this version of Redis

@Agroang can you help us review this PR, please?


Implement ElementHandle.ScreenshotStreamAsync

closes #30

Ready to review @Meir017

Done @Meir017

CodeFactor found a duplicated code 😏

Regarding the CodeFactor issue @Meir017. I don't buy that. We won't create a base class just to reuse those Screenshots overrides.

How about a static internal method on one the yhe classes?

@Meir017  The thing is that those 3 "duplicated" methods end up calling its own  public async Task<Stream> ScreenshotStreamAsync(ScreenshotOptions options) and the implementation is different there.
Or am I missing something?

Ok


Redfish LDAP Automation and testing

[x] Test plan
[x] Test and verification
[x] Automate

[ ] Refer Redfish LDAP Test Plan  https://github.com/openbmc/openbmc-test-automation/issues/1520

All tasks for LDAP completed we targeted for. Closing epic. Thanks @sivassrr


Load a default DFK if none has been loaded

We currently being the userguide with a discussion of apps, futures, etc, but do not show a complete example (including the configuration) until significantly later in the documentation. I think it is reasonable to wait until later for a detailed discussion of config options, but in that case, we should consider removing the DFK from the examples and loading a default one (ThreadPoolExecutor) if none has been loaded.

I'm changing the name to clarify this proposal. The proposal is to load a default DFK if none has been loaded. The motivation for doing so is so that we can show ac omplete example of a simple python App earlier in the documentation; to start with running simple apps instead of start by talking about configs.


Diagnostic check for instance variables that are not initialized in constructor

I don't know if this is a bug or a feature, but pylance reports no errors for the following code, while mypy helpfully reports Cannot determine type of "children":
from __future__ import annotations
from typing import Optional

class Entry:
    def __init__(self, name: Optional[str]):
        self.name = name
        self.childrn: Optional[list[float]] = None

    def add_child(self, child: Entry) -> None:
        if self.children is None:  # mypy errors here
            self.children = ["str"]  # pylance is okay with this
        else:
            self.children.append("str")

This really is the kind of thing I'd expect a type checker to catch. I'd like to keep mypy turned off so I can use cyclic types. Am I misunderstanding something about pylance?

You've misspelled childrn in the constructor, so children is a different instance variable that has no type annotation, and its type must be inferred. Pylance's type inference techniques are more sophisticated than mypy's. In this particular case, it's inferring the type of self.children to be list[str] because it is assigned that type.

Thank you. That explains it, and yet I hate this. I'll need to use mypy as well.
Is there a switch that makes pylance require all member variables be declared in __init__?

The fact that mypy reported an error here is just by chance. It's not even reporting the correct error. The real error — the one that would be manifest at runtime — is that you're accessing an unbound instance variable. Mypy doesn't track unbound variables at all. Pylance does, but it can do so only within an execution context (e.g. within a function). It can't track execution flow across functions because function execution order cannot be determined statically. So you happen to get lucky here that mypy happens to be unable to infer the type, and it's emitting another false-positive error.
There is no switch that requires all member variables to be declared in __init__. I don't think that would be very useful in the vast majority of Python code bases. It's unfortunately idiomatic to create new instance variables in methods other than the constructor. I suppose we could consider adding such a check, but it would be useful only for those who want "super super strict mode".

I see. Thanks for the further explanation. I'd like to suggest that this feature would be useful to all those coming from statically-typed languages who expect this sort of behavior. Right now, pylance is the only reason I'm considering doing work in Python. I like type checking partly for its ability to find bugs such as these, and partly for its help with refactoring. In my case, I was actually refactoring code and discovered that changing the name of a member variable in __init__ broke no type checking. This is my trial run, and I so love the Python syntax that I want it to work, but I'm not yet convinced that I can get sufficient type support in Python.
Put another way, such a switch would enable developers who prefer statically-typed languages to allow themselves to work with Python. It could bring many more devs into the Python fold.

Should I create a new post for a feature request, being more concise about the proposal?

No need to create a new feature request. We can use this issue to track it. I'll change the title accordingly.
I think your idea has merit.
I think I'll prototype it and try it on some Python code bases that are more strictly typed. That will help inform how many false positives versus actual bugs it finds.

Thank you so much! I'm looking forward to trying it.

Turns out we discussed this a few months ago. See this issue: https://github.com/microsoft/pyright/issues/1924. I dusted off the code that I had written when I explored that. As I mentioned in the other issue, this diagnostic isn't going to be useful for most Python code bases because there are too many legitimate cases where instance variables are not initialized in the constructor.
But this has now come up enough times (once in a mypy issue, once in a pyright issue and now in a pylance feature request) that I think it's worth including. I've added a new diagnostic check called "reportUninitializedInstanceVariable" that can be enabled optionally. It's off by default, even in strict mode.

It's off by default, even in strict mode.

The commit has this the other way around, it seems: https://github.com/microsoft/pyright/commit/2156f2eb73ecf918dd75c787a2463420911b2b07#diff-7bc0b8aef76656a15cbcfa1c3ab7294cedf52638fdd62d83fd6e41be5a9dc498R533
(and other lines)

Thanks for catching that. I think this happened during the rebase that I did immediately before pushing to the remote repo.
-Eric

On Jul 14, 2021, at 4:18 PM, Jake Bailey @.***> wrote:
It's off by default, even in strict mode.
The commit has this the other way around, it seems: @.***#diff-7bc0b8aef76656a15cbcfa1c3ab7294cedf52638fdd62d83fd6e41be5a9dc498R533 https://github.com/microsoft/pyright/commit/2156f2eb73ecf918dd75c787a2463420911b2b07#diff-7bc0b8aef76656a15cbcfa1c3ab7294cedf52638fdd62d83fd6e41be5a9dc498R533
(and other lines)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/microsoft/pylance-release/issues/1552#issuecomment-880246788, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVWY6UBSU6SWRWH3JHSLQTTXYEKZANCNFSM5AL7HY6A.

@erictraut, I have your mods installed and working in a pyright extension, with pylance disabled. Thank you so much! I'll let you know if I encounter any issues.

Unless I'm mistaken, I think that this was implemented but not closed.


Mobile data not working

I don't know if this is yalu related or not, but if its not then plz close this issue.
After a day with jailbreak my i6 ended up with no mobile data connection.
At first I thought that resetting network settings would work. It didn't.
I then tried the following chmod commands also with no efect:
chmod 777 /var
chmod 777 /var/mobile
chmod 777 /var/mobile/Library
chmod 777 /var/mobile/Library/Preferences
Before restoring my device, do you have any idea about what may have done this?  Thanks.

i do not believe this is yalu related. closing, but if you have any interesting crashlog, feel free to comment again

Sorry, where should I look for the crashlog related to this mobile data problem?
Thank you once again.

Well... Decided to do a restore from an iCloud backup and it didn't fix it.
Ended up doing a complete restore and it solved the issue.
:|


Invoices are not downloadable

PHP Version
7.4.x
Shopware Version
<IP_ADDRESS>
Expected behaviour
Allow customer to download invoices in their "account" area.
First: document types has to be configured to display in "account area" (displayInCustomerAccount = true)
Second: the invoice has to be sent or marked as sent.
Third: the customer will see a button to download the invoice or a document.
Actual behaviour
All steps are done, but there are no documents in the customer area.
How to reproduce
The bug is inside "vendor/shopware/core/Checkout/Order/SalesChannel/OrderRoute.php"
Remove the "->addFilter(new EqualsFilter('config.displayInCustomerAccount', 'true'))" line on the load() method.
All invoices which are "sent" are now visible and the configuration is correct.

The bug is inside "vendor/shopware/core/Checkout/Order/SalesChannel/OrderRoute.php"
Remove the "->addFilter(new EqualsFilter('config.displayInCustomerAccount', 'true'))" line on the load() method.
All invoices which are "sent" are now visible and the configuration is correct.
what is  load() method. a sample please

### what is load() method. a sample please

https://www.e-recht24.de/news/ecommerce/13369-die-wirtschafts-id-kommt-was-das-fuer-ihr-impressum-bedeutet.html


KeepAlive not working with React Portals - React 18

Hi! nice library, but I'd like to ask for help solving an issue with React 18 and createPortal.
Current Behaviour:
When using KeepAlive inside portals, the component wrapped by KeepAlive is frozen, ie it is rendered but it is not possible to interact with it.
I've made a PoC in this sandbox. This problem only happens using React 18, the same code using React 16 works fine (here a sandbox).
I appreciate any help you can provide on this.
Greetings.

For reference, this works on React16 but doesn't on React17/18:
const Portal = createPortal(children, target)

const usage =
  <AliveScope>
    <Portal>
      <Counter />
    </Portal>
  </AliveScope>


Use Furo documentation theme

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #1693

[ ] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[ ] CHANGES.rst has been updated (with summary of main changes)

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Replaces the sphinx-rtd-theme for the furo documentation theme
Adapts the conf.py to make use of specific variables for furo
Adds an alternate logo for the "dark" theme
Updates the docstrings for xclim/data/__init__.py and xclim/core/locales.py
Synchronizes tooling dependency versions (ruff, black, yamllint)

Does this PR introduce a breaking change?
Yes. The theme has been completely replaced with furo, which gives us a dark mode for free as well as better navigation scroll bars when viewing pages in landscape mode.
Other information:
The load order of layouts appears to be slightly different, and I'm having trouble getting the indicators.rst search bar to load properly. Likely a very small change is needed.

@aulemahal (and @SarahG-579462)
Tagging you here for the JavaScript magic. I think the layout files are handled differently or load later. It seems as though the header content that should be adding minisearch.js to the relevant pages isn't working as intended.

@Zeitsperre Fixed the javascript and html injection! Furo simply uses a different base template name and jinja blocks.

Dark mode is looking sharp!

I think that if we fix the jupyter notebook issue on auto (or remove auto), and fix the yaml issue for numbers, this is good to go.

This latest commit fixes the issue with xarray not working in "auto" mode.
It is not the prettiest solution, since it requires redefining the xarray theme variables in the body tag. (in _static/xarray.css)
I chose to update the xarray css variables (e.g. --xr-font-color0) thru the externalized --jp variables that xarray seems to offer. I'm assuming these are jupyter variables. This fix should therefore be compatible with any jupyter output that uses variables set with a scope within body.
Other options would have been:

Copying the css that furo uses to set variables when swapping to light or dark mode, and adding a selector so that it updates in the root instead of the body.
Redefining the xarray colours in the body, instead of the offered --jp variables.

This might be a better solution, but it does not offer the nicety that is potentially fixing other jupyter notebook output issues.

wait for an upstream fix in either xarray or furo.

The xarray upstream fix could be done in two ways:

Add compatibility for the "auto" theme by using a similar css selector to furo, but targeting the :root pseudo-class instead of the body tag (using the :has pseudo-class)
Change the xarray default theming to be set in body instead of, or on top of, :root

the furo fix would be to:

Make the css variables apply to the :root pseudo-clas, instead of/on top of the body tag (once again with the :has pseudo-class.


May I ask where you obtained your icosphere .vtk file?

Dear Shape-Lab,
I want to observe the effect of SPHARM on spheres of other scales(like ico5 , ico7). I found some. vtk files on Github, but they seem to be different from the ico6.vtk you provided. I think I may have made a mistake.
So I wonder where you obtained your ico6.vtk, and I would like to obtain some different scales of ico.vtk.
Looking forward to your reply

Thanks for reaching out to us. Our method is independent of a specific tessellation because it does not rely on neighborhood information. Any spherical tessellation should work fine, which means that you can use any mesh files you have. All you need is to just supply your mesh file to --sphere in prep.py and train.py.

Thank you for your timely reply.
Could you tell me where I can get icosphere mesh in vtk format?
I am not very familiar with this format,  actually，the mesh format I often use is the .surf.gii . I can obtain ico6.vtk through the command line you provided. How can I obtain icosphere mesh of other scales?

Dear ilwoolyu,
I noticed that the ico6 you provided is a spherical mesh with a radius of 1, but the icospheres I found in your repositories [https://github.com/ilwoolyu/HSD/tree/master/script/sphere] are all mesh with a radius of 100.
I also try to use https://github.com/ilwoolyu/SphericalLabeling/blob/master/gen_ico.py to generate icosahedral mesh files, but I cannot access the URL in the code.
I'm not sure if using mesh with different radius will affect the resultsof SPHARM. I would greatly appreciate it if you could provide me with other sizes of icosphere (such as ico3. vtk to ico7.vtk).
Looking forward to your reply

You can normalize the mesh with a radius of 100 by dividing it to 100. For convenience, I share the icosphere(the level of 0 to 7).
link: https://drive.google.com/drive/folders/1soji525WMtsNID4X8iKHkbL2ud9-QSOj?usp=sharing

This is very helpful for my study. Thank you very much.


Time slice not working for 360_day calendar

@mattiarighi detected some problems with the calendar in some models:

HadCM3, HadGEM2-AO, HadGEM2-CC, HadGEM2-ES: the code exits on error due to a problem with the calendar.

This was due to the fact that we were trying to slice between January 1st of start year to December 31st of last year. As 31st December is not a valid date in this calendar, an error was raising
I will add a check that will convert the 31 to 30 when we are using the 360_day calendar

Shouldn't the end date be January 1st anyway? I assume the time is set to 00:00, so if you slice on December 31st you're missing the last day of the year.

In this way you would also include January (since these are monthly means).

We will need further testing with the diagnostics using daily values, but for now we can mark this as solved.


Copilot cannot use after 30 minutes

Issue happen every 30 mins using and have to restart extension copilot again :
2024-09-10 15:06:56.257 [info] [auth] Got Copilot token for mjkokid
2024-09-10 15:06:56.266 [info] [chat] copilot token chat_enabled: true
2024-09-10 15:06:56.266 [info] [githubTitleAndDescriptionProvider] GitHub.vscode-pull-request-github extension is not yet activated.
2024-09-10 15:06:59.008 [info] [contributions] activationBlocker from 'languageModelAccess' took for 8596ms
2024-09-10 15:07:25.978 [info] [chat fetch] request.response: [https://api.business.githubcopilot.com/chat/completions], took 2040 ms
2024-09-10 15:07:26.002 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-09-10 15:07:26.003 [info] [streamChoices] request done: requestId: [5d78769c-10ad-4121-beee-1108c7357a53] model deployment ID: []
2024-09-10 15:07:28.060 [info] [chat fetch] request.response: [https://api.business.githubcopilot.com/chat/completions], took 2051 ms
2024-09-10 15:07:28.062 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-09-10 15:07:28.063 [info] [streamChoices] request done: requestId: [531d51a2-39f3-4ede-9a42-7f5ebd978ea1] model deployment ID: []
2024-09-10 15:31:56.332 [info] [auth] Logged in as mjkokid
2024-09-10 15:36:59.159 [info] [auth] Logged in as mjkokid
2024-09-10 15:37:00.215 [info] [LanguageModelAccess] LanguageModel/Embeddings are not available without auth token
2024-09-10 15:37:00.215 [info] [LanguageModelAccess] SyntaxError: Unexpected token '<', "
<h"... is not valid JSON
at JSON.parse ()
at t.json (c:\Users\apo1hc.vscode\extensions\github.copilot-chat-0.18.2\dist\extension.js:13:17068)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at kS.authFromGitHubToken (c:\Users\apo1hc.vscode\extensions\github.copilot-chat-0.18.2\dist\extension.js:633:3978)
at kS.auth (c:\Users\apo1hc.vscode\extensions\github.copilot-chat-0.18.2\dist\extension.js:633:13173)
at kS.authShowWarnings (c:\Users\apo1hc.vscode\extensions\github.copilot-chat-0.18.2\dist\extension.js:633:13330)
at kS.getCopilotToken (c:\Users\apo1hc.vscode\extensions\github.copilot-chat-0.18.2\dist\extension.js:633:12143)
at Q_.getCopilotToken (c:\Users\apo1hc.vscode\extensions\github.copilot-chat-0.18.2\dist\extension.js:144:2645)
at AS._getAuthSession (c:\Users\apo1hc.vscode\extensions\github.copilot-chat-0.18.2\dist\extension.js:634:2188)
at Timeout.r [as _onTimeout] (c:\Users\apo1hc.vscode\extensions\github.copilot-chat-0.18.2\dist\extension.js:634:627)

No update?

Please update to VS Code 1.93.1 and GitHub Copilot Chat 0.20.1 to get the latest fixes.


Servermetrics

Dear all
Although there are other tools like nagios or cacti, we'd like to have server infos in munkireport and then have the ability to make a summary of it. The logs can be found in /private/var/log/servermetricsd/. Server.app is cool, but not flexible enough. Furthermore we'd like to see the evolution of the TimeMachine status and TimeMachineServer status. And the amount of free strage in %. And when the certificats run out. And Crashplan if possible. Perhaps even more, but let's start easy.
Now the problem. I have no idea how to code it and I'm looking for someone who could do it for me (not for free of corse).
Thanks for inputs, Stefan.

Hi Stefan,
Could you contact me directly about this?
-Arjen

Dear Arjen
Well yes - but how? You could call me at 0041 76 3776773 or send me an email at<EMAIL_ADDRESS>Stefan =:-)


Update github-corporate-terms-of-service.md

Clarifications and alignment of the language across our Terms of Service, Privacy Statement, Corporate Terms of Service, and Enterprise Subscription Agreement regarding

notice of changes
access to private content

Clarification that providing our Service includes use to improve the Service, and that third-party contractors may use content in connection with our Archive Program
Clarification, for greater license certainty, that the inbound=outbound license model applies to issues and comments submitted to a repository when changes are made in response to or including those issues and comments

Updates will go into effect after the 30-day notice and comment period, on November 16, at 5 pm PT.

Thanks for all your feedback! The policy changes are now live. You can learn more in our blog post here.


Stop docker container after closing kernel

Currently, docker containers keep running when a kernel/notebook is closed. This can start eating up a lot of resources over time.
To investigate:

How does jupyter arrange cleanup of kernels?
Can this command be integrated to stop docker container?

I have the same issue, this is my kernel.json file.
When a kernel stopped, I would be interested in capturing that signal and call the docker stop command. I would assume we would need to collect the docker image id to be able to call correctly docker stop. I'm not a iPython kernel expert but  seems to be this needs to be handled directly by a Kernel Manager such as here: https://github.com/jupyter/notebook/blob/master/notebook/services/kernels/kernelmanager.py
{
 "argv": [
  "/usr/bin/docker",
  "run",
  "--network=host",
  "-v",
  "{connection_file}:/connection-spec",
  "gcr.io/deeplearning-platform-release/tf2-cpu.2-4:latest",
  "python",
  "-m",
  "ipykernel_launcher",
  "-f",
  "/connection-spec"
 ],
 "display_name": "tensorflow",
 "language": "python"
}

I have the same issue, this is my kernel.json file.
When a kernel stopped, I would be interested in capturing that signal and call the docker stop command. I would assume we would need to collect the docker image id to be able to call correctly docker stop. I'm not a iPython kernel expert but  seems to be this needs to be handled directly by a Kernel Manager such as here: https://github.com/jupyter/notebook/blob/master/notebook/services/kernels/kernelmanager.py
{
 "argv": [
  "/usr/bin/docker",
  "run",
  "--network=host",
  "-v",
  "{connection_file}:/connection-spec",
  "gcr.io/deeplearning-platform-release/tf2-cpu.2-4:latest",
  "python",
  "-m",
  "ipykernel_launcher",
  "-f",
  "/connection-spec"
 ],
 "display_name": "tensorflow",
 "language": "python"
}

The normal behaviour for a container when running in the background is to stop whenver the CMD/ENTRYPOINT command stops. In this case the ipykernel receives the shutdown command, after which it terminates and the docker should automatically terminate.
For this project it works correctly most of the time, but in some cases the docker keeps running. I have yet to find a complete reproducible case, but will update if I find one.

The normal behaviour for a container when running in the background is to stop whenver the CMD/ENTRYPOINT command stops. In this case the ipykernel receives the shutdown command, after which it terminates and the docker should automatically terminate.
For this project it works correctly most of the time, but in some cases the docker keeps running. I have yet to find a complete reproducible case, but will update if I find one.

@vmenger @gogasca IIRC, back at the time I was developing the first release I had the same problem. Changing the default interrupt mode fixed the issue. I don't think this change was released, but it's merged to master(5ca4d069d11b25b5e58573fbceb6cc510eace165).

@vmenger @gogasca IIRC, back at the time I was developing the first release I had the same problem. Changing the default interrupt mode fixed the issue. I don't think this change was released, but it's merged to master(5ca4d069d11b25b5e58573fbceb6cc510eace165).

BTW. I've just realized that the release I've put out on PyPI either disappeared or was never deployed properly in the first place. Fixing this as we speak.

BTW. I've just realized that the release I've put out on PyPI either disappeared or was never deployed properly in the first place. Fixing this as we speak.

There you go. dockernel==1.0.1 should fix this issue.
I have no idea why I left all of this without releasing it properly, sorry for that.

There you go. dockernel==1.0.1 should fix this issue.
I have no idea why I left all of this without releasing it properly, sorry for that.

Closing this one. If anyone has this same problem again - please make sure it's dockernel==1.0.2 and if so, create a new issue. Thanks!


e2e: Identity on hover

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[x] E2E Test

What's new?

[x] PR closes #3760
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

do tests builds? 👀

now do, is code good to go?

some conflicts  @preschian  😇
meanwhile, tests seem to pass, great! )


"copyOnSelect": true - not working?

Environment
Windows build number: Microsoft Windows [Version 10.0.18363.959]
Windows Terminal version (if applicable): (latest just re installed with winget)

Any other software?
WSL

Steps to reproduce
select text, requires right click to copy, instead of copying on selection. Would like to right click once only to paste.
If I select text, then press escape, text is not copied.
Expected behavior
Right click once should be pasting instead of copying and requiring a second right-click.
Actual behavior
Right-clicking while text is selected will copy.. where it should have been copied on select, and right-click should paste instead.

The latest is now 1.6 preview. Winget takes a few days to get it updated once an updated manifest is provided. Please specify the version you are running. Incidentally it that setting workings just fine for me. If you are on 1.6 preview, did you open the Settings UI first? There's a slightly different setting name that appears to encompass more than one of the normal settings such as copyonSelect.

Yea, the specific version would be helpful. You can find this with the command wt -v (it'll open a message box)

Hello @WSLUser and @zadjii-msft
Thank you kindly for your replies. Running wt -v shows that the version I have is: 1.5.10271.0.
This probably means this feature is not yet available right?
If the 1.6 preview will be available in a week or so, I will wait and update.
If it is longer I will find how to update another way..
This sounds something simple but is a big habit. I I change my habit here, I will break my own usage of other apps :/
Thank you for your replies, and sorry for this non-issue report.

Winget takes a few days to get it updated once an updated manifest is provided.

as an aside: winget does not automatically update packages.

This is curious. copyOnSelect has been around since 0.3 or 0.4. You should not need a new version to get it working.
Would you mind sharing a copy of your settings.json file? You can upload it to GitHub's gist service

This is curious. copyOnSelect has been around since 0.3 or 0.4. You should not need a new version to get it working.
Would you mind sharing a copy of your settings.json file? You can upload it to GitHub's gist service

yes: https://gist.github.com/cusco/722d792887dee00daf354d9143a28578

This is curious. copyOnSelect has been around since 0.3 or 0.4. You should not need a new version to get it working.
Would you mind sharing a copy of your settings.json file? You can upload it to GitHub's gist service

yes: https://gist.github.com/cusco/722d792887dee00daf354d9143a28578

Upon reading my own settings.json I found the same option being set to false bellow. I don't know how this escaped me before, I'm pretty sure I used search in notepad before before adding the option...
I'm so sorry to waste your attention on this! It works as intended !
Thank you once more!

No worries, glad you figured it out (and that we didn't somehow regress this 😜)


Split commands / tasks into files

Concept: Split the bot's interaction commands and tasks into separate files in a commands and tasks folder, then iterate through and register them in the main file.

We only have 1 task, so i just have that in index.py. I will create a seperate tasks folder if we end up having more than one task.


deprecation warning

rakudo-star-2015.07/install/bin/perl6-m --target=mbc --output=rakudo-star-2015.07/install/share/perl6/lib/Template/Mustache.pm.moarvm rakudo-star-2015.07/install/share/perl6/lib/Template/Mustache.pm
Saw 1 occurrence of deprecated code.
$*PROGRAM_NAME seen at:
rakudo-star-2015.07/install/share/perl6/lib/Template/Mustache.pm, line 184
Deprecated since v2015.6, will be removed with release v2015.9!
Please use $*PROGRAM-NAME instead.
Please contact the author to have these occurrences of deprecated code
adapted, so that this message will disappear!
Please note that ALL deprecated features will be removed at the RC-0 release
(expected September 2015).

Thanks for the issue report. This was fixed by pull request #6 .


Changed yii\authclient\clients\Twitter $authUrl

It's will use previous logged user without request an access.
https://dev.twitter.com/oauth/reference/get/oauth/authenticate

Merged manually 275d87d

Thanks!


🐛 "Unable to retrieve socket path" when upgrading manjaro-sway-settings

branch
testing
Architecture
x86_64
Description
During the upgrade to manjaro-sway-settings 15.6.0 I noticed the following error message:
...
(1/1) upgrading manjaro-sway-settings                                                                    [--------------------------------------------------------------] 100%
00:00:00.009 [ERROR] [swaymsg/main.c:491] Unable to retrieve socket path
## in order to update your user configuration, run: skel
...

Reproduction steps
1. `sudo pacman -S manjaro-sway-settings`

Screenshots
No response
Logs
No response

Looks like a sway error when running swaymsg reload. No idea why tho.

Good catch! Do you know of a way to run a command during pacman install as the calling user?

As I don't think it is that important anyway: going with just the comment. Will be in the next release.


refactor(metrics): use object destructuring for otel prefix

This PR addresses a code style issue in the metrics.ts file. Previously, we were accessing the prefix property from the otel object directly. However, using object destructuring can make the code cleaner and easier to understand.
To improve readability, we've updated the code to use object destructuring when accessing the prefix property from the otel object.
Changes include:

Updating the metrics.ts file to use object destructuring for the otel object.

This change should make the code in metrics.ts easier to read and maintain.

I Run npm run format as per request.


adding hf-gradio-hackathon page

Could we list this after Trans*Code? I want to put all the workshop days events first.


Fixing tiles in employee page

Targets #

Description

now the alignment of tiles is justified and the margins are also aligned with each other.

Checklist:

[x] I have performed a self-review of my own code.

@nivesh1000  There are a few suggestions that need to be done when you are making the PR.

In Assignees  : Assign it to yourself before assigning to the reviewers.
In Label : Put ready for review label before assigning it to the reviewers.
In Reviewers : Assign it to team-portal-reviewers.
In Targets :  # issue task id should be present.


Netflix Movies and TV Shows

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Netflix Movies and TV Shows
:red_circle: Aim : To understand what content is available in different countries ,Identify similar content by matching text-based features ,Network analysis of Actors / Directors and find interesting insights ,Does Netflix has more focus on TV Shows than movies in recent years?. Perform EDA.
:red_circle: Dataset : https://www.kaggle.com/shivamb/netflix-shows
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.
A Demo Project has been created to guide you about the whole structure of presenting the Project in this repository. Here's the link of the Demo Project - https://github.com/abhisheks008/ML-Crate/tree/main/Project-Demo-Folder

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
Are you a participant of SWOC 2.0?

[ ] YES
[ ]  No

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Hi @ASLManasa , I want to take this issue.

SWASTIKA GUPTA
Swastyy
not sure where it is mentioned.
Country wise analysis for trending shows/binge, more searches of tv shows or movies in netflix by analysing the test data
Yes, I am a participant.

Can you tell me how the score for fixing this issue will be calculated? Thanks.

@Swastyy ok Assigning to you.  Try completing within 3 days. You can check the kaggle code section. You will get an idea.

Is this you?

Is this you? @Swastyy
Yes, where did you get it?

If you have joined the ml-crate channel created by SWOC team then I think you must have knew it.

@Swastyy what's the update here for this project?

Full name : Sankalp Srivastava
GitHub Profile Link : www.github.com/sankalp-srivastava
Participant ID : 857
Approach for this Project : A detailed EDA and creating different models and comparing them.
Are you a participant of SWOC 2.0?

[x] YES
[ ] NO

@sankalp-srivastava go ahead!


Folder structure adapted for Carthage

:tophat: What? Why?

Updating folder Structure for RRC to find its dependencies correctly
Fixing a crash when calling numberOfObjectsAt: without cached objects

:ghost: GIF

:+1:

:+1:


feat(EMI-1956): display limited time offer signal

The type of this PR is: feature

This PR solves EMI-1956
Description
In draft as I have not enabled showActivePartnerOffer in every place on the list yet, otherwise it's good to review.
This displays the "Limited-Time Offer" badge along with the countdown timer and price with discount to users who have an active partner offer on an artwork in these places:

[x] Gallery detail page
[x] Artist detail page
[x] Recently Viewed Rail (all pages, including home feed and bottom of artwork detail page)
[x] Home/Trending Now (rail)
[x] Home/New works for you (rail)
[x] Home/Curator’s Picks: Emerging Artists (rail)
[x] Profile/Saves List (page)
[x] Artwork detail page
[ ] Nav/Trending Now (page)
[ ] Nav/New this week (page)
[ ] Nav/Curator’s Picks: Emerging Artists (page)
[ ] Nav/Curator’s Picks: Blue Chip Artists (page)
[ ] Search Results/artworks (page)

Either as part of this PR or the next we can add tracking from artsy/cohesion#516 to these events. Some events on the artwork page are using the Deprecated Schema and will need to be updated to use the new event values: ClickedBid, ClickedContactGallery.


version: fix parsing of URLs ending with version

https://github.com/lihaoyi/Ammonite/releases/download/0.7.4/0.7.4
was parsing as "0.7" not "0.7.4" since ".4" was being treated as a
legitimate file extension. At minimum, let's insist that a valid file
extension include at least one letter to avoid lopping off part of the
correct version string.
CC @DomT4 @UniqMartin

And here's another one: https://github.com/Homebrew/homebrew-core/blob/master/Formula/datomic.rb#L4-L5

👍 but add a test to test_versions for these cases.

@MikeMcQuaid haha it was already in there!
    # URL with no extension
    # e.g. https://waf.io/waf-1.8.12
    # e.g. https://codeload.github.com/gsamokovarov/jump/tar.gz/v0.7.1
    m = /[-v]((?:\d+\.)*\d+)$/.match(spec_s)

Looks like the "correct" fix is
m = /[-v]?((?:\d+\.)*\d+)$/.match(spec_s)

@MikeMcQuaid PR refreshed.

🚢

@MikeMcQuaid any idea what's going on here?
$ git push
Counting objects: 7, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 951 bytes | 0 bytes/s, done.
Total 7 (delta 5), reused 0 (delta 0)
remote: Resolving deltas: 100% (5/5), completed with 5 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Required status check "default" is expected
To https://github.com/Homebrew/brew
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/Homebrew/brew'

Oh, Mike banned pushing. You'll need to literally merge it.

Huh? Why?

Are you saying we have to interact with the brew repo via the web browser to merge anything? Or is there some way this can be done from CLI? Please tell me it's the latter, or I must be in Twilight zone.

Mostly to make sure everything goes through a successful PR (and its various tests) first. There's no way to communicate to GitHub that a PR has passed & is safe to merge via the brew pull mechanism.

Possibly my fault. I accidentally nicked his PR by pushing directly 😄.

@DomT4 sounds like a slight overreaction :scream:

I loathe merge commits with a sort of unholy passion, and they're the only way to preserve GPG signing of commits from the GitHub interface, so I'm not in love with the block, but I understand the reasoning for it & theoretically it'll prevent breakage from creeping in more than the current system has.

@DomT4 hub merge command works fine so I've stopped caring now. But I agree merge commits are pretty much awful.

hub merge or I believe just doing a merge on the command-line. It needs to ensure that the SHA1 that was tested is the one that's merged.
As @DomT4 says: they preserve GPG and they provide a pointer to the PR the commit came from (which brew pull loses with multi-commit PRs which most are in Homebrew/brew nowadays).

@MikeMcQuaid the biggest problem is timestamps don't get updated unless you manually bump them, so just about everything ends up with dates older than when they actually were committed and the history becomes unintelligible in terms of actual chronological order of commits let alone when they were actually merged but :see_no_evil: as long as it works from CLI.


chore(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cos/ibm (source)
module
minor
8.3.0 -> 8.4.0

terraform-ibm-modules/key-protect/ibm (source)
module
patch
v2.7.1 -> v2.7.2

terraform-ibm-modules/resource-group/ibm (source)
module
patch
1.1.5 -> 1.1.6

Release Notes

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v8.4.0
Compare Source
Features

removed kms_region from the bucket DA inputs as its now programmatically determined.* The existing_kms_instance_guid input variable has been replaced by the existing_kms_instance_crn in the both bucket DA solutiona. The CRN should now be passed to it instead of the GUID. (#642) (9748e04)

v8.3.3
Compare Source
Bug Fixes

remove upper limit for required terraform version (#639) (ef51c60)

v8.3.2
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.13.2 (#637) (6425d8b)

v8.3.1
Compare Source
Bug Fixes

fixed bug in validation of resource_keys roles. It was incorrectly checking for None an now it correctly checks for NONE (#632) (5473ee2)

terraform-ibm-modules/terraform-ibm-key-protect (terraform-ibm-modules/key-protect/ibm)
v2.7.2
Compare Source
Bug Fixes

remove upper limit for required terraform version (#583) (7b78e3b)

terraform-ibm-modules/terraform-ibm-resource-group (terraform-ibm-modules/resource-group/ibm)
v1.1.6
Compare Source
Bug Fixes

remove upper limit for required terraform version (#624) (0c4a55a)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.22.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[T3A2][T11-A2]JoshuaChing

Ready for review

Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.


Add grammar fix

Not much to say about this :-)

Could you sign our CLA so I can merge your PR?

@danielquinn 🙂

Closing due to inactivity on signing the CLA.


clarifications about usable options

Clarifications about which options can be used.
Something I and others have been confused about.

Thanks, I took your changes and added more.  Thanks for forcing me to sit down and make sure people realize how to use the directive!


Unable to use can.Map in place of can.Component helper

I want to define a bunch of default helpers into a can.Map so that i can include them into my components without the need to rewrite them again in different components. I would just like to include the map into the component like this.
can.Component.extend({
    ...
    helpers: new can.Map({...})
})

This would be a great feature and if already available, please guide me. Thankx.

@wishabhilash Imo, it doesn't make sense to use a Map.  After all, we only have can.Map to provide observability.  Your helpers "objects" don't need to be observable.
I'm going to close this b/c I don't understand the use case.  If you fell like this is a mistake, please try to explain more.


Add version

In order to better resolve issues, I should have a --version flag to provide the version.

Fixed in https://github.com/duo-labs/cloudmapper/commit/3f8eb9aa0f7e6a070336cbba17ea20b2bbb9d1f3


Revamp BaseSingleAxisSubsystem

Looks very clean, do we want to go ahead with renaming the [class]2 to just [class] before merge or are we waiting until climbers can be converted?

I would convert and check for regressions before deleting existing code


Print options update

Currently as exploration is being performed in other projects, this is a combined list of absolutes & options for users of Pelican to modify the visibility of elements in a printout of any page (with Pelican elements):
Absolutes

Skip to Main
Sidebar
Topbar
Nav elements (Breadcrumbs)
Footer elements
Popover
Table of Contents
Fixed Position items

Optional

Specific buttons
Pagination

Other brainstorming ideas to experiment with:

Having multiple print style files for toggling variations (similar to component file naming)
Placing all elements onto one index layer, and making that layer invisible when printing
Creating a global class style that is manually placed on elements to hide them

Questions:
What should be done with visible modals?

Going to take comments and separate into new files to have different demo able print layouts to showcase.


Robust ad-hoc exec

No test cases, local terminology, parameter, CQL version parameter, silent success(fail), debug

This is actually related to the Atom CQL execution. I've opened an issue cqfamework/atom_cql_support.


Ansi fix

Not sure if this is potentially breaking to other projects, as I haven't delve into the project very much. It solves the issue of the HTML getting overridden by Highlight.js in solveit, but not sure if it might have a deeper impact on other projects using execnb, or if there's a better solution happy to explore that too :)

Could we just do return f"
{txt}
" ?

Could we just do return f"
{txt}\
" ?

Not when the output type is from a stream, otherwise normal code blocks don't get highlighted - and it looks like both tracebacks and normal outputs are piped into stdout stream outputs.
There is the output_type='error' dict which could be useful to differentiate the two, but currently isn't being used in the ansi_renderer. But yeh, substring usage doesn't feel very good for this, definitely feel like there is a better way.


How to detect android toast permission

When android user close app notice permission, toast can not display.
Is there anyway to detect toast permission?

I haven't tried this plugin, but maybe this'll work for you?
https://www.npmjs.com/package/cordova-plugin-android-permissions

What is a Toast permission exactly?


Space before parenthesis

TypeScript Version:  2.4.0 / nightly (2.5.0-dev.201xxxxx)
Code
setting the property
"javascript.format.insertSpaceBeforeFunctionParenthesis": false

Expected behavior:
I expect the auto formatter to not insert the space before function parenthesis.
Actual behavior:
The formatter continues to insert space on formatting.
Probably linked to https://github.com/Microsoft/vscode/pull/21712

Could you provide a code repro as well?

It's a general behaviour of the javascript formatter, i think that the bug should be independent by the code base. If you think it's useful my code base relies mostly on an object literal notation, e.g.

var object = {
  method1: function(){
    //code here
  },
  method2: function(){
   //code here
  }
}

Seems like this was a configuration problem, not a bug


Add airport codes to places

Implement #127

I moved "lax" from adjectives to places (airports). If you google "lax", all links on the first page are about the airport.

nice! this looks great Ilya.


Test autmoated build from hub.docker

Status: Downloaded newer image for dmitvan/zabbix-screens-generator:latest
docker: Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "exec: "/app/entrypoint.sh": permission denied": unknown.


Can't set hyperparameter for CTModel

TypeError: 'alpha' is an invalid keyword argument for this function

Oh, CTModel doesn't have argument alpha, but has smoothing_alpha.
The documentation and doc string of CTModel seems to have a typo. I will fix it in the next update.
Thank you for your reporting.

The typo was fixed in version 0.9.1


docs: update team and contributors list

Signed-off-by: Ivan Donchev<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I'll merge it as part of the release process


feat(dotnet): add support for Manifest

Add support for manifest
Add more unit tests
Update Runtime package reference

There isn't currently a way to access vars from the host, we could add the ability but I don't have any work planned for that yet.

Will open another PR in the new repo


Grab average color?

It would be great if the blurhash could somehow be easily converted to the average RGB color of the image. That way, on SSR, the placeholder can already get that color before the blurhash can run.

@omahlama ah great! You wouldn't happen to have an easy JS version already done would you? :-)

Found it I think https://github.com/mad-gooze/fast-blurhash/blob/main/index.js#L57-L60

Ok I asked the library author to maybe export a function for it. https://github.com/mad-gooze/fast-blurhash/issues/3


Rotate event colors instead of picking a random one

Rotate event colors instead of picking a random one: I think this is more robust since it reduces the chances of having two similar colors close to each other.

Can you also please change the readme preview image to this ?

Can you also please change the readme preview image to this ? (it's inside doc folder)

Said and done!


chore: Prepare 3.3.0 release

Detail

Prepare 3.3.0 release
Not to be merged until the required PRs are merged:

#2403

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 43abe86f31355fcda99bea2be41f9b70c18b8b47
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 43abe86f31355fcda99bea2be41f9b70c18b8b47
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 9ef65fce574d784863862010aa6dcafd9a88a292
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 9ef65fce574d784863862010aa6dcafd9a88a292
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 0fc315bf74bcb1bcd6283683c4d3c914d95e1679
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 0fc315bf74bcb1bcd6283683c4d3c914d95e1679
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


[pgadmin4] Add example enable LDAP integration

What this PR does / why we need it:
Add an example to show to properly set up PGAdmin with an AD domain
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [pgadmin4])

@manueliglesiasgarcia can you let me know if this is something that would do:
https://github.com/rowanruseler/helm-charts/pull/83


Added Nine men's morris

Submitting this PR means you have:

[x] searched the readme file and searched the open pull requests (no duplicates please)
[x] and will follow the desired format
[x] used image links that resolve correctly, are appropriately sized, and are served over HTTPS

The board consists of a grid with twenty-four intersections or points. Each player has nine pieces, or "men", usually coloured black and white. Players try to form 'mills'—three of their own men lined horizontally or vertically—allowing a player to remove an opponent's man from the game. A player wins by reducing the opponent to two pieces (where they could no longer form mills and thus be unable to win), or by leaving them without a legal move.
this is for hacktoberfest #176

@edm00se sure thing, there, just fixed it.


Fixed linebreak in environments-virtual-machines.md

Fixed linebreak, so point 7 is not inside Note section
Live link: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/environments-virtual-machines?view=azure-devops#virtual-machine-resource-creation

@michha : Thanks for your contribution! The author(s) have been notified to review your proposed change.


CASMCMS-6989: Rename compute configuration to csm configuration

Description
Renames a section on compute configuration since the configuration will now also include application nodes.
Checklist Before Merging

[X] If I added any command snippets, the steps they belong to follow the prompt conventions (see [example][1]).
[X] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in [Cray-HPE][2].
[X] My commits or Pull-Request Title contain my JIRA information, or I don't have a JIRA.

These changes are needed for 1.2.6.  Should this be backported to the 1.2 branch?

Would like to see this change pulled into the main branch PR:
https://github.com/Cray-HPE/docs-csm/pull/1950


Allow users to specify types of literals to obfuscate

Fixes #72.

Also please add a test for using different options not just all

Found a bug in numerical literal obfuscation, pushing so other eyes can be on it

Closed in favor of #111.


WIP: Release 0.6.0

Lots of yummy goodness here.  Getting basecli ready for prime-time in the testnet.
Outstanding issues:
#109 (DONE!)
#114 (fix docs)
#106 (need to review paul's changes and integrate them)
Check out the Changelog as well.  And add anything I missed...
Especially check out the new tests/cli dir, which is in make test by default.

I'll add https://github.com/tendermint/basecoin/issues/117 in too, since it's also breaking

Yeah, I think #117 needs a bit more discussion first.
Don't worry, there will be more breaking changes coming ;)

Cool.  I think it is just docs and the height fix that need doing.  Good luck!

Docs are done.  Bucky, just up to you with the height-restart fix


[Azure Monitor OpenTelemetry] Fix issues with types

Optional properties in InstrumentationOptions  allow customer to only specify settings they are interested
Typo in tracer provider method

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-monitor-opentelemetry


docs(): update nest-commander logo

The logo in the readme is not displayed (see screenshot):

The CI failed 😲, very strange 🤔
https://github.com/jmcdo29/ogma/actions/runs/3503050719/jobs/5867831688


Just fixed a couple of typos in error messages

Thanks @jonschlinkert, can you update the tests with these changes as well please?


Fix Taiwan Traditional Chinese String

Replace the string from "設定快捷鍵" to "設定快速鍵".
What's this PR do?

[x] Add new routes for user
[x] Add instruction for using docker-compose

What are the relevant Git tickets?
// Put in link to Git Issue
Screenshots (if appropriate)
// Use Licecap to share a screencast gif.
Any background context you want to provide? (if appropriate)

Is there a blog post?
Does the knowledge base need an update?
Does this add new dependencies which need to be added to?

@p-z-l can you help me review this?

Looks good as far as I can tell

Let me check that.

Thanks @pan93412 @p-z-l


Two build issues on Mac M1 chip

Bug Report

On MacOS, if coreutils/gnubin is installed, the uname -p will show arm64, neither aarch64 nor arm, causing SSE to be enabled. (checked here)

/opt/homebrew/opt/coreutils/libexec/gnubin/uname -p
# output arm64

Note that this might be common if someone is also developing kubernetes, since kubernetes build guide requires coreutils to be installed.

The build guide mentioned llvm and clang should be installed. What's the correct way of installing them on M1 MacOS? I installed using Homebrew but the Homebrew version causes failed openssl build (See [this issue](https://github.com/openssl/openssl/issues/10709, basically, the Homebrew version llvm cannot recognize the -c parameter of ranlib).

ps. I can build successfully after uninstalling the homebrew version llvm.
...
  install libcrypto.a -> /Users/dongjin/code/tikv/target/debug/build/openssl-sys-8948495dd3a11ccf/out/openssl-build/install/lib/libcrypto.a
  make[1]: Leaving directory '/Users/dongjin/code/tikv/target/debug/build/openssl-sys-8948495dd3a11ccf/out/openssl-build/build/src'

  --- stderr
  ar: warning: creating apps/libapps.a
  ranlib: error: Invalid option: '-c'
  ar: warning: creating libssl.a
  ranlib: error: Invalid option: '-c'
  ar: warning: creating libcrypto.a
  ranlib: error: Invalid option: '-c'
  ranlib: error: Invalid option: '-c'
  make[1]: *** [Makefile:327: install_dev] Error 1
  thread 'main' panicked at '

  Error installing OpenSSL:
      Command: "make" "install_dev"
      Exit status: exit status: 2

      ', /Users/dongjin/.cargo/registry/src/github.com-1ecc6299db9ec823/openssl-src-111.15.0+1.1.1k/src/lib.rs:471:13
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
make: *** [Makefile:154: build] Error 101

What version of TiKV are you using?

Build from source (master)
What operating system and CPU are you using?

Mac OS Monterey, M1.
Steps to reproduce

What did you expect?
What did happened?

I also have llvm installed on my Mac and I can successfully build TiKV from source. Perhaps you can try not including llvm binaries in the PATH.

Good news is that after https://github.com/tikv/grpc-rs/pull/558, it's not required to install llvm on macos anymore. It may be landed on master days later. You still need llvm to build old releases/branches though.


Apply for reviewer permission

I have contributed many features to the project, I am familiar with the project, and hope to make more contributions to the project.
Currently, there are not enough code reviewers in the project, resulting in many PRs not being reviewed. Therefore, I applied to become a reviewer to help the project develop better.
Submit PR：https://github.com/Project-HAMi/HAMi/pulls?q=is%3Apr+author%3Alengrongfu+is%3Aclosed
Submit issue：https://github.com/Project-HAMi/HAMi/issues/created_by/lengrongfu
cc @wawa0210 @archlitchi

Thank you very much for your contributions to HAMi, including PR, Issue, and code review
Fully meet the requirements of the HAMi community for reviewers https://github.com/Project-HAMi/community/blob/main/CONTRIBUTOR-LADDER.md#reviewer
It is a great honor to invite you to join the reviewer family
At present, HAMi robot CI is not fully ready. After the robot ci is built, the entire reviewer process should be automatically triggered. Currently, some manual work is required


Containerd version reported as unknown when listing nodes in cluster

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Install k3s cluster
In Rancher UI, create a custom cluster
Apply the YAML on the k3s cluster to import the cluster
In Rancher UI, go to the list of nodes

Result:
The nodes are listed with Version "containerd://1.2.3+unknown"
Other details that may be helpful:

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
Rancher v2.1.6
Installation option (single install/HA):
single install

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Imported
Machine type (cloud/VM/metal) and specifications (CPU/memory):
AWS
Kubernetes version (use kubectl version):

v1.13.3-k3s6

Docker version (use docker version):

(paste the output here)

According to @ibuildthecloud, this is likely a k3s issue and can be tracked here: https://github.com/rancher/k3s/issues/159

This should be extended to the Node view:

Wasn't this already fixed for 2.2?

It's fixed in the Nodes view, not in the Node view (or Node detail view)

Should label be Docker Version:"? Should it be changed to just Version: or Runtime Version:? I don't think containerd is considered a Docker version.

Yep, should probably move to what k8s uses:
"containerRuntimeVersion": "docker://18.9.2",

Or something along that displays nicely in the UI

Version containing unknown is tracked in https://github.com/rancher/k3s/issues/159, UI in node list view is fixed, node detail view can be tracked in https://github.com/rancher/rancher/issues/21099


2.4 compatible issue

This gem is really helpful, i just want to know that is this gem is compatible with spree 2.4 because i am facing the issue when is start my bundler
Bundler could not find compatible versions for gem "spree":
In snapshot (Gemfile.lock):
spree (= 2.4.3.beta)
In Gemfile:
spree_subscriptions (>= 0) ruby depends on
spree (~> 2.4.4) ruby
spree (>= 0) ruby

Thanks

hi @Qubaish, thanks for reporting this issue. It seems like you are using the 2.4.3.beta version of spree. I think that updating the spree gem it will allow to use this extension. Try running:
bundle update --source spree

Hi thanks for the quick response, i try to run this command but it also gives error
Bundler could not find compatible versions for gem "spree_core":
In snapshot (Gemfile.lock):
spree_core (= 2.4.3.beta)
In Gemfile:
spree_core (~> 2.4.0) ruby
spree (>= 0) ruby depends on
  spree_core (= 2.4.8.beta) ruby

Here is my gem file
gem 'spree', github: 'spree/spree', branch: '2-4-stable'
gem 'spree_auth_devise', github: 'spree/spree_auth_devise', branch: '2-4-stable'
gem 'spree_gateway', github: 'spree/spree_gateway', branch: '2-4-stable'
gem 'spree_paypal_express', github: 'spree-contrib/better_spree_paypal_express'
gem 'spree_editor', github: 'spree-contrib/spree_editor', branch: '2-4-stable'
gem 'spree_subscriptions', github: 'nebulab/spree-subscriptions', branch: '2-4-stable'
Thanks

You should look in your Gemfile.lock and understand which gem is locking spree_core gem to that particular version (2.4.3)

I appreciate your help, spree paypal caused that problem now i solved it.
Thanks

@Qubaish happy you solved! :beers:


Add Pause/Resume keywords

Should be possible to pause a started video recording during test execution and to resume it at a later time.

Implemented in https://github.com/mihaiparvu/ScreenCapLibrary/commit/d2793f1e5343123b92ce492470db5e66c69e47f9


Restructure how functions are handled in the IR and codegen to eliminate function inlining

Once #1824 goes in, we will have the option to support recursive functions. But, in order to do so, we will need to make changes to the IR and codegen.
Blocked by:

[x] #1824

The IR would like to organise a program into a tree.  Instructions gathered into blocks, gathered into functions, gathered into modules.  So having distinct functions and all their meta available to IR would be beneficial structurally and analytically.
To the best of my knowledge, the debugger is mostly interested in attributing spans to instructions, but being able to resolve full paths of symbols to instructions is important to set breakpoints (or inspect memory values).  Without the absolute naming of functions this becomes impossible.  @Dentosal knows more.
Originally posted by @otrho in https://github.com/FuelLabs/sway/issues/1557#issuecomment-1127188087

The hardest part of removing inlining (and supporting recursion) is supporting actual function calls.  I can't find an issue for this though at the moment.
Function calls are typically done with a call/ret mechanism, where ret is essentially a 'pop an arbitrary value off the stack and jump to it'.
The Fuel VM doesn't support arbitrary jumps so to get around this the current proposal is to use a 'jump table'.  Each 'call' would include a token describing where the function should 'return' to which would be looked up in a static local table.
This may end up less efficient as popular functions would have a very large return table.  But it could also prove more efficient in that CPS call chains could be generated and tail call optimisations are pretty much built in.
Another downside to using a return table is that library code can never be precompiled and included verbatim (i.e., linked) with user code as the return table for a library function depends on where it is called from, which varies per program of course.

Just jotting down some things here to make sure I understand the full picture correctly:
Inlining has been used in our conversations to mean two different things:

Inlining the function body in the FunctionApplication AST node itself. This is not what the term "inlining" is usually used for I think.
Inlining in IR (inliner pass) where the function body is actually moved and replaces the call instruction in IR. (call here is not a contract call... the contract call instruction in IR is contract_call and, of course, no inlining happens there).

We want to avoid (1) by creating a declaration engine that avoids making copies of the function body everywhere it is called. This would be a cleaner and lighter design and enables a much easier solution for the trait constraints problem.
We also want to be more flexible with (2) and not have to inline everything (inlining in the traditional sense). Some functions will still be worth inlining (some heuristic can be introduced here) and we should probably have an #[always_inline] annotation at some point that a user can apply to force inlining. Introducing this flexibility requires all the stuff that Toby is talking about above.
Am I getting this right?

We have the call instruction in the IR now, which gets lowered to jumps in the ASM. Functions are now inlined in a classical term, as an optimization pass.


Feature request

@SorsOps  @josephnhtam Are you planning to add new features?

Hi @RahulKumar1119
Currently, I am focusing on live-streaming-server-net.
I may consider integrating it to add a live video streaming feature, but this will not happen soon.

@josephnhtam If you have time, please add a feature similar to YouTube Shorts.