Consultation on the preprocessing of DFEW datasets

Hello, I am very interested in your work, but I have some questions about the comments in dfew. py in your pre-processing file because you wrote # org: original frames in jpg_256 in line 13 of the comments, not temporally aligned in jpg_224_16f， But when I applied for the dataset again, I couldn't find the file in the jpg_256 folder and only found jpg_224. I would like to ask if you used the original frame folder jpg_224 or the video folder?

I hope you can answer my question, thank you very much for your help.

Hi, soory for the confusion. It should be clarified that the real facial image resolution in jpg_224 is 256x256. Thus, I rename this folder and keep the content unchanged.
---- Replied Message ----
From @.> Date 10/13/2024 10:33 To @.> Cc @.> Subject Re: [sunlicai/MAE-DFER] Consultation on the preprocessing of DFEW datasets (Issue #17)
I hope you can answer my question, thank you very much for your help.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.>

OK，i get it，thanks for your help.


Clarified the apiGroup identified by empty string

Noted this where the relevance of api group is introduced, and
corrected the reference to what the empty string means ("core" api
group, which is the terminology used in the page that introduces api
group, rather than the old text "default").

This change is

CC @liggitt
CC Marc Boorshtein

LGTM

lgtm

LGTM

@erictune @devin-donnelly is there anything I need to do now in order to move this forward?

Just the one comment. Sorry for the delay.

@devin-donnelly please see the latest revision.


Disable Kext Signing on Yosemite

I had to disable kext signing on Yosemite. It didn't load modified Kext otherwise.
to do it, execute:
sudo nvram boot-args=kext-dev-mode=1

Thanks for the tip, going to execute this command line on OS version starting from Yosemite.

Well, in fact this can be executed on previous macOS versions, I'm going to run it by default to limit potential errors. 😄


To have assigning task option for Glossary.

Is your feature request related to a problem? Please describe.
UI
Describe the solution you'd like
Currently, tasks can be assigned at table level. Since we also need to collaborate around glossary, therefore, we need an option for assigning tasks at glossary level other than the reviewer option.
available option at table level only.

Duplicated of #12166


added podle.audio

resolves #113

There’s no need for such complicated way of inserting icon via ::before, I did it for Paper Planes only because of box-shadow. It’s much easier to use multiple backgrounds for that, just like we already did in most of the cases:
	background:
		url(../images/pokedex.png) 50% 50% / 50% auto no-repeat,
		linear-gradient(to right, #78C850 50%, #A040A0 50%)
		#78C850;


gitea isn't being updated

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
This conda-forge package hasn't received updates since the only version 1.2 was released in 2017:
https://anaconda.org/conda-forge/gitea/files
The current release of Gitea is 1.21.4:
https://github.com/go-gitea/gitea/releases
There are no automatic bot PRs to update the versions
Installed packages
N/A

Environment info
N/A

It's downloading pre-built binaries:
https://github.com/conda-forge/gitea-feedstock/blob/876dc8203ff7ae4445a6228fa22acd18d6bc70a5/recipe/meta.yaml#L12-L17
so I presume this pre-dates the conda-forge standard of building from source?
It's a Go package and conda-forge support for Go has improved a lot, so maybe it's not too difficult to do this properly....

so I presume this pre-dates the conda-forge standard of building from source?

Very likely

It's a Go package and conda-forge support for Go has improved a lot, so maybe it's not too difficult to do this properly....

If you can give it a go, please send a PR. I don't know how active the current maintainer is and/or if they are interested in fixing this package.

I've managed to get a build for MacOS and Linux only: https://github.com/conda-forge/gitea-feedstock/pull/4


option to disable normal dark vignette in caves

just a bit weird seeing my screen all of a sudden get slightly dark in caves when I pass the damage vignette min threshold or reach full health

would having a toggle for damage vignette (separate from normal vignette) work for you?

yeah that works


Required Information about peripheral files.

Let me put it straight. Can I delete the following files?

.travis.yml
appveyor.yml
.istanbul.yml

Can someone please give me a brief of the effects If I remove these files?
I have little idea for .istanbul.yml that if I remove this file then .spec files will start showing in the coverage report but I don't have any idea where .travis.yml and appveyor.yml are used.

travis.yml and appveyor are files for Continuous Integration (CI for short)
the purpose of these files is to automate build process and deployment on the fly.
they are required for https://travis-ci.org/ and https://www.appveyor.com/
they shouldn't affect the project if you remove them but you should learn about it you can check this course
https://app.pluralsight.com/library/courses/javascript-development-environment/table-of-contents by @coryhouse
Testing and Continuous Integration module to learn more about CI

What @Ramadanko said and the Istanbul yaml file is for deciding which files to collect code coverage from.
Hope that clears things up for you.


Misleading error messages for misnamed formula class

I'm trying to write my own first formula, so it's entirely possible I'm doing something wrong here, but the error I'm getting from brew is definitely confusing.
I'm running an updated homebrew:
Flos-Mac-mini:~ flo$ brew update
Already up-to-date.

I'm copying my formula to the right place:
Flos-Mac-mini:~ flo$ cp qt5-webkit/qt5-webkit.rb /usr/local/Library/Formula/
Flos-Mac-mini:~ flo$

but installing it fails - it seems the formula gets found, but then brew decides it didn't find it anyways? :wink:
Flos-Mac-mini:~ flo$ brew install --debug --verbose qt5-webkit
/usr/local/Library/brew.rb (Formulary::FormulaLoader): loading /usr/local/Library/Taps/homebrew/homebrew-core/Formula/qt5-webkit.rb
Error: No available formula with the name "qt5-webkit"
==> Searching for similarly named formulae...
/usr/local/Library/brew.rb (Formulary::FormulaLoader): loading /usr/local/Library/Taps/homebrew/homebrew-core/Formula/qt5-webkit.rb
This similarly named formula was found:
qt5-webkit
To install it, run:
  brew install qt5-webkit
==> Searching taps...
Error: No formulae found in taps.

My formula:
class Qt5WebKit < Formula
  desc "Version 5 of the Qt framework - QtWebKit module"
  homepage "https://www.qt.io/"
  url "http://download.qt.io/community_releases/5.6/5.6.0/qtwebkit-opensource-src-5.6.0.tar.xz"
  mirror "https://www.mirrorservice.org/sites/download.qt-project.org/community_releases/5.6/5.6.0/qtwebkit-opensource-src-5.6.0.tar.xz"
  sha256 "9ca72373841f3a868a7bcc696956cdb0ad7f5e678c693659f6f0b919fdd16dfe"

  head "https://code.qt.io/qt/qtwebkit.git", :branch => "5.6", :shallow => false

  # OS X 10.7 Lion is still supported in Qt 5.5, but is no longer a reference
  # configuration and thus untested in practice. Builds on OS X 10.7 have been
  # reported to fail: <https://github.com/Homebrew/homebrew/issues/45284>.
  depends_on :macos => :mountain_lion

  depends_on "qt5"
  depends_on :xcode => :build

  def install
    system "qmake"
    system "make"
    system "make", "INSTALL_ROOT=#{prefix}" "install"
  end

  test do
    (testpath/"hello.pro").write <<-EOS.undent
      QT       += core webkit
      QT       -= gui
      TARGET = hello
      CONFIG   += console
      CONFIG   -= app_bundle
      TEMPLATE = app
      SOURCES += main.cpp
    EOS

    (testpath/"main.cpp").write <<-EOS.undent
      #include <QCoreApplication>
      #include <QDebug>
      #include <QWebView>

      int main(int argc, char *argv[])
      {
      }
    EOS

    system bin/"qmake", testpath/"hello.pro"
    system "make"
    assert File.exist?("hello")
    assert File.exist?("main.o")
  end
end

Hi Florian,
On 4/13/16 10:00 AM, Florian Bruhin wrote:

I'm trying to write my own first formula, so it's entirely possible
I'm doing something wrong here, but the error I'm getting from brew is
definitely confusing.
|[...snip...] |
but installing it fails - it seems the formula gets found, but then
brew decides it didn't find it anyways? :wink:
|Flos-Mac-mini:~ flo$ brew install --debug --verbose qt5-webkit
/usr/local/Library/brew.rb (Formulary::FormulaLoader): loading
/usr/local/Library/Taps/homebrew/homebrew-core/Formula/qt5-webkit.rb
Error: No available formula with the name "qt5-webkit" ==> Searching
for similarly named formulae... /usr/local/Library/brew.rb
(Formulary::FormulaLoader): loading
/usr/local/Library/Taps/homebrew/homebrew-core/Formula/qt5-webkit.rb
This similarly named formula was found: qt5-webkit To install it, run:
brew install qt5-webkit ==> Searching taps... Error: No formulae found
in taps. |
My formula:
class  Qt5WebKit< Formula
desc"Version 5 of the Qt framework - QtWebKit module"
homepage"https://www.qt.io/"
[...snip...]

You're very close. Homebrew is very strict about the class naming
pattern. qt5-webkit needs to become Qt5Webkit, not Qt5WebKit.
Only the first letter and letters immediately following a dash get
capitalized.
The misleading error messages are an issue with brew. We'll try to do
something about that. https://github.com/Homebrew/brew/issues/82
Cheers,
Andrew

What @apjanke pointed out is probably the main issue.

system "make", "INSTALL_ROOT=#{prefix}" "install"

There's also a missing comma in this line. Might be another reason why the formula file is found, but fails to load. You can check with brew readall for syntax errors in formulae. Running brew style --strict --online qt5-webkit is also a good idea to check that the formula is in a decent shape.

Thanks a lot for the quick help and the helpful hints! :+1:
@UniqMartin getting a bit off-topic here, but do you think I should submit this formula after it's polished and working, or keep it for myself? After all, there was an official source release for QtWebKit with Qt 5.6, and there are chances it'll be continued to be maintained by the community in the future.

[…] do you think I should submit this formula after it's polished and working, or keep it for myself?

I've seen some demand for this, so it would be nice of you to put it in a tap where others can find it. I'm not sure if we want to make that an official formula, though, as I believe our stance is that QtWebKit is basically broken and insecure, and it should die sooner than later. Including it could seem like an endorsement we don't want to commit to. @DomT4 and @mikemcquaid also might have an opinion.

Including it could seem like an endorsement we don't want to commit to. @DomT4 and @mikemcquaid also might have an opinion.

Yeh, agreed.

as I believe our stance is that QtWebKit is basically broken and insecure, and it should die sooner than later. Including it could seem like an endorsement we don't want to commit to.

:+1: from me on that as well. A tap would be useful though, I agree.

Is the community QtWebkit using newer versions and e.g. accepting security updates? If so, we'd consider accepting it. Otherwise, as @UniqMartin said.
Closing this as it's not a Homebrew issue but happy to help further if you have questions.

Is the community QtWebkit using newer versions and e.g. accepting security updates? If so, we'd consider accepting it.

It's still heavily work in progress, but I think that's the goal - having a QtWebKit based on an updated upstream WebKit.

Closing this as it's not a Homebrew issue

How isn't it? Surely Homebrew could/should tell me something more useful than "qt5-webkit was not found, but qt5-webkit was found instead, try running the command you did just run"? :wink:

but happy to help further if you have questions

Thank you and everyone for being so open and helpful, I really appreciate it! :+1:

Closing this as it's not a Homebrew issue

How isn't it? Surely Homebrew could/should tell me something more useful than "qt5-webkit was not found, but qt5-webkit was found instead, try running the command you did just run"? :wink:

You can find my attempt to improve the error message for this case in PR #101. Feedback welcome!


Highlight clicked element in multi bar chart

I have attached a event handler to a multi bar chart that does something when a bar is clicked.
Is there a way to highlight/change the color of the bar that is clicked ? Just like it happens when we hover over it. Any help is appreciated.
Thanks

I think you're looking for the barColor nvd3 attribute, but it is not exposed in angularjs-nvd3 directive yet.
look at this branch https://github.com/worldline/angularjs-nvd3-directives/tree/feature/addBarColorToMultiBarChart


MyWebHistory | browserhistory.py and main.py

browserhistory.py
Line 148, creating a backup of history file
I would recommend removing the if statement. I didn't completely debug it, but I can never get new history out of the plugin unless this line is removed.
main.py
Line 35: if qs[0] == 'vsc':
I would remove this because it generates a error in the error.log for index out of range, and don't get exact line error from logging module.
would add Log.error(traceback.format_exc())
under line 69
say something like the below to evaluate first
if 'vsc' in qs:

Thanks for your using and response, please feel free to commit a PR


Ho to deal with complex packaging and non-cli applications

Hi,
just discovered jrun, very cool!
I wonder if there is support (or it's planned) for cases more complex than just running the main class in a jar. For instance, I have desktop applications that need to install config and data directories, I'd like to manage both the case of shared config directories and user-specific directories. Should jrun deal with it, or is there some other library that I should use in my application?
Moreover, I would be interested in Maven projects that are not executables, but, for instance, provide a .war file and a script to install it on your application server (eg, Tomcat), and possibly linking dependencies in .m2.

@marco-brandizi wrote:

I wonder if there is support (or it's planned) for cases more complex than just running the main class in a jar. For instance, I have desktop applications that need to install config and data directories

There are several different Java application packaging tools intended for end-user application deployment. IMHO, without having exhaustively surveyed all options, the most promising one right now is the JavaFX packager which comes standard with the JDK now. Note that this is a distinct thing from JavaFX the RIA infrastructure and UI toolkit. There is a nice JavaFX Maven plugin maintained @FibreFox which lets you integrate packaging into your Maven builds.
For the ImageJ project, we currently use a custom launcher but maintaining it is difficult, so we are planning to switch to a JavaFX self-contained application, either with or without a bundled JRE/JDK. The configuration for this can be seen in the parent POM we use; see here and here.
Reasons I prefer the JavaFX packager to previously available solutions:

The JavaFX packager is a first-party solution, which is likely to continue being supported, both by Oracle and by the OpenJDK community.
The JavaFX packager tries very hard to work from the CLI on Windows, macOS and Linux platforms, as long as you have the appropriate dev tools installed on the box. This means it is feasible to automate application deployment for all major target platforms, unlike many of the other solutions.
The JavaFX packager is FOSS, unlike many other Java packagers.

That said, there are still pieces missing. For instance, in order to switch ImageJ from its current custom launcher to the JavaFX deployment system, we will need to either: A) enhance the JavaFX native launcher to support the features that the ImageJ launcher supports; or B) create a pure-Java launcher which relaunches the JVM with the appropriate settings depending on CLI flags passed etc. We are planning to do (B) right now, since it is generally useful, and (A) would probably be a big time investment arguing for features upstream etc. In order to accomplish (B), we will first try starting from an existing solution like Apache Commons Launcher.

I'd like to manage both the case of shared config directories and user-specific directories.

Indeed, ImageJ needs this too: we want to support shared/system plugins as well as plugins installed in user space. Perhaps the tool for managing that should be its own shared library. This is an area where I think Java is lacking—people each seem to invent their own solutions along these lines, the Java Preferences API has serious issues, etc.—but the use cases are very heterogeneous so I don't have a good idea on how to improve the situation.

I would be interested in Maven projects that are not executables, but, for instance, provide a .war file and a script to install it on your application server (eg, Tomcat), and possibly linking dependencies in .m2.

This sounds like something where jrun could potentially be helpful. Unfortunately, I have only limited experience with Java application servers, so I'm not familiar with existing deployment solutions for .war files. I do know that historically on the Maven users list there have been a lot of questions about .war deployment—mostly people trying to shoehorn Maven into a tool to do that, and the community pushing back against it.
One easy thing which occurs to me is to add a flag to jrun which does all the environment setup, but does not actually launch the thing at the end. That way, you could feed it a .war endpoint and let it link in all the deps, and then it could echo the cached environment directory to stdout at the end or something. This would let you use jrun as a building block in your own deployment scripts. Would something like that be helpful?
Generally speaking, Java application packaging and deployment is a huge can of worms and I certainly have no plans for jrun to move in that direction. It is intended to be lightweight and painless for launching software components which are already properly deployed to Maven repositories. On the other hand, if you have a specific vision for how the jrun paradigm could be easily adapted to your use cases in a better way than the options I describe above, let's continue the discussion and figure out the best way to proceed!

Moreover, I would be interested in Maven projects that are not executables, but, for instance, provide a .war file and a script to install it on your application server (eg, Tomcat), and possibly linking dependencies in .m2.

This sounds a bit strange, since .war files CAN be executable and are getting called "FAT-WARs", but have to be configured to be (and have to include some webserver like Jetty, Tomcat/TomEE, Spring or other products).
"symlinking" would probably limited to Linux-systems, as Windows users might not be able to (I think this is limited to current NTFS filesystem implementations).
As @ctrueden said, creating "native launchers" is a big mess right now, because there are a lot of ways to do so, but only a few ones which are cross-plattform, and even that isn't the best. With the upcoming JRE/JDK 9 this will be ugly even more, because of the new packaging-concept (which I still fear to use).

Thanks for your replies.
I don't know JavaFX, but I'm not thinking of self-contained big bundles, to be run from the GUI, I need it more often to provide a framework of command line tools, which is composed of core components/commands and additional ones, which can be installed optionally. Both share a number of files (e.g., logging configuration), and hece the ideal pacakge manager should be ablet to unpack the new components, put in place its files (e.g., in /usr/local/my-framework), deal with overlaps, upgrades, etc. More or less like it happens with APT in Debian, Yum, MacPorts etc.
The case of .wars is similar: I'd like an installer to be able to place an application's war onto the app folder of an application server like Tomcat (location to be specified by the installing user). Ideally this should integrate with the above package manager, allowing to install additional shared files (in shared locations) and configure the application running in the .war to point it to such files.

I'm going to close this, since there are no plans to make jrun into a more general Java component package manager, or a non-cli tool.


Add fallback prop to PrismicRichText

Is your feature request related to a problem? Please describe.
Adding a fallback prop to <PrismicRichText> would be helpful to render content when a field's value is empty.
This functionality should mirror <PrismicText>'s fallback prop. See #105 for more details.
Describe the solution you'd like
<PrismicRichText
  field={document.data.richTextField}
  fallback={
Empty content
}
/>

Describe alternatives you've considered
To do this today, one must use isFilled.richText() from @prismicio/helpers in a ternary.

  {prismicH.isFilled.richText(document.data.richTextField) ? (
    <PrismicRichText field={document.data.richTextField} />
  ) : (

Empty content

  )}

This is verbose and requires using a separate library.
Additional context
N/A

Completed in #135.


Doesn't work without npm

Hey,
When i copy paste the build/vue-cookie.js to my own project and include below the vue.js include and try to call this.$cookie or Vue.cookie i get: Undefined get for undefined.
Does this work without npm?

I also have this problem....

What i did is just use tiny-cookie plugin directly. Without this wrapper. Works as a charm!

get, I quit using this plugin. thx

yep, it's broken, I think in the build (the code in there in the source to do the right thing, and properly export)

Try adding this code before your Vue code and after including tiny-cookie's JS :
Vue.cookie = Cookie;
Vue.prototype.$cookie = Cookie;

@alfhen Will this be fixed?

import Vue from 'vue';
import VueCookie from 'vue-cookie';

Vue.use(VueCookie);


odopen URL updates and content reorganization

The odopen:// is not sufficiently documented and in the middle of alternative mechanisms of "Help user sign in".
I put OneDrive launching mechanisms together, and created a specific odopen block with details on how to get the information neeed without CSOM, and adding webTitle and listTitle to avoid getting " - Documents" for every library synchronized with this method.
On the other hand, while it also works, encoding characters is not really needed, so removed the note.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@kaarins PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


[NEX-6555] Make gem compatible with Ruby 3

Makes this fork of smart_listing compatible with Ruby 3. This is based on this example PR in the original repo

@CJStadler that's next on the list!


Fix Cts avc profile level test

Value: MFX_LEVEL_AVC_1:10 MFX_LEVEL_AVC_1b:9
The functions GetLevelLimitByDpbSize(), GetLevelLimitByFrameSize(), GetLevelLimitByMbps(), and GetLevelLimitByMaxBitrate() return the minimum level according to the frame size, FPS and profile. Since the capability of level MFX_LEVEL_AVC_1b is greater than level MFX_LEVEL_AVC_1, the CodecLevel should not be updated in this case.
Cases:
1.android.media.recorder.cts.MediaRecorderTest#testProfileAvcBaselineLevel1 2.android.mediav2.cts.EncoderProfileLevelTest#testValidateProfileLevel [8_c2.intel.avc.encoder_video/avc_128kbps_176x144_15fps_yuv420flexible_2_0-bframes] 3.android.mediav2.cts.EncoderProfileLevelTest#testValidateProfileLevel [10_c2.intel.avc.encoder_video/avc_128kbps_176x144_15fps_yuv420flexible_2_2-bframes]
Tracked-On: OAM-119037

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web  for more details.

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web  for more details. For Binaries: /cactus-absp-or-local/celadon-merge/614


Add a way to access response headers

Is your feature request related to a problem? Please describe.
I want to access response headers because I need to save authorization tokens from server
Describe the solution you'd like
Would be nice if completionHandler of send function return the HTTPURLResponse which exposes the property allHeaderFields
Describe alternatives you've considered
I've wrote a custom URLProtocol to intercept the request and the response with custom logic to add my tokens on keychain

👋
The new version let's you take complete control over how you send and receive your request. Instead of hiding the networking part, the library's core (the whole library in the previous version) only handles selection and decoding. You can find the methods that (I think) you are looking for in https://github.com/maticzav/swift-graphql/blob/main/Sources/SwiftGraphQL/HTTP.swift.
Feel free to reopen this issue or add comments if you need more help 🙂


chore(clerk-js): Add devOrigin environment option to the webpack dev server

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[x] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

Adds a new devOrigin environment option to the clerk-js webpack configuration that allows us to tweak the dev server URL. Practically, this will ensure HMR and the webpack public path are configured correctly for the origin you supply.
Defaults to https://lclclerk.com
Usage:
npm run dev -- --env devOrigin=http://localhost:4000

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Performance Benchmark

... to lock in speed once we have an initial release ready.
https://pytest-benchmark.readthedocs.io/en/latest/

This is not needed.


Replace Grunt with Gulp

Grunt has been replaced with Gulp before (#341), but has been reverted since there was a 'general revert'. This PR brings Gulp back.

Something's wrong with Travis, the push build won't finish. The PR build is successful, so I'll merge this one.


Add feature: Highlight user defined keywords in title and abstract

Feature Request
To help speed up the review process it would be very helpful if a user-defined set of keywords can be used to highlight text in the title and abstract, see image for example. Additionally, if the paper keywords can also be shown that would also be helpful.

Thank you for your suggestion! The implementation is provided by @tomseinen in https://github.com/asreview/asreview/discussions/995. Feel free to add to the discussion!


Sort and reverse bars are different heights

Description
The sort and reverse header bars are different heights. This is mostly noticeable with side by side tables. 1 with a sort and 1 with a reverse.
It is slightly less noticeable with both applied

Versions

Deephaven: 0.11.8

This is as designed. Gives you a subtle visual difference that doesn't depend on just colour. You always want to show changes by more than just colour to be more accessible for colour blind. I do accept that this is a pretty subtle difference, and maybe a pattern or something would be even better.


Add missing falback to webpack.config.js

Adding this got rid of an error for me:
buffer: require.resolve("buffer")

thanks @lisa-parity
fixed via https://github.com/bernardoaraujor/empty-webapp/commit/28bdf9504071dd7e92b7745d6586b77466613422
let me know if it's good now


WooCommerce 3.7 changes

WooCommerce 3.7 has landed!
https://woocommerce.wordpress.com/2019/08/12/woocommerce-3-7-has-landed/
I am on the contributors list again - woo! - however for other bugfixes not the change proposed for this plugin :(
As usual, upgrade with caution and at own risk.
Areas of changes likely to need testing for possible impacts:

Variations: loading of variations has changed
Tax classes: have moved to a separate table
Cart: fixed performance bottleneck

New Features not implemented in this plugin:

Product Blocks introduced in 3.6, are enhanced, optimized and extended with new blocks for Product Categories and Tags.  No work has been done on the product blocks in this plugin, so translation probably needs implementing similarly to WooCommerce shortcodes.
Additional Content sections added to all email templates: great but needs adding to Polylang Strings Translation by adding implementation to Emails.php

Contributions welcome!

Still no work done on Product blocks, nor have specific incompatibilities been reported.
Email fields duplicated by #476
closing as WooCommerce 3.7 superseded by WooCommerce 4.x


Activate a quick-n-dirty macosx shell builder

Activate a macosx shell builder to get some CI/CD active pending a linux-based toolchain.

wrong git service


xmlsec1 missing

The "Generating Signed AuthnRequests" example gives me the following error:
exec: "xmlsec1": executable file not found in $PATH

Looks like this is a required tool for this project.
I just installed it on my Ubuntu machine sudo apt install xmlsec1.


Remove duplicate routes with Array#uniq instead of Array#delete_if

Hello!
Here is my little story behind this PR. :smile:
Problem
Recently I've updated ruby to version 2.3.0. Then I've found that route helpers are no longer available in my application.
After quick investigation I've discovered that there is a problem with GrapeRouteHelpers::AllRoutes#all_routes method, which returns empty array instead of array of Grape::Route objects.
The possible reason is that Array#delete_if behavior has changed in ruby-2.3.0:

Array#select!, Array#keep_if, Array#reject!, and Array#delete_if no longer changes the receiver array instantly every time the block is called.

Possible solution
The main idea is to collect array of route options and use Array#uniq against this array. Then we can pass only route options hash to GrapeRouteHelpers::DecoratedRoute instead of passing the whole Grape::Route instance.
I've checked, this solution gave me a consistent result on ruby-2.2.3 and ruby-2.3.0.
Please check out my PR and tell me what do you think.
I've also fixed specs and added rspec config for randomize specs order.
Thank you.

I've slightly changed my implementation for the sake of naming, now DecoratedRoute is initialized with route instance as it was before.
Thanks, @timurkhafizov

Thank you! I'll take a look at your commit very soon. It looks like several people have made a PR about this, I didn't know it was an issue.

Hi, thanks a lot for taking the time to write a PR and submit it. I chose to merge someone else's fix into the master branch because their change was more contained. Does that make sense? There are things in your pull request that I think are a good idea (like configuring Rspec to run specs in a random order) and will add in.
I really appreciate your help.

I also released 1.2.2, which should make it work with Ruby 2.3. Please let me know if something else is wrong.

@reprah I've checked — it works as expected with 1.2.2 and ruby 2.3.0.
Thank you for release.


fix #2940

see #2942

@Vurv78

I'm sorry, is your code structured so you use createWire to use dynamically generated wirelinks? Is that the problem here?

I'm using the return value of CamController:wirelink() and assuming it's a valid wirelink (which it was before this PR)
wrecking_ball/modules/seatcontrol_module.txt
    function seatrotation_setupCamController(CamController:entity){
        CamController:linkTo(SEATROTATION_Seat)
        SEATROTATION_CamLink = CamController:wirelink()
        SEATROTATION_CamLink["Position",vector] = SEATROTATION_HampterEyePos
        SEATROTATION_CamLink["Parent",entity]   = SEATROTATION_Seat
    }

When I do this now, I get back a bugged wirelink that doesn't do anything when I write to its inputs.

If #2942 takes too long to merge then I'll merge this.


Expression Variable Support

Uniform does not currently support the use of variables.

Added support for Expression Variables. It is now possible to declared a variable as a statement and have it store its value and update its dependencies correctly.
@filled: /"."/;

@makeValid: make matches @filled;
valid: @makeValid;


tf.autodiff.ForwardAccumulator._watch(primal, tangent) erroneously refers to dtype.is_floating which does not exist for a Keras layer.

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
binary
TensorFlow version
2.17.0
Custom code
No
OS platform and distribution
Linux ubuntu 24.04
Mobile device
No response
Python version
3.12.3
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
The bug is that in tf.autodiff.ForwardAccumulator._watch(primal, tangent), it refers to the attribute primal.dtype.is_floating, but this causes a crash, as primal.dtype is now a string type variable, and so does not have the attribute "is_floating".
Here is the error message I see, from the standalone code below.
File "/home/me/.local/lib/python3.12/site-packages/tensorflow/python/eager/forwardprop.py", line 411, in _watch
if not primal.dtype.is_floating:
^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'is_floating'
Standalone code to reproduce the issue
import tensorflow as tf
x = tf.constant([[2.0, 3.0], [1.0, 4.0]])
targets = tf.constant([[1.], [-1.]])
dense = tf.keras.layers.Dense(1)
dense.build([None, 2])
with tf.autodiff.ForwardAccumulator(
   primals=dense.kernel,
   tangents=tf.constant([[1.], [0.]])) as acc:
  loss = tf.reduce_sum((dense(x) - targets) ** 2.)
print(acc.jvp(loss))

Relevant log output
No response

The standalone code I gave to reproduce this issue is the example code given at https://www.tensorflow.org/api_docs/python/tf/autodiff/ForwardAccumulator , so that code really should work.

Hi @mikefairbank ,
Apologies for the delay, and thank you for raising your concern here. By default the colab notebook is using tensorflow v2.17 which contains keras3.0 which was causing the error. Could you please try to import keras2.0 with the below commands.
!pip install tf-keras

import tf_keras as keras

Also I have modified some steps and then the code was executed without error/fail. Kindly find the gist of it here.
Thank you!

Thank you for looking into this.  The fix you suggested works well for me.  I've switched to tf-keras from keras, and pip upgraded my tensorflow versions to 2.18 now (for both tensorflow and tf-keras).
There still seems to be the same bug though affecting tf.keras:
File "/home/me/.local/lib/python3.12/site-packages/tensorflow/python/eager/forwardprop.py", line 411, in _watch
if not primal.dtype.is_floating:
^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'is_floating'
Is that something that can/should be fixed?  Should the user just know to use tf_keras and not tf.keras?  That doesn't seem right!

Also, the example code in https://www.tensorflow.org/api_docs/python/tf/autodiff/ForwardAccumulator will need changing to use tf-keras instead of tf.keras.  I think the needed solution is to fix forwardprop.py, line 411 so that it can handle string dtypes.

So this task has been closed then.

Please don't close it.  I think:

the example code in https://www.tensorflow.org/api_docs/python/tf/autodiff/ForwardAccumulator will need changing to use tf-keras instead of tf.keras
The code in tf.keras has this bug still:

File "/home/me/.local/lib/python3.12/site-packages/tensorflow/python/eager/forwardprop.py", line 411, in _watch
if not primal.dtype.is_floating:
^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'is_floating'
We can work around this by switching tf-keras for tf.keras, but I'm not sure that is the permanent solution to this problem.

Hi, @mikefairbank
I apologize for the delayed response, It seems like this issue is happening because of TensorFlow + Keras 2 backwards compatibility From TensorFlow 2.0 to TensorFlow 2.15 (included), doing pip install tensorflow will also install the corresponding version of Keras 2 – for instance, pip install tensorflow==2.14.0 will install keras==2.14.0. That version of Keras is then available via both import keras and from tensorflow import keras (the tf.keras namespace).
Starting with TensorFlow 2.16, doing pip install tensorflow will install Keras 3. When you have TensorFlow >= 2.16 and Keras 3, then by default from tensorflow import keras (tf.keras) will be Keras 3.
Meanwhile, the legacy Keras 2 package is still being released regularly and is available on PyPI as tf_keras (or equivalently tf-keras – note that - and _ are equivalent in PyPI package names). To use it, you can install it via pip install tf_keras then import it via import tf_keras as keras.
Should you want tf.keras to stay on Keras 2 after upgrading to TensorFlow 2.16+, you can configure your TensorFlow installation so that tf.keras points to tf_keras. To achieve this:

Make sure to install tf_keras. Note that TensorFlow does not install it by default.
Export the environment variable TF_USE_LEGACY_KERAS=1.

I have submitted PR to update example https://github.com/tensorflow/tensorflow/pull/83318
Thank you for your cooperation and patience.

From my understanding of the comments posted here, the same error occurs when using either keras or tf-keras, right?

Hi, @mihaimaruseac
Today, I have tried different combinations of TensorFlow versions and Keras versions along with standalone installing Keras without installing the tf_keras and setting up environment variable TF_USE_LEGACY_KERAS=1  it is throwing this error message AttributeError: 'str' object has no attribute 'is_floating' for examples mentioned for tf.autodiff.ForwardAccumulator but when I install tf_keras manually and setting up environment variable TF_USE_LEGACY_KERAS=1  the examples are working as expected please refer this gist-file where I did all the experiments with different versions of TensorFlow and Keras even I checked by installing Keras package standalone but examples did not work as expected
If I am not wrong examples mentioned for tf.autodiff.ForwardAccumulator are working with Keras 2 but it is not working with Keras 3  so should we proceed with making the tf.autodiff.ForwardAccumulator API compatible with Keras 3 or are the below proposed changes sufficient for the time being?
I have missed something here please let me know. Thank you
>>> # Please install pip install tf_keras before executing below examples
>>> import os
>>> import numpy as np
>>> import tensorflow as tf
>>> os.environ["TF_USE_LEGACY_KERAS"] = "1"

I tried it myself. First, setup:
[...]$ pip list
Package                      Version
---------------------------- -------------------
absl-py                      2.1.0
astunparse                   1.6.3
certifi                      2024.12.14
charset-normalizer           3.4.0
flatbuffers                  24.3.25
gast                         0.6.0
google-pasta                 0.2.0
grpcio                       1.68.1
h5py                         3.12.1
idna                         3.10
keras-nightly                3.7.0.dev2024122303
libclang                     18.1.1
Markdown                     3.7
markdown-it-py               3.0.0
MarkupSafe                   3.0.2
mdurl                        0.1.2
ml_dtypes                    0.5.0
namex                        0.0.8
numpy                        2.1.3
opt_einsum                   3.4.0
optree                       0.13.1
packaging                    24.2
pip                          24.0
protobuf                     5.29.2
Pygments                     2.18.0
requests                     2.32.3
rich                         13.9.4
setuptools                   70.3.0
six                          1.17.0
tb-nightly                   2.19.0a20241223
tensorboard-data-server      0.7.2
tensorflow-io-gcs-filesystem 0.37.1
termcolor                    2.5.0
tf_nightly                   2.19.0.dev20241219
typing_extensions            4.12.2
urllib3                      2.3.0
Werkzeug                     3.1.3
wheel                        0.45.1
wrapt                        1.17.0
[...]$ echo ${TF_USE_LEGACY_KERAS:-unset}
unset

Then, reproduction
>>> import tensorflow as tf
2024-12-23 11:00:56.974298: I external/local_xla/xla/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-12-23 11:00:56.978166: I external/local_xla/xla/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-12-23 11:00:56.986610: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:467] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
E0000 00:00:1734980457.003693 2169296 cuda_dnn.cc:8501] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
E0000 00:00:1734980457.007630 2169296 cuda_blas.cc:1407] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-12-23 11:00:57.021934: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX512F FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
>>> x = tf.constant([[2.0, 3.0], [1.0, 4.0]])
E0000 00:00:1734980461.384182 2169296 cuda_executor.cc:1189] INTERNAL: CUDA Runtime error: Failed call to cudaGetRuntimeVersion: Error loading CUDA libraries. GPU will not be used.: Error loading CUDA libraries. GPU will not be used.
W0000 00:00:1734980461.386100 2169296 gpu_device.cc:2342] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
>>> targets = tf.constant([[1.], [-1.]])
>>> dense = tf.keras.layers.Dense(1)
>>> dense.build([None, 2])
>>> with tf.autodiff.ForwardAccumulator(primals=dense.kernel, tangents=tf.constant([[1.], [0.]])) as acc:
...   loss = tf.reduce_sum((dense(x) - targets) ** 2.)
...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/eager/forwardprop.py", line 372, in __init__
    self._watch(primals, tangents)
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/eager/forwardprop.py", line 423, in _watch
    nest.map_structure(_watch, primals, tangents)
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/util/nest.py", line 628, in map_structure
    return nest_util.map_structure(
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/util/nest_util.py", line 1065, in map_structure
    return _tf_core_map_structure(func, *structure, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/util/nest_util.py", line 1105, in _tf_core_map_structure
    [func(*x) for x in entries],
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/util/nest_util.py", line 1105, in <listcomp>
    [func(*x) for x in entries],
     ^^^^^^^^
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/eager/forwardprop.py", line 411, in _watch
    if not primal.dtype.is_floating:
           ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'is_floating'

Minimizing:
>>> tf.autodiff.ForwardAccumulator(primals=dense.kernel, tangents=tf.constant([[1.], [0.]]))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/eager/forwardprop.py", line 372, in __init__
    self._watch(primals, tangents)
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/eager/forwardprop.py", line 423, in _watch
    nest.map_structure(_watch, primals, tangents)
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/util/nest.py", line 628, in map_structure
    return nest_util.map_structure(
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/util/nest_util.py", line 1065, in map_structure
    return _tf_core_map_structure(func, *structure, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/util/nest_util.py", line 1105, in _tf_core_map_structure
    [func(*x) for x in entries],
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/util/nest_util.py", line 1105, in <listcomp>
    [func(*x) for x in entries],
     ^^^^^^^^
  File "/tmp/tf/venv/lib/python3.11/site-packages/tensorflow/python/eager/forwardprop.py", line 411, in _watch
    if not primal.dtype.is_floating:
           ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'is_floating'

Using only constants:
>>> tf.autodiff.ForwardAccumulator(primals=tf.constant([[0.], [1.]]), tangents=tf.constant([[1.], [0.]]))
<tensorflow.python.eager.forwardprop.ForwardAccumulator object at 0x7faeb00ba150>

So, the issue is on the keras layer:
>>> tf.constant([[0.], [1.]]).dtype
tf.float32
>>> dense.kernel.dtype
'float32'

We should make the code compatible with both TF-Keras and Keras 3.

Now that the issue is isolated, installing tf_keras-nightly directly results in both keras versions being installed:
[...]$ pip list | grep keras
keras-nightly                3.7.0.dev2024122303
tf_keras-nightly             2.19.0.dev2024122310

Testing
[...]$ python
Python 3.11.9 (main, Jun 19 2024, 00:38:48) [GCC 13.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
2024-12-23 11:10:20.719619: I external/local_xla/xla/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-12-23 11:10:20.722685: I external/local_xla/xla/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-12-23 11:10:20.731190: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:467] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
E0000 00:00:1734981020.746389 2173405 cuda_dnn.cc:8501] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
E0000 00:00:1734981020.750512 2173405 cuda_blas.cc:1407] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-12-23 11:10:20.766911: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX512F FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
>>> l = tf.keras.layers.Dense(1)
>>> l.build([None, 2])
E0000 00:00:1734981044.048778 2173405 cuda_executor.cc:1189] INTERNAL: CUDA Runtime error: Failed call to cudaGetRuntimeVersion: Error loading CUDA libraries. GPU will not be used.: Error loading CUDA libraries. GPU will not be used.
W0000 00:00:1734981044.050537 2173405 gpu_device.cc:2342] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
>>> l.kernel.dtype
'float32'

This is not good. Let's set the environment variable:
[...]$ export TF_USE_LEGACY_KERAS=1
[...]$ python
Python 3.11.9 (main, Jun 19 2024, 00:38:48) [GCC 13.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
2024-12-23 11:11:13.884706: I external/local_xla/xla/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-12-23 11:11:13.887806: I external/local_xla/xla/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-12-23 11:11:13.896277: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:467] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
E0000 00:00:1734981073.910177 2173913 cuda_dnn.cc:8501] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
E0000 00:00:1734981073.914621 2173913 cuda_blas.cc:1407] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-12-23 11:11:13.928734: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX512F FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
>>> l = tf.keras.layers.Dense(1)
>>> l.build([None, 2])
E0000 00:00:1734981083.268596 2173913 cuda_executor.cc:1189] INTERNAL: CUDA Runtime error: Failed call to cudaGetRuntimeVersion: Error loading CUDA libraries. GPU will not be used.: Error loading CUDA libraries. GPU will not be used.
W0000 00:00:1734981083.270463 2173913 gpu_device.cc:2342] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
>>> l.kernel.dtype
tf.float32

So, this should likely be a bug reported on Keras and what we can do for TF is to suggest to set the environment variable (in tutorial, I'm not sure we should do that in code since the code works perfect when not using Keras at all)


Replace prototype form observer

@dclarizio please test/review.
This PR is replacement for https://github.com/ManageIQ/manageiq/pull/1316, since i do not have access to push to @bmclaughlin 's branch.

other than the inline comments, all looks good

@martinpovolny good catch, fixed both places. Please re-review


[DOC] What is the difference between FileField and UrlField?

Documentation issue
What is the difference between?

FileField https://refine.dev/docs/api-reference/mui/components/fields/file/
UrlField https://refine.dev/docs/api-reference/mui/components/fields/url/

Currently in the examples, it looks like both fields look and behave the exactly same.
Also IMO these example looks very artificial:

Who really wants to display the image url? I think it would be better just to display image.
Describe the thing to improve
FileField and UrlField should not work and behave the same.
Describe the solution (optional)
No response

Hey @Mikilll94 ,
Unlike URLField, FileField takes 'title' parameter. Maybe in the future, we can merge the two components


Update synth script for tasks

The gemspec is now updated while preserving the current gem version. (Currently this requires running synthtool from master.)

Okay hold off for a moment... looks like we have to add the grpc-google-iam-v1 dependency back...


Update gotchas.md and Quick Start

We need to address what's described in this comment
We have #1529 #1500 #1497 #1427 #1443 #1375 #1278. Almost all of them were solved by running a standard set of commands-
rm -rf node_modules
rm -rf build
yarn install
OR
npm cache clean
npm install
As @gihrig said,

The project provides a yarn.lock file that (pretty much) guarantees a working set of dependencies is installed if the yarn install command is used to install dependencies.

So I propose three things-

To add emphasis on using yarn over npm in Quick Start section of README.md
To add the aforementioned set of commands right below Quick Start section in README.md
To address #1491 by adding instructions to install brew in Gotchas.md

@KarandikarMihir

So I propose three things-

I agree! 👍

Another one for Gotchas: A common issue is the need to exclude modules from Babel processing. See this #1405 comment


nuget package with any cpu library

Hi!
I have the issue with the nuget package of the library. It contains only x86 version. Is there a reason for this and could it be possible to make package with any cpu build?

Tracking with #110 .


Hotfix: Headline / Blockquote Text Alignment Regression Fix

Jira
http://vjira2:8080/browse/BDS-2074
Summary
Addresses a regression in last week's v2.20.0 release in which the new Numbered Bullet feature added to Headline component inadvertently caused the component's text alignment to not work as expected in certain situations.
Details

While Headline component's horizontal alignment (via the component's align prop) continues to work as expected, there were unfortunate side-effects from the globally applied display: flex; CSS update that caused text alignment to stop working in the Blockquote component + when the u-bolt-text-align-X utility class was used.

This PR works around that issue by only adding the display: flex; styles + related c-bolt-headline__text inner text wrapper in the specific use case that required both of those updates in the first place -- when a Headline is displaying the new Numbered Bullet option.

This PR also ensures that the c-bolt-headline__text wrapper continues to be conditionally added when the quoted version of Headline is used (which the original updates in v2.20.0 addressed)

This PR also fixes a separate issue related to this regression with Blockquote quote styles not rendering as expected once the page's JavaScript kicks in

Finally, this PR cherry picks the one critical update from #1793 to ensure CI builds continue to work as expected.

How to test

Confirm new text alignment-related VRT snapshots added for Blockquote look correct
Compare before and after links for Headline, Blockquote, and the referenced utility class instance to confirm these updates fix the visual regressions.

Headline demos are visually similar in v2.20.0 compared to this PR

[ ] Confirm that the Headline is visually as good or better as it was in the v2.20.0 release
[ ] Confirm that the quotes that display when the Headline's quoted option is used show up as expected
[ ] Confirm that the Right Icon in Headline is still inline when text wraps on smaller screens

Blockquote text alignment broken in v2.20.0 is now fixed

[x] Confirm that the Headline's text alignment usage within Blockquote is fixed in this PR when compared to the previous v2.20.0 release

The broken Utility class alignment for "Add Mission" in v2.20.0 is now fixed

[x] Confirm that the Headline component's text alignment is now fixed with this updates from this PR.

@danielamorse this should be ready for you to take another look 👍

Thanks @danielamorse!

PR was released with v2.20.1


Use SDL math functions to avoid including cmath

SDL's main libray has SDL_cos and SDL_sin, since this is built on top of SDL, it will be fine to use this and still maintain single header functionality.

Merged in first PR.


Doesn't work when folder opened

When you "open folder" with VSCode, and then from VSCode open a file, the plugin does not embed any files. It will only work if you open the file directly from the OS.

I tried the following in my windows environment and it worked fine.

Click on the “File” menu in vscode.
click on “Open Folder
open any folder
select any html file from vscode's folder tree
run the plugin

Do you have any other information?
As per another ticket, I will check it on Linux as soon as I get time.


timedelta doesn't parse fractional seconds

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
A field of the timedelta type, when given a float, seems to floor it to an int before creating a timedelta, even though timedelta supports fractional seconds.
Example Code
from datetime import timedelta
from pydantic import BaseModel

class Foo(BaseModel):
    t: timedelta

print(repr(Foo(t=.5).t))
# datetime.timedelta(0)

print(repr(timedelta(seconds=.5)))
# datetime.timedelta(microseconds=500000)

Python, Pydantic & OS Version
$ python -c "import pydantic.version; print(pydantic.version.version_info())"
             pydantic version: 2.6.1
        pydantic-core version: 2.16.2
          pydantic-core build: profile=release pgo=true
                 install path: .../venv/lib/python3.8/site-packages/pydantic
               python version: 3.8.18 (default, Aug 25 2023, 13:20:30)  [GCC 11.4.0]
                     platform: Linux-6.1.0-1033-oem-x86_64-with-glibc2.35
             related packages: email-validator-2.1.0.post1 typing_extensions-4.9.0 fastapi-0.109.0 pydantic-settings-2.1.0 mypy-1.8.0
                       commit: unknown

@brianmedigate,
When I run this on main with the latest version of speedate, I get the following:
from datetime import timedelta
from pydantic import BaseModel

class Foo(BaseModel):
    t: timedelta

print(repr(Foo(t=.5).t))
# datetime.timedelta(microseconds=500000)

print(repr(timedelta(seconds=.5)))
# datetime.timedelta(microseconds=500000)

Additionally, with this extra config setting, I get the following behavior:
from datetime import timedelta

from pydantic import BaseModel, ConfigDict

class Foo(BaseModel):
    t: timedelta

    model_config = ConfigDict(ser_json_timedelta='float')

print(repr(Foo(t=.5).t))
# datetime.timedelta(microseconds=500000)

print(repr(timedelta(seconds=.5)))
# datetime.timedelta(microseconds=500000)

print(Foo(t=.5).model_dump_json())
#> {"t":0.5}

print(Foo(t=timedelta(seconds=.5)).model_dump_json())
#> {"t":0.5}

Marking this as resolved, as I think this shows that the behavior you're looking for is present.

great, thanks!

I'm still seeing this behavior on the latest release (2.6.3 from last week):
  from datetime import timedelta
  from pydantic import BaseModel, __version__

class Foo(BaseModel):
    t: timedelta

print(repr(Foo(t=.5).t))
print(f"Pydantic: {__version__}")

datetime.timedelta(0)
Pydantic: 2.6.3

same with 2.7.0. @sydney-runkle do you mind taking a look?

It would be good to reopen until it's available imo

Hey folks,
I'm getting the following with 2.7.1:
from datetime import timedelta
from pydantic import BaseModel, __version__

class Foo(BaseModel):
    t: timedelta

print(repr(Foo(t=.5).t))
#> datetime.timedelta(microseconds=500000)
print(f"Pydantic: {__version__}")
#> Pydantic: 2.7.1

Apologies for the delayed response, the ping slipped through my email!
Lmk if you're still experiencing this issue, we can definitely reopen if it's still a problem!

Yes, same behavior
from datetime import timedelta
from pydantic import BaseModel, __version__

class Foo(BaseModel):
    t: timedelta

print(repr(Foo(t=.5).t))
#> datetime.timedelta(0)
print(f"Pydantic: {__version__}")
#> Pydantic: 2.7.1

@brianmedigate,
What version of pydantic-core are you using? Maybe we didn't bump the dependency correctly for speedate. If so, I can fix that in 2.7.2!

2.18.2

@brianmedigate,
Can you share what version of speedate you're using? Working on our prep for 2.7.2 now and want to make sure everything is ironed out.

How can I check? Isn't it a compile-time dependency of pydantic_core, so wouldn't it be implied by the version of pydantic_core that I'm using?

@davidhewitt, any advice here?

I can reproduce with Pydantic 2.7.1; the important point is the Python version 3.8. I suspect also was broken on 3.9.
The good news is that it's already fixed in 2.7.2. I'm pretty sure this was a case of older versions suffering from integer promotion, similar to https://github.com/pydantic/pydantic/issues/9018, which was fixed in https://github.com/pydantic/pydantic-core/pull/1288.

I can confirm that it's fixed for me in 2.7.2. Thanks!


Binary payload javascript decoder example

Place the decoder function for the binary coordinate examples, which can be used on the TTN console, somewhere in the repository.

Fixed in https://github.com/jpmeijers/RN2483-Arduino-Library/pull/36


 Github doesn't support upload of .mjml files.)

To Reproduce

In Chrome and Firefox: Use Node.js, MJML, and the renamed file from above to create an HTML file equivalent to the above file. Point each browser to that file.

In VS Code: Edit the renamed file from above.

In the MJML App: Point the app to the renamed file from above.

In Try-it-Live: Click Try-it-Live.

Expected behavior
All four renderings show only white text (#FAFAFA) on a blue background (#001FFE).
Actual behavior

Chrome, Firefox, and VS Code render as intended: The background is blue and the text is white.

Firefox and VS Code are effectively identical.

The MJML App:

Text at the top left and bottom right is black, not white.
The background color is purple (#3700FD).

Try-it-Live:

Text at the top left and bottom right is black, not white. (Matches the MJML App.)
The background color is as expected.

Background
The JetBrains HTML Support plugin reproduces the MJML App rendering.

For some reason re-rendering an iframe doesn't recognize the doctype of the document switching to quirks mode as it loads some weird css with a lot of overrides.
I'm closing, there's not so much we can do about this without compromising perf/adding visual glitches  when reloading the iframe entirely.

That happens (by this evidence) only for Try-it-Live and the MJML App (Electron)? Has anything common to them changed recently to cause this? This feels new.

Any browsers behave like this so it’s like this for a while

On 29 Jun 2021, at 20:48, Garry Flemings @.***> wrote:

That happens (by this evidence) only for Try-it-Live and the MJML App (Electron)? Has anything common to them changed recently to cause this? This feels new.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

The browsers are operating correctly. The condition is only in Try-it-Live and the MJML App.

Every browsers behave like this with iframe when replacing content on the fly.

On 29 Jun 2021, at 21:13, Garry Flemings @.***> wrote:

The browsers are operating correctly. The condition is only in Try-it-Live and the MJML App.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Here's a total surprise.
Sigh. Try-it-Live renders the same as Chrome and Firefox now.

That's different from just two days ago when I wrote this ticket.
The MJML App did not change from above.
I had another reason to put the code directly from this ticket into Try-it-Live again. Compare the above image to the third image in the original ticket. Here, all text is white.
Perhaps the Try-it-Live update from 4.7.1 to 4.9.3 was relevant? Something else?

It happens when it reload the iframe as I've said. Change a small character and it iframe goes in quirk mode from some unknown reasons.


explicit libs example ?

Hi,
I wanted explicit libraries to be passed to compiled objects.
I put into autocmake.cfg (after DIRAC autocmake.cfg)
[explicit]
docopt: --explicit-libs=<LIBS> Explicit linker specification for extra libraries passed directly to the linker [default: off].
define: '-DEXPLICIT_LIBS=%s' % arguments['--explicit-libs'].strip()

did setup
python setup --fc=gfortran --blas=off --lapack=off --explicit-libs="/u/milias/Work/qch/software/lapack/lapack-3.6.0/build/lib/liblapack.a  /u/milias/Work/qch/software/lapack/lapack-3.6.0/build/lib/libblas.a"  build_gfortran_lapack3.6.0

but the linking command is not complete:
/usr/bin/gfortran       -O3 -funroll-all-loops CMakeFiles/dsyerv_check.dir/dsyerv_check.F90.o CMakeFiles/dsyerv_check.dir/eispack.F.o  -o dsyerv_check -rdynamic /u/milias/Work/qch/software/lapack/lapack-3.6.0/build/lib/liblapack.a

The reason could be the python strip() command.
Could we have an autocmake example of explicit libs adding ?

The problem is that explicit
[explicit]
docopt: --explicit-libs=<LIBS> Explicit linker specification for extra libraries passed directly to the linker [default: off].
define: '-DEXPLICIT_LIBS=%s' % arguments['--explicit-libs']

accepts only one string, we need more strings separated by blanks....

I will try to fix that. But independently of this apparent issue why don't you include BLAS and LAPACK via --blas and --lapack?

Hi,
I was testing fresh lapack3.6.0, https://github.com/miroi/lapack-dsyevr-test
python setup --fc=ifort --blas=off --lapack=off --cmake-options="-D EXPLICIT_LIBS='-L/u/milias/Work/qch/software/lapack/lapack-3.6.0/build/lib -llapack -lblas -lgfortran'"  build_ifort_lapack3.6.0

I don't know if ot works to include both blas+lapack viac --blas/--lapack for such a package...

Well ideally it should work and if it does not, we need to fix it. It is otherwise unnatural to include BLAS and LAPACK using --blas=off --lapack=off. But independently I will try to fix the --explicit-libs issue.

There is no explicit libs module in Autocmake. This is not an Autocmake issue. Probably a DIRAC issue. Closing.

Yes,it's rather DIRAC support. Also, would be good to extend the autocmake documentation on it...

Extend the Autocmake documentation on what?

....on adding the explicit libs as I did, via --cmake-options="-D EXPLICIT_LIBS='-L/u ...

You mean documentation on --cmake-options? Autocmake knows nothing about EXPLICIT_LIBS. Please try to keep these things separated.

I would add an example (or test) to autocmake on how to include standalone math libraries. This has to do with math library search when math libs are on 'non-standard' positions (like user downloaded packages).

Good idea on such doc. I will open a new issue on that. This one is closed now.

...and please, Rado, would you improve EXPLICIT_LIBS usage in Dirac to that it can include more than one string ?

This is not the right place to discuss DIRAC issues. Open an issue there, mention me, and then we see what we can do about it.


Fatal Exception: could not delete: /data/user/0/com.package_name/lib-0/libbetter.so on production build

Fatal Exception: java.lang.RuntimeException: Unable to create application com.packageName.MainApplication: java.lang.RuntimeException: java.io.IOException: could not delete: /data/user/0/com.packageName/lib-0/libbetter.so
This issue is coming in production build on firebase crash analytics, but I'm unable to reproduce it.
As Firebase crash analytic information this issue is coming on following android devices
Galaxy Note20 Ultra 5G (Android version 13)
OnePlus 9 5G (Android Version 12)
"react": "18.2.0",
"react-native": "0.71.7",
Any faced the same issue? please help.
Originally posted by @tmikov in https://github.com/facebook/hermes/issues/1005#issuecomment-1557364491

java.io.IOException: could not delete: /data/user/0/com.packageName/lib-0/libbetter.so

What is libbetter.so? That's not part of React Native at all.

did anyone found any solution for this issue??, getting this error as a crash in my android app logs.


Allow several messages to be forwarded at once (for media groups)

The method the bot API will call is forwardMessages. Currently the bot API only allows to forward one message in forwardMessage.
This decision doesn't allow bots to forward (parts of) media groups. If a bot e.g. encounters a media group in a channel and wants to forward it as a group, the bot has to send a new media group. This degrades the user experience, since the link to the channel is lost and the bot has to add it manually to the media caption if it is to persist, not to speak of the view counter which the bot can not replicate even if it wants to.
The other solution is to forward each media of a media group, which can lead to 10 updates at once for an user, which they certainly do not appreciate either.
It would be better if a bot can forward multiple messages at once, as the MTProto API and clients support.

Yes! It would be very helpful to have this functionality in the bot API, especially if it's already present in MTProto.

The same request for copyMessage.

yay, Bot API 7.0 fixes this


[TensorRT] use op_name as op_type_name.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): None
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): centos 7.2
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: None
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 1.11.0
Python version: 2.7
Bazel version (if compiling from source):  0.16.1
GCC/Compiler version (if compiling from source): 5.4.0
CUDA/cuDNN version: cudnn 7.0.4
GPU model and memory: p40 & 20GB
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem

run tensorflow 1.11.0 with tensorrt 4.0.6.
TRTEngineOp is registered.
I find the tf  use op_name as op_type_name.

Not found: Op type not registered 'TitleLSTM/my_trt_op_2_native_segment' in binary

I think  'TitleLSTM/my_trt_op_2_native_segment' is a op_name, this op's type is 'TRTEngineOp'
Source code / logs
2018-09-30 17:23:37.482200: I external/org_tensorflow/tensorflow/core/framework/op.cc:103] Not found: Op type not registered 'TitleLSTM/my_trt_op_2_native_segment' in binary running on jshd_40_73. Make sure the Op and Kernel are registered in the binary running in this process. Note that if you are loading a saved graph which used ops from tf.contrib, accessing (e.g.) tf.contrib.resampler should be done before importing the graph, as contrib ops are lazily registered when the module is first accessed.

@qiaohaijun step 3 is not clear to me. Can you describe what are you trying to do in a bit more detail?

@samikama ok

freeze saved_model to freezed_model
use create_inference_graph to covert freezed_model to freezed_trt_model
convert freezed_trt_model to trt_saved_model for tensorflow_serving
tf serving load the trt_saved_model

When the tensorflow serving is executed, an error occurs.
Not found: Op type not registered 'TitleLSTM/my_trt_op_2_native_segment' in binary

@samikama is it a bug or not?

@qiaohaijun this is not a bug in TFTRT, it is a bug in your script that converts TFTRT model to serving model. As error mentions 'TitleLSTM/my_trt_op_2_native_segment' is not an OP but it is a function. It looks like your serving conversion script can't handle functions.

@qiaohaijun , logs above seem correct to me. TRT optimization pass should not be run on function objects in the graph but current infrastructure runs all configured optimizers on all graph components thus TRT optimization pass is printing a warning about it. I don' t think problem is related with TFTRT or specific to conversion of a TRT optimized graph. It is more likely to be due to you conversion scripts ability to handle function objects in the graph. I expect it to fail similarly when more functional ops introduced in to the graphs. Perhaps you can try asking in TFServing forums, or you can take a look at https://github.com/NVIDIA/dl-inference-server which is similar and support TRT optimized graphs.

@samikama ok, thank you very much.


Could not install speedtest following guide from README file

vadym@ubuntu:~$ git clone git@github.com:vikulin/speedtest.git
Cloning into 'speedtest'...
remote: Enumerating objects: 464, done.
remote: Counting objects: 100% (464/464), done.
remote: Compressing objects: 100% (303/303), done.
remote: Total 3700 (delta 255), reused 303 (delta 158), pack-reused 3236
Receiving objects: 100% (3700/3700), 2.59 MiB | 708.00 KiB/s, done.
Resolving deltas: 100% (2291/2291), done.
vadym@ubuntu:~$ cd speedtest/
vadym@ubuntu:~/speedtest$ ls
assets  Dockerfile  lerna.json  LICENSE  package.json  package-lock.json  packages  README.md
vadym@ubuntu:~/speedtest$ cd packages/web
vadym@ubuntu:~/speedtest/packages/web$ npm ci

><EMAIL_ADDRESS>install /home/vadym/speedtest/packages/web/node_modules/fsevents
> node-gyp rebuild

make: Entering directory '/home/vadym/speedtest/packages/web/node_modules/fsevents/build'
  SOLINK_MODULE(target) Release/obj.target/.node
  COPY Release/.node
make: Leaving directory '/home/vadym/speedtest/packages/web/node_modules/fsevents/build'

><EMAIL_ADDRESS>install /home/vadym/speedtest/packages/web/node_modules/node-sass
> node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.14.1/linux-x64-64_binding.node
Download complete .] - :
Binary saved to /home/vadym/speedtest/packages/web/node_modules/node-sass/vendor/linux-x64-64/binding.node
Caching binary to /home/vadym/.npm/_cacache/node-sass/4.14.1/linux-x64-64_binding.node

><EMAIL_ADDRESS>postinstall /home/vadym/speedtest/packages/web/node_modules/node-sass
> node scripts/build.js

Binary found at /home/vadym/speedtest/packages/web/node_modules/node-sass/vendor/linux-x64-64/binding.node
Testing binary
Binary is fine

><EMAIL_ADDRESS>postinstall /home/vadym/speedtest/packages/web/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
> https://opencollective.com/core-js
> https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

added 1197 packages in 17.219s
vadym@ubuntu:~/speedtest/packages/web$ npm run dist
npm ERR! missing script: dist
npm ERR!
npm ERR! Did you mean this?
npm ERR!     test

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/vadym/.npm/_logs/2020-08-02T10_24_49_435Z-debug.log
vadym@ubuntu:~/speedtest/packages/web$ cd ..
vadym@ubuntu:~/speedtest/packages$ cd ..
vadym@ubuntu:~/speedtest$ ls
assets  Dockerfile  lerna.json  LICENSE  package.json  package-lock.json  packages  README.md
vadym@ubuntu:~/speedtest$ cd cd packages/web
bash: cd: too many arguments
vadym@ubuntu:~/speedtest$ cd packages/web
vadym@ubuntu:~/speedtest/packages/web$ ls
build  node_modules  package.json  package-lock.json  src  webpack.common.js  webpack.config.js  webpack.dev.js  webpack.prod.js
vadym@ubuntu:~/speedtest/packages/web$ cd build/
vadym@ubuntu:~/speedtest/packages/web/build$ ls
app.js  serviceWorker.js
vadym@ubuntu:~/speedtest/packages/web/build$ cd ..
vadym@ubuntu:~/speedtest/packages/web$ cd ..
vadym@ubuntu:~/speedtest/packages$ cd ..
vadym@ubuntu:~/speedtest$ cd packages/server
vadym@ubuntu:~/speedtest/packages/server$ npm ci --production

><EMAIL_ADDRESS>install /home/vadym/speedtest/packages/server/node_modules/websocket
> (node-gyp rebuild 2> builderror.log) || (exit 0)

make: Entering directory '/home/vadym/speedtest/packages/server/node_modules/websocket/build'
  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
  SOLINK_MODULE(target) Release/obj.target/bufferutil.node
  COPY Release/bufferutil.node
  CXX(target) Release/obj.target/validation/src/validation.o
  SOLINK_MODULE(target) Release/obj.target/validation.node
  COPY Release/validation.node
make: Leaving directory '/home/vadym/speedtest/packages/server/node_modules/websocket/build'
added 29 packages in 6.203s
vadym@ubuntu:~/speedtest/packages/server$ node server.js 80 ../web/dist
The web folder does not exists: /home/vadym/speedtest/packages/server/web
vadym@ubuntu:~/speedtest/packages/server$ ls

Hello @vikulin adn soryy for the really late response,
You are completely right. The documentation is dead obsolete for the "Self-hosted server" part. I'll update it as soon as i get a chance.


please update

i cant install anymore tenserflow 1.13.x due to newest updates, and i cant run passGan with newst tenserflow, please update

How please


Update VSCode Extension Release

I just built and smoke-tested the latest version in VSCode and it appears to work great (MacOS 14.5, M2), but I can't get the built extension loaded outside of the project folder.  Anyway, please add "update release vscode extension" to your todo list.  :)

Okay. I'll release the latest version of the extension within a few days.
(Since I'm not sure if there are actual users of this extension, I haven't updated the version to reduce maintenance costs.)

Awesome!  Thank you very much!


Fix mvn profile name for github-actions

Description
Small fix for the mvn profile name used in the 'github-actions' test runner script.

Codecov Report

Merging #6370 (7e54c16) into master (1beaab5) will decrease coverage by 1.08%.
The diff coverage is 56.80%.

@@            Coverage Diff             @@
##           master    #6370      +/-   ##
==========================================
- Coverage   66.44%   65.36%   -1.09%
==========================================
  Files        1075     1294     +219
  Lines       54773    62515    +7742
  Branches     8168     9089     +921
==========================================
+ Hits        36396    40865    +4469
- Misses      15700    18737    +3037
- Partials     2677     2913     +236

Flag
Coverage Δ

unittests
65.36% <56.80%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <0.00%> (+9.52%)
:arrow_up:

.../main/java/org/apache/pinot/client/Connection.java
35.55% <0.00%> (-13.29%)
:arrow_down:

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <0.00%> (-51.10%)
:arrow_down:

...not/common/assignment/InstancePartitionsUtils.java
73.80% <ø> (+0.63%)
:arrow_up:

...common/config/tuner/NoOpTableTableConfigTuner.java
100.00% <ø> (ø)

...ot/common/config/tuner/RealTimeAutoIndexTuner.java
100.00% <ø> (ø)

... and 1147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003442a...7e54c16. Read the comment docs.

Oh! this is a good catch!
Thanks for fixing this!


Removing Polymer from core SDK API's homepage

Also, the "writing API documentation" page was never moved over from the codesite.

thanks for taking a look!

LGTM!

Thanks for the review!


Update to lift test calibration notebook

This issue closes #999 in that it provides various updates and clarifications to the lift test calibration notebook.
Checklist

[ ] Checked that the pre-commit linting/style checks pass
[ ] Included tests that prove the fix is effective or that the new feature works
[ ] Added necessary documentation (docstrings and/or example notebooks)
[ ] If you are a pro: each commit corresponds to a relevant logical change

Modules affected

[X] MMM
[ ] CLV

Type of change

[ ] New feature / enhancement
[ ] Bug fix
[X] Documentation
[ ] Maintenance
[ ] Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1000.org.readthedocs.build/en/1000/

I like the improvement in the doc, I leave some comments with ideas and opinions!

+1

View entire conversation on ReviewNB

@drbenvincent I love the changes 💪 ! Think about Carlo's suggestions and when you are done ping me for a quick last change ant merge !

Good point - I now explicitly mention the adstock function. See what you think.

View entire conversation on ReviewNB

Good idea, have done something along these lines, but retaining the max abs transformation

View entire conversation on ReviewNB

I've given this a go. Can you double check the line y=true_params["saturation_beta"][i] * df[f"x{i+1}_adstock_saturated"], # ?????? in the utility function plot_channel_contributions please? I think it's ok, but would appreciate a sanity check.

View entire conversation on ReviewNB

done

View entire conversation on ReviewNB

Thanks for comments @carlosagostini. I think I've addressed your comments. I did drop in a question for you to double check I'm calculating the true channel contributions correctly.

nice!

View entire conversation on ReviewNB

@carlosagostini if you have time can you please double check @drbenvincent 's las questions :)?

Hey @drbenvincent and @juanitorduz the implementation is correct but I'll recommend do the following:
# Save the true contribution for each channel
df[["true_contribution_x1", "true_contribution_x2"]] = pm.draw(fixed_model["channel_contributions"], random_seed=rng)

Then replace in the function by:
def plot_channel_contributions(mmm, df):
    channels_contribution_original_scale = (
        mmm.compute_channel_contribution_original_scale()
    )
    channels_contribution_original_scale_hdi = az.hdi(
        ary=channels_contribution_original_scale
    )

    get_mean_contributions_over_time_df = mmm.compute_mean_contributions_over_time(
        original_scale=True
    )

    fig, ax = plt.subplots(
        nrows=2,
        figsize=(15, 8),
        ncols=1,
        sharex=True,
        sharey=False,
        layout="constrained",
    )

    for i, x in enumerate(["channel 1", "channel 2"]):
        # Estimate true contribution in the original scale from the data generating process
        sns.lineplot(
            x=df["date"],
            y=df[f"true_contribution_x{i+1}"], ## Change everything here.
            color="black",
            label=f"{x} true contribution",
            ax=ax[i],
        )
        # HDI estimated contribution in the original scale
        ax[i].fill_between(
            x=df["date"],
            y1=channels_contribution_original_scale_hdi.sel(channel=x)["x"][:, 0],
            y2=channels_contribution_original_scale_hdi.sel(channel=x)["x"][:, 1],
            color=f"C{i}",
            label=rf"{x} $94\%$ HDI contribution",
            alpha=0.4,
        )
        # Mean estimated contribution in the original scale
        sns.lineplot(
            x=df["date"],
            y=get_mean_contributions_over_time_df[x].to_numpy(),
            color=f"C{i}",
            label=f"{x} posterior mean contribution",
            alpha=0.8,
            ax=ax[i],
        )
        ax[i].legend(loc="center left", bbox_to_anchor=(1, 0.5))
        ax[i].set(title=x, ylim=(0, 1))

If we are using pm.draw already, then we can keep it simple estimating the true contribution from the start. What do you think?

@juanitorduz @drbenvincent
Another comment, we are adding numpyro to all our notebooks but it is not a dependency, neither is Jax. So a new user will have problems running our notebooks, sometimes I forget, for example now, trying this I got errors.
I would recommend not using numpyro in the examples, otherwise we should add it to the dependencies. What do you think? I had removed numpyro in a PR but apparently it came back 😅

Good point @cetagostini !

Thanks @drbenvincent !

Thanks. I'll get on these changes today/tomorrow.


[Crash] FragmentViewBindingDelegate edge case

Specific edge case with binding delegate -
When bindings are accessed and created lazily, when the binding is never accessed in between onViewCreated and onDestroyView, accessing the binding inside of onDestroyView will crash the application. It seems like when the fragment is created and abruptly destroyed - this never gives the Fragment the chance to call the binding.
Crashes with

java.lang.IllegalStateException: Should not attempt to get bindings when Fragment views are destroyed.

How did you end up in onDestroyView without making the binding initialized via onViewCreated? 🤔

Binding is accessed and created lazily - we have an edge case where the binding is never used in a fragment until a specific set of conditions are met. As the activity that contains the fragment is destroyed, the fragment ends up in onDestroyView and the fragment never gets the chance to use the binding to initialize it in the first place.

Hi @Zhuinden, @kendrickkwok's colleague here.
Would like to attempt to explain the issue in a little more detail, in preparation for the PR I'm about to submit to fix the issue.
Here's the conditions that were causing the crash:

The Fragment is created and attached to the Activity
Other async code runs, killing the Activity
The Fragment never executes any code that accesses the binding, and starts getting torn down
The Fragment hits onDestroyView(), where our cleanup code runs, becoming the first time we attempt to access the binding.

This ends up triggering the crash, because according to the Fragment Lifecycle docs,

the fragment's view Lifecycle is moved into the DESTROYED state and emits the ON_DESTROY event to its observers. The fragment then invokes its onDestroyView() callback.

Ultimately, the check !lifecycle.currentState.isAtLeast(Lifecycle.State.INITIALIZED) is incorrect, because the state is moved to DESTROYED before the call to onDestroyView().
Our solution is to replace the lifecycle state check with thisRef.view == null in the getValue() method. That way, we can create the binding in onDestroyView safely, even though it'll be destroyed very shortly after.
We realize this is kind of dumb, but legacy code is legacy code...

If Jitpack works, 1.0.2 should have it


Make include_in_copy work for patterns containing parent folders

The current implementation does not allow to copy files specified with include_in_copy which are not at the root of the repository.
I have the following repository structure:
├── config
│   └── app
│       └── dev
│           ├── .terraform.lock.hcl
│           └── terragrunt.hcl
└── modules
    └── app
        ├── chart
        │   ├── .helmignore
        │   ├── Chart.yaml
        │   ├── charts
        │   ├── templates
        │   │   ├── NOTES.txt
        │   │   ├── _helpers.tpl
        │   │   ├── deployment.yaml
        │   │   ├── hpa.yaml
        │   │   ├── ingress.yaml
        │   │   ├── service.yaml
        │   │   ├── serviceaccount.yaml
        │   │   └── tests
        │   │       └── test-connection.yaml
        │   └── values.yaml
        └── main.tf

My terragrunt.hcl looks as follows:
terraform {
  source = "../../..//modules/app"
  include_in_copy = [
    "**/.helmignore"
  ]
}

Doing terragrunt init does NOT copy .helmignore. I explained what I believe the issue in this comment.
This PR changes the semantic and invocation of the filter function. The function parameter is now an absolute path, which allows proper lookup in includeExpandedGlobs list.
Changing the semantic of the filter function also changes slightly the behavior of CopyFolderContentsWithFilter. I noticed that this function is also used in internal/tfr/getter.go but the actual filter function implementation used there always returns true so the introduced change should have no negative impact there.
Finally, note that this implementation may not be completely correct yet. Based on the documentation for the include_in_copy attribute, "The path should be specified relative to the source directory". If my source directory is modules/app, the value of include_in_copy should be chart/.helmignore. Unfortunately this does not work either even with my proposed changes. I see that in the code the "source" is my repository root - that's why include_in_copy=["modules/app/chart/.helmignore"] also works for me.

Hi,
nice attempt but seems that still not all files are included in the copy, example which I tried:
../_module/
├── main.tf
├── .region1
│   └── info.txt
├── .region2
│   ├── .project2-1
│   │   ├── app2               (not copied even defined in include_in_copy)
│   │   │   └── f2-dot-f2.txt
│   │   └── readme.txt
│   └── project2-2
│       └── f2-dot-f0.txt
└── .region3
    ├── project3-1
    │   ├── app1
    │   │   └── .include-me-too (not copied even defined in include_in_copy)
    │   │       └── file.txt
    │   └── f1-2-levels.txt
    └── project3-2
        └── .f0
            └── f0-3-levels.txt

terraform {
    source = "${get_terragrunt_dir()}/../_module"
    include_in_copy = [ ".region2", "**/app2", "**/.include-me-too"]
}

Copied files:
.terragrunt-cache
└── 1-PIp7iO1vC2ThOeuzAfSvCHrP0
    └── nEJWciBj9VECUGGZoUkvHjACp_8
        ├── main.tf
        ├── .region2
        │   ├── project2-2
        │   │   ├── f2-dot-f0.txt
        │   │   └── .terragrunt-source-manifest
        │   └── .terragrunt-source-manifest
        ├── terraform.tfstate
        ├── terragrunt.hcl
        ├── .terragrunt-module-manifest
        ├── .terragrunt-source-manifest
        └── .terragrunt-source-version

Full example:
https://github.com/denis256/terragrunt-tests/tree/master/include_in_copy

Excellent test @denis256 ! include_in_copy with folders instead of just files seems to create yet another interesting challenge (i.e. if a .folder should be included then should its content be filtered or copied as-is?).
I get a slightly different results with my fork though - project2-2 is not copied:
.terragrunt-cache/
└── MdRM5JX6HaKNIZlQKReHBGKlgaY
    └── cOrakgg_VWg8mw2z_GNXJSCM3aA
        ├── .region2
        │   └── .terragrunt-source-manifest
        ├── .terragrunt-module-manifest
        ├── .terragrunt-source-manifest
        ├── .terragrunt-source-version
        ├── main.tf
        ├── terraform.tfstate
        └── terragrunt.hcl

I created a branch with a bunch of plain old school Fprintf statements to help with "debugging" 😊

@denis256 I made few more changes. Here is what I got when I try it with your test repo:
.terragrunt-cache/
└── MdRM5JX6HaKNIZlQKReHBGKlgaY
    └── cOrakgg_VWg8mw2z_GNXJSCM3aA
        ├── .region2
        │   ├── .project2-1
        │   │   ├── .terragrunt-source-manifest
        │   │   ├── app2
        │   │   │   ├── .terragrunt-source-manifest
        │   │   │   └── f2-dot-f2.txt
        │   │   └── readme.txt
        │   ├── .terragrunt-source-manifest
        │   └── project2-2
        │       ├── .terragrunt-source-manifest
        │       └── f2-dot-f0.txt
        ├── .region3
        │   ├── .terragrunt-source-manifest
        │   └── project3-1
        │       ├── .terragrunt-source-manifest
        │       └── app1
        │           ├── .include-me-too
        │           │   ├── .terragrunt-source-manifest
        │           │   └── file.txt
        │           └── .terragrunt-source-manifest
        ├── .terragrunt-module-manifest
        ├── .terragrunt-source-manifest
        ├── .terragrunt-source-version
        ├── main.tf
        ├── terraform.tfstate
        └── terragrunt.hcl

10 directories, 18 files

I believe this is what you'd expect based on your include_in_copy patterns. What do you think?

Hi,
looks better now will be helpful also to have a test to track that this functionality will continue to work in future

Sure thing @denis256 - test(s) for the functionality coming soon.

@denis256 I added a test that leverages your folder/file structure. Is this enough?

Ouch, the output does not look good. Will check that ...

@denis256 TerragruntExcludes requires OS path separator (e.g. \ on Windows) while the code around works with Slash. This was causing incorrect path split and so .terragrunt-cache folder not being excluded from copy resulting in recursive copy. This issue was not visible before as the paths passed to TerragruntExcludes were single-part. This PR operates on longer paths causing the issue.

Tests passed on last run


Adding shellcheck to openverse-api

Adding shell check to openverse-api repo

@MustkimKhatik Could you edit your comment to fill the Pull Request template? Thanks!

@MustkimKhatik Could you edit your comment to fill the Pull Request template? Thanks!

Sure.

Sure @dhruvkb I'll do it

@MustkimKhatik there are still some lint changes needed. Do you need help fixing those?

@MustkimKhatik there are still some lint changes needed. Do you need help fixing those?

Yes @dhruvkb , I'll do them by myself as I got the time

hey @dhruvkb, can you look into the error it detecting?

Good to go from my end 👍! Feel free to work on something else while we wait for a second approval.

Okay sure! Thanks for helping me out with it.


Versioning

I was about to write:

It would be useful if the various script could include a version command or flag.

It is probably easier to use tags. Is the repo in a state where we could tag and "release" a first version ?

It would be useful if the various script could include a version command or flag

Why is it useful? And could we use the commit hash as the version?

Is the repo in a state where we could tag and "release" a first version?

I don't see why not

Why is it useful? And could we use the commit hash as the version?

We need to know, from the logs of a run, which version was used so we know if those issues we see have been addressed already. Using the tag require to all the git information which we will likely not have in the case of a Docker container for instance.

I don't see why not

OK, so we could create a first tag already.

https://github.com/paritytech/releng-scripts/blob/master/VERSION has been added and the Docker container reponds to the new version command.


Gap in looped audio

Version

Phaser Version: 3.50.0-beta.12
Operating system: Ubuntu 20.04

Description
Was trying to get a sound to loop seamlessly, but looped audio has a gap between the stand/end of loops.
I noticed when searching that loopEndOffset in HTML5AudioManager is missing from the default sound manager.
Example Test Code
Boot.js
preload() {
    this.load.audio("player-death-loop", "assets/audio/player/death-loop.ogg");
}

Game.js
create() {
    this.playerDeathLoop: this.sound.add("player-death-loop");
}

In the relevant event
this.playerDeathLoop.play({
    loop: true,
});

Using Ogg. Tried with WAV too, same problem.

NVM, the audio file I was using was the problem. It has a small unexpected silence right at the end... >_>*


Is there any way to make wildcards permissons take priority over more specific permissions?

Description
Sometimes, behavior like wildcards permissons take priority over more specific permissions is needed in some cases.
For example, consider such a situation:
There are 3 levels of permisson groups in server: default, admin, super_admin

default is applied to common players.
admin is applied to OPs, but some vanilla commands (such as fill, setblock, summon, etc.) are disabled via Vanilla Permissions mod, in order to limit these admins' permissions.
super_admin is applied to some specific OPs. Players in this group can execute all commands without any limitation.

Clearly, there is a natural permission group track like default->admin->super_admin, which means the extension of admin permissions.
However, when I:

Set minecraft.commands.xxx (specific permissions) denied in admin
Set minecraft.commands.* (wildcard permissions) allowed in super_admin

Players who are in both admin and super-admin groups still cannot use those specific commands.
Even when I set the weight of group super_admin > admin, the wildcard permissions are still ignored.
Proposed Behaviour
I think it's better to add something like an option in config to change this default specific-wildcard permission overwrite rule.
Extra Details
No response

if you want your super_admin group to have every permission, there is no reason for you to make it inherit the permissions from your admin group

Sure, the inherit from admin to super_admin is not proper. Actually, I set these perm groups separately, but let super players have both parent groups admin and super_admin.
Generally, permissions in super_admin should override admin unconditionally, as I have given it higher weight than admin. However, the default behavior of specific permissions take priority over wildcards breaks this expectation.


Remove IexMath as a library

It was not being used or linked in the current tree, so moved the
symbols to libIex and updated exports, etc.
Signed-off-by: Kimball Thurston<EMAIL_ADDRESS>

fyi, this will have to be manually merged w/ the symbol visibility tree, I will take care of that


added the GameSessionLogger class

Pull Request Test Coverage Report for Build 992334095

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.896%

Totals

Change from base Build 991525438:
0.0%

Covered Lines:
501

Relevant Lines:
506

💛  - Coveralls


Add checksums to releases

We could consider publishing checksums of our released artifacts.
I would normally expect to provide checksums for the entire archives, not the individual binaries, although that is what was requested today on the mailing list. Given that our binaries are just launchers and all the code resides in class files, I am not sure what guarantees binary checksums give.
This is related to the fact that our packages are unsigned, which displays scary messages to Mac users (and Windows too, I think) when they install the software. The process (and cost) to fix this depends on the target operating system.
https://groups.google.com/forum/#!topic/openrefine/1g957CEbtKI

I think the downloadable artefacts are the correct things to checksum. The standard flow is download, verify checksums, install/build. Packaging signing is only tangentially related, in my mind.

This has been done in the past few releases.