Does not skip .rar part when not using .r00 naming convention

Program is not smart enough to skip rar part files, when they have a .rar extension. This forces user interaction via the "Overwrite Prompt" for each part file.
For example:
ufc.2.no.way.out.dvdrip.xvid-kyr.part49.rar
The 7zip context menu does not seem to suffer from this issue either when selecting one part file or all of them.

Perhaps switching to 7zip's built in recursive flag would solve this problem as well. See Issue #1


New version: SophiApp 1.0.97

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/113246&drop=dogfoodAlpha

@ItzLevvie


Improve error msg when endpoint fails to be created due to full policymap size

There have been reports where endpoints fail to be created (due to a Cilium API timeout) because the policymap is full. The error msg seen by the user ("Cilium API timed out") is not helpful at all if the policymap is filled up, because the API could time out for a myriad of reasons.
In one specific case, the reason why the policymap was full was due to an FQDN leak which was fixed by https://github.com/cilium/cilium/pull/17699 & https://github.com/cilium/cilium/pull/17788.
In the future, if we encounter a scenario like this again, we will at least have a specific error msg indicating the root cause of the problem.

Hi, @christarazi if possible can you please point me the piece of code. I will try to fix the error message.

Turns out this is a dup of https://github.com/cilium/cilium/issues/15864. See the linked PR. It is available since 1.10.4. Closing, apologies @chowmean, thanks for the interest! Please check out other good fist issues.


efficient_su2 & co should handle the num_qubits=1 case

Environment

Qiskit version: 1.3.0rc2
Python version: 3.11.9
Operating system: macOS

What is happening?
Calling some library functions, like efficient_su2 don't work for num_qubits=1, since the entangling gate requires 2 qubits. This should still work, but simply not add an entangling gate.
We should check this edge case for all other functions, as well.
How can we reproduce the issue?
from qiskit.circuit.library import efficient_su2

efficient_su2(1)

What should happen?
Build a circuit without CX entangling gate. This should be handled in the efficient_su2 function and adjust the internal call to n_local.
Any suggestions?
No response

I'd like to take this one on.

Great @trigpolynom! You can verify what should happen if you run the circuit-versions of these functions with a single qubit, e.g.
from qiskit.circuit.library import EfficientSU2, efficient_su2

circuit = EfficientSU2(1, flatten=True)
also_circuit = efficient_su2(1)  # should equal ``circuit``

We also need to add tests in this file and add a release note. You can check out the contributing guidelines on how to do that.
Let me know if you have any questions, I'm happy to discuss!

Something like this @Cryoris ? https://github.com/Qiskit/qiskit/pull/13523/files


tools/flow: return controller value

This can be used to validate the value after the flow is completed, or
unifying the result value with the original value.
Change-Id: If588467ee85d061cce51fcbef2ab8c0fcdd3ead8
Signed-off-by: Jean-Philippe Braun<EMAIL_ADDRESS>

This is a proposal to change the API of flow.Run to returned the value updated by the flow.
I have a use case where I want to run multiple flows, and I want to validate resulting flow value.
Moreover a some flow might depend on values produced by a previous flow so I need to use values produces by the previous flow.


python311Packages.aesedb: 0.1.4 -> 0.1.6

Diff: https://github.com/skelsec/aesedb/compare/refs/tags/0.1.4...0.1.6
Changelog: https://github.com/skelsec/aesedb/releases/tag/0.1.6
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 283143 run on x86_64-linux 1

2 packages failed to build:

netexec
netexec.dist

8 packages built:

crackmapexec
crackmapexec.dist
python311Packages.aesedb
python311Packages.aesedb.dist
python311Packages.lsassy
python311Packages.lsassy.dist
python311Packages.pypykatz
python311Packages.pypykatz.dist


Add KafkaStream

We should add a KafkaStreamFactory placed under..
stream/kafka
autoconfigure/stream-kafka
The README, pom files, project structure and code style should be the same as #6
The code itself should be similar to #3, using the same property name conventions from zipkin-collector-kafka. Don't forget tests!
https://github.com/openzipkin/zipkin/blob/master/zipkin-collector/kafka/src/main/java/zipkin/collector/kafka/KafkaCollector.java
https://github.com/openzipkin/zipkin/blob/master/zipkin-collector/kafka/src/test/java/zipkin/collector/kafka/KafkaCollectorTest.java
https://github.com/openzipkin/zipkin/tree/master/zipkin-autoconfigure/collector-kafka/src/main/java/zipkin/autoconfigure/collector/kafka
https://github.com/openzipkin/zipkin/tree/master/zipkin-autoconfigure/collector-kafka/src/test/java/zipkin/autoconfigure/collector/kafka
https://github.com/openzipkin/zipkin/blob/master/zipkin-collector/kafka/README.md

#11 has the changes.


Capture bailout symbols incrementally in one block

Capture constant and copy prop symbols for bailout takes lots of time in regexp benchmark from Octane one some low end machine, this change caches the first capture values for bailout, and reuse it when capturing value in the following bailout in the same block.
The new bailout is constructed according to the previous bailout and changed symbol value map since then.

@LouisLaf , could you please take a look?

:shipit:


Javascript error when DataTable is empty

A javascript error was displayed in firebug when there is no results found.
"TypeError: nTd is undefined
column: i"

Looks like I have the same problem. When no result found:
"Uncaught TypeError: Cannot set property '_DT_CellIndex' of undefined"

I encountered this error too but I have found a workaround..
The problem appears to be that both the original DataTables JS library and the Yii2 GridView are trying to provide a message to the user to say the table is empty.
To work around it I have created a class that inherits from DataTables and overridden the renderTableBody function with the following
public function renderTableBody() {
    $models = array_values($this->dataProvider->getModels());
    if (count($models) === 0) {
        return "<tbody>\n</tbody>";
    } else {
        return parent::renderTableBody();
    }
}
This gets rid of the "No results found." message from GridView and just outputs an empty tbody instead.
I've also passed the GridView->emptyText property to clientOptions ->language->emptyTable as this means that datatables renders the same message that GridView would have done.

@adhayward Thanks for the comment. I am busy right now and I am not dedicating to much time for this project. Could you create a pull request? I will merge the change ASAP

No Problem.
https://github.com/fedemotta/yii2-widget-datatables/pull/16


docs: add badges

Description
Adds badges to show the current version in the Terraform registry and the status of the release job.
Verification
None.
Checklist

[ ] My code follows the style guidelines of the project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have used pre-commit hook to update the Terraform documentation

:tada: This PR is included in version 1.12.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Provide the ability to change the name of a topology

I'm submitting a ...

improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

Traffic Ops
Traffic Portal

Current behavior:
Currently you cannot change the name of a topology
New behavior:
Allow the user to change the name of a topology thru the API and cascade that change to all appropriate areas. I.e. ds.toplogy
Minimal reproduction of the problem with instructions:
In TP, navigate to an existing topology and notice that the name field is disabled.
Anything else:
Changing a topology name will probably dirty the snapshot for that CDN in 2 places: the topology section and the delivery service section (if the topology is assigned to a ds)

@mitchell852 I'm guessing this will involve a database migration, since the primary key for the topology table is its name.

I believe we can actually change the PK and it auto-updates the FK references.

I can take this one.


Input:file wrong counting

//      get all the files to upload in an array
$files=Input::file('images');
//      count the number of files to upload
$files_count = count($files)
The problem I face is that even if I don't select any file to upload I still got the array $files created.
when I do dd($files) and I don;t select any file in the form I got
array:1 [▼
0 => null
]
So I found a way to overcome this issue but I would like to know if there is a simpler way:
//      count the files to upload check if the first element is null
if(count($files)==1 and $files[0]==null){$files_count=0;}else{$files_count=count($files);}
Thanks for your help.

You might want to ask this on the laravel forums http://laravel.io/forum

ok thanks


Rebrand DApp to Moloch v3

Placeholder
Logo and references to "Tribute" and "Tribute dao" should be replaced with "Moloch v3" branding.

This is done.


Include TypeScript types in this repo

Already on DefinitelyTyped, but would be nice to just drop them in here since it's so simple.

// @BendingBender

Also would love not having to enable allowSyntheticDefaultImports just for this library, but guess that might require a change in the API, so probably not worth it.

@osdiab I know, it just takes time. We're open for pull requests.

Regarding allowSyntheticDefaultImports, you can switch to the much safer flag esModuleInterop. This won't change, even after moving here you'll need to use one of the mentioned flags.

I decided that this library is so simple it's safer for me to just have the equivalent code in my own repository (with attribution) rather than having the external dep, so I'll pass for now on this - just thought I'd log it at least for posterity.


Simplify RandomSubsetImpl code

Currently, RandomSubsetImpl receives a Func<IEnumerable<T>, (T[], int)> parameter. However, both callers use s.ToArray() for the array value and one uses array.Length as the int value. It would be better to move the .ToArray() call inside RandomSubsetImpl, and add an int? parameter that can be used to evaluate the subset length (if null, then set to array.Length).

I may have an answer for this, would you assign this?  Or what process works best for you?  I am adaptable!

Assigned! Thanks.
Please note that I have updated the codebase to C#12, so you will need to do development with the preview sdk until net8 is released on 14-Nov.

Shouldn't be a problem!

Quick update, still working on this.


Parse mods from status response

This includes forgeData key in the answer and other modded cores, if they provide this information.

forgeData isn't a part of minecraft's official protocol, hence mcstatus doesn't support it. However forgeData seems to just be a part of the status response, as just an additional key. This means that it's already being obtained and is accessible, why would having a bool in the reader/writer classes help?
Mcstatus probably isn't the place to introduce these kinds of changes, as you're not expected to use these classes in your code. These classes are considered internal, and they are not a part of the public API. This means they're only expected to be used for internal functionalities, and if they're not necessary for those, they're not needed.
If you do need this kind of change, either implement it locally within your project, or consider checking out https://github.com/py-mine/mcproto, which already supports this behavior, and where the reader/writer classes are indeed a part of the public API: see the implementation (enum def, writer and reader).

Originally posted by @ItsDrike in https://github.com/py-mine/mcstatus/issues/555#issuecomment-1565999619

forgeData isn't a part of minecraft's official protocol, hence mcstatus doesn't support it.

We support modded server cores as well as vanilla one (#446, #433, etc). Although, they usually just follow the protocol, we sometimes change some things to fit their needs (#439, we didn't have a required part of request, but vanilla was fine with it, so why we would change it?).

However forgeData seems to just be a part of the status response, as just an additional key.

It's and it doesn't have documentation which makes it hard to general user to understand it (it has quite strange structure and multiple fully different versions).

These classes are considered internal, and they are not a part of the public API.

They are, but they are also often used and referenced. Both mcstatus.io and mcsrvstat.us parse forgeData property and show this information to user, so would we don't do this?

They are, but they are also often used and referenced. Both mcstatus.io and mcsrvstat.us parse forgeData property and show this information to user, so would we don't do this?}

Perhaps, however as forgeData is just a part of status, I still don't understand why a bool reader/writer is necessary. It's not like we need to read an additional packet that contains this data, we already read it as a part of status, it's essentially just another JSON object. Does it contain some bytearrays that need to be read with a buffer (or as we call it connection) reader? Or what's the reason we would need this additional bool operations?

It's and it doesn't have documentation which makes it hard to general user to understand it (it has quite strange structure and multiple fully different versions).

This sounds concerning, I don't necessarily love the idea of adding support for parsing something that might constantly end up changing with newer versions in major ways. But it depends on what these changes are, how many of them we'd need to support at a time, and other factors.

They are, but they are also often used and referenced. Both mcstatus.io and mcsrvstat.us parse forgeData property and show this information to user, so would we don't do this?

In this comment, I was talking about the Connection classes, and the bool reader/writers. These are fully internal and nobody should be using them. forgeData should be available as a part of raw of the status response class. This is actually a part of the public API already.

I've actually already written a forgeData response reader for my discord bot StatusBot linked here, it would just be a matter of making a nice interface for it here

Why do you need to transform dict object to buffer and use bytes? Why can't you just use dict?

Actually, it has quite poor documentation, but we anyway need to do our own research.

Why do you need to transform dict object to buffer and use bytes? Why can't you just use dict?

From the example code CoolCat467 sent, it seems that forgeData dict (originally received as JSON), contains some data under the "d" key, which while sent as string in the JSON, is actually interpreted as binary data, and you do indeed need the buffer classes to properly read it out (See this line in the linked file).

forgeData dict (originally received as JSON), contains some data under the "d" key

I tested it with grmpixelmon.com (Forge 1.16.5, it's a just some public server that I use to test mcstatus sometimes) and didn't get any d key anywhere. I'm confused where it comes from and what it means.

Yeah, I also didn't find any good documentation for it, do you have some docs or even source code link to the forge implementation that describes this @CoolCat467?

Yes, let me try to go find it. I was meaning to find the link to this the other day but it was getting a bit late.

Here we go, this file from forge explains everything pretty well:
https://github.com/MinecraftForge/MinecraftForge/blob/42115d37d6a46856e3dc914b54a1ce6d33b9872a/src/main/java/net/minecraftforge/network/ServerStatusPing.java

Oh, that makes everything much more cleaner... I will approve #555 after you will resolve the conversation.


NUMBERS-113: Fix JUnit dependencies in pom.xml

I'm not a JUnit expert, so I'm not sure if this is the optimal way to import both JUnit 5 and JUnit 4. But it does seem to solve the problems described in the JIRA ticket, so I'll just be bold and put this here.

I think that @grimreaper may have pushed over the original PR #47 that passed all the checks with a different revision. Hopefully it can be sorted quickly.

hrm, you're right. I thought I pushed the version with the BOM but apparently not.

@aherbert I think I fixed it now.

See 6bcc6d9a16bea265243f68b298713d10abb09224

The JUnit change is now restored in master. @Schamschi can you confirm if this has fixed your JUnit issues on your branch and close?

@aherbert Yes, it seems fixed now, I'm going to close the pull request and the JIRA ticket.


ApolloQuery crash due to the new cloneDeep methods from 'apollo-utilities'

It is a funny one :
After a simple npm update all my ApolloQuery component crashed :

After digging into dependencies and source :
3/4 days ago 'apollo-utilities' change its 'deepClone' function from a npm package 'fclone' to a custom one.
The query result come from network -> apollo -> vue-apollo, and in this process the query result is 'deepClone' somewhere but the properties from the result have one value and get/set from vue :

I hope this is clear enough
Thanks !

Nevermind, just fixed : https://github.com/apollographql/apollo-client/commit/e1f8da4ae9818f664ba7961eb6795387989bccc4

same problem here. @Hugome have you figure out versions of the packages that work together?


Update to version 2 of quick-error

This just updates quick-error to version 2. This did involve switching cause over to source and removing description since both were deprecated since rust 1.33.0 and 1.42.0 respectively.

@AltSysrq  Any chance to ever get this merged/released to avoid duplicating quick-error by updating proptest ?


Java 8 syntax not supported in actions

Using a method reference (Class::method) in an action raises an exception with Javacc 7.0.12:
org.javacc.parser.ParseException: Encountered " "::" ":: "" at line 36, column 21.
Was expecting one of:
"instanceof" ...
")" ...
"," ...
"<" ...
"?"
Are there any plans to support Java 8 in the near future?

If you use javacc 8 I think it does On Mar 26, 2023 5:52 AM, Jerome Abela @.**> wrote:
Using a method reference (Class::method) in an action raises an exception with Javacc 7.0.12:
org.javacc.parser.ParseException: Encountered " "::" ":: "" at line 36, column 21.
Was expecting one of:
"instanceof" ...
")" ...
"," ...
"<" ...
"?"
Are there any plans to support Java 8 in the near future?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

If you use javacc 8 I think it does

You think so, eh? Well, that's a very confident, authoritative answer. Well, I guess you're free to think that it does, but I just checked and it doesn't. I just looked here and here, and, scanning over the thing, it is quite obvious that there is nothing in either grammar to handle lambdas or method references. Also, one should note that the last commit on either file is from June 2021, nearly 2 years ago. Actually, the last meaningful change to the file was a patch by iponomarev from March 16, 2019. That patch did take the Java support in code actions to JDK 7 level. However, Ponomarev's changes were not applied to JJTree.jjt so you can use JDK 7 features like try-with-resources if you use plain JavaCC, but not if you use JJTree.
That is a rather strange design decision, is it not? Could you clarify that?


Custom machines / processes that use items like factory tech machines

The new applied energistics system won't let you generate energy, instead you need to build charged cells and when they run out build and place new ones


Adding EntityTables, EntityTableGroups and Frontend Entity Utilities

Closes #15.

This PR implements EntityTables and EntityTableGroups that can be used to render a list of entities. This will be important when displaying character stats, or anything that is in entity form.

I finished the changes made in #35, so I merged those changes into this branch an will be added with this merge.


[PROG] Counting Sort

Program Description
Program to implement Counting Sort algorithm.
Additional
Update the documentation (DOC.md in the 'sorting` folder)
Checklist

[x] This issue has not been mentioned in existing issues.

Hello @GigaMoksh ,
There's already a PR for this issue. 😅
Would you mind creating a new issue?
I'll assign that to you


Spurious warnings when importing MDX files

What version of Remix are you using?
^1.16.0
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce

Create new Remix app:

// remix.config.js
/** @type {import('@remix-run/dev').AppConfig} */
module.exports = {
  ignoredRouteFiles: ["**/.*"],
  // appDirectory: "app",
  // assetsBuildDirectory: "public/build",
  // serverBuildPath: "build/index.js",
  // publicPath: "/build/",
  serverModuleFormat: "cjs",
  future: {
    v2_errorBoundary: true,
    v2_meta: true,
    v2_normalizeFormMethod: true,
    v2_routeConvention: true,
  },
  watchPaths: ["./app", "./docs"],
}

Update tsconfig.json:

    "paths": {
      "~/*": ["./app/*"],
      "#docs/*": ["./docs/*"]
    },

Create MDX file /docs/introduction.mdx with the following content:

---
meta:
  title: Introduction
---

# Introduction

Hello world!

Edit content in the file routes/_index.mdx:

import Introduction from "#docs/introduction.mdx";

export default function Index() {
  return (
    <Introduction />
  )
}

Expected Behavior
$ remix dev
💿 Building...
💿 Rebuilt in 7.5s
Remix App Server started at http://localhost:3000 (http://<IP_ADDRESS>:3000)

Actual Behavior
$ remix dev
💿 Building...
The path "react/jsx-dev-runtime" is imported in ../docs/introduction.mdx but "react/jsx-dev-runtime" was not found in your node_modules. Did you forget to install it?
💿 Rebuilt in 7.5s
Remix App Server started at http://localhost:3000 (http://<IP_ADDRESS>:3000)

I just tested this on the dev branch and it works. Please reply if you're still seeing this problem. Thanks!


Remove redundant variable setting

local var=${var:=thing} is redundant, because ${var:=thing} sets var
to thing if var is unset already; the line still needs to be a
statement, though, so use : for this purpose.

Thanks; I'd previously thought that :=thing was defaulting for the occurrence, not modifying the actual variable. TIL


dual 12gb gpu gets CUDA OOM, single works

Description
Using a single 12g GPU works for training a style; however, trying to use 2x12g GPU gets OOM if GPU 0 has 11g instead of 12g available
Details
# Generic command
python main.py --no-test --base ...yaml -t --actual_resume ./models/ldm/text2img-large/model.ckpt -n ...  --gpus 0,1  --data_root ... --init_word ...

GPU 0 has ~1gb dedicated to the GUI(ubuntu desktop). This is enough to fail the model when trying to parallelize across two GPUs.
Running on GPUs 0,1
Loading model from ./models/ldm/text2img-large/model.ckpt
Global seed set to 23
initializing distributed: GLOBAL_RANK: 0, MEMBER: 1/2
LatentDiffusion: Running in eps-prediction mode
DiffusionWrapper has 872.30 M params.
making attention of type 'vanilla' with 512 in_channels
Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
making attention of type 'vanilla' with 512 in_channels
Restored from ./models/ldm/text2img-large/model.ckpt with 0 missing and 2 unexpected keys
Unexpected Keys: ['model_ema.decay', 'model_ema.num_updates']
Traceback (most recent call last):
  File "/home/ryan/lab/textual_inversion/main.py", line 613, in <module>
    model = load_model_from_config(config, opt.actual_resume)
  File "/home/ryan/lab/textual_inversion/main.py", line 38, in load_model_from_config
    model.cuda()
  File "/home/ryan/anaconda3/envs/ldm/lib/python3.8/site-packages/pytorch_lightning/core/mixins/device_dtype_mixin.py", line 128, in cuda
    return super().cuda(device=device)
  File "/home/ryan/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 680, in cuda
    return self._apply(lambda t: t.cuda(device))
  File "/home/ryan/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 570, in _apply
    module._apply(fn)
  File "/home/ryan/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 570, in _apply
    module._apply(fn)
  File "/home/ryan/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 570, in _apply
    module._apply(fn)
  [Previous line repeated 4 more times]
  File "/home/ryan/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 593, in _apply
    param_applied = fn(param)
  File "/home/ryan/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 680, in <lambda>
    return self._apply(lambda t: t.cuda(device))
RuntimeError: CUDA out of memory. Tried to allocate 114.00 MiB (GPU 0; 11.78 GiB total capacity; 1.93 GiB already allocated; 118.94 MiB free; 1.99 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

The same command with --gpus 1, will succeed training as expected.
It seems to peak around 11,039mb ... which explains why it fails on GPU 0 in this example.
Questions
Is there a small tweak I'm missing? Possibly a way to make it bind to a specific GPU(GPU 1 in this example) for the init?
Or is 12G just the absolute minimum, and this is expected in a scenario like this?
Greatly appreciate any wisdom you can share!

Or is 12G just the absolute minimum, and this is expected in a scenario like this?

I've been able to run it (with stable diffusion) on a single 12gb rtx 3060 which is also running windows (and occasionally youtube videos etc). It was a different repo but I think they copied the code exactly from here.
My changes were to set batch size to 1 and num workers to 2, in v1-finetune.yaml > data > params, and later I added accumulate_grad_batches: 4 to the last line of the yaml file in the lightning > trainer section, to try to help with the reduced batch size.

@ryanrussell How willing are you to tinker with code? You could possibly implement the improved cross attention mechanism used in the newer 'dreambooth' forks. That seems to significantly reduce memory requirements.

@rinongal

@ryanrussell How willing are you to tinker with code?

Very.
Are you referencing the xformers mod that (I believe) originated with the PR from @MatthieuTPHR this diffusers pr?
Do these types of PR's belong in your repo or in a fork? Are extra dependencies welcomed?
Is the intent in textual_inversion to stay true to the original arxiv pub or to evolve?

I did have the xformers mod in mind, yes.
Intent is to stay mostly true to the scope of the original paper.
I don't mind adding optimizations that are orthogonal to the current functionality, so optimizing memory requirements / run times is more than fine, as long as there's no harm to actual results or it's toggleable (so others still have the option to reasonably reproduce our initial results).
PRs in the repo are fine.
Extra dependencies are fine, so long as it's not something that requires some messy manual installation.

Before trying to materially change the implementation, I've been trying to do some more due diligence to understand what is happening.
As of now, running the process using EITHER GPU 0 or 1 works.
Works:

--gpus "0,"
--gpus "1,"

Does not work:

--gpus "0,1,"
2 separate processes using each GPU (GPU 0 resources still get used for the GPU 1 job)

It appears there's something in/around load_model_from_config() consumes GPU 0 resources regardless of the CLI param. There are various nested imports in conditional statements that I'm still wrapping my head around that may be culprits.
When run with two GPU's or with GPU 1, the memory demands on GPU 0 spike before/around the call to model = load_model_from_config(config, opt.actual_resume)
Below is a screenshot right around that handoff when running using --gpus "1," -- Notice how the GPU 0 memory jumped to ~8gb even though it's not supposed to be used:

This is around the stdout:
Global seed set to 23
initializing distributed: GLOBAL_RANK: 0, MEMBER: 1/1
----------------------------------------------------------------------------------------------------
distributed_backend=nccl
All distributed processes registered. Starting with 1 processes

As soon as the training begins on GPU 1, the GPU 0 memory goes back down to ~2gb. When I force-kill the training on GPU 1, GPU 0 memory goes back to ~690mb as of this run.
Summary
When assigning GPU 1, something is still using GPU 0 resources peaking at ~8gb right before training beginds, and ~1.3gb during training.
@rinongal -- I'm going to keep looking into this, if something out of my description seems obvious to you what is going on, would love any insights you may have.

Solution:
There are various model.cuda() calls, which defaults to GPU 0.
The most offensive is in load_model_from_config() in main.py
This will have zero effect on machines with only one GPU.
It may, however, cause strange side effects on multi-gpu machines if the memory is near-capacity. Likely would not OOM in a 2x24G VRAM GPU environment, but fails consistently on a 2x12G GPU config.
Either of these seem to work well for me:

Just remove the model.cuda() calls
Bind the model.cuda() to your CLI GPU(can also cause OOM...) model.to(torch.device('cuda:[id]'))

    # model.cuda()

    # Optional assignment to your preferred GPU like
    model.to(torch.device('cuda:1'))

Updating these references allows me to train with multiple GPU's and/or multiple processes with single GPU's
@rinongal -- do you have opinions on which you think would be better based on your intent?
If you like, I can try to touch up the references to model.cuda() to align them with the CLI param.

Cheers for investigating this!
If removing model.cuda() from load_model_from_config() works, I'd do that. It keeps it closest to the original LDM implementation and lets Pytorch Lightning handle most movements to the GPU.

Sent a PR with notes just removing that single model.cuda() call -- that gets us to working on 2x12GB GPU's.
The xformers and other model.cuda() calls would definitely improve memory requirements further... this seems like a good middle-ground that solve the initial problem for almost no effort. :+1:

Merged. If it solves your issue, it's good enough for now :)
Closing as resolved. Let me know if you need further help.


expose ExceptionClass only in debug mode

What this PR does:
expose ExceptionClass in error msg only in debug mode
Which issue(s) this PR fixes:
Fixes https://github.com/stargate/jsonapi/issues/578
Checklist

[x] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

Let's talk about this on daily meeting -- I am not sure if log level is a good determination for debug mode.

Let's talk about this on daily meeting -- I am not sure if log level is a good determination for debug mode.

I agree. Let's discuss making a property to control this


AttributeError: module 'tensorflow._api.v1.summary' has no attribute 'create_file_writer'

Thank you very much for reporting a bug on Talos. Before you do, please go through the below checklist carefully and make sure to prepare your bug report in a way that facilitates effective handling of the matter.
1) Confirm the below

[x] My Python version is 3.5 or higher
[x] I have searched through the issues Issues for a duplicate
[x] I've tested that my Keras model works as a stand-alone

2) Include the output of:
talos.__version__
0.6.3
3) Explain clearly what you expect to happen
Tune one hyperparameter.
4) Explain what actually happened
Error:
AttributeError                            Traceback (most recent call last)
<ipython-input-21-ea93cf9be25f> in <module>()
----> 1 h = talos.Scan(train_images.astype(np.float32), train_labels, p, demo_model, 'patchsize')

7 frames
/usr/local/lib/python3.6/dist-packages/talos/scan/Scan.py in __init__(self, x, y, params, model, experiment_name, x_val, y_val, val_split, random_method, seed, performance_target, fraction_limit, round_limit, time_limit, boolean_limit, reduction_method, reduction_interval, reduction_window, reduction_threshold, reduction_metric, minimize_loss, disable_progress_bar, print_params, clear_session, save_weights)
    194         # input parameters section ends
    195
--> 196         self._runtime()
    197
    198     def _runtime(self):

/usr/local/lib/python3.6/dist-packages/talos/scan/Scan.py in _runtime(self)
    199
    200         from .scan_run import scan_run
--> 201         self = scan_run(self)

/usr/local/lib/python3.6/dist-packages/talos/scan/scan_run.py in scan_run(self)
     24         # otherwise proceed with next permutation
     25         from .scan_round import scan_round
---> 26         self = scan_round(self)
     27         self.pbar.update(1)
     28

/usr/local/lib/python3.6/dist-packages/talos/scan/scan_round.py in scan_round(self)
     17     # fit the model
     18     from ..model.ingest_model import ingest_model
---> 19     self.model_history, self.round_model = ingest_model(self)
     20     self.round_history.append(self.model_history.history)
     21

/usr/local/lib/python3.6/dist-packages/talos/model/ingest_model.py in ingest_model(self)
      8                       self.x_val,
      9                       self.y_val,
---> 10                       self.round_params)

<ipython-input-19-b08f1577d5b4> in demo_model(x_train, y_train, x_val, y_val, params)
     74   # class_index value should match the validation_data selected above
     75   callbacks = [
---> 76       tf_explain.callbacks.GradCAMCallback(validation_class_three, 'target_layer', class_index=3, output_dir='logs/GradCam/class3expl3'),
     77       tf_explain.callbacks.GradCAMCallback(validation_class_three, 'target_layer', class_index=9, output_dir='logs/GradCam/class3expl9'),
     78       tf_explain.callbacks.GradCAMCallback(validation_class_nine, 'target_layer', class_index=3, output_dir='logs/GradCam/class9expl3'),

/usr/local/lib/python3.6/dist-packages/tf_explain/callbacks/grad_cam.py in __init__(self, validation_data, layer_name, class_index, output_dir)
     42         Path.mkdir(Path(self.output_dir), parents=True, exist_ok=True)
     43
---> 44         self.file_writer = tf.summary.create_file_writer(str(self.output_dir))
     45
     46     def on_epoch_end(self, epoch, logs=None):

/usr/local/lib/python3.6/dist-packages/tensorflow/python/util/deprecation_wrapper.py in __getattr__(self, name)
    104     if name.startswith('_dw_'):
    105       raise AttributeError('Accessing local variables before they are created.')
--> 106     attr = getattr(self._dw_wrapped_module, name)
    107     if (self._dw_warning_count < _PER_MODULE_WARNING_LIMIT and
    108         name not in self._dw_deprecated_printed):

AttributeError: module 'tensorflow._api.v1.summary' has no attribute 'create_file_writer'

5) Provide a code-complete reference
Don't think it will help. Error is supposedly related to version incompatibility, as all code runs fine without talos.

Solved. TF 2.0.0 rc0 works. My notebook  didn't use it, though, which I didn't notice.

hey i have a same problem. did you solve it?


Difference between getFormValues and formValueSelector?

getFormValues: https://redux-form.com/7.3.0/docs/api/selectors.md
connect(state => ({
  values: getFormValues('myForm')(state),
}))(MyComponent)

formValueSelector: https://redux-form.com/7.3.0/docs/api/formvalueselector.md
const selector = formValueSelector('myForm')

connect(state => ({
  values: selector(state, 'first', 'second')
}))(MyComponent)

Is one of these methods preferred to the other one?

But they are not the same.

getFormValues returns a object with all form values. (You can of course get values by navigating through the object)
formValueSelector returns a function to select (a "selector") a specific form value.

It depends on what you want to do. Do you want to select a specific form value? formValueSelector. Do you want all form values? getFormValues.
Think of  formValueSelector as getFormValue (without the plural) if that's easier.


ARROW-5815: [Java] Support swap functionality for fixed-width vectors

Support swapping data elements for fixed-width vectors.

I'm mostly against vector mutation at the api level. See my comment on the JIRA.


Re-generate self-signed certificate if domain changes

If someone was to modify spec.domain, then we need to re-generated the API certificate so that it matches the new domain name

This is done, but I haven't tested it yet

I've tested this and it is working


[WIP] Migration to the IntelliJ Platform 2.0.0

Closes https://github.com/sourcegraph/cody-issues/issues/240.
Test plan

Build the plugin (make sure your Java is version 17 or newer):./gradlew buildPlugin

Open IntelliJ 2024.2 (EAP) and install the plugin manually.

The distribution package can be found in build/distributions

Restart IntelliJ.
Verify that the Cody plugin loads without errors, and that the AI chat works.

Known problems

Exception at startup: Cannot create extension (class=com.intellij.ide.misc.PluginAgreementUpdateScheduler). The Cody plugin still works though.
Integration tests become much more flaky, something may be broken
How do I specify the tool version for the Plugin verifier?

TODO

Configure a variant build to support old versions of IntelliJ

closing in favor of https://github.com/sourcegraph/jetbrains/pull/2194


alterzorder not working

Hyprland Version
v0.33.1-48-g9ca0c7d8v0.33.1-48-g9ca0c7d8
Bug or Regression?
Bug
Description
i have little script to open certain app on certain workspace, it will open new instance if window not found using hyprctl clients, if window is found in certain workspace then it will focus to it instead using hyprctl focus. the problem is when there is other window on full screen, it will focus but it's on the bottom of that other window, i tried to use hyprctl dispatch alterzorder but it doesn't work, maybe my script is wrong, maybe i don't understand enough alterzorder i'm still not sure the param alterzorder in documentation zheight[,window] what is that mean, any help?
How to reproduce
here's the script to reproduce
usage: $PATH_TO_SCRIPT.sh [workspace_id] [window_class] [program/binary/runscript]
#!/bin/bash

workspace_id=$1
class=$2
program=$3

shift 3  # Shift the first two arguments (workspace_id and program) out

window_address=($(hyprctl clients -j | jq -r --arg class "$class" --arg workspace_id "$workspace_id" '.[] | select(.workspace.id == ($workspace_id | tonumber)) | select(.class == $class) | .address'))

echo $window_address

if [[ $window_address != "" ]]; then
  hyprctl --batch "dispatch workspace $workspace_id; dispatch focuswindow address:$window_address; hyprctl dispatch alterzorder top,address:$window_address"
else
  hyprctl dispatch workspace $workspace_id
  "$program" "$@"
fi

Crash reports, logs, images, videos
No response

Remove "hyprctl" from the hyprctl dispatch alterzorder top,address:$window_address" part in your --batch request.

Remove "hyprctl" from the hyprctl dispatch alterzorder top,address:$window_address" part in your --batch request.

my bad there, but still not working, somehow stil not wroking, the window still won't to go to the top

i'm expecting the behaviour similar to cyclenext in terms of z order on fullscreen, i'm expecting focuswindow dispatch will do that automatically but it's not, the focused window still on the bottom. but the windows is focused based on what i see in waybar window title

Ahh, I missed the fullscreen part, zorder won't help here then.
By the way, the root cause seems to be the same as in #4172 (I know the window is moved there, but similarly the switch won't happen).

alterzorder is only for floating windows


Add documentation for DeinitializerDeclSyntax and all its children

As part of #1528, documentation should be added to DeinitializerDeclSyntax and all it's children.

@swift-ci Please test


Support isModified for package beyond Maven

Currenly ORT only supports checking if a Maven package is modified by comparing hashes - this is useful feature to discover if say an R&D team has taken an FOSS package, modified it and uploaded it to say the internal artifactory.

FYI, this is the way it's currently implemented for Maven:
https://github.com/oss-review-toolkit/ort/blob/eb34b0dd11ee08ddbb537aa3c7eb54ecb7ff5bd7/analyzer/src/main/kotlin/managers/utils/MavenSupport.kt#L305-L321

pnpm and Yarn both have patching functionality, which at least indicated a modified package.

pnpm and Yarn both have patching functionality, which at least indicated a modified package.

Now that you mention it, for Conan we have implemented something similar:
https://github.com/oss-review-toolkit/ort/blob/ab808c98ed9abc2aad8e323500edfc24ba4c55aa/plugins/package-managers/conan/src/main/kotlin/Conan.kt#L324

@mmurto, regarding pnpm, the sentence

register it into your top-level manifest via the patchedDependencies field.

sounds as is ORT would more or less automatically get aware of patches packages as it would pick them up in a dedicated scope, right?

@mmurto, regarding pnpm, the sentence

register it into your top-level manifest via the patchedDependencies field.

sounds as is ORT would more or less automatically get aware of patches packages as it would pick them up in a dedicated scope, right?

Not sure if ORT creates a separate scope for patchedDependencies, but I believe it does require the dependency to be first specified in dependencies or devDependencies after which it can be patched in patchedDependencies.


Use context manager for file handles in case assertions fail

Model context manager usage in the tests.

superseded by #24


feat: add server to connectedToBrowser event

@danielhalodev @lluczo [off-topic] Are you willing to review/merge #778 and #779? I'd like to not use my fork anymore and stick to the original repository for my deployments, and think these fixes are worth to this project.


Use Jetpack Paging

Demonstrates how to use the Paging component combined with Apollo Kotlin's recent pagination facilities.
Disclaimer: it seems to work well but I must admit I'm not 100% confident everything is correct, as it took me a good while of trial/error to settle on this.
The documentation is here but to summarize:

a SessionRemoteMediator is responsible for downloading pages from the network, and to store them in the cache. In our case the storing is actually done automatically by the Apollo client.
a SessionPagingSource is responsible for querying the cache for specific pages
it is also responsible for invalidating itself when it knows the data it has returned is stale. In our case we do this by using watch on the sessions.
the UI observes the data returned by the PagingSource, via a Pager held by the ViewModel

Woops, sorry about iOS, I should have known.
About no data showing up, is your server running locally (./gradlew :server:bootRun)? On this branch I use the local server because of changes that are not published to the 'prod' one.

Good reminder that I must update github workflow so that it does some kind of build verification of iOS client

and looks like @martinbonnin has done just that 👍   https://github.com/joreilly/Confetti/pull/60/files

Working on it... Too afraid of breaking things when touching the code so at least having a CI will give a better level of confidence 🤞

@BoD want to get this through the finish line or should we close it?

Closing for now, it was a way to test/demo the cache pagination incubating features, but I don't think it's actually useful for the app (plus using something other than Jetpack Paging may make more sense for a KMP project) :).


Remember Password

Is your feature request related to a problem? Please describe.
Not a problem.
Describe the solution you'd like
Regular OSRS allows you to save the email/username for your account. Another great addiction to this would be a plugin to save your password if you want.
Describe alternatives you've considered
Save the password in notes so you can easily access it.
Additional context
None.

Storing passwords in the client is a really really bad idea. If you want quick logging in, the Login Screen plugin already allows you to paste in passwords, allowing easy use of a password manager such as KeePass.

Would be fine if you did two step than either way it doesn't matter

Storing passwords in the client is a really really bad idea.

This would be the same behavior as the official mobile client

Storing passwords in the client is a really really bad idea

This feature would mirror the current behavior of the official mobile client. Could salt the password locally.... or trust the player to secure their own PC.

Storing passwords in the client is a really really bad idea

This feature would mirror the current behavior of the official mobile client. Could salt the password locally.... or trust the player to secure their own PC.

The official mobile client doesn't store passwords

theres a plugin on the hub, "KeePassXC", it auto fills for you and if setup correctly means you only need to put the master password into keepassxc once per startup on your pc

In Linux for example it could be stored in your keyring and remembered that way user wide

Storing passwords in the client is a really really bad idea

You can encrypt the password so they are not stored in cleartext

99.99% chance this isn't going to happen. Use the keepass plugin if you want something close to remembering passwords, great thing about the plugin in you can have multiple accounts saved into keepass and clicking on them in the plugins sidebar will fill username and password for you

@Hydrox6 not sure why you thumbs down my comment, it's not like anyone else is going to know someone else's password and even if they did they wouldn't have access to it without 2step and they could change their password ontop of that using a Password manager like Bitwarden to generate a decent password for example making it a non issue. Not to mention if they client did save the password or with Mac/Linux or even WIndows if you used a password manager like Linux and Mac has built in it's not like the password wouldn't be encrypted and not stored as plain text, that would be stupid.

No matter how it's done, we would be responsible for storing the passwords. Sure, Mac and Linux have built-in keyrings, but Windows does not, at least not universally (and even Linux kinda doesn't). Given that the vast majority of users are on Windows, requiring users to download entirely external software just to use a feature in the client is just silly.
If a user already has a "decent password" with Bitwarden, then they should just use the hub plugin for it. Same with any password manager that there's a hub plugin for. Either way, it's not getting any further than an optional integration with an optional application, and it's definitely not getting into core.

Well sadly for Windows unless you install a password manager than it won't be able to but on Linux it's a no brainer to impliment

Password managers (including KeePassXC and other KeePass variants) may not be able to auto-type on Linux when using Wayland. I just ran into this on Fedora 36 and was looking for another auto-login solution, and landed here.
I can switch to Xorg, but I would prefer to see some integration with keyrings or even Hello or Credential Manager on Windows.


add 1.8.1 release to helm chart

What's the purpose of this PR
add 1.8.1 release to helm chart
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.

Codecov Report

Merging #3562 (2a8d5a2) into master (00776a2) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3562      +/-   ##
============================================
+ Coverage     50.91%   50.94%   +0.02%
  Complexity     2324     2324
============================================
  Files           447      447
  Lines         13989    13989
  Branches       1423     1423
============================================
+ Hits           7123     7127       +4
+ Misses         6377     6374       -3
+ Partials        489      488       -1

Impacted Files
Coverage Δ
Complexity Δ

.../apollo/internals/RemoteConfigLongPollService.java
77.10% <0.00%> (-1.21%)
28.00% <0.00%> (-1.00%)

...ervice/service/ReleaseMessageServiceWithCache.java
87.05% <0.00%> (+1.17%)
25.00% <0.00%> (+1.00%)

...mework/apollo/portal/component/PortalSettings.java
65.62% <0.00%> (+7.81%)
5.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00776a2...2a8d5a2. Read the comment docs.


Don't error when no environment secrets specified.

Issue
#2
What
skip looking for secrets if the section isn't found
Test
Follow the reproduction steps in the issue.
Try without an environmentSecrets section in your serverless.yml file.
Try with an environmentSecrets section but no values in that section.

Unit test

Fair, I'll look at that a bit later.

@mccredie I merged your changes into this branch (not sure if that was intended, but your PR was based on this branch, so that's what happened.)

yeah, merging into this branch was intended.  I'm not too stuck with either method, so long as it works.  The argument for always writing the file is that it is consistent.  I checked with @piohhmy and he seems to be onboard with this method too.

yeah, merging into this branch was intended.  I'm not too stuck with either method, so long as it works.  The argument for always writing the file is that it is consistent.  I checked with @piohhmy and he seems to be onboard with this method too.


[auth/gcp] allowing IAMConfig to override default Google credentials

This can be helpful for using the auth/gcp tools outside of GCP

Coverage remained the same at 42.898% when pulling 6e4cb125cd7381bcf82b3e57d4e7e3ab3a49f726 on gcp-auth-json into 859d35d894ad41c5927b513b2250a26fe247c78a on master.


This but for typed web components

Have you considered (or tried) generating typed web components instead of Svelte components?
i.e. generating types that extend from regular HTMLAttributes not svelte.JSX.HTMLAttributes etc.
I just wanted to check to see if this was a route you'd explored before running into roadblocks.
(I'm not overly familiar with SvelteJS so you might be able to tell me this is a bad idea!)

Interesting idea! I'm not well versed in web components but I'm sure the same concept can be applied.


feat(shared): Support passing env source into runtime environment helpers [SDK-773]

Description
Changes:

Support per-request env of Cloudflare workers
Add JSDoc with examples

Currently we cannot support per-request environment variables for helpers using the runtimeEnvironment helpers since we should pass the env parameter from fetch() handler down to all functions using it. An alternative way to support this is to  manually copy these values into process.env (see Cloudflare ref).
Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[x] (If applicable) JSDoc comments have been added or updated for any package exports
[x] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[x] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Compilation and load does not work.

Hi.

Does anyone know why?
Thank you.
Euclides Franco de Rezende
Brazil.

Hi,
Make sure the arduino_exec_path points to the arduino_debug.exe file and not the installation directory.

Hi,
It's the same directory:
C:\Program Files\Arduino
What about the ServerCompilerSettings.ini file? Is it in the same directory as ardublockly_run.bat? Or in the ardublockly.exe directory?
I need a Blockly converter for BASIC and I found your project.
I intend to use the BASIC language on a microprocessor (ESP8266-NodeMCU), which has an interpreter in operation and if I could do the Blockly generate source in BASIC language would be the solution.
I found people who were already interested in doing the conversion part of Blockly for the BASIC language:
Https://groups.google.com/forum/#!searchin/blockly/BASIC|sort:relevance/blockly/j21cRPTEEkk/Izu7rkOGJQAJ
He made it available on Github, but I do not know what state it is in:
Https://github.com/MikeDX/blockly-div
It would be missing just part of the source submission for ESP8266Basic (https://www.esp8266basic.com/). If the syntax is Ok.
There are differences between the Arduino and ESP8266 that need to be observed: pins, ports and utilities of each of the modules or hardware extensions to be used.
What's all this for?
Answer: So that the ESP8266 can be programmed via WiFi and not by cable, or any type of electrical connection, only by air.
I would like to know your opinion on this? Since you have much more experience than I do in this environment.
Thank you.

Hi @euclas,
Just to confirm, your settings file has this exact entry?
arduino_exec_path = C:\Program Files\Arduino\arduino_debug.exe

And yes, the ServerCompilerSettings.ini file should be in the same directory as ardublockly_run.bat.
About the project in itself, I've never used BASIC before and don't really know anything about ESP8266Basic either, but as long as it has an interpreter built-in that could be feed the generated code then I think it should be possible.

Hi Carlos.
Exactly:
[image: Imagem inline 1]
I would like to test at least the basics, in the Arduino IDE (COM11, and
Arduino Mega 2560) works correctly.
Thank you again
Euclides.

HI @euclas, do you still have problems getting Ardublockly to use the Arduino IDE?


Added UserAvatar in userlist and users page

Proposed Changes

Fixes #8869
Added avatar in userlist and users section

@ohcnetwork/care-fe-code-reviewers
Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

Done!

@nihal467 we are rebuilding that UI, unless we have functional issues lets move ahead.

LGTM

@rithviknishad @bodhish @nihal467
How many story points will I get for this..?


Change "elderly" to "older adults"

Describe the bug
Reported issues with the word "Elderly" in the census demographic data. Change to "Older adults".
To Reproduce
Steps to reproduce the behavior:

Go to 'explore the map / any census tract'
Click on 'age'
See error

Expected behavior
Update string.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

add to content doc to track


Rewrite layernorm for tf

The current implementation for layernorm in tf requires the scale and bias mid-way through the equation, whereas the onnx implementation does not. We can either rewrite layernorm to be equivalent to onnx before fusion, or we can optimize the layernorm device function to include the scale and bias.

Will revisit after later release. Will not implement.


Package Updates

I cloned this repo and installed packages.  npm reports several outdated packages:
found 36 vulnerabilities (20 low, 3 moderate, 13 high) in 1977 scanned packages
  run `npm audit fix` to fix 21 of them.
  15 vulnerabilities require manual review. See the full report for details.

Will there be any updates to resolve this?  Or should I submit a PR?

I updated the dependencies as far as there were no compatibility issues


Enhanced monitoring

Enable enhanced monitoring option.

It's great having you contribute to this project Welcome to the community :nerd_face: :rocket:Soon one of our maintainers will review it and provide you with feedback/suggestions. If you think it's something urgent, feel free to reach out Md Shamim on LinkedIn. Please star ⭐ this repo to show us support.Happy, Open Source!


[Bug]: JetSnack images don't load

Is there an existing issue for this?

[X] I have searched the existing issues

Is there a StackOverflow question about this issue?

[X] I have searched StackOverflow

Is this an issue related to one of the samples?

[X] Yes, this is a specific issue related to this samples repo.

Sample app
Jetsnack
What happened?
Images fail to load. It looks like there's an error with the host rather than the app though. Example url: https://source.unsplash.com/pGM4sjt_BdQ
Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Seems to be resolved now


Updates to selectize menu css and analytics capturing

@versatilehuman Are you okay if I push these updates to production? This encompasses the fixes for https://github.com/smartchicago/trailsy/issues/193 and https://github.com/smartchicago/trailsy/issues/196 along with some additional analytics event tracking.

Looks good, let's do it.

These updates are now live.

JS changes look good, I'm not getting newguts.css updates (cleared cache, tried private browser) from 061a518.

Try now
On Wed, Mar 21, 2018 at 5:11 PM, Ryan Lothian<EMAIL_ADDRESS>wrote:

JS changes look good, I'm not getting newguts.css updates (cleared cache,
tried private browser) from 061a518
https://github.com/smartchicago/trailsy/commit/061a5187430d3e01385cb0776bfc48c13f15b572
.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/smartchicago/trailsy/pull/199#issuecomment-375112850,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABhQwS5K-a2cz5UPnMgaPfT_EKdEQ7_Zks5tgtABgaJpZM4SyshY
.

Looks good.


Running hugo server outputs public folder

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.123.0-3c8a4713908e48e6523f058ca126710397aa4ed5+extended darwin/arm64 BuildDate=2024-02-19T16:32:38Z VendorInfo=brew

Does this issue reproduce with the latest release?
Yes
Details
Running hugo server on version 0.123.0 outputs the public folder into the project folder. Previous versions would only do this when running hugo on its own. This also occurs when using the -D draft flag hugo server -D.

This is the expected behavior with v0.123.0.  If you wish to render to memory use the --renderToMemory command line flag.


Dynamic Pricing for Bulk Coretime Sales

RFC-1 asks for another RFC that specifies the pricing function of Bulk Coretime Sales. RFC-6 is a proposal to apply a dynamic pricing function that has several levers for governance to adapt the pricing curve to changing market conditions.
This RFC follows a proposal in the Polkadot Forum here and an invitation by Gavin Wood to submit an RFC here.

an invitation by Gavin Wood to submit an RFC https://github.com/polkadot-fellows/RFCs/pull/1#issuecomment-1627626753.

FWIW, the rules in #2 (currently being voted on as Fellowship Referendum 7) state that anyone may open an RFC , invitation or not :)


fix 0d in decimal.md

Issue #, if available:
Description of changes:
minor fix to the docs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

While we appreciate your interests in the project, the use of the letter d is actually not a problem here. If you refer to the Ion 1.0 specification, you can see that decimal uses d to separate the coefficient from the exponent in Ion text. Removing the d leaving only an integer actually represents a different data type (an integer), and swapping the d for an e likewise changes the data type from decimal to float. Please see https://amazon-ion.github.io/ion-docs/docs/spec.html#real-numbers for details.

I see. Thanks.


#98 Self Hosting

I've published a #98 Self Hosting version of unpkg to npm here:
https://www.npmjs.com/package/unpkg-server
I've been running it in my own organisation against a private npm registry (nexus) and it seems pretty stable.
These are the changes I used to produce a version of server.js that can be configured using a few CLI flags.
I've changed the build process a bit which I'm sure would break the unpkg build process, so this PR is primarily to discuss the approach and what would need to change before this could potentially be merged.

Added a flag to disable the integration with cloudflare: ENABLE_CLOUDFLARE
Moved several process.env options to be read at runtime instead of at build time
Added a CLI library minimist for reading/setting config flags
Documented the available configuration options
Support for ports other than 443
Updated package.json to support publishing to npm

@mjackson will you merge this branch? @KevinSheedy thanks a lot!

I switched from running straight-up couchdb to serving it from verdaccio and this fixes my issue.


Autocomplete for VSCode MATLAB terminal

Is your feature request related to a problem? Please describe.
I would like to suggest if MATLAB terminal can autocomplete codes added in MATLAB path by pressing TAB key.
Describe the solution you'd like
For exmaples, when I used MATLAB terminal in VSCode it autocompletes the code or gives suggestions which is the same as with MATLAB GUI Desktop Command Window.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Thanks for the request!
I believe this is the same as #104 , so I am going to close this as a duplicate of that issue. If that issue does not capture your request accurately, please feel free to add a comment!


HDDS-4006. Disallow MPU on encrypted buckets.

What changes were proposed in this pull request?
Disallow MPU operation on Encrypted buckets when KMS is configured.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4006
How was this patch tested?
Added a UT

The patch LGTM +1.


Support branch names containing forward slashes

Thanks for this tool!
Closes #180. Please let me know if there's any adjustments you'd like me to make to code, comments, commit messages, etc. for this to be an acceptable contribution.

Will also find some time to cut a release since it's been a while.

Thanks! I'm probably able to open a PR for #170 as well, likely sometime today.

Will also find some time to cut a release since it's been a while.

@rraval Thanks! I'm probably able to open a PR for #170 as well, likely sometime today.


integrity isn't added to assets in loadable-stats.json

🐛 Bug Report
I'm having the same problem as this issue: https://github.com/gregberge/loadable-components/issues/344
However a PR Was merged which solved this issue and in the past it worked, for some reason it now
doesn't work at all.
To Reproduce
Steps to reproduce the behavior:
1- install webpack-subresource-plugin and setup loadable components for SSR(webpack-plugin et all)
2- add the plugins in webpack config like this:
            new SriPlugin({
                hashFuncNames: ["sha256"],
                enabled: !isDevelopment,
            }),
            new LoadablePlugin(),

also add crossOriginLoading: "anonymous" to webpack.output.
3- build the bundle, in the generted loadable-stats.json you'll see no integrity attribute.
4- in the server bundle call chunkExtractor.getScriptTags({ crossorigin: "anonymous" }), you'll notice no integrity attribute
Expected behavior
chunkExtractor.getScriptTags(), chunkExtractor.getStyleTags(),
chunkExtractor.getLinkTags() would set integrity attribute.
npx envinfo --system --binaries --npmPackages @loadable/component,@loadable/server,@loadable/webpack-plugin,@loadable/babel-plugin --markdown --clipboard output:
## System:
 - OS: Windows 10 10.0.18363
 - CPU: (8) x64 Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
 - Memory: 1.27 GB / 7.89 GB
## Binaries:
 - Node: 14.0.0 - C:\Program Files\nodejs\node.EXE
 - npm: 6.14.4 - ~\AppData\Roaming\npm\npm.CMD

Other Information:
webpack version: 4.43
loadable-components version: 5.12
webpack-subresource-plugin version: 1.4.0

@abnud1 i am seeing this issue as well. were you able to figure out why this happens?
## System:
 - OS: macOS 11.4
 - CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
 - Memory: 61.25 MB / 16.00 GB
 - Shell: 5.8 - /bin/zsh
## Binaries:
 - Node: 14.16.0 - /usr/local/bin/node
 - Yarn: 1.22.10 - ~/my-app/node_modules/.bin/yarn
 - npm: 6.14.11 - /usr/local/bin/npm
 - Watchman: 4.9.0 - /usr/local/bin/watchman

Other Information:
webpack version: 5.33.2
loadable-components version: 5.14.2
webpack-subresource-integrity version: 1.5.2

i have created https://github.com/gregberge/loadable-components/pull/803 in attempt to fix this issue

Published as a part of:

<EMAIL_ADDRESS><EMAIL_ADDRESS>


✨(react) add enableSorting support on DataGrid

Previously it was only available at column level. This way we will be able to disable sorting on all columns at once.

Yeaaah omg you ship it so fast 🤩
Small question, should we refactor this line to disable sorting at table level instead of setting it for each column? Wdyt?

Yeaaah omg you ship it so fast 🤩 Small question, should we refactor this line to disable sorting at table level instead of setting it for each column? Wdyt? My suggestion might not be appropriate

Yep it's done :)


PeMS detector health diagnostics: too few data samples

Implement Test number 2 from the PeMS User Guide:

Data sources: 30 second raw data, VDS metadata (controller, station, detector)

@ian-r-rose thinks this issue (and the whole project) could be a good use case for dbt incremental models. See docs here and here

I don't think this is done yet, we still need to get #96 through review and in main, no?

If I am understanding correctly, even though I built the relevant model for this issue you want to keep this issue open until Ken merges his PR? @ian-r-rose

Yes, I don't think issues are considered done until they are merged to main.

That makes sense to me, thank you for clarifying!
On Tue, Mar 19, 2024 at 10:59 AM Ian Rose @.***> wrote:

Yes, I don't think issues are considered done until they are merged to
main.
—
Reply to this email directly, view it on GitHub
https://github.com/cagov/caldata-mdsa-caltrans-pems/issues/79#issuecomment-2007811869,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALJFWSVWMGR6JVEPWVIEWELYZB4G3AVCNFSM6AAAAABDTVWKFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXHAYTCOBWHE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Monospace menubar

This PR addresses issue #56 by introducing three new options:
# Font size for menu bar
font-size = 12.0

# Font family for the menu bar items
# Use the Font Book to find fonts
font-family = 'JetBrainsMono Nerd Font Mono'

# Possible values: icon|horizontal_full|horizontal_min
# icon: shows only the current workspace
# horizontal_full: shows all workspaces, with the current one highlighted
# horizontal_min: shows all workspaces with open windows,and the current one
workspace-indicator-style = 'icon'

To accomplish this, I had to rewrite all menu bar items to use AppKit, as pure SwiftUI lacks the capability to display arbitrary views.
Here are some pictures demonstrating the feature in action:

Can we get a video demo? This seems pretty interesting

https://github.com/user-attachments/assets/4041861f-58e7-4ae1-9c6e-9d03ecac1150
Emojis are pushed to the end, which is the same behavior that exists.

Also see: https://github.com/nikitabobko/AeroSpace/issues/711#issuecomment-2541128213


pythonPackages.mox3: disabling tests

Motivation for this change
Fixing https://hydra.nixos.org/build/98975821
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build pythonPackages.mox3 python3Packages.mox3

The test requirements don't look too weird - could we probably just add them to checkInputs and keep running tests?

The problem is the test dependencies are not packaged in nixpkgs, therefore the test is trying to download them from pypi. Sadly this package doesn't have a maintainer and I don't want to put in the effort to package these all just to fix this one test.

Fixing test dependencies is indeed the preferred solution, however, as you're not the maintainer I can understand you don't want to add those expressions. Here users of the package (including reverse dependencies) may want to take a role https://github.com/NixOS/ofborg/issues/387.

@FRidh that's a good suggestion, but in this case this package is a dependency of none.

Perfect, then let's not spend any time on it. Whoever chooses to use this package can take that responsibility.


merge from arlac77/npm-package-template-esm-only

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 -x 'tests/**/*.mjs' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp

.travis.yml

chore(travis): merge from template .travis.yml

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   96.24%   96.24%
=======================================
  Files           6        6
  Lines         532      532
  Branches       74       74
=======================================
  Hits          512      512
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e645a...ab649a0. Read the comment docs.

:tada: This PR is included in version 1.5.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add content length mismatch check on handling HEADERS frame and CONTINUATION frame

Cherry-picked to v9.2.x


improve stats calculate cost

What type of PR is this?

[ ] API-change
[ ] BUG
[ ] Improvement
[ ] Documentation
[ ] Feature
[ ] Test and CI
[ ] Code Refactoring

Which issue(s) this PR fixes:
issue #
What this PR does / why we need it:

@xzxiong Thanks for your contributions!
Here are review comments for file pkg/config/configuration.go:
Title: Improve stats calculate cost
Body:

This pull request aims to improve the calculation of stats cost.
It includes changes to the pkg/config/configuration.go file.

Changes made in pkg/config/configuration.go:

Line 602: Added a comment explaining the purpose of DisableStmtAggregation and its relationship with LongQueryTime and SelectAggrThreshold.
Line 685: Added a condition to check if DisableStmtAggregation is false. If true, it calculates the value of LongQueryTime based on SelectAggrThreshold.

Overall, the changes seem to be focused on improving the understanding and functionality of the code related to stats calculation. However, there are a few issues that need addressing:

Inconsistent comment style: The comment on line 602 uses a different style than the rest of the comments in the file. It should be consistent with the existing comment style.

Suggestion: Update the comment on line 602 to match the style of the other comments in the file.

Lack of explanation for the purpose of the changes: The pull request description does not provide a clear explanation of why these changes are necessary or what problem they are addressing. It would be helpful to include more context and explanation in the pull request description.

Suggestion: Provide a detailed explanation in the pull request description about the problem being addressed and how these changes improve the code.
Optimization suggestions:

Consider adding more inline comments to explain the purpose and functionality of the code changes.
Ensure that the code changes adhere to the existing code style and formatting guidelines.
Run tests to ensure that the changes do not introduce any regressions or errors.
Consider providing examples or test cases to demonstrate the expected behavior of the code changes.

Here are review comments for file pkg/config/configuration_test.go:
Review:
Title
The title of the pull request is "improve stats calculate cost". The title is not very descriptive and does not provide enough information about the changes being made. It would be better to provide a more specific and concise title that accurately reflects the purpose of the pull request.
Body
The body of the pull request is incomplete. It only contains a checklist for the type of PR and a placeholder for the issue number. It would be helpful to provide more information about the changes being made, the problem being addressed, and the motivation behind the changes.
Changes
The changes made in the pull request are focused on the file pkg/config/configuration_test.go. The changes include adding a new test function TestObservabilityParameters_SetDefaultValues1 and a test table with multiple test cases. Each test case has a prepare function that initializes an ObservabilityParameters struct and a check function that verifies the values of the struct after calling SetDefaultValues.
Problems:

Lack of comments: The new test function and the test table do not have any comments explaining what they are testing and why. It would be helpful to add comments to improve code readability and maintainability.

Inconsistent formatting: The formatting of the test table is inconsistent. Some test cases have a space before the colon (:) while others do not. It would be better to have consistent formatting throughout the test table.

Lack of error handling: The code does not handle any errors that may occur during the test. It would be good to add error handling and provide meaningful error messages in case of failures.

Magic numbers: The code uses magic numbers like 200 and 0.2 without any explanation. It would be better to use named constants or variables to make the code more readable and maintainable.

Redundant code: The code includes redundant assertions in the check functions. For example, the require.Equal assertions are unnecessary because the values being compared are already set in the prepare function. It would be better to remove these redundant assertions to simplify the code.

Optimization suggestions:

Add comments: Add comments to the new test function and the test table to explain what they are testing and why.

Consistent formatting: Ensure consistent formatting in the test table by either always including a space before the colon or always omitting it.

Error handling: Add error handling to the test function and provide meaningful error messages in case of failures.

Use named constants or variables: Replace magic numbers with named constants or variables to improve code readability and maintainability.

Remove redundant assertions: Remove redundant assertions in the check functions to simplify the code.

Improve pull request description: Provide a more detailed description in the pull request body that explains the problem being addressed and the motivation behind the changes.

Here are review comments for file pkg/frontend/mysql_cmd_executor.go:
Title: improve stats calculate cost
Body: The pull request aims to improve the calculation of statistics in the Stats method of the marshalPlanHandler struct. It also includes some code refactoring and optimization.
Changes made in pkg/frontend/mysql_cmd_executor.go:

Added a new field query of type *plan.Query to the marshalPlanHandler struct.
Updated the NewMarshalPlanHandler function to assign the query field with the value of plan.GetQuery() if plan is not nil.
Added a check for longQueryTime and only build the JSON plan if the time since the request exceeds the longQueryTime.
Updated the Stats method to calculate the statistics based on the query field instead of the marshalPlan field.

Overall, the changes aim to improve the efficiency of calculating statistics and avoid unnecessary calculations when not needed.
Review:

Inconsistent use of variable names: The variable options is used inconsistently in the Stats method. It is declared as options := &explain.MarshalPlanOptions, but then used as options in some places and &options in others. It would be clearer to consistently use options throughout the method.

Redundant assignment in NewMarshalPlanHandler: In the NewMarshalPlanHandler function, the query field is assigned with the value of plan.GetQuery() twice. It can be simplified by assigning the value directly to the field without the need for the query variable.

Inefficient calculation of statistics: The current implementation of the Stats method calculates the statistics by iterating over all the nodes in the query and making multiple calls to explain.GetStatistic4Trace and explain.GetInputRowsAndInputSize. This can be optimized by calculating the statistics in a single pass, avoiding redundant calculations.

Unused import: The import statement for plan2 is not used in the file and can be removed.

Suggestions:

Update the variable name in the Stats method to consistently use options instead of &options.

Remove the redundant assignment of the query field in the NewMarshalPlanHandler function.

Optimize the calculation of statistics in the Stats method by iterating over the nodes in the query once and calculating the statistics in a single pass.

Remove the unused import statement for plan2.

By addressing these suggestions, the code will be more efficient and maintainable.
Here are review comments for file pkg/sql/plan/explain/explain_query.go:
Review:
Title: improve stats calculate cost
The title of the pull request is not very clear and does not provide much information about the changes being made.
Body:
The body of the pull request is incomplete and does not provide any context or explanation for the changes being made. It includes a checklist for the type of PR, but it is not filled out. It also includes a placeholder for the issue number that this PR fixes, but it is not filled out either. The body should be updated to provide a clear description of what this PR does and why it is needed.
Changes:
The changes made in the pull request are focused on a single file: pkg/sql/plan/explain/explain_query.go. The changes include adding a new comment to the StatisticsRead method, deprecating it and suggesting to use explain.GetInputRowsAndInputSize instead.
Suggestions:

Title: The title should be updated to provide a clear and concise description of the changes being made. For example, "Deprecate StatisticsRead method in explain_query.go".

Body: The body should be updated to provide a clear description of what this PR does and why it is needed. It should also include the issue number that this PR fixes, if applicable.

Changes: The changes made in the pull request seem reasonable, as they deprecate a method and suggest using a different method instead. However, it would be helpful to include a comment in the code explaining why the StatisticsRead method is being deprecated and what benefits the new method provides.

Optimization: Since the changes are focused on a single file, it would be helpful to include a diff of the entire file, rather than just the changed lines. This would provide a better understanding of the overall changes being made.

Overall, the pull request needs more information and context in the title, body, and code changes. Providing a clear description of the changes being made and the reasons behind them will help reviewers understand the purpose of the pull request and provide more meaningful feedback.
Here are review comments for file pkg/sql/plan/explain/marshal_query.go:
Title: Improve stats calculate cost
Body:

This pull request aims to improve the calculation of stats cost.
It adds two new functions: GetStatistic4Trace and GetInputRowsAndInputSize.
The GetStatistic4Trace function retrieves statistics for tracing purposes.
The GetInputRowsAndInputSize function returns the input rows and input size for a given node.

Changes:

Added import statement for statistic package.
Added GetStatistic4Trace function to calculate statistics for tracing.
Added GetInputRowsAndInputSize function to retrieve input rows and input size.
Modified GetStatistics function to use the new functions for calculating statistics.

Problems:

Lack of context in the pull request title and body: The title and body of the pull request do not provide enough context about the specific problem being addressed or the motivation behind the changes. It would be helpful to include more information about the issue being fixed or the improvement being made.

Suggestions:

Provide a more descriptive title that clearly states the purpose of the pull request, such as "Improve calculation of stats cost for query execution".
Expand the body to explain the problem with the current stats calculation and why it needs improvement. This could include details about performance issues, inaccuracies in the current calculation, or any other relevant information.

Inconsistent formatting: The changes made in the pull request have inconsistent formatting. Some lines have extra spaces before the import statement, and some lines have inconsistent indentation.

Suggestions:

Ensure consistent formatting throughout the code changes. This includes consistent indentation, spacing, and line breaks.

Lack of comments or documentation: The new functions GetStatistic4Trace and GetInputRowsAndInputSize lack comments or documentation explaining their purpose, parameters, and return values. This makes it difficult for other developers to understand and use these functions effectively.

Suggestions:

Add comments or documentation to the new functions, explaining their purpose, parameters, and return values. This will make it easier for other developers to understand and use these functions correctly.

Redundant return statement: The GetStatistic4Trace function has a redundant return statement at the end. Since the function returns a value of type statistic.StatsArray, the return statement at the end is not necessary.

Suggestions:

Remove the redundant return statement at the end of the GetStatistic4Trace function.

Unused constants: The constants S3IOInputCount, S3IOOutputCount, and Network are defined but not used in the code changes. This adds unnecessary clutter to the codebase.

Suggestions:

Remove the unused constants to improve code readability and maintainability.

Optimizations:

Consider optimizing the calculation of statistics by using more efficient algorithms or data structures, if applicable. This could help improve the performance of the stats calculation process.
Consider adding unit tests for the new functions to ensure their correctness and to provide a safety net for future changes.

Here are review comments for file pkg/util/trace/impl/motrace/report_statement.go:
Title: improve stats calculate cost
Body: This pull request aims to improve the calculation of stats cost.
Changes made in pkg/util/trace/impl/motrace/report_statement.go:

Line 123: The condition for filtering statement info has been modified. The previous condition checked if the duration of the statement was less than a certain threshold, while the new condition checks if the duration is less than or equal to the threshold.

Review:

The title of the pull request is not very descriptive. It would be better to provide more specific information about what aspect of the stats calculation is being improved.

Suggestion: Update the title to something like "Improve calculation of stats cost for specific statement types".

The body of the pull request is incomplete. It does not provide any explanation of why the improvement is needed or what problem it solves. It also does not mention any related issues that this pull request fixes.

Suggestion: Provide a detailed explanation of why the improvement is necessary and how it benefits the codebase. Additionally, mention any related issues that this pull request addresses.

The changes made in the code seem reasonable. The modification in line 123 improves the filtering condition by including statements with durations equal to the threshold.

Optimization suggestion: Consider adding comments to explain the purpose of the filtering condition and the significance of the selectAggrThreshold value. This will make the code more understandable for future developers.
Overall, this pull request addresses a specific improvement in the stats calculation. However, the title and body of the pull request need to be more informative and provide a clear explanation of the problem being solved and the benefits of the improvement. Additionally, adding comments to the code changes will enhance code readability.


PHP

https://sendgrid.com/docs/Integrate/Code_Examples/Webhook_Examples/php.html
Line 10 in the code example should be     $attachment = $_FILES['attachment' . $i]; not     $attachment = $_FILES['attachment' + $i];

thanks for the feedback! this is a great catch. updates for this are in PR #3563


[$250] Request Money - Text in the compose box changes from "Say hello" to "Write something" & vice versa

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Login with any account
Click on FAB button/Request money or Split bill
Сomplete the action
Pay attention to the text in the input field

Also,

Click on FAB button/New chat
Select new user with no previous chat
Pay attention to compose box
Placeholder text changes

Expected Result:
The text in the input field shouldn't changes
Actual Result:
The text in the input field changes from "Say hello" to "Write something." from "Say hello" to "Write something."
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/193309858-87395bdb-d279-43ef-a283-ed04c9e244f0.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Not a critical bug, looking it later

I think this is more general issue and also occurs when -

Click on FAB button/New chat
Select new user with no previous chat
Pay attention to compose box
Placeholder text changes

Proposal
The issue here is that while the chat is loading, our fallback value is "Say hello"
Now we have two options:
Either change the fallback text to Write something
Or completely delete the fallback value so it is an empty string and after loading is finished display the proper value
That would be done here.
https://github.com/Expensify/App/blob/6551eb9d07f54c222bd6cb7411b7613f3ccd03b4/src/pages/home/report/ReportActionCompose.js#L244-L258
Like this:
// Waiting until ONYX variables are loaded before displaying the input place holder
        if (_.isEmpty(this.props.reportActions)) {
            return '';
        }

Proposal
RCA

This happens because in our code base we have added validation to check if isEmptyChat which basically returns the length of this.props.reportActions and if chat is empty we are returning 1 as even empty chat reportActions object will be  containing one record of creating

Text in the input field changes from "Say hello" to "Write something." because when we are updating a reportActions at particular moment  reportActions length would be 0 empty so we need to add one more validation to check if  reportActions is not 0

        if (this.isEmptyChat() && _.size(this.props.reportActions) !== 0) {
            return this.props.translate('reportActionCompose.sayHello');
        }

https://github.com/Expensify/App/blob/44bf1ffc491cd1e99258ddbe07823a99b80e9aad/src/pages/home/report/ReportActionCompose.js#L253-L255

Went through the proposals and @dhairyasenjaliya's proposal here looks good to me.
@MonilBhavsar All yours.
🎀 👀 🎀
C+ reviewed

@dhairyasenjaliya could you please check if this issue use case is also fixed- https://github.com/Expensify/App/issues/11471#issuecomment-1271485274

@dhairyasenjaliya could you please check if this issue use case is also fixed- #11471 (comment)

I did check this condition now, so basically, here we are adding a conditional check when reportAction is not empty at that time we display Say Hello, but if we want to add this condition then we should probably add a condition whereby if reportAction is blank at that time we need to return placeholder as empty since only after data is loaded we can identify the type of placeholder (E.g Say Hello/Write something)

@MonilBhavsar @dhairyasenjaliya I am not able to reproduce this in a general scenario. Here's the video from staging. Am I missing something on the reproduction steps?
https://user-images.githubusercontent.com/3069065/196001475-20c8b290-6f7e-49fd-9665-8df7203ac3d4.mp4

yeah Request a money I am aware but not with New Chat as mentioned in the GH body. Hence, clarifying.

(if you check the video), I am trying a very random email that don't exist in the system

Hmm, I'm not also able to reproduce now.
@kbecciv could you please confirm if this issue is still reproducible. Thank you!

@MonilBhavsar Checking with team, will update you shortly

@MonilBhavsar Issue is still reproduced with build <IP_ADDRESS>
https://user-images.githubusercontent.com/93399543/196500038-c8ff1eac-6052-48e9-9849-50921e336efd.mp4

https://www.upwork.com/ab/applicants/1582488161449332736/job-details

Thanks!
Yes, reproducible with request money flow. Waiting for proposals...

@MonilBhavsar https://github.com/Expensify/App/issues/11471#issuecomment-1271544517 this proposal is for request money flow can you confirm @mananjadhav

@MonilBhavsar Just for request flow, I shortlisted a proposal if you check the comment here

Thanks, had a look.
When we request from a completely new account, the transition still happens, but I think that is because of a new reportAction is added at that moment.

@MonilBhavsar Any updates on this one?

Quick bump on this @MonilBhavsar

Proposal looks good to me. let's implement it

@dhairyasenjaliya This PR is in draft for a few days. Can we please have it closed soon? Can you please send us an update on this one.

I will only be able to check this tomorrow. @kbecciv Is this still reproducible? I am guessing this will go through KI today/tomorrow.

You're right @dhairyasenjaliya.
@MonilBhavsar @kbecciv I am not able to reproduce this anymore on staging. Can you confirm once? I think we need to hold this, until 1-2 KI tests.

Checking now, update you shortly

Issue is still reproducible
https://user-images.githubusercontent.com/93399543/200344779-9c7026ab-1473-441a-afcb-ddb0082d8a7c.mp4
.

Okay thanks for the comment @dhairyasenjaliya.
Based on the previous comment, this is still open for proposals. @slafortune @MonilBhavsar can we please add Help Wanted tag?

Yes 👍
@dhairyasenjaliya feel free to propose the solution again

Waiting for proposals.

I tried reproducing the issue and looks like it is reproducible with account having higher number of chats and messages.

Job posted - https://www.upwork.com/ab/applicants/1592579987018907648/job-details

Hey @MonilBhavsar can you maybe provide the login credentials of the account? that makes sense because those accounts would have reports that take longer to load.
I can take this one on, have a solution in mind. I feel like this exact situation is what isLoadingReportActions is for.

Not able to repro this on staging or production.

@marcaaron are you using accounts with very large reports?

What does "very large reports" mean?

Actually now that you mention it, I'm not really sure what they were talking about since we paginate loading report actions. But I'm getting this from here

I think maybe whatever was causing it is not happening anymore? Can you try to reproduce on staging and production to validate what I'm seeing?

cc @MonilBhavsar, since I don't have access to those test accounts can you try to repro again? Since the last time you tried a number of deploys have went out, so perhaps something has changed.

Hey @MonilBhavsar can you maybe provide the login credentials of the account? that makes sense because those accounts would have reports that take longer to load.

TBH I just used my original expensify.com account and encountered this. I used my expensifail.com account (less chats) and didn't see the bug. So that led me to this belief.

I tested right now and was able to reproduce on my expensify account.

I think it must be impacting high traffic account, because in the following block we check:
https://github.com/Expensify/App/blob/3528ad556579f3048eb91aa5ec02a2e98b35229b/src/pages/home/report/ReportActionCompose.js#L255-L261
which consists of the check:
return _.size(this.props.reportActions) === 1;

reportActions is passed all the way from ReportScreen. Hence while the reportActions aren't loaded it shows Say Hello.
Question from first principles: why do we have two placeholders? Any specific need for the same between an empty/existing chat?

not overdue

I investigated this issue today, Root cause seems like - When we create IOU report and navigate to a report (chat), we have an IOU report as a prop in ReportScreen component and thus isLoadingInitialReportActions becomes false and we render the ReportFooter as well as ReportActionCompose. In fact it is wrong, we haven't loaded initial report actions, we just have one IOU report as a reportAction and we render the screens.
I believe these are steps to surely reproduce the issue -

Signout (So Onyx is cleared and we'll be required to fetch reportActions)
Have two chats A and B with some good number of chats
Navigate to chat A
From + option, request a Money from Chat B
Keep an eye on compose box and see the text changing

I'l revisit again...

why do we have two placeholders? Any specific need for the same between an empty/existing chat?
@mananjadhav sorry I don't know the reason behind it.

PR is in review to have only placeholder
And new bug reported to create a new followup issue to fix root cause

@MonilBhavsar This doesn’t need C+ review ?

Sorry forgot, requested your review.

PR is merged and followup issue to fix the root cause is here https://github.com/Expensify/App/issues/13074

Offer sent to @mananjadhav 👍

PR is deployed to production and follow up issue is created
@slafortune I think we can close this now?

@slafortune can we please issue the payment to C+ here

Paid!