fix: do not show code editor outside of presenter mode

proposed by user @15921483570 in linked issue
Closes #1048

It's intentional. The "Dev" more is intended to be used for the author themselves, and should not expose to the audience directly. Generally, it's recommended to use a built SPA for the audience.
I think it would be great to:

Disable the editor when a password is set to the presenter mode
Have an option to disable it

Generally, it's recommended to use a built SPA for the audience

Yes, that is true. There is #889 which describes issue with the SPA, where you can have no presenter mode or unprotected presenter mode. So instead @nejci is using password protected presenter mode in dev mode allowing outside world to use code mirror.

Disable the editor when a password is set to the presenter mode
Have an option to disable it

Sounds great. I will take a look on that.
There is also third option, implementing password protection for presenter mode in SPA. What do you think about it @antfu ?

implementing password protection for presenter mode in SPA

I don't mind having it. Tho maybe we need to make clear that it only visually blocks the view, but does not prevent malware actions.
/cc @tonai in case you have any other opinions

Thanks, that might be for another PR.
Implemented your suggested changes to hide code editor:

if password is set
disabled explicitly via config

implementing password protection for presenter mode in SPA

I don't mind having it. Tho maybe we need to make clear that it only visually blocks the view, but does not prevent malware actions.
/cc @tonai in case you have any other opinions

When you use static build, the presenter mode is not synced with other clients, so the need for a password is not obvious.
if we found a way to share it, that would then clearly become a problem, so this can still be a potential feature to add.
As you say, using a password in a client only app is clearly not a perfect protection, but I don't think we have another option.
And yes I also agree that this would be for another PR.

When you use static build, the presenter mode is not synced with other clients, so the need for a password is not obvious.

Okay, that is probably the missing piece of information for users. Documentation doesn't state mention that so that might be why presenter with password in dev is used.
Is there anything else that needs to be done in this PR?

@antfu or @tonai anything else to be done in this PR?


Add is_ok?/1 and is_error?/1 helper functions

Fix #59

I was thinking about harmonizing semantic.
There's already success/1 and failure/1 functions, maybe better names for those new ones would be is_success?/1 and is_failure?/1 ?

It's a good question. There are a lot of OK users I wish I could ask them but I don't know anywhere I would find answers.

I don't have too strong a feeling on this but I think my inclination is towards success/failure

I agree – I updated the PR.

Released in 2.2 https://hex.pm/packages/ok/2.2.0


Release 0.13.1

It seems like 0.13.1 is not released but documented in changelog as a release? I'm running into #221 and would appreciate a release. Thanks!

0.13.1 is the one currently declared, but there is no tag/release for it.
If #222 is the working fix for #221, releasing 0.13.1 would be amazing! 😸
Thanks @hassox, @doomspork, @scrogson & Co. ✌

@kenips / @mariusbutuc — I'm going to cut 0.14 this weekend with a bunch of changes and bumping the Elixir version to 1.3.

With v0.14.0 released, we might be good to close this.

Thank you @mariusbutuc 👍


Don't show sent for received tx

It seems that the fix in https://github.com/LN-Zap/zap-desktop/pull/542 for #539 was the wrong way round (sent showing as received, received showing as sent). This reverses it.
Fix for #539

utACK 48681ba

utACK 48681ba


Add a tabindex to potentially-overflowing code blocks

Since our code blocks overflow with scrollbars, it's important that they're focusable. Adding tabindex="0" allows for keyboard focus and scrolling when things overflow. https://dequeuniversity.com/rules/axe/4.3/scrollable-region-focusable?application=AxeChrome
This adds it to our plugin so the documentation is accessible.

I'd like to actually hold off on this specific solution.

More or less addressed in #10, which landed in v1.1.0


Add new connector: spark-cassandra

This PR introduces a new connector called spark-cassandra. This connector is based on sparkcore and it gives ability to mount Quasar to Cassandra instance.
Keyspaces are representing folders, tables are representing files.
Current limitation: connector works with single column tables that hold JSON String as a value.
All limitations and possible improvements are listed under https://github.com/quasar-analytics/quasar/issues/2581

Part of https://github.com/quasar-analytics/quasar/issues/1676

Note that some folders and files in integrations test had their paths shortened because of the Cassandra's specific limitations

@djspiewak is on vacation thus changing reviewer to @jedesah

@jedesah As I'm back from vacation, I can take this back if you want.  Or you can keep it.  Whichever is easier.

@djspiewak Happy to hand you back the torch 😄

wow, that was too fast i think, there were changes in master that will break the build after merge

@rabbitonweb What changes?

i guess we will see in a moment, if those happen let me know i will fix them (@marekklis wanted to do this tomorrow)

Ok, I was under the impression that the review comments here were the only thing holding this up.  In future, if there's something that temporarily prevents a PR from being merged, please note it on the PR thread.  Sorry for the fast merge.

Travis was complaining (or maybe I dont remember correctly). Basically I did some changes in other PR which was merged to master yesterday, and that change was breaking spark-cassandra (coompilation errror). I will fetch master now and see if it is true (maybe Marek already fixed that byut I dont see this in git history so i doubt it)

@djspiewak I'm pretty certain that travis marked it RED . If it was not marked red then this is false alarm

I'll address remaining issues in separate PR

@marekklis you are now officially committer to Quasar Analytics :)
@zeeiyerWork ekhm.... ^^  :)


Nginx proxies

This needs testing both with and without SSL. I am running this exact configuration with SSL. In order to get SSL working I used certbot from https://certbot.eff.org/

Ok, some wishlist items for this PR (may or may not make the cut):

[ ] Need to include ALL services in Atomic (MUST be done to make the cut)
[ ] Either Atomic should set the baseurl in the config of all of the services that need it, or the proxy settings need to be reworked to not require setting the baseurl

I may change this list a few times in the future.

I tested and got it working with both ssl and without.  LGTM

Excellent work chaps! Sounds like we've got a very promising solution going forward. I definitely agree we Need to include ALL services that ATK currently supports to begin with. Then come up with some clever way to update going forward if we add any new services.
Thanks again for all your time. We need more people like you both to create new features and help test them!
Tom

@TommyE123 I've added all the services but I have NOT tested them all. This updated config needs a bit more testing, but it should work since it's just a bunch of copy paste. Each service needs a baseurl set in order to work, and some might need special considerations similar to Plex or Ombi, and those things are not accounted for yet.
It looks like atomic might have the ability to set the baseurl into the configs for a lot of the apps, so that might be next if I can figure it out.


Unable to start print

Thanks for this cool app! I can certainly use this in our farm.
Installed and all controls work fine and can connect to multiple p1p printers. Can upload .3mf files to printer. No AMS units on printers, just external spools.
I am unable to start job via print from SD or batch print. Filament mapped.
Can you please point me where I should be looking for troubleshooting? I do not see any errors on server startup or during the execution of jobs in console output or logs. It says the batch job is sent, but nothing happens with the batch print function or the print from sd card.

Resolved

How did you fix it? It might help other users with similar issues 😄

Sorry...
I had to downgrade my firmware. In a fairly recent firmware update, I believe that Bamabu blocked MQTT requests with P1Ps not in LAN Only mode. Once I downgraded, it worked fine.
https://forum.bambulab.com/t/mqtt-for-a1/50033/22

Thanks for confirming!
It correllates with their release notes:
https://wiki.bambulab.com/en/p1/manual/p1p-firmware-release-history

Prevent conflicts with Bambu Cloud service & potential damage to printer hardware by prohibiting crucial printer controls (initiating printing, heating the nozzle, and heating the heatbed) through the local MQTT Broker while the printer is logged into Bambu Cloud service.


Feature go err enhance

HI @dgkanatsios,
I made some enhancements to the error handling so it exposes errors from the remote API.
Thanks for creating this! This was a big help.
-w

@computerrivet thanks for the contribution. I'm gonna move this in a new repo next week (where only the Go generator will exists) and setup it from scratch. So, please keep your changes so you can properly PR in the new repo. Sorry for the inconvenience!

hey @computerrivet, so I'll keep this fork for the "Generator" part of the SDK and I'll host the SDK here https://github.com/dgkanatsios/playfabsdk-go. Can you please rebase and fix your PR so I can review and merge? Thanks!

@computerrivet, as discussed I've published a first version of this SDK here -> https://github.com/dgkanatsios/playfabsdk-go
Happy to discuss your PR when ready :)

@computerrivet thanks again for the contribution! Closing down this PR as https://github.com/dgkanatsios/SDKGenerator/pull/2 was merged, let me know if I missed something.


Suggest for changing "diagonal flip"

The implementation of diagonal flip seems not an actual diagonal flip. To my understanding it is horizontal + vertical flip (H+V flip). See below.
https://github.com/open-mmlab/mmdetection/blob/83eea4bec684708171f0b6433636df0873e50dac/mmdet/datasets/pipelines/transforms.py#L411-L417
The difference between H+V flip and diagonal flip is shown in figure below. I suggest to change the flip_direction from diagonal to hor_ver or both for consistency between implementation and intuition.

@thangvubk Thank you very much for your suggestion, I will modify it.


Broken compatibility due to previous bug in a script

Previously, sct_dmri_separate_b0_and_dwi had a bug:
The default value was supposedly average=0:
https://github.com/neuropoly/spinalcordtoolbox/blob/2d29de6918f7b85bda96e8c2b6d58f720442ac77/scripts/sct_dmri_separate_b0_and_dwi.py#L34
However the input flag was converting to a string:
https://github.com/neuropoly/spinalcordtoolbox/blob/2d29de6918f7b85bda96e8c2b6d58f720442ac77/scripts/sct_dmri_separate_b0_and_dwi.py#L63
And the variable was then evaluated as a Bool, so the result was always "True":
https://github.com/neuropoly/spinalcordtoolbox/blob/2d29de6918f7b85bda96e8c2b6d58f720442ac77/scripts/sct_dmri_separate_b0_and_dwi.py#L212
The recent PR #2819 fixed that bug, but also changed the behaviour: the average scan is not more produced, which breaks all the current processing pipelines already in place, e.g.
https://github.com/spine-generic/spine-generic/blob/4143cbfd7a206f06e3fd9f42485d5087129899d7/process_data.sh#L261
I suggest we change the default to be average=1 to ensure cross-compatibility

Good catch!
Doing a project-wide search for =['0' yields other examples of 0/1 flags that were parsed as strings. So, there could be other instances of this type of bug, where if <variable>: was always evaluating to True.
Since more of these '0'/'1' flags will be updated as a result of #2842 and #2843, I'm concerned about compatibility breaks elsewhere, too. (Especially because this doesn't seem like something our current test suite is able to catch.) Since there are only a limited number of '0'/'1' flags, I can do a quick manual inspection for other occurrences.

On a first pass, I couldn't find any other instances of this bug. All other '0'/'1' options are cast to int before use, e.g.

On a first pass, I couldn't find any other instances of this bug. As far as I can tell, all other string '0'/'1' options are either cast to int before use:
https://github.com/neuropoly/spinalcordtoolbox/blob/b6a3fd5c6cbb6f03b68d086721e376846d339813/scripts/sct_label_vertebrae.py#L227-L228
Or the string value is checked explicitly, e.g.:
https://github.com/neuropoly/spinalcordtoolbox/blob/b6a3fd5c6cbb6f03b68d086721e376846d339813/scripts/sct_propseg.py#L590-L592
So, I think it was just this one.


Custom Creative Tab

Add all items / blocks in a custom Celtic Rituals creative tab. Therefore, we also need an icon.

Done with #32


CI Containerize DB Take 2

Followup for https://github.com/rancher/cattle/pull/2132

@dx9 I'm pretty sure this is going to conflict with https://github.com/rancher/cattle/pull/2088 which will be merged before this one.  One thing that I changed in that PR (besides the million other things) is that on mysql start we preseed the database with https://github.com/rancher/rancher/blob/master/server/artifacts/mysql-dump.sql.  It is just to speed up the startup because the full liquibase migration on mysql takes a long time.  We do the exact same thing when you do docker run rancher/server at https://github.com/rancher/rancher/blob/master/server/artifacts/mysql.sh#L91

@ibuildthecloud ok, I'll wait for the madness to drop and then rebase this to keep the seeding.

@dx9 1.2 is finally going out tomorrow so I want to start merging all these pending PRs.  Can you rebase this one just to make sure it's still good.

yep, rebased


⚠ Secret Website 3 has degraded performance

In 33b3dea, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2285 ms

Resolved: Secret Website 3 performance has improved in c2677e8.


fix: init sage in repository not working

If merged this PR will fix the init command returning the error .sage: file exists. This was caused by a recent addition of ensureParentDir to FromBinDir. The function sg.Command uses FromBinDir which causes the .sage directory to already be created when os.Mkdir is called in initSage

Nice catch! Maybe we should also fix the ensureParentDirectory function to not create the parent dir if it already exists?

Sounds like a good idea I can look into it


Fix DeformConv2d's autocast test flakiness

A series of recent unrelated PRs exposed the fact that DeformConv2d's autocast unit-test is flaky and it can fail if we hit a bad seed. To resolve the problem, PR #3032 introduced a temporary workaround that fixes the random_seed:
https://github.com/pytorch/vision/blob/06ebee1a9f10c76d8ac5768fd578362dd5ace6e9/test/test_ops.py#L657-L659
The above is not a great solution. We should investigate and fix the problem properly by adjusting the unit-test.
To reproduce the issue, remove the set_rng_seed call from the test and rerun it.

I can't really tell why the test is failing for some seeds but I made some experiments:

It only fails for half precision; the float32 dtype sections are fine
increasing the tol from 1e-3 to 1.5e-3, seeds in [0, 79] pass (and seed 80 fails)
increasing tol further to 2e-3 makes all seeds in [0, 100] succeed

Considering that all checks for float32 pass without change, perhaps the simplest fix is to increase the tolerance to 2e-3 for half precision?

I can't really tell why the test is failing for some seeds but I made some experiments:

It only fails for half precision; the float32 dtype sections are fine
increasing the tol from 1e-3 to 1.5e-3, seeds in [0, 79] pass (and seed 80 fails)
increasing tol further to 2e-3 makes all seeds in [0, 100] succeed

Considering that all checks for float32 pass without change, perhaps the simplest fix is to increase the tolerance to 2e-3 for half precision?

Thanks for the analysis @NicolasHug. Perhaps it's just an issue of using too small tolerance. I think 2e-3 is reasonable if it resolves the issue. I'm happy to review it if you want to send a PR.

Thanks for the analysis @NicolasHug. Perhaps it's just an issue of using too small tolerance. I think 2e-3 is reasonable if it resolves the issue. I'm happy to review it if you want to send a PR.


cannot use output for Android 11 ?

This  works fine from Android 6 to an Samsung A7 with Android 10
But now i have another movement from Android 6 (Sony Z3) to Android 11 (Realme X2).
The script produces around 800 KB .
Then i copy the output  to /data/misc/apexdata/com.android.wifi/WifiConfigStore.xml with wifi off and reboot
But when i now enable Wifi, i can see in the total commander, how the file shrinks down to about 50kB.  Nearly all entries are lost. S
Couldn't it be because the Android 11 doesn't fit the format?
In the native wificonfigstore the 3rd line says version value=3
while the version generated by this  script is version=1

Its hard to tell @rregn, but I'd guess from what you wrote that some of the wireless networks got transferred successfully. My (blind) guess would be that phone accepted networks from start of the file up to some point where it stumbled upon something it couldn't understand, and then import aborted and all wifi networks after that line did not get processed.
Then it saved new (version3) file over (with just the information that it managed to import so far, thus losing most of the networks).
You could verify that theory by comparing  wifi networks that did manage to get imported with original file. If the theory is correct, you should be able to find network which cased import to abort (i.e. the first network that didn't get imported).  My guess is that something will be special about that network - some custom parameters, different authentication types, strange (non-ASCII) name etc. When you have found it, then you could:

remove just that network from the input file, run conversion again, and see if all networks got imported
also anonymize information in that wifi network, and send it over here, so perhaps such problematic networks can be at least detected (or even better autocorrected) with this tool.

thank you for the fast reply and the ideas. So  I had a closer look to the networks which are finally on the phone. It comes out, that it was the last 20 of  the list in the wpa_supplicant. So i thought, there is a problem with the entry just before. I removed the last 22 entries  in the  wpa_supplicant. and tried again. Again just the last 20 (and my home network) remain
Also  I could see  - after switching wifi on again - with the total commander how  the file  in ...apexdata/com.android.wifi  shrinks and from time to time there is a wpa_supplicant.conf.new - so some process does a copy for rewriting.
I did this a 3rd time, cut again 22 entries from wpa_supplicant.conf, and again: the last 20 entries survive + my network.
i really like to attach the file here (bt you need an Adroid 11  or somewhat phone to test the import

wpa_supplicant.conf_8_24_era.txt
here my  wpa_supplicant.conf -  note: whereever key_mgmt is "WPA-PSK .... " i cut after WPA_PSK

i found out the reason  - it was the cut of the characters behind WPA-PSK!  i removed the "$" in line 58 of the script, now i have 126 Networks in the new phone

It comes out, that it was the last 20 of the list in the wpa_supplicant

That is strange that those are last 20 entries; it would mean my guess was probably wrong and something else is at work. Unfortunately, I don't know what :shrug:. Is your wifi on or off when you try doing the import?
Could you try keeping only first 30 entries and removing all other, and trying to import that? What is on the phone then?

i really like to attach the file here (bt you need an Adroid 11 or somewhat phone to test the import

Unfortunately I don't have rooted Android 11 device, sorry.

here my wpa_supplicant.conf - note: whereever key_mgmt is "WPA-PSK .... " i cut after WPA_PSK, otherwise the script stops with error

I've just made some changes to avoid problems with that. Can you try that new version?

i tried,  (again wifi is off, when i insert the file, and after i reboot quickly)  but  the result is the same. shrinking takes around 10 sec, and i could see the .new file agein. i think, the problem is in the  xml file.  e.g. why you write  hasEverConnected = false  ?

I added here
WifiConfigStore_realme_xml.txt
a entry in the final xml "made" by my realme

Now i found out that ALL "surviving entries" are open wifis - without key!

Aha, that is very useful information!
Can you manually create one password-protected entry via normal Android UI, and extract from WifiConfigStore.xml  (with replaced password with dummy value) how that correct & working entry looks on your Android?
Then we can compare how it looks compared to the output that script generates...

WifiConfigStore_realme_xml.txt
here

Hi

i uploaded a example file, did you examine it?
kind regards

Gesendet: Freitag, 23. August 2024 um 16:32 Uhr
Von: "Matija Nalis - @." @.>
An: "mnalis/android-wifi-upgrade" @.>
Cc: "rregn" @.>, "Mention" @.***>
Betreff: Re: [mnalis/android-wifi-upgrade] cannot use output for Android 11 ? (Issue #9)

here my wpa_supplicant.conf - note: whereever key_mgmt is "WPA-PSK .... " i cut after WPA_PSK, otherwise the script stops with error
I've just made some changes to avoid problems with that. Can you try that new version?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

yeah, sorry, I have some backlog to go through... I'll  send you something to try in a few days

Ok, here is test WifiConfigStore.xml for you @rregn. It should have 50 networks (named from demo1_01 to demo1_50).
WifiConfigStore_demo1_xml.txt
Does that work? Do all 50 networks survive? Or do some remain, but some get truncated?

thanks!

after switching wifi on again the file does NOT shrink this time!

and yes, in stored networks i find   50 networks (named from demo1_01 to demo1_50)!
Message ID: @.***>

And how about this one? It should also have 50 networks (but named from demo2_01 to demo2_50).
WifiConfigStore_demo2_xml.txt

it does grow a little bit from 130 to 135 kB (after switching wifi on) and :
I have still the old demo01_xx networks in my stored listMessage ID: @.***>

it does grow a little bit from 130 to 135 kB (after switching wifi on) and :

Was there supposed to be some more information after that "and :" ? Because it didn't make it to GitHub :cry:

I have still the old demo01_xx networks in my stored listMessage ID: @.***>

So, what is the end result? Only 50 demo1_xx networks? Or some demo2_xx also (how many and which numbers)?

But that looks very promising so far - when you answer this question, I'll have to send you few more test to try to isolate exactly what directive is problematic; but so far it looks it should be possible to devise some fix when all data is collected!

sorry, i didnt express it clearly:
there no demo2_xx  networks in the list.

there no demo2_xx  networks in the list.

Ok, great; how about this demo3_xx:
WifiConfigStore_demo3_xml.txt

same:
Only the old demo01_xx networks are  in my stored listMessage ID: @.***>

Only the old demo01_xx networks are  in my stored list

OK, how about demo4_xx:
WifiConfigStore_demo4_xml.txt

it does shrink a little bit from 136 to 130 kB (after switching wifi on) and :
all the demo04-xx are there (no 01 anymore)

And demo5-xx?
WifiConfigStore_demo5_xml.txt

it does shrink a little bit from 136 to 132 kB (after switching wifi on) and : all the demo04-xx are  still there (no demo05 !)

B.T.W.
today afternoon (4 p.m. GMT +2) i start going to vacation, so i cannot longer use the smartphone as a test system. I would much appreciate if the final script could be ready. on my trip i have no access to perl

OK, it seems culprit is BSSID field format. I've changed it now, new script is up. Can you test if it works for you @rregn ?
If it does work on Android 11 (Realme X2)., I'd appreciate if you could test if new script still works  for conversion "Android 6 to an Samsung A7 with Android 10" (because if Samsung A7 only works with old script, I'll have to add some options which version to use...)
Have fun on your vacation! :smile_cat:

(and if  that regular script from master branch does not work, you can try one from realme_x2_test_hadcoded_fields_dontuse branch as a last resort before vacation. Other than that @rregn , I probably won't see your reply before you have to go... ).

I tested the new script. it produces around 800kB output, but when i insert and start wifi again, it shrinks to ~130kb and finally the demo4 networks are there - and nothing else
in a 2nd try, it shrinks to 53 kB and has no demo04, but around 20 from my entries, !

--
the broken hardcoded version generates around 1MB and it shrinks to 207kB and look good.  But it has just around 80 entries from me.
when made a 2nd try, it has also around 80 entries, but now different ones!
so i can start into holidays, its better than before, thanksMessage ID: @.***>

in a 2nd try, it shrinks to 53 kB and has no demo04, but around 20 from my entries, !

Anyway, if you're back from vacation and would like to try to debug this more, let me know... It is a good progress that some entries are imported now, but it seems some entry is problematic and making it fail.
But it probably would take several tries to try to pin down the culprit before the solution can be devised...


Default Tab indentation of c example is 2 spaces, but editor's 4.

This is not a real problem, but i thought it would be good to warn.

im just dumb :D


🚀 [Feature] DM Button: Edit Table before opening it

🚀 Feature

DM Button: Edit Table before opening it
Clarify with @Hardy-Hart-am-Start before starting
There is a new Menu, which allows an unser to edit an existing not yet opened table before opening it:

Before:

Clarification from Hardi: After leaving my mall talk table, I cannot join it again (unless I've got the link). I just create a new table and the old one is deleted in the process. The default name can be taken from my last table, the invitee list should be clean.


https://codecov.io/bash: 502 Server Error

Hi! :wave:
When requesting https://codecov.io/bash, I am seeing an HTML page with a Server Error, rather than the actual bash script:
Error: Server Error
The server encountered a temporary error and could not complete your request.

Please try again in 30 seconds.

Started happening at least since today 11am (UTC+1). Makes my CI builds fail because my coverage script wouldn't be able to download and run the codecov bash script. Eg here's a sample of what I'm seeing on CI:
$ bash <(curl -s https://codecov.io/bash)
/dev/fd/63: line 2: syntax error near unexpected token `<'
/dev/fd/63: line 2: `<html><head>'

I'm going to see if I can allow failures on the coverage upload job, but thought this would be of interest to other people curious about what's happening!

Hi, it looks like we are currently having an issue but have deployed a fix. You can read more here

Thank you! Looks like everything is back on track, thanks for responding.


Sick Effects

I should really really really make some really sick effects

Screen shake
Particles

Imagine the chaos and lag...

Screen Shake added in v1.2


add note for document() function

DOCUMENT() does use primary indexes (without reporting it). I thus removed the misleading statement about not using indexes.
Added details about the shortcomings and the subquery alternative.
Unrelated minor improvements (alphabetical order of functions, SHARD_ID() description)


added SVG and path tag support

Added SVG and path tag support. Possibly incomplete, there may be more attributes I'm not aware of.

Hello @alextownleymakes 👋🏼
Thank you for creating this PR. We haven't maintained this repo in a while so I'm going to transition it to an archived state. I encourage everyone to find (or make!) forks of the code.
Thank you for your support!


pygments highlighting sometimes has bad contrast

This can be observed at https://pip.pypa.io/en/stable/reference/pip_show/:

A contrast of 3.34 does not meet the WCAG standards. (This is also reported by your browser if you right click on the text with the bad contrast, click Inspect and then click on the color).
AA conformance could be achieved with the following CSS rule:
.highlight .go {
    color: #727272;
}

Thanks for filing this issue!
This isn’t directly controlled by Furo, but is coming from pygments. I don’t see any there’s built-in alternative pygments theme that Furo should use that is much better, and this is customisable by the specific projects as well. I’m not sure what’s actionable here.

Ah thanks, I thought this was caused by the Furo background color but apparently many pygments styles have bad contrasts for some token types. I opened an issue at Pygments: pygments/pygments#1718. In my report there you can also see that there are some built-in styles that have better contrasts but if Pygments improves the contrast of their default style, I don't think you need to take any action.

Thanks for taking this upstream! I've subscribed to that and let's see what pygments' maintainers say.
I'll close this for now, since I don't see anything directly actionable here. :)


Not getting Resources for all users request

Hello,
I am using OSIAM as SCIM server. I written Jersey client to speak to OSIAM Server. While trying to get all users by hitting the url "http://<IP_ADDRESS>:8080/osiam/Users/", I am getting response like {"itemsPerPage":100,"Resources":[],"schemas":["urn:ietf:params:scim:api:messages:2.0:ListResponse"],"startIndex":1,"totalResults":62}. As you see Resources field is empty.
Following are my model classes.
@ToString
public class UserResponse {

    @Getter @Setter private Integer totalResults;
    @Getter @Setter private Integer itemsPerPage;
    @Getter @Setter private Integer startIndex;
    @Getter @Setter private List<String> schemas = new ArrayList<>();

    @Getter @Setter private List<User> Resources = new ArrayList<>();
}

@ToString
@EqualsAndHashCode(exclude = {"id", "meta", "schemas"})
public class User {

     @Getter @Setter private String id;
     @Getter @Setter private String externalId;
     @Getter @Setter private Meta meta = new Meta();
     @Getter @Setter private Set<String> schemas = new HashSet<>();
     @Getter @Setter private String userName;
     @Getter @Setter private Name name = new Name();
     @Getter @Setter private String displayName;
     @Getter @Setter private String nickName;
     @Getter @Setter private String profileUrl;
     @Getter @Setter private String title;
     @Getter @Setter private String userType;
     @Getter @Setter private String preferredLanguage;
     @Getter @Setter private String locale;
     @Getter @Setter private String timezone;
     @Getter @Setter private Boolean active;
     @Getter @Setter private String password;
     @Getter @Setter private Set<Email> emails = new HashSet<>();
     @Getter @Setter private Set<PhoneNumber> phoneNumbers = new HashSet<>();
     @Getter @Setter private Set<Im> ims = new HashSet<>();
     @Getter @Setter private Set<Photo> photos = new HashSet<>();
     @Getter @Setter private Set<Address> addresses = new HashSet<>();
     @Getter @Setter private Set<Group> groups = new HashSet<>();
     @Getter @Setter private Set<X509Certificate> x509Certificates = new HashSet<>();
     @Getter @Setter private Manager manager;
     @Getter @Setter private String employeeNumber;
     @Getter @Setter private String costCenter;
     @Getter @Setter private String organisation;
     @Getter @Setter private String division;
     @Getter @Setter private String department;

     public User() {
          schemas.add("urn:ietf:params:scim:schemas:core:2.0:User");
     }
}

Following method hit the REST Users endpoint.
public Response getAllUsers() {
     WebTarget target = client.target("http://localhost:8080/jersey_tutors/employees");

     return target.request(MediaType.APPLICATION_JSON).header("Content-type", "application/json").header("Authorization", getAccessToken().get()).get();

     }

Following method print the response.
public static void getUsertest(){
     Response response = service.getAllUsers();

     UserResponse resp = response.readEntity(UserResponse.class);
     System.out.println(JSONUtil.getJson(resp));
}

FYI, I am adding debug log.

Did you try to retrieve the users with curl? What does it respond?
$ curl -i -H "Accept: application/json" -H "Content-type: application/json" -H "Authorization: Bearer $YOUR_ACCESS_TOKEN" -X GET http://<IP_ADDRESS>:8080/osiam/Users/

Greetz,
David

Hello Dacrome,
Thanks for the reply.  When i tried with advanced rest client, it is returning all users, but when i used Jersey rest client it is unable to map to UserResponse class.
I can able to solve the problem in different way. I am reading response as  json string and mapping it to my model class UserResponse.
/* Get all users from scim server */
Response response = getAllUsers();
String jsonResponse = response.readEntity(String.class);
UserResponse cloudUsersResp = JSONUtil.getObject(jsonResponse,UserResponse.class);

Only thing I am not getting is, why it is unable to map the response directly to UserResponse class. Will you able to suggest on this?

Hi @harikrishna553,
I think you have to explicitly configure Jersey to correctly map a JSON String to some POJO. On the other hand, your debug logs proofs, that the JSON returned from OSIAM does not contain any data in the resources attribute. That's strange. And if you use some other HTTP client, you actually getting a response with some resources in it? That's even stranger. Can you provide a small working app, that's able to always reproduce the issue?

Hi Tkrille,
I figured out the issue. User model class is not matched to the response in resource. I able to solve the issue by ignoring some multi valued attributes (which are not supported by osiam).

I'm curious: waht multi-valued attributes don't we support? AFAIC we support all of them.

Attributes like groups, manager, department etc.,

Alright, but to be clear:

We do support User.groups, but not Group.groups
"manager, department etc.," are coming from the enterprise extensions, which we do not support fully, but planning to do so: https://github.com/osiam/osiam/issues/133

Thanks for your additional information.

Oh, I wasn't right at Group.groups: That's not supported by the current SCIM spec. But we still support User.groups :)


Google+ Sign-In Deprecation

Hi there,
We are using passport.js to authenticate people with their Google account. And I'm receiving emails from Google last days that we are using something that's going to be fully deprecated. Screenshot of the email below:

Here is the code we have for authentication:
const options = {
authType: "rerequest",
state: JSON.stringify(data),
session: false,
failureRedirect: "/login",
scope: ["profile", "email"],
};
passport.authenticate("google", options)(req, res, next);
Are you going to update the api you are making requests to? Or should I update something in my code?
Environment

<EMAIL_ADDRESS><EMAIL_ADDRESS>

@tima101 Do you know what's going on with passport.js? I see that they haven't updated almost anything last months. If you can make a pull request with your updated version to the original repository.

@jaredhanson Are you going to review this PR?
https://github.com/jaredhanson/passport-google-oauth2/pull/51

You may find this useful: https://stackoverflow.com/a/54112673/10124491

Any update on the PR ? would be nice to pull the trigger on it

<EMAIL_ADDRESS>has been published to npm.  More information here: https://medium.com/passportjs/google-api-shutdown-330c3b47e3df


[IOTDB-2742] Hide IDTable configurations

Description
Since IDTable is not formal feature of 0.13, we need to hide the configuration and not allow users to open it.

Coverage decreased (-0.01%) to 65.599% when pulling a13ff9fb75185596713a6fd719ff73cb9a96d540 on iotdb_2742 into 0d2cad6dbf3f8d9a43242f28d07c8c90fcc4d2c2 on master.


HDFS storage driver

Dears,
Currently distribution supports some storage drivers, except HDFS.
HDFS is a distributed file system, which can be deployed on low-cost hardware.
I think it can be used as a good storage option for distribution, and I'm implementing this feature.
Would distribution project accept this kind of patch?
Thanks a lot!

I think someone mentioned HDFS in the past.
We are willing to accept additional drivers into the core, on the following conditions:

your code is good quality, well tested, well documented
you (or your team) make a commitment to be responsive on future github issues involving your driver, and helping users with setup and debugging
you make a commitment to fix future bugs in your driver in a timely manner

@dmp42 Thanks for your explain. I'd go on the implementation with good quality, and make commitment to maintain the related issues.

@xiekeyang As I said in the ticket, I'd like this to use the binary protocol, rather than the web interface. Either way, good luck!

@stevvooe
Hadoop RPC protocol is faster than hdfsweb. I tried both to transfer big data, and I feel they might be not very different. I didn't implement RPC on distribution, so I didn't compare them on Docker image up/down load.
I selected hdfsweb because it is widely using, and implementation is some easier.
I have made experience of colinmarc/hdfs, which provides part of function interface for Distribution Storage Driver. Write support functionality hasn't been merged to master branch.
If we leverage it, maybe we should make some modification.
We can discuss about the 2 ways, and find the better option. At the same time, I would go on working the RPC protocol.
Thanks so much.

@xiekeyang I still think the hdfsweb work is valuable. It is possible that we could merge an implementation. I meant that we should call it by that name, instead of "hdfs". Sorry if that was confusing.

@stevvooe
Understood. Thanks a lot.

Hey @xiekeyang, did you get started on hdfsweb project yet? Would like to contribute to it as well.

@serkanh The PR is here #1123.

@stevvooe awesome thank you.

I'd like to see this merged

Implement a driver use golang native HDFS library instead of webhdfs https://github.com/docker/distribution/pull/3123

Closing as per https://github.com/distribution/distribution/pull/3123#issuecomment-1676372856.


Allow providing additional passthrough options for the request library.

#30 wanted a configuration option for strictSSL on the request library (which webpack-sentry-plugin uses under the hood). I figured better to solve the general case and add a config parameter for options to be sent to the underlying request.
Fixes #30

@rhys-vdw While I'm bugging you, mind reviewing this PR as well? Along with the doc updates this should finish out the outstanding issues, just wanted to get another set of eyes on the code.

Looks pretty straight forward @schneidmaster apart from the one uncertainly I have above.

@rhys-vdw Thanks, updated per your comment, let me know if that looks good

Just FYI that was just some example code, whether it works or not is up to you to test. Other than that it all looks good. 👍

Yep, I tested 👍 thanks!


[PASS] Add CUDA IR verifier

Add a pass to check whether a cuda ir is valid

/workspace/src/arithmetic/modular.cc:168:1: fatal error: error writing to /tmp/cc30MweO.s: No space left on device

@merrymercy please act on the comments and fix the ci error

@eqy can you also do a round of codereview?

@tqchen @merrymercy if we also save the number of threads per dimension (x, y, z), perhaps we can also use this to capture
CL_INVALID_WORK_ITEM_SIZE (e.g., in https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/clEnqueueNDRangeKernel.html)
for OpenCL kernels. But I am not sure if this can happen in CUDA land, so we could also use a separate verifier pass there.

It would be a good idea to pass in as many constraints as possible and allowing defaults to non-constraints. One possible way to do so is to allow pass in of a Map<str, value> so we don't have a lot of positional arguments

ready for review

Is the plan to skip checking threadId/workitem dimensions in this round?

please fix the compiler warning http://mode-gpu.cs.washington.edu:8080/blue/organizations/jenkins/dmlc%2Ftvm/detail/PR-1296/11/pipeline
Currently we set compiler warning as error so built won't pass if there is a warning

@eqy your comment are addressed
@tqchen  no space left on CI

The test error likely indicate there is some problem with the current PR when importing runtime only dll.


Faster conversation-links-on-repo-list

LINKED ISSUES:
#2671

TEST URLS:
https://github.com/search?q=user%3Asindresorhus+sindre
https://github.com/sindresorhus?tab=repositories&type=source

SCREENSHOT:
None

Actually… it’s not faster. I found out that selector-observer always waits for dom-ready. This sort of limits the usefulness of this package.
This is kind of a problem for some features. I wonder if we need to find another package.
It makes sense that it waits (for performance reasons) but also this means that features a no longer instant.

Your right. https://github.com/josh/selector-observer/blob/master/lib/ready.js
I have however found that on Ajax requests or when we were doing observelement on init this was faster. But otherwise it only makes it simpler.

I'm failing to see the purpose of this change. I don't think that the page is particularly ajaxed

I guess this does have observeElement('#user-repositories-list', init) and the initialization is slightly shorter. It could be ok

Congrats on your first merged PR 😸

Thanks!


SAS Token auth on DFS endpoints

The following 3 commits enable the use of a SAS token to authenticate uploads and downloads on dfs.core.windows.net endpoints.
In order to facilitate this addition, some core files were shared to azbfs (namely relating to SAS tokens). Namely, zc_sas_account.go and zc_sas_query_params.go.
As usual, some changes are as a result of the automatic go fmt execution configured in my Goland setup.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: adreed-msft sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Uploaded to azure:SASauth, replacing this PR


Uncaught TypeError: Cannot read property 'highlights' of undefined

I was editing a CoffeeScript file, so I don't think this is related to the latex and xmllint packages I had installed at the time. It happened a few seconds after I unfolded a fold while editor had some search results highlighted.
Will try to reproduce, but so far I've been unsuccessful. cc @nathansobo for :eyes:
Atom Version: 0.208.0-c06d62e
System: Mac OS X 10.10.3
Thrown From: Atom Core
Stack Trace
Uncaught TypeError: Cannot read property 'highlights' of undefined
At /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-presenter.js:1654

TypeError: Cannot read property 'highlights' of undefined
  at TextEditorPresenter.module.exports.TextEditorPresenter.updateHighlightState (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-presenter.js:1654:25)
  at TextEditorPresenter.module.exports.TextEditorPresenter.updateDecorations (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-presenter.js:1518:18)
  at TextEditorPresenter.module.exports.TextEditorPresenter.getState (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-presenter.js:130:14)
  at TextEditorComponent.module.exports.TextEditorComponent.updateSync (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:182:38)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:298:28
  at ViewRegistry.module.exports.ViewRegistry.performDocumentUpdate (/Applications/Atom.app/Contents/Resources/app.asar/src/view-registry.js:168:9)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/view-registry.js:3:61

Commands
     -1:33.5.0 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -1:33.5.0 snippets:expand (atom-text-editor.editor.is-focused)
     -1:33.5.0 editor:indent (atom-text-editor.editor.is-focused)
  4x -1:33 core:backspace (atom-text-editor.editor.is-focused)
  2x -1:08.8.0 editor:select-to-beginning-of-word (atom-text-editor.editor.is-focused.autocomplete-active)
  2x -1:07.6.0 core:backspace (atom-text-editor.editor.is-focused)
  6x -1:05.9.0 editor:select-to-beginning-of-word (atom-text-editor.editor.is-focused)
  3x -1:03.0 editor:select-to-end-of-word (atom-text-editor.editor.is-focused)
  3x -1:02.2.0 editor:select-to-beginning-of-word (atom-text-editor.editor.is-focused)
  3x -1:00.4.0 core:select-right (atom-text-editor.editor.is-focused)
     -0:56.7.0 core:backspace (atom-text-editor.editor.is-focused.autocomplete-active)
  3x -0:39.4.0 editor:select-to-end-of-word (atom-text-editor.editor.is-focused)
  2x -0:38.4.0 core:backspace (atom-text-editor.editor.is-focused)
  5x -0:37.9.0 editor:move-to-beginning-of-word (atom-text-editor.editor.is-focused)
     -0:36.9.0 editor:select-to-end-of-word (atom-text-editor.editor.is-focused)
     -0:07.3.0 editor:newline (atom-text-editor.editor.is-focused)

Config
{
  "core": {},
  "editor": {
    "fontSize": 20,
    "invisibles": {},
    "softWrapAtPreferredLineLength": true,
    "showInvisibles": true,
    "tabLength": 4,
    "softWrap": true
  }
}

Installed Packages
# User
language-latex, v0.6.1
linter, v0.12.6
linter-xmllint, v0.0.6

# Dev
No dev packages

It looks like tileState was undefined here. This seems like it shouldn't happen, since range.start.row is forced to be between @startRow and @endRow. /cc @as-cii do you have any ideas here?

@maxbrunsfeld: tiles could have been rearranged by the folding operation and, since @updateDecorations actually gets executed before @updateTilesState, that code path could be trying to delete a tile which doesn't exist yet. Ideally, @updateTileState should run before @updateDecorations, but this would break @lineDecorationClassesForRow (cause it needs to access a cache which is constructed by @updateDecorations).
This whole layer, although not executing complex operations, is getting tangled and I would love to refactor that at some point (IMHO this is something we can do only after 1.0). So, I'd say a quick and dirty fix could be to simply take into the account the possibility of a certain tile to be nil, e.g.:
delete tileState?.highlights[decoration.id]

Alternatively, we may have a separate @setupTiles operation (or something similar) whose job is to simply handle the @state.content.tiles object, deleting and instantiating tiles as needed. Then, @updateTilesState would simply calculate positions as well as calling @updateLinesState.
However, let me first try to reproduce it consistently and actually confirm my hypothesis. I'll take care of it and report my findings here (or in a PR) as soon as I have made some progress.
Sorry guys if this tiling stuff is causing all these headaches to you. :disappointed:


Adds SwiftLint

SwiftLint available via Homebrew:
brew install SwiftLint

There are two .swiftlint.yml files, one for our app target and one for our test target. I think this is important because we don't ship tests, so I don't mind force-unwrapping optionals there. All of these changes are open to discussion of course.
I decided not to include it on CI for the same reason we don't use spacecommander there. I looked into only linting changed files, but that introduced problems integrating with Xcode. Linting takes 0.67 seconds on my machine, so it's something to keep an eye on if it gets too lengthy (we could add the ability to specify more than one path at once to swiftlint, which would fix our Xcode integration problem).

        2 Errors

  </th>
 </tr>

:no_entry_sign:
No CHANGELOG changes made

:no_entry_sign:
There were snapshot errors

        2 Warnings

  </th>
 </tr>

:warning:
Needs testing on a Phone if change is non-trivial

:warning:
Detected some Swift building time outliers

Time | Class | Function |
| --- | ----- | ----- |252.5ms | AuctionViewController.swift | @objc dynamic func showRefineTappedAnimated(animated: Bool)
207.4ms | SwiftyJSON.swift | get {}
174.1ms | WebSocket.swift | private func processRawMessage(buffer: UnsafePointer, bufferLen: Int)
80.0ms | Observable.swift | private final func nextTokenHash() -> Int
71.5ms | LiveAuctionsAdminViewController.swift | @objc override func viewDidLoad()
70.7ms | AuctionLotMetadataStackScrollView.swift | required init(viewModel: LiveAuctionLotViewModelType, sideMargin: String)
62.3ms | RefinementOptionsViewController+Private.swift | func stackView() -> ORStackView

  Generated by :no_entry_sign: danger

Getting intermittent error on CI, it's consistently "got expected a matching snapshot in looks_good_when_stuck_to_the_bottom", example: https://eigen-ci.s3.amazonaws.com/2748/index.html I'll take a look later.

Ha, test failure was actually legit: https://github.com/artsy/eigen/pull/1612/commits/973ac57d3a7d78a24f93aaa35d12c01797bc9ea3
After removing the build scripts, I added SwiftLint invocations to a precommit hook (installed via a ruby script from make artsy). We can optimize later for how things go using the precommit hook, maybe we want to restrict to only files changed, but I think this is a reasonable foundation.

Build is only failing due to Developer Specific file shouldn't be changed in Danger, unit tests are passing.

Yep 👍

Note: Danger can ignore specific warnings/fails, I think you add this to the body of the PR:
Danger Ignore: Developer Specific file shouldn't be changed

Cool!


Implement gp_exp_quad_cov in opencl

Description
gp_exp_quad_cov() could use GPU to be faster.
Example
gp_exp_quad_cov is faster when using GPU.
Expected Output
gp_exp_quad_cov is faster when using GPU.
Current Version:
v2.19.0

Nice!! Could you post a performance test?
Tag me as a reviewer when this is ready to rock!


Trigger Engine: fwport connection failure fix from release-1.1

It seems that the codecov action broke one again, yay


Update cache-tls-configuration.md

Support for TLS 1.0/1.1 on Azure Cache for Redis ending on 31 October 2024. Add changes to update TLS 1.2 enforcement date.
Refer:
https://azure.microsoft.com/en-us/updates/support-for-tls-1011-on-azure-cache-for-redis-ending-on-31-october-2024/
https://learn.microsoft.com/en-us/azure/azure-cache-for-redis/cache-remove-tls-10-11

@flang-msft
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

#sign-off

Thank you for your contribution to the documentation @DeeptiJainMicrosoft.


accessibility API bug

Hi there,
when I set the accessibilityRole ={"button"} to any button, talk back says "button submit". but that is not expected behavior.
instead of, talk back should say, "submit button, double tap to activate"
to make things worse, talk back doesn't recognized unless I set the accessibilityRole={"button"}.
however, I could just set the accessibilityLabel ={"submit button, double tap to activate"}. but it is not elegant solution because screen reader hints differs from one screen reader to another, I mean, it is not cross platform solution.
the another issue that I have come across is, the talkback doesn't read the accessiblityHints.
I. E.
<Button accessibilityHints ={"double tap to activate"}
accessibilityRole={"button"}
title ={"submit"}
/>
for above example, talkback would announce, "button submit".
leaving out the accessibility hints and announcing the control in nonstandard manner.
there are no accessibilityRole for drop down (combobox), spin editor etc. could you please add some more accessibilityRoles?
while creating material bottum tabBar,
every tab is being announced as selected, but they are not.
here is the code:
import React, { Component } from 'react';
import {Alert, AppRegistry,StyleSheet, TextInput, View, Text} from 'react-native';
import { Button } from 'react-native-elements';
import Icon from 'react-native-vector-icons/MaterialIcons';
import { createMaterialBottomTabNavigator } from "react-navigation-material-bottom-tabs";
import { createAppContainer, createStackNavigator } from 'react-navigation';
class Album extends Component {
render (){
return(

<Text accessibilityRole ={"text"}> album here
<Button
onPress={() => this.props.navigation.navigate("Library")}
title={"go to library"}
accessibilityLabel={"go to library, button"}
 />
</View>
)

}
}
class Library extends Component{
render () {
return(

<Text accessibilityRole={"text"}> your library here

)
}
}
class Cart extends Component{
render () {
return (

<Text accessibilityRole={"text"}> your carts here

)
}
}
class History extends Component{
render(){
return (

<Text accessibilityRole={"text"}> history here

)
}
}
const Tabs =  createMaterialBottomTabNavigator({
Album: { screen: Album },
Library: { screen: Library },
History: { screen: History },
Cart: { screen: Cart },
}, {
initialRouteName: 'Album',
activeColor: '#f0edf6',
inactiveColor: '#3e2465',
barStyle: { backgroundColor: '#694fad' },
});
const AppNavigator = createStackNavigator({
Album: {
screen: Album
},
Library:{
screen:Library
}
});
const App = createAppContainer(Tabs);
export default App;

Can you please improve code formatting in the issue. It's very hard to read. Find a reference here


Essential configuration.

Please add basic configuration like displaying on the right side or hiding the control. It would be nice if the user could choose which members are displayed: public, protected, private, static, fields, properties, methods, events. Just a simple filter looking exactly like the one shown by VS 2017 when auto-complete for C# kicks in.

With the upcoming 1.3 version it will have the following features:

Double-click the splitter to hide the control
Options screen to change sides
Filter screen to change which elements are shown


Angry IP Scanner fails to start

Describe the bug
When opening Angry IP Scanner, i get an error message about it trying to load the "SWT" library, but failing to do so because im trying to use a binary made for a "different OS or CPU"
Steps To Reproduce
Steps to reproduce the behavior:

Install Angry IP Scanner
Start
Error popup message appears

Expected behavior
Should just start and work
Screenshots

Additional context
Nothing
Notify maintainers
@kylesferrazza
@totoroot
Metadata

system: "x86_64-linux"
host os: Linux 6.10.1-zen1, NixOS, 24.11 (Vicuna), 24.11.20240731.9f918d6
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.5
nixpkgs: /nix/store/7v6l2v247fmdgfpbs3w91mf6rinai4yk-source

Add a :+1: reaction to issues you find important.

Closed in https://github.com/NixOS/nixpkgs/pull/338234


fix: default port numbers for the datasources

Description
This PR covers arango, elasticSearch, mongo, mssql, mysql, oracle, postgres, redis, redshift, smtp datasources for setting the default port values for each. This adds a test case that tests the default port values for all
Reopening the pr as the issue with the test failures was due to release build cache.
Find the RCA : https://www.notion.so/appsmith/Default-port-value-Pr-introduced-test-failures-RCA-0043049215064257862ba4f678113bb3
Related PRs :
https://github.com/appsmithorg/appsmith/pull/32592
https://github.com/appsmithorg/appsmith/pull/32726
Fixes #32136
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!CAUTION]
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8808461308
Commit: 5f340aecfa02bbb543603fb3cf9ac027e6823d49
Cypress dashboard:  Click here!
The following are new failures, please fix them before merging the PR:
cypress/e2e/Regression/ClientSide/EmbedSettings/EmbedSettings_spec.js
cypress/e2e/Regression/ClientSide/Fork/ForkAppWithMultipleDS_Spec.ts
cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
cypress/e2e/Regression/ClientSide/OtherUIFeatures/UpdateApplication_spec.js
cypress/e2e/Regression/ClientSide/Workspace/Workspace_validation_spec.js
cypress/e2e/Regression/ServerSide/AppLevelImport/AppImportwithDS_Spec.ts
cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad2_Spec.ts
cypress/e2e/Regression/ServerSide/QueryPane/DSDocs_Spec.ts
To know the list of identified flaky tests - Refer here

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features

Default port settings added for multiple datasources, simplifying configuration for ArangoDB, MongoDB, MySQL, PostgreSQL, and others.

Bug Fixes

Enhanced error messages for better guidance on missing information during datasource connections.

Tests

Increased test coverage to validate default port settings across different datasources, ensuring reliability in automated checks.

/build-deploy-preview skip-tests=true


Externalize jdk.attach API usage

The purpose is to be able to build with Java 11+

:x: Build jmxtrans 492 failed (commit https://github.com/jmxtrans/jmxtrans/commit/2561c9c3fd by @gquintana)

:x: Build jmxtrans 492 failed (commit https://github.com/jmxtrans/jmxtrans/commit/2561c9c3fd by @gquintana)

:white_check_mark: Build jmxtrans 494 completed (commit https://github.com/jmxtrans/jmxtrans/commit/637c4ea6f2 by @gquintana)

:white_check_mark: Build jmxtrans 494 completed (commit https://github.com/jmxtrans/jmxtrans/commit/637c4ea6f2 by @gquintana)


Is there a better way to write this scenario in terms of clarity?

I have the following reg ex which matches on multiple naming conventions:
    [a-z]{2}aip(dev|test|uat|prod)[a-z]{3}
    [a-z]{2,4}-aip-(dev|test|uat|prod)
    [a-z]{2,4}-aip-([a-z]{2})-(dev|test|uat|prod)

I want to make sure every resource in the plan file adheres to one of these 3 naming conventions. I may add more conventions in the future. I got the following scenario that works:
Scenario: Ensure that resource names follow naming conventions
        Gives I have resources defined
        When it has name
        Then it must have name
        Then its value must match the "([a-z]{2}aip(dev|test|uat|prod)[a-z]{3})|([a-z]{2,4}-aip-(dev|test|uat|prod))|([a-z]{2,4}-aip-([a-z]{2})-(dev|test|uat|prod))" regex

However its not very readable. Is there a better way of writing this that potentially would involve an example table? It needs to match one of them. If a resource does not match any of these then the test should throw a fail.

no longer relevant, closing.


Multiple dialogs on reload file v1.12-dev

Steps to reproduce:

load a box file into the editor
modify the box file outside the editor
dialogs pops up to reload
Now have to close them all or force close

Please provide more information: What OS are you using? What version of Qt?

At the time I was using Ubuntu 15.04 and I think Qt 4.5. I mostly work on windows now so I haven't had time to  test again. I will see if I can build on windows and see if the problem is still there

Seems like using Qt5 can help see issue #57


Subpanels to open with the same type as the initial panel, rather than the default profile

I set my default profile as Linux/Ubuntu. But I have multiple profiles, one for Azure, one for SSH into my Raspberry pi, one for Git CMD, etc.
When I have -say- a CMD tab opened, and I create a subpanel (ALT/Shift/+ or ALT/Shift/-) a new subpanel will be opened - splitting the screen vertically/horizontally, but this new subpanel won't be a CMD subpanel, it will be an Ubuntu subpanel, because that's my default profile.
As a user, if I'm in a CMD tab, and I open a subpanel I would expect this to continue to be CMD, not the default profile.
One implementation approach could be to open subpanels to follow whatever the initial panel was (example: I opened a PowerShell tab, and create a subpanel, so I would see this new subpanel to be PowerShell too).
One alternative, could be a  new setting to say: "open subpanels with the same type of the initial tab" or "open subpanels with the default profile".

So, you can set this up yourself. Right now, we offer three bindings (by default);

alt+shift+d: open auto-sized split with the current active profile
the two you are talking about, which open the default profile

Fortunately, you can configure customize any key binding. For the split pane ones, you can add "splitMode": "duplicate"

Thank you, " alf+shif+d" works fine indeed!


Add a Skeleton class

A lot of the Skan API consists not of standard SciPy classes, as originally intended, but of bundles of such classes. For example, the skeleton_to_csgraph method returns a sparse matrix and two numpy arrays (one of coordinates and another of degrees).
This was rapidly becoming too unwieldy to do complex things. The goal of the Skeleton class is to bundle together all the information we want about a skeleton, including paths, junction coordinates, and path statistics. This should simplify complex computations on the skeleton graph.

Coverage increased (+0.09%) to 99.372% when pulling 2575d4b32ea78d184b82ef384408da5176fd24e8 on skeleton-class into f16bca39d7f9968678890c92b07a48871868adbb on master.


Translations for United States of America

The 'en' locale has a translation for the US as 'United States', where I believe this should be 'United States of America' as per
https://github.com/countries/countries/pull/384
See in lib/countries/cache/locales/en.json file

The translated country names JSON files are generated from i18n_data, which uses data from pkg-isocodes.
That data set does not use ISO country names, but instead what you could call "common" country names, such as 'United States' instead of 'United States of America' or 'United Kingdom' instead of 'United Kingdom of Great Britain and Northern Ireland'
In this gem, you have both the ISO names and the translated "common" names, please see https://github.com/countries/countries#names--translations for the methods corresponding to each


Issue: cannot play key U with midi output from composed song in Genshin Music Nightly

Using the midi file downloaded from composed song in https://specy.github.io/genshinMusic/#/ the player cannot play the key U in keyboard. Attached file for reference contains the midi output and the corresponding .json file to import to Genshin Music Nightly.
key U lyre player.zip

The MIDI output of the tool is wrong, it outputted the "U" key in the C6 key as seen from MidiEditor
The output also produces an error from the MIDI Parser, which I don't actually know what causes this, you have to ask the creator of the tool about this, not in here.

The key is too high, so therefore it shifted back to C5 which is Q on the keyboard. You know that is the case because if you shift the key up one tone to C#3, it will now become G5 which now becomes U on the keyboard.


.env & .debug

require("@terse/webpack").env === (process.env.NODE_ENV || "development")
require("@terse/webpack").debug === (
  env === "development"
  ||
  env === "testing"
);

This useful when configuring the .api().

No need for .env() anymore, IMO.

@ericclemmons looking at the Webpack CLI I am wondering if the --env flag is intended to be equivalent to NODE_ENV.
Could we make it so that env() accepts whatever, and the when function runs against whatever is in there? In most cases it will be the same but given that --env is the only flag webpack really gives you the freedom to say whatever you want, and it is the only arg that gets passed to a function in your config file (besides options, which are limited to what webpack cli accepts), it would be nicer to not assume that the only valid options are what you would have in your NODE_ENV

@datapimp Can you make up a code example of how that'd look?  I had plans for .when to support both string|function, so that you can do things like:
.when(
  // Should return `true` when condition matches
  (...) => ...,
  // Conditional config
  (api) => ...
);

I'm in the process of migrating a project to use webpack, and went with this project as the configuration builder
I settled on doing something like this: https://github.com/OpenCollective/opencollective-website/blob/webpack-2/frontend/webpack.config.babel.js#L11 which probably makes more sense anyway given that the target was what I was trying to branch off of.
Still, I'd love to have just the one simple module.exports = require('@terse/webpack') since it reads so nicely -- having only one thread to follow top to bottom is great.  So I think your string|function would be perfect for that.
I was in the middle of submitting a PR which added support for something like:
.when({ target: 'web', env: 'production' }, (api) => (
  api.plugin('webpack.UglifyJsPlugin', {})
)

so if you like I can add a function as well.


How to style scrollbar?

Hello,
I'm trying ScrollArea component with following structure

            <ScrollArea className="w-full h-[100vh]">

Contacts

                    {
                        Array(30).fill(null).map((u, i) => (
                            <OnlineUser key={i}/>
                        ))
                    }

                <ScrollBar
                    className="scrollbar-thumb-rounded-full scrollbar-track-rounded-full scrollbar scrollbar-thumb-sky-700 scrollbar-track-sky-300"
                />
            </ScrollArea>

scrollbar-* classes are from the package tailwind-scrollbar. This classes work perfectly with any element but this or any other custom class is not working with the Scrollbar component. Am I doing anything worng? Whats the way to style the scrollbar?

@apudiu When installing the scrollarea component, there will be:
const ScrollBar = React.forwardRef<
   React.ElementRef<typeof ScrollAreaPrimitive.ScrollAreaScrollbar>,
   React.ComponentPropsWithoutRef<typeof ScrollAreaPrimitive.ScrollAreaScrollbar>
>(({ className, orientation = "vertical", ...props }, ref) => (
   <ScrollAreaPrimitive.ScrollAreaScrollbar
     ref={ref}
     orientation={orientation}
     className={cn(
       "flex touch-none select-none transition-colors",
       orientation === "vertical" &&
         "h-full w-2.5 border-l border-l-transparent p-[1px]",
       orientation === "horizontal" &&
         "h-2.5 flex-col border-t border-t-transparent p-[1px]",
       className
     )}
     {...props}
   >
     <ScrollAreaPrimitive.ScrollAreaThumb
       className={cn(
         "relative rounded-full bg-border",
         orientation === "vertical" && "flex-1"
       )}
     />
   </ScrollAreaPrimitive.ScrollAreaScrollbar>
))
ScrollBar.displayName = ScrollAreaPrimitive.ScrollAreaScrollbar.displayName

The ScrollAreaPrimitive.ScrollAreaThumb will be where you do the styling. If you want to use it outside the component, use a children in ScrollBar, to better understand see doc (link).

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

ScrollArea is a little hard to use, something it is just easier to drop a overflow-auto, was wondering if we can have matching style from the ScrollArea to the normal scroll bar

@FrancescoSaverioZuppichini You can paste the following styles on your globals.css, it gives most of Scroll-area component styles to the normal scrollbar

::-webkit-scrollbar {
    @apply w-2.5 h-2.5;

}

::-webkit-scrollbar-track {
    @apply bg-transparent
}

::-webkit-scrollbar-thumb {
    @apply rounded-full bg-border border-[1px] border-transparent border-solid bg-clip-padding;
}

@FrancescoSaverioZuppichini You can paste the following styles on your globals.css, it gives most of Scroll-area component styles to the normal scrollbar
::-webkit-scrollbar {
    @apply w-2.5 h-2.5;

}

::-webkit-scrollbar-track {
    @apply bg-transparent
}

::-webkit-scrollbar-thumb {
    @apply rounded-full bg-border border-[1px] border-transparent border-solid bg-clip-padding;
}

For me, this classes wasn't working as I was also putting html styles within the base directory 😅
   html {     scrollbar-width: thin;     scrollbar-color: rgb(20 21 27) transparent;     scrollbar-gutter: stable;     scroll-behavior: smooth;     scroll-margin: 0;     scroll-padding: 0;   }

If you want to hide or change the color in a specific area, you can use the following code:
<ScrollBar
  style={{ "--border": "transparent" }}
/>

By default, the Shadcn ScrollThumb uses bg-border, allowing you to easily override the border background for any component that requires a custom scrollbar color

you can  call the scroll area like this
<ScrollArea scrollbarColor={"#CB3CFF"}>
and edit the main component like this
"use client"
import * as React from "react"
import * as ScrollAreaPrimitive from "@radix-ui/react-scroll-area"
import { cn } from "@/lib/utils"
const ScrollArea = React.forwardRef<
React.ElementRef,
React.ComponentPropsWithoutRef & { scrollbarColor?: string }

(({ className, children, scrollbarColor , ...props }, ref) => (
<ScrollAreaPrimitive.Root
ref={ref}
className={cn("relative overflow-hidden", className)}
{...props}

<ScrollAreaPrimitive.Viewport className="h-full w-full rounded-[inherit]">
  {children}
</ScrollAreaPrimitive.Viewport>
**<ScrollBar scrollbarColor={scrollbarColor} />**
<ScrollAreaPrimitive.Corner />

</ScrollAreaPrimitive.Root>
))
ScrollArea.displayName = ScrollAreaPrimitive.Root.displayName
const ScrollBar = React.forwardRef<
React.ElementRef,
React.ComponentPropsWithoutRef & { scrollbarColor?: string }

(({ className, orientation = "vertical", scrollbarColor = "pink", ...props }, ref) => (
<ScrollAreaPrimitive.ScrollAreaScrollbar
ref={ref}
orientation={orientation}
className={cn(
"flex touch-none select-none transition-colors",
orientation === "vertical" &&
"h-full w-2.5 border-l border-l-transparent p-[1px]",
orientation === "horizontal" &&
"h-2.5 flex-col border-t border-t-transparent p-[1px]",
className
)}
style={{
"--scrollbar-color": scrollbarColor,
}}
{...props}

<ScrollAreaPrimitive.ScrollAreaThumb
  className="relative flex-1 rounded-full"
  style={{
    backgroundColor: scrollbarColor,
  }}
/>

</ScrollAreaPrimitive.ScrollAreaScrollbar>
))
ScrollBar.displayName = ScrollAreaPrimitive.ScrollAreaScrollbar.displayName
export { ScrollArea, ScrollBar }
herei have passed the prop so you can pass any color like this
scrollbarColor={"#CB3CFF"}

In shadcn component folder, every component has it's own unique file, by which you can modify your component and style it. Let's say you want to add new style to your scroll bar,,, you should go there and Manipulate directly the source code. As for Scrollbar => <ScrollAreaPrimitive.ScrollAreaThumb className="relative bg-accent flex-1 rounded-full bg-border" />


Modify constructor to enable const std::string& as a first argument

Modify constructor signature to be able to use it passing const std::string & as a first argument.

Thanks!


first step in fixing #453 by providing an optional nvdApiKey to depen…

…dency-check

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.631%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
3375

Relevant Lines:
8107

💛  - Coveralls


Label node as 'submariner.io/gateway=true' failed on ROSA

To enable Submariner GW deployment we need to label one or more nodes as 'submariner.io/gateway=true' ,
Label node using [1] command failed on ROSA platform.
To work around this issue I created new node/nodes using 'rosa create machinepool' API [2] .
[1]
$ oc label --overwrite node ip-10-0-171-134.ec2.internal   submariner.io/gateway=true
Error from server (Prevented from accessing Red Hat managed resources. This is an effort to prevent harmful actions that may cause unintended consequences or affect the stability of the cluster. If you have any questions about this, please reach out to Red Hat support at https://access.redhat.com/support.
To modify node labels or taints, use OCM or the ROSA cli to edit the MachinePool.): admission webhook "regular-user-validation.managed.openshift.io" denied the request: Prevented from accessing Red Hat managed resources. This is an effort to prevent harmful actions that may cause unintended consequences or affect the stability of the cluster. If you have any questions about this, please reach out to Red Hat support at https://access.redhat.com/support.
To modify node labels or taints, use OCM or the ROSA cli to edit the MachinePool.
[2]
rosa create machinepool --cluster=yb-rosa  --name=sm-gw-mp --replicas=2 --labels='submariner.io/gateway=true'

I think it would be good to understand how ARO behaves as well.

According to feedback from ARO experts, adding new labels to nodes is possible with CLI [1]  using the 'oc label node ' command
[1]
https://docs.microsoft.com/en-us/azure/openshift/tutorial-connect-cluster#connect-using-the-openshift-cli

@nyechiel @sridhargaddam Well, since this is the expected behavior (labeling node isn't allowed ) for ROSA clusters, I think we shouldn't treat it as Submariner bug. Do you think we can close this one (and just document the workaround ) ?

@nyechiel @sridhargaddam Well, since this is the expected behavior (labeling node isn't allowed ) for ROSA clusters, I think we shouldn't treat it as Submariner bug. Do you think we can close this one (and just document the workaround ) ?

Fine with me.

This is not a Submariner bug (labeling and annotating nodes is blocked on ROSA), in order to allow Submariner gateway deployment new machinepool (see [1]) should be created.
We should document this step and close this bug.
[1]
rosa create machinepool --cluster= --name=sm-gw-mp --replicas=2 --labels='submariner.io/gateway=true'


Consider exit utxos as part of the wallet

When a user does a unilateral exit, the output of the exit tx has a short relative timelock before the user can spend them. But as soon as that exit tx is confirmed, only the user can spend the output (just with the short delay). Currently, we only consider them part of our online wallet once a users explicitly spends these outputs into its regular onchain wallet. But this is not necessary. As soon as the relative timelock has passed, they could be considered part of the onchain wallet's UTXOs just like any other, just with a different way to spend them.
Also see https://github.com/ark-bitcoin/bark/pull/29#discussion_r1709612249

Moved to https://codeberg.org/ark-bitcoin/bark/issues/1.


Remove Sonar Integration

PR description
Sonar has been removed from the build workflow. This PR removes all
configuration and code markings that were used to facilitate it.
Fixed Issue(s)

Documentation

[ ] I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Changelog

[ ] I thought about the changelog and included a changelog update if required.

we did have a go at fixing it here #3970 but haven't had bandwidth to get back to this

That PR can restore sonarqube when it is ready.  But master has been showing red for a month, and that is not good.


Add eval loader to eval script

@dakinggg

a training run with an eval loader

mpt-1b-ctx-8k-gpus-8-3IPwqf

an eval run with an eval loader

mpt-eval-YwAj8C (stopped early)


Support for sessionStorage?

Is there any interest from anyone else in support for sessionStorage as an alternative to localStorage?
There are times when I just want to keep the data for the browser session.  Mostly logged-in user info for a client side app.

Store.js v2.0 has been released with support for sessionStorage!
If you update to the latest version you will automatically get this functionality plus a bunch more :)
The docs explain how to create a custom build - to get one that only uses sessionStorage, you can do this:
// Example custom build usage:
var engine = require('../store-engine')
var storages = [require('store/storages/sessionStorage')
var plugins = []
var store = engine.createStore(storages, plugins)
store.set('foo', 'bar')


Android system warns that our app is draining battery

Is anyone else with an Android Nougat phone getting this notification when leaving the app open? I leave most apps open without getting such a warning, so I'm wondering if we need to look into how to reduce battery usage.

Does anyone get these warnings currently? @maskaravivek and I haven't noticed them since 2.7.

Closing this as there are no further reports of the issue.


Add office world

Summary

[ ] Add usd/usda of the office world.
[ ] Provide a way to select that world to be launched via ros launch.

Superseded by https://github.com/Ekumen-OS/andino_isaac/issues/24


Unit test for fusion upload and formatting

For AE-23-273-GEN
Unit test that checks whether fusions have been uploaded to the database for TSO500 RNA and whether they are uploaded with the correct formatting. e.g NCOA4/RET to NCOA4-RET
Resolves #87 and #97

Thanks Erik, I understand the changes made and why


Inquiry about Implementation of "Aloha Unleashed"

First and foremost, I would like to extend my heartfelt gratitude for your incredible work on the Lerobo project.
I recently came across the paper "Aloha Unleashed" published by the Aloha team a few months ago, and I am curious to know if there are any plans to implement the methodologies and findings from this paper into the Lerobo project.
Thank you once again for your hard work and for providing such a fantastic tool to the community. I look forward to your response.
paper link：https://aloha-unleashed.github.io/

Hello @lightfate , we already have native support for Aloha robot, so we could reproduce Aloha Unleashed. It is on our TODO list, but I can't provide a date.
If the authors were to provide a dataset or pretrained model, it would greatly help us prioritize this!


Throttle noisy/bad clients

We should probably limit the number of requests per IP to something like ~10 requests per minute.

Done by 8b8519be06fc53f841a6ea30309e70da28a8818b.


Customizing InputCallout Font

I have been struggling to fully understand how to apply a custom InputCalloutStyle to the keyboard (to use a custom font). With button styles I can see that that are passed through a StyleService into the KeyboardController. This connection makes sense. With the Callouts though I can't seem to find the connection. I think I am missing something.
Would you happen to have an example of how to do this?
Thanks

Hi @NeilSureshPatel
You can set the callout fonts by applying a custom Callouts.InputCalloutStyle and Callouts.ActionCalloutStyle.
The intended design is to apply these with an .inputCalloutStyle(...) and .actionCalloutStyle(...) view modifier, which is how it will work in KeyboardKit 9, but in KeyboardKit 8 you have to create a custom style service and override these style builders.

I will add this ticket to the KeyboardKit 9 milestone, and mark it as done when it's fully implemented.

Thanks @danielsaidi. The view modifier method is what I was trying so that explains why it didn't work. I look forward to this working in KeyboardKit 9. In the mean time, I am trying to make a custom callout service, and I am a bit lost on how to point to my custom Callouts.InputCalloutStyle. I don't see an overridable function or initializer that I can use in the callout service as there is in the layout service and style service. I apologize I am bit new to SwiftUI so I think I may be missing something.

I have finished refactoring the callout style in KeyboardKit 9 now.
Styling is a LOT easier now, and can either be done with a view modifier, or by creating a custom style provider (will be removed in KeyboardKit 10). The callout namespace now only has a single style and a single context to handle both callouts.
For instance, this is how the SwiftUI preview adjusts the callout style for the input callout:


Moxie jail.

FID : 416704
USER ID : puresmile
I'm a regular user who loves moxie. I think I went to jail because of the quick reaction of recasts, likes, and comments. This situation is so sad. Please help.

I'm not even a bot, I'm just a regular user. Please help me.

Please get me out of jail.


refactor(playground): use layout in components

All i have left to do is reintroduce an app.vue to the main package for dev. Not sure if it should be bare bones or a copy of playground.


Add a language selector to the Mismatch Finder layout

This allows changing the interface language from the UI.
(rather a large PR but i couldn't think of a way to split it that made sense)
Bug: T328149

I get the above errors locally as well, although the SVGs are displayed in the UI. Might be a path issue


Merge the Apps Functionality topic into the Structure topic

Summary
This PR merges the Apps Functionality topic into the Apps Structure topic.
Specifically sections on Forms and Embedded Bindings are added.

Hello @neflyte,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


#2191 for encrypt test

Fixes #ISSUSE_ID.
Changes proposed in this pull request:

Pull Request Test Coverage Report for Build 8049

0 of 5 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 17.918%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-sql-test/src/main/java/org/apache/shardingsphere/test/sql/EncryptSQLCasesLoader.java
0
5
0.0%

Totals

Change from base Build 8048:
-0.002%

Covered Lines:
8659

Relevant Lines:
48325

💛  - Coveralls


how could i record reponse body and surpport non-standard http status code both

I record the response body by creating ServerHttpResponseDecorator, it works correctly. but when the back-end service return with a non-standard http status code，the gateway throw exception. because ServerHttpResponseDecorator not supports  non-standard http status code, while AbstractServerHttpResponse supports
In NettyRoutingFilter.java:
HttpStatus status = HttpStatus.resolve(res.status().code());
if (status != null) {
response.setStatusCode(status);
} else if (response instanceof AbstractServerHttpResponse) {
// https://jira.spring.io/browse/SPR-16748
((AbstractServerHttpResponse) response).setStatusCodeValue(res.status().code());
} else {
throw new IllegalStateException("Unable to set status code on response: " + res.status().code() + ", " + response.getClass());
}
how could i record reponse body and surpport non-standard http status code both?

Please learn how to format code on GitHub.
Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

@ryanjbaxter @spring-issuemaster here is the code link: https://github.com/Ares163/gateway-demo, thanks


Change Series.clip to work with numpy.clip

from @bburan
I always find Series.clip() a bit confusing because the order of
arguments are reversed compared with Numpy's clip() method:

Series.clip(self, upper=None, lower=None)
numpy.clip(a, a_min, a_max, out=None)

Also, the following doesn't work well:

x = Series(data=np.random.uniform(size=10))
np.clip(x, 0.4, 0.6)

I think numpy.clip is checking for the existence of the clip() method
on the Series and attempting to pass the arguments to Series.clip().
Since Series.clip() doesn't support the axis argument this approach
fails.  Ideally, I'd prefer to be able to use clip() without having to
check whether the data is a numpy.ndarray or pandas.Series object.

fixed in the above commit. thanks for the bug report


Incorporate tag cleaning algorithm into Tag model

This could guess at which tags should match, or be more complex and return suggestions so that a user could manually respond yes or no.

I think more accurately some of the rules and verifications should be included here.
But I think just as appropriately the rest should be in the client - it is currently unclear where the split in responsibility best lies.

It would also be good to have an admin tag management facility - add, remove, modify tags, and see stats on tag usage.


HB-5511: [<IP_ADDRESS>.0] lower minimum AppLovin version to 11.5.5 for ZADE

Adapter release process doc: https://chartboost.atlassian.net/wiki/spaces/HM/pages/2484174870/Adapter+Development+Guide

Close this backward release and cherry-pick the CHANGELOG.md changes only (PR #37).


cannot use absolute path in ReadExtractor

Hi Inigo,
I think this is inconvenient to users used to using absolute path in their script:
https://github.com/iprada/Circle-Map/blob/ed88ff67634389f70aefc0b4e94566bc20897a16/circlemap/extract_circle_SV_reads.py#L64
https://github.com/iprada/Circle-Map/blob/ed88ff67634389f70aefc0b4e94566bc20897a16/circlemap/extract_circle_SV_reads.py#L88
Best regards
JY

Dear @jinyung,
You are absolutely right. I wish 6 years ago Inigo was a better programmer.
Right now I am busy with other projects, and have limited time to dig into this. Would you be up for making a pull request?
I'll gladly accept one!


NetworkXError: cannot tokenize 'graph[directed 1node

After installed dowhy and its dependencies, I tested the simple example https://github.com/Microsoft/dowhy#sample-causal-inference-analysis-in-dowhy, and encountered the problem.
After running the code:
model=CausalModel(
data = df,
treatment=data["treatment_name"],
outcome=data["outcome_name"],
graph=data["gml_graph"]
)
the error come out:
NetworkXError: cannot tokenize 'graph[directed 1node[ id "v" label "v"]node[ id "y" label "y"]node[ id "Unobserved Confounders" label "Unobserved Confounders"]edge[source "v" target "y"]edge[source "Unobserved Confounders" target "v"]edge[source "Unobserved Confounders" target "y"]node[ id "X0" label "X0"] edge[ source "X0" target "v"] node[ id "X1" label "X1"] edge[ source "X1" target "v"] node[ id "X2" label "X2"] edge[ source "X2" target "v"] node[ id "X3" label "X3"] edge[ source "X3" target "v"] node[ id "X4" label "X4"] edge[ source "X4" target "v"]edge[ source "X0" target "y"] edge[ source "X1" target "y"] edge[ source "X2" target "y"] edge[ source "X3" target "y"] edge[ source "X4" target "y"]node[ id "Z0" label "Z0"] edge[ source "Z0" target "v"] node[ id "Z1" label "Z1"] edge[ source "Z1" target "v"]]' at (1, 1)

Hey @qvz thanks for raising this. I checked and it looks like this is a problem due to version mismatch with networkx. Can you try upgrading networkx to the latest version?
If the problem still persists, do share the python 3 version and networkx version you are using here.

@qvz any update?

Closing due to inactivity. @qvz let us know if you still face this problem.


Creating underground pipes sometimes skip pumpjacks

Still a wonderful mod, can't play without it. ;D Found an occasional error where a pumpjack would be skipped after an underground section is created. I've not been able to figure out what caused it, just how it looks at the end.

As per the request on the mod page, I attach pump_planner_input.zip (for the oil field detailed above). I also provide a minimal save (Editor Extensions only as "cheat" along with P.U.M.P.) detailing the two oil fields where I found this issue.

Fixed the issue. It seems to be slightly luck-bound and order-of-execution sensitive.
You were correct that it is the underground section of another pump that caused the issue of the pump not connection.
Or more precisely, P.U.M.P. plans out all pipes above ground first. And after the layout is complete it'll bury stretches of straight pipes. Unfortunately, the information it shouldn't bury the output of the pumps sometimes got overwritten.
In both your screenshots the pump missing the pipe was planned first, the output of the pipe was marked as essential to keep above ground. But that essential flag got removed/overwritten when the pump to the right of it got planned, and plotted its pipe right on top of it and thus marking it as regular pipe instead. Later on the pipe-burying routine no longer has the info to keep that particular pipe above ground; therefor, unconnected pump.
Had the pump on the right be planned first, and the pump the left planned on top of it, the issue wouldn't be there, as no essential markings would've been deleted.
Issue is fixed by checking if a pipe has already been planned for a tile before planning a regular pipe on top of it.


[Feature] Several xtra details

Short summary
https://api.ipgeolocation.io/astronomy provides some extra details?
Detailed description
Hi,
thanks for creating this integration, and your card! (got your link via the bio you mentioned in custom:button-card /-) )
Since this is not a bug report at all, please let me add below info as a FR. It's more of a FYI though, not requesting anything perse.
I noticed that your CC does not have a few of the interesting details the https://api.ipgeolocation.io/astronomy provides
I am using this rest:
rest:

  - resource: https://api.ipgeolocation.io/astronomy
    scan_interval: 1200
    params:
      apiKey: !secret ipgeolocation_api
      city: Roosendaal
#       country: Netherlands

    sensor:

      - unique_id: maan_astronomy
        value_template: >
          {{'Op' if value_json.moon_altitude > 0 else 'Onder'}}
        json_attributes:
          - date
          - current_time
          - sun_distance
          - moonrise
          - moonset
          - moon_status
          - moon_altitude # <-----
          - moon_distance
          - moon_azimuth # <-----
          - moon_parallactic_angle #<------

and have those extra details available.
Ive added them in a simple compound card like this:

Figured you might want to know the availability and maybe add them to your CC's options.
thanks!
Examples 🖼
No response
Additional context 🗒
No response

Hi, I have already finished the new version with these additional data sensors .. I will change a few details and prepare for release... Thanks for the suggestion 😄

thx, but it is more of a card-mod exercise than a layout of that card:
type: custom:mod-card
card_mod:
  style: |
    :host {
      --stack-card-gap: 0;
    }
card:
  type: vertical-stack
  cards:
    - type: custom:horizon-card #sun-card
      moon: true
      fields:
        sunrise: false
        sunset: false
        dawn: false
        noon: false
        dusk: false
      card_mod:
        style: |
          .horizon-card {
            padding: 0px !important;
            margin: -16px -4px -16px -8px;
          }

    - !include /config/dashboard/includes/include_zon_multiple_row.yaml

    - !include /config/dashboard/includes/include_maan_multiple_row.yaml

maan multiple-row:
type: entities
card_mod:
  style: |
    ha-card {
      box-shadow: none;
      margin: -4px 0px 0px 0px;
    }
    .card-content {
      padding: 0px 8px 8px 0px;
    }
entities:
  - entity: sensor.moon
    type: custom:multiple-entity-row
    card_mod:
      style:
        hui-generic-entity-row $: |
          .info {
            display: none;
          }
        .: |
          .entities-row {
           width: 100%;
           justify-content: space-evenly !important;
          }
    state_color: true
    show_state: false
#         name: false
    entities:
      - type: attribute
        entity: sensor.maan_astronomy
        attribute: moon_altitude
        name: Hoogte
      - type: attribute
        entity: sensor.maan_astronomy
        attribute: moon_azimuth
        name: Azimuth
      - type: attribute
        entity: sensor.maan_astronomy
        attribute: moonrise
        name: Op
        format: time
      - type: attribute
        entity: sensor.maan_astronomy
        attribute: moon_parallactic_angle
        name: Hoek
      - type: attribute
        entity: sensor.maan_astronomy
        attribute: moonset
        name: Onder
        format: time
      - type: attribute
        entity: sensor.maan_astronomy
        attribute: moon_distance
        name: Afstand

zon multiple row
type: entities
card_mod:
  style: |
    ha-card {
      box-shadow: none;
      margin: -4px 0px 0px 0px;
    }
    .card-content {
      padding: 0px 8px 8px 0px;
    }
entities:
  - entity: sun.sun
    type: custom:multiple-entity-row
    card_mod:
      style:
        hui-generic-entity-row $: |
          .info {
            display: none;
          }
        .: |
          .entities-row {
           width: 100%;
           justify-content: space-evenly !important;
          }
    state_color: true
    show_state: false
#         name: false
    entities:
      - entity: sensor.sun_solar_elevation
        name: Hoogte
        unit: false
      - entity: sensor.sun_next_dawn
        name: Dageraad
        format: time
      - entity: sensor.sun_next_rising
        name: Op
        format: time
      - entity: sensor.sun_next_noon
        name: Middag
        format: time
      - entity: sensor.sun_next_setting
        name: Onder
        format: time
      - entity: sensor.sun_next_dusk
        name: Schemer
        format: time
      - entity: sensor.sun_next_midnight
        name: Nacht
        format: time

New sensors added in v0.2.0 🎉


Text input field not allowing to type space

Whenever I add keyboard navigation utility to a text input field it won’t let me type space between words. I viewed the package code; in the handleKeyPress function the event default for a Space key press case is being prevented. I’ll raise a PR when I can.

Pull request has been merged.


fix frontend : highlight active assistant text and maintain chat seq | for

highlight active assistant text and maintain chat seq
new typing seq.webm
for #476
This PR instead of #531

needs some wrangling to find bugs.
note: potential for bugs resides in side effects (useEffects).

This is working great!
The one bug I see is that if it prints several lines, the go below the fold, and you have to scroll down to see the full message

@rbren I have added a new commit which alters the autoscroll behaviour.
new autoscroll.webm

👍 let's get this one in


CPU: Add support for displaying temp as Fahrenheit

Description
This works on Linux and BSD but it's untested on BSD.
Note: This probably won't be merged.
Note: I accidentally included #574 in this PR.

Works in BSD :+1:


unclean shareAll output with some packages (out of memory/import errors)

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
I also see errors for files that aren't even modules - like changelog.md from some node_module package.
./node_modules/vanilla-jsoneditor/CHANGELOG.md:1:1 - Error: Module parse failed: Unexpected character ' ' (1:1)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders

Likely because the config output from shareAll contains:
'vanilla-jsoneditor/CHANGELOG.md': {
singleton: true,
strictVersion: true,
requiredVersion: '^0.23.8',
eager: true,
pinned: true,
version: '0.23.8'
},
etc  - css, map, md, d.ts etc are included  depending on package types.
Perhaps shareAll might needs some filter to exclude non-important files from it's exports. It's likely ES6 package.

you can use the skip array to exclude such packages.


Bump sbt to 1.2.6; update dependencies

I was running into problems with transitive dependencies, specifically:
Symbol 'term org.junit' is missing from the classpath.
I suspect this is due to interaction between the latest version of sbt and org.scala-sbt.ivy. It may be because junit is special - it's pure Java and independent of the Scala compiler. Forcing a more recent version of junit seemed to resolve those problems.
If I remember correctly, forcing an explicit version of sc_opts resolved similar issues there.
I should have mentioned this with the PR.


"Jijia", "Mășcăteni" and "Tudor Vladimirescu" are listed in the drop-down menu

Description:
"Jijia", "Mășcăteni" and "Tudor Vladimirescu" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Jijia" in the search bar.

Expected results
The location is listed in the drop-down menu as "Jijia, Botoșani (Albești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Mășcăteni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Mășcăteni, Botoșani (Albești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Tudor Vladimirescu" in the search bar.

Expected results
The location is listed in the drop-down menu as "Tudor Vladimirescu, Botoșani (Albești)".


Fixing search in homepage.

Fixes #74.
The theme require an h1 element in the page for listening the scroll events on Js side. Without an h1 the whole js was breaking therefore, the search wasn't working

I'm merging and proceeding with the rebase in asf-staging and asf-site