Could inspect device. Error was: Could not connect to device, token needs to be specified

Hello,
I receive "Could inspect device. Error was: Could not connect to device, token needs to be specified" when I try to inspect a device ( miio inspect <IP_ADDRESS>). I have the token, but how should I use it in CLI for the "inspect"?
miio inspect <IP_ADDRESS> xxxxxxxxxxxxxxxxx is not working, "xxxxxxxxxxxxxxxxx ", token: xxxxxxxxxxxxxxxxx also not working.
Have found nothing about right arguments for inspect command.

same here, I thinks some update might have broken things, I'm just triying to assimilate mi new Mi air2 today and so far i'm been unable.
After reset I can do inspect(though no capabilities reported):
~$ miio inspect xxxxxxxx
Device ID: xxxxxxxx
Model info: zhimi.airpurifier.mc1
Address: <IP_ADDRESS>
Token: ffffffffffffffffffffffffffffff via auto-token
Support: At least generic
Type info: miio
Capabilities:
Firmware version: 1.4.3_21105
Hardware version: MW300
WiFi: . (FF:FF:FF:FF:FF) RSSI: -256
WiFi firmware version: SD878x-14.76.36.p84-702.1.0-WM
Remote access (Mi Home App): Maybe
then I'm unable to change token,
:~$ miio tokens update xxxx --token<PHONE_NUMBER>3456781234567812345678
INFO  Updating token for xxxxx
INFO  Connected to miio:xxxxxxx  - trying to change token
ERROR  Could not update token, double-check the given token
After configuring wifi, I cannot access anymore, becouse lack of knowling how to specify token
~$ miio inspect XXXXX token  XXXXXXXXX
INFO  Attempting to inspect XXXXXXXX
ERROR  Could inspect device. Error was: Could not connect to device, token needs to be specified
Have tried:
miio inspect XXXXX token  TTTTTTTT
miio inspect XXXXX --token  TTTTTTTTTTT
miio inspect XXXXX  TTTTTTT

To specify a token, please try the following command:
miio tokens update ip-of-device —token the-token

I have some problem
miio tokens update <IP_ADDRESS> --token 74271585b1ef517df210f62de4c717aa

 ERROR  Could not update token, double-check the given token

I believe that the token changes every second. I have fired this into my network, every second one command. The effect was that the code 'f37...' and 'f38....' and 'f39...' and so forth changed every second.
$ echo -ne '\x21\x31\x00\x20\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff' | nc -W1 -u 192.168.x.x 54321|xxd -p|egrep -v "^ffff$"
12345670000000001234567800000f37ffffffffffffffffffffffffffff
$ echo -ne '\x21\x31\x00\x20\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff' | nc -W1 -u 192.168.x.x 54321|xxd -p|egrep -v "^ffff$"
12345670000000001234567800000f38ffffffffffffffffffffffffffff
$ echo -ne '\x21\x31\x00\x20\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff' | nc -W1 -u 192.168.x.x 54321|xxd -p|egrep -v "^ffff$"
12345670000000001234567800000f39ffffffffffffffffffffffffffff
$ echo -ne '\x21\x31\x00\x20\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff' | nc -W1 -u 192.168.x.x 54321|xxd -p|egrep -v "^ffff$"
12345670000000001234567800000f3affffffffffffffffffffffffffff
$ echo -ne '\x21\x31\x00\x20\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff' | nc -W1 -u 192.168.x.x 54321|xxd -p|egrep -v "^ffff$"
12345670000000001234567800000f3bffffffffffffffffffffffffffff

So my theory is that once we're synced with the other side, we know what we have to send as a token at that given second.
The parts with 12345... are masked/greyed out by me.
Your thoughts? Could that be a route to get miio working again in those cases where obtaining a token wouldn't work?


The component doesn't work on Firefox 39.0

I'm facing 1 critical issue on the component on my app. Using Firefox browser 39.0, we cannot select the date on datepicker.
I tried to check on the demo page of the component and got the same issue.

Please help to clarify and fix it.
Regards,
Tin Nguyen

anyone can help me on the issue?

FWIW it works for me on my project.

@Tin-Nguyen This was fixed by #56 so if you get v0.0.18 or newer this should work for you

Thank you. I will check soon


Add Sphinx documentation to generate man pages

This is my first time using Sphinx, so please let me know if there's something wrong (or a less hacky way to set the description of the man page).
I also updated the dependencies and sped up the Makefile while adding the documentation generation.  As part of the documentation efforts, I have also updated the README to more accurately reflect how to build and install the project.

Don't merge this yet.  I'm considering whether it would be better to use Asciidoctor.

@ids1024 does Redox have support for Python at the moment?  That may influence this decision.

Redox has limited support for Python currently. But at the moment things are still generally cross-compiled, so don't worry about that.
You may want to look at mdbook for generating documentation, which is in Rust and is what the Rust book uses, for instance.

Alright, it's good that Python isn't an issue then.
I remember looking at mdBook and deciding against it because it could not generate man pages, which is the primary use case here.  The ability to generate HTML is more of a bonus.

@mpkh I think we should just use Sphinx, so can you merge this at some point?

@Arcterus afair we did fixed appveyor, isn't it? other than that it's fine

Apparently cp didn’t mark which version of winapi it wanted, and a breaking change just came out, so it broke.  I just pinned the dependency to the old version of winapi for now.


feat: add total difficulty to ChainInfo

This introduces a total_difficulty field to ChainInfo, so the field can be used in RPCs such as eth_getBlockByNumber and eth_getBlockByHash.
We still need to implement the BlockProvider methods on the ShareableDatabase for the output to work on the RPCs, but these methods are not yet implemented so it should be fine for now.

Codecov Report

Merging #1216 (4bc0e70) into main (4c76581) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1216      +/-   ##
==========================================
- Coverage   75.57%   75.57%   -0.01%
==========================================
  Files         339      339
  Lines       37698    37706       +8
==========================================
+ Hits        28490    28496       +6
- Misses       9208     9210       +2

Flag
Coverage Δ

unit-tests
75.57% <37.50%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/primitives/src/chain/info.rs
0.00% <ø> (ø)

crates/storage/provider/src/providers/mod.rs
16.43% <0.00%> (-0.71%)
:arrow_down:

crates/storage/provider/src/test_utils/noop.rs
8.69% <0.00%> (-0.20%)
:arrow_down:

crates/storage/provider/src/test_utils/mock.rs
53.98% <75.00%> (+0.77%)
:arrow_up:

crates/net/network/src/listener.rs
81.39% <0.00%> (-2.33%)
:arrow_down:

crates/stages/src/stages/bodies.rs
92.59% <0.00%> (-0.22%)
:arrow_down:

crates/net/network/src/manager.rs
49.43% <0.00%> (+0.18%)
:arrow_up:

crates/net/network/src/session/active.rs
86.95% <0.00%> (+0.59%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

After thinking about it a bit, I'm not sure this makes sense or is necessary for rpc. The total_difficulty field is relevant for eth_getBlockByHash / eth_getBlockByNumber, but it does not make sense to include it in ChainInfo because those RPCs return the total difficulty for the given block, not overall total difficulty.


Patchouli Book Empty

The "guide" book when the patchouli mod is installed is almost entirely empty...
so uh, what does literally everything do? the only page that is available are for crystals and holy stones (items page)

@Boundarybreaker Would you be able to look into this?

I'm getting an error during loading that indicates syntax problems in the book definition. I'm using Patchouli-1.16-38-FABRIC and composing-1.0.3+1.16.1.
[14:46:42] [main/ERROR]: Error while loading contents for book composing:composing_howto
java.lang.RuntimeException: Error building entry composing:effects/weapons
...
Caused by: java.lang.RuntimeException: Error while loading entry composing:effects/weapons page 1
...
Caused by: net.minecraft.class_151: Non [a-z0-9/._-] character in path of location: composing:small_earth_crystal,composing


WACI Share - Use DIDComm v2

Currently, WACI is using DIDComm v1.

This has been implemented now. Closing the issue.


Good way for templating

Hi,
First, thanks for the job. Really good. Starting with cordova very quickly (time to read the doc/issues ;) )
I read with attention the #145 issue and as @andreujuanc, i don't want to use Riot / Angula(arghhhh) but really like your components (light) approach with templates.
But now, i need to fetch datas through (private) REST API and don't know how to render it in a template.
OK for phonon ajax method but after ?
How can do that before page display  (in template ) ?
Can you share an example ?
Otherwise, this is a poor example of my cordova test application (index.js) :
phonon.options({
    navigator: {
        defaultPage: 'login',
        animatePages: true,
        enableBrowserBackButton: true,
        templateRootDirectory: './tpl'
    },
    i18n: null
});
var app = phonon.navigator();
app.on({page: 'pagetwo', preventClose: false, content: 'pagetwo.html'});

document.addEventListener('deviceready', function(){
    app.start();
}, false);

And index.html :

Page Two

How can I split JS in multiple files. All in index.js is not maintainable for me ;)
Thanks in advance.
BR

Hello mate!
Personally im trying to make phonon more modular and templatish. The idea is just having the page declarations, but the page-related stuff, all in the template.
For your small test, you have pagetwo.html where inside you can see the tags my web is here xD  right? Well, in the same html, you can load scripts!
It worked for me loading them outside the  tags, something like this:
<pagetwo>

oh yes

</pagetwo>

As you can see, now you have a "normal" html page. Which can be practically just tested without phonon.!
With the author we are discusing a way to make everything even easier, but as it is now, its TOTALLY workable and you should be able to do a full project with this. We are just trying to make it even more easy (who doesnt want more free time to just enjoy life right?)
BTW, what framework are you going to use to access data and bind values?

Check this: https://github.com/andreujuanc/Phonon-Framework/tree/master/examples/pizza-app-with-ractive
Im working on a ractive example for phonon. But the template structure im trying to implement should work on any other ui framework/renderer/binder.
Note that i use the phonon.ajax to get data, then i just pass the data object to ractive, which in turn "refresh" the page.

Hi @gbtux,
Thank you for trying Phonon :).
The example of @andreujuanc is perfect for your aim.
In pagetwo.html, you can start tasks concerning this page. To complete the example of @andreujuanc :
<pagetwo>

oh yes

</pagetwo>

Phonon does not contain a template engine for building components such as lists because many small and interesting libraries exist like Mustache or Handlebars. Furthermore, many people use a complete MVVM framework such as Riot, Angular, Vue, etc so I don't think that Phonon needs to have its own template engine.
But I am interested to read your point of view.
Please, let me known

Hi @Qathom,
Thanks to you and @andreujuanc for answers.
My example with Handlebars (based on ractive) works perfectly !
I think other people may be interested with a quick example (but people really interested will found that issue ;) ).
I agree with you. Choice is better ! When i discover Phonon, i don't search  a complete MVVM framework, or a complete MVVM framework with a really good architecture which can keep me a way to use what i want (a not only the complete stack).
In comparison, i like (love) Symfony. Why ? Because it's a (really) big fullstack framework for big projects, but if i need, i can use just the Routing component or Doctrine,..., Twig or others.
I think it's the good way to keep Phonon "in the edge". Many features, simple, light, but in the real world (Angular do you hear me ?).
People/Professional don't want to learn a new stack every week (and don't have this time in my world !).
Keep it robust, supported, and Phonon has a long life.
So, I need to fix last issues in my Phonon project ;) ("NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node" when i go back on the defaultPage through my side-panel....an idea ? )
Thanks for all.
PS : i can share my project if you're interested (Phonon + bower + grunt + handlebars in cordova) as a boilerplate....

"NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node" -->  phonon.js : 4417

Hi @gbtux,
Thank you for your contributions! :)
The line 4417 refers to the dependency of side panels (Snap).. did you find a fix?
If you have a "pizza sample" with Handlebars, you are welcome to make a pull request!
The idea with samples is to achieve the same tiny app with different frameworks ;).

Hi @Qathom,
Could you expand on your example? I'm using mustache for tempting but I can't figure out how to integrate it into the page. I'd like to have the title and other sections of the page templated through mustache in an elegant way, can you suggest a way to do this?
Thanks

Hi @syncai (french ?)
I use Handlebars in my Cordova project (more powerful than Mustache for me !) but it's the same for a web project.
It's a small example based on my code and simplified of course.
You have below an example on how render a list of shops (from an ajax request) in a div
BR // gbtux
1° Include library in index.html

2° in a page (for example pagetwo.html) :
`

Thanks, that makes perfect sense.
On Thu, Oct 20, 2016 at 6:36 PM, guillaume<EMAIL_ADDRESS>wrote:

Hi @syncai https://github.com/syncai (french ?)
I use Handlebars in my Cordova project (more powerful than Mustache for me
!) but it's the same for a web project.
It's a small example based on my code and simplified of course.
You have below an example on how render a list of shops (from an ajax
request) in a div
BR // gbtux
1° Include library in index.html

2° in a page (for example pagetwo.html) :
`

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/quark-dev/Phonon-Framework/issues/149#issuecomment-255247329,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APy1SSdL2iRRgLCP9Ew_iZ_Trho00RfNks5q1-zmgaJpZM4Jdyoz
.

I'd like to revisit this question. I've gotten the templating to work, however, if I add a Phonon Component (like an accordion list) it is never recognized/bound by Phonon because it seems to look for components before the templating is applied. In your example, if you were creating an Accordion List, would it function properly? If not, is there a function similar to phonon.i18n().bind() that will trigger a re-indexing of any components on a page?


Button to copy shortlink to AEP

It'd be great to have a clickable button on each AEP that copies e.g. "http://aep.dev/pagination" to the clipboard.

+1, I like that idea. Where to locate it? Perhaps on the title of the sidebar component? Make the heading have a link based on the slug permalink, with a helpful icon next to it?

Makes sense to me!


Backup/restore multiple (but not all) packages

e.g.
./backup-app.sh com.nxp.taginfolite  org.kde.kdeconnect_tp user@host:/my/folder/backup
./restore-app.sh com.nxp.taginfolite  org.kde.kdeconnect_tp

The idea is good.
But the solution could be improved.
I suggest using file such as applist to use as input
There is apps available that list files in specific formats. The output can be edited then used.

https://github.com/onyxbits/listmyaps
So, command would be:

./backup-app.sh applist user@host:/my/folder/backup

As a minimum, applist would include package names of all apps you want to backup, one per line.

This could be realized like so:
./backup-app.sh $(cat applist) user@host:/my/folder/backup

without having to implement file loading or parsing 😉


Selected event item indicator

Add active prop and class to EventItem, with corresponding styles.
Moved the <Link> to wrap the entire item (still inside EventItem).
Added a titleCase() utility function so as to not need lodash for something so simple.
Added a top offset for the target scrollOffset, so that the active item isn't right up against the top

Looks pretty good.
How a bout a soft inner shadow or something? Also, did you try where the background was just highlighted a bit more or different bg color? I'm not sure if completely opposite will be a bit too jarring.

@kamiyo how about this highlight color?
I tried the inner shadow, and it didn't look too good. I'm inclined to just merge this in master and let you play with it. Or you can pull it down and play with it and just push changes to it until you're satisfied. Let me know.

I'll pull it and try out diff backgrounds. thanks!


ERROR

Please provide steps to reproduce.

asets  231430 *

I guess this is because of those two server-side achievements.

I'll take a look if I can filter such achievements when * is used as parameter.

Actually, I checked the code, and I already have such filter in place. Tried !aset 231430 * on one of my bots, and it worked correctly (all achievements, apart from the above two, were set). So I still can not reproduce it. Are you sure bots where you tried it actually own this game?

All achievements, apart from these two, are also set for my bot, but should it show this error in console?
It shows nothing in case of success for example.
And I have another game, which has only erver-side achievements, when I run aset <bots> 99910 * command, the status is failed of course, but console doesn't show error message.

All achievements, apart from these two, are also set for my bot, but should it show this error in console?

No it should not, and it does not show any error for me. That's why I said that I can't reproduce this issue for now. Maybe my first guess about server-side achievements as a root cause was wrong. Do you have any other ideas how to reproduce it?

Try to set all achievements for a random appid, like
aset <bots> 1165161 *
Response should look like this:

Well, there is no appid 1165161, so this is expected behavior.

So, it seems, my second guess was correct - your bot just don't have required game. Everything works as intended.

Well, there is no appid 1165161, so this is expected behavior.

It was supposed to produce an error message in console, of course command response is expected.

So, it seems, my second guess was correct - your bot just don't have required game. Everything works as intended.

Wrong.

It was supposed to produce an error message in console, of course command response is expected. Try different random appids until you see error message in console.

Of course it produces error in console. Once again, this is intended behavior.  Plugin tried to set achievements of a game that does not exist - it results in error. All works as it should.

Wrong.

That's cool, but it still have no idea how to reproduce it. Is there something special about this bot? Any kind of bans or other special conditions?

That's cool, but it still have no idea how to reproduce it. Is there something special about this bot? Any kind of bans or other special conditions?

I don't what to consider as special.
Here are log, asf and bot configs.
log.txt
{
  "Blacklist": [
    362890
  ],
  "ConfirmationsLimiterDelay": 15,
  "CurrentCulture": "en-US",
  "FarmingDelay": 10,
  "GiftsLimiterDelay": 3,
  "Headless": true,
  "IdleFarmingPeriod": 4,
  "InventoryLimiterDelay": 15,
  "LoginLimiterDelay": 15,
  "Statistics": false,
  "SteamOwnerID":<PHONE_NUMBER>0895331,
  "UpdateChannel": 2,
  "UpdatePeriod": 0
}

{
  "AcceptGifts": true,
  "AutoSteamSaleEvent": true,
  "BotBehaviour": 32,
  "Enabled": true,
  "FarmingOrders": [
    3
  ],
  "GamesPlayedWhileIdle": [
    515040
  ],
  "HoursUntilCardDrops": 4,
  "LootableTypes": [],
  "MatchableTypes": [],
  "Paused": true,
  "RedeemingPreferences": 5,
  "SteamLogin": "***",
  "SteamPassword": "***",
  "TradingPreferences": 1,
  "TransferableTypes": []
}

Any kind of bans or other special conditions?

No bans, the profile is fully public: https://steamcommunity.com/id/Botan626/

Of course it produces error in console. Once again, this is intended behavior.

If bot doesn't own appid, this error in console is expected behaviour?

If bot doesn't own appid, this error in console is expected behaviour?

Yes. Theoretically I can check if bot has required game before sending request to get achievements, but I consider it excessive: it will increase network load, and since steam is shit and don't have a reliable way to check if game is owned - it may also lead to false negatives, which is not desirable. Maybe I should change it from error to warning though, it will be more consistent with mainline ASF.

Another case, with same error in console.

got the same error, is there any limit how many achievement to fetch in one time?


ForkJoinPool

Hi,
I tried to speedup the processing of GIF via multithreading on Android and my tests showed some improvements with ForkJoinPool. Also I did some refactoring in AnimatedGif.java but without including last commits from tommyettinger.

This is interesting and could prove useful in the future. For now, though, there's a number of issues here.

The big one is that it isn't necessarily any faster, and at least for making a 90-frame gif from a video, using threads makes the processing slower. GifStartupBench takes about 40% more time with this PR in, admittedly, a very rough benchmark.
The code here is several months older than current, and I would need to go through and add things like Woven dither, from November, back to the codebase.
The PR increases various requirements in a way that would be hard to swallow for many libGDX-using developers.

Java 11 isn't reliably available except on PCs and relatively new Android devices.
We lose all GWT compatibility as soon as threads are involved, and AnimatedGif was the only file format that could be produced with GWT (on HTML5) before.

There are other things that could be done that might benefit performance more reliably. We currently call Pixmap.getPixel() quite a lot for all dither algorithms, which on desktop involves a JNI call, That could potentially be sped up by using the raw, lower-level bytes of image data obtained by using Pixmap.getPixels(). I'm going to make a separate project to be able to profile this more accurately, and hopefully find which individual methods take the most time.
I'm not going to close this because I need to get my performance data more certain and clear, and I have an idea for how to do that next. I'm not merging either, because of the other issues listed above. It looks like you put a lot of work into this PR, and thank you for that; it just seems like adding in threading is too unpredictable for performance across many types of devices.

Thank you for your feedback on the pull request. I appreciate your thorough analysis of the potential impact and other considerations. I have conducted tests by implementing the code into my Android app which can be found here: https://play.google.com/store/apps/details?id=com.spineviewer and compared the outcome. I will work on gathering more precise data and addressing the other issues you mentioned. Thank you for taking the time to review my work and for not closing the pull request :)

OK, I looked into the performance of my desktop-only FastGif class, and it isn't different enough from AnimatedGif to warrant its existence right now, especially considering it loses some features. Since I'd like to either remove FastGif's platform-specific code or have it actually make good use of platform-specific code, this provides an opportunity to replace at least FastGif with the threaded code here to provide an option for users on desktop platforms. If you don't mind, I'll try to edit your PR before I try to merge it, to get the AnimatedGif changes moved over to FastGif and the more recent DitherAlgorithms implemented for threaded GIFs.

OK, I looked into the performance of my desktop-only FastGif class, and it isn't different enough from AnimatedGif to warrant its existence right now, especially considering it loses some features. Since I'd like to either remove FastGif's platform-specific code or have it actually make good use of platform-specific code, this provides an opportunity to replace at least FastGif with the threaded code here to provide an option for users on desktop platforms. If you don't mind, I'll try to edit your PR before I try to merge it, to get the AnimatedGif changes moved over to FastGif and the more recent DitherAlgorithms implemented for threaded GIFs.
I tested AnimatedGif with ForkJoinPool with Android only. The performance for mobile devices comparing to Desktop could be different.

I decided to delay any attempts to merge this until after the 0.4.1 release, which should be within the hour. This seems like a fairly major feature and also a fairly major change to FastGif, even if the API stays the same, so it should probably get tested/benchmarked a lot and included in a higher-significance release like 0.5.0 . That is, assuming it can be included at all without removing existing supported platforms like RoboVM. And I can't test RoboVM at all without a relatively recent Mac, so I have to only use APIs I know exist... And all or almost all of those are from Java 7 or earlier.


Fixed typo for filterWorkTime and sensorDirtyTime

Before
{ state: 'cleaning',
batteryLevel: 78,
cleanTime: 925,
cleanArea: 17.05,
fanSpeed: 38,
in_cleaning: 0,
mainBrushWorkTime: 363402,
sideBrushWorkTime: 363402 },
Now:
{ state: 'cleaning',
batteryLevel: 78,
cleanTime: 925,
cleanArea: 17.05,
fanSpeed: 38,
in_cleaning: 0,
mainBrushWorkTime: 363402,
sideBrushWorkTime: 363402,
filterWorkTime: 363402,
sensorDirtyTime: 248889 },

Thanks for the PR!


Complains shouldn't be accepted/rejected instant

Describe the bug

In my opinion the reject button and the bigger message window should have more space in between. so the problem is that you can trigger the reject button very easy when you want to extend the window.
An other even better way would be to add an extra warning before accepting or rejecting a complain, like it is when you cancel the assessment of an exercise
I mean its an easy fix probably. There should be just an extra check
To Reproduce

Start a complain
click on reject

Environment
ALL (tested with Firefox newest Version)
PS: please contact me if you need additional information

@Kroko-fant please check if #2877 resolved your issue. (Will be released this Thursday)

works fine as a quick fix :)


implement :set! termcap to make key codes more readable

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
The "Terminal keys" section in the output of :set termcap is difficult to read, because a line might contain several key codes.
For example:
t_#2 <S-Home>    ^[[1;2H   t_KG <k4>        ^[O*t     t_kb <BS>        ^?

Describe the solution you'd like
Make :set! termcap print every key code on a separate, so that the previous line is printed like this:
t_#2 <S-Home>    ^[[1;2H
t_KG <k4>        ^[O*t
t_kb <BS>        ^?

Describe alternatives you've considered
Format the output manually or use a plugin to do it automatically.
Formatting the whole section manually is too cumbersome.
Enabling a plugin defers what should be builtin to a third-party dependency.  Besides, it is still too cumbersome when we're debugging an issue, which is the most probable reason for which we're reading :set termcap.
I think the relevant function is show_termcodes().
Additional context
Even if this feature request is closed, we might still want to document the fact that :set! termcap is valid and has an effect: it correctly formats the first section "Terminal codes" so that each terminal option is printed on a separate line.  That's probably because :set all and :set termcap share some code (i.e. showoptions()).
As a suggestion, here is a patch:
diff --git a/runtime/doc/options.txt b/runtime/doc/options.txt
index b0000adf9..7a40ea8bc 100644
--- a/runtime/doc/options.txt
+++ b/runtime/doc/options.txt
@@ -30,10 +30,12 @@ achieve special effects.  These options come in three forms:
 			When [!] is present every option is on a separate
 			line.

-:se[t] termcap		Show all terminal options.  Note that in the GUI the
+:se[t][!] termcap	Show all terminal options.  Note that in the GUI the
 			key codes are not shown, because they are generated
 			internally and can't be changed.  Changing the terminal
 			codes in the GUI is not useful either...
+			When [!] is present every terminal option is on a
+			separate line (but not the key codes).

 								*E518* *E519*
 :se[t] {option}?	Show value of {option}.

Make :set! termcap print every key code on a separate, so that the previous line is printed like this:

Just to be clear: I'm not asking for :set termcap to change its formatting.  I'm asking for :set! termcap (notice the bang after :set) to format the second section "Terminal keys" just like it already formats the first one "Terminal codes", so that the global output is more consistent and readable.


dfx generate bug

I tried the following:

include the ledger in a project with the following dfx.json

    "canisters": {
        "ledger": {
            "type": "custom",
            "wasm": "ledger.wasm",
            "candid": "ledger.private.did",
            "remote": {
                "candid": "ledger.public.did",
                "id": {
                    "ic": "ryjl3-tyaaa-aaaaa-aaaba-cai"
                }
            }
        },
        "trax_payments_backend": {
            "main": "src/trax_payments_backend/main.mo",
            "type": "motoko",
            "dependencies": ["ledger"]
        }
    },
    "defaults": {
        "build": {
            "args": "",
            "packtool": ""
        }
    },
    "version": 1
}

deploy the ledger, swap ledger.private.did to ledger.public.did in the dfx.json
include the ledger in another canister A using import Ledger "canister:ledger
deploy that canister A as well
run dfx generate A

I expected to see this happen: dfx generates the bindings for canister A
Instead, this happened:
dfx fails with the following output
❯ dfx generate trax_payments_backend
Building canisters before generate for Motoko
Error: Failed while trying to build all canisters.
Caused by: Failed while trying to build all canisters.
  The build step failed for canister 'r7inp-6aaaa-aaaaa-aaabq-cai' (trax_payments_backend) with an embedded error: Failed to build Motoko canister 'trax_payments_backend'.: Failed to compile Motoko.: Failed to run 'moc'.: The command '"/Users/moritz/.cache/dfinity/versions/0.12.1/moc" "/Users/moritz/projects/trax_payments/src/trax_payments_backend/main.mo" "-o" "/Users/moritz/projects/trax_payments/.dfx/local/canisters/trax_payments_backend/trax_payments_backend.wasm" "-c" "--debug" "--idl" "--stable-types" "--public-metadata" "candid:service" "--actor-idl" "/Users/moritz/projects/trax_payments/.dfx/local/canisters/idl/" "--actor-alias" "ledger" "rrkah-fqaaa-aaaaa-aaaaq-cai" "--actor-alias" "trax_payments_backend" "r7inp-6aaaa-aaaaa-aaabq-cai" "--package" "base" "/Users/moritz/.cache/dfinity/versions/0.12.1/base"' failed with exit status 'exit status: 1'.
Stdout:

Stderr:
/Users/moritz/projects/trax_payments/src/trax_payments_backend/main.mo:11.1-11.36: import error [M0009], file "/Users/moritz/projects/trax_payments/.dfx/local/canisters/idl/rrkah-fqaaa-aaaaa-aaaaq-cai.did" does not exist

This can be fixed by moving the ledgers did file to the path specified in the error message.
Meta
dfx --version:
12.0.1

Further log output

<log output>

@letmejustputthishere Talk to LEDGER Support on the Ledger Live support so that your issue can be looked into.

Tracked internally as SDK-1019


Unpause on join not working

After a while, the server is unable to unpause the game if running when a client joins.
In the console logs I see the following error message.
Command '@@@@UnpauseCommand_1679345456406@@@@' not found.

Hi @zazzn
please take a look here: https://github.com/andreashauschild/openttd-server/issues/6
if you have an open web terminal all automatic features are disabled.

Actually, there is for sure something wrong, my console isn't open, I've connected and it does not unpause automatically. Something is failing to check and unpause.

I've joined a company and sat there for 10 minutes and it did not unpause.

If you like to connect to the sever i can share the info along with rcon if that helps.

I have two more questions:

How long is the server uptime (time since last restart)?
Did you join the game and selected your company? The game only unpause if a player has joined a company.

At least 1 week, not sure exactly, I did join a company and sit there waiting

Mhhh i think i will add thie possibility for a daily server restart at defined time. It may fix this issue.


Addition of home icon to games

PR Description 📜
Fixes #1620
###Changes:
-As when we click on a game to go back to the homepage ,I have added the home icon .
-By hovering over the home icon we land back to homepage.
-Some games couldn't be loaded in my server so I was not able to make the change.

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[ ] I have added entries for my game in main README.md
[ ] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[ ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸
Without addition of home icon on games

After resolving the issue

@kunjgit Please review my PR.

Thank you soo much for contributing to our repository 💗

Thank you @KanchandeepK ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

How can I check this my system lagging so much 😔@KanchandeepK

@gurjeetsinghvirdee I will try to figure it out .It was working fine in mine.

@gurjeetsinghvirdee I will try to figure it out .It was working fine in mine.

Not working on my system i3 11th gen 😕

Thank you  @KanchandeepK , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Added untriaged issue workflow.

Coming from https://github.com/opensearch-project/.github/issues/133, create a GitHub workflow for labelling untriaged issues. Please ensure that an untriaged label with color  exists before merging.

Codecov Report

Merging #450 (a9eb34f) into main (514f796) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##               main     #450   +/-   ##
=========================================
  Coverage     62.32%   62.32%
  Complexity      159      159
=========================================
  Files            30       30
  Lines           730      730
  Branches         20       20
=========================================
  Hits            455      455
  Misses          266      266
  Partials          9        9

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

FIxed the spotless errors. Not sure what it was but probably windows CRLF.
I'd prefer to remove "opened" from this PR to allow untriaged on reopened/transferred, but I think the bug/feature workflows are sufficient for us, so I'm not going to approve it myself. However, if two other maintainers want to approve this as is, I won't yell.

Sorry about the CR/LFs, I copied another workflow.

Insert smack talk about Windows vs. *nix here.


LoginService should use LoginDTO #175

Use LoginDTO instead of strings in the service class and Junit test cases
Close #175

Hi @iravimandalia ! Thanks for all your recent contributions 👍 The PR looks good, it will be merged soon 🎉


APIError: beginTransaction called while no connection to the database exists

Hi, I'm not sure what I'm missing but I can't seem to get the template to work. When running yarn dev and trying to access localhost:3000 I get met with the error:
APIError: beginTransaction called while no connection to the database exists
    at Object.beginTransaction (/home/kwabe007/test/repay/node_modules/@payloadcms/db-mongodb/src/transactions/beginTransaction.ts:14:11)
    at initTransaction (/home/kwabe007/test/repay/node_modules/payload/src/utilities/initTransaction.ts:20:43)
    at find (/home/kwabe007/test/repay/node_modules/payload/src/collections/operations/find.ts:41:47)
    at find (/home/kwabe007/test/repay/node_modules/payload/src/collections/operations/local/find.ts:63:14)
    at BasePayload.find (/home/kwabe007/test/repay/node_modules/payload/src/payload.ts:118:12)
    at loader (/home/kwabe007/test/repay/app/routes/_index.tsx:6:31)
    at Object.callRouteLoaderRR (/home/kwabe007/test/repay/node_modules/@remix-run/server-runtime/dist/data.js:52:22)
    at handler (/home/kwabe007/test/repay/node_modules/@remix-run/server-runtime/dist/routes.js:54:20)
    at runHandler (/home/kwabe007/test/repay/node_modules/@remix-run/router/router.ts:3960:7)
    at callLoaderOrAction (/home/kwabe007/test/repay/node_modules/@remix-run/router/router.ts:4020:22) {
  data: null,
  isOperational: true,
  isPublic: false,
  status: 500
}

These are the steps I took:

Clone repo
Install dependencies with yarn;
Setup a local mongo instance via docker (without authentication).
Copy .env.example to .env with MONGODB_URL=mongodb://localhost:27017/app and PAYLOAD_SECRET=secret.
Run yarn dev.

I also double checked that I could reach the mongo server with mongosh mongodb://localhost:27017/app. I can access it without problems. No idea what I'm doing wrong.
Running
Ubuntu 22.04.4 LTS
node 20.11.1
yarn 1.22.21

Figured it out. Somehow I used MONGODB_URL as the environment variable name instead of MONGODB_URI which is the correct one.


GRPC API post proof info improvement

GRPC API should have more available information about Post Proof. One of API current or new could response with information about proof after initialization. Time of data reading and nonce of proof which gave nonce and number of prooving tries. There should be also an information about current situation. So when node was trying to make proof, same information, time, nonce, if it was successful and overall information at the end if node is currently taking participation in smeshing.
Something like:
{"post_proof":
{status: "ready"|"not_started"|"in_progress",
"calculating_time": "minutes_value",
"nonce_found": "nonce_value",
"next_poet_round": "unix_start_of_poet"}}

I would love to see this option, many rin spacemesh go in screen without logs and a lot is unknown

This is bothering me too. The node reports the status of the PoST initialization process, but once this is complete there is no info whatsoever on proof generation. There's not even any log message, so you really have no idea what's going on or how much progress has been made.

This should be tackled as part of https://github.com/spacemeshos/pm/issues/259

I consider that this is solved for now.


[ZEPPELIN-2482] added font size for paragraph

What is this PR for?

Added possibilty to change font size of paragraph text
Fixed cloneParagraphAction (immediately after the cloning is incorrectly displayed a new paragraph)
Fixed paragraph settings into Firefox

What type of PR is it?
Feature
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2482
How should this be tested?

Open note
Add some text to paragraph
Open settings of paragraph and chenge "Font size"

Screenshots (if appropriate)

Font size and clone

BEFORE

AFTER

Fix for Firefox
BEFORE

AFTER

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

CI red -> AuthenticationIT.testGroupPermission

Thanks @tinkoff-dwh and nice feature!
Let me test and come back here.

In Font size and clone and firefox browser case, I tested and it's work well. LGTM.

Ready to review

Ready to review

Ready to review

LGTM. @1ambda Can you verify it?

@tinkoff-dwh @jongyoul sorry for the late reply.
I will test and comment in few hours.

This feature will be helpful when displaying in the report mode but want to increase font-size.

need to be rebased. base branch is outdated.
+1 reindent DOMs and having a test

LGTM. Thanks for the contribution @tinkoff-dwh.

@1ambda Thanks. @tinkoff-dwh Please catch up the comment.

@1ambda
save changes by change font size works fine

@tinkoff-dwh saving works. but it's not automatically propagated to other web-browsers.

@1ambda
can you provide a link to the code where it is implemented to colWidth?

I attached a GIF.

@tinkoff-dwh Do you still need a link? or just wanted to check the behavior?

@1ambda
no, thx. it's clear

@1ambda
done

ci red because fall other tests (not mine)

Looks good. I guess the failed job in https://travis-ci.org/tinkoff-dwh/zeppelin/builds/242104908 is due to a flaky test. But just to make sure, could you restart it so that CI will be green?

the same errors
ParagraphActionsIT.testSingleDynamicFormSelectForm:624 » NoSuchElement Cannot ...
ParagraphActionsIT.testMultipleDynamicFormsSameType:707 » NoSuchElement Cannot...
ParagraphActionsIT.testRunOnSelectionChange:282 » NoSuchElement Cannot locate ...

sorry it is my fault. i added new dropdown menu (font size) so order of elements (select) is changed

LGTM

thx for review.
@jongyoul
can you init merge?

I'll merge it if there's no more discussion.

@jongyoul
?

Missed. I'll merge it now.


[Hub Generated] Publish private branch 'release-azurestackhci-Microsoft.AzureStackHCI-2021-09-01-preview'

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/9073

@xiaoxuqi-ms would you mind merging this given the approval in the approval here?
https://github.com/Azure/azure-rest-api-specs-pr/pull/9073

please fix the linter errors, model validation errors and prettier check. Other update LGTM.

please fix the linter errors, model validation errors and prettier check. Other update LGTM.

Hi @xiaoxuqi-ms thanks for reviewing. The lintdiff, modelvalidation and prettier check failures we will be taking in our next version as mentioned in the private PR this PR was based off of: https://github.com/Azure/azure-rest-api-specs-pr/pull/9073#issuecomment-1276784267
Let me know if you have additional questions, happy to answer them.

@pathuang-sia , while we are reviewing this pr, new update are merged into 2021-07-01-preview, in pr: https://github.com/Azure/azure-rest-api-specs/pull/18152. so there are breaking changes. Please help to confirm if the breaking changes are introduced intentionally or should these changes be synced to 2021-09-01-preview to avoid these breaking changes.

/azp run

I think the first letter of the property name can be lower-case: for example, galleryimagesProperties is fine. But not GalleryimagesProperties


Show All Files - working only for StartUp Project

If have 3 node js projects in my solution, one set as StartUp Project with "Show All Files" button toggled on in Solution Explorer.
In this situation I can see all folders/files, including the greyed out ones.
If I toggle it off, then only greyed out folders/files from a StartUp Project are disappearing, and in other two I still see them.
The same if I click it again to show all files.
Button is only affecting StartUp Project.

'Show all files' is a project-specific property (in fact you'll see it if you open your project file in the editor). So you should be able to click on any of the other projects, and select show all files to set them each individually.


Internal server error: Cannot use 'import.meta' outside a module

When upgrading from 1.2.7 to 1.3.x, I got the following error:
[vite] Internal server error: Cannot use 'import.meta' outside a module (1:0)
Further inspection, the error comes from using the lib acorn, saying that "import.meta" can't be used on scripts.
I am using a vite project with hmr. When running vite dev, vite will inject import.meta.hot in the compiled bundle.  es-module-lexer will read the bundle and extract all imports, including import.meta.*. When you call acorn parse, you don't specify the sourceType, and the default value to that is 'script'. When it catches 'import.meta', it will throw this error.
Reverting to 1.2.7 solves this problem.
Possible solution would be to pass sourceType value as option of acorn.

sure right

I still hope you provide a minimal reproduction repo :)

Hi, I see it's solved, but if you ever wanted to see the problem, here is the reproduction repo:
https://codesandbox.io/s/vite-react-forked-xw8suh
Thanks


Custom template controller issues.

I've been running into issues with custom templates. Whether I am relying on naming the controller the same or setting the template property, the controller fails to send data to the view.
However, the standard page controller does send it's data.
Thanks for any help you can provide!
templates/faq.blade.php
{{--
  Template Name: Frequently Asked Questions
--}}

@extends('layouts.base')

@section('content')
  @while(have_posts()) @php(the_post())
  @include('partials.page-header')
  @include('partials.content-page')
  @endwhile
  {{ $faq or 'No $faq variable returned' }}<br/>
  {{ $page or 'No $page variable returned' }}
@endsection

controllers/faq.php
<?php
namespace App;
use Sober\Controller\Controller;

class Faq extends Controller
{
    /**
     * Protected methods will not be passed to the template
     */
    protected function hidden()
    {

    }
    public function faq()
    {
        return 'Testing FAQ Controller';
    }
}

controllers/page.php
<?php
namespace App;
use Sober\Controller\Controller;

class Page extends Controller
{
    /**
     * Protected methods will not be passed to the template
     */
    protected function hidden()
    {

    }
    public function page()
    {
        return 'Testing Page Controller';
    }
}

Outputs
No $faq variable returned
Testing Page Controller

@christianmagill thanks for flagging this.
The controllers essentially work using the body class, so as a workaround you could add this to the controller;
<?php

namespace App;

use Sober\Controller\Controller;

class Faq extends Controller
{
    public $template = 'page-template-faq-blade';

    public function faq()
    {
        return 'Testing FAQ Controller';
    }
}

I'd like to improve this solution in the next release which I'll be working on this weekend, so I'm going to keep the issue open for now.

I've just released 1.0.0-alpha6 which should address this.  Your original setup should now work.
I've also added in a singular.php controller option as I use that often, or you could use base.php within controllers/ for global options.
https://github.com/soberwp/controller/commit/d200c7e448777ee0b21a20c6f180f8e8147d3cf2#diff-3864ffe37f3a1de39876ea62cae525f3

Thanks for the information and fix!
If the controllers work on the body classes, why not just make this more transparent in the documentation and property name. It's similar to the way Sage handles their javascript routing.
In reality the way you describe the template/controller connection is not exactly right. For instance, a custom page template, with it's own controller, will still incorporate the standard page controller.
This could be useful in many contexts but confusing if it is not expected. I am not sure what happens when two applied controllers have the identically named methods.

@christianmagill sure, it's still in alpha so there's a bit to work through to be honest. I'm working on some changes this weekend and will be testing multiple scenarios and the best way to deal with them. I will update the docs once it's in beta (hopefully soon).

Thanks! I appreciate your work on this. I think it's going to be great. Let me know if there's anything I can do to help.

I will keep this issue open for now, appreciate your feedback so far, will let you know when the next alpha is released.

@christianmagill I rewrote large amounts of the plugin today.
I realised that going having template overrides is a bad idea as it quickly becomes a tangled mess.
I've implemented a more sane structure, while still allowing components through traits.
Here's an implementation example;
<?php

namespace App;

use Sober\Controller\Controller;

class Single extends Controller
{
    use Images;

    public function books()
    {
        return array();
    }
}

How is the determination made as to which templates load which controllers? Is it just anything that is a body class? Thanks for your work on this. I'm out tonight but will test out tommorow.

Okay, I noticed updated documentation in read me and that helped clear up some things.
The only thing I'm not completely clear on is "Inheriting the Tree/Heirarchy". Where do these co trollers come from and do they stack on top of each other according to the template hierarchy. You mention singular, but there is no "singular" in the template hierarchy. Is thay in reference to the associated body class. Thanks. I really like how things are setup!

@christianmagill it works on the filename.  If there is a faq.blade.php within templates, then faq.php would work.
I will be testing the Tree more today and will provide more examples.  Essentially it's going to aim at following this, https://developer.wordpress.org/files/2014/10/template-hierarchy.png
So if you had templates/single.php and templates/page.php, you could use controllers/singular.php to send to both (the same as WordPress' standard hierarchy).

@christianmagill the standard WordPress hierarchy has been implemented in 1.0.0-beta1.  If you inspect the body class on a page, you will notice *-data classes;

All classes with *-data can become controller files (omitting -data from the filename), with the latest one always overriding the previous should you not add "implements Tree" to the Class declaration.
I'll update the docs later to better explain.

Great. I was unfamiliar with the addition of singular.php to the template hierarchy which caused some confusion. The way you have things setup seems very powerful and well organized. Can't wait to try it out.

Hey there !
Just found this issue related to mine.
I'm using latest Beta, and i'm wandering if there's a way to use a Class attribute
like
public $template = 'page-template-faq-blade';
To override the controller search based on controller filename ?
It would be just to :

Have clear controllers filename
Be able to specify in the controller the "slug" that this controller will match, in addition to its filename.

Thanks !


Update inputs to "sp-inputs"

Update inputs to "sp-inputs". Text area and others.

Will be in next version


USHIFT-1340: Add configurable ssh port to RF

Which issue(s) this PR addresses:

Closes #

/lgtm


BREAKING CHANGE: assigning multiple FAPs per proposal

Description
The PR introduces the functionality to allow multiple Facility Access Panels (FAPs) to be associated with a single proposal.
Motivation and Context
The need for this change arose due to the real-world scenario where a proposal may need to go trough reviews from multiple Facility access panels. This PR allows the backend to handle such scenarios, enhancing the application's flexibility and usability.
Changes

The main change is in the ProposalDataSource.ts file where the new column fap_proposals_id has been added and the primary key constraint has been redefined.
The PostgreSQL version for all docker-compose files has been upgraded to version 16.
The view proposal_table_view has been modified to accommodate the multiple FAPs per proposal change.
The technical_review table now includes a new column technical_review_assignee_id.
The proposal_events table has been updated to include a new column proposal_faps_removed and the column proposal_fap_selected has been renamed to proposal_faps_selected.

How Has This Been Tested?

Fixes Jira Issue
https://jira.esss.lu.se/browse/SWAP-3734
Depends On

Tests included/Docs Updated?

[x] I have added tests to cover my changes.
[ ] All relevant doc has been updated

One bug I've found so far. When you remove an instrument from a proposal that was attached to a FAP.  The Fap still remains  assigned status to the proposal/instrument.

One bug I've found so far. When you remove an instrument from a proposal that was attached to a FAP. The Fap still remains assigned status to the proposal/instrument as well as the record in the fap_proposals table.

@Junjiequan this should be fixed now and e2e test is added to cover the bug. You are free to review it again.

@ACLay thanks for the great feedback. I have fixed and addressed most of your comments and you are ready to give it another try.

@TCMeldrum or @Scott-James-Hurley if you have some time one of you can pull this code and test it locally using STFC configuration.

Hi @ACLay can you please check this one again and if you think it looks good I can merge it today.


qsutil cp support wildcard *, like bash cp

hope qsutil cp support wildcard *, like bash cp
such as:
qsutil cp *.jpg qs://${mybucket}/images/

Good idea, we will add this feature as soon as possible.


Surveys: allow for custom confirmation messages

Possibly also allow for a footer which states something similar (but isn't hidden behind a click)


CollapsableNavBar - widget doesn't work in Storybook

When you open CollapsableNavBar in Docs section of Storybook it doesn't work as expected

Please fix the UI issues that occur:


Bug report & Question about functions which cannot be lifted into LLVM IR

Dear, RetDec developers.
I really appreciate that you make this tool.
But, I found some problems. I am not sure whether this is ARM's THUMB architecture specific.
Based on my guess, the problem is that some functions are not lifted into LLVM.
This function is "not explicitly" called by other function because it is run by "pthread_create".
However, this is not a standard pthread create. That means that my target binary running on the embedded device w/ RTOS (RIOT) - not Linux.
Therefore, pthead_create is included in the binary codes as a normal function.
Specifically, the problem is that.

This function is not called by the other functions. That's why I think RetDec didn't lift it.

Also, when this function's pointer value is passed into an argument to "pthread_create". This function pointer value should be "actual function pointer value + 1".
When a function is executed with ARM's Thumb mode, its pointer value must be +1; otherwise, that function will be executed in the ARM's "ARM mode".  (I strongly believe you know ARM architecture supports both ARM and Thumb modes which is the unique ARM scheme. But, I put this description just in case.)

As I mentioned, my target firmware is not an application binary for Linux. It is a bare-metal firmware including RTOS (+ pthread related functions).
That's why pthread functions are considered as a just normal function.
Then, RetDec may not take special processing to pthread functions I guess

In this context, could you help me to solve this problem?
Even if that is not possible (at least very soon), is there a way to "forcibly" convert such "unlifted" functions?
I think the fundamental reason why that function is not lifted is related to optimization.
For example, I guess that function is considered as garbage since it is not called by any other functions during some analysis (e.g., a sort of points-to analysis I guess...?)
If that is possible, I am fine with it at this time since I need to emergently solve this problem.
Or at this time, I can assume my firmware has a symbol against the target unlifted function temporarily.
Thank you for your help :)
PS. the converted "pthread_create" call looks like this
%v9_80015a4 = call i32 @pthread_create(i32* nonnull %th_id1_-44, i32 %v2_8001596, i8* (i8*)* inttoptr (i32 134222901 to i8* (i8*)), i8 null)
i8* (i8*)* inttoptr (i32 134222901 to i8* (i8*)*) -> this was originally a function pointer to thread handler function. But, since the last bit is set (13422290"1"), it was not recognized as a function pointer maybe....

Hi. Could you please try to run the decompilation with --keep-unreachable-funcs? It that does not help, would it be possible for you to share the binary file that you are trying to decompile with us?

@s3rvac I actually solved it by removing "-unreachable-funcs" option (in scripts/retdec-config.py).
However, "i8* (i8*)* inttoptr (i32 134222901 to i8* (i8*))" this pointer value is not recognized as a function pointer.
As a future work, I personally think it should be recognized as a function pointer in the future?


refactor: Standardize guest Input format

Address https://github.com/taikoxyz/raiko/issues/38

https://github.com/CeciliaZ030/zeth/pull/9/commits/ad754cd270a65e10601551b05dab5e725d43e06c starts work on https://github.com/taikoxyz/raiko/issues/39

@CeciliaZ030 There is now a initial version of how the driver could work, but the compilation and linking of the powdr guest is not complete. My thinking is that we could compile the artifact (no_std powdr lib code) outside of the runtime call to reduce computation and simply have the runtime read the assembly file from a predetermined location. Than the runtime only needs to pass the inputs (serialized by the driver) and run the pipeline.

Resolved https://github.com/taikoxyz/raiko/pull/68


Allow shift anti drag to better interface with shift dropping

Currently shift anti-drag is quite a nice feature but the issue is that it maps to the same key binding as shift dropping. This means utilizing anti-drag, requires you to disable shift dropping which albeit works but can be really annoying, especially when you forget to re-enable shift dropping and you accidentally left-click something, like a brew, when you though you were dropping it.
Potential Solutions

Add ignorable items for shift dropping. Similar to a feature that exists in OSBuddy, you can configure items that will be ignored by shift dropping (by setting the click option of the item when shift is held, drop->use).
Allow remapping of anti-dragging. Potentially either a select from a choice of preset keys or user's personal choice of keys as opposed to Shift, which could remain as the default. Potential key choices could be things like Ctrl, Alt, or Function Keys.

This is by design

Why is it by design though? To comply with Jagex requirements or code base support?


Make orderBy processing in WindowAgg a bit less imperative

Checklist

[x] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed

@andreidan this is what I had in mind in a prior PR. Let me know what you think


Use shorter sorting syntax and update javadoc

Coverage remained the same at 88.152% when pulling 7e84ccf4dfdaf53c2d586e70c292a0055f22894d on cascer1-patch-1 into 88a24d7bdda8ea8a296027ed8dca2ff4c9bde60d on master.


Lsif-tsc 0.4.9 fails on reactivex/rxjs

Running lsif-tsc over the rxjs repository causes the following error, in which a document has already been finalized but is seen again. I have not investigated this deeply yet, but it seems as if the set of files it iterates over contains duplicates (I see some effort to de-duplicate this, but for transitive files there is no such effort).
Steps to Reproduce:

Clone reactivex/rxjs
Run npm i
Run lsif-tsc

Output:
$ lsif-tsc -p tsconfig.json --out temp.lsif --noContents
...................................................................................................................................................................................................................................................................................................................................................................................................Error: There was already a managed document data for file: /Users/efritz/dev/sourcegraph/rxjs/src/internal/util/root.ts
    at DataManager.getDocumentData (/usr/local/lib/node_modules/lsif-tsc/lib/lsif.js:1119:19)
    at Visitor.getOrCreateDocumentData (/usr/local/lib/node_modules/lsif-tsc/lib/lsif.js:1597:39)
    at Visitor.getOrCreateSymbolData (/usr/local/lib/node_modules/lsif-tsc/lib/lsif.js:1643:37)
    at AliasResolver.resolve (/usr/local/lib/node_modules/lsif-tsc/lib/lsif.js:927:58)
    at /usr/local/lib/node_modules/lsif-tsc/lib/lsif.js:1657:148
    at DataManager.getOrCreateSymbolData (/usr/local/lib/node_modules/lsif-tsc/lib/lsif.js:1152:22)
    at Visitor.getOrCreateSymbolData (/usr/local/lib/node_modules/lsif-tsc/lib/lsif.js:1656:35)
    at Visitor.handleSymbol (/usr/local/lib/node_modules/lsif-tsc/lib/lsif.js:1536:31)
    at Visitor.visitIdentifier (/usr/local/lib/node_modules/lsif-tsc/lib/lsif.js:1527:14)
    at Visitor.visit (/usr/local/lib/node_modules/lsif-tsc/lib/lsif.js:1321:22)

@efritz thanks for the report. Was able to reproduce can will have a look.

Published 0.4.10.
@efritz out of curiosity: what is the use case of running the lsif tool over the rxjs code?

Just looking for popular typescript projects to test the exporter on. Is it an odd use-case to run the tool over rxjs?

No, not at all. What other projects did you test so far

We also ran it on vscode and some internal libraries/projects.


Update suggester pacakge name

The package name is now suggester.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c973e55) 59.26% compared to head (a4006e5) 58.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   59.26%   58.97%   -0.29%
==========================================
  Files         135      135
  Lines       10757    10757
==========================================
- Hits         6375     6344      -31
- Misses       4002     4030      +28
- Partials      380      383       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I'm curious to why this was renamed since the public method is GetSuggestor which'd lead to suggestor, err := suggestor.GetSuggestor which'd shadow the package name...
So to me it feels like suggest would be a better name (this is actually what's happening in the tests, but it's not obvious because they're within the same package so you don't actually need to import the package currently)


Question.

What is task completion in the HW (Interaction with other groups)?

This is the guidelines.

ok

OK, Thanx

Isn't different?
There is a completion task, in the interaction with other groups. What is that?

Or. That is not interaction with other groups? That is just completing your own task, I guess? Then its fine.


Stacking Regressor

Hi, could you kindly add support for converting Stacking Regressors?

Yes unfortunately this meta-estimator isn't supported. By design, pure predict only supports a subset of sklearn estimators and meta-estimators. Please feel free to contribute, I'd happily comment on and approve a PR that implements this solution.


[All Hosts] (manifest) update npx command

Fixes https://github.com/OfficeDev/office-js-docs-pr/issues/3025
Doesn't need a review.

Docs Build status updates of commit c50466b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/testing/troubleshoot-manifest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Typescript helper to extract data from responses etc.

@Berk0ld you can look here for real server inspiration.

Still WIP. Need to tune roll unfolding and grouping.

@AlexeyDemedetskiy I will definitely do!


Feature proposal/discussion -- create API command that "migrates" a hosts from a cluster to another

ISSUE TYPE

Feature Idea

COMPONENT NAME

API

CLOUDSTACK VERSION

4.17

CONFIGURATION

KVM
OS / ENVIRONMENT

N/A
SUMMARY

CloudStack does not allow to migrate hosts from clusters. This Issue raises the feature idea of migrating hosts between clusters.
In KVM at least this is quite easy to be done. Basically, it can be done by changing the agent.properties and updating a few tables in the DB.
At first, I would propose creating such an API command only for KVM. As far as I know, XenServer & VMware aren't as simple. Quite a long time since I played with Xen or VMware, so I am not raising them here. But anyone interested in discussing raising it. feel free.
The idea is that such a host should be placed into maintenance, making sure that no VMs will be running.
If the host is in Maintenance, then the API command would run the needed changes in order to have the host available at other cluster.
This would require Admins to ensure that the shared storage pool is available at the zone-wide level.

Thanks @GabrielBrascher for the proposal. IMO this would not feasible for Vmware or Xen, they would require to be externally handled by the administrator on the hypervisor side. For example on Vmware, putting the host on maintenance, unmounting the datastores on the host which belong to the 'old' cluster and mounting the datastores from the 'new' cluster, check portgroups, would need to be handled externally. However, I do think it is a good idea for KVM - should this API have any prerequisite besides the host being on maintenance?
Opinions? @rohityadavcloud @borisstoyanov @sureshanaparti @andrijapanicsb @DaanHoogland

While I appreciate that the feature might be interesting for KVM, I don't think it's worth the effort since other hypervisors can't be migrated and for KVM a simpe DB changes will do.

Would this basically be an automated shortcut for removing and adding the host, or is there a benefit of actually moving it, like retaining the host's ID or history?

Added bonus of that

Would this basically be an automated shortcut for removing and adding the host, or is there a benefit of actually moving it, like retaining the host's ID or history?

is that the comments/annotations on the host would be retained. I like the idea but fear this will be worked on more than it will be used. In a datacenter a cluster would typically be organised around which hosts sit together in the top, middle or bottom of which rack/pod. a re-clustering would mean physical moving usually and the removing/adding would make more sense. Of course you might have different experiences @GabrielBrascher @mlsorensen ... ?

@nvazquez @andrijapanicsb that's true, it would be focused specifically on KVM. Definitelly not a good idea for VMware and XenServer.
@mlsorensen indeed, it is a shortcut for removing and adding a host from CloudStack.
Also, I don't think it would cause downtime for VMs, as long as they are allocated either on local storage and/or zone-wide shared pools. Host IP addresses, connected pools, and guest networks could remain the same in such cases.
@DaanHoogland this rarely happens. But decided to open a discussion as I've seen it happen. It is quite fun to move hosts around CloudStack "logical" clusters.
To "move" a host between clusters it is needed just a few changes in DB and host's agent.properties. It is not hard to do it "manually" so I'm not sure if it justifies an API call. But I rather first hear what you guys have in mind and if this could maybe add some interesting dynamic for operating KVM-based clusters.
Keep in mind that a Pod is a "DC Rack" that contains one or multiple "clusters". In that sense, KVM hosts can easily be changed from clusters when residing in the same Pod as they are using the same switch (L2 network). Therefore, no networking nor pool changes are required in such cases, neither unplugging/plugging hosts in different racks.

@DaanHoogland this rarely happens. But decided to open a discussion as I've seen it happen. It is quite fun to move hosts around CloudStack "logical" clusters.
To "move" a host between clusters it is needed just a few changes in DB and host's agent.properties. It is not hard to do it "manually" so I'm not sure if it justifies an API call. But I rather first hear what you guys have in mind and if this could maybe add some interesting dynamic for operating KVM-based clusters.
Keep in mind that a Pod is a "DC Rack" that contains one or multiple "clusters". In that sense, KVM hosts can easily be changed from clusters when residing in the same Pod as they are using the same switch (L2 network). Therefore, no networking nor pool changes are required in such cases, neither unplugging/plugging hosts in different racks.

Yes, so that would limit changing clusters within a pod, would it? As said and though I like the idea from a logical point of view, I fear it will not be used as much as it would seem at first sight.
If however it is persistently done manually it does justify an API endpoint as manual DB manipulation should be avoided.

Agree, let's not proceed with creating a new API command then.
Eventually, if this becomes a common case, then it would make sense to consider an API endpoint.

Closed for now. Thanks for participating in this discussion :)
Please let me know if this issue makes sense or if any of you see interesting things that we could do in this context.


refactor(combineAll-spec): update combineAll operator tests to use pipeable operators

update combineAll spec to use updated import sites and pipeable operators

Coverage remained the same at 96.503% when pulling 3587d7f142a9c227c33003b12f0cbec760952e2a on natmegs:combineall-spec-pipeable into 7e4cef4087f1f75dc5476199d80accc335bb48a0 on ReactiveX:master.


SoShadowGroup : Wrong slack ?

In "SoShadowGroup.cpp", at line 1285, there is the code :
cam->nearDistance = -box.getMax()[2]*1.01f;
Isn't the right code :
cam->nearDistance = -box.getMax()[2]/1.01f;
?

Sorry, that was an error, code is OK


Small correction to README

In the quick demo using sessions, the readme referenced 'nvim' without the preceeding '.'.

In the quick demo using sessions, the readme referenced 'nvim' without the preceding '.'.


is it possible to set @turbo thread = true/false at runtime?

I have a function that uses @turbo and has a threaded kwarg
function f(a, b; threaded = true)
c = similar(a)
@turbo thread = true for i = eachindex(a)
     c[i] = a[i]+b[i]
end
end

is it possible to pass the function kwarg threaded to @turbo to set thread  ?

Currently no, but you could add support for this.

You could even take a naive approach, of doing the translation automatically from
@turbo thread=b for ...

to
if b && Threads.nthreads()>1
   @turbo thread=true for ...
else
   @turbo thread=false for ...
end

if you want to get more creative, you could try and integrate with the runtime threading profitability check LV already does based on the number of loop iterations and expected cost.

Thanks @chriselrod … I’ve coded up a solution for now but would like to see if I can create a PR later this summer


ASAN Support?

I've been exploring if its possible to set up ASAN/LSAN with custom extensions in pandas. With meson-python I was able to build the extensions with santizer support via pip install -ve . --no-build-isolation --config-settings=builddir="asan" --config-settings=setup-args="-Db_sanitize=address"
After build, a simple import yields the following:
$ python -c "import pandas"
==2611882==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.

If you try to expand on that and provide LD_PRELOAD you get a rather cryptic error message:
$ LSAN_OPTIONS=suppressions=asan-supp.txt LD_PRELOAD=/home/willayd/mambaforge/envs/pandas-dev/x86_64-conda-linux-gnu/lib/libasan.so python -c 'import pandas'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1140, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1080, in _find_spec
  File "/home/willayd/code/pydebug/lib/python3.11/site-packages/_pandas_editable_loader.py", line 268, in find_spec
    tree = self.rebuild()
           ^^^^^^^^^^^^^^
  File "/home/willayd/code/pydebug/lib/python3.11/site-packages/_pandas_editable_loader.py", line 309, in rebuild
    subprocess.run(self._build_cmd, cwd=self._build_path, env=env, stdout=stdout, check=True)
  File "/home/willayd/.pyenv/versions/3.11.3/lib/python3.11/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/ninja']' returned non-zero exit status 1.
-----------------------------------------------------
Suppressions used:
  count      bytes template
      6      13628 _PyObject_Malloc
-----------------------------------------------------

In this case the suppression file I used just contained leak:_PyObject_Malloc
Imports of pre-built libraries seem to work:
LSAN_OPTIONS=suppressions=asan-supp.txt LD_PRELOAD=/home/willayd/mambaforge/envs/pandas-dev/x86_64-conda-linux-gnu/lib/libasan.so python -c 'import numpy'

=================================================================
==2612008==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 3397 byte(s) in 1 object(s) allocated from:
    #0 0x7fcd5a894dd2 in __interceptor_realloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:85
    #1 0x7fcd5a3de9c6 in resize_compact Objects/unicodeobject.c:1060

Direct leak of 436 byte(s) in 41 object(s) allocated from:
    #0 0x7fcd5a8955f8 in __interceptor_malloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7fcd5722bb19 in PyUFunc_FromFuncAndDataAndSignatureAndIdentity (/home/willayd/code/pydebug/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-x86_64-linux-gnu.so+0x42bb19)

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x7fcd5a894dd2 in __interceptor_realloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:85
    #1 0x7fcd5722c018 in PyUFunc_FromFuncAndDataAndSignatureAndIdentity (/home/willayd/code/pydebug/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-x86_64-linux-gnu.so+0x42c018)

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x7fcd5a894dd2 in __interceptor_realloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:85
    #1 0x7fcd5722c000 in PyUFunc_FromFuncAndDataAndSignatureAndIdentity (/home/willayd/code/pydebug/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-x86_64-linux-gnu.so+0x42c000)

Direct leak of 23 byte(s) in 1 object(s) allocated from:
    #0 0x7fcd5a8955f8 in __interceptor_malloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7fcd5722bb58 in PyUFunc_FromFuncAndDataAndSignatureAndIdentity (/home/willayd/code/pydebug/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-x86_64-linux-gnu.so+0x42bb58)

Direct leak of 12 byte(s) in 1 object(s) allocated from:
    #0 0x7fcd5a8955f8 in __interceptor_malloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7fcd5722bbad in PyUFunc_FromFuncAndDataAndSignatureAndIdentity (/home/willayd/code/pydebug/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-x86_64-linux-gnu.so+0x42bbad)

Direct leak of 12 byte(s) in 1 object(s) allocated from:
    #0 0x7fcd5a894dd2 in __interceptor_realloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:85
    #1 0x7fcd5722c033 in PyUFunc_FromFuncAndDataAndSignatureAndIdentity (/home/willayd/code/pydebug/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-x86_64-linux-gnu.so+0x42c033)

Direct leak of 12 byte(s) in 1 object(s) allocated from:
    #0 0x7fcd5a8955f8 in __interceptor_malloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7fcd5722bbbe in PyUFunc_FromFuncAndDataAndSignatureAndIdentity (/home/willayd/code/pydebug/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-x86_64-linux-gnu.so+0x42bbbe)

-----------------------------------------------------
Suppressions used:
  count      bytes template
    352     519514 _PyObject_Malloc
-----------------------------------------------------

SUMMARY: AddressSanitizer: 3940 byte(s) leaked in 48 allocation(s).

Any idea what might be the problem with the import of the built project?
Worth noting I have tried this both with a production python and a dev python build with sanitizer support, and both yielded the same results

When a package is installed in editable mode with pip -e, meson-python rebuild the project when it is imported for the first time in a given interpreter instance. The error message is a failure of meson-python to rebuild the project running ninja. What happens if you run ninja in the build directory? What changes if you do it with the LD_PRELOAD variable set in the same way as in your test?

Ah very nice - I found the issue with that advice. The "problem" is that I put a suppression file in my project root. Following your advice to try that from the build folder yielded:
LSAN_OPTIONS=suppressions=asan-supp.txt LD_PRELOAD=/home/willayd/mambaforge/envs/pandas-dev/x86_64-conda-linux-gnu/lib/libasan.so ninja
[1/1] Generating write_version_file with a custom command
FAILED: _version_meson.py
/home/willayd/code/pydebug/bin/python ../generate_version.py -o _version_meson.py
AddressSanitizer: failed to read suppressions file '/home/willayd/.pyenv/versions/3.11.3/bin/asan-supp.txt'
ninja: build stopped: subcommand failed.

So it seems like the fix was to specify the absolute path to the suppressions file via LSAN_OPTIONS

Thanks again for the help @dnicolodi

@WillAyd numpy has a GHA CI job that runs ASAN, maybe that's of use to you: https://github.com/numpy/numpy/blob/main/.github/workflows/linux_compiler_sanitizers.yml

Good to know. @lithomas1 might be interested in that as well. We've loosely talked about setting something like that up in pandas so great to see we don't need to start from scratch


adjust description of dataSourceConfig.rMEndPoints in hadoop-queue-monitoring

Trivial modification, didn't open jira ticket for it.

Please format title as "[MINOR] xxxx" for trivial modification.


Add rubyonremote.com and remove StackOverFlow Jobs

RubyOnRemote is a ruby/rails job board running since 2018 and currently has a user base of 800+ Rubyists.
Also removing StackOverFlow Jobs because they shutdown.

@ekrubyguy thanks!


⚠ Bofrost.at has degraded performance

In d6f120e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1483 ms

Resolved: Bofrost.at performance has improved in c05c97a after 6 minutes.


ippfind: add LOC record checking and filtering

Originally reported in ippsample project:
https://github.com/istopwg/ippsample/issues/1

It would be useful to add support for querying for the presence of published LOC records and filtering results based on proximity based on data from LOC records.
IPP Everywhere (5100.14) requires Printers to publish LOC records, but we are currently lacking a tool that would allow the PWG IPP Everywhere Self Certification test suite to validate whether the device has published a LOC record for its IPP services.

It appears that both mDNSResponder and Avahi have APIs to query arbitrary DNS record types, so it may be possible to get this information. Will need to do some testing to see how existing printers respond to such queries...

Also, we'll need to update ippserver to publish LOC records... :)

and then privacy issues make this moot. NTBF.


Run Conformance Testing for k8s 1.22

k8s 1.22 is avaiable starting at rancher 2.6.3. We need to run Conformance Testing for Rancher

Rancher Server Setup

Rancher version:v2.6.3-rc4
Installation option (Docker install/Helm Chart): Docker
Proxy/Cert Details:Selfsigned

Information about the Cluster

Kubernetes version:v1.22.4
Cluster Type (Local/Downstream):

Downstream 1 Node with CP, ETCD and Worker, 2 Worker nodes.

To Reproduce

Create downstream cluster on Rancher v2.6.3-rc4.
Once the cluster is up and active, update the kube_api with following extra argument.

  extra_args:
       service-account-issuer: https://<cp_ip>:6443

(<cp_ip> is Public/External IP of Control Plane)

Run conformance test

Results
Ran 346 of 6433 Specs in 5277.484 seconds
SUCCESS! -- 346 Passed | 0 Failed | 0 Pending | 6087 Skipped
PASS

Ginkgo ran 1 suite in 1h27m59.495464593s
Test Suite Passed

Rancher conformance test results PR on cncf: https://github.com/cncf/k8s-conformance/pull/1726


Livewire issues when accessing menu

@ryangjchandler
I am encountering an issue when using the latest version of the package on a fresh install of Filament 3 where only the overlay appears when you click "Add Item" or try to edit an existing item. The form is missing.
Is there something I have missed in the setup?

@ryangjchandler

@ryangjchandler

Please do not bump an issue by ping me directly.

I'm currently on vacation and won't be able to look at this problem until Tuesday.

Apologies @ryangjchandler I managed to get this working and forgot to update the ticket. I wiped my plugin configuration and rewrote it which enabled me to get it working. I can only assume there was some sort of "syntax" issue here that didn't register at the PHP level.


Location data not send to our server on locationUpdateInterval and on heartbeatInterval

-->
Your Environment
Plugin version:
"@transistorsoft/capacitor-background-fetch": "^5.1.1",
"@transistorsoft/capacitor-background-geolocation": "^5.2.4",
Platform: iOS or Android
Device OS version: Android 13,14
Device manufacturer / model: Samsung galaxy note20 ultra 5g
XCode version: Version 15.1
Capacitor info (npx cap doctor)
💊 Capacitor Doctor 💊

Latest Dependencies:

@capacitor/cli: 5.7.2
@capacitor/core: 5.7.2
@capacitor/android: 5.7.2
@capacitor/ios: 5.7.2

Installed Dependencies:

@capacitor/cli: 5.3.0
@capacitor/core: 5.3.0
@capacitor/android: 5.3.0
@capacitor/ios: 5.3.0

[success] iOS looking great! 👌
[success] Android looking great! 👌

We have capacitor-background-geolocation license .

BackgroundGeolocation.ready({
      reset: true,
      debug: true,
      logLevel: BackgroundGeolocation.LOG_LEVEL_VERBOSE,
      desiredAccuracy: BackgroundGeolocation.DESIRED_ACCURACY_HIGH,
      activityType: BackgroundGeolocation.ACTIVITY_TYPE_AUTOMOTIVE_NAVIGATION,
      distanceFilter: 0,
      locationAuthorizationRequest: 'Always',
      enableHeadless: true,
      stopOnTerminate: false,
      startOnBoot: true,
      stopOnStationary: false,
      heartbeatInterval: 600,
      preventSuspend: true,
      locationUpdateInterval: 300000,
      foregroundService: true,
      // [Android] backgroundPermissionRationale for Always permission.
      backgroundPermissionRationale: {
        title: 'Allow {applicationName} to access to this device`s location in the background?',
        message: 'In order to track your activity in the background, please enable {backgroundPermissionOptionLabel} location permission',
        positiveAction: 'Change to {backgroundPermissionOptionLabel}',
        negativeAction: 'Cancel'
      },
      locationAuthorizationAlert: {
        titleWhenOff: 'Activate your location in ALWAYS mode',
        titleWhenNotEnabled: 'Activate your location in ALWAYS mode',
        instructions: 'In order to keep your location updated in the background, please enable "Always" in Location permissions. This is necessary for the application to work correctly and for you to share your current location with your load Info.',
        cancelButton: 'Cancel',
        settingsButton: 'Settings'
      },
      url: environment.api.APP_SERVER_CONTEXT_URL + environment.api.Location_Update,
      autoSync: true,
      authorization: {
        strategy: "JWT",
        accessToken: this.auth.currentUser.accessToken
      },
      params: {
        latitude: this.curentLat,
        longitude: this.currentlong,
        speed: null,
        timestamp: moment().valueOf()
      },
      maxDaysToPersist: 14,
    }).then(async (state) => {
      // Store the plugin state onto ourself for convenience.
      console.log('- BackgroundGeolocation is ready: ', state);
      this.zone.run(() => {
        this.state.enabled = state.enabled;
        this.state.isMoving = state.isMoving;
        this.state.trackingMode = state.trackingMode;
      });
    }).catch((error) => {
      console.warn('- BackgroundGeolocation configuration error: ', error);
    });

## Expected Behavior

Update Location data to our server on locationUpdateInterval and on heartbeatInterval.

## Actual Behavior

When I set location Update Interval as 5 mins , first time I got HTTP response. From next onwards I didn't get any HTTP response.

When I set heartbeatInterval 10 mins, Event fire every 10 mins. But I didn't get any HTTP response.

How to call our service ( HTTP call)  on heartbeatInterval?

## Context
Update Location data to our server on locationUpdateInterval and on heartbeatInterval.

[Android_Logs.pdf](https://github.com/transistorsoft/capacitor-background-geolocation/files/14931914/Android_Logs.pdf)

When I set locationUpdateInterval 1000 also HTTP is calling very first time. From there it was not repeat. How to call HTTP service call every 10 mins?
I called .getCurrentPosition in .onHeartbeat
onHeartbeat(event: HeartbeatEvent) {
console.log('[heartbeat] -', event);
BackgroundGeolocation.getCurrentPosition({
samples: 1,
persist: true
}).then((location) => {
console.log("[getCurrentPosition] ", location);
});
}

From there it was not repeat.

  Read the wiki here “Philosophy of Operation”.
then go outside with a real device for a nice long walk of >= 1000 meters.

Ok, It's working on moving state.
But I need HTTP call OnStationary state on every 10 mins.


fixes SDM for some people

Jenkins please retest this.

@Rikkola @ederign It definitely makes a difference for me (and besides, why should drools-wb-verifier-core be provided when drools-wb-verifier-client is not?). Unless somebody can give a compelling reason not to merge I will do so (on Monday).

+1 to remove the <provided> scope if this is direct dependency.

+1, I know, I know I am picky, but @Rikkola could you please change the commit message to i.e. "Set drools-wb-verifier-core dep. to compile scope to fix SDM." It's much more descriptive than "fix SDM for some people'" :)

Done. Jenkins please retest. Rebased the branch.


swagger-maven-plugin not including  @ApiOperation's consumes/produces

Hi,
I am currently using swagger-maven-plugin version 3.1.1-SNAPSHOT and swagger-core 1.5.3 and i have the below issue.
I am able to generate html and swagger.json for my Spring MVC REST controllers.Controllers are swagger annotated but  consumes/produces for request and response are not reflected in generated html and swagger.json
Controller piece:
@ApiOperation(value="Create Account",
    notes="This method will validate the information passed before attempting to create a new Account. It will check if the " +
        "accountId, account Name, creation date information is correct. Thereafter, the account creation process starts ",
    response=String.class,
    consumes="application/json, application/xml",
    produces="application/json, application/xml"
    )
@ApiResponses(value = {
        @ApiResponse(code = 200, message = "Successful response",response=String.class),
        @ApiResponse(code = 420, message = "Acccount cannot be created",response=RestErrorMessage.class),
        @ApiResponse(code = 500, message = "Unkown error",response=RestErrorMessage.class) })
@RequestMapping(value = "/accounts/{accountId}", method = RequestMethod.PUT)
public ResponseEntity<?> createAccount( @ApiParam(value="This parameter provides account Id for the new account.") @PathVariable("accountId") Integer accountId,@ApiParam(value="This parameter encapsulates new account information.")@RequestBody Account acct) {

Generated JSON part:
"put" : {
"summary" : "Create Account",
"description" : "This method will validate the information passed before attempting to create a new Account. It will check if the accountId, account Name, creation date information is correct. Thereafter, the account creation process starts ",
"operationId" : "createAccount",
"parameters" : [ {
"name" : "accountId",
"in" : "path",
"description" : "This parameter provides account Id for the new account.",
"required" : true,
"type" : "integer",
"format" : "int32"
}, {
"in" : "body",
"name" : "body",
"description" : "This parameter encapsulates new account information.",
"required" : false,
"schema" : {
"$ref" : "#/definitions/Account"
}
} ],
"responses" : {
"200" : {
"description" : "Successful response"
},
"420" : {
"description" : "Acccount cannot be created",
"schema" : {
"$ref" : "#/definitions/RestErrorMessage"
}
},
"500" : {
"description" : "Unkown error",
"schema" : {
"$ref" : "#/definitions/RestErrorMessage"
}
}
}
},
Generated HTML:

I dont even see the content-type section in request and response.

Try annotating your endpoints with jaxrs annotations
@Produces({"application/json"})
@Consumes({"application/json"})

Man can you share your pom.xml cause I go by the book and the swagger.json is empty...from rest api endpoints..

I can see this in version 3.1.3. I've tried adding all of
@ApiParam(consumes="multipart/form-data")
@Consumes("multipart/form-data")
@RequestMapping(consumes = "multipart/form-data")

but the generated JSON doesn't contain the consumes parameter. This is particularly important to me, as a swagger-codegen generated java/jersey2 client won't send form data unless consumes="multipart/form-data" is present.

Ok, in 3.1.3 @RequestMapping(consumes) works as long as produces is also present, due to this typo in SpringMvcApiReader line 128:
 apiConsumes = (apiConsumes == null || apiProduces.length == 0) ? controllerConsumes : apiConsumes;

should read
apiConsumes = (apiConsumes == null || apiConsumes.length == 0) ? controllerConsumes : apiConsumes;

I think you may have fixed this in master, though?

I am finding that multiple values for the consume property (comma-delimited) of @ApiOperation is being ignored.  Instead, only the last one in the list is shown in the final swagger documentation.
    @Consumes("multipart/form-data")
    @ApiOperation(value = "<some description>", response = String.class, consumes = (MediaType.MULTIPART_FORM_DATA
            + "," + MediaType.APPLICATION_JSON))

produces
...
        "tags" : [ "<some tag>" ],
        "summary" : "<some description>",
        "description" : "",
        "operationId" : "<some operation name>",
        "consumes" : [ "application/json" ],
        "produces" : [ "application/json" ],
        "parameters" : [ {
...


PowerPaint v2

Is the PowerPaint v2 model compatible? You can find it in this GitHub repository: https://github.com/open-mmlab/PowerPaint
The model features an architecture akin to BrushNet and delivers remarkable inpainting performance.

I plan to implement it. I am working on non-diffusers native ComfyUI version now. I think it will be ready in a couple of days. Then it will be possible to use IP Adapter v2 and all other ComfyUI nodes with BrushNet. After that I am going to implement PowerPaint v2.

Thanks!

那么现在brushnet模型加载器里面，可以选择PowerPaint v2，意思是已经支持了？

PowerPaint is ready.


Criteria Matching Ignoring In Memory Changes

This seems to be the same issue reported in https://github.com/doctrine/doctrine2/issues/3046, however
It appears that if I make a change to an entities field without flushing, the subsequent matching call with a criteria queries the database for the association and returns incorrect results. The in memory changes are still applied though
Given this function:
    public function getActiveUsers()
    {
        $criteria = Criteria::create();
        $criteria->where(Criteria::expr()->eq('active', true));

        return $this->users->matching($criteria);
    }

Running the following will output "true true"
foreach($organisation->getActiveUsers() as $user)
    echo ($user->isActive() ? 'true' : 'false');

Marking one of those users as inactive and running the same criteria match will output "false true"
User::get(1)->setActive(false);

foreach($organisation->getActiveUsers() as $user)
    echo ($user->isActive() ? 'true' : 'false');

This bug is forcing me to perform a flush before every criteria query which is extremely draining on performance. If anyone can shed some light on this it would be appreciated

Same issue in onFlush. Only here I can not flush, so I have to do something lie $entity->collection->toArray() to force a fetch & merge. A better workaround is appreciated.

@awhitby could you please send us a PR with a functional test that reproduces this behaviour? Sending just an example doesn't give us the complete overview of things and why it fails. You can find examples on https://github.com/doctrine/doctrine2/tree/971c40002522cfebe58d80aff21eef9fe439fa60/tests/Doctrine/Tests/ORM/Functional

Same problem here. I'm trying to run a criteria::matching after persist but it doesn't see the new elements being persisted.
If I flush, then it works


Some napps need to be deleted

After installing kyco, we need to delete some napps so it works.

Already solved by enabling only of_core by default and removing of_liveness (using old and non-existent classes).


Expression Evaluation

Building off the streamlit-refresh-bug-fix branch:

Adds expression evaluation within tabular data
Adds simpleeval to requirements.txt

simpleeval is a very small package that adds a safer version of eval - still not 100% safe, but enough that it is unlikely to run (incidentally) malicious code. Also, the function checks if the cell value is "" or "-", because non-expressions will not run. This most likely cannot be comprehensive, but if y'all know of any other likely non-expression values that would be in the cell, I'd like to make it as safe as possible.

Update:

Fixed expression evaluation and added error handling
Added multiple file input


Style: Added .pylintrc

This will make it so if you guys are using pylint/pep8 the settings will be shared.

Already merged through tokeniser