Fix diff highlight of symbol-keyed object.

Summary
Fixes #9432.
Use Object.getOwnPropertySymbols to traverse object's symbol key can fix this issue.
Thanks @pedrottimark to point out this edge case.
Test plan
Add  symbol-keyed object tests.

Codecov Report

Merging #9499 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #9499      +/-   ##
==========================================
+ Coverage      65%   65.01%   +0.01%
==========================================
  Files         283      283
  Lines       12131    12135       +4
  Branches     3002     3003       +1
==========================================
+ Hits         7886     7890       +4
  Misses       3604     3604
  Partials      641      641

Impacted Files
Coverage Δ

packages/jest-matcher-utils/src/Replaceable.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdaa75...56cab73. Read the comment docs.


[hotfix] [docs] reference.md: Add missing FlinkSessionJob CRD

What is the purpose of the change
Add missing documentation for FlinkSessionJob CRD.
Brief change log

Add docs for FlinkSessionJob CRD.
Reorganize docs into three categories:

FlinkDeployment-specific resources
FlinkClusterJob-specific resources
Shared resources

Increase table of contents maximum level to 4.
Remove application deployment-related language from session job docs.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage, other than verifying locally.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@gyfora Thanks for clarifying, I'll make the changes there.


FR: Granular control over date/time pickers.

It would nice to have the below features in the picker:

Allow Custom header messages (useful when there are multiple pickers with autoOK)

Make action buttons optional, again useful with multiple pickers.

All custom defined, onTouchTap events for action buttons.

Let me if this sounds ok, ready to do a PR.

@oliviertassinari What do you think? I think these are good features.

Allow Custom header messages (useful when there are multiple pickers with autoOK)

Could you elaborate on this point?

Make action buttons optional, again useful with multiple pickers.

Sounds fair

All custom defined, onTouchTap events for action buttons.

What is your use case?

Could you elaborate on this point?

Alright, say the user has to pick two dates from two different date pickers in the same page, it would nice to have specific header/message for each calendar, say something like below:

What is your use case?

Not able to recall as of now. (My brain shall await for the promise to resolve ;))

My brain shall await for the promise to resolve ;)

Almost had a heart attack :joy: :joy:

Alright, say the user has to pick two dates from two different date pickers in the same page, it would nice to have specific header/message for each calendar

I think it's good to have this. I like the idea.

heh heh looks like the promise threw an exception.
One more thing would be have custom buttons, rather than just cancel and OK.
Related issue #2118

One more thing would be have custom buttons, rather than just cancel and OK.

What would the custom buttons do?

Say in the example I gave, if I could not have cancel or ok button, but just one button which said pickup that would be cool, no?

@hemanth The edge cases are so many. and this use-case is so specific. If we make actions customizabe then how far should be expose them? we'll end up with date-picker having a huge number of prop. if we provide an actions prop so the user can provide the buttons then how will we hook the OK and CANCEL with them? this will lead to a very un-intuitive API. Maybe it's best to provide ways for users of this library to build their own date-picker the way they want. By exposing all date-picker components and customization guild. @oliviertassinari What do you think?

@hemanth Closing this for now. The custom header wouldn't work with a landscape dialog, the button labels can be customised, and hooks for the buttons isn't something we want to add.


The "Generate deployment scripts..." command is a preview feature and might be subject to change.

Describe the Bug with repro steps
I am trying to generate the deployment script for the logic app since I must deploy the process in Azure Devops.
I have tried the function deployment task and the new extension from azure devops.
Another alternative is this one from visual studio code but after trying to generate the script I get this message
What type of Logic App Is this happening in?
VS Code
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos

Browser
visual studio code
Additional context
No response

Hi @veronicagt094, thanks for raising this issue. The information message that we show as "The "Generate deployment scripts..." it just simply works as informational content. It's to let the user know that this feature is in preview and not stable.
In the current production version, the command does nothing if it detects no connections in the workflow (it doesn't even shows an alert about this), as indicated by the absence of a connections.json file in the logic app folder. From your screenshot, it is clear that there are no connections in your folder.
We are improving this feature. The upcoming version will allow the generation of deployment scripts even without any connections.
Could you please try adding some actions in your workflow that require connections? We will be releasing the new version in about 2 weeks.


Unable to resolve libraries for '.NETCoreApp,Version=v3.0' in windows 10

We have developed a console application with .net core 3.0 + visual studio code + windows 10. Application could not compile and give following error:
error NU1100: Unable to resolve 'Microsoft.Extensions.Hosting (>= 3.0.0)' for '.NETCoreApp,Version=v3.0'.
error NU1100: Unable to resolve 'Microsoft.Extensions.Configuration (>= 3.0.0)' for '.NETCoreApp,Version=v3.0'.
error NU1100: Unable to resolve 'MailKit (>= <IP_ADDRESS>)' for '.NETCoreApp,Version=v3.0'.
error NU1100:Unable to resolve 'Microsoft.Extensions.Logging (>= 3.0.0)' for '.NETCoreApp,Version=v3.0'.
error NU1100:Unable to resolve 'Microsoft.Extensions.Logging (>= 3.0.0)' for '.NETCoreApp,Version=v3.0'
error NU1100:Unable to resolve 'Microsoft.Extensions.Configuration (>= 3.0.0)' for '.NETCoreApp,Version=v3.0'
error NU1100: Unable to resolve 'Newtonsoft.Json (>= 12.0.2)' for '.NETCoreApp,Version=v3.0'
error NU1100:Unable to resolve 'System.Data.SqlClient (>= 4.7.0)' for '.NETCoreApp,Version=v3.0'
error NU1100:Unable to resolve 'Microsoft.Extensions.Logging.Abstractions (>= 3.0.0)' for '.NETCoreApp,Version=v3.0'
error NU1100: Unable to resolve 'Microsoft.Extensions.Logging.Configuration (>= 3.0.0)' for '.NETCoreApp,Version=v3.0'
Even when we tried to install these libraries using command like
dotnet add package Microsoft.Extensions.Logging.Abstractions --version 3.0.0,
it gives message like "Package 'Microsoft.Extensions.Logging.Abstractions' is incompatible with 'all' frameworks in project".
We have repaired the .net core 3.0, so it works fine for few builds and again same problem starts occurring. Later on we have repaired and install/uninstall .net core 3.0
multiple times but does not work for us.
We have urgent deliveries related to this, so please guide us for the solution of this problem ASAP.

We will probably need a sample app that shows this problem.
CC @rrelyea @livarcocc

Closing out due to lack of response; please re-open if you're still hitting this issue and can provide more detail.


Certificate error due to invalid name in FluxCD HelmRelease installation

Bug description
When installing capsule in FluxCD as a HelmRelease all services automatically get the HelmRelease name as a prefix. This is incompatible with the certificate generated internally.
 Warning  ReconciliationFailed     13s (x10 over 8m14s)  kustomize-controller  Namespace/ingress-nginx dry-run failed (InternalError): Internal error occurred: failed calling webhook "owner.name
space.projectcapsule.dev": failed to call webhook: Post "https://capsule-capsule-webhook-service.capsule.svc:443/namespace-owner-reference?timeout=30s": tls: failed to verify certificate: x509: c
ertificate is valid for capsule-webhook-service.capsule.svc, not capsule-capsule-webhook-service.capsule.s

How to reproduce
I'm installing capsule as a HelmRelease with the following yaml
---
apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
  name: capsule
  namespace: flux-system
spec:
  chart:
    spec:
      chart: capsule
      reconcileStrategy: ChartVersion
      sourceRef:
        kind: HelmRepository
        name: projectcapsule
      version: '>=0.7.2 < 0.8.0'
  install:
    crds: Create
    createNamespace: true
    remediation:
      retries: -1
  interval: 5m0s
  targetNamespace: capsule
  upgrade:
    crds: CreateReplace

The ingress-nginx controller which installs a little earlier attempts to make a webhook call to capsule and fails with the error mentioned earlier
Expected behavior
I'm trying to find some way to add an additional name into SANS but so far have not been able to find something in the helm chart values.
Logs
If applicable, please provide logs of capsule.
In a standard stand-alone installation of Capsule,
you'd get this by running kubectl -n capsule-system logs deploy/capsule-controller-manager.
Additional context

Helm Chart version: 0.7.2

We should make this configurable, or fixed:
https://github.com/projectcapsule/capsule/blob/20807ad8f384a49da75fcb9672691d9e5dd3b38e/charts/capsule/templates/certificate.yaml#L27-L29
Are you up for a contribution? New contributors are always welcomed! 🫂 🤗

Ah that's the line I was looking for.  I'll see if I can do something with this in the next few days.
Thanks!

I've created https://github.com/projectcapsule/capsule/pull/1303 but after playing around with the helm chart I don't know if it's necessary.
In my case it looks like setting
fullnameOverride: capsule-capsule
certManager:
  generateCertificates: true

Solves the problem. I'll submit that PR anyway in case it might also be useful to be able to set additional SANS.

I'll submit that PR anyway in case it might also be useful to be able to set additional SANS

Loving it, thanks! ❤

Closed via #1303


Custom storage path for videos

Being able to save videos in a different path than photos would be very nice.

Keeping this issue here but removed the part about screenshots. That would be an OS feature request.


Import documentation from Google Docs

GitHub will be our official documentation storage.
Closes #62.
Currently blocked on #64.

While we're waiting, I'd like to get someone's approval.

Hm... sorry wrong PR again :D

@ForNeVeR is there anything you want to complete before the merge? I'd like to start translating these docs after I get back home from a conf.

Nope, nothing. Feel free to branch this stuff and change it as you like; you may start right now. I'll deal with the merge outcome (e.g. rebase everything properly).


Any plan to add other ThinQ Devices? LG GSJ761PZZZ Side-by-Side

@sman591 I hope not to bother, but I can't find any other solution for ThinQ -> Homebridge and the experience you show with your plugin.
Do you have any plans to support more ThinQ devices in the future or create another ThinQ plugin? I was hoping to use my Fridge LG GSJ761PZZZ showing Temperature in HomeKit.
If there is anything I can do to help from user side, please of course let me know.
Thanks again for the time you are investing and for your work sharing with the community. 👍

@DJay-X I only have my one A/C unit, so I don't have any plans to add additional product support at this time.
Does your Fridge LG GSJ761PZZZ show up with this plugin at all? It might not be hard to add basic temperature support but I'm not sure what the API response is like

@sman591 Thanks for your friendly reply.
I received the new fridge a couple of days ago and now I was able to just give the plugin a shot out of curiosity. :)
Jun 13 23:41:59 raspberrypi-3BPlus homebridge[3786]: [2020-6-13 23:41:59] Loaded plugin<EMAIL_ADDRESS>Jun 13 23:41:59 raspberrypi-3BPlus homebridge[3786]: [2020-6-13 23:41:59] Registering platform 'homebridge-lg-thinq-ac.LgThinqAirConditioner'
Jun 13 23:42:00 raspberrypi-3BPlus homebridge[3786]: [2020-6-13 23:42:00] [LgThinqAirConditioner] Initializing LgThinqAirConditioner platform...
Jun 13 23:42:01 raspberrypi-3BPlus homebridge[3786]: [2020-6-13 23:42:01] [LgThinqAirConditioner] Initiating auth with provided redirect URL
Jun 13 23:42:04 raspberrypi-3BPlus homebridge[3786]: [2020-6-13 23:42:04] [LgThinqAirConditioner] Discover found 1 total devices

There is 1 device discovered but nothing (of course?) is showing up in HomeKit.
Well... it's fridge, not an A/C. 😅
However, in the meantime I was also able to get to grips with the LG ThinQ app and it is completely useless for the fridge.
The temperature of the fridge and freezer can be changed, Express Freeze can be switched on/off, but the current actual temperature of the device is not displayed at all.
As if you constantly change the temperature of your fridge and need the app for that?! The obvious idea of displaying the real temperature seems too abstract for the LG developers.
Buy this I don't think it's worth to put energy and work into further investigation? Especially if there was no general intention on your part to develop the app for other LG devices.
Let me know what you think and of course you can close this ticket.
Thanks again for being a developer and sharing your work with the community. 👍

The temperature of the fridge and freezer can be changed, Express Freeze can be switched on/off, but the current actual temperature of the device is not displayed at all.

Ah, that's unfortunate 😞 yeah, doesn't sound like something this plugin will support in the near term given the controls/state would be pretty different.


Hidden files not covered by ** glob

Using this example:
files:
  # Keys are glob expressions.
  # You can assign groups defined above as well as GitHub usernames.
  '**':
    - repository-owners # group
    - team:external-reviewers # GitHub team

if the PR only contain changes files inside a hidden folder (e.g. .github), the reviewers are not added.
Output:
No default reviewers are matched; terminating the process

@lmvco I played around with it but It looks like that's how glob works.

I think you can use {**,.**,.**/**} or something similar to cover files and directories starting ..

Ref: https://www.digitalocean.com/community/tools/glob

FYI - the glob logic is implemented with minimatch


Update facades to use pub(crate)

There are a couple module facades (async_impl vs async and multipart_ vs multipart) that exist purely to allow exposing some items out of the module without making those items public on reqwest::unstable::async and reqwest::multipart.
Additionally, several modules have public free functions with a comment // pub(crate).
Those can be consolidated into just single modules, and the functions can become part of the related type, with pub(crate) visibility added to them.

The async_impl module should probably stay how it is for now, since async is becoming a keyword (#357).
To close this out, any instances of modules that have pub items but no docs should be changed to pub(crate). If they are free functions, they can probably become methods of the type of the first argument to them (for example, response::new(res, ...args) to Response::new(...args), or body::into_async(body) to body.into_async()).

Done!


Fix Failing pipeline - tikv_ghpr_integration_common_test

Development Task
A lot of the commits in this repo's master have a red status https://github.com/tikv/tikv/commits/master and I noticed many of them are failing only in area - idc-jenkins-ci-tikv/integration-common-test, which points to a Jenkins pipeline with the name tikv_ghpr_integration_common_test in it
At the time of this writing, the latest failure is https://ci.pingcap.net/blue/organizations/jenkins/tikv_ghpr_integration_common_test/detail/tikv_ghpr_integration_common_test/2928/pipeline from this commit - https://github.com/tikv/tikv/commit/2934196762268d6b1a664d1cbce9b24769e33f20
I think it's important to avoid red status commits and failing pipelines, as those are indicative of some issue and need to be looked at - if it's a bug / actual failure, fix it, or else if it's flaky, deflake it.
I recently noticed etcd repo taking an interesting approach in case of flaky tests - https://github.com/etcd-io/etcd/issues/13167 , it inspired me to checkout further more about tests specifically failing ones and flaky ones, which I usually try to debug and fix
I'm not sure if it's flaky or not or what's going on in this case, since I haven't debugged / dug deeper. Maybe digging deeper might help, I'll see if I can check more on this sometime when I can

Thanks for your reporting @karuppiah7890 !
Agree it's significant to ensure ci stability. @BusyJay @skyzh @zhouqiang-cl do you have ideas on tikv_ghpr_integration_common_test failures?

Commits on master should be running the same continuous integration procedure as pull requests. It’s weird that PRs pass the tests, but when they come to master branch, they fail…

@skyzh no. I think we're now running only building and unit tests for pull requests.

Only maintainers and committers could trigger integration tests by /merge or /run-all-tests. Integration tests won’t run by default.

Just find out that integration test is not running in PRs… Something has changed 😂

I guess https://github.com/pingcap/tidb/pull/27484 is the root cause of failure. By the way, why is integration-test not running in PRs?????

~Only maintainers and committers could trigger integration tests by /merge or /run-all-tests. Integration tests won’t run by default.~

IIRC you can still trigger integration tests by /run-integretion-tests or something. I'm driving our infra team member to post an announcement on internals.tidb.io and it may include the information or at least we can ask for it.
@purelind I remember you summarize our ci pipeline and commands communicate with them. In our previous discussion we'd like to tight them up with the repo. Is there any progress? We can create an issue to trace the document writing task.

I believe run-integretion-tests is a must especially for copr-related PRs. Otherwise our contributors will never know if they siliently break anything.

@tisonkun  Docs on ci pipeline and trigger phrases to communicate with them are on progress。An issue to trace the docs writting task will be much better.

@zhouqiang-cl can you take a look? I remember the case is taken down for CI speed. We assumed some one will watch master's status and fix potential problems. Though it seems to be contrary.

closed as master CI fixed. @zhouqiang-cl spotted that it is caused by https://github.com/pingcap/tidb/issues/27673 .
But we can still think of turning on copr related tests for PRs, moving to https://github.com/tikv/tikv/issues/10877 FYI.


Feature: Stack Traces for JS Errors (Only possible on Android)

The fabric crashlytics plugin supports logging js stack traces on android. I'd like to port that functionality over to this plugin, which would greatly improve the usefulness of js error reporting. It works by manually calling setStackTrace on the exception. However, since no equivalent exists in iOS, this is only possible on android. Here is the relevant method in Fabric's repo: https://github.com/sarriaroman/FabricPlugin/blob/master/src/android/FabricPlugin.java#L125
I'd be willing to do the work if this is something that will get merged.

I'm implemented this feature on the wizpanda fork: https://github.com/wizpanda/cordova-plugin-firebase-lib/pull/8


SRI testing harness data

Cut from https://github.com/biothings/BioThings_Explorer_TRAPI/issues/450#issuecomment-1176496343.
Add test_data_location in x-trapi. Would be mostly a Colleen thing. This is optional in the schema. However, it's related to the SRI testing harness and

[ ] TAKES A WHILE: building the test files for "one triple of each type that the KP can provide" for Service Provider (and maybe Multiomics / Text-Mining too)
[ ] the test file for the BTE ARA is easy to update, but would need to be kept up-to-date with the API_LIST variable in the BTE's config
[ ] add x-trapi.test_data_location to TRAPI registrations (BTE and Service Provider)

In the implementation tracker, this now has an implementation date of today. Very few teams have completed this so I don't think we're "late", but internally let's shoot for initial "completion" by 2022-10-11.  For an initial implementation, let's create test data for the following three records:

mygene.info: BRCA2 (NCBIGene:675) related_to Breast/Ovarian Cancer (MONDO:0012933) (source: http://mygene.info/v3/gene/675?fields=clingen)
mychem.info: imatinib (InChIKey:KTUFNOKKBVMGRW-UHFFFAOYSA-N) treats CML (MESH:D015464) (source: http://mychem.info/v1/chem/KTUFNOKKBVMGRW-UHFFFAOYSA-N?fields=chembl)
bioplanet: TP53 (NCBIGene:7157) participates_in Cell cycle progression regulation by PLK3 (bioplanet:bioplanet_68) (source: https://biothings.ncats.io/bioplanet_pathway_gene/association/bioplanet_68-7157)

More documentation is provided in the parent issue https://github.com/TranslatorSRI/SRI_testing/issues/56.

link to be added to Service Provider KP smartAPI registration here https://github.com/NCATS-Tangerine/translator-api-registry/blob/master/biothings_explorer/service-provider-trapi.yaml#L29

Info here on the JSON structure https://github.com/TranslatorSRI/SRI_testing/tree/main/tests/onehop#configuring-the-tests

The initial task outlined by Andrew's post is done. The test data is here and the test_data_location field has been added.
Notes:

I added fields to make it clearer where the edge/record came from (underlying_api_infores and underlying_source_infores) and what entities are involved (subject_name and object_name)
I used the "raw" link for the test_data_location field, but it's not clear if the SRI testing harness would prefer the non-raw link

closing this as our initial implementation is done.  We can do more when/if the rest of the consortium moves forward on this.


Fixing timeouts in workflow tests.

Although I don't see how that triggers the 'go test -race' timing out
fater 10 minutes.

LGTM
(Shame on me for not catching it in the review.)


Adjusted to ?po command

Hi,
instead of just "Windsinger"  please adjust so it shows the role of the player currently on the server.
"Windsinger (Guest)"
"Windsinger (Member)"
Kind regards,
Windsinger

Wont allow me add a label "Enhancement" or " Request "


Outdated documentation at https://blueskyproject.io/hklpy

I am observing the outdated documentation for v0.3.14 at https://blueskyproject.io/hklpy while v0.3.15 is available. Was the documentation push failing?

It's working now.


Issue #70 Add color variable for links with good contrast

I introduced an additional variable for link colors and applied the color suggested by @marcysutton in #70

Thanks!


Updating the rotateX for FPSCamera

If you just return this without doing no angle rotation when the FPSCamera isn't already in ANGLE_LIMIT_X it can never obtain the limit.
Exemple :
FPSCamera are in angleX 50.9, if the angleX in parameter for this update is more than 1.1 (lag, speed etc affect this angleX) the FPSCamera will never obtain the max angle X.
So we need to calculate which angle is needed to obtain the limite when a rotation exceeds it.

This is an enhancement, but could you add yourself to the @author in the javadocs before I can merge this PR?

@author added. I've not tested it. But I think it's working :+1: !
If you want, I can test it tonight.

Wait what?? You think it's working?? I cannot merge it then, could you test it and confirm?

I know that you can't merge it. It was a merge request, so I think that we will speak about it together to see if it's a good thing or not :).

I've tested it, it WORK fine !
I've tested it with adding a Logger.info(angleX) into the rotateX function to see the current angleX after rotating.
We can see with my enhancement that angleX can take LIMIT_ANGLE and -LIMIT_ANGLE, with the current code of this function it can't.
I've tested it with "lag" (constant 3FPS and 20UPS during Mouse input), it work too.

Looks good enough. I'll merge this in.


Update subscribing-to-expert-insights.md

Added a period after report:  See an example of Expert Insights report.
Fixed typo under the first sentence in Managing Your Expert Services:
Description of the change:
Reason for the change:
Link to original source:

Closes #

Added a period in first paragraph and fixed and a typo under managing your report! ; )

Hello @negarzipan,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Add a guard to PR #934

#934
@jebeaudet

Thanks for heads up, let me know if you find anything related to it.

@qiangdavidliu Did you encounter any problem with it in the end? Thanks for the feedback


reset baseline copyConstraint from discussions at ashg unconference

@DanielPuthawala I just merged this because you and I talked and decided this was a good baseline start for the re-work of copyConstraint until you can sort out the feedback from the discussion that was recently opened.


Merge the archive node artifact job with the main build-artifact job

All of the binaries required for the archive node package are built as part of build-artifact anyway, this should reduce overall runtime / total cpu cycles

Results of this have not yet been fully tested, but the pipeline is all green with an implementation of this strategy in #9151

@lk86 Should this issue be closed, given that it was moved to Done?

@kaozenn Possible for you to confirm that this is indeed done? (And not by bothering @lk86 as I have done, but by checking the code, as I have not done.)


launch plan

rename this repo to something more descriptive
finish documentation
coordinate timing with waldo
map diff component
verbage about what this is and what state it's in, and about how we may use/deploy this in the future (help from waldo on this)

...and more! think this through & communicate with @ericrodenbeck and @iamjimstanley

From Slack:
Eric Socolofsky [1:11 PM]
Hi @waldo. @ericrodenbeck and I just had a conversation internally about how best to launch / promote this thing, and some concerns came up about context and content.
If you take off your been-part-of-the-project-the-whole-time shoes and visit http://openredist.org/, you get lost very quickly. The explanatory text in the intro modal is somewhat helpful, but may not go far enough on its own and once dismissed is gone forever. We can make it persist in some other way (/cc @alec), but we need to reconsider what it says in the context of openredist.org as a sandbox and as a provocation for opening the redistricting process. (This is a very different context than that of One Virginia 2021, which has a much more specific goal.)
Also, the content is all dummy content right now. Dummy content is fine for getting a point across, but it needs to be curated to help get that point across. Lorem ipsum doesn’t go far enough. We feel that this sandbox will function much better as a proof-of-concept with some dummy redistricting proposals, instead of just random maps, and need someone knowledgeable about the topic to generate the content.
@ericrodenbeck will (tentatively) be joining us on the call tomorrow to hash out these details so we can find the best deliverable for our goals. We can prelude the conversation on Slack, too, if you like.


feat: make schematics compatible with next Angular versions

What changes to angular schematics are coming in upcoming versions?

Hey, Angular schematics package has an API for working with workspaces and projects w/o accessing properties directly like that:
clientProject.architect!.build!.configurations

I haven't done any functional changes in this PR. I've only applied the Angular's way of dealing with workspaces and projects, it's mentioned here: https://angular.io/guide/schematics-for-libraries#get-the-project-configuration.
I moved all rules from the chain() function into rules folder since the index.ts file becomes messy and it's a bit complicated to read it

I should've actually renamed PR to fix: remove direct workspace access since it's not feat.


Update black rev in order to include fix for https://github.com/psf/black/issues/1629

I ran into this error related to https://github.com/psf/black/issues/1629.
In order to fix it, black needs to be updated at least to https://pypi.org/project/black/21.4b0.

The problem with changing black on active branches is that it creates some churn with PRs becoming red due to minor reformating. That said, black is getting more and more stable over time.
Alternatives:

using the # fmt: on/off/skip black directive to work around local issues
making the black version a copier question (with same defaults as today), so we can let PSCs manage their black version autonomously across branches

Ok, thanks for the explanation.
In the meantime I found the lines could make black fail and I fix them. So I can proceed without this.
Personally I'd prefer the following:

making the black version a copier question (with same defaults as today), so we can let PSCs manage their black version autonomously across branches


add a check for the return value of OPENSSL_strdup in app_rand.c:112

check the return value of OPENSSL_strdup(CRYPTO_strdup) in app_rand.c:112 to prevent potential memory access error.

This pull request is ready to merge

Merged to master and 3.0.  Thanks for this fix.


[Website] Improve reuqest library link

#195

OK!

@qas612820704 so we suppose to have another commit above the current existing two commits which only upgrade the lodash?

@PeterDaveHello , you mean I should split upgrade loadsh by an independent commit ?

@qas612820704 yes please

@PeterDaveHello , OK!

Awesome!


GlobalState is set to default on wasm startup

Using 4.6.1
using wasm, if you inject Global state such as:
@inject GlobalState Theme
and then
...
    protected override Task OnAfterRenderAsync(bool firstRender)
    {
        Console.WriteLine(Theme.Luminance);
        return base.OnAfterRenderAsync(firstRender);
    }
...

When the app first starts up, the Luminance is set to the default value instead of the stored local storage value.
Once i navigate to a page or component that contains the FluentDesignTheme component then the GlobalState contains the proper luminance value.
I would add FluentDesignTheme into the main layout so it auto-loads on startup, but other issues have directed to NOT put the FluentDesignTheme into the mainlayout.

and in the event that my usage above is incorrect; I am looking for the way i can programatically determine if i am in Light or Dark mode.

Luminanceneeds to have a default value. We set it to LightMode. We can only change it once JavaScript is available so in OnAfterRenderAsync
You can use the loading-theme webcomponent to read/work with it earlier. See https://www.fluentui-blazor.net/DesignTheme for more information

@vnbaaij it would seem like GlobalState should have a method that provides similar functionality to: https://github.com/microsoft/fluentui-blazor/blob/eea55eae82cb28d8b1e009bb80e62f6a2e68fb61/src/Core/Components/DesignSystemProvider/FluentDesignTheme.razor.cs#L196-L204  so we can get the state earlier.
This seems to be a gap: several issues state not to put the FluentDesignTheme into the main layout, but in order for the GlobalState to have an actual valid value we need FluentDesignTheme to be active.  But FluentDesignTheme is only used (currently) to edit the theme configs.
If a user never navigates to a page with FluentDesignTheme, how would the page ever detect programmatically that the theme is in Light vs dark mode?

We can't get the mode earlier. As you can see in line 196, we need JS to get the luminance.
As said in my previous comment, you can use the loading-theme web component. See https://www.fluentui-blazor.net/DesignTheme#how-to-remove-the-"bright-flash"-on-loading

How does having the loading theme in the index.html provide general component access to which luminance/isDark status?

It doesn't but together with the <fluent-design-theme> web component it can read from local storage and manipulate the Design Tokens before Blazor starts.

@StephenOTT

If a user never navigates to a page with FluentDesignTheme, how would the page ever detect programmatically that the theme is in Light vs dark mode?

You can also capture OnLoaded or OnLuminanceChanged events to be informed of theme changes.
<FluentDesignTheme<EMAIL_ADDRESS>                   OnLoaded="@(e => Console.WriteLine(e.Mode))"
                   OnLuminanceChanged="@(e => Console.WriteLine(e.Mode))" />

@dvoituron would this be done on any page where we need this info? Or you expect it to be configured at a mainlayout/app level and the info stored in a global singleton.

You'll find the explanation on this page:

You have the Blazor component FluentDesignTheme to manage the theme in Blazor
But you also have the web component fluent-design-theme that can be used before Blazor loads all the assemblies.

FluentDesignTheme
FluentDesignTheme is a Blazor component. It comes with an additional web component (fluent-design-theme) that can be used in HTML before Blazor has started and components are rendered. This avoids a "flash" of dark or white at page startup. Particularly so when using a WebAssembly project, which in general requires more time to download the assemblies needed to run the application.
Example in HTML
<fluent-design-theme mode="dark" primary-color="word" />
<fluent-design-theme mode="light" primary-color="#ff0000" />

Example in Blazor
<FluentDesignTheme Mode="DesignThemeModes.Dark" OfficeColor="OfficeColor.Word" />
<FluentDesignTheme Mode="DesignThemeModes.Light" CustomColor="#ff0000" />

Is it not possible for you to use OnLuminanceChanged to get the applied Mode? What is the problem about that?
Of course, this value will be received after the Blazor loading, but before that you don't have a simple way to have this info (except using JavaScript).
<FluentDesignTheme<EMAIL_ADDRESS>                   OnLoaded="@(e => Console.WriteLine(e.Mode))"
                   OnLuminanceChanged="@(e => Console.WriteLine(e.Mode))" />

@dvoituron Mode is System, Light and Dark.  Where System could mean Light or Dark.  One must use isDark to figure out the final condition.
When rendering how would you determine the difference between the default Luminance and the actual luminance?
GlobalState is already a state container holding this info.  But it would seem we then need to duplicate the usage of GlobalState to re-store the same information and then start tracking changes and loads.
If you had a overlay such as:
<FluentOverlay Visible="true" Opacity="0.5" Dismissable="false" FullScreen="true" BackgroundColor="@(()=> isDark == true ? "#someDarkColor" : "#someLightColor")">

The isDark custom method would not have to also implement on the page the FluentDesignTheme, a additional handler to luminanceChanged, a storage for updating this value and likely  a if statement around the overlay to not load the value until the isDark value has been set / equals not null.
If this is correct, is this not excessive work for a extremely common need to know globally at any time "Is the app in light or dark mode?"


product image is displayed smaller than the rest of the images (Safari)

1st product image is displayed smaller than the second, although both have the same pixel size (1500x1500px).
However, this only happens in Safari. If I upload images with Chrome, they are displayed correctly.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-39598
[created from NEXT-39598, comment 512606]


feat: add option to add slices for all values of a nominal column

Description
The slice popup changes if a user selects only a nominal column without entering anything else as follows:

After creation, slices will look as follows:

fix ZEN-214

should we add a three dot menu next to each histogram for this? And do we want to do this for the continuous histograms?

Something I thought about as well but was not sure how to do. Right now it's in the slice popup but I think I agree it might be better next to histograms. Don't know about continuous either. It's not really meaningful for continuous histograms is it?


Buffer overflow when loading blob as string

the length returned from OCI_StringBinaryToString includes a null byte, so currently on each loop for blob of the OCI_CDT_LOB case of OCI_StringGetFromType it writes 4097 bytes, starting from after the prior iteration's null, creating in effect n 4096-character strings and overrunning the buffer by n-1 bytes
issue for PR #87

Alice,
Thanks for reporting this bug :)
OCI_StringBinaryToString() should not include the null terminator in the string length.
But in the meanwhile it shall null terminate the string when it updates the output buffer.
That is an error within this internal method.
I will commit a fix for that asap.
Regards,
Vincent


[Macos] AppLifeCycleListener's onExitRequested is not handled correctly

Steps to reproduce
1- run the sample code
2- close the window that appears
3- the window will close and no dialog is displayed because of that
Expected results
The window should not close unless AppExitResponse.exit is returned from the callback
Actual results
The window will close before executing the code in the callback, note that the code in the callback is executed but after the window is closed which means any dialog you open in the callback will not be shown
Code sample
Code sample

import 'dart:ui';

import 'package:flutter/material.dart';

void main() {
  runApp(const LifeCycleApp());
}
class LifeCycleApp extends StatelessWidget {
  const LifeCycleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: LifeCycleTest(),
    );
  }
}

class LifeCycleTest extends StatefulWidget {
  const LifeCycleTest({super.key});

  @override
  State<LifeCycleTest> createState() => _LifeCycleTestState();
}

class _LifeCycleTestState extends State<LifeCycleTest> {
  late AppLifecycleListener listener;
  Future<AppExitResponse> _onExitRequested() async {
    final response = await showDialog<AppExitResponse>(
      context: context,
      barrierDismissible: false,
      builder: (context) => AlertDialog.adaptive(
        title: const Text('Are you sure you want to quit this app?'),
        content: const Text('All unsaved progress will be lost.'),
        actions: [
          TextButton(
            child: const Text('Cancel'),
            onPressed: () {
              Navigator.of(context).pop(AppExitResponse.cancel);
            },
          ),
          TextButton(
            child: const Text('Ok'),
            onPressed: () {
              Navigator.of(context).pop(AppExitResponse.exit);
            },
          ),
        ],
      ),
    );

    return response ?? AppExitResponse.exit;
  }

  @override
  void initState() {
    super.initState();
    listener = AppLifecycleListener(
      onExitRequested: _onExitRequested,
    );
  }

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Scaffold(
        body: Text("Testing"),
      ),
    );
  }
}

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.3, on macOS 13.4 22F66 darwin-arm64, locale en-IQ)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.1)
[✓] VS Code (version 1.81.1)
[✓] Connected device (2 available)
[✓] Network resources

• No issues found!

Reproducible using the code sample provided above.
This may not be a macOS-only issue but at the moment I am unable to test on other desktop platforms.
Labeling for further investigation.

flutter doctor -v
[!] Flutter (Channel stable, 3.13.3, on macOS 13.4.1 22F770820d darwin-arm64, locale en-GB)
    • Flutter version 3.13.3 on channel stable at /Users/nexus/dev/sdks/flutter
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter. Consider adding /Users/nexus/dev/sdks/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter. Consider adding /Users/nexus/dev/sdks/flutter/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (2 days ago), 2023-09-06 14:32:31 -0700
    • Engine revision b8d35810e9
    • Dart version 3.1.1
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.1)
    • IntelliJ at /Users/nexus/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 75.1.4
    • Dart plugin version 232.9559.10

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/232.8660.185/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.1)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/232.9559.62/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (3 available)
    • Pixel 7 (mobile) • 28291FDH2001SA • android-arm64  • Android 13 (API 33)
    • macOS (desktop)  • macos          • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
    • Chrome (web)     • chrome         • web-javascript • Google Chrome 116.0.5845.179

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 3.14.0-14.0.pre.169, on macOS 13.4.1 22F770820d darwin-arm64, locale en-GB)
    • Flutter version 3.14.0-14.0.pre.169 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fa1133586a (6 hours ago), 2023-09-08 00:08:32 -0400
    • Engine revision ea1d0d28e2
    • Dart version 3.2.0 (build 3.2.0-134.0.dev)
    • DevTools version 2.27.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/232.8660.185/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.1)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/232.9559.62/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (3 available)
    • Pixel 7 (mobile) • 28291FDH2001SA • android-arm64  • Android 13 (API 33)
    • macOS (desktop)  • macos          • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
    • Chrome (web)     • chrome         • web-javascript • Google Chrome 116.0.5845.179

[✓] Network resources
    • All expected network resources are available.

• No issues found!

someone on the discord channel tested the code in windows and it works fine, I do suspect that it is a Macos only. It might be due to how Macos handles the closing of windows differently, which is why in electronjs apps the closing is handled differently on macos
// Quit when all windows are closed.
app.on('window-all-closed', () => {
  // On macOS it is common for applications and their menu bar
  // to stay active until the user quits explicitly with Cmd + Q
  if (process.platform !== 'darwin') {
    app.quit()
  }
})

+1

I know this issue is for MacOS, but FWIW, the sample "cancelable exit" app isn't working for me on Android (tried 14 &  8.1).  The app always exits with the Back button, and NEVER exits using the Quit button in the app. Flutter 3.16.5


Refs #4971 Fix #457. Added Blackbox for it and modified SimpleCommuni… [5205]

…cation to ease testing.
Fix #457

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows


@continue blade directive has no highlight

@foreach($tests as $test)
  @continue(!$items->count() ? true : false)
@endforeach

Hi,
Thank you for your observation.
A issue linked with directives which can also be without arguments.
@break also had this issue.
Should be fixed with the latest prerelease <IP_ADDRESS> -  https://github.com/haidubogdan/netbeans-php-blade-plugin/releases/tag/prenbpr1.0.9

Another question, it is something minimal, if it complicates everything it would be better to ignore it,
On custom directives, if you click/select an opening directive, closing directive gets highlighted

But if you click/select a closing directive, opening directive does nothing

In large blocks it's difficult to find the opening directive from closing directive


Suggestion: schedule navigator

Right now you have the events listed on the left and the schedule when you go to the competition's main page.
It would be cool if we could toggle between event list (in WCA order) or round list according to schedule. That way it would be easier to navigate, without having to go back to main page every time or opening a new tab each time you click an event.

While I see the point, I think adding such option is a bit of an overkill, I'd rather not clobber the UI with options that are not that useful, to make it more intuitive for external visitors. Also the functionality itself is implemented by the schedule view and I think that's where it should be. If many people strongly support it, we may consider that, but for now I don't really feel it's valuable enough.


Bipartite Graph

Related Issue
#188
Proposed Changes
-Added short description about problem statement
-Added code, related input-output
Checklist

[X] ✅ My code follows the code style of this project.
[X] 📝 My change requires a change to the documentation.
[X] 🎀 I have updated the documentation accordingly.
[X] 👀 I have read the CONTRIBUTING document.
[X] ✨ I have added tests to cover my changes.
[X] 🚩 All new and existing tests passed.
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] 🌟 ed the repo

Solution of issue #188
Added brief description about the bipartite graph and explained a code using BFS algorithm
Here I used 2 inputs for the 1st one I show that the graph is bipartite and 2nd input graph is not bipartite
APPROACH::
It is possible to test whether a graph is bipartite or not using a BFS Algorithm
There are 2 ways to check for a bipartite graph:
1. A graph is a bipartite graph if and only if it is colorable by 2 colors only.
While doing BFS traversal m the given Graph, each node in the BFS tree is given its parent’s opposite color. If there exists an edge connecting the current vertex to a previously colored vertex with the same color, then we can say that the graph is not bipartite.
2. A graph is a bipartite graph if and only if it  contains an odd cycle(Cycle contains  Odd number of vertices)
If a graph contains an odd, we cannot divide the graph such that every adjacent vertex has a different color.  If in the BFS, we find an edge, if both of its endpoints are at the same level, then the graph is not Bipartite and an odd-cycle is found.
Here in the explanation, we use the 1st approach of the BFS algorithm to check whether a given graph I bipartite or not.

Output Screenshots
| INPUT-1

| INPUT-2   |

@miraj0507  please check it...it was already reviewd but I deleted PR by mastake ..I had messaged you on discord about it ..please check it .

@Lakhankumawat  what should I have to  change here ?

I can see you have committed 3 files ! Also you added code in cpp file, you don't need it in readme. Follow proper structure of Readme

Ok I will update

How to solve it? @siddhi-244

@siddhi-244  , updated please check

Check the tasks which are completed by you !

Check the tasks which are completed by you !

@siddhi-244 , done please check

@Lakhankumawat , updated

@all-contributors please add @Mrjoy832 ,

@all-contributors please add @Mrjoy832 code ,


How does this differ from zzstructure(hyperthogonal structure)?

Hyperthogonality is a new idea to me, and very cool. It's like a graph plus a local concept of space. Each cell can have up to four neighbors (up, down, left and right), with the constraint that if A is above B, then B must be below A, and if A is left of B, then B must be right of A.
When you use a tree to organize your data, too, there's an implicit notion of space: The directions up (toward the root), down (toward the leaves), and the two other directions (across siblings). It is up to the user to decide what those directions mean. Hyperthogonal data seems to offer a similar experience: Now your data is free to be cyclic, but still it is up to the user to decide what each direction means, and there are only so many directions to use.
In DWT, relationships are semantic, not spatial. If you want to record the fact that Barney is purple, you would enter "Barney #is purple". That would create (if they are not already present) expressions representing "Barney", "purple", the relationship template "_ is _", and the relationship "Barney #is purple".
The number of kinds of relationships that Barney can be involved in has no limit: "Barney #needs food", "Barney #(appears on) television", "Barney #was popular #in the early 2000s" (notice that that's a relationship with three members), "(Barney #is funny) #because (Barney #makes weird noises)" (that's a relationship between two relationships) ...
Given that expression and others, you can then ask for all the things that are purple ("/it #is purple"), or all the things Barney is ("Barney #is /it"), or every consequence of Barney being purple ("/it #because (Barney #is purple)") ...
DWT offers a flexible representation of information (the RSLT) and a language for querying that information (Hash). The representation and querying are separate concerns from how the data is displayed. Currently, query results are a simple list, but spatial display is on the to-do list -- both hierarchical (tree-like) and tabular displays.

I've closed this issue but added it to the FAQ. If you're still not satisfied, please, feel free to ask more questions.

Thanks!
Also, I have two new questions, how does RSLT compare to:

Ultragraphs
Ubergraphs

See this presentation deck for (vague, but pretty) details on both, specifically PDF pages 9 to 13:
http://www.storageconference.us/2018/Presentations/BigData-tutorial-1.pdf
This paper for (minimal) details on Ultragraphs, specifically PDF pages 5 to 6:
https://avesterra.georgetown.edu/sites/avesterra/files/avesterra_formalization.pdf
And this paper for details on (Undirected) Ubergraphs, which claims that Ubergraphs directly generalize Hypergraphs, neglecting to mention the (admittedly rather trivial) intermediate step of Ultragraphs:
https://arxiv.org/abs/1704.05547

Thanks!
Ubergraphs and RSLTs look like they're the same thing.
The authors of the Ubergraph paper have attached a lot of math to the data
structure, which I don't immediately see a reason to be interested in --
what I care about is representing and querying knowledge. I think they
might not be, because they don't talk about labeling the relationships. In
the RSLT the templates are the relationship labels. Labels are critical --
otherwise the relationship "lion <-> gazelle" could be "lion dreams of
gazelle" or "lion assembles dollhouse after gazelle shimmies down a
halfpipe" or anything. Linear text with a hole corresponding to each member
seems like the most natural way to label a relationship: "_ uses _ to _",
or "not ", or " is a _".
They also talk about how an Ubergraph is better than an Ultragraph because
Ubergraphs give you recursive relationshipss. I see no natural
representation of an Ultragraph that is not an Ubergraph. The RSLT, for
instance, I designed with only the intention of n-ary nested relationships,
and it gave me recursion for free. I think it's the simplest possible
implementation. In it relationships, relationship templates, and atoms are
all elements of the same set ("nodes"), and the fields of a relationship
are nodes. A relationship has nodes, and a relationship is a node,
therefore recursion is possible.
It's a good thing, because recursion is a property of the universe. "Is a
relationship," for instance, is a relationship that applies to all
relationships, including those (unary) relationships in which it is applied
to other relationships.
The AvesTerra idea seems to involve them picking a few kinds of metadata
they think are important (precision of measurement, for example) and
elevating them above other possible kinds of meta-information (such as
authors who disagree). It's certainly possible you would want to represent
some metadata differently from others. The time at which a relationship was
created, for instance, might be so ubiquitous that you would prefer to add
a Timestamp field to your relationships, rather than use three objects to
represent "X was created at time T". But that's an implementation detail
that the backend programmer should hide, I believe, from the frontend user.
I prefer the RSLT (or, if indeed it's equivalent, the Ubergraph), which
presents a uniform and simpler interface to the user, while allowing for
the possibility of complicating it behind the scenes.
On Mon, Aug 27, 2018 at 6:01 AM no_identd<EMAIL_ADDRESS>wrote:

Thanks!
Also, I have two new questions, how does RSLT compare to:

Ultragraphs
Ubergraphs

See this presentation deck for (vague, but pretty) details on both,
specifically PDF pages 9 to 13:
http://www.storageconference.us/2018/Presentations/BigData-tutorial-1.pdf
This paper for (minimal) details on Ultragraphs, specifically PDF pages 5
to 6:
https://avesterra.georgetown.edu/sites/avesterra/files/avesterra_formalization.pdf
And this paper for details on (Undirected) Ubergraphs, which claims that
Ubergraphs directly generalize Hypergraphs, neglecting to mention the
(admittedly rather trivial) intermediate step of Ultragraphs:
https://arxiv.org/abs/1704.05547
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/JeffreyBenjaminBrown/digraphs-with-text/issues/11#issuecomment-416191048,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIfQT24PHM4ID5noCIWM2kfmzDwuuAFQks5uU9F1gaJpZM4QcScf
.

--
Jeff Brown | Jeffrey Benjamin Brown
Website https://msu.edu/~brown202/   |   Facebook
https://www.facebook.com/mejeff.younotjeff   |   LinkedIn
https://www.linkedin.com/in/jeffreybenjaminbrown(spammy, so I often miss
messages here)   |   Github https://github.com/jeffreybenjaminbrown

HypergraphDB, if I recall correctly (I read about it sometime this year),
also seems to offer the same representative capabilities as the RSLT. It
might be a big community. (Hash still hasn't caught on anywhere, to my
knowledge.)
Also Grakn might do it? That was at least my sense from something I read of
theirs.
Sorry, it's been a while. I do expect to get back to this stuff eventually
...
On Wed, Sep 5, 2018 at 12:02 AM Jeffrey Brown<EMAIL_ADDRESS>wrote:

Thanks!
Ubergraphs and RSLTs look like they're the same thing.
The authors of the Ubergraph paper have attached a lot of math to the data
structure, which I don't immediately see a reason to be interested in --
what I care about is representing and querying knowledge. I think they
might not be, because they don't talk about labeling the relationships. In
the RSLT the templates are the relationship labels. Labels are critical --
otherwise the relationship "lion <-> gazelle" could be "lion dreams of
gazelle" or "lion assembles dollhouse after gazelle shimmies down a
halfpipe" or anything. Linear text with a hole corresponding to each member
seems like the most natural way to label a relationship: "_ uses _ to _",
or "not ", or " is a _".
They also talk about how an Ubergraph is better than an Ultragraph because
Ubergraphs give you recursive relationshipss. I see no natural
representation of an Ultragraph that is not an Ubergraph. The RSLT, for
instance, I designed with only the intention of n-ary nested relationships,
and it gave me recursion for free. I think it's the simplest possible
implementation. In it relationships, relationship templates, and atoms are
all elements of the same set ("nodes"), and the fields of a relationship
are nodes. A relationship has nodes, and a relationship is a node,
therefore recursion is possible.
It's a good thing, because recursion is a property of the universe. "Is a
relationship," for instance, is a relationship that applies to all
relationships, including those (unary) relationships in which it is applied
to other relationships.
The AvesTerra idea seems to involve them picking a few kinds of metadata
they think are important (precision of measurement, for example) and
elevating them above other possible kinds of meta-information (such as
authors who disagree). It's certainly possible you would want to represent
some metadata differently from others. The time at which a relationship was
created, for instance, might be so ubiquitous that you would prefer to add
a Timestamp field to your relationships, rather than use three objects to
represent "X was created at time T". But that's an implementation detail
that the backend programmer should hide, I believe, from the frontend user.
I prefer the RSLT (or, if indeed it's equivalent, the Ubergraph), which
presents a uniform and simpler interface to the user, while allowing for
the possibility of complicating it behind the scenes.
On Mon, Aug 27, 2018 at 6:01 AM no_identd<EMAIL_ADDRESS>wrote:

Thanks!
Also, I have two new questions, how does RSLT compare to:

Ultragraphs
Ubergraphs

See this presentation deck for (vague, but pretty) details on both,
specifically PDF pages 9 to 13:
http://www.storageconference.us/2018/Presentations/BigData-tutorial-1.pdf
This paper for (minimal) details on Ultragraphs, specifically PDF pages 5
to 6:
https://avesterra.georgetown.edu/sites/avesterra/files/avesterra_formalization.pdf
And this paper for details on (Undirected) Ubergraphs, which claims that
Ubergraphs directly generalize Hypergraphs, neglecting to mention the
(admittedly rather trivial) intermediate step of Ultragraphs:
https://arxiv.org/abs/1704.05547
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/JeffreyBenjaminBrown/digraphs-with-text/issues/11#issuecomment-416191048,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIfQT24PHM4ID5noCIWM2kfmzDwuuAFQks5uU9F1gaJpZM4QcScf
.

--
Jeff Brown | Jeffrey Benjamin Brown
Website https://msu.edu/~brown202/   |   Facebook
https://www.facebook.com/mejeff.younotjeff   |   LinkedIn
https://www.linkedin.com/in/jeffreybenjaminbrown(spammy, so I often
miss messages here)   |   Github https://github.com/jeffreybenjaminbrown

--
Jeff Brown | Jeffrey Benjamin Brown
Website https://msu.edu/~brown202/   |   Facebook
https://www.facebook.com/mejeff.younotjeff   |   LinkedIn
https://www.linkedin.com/in/jeffreybenjaminbrown(spammy, so I often miss
messages here)   |   Github https://github.com/jeffreybenjaminbrown


Github Action

Thanks a lot for the work done by this community, It saved me a lot of time.
To be able to integrate it with a new project, I've created a github action which uses the docker image already created by @ferrarimarco. I thought that this could be useful for someone else.
It can be found here: https://github.com/marketplace/actions/automatic-changelog-generator
I'm quite new to Github Actions, so there might be some thing which can be done better.
It's currently used by a new project which can be found here https://github.com/OpenSentry
You're more than welcome to add this to the "Projects using this library" list.

Thanks. It's a good idea to add it as Action.
I'm also new with actions and didn't have time to figure out, how to work with it. Let's have a look. If you have an idea, how to set up it in repo or make a quick readme addition based on your experience, how to setup it in your repo - I would be happy to merge it!
btw, you can add your project, since it's a wiki page and everyone can edit it: https://github.com/github-changelog-generator/github-changelog-generator/wiki/Projects-using-Github-Changelog-Generator

I see your action, but don't see any kind of code or instrucrtions how to setup it:
https://github.com/OpenSentry/idp/actions?query=workflow%3AChangelog
It would be cool, if you can add this instruction for other users. But it's definetly cool thing to automate!

@CharMixer
You're right. I mean that we can add it as an example to this repo. So people can copy-paste it to their own. It would be nice to make the readme section about this too.
Or let me know if you will be done this with your repo. So I will make the same in this repo.


Add a link to a post on how to use F# with Azure functions

Add a link to a post on how to use F# with Azure Functions
Summary
This PR adds a link to an in depth blog post which covers the details of developing pre compiled functions with F# whilst also using the Azure Storage Type Provider
Details
As above, this PR simply links to a blog post covering how to use Azure Functions with F#

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


[RFC] OpenXLA PJRT plugin

Request for comment OpenXLA PJRT plugin along with creation of new repo for its development.

Thanks for the writeup, Jacques!

nice to have windows support. Some products need Windows implementation. I had mentioned a few times that Windows availability would make OpenXLA more attractive.

nice to have windows support. Some products need Windows implementation. I had mentioned a few times that Windows availability would make OpenXLA more attractive.

I looked at this, and the plugin infra itself looks like it needs a bit of work for Windows compatibility still. But the plugin implementation is tested and deployed on Windows currently. So this doesn't seem too far to expect from were I see.

What is the process here? Create an issue?

What is the process here? Create an issue?

Process for this RFC or requesting windows support for the implementation generally? For the latter, I would create a dedicated issue for platform policy overall (vs asking component by component).

Related: https://github.com/google/jax/issues/438
I don't see any reason why the plugin infra and the openxla plugin can't support Windows.

For the latter, I would create a dedicated issue for platform policy overall (vs asking component by component).
Which repository? JAX or  ???

For the latter, I would create a dedicated issue for platform policy overall (vs asking component by component).

Which repository? JAX or ???

https://github.com/openxla/community/issues/34

Something I would like to see is something about how a plugin is tested.
Having a reference test suite that checks a PJRT implementation is "correct" would be very useful.

I would like to see is something about how a plugin is tested.
Having a reference test suite that checks a PJRT implementation is "correct" would be very useful.

Agreed. Ime, the Jax test suite is a useful component of this, but it doesn't have sufficient coverage for more integration-heavy tests (ie. Multi device, exotic compilation modes, out of the ordinary data transfer scenarios). Probably makes sense to have an additional layer of testing, and then we call some union of test suites an interim CTS and work on unifying it in a next phase.

It is likely not required for the plugin to compile any PJRT_Program

Would it be possible to comunicate with the plugin to understand if an input program could be compiled (or is it supported) without failing (fast) at "runtime" on compilation?
I asking about this with the scope of have a complete overview, or at least a preliminary check, of the PJRT plugin coverage over a specific program.
I don't know if it make sense at this level but it was something that I've expected at the current framework bridge level and still don't have it. So I don't know if the topic is still valid at this lower level with PJRT programs or not.

It is likely not required for the plugin to compile any PJRT_Program

Would it be possible to comunicate with the plugin to understand if an input program could be compiled (or is it supported) without failing (fast) at "runtime" on compilation?

That is a good suggestion. Ability to flag compatibility for a given plugin instance [there are potentially conservative and aggressive options too - e.g., an unsupported op that could be optimized away after a few rounds of optimizations]. We should keep that in mind for the compile API discussion.

PJRT_Program is the input for PJRT compile, provide by the ML framework. Currently it be either serialized HloModuleProto/HloModuleProtoWithConfig or MLIR module.

Ultimately is seems that it should be a StableHLO module in the OpenXLA architecture?

It is likely not required for the plugin to compile any PJRT_Program. It is still evolving in terms of how we want to design the compile API. @skye

This ties pretty well with a discussion this morning in the open meeting: someone asked about dynamic shape support and how some platforms won't be able to support it. So as @jpienaar mentions above, we need to have this in mind when designing the APIs: "program capabilities" or "features" that aren't uniformly supported. There is a range of possibilities in the API design to express this...

@jpienaar Yes exactly these arguments are all related to what I meant.
I hope we could have a specific ticket/discussion in the new repo.

PJRT_Program is the input for PJRT compile, provide by the ML framework. Currently it be either serialized HloModuleProto/HloModuleProtoWithConfig or MLIR module.

Ultimately is seems that it should be a StableHLO module in the OpenXLA architecture?

+1, PJRT is not OpenXLA/XLA specific but within the context of OpenXLA this is the supported input format.

Agreed. Ime, the Jax test suite is a useful component of this, but it doesn't have sufficient coverage for more integration-heavy tests (ie. Multi device, exotic compilation modes, out of the ordinary data transfer scenarios).

Yes, I think having some of those tests would be good. A problem I've had with using the ML Frameworks tests for the IPU PJRT implementation is it's unclear what the "canonical" set of tests is. There are a lot of exceptions and exclusions for CPU, TPU, and GPU.

what will happen when an unsupported op that could be optimized away?
Does the op means the op supported by framework?
Does an unsupported op that could be optimized away means the program will return error more early with the op info?

It is likely not required for the plugin to compile any PJRT_Program

Would it be possible to comunicate with the plugin to understand if an input program could be compiled (or is it supported) without failing (fast) at "runtime" on compilation?

That is a good suggestion. Ability to flag compatibility for a given plugin instance [there are potentially conservative and aggressive options too - e.g., an unsupported op that could be optimized away after a few rounds of optimizations]. We should keep that in mind for the compile API discussion.

If the op means the op supported by framework, would an unsupported op that could be optimized away might means the PJRT plugin will return error more early with the op info?

We are going into the compiler API design and query functionality a bit, which is a separate discussion that needs to happen still. We can have multiple layers and expensiveness of tests. So the most simple one could be purely on op names, more advanced/expensive checks the attributes, more check the types too, then checking usage within a context (e.g., can I elide asserts?), then trying to run some initial optimizations to see. As a straw man one could add yes, no, maybe results for query "is supported model" and the cost of the query or amount of effort to try can be configured additionally - and trying to do a couple of optimizations would be on the expensive path. The more information the backend could provide the earlier and easier. For backends that are complete (which is a much more tractable target for HLOs!) one might not need to dig in too deep to get a result (exception is ops like scatter which are not a simpler ops). But there may be value in being able to give a very quick response even if conservative for some use cases, while in others conservative isn't useful. Larger discussion :) (I've seen multiple different attempts here and this will be design question in the compiler API work).

It will be super useful also for CI jobs or other development activities if for an early check you will not need to retrieve/run the verification on the device specific resources.
I still hope that this layer could not fail fast.
It would be useful to open feature request tickets/issues on the specific compiler.
Then honestly we need something similar Framework bridges on failures generating StableHLO programs but this is another story.
Also I don't know if we could have some complications with custom calls.

*   Registration of multiple PJRT plugins.

This a braindump of things to consider will keep adding :

Versioning/variants ( e.g. x86, x86-64 and ARM CPUs, different CUDA compute capability GPUs, DPUs..etc),
How does a device broadcast its capability/supported API calls? Not sure the balance is here between going full VM contract vs. "DEVICE_VARIANT_VERSION" naming.
"Hot-swap/plug" PjRT plugins (i.e. in the runtime being able to unload and reload.)
Single vs Multi-process access/ ownership (maybe covered by IRFT)
Command queues/ buffer management APIs access, simple commands vs. transactional.

cc: @nouiz @stellaraccident

Offloading on the device API level, especially on Grace-Hopper+ (Page 19 - Figure 9) systems, which has a core design issue (CPU and GPU viewed as a single device?, hierarchical caching?)

Offloading on the device API level, especially on Grace-Hopper+ (Page 19 - Figure 9) systems, which has a core design issue (CPU and GPU viewed as a single device?, hierarchical caching?)

I'm having trouble tracking the exact use case that is promoting the question (and can imagine different directions). Could you elaborate?

For those watching from the sides, could someone point to a public
documentation on what is PjRT ? Thanks!
On Wed, Feb 1, 2023 at 5:49 PM Frédéric Bastien @.***>
wrote:

@.**** commented on this pull request.
In rfcs/20230123-pjrt-plugin.md
https://github.com/openxla/community/pull/33#discussion_r1093484220:

+*   Call load_pjrt_plugins when

initializing backends.
+*   Call get_loaded_plugin_names to get loaded PJRT
plugin_name, have some framework specific logics to decide whether to call
create_pjrt_client to create the PJRT client.

+```python
+def create_pjrt_clients():

loaded_plugin_names = get_loaded_plugin_names()
for plugin_name in loaded_plugin_names:

Framework specific logics to decide whether to create

if should_create_pjrt_client(plugin_name):

 pjrt_client = create_pjrt_client(plugin_name)

+```
+
+For TensorFlow, discovery will be added to
That sound good. Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/openxla/community/pull/33#discussion_r1093484220, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABY5KE36KPNORGZFEFODVL3WVKH2DANCNFSM6AAAAAAUES333A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Jan Pfeifer
Research Engineer
Google Switzerland GmbH
@ : @.***
@ : @.***
T : +41 79 907 3855

For those watching from the sides, could someone point to a public documentation on what is PjRT ? Thanks!

Also what is the extended version of this acronym?
https://github.com/google/jax/discussions/11439#discussioncomment-3120985

For those watching from the sides, could someone point to a public documentation on what is PjRT ? Thanks!

I don't have a pointer to a documentation immediately, but think of PJRT right now as the public API for setting up XLA (other than building the input graph).
See this basic example: https://github.com/openxla/xla/blob/main/xla/examples/axpy/stablehlo_compile_test.cc#L60-L79
The PjRtStreamExecutorDevice  and PjRtStreamExecutorClient classes are defined in https://github.com/openxla/xla/blob/main/xla/pjrt/pjrt_stream_executor_client.h and are just some specific implementations of PjRtDevice and PjRtClient.
These abstract base class are really good references I think to figure out what is the PJRT api right now. See this long description for PjRtClient:  https://github.com/openxla/xla/blob/main/xla/pjrt/pjrt_client.h#L339-L386

Also what is the extended version of this acronym?

d8c85bc19e29fdff0aa3d03065cdf79cef6c0fb9: PjRt stands for "pretty much just another runtime".

For those watching from the sides, could someone point to a public documentation on what is PjRT ? Thanks!

I think the best on these are those listed at the bottom of the RFC and the headers here, let us know if too low level. As mentioned in intro PJRT is a device API that will provide an easy interface with which frameworks can integrate a packaged compiler and runtime solution.

Also what is the extended version of this acronym?
google/jax#11439 (comment)

From the header: 'PjRt stands for "Pretty much Just another RunTime"' (this makes a lot more sense if one considers the originally JAX expansion).

PJRT_Program is the input for PJRT compile, provide by the ML framework. Currently it be either serialized HloModuleProto/HloModuleProtoWithConfig or MLIR module.

It is important to support versioning of the program representation so that the plugin can check before processing the program.  Do you consider versioning and what is the runtime behavior if the version doesn't exactly match?

PJRT_Program is the input for PJRT compile, provide by the ML framework. Currently it be either serialized HloModuleProto/HloModuleProtoWithConfig or MLIR module.

It is important to support versioning of the program representation so that the plugin can check before processing the program. Do you consider versioning and what is the runtime behavior if the version doesn't exactly match?

We are driving this towards StableHLO which is developing version constraints as part of its design. New implementations should use that.
@burmako

I'm having trouble tracking the exact use case promoting the question (and can imagine different directions). Could you elaborate?

I'm sorry for the vague statement; I'm trying to jot down the key points so I can remember to bring them up when there is a higher bandwidth format.
A small write-up for 7 is:
For Grace Hopper + based systems, the NVL bandwidth is much higher than PCIe, opening the door for profitable offloading of tensors to the HBM. The next version of the runtime API would need to consider the programming model for such hybrid systems while tackling the traditional Host <-> GPU typical design. One example is if one is doing a "one layer at a time" style of computation for a massive model with a limited set of GPUs (model_size> All GPU memories)
Current frameworks (e.g. JAX) don't have an ergonomic path for this hybrid memory model; assuming they do, it will likely need an abstraction at the runtime level too.

*   Registration of multiple PJRT plugins.

This a braindump of things to consider will keep adding :

Versioning/variants ( e.g. x86, x86-64 and ARM CPUs, different CUDA compute capability GPUs, DPUs..etc),
How does a device broadcast its capability/supported API calls? Not sure the balance is here between going full VM contract vs. "DEVICE_VARIANT_VERSION" naming.
"Hot-swap/plug" PjRT plugins (i.e. in the runtime being able to unload and reload.)
Single vs Multi-process access/ ownership (maybe covered by IRFT)
Command queues/ buffer management APIs access, simple commands vs. transactional.

cc: @nouiz @stellaraccident

Added a section to capture it.

@jyingl3 Can you catch me up on comm channels for this work? I just got a basic CI going and found that there was some API drift around Executables/LoadedExecutables that I am adapting to. As you know, it is basically impossible to keep up with the noise in the TF repo, and without seeing the dev process, this isn't a great experience for collaborators.
@theadactyl Any objection to using the IREE #pjrt-plugin channel for now to coordinate on API updates and such? Open to other options.

Can one of the PJRT owners please advise on where to file bugs and how to reach the engineers. I have filed this one: https://github.com/openxla/xla/issues/1237 but the engineers who work on this do not appear to be members of the repo.
Thanks.

(ftr - I work at Google and could have pinged them privately but am trying to flush out how to actually interact with our OSS projects without such privileged access)

https://github.com/openxla/xla/issues/448

@jyingl3 Can you catch me up on comm channels for this work? I just got a basic CI going and found that there was some API drift around Executables/LoadedExecutables that I am adapting to. As you know, it is basically impossible to keep up with the noise in the TF repo, and without seeing the dev process, this isn't a great experience for collaborators.

Thanks for checking! We have finalized the communication channel:

Please file issues in the OpenXla/xla repo (https://github.com/openxla/xla).
Join discussion in the #pjrt-plugin channel of the IREE discord server (https://github.com/openxla/iree/#communication-channels).

We also just added a README to https://github.com/openxla/xla/tree/main/xla/pjrt/c about the communication channel and some resources.
@skye


Support nearcore 2.3.0

We need to support non-200 RPC error codes
More details:
https://github.com/near/nearcore/blob/master/chain/jsonrpc/CHANGELOG.md#230

Solution in PR https://github.com/near/near-api-js/pull/1404


Better queryFormat function

Thank you, but this is just an example made to be simple to understand. The idea is that users can write whatever they like for their use case :+1:


build(gomod): Bump KraftCloud SDK to v0.3.0

Description of your changes

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Thanks


Allow kani to return EXIT_SUCCESS for empty proof harnesses

Feature: Treat empty harnesses as successes rather than failures, either by default or through a flag. This is helpful to make generic CI checkers that automatically pick up proofs when they exist for a project and ignore them when they don't. As an example, consider that cargo test does not fail on an empty harness.
Current behaviour: kani unconditionally errors out if there's no proof harness.
alexgv@mypc:~$ cargo new mwe
     Created binary (application) `mwe` package
alexgv@mypc:~$ cd mwe && cargo kani || echo NONZERO_EXIT
   Compiling mwe v0.1.0 (/home/alexgv/mwe)
    Finished dev [unoptimized + debuginfo] target(s) in 0.09s
Error: No proof harnesses (functions with #[kani::proof]) were found to verify.
NONZERO_EXIT

That seems reasonable to me. I don't think the current behavior was carefully considered.
Anyone object?

That also seems reasonable to me.


Initial import of libiberty tests

This imports the libiberty tests, generates Rust #[test]s from them, and runs them behind the libiberty_compat feature.
The tests aren't passing yet, hence the (default off) feature.

Coverage increased (+0.002%) to 94.998% when pulling 9e75c279e5b401799be2606d215a65e92b9c1a19 on libiberty-test-compat into c77592a2df71f813d5f4bb15e8c5b710f187759f on master.


Remove unnecessary state on AbstractHttp2StreamChannel

Motivation:
The firstFrameWritten state on AbstractHttp2StreamChannel exists to
make sure the channel doesn't transition the stream state from Idle to
another state by any other frame than a Headers frame, as required by
the spec. We already have that state in the stream() through the
id() method, which is typically checked at the same time anyway.
Modifications:
Drop the firstFrameWritten field in favor of examining the stream
state.
Result:
Less state to consider in AbstractHttp2StreamChannel.

Note that this is just an attempt to cleanup the state in the stream which is pretty gnarly, and I'm not passionate about it so if there is suspicion this isn't right let's dump it.


Fix typo under Miscellaneous/TODO comments...

Hello,
Thanks for publishing this helpful document. I spotted a typo where the word "know" had been omitted under the Miscellaneous/TODO Comments... section.

Thank you!


what is the return of the euclidean cluster?

Fill-out only one section depending on whether you are reporting a bug or a new feature.
/home/henry/Pictures/Screenshot from 2017-11-14 18:44:11.png
Bug
Expected Behavior
Actual Behavior
Steps to Reproduce the Problem

Specifications

Ubuntu version:
ROS Version:
Autoware branch:

New Feature
Describe where does new feature request come from. Add high-level picture of how the new feature should work.

@brainhenry please provide more details? which code/launch file are you running? What return value are you interested in?
I will for now close the issue. Please re-open once you provided more details.


Fabr1ce patch 1

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

0 out of 2 committers have signed the CLA.

[ ] Fabrice Eureka
[ ] Fabr1ce

Fabrice Eureka seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


Add Space Deno artwork

Hello!
I add a new deno artwork called Space deno 🐱🐉.

I hope u enjoy :D

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Done!

Thanks!


cannot run tests on windows

yarn test v0.27.5
$ npm run lint && BABEL_ENV=test ava

><EMAIL_ADDRESS>lint E:\Documents\marked3
> xo src/*.js

'BABEL_ENV' is not recognized as an internal or external command,
operable program or batch file.
error Command failed with exit code 1.

ah yeah I'll fix it soon.

Done: 26a6c2634acd8bb1c0d0890e43e73e466b4e96b7


[BUG]: Extra escape button in settings for pause menu

Description of the bug
There is an extra escape button in the setting page of the pause menu (top left). When clicked, it does not do anything in game.
Image of bug:

Steps To Reproduce

Start game in any official scene (Tutorial, In-Game/Living Room, Kitchen)
Pause the game to bring up the pause menu
Click on the "settings" option
At the top left, you will see another escape button, which does not do anything when clicked
Top right escape button will close settings menu

Additional Information
Possible fix:
Remove the unnecessary button from the settings prefab.

#57 was merged


[network] az network application-gateway http-listener create Update help message for --frontend-port argument

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature
Summary
This Pull Request updates the help message for the --frontend-port option in the az network application-gateway http-listener create command. The previous message, "Name or ID of the frontend port.", led to some confusion as it could be interpreted as asking for the port number or a TCP name. There have been issues raised due to this misunderstanding.
ref. Command "az network application-gateway http-listener create" does not work. #16567
Changes
The help message for --frontend-port has been clarified to explicitly state that it is not asking for the port number. The new message is: "This is NOT for the port number. Please input the Resource Name or ID of the frontend port, which can be found using 'az network application-gateway frontend-port list'."
Impact
This change will help users understand what is expected for the --frontend-port option and prevent future misunderstandings. 😄

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

network

Yes, but these files are generated. Means it cannot be modified directly, unless it'll be overwritten by the next generation.
You can leverage such codegen tool https://github.com/Azure/aaz-dev-tools to apply the above changes. :)

Thank you for your message! I appreciate your guidance. I’ll give it a try and apply the changes using the Azure/aaz-dev-tools codegen tool. 😊


mdbook css theme flashing on reload

https://github.com/axodotdev/oranda/assets/17577332/eb7dba52-56d8-40e2-83dd-d7ed66781328

Looks like this was related with embedding gist inside the webpage. Fixed it by removing the gists.


Dragging drawings across the date line does not move them to the target "world"

Leaflet version I'm using: 0.7.2
Leaflet Draw version I'm using: 0.4.9
Browser (with version) I'm using: Chrome 60
OS/Platform (with version) I'm using: Ubuntu 14.04

A user makes a drawing (for example, a polygon) and drags it across the date line in the Pacific:

As soon as they release the mouse, the drawing seems to vanish off the map. In fact it simply stays in the Leaflet "world" it came from, instead of moving to the new one that the user dragged it to. It remains in the right location, but in the wrong copy of the world and probably way outside the viewing area.
I tried worldCopyJump and other possible solutions from here:
https://github.com/Leaflet/Leaflet/issues/2333
Unfortunately, nothing helps.

Do you want the rectangle to not be able to cross the dateline, or do you just want the rectangle to be able to seemlessly cross the dateline when dragged?
And can you provide a jsfiddle or some such?

Ah, I see there's a fiddle on the link you posted. So, I think this is a leaflet problem... using the fiddle there:
http://jsfiddle.net/u90L0oLq/
If I add a rectangle like so:
var r = new L.Rectangle([[-29.5, 143], [35.5, (180-119)+180]]).addTo(map)
And I pan towards Australia, the rectangle shows up correctly. However, if I pan towards California, the rectangle disappears. That doesn't seem right.

Looks like this issue with Leaflet is both well known and highly controversial... I guess the only solution is to locally implement something like https://github.com/Leaflet/Leaflet/pull/1293

Holy f*** that's a mess. :fearful: Thanks for pointing me in the right direction though!
Based on this comment, is it possible to implement a "manual" solution within Leaflet.draw?

This easily solved manually by either providing coordinates that go beyond the [-180;180] longitude range, or preprocessing input coordinates, manually adding/subtracting 360 where neighboring points are almost a world apart. This pull is a convenience, its absence shouldn't be a showstopper.

Or can this only be handled within Leaflet itself?
My current workaround: setting the maxBounds map option to [[-90, -180], [90, 180]]. Two problems with this:

Users can still drag drawings to another world (outside the map). They are just less likely to do this, because they can't see where they're dragging.
Restricting the map in this way can be very annoying for users near the "edges" of the world in places like Japan, Australia, eastern Russia, etc.

Any other ideas?

I've got some code that can restrict drawings to a map's maxbounds; I had submitted it as part of an earlier PR, and would be happy to do so again.
OTOH, I had another idea that I've been playing with somewhat that seems to be working out. That is to use L.Class.include to overload various methods of L.Polyline, L.Polygon, L.Rectangle, L.Marker, and L.Circle to essentially add a "shadow" duplicate version of a shape whenever it spans a map's wrap line. That is to say, if one has a rectangle like this:
new L.Rectangle([[-29.5, -119], [35.5, 143]])

Then my code will change its coordinates to all be on one side of the IDL, and then add a secondary rectangle so that you now have two rectangles like this:
new L.Rectangle([[-29.5, -119], [35.5, 143-360]])
new L.Rectangle([[-29.5, (360-119)], [35.5, 143]])

This shadow rectangle has its events forwarded to the main rectangle, and changing the latlangs/bounds  of either will cause the other one to be changed as well.
A wonderful thing about this method is that it requires absolutely no changes (I think) to leaflet.js or leaflet-draw.js! It does, however, use extra resources because it needs to check for wrap-crossings every time latlngs are changed. But, I don't think that is avoidable, unfortunately.
One caveat is that I'm currently testing with 1.0.3, and I just now remembered that Leaflet 1.2 uses a new ES6-based build scheme. Since my implementation uses heavy modifications of the L.Polyline, L.Polygon, etc prototypes along with manual method dispatch in order to implement the automatic shape mirroring, I'm worried that the new build system will break my stuff in a similar way to the stuff with L.Util broke Leaflet Draw 0.4.10. I have no idea though... but, I'll have to look into that before I post another update.


BUG: The type 'MemoryExtensions' exists in both assemblies in version 1.5

Describe the bug
When I upgrade this library to v1.5 in a Unity project which uses .NET Standard 2.1, the compiler throws errors like this:
Error CS0433: The type 'MemoryExtensions' exists in both 'SpanExtensions.Net.Unity, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' and 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'

To Reproduce
I don't suppose you're using Unity so I will omit this part because this ultimately doesn't relate to Unity.
Expected behavior
No compilation error.
Version
v1.5
Additional context
The type 'MemoryExtensions' already exists since .NET Standard 2.1, this define
#if !NET9_0_OR_GREATER

is not a good one.

Hey, thanks for your report.
I've looked into this and tried to run Split on frameworks below .Net 9, which worked flawlessly.
I might need more information here, yet
#if !NET9_0_OR_GREATER

should be (and in fact is as far as I can tell) fine, since MemoryExtensions is declared as a partial class in my source as well as in the CoreCLR as provided by Microsoft.
You mentioned that you are running .Net Standard 2.1, which is not really a possibility as .Net Standard is only a specification and not a concrete implemention of .Net unlike .Net Core. From the little Unity experience I have, I seem to recall that Unity provides its own .Net Standard 2.1 compliant runtime, which presumably is what you are refering to.
I currently assume, unless you have evidence to the contrary, that this is a compatibility issue with Unity's implementation and not a flaw of the package I can fix.
However, as I see you are providing a fork for unity, perhaps try changing the namespace of MemoryExtensions in src/Enumerators/System/SpanSplitEnumerator.cs from System to SpanExtensions and see if that helps.

Yes changing namespace or type name is doable. However it might introduce incompatibility which complicate the updating process. However, I will go this route then.

MemoryExtensions is declared as a partial class in my source as well as in the CoreCLR as provided by Microsoft

Stated in the document: Partial definitions can't span multiple modules.

You're right, I'm somewhat confused why it doesn't break then on earlier .Net versions (like .Net 7/8) as it should, yet I might just rename the type to a custom Type to comply with the docs - just in case.
I need to roll a bugfix anyway.
Thanks for bringing this to my attention.

I internally changed the namespace to SpanExtensions. Should be resolved.


Update 2018-06-07-you-probably-dont-need-derived-state.md

A single form of argument confused me here. The memoization func in question accepts multiple arguments.

Thanks


Properly handles unused groups in the multimap modal

Fixes #1350

properly filters available demographic group options into withData and noData
sends noData into multimap to be displayed in an alert box; better visually than a blank map box, but still highlighting the issues re: missing data and inconsistent terminology / data collection


Response freezes

Sometimes the request will freeze and never finish, might be useful to have a timeout in ms attribute.

Agreed.
In the meantime, see my example here for how to do this on your end: https://github.com/transitive-bullshit/chatgpt-api/issues/16#issuecomment-1338985001

If anyone's able to debug what's actually going on when this happens, that'd be really helpful btw.

I was initially reluctant to add timeout support to the package, because you could do it externally as I showed in https://github.com/transitive-bullshit/chatgpt-api/issues/16#issuecomment-1338985001.
I changed my mind, however, and added support for an optional timeoutMs parameter in https://github.com/transitive-bullshit/chatgpt-api/releases/tag/v2.0.0
I made this change for two main reasons:

Timeouts seem to be happening fairly commonly. I'm not sure if this is just because OpenAI's servers are being overloaded or because of possible rate-limiting, but it's a common enough issue that many people are running into that I felt it could be solved better in the package itself.
Currently, it'd be difficult to abort the underlying HTTP fetch request upon a timeout. By moving this logic inside of the sendMessage function, it's easy to make sure the HTTP fetch call gets properly aborted and cleaned up if a timeout occurs.


Allow running as service

I thought we want to proceed with daemon/sync. Do you think daemon would just run sync with loop flag?

I thought we want to proceed with daemon/sync. Do you think daemon would just run sync with loop flag?

We still want daemon. When it's ready we should remove this --loop flag.