influxdb2-cli: 2.5.0 -> 2.6.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/influx-cli/versions.
meta.description for influxdb2-cli is: "CLI for managing resources in InfluxDB v2"
meta.homepage for influxdb2-cli is: "https://influxdata.com/"
meta.changelog for influxdb2-cli is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.6.1 with grep in /nix/store/qg7111rp09ha09bz8zklpvzi5dsa6dnw-influx-cli-2.6.1
found 2.6.1 in filename of file in /nix/store/qg7111rp09ha09bz8zklpvzi5dsa6dnw-influx-cli-2.6.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
influxdb2
influxdb2-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qg7111rp09ha09bz8zklpvzi5dsa6dnw-influx-cli-2.6.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A influxdb2-cli https://github.com/r-ryantm/nixpkgs/archive/19f0aea48c07af9b533022b6ae4a9dde1fce7cda.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qg7111rp09ha09bz8zklpvzi5dsa6dnw-influx-cli-2.6.1
ls -la /nix/store/qg7111rp09ha09bz8zklpvzi5dsa6dnw-influx-cli-2.6.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

influxdb2
influxdb2-cli

Maintainer pings
cc @abbradar @danderson for testing.

https://github.com/NixOS/nixpkgs/pull/188678#issuecomment-1229553180


selectioncontrol TypeError: 'NoneType' object is not iterable

Description of the Bug
When running kitchen_sink demo, clicking on "Selection controls"  yields to a crash.
Code and Logs
[INFO   ] [KivyMD      ] 0.104.2.dev0 (installed at "/home/jdg/Téléchargements/KivyMD/kivymd/init.py")
[INFO   ] [Text        ] Provider: sdl2(['text_pango'] ignored)
[INFO   ] [GL          ] NPOT texture support is available
[INFO   ] [Clipboard   ] Provider: xclip
[INFO   ] [CutBuffer   ] cut buffer support enabled
[INFO   ] [Base        ] Start application main loop
[INFO   ] [Base        ] Leaving application in progress...
Traceback (most recent call last):
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 926, in _build_canvas
setattr(instr, key, value)
File "kivy/graphics/context_instructions.pyx", line 275, in kivy.graphics.context_instructions.Color.rgba.set
TypeError: 'NoneType' object is not iterable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "demos/kitchen_sink/main.py", line 124, in
KitchenSinkApp().run()
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/app.py", line 950, in run
runTouchApp()
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/base.py", line 582, in runTouchApp
EventLoop.mainloop()
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/base.py", line 347, in mainloop
self.idle()
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/base.py", line 391, in idle
self.dispatch_input()
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/base.py", line 342, in dispatch_input
post_dispatch_input(*pop(0))
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/base.py", line 308, in post_dispatch_input
wid.dispatch('on_touch_up', me)
File "kivy/_event.pyx", line 709, in kivy._event.EventDispatcher.dispatch
File "/home/jdg/Téléchargements/KivyMD/kivymd/uix/list.py", line 854, in on_touch_up
super().on_touch_up(touch)
File "/home/jdg/Téléchargements/KivyMD/kivymd/uix/behaviors/ripple_behavior.py", line 296, in on_touch_up
return super().on_touch_up(touch)
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/uix/behaviors/button.py", line 179, in on_touch_up
self.dispatch('on_release')
File "kivy/_event.pyx", line 709, in kivy._event.EventDispatcher.dispatch
File "demos/kitchen_sink/main.py", line 76, in
"on_release": lambda x=name_item_example: self.set_example_screen(
File "demos/kitchen_sink/main.py", line 93, in set_example_screen
screen_object = eval(self.data_screens[name_screen]["Factory"])
File "", line 1, in
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/uix/relativelayout.py", line 274, in init
super(RelativeLayout, self).init(**kw)
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/uix/floatlayout.py", line 65, in init
super(FloatLayout, self).init(**kwargs)
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/uix/layout.py", line 76, in init
super(Layout, self).init(**kwargs)
File "/home/jdg/Téléchargements/KivyMD/kivymd/uix/behaviors/backgroundcolor_behavior.py", line 139, in init
super().init(**kwargs)
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/uix/widget.py", line 359, in init
self.apply_class_lang_rules(
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/uix/widget.py", line 463, in apply_class_lang_rules
Builder.apply(
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 541, in apply
self._apply_rule(
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 661, in _apply_rule
child.apply_class_lang_rules(
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/uix/widget.py", line 463, in apply_class_lang_rules
Builder.apply(
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 541, in apply
self._apply_rule(
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 596, in _apply_rule
self._build_canvas(widget.canvas.before, widget,
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 929, in _build_canvas
raise BuilderException(
kivy.lang.builder.BuilderException: Parser: File "", line 32:
...
30:        Color:
31:            rgba:

32:                self._track_color_disabled if self.disabled else                (self._track_color_active if self.active                else self._track_color_normal)
33:        RoundedRectangle:
34:            size: self.width - dp(8), dp(16)
...
TypeError: 'NoneType' object is not iterable
File "/home/jdg/.local/lib/python3.8/site-packages/kivy/lang/builder.py", line 926, in _build_canvas
setattr(instr, key, value)
File "kivy/graphics/context_instructions.pyx", line 275, in kivy.graphics.context_instructions.Color.rgba.set

Versions

OS: Fedora-32 x86_64
Python: Python 3.8.6
Kivy: v2.0.0rc4
KivyMD: git a9da44b8714cd794c782ed5027c7db295c3a57cf

Following patch does solve the issue:
[jdg@tiare KivyMD]$ git diff
diff --git a/kivymd/uix/selectioncontrol.py b/kivymd/uix/selectioncontrol.py
index 543e2a8..bc394a0 100755
--- a/kivymd/uix/selectioncontrol.py
+++ b/kivymd/uix/selectioncontrol.py
@@ -513,9 +513,9 @@ class MDSwitch(ThemableBehavior, ButtonBehavior, FloatLayout):
     and defaults to `Primary`.
     """

-    _track_color_active = ColorProperty(None)
-    _track_color_normal = ColorProperty(None)
-    _track_color_disabled = ColorProperty(None)
+    _track_color_active = ColorProperty()
+    _track_color_normal = ColorProperty()
+    _track_color_disabled = ColorProperty()
     _thumb_pos = ListProperty([0, 0])

     def __init__(self, **kwargs):

Not sure this is the right thing to do...

https://github.com/kivymd/KivyMD/commit/15e21769c32ed00df96570d45c90e0d7971e7f49

https://github.com/kivymd/KivyMD/commit/15e21769c32ed00df96570d45c90e0d7971e7f49


The app is terminated by the OS, sometime.

Actions:

[ ] Ensure that users receive a notification when the app is terminated.
[ ] Reproduce the case, then decide on the next steps.

Notifications

app closed, user should be notified w a notification
device disconnects, user should be notified w a notification
transcript service disconnects, user should be notified w a notification

Closed, duplicated #924


PROPOSAL: Adding generator and specs repo info to APIDIFF output

The following additions serve as a convenience when generating diffs between packages. The optional arguments would enable developers to output the diff with the azure-rest-api-specs repo commit hash and the Go generator version beneath the release header.
Another solution for adding this information could be to simply use a script that runs through generated diff documents and appends the information to those files as needed.

Hi @catalinaperalta This looks good to me, but I suppose we still need the relative path of the readme.md file and the corresponding tag to keep the metadata complete.
I am using commit hash, readme file relative path, tag name, and the code generator version to track every package in their CHANGELOGs, so that we could identify it when there is a change of output-folder or rename of tag, etc.

Hi @catalinaperalta This looks good to me, but I suppose we still need the relative path of the readme.md file and the corresponding tag to keep the metadata complete.
I am using commit hash, readme file relative path, tag name, and the code generator version to track every package in their CHANGELOGs, so that we could identify it when there is a change of output-folder or rename of tag, etc.

but I suppose we still need the relative path of the readme.md file and the corresponding tag to keep the metadata complete

@ArcturusZhang we can add any additional metadata we want, only I see this adding more args to the command. I also think we should all agree on what additional information we want to output in the changelogs. @jhendrixMSFT do you also have an opinion on also adding the readme.md and tag to the changelog?

but I suppose we still need the relative path of the readme.md file and the corresponding tag to keep the metadata complete

@ArcturusZhang we can add any additional metadata we want, only I see this adding more args to the command. I also think we should all agree on what additional information we want to output in the changelogs. @jhendrixMSFT do you also have an opinion on also adding the readme.md and tag to the changelog?

We can also just append content to the file via the shell, e.g. ver v1.2.3 commit abc >> changelog.md or something.

We can also just append content to the file via the shell, e.g. ver v1.2.3 commit abc >> changelog.md or something.

@catalinaperalta @jhendrixMSFT I have been using this format in track 1 packages now, please take this file as an example: https://github.com/Azure/azure-sdk-for-go/blob/master/services/aad/mgmt/2017-04-01/aad/CHANGELOG.md

@catalinaperalta @jhendrixMSFT I have been using this format in track 1 packages now, please take this file as an example: https://github.com/Azure/azure-sdk-for-go/blob/master/services/aad/mgmt/2017-04-01/aad/CHANGELOG.md

And for your information, I have written some utilities for writing and reading the generation metadata, please check it out here: https://github.com/Azure/azure-sdk-for-go/blob/2748f9c295d18b949cb1bfacb6bce08ad1d87501/tools/generator/autorest/generationMetadata.go#L22
Please feel free to reuse or refactor this to make it more general if necessary

And for your information, I have written some utilities for writing and reading the generation metadata, please check it out here: https://github.com/Azure/azure-sdk-for-go/blob/2748f9c295d18b949cb1bfacb6bce08ad1d87501/tools/generator/autorest/generationMetadata.go#L22
Please feel free to reuse or refactor this to make it more general if necessary

Per offline discussion, we agreed that adding the metadata doesn't really belong with the changelog command.

Per offline discussion, we agreed that adding the metadata doesn't really belong with the changelog command.


https://auth.contao.id/security/register broken

Affected version(s)
current
Description
Not sure what the context of this system is as there is no documentation, but https://auth.contao.id/security/register is broken.

It's not yet open to public registration.


Not able to find train_sizes-00000-of-00001.csv

Hi,
Thanks for sharing the script for converting annotations to COCO format. I am going through your code but realized that I am not able to find a particular file train_sizes-00000-of-00001.csv.
Do you mind sharing with me where can I download it?
Thank you!

Hi,
have you found where are train_sizes-00000-of-00001.csv and validation_sizes-00000-of-00001.csv?
thanks!!


Portuguese Translation

Can I start translating this course to Portuguese?
I'm not a professional translator, not even concluded the course, but with a AI tool I think I can do a good job. 😀
Also can use the translation as a mean to better understand the concepts.
Best Regards

Hey there 👋 we don't plan for now to make official course translation but we might do it in the future. I'm keeping your name to contact you if and when we will do it 🤗


Rum search tracking

Description:
test sampleRUM for search terms tracking
Resolves: MWPW-135636
Test URLs:

Before: https://main--express--adobecom.hlx.page/express/?lighthouse=on
After: https://rum-search-tracking--express--adobecom.hlx.page/express/?lighthouse=on

@qiyundai in general, there should always be a ticket for the coding work we do. I actually already created one a few days ago, so you can use that - https://jira.corp.adobe.com/browse/MWPW-135636

Codecov Report

Merging #218 (a15a921) into stage (78a205d) will increase coverage by 1.67%.
Report is 31 commits behind head on stage.
The diff coverage is 18.75%.

@@            Coverage Diff             @@
##            stage     #218      +/-   ##
==========================================
+ Coverage   35.34%   37.01%   +1.67%
==========================================
  Files          27       29       +2
  Lines        9533     9852     +319
==========================================
+ Hits         3369     3647     +278
- Misses       6164     6205      +41

Files Changed
Coverage Δ

express/blocks/template-list/template-list.js
15.88% <10.34%> (+0.01%)
:arrow_up:

express/scripts/scripts.js
42.42% <100.00%> (-0.31%)
:arrow_down:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

We might want to hold out on this since the content API team is gonna setup a backend API endpoint for us to dump the data. cc: @JingleH @vhargrave

We might want to hold out on this since the content API team is gonna setup a backend API endpoint for us to dump the data. cc: @JingleH @vhargrave

@qiyundai I wouldn't wait. This is high priority for the franklin folks. Could you ask whoever wants these logs if we can either start rerouting or pause logging altogether?

We might want to hold out on this since the content API team is gonna setup a backend API endpoint for us to dump the data. cc: @JingleH @vhargrave

@qiyundai I wouldn't wait. This is high priority for the franklin folks. Could you ask whoever wants these logs if we can either start rerouting or pause logging altogether?

In that case let's get this merged first and then take a quick look at what RUM has to offer for search tracking. Later when content API team has that backend API setup for us we can pivot again. Thoughts? @JingleH @vhargrave


bgp update-source option missing or overwritten in os-frr (gui)

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X ] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[ X] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[X] The title contains the plugin to which this issue belongs

Describe the bug
Can't set source IPv6 address for BGP neigbour from which to start BGP session.
Using CARP to make IPv6 failover on vlan01 interface. CIDR is /120
I can only set interface:
neighbor X:X:X:1 interface vlan01
but not :
neighbor X:X:X:1 update-source X:X:X:X
And then the bgp peer session is started from WAN interface IPv6, not the VIP one.
This worked in pfsense version of frr.
To Reproduce
Steps to reproduce the behavior:

If i add this option via vtysh it works till next time i use FRR via GUI
https://opnsense/ui/quagga/diagnostics/bgp

Expected behavior
Local host: 2X:X:1:1::21:2
Foreign host: 2X:X:1:1::21:1, Foreign port: 179
Relevant log files
Connections established 0; dropped 0
Last reset 03:13:16,   Notification received (Cease/Connection Rejected)
Additional context
VIP is ::21:2
OPN1 has ::21:20
OPN2 has ::21:21
Environment
OPNsense 22.7.6-amd64
FreeBSD 13.1-RELEASE-p2
OpenSSL 1.1.1q 5 Jul 2022
Intel(R) Atom(TM) CPU C3558 @ 2.20GHz (4 cores, 4 threads)

Hello.
I might be wrong, but I think this is related to issue 3179.
- AnsibleGuy

Hi
Using NAT on outbound BGP session is not possible on IPv6. :)
Now i run BGP w/ FRR, but w/o os-frr (gui) because

it ignores/deletes "update-source" in config if i added it via vtysh
os-frr (bgp neighbour section) tself does not have update-source option

and all of this worked in pfsense/frr. :)

Hello.
I might be wrong, but I think this is related to issue 3179.

AnsibleGuy

@ansibleguy , you are correct, it is the same, but I didn't notice this as it was regarding IPv6.
Anyone, pls feel free to merge these tickets.
NIels

We could use the localip field which was introduced for MD5 passwords


Add row_factory property to Cursor

Description
Adds the row_factory property to the Cursor class as documented here: https://docs.python.org/3/library/sqlite3.html#sqlite3.Cursor.row_factory
Also amended the unit tests to cover this new case.
Fixes: https://github.com/omnilib/aiosqlite/issues/180

I had not run the linter. Let me go fix this.

I had not run the linter. Let me go fix this.

No worries, I took care of it.  Thank you for submitting this :)

Oh perfect, thank you Amy!On Apr 16, 2023, at 10:03 PM, Amethyst Reese @.***> wrote:
Merged #229 into main.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Module "@prisma/client" has no exported member "PrismaClient"

Bug description

The latest version of @prisma/client (3.15.2) has (In my opinion) made some changes, and PrismaClient is no longer being exported from "@prisma/client";
How to reproduce

Go to the file, where you want to import & import { PrismaClient } from "@prisma/client"
See error

Expected behavior
No response
Prisma information
generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["referentialIntegrity"]
}

datasource db {
  provider             = "mysql"
  url                  = env("DATABASE_URL")
  referentialIntegrity = "prisma"
}

model user {
  id             Int      @id @default(autoincrement())
  email          String   @unique
  First_Name     String   @map("First Name")
  Last_Name      String   @map("Last Name")
  Password       String
  created_at     DateTime @default(now())
  updated_at     DateTime
}

Environment & setup

OS: EndeavourOS Linux x86_64 (Arch Linux)
Database: MySQL (Provisioned by PlanetScale)
Node.js version: 18.3.0

Prisma Version
3.15.2

did you ran prisma generate as the docs says?

As @arthurfiorette mentioned, I think you're missing a prisma generate.

As @arthurfiorette mentioned, I think you're missing a prisma generate. Perhaps you cloned the repo?

I won't raise an Issue, without running the prisma generate command sir. I've done a prisma db push as well.
Restarted my TypeScript Server. And the weird thing here is, the Package Manager.
pnpm is giving this error, But If I delete the node_modules/ and re-install all the dependencies with npm It works fine.
In most of my Projects, I use pnpm and all of them when ran pnpm install gives the same error.

Installing via pnpm and using import { PrismaClient } from '@prisma/client'; the typescript server states:

Cannot resolve symbol 'PrismaClient'

I've run pnpx prisma generate which created node_modules/.prisma/client; still it's not picked up for some reason.

I'm having the same issue on endeavourOS. I've run prisma generate and tried to reinstall node_modules as well.

I'm having the same issue on endeavourOS. I've run prisma generate and tried to reinstall node_modules as well.

Installing via pnpm and using import { PrismaClient } from '@prisma/client'; the typescript server states:

Cannot resolve symbol 'PrismaClient'

I've run pnpx prisma generate which created node_modules/.prisma/client; still it's not picked up for some reason.

I dont't know if it's the Operating System or the Package Manager, I've to use npm instead of pnpm everytime I use Prisma. With a TSServer Restart, It does the work.

Try updating prisma. There apparently was a new major version update.

Also facing the exact same issue with pnpm and prisma. The node_modules/.prisma dependency is generated correctly, but what's happening is @prisma/client points to node_modules/.pnpm/@prisma+client@3.15.2_prisma<EMAIL_ADDRESS>- so the nested dependency approach of pnpm to avoid version conflicts is getting in the way.

Also facing the exact same issue with pnpm and prisma. The node_modules/.prisma dependency is generated correctly, but what's happening is @prisma/client points to node_modules/.pnpm/@prisma+client@3.15.2_prisma<EMAIL_ADDRESS>- so the nested dependency approach of pnpm to avoid version conflicts is getting in the way.
Edit: Was using pnpm 7.5.2, upgrading to pnpm 7.8.0, deleting node_modules and running PRISMA_SKIP_POSTINSTALL_GENERATE=true p install fixed it for me. Which of those steps did the trick though shrug

As you mentioned, Sir, I updated pnpm to 7.8.0 and deleted the node_modules
ran, PRISMA_SKIP_POSTINSTALL_GENERATE=true pnpm install
This thing didn't worked for me.
I created a new project to test this out, But still the same issue occurred.

Edit: Was using pnpm 7.5.2, upgrading to pnpm 7.8.0, deleting node_modules and running PRISMA_SKIP_POSTINSTALL_GENERATE=true p install fixed it for me. Which of those steps did the trick though 🤷

Did not fix it for me either.
I've also set this in the project's .npmrc file:
node-linker=hoisted
symlink=false
package-import-method=copy

But even that didn't help.

So, do we know something about this? Still happening, I don't have any types for prisma client. It works when exporting the client from the package base directory. Stops working when exporting from src. I am starting to wonder what the point of pnpm is really

Hey @irg1008, could you provide us with a simple reproduction?

Sure,
I have a pnpm monorepo with turborepo.
My prisma schema output is in a "database" package:
Custom client output:
generator client {
  provider = "prisma-client-js"
  output   = "../node_modules/.prisma/client" // We need to export the client to the root for production and to pnpm virtual store for development
}

So when I disable the custom output, the prisma client is built out to the .pnpm virtual store, and as so it works on both dev and prod in apps "database" is dependency of.
The issue is that when doing this, I am missing typing on dev. This happens because the TS server links to the package "database" (without generated prisma client) even when it actually is importing it from the virtual store.
Project tree:

node_modules (root)

.pnpm

.prisma

(default prisma client output). (Works when exporting here, no typing)

apps

server (links types to database, consumes from virtual store)

packages

database

node_modules (exporting here adds typings but prod fails)
prisma/schema

The solution to have both the correct build link and typing it's to generate the clients in both places.
This causes and immediate problem when updating the schema.You have to generate the client two times, etc etc
We can solve this if we automatically output the schema to both node_modules (root and package).
Or maybe I am missing some settings with pnpm.
Any help would be great!

A basic fix is to point prisma client output to root node_modules like:
generator client {
  provider = "prisma-client-js"
  output   = "../../../node_modules/.prisma/client" // Root of the monorepo
}

This works when building and in dev mode.
I see problems with this approach while deploying the app as a separate project and not as a monorepo; schema would point to a non existant folder
Additional info (.pnpm):
auto-install-peers = true
enable-pre-post-scripts=true
public-hoist-pattern[]=*prisma*

Same issue here - it's searching for it in the wrong location

@ARMATAV @irg1008 @SooditK @pgiovanni @thasmo
Are you by any chance using preserveSymlinks?
I confirmed that this is causing issues with Prisma Client  and pnpm, setting it to false prevents type issues.
Have you tried to restart VSCode or the TS Server?
Some users have reported that after being generate, VSCode did not pick up the new generated types.
There are many issues interleaved, and so far we know my two mentions just above are things we need to fix.
Did any of these help? If not, could you please provide us with a small reproduction? We are not able to reproduce the issues mentioned in the comments, so we need your help :pray:  I'd appreciate if you could submit us some code.

This is how install works for me:
set NODE_OPTIONS="--preserve-symlinks"
pnpm install        // will emit error, no worry continue with next step
cd packages/hoppscotch-backend
rm -rf dist && pnpm prisma generate && pnpm install
cd -
pnpm install

A basic fix is to point prisma client output to root node_modules like:
generator client {
  provider = "prisma-client-js"
  output   = "../../../node_modules/.prisma/client" // Root of the monorepo
}

This works when building and in dev mode.
I see problems with this approach while deploying the app as a separate project and not as a monorepo; schema would point to a non existant folder
Additional info (.pnpm):
auto-install-peers = true
enable-pre-post-scripts=true
public-hoist-pattern[]=*prisma*

It's been one year have you got the solution?


Still not working with 10.15.7, Mail v. 13.4

log reports these commands containing Mailtracker:
Timestamp                       (process)[PID]
2021-11-01 17:55:56.012376-0400  localhost UserEventAgent[898]: (com.apple.cts) [com.apple.xpc.activity:Activities] Unregistered XPC Activity: com.onefatgiraffe.mailtrackerblocker.updater
2021-11-01 17:55:56.014032-0400  localhost UserEventAgent[898]: (com.apple.cts) [com.apple.xpc.activity:Internal] Creating zombie: com.onefatgiraffe.mailtrackerblocker.updater
2021-11-01 17:55:56.617761-0400  localhost UserEventAgent[898]: (com.apple.cts) [com.apple.xpc.activity:Internal] Reaping zombie: com.onefatgiraffe.mailtrackerblocker.updater
2021-11-01 17:55:56.617954-0400  localhost UserEventAgent[898]: (com.apple.cts) [com.apple.xpc.activity:Internal] com.onefatgiraffe.mailtrackerblocker.updater state change 1 -> -1
2021-11-01 17:55:56.618275-0400  localhost UserEventAgent[898]: (com.apple.cts) [com.apple.xpc.activity:Internal] Canceling DASActivity: 504:com.onefatgiraffe.mailtrackerblocker.updater:5B3B7C
2021-11-01 17:55:56.618744-0400  localhost UserEventAgent[898]: (com.apple.cts) [com.apple.xpc.activity:Internal] REAPED zombie: com.onefatgiraffe.mailtrackerblocker.updater [0x7ffcbee13a40]
2021-11-01 17:55:56.619078-0400  localhost dasd[204]: (DuetActivitySchedulerDaemon) [com.apple.duetactivityscheduler:lifecycle] CANCELED: 504:com.onefatgiraffe.mailtrackerblocker.updater:5B3B7C at priority 5 <private>!
2021-11-01 17:56:06.349527-0400  localhost kernel[0]: (Sandbox) Sandbox: 1 duplicate report for syspolicyd deny(1) file-read-metadata /Users/username/Library/Containers/com.apple.mail/Data/DataVaults/MailBundles/Library/Mail/Bundles/MailTrackerBlocker.mailbundle/Contents/MacOS/MailTrackerBlocker
2021-11-01 17:56:06.349536-0400  localhost kernel[0]: (Sandbox) Sandbox: launchd(1) System Policy: deny(1) file-read-metadata /Users/username/Library/Containers/com.apple.mail/Data/DataVaults/MailBundles/Library/Mail/Bundles/MailTrackerBlocker.mailbundle/Contents/MacOS/MailTrackerBlocker
2021-11-01 17:56:06.379509-0400  localhost Mail[7416]: (libxpc.dylib) [com.apple.xpc.activity:Client] xpc_activity_register: com.onefatgiraffe.mailtrackerblocker.updater, criteria: dictionary
2021-11-01 17:56:06.382597-0400  localhost UserEventAgent[898]: (com.apple.cts) [com.apple.xpc.activity:Internal] Creating XPC Activity: com.onefatgiraffe.mailtrackerblocker.updater
2021-11-01 17:56:06.382885-0400  localhost UserEventAgent[898]: (com.apple.cts) [com.apple.xpc.activity:Internal] Submitting DASActivity: <_DASActivity: \"504:com.onefatgiraffe.mailtrackerblocker.updater:75A8E9\", Maintenance, 60s, [2/11/21, 14:50:15 - 2/11/21, 16:50:15], Group: \"com.apple.dasd.default\", Plugin Required, Interval=1440, Budgeted, Delayed Start, User Specified: { }>
2021-11-01 17:56:06.383130-0400  localhost UserEventAgent[898]: (com.apple.cts) [com.apple.xpc.activity:Activities] Registered XPC Activity: com.onefatgiraffe.mailtrackerblocker.updater
2021-11-01 17:56:06.383283-0400  localhost UserEventAgent[898]: (com.apple.cts) [com.apple.xpc.activity:Internal] com.onefatgiraffe.mailtrackerblocker.updater: <dictionary: 0x7ffcbec72510> { count = 6, transaction: 0, voucher = 0x0, contents =
	\"_SequenceNumber\" => <uint64: 0x2fd5a7e7d51428cb>: 1
	\"Repeating\" => <bool: 0x7fff91219490>: true
	\"Interval\" => <int64: 0x2fd5a7e7c00c38db>: 86400
	\"GracePeriod\" => <int64: 0x2fd5a7e7d5f538db>: 3600
	\"Delay\" => <int64: 0x2fd5a7e7c12338db>: 82800
	\"Priority\" => <string: 0x7ffcbec8fd30> { length = 11, contents = \"Maintenance\" }
}
2021-11-01 17:56:06.387291-0400  localhost dasd[204]: (DuetActivitySchedulerDaemon) [com.apple.duetactivityscheduler:default] Submitted Activity: 504:com.onefatgiraffe.mailtrackerblocker.updater:75A8E9 at priority 5 with interval 86400 <private>
2021-11-01 17:56:06.686820-0400  localhost kernel[0]: (Sandbox) Sandbox: logd(172) System Policy: deny(1) file-read-data /Users/username/Library/Containers/com.apple.mail/Data/DataVaults/MailBundles/Library/Mail/Bundles/MailTrackerBlocker.mailbundle/Contents/MacOS/MailTrackerBlocker
2021-11-01 17:56:06.686949-0400  localhost kernel[0]: (Sandbox) Sandbox: logd(172) System Policy: deny(1) file-read-data /Users/username/Library/Containers/com.apple.mail/Data/DataVaults/MailBundles/Library/Mail/Bundles/MailTrackerBlocker.mailbundle/Contents/MacOS/MailTrackerBlocker

By "not working", do you mean the plugin doesn't startup (i.e. the ⓧ icon is missing)? Or is this issue related to #107?

Hmmm, right now I'm getting the x icon and it seems to be working. I'll monitor.

Just a little follow-up:
My script uses the following to look for the log entry to make sure that the plugin gets loaded:
log show --debug --last 1m --style syslog --info --predicate 'eventMessage BEGINSWITH[c] "Loaded MailTrackerBlocker"'

But it's not finding anything.


Fix pokemon_evolved event parameters conflict

Hotfix for error:
Traceback (most recent call last):
  File "pokecli.py", line 674, in <module>
    main()
  File "pokecli.py", line 118, in main
    bot.tick()
  File "/home/cmezh/pogocmezh/pokemongo_bot/__init__.py", line 541, in tick
    if worker.work() == WorkerResult.RUNNING:
  File "/home/cmezh/pogocmezh/pokemongo_bot/cell_workers/pokemon_optimizer.py", line 78, in work
    self.apply_optimization(transfer_all, evo_all)
  File "/home/cmezh/pogocmezh/pokemongo_bot/cell_workers/pokemon_optimizer.py", line 294, in apply_optimization
    self.evolve_pokemon(pokemon)
  File "/home/cmezh/pogocmezh/pokemongo_bot/cell_workers/pokemon_optimizer.py", line 396, in evolve_pokemon
    "xp": xp})
  File "/home/cmezh/pogocmezh/pokemongo_bot/base_task.py", line 35, in emit_event
    data=data
  File "/home/cmezh/pogocmezh/pokemongo_bot/event_manager.py", line 59, in emit
    raise EventMalformedException("Event %s does not require parameter %s" % (event, k))
pokemongo_bot.event_manager.EventMalformedException: Event pokemon_evolved does not require parameter candy

Sorry. #4389


integrate unit id in catalogue category , item and catalogue items  #243

Description
see #243
Testing instructions
Add a set up instructions describing how the reviewer should test the code

[ ] Review code
[ ] Check Actions build
[ ] Review changes to test coverage
[ ] {more steps here}

Agile board tracking
closes #243

I will review the tests once the requested changes have been addressed as they are likely to affect the tests.


improving seek speed

we were using absolute which uses exact and from the docs looks like that is slow, when testing with the new code it seems faster, but i dont feel that the workaround i did to allow such logic is good,
so this needs further testing and a better/cleaner position logic
issues i found which needs to be fixed before merging:

[x] multiple seeks in the same time is not working correctly due to position not being updated

from my testing for now it should be all good and seeking is faster when called multiple times (that was a problem in general )
and seeking is 50% faster from what i feel

i cant figure out why the test case is failing since the seek works, but looks like its not as accurate as absolute in exchange for speed i think thats a good trade.

Precise jump positioning is really not necessary. Users don’t click very accurately. I agree with this update.
In addition, I have a question that is not related to this update. I would like to ask about whether the automatic next episode is triggered by mpv? Or media-kit. I didn't find the relevant code for the next episode in the media-kit.

Precise jump positioning is really not necessary. Users don’t click very accurately. I agree with this update.
In addition, I have a question that is not related to this update. I would like to ask about whether the automatic next episode is triggered by mpv? Or media-kit. I didn't find the relevant code for the next episode in the media-kit.

its handled by mpv, and can you test this pr and see if the seek is faster or not in your case

Precise jump positioning is really not necessary. Users don’t click very accurately. I agree with this update.
In addition, I have a question that is not related to this update. I would like to ask about whether the automatic next episode is triggered by mpv? Or media-kit. I didn't find the relevant code for the next episode in the media-kit.

its handled by mpv, and can you test this pr and see if the seek is faster or not in your case

Thanks, I'd like to test it, but one of these days I'll be back in a small town where I don't have a computer to program with. I can test it after I come back, which will take 3 days. Thank you for your enthusiastic reply.

No. This is not a solution. It's not really ideal to have 2-3 seconds mismatch, many of our users actually rely on accurate seek (which in-fact is default in most applications).

Of course... If one wishes to experiment themselves, they are free to use the hidden setProperty API.

from my test the mismatch was close to 0.5 sec but if you got higher values i dont think this can work, so i agree with you

I tried this yesterday. It couldn’t let me seek 15s forward on a long video file. It was jumping back to the closest keyframe.
For certain use cases that’s probably not an issue, so we can at least file an issue to make this configurable

Of course... If one wishes to experiment themselves, they are free to use the hidden setProperty API.

^^


[Question] Is there a way to change entity name("__en") field with custom property name?

Each item created by this library has internal attribute __en
I'd like to change this property's name because some of my service logics rely on the entity name and it assumes the property that shows type of entity would be named type.
suppose I have an entity like below
@Entity({
  name: "order",
  ...
})
class Order {
}

I want the final record to be like this
type Order = {
  // ...attributes,
  type: "order"
}

Is there any way to get the entity name in the entity class or other walkarounds?

Hi @warren3billion,
Currently, the __en is only available to internal APIs of TypeDORM and is not intended to be used outside of the TypeDORM's runtime lifecycle.
However, I do see a use-case were (optionally) exposing this as a public API might be useful, but it is not likely to be added anytime soon.
For the time being, I think you should consider storing "type" as an attribute on the entity with a default value specified as the entity name.
@Entity({
  name: "order",
  ...
})
class Order {
  @Attribute({default: 'user'})
  type: string
}


Handling error

I could not find any error handling for the connection. Also how could i know that the connection was a success

Hey @rubiin
Can you please share the package you are using and a sample code snippet that shows what it is that you are trying to do?
Some more details on your scenario and requirement will also help

i am using @azure/service-bus .
the code i am following is
const { ServiceBusClient } = require("@azure/service-bus");

// Define connection string and related Service Bus entity names here
const connectionString = "";
const topicName = "";

async function main(){
  const sbClient = ServiceBusClient.createFromConnectionString(connectionString);
  const topicClient = sbClient.createTopicClient(topicName);
  const sender = topicClient.createSender();

    try {
        for (let i = 0; i < 10; i++) {
          const message= {
            body: `Hello world! ${i}`,
            label: `test`,
            userProperties: {
                myCustomPropertyName: `my custom property value ${i}`
            }
          };
          console.log(`Sending message: ${message.body}`);
          await sender.send(message);
        }

        await topicClient.close();
      } finally {
        await sbClient.close();
      }
}

main().catch((err) => {
  console.log("Error occurred: ", err);
});

so how can i know the connection established successfully on line ServiceBusClient.createFromConnectionString(connectionString);

The createFromConnectionString() method does not establish the connection.
The package does lazy connection initialization once it encounters a user initiated action that does need the connection.
In the code snippet you have shared, the connection is established when the first message is sent.
You use the await sender.open() to ensure that the connection is established before sending your first message.
cc @richardpark-msft for any follow ups if needed

Hey @rubiin
We have not heard back from you in two weeks, so am assuming that the above has answered your question.
Please feel free to log a new issue if you find any other problems.


[WIP] Async/await style API

Currently severely broken due to bugs in tokio's DelayQueue and in need of considerable testing once that's fixed, but there's no reason for that to get in the way of design/API feedback. I'm particularly interested in thoughts on the 0-RTT API, which notably does not actually involve any futures or async.

With https://github.com/tokio-rs/tokio/pull/871, this now appears to be usable! All that's left is to wait for stabilization, and in the meantime I encourage people to try out the new API and see if there are any design flaws.

The new approach assumes that restrictions on 0-RTT frames will be relaxed as proposed in https://github.com/quicwg/base-drafts/pull/2355.

Should we just close this PR and/or convert it to issues with things we can still scavenge at some point? At this point I feel like redoing the work is probably easier than rebasing this.

Yeah, I believe we've successfully extracted all the significant architectural changes here save for the conversion to borrowing futures, which won't be a lot of work to reproduce.

I guess we might still want the failure -> err-ctx conversion?

The interop tool was completely rewritten with async/await so it's not really a portable change. Something to consider when the time to do that for real comes. Very mechanical, anyway.


Changed command for getting the load average.

Previous implementation was failing when the "uptime" command
returned seconds also in the uptime.
This should handle both cases.
Tested in Arch Linux where the problem occured.

Looks good to me! :+1: Thanks for the contribution!


do not compare cert bytes directly

We should not compare the root certs bytes directly, instead we can rely on the https://github.com/istio/istio/compare/master...irisdingbj:verifyfix?expand=1#diff-df16ac4e2cc1c048a4ce70aa3f27ec9c173573fc5288fb029fdc19b93c0ae259L133 to make sure the cert chain retured is correctly signed from root cert.

@irisdingbj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
e8acde757cbc777efdd1d8f26d9feb33c3c0b88f
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@irisdingbj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
e8acde757cbc777efdd1d8f26d9feb33c3c0b88f
link
true
/test release-notes_istio

lint_istio
e8acde757cbc777efdd1d8f26d9feb33c3c0b88f
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
818b29f587e4ecfba50429654c92f4474baf3ee2
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
818b29f587e4ecfba50429654c92f4474baf3ee2
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
818b29f587e4ecfba50429654c92f4474baf3ee2
link
true
/test integ-pilot-multicluster_istio

lint_istio
3f82da41aa45bedbd269ec3952f273484f7cd87a
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
818b29f587e4ecfba50429654c92f4474baf3ee2
link
true
/test integ-pilot-multicluster_istio

lint_istio
3f82da41aa45bedbd269ec3952f273484f7cd87a
link
true
/test lint_istio

gencheck_istio
3f82da41aa45bedbd269ec3952f273484f7cd87a
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @shankgan  Thanks a lot for the review comments.  I have added comments to explain the possible scenarios in the code and also added more test cases to cover these secnarios.    The new code are majorly to handle the situation that cert chain contains only intermediate CA. So we can not compare bytes directly. PTAL and let me know if the current rules are good.

@irisdingbj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
c4a269b01217d9fffb7d2118db67a0498eaba6c4
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@irisdingbj - looks good with the additional comments and the test cases


:fire: remove requirements/ from Build targets

Change Summary
Removing Requirements directory as its not existing anymore because its replaced with UV

Related issue number

Checklist

[x] The pull request title is a good summary of the changes - it will be used in the changelog
[x] Unit tests for the changes exist
[x] Tests pass on CI
[x] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review


Permutation Argument Soundness

The argument in point 1. of the section "Permutation Arguments" appears to be incomplete.
Denote the tables as matrices by A, B and the verifier randomness (a, b, c, ...) by the vector r. What needs to be analyzed is the probability that the components of the vector Ar are a permutation of the components of the vector Br when the rows of A and B are not permutations of each other. That is, what are the odds that for every permutation matrix P, A ≠ PB, but that we sample an r such that Ar = PBr for some P?
The argument given correctly analyzes the probability of sampling an r such that Ar = PBr for a fixed P. However, if Ar = PBr for any permutation matrix P, then the prover can trick the verifier, so only considering a single P is insufficient.
Basically, it's a priori possible that A - PB has a large codimension 1 kernel for a large number of permutations P. If these kernels are distinct they could fill up a significant portion of the space the verifier is sampling from, since the number of permutations P is on par with the field size for tables of even moderate height.

Excellent remark. I agree with this analysis entirely. Well done!
Here is an updated argument that works around the issue:
Let b be a row of B that does not exist in A. The malicious prover wins only if he receives challenges r such that for some row a of A, ar = br. The probability of this event for a given row a is 1/|F|. By the union bound, the probability of this event for any row a of A is at most N/|F|, where N is the number of rows.


Added callbacks to stop and pause, because the RN bridge is asynchronous

For 99% of my sound effects, I just want to play them from the beginning. If something is already playing, I almost always want to rewind and start from the beginning.
I had assumed that I could do this with:
sound.stop()
sound.play()

But then I noticed that sometimes my sounds were being clipped in strange ways. I just learned that the React Native Bridge is asynchronous, so stop and play are effectively being called in parallel.
This change allows me to call:
sound.stop(() => { sound.play() })

... which lets me make sure that a sound is rewinded before playing it.
Disclaimer
I haven't been able to test the Windows version, and that's the first time I've ever written any C#. But I'm currently in the middle of setting up a Windows installation for RN development, so I might be able to report back in a few hours.

Thanks @ndbroadbent. This is a nice idea and definitely a useful feature.
My first thought was that returning a Promise would be preferable to using a callback, but callbacks are more consistent with the rest of the react-native-sound API.
One question before I merge it - if you don't pass a callback to .stop() or .pause() does it still work on all platforms?

Hi @benvium, yes a callback is always passed to the native libraries, even if it is just a noop.
When I first looked at the code, I wanted to rewrite RNSound.play(this._key, (successfully) => onEnd && onEnd(successfully)); to be:
RNSound.play(this._key, onEnd && (successfully) => onEnd(successfully));

because that made more sense to me, but I quickly realized that the React Native bridge doesn't support "optional" callbacks. So the stop and pause functions will always pass in a callback function, even if the user did not provide one.
I'm actually just about to finish setting up my Windows development environment (🤞), and the Visual Studio installation is about 80% done. So if I can get my app running in there, I will be able to test the Windows version and make sure everything is working. I'll also see if I can replace callback.Invoke(NULL); with callback.Invoke();, because I think the NULL might not be necessary.

Also I agree about Promises. It looks like they are very easy to implement in a native module. Another idea might be to hide this inside the sound.js class, so that it keeps track of it's own promises. So if you call sound.stop(), and then you call sound.play() in a different part of your code, it would be cool if the sound instance kept track of the stop() Promise, and waited for that to resolve before calling play. That might actually be useful in my app, because I have some sound effects that are called very often from different places in my code.

What do you think about refactoring play, stop, and pause, and all of the setter and getter functions so that they all return a Promise (and use Promises internally?)
I just saw this line in the README:
You may chain non-getter calls, for example, sound.setVolume(.5).setPan(.5).play().

That's also going to suffer from the same race condition described in this PR. There's no guarantee that setVolume and setPan will finish before the play is started.

@ndbroadbent That's an interesting idea - internally here at Calvium we use a wrapper class for react-native-sound that does exactly that (return promises for everything).
We also 'remember' a promise wrapped around the constructor (that actually loads the sounds) and wait for that to resolve before 'doing' anything with the sound.
E.g.
setPosition(ms: number): Promise<*> {
    return this.load()
      .then(() => this._reactSoundObject.setCurrentTime(ms / 1000));
  }

.. where _reactSoundObject is an instance of react-native-sound.
This has made it much easier to deal with sounds controlled from various places in the app. Making this change direct to react-native-sound would probably be a breaking change though.

@benvium oh awesome, yeah I think that would be a great change to react-native-sound. Definitely would be grounds for a major version bump.

@benvium I just got my app working on Windows, and can confirm that these changes are ready to merge. (I also fixed another callback crash in #168).

Thanks @ndbroadbent! Merged


Tracking issue for doc alignment: Coalesce with other SB Feature teams for core concept structure

This is a tracking issue for a requested change to upcoming ServiceBus documentation.

Turn core concept headers into docs.microsoft links
Sync with other sdk languaged teams to centralize on core concept lists.
Ensure samples are all runnable with only their local state.

Closing since work was completed and approved in doc review.


Improve overall performance of the website but especially Blog

Reason/Context
When I access the blog, I cry, like a baby 😄
Website is not fastest but blog performs like a 🐢
Description

images sizes that can be easily improved with compression on a build level, or maybe Netlify offers something for free. This is an example of an image that has 4MB https://www.asyncapi.com/images/posts/organizing-asyncapi-documents.jpg
analyze with some widely know page speed tools what quick fixes can be applied
I don't think we have gzip enabled, must be doublechecked
MUST HAVE - proper testing of PR, of the size of the images, to throw errors if they are way to big, even for compression
MUST HAVE - have some validation of performance to make sure it is not getting worse over time again -> https://foo-software-lighthouse-reports.s3.amazonaws.com/lighthouse-report-1583237527152.html as there is out of the box GitHub action ready for that https://github.com/marketplace/actions/lighthouse-check
MUST HAVE - Start using a CDN. Cloudflare's CDN is a great one and it has a nice API too: https://www.cloudflare.com/cdn/.
Consider https://blurha.sh/

Store 'blob' object in cache rather than as BLOB. If is text/json/gson/bson/xml/etc, can easily be stored in cache and pulled quickly. BLOB is very slow and not ideal.

It seems to be giant task but it in fact is not, not everything has to be done by one person, it can end up as several PRs fixing different bits and pieces. Somebody need to just run some analytics and go and suggest fixes for each. We now for sure improved performance by shrinking manually all images and using webp format. I bet we could try to do more. Opened for suggestions

Heyy @derberg , Hope you are doing well!.
As discussed on Slack, I would like to work on this issue.
As you suggested, I used lighthouse to generate report for both mobile and desktop view.
Here are the reports I got.
For Home page:
Lighthouse-Report-Mobile-Expanded.pdf
Lighthouse-Report-Desktop-Expanded.pdf
For Blog:
Lighthouse-Report--Blog--Desktop-Expanded.pdf
Lighthouse-Report--Blog--Mobile-Expanded.pdf
Scores:

Categories
Desktop
Mobile

Performance
25
20

Accessibility
93
93

Best Practices
92
92

SEO
100
100

So, the main issues ,that have to be taken care of immediately,  are:

Using properly sized images
Ensuring that text remains visible during webfront load
Avoid enormous network payloads (due to .webp files)
Avoid an excessive DOM size (I really donot know what this is, have to look at it)

First I would like to work on resizing the images, as it could improve the performance score drastically.
For that, Sharp is recommended (by lighthouse) to resize the images. For that I need your approval to implement that 😃.
Ready to start the work.
Thank you very much😃

Avoid enormous network payloads (due to .webp files)

what do you mean by that? is it because of size? or some issues with .webp in general?

First I would like to work on resizing the images, as it could improve the performance score drastically.
For that, Sharp is recommended (by lighthouse) to resize the images

what is your plan, when would the optimization be triggered?
maybe there is some Netlify solution that we could use 🤔

Heyyy @derberg ,

what do you mean by that? is it because of size? or some issues with .webp in general?

I don't know the exact reason for this and have to look for some sources or the exact reason for this being as an issue

what is your plan, when would the optimization be triggered?

Sorry, I did not give a proper detailed explanation for this.
So the recommendation was to just serve the image of required size. As we are just using, most of the images, for blog cover image and profile picture, we can just scale or resize the images to the absolute required size.
Thus, cutting out the extra unnecessary payload, as of now we are using a full image which is being transferred to users' devices and then resized to the required size. which is taking a considerable amount of load time of 2.5s. We have to reduce this somehow.

maybe there is some Netlify solution that we could use 🤔

ooh could you please tell me about this or give me some links
Thank you😃

Sorry, I did not give a proper detailed explanation for this.
So the recommendation was to just serve the image of required size. As we are just using, most of the images, for blog cover image and profile picture, we can just scale or resize the images to the absolute required size.
Thus, cutting out the extra unnecessary payload, as of now we are using a full image which is being transferred to users' devices and then resized to the required size. which is taking a considerable amount of load time of 2.5s. We have to reduce this somehow.

so you mean manual work? problem is you know, after merging PR all new images would again be added to big. Thus this has to be somehow automated

ooh could you please tell me about this or give me some links

you would have to research, I haven't done this before but see things like https://spacejelly.dev/posts/how-to-optimize-images-on-netlify-with-the-cloudinary-build-plugin/ and for example cloudinary if for free for one account, so maybe we could use it (there is a plugin of some sort https://github.com/colbyfayock/netlify-plugin-cloudinary/)

Heyy @derberg ,

after merging PR all new images would again be added to big. Thus this has to be somehow automated

Ok. I will do some research and try to find some way to automate it.

you would have to research, I haven't done this before but see things like https://spacejelly.dev/posts/how-to-optimize-images-on-netlify-with-the-cloudinary-build-plugin/ and for example cloudinary if for free for one account, so maybe we could use it (there is a plugin of some sort https://github.com/colbyfayock/netlify-plugin-cloudinary/)

Yeah ok then.. I will do that and get back to you
I need some time for this because one issue got my attention. So now, I would like to work parallelly on the press, performance issue and this issue.
Thank you😁

@Harish-b-03 no worries, take your time 👍🏼

I would suggest first start experimenting with https://github.com/lovell/sharp which you mentioned there in the comments.
Try to write a script that can go through all the images in the website repo, and modifies them, I mean resizes. Then open a PR and let us have a look at the lighthouse report that will be generated.
Then we can make this script run in the background every day on GitHub Actions, and it will always do resize if there are new images, and open a PR and it will be merged by the bot.
Wdyt?

@Harish-b-03 still working on this issue? Would love to take over if not.

Heyy @Shofiya2003 , I am working on different issue. Please go ahead.😀

@Shofiya2003 lemme know if you need help

@Harish-b-03 I used lighthouse to generate the performance stats, but how did you generate those pdfs?

@Shofiya2003 there will be an option  inside the lighthouse tab to export it.

@derberg
Since in the blog the images rendered are of either the thumbnail for the blog or the profile photos.
I read about using cloudinary.
First we will serve our images using cloudinary CDN, we can do this even using our current image URL.
The images will be rendered using optimizations automatically with formats like AVIF if the browser supports it.
The size of the images will be transformed as required, using cloudinary image API which can be configured using parameters.
I read https://spacejelly.dev/posts/how-to-create-thumbnail-images-using-face-detection-with-cloudinary/#step-3-automatically-creating-cropped-thumbnails-based-on-detected-faces-with-cloudinary-transformations
It might help you understand the solution
Can we implement something like this instead of running scripts with sharp?

The large network payload is also due to the images. Maybe it will improve once we resize them.

Also, we have to ensure text is displayed during font load. For that we can use font-display:swap  in our css, the swap will display unstyled font while the font loads.

We are using lazy loading to load all the images, can we eagerly load the images above the fold eagerly because sometimes they are rendered late in the page and it increases the perceived load speed.

The optimization can be done by using the https://www.npmjs.com/package/react-window, to reduce the  number of DOM nodes created in the blog due to repeated elements. Increased DOM depths is affecting the speed due to the style calculations.

These were the suggestions for the blog.
The image loading is a issue in the website too, will first solve that and get the statistics again using lighthouse.

Cloudinary free tier looks good, I would not worry about that. We host AsyncAPI website on Netlify for free too, and use other free services.
I like idea with automated thumbnail generation a lot! Sound like great idea for blog.
We also need transformation on images and cover image on individual articles. Also the same with other places on the website.
So basically the idea is that during build images will be transformed, uploaded to cloudinary and links to images updated to point to new location. Right? If I get it right, please go ahead and give it a try, once it works, I can create official account for AsyncAPI.
great research btw!!!

@derberg yes you got it right. Will start implementing the solution.
Thank you

@derberg I made the changes for the blog. Should we first check the performance of the blog and then change the rest of the website?

yup, such approach definitely makes sense

@derberg opened a PR with the changes need the cloudinary cloudname for build to be successful

@derberg
The solution seems to be improving the analytics of the blog page for the web but not for mobile. Will look into it and get back to you within a day with a better solution.
Thanks a ton

I'm expanding this issue to not only focus on Blogs but on the overall website of AsyncAPI. With the current reports of Lighthouse, it is fully understandable that the website has a very poor rating in terms of performance. We can't afford further addition of features/animations inside website since it can then decrease the performance of the website. It's now important to improve the performance of the website based on the errors we detect using Lighthouse reports and analysis of various tools and make a strict bar on Performance parameter inside Lighthouse results to become future-proof on these issues.

Refactor and improve the overall performance of the website
Description
This issue is now divided into 3 phases - Refactoring the codebase, Improving the performance of each page of the website and Creating strict bar on Lighthouse reports. These 3 parts should be completed in the phase of the Mentorship program effectively. The details for the subcategories of this issue are mentioned as follows:
Refactoring the codebase
There are many parts inside the website codebase that needs to be refactored in order to improve code quality and performance of the website. The reports show us that there are many parts of code that comes under "Unused Javascript" while rendering the website. Hence, the contributor has to identify those part of codes and restructure them to provide better code quality. Secondly, I see we are making duplication of implementation in certain part of components where the necessary code has already been implemented in some other files, yet not been used from it. Hence, these cases should be acknowledged properly.
Improving the performance of each page of the website
In the network of 3G or some other slow networks, our website is not responsive for many seconds which makes the website performance rating and user Feedback very poor. Hence, this part of the issue coves on detecting and improving those part of implementation inside the website that hinders the performance. The contributor should show his/her detailed research in his part of the proposal.
Creating strict bar on Lighthouse reports
In order to become future-proof regarding these issues, we should ensure that no such contributions in the future should hinder the Performance, Accessibility, SEOs, and many other factors of website efficiency. Hence, required workflows and checks should be created (just like we have lighthouse report workflow).
This issue is now part of AsyncAPI Mentorship program 2023 and will be accepting proposals regarding it. Till now, no mentors have been assigned for the issue, but it will be announced officially soon. All the interested candidates are requested to kindly make the proposals according to the need of the issue and the codebase, to have better chances of getting selected.

@akshatnema
where to send the proposal for this issue? what is the deadline for the same?

@Shofiya2003 Proposal submission round hasn't been started yet. You can view the timeline of the AsyncAPI Mentorship program here.

To inform all the interested candidates of this issue, I have retracted this project idea from the Mentorship program on the discussion with @derberg. We will right now focus on @Shofiya2003's PR to resolve this issue.

Hi @derberg. Asking here as the relevant has been closed. Why aren't we using the NextJS Image Component. It essentially does the same thing as Cloudinary's CDN I think?

I am closing this issue as we have opened a new one for mentorship program
Ref https://github.com/asyncapi/website/issues/3186


More detailed to explanation

I put some details about built-in functions and explained better how to import them.

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] None of my changes are plagiarized from another source without proper attribution.
[X] My article does not contain shortened URLs or affiliate links.

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Remove jsnext:main support in next major release

ref https://github.com/infernojs/inferno/pull/830

I don't know enough about this to know if it is a good idea; but it would be quite easy to do downstream of my PR:  https://github.com/rollup/rollup-plugin-node-resolve/pull/85

Already deprecated with the latest version. Can we close the issue?


Stellar: Export Secret Key screen

@keybase/react-hackers
First up: @patrickxb or @mlsteele, are you okay with moving exportSecretKeyLocal to enabled-calls.json now?  It's used by the frontend for this PR.
Redux security considerations: Frontenders, I decided to use a HiddenString for the Stellar secret key value in the redux store, and to clear that HiddenString out from the store as soon as the export dialog is closed.  Sound right?

@cjb yep sounds good

@zanderz Thanks -- is that a thumb? :) Pinentry's switched over to the non-passphrase version now.

@chrisnojima Thanks! Made all of these changes.


server: adjust store disconnect log level and message

Signed-off-by: disksing<EMAIL_ADDRESS>What problem does this PR solve?
When store disconnected, the log message looks critical.
What is changed and how it works?
Adjust log level and reword.
Check List

Tests

no test

Release note

No release note

/merge


Extract specific result type from the res1d

Hi,
Is it possible to extract from a res1d only the WaterLevel and drop the DischargeToSurface for example?
thanks for the help

Hi, to do that you can try:
res1d = Res1D(file_path)
res1d.result_network.nodes.WaterLevel.add()
res1d.result_network.reaches.WaterLevel.add()
res1d.read()

Hi, to do that you can try:
res1d = Res1D(file_path)
res1d.result_network.nodes.WaterLevel.add()
res1d.result_network.reaches.WaterLevel.add()
res1d.read()

I must say that I find this syntax with the .add() to be slightly cryptic, I am not sure what I am adding it to🤔
> res1d.result_network.nodes.WaterLevel.add()
> res1d.result_network.reaches.WaterLevel.add()

res1d = Res1D(file_path)
res1d.result_network.reaches.WaterLevel.add()
res1d.read()

Works fine for me.

res1d.result_network.nodes.WaterLevel.add()

...does not work, however. (mikeio1d 0.4.0. Error message says "AttributeError: 'ResultNodes' object has no attribute 'WaterLevel'" (same happens for Discharge)
In any case, the above was a solution for me wanting to query all discharge across the entire file (like read_all(), but limited to a specified quantity)
I also tried to use QueryDataGlobal. That exists as parts of the queries, but does not seem to be implemented in res1d.read(). I tried to go through the code, but failed to understand how QueryDataGlobal could be implemented there (just like QueryDataNode, QueryDataReach and QueryDataCatchment already are.
If you think that should be implemented - should we open a new issue?

Thanks for the follow-up, Ryan!
The respective quantities are there:
print(res.quantities)
['WaterLevel', 'Discharge', 'LateralInflowSHEOverland', 'LateralInflowSHESatZone', 'LateralInflowSHEOverlandDrain', 'LateralInflowSHESatZoneDrain']

The global query, however:
from mikeio1d import Res1D
[DK7_HIP_100m_running.zip](https://github.com/DHI/mikeio1d/files/12723775/DK7_HIP_100m_running.zip)

from mikeio1d.res1d import QueryDataGlobal
fp = r'DK7_HIP_100m_running.res1d'
res = Res1D(fp)
# print(res.quantities)
qu = QueryDataGlobal('Discharge')
res.read(qu)

does not work, and yields a "NoDataForQuery: Invalid query Discharge" error. I tried to work my way through the code myself to understand what's going on, but to no avail.
I attached the .res1d file I used - which originates from a coupled MIKE SHE - HYDRO River setup run in MIKE Zero 2023. Thanks for looking into this.

Ok, thanks for clarifying that with the GlobalData.
I am not aware of any possiblity of controlling (from the user's/GUI side) how data is stored on nodes/reaches in the .res1d file.
But that means that the recommended way of extracting all Discharge data or WaterLevel data from a .res1d file still is
res1d.result_network.reaches.Discharge.add()
Q = res1d.read()
res1d.result_network.reaches.WaterLevel.add()
WL = res1d.read()

(if I don't want to use res1d.read_all() which can get quite big).
Any possiblity to read all Discharge data at a specified timestep?

Re: Filtering on read:
Yes, typically it works to load the entire file (or all timesteps for a specific quantity), and the filter the resulting dataframe. Just wanted to see if it can be optimized (where we run model ensembles where files potentially are on network drives).

Hi, to do that you can try:
res1d = Res1D(file_path)
res1d.result_network.nodes.WaterLevel.add()
res1d.result_network.reaches.WaterLevel.add()
res1d.read()

Thanks for the help @gedaskir, it worked well for me.


fix registers edge cases

https://github.com/edenlabllc/ehealth.api/issues/2839

Coverage decreased (-0.02%) to 90.269% when pulling 8edd9cd7b3071c8c2f18fe778a76b75ea982bba7 on fix_registers#2839 into ed5ea698c3a3bc97df4a5f35bd4a878b460c3ad4 on develop.


About some questions

Could I contact you through this email<EMAIL_ADDRESS>to ask you any more questions about the implementation of this project?

Hi Lucia-Rubio-E,
You're welcome to contact me at the email address 34400mt_at_gmail.com with any questions you may have.
Alternatively, if you're comfortable with it being public, please don't hesitate to open an issue on this GitHub repository and ask your questions there.

Hi Lucia-Rubio-E,
I've created a standalone version of the server, so I'm going to archive this repository. Here's the link to the new repository: link.
Take a look whenever you have a moment.


Document the concept of Groups and Roles

The new APIs introduced via https://github.com/wso2/product-is/issues/8123 are documented in the API docs at [1]. But the concept of role and group separation [2] is not properly documented.
[1] https://is.docs.wso2.com/en/latest/apis/scim2-rest-apis/#/Roles Endpoint/getRole
[2] https://medium.com/identity-beyond-borders/manage-groups-and-roles-with-wso2-identity-server-5-11-0-onwards-93d42fe2f135

Need to document on the config to enable group role separation as well.
[authorization_manager.properties]
GroupAndRoleSeparationEnabled = true

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!

This is somewhat explained in the below docs
https://is.docs.wso2.com/en/latest/guides/users/manage-roles/
https://is.docs.wso2.com/en/latest/guides/users/manage-groups/


Breaks when filename has spaces

e.g.: Observable + Operations.swift breaks the plugin
See here: https://travis-ci.org/RxSwiftCommunity/RxViewModel/builds/142914303

Unrecognized arguments: "Categories/Observable", "+", "Operations.swift"
[!] Invalid `Dangerfile` file: A JSON text must at least contain two octets!. Updating the Danger gem might fix the issue.
 #  from Dangerfile:27
 #  -------------------------------------------
 #  # Run SwiftLint
 swiftlint.lint_files
 #  -------------------------------------------

I resorted to renaming the file for now but thought it was a good idea to at least bring this issue to light.

Should be fixed in #9

I can confirm it works because i've been using the fork from #9 since i first created this issue 👍
Thanks


Plugin pattern: Router with opt-in upgrades (DO NOT MERGE)

Introduces PluginRegistry and RouterOptInUpgrades.
PluginRegistry.sol

Similar to PluginMap; maintains a map from fn selector -> plugin contract.
This map can be updated by a PLUGIN_ADMIN_ROLE role holder.
Contains the function isApprovedPlugin which returns true if the concerned plugin exists in the plugin registry's map.

function isApprovedPlugin(bytes4 functionSelector, address plugin) external view returns (bool);

RouterOptInUpgrades

Inherits Router with the following condition in _canSetPlugin:

    /// @dev Returns whether plug-in can be set in the given execution context.
    function _canSetPlugin(bytes4 _functionSelector, address _plugin) internal view virtual override returns (bool) {
        return
            hasRole(PLUGIN_ADMIN_ROLE, msg.sender) &&
            PluginRegistry(pluginRegistry).isApprovedPlugin(_functionSelector, _plugin);
    }

The plugin pattern has since been revised, and is now the Dynamic Contracts standard, which can be found in this repository.


use React.forwardRef

This probably doesn't work yet, but I'm waiting for an enzyme adapter release so I can actually test the functionality.

@gaearon when you get some time, could you take a look at this PR? I'm feeling a bit conflicted at how the ref forwarding is implemented. Since the React.forwardRef API introduces an interim component, there's some backflips happening to maintain things like letting the consumer set defaultProps and then doing referential checks against them, etc.
It seems like this API maybe should have been implemented as a decorator.

WeakMap isn’t guaranteed to be polyfilled
On Thu, Aug 23, 2018 at 3:32 AM Phil Plückthun<EMAIL_ADDRESS>wrote:

@kitten commented on this pull request.
In src/utils/isDerivedReactComponent.js
https://github.com/styled-components/styled-components/pull/1923#discussion_r212224159
:

@@ -0,0 +1,22 @@
+// @flow
+import { Component } from 'react'

+const cachedResults = new Map()
@probablyup https://github.com/probablyup You probably would use a
WeakMap. I've seen it's used for attrs which sticks around since it's
never not present (and thus GC'd), but just to be sure I'd still use it :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/pull/1923#discussion_r212224159,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1viLTCzBK4bMtzCh7uxQvnoa1A84ks5uTmiLgaJpZM4V_N-l
.


Frontend Test Cases for Login/Register

Removed unnecessary files from chutzpah

Used Selenium IDE plugin to run testcases for login and register on CUSE website

Exported test cases  generated by Selenium as C# files

Need to add the necessary dependencies such that the frontend tests can be run within Visual Studio

#27

Unnecessary files were removed
Frontend tests were added for login page
Frontend tests were added for register page


[3pt] Update 3DEP DEMs

Based on the findings in #1257, we should update our DEMs from the USGS 3DEP service to ensure we're using up-to-date data.
Instead of doing a full domain download and replace, it may be better to take a targeted approach to only download the areas that have been updated. Here's an example of a way we could accomplish that.
aws s3 ls s3://prd-tnm/StagedProducts/Elevation/13/TIFF/current/ --recursive

We can not download just one part, well... not easily.  We have our tool to download DEMs but it does a handful of other things such as some cropping, downloads with critical params, creates polys and the vrt.  You really can not replace just small parts.  It is pretty easy to run our acquire 3dep script and isn't overly slow on a prod machine.  I can kick off a full new set in the next few days.

That's probably a better choice anyway to make sure we don't accidentally miss any files.

ya. and with the critical other download args we need and post download processing, you would find is it incredibly difficult to do it without our acquire tool. There is more processing in our tool than one might think.  The hardest part of any input  changes is not the acquire, it is the processing and careful process of getting all right files, vrts, dems and poly's to all 5 / 6 environments at the right time. ie) Hopefully not overwriting anything. :)

We should revisit #887 with the new DEMs

Good point. When I have this done plus the pre-clips, we can recheck this before merge.


Add GET argument 'mod' to filter on module, i.e. 'str=hd&mod=stdlist'

Eventually you'd want this to happen from within $_GET['str'], but for people who directly use the API (like me) this is useful functionality.

I propose to not make this case sensitive. And to make it into a comma separable list so that you can select from multiple modules

Thanks for this.
It seems it would be more efficient to only search in the relevant modules, instead of filtering afterwards.
We should also consider names. I have a slight preference for module over mod; it is less ambiguous -- also longer though.

mod is fine, the api will be documented and does not necessarily needs to be very human readable.

Should also consider lib, by the way, but that's for some other time.

Library is too amiguous. What are libraries. StdEnv, StdLib, Generics?
What about lean-platform? clean-platform/Data.List?

It is already case insensitive.

Yeah, this is a problem with libraries. We should look into combining cloogle with some kind of project manager which has a clear idea about libraries. I didn't look into clean-scrub yet, but perhaps that could be an idea.

I suggest we not make it monolithic and dependant on external projects. There is no clear notion of libraries in clean. Just modules, let's keep it that way.
The only notion of libraries is the toplevel directory, clean-platform, StdEnv, Generics would be libraries then.

Thanks for the title change @camilstaps, and you're right about moving filtering prior to actually searching.

The toplevel isn't well-defined: "a subdirectory of $CLEAN_HOME/lob" doesn't allow for external libraries later; could use "any directory that holds modules", but that would be e.g. "OS-Independent" which is not what you'd want. This requires some more thought, I think.

In a range commits (aea97ceab7d2c1adbc464bfcb19d1b9a863a068c to fcad475), I moved the backend largely to Clean and added type search (this is what the types branch was originally intended for).
That means that starting from those commits, mod is no longer supported. It will be back, but should be handled in Clean. The idea is that the PHP script is just a wrapper from now on.
If you need mod, you should work from 6951a3534603b4341075ae8b747d60478a9b9ca7.

@KDercksen as you can see in the above commit, ?mod is back. The PHP interface uses a comma-separated list as before. The CloogleServer expects that you add an array modules to your request, so for example it may look like this:
{"name":"test", "unify":"", "modules":["testable", "confSM"]}

The frontend does not support this feature yet.

Looking at the Clean code, the 'modules' key is not mandatory like 'name'/'unify', correct? i.e. I just need to supply it when I want to filter and leave it out otherwise?

@KDercksen correct.

Related and now also supported: ?lib on api.php or the libraries key for the Clean backend: an optional comma-separated / JSON list with libraries. Substrings match, e.g. Std matches both StdEnv and StdLib. See backend/builddb.icl (line 54-93) for a list of included libraries.


⚠ Jenkins Plugins Artifactory has degraded performance

In 0eb0ba6, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1132 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 97273d2 after 12 minutes.


Twitter icon directs to wrong place

When I click the Twitter icon in the footer it should take me here:
https://twitter.com/TheDMPTool
Currently it goes to #dmptool

looks good. closing.


make ether payments "on pull" because of 2300 gas limit

The instantaneous / "on push" ether payment in the contract currently is a nice feature, but unfortunately this would make it impossible to send ether to the contract from many apps because of the default 2300 gas limit for simple transactions.
One solution is to add a payable function that does what the receive function currently does. The splitAndWithdrawUnsentEther function might become unnecessary.

fixed
btw I think the default gas fee is actually 23000, not 2300, based on my local tests.


WASM Brotli

We should investigate using this - https://github.com/dfrankland/wasm-brotli. Having to compile at the moment is slow, and a lil annoying haha.

Tried running this with a static server, but it seems it doesn't work as expected. Probably an issue with wasm-brotli 😢
var http = require('http')
var path = require('path')
var fs = require('fs')

http.createServer(function (req, res) {
  res.writeHead(200, {
    'Content-Type': 'text/html',
    'Content-Encoding': 'br'
  })

  fs.createReadStream(path.join(__dirname, 'index.html.br'))
    .pipe(res)
}).listen(8085, function () {
  console.log('listening on 8080')
})

Yep, there definitely seems to be some issue with compress.
Just adding changing 1 character in a string can break it apparently. Take a look at the example below:
const { compress, decompress } = require('wasm-brotli');

const badHtml = `
  <!doctype html>

      <title>Testing!</title>

Hello, world!

`;

const goodHtml = `
  <!doctype html>

      <title>Testng!</title>

Hello, world!

`;

(async () => {
  await Promise.all([goodHtml, badHtml].map(async (content) => {
    try {
      const buffer = Buffer.from(content, 'utf8');
      const compressed = await compress(buffer);
      const decompressed = await decompress(compressed);
      const newContent = Buffer.from(decompressed).toString('utf8');
      console.log(`This one works!\n${newContent}`);
    } catch (err) {
      console.error(`This one failed!\n${content}`);
    }
  }));
})();

The only character that is changed is the i in Testing!.

thanks for digging into this @dfrankland! for reference, looks like this was the core issue: https://github.com/dropbox/rust-brotli/issues/15

I fixed the bug in brotli: can you update the crate to 1.1.1 and try again?

I've ran a couple of tests with<EMAIL_ADDRESS>and everything seems to work now that it includes the<EMAIL_ADDRESS>crate (thank you @danielrh).


way to fast estimate area?

Hello,
Anyone know how to fast estimate area for specific memory size? I found the process of generating a memory size bigger than 1kB takes more than 1 hour. How about if I just to want to get an estimated area value and no requirement of having a gds file. Is there any option can be used?
Kind regards,
Jiacong

If you disable the power routing, disable DRV/LVS, and disable characterization it will be very quick.
route_supplies=False
check_lvsdrc=False
analytical_delay=True

If you disable the power routing, disable DRV/LVS, and disable characterization it will be very quick.
route_supplies=False check_lvsdrc=False analytical_delay=True

Thanks a lot!


Improve Navigation Layout and UX Enhancement

Improve Navigation Layout, Responsiveness and UX Enhancement
Redesign the layout of navigation to improve the UX and responsiveness of our navigation system while ensuring seamless integration with translations.
Key Enhancements:

Navigation Layout Redesign:

Revampe the navigation layout to provide a more visually appealing experience.
Optimise the spacing of Navigation elements to improved clarity and ease of use.

Improve Responsiveness:

Improve the Responsiveness to ensure layout is accessible on various devices.

Apply the Changes to all Translation:

Test the changes to ensure compatibility with translations.

Improved UX by adding some animation:

Add Animation for enhancing user experience.

https://github.com/expressjs/expressjs.com/assets/163371960/0b81f767-7bf9-4dac-8888-e75756fcf3d0
Screenshots

Desktop Navigation

Mobile Navigation (iPhone 8 Plus)

Dark and Light Theme

Dark Theme

Light Theme

Thanks for @OmkarSonawane1230. A quick look over a few of the changes and I found a few things to comment on.

Changing the break-point for the menu to @media all and (max-width: 1060px). It works better the way it is now. I don't think this works, or is an enchantment.

Using the new break point size you added above, opening the new arrow drawers above 899pxsize, they snap closed right away after opening. Anyway, at this point we'd have the navbar showing anyway (like does now), but just wanted to let you know. I'm testing on Mac chrome and FF.

And the auto highlighed nav-links feature that shows the current page in dark grey, and then also adds grey highlights on hover. This is just too busy to fit the current UI. Might be too drastic?

Overall this is just too many file changes all at once and too many unsolicited changes. I didn't go through every single feature you suggested, and there might be some good stuff , but a better way might be to suggest a change or two individually first, and then once they've been approved you can implement them. This would make it much easier to review too, dealing with less files and changes at once. And also, if the change isn't approved, it saves you the the time of working on it.
For example, just navbar itself could perhaps benefit from a revamp. Just this alone might be one PR.
This is just my 5 cents. What do you think of that @crandmck?

Hi @chrisdel101, Thanks for taking the time to review my pull request. I appreciate your feedback and suggestions for improving the navigation. I want to highlight some points you mentioned.

Changing media query, I have to change them because after updating the navmenu, spacing, sizing and search bar position in navbar, all the element don't fit in size below 1060px, that the reason I change 899px break point.

Yes, I agree with this point, I tested it as you mention how I snap right after the click, but it happens in range between 899px - 1060px maybe because of previous layout was build to work with 899px break point. It could be solve by changing the style made for 899px break point, although there is no problem for below 899px.

I agree that the UI changes are to much for current UI, but my I idea is to redesign the Expressjs.com. I decided to do following things.

Improve overall UI.
Make the documentation well formatted.
As you are adding the blog feature, I think that we should also add a 'Help desk', where developer and tell their problem regarding the development. on basis of that problem we will able find more issues.

@crandmck and @chrisdel101
I believe these improvement and features will make Expressjs.com not only a website, but a Developer hub. Please let me know what you think about my idea.

Thanks @OmkarSonawane1230 for the PR, and thanks also @chrisdel101 for reviewing it.
I agree with @chrisdel101 that there are a lot of changes in a single PR.  In general it's best if a PR addresses an existing issue which has ideally had some prior discussion.  This one is a bit "out of the blue" and objectively it's not entirely clear what it accomplishes.

my I idea is to redesign the Expressjs.com. I decided to do following things.

I appreciate the sentiment and enthusiasm, and while the site is not perfect by any means, it's not clear that it needs a complete redesign, and there are other issues with the content (vs. layout/design) that are higher priority IMO.

Improve overall UI.

Hard to argue with that, but what specifically needs to be improved and why?  "UI improvement" can often be a matter of opinion and IMO should be the result of a collaborative & comprehensive design effort.

Make the documentation well formatted.

What does this mean?   It seems well formatted to me, but this could mean almost anything.

As you are adding the blog feature, I think that we should also add a 'Help desk', where developer and tell their problem regarding the development. on basis of that problem we will able find more issues.

This is a big change, and would require discussion by the @expressjs/express-tc.  The biggest issue that I see is that the TC and project collaborators more broadly have more than enough on their plate already trying to release 5.x and definitely don't have time to act as a "help desk" to the entire Express community, as much as we might like to do that.
I'm open to the idea of a redesign in general, but I'd like to understand the value added, beyond qualitative or purely subjective rationale.
I'm going to close this issue, but I'm open to considering INCREMENTAL changes along these lines in the future. I would ask that you open issues in the repo identifying specific, well-defined problems or deficiencies and then open PR(s) to address those...  This will just make it easier for us to manage the changes and ensure that they improve the overall quality of the documentation.
@OmkarSonawane1230 I do appreciate your efforts and I don't want to discourage you, but I hope you'll understand that we want to stay focused on improving the overall quality of the documentation, and not making sweeping changes without due diligence.


feat(frontend): report slow query in the log

Signed-off-by: Bugen Zhao<EMAIL_ADDRESS>I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title. This can be helpful for us to debug timeouts in CI.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#6617

If we only want it in debug, do we need to add different implementation in release mode?🤔 (Do we have different complie mode like 'debug' and 'release'

Do we have different complie mode like 'debug' and 'release'

Yes, like ci-dev ci-sim ci-release. However, we'll only deliver the release profile without debug assertions in production, so we can rely on the condition of cfg(debug_assertions).

The simulation recovery test panics here. Interesting. 🤔
https://github.com/risingwavelabs/risingwave/blob/15030ea76be219a5a2bd64ad28527852ded1a724/src/frontend/src/scheduler/distributed/stage.rs#L432-L436

The simulation recovery test panics here. Interesting. 🤔
https://github.com/risingwavelabs/risingwave/blob/15030ea76be219a5a2bd64ad28527852ded1a724/src/frontend/src/scheduler/distributed/stage.rs#L432-L436

Is there madsim number to reproduce? I can have a look


Update Metadata Flow to use secure more Hash

DevEx/OpEx
The metadata flow is currently using the built in Java hashing, but this can be reversed and isn't a secure way to have the message stored at rest.  Need to make a small code update to implement a secure, non-reversible hash
Tasks

[ ] Something.

Additional Context
Add any other context or screenshots about the work here.

Is this for the order hash? It was left like that on purpose because we don't have the original order hash and the one we're creating can't be use to verify the message integrity. So it's more of a placeholder for now until we can get the actual order has from RS (created from the original order coming in)

Today, in our order and result usecase, we call order.hashCode() or result.hashCode().  This is not a cryptographically secure hash.  Instead we should use SHA2-256, SHA2-512, or even better, a SHA3-256 or SHA3-512 hashing algorithms.
Unsure if there is built-in support to generate these hashes in Java.  If not, then we'll need to make a "humble object" that wraps the third-party library.

Looks like there is support in Java since 11
https://docs.oracle.com/en/java/javase/11/docs/specs/security/standard-names.html#messagedigest-algorithms

I added a comment on Jan 31st about why it doesn't make sense to make this has code more cryptographically secure. How are we planning to use this hash? Is RS going to use it to verify the message coming from us?


Issue-744: Support for ExpireSnapshot functionality on top of cherrypick

This PR implements the stuff discussed on Issue https://github.com/apache/incubator-iceberg/issues/744

@mehtaashish23 we should redirect this PR against master so Apache committers can review this.


Updating to latest v0.7.0 changes

fixes #463
Regenerated the pre-packaged html to reflect the latest in the main repo: b9eee39

Adds Message signing
Adds Show QR brightness tips

ACK and Tested

ACK tested


Add changesets GitHub Action #31

Inspiration from https://github.com/changesets/action#without-publishing


Is there training code for the generator?

please see https://github.com/bytedance/1d-tokenizer?tab=readme-ov-file#training for instructions on generator training