[v2.0.x] Solved a couple Android build errors

Description
This pull requests suggests changes to a couple of files that are used to configure and build this cordova plugin.
Related Issue
[v2.0.x][Android] Multiple build errors #1381
Motivation and Context

This change solves the following two Android build errors, which came up running cordova buid android on a private cordova project of mine which uses this plugin.
First error

FAILURE: Build failed with an exception.
What went wrong:
Execution failed for task ':transformClassesWithDexForArmv7Debug'.
com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.dex.DexException: Multiple dex files define Landroid/support/v4/accessibilityservice/AccessibilityServiceInfoCompat$AccessibilityServiceInfoVersionImpl;

Second error

FAILURE: Build failed with an exception.
What went wrong:
Execution failed for task ':transformClassesWithDexForArmv7Debug'.
com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.dex.DexException: Multiple dex files define Lcom/google/firebase/FirebaseException;

In depth
The actual meaning of these errors, how I found them, and how I got to the solution I am proposing can all be found explained in depth in the related issue #1381.
How Has This Been Tested?

I ran the npm tests on this repository (as specified by the CONTRIBUTING document), and also tested the plugin with the proposed changes on a cordova project of mine.
Npm tests
I ran npm test before and after making the changes in this repository, and the results were successful (I did not add any new tests, though).
Testing on my cordova project
I added this plugin's v2.0.x branch with the proposed changes to my cordova project, and tried building (cordova build android) and running the app (cordova run android) on a physical Android device, making sure that the phonegap plugin was functioning correctly.
These tests were successful as well.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@JaimeFerBec Thanks!


WorkVersion's published_date is a singular field and validated

WorkVersion#published_date is currently a multi-value field. We agreed in #101 that it should be singular.
Todo

[x] Determine how many legacy ScholarSphere works have multiple values in this field.
[x] Figure out how we're going to reduce those multiple values into a single one when we port the data over
[x] Make WorkVersion#published_date a singular field

Bonus Todo?

[x] Enforce a standard format for storing dates as strings (date-picker on UI?). @srerickson suggests ISO8601, but will this handle every scenario we need to address?
[x] Validate that published_date is both present and in the correct format when a WorkVersion is published
[x] Ensure that the Solr document/indexer can properly "explode" an imprecise date out into a date range, e.g. "2019" becomes "2019-01-01 00:00:00" - "2019-12-31 23:59:59" (Ryan did this in CHO for EDTF dates. Yoink that code?)

Open Questions

Does ISO8601 cover all the use cases that we have?

WDLL

make published_date a singular field
validate field as an ETDF-type date field
incorrect or non-EDTF dates will save but prevent the record's publish action
index published_date into  Solr as an "exploded" date range (like we did in CHO)
for migration, multiple values will be concatenated and the resulting record will remain in draft status until fixed

Remaining Questions

Is published_date required for publishing?
Do we want a datepicker or just leave it as a text field?


fix(update): Remove references to -p in help

Missed these in #12545

Thanks!
@bors r+

:pushpin: Commit 66f0b13d4769118646f28e952e6456cdadb1788a has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 66f0b13d4769118646f28e952e6456cdadb1788a with merge 87a14ed1c651a09d6c0bde9f955e1b2b2bbd3e3b...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 87a14ed1c651a09d6c0bde9f955e1b2b2bbd3e3b to master...


Clicking on browser/system back button takes user back two steps

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to workspace > reimbursements > Connect bank account > Connect manually
Click on the browser/system back button

Expected Result:
App should take user one step back
Actual Result:
App takes user two steps back
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/28d58f8a-208d-4e37-ab18-b0b64ef87f4d
https://github.com/Expensify/App/assets/43996225/cd4d9763-44a8-4f4c-a811-95dd5a8be933
Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686817579048109
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Going back with browser button instead of header back goes back "2 views", in other words, returns to ReimbursementPage instead of BankAccountPage
Note: It
What is the root cause of that problem?
BankAccountStep component has something called substeps stored in the onyx key REIMBURSEMENT_ACCOUNT.achData.subStep
https://github.com/Expensify/App/blob/6183609c577f2310928bb4e8ee23b52f6dd28e00/src/pages/ReimbursementAccount/BankAccountStep.js#L61C1-L79C1
Since this navigation is managed on memory pressing back in the browser/android back button goes back in the React Navigation stack, hence going back from BankAccountStep to ReimbursementAccountPage. Pressing in the navigation header back goes through a custom code in ReimbursementAccountPage:
https://github.com/Expensify/App/blob/6183609c577f2310928bb4e8ee23b52f6dd28e00/src/pages/ReimbursementAccount/ReimbursementAccountPage.js#L276C1-L290C18
This is why it works pressing on it, it just cleans de REIMBURSEMENT_ACCOUNT.achData.subStep key from Onyx
What changes do you think we should make in order to solve the problem?
So to be clear this seems like a "desired" behavior so there are 2 possible solutions:

Refactor the code of the substeps and turn BankAccountStep into a mini Stack inside ReimbursementAccountPage or RHP. This might take some effort due to all the lines included in the goBack method, with a high chance of regression:
https://github.com/Expensify/App/blob/6183609c577f2310928bb4e8ee23b52f6dd28e00/src/pages/ReimbursementAccount/ReimbursementAccountPage.js#L276C1-L290C18
@mountiny @marcochavezf I think I know have found two possible use cases of my proposal in https://github.com/Expensify/App/issues/20558 basically I could implement the library of BackButtonUtils so generic that it could allow this special use cases of navigation: going back to substep, going back to public room . Or any other special scenario to work. This can be found in the original PR. And then it wouldn't be a single resp code and could be useful in other special navigation scenarios. Calling a specific handler in two places: 1. SignInPage 2. BankAccountStep

cc. @WoLewicki
What alternative solutions did you explore? (Optional)
N/A both discussed in the proposal

@gedu will be working on refactoring this entire flow
@anmurali could we make the Tiered bank account tracking issue public otherwise its hard to link for contributors?
@gedu Would you be able and want to work with @daordonez11 on making sure the flow is made from individual stack screens to ensure the navigation works as expected?

Yeah, it seems like the same issue as with Request Money flows, where the steps were not connected to the navigation. So if we want to refactor it, I think there is nothing to add from my side. Also, hijacking Back button won't still solve the browser back button scenario on web, or am I missing something @daordonez11 ?

Right @WoLewicki it was lack of knowledge form my side. Definitely if everything will be in the stack hijack is not necessary. It could be a workaround in case there is custom navigation inside of the app. I don't know if there are other places but definitely is just a patch solution.

@gedu want to make sure you have seen this and will factor this into your detailed design considerations for https://github.com/Expensify/Expensify/issues/289050. Can you give me a 👍 here to make sure?
(@vitHoracek I am trying to transfer https://github.com/Expensify/Expensify/issues/289050 to App repo, stay tuned)

I am going to close this because we will handle this in the VBBA refactor as commented earlier

Isn't this eligible for reporting bonus since the report has contribution @anmurali

Probably not in this case because we had plans to fix this with the refactor anyways. Thanks for raising this though!


Fix typo in README

What type of PR is this:
/kind documentation
/area documentation
What does this PR do / why we need it:
Small typo in README
Which issue(s) this PR fixes:
—
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[x] Documentation

How to test changes / Special notes to the reviewer:
—

/override windows-integration-test
/lgtm
/approve

/override windows-integration-test/Windows-test


Yum dependency and Amazon templates

Yum dependency 3.0.0 in metadata is very old. Updated to a more recent one.
Add amazon templates (equal to the centos ones).

Thanks!

Thanks for accepting it!
Can you please bump the metadata version?
Cheers,
João
On Fri, Mar 27, 2015 at 4:15 PM, Daniel Givens<EMAIL_ADDRESS>wrote:

Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/dgivens/chef-lsyncd/pull/8#issuecomment-86992703.

Already did and published it to the supermarket


--no-pull ask for wrong image from profile setting

I have image image = "jusong/aiidalab:x86-stable" setting in profile but when I try to start aiidalab it shows Unable to find container 'aiidalab_impish' where impish is the profile name.

Close since after update to latest version I encounter another issue.


uv offers wrong Python when inside Docker with Rosetta in AMD linux on Mac ARM

The situation is a bit special: I usually work on devcontainers. Sadly, there are still many packages that do not have support for ARM architecture. Thus, many times I end up within a Docker container running rosetta since my Mac is sillicon.
Minimal Example
# devcontainer/Dockerfile
FROM --platform=linux/amd64 mcr.microsoft.com/devcontainers/base:jammy

# Install uv
COPY --from=ghcr.io/astral-sh/uv:0.4.29 /uv /uvx /bin/

// devcontainer/devcontainer.json
{
    "name": "minimal",
    "build": { "dockerfile": "Dockerfile" },
    "workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
    "remoteEnv": {
        // Ensure venv is always first in PATH
        "PATH": "${containerWorkspaceFolder}/.venv/bin:${containerEnv:PATH}",
    },
    "remoteUser": "vscode",
}

To reproduce you will need:

A Mac with AppleSillicon
VSCode with the devcontainer extension installed
Docker in your machine

Then, open the command palette of VSCode (if not directly prompted) and "reopen in container".
Once it builds, if I go to the terminal and run:
$uv python list

cpython-3.13.0+freethreaded-linux-aarch64-gnu    <download available>
cpython-3.12.7-linux-aarch64-gnu                 <download available>
cpython-3.11.10-linux-aarch64-gnu                <download available>
cpython-3.10.15-linux-aarch64-gnu                <download available>
cpython-3.10.12-linux-x86_64-gnu                 /usr/bin/python3.10
cpython-3.10.12-linux-x86_64-gnu                 /usr/bin/python3 -> python3.10
cpython-3.10.12-linux-x86_64-gnu                 /bin/python3.10
cpython-3.10.12-linux-x86_64-gnu                 /bin/python3 -> python3.10
cpython-3.9.20-linux-aarch64-gnu                 <download available>
cpython-3.8.20-linux-aarch64-gnu                 <download available>
pypy-3.10.14-linux-aarch64-gnu                   <download available>
pypy-3.9.19-linux-aarch64-gnu                    <download available>
pypy-3.8.16-linux-aarch64-gnu                    <download available>
pypy-3.7.13-linux-aarch64-gnu                    <download available>

As we can see, it finds the AMD arch python that comes pre-installed but everything else it offers is ARM. Thus, nothing works because it crashes when trying to use any of these pythons because they have the wrong architecture. For reference, this is the error:
$uv sync

error: Failed to query Python interpreter at `/home/vscode/.local/share/uv/python/cpython-3.11.10-linux-aarch64-gnu/bin/python3.11`
  Caused by: No such file or directory (os error 2)

I am not sure if I am installing uv wrong somehow or if I can do something to direct it to the right arch. Any help will be super appreciated, thank you!

The logs with verbose (if I understand correctly how to get them):
$ uv sync -v

DEBUG uv 0.4.29
DEBUG Found project root: `/workspaces/minimal`
DEBUG No workspace root found, using project root
DEBUG Reading requests from `/workspaces/minimal/.python-version`
DEBUG Searching for Python 3.11 in managed installations or system path
DEBUG Searching for managed installations at `/home/vscode/.local/share/uv/python`
DEBUG Found managed installation `cpython-3.11.10-linux-aarch64-gnu`
DEBUG Failed to inspect Python interpreter from managed installations at `/home/vscode/.local/share/uv/python/cpython-3.11.10-linux-aarch64-gnu/bin/python3.11`
error: Failed to inspect Python interpreter from managed installations at `/home/vscode/.local/share/uv/python/cpython-3.11.10-linux-aarch64-gnu/bin/python3.11`
  Caused by: Failed to query Python interpreter at `/home/vscode/.local/share/uv/python/cpython-3.11.10-linux-aarch64-gnu/bin/python3.11`
  Caused by: No such file or directory (os error 2)

And running the command you suggest:
$ uv sync -p cpython-3.11.10-linux-x86_64-gnu -v

DEBUG uv 0.4.29
DEBUG Found project root: `/workspaces/minimal`
DEBUG No workspace root found, using project root
DEBUG Searching for cpython-3.11.10-linux-x86_64-gnu in managed installations or system path
DEBUG Searching for managed installations at `/home/vscode/.local/share/uv/python`
DEBUG Found managed installation `cpython-3.11.10-linux-aarch64-gnu`
DEBUG Failed to inspect Python interpreter from managed installations at `/home/vscode/.local/share/uv/python/cpython-3.11.10-linux-aarch64-gnu/bin/python3.11`
error: Failed to inspect Python interpreter from managed installations at `/home/vscode/.local/share/uv/python/cpython-3.11.10-linux-aarch64-gnu/bin/python3.11`
 Caused by: Failed to query Python interpreter at `/home/vscode/.local/share/uv/python/cpython-3.11.10-linux-aarch64-gnu/bin/python3.11`
 Caused by: No such file or directory (os error 2)

Let me know if there is anything else I can do to provide more info.

I think it's a bug, in that when we fill the platform information at
https://github.com/astral-sh/uv/blob/893257bb0b2a0df4196410f279d5a837effafee0/crates/uv-python/src/downloads.rs#L192-L194
and
https://github.com/astral-sh/uv/blob/2b0e16cb75911bc291c92f7186512223c2d2d899/crates/uv-python/src/platform.rs#L76-L78
we think it's aarch64 instead of x86_64. I'm not really sure why yet.
You could put that full version tag in a UV_PYTHON environment variable and we should respect it.

Are you copying uv from the right image?
https://github.com/astral-sh/uv/pkgs/container/uv/298017082?tag=latest

Agreed with @zanieb. Usually you'd pass --platform to your docker buildx build --platform=linux/amd64 -t foo-linux-amd64 /path/to/context to resolve this as it will then pick the right manifest entry.
That would allow you to cleanup the Dockerfile
# devcontainer/Dockerfile
FROM mcr.microsoft.com/devcontainers/base:jammy

# Install uv
COPY --from=ghcr.io/astral-sh/uv:0.4.29 /uv /uvx /bin/

Alternatively would be using raw sha
# devcontainer/Dockerfile
FROM --platform=linux/amd64 mcr.microsoft.com/devcontainers/base:jammy

# Install uv
COPY --from=ghcr.io/astral-sh/uv:0.4.29@sha256:c17127bc372350d61bae20be54c85540a8937eaa691c61840a7abc80e284fc8d /uv /uvx /bin/

On VSCode, you may be able to do this by leveraging devcontainers extension build.options setting. e.g.
    "build": {
        ...
        "options": [
            "--platform=linux/amd64"
        ]
    },

We should add some notes to the documentation about using cross-platform images.

It does seem I might have been using the wrong uv using a naive copy. I would still have expected that to work but using curl is an option and does seem to solve the issue. Thank you very much for the help!


Task list research update

@amyhupe and I updated the task list research section to:

include important updates shared in the community backlog discussion on GitHub
validate a new approach to formatting the research sections based on what users told us they wanted to see there

You can preview this change here:
Built with commit 11233f3631d1feacffeefc95d346f4f12c39c584
https://deploy-preview-573--govuk-design-system-preview.netlify.com


Junaed/fssdk 10198 odp not integrated error

Summary
If the project does not have ODP integration enabled, sdk should not call the fetchQualifiedSegments method.
Test plan
Existing test should pass
Issues
FSSDK-10198

Looks like this https://github.com/optimizely/react-sdk/pull/262 would resolve the issue


Add support for creating a namespace and installing a module into it in a single command

Per discussions with HSOPS, we're asking for the possibility of creating a namespace and corresponding database into which a module can be installed as part of the same command that loads/installs the module. The namespace name, global, routine, and code database names and locations should all be configurable by the user via flat file.

This issue goes away with CPF merge as the language for configuration, using https://docs.intersystems.com/iris20243/csp/docbook/DocBook.UI.Page.cls?KEY=RACS_execute to call in to IPM.


How to use

Ffs this library is so bad! How to use this?
K thx bai

Dont point the finger on others if you cause the problem yourself.

Calm down, the guy is my mate


Adding support to enable pipelineSpec

Changes
Its now possible to embed the whole pipeline specification into Pipeline Run
using pipelineSpec, for example:
apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: pipelinerun-echo-greetings
spec:
  pipelineRef:
    name: pipeline-echo-greetings

Can be specified as:
apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: pipelinerun-echo-greetings
spec:
  pipelineSpec:
    tasks:
    - name: echo-good-morning
    ...
    params:
    ...

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.
Release Notes
Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

/ok-to-test

/assign pritidesai

/retest

/lgtm

/lgtm

/hold
I've added this as an agenda item to discuss during tomorrow's Working Group meeting. I think it would be useful to raise the profile of this change a little bit just to make sure that everyone is aware of the change and its meaning prior to merge.

/hold
I've added this as an agenda item to discuss during tomorrow's Working Group meeting. I think it would be useful to raise the profile of this change a little bit just to make sure that everyone is aware of the change and its meaning prior to merge.

hey @sbwsg, have created a doc here, let me know if you want to add anything specific (still editing).

@pritidesai This is perfect, thankyou. I've added links to this design doc to the WG agenda so people can review before and during the meeting.

/lgtm

/lgtm
I guess the hold label can be cancelled now that we've discussed this in the working group meeting?  @pritidesai want me to remove it?


cs1002 error

Description
When I try to set InstancePerEntity for a globalNPC, it says it's missing a semicolon, when I clearly included a semicolon. I even copy and pasted the one from the exampleGlobalNPC and it did an error.
Steps to Reproduce

Make a new globalNPC class
Put this code within the class: public override bool InstancePerEntity => true;
Run tmodloader and try to build the mod

Expected behavior
It SHOULD be completely fine but it gives a semicolon error when there is clearly a semicolon
Actual behavior
It won't compile because it doesn't think there is a semicolon there when there is one clearly there
Reproduction frequency
Every time
Versions
tModLoader v<IP_ADDRESS>
Mods
N/A, won't get past building screen for custom mod
Additional Information
C# language is 4
Full code:
using Microsoft.Xna.Framework;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using Terraria;
using Terraria.ModLoader;
using Terraria.ModLoader.IO;
using Terraria.Utilities;

namespace Set8
{
    public class GlobalOneNPC : GlobalNPC
    {
        public override bool InstancePerEntity => true;

        public bool sunburn;

        public override void ResetEffects(NPC npc)
        {
            sunburn = false;
        }

        public override void UpdateLifeRegen(NPC npc, ref int damage)
        {
            if (sunburn)
            {
                npc.life = npc.life - 5;
            }
        }
    }
}

Fixed in chat. The issue was the c#6 style code used in recent ExampleMod code. You can select the <IP_ADDRESS> tag while in github to see old style code for examplemod.


Github CI implemented for the repository

With this PR we will solve Scrunitizer problem and also the github ci. After merging this one, I will continue with PHP8 support branch with rebase on master

Maybe I don't understand something. You deleted version field, how composer know what is the version of the package?


Fix small bug in OrnsteinUhlenbeckProcessNoise

Summary: I believe the cache of the previously emitted noise observation was not being updated, so the get_noise function was just returning a normal distribution
Reviewed By: econti
Differential Revision: D8631964

I need to figure out why this PR was generated after the commit was made :-P


docs(ngAnimate) - Correct keyframe to keyframeStyle

Documentation for $animateCss says there is a keyframe property when in fact it is keyframeStyle

I signed it!

Ahah, believe the email on the commit is different. Should have fixed CLA now

Kind of linked to: #12340 Think it makes sense to go up at the same time

Merged in as https://github.com/angular/angular.js/commit/7202bfafcd0ad0059a5618e3c8abed7d45a77c65. Thank you.


Yorgos comments

Adding installations instructions

I edited the installation instructions a bit and re-ran the examples to make sure they work the same as before. These changes look good, thank you!
However, the pure Mann model fit example is now broken. I see that you changed the physical parameter configuration, which currently results in the following fit, that is clearly still suffering the same problems mentioned in #56

After this non-dimensionalization is fixed, maybe it would be better to combine the old example (with the configuration from the original DRD paper) with this new non-dimensionalization?

The first example now works properly with passing the correct reference height to the data generator, as in the following fit:

This fixes #56! I think this is good to merge now!


[ISSUE #3372]Add StorageResource for loading StorageResourceService

Fixes #3372
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Add StorageResource for loading StorageResourceService
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@xwm1992 @qqeasonchen @mytang0  PTAL~

@mxsm The storage module will be modified uniformly, and the current connector plugin will be replaced by the storage plugin as a whole. This pr modification does not need to be merged for the time being.

@mxsm The storage module will be modified uniformly, and the current connector plugin will be replaced by the storage plugin as a whole. This pr modification does not need to be merged for the time being.

@xwm1992  I will close this pr


Issue 126: Allow objects with non-data encoding iterators to be handled.

If an object is an iterator and also has its own data then the data won't be encoded, just the iterator. This PR adds a flag to ignore the iterator.
A better solution would be to encode both iterator and data.

(I'll add the CHANGES.rst entry after this is merged)

The more I think about this the more convinced I am that it isn't the correct approach. It is too broad a brush and will cause just as many problems as it solves.
Either need to support iters and dicts in the same class; or be able to specify on a per class basis (through a __jsonpickle attribute?) which attributes to include / exclude.
The latter one seems to be the best (and probably easiest to implement) as there are occasionally members of a class that you might not want to save / restore (e.g. temporary data)

The more I think about this the more convinced I am that it isn't the correct approach. It is too broad a brush and will cause just as many problems as it solves.

It's quite possible that that's correct, but we also can't let perfect be the enemy of good. If it's indeed the case that it causes more problems than it solves, then yeah it shouldn't be merged, but otherwise I think it would be useful to try it out.

Either need to support iters and dicts in the same class; or be able to specify on a per class basis (through a __jsonpickle attribute?) which attributes to include / exclude.

If I'm understanding what you mean by a "__jsonpickle attribute" (a dictionary attribute on the class + instance being pickled that maps attributes to booleans representing whether the attribute should be in/excluded), I don't think such an attribute would be the best immediate solution for that. A user can already customize the attributes that they want to be encoded/decoded by setting their own __getstate__() or __setstate__() magic methods on the class. I would definitely try to support both iters and dicts instead, as I don't believe there's a workaround for that. Maybe we could include such a __jsonpickle attribute later on, as I can see it being easier for beginners to make use of, especially since magic methods aren't well documented currently.

Maybe we could include such a __jsonpickle attribute later on, as I can see it being easier for beginners to make use of, especially since magic methods aren't well documented currently.

Agreed. We might want to call it e.g. _jsonpickle_fields to avoid the double-underscore name mangling and to leave space for future enhancement, but that's all stuff we can figure out later.
I'm very curious to see if there's code out there that would fail with ignore_iterator=True.
That said... I'm starting to slightly question this change slightly. Semantically, I would imagine that ignoring iterators would mean that we might encode them to None, but what we actually do is make it so that we include their attributes.
That makes me wonder whether we should name this parameter to better prepare the naming for future enhancement where we improve the iterator+data code path.
It's interesting that we currently blindly consume iterators and encode its data as a list, so it does seem like a future goal would be to have encoding of custom iterator data become the new default, and ideally even eliminating the emission of tags.ITERATOR if we can handle iterators and regular objects uniformly.
The code currently has two aspects that we want the name to reflect ~ the iter-to-list conversion and the custom iterator class + data aspect. Maybe a clearer name might be something like, include_iterator_attributes?
That name is also similar to the include_properties option we currently support, which is kinda nice as well.
This is just cosmetic though, so I approved this but we can still change this before (or even after) merging as long as we do it before tagging the next release.

Semantically, I would imagine that ignoring iterators would mean that we might encode them to None, but what we actually do is make it so that we include their attributes.

That's interesting, as I'd expect that ignoring iterators would mean excluding them from the result entirely. Maybe we should bikeshed the name more, as you're suggesting. I think include_iterator_attributes is accurate but a bit verbose for a parameter though, so maybe it might be better to call it include_iterator_attrs? I don't know if that'd be less clear to non-native English speakers though, I'll need to check with friends of mine who don't speak English natively first.
Overall, I'd wait on merging until dwagon has a chance to respond to these ideas.

I'm curious as to the reasoning / use case to encode iterators at all.
My use of iterators fall in to two major categories:

Iterating across a container inside a class - no need for saving the iterator; the container should be saved
Iterating across an external data source (file, database, etc) - no need to save the iterator; just save the data source

Is there something that I have missed or a technique I should have been using?
The attribute should be either to explicitly include or exclude members of a class (and by default do everything). It shouldn't try to do both (having an "include" list and an "exclude" list is just going to cause confusion). As the default is to pickle everything, I'm thinking specifying attributes to not include is more logical. It means that if a user adds a new attribute to a class they are trying to pickle it will work with no additional effort - only if there is a problem would they need to adjust the field list.
As to the naming of the attribute:

It should include the name "jsonpickle" to avoid clashes with anything else.
It should be terse; we're not coding cobol :)

My suggestion would be "_jsonpickle_exclude"

One reason I dislike the "ignore_iterators" flag is that it is coarse grain - it affects all of the saved classes whether you want it to or not. So if you have a class that you want to have iters and one where you don't you would have to treat them separately - and if they are nested you are out of luck. Whereas a attribute on a class means you have fine grained control when you need it.

I created a PR (https://github.com/jsonpickle/jsonpickle/pull/517) with code that does the exclusion.
It works but there are probably huge gaps in cases; and almost certainly easier/better ways of doing it.
If you like the concept I will do the docs as well.

include_iterator_attrs? I don't know if that'd be less clear to non-native English speakers though, I'll need to check with friends of mine who don't speak English natively first.

I'd :+1: for the shorter name and if we go down that road. I'm super curious to know what your friends think of the attrs abbreviation. To me, one attr in favor of attr is that python already uses the abbreviation in getattr, setattr, hasattr and friends.
Better still, it seems like that might be a moot point if we can do without it altogether. I like the concept and diffs in #517 better, especially since it's minimal, general-purpose, and fine-grained.

One reason I dislike the "ignore_iterators" flag is that it is coarse grain

Same.

(#517) works but there are probably huge gaps in cases; and almost certainly easier/better ways of doing it.
If you like the concept I will do the docs as well.

Docs would be much appreciated. There may be gaps but since it's something that only affects new code that opts-in then it should be pretty easy to spackle over the gaps as users encounter them. I'm optimistic that we can make it work.
What do you think @Theelx? I'll start reviewing #517 in the meantime. Thanks for taking the time to get this going.

I'm super curious to know what your friends think of the attrs abbreviation.

I asked 3 friends, one who speaks French, one who speaks Spanish, and one who speaks Korean (all natively). They all understand the attrs abbreviation, though I forgot to ask them whether they like attrs or attributes better.

One reason I dislike the "ignore_iterators" flag is that it is coarse grain

Same, additionally I think we have so many options on encode and decode that it'd be worth thinking about a redesign of some of them for 4.0.0, specifically to merge some functionality together. I emailed davvid about this a while back, but I really liked a bitflags/enum approach to specifying flags, and enums are already in the standard library.

I'm optimistic that we can make it work.

Absolutely! Thank you so much for your time, help, and well-reasoned approaches @dwagon, I think these contributions are going to be a big benefit to jsonpickle overall!

I think we have so many options on encode and decode that it'd be worth thinking about a redesign of some of them for 4.0.0, specifically to merge some functionality together. I emailed davvid about this a while back, but I really liked a bitflags/enum approach to specifying flags, and enums are already in the standard library.

I'm on board with this idea as a reason to bump major versions once we get around to it.
We could keep the existing names for backwards-compatibility forever and introduce new functions with the better design, but I suspect we'll want to drop the old baggage eventually to prevent the implementation from metastasizing.
Either way, we'd probably want to implement it initially by first having the existing API call into a redesigned API that uses bitflags/enum. We can do that before bumping major versions, which is nice since it'll exercise the new API by ensuring that we can reflect our current use cases before swapping over.
We'd then have a commit that changes the signature of the existing functions to remove the old parameter names and that'd be major version trigger.
Anyways, we're off on a tangent so I'll try and keep focused by closing this PR for now since I think we're all in alignment here. Thanks for sharing and helping shape things.


Signomial programming heuristic should expose single-step method

It should be possible to do a single step of the signomial programming heuristic and get back the corresponding GP approximation, residual, solution, etc.
Public local_solve method would then be a simple while loop wrapper around the above.
Overall theme is making everything more modular.
Related to removing code duplication between GP and SP.

It does in the refactor!
import gpkit
x = gpkit.Variable('x')
y = gpkit.Variable('y')
gpkit.enable_signomials()
m = gpkit.Model(x, [x+y >= 1, y <= 0.1])
sol = m.localsolve(verbosity=0)
print m.program.gps


Update config to include upcoming AWS CPI release capabilities

Release 93 will include the ability to set GP3 iops and throughput. Preparing docs so they won't be forgotten.
https://github.com/cloudfoundry/bosh-aws-cpi-release/pull/126.
Can be merged once a CPI release is released.

+1, thanks for the docs PR

Thanks! @schmidtsv


add sdk constraints where missing to prepare for nnbd flag flip

Description
When NNBD is enabled without a flag, packages that don't have SDK constraints will be broken because they will be opted in by default. This adds some constraints where they were omitted to avoid breakage.
Tests
No new tests
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

@zanderso why the label removal?

@jakemac53 Sorry for the trouble. We're closing the tree for a bit to get some sound null safety work rolled through quickly.

Ok - when should I come back to this?


Add xml documentation to all functions

I'd like the world to believe it's because this is what you do in C#, but really, I just wanted to silence the warnings without using the silence warnings hammer.

≧☉_☉≦

:+1: don't know what the .net community likes in terms of line length, and noticed some of the comments are wider than github, but nothing real to stop


improper types when using new DataFrames

When using DataFrames with NullableArrays (currently their master) a DataFrame that is saved an reloaded with Feather has the wrong eltypes.
For example, the dataframe with these eltypes
julia> eltypes(df)
5-element Array{Type,1}:
 Nullable{Float64}
 Nullable{Int64}
 Nullable{String}
 Nullable{DateTime}
 Nullable{Date}

becomes a dataframe with these eltypes
julia> eltypes(df_test)
5-element Array{Type,1}:
 Float64
 Int64
 Nullable{WeakRefString{UInt8}}
 DateTime
 Date

So, as far as I can tell the only problems are that all types wind up not being in NullableArrays except for strings, which have the ("wrong") type WeakRefString{UInt8}.

This will be due to the fact that your first 2 columns don't have any null values, so when they get deserialized, they will be regular Vector{T} instead of NullableVectors. The Nullable{WeakRefString{UInt8}} is also due to an optimization of using WeakRefStrings for performance because materializing Strings can currently kill the performance of Feather. Nothing unexpected here, but we could probably use better docs around this.

I see.  It seems like a problem that deserialized dataframes have significantly different behavior from the serialized ones they result from.  It seems to me that the responsibility falls to the DataFrames package for the first issue (whether the new DataFrame has NullableArrays or not).  The latter issue seems like something that should be addressed here.  Perhaps with a flag to Feather.read or something, I'm not sure what the best answer is.

I don't really like the idea that the type changes depending on whether there are null values or not in the data (there's the same issue in RCall). Since Feather only support nullable arrays, maybe the default should be to always return a NullableArray, with an option to get a standard array when there are no nulls?

I don't really like the idea that the type changes depending on whether there are null values or not in the data

This is definitely a big issue.  Currently, however, this issue is sort of baked into DataFrames, or else it wouldn't even be possible to do this.  The way things stand right now I'd opt for everything always being a NullableArray.
I think what needs to happen is that there need to be two different types down graph from AbstractDataFrame, one which has NullableArrays and one which is not allowed to have null values at all.  Then, there'd be a Type argument to Feather.read specifying which one you want.
Also, I'm wondering under just what circumstances WeakRefString is actually usable.  If you always have to convert to Strings to actually do anything, it seems like that conversion would have to take place regardless of how expensive it is.

Ok, so the new behavior (as of 2135bf6545bd939085f4b8f5b8025f0bce48dfa9) is that all columns will be returned as NullableVector{T}. There's now a keyword argument, nullable::Bool=true, which, if set to false, will return any column with null_count == 0 as a regular Vector{T}. I like the consistency and predictability of returning NullableVectors all the time, while still providing a way for purists to get their vectors out if they want.

That seems ideal.
I think we need something analogous for converting the WeakRefStrings, as the wreak havoc on things that expect String, so I haven't found it possible to actually use them.

Can you give me cases where you ran into problems with WeakRefStrings? I'd definitely be interested to hear about cases where they're causing problems.

I don't have a record of the exact cases when I encountered an issue to be honest, if I encounter more I'll keep track of them and let you know, but frankly I've been converting them for a while so I haven't seen more.
As I recall, there weren't any problems that seemed like bugs to me, so I'm not sure there'd be anything to actually fix, it was more of an interface issue.  If I think of anything really specific I'll let you know.

I just ran into this problem. If you do a join with two DataFrames on a column where in one DataFrame it is a column of WeakRefStrings and in the other DataFrame the column is of type String the join fails with an ArgumentError because the two columns have different types.
I guess your solution to this is to use WeakRefStrings in the second DataFrame.

This issue is actually a really significant performance barrier.  Deserialization into normal strings is much faster in the Python implementation as things are right now, that seems like a problem.  Why should that be the case, does it have something to do with the way Julia strings work?  Having a different string type for this is definitely not ideal, there is always the potential for them to work differently than String somehow, the joinng is a good example, but also, I'm guessing that any operation on them that causes them to be converted into String would be (perhaps unexpectedly) slow and it makes more sense to me to absorb all slowness into the (somewhat expectedly) slow deserialization process.

Is the problem with deserialization at the time of reading the file, or at any time? Is it possible to deserialize the file into WeakRefStrings and then later bulk convert them to regular strings faster than the time it takes to read from the file into regular strings? Or is this a problem with the performance of regular strings in general?

I think the use of WeakRefStrings may be because of terminating NULL characters.  The Julia String type appends a NULL.  The Feather specification doesn't.  A Vector{String} is stored as a single long Vector{UInt8} and a Vector{Int32} of offsets, as described in https://github.com/wesm/feather/blob/master/doc/FORMAT.md
<null bitmask, optional> <int32_t* value offsets> <uint8_t* value data>

There are no NULLs between adjacent strings in Feather.

It seems likely to me that since CPython is written in C, internally Python strings are null-terminated.  If that's the case it means that what @dmbates told us shouldn't mean that the Julia deserialization of strings is necessarily slower.

No, that's incorrect.
The use of WeakRefStrings is purely a performance optimization. Currently, a Julia String is defined to hold a Vector{UInt8} internally. Vector{UInt8} come with a non-trivial overhead (something like ~80 bytes last time I heard), not to mention the construction/destruction costs. It really boils back to the fact that when you have an immutable type that has a mutable field, the immutable type ends up not being as efficient as it could be right now in Julia.
WeakRefStrings solve these issues by being an actual pure immutable type that can "point" at existing data. Their overhead is exactly 24 bytes, and can be seen as a "StringView" of sorts, similar to a SubArray.
And we really need to squash the myth that's been going around that Julia String types have a terminating NULL character; this IS NOT THE CASE. In certain calls to ccall, a conversion to a Cstring is inserted which appends a NULL character for compatibility with C APIs, but in general, the Julia String type has no need or care with NULL terminating-characters.

@quinnj Okay.  I was wrong.

That makes it sound like there's really no choice but to wait for Julia to improve its String implementation.  As a general comment, I tend to notice that the speed-up of Julia vs Python when it comes to numerics tends to be a factor of 20 to 30, while with strings it tends to be more like 10 (of course that's an absurdly broad statement).
Anyway, do you know if the String overhead issue is something that's being actively worked on for v0.6?  I'm assuming that the fact that Julia strings are not null-terminated is good news for the ultimate attainable speed of feather deserialization, though I guess it depends on how exactly it's possible to store them in memory.

Yes, we'd need https://github.com/JuliaLang/julia/pull/18632 to be cleaned up/merged (probably non-trivial). Ultimately, we'd also want https://github.com/JuliaLang/julia/issues/12447 to ensure that the Julia String type was backed by the lowest-level/lowest-overhead "raw bytes" type possible.


ROCm 1.8 with tensorflow 1.3 2.5x slower than ROCm 1.7

Using a Dell Precision 7910XL, a Vega 56 GPU, Ubuntu 16.04.4 LTS and 4.13.0-32-generic kernel, I tested convolution.py from the tensorflow models/tutorials/image/mnist/ folder, using python (vs. python3). With the 4.4 or 4.13 kernel and ROCm 1.7,  I got this per step:
Step 100 (epoch 0.12), 8.8 ms
Now with 1.8, I get this per step:
Step 100 (epoch 0.12), 22.0 ms
I was hoping to get better than 8.8 ms because our nvidia Titan XP gets about 4 ms.
Any ideas how I can get better performance or return to the 8.8 ms/step performance?
rocminfo:
``
HSA System Attributes
Runtime Version:         1.1
System Timestamp Freq.:  1000.000000MHz
Sig. Max Wait Duration:<PHONE_NUMBER>3709551615 (number of timestamp)
Machine Model:           LARGE
System Endianness:       LITTLE
==========
HSA Agents

Agent 1

Name:                    Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz
Vendor Name:             CPU
Feature:                 None specified
Profile:                 FULL_PROFILE
Float Round Mode:        NEAR
Max Queue Number:        0
Queue Min Size:          0
Queue Max Size:          0
Queue Type:              MULTI
Node:                    0
Device Type:             CPU
Cache Info:
L1:                      32768KB
Chip ID:                 0
Cacheline Size:          64
Max Clock Frequency (MHz):3600
BDFID:                   0
Compute Unit:            16
Features:                None
Pool Info:
Pool 1
Segment:                 GLOBAL; FLAGS: KERNARG, FINE GRAINED
Size:                    131952400KB
Allocatable:             TRUE
Alloc Granule:           4KB
Alloc Alignment:         4KB
Acessible by all:        TRUE
Pool 2
Segment:                 GLOBAL; FLAGS: COARSE GRAINED
Size:                    131952400KB
Allocatable:             TRUE
Alloc Granule:           4KB
Alloc Alignment:         4KB
Acessible by all:        TRUE
ISA Info:
N/A

Agent 2

Name:                    gfx900
Vendor Name:             AMD
Feature:                 KERNEL_DISPATCH
Profile:                 BASE_PROFILE
Float Round Mode:        NEAR
Max Queue Number:        128
Queue Min Size:          4096
Queue Max Size:          131072
Queue Type:              MULTI
Node:                    1
Device Type:             GPU
Cache Info:
L1:                      16KB
Chip ID:                 26751
Cacheline Size:          64
Max Clock Frequency (MHz):1590
BDFID:                   1280
Compute Unit:            56
Features:                KERNEL_DISPATCH
Fast F16 Operation:      FALSE
Wavefront Size:          64
Workgroup Max Size:      1024
Workgroup Max Size Per Dimension:
Dim[0]:                  67109888
Dim[1]:                  83887104
Dim[2]:                  0
Grid Max Size:<PHONE_NUMBER>
Waves Per CU:            40
Max Work-item Per CU:    2560
Grid Max Size per Dimension:
Dim[0]:<PHONE_NUMBER>
Dim[1]:<PHONE_NUMBER>
Dim[2]:<PHONE_NUMBER>
Max number Of fbarriers Per Workgroup:32
Pool Info:
Pool 1
Segment:                 GLOBAL; FLAGS: COARSE GRAINED
Size:                    8372224KB
Allocatable:             TRUE
Alloc Granule:           4KB
Alloc Alignment:         4KB
Acessible by all:        FALSE
Pool 2
Segment:                 GROUP
Size:                    64KB
Allocatable:             FALSE
Alloc Granule:           0KB
Alloc Alignment:         0KB
Acessible by all:        FALSE
ISA Info:
ISA 1
Name:                    amdgcn-amd-amdhsa--gfx900
Machine Models:          HSA_MACHINE_MODEL_LARGE
Profiles:                HSA_PROFILE_BASE
Default Rounding Mode:   NEAR
Default Rounding Mode:   NEAR
Fast f16:                TRUE
Workgroup Max Dimension:
Dim[0]:                  67109888
Dim[1]:                  1024
Dim[2]:                  16777217
Workgroup Max Size:      1024
Grid Max Dimension:
x<PHONE_NUMBER>
y<PHONE_NUMBER>
z<PHONE_NUMBER>
Grid Max Size:<PHONE_NUMBER>
FBarrier Max Size:       32
*** Done ***

TensorFlow : 1.3 v - tf_cnn_benchmarks
ROCm 1.7.2 GA
Drop
ROCm 1.8 GA

2500 , alexnet ; Batch size:  2048 global , 512 per device
3196.48
-1.61%
3145.09

2500 , googlenet ; Batch size:  128 global 32 per device
603.14
4.13%
628.03

2500 , inception3 ; Batch size:  128 global 32 per device
172.39
-6.00%
162.04

2500 , inception4 ; Batch size:  128 global 32 per device
69.67
-7.55%
64.41

2550 , lenet5 ; Batch size:  128 global 32 per device
8433.25
-7.40%
7809.51

2500 , overfeat ; Batch size:  128 global 32 per device
226.33
-0.07%
226.17

resnet50 ; Batch size:  256 global 64 per device
302.72
-2.69%
294.57

2500 , resnet152_v2 ; Batch size:  128 global 32 per device
113.3
12.97%
128

2500 , trivial ; Batch size:  128 global 32 per device
6155.1
-3.20%
5957.96

2500 , vgg11 ; Batch size:  256 global  64 per device
307.41
-3.99%
295.14

Hi @srondeauuwt , could you try our latest TF1.11 release based on ROCm1.9?
Here's part of the log I can see using single MI25 GPU:
Minibatch loss: 8.334, learning rate: 0.010000
Minibatch error: 85.9%
Validation error: 84.6%
Step 100 (epoch 0.12), 5.1 ms
Minibatch loss: 3.236, learning rate: 0.010000
Minibatch error: 6.2%
Validation error: 7.6%
Step 200 (epoch 0.23), 4.8 ms
Minibatch loss: 3.362, learning rate: 0.010000
Minibatch error: 10.9%
Validation error: 4.5%
Step 300 (epoch 0.35), 4.6 ms
Minibatch loss: 3.153, learning rate: 0.010000
Minibatch error: 3.1%
Validation error: 2.9%
Step 400 (epoch 0.47), 4.3 ms
Minibatch loss: 3.210, learning rate: 0.010000
Minibatch error: 6.2%
Validation error: 2.8%
Step 500 (epoch 0.58), 4.4 ms
Minibatch loss: 3.173, learning rate: 0.010000
Minibatch error: 6.2%
Validation error: 2.4%
Step 600 (epoch 0.70), 4.2 ms
Minibatch loss: 3.144, learning rate: 0.010000
Minibatch error: 3.1%
Validation error: 2.2%
Step 700 (epoch 0.81), 4.2 ms
Minibatch loss: 2.963, learning rate: 0.010000```

Hi @srondeauuwt , could you try our latest TF1.11 release based on ROCm1.9?
Here's part of the log I can see using single MI25 GPU:
Minibatch loss: 8.334, learning rate: 0.010000
Minibatch error: 85.9%
Validation error: 84.6%
Step 100 (epoch 0.12), 5.1 ms
Minibatch loss: 3.236, learning rate: 0.010000
Minibatch error: 6.2%
Validation error: 7.6%
Step 200 (epoch 0.23), 4.8 ms
Minibatch loss: 3.362, learning rate: 0.010000
Minibatch error: 10.9%
Validation error: 4.5%
Step 300 (epoch 0.35), 4.6 ms
Minibatch loss: 3.153, learning rate: 0.010000
Minibatch error: 3.1%
Validation error: 2.9%
Step 400 (epoch 0.47), 4.3 ms
Minibatch loss: 3.210, learning rate: 0.010000
Minibatch error: 6.2%
Validation error: 2.8%

Finally got a chance to upgrade from Ubuntu 16.04 to 18.04, and from Tensorflow 1.3 to 1.11 and RocM 1.9.1. It is now running much better than when I complained about 1.8.1; e.g.:
Step 100 (epoch 0.12), 7.3 ms
Minibatch loss: 3.247, learning rate: 0.010000
Minibatch error: 6.2%
Validation error: 7.9%
but in the meantime, Nvidia's drivers improved for the Titan XP, and now the mark to beat is about 2.8 ms per 100 steps vs. the 4 ms/100 I was seeing before. I doubt if my Vega 56 is going to outpace or even keep pace with the XP. Soon I will be buying an RTX 2080 Ti, and it will be interesting to compare results with it.


Fix port in use while use jmx jvm argument

Fix #15168

@Xenorith Thanks for your review, please take another look, thank you

alluxio-bot, merge this please

@Xenorith Thanks for merge this PR!
BTW, I just feel curious why add a ^ before the regex for the -agentlib:jdwp=transport=dt_socket.*address=[0-9]*, if we added the ^ as it is now, if -agentlib:jdwp=transport=dt_socket.*address=[0-9]* appears in the middle of the ALLUXIO_XXX_JAVA_OPTS, it cannot be removed i think.

i think you are right. i dont see a reason why it must be the beginning of the string
when reading more about it, i also find that the regex we use may not be complete and result in incorrect replacement. for example if i add a timeout value like -agentlib:jdwp=transport=dt_socket,server=y,address=localhost:8000,timeout=5000, then the sed will leave behind ,timeout=5000


Document rust-analyzer diagnostics

We should document all our diagnostics in the manual (probably don't need a lot of text, just the diagnostic code and maybe an example message). We could probably generate this similarly to the assist documentation.

Here's the relevant code:
https://github.com/rust-analyzer/rust-analyzer/blob/3e450cf89f9fcb7356a12487ccac7f8e21811095/xtask/src/codegen/gen_feature_docs.rs#L10-L18
To find existing diagnostics, look for impls of this trait:
https://github.com/rust-analyzer/rust-analyzer/blob/3e450cf89f9fcb7356a12487ccac7f8e21811095/crates/hir_expand/src/diagnostics.rs#L32-L42


Clarifying best practices for configuration and Excluding devices

At this time (v3.4.0), I'm adopting the cookie approach, and have stored my cookie info in /config/.storage/alexa_media.{account}.txt.   Works great; I'm just hoping they don't expire it as frequently as Google Maps does!
(If they do, I assume my last alternative is to leverage the 2FA App approach.)
Anyway, regarding Exclusions: (doc on Advanced Configuration)
It appears the alexa_media: exclude_devices: list I've always had in my configuration.yaml file is no longer affecting anything.
Maybe configuring this via the HA Integration depreciating exclude_devices: options?
Regardless: during my Integration-add, I excluded the 11 devices of interest (155 characters - so I'm hoping I don't need to enter string every time!), but then I have 36 'unavailable' switches (repeat/shuffle/DNDs) and sensors (next_alarm, next_reminder, next_timer) that I don't want visible in HA (so templating loops, etc, are not tripped up by entities I don't care about).
Is there a better approach to manually disabling them each time the Integration needs to be cycled? Unless HA offers a better way, the hunt-and-click for all these on the Entitles Config screen is getting old.

Exclude_devices is the only way and only superficially supported. Given HA wanted to move to UI based editing, I am unlikely to make significant investments in supporting it further. Please note you can also exclude the additional switches using the same interface.
I recognize the config flow is more cumbersome then the configuration.yaml, but my suggestion would be to save the string you use in the config flow somewhere so you can just paste it if you need to remove and readd.
Lastly, configuration.yaml should automatically update the existing config flow entry on start up. If you're saying it's not doing that, that may be a bug, but I'd need to see the startup logs.

Again, tonight, they dropped me I guess and I had to remake the cookie files. I was surprised to see my previous pickle file was no longer in .storage.   This Amazon stuff is really getting old.

configuration.yaml should automatically update the existing config flow entry on start up

I'm not sure what you mean by config flow entry. I re-added the integration, restarted HA, but still had the Excluded devices from the configuration.yaml file.
BTW: Someone's bound to mention this: after screwing up with the captchas long enough, things finally give up with an abort error, but the screen also says successful:

The .pickle is automatically deleted if a failure is detected. Yes, I wish Amazon was less fincky.
The integration page is also known as config flow. If you have the yaml entry, it will automatically create the integration for you on startup. If it already exists, it's supposed to update it.
The abort screen is a HA problem. I've raised it since it's so confusing but so far this is the approved mechanism.

Once again, thank you for your time on this.
I just migrated to using your Built-in 2FA App. I'm hoping it's easier to paste in strings for that code and my exclude devices, rather than having to screw around with their captchas and the authenticator app. Time will tell.


Go coloring

Fixes this issue: https://github.com/sdras/night-owl-vscode-theme/issues/108

Perfect, thank you!


fix: duplicate devDependencies in package.json

I'm using chance inside of Bun and it complains about:
81 |   "devDependencies": {
       ^
warn: Duplicate key "devDependencies" in object literal
   at /myproject/node_modules/.pnpm/chance@1.1.11/node_modules/chance/package.json:81:3

And looks like indeed there are currently two duplicate devDependencies keys in the package.json. This PR fixes that.

Closing as this is a duplicate of #595


When is deployed the snapshot including fixes #295?

Hello, wumpz.
I am wondering when the snapshot including fixes #295 is deployed ?
(I am waiting for it......)
Of couse, I always thanks for your effort ^^

It already should be deployed. Did you try it?

Sorry, I got it!! Thanks!!


Changing the num_features parameter in explain_instance gives very different results

I have recently started using LIME and I'm using it to explain the outputs of a LGBMClassifier.
I have an issue with the num_features parameter.  For example if I run it with 5, the output is something like this:
exp = explainer.explain_instance(X_train.values[idx], predict_model_lgbm.predict_proba,                                                        num_features=5) exp.as_list()

[('entitlement_number <= 1.00', -0.41398972465855205),
('Annual=0', 0.33586503353921526),
('Daily=0', -0.23173429118453642),
('hist_total_tenurea <= 0.00', 0.210909651734952),
('numrenewals > 1.00', 0.12207210974714447)]

But if I run it with num_features = 10, I get something like this:

[('SAILING <= 0.00', 0.0),
('LIVE ONLY <= 1.00', 0.0),
('MODERN PENTATHLON <= 0.00', 0.0),
('JET SKIING <= 0.00', 0.0),
('VOLLEYBALL <= 0.00', 0.0),
('HANDBALL <= 0.00', 0.0),
('SHOW JUMPING <= 0.00', 0.0),
('One Time=0', 0.0),
('ARTISTIC GYMNASTICS <= 0.00', 0.0),
('XTREME SPORTS <= 0.00', 0.0)]

I would have thought that increasing the features from 5 to 10 would keep the original 5 plus adding another 5 that are less important.    Am I using this parameter correctly?
On another note, the features shown by the explainer are very different to the ones I get when plotting model's feature importances (using plot_importance from Lightgbm).  Is that something I should expect?

You seem to be using it correctly, it's probably a bug on our end. Is the dataset you are using public? If so, would you mind posting a link to it so I can debug this?

Any update on this issue?

I am waiting for the update on this. I am also getting different results when using different number of features.

This (all zeros on explanations) should have been fixed by f2d08669ab8db2e777e63cd646b59f4d0867f4a2. Please reopen if not!

Hi Marco, first of, thanks for the implementation 👍. Secondly, I am using lime==<IP_ADDRESS> and am getting a similar problem as Fernando. For num_features < 7 the explanations are generally incremental and intuitive. Using num_features between 7 and 20 i get zeros on explanations and going even higher, I get either zeros or unintuitive features explanations, i.e., explanations altering from one class to another and values larger than the first 6 "good" explanations.
The dataset is non public so unfortunately i cannot pass a copy for reproduction purposes.


Support Standard Trait Definition for Fungible Tokens (SIP 010) (e.g. decimals)

When implementing a fungible token with a certain number of decimals (e.g. 6), it currently shows the whole amount in the Stacks Web Wallet. For instance, for a stablecoin xUSD I am implementing, I get the following:

In this case, I have 822.82 xUSD in my wallet, but it shows as 82282000 (i.e. 6 decimals). This fungible token will follow the SRC20 standard activated soon (https://github.com/stacksgov/sips/pull/5/files), so my proposal would be to check if that "standard" trait is implemented and use the decimals method in there to visualise and process it.

@psq has also mentioned a general need here for SIP010 support in the web wallet (e.g. showing decimals, artwork and symbols correctly) so I'll widen this issue a bit.

@markmhx cool!
can we track the ETA of these items somehow? e.g. how long does an item stay in backlog and how long does it take to move through the kanban?

Fully supporting sip-010 tokens in a wallet (or the explorer) probably goes beyond supporting the number of decimals, pulling the artwork via the uri and the symbol.  Instead of relying of the api endpoints that provide balances for native ft-tokens, all information should be retrieved via the contract, i.e. the balance via get-balance-of, and transfers made via the transfer function instead of relying on the native clarity function.
Failure to do so will likely cause discrepancies as the token may need to do other things when doing a transfer (check that it can be transferred for 1 possible example).
And a token may not even use a native ft-token in its implementation (see flexr for an example, even if maybe this could be improved in this case).  More on this below.
As an added difficulty, one thing that is yet unclear, is how the wallets can, in the general case, find all SIP-010 tokens owned by an address.  If such a token uses a native ft-token, the contract address can be inferred by what is returned from the Get Account Balances endpoint (https://blockstack.github.io/stacks-blockchain-api/#operation/get_account_balance).  In this case, the contract address can be extracted from SP32AEEF6WW5Y0NMJ1S8SBSZDAY8R5J32NBZFPKKZ.micro-nthng::micro-nothing by using the value left of ::.
However, if it is not using a native token, the wallet may require the ability to manually add the token's contract address (like you can do in metamask) in order to be able to interact with the token.
And I can think of a few cases where a SIP-010 token would require more than one native token to implement, so don't assume there is a one to one mapping between a SIP-010 token and native tokens...
Hopefully, this helps...  and would be happy to develop any of the above if needed.

@philipdesmedt I can't estimate the speed of our board at the moment, but we can start with the design phase of this issue soon and we are working this week on the roadmap to prioritize it over other tasks.
@psq

Hopefully, this helps... and would be happy to develop any of the above if needed.

Once we have the designs ready, would this be someone that might want to implement yourself?

Once we have the designs ready, would this be someone that might want to implement yourself?

poor choice of word, by "develop", I meant explain further if needed

Wanted to chime in that this impacts a potential launch of xBTC by Tokensoft.

@GinaAbrams excited to see xBTC!
I think this impacts the launch of every fungible token, unless you specifically launch a micro-denominated token I guess

@GinaAbrams Are there any particular aspects of the standard required by Tokensoft for launch?

confirmed that trying to transfer a sip-010 token from the web wallet does not work.  Errors with

The contract you specified does not have a transfer function.

as expected, as it assumes the transfer function signature is different.
Also, the message you get when setting PostConditions.allow is the same as having an empty array of postconditions with PostConditions.deny, which is confusing, or misleading.


ZEPPELIN-1562 updated api doc

What is this PR for?
The URL for running a paragraph synchronously using REST api is mistakenly given as "http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId] "
Changed the doc as per code
What type of PR is it?
[Documentation]
Todos
What is the Jira issue?
ZEPPELIN-1562
How should this be tested?
Hit the url in below format for asynchrnous
http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId]
the same in synchronous
http://[zeppelin-server]:[zeppelin-port]/api/notebook/run/[notebookId]/[paragraphId]
Screenshots (if appropriate)
Questions:
Does the licenses files need update? NO
Is there breaking changes for older versions? NO
Does this needs documentation? NO

LGTM. Merge if there is no more discussion.


Bug: --json mode going into a infinite loop?

/tmp took 37s
❯ ollama run llama2 --format json
>>> give me 10 emojis with their meanings
{

 .... # never ends for that input

https://github.com/jmorganca/ollama/assets/18315/6771fd1f-d0e3-4f1f-9e7b-e15bacf8acad
^ recording

Hi @hemanth sorry you hit this issue. It's important sometimes to add Answer in JSON in the response so the model can better predict JSON fields (I'll still label this as a bug)

>>> give me 3 emojies and meanings in JSON format
{
  "emojis":[
    {"name":"😂", "meaning":"laughter"},
    {"name":"🤔", "meaning":"thoughtfulness"},
    {"name":"🎉", "meaning":"celebration"}
  ]
}

Nice!

For me it's working without specifying json in the prompt. (I have 32Gb on M1Pro MacBook)
(base) igor@macIgor ~ % ollama run llama2 --format json

give me 10 emojis with their meanings
{ "😊": "Happy", "👍": "Okay", "🤔": "Thinking", "🚀": "Space", "🎉": "Celebration", "💭": "Thoughts", "🤝":
"Friendship", "🌈": "Rainbow", "🏆": "Trophy", "📚": "Book" }

It seems to spin out of control for me quite often in the "REPL" mode specifically. It will just go nutty dumping newlines after it finishes the JSON object.

Resolving this to unify with #1910, which will be solved by #3080


4481 Print Individual Donation Receipts

Resolves #4481
Description
Added buttons to donation list rows and donation view page to print PDF receipt of individual donation.  PDF is modification of existing distribution receipt.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Added and modified sample donation records to provide a variety of types of donations: sources, various states of completeness of contact info, line items, money values.
For some reason rSpec is currently getting hung on my system, so these tests were not run.  Only changes made to existing code was adding 2 routes, 2 buttons, and one controller method.
Screenshots

Hiding value columns:

Not hiding value columns:

Added zero dollar money raised display and tests.

Latest changes pushed.

All things being tested for now have hardcoded values.


setup.py now fetches packages from requirements.txt.

FYI @carlogrisetti and I are working on how best to group the dependencies. Will feed back

FYI @carlogrisetti and I are working on how best to group the dependencies. Will feed back

Alright. Paused development meanwhile. Thanks for feedback


Remove tralling whitespace in edit mode of frames

Hi @roramirez thank you for your contribution! Can you add a bit more context/explanation to this improvement please (in your PR description)?


fix prettier delete ␍

Update prettier configuration.
delete '␍' prettier/prettier

Hey thanks for the first contribution!
Would you be able to explain why this PR is useful? :)

Maybe I think your OS is ubuntu.
It is the problem about line break type(git, vscode, ...).
    "prettier/prettier": [
      "error",
      {
        endOfLine: "auto",
      },
    ]

It is working well without this rule in ubuntu OS because it support LF as default
But It is not working in other OS like Windows(support CRLF) and others(CR).
Of course we can convert from LF to CRLF and from CRLF to LF.
Once we add this rule into eslint, we can use the source without difficulty in all of line break type.
Your opinion related this commit?

LF (what we default to now) should be supported by all modern text editors, regardless of what OS is being used.
What text editor are you using to view the code?

I am using vscode as a code editor
LF is default for us.

And you are still experiencing issues with LF in your editor?

When I build the open source projects, I have difficulty sometimes because of it.
In the process of exploring several times, I found that it was the most sensible solution.

I'd rather save this for a bigger prettier update. thank you for the contribution


Is MaxCDN vulnerable?

I got some results point to netdna-cdn.com, which is manage by MaxCDN, and now StackPath,
I've checked the StackPath manage panel but can't find anywhere to claim the site, Is there any proof-of-concept or links useful for this please?

Create a cdn service will be given such kinds of domain [random value].stackpathcdn.com, so I don't think it's vulnerable now.


How do I generate nested json objects using mysql native json functions?

CREATE TABLE `parent_table` (
   `id` int(11) NOT NULL,
   `desc` varchar(20) NOT NULL,
   PRIMARY KEY (`id`)
);
CREATE TABLE `child_table` (
   `id` int(11) NOT NULL,
   `parent_id` int(11) NOT NULL,
   `desc` varchar(20) NOT NULL,
   PRIMARY KEY (`id`,`parent_id`)
);
insert `parent_table` values (1,'parent row 1');
insert `child_table` values (1,1,'child row 1');
insert `child_table` values (2,1,'child row 2');

I am trying to generate a JSON document that looks like this:
[{
    "id" : 1,
    "desc" : "parent row 1",
    "child_objects" : [{
            "id" : 1,
            "parent_id" : 1,
            "desc" : "child row 1"
        }, {
            "id" : 2,
            "parent_id" : 1,
            "desc" : "child row 2"
        }
    ]
}]

I was able to get the desired result using mysql2 (npm install mysql2)

Hi @petkovic43 there is a lot to digest there. The interfaces should be the same. Can you share the code you're using with mysql2 to get that output?

Closing since I never heard back.

Anyone who got the solution to this to help me?

I was able to get the desired result using mysql2 (npm install mysql2)

Kindly explain how you did this. I will appreciate.


Error when build for WASM - LibZ

axmol version: 6b25f513e17ac7f692bf8c8cce4b05f163521bf3
devices test on:
developing environments

NDK version: r23c
Xcode version: 14.2+
Visual Studio:

VS version: 2022 (17.9+)
MSVC version: 19.39+
Windows SDK version: 10.0.22621.0+

cmake version: 3.29.3
Steps to Reproduce:

git clone https://github.com/paulocoutinhox/axmol-native-helper.git
cd axmol-native-helper
make build-wasm

Error:
[ 93%] Building CXX object CMakeFiles/axmol-native-helper.dir/Platform/wasm/PlatformHelper.cpp.o
make[2]: *** No rule to make target `/Users/paulo/Developer/workspaces/cpp/axmol/3rdparty/zlib/_x/lib/wasm/libz.a', needed by `bin/axmol-native-helper/axmol-native-helper.html'.  Stop.
make[1]: *** [CMakeFiles/axmol-native-helper.dir/all] Error 2
make: *** [all] Error 2

Please pass -u to axmol cmdline to upgrade 1kdist to v85

After update, i get other error:
[100%] Building CXX object engine/extensions/scripting/lua-bindings/CMakeFiles/axlua.dir/Users/paulo/Developer/workspaces/cpp/axmol/3rdparty/yasio/yasio/bindings/lyasio.cpp.o
In file included from /Users/paulo/Developer/workspaces/cpp/axmol/3rdparty/yasio/yasio/bindings/lyasio.cpp:83:
In file included from /Users/paulo/Developer/workspaces/cpp/axmol/3rdparty/yasio/yasio/bindings/yasio_sol.hpp:29:
/Users/paulo/Developer/workspaces/cpp/axmol/3rdparty/lua/sol/sol.hpp:6755:10: error: no member named 'construct' in 'optional<type-parameter-0-0 &>'
 6755 |                         this->construct(std::forward<Args>(args)...);
      |                         ~~~~  ^
/Users/paulo/Developer/workspaces/cpp/axmol/3rdparty/lua/sol/sol.hpp:14541:32: warning: unknown warning group '-Wmaybe-uninitialized', ignored [-Wunknown-warning-option]
 14541 | #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
       |                                ^
/Users/paulo/Developer/workspaces/cpp/axmol/3rdparty/lua/sol/sol.hpp:17294:32: warning: unknown warning group '-Wmaybe-uninitialized', ignored [-Wunknown-warning-option]
 17294 | #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
       |                                ^
2 warnings and 1 error generated.

All done, thanks.


The one below isn't rendering it as a code block.
{% include note.html content="This is my note.

~~~
def foo(x):
    return x+1
~~~

" %}

As a general rule, whenever MarkDown fails, you have fallback to HTML:
{% include note.html content="This is my note.

def foo(x):

    return x+1

" %}

In previous versions of documentation-theme-jekyll, the
 tag was supported. It doesn't seem to be working in 6.0, so you have to use
 and   to get the line breaks and spacing you're looking for.

Thanks for adding this note. I'll mention this in the documentation.

I added the note here.


Stable/newton

@zancas
What issues does this address?
What's this change do?
Bringing newton up-to-date with mitaka changes.
Where should the reviewer start?
Any background context?

test this please

@pjbreaux can I just say:

"test this please" like I did above?

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please


update combineTemplate to use original objects given as values (#615)

Fixes issue https://github.com/baconjs/bacon.js/issues/615

This was my first time to touch Bacon.js code so direct but constructive pointers will be appreciated :)

To me it looks like you're now always using the original template objects as values and you'll end up mutating them when new values are pushed through the template. You should add a test for "does not mutate the original template objects" to make sure this doesn't happen.

it.only "doesn't mutate template objects", ->
    value = {key: fromArray([1, 2])}

    Bacon
      .combineTemplate(value)
      .slidingWindow(2, 2)
      .onValue ([first, second]) ->
        expect(first).to.not.equal(second)

Tried something like this but slidingWindow is undefined. What is the preferred way to write tests?

When tests are run separately, only the dependencies of the tested module are included in the build to ensure that the given module actually works with its declared deps.
You can however declare extra dependencies in test files too, like this:
# build-dependencies: slidingwindow


70initLND - Warning70

Hi Guys,
it seems like my bitcoind service can't run. I get following message: Service bitcoind is not running.
https://termbin.com/xksdr
I tried to install the sphinx-relay, maybe there was something wrong with it?
https://github.com/stakwork/sphinx-relay/blob/master/docs/raspiblitz_deployment.md
Thanks for your help in advance!

can you check if you see any hint of that error with sudo tail -n 100 /mnt/hdd/bitcoin/debug.log ... and bitcoind worked before you installed sphinx-relay?
BTW since RaspiBlitz v1.6.2 there is a one-click install for Sphinx-Relay under MAINMENU > SERVICES ... the detailed tutorial you linked is outdated. Have you tried that? Maybe best is to recover your RaspiBlitz with a fresh v1.6.2 sd card image and then use the one-click install.

Hey, thanks for the superfast answer. Yes, bitcoind worked before. Maybe it would indeed be the best to recover with a fresh install.
Also it seems like the raspi can't find or properly mount the ssd for some reason. There's also no directory bitcoin in hdd.

Yeah seems best to give a fresh v1.6.2 sd card image a chance and use the one-click install for Sphinx-relay.

thanks for the help. one more thing: how can I backup funds from channels via command line? I presume the funds in my wallet will still be there after using the seed to recover the node?

You can simply copy the static channel backup file to a secure place of your choosing at any time ... its located /mnt/hdd/lnd/data/chain/bitcoin/mainnet/channel.backup and updates after a channel gets opened or closed.


denicotinized, antimasonic

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[a,d]

/trunk merge


chore: Update ava to `v0.19.1

https://github.com/avajs/ava/compare/v0.15.1...v0.19.1

Coverage remained the same at 100.0% when pulling 9f5c0b4c7828cdb19d1f6f5061aecf8246c35f20 on ava into 239f93e983e9b32fea525ca8975f862d49d702a8 on master.


Add writeNullable to RowBinaryStream

Following up on discussion in https://github.com/apache/beam/pull/7006#discussion_r232695315
@serebrserg can you please take a look?

@serebrserg thanks for the review


Load results of Provider API Script runs to S3, as well as PostgreSQL

Fixes

Fixes #333 by @mathemancer
Description

This PR modifies the Apache Airflow DAG (Directed Acyclic Graph) defined at src/cc_catalog_airflow/dags/loader_workflow.py so that it now loads the staged TSV (tab separated value) file to an AWS S3 bucket before attempting to load it into the PostgreSQL database.  Note that the DAG will still attempt to load the data into PostgreSQL, even if loading the file to S3 fails.
Also included is a local S3 mock server that allows running the entire DAG locally without touching actual Amazon AWS at all.
Tests

Follow the instructions in the README.md to run the tests.  For even more excitement:

Login to the cc_catalog_airflow_webserver_1 container (after following the README.md to bring up the environment):

docker exec -it cc_catalog_airflow_webserver_1 /bin/bash

Copy an example tsv to the /tmp/ directory in the container:

cp /usr/local/airflow/dags/provider_api_scripts/tests/resources/example_output/phylopic_1561673410.tsv /tmp/

Go to localhost:9090 in your browser, and toggle the tsv_to_postgres_loader DAG to 'On'
Click on the tiny 'tree' icon in the interface for that DAG.  Watch the lights turn green.  It may take a couple of runs before anything interesting happens, since the DAG waits for the file to be unmodified for a minute before it does anything.

Checklist

[X] My pull request has a descriptive title (not a vague title like Update index.md).
[X] My pull request targets the master branch of the repository.
[X] My commit messages follow best practices.
[X] My code follows the established code style of the repository.
[X] I added tests for the changes I made (if applicable).
[ ] ~I added or updated documentation (if applicable).~
[X] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Apparently WTForms had a version update today that broke Flask.  The version is pinned for now.


Add support for Visual Studio 2017

I've just added support for Visual Studio 2017. So Pomdog has deprecated Visual Studio 2015 in favour of 2017 and other modern C++ compilers.
Here is the related commit: 71cb681d0ba2b80fa0d5e0f1c895d54cc2a0d62a

Travis CI is having trouble right now. 🙏
https://www.traviscistatus.com/incidents/l26xy07hwr5q


Add some new refolds.

This adds ghyloM, dyna, codyna, codynaM refolds. As well as a
ganaM unfold.
FunctorT.translate has been removed, as it is identical to
FunctorT.transAna (and identical to .transCata, since the traversal
order is irrelevant) and attempting to add TraverseT.translateM made it clear
that sometimes you do care about whether its bottom-up or
top-down (because the constraints on F and G differ), so now always
explicitly use transAna or transCata.
Fixed the type parameter order for IdOps.ghylo.
Added a Nat type to matryoshka.fixedpoint.
Added type aliases for transforms, and a conversion from Transform to
Algebra.
Added optics for algebras and folds.
Made freeEqual available outside of tests.

sigh once again scaladoc breaks the build.

[Current coverage][cc-pull] is 71.84%

Merging [#27][cc-pull] into [master][cc-base-branch] will decrease coverage by 3.15%

2 files (not in diff) in .../matryoshka/patterns were modified. more

Misses +3
Hits -3

2 files (not in diff) in ...ain/scala/matryoshka were modified. more

Misses +1
Hits +3

2 files in ...ain/scala/matryoshka were modified. more

Misses -2
Hits -1

@@             master        #27   diff @@
==========================================
  Files            25         25
  Lines           416        451    +35
  Methods         406        445    +39
  Messages          0          0
  Branches          8          5     -3
==========================================
+ Hits            312        324    +12
- Misses          104        127    +23
  Partials          0          0

Powered by Codecov. Last updated by [4c90b0e...3fdabfe][cc-compare]
[cc-base-branch]: https://codecov.io/gh/slamdata/matryoshka/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/slamdata/matryoshka/compare/4c90b0e444950d4285e9223f78441c6d76dbb926...3fdabfe1d766baa724f7ea41899daea689d44e37
[cc-pull]: https://codecov.io/gh/slamdata/matryoshka/pull/27?src=pr

:+1: LGTM.
A thought for the fixedpoint instances might be to make them value classes instead of aliases so that you can hang typeclass instances and operations off of them.

Yeah, there’s actually a PR (#13) that converts them to classes. I have to rebase that and fix whatever issues were still there.

Ok, addressed your comments, and some other minor stuff (as always), if you want to take a look. Otherwise I’ll merge when the build passes.


Some code issues

I think it would be better to rename the variable.
forwarding-bot/forwarding_bot/settings.py

MINSK_TZ = pytz.timezone("Europe/Minsk")
def minsk_timezone(*args):
    return datetime.now(MINSK_TZ).timetuple()

I guess there's no need to instantiate Bot class
forwarding_bot/vk/_blueprint/blueprint.py

bot = Bot(data_config.bot_token)

As I know bot = message.bot should work

What are your suggestions? Feel free to make PR's
I think you are mistaken this bot instance with VK bot. It is a TG bot instance which needs to make API calls
This will be refactored when I will have time
Again, I'm open to your PR's
:)

Will it be okay if the time zone is set via the Telegram bot?
I have a lot of ideas.
What about multiple accounts?
What about adding accounts via bot? But it's not safe
My mistake.

Multiple accounts and multiple convos config is a feature that is not really prioritised right now
The main goal is to achieve better code structure and better message handling
Also the timezone here is for logging, not for bots
It should be a function as it is requested by logging module
The only thing is that this function can be lambda

Closed as inactive


Docker Container Build and Run setup with foundations for adding integration-tests

Docker images built with Hadoop 2.8.4 Hive 2.3.3 and Spark 2.3.1
Main Changes:

Ability to build docker images with Hoodie-2.8.4. hive-2.3.3 and Spark 2.3.1 with Hoodie package and source installed. HiveServer running with hoodie jars.
Integrate docker build and run process with maven life-cycles.
Simple integration test the runs HoodieJavaApp and ensures the hive table has correct count.

See docs/quickstart.md for commands to use.

@vinothchandar : Ready for review. This is mostly pom and dockerfile changes.

We test this and get back. Thank you much.


calling move call using TS SDK signAndExecuteTransaction returns RPC Error: invalid length 109, expected an byte array of size 32

A few community member reported error when using TS SDK to sign a move call transaction.
https://discord.com/channels/916379725201563759/955861929346355290/1071053778645696582

Fixed in a newer version of the SKD


Updated README.md: Added 'Bomber', 'Settings Widget Constructor', 'Custom Shape Button', 'Pool Manager', 'Meta Cheat Manager', and 'Morphs Player'

I have created several projects that I believe will be beneficial to the community. I'm proposing to include the following projects in the Awesome-Unreal collection:

Bomber
Settings Widget Constructor
Custom Shape Button
Pool Manager
Meta Cheat Manager
Player Morphs

Each of these projects is accompanied by a downloadable sample and documentation. I am committed to maintaining and updating these repositories to ensure their ongoing value to the Unreal Engine community. I look forward to your feedback and hope these contributions can enhance the collection's offerings.

Thank you


correct missing self parameters, remove duplicate class methods

Hi,
is stumbled across your work and would like to thank you for the stub you created.
I found a few thinks that i think should be corrected,
which were revealed by suppressing mostly irrelevant pylint errors
I'm working on a set of stubs from micropython , and although i do not have a pyboard myself, support for the pyb should be included.
Is it OK with you to re-use your work for that ?
regards,
Jos

Mostly everything looks good, the linter and self work is fine. Can you make another pass through the current docs and make sure we are deleting stuff that should be and not deleting stuff that shouldn't?
Thanks for the help!

Hi Daryl,
Tried to review my own work , and found one edge case where it is really not clear Pin.af_list()  and which I cannot test myself lacking the hardware.
I think the rest checks out pretty well. Please see dfacd55 for documentation / rationale


Transfers filter is borked

search for "transfers borked 1867" on slack

I think you should write it here because TOSKA doesn't pay Slack so this search result will be gone when the memes go wild


[OSF-2052] Social share button should show up on Safari

Purpose
Due to browser differences, clicking on the "Share" button on a project page in Safari did nothing.
Changes
Use of onfocus and other events was changed to accommodate different browser behaviors.
Side effects
N/A
Ticket
https://openscience.atlassian.net/browse/OSF-2052

🎉 🐧 🎉


Exception Handler Does Account for Inheritance

Seems like when searching for an exception handler at https://github.com/channelcat/sanic/blob/master/sanic/exceptions.py#L173, the dictionary lookup is only for that specific exception type.
This is contradictory to the documentation saying You can pass SanicException to catch them all!.
Is there any other way to achieve the desired catch-all behavior as-is?

Should be fixed by #379


PHP 8.1 Compatibility

Deployer version: 7.0.0-rc4
Deployment OS: MacOS
PHP Version: 8.1.1

I'm trying to use Deployer in my local ddev TYPO3 environment with PHP 8.1 and i get the following error with dep init and dep --version :
ddev exec dep --version PHP Fatal error:  Uncaught ErrorException: dirname(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/vendor/deployer/deployer/bin/dep:96 Stack trace: #0 [internal function]: {closure}(8192, 'dirname(): Pass...', '/var/www/html/v...', 96) #1 /var/www/html/vendor/deployer/deployer/bin/dep(96): dirname(NULL) #2 /var/www/html/vendor/bin/dep(107): include('/var/www/html/v...') #3 {main}   thrown in /var/www/html/vendor/deployer/deployer/bin/dep on line 96 Failed to execute command dep --version: exit status 255
When I switch to PHP 8.0 everything works fine.
If I create an empty deploy.php and deploy.yaml I can use it with PHP 8.1. This error seems related to the following change in PHP 8.1:

Passing null to non-nullable internal function parameters is deprecated.

Keen to see php8.1 support added too.


341: Correct full file path casing upon initializing model

Added full file path case resolving for Windows, Linux and MacOS.
The resolving works differently for each OS.
For MacOS this can be performance heavy, depending on your file structure.

Review OK!


How to miner XNA

How to miner XNA？
And where do I can find the whitepapper？

Hey - i just saw this. I only mine XNA. I'm not a dev.

The whitepaper is on their website actually. To mine it like any Kawpow coin look for setting on hashrate no that is it