Hadoop 18325: ABFS: Add correlated metric support for ABFS operations

We have added support for collection of metrics at filesystem instance level. Whenever a filesystem close is called, we push metrics back to the store for all the operations that used that instance. The metrics collected include the no of succeeded requests without retrying, the no of requests which succeeded after x no of retries, the request count which was throttled, the count of requests which failed even after all the retries were exhausted.

:::: AGGREGATED TEST RESULT ::::
HNS-OAuth
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   TestAccountConfiguration.testConfigPropNotFound:386->testMissingConfigKey:399 Expected a org.apache.hadoop.fs.azurebfs.contracts.exceptions.TokenAccessProviderException to be thrown, but got the result: : "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider"
[INFO]
[ERROR] Tests run: 106, Failures: 1, Errors: 0, Skipped: 2
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   ITestAzureBlobFileSystemLease.testAcquireRetry:329 » TestTimedOut test timed o...
[INFO]
[ERROR] Tests run: 566, Failures: 0, Errors: 1, Skipped: 54
[INFO] Results:
[INFO]
[WARNING] Tests run: 332, Failures: 0, Errors: 0, Skipped: 41
HNS-SharedKey
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   TestAccountConfiguration.testConfigPropNotFound:386->testMissingConfigKey:399 Expected a org.apache.hadoop.fs.azurebfs.contracts.exceptions.TokenAccessProviderException to be thrown, but got the result: : "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider"
[INFO]
[ERROR] Tests run: 106, Failures: 1, Errors: 0, Skipped: 2
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   ITestAzureBlobFileSystemLease.testAcquireRetry:329 » TestTimedOut test timed o...
[INFO]
[ERROR] Tests run: 566, Failures: 0, Errors: 1, Skipped: 54
[INFO] Results:
[INFO]
[WARNING] Tests run: 332, Failures: 0, Errors: 0, Skipped: 41
NonHNS-SharedKey
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   TestAccountConfiguration.testConfigPropNotFound:386->testMissingConfigKey:399 Expected a org.apache.hadoop.fs.azurebfs.contracts.exceptions.TokenAccessProviderException to be thrown, but got the result: : "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider"
[INFO]
[ERROR] Tests run: 106, Failures: 1, Errors: 0, Skipped: 2
[INFO] Results:
[INFO]
[WARNING] Tests run: 566, Failures: 0, Errors: 0, Skipped: 276
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   ITestAbfsRenameStageFailure>TestRenameStageFailure.testResilienceAsExpected:126 [resilient commit support] expected:<[tru]e> but was:<[fals]e>
[ERROR]   ITestAbfsTerasort.test_110_teragen:244->executeStage:211->Assert.assertEquals:647->Assert.failNotEquals:835->Assert.fail:89 teragen(1000<EMAIL_ADDRESS>failed expected:<0> but was:<1>
[ERROR] Errors:
[ERROR]   ITestAbfsReadWriteAndSeek.testReadAndWriteWithDifferentBufferSizesAndSeek:69->testReadWriteAndSeek:86 » TestTimedOut
[ERROR]   ITestAbfsJobThroughManifestCommitter.test_0420_validateJob » OutputValidation ...
[ERROR]   ITestAbfsManifestCommitProtocol.testCommitLifecycle » OutputValidation abfs:/... [ERROR]   ITestAbfsManifestCommitProtocol.testCommitterWithDuplicatedCommit » OutputValidation [ERROR]   ITestAbfsManifestCommitProtocol.testConcurrentCommitTaskWithSubDir » OutputValidation [ERROR]   ITestAbfsManifestCommitProtocol.testMapFileOutputCommitter » OutputValidation ... [ERROR]   ITestAbfsManifestCommitProtocol.testOutputFormatIntegration » OutputValidation [ERROR]   ITestAbfsManifestCommitProtocol.testParallelJobsToAdjacentPaths » OutputValidation [ERROR]   ITestAbfsManifestCommitProtocol.testTwoTaskAttemptsCommit » OutputValidation ...
[INFO]
[ERROR] Tests run: 332, Failures: 2, Errors: 9, Skipped: 46
AppendBlob-HNS-OAuth
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   TestAccountConfiguration.testConfigPropNotFound:386->testMissingConfigKey:399 Expected a org.apache.hadoop.fs.azurebfs.contracts.exceptions.TokenAccessProviderException to be thrown, but got the result: : "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider"
[INFO]
[ERROR] Tests run: 106, Failures: 1, Errors: 0, Skipped: 2
[INFO] Results:
[INFO]
[WARNING] Tests run: 566, Failures: 0, Errors: 0, Skipped: 54
[INFO] Results:
[INFO]
[WARNING] Tests run: 332, Failures: 0, Errors: 0, Skipped: 41

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 20s

trunk passed

+1 :green_heart:
compile
0m 58s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 55s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 52s

trunk passed

+1 :green_heart:
mvnsite
1m  0s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 35s

trunk passed

+1 :green_heart:
shadedclient
20m 49s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 16s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 4 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 27s
/results-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 41 new + 9 unchanged - 0 fixed = 50 total (was 9)

+1 :green_heart:
mvnsite
0m 40s

the patch passed

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
1m 16s
/new-spotbugs-hadoop-tools_hadoop-azure.html
hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
20m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 22s

hadoop-azure in the patch passed.

-1 :x:
asflicense
0m 51s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

96m 16s

Reason
Tests

SpotBugs
module:hadoop-tools/hadoop-azure

Integral division result cast to double or float in org.apache.hadoop.fs.azurebfs.AbfsDriverMetrics.toString()  At AbfsDriverMetrics.java:double or float in org.apache.hadoop.fs.azurebfs.AbfsDriverMetrics.toString()  At AbfsDriverMetrics.java:[line 162]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4564

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 1776a15ec58b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a4774007b88ed879a257ed95e048398ec17883f9

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/1/testReport/

Max. process+thread count
629 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 27s

trunk passed

+1 :green_heart:
compile
0m 59s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 55s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 52s

trunk passed

+1 :green_heart:
mvnsite
1m  0s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 35s

trunk passed

+1 :green_heart:
shadedclient
20m 49s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 17s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 39s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 26s
/results-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 12 new + 9 unchanged - 0 fixed = 21 total (was 9)

+1 :green_heart:
mvnsite
0m 39s

the patch passed

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
1m 14s
/new-spotbugs-hadoop-tools_hadoop-azure.html
hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
20m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 23s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

96m 40s

Reason
Tests

SpotBugs
module:hadoop-tools/hadoop-azure

Integral division result cast to double or float in org.apache.hadoop.fs.azurebfs.AbfsDriverMetrics.toString()  At AbfsDriverMetrics.java:double or float in org.apache.hadoop.fs.azurebfs.AbfsDriverMetrics.toString()  At AbfsDriverMetrics.java:[line 187]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4564

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 06980693e123 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0f44a9bf4c38d473accb3a4e188f24063bdea831

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/2/testReport/

Max. process+thread count
728 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 25s

trunk passed

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 55s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 53s

trunk passed

+1 :green_heart:
mvnsite
1m  1s

trunk passed

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 33s

trunk passed

+1 :green_heart:
shadedclient
21m  7s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 34s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 26s
/results-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 9 new + 9 unchanged - 0 fixed = 18 total (was 9)

+1 :green_heart:
mvnsite
0m 39s

the patch passed

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
1m 14s
/new-spotbugs-hadoop-tools_hadoop-azure.html
hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
20m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 22s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

96m 30s

Reason
Tests

SpotBugs
module:hadoop-tools/hadoop-azure

Integral division result cast to double or float in org.apache.hadoop.fs.azurebfs.AbfsDriverMetrics.toString()  At AbfsDriverMetrics.java:double or float in org.apache.hadoop.fs.azurebfs.AbfsDriverMetrics.toString()  At AbfsDriverMetrics.java:[line 187]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4564

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 3ee4eb16c44b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 312853cb4395e27b6112f8002943395e97765dd5

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/3/testReport/

Max. process+thread count
738 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 31s

trunk passed

+1 :green_heart:
compile
0m 58s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 51s

trunk passed

+1 :green_heart:
mvnsite
0m 59s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 34s

trunk passed

+1 :green_heart:
shadedclient
22m 29s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
22m 57s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
0m 42s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 42s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 28s
/results-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 10 new + 9 unchanged - 0 fixed = 19 total (was 9)

+1 :green_heart:
mvnsite
0m 42s

the patch passed

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 11s

the patch passed

+1 :green_heart:
shadedclient
20m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 24s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

100m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4564

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 098ce6aa4e11 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4e99643d4c28a65e566364b5325879b681a62453

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/5/testReport/

Max. process+thread count
668 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 19s

trunk passed

+1 :green_heart:
compile
0m 59s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 51s

trunk passed

+1 :green_heart:
mvnsite
1m  0s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 29s

trunk passed

+1 :green_heart:
shadedclient
20m 56s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 23s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 38s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 27s

the patch passed

+1 :green_heart:
mvnsite
0m 40s

the patch passed

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 10s

the patch passed

+1 :green_heart:
shadedclient
20m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 20s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

97m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4564

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint

uname
Linux 191e5a24d513 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3abca57857ec2dbe746d70b60c9778ec9cb2128c

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/6/testReport/

Max. process+thread count
553 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 34s

trunk passed

+1 :green_heart:
compile
0m 56s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 44s

trunk passed

+1 :green_heart:
mvnsite
0m 56s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 27s

trunk passed

+1 :green_heart:
shadedclient
22m 58s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 19s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 36s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 10s

the patch passed

+1 :green_heart:
shadedclient
21m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 17s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

99m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4564

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint

uname
Linux c319003d237c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 386da871f54915fbbcf0931bb89735aafff98a05

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/7/testReport/

Max. process+thread count
554 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 32s

trunk passed

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 43s

trunk passed

+1 :green_heart:
mvnsite
0m 55s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 25s

trunk passed

+1 :green_heart:
shadedclient
21m 53s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
22m 18s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 36s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  8s

the patch passed

+1 :green_heart:
shadedclient
20m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 24s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

99m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4564

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint

uname
Linux 1010ff12f2b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 40868de10dc26228d48b6ca1f5e535bbd173bdcd

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/8/testReport/

Max. process+thread count
740 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 21s

trunk passed

+1 :green_heart:
compile
0m 48s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 42s

trunk passed

+1 :green_heart:
mvnsite
0m 55s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 22s

trunk passed

+1 :green_heart:
shadedclient
20m 51s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 13s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 22s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  9s

the patch passed

+1 :green_heart:
shadedclient
20m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 16s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

98m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4564

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint

uname
Linux 68f1c6d81d9a 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1f6827f39ff4875747fab8949bf67780c205d9c1

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/9/testReport/

Max. process+thread count
642 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4564/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Balanced distribution does not use all available resources when deliveries are streamed (Affects TCP and HTTP adaptors)

Balanced distribution does not properly take into account the existence of currently streaming deliveries and therefore does not always choose the best path for the distribution of load to all available destinations.
This will affect TCP and HTTP service traffic across an interior network where there are multiple routers along a path that have available destinations for the service traffic.
This does not affect the proper processing of service traffic.  It may, however, cause available resources (server instances) to be under-utilized or not utilized at all.

This fix can be disabled at run-time by setting the environment variable "SKUPPER_ROUTER_DISABLE_867_FIX" to any value in the router's process environment.


Copy data between the MBR and the first partition when resizing a preloader image.

Connects-To: #127
Change-Type: patch
---- Autogenerated Waffleboard Connection: Connects to #127

Just going to test this and report back.


hfnet inference with C++

Hi everyone, Thanks for @Skydes 's great work. hf-net is a state-of-the-art method in visual localization. But the origin inference code is written with Python. I modified the inference part with c++, also provide a docker image, I guess it is more convenient integration into other projects. (slam  or vio system)
The code is here:
https://github.com/TurtleZhong/hfnet_ros

Cool work, thanks for sharing it! Glad to see it running so fast. I am now closing this issue - feel free to reopen.


[Managed Iceberg] Support partitioning time types (year, month, day, hour)

Fixes #32865

@DanielMorales9 can you take a look at this one too?

I think a more scalable approach here would be to encapsulate the writing logic within a Parquet writer class. This would be similar to how Spark or Flink handle Parquet writes (e.g., i.e. SparkParquetWriter, FlinkParquetWriter), allowing you to manage the type conversions and partitioning requirements specific to Iceberg in a centralized and reusable way."

hey @DanielMorales9, would you like to take a look? the next Beam release is getting cut next week if we wanna get this in before then.

Hey @ahmedabu98, I am a bit concerned with the additional overhead you are introducing by recreating all records just to fit the types expected by the Iceberg partitioning logic. Imo, it should be done in a single place rather than scattered everywhere (such as in the timestamp issue we discussed some time ago).

Agreed it's not the most ideal. I expected all these conversions to be taken care of behind the scenes by Iceberg's partitioning logic, but looks like for time types we need to it on our side instead.

recreating all records just to fit the types expected by the Iceberg partitioning logic

We're not really recreating the records (i.e. not doing a fully copy). We're just creating an empty record and filling in the fields that we're partitioning on (ref). I found this to be the minimal implementation needed to make it work. In the average case, we should expect only a few fields to be populated, not the full record.
I'm open to suggestions though! hope I'm missing something

@DanielMorales9 others are beginning to ask for this feature as well. I'll try to find other reviewers in case you don't have time to look at this

assign set of reviewers

This more generally adds the partition fields functionality, right? It isn't just adding date/time support. Or am I misunderstanding?

Partitioning support was added in #32102 and already works with most fields (e.g. integer, float, string, etc.), but further handling is required for some time types. I decided to make most of this handling uniform for all types.


How can we manage external dependencies?

We need a "simple" enough way to instruct the user on how to start a PostgreSQL database, a RabbitMQ  broker, and any other dependencies we support in our wizards.
This is somewhat a challenging problem, so we should think of what would possible and what metadata we would need.

This depends on the stackable, so IMO every stackable should provide (the following options are alternatives):

A MD description of documentation that we can show inside Meraki, or
The documentation in the marketplace in the stackable page, with a link to it in Meraki (or we might open the marketplace page directly inside Meraki, with the caveat that the use might need to be authenticated on the marketplace to see the  documentation page).


Design syntax for using Lightning from SQL

Feature Request
Is your feature request related to a problem? Please describe:

Integrating Lightning into TiDB requires an SQL syntax.
Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Optimization:

Referring to pingcap/parser#746, we will support use the syntax like this:
IMPORT DATABASE * FROM 'file:///data/sql_dump';
IMPORT TABLE db1.tbl1, db1.tbl2 FROM 'file:///data/csv_dump';

-- lightning options
IMPORT DATABASE * FROM 'file:///data/csv_dump'
    CHECKSUM = 0
    ANALYZE = 0
    CHECKPOINT = 0;

-- view tasks
SHOW IMPORT;
SHOW IMPORT LIKE '%csv%';
SHOW IMPORT WHERE `Progress` = 'Wait';

The main issue is to sort out the list of options to be exposed.


build failed on win64

I followed your instructions, I can successfully build win32 version under mingw. But i have some problem on win64 version. The difference between win32 and win64 is:
win32: make OS=msvc ARCH=i386
win64: make OS=msvc ARCH=x86_64
when I build win64, it has following errors:
codec/common/x86/cpuid.obj : fatal error LNK1112: module machine type 'x64' conflicts with target machine type 'X86'
make: *** [common.lib] Error 88

i tried replace export LIB="C:\Program Files (x86)\Windows Kits\8.1\Lib\winv6.3\um\x86;C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\lib" under win32 with export LIB="C:\Program Files (x86)\Windows Kits\8.1\Lib\winv6.3\um\x64;C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\lib\amd64"

please open the file msvc-common.mk (in build dir)
modified to
include $(SRC_PATH)build/arch.mk
ifeq ($(ASM_ARCH), x86)
ASMFLAGS += -f win32 -DPREFIX
ifeq ($(ARCH), x86_64)
ASMFLAGS += -f win64
ASMFLAGS_PLATFORM = -DWIN64
else
endif
else
endif
......


Poor Error when using Pivnet Resources

When using the PCF-Pipelines to deploy PCF 1.12 on AWS with concourse I hit the following error:
2017/12/28 21:50:08 PivNet Resource version: 0.31.5
2017/12/28 21:50:08 Creating download directory: /tmp/build/get
2017/12/28 21:50:08 Getting release for product slug: 'elastic-runtime' and product version: '1.12.9'
2017/12/28 21:50:08 Accepting EULA for release with ID: 9710
2017/12/28 21:50:08 Getting product files
2017/12/28 21:50:08 Getting file groups
2017/12/28 21:50:10 Getting release dependencies
2017/12/28 21:50:11 Getting dependency specifiers
2017/12/28 21:50:11 Getting release upgrade paths
2017/12/28 21:50:12 Getting upgrade path specifiers
2017/12/28 21:50:12 Downloading files
2017/12/28 21:50:12 Filtering download links by glob
2017/12/28 21:50:12 Downloading filtered files
2017/12/28 21:50:12 Downloading: 'PCF Elastic Runtime' to file: '/tmp/build/get/cf-1.12.9-build.3.pivotal'
 2.44 GiB / 8.01 GiB [=============>-----------------------------]  30.44% 1m17spanic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x62e2bc]

goroutine 122 [running]:
github.com/pivotal-cf/pivnet-resource/vendor/github.com/pivotal-cf/go-pivnet/download.Client.retryableRequest(0x848fa0, 0xc420079410, 0x849e20, 0xc42006a958, 0x84e180, 0xc42050b4a0, 0x84b120, 0xc4200e2520, 0xc420546240, 0x235, ...)
    /tmp/build/80754af9/gopath/src/github.com/pivotal-cf/pivnet-resource/vendor/github.com/pivotal-cf/go-pivnet/download/downloader.go:165 +0x27c
github.com/pivotal-cf/pivnet-resource/vendor/github.com/pivotal-cf/go-pivnet/download.Client.Get.func1(0x7572742d00000008, 0x70a688)
    /tmp/build/80754af9/gopath/src/github.com/pivotal-cf/pivnet-resource/vendor/github.com/pivotal-cf/go-pivnet/download/downloader.go:93 +0xb3
github.com/pivotal-cf/pivnet-resource/vendor/github.com/pivotal-cf/go-pivnet/vendor/golang.org/x/sync/errgroup.(*Group).Go.func1(0xc42025ce80, 0xc420147b00)
    /tmp/build/80754af9/gopath/src/github.com/pivotal-cf/pivnet-resource/vendor/github.com/pivotal-cf/go-pivnet/vendor/golang.org/x/sync/errgroup/errgroup.go:58 +0x57
created by github.com/pivotal-cf/pivnet-resource/vendor/github.com/pivotal-cf/go-pivnet/vendor/golang.org/x/sync/errgroup.(*Group).Go
    /tmp/build/80754af9/gopath/src/github.com/pivotal-cf/pivnet-resource/vendor/github.com/pivotal-cf/go-pivnet/vendor/golang.org/x/sync/errgroup/errgroup.go:55 +0x66

I did end up getting around the error by sizing up the ephemeral disk size on the concourse worker nodes, but it would be helpful for a better error rather than a seg fault.

@robdimsdale Had some great ideas why this was happening such as checking the status of a type assertion. Feel free to add more!

I noticed that https://github.com/pivotal-cf/pivnet-resource/blob/master/vendor/github.com/pivotal-cf/go-pivnet/download/downloader.go#L164 isn't checking the outcome of the type assertion of the error, which could lead to nil pointers a couple of lines below.
Given that providing more disk resolved the issue, it's not clear that there is any underlying issue that needs to be fixed beyond a more helpful error message.


Vertical navigation to site

I've left comments to @navkaur76 in the Figma file

500 Error
https://saltdesignsystem-git-vertical-nav-to-site-fed-team.vercel.app/salt/patterns/navigation/index


Replace registry imports with registry.get()

With the correct spaCy version available, imports such as from spacy.ml import extract_ngram are replaced with
extract_ngrams = registry.get("layers", "spacy.extract_ngrams.v1") .
Changes in:

architecture/textcat.py
architecture/parser.py
loggers.py

Updated the requirement


Shuffle the list of secure etcd endpoints if the client fails to connect to first endpoint.

ETCD client has a bug in its failover/connection code where it fails to connect a secure etcd cluster
if the first endpoint is down.

The change is to shuffle the list of endpoints and try connecting again. This is done regardless of
what error is returned when connecting for the first time.

Not doing this for non-secure etcd, as this is already handled by the etcd client.

ETCD has fixed this problem in the recent releases, but that involves changing grpc dependencies. Hence this is a stop gap solution.

More details here: https://kubernetes.io/docs/tasks/administer-cluster/configure-upgrade-etcd/#known-issue-etcd-client-balancer-with-secure-endpoints
Known issue: All the watches exit if the first endpoint goes down.

"ETCD has fixed this problem in the recent releases, but that involves changing grpc dependencies. Hence this is a stop gap solution."

We need to update the vendor'ed packages for etcd/clientv3 and grpc

etcd to version 3.2.14
grpc to 1.22


img-src and v-html not updating to new values after hydration

Vue version
3.3.4
Link to minimal reproduction
https://stackblitz.com/edit/github-vxyebj-admpj8?file=src%2FApp.vue
Steps to reproduce
i was stumbling on problems with certain stuff not getting updated to new values after hydration using pregenerated sites with Nuxt 3. (see issue with reproduction here: https://github.com/nuxt/nuxt/issues/22784)
after looking at it, Daniel concluded, it was a a vue-related problem, visible in the reproduction provided in this here issue. here is the code:

<template>

    These values should all be equal:

    {{ timestamp }}

</template>

What is expected?
That the contents of the img src attribute and v-html get updated with the new value of the timestamp  ref after hydration.
What is actually happening?
The server-generated img src attribute and v-html stay the same - not getting updated to the new value.
System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.20.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.6.10 - /usr/local/bin/pnpm
  npmPackages:
    vue: ^3.3.4 => 3.3.4

Any additional comments?
No response

The issue title is a bit misleading. The values don't change after hydration - rather, there's a hydration mismatch because the SSR state that's reflected in the server's HTML was different from the client-side state when hydration is being performed.
So the problem here is that during hydration, when  when the mismatch is found, the render does not update the DOM with the client-side values.


Update README.markdown

Get optimized

Hi there !
Actually, #611 fixed this but thanks for the patch anyway ! :-)


Use shared update-step action

skills/action-update-step
Summary
"TODO UPDATE" of #25
:warning: skills/action-update-step#14 should be merged and released before.
Changes
Delete the custom step and use shared update-step action.
The action skills/action-update-step with to_step: 45X will update -step.txt to "45X", and README.md body to the Steps 4, 5 and X concatenated in the course.
Task list

[x] For workflow changes, I have verified the Actions workflows function as expected.
[x] For content changes, I have reviewed the style guide.

👋 @sinsukehlab Thanks so much for opening a PR! I'll get this triaged for review :zap:

@cmwilson21 @hectorsector @heiskr The course will need<EMAIL_ADDRESS>(skills/action-update-step#14) with this PR merged. The current action-update-step<EMAIL_ADDRESS>will just try to show 45X-*.md (no such files). Please review and merge the PR skills/action-update-step#14 as soon as possible.


Problem with naming reference objects

Hello. I'm trying to create models with no root schema, and all of its content is exposed in definitions. The following json schema snippet will be converted to ICollection <Items> Items.
          "properties": {             "items": {               "type": "array",               "items": {                 "$ref": "other.json#/definitions/offer"               }             }           }
But I would like the class to be called Offer. That is, by the name of the reference element, not the name of the property that refers to it.
At what stage is this name assigned?

Internally it would use the typeNameHint "items" which is translated to "Items"... we need to improve that so that if there is a reference like this, it would use "offer" as hint => "Offer"

Or probably you could add a "title" property to the "offer" schema with the content "Offer" and it would use that...

Hi Rico,
We are having the same problem, this is our main schema:
{   "title": "MyHead",   "type": "object",   "properties": {     "id": {       "type": "string"     },     "legs": {       "type": "array",       "items": {         "$ref": "my_leg.json"       }     }   },   "additionalProperties": false }
and this is a referenced schema my_leg.json:
{   "title": "MyLeg",   "type": "object",   "properties": {     "id": {       "type": "string"     }   },   "additionalProperties": false }
We use this code to generate C# code:
var generator = new CSharpGenerator(schemaFile.Schema, new CSharpGeneratorSettings()                 {                     Namespace = schemaFile.GetNamespace(),                     GenerateJsonMethods = false,                     GenerateOptionalPropertiesAsNullable = true,                     GenerateDataAnnotations = false,                     HandleReferences = false,                     AnyType = "Newtonsoft.Json.Linq.JObject",                 });                 var types = generator.GenerateTypes(schemaFile.Schema, schemaKey.Title).Reverse();
Although the title is set in referenced schema, generated C# code returns this:
`public partial class MyLeg
{
public string Id { get; set; }
}
public partial class MyHead
{
public string Id { get; set; }
public System.Collections.Generic.ICollection<My_leg> Legs { get; set; }
}`
The name of the referenced class is "My_leg" instead of "MyLeg".
Are we missing something or is this a valid issue?


Not all devices respond any more

As of today, only the first 6 devices seem to be controllable via Alexa.
I have defined 8 devices as multiple sockets in the source code. Everything has worked well until today. But then I could no longer address individual devices (the first 6 devices work, the last two do not respond according to Alexa).
Does anyone have similar problems?

It must have been an Amazon/Alexa problem. When removing a non-functioning device from the Alexa app, I noticed that it immediately reappeared as a new device. I was able to delete the same device 5 times. After that, it had really disappeared and first had to be found again via the device search. Now everything works again as before.


Support for goOffline, onDisconnect().setValue() in core and Android

Is your feature request related to a problem? Please describe.
I am glad to find this library to support Firebase realtime database in libgdx. You are life saver. I try to implement DatabaseReference.goOffline() and goOnline to manually connect database or disconnect but I couldn't find that API. I also cannot find DatabaseReference.onDisconnect() to set value or remove value in database when disconnect the database. Those are important features in my project. Hope it will be implemented. Or tell me how to implement it in this library under current version.
Describe the solution you'd like
goOnline(), goOffline(), onDisconnect().setValue(value), onDisconnect().removeValue()
I would like you can add those APIs I mentioned above.

Hello @wangdong20 ! good to hear :)
There is an existing API to listen on connection change.  Example:
        GdxFIRDatabase.inst()
                .onConnect()
                .after(GdxFIRAuth.inst().signInAnonymously())
                .then(new Consumer<ConnectionStatus>() {
                    @Override
                    public void accept(ConnectionStatus connectionStatus) {
                        if (connectionStatus == ConnectionStatus.CONNECTED) {
                            // connection done!
                        }
                    }
                });

is it something you are looking for?

It would be better to implement DatabaseReference.onDisconnect().setValue or remove value API for me. Is there also goOffline, goOnline API to disconnect or connect the database manually? Like this APi page API

@wangdong20   👍 make sense.  I will look on that

@wangdong20 sorry for huge delay. I didn't have so many free hours to take some gdx-fireapp topics.
but 🥁🥁🥁🥁🥁 good news 🥳 the feature is almost there. It should be release today/tomorrow.
There will be a support for methods:
onDisconnect().removeValue()
onDisconnect().setValue(object)
onDisconnect().cancel()
.goOnline()
.goOffline()

@wangdong20  pls check version 3.3.0. I've added a few exampels in WIKI


Configure Tasks by type instead of only specific named Tasks

Configure Tasks by type (e.g., JavaCompile, JavaExec) instead of only specific named Tasks (e.g., "compileJava", "run").
This will enable module usage for all source sets, all java executions, etc.

This is not an issue anymore with the Module support in Gradle 6.4+.


Unexpected ibm-api-symmetry warning with dictionary

I am getting validation warning ibm-api-symmetry with an openapi spec that includes a dictionary following https://swagger.io/docs/specification/v3_0/data-models/dictionaries/ :
$ lint-openapi error_example.yaml --log-level ibm-api-symmetry=info
IBM OpenAPI Validator (validator: 1.20.0), @Copyright IBM Corporation 2017, 2024.

Validation Results for error_example.yaml:

[INFO] ibm-api-symmetry: checking variant schema DevicePrototype against canonical schema Device
[INFO] ibm-api-symmetry: schema defines 'additionalProperties' - it is not a proper graph fragment
[INFO] ibm-api-symmetry: nested object property input_parameters is not a graph fragment of canonical property input_parameters
[INFO] ibm-api-symmetry: nested object property device_config is not a graph fragment of canonical property device_config
[INFO] ibm-api-symmetry: nested object property details is not a graph fragment of canonical property details
[INFO] ibm-api-symmetry: variant schema DevicePrototype is not a graph fragment of canonical schema Device
Warnings:

  Message :   Variant schema should be a graph fragment of the canonical schema
  Rule    :   ibm-api-symmetry
  Path    :   components.schemas.DevicePrototype
  Line    :   120

Summary:

  Total number of errors   : 0
  Total number of warnings : 1

  Warnings:
   1 (100%) : Variant schema should be a graph fragment of the canonical schema

I am using this version:  validator: 1.20.0; ruleset: 1.19.0 (default)
Here is the yaml file that generates the warning: error_example.txt
Is this a legitimate warning?
I guess it is not because if I define input_parameters in DeviceConfiguration as a string instead of a dictionary, no warning is generated, so I guess it has to do with the dictionary definition. In addition, if I comment the path /devices/{device_id} (lines 14 to 36 in the file) no warning is generated either.
Is there anyway to skip the validation for this input_parameters?
Thanks for your help.

Taking a look to the code in here, it seems that if the variant defines additionalProperties it not considered a graph fragment.

That's correct - if the variant schema is a dictionary, it may contain properties that are not (or even cannot) be represented on the canonical schema, which would violate the graph fragment pattern.

That's correct - if the variant schema is a dictionary, it may contain properties that are not (or even cannot) be represented on the canonical schema, which would violate the graph fragment pattern.

Thanks for the answer. Does it mean that the use of dictionaries is not allowed in variant schemas?

Does it mean that the use of dictionaries is not allowed in variant schemas?

Upon looking at your API in more detail, I actually think that this case may be allowed since the two schemas are using the same dictionary property. I will go over the code and confirm whether or not this is intended behavior or a bug. Thanks for opening the issue.

@vsandonis after review, this should not be a warning. I'll mark this as a bug and will update the code soon.


sell should emit Transfer event

so that etherscan shows correct balance
E.g. an address has 300k of tokens, yet etherscan shows 600k because he doesn't see outgoing tx.

There is no ERC20 transfer event in our nutz satellite contract during sell. Only a custom Sell event. Wont we need to change the nutz satellite for this?

unfortunatelly this is correct.
It is a tough call: it is not good to change satellite, but later it will be hardly ever possible once NTZ is listed on exchanges.
We can fix this and do not upgrade unless we absolutely need to (hopefully this will never happen). Or we can upgrade at some point before NTZ is listed. I'm not sure

/cc @johannbarbie

Right now we can follow this protocol if we really want to update this:-

Move floor to infinity.
Allocate ether to the escrow council
Withdraw ether from the pullPayment.
Deploy new nutz satellite
Set in controller
Transfer back all ether to the nutz contract (can be done in the constructor itself)

I just checked this guys balance again. I see 0 nutz. And @johannbarbie pointed out that the event Transfer is just used to list addresses on etherscan and balanceOf is used to read the balances. And now that I check the balance of this guy, I can see 0 NTZ https://etherscan.io/address/0xcb51bd23930330fd96cb5646dbf9e17c87a4d769

And now that I check the balance of this guy, I can see 0 NTZ

That is correct, because he exchanged all his NTZ and withdrew ether. Somehow etherscan now shows the right balance even though exchange transactions are not shown — there are should be two OUT transactions 300k NTZ each.

True. I have anyhow made a nutz satellite change and upgrade event change in case we change our minds about changing this in the future.

We have branch fix/NutzTransferBug for whenever we want to fix this.


Maybe wrong error about confusing snippet-variables and snippet-placeholders

Issue Type: Bug
Hello, I am the creator of a very simple snippets for javascript extension.
I am getting the following error message while debuging my extension:
[danielo515.danielo-node-snippets]: One or more snippets from the extension 'danielo-node-snippets' very likely confuse snippet-variables and snippet-placeholders (see https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax for more details)

I double checked the snippets syntax and I'm sure it is correct. In fact, if I debug the extension all the snippets are available on any JS file, but when it get's plubished the ones using variables with the ${...} syntax are not offered as an option. The same snippets also works if I add them as a personal snippet to my personal javascript.json extensions file.
You can see the extension snippets (just one fille) here: https://github.com/danielo515/vscode-node-snippets/blob/7920f445b5224c0f2a6a4ad3adb475178e9685c1/snippets/snippets.json#L58
I will be very grateful if you explain to me what is wrong because according to docs my snippets are correct.
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:22:55.268Z)
OS version: Darwin x64 17.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 2900)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 3

Memory (System)
32.00GB (5.99GB free)

Process Argv

Screen Reader
no

VM
0%

It's likely the $object, see https://github.com/danielo515/vscode-node-snippets/blob/7920f445b5224c0f2a6a4ad3adb475178e9685c1/snippets/snippets.json#L91

Thanks for your answer @jrieken, but according to documentation that syntax is correct for placeholders:
https://code.visualstudio.com/docs/editor/userdefinedsnippets#_variables

When a variable is unknown (that is, its name isn’t defined) the name of the variable is inserted and it is transformed into a placeholder.

Maybe that is not supported anymore and you must use existing variables or placeholders? But that is for sure not what documentation says.

That's to be understood as mitigation in the presence of such unknown variables (and the reason for the warning). For some time we wrongly supported that syntax (which isn't valid Textmate) If at a future point $object becomes a variable, your snippet will change and that's why we want to migrate snippets to the correct syntax.

Yes, I totally understand. But the fact that it is supported on normal snippet files but disabled on extensions is what is confusing. I don't have a problem now that I know it, but probably it could confuse other people. Maybe if you add a more concrete message about this on the docs or on the error message (eg, unknown variable used...)
Regards


Remove unused constant from Package.swift

relatedDependenciesBranch is no longer used in the package manifest.

@swift-ci please test


storage: object management

Objects are the individual pieces of data that you store in Google Cloud Storage

Is the functionality in master sufficient to close this?


bcrypt compare returns false all the time

Hi there,
I'm implementing user authentication using bcrypt. Bcrypt compare is returning false despite the password being correct. Interestingly, bcrypt compare works on a local db but not on a hosted remote db. (not a password string length issue) Any idea what might be the problem?
UserSchema.methods.validPassword = function (password, next) {
    var user = this;

    bcrypt.compare(password, user.password, function (err, isMatch) {
        if (err) {
            console.log('PW COMPARE ERR: Validation process failed')
            next(err)
        };

        next(null, isMatch)
    })
};

Sorry it was entirely my own issue. Rectified & closed

i am faceing the same problem - what was your mistake? maybe its mine too...

if you're using mongoose and using bcrypt hash in the pre-save method of
mongoose in the models, make sure in your function you're only calling
'save' once. If not hash will be called more than once which will naturally
fail bcrypt compare.
Again, this is my own error entirely unrelated to bcrypt
On Sun, May 24, 2015 at 11:18 AM ms88privat<EMAIL_ADDRESS>wrote:

i am faceing the same problem - what was your mistake? maybe its mine
too...
—
Reply to this email directly or view it on GitHub
https://github.com/shaneGirish/bcrypt-nodejs/issues/45#issuecomment-104972572
.

thanks you, i was having a similar mistake.


Promote AdminKubeconfigRequest feature gate to beta

How to categorize this PR?

/kind enhancement
What this PR does / why we need it:
The AdminKubeconfigRequest feature gate  in the apiserver has been promoted to beta.
Special notes for your reviewer:
@BeckerMax
Release note:

The `AdminKubeconfigRequest` feature gate in the `apiserver` has been promoted to beta and is now enabled by default.

/invite @ialidzhikov

/assign @petersutter
Ref https://github.com/gardener/gardener/blob/889f5506e0be3342e38207b2615e54e719ff3d66/pkg/features/features.go#L86

Change itself lgtm but cannot judge feature-wise whether it is ready for beta (enabled by default) - @petersutter any input from you side wrt to this question will be appreciated.

@ialidzhikov from what I can tell this feature works very reliable. Up to now I haven't had any issues whatsoever, and haven't heard of any issues from colleagues using g/gardenlogin (which internally calls this API).
/lgtm


[MNT] - Warning on scipy.stats.mode

As of scipy version 1.9.0, there is a new 'keepdims' argument in scipy.stats.mode that needs to be set for future-proofing, and will start to fail in scipy version 1.11.0: https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.mode.html
This relates to the use of scipy.stats.mode here:
https://github.com/HSUPipeline/convnwb/blob/main/convnwb/timestamps/align.py#L168
For future scipy usage, this could be updated to:
ixis_mode = stats.mode(ixis, keepdims=True)[0][0]
Or, equivalent updates:
ixis_mode = stats.mode(ixis, keepdims=True).mode[0]
ixis_mode = stats.mode(ixis, keepdims=False).mode
Basically - the fix is easy, but need to decide whether to enforce a specific version of scipy, and/or do a version check.

sync_behav_out, sync_neural_out = match_pulses(sync_behav, sync_neural, n_pulses=500, start_offset=100)
Change start_offset number has a significant effect on the output

This is now fixed, by adding a version check, so both old and new scipy versions should work.

def match_sync_pulses(task, n_pulses, start_offset=None, tolerance=0.001):
start_offset = None
sync_behav = task.sync['process']['behave']
sync_neural = task.sync['process']['neural']
isi_sb = np.diff(sync_behav) / 1000  # Convert to seconds
isi_sn = np.diff(sync_neural)

# List to collect index offsets for matching ISIs
ixis = []

# Define a tolerance for matching ISIs
tolerance = 0.01  # Adjust based on acceptable tolerance

# Iterate through neural sync pulses and collect index offsets for matching ISIs
for ixn, isi in enumerate(isi_sn):
    # Use np.isclose to find if there are any close matches in isi_sb
    matches = np.isclose(isi_sb, isi, atol=tolerance)

    # Check if any matches are found
    if np.any(matches):
        # Get the index of the first match
        ixb = np.where(matches)[0][0]

        # Check if the next ISI exists and also matches
        if ixn + 1 < len(isi_sn) and ixb + 1 < len(isi_sb):
            if np.isclose(isi_sn[ixn + 1], isi_sb[ixb + 1], atol=tolerance):
                # If both current and next ISI match, record the index offset
                ixis.append(ixb - ixn)
                print(f"Match found at {ixn} with offset {ixb - ixn}")
        #else:
            # No next match or reached end of arrays
            #ixis.append(ixb - ixn)
ixis_mode = stats.mode(ixis)            #print(f"Match found at {ixn} with offset {ixb - ixn}")
print(ixis_mode)
if start_offset is not None:
        # Choose sync vector starting at chosen index rather than the beginning
        sync_behav_out = sync_behav[ixis_mode.mode + start_offset : ixis_mode.mode + start_offset + n_pulses-ixis_mode.mode]
        sync_neural_out = sync_neural[start_offset : start_offset + n_pulses-ixis_mode.mode]
else:
        # (STANDARD) Sync vector from beginning with offset accounted for
        sync_behav_out = sync_behav[ixis_mode.mode: ixis_mode.mode + n_pulses-ixis_mode.mode]
        sync_neural_out = sync_neural[0 : n_pulses-ixis_mode.mode]
return sync_behav_out,sync_neural_out

Convnwb version: 0.4.0-dev
Scipy version: 1.11.1


SliverList inside SliverList

I've run into large scrolling lists. Sometimes you need to write multiple recursive SliverLists.
I used one package (https://pub.dev/packages/sliver_tools) to solve this problem but you can't use MutliSliverList as Builder.
This doesn't work properly if you have 10,000 items (lazy loading, etc.)
Also, you can't add a background color for Sliver Lists, which is a little problematic.
Let's find a new way to implement this or something like that?

@Hellomik2002
Can you provide `flutter doctor -v, a complete minimal reproducible code sample that shows the current behavior / limitation you are facing ? And what are you trying to achieve exactly ?

For example, you have list items in a list and they have a background color.
I could do Column, with SliverList (Builder) but they can have 100 items inside

a complete minimal reproducible code sample that shows the current behavior / limitation you are facing ?

@Hellomik2002

EXAMPLE
import 'dart:developer';

import 'package:flutter/material.dart';

const sssColor = [
  Colors.red,
  Colors.orange,
  Colors.cyan,
  Colors.brown,
  Colors.lime,
];

class TrainerMainPage extends StatelessWidget {
  const TrainerMainPage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.white,
      appBar: AppBar(),
      body: CustomScrollView(
        slivers: [
          const SliverToBoxAdapter(
            child: SizedBox(height: 30),
          ),
          const SliverToBoxAdapter(
            child: SizedBox(height: 30),
          ),
          const SliverToBoxAdapter(
            child: SizedBox(height: 30),
          ),
          const SliverToBoxAdapter(
            child: SizedBox(height: 30),
          ),
          ...List.generate(
            10000,
            (_) => SliverList(
              delegate: SliverChildBuilderDelegate((ctx, _) {
                return Container(
                  height: 50,
                  color: sssColor[_ % sssColor.length],
                );
              }),
            ),
          )
        ],
      ),
    );
  }
}

@Hellomik2002
Can you take a look at NestedScrollView and see if it helps to achieve your purpose ? https://api.flutter.dev/flutter/widgets/NestedScrollView-class.html
Also, take a look at this gist and see if it helps.

NestedScrollView is a good solution but not for this purpose.
Here I have another problem.
I have a huge number of items that contain an almost equally huge number of items inside them. The NestedScrollView does not serve the purpose of loading this data as a high flowing builder. I need something more adaptive to higher loads. Again, what has the feature of "Nested" in NestedScrollView is the header, whilst I need this feature in body. Are there any widgets from material.dart of any 3rd party packages that can help me execute this without changing their library?

@Hellomik2002
I would suggest you to ask this question on support channels like StackOverflow to get a solution on how to implement nested sliverlist to achieve your use case and to know about any 3rd party plugins to do the same.
Closing from here. If you are looking to propose a change in the sliverlist or a bug, then write in comments and I'll reopen it.

Slivers are limited, NestedScrollView can not nest Scroll from another scroll, You can not combine a lot of Scroll widgets in Nested Sliver List.
I don't want to write List.generate(10 000)
or Write Super hard logic to implement that.
Slivers have a lot of limits, You can not put background Color for Example
of course I can put Container or DecoratedBox widget, but the Phone will be forced to render all Items, and if you have 10k items it is inappropriate.
If you change the background color of every item, You will see a lines between them with the Color of the under widget.

@Hellomik2002
It seems you highlighted current limitation of Slivers. I suggest you to open a new issue and use the new issue template and fill out all requested details and clearly highlighting the limitation or current behavior you are seeing and what changes you would like to see using it, that'll help us to address the issue properly.


fix flaky gitrepo test

Summary
Fixes #
gitrepo.spec.ts > "in git repo details view we should display the correct bundle count" test is failing consistently in CI with an assertion error
AssertionError
Timed out retrying after 10000ms: Expected to find element: [data-testid="gitrepo-bundle-summary"] .count, but never found it. Queried from element: <div.dashboard-root>
Checklist

[x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[x] The PR has a Milestone
[x] The PR template has been filled out
[x] The PR has been self reviewed
[x] The PR has a reviewer assigned
[x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[ ] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

going a different route to fix this issue. closing this pr


Class 06

I've gotten the JSON stuff working for the home section (with the images and descriptions), but haven't yet gotten it to work for the about page. This is sort of still in progress! I will try and get it up and running today.


Set ratelimit for rsyslog

Merged into https://github.com/OpenConext/Stepup-Deploy/tree/branch-release-23.1


Permissions not actively loaded

Expected Behaviour
Setting the permissions in a PDF Protect operation should determine edit/copy/print permissions in the resulting PDF
Actual Behaviour
Permissions are always set to:
"permissions": {
      "assistive_technology": true,
      "form_filling": false,
      "copying": false,
      "page_extraction": true,
      "document_assembly": false,
      "commenting": false,
      "printing": "none",
      "editing": false
    }

Reproduce Scenario (including but not limited to)
I've merged this sample:
https://github.com/adobe/pdfservices-node-sdk-samples/blob/master/src/protectpdf/protect-pdf-with-owner-password.js
With this sample:
https://github.com/adobe/pdfservices-node-sdk-samples/blob/master/src/pdfproperties/pdf-properties-as-json.js
And the resulting PDF's properties indicate that permissions haven't been set correctly AFAIK
Platform and Version
Currently using
"@adobe/pdfservices-node-sdk": "^2.1.0"
With
node.js v16.5.0

Hi @code-jorge , issues here should address problems in the samples for this repo. To raise any issues related to your custom code usage, please use our community forum for better tracking.
Link to the community forum: https://community.adobe.com/t5/document-services-apis/ct-p/ct-Document-Cloud-SDK


this mod breaks my pc

i dont know how you wrote it but holy shit i cant even create a crash file for you because my ENTIRE pc hardcrash when trying to start with a fresh install of fabric 1.19.3 with only ur mod
hardware (new and all drives up todate)
12600k
rx 6600
500ssd
16gb ram 3200rz
win11 october update

weird... i can't see how this would cause a hard crash though, as it doesn't do anything dangerous that could make that happen in the first place.

unless you have an event viewer log, i don't know how i can help or fix this. Even on windows i can't force this kind of crash.

Nothing is really happening here, so I'm going to close.

Does this happen with other mods?
How much RAM do you have?
Have you checked your computer for malware? I would recommend using Windows Defender or Malwarebytes.
What graphics card are you using? If you aren't using a graphics card, what processor are you using?


chore: prepend @aws-amplify to dependencies pt.3

Description of changes
Dependencies Prepending aws-amplify to :

cli-shared-interfaces
amplify-console-hosting
amplify-container-hosting
amplify-dotnet function-runtime provider
amplify-dotnet template provider.

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[n/a] Relevant documentation is changed or added (and PR referenced)
[n/a] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[x] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

this passed e2e tests but failed lint tests because this was out of date with dev branch

addressed all comments, would appreciate another round of eyes 👍🏼

Codecov Report

Merging #11954 (535b772) into dev (984c0f8) will decrease coverage by 3.53%.
The diff coverage is 57.68%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev   #11954      +/-   ##
==========================================
- Coverage   49.45%   45.92%   -3.53%
==========================================
  Files         692      820     +128
  Lines       33424    37637    +4213
  Branches     6840     7727     +887
==========================================
+ Hits        16529    17284     +755
- Misses      15370    18671    +3301
- Partials     1525     1682     +157

Impacted Files
Coverage Δ

...y-appsync-simulator/src/resolvers/unit-resolver.ts
90.32% <0.00%> (ø)

...ages/amplify-appsync-simulator/src/schema/index.ts
70.68% <0.00%> (-1.25%)
:arrow_down:

...s/amplify-appsync-simulator/src/type-definition.ts
100.00% <ø> (ø)

...tor/src/velocity/util/transform/dynamodb-filter.ts
4.93% <0.00%> (ø)

...ync-simulator/src/velocity/util/transform/index.ts
21.05% <0.00%> (ø)

...appsync-simulator/src/velocity/value-mapper/map.ts
86.88% <ø> (ø)

...ackages/amplify-category-auth/src/commands/auth.ts
0.00% <0.00%> (ø)

...es/amplify-category-auth/src/commands/auth/help.ts
0.00% <0.00%> (ø)

.../amplify-category-auth/src/commands/auth/import.ts
0.00% <0.00%> (ø)

...vice-walkthrough-types/cognito-user-input-types.ts
100.00% <ø> (ø)

... and 447 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add Temporal Fusion Transformer (TFT)

Description
Add Temporal Fusion Transformer (TFT)
References

https://arxiv.org/pdf/1912.09363.pdf
https://github.com/jdb78/pytorch-forecasting

There's a PR open here: https://github.com/awslabs/gluon-ts/pull/962
this is coming.

Awesome! Thanks!

@skybullet1987 #962 got merged

Hi @lostella,
I am quite interested in this model. I saw that it was merged, but I can't find it in the documentation or the milestone.
I am not in a particular rush about this, but I am just curious to know when this will make it into an official release?
Cheers,
Alex

@alexcombessie the model will be included in the next release v0.6.0; we've been delaying this release a bit, but all necessary commits should be there, so this should be released somewhere next week. In the mean time, if you want to try it out you can play with the master branch

@alexcombessie v0.6.0 was released, is available on PyPI, and contains the TFT implementation

I saw that yesterday, thanks for the kind message. I am genuinely amazed by the release, not just for the new TFT model. You are doing amazing work!


Join efforts with jstoone/HTMLFormValidator

See jstoone/HTMLFormValidator#1 - some reviews are really relevant for this repo as well /cc @jstoone
Sorry for not notifying that @jstoone was already giving it a shot, I just really want to avoid having you folks work on 20 flavors of the same thing while maybe repeating the same thought process.
If you are interested in working on it, maybe you should team up before you reach a stable API =)

Ok, thanx for letting me know. I'll stop with this and will watch the repo from @jstoone. I'll try to help out there when I can.

@xtreamwayz no need to stop, just make sure you two have a chat or something =D

Thanks for referencing my repo, @Ocramius.
When I'm done with the new PR, featuring the changes mentioned in my last PR, I'll be sure to drop a note here on the thread, if you are interested @xtreamwayz?
Happy holidays.


Updated semgrep parser.py because Info tag was not recognised

Updated semgrep parser.py because the Info severity tag was not recognised

@VeepsFR do you have a report that fail to import? What is the need of this PR?

@damiencarol I tried to import a JSON report and obviously could not since the Info tag was not taken into account in the code, thus the PR.

I believe Damien is asking if you could add a unit test with the redacted JSON report that failed the import and add it here https://github.com/DefectDojo/django-DefectDojo/tree/master/dojo/unittests/scans/semgrep so that issues like these are less frequent.

+1 here.
Dojo uwsgi logs:
uwsgi_1         | [20/Jul/2021 14:29:38] ERROR [dojo.importers.utils:23] Unknown value for severity: INFO
uwsgi_1         | Traceback (most recent call last):
uwsgi_1         |   File "/app/./dojo/importers/utils.py", line 16, in parse_findings
uwsgi_1         |     parsed_findings = parser.get_findings(scan, test)
uwsgi_1         |   File "/app/./dojo/tools/semgrep/parser.py", line 26, in get_findings
uwsgi_1         |     severity=self.convert_severity(item["extra"]["severity"]),
uwsgi_1         |   File "/app/./dojo/tools/semgrep/parser.py", line 71, in convert_severity
uwsgi_1         |     raise ValueError(f"Unknown value for severity: {val}")
uwsgi_1         | ValueError: Unknown value for severity: INFO
uwsgi_1         | [20/Jul/2021 14:29:38] WARNING [dojo.importers.utils:24] Error in parser: Unknown value for severity: INFO
uwsgi_1         | [20/Jul/2021 14:29:38] ERROR [django.request:224] Internal Server Error: /api/v2/import-scan/
uwsgi_1         | Traceback (most recent call last):
uwsgi_1         |   File "/app/./dojo/api_v2/serializers.py", line 1228, in save
uwsgi_1         |     test, finding_count, closed_finding_count = importer.import_scan(scan, scan_type, engagement, lead, environment,
uwsgi_1         |   File "/app/./dojo/importers/importer/importer.py", line 290, in import_scan
uwsgi_1         |     parsed_findings = importer_utils.parse_findings(scan, test, active, verified, scan_type)
uwsgi_1         |   File "/app/./dojo/importers/utils.py", line 16, in parse_findings
uwsgi_1         |     parsed_findings = parser.get_findings(scan, test)
uwsgi_1         |   File "/app/./dojo/tools/semgrep/parser.py", line 26, in get_findings
uwsgi_1         |     severity=self.convert_severity(item["extra"]["severity"]),
uwsgi_1         |   File "/app/./dojo/tools/semgrep/parser.py", line 71, in convert_severity
uwsgi_1         |     raise ValueError(f"Unknown value for severity: {val}")
uwsgi_1         | ValueError: Unknown value for severity: INFO
uwsgi_1         |
uwsgi_1         | During handling of the above exception, another exception occurred:
uwsgi_1         |
uwsgi_1         | Traceback (most recent call last):
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
uwsgi_1         |     response = get_response(request)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
uwsgi_1         |     response = wrapped_callback(request, *callback_args, **callback_kwargs)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
uwsgi_1         |     return view_func(*args, **kwargs)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/viewsets.py", line 125, in view
uwsgi_1         |     return self.dispatch(request, *args, **kwargs)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 509, in dispatch
uwsgi_1         |     response = self.handle_exception(exc)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 469, in handle_exception
uwsgi_1         |     self.raise_uncaught_exception(exc)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
uwsgi_1         |     raise exc
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 506, in dispatch
uwsgi_1         |     response = handler(request, *args, **kwargs)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/mixins.py", line 19, in create
uwsgi_1         |     self.perform_create(serializer)
uwsgi_1         |   File "/app/./dojo/api_v2/views.py", line 1869, in perform_create
uwsgi_1         |     serializer.save(push_to_jira=push_to_jira)
uwsgi_1         |   File "/app/./dojo/api_v2/serializers.py", line 1243, in save
uwsgi_1         |     raise Exception(ve)
uwsgi_1         | Exception: Unknown value for severity: INFO
uwsgi_1         | ERROR:django.request:Internal Server Error: /api/v2/import-scan/
uwsgi_1         | Traceback (most recent call last):
uwsgi_1         |   File "/app/./dojo/api_v2/serializers.py", line 1228, in save
uwsgi_1         |     test, finding_count, closed_finding_count = importer.import_scan(scan, scan_type, engagement, lead, environment,
uwsgi_1         |   File "/app/./dojo/importers/importer/importer.py", line 290, in import_scan
uwsgi_1         |     parsed_findings = importer_utils.parse_findings(scan, test, active, verified, scan_type)
uwsgi_1         |   File "/app/./dojo/importers/utils.py", line 16, in parse_findings
uwsgi_1         |     parsed_findings = parser.get_findings(scan, test)
uwsgi_1         |   File "/app/./dojo/tools/semgrep/parser.py", line 26, in get_findings
uwsgi_1         |     severity=self.convert_severity(item["extra"]["severity"]),
uwsgi_1         |   File "/app/./dojo/tools/semgrep/parser.py", line 71, in convert_severity
uwsgi_1         |     raise ValueError(f"Unknown value for severity: {val}")
uwsgi_1         | ValueError: Unknown value for severity: INFO
uwsgi_1         |
uwsgi_1         | During handling of the above exception, another exception occurred:
uwsgi_1         |
uwsgi_1         | Traceback (most recent call last):
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
uwsgi_1         |     response = get_response(request)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
uwsgi_1         |     response = wrapped_callback(request, *callback_args, **callback_kwargs)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
uwsgi_1         |     return view_func(*args, **kwargs)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/viewsets.py", line 125, in view
uwsgi_1         |     return self.dispatch(request, *args, **kwargs)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 509, in dispatch
uwsgi_1         |     response = self.handle_exception(exc)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 469, in handle_exception
uwsgi_1         |     self.raise_uncaught_exception(exc)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
uwsgi_1         |     raise exc
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 506, in dispatch
uwsgi_1         |     response = handler(request, *args, **kwargs)
uwsgi_1         |   File "/usr/local/lib/python3.8/site-packages/rest_framework/mixins.py", line 19, in create
uwsgi_1         |     self.perform_create(serializer)
uwsgi_1         |   File "/app/./dojo/api_v2/views.py", line 1869, in perform_create
uwsgi_1         |     serializer.save(push_to_jira=push_to_jira)
uwsgi_1         |   File "/app/./dojo/api_v2/serializers.py", line 1243, in save
uwsgi_1         |     raise Exception(ve)
uwsgi_1         | Exception: Unknown value for severity: INFO

json report from semgrep:
{"results": [{"check_id": "rules.contrib.owasp.java.ssrf.owasp.java.ssrf.possible.import.statements", "end": {"col": 20, "line": 7}, "extra": {"is_ignored": false, "lines": "import java.net.URI;", "message": "Non-exhaustive list of Libraries that provide functionality to accept URL as a parameter\n", "metadata": {"category": "security", "cwe": "CWE-918: Server-Side Request Forgery (SSRF)", "source-rule-url": "https://cheatsheetseries.owasp.org/cheatsheets/Server_Side_Request_Forgery_Prevention_Cheat_Sheet.html"}, "metavars": {}, "severity": "INFO"}, "path": "src/main/java/ru/itfbgroup/mvc/form/canonic/ReflectionUtils.java", "start": {"col": 1, "line": 7}}, {"check_id": "rules.contrib.owasp.java.ssrf.owasp.java.ssrf.possible.import.statements", "end": {"col": 20, "line": 8}, "extra": {"is_ignored": false, "lines": "import java.net.URL;", "message": "Non-exhaustive list of Libraries that provide functionality to accept URL as a parameter\n", "metadata": {"category": "security", "cwe": "CWE-918: Server-Side Request Forgery (SSRF)", "source-rule-url": "https://cheatsheetseries.owasp.org/cheatsheets/Server_Side_Request_Forgery_Prevention_Cheat_Sheet.html"}, "metavars": {}, "severity": "INFO"}, "path": "src/main/java/ru/itfbgroup/mvc/form/canonic/ReflectionUtils.java", "start": {"col": 1, "line": 8}}], "errors": []}

When could i expect this merge in release?)

or allow us write permission to the PR so we can update it, my push was denied.

hmm might be gh cli messing up branch names

diff to apply:
diff --git a/dojo/unittests/scans/semgrep/many_findings.json b/dojo/unittests/scans/semgrep/many_findings.json
index e37c7449c..08ccae9b4 100644
--- a/dojo/unittests/scans/semgrep/many_findings.json
+++ b/dojo/unittests/scans/semgrep/many_findings.json
@@ -130,7 +130,7 @@
             "https://capec.mitre.org/data/definitions/463.html"
           ]
         },
-        "severity": "WARNING",
+        "severity": "INFO",
         "fix": "javax crypto Cipher.getInstance(\"AES/GCM/NoPadding\");",
         "lines": "\t\t\tjavax.crypto.Cipher c = javax.crypto.Cipher.getInstance(\"DES/CBC/PKCS5Padding\");"
       }
diff --git a/dojo/unittests/tools/test_semgrep_parser.py b/dojo/unittests/tools/test_semgrep_parser.py
index e6b421b62..916d47839 100644
--- a/dojo/unittests/tools/test_semgrep_parser.py
+++ b/dojo/unittests/tools/test_semgrep_parser.py
@@ -40,7 +40,7 @@ class TestSemgrepParser(TestCase):
         self.assertEqual("javax crypto Cipher.getInstance(\"AES/GCM/NoPadding\");", finding.mitigation)
         self.assertEqual("java.lang.security.audit.cbc-padding-oracle.cbc-padding-oracle", finding.vuln_id_from_tool)
         finding = findings[2]
-        self.assertEqual("Low", finding.severity)
+        self.assertEqual("Info", finding.severity)
         self.assertEqual("src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01150.java", finding.file_path)
         self.assertEqual(66, finding.line)
         self.assertEqual(696, finding.cwe)

Closed by accident @arthur-wolf ?

@valentijnscholten Tell me how I can allow you write permission. I don't know how to setup a unit test since I discovered this during an internship before starting my studies in IT. My coworkers have been telling me that it might be a lot to do compared to how little my change was (I mean, 2 lines of code ???).
I have a lot of stuff to do so if I can let you continue with that, I will with great pleasure !

https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
It's just two small changes as you can see in the diff I posted. We have so many errors on mistakes in parsers, do we need all the unit tests we can get.

@arthur-wolf if you can provide a report that have this severity data and let us commit on your branch we can help finish it.

Here is a scan report with a "INFO" Severity at line 16135
scan-js-2-clean.zip

tell me how I can let you commit on my branch and it will be done !
@damiencarol

No need for an example, I already specified above what needs to be changed in two files.

tell me how I can let you commit on my branch and it will be done

Can you check the link I posted above:

https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Closed in favor of https://github.com/DefectDojo/django-DefectDojo/pull/5004