[#1641][commerce] using parent option in createTag, as well as innerHtml sometimes

Test URLs:

Before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/merch-card?martech=off
After: https://discussion_1641_commerce--milo--npeltier.hlx.page/docs/library/kitchen-sink/merch-card?martech=off

@npeltier , any update on this PR?


Create publishing pipelines in new repository for decentraland-ecs

[x] Enable Github action to publish decentraland-ecs in https://github.com/decentraland/js-sdk-toolchain (use a different package name to prevent conflicts until we reach stability)
[x] Add oddish-action to publish artifacts in pull requests and merges https://github.com/decentraland/explorer/blob/feat/decouple-kernel-website/.github/workflows/ci.yml#L50-L65
In the pull request, it will generate a .tar file that can be istalled directly in node after download

This will be finished when the temporary package rename (decentraland-ecs-wip) is removed. Before, it's necessary to test that works properly


[BUG] - console error inside  when hitting shift key

NextUI Version
2.2.9
Describe the bug
When hitting shift key inside  component I'm receiving a console error.
VM41982:14 Uncaught TypeError: inputTypes.contains is not a function
    at isTextElement (<anonymous>:14:31)
    at <anonymous>:31:26
    at <anonymous>:66:3

Seems that there is a usage of js builtin:  contains method instead of includes
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Add  component
Hit shift keyboard
Check console

Expected behavior
No error should be happen when hitting shift key.
Screenshots or Videos

Operating System Version
macOS 17.3
Browser
Chrome

I think this is a problem with react because I get this error even though I use pure input and react.

Hi @Berdugo1994, I was trying to reproduce this error, however I did not get the result that you explained above. Could you give me more details about how to reproduce this bug?

Based on the following dependencies:
next 14.1.0
react 18.2.0
nextui-org/react 2.2.9
When using  component and hitting Shift button on keyboard it occurs.

@Berdugo1994 Thank you for the reply. I created my NextJS project for this, however, I could not see the same error. Could you please send me a simple sandbox or provide the reproducing code?

Closing - not able to reproduce + inactivity.


DP or PX

Hi friend.
in init method :
  void init(BuildContext context) {
    MediaQueryData mediaQuery = MediaQuery.of(context);
    _mediaQueryData = mediaQuery;
    _pixelRatio = mediaQuery.devicePixelRatio;
    _screenWidth = mediaQuery.size.width;
    _screenHeight = mediaQuery.size.height;
    _statusBarHeight = mediaQuery.padding.top;
    _bottomBarHeight = _mediaQueryData.padding.bottom;
    _textScaleFactor = mediaQuery.textScaleFactor;
  }

You mentioned
  ///Current device width px
  static double get screenWidth => _screenWidth;
 ///Current device width dp
  static double get screenWidthDp => _screenWidth;

but _screenWidth achieved from   _screenWidth = mediaQuery.size.width;
They are not difference, Are thay not px?
Why one of them you wrote dp?

There are some places where the value in px is provided, but generally there are instructions

My last question :
ScreenUtil().setWidth(540)  (sdk>=2.6 : 540.w) //Adapted to screen width
540.w means 540 px?
 Right?
Now if i want to use your library, How could i do that ?Because I am using like this:
              child: Container(
                height: 34.h,

The height of container 34.h is different with 34.0!!
Thanks so much


WandB incorrectly recognising transformers import as PyTorch (should be dynamic to PT or TF)

Weights and Biases version: 0.9.5
Python version: 3.6
Operating System: MacOS

Description
Using colab, I was trying to run a sweep on a tf.keras model, the embeddings for which were created using huggingface's transformers tokenizer.
However, on import of transformers, WandB by default assumes you want to run a PyTorch model (checked by calling wandb.config.as_dict(), and so when running the sweep, despite the outputs showing correct setup, nothing happens after the links to the various project pages/runs are posted in the console output.
What I Did
!pip install transformers
!pip install wandb

import transformers
import wandb

!wandb login

wandb.init()
wandb.config.as_dict()
> {'_wandb': {'desc': None,
  'value': {'cli_version': '0.9.5',
   'framework': 'torch',
   'huggingface_version': '3.0.2',
   'is_jupyter_run': True,
   'is_kaggle_kernel': False,
   'python_version': '3.6.9'}}}

A workaround for now is to load a separate colab workbook, convert the inputs to embeddings as normal using the Huggingface tokenizer, but then save the embeddings as a numpy array to your colab directory.
In your other wandb notebook, don't import transformers, just load the saved embeddings. On doing this, wandb.config.as_dict() gives 'framework: 'tensorflow', and the sweep runs as expected.

FYI: the _wandb structure in the config dictionary is just for internal telemetry and no actions of the script or library should be taken based on its values.   We use a very simple heuristic right now to determine framework and will be enhancing it soon to better reflect the "primary" framework used, rather than just what modules are loaded.
I am not sure about the behavior in the huggingface integration based on modules loaded -- but it shouldnt have to do with our fuzzy platform detection.

@borisdayma any ideas on what might be happening here?

@raubitsj thanks that would explain why when trying to manually amend the config dictionary 'framework' value there was no effect.

transformers detects the presence of wandb and will automatically logs runs if you use Trainer or TfTrainer.
You can disable this functionality with os.environ['WANDB_DISABLED']="true" (which should be suggested to you in the print output). This will desactivate it only for transformers.
@raubitsj @vanpelt The issue may be related to the transformers library automatically calling wandb.init at this line, which in colab will do a reinit which is why nothing is displayed in the sweeps.

In the past year we've majorly reworked the CLI and UI for Weights & Biases. We're closing issues older than 6 months. Please comment to reopen.


fix: prevent publish inf values, odometry tf not being published

Hello man!
I noticed this same issue: https://github.com/pvandervelde/zinger_swerve_controller/issues/1 so atm I avoid publishing the message if there are some inf values.
Also, testing out slam and known-map navigation, I also noticed that publishing a static TF between "odom" and "base_footprint" causes some problems, so I slightly modified the code to publish tf within the odometry message.

Thanks for the PR. I like the changes but is there any chance you could split the changes in to two PRs? One for the base link stuff and one for the infinity issue? That way I can merge them separately.

Ok, for now i will just make a PR for the odometry tf fix
for the inf values im doing some tests based on the discussion in the issue https://github.com/pvandervelde/zinger_swerve_controller/issues/1


Error when user denies execution from Boxstarter is uncaught

Windows will pop up a dialog asking permission for the second command window that Boxstarter opens. The exception that's thrown when the user denies this permission is uncaught.

Is it possible to catch this, and display in some nice bright text:
"You denied permission to run Boxstarter. Packages X Y Z will not be installed."

I get this always when I run boxstarter for the first time. Eg if I click on this link http://boxstarter.org/package/nr/url?https://raw.githubusercontent.com/laurentkempe/Cacao/master/PrepareMyCacao.ps1
I click on a link in Edge
I say run the click once installer that it downloads
It downloads and installs boxstarter
The opens new command line window like above and crashes
Then I click the link second time
Run the click once
Without downloading or installing anything it starts executing the script without any problems

@martinskuta @laurentkempe would either of you be able to check that it wasn't this issue that you are running into?
https://stackoverflow.com/questions/50379742/clickonce-app-doesnt-start-with-windows-1803

As a workaround you can install boxstarter locally and then refer it to the same scripts you're attempting to run.
In an elevated PowerShell Window run:
CINST Boxstarter
Install-BoxstarterPackage [PATH_TO_SCRIPT]

would either of you be able to check that it wasn't this issue that you are running into?

Yeah @gep13 it might have been my issue for sure! on @martinskuta VM we have seen the exception described in that issue, but let's try it again next week and we let you know

As a workaround you can install boxstarter locally and then refer it to the same scripts you're attempting to run.

Thanks @yodurr exactly what I did at the end. But clicking on an hyperlink on a webpage is so much fun 😄

@martinskuta @laurentkempe would either of you be able to check that it wasn't this issue that you are running into?
https://stackoverflow.com/questions/50379742/clickonce-app-doesnt-start-with-windows-1803

Yep it is that, when I changed Check app and files OFF as described in the stackoverflow thread, everything run properly.

I'm not reproducing this bug anymore.  Anyone else still see it?

I think we should close this issue - I'm not having this problem anymore.

Closing as requested


Add podspec

Thanks! I don't use CocoaPods at all, but I trust it just works for now :)

Thanks @Anviking !


Add Option to see always Streamtitle

If i search for ADC only streamers in Games -> League of Legends .. I always have to go to the twitch online page, because i cant see streamtitles in Games -> Legaue of Legends Tab.
(I know it is posible to toggle details .. but this would last too long if i click on every details button of all Streams that are currently online (2592 xD).
Therefore it would be awesome to exchange the Uptime + Viewerscount with the Streaming title.
Greetings
Nexxy

I decided against adding titles, because they are too variable when you only have a limited amount of available space. The stream list items in the GUI are smaller than on the twitch website, because the GUI is a windowed application, whereas the twitch website will almost always be opened in a maximized browser window. That's why they can make use of all the available space.
Although they are using bigger list items, titles are still being cut off and most of them don't provide much info unless you are hovering it, so you can see the full title.
That's what you can do in the GUI as well without having to expand the info overlay. Just hover the preview image. From the overlay you can also directly open links from the stream title. You can't do this on the Twitch website...
Also, if you are searching for a specific title, then why don't you use the search function?

Why would you want to see a title that doesn't say much about the stream at all and waste space by doing this?

I disagree with your opinion.
Variety streamer post the for that day planned games in the title and match streams have the current opponents written in the title. So much is packed into the first characters that even the abbriviated version carries enough information.
Most importantly streamer use the title to communicate with everyone who's not watching the stream, it's an important medium for the viewer and the streamer that it warrants its own place on the GUI.
Having to hover over the stream for the title is also really unintuitive.
When hovering over the stream it also takes too long for the title to show up. Maybe allow us to set the delay time?
Right below the stream name would be the perfect place for the title.

+1 I couldn't have said it any better :D Fully agree with him.

I've added a dropdown to the settings, so you can choose between showing the game or showing the title in the stream preview (default is the game being played). The expanded view will always show all informations, except while being in a game-menu, where the game info is redundant.
I really, really don't want to add another line of text below the preview image or somewhere else, because that would break the layout and I'd have to readjust the size of everything.
I think everyone can live with this solution. See the stream-title branch (not yet merged into master)...

Understandable.
How about an option that allows us to set the delay between hovering over the stream preview and showing the title?
Checking on multiple streams atm is a pain since it takes so long for the title to pop up.

I don't know what you are talking about. With the latest changes you're able to see the title without hovering anything. It's definitely not a pain...
Also, the animation when clicking the expand button at the bottom right of the preview image has a transition time of just 0.25s. I don't see anything wrong with it. I'm not going make it even more ridiculously complex the way it is right now with all the customizations.
I don't have any influence on the tooltip delay, if you're talking about that. That's determined by Chromium or your OS, can't tell...


Remove chrono dep

Codecov Report

Merging #167 (80cf27d) into main (72b978f) will decrease coverage by 1.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   63.83%   62.13%   -1.70%
==========================================
  Files          57       57
  Lines        6999     7192     +193
==========================================
+ Hits         4468     4469       +1
- Misses       2531     2723     +192

Impacted Files
Coverage Δ

src/many-identity/src/address.rs
63.56% <0.00%> (-17.95%)
:arrow_down:

src/many-protocol/src/lib.rs
85.26% <0.00%> (-11.35%)
:arrow_down:

src/many-types/src/lib.rs
42.35% <0.00%> (-10.51%)
:arrow_down:

src/many-types/src/cbor.rs
96.72% <0.00%> (-1.62%)
:arrow_down:

src/many-macros/src/lib.rs
0.24% <0.00%> (+0.03%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.


[V6] [Discussion] would be any cause if we move initializing of form to componentDidMount ?

Hi @erikras
I know regarding initializing by exposed action API in redux-form, would does that make any difference if we move whole  initialize logic to componentDidMount instead of componentWillMount ?
More over uses cases are , let's say you directly initialize form from either localStorage if you do it in componentWillMount you will see the Dom Difference from React as localStorage is not accessible on server side.

I would say, yes, go ahead and do it. No problems IMO.
Let us know about any problems you found so to enhance the docs.


Deterministic Version Finding

Comes from convo on #23 - where code was adjusted to find the biggest version.
Consider this situation:
The CLI outputs 2 versions for some terrible reason.
On Alice's machine 1.0.1 and 0.47.2. Using your formula this would grab 0.47.2 and a person would ship that rule, happy it found the correct one.
Then on Bob's machine, he has 2 versions 2.0.0-beta and 0.47.2. On this machine, it would match 2.0.0-beta because it's longer.
Solution
By default, the tool should match the first identified semver. The user who is implementing a rule, knows this, and can always identify who will get matched.
We then provide a new property to a rule, perhaps matchIndex? Which is a bit harder to use than line, but properly so, it will help if for some reason there are multiple matches in output, that they can write a stable rule.

I think I'm gonna knock this one out today.

Momma said knock this out!


IconSource binding

Is there any way to do an IconSource binding, or to change the IconSource in a Trigger? (It doesn't appear to work)

Using a storyboard works fine, but not with a DataTrigger
IE, this works:
  <tb:TaskbarIcon.Style>
      <Style TargetType="tb:TaskbarIcon">
          <Style.Resources>
              <ImageSource x:Key="RecordingIco">pack://application:,,,/Images/Recording.ico</ImageSource>
              <ImageSource x:Key="RegularIco">pack://application:,,,/Images/Regular.ico</ImageSource>
          </Style.Resources>
          <Style.Triggers>
              <DataTrigger Binding="{Binding IsRecording}" Value="True">
                  <DataTrigger.EnterActions>
                      <BeginStoryboard>
                          <BeginStoryboard.Storyboard>
                              <Storyboard>
                                  <ObjectAnimationUsingKeyFrames BeginTime="00:00:00" Storyboard.TargetProperty="IconSource">
                                      <DiscreteObjectKeyFrame KeyTime="00:00:00" Value="{StaticResource RecordingIco}"/>
                                  </ObjectAnimationUsingKeyFrames>
                              </Storyboard>
                          </BeginStoryboard.Storyboard>
                      </BeginStoryboard>
                  </DataTrigger.EnterActions>
                  <DataTrigger.ExitActions>
                      <BeginStoryboard>
                          <BeginStoryboard.Storyboard>
                              <Storyboard>
                                  <ObjectAnimationUsingKeyFrames BeginTime="00:00:00" Storyboard.TargetProperty="IconSource">
                                      <DiscreteObjectKeyFrame KeyTime="00:00:00" Value="{StaticResource RegularIco}"/>
                                  </ObjectAnimationUsingKeyFrames>
                              </Storyboard>
                          </BeginStoryboard.Storyboard>
                      </BeginStoryboard>
                  </DataTrigger.ExitActions>
              </DataTrigger>
          </Style.Triggers>
      </Style>
  </tb:TaskbarIcon.Style>

Have you tried the main version? - https://github.com/hardcodet/wpf-notifyicon/
I checked IconSource is a DependencyProperty and it's strange that it behaves like that. You need to create specific tests and track behavior.

Thanks. You might want to update the Nuget Project URL https://www.nuget.org/packages/Hardcodet.NotifyIcon.Wpf.NetCore/ because it points to this repository not the new one.

You didn't quite understand the situation. I created this repository because, at the time of the release of .Net 5, the original repository was last updated in 2016. Then it became active for a while. I've added a link to them at the top of the README. As far as I know, at the moment there is no activity in it again for almost a year (since April 2020). I have also updated the code according to their latest changes

Regarding your problem - I can try to solve it. For this I need a simple sample application with a problem


Got minus one from a read call

I run docker with command
docker run --name plugpdb -p 32767:1521 -p 32766:5500 -e ORACLE_SID=DEVOPSUATCDB -v /home/oracle/oradata:/opt/oracle/oradata store/oracle/database-enterprise:<IP_ADDRESS>
in tnsnames.ora I have
ORCLCDB=(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=<IP_ADDRESS>)(PORT=32767))     (CONNECT_DATA=(SERVER=DEDICATED)(SERVICE_NAME=ORCLCDB.localdomain)))
ORCLPDB1=(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=<IP_ADDRESS>)(PORT=32766))     (CONNECT_DATA=(SERVER=DEDICATED)(SERVICE_NAME=ORCLPDB1.localdomain)))
I can connect to ORCLCDB via sqlplus and Oracle SQL Developer, but when I try to connect to ORCLPDB1 I get error:

An error was encountered performing the requested operation:
Got minus one from a read call, connect lapse 2 ms., Authentication lapse 0 ms.
Vendor code 17002

What is wrong?

Actually, I don't believe that you can connect to ORCLCDB. You might be able to start SQL*Plus but connect to an idle instance. The reason why I say this is because you specified your ORACLE_SID=DEVOPSUATCDB so there is no ORCLCDB database instance running.
Furthermore, I don't think that your database creation was successful altogether because the ORACLE_SID can't be longer than 8 characters and your SID has 12.
Please verify that your database creation has been successful, see the README.md for further information.


ubuntu-latest: Failing to run NET6 app due to missing Microsoft.NETCore.App

Description
After the latest update in ubuntu-latest we started having issues in our Azure pipeline while running a NET6 app with the error:
/usr/share/dotnet/sdk/7.0.101/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(376,5):
 error NETSDK1127: The targeting pack Microsoft.NETCore.App is not installed. Please restore and try again.

Executing dotnet --list-sdks inside the VM shows:
6.0.404 [/usr/share/dotnet/sdk]
7.0.101 [/usr/share/dotnet/sdk]

Executing dotnet --info inside the VM shows:
========================== Starting Command Output ===========================
/usr/bin/bash --noprofile --norc /home/vsts/work/_temp/039e26df-14cb-44e1-bd8d-5aa83db5ddf9.sh
.NET SDK (reflecting any global.json):
 Version:   6.0.404
 Commit:    be4f3ec411

Runtime Environment:
 OS Name:     ubuntu
 OS Version:  22.04
 OS Platform: Linux
 RID:         ubuntu.22.04-x64
 Base Path:   /usr/share/dotnet/sdk/6.0.404/

Host:
  Version:      7.0.2
  Architecture: x64
  Commit:       d037e070eb

.NET SDKs installed:
  6.0.404 [/usr/share/dotnet/sdk]
  7.0.101 [/usr/share/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.12 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 7.0.1 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.12 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 7.0.1 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  Not set

global.json file:
  /home/vsts/work/1/s/global.json

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

This seems oddly similar to this ticket that a teammate of mine made some time ago.
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Image: ubuntu-22.04
Version: 20230109.1

Is it regression?
Yes, it worked before commit c82cd6704bacd9429d4e037d6554e74375842f51
Expected behavior
Run the App without a runtime error.
Actual behavior
Having an error:
/usr/share/dotnet/sdk/7.0.101/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(376,5):
 error NETSDK1127: The targeting pack Microsoft.NETCore.App is not installed. Please restore and try again.

Repro steps
Could not reproduce this locally.
Changing the image to ubuntu-18.04 seems to solve the issue on the pipeline, at least.

Hey @gregory-paidis-sonarsource!
I'm not sure it is the same situation but according to my little investigation the same method will work for you here. You can use setup-dotnet task or wait untill new image rollout.
More info about reasons you may find here.

yeah, @erik-bershel , I installed the latest .NET 7 Sdk to latest and got the same issue on Windows as well.
I cannot reproduce it, but if I find a way to, I will open an issue to the .NET repo.
Just leaving this here, to let you know I do not think it is platform(ubuntu)-specific.

@gregory-paidis-sonarsource yes, it is not a really platform specific. It is more about compability of .Net platforms. As it was mentioned in issue sometimes it happens when you installing both of .Net 7 and 6 on the same machine. We'll see how next build would help you. And in case we got new compability bug, not the same I described, we'll think about another possibility to help you with broaken build. It works right now with old Ubuntu image because of process of retirement - no updates, no preinstalled comability issues.

Hey @gregory-paidis-sonarsource!
New Ubuntu images shiped. May I ask you to try it again?

Hi @gregory-paidis-sonarsource, any updates? How it works right now for you?

hey @erik-bershel , it works. Could you share, at a high level, what changed?
Thanks again for the fix!

@gregory-paidis-sonarsource glad to see it. Main change that supposed been fix issue and did it is .NET Core SDK: 7.0.101 -> 7.0.102


Update 2.11

Bump iModel.js version to v2.11.0

@wgoehrig Care to take a look?

@wgoehrig Care to take a look?

@williamkbentley  LGTM


How to display all child elements in inspect tool?

Hi Team,
We have a custom control like datagrid that supports ui accessibility by deriving the IRawElementProviderFragmentRoot, ISelectionProvider and IScrollProvider interfaces. When we tried to automate our custom control using inspect tool, Only 12 cell elements are updated in the Inspect tool pane whereas the grid has 60 cells (15 rows and 4 columns). In our UIPRovider class we have a method that returns the IRawElementProviderFragmentRoot of each cell based on the accessibilityName and id. It returned properly when we debug but it is not reflected in the inspect tool. Below is the code that we are used to update the element value for each cells. While debugging, we noticed that the element is returned as null in inspect window for a specified cell since the GetObject message was not invoked for that cell in WndProc method of our custom control. Can you please suggest a solution to update all the grid cell elements in inspect window?
public object GetPropertyValue(int propertyId)
{
    GridRangeInfo spannedRange = GridRangeInfo.Empty;
    if (this.Grid != null)
    {
        Grid.Model.GetSpannedRangeInfo(Info.CellIdentity.RowIndex,(Info.CellIdentity.ColIndex, out spannedRange)
    }
if (propertyId == AutomationElementIdentifiers.NameProperty.Id /*|| propertyId == 30020*/)
   {
     if (spannedRange.RangeType != GridRangeInfoType.Empty)
        {
          return "GridCell_R" + spannedRange.Top + "_C" + spannedRange.Left;
       }
     return "GridCell_R" + this.Info.CellIdentity.RowIndex + "_C" + this.Info.CellIdentity.ColIndex;
           }
}

Thanks in advance,
Arulpriya R

Hi @Arulpriya,
This repository is for the Application Inspector code scanning tool, I'm not familiar with the tool you're using here.


Added required RBAC permissions for Kudo

Added the permissions required for the Kudo service with Azure App Service as it was missing from the documentation and is important to customers

@mabesignal : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@mabesignal thanks for adding the details. The name of the tool is actually Kudu not Kudo. Can you fix that?

Fixed in a separate PR. #please-close

@cephalin Thanks for the spelling catch, appreciate it :)


Hide amendments  behind growth book flag

Describe the task
Hide new amendment feature behind feature flag.
Acceptance Criteria

[x] Turn on feature flag in growth book
[x] Put amendments and other revisions table behind the feature flag (on the Tasklist and its dedicated page)
[x] Put amendments and other revisions create page behind the feature flag
[x] Put amendments and other revisions view  page behind the feature flag
[x] make sure the current create revision process is still working

Additional context

Add any other context about the task here.
Or here

keyword: growthbook, feature flag

FYI @pbastia - I've created this ticket for hiding amendments behind a feature flag

Thank you @Sepehr-Sobhani!
I always forget in growth book - when it is purple, that means it is visible in that environment correct? If so, are there any objections to have amendments visible in the test environment?

Thank you @Sepehr-Sobhani!
I always forget in growth book - when it is purple, that means it is visible in that environment correct? If so, are there any objections to have amendments visible in the test environment?

@LindsayMacfarlane Yes you're right and there's no objection :) I'm gonna turn it on.

Brilliant! Thank you @Sepehr-Sobhani!


Support Different Note Types

Is your feature request related to a problem? Please describe.
First of all, thank you very much for the great plugin! Unless I am mistaken, I noticed that the plugin seems to only support the default note types in Anki (i.e. Basic and Cloze). A few days ago, I exported some cards to Anki using the plugin and updated some cards to have a custom note type (I have some simple modifications like Basic (+reverse)). When I synced with Anki again, it seems to have erased those cards and created new ones, and the spaced repetition has reset. I understand this is happening because the Obsidian Vault contains the "true" information.
Describe the solution you'd like
I do like that Obsidian contains the "true" information, but it would be nice to create custom note cards (and basically not worry about having to modify cards in Anki once exported). Please let me know if I can help, since it seems so far that that the Basic note type is "baked in" using the codeblock, and a custom note type would require defining a flexible codeblock, which could be a lot of work.
Describe alternatives you've considered
I think Obsidian_to_Anki plugin support custom note type, but I prefer this plugin for its cleanliness and rendering.

Unfortunately I am exceedingly busy with other parts of life at the moment, but I do hope to support some basic custom note cards in the future.
The flexibility of Anki's custom notes does mean that making something that will magically fit everything won't be possible. For example, basic blueprints will inevitably be limited to note types that have two fields. Support for reversed basic notes should not be too hard.
The underlying implementation is already somewhat ready for custom note types, but there is a lot of programmatic plumbing to be done.
TL;DR: Will add feature in the future, but likely this is not going to be in the short/medium term.


Select with expandableInfo (React): Too much space below label if labelInformation is not set

I also tested it in the storybook, but removing the .form-info div:

Interesting usecase.. Why not opt for label information to explain the label and skip expandable? Do you have a screenshot when it's expanded?

@daneriseb Did you get an answer from CX?

Answer from Julia D:

Question 1: the component looks weird when there is no label information so the question is should this use case be covered or not?
Answer: Yes, this use case should be covered
Question 2:  when should the expandable information be used instead of label information?
Answer: the expandable component should be used when the help text is too long to show directly, or not super important to be shown directly but is rather extra info on demand

Addition to this:
Putting two input fields horizontally next to each other and expanding the info field causes the items to stack on top of eachother:


Upgrade GO packages for GHSA-jq35-85cj-fj4p and GHSA-m425-mq94-257g in 3.13.2

Output of helm version: 3.13.0
Output of kubectl version: 1.27.1
Cloud Provider/Platform (AKS, GKE, Minikube etc.): AKS
There are new security issues for helm binary in our corp security scan.
https://github.com/advisories/GHSA-m425-mq94-257g
https://github.com/advisories/GHSA-jq35-85cj-fj4p
Since the next of next release is 2024 Jan, Is it possible to include below two pull requests in 3.13.2?
Also please help review and complete below two package updates.
https://github.com/helm/helm/pull/12535
https://github.com/helm/helm/pull/12525

@joejulian since you help https://github.com/helm/helm/pull/12481, wonder if you can help this.

We use dependabot for security notices and dependency upgrades. Check the security tab. If your issue isn't there, your tool is giving a false positive. If it is, the pull requests labeled dependency will address them.

Above two PRs are generated from dependabot with dependency label, but no one review them.
I don't think its false positive - the go package is still in old version.

If dependabot created a PR, they'll get reviewed and merged by the next release cycle.

don't think its false positive - the go package is still in old version in below GHSA reports.
https://github.com/advisories/GHSA-m425-mq94-257g
https://github.com/advisories/GHSA-jq35-85cj-fj4p

I think your scanner has detected these CVEs via transitive dependencies of Helm. But the scanner is almost certainly wrong (false positive) in that these CVEs don't affect Helm (the first affects docker engine running containers, which Helm doesn't do. And the second affects http/2 servers, which the Helm CLI doesn't do)
Please follow up with your scanner vendor/provider to fix these false positives.

@joejulian, since a fix for #12497 had been merged but was not shipped with the last patch release, you may understand if we retain some concern.
Anyway, there are currently nine PRs labeled dependencies. When is the "next release cycle"? What triggers a patch release if not security fixes in dependencies? Is there something we users can do, is there a schedule, ... ? Does the project need more/better automated tests to more confidently approach dependency updates?

Release calendar is on https://helm.sh homepage @reitzig

Ah, https://helm.sh/calendar/release indicates monthly patch releases on a schedule. Thanks for the pointer! :pray:

Thanks @mattfarina for completing above two PRs and mark them in 3.13.2 milestone.
As long as helm can review and check-in dependabot security updates in monthly we should be fine from security scans.


Tasks: Bubble up errors from scripts

See this issue for the query: https://github.com/influxdata/flux/issues/2075
Looks like the error message from the logs is not getting bubbled up into the logs of the task response:

It looks like the task system doesn't bubble that error up: https://github.com/influxdata/influxdb/blob/fc7bb9fcaf48f5e481a18752a36b0b1b1b0669b4/task/backend/executor/executor.go#L179
2019-10-28T20:39:05.058531Z debug   Created run; beginning execution    {"log_id": "0Im11qZ0000", "svc": "taskd/scheduler", "task_id": "04a1b4334ae66000", "run_slot": 0, "run_id": "04b105569360b000", "now":<PHONE_NUMBER>}
2019-10-28T20:39:05.058599Z debug   Ticked  {"log_id": "0Im11qZ0000", "svc": "taskd/scheduler", "now":<PHONE_NUMBER>, "tasks_affected": 1}
2019-10-28T20:39:05.089431Z info    Executing task (start)  {"log_id": "0Im11qZ0000", "service": "task-executor", "task_id": "04a1b4334ae66000", "run_id": "04b105569360b000", "op_name": "execute", "op_event": "start"}
2019/10/28 13:39:05 http: TLS handshake error from [::1]:59852: remote error: tls: bad certificate
2019-10-28T20:39:05.100580Z info    Error exhausting result iterator    {"log_id": "0Im11qZ0000", "service": "task-executor", "task_id": "04a1b4334ae66000", "run_id": "04b105569360b000", "op_name": "execute", "error": "Get https://localhost:9999/metrics: x509: certificate signed by unknown authority", "name": "to2"}
2019-10-28T20:39:05.100625Z debug   Completed successfully  {"log_id": "0Im11qZ0000", "service": "task-executor", "task_id": "04a1b4334ae66000", "run_id": "04b105569360b000", "op_name": "execute"}
2019-10-28T20:39:05.100648Z info    Executing task (end)    {"log_id": "0Im11qZ0000", "service": "task-executor", "task_id": "04a1b4334ae66000", "run_id": "04b105569360b000", "op_name": "execute", "op_event": "end", "op_elapsed": "11.218ms"}
2019-10-28T20:39:05.136198Z debug   Execution succeeded {"log_id": "0Im11qZ0000", "svc": "taskd/scheduler", "task_id": "04a1b4334ae66000", "run_slot": 0, "run_id": "04b105569360b000", "now":<PHONE_NUMBER>}

This because we aren't properly bubbling up errors that occur during result iterator exhaustion.
https://github.com/influxdata/influxdb/blob/fc7bb9fcaf48f5e481a18752a36b0b1b1b0669b4/task/backend/executor/executor.go#L179
https://github.com/influxdata/influxdb/blob/552168d3aefd142d64299e45642210bebac9c146/task/backend/executor/task_executor.go#L391

@docmerlin is this still an issue?


Does this change the actual alegro file as well?

Does this change the alegro file it is exporting too?

Sorry for my late response ... no, the script does not change the allegro file.

thank you! Is there a way for me to change the script so the json that gets outputted includes all of the inner layers as well, not just the front and back?

Theoretically you could changed it this way, but I'm not sure, if the interactive html bom supports this ...
To do so you have to  the case statement and append the copper to the correct position afterwards ...

You should first verify, that the interactive html bom does support displaying the inner layers ... I don't want to say something wrong, but the time I wrote the script, it did not! If the ibom supports it, I think I would implement this feature anyway.

The ibom doesn't currently feature inner layers however I am thinking of adding the support myself. I also found another hard fork that does implement the extra layers. The allegro skill script is just Mandarin to me so the json conversion is tough.

Ok, but I can only recommend you to try to understand what is happening here, although I know it is not easy the first time ...
The "only" thing you have to do is, to fit the addCopper() procecdure to your needs. And at this moment I see, that my code could run a lot faster, because the inner layers are already parsed, but not stored ...
So any time there is a case( child->layer ... loop you need to add code to the t case, which is whenever the copper is not on top or bottom or you could eliminate the whole case loop and do the storing of the elements more dynamically, what is the best solution I think, because the number of layers can be different.
I would suggest to to declare two tables, one for the tracks and one for the zones. This is done by:
tracks = makeTable( "tracks" nil )
zones = makeTable( "zones" nil )

In the following you have to assign parsed elements depending on their layers (this needs to be done for the zones as well):
if( tracks[ child->layer ] then
   tconc( tracks[child->layer] track )
else
   tracks[child->layer] = tconc( nil track )
)

At the end you have to loop over all layers layers = tracks->? and build the json string as I did in line 2090 to 2144

I have almost finished what you need, because I think this makes my code more "elegant". The only questions is, what is the naming convention for the inner layers?

Check out my latest commit. It supports the export of the inner layers.

thank you so much I appreciate it! Will this still work for the existing ibom?
This is the hard fork I am going to use ----- > https://github.com/oceanofthelost/InteractivePCB

If you don't pass exportInnerLayers t it is the normal export, without the inner layers.

This is the hard fork I am going to use ----- > https://github.com/oceanofthelost/InteractivePCB

I already looked it up, unfortunately there is no "rendered" demo ... so I can't imagine how it looks ....

okay thanks again, I can probably edit ibom to allow for inner layer integration if https://github.com/oceanofthelost/InteractivePCB doesn't work out. Will let you know how it goes thanks again!

I am getting this error when exporting and resulted in an empty json Error eval: unbound variable - indentedStrings. What do yo uthink is the issue because I saw the code and it looked like you handled it?

I would put the file up but github doesnt support the file type.

Can you put everything in a zip-folder?

Sample.zip

Please check out my latest commit. It should be working now.

It worked thank you!


Dose vvencapp support arbitrary GOP size?

I use vvencapp to encode video, -g option only accepts [16, 32] but I want to set 24 gop size, Is there a way to do this?

Why would you want to set GOP size to 24?
If the GOP size is not a power of two the hierarchical structure will be somehow unbalanced - i.e. probably like a mix of interleaving gop-16 and gop-8 structures, meaning it would also produce suboptimal results.
Since we don't want to decide how it should be unbalanced nor have an algorithm that can decide the optimum between gop16-gop8, gop8-gop16 and gop8-gop8-gop8 or even more fine-granular imbalance (i.e. on higher temporal depths), there is no setting to do that.
To run a GOP24 encoding you'd need to define your own GOP structure in the expert app (defining reference pictures lists, QP offsets and all that stuff for each frame in the GOP), which is indeed an expert setting.

Thanks for quick response.
I want to encode videos for streaming, most input videos are 24 or 25 fps, so setting GOP to 1 seconds or 3 seconds is helpful to generate same duration dash m4s segments.
If I can't use the standard encoder to do this, I may need to change input videos to 32fps.

So in your case you want an intra-period (IP) of 24. I guess the best way to do this would be to have a GOP of 24, but the problem applies. The easiest hack around this would be to have a GOP8 structure, because for now intra period has to be a multiple of GOP size. I think older version of HM have a GOP8 configured so you could adapt their configuration (it should use similar semantics to the expert encoder parametrization). Doing that will cost a lot of efficiency, though. So for proper application right now you'd need to adapt the segment size to 1.3 seconds (32 frames), or a multiple of that.
I guess we can evaluate it internally if the the intra-period necessarily has to be a multiple of the GOP size, in which case e.g. a GOP32 could be just cut short (frame 24 would be an I-frame instead of temporal layer 2 B-frame and the frames 25-31 in the GOP would be skipped, as they would be transmitted in the next IP, so also next GOP). But since it requires some experiments and might produce too much overhead for us to officially support it, I would not count on seeing this feature soon, if at all.

Got it, thanks for help.


about concept quantization

Hi, in your paper, Pr[object i is Red] is given by shifted and scaled sigmoid function, but there seems no sigmoid function in your code as shown below
https://github.com/vacancy/NSCL-PyTorch-Release/blob/ef493d58a986dcb1ea16a23183a57119abeaff34/nscl/nn/reasoning_v1/concept_embedding.py#L181
If so, the range of the 'logits' variable can be a problem when it adds with the 'belong' vector. Could you explain more about this? Thx!

Thanks for bringing up this. Yes, the implementation here does not exactly follow the equation in the paper.
To correct that, one should add an additional logsigmoid operation before it got added up with the belong vector.
And we should also replace the BCEWithLogit loss with a BCE(exp(log_logits), label) loss.
However, in practice, I feel that the current implementation won't significantly hurt the training.
To understand that, interpret the logsumexp as a "soft max" operation. So the additional belong vector with adjust the logits so that if concept c does not belong to attribute a, it will has a logit value less than 0. The logsumexp will operation will pick the largest possible logit.

Thanks a lot! I agree with you that the effect can be the same without a sigmoid function.


more py2 compat

This seems to work for me, but could change the behavior of some exceptions (select.error would now be caught in Python 3.

Whoops, I didn't test this thoroughly.


Interrupt command not observable

Problem:
The scheduler observes the plan to determine whether to suppress or revive offers.    Therefore any plan change that could bear on that must be observable.   Due to a bug, interrupting a plan element via the API isn't notifying the scheduler as it should.
Suggested fix:
The interruptCommand method of PlanResource should invoke interrupt on the phase object, not on the phase's associated strategy object.   Look at the continueCommand for comparison.

Hi @EronWright, we are moving dcos-commons issues to JIRA.  If your issue is still relevant, please open a ticket in DCOS_SDK (for the common code) or DCOS_DS (for the services themselves).


Clean up past reports buggy; ignores report_path ; coverage shouldn't be checked in?

running ./coco shouldn't affect git status ;
git clone https://github.com/samuelroy/coco
cd coco
nimble build
./coco --report_path=/tmp/d19
git status

        deleted:    coverage/amber.png
        deleted:    coverage/emerald.png
        deleted:    coverage/gcov.css
        deleted:    coverage/glass.png
        deleted:    coverage/index-sort-f.html
        deleted:    coverage/index-sort-l.html
        deleted:    coverage/index.html
        deleted:    coverage/nim-coverage/coco.nim.func-sort-c.html
        deleted:    coverage/nim-coverage/coco.nim.func.html
        deleted:    coverage/nim-coverage/coco.nim.gcov.html
        deleted:    coverage/nim-coverage/index-sort-f.html
        deleted:    coverage/nim-coverage/index-sort-l.html
        deleted:    coverage/nim-coverage/index.html
        deleted:    coverage/ruby.png
        deleted:    coverage/snow.png
        deleted:    coverage/updown.png
        modified:   lcov.info

        tests/compilation
        tests/foo
        tests/report/cleanup_past_report
        tests/report/generate_coverage

coverage is removed even though I specified ./coco --report_path=/tmp/d19 so I'd assume it'd instead remove /tmp/d19

I'm actually confused about coverage ; was this intended to be checked in this repo or was it an artifact of running ./coco and checking in automatically generated files in the repo? if the latter, these should be deleted from this repo
even after removing coverage, ./coco still works which makes me think snow.png (etc) are generated by something else (maybe lcov?)

I really like when git status stays clean after running commands (or at least everything generated goes under 1 directory); maybe 1 option is to generate:

./coco
lcov.info
coverage (default value for report_path)
nimcache

under a build/ dir that's gitignored?

@timotheecour coverage/ in this repo is only used as an example of the report generated by Coco.
About --report_path it does the job correctly, cleanup then creating the report at that path. When you ran the command ./coco, it ran my tests and one was removing coverage/. Totally unnecessary and confusing. It's fixed now.
Agree about git status. It should stay clean as much as possible. Now, by default, you should only get 1 directory with the HTML report (I should add an option to disable the generation) and your LCOV file. This one is really useful in your project as it's read by Coverage Gutters in VSCode.


Fixed 'RemovedInDjango110Warning: render() must be called with a dict…

Django==1.9.6, 1.9.7 complains about calling django.template.loader.get_template with a Context object, rather than a dict:
$ ./manage.py generate_favicon logo.png
Are you sure you want to continue? [Y/n]
Launch favicon generation and uploading
/home/foo/favicon/utils.py:67: RemovedInDjango110Warning: render() must be called with a dict,
not a Context.
  output_content = template.render(Context({'tile_color': 'FFFFFF'}))

I simply updated the offending line in utils.py. It seems to work fine now with 1.9.6, 1.9.7, and runtests.py still succeeds:
$ ./manage.py generate_favicon logo.png
Are you sure you want to continue? [Y/n]
Launch favicon generation and uploading

Coverage remained the same at 94.262% when pulling 303ab8b31e5fd3c0c82b182fcd65cfd69a02888e on ryankaiser:master into 6f957618b879a22f6239d6d7b942e402897bc4cc on ZuluPro:master.

Hello @ryankaiser
Thank you very much for this contrib.
Could you also remove the Context's import, it is now useless.
Thanks again


PubSub: Delayed messages

I'm migrating some of my node & PHP clients to Go, and I'm hitting a barrier using the ack mechanism of the Go client. I've implemented delayed messages by using a delayed_until attribute containing the date when the message should be processed. When my workers receive such messages, they extend the deadline until this moment (or 600s if it's too far away) and don't ack or nack the message.
Because the Go client is extending the deadline automatically before we .Ack() or .Nack() on the message, I can't easily reproduce this mechanism. Do you have any idea how I should approach this?

You should have a look at #691. tl;dr: the cloud.google.com/go/pubsub client doesn't support what you're trying to do. You can try the Cloud Tasks alpha (link at the bottom of that issue) or use the lower-level client at cloud.google.com/go/pubsub/apiv1.

I'm not sure to follow why a refusal of a .Forget API in the client, as that would be the simplest way to solve this problem. I'll have to go for the lower-level version then I guess. Thanks at least for your answer @jba !

@sroze Did you manage to solve your problem?

yes, did by using the lower-level library.

@sroze would you mind to share a short "how" :)

https://code-review.googlesource.com/c/gocloud/+/33250 is adding a Forget method that may help you.


Be sure to add /admin to your email confirmation url or update your emails in netlify

Currently, if you just deploy directly to netlify you get the email but it directs you to the index page , where it needs to be /admin?and your query
Should this repo add the netlify widget source to index?
See my comment here
https://answers.netlify.com/t/cms-nuxt-template-starter/37634
I ended up creating new email templates in the back end of netlify , identity ->emails. per the user @tomrutgers
suggestions.
I added these to the /static/emails
and then referenced them in netlify.
confirmation.html

Confirm your signup

Follow this link to confirm your user:

Confirm your mail

recovery.html

Reset Password

Follow this link to reset the password for your user:

Reset Password

invitation.html

You have been invited

You have been invited to create a user on {{ .SiteURL }}. Follow this link to accept the invite:

Accept the invite

email-change.html

Confirm Change of Email

Follow this link to confirm the update of your email from {{ .Email }} to {{ .NewEmail }}:

Change Email

Really nice of you to write up such a detailed and helpful issue!
So apparently if I understood this correctly, this is caused because Netlify redirects to the root domain from the emails, where it expects to find  imported in .
This is something I removed from the main templates and only added to the /admin/index.html page, as it is not useful for most visitors. It saves them some kilobytes.
But if your implementation requires some more authentication support, I'd suggest following @audetcameron's advice above or @tomrutgers advice here:
https://answers.netlify.com/t/common-issue-netlify-cms-git-gateway-email-not-confirmed/10690
I wont be adding the package to the other pages'  for reasons above, but I'll add this to the readme for further availability.
Thank you so much for your contribution @audetcameron ! ⭐

You might want to consider adding the email templates to the repo along with some instructions on how to install them though, but that's just my two cents 🙃

You might want to consider adding the email templates to the repo along with some instructions on how to install them though, but that's just my two cents 🙃

@Knogobert if you need an screeshot on where to add/update your email template files in netlify

@tomrutgers @audetcameron , Thanks for your input! I was a bit distracted by other work to do this properly.
I have now updated the readme to be more extensive and also added /static/emails/ templates included so it is easy for activation.


does this plugin work?

i tried running your tests and they tend to fill my screen with errors.
i do have redis installed, and i'm using it for other parts of my code, so i don't think it's the issue.

Yeah, it should work. What sort of errors are you seeing?

npm install
npm test

@boxxxie please add a proper bug report if you have issues


Can't obtail overheat nailgun

for somereason, when i try to buy overheat nailgun after i got the attractor, with all of the recources needed, it just says "error : user allready owns the item", andwhen i try to switch i don't have it, this is quite a big bug

fixed in 2.1.1


Duplicated indices in a DataFrame leads to the failure of add_points_from_xy().

Environment Information

leafmap version:  0.8.2
Python version: 3.7.10
Operating System: Windows

Description
Describe what you were trying to get done.
Duplicated indices in a DataFrame lead to the failure of add_points_from_xy().

Not enough of information for debugging. Please provide sample data and script that can reproduce the issue

Closing this issue to the lack of information. Feel free to reopen when you can provide detailed information


Batch rocksdb updates during state recovery

Why?
Currently, when the application recovers from the changelog topic, it writes every state update to the rocksdb.
It's not very efficient and can lead to longer recovery times.
What?
Batch updates to RocksDB during recovery by a number of updates or total bytes in the batch.
Things to keep in mind:

Batches should not be too large, otherwise they will take too much memory.
Multiple batches can be accumulated simultaneously, one batch per recoverable state partition.

Here you can try few things during the implementation of efficient batch updates to RockDB during the recovery process, by considering the above constraints:

Set limits on the number of updates and total bytes per batch to ensure batches are not too large.

Accumulate state updates in memory until the batch size limit is reached, then write the batch to RockDB.

Maintain separate batches for each partition to handle parallel recovery efficiently.

Once a batch reaches its size limit or the recovery is complete for a partition, write the batch to RockDB.


OnRequest event should wait until onWorkerStart finish

If HTTP request comes when onWorkerStart event is not finished yet, request is processed which is not desired. On request event should wait until start event finish, then start processing requests.
Idea, taken from hyperf fw: We can use Channel, size 1, onRequest call pop(), and wait until onWorkerStrart close the channel.

Best way is to require https://github.com/hyperf/coordinator lib into composer, otherwise i would take almost all classes... @Rastusik are u OK with that, or should (copy-paste) required parts ?!

Not sure about bug in swoole, I found info about this in official swoole (and openswoole documentation):

Before the server Start event, the Server has finished the following:
Created the Manager process
Created the Worker-Sub processes
Listening on the TCP/UDP port that was specified, no connections are accepted until this event returns
Started the OpenSwoole Timer process
After the Start event executes, the reactor threads are ready to process server events and accept connections from clients.

also:

OnWorkerStart and onStart callbacks are executed in parallel in different processes, with no order of precedence.

Hyperf fw solves that: https://github.com/hyperf/hyperf/blob/master/src/http-server/src/Server.php#L86
Coordinator lib just has functions which I would take to implement/fix this flow.

@Rastusik your opinion? would like to fix it some how :) thx.

@pistej sorry I didn't have a lot of time lately. Feel free to start a proof of concept if you wish and we will see. I'm kind of skeptical with the yeld approach here https://github.com/hyperf/hyperf/blob/master/src/http-server/src/Server.php#L87

@Rastusik It's not yeld, just naming... created POC PR

@pistej released


PHP 7.1 issue

Hey,
We think there might be a slight php 7.1/7.2 compatibility issue with phpunit 7.0.3 (excuse me if you dont expect it to work with this)

The error we actually get when running phpunit is

Is this something you believe can be fixed?

Should be fixable. See these changes that where made to the NyanCat printer:
https://github.com/JeroenDeDauw/nyancat-phpunit-resultprinter/commit/7b9c6a5aefd6fe5103c877ec480a77c7d366d47a
https://github.com/JeroenDeDauw/nyancat-phpunit-resultprinter/commit/9854f48170c0e82b8ecd2ed4298f6029c405fd92


Simplify Bootstrap usage

Once again, I felt like I needed access to Bootstrap buttons, but this time I needed them in a post and not a page. To do this, something came to my mind - why would we need a separate layout for Bootstrap? Could just be a toggle in page/post Front Matter.
I have adapted it to my blog and it seems to work wonders:
https://github.com/CookiePLMonster/CookiePLMonster.github.io/commit/cec93d3d8442298d8eb416ad2696bba7c5a4e378
Do you think tweaking it to be like this is feasible? Seems like it would make using Bootstrap more straightforward, without it "leaking" into the theme needlessly (since you seem to want to avoid that).

Yeah it's sweet!!
I was actually thinking of doing something like that but did not have bandwidth to start it.
If you want to make a pull request, I would be able to test it a bit. 😄

PR accepted, I am closing this one ;)


[BACKLOG-11905] Fix icons

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -f ui/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  ui/src/org/pentaho/di/ui/core/gui/GUIResource.java
  ui/src/org/pentaho/di/ui/core/widget/ConditionEditor.java
  ui/src/org/pentaho/di/ui/partition/dialog/PartitionSchemaDialog.java
  ui/src/org/pentaho/di/ui/spoon/trans/TransGraph.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.ui.spoon.trans.TransGraph

Instruction Change: -.00%:small_red_triangle_down:
Line Change: -.00%:small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on ui/src/org/pentaho/di/ui/core/widget/ConditionEditor.java. Found 2016. Was expecting 2017

:heavy_exclamation_mark: Copyright year is not the current year on ui/src/org/pentaho/di/ui/partition/dialog/PartitionSchemaDialog.java. Found 2013. Was expecting 2017

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -f ui/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  ui/src/org/pentaho/di/ui/core/gui/GUIResource.java
  ui/src/org/pentaho/di/ui/core/widget/ConditionEditor.java
  ui/src/org/pentaho/di/ui/partition/dialog/PartitionSchemaDialog.java
  ui/src/org/pentaho/di/ui/spoon/trans/TransGraph.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.ui.spoon.trans.TransGraph

Instruction Change: -.00%:small_red_triangle_down:
Line Change: -.00%:small_red_triangle_down:


Unhandled Exception: NoSuchMethodError: The method '<' was called on null

3.2.7 version in pub.dev is broken and not consistent with master
I'm trying to run an application but receive an exception:
E/flutter ( 9315): [ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: NoSuchMethodError: The method '<' was called on null.
E/flutter ( 9315): Receiver: null
E/flutter ( 9315): Tried calling: <(8)
E/flutter ( 9315): #0      Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5)
E/flutter ( 9315): #1      _Executor.warmUp (package:worker_manager/src/executor.dart:60:23)
E/flutter ( 9315): #2      main (package:tc_x/main.dart:12:20)
E/flutter ( 9315): #3      _runMainZoned.<anonymous closure>.<anonymous closure> (dart:ui/hooks.dart:231:25)
E/flutter ( 9315): #4      _rootRun (dart:async/zone.dart:1190:13)
E/flutter ( 9315): #5      _CustomZone.run (dart:async/zone.dart:1093:19)
E/flutter ( 9315): #6      _runZoned (dart:async/zone.dart:1630:10)
E/flutter ( 9315): #7      runZonedGuarded (dart:async/zone.dart:1618:12)
E/flutter ( 9315): #8      _runMainZoned.<anonymous closure> (dart:ui/hooks.dart:223:5)
E/flutter ( 9315): #9      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:301:19)
E/flutter ( 9315): #10     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
E/flutter ( 9315):

3.2.7 sources:
55  @override
56  Future<void> warmUp({bool log = false, int isolatesCount}) async {
57    _log = log;
58    final processors = numberOfProcessors;
59    var processorsNumber =
60        isolatesCount < processors ? isolatesCount : processors;
61    if (processorsNumber == 1) processorsNumber = 2;
62    for (var i = 0; i < processorsNumber - 1; i++) {
63      _pool.add(IsolateWrapper());
64    }
65    logInfo('${_pool.length} has been spawned');
66    await Future.wait(_pool.map((iw) => iw.initialize()));
67    logInfo('initialized');
68  }

As you can see in line 60 you are trying to compare nullable isolatesCount with processors. But isolatesCount is null and null doesn't have < operator.
I wanted to resolve this issue by myself, but I found that sources in pub.dev and master are not consistent

Hello @DmitryVoronko thx for creating the issue, bug already resolved in 3.2.8


Added 3 new libs and updated 1

PR for https://github.com/mikepenz/AboutLibraries/issues/201
Add new:
compile 'com.github.paolorotolo:appintro:3.4.0'
compile 'com.annimon:stream:1.0.8'
compile 'com.pixplicity.easyprefs:library:1.8.1@aar'

Will update:
compile 'com.google.android.gms:play-services-gcm:8.4.0'

@mikepenz Since play-services-gcm and all other GPS libraries are close source, should we create a separate libs XML for each one?

@jaredsburrows I think it's fine if there's only one for the complete package

@mikepenz Ok. That's fine.

@mikepenz After this PR, can you make a release?

v5.6.1


feat(theme): add new style for compomponent Input

Failed to compile.

13:22:42.741 | ▲  ../../packages/components/react/input/input.tsx:6:18
13:22:42.741 | ▲  Type error: Interface 'Props' cannot simultaneously extend types 'InputHTMLAttributes<HTMLInputElement>' and 'VariantProps<(props?: ({ borderColor?: "error" \| "none" \| "primary" \| "success" \| "warn" \| null \| undefined; background?: "error" \| "none" \| "primary" \| "success" \| "warn" \| null \| undefined; size?: "small" \| ... 3 more ... \| undefined; } & ClassProp) \| undefined) => string>'.
13:22:42.741 | ▲  Named property 'size' of types 'InputHTMLAttributes<HTMLInputElement>' and 'VariantProps<(props?: ({ borderColor?: "error" \| "none" \| "primary" \| "success" \| "warn" \| null \| undefined; background?: "error" \| "none" \| "primary" \| "success" \| "warn" \| null \| undefined; size?: "small" \| ... 3 more ... \| undefined; } & ClassProp) \| undefined) => string>' are not identical.
13:22:42.742 | ▲
13:22:42.742 | ▲    4 \|
13:22:42.742 | ▲    5 \| export interface Comp extends HTMLInputElement {}
13:22:42.742 | ▲  > 6 \| export interface Props extends React.InputHTMLAttributes<HTMLInputElement>,
13:22:42.742 | ▲      \|                  ^
13:22:42.742 | ▲    7 \|   VariantProps <typeof input> {
13:22:42.742 | ▲    8 \|   Label?: string
13:22:42.742 | ▲    9 \|   Icon?: React.ReactNode
13:22:42.832 | ▲  ELIFECYCLE  Command failed with exit code 1.
13:22:42.871 | ▲  Error: Command "pnpm run build" exited with 1
13:22:42.959 |
13:22:42.960 | ⚡ The Vercel build (`npx vercel build`) command failed. For more details see the Vercel logs above.
13:22:42.960 | ⚡ If you need help solving the issue, refer to the Vercel or Next.js documentation or their repositories.
13:22:42.960 |
13:22:42.996 | Failed: Error while executing user command. Exited with error code: 1
13:22:43.008 | Failed: build command exited with code: 1
13:22:44.366 | Failed: error occurred while running build command


feat(src): add support for custom error messages

Notable Changes
This PR adds support for custom error messages defined in the options schema within an errorMessage  property. Current schemas without an errorMessage prop are unaffected by this change
schema.json
{
  "type": "object",
  "properties": {
    "option": {
      "type": [ "boolean" ]
    }
  },
  // Overrides the default err.message for option
  "errorMessage": {
    "option": "should be {Boolean} (https:/github.com/org/repo#anchor)"
  }
  "additionalProperties": false
}

{Name} Invalid Options

- options.option should be boolean
+ options.option should be {Boolean} (https:/github.com/org/repo#anchor)

Type

[x] Feature

Issues

Fixes #18

SemVer

[x] Feature (:label: Minor)

Checklist

[x] I have signed the CLA
[x] Lint and unit tests pass with my changes
[x] I have added tests that prove my fix is effective/works (if needed)
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes are merged and published in downstream modules

I added travis back but it doesn't trigger in webpack-contrib despite it being enabled 😞 . I think there is a permissins/webhook missing for the org but I couldn't find it

But the build passes on my fork of the repo

Would be really good to have Travis CI available alongside CircleCI for more advanced setups. Travis is just easier to use for simpler packages

CI is failing here because there is no .circleci config

@michael-ciniawsky let's add template in this PR :+1: https://github.com/webpack-contrib/webpack-defaults/tree/master/templates/.circleci

I would like to but the current CircleCI is to complicated and doesn't work with the current scripts.
By to complicated I mean that it automatically installs webpack which is not needed for this package. The current default CircleCI setup makes to much assumptions about the package and is specific to loaders/plugins. We should either simplify it and add needed stuff per repo or use e.g Travis CI for that and leave the CircleCI setup Loader/Plugin specific

@michael-ciniawsky hm, i.e. adding template from default doesn't work? If local tests are passed feel free to merge and release :+1:

It could theoretically work with the current CirclCI config of course 🙃 I could ducktape it in and cleanup the config, still it's not really needed nevertheless and likely will need to be refactor later on anyways. All that is needed is to grant travis org permissions again, but as it seems I sadly can't do that myself
I open an issue that this needs be fixed, but will merge this PR later to finish the pending postcss-loader update and revert the dep changes there, since test pass on the fork

@michael-ciniawsky :+1:


Discovery Page - Direct link to search results

A user requests the ability to give someone a link that goes directly to a search results page.  This feature was available in the old system and people used it.

Verified works on ci-develop.amlng.di2e.net.

Verified in all browsers on the staging environment.

Retroactive :+1:


Boolean expression object

fixes #5666
Based on https://github.com/Qiskit/qiskit-terra/pull/5656 (this extends and replace #5656), this PR:

implements BooleanExpression which:

leverages tweedledum python expression parser.
leverages tweedledum DIMACS parser.

creates PhaseOracle (similar to previous LogicalExpressionOracle) as a circuit wrapper of BooleanExpression

This issue is blocked on recently found issues on tweedledum.

tweedledum 1.0.0 released https://pypi.org/project/tweedledum/1.0.0/
removing on hold


Stop calling the attribute change callback on the wrong thread in bridge-app.

A few changes here:

Stop trying to pass values to the attribute change callback, since those get
ignored anyway.
Run the attribute change callback off a task on the Matter thread, instead of
calling it directly from a different thread.
Change initial bridge setup to set state before setting change callbacks, so
we won't try to notify changes at startup before the Matter stack is actually
initialized.

Fixes https://github.com/project-chip/connectedhomeip/issues/21212
Problem
See above.
Change overview
See above.
Testing
Ran bridge-app locally.  Tried triggering things by typing b and c followed by return in the bridge app, and with these changes no longer fail the threading asserts.

Fast tracking platform changes.


added [windows] extra to encapsulate windows dependancies #25

adds the windows extra to the package that explicitly adds pypiwin32 as a dependency.
should be invoked with pip install magic-wormhole[windows] as per issue #25.

landed (in rebased form) in 13cda9e6159784dda7f7b67ae600fc64aac0fe0e . thanks!


Add link to readme

Instead of saying "" show the location of the repo. Reason being, most people reading the README that want to take action will just want to copy the direction and use it.
Thanks!

Took care of this in latest README update.


Pallet dispatchable+storage doc module.

hopefully closes https://github.com/paritytech/substrate/issues/12398, but needs more work.
step toward https://github.com/paritytech/substrate/issues/13299

Figuring out how we want to handle generics in fn signatures in pallets aka situations like this:
pub fn set(origin: OriginFor<T>, #[pallet::compact] now: T::Moment) -> DispatchResult {

are causing this error:
error[E0412]: cannot find type `T` in this scope
   --> frame/balances/src/lib.rs:372:28
    |
369 |         pub fn force_transfer(
    |                              - help: you might be missing a type parameter: `<T>`
...
372 |             dest: AccountIdLookupOf<T>,
    |                                     ^ not found in this scope

As far as I can tell that is the only outstanding thing not working

Figuring out how we want to handle generics in fn signatures in pallets aka situations like this:
		#[pallet::call_index(2)]
		#[pallet::weight(T::WeightInfo::force_transfer())]
		pub fn force_transfer(
			origin: OriginFor<T>,
			source: AccountIdLookupOf<T>,
			dest: AccountIdLookupOf<T>,
			#[pallet::compact] value: T::Balance,
		) -> DispatchResultWithPostInfo {

are causing this error:
error[E0412]: cannot find type `T` in this scope
   --> frame/balances/src/lib.rs:372:28
    |
369 |         pub fn force_transfer(
    |                              - help: you might be missing a type parameter: `<T>`
...
372 |             dest: AccountIdLookupOf<T>,
    |                                     ^ not found in this scope

As far as I can tell that is the only outstanding thing not working

Maybe put a <T: Config> on every function? or better, wrap them all in
/// Some doc saying that this struct does not exist in reality
pub struct Dispatchables<T: Config>(Phantom(T));
impl<T: Config> Dispatchables {
  // This is now 100% identical to `Pallet` struct and should work.
}

and then we export struct Dispatchables, which is good enough.

This clearly requires some screenshots on how that looks in the docs. I'm not 100% sure that adding fake items to the docs is such a great idea.

These when clicked take you to the relevant docs. I think the best dev UX would be to have the docs here verbatim but alas that doesn't quite work in rustdoc with re-exports. I actually ran into a literal compiler bug when I tried to do anything other than re-exporting for this one, btw.

This one works better because they are not re-exports:

Did you tried using pub type StorageItem = super::StorageItem instead of the re-export.
But with the calls people will then not know how to use them. From the docs it looks like there is some module, which doesn't really exists 🤷

Did you tried using pub type StorageItem = super::StorageItem instead of the re-export.
But with the calls people will then not know how to use them. From the docs it looks like there is some module, which doesn't really exists 🤷

Yeah in that case I think the current solution is the best compromise because at least it points them to the right place.
As far as accessibility, I will add a comment saying these types and functions are available on the pallet itself or something to that effect

Suggestion: For each dispatchable, link to the actually function in struct Pallet and the corresponding enum Call variant as well, emphasizing that "the real thing is there, this is just a fake" list.
For storage items, I think this is great and already a massive improvement.
I will try and help a bit with the auto-generated documents, making sure they are not confusing, especially for the dispatch stuff.

Hmm I wonder if we could instead just add the docs to the Call enum variants? thoughts?

As with everything doc-related, it's hard to give comments if we don't know how it looks like on the UI, especially when it is about grouping similar items together, which is what the entire underlying issue is about.

As with everything doc-related, it's hard to give comments if we don't know how it looks like on the UI, especially when it is about grouping similar items together, which is what the entire underlying issue is about.

i.e. what if we emit doc strings on these variants instead of the dispatchables module shown above:

lol so we've come full circle. I scrolled down the page on the Call enum only to realize the variants are already documented:

Do we maybe just want to surface this better with a link to the Call variant on the main docs page for each pallet? Looks like this already perfectly documents the dispatchables for any given pallet

I guess the intent though of what @kianenigma was doing with the dispatchables was to render them in the docs as actual functions instead of enum variants. Given that, I think it might be better to leave it the way he set it up, but I'm going to add doc links to the actual variants like he suggested on each one

OK so yeah latest commit adds this preface to the docs for the auto-generated dispatchables stub functions:

Notably, the NOTE actually links to the proper enum variant corresponding with the function.

If we like the wording above I think this is ready

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2522151

Have also added a revamp of the very ugly Instance1, Instance2, Instance3... Instance16 stuff in the pallet module based on @ggwpez's feedback:

Using structs for the storage types works. We dont actually need the concrete storage type. If we really want we could still link to the frame-support::storage::... type but for high-level this looks good to me.
Before:

After:

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2522449

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2522442

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2522443

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2522444

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2522506

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2522499

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2522501

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2522500

@KiChjang this should be good for a final look now, screenshots at the top are updated

bot rebase

bot merge


set within list notation does not what it is supposed to do (arg-st.tex)

These lists are two-element lists. The second element is a set. Add a footnote explaining how to do this with shuffle?

mail


WebDataset for deepspeed / distributed training

I wanted to include WebDataset in a github repo (instead of just using image-text pairs within a folder). I'm having trouble getting the deepspeed distribution to work with the WebDataset format.
(distr_dalle, distr_opt, distr_dl, distr_scheduler) = distr_backend.distribute(
    args=args,
    model=dalle,
    optimizer=opt,
    model_parameters=get_trainable_params(dalle),
    training_data=ds if using_deepspeed else dl,
    lr_scheduler=scheduler if LR_DECAY else None,
    config_params=deepspeed_config,
)

The regular image-text-folder loader works fine with with deepspeed:
    ds = TextImageDataset(
        args.image_text_path,
        text_len=TEXT_SEQ_LEN,
        image_size=IMAGE_SIZE,
        resize_ratio=args.resize_ratio,
        truncate_captions=args.truncate_captions,
        tokenizer=tokenizer,
        shuffle=is_shuffle,
    )

But Deepspeed does not seem to work with this WebDataset implementation:
(Training without deepspeed is fine, so it is no error with the data itself, but with deepspeed / sampling / batch generation, ...)
    ds = wds.Dataset(args.image_text_path) \
        .map_dict(**image_text_mapping) \
        .map_dict(**image_mapping).to_tuple(mycap, myimg) \
        .batched(BATCH_SIZE)

This is my error code:
ValueError: DataLoader with IterableDataset: expected unspecified sampler option, but got sampler=<torch.utils.data.distributed.DistributedSampler object at 0x7f120708eca0>

The error occurs in this line:
for i, (text, images) in enumerate(distr_dl):

This is the repo: https://github.com/robvanvolt/DALLE-pytorch/blob/loader-for-webdataset-included/train_dalle.py

You can just use your own DataLoader without the need to let DeepSpeed handle it. Solved.


Error in matrix(0, nrow = length(eids), ncol = ncol(expTPM)): "non-numeric matrix extent"

Hi,
I have been trying to run CellNet locally on my Mac. But there's error "non-numeric matrix extent" at the step "Estimation of expression levels".
Here's my code:
expList<-cn_salmon(stQuery, refDir="ref/", salmonIndex=iFileMouse,salmonPath=pathToSalmon)
When I trace back, it's the line "ansTPM<-matrix(0, nrow=length(eids), ncol=ncol(expTPM))" at function "gene_expr_sum" at "cn_salmon".
I'm not familiar with R, so would you please help with this?

I've checked the class of expTPM. After the line "expTPM<-expDatList[['TPM']]", class(expTPM) is matrix. But after the line "expTPM<-expTPM[sameProbes,]", class(expTPM) is numeric. Then when it gets to "ncol=ncol(expTPM)", the "ncol" is NULL.

How many fastqs are you trying to process?

@pcahan1 Sorry, I realized I was trying to test with only one fastq file.
But when I tried to test with three fastq files, I got another error at cn_salmon:
./salmonRes_FKO_mESC/quant.sf
./salmonRes_WT/quant.sf
./salmonRes_FKO_diff/quant.sf
Error in geneIndexList[[i]] : subscript out of bounds
Actually I didn't got any error when I test on my Mac. But I couldn't figure out what's going on when I tried to test it on server. I used the latest version of salmon and build the index myself.

I wonder where I can download the fasta file you used to build index: Mus_musculus.GRCm38.cdna.ncrna.exo.fa

Hi, We are working on this and hope to have a fix very soon. Will post here as soon as we can. Thanks.

The latter issue

./salmonRes_FKO_mESC/quant.sf
./salmonRes_WT/quant.sf
./salmonRes_FKO_diff/quant.sf
Error in geneIndexList[[i]] : subscript out of bounds

is likely due to using a different index that what we have provided.
We have fixed the earlier error in gene_expr_sum that pops up when the pipeline is applied to one query sample.
Please let us know if you have any more issues. Thanks!

@pcahan1 Thanks!
I then used cdna and ncrna files from Ensembl to rebuild the index with the latest salmon software and it works throughout the cn_salmon function.
I noticed that the index file that you provided (that is "salmon.index.mouse.122116") doesn't work well with the latest version of salmon(0.8.2), which would raise a error so that we need to rebuild the index with latest version of salmon.
However, I got another problem at the "Reconstruction of GRNs" step when using the "cn_make_grn" function:
esc : 5
liver : 3
neuron : 5
VE : 1
Number of samples per CT:  1
Error in expDat[, rownames(stGRN)] : incorrect number of dimensions
Calls: cn_make_grn
In addition: Warning message:
In if (is.na(tfs)) { :
the condition has length > 1 and only the first element will be used
I was trying to use my own data to train a new CellNet, btw. The training metadata table is in ".rda" format in your paper. I just read my csv file and save as ".rda" in R and then use it for  cn_make_grn function together with the output of cn_salmon function. Is there anything wrong with this conversion ?  I hope that I describe my situation clearly.

The output file of cn_salmon is a list, while the parameter for cn_make_grn need to be a matrix ?  Step 13-16 in your Nature Protocol paper doesn't describe how to build a new CellNet in details. So far, I have just finished collecting fast files, creating a training metadata table in "csv" format and run through the cn_salmon function...

Hi, I am going to move this last error

Error in expDat[, rownames(stGRN)] : incorrect number of dimensions
to another issue and close this one as it is not related to the original bug.

I cannot recommend using so few samples per cell type or tissue. In the original CellNet paper, the minimum was around 60 samples per cell type, and in the rna-seq we have gone as low as 30-40.


Add to array (fix + unit tests)

Kirthi, this is the PR containing the changes for adding to an array (including unit tests)

Hi @KevinDockx, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft Open Technologies, Inc. and real humans are currently evaluating your PR.
TTYL, MSOTBOT;

@GrabYourPitchforks

@KevinDockx - Changes look fine to me but we need to fix spacing. I can fix that.

@kirthik: tnx!  On the spacing issue: - ok, sounds good to me :)

Yah, we don't use tabs.

Checked this into jsonpatch branch. This is related PR for jsonpatch branch - https://github.com/aspnet/Mvc/pull/2212


Connection refused

Getting this error upon trying to setup the bot:
Get "http://localhost:9222/json/version": dial tcp [::1]:9222: connect: connection refused
These are my commands that I previously entered:
% export NVIDIA_CLERK_SKU=5438481700
% export TWILIO_ACCOUNT_SID=[redacted]
% export TWILIO_TOKEN=[redacted]
% export TWILIO_SOURCE_NUMBER=[redacted]
% export TWILIO_DESTINATION_NUMBER=[redacted]
% chmod +x ./nvidia-clerk-darwin
% ./nvidia-clerk-darwin -sms

Running MacOS. Chrome is installed.
Script was working last time I ran which was v0.4

I'm wondering if this is a permissions thing, nothing should have changed that would effect OSX users?
Do you see a chrome window opening when run,
% ./nvidia-clerk-darwin -sms

Same issue for me on linux but first time trying
2020/09/21 18:56:38 Get "http://localhost:9222/json/version": dial tcp [::1]:9222: connect: connection refused

Try to sudo -E for the command (should use the environmental variables you set in your user account)

Try to sudo -E for the command (should use the environmental variables you set in your user account)

Did do this, running in a VM though if it matters but made sure that I was running it as root

I'm wondering if this is a permissions thing, nothing should have changed that would effect OSX users?
Do you see a chrome window opening when run,
% ./nvidia-clerk-darwin -sms

Not on the first time.
Second time worked like a charm, but still getting the odd issue as detailed in https://github.com/ianmarmour/nvidia-clerk/issues/29 (I understand this is the API - not the bot itself).

Closing this out as it's now resolved please update to the latest release :)


Create synth script for firestore and regen gapic

We might be close to merging the Firestore Watch PR, and if we are I may hold off on approving this until that is merged. Just in case.

Tests are failing anyway. Looks like I might have screwed up some credentials change.


Add indentation to all of our monaco snippets with curly braces

Our monaco snippets currently don't add indentations in between curly braces when they're dragged out for built-in language features. Functions (like forever) do add the indentation.
Changing the snippets for the built-in's to match.

Port to stable


github_release always returns 0, even if release doesn't exist

$ . ./is_command.sh
$ . ./log.sh
$ . ./http_download.sh
$ . ./github_release.sh
$ github_release client9/misspell
v0.3.4
$ echo $?
0
# correct ^^

# non existant version number
$ github_release client9/misspell xxx
curl: (22) The requested URL returned error: 404 Not Found
$ echo $?
0

# this repo doesn't have any releases
$ github_release client9/shlib
curl: (22) The requested URL returned error: 406 Not Acceptable
$ echo $?
0

problem is actually in http_download
$ http_download /dev/null https://github.com/joanyi
$ echo $?
0
$ http_download /dev/null https://github.com/
$ echo $?
0

fixed


Service "Test//Climate.MapServer" is associated with a portal item that does not exist

ERROR: Service "Test//Climate.MapServer" is associated with a portal item (96bf1c94e296460382e9299accf4b1fa; MapServer) that does not exist.
Most likely cause is that publisher deleted the service incorrectly. Non-hosted service should be deleted through an AGS connection in desktop and not by deleting the portal service item.
If this service was truly meant to be deleted, let me know and I can delete this service.(important as if it's not deleted then service will be published to UC machines utilizing memory that can be used for required services.

@jrweakland @joebayles This one is nothing to do with me sorry

@elinz delete this service please.

Checked today and this service no longer exists. Closing issue.


deleting file from download dir doesn't work

So I try something like this:
`curl -vL -X DELETE -u test:test-password http://<IP_ADDRESS>:4445/download/548eba3d2534abeb03b7e6162388415c/image.jpg
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 4445 (#0)
* Server auth using Basic with user 'test'
> DELETE /download/548eba3d2534abeb03b7e6162388415c/image.jpg HTTP/1.1
> Host: <IP_ADDRESS>:4445
> Authorization: Basic dGVzdDp0ZXN0LXBhc3N3b3Jk
> User-Agent: curl/7.63.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Accept-Ranges: bytes
< Content-Length: 38760
< Content-Type: image/jpeg
< Date: Fri, 08 Feb 2019 12:03:10 GMT
< Last-Modified: Thu, 07 Feb 2019 15:42:24 GMT
<
Warning: Binary output can mess up your terminal. Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.
* Failed writing body (0 != 3923)`

But nothing happens. And you can see the output. So what am I doing wrong here?

@djordje-petrovic this feature is partially implemented on browser images side and only recent browser versions should contain a binary that supports deleting.

@vania-pooh Could you be please more speficic? Which images have fileserver bin that can delete files? I'm using selenoid/chrome:72.0 and this one should have it right? Of built opon base_4, right?
https://github.com/aerokube/selenoid-images/blob/master/selenium/base/base_4/fileserver/main.go#L16-L41

Ran into the same issue with "browsers":{"chrome":{"73.0":{}}

@djordje-petrovic unfortunately this was implemented but never built into images.


Silence console logger in gitea serv  (#5887)

By default, if setting.NewContext() prints out any warning logs, these are printed to the stdout breaking git receive-pack etc. meaning that even if there is a warning because of a minor problem in your app.ini but gitea starts despite this - you CANNOT push or pull over SSH.
This PR disables the console logger whilst in serv.go
Backport #5887 to fix #5866
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Make LG-TM work


Bump LLVM to 82c18dd9add0fa96ac95256fd1b0b1202f9f56dd

Do we really need to bump it or would a cherry pick work. All checks are fine, but it might be better to keep bumping LLVM, MHLO and TF together. Also LLVM bump PRs probably needs someone from core IREE team to be reviewer.

I can start an integration later today. TF has checked in the needed cherry-pick commit, so we can make LLVM version aligned with TF/MHLO repo.

Do we really need to bump it or would a cherry pick work. All checks are fine, but it might be better to keep bumping LLVM, MHLO and TF together. Also LLVM bump PRs probably needs someone from core IREE team to be reviewer.

I can start an integration later today. TF has checked in the needed cherry-pick commit, so we can make LLVM version aligned with TF/MHLO repo.

Thanks Hanhan!

Do we really need to bump it or would a cherry pick work. All checks are fine, but it might be better to keep bumping LLVM, MHLO and TF together. Also LLVM bump PRs probably needs someone from core IREE team to be reviewer.

My expectation is that a bump that is green is always better than a cherry-pick as there is literally 0 possible surprises in either projects (OTOH a cheery-pick may well fail to build with TF if we tried). Is this inaccurate?

My expectation is that a bump that is green is always better than a cherry-pick as there is literally 0 possible surprises in either projects (OTOH a cherry-pick may well fail to build with e.g. TF if we tried). Is this inaccurate?

Sometimes it may break internal stuff because the internal integration is not happened yet. I think you're right for most of cases if there are no IREE file changes.

This is covered in https://github.com/google/iree/pull/8786

sg, thanks @hanhanW !


Bring menu item/reference selection into core and make a new Reference selector widget

Package targeted
Both
Description
I was hoping to implement this as a PR immediately, but it's become a little bigger than I had imagined so I think it's best we scope this out.
Currently, this Menu Item selector/editor is only available when the Pages plugin is installed:

However, I feel (and I seem to recall the other maintainers feeling the same) that this is a well useful tool that could be used in other areas, and as such should be brought into core. Ideally, I'd like to create a new FormWidget called "Reference" which brings up a (simplified) version of this selector and calls for all plugin references (the pages.menuitem.* events), allowing the user to select a reference for cross-linking, or providing an ability for a field to contain either a straight URL or a dynamic reference to a plugin item. This would make it similar to Wordpress' link picker:

Storage
There's two ways we could store these references:

As a JSON or serialized object. Seems a bit "unclean" in my opinion, but would be much easier. Should be stored as an object to allow for URL changes on the target references. The object would need to be decoded/unserialized prior to use - for forms/models, we could do this automatically. For Twig, it might need a filter like we have for media items.
Alternatively, we could store it as an "attachment" relation. Would require a database call to get the relations however, and Halcyon has no relation capability yet, so would require us to add - at a minimum - attach relation capabilities to Halcyon. Doing this would pave the way to allow us to eliminate another issue: people being unable to use fileupload widgets with Halcyon objects.

Reference FormWidget
The Reference form widget should, at a minimum, provide the following fields from the menu item editor above:

Type
Reference
Allow nested items?
Replace with children?

It should return a class representing the reference: ideally, this class should be able to determine if there's multiple references or not, and return URLs for each.
It may be prudent to allow the form widget to be configured to accept only one reference (therefore not allowing nested items), or accept multiple.
Other places to implement this
The same picker should be made available for the Rich Editor and Markdown Editor's link buttons. Currently, I believe, these both allow you to just pick a CMS page.
Will this change be backwards-compatible?
Yes, backwards compatibility would be maintained.
Ideally, we'll need to use new event names, but call the old event names for compatibility and merge the results. I propose the following:

references.getTypes (replaces pages.menuitem.listTypes, gets the available reference types for the "Type" dropdown)
references.getReferences (replaces pages.menuitem.getTypeInfo, gets the available references for a particular type)
references.resolve (replaces pages.menuitem.resolveItem, resolves a reference object)

OH God yes. I rarely use static pages but use the static pages menu editor all the time. I'd live for it to be extensible so I can store other data such as related font icons or extend it to recognize Passage permissions.


Should resolutions <= 0 fail?

Does it make sense to allow to pass a resolution <= 0?

With resolution < 0 no data will be returned.
With resolution = 0 some providers will fail due to a division by 0 (for instance windshaft provider query won't work).

related: https://github.com/CartoDB/torque/issues/47

I do think they should fail, but maybe as a 400 from the server? It'd make sense with what we've been doing so far.

+1 for the 400.

OK then since we're dealing with this server-side let's close this and keep tracking on Windshaft.


DynamicLoad.mat is missing, could you add it Sir?

DynamicLoad.mat is missing, could you add it Sir? Thank you very much!

Same problem here

Sir is dynamic.mat available

DynamicLoad.mat is missing, could you add it Sir? Thank you very much!

DynamicLoad.mat is missing, could you add it Sir? Thank you very much!

Also looking for dynamicLoad.mat

Me too


Allow building with Java 8

JaCoCo versions older than 0.7 do not support Java 8. Updating to the
latest version fixes this.
I have executed the automated tests: all of them are successful.

travis seems to be failing even without my changes.
Could you please look into this then trigger a new travis build?

Looks like the Caelum repo is missing some snapshot dependencies for VRaptor.

Hi, @xdarklight! Thanks for the contribution, I actually removed this jacoco plugin while fixing the dependencies issues, so I'm closing here, ok!
It would be great if you open a new PR with the jacoco setup.


Evaluation of Postfix Expression

I want to add a new problem to the stacks section.
The problem I want to add is the Evaluation of Postfix Expression (which is a quite fundamental problem related to stacks).
Please assign me to work on this problem in c++ language. I can also work in python and java on this issue.

Hi I'm a GSSOC participant. I can also contribute by writing the code in python or cpp. Please assign it to me

@raksha009  please assign this issue to me ,I will implement in c++