Add fix for Full Metal Daemon Muramasa

Full Metal Daemon Muramasa is borked on gog when running the game through Proton. After reaching the main menu and clicking Start, the game is observed to, at some point, freeze due to audio-related deadlocks from wine resulting in errors such as:
err:ntdll:RtlpWaitForCriticalSection section 0x76b5d38 "?" wait timed out in thread 0138, blocked by 0148, retrying (60 sec)

This title uses the same game engine as other Nitroplus titles such as YOU and ME and HER: A Love Story (1293820), which exhibits the exact symptoms. However, unlike those, falling back to wine server sync and running the xact verb is not sufficient. To fix the deadlocks, xaudio2_8.dll needs to be within the game directory.
Tested against GE-Proton9-11

The xaudio2_8.dll file is sourced from the xaudio29 verb from winetricks, and will be renamed to xaudio2_8.dll in the game directory.

File: xaudio2_8.dll.gz
File digest (sha256): 173cac0a7931989d66338e0d7779e451f2f01b2377903df7954d86c07c1bc8fb
Virus Total (xaudio2_8.dll):
https://www.virustotal.com/gui/file/df3d1ddfa5a439676230b4714f29738d627c2f9574aec179777f7951ddc822f7
Virus total (xaudio2_8.dll.gz):
https://www.virustotal.com/gui/file/173cac0a7931989d66338e0d7779e451f2f01b2377903df7954d86c07c1bc8fb?nocache=1

Can't we just use util.protontricks('xaudio29')?
If the file needs to be in the game's directory or has the wrong name, we could sym-link or copy the file.

Using util.protontricks('xaudio29') requires to run the winetricks verb, which we both know is slow. Here, we can just skip winetricks all together and just simply put the file directly inside the game directory.


Bumping go packages to fix CVE

fixes: https://github.com/open-telemetry/opentelemetry-network/issues/243

Thanks for this!
It doesn't seem to compile (see the auto checks above), appears to require a go mod vendor.
fyi I tried go mod tidy on this branch and got:
opentelemetry-network/collector/k8s $ go mod tidy
go: downloading sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2
go: finding module for package ebpf.net/collector
go: finding module for package k8s.io/api/resource/v1alpha1
go: finding module for package k8s.io/api/flowcontrol/v1alpha1
ebpf.net/collector/k8s-watcher imports
	ebpf.net/collector: can't request version "latest" of the main module (ebpf.net/collector)
ebpf.net/collector/k8s-watcher imports
	k8s.io/client-go/kubernetes imports
	k8s.io/client-go/kubernetes/typed/flowcontrol/v1alpha1 imports
	k8s.io/api/flowcontrol/v1alpha1: module k8s.io/api@latest found (v0.29.2), but does not contain package k8s.io/api/flowcontrol/v1alpha1
ebpf.net/collector/k8s-watcher imports
	k8s.io/client-go/kubernetes imports
	k8s.io/client-go/kubernetes/typed/resource/v1alpha1 imports
	k8s.io/api/resource/v1alpha1: module k8s.io/api@latest found (v0.29.2), but does not contain package k8s.io/api/resource/v1alpha1


fix(controller): fix cnr residue when node deletion

What type of PR is this?

Bug fixes
What this PR does / why we need it:
When a Node is deleted, there may be remaining CNR (CustomNodeResource) objects without labels in cluster. This is because when a node is deleted, katalyst-agent creates a new CNR without labels, and the katalyst-controller is unable to GET the deleted node for patching labels.
Additionally, during the periodic cleaning process in katalyst-controller, it lists CNRs with labels based on the NodeSelector from Informer initialization, excluding the CNR without labels created katalyst-agent. This causes the CNR to be unable to be cleaned up.
# Residual CNR without lables
apiVersion: node.katalyst.kubewharf.io/v1alpha1
kind: CustomNodeResource
metadata:
  name: <IP_ADDRESS>
spec: {}
status:
  topologyPolicy: SingleNUMANodeContainerLevel
  topologyZone:
     ...

This PR attempts to list all CNRs from the kube-apiserver during the periodic cleaning process, instead of using cnrLister with a NodeSelector.
Which issue(s) this PR fixes:
Special notes for your reviewer:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jiangchenxi.530 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

maybe it's better to do this by add the same label in reporter rather than trigger list request periodically cc @caohe @luomingmeng

@waynepeking348 Sorry for the late reply. The method you mentioned indeed has better performance. I will submit the PR later.

@waynepeking348 @caohe PTAL

add --label-selector to the agent startup parameter, which controls the default labels of CNR created by agent. User needs to ensure that this parameter is consistent with the --label-selector for controller. For example, use the same value in Charts values.yaml to render the label-selector for both agent and controller.
merge labels instead of overriding it with node lables when controller periodic sync CNR.


Make animation optional

Feature request: Just as you can dismiss a popover without animation on iOS using dismiss(animated:completion:), it would be useful to hide the MAUI Popover without animation. (In my use case, I want to immediately navigate to another page.)

Hi @breyed,
I have implemented optional animations in the latest release.

The update in version 5.1.0 doesn’t work. In a response to a Command from a view on the popover, my code essentially does this:
popover.IsAnimated = false;
popover.Hide();
page.Navigation.PushModalAsync(navigationPage)

The popover still animates before the modal push animation begins. Tested on iOS 17.5.

Hi @breyed,
I made a dumb mistake in the iOS handler. I published a fix.

In 5.1.1 IsAnimated = false works on iOS. However, on Android 14, it still animates.

Hi,
on Android, it does not work only if you change the IsAnimated property while the popover is open. Popover is implemented using PopupWindow on Android. I do not know why, but changing AnimationStyle of PopupWindow while the window is open does not have any effect (the change is only reflected the next time it is opened). If you change the property before you open the popover, it works as expected:
https://github.com/user-attachments/assets/7ff79cf3-0ea0-413d-b5b5-64cfd225d569

Perhaps you need to call update for the new animation style to take effect.

Hi @breyed,
thank you for the tip about the update() method. I implemented it and published a new version. However, I could not make it working in a situation when the Hide() method is called right after IsAnimated is changed. You have to wait a bit for the new animation style to take effect, for example using Task.Delay(), although this is far from a perfect solution:
popover.IsAnimated = false;
await Task.Delay(10);
popover.Hide();


Evaluation code

Hi, @ltkong218,
Thanks for your exciting work, do you have any plan to release the evaluation code of MPI-Sitel training and KITTI?

I will release the train and evaluation code of FastFlowNet with a future paper. For emergency, you can refer to PWC-Net (CVPR 2018, Caffe), RAFT (ECCV 2020, PyTorch), UFlow (ECCV 2020, Tensorflow) and so on.


Send initialize to new instances by default

An issue I've hit when porting code from Pharo to Dolphin is that Pharo implements Behavior>>new as
^ self basicNew initialize

Dolphin on the other hand does what I think most other Smalltalk implementations do and just returns the new instance with no initialization (the same as basicNew).
This is something that has appeared wrong to me ever since I started using Smalltalk. If I'm subclassing an existing class and implement initialize in my new class I have to check through the parent hierarchy to see if any of the superclasses also implement initialize and therefore have added
new
	^super new initialize

If they have, I don't do anything else. If they haven't, I add it. In addition to being a (slightly) annoying additional step this is a point of brittleness since if a superclass adds/removes their initialize and new implementations this can break my subclass.
On this occcasion I think Pharo has taken the right approach and would like to suggest that Dolphin considers doing the same.
In support I'll quote the comment for new in the instantiator and Object class protocols in the Draft ANSI spec:

Return a newly created object initialized to a standard initial state.

(I'll admit it's unclear if the "standard initial state" is a general one or specific to the implementing class - possibly the final spec clarifies this?)

Having had the experience of trying to move a lot of code out of one of those traditional Smalltalk systems into Pharo, that decision is a major compatibility headache. It is a problem in either direction, but running code that is not expecting the initialize is more problematic than the direct failures one sees from not running the initialize. Double-initialization can create all sorts of subtle issues that generally don't show up immediately. Based on that reason alone I don't intend to change it, sorry.
I'm afraid the ANSI standard doesn't support the argument "for" either, since since the initialize method is not part of the spec, and the implementation of methods in the spec are not supposed to call methods not in the spec because it creates a fragile subclassing problem.  The words in the spec are referring to the general initialization to the standard initial state of nils or zeros.
Of course that can all be taken with a pinch of salt since there are so many pre-existing cases of the fragile subclassing problem that none of the existing implementations could comply without breaking everything. The standard was really in need of a V2 to iron out the issues in the first version. My favourite (though much smaller) issue is that DateAndTime instances are supposed to be able to tell you the name of the timezone in which they are specifying a point of time, which is impossible since they only know the offset from UTC, and one can't determine a unique timezone from that.

No problem; I prefer the Pharo approach but appreciate the counter-viewpoint and experience.
I now run a script after porting code to pick up any classes implementing an initialize that won't be sent and add a corresponding new implementation, so it's a manageable issue.
Thanks for the explanation.


Dynamic data background color not rendering

Expected Behavior
Data in the graph should show background colors with a prepopulated backgroundColor[]
Current Behavior
In horizontal bar graph, when values are fetched after response from an API, sometimes the data on Graph doesn't show up background color even though the backgroundColor array is initialized with enough background color values and there is a value associated with each key in the data response.
Issue:

Environment

Chart.js version: 2.5.0
All browsers

Try it after updating to 2.9 version

Closing due to missing test case


Vectorized sampling (WIP)

for now, vectorized sampling only works for discrete nets

Hello @jrzkaminski! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file bamt/external/pyitlib/DiscreteRandomVariableUtils.py:

Line 161:13: W503 line break before binary operator
Line 168:13: W503 line break before binary operator
Line 175:13: W503 line break before binary operator
Line 490:13: W503 line break before binary operator
Line 491:13: W503 line break before binary operator
Line 492:13: W503 line break before binary operator
Line 705:17: W503 line break before binary operator
Line 706:17: W503 line break before binary operator
Line 730:13: W503 line break before binary operator
Line 731:13: W503 line break before binary operator
Line 732:13: W503 line break before binary operator
Line 768:17: W503 line break before binary operator
Line 770:21: W503 line break before binary operator

Codecov Report
Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (9537cd2) 65.44% compared to head (ed82b40) 64.07%.

Files
Patch %
Lines

bamt/networks/base.py
7.27%
51 Missing :warning:

bamt/nodes/discrete_node.py
15.78%
16 Missing :warning:

bamt/log.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   65.44%   64.07%   -1.38%
==========================================
  Files          42       42
  Lines        2903     2976      +73
==========================================
+ Hits         1900     1907       +7
- Misses       1003     1069      +66

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BrokenLinksH2] fixing broken image

Global effort to fix broken links
@jswymer
The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only link fixes and does not change other content. Please review within five business days and merge, or comment in the PR with any changes you'd like to see. Thanks!

Docs Build status updates of commit 0506be8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

dynamics-nav/how-to-view-synchronization-job-queue-status.md
:warning:Warning

Details

dynamics-nav/how-to-view-synchronization-job-queue-status.md

Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'Synchronizing Dynamics NAV and Dynamics 365 for Sales - Dynamics NAV' is duplicated in: 'how-to-view-synchronization-job-queue-status.md(2,8), Scheduled-Synchronization-Using-the-Synchronization-Job-Queue-Entries.md(2,8)'. Titles must be unique within a docset.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2e84df5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav/how-to-view-synchronization-job-queue-status.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


⚠ SceneTime has degraded performance

In c818c64, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1759 ms

Resolved: SceneTime performance has improved in 7a883b9 after 7 minutes.


Update README.md

Some grammar and copyright year

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


joelx.com does not meet quality requirements

Browsing The Small Web, I was served this: https://joelx.com/dead-children/18136/
Not sure how that meets anywhere near the quality criteria for the site. It's just grotesque.

I can understand how you can find this grotesque. I can also understand there may be other people would not. In general we do not review the 'flavor' the content unless it is NSFW (which is in the guidelines).
Small web is thousands of humans and some of them may be very different than you and have different views of the world than you, like in the real world.

I don't really understand it. The lack of consistently not-right wing content in the list is inconsistent with a curated snapshot of the small web free of bias. Please feel free to close this -- I will find a new list.


No module named 'GP_cuda'

Thanks for your great work!
When i try to implement the code, i came across the error:
"ModuleNotFoundError: No module named 'GP_cuda'"
File "/apro/gp_cuda/gp_process/GP.py", line 6, in
import GP_cuda as _C
Are there some files missing ? or the enviroment i have installed is not correct ?
Looking forward your kindly reply.

Hi, @zwyang6
It seems that you didn't compile the op or didn't compile the op successfully.
cd apro/gp_cuda
python setup.py build develop


Dang 0.2 is slow!

An example is generated for every line of every file, perhaps just create one example per file.

Determined that specs2 report generation was slow, perf tested and sent suggestions to etorreborre, who included them in 1.8.2


Container Apps created with Consumption Workload Profile fails to execute.

:heavy_exclamation_mark: This is an active incident in Azure Container Apps for customers using Consumption Workload Profile

Issue Description
We have received multiple reports of Container Apps created in Consumption Workload Profile failing to execute. Our preliminary investigation points to a system component handling scheduling to be in a non-functional state. We have taken temporary mitigation steps to address the issue, while continuing to investigate the full root cause.
Next update will be provided in 2 hours @ [2023-08-03 17:20 UTC]

Update @ 2023-08-03 17:40 UTC
Investigation is still in progress.

Update @2023-08-04 17:52 UTC
We have made progress in our investigation and now understand the trigger for the issue. We also engaged Azure Communications to provide updates via official update channel to provide regular updates to impacted subscriptions. Issue continues to stay mitigated.

Update @2023-08-07 17:46 UTC
Root cause understood and fix roll out complete.


Format for specifying custom topology file?

Is there any documentation available for how to specify a custom topology for SCCL?  (--topology-file)?
Thanks

If you wish to define a custom topology, you may follow one of the examples in here.


feat: Add Tool.from_component

DO NOT MERGE - just a draft for now

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 83.588%

Totals

Change from base Build<PHONE_NUMBER>4:
0.4%

Covered Lines:
2134

Relevant Lines:
2553

💛  - Coveralls

Thanks for the effort you are putting into this PR.
I do have some questions and suggestions.
The requirement was to support components with basic str or native Python types as input. This implementation appears to go beyond that, which is great for flexibility but might become hard to maintain.

What's the advantage of supporting Pydantic models here? Maybe I am just missing some reasonable use cases...

The TypeAdapter from pydantic takes care of range of json to object conversion be these objects strings or other native Python types, dataclasses or Pydantic objects.
It is in fact, harder and longer codebase to implement a version of Tool.from_component that only supports strings, native Python types and their lists as we need to detect cases we don't support, raise errors and so on.
TypeAdapter.validate_python takes conversion of all of these. Unit and integration tests for dataclasses and Pydantic models I included to showcase how this is indeed possible with almost no code. We even support our own Document class as show in test examples.
Given these newfound benefits of TypeAdapter which enable proper conversion support with 10 lines of well tested pydantic code - I went for that solution although it was not required by the requirements.

As I commented in the PR, if I remember correctly, one of the initial requirements was to enable the deserialization of Tools from YAML, which would be feasible if Tools are treated as components. Is it possible? If yes, can we add some tests to cover this?

Yes, I need to review this part as well.

Given the main goal of this PR, would it make sense to involve someone from the DC team in the review?
Yes, @mathislucka is on PTO and he had the most context. Let's wait for him


can't use combine text to set a lora name string widget.

Thanks @spiraloid - taking a look!
It looks like the issue may be that the input type for lora_name is an item from a list..
Here's how it's defined in the class:
    @classmethod
    def INPUT_TYPES(s):
        return {"required": { "model": ("MODEL",),
                              "clip": ("CLIP", ),
                              "lora_name": (folder_paths.get_filename_list("loras"), ),
                              "strength_model": ("FLOAT", {"default": 1.0, "min": -100.0, "max": 100.0, "step": 0.01}),
                              "strength_clip": ("FLOAT", {"default": 1.0, "min": -100.0, "max": 100.0, "step": 0.01}),
                              }}

I'll have to dig around and see if I can figure out what type of value it takes.
Workin on it! :)

Okay, I've just pushed a new node that will convert a string to a combo input type..

Can you pull the latest and give it a try?
Thanks! :)

awwww yeah


Bound term variable not found

I'm working on a minimal F* repro for #1156 and while cobbling together bits and pieces from other files, F* suddenly told me to report a bug:
module GH1156

// FStar.TSet

open FStar.TSet
module TS = FStar.TSet

// FStar.Preorder

type relation (a:Type) = a -> a -> Type0

type predicate (a:Type) = a -> Type0

let preorder_rel (#a:Type) (rel:relation a) =
  (forall (x:a). rel x x) /\ (forall (x:a) (y:a) (z:a). (rel x y /\ rel y z) ==> rel x z)

type preorder (a:Type) = rel:relation a{preorder_rel rel}

// Fstar.Ghost

let erased a = a
let reveal #a x = x

// FStar.Monotonic.Heap

let tset = TSet.set

private noeq type heap_rec = {
  next_addr: nat;
    memory   : nat -> Tot (option (a:Type0 & rel:(option (preorder a)) & a))
    }

let heap = h:heap_rec{(forall (n:nat). n >= h.next_addr ==> None? (h.memory n))}

private noeq type mref' (a:Type0) (rel:preorder a) :Type0 = {
  addr: nat;
    init: erased a;
      mm: erased bool;  //manually managed flag
      }

let mref a rel = mref' a rel

let contains #a #rel h r =
  let _ = () in
    Some? (h.memory r.addr) /\
      (let Some (| a1, pre_opt, _ |) = h.memory r.addr in
         a == a1 /\ Some? pre_opt /\ Some?.v pre_opt === rel)

throws
[...]
[F* info] Z3 says: unsat [6 times]
[F* error] Unexpected error; please file a bug report, ideally with a minimized version of the source program that triggered the error.
[F* error] Failure("Bound term variable not found (after unmangling): uu___#220502 in environment: contains,
[...]

(in Emacs interactive mode).

This is probably another example of #1091.

@aseemr: you've fixed a bunch of similar issues like this recently. Any ideas about this one?

This is indeed another example of #1091.


Improve the sub-items system

Is your feature request related to a problem? If so, please describe.
The sub-items system is not aesthatically pleasing/convenient
Describe the solution you'd like
I think that sub-items that are aesthatically pleasing would be a nice addition to Dashy.
Instead of splitting the the space equally among the sub-items, it would be better to add them as small icons (max of 3).
This would be great to reference a wiki, an ftp server to download the source code etc...
Here is an illustration of an example:

First icon (Lock) => calls the password from a password manager
Second Icon (Arrow) => Download the content of the docker
Third Icon (Book) => Documentaiton
Priority
Medium (Would be very useful)
Is this something you would be keen to implement
Maybe

Am still open to suggestions, if you're able to share the code you wrote to generate the above, I can look into implementing it as an option in the future.


[Показати на мапі] The show 'all cities' option is not implemented in the dropdown list

Environment: Windows 10, Google Chrome, 88.0.4324.182, (64-bit).
Reproducible: always
Build found: last commit from https://speak-ukrainian.org.ua/dev/service
Steps to reproduce

Go to 'https://speak-ukrainian.org.ua/dev/service'
Click on 'Show on map'
Look at the dropdown with cities

Actual result
The show 'all cities' option is not implemented in the dropdown list.

Expected result
The show 'all cities' option should be implemented in the dropdown list.

User story and test case links
User story #116
Labels to be added
"Bug", Priority ("medium"), Severity ("major"), Type ("Functional").

bug is fixed


Fix addLuaScript script adding twice

simple one line change that I think should fix

yippee

shadowmario fixed this in a recent push, so yeah this pr is useless now


Sarvesh/mosa 85 make stake request iterable

Created Library contract for address array
Adding staker address in requestStake method
Removing staker address in revertStakeRequest, rejectStakeRequest, processStaking and revertStaking from array
Create a function to return length of array
Test cases to support above changes

For the data to be iterable we don't need this machinery.
I don't understand why the library functions have view as visibility.  There are other remarks to be made, but we should first align what the requirements are.

@benjaminbollen  Thanks for the feedback. Let's discuss this in the call.


Forceful unwrapping of bytes in NIOCore

Actual behavior
The App can be crashed because of using forceful unwrapping of optional value.
Steps to reproduce
While creating a buffer, forceful unwrapping is done that is causing a crash.
static func _allocateAndPrepareRawMemory(bytes: _Capacity, allocator: Allocator) -> UnsafeMutableRawPointer {
        let ptr = allocator.malloc(size_t(bytes))! // forceful unwrapping

        /* bind the memory so we can assume it elsewhere to be bound to UInt8 */
        ptr.bindMemory(to: UInt8.self, capacity: Int(bytes))
        return ptr
    }

Is there any possible reason behind forcefully unwrapping it.
From what i know, forceful unwrapping is not a good approach to handle as it might cause app crash.
Kindly let me know the inputs.

We force-unwrap on malloc failure because there is no recovery. Swift does not support running in environments where malloc might fail, and we inherit that restriction. There is no point continuing in this case.


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Codecov Report

Merging #554 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #554   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          29     29
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9cd5b5...5b1f9d3. Read the comment docs.

Coverage remained the same at 97.619% when pulling 5b1f9d3afaea4d4ce7b59c0cb1db2e703b1195f1 on template-sync-1 into a9cd5b52ec9f27229b9d3cab457de0a6b2212e83 on master.


Set timeago update interval to 10 secs. Closes #615.

We still need to fix usage in under DemocracyOS/side-comments


Consider renaming iostreamer module

(cc @geek-yang ) As @Peter9192  suggested, the module iostreamer can be renamed so it is more clear. I am thinking about something like data_io, model_io, model_setup, ... Please add your suggestions.

Something with config in it? Or data handling?
io_config
io_utils
config/io
utils.io
data_handling
directory_config
For reference, this is what the module currently does:

read_config: Load paths from config file and save them into dict.
create_io_dir: Create input directory and copy required files.
(_copy_data: Copy required data to the work directory.)
(_update_config_file: Update config file for each station.)

I think config_io is good and very related to what it does.


ZCU 104 litex_server connection issue

Hi,
I am having some issues with the litex_server connection on the ZCU 104 board. I am using the latest prebuilt image posted here and I was having the same connection issues discussed in #74.
As per previous discussions on issue #74, I have recompiled the Etherbone server with gcc-aarch64-linux-gnu and the debug option on. I can see that now the make srv command works and sends and receive some data. However, as I try the leds.py test, it fails.
The output during the test looks something like below:
Before running the test (only the server running),
host:
make srv
litex_server --udp --udp-ip <IP_ADDRESS> --udp-port 1234
[CommUDP] ip: <IP_ADDRESS> / port: 1234 / tcp port: 1234

zcu104:
Received 12 byte packet
4e 6f 11 44 00 00 00 00
00 00 00 00
Sending 8 byte response
4e 6f 16 44 00 00 00 00

After running the test:
host (terminal 1):
python leds.py
Using generated target files in: ../../build/zcu104
Didn't get a reponse from the board. Check connection?

host (terminal 2)
litex_server --udp --udp-ip <IP_ADDRESS> --udp-port 1234
[CommUDP] ip: <IP_ADDRESS> / port: 1234 / tcp port: 1234
Connected with <IP_ADDRESS>:58214
Disconnect
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/home/abc/rowhammer-tester/third_party/litex/litex/tools/litex_server.py", line 153, in _serve_thread
    reads += self.comm.read(addr, length, burst)
  File "/home/abc/rowhammer-tester/third_party/litex/litex/tools/remote/comm_udp.py", line 127, in read
    raise socket.timeout
socket.timeout

ZCU104:
Received 12 byte packet
4e 6f 11 44 00 00 00 00
00 00 00 00
Sending 8 byte response
4e 6f 16 44 00 00 00 00
Received 12 byte packet
4e 6f 11 44 00 00 00 00
00 00 00 00
Sending 8 byte response
4e 6f 16 44 00 00 00 00
Received 20 byte packet
4e 6f 10 44 00 00 00 00
00 0f 00 01 00 00 00 01
f0 00 58 00
0xf0005800 => 0x00000052
Sending 20 byte response
4e 6f 14 44 00 00 00 00
00 0f 01 00 01 00 00 00
00 00 00 52
Received 20 byte packet
4e 6f 10 44 00 00 00 00
00 0f 00 01 00 00 00 02
f0 00 58 00
0xf0005800 => 0x00000052
Sending 20 byte response
4e 6f 14 44 00 00 00 00
00 0f 01 00 02 00 00 00
00 00 00 52
Received 20 byte packet
4e 6f 10 44 00 00 00 00
00 0f 00 01 00 00 00 03
f0 00 58 00
0xf0005800 => 0x00000052
Sending 20 byte response
4e 6f 14 44 00 00 00 00
00 0f 01 00 03 00 00 00
00 00 00 52
Received 20 byte packet
4e 6f 10 44 00 00 00 00
00 0f 00 01 00 00 00 04
f0 00 58 00

....
Any suggestion why this might happen? Is there any updated ZCU 104 image that have the fixed Etherbone server? Thanks 🙏

Hi @tanvirarafin
Turns out, endianness of the base_ret_addr was being swapped, when it shouldn't. That is, we didn't convert it from network to host, but we still converted it from host to network.
This caused the issue with changes from https://github.com/enjoy-digital/litex/pull/1504. As reply ID didn't match, the packets were being dropped and no response were being received.
We will release a new prebuilt image for the ZCU104 soon.
Until then, you can rebuild the server with the following patch https://github.com/antmicro/rowhammer-tester/pull/166/commits/f061c80100130aeb828b7dd8b7b924abfe5ff50b and replace the one on the SD card under /bin/zcu104_etherbone.
If you want to replace it via the SSH, you may need to first killall zcu104_etherbone to stop the server currently running, then do the scp and then reboot the ZCU104.
As there was a bug introduced during recent cleanup with the US(+) FPGAs, you may need to wait for https://github.com/antmicro/rowhammer-tester/pull/166 to be merged if you want to build and use a new bitstream.

It's working now :).


Add audio streaming support with WebRTC and Opus

Awesome!! I can merge it first. Can think about optimizing audioChannel sending later.

@sergystepanov I deployed on FRA. You can check your audio result over internet :D


compiler crashes inside checkTypeRelatedTo after attempting to elaborate errors

interface Container<T> {
    m1: Container<T[]>;
    m2: T;
}
declare function foo(x: () => Container<number[]>): void;
let a: Container<string[]>;
foo(() => a);

TypeError: Cannot read property 'code' of undefined
    at Object.createDiagnosticForNodeFromMessageChain (C:\Sources\TypeScript\built\local\tsc.js:4438:31)
    at checkTypeRelatedTo (C:\Sources\TypeScript\built\local\tsc.js:18365:36)
    at checkApplicableSignature (C:\Sources\TypeScript\built\local\tsc.js:21845:26)
    at resolveCall (C:\Sources\TypeScript\built\local\tsc.js:22226:17)
    at resolveCallExpression (C:\Sources\TypeScript\built\local\tsc.js:22386:20)
    at getResolvedSignature (C:\Sources\TypeScript\built\local\tsc.js:22516:47)
    at checkCallExpression (C:\Sources\TypeScript\built\local\tsc.js:22541:29)
    at checkExpressionWorker (C:\Sources\TypeScript\built\local\tsc.js:23602:28)
    at checkExpression (C:\Sources\TypeScript\built\local\tsc.js:23547:42)
    at checkExpressionStatement (C:\Sources\TypeScript\built\local\tsc.js:25118:13)

The problem is that the initial run of isRelatedTo correctly finds the top-level error '() => Container<string[]>' is not assignable to '() => Container<number[]>', but when isRelatedTo is re-run with reportErrors: true, it fails to find an error, setting errorInfo to undefined, which causes createDiagnosticMessageChains to crash.
So far I've found that isRelatedTo correctly identifies the type parameters number[] and string[] as not assignable, but then objectTypeRelatedTo says that Container either is or might be assignable to Container, which then sets errorInfo to undefined.
The error doesn't manifest with () => Container<number> vs <string>, so I need to compare its behaviour in objectTypeRelatedTo.


Make benchmarks results easier to read

Make the benchmarks results easier to read by only showing ops/sec
Remove the devnull dependency in favor of console.log
Update benchmarks/README.md with fresh data

Coverage remained the same at 100.0% when pulling 8938f1fffa891038a013531497d3e33e4f21854f on benchmarks into e2c2248596161ba5005b7bdd93da58a0e9a4709b on master.

Coverage remained the same at 100.0% when pulling 8938f1fffa891038a013531497d3e33e4f21854f on benchmarks into e2c2248596161ba5005b7bdd93da58a0e9a4709b on master.

@3rd-Eden I merge this. Revert it if you don't like it.


fix typo - level 10 data generation

Summary
fix a typo in the level-up 10 data generation document

How to test

Checklist

[ ] I have added unit tests to cover my changes.
[ ] I have added integration tests to cover my changes.
[ ] I have added the description of my changes into CHANGELOG.
[ ] I have updated the documentation accordingly

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below).

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Codecov Report
Patch coverage has no change and project coverage change: -0.02 :warning:

Comparison is base (c5911ea) 78.70% compared to head (1c53991) 78.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #975      +/-   ##
===========================================
- Coverage    78.70%   78.69%   -0.02%
===========================================
  Files          231      231
  Lines        26420    26420
  Branches      5258     5258
===========================================
- Hits         20795    20790       -5
- Misses        4400     4402       +2
- Partials      1225     1228       +3

Flag
Coverage Δ

macos-11_Python-3.8
?

ubuntu-20.04_Python-3.8
78.69% <ø> (ø)

windows-2019_Python-3.8
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Friend list and discord Settings

T1 Issue report:
For whatever reason, I feel like it's broken, idk why

T1 version:
0.8
Discord client:
PTB
Platform:
Windows
Discord Mod:
BetterDiscord
Additional notes:
No response

Yeah, sometimes when Discord makes an update it can break parts of the theme.
Usually I fix these issues only once they occur on stable.
Otherwise, I'd have to maintain 3 different versions of the theme and deal with some other issues.
I recommend using the stable client to avoid stuff like that.
It may still break for a moment, but I usually try to fix major stuff within a day.
On Canary or PTB it may be broken for longer periods as I wait for the update to hit stable.
Thanks for letting me know about the issue tho. I got a fix ready to go.
Sorry for the inconvenience.

Yeah, sometimes when Discord makes an update it can break parts of the theme.
Usually I fix these issues only once they occur on stable. Otherwise, I'd have to maintain 3 different versions of the theme and deal with some other issues.
I recommend using the stable client to avoid stuff like that.
It may still break for a moment, but I usually try to fix major stuff within a day. On Canary or PTB it may be broken for longer periods as I wait for the update to hit stable.
Thanks for letting me know about the issue tho. I got a fix ready to go. Sorry for the inconvenience.

The issue has now happened on stable, it's probably time to push the update...

Yup, should be fixed now.

Yup, should be fixed now.

thx


vernemq version is returning empty string

This is due to vernemq itself not setting this. This was fixed in https://github.com/vernemq/vernemq/pull/1193 and thus the docker images for 1.9.0 will correctly display the version number.


Incorrect format specifiers

https://github.com/awegrzyn/influxdb-cxx/blob/0bb9a05e4205a788517a7c27790c8e6f50a5575f/src/InfluxDB.cxx#L107
I believe the format specifiers that are used with std::get_time are actually only valid with std::strftime. I'm unable to find concrete documentation to prove that strftime() and strptime() don't share all the specifiers in format string. However, I can illustrate the difference through an example:
$ cat sample.cpp
#include <sstream>
#include <iostream>
#include <chrono>
#include <ctime>
#include <iomanip>

int main(int argc, char** argv)
{
    std::stringstream ss("2020-03-18T09:11:25Z");

    std::cout << ss.str() << "\n";
    std::tm tm = {};

    #ifdef __FIX__
    ss >> std::get_time(&tm, "%Y-%m-%dT%H:%M:%SZ");
    #else
    ss >> std::get_time(&tm, "%FT%TZ");
    #endif

    tm.tm_isdst = -1;
    auto tstamp = std::chrono::system_clock::from_time_t(std::mktime(&tm));
    auto t = std::chrono::system_clock::to_time_t(tstamp);
    std::cout << "Timestamp: " << std::ctime(&t) << "\n";

    return 0;
}

$ g++8 -g -std=c++17 sample.cpp -o sample
$ ./sample
2020-03-18T09:11:25Z
Timestamp: Wed Dec 31 18:59:59 1969

$ g++8 -g -std=c++17 -D __FIX__ sample.cpp -o sample
$ ./sample
2020-03-18T09:11:25Z
Timestamp: Wed Mar 18 09:11:25 2020

$ uname -a
FreeBSD ftlvssarkFreeBSD 11.1-RELEASE FreeBSD 11.1-RELEASE #0 r321309: Fri Jul 21 02:08:28 UTC 2017     root@releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

Another issue here is that std::get_time doesn't set tm::is_dst, so I think we need to set it explicitly to -1, otherwise it remains at 0 and then std::mktime interprets that as if DST is in effect.

Hi,
Indeed you are right and thanks for providing fix. I opened a PR with timestamp check and it failed: https://github.com/awegrzyn/influxdb-cxx/pull/68/files
I'll definitely add this fix this week!

It works, thanks you !


Add EnvSettings.SetNamespace method

I would like to be able to set the namespace for install/upgrade/etc actions programmatically (that is, not via CLI options) in my code that uses Helm's Go API (including the cli package for some CLI options and for action configuration).
At the moment, the workaround I found is to pass the desired namespace to action.Configuration.Init like so, but I believe being able to set namespace on EnvSettings would be the proper way.

I was wrong, using the workaround I mentioned does not work – if actual templates do not set metadata.namespace they're deployed into default namespace, while the release record is put into the custom namespace.

have you had a chance to look at https://github.com/helm/helm/pull/7373?

Hmm. So if I set it on the client and not set it on the EnvSettings it would work?.. 🤔


number of uploaded pics in header

there is number of loaded images (minus number of deleted images) in the header of app; there should be number of total uploads to commons; in idle case there should be number of loaded pics/number of total uploads (= 500/1234)

https://tools.wmflabs.org/urbanecmbot/uploadsbyuser/uploadsbyuser.py?user=Jagro
Thanks to Martin Urbanec!

@HonzaG : Very useful script, and faster than anything we could develop!
Off-topic, would you happen to know any script that gives the numbers we are looking for at #85? Thanks a lot :-)


Features: Add binding to get the creation timestamp of an image or a …

…snapshot
Add the following functions:
func (image *Image) GetCreateTimestamp() (timestamp time.Time, err error)
func (image *Image) GetSnapCreationTime(snap_name string) (timestamp time.Time, err error)
and also a helper function:
func (image *Image) GetSnapId(snap_name string) (uint64_t snapId, err error)
I am currently writing a grpc/http api that needs to have access to those, and i though i would share :)

@fflorens could you please add a unit test?

I've added unit tests,
At the same time I modified the name of the function to keep consistency in the name.
Also added checks for the case where the image is not opened

Any news ?

Up ? need too !

@fflorens  Hi, thank you for your contributions to this project. This project had gone stale for a while and some of us are new contributors trying to update it and actively contribute. However, because we are not always familiar with the context of changes that were started a while ago before we were involved I'd like to ask you to update this PR with your current status and if you feel you would still like us to review it anew. If we do not hear from you in a few weeks we will probably close the PR as stale in order to lower our backlog. Thanks again!


[DATE-FORMAT] Regarding displaying dates and default values

Name

D&D (Harptos)

Type

[X] Existing date format - (it's in the list already, but you want to edit something about it)

Request
Hello, firstly, great plugin (and I hope 'wizzard' is a reference to everybody's favourite member of UU).
I've just started using it, and Obsidian in general, so please excuse me if something is incorrect or I've assumed something that's stupid.

Is it possible to only display those portions of a date which are defined?

For example, I add a date of -848-01-01 (expecting -848DR, Hammer, 1st) and I get 'date missing' in the Timeline view.
If I add '-848' on its own, it correctly renders as a date, but sets the default values of '01 Hammer -848D.R. 01:01'
Is there a happy medium here? Some of my entries I want to be just a year, some a year and a month, some a year-month-day, and some more granular, but I'd like them to show on the same timeline.

Hey @dubiousgit thank you for your interest in the plugin
Mind sharing a reproduction case zip file ? Or some screenshots of your settings ?
Thanks in advance

Basically it looks like there are some default assumptions if just a year is added, where it populates the rest of the values with default values.
There's also a bug(?) where adding a month and day returns a failure to render.
So I suppose:

Is this a bug, should it always render irrespective of the date granularity created?
Can we have it not render the 'default' values in some way? (I.e. I'd like the timeline to not have 01:01 for every date in a given year, just because I've not been granular in the date designation.

Well it for sure isn't a bug hehe, it was just designed this way
But it would be a cool enhancement
The capture regex expects every member to be there, But I might be able to make it more lax
When it comes to skipping values that are unset I'm not quite sure how I could get around to achieving that for now
I'll look into it but no promises

I'll look into it but no promises

Understandable and I wouldn't expect it just because I asked.
I've been using it a bit more in anger over the last few days, and there are some other things that it would be nice to have. I will try and sort them into 'probably fits with the extension' and 'probably an enhancement, but separate extension' when I have a minute.
I'd offer to help, but my FE experience is non-existent.


fix(PopoverMenu): fix opening external links

Details

Fixed Issues

$https://github.com/Expensify/App/issues/45417
PROPOSAL:
Tests
This bug is related to feature that is not yet in the app.
To check the external links functionality it's needed to change code in 1 button.
This code has to be added in PolicyAccountingPage (line 188)
onSelected: () => {
                    Link.openLink(getQuickBooksOnlineSetupLink(policyID), CONST.NEW_EXPENSIFY_URL);
                },

Check deatils on this branch.
Additionally it's needed to add file .env in the main directory with one line:
ENVIRONMENT=staging

Testing scenario:

Add code from above
Go to Settings -> Workspaces
Create a workspace, click More features and choose Accounting
Connect to Xero
It's needed to create an account there
After everything is set up click three dots
Choose Sync up
The changed code should be called and an external page should open

Other features connected to PopoverMenu that are worthy to check are:

Uploading and viewing avatar

Go to Settings
Click on the avatar
Click Upload photo
New photo should appear
Click on the avatar
Click View photo
The photo should appear on a modal

Deleting workspace

Go to Settings
Go to Workspace
Click three dots on a chosen workspace
Click Delete workspace
Workspace should disappear

Adding attachment to a message

Go to a chosen chat (report)
Click + next to input
Click Add attachments
Modal with files to attach should appear

Deleting tag/tax from workspace

Go to Settings
Go to Workspaces
Go to a chosen workspace
If neither tab Taxes nor Tags is not visible go to More features
Turn on Tags or Taxes
Go to proper tab
Add a new tag
Select this tag
Click the button above 1 selected
Click Delete tag and confirm in the next modal
Tag should disappear

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

The external links functionality can't be tested yet. We need to wait until it's placed in the app.
Rest of the tests same like above.
It would be great to test all features that are connected to PopoverMenu or ButtonWithDropDownMenu

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behaviour for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
External link
https://github.com/user-attachments/assets/bbfc5162-dea1-4d1c-ad6c-21d8bbe0edbd
Other functionalities connected to PopoverMenu
https://github.com/user-attachments/assets/6d74b1a6-9c03-4ad3-b961-1f9de23fbe14
https://github.com/user-attachments/assets/68f5f10f-5667-42c5-a6b3-2057126c573b
https://github.com/user-attachments/assets/2279d135-9f40-4a1f-ad9f-15e32cc2f44d

Android: mWeb Chrome
External link
https://github.com/user-attachments/assets/74c9bf5f-c75a-47fd-b027-ee3fbcba5036
Other functionalities connected to PopoverMenu
https://github.com/user-attachments/assets/7d197041-5056-4763-9641-7f59db082d61
https://github.com/user-attachments/assets/abd0f64d-0465-4a77-b6c2-133df3f8d69b
https://github.com/user-attachments/assets/4a4a56c8-a6cb-449b-918c-38bd0baa3240

iOS: Native
External link
https://github.com/user-attachments/assets/09f44b5a-7e36-4dd6-bb9e-513fec9c22dc
Other functionalities connected to PopoverMenu
https://github.com/user-attachments/assets/afdc10c0-343c-4626-a580-362f41d3475c
https://github.com/user-attachments/assets/4f508e9c-66b9-4ccb-b494-6eccf3717a29
https://github.com/user-attachments/assets/ea57b1fb-36d6-4447-942c-3aaf384f3df6
https://github.com/user-attachments/assets/af9a75e7-87fc-4a71-b881-273a58fdf5eb

iOS: mWeb Safari
External link
https://github.com/user-attachments/assets/af4fa0f1-cd3f-4a40-b845-d5863cc4293b
Other functionalities connected to PopoverMenu
https://github.com/user-attachments/assets/91a204a4-566a-473f-810f-20ff6ccd4d85
https://github.com/user-attachments/assets/5e47aad3-8e26-4ea0-bd48-57a4563ff63c
https://github.com/user-attachments/assets/5a94973e-95eb-47ba-85f9-8d0570286dc5

MacOS: Chrome / Safari
External link
https://github.com/user-attachments/assets/75dab54a-cd3e-4036-a6d8-f62030df426d
Other functionalities connected to PopoverMenu
https://github.com/user-attachments/assets/82a0492e-c9a3-4e4a-b8c9-6a5ada7e6238
https://github.com/user-attachments/assets/b3ff2e9c-e4f4-459a-a5be-d74c2be38ac8
https://github.com/user-attachments/assets/f003b32f-0e85-4a16-9e78-0470f3230492
https://github.com/user-attachments/assets/2c0b2b9a-e1af-4552-b526-11f27bf0af49

MacOS: Desktop
External link
https://github.com/user-attachments/assets/aab1f680-a8bb-4663-a9d1-f716bf888208
Other functionalities connected to PopoverMenu
https://github.com/user-attachments/assets/3b35810f-8d1d-47ce-9fff-45a0cf87f344
https://github.com/user-attachments/assets/a2227745-042f-4731-b920-445144702302
https://github.com/user-attachments/assets/3db4bed0-69a3-48d6-b83d-97fe82b505d1
https://github.com/user-attachments/assets/2bfd9845-44b5-4c2a-ae5e-dc98ed18811d

@shubham1206agra as I was testing, it wasn't possible to open an external link from PopoverMenu on mWeb iOS. Did you check this exact case? (with added code)

friendly bump @shubham1206agra 😊

Could you take a look @shubham1206agra? :)

How is it going @shubham1206agra?

@shubham1206agra
Oh yes, I know about this performance issue and have been looking into it for a while. 🧐
With @BrtqKr we tried different approaches to solve it (get rid of these additional 2 re-renders). We've tried to apply memoization and useCallbacks to the related functions/values, but nothing seemed to help.
We believe this is related to the fact that we're waiting for the modal to close, before proceeding with the following actions. This happens inside of the different scope(Modal.close() to be more precise), preventing batching of the updates, which is causing 2 extra re-renders in result.
The previous behaviour was not stable and because we have react forget enabled, this shouldn't be much of an issue. 😊

@shubham1206agra Android native video is missing in your checklist

We believe this is related to the fact that we're waiting for the modal to close, before proceeding with the following actions.

Sounds like we can't avoid this. Should we update the test to expect a slower time?

Sounds like we can't avoid this. Should we update the test to expect a slower time?

Yes exactly, it would be perfect!

Sounds like we can't avoid this. Should we update the test to expect a slower time?

@arosiclair yes exactly, it would be perfect!

Not sure how to update it. Asked about that here.

Android native video is missing in your checklist

@arosiclair Right now my android native build is not compiling.

Can you try fixing it? Start a thread in #expensify-open-source if you're having trouble.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.16-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

I see that there may be places where you miss wrapping in this Model.close(() => {...}, for example:
https://github.com/Expensify/App/blob/16f6c20088d91f7c709a307161ef82a926ddab93/src/pages/workspace/tags/WorkspaceTagsPage.tsx#L224

Update: seems like in this case it is not necessary since it works well 🤷 . When is it necessary to use Model.close(() => {...}?

@aldo-expensify
Since the action is now being called earlier in some cases, the modal (PopoverMenu) doesn't have enough time to close and remains as a parent of a new modal that is opened. Without Modal.close(() => ... wrapping the new modal is opened but with height = 0 and width = 0.
We need to add it in cases when another modal is opening, in the app it's mostly deleting, because of opening delete confirmation modal (ConfirmModal) or adding attachment/photo.

I believe this also caused the regression here

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.16-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Thread pool control without Akka

Previous version of NakadiClient allowed management of its thread pool in a java/spring-friendly way. The only configuration possible in the present version is via Akka configuration files, which is an undesirable dependency for applications that merely want to use the NakadiClient.

Hi @esroush
I'm coming to the project from the Scala background. I could see one structural problem arising - what exactly is the intended focus of the project? Scala, Java, or both? Currently it's a mix.
Architecturally, I'd like there to be a clear underneath core part, and a primary end user target. Any other adaptations can then be done (and tested) separately.
Do you know if there's currently a decision about such target focus? (i.e. can we go with Akka until ready, and collect any Java specific issues until that time)?

@akauppi I think there has been no stated focus in terms of Java or Scala. Rather, my understanding is that the underlying technology was changed in the most recent rewrite for development reasons.


rtv: drop package

Motivation for this change
https://github.com/michael-lazar/rtv
Development of this project has been abandoned since Jun 2019.
Actively developed fork of rtv has already been packaged as tuir.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Mention the replacement in the alias

Mention the replacement in the alias

Done, please take a look.


[Redshift] Show permissions in DDL generates double quotes in wrong place

System information:

DBeaver version 21.1.4

Connection details:

Database : Redshift
Cluster version: 1.0.28330
Driver name: RedshiftJDBC42-no-awssdk-<IP_ADDRESS>9 (managed by DBeaver)

Describe the problem you're observing:
Wrong group grants after obtaining the DDL of a redshift table with a particular grant over a redshift group. Steps:

Right Click on a table -> Generate SQL -> DDL
Settings -> Show permissions enabled
Wrong grant -> GRANT SELECT ON TABLE <table_name> TO "group <group_name>";

grant should be: GRANT SELECT ON TABLE <table_name> TO group "<group_name>";

Thanks for reporting this. We noticed the same. Did you also notice the security definer in procedure ddls are missing (it’s available in properties though), have you already file a bug for that?

Another wrong DDL is generated GRANT ALL ON TABLE public.users TO group "\""test group2\""";

Is that an existing, but different issue?--
SD

Fixed

Still not as expected, one quote just moved to the beginning of group keyword
 GRANT ALL ON TABLE public.sales TO "group \""test group2\""";

Fixed. Roles names are stored in quoted and escaped form.
Please test it in PostgreSQL as well.

Verified


Add advantage/Reduce advantage no more dynamic in 0.7.X

When using the advantages macros, they add/substract advantages point properly but the updated amount is not displayed in the HUD.
You need to deselect/select again the token to see the new value.

Marco should be :
/* Increases Advantage for the selected token by 0 */

await actor.update({"data.status.advantage.value" : Number(actor.data.data.status.advantage.value)+1});
canvas.hud.token.render();
ui.notifications.notify(`Advantage increased by 1 to ${actor.data.name}`)

This is updated now for FVTT 0.7, including for the Clear Advantage macro and world setting.


fix consistency in parameter names + some cleanup

not sure how we can enforce this later in CI.
there's a lot of rules we have that are currently not enforced by CI:

a file can only contain 1 function declaration
Psl\Foo\Bar\Baz\qux function must be declared in src/Psl/Foo/Bar/Baz/qux.php
function name must be in snake_case
argument name must be in snake_case
constant Psl\Foo\Bar\BAZ_QUX must be declared in src/Psl/Foo/Bar/constants.php
all classes should be declared either final or abstract ( unless its an exception )
interface names should end with Interface suffix
abstract classes should have the Abstract prefix
traits should end with Trait suffix
closure should always be declared static, even within functions, when $this is not used.
.... and more

Added the list to #30
I think there are at least some of them that we can tackle with cs


can you create examples for every extensions ?

Import the file and call it directly, and the extension type method can be used directly.


Refactor startReplica(c *cli.Context)

I've selected *startReplica(c cli.Context) for refactoring, which is a unit of 165 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍
Here's the gist of this guideline:

Definition 📖
Limit the length of code units to 15 lines of code.
Why❓
Small units are easier to analyse, test and reuse.
How 🔧
When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲  next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! :shipit: :sparkles: :100:

I will take this up.


cache: random pick region from cache.

The old way relies on the randomness of map iteration, which is not guaranteed always works correctly.
cc @siddontang @nolouch @overvenus

LGTM

Ping @disksing

PTAL @siddontang


Archiving web design

I am trying to archive websites for their design characteristics, my goal is to have a copy containing every asset in order to replicate exactly the graphic characteristics of a page (CSS, fonts, images…). I am wondering if ArchiveBox is the tool I need.
After a first tests, issues appear for fonts and ajax calls (or image lazy loading): When I try to archive this web page for instance with all archive methods selected, none of the result fits to my goal. The fonts seams to be downloaded for singlefile only and the images appears to be not downloaded at all, in fact, they keep their original URL. Do you have any tips for me to archive this kind of page?
Other website causing similar issues

http://www.guydecointet.org
http://edwardthomson.net/
http://www.dougkoellmer.com/

Thank you for your answer @pirate!


chore: move to provide object literal

I used the "provided object literal" to define this new syntax. We were using it already and I agreed with it.
I removed two examples from dependency injection and touched Dart prose and one of the files so please @chalin or @kwalrath confirm that I didn't break it.
Removing two examples the numbers jump from example 1 to example 3a, but that is just internal. I can fix the numbers if needed.

Seems like I left some behind, working on that.

I took a quick look; @chalin will take a closer one.

@Foxandxss : let me know once this is ready for review.

I definitely broke the Dart part, but @chalin will fix it when this hit master.

Also changed a blue box where it explains differences from Dart to Typescript in regard of provide. I changed the prose there, but feel free to change it too.

Proceeding with the agreement that @chalin will fix what we broke in Dart at his convenience.


Set up GitHub source links for debug support

This sets up links to GitHub source in the symbols files. Devs can then step through source in debug sessions. Source code is downloaded on the fly as needed.
Issue #474

NOW you should find only package projects with SourceLink, and no version updates. (The updates were not intended. I think someone else had updated them, and I had not merged with latest.)

I don't plan to use parameter SourceLinkCreate=true since it is true by default. I expect SourceLinkCreate=false would be useful for suppressing SourceLink execution.

Hmm, ok, 'cause I was reading this section which says:

You can control when it runs by setting the MSBuild property /p:SourceLinkCreate=true. That property is set to true by default on build servers that set CI or BUILD_NUMBER environment variables. In general these tools are meant to be run only on build servers.

So, maybe you don't need to set that parameter explicitly, but we would need to make sure the build is setting the CI or BUILD_NUMBER environment variables for it to happen implicitly. Not sure the VSTS build(s) have that yet, so just making sure. 😊

I confirmed the new Packages are MIT licensed. Thank Bruce!


Processing data

Created Model

Created model classes for all entities as shown in the ERD diagram.
Set up associations between models.

author_id column in posts table is the foreign_key for the users table.

Use models to insert data

Created users by running the following code:
first_user = User.create(name: 'Tom', photo: 'https://unsplash.com/photos/F_-0BxGuVvo', bio: 'Teacher from Mexico.') second_user = User.create(name: 'Lilly', photo: 'https://unsplash.com/photos/F_-0BxGuVvo', bio: 'Teacher from Poland.')
Created  4 posts written by one of the users you created by running the following code:
first_post = Post.create(author: first_user, title: 'Hello', text: 'This is my first post')
Created at 6 posts comments for one of the posts you created by running the following code:
 Comment.create(post: first_post, user: second_user, text: 'Hi Tom!' )

My Blog models includes following additional methods.

Users

A method that returns the 3 most recent posts for a given user.

Posts

A method that updates the posts counter for a user.
A method which returns the 5 most recent comments for a given post.

Comments

A method that updates the comments counter for a post.

Likes

A method that updates the likes counter for a post.

Thank you for the valuable suggestions, I have modified the code to comply with the project rewuirements.


Backport #163 to 5.x series

#163
For compatibility with adventure-platform-fabric using mods on 1.21.x.

Released as 5.14.2


Update README to make it clearer this a GitHub Action repo

Today the repo isn't clear that this is a repo for a GitHub Action. We should update it to better point people to the proper platform to consume this setup installer.

The title could say this is the setup-dapr@ gh action.  But I think it's fine and has not come up since 2021.


attacked large graphs available?

Hi there,
Thanks for the great work! I'm wondering if you could kindly provide the attacked graphs of ogbn-arxiv and ogbn-product datasets?
Best,
Chenhui

Hi Chenhui,
we're happy to help you out. But could you quickly eleborate on what exactly you mean with the "attacked graphs of ogbn-arxiv / ogbn-products".
The clean / unperturbed grahps you can find at the OGBN website
We will also update this repository with a more up-to-date version of the code some time today
Best, Tobias

Hi Tobias,
Thanks for the reply! I mean the graphs that are attacked by PR-BCD (under the poison setting). My gpu memory only has 11G and probably cannot run PR-BCD on relatively large graphs such as ogbn-arxiv and ogbn-products, which is why I hope you kindly could provided those attacked graphs, so that I can evaluate robustness of other GNN models on them.
Looking forward to your updated code! Thanks for the great work again!

Hi @Chenhui1016,
we will provide the perturbed graphs soon. Anyhow, we ran most of the ogbn-arxiv experiments also on a 11GB GPU. So for ogbn-arxiv you should be good to go.
Please note that we only experimented with global attacks (i.e. lowering accuracy over all nodes) for evasion. But you could simply use these perturbed matrices to train a model. At least for the local attacks, this works very well.
Best,
Simon

@Chenhui1016
We're still working on cleaning up the camera-ready version of the code even further. But we've already pushed the most up-to-date version for you to try out and test. Just have a look at the camera-ready branch of this repo.
If you're having trouble running the code please let us know, so we can keep improving the codebase.

Hi Tobias,
I just tried to run the code after following the instruction to install packages, but got a couple of errors below:

The package rgnn_at_scale.helper is not included. I manually add __init__.py" in rgnn_at_scale/helper to fix it.
When running pytest tests, it shows TypeError: scatter_softmax() got an unexpected keyword argument 'eps' for aggregation_test and ModuleNotFoundError: No module named 'experiments' for experiments_test.
There is a typo in the command: python script_execute_experiment.py --**config-files** 'config/train/cora_and_citeseer.yaml'. It should be python script_execute_experiment.py --**config-file** 'config/train/cora_and_citeseer.yaml'
When running the corrected command above, it shows the error: TypeError: expected str, bytes or os.PathLike object, not list when reading the config file in helper/local_util.py

Any suggestions would be greatly appreciated.

Hi @Chenhui1016,
Thanks a lot for your feedback and helpful notes.
I've pushed a few fixes to the camera-ready branch including the __init__.py for rgnn_at_scale/helper, the typo in the readme and the fix for the TypeError in helper/local_util.py.
However, I couldn't reproduce the 2. bug with the TypeError in scatter_softmax(). My best guess is that you're using a different version of torch and hence a different version of the torch_scatter package. So the signature of the function could be different resulting in the error.
Please make sure that you're using the same versions of all the dependencies and that your pytest is configured to use the correct python environment. E.g. you need to set the PythonPath for pytest manually.

Hi @Xiuyu-Li,
I've been using torch version 1.8.1+cu102 and torch_scatter version 2.0.7.
Hope this helps.

Thanks for your great work!  I want to ask you some questions. I am confusing how to obtain the attacked ogb-arxiv dataset generated by PR-BCD under the poison setting.

Thanks for your great work! I want to ask you some questions. I am confusing how to obtain the attacked ogb-arxiv dataset generated by PR-BCD under the poison setting.  Or, can you  provide the attacked ogb-arxiv dataset?
Looking forward to your reply!

In the paper, we only have evasion experiments on ogbn-arxiv. However, a widely adopted strategy is to transfer evasion attacks to poisoning (i.e. use the perturbed adjacency matrix obtained from an evasion attack for training a model from scratch). This is done by Nettack, SGA, ... and so can you do the same with GRBCD or PRBCD.
For a discussion of implications, I would look into the Metattack paper. Naturally, perturbations obtained specifically for poisoning are quite different. If you want to perform a poisoning attack then you might want to look into the example of the current PytorchGeometric Pull Request. However, I doubt that this example (i.e. without torch.checkpoint for the adjacency normalization) will scale to ogbn-arxiv out of the box. If you run into trouble I am happy to help.

@Chenhui1016 @Wangbeibei-AHU please see https://github.com/sigeisler/robustness_of_gnns_at_scale/tree/clean for the download instructions (will be merged to master soon)


feat: quotientLift on a finite family

mathlib3 PR: https://github.com/leanprover-community/mathlib/pull/18315

This PR seems to mix porting and pairing, which seems like a bad idea to me.

Closing this, the linked PR now has nothing to forward-port.


Add deprecation notice to response_url and response_urls_enabled

Summary
Reverts https://github.com/slackapi/deno-slack-sdk/pull/117/ again, effectively putting the deprecation notice back.
Also deprecates response_urls_enabled which is related.
Draft for now while I figure out if there's some timing on when this should go in
Requirements (place an x in each [ ])

[ ] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[ ] I've read and agree to the Code of Conduct.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks fine to me @henrymingwu but in the PR title you mentioned response_url_enabled which I don't see here?

Ah yes that was my mistake - I meant to put response_urls actually instead of response_url_enabled. response_url_enabled is a property of the block elements themselves (https://api.slack.com/reference/block-kit/block-elements#conversations_select__fields), but this PR is meant for properties in the interactivity payloads, which only includes response_url and response_urls. Edited to make that more clear!


Implement islice.reduce

Related to #3611
Implement and add tests for the reduce function of islice.

Thank you for contributing!

No problem!


Losing some data of prospecting on server 1.17.11

After rejoining the server, decimal numbers are no longer displayed, only integers.
Singleplayer works fine.

Data file from server looks like:
vsprospectorinfo.data.txt

Is this new to 1.17.11 or has this been a problem before?
Did you use other languages than English? If yes which?
The file contains the decimal values but also some extra characters which I'm not sure where they come from (1.4â€°)

Didn't play on server before, so idk.
I'm using English.
Somehow it skip server values and write only message.
{       "X":15617,       "Z":16501,       "Values":null,       "Message":"Triangulated 3 traces of ore. Relative densities:\nHigh Ilmenite (1.4‰ absolute)\nVery poor Native copper (2.2‰ absolute)\nVery poor Hematite (0.2‰ absolute)\nMiniscule amounts of Sphalerite, Graphite\n"    }"
Singleplayer data looks like:
 {       "X":16000,       "Z":15999,       "Values":[          {             "Name":"game:ore-nativecopper",             "PageCode":"item-nugget-nativecopper",             "RelativeDensity":3,             "AbsoluteDensity":6.7          },          {             "Name":"game:ore-lignite",             "PageCode":"ore-lignite",             "RelativeDensity":3,             "AbsoluteDensity":6.8          },          {             "Name":"game:ore-bituminouscoal",             "PageCode":"ore-bituminouscoal",             "RelativeDensity":2,             "AbsoluteDensity":1.3          },          {             "Name":"game:ore-halite",             "PageCode":"rock-halite",             "RelativeDensity":2,             "AbsoluteDensity":3.7          }       ],       "Message":null    }
P.S. Formatted to better reading

Still an issue 😫

I need to ask some questions otherwise we won't get further (and remember this is all voluntary on our side):
Same computer difference only if you start the dedicated server and connecting via client (if not what is your setup where the issue occurs)?
Version is still 1.17.11 ?
Any other mods are running (if so which) ?
What steps can we do to reproduce it ?
Do you have a save file where we can reproduce it ?

I looked a bit into this. The problem seems to be that the mod tries to parse the absolute density using the RegExp ([0-9]+,?[0-9]*) where it expects a , as decimal separator, which obviously does not work in each locale. To make things even worse, the output generated by the ProPick itself does not adhere to the configured locale of the game, but uses the Runtime/System locale, see here.
So for example on my machine (German System, English Game) I get entries like this: Very poor Native copper (3,9‰ absolute), where , as a separator works. Looking at the uploaded file, there are some legacy messages that have a . as a separator, which is why I assume it only recognizes the part that comes before the decimal separator.
Scraping locale dependent output is always a bit hacky.
One possible (hacky) fix would is to include the System decimal separator when constructing the Regex,
so something like '([0-9]+' + escapedSeparator + '?[0-9]*)', similar to this answer on SO
@GGGuenni @p3t3rix  I can give it a try if you think this is a reasonable fix.

Wow, only the separator is in system locale?! What a mess...
But good find! and sure sounds like a reasonable fix
The whole chat stuff is "hacky" in my eyes anyway

grab the result of the ProPick and no longer rely on the chat output
Sadly that's not possible. At least I didn't get it to work. The reason is that this mod is supposed to stay client-side only. Trying to patch the ProPick requires server-side code which would make everything a lot easier but also would require every server to install this mod for it to work.

The question is are there that many decimal seperators? We could extend the regex to include ',' as well as '.'.  This could of course lead to problems when the numbers would be grouped by digit (like 1,000,000.23) but i am not sure that is currently a case we need to consider.

Same computer difference only if you start the dedicated server and connecting via client (if not what is your setup where the issue occurs)?

If I start the dedicated server on my own computer there is no such issue (tested right now)
So issue ocurs only on another server where I'm playing right now. (mb need to test another servers too?)
I tested using same language as server on client, it didn't help. Also I tested to start the dedicated server on my own computer with config   "ServerLanguage": "ru", still works fine. (mine OC is Win10)
So my next guess about reasons is that those server is on Linux + using "ru" localization file. (heared sometimes it matters)

Version is still 1.17.11?

Yes.

Any other mods?

Yes, lots of them. List of them below.
Mods.txt

What steps can we do to reproduce it?

Can't really find this steps. I will ask owner of server if he could help to test this on his server (it's private and passworded only by invites)

Do you have a save file where we can reproduce it?

Nope, I'll ask an owner this too. But it could take a while he's on vacation right now.
Anyway, Wooza said smart things, looks very similar to our issue, as I understand.
P.S. I understand why you want it to stay only client-side mod.
If this mod will became a server side it will be the first "must have" mod on all servers. 🤣
P.P.S. Sorry of my English. I'm not native, hope you'll understand what I mean.

@LeonaLens thanks for reporting this bug, could you try version 4.1.3 to see if the issue still persists ?

Hi, I have this issue too, and I tried version 4.1.3 but the game crashed. I am using windows in the cs_CZ localization, which uses ',' as a decimal point. A crash log is attached.
Vintage story crash.txt

It's not so big, so I will post it in full. After removing the file and making a new prospecting with an empty result, it works fine. I will try to find some ore and then comment here.
'[{"X":15641,"Z":15610,"Values":[],"Message":null},{"X":15658,"Z":15494,"Values":null,"Message":"Triangulated 2 traces of ore. Relative densities:\nVery high Cassiterite (0.1‰ absolute)\nVery poor Cinnabar (0‰ absolute)\nMiniscule amounts of Hematite, Halite, Alum\n"},{"X":15654,"Z":15622,"Values":null,"Message":"Triangulated 3 traces of ore. Relative densities:\nUltra high Cassiterite (0.2‰ absolute)\nVery poor Cinnabar (0.1‰ absolute)\nVery poor Emerald (0.1‰ absolute)\n"},{"X":15657,"Z":15623,"Values":null,"Message":"Triangulated 2 traces of ore. Relative densities:\nVery high Cassiterite (0.2‰ absolute)\nVery poor Cinnabar (0.1‰ absolute)\nMiniscule amounts of Emerald\n"},{"X":15655,"Z":15623,"Values":null,"Message":"Triangulated 2 traces of ore. Relative densities:\nUltra high Cassiterite (0.3‰ absolute)\nVery poor Cinnabar (0.1‰ absolute)\nMiniscule amounts of Emerald\n"}]'

If I understand the code correctly, the problem in bullet 3. is causing a parsing error, so it saves the message as a string instead. That way, it can try again next time, when the problem is resolved.
Bullet 3. exactly describes my case. But I think that 0.5 is parsed as null, and that's the problem.

I implemented another fix and zipped it up if you want to try it.
ProspectorInfo-4.1.3-pre.zip

It works for me. Good work @Wooza

Three pieces of information are relevant for parsing the ProPick output:

the system locale of the server OS, which is used to format the absolute densities.
the system locale of the client OS, which is used to parsed the absolute densities.
the client locale of the game, which is used to find the proper i18n template (Lang.Get...) to know where certain information is located within the output string.

MB even 4?
4. the server locale of the game server.
Our's pieces will be nuts:
1 eng
2 ru
3 eng
4 ru

I implemented another fix and zipped it up if you want to try it.

Tested right now. Looks like all goes fine, even some chunks prospected before have full values (some not, but it's not an issue to go and prospect them once more) Data file looks amazing! Thanx! @Wooza 😘

i created a new release 4.1.4 which includes the fix


Fix CVE-2024-51744 and CVE-2024-45337

Description
Fixes CVEs
Issue link

CVE-2024-51744 (GHSA-29wx-vh33-7x7r)
CVE-2024-45337 (GHSA-v778-237x-gjrc)

Checklist

Purpose

[x] Bug fix
[ ] New functionality
[ ] Documentation
[ ] Refactoring
[ ] CI

Test

[ ] Unit test
[ ] E2E Test
[ ] Tested manually

Introduce a breaking change

[ ] Yes (description required)
[x] No

/reverify

/reverify

/reverify


.nav() method have a bug

this line doesn't work:
if (self.navigation.wrapper) self.navigation.wrapper.remove();
self.navigation.wrapper is a jQuery object but it isn't removed

Glide has been released in version v2.0.0. If the problem remains, please set up a new thread.


String#split fails to split on second or later separator

String#split fails to split some strings on their second or later separators.
a = "a.b.c.d"; p a
b = a.gsub('.', '-'); p b
c = b.split('-'); p c

% mruby a.rb
"a.b.c.d"
"a-b-c-d"
["a", "b-c-d"]

% ruby a.rb
"a.b.c.d"
"a-b-c-d"
["a", "b", "c", "d"]

was this ever fixed ?
I just got this issue on 1.1.0, sometimes it split correctly and sometimes it split the first and stop there, if I call split twice it works...

We will release 1.2.0 in November.

nice, thanks :)


3D editor flickering

See this video:
https://www.dropbox.com/s/2a5uyhmq3lz29gb/flickering3Deditor.mp4?dl=0
Steps: I make it full screen, add an asset, then make it small screen, there are scrolling bars appearing and dissapearing around the 3d editor

I can only reproduce this when the dom inspector is on.
I suppose yours is off?


[NFC]: Modernize code to follow C++11 clang-tidy recommendations

I have installed and run clang-tidy with the following configuration:
    "clang-tidy.checks": [
        "cppcoreguidelines-*",
        "modernize-*",
        "performance-*",
        "-modernize-use-trailing-return-type",
        "-cppcoreguidelines-init-variables",
        "-cppcoreguidelines-avoid-non-const-global-variables",
        "-cppcoreguidelines-non-private-member-variables-in-classes",
        "-cppcoreguidelines-pro-type-member-init"
    ],

The tool highlights several problems with the code base which this patch is fixing. Namely:

uninitialized variables
use of typedefs instead of alias declaration (via using keyword)
classes that have declared a custom constructor but have not declared move constructor and move operator= ...
use of define to declare names associated with a constant (should use static constexpr instead)
etc...

This patch also introduces the use of the standard LLVM facility for code tracing (i.e. the LLVM_DEBUG macro)

Jenkins Linux amd64 Build #2208 [push] [NFC]: Modernize code to... started at 17:46

Jenkins Linux s390x Build #2207 [push] [NFC]: Modernize code to... started at 18:47

Jenkins Linux ppc64le Build #1317 [push] [NFC]: Modernize code to... started at 18:48

Jenkins Linux amd64 Build #2208 [push] [NFC]: Modernize code to... passed after 54 min