HTML parsing error due to captcha

I got this error when I tried to use this module without the API key, which scrapes the genius lyrics.
undefined:1
<!DOCTYPE html>
^

SyntaxError: Unexpected token < in JSON at position 0
    at JSON.parse (<anonymous>)
    at SongsClient.<anonymous> (/home/runner/terminal/node_modules/genius-lyrics/dist/songs/client.js:47:37)
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/terminal/node_modules/genius-lyrics/dist/songs/client.js:5:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

const Genius = require("genius-lyrics");
const Client = new Genius.Client();
(async () => {
const searches = await Client.songs.search("faded");

const firstSong = searches[0];
console.log("About the Song:\n", firstSong, "\n");
console.log(firstSong)
})();

Code?

const Client = new Genius.Client();
(async () => {
const searches = await Client.songs.search("faded");

const firstSong = searches[0];
console.log("About the Song:\n", firstSong, "\n");
console.log(firstSong)
})();```

I ran an axios fetch request to the genius lyrics page and the page begins with:
<!doctype html>

    <title>Alan Walker – Faded Lyrics | Genius Lyrics</title>

I ran an axios fetch request to the genius lyrics page and the page begins with:
<!doctype html>

    <title>Alan Walker – Faded Lyrics | Genius Lyrics</title>

That's weird since the results are different. The error is probably due to cloudflare check, but your request from axios didn't trigger that check. Currently, there is no way of bypassing cloudflare check but I'll see what I can do. I keep this open until then.

I ran an axios fetch request to the genius lyrics page and the page begins with:
<!doctype html>

    <title>Alan Walker – Faded Lyrics | Genius Lyrics</title>

That's weird since the results are different. The error is probably due to cloudflare check, but your request from axios didn't trigger that check. Currently, there is no way of bypassing cloudflare check but I'll see what I can do. I keep this open until then.

I do believe that it isn't, I've dealt with many cloudflare check and normally cloudflare checks would be:
Page begins with:
<!DOCTYPE html>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Genius</title>

and the body content would have

Scrrrr!!

Sorry, we have to make sure you're a human before we can show you this page.

          <form id="challenge-form" class="challenge-form" action="/young-captain-na-li-dou-shi-ni-lyrics?__cf_chl_f_tk=osDcIXsJsHgwkalPyNRqy_UNjB9G_PMl3Ud7QnrFmwU-1672043083-0-gaNycGzNCBE" method="POST" enctype="application/x-www-form-urlencoded">

A Screenshot of the page:

I ran an axios fetch request to the genius lyrics page and the page begins with:
<!doctype html>

    <title>Alan Walker – Faded Lyrics | Genius Lyrics</title>

That's weird since the results are different. The error is probably due to cloudflare check, but your request from axios didn't trigger that check. Currently, there is no way of bypassing cloudflare check but I'll see what I can do. I keep this open until then.

I do believe that it isn't, I've dealt with many cloudflare check and normally cloudflare checks would be: Page begins with:
<!DOCTYPE html>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Genius</title>

and the body content would have

Scrrrr!!

Sorry, we have to make sure you're a human before we can show you this page.

          <form id="challenge-form" class="challenge-form" action="/young-captain-na-li-dou-shi-ni-lyrics?__cf_chl_f_tk=osDcIXsJsHgwkalPyNRqy_UNjB9G_PMl3Ud7QnrFmwU-1672043083-0-gaNycGzNCBE" method="POST" enctype="application/x-www-form-urlencoded">

A Screenshot of the page:

This could maybe be fixed with proper headers. I'll have to analyse it though. Meanwhile you could check the headers send from this library and the request done with axios and check the differences.

It is kind of weird though, axios shouldn't work if the cloudflare anti scrape feature was turned on, this confuses me alot

It is kind of weird though, axios shouldn't work if the cloudflare anti scrape feature was turned on, this confuses me alot

It doesn't seems like the headers matter:
  fetch({ url: "https://genius.com/young-captain-na-li-dou-shi-ni-lyrics" }).then(response => {
            var { data } = response;
            const $ = cheerio.load(data);

            const selectors = [
                () => $(".lyrics").text().trim(),
                () =>
                    $("div[class*='Lyrics__Container']")
                        .toArray()
                        .map((x) => {
                            const ele = $(x);
                            ele.find("br").replaceWith("\n");
                            return ele.text();
                        })
                        .join("\n")
                        .trim(),
            ];

        for (const x of selectors) {
            const lyrics = x();
            if (lyrics?.length) {
                return removeChorus ? removeChorus(lyrics) : lyrics;
            }
        }
        });

It is kind of weird though, axios shouldn't work if the cloudflare anti scrape feature was turned on, this confuses me alot

It doesn't seems like the headers matter:
  fetch({ url: "https://genius.com/young-captain-na-li-dou-shi-ni-lyrics" }).then(response => {
            var { data } = response;
            const $ = cheerio.load(data);

            const selectors = [
                () => $(".lyrics").text().trim(),
                () =>
                    $("div[class*='Lyrics__Container']")
                        .toArray()
                        .map((x) => {
                            const ele = $(x);
                            ele.find("br").replaceWith("\n");
                            return ele.text();
                        })
                        .join("\n")
                        .trim(),
            ];

        for (const x of selectors) {
            const lyrics = x();
            if (lyrics?.length) {
                return removeChorus ? removeChorus(lyrics) : lyrics;
            }
        }
        });

With this code, there are no headers, which means default to the axios user agent

++
Same, tho

found API to use it, it's working fine

found API to use it, it's working fine

What do you mean by that ?

found API to use it, it's working fine

What do you mean by that ?

just a delayed API which can scrap lines

found API to use it, it's working fine

What do you mean by that ?

just a delayed API which can scrap lyrics

could you mentioning about the api here, thanks

As of 25-03-2023, the fix for the rate limit has not been implemented. It should be noted that the issue only persists when using a enterprise-like ip address. Whereas on things like a home network it would not affect you at all.
I like this project and I really hope to see it succeed.

This seems to crash our entire script when simply using the search function. We've put the code within a try/catch but that hasn't prevented the crash. Am I missing something?
You can check the beta-(Bugs-are-expected) branch in the ZerioDev/Music-Bot project for the specific code. Here's a link. https://github.com/ZerioDev/Music-bot/blob/beta-(Bugs-are-expected)/src/buttons/lyrics.js

I fixed this problem, now everything working.

Hello, i have the same problem again when i host my bot on replit. How can i fix it ?

Hello, i have the same problem again when i host my bot on replit. How can i fix it ?

Use my API https://weeb-api.vercel.app/docs Check Misc session

Why not just share what you did?

Hello, i have the same problem again when i host my bot on replit. How can i fix it ?

Use my API https://weeb-api.vercel.app/docs Check Misc session

Why not just share what you did?
Here:

https://weeb-api.vercel.app/genius?query=let me down slowly
https://weeb-api.vercel.app/lyrics?url=https://genius.com/Alec-benjamin-let-me-down-slowly-lyrics

Hello, i have the same problem again when i host my bot on replit. How can i fix it ?

Use my API https://weeb-api.vercel.app/docs Check Misc session

Why not just share what you did?
Here:

https://weeb-api.vercel.app/genius?query=let me down slowly
https://weeb-api.vercel.app/lyrics?url=https://genius.com/Alec-benjamin-let-me-down-slowly-lyrics

It's your API not the fix. What I meant was how did you fix the captcha error? or did you used other package do it?

There is no way to bypass captcha, unless you solve it. Using hosts that are not blacklisted would also be a way to avoid captcha, which is how proxy would work in this case. Maybe there is something I don't know that enables bypassing this, perhaps something like cookie.

I think the conclusion to this issue would be the following:

Not using enterprise-liked IPs
Solve the captcha once in awhile (when it occurs)
Use services like 2captcha to solve the captcha
Hop between IP addresses
Try other APIs


(ER Patch 1.12) Increase pause length before low stats confirmation

Melina's Fingers was my one must-use tool when playing Elden Ring. One of my main uses was to use Grafted Blade Greatsword's AoW buff in low-level characters. In the recent patch of 1.12, I noticed that FromSoftware seems to implemented some kind of blocking delay for the input before we can press confirm the low stats popup. Upon testing, the increase to 300 was I believe the safest length out there.
I really appreciate this awesome tool 🙏
Due to the adjusted input speed in Elden Ring patch 1.12

You're my hero, thanks! <3
I actually noticed that my invasion hotkey (F10 by default) suffers from the same problem. But did not noticed problem with ignoring low stats popup. Thank a lot! Will release 1.13 soon.


Application often hangs upon exit when using Multi-Threaded 2DPhysics mode

Developed (simple 2DPhysics/AnimatedSprites and some custom code testing) application hangs upon exit when the threading model for 2DPhysics is set to Multi-Threaded, tested on windows and android, the problem apparently only happens on the former. Tested with godot 1.1 built from source with Visual Studio 2013 in all of 32bit and 64bit release and release_debug scenarios.
Sometimes, and after a long time (happened quickly once) the output will be something around the lines of "sync ==true" and the application properly quits.
I have already tried doing a lot of customized unload logic such as deactivating the physics server altogether, making sure all existing bodies are asleep and queueing their deletion, blocking signals on both the bodies and the 2DPhysicsSever itself by handling event 7 on _notify, all to no avail; the program still hangs after the custom logic runs, I can even go in the debugger and see 0 active bodies for 2DPhysics (but still around 500-ish collisionPairs)
EDIT: Realized that while running from the downloadable release doesn't have this problem, it also does not give the console output for the Multi-Thread 2DPhysics, it's most likely ignoring the parameter and running as Single-Thread.
image

PS: Changing back to Single Thread-Safe, naturally, fixes the problem.

im pretty sure the engine is single threaded at the moment. i think i read something about that being worked on.

IIRC there was work done on threading post-1.1, could you try the master branch to see if your bug is still there?

Will do so sometime tomorrow :)
On Fri, Nov 13, 2015 at 5:15 AM, Rémi Verschelde<EMAIL_ADDRESS>wrote:

IIRC there was work done on threading post-1.1, could you try the master
branch to see if your bug is still there?
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/2034#issuecomment-156359196.

--
Pedro Oliveira Raimundo.
Graduado em Análise e Desenvolvimento de Sistemas, IFBA. (2011-2015)

Had the same experience with mulitthreaded physics lately, mentioned here: #2760. You better use SingleThreaded-Unsafe, because I believe this was the default in Godot 1.1 and that SingleThreaded-Safe does not yield any benefits, but I could be wrong.


Possible issues with units

This section of the driver raises errors that I don't understand:
                                   raise RuntimeError(
                                       "Could not convert model units (%s) "
                                       "to obs units: (%s)" %
                                       (dm.units, do.units)
                                       )

Like this one:
 Error while processing variable tos:
	not all arguments converted during string formatting

I've ran the package after neutralizing these lines (with a #), and the result looks just fine. There is something at the beginning of this section that got my attention:
                            # Ok possible issue with units

The package is working for me right now but would you have some inputs for me on this point?

@jservonnat we're starting to clean things up for a new release, if you are not able to reproduce this we'll close it (along with any other rogue issues)

@jservonnat any more info on this? If not we'll close it as we're starting to clean things up for a new release


Theseslist

Coverage increased (+0.1%) to 87.317% when pulling dee0dcb9a471b2d18ca662e60c7109c982a0ba7d on theseslist into 4483aabdb13660123a969fdebfee3ce1e2e00d8b on master.


ImageButton spelling error

The title says ImageButon (with a single T)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8fdac83c-6d89-7423-b09c-d9a8c7e77d92
Version Independent ID: 1888bc98-338a-dba3-58bd-96023925b5a7
Content: Xamarin.Forms User Interface Views - Xamarin
Content Source: docs/xamarin-forms/user-interface/index.md
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @RikDriever
Thanks for pointing out the typo. It's fixed in a PR that will go out later.


debug CI a

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[ ] Test A
[ ] Test B

/rebase test=true

Hi @cheina97. Thanks for your PR!
I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

/rebase:            Rebase this PR onto the master branch (You can add the option test=true to launch the tests
when the rebase operation is completed)
/merge:             Merge this PR into the master branch
/build              Build Liqo components
/test               Launch the E2E and Unit tests
/hold, /unhold    Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

kind/breaking:      :boom: Breaking Change
kind/feature:       :rocket: New Feature
kind/bug:           :bug: Bug Fix
kind/cleanup:       :broom: Code Refactoring
kind/docs:          :memo: Documentation


[Error on PyTorch] Memory access fault by GPU node-4. Reason: Page not present or supervisor privilege.

I am implementing a incomplete gamma function in PyTorch in CPU and CUDA, but I always have a problem with a test with ROCm in PyTorch's CI.
The log can be found here (search for test_igamma_common_cuda_float64) with some of the log:
21:18:17 test_igamma_common_cuda_float32 (__main__.TestTorchDeviceTypeCUDA) ... ok
21:18:18 test_igamma_common_cuda_float64 (__main__.TestTorchDeviceTypeCUDA) ... Memory exception on virtual address 0x7f32775e8000, node id 4 : Page not present
21:18:18 Address does not belong to a known buffer
21:18:18 Memory access fault by GPU node-4 (Agent handle: 0x55d2eee23120) on address 0x7f32775e8000. Reason: Page not present or supervisor privilege.

My pull request can be seen here with the CUDA implementation of the function can be seen here.
I'm not sure why the error happens. Strangely, it works well with float32.

Hi @mfkasim1 ,
Thank you for filling the ticket.

Could you kindly share more details about your system(CI node from the hardware prospective)? and output log of  "/opt/rocm/bin/rocminfo".

Hi @ashutoshamd, I'm afraid I don't have access to know the specs and the logs. All I can see is just everything from this page.

Hi @mfkasim1 ,
  From the logs, I was able to get the configuration details of the H/W & S/W.
  I took Upstream PyTorch & pulled your patch to it & I tried to compile & test, but unable to get test generated.

`
root@taccuser-All-Series:/var/lib/jenkins/pytorch# python3.6 test/test_torch.py TestTorchDeviceTypeCPU.test_igamma_common_cuda_float32
E
ERROR: test_igamma_common_cuda_float32 (unittest.loader._FailedTest)
AttributeError: type object 'TestTorchDeviceTypeCPU' has no attribute 'test_igamma_common_cuda_float32'

Ran 1 test in 0.000s
FAILED (errors=1)
root@taccuser-All-Series:/var/lib/jenkins/pytorch# grep -rn test_igamma_common_cuda_float32 *
root@taccuser-All-Series:/var/lib/jenkins/pytorch#
`
Also, I did ran the test bench  .jenkins/pytorch/test.sh  , but there also, I could not see any "_igamma_common_cuda" , in the logs  for both passed / failed test.
I did test with after removing this commit [https://github.com/pytorch/pytorch/pull/46183/commits/c22072616d09c31742a215edbba86e7863335a85]   : "Skip ROCm CUDA test"
and currently my file stands like this
17392         half_prec = dtype in [torch.bfloat16, torch.float16] 17393         for input0, input1 in inputs: 17394             actual = torch.igamma(input0, input1) 17395             if half_prec: 17396                 input0 = input0.to(torch.float) 17397                 input1 = input1.to(torch.float) 17398             expected = scipy.special.gammainc(input0.cpu().numpy(), input1.cpu().numpy()) 17399             expected = torch.from_numpy(expected).to(dtype) 17400             self.assertEqual(actual, expected) 17401 17402     @dtypesIfCPU(torch.float16, torch.bfloat16, torch.float32, torch.float64) 17403     @dtypes(torch.float32, torch.float64) 17404     @unittest.skipIf(not TEST_SCIPY, "SciPy not found") 17405     @onlyOnCPUAndCUDA 17406     def test_igamma_common(self, device, dtype): 17407         # test igamma for reasonable range of values 17408         loglo = -4  # approx 0.018 17409         loghi = 4  # approx 54.6 17410         self._helper_test_igamma(loglo, loghi, device, dtype) 17411 17412     @dtypesIfCPU(torch.float16, torch.bfloat16, torch.float32, torch.float64) 17413     @dtypes(torch.float32, torch.float64) 17414     @onlyOnCPUAndCUDA 17415     def test_igamma_edge_cases(self, device, dtype): 17416         tkwargs = {"dtype": dtype, "device": device} 17417         infs = torch.zeros((3,), **tkwargs) + float("inf") 17418         zeros = torch.zeros((3,), **tkwargs) 17419         ones = torch.ones((3,), **tkwargs) 17420         zero_to_large = torch.tensor([0., 1., 1e3], **tkwargs)
Still the result is same.
What is that we are missing here?

Hi @ashutoshamd, I think the test should be called TestTorchDeviceTypeCUDA.test_igamma_common_cuda_float32.

Hi @mfkasim1 ,   I tried again.  It runs fine on the same hardware/software as per your logs.
root@taccuser-All-Series:/var/lib/jenkins/pytorch# python3.6 test/test_torch.py  TestTorchDeviceTypeCUDA.test_igamma_common_cuda_float64
.
----------------------------------------------------------------------
Ran 1 test in 1.848s

OK
root@taccuser-All-Series:/var/lib/jenkins/pytorch# python3.6 test/test_torch.py  TestTorchDeviceTypeCUDA.test_igamma_common_cuda_float32
.
----------------------------------------------------------------------
Ran 1 test in 1.529s

OK

All works fine for me.
Do you have any other info for reproduction scenario?

Hmmm.. did you remove the @skipCudaIfROCm line on the test?
I added it there because I was not sure how to fix it.
If you did remove it, I can try to remove it later in another PR to PyTorch.

Yes, as shown above my file is in the current state as shown.
It is running the test without any failure for me.

Thanks for trying this and sorry I can't give you more information about the reproduction.
I will close this issue until I can get more info to reproduce the error.


recursive conditional type fails to narrow when using ... operator

Bug Report

🔎 Search Terms
recursive conditional type narrow array
🕗 Version & Regression Information
4.5.0-dev.20211002
⏯ Playground Link

Playground link with relevant code
💻 Code

type _TupleOf<
    Type,
    Length extends number,
    CurrentArray extends Type[]
> = CurrentArray['length'] extends Length
    ? CurrentArray
    : _TupleOf<Type, Length, [Type, ...CurrentArray]>

export type TupleOf<Type, Length extends number> = number extends Length? Type[]: _TupleOf<Type, Length, []>

type Add<Num1 extends number, Num2 extends number> = [
    ...TupleOf<never, Num1>,
    ...TupleOf<never, Num2>]['length']

type AssertNumber<T extends number> = T

//error: Type 'Add<T, 2>' does not satisfy the constraint 'number'.(2344)
type Foo<T extends number> = AssertNumber<Add<T, 2>>

🙁 Actual behavior
Type 'Add<T, 2>' does not satisfy the constraint 'number'.(2344)

🙂 Expected behavior
no error

🕗 Version & Regression Information
4.1.5 to 4.5.0-dev.20211002

This doesn't seem to have worked in 4.1.5, or actually ever?

Yeah sorry that was a bit lazy of me, that was just the earliest version on playground I tested against before other errors started to show up

potentially the same issue, not sure:
type Foo<U> = U extends [infer I]? I : never;

type AssertString<T extends string> = T

// Type 'Foo<T>' does not satisfy the constraint 'string'.
//  Type 'unknown' is not assignable to type 'string'.(2344)
type Bar<T extends string> = AssertString<Foo<T>>
type Baz = AssertString<Foo<string>>

https://www.typescriptlang.org/play?#code/C4TwDgpgBAYg9nAPAVQHxQLxWVCAPYCAOwBMBnKAbQEsiAzCAJygEkBdAflagC4oiIANyYBuAFBjQkKAEEyZJsADKwRrQDmiACq4CxclDKqN6LFokB6C1C3hoAcnhItqe1BJwIFInGCGAhsDUZHQgUMAAFtAAxnBERoz+tH72CRr2AHRiVlA2dlD2AK5EANY+AO5EbsH8vlD+8tTqRP4ARgA20MBw4fmpxkTqmQAUAEwAzAAskwCUkvkAQv6M2rqEpBRpg6ay8ooqaoOITtqoqPPSSwBemLsKjMoDmidb6mdAA

Duplicate of https://github.com/microsoft/TypeScript/issues/44433 and many other generic conditional type / indexed access type issues—conditional types and indexed access types do not resolve according to their constraints and are not generally relatable when generic.


⚠ gorzdrav.org has degraded performance

In 8fc15b8, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 1084 ms

Resolved: gorzdrav.org performance has improved in e3c0aa9.


Error: Cannot read property 'forEach' of undefined

I receive these errors with default settings.  The PHP example works but not with my own code projects
[1540459847609][coverageservice]: INITIALIZING
[1540459872808][coverageservice]: LOADING
[1540459873247][coverageservice]: Loading 1 file(s)
[1540459874212][lcovparser][clover-parse]: Error: Cannot read property 'forEach' of undefined
[1540459874212][lcovparser][clover-parse]: Stacktrace: TypeError: Cannot read property 'forEach' of undefined
at /home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/@cvrg-report/clover-json/src/index.js:29:17
at Array.map ()
at unpackage (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/@cvrg-report/clover-json/src/index.js:25:25)
at /home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/@cvrg-report/clover-json/src/index.js:80:26
at Parser. (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/xml2js/lib/parser.js:303:18)
at emitOne (events.js:116:13)
at Parser.emit (events.js:211:7)
at SAXParser.onclosetag (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/xml2js/lib/parser.js:261:26)
at emit (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/sax/lib/sax.js:624:35)
at emitNode (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/sax/lib/sax.js:629:5)
at closeTag (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/sax/lib/sax.js:889:7)
at SAXParser.write (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/sax/lib/sax.js:1436:13)
at Parser.exports.Parser.Parser.parseString (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/xml2js/lib/parser.js:322:31)
at Parser.parseString (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/xml2js/lib/parser.js:5:59)
at exports.parseString (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/xml2js/lib/parser.js:354:19)
at /home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/@cvrg-report/clover-json/src/index.js:76:9
at new Promise ()
at Object.parse.parseContent (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/node_modules/@cvrg-report/clover-json/src/index.js:75:12)
at CoverageParser. (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/out/src/files/coverageparser.js:176:50)
at Generator.next ()
at /home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/out/src/files/coverageparser.js:7:71
at new Promise ()
at __awaiter (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/out/src/files/coverageparser.js:3:12)
at CoverageParser.xmlExtractClover (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/out/src/files/coverageparser.js:174:16)
at CoverageParser. (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/out/src/files/coverageparser.js:47:47)
at Generator.next ()
at /home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/out/src/files/coverageparser.js:7:71
at new Promise ()
at __awaiter (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/out/src/files/coverageparser.js:3:12)
at CoverageParser.filesToSections (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/out/src/files/coverageparser.js:36:16)
at CoverageService. (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/out/src/coverage-system/coverageservice.js:68:64)
at Generator.next ()
at fulfilled (/home/john.mitchell/.vscode/extensions/ryanluker.vscode-coverage-gutters-2.2.0/out/src/coverage-system/coverageservice.js:4:58)
at
[1540459874212][coverageservice]: Caching 0 coverage(s)
[1540459874212][coverageservice]: READY
[1540459874212][coverageservice]: RENDERING
[1540459874213][coverageservice]: READY
[1540459889363][coverageservice]: RENDERING
[1540459889364][coverageservice]: RENDERING
[1540459889377][coverageservice]: READY
[1540459889377][coverageservice]: READY

@neufena thanks for the issue, is what you are seeing similar to this ticket https://github.com/ryanluker/vscode-coverage-gutters/issues/172 ?

Thanks,
This seems to be the same issue, I have over 500 classes in codebase that are empty (mainly exceptions just extend the base exception).  I'll monitor this for the upstream fix.

going to close this one as a duplicate, thanks the extra info though!


Fix parsing of boolean value

Closes #123

I’ll seize the opportunity to thank you for not supporting on/off. Having both on and no in the same domain of values is a footgun.

This can be made configurable but since there are no complains, it's not urgent.


Annotation text does not wrap and overflows popup

I am unable to share the particular PDF at this time. If it is really necessary, I can get a file with an annotation, but I doubt it is a specific problem.
Configuration:

Web browser and its version: Mozilla Firefox for Ubuntu 84.0.2 (64-bit)
Operating system and its version: Ubuntu 20.04
PDF.js version: unknown
Is a browser extension: no

The text should be contained within the annotation popup like so:

Instead, it overflows.

The problem seems to be caused by the .pdfViewer.scrollHorizontal, .spread CSS rule in resource://pdf.js/web/viewer.css which specifies white-space: nowrap;. At least I am able to fix it by adding white-space: normal to the .annotationLayer .popup rule in the DOM inspector.

I can reproduce this with a sufficiently long annotation text. Thank you for reporting this, I'll work on a fix.

I can reproduce this with a sufficiently long annotation text. Thank you for reporting this, I'll work on a fix.

Fixed by the PR above.

Fixed by the PR above.


”Running Javascript Code as a Side Effect“ using a js script file

Writing some javascript code directly in the " run"  field is a little annoying especially when the code is long.
Is there any possibility that just filling a js script file path makes it work?

Any suggestion as to where you would like the scripts file to live?  In the .vscode folder or elsewhere?


Flang hardcodes a warp size of 32

See #define NVVM_WARPSIZE 32 in flang/tools/flang2/flang2exe/ompaccel.h
Only has one use site:
  sptrShmem = mk_ompaccel_addsymbol(
      name, mk_ompaccel_array_dtype(DT_INT8, NVVM_WARPSIZE),

I'm not totally sure what this API is doing, but would guess it's allocating an array char[WARPSIZE] which suggests there's a risk of out of bounds for amdgcn when warpsize is actually 64.

although  I think this may only be SHMEM related
I also see in the file this which gives me warm fuzzies
// Should be in sync with clang::GPU::AMDGPUGpuGridValues in clang
#define GV_Warp_Size 64
#define GV_Warp_Size_Log2 6
#define GV_Warp_Size_Log2_Mask 63
// AOCC End

I think this is now fixed - @ronlieb?

I think this is resolved as well

Cool, thanks


Where is the code that visualizes by time step?

In the paper, there is a visualization figure for each time step, but it is not in the code.
If it's in the code, please let me know which part it is.
If it's not in the code, please let me know which part I should check.

I think that you can add a dictionary in the class AttentionStore to collect the cross-attention map for each step

and add the cross-attention map of each step to the dict in between_steps function

@wenqsun Thanks! so much helpful


Updating dependencies breaks this project

Hi, thanks for reaching us out.
Please, provide:

Bug description
Expected behavior
Actual behavior
Steps to reproduce
NPM / Node.js logs while reproducing the problem

Do not forget to remove any sensitive data from logs outputs.
Thx!

Hey, we haven't heard back from you since a while...
Therefore, we are going mark this issue as closed due to the lack of information to reproduce the problem.
Have a great day!


docs: examples reference outDir vs. outputDir

The value wxt.config.outputDir doesn't exist. By inspecting wxt.config the closest value I found was outDir.
This change does not effect any functionality. It's just markdown and comments that generate the docs.

:zap: Quick jump to updated sections:

https://deploy-preview-982--creative-fairy-df92c4.netlify.app/guide/go-further/reusable-modules.html#module-utils
https://deploy-preview-982--creative-fairy-df92c4.netlify.app/api/reference/wxt/modules/functions/addEntrypoint.html#example


Add qubit_properties to Target class

Summary
This commit adds a new attribute to the target class for defining qubit
properties. This was originally not included in the target because
nothing in the transpiler supports using any qubit properties. However,
in a future PR I'm planning to modify the default heuristic layout score
used by VF2Layout to factor in T1 and/or T2 in addition to the
measurement error rate it's using now. To do this though we need to
ensure that we have these values available via the target. This commit
also is the first time we've had to expand the set of information that
can optionally be pecified in a target. I opted to just make a straight
addition here rather than versioning it. There should be no backwards
compatibility issue for users or provider maintainers on upgrade because
not specifying a qubit properties payload will not change any behavior
the Target and BackendV2 objects will behave exactly as before.
I was thinking we'd only use a version if we needed to make a backwards
incompatible change in the future. That way we can support both versions
of the class a the same time while we migrated to a newer interface. But
for simple additions like this that don't effect the behavior or cause
any issues with compatibility we can simply add them to the class.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

17 of 20 (85.0%)  changed or added relevant lines in 4 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.0003%) to 83.57%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/providers/backend.py
4
5
80.0%

qiskit/transpiler/target.py
7
9
77.78%

Files with Coverage Reduction
New Missed Lines
%

qiskit/pulse/library/waveform.py
3
89.36%

Totals

Change from base Build<PHONE_NUMBER>:
-0.0003%

Covered Lines:
52346

Relevant Lines:
62637

💛  - Coveralls

The PR looks good to me based on my limited experience of BackendV2. I would like to know whether I should update my PR #7643 to reflect the changes here after this PR is merged.

Yeah if we merge this before #7643 it would be good to update the #7643 to include the QubitProperties in the Target (it should be a minimal change). But if #7643 merges first I'll take care of updating the fake objects in this PR.

I was initially planning to rename the backends in fake_backend_v2.py to avoid confusion with the new FakeBackendV2 I created, but perhaps that can be made in a follow up PR separately. What do you think? @mtreinish

I think we can do that in a follow up to #7643. For #7643 I think it would be good if we just keep the PR to adding a v2 implementation of the fake backends (which will be a big enough change on its own). Cleanups like renaming things are small enough that they should be quick PRs.


Decorator in different file: ReferenceError, myComponent not found

storybook version: 2.35.3
When adding a global decorator decorator in its own file, like this:
import { configure, addDecorator } from '@kadira/storybook';
import myDecorator from './myDecorator.jsx';

addDecorator(myDecorator);

with myDecorator.jsx looking something like this
export default function(story) {
  return (
    <div class="decoratorWrapper">
      { story() }
    </div>
  );
}

and then trying to write a story with your own component, like this:
import React from 'react';
import { storiesOf, action, linkTo } from '@kadira/storybook';
import myComponent from './myComponent.jsx';

storiesOf('AppBar', module)
    .add('My story', () => (
        <myComponent>
        </myComponent>
    ))

I get the error Uncaught ReferenceError: myComponent is not defined. The only time where my decorator works is if the decorator component is defined in the same file as it is used by a story.
Any idea what the problem is?

In myDecorator.jsx I somehow managed to have <myComponent> with much whitespace Before it so it wasn't visible in the editor screen.


Non-negative timestamp expected

What happened?
A bug happened!
Steps to reproduce
opened the app
What OS are you seeing the problem on?
No response
Relevant log output
Boundary error:
Error: Non-negative timestamp expected
App Version: vibe 3.0.0
Commit Hash: 371af90
Arch: x86_64
Platform: windows
Kernel Version: 10.0.22631
OS: windows
OS Version: 10.0.22631
Cuda Version: n/a
Models: ggml-medium-q8_0.bin
Default Model: "C:\\Users\\email\\AppData\\Local\\github.com.thewh1teagle.vibe\\ggml-medium-q8_0.bin"
Cargo features: vulkan

{"avx":{"enabled":true,"support":true},"avx2":{"enabled":true,"support":true},"f16c":{"enabled":true,"support":true},"fma":{"enabled":true,"support":true}}

<details>
<summary>logs</summary>

cmd: "C:\\Users\\email\\AppData\\Local\\vibe\\ffmpeg.exe" "-i" "C:\\Users\\email\\AppData\\Local\\Temp\\vibe_temp_2024-12-28\\Jt3tEPwjj8.wav" "-ar" "16000" "-ac" "1" "-c:a" "pcm_s16le" "C:\\Users\\email\\AppData\\Local\\Temp\\vibe_temp_2024-12-28\\2024-12-28 19-19-12.wav" "-hide_banner" "-y" "-loglevel" "error"

</details>

Duplicate of https://github.com/thewh1teagle/vibe/issues/408


Not expanding combos in CLI clients

Expected behavior
-Typing in a combo should expand it into proper text
Actual behavior

Typing in a combo replaces it with nothing

Steps to reproduce the behavior

Using PuTTY you need to connect to server via SSH to access CLI and try using combos there.
The issue also happens in PowerShell. Launch PowerShell CLI and try a combo.

Operating system

Windows 10

I tried it in Command Prompt on Windows and it does work.

Hi @viktorix.
I noticed the problem with Putty, and forgot to open an issue for it, so thanks for reporting it.
The reason Beeftext does not work properly is that Putty does not support the standard Ctrl+V shortcut for pasting the content of the clipboard. To work as universally as possible, The combo substitution process is  the following:

Backup the content of the clipboard.
Copy the snippet to the clipboard.
Synthesize a Ctrl+V keystroke.
Restore the previous content of the clipboard after waiting for a brief amount of time.

I'm surprised to hear that Beeftext is not working in PowerShell, because it works just fine on my Windows 10 system.
There is a workaround that I can implement for Putty (and other terminal applications like Cygwin), because there is another standard shortcut for pasting: Shift+Insert. It also works nearly everywhere, but unfortunately, there are also applications that does not support it, such as... PowerShell. As a consequence, I'll have to try to identify the active application and if it is in a predefined list, I'll use Shift+Insert instead of Ctrl+V.


you are not allowed to use command syntax />pluginname>:!

*Detailed description of the issue:
When a player goes to open /jobs, this issue is stated in the chat
you are not allowed to use command syntax />pluginname>:!
[13:39:47 INFO]: Moonbounce issued server command: /jobs:jobs join fisher

ERROR (DELETE IF YOU HAVE NO ERROR):
<-- Try to use pastebin.com server if you have long error. -->
####################
No console error is present
####################

CONFIG SECTION (DELETE IF NOT RELEVANT):
#####################################
## PASTE RELEVANT CONFIG SECTION HERE ##
#####################################

Jobs version:
<IP_ADDRESS>
Server Type (Spigot/Paper/etc):
paper
Server Version (using /ver):
This server is running Paper version git-Paper-196 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 773dd72)

closed, bug was found elsewhere.


Filtering Support

It would be nice to have some basic filtering support of the hstore fields with Django Rest Framework.

@krische, contributions are welcome, if you manage to implement something interesting please send a pull request with the code so we can discuss further.

Yeah I was starting to play around with creating an HStoreBackend filtering class. I was thinking thinking users could specify their filter query parameter as FIELD.KEY=VALUE. That should at least give some kind of basic filtering for hstore fields that are just storing key/value pairs.

@krische Did u implement the filter? I also need some filter capabilities in my API to HStore


E2E Tests - Parameterize iOS Simulator Version

Support for 8.3, 9.1 and future simulator releases

Wrong repo.


create-cluster: Validate operator roles prefix

Since the prefix is used to generate the role name, the prefix itself
needs to conform to the Role Name regular expression.

/lgtm


Support our own notifications

Resolves #293
Instead of using custom notifications, which is supported on near.org (but contains quite a few bugs) and isn't supported on near.social, I thought of adding our own index like buildhub.near/{{feature}}/{{action}}.
Because now we have our own notifications page in gateway, where we can easily support it.
Eg: for proposal, it will be buildhub.near/proposal/vote, buildhub.near/proposal/create, similarly we can have it for events, and other features. We can have "Approve", "Reject", "View", all these different actions for different type of feature and actions.
@elliotBraem what do you think of the idea and structure? if you agree, I will continue to add further changes to the PR

I like the idea of creating new indices, and I think I could get behind the structure with some more reasoning --
If I were to Social.get("buildhub.near/proposal/vote"), would I get any data? What would this data look like?
How might we define a "Notification" type?

but maybe we can continue this discussion through notify.near on gateway? Can you create this project pointing to "notify.near" account?

I have moved this conversation here.


Major cleanup (whitespace, headings, warnings, circular deps)

As promised in #92, here comes a major cleanup.

Cleanup whitespace (same as #91 but now for all libraries).
Use outline-minor-mode compatible section headings. 415e619ed4bdffe0c50d9e49b8b8676692def718
Address all byte-compilation warnings (approximately 60!).
Break circular dependencies between libraries. 6711095d4ce6ee876bf4af0c13aecb0188eb7ce3

Please make sure the fixes in 1c75e74ed6b29d18ca18471275fbdcee7081f6ee are correct and don't just further hide bugs.
Next I would like to make all libraries except rustic.el itself optional.  That basically works already, but needs more testing.

Nice, thanks! I want to review this properly so I maybe won't merge this before the next weekend.

If you checkout this branch and in the rust-mode repository tarsius/backport you now can get a human readable comparison between the two modes like so:
cd rust-mode
cp ../rustic/rustic.el rust-mode.el
sed rust-mode.el -i -e s:rustic:rust:g

Then view the diff in Magit.

It seems the user needs to change his config in order to use all rust components ? IMO it should be optional to disable the other features, not to enable them ?
Now emacs complains about void variable rustic-rls-pkg when opening a rust file.

It seems the user needs to change his config in order to use all rust components ? IMO it should be optional to disable the other features, not to enable them ?

I have removed those changes for the time being and moved them to the lighttweight branch. Also fixed some issue.
(Another issue that I ran to, even on master, is that when one has lsp-mode installed without configuring it, then an error occurs in rustic-lsp-mode-setup because rustic-lsp-server isn't in lsp-client. I don't know how that is supposed to get in there. So I had to disable rustic-lsp-setup-p.)

Now emacs complains about void variable rustic-rls-pkg when opening a rust file.

I have fixed that.

After splitting out the difficult parts to another branch, this should be safe to merge again.

I can't push to your branch so I added the branch to this repo. I just moved some code to make things work again. If it is ok for you I would merge this when tests go green ?

I can't push to your branch so I added the branch to this repo.

Hm, I'll have to look into how that happened.

I just moved some code to make things work again. If it is ok for you I would merge this when tests go green ?

Give me a moment to look into that.

Okay that's one way of doing it (in one of the commits that I am holding back for now I instead moved both rustic-re-item-def-imenu and  rustic-imenu-generic-expression right before rustic-mode-syntax-table instead. If you move them to eof, then you should should at least declare somwhere before rustic-mode-map.
But I would rather finish the remaining two commits before anything is merged. I just needed a break; it's rather boring work.

Yeah I know, that's why I'm especially grateful ;)
I'm on my way home, if you want you can fix it now or wait.

I would like to let it rest until Monday and if you in turn can only work on it on the week end, then we should probably delay until the end of next week.

I was a little busy this week and wanted to take the time to Review it. Monday sounds good.
Have a nice weekend.

Do you run the tests locally? It takes forever on Travis.
Do you have setup instructions? I don't just want to blindly copy the Travis configuration (especially considering that what it does seems to be quite expensive).

I am currently doing "testing by using". I also looked at the test output, but I cannot wait > an hour after every little change. I noticed it complained a lot about some functions being void.
We no longer explicitly load the libraries that define that, so that's not a complete surprise, but they should be autoloaded, i.e. they should get loaded when first used. I think this does not work properly due to a bug in .travis.yml, but I have very little experience with Cask, so I am not sure.
Shouldn't cask build also be run? Why does doing that not generate rustic-autoloads.el (as I just found out by doing it locally)? How does one generate that file when using Cask? Does cask exec ert-runner load rustic-autoloads.el if it is present?
Or in other words, it appears that the test setup also needs some work (and I am not the one to do that).
Meanwhile we might have to give up on not explicitly requiring all additional libraries until we can reliably and somewhat quickly test whether that actually works as expected.

Do you have setup instructions?

Oh! You do. But they appear to be extremely incomplete and result in one failed test and all other tests being "unknown", whatever that means.

I am currently doing "testing by using". I also looked at the test output, but I cannot wait > an hour after every little change. I noticed it complained a lot about some functions being void.

I wouldn't wait for travis, but run the tests locally. It takes some time to download the rust lsp server, but I had several issues regarding rust-analyzer that does not start, so I decided to add this test.

We no longer explicitly load the libraries that define that, so that's not a complete surprise, but they should be autoloaded, i.e. they should get loaded when first used. I think this does not work properly due to a bug in .travis.yml, but I have very little experience with Cask, so I am not sure.

I'm actually still inclined to keep providing all features, since most users want that(I would have no problem with doing it the other way round, but I'm sticking with the majority of users).

Shouldn't cask build also be run? Why does doing that not generate rustic-autoloads.el (as I just found out by doing it locally)? How does one generate that file when using Cask? Does cask exec ert-runner load rustic-autoloads.el if it is present?

I don't really know, but what I do know is that it works this way ;)
I don't know what's the purpose of this autoloads file. I don't have this on my disk. Maybe it's a configuration thing ?

Or in other words, it appears that the test setup also needs some work (and I am not the one to do that).

Sure it can always be done better, but it works and it saved me a lot of nerves. Look at master, it's green. I have been fiddling with it on another branch so I know it works, currently. The issues you've seen seem to come up every now and then :D
Most of the times it works again when I clear the cache, don't ask me why...

Meanwhile we might have to give up on not explicitly requiring all additional libraries until we can reliably and somewhat quickly test whether that actually works as expected.

As mentioned before, I would keep requiring all libraries and add some tests to check whether it works with rustic.el only. Sorry, but I already see users opening issues why the features they were using are not available anymore.
That being said I really appreciate your work here and I can also finish your work if you want. I know that you have tons of other things you want to improve ;)

The idea isn't to force users to explicitly opt-in to functionality that was previously available out of the box. You made it clear that you don't want that and I accept that.
What I am trying to do right now is to merely to avoid loading libraries until the things that they define are actually being used. This libraries should automatically be loaded because of a technique called "autoloading". This means that a special file rustic-autoloads.el is generated from all the functions and variables whose definitions are prefixed with ;;;###autoload. Once such a symbol is actually used the library that contains the real definition is loaded.
Now there are a few issues with that: It appears Cask does not generate that, and I am having difficulties running the tests.

As mentioned before, I would keep requiring all libraries and add some tests to check whether it works with rustic.el only.

I'll look into that.

Travis seems to refuse to test the latest tip of my pr, see https://github.com/brotzeit/rustic/pull/95/checks. Could you tell it please run the tests? I made some experimental changes that are specifically intended to test how travis tests, so it is a bit frustrating that it is right now deciding to go on strike. :roll_eyes:

I made some experimental changes that are specifically intended to test how travis tests, so it is a bit frustrating that it is right now deciding to go on strike.

Yeah, I know what you're talking about.
I have to do some more work, but hopefully I can take a look at it later but probably it will be tomorrow. Maybe it's better for you to work on something else for now ;)

Wow, looks great! I would merge this now ? What about #97 ?

Well obviously I still have to cleanup the various wip commits, but I could do that now.
I wanted to play with emacs-module-rs instead, but got stuck on the first step. https://github.com/ubolonton/emacs-module-rs/issues/25 So I got some time.

Ok, tell me when you're ready.

I think we are good to go. (Once the tests complete.)

:ok_hand:

Finally "rebase and merge" is set so I can't forget it again :sweat_smile:
Thanks again. The next PR will be merged properly ;)


Ivi manager protocol v2

I added orientation requests and events to ivi-manager protocol

Only a single ivi_manager_layer and a single ivi_manager_surface are
allowed per ivi_manager. So they are more like some additional
namespaces for ivi_manager.
Would it make sense to move all ivi_manager_surface requests and events and all ivi_manager_layer requests and events to ivi_manager and extend the names with a corresponding prefix 'surface' and 'layer' ?

The comment for the ivi_manager_surface.configuration event suggests that width and hight reflect the size the client was requested to resize its buffer to, not the actual surface size. But from the implementation is seems like the configuration event informs about the actual current surface size.
The implementation might make more sense as there would be no other event for the ivi_manager client to find out the real surface size.

Shall update events for render order (e.g. surface_added) also be send in sync mode?

The name ivi_manager is to generic, I think something like ivi_wmanager (w for window)

I will merge layer and surface interfaces to ivi-manager interface. I will send a new PR with these changes.
In current implementation, it is not feasible to update render order all the time. Because ivi-shell sends an event with the information that a surface is added to layer. There is no information where in layer render order this surface added to. We have to either modify ivi-shell code or track render order in ivi-controller.
Both options are not optimal because:

updating ivi-shell cumbersome and takes time. We have to release the update for next compliance update
tracking render order is also bad. it is already tracked at ivi-layout. they should be in sync etc.

In my opinion, ivi_manager is ok and not too generic because it is a wayland protocol. It is clear that it manages compositor content. But we can change the name. No problem.
what about ivi_wm instead of ivi_wmanager? I like short names then function names would be also short.
Therefore, I want to skip it for now. In future we can change it.

lets go for ivi_wm and we should change this before merging this implementation, changing the name later could cause some confusion and explanation efforts which we should avoid ( we have already enough such efforts :-) )


enable 1.0 payouts indefinitely

To complement https://medium.com/gratipay-blog/39c07bd031b.

😛

Rebased and ready for review!
cc: @rohitpaulk @rorepo @yifeiwu et al.

LGTM

!m @kaguillera
Thanks! :-)


Fix buildkite-agent upload with absolute path

Fixes https://github.com/buildkite/agent/issues/1043

Will get this released into 3.13.2 later today.


[WIP] Modeling AnsibleTowerJob

The goal is to model AnsibleTowerJob as a subclass of OrchestrationStack
The first step is to extract part of the existing OrchestrationStack to intermediate class ManageIQ::Providers::CloudManager::OrchestrationStack. The new class hierarchy is:
(specific cloud manager)::OrchestrationStack < ManageIQ::Providers::CloudManager::OrchestrationStack
ManageIQ::Providers::CloudManager::OrchestrationStack                    < ::OrchestrationStack
ManageIQ::Providers::Openstack::InfraManager::OrchestrationStack         < ::OrchestrationStack
ManageIQ::Providers::AnsibleTower::ConfigurationManager::AnsibleTowerJob < ::OrchestrationStack

The first step is ready for review.

@gmcculloug please review. We can also choose to merge this PR and create a separate PR to create AnsibleTowerJob

@bzwei You also need to update the subclassing of the provider specific OrchestrationStack service_models so they derive from the new ManageIQ::Providers::CloudManager::OrchestrationStack class.
MiqAeServiceManageIQ_Providers_Amazon_CloudManager_OrchestrationStack < MiqAeServiceOrchestrationStack
MiqAeServiceManageIQ_Providers_Azure_CloudManager_OrchestrationStack < MiqAeServiceOrchestrationStack
MiqAeServiceManageIQ_Providers_Openstack_CloudManager_OrchestrationStack < MiqAeServiceOrchestrationStack

Otherwise, this looks good.

@bzwei Along with removing WIP (when ready) you should update the PR title since we are not adding the AnsibleTowerJob model here but just refactoring in preparation for it.


Pin claims to web3.storage

Pinning claims to ipfs.

Closing this, because resolving the conflicts is too complicated. Creating another PR.


MariaDB support?

Does knex support MariaDB?

It does, we are using it with mariadb; the only issues we found are on both mysql & mariadb; nothing mariadb specific yet.


test doesn't fail for python3

Python3.4 and Python3.5
python3.4 ./runtests.py -v2
Creating test database for alias 'default' (':memory:')...
Operations to perform:
  Synchronize unmigrated apps: django_filters, tests
  Apply all migrations: auth, contenttypes
Synchronizing apps without migrations:
  Creating tables...
    Creating table tests_user_favorite_books
    Creating table tests_user
    Creating table tests_comment
    Creating table tests_article
    Creating table tests_book
    Creating table tests_restaurant
    Creating table tests_networksetting
    Creating table tests_company
    Creating table tests_location
    Creating table tests_account
    Creating table tests_profile
    Creating table tests_bankaccount
    Creating table tests_node_adjacents
    Creating table tests_node
    Creating table tests_directednode_outbound_nodes
    Creating table tests_directednode
    Creating table tests_worker
    Creating table tests_hiredworker
    Creating table tests_business
  Installing custom SQL...
  Installing indexes...
Running migrations:
  Applying contenttypes.0001_initial... OK
  Applying auth.0001_initial... OK
...
test_filtering_skipped_with_empty_list_value_and_some_choices (tests.test_filters.MultipleChoiceFilterTests) ... unexpected success
...
----------------------------------------------------------------------
Ran 245 tests in 0.463s

FAILED (skipped=13, expected failures=8, unexpected successes=1)
Destroying test database for alias 'default' (':memory:')...

Also disturbing is that it exits with a 0 status, indicating success, for this case.

Just noticed it also reports successes=1 under Python 2.7. Curiously Python2.7 reports OK, not FAILED.
Looking at the test seems to suggest that the test is suppose to pass, however it is decorated with @unittest.expectedFailure - which doesn't make a lot of sense to me.

Yep, so #79 was a huge overhaul of the tests and introduced quite a few new ones, including several expected failures. Since then, the original implementation has been updated and passes, but the test was never updated.


user_registered signal doesn't fire

Whats the problem?
I cannot for the life of me get the user_registered signal to fire. I have no idea why. On creating a user with the djoser /users/ endpoint, the signal doesn't fire.

I am hitting the correct endpoint.
The user is successfully created.
I can get other signals like post_save to work, but not the Djoser home rolled ones.
I know the Djoser create view is firing correctly. I can get it to print out confirmations, but can't get the signal to work.

What on earth am I doing wrong?
## __init.py__

default_app_config = 'accounts.apps.AccountAppConfig'

## apps.py

from django.apps import AppConfig
from djoser.signals import user_registered

class AccountAppConfig(AppConfig):
    name = "accounts"

    def ready(self):
        import accounts.signals as signals

### signals.py

@receiver(user_registered, sender=User)
def add_registered_user_to_group(sender, instance, **kwargs):
    """
    When a user is registered (this is before they have
    validated their email), assign them to groups allowing them
    to create projects & rules.

    """
    print("I have run")
    add_users_to_groups(sender, ["ProjectUser", "RuleSetUser"])

same, though for user_activated signal.

update:
I was able to get this to work by correctly importing my AppConfig.
I was able to follow these docs to find out how to correctly import my AppConfig.
app/apps.py
from django.apps import AppConfig
from djoser.signals import user_activated

class AppConfig(AppConfig):
    name = "app"

    def ready(self):
        from .users.signals import user_activated_handler
        print('AppConfig ready')

app/init.py
default_app_config = 'app.apps.AppConfig'

app/users/signals.py
from .contacts import EmailContacts
from django.conf import settings
from django.dispatch import receiver
from djoser.compat import get_user_email
from djoser.signals import user_activated

# @receiver(user_activated)
def user_activated_handler(sender, user, request, *args, **kwargs):
    print('user_activated_handler', user, request)
    to = get_user_email(user)
    EmailContacts.add_contact(to, settings.CAFECITO_USERS_CONTACT_LIST_ID)

user_activated.connect(user_activated_handler)

print('registered user_activated_handler')


Cleanup

I’m starting to deprecate the repo, so I’ve put up a notice, removed outdated packs and transferred those that can be useful (most of the packs here can). I’m going to do it in parts so that it wouldn’t be too hard to review. This is part 1. :)
Review, and I’ll merge after a couple LGTM’s. Transferred packs are opened as separate PRs in contrib, please review those, too. I’ll fix the linting and typos there, as well.
:heart:

I've transferred every complete independent pack. Those that are left are examples, demos and our internal cases. I won't touch them right now, we can decide on it later.
Someone please review.

Almost every pack that's listed here has been carefully linted and merged into st2contrib. Merging.


Project structure and plugin system

Hello, hello.
As I mentioned, I've worked on Asteria for a few weeks now. Asteria(V3 base) has most of the combat "hardcoded" into the source and doesn't really utilise the plugin system much. I checked few releases based on Asteria and everything was pretty much crammed into already existing classes, into the source.
That's what I am familiar with, that's what we did back in 2006-2011.
My understanding is that there shouldn't(when finished, of course) be a need for common developer to delve into the Luna source but write everything into the plugins.
So, what I don't understand is: What is the benefit of having skills(experience, levels, factors, combat level)?
If I were to develop my fork, what should I write to the source and what should I write into the plugins?(I am somewhat familiar with plugin model but It seems I cannot apply it to RSPS)
~Spirithill
P.S. Wanted to discuss, but have no idea if "issue" is the appropriate way of doing that on GitHub. I am bew to GitHub, sorry.

Hello @Spirithill, this is a fine way to discuss this.
I am not entirely sure on what you are asking, but if you need help with anything, let me know and I would love to help. I am still learning the ins and outs of Luna myself, but I am excited that others are interested in working on the project.

Closing as discussion is a year old.


Feature/swagger

Codecov Report

Merging #5 (9739693) into master (1932dd0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   12.56%   12.56%
=======================================
  Files          26       26
  Lines         573      573
  Branches       26       26
=======================================
  Hits           72       72
  Misses        501      501

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1932dd0...9739693. Read the comment docs.


Trello 36 - Create model for Case Study

Model creation for Case Study.
Additionally, Tags and Questions must also be models, and having MHx and Medication as its separate models allows for a simple structure for the case study model.

Updated Tag so that multiple tags can be assigned to the same Case study, fix user foreign key for last edited


[BUG] Unable to edit existing Anomality Detectors after changing Authentication to SAML

Describe the bug
Changing authentication from internal users to SAML authentication causes existing (created with internal user, that is now deleted) anomality detectors to be not editable with administrator access.
Details:
PUT /_dashboards/api/alerting/monitors/id-of-detector?ifSeqNo=1&ifPrimaryTerm=59
-> Response status code 200
-> Response content: {"ok":false,"resp":"[alerting_exception] User has no available detectors"}
To Reproduce
Steps to reproduce the behavior:

Change authentication method to SAML (Azure in this case), Log in with new user with pre-existing anomality detectors
Click on Anomaly detection on sidebar
Click on Detectors
Click on one of Detectors created
Anomality overview click on Edit alert settings
Click on Edit
Do not make any changes and click on Update at the bottom

Expected behavior
Should be able to successfully edit
Plugins
SAML Authentication from Opensearch AWS console enabled
Host/Environment (please complete the following information):

OS: Windows 11, Edge
Version 2.3 (Latest on AWS)

@lehmat We would need a more information to know if there is a bug.  AD uses the username to populate the ownership field on the detector, if the internal name != the saml name this would be expected behavior.
If they are the same, then we would need a copy of the detector document and GET _plugins/_security/api/account result of to understand the nature of the bug.

Hi,
I can tell this without querying the API. The internal username used to be shortname (for example lehmat) and AD is an email address.
Is there any steps I could take to manually fix them or is recreating them only option?

I'm going to transfer this issue to the repo of the plugin they might be able to give you advice on how to make the change.


global_cmvn in fine-tuning

Hi, when using fine-tuning, does global_cmvn need to be recalculated with historical data?

solved?


[TACHYON-919] Fix "mvn site" warnings and errors

This PR:

fixes a large number of "mvn site" warnings and errors (missing / incorrect @param and @throws descriptions)
applies a consistent style to JavaDoc
restricts the access to private members only to test classes where applicable

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4674/
Test PASSed.

Thanks for the patch! It looks good in general. One question:
is the way using class PrivateAccess a standard practice to access private members in tests?

I think standard practice is to use the following idiom: http://stackoverflow.com/questions/182278/is-there-a-way-to-simulate-the-c-friend-concept-in-java. However, since our "main" sources cannot have a compile time dependency on our "test" sources (which is what would be needed to apply that idiom directly). I introduced the Tester interface.
The purpose of doing this is to avoid accidental use of (previously) public API that is only meant for unit testing. I have indeed come across methods that said "only for unit testing" in their JavaDoc and yet they were invoked by non-test code.

@jsimsa Could you resolve the merge conflicts please?

Addressed comments and resolved merge conflicts. PTAL

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4816/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4817/
Test FAILed.

Jenkins, test this please.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4821/Build result: FAILURE[...truncated 2471 lines...][JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/s3/target/tachyon-underfs-s3-0.8.0-SNAPSHOT.jar to org.tachyonproject/tachyon-underfs-s3/0.8.0-SNAPSHOT/tachyon-underfs-s3-0.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/s3/target/tachyon-underfs-s3-0.8.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-underfs-s3/0.8.0-SNAPSHOT/tachyon-underfs-s3-0.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/s3/target/tachyon-underfs-s3-0.8.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-underfs-s3/0.8.0-SNAPSHOT/tachyon-underfs-s3-0.8.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/pom.xml to org.tachyonproject/tachyon-clients/0.8.0-SNAPSHOT/tachyon-clients-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/pom.xml to org.tachyonproject/tachyon-client-unshaded/0.8.0-SNAPSHOT/tachyon-client-unshaded-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/target/tachyon-client-unshaded-0.8.0-SNAPSHOT.jar to org.tachyonproject/tachyon-client-unshaded/0.8.0-SNAPSHOT/tachyon-client-unshaded-0.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/target/tachyon-client-unshaded-0.8.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-client-unshaded/0.8.0-SNAPSHOT/tachyon-client-unshaded-0.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/target/tachyon-client-unshaded-0.8.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-client-unshaded/0.8.0-SNAPSHOT/tachyon-client-unshaded-0.8.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/servers/pom.xml to org.tachyonproject/tachyon-servers/0.8.0-SNAPSHOT/tachyon-servers-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/pom.xml to org.tachyonproject/tachyon-underfs-hdfs/0.8.0-SNAPSHOT/tachyon-underfs-hdfs-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/target/tachyon-underfs-hdfs-0.8.0-SNAPSHOT.jar to org.tachyonproject/tachyon-underfs-hdfs/0.8.0-SNAPSHOT/tachyon-underfs-hdfs-0.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/target/tachyon-underfs-hdfs-0.8.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-underfs-hdfs/0.8.0-SNAPSHOT/tachyon-underfs-hdfs-0.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/target/tachyon-underfs-hdfs-0.8.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-underfs-hdfs/0.8.0-SNAPSHOT/tachyon-underfs-hdfs-0.8.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/pom.xml to org.tachyonproject/tachyon-parent/0.8.0-SNAPSHOT/tachyon-parent-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/dependency-reduced-pom.xml to org.tachyonproject/tachyon-client/0.8.0-SNAPSHOT/tachyon-client-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/target/tachyon-client-0.8.0-SNAPSHOT.jar to org.tachyonproject/tachyon-client/0.8.0-SNAPSHOT/tachyon-client-0.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/target/tachyon-client-0.8.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-client/0.8.0-SNAPSHOT/tachyon-client-0.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/target/tachyon-client-0.8.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-client/0.8.0-SNAPSHOT/tachyon-client-0.8.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/shell/pom.xml to org.tachyonproject/tachyon-shell/0.8.0-SNAPSHOT/tachyon-shell-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.tachyonproject/tachyon-underfs-glusterfs/0.8.0-SNAPSHOT/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/target/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT.jar to org.tachyonproject/tachyon-underfs-glusterfs/0.8.0-SNAPSHOT/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/target/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-underfs-glusterfs/0.8.0-SNAPSHOT/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/target/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-underfs-glusterfs/0.8.0-SNAPSHOT/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT-javadoc.jarchannel stopped
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4822/
Test PASSed.

Resolved conflicts. PTAL

@jsimsa A high level comment about the javadoc, it seems weird to see @throws paired with past tense, is this the recommended convention?

@jsimsa Really appreciate the PrivateAccess approach to provide access to private members/methods. I agree with @calvinjia that this model should be applied in general in this codebase. So for this PR, we may not include this change but only the document fixes, and leave that testing improvement in a separate PR with properly created new JIRA ticket.

+1 to the PrivateAccess model. Indeed an elegant solution.

Addressed all your comments. PTAL

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4849/
Test PASSed.

+1 LGTM


What is v value in tracker?

Can you show me or explain about v value in tracker. If I set max_age > 0 i receive error

v is the velocity. You can simply make v = [0, 0] or v = [- tracking[0] * hyper_parameter, - tracking[1] * hyper_parameter]. v = [0, 0] works well for me.

Thanks a lot!


Move cypress integration from bigtest repository

Motivation
https://github.com/thefrontside/bigtest/issues/981
Approach
WIP

The preview packages of this pull request have been published.
Click on the following packages for instructions on how to install them:
@interactors/html

Install using the following command:
$ npm install @interactors/html@with-cypress

Or update your package.json file:
{
  "@interactors/html": "with-cypress"
}

@interactors/with-cypress

Install using the following command:
$ npm install @interactors/with-cypress@with-cypress

Or update your package.json file:
{
  "@interactors/with-cypress": "with-cypress"
}

interactors-sample

Install using the following command:
$ npm install interactors-sample@with-cypress

Or update your package.json file:
{
  "interactors-sample": "with-cypress"
}

  Generated by :no_entry_sign: dangerJS against cb8f5231b57c565d6e0dd2703fb60f8866e86f50


Edit setup and requirements

Coverage increased (+0.14%) to 36.53% when pulling 94e0a74b4d41c495d36f86740c71c139f77c5f1e on AlexMathew:scrapple into f7e52720718530c45004d0a46c29909ee46d92c1 on scrappleapp:master.


nixos-container: support user-defined extra binds

in this pull request, I implemented a new feature of declarative nixos-container, user-defined extra binding directories, in addition to /nix/store, /nix/var...
This function enables data communication between host and containers, and the host effectively works as nfs server and containers works as nfs clients. It is quite useful for developing multiple server deployment on a single machine.
A directory in the host can be bound to a directory in the container as specified in the extraBinds attribute, whose value is a list of binding specifications. Each binding specification has host, container and isReadOnly attributes. host is the host directory, container is the directory mounted in the container and isReadOnly is a boolean attribute specifying whether the directory in the container will be read-only or not.
The following is some example container setup in /etc/nixos/configuration.nix
containers.foo =
    { privateNetwork = true;
      hostAddress = "<IP_ADDRESS>";
      localAddress = "<IP_ADDRESS>";
      autoStart = true;
      extraBinds = [ { host="/home/wavewave/www";
                       container="/webroot";
                       isReadOnly = true; }
                     { host="/home/wavewave/temp";
                       container="/home/wavewave/temp";
                       isReadOnly = false; }
                   ];
      config =
        {config, pkgs, ...}:
        { networking.firewall.enable = false;
          services.openssh.enable = true;
          services.lighttpd = {
            enable = true;
            document-root = "/webroot";
          };
        };
    };

This looks very appealing, thanks! :+1:
This isn't actually using bind mounts, right? The filesystem namespacing takes care of the binding transparently?

Can we just have extraFlags? Because that's what it is.

Can you make it an attribute set (like e.g. fileSystems)? E.g.
bindMounts."/webroot" =
  { hostPath = "/home/wavewave/www";
    isReadOnly = true;
  };

In fact, maybe this should just piggy-back on fileSystems, e.g.
fileSystems."/webroot".hostPath = "/home/wavewave/www";

@edolstra I've renamed extraBinds to bindMounts and changed the syntax from a list to an attribute set like fileSystems as you suggested. Ideally, to incorporate this into fileSystems is a good idea, but it's too intrusive change for me as a nixos newbie to proceed ;-)
@copumpkin This is using the --bind or --bind-ro option of systemd-nspawn, which I think uses mount --bind internally. I am not sure though.
@lethalman Using extraFlags was the very first idea I actually tried. At least, the current nixos code that deal with extraFlags need to be changed, and I think that this feature is quite good for generic purpose, so I separated it out. Still, additional support for user-defined extraFlags should be good for some expert usage.

Now in /etc/nixos/configuration.nix, one can specify bindMounts like the following.
Note that hostPath can be omitted if it is intended to be the same as the mounted path inside the container.
containers.foo =
    { privateNetwork = true;
      hostAddress = "<IP_ADDRESS>";
      localAddress = "<IP_ADDRESS>";
      autoStart = true;
      bindMounts = { "/webroot" = {
                       hostPath="/home/wavewave/www";
                       isReadOnly = true;
                     };
                     "/home/wavewave/temp" = {
                       isReadOnly = false;
                    };
                  };
      config =
        {config, pkgs, ...}:
        { networking.firewall.enable = false;
          services.openssh.enable = true;
          services.lighttpd = {
            enable = true;
            document-root = "/webroot";
          };
        };
    };

@wavewave why current code needs to be changed? Instead of having that length bindMounts option, just pass flags directly. Like you are doing with bindMounts, except without a special format.

@lethalman Having a dedicated, typed option is user-friendlier, and independent from the container implementation (i.e. we could replace systemd-nspawn with something else).

@lethalman currently extraFlags is not an option for a container afaik. So we need to make that as an option?
$  sudo nixos-rebuild switch -I nixpkgs=~/repo/srcc/nixpkgs
building Nix...
building the system configuration...
error: The option `containers.foo.extraFlags' defined in `/etc/nixos/configuration.nix' does not exist.
(use ‘--show-trace’ to show detailed location information)

@edolstra changed as you suggested in the code comments.

Ping.

I updated the branch to be compatible with the latest master. Please let me know if something is needed to be accepted.

I think it's ok, except this systemd template system is preventing yet another useful feature: we cannot RequireMountsFor the extra binds :(

@lethalman  do you mean

"I consider this PR ready to merge, and in the future I would like see an addition that integrates better with RequireMountsFor"

or do you mean

"There is an issue with RequireMountsFor that needs to be fixed before this PR can proceed"

?
I ask because I (and others, I guess) want this functionality to land. I'm about to cherry-pick this change to my local nixpkgs checkout but of course I'd prefer to have the "officially merged" version

Any update on this?

I think it's ok, except this systemd template system is preventing yet another useful feature: we cannot RequireMountsFor the extra binds :(

It seems that #3021 implements a unit per container, could that help with this problem?

Is there anything for me to do to push this forward? I hope that this feature will land well...

@wavewave no let's just merge. Thanks.

@wavewave does this help imperative containers at all or do those not follow this code path at all?


Ttmenezes/main

Proposed Changes:

Add kwargs to enable semantic ranking in retrievers.
Small fixes

How did you test it?
Ran the tests
Notes for the reviewer

Checklist

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 5 committers have signed the CLA.:white_check_mark: ttmenezes:white_check_mark: rblst:white_check_mark: Amnah199:x: sjrl:x: HaystackBotYou have signed the CLA already but the status is still pending? Let us recheck it.


runtime/vm/os_thread_linux.cc: 264: error: pthread error: 16 (Device or resource busy)

root@5af831c338c0:/app/fhir_client# echo "main() => print('hello');" > test.dart && dart test.dart
hello
runtime/vm/os_thread_linux.cc: 264: error: pthread error: 16 (Device or resource busy)
Aborting re-entrant request for stack trace.
Aborted (core dumped)

Whenever I run any Dart program on my local machine within Docker.
When I deploy the same Docker image to GCloud I don't get this error.
I updated to the latest Docker version
Docker version 1.13.0, build 49bf474f9

but no change.
See also https://github.com/dart-lang/sdk/issues/24222

Before I updated my Docker version was 1.11.2

@zoechi could you get us a core dump or at least run it under the gdb and send us output of thread apply all bt

How do I create a core dump? Some basic instructions about how to use gdb?
Never really used gdb.

For gdb, you can use gdb --args dart hello.dart
The commands you need are run and after the crash thread apply all bt to print stack traces of all threads.
To get a core file from the command line, the core file size limit should be set to unlimited for the current shell you're running in: ulimit -c unlimited will do that.

Installing gdb fixes the problem :grimacing:

I'm using the Docker image FROM google/dart

I was able to get this core file. It was created automatically when I run the dart script.
Hope this helps.
core.zip

I have a similar issue running pub in a Docker container.
Precompiling dependencies...
Loading source assets...
Loading di/module_transformer transformers...
runtime/vm/os_thread_linux.cc: 265: error: pthread error: 16 (Device or resource busy)
Aborting re-entrant request for stack trace.
Aborted

I'm using Docker 1.13.0 on MacOS Sierra FROM google/dart-runtime-base
I tried using versions 1.21.1 down to 1.19.1

I managed to get pub complete successfully using FROM google/dart instead. Precompilation for some dependencies still fails, but the application starts and seems to be working correctly.

I use ; exit 0 to prevent docker build to fail
RUN pub upgrade --packages-dir; exit 0

pub upgrade and other Dart scripts, run fine, just when it exits it throws the exception.

We tried reproducing it locally without success.
Here are thread stacks @zoechi got for me from his core running gdb inside the container:
(gdb) thread apply all bt

Thread 5 (LWP 10):
#0  0x00007ffa557fa438 in pthread_cond_timedwait@@GLIBC_2.3.2 () at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:287
#1  0x00000000007f2df0 in dart::Monitor::Wait(long) ()
#2  0x000000000090d6a8 in dart::ThreadPool::Worker::Loop() ()
#3  0x000000000090d79f in dart::ThreadPool::Worker::Main(unsigned long) ()
#4  0x00000000007f2106 in ?? ()
#5  0x00007ffa557f60a4 in start_thread (arg=0x7ffa54615700) at pthread_create.c:403
#6  0x00007ffa548fd04d in __libc_ifunc_impl_list (name=<optimized out>, array=0x7ffa54615700, max=<optimized out>) at ../sysdeps/x86_64/multiarch/ifunc-impl-list.c:172
#7  0x0000000000000000 in ?? ()

Thread 4 (LWP 8):
#0  0x00007ffa548fd623 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:104

Thread 3 (LWP 11):
---Type <return> to continue, or q <return> to quit---
#0  0x00007ffa557ff201 in __lll_lock_elision (futex=0x2667350, adapt_count=0x2667366, private=0) at ../nptl/sysdeps/unix/sysv/linux/x86/elision-lock.c:74
#1  0x00000000006ec51e in dart::FreeList::TryAllocate(long, bool) ()
#2  0x00000000007f4055 in dart::PageSpace::TryAllocateInternal(long, dart::HeapPage::PageType, dart::PageSpace::GrowthPolicy, bool, bool) ()
#3  0x00000000006f06c1 in dart::Heap::AllocateOld(long, dart::HeapPage::PageType) ()
#4  0x000000000078ba67 in dart::Object::Allocate(long, long, dart::Heap::Space) ()
#5  0x000000000078bca8 in ?? ()
#6  0x00000000007ae241 in dart::Array::Grow(dart::Array const&, long, dart::Heap::Space) ()
#7  0x00000000007ae4af in dart::ICData::FindFreeIndex(long*) const ()
#8  0x00000000007b9a44 in dart::ICData::AddReceiverCheck(long, dart::Function const&, long) const ()
#9  0x000000000094e22f in ?? ()
#10 0x0000000000952e3c in dart::DRT_InlineCacheMissHandlerOneArg(dart::NativeArguments) ()
#11 0x00007ffa55a9f47b in ?? ()
#12 0x00000000039cdb00 in ?? ()
#13 0x0000000000000002 in ?? ()
#14 0x00007ffa53cdf048 in ?? ()
---Type <return> to continue, or q <return> to quit---
#15 0x00007ffa53cdf050 in ?? ()
#16 0x00007ffa55ae1551 in ?? ()
#17 0x00007ffa55ae2511 in ?? ()
#18 0x00007ffa53cdf078 in ?? ()
#19 0x00007ffa55aa0768 in ?? ()
#20 0x00007ffa539a98a1 in ?? ()
#21 0x00007ffa540ebec9 in ?? ()
#22 0x0000000000000000 in ?? ()

Thread 2 (LWP 9):
#0  0x00007ffa557fa438 in pthread_cond_timedwait@@GLIBC_2.3.2 () at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:287
#1  0x00000000007f2ec0 in dart::Monitor::WaitMicros(long) ()
#2  0x000000000090c74c in dart::ThreadInterrupter::ThreadMain(unsigned long) ()
#3  0x00000000007f2106 in ?? ()
#4  0x00007ffa557f60a4 in start_thread (arg=0x7ffa54816700) at pthread_create.c:403
---Type <return> to continue, or q <return> to quit---
#5  0x00007ffa548fd04d in __libc_ifunc_impl_list (name=<optimized out>, array=0x7ffa54816700, max=<optimized out>) at ../sysdeps/x86_64/multiarch/ifunc-impl-list.c:172
#6  0x0000000000000000 in ?? ()

Thread 1 (LWP 7):
#0  0x00007ffa5484c107 in __GI_qsort (b=<optimized out>, n=<optimized out>, s=<optimized out>, cmp=<optimized out>) at msort.c:307
#1  0x00007ffa5484d4e8 in __initstate (seed=<optimized out>, arg_state=<optimized out>, n=<optimized out>) at random.c:245
#2  0x0000000000000000 in ?? ()
(gdb)

Notice that Thread 1 stack trace (one that crashed) makes 0 sense.

Still seeing this in the google/dart container.
Setup

I've mounted a volume from the host->container so that I can edit files using an IDE, but run them in the container (so I don't have to install dart on my host)
docker (server) version 17.05.0-ce
dart version (that came with the container) D1.24.2 (Thu Jun 22 15:42:21 2017) on "linux_x64"

Program that causes this
simple program:
root@eeebbc1209df:/# cat /dart/hello/hello.dart
void main() {
  print('Hello, World!');
}

Output from executing this program
root@eeebbc1209df:/# dart /dart/hello/hello.dart
Hello, World!
../../runtime/vm/os_thread_linux.cc: 284: error: pthread error: 16 (Device or resource busy)
Aborting re-entrant request for stack trace.
Aborted (core dumped)

Backtrace
(gdb) thread apply all bt

Thread 5 (Thread 0x7f3b14562700 (LWP 10)):
#0  0x00007f3b15342438 in pthread_cond_timedwait@@GLIBC_2.3.2 () from /lib/x86_64-linux-gnu/libpthread.so.0
#1  0x0000000000ab8f3f in dart::Monitor::WaitMicros(long) ()
#2  0x0000000000c06f7f in dart::ThreadInterrupter::ThreadMain(unsigned long) ()
#3  0x0000000000ab8619 in ?? ()
#4  0x00007f3b1533e0a4 in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
#5  0x00007f3b1464904d in clone () from /lib/x86_64-linux-gnu/libc.so.6

Thread 4 (Thread 0x7f3b143a1700 (LWP 11)):
#0  0x00007f3b15342438 in pthread_cond_timedwait@@GLIBC_2.3.2 () from /lib/x86_64-linux-gnu/libpthread.so.0
#1  0x0000000000ab8f3f in dart::Monitor::WaitMicros(long) ()
#2  0x0000000000c07d3d in dart::ThreadPool::Worker::Loop() ()
#3  0x0000000000c07b5a in dart::ThreadPool::Worker::Main(unsigned long) ()
#4  0x0000000000ab8619 in ?? ()
#5  0x00007f3b1533e0a4 in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
#6  0x00007f3b1464904d in clone () from /lib/x86_64-linux-gnu/libc.so.6

Thread 3 (Thread 0x7f3b1596a700 (LWP 9)):
#0  0x00007f3b14649623 in epoll_wait () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00000000006fce45 in dart::bin::EventHandlerImplementation::Poll(unsigned long) ()
#2  0x0000000000718f3e in ?? ()
#3  0x00007f3b1533e0a4 in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
#4  0x00007f3b1464904d in clone () from /lib/x86_64-linux-gnu/libc.so.6

Thread 2 (Thread 0x7f3b13a30700 (LWP 12)):
#0  0x00000000009c7820 in ?? ()
#1  0x0000000000965b39 in dart::EffectGraphVisitor::VisitArrayNode(dart::ArrayNode*) ()
#2  0x0000000000966133 in dart::EffectGraphVisitor::VisitStringInterpolateNode(dart::StringInterpolateNode*) ()
#3  0x0000000000967be7 in dart::EffectGraphVisitor::BuildPushArguments(dart::ArgumentListNode const&, dart::ZoneGrowableArray<dart::PushArgumentInstr*>*) ()
#4  0x00000000009687e1 in dart::EffectGraphVisitor::VisitStaticCallNode(dart::StaticCallNode*) ()
#5  0x000000000097379b in dart::EffectGraphVisitor::VisitSequenceNode(dart::SequenceNode*) ()
#6  0x000000000097379b in dart::EffectGraphVisitor::VisitSequenceNode(dart::SequenceNode*) ()
#7  0x00000000009763d2 in dart::FlowGraphBuilder::BuildGraph() ()
#8  0x00000000008d41f7 in dart::DartCompilationPipeline::BuildFlowGraph(dart::Zone*, dart::ParsedFunction*, dart::ZoneGrowableArray<dart::ICData const*> const&, long) ()
#9  0x00000000008d685f in dart::CompileParsedFunctionHelper::Compile(dart::CompilationPipeline*) ()
#10 0x00000000008d81ce in ?? ()
#11 0x00000000008d7c08 in dart::Compiler::CompileFunction(dart::Thread*, dart::Function const&) ()
#12 0x00000000008d4487 in dart::DRT_CompileFunction(dart::NativeArguments) ()
#13 0x00007f3b157ea61b in ?? ()
#14 0x0000000003291b00 in ?? ()
#15 0x0000000000000001 in ?? ()
#16 0x00007f3b13a2f0b0 in ?? ()
#17 0x00007f3b13a2f0b8 in ?? ()
#18 0x00007f3b1582c661 in ?? ()
#19 0x00007f3b1582d901 in ?? ()
#20 0x00007f3b13a2f0d8 in ?? ()
#21 0x00007f3b157ea690 in ?? ()
#22 0x00007f3b13b980f1 in ?? ()
#23 0x00007f3b13768941 in ?? ()
#24 0x00007f3b1582cc81 in ?? ()
#25 0x00007f3b137689b1 in ?? ()
#26 0x00007f3b1582d9b1 in ?? ()
#27 0x00007f3b13a2f118 in ?? ()
#28 0x00007f3b137c7aa0 in ?? ()
#29 0x00007f3b13e48dd9 in ?? ()
#30 0x00007f3b13e3be49 in ?? ()
#31 0x00007f3b13e3f2e9 in ?? ()
#32 0x00007f3b1582a021 in ?? ()
---Type <return> to continue, or q <return> to quit---
#33 0x00007f3b13a34621 in ?? ()
#34 0x00007f3b13768a21 in ?? ()
#35 0x00007f3b13a2f150 in ?? ()
#36 0x00007f3b13b459f8 in ?? ()
#37 0x00007f3b13e48dd9 in ?? ()
#38 0x00007f3b13e3f2b9 in ?? ()
#39 0x00007f3b1582c631 in ?? ()
#40 0x00007f3b13a34211 in ?? ()
#41 0x00007f3b13a34681 in ?? ()
#42 0x00007f3b13a2f190 in ?? ()
#43 0x00007f3b13b45907 in ?? ()
#44 0x00007f3b13e48dd9 in ?? ()
#45 0x00007f3b13e3f2b9 in ?? ()
#46 0x00007f3b1582c631 in ?? ()
#47 0x00007f3b1582a021 in ?? ()
#48 0x0000000000000000 in ?? ()

Thread 1 (Thread 0x7f3b1596c780 (LWP 8)):
#0  0x00007f3b14598107 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007f3b145994e8 in abort () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x0000000000ab7d79 in dart::OS::Abort() ()
#3  0x000000000084772b in dart::DynamicAssertionHelper::Fail(char const*, ...) ()
#4  0x0000000000ab89e9 in dart::Mutex::~Mutex() ()
#5  0x00000000009f8cf9 in dart::Isolate::~Isolate() ()
#6  0x000000000090e401 in dart::Dart::ShutdownIsolate() ()
#7  0x000000000082328f in Dart_ShutdownIsolate ()
#8  0x00000000006f65e7 in dart::bin::RunMainIsolate(char const*, dart::bin::CommandLineOptions*) ()
#9  0x00000000006f7aaf in dart::bin::main(int, char**) ()
#10 0x00000000006f7ef9 in main ()
(gdb) q

I still have a similar problem when running pub get && pub build with google/dart... :confused:

We need to understand which mutex is being destroyed. Unfortunately stack traces don't really help - because line information is stripped.
I added some debug information in this CL: https://dart-review.googlesource.com/c/sdk/+/4721
If somebody could build custom dart binary with this patch and try it out that would help a lot.

Currently working around this by adding --no-precompile flag to pub get.

I have similar error when executing pub run test
pub run test

00:00 +0: loading test/util_test.dart
00:00 +0: loading test/util_test.dart
time is 11:54:AM
1970-01-01 11:54:00.000
1970-01-01 11:54:00.000
No tests ran.
../../runtime/vm/os_thread_linux.cc: 284: error: pthread error: 16 (Device or resource busy)

@muzuro The problem occurs when a dart program is running, and since pub is written in dart, it is affected as well. Try to use the 1.25-dev version. It might fix the problem.

I guess this can be closed. If someone sees this. Please add a comment to have it reopened or create a new one an link here.


fix: Set latitude and longitude on event creation

Fixes #1689

Use a map picker than this please

@iamareebjamal It is already there but hidden because Google Places API key needs to be added.

OK, I'll add that. You verify that it's working on your personal jey

@iamareebjamal The code seems good to me. I couldn't verify it since using Places API key requires to set up billing.

It allows 1 query per day for free

Yes, but it still requires to set up billing before using. I had generated a key and tried using it but the map opens and then closes instantly and logs show:
Places API for Android does not seem to be enabled for your app.

OK, I'll give you a key on personal chat on gitter tomorrow

@iamareebjamal Place Picker is deprecated and cannot be used now: https://stackoverflow.com/a/55524719
Should we use Places Autocomplete instead?

No need for autocompletion right now. We can come back to it later. Just lat and lon are important.

@mariobehling #1737 fixes this. Hence, this can be closed.


Add and support "memory" vdisk storage type

Disk type
Redundant
Persistent
Template Support
Rollback
Performance Optimized

memory
no
no
no
no
yes

Not sure what performance optimized means in this context.
However the rest of the information seems that we could simply use the newly added InMemoryStorage for this. A simple pure-go in-memory storage implementation to be found here: nbdserver/ardb/inmemory.go.
It's a vdisk that will lose its content as soon as the user disconnects from the nbdserver, which I think is what persistent means in this context.
It doesn't supportrollback, meaning we won't be using it in combination with the tlog- storage/server/client.
So with that knowledge in mind, we simply have to:

add the memory vdisk type to the config code, such that it can be used from the configuration files;
add a new memory storage type, that for now only will be used for the memory vdisk type;
add a new switch case for the memory storage type in the ardb.go code, where we create the inMemoryStorage, for such vdisks that have the memory storage type;
add unit-test code that reflect these changes;

Not required by any project and never formally specified.


Please add support for rereading the current file when jumping to the end

In less when jumping to the end of the file via END or G the file is also reread. That is very handy when viewing logfiles that grow while viewing them.
For example,

open a logfile
press G or END to jump to the end of the file
…
press G or END again

The second invocation (and in fact also the first invocation) would also display lines that were added to the file after step 2 (the first jump to the files end).

I think this is a good idea. :+1:
I would like to implement it eventually, but I don't know if it's still a problem.

I would have thought that the actual rereading of the file would be easily solved (as I tried in #33):
  root.Doc.ReadFile(root.Doc.FileName)
  root.viewSync()
  root.Screen.Sync()

But it seems that this is not the case. Do you know out of your head what would be necessary for this to happen?

The current ov does not assume Reload, so it will not work as it is.
You need to initialize slice and clear the cache for it to work.
There may be other problems as well.
func (root *Root) ReRead() {
	root.Doc.lines = nil
	root.Doc.endNum = 0
	err := root.Doc.ReadFile(root.Doc.FileName)
	if err != nil {
		log.Println(err)
		return
	}
	root.Doc.ClearCache()
	root.viewSync()
}

Many thanks! This seems to work very well. I didn't find any issues with it yet.
I have taken the liberty to provide a PR for it: #34

I think I could implement it, so I'll close this issue.
Please reopen if there is a problem.


Snippets not appearing automatically

The snippets dont appear automatically but when the popup is removed and recalled using ctrl+space they appear

Same problem with clg snippet

refer https://github.com/microsoft/vscode/issues/173244

same here

In Next.js or a CRA created React project, typing "clo" works fine, but I have a React project created with Vite and in that one, typing just the first 2 characters of the snippet "cl" the "clo" snippet is shown, but if I type "clo", the snippets disappear.


Make it possible to hide the hint bar on the bottom of the screen

Thank you for writing this tool! I think it would be very useful if the bottom bar could be hidden.

Thanks for the kind words and the comment! That should be doable and I'll see about including it in the next release, which I'm hoping to get to in the next few days. Thanks again.

This feature has been released as part of v1.1.0. Thanks again for the input!


PermissionError:[Errno 13]

Hi, I'm getting this one please help:
Traceback (most recent call last):
File "/home/CloudFail/cloudfail.py", line 304, in
init(args.target)
File "/home/CloudFail/cloudfail.py", line 138, in init
update()
File "/home/CloudFail/cloudfail.py", line 246, in update
with open('data/cf-subnet.txt', 'wb') as fd:
PermissionError: [Errno 13] Permission denied: 'data/cf-subnet.txt'
Thank you

Hi, I'm getting this one please help:
Traceback (most recent call last): File "/home/CloudFail/cloudfail.py", line 304, in init(args.target) File "/home/CloudFail/cloudfail.py", line 138, in init update() File "/home/CloudFail/cloudfail.py", line 246, in update with open('data/cf-subnet.txt', 'wb') as fd: PermissionError: [Errno 13] Permission denied: 'data/cf-subnet.txt'
Thank you

Hello, friend. Did you run this with sudo?