ceph_osd_stats check fails with > 10 osd

What version (commit) do you encounter this issue on?
Kilo+
What type of issue is this (bug, feature, documentation, regression)?
bug
What is the expected behavior?
The ceph_osd_stats check is able to successfully complete with more than 10 osd
What is actually happening?
With more than 10 osd on a ceph node, the ceph_monitoring.py check will attempt to build five metrics per osd causing the check to fail due to the metrics limit of 50. It appears that we're building metrics for 'up', 'in', 'kb', 'kb_used', and 'kb_avail'. However, only metric 'up' is actually used by any current alarm criteria that is deployed up to the current Liberty release.
What were you attempting to do when you encountered this error (give as much detail as possible)? Running the ceph_osd_stats check against a ceph node with 12 osd. Check fails due to the metric limit.
How can we reproduce this issue?
Run the check on a node with >10 osd with an updated limits in maas_common.py as outlined here:
https://github.com/rcbops/rpc-openstack/issues/1180
How can we verify your issue is addressed?
Limit number of metrics allowing the check to pass. Potentially only building metrics against the values which are being used in alarm criteria.
What is your evaluation on the importance of this issue, and why?
Unable to effectively monitor ceph osd's
What branches / milestones do you believe this issue should target?
The list below is what is currently supported for backports
Remove branches (lines) you do not wish to target.

[ ] Master
[ ] liberty-12.2
[ ] kilo

DocImpact: This section is to be completed by the issue owner as part of the issue's resolution.
Does your change require documentation?

[ ] No documentation required for this change

Given that we are primarily focused on monitoring with these plugins, rather than gathering arbitrary metrics for capacity planning (appformix is targeted at that), I would advocate removing those things that we are not alerting on.

@npawelek to add further details.

We generate 5 metrics per ceph OSD in the environment and we're only evaluating against 1, whether it's 'up' or not. Due to current metric limit of 50, when we deploy accounts with more than 10 ceph OSD, these checks will fail post-deploy. The deployment workaround is to comment out some of the unused metrics to allow evaluation of the checks once it's handed over to the customer. This typically results in commenting out the following lines where metrics are generated.
for key in ('kb', 'kb_used', 'kb_avail'):
name = '_'.join((osd_ref, key))
maas_common.metric(name, 'uint64', osd[key])

@Frank-ZhangXin worked with @mattt416 yesterday to build an AIO with more than the default number of OSD.

@mattt416 AIO with ceph is completed, but I wonder how we manually add more osd to one single osd node? Thanks

@Frank-ZhangXin, if your AIO is already deployed, update /etc/openstack_deploy/user_rpco_variables_overrides.yml from:
osd_directories:
  - /var/lib/ceph/osd/mydir1

to:
osd_directories:
  - /var/lib/ceph/osd/mydir1
  - /var/lib/ceph/osd/mydir2
  - /var/lib/ceph/osd/mydir3
  - /var/lib/ceph/osd/mydir4
  - /var/lib/ceph/osd/mydir5
  - /var/lib/ceph/osd/mydir6
  ...

After that, you'll need to re-run ceph-osd.yml.

Having issues with re-setup ceph afterward AIO deployment. Working with @mattt416 now.

Update:
This bug is verified in master and can be reproduced. MaaS did send warning about exceed 50 metrics per OSD host.

@git-harry Here's the cause of this bug: https://github.com/rcbops/rpc-openstack/blob/master/maas/plugins/ceph_monitoring.py#L73-L83
(5 different attributes: "up, in, kb, kb_used, kb_avaiblable")
Five different metrics normally are added to one OSD and MaaS side require maximum number of metrics won't be more than 50.
I don't know if every attribute really need a metric necessarily. Need advice, thanks.

@npawelek @Frank-ZhangXin
I think we could reduce the metrics collected to "up & kb_available" then we can figure out a threshold for kb_available and implement an alarm for that.  I think we should alarm when ceph is running out of space?  Nathan, what are your thoughts?

@russwclark
It would be OK with me if 'up' and 'kb_available' two are enough for metric. Looks Nathan is out today, but I'm gonna make a PR with this idea.

@rcbops/support-feedback Feedback on this issue appreciated if Nathan is out for the next couple of days.

@Frank-ZhangXin I apologize for the delay.
I'm fairly certain that we deploy file system disk space used checks/alarms for OSD mount points on ceph nodes. As such, I don't think it's necessary to retain anything other than the 'up' metric which is what we're alarming on. I'd rather limit the potential to hit the cap as I can see more than 25 ceph nodes being deployed in an environment.
Let me know if you have any additional questions or concerns.

@npawelek bear in mind, though, that when the plugin is called on any particular host, it will only be passed the IDs of the OSDs on that host (because of the way the maas template is constructed). So you aren't limited by the number of ceph storage nodes in an environment (or total OSDs in an environment which is what I think you were saying), but rather by the number of OSDs on an individual host. 25 in that case is probably plenty.
Having said that, your logic is sound if we already monitor the disk space on the mounts, and I'm all for removing redundant metrics, so just looking at 'up' still seems like a good suggestion to me.

@mancdaz Correct, thanks for clarifying that

@npawelek hey, Nathan, is it necessary still backport to Kilo?

@Frank-ZhangXin, the original bug description does mention it's also a problem with Kilo environments. I think it would be a good idea to backport this to Kilo.

FYI, in the past a back port was turned down since it's a change of the default behavior. I would have loved to get this addressed ASAP but we couldn't

@Frank-ZhangXin why has this been moved to 'status-pending-sha-update'?

@alextricity25 got it, will do soon
@git-harry sorry, that was a mistake and I should move it to done column.


[Feature request] Supercharge links in File Explorer (official plugin)

Thank you for a great plugin!
My request should be self-explanatory. Is there any way the files in the File Explorer list could be supercharged as well? Extra gratitude for a toggle in the settings for people who only want to see links supercharged only in one those 2 instances.

I might try and take this on for this PR https://github.com/mdelobelle/obsidian_supercharged_links/pull/37

@HEmile
This is amazing! Thank you so much for such a massive amount of work!
@mdelobelle
Thank you for approving the change and merging it!


"Uncaught ReferenceError: React is not defined" when using Router

I'm getting Uncaught ReferenceError: React is not defined when running the below code. I'm not sure why React is in the equation here. What am I missing about how this works?
import { Router, pathIntegration } from '@rturnq/solid-router';

const Root = () => {
  return (
    <Router integration={pathIntegration()}>

App

    </Router>
  );
};

export default Root;

Versions:
"@rturnq/solid-router": "^0.2.6",
"solid-js": "^0.26.5",

Thanks!

You code looks fine. Are you using Vite?
Assuming this is the case. Vite uses esbuild to pre-build dependencies as an optimization. By default esbuild treats any JSX it encounters as React and converts it to React.createElement calls. Vite excludes dependencies it knows have JSX but only does so by looking at the extension of the entry file which doesn't work in this case. It does have a workaround though by manually excluding the library using the optimizeDeps.exclude config option.
// vite.config.js
export default defineConfig({
  ...
  optimizeDeps: {
    exclude: ['@rturnq/solid-router'],
  }
});

I am using Vite and your suggested fix works!
Is this in the docs somewhere? I just took a look and wasn't able to find this information.
Thank you!

There is now https://github.com/rturnq/solid-router/commit/ffa31c845966d351e211673456d117a03846261c


Add IsMemberOf to the set of filters

Add IsMemberOf to the set of filters

Please provide an update to the README.md with docs for this feature.


Runtime exception: 'Namespace' object has no attribute 'cilium_labels'

Reported in Slack:
https://cilium.slack.com/archives/C1MATJ5U5/p1572261217223400?thread_ts=1572259123.221800&cid=C1MATJ5U5

I got the following error when running the cluster-diagnosis.zip

Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "cluster-diagnosis.zip/__main__.py", line 97, in <module>
AttributeError: 'Namespace' object has no attribute 'cilium_labels'

It seems https://github.com/cilium/cluster-diagnosis/commit/77bb31aef5a2e707d2cea2e6f00d8872610eaca7 broke cluster-diagnosis


Manager button disappeared with recent updates

Thanks for making this!
The manager button disappeared with the newest updates. I checked out bd829bfe856bc6ec63bcbf4ba0e3cfb485d32d25 and it reappeared.

I cannot reproduce your issue; the code here also does not modify anything in the js related to the manager button or otherwise. I'd recommend updating your ComfyUI Manager.


Daily Water Intake Calculator

Calculator Functions
Description
This calculator helps you determine approximately the amount of water you must drink each day to avoid dehydration. However, this is only an estimate and the actual amount one needs depends on several factors like exercise, illness and fluid content in dietary intake.
Contribution Event
GSSOC22
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


Platform changer

Added feature that can change your platform / client version as described in https://github.com/ReSpeak/TS3Hook/issues/17

@Najsr There's one small issue.
When you send a textmessage with just the content clientinit TS3Hook does this:
[OUT] sendtextmessag3.?.?\s[Build:\s5680278000]
[IN ] error id=256 msg=command\snot\sfound

@Najsr another user (@SossenSystems) pointed out that the platform changer will revert the output_muted status to 0 when connecting so you're no longer muted.


1.10 - Crash when viewing an item recipe with inventory panel GUI open

Crash log: http://pastebin.com/iuYgEM1D
Setup:
Screen:
To reproduce, just hover over an item in your inventory and press 'R'

Panel offline, no item database to check availability against...
Fixed in next build


Watch window does NOT show vector data correctly in Google Test debug session.

This does NOT happen in Console application debug session:

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.91.1
OS Version: Ubuntu 24.04

Steps to Reproduce:

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!

https://github.com/matepek/vscode-catch2-test-adapter/issues/439 mentions it is not due to extension but VSCode debugger!?!


Where is the resulting graph of the program running

May I ask where the result diagram of your program is drawn?Seems not to see the corresponding code, run your program only a few lines of data out。

Which result diagram? Visualization in README?

I have the same question. How can I get the result diagram in README.

哪个结果图？在README中可视化？

yes

yes I haven't seen the code to produce the picture

Yes, I have the same question


add knuff

and looks like ans-pusher has beed rename to knuff

Thank you for the contribution. It needed some fixes, so they were made in 6e1fabae1402ab7dc9e8b57f1b5374b2bcefaa61. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Updated validations py python script.

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

I fixed the code by adding this line of code:
if not username[0].isalpha():
return false


Override tokenize.ensure-deterministic config flag

Add optional parameter to tokenize(ensure_deterministic=True) to force raising exception
Can now run test_tokenize.py with either value for the config variable
Subclass RuntimeError to restrict exception catching (we're calling pickle internally, which is very complex)
Better tests for the _seen variable

@hendrikmakait @fjetter all comments have been addressed


[release-1.1] Backport 'Drop certain keys from clone annotation filters'

What this PR does / why we need it:
Manual backport of https://github.com/kubevirt/kubevirt/pull/10860
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

BugFix: Double cloning with filter fails

/lgtm
/approve

/retest


First draft of Exception handling

Please let me know if you see any red flags, i will update unit tests and MSAL next

This looks like a great start - couple of thoughts, observations, questions.
Error codes:
What do we expect developers to do with these?

If we plan to report them only in telemetry or logging, they look fine as-is
If we expect developers to display them to end users, we should consider String formatting that is more easily presented in an app (i18n, spaces not _, etc)
If we expect developers to switch on them in catch blocks, perhaps we use an enum or int (with a String descriptor)**
To make Intellisense work better, we could consider isolating these code to their own class or giving them a common prefix such that developers can 'browse' them when searching for a specific code:

public static String ERROR_DEVICE_NETWORK_UNAVAILABLE = "Device network unavailable";
public static String ERROR_MALFORMED_URL = "Malformed URL, cannot complete request";
public static String ERROR_MASHED_POTATOES_NO_GRAVY = "These potatoes have no gravy";

Exceptions & Access to Response Bodies, Headers
How do developers know when to inspect these fields?

Because network headers and response bodies are available on the base class, it's unclear when you should inspect these values (as every Exception potentially contains this payload, although practically they won't) -- would these fields/getters make more sense to expose on the ServiceException subclass?
SocketTimeouts are indistinguishable from the default int value of 0 -- perhaps we reserve a negative value for this?

**Not that developers cannot do this with String types, but it becomes a more brittle solution depending on the rigor applied by the consuming dev. For instance:
catch (CommonCoreException e) {
    final msg = e.getMessage();

    switch (msg) {
        case CommonCoreException.ENCRYPTION_ERROR:
            // This is fine, the developer has used a constant.
            // If this *value* of this field changes later this solution continues to work
            break;
        case "decryption_error":
            // Because the developer has taken a dependency on this value
            // this code will break if it is updated later
    }
}

I am not able to reply to error codes and exceptions & access to response bodies, headers:
Great to see this being discussed, Brian, Ashish.
In general, I do not like wrapping the exceptions with a common exception type. But, since we are already here, error codes (not just the messages) are must have. Also, please include the underlying exception as innerException...

@sdabbiru The mapping to code and messages is done in ADAL, are you suggesting that CommonCore throw both errorCode and Message and ADAL picks up error code while MSAL picks up messages?

@addev-ashish : I am suggesting that the contract (between layers) should never be such that the client interprets or compares strings.

@sdabbiru i would agree but that would mean an explosion of exception classes.


Add option to disable country and postal code inputs in CardForm component

Context
I've updated @stripe/stripe-react-native package to v.0.2.0 in order to use CardForm component so that I can use a multi-line form instead of having it on one line.
Issue
I can't remove postal code input and country input.

I can see on the source code here that unlike CardField component, I cannot put postalCodeEnabled to false. Plus I can't see where to remove country field.
I saw that on line 79, you're doing ...props but even though I'm putting postalCodeEnabled to false it's not working
Code I'm using
const StripeCardForm = ({ onFormComplete }) => (
  <CardForm
    postalCodeEnabled={false}
    onFormComplete={onFormComplete}
  />
);

Solution I'd liked
Have the possibility to remove postal code input and country input.

Thanks a lot for taking your time answering my issue

@kevinhuang78 unfortunately CardForm doesn't support disabling particular fields atm, I will keep this issue open in order to track progress regarding this

At this point in the payment flow, we already asked the customer for their billing address, so asking again for country and zip code is redundant and make us look unprofessional and/or less competent.
For that reason only, this issue should be labeled as a bug.
If fields cannot be disabled at least we should be able to pre fill them. Can we do that? I didn't find any way to do it.
Thank you!

@kevinhuang78
little question that has nothing to do, how did you manage to put the label of the postal code in French?

Context
I've updated @stripe/stripe-react-native package to v.0.2.0 in order to use CardForm component so that I can use a multi-line form instead of having it on one line.
Issue
I can't remove postal code input and country input.

I can see on the source code here that unlike CardField component, I cannot put postalCodeEnabled to false. Plus I can't see where to remove country field. I saw that on line 79, you're doing ...props but even though I'm putting postalCodeEnabled to false it's not working
Code I'm using
const StripeCardForm = ({ onFormComplete }) => (
  <CardForm
    postalCodeEnabled={false}
    onFormComplete={onFormComplete}
  />
);

Solution I'd liked
Have the possibility to remove postal code input and country input.
Thanks a lot for taking your time answering my issue

+1

Hi, same for me, I don't need to ask user for country and zip, any solution ?
Another solution is to use CardField but as far I know we cannot use it with multiline (one line for card number, and next line for Code & expiration)

Hi, same for me, I don't need to ask user for country and zip, any solution ? Another solution is to use CardField but as far I know we cannot use it with multiline (one line for card number, and next line for Code & expiration)

Same here

It will resolve this issue as well.


Add Neuroglia.AsyncAPI to tooling section

Hello everyone,
I followed the link to add tooling on https://www.asyncapi.com/docs/community/tooling, and landed here.
I would like, if possible, to add my Apache 2.0 licensed .NET 5.0 project.
For now, the libs provide ways to:

[x] Read, parse and validate a YAML or JSON AsyncAPI document
[x] Build an AsyncAPI document programatically using fluent builders
[ ] Create at runtime an AsyncApiMessageBus based on an AsyncAPI document (WIP)

Hi! Could you describe your tool, few sentences like for another tools in mentioned link in our site, and add info for which section we should add Neuroglia.AsyncAPI? :)

Of course, if you want, you can always create PR in our website repo and add your tool by yourself - you should update this file https://github.com/asyncapi/website/blob/master/pages/docs/community/tooling.md :)

@cdavernas Hello! We would love to add your tool, but we don't have needed information :) It would be best if you would create a PR as I wrote in the previous comment.

@magicmatatjahu Yes, sorry, will do the PR as soon as I'm back from holidays 😅
In the meanwhile, thank you so much for the responsiveness

Sorry, I didn't know 😅 Have a nice vacation!


Python3 support of docs generation

Replace codegen by astor.
Use tuple._asdict() to replace tuple.dict.

Fix #9437

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Sure I can give it a try. However bazel test //tensorflow/tools/docs:build_docs_test runs fine locally. Perhaps because I'm using Python 3.6?

Nagging Assignee @MarkDaoust: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


#include path errors

somehow, vscode fails to allow us to have more than one .vscode folder in order to run the windows gcc compiler for cpp and the arduino c compiler. We have tried moving the .vscode folder in the respective subfolder (for arduino or c++) but this just results in more errors (according to thesmilingturtle).
Currently the repository is set up for arduino compiling.

well idk i fixed my stuff and its really quite liberating having intellisense back to tell you what you did wrong.
dunno how i can help u but dm me on the discord if you still have that issue


No 'confirmation of enrollment' emails

Add a settings option to disable the 'confirmation of enrollment' emails. I know I just enrolled, I don't need an email 🙃

@bramvandartel change of privacy regulations (just mentioned it here as well for backlog)


Dialog component

Description
Dialogues are 'windows' of floating content / UI components that sit over the top of the main content of the screen. They present important information, workflows or decisions that the user needs to make.
Component classification
Is this component an atom, molecule or organism?

[ ] Atom
[ ] Molecule
[x] Organism

Details / user needs
'Dialogue' is an ambiguous term, but is intended to highlight important information to the user. It does this by removing them from the main workflow of the page, and presenting the relevant UI components in a minimal setting.
In Application designs so far, we have approached this by creating a transparent window over the top of the interface, and presenting the dialogue on top. Some points to consider int he design:

How should the dialogue be closed? Should it have a button or 'X' icon? Should clicking outside of the dialogue, or pressing ESC close the dialogue (probably not in my opinion)?
How should buttons be positioned on the dialogue? Should positive actions always sit on the right?
There may be more than two buttons. For example Cancel, Previous and Next.
How big should dialogues be? Preferably the App designer should have control over this with suitable guidance.

Used in 3x exemplar projects
Variations
We may need to have a few versions of this. Some examples I can think of include:

Simple decision: yes / no decision
Informational dialogue containing text or images
Form. This could include a multi-step workflow
Dialogue with tabbed content. Not sure if this would be considered best practise though.

Questions

When the documentation is produced, can we define clearly what we consider to be a 'dialogue; as?

Definition of done

[ ] The Sketch file is updated with the component
[ ] There are screenshots of all component variations in this ticket
[ ] All states are included if applicable (default, hover, active, focus)
[ ] A design documentation PR is linked from this ticket
[ ] All questions laid out in this ticket have been resolved
[ ] A pull request for a component must contain a fully tested, documented and finished component in a state it can be shared with partner developers

Dialog & Modal component
The Dialog and Modal are full screen components that focus the attention of the user. The Modal can be used in a variety of situations, including displaying forms. The Dialog is a confirmation modal, requiring the user to confirm or cancel an action.

Modal Component
The Modal component has the following sub components:
Empty Frame
The Empty Frame is the main Modal container.
Modal Header
The Modal Header contains a title and the close button.
Footer - Default
The default footer contains a "Confirm" and "Cancel" button
Footer - Stepped
Like the default footer, the stepped footer contains a "Confirm" and "Cancel" button, but with the addition of a "Back" button on the left hand side.
Dialog component
The Dialog component is a special type of Modal. It is used as a confirmation from the user of a particular action. The Dialog comes in two varieties - Default and Danger.

@hxltrhuxze
Looks great, just a few points:

The red confirmation button in 'danger mode' feels weird (it makes sense with context)
Could you specify behaviours in this ticket (escape key? clicking outside on overlay closes?)
Can you define the opaque overlay - we could progressively enhance to a blur effect if you like?

https://github.com/Royal-Navy/standards-toolkit/pull/290


Provide a preview button/keyboard-shortcut which would preview markdown

Hi @nakulcg! This is good idea for apps that include markdown editing, but currently Notational is intentionally just for plain text. If markdown becomes a feature in the future, I am happy to revisit this.
Additionally, feel free to open a PR with support for this and I will review.


Runner]updating and bug report lags

Summary of the Pull Request
There is a lag when check for updates button and report bug button in tray icon is clicked. Both functions are moved to thread.

PR Checklist

[ ] Closes: #24419
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Should this be a hotfix?


Alias and custom installer branch support

Required to get new asset-admin module building with our long-running forks of framework and cms (until the module is stable in about a month). Relies on a repositories key to be merged from the module composer.json to the dynamically generated root composer.json, which is already the case in the current logic. The aliasing is necessary to avoid failing composer constraint checks. Could also be solved via branch-alias on the forks of course, but that's more CI-related code which needs to be removed before opening a pull request.
I purposely haven't documented this feature since it's weakening the API a bit (unclear where CORE_RELEASE is enforce). If you think it's a feature we should draw attention to, I'm happy to document in README

Current coverage is 100.00%

Merging #27 into master will not affect coverage as of 00f759e

@@            master     #27   diff @@
======================================
  Files            1       1
  Stmts          109     115     +6
  Branches         0       0
  Methods         11      12     +1
======================================
+ Hit            109     115     +6
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 00f759e

Powered by Codecov. Updated on successful CI builds.

@tractorcow You mentioned on the team chat that you'd like some doc for this - I've added them now.


What is the difference from official PyTorch DDP hooks?

It is a classical idea to overlap the backward pass and the optimization step. PyTorch supports this overlapping in DDP and FSDP. For example, here are hooks in DDP https://github.com/pytorch/pytorch/tree/main/torch/distributed/algorithms/ddp_comm_hooks
How does this project (https://arxiv.org/pdf/2306.09782.pdf) differ from https://arxiv.org/pdf/2306.09782.pdf? Thanks.

Thanks for your information, we will investigate it. Inplace updating is a classical engineering trick, and our intuition is to provide a solution for low-resource training. Our paper also discusses why SGD might be a good choice for LLM finetuning, how to stabilize the training process, and other analyses.


XAML Compiler Causes Build Failures with x:Bind + C# Record

Describe the bug
x:Bind does not sometimes work with record types where the following build error can occur:
XamlTypeInfo.g.cs: error CS8852: Init-only property or indexer '{Type}.{Property}' can only be assigned in an object initializer, or on 'this' or 'base' in an instance constructor or an 'init' accessor.

Steps to reproduce the bug

Create a new WinUI project
Specify Microsoft.WindowsAppSDK=1.2.221116.1, Microsoft.Windows.SDK.BuildTools=10.0.22621.755

Not sure whether SDK version matters but just in case

Use the following code for MainWindow, and then get build errors.

MainWindow.xaml:

<ListView ItemsSource="{x:Bind Items, Mode=OneWay}"/>

MainWindow.xaml.cs
public record Item(int Property);
public sealed partial class MainWindow : Window
{
    private ObservableCollection<Item> _items = new ObservableCollection<Item>();
    public IList<Item> Items => _items;
}

Expected behavior
No response
Screenshots
No response
NuGet package version
Windows App SDK 1.2.1: 1.2.221116.1
Packaging type
Packaged (MSIX)
Windows version
No response
IDE
Visual Studio 2022
Additional context
No response

Seems pretty similar to this issue I filed a while back: #5315


Unable to import user config from XML

When I attempt to import user config from XML, I get the following error:

Error:java.lang.RuntimeException: java.lang.ClassNotFoundException: org.gjt.mm.mysql.Driver

Hi @smidley , we have not tried DB, so we not have experiences on the import/export with external Database.

For setup DB, make sure we put the driver on the location as docs, should be mounted to volume or external folder
Location: /var/opt/crushftp
For example: mysql-connector-java-5.1.47-bin.jar from https://dev.mysql.com/get/Downloads/Connector-J/mysql-connector-java-5.1.47.zip
Docs: https://www.crushftp.com/crush10wiki/Wiki.jsp?page=MySQL
After place the driver to the location, we have to update the path (I guess)

We follow CrushFTP recommendation for User Store, use file based instead of SQL
https://www.crushftp.com/crush10wiki/Wiki.jsp?page=User Config

Lastly, you may need contact CrushFTP support for help setup SQL


Automate restore process.

Currently restore process requires user to manually create pipeline from restore template. This step should be automated, via the same lambda function. Ideally that would also handle increasing write throughput, to met restore time criteria and decrease it, when finished.

Closing, as project is now discontinued.


Add info about default user name

@iamNoah1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.


typo: verfiy -> verify

@nschonni : Thanks for your contribution! The author, @alkohli, has been notified to review your proposed change.

#sign-off Thank you, looks good. Please merge.

Verified editorial corrections.


fix(components/plc4x): fix NPE when Camel can not establish connection

Description
When Camel can not establish the connection to the S7 PLC, the component is throwing follow-up exceptions which are causing the application start up to fail and which hide the real connection issue.

Added isConnected() to endpoint which checks if connection is null. This method is public to allow external logic to check if endpoint is really connected.
Moved canWrite() call to be checked only when connected.
Added additional canWrite() check after reconnectIfNeeded().

Steps to reproduce:

Add Camel route with S7 driver
PLC is not available
Connection failure
Additional NullPointerExceptions are thrown

Target

[X] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[X] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[X] I checked that each commit in the pull request has a meaningful subject line and body.

[X] I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@oscerd I think the maven download failed during the JDK17 build. Can you please trigger the 2 builds again?

/component-tests plc4x


When launching with a configuration file, the default value for system_reserved does not take effect

Describe the bug

When launching with a configuration file, the default value for system_reserved does not take effect.
Steps to reproduce

Run GPUStack with the configuration file to set parameters:

Invoke-Expression "& {$((New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/gpustack/gpustack/main/install.ps1'))} --config-file 'C:\Users\seal\Documents\testdata\config.yaml'"

config file:
debug: true

port: 8080
token: "1234567890"

Go to Resource page and check the GET work api response.

Result

The default reserved resources for CPU and GPU memory are set to 0.

When running without a configuration file, the reserved resources default to 1G.

Expected behavior

The default system_reserved should be 1G.
Environment

GPUStack version: main (a7c8e86)
OS: Windows 11
GPU:  NVIDIA GeForce RTX 4090 24G

Additional context
Add any other context about the problem here.

Environment

GPUStack version: main(6b312f3)
UI version: 76444f2
OS: macOS 14.2.1
GPU: Apple M2, 24G

Test Result: pass


Update README.md

attempt to fix links to section with link

in particular it's this link that was broken: https://github.com/bioimage-io/spec-bioimage-io#model-resource-description-file-specificationhttpsgithubcombioimage-iospec-bioimage-ioblobgh-pagesmodel_spec_latestmd

and as https://github.com/bioimage-io/spec-bioimage-io#model-resource-description-file-specification works I'll merge this...


Can't install the packages. What are the exact versions?

Hi, I'm trying the full installation, but keep failing.
What are the "exact" versions for your packages (including CUDA).
Thanks.

Hi @EasonLin536, could you share the exact error message? We used PyTorch 1.7.1 and CUDA 11.0 but other versions (PyTorch >1.0.0) should also pose no issues.

Hi, @ChristophReich1996 , thank you for the reply.
After I built the Deformable-Convolution repo and install the DCN==1.0 package, I copied the files in build/lib.linux-x86_64-3.6/ to this repo.
When I execute main.py, the error message is
Traceback (most recent call last):
  File "main.py", line 32, in <module>
    from model import RecurrentUNet
  File "/home/eason/Deep_Fovea_Architecture_for_Video_Super_Resolution/model.py", line 6, in <module>
    from modules.modulated_deform_conv import ModulatedDeformConvPack
  File "/home/eason/Deep_Fovea_Architecture_for_Video_Super_Resolution/modules/__init__.py", line 1, in <module>
    from .deform_conv import DeformConv, _DeformConv, DeformConvPack
  File "/home/eason/Deep_Fovea_Architecture_for_Video_Super_Resolution/modules/deform_conv.py", line 12, in <module>
    from functions.deform_conv_func import DeformConvFunction
  File "/home/eason/Deep_Fovea_Architecture_for_Video_Super_Resolution/functions/__init__.py", line 1, in <module>
    from .deform_conv_func import DeformConvFunction
  File "/home/eason/Deep_Fovea_Architecture_for_Video_Super_Resolution/functions/deform_conv_func.py", line 13, in <module>
    import DCN
ImportError: /home/eason/Deep_Fovea_Architecture_for_Video_Super_Resolution/DCN.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN3c1019UndefinedTensorImpl10_singletonE

I'm using pytorch 1.0.0 and CUDA 9.0.
Thanks.

Hi @EasonLin536, in case you cloned the Deformable-Convolution-V2-PyTorch repo into the DeepFovea++ folder/repo there should be no need for comping and files. Maybe consider updating to CUDA 10.0 or newer to avoid more issues.
Cheers
Christoph

Hi, @ChristophReich1996, thanks for your help. I successfully installed DCN after updating to CUDA 11.0. However, in your Full installation section of README, shouldn't I cd into the correlation/ folder to execute python set_up.py install? (the same with resample/). It appears to be some file missing if I execute in the repo directory. Not sure if I missed anything.
Thanks.

Hi @EasonLin536, nice so installing all dependencies worked for you?
Yes, changing directory to the respective CUDA extension makes sense!


compile will sign if the signature files are present in the directory

IMO this shouldn't be the default behaviour. It's neat that themis-contract sign brings in a copy of the signature into the pwd but it seems both redundant and detrimental. Does it really need it to be there in order to render the PDF? Then all these signatures images get committed (although they don't really need to?). Not sure if that's ideal from a general opsec point of view. Other issue that I've just run into is when updating / making a new contract from an existing one. Since those signature images are in that directory, running themis-contract compile ends up signing the PDF contract. My current workaround is to delete the counterparty's signature and have them sign+compile+commit+push the final PDF.

If you don't add the signature files, then how could I compile a contract that you had signed? Where would I get the signature image from?

When you say "compile will sign" do you just mean it includes the signature in the generated PDF?


[Key Vault] Removed the use of a properties file for error messages in favor of using constants.

Fixes #34938.

API change check
API changes are not detected in this pull request.


Android compilation error - deprecated api

I get the following error when trying to compile in a project created with expo-cli using sdk version 31.
/Users/cristi/code/automemo/update-mobile-good/node_modules/react-native-braintree-xplat/android/src/main/java/com/pw/droplet/braintree/Braintree.java:33: error: Braintree is not abstract and does not override abstract method onActivityResult(int,int,Intent) in ActivityEventListener
public class Braintree extends ReactContextBaseJavaModule implements ActivityEventListener {
       ^
/Users/cristi/code/automemo/update-mobile-good/node_modules/react-native-braintree-xplat/android/src/main/java/com/pw/droplet/braintree/Braintree.java:239: error: method does not override or implement a method from a supertype
  @Override
  ^
Note: /Users/cristi/code/automemo/update-mobile-good/node_modules/react-native-braintree-xplat/android/src/main/java/com/pw/droplet/braintree/Braintree.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
2 errors

The compile used to work in an older project ( ~ 1 month ago ).
The case where I'm having the problem is a brand new project.
Any ideeas ?

@stochris Did you ever manage to get a resolution to this?


Revert "Adds more grindables (#24267)"

This reverts commit 16a1f2f16a8549d538c7523f5abefea63c7ad3db.

This is kind of a random one to revert, is it breaking something?

It's failing tests and I want to merge PRs.


[RFC][Runtime] Graph signature metadata

In the context of integrating TVM runtime with model hosting services
Model serving solution isolate model specific information and expose unified interface to users (example via REST API). Integration with such solutions need model metadata to be exposed to users (like inputs/outputs shape, name and dtype ...etc.).
ref. https://github.com/dmlc/tvm/pull/1659 solves to an extent of querying information of outputs.
We still need some way of getting inputs information.
Some challenges in current runtime implementation

TVM runtime doesn't differentiates params from inputs and allows to setting params by set_input API.
There is no API to get node name from index.

Option:

After load_params we could maintain graph_inputs list (inputs - params) and support get_input and num_inputs.
Additional API to query name_hint to get the node name. name_hint(input or output, index)

@tqchen @yzhliu @grwlf welcome to comment.

There are certainly tradeoffs we can make here. Supporting more meta-data query will make the module more informative, but never-the-less creates additional APIs that need to maintain and part of the code that need to be included in the runtime(which somewhat goes against minimalist principle).
This additional information can also be provided as a wrapper on the current API, for example, storing additional meta-data in json, in the case of REST. For other applications, we already have a convention on name/index of input, as well as the shape info, so such may not be necessary.

storing the input info in graph json should be ok.


DS-867 (Part 2 of 2) Restructure image folder, update docs pages

Jira
https://pegadigitalit.atlassian.net/browse/DS-867
Summary

Refactored the Doc Site image folder and updated the documentation examples to reflect theses changes.

Details
Restructured the Doc Site image folder

Removed images/backgrounds/
Removed images/content/backgrounds/
Created images/content/academy/
Created images/content/best-of-content/
Created images/content/calculator/
Created images/content/contact/
Created images/content/heroes/
Created images/content/icons/
Created images/content/layout/
Removed images/content/logos/480x160
Created images/content/oclp/
Removed images/content/portraits
Created images/content/profiles/
Removed images/content/promos
Removed images/content/screenshots
Created images/content/user/
Removed images/docs
Removed images/heros
Removed images/logos
Created images/placeholders/backgrounds/
Removed images/shapes

Moving forward, we should be utilizing the couple options that are in the images/placeholders/ folder for most Doc Site images. There should be enough images variation to support most of what we need for test images. We can modify or add more moving forward.
The content folder should be utilized when we need to build Drupal specific mockups that requires that will be used to build out a design. These images are just for display purposes and should not be shipped to Drupal (Drupal has its own image management system).
Updated the Documentation pages

Removed all unused images from the Doc Site image folder.
Updated existing images examples on the Doc Site to the placeholder images examples (if applicable).
Fixed the broken images on the archived Academy pages.

How to test

Pull down the branch and test the yarn start, yarn build and yarn tests:js commands.
Click though the doc site to make sure no images are broken (you can quickly see this in a browsers dev tools).
-- Note here, I did a very careful review of all the pages so I am fairly certain there are no broken images (no promises though) so i think we would be fine with just focusing on components/elements/pages that we know have a lot of images. For example, review the Background Component, Image Element and Academy pages among others.

Release notes

Refactored the Doc Site image folder
Updated the Doc Site pages images to new image folder paths

@adamszalapski @danielamorse I removed the redundant docs-site/src/assets/images/placeholders/4x3-640.jpg image. it was not being used and it not needed. Nice catch Adam


MAINT: add osx-arm64 to supported platforms

Same as
https://github.com/RUB-EP1/amplitude-serialization/issues/26
without right platform, pixi does not see the tasks

Took the liberty to rebase on main, sorry for any merge conflicts that may arise from this.

What is the tutorials branch btw?


Cleaning up branchStrategy messaging

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-node

Automation for azure-libraries-for-java

CI must pass here, and fail in https://github.com/Azure/azure-rest-api-specs-pr/pull/431 before this is merged.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go


RR V4 Programmatically Change Routes

Version
4.0.0
Test Case
Can't access router history to push state.
Steps to reproduce
Attempt to access programmatically the ability to change routing.
Expected Behavior
history.push (path) is what I would expect to push to a new route
alternatively history.replaceState (path) etc.
Actual Behavior
history is not available, confused as to if I need to import a library for this.

I should note, previous versions of RR contained these docs: https://github.com/ReactTraining/react-router/blob/master/docs/guides/NavigatingOutsideOfComponents.md

It appears I can access the router methods I need through context, however I was under the impression that using context was an anti pattern and would be deprecated?

We can't prevent its use, only discourage it. You might be interested in react-history for a declarative means to issue history actions. It's pretty neat.

@timdorr so what's the correct way to redirect in V4 from redux-saga for example?

Any news on this? I need to be able to send the user to a specific URL after they submit a form, so I can't use <Link>.
I checked react-history but it's not really what I need. Are there plans to include withRouter in v4?

Any update on this?

I think you want to use react-history and do something like history.push ('/route');

As best as possible I try to use either the Link or Redirect component. Accessing react-history works, but could reduce the reusability of the action.

i have a same problem iI cant redirect user after sending form, how can i solve it?

this issue needs to be reopened.
the experience is terrible for those using redux-saga


Create SuperAdmin role

We need a role in ScholarSphere that has the following privileges:

Ability to remove any user's files
Ability to change visibility / access of a user's files (e.g., make a file private)
Ability to correct a file's metadata

@patriciahswe Can we clarify remove.  Is that just making a file private, or actually deleting the file?  Also where would you expect to perform the action?  When you are on the edit page of the paper, or are you expecting to see all the user's files in your dashboard.
@patriciahswe do 2 & 3 just boil down to edit access to all files metadata and access information, or was there something you wanted to be able to block?

Yes, we can clarify! Let's rephrase to "Ability to make a file private."
That's an interesting albeit overwhelming concept - the ability to see all users' files in the SuperAdmin's dashboard. I'd be interested in seeing all new files uploaded appear in the SuperAdmin's dashboard and having them remain in the dashboard for a limited amount of time - during which the SuperAdmin could review the files and, as necessary, make changes to the metadata or make the files private until further notice.
Re: 2 and 3 - That seems reasonable: access to metadata for all files and access to visibility / access information.
Does the above make sense?

Ok so I am seeing three user stories:
As a system administrator I would like to be able to modify permissions on all files so that I can restrict access to private or invalid data.
As a system administrator I would like to be able to modify metadata on all files and collections so that we can curate metadata entered into ScholarSphere.
As a system administrator I would like a dashboard that shows me all files and collections uploaded within the past N(?) days so that I have easy access to new files for curation purposes.
The question in my mind is how you are planning to access the files in stories 1 & 2.  If a file is open access or new to the system then you would see it in search or the Admin dashboard.  If the file is private then it will not show up in the catalog.  Do you want the search to return all files no matter the permissions, or are you thinking you will have a direct link to the data?

Allow a Super Admin to create collections from other peoples work.

Miss spelling of a name
Metadata errors depositor is not the creator
Possible to make files the files private

Mid May for access to edit Public Metadata.


setup turn server

how to setup turn server? thanks

I followed this post.

@glennmichaelmejias @larrylisky flutter-webrtc-server does not require the additional deployment of turn server, because it and built-in turn server
https://github.com/cloudwebrtc/flutter-webrtc-server/blob/master/pkg/turn/turn.go#L39

@cloudwebrtc Thanks for pointing this out.  But 'config.ini' is showing '<IP_ADDRESS>' for public_ip, and the 'flutter-webrtc-demo' code (signaling.dart) has the entire turn section commented out.
Furthermore, when I built flutter-webrtc-demo as-is, P2P call only works on LAN and would not work over different LAN, until I brought in coturn.  How should I modify to config.ini and signaling.dart to work with the built-in turn server?

@larrylisky could you explain me the method to test a p2p call from mobile app using this server?
Thanks in advance !

@abheet-98 I documented what I did in this blog post.

@larrylisky Awesome.

@larrylisky Thank you so much for the blog post !
I'll definitely follow this but currently I want to first test the P2P call on the same LAN without using the coturn server so if you could help me to connect 2 phones on the same network to get connected to the P2P call that will be so kind of you.
Thanks and Regards

Run flutter-webrtc-demo in your mobile device, and run flutter-webrtc-server on a local server or a server with a public IP address for signaling.  The instruction on the github README.md is pretty straightforward.  Where are you getting stuck?

@larrylisky
Actually the server started but now I don't know how to connect the 2 phones with each other.
and the server starts and when I open it in the browser the logs are :
2020-05-28T20:35:29+05:30 INF Flutter WebRTC Server listening on: <IP_ADDRESS>:8086
2020/05/28 20:35:41 http: TLS handshake error from <IP_ADDRESS>:64510: remote error: tls: unknown certificate
2020/05/28 20:35:41 http: TLS handshake error from <IP_ADDRESS>:64511: remote error: tls: unknown certificate

@larrylisky
Actually the server started but now I don't know how to connect the 2 phones with each other.
and the server starts and when I open it in the browser the logs are :
�[90m2020-05-28T20:35:29+05:30�[0m �[32mINF�[0m Flutter WebRTC Server listening on: <IP_ADDRESS>:8086
2020/05/28 20:35:41 http: TLS handshake error from <IP_ADDRESS>:64510: remote error: tls: unknown certificate
2020/05/28 20:35:41 http: TLS handshake error from <IP_ADDRESS>:64511: remote error: tls: unknown certificate

read your log buddy, that error comes from the certificate(self signed certs), use the browser hit your server ip, accept the unsafe cert, then run your app

@jason-shen Yes the server starts and when I open the server on the browser on multiple tabs , I can see those many peers connected with each other and I can do video call to any of them from any tab.
But when I tap the P2P call sample in the mobile app and then type the server ip, I get a blank screen and the server doesn't get updated with the new peer (i.e.,which is from the mobile app).
If you could help me with this.
I want to have a video call using the mobile devices.
Thanks in advance !

hi, am not able to run "make" command in visual studio code(am using windows) after cloning, it says command not found, pls giv me detailed procedure to run this server on windows. pls help me out

flutter-webrtc-server does not need to deploy turn server, because it has built-in turn server

why README.md says:
This example can only be used for LAN testing. If you need to use it in a production environment, you need more testing and and deploy an available turn server.

@fawdlstty In fact, the turn server is already supported. The new version is rewritten with go and uses pion/turn as the built-in turn server, so no additional deployment is required. I have updated the README.md.


Add option to show datetime

i like to see the datetime ateach prompt. Could you add an option for this?

@geromueller hi! There is an related PR #51. I don't have enough time these days. Gonna do review ASAP.
P.S: Personally, I don't like timestamps in console, so probably this feature will be optional (could be enabled with environment variable)

Closed in #51

https://twitter.com/denysdovhan/status/827891289261801472


validation with node_modules monitor examples

I am not sure if this a bug. Seems like you linked the agent from your local folder and it kinda takes everything from there. We can add an option to ignore node_modules, but I don't see users running in to this problem.

Seems like we always had this issue, but since our templating logic was broken https://github.com/elastic/synthetics/commit/cbf4c4e388acb25c86a94e3c99ad516aee9f13e6 we never picked it up. Addressing that one, revealed the other bug.


What Calibration setting value to use for 200A CT?

Per 7. Calibration Settings...
25498 - SCT-013-000 100A/50mA
39473 - SCT-016 120A/40mA (default)
46539 - Magnalab 100A
...so what do I put if the CT sensor is this 200A version: https://circuitsetup.us/index.php/product/200a-100ma-current-transformer-yhdc-sct-024-24mm/
Also, if CT1 reports - (negative) value and CT2 is + (positive), does one need to be flipped?
Documentation is contradictory...
Picture shows arrows pointing opposite ways on each leg of split phase
but... troubleshooting says...
 If they are both oriented in the same direction, this will not happen.

Thanks for pointing out the fact that this value is missing. I'll have to add it to the documentation, and update things to not contradict.
It should be around 26315
The CT that is reading negative should be turned around.

I am planning on using the CT referred here (https://circuitsetup.us/index.php/product/200a-100ma-current-transformer-yhdc-sct-024-24mm/). Since they have the TVS diode, I do not need to sever the burden resistor, correct?

I am planning on using the CT referred here (https://circuitsetup.us/index.php/product/200a-100ma-current-transformer-yhdc-sct-024-24mm/). Since they have the TVS diode, I do not need to sever the burden resistor, correct?

I am planning on using the CT referred here (https://circuitsetup.us/index.php/product/200a-100ma-current-transformer-yhdc-sct-024-24mm/). Since they have the TVS diode, I do not need to sever the burden resistor, correct?

No, you don't need to (and shouldn't) sever the burden resistor.

I am planning on using the CT referred here (https://circuitsetup.us/index.php/product/200a-100ma-current-transformer-yhdc-sct-024-24mm/). Since they have the TVS diode, I do not need to sever the burden resistor, correct?

No, you don't need to (and shouldn't) sever the burden resistor.

Hello,

It should be around 26315

Could you give some insight about how you come up with these values?
The calibration process suggested in the AppNote needs an input of the value read on reference meter, and also value read on the ATM90 chip, so I'm kind of curious how can you pre-define these values?
Thank you.

The 26315 is a starting point...
You need to calibrate it by putting a clamp amp meter around the mains cable, then manually adjusting the 26315 number +/- until the amps measured by your meter and the emonESP match - at least close.  You can see the live value as read by the emonESP by hitting it's IP in a browser directly.  It's sorta a pane in the butt cause obviously your power use is fluctuating in the house as you do it.
In my case, using the emonESP, with the 200A CTs it shipped with, my values turned out to be as follows...
Voltage: 3920
CT1: 26100  (I found 26315 to be off a bit)
CT2: 26100
Freq: 4485
CT Gain (PGA): 21  (I found 42, as the webpage suggests to be way off)
Some math is being done against the 26315 number to calculate the amperage displayed.  That's why adjusting this number +/- helps make it more accurate to actual amps being used.  There are likely differences in the way the CTs are manufactured, but also how you attach them (snug to the mains cable), and electrical noise that makes the case for calibration against another known source (amperage clamp style meter) necessary.
Side note - at some point I flashed mine with the latest firmware file (more difficult to find than it needed to be) and ended up "downgrading" mine to v2.6 whereas it shipped with v2.6.1  :(


Unable to set end time when selecting the same day

Configuration:
mode: 'range',
enableTime: true

Expected Behavior
The user should be able to:

Select the start day
Select the start time
Select the same start day for the end day
Select the end time

Eg: 01-01-2017 08:00 to 01-01-2017 13:00
Current Behavior
Upon selecting the same end day as the start day, the calendar only allows the user to change start time.

Version used: v2.2.9

+1

Hello, as per version 2.3.3, the issue still persists.

Hi, make sure you use version 2.3.3 and not some other version from cache because for me it works on latest version of Chrome, what browser do you use? Maybe it's browser related.


Exported SVG not opening in other programs

When we used the export to SVG function on Cocreate this morning, the resulting file failed to load properly. This was across at least three different devices including Inkscape and Chrome on Windows 10 and the standard Ubuntu image viewer. Inkscape failed to load, chrome displayed a blank document, and the Ubuntu pdf viewer gave an error saying it was not a correctly formatted svg.

Can you email me a link? (I wouldn't post it publicly here.) I use export to SVG roughly every day, and it loads fine on Chrome (but I don't test Inkscape as often), so maybe it's something specific to your drawing.

Yep, I had intended to suggest you pm me for the link.
https://cocreate.csail.mit.edu/r/umohfGvM8jcG42PYz
Let me know if you also want the file.
On Mon, Sep 28, 2020 at 12:19 PM Erik Demaine<EMAIL_ADDRESS>wrote:

Can you email me a link? (I wouldn't post it publicly here.) I use export
to SVG roughly every day, and it loads fine on Chrome/Coauthor (but I don't
test Inkscape as often), so maybe it's something specific to your drawing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/edemaine/cocreate/issues/106#issuecomment-700137838,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7UVFS5IFTMP6YVRHVMNCDSICZPDANCNFSM4R4WR5IQ
.

You emailed Github, not me... I've deleted the comment but you should be careful in the future.

There was a rectangle object at coordinates -577065.5, -378730.09375, which caused the bounding box to be huge relative to the drawing.  The drawing still looked fine to me on Chrome; it's just that the content was about 1% of the rendered area.  I deleted the stray object, and now the bounding box is much happier.  (You could have also selected just the objects you care for, and export those.)  It loaded fine for me before and after Chrome (and probably did for you -- it just looked blank to you).
I also had no trouble loading the file in Inscape 1.0. Are you using 0.92?

I wonder what put an object out there. It might be nice to be able to easily tell what the bounding box is in cocreate.
I am using Inkscape 0.92.3 I'll look into updating. Sounds like this was an issue with our use, not cocreate.

I just tested in Inkscape 0.92.4, and it worked fine (though took several seconds to load). It is a big SVG file, though (6.2MB), so maybe an out-of-memory issue?

Opened #108 regarding discovering the bounding box -- feel free to post there if you have ideas.


Removed Nuage marketing

This entry is not necessary for Kubernetes to function.  Entry provides a link to the main corporate website, not to any relevant information.  No CNI.  Acronym refers to product marketing, not an actual technology.

/assign @bradtopol

I agree with this removal according to the third-party content guide
/approve


CRC of data Blocks and Hash of File should has to be adapted to RS encoding

CRC removed because file can self repair


feat(dropdown): add support for disabled dropdown menus

fixes https://github.com/patternfly/patternfly-next/issues/1511

Deploy preview for pf-next ready!
Built with commit 9173d31080e5bd4dbcb0a1df4532e840986be27f
https://deploy-preview-1512--pf-next.netlify.com

Thanks @christiemolloy updated


Update json

Added more fields to JSON and added blank line between objects.

not really a fan, fwiw, specifically wrt the changes to Dispatch and the JSON fields. also not sure when query_parameters snuck in there, that one seems like it needs to go.
all additional fields added to the json blob are already available via other places. I'll enumerate:

request url is in req.Header["FN_REQUEST_URL"], and, notably, is generated slightly differently than req.URL.String()
call id is available in req.Header["CALL_ID"]
call.EnvVars the intent is to no longer send these in the 'headers' / per request, as of https://github.com/fnproject/fn/pull/370 as it is the union of the base vars, which are available in from environment variables regardless of route.Format and the 'headers', in req.Header. while i kind of agree headers/env vars are a mess, I don't think making them available from 2 different places with potentially different formats/casing per route.Format is going to make things any less messy. in any event, there has been some discussion on #370 and input would be appreciated.
the json format will now override response headers that are set on the route.Header if specified from a given call, as opposed to adding them, as the other formats do. this is hairy and should likely be in someplace else (my b for http)

I assume this is pairing with changes to make fdk-ruby & co (not safe to assume -- proceeding with assumption) perhaps easier to use without having to do too much magic in the fdk itself. I am tepid about adding *models.Call to the Dispatch signature for some of the kind of inconsistency between various formats highlighted above, namely, giving access to call fields like env vars, but others as well. I do agree that it very much sucks as a dev to have to do:
cid = headers["FN_CALL_ID"][0]

but on the bright side we're overriding this one so that there won't be > 0, and fdk's could likely parse out the set of 'guaranteed' headers like this one and make them more easily available as fields? not sure that's any better, though. At least, it seems like the json format, if we want this, could extract the additional things we are yanking out of the *models.Call from the req.Header instead into the more "friendly" format inside of Dispatch as opposed to adding to Dispatch's signature; this would skirt the inconsistencies of writing both env vars and headers, and the call_id and request_url are easy to extract.
I'm mostly guessing, a rationale for this change set would help in clarification. but those are my thoughts on the matter to consider, if you please, anyway.

@rdallman addressing your long comment: Regarding first two bullets, I don't agree grabbing critical values out of a map is the best way to do do this. Having the Call object available makes a lot of sense considering everything Dispatch is doing is related to a Call. Again, need to get off the "let's make everything raw HTTP" wagon.
Regarding bullet 3, fine by me. Although, after our FDK convos, I'm thinking this should map more closely to what we plan to offer in the FDK's. See #476.

Regarding first two bullets, I don't agree grabbing critical values out of a map is the best way to do do this.

fdk's can re-build this into the client side context rather easily, it's just kind of smelly to have values exist in > 1 place and have snowflake format values. i don't think it really makes us all that http specific, just seems like a straw man attempt -- we're going to send in per request values, regardless of format, the fact that they're called 'headers' doesn't seem like a point about http. it's pretty trivial to convert to some version that pretends it isn't http when it's basically the same, seems like we're hung up on hiding http even though it's basically http -- we can call them 'ducklings' if it would avoid adding things for the sake of hiding http.

i've had a comment that would likely acquiesce the apparent itch of import "http", we can very likely have:
type Input interface{
  ID() // please no
  Ducklings() map[string][]string // since the list is not approved of, don't get hung up on this
  Env() map[string]string
  Body() io.Reader

  // whatever else we decide we don't want to access by key-value strings?
}

which a thin wrapper around an http.Request basically implements and we can have some other input format that implements this that doesn't happen to be an *http.Request underneath eventually (say, a *grpc.Request or what have you), but we need direct access to *http.Request fields (if the request is from http) in order to stream things in without doing any copying. then the http import is eliminated but http is masked, since this is a sticking point (and for that, we get added indirection, yay. and future proofing; but-maybe-yagni).

Let's leave FDK's out of this for the moment, we're really just talking about the protocols and the Dispatch method, which for some reason you're hesitant to provide all the appropriate information, eg: the Call object. Previous to this PR, the protocol handlers have to pull values out of the headers map in the request object that was modified by adding values from the Call object. 😨
IMO, it should be the other way around. The request object shouldn't be modified and the call object should be readily accessible to the protocol handler. The HTTP handler should be the only thing that modifies the request object since it's the only one that will be passing that along to the container. The others should probably get the real, unmodified request object.
And lastly, I'm not saying remove http, I don't care that there's an http import or that we're using http things, I'm just saying we shouldn't force every interface method to only take stdlib HTTP objects throughout the whole system and be afraid to pass non-stdlib object around, there's no value in doing that, it's just a hindrance.

Previous to this PR, the protocol handlers have to pull values out of the headers map in the request object that was modified by adding values from the Call object.

I would say prior to this patch no protocols were even attempting to do this, so it's kind of a moot point unless we mostly agree we should start doing this (for whatever reason, as proposed here). python is/was also handing things in as headers key which mapped to a map[string][]string so just passing it down was easy enough. now we have 2 formats so can figure out what makes sense. I think the arg is really for this format as well as other formats, what do we really want? we can optimize for http and have that one fall out, but that's going to have to be translated to a grpc or some tcp framing thing or some json blob or whatever format. i maintain we're basically serving http requests so it seems an ok one to optimize for (the current ideas around kafka atm are completely unscalable, to counter the counter there, I haven't gotten around to writing a 'nice' rebuttal).
so, we have json, which is extracting all these fields from the call to shove into the json blob, so that the fdk's/clients can read them easier than from in the headers (can't avoid why here)? for grpc or for amqp (other request-like objects?) the construction will be very similar to http, in that we have to build a request-like-object that will basically (basically) have a method, headers, and a body and maybe some protocol specific bits -- not some special body that has a call id, some env vars, some headers, {other_call_fields}, and a payload, as does json. I realize json is a little different, but it seems completely sane for json to have a field for just headers and body basically, since basically every kind of higher level request-response type protocol will be defined in some way analogous to that. what we're ultimately getting at here is yea, fdk's / clients are going to have to translate from e.g. grpc/amqp/http to some nice in-language object/model/data and for most of those things it's just not so fun (hence fdk's masking). we could change to have more structured data in the body across all formats but the tradeoffs there are also... icky.
the call object has to be constructed, as well as the http headers, and these two will never really be unrelated since there's overlap. the main thing was not having to re-construct the http request that we already had coming in to send to the container, which was/is brittle and inefficient, so yea, while it's unfortunate that we're modifying the headers in place, it is kind of a pros-outweigh-the-cons kind of thing too, imo (yay computers). what's proposed is to build a call and then build a request from that, which is kinda what I'm trying to avoid yea. if we can wrap request objects more nicely than a call and limit the surface area (as noted in prior comment) then it could be workable.

And lastly, I'm not saying remove http, I don't care that there's an http import or that we're using http things, I'm just saying we shouldn't force every interface method to only take stdlib HTTP objects throughout the whole system and be afraid to pass non-stdlib object around, there's no value in doing that, it's just a hindrance

I believe I pointed out the value in this in the last P. have proposed the wrapper interface which could possibly build each kind of object for us. i.e. we have a thing that can take grpc->json, http->json, http->http, http->default, etc. where the thing on the left is the actual wire format for the incoming request (not to be forgotten!). in the case of async right now we are reconstructing an http request (sad), it would be nice to serialize the http request to a message in the MQ and then just deserialize that (TODO exist for this). if we have the transmogrifier (TODO for this, too) then it would be easy enough for any input to turn into http and back into whatever else we need, too. i realize we are all comfy building layer cakes of abstraction, it is the app development model now, but things like kafka get a lot of sugar by having their wire format and their backend work together nicely and it's at least more fun to think about than some of the other yak's facial hairs.
this addresses everything, mostly:

we do get sugar from not having to re-build http request
this patch attempts to make json a snowflake
an attempt to make everyone hold hands and say nice things about each other. in public.

let's flesh this out tues, maybe with all the header stuff

Meanwhile working on FDK context I figured out that having call object in Dispatch is kinda required in order to distinguish what are request headers (that are stored in env) and what is an app and/or config.
Having both app and route config merged makes it a bit complicated to identify whether this particular environment var is HTTP request header or config var.

Meanwhile working on FDK context I figured out that having call object in Dispatch is kinda required in order to distinguish what are request headers (that are stored in env) and what is an app and/or config.

I think the plan here is that app and route configs are only present in environment, so this isn't true if we do that.

I'm okay keeping them in env, but still not clear how do I know if env var A is a request header, app config var or route config var? That's the point I'm trying to make. I feel a bit uncomfortable when I start considering context.Config() as i copy of os.Env().

I guess the thinking is that they are in separate buckets in the fdk context. i.e. ctx.Headers() and ctx.Config() or something along those lines. this is fdk specific. without fdks, they are simply in different places to delineate (headers in headers, app/route config in env). as far as app vs. route config, it's true we don't say which is which and route overrides app but when we have versioning of routes this should be easy enough to look up wrt auditing.

i.e. dispatch should explicitly not have access to config and app vars (ideally)

@rdallman why is that ideal? Dispatch should have all information it needs to pass into the container, which includes config vars and call information as well as the unmodified Request object. It shouldn't have to extract this information from the Request objects headers. Again, I think the HTTP Dispatch should be the only thing that does anything with the headers since that is what it will pass into the container, none of the other protocols will be doing that.

Ok, @rdallman and I came up with a good plan for this, we'll pass in an interface with the required data so protocol can't modify the call object with methods like CallID(), Writer(), etc. Also, only the http protocol will add modify request headers to pass into the container.

@treeder sounds reasonable, of course, if the main reason for forbidding protocol Dispatch access and modify call object. Meanwhile, we talk here about modifying JSON protocol fields by extending one to something new, can't we make OpenEvent-compatible payload here? We're almost there. Thoughts?

{
  "eventId": "66dfc31d-6844-42fd-b1a7-a489a49f65f3", # call ID
  "eventType": "google.storage.object.finalize", # let's hard code one to http_api_call or whatever looks reasonable
  "createdAt": "2017-09-28T19:03:12Z", # i think we can get one because timer started before dispatch
  "data": {}, # request payload
  "dataContentType": "application/json", # Content-Type
  "resource": { # this might be blank at this moment
    "type": "storage#object",
    "id": "storage.googleapis.com"
  },
  "specVersion": "0.1", # we're not versioning protocols yet, so might be black
  "attributes": {} # include headers here would those ones be in Go-http headers or HTTP 1.1 style
}

Alright, revamped this a bit, please take a look.
The format this generates and expects is documented here: https://github.com/fnproject/fn/blob/3a481d4325d7500710a06bdf7aeb8606b4fb656e/docs/function-format.md#input
Not the "protocol" map to hold protocol specific things, that user can ignore or use at his/her own risk. Also directly aligns with our FDK discussions.

I'll have a deeper look at this tomorrow, but for now I have two at-a-glance comments...
I'm a bit concerned at the level of escaping that will be required for the "body" field. What happens if the input already has strings containing quotes that are escaped? Then those will have to be double-escaped... do we have a reliable solution for encapsulating general json in a json string? (maybe golang can already do json reliably, I'm not an expert)
Secondly, I guess the "protocol" section could be handled as an arbitrary nested hashmap in most languages, though in Java it might require a bit of work. Still, shouldn't we have the protocol "type" in the output as well? The current example / spec doesn't have it.
Or is it enforced to be the same protocol as the input? It would make sense... Or could a function receive http and spit out a protocol section for, say, a kafka event as output? What's the behaviour in that case?

@hhexo the body is a string, so quotes and things have to be escaped, as you see in the example, they don't need to be double escaped beyond what the example shows. The function gets a string in the body, and they can do with as they please. If using an FDK, the FDK may deal with it for you.
The protocol section is an arbitrary map, the docs just show an example. And you're right, the docs don't have the type field, I'll add. I suppose the type field is the one thing that's not arbitrary.

If the type field is required, could it be at the same level of "protocol"? Maybe always have "protocol_type" and rename the map to "protocol_data"?
Regarding escaping, my doubts were just about what happens when I send some input json like this:
{
  "sentence": "\"Elementary, my dear Watson!\" he said."
}

Then the does the json received by the function look like this?
{
  "call_id": "123",
  "content_type": "application/json",
  "body": "{\n"sentence": \"\\\"Elementary, my dear Watson!\\\" he said.\"\n}",
  ...
}

(i.e. with escaped backslashes and special characters)
Maybe the json libraries for the various languages will just "do the right thing" when encoding/decoding.
Another question... I notice that for json format, the body is represented as a string, but what happens if I make an http request to the function and the request has binary data in the body? Do we forbid that?

re: escaping, yes, that is what would happen, json libs should handle it just fine.
re: type: Was thinking the same thing on the protocol type thing, might be better top level. or to keep top level cleaner:
"protocol": {"type": "x", "data": "MAP"}

re: binary: they'd have to base64 encode (or some other encoding perhaps) the data, but that's a limitation of JSON itself so not much we can do there. Although, this could probably also be solved with something like #500 if we need to do it.


Fix badge view default text "0"

Description of Bug
BadgeView default Text value is never set.
The Text property has a default value of 0, but it is never set to the actual label. This prevents the BadgeView from being displayed if it is bound to a property with a value of 0 and AutoHide is set to false.
Issues Fixed

Fixes #1900

Before

After

PR Checklist

[ ] Has a linked Issue, and the Issue has been approved
[ ] Has tests (if omitted, state reason in description)
[x] Has samples (if omitted, state reason in description)
[ ] Rebased on top of main at time of PR
[x] Changes adhere to coding standard
[ ] Updated documentation

@microsoft-github-policy-service agree

AutoHide default value is set to true
https://github.com/xamarin/XamarinCommunityToolkit/blob/e7c0c80d79d363e949443970e7c65bcfd6717c57/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/BadgeView/BadgeView.shared.cs#L54-L59
And BadgeIndicatorContainer visibility is set to false
https://github.com/xamarin/XamarinCommunityToolkit/blob/e7c0c80d79d363e949443970e7c65bcfd6717c57/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/BadgeView/BadgeView.shared.cs#L286-L291
In my test case, the second label is wrapped in a BadgeView and AutoHide is true. When the binded text is changed it is always called UpdateVisibilityAsync.
https://github.com/xamarin/XamarinCommunityToolkit/blob/e7c0c80d79d363e949443970e7c65bcfd6717c57/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/BadgeView/BadgeView.shared.cs#L199-L206
As a result, the default behaviour of AutoHide remains unchanged

@FedericoNembrini Thank you for this submission!


Add aggregate report process

The ability to be able to process aggregate reports generated by Jacoco is added in this pr.
The functionality is enabled by setting aggregate-mode to true
fixes https://github.com/Madrapps/jacoco-report/issues/40

The DTD is not fully supported. There are still cases like "group can exist within group", "report can contain both group and package"...
I will add the full DTD support along with the Multi Module support.


can we add babel 7?

it would be nice to add babel and see how is the setup
check this: https://github.com/entria/entria-fullstack

there are a lot of issues with babel config in monorepos, like this one
https://github.com/babel/babel/issues/8945#issuecomment-438264514
it would be cool to have babel setup here with docker, so we can fix all of them


Workaround for accessing the webhook's query in the body of the Webhook

Related to https://github.com/elasticio/webhooks/issues/70

@luzhok @stas-fomenko how can I facilitate the test of this fix?

@zubairov where can we test it? is it already on popeye or sparrow?

@luzhok tbh no idea, code is merged into the components master branch what is the usual process after that?
Expected behavior after this fix would be following:

If webhook is submitted as before (e.g. POST with json or any other content types) no changes in behaviour is expected
if webhook is submitted as before but webhook URL has additional GET parameters in it (e.g. https://in.elastic.io/hoooks/123456798?foo=baz ) then additional field called _query will appear inside the body of the message after the WebHook component and values in it are parsed from query parameters (e.g. in the sample above {"foo":"baz"})

@khanzadyan may be we need to mention it in the documentation too (once it will be merged and deployed to production)

@zubairov ok, I see ) I'll push the component to sparrow and test it. I'll inform you about the test results

@khanzadyan now it's a good time to mention it in the documentation, I'm ready to make a suggestion (PR) but need your help to show me where?

@zubairov can you please create an issue in here: https://github.com/elasticio/elasticio.github.io/issues

@khanzadyan done - https://github.com/elasticio/elasticio.github.io/issues/26


Fix mattermost systemd unit

Fixes #22860
Motivation for this change
The preStart hook of the service file tries to set up a postgres database using the psql command.
psql connects to Postgres through a unix domain socket that is in /tmp .    However, because we have PrivateTmp=true , psql can never find this domain socket.   Hence the change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

JoinsNamespaceOf sound appropriate to me.

That is not possible.  -h  needs  a password to authenticate instead of the current user id that runs the command.  JoinsNamespaceOf seems like a better solution. let me try this.

Thanks!


Update the links to Singularity which are outdated

@pcantalupo I'll update them myself, that'll be quicker ^^

I added a link to a turorial for installing Singularity, since the one one Sylabs uses GO Compiler v1.11, which is outdated and causes installation to fail.


[build-script] Introduce ProductBuilder. Transform Ninja to use it.

ProductBuilder allows us to tackle the different way than the different
products need to be build. The builders follow a very simple interface,
but inside them the details are hidden.
Previously the Ninja product was both a Product and also the process to build Ninja. The
methods that did the build have moved into ProductBuilder to match the
future ProductBuilders.
Product and ProductBuilder are very close, but the current design of Product is not adequate to compile for different hosts and lacks of some access to other parts of the script. Instead of modifying Product, I decided to keep separate from it to allow the rest of the script to keep working the same (it will also allow to keep the previous way of doing things and the new way of doing things in parallel, which might made the migration less scary).
Pieces that ProductBuilder requires, but weren’t available in Product are the target host and the workspace information. The first is needed to generate the right parameters to invoke CMake and other build scripts, while the second is necessary to find out about other product locations (Swift product references LLVM, LLDB references both Swift and LLVM), as well as allowing access to the build results for the current target, and also the tools host target.
Later commits will show how ProductBuilder is leveraged to invoke different building scripts and how  flexible is the setup.
This was part of #23257. I’m trying to split the PR in smaller ones to make the reviews easier. Other PRs in this group are #23303, #23803, and #23810 .
/cc @compnerd

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 29159b9cc513a0d46ea3a5aeba7eabde4d691880

Build failed
Swift Test Linux Platform
Git Sha - 29159b9cc513a0d46ea3a5aeba7eabde4d691880

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 29159b9cc513a0d46ea3a5aeba7eabde4d691880

Removed the do_ from this PR, as I did in #23871. No other changes at the moment.
PD: the test were green before I pushed again.

@swift-ci please smoke test

Moved the initializer into the formal requirements of the ProductBuilder. It looks a little bit out of place for single product builders, but I hope it will not create problems later.

@swift-ci please smoke test

The failures seems to be related to #23980, which disables those tests completely.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 1ee8a0482daeef8394e41e72f30bdc92b53addb5

The Linux failure seems to be fixed in #24372.
@swift-ci please test linux platform

@Rostepher, @compnerd: I would like to restart my efforts in these PRs, if everyone is onboard. Without this PR and some of the others I am a little bit blocked about the next steps. If there's further feedback or requests, it would be my pleasure to make the changes.
(PD: other people can also provide feedback)

First and foremost, thank for all the work done in this PRs and the rest of the project.
We know that we are all very busy, but it would be great to know if the radio silence is because we are busy or something related to the PRs contents. If the PRs conflict with internal systems and modifications, I would not mind modifying this to adapt better (or help modifying the internal systems if that's possible), but without any clue of what can be modified, I cannot do that much.
Thanks, and sorry for insisting again.

@swift-ci please test


Release of scope-backend-build docker image

Hi,
When could we expect the release of scope-backend-build docker image?
It would be great if you release scope-backend-build docker image with an updated backend dockerfile.
Thanks :slightly_smiling_face:

@qiell @fbarl @satyamz @bboreham
Any updates on this issue? Thanks :)

The image has jumped from about 1GB to about 2.3GB since last updated in CI; I will see if I can fix that.

@bboreham Gentle ping, any updates for this issue? Thanks :)

@bboreham Could you please have a look? Thanks :)

Sorry, can you remind me which specific change(s) you need?
From #3902 we had an image weaveworks/scope-backend-build:go-1-17-8-bcdf2caa in April; I have just merged that PR which means master is using it.
That image is 1.15GB, so at least the problem I noted on 7th March is fixed.

@bboreham
Thank you for the update. I was awaiting updates on weaveworks/scope-backend-build:go-1-17-8-bcdf2caa image. And since master now uses the updated image we can close this issue.


chore(main): release 1.4.0

:robot: I have created a release beep boop
1.4.0 (2024-07-11)
Features

plugin: allow specifying a subdirectory for plugins (0e79514)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.4.0
:sunflower:


[Question/Issue] Working with Livewire component

Hi,
when I try to type some text into a Livewire component, I somehow get immediately disconnected.
I can see in the console that the route for the component gets hit, and a 419 Unknown response is returned, which disconnects the user.
Please see the screenshot for details.

Did I forget something in the configuration?
thanks

I use this package to test a few Livewire components, and haven't had any issues.
I think this might be an issue with your Livewire component, and not a bug in the package.

I use this package to test a few Livewire components, and haven't had any issues.
I think this might be an issue with your Livewire component, and not a bug in the package.

I'm running into the same issue, did you find a solution for this?


Fix floating point context switch issue

Clear the ASPEN and LSPEN bits in the FPCCR. Combined with OS_OPT_TASK_SAVE_FP, the RTOS no longer hard fautls when trying to restore FP context.
Quality Assurance Checklist
To make reviews more efficient, please make sure the software feature meets the following standards and check everything off that meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.
There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.
Requirements

[ ] Followed Coding Style Guide
[ ] Presented/discussed in some capacity with others on the Controls team
[ ] Code Build checks pass
[ ] No merge conflicts
[ ] Software feature has documentation for it updated in both ReadTheDocs and the comments
[ ] Software feature has documentation for it updated
Testing

[ ] Software feature has test associated with it
[ ] Test provides useful information and uses relevant data to accurately represent Controls
[ ] Tested on hardware
NOTE: If test file already exists, use that one

[ ] If applicable, have you added the new feature to main.c?
[ ] Tagged appropriate issue ticket on this PR
[ ] Did you have fun?

Things to Consider

[ ] Even if the above are checked, is this the best way of writing my code?

It's possible to write code that works, but are there ways to make code more efficient?

@chaseblock


Blackjack condition

The blackjack condition is achieved if there is a combination of Ace and a royal card(jack, queen and king) to score 21.
Currently, when they are drawn, the score is 20 because the default value of Ace is 10 and the royal cards are 10 which added together are 21.
I think a way around this would be to add a blackjack check after the initial draw phase to check the score and adjust?
Another way would be to evaluate the cards when drawn and adjust the value of Ace. Problem is, I wont know which order the cards are drawn first.

Example screenshot as reference

Resolved by adding a blackjack check on after the draw phase by iterating both dealer and player hands to check for ace or royal card and then make the score 21.

Commit done. Logic works so closing. Refactoring will be carried out for player and dealer mentioned in #2


Dropdown for choosing robot type buggy

Steps to reproduce:

Click on Robot Type button twice, to open and close the dropdown
Click outside the button once

The dropdown should not reopen.

Solved by checking whether dropdown is-active or not for onBlur function.


Clientserver: receive list of configuration parameter results

The app needs the clientserver to accept a list of configuration parameter results, rather than just one at a time, but recent changes undid this. This should be a hacky fix, however refactoring it into sending one big request to the infoserver is probably a better idea. Either way I need this ASAP so I can test re/calibration app-side.

Eh yeah this isn't gonna work


Cannot query field ... on type "RootType"

Sorry for not following the template. I can't reproduce it with the same codebase (assumption) on a different laptop.
on a long-running project, I've updated all packages to their latest versions and now for the life of me, can't get graphql-codegen to work anymore.
I get an error for all my operations "Cannot query field"
Even when I go back to the exact same setup for codegen as before it throws the same errors.
When I only run the introspection plugin it works, also on another laptop with the old code the codegen works so I think I can rule out it has to do with the graphql server (Hasura).
My question is:
Does anybody have some pointers where I need to start looking?
I just don't know where to start.
I've tried:

almost all different graphql versions
a lot of different versions of the various graphql-codegen packages
reinstalling packages
restarting my laptop
pulling out my scarce hair

The only piece of usefull information in the error output is:
new AggregateError (/Users/les/projects/spatialexplorers/dagenapp/node_modules/@ardatan/aggregate-error/index.cjs.js:141:24)
    at Object.checkValidationErrors (/Users/les/projects/spatialexplorers/dagenapp/node_modules/@graphql-codegen/core/node_modules/@graphql-tools/utils/index.cjs.js:517:15)

I can't reproduce it with the same codebase

Even if it's not reproducible, I suggest providing context and configuration, therefore people can get a hint from it.
I have experienced a few non-reproducible behaviors before(not with graphql-code-generator).
And one turned out that a database .sql file was broken "somehow".
The broken piece was not visible in IDE, but only parsable when checking every bit (think of it smillar to something like EOF or line breaking error).
So I created a new file and wrote the same SQL, and it worked.
What if you check if some files are corrupted, and/or just manually rewriting(not copy-paste) them from the scratch?

I've tried eliminating as many possible points of failures, reducing the operations to just one, config without near operation file and a clean install on a different machine.
I'm just looking for a way to dive deeper into my problem.
It's something very specific to this project and its packages

I've been having the same issue today after updating the packages, notably also using hasura. After experimenting for a bit I figured out a way to get the code generator to work again.
Here's the steps I took and what I think is the cause of this problem somewhere down the dependency tree.
First of all, I generated a schema.graphql file using graphqurl to test if something went wrong with schema generation in codegen. I used this specific command: npx graphqurl http://localhost:8080/v1/graphql -H "X-Hasura-Admin-Secret: supersecrethere" --introspect > schema.graphql
The errors that @lkleuver and me experiences where these on every type:
GraphQLDocumentError: Cannot query field X on type "Query". # or '... on type "Mutation"

After noticing a schema type, e.g. specifically the following:
schema {
  query: query_root
  mutation: mutation_root
  subscription: subscription_root
}

I tried renaming query_root -> Query, mutation_root -> Mutation and subscription_root -> Subscription to make sure the types actually exist, and when I then feed the .graphql file into the code-generator it works!
I think we can conclude from this, since it definitely worked before, that a 'breaking change' occurred in one of the versions of the dependencies of graphql-codgen, in parsing the schema field. I think before, it used to recognize the schema type and act accordingly by using the custom types defined, for the proper root types.
In which packages this exactly happens, I don't know and any points / hints to this to properly sort this out and report this would be great!

Related issue: https://github.com/dotansimha/graphql-code-generator/issues/5758

Thanks to @ItsWendell investigative work I got to resolve this by reverting to 1.15.0
it works now, though without a real solution :)


[Refactor] Remove old /collect app

Removes old /collect app and renames /collect2 to /collect.

[ ] Remove NEW_COLLECT_PAGE_ENABLED from hokusai

Merging per offline convo


wip: Added hook: check_model_has_tests_by_group

This PR adds a hook that checks if a model has a sufficient number of tests pulled out of a group of acceptable tests, e.g. this model has 1 of unique, unique_where, or unique_threshold.

Codecov Report

Merging #6 (d339f07) into main (6a24a42) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           35        35
  Lines         1485      1479    -6
  Branches       192       192
=========================================
- Hits          1485      1479    -6

Impacted Files
Coverage Δ

pre_commit_dbt/utils.py
100.00% <0.00%> (ø)

pre_commit_dbt/check_column_desc_are_same.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a24a42...d339f07. Read the comment docs.

Looks great 🎉! I have run even mutation testing and all passes. Just delete unnecessary try and delete the unused import and we can merge that.

awesome. i just added a new commit to take care of requested changes.

resolve #5