Redirect instead of popup

Is there any way to log in with a redirect instead of a popup (like Stack Overflow's login)?

Hi Sahat,
I used satellizer within my frontend angular spa, my backend api is seperated. Now i want to reuse my frontend code within a hybrid mobile app using ionic or cordova framework.
Does the satellizer popups work with this mobile hybrid apps?
Thanks

@ersensen It works slightly different, but yes they do, using the InAppBrowser. Take a look at the Ionic example provided in the examples directory.

I've invested a great deal of time getting Satellizer working for various sites - now we see the login does not work in "standalone" mode on iOS.
Is there a Satellizer solution for when the user pins the url to the home screen, AND the html contains
		<meta name="apple-mobile-web-app-capable" content="yes">
		<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">

Would the mobile:true work for this?

@dcolley Did you make it work finally with mobile: true?

@nass600 we did not get this to work in 'standalone' mode. For now we will stick with satellizer for the [mobile+desktop] web channel. We're going to switch to native apps for better integration with each device.


fix: Cannot configure advertised listeners to use host ip for external clients

What this PR does / why we need it:
Hello @faraazkhan @h0tbird @benjigoldberg ,
This PR is a fix the the following issue.

Cannot configure advertised listeners to use host ip for external clients #11370

I solved the LoadBalancer setting scenario. This fix doesn't affects for NodePort configuration. This fix enable to use this chart for LoadBalancer settings. I tested on Azure. However, it is the same for other cloud platforms.  The change is small. However, I'd like to discuss the spec with you guys before writing the document.
Special notes for your reviewer:
Root Cause
The issue is caused by this reason. If the external client get the metadata (e.g. `kafkacat -b : -L) and access trough LoadBalancer, the Service transport the message with TargetPort. Currently, it is 9092(headless default).  The broker pods receives get message with 9092, they return the metadata of 9092 which is for internal metadata.
Fix
In case of the Load Balancer setting, set the TargetPort as the same Port number as the Service.
It returns correct listener address.
Additional Fix
However, once we enable it, it works for single broker.  Once you try to configure multiple brokers, it cause a problem. First, we need to get the LoadBalancer IP address at the broker container side to configure advertised.listeners.  I add LOAD_BALANCER_IP environment variables for it. If it is not fit the naming convention, please let me know.
It solves the configuration issue, then,  I'll receive this error.  (I change the IP address to be fake.)
[2019-04-08 07:46:40,288] ERROR [MetadataCache brokerId=0] Listeners are not identical across brokers: Map(2 -> Map(ListenerName(PLAINTEXT) -> md-kafkas-2.md-kafkas-headless.default:9092 (id: 2 rack: null), ListenerName(EXTERNAL2) -> <IP_ADDRESS>9:31092 (id: 2 rack: null)), 1 -> Map(ListenerName(PLAINTEXT) -> md-kafkas-1.md-kafkas-headless.default:9092 (id: 1 rack: null), ListenerName(EXTERNAL1) -> <IP_ADDRESS>9:31091 (id: 1 rack: null)), 0 -> Map(ListenerName(PLAINTEXT) -> md-kafkas-0.md-kafkas-headless.default:9092 (id: 0 rack: null), ListenerName(EXTERNAL0) -> <IP_ADDRESS>9:31090 (id: 0 rack: null))) (kafka.server.MetadataCache)

Since current configuration of helm, if we have several brokers which means several LoadBalancers, It have a different Port number. like 31090 , 31091... and so on. Which means we need to define Listeners for corresponding to the Port number. However, this feature might be for NodePort settings. Since LoadBalancer settings requires different IP address, It doesn't make sense, and also, it cause that error because of kafka checking if the advertised.listener is identical or not. However, if I configure listener like EXTERNAL0, EXTERNAL1... it also cause a problem. The first pod works correctly, the second pod fails because of the duplicated entry.
So, In case of LoadBalancer, I change not to change the LoadBancer Port for each LoadBalancers.
Now, we can configure something like this.  IP Addresses are fake.
values.yaml
## External access.
##
external:
  type: LoadBalancer
  # annotations:
  #  service.beta.kubernetes.io/openstack-internal-load-balancer: "true"
  dns:
    useInternal: false
    useExternal: false
  # create an A record for each statefulset pod
  distinct: false
  enabled: true
  servicePort: 19092
  firstListenerPort: 31090
  domain: cluster.local
  loadBalancerIP:
    - <IP_ADDRESS>9
    - <IP_ADDRESS>9
    - <IP_ADDRESS>9

  externalTrafficPolicy: Local
  init:
    image: "lwolf/kubectl_deployer"
    imageTag: "0.4"
    imagePullPolicy: "IfNotPresent"

# Annotation to be added to Kafka pods
podAnnotations: {}

## Configuration Overrides. Specify any Kafka settings you would like set on the StatefulSet
## here in map format, as defined in the official docs.
## ref: https://kafka.apache.org/documentation/#brokerconfigs
##
configurationOverrides:
  "offsets.topic.replication.factor": 3
  "confluent.support.metrics.enable": false  # Disables confluent metric submission
  "auto.leader.rebalance.enable": true
  # "auto.create.topics.enable": true
  # "controlled.shutdown.enable": trueooder0
  # "controlled.shutdown.max.retries": 100

  ## Options required for external access via NodePort
  ## ref:
  ## - http://kafka.apache.org/documentation/#security_configbroker
  ## - https://cwiki.apache.org/confluence/display/KAFKA/KIP-103%3A+Separation+of+Internal+and+External+traffic
  ##
  ## Setting "advertised.listeners" here appends to "PLAINTEXT://${POD_IP}:9092,"
  "advertised.listeners": EXTERNAL://${LOAD_BALANCER_IP}:31090
  "listener.security.protocol.map": PLAINTEXT:PLAINTEXT,EXTERNAL:PLAINTEXT
  "listeners": PLAINTEXT://:9092,EXTERNAL://:31090
  "inter.broker.listener.name": "PLAINTEXT"

Comments for reviewers
I need some discussion.
Variable name which we can use in the advertised.listerner
I use it as LOAD_BALANCER_ID. However, I don't know it is good for you guys.
Specification of LoadBalancer settings
In case of LoadBalancer, I believe, we should configure that all LoadBalancer can have the same port number. However, according to the helm chart, You change the source of the port number according to the external.distinct .
the service-brokers-external.yaml

external.distinct : true, external.type: LoadBalancer
port: servicePort, targetPort: servicePort
external.distinct : false, external.type. LoadBalancer
port: externalListenerPort (current -> I change it to firstListerPort) , targetPort: externalListenerPort(current ->I change it to firstListenerPort)

However, I don't know your intention for it. We might introduce new parameter which enable to use the same port in case of LoadBalancer. I'm not sure the case of the LoadBalancer with inclement port number. If it is necessary, I'd happy to modify it to add the new parameter like enableSinglePort or something.
I don't write a document, however, once discussion is finished, I'd happy to write it.
I hope this PR helps people enjoy kafka more easily on k8s.
I explain what it looks like on this blog.
https://medium.com/@tsuyoshiushio/configuring-kafka-on-kubernetes-makes-available-from-an-external-client-with-helm-96e9308ee9f4
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md

Hello @faraazkhan @h0tbird @benjigoldberg ,
I resolve the conflict and modify code to fit it with some improvement of the shell script. Could you review this, please?

Hello @faraazkhan @h0tbird @benjigoldberg, this is friendly reminder.  I'd appreciate you guys if you could take a look.

@TsuyoshiUshio awesome work on this PR, the writeup, etc. I think your naming conventions for LOAD_BALANCER_IP look good to me. I also like the behavior you decided on re port numbers. Thank you for putting so much effort into this.
/ok-to-test

/retest

Hi @benjigoldberg ,
I mistook the operation of the git. I use the Resolve conflicts of the browser stuff. It caused this mess.
I'll create a new PR from current master and just add three files change as original. :) Please wait for a while. Once I create a new PR, I'll mention you and link from here.

Hi @benjigoldberg
I create a new PR (but the same PR with this)  and test it in my environment. I do the same thing however, just clean up the commit log and create branch from current master.
Please discuss on this and close this PR.
https://github.com/helm/charts/pull/13155

The new PR is merged. so I close this. thanks.


Autodetect javahome?

I'm using the below statement to autodetect javahome as of now (in linux systems):
os.environ["JAVAHOME"] = str(os.popen('which java').read()).rstrip()


Keeps Priority 0 in the sitemap

Adds 1 decimal place in sitemap for all Prority. e.g. 1 becomes 1.0

Thanks!


Emails are going to spam

Validation emails and reset password emails are going to some people's spam folders.
Set up DKIM/SPA records in the dns.
Add a disclaimer to check spam folder.

Updated DKIM with Route 53. Added message to alerts to check spam folder and/or whitelist my-whiskies.online.
Updated alert colors because I had an irrational level of dislike for the bootstrap alert colors.


ReconnectFix

step to reproduce problem in previous version:
start your service without Kafka and Zookeeper
bring up Kafka and Zookeeper and service won't connect
after embedding this fix, step 2 will connect

Hi,
you completely remove all connection retries?
why not just limit it to X times?
the problem is:
if my service (service that use 'no-kafka' package) is up before 'Kafka' is
up, it will never connect
בתאריך יום ג׳, 29 בינו׳ 2019 ב-17:22 מאת Oleksii Kryvoshei <
notifications@github.com>:

This code has been intentionally removed in #240
https://github.com/oleksiyk/kafka/pull/240. The reason has been
described in #239 https://github.com/oleksiyk/kafka/pull/239
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/oleksiyk/kafka/pull/249#issuecomment-458580363, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AsghcFeQO08-tNLd34ZlWcKbBweji3uvks5vIGc4gaJpZM4aJo6O
.


[Bug] Copy/paste is not allowed

Describe the bug
The copy and pasting inside the editor does not work.
To Reproduce
Steps to reproduce the behavior:

Go to the block and try to paste any text from anywhere.

Expected behavior
Should paste the text, at least as paragraph.
Additional context
Is there maybe a way to activate it, or change the behavior for pasting?

Hi,
This library should not be used in production.
I am well aware of the bug you're discussing about, and I won't fix it as I no longer need to work on that library.
It's super hard to fix because of the complexity of the code. My advice is you use another library.
Sorry for the mixed signals.


Fix awk command in init.sh generating resolvers.conf file

Fixes #312

@baxtersa Thanks for identifying this problem and addressing the script command. Out of curiosity, have you signed an Apache ICLA?  If you have not, and wish to contribute more extensive code fixes, please consider it.

@mrutkows No problem! I submitted an Apache ICLA last week. I think I should be set on that front.


Make Sprockets support optional

Rails API has no Sprockets support

Does one need to use this gem for a pure Rails-API app?

GZip for JSON Data.

It's possible to add the Rack::Deflate to the rack stack in this case. I don't think that you need the extra features that this gem provides.

We just ran into this today, after upgrading from Rails 4.2 to Rails 5. We deploy a Rails API together with a webpack-based React app. With Rails 4.2, we were able to comment out the sprockets require. With Rails 5, we need to require it.

Update: I opted for plain old Rack::Deflater instead for my JSON and will use compression for my CDN-served assets. Cheers.


Custom dungeon compatibility with LethalLib

Is there a decent way to easily integrate a custom dungeon (which is built via LethalLib) into a custom planet? Or rather: force a custom flow type on a moon? If not via LethalLib, just a native implementation for this SDK?
I'm down to look into it myself and submit a PR if I do figure it out, but I figured I'd ask nevertheless

Is there a decent way to easily integrate a custom dungeon (which is built via LethalLib) into a custom planet? Or rather: force a custom flow type on a moon? If not via LethalLib, just a native implementation for this SDK? I'm down to look into it myself and submit a PR if I do figure it out, but I figured I'd ask nevertheless

i dunno how LethalLib implement the new dungeons, if it's a new normal flow i guess putting it's ID in the moon asset would be enough
native dungeon support for SDK is planned tho

Is there a decent way to easily integrate a custom dungeon (which is built via LethalLib) into a custom planet? Or rather: force a custom flow type on a moon? If not via LethalLib, just a native implementation for this SDK? I'm down to look into it myself and submit a PR if I do figure it out, but I figured I'd ask nevertheless

i dunno how LethalLib implement the new dungeons, if it's a new normal flow i guess putting it's ID in the moon asset would be enough native dungeon support for SDK is planned tho
https://github.com/EvaisaDev/LethalLib/blob/60d42612d19dbe329175a80dfc41bc601a0ec3eb/LethalLib/Modules/Dungeon.cs#L28 following the logic from LethalLib it's just adding it as a flow somewhere down the line, so it shouldn't be that hard. Only issue is I won't/can't know which flow ID LethalLib used for my custom flow, so I can't really assign it to my custom moon. At least I don't think? Again might look into it later myself and submit a PR if I figure something out

Is there a decent way to easily integrate a custom dungeon (which is built via LethalLib) into a custom planet? Or rather: force a custom flow type on a moon? If not via LethalLib, just a native implementation for this SDK? I'm down to look into it myself and submit a PR if I do figure it out, but I figured I'd ask nevertheless

i dunno how LethalLib implement the new dungeons, if it's a new normal flow i guess putting it's ID in the moon asset would be enough native dungeon support for SDK is planned tho
https://github.com/EvaisaDev/LethalLib/blob/60d42612d19dbe329175a80dfc41bc601a0ec3eb/LethalLib/Modules/Dungeon.cs#L28 following the logic from LethalLib it's just adding it as a flow somewhere down the line, so it shouldn't be that hard. Only issue is I won't/can't know which flow ID LethalLib used for my custom flow, so I can't really assign it to my custom moon. At least I don't think? Again might look into it later myself and submit a PR if I figure something out

yes, but a dungeon flow is a matrix of 40 prefabs, with specific elements in each prefab to define where are the doors, where can be the scraps, where can be the fireexists, etc
it's more complex than add a flow down the line

Is there a decent way to easily integrate a custom dungeon (which is built via LethalLib) into a custom planet? Or rather: force a custom flow type on a moon? If not via LethalLib, just a native implementation for this SDK? I'm down to look into it myself and submit a PR if I do figure it out, but I figured I'd ask nevertheless

i dunno how LethalLib implement the new dungeons, if it's a new normal flow i guess putting it's ID in the moon asset would be enough native dungeon support for SDK is planned tho
https://github.com/EvaisaDev/LethalLib/blob/60d42612d19dbe329175a80dfc41bc601a0ec3eb/LethalLib/Modules/Dungeon.cs#L28 following the logic from LethalLib it's just adding it as a flow somewhere down the line, so it shouldn't be that hard. Only issue is I won't/can't know which flow ID LethalLib used for my custom flow, so I can't really assign it to my custom moon. At least I don't think? Again might look into it later myself and submit a PR if I figure something out

yes, but a dungeon flow is a matrix of around 40 prefabs, with specific elements in each prefab to define where are the doors, where can be the scraps, where can be the fireexists, etc it's more complex than just add a flow down the line

yeah I know, but I got it working perfectly with LethalLib (setting up all the prefabs was a ton of work but I got it working), so it can't be too bad to port over, idk I'll have a look at it

Is there a decent way to easily integrate a custom dungeon (which is built via LethalLib) into a custom planet? Or rather: force a custom flow type on a moon? If not via LethalLib, just a native implementation for this SDK? I'm down to look into it myself and submit a PR if I do figure it out, but I figured I'd ask nevertheless

i dunno how LethalLib implement the new dungeons, if it's a new normal flow i guess putting it's ID in the moon asset would be enough native dungeon support for SDK is planned tho
https://github.com/EvaisaDev/LethalLib/blob/60d42612d19dbe329175a80dfc41bc601a0ec3eb/LethalLib/Modules/Dungeon.cs#L28 following the logic from LethalLib it's just adding it as a flow somewhere down the line, so it shouldn't be that hard. Only issue is I won't/can't know which flow ID LethalLib used for my custom flow, so I can't really assign it to my custom moon. At least I don't think? Again might look into it later myself and submit a PR if I figure something out

yes, but a dungeon flow is a matrix of around 40 prefabs, with specific elements in each prefab to define where are the doors, where can be the scraps, where can be the fireexists, etc it's more complex than just add a flow down the line

yeah I know, but I got it working perfectly with LethalLib (setting up all the prefabs was a ton of work but I got it working), so it can't be too bad to port over, idk I'll have a look at it

The difference is I don't put any vanilla or external script in the SDK
I'll have to rebuild every fields
Look how are made the moons in the SDK
The SDK build 5/6 objects from one

Is there a decent way to easily integrate a custom dungeon (which is built via LethalLib) into a custom planet? Or rather: force a custom flow type on a moon? If not via LethalLib, just a native implementation for this SDK? I'm down to look into it myself and submit a PR if I do figure it out, but I figured I'd ask nevertheless

i dunno how LethalLib implement the new dungeons, if it's a new normal flow i guess putting it's ID in the moon asset would be enough native dungeon support for SDK is planned tho
https://github.com/EvaisaDev/LethalLib/blob/60d42612d19dbe329175a80dfc41bc601a0ec3eb/LethalLib/Modules/Dungeon.cs#L28 following the logic from LethalLib it's just adding it as a flow somewhere down the line, so it shouldn't be that hard. Only issue is I won't/can't know which flow ID LethalLib used for my custom flow, so I can't really assign it to my custom moon. At least I don't think? Again might look into it later myself and submit a PR if I figure something out

yes, but a dungeon flow is a matrix of around 40 prefabs, with specific elements in each prefab to define where are the doors, where can be the scraps, where can be the fireexists, etc it's more complex than just add a flow down the line

yeah I know, but I got it working perfectly with LethalLib (setting up all the prefabs was a ton of work but I got it working), so it can't be too bad to port over, idk I'll have a look at it

The difference is I don't put any vanilla or external script in the SDK I'll have to rebuild every fields Look how are made the moons in the SDK The SDK build 5/6 objects from one I can't buy DunGen to place it in the SDK neither, this is not legal The goal of the SDK is to do everything with embed HUD The amount of work is not same

Hmm right okay, I see what you're getting at no worries!
In that case I'll have to make my plugin the messenger between the two libraries, mind if I submit a PR that makes all classes public rather than internal for this instead then?

yes, you can do this PR
i'll made it in next update anyway
for now i'm taking 3/4 days of resting

No worries!
Happy Holidays!


Add RSpec/FactoryBot/AssociationStyle cop

In FactoryBot, there are 2 ways to define associations.
# implicit style
factory :article do
  user
end

# explicit style
factory :article do
  association :user
end

These styles are documented at the following section:

https://github.com/thoughtbot/factory_bot/blob/ec71611954d07419c9b668be03641332443dcd78/GETTING_STARTED.md#associations

(Stricyly speaking, there is also inline style, but it behaves differently from the above 2 styles.)
It would be nice to have a cop for consistent use of only one of the styles. This Pull Request has been created for this purpose.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[x] Added the new cop to config/default.yml.
[x] The cop is configured as Enabled: pending in config/default.yml.
[x] The cop is configured as Enabled: true in .rubocop.yml.
[x] The cop documents examples of good and bad code.
[x] The tests assert both that bad code is reported and that good code is not reported.
[x] Set VersionAdded in default/config.yml to the next minor version.

If you have modified an existing cop's configuration options:

[ ] Set VersionChanged in config/default.yml to the next major version.

It seems that over time, all the three progressed. I was still believing that the implicit way didn't allow specifying factory: as it was in 5.0. Good to know FB improved so much on this front.
Personally, I strongly prefer the inline definition, for three reasons:

usage of instance (could be done before 6.0 with some hack, too) to refer to the model from association definitions
refer to (transient) attributes
with one-to-many associations an approach with no need for after(:create) that implies create strategy, or multiple per-strategy hooks that tend to get out of sync

The downside is that it's the most verbose out of the three in most of the cases.

it behaves differently from the above 2 styles

Is there anything else that I'm missing?

The implicit style run with real-world-rspec yields some false positives:
/Users/pirj/source/real-world-rspec/gitlabhq/spec/factories/issues.rb:49:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    factory :closed_issue, traits: [:closed]
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/pirj/source/real-world-rspec/gitlabhq/spec/factories/issues.rb:50:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    factory :reopened_issue, traits: [:opened]
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The explicit style run results in some errors:
An error occurred while RSpec/FactoryBot/AssociationStyle cop was inspecting /Users/pirj/source/real-world-rspec/cartodb/spec/factories/likes.rb:2:2.
undefined method `begin_type?' for nil:NilClass
/Users/pirj/source/rubocop-rspec/lib/rubocop/cop/rspec/factory_bot/association_style.rb:154:in `children_of_factory_block'
/Users/pirj/source/rubocop-rspec/lib/rubocop/cop/rspec/factory_bot/association_style.rb:142:in `bad_associations_in'
/Users/pirj/source/rubocop-rspec/lib/rubocop/cop/rspec/factory_bot/association_style.rb:45:in `on_send'

for e.g.:
FactoryBot.define do
  factory :like, class: Carto::Like do
  end
end

    factory 'valid site' do
      # after(:build) { |valid_site| valid_site.stubs(:valid?).returns(true) }
    end

Implicit:
57497 files inspected, 191 offenses detected, 191 offenses autocorrectable

Explicit:
57497 files inspected, 911 offenses detected, 911 offenses autocorrectable

Going with the implicit as the default enforced style seems reasonable 👍

For the reference, this (apart from probably pending -> true) was needed to run the cop against real-world-rspec:

it behaves differently from the above 2 styles

Is there anything else that I'm missing?

As noted in the documentation, attributes defined by inline-style return nil when called with attributes_for strategy.
My personal preference is to use inline-style only when I need it and not otherwise. If I always use inline-style, it makes difficult to infer from the code whether I am doing so because inline-style is necessary in the case or not.
If there seems to be a certain number of people who want to use the inline-style all the time, it might be nice to have a style in this cop that always prefers the inline-style. The downside is that it is quite difficult to autocorrect from inline-style to the other styles for the reasons mentioned above.

implicit
57497 files inspected, 206 offenses detected, 206 offenses autocorrectable

Concerns
/Users/pirj/source/real-world-rspec/hound/spec/factories.rb:77:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use implicit style to define associations.
    association :repo, :active, :private
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/Users/pirj/source/real-world-rspec/gitlabhq/spec/factories/clusters/kubernetes_namespaces.rb:5:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use implicit style to define
associations.
    association :cluster, :project, :provided_by_gcp
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Would the following be a valid FactoryBot syntax?
repo :active, :private
cluster :project, :provided_by_gcp

Using traits with associations only has examples with the explicit syntax.
explicit
57497 files inspected, 1026 offenses detected, 1026 offenses autocorrectable

False positives
Static attributes
Static attributes were deprecated in FactoryBot 4.11 and removed in 5.0.
4.11 is nearly 5 years old, but I don't think it is a reasonable decision to break support for it for several major repos.
/Users/pirj/source/real-world-rspec/sharetribe/spec/factories.rb:535:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    version           '1'
    ^^^^^^^^^^^^^^^^^^^^^
/Users/pirj/source/real-world-rspec/sharetribe/spec/factories.rb:536:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    content           CustomLandingPage::ExampleData::DATA_STR
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/pirj/source/real-world-rspec/sharetribe/spec/factories.rb:541:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    enabled           true
    ^^^^^^^^^^^^^^^^^^^^^^
/Users/pirj/source/real-world-rspec/sharetribe/spec/factories.rb:545:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    listing_id 123
    ^^^^^^^^^^^^^^
/Users/pirj/source/real-world-rspec/sharetribe/spec/factories.rb:546:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    blocked_at Date.current
    ^^^^^^^^^^^^^^^^^^^^^^^

What do you think if the cop should only register an offence if the first argument is a hash?
Another option would be to introduce TargetFactoryBotVersion. Wondering if this is something we can do in a minor release, @bquorning @Darhazer ?
Blockpass
/Users/pirj/source/real-world-rspec/diaspora/spec/factories.rb:69:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    password_confirmation(&:password)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

build_association
/Users/pirj/source/real-world-rspec/sharetribe/spec/factories.rb:499:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    build_association(:paypal_account)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

sequence
/Users/pirj/source/real-world-rspec/gitlabhq/spec/factories/terraform/state_version.rb:9:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    sequence(:version)
    ^^^^^^^^^^^^^^^^^^

/Users/pirj/source/real-world-rspec/chatwoot/spec/factories/channel/channel_widget.rb:6:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associat
ions.
    sequence(:widget_color, &:to_s)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

factory
/Users/pirj/source/real-world-rspec/gitlabhq/spec/factories/keys.rb:22:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    factory :deploy_key, class: 'DeployKey'
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/pirj/source/real-world-rspec/gitlabhq/spec/factories/issues.rb:48:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    factory :closed_issue, traits: [:closed]
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

to_create
/Users/pirj/source/real-world-rspec/cartodb/spec/factories/geocodings.rb:4:5: C: [Correctable] RSpec/FactoryBot/AssociationStyle: Use explicit style to define associations.
    to_create(&:save)
    ^^^^^^^^^^^^^^^^^

❓ Side note about using traits
This is ambiguous:
factory :word do
  letters { "bar" }
  type { "noun" }

  trait :article do
    type { :article }
  end

  factory :the do
    article
    letters { "the" }
  end

Unless we parse traits in context, it's hard to understand if article is an association or a trait.
With factory :verb, parent: :word placed in a separate file, this is getting impossible.
An alternative syntax makes it unambiguous:
  factory :the, traits: [:article] do
    letters { "the" }
  end

Might be an idea for a cop. Still, we won't be able to rely on that cop to be turned on and all traits to be defined in a factory call.

I can also think of traits_for_enum for completeness. Wondering if there's anything else available to use/override in the context of a factory that we have to consider ignoring.

Would the following be a valid FactoryBot syntax?
repo :active, :private
cluster :project, :provided_by_gcp

It seems that the implicit style does not allow such trait usage, so I need to fix #autocorrect_to_implicit_style for this.
# frozen_string_literal: true

require 'bundler/inline'

gemfile do
  source 'https://rubygems.org'

  gem 'factory_bot'
end

FactoryBot.define do
  factory :article do
    trait :active do
      active { true }
    end
  end

  factory :comment do
    article :active
  end
end

$ ruby wrong_association.rb
/home/r7kamura/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/factory_bot-6.2.1/lib/factory_bot/definition_proxy.rb:99:in `method_missing': undefined method 'article' in 'comment' factory (NoMethodError)
Did you mean? 'article { :active }'

        raise NoMethodError.new(<<~MSG)
        ^^^^^
        from wrong_association.rb:19:in `block (2 levels) in <main>'
        from /home/r7kamura/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/factory_bot-6.2.1/lib/factory_bot/syntax/default.rb:18:in `instance_eval'
        from /home/r7kamura/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/factory_bot-6.2.1/lib/factory_bot/syntax/default.rb:18:in `factory'
        from wrong_association.rb:18:in `block in <main>'
        from /home/r7kamura/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/factory_bot-6.2.1/lib/factory_bot/syntax/default.rb:37:in `instance_eval'
        from /home/r7kamura/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/factory_bot-6.2.1/lib/factory_bot/syntax/default.rb:37:in `run'
        from /home/r7kamura/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/factory_bot-6.2.1/lib/factory_bot/syntax/default.rb:7:in `define'
        from wrong_association.rb:11:in `<main>'

Instead, it can be written by using factory option:
# frozen_string_literal: true

require 'bundler/inline'

gemfile do
  source 'https://rubygems.org'

  gem 'activerecord', '~> 7.0.0'
  gem 'factory_bot'
  gem 'sqlite3'
end

require 'active_record'
require 'logger'
require 'minitest/autorun'

ActiveRecord::Base.establish_connection(
  adapter: 'sqlite3',
  database: ':memory:'
)

ActiveRecord::Schema.define do
  create_table :articles, force: true do |t|
    t.boolean :active, default: false
  end

  create_table :comments, force: true do |t|
    t.references :article
  end
end

class Article < ActiveRecord::Base
end

class Comment < ActiveRecord::Base
  belongs_to :article
end

FactoryBot.define do
  factory :article do
    trait :active do
      active { true }
    end
  end

  factory :comment do
    article factory: [:article, :active]
  end
end

class FactoryTest < Minitest::Test
  def test_association
    assert ::FactoryBot.create(:comment).article.active
  end
end

$ ruby example.rb
-- create_table(:articles, {:force=>true})
   -> 0.0024s
-- create_table(:comments, {:force=>true})
   -> 0.0003s
Run options: --seed 55593

# Running:

.

Finished in 0.010602s, 94.3227 runs/s, 94.3227 assertions/s.

1 runs, 1 assertions, 0 failures, 0 errors, 0 skips

I might be talking nonsense, but as an alternative to
article factory: [:article, :active]

would it be possible to write it as
article traits: [:active]

Which one would you prefer?

I feel you. I actually tried that example before posting the previous comment too, but I couldn't use :traits option on implicit style. In that example, I don't want to write "article" twice, and I too think that ideally :traits should be available here.

@r7kamura Would you re-target this to rubocop-factory_bot, please?

Recreated on rubocop-factory_bot repo:

https://github.com/rubocop/rubocop-factory_bot/pull/33


unclear relationship between src and lib.entryFile in ng-package.json

Type of Issue
[x] Bug Report
[ ] Feature Request

Description
as described in the title, in the older version(like 1.6.0), the lib.entryFile is relative to src, now there is no relation. So it can't find the target entry file now if i don't update the entryFile.
How To Reproduce
Not needed
Expected Behavior
It cloud stay the current behavior, but we should state out the issue, it's not mentioned in breaking changes
Version Information
ng-packagr: 2.0.0-rc.6
@angular/*: 5.1.1
typescript: 2.5.3
node: 8.9.0
npm/yarn: 1.3.2

Hi @e-cloud,
yes, it wasn't mentioned in the changelog for rc6. It hopefully is in rc7 changelog more clarified.
The reason for src has been that ng-packagr used to regex/copy files for resource inlining. In the 2.x version, it's going to replace that with the typescript transformations API and thus there is no more need for globbing file patterns like <src>/**/*.ts.
The src property is eventually going to be dropped.

Fixed / adressed in rc8


Refactor View Profile

remove the profile thing from the main navbar
when you click the current's user picture, take them to a new activity to view
have the edit button take to the edit activity
search takes to another activity to view profile
maybe send the userid to view profile instead of the user, i find that the user crashes when serialized

Related: #68 #64


Get rid of Javascript Executor (close #60)

Javascript Executor was used only in the automation.playback method.
This method was required only for testing purposes, but we don't have
functionality for this test anymore. So we should get rid of the test,
method and Javascript Executor.
/cc @AlexanderMoskovkin

lgtm


fix: added eventsServiceFactory to defaultServiceFactories

Hey, I just made a Pull Request!

added eventsServiceFactory to defaultServiceFactories to resolve issue where different instances of the EventsServices could be used
related to #24319
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@marleypowell sorry it's taken a while to get round to this -  can you rebase this :pray:

@marleypowell sorry it's taken a while to get round to this - can you rebase this 🙏

got there eventually. I think that's done 🙂

@marleypowell think that you'll need to regenerate the api-reports in order to get this passing.
yarn build:api-reports in the root and commit the changes should do it :tada:

@benjdlambert thanks for getting this merged for me 🙂


Tuple & nominal not recognised as tuple in spread parameter

Bug Report

🔎 Search Terms

Nominal, Spread, Tuple,
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about spread and intersections

⏯ Playground Link

Playground link with relevant code
💻 Code

declare let a: [number, number, number] & { _nominal_a: never }
function b(...params: [number, number, number]) {}
b(...a) // Error: A spread argument must either have a tuple type or be passed to a rest parameter.

🙁 Actual behavior

The error in the code example is thrown, because TypeScript does not detect it as being a tuple.
In roblox-ts, we use a nominal marker type to indicate a special kind of tuple. This bug means that this tuple type can then not be spreaded into a fixed argument function. Our issue: https://github.com/roblox-ts/roblox-ts/issues/1537
🙂 Expected behavior

This is a tuple type, and should therefore be recognised as such.

I recently ran into this error too, and worked around it by hinting the type via the as keyword, eg.
function mergeDictionaries(...dictionaries: { [key: string]: unknown }[]): {
  [key: string]: unknown;
} {
  return Object.assign(
    ...(dictionaries.map((dictionary) => {
      return JSON.parse(JSON.stringify(dictionary));
    }) as [{ [key: string]: unknown }])
  );
}

... without the [{ [key: string]: unknown }]) bit, an error similar to the following pops;

<file>.ts|<C> col <L> error| A spread argument must either have a tuple type or be passed to a rest parameter.

What I find somewhat trubling, beyond TypeScript loosing the plot in the first place, is that Array<T> will produce the same error, eg.
function mergeDictionaries(...dictionaries: { [key: string]: unknown }[]): {
  [key: string]: unknown;
} {
  return Object.assign(
    ...(dictionaries.map((dictionary) => { /* ← Error on this line */
      return JSON.parse(JSON.stringify(dictionary));
    }) as Array<{ [key: string]: unknown }>) /* ← Why is [{}] required? */
  );
}

What I find somewhat trubling, beyond TypeScript loosing the plot in the first place, is that Array<T> will produce the same error, eg.

This usually makes sense, because you don't know the Array's length.
I believe this not working in this case is a separate missing behaviour, which is that normal parameters need to be filled manually, not being considered to be part of the rest parameter. What I mean by that is that a function like a(obj: object, ...other: object[]) will not allow a call like a(...objects) where objects is Array<object>, despite this being type-compatible.

Hmm, I supose I'll have to dig deeper into how TypeScript parses things. Because I'm still a bit befuddled that as Array<{ [key: string]: unknown }> throws errors but using the same hint for a parameter doesn't present issues, eg.
function mergeDictionaries(
  ...dictionaries: Array<{ [key: string]: unknown }>  /* ← Totally okay */
  // ...dictionaries: [{ [key: string]: unknown }]    /* ← this is fine too */
): {
  [key: string]: unknown;
} {
  return Object.assign(
    ...(dictionaries.map((dictionary) => {
      return JSON.parse(JSON.stringify(dictionary));
    }) as [{ [key: string]: unknown }])
    // }) as { [key: string]: unknown }[])       /* ← Nope */
    // }) as Array<{ [key: string]: unknown }>)  /* ← no joy either */
  );
}

Hmm, I supose I'll have to dig deeper into how TypeScript parses things. Because I'm still a bit befuddled that as Array<{ [key: string]: unknown }> throws errors but using the same hint for a parameter doesn't present issues, eg.
function mergeDictionaries(
  ...dictionaries: Array<{ [key: string]: unknown }>  /* ← Totally okay */
  // ...dictionaries: [{ [key: string]: unknown }]    /* ← this is fine too */
): {
  [key: string]: unknown;
} {
  return Object.assign(
    ...(dictionaries.map((dictionary) => {
      return JSON.parse(JSON.stringify(dictionary));
    }) as [{ [key: string]: unknown }])
    // }) as { [key: string]: unknown }[])       /* ← Nope */
    // }) as Array<{ [key: string]: unknown }>)  /* ← no joy either */
  );
}

I'm mapping a dispatch into a object and this is freaking my mind.
// not actual example but close
Object.fromEntries(
  Object.entries(actions)
    .map(entry => [
      entry[0],
      (...args: Parameters<typeof entry[1]>) => dispatch(entry[1](...args))
    ])
)

There is no reason for that be a problem, mainly because not allowing arrays as spread arguments should be a linter problem, not a compiler problem.

Made a Playground Link for your code example, and I'm failing to spot any issue in this. In any case, it's probably similar to the above comment by S0AndS0, and as explained not a related problem.

I am not sure if this is related, or supposed to occur... However, when attempting to brand or flavor a tuple it appears that TypeScript is no longer able to restrict property access past the length of the tuple.
Example
declare const id: unique symbol;
type Id<T> = { readonly [id]: T };

type Brand<T, U> = T & Id<U>;
type PartialBrand<T, U> = T & Partial<Id<U>>; // Also known as Flavor.

declare const pointId: unique symbol;
type Point = PartialBrand<[number, number], typeof pointId>;

const point = (x: number = 0, y: number = 0): Point => [x, y];

const add = (a: Point, b: Point, c: Point = point()): Point => {
  c[0] = a[0] + b[0];
  c[1] = a[1] + b[1];
  return c;
};

const a = point(0, 1);
const b = point(2, 3);
const c = add(a, b);

console.log(c);

c[0] = 4;
c[1] = 5;
c[2] = 6; // Should be an error!

console.log(c);

Playground Link
It appears that the expansion of the type includes [x: number]: number. Maybe I should open this a separate issue?
type DeepExpand<T> = T extends object ? T extends infer O ? { [K in keyof O]: DeepExpand<O[K]> } : never : T;
type ExpandPoint = DeepExpand<Point>;

// type ExpandPoint = {
//   [x: number]: number;
//   ...
// }

Here is another instance of (probably) the same error:
Playground link
A TS2556 (A spread argument must either have a tuple type or be passed to a rest parameter.) error is thrown whenever I try to spread the contents of a tuple into another function. Even though that tuple is inferred as the correct type.
I have tested this on all versions available in the playground.

It appears that the expansion of the type includes [x: number]: number. Maybe I should open this a separate issue?

Good observation. Once the index signature is removed, the tuple behaves as expected.
// https://stackoverflow.com/a/66252656
type RemoveIndex<T> = {
  [ K in keyof T as
    string extends K
    ? never
    : number extends K
    ? never
    : symbol extends K
    ? never
    : K
  ] : T[K];
};

// -snip-
type PartialBrand<T, U> = RemoveIndex<T> & Partial<Id<U>>; // Also known as Flavor.
//                        ^^^^^^^^^^^

Playground link
// -snip-
type Point = PartialBrand<RemoveIndex<[number, number]>, typeof pointId>;
//                        ^^^^^^^^^^^

Playground link


DOC: stats: Move biomedical examples to notebooks

Reference issue
N/A
What does this implement/fix?
Moves existing biomedical examples for scipy.stats functions into markdown-based notebooks (follow-up to #21004)
In addition to moving the examples, I've also fixed some typos, made reference styles consistent and reorganized some content. In cases where basic examples were removed to include the biomedical ones, I restored them so the docstrings would have at least one simple example. In at least one case (friedmanchisquare) I pulled in an example from the tests for the function - hope that is ok!
Additional information
The diff is large, but there is very little new content; some of it is meant to contextualize examples or to reword text so the examples flow better since they have moved. I have kept commits separate to make review easier. If we prefer breaking this down it won't be difficult.
cc @mdhaber and @tupui

I don't see if https://app.circleci.com/pipelines/github/scipy/scipy/28369/workflows/e203d29e-3db5-4892-bb0e-a1ed8a635810/jobs/95675?invite=true#step-105-7900_80 is a real failure?

After this, could you add a page for https://nbviewer.org/github/mdhaber/scipy-cookbook/blob/83f75bc18f62b420e482ba8230d12f0269b656ba/ipython/stats/pearsonr.ipynb ? I wrote that a while ago. Would you mind making a (informal, real-time) screen recording video of how you convert that so I can do it in the future? Or doing it live on a call would be fine, too.

Thanks @mdhaber - I fixed most of the smaller comments and will address the others tomorrow. I'd be happy to document the process with a short video.

It would also be terrific if the appearance in "See Also" could indicate that they are extended examples, like "Example: Chi-square test of independence of variables in a contingency table". Is it possible to do this without prepending "Example" to their actual title? Looks like these appear in every function's API See Also section, which is great.

I could not make this work; the only option I found is to add a note after the document name (see, for example, https://github.com/numpy/numpydoc/issues/170). I tried doing
See Also
--------

:ref:`My example <doc.md>`

and Sphinx throws an exception. I think you can only link to objects without an extra title.

Forgot to respond:

Did you revive most of the API examples from the commit before we added the extended examples? It looks like it; just thought I'd check whether there were any you had to write or got from somewhere else.

Yes - I took them from the original PRs.

Coming in late on this. It looks awesome 👏 Let me know if you want me to look at something specific.

Hi @melissawm is this ready for another look at the changes?

Yes @mdhaber - pending is the video and conversion of https://nbviewer.org/github/mdhaber/scipy-cookbook/blob/83f75bc18f62b420e482ba8230d12f0269b656ba/ipython/stats/pearsonr.ipynb which I plan on doing today.

BTW, this

looks like a fine solution to https://github.com/scipy/scipy/pull/21042#issuecomment-2195874656.

It looks like everyting in https://github.com/scipy/scipy/pull/21042#pullrequestreview-2146105328 was addressed, so let's get this in. Thanks @melissawm!

Thank you!

@melissawm Were you able to make that video? Thanks!

oops! It was on my todo list and I never finished it. Will work on it this week

Thanks. If you want to use the tutorial in gh-21462 as an example, that would be awesome : ) Before too much editing is done, can I see a draft? One important thing besides converting from ipynb to markdown is working with it afterward - how can we open/edit it as a notebook and work on it with the development version of SciPy?

Here you go @mdhaber - the video will show you how to convert a doc from ipynb to executable md (myst) and open it afterwards: https://www.youtube.com/watch?v=TbJ0Nq6Tpns
I did notice that the jupyter lab session does not seem to recognize the dev version of SciPy, so instead of just jupyter lab we might need some PYTHONPATH setting before opening jupyterlab.


MongoDB

Hello and thank you for great package. Would it be possible to add MongoDB as an option to that package?
Thank you

Hi @xnekv03, thanks. Great suggestion! Personally, I have to admit I never used MongoDB. But I think a dedicated container could be easily added.
I'll try as soon as possible.
Any request about a particular configuration for Laravel?

The trick is to install all the php extensions and enable them properly - quite a struggle for me personally.
I can test it for you if you want that it works.
Thanks

Hi @xnekv03, sorry for the delay.
Just released version 1.8.0.
Please note I didn't and I don't have a MongoDB background at all, so I could have missed something basic 😅 I didn't try to connect from Laravel to MongoDB; just checked the connection to the service.
In case you're upgrading an existing project, take a look at .env.example to add the new MONGODB_* variables to your .env file, then rebuild containers.
Please let me know if you encounter any issues or you have any suggestions! Thank you

Hello,
thanks for the change but unfortunately I was unable to connect to Mongo with Laravel.
I forked your repository and modified
added some mongo specific environment variables

https://github.com/xnekv03/laradhoc/blob/master/src/.env

added mogo connection config

https://github.com/xnekv03/laradhoc/blob/master/src/config/database.php

Unfortunately there is still one docker problem that mongo drivers are missing.
Steps to reproduce.

git clone git@github.com:xnekv03/laradhoc.git
spin up docker containers
run php artisan migrate:fresh
you will get an error Unsupported driver [mongodb].

Thank you in advance


Nokogiri error

Hello bro while deploying my fork of your Luna telegram bot repo there was an error of nokogiri version and libxslt and libxml please tell me how to fix it i have tried on heroheroku ,clever cloud and render all showed same error

nokogiri?

nokogiri?
Yes bro see the screenshots 😊

wtf y u closed the issue without solving
On Wed, Mar 15, 2023, 1:01 AM Akshay Rajput @.***>
wrote:

nokogiri?
—
Reply to this email directly, view it on GitHub
https://github.com/TheHamkerCat/LunaChatBot/issues/22#issuecomment-1468706122,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVK75VBNATC64R4BM73AUQ3W4DBPRANCNFSM6AAAAAAV2OYKJQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


[Analyzers][CPP] Remove the rules that are marked as info

[Analyzers][CPP] Remove the rules that are marked as info from the ruleset
Make the build logs cleaner and the warning reports useful

PR Checklist

[ ] Closes: #xxx
[x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed
CI

NOOB question: are (these) rules not supposed prevent problems? I mean, is it okay to hide (and likely forget) them?

Yes they are, and we are going to turn then back on.
For now, they are generating 27k warnings, and that makes looking for warnings more difficult.
So they are hidden now and will be marked as error when the issues in the code are solved.


Skip partial duplicates when applying multi-edit fixes

Summary
Right now, if we have two fixes that have an overlapping edit, but not an identical set of edits, they'll conflict, causing us to do another linter traversal. Here, I've enabled the fixer to support partially overlapping edits, which (as an example) let's us greatly reduce the number of iterations required in the test suite.
The most common case here is that in which a bunch of edits need to import some symbol, and then use that symbol, but in different ways. In that case, all edits will have a common fix (to import the symbol), but deviate in some way. With this change, we can do all of those edits in one pass.
Closes #5800.

This is a bit better could likely be better still.

Okay, the latest version stores sorted edits rather than sorting on the fly. I think this is a lot more efficient as we sort once (and iterate through the edits exactly once) and no longer need to do any clones anywhere. min_start also becomes O(1).


Statically forbid usage of revert in predicates

Using reverts in predicates produces a panic as they are illegal. Using them in that context should produce an error at compile time.

I'd like to take this on, seems like a good issue to start with.
If I understand correctly, the revert (RVRT code) should not be allowed on predicates, currently it's not specified anywhere but we need to do that.


fix: Mixed Content problem with updating minifiedAjax method and get current url based on http or https scheme

Change url()->full() method to url()->current() to solve Mixed Content when using forceScheme('https') function in Laravel

This PR will revert https://github.com/yajra/laravel-datatables-html/pull/122. Need to confirm with other users before merging. There was also a comment to revert it https://github.com/yajra/laravel-datatables/issues/2322 and just noticed it today.
Will keep this open for a week incase anyone wants to add their review. Thanks!

Apologies for the late review, released in v10.8.0 🚀 Thanks!

Our applications are brooked after this update


POL-649 Remove disabled triggers from LightweightEngineImpl

@josejulio This should properly disable triggers in LightweightEngineImpl. Thanks for asking in #370 and making me realize something was missing!


Support for High Sierra and Mojave

Hi, I would like to add support for this project to the relevant OS versions.
Perhaps do you know how can I detect the location of the syscall table on those versions while connecting from remote kdp.
thanks
Irad

Hi Irad,
For macOS High Sierra, it could be done by referring to these commits. I will investigate macOS Mojave after its official stable release.
There couple of techniques to discover sysent table. Every syscall is executed via INT80, and the interrupt descriptor table (IDT) address is exposed to userspace from kernel space through assembly instruction SIDT (store interrupt descriptor table register). From IDT address, one can calculate the location of INT80 by adding the offset distance since we know the size of IDT descriptor structure, which sized 16 bytes. Thereafter, by dynamically searching backward for the MachO magic value header 0xfeedfacf 64-bit kernel or 0xfeedface 32-bit kernel, we can obtain the base address of the kernel. The systent table is located in DATA segment (til Mac OSX El Capitan) or CONST segment (macOS), hence parsing the LOAD commands from known base kernel header we can find out the segment location. Other techniques are information extraction from userspace /dev/kmem, or using the MSR register number which contains the syscall entrypoint.
Pham.

Hi Pham and thanks for the reply,
regarding High Sierra, I've tried to use 'sidt' opcode to locate IDT, but it looks like Apple block it from 10.13.2 and it seems like the sidt now points to corrupted table structure
I also found another reference for this behavior in the following https://reverse.put.as/2018/01/07/measuring-osx-meltdown-patches-performance/
perhaps did you have a chance to check this method on 10.13.2 or above ?
My intention is hooking some syscalls using kernel module by simply change the appropriate address of the desired syscall entry in table and replace it with address of my own implementation.
So if i'm not limited to 'sidt' because all kernel VM is accessible to me. Do you think that if i take arbitrary function address (i.e. proc_name) and use the same backwards search to reach the syscall table ?
thanks,


about monotonic_align?

i have a issue when i install the list of requirements.txt.... could y tell me how to deal with?

Please refer to this issue: https://github.com/RVC-Project/Retrieval-based-Voice-Conversion-WebUI/issues/1103
How are you running this? Which python version are you using?

Please refer to this issue: RVC-Project/Retrieval-based-Voice-Conversion-WebUI#1103
How are you running this? Which python version are you using?

thanks,i got it: to install vc++


small question about the paper

hi
I have a little question about the picture of your paper: The exact configuration of Feature Extractor.
Can you tell me what the meaning of 2C|64  3C|512  etc. Thank you very much!!

2C|64 means that there are two convolutional layers with channel output dim of 64 and likewise for 3C|512.


No debug call-back reported in a vkCmdUpdateBuffer()->dispatch/draw call scenario

Consider a command buffer A which does the following:

One or more vkCmdUpdateBuffer() calls which fill non-overlapping regions of buffer X with data.
A dispatch or a draw call which follows, and which consumes the data delivered by the previous operation.

There should be a buffer / global barrier between steps 1 and 2. Lack of one goes unnoticed by the core validation layer.

This is a dupe of #892


Behavior of != operator is confusing when rhs is a list

Compare:
for np in jnp, onp:
  print(np)
  print(np.array([1,2]) != [1,2])
  print(np.array([1,2]) != [3,2])
  print(np.array([1,2]) != np.array([1,2]))
  print(np.array([1,2]) != np.array([3,2]))

Ouptut:
<module 'jax.numpy' from '/usr/local/lib/python3.6/dist-packages/jax/numpy/__init__.py'>
True
True
[False False]
[ True False]
<module 'numpy' from '/usr/local/lib/python3.6/dist-packages/numpy/__init__.py'>
[False False]
[ True False]
[False False]
[ True False]

The strange dynamically-shaped result results in some strange downstream exceptions when dropping in jax.numpy in place of numpy, such as:
print(any(onp.array([1,2]) != [1,2]))
print(any(jnp.array([1,2]) != [1,2]))

Output:
False
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-18-e89704e72507> in <module>()
      1 print(any(onp.array([1,2]) != [1,2]))
----> 2 print(any(jnp.array([1,2]) != [1,2]))

TypeError: 'bool' object is not iterable

(Of course the real use-case is some_fn_returns_array(x) != some_fn_returns_list(y))

I think this is an artifact of jax.numpy not promoting lists to arrays automatically like numpy does. We're okay with that behavior in general, but perhaps the comparison functions like equal, not_equal, less, etc. could promote here.

The other alternative would be to at least raise rather than quietly returning False.


How to select suitable capture_rate

Hi,
I'm confused on how to set capture_rate if my data was produced on non-10x Genomics platform?
How should capture rate be set suitably?
Thanks:)

In fact, my data is from MARS-seq, capturing lower molecules than 10X genomics based on some comparison paper like one from Molecule Cell.
I guess 0.0 may be the considerable parameter.

I think the Poisson limiting case (0.0) is perfectly fine to try. From that paper, it seems like it's actually not that much different from Drop-seq, so some number slightly higher (especially if you sequenced to saturation) is fine too.


teamv2

Hey,
I'm in a quite urgent need of the teamv2 API. I basically just need the List/GetAll call. Is it planned to add this soon? If not I will fallback to an HTTP call.
Thanks

Any news on the TeamV2 API ?
I update the Terraform Opsgenie provider to use the API v2.
It works fine for User (CRUD). But i've got an error when i try to create the team :
...

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

opsgenie_user.first: Creating...
  full_name: "" => "Cookie Monster"
  locale:    "" => "fr_FR"
  role:      "" => "User"
  timezone:  "" => "Europe/Paris"
  username:  "" =><EMAIL_ADDRESS>opsgenie_user.first: Creation complete after 2s (ID: c9e8365c-8887-47b7-873e-6f68fdaa7406)
opsgenie_team.test: Creating...
  description:       "" => "This team deals with all the things"
  member.#:          "0" => "1"
  member.0.role:     "" => "admin"
  member.0.username: "" =><EMAIL_ADDRESS>  name:              "" => "example"

Error: Error applying plan:

1 error(s) occurred:

* opsgenie_team.test: 1 error(s) occurred:

* opsgenie_team.test: Client error occurred; Response Code: 400, Response Body: No handler found for url /v1/json/team

We released a new GO SDK. https://github.com/opsgenie/opsgenie-go-sdk-v2


Not rendering.

It simply doesn't work. I'm using react native 55.4. PhotoUpload does not render whatsoever, throws no errors, nothing.  Image renders fine by itself, disappears if I wrap it in PhotoUpload

I am just trying this library for the first time, and I was experiencing the same issue. What fixed it for me was changing my image styles from width: 100% to a non-percentage value. So it seems that maybe it doesnt play well with percentages. Hope this helps you!

That was exactly my problem, thank you! That's what I get for not testing the example first.


close the file after use

Hi Peeps,
I found an opportunity for improvement this code. The test_decode function opens two files, but it never closes those files. In this case, we have 2 types of weaknesses: CWE 399 (Resource Management Errors) and CWE 772 (Missing Release of Resource after Effective Lifetime).
According to CWE 772: "When a resource is not released after use, it can allow attackers to cause a denial of service by causing the allocation of resources without triggering their release. Frequently-affected resources include memory, CPU, disk space, power or battery, etc."
Thus, I suggest following the pattern of the test_encode function and closing both files after use.
CWE 339: https://cwe.mitre.org/data/definitions/399.html
CWE 772: https://cwe.mitre.org/data/definitions/772.html
Regards

[approve ci]

Previous discussion int:  https://github.com/klebertarcisio/trafficserver/pull/1

Generally you want to use a lambda function with PostScript like this:  https://github.com/apache/trafficserver/blob/21f6a702f6874a49efa15336a740d1859f20bb15/include/tscpp/util/PostScript.h#L32

[approve ci]

Generally you want to use a lambda function with PostScript like this:
https://github.com/apache/trafficserver/blob/21f6a702f6874a49efa15336a740d1859f20bb15/include/tscpp/util/PostScript.h#L32

what's the problem in calling fclose as in the function test_encode?
https://github.com/apache/trafficserver/blob/0457b2f319a7ed86302062850f54ff6938b6abe5/proxy/http3/test/test_QPACK.cc#L325
Regards

The title should be changed it no longer fixes the file leak problem.

I was suggesting that you do the fclose() calls in the lambda function passed to the PostScript constructor.

[approve ci]

When one of the PR checks fails, you can see why by clicking on "Details".

I was suggesting that you do the fclose() calls in the lambda function passed to the PostScript constructor.

It would look something like this?
#include "tscpp/util/PostScript.h"
ts::PostScript ps(= -> void { fclose(fd_in); });
ts::PostScript ps(= -> void { fclose(fd_out); });
https://github.com/apache/trafficserver/blob/90357576c4cbd8c172047955d385b7ba0cd62627/plugins/xdebug/xdebug.cc#L533
I did it by the example above. In this case, would it be guaranteed that the files would be closed before the end of the function? Very interesting. Would these lines be at line 348?

You forgot the brackets in the capture.  You can't repeat the same variable name.  In any case, I think you could do it with one PostScript instance,  if you init fd_out to -1, and check that it's nonnegative before closing.

You forgot the brackets in the capture. You can't repeat the same variable name. In any case, I think you could do it with one PostScript instance, if you init fd_out to -1, and check that it's nonnegative before closing.

ts::PostScript ps([=] ( ) -> void { fclose(fd_in); fclose(fd_out); });
Could you show the most elegant solution?

Perhaps at some point, I can't at the moment.

[approve ci clang-format]

@klebertarcisio There's trailing whitespace in your PR. You need to fix and amend your change for the clang-format test to pass.
proxy/http3/test/test_QPACK.cc:  fclose(fd_out);

@randall I fixed it. If ok, i will make git rebase -i to keep just one single commit.

[approve ci]


Output stackbrew library file in a canonical order

Current LTS & weekly
Previous LTS (descending order)
Previous weekly (descending order)

If the changes in docker-library/docs#183 are implemented, this will hopefully be the format and the Jenkins releases will start showing up in named groups. Until that happens, I believe that creating the library file in this order will at least put the current LTS and weekly releases at the top of the list, followed by previous LTS releases, and finally by previous weekly releases.

Thanks! :metal:


Update qspectre.md

Provide location for VS 2015 Update 3 patch that contains support for /Qspectre

@GreatKeeper : Thanks for your contribution! The author, @"corob-msft", has been notified to review your proposed change.

@corob-msft : Thanks for your contribution! The author, @"corob-msft", has been notified to review your proposed change.


Search by County

I would like to be able to search by one or more counties. This should be located in the spatial factors section and should be placed above the route and milepost search.

NULL
84120
AMALGA
BEAVER
BLUFFDALE
BOUNTIFUL
BOX ELDER
CACHE
CARBON
CLEARFIELD
COTTONWOOD HEIGHTS
DAGGETT
DAVIS
DRAPER
DUCHESNE
EMERY
EXIT #99
GARFIELD
GENOLA
GRAND
GRANTSVILLE
HOLLADAY
HURRICANE
IRON
JUAB
KANAB
KANE
KAYSVILLE
LAYTON
LAYTON UT
LEHI
MIDVALE
MILLARD
MORGAN
MURRAY
OF EXIT 9
OGDEN
OREM
OUTSIDE CITY LIMITS
PARK CITY
PERRY
PIUTE
RICH
RIVERTON
ROOSEVELT
SALT LAKE
SALT LAKE CITY
SAN JUAN
SANDY
SANPETE
SARATOGA SPRINGS
SEVIER
SOUTH JORDAN
SOUTH SALT LAKE
ST.  I should probably fix that in the etl script some how or should I let them deal with their data?

I think we need to do both. I will alert them to their data.
On Apr 30, 2015, at 5:34 PM, steveoh<EMAIL_ADDRESS>wrote:
NULL
84120
AMALGA
BEAVER
BLUFFDALE
BOUNTIFUL
BOX ELDER
CACHE
CARBON
CLEARFIELD
COTTONWOOD HEIGHTS
DAGGETT
DAVIS
DRAPER
DUCHESNE
EMERY
EXIT #99
GARFIELD
GENOLA
GRAND
GRANTSVILLE
HOLLADAY
HURRICANE
IRON
JUAB
KANAB
KANE
KAYSVILLE
LAYTON
LAYTON UT
LEHI
MIDVALE
MILLARD
MORGAN
MURRAY
OF EXIT 9
OGDEN
OREM
OUTSIDE CITY LIMITS
PARK CITY
PERRY
PIUTE
RICH
RIVERTON
ROOSEVELT
SALT LAKE
SALT LAKE CITY
SAN JUAN
SANDY
SANPETE
SARATOGA SPRINGS
SEVIER
SOUTH JORDAN
SOUTH SALT LAKE
ST.  I should probably fix that in the etl
script some how or should I let them deal with their data?
—
Reply to this email directly or view it on GitHub
https://github.com/agrc/Crash-web/issues/26#issuecomment-98000016.


Array error

What this error mean? Not sure what to make of it or how to fix it.

Not sure the cause of error. However, using numpy functions to allow it to get close to zero but never reach it avoided the problem.


cant install with php 7.0.8 in Ubuntu 16 platform

I cant install mongodb driver for php 7.0.8 in Unbuntu 16 with pecl install mongodb it return me pecl command not found

This is not a library problem.
Try installing pecl:
sudo apt-get install php-pear php-dev

Duplicate of https://github.com/mongodb/mongo-php-driver/issues/482.
@DBARUNNER: Please do not create duplicate issues on the driver and library projects. Simply use the project that is most relevant to the issue.


Retrieving and invoking user-selectable menu items or shortcut keys in applications

After a user launches an app and while the focus is on the app's main window, the user can invoke Arvis and then Arvis can dynamically retrieve all available menu item names/descriptions (and perhaps also equivalent keyboard shortcuts) of the app.  For example, in Visual Studio Code, there is a "New File" menu item and its keyboard shortcut is -N.  Then the user can create a sequence of steps relatively easy inside Arvis by visually selecting a series of actions (including invoking a menu item like "New File" which may be displayed as [Visual Studio Code] -> New File (-N) inside Arvis.
For example, a sequence to comment out the current clipboard's content can be like invoking [Visual Studio Code] File -> New File (-N) followed by [Visual Studio Code] Edit -> Paste (-V) followed by [Visual Studio Code] Edit -> Toggle Block Comment (/) followed by [Visual Studio Code] Edit -> Copy (-C)
The above block commenting the clipboard's content can be achieved with scripting but not all users know how to write scripts.  Letting the user visually pick and choose available menu items inside an application and chain the steps and save them for later use will be quite powerful.
There is a macOS app called Paletro that somehow can obtain the menu item names and keyboard shortcuts of multiple applications and show the commands to the user in a command palette.

Could you tell me in detail what items you want to add to the menu?
Below list is just my guess.
Is this kind of what you meant? If not, I'd appreciate writing some items you want to add.

Show installed workflow preference
Show store preference
Install workflow, plugin

HI Gyubong.  This was just an idea as it might not be easy or even impossible to implement.  What I was thinking was to provide a way in Arvis for users to visually pick what menu items to run in a launched app because not all apps could be controlled on the command line and not all users know how to write scripts.  However, users would be able to achieve what they wanted by launching their installed apps and clicking menu bar items.  For example, most users would know that "File | New File" would create a new file in any app and "Edit | Paste" would paste the clipboard content to an app.
So my imaginative example of the idea would be:

User launched an app like Visual Studio Code (or any installed app like an image editing app).
Press Arvis shortcut key to launch Arvis
Arvis would read all menu items (with the names and shortcuts like "File -> New File" and "-N") from the launched app (which had the focus before switching to Arvis).  The menu items + shortcut keys from the app would be shown by Arvis to the user in a list or checkboxes, etc.
User would select a sequence of menu items by clicking list items or checkboxes created in step 3.  For example, "File menu | New File" then "Edit menu | Paste" then "Edit menu | Toggle Comment Block" then "Edit menu | Copy"
User could save the app name (Visual Studio Code) in step 1 and the chosen sequence of menu items in step 4.  She could name the sequence "Convert clipboard to comment block"

User could run the saved sequence in step 5 later to convert textual clipboard content to a comment block in Arvis.  I was not sure if it was possible to do the above in general for all apps that had menu items (with a new Arvis plugin or workflow).  Also, even if it was possible how Arvis could avoid causing screen flashes (to switch to another app in Arvis and to invoke a sequence of menu items by clicking the menu bar or by pressing some shortcut keys).  The whole idea was to provide a way for users to take advantage of apps they already had and functions that were already provided by an app instead of asking users to write a plugin or workflow for everything.  With Visual Studio Code, being able to use just its built-in functions through menu items or their shortcuts keys could do a lot to change text in the clipboard.  Another example would be using an image editing app's menu items to resize an image, rotate an image, enlarge an image, etc.
Thank you for reading the above.

Thanks Gyubong.  As I mentioned before there was an app for macOS called "Paletro" which could read menu items (and their textual descriptions) from different apps and then presented those items in a "Visual Studio Code" type of command palette when the user presses command-shift-P.  I have tried the app and it is able to retrieve menu items for many apps including those written in Swift and Electron.  So I think it is technically possible to retrieve the menu items of an app.  Can you download a trial version of the app at https://appmakes.io/paletro and test it out?

I tried paletro, this feature is quite impressive.
I'm not sure but, I think maybe there are some kind of APIs allowing accessing other App's menus in macOS with swift,
Which means this feature might be only feasible in macOS.
So I'm not planning to dedicate to implement this feature at this time.
But I'll leave the issue to reopen for the sake of future possibilities, and add Need help tag.

Fair enough since Arvis is cross-platform and not just for macOS.  By the way, the latest raycast app update will support (iOS like) shortcuts that are coming in the next macOS version.  Perhaps you can consider supporting them in future.
Thanks.


Filter form testing

Refactor and test Filterable List functionality.
Additions

Tests

Changes

filterable_context.py is now called filterable_list.py

Testing

tox

Review

@kave
@richaagarwal
@rosskarchner

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

can you update the changelog

everything works fine to me, just out of curiousity. Did we ever see form errors if we submitted something like this?

👍


Datasets

I am want to ask if you can provide more benchmarks used in the paper. Thanks.

@Angerla
Thank you for your interest in BinTuner.
We actually used the two most well-known benchmarks, SPEC 2006 & SPEC 2017 in our experiments, and unfortunately, neither of them is open source.


Client Api is not working for Framework 4.6.1

Hi @tiaroque , this is a known issue.
We will be working on a .NET core port, but still don't have an official release date.

Hi,
Is there any progress/eta on this?
I'm happy to help where I can as we're looking to use checkout for payments but are completely .net standard 2.0.
Also, it would be nice if more of the library was mockable and had interfaces.

Hi @SeanFarrow ,
We're currently looking into revamping the library but we don't have an ETA yet.
We'll keep you posted when we get updates.


Incorrect linking of GFS files for use in ungrib.exe

Describe the Problem
The GFS files are linked to GRIBFILE.AA* series in the incorrect order, i.e. not in sequential time increasing order. It does not cause anything to fail, but definitely not going to produce correct results. Guessing this is an issue in ungrib.py somewhere and how the files are sorted. The issue occurs when pulling data from NOMADS or S3 on both Cheyenne and AWS. It did not occur using local GFS test data.  Note below how GRIBFILE.AAA is linked to f009, but it should be the first in time, e.g. f000.
GRIBFILE.AAA -> /data/testrun/ungrib/gfs.t06z.pgrb2.0p25.f009
GRIBFILE.AAB -> /data/testrun/ungrib/gfs.t06z.pgrb2.0p25.f000
GRIBFILE.AAC -> /data/testrun/ungrib/gfs.t06z.pgrb2.0p25.f006
GRIBFILE.AAD -> /data/testrun/ungrib/gfs.t06z.pgrb2.0p25.f003
GRIBFILE.AAE -> /data/testrun/ungrib/gfs.t06z.pgrb2.0p25.f012
Expected Behavior
Expected to see:
GRIBFILE.AAA -> /data/testrun/ungrib/gfs.t06z.pgrb2.0p25.f000
GRIBFILE.AAB -> /data/testrun/ungrib/gfs.t06z.pgrb2.0p25.f003
GRIBFILE.AAC -> /data/testrun/ungrib/gfs.t06z.pgrb2.0p25.f006
GRIBFILE.AAD -> /data/testrun/ungrib/gfs.t06z.pgrb2.0p25.f009
GRIBFILE.AAE -> /data/testrun/ungrib/gfs.t06z.pgrb2.0p25.f012
Environment
Describe your runtime environment:

Machine: Cheyenne and AWS wrfcloud cluster
OS: Linux
n/a

To Reproduce
Describe the steps to reproduce the behavior:

Checkout develop branch and set up a test
Edit run.yml to set local_data to empty string, e.g.:
local_data: ''
Run the run.py
Check the output/ungrib and do an ls -l to the see the incorrect linking

Relevant Deadlines
Sep 30
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[x] Select scientist(s) or no scientist required

Labels

[x] Select component(s)
[x] Select priority

Projects and Milestone

[x] Select first Project for support of the current release
[ ] Select second Project for development toward the next official release
[x] Select Milestone as the next bugfix version

Bugfix Checklist

[x] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of main_<Version>.
Branch name: bugfix_<Issue Number>/main_<Version>_<Description>
[ ] Fix the bug and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into main_<Version>.
Pull request: bugfix <Issue Number> main_<Version> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Project for support of the current release
Select: Milestone as the next bugfix version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Complete the steps above to fix the bug on the develop branch.
Branch name:  bugfix_<Issue Number>/develop_<Description>
Pull request: bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Project for the next official release
Select: Milestone as the next official version
[ ] Close this issue.

I see the problem. The "glob" filelist for the remote data retrieval needs to be sorted alphabetically just like the local data, since glob.glob returns a list of files that is not guaranteed any particular sorting.
https://stackoverflow.com/questions/6773584/how-are-glob-globs-return-values-ordered
Line 51 in ungrib.py needs to be
            filelist = sorted(glob.glob(os.path.join(self.runinfo.ungribdir, 'gfs.*')))

The sorted function sorts the list alphabetically by default, which is the same behavior that the WPS link_grib.csh script shows.

@mkavulich - Thanks! I see it now. I can create a feature branch and test this tomorrow.


Suggestion: Incorporating IPython 5 Updates in the Notebooks - Readline and Multiline Paste

A couple of things I noticed while working through your book, and which you most likely are aware of, are

(GNU) Readline has been replaced by python_toolkit, and this in turn has made...
... pasting multiline code with other formatting now even simpler. The code example in the book works without a hitch without invoking the magic command:

In [1]: >>> def donothing(x):
   ...: ...     return x
   ...:
In [2]: donothing(5)
Out[2]: 5

I understand that it may be too late to incorporate these in the print book, but perhaps you could add a note about these changes in the notebooks, and, if possible, in the electronic versions, since newcomers to Python are likely to download the latest version (i.e. 5.x) of IPython and may be confused by the example.

Thanks! I've still not decided what I'll do about the inevitable change in packages with time. Similar things are happening in matplotlib & pandas as well.


windows_feature msi guard causes memory leak

On Windows 2008 R2, running the following powershell causes the TrustedInstaller service to jump from a 1.8Mb baseline to 85Mb used (and doesn't come back down).
Get-WmiObject -Query "SELECT * FROM Win32_OptionalFeature"

Each subsequent use of this command causes a 100 - 300Mb increase in TrustedInstaller's RAM usage
The following command also causes TrustedInstaller to jump to around 85Mb, but it immediately settles back down to a stable 8Mb
dism /online /get-features

These are the commands run by the guard of windows_feature as of https://github.com/chef-cookbooks/windows/pull/257.
While the new guards are faster, we have seen trustedInstaller services grow to over 1Gb of RAM usage, since the guards are executed every time chef runs.
We need some better way of determining the installation state of a feature.

The scheduled task resource uses schtask.exe under the hood.
Looks like this is the /DU flag
SCHTASKS /Create [/S system [/U <username> [/P [<password>]]]] [/RU <username> [/RP <password>]] /SC schedule [/MO <modifier>] [/D <day>] [/M <months>] [/I <idletime>] /TN <taskname> /TR <taskrun> [/ST <starttime>] [/RI <interval>] [ {/ET <endtime> | /DU <duration>} [/K] [/XML <xmlfile>] [/V1]] [/SD <startdate>] [/ED <enddate>] [/IT] [/Z] [/F]
https://github.com/chef-cookbooks/windows/blob/master/providers/task.rb#L41

I can confirm this as well. Only on Server 2008 R2. Windows Server 2012 does not seem to be effected. I run Chef-Client as a service (check in every 10 mins) and it was consistently eating all the RAM across several dozen servers until I disabled it.

I'd consider a PR that would solve this, but most solutions would require caching the state of installed features which could make resources attempt to converge when they should not.
You could also work around that by putting a guard in place that might check an ohai data (which would require a custom plugin) or shell out to query once in the run and check that in your guard.
While I acknowledge there is still a lot of 2008 R2 out there, it's two (and about to be three) major versions back and more current versions do not seem to have this issue.  This is really a bug in the Windows 2008 R2 os.

The latest release of this cookbook implemented an Ohai plugin for feature caching. This should work around the leak here by only actually obtaining the state on a change vs. on every call.


do not call  m_sessionsStore.wipeSubscriptions(clientID) twice

hi;@andsel,in the cleanSession method  of org.eclipse.moquette.spi.impl.ProtocolProcessor class,
we call the two sentences:

and the subscriptions.removeForClient(clientID) is
public void removeForClient(String clientID) {
subscriptions.removeClientSubscriptions(clientID);
//persist the update
m_sessionsStore.wipeSubscriptions(clientID);
}
so that means we call   m_sessionsStore.wipeSubscriptions(clientID) twice;

Duplicated of issue #69 as already fix, the line java m_sessionsStore.wipeSubscriptions(clientID);  ad line 298 is not more present in ProtocolProcessr


Support Binary/LargeBinary --> Utf8/LargeUtf8 in ilike and string functions

Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/7342
Closes https://github.com/apache/arrow-datafusion/issues/7345
Closes https://github.com/apache/arrow-datafusion/issues/7344
It also closes several draft / PRs:
Closes https://github.com/apache/arrow-datafusion/pull/7349
Closes https://github.com/apache/arrow-datafusion/pull/7350
Closes https://github.com/apache/arrow-datafusion/pull/7365
Rationale for this change
Some of the clickbench queries have this pattern
What changes are included in this PR?

Add a bunch of comments
Add automatic coercion rules from Binary and LargeBinary to the appropriate Utf8 (string) variants for LIKE and ILIKE
Add appropriate binary --> string logic in return type calculation for functions

Are these changes tested?
Yes, new tests
Are there any user-facing changes?
Yes now some queries will not error

@jonahgao  I wonder if you have some time to review this PR
cc @Weijun-H  and @JayjeetAtGithub  and @parkma99

@alamb LGTM 👍.
I also tested some other string functions on this branch, and they worked as expected.
Although some outputs may look strange, it’s just a display issue.
DataFusion CLI v32.0.0
❯ select lower(X'0000102023');
+-------------------------------+
| lower(Binary("0,0,16,32,35")) |
+-------------------------------+
|  #                            |
+-------------------------------+
1 row in set. Query took 0.004 seconds.

Thanks everyone for the reviews!

Thank you @viirya  -- I will fix the typos

Found a few typos.

PR to fix: https://github.com/apache/arrow-datafusion/pull/7873


TypeError WSGI response header value u'...' is not of type str

The fix for #913 introduced new type checks on headers which causes failure when existing code like this:
#!/usr/bin/env python
# coding=utf-8
import bottle
@bottle.route('/', method='GET')
def test():
    return bottle.static_file('test.txt', root='.', mimetype=u'text/plain', download='test.txt')
bottle.BaseRequest.MEMFILE_MAX = 5 * 1024 * 1024
bottle.debug(True)
bottle.run(host='<IP_ADDRESS>', port=8080, reloader=True, server='cherrypy')

is run with python 2.7
This used to work, now it shows this error in chromium:
"The requested resource returned more bytes than the declared Content-Length."

The actual trace as shown in the console where the script runs is:
Critical error while processing request: /
Error:
TypeError("WSGI response header value u'text/plain' is not of type str.",)
Traceback:
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/bottle.py", line 960, in wsgi
    start_response(response._status_line, response.headerlist)
  File "/usr/lib/python2.7/dist-packages/cherrypy/wsgiserver/wsgiserver2.py", line 2309, in start_response
    "WSGI response header value %r is not of type str." % v)
TypeError: WSGI response header value u'text/plain' is not of type str.

The workaround is to pass a string not a unicode string as mimetype:
    return bottle.static_file('test.txt', root='.', mimetype='text/plain', download='test.txt')

At a minimum, it would be preferable to see the "Critical error while processing request" error not the "The requested resource returned more bytes than the declared Content-Length." one which is misleading.
For maximum backward compatibility, and if that does not cause side-effects, it would be nice if unicode strings would be OK as they used to be.

The strange chrome error comes from cherrypy not updating the content-type header after replacing the response content. Perhaps we should report that to cherrypy as well.
I'll release a fix for the bottle-side of this bug soon.

I'm not sure this is really a cherrypy bug. It might be caused by the "last resort" error handling in bottle. On first glance I cannot find a bug. https://github.com/bottlepy/bottle/blob/release-0.12/bottle.py#L973 looks fine (no Content-Type header at all).

I guess to prove that we should reproduce it with a minimal test code as they did here: https://github.com/cherrypy/cherrypy/issues/1530 ?
BTW I just noticed that being on Debian stable my cherrypy is quite outdated (2.3.0 vs. 8.7.0 (!))...


[Crawler] Starts hadnling blockchain events after unlock rpc

Especially when restoring from a seed when we lost/deleted datadir, better sto starts observing after the UnlockRPC, that means we already recovered from explorer and created the markets.

This is pretty annoying indeed
DEBU[0047] Start observing new account: 0
DEBU[0047] Start observing new account: 0
DEBU[0047] Start observing new account: 0
DEBU[0047] Start observing new account: 0
DEBU[0047] Start observing new account: 5
DEBU[0047] Start observing new account: 5
DEBU[0047] Start observing new account: 5
DEBU[0047] Start observing new account: 5
DEBU[0047] Start observing new account: 5
DEBU[0047] ended syncing wallet
DEBU[0048] observe interval
WARN[0048] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0048] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0048] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0048] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0048] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0048] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0048] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0048] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0048] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
DEBU[0049] observe interval
WARN[0049] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0049] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0049] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0049] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0050] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0050] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0050] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0050] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0050] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
DEBU[0050] observe interval
WARN[0050] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0050] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0050] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0050] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0050] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0050] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0050] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0050] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0050] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
DEBU[0051] observe interval
WARN[0051] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0051] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0051] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0051] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0051] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0051] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0051] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0051] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0051] trying to check balance for fee account: wallet must be unlocked to perform this operation
DEBU[0052] observe interval
WARN[0052] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0052] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0052] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0052] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0052] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0052] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0052] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0052] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0052] trying to check balance for fee account: wallet must be unlocked to perform this operation
DEBU[0053] observe interval
WARN[0053] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0053] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0053] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0053] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0053] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0054] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0054] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
DEBU[0054] observe interval
WARN[0054] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0054] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0054] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0054] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0054] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0054] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0054] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0054] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0054] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0054] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0054] trying to check balance for fee account: wallet must be unlocked to perform this operation
DEBU[0055] observe interval
WARN[0055] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0055] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0055] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0055] trying to check balance for fee account: wallet must be unlocked to perform this operation
DEBU[0056] observe interval
WARN[0056] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0056] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0056] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0056] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0056] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0056] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0056] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0056] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0056] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0056] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0056] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0056] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0056] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0056] trying to check balance for fee account: wallet must be unlocked to perform this operation
DEBU[0057] observe interval
WARN[0057] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0057] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0057] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0057] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0057] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0057] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0057] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0057] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0057] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
DEBU[0058] observe interval
WARN[0058] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0058] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0058] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0058] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0058] trying to check balance for fee account: wallet must be unlocked to perform this operation
WARN[0058] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0058] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0058] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
WARN[0059] trying to check fundings for market account 5: wallet must be unlocked to perform this operation
DEBU[0059] observe interval


jQuery simpleweather.min.js, GET https://query.yahooapis.com/v1/public/yql returns 'e.query.results is null'

Was working fine just last night (January 18th, 2016). More than likely an issue with yahoo updating their weather API. Noticed there was a similar issue dated a few years ago here: Previous issue
Attached code snippit I was using, and had previously working.
weather.zip
Thanks.

Same problem here

I'm getting the same issue and it appears to also effect all the demos on simpleweather's own website

See #174 for some temporary fixes and other information.