Explicit URL Imports with relative path

Describe the bug
Hi there
Feature: Explicit URL Imports (https://vitejs.dev/guide/assets.html#explicit-url-imports)
When I use the absolute path, all is well and working

But I have a problem with relative path

Reproduction
easy to reproduce
Steps to reproduce
No response
System Info
System:
    OS: macOS 12.6
    CPU: (10) arm64 Apple M1 Pro
    Memory: 107.14 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.14.0 - /usr/local/bin/node
    npm: 9.3.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 111.0.5563.146
    Safari: 15.6.1

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I wasn't able to reproduce.
https://stackblitz.com/edit/vitejs-vite-pees8e?file=main.js&terminal=dev

@sapphi-red
Oh
When I reproduced I see: I'm not correctly understood why need to use "?url". Need something else
Reproduce: https://stackblitz.com/edit/vitejs-vite-3dlyns?file=main.js
One more workaround: https://stackblitz.com/edit/vitejs-vite-3dlyns?file=mainWorkaround1.js

OK. I got what you want to do.
You can use a plugin to externalize a module. In this case, a plugin like this would work.
const plugin = {
  name: 'external',
  resolveId(id) {
    if (id.startsWith('/api/')) {
      return { id, external: true };
    }
  },
},

https://stackblitz.com/edit/vitejs-vite-m3kame?file=main.js,server.js
Closing as this is a duplicate of #12711

Perfect! Thanks


Audioplayers fails on iOS after ~750 mp3s with AVPlayerItem.Status.failed

I'm using audioplayers in a production app. It works great but I just discovered a critical bug. After playing about 750 mp3 files, audioplayers keep throwing an error (AVPlayerItem.Status.failed) and no more sounds are played. This happens only on iOS and only on physical devices.
Full Description
This is a really strange bug (at least to me) and I'm not sure if I'm doing something wrong in my code but I do not think so. The code is working perfectly for Android and also perfectly for iOS for quite some time but after about 750 played mp3s, it crashes. It may of course be something else but I can reproduce this by playing any mp3 ~750 times in a loop. This is no matter if I create my own AudioPlayer or use AudioCache. It does not matter if the files are long (~10s or short ~1s). It doesn't matter if I'm in MEDIA_PLAYER mode or LOW_LATENCY mode. If I just loop the same sound for 2000 times it will crash after about 750 played mp3s.
I've tested with audioplayers 0.16.1 and 0.17.2, both have the same result.
Code to Reproduce
I've not been able to test this minimal reproducible example yet since I can only test it on a physical iOS device and I do not have an iOS device here right now. I will try it tomorrow and post the results. But this code should reproduce the bug. The minimal reproducible example would be to clone the example from this lib and change this code:
Text('Play Local Asset In Low Latency \'audio.mp3\':'),
_Btn(
  txt: 'Play',
  onPressed: () =>
	  audioCache.play('audio.mp3', mode: PlayerMode.LOW_LATENCY),
),

to
Text('Play Local Asset In Low Latency \'audio.mp3\':'),
_Btn(
  txt: 'Play',
  onPressed: () {
	  for (int i = 1; i < 2000; i++) {
		print('lapCount = $i');
		audioCache.play('audio.mp3', mode: PlayerMode.LOW_LATENCY);
		await Future.delayed(Duration(milliseconds: 50));
		//await Future.delayed(Duration(seconds: 3));
	  }
  }
),

Please note that the delay maybe isn't necessary, I'm not sure. I've used 50ms delay in our app. Use 3 seconds or so to prevent overlap of the sound but I do not think it matters for reproducing the bug.
Log Errors
No errors really, except that the AudioPlayer sends an error with message "AVPlayerItem.Status.failed" through the onPlayerError stream of the AudioPlayer.
Platforms
This seems to be a bug specific for iOS, maybe MacOS as well but I have not tested that OS. I've tested iOS 12.x and 14.x, both have the same error. I've tested on iPad mini 2nd gen, iPad 6th gen, iPad 8th gen - all have the same error.
I've used Flutter stable 1.22.5 for all

OS: iOS
OS version: iOS 12.x & 14.x
Device: only physical iOS devices, only tested on iPads, not iPhones but I guess the same problem is on iPhone
flutter version: 1.22.5 (stable channel)
audioplayers version: 0.16.1 & 0.17.2
release or not release: this is reproduced in development, also reproduced with --profile flag. Also, my end users are reporting this frequently from the release builds so I'm 99.99% sure that it also affects release builds.
does the error occur and does it have any peculiarities: only on iOS, not Android. It works perfectly for ~750 mp3s, then it crashes every time.

I have reproduced this with the example in this repo: https://github.com/mikeesouth/audioplayers/tree/issue-746
Note that it's a branch called issue-746 that is branched from 0.16.1. To reproduce the error, start the example and press any red play-button (there is one right at the start page). It will play a sound and overlap with the same sound again after 50ms so the sound output is quite annoying and "choppy", like a robot that has some kind of speech problem :)
The red play button will play a small mp3 file (test.mp3) 2000 times. On iOS simulators, Android emulators and Android physical devices  - this works just fine. On physical iOS devices, it stops playing sounds after about 700-750 times, that is after about 1 minute. When it stops playing sounds, the print output from the app is similar to this (note that lap 731 and 732 works just fine, 733 gets error AVPlayerItemStatus.failed and all the following calls get the same error):
flutter: lapCount = 731
flutter: Playing _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-731.mp3
flutter: Deleting _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-731.mp3
flutter: Fatal Error: Callback lookup failed!
flutter: lapCount = 732
flutter: Playing _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-732.mp3
flutter: Deleting _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-732.mp3
flutter: Fatal Error: Callback lookup failed!
flutter: lapCount = 733
flutter: Playing _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-733.mp3
flutter: onPlayerError: AVPlayerItemStatus.failed
flutter: await _file.exists() = true
flutter: lapCount = 734
flutter: Playing _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-734.mp3
flutter: onPlayerError: AVPlayerItemStatus.failed
flutter: await _file.exists() = true

Currently, on line 64/65 in one_time_audio_player.dart, I just have a delay of 50ms. By uncommenting line 65 (return _completer.future;) the sounds will play in sequence instead. The log output is a bit easier to follow but a full run (2000 sounds) takes about 10.5 minutes and on iOS the problem occurs after about 750 errors, about 4 minutes.
Do you have any idea what's going on here @luanpotter ? I'm happy to submit a PR but I'm not sure why this is happening or how I can try to fix it.

I have reproduced this with the example in this repo: https://github.com/mikeesouth/audioplayers/tree/issue-746
Note that it's a branch called issue-746 that is branched from 0.16.1. To reproduce the error, start the example and press any red play-button (there is one right at the start page). It will play a sound and overlap with the same sound again after 50ms so the sound output is quite annoying and "choppy", like a robot that has some kind of speech problem :)
The red play button will play a small mp3 file (test.mp3) 2000 times. On iOS simulators, Android emulators and Android physical devices  - this works just fine. On physical iOS devices, it stops playing sounds after about 700-750 times, that is after about 1 minute. When it stops playing sounds, the print output from the app is similar to this (note that lap 731 and 732 works just fine, 733 gets error AVPlayerItemStatus.failed and all the following calls get the same error):
flutter: lapCount = 731
flutter: Playing _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-731.mp3
flutter: Deleting _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-731.mp3
flutter: Fatal Error: Callback lookup failed!
flutter: lapCount = 732
flutter: Playing _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-732.mp3
flutter: Deleting _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-732.mp3
flutter: Fatal Error: Callback lookup failed!
flutter: lapCount = 733
flutter: Playing _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-733.mp3
flutter: onPlayerError: AVPlayerItemStatus.failed
flutter: await _file.exists() = true
flutter: lapCount = 734
flutter: Playing _file.path = /var/mobile/Containers/Data/Application/A40D1FFA-12CF-4AED-B181-0BC03A676AD6/Library/Caches/sound-734.mp3
flutter: onPlayerError: AVPlayerItemStatus.failed
flutter: await _file.exists() = true

Currently, on line 64/65 in one_time_audio_player.dart, I just have a delay of 50ms. By uncommenting line 65 (return _completer.future;) the sounds will play in sequence instead. The log output is a bit easier to follow but a full run (2000 sounds) takes about 10.5 minutes and on iOS the problem occurs after about 750 errors, about 4 minutes.
Do you have any idea what's going on here @luanpotter ? I'm happy to submit a PR but I'm not sure why this is happening or how I can try to fix it.

Pretty sure I'm experiencing the same memory leak as described here: https://github.com/luanpotter/audioplayers/issues/141
I actually solved this by creating my own pool of audio players before reading about the AudioPool and it seems to be working, still a bit buggy though so some kind of RELEASE logic is probably necessary on iOS.

Pretty sure I'm experiencing the same memory leak as described here: https://github.com/luanpotter/audioplayers/issues/141
I actually solved this by creating my own pool of audio players before reading about the AudioPool and it seems to be working, still a bit buggy though so some kind of RELEASE logic is probably necessary on iOS.

I'm experiencing a similar issue on Android.
After playing ~220 wav files, the audio can't be heared anymore even if I dispose and reinitialize the player.
When restarting the app, everything works fine.
Some output from my log:
I/MediaPlayer(22109): [HSM] stayAwake true uid: 10294, pid: 22109
I/MediaPlayer(22109): Pid:22109 MediaPlayer::start
E/MediaPlayer(22109): error (1, -19)
E/MediaPlayer(22109): Error (1,-19)
I/MediaPlayer(22109): [HSM] stayAwake false uid: 10294, pid: 22109
E/MediaPlayer(22109): pause called in state 0, mPlayer(0x7ccb239540)
E/MediaPlayer(22109): error (-38, 0)
E/MediaPlayer(22109): Attempt to perform seekTo in wrong state: mPlayer=0x7ccb239540, mCurrentState=0
E/MediaPlayer(22109): error (-38, 0)
I/MediaPlayer(22109): [HSM] stayAwake false uid: 10294, pid: 22109
E/MediaPlayer(22109): Error (-38,0)
I/MediaPlayer(22109): [HSM] stayAwake false uid: 10294, pid: 22109
E/MediaPlayer(22109): Error (-38,0)
I/MediaPlayer(22109): [HSM] stayAwake false uid: 10294, pid: 22109
I/MediaPlayer(22109): [HSM] stayAwake false uid: 10294, pid: 22109
I/MediaPlayer(22109): [HSM] stayAwake false uid: 10294, pid: 22109
I/MediaPlayer(22109): Pid:22109 MediaPlayer destructor

I tried both
voicePlayerCache ??= AudioCache();
and
voicePlayerCache ??= AudioCache(fixedPlayer: voicePlayer);

Any update on this issue? I'm getting the same error AVPlayerItem.Status.failed on iOS only after a few calls to audioPlayer.play when streaming audio.

I'm getting the same error AVPlayerItem.Status.failed.

As am I. Same error and similar circumstances. I have 36 Audioplayers. Error happens eventually and inconsistently. Same error code
VERBOSE-2:ui_dart_state.cc(198)] Unhandled Exception: AVPlayerItem.Status.failed
#0      MethodChannelAudioplayersPlatform._doHandlePlatformCall
package:audioplayers_platform_interface/method_channel_audioplayers_platform.dart:174
#1      MethodChannelAudioplayersPlatform.platformCallHandler
package:audioplayers_platform_interface/method_channel_audioplayers_platform.dart:147
#2      MethodChannel._handleAsMethodCall
package:flutter/…/services/platform_channel.dart:404
#3      MethodChannel.setMethodCallHandler.
package:flutter/…/services/platform_channel.dart:397
#4      _DefaultBinaryMessenger.setMessageHandler.
package:flutter/…/services/binding.dart:380
#5      _DefaultBinaryMessenger.setMessageHandler.
package:flutter/…/services/binding.dart:377
#6      _invoke2. (dart:ui/hooks.dart:190:15)
#7      _rootRun (dart:async/zone.dart:1426:13)
#8      _CustomZone.run (dart:async/zone.dart:1328:19)
#9      _CustomZone.runGuarded (dart:async/zone.dart:1236:7)
#10     _invoke2 (dart:ui/hooks.dart:189:10)
#11     _ChannelCallbackRecord.invoke (dart:ui/channel_buffers.dart:42:5)
#12     _Channel.push (dart:ui/channel_buffers.dart:132:31)
#13     ChannelBuffers.push (dart:ui/channel_buffers.dart:329:17)
#14     PlatformDispatcher._dispatchPlatformMessage (dart:ui/platform_dispatcher.dart:589:22)

Is this still a thing in audioplayers: ^1.1.0 ?

Is this still a thing in audioplayers: ^1.1.0 ? We are happy to review any merge requests

Yes, I'm still getting the error in audioplayers: ^1.1.1. Only iOS getting this error.

I created a long audio and seek, pause, resume.
At the same time, create short audio from time to time, play and release.
After a while, the long audio not working, with error flutter: Unexpected platform error: AVPlayerItem.Status.failed
Then I cached the short audio players, the error gone.


ESP32 BLE onDisconnect() gets called after some delay

I use a standard BLE client example. After a successful connection, a program example sends some data to a server. In case of disconnection of the server, the client detects that and calls onDisconnect()  only after some delay (about 6 sec). But the main loop continues to send data. And terminal just sends an error "lld_pdu_get_tx_flush_nb HCI packet count mismatch (10, 11)" and after the board can work again in the normal way.
But if the delay between data sending less than 200 milliseconds, the terminal just sends "onDisconnect" message, and the bord reboots or just stops working.
I equate understand, what happens, as I try to send data to Client that has already offline and some issue leads to that. But I don't understand why onDisconnect() method is called with that delay? I've tested this code on different ESP32 board with ArduinoIDE, but the result always the same.

Hi @JLightMedia I have similar Errors with my iPhone and ANCS Service, if I go out of range from the ESP I get a wierd behaviour of rebooting or Stuck of my program... I also use Arduino IDE. I think it is the same bug as you have.
I have no clue how to tackle this problem...
I also find this Post on ESP forum with similar problem:
https://esp32.com/viewtopic.php?t=7445
cheers

Hello guys, have some update about this? I have the same problem in Arduino IDE. When i get out of server alcance with client (ESP32) and return, i have this error. 16:47:58.823 -> lld_pdu_get_tx_flush_nb HCI packet count mismatch (0, 1)


Training time for dynamic k estimation vs fixed k

Hi, thanks for your great work on OTA. I have tried to incorporate OTA into my model and found a huge difference in training time for dynamic k estimation vs fixed k settings. I am using 4 Tesla P100 to train. It takes about 2.5 days for fixed k while it takes more than 6 days to train for dynamic k estimation. I am wondering what your training time is like on both settings. Do you face similar issues? Thanks a lot!

@QinghangHong1
Hi, thank you for your interest in our work. In our experiments, there is no difference between fixed k and dynamic k. I would suggest you try to use dynamic k only (without OT) to test the speed. If OT slows down the training speed, you can directly use dynamic k without OT, it still performs better than most existing label assigning strategies but with higher training efficiency.

Thanks a lot for your reply.  It was slow because I put topk operation on cpu instead of gpu.


Import sit-lie ban data into database

Data is located in backend/data/ROH.Chapter29.Article15A.

Reference Issue #3 for context of data.


wrapscroll ?

yazi --debug output
Gi=31,s=1,v=1,a=q,t=d,f=24;AAAA
Yazi
    Version: 0.4.1 (Homebrew 2024-12-10)
    Debug  : false
    Triple : aarch64-apple-darwin (macos-aarch64)
    Rustc  : 1.83.0 (90b35a62 2024-11-26)

Ya
    Version: 0.4.1 (Homebrew 2024-12-10)

Emulator
    Brand.from_env      : Some(Apple)
    Emulator.detect     : Emulator { kind: Left(Apple), light: false, cell_size: None }
    Emulator.detect_full: Ok(Emulator { kind: Right(Unknown { kgp: false, sixel: false }), light: false, cell_size: None })

Adapter
    Adapter.matches: Chafa

Desktop
    XDG_SESSION_TYPE           : None
    WAYLAND_DISPLAY            : None
    DISPLAY                    : None
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

NVIM
    NVIM          : false
    Neovim version: 0.10.2

Variables
    SHELL           : Some("/bin/zsh")
    EDITOR          : Some("nvim")
    VISUAL          : None
    YAZI_FILE_ONE   : None
    YAZI_CONFIG_HOME: None
    YAZI_ZOXIDE_OPTS: None
    FZF_DEFAULT_OPTS: None

Text Opener
    default     : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-create: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-rename: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : 0
    tmux version       : No such file or directory (os error 2)
    tmux build flags   : enable-sixel=Unknown
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file          : 5.41
    ueberzugpp    : No such file or directory (os error 2)
    ffmpeg/ffprobe: 7.1 / 7.1
    pdftoppm      : 24.12.0
    magick        : 7.1.1-41
    fzf           : 0.56.3
    fd/fdfind     : 10.2.0 / No such file or directory (os error 2)
    rg            : 14.1.1
    chafa         : No such file or directory (os error 2)
    zoxide        : 0.9.6
    7z/7zz        : No such file or directory (os error 2) / 24.09
    jq            : 1.7.1

Clipboard
    wl-copy/paste: No such file or directory (os error 2) / No such file or directory (os error 2)
    xclip        : No such file or directory (os error 2)
    xsel         : No such file or directory (os error 2)

Please describe the problem you're trying to solve
Is it possible to have wrapscroll functionality similar to wrapscroll in lf? (https://github.com/gokcehan/lf/blob/master/doc.md#wrapscroll-bool-default-false)
Basically is it possible to scroll back to the bottom when going up from the first file & going back to the top when going to the bottom from the last file?
Would you be willing to contribute this feature?

[ ] Yes, I'll give it a shot

Describe the solution you'd like
Functionality and/or config item to enable "wrapscroll" functionality, which means the ability to scroll back to the bottom when going up from the first file & going back to the top when going to the bottom from the last file.
Additional context
No response
Checklist

[X] I have searched the existing issues/discussions
[X] The latest nightly build doesn't already have this feature

Duplicate of https://github.com/sxyazi/yazi/issues/1121
Closing as already supported and duplicate


Added Zfinx and Zfh tests

Description

Zfh and Zfinx Test are added
Added half width and half word into the NAN function to accommodate Zfh, as the base for Zfh is F which is also falls under the value as word
Introduced two new flags (ZFINX and ZDINX) to aid the compilation of floating ops into integer regs

Related Issues
NA
Ratified/Unratified Extensions
[✓] Ratified
List Extensions

Zfinx
Zfh

Reference Model Used
[✓] SAIL
Mandatory Checklist:
Ran reports are placed here
https://gitlab.com/ptprasanna/actreports.git

As already discussed, this PR can be merged only after the corresponding PR for ISAC has been merged.

I would use these tests on CORE-V Wally when they are available.
PR72 for ISAC has been merged.
https://github.com/riscv-software-src/riscv-isac/pull/72
PR67 from CTG has been waiting for review since July 2.
https://github.com/riscv-software-src/riscv-ctg/pull/67

@neelgala , -Please have your review and let us know if more information would help.

I see there are no fma tests in this directory.  Is there a reason these are omitted?

Hi,
As per the Zfinx and Zfh specification, there is no fma tests available I
think
On Mon, Jan 15, 2024 at 11:01 PM David Harris @.***>
wrote:

I see there are no fma tests in this directory. Is there a reason these
are omitted?
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1892560832,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3G6FF7QWJ44KEAEENHUWZLYOVRXRAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGU3DAOBTGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Got it. Thanks!
On Mon, Jan 15, 2024 at 8:18 PM anuani21 @.***> wrote:

Hi,
As per the Zfinx and Zfh specification, there is no fma tests available I
think
On Mon, Jan 15, 2024 at 11:01 PM David Harris @.***>
wrote:

I see there are no fma tests in this directory. Is there a reason these
are omitted?
—
Reply to this email directly, view it on GitHub
<
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1892560832>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/A3G6FF7QWJ44KEAEENHUWZLYOVRXRAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGU3DAOBTGI>

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893046699,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4AA37ZAEBKH7BPOFP4F4LYOX5R3AVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DMNRZHE
.
You are receiving this because you commented.Message ID:
@.***>

On further review of the ratified Zfh spec, there are fmadd.h and related instructions.  See the bottom figure of Section 15.2.
https://wiki.riscv.org/display/HOME/Recently+Ratified+Extensions
https://drive.google.com/file/d/1z3tQQLm5ALsAD77PM0l0CHnapxWCeVzP/view

I'm not sure how to interpret that.
"The Zfinx extension adds all of the instructions that the F extension
adds, except for the transfer instructions FLW, FSW, FMV.W.X, FMV.X.W,
C.FLW[SP], and C.FSW[SP]."
So, there should be FMA tests.
On Mon, Jan 15, 2024 at 8:22 PM David Harris @.***>
wrote:

Got it. Thanks!
On Mon, Jan 15, 2024 at 8:18 PM anuani21 @.***> wrote:

Hi,
As per the Zfinx and Zfh specification, there is no fma tests available
I
think
On Mon, Jan 15, 2024 at 11:01 PM David Harris @.***>
wrote:

I see there are no fma tests in this directory. Is there a reason
these
are omitted?
—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1892560832>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/A3G6FF7QWJ44KEAEENHUWZLYOVRXRAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGU3DAOBTGI>

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893046699>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AR4AA37ZAEBKH7BPOFP4F4LYOX5R3AVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DMNRZHE>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893049151,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJXXCEAZ6Q62RFN4XULYOX6AZAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DSMJVGE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi,
I thought fma and fmadd instructions are different. Fmadd and fmsub
instructions are available in zfh and zfinx. I will upload the coverage
report for fmadd and fmsub instructions shortly.
On Wed, 24 Jan, 2024, 11:14 pm Allen Baum, @.***> wrote:

I'm not sure how to interpret that.
"The Zfinx extension adds all of the instructions that the F extension
adds, except for the transfer instructions FLW, FSW, FMV.W.X, FMV.X.W,
C.FLW[SP], and C.FSW[SP]."
So, there should be FMA tests.
On Mon, Jan 15, 2024 at 8:22 PM David Harris @.***>
wrote:

Got it. Thanks!
On Mon, Jan 15, 2024 at 8:18 PM anuani21 @.***> wrote:

Hi,
As per the Zfinx and Zfh specification, there is no fma tests
available
I
think
On Mon, Jan 15, 2024 at 11:01 PM David Harris @.***>
wrote:

I see there are no fma tests in this directory. Is there a reason
these
are omitted?
—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1892560832>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/A3G6FF7QWJ44KEAEENHUWZLYOVRXRAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGU3DAOBTGI>

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893046699>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AR4AA37ZAEBKH7BPOFP4F4LYOX5R3AVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DMNRZHE>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893049151>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AHPXVJXXCEAZ6Q62RFN4XULYOX6AZAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DSMJVGE>

.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1908627624,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3G6FFZOUYDQ4OCBPG2HT53YQFCAJAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGYZDONRSGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Remember that there are fnmadd and fnmsub as well in the FMA class of instructions.

On Jan 24, 2024, at 5:36 PM, anuani21 @.***> wrote:
Hi,
I thought fma and fmadd instructions are different. Fmadd and fmsub
instructions are available in zfh and zfinx. I will upload the coverage
report for fmadd and fmsub instructions shortly.
On Wed, 24 Jan, 2024, 11:14 pm Allen Baum, @.***> wrote:

I'm not sure how to interpret that.
"The Zfinx extension adds all of the instructions that the F extension
adds, except for the transfer instructions FLW, FSW, FMV.W.X, FMV.X.W,
C.FLW[SP], and C.FSW[SP]."
So, there should be FMA tests.
On Mon, Jan 15, 2024 at 8:22 PM David Harris @.***>
wrote:

Got it. Thanks!
On Mon, Jan 15, 2024 at 8:18 PM anuani21 @.***> wrote:

Hi,
As per the Zfinx and Zfh specification, there is no fma tests
available
I
think
On Mon, Jan 15, 2024 at 11:01 PM David Harris @.***>
wrote:

I see there are no fma tests in this directory. Is there a reason
these
are omitted?
—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1892560832>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/A3G6FF7QWJ44KEAEENHUWZLYOVRXRAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGU3DAOBTGI>

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893046699>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AR4AA37ZAEBKH7BPOFP4F4LYOX5R3AVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DMNRZHE>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893049151>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AHPXVJXXCEAZ6Q62RFN4XULYOX6AZAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DSMJVGE>

.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1908627624,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3G6FFZOUYDQ4OCBPG2HT53YQFCAJAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGYZDONRSGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1909201935, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR4AA32MAHIUM2H2L7SQWXTYQGZJPAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGIYDCOJTGU.
You are receiving this because you commented.

Ya sure I will upload fmadd,fmsub,fnmadd and fnmsub instructions.
On Thu, Jan 25, 2024 at 10:34 AM David Harris @.***>
wrote:

Remember that there are fnmadd and fnmsub as well in the FMA class of
instructions.

On Jan 24, 2024, at 5:36 PM, anuani21 @.***> wrote:
Hi,
I thought fma and fmadd instructions are different. Fmadd and fmsub
instructions are available in zfh and zfinx. I will upload the coverage
report for fmadd and fmsub instructions shortly.
On Wed, 24 Jan, 2024, 11:14 pm Allen Baum, @.***> wrote:

I'm not sure how to interpret that.
"The Zfinx extension adds all of the instructions that the F extension
adds, except for the transfer instructions FLW, FSW, FMV.W.X, FMV.X.W,
C.FLW[SP], and C.FSW[SP]."
So, there should be FMA tests.
On Mon, Jan 15, 2024 at 8:22 PM David Harris @.***>
wrote:

Got it. Thanks!
On Mon, Jan 15, 2024 at 8:18 PM anuani21 @.***> wrote:

Hi,
As per the Zfinx and Zfh specification, there is no fma tests
available
I
think
On Mon, Jan 15, 2024 at 11:01 PM David Harris @.***>
wrote:

I see there are no fma tests in this directory. Is there a
reason
these
are omitted?
—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1892560832>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/A3G6FF7QWJ44KEAEENHUWZLYOVRXRAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGU3DAOBTGI>

.
You are receiving this because you authored the thread.Message
ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893046699>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AR4AA37ZAEBKH7BPOFP4F4LYOX5R3AVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DMNRZHE>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893049151>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AHPXVJXXCEAZ6Q62RFN4XULYOX6AZAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DSMJVGE>

.
You are receiving this because you are subscribed to this
thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1908627624>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/A3G6FFZOUYDQ4OCBPG2HT53YQFCAJAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGYZDONRSGQ>

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub <
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1909201935>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AR4AA32MAHIUM2H2L7SQWXTYQGZJPAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGIYDCOJTGU>.

You are receiving this because you commented.

—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1909361508,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3G6FF5NFY2OK4I5HT2RS7DYQHRXPAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGM3DCNJQHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Ah, I thought you were using fma as the generic for fm[n][add/sub]
On Wed, Jan 24, 2024 at 9:12 PM anuani21 @.***> wrote:

Ya sure I will upload fmadd,fmsub,fnmadd and fnmsub instructions.
On Thu, Jan 25, 2024 at 10:34 AM David Harris @.***>
wrote:

Remember that there are fnmadd and fnmsub as well in the FMA class of
instructions.

On Jan 24, 2024, at 5:36 PM, anuani21 @.***> wrote:
Hi,
I thought fma and fmadd instructions are different. Fmadd and fmsub
instructions are available in zfh and zfinx. I will upload the
coverage
report for fmadd and fmsub instructions shortly.
On Wed, 24 Jan, 2024, 11:14 pm Allen Baum, @.***> wrote:

I'm not sure how to interpret that.
"The Zfinx extension adds all of the instructions that the F
extension
adds, except for the transfer instructions FLW, FSW, FMV.W.X,
FMV.X.W,
C.FLW[SP], and C.FSW[SP]."
So, there should be FMA tests.
On Mon, Jan 15, 2024 at 8:22 PM David Harris @.***>
wrote:

Got it. Thanks!
On Mon, Jan 15, 2024 at 8:18 PM anuani21 @.***> wrote:

Hi,
As per the Zfinx and Zfh specification, there is no fma tests
available
I
think
On Mon, Jan 15, 2024 at 11:01 PM David Harris @.***>
wrote:

I see there are no fma tests in this directory. Is there a
reason
these
are omitted?
—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1892560832>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/A3G6FF7QWJ44KEAEENHUWZLYOVRXRAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGU3DAOBTGI>

.
You are receiving this because you authored the thread.Message
ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893046699>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AR4AA37ZAEBKH7BPOFP4F4LYOX5R3AVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DMNRZHE>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1893049151>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AHPXVJXXCEAZ6Q62RFN4XULYOX6AZAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA2DSMJVGE>

.
You are receiving this because you are subscribed to this
thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1908627624>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/A3G6FFZOUYDQ4OCBPG2HT53YQFCAJAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGYZDONRSGQ>

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub <

https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1909201935>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AR4AA32MAHIUM2H2L7SQWXTYQGZJPAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGIYDCOJTGU>.

You are receiving this because you commented.

—
Reply to this email directly, view it on GitHub
<
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1909361508>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/A3G6FF5NFY2OK4I5HT2RS7DYQHRXPAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGM3DCNJQHA>

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1909367761,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJQTYXASI2CFS7JCQDDYQHSTVAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGM3DONZWGE
.
You are receiving this because you commented.Message ID:
@.***>

CORE-V Wally will take advantage of the FMA tests as soon as you have them available.

I have updated FMA tests for Zfh and Zfinx extension.

I tried them out and they are working for me.  The f{madd/msub/nmadd/nmsub}_b15-01 tests are not in the PR.  These are the largest set of FMA tests.  Is there a reason they aren't applicable to Zfh?

I will check and let you know
On Wed, 7 Feb, 2024, 2:13 am David Harris, @.***> wrote:

I tried them out and they are working for me. The
f{madd/msub/nmadd/nmsub}_b15-01 tests are not in the PR. These are the
largest set of FMA tests. Is there a reason they aren't applicable to Zfh?
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1930719795,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3G6FF2UBZHAXKPUE5VIGYTYSKIXPAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZQG4YTSNZZGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

@davidharrishmc, Are you facing any issue while running Zfinx test?

I don't have hardware support for Zfinx, so I don't know if those tests have any issues.

No issues in the test, to check whether it is working fine.
On Wed, 7 Feb, 2024, 10:21 am David Harris, @.***>
wrote:

I don't have hardware support for Zfinx, so I don't know if those tests
have any issues.
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-1931278951,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3G6FF4ZL4OT5T2S22RRRHLYSMB67AVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZRGI3TQOJVGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

@davidharrishmc, I have updated  f{madd/msub/nmadd/nmsub}_b15-01 tests in the PR.

The fcvt.h.l tests should only depend on the F and Zfh extensions, as indicated in the test case.
RVTEST_CASE(0,"//check ISA:=regex(.*64.*I.*F.*Zfh.*);def TEST_CASE_1=True;",fcvt.h.l_b25)
inst_0:// rs1==x31, rd==f31,rs1_val == 0 and  fcsr == 0 and rm_val == 7
/* opcode: fcvt.h.l ; op1:x31; dest:f31; op1val:0x0; valaddr_reg:x3;
val_offset:0*8; rmval:dyn; correctval:??; testreg:x2;
fcsr_val: 0*/
TEST_FPIO_OP(fcvt.h.l, f31, x31, dyn, 0, 0, x3, 0*8, x4, x1, x2,ld)

However, the TEST_FPIO_OP macro generates a fsd, which requires the D extension.  Therefore, these tests do not run successfully on a RV64IFZfh machine.
0000000080000440 <inst_0>:
    80000440:	0001bf83          	ld	t6,0(gp)
    80000444:	00000113          	li	sp,0
    80000448:	00311073          	fscsr	sp
    8000044c:	d42fffd3          	fcvt.h.l	ft11,t6
    80000450:	00302273          	frcsr	tp
    80000454:	01f0b027          	fsd	ft11,0(ra)
    80000458:	0040b423          	sd	tp,8(ra)

It would be better to produce a fsw or fsh in this situation.

I see no further commits that would indicate that the problem David found (tests use D-ext ops on a configuration that only supports F-extension) have been fixed. Has that one been fixed?
As far as I can tell, that "fsd" corresponds to the first parameter of TEST_FPIO_OP ("inst" parameter )
but I can't find any instance of "fsd* used anywhere in the repo, so I don't have any idea where it is coming from.

Actually, that "fsd" op corresponds to something after the FPIO macro, but all the FP tests that use the FPIO macro consist of nothing but FPIO macros. the only ops that use FPIO are FCVT ops, and there are no uses of fsd in them, therefore it must be after the FPIO. But, all of those tests end with no further ops. Search for "fsd" shows only tests of fsd, and the don't use FPIO. So, I cannot figure out where that fsd is being generated.

@david and @allen ,I will check and get back to you. Sorry for the delay.
On Sun, 24 Mar, 2024, 3:40 am Allen Baum, @.***> wrote:

Actually, that "fsd" op corresponds to something after the FPIO macro, but
all the FP tests that use the FPIO macro consist of nothing but FPIO
macros. the only ops that use FPIO are FCVT ops, and there are no uses of
fsd in them, therefore it must be after the FPIO. But, all of those tests
end with no further ops. Search for "fsd" shows only tests of fsd, and the
don't use FPIO. So, I cannot figure out where that fsd is being generated.
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-2016615588,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3G6FFYWEVJWFTSEUNXSE7DYZX4UNAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGYYTKNJYHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@davidharrishmc  and @allenjbaum,
I have updated the test using fsw instead of fsd. I have attached the logs for your reference for fcvt.h.l instruction.
00000000800003ac <inst_0>:
800003ac:	0001bf83          	ld	t6,0(gp)
800003b0:	00000113          	li	sp,0
800003b4:	00311073          	fscsr	sp
800003b8:	d42fffd3          	fcvt.h.l	ft11,t6
800003bc:	00302273          	frcsr	tp
800003c0:	01f0a027          	fsw	ft11,0(ra)
800003c4:	0040b223          	sd	tp,4(ra)

Would you mind submitting a PR for the bugs you found?
On Mon, Mar 25, 2024 at 6:04 AM David Harris @.***>
wrote:

This fix to RVTEST_ISA looks good.
There is still an inconsistency between the check ISA lines in
fcvt.h.l_b25 and _b26. The instruction should depend on RV64, so I think
the _b25 line should add *RV64 to match _b26.
RVTEST_CASE(0,"//check ISA:=regex(.*I.*F.Zfh.);def
TEST_CASE_1=True;",fcvt.h.l_b25)
RVTEST_CASE(0,"//check ISA:=regex(.*RV64.*I.*F.Zfh.);def
TEST_CASE_1=True;",fcvt.h.l_b26)
The same applies to fcvt.h.lu_b25.
The check ISA is also wrong (usually has D, always missing RV64) on
fcvt.l.h*, fcvt.lu.h*
Nevertheless, the incorrect macros are not preventing me from building and
running the tests. The new tests pass on CORE-V Wally.
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-2017965892,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJUIRO7BKKAISLMCCZ3Y2AOHJAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXHE3DKOBZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Zfh isn’t in the repo yet, so I don’t know how to do a PR on a PR.  Could you either accept PR367 and I’ll do a PR with these fixes, or anuani could incorporate fixes into PR367?
David

On Mar 25, 2024, at 8:01 AM, Allen Baum @.***> wrote:
Would you mind submitting a PR for the bugs you found?
On Mon, Mar 25, 2024 at 6:04 AM David Harris @.***>
wrote:

This fix to RVTEST_ISA looks good.
There is still an inconsistency between the check ISA lines in
fcvt.h.l_b25 and _b26. The instruction should depend on RV64, so I think
the _b25 line should add *RV64 to match _b26.
RVTEST_CASE(0,"//check ISA:=regex(.*I.*F.Zfh.);def
TEST_CASE_1=True;",fcvt.h.l_b25)
RVTEST_CASE(0,"//check ISA:=regex(.*RV64.*I.*F.Zfh.);def
TEST_CASE_1=True;",fcvt.h.l_b26)
The same applies to fcvt.h.lu_b25.
The check ISA is also wrong (usually has D, always missing RV64) on
fcvt.l.h*, fcvt.lu.h*
Nevertheless, the incorrect macros are not preventing me from building and
running the tests. The new tests pass on CORE-V Wally.
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-2017965892,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJUIRO7BKKAISLMCCZ3Y2AOHJAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXHE3DKOBZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-2018207874, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR4AA34N4OT4TV6PVRBZ77TY2A325AVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGIYDOOBXGQ.
You are receiving this because you were mentioned.

Oh, and anuani21 - thanks for figuring out what the problem is.
Now we know we should carefully review this macros as well as the tests.
It is still a puzzle to me that this wasn't caught ages ago.

yes. I want some changes to the PR #367 first though, to back out changes
to the comments.
Those are unnecessary, and clutter up the diff - and will clutter the diff
up again if someone regenerates the tests, so it should ust be left
along (and, yes, I know I can filter out comments fro the diff...)
On Mon, Mar 25, 2024 at 8:06 AM David Harris @.***>
wrote:

Zfh isn’t in the repo yet, so I don’t know how to do a PR on a PR. Could
you either accept PR367 and I’ll do a PR with these fixes, or anuani could
incorporate fixes into PR367?
David

On Mar 25, 2024, at 8:01 AM, Allen Baum @.***> wrote:
Would you mind submitting a PR for the bugs you found?
On Mon, Mar 25, 2024 at 6:04 AM David Harris @.***>
wrote:

This fix to RVTEST_ISA looks good.
There is still an inconsistency between the check ISA lines in
fcvt.h.l_b25 and _b26. The instruction should depend on RV64, so I
think
the _b25 line should add *RV64 to match _b26.
RVTEST_CASE(0,"//check ISA:=regex(.*I.*F.Zfh.);def
TEST_CASE_1=True;",fcvt.h.l_b25)
RVTEST_CASE(0,"//check ISA:=regex(.*RV64.*I.*F.Zfh.);def
TEST_CASE_1=True;",fcvt.h.l_b26)
The same applies to fcvt.h.lu_b25.
The check ISA is also wrong (usually has D, always missing RV64) on
fcvt.l.h*, fcvt.lu.h*
Nevertheless, the incorrect macros are not preventing me from building
and
running the tests. The new tests pass on CORE-V Wally.
—
Reply to this email directly, view it on GitHub
<
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-2017965892>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AHPXVJUIRO7BKKAISLMCCZ3Y2AOHJAVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXHE3DKOBZGI>

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub <
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-2018207874>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AR4AA34N4OT4TV6PVRBZ77TY2A325AVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGIYDOOBXGQ>.

You are receiving this because you were mentioned.

—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/367#issuecomment-2018220095,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJRFC5UO6K5IBK4ZKP3Y2A4O7AVCNFSM6AAAAAAZ37DUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGIZDAMBZGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

sigh: as usual, we have a conflict with the changelog version. It needs to be updated.
Note that in future, all PRs should be filed against the dev branch, the dev branch should not be checking for changelog version numbers, and maintainers will be responsible for updating the union of changelogs for all the PRs included in that version of the dev branch

@allenjbaum, I have updated the changelog file. Please have your review and let us know if more information would help.
Hereafter, I will raise the PR with target branch as dev.

Just one question about this: Zfinx is currently only supported for rv64 machines, right?! 🤔
(there is a rv64i_m/Zfinx testcases folder but no rv32i_m/Zfinx testcases folder)


Fix extra # in link

@cijothomas : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


fzy: either allow -q to have no argument or accept any string as -q

I am trying to set up an alias like:
alias fzyfind=find . | fzy

but if I want to start with a query I have to specify the -qoption, and I cannot add it to the alias because then I cannot use the alias without specifying a start query.
Is the -q option necessary? Could not the argument that is not an option just always be the intital query?

I think it is best if an argument is required. It's weird that -q would "work" but have no meaning. However, -q can accept an empty string as an argument.
You should be able to achieve what you want using a shell function instead of an alias
fzyfind() {
  find . | fzy -q "$*"
}

This uses any arguments to fzyfind as input to -q. If none are provided it is equivalent to -q ""
fzyfind -> find . | fzy -q ""
fzyfind foo -> find . | fzy -q "foo"
fzyfind foo bar -> find . | fzy -q "foo bar"

John Hawthorn writes on juni 5, 2016 9:51:

I think it is best if an argument is required. It's weird that -q would "work" but have no meaning. However, -q can accept an empty string as an argument.

Right, that works of course :)


feat(button): add icon alone UIKit VitaminButton type, and refactor icon management

Changes description
I added the ability to define a 'icon Alone' version of VitaminButton.
I also reworked the way to specify which type of icon you want (for already existing trailing and leading icons)
And I took advantage of this PR to change icon size on large and medium button (see #74)
Context

This PR solves #52
It also solves #74

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[ ] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.
[ ] If it includes design changes, please ask for a review with a core team designer.

Does this introduce a breaking change?

No
I deprecated some methods, but they are still usable, the will just raise a warning.

Screenshots
iPhone

iPad

Other information
I am not sure it is Vitamin compliant, but I reworked the code to give the ability to have different icons for different states (that was allowed before by the previous code, but did not work well)

👍

Some problems have been detected on existing buttons, but since they are already released, I just opened a new issue #77 and merge this feature.


Overall services view in Octant

Is there a way in Octant to see the connection between various services? Right now I can see only individual services. Thanks.

Hi @texanraj , I was wondering if you could expand on this some.
Where are you expecting to see these connections? How are you making these connections, can you provide some examples of configurations you are trying to visualize?

Closing this out, but feel free to reopen with some more detail of what you're hoping to see.


[1281] Missing settings variable in audit env

Context
Missing settings variable in audit env. There are a few small changes due to the linter.

 Fix endpoint is down sentry error


Update about.html

I have been tasked by the FOSS4G SotM Oceania 2020 Conference committee to make necessary updates to the test website.

Tonnes of thanks Adam...much appreciated.
On Thu, 11 Jun 2020 at 09:47, Adam Steer<EMAIL_ADDRESS>wrote:

Merged #2 https://github.com/Spatialised/osgeo-oceania-template/pull/2
into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Spatialised/osgeo-oceania-template/pull/2#event-3431855578,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANMZ4TH6XW5J4JTRCE2GP3RWALQTANCNFSM4NZ65HAQ
.

--
Edwin Liava'a
ICT Generalist
Email<EMAIL_ADDRESS>Web: https://chespatial.pasifikaos.site
           武士道

"Always At Your Service"
DISCLAIMER:
This message and any attachment are intended solely for the addressee and
may contain confidential information. If you have received this message in
error, please send it back to me, and immediately delete it. Please do not
use copy or disclose the information contained in this message or any
attachment. Any views or opinions expressed by the author of this email do
not necessarily reflect the views of CheSpatial. This message has been
checked for viruses but the contents of an attachment may still contain
software viruses which could damage your computer system, you are advised
to perform your own checks.

no worries. Please head over to https://github.com/foss4g-oceania/foss4g-sotm-oceania-2020 to make further changes ;)

Tonnes of thanks :)
On Thu, 11 Jun 2020 at 10:54, Adam Steer<EMAIL_ADDRESS>wrote:

no worries. Please head over to
https://github.com/foss4g-oceania/foss4g-sotm-oceania-2020 to make
further changes ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Spatialised/osgeo-oceania-template/pull/2#issuecomment-642342048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANMZ4V5OI7O3WESPP6XU6DRWATNNANCNFSM4NZ65HAQ
.

--
Edwin Liava'a
ICT Generalist
Email<EMAIL_ADDRESS>Web: https://chespatial.pasifikaos.site
           武士道

"Always At Your Service"
DISCLAIMER:
This message and any attachment are intended solely for the addressee and
may contain confidential information. If you have received this message in
error, please send it back to me, and immediately delete it. Please do not
use copy or disclose the information contained in this message or any
attachment. Any views or opinions expressed by the author of this email do
not necessarily reflect the views of CheSpatial. This message has been
checked for viruses but the contents of an attachment may still contain
software viruses which could damage your computer system, you are advised
to perform your own checks.

Hi Adam,
Please give me push access to this repository so I can upload files.
cheers,
Edwin
On Thu, 11 Jun 2020 at 10:54, Adam Steer<EMAIL_ADDRESS>wrote:

no worries. Please head over to
https://github.com/foss4g-oceania/foss4g-sotm-oceania-2020 to make
further changes ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Spatialised/osgeo-oceania-template/pull/2#issuecomment-642342048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANMZ4V5OI7O3WESPP6XU6DRWATNNANCNFSM4NZ65HAQ
.

--
Edwin Liava'a
ICT Generalist
Email<EMAIL_ADDRESS>Web: https://chespatial.pasifikaos.site
           武士道

"Always At Your Service"
DISCLAIMER:
This message and any attachment are intended solely for the addressee and
may contain confidential information. If you have received this message in
error, please send it back to me, and immediately delete it. Please do not
use copy or disclose the information contained in this message or any
attachment. Any views or opinions expressed by the author of this email do
not necessarily reflect the views of CheSpatial. This message has been
checked for viruses but the contents of an attachment may still contain
software viruses which could damage your computer system, you are advised
to perform your own checks.


Fix target uri for webdav prefix for datatx

When a webdav prefix is used it appears in both host and name parameter of the target uri for data transfer. This PR fixes that.
The resulting target uri should be similar to:
http://...token...@reva.eu/prefix/?name=remote.php/webdav/home/...

Apart from @redblom's manual testing I also quickly tested it with the OCM test suite and didn't encounter any problems. 👍

Excellent, thanks @michielbdejong :+1:


Died kernel on compute

I downloaded a 5 GB csv file using ds.as_download(path_on_compute='your path on compute').
When I read this file using Pandas on my VM compute (STANDARD_D3-V2), the kernel dies but it works well on  (STANDARD_D4-V2).
Why D3_V2 does not work with 14 GB RAM?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd91721f-4a86-30cb-5e37-147c7319f0e6
Version Independent ID: 98499c4f-ad83-81a4-e5db-af6415f79a98
Content: Access data in datastores / blobs for training - Azure Machine Learning service
Content Source: articles/machine-learning/service/how-to-access-data.md
Service: machine-learning
Sub-service: core
GitHub Login: @mx-iao
Microsoft Alias: minxia

@thecpshah Thanks for the feedback. We are investigating the issue and will update you shortly.

@thecpshah Could you please share your 5 GB csv to check.

@vrishni Unfortunately I can't.

@thecpshah I could see the following differences between D3_v2 and D4_v2.

To verify the died kernel issue for D3_v2, please raise a support request from the Help + Support blade of Azure Portal to check.
If you do not have a support plan we can enable a one time support request if you can email us at azcommunity[at]microsoft[dot]com. Please provide us with your subscription id and URL of this thread in the email. I hope this helps!

@thecpshah We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


after logon to technet i get some error msg

Hello,
i try to logon my account (it's not be use the last year) to technet forums
https://social.technet.microsoft.com/forums/en-us/home
after i try to type my user & password i get some error msg: "The resource you are looking for has been removed, had its name changed, or is temporarily unavailable."
anyone can know how to fix it ?

@Computer24HR TechNet forums have closed at https://docs.microsoft.com/en-us/teamblog/msdn-technet-english-forums-closure


Es 487

Initial release. Forked from pradels/vagrant-libvirt v0.0.32. Most recent
change updates the functionality of random_hostname config param to be a fixed-
length hash with timestamp appended to adhere to the libvirt 64 max-char
hostname rule.

Sorry, inadvertent :P


inventree 0.16.4 - can see part, stock counts, but can't see parts or stock list

Deployment Method

[ ] Installer
[ ] Docker Development
[ ] Docker Production
[ ] Bare metal Development
[ ] Bare metal Production
[x] Digital Ocean image
[ ] Other (please provide a link Steps to Reproduce

Describe the problem*
I can see all my parts and stock in the admin view, but when I go to look at the stock screen or parts screen, I don't see any lists.  just counts of all the parts and stock in my database.  no errors, but can't understand how to make the lists show up
Steps to Reproduce
1.) click on "Parts" or "stock" in the nav bar
2.) see counts, and nothing else.  refer to screenshots

Relevant log output

Have you looked at https://docs.inventree.org/en/stable/faq/?h=feature+x#feature-x-does-not-work-after-update

@wolflu05 sure have!  I definitely tried that before raising this issue with no luck

Can you please also provide a screenshot from the network tab of the browser console. Try to find the red requests and click on it to see some details.
The loadApiPacks function error is related to it not being defined because that was introduced only recently. So it indicates that you don't have the latest sources on our system because something may be cached. Maybe it's not loading the new files because the first error, but not sure without more details.

@wolflu05 unfortunately, there aren't any red requests.  everything is coming back 200 successful on the network tab

Can you click on the en.helpers.js and search for loadApiIconPacks(https://github.com/inventree/InvenTree/blob/e0756a70069a72ba00cfe42444d936665c8b69f7/src/backend/InvenTree/templates/js/translated/helpers.js#L601-L621) this should definitely be in there. I really suspect a caching issue here. just to verify. what does curl https://your-domain.tld/static/i18n/en.helpers.js 2> /dev/null | grep loadApiIconPacks output? This should output something like this:
~ curl https://your-domain.tld/static/i18n/en.helpers.js 2> /dev/null | grep loadApiIconPacks
    loadApiIconPacks,
async function loadApiIconPacks() {

If not try to see what (now sshed into your server) the following outputs, it should be something like this (make sure you're in the right place where the static, media, ... folders are.
~ cat inventree-data/static/i18n/en.helpers.js |grep loadApiIconPacks
    loadApiIconPacks,
async function loadApiIconPacks() {

@wolflu05 is it possible my version of inventree is too out of date for the instructions you're telling me?  instead of inventree-data/static/i18n/en.helpers.js, I have data/static/i18n as the path instead.
when I run cat data/static/i18n/en.helpers.js | grep loadApiIconPacks, I don't get anything back.
The curl command doesn't output anything.
I'm on inventree version 0.16.4

Ah, right, sorry for the confusion have forgotten to remove the folder where I was testing with (docker deployment). But you already found the correct file.
We're getting there... Can you also find this file? src/backend/InvenTree/templates/js/translated/helpers.js does this contain the loadApiIconPacks function? (this should also be in 0.16.4). If yes you may need to run the invoke update command and try to load again (reset cache first in your browser). If its still not works, try the commands from above again and post the output.

@wolflu05 running invoke update again did the trick!  I'm back in business now.  Thanks so much for your help!  closing now as resolved

Nice that you got it working now. Sorry for the long debugging trail, I've should have suggested the invoke update before.


Solved multiple canvas issue

If el is already populate, it makes duplicate childs that can't fit in original geometry.
I added row 360 with this code to avoid the bug.
el.innerHTML = "";
Scenario for multiple canvas issue on Codepen
https://codepen.io/tonywhite1985/pen/bGgedMN?editors=1000
Try to comment this in JS tab on row 918
el.innerHTML = "";
and see glithes.

Open RESULT tab and start typing some text to encode
Detele all text
Try to type another text to encode
See qrcode (it shows badly when el.innerHTML = ""; is under comment)

I have improved the modularity of my scenario. Now, if you delete el.innerHTML = "", the glitch is immediately visible.

This would solve it for your use case without needing to changing the library.
Clear the element where the qr code is added before you call the method to add the qr code:
function createQRCode(textToEncode) {
document.getElementById("qrcode").innerHTML = '';
  qrcode = new QRCode(document.getElementById("qrcode"), {
    text: textToEncode,
    width: 300,
    height: 300,
    colorDark : "#000000",
    colorLight : "#ffffff",
    correctLevel : qrcodeQuality
  });
}

@markvantilburg it was my first step to solving the glitch. However the library adds a child without deleting or checking if another one already exists. I think it is useful to limit human errors by simplifying routine maintenance.


Add Description Parsing for Split Functionality

[x] I think my problem is NOT with youtube-dl
[x] I've verified and i assure that I'm running youtube-dl-gui 0.4
[x] I assure that i am using the latest version of youtube-dl
[x] Searched bugtracker
[x] I've read the FAQs file

What is the purpose of your issue?

[ ] Bug report
[x] Feature request (request for a new functionality)
[ ] Question
[ ] Other
[x] I've verified and i assure that my requested feature is NOT in the TODO list

I've developed a fairly accurate description parser in my own implementation of a GUI Youtube Downloader. This allowed for mixes and albums to be automatically be split/named into different files/folder structures, enhancing the power to acquire music quickly and formatted correctly. While I've discontinued work on my downloader, it is a functionality I'd love to see in this software as an optional setting. The particular description parser can be found here.

Can you provide a little more details and maybe an example on what exactly your code is doing?
As far as i understand your code (let's say i have an hour long video which is a music album):

Tries to find timestamps in the video's description
Creates an Album object based on this timestamps & titles
Then do you split the actual video in this timestamps in order to extract the songs?
...

@ajsnyde

Sorry for the slow reply. Yes, that is about right. There are also some subtle features such as adding the parsed metadata to mp3s, but that is about right.


Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page

Added new colors and brushes to the common styles.
Updated Button (partially) with new colors and to remove tilt effect.
Added test page with a large number of ControlStateViewers to see all updates in one place.

Are you able to share details about this token-experiment @teaP
I am assuming this is related to the concept of Design Tokens and possible integration with Figma?
@Felix-Dev when did the Control Corner Radius change to 4epx?  Also why was this change made?

@teaP I fear that this will cause design issues in many apps. Developers who put special effort into working around design issues caused by the last change to the CornerRadius are going to have to go through this again, here are just a couple of the issues caused with the last change, #2134 #2401. Both of those examples are things can be fixed by retemplating the control, however, I don't think it's a good idea to make changes to the corner radius again until the mentioned issues are fixed. Fixing those first will prevent extra work for developers and it will help apps move towards a more consistent design.

@teaP I fear that this will cause design issues in many apps. Developers who put special effort into working around design issues caused by the last change to the CornerRadius are going to have to go through this again, here are just a couple of the issues caused with the last change, #2134 #2401. Both of those examples are things can be fixed by retemplating the control, however, I don't think it's a good idea to make changes to the corner radius again until the mentioned issues are fixed. Fixing those first will prevent extra work for developers and it will help apps move towards a more consistent design.

If these changes are intended for WinUI 3.0 only - then I think the huge version change could enable making these kinds of changes.  I am not against them, based on what I see in the code - but I am curious why the changes are coming, and what the end goal is - so I can comment or provide feedback with some idea of the direction.

@mdtauk I am fine with a change to the radius, however a couple issues need to be solved, mainly making sure that it's applied consistently. The current iteration is not consistent, so as a temporary solution, many developers manually set the corner radius to solve these inconsistencies. Making another change to the radius is going to break all those manual changes unless the reason developers made the changes manually in the first place is solved.

@mdtauk I am fine with a change to the radius, however a couple issues need to be solved, mainly making sure that it's applied consistently. The current iteration is not consistent, so as a temporary solution, many developers manually set the corner radius to solve these inconsistencies. Making another change to the radius is going to break all those manual changes unless the reason developers made the changes manually in the first place is solved.

Looking at the new names for the Button brushes - I think that is exactly what is being planned for.
I see things like an elevation border which appears to be a linear gradient so the top of the control/element gets a highlight, adding some subtle depth.  And a new naming convention for Primary, Secondary, Tertiary, Disabled brushes used for the Rest, Hover, Pressed, Disabled visual states.
Design tokens may make it much easier to affect the look of a control from within something like Adobe XD or Figma - and it produce the code you then copy and paste into XAML.

/azp run

Are you able to share details about this token-experiment @teaP
I am assuming this is related to the concept of Design Tokens and possible integration with Figma?
@Felix-Dev when did the Control Corner Radius change to 4epx? Also why was this change made?

@mdtauk ,
Great question! Yes, it is related to Design Token we have announced in our past talks. While we cannot share a detail of where we are or what exactly is happening, you can think of this as you are being included in our progress.
Yes, we are changing the Control Corner Radius to 4epx.

@mdtauk ,
Great question! Yes, it is related to Design Token we have announced in our past talks. While we cannot share a detail of where we are or what exactly is happening, you can think of this as you are being included in our progress.
Yes, we are changing the Control Corner Radius to 4epx.

Very interesting.  Do you have some idea when the community will hear about the future plans?
Also to what extent these changes may fundamentally change how Xaml works, and what changes developers may need to make in their apps?

@mdtauk ,
Great question! Yes, it is related to Design Token we have announced in our past talks. While we cannot share a detail of where we are or what exactly is happening, you can think of this as you are being included in our progress.
Yes, we are changing the Control Corner Radius to 4epx.

Very interesting. Do you have some idea when the community will hear about the future plans?
Also to what extent these changes may fundamentally change how Xaml works, and what changes developers may need to make in their apps?

@mdtauk , I am not at the position to comment when we can or plan to share, but I'm sure this community will be the first to find out. :)
The idea of design token is it should be transparent to the developers as long as they are using controls "as is". As is any changes we make, retemplating or customization make it more work for developers but it is not unique to token.

The problem is the corner rendering in XAML is already very bad compared to other platforms. Increasing to 4epx will make it even worse by default.

The problem is the corner rendering in XAML is already very bad compared to other platforms. Increasing to 4epx will make it even worse by default.

I can see some logic in the decision.  XAML for WinUI bases it's layout on a 4px grid.  So having the corners use 4px as a minimum, could solve some potential scaling issues.
I just have no idea where the discussion took place to change it, and feel like I missed something.  Unless of course this decision took place offline, or internally without including the community in the disscussion.
The previous change to 2px and 4 px radii was talked about quite a bit, as it was being implemented.

Or don't use rounded corners at all. Windows apps don't need to consistent with other apps.

Or don't use rounded corners at all. Windows apps don't need to consistent with other apps.

This is more an aesthetic choice here, and I personally like the rounded corners, as it adds a sense of the controls actually being designed compared to just boxes.  It gives a level of polish, and when the corners make their way to the shell and windows themselves, it will no longer feel as out of place to you.

When MS chose 2px as the default I was happy because most other platforms round their controls too much and reduce usability. Please don't increase it

The problem is the corner rendering in XAML is already very bad compared to other platforms. Increasing to 4epx will make it even worse by default.

@Jaiganeshkumaran Yes, I'm not sure how we didn't notice this when we first did the rounded corners but it's a XAML / Composition bug that we will be fixing.

I just have no idea where the discussion took place to change it, and feel like I missed something. Unless of course this decision took place offline, or internally without including the community in the disscussion.

@mdtauk We welcome feedback on the design changes. I'm sure you know that design choices are personal and can be polarizing. Even across Microsoft it's hard for us to agree on any one design system or aesthetic. We bring the community in to the discussions when we can but WinUI's job is to be the native embodiment of the Fluent design system, we don't drive all aspects of the design. This can be frustrating for us too sometimes.
We understand that changes can be disruptive so we welcome feedback like you all are providing. I'd love to hear specific feedback about how we can make these changes easier to adopt. We're doing this experimentation in a branch as the default just so we can evaluate the look and impact. But in order to bring it to main we may need to add knobs to help turn off some or all of the change for folks who don't have time to update their app designs. Please let us know what ideas you have for minimizing the impact to developers.

@mdtauk We welcome feedback on the design changes. I'm sure you know that design choices are personal and can be polarizing. Even across Microsoft it's hard for us to agree on any one design system or aesthetic. We bring the community in to the discussions when we can but WinUI's job is to be the native embodiment of the Fluent design system, we don't drive all aspects of the design. This can be frustrating for us too sometimes.

I suppose it is curiosity over everything that makes me wonder why this change in particular was made.  For over a year the settled wisdom was 2px radius for controls, 4px radius for overlays.  There were control mockups posted, conversations about the changes, and whilst some disagreed, and others were enthusiastic for the changes - it was talked about.
Now the values become 4px and 8px - and it was "snuck" into this branch merge, and I was just asking and wondering why this change is being made, and when it is coming to all controls across the WinUI scope.
I am speculating it is because of the 4px grid, as that is still the core measurement used by Xaml layouts.  I could speculate further about it being related to "Sun Valley" and the refreshed Windows visual design being reported - but with no new 10X builds being released, and no new UI designs being included in Windows Insider builds - there is no way to understand or visualise the direction things are being moved towards.
Then of course there is Xbox, and that UI is the one currently undergoing a transition, for the Series X | S launch - but WinUI is not due to be supported until after 3.0 - and to what level those ResourceDictionaries and Templates will be integrated and open source is not known.

We understand that changes can be disruptive so we welcome feedback like you all are providing. I'd love to hear specific feedback about how we can make these changes easier to adopt. We're doing this experimentation in a branch as the default just so we can evaluate the look and impact. But in order to bring it to main we may need to add knobs to help turn off some or all of the change for folks who don't have time to update their app designs. Please let us know what ideas you have for minimizing the impact to developers.

Developers who re-template their controls will need time to transition their custom templates to avoid breaking changes.  Those who build Custom Controls and those libraries who take dependence on WinUI 3.X - will also need time to compare new templates to their own, to ensure brush, font, and colour resources still work.
Would you consider sharing design comps and mock-ups to show what these new Tokenised controls will look like - so we can either pass comment, pick up on potential issues, or just to feel like we know the next destination on this shared design journey.

One other question I have about the new Corner Radius values.  Will this affect how the ThemeShadows are rendered.  These are essentially 9-Grid images wrapped around the XAML element AFAIU - and are not true shadows that conform to the shape and corner radii of the XAML element?

One other question I have about the new Corner Radius values. Will this affect how the ThemeShadows are rendered. These are essentially 9-Grid images wrapped around the XAML element AFAIU - and are not true shadows that conform to the shape and corner radii of the XAML element?

@mdtauk , you are right and this is something we are actively investigating.

I can see ghost styles are being included with the button resources.  How would you choose to display a Button in the ghost styling?
Is this a Style resource, or are you introducing a Variant concept to Xaml as with Fluent Web, Fast and now Figma?
<Button variant="Ghost", content="Button text" />

I can see ghost styles are being included with the button resources. How would you choose to display a Button in the ghost styling?
Is this a Style resource, or are you introducing a Variant concept to Xaml as with Fluent Web, Fast and now Figma?
<Button variant="Ghost", content="Button text" />

@mdtauk , I am not sure where you are gathering the ghost style, but we are not introducing variant for button styles. It will be a replacement of existing styles.

@jevansaks @chigy @chingucoding Would you consider sharing design comps and mock-ups to show what these new Tokenised controls will look like - so we can either pass comment, pick up on potential issues, or just to feel like we know the next destination on this shared design journey.

@mdtauk , we are working on it as we speak. Stay tuned.

/azp run

Great to see discussions here. Note that these changes are not going into master branch (but a feature branch) so we can continue to have these conversations as we make incremental progress.

@teaP Please don't remove the tilt effect. It's a great effect that I like and I don't find on other platforms. Please don't make Fluent an ugly design like the rest of the web and mobile.

WinUI is blindly copying other platforms and trends and removing everything that made Fluent fluent. This is bad for Windows design

Wow, not happy a change to 4px/8px slipped in unannounced like this. I had to update almost 40 custom controls to sync with the 2px/4px corner radius last time. Was not planning on making significant changes there for a while and definitely not before WinUI 3.0. @jevansaks @ranjeshj @StephenLPeters My strong request is that you don't make increment styling updates like this. We all know Microsoft is cooking up a big design refresh. Please only commit code after it is fully fleshed out and discussed. Then commit the new styling all at once so we can all plan for it and sync with it at once.

Wow, not happy a change to 4px/8px slipped in unannounced like this. I had to update almost 40 custom controls to sync with the 2px/4px corner radius last time. Was not planning on making significant changes there for a while and definitely not before WinUI 3.0. @jevansaks @ranjeshj @StephenLPeters My strong request is that you don't make increment styling updates like this. We all know Microsoft is cooking up a big design refresh. Please only commit code after it is fully fleshed out and discussed. Then commit the new styling all at once so we can all plan for it and sync with it at once.
Edit: I see actually this is a feature branch. Still, please be careful with the main branch changes.

When the changes go to the main branch, you should be using the ControlCornerRadius theme resource, and the OverlayCornerRadius one.  That way the change can be made to those two resources, and they propagate down to your controls or other things where you are setting the corner radii

@mdtauk I already use this resource. They are custom controls. In a perfect world, yes, the update would be transparent. However, corner radius can clip things that shouldn't be clipped, etc. All the designs need to be reviewed and adjusted. It is true that this should go faster the second time now that corner radius was already added (adding the property is where it didn't exist was quite time consuming).

@mdtauk I already use this resource. They are custom controls. In a perfect world, yes, the update would be transparent. However, corner radius can clip things that shouldn't be clipped, etc. All the designs need to be reviewed and adjusted. It is true that this should go faster the second time now that corner radius was already added (adding the property is where it didn't exist was quite time consuming).

I believe this is what's happening, and this branch is the start, as well as the rumoured "Sun Valley" Windows design coming next year.

@mdtauk We asked for a consistent design between old Windows and new Windows and not a consistent design with dumb mobile/web platforms.

@mdtauk We asked for a consistent design between old Windows and new Windows and not a consistent design with dumb mobile/web platforms.

See, I'd rather old Windows catch up with modern fluent design, rather than holding back the Frameworks, with outdated control designs and UI

@mdtauk That's right but I would like to see the web adopt "Fluent UI" adopt WinUI look and feel and not the other way around.

@mdtauk That's right but I would like to see the web adopt "Fluent UI" adopt WinUI look and feel and not the other way around. The removal of the tilt effect in this pull request shows this clearly.

The Tilt Effect is a remnant of Metro from Windows Phone.  It is also not an effect that works well on the web, or with smaller buttons.
There is a form of Acrylic that can work on the Web, but obviously not going through to the desktop.

@mdtauk I like the tilt effect. It's so good and modern why remove it on Windows?

@mdtauk I like the tilt effect. It's so good and modern why remove it on Windows?

In the Windows Phone days I repeatedly asked for that Tilt effect to be added to the inbox controls, and it eventually was added in Windows 8
But the design language has moved on, like those progress rings with the dots.
You seem to act like Windows is being forced to abandon it's current design language - but the same people who designed that, also designed the Web controls, and so it is just a natural evolution of the direction Fluent Design is taking.  The web versions just iterated faster, because its much easier to update those controls - and now its time for Windows to refresh their designs.

Design is an iterative process that we continue to improve based on findings. Sometimes we introduce something that goes out of style just like a style of clothing. As we work on the series of UI updates here, we are also building the foundation that can be updated whenever the style change happens. It is not a matter of if, it is matter of when.
For those of you who want to give feedback on the design, please join us in the following and other issues that can be more specific about particular changes: #3544 , #3546 , #3549

@chigy I understand but please don't remove the tilt effect. I don't find it on other platforms.


[FEATURE] Support upload jar file in POST /batches

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the feature
Currently In REST Api, POST /batches (https://kyuubi.readthedocs.io/en/latest/client/rest/rest_api.html#post-batches)  only
supports executing a path to the resource in external storage (eg. hdfs, s3 and etc).
Supporting uploading the jar file in this API will help users avoid uploading the jar file to other external storage first.

support upload jar file in POST request (but it may violate the JSON mediaType, need to add a new API maybe)
put jar file in temporary folder on server
submit job using the local path on server to jar file in above
clean up temp jar file after submission or finishing execution

Motivation
No response
Describe the solution
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
[X] No. I cannot submit a PR at this time.

Do you have any ideas or suggestions for this? Especially for step 1, how extending the facade of this JSON Restful Api for uploading jar file, or adding new Api for it.
cc @turboFei @pan3793

ok, i will try to put multiple media types to @Consumes .

I am having trouble in implementing upload files by adding MULTIPART_FORM_DATA in @Consumes.
  @Consumes(Array(MediaType.MULTIPART_FORM_DATA, MediaType.APPLICATION_JSON))
or   @Consumes(Array(MediaType.APPLICATION_JSON)).
MultiPartFeature is registered in both client and server, referring to Jersey docs https://eclipse-ee4j.github.io/jersey.github.io/documentation/latest/user-guide.html#multipart
Having HTTP code 415 Unsupported Media Type in response in a unit test.
Also, it seems Livy doesn't support uploading jars. (POST /sessions
https://livy.incubator.apache.org/docs/latest/rest-api.html)


move unshare into chdir

We don't need clone if we don't need to change current dir.

@Burning1020 @fuweid Thanks for suggestion.
https://github.com/containerd/rust-extensions/pull/266


Run Steps

@dhanzy hey - I am having trouble running the application. Is there a way we can host this on Heroku or Netifly?

This has been resolved.


Arrays in C++

Suggested Title
Arrays in C++
A Small Description
Tell me all about the array methods
How soon do you need it?
Tomorrow

tell me about linear search in arrays


refactor: use option structs to replace the long list of function parameters

/hold
Needs to rebase on top of #1030

/unhold
Updated #1030 to base on top of this PR

/lgtm


Relate Cards

Also updated search functionality so that by default the board will only be searched by names of cards (not descriptions)
Created functionality to "Relate Cards" this will take either a given list of cards, or search the name of cards for given criteria on the board. In either case the list of cards will then have their descriptions updated to have a "Related Cards" section that will have links to the other Trello cards that have been identified.
There is no current functionality to add or remove cards to this list (via hubot).

This sounds interesting, how have you been using it?

SO interesting story, this functionality brought about me having a conversation with Trello support and them finding a bug in their code. What this does is allow you to build cards that are related to each other, if you're using Trello as a Scrum tool for example this is an excellent way to have "related stories". The one "bug" is that while in the past I would use pipes (|) as a delimiter for "themes" i.e. Website | Build HTML file Website | Build JS file Trello's search code doesn't handle pipes correctly resulting in more results than expected when relating a theme. Instead you can use Parenthesis and it works as expected.


docker mvp

I'd like to add a /docker/ folder with Dockerfile and docker-compose examples
I see in the docs that its mentioned, but don't see any issues.
Is anyone working on this?
If not, any advice and/or encouragement for me?

Started on this
https://github.com/n0-computer/iroh/compare/main...onezoomin:iroh:main
it works if i bind the port and access directly via http
http://iroh.1zm.in:9050/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR?filename=test.jpg
and if i access via traefik reverse proxy on https
https://iroh.1zm.in/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR?filename=test.jpg
cheers

Amazing! Thank you @gotjoshua! We'd welcome a PR that introduces dockerfiles, and can wire builds up to CI

So far, no ci, but i can ask @tennox if he's up for that part.
I'll split the work into separate issues/PRs
This one for the MVP (just using the quick start instructions in a simple docker setup)
One for CI (likely to use gitlab for this)
One for docker production details, to split the services in docker compose and use a non root user
Maybe one for live hacking, that uses the development instructions, but not sure about that one. Could be better to make the repo gitpod ready... Tbd.

@b5 questions for you about the setup.sh
Are you building and posting manually to https://vorc.iroh.computer/bin/ ?
Do you have versions also there?
I am using that fetch and run strategy for the MVP, but version pinned reliably built binaries will be needed/desirable for publishing images to container registries...


llama2 always show even if not installed

Hello,
I'm writing this issue because the model llama2 is always shown in UI pickers even if it's not installed.

ollama ls
NAME            	ID          	SIZE  	MODIFIED
codellama:latest	8fdf8f752f6e	3.8 GB	23 minutes ago
mistral:latest  	61e88e884507	4.1 GB	43 minutes ago

I'm running Version 1.5.5 (14)

Fixed, will be available in next release.


ncurses rendering issue under wsl/ubuntu

Your Windows build number:  Microsoft Windows [Version 10.0.17134.285]

What you're doing and what's happening: Under WSL/Ubuntu/18.04 this simple ncurses code should display 5 x characters.

#include <stdio.h>
#include <curses.h>

int main(int argc, char *argv[]) {
    int i;
    initscr();
    erase();
    for(i=0; i<5; i++)
        mvaddch(0, i, 'x');
    refresh();
    getch();
    endwin();

What's wrong / what should be happening instead:

Only one x character is displayed.
5 x characters should be displayed.
Note that this is problem with Windows Console specifically. When running over wsl-bridge (eg wsltty or wsl-terminal) this works correctly.

I'm fairly certain this is a dupe of #240


Animation key button in property inspector fails to register click sometimes

Tested versions
Reproducible in 4.3.beta [b97110cd307e4d78e20bfafe5de6c082194b2cd6]
System information
Windows 11 (10.0.22631)
Issue description
The symptoms of this issue are fairly straight-forward. Sometimes when you click the key button in the property inspector (after having selected an AnimationPlayer node with at least one animation) you'll find that the click doesn't always register.
I have yet to pin down exactly when or why it happens, but at least one consistent repro is if you let the tooltip of the property itself show up before you click, in which case the click will only dismiss the tooltip but not actually register as a click of the key button, thereby failing to add a new keyframe.
You should be able to see that in this video:
https://github.com/godotengine/godot/assets/4884246/4b1dd288-5e5c-4dfd-a8e5-8f33f505dce0
There may very well be other cases where this happens as well, which might speak to a bigger problem with the button in general.
Steps to reproduce

Open the MRP
Select the AnimationPlayer node
Select the Sprite node
Hover over the key button for the position property
Wait for the tooltip to show up
Click the button
Note how no keyframe is added in the Animation dock

Minimal reproduction project (MRP)
key-button-fails-to-register.zip

Related issue: #92382


[Proposal] Add a new extra named "except-mujoco-py"

Proposal
Related to previous proposal: https://github.com/Farama-Foundation/Gymnasium/issues/921. When user want cython>=3.0.0 but also an almost full features of gymnasium .
Provide a new extra named except-mujoco-py would make user a lot easier than manually include all the feature except for mujoco-py.
Motivation
mujoco-py is a legacy and deprecated stuff. All newly created project will rarely need it. Adding a new extra option except-mujoco-py would save user a lot of time from manually include every extra option except for mujoco-py.
Pitch
pip install gymnasium[except-mujoco-py] will install every extra dependencies except mujoco-py (which required cython < 3).
Alternatives
An alternative would remove the support of mujoco-py support.
Additional context

https://github.com/Farama-Foundation/Gymnasium/issues/921

Checklist

[X] I have checked that there is no similar issue in the repo

It will likely be removed at some point.
For now You can just not use gymnasium[all] And only use the ones you need

I don't think this is a good idea and as @Kallinteris-Andreas notes, we will more likely remove it from the repo in the future.
In the meantime, I would recommend just doing pip install "gymnasium[atari, accept-rom-license, ...]" for all the options you want


Add Code DiagnosticAnalyzer and CodeFixProvider for Custom Application classes

Context https://github.com/dotnet/android/issues/8410
Building out our DiagnosticAnalyzer support lets add a check to detect if a user has a Custom Application class implemented correctly. When subclassing Android.App.Application, the "Activation Constructor" (IntPtr handle, JniHandleOwnership transfer) must also be provided. Failure to do so results in the following crash
[ERROR] FATAL UNHANDLED EXCEPTION: System.NotSupportedException: Unable to activate instance of type MyApp from native handle 0x7ff1f3b468 (key_handle 0x466b26f).

So lets write a DiagnosticAnalyzer which will check for a constructor which has a specific set of arguments. In this case an IntPtr and JniHandleOwnership . We only do this for classes which derive from Android.App.Application.
If we find a class which does not have the constructor we will report a XAA001 issue.
The code fix is designed to inject the required constructor into the syntax tree.

@pjcollins is there anything else I need to do for localization? I just added a base Resources.resx file and designer. But that is all. I can't remember if I need to do anything else?

@pjcollins is there anything else I need to do for localization? I just added a base Resources.resx file and designer. But that is all. I can't remember if I need to do anything else?

A Resources.resx update should be all that is needed initially. This should trigger an initial PR from the OneLoc build system to bring in English strings which are then sent for translation.

Extend that support to add a `CustomApplicationAnalyzer` which checks
for the [`(IntPtr, JniHandleOwnership)`][1] constructor on
[`Android.App.Application`][2] subclasses, as this constructor is
currently required.

If the constructor is missing:

	[Application]
	public class MyApp : Application {
	}

then the app will crash during startup:

	System.NotSupportedException: Unable to activate instance of type MyApp from native handle 0x7ff1f3b468 (key_handle 0x466b26f).

If we find an `Application` subclass that is missing the required
constructor, we'll emit a DNAA0001 warning:

	warning DNAA0001: Application class 'MyApp' does not have an Activation Constructor.

Additionally, provide a `CustomApplicationCodeFixProvider` which will
inject the required constructor into the syntax tree.

Finally, rename the previous `XAD0001` warning to `DNAS0001`.
Our convention is as follows:

  * `DNA`: prefix for .NET for Android messages
  * `A` for *Analyzers*, `S` for *Suppressors*
  * 4 digit code.

[0]: https://learn.microsoft.com/en-us/dotnet/api/microsoft.codeanalysis.diagnostics.diagnosticanalyzer?view=roslyn-dotnet-4.9.0
[1]: https://learn.microsoft.com/en-us/dotnet/api/android.app.application.-ctor?view=net-android-34.0#android-app-application-ctor(system-intptr-android-runtime-jnihandleownership)
[2]: https://learn.microsoft.com/en-us/dotnet/api/android.app.application?view=net-android-34.0


[FEATURE] update ollama integration with Python client

Is your feature request related to a problem? Please describe.
We can now do pip install ollama
Describe the solution you'd like
Ideally we want to replace the current urllib requests with their client library.
https://github.com/argilla-io/distilabel/blob/main/src/distilabel/llm/ollama.py
Describe alternatives you've considered
N.A.
Additional context
N.A.

@sdiazlor https://github.com/ollama/ollama/blob/main/docs/modelfile.md


Fix the WireMock 3.x content inclusion

As reported by @tomakehurst , 3.x does not actually include the 3.x content after I restructured the repository and stopped doing git checkout magic

A bit of YOLO, merging to main to see the CD


DrugCell: hardcoded path in preprocess.sh

/usr/local/DrugCell/preprocess.sh: line 56: /homes/ac.rgnanaolivu/miniconda3/etc/profile.d/conda.sh: No such file or directory
CommandNotFoundError: Your shell has not been properly configured to use 'conda activate'.
To initialize your shell, run
$ conda init <SHELL_NAME>

Currently supported shells are:

bash
fish
tcsh
xonsh
zsh
powershell

See 'conda init --help' for more information and options.
IMPORTANT: You may need to close and restart your shell after running 'conda init'.

Please don't use conda in your shell scripts. Refer to the template scripts.

this issue has been fixed


USB SCB backup fails - wrong partition being used

Reports:
https://t.me/raspiblitz/108839
https://t.me/raspiblitz/109418

Alternatives to save the SCB until fixed:
RTL, Thunderhub
bos TG bot: https://raspibolt.org/guide/bonus/lightning/balance-of-satoshis.html#optional-connect-your-node-to-a-telegram-bot
Nextcloud backup + SCP : https://github.com/rootzoll/raspiblitz/blob/v1.8/README.md#backup-for-on-chain---channel-funds

fixed in #3393