Revert "Merge pull request #1052 from donoghuc/pin-postgres"

This reverts commit d2fddeafdab1762171aa5d92dec1b7fc16f3832b, reversing
changes made to 44a379c064060483dbfd189dd3f2b0e18201daeb.

Puppetdb ended up patching this to avoid the issue. It appears the containers are pushed based on commit to master branch. So we pick up latest puppetdb and latest postgress and we are good.

CLA signed by all contributors.


Not able to replicate results of paper

Hi, thanks for sharing your code! But after running for 40 epochs on the java-small dataset, I am just getting an F1 score of 32% (the original paper shows 43%).
Do you have any ideas on this? Thanks!

Hello. I also could not reproduce the score. Probably because of the differences in the framework specifications, but I don't know the details. In the end, I used the author's TensorFlow code for the reproduction experiment (https://github.com/tech-srl/code2seq)
Sorry for not being able to help. If you can find out the cause, I would be happy if you could tell me.

Did you use the same parameters in run_small.sh? I used java-small and run_small.sh to train more than a dozen epochs, F1 score did not improve.


559-endpoint-log-events - Adds middleware for calling analytics events for each endpoint

Purpose
Adds middleware for analytics events on endpoints
Changes

Adds http middleware to fidesops endpoints that calls fideslog with endpoint path, response code, source, and error class
Adds X-Fides-Source header to all endpoint calls from admin ui and privacy center ui
Turns off prefer-default-export for eslint in admin-ui
Turns on dev mode by default in fidesops- https://github.com/ethyca/fidesops/pull/622/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3R27.

Checklist

[x] Update CHANGELOG.md file

[x] Merge in main so the most recent CHANGELOG.md file is being appended to
[x] Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
[x] Add a link to this PR at the end of the description with the PR number as the text. example: #1

[ ] Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
If docs updated (select one):

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Good unit test/integration test coverage
[ ] This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
[ ] The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket
Fixes #559

thanks @eastandwestwind, I'll review this AM

@eastandwestwind what about unit tests of this format? just testing that prepare_and_log_request was called with the correct parameters. I'm just arbitrarily adding them to the patch connections api endpoint tests:
class TestPatchConnections:
...
    @mock.patch('fidesops.main.prepare_and_log_request')
    def test_patch_connections_incorrect_scope_analytics(
        self, mocked_prepare_and_log_request, api_client: TestClient, generate_auth_header, payload
    ) -> None:
        url = V1_URL_PREFIX + CONNECTIONS
        auth_header = generate_auth_header(scopes=[STORAGE_DELETE])
        response = api_client.patch(url, headers=auth_header, json=payload)
        assert 403 == response.status_code
        assert mocked_prepare_and_log_request.called
        call_args = mocked_prepare_and_log_request._mock_call_args[0]

        assert call_args[0] == 'PATCH: http://testserver/api/v1/connection'
        assert call_args[1] == 403
        assert isinstance(call_args[2], datetime)
        assert call_args[3] is None
        assert call_args[4] == 'HTTPException'

    @mock.patch('fidesops.main.prepare_and_log_request')
    def test_patch_http_connection_successful_analytics(
        self, mocked_prepare_and_log_request, api_client, db: Session, generate_auth_header, url
    ):
        auth_header = generate_auth_header(scopes=[CONNECTION_CREATE_OR_UPDATE])
        payload = [
            {
                "name": "My Post-Execution Webhook",
                "key": "webhook_key",
                "connection_type": "https",
                "access": "read",
            }
        ]
        response = api_client.patch(url, headers=auth_header, json=payload)
        assert 200 == response.status_code
        body = json.loads(response.text)
        assert body["succeeded"][0]["connection_type"] == "https"
        http_config = ConnectionConfig.get_by(db, field="key", value="webhook_key")
        http_config.delete(db)

        call_args = mocked_prepare_and_log_request._mock_call_args[0]

        assert call_args[0] == 'PATCH: http://testserver/api/v1/connection'
        assert call_args[1] == 200
        assert isinstance(call_args[2], datetime)
        assert call_args[3] is None
        assert call_args[4] is None


contracts/: support LP token price

on-chain support LP tokens price (UNI-LP & Sushi-LP)

xSushi exchange rate: https://github.com/sushiswap/xsushi-exchange-rate/blob/master/contracts/xSushiExchangeRate.sol


"Attempted to redefine property XXX" hangs the entire app on Android

[x] I have reviewed the documentation
[x] I have searched existing issues
[x] I am using the latest React Native version

Environment
Environment:
  OS: macOS High Sierra 10.13.4
  Node: 9.10.1
  Yarn: 1.5.1
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: Xcode 9.3 Build version 9E145
  Android Studio: 3.1 AI-173.4670197

Packages: (wanted => installed)
  react: ^16.3.0-alpha.0 => 16.3.0
  react-native: 0.55.0 => 0.55.0

Steps to Reproduce
Define a style with two duplicated style in a single style, say borderRadius
Expected Behavior
The app can start successfully, with a redbox
Actual Behavior
The app hangs, react native fails to initialize with the following error
04-06 02:17:24.913  5941  5991 E ReactNativeJNI: Got JS Exception: Attempted to redefine property 'borderRadius'. (http://<IP_ADDRESS>:8081/index.delta?platform=android&dev=true&minify=false:175550)
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: Exception in native call from JS
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: com.facebook.react.devsupport.JSException: Attempted to redefine property 'borderRadius'. (http://<IP_ADDRESS>:8081/index.delta?platform=android&dev=true&minify=false:175550)
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: 	at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: 	at android.os.Handler.handleCallback(Handler.java:739)
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: 	at android.os.Handler.dispatchMessage(Handler.java:95)
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: 	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29)
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: 	at android.os.Looper.loop(Looper.java:148)
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: 	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:192)
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: 	at java.lang.Thread.run(Thread.java:818)
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: Caused by: com.facebook.jni.CppException: Attempted to redefine property 'borderRadius'. (http://<IP_ADDRESS>:8081/index.delta?platform=android&dev=true&minify=false:175550)
04-06 02:17:24.914  5941  5991 E unknown:ReactNative: 	... 7 more

The real issue here is that this is EXTREMELY hard to debug, since with the new JS delta build, the position it points to is with index.delta and it's a JSON file instead of a JS file, so that lineno (175550) is not accurate anymore. It would be great that this would behave like a normal error and do not fail the entire app.

Did you ever resolve this yourself, @shivawu ?  Running into a hard crash because we apparently rewrote Copy someplace, not sure where to even start with debugging it.

my problem was solved when I changed render = () => (...) to render(){ return (...)} in react component


FormBuilderTypeAhead is permanently removed from version 6.0.0?

Is FormBuilderTypeAhead permanently removed? I have quite a few of these in my code and staying with version 5.0.0 is no longer an option due to package conflicts. A bit stuck right now.

@rgb1380 you can use https://api.flutter.dev/flutter/material/Autocomplete-class.html which was introduced in flutter 2, I guess this is the reason FormBuilderTypeAhead was removed.
would appreciate FormField version of this though

would appreciate FormField version of this though
exactly, they are not the same thing without the additional validation that used to be provided through FormBuilderTypeAhead.

FormBuilderTypeAhead exists in another package but same repository


(1.21) "Immediately Play" option and switching dimensions

Seems like there's a bug where switching dimensions with this option enabled causes the game to pull from the generic music.game sound event instead of choosing the appropriate biome. Causes a bit of tonal disconnect since it makes the Nether play the more light-hearted Overworld tracks

Thanks I fixed this in the latest version


Scans flip while building the first submap

I have managed to get cartographer_ros working for me reasonably well for the mapping bit except for a small glitch at the start. After beginning to create the first submap, the scans flip. The following GIF shows what I am talking about:

The mapping continues well after this flip and no issue is seen. But I can't seem to get my head around why this flip happens.

Output of rosbag_validate: https://gist.github.com/precyon/2a5e0efffcae84d184028b78601535ff

Repo with all the configuration files:  https://github.com/precyon/cartographer_test
which is based on cartographer_mir@6b228cd
Also, I use<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

The bagfile: https://drive.google.com/file/d/1WemcOkNY5FjCHBjdKSQ5MnP0kXWnBkqo/view?usp=sharing

I run,
roslaunch cartographer_test 2d_mapper_demo.launch bag_filename:=test_take1.bag
Thanks!

@precyon, I had a look at your files and noticed that you have rotated your IMU frame ( id: vectornav) by 180 degrees. Is it to account for the way your IMU is mounted?
Like mentioned in #990, try breaking up your URDF into an having an intermediate imu_link which is at the same position as vectornav but rotated to be Z-up. Use imu_link as the tracking frame and see if this resolves your issue.
And since #990 is closed, see if your problem persists in the the latest versions.

Thanks! I will try this and report back.

I recommend just changing your  tracking frame to base_link. If your base_link is not z-up, make another child frame of base_link which is z-up and use that as the tracking frame.

@precyon, I had a look at your files and noticed that you have rotated your IMU frame ( id: vectornav) by 180 degrees. Is it to account for the way your IMU is mounted?
Like mentioned in #990, try breaking up your URDF into having an intermediate imu_link which is at the same position as vectornav but rotated to be Z-up. Use imu_link as the tracking frame and see if this resolves your issue.
And since #990 is closed, see if your problem persists in the latest versions.

Hey @pvishal which file did you see the 180 degree flip? I am having the same issue. Thanks


yaki mobile - search bar

**context **
after the 04/01/2024 review, it was decided to remove the search icon
** TODO **
removed the icon in file: teams_declarations_summary.dart

double with ticket #1209


The official example application has been superseded

On the official Backbone.js page in the intro section there is a link to the example application (it's in the second paragraph from the top). The source code of this example application has been superseded and the newest version of the source code is located in Addy's TodoMVC repository under architecture-examples/backbone.
This newer version is superior - a couple of things have been refactored and optimized. Therefore, it would make sense to use this source code as the official example. So, it'd be cool if you could update the http://documentcloud.github.com/backbone/examples/todos/ directory with the newest version of the source code.

Do you have a diff of the changes between the original and @addyosmani's version? I'd be curious to take a look before merging the changes.

I'll get you over a diff this evening :)

Hm, not sure how to do a diff (still haven't figured out GitHub), but the two things that bothered me (and that have been changed) are:

the custom classes are now assigned to (local) variables (they're no longer global properties), and
the "blur" handler for ".todo-input" is no longer bound manually, but has been (appropriately) moved to the events hash.

Also, I noticed they added "mark all done" functionality.

Figured I might as well submit a PR as that would also give us the diff. Here it is:
https://github.com/addyosmani/backbone/commit/3cf1bb4ed51a47a87c50a56896a10e2fe597172a#diff-2


Regression: $location.replace() with changes only to stateParams using reloadOnSearch:false - still cause page reload

Hey,
Doing the following:
$location.search('myParam', 'someValue');
$location.replace();
Seems to cause page reload, even when we use "reloadOnSearch:false" for our state.
We use angular 1.3.15 and angular-ui-router 0.2.14 (Chrome  42.0.2311.135 (64-bit) - latest)
The strange thing is, that it started to happen only on the following scenario:

Since Chrome 42 version.
When navigate to our app using Chrome's basic-authentication via URL, for example:
http://username@email.com:password@<IP_ADDRESS>:9000

It doesn't happen if we use Chrome 41 or on Chrome 42 without the basic-authentication navigation feature.
So the flow is the following:

We navigate to our app as above.
Then click some element that causes navigation to a new state
The new state is doing $location.search('myParam','myValue') then $location.replace()
A page reload occurs.

(BTW, the reason we use the URL basic-authentication feature - is for selenium-testing for our app).
Any ideas what could cause this regression?

We pushed 0.2.14 less than a week ago. Do your tests pass on 0.2.13?

Nope. Actually we worked with 0.2.13, I wasn't sure if this is related - so I tried also 0.2.14.
It doesn't work on 0.2.13 as well

Add $rootScope.$on("$locationChangeSuccess", console.log.bind(console));, and see if that displays anything. If yes, it's probably a UI-Router bug. If no, it's probably a Chrome or Angular bug.

Interesting. It does print some stuff, but now I see it also prints this exception (which wasn't before):
Error: [$rootScope:infdig] 10 $digest() iterations reached. Aborting!
Watchers fired in the last 5 iterations: []
http://errors.angularjs.org/1.3.15/$rootScope/infdig?p0=10&p1=[]
at REGEX_STRING_REGEXP (http://upitewta.balovgop%40ravellosystems.com:astadatifgefdek@<IP_ADDRESS>:9000/bower_components/angular/angular.js:63:12)
at Scope.$get.Scope.$digest (http://upitewta.balovgop%40ravellosystems.com:astadatifgefdek@<IP_ADDRESS>:9000/bower_components/angular/angular.js:14346:19)
at Scope.$get.Scope.$apply (http://upitewta.balovgop%40ravellosystems.com:astadatifgefdek@<IP_ADDRESS>:9000/bower_components/angular/angular.js:14571:24)
at http://upitewta.balovgop%40ravellosystems.com:astadatifgefdek@<IP_ADDRESS>:9000/bower_components/angular/angular.js:16308:36
at completeOutstandingRequest (http://upitewta.balovgop%40ravellosystems.com:astadatifgefdek@<IP_ADDRESS>:9000/bower_components/angular/angular.js:4924:10)
at http://upitewta.balovgop%40ravellosystems.com:astadatifgefdek@<IP_ADDRESS>:9000/bower_components/angular/angular.js:5312:7 undefined

Sorry - this one was before adding the console print, I just missed that. I wonder if this is related

Unfortunately there's not enough information to say. If you can post a plunkr with a reproduction of the issue, I'll take a look.

Ok, it is a bit tricky but here it is:
http://plnkr.co/edit/C1VFq5gP6VIZ9bNLPm64?p=preview
This a simple 2 states UI router app. "Home" and "Page1".
"Page1" also has a controller that changes (adds) a param to its state and do $location.replace(). It is also configured with "reloadOnSearch:false".
You should run the above using the separate window option (and not the embed version, which takes out the state params, not sure why):
(1) http://run.plnkr.co/FvFE87Kb51jHYlbI/#/home
Running the above - going through the 2 states, works fine.
Now, try to run it with Chrome's (42) URL basic-authentication feature. For example navigate to:
(2) ben:ben@http://run.plnkr.co/FvFE87Kb51jHYlbI/#/home
(if the plunker breaks, just start it again with (1) and change the URL again).
Then, navigate to home, and to page1. When navigating to page1, you'll get a console exception (and you'll see the page is reloading, keep the console.log preserved between navigation of course..)

BTW - it seems you need to sign in into plunker for it to work well (tried it here on another machine, when using the ben:ben@ option the plunk stopped working until we signed in)

Hey,
And updates on this item? Currently this seems to block us to do testing using chrome..

@benbracha can you try with 0.2.15? See this updated plunk:
http://plnkr.co/edit/6MPpWqugEHi5Stf2r0wZ?p=preview

Still cause a page refresh, and an error shown in the log.
You can try it according to the scenario I wrote above

It happens without ui-router involved, this must be an angular bug related to the user/password and $location
http://plnkr.co/edit/6MPpWqugEHi5Stf2r0wZ?p=preview

Thanks.
Where should I continue this thread? On angular repo?

Yeah. I'd first try the most recent builds of both angular 1.3 and 1.4, then search the angular issues, then file a bug there.


Can't compile cup program which has a function which returns a struct

I tried to compile the following program:
struct A{
	a: int;
	b: int;
	c: int;
}

fn a(): A{
	let a_: A;
	a_.a = 1;
	a_.b = 2;
	a_.c = 2;
	return a_;
}

fn main(){

}

Compiler tells me:
A
compiler/codegen.cup:66:9: Unsupported type size

This is a known limitation, and there are currently no plans (by me at least) of passing around structs as values to/from functions. The reason for this is so that all function return values can fit in a single x86_64 register.
Allowing passing structs as arguments / as return values would necessitate figuring out how (and where) to properly allocate the space in the caller, and then copying the whole struct into that location.
If this is something you're interested in working on, I'm happy to provide any assistance I can, but I am personally more focussed on other projects at the moment to work on this myself.

Okay, maybe I'll try to play around with that, but I'm not really an assembly programmer or something so idk.

Would it make sense to push struct fields to the stack instead of passing them on the registers?

Would it make sense to push struct fields to the stack instead of passing a struct on the register?

Yep. let's assume the following example:
fn get_a(): A {
    let obj: A;
    ...
    return obj;
}

fn foo() {
    let a_in_foo: A = get_a();
}

Here, we'd want to do something like:

Allocate space for a_in_foo in the stack frame for foo
Pass an extra (hidden) parameter to get_a, which represents &a_in_foo (the address)
Have return obj copy over the struct directly into a_in_foo using the address.

There are some cases to be careful of, which I'm not exactly sure what the best way to handle is, such as:
fn foo(): A {  return get_a(); }
fn bar(): A {  return foo(); }
fn baz(): A {  return bar(); }

One way to deal with this would be to allocate / copy an intermediate object in each function, but that seems very wasteful. It would be nice to have some way to "figure out" where the object actually needs to be allocated, and then just pass around pointers.
Obviously that is more complex, and doesn't need to all be implemented at once. Just make sure that any design you pick leaves room for improvements like these to be made in the future, and that at the very least such situations are handled correctly, even if it is inefficient.

A bit offtopic question but can I share ideas/suggestions in issue tracker?

A bit offtopic question but can I share ideas/suggestions in issue tracker?

Sure.

Struct copying for var to var cannot be done too?

Struct copying for var to var cannot be done too?

It would be nice to support that as well. I didn't mention it because that part would be fairly straightforward, we just copy the fields from the location of the first variable to the other.

Struct copying for var to var cannot be done too?
I've just noticed that you can do something like that:

import "std/memory.cup"

struct A{
    i: i32;
}

initialize A(b: i32){
    self.i = b;
}

fn main(){
    let a: A* = new A(5);
    let b = 5;

	let c: A = *a;

    print(c.i);
}

I've just noticed that you can do ...
Copy by dereferencing.

I don't believe I ever added any logic in the compiler that loops over all members of a struct and copies it over. Even though this passes type checking, I suspect this won't actually work for structs that don't fit in a register. In the current state of the language this should throw an error.

Would it make sense to push struct fields to the stack instead of passing a struct on the register?

Yep. let's assume the following example:
fn get_a(): A {
    let obj: A;
    ...
    return obj;
}

fn foo() {
    let a_in_foo: A = get_a();
}

Here, we'd want to do something like:

Allocate space for a_in_foo in the stack frame for foo
Pass an extra (hidden) parameter to get_a, which represents &a_in_foo (the address)
Have return obj copy over the struct directly into a_in_foo using the address.

There are some cases to be careful of, which I'm not exactly sure what the best way to handle is, such as:
fn foo(): A {  return get_a(); }
fn bar(): A {  return foo(); }
fn baz(): A {  return bar(); }

One way to deal with this would be to allocate / copy an intermediate object in each function, but that seems very wasteful. It would be nice to have some way to "figure out" where the object actually needs to be allocated, and then just pass around pointers.
Obviously that is more complex, and doesn't need to all be implemented at once. Just make sure that any design you pick leaves room for improvements like these to be made in the future, and that at the very least such situations are handled correctly, even if it is inefficient.

Btw by allocating space in stack frame do you mean just pushing onto stack or something else?

Btw by allocating space in stack frame do you mean just pushing onto stack or something else?

You should be able to use the  add_variable_to_current_block(var) function in parser.cup. you're not "pushing" anything yet, we just reserve more space in the function prologue to be able to store the struct, and the compiler just tracks the offsets.

So we allocate more space during parsing of the function?

From what I see it is already done in function parsing.

I don't think I'm able to implement this.

I don't think I'm able to implement this.

No worries, thanks for trying!


[Blog] What's New Reporting CLI

Describe the blog post your would like to write
A blog post which talks to what Reporting CLI is, who is Reporting CLI built for, what are some examples, and where can I find out more information?
What is the title of the blog post?
What’s new: Reporting CLI with OpenSearch
Who are the authors?
@alicejw-aws
What is the proposed posting date?
2/16

Thanks @brijos ! I'll check with the SMEs and find out what we want to highlight about the Reporting CLI.
You can use the Reporting CLI if you want to:
-- automate report generation with AWS Lambda functions, or cron
-- send reports to large groups via email lists
I'll find out more use case examples too.

Update: Started draft based from the new blog "What is" template. Will set time with @brijos , @rupal-bq, and @anirudha to get the real world examples to describe.

Update: Draft has been tech reviewed by 3 SMEs and is now approved for editiorial review. Asana request is updated.

PR is merged, ok to close ticket.


Supports Cat's Xor as an Endpoint result

As discussed on Gitter. It would be useful to support endpoints that return Xor[A, B] representing a failure and success case.

We've made the same thing with scalaz \/ in glopart. I could port some code here.
But it would be nice to know how to work with left branch in the end, when we fold it it Response. I mean, should we just apply encoder to an error? And what about HTTP status codes?

@ImLiar that's a great question actually. I probably need think this over, but for now I imagine this to be something like this:
case class Error(message: String)
val a: Endpoint[Xor[Error, Int]] = get("div" / int / int) { (a: Int, b: Int) =>
  if (b == 0) Output.payload(Xor.left(Error("Can't divide by 0")), Status.BadRequest)
  else Ok(a / b)
}

So basically this should work fine (not need to change io.finch.internal.*) as long as we have EncodeResponse defined for Xor[A: EncodeResponse, B: EncodeResponse].

Still need a folder for Xor[Response, Response] => Response, but yea, I got it.

Well, it would be nice to pick Content-Type from instance of EncodeResponse which is applied to A or B, depending on Xor content. But with current API it seems impossible:
new EncodeResponse[Xor[A, B]] {

      override def apply(rep: Xor[A, B]): Buf = ???
      override def contentType: String = ???

    }

Fixed in #518.


fix: allow opting-into upstream probes

Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Allow users to opt-into upstream probe definitions.
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

[ ] CHANGE (fix or feature that would cause existing functionality to not work as expected)
[ ] FEATURE (non-breaking change which adds functionality)
[x] BUGFIX (non-breaking change which fixes an issue)
[ ] ENHANCEMENT (non-breaking change which improves existing functionality)
[ ] NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.

Users can opt-into the upstreamProbesOptIn (boolean, false by default) for KSM to sync with upstream's health probe definitions.

Tested downstream (CMO), on enabling upstreamProbesOptIn.
diff --git a/assets/kube-state-metrics/deployment.yaml b/assets/kube-state-metrics/deployment.yaml
index ec651432e..e73091269 100644
--- a/assets/kube-state-metrics/deployment.yaml
+++ b/assets/kube-state-metrics/deployment.yaml
@@ -57,7 +57,19 @@ spec:
           ^kube_pod_completion_time$,
           ^kube_pod_status_scheduled$
         image: registry.k8s.io/kube-state-metrics/kube-state-metrics:v2.13.0
+        livenessProbe:
+          httpGet:
+            path: /livez
+            port: 8080
+          initialDelaySeconds: 5
+          timeoutSeconds: 5
         name: kube-state-metrics
+        readinessProbe:
+          httpGet:
+            path: /livez
+            port: 8080
+          initialDelaySeconds: 5
+          timeoutSeconds: 5
         resources:
           requests:
             cpu: 2m
diff --git a/jsonnet/main.jsonnet b/jsonnet/main.jsonnet
index 7539fb456..ffabfb4f0 100644
--- a/jsonnet/main.jsonnet
+++ b/jsonnet/main.jsonnet
@@ -216,6 +216,7 @@ local inCluster =
         kubeRbacProxyImage: $.values.common.images.kubeRbacProxy,
         commonLabels+: $.values.common.commonLabels,
         mixin+: { ruleLabels: $.values.common.ruleLabels },
+        upstreamProbesOptIn: true,
       },
       nodeExporter: {
         namespace: $.values.common.namespace,
@@ -439,7 +440,7 @@ local inCluster =
     openshiftStateMetrics: openshiftStateMetrics($.values.openshiftStateMetrics),
   } +
   (import './utils/anti-affinity.libsonnet') +
-  (import 'github.com/prometheus-operator/kube-prometheus/jsonnet/kube-prometheus/addons/ksm-lite.libsonnet') +
+  (import 'github.com/rexagod/kube-prometheus/jsonnet/kube-prometheus/addons/ksm-lite.libsonnet') +
   (import './utils/ibm-cloud-managed-profile.libsonnet') +
   (import './components/metrics-server-audit.libsonnet') +
   {};  // Including empty object to simplify adding and removing imports during development

[ ] Add a comment describing the way probes are defined and expected to work.

@simonpasquier Pushed all the suggested changes but s/defaults.ignorePaths/[] and s/super.ignorePaths/[] since will always be [], in addition to the current implementation allowing for a single source of truth for the default value?

I generated the manifest with enableProbes: true but Kubernetes isn't happy with it:
$ kc events
LAST SEEN                TYPE      REASON      OBJECT                                    MESSAGE
6m20s (x2355 over 21h)   Warning   Unhealthy   Pod/kube-state-metrics-68fccdc5f7-9wzdn   Liveness probe errored: strconv.Atoi: parsing "http-metrics": invalid syntax
80s (x2703 over 21h)     Warning   Unhealthy   Pod/kube-state-metrics-68fccdc5f7-9wzdn   Readiness probe errored: strconv.Atoi: parsing "telemetry": invalid syntax

The probes seem to work now, my guess is that due to the names being hardcoded (for KRP), they had to be updated, the lack of which made the controller-manager parse the port strings as numbers since they weren't defined beforehand. It looks like the workflows need to be jumpstarted, though.

Tested on a cluster, seems to work now. I've made KRP's ports the single source of truth for KSM's probes and ports for convenience.

Needs an approval (for workflows).

https://github.com/prometheus-operator/kube-prometheus/actions/runs/11370566998/job/31653537858?pr=2505 fails on kube-state-metrics check for metrics.

Fixed, needs workflow approval here

Re-ping, @simonpasquier for another look here. 🙁

Since port definitions use the containerPort as keys, I'm not sure if the warnings can be addressed. Since the APIServer sees this as an anti-pattern, a potential fix may come from KRP. I'll see if we can do something there.

Since port-definitions use the port numbers as keys, I believe there's no workaround to define the same ones on KSM, without server-side apply warnings. I'll open a ticket/PR upstream to see if we cannot address this there.

Actually, since Kubelet looks at KSM's ports and pings them on the proxy (which then goes through successfully if the port definitions are duplicated) may suggest that we'd need to bring this up to the upstream k/k community to address this particular use-case.


setting play time limit to not defined

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.
[ ] This issue is a feature request to test other Nintendo Parental Controls mobile app configurations

Is your feature request related to a problem? Please describe.
When you want to delete the playtime limit, but want to keep the bedtime alarm, you need to set the playtime limit to not defined.
But It looks like you are not able in home assistant to set it to not defined
Describe the solution you'd like
If i am correct, the maximum time which you can set is 6 hours.
Perhaps an option would be if you set it to higher then 6 hours it is changed to "not defined"
Perhaps with a warning message?
Describe alternatives you've considered
A binary switch?

Okay I found out, that every wrong value (e.g. 2:04:24) leads to not defined.
Which is a little bit problematic for my automations, but good for using it to set not defined XD

Okay I found out, that every "wrong" value (e.g. 2:04:24) leads to not defined. Which is a little bit problematic for my automations, but good for using it to set not defined XD

Have to correct me, the app shows not defined but in really it's defined...
@pantherale0 Can you give me a Hint what code i have to change to be able to set more than 6 hours?

@JokerGermany yep, was going to say, the API will not accent higher than 6 hours.
Will see if I can work on the outstanding issues today/tomorrow

Next version will replace the time entity with a number entity that when set to -1 should set the play time limit to not defined... unfortunately the app seems to do some different things to what I was expecting so while the "support" will be there, it currently doesn't work as intended though.

This has been implemented now and due to be released in 2024.5.0, apologies for the delay.

Looks good, will implement it in my scripts in a couple of hours, thanks


Fix text node when pasting images; sanitize URLs

[x] Assign an image's src as the parsed node's text content. Children must be passed to the jsx function as the third argument. Previously, they were returned as part of the attrs object.

https://user-images.githubusercontent.com/34208415/128988710-cdb7763b-40b7-40f7-abf7-a623f77b11b9.mp4

[x] Sanitize anchor's href, image's src

Resolves ENG-3787

:shipit:


API Test Harness, API Servers

This patch introduces the API test harness, enabling storage driver developers to rapidly create tests. This patch also introduces a simple API server CLI for each driver type, creating a program that does nothing more than launch an API server for that driver type and block until Ctrl-C is used.

Current coverage is 34.41%

Merging #17 into master will decrease coverage by -2.03% as of d511bc3

@@            master     #17   diff @@
======================================
  Files            7      12     +5
  Stmts          354     677   +323
  Branches        12      14     +2
  Methods          0       0
======================================
+ Hit            129     233   +104
- Partial         12      14     +2
- Missed         213     430   +217

Review entire Coverage Diff as of d511bc3

Powered by Codecov. Updated on successful CI builds.


Class based model API

This introduces a new API for defining models that allows us to construct the read only instances much faster. Without any optimization yet, our primitive benchmark shows a 2.5x speedup for this new API over the existing readonly API:
claw ~/C/mobx-quick-tree (class-models) ➜  yarn x spec/bench/cross-framework.ts
yarn run v1.22.10
$ ts-node --transpile-only spec/bench/cross-framework.ts
mobx-state-tree x 4,618 ops/sec ±12.62% (80 runs sampled)
mobx-quick-tree types.model x 98,964 ops/sec ±3.50% (91 runs sampled)
mobx-quick-tree ClassModel x 261,246 ops/sec ±0.22% (92 runs sampled)
Fastest is mobx-quick-tree ClassModel
Slowest is mobx-state-tree

Why something different
The central premise is that mobx-state-tree's API for defining models collects functions that add views and actions in such a way that each view-adder function or action-adder function has to be run once per instance. If you have a model like:
const Todo = types.model("Todo", {
  name: types.string,
  done: types.boolean
}).actions(self => {
  setDone(done: boolean) {
    self.done = done;
  }
});

each time you instantiate a Todo with Todo.create or Todo.createReadOnly, that self => ({ setDone() {} }) block has to run once to create a new set of actions which close over a new value of self. There's no magic behind the scenes that only runs that function once and re-uses the output between instances -- it's instead re-executed on instantiation every time. NIce API, terrible for performance.
How to get faster
Instead, we should leverage JavaScripts existing mechanisms for defining what is the same about a bunch of objects once instead of over and over: the prototype chain! Classes (which in JS are just sugar over prototypes) allow us to define something like the setDone function once on a prototype, and then create an instance which has that as it's prototype, and not need to re-create setDone per instance. This whole PR is about defining a class-based API that leverages this built-in performant approach in JS to power read only instances, while still allowing us to generate the observable instances we need sometimes. It's an inversion from the previous approach to MQT: before, we adapted the MST API to give us readonly instances while conforming to the existing API, but now, we define a new API with a higher performance ceiling, and adapt that API to the slower thing under the hood.
Outcome
This PR implements ... the whole thing. There's a lot, but I found the whole implementation was quite sensitive to each incoming requirement. Here's what I came up with:

MQT types.models and ClassModel()s can interoperate within the same tree at runtime and typetime
No more types.compose, only subclassing (but subclassing works)
Full support for volatiles and flow(function * (){}) actions, both of which we use in Gadget
Support for dynamically defined classes (class factories like gadgetDomainModelType)
Still built atop MST for observables -- the observables are just fully derived from the class models
Green tests in Gadget https://github.com/gadget-inc/gadget/pull/4974

Key choices I've made so far

All classes need to be registered (finalized to do all the internal work) with the @register decorator
All action prototype functions need to be decorated with the @action decorator, any volatiles with the @volatile decorator
Any undecorated function or getter becomes an automatic view.
The type of an observable instance of readonly instance is the same (same as MQT v1)

Implementation
The implementation of this is scary to be honest. types.model was clearly modelled after classes, so the grain of class definitions and MST type defintions match, but getting it to work at runtime and typetime requires lots of fancy stuff. The first tricky part is the types. I think it's key that a new, class based API for MQT is incrementally adoptable so that we can roll it out over time and build confidence, and that means that the existing types.model types and MQT class based types need to interoperate. After much fiddling, I think I accomplished this, but it was hard to get IType and IClassModelType working in harmony. See the note in IClassModelType for more info.
Also tricky is the runtime derivation of the observable class from the readonly class. The general approach is to use decorators to add metadata properties using the Reflect API. The decorators give us enough structure to hang off of, but ES2020/TS decorators have two key limitations: they can't muck with properties until they are defined, and TS decorators can't change the type. This matters most for volatiles and async actions.
Let's review the requirements:

Async actions in MST and plain old mobx are really several chunks of sync action chained together, which some kind of hook system to ensure that each sync bit is wrapped in mobx action wrapper goodness, and that inbetween while awaiting something, the wrapper isn't active. mobx/MST need this hook point to enforce actions are actually the only ones changing data.
We want to define async actions on classes

And then the limitations:

The only hook system that the mobx or MST folks have come up with that is ergonomic is having userland code build async actions using generators instead of the normal async/await. This is so they have their hook point for every yield, where they can be like "oh, a promise!" and disable the action bits for the duration of the promise, and re-active them when it resolves and they pass the value back in to the caller. Generators allow userland to intercept each call to what would be await in both node and the browser.
Inside the async action you use yield somePromise, but calling the action still returns a promise, so you still do await someNode.someAsyncAction(). This is to stay as normal as possible outside of MST action bodies and not make the whole system use generators. So, to adapt the generator into a normally typed async function, users need to wrap their generator functions in flow().
There's no way to automatically adapt an async function into a generator function for MST. If there was, MST would use it already and not require folks to write generators. This means the code on the MQT class model has to be in generator form.
TypeScript decorators can't change the type of the property they are decorating, so they can't automatically apply the flow expression to a prototype level generator function and get the type turned into a nice promise returning type. If you have a class body like this:

class Foo {

  https://github.com/flow
  *someAsyncAction() {
  }

the return type of that function is locked in as a generator, and @flow can't change it. It can do stuff to it at runtime, but it can't mutate the type time type. That means that await someFoo.someAsyncAction() won't typecheck, as TypeScript will be expecting it to return a generator regardless of what runtime trickery the decorator gets up to. Sad.
So, we need to do the adaptation of the generator function into a promise-returning function for nice caller types with some sort of expression. That's what the flow() helper from MST does.

To assign a flow(function * () {}) expression to a property on a class, it becomes an "instance property" instead of a prototype property. That is:

class Foo {

  someAsyncAction = flow(function * () {
    yield sleep(100)
  });

}

desugars into:
class Foo {

  constructor() {
    this.someAsyncAction = flow(function * () {
      yield sleep(100)
    });
  }

}

It'd be far more performant in general to have this somehow do a Foo.prototype.whatever = flow(...), but alas, thats not how ES6 expression assignments work. This is a major issue for us though, because this desugaring means that there is nothing to look at to get the flow definition at class definition time. For things defined on the prototype, we can get a handle on them easily at class definition time to send them into mobx land for making the observable instance, but, for these things which aren't set until the constructor, we can't see their value until the constructor runs! After much brain wracking I couldn't find a away around this -- I had to go with a major hack which is to actually construct an instance, let the constructor run, and then pull the resulting expression off of the constructed instance to get a handle on the flow implementation to pass into MST. Yikes.

I still feel like this should be using Reflect.getPrototypeOf(klass).constructor.name - otherwise I think all class models will have AnonymousModel for the name.


add graphcast

Insert URLs to the project here:
https://github.com/google-deepmind/graphcast
https://arxiv.org/abs/2212.12794
In one sentence, explain what the project is about:
Predicting world weather.

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

@fkromer Thank you very much for your support. A very impressive project! A perfect fit. I just moved it to the weather models, as it is mainly used for short-term but precise forecasts.


Flicker with some cards in the stack during a drag and a "move up"

There is a bug where we are incorrectly "moving up" a card that is really being dragged. That results in a flicker effect as the transform axis is modified in x and y randomly.

Haven't seen the flicker, but did fix that issue @0xsven.


fonts should be an array of objects not just and object

fonts should be an array of objects not just and object

👍


Jump in generation in Game of Life activity on Chrome

On Chrome, there is sometime some "jumps" in generation.
See for example: https://github.com/llaske/sugarizer/pull/385#issuecomment-538725198

Fixed in https://github.com/llaske/sugarizer/commit/0083e05f50cdc63b87f9bbf34231e54ea933ec0e


ansible: use hostname instead of IP for flannel config

fixes #243
Signed-off-by: Guohua Ouyang<EMAIL_ADDRESS>

I kinda hate ansible_fqdn, as it resolves to 'localhost.localdomain' in too many situations for people.
I think what I want to do to fix all of this non-sense it to make etcd stuff use ansible_default_ipv4.address most places, and set etcd listen_client and list_peer to <IP_ADDRESS>
I keep meaning to send a PR for that, I'll try to do it today and see what you think.

I kinda hate ansible_fqdn, as it resolves to 'localhost.localdomain' in too many situations for people.

This is a problem, I have to add a host entry to /etc/hosts to make it work actually.

I agree with @eparis and ansible_fqdn does not work in my environment. I will be submitting a PR to change to ansible_default_ipv4.address

closing because fqdn doesn't work either. Will look for @danehans PR to set it to IP

@eparis here is the PR to address this issue: https://github.com/kubernetes/contrib/pull/596


Update crowdin.yml

Add documentation strings
Attempt to "fix" dest parameters
Part of ongoing efforts to get crowdin working again...

@matmair ok the upload / download of translations seems to be working quite well now, and the paths match up on crowdin now.
However we still have "duplicate" translations which means that the "new" files are showing up as only having a small number of unique translations:

So I think we still need to:

Download the existing translations
Remove the old GitHub integration
Re-upload the translations against the directory structure
Re-approve all existing translations

Do you agree that this is the correct approach?


Mutliple files getting downloaded if multiple base64 images are added

I added two slides and on each slide, I added two base64 images (SVG to base64). When saving, it downloads two files.
I tried with normal png or jpeg images, it works fine.
Problem is when I tried to add images in base64 format.
Attached the fiddle for this issue:
https://jsfiddle.net/9f7kb0ze/5/
Please check and let me know if it is an issue or I am doing something wrong.
Thanks.

@gitbrent any update here?

Hi @akshaymagapu
Thanks for reporting this.
I've verified the issue has already been fixed in the upcoming 3.0 release.

@gitbrent  Thanks :)


"sabre/vobject 1.0.0 could not be found"

Hello,
When I am executing the command "Composer Update" after modifying the composer.json file, to add the line:
"require" : {
"sabre/vobject" : "~3.3"
}
I am getting the following at the moment:
"Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- The requested package sabre/vobject 1.0.0 could not be found.
Potential causes:

A typo in the package name
The package is not available in a stable-enough version according to your minimum-stability setting
see https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion for more details.

Read http://getcomposer.org/doc/articles/troubleshooting.md for further common problems."
Why on earth does it want version 1.0.0? Is this a bug?

I have no idea why ... do you have a recent composer ?

I couldn't reproduce that issue here... could you perhaps share your entire composer.json?

My composer.json is:
{
"name": "sabre/vobject",
"description" : "The VObject library for PHP allows you to easily parse and manipulate iCalendar and vCard objects",
"keywords" : [ "VObject", "iCalendar", "vCard", "jCard", "jCal" ],
"homepage" : "http://sabre.io/vobject/",
"license" : "BSD-3-Clause",
"require" : {
"php"          : ">=5.3.1",
"ext-mbstring" : "",
"sabre/vobject" : "~3.3"
},
"require-dev" : {
"phpunit/phpunit" : "",
"squizlabs/php_codesniffer": "*"
},
"authors" : [
{
"name" : "Evert Pot",
"email"<EMAIL_ADDRESS>"homepage" : "http://evertpot.com/",
"role" : "Developer"
},
{
"name" : "Dominik Tobschall",
"email"<EMAIL_ADDRESS>"homepage" : "http://tobschall.de/",
"role" : "Developer"
}
],
"support" : {
"forum" : "https://groups.google.com/group/sabredav-discuss",
"source" : "https://github.com/fruux/sabre-vobject"
},
"autoload" : {
"psr-4" : {
"Sabre\VObject\" : "lib/"
}
},
"bin" : [
"bin/vobject",
"bin/generate_vcards"
],
"extra" : {
"branch-alias" : {
"dev-master" : "3.2.x-dev"
}
},
"config" : {
"bin-dir" : "bin"
}
}
Latest composer version - I've done all the composer troubleshooting steps to check for self updates etc and all comes back as latest version :(

Ah ok... well that's broken :)
Your package requires sabre/vobject but it also identifies itself as sabre/vobject. You are not supposed to use the composer.json file that comes with sabre/vobject, but rather you should create your own composer.json.
Don't start from a sabre/vobject git clone either. To install sabre/vobject properly, start from an empty directory and simply type:
composer require sabre/vobject ~3.4

Thank you so much!!!! I've spent hours trying to get that to work! :)


where's the old repo?

https://web.archive.org/web/20201030035217/https://github.com/prism/Prism

This repo has new owners and may be the new home of the Prism Library. The Prism Library is currently trying to leave the .NET Foundation and is waiting on legal decisions from the .NET Foundation before the move is made.


TRT

HI,
there are operators such as torch.unique not supported by trt, do you have any suggestions to solve this problem?thanks

You mean the torch.unique used in Transfusion Head?

There is no torch.unique in inference time. As for the torch.unique in Backbone, you can refer DSVT's Implementation.

Thank you for your guidance。


Implement a compiler intrinsic to get the storage hash of any given struct

Right now, StorageMap and StorageVec use the compiler intrinsic __get_storage_key(). This returns a string which contains the index of the given variable when stored in a storage variable. The problem is that if you have a recursive Map or Vec, this will return the same string for all the Maps and Vecs involved, rendering it useless as a salt for more than one struct.
If the hash of the specific storage slot where the given struct is stored can be accessed with a intrinsic, then recursive maps and recursive vecs would become possible by just replacing any reference of __get_storage_key() with __get_struct_storage_hash() (name can be changed obvs)

Before changing the intrinsic, I'd like to see how it's going to be used. How would you rewrite StorageMap for example to use the new intrinsic? And how would that help us with recursive maps?

Before changing the intrinsic, I'd like to see how it's going to be used. How would you rewrite StorageMap for example to use the new intrinsic? And how would that help us with recursive maps?

pub struct StorageMap<K, V> {
}

impl<K, V> StorageMap<K, V> {
    #[storage(write)]fn insert(self, key: K, value: V) {
        let key = sha256((key, __get_struct_storage_hash()));
        store::<V>(key, value);
    }

    #[storage(read)]fn get(self, key: K) -> V {
        let key = sha256((key, __get_struct_storage_hash()));
        get::<V>(key)
    }
}

a simple replacing of __get_storage_key() with the new intrinsic would expand the functionality of StorageMap and StorageVec while retaining its current functionality
This is assuming that every storage field has a corresponding hash which would be used in the store function
It would achieve recursive maps like this
in this example storage:
storage {
    map: StorageMap<u64, StorageMap<u64, u64>>,
}

The outer StorageMap would have a corresponding storage hash x. When calling insert, it will store a new StorageMap at the hash of (u64, x). This hash of (u64, x) would be the storage hash of the inner StorageMap y. When calling insert on the new inner Map, it would calculate the hash as (u64, y) now.
Currently, since __get_storage_key() resolves to the same salt no matter how many StorageMaps/StorageVecs are present in the given storage field (through recursive Maps/Vecs) it would result in overwriting of values if the same key is used.
One flaw of this implementation (correct me if im wrong on this one) is that structs would still not allow multiple StorageMaps and StorageVecs, since the entire struct would still be stored in the same hash

Right, that makes sense to me. The intrinsic you're suggesting is a bit more complicated to implement than __get_storage_key(). The intrinsic __get_storage_key() only returns something useful if it is called inside a method of a struct that is instantiated in a storage block, which is very restrictive. Generalizing this to an intrinsic that returns the storage hash of any given variable is effectively equivalent to implementing storage references (hash are like addresses basically). We also have the problem of dealing variables that span multiple storage slots (like large structs).

Essentially the challenge is that when you write
storage {
    let vec: StorageVec<StorageVec<u64>>` = StorageVec {}
}

and then write
let inner_vec = storage.vec.get(0).unwarp(); // Assuming len >= 1
let first_elem = inner_vec.get(0).unwrap();

inner_vec is now a stack variable and we have no way of figuring out it's hash without storage references.

Just an update: before attempting to allow StorageVec<StorageVec<T>> and other similar compositions, we're going to implement https://github.com/FuelLabs/sway/issues/3043 (and https://github.com/FuelLabs/sway/issues/2585) and see where that takes us. We should be able to do all kinds of compositions at that point.


Fixed AutocompletePanel to work with wagtail 3.0, fixes #115

For one of our projects, this fixes the issue that a select-input is shown instead of the autocomplete-widget.
This does not fix the tests, which also seem to be incompatible with the new wagtail release.

This was resolved in #125 instead. (Please let me know if closing is in error)


Fix few typos in README.md

a few insignificant typo fixes in readme
I dislike this "fiXed gRamMaR" sort of PRs, and yet here I am creating one myself... the irony

Thanks, merged.


What are "off-peak hours in the VM's time zone" for AutomaticByPlatform VM Guest Patching?

Where are "off-peak hours in the VM's time zone" defined? Is it something in Azure or is it using the Active Hours defined on the server (we are using Windows Server 2019)?
We have virtual machines that are hosted in the East US region, but accessed by other time zones so something like 8 AM - 5PM in eastern time zone is not going to be sufficient.
Thank you,
Mike
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61687573-f03b-85dc-54cf-e95d95efb235
Version Independent ID: 7bfd1c0f-0ecd-44da-9724-6118b950f4ff
Content: Automatic VM Guest Patching for Windows VMs in Azure - Azure Virtual Machines
Content Source: articles/virtual-machines/windows/automatic-vm-guest-patching.md
Service: virtual-machines-windows
GitHub Login: @mayanknayar
Microsoft Alias: manayar

@mjcarrabine We are checking this and will get back to you.

@mayanknayar Can you please help clarify on the 'off-peak hours in the VM's time zone'. Thanks.

@mjcarrabine the off-peak hour period is usually a few hours before and after midnight local time, typically after 10PM local time. The exact timing is not fixed as peak regional loads and other maintenance activity can lead to different start times. The timing is common for a particular region and does not use the VM's internal active hour definition. We are working on enabling custom maintenance windows where you'll be able to define your own maintenance periods for the patching process. However, your current usage hours (8AM-5PM Eastern) are well outside the off-peak period for the East US region.

Thanks for bringing this to our attention. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.

Thank you. This is very helpful information in evaluating the feature.


Deprecate NET_SOCKETS_POSIX_NAMES option

The CONFIG_NET_SOCKETS_POSIX_NAMES option is marked as deprecated in favor of using normal POSIX socket API includes found under the include/zephyr/posix directory. If you want to use BSD socket API calls, you need to select POSIX_API and use the socket headers found in the POSIX subsystem. If you do not want to or cannot enable POSIX_API, then you must use zsock_ prefix when working with BSD socket calls.
This is initial work in order to simplify the network and Posix related config options. The use of CONFIG_NET_SOCKETS_POSIX_NAMES is currently confusing as it conflicts with CONFIG_POSIX_API.
If this PR is accepted, I will write information to migration guide about this change.

@jukkar - #69979 was merged so this could use a rebase

Thanks for the support :bowing_man:. There is still USB native_sim driver issues that needs fixing or a new driver, so at least one new version will be sent in hopefully near future.
@jfischer-no do you have time to look into the USB issue?

should this PR go through another round of reviews, s/Posix/POSIX/ would be nice (spotted in the migration guide blurb, maybe elsewhere?). Thanks!

Please add comments if you find something. I will collect them all and do an update at some point. I can do the Posix->POSIX already (but will not send a new version yet).

rebased against latest master
resolving merge conflict
updated code according to review comments

The native-posix/sim usb driver does not work and will fail the CI.

Changes:

fixed the http_get sample compilation


Generalize Transform

We want to try a wider range of transforms. The following still fails because the inverse transform is missing.
using ACEpotentials
model = acemodel(elements = [:Fe,], order = 3, totaldegree = 10,
       pair_transform = (:agnesi, 1, 4),
       pair_envelope = (:x, 0, 2),
       transform = (:agnesi, 1, 4),
       envelope = (:x, 0, 2),
       r0 = :bondlen, # default, could specify explicitly
       )

It seems this is already implemented, one just needs to use
transform = (:agnesi, 1, 4, 0.0)

this uses a normalized agnesi transform. It needs to be tested a bit.

in light of moving to the new model implementatoin I'm just going to close this. I don't think I will get back to ACE1.


Format HTML code inside php

Support to format HTML code inside php file (or let other plugin format just a selection of HTML code) would be nice

This is nothing the language server can do, it depends on https://github.com/Microsoft/vscode/issues/1751


[python] Feature request:  SparseNdArray.read_sparse_tensor_all

Request an 'all' variant of read_sparse_tensor.   Simply for convenience...

duplicate of #596


0.190.0 windows installer does not setup correctly.

With an upgrade install, the Open with Atom shell menu and apm command tool are bot not upgrade (still pointed to older version).

remove atom and setup again, the  Open with Atom shell menu and apm command tool are both gone

What version of Windows? Is there apm tool on Windows?

Windows 7 64 bit

Still not working in 0.192.0.

Closing this out since this seems like an intermittent auto-update bug that is hopefully fixed by upgrading to a newer version.
You can uninstall and reinstall to get the explorer context menus back, sorry about this.


jvm.throwCustomException`: the handler exec not found"

Issue Description
Type: bug report or feature request
Describe what happened (or what feature you want)
I am unable to create a JVM throwCustomException inside a K8s container.   Below is my command
./blade create k8s container-jvm throwCustomException --exception java.io.IOException --classname="com.ajit.shopping.productcata.resources.PResource" --methodname="geProducts" --chaosblade-deployed-path /tmp --container-names chaos-productcatalogue --namespace sre-chaos-testing --process java --labels "app=chaos-productcatalogue" --timeout 60 --kubeconfig /vagrant/k2.json --debug
and I get
{"code":56000,"success":false,"error":"jvm.throwCustomException: the handler exec not found","result":{"uid":"b8df78e2383ec027","success":false,"error":"jvm.throwCustomException: the handler exec not found","statuses":[{"id":"b8df78e2383ec027","state":"","code":56000,"error":"jvm.throwCustomException: the handler exec not found","success":false,"kind":""}]}}
Describe what you expected to happen
I was expecting the JVM customException experiment to be created inside JVMs running in the container.
I managed to do this in a VM successfully,
./blade create jvm throwCustomException --exception java.io.IOException --classname="com.ajit.shopping.productcata.resources.PResource" --methodname="getProducts" --pid 7751
but inside a K8 container, is where I fail.
How to reproduce it (as minimally and precisely as possible)

Tell us your environment
Linux containers
K8s
Anything else we need to know?

I figured out that the chaos binary was missing the k8s pluggin.    I recompiled chaosblade with k8s options and attached to the operator deployment.


[Subtask] Fix invalid-field-call Pylint rule for client-python

Describe the subtask

Currently the field function is used in several non-dataclass class, please try to read the source code and determine whether change the class to dataclass or just remove the field function.

Parent issue
#3560

@featherchen can you please leave a comment here, so that I can assign the issue to you.

@featherchen can you please leave a comment here, so that I can assign the issue to you.

Sure, Thanks for the help.


Add new maintainers

Why not delegating to others instead of abandoning the project?

It's a pity that this project is stuck.  Is there a more lively fork somewhere?


[Snyk] Security upgrade com.fasterxml.jackson.core:jackson-databind from <IP_ADDRESS> to 2.13.4

Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

688/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.9
Denial of Service (DoS) SNYK-JAVA-COMFASTERXMLJACKSONCORE-3038424
com.fasterxml.jackson.core:jackson-databind:  <IP_ADDRESS> -> 2.13.4
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


BulkDeleteAsync takes empty DateTime into account

My understanding was that the BulkDeleteAsync looked at the PrimaryKey, so I created a list with only the PK values.
However, for SQL Server, it fails when the entity contains DateTime fields which are not initialised and therefore have the min date value for .net; but this minimum is invalid for SQLServer.
Not sure how this is used; when I just initialised all DateTime fields for the entity with DateTime.Today, my records get deleted.

My understanding was that the BulkDeleteAsync looked at the PrimaryKey, so I created a list with only the PK values.

Yes, this is correct. Is that not working in your side?
Also, I need more context here. Is your PK a Date Time field?
Lastly, if you intend to use an uninitialized DateTime, can you set it to type Nullable DateTime and set it to NULL before sending?

No this is not working.
Consider following example:
public class RepLandingPageStatistic
{
		public string LandingPageStatisticId { get; set; }

		public string LandingPageId { get; set; }

		public DateTime PageView { get; set; }
}

The LandingPageStatisticId is my PK. The PageView is a mandatory field in the DB, that's why it is not a nullable field.
So bulkInsert, bulkMerge etc all works Wonderfull, but if I want to bulkDelete, and I only set the LandingPageStatisticId to a value,  the BulkDelete fails because of the PageView is set to a default which is "too low" for SQLServer.
So I now do
		public DateTime PageView { get; set; } = DateTime.Today; //needed for bulk delete

and then the BulkDelete works.

Okay, I thought you passed a list of PK (as in an Array of String) for LandingPageStatisticId. In anyway, thanks for creating this issue. We will look at this and it will be a part of the next version if it is a valid issue. Hope you are not block.

@stefandevo - the overloaded method that accepts the list of the entities is not suite for your use-case. You are correct that you need to provide values to the PageView column in order for it to be Bulk-Inserted into the pseudo-temp table, and that is on purpose for the usage of Bulk-Delete. Therefore, we instead highly recommend to you that you should use the overloaded method that accepts the array of the primary keys (IEnumerable<object> primaryKeys). This would somehow invalidate this request, as we speak. I hope you are okay with that.

Ok, just for my knowledge, if I only provide the PKs, no temp table will be created for the Delete? Because, the fact that the DateTime is a non-nullable field, the issue will stay the same. Or when providing PKs only, there is no temp table?

There is still a temporary table because of the following:

SQL Server only allows 2100 parameters, whereas you may pass more than that
It is leveraging thr BulkInsert and does the DELETE JOIN SQL to ensure that Bulk Processing is done atomic

It will not trigger a problem is because, the temporary table to be created will only contains the PK column and not all the fields. So the operation is very minimal, yet performant and efficient.

Ok thanks for this insight! Then indeed the list of PK's is better than adding the complete entity with the default values!
It might be a good idea to add to the documentation as well.
I will close it now.

Sure, we will do add this - I will create and relate it here soon.


Hard-coded bastion instance type forces HVM EC2 nodes

Because there is only one parameter to set the CoreOS AMI (--ami) for all nodes and this value is used to create the bastion instance which is hard-coded to be t2.micro, this means that the AMI must be of HVM type. By extension this means that no PV-only instance types can be used (e.g. t1.micro, m1.small and m1.medium) as the argument to --instance-size.
If this is intended I suggest that it should be documented.

Thanks for bringint this up. It's not so much that it's intended than it is that almost all the code in kaws is based on how we deploy Kubernetes clusters at InQuicker. As an open source tool, we do want parts of it to be configurable, but not at huge expense to the complexity of the tool for our purposes. Could you say some more about your use case and why you want to use PV instances?

Thanks for a useful tool,
I have no actual use case that requires PV instances – I think the HVM limitation is fine if it simplifies the tool. I was just a bit surprised when I tried creating a cluster with m1.small and noticed that it failed because the t2.micro instance (that I didn't declare) required a HVM AMI. So maybe it should be documented as a requirement in the cluster reference?

Agreed, it should be documented. Thanks!


No Block grid when using just base grid

Using Sass with this setting for XY grid:
@include foundation-xy-grid-classes(
$base-grid: true,
$margin-grid: false,
$padding-grid: false,
$block-grid: true,
$collapse: false,
$offset: false,
$vertical-grid: false
);
Block grid is set to true but its not created.

Looks like the mixin is missing an important piece,
I got it to work like this
.blockgrid-thing {
  @include xy-grid;
  @include xy-grid-layout(4, '.thing', true, $grid-margin-gutters, margin, right left top bottom);
}

Would you be able to submit a quick pr for this so we can get it into the release for 6.4.4?

@rafibomb That's a different issue I think and not the issue raised here.
@DusanMilko This is because you have set $margin-grid and $padding-grid to false.
If you look here the inclusion of the classes accepts 2 arguments - this allows only the required grid type classes to be output. The block grid relies on some styles from either margin or padding grid to work correctly.
@kball I think I'm correct on the above right? Been a while 😄
If you have any suggestions on your use case though we might be able to potentially split up the includes even further.

I think this is a legitimate bug... we have 2 explicit cases for block grid with margin & not, but conceptually, don't see any reason why we shouldn't support a block grid with neither margin nor padding.


Instruct browser to remove cookies

fix: Cookies not being removed from browser
The previous behavior of Response's unset_cookie function was just to delete the given name from the SimpleCookie object if it existed. However, this causes a problem in that the browser is not told to remove the cookie on its side, causing all future Request objects to still contain the cookie that was supposed to have been unset/removed. This change causes the Response object to actually set the expires token for the cookie that is being unset to a point in the past, causing the browser to immediately remove the now-expired cookie, which will remove the cookie from future Request objects.

@kgriffs The docstring has been expanded. Let me know if the explanation is satisfactory.

The docstring has been expanded.

Looks good, thanks!

@Freezerburn Looks good. As a final step in preparation for merging, could you please rebase on master and squash down to a single commit, formatted according to our style guide? Thanks!

@Freezerburn I think this is ready to go, but it needs to be rebased first.

Manually rebased and resubmitted as #634

[merged manually]


Cannot access offset of type string on string

I just updated the bundle from v3.3.1 to v4.0.2 on my project with composer require 'pentatrion/vite-bundle:^4.0'. But now I get the following error:

I reduced my vite config to the bare minimum:
import { defineConfig } from "vite"
import symfonyPlugin from "vite-plugin-symfony"
import react from "@vitejs/plugin-react"
import { fileURLToPath, URL } from "node:url"

export default defineConfig({
	plugins: [react(), symfonyPlugin()],
	build: {
		rollupOptions: {
			input: {
				"generation-add": "./assets/js/pages/generation/add/index.tsx",
			},
		},
	},
	server: {
		origin: "http://localhost:3000",
		port: 3000,
		host: "<IP_ADDRESS>",
	},
	resolve: {
		alias: {
			app: fileURLToPath(new URL("./assets/js", import.meta.url)),
		},
	},
})

Here is how I call the vite_entry_link_tags and vite_entry_script_tags functions (templates/base.html.twig file):
<!DOCTYPE html>

        <meta charset="UTF-8">
        <meta name="viewport" content="initial-scale=1, width=device-width" />
        {% block stylesheets %}
          {{ vite_entry_link_tags("generation-add") }}
        {% endblock %}

        {% block javascripts %}

            {{ vite_entry_script_tags("generation-add", { dependency: "react" }) }}
        {% endblock %}

        {% block body %}

{% endblock %}

I also tried v4.0.1 and v4.0.0 and still got the same issue. v3.3.1 works fine. Did I do something wrong on the upgrade process? Is there any upgrade guide?

hi @drazik, have you update the vite-plugin-symfony ? vite-bundle v4.0.x need vite-plugin-symfony v4.0.x (v4 change the entrypoints.json file)

It fixes the issue! Thanks a lot @lhapaipai :heart:


Example for lazy initialization of connectionstring does not work when using password in connectionstring

Wasted some time debugging issue where sql login failed for user when using this approach for setting connection string.
When using connection string with a password it will be correct the first time the interceptor is invoked, but the next time we open connection the connection.ConnectionString is not empty - but the password is removed due to Persist Security Info is default false.
if (string.IsNullOrEmpty(connection.ConnectionString))
{
    connection.ConnectionString = (await _connectionStringFactory.GetConnectionStringAsync(cancellationToken));
}

Lazy initialization of a connection string
For this to work with password the connection string must be set each time and probably use some caching or change the default...
Maybe the docs should have a note about this?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9c8aad46-30fc-c5ef-8be2-5b94a0ded8eb
Version Independent ID: 9c8aad46-30fc-c5ef-8be2-5b94a0ded8eb
Content: What's New in EF Core 7.0
Content Source: entity-framework/core/what-is-new/ef-core-7.0/whatsnew.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @ajcvickers
Microsoft Alias: avickers

@ajcvickers No, I experienced this when invoking MigrateAsync or EnsureCreatedAsync on my DbContext. The ConnectionOpeningAsync is invoked multiple times and when inspecting the connection.ConnectionString with a breakpoint the password is not present in the connection string anymore thus causing login failed.
When I added the Persist Security Info=True to the connection string the migration worked fine (or if I changed the code to always set the connection string using factory).
public override async ValueTask<InterceptionResult> ConnectionOpeningAsync(
        DbConnection connection, ConnectionEventData eventData, InterceptionResult result,
        CancellationToken cancellationToken = new())
    {
        if (string.IsNullOrEmpty(connection.ConnectionString))
        {
            connection.ConnectionString = (await _connectionStringFactory.GetConnectionStringAsync(cancellationToken));
        }

        return result;
    }

Hope this clarify the issue.


[UI] Convert Header.js to Functional Component

Original Issue: https://github.com/meshery/meshery/issues/7187
Tracking another issue for visibility: https://github.com/meshery/meshery/issues/8668

[ ] Move Header.js to its own directory
[ ] Break up Header.js and K8sContextMenu to its own exports
[ ] Remove unused file Headerstyle.js

Future items for tracking (not necessary to complete this ticket)

[ ] Identity the redux states
[ ] Identity the static styles
[ ] Identity the custom components

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hi @nebula-aac, can I take this on?
I was working on  ui/pages/index.js & ui/pages/settings.js & saw this one. I'm mostly done with the two files.
I can take this if you can assign me.

I'm working on this one, I already have this completed, just opened it for visibility and tracking

Great! Thanks for the response!

Still working on this

Let me know if you need any help

Still in progress, sorry. I was working on the design system and prettier config

@nebula-aac, hi! It's been a long time since you've been working on this issue. If you are not currently working on it, may I reassign it?

@nebula-aac are you still working on this issue ? I'm up for this  issue

@nitin-pandita you can start working on this

@nitin-pandita you can start working on this
Hi @iArchitSharma thank you for assigning this issue to me. Acutally I was just setting up the project and I was trying to run it locally and i couldn't find the package json file, there is the docker file, can you please guide be how to run the project locally. I


[Docs] Document how to start the node under macOS and Windows

Filing this issue instead of https://github.com/AleoHQ/snarkOS/issues/1361.

Closing as instructions are on README now.


Update Apache / SSH Config

Mozilla infosec noticed that the MDN Code Samples service is running a vulnerable version of Apache (2.4.6) and an SSH config that's a little outside of what our suggested configuration is.
https://www.shodan.io/host/<IP_ADDRESS>
From talking with @a2sheppy, it sounds like the instance automatically updates when it's rebooted, so it's likely that a reboot will bring Apache up to date. For the SSH config, we recommend the "Modern" configuration file specified in our suggested configuration guide.
If you need any help or assistance getting this instance cleaned up, don't hesitate to let me know and I'll make sure you get whatever resources you need!
https://github.com/mdn/samples-server
AWS Account: cloudservices-aws-dev
InstanceID: i-42a595fc

@luciusbono which service exactly are you talking about?

@chrisdavidmills wow, I actually managed to not state at any point what service I was talking about. Apologies, that was sloppy on my part. This ticket came after a looooonnnng string of asking people over and over again about the same service and I guess it broke my brain - I've updated the original ticket to include the service name, sorry for the confusion!

@luciusbono no worries, thanks for the update! I've not triaged this successfully; we'll try to get round to it before too long.


proposal: Go 2: allow goto to jump across variable declarations (in many circumstances)

Problem statement
The current rules for the goto statement state:

Executing the goto statement must not cause any variables to come into scope that were not already in scope at the point of the goto.

In short, a goto statement is not allowed to jump across variable declarations (jumping across nested scopes that declare variables is ok). The underlying reason for that rule is that such variable declarations will not be executed when the goto is taken and thus the respective variables may be in an undefined state (not initialized, not heap-allocated, etc.) at the target label.
This is unfortunate because many times when a goto is used at all, we don't actually care about the values of such variables. A perhaps typical example is the use of goto to factor out error handling to the end of a function:
func f() {
    ...
    if !cond1 {
        goto Error
    }
    if !cond2 {
        goto Error
    }
    ... code here cannot declare new variables even if they are only used locally ...
    if !cond3 {
        goto Error
    }
    ...
    return

Error:
    // handle error
}

Other common scenarios are uses of goto's for early exit where there is no error handling but some finishing up code (e.g., look for goto done, goto out, goto skipped, etc. in the std library).
If the code above needs to use a new variable in the code following the goto and before the Error label, that variable cannot conveniently be introduced close to where it is used, but instead will need to be declared before the goto. Often this also means that one cannot use a short variable declaration because the program state is not what is needs to be for an initialization expression.
In summary, using a goto sometimes requires that otherwise unaffected code will need to move variable declarations before the use of the goto since the goto would not be permitted otherwise. This is at best annoying, and at worst may lead to less readable and maintainable code due to bulk variable declarations, without initialization expressions, sometimes much before they are actually needed.
Observation
Obviously, if code accesses a variable at a target label of a goto, that variable must be declared before the goto as otherwise its value may be unknown. But the values of variables that are not accessed at the target label don't matter exactly because the code doesn't use those values.
This observation leads directly to the proposal.
Proposal
We propose to remove the goto restrictions on variable declarations in favor of a new scope rule:

A variable that would normally (without the presence of any goto) be in scope at a label declaration is not in scope if there is a goto to that label which jumps over the variable's declaration.

Examples
The code fragment:
func _() {
	goto L
	x := initexpr
	use(x)
L:
}

currently is invalid and leads to the compiler error:
x.go:4:7: goto L jumps over declaration of x at x.go:5:6

To make it valid, we would need to write something like:
func _() {
	var x T // declare x here because of goto below
	goto L
	x = initexpr
	use(x)
L:
}

With the proposed new rule, the goto error will disappear, making the original code fragment valid. On the other hand, if the code were to make use of x at the label L as well:
func _() {
	goto L
	x := initexpr
	use(x)
L:
	use(x)
}

the compiler might report instead:
x.go:4:6: undefined: x

or, better:
x.go:4:6: x not in scope (goto L jumps over declaration of x at x.go:5:6)

The error reported currently with the goto statement could be used literally as explanation in the error reporting the invalid variable access at the target label.
Implementation
The implementation is expected to be straight-forward: The new rule shifts an existing error, reported with a goto, to a specific access of the variable which caused the goto error. More detailed:
Whenever the compiler's analysis detects that a goto jumps over a variable declaration, instead of reporting that as an error, the compiler remembers that variable as inaccessible at the target label. At the target label, all such inaccessible variables are removed from scope. This will in turn make it impossible to access such a variable in the code. (A more user-friendly implementation might keep the variable in scope but upon access would also check if it was marked inaccessible. Such an approach could provide a better error message).
Summary
This proposal removes a restriction on uses of goto's in favor of a new scope rule for variables: Instead of making it invalid for a goto to jump over a variable declaration, it will become invalid to access a variable (after a label) whose declaration was jumped over. This is an improvement over the existing situation because the current rules always disallow variable declarations that are being jumped over, while the new rules only lead to an error if such variables are used at the target label, which is a less common scenario.
Because the proposal removes an existing restriction, this is a backward-compatible language change.

@griesemer Should the title say "allow goto" instead of "allow variables"?

I
Would it be valid to redeclare a variable after a goto? For example,
func _() {
	goto L
	var x int
L:
	var x int
}

That is, are the lines between goto L and L: a new scope, or some sort of pseudo-scope? In other words, is the above code equivalent to
func _() {
	goto L
	{
		var x int
	}
L:
	var x int
}

II
Does this interact with garbage collection at all? If i understand things correctly, currently the garbage collector is allowed to reclaim variables as soon as they are no longer used, regardless of whether they are officially "out of scope", so nothing would really change under this proposal. Just checking.

@griesemer Thanks for the clarification. I agree that it would be overly confusing, so I'm glad that it wouldn't be allowed.

I like this but you don't have to declare the variable before the goto if you use
func main() {
	cond1 := false
	cond2 := true
	cond3 := false

	if !cond1 {
		goto exit
	}

	if !cond2 {
		goto exit
	}

	{
		i := 5
		if i == 5 && !cond3 {
			goto exit
		}
	}

exit:
	fmt.Println("exit")
}

For all I know there is nothing to do here, but @randall77 or @aclements will be able to give the authoritative answer.

 Variables affected by this proposal must already be dead at the label, so it won't matter whether or not they're initialized in the frame.
It's possible this would have some interaction with ambiguously live variables, for example if you jump from a location before an ambiguously live variable is declared to a location where it is ambiguously live. This may require zeroing the ambiguously live slot before the jump. I suspect @randall77's stack tracing change will make this a moot point anyway.

Possible refinement: Instead of disallowing variable access after a label if a goto jumped over the variable's declaration, it may be sufficient to disallow variable "reads". (A similar refinement may apply to #26058).

Closing in favor of #26058, which is the same idea expressed in a slightly different way.  Both issues accept the same set of programs; the difference is whether the error is reported on the use of the variable or on the goto statement.  The (small) advantage of #26058 is that it does not change variable scope.  It just relaxes, slightly, the existing constraint on goto over a variable declaration.


Filtering out artifacts due to ambient light interference in sunny outdoor environments

I'm using a cheap 2D lidar with poor ambient light resistance to map an outdoor environment. This means I get small artifacts near the robots that show up in the map ie a stray set of sparse points that look like small islands with the 2d costmap enabled. I'd like to filter these points out so they don't interfere with the robot's navigation. I've thought of some ways to do this (ie by point density in moving window, or by removing points with distant nearest neighbours, testing only points within a certain radius of the robot since that's where they always show up). Where in the code is best to add this functionality?

Have you considered writing a ROS node that does the filtering a republishes the cleaned up point clouds? That's what I would do.

Yeah that's what I decided to do. Thanks!


Cubic panorama support?

Are you thinking about cubic panorama support?

I think it would be a good thing, I've just never had the need for it, that's the only reason I never worked on it.
I've never used this format and am unfamiliar with any standards, I did a quick search and found SPi-V, and Quicktime VR. I'd want to make sure I accommodate people's expectations before I implemented it.
What image standard would people like to see on this?

There are a lot of types. Single images for each side, or a CUBESTRIP with different order in row or column.
For example here is support for that in html viewer krpano: http://krpano.com/docu/xml/#image
There are 4 possible formats ant it decides which of that is that according to the dimensions. Formats are 6x1, 1x6, 2x3, 3x2 but I didn't find the order of sides.
I have one example for 1x6 strip and it is in order: LEFT, FRONT, RIGHT, BACK, UP, DOWN

But there could be a parameter for setting up an order. But maybe at the beginning your lib can support only 6x1 or 1x6 in one order and people can manage their cubic images. Or there should be an optimization in using single images for each side that sides out of range could be hidden and should free memory. But that's only my assumption.


accumulated Jenkins config changes

fixes #245 (pin 2.13.x community build to behemoth 3)
not sure what the other changes are

review by @adriaanm since the actual change I made is mixed in with other accumulated uncommitted changes


documentation updates

Overview of changes
Remove mentions of API Key in documentation
Relate Issue (if any)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #35 (6c79440) into master (11fe430) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   82.90%   82.90%
=======================================
  Files          39       39
  Lines        1275     1275
  Branches      213      213
=======================================
  Hits         1057     1057
  Misses        174      174
  Partials       44       44

Impacted Files
Coverage Δ

ochrona/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d391e...6c79440. Read the comment docs.


KYLIN-5157 Attach  username and password to README.md

Proposed changes
update document
Github Branch
As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :

The original branch kylin-on-parquet-v2 for Kylin 4.X (Parquet Storage) has been renamed to branch main, and configured as the default branch;
The original branch master for Kylin 3.X (HBase Storage) has been renamed to branch kylin3 ;

Please check Intro to Kylin 4 architecture and INFRA-22166 if you are interested.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[x] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8365e66). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1805   +/-   ##
=======================================
  Coverage        ?   24.59%
  Complexity      ?     4435
=======================================
  Files           ?     1095
  Lines           ?    61850
  Branches        ?     8865
=======================================
  Hits            ?    15212
  Misses          ?    45029
  Partials        ?     1609

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8365e66...3824200. Read the comment docs.

Thx, @zhouyao1994


Create Kyungill

@ahs2710 Both this request and #5209 have incorrect filename. It has to end with .txt.
Could you please reply this comment and tell us what is email address pattern in your university? Is it<EMAIL_ADDRESS>Please ensure you are familiar with this repository rules located at the bottom of this page and modify your requests accordingly.

@ahs2710 I am closing this request as a duplicate to #5209. Thank you for the understanding!


[Issue-question] Two consecutive empty variables break a pipeline (Strange pipeline behavior)

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
What value will a variable get in expression like this?
$var1 = if (1 -eq 2) {'value'} # $null?
$var1 -eq $null
True

Test
# implicit initialization
$var1 = if (1 -eq 2) {'value'}
$var2 = if (1 -eq 2) {'value'}
$var1,$var2 # output: none

$var1,$var2,'1111' # output: 1111
1111

$var1,$var2,'1111' | Where-Object {$_} # output: none

$var1,2222,$var2,'1111' | Where-Object {$_} # output: 2222
2222

2222,$var1,$var2,'1111' | Where-Object {$_} # output: 2222
2222

# workaround: break a "chain"
"$var1",$var2,'1111' | Where-Object {$_} # output: 1111
1111
2222,"$var1",$var2,'1111' | Where-Object {$_} # output: 2222 1111
2222
1111
"$var1",2222,$var2,'1111' | Where-Object {$_} # output: 2222 1111
2222
1111

# explicit initialization
remove-variable var1,var2
$var1 = if (1 -eq 2) {'value'} else {$null}
$var2 = if (1 -eq 2) {'value'} else {$null}
$var1,$var2,'1111' | Where-Object {$_} # output: 1111
1111
2222,$var1,$var2,'1111' | Where-Object {$_} # output: 2222 1111
2222
1111

In both cases of assignment the value is $null but a pipeline works differently.
Is it a bug or feature?
Expected behavior
$var1,$var2,'1111' | Where-Object {$_}
1111

Actual behavior
$var1,$var2,'1111' | Where-Object {$_} # output: none

Error details
none

Environment data
Name                           Value
----                           -----
PSVersion                      7.2.1
PSEdition                      Core
GitCommitId                    7.2.1
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

When a variable is created and no value is assigned, it's not technically $null here, it's the [AutomationNull]::Value. I'm not sure if this is by design or not, but it's an interesting case.
@daxian-dbw might wanna give this a look over, it's a bit of an edge case but still feasibly something folks can run into from time to time.

Interestingly, there are no issues with undefinded variables
$v11111111,$v2222222,1111 | Where-Object {$_}
1111

Yep. Confusingly, variables that don't exist create a "true" $null value, whereas initialised variables that don't have a valid value are the automationnull.
I would be inclined to say we should have the latter also be initialised to $null instead of persisting the automationnull value (which primarily exists for internal engine pipeline implementation reasons anyway). Unsure if that would be likely to break things, but it would make the experience more consistent.

It seems we already have/had an issue like that.

After additional investigation of AutomationNull  I have found the explanation of empty null
https://docs.microsoft.com/en-us/powershell/scripting/learn/deep-dives/everything-about-null?view=powershell-7.2#empty-null
Turns out this is by design but it is confusing and is breaking pipeline.

Turns out this is by design but it is confusing and is breaking pipeline.

If I remember right we already discussed this in the repo and changing this would be more breaking and confusing.

@iSazonov Can you point us to the discussion about this issue (or a similar issue)?

@iSazonov Can you point us to the discussion about this issue (or a similar issue)?

Oh, pity my AI :-)
I think that #9997 was the grandest discussion. With PowerShell Committee consideration :-)

That issue is a mite different, though related for sure.

Dup #14920


docs(react): Add example for useVisibilityEvent.

Overview

I have added an example for the missing useVisibilityEvent.
PR Checklist

[x] I read and included theses actions below

I have read the Contributing Guide
I have written documents and tests, if needed.

@HoseungJang   Can you please double-check once again?!
Thank you : )


Update create a PSI instance section

Improve how to find less  congested network (takes less time and deals only with ipv4 networks)
Update links to "Min requirement" and "Virtualized env setup" sections
Split the lines

This PR has:

[ ] Appropriate testing (molecule, python unit tests)
[ ] Appropriate documentation (README in the role, main README is up-to-date)

/approve
Looks good in the test build: https://logserver.rdoproject.org/15/215/1498a1da0bd9eb1db89a43d2c834dd2fbaa3ca82/github-check/cifmw-doc/0271e04/doc_build/html/Quickstart/03_psi.html
Internal links are working just fine with relative path.


Bingo does not provide suggestions for unimported packages

VS code. Using latest version of bingo, I found that it has stopped providing suggestions on unimported packages. No idea when this was broken.

@inliquid
Please use the enhanced version of gopls


chore: 更新README

👀 PR includes

🔧 Chore

[ ] Test case
[x] Docs / demos update
[ ] CI / workflow
[ ] Release version
[ ] Other ()

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: