Hope can custom the root #__next div

Bug report
Describe the bug
For some special layout, it would be easier if we can custom the root div:  #__next

Now when trying custom document by _document.js, we can do nothing about the <Main /> component. all the props will be ignored:

Expected behavior
I hope the Main can accept several props, at least className.

What about as simply as:
<head>
 <style>
  #__next {
     /* styles */
  }
 </style>
</head>

?

@prichodko  😄 of course we can. but I prefer assign a className to it, if it's possible...

@prichodko where should I add this css to change __next's style?
I add to __document, but it didn't change.

+1, how can we add styles to #__next?

Ended up doing this:
import Document, { Head, Main, NextScript } from 'next/document'
import { ServerStyleSheet } from 'styled-components'

export default class MyDocument extends Document {
  static getInitialProps ({ renderPage }) {
    const sheet = new ServerStyleSheet()
    const page = renderPage(App => props => sheet.collectStyles(<App {...props} />))
    const styleTags = sheet.getStyleElement()
    return { ...page, styleTags }
  }

  render () {
    return (
      <html style={{ height: '100%'}}>
        <Head>
          <title>My page</title>
          <style>{`
            #__next { height: 100% }
          `}
          </style>
          {this.props.styleTags}
        </Head>
        <body style={{ height: '100%', margin: 0}}>
          <Main />
          <NextScript />
        </body>
      </html>
    )
  }
}

We're not planning to change #__next anytime soon, as React always needs a root, so you can select this safely. There's no need to add an extra className as that makes the initial HTML document larger.


Bug when declaring dependency on specific version

I have flowing dependency
nuget MySql.Data 6.9.8
When I run paket pack I end up with following  dependency
<dependency id="MySql.Data" version="[6.9.8-prerelease,6.9.8]" />
Looks like it should not be a range dependency

Is there something missing in your report?

a h I see MySql.Data" version="[6.9.8-prerelease,6.9.8]"

what is your lockfile showing?

Marked it as code so it will be shown

Lock file showing
MySql.Data (6.9.8)

Also I see that bug not happening when I write dependency like this MySql.Data  6.9.8  framework: >= net45

mhm I can't reproduce (see e9205aa)

are you sure you don't have
nuget MySql.Data 6.9.8 prerelease
?

I tried to recreate it on new project and also failed. I try to pinpoint the issue

maybe you can modify the integration test

Very strange I have a project where it recreated consistently but when I try to create similar project it works fine. I can't pinpoint the difference.

it creates [6.9.8-prerelease,6.9.8] when it thinks prereleases are involved. so that#s the thing you need to look for.

Where it looking for prerelease ?

can you mail me the project? sforkmann @ ggmail

Sorry it a company code, thank you for the help, the issue is not serious for me because I have good workaround right now.


tray and $xxx$ scripts not displaying

I have 'tray' active in my hypr.conf and also added some scripts ($vol$ and $wifi$) to my bar settings, but both tray and script output are not displayed. %RAM% and %CPU% display OK.
Both my scripts when run in the terminal give the expected output, which is not displayed in the bar.
Bug?

show config

Bar {
33   │     height=35
34   │     monitor=0
35   │     enabled=1
36   │     mod_pad_in=12
37   │     no_tray_saving=1 # using this doesnt save the tray between reloads but fixes an issue with the bar disappearing.
38   │
39   │     font.main=Hermit
40   │     font.secondary=FontAwesome
41   │     font.size=22
42   │     col.bg=0xcc222222
43   │     col.high=0xffffa700
44   │
45   │     module=left,X,0xff8000ff,0xffffffff,1,workspaces
46   │     module=pad,left,10
47   │     module=left,X,0xffb8b8b8,0x00222222,1,tray
48   │     module=left,,0xffb8b8b8,0x00222222,1000,%WINNAME%
49   │     module=right,,0xffb8b8b8,0x00222222,1000,[ $date +%a,\ %d\ %b\ %Y\ \ %I:%M\ %p$ ]
50   │     module=pad,right,15
51   │     module=right,,0xffb8b8b8,0x00222222,1000,%CPU%
52   │     module=pad,right,15
53   │     module=right,,0xffb8b8b8,0x00222222,1000, %RAM%
54   │ #    module=right,,0xffb8b8b8,0x00222222,500, $volume$
55   │     module=right,,0xffb8b8b8,0x00222222,1000,$web$
56   │     module=right,,0xffb8b8b8,0x00222222,1000,:
57   │
58   │ }

$volume$ and $web$ are my scripts
this is better readable:
Bar config
Bar {
height=35
monitor=0
enabled=1
mod_pad_in=12
no_tray_saving=1 # using this doesnt save the tray between reloads but fixes an issue with the bar disappearing.
font.main=Hermit
font.secondary=FontAwesome
font.size=22
col.bg=0xcc222222
col.high=0xffffa700

module=left,X,0xff8000ff,0xffffffff,1,workspaces
module=pad,left,10
module=left,X,0xffb8b8b8,0x00222222,1,tray
module=left,,0xffb8b8b8,0x00222222,1000,%WINNAME%
module=right,,0xffb8b8b8,0x00222222,1000,[ $date +%a,\ %d\ %b\ %Y\ \ %I:%M\ %p$ ]
module=pad,right,15
module=right,,0xffb8b8b8,0x00222222,1000,%CPU%
module=pad,right,15
module=right,,0xffb8b8b8,0x00222222,1000, %RAM%

module=right,,0xffb8b8b8,0x00222222,500, $volume$
module=right,,0xffb8b8b8,0x00222222,1000,$web$
module=right,,0xffb8b8b8,0x00222222,1000,:

}

can you launch
web

in your terminal? That's basically what it does.
If it's a script, you should use its actual path:
~/my/path/to/web.sh

Doesn't work for me either even with an example config

    module=right,,0xffffffff,0x22ffffff,1000,$date +%a,\ %d\ %b\ %Y\ \ %I:%M\ %p$
    module=pad,right,10
    module=right,,0xffffffff,0x22ffffff,1000, %RAM%
    module=pad,right,10
    module=right,ﲯ,0xffffffff,0x22ffffff,1000, %CPU%
    module=pad,right,10
    module=right,,0xffffffff,0x22ffffff,60000, $checkupdates | wc -l$
    module=center,﯑,0xffffffff,0x22ffffff,50, %WINNAME%
    ```

have you tried restarting Hypr? there are some issues with the tray if you reload the config.

@vaxerski
Hi, I tried it, but it didn't still work.

no clue then

I reinstall the Hypr, and the tray displays correctly. The speed of drawing the tray is a little bit slow, but I know that there is no problem with the tray at least. Thank you!


[rtl] Add register stage to SPI internal loopback

Timing failures have been observed on this loopback path, it has minimal logic levels but a very long delay, possibly due to I/O timing constraints.
Adding the register stage cuts the internal path. With the register stage the internal loopback cannot run at full speed, however as this is for testing purposes only this is acceptable.
Bizarrely causes timing failures to introduce this right now, so not to be merged yet until we get on top of the timing instability.

I had the same/similar failing here just now, hence the discovery of the untethered cipo_i (PR #321) signal on that LCD-specific SPI controller; now, one would expect that it just gets tied low as an implicit net but it's also hard to ignore the fact that it's that one specific signal with the weird 25ns delay.

I still have no good explanation for why this odd path delay happens. Only the observations that I've only ever seen it on the LCD SPI, that other loads on the net may have much shorter and more reasonable paths (don't use the long winding path segment), and that it has tight hold timing due its nature as a shift register with minimal logic on the shift path. My best guess is that it was something to do with how the tool handled the unconnected input, but I have no solid basis beyond coincidence and lack of faith in the tool.

Worth investigating this properly (maybe with the unconnected input sorted this has gone away?) but not something we need for v1.0 now as it's not causing a critical timing issue

See https://github.com/lowRISC/sonata-system/issues/330

Fixed with https://github.com/lowRISC/sonata-system/pull/334 so register stage won't be required


Identify protocol

Resolves #1769
Resolves https://github.com/itchysats/itchysats/issues/2307
In the legacy connection we had bound compatibility to the connection status, not we use the identify protocol to ensure compatibility.
Notes:

Takers don't disconnect if the maker does not speak the protocol, but we display a warning in the UI. This is more graceful, because if e.g. contract setup is not compatible but rollover is existing positions can still roll over.
Makers currently don't care about connection information. Eventually we should change this. The maker should validate the listening protocols of the taker as well, otherwise a maker may repeatedly fail to e.g. end offers (if offers protocol is incompatible).

More generally speaking: We can invest more time into handling if the expected protocols of one side are not supported on the other side.

bors r+


bug: Inconsistent attribute value when using number pool

Component
Python SDK
Infrahub SDK version
0.14
Current Behavior
When I populate a number using a pool the object then contains a dict { "value": 1000 }
Expected Behavior
I expect the value field to contain the actual value (e.g. 1000) instead of a dict with again value key ({ "value": 1000 })
Steps to Reproduce

invoke demo.build demo.start demo.load-infra-schema demo.load-infra-data
Open a Python interpreter with SDK installed
Run the following code

from infrahub_sdk import InfrahubClient, Config
from infrahub_sdk.protocols import CoreNumberPool

class MyClassSoICanDoAsyncStuff:
    def __init__(self) -> None:
        self.client: InfrahubClient =  InfrahubClient(config=Config(api_token="06438eb2-8019-4776-878c-0941b1f1d1ec"), address="http://localhost:8000")

    async def create_number_pool(self) -> None:
        # Create number pool
        number_pool: CoreNumberPool = await self.client.create(
            kind="CoreNumberPool",
            name="My Number Pool",
            node="InfraVLAN",
            node_attribute="vlan_id",
            start_range=1000,
            end_range=1999
        )

        # Save it
        await number_pool.save()
        self.number_pool = number_pool

    async def create_vlans(self) -> None:
        # Create VLAN without pool
        vlan = await self.client.create(
            kind="InfraVLAN",
            name="my-vlan-without-pool",
            vlan_id=2000,
            description="My vlan production",
            status="active",
            role="server"
        )

        await vlan.save()

        print(f"VLAN ID = {vlan.vlan_id.value} (without pool)")

        # Create VLAN with pool
        vlan = await self.client.create(
            kind="InfraVLAN",
            name="my-vlan-with-pool",
            vlan_id=self.number_pool,
            description="My vlan production",
            status="active",
            role="server"
        )

        await vlan.save()

        print(f"VLAN ID = {vlan.vlan_id.value} (with pool)")

myclass = MyClassSoICanDoAsyncStuff()
await myclass.create_number_pool()
await myclass.create_vlans()

This yield the following results

VLAN ID = 2000 (without pool)
VLAN ID = {'value': 1000} (with pool)

Additional Information
No response

I'm unable to reproduce this issue with the SDK v1.0.1. I wonder if this has been fixed alongside another issue somehow. Can you confirm if you still observe this issue?

@gmazoyer I faced that one with SDK in v1.1.0
> pip show infrahub-sdk
Name: infrahub-sdk
Version: 1.1.0
Summary: Python Client to interact with Infrahub

So it turns out it's a difference of behaviour between the sync and async code. I was testing with the sync one, hence not seeing the same results. I'll have a deeper look into the async code to fix it.


webrtc: fix exception in browser when webrtcICEServers is empty (#1817)

this fixes a regression introduced in v0.23.0.
Fixes #1817

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@586df28). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main    #1821   +/-   ##
=======================================
  Coverage        ?   61.42%
=======================================
  Files           ?      107
  Lines           ?    10979
  Branches        ?        0
=======================================
  Hits            ?     6744
  Misses          ?     3739
  Partials        ?      496

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Terminal uses locale from geoip AFAIK.

What would you like to be added:
Terminal shouldn't guess locale. It should use an existing locale settings as is.
Why is this needed:
My mother lang is Turkish but all operations are en_EN.UTF8 in terminal.
Another language is disrupting bash behaviour. Do not switch locale.
Environment you are Lens application on:
GNU bash, version 5.0.3(1)-release (x86_64-apple-darwin18.2.0)

Kubernetes distribution: [EKS, AKS, GKE, Rancher, ...]
Docker Desktop with Kubernetes 2.2.05
Kubernetes v1.15.5

Desktop OS:
MacOS, Mojave 10.14.6, Early 2015

I'll investigate and return with solution. Do not assign anyone for a week yet!

@kunthar any update on this?

is this still a problem with Lens 4.1.4? We only set LANG if it wasn't already set. Though we do add .UTF-8 if it isn't there.


First pass at highlighting the current locale

A couple things:

Is this the best way to highlight this item? Maybe a checkmark icon to the right of the locale name would also be good.
This should probably be refactored into a macro. Note if you agree.
I also placed the text inside the label tag so it's clickable.

Here's the current appearance with this PR:

For reference Michelin ticket: https://git.dgadteamdev.com/pa/apostrophe-enhancements/issues/72

Added @boutell for thoughts on nesting the span tag and to confirm this is the correct template for this change.

I like the general direction, suggest a Unicode check mark (✔) after the label to emphasize that the green is saying "this is really done already, but you can check the box if you want to select its children."

in the wireframes we literally put a little note next to the locale from which changes were a'coming.
I'm not sure the interface needs to be super clever with double checkmarks.
What do we think of a note?

I was thinking a note. Maybe just "committed"
On Mon, Jul 31, 2017 at 10:43 AM, Stuart Romanek<EMAIL_ADDRESS>wrote:

in the wireframes we literally put a little note next to the locale from
which changes were a'coming.
I'm not sure the interface needs to be super clever with double checkmarks.
What do we think of a note?
[image: image]
https://user-images.githubusercontent.com/1889830/28783064-1cc57af8-75dd-11e7-8130-93c67d2a379f.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/punkave/apostrophe-workflow/pull/86#issuecomment-319088354,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHIUqbWTWfTg83cD_r_7ezTOV8HwO8Kks5sTegkgaJpZM4Om57s
.

Ah! Yeah I'm in favor of a note and of following the design where possible.
But length could be iffy if it's farther down in the tree, so I like the
phrasing "Committed" as Bob suggests.
On Mon, Jul 31, 2017 at 10:47 AM, Bob Clewell<EMAIL_ADDRESS>wrote:

I was thinking a note. Maybe just "committed"
On Mon, Jul 31, 2017 at 10:43 AM, Stuart Romanek<EMAIL_ADDRESS>
wrote:

in the wireframes we literally put a little note next to the locale from
which changes were a'coming.
I'm not sure the interface needs to be super clever with double
checkmarks.
What do we think of a note?
[image: image]
<https://user-images.githubusercontent.com/1889830/
28783064-1cc57af8-75dd-11e7-8130-93c67d2a379f.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/punkave/apostrophe-workflow/pull/86#
issuecomment-319088354>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHIUqbWTWfTg83cD_r_
7ezTOV8HwO8Kks5sTegkgaJpZM4Om57s>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/punkave/apostrophe-workflow/pull/86#issuecomment-319089408,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB9fTqUftyiKkDsOUfF6sRKx9HUJtD3ks5sTej_gaJpZM4Om57s
.

--
*THOMAS BOUTELL, *SUPPORT LEAD
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

@boutell & @stuartromanek an updated PR. Added the brief note. This is how it looks now...

Note style is nice. Not sure what green should indicate. Maybe just normal color bolded

Yeah. I think I agree with that.
On Mon, Jul 31, 2017 at 2:10 PM, Stuart Romanek<EMAIL_ADDRESS>wrote:

Note style is nice. Not sure what green should indicate. Maybe just normal
color bolded
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/punkave/apostrophe-workflow/pull/86#issuecomment-319150058,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHIUoFmovgKtSZS_dHjrYcMklurFP8wks5sThiBgaJpZM4Om57s
.

I agree with the bold instead of green feedback.
On Mon, Jul 31, 2017 at 2:10 PM, Stuart Romanek<EMAIL_ADDRESS>wrote:

Note style is nice. Not sure what green should indicate. Maybe just normal
color bolded
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/punkave/apostrophe-workflow/pull/86#issuecomment-319150058,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB9faDrlAsDgCIahxMWy5rHId3rbHAEks5sThiAgaJpZM4Om57s
.

--
*THOMAS BOUTELL, *SUPPORT LEAD
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

PR updated.


Flow Layout Container implementation

Support for Flow Layout Container

This PR adds support for the Flow Layout container for elements of type AdaptiveCard, Container, Column and Table Cell.
This PR introduces a feature flag resolver interface that allows the host to implement and register it, enabling control of features through ECS settings.

A new layouts property is introduced on container elements. The value is an array of Layout objects. The layout objects look like this:

The layout to apply is determined the following way:

Look for the first layout in the list whose targetWidth property matches the current host width. If one is found, apply it

Otherwise, look for a layout that doesn’t have a targetWidth defined. If one is found, apply it

Otherwise, apply a default Layout.Stack layout and ignore other layouts in the list

Spec for Layout.Flow

Sample Card:

Is there some unit test could be added for this feature? If a card with nested layout could be added to ensure is working would be great.

Is there some unit test could be added for this feature? If a card with nested layout could be added to ensure is working would be great.

The NestedFlowLayout example is already added in the samples.


I want to ask big brother how you implement the framework to press the return key twice to exit the application. All sorts of things that don't work

Version
Tell us which versions you are using:

react-native-router-flux v4.?.?
react v16.?.?
react-native v0.?.?

Expected behaviour
Actual behaviour
Steps to reproduce
For non-obvious bugs, please fork this component, modify Example project to reproduce your issue and include link here.
1.
2.
3.
Reproducible Demo

Please provide a minimized reproducible demonstration of the problem you're reporting.
Issues that come with minimal repro's are resolved much more quickly than issues where a maintainer has to reproduce themselves.

I want to ask big brother how you implement the framework to press the return key twice to exit the application. All sorts of things that don't work

这种问题 我已经解决了。目前ReactNative 开发 用的框架 都是 react-navigation 和 react-native-router-flux
所以终极解决方案 直接在原生ManActivity里重写onKeyDowm 方法 写下如下代码 就可以了。
private long firstTime = 0;
@Override
public boolean onKeyDown(int keyCode, KeyEvent event) {
    long secondTime = System.currentTimeMillis();

    if (keyCode == KeyEvent.KEYCODE_BACK) {
        if (secondTime - firstTime < 2000) {
            System.exit(0);
        } else {
            Toast.makeText(getApplicationContext(), "再按一次退出应用程序", Toast.LENGTH_SHORT).show();
            firstTime = System.currentTimeMillis();
        }

        return true;
    }

    return super.onKeyDown(keyCode, event);
}


Metadata cache invalidation issue for unpublished crate

In https://bugzilla.mozilla.org/show_bug.cgi?id=1842331 it was discovered that we cache the unpublished metadata within the crates-io cache and don't attempt to check the index daily to invalidate this cache when a new version is published. We should probably make sure to check the index more frequently and use discovering that the crate has been published to invalidate and fetch the crate's metadata from crates.io.

@mystor Is this something we should fix in a dot release?

It's probably worth fixing, yeah. We'd need to tweak how our caching works around metadata somewhat in order to get a reasonable setup here. I don't imagine it'll be that tricky to do once I can find some time to dig into the code, but I haven't had the time for it lately.


Association "HasOne" & scope

Hi,
With sequelize it's possible to use "scope" with "hasOne" relation.
For exemple for :
@Table
class WebSite extends Model<WebSite> {
    @PrimaryKey
    @AutoIncrement
    @Column(DataType.INTEGER)
    id: number;

    @HasMany(() => Page, {
    })
    Pages: Page[];

    @HasOne(() => Page, {
         scope: {
             type: "home"
         }
    })
    HomePage: Page;
}

@Table
class Page extends Model<Page> {
    @PrimaryKey
    @AutoIncrement
    @Column(DataType.INTEGER)
    id: number;

    @AllowNull(false)
    @ForeignKey(() => WebSite)
    @Column(DataType.INTEGER)
    website_id: number;

    @BelongsTo(() => WebSite, {
        onUpdate: "CASCADE",
        onDelete: "CASCADE"
    })
    WebSite: WebSite;

    @AllowNull(false)
    @Column(DataType.STRING)
    type: string;
}

it works, but it would be necessary to update AssociationOptionsHasOne interface to avoid a typescript error :
interface AssociationOptionsHasOne extends AssociationOptions {
    scope?: AssociationScope; // here
    keyType?: DataTypeAbstract;
}

Thank you for reporting!

Any updates on this?

I didn't realized in the first place, but this is an issue in the sequelize typings, not in the sequelize-typescript ones. So  one need to update the sequelize typings in order to fix this.

I have created https://github.com/DefinitelyTyped/DefinitelyTyped/pull/35420 to address the typings issue in sequelize

FWIW: You could address this with declaration merging, in the interim: http://www.typescriptlang.org/docs/handbook/declaration-merging.html#module-augmentation

Perhaps #312 is a better solution for this - make the DefinitelyTyped types a peer dependency and allow the users of sequelize-typescript to handle this with declaration merging?

assuming we now need to update the typings that ship with sequelize to get this to work?

Since sequelize ships typings (where the assoication types are fixed) since version 5, this isn't an issue anymore


DBZ-341 Ignore malformed messages coming from database history

This is just first step - to log history message before an exception is thrown to enable easier diagnostics

Thanks for adding the test, @jpechane. Squashed everything into one commit, rebased and applied.


Add HOLO (HOT)

https://holochain.org/
https://coinmarketcap.com/currencies/holo/
We need help finding a vector version of their logo.

@sindresorhus hmm, not something i've used before but i'm sure there is one around!

chasing up... will keep you posted

holo-logo.zip
here it is

@sindresorhus ^^


need to upload other format config

hi, is it possible to upload any other type of config like .anom or other
thank you

No, and this is not supported anymore


Add support for deleting resources from resourceregistry

Description
Add support for deleting resources from resourceregistry by passing resourceregistryId
Additional Information
No response
Tasks
No response
Acceptance Criterias
Given the existing DeleteRules-endpoint only allowing deleting rules based on org/app (AltinnAppId).
When the rule is based on a resource from resourceregistry, there will be no org/app.
Then it should be made possible to delete rule based on resourceregistryId as well as the existing org/app functionality.

Internal implementation of revoke. Testing will be covered by separate issues for API revoke-endpoints


Chat message tips for less discoverable shortcuts?

Added one of these for switching input modes. I think I like it? Tbd.


fix: # in concatenation

Issue: https://github.com/ram02z/tree-sitter-fish/issues/8
This PR addresses unhandled cases that were not fixed by https://github.com/ram02z/tree-sitter-fish/pull/9
Examples:
word# - is now a concatenation instead of parse error
word##word - is now a concatenation instead of parse error

Thank you <3


Create Docker guide for PHP/MYSQL

Problem description

Problem location

I saw a problem at the following URL:

I couldn't find the information I wanted. I expected to find it near the following URL

Other:

Project version(s) affected

Suggestions for a fix

Hi @parthasarathysw
Can you provide the URL details?
Thank you


How to view logcat along with Scrcpy?

I want to view the logs and grep the live logs along with scrcpy, is it possible?
If yes, how?
When i try to start logcat from another terminal, the scrcpy window closes. Please help.

It's probably just that you don't use the same adb version as the one scrcpy uses (on Windows, go to the same directory as scrcpy before calling adb logcat).


Fix different grayness levels on parent and child message

Details
Fix different grayness levels on parent and child messages.
Fixed Issues
$ https://github.com/Expensify/App/issues/24263
PROPOSAL: https://github.com/Expensify/App/issues/24263#issuecomment-1669655689
Tests

Be offline.
Go to any chat.
Send a message.
"Reply in thread" on that message.
Send a reply.
Verify that there is no difference in the grayness between parent and child messages.
Be online.
Verify that there is no crash.

[x] Verify that no errors appear in the JS console

Offline tests

Same as tests
QA Steps
Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/13113013/c3ac3bcb-eab5-4283-9ddc-b26a5161a9c3

Mobile Web - Safari
https://github.com/Expensify/App/assets/13113013/ca6bdb27-c9cd-4da9-96f7-e1a0c9623393

Mobile Web - Chrome
https://github.com/Expensify/App/assets/13113013/5b70f348-b32a-49bc-a725-0a287b1bea15

Desktop
https://github.com/Expensify/App/assets/13113013/4ab6124d-b339-4ea9-a007-9d25df15cef4

iOS
https://github.com/Expensify/App/assets/13113013/2c9baff4-f16e-466a-904f-9a65dfea9f25

Android
https://github.com/Expensify/App/assets/13113013/41a0452a-eaf3-41de-b7a7-42a9229f4a84

Regression -> https://github.com/Expensify/App/issues/26204
Probably,
In the previous we were unable to reproduce the issue because parentReportAction  was not undefined back then. But due to some backend change  (probably https://github.com/Expensify/App/issues/26204#issuecomment-1697926409), the structure of reportAction was changed making parentReportAction undefined which is now fixed (https://github.com/Expensify/App/issues/26181#issuecomment-1698062362)

There is a merge freeze going on so I will hold merging this for now.

@ginsuma Can you please follow the instructions from here https://expensify.slack.com/archives/C01GTK53T8Q/p1694405959277169 i.e. update the PR with the main and re-test it? Thanks

🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.68-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Kubuntu 20.04 w v0.8.1 - Camera works sporadically

I just purchased a webcam (Logitech Brio) , and in OBS I can see things are looking quite good.. but when I come into OpenSeeFace-GD .. it seems not to quite be consistently able to trigger the camera on.. (the little light doesn't turn on for instance)
The only way I can get it to work is..
open the program
immediately go to the tracker settings
select the first camera in the list (there are 4 for some reason)
hit start tracker
that will work.. then I turn it off.. and try to re-engage it and.. nothing
python3 --version
Python 3.8.10

./OpenSeeFaceGD.x86_64
Godot Engine v3.4.3.rc.custom_build.6658f5c47 - https://godotengine.org
OpenGL ES 3.0 Renderer: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2
OpenGL ES Batching: ON

[INFO] 2022-2-21_17:56:29 Begin loading metadata
[INFO] 2022-2-21_17:56:29 Finished loading metadata
ERROR: Can't open dynamic library: addons/real-time-lip-sync-gd/libreal_time_lip_sync_gd.so. Error: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/emcp/Tools/openseeface-gd_0.8.1_linux/libreal_time_lip_sync_gd.so)
   at: open_dynamic_library (drivers/unix/os_unix.cpp:403)
ERROR: No valid library handle, can't get symbol from GDNative object
   at: get_symbol (modules/gdnative/gdnative.cpp:510)
ERROR: No nativescript_init in "res://addons/real-time-lip-sync-gd/libreal_time_lip_sync_gd.so" found
   at: init_library (modules/gdnative/nativescript/nativescript.cpp:1510)
ERROR: In Object of type 'NativeScript': Attempt to connect nonexistent signal 'lip_sync_updated' to method 'Node._on_lip_sync_updated'.
   at: connect (core/object.cpp:1462)
ERROR: In Object of type 'NativeScript': Attempt to connect nonexistent signal 'lip_sync_panicked' to method 'Node._on_lip_sync_panicked'.
   at: connect (core/object.cpp:1462)
[INFO] 2022-2-21_17:56:29 Loading metadata: metadata.xml
[INFO] 2022-2-21_17:56:29 Loading gui file: model.xml
this is a test print in Model.gd. Extend this by modifying resources/gui/Model.gd
[INFO] 2022-2-21_17:56:29 Loading gui file: tracking.xml
[INFO] 2022-2-21_17:56:29 Loading gui file: features.xml
[INFO] 2022-2-21_17:56:29 Loading gui file: presets.xml
[INFO] 2022-2-21_17:56:29 Loading gui file: app-settings.xml
[INFO] 2022-2-21_17:56:29 Begin loading config for user:///hackz0r_final_seeface.json
[INFO] 2022-2-21_17:56:29 Finished loading config
[INFO] 2022-2-21_17:56:29 Loading VRM file.
VRM: Using builtin gltf module
/home/emcp/Downloads/hackz0r_final_seeface.vrm
WARNING: Octahedral compression cannot be used to compress a zero-length vector, please use normalized normal values or disable octahedral compression
     at: norm_to_oct (servers/visual_server.cpp:341)
[INFO] 2022-2-21_17:56:29 VRM file loaded successfully.
[INFO] 2022-2-21_17:56:30 Press ESCAPE to hide the UI
ERROR: Condition "name == """ is true.
   at: set_name (scene/main/node.cpp:914)
[INFO] 2022-2-21_17:56:30 Model has ultra nested meshes: .
[INFO] 2022-2-21_17:56:30 Model has ultra nested meshes: .

EDIT: Stranger still , I reopen the app and now see no cameras at all.. and in output I can see
There was no valid input.
[INFO] 2022-2-21_17:58:19 Finished saving config
[INFO] 2022-2-21_17:58:19 Exiting. おやすみ。
ERROR: No valid library handle, can't terminate GDNative object
   at: terminate (modules/gdnative/gdnative.cpp:417)

ERROR: No valid library handle, can't terminate GDNative object
at: terminate (modules/gdnative/gdnative.cpp:417)

This line is due to #106 which is actually related to #103 , except in Rust rather than Godot.
Regarding the flaky video inputs, can you run
ls /dev | grep video

I've observed that sometimes, especially on laptops with physical webcam killswitches, the webcam device will just turn off. Even though you are using a physical webcam, you might need to unplug/plug in your webcam if nothing shows up after running the above command.

Thanks @you-win
I'm on a workstation .. one issue is perhaps I have a very very long USB cable.. maybe this is causing issues.. I tried just now to unplug and re-plug the device back into the extension USB cable.. no luck there.. when I reopen up it's a blank list

welp, I plugged it directly into the MOBO and it popped right back to life so.. it must be this super long extension cord.. thanks again


Results Per Page in the list pages is not consistent

tags and media entities list pages in dega studio has per page which is not working as expected.
Media if failing to load when per page is selected and tags still only show the default of 10 results even for a different selected count.
We need to keep the UI consistent on all the entities. Lets remove per page option on these entities to keep it simple

per page limit is set to a max of 20. If the limit exceeds the max value then the limit is set to 10


ci: merge staging to master

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

Pipeline Attempt on 594146788 for 4eb3620a357deef197ea57803312c16caa109bda
https://gitlab.com/MatrixAI/open-source/js-db/-/pipelines/594146788

Pipeline Succeeded on 594146788 for 4eb3620a357deef197ea57803312c16caa109bda
https://gitlab.com/MatrixAI/open-source/js-db/-/pipelines/594146788


Custom private repository template - authorization problem

Hi
I don't want to clone or modify AL GO actions, but I'd like to have a custom, private repository template with some additional workflows and a few additional steps added to the standard AL GO workflows. Then I want to manually update my template from the AL Go PTE template when needed and use "Update AL-Go System Files" workflow to update my repositories from there. Unfortunately it is not possible now, because CheckForUpdates action can only download from public repositories. Can you modify Actions/CheckForUpdates/CheckForUpdates.ps1 file and send GitHub token in the Authorization header when repository template zip is downloaded?
Current code:
 # Download the template repository and unpack to a temp folder
    $headers = @{
        "Accept" = "application/vnd.github.baptiste-preview+json"
    }

New code:
 # Download the template repository and unpack to a temp folder
    $headers = @{
        "Accept" = "application/vnd.github.baptiste-preview+json"
        "Authorization" = "token $token"
    }

Thank you,
Andrzej

@azwierzchowskitnp - during review I was made aware that having a private AL-Go-PTE template repo means that you will loose the connection to AL-Go.
You cannot have a private fork of AL-Go. You can have a private AL-Go-PTE repo, but you will not be able to uptake changes to AL-Go in that and thus - we will for sure break you when we make changes to actions and PTE templates.
Lets setup a meeting and discuss what exactly you want to achieve with this to see if there are better options.
Please send a meeting request (this week or next) to freddyk at microsoft dot com.
Thanks

Reopening after further discussions


Output

1.how to get the output of network in decoder, like Softmax  probability vs time stamp
2. How to get the phone level output

Look at netbin/net-output-extract.cc.
What do you mean by phone level output?

For your question 1, look at line 77 of https://github.com/srvk/eesen/blob/master/asr_egs/wsj/steps/decode_ctc.sh
If you want to save the posteriors into text format, simply:
net-output-extract --class-frame-counts=$srcdir/label.counts --apply-log=true $srcdir/final.nnet "$feats" ark,t:output.txt
For question 2, are you trying to output frame-level or utterance-level outputs?

utterance-level output.


Rounded corners for actions

How to make something like this? (photo in attach)

I've tried, but right corners could not be rounded because swipeActionsView goes outside the cell border.

How to make something like this? (photo in attach)

I've tried, but right corners could not be rounded because swipeActionsView goes outside the cell border.

Yes, I'm also wondering if the option to round the corners of swipeable actions.
Referrence screenshot is attached below

@IlyasNN were you able to achieve this?

any solution here?

any solution here?


[terra-date-picker] date format no longer accepted

Bug Report
terra-date-picker no longer sets the date with previously working value.
Description
Previously, I set the value on a DatePicker to 20190801, which would display as 08/01/2019 (in en-US) in the date picker.
With the 4.12.0 changes, it now displays as 20190801.   While this might be a necessary change, this is not passive.
Steps to Reproduce

Create a DatePicker using < 4.12.0, passing in a value YYYYMMDD.  Verify the appearance.
Upgrade to 4.12.0 without changing the code.  The date doesn't look right anymore.

Additional Context / Screenshots
Dates using < 4.12.0

Dates using 4.12.0

Possible Solution
Revert the changes to fix the minor version.  Then add the changes back in for a major version release.
Environment

Component Name and Version: terra-date-picker  4.12.0
Browser Name and Version: IE and Chrome
Node/npm Version: [e.g. Node 8/npm 5]
Webpack Version:
Operating System and version (desktop or mobile):

@ Mentions

I believe that this goes back to the discussion that this is a bug fix (meaning that this has corrected a wrong behavior that existed) and not a breaking change per se. I could be wrong, tho.
cc @benbcai @bjankord

I agree with @nramamurth 's comment above. Prior to 4.12.0, the controlled date-picker would accept ordinal dates (e.g. 01011234; 20190801) as valid values and converts it to a readable, formatted date as described on issue #800. The fix for this on PR #851 is to prevent ordinal date (as they are confusing to read) as valid values and only accepts values that must be either in the more strict YYYY-MM-DD ISO-8601 format or the locale's format (e.g. MM/DD/YYYY for U.S.) as described on the 4.12.0 release change log.
I would agree that this is technically a non-passive change but the change is to address inputs that the component considers misformed.
@BenBoersma @nramamurth @bjankord @hboege

I'm all for fixing problem code.  Its just that it broke working functionality.  If as consumers, we are in the middle of releasing our components/applications, having these changes in a minor version change means a component or application could get released broken and not know it.

I argue that the working functionality is not correct.  The control is broken as is and could get into a situation where bad dates are entered as values.  We don't want to get into the habit of making people have to major version bump in order to get fixes for defective components.


Where in the code is randomized intensities?

I couldn't find it in the code.
It seems like just setting t_0=0.5.

Hello,
The code for randomizing the intensity strength is in two parts:
https://github.com/brandontrabucco/da-fusion/blob/dbcdc9c6aeb0a25aa1cb2bdddc7104be2ee63bf4/train_classifier.py#L113-L117
This first part defines multiple augmentations with different intensities to sample from. The following second part samples one of the intensities:
https://github.com/brandontrabucco/da-fusion/blob/dbcdc9c6aeb0a25aa1cb2bdddc7104be2ee63bf4/semantic_aug/augmentations/compose.py#L49-L56
By setting multiple values for --strength when calling train_classifier.py, such as as done here:
https://github.com/brandontrabucco/da-fusion/blob/dbcdc9c6aeb0a25aa1cb2bdddc7104be2ee63bf4/scripts/stacking/launch_textual_inversion%3D1.0-0.75-0.5-0.25_coco.sh#L22-L26
the intensity will be sampled uniformly from a list given via the command line

Thanks!
I have one more question.
Can you provide instruction to obtain tokens from textual inversion for reproducing the results in figure 5? ( Or download link for learned tokens )


[FEATURE REQ] Tab completion for grofer.

Is your feature request related to a problem? Please describe.
The grofer command would be easier to use with tab completion!
Describe the solution you'd like
As we're implementing cobra to parse command line options and arguments, we could enhance it with tab auto completions as cobra supports this for major shells.

From what I read, cobra has a utility for generating a go file, which provides the executable with an option to generate an autocompletion script for various shells. Once generated, it would have to be moved to an appropriate location (on the user's fpath in Linux) for it to be used. How would we handle moving the generated completion script onto fpath?

Can I pick this up? (I kinda got confused and mixed up the issue I was working on :sweat_smile:)

@anihm136 Sure! I'll assign you to the same.


⚠ Bofrost.fr has degraded performance

In 3904912, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1402 ms

Resolved: Bofrost.fr performance has improved in 8a7b3d4.


leptos_meta components inside a  do not update the DOM

This doesn't actually appear to be the case. Here's a very simple "doesn't reproduce." This correctly sets the title and meta tag in the actual DOM (i.e., in the inspector) once the Wasm has loaded and it hydrates, although it doesn't (and can't) insert them into the initial head.
Since we were talking about this on Discord and I suggested you open this issue, I'm going to close it.
For anyone who's reading this and is curious: Using streaming SSR, we don't wait for resources to resolve before we begin streaming HTML, but send them in a separate chunk once they've resolved. This means that meta tags can't be sent in the  if they're under a <Suspense/>, because the  has already been sent. Granted that this is one of the tradeoffs between streaming and plain-async SSR rendering.
#[component]
pub fn App(cx: Scope) -> impl IntoView {
    // Provides context that manages stylesheets, titles, meta tags, etc.
    provide_meta_context(cx);

    let res = create_resource(cx, || (), |_| async move { true });

    view! {
        cx,

        <Suspense fallback=move || view! { cx,
"Fallback"
 }>
        {move || res.read().map(|val| view! { cx,

{val}

            <Title text="Welcome to Leptos"/>
            <Meta name="description" content=val.to_string()/>
        })}
        </Suspense>
    }
}


Prevent stack-use-after-scope in rendering_device_driver_metal.mm

This fixes a stack-use-after-scope error that I was getting on MacOS with sanitizers:

The problem is when it tries to get a reference from get_entry_points_and_stages().front(), but since the SmallVector that get_entry_points_and_stages() passes back  is dynamically created, it deconstructs right after front() passes back that reference, thus we keep a reference to something that is no longer in scope.

Keeping that vector in scope fixes the issue.
asan.log

cc @bruvzg

Thanks!


To put a textbox with the intent to put links to images

Instead of loading files, we could put links to save the HDD.

I am not sure I understand the requested feature. Can you either describe it in more detail or provide a mockup image of how the UI shall look like?

Put images by a link, and not by a picture INSIDE the HDD.

I see!
This feature makes sense.

Will you really make this?

Probably, one day, yes.
There is also a rather important point worth considering: this will only work for CORS-enabled images, as only their data can be processed via HTML Canvas (https://developer.mozilla.org/en-US/docs/Web/HTML/CORS_enabled_image). Do you have a particular image hosting service on your mind?

Don't know certainly. The most common are imgur and lightshot. But I was meaning direct links. Like when we click with the right mouse button on an image an choose the copy image address option, probably in Google Images.

Like when we click with the right mouse button on an image an choose the copy image address option, probably in Google Images.

Right, exactly. You cannot read image data of these images unless the server sends the proper CORS header.

There are sites too that catches the copied image and if we paste it into the site it reads it. But if this belongs to the same situation, consider using imgur.
Check: https://stackoverflow.com/questions/19823469/publicly-hosted-image-with-a-liberal-cors-policy

Imgur is the best alternative. If the user has some other hosting image server, imgur accepts pasting images without register. In other words, if you have some image hosted on http://johnwebsite.com and you need to make a primitive version of that, you only need to copy the image by clicking with the right button and pasting it into the imgur site. Then the imgur will read the image and create a link for that and the best: provide an image with CORS.

If it is possible, it could even make an imgur link automatically

Implemented :-)


Support for macOS?

It would be nice if EarlGrey also supported macOS UI testing.
Does anyone know of any blockers to adding support for macOS?

UIKit and AppKit are different frameworks, even if similar in some ways. In some cases it's easy to cover both, but I'm not sure if it's easy in the case of EarlGrey.
Aside from technical questions, there are also motivational. Google does develop iOS apps, but probably not macOS ones.


Auto restarted Jupyter kernel

Solves #1616, #1627

Auto restarted Jupyter kernel. Sometimes LLM is ignoring that.
https://github.com/OpenDevin/OpenDevin/issues/1616#issuecomment-2112150465

Context length is increased quickly due to the output of the package installation. So, changed the output of pip installs to a single line.
https://github.com/OpenDevin/OpenDevin/issues/1616#issuecomment-2106134659

Changed regex to non-greedy versions for the following LLM output

Install the module using
<execute_ipython>
%pip install matplotlib
</execute_ipython>

Then import using this ...
<execute_ipython>
import matplotlib.pyplot as plt
</execute_ipython>

Refactored execute_cli

@SmartManoj : this is ready to merge other than codecov. Could you add tests to the modified parts?

poetry commands fail with [Errno 2] No such file or directory
Similar issue: https://github.com/python-poetry/poetry/issues/6841
But without running poetry also causes this issue.
https://bugs.launchpad.net/apport/+bug/1977954

Patched apport. Still, issue is there.

I guess it suddenly doesn't find the right python.
You may want to try the suggestions in the comments to the poetry issue you linked above, to fix/clean the poetry virtual environments. Just not the one comment with rm -rf [poetry-config-variable] because that one seems to be risky! 😅

Seems poetry is not the problem. Because in the last image error occurs in os.getcwd() ;
--
In the last test, prompts are equal.
https://www.diffchecker.com/RbS3al9o/

The diffchecker link seems to show a difference with the separator. @li-boxuan may have already seen something like that happening?
I updated the branch to make sure it gets all fixes, I believe there have been changes to integration tests very recently.

Do you mind reviewing https://github.com/OpenDevin/OpenDevin/pull/1855 and merging it if you approve it?
That PR would solve the separator problem.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Engel Nyst @.>
Sent: Friday, May 17, 2024 1:59:17 PM
To: OpenDevin/OpenDevin @.>
Cc: @.*** @.>; Mention @.>
Subject: Re: [OpenDevin/OpenDevin] Auto restarted Jupyter kernel (PR #1808)
The diffchecker link seems to show a difference with the separator. @li-boxuanhttps://github.com/li-boxuan may have already seen something like that happening?
I updated the branch to make sure it gets all fixes, I believe there have been changes to integration tests very recently.
—
Reply to this email directly, view it on GitHubhttps://github.com/OpenDevin/OpenDevin/pull/1808#issuecomment-2118375956, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGENUWTUZIJWNUC5IZ5T6MDZCZVSLAVCNFSM6AAAAABHYAMXSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGM3TKOJVGY.
You are receiving this because you were mentioned.Message ID: @.***>

Note: after merging main branch, you need to revert/remove previous regeneration commits and rerun the regenerate script, otherwise nothing happens if the test is passing.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Boxuan Li @.>
Sent: Friday, May 17, 2024 2:03:58 PM
To: OpenDevin/OpenDevin @.>
Cc: @.*** @.>; Your activity @.>
Subject: Re: [OpenDevin/OpenDevin] Auto restarted Jupyter kernel (PR #1808)
Do you mind reviewing https://github.com/OpenDevin/OpenDevin/pull/1855 and merging it if you approve it?
That PR would solve the separator problem.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Engel Nyst @.>
Sent: Friday, May 17, 2024 1:59:17 PM
To: OpenDevin/OpenDevin @.>
Cc: @.*** @.>; Mention @.>
Subject: Re: [OpenDevin/OpenDevin] Auto restarted Jupyter kernel (PR #1808)
The diffchecker link seems to show a difference with the separator. @li-boxuanhttps://github.com/li-boxuan may have already seen something like that happening?
I updated the branch to make sure it gets all fixes, I believe there have been changes to integration tests very recently.
—
Reply to this email directly, view it on GitHubhttps://github.com/OpenDevin/OpenDevin/pull/1808#issuecomment-2118375956, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGENUWTUZIJWNUC5IZ5T6MDZCZVSLAVCNFSM6AAAAABHYAMXSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGM3TKOJVGY.
You are receiving this because you were mentioned.Message ID: @.***>
—
Reply to this email directly, view it on GitHubhttps://github.com/OpenDevin/OpenDevin/pull/1808#issuecomment-2118381221, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGENUWTEY7P3GKUNFLI5Y3DZCZWD5AVCNFSM6AAAAABHYAMXSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGM4DCMRSGE.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Slider error type

Steps to reproduce
Fork the Non-linear scale demo here
hook.js:608 Warning: Failed prop type: Invalid prop `value` of type `string` supplied to `MuiSliderValueLabel`, expected `number`.

Current behavior
No response
Expected behavior
No response
Context
No response
Your environment
No response
Search keywords: Slider

I can reproduce this, the warning goes away if the custom valueLabelFormat prop is commented out

The issue was already fixed in #44131. It will be available in the upcoming release.


Remove my name from your Project

In the file https://github.com/Futuristic-Development/FutureBoard-v0.1/blob/main/themes/default/index.ejs
It has my Discord username ( MythicalKitten#0001 ) listed in the credits of the project
I am no way associated with said project and I have not touched this project (FutureBoard) at all. So I request that you remove my name from your project

@Joseph-futuristic #5
Merge the PR and remove Mythical from credits.

@Joseph-futuristic I deleted the PR so I don't become a contributor. Please kindly remove it.

Done :)


cannot open xml file on my server using url because of proxy

I have the same issue mentioned in the below thread,
https://github.com/jgraph/drawio/issues/255
it's give proxy error on my server but on https://draw.io/ it's working fine.
here is example url's,
https://draw.io/?url=http://www.xyz.com/demo.xml -> Working
https://xyz.com/?url=http://www.xyz.com/demo.xml

Note : Here xyz.com is my server and try to use xml from another server
I am using asp.net technology in IIS server,
Hot to set proxy in this, Is there any change in XML file for servlet.

Or any other way to implement proxy in this server and this will work,
I tried to directly pass the file using App.min.js and it gives proper response as accepted,
still it is showing file not found error,
Basically i want to open xml file to edit in this.

Issue resolved created a http handler code by own in asp.net to handle file url data


Added comments and examples!

Hello! I added JSDoc style comments for your functions, as well as adding an examples folder.

This is strange. Did you do this for a school class?

Yeah, one of our assignments was to find a module on npm that wasn't
commented, and add some documentation. You're welcome to use them or not,
just thought I'd show you! I like the module, clever and simple. Thanks for
inadvertently helping with my homework.
On Jan 19, 2016 11:27 PM, "Tobias Baunbæk"<EMAIL_ADDRESS>wrote:

This is strange. Did you do this for a school class?
—
Reply to this email directly or view it on GitHub
https://github.com/freeall/currency-codes/pull/6#issuecomment-173117370.


CF blocks when using docker container

CF with JS challenge blocks access when running in docker container. Same simple app has no problem when run on Windows (headless true or false)

could you share the code how are breaking it in windows?

We have released v4, which solves many bugs and adds awesome feautres like UI Run. I suggest using it and let me know if this issue reoccurs, to do so, please run the following commands:
python -m pip install bota botasaurus_api botasaurus_driver bota botasaurus-proxy-authentication botasaurus_server --upgrade

Then read the documentation at https://github.com/omkarcloud/botasaurus.


Small issues with test cases:

[ ] RMLSTC0004a does not have a reference formulation
[ ] RMLSTC0004b does not have a reference formulation
[ ] RMLSTC0004a has the wrong reference formulation (rml:referenceFormulation rml:JSONPath)

RMLSTC0004a has the wrong reference formulation (rml:referenceFormulation rml:JSONPath)

I think this has a typo, which test-case do you mean? 4a appears twice.

Yes, I meant 0004c


[BUG] Azure OpenAI > 1.0.0-beta.8 (starting from beta 9) causes JSON streaming payload issues

Describe the bug
After the change to azure-json in beta 9 there are assertions when using function calling with streaming. Everything is still working, but ofc the console errors are not OK.
Exception or Stack Trace
ChatCompletionsToolCall.java
public static ChatCompletionsToolCall fromJson(JsonReader jsonReader) throws IOException
--> throws (>20 times)
2024-07-16T12:08:10.913+02:00 ERROR 33620 --- [oundedElastic-1] c.a.c.i.MethodHandleReflectiveInvoker    : Unexpected end-of-input in field name at [Source: (byte[])"{"choices":[{"content_filter_results":{},"delta":{"tool_calls":[{"funct"; line: 1, column: 72]
2024-07-16T12:08:10.913+02:00 ERROR 33620 --- [oundedElastic-1] c.a.c.i.s.DefaultJsonSerializer          : com.azure.json.implementation.jackson.core.io.JsonEOFException: Unexpected end-of-input in field name at [Source: (byte[])"{"choices":[{"content_filter_results":{},"delta":{"tool_calls":[{"funct"; line: 1, column: 72]

To Reproduce
Steps to reproduce the behavior - Use the code snippet below from the official documentation
Code Snippet
	ChatCompletionsOptions optionsPure = new ChatCompletionsOptions(List.of(new ChatRequestUserMessage("What is " +
			"the " +
			"weather at the Tokio?")));

	var func = new FunctionDefinition("getCurrentWeather");
	func.setDescription("Get the current weather for a location");
	func.setParameters(BinaryData.fromString("""
			{"$schema":"https://json-schema.org/draft/2020-12/schema","description":"Weather API request","type":"object","properties":{"location":{"type":"string","description":"The city and state e.g. San Francisco, CA"},"unit":{"type":"string","enum":["C","F"],"description":"Temperature unit"}},"required":["location","unit"]}
			"""));

	optionsPure.setTools(List.of(
			new ChatCompletionsFunctionToolDefinition(func)));
	optionsPure.setStream(true);

	this.openAIClient.getChatCompletionsStream(options.getModel(), optionsPure)
			.forEach(chatCompletions -> {
				if (CoreUtils.isNullOrEmpty(chatCompletions.getChoices())) {
					return;
				}
				ChatResponseMessage delta = chatCompletions.getChoices().get(0).getDelta();
				if (delta.getRole() != null) {
					System.out.println("Role = " + delta.getRole());
				}
				if (delta.getContent() != null) {
					String content = delta.getContent();
					System.out.print(content);
				}
			});

Expected behavior
No error messages,,

Same issue for me as well, functions are working but just dirty error logs.
can you fix it

issue is reproducible using your own example (StreamingChatSample.java).

@alzimmermsft please follow up on this azure-json error in OpenAI

Thanks for filing this issue @timostark.
@mssfang / @jpalvarezl this appears to be a bug in OpenAIServerSentEvents and how they're being processed. I see a few possible issues here:

(Not part of this bug) There's an assumption made that the ByteBuffer will have a backing array (ByteBuffer.array()), if the ByteBuffer is native memory this will be false and will result in an exception being thrown.
(The problem) The stream of ByteBuffers emitted may not cleanly break on a server sent event. I found the cases where the exception is thrown that there is a partial server sent event trailing in the emitted data. Ex, data: {"choices":[{"content_filter_results":{"hate":{"filtered":false,"severity":"safe"},"self_harm":{"filtered":, which is invalid JSON leading to the exception being seen in this issue. We'll need richer checks to make sure that a fully-formed server sent event is being processed.
(General comment) Don't use 0xA and 0xD to perform checks. While they are correct, many people won't know what these are without researching them (new line characters), please compare against \n and \r so someone looking at this understands what's going on right away.

Forgot to add, when running the reproduction sample. While I didn't see exceptions being thrown anywhere, they are logged (as mentioned by this issue). Add an environment variable of AZURE_LOG_LEVEL=debug to see these logs happening without needing to add an SLF4J logging implementation.

Any news?

@alzimmermsft any news on this issue?

@mssfang, @jpalvarezl, could you provide @maxhov an update on where this issue currently stands

@mssfang @jpalvarezl @alzimmermsft could you indicate if this is going to be addressed anytime soon?

@maxhov Sorry for the late reply. We are going to look into it. Due to other higher priority tasks. It might be slow, but let me see if we can address it before December.

I have the same issue with the 1.0.0-beta.11 version

I'd say it's quite critical issue for users of the SDK. We use streaming via open azure SDK chat completions. That's why logs of our service are highly polluted by deserialization errors. For us it's a big issue to analyze error logs if they contain that high amount of errors


AUR Package

An AUR package for this would greatly benefit Arch users.

will be done soon

Sure would, but its still kinda not ready for shipping, but I suppose adding it to AUR would get more people interested.

I'm willing to maintain the AUR package. I think this is a good time to package it. If ready, I can start this asap.

You can do it

Great, getting started on it now. Will post a comment when finished.

@00ly ... Just checking if there's any progress on that AUR package?

Looks like the AUR package was not released and no response from @00ly.


[resotocore][feat] Improve AliasTemplate handling

Description
While experimenting with AliasTemplates I realized a couple of possible improvements:

The analytics event should show commands and aliases separately
Jq needs an option to get rid  of preprocessing
More clever templates might be required (something like: in 3 hours)
Replace parameters are case insensitive

To-Dos

[x] Add test coverage for new or updated functionality
[x] Lint and test with tox

Issues Fixed

Fixes #XXXX

Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

Codecov Report

Merging #728 (b083e13) into main (aee23b1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   89.54%   89.57%   +0.02%
==========================================
  Files          69       69
  Lines        9636     9657      +21
==========================================
+ Hits         8629     8650      +21
  Misses       1007     1007

Flag
Coverage Δ

resotocore
89.57% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

resotocore/resotocore/cli/__init__.py
93.18% <100.00%> (+0.49%)
:arrow_up:

resotocore/resotocore/cli/cli.py
94.09% <100.00%> (+0.25%)
:arrow_up:

resotocore/resotocore/cli/command.py
86.65% <100.00%> (+0.03%)
:arrow_up:

resotocore/resotocore/query/template_expander.py
94.11% <100.00%> (+0.15%)
:arrow_up:

resotocore/resotocore/task/task_handler.py
84.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee23b1...b083e13. Read the comment docs.


Position error

Hi,
I'm using RangedIK on ROS humble (which gives no erros). I'm using it with a UR5e manipulator, so I'm using your ur5 configuration.
I made a small change in the relaxed_ik_rust.py script to be able to publish Float64MultiArray.
My issue lies in the resulting pose, which has a quite large offset in the Y and Z (relative to base_link). Offset along Y is 0.04 m and the offset along Z is 0.07 m. It is very consistent, when moving the arm this stays true, also in different orientation.
Do you know where the issue might lie?

I updated the URDF to use the one published under /robot_description when using the UR ros2 driver. This solves the issue.


'Identifiable' is only available in iOS 13 or newer error

Hi, I tired to compile my Xcode project, but I shows ''Identifiable' is only available in iOS 13 or newer' error.
iOS Deployment Target on Target and Project page both set to 14.0.
I am pretty new to this. Sorry if this kind of question is not supposed to be posted here.
Appreciate your help.

@ChurikiTenna you can try https://github.com/brokenhandsio/elasticsearch-nio-client/releases/tag/0.4.3 which should fix the issue. Note that there is no CI set up for iOS and I haven't done any testing so it's all experimental at this point


[1/2] Add example of migrate data.

[x] Forked repo is synced with upstream -> github shows no code delta outside of the desired.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork
[x] Tests are passing? https://github.com/microsoft/DeepGNN/blob/main/CONTRIBUTING.md#run-tests
[x] Changelog and documentation updated.
[x] PR is labeled using the label menu on the right side.

New Behavior
Add example for what pytorch examples will look like after migrate script.

First PR does not include Ray Data, next one will


Couldn't transpile this module

This module uses ES6 code which is problematic if the target is IE11, we can transpile it, however at the end of the lib file the module is exported as modules.export instead of default export which is problematic if we transpile it with Babel.
It should be default export to be consistent with the rest of the code (ES6).

Hi.
Target of defu is not either ES6 or esm. But CJS to support node >= 8.

ES5 compatibility has been improved in v0.0.4.


Thorium crashes when creating profile

System Details

OS: Windows 11
Thorium Version M114.0.5735.134

Problem
Thorium crashes when trying to create a new profile (click + Add in screenshot), while the same action works on the latest version of Chromium
Screenshots

Similar questions
https://github.com/Alex313031/Thorium-AVX2/issues/95

Thanks @gz83, I missed that one!

@gz83 @jstdk Fixed with latest M115


feat(dialog): allow for a config object to be passed on init

Adds the ability to pass in a configuration object when creating a new MdDialogConfig. This should make working with a lot of dialog options a little easier.

Updated with your feedback @jelbourn.

Updated again.

I have following error:
Argument of type '{ disableClose: boolean; }' is not assignable to parameter of type 'MdDialogConfig'.
Object literal may only specify known properties, and 'disableClose' does not exist in type 'MdDialogConfig'.
this is using example from MdDialog readme:
this.dialogRef = this.dialog.open(PizzaDialog, {       disableClose: false     });

It works for me @Nogostradamus, can you retry checking your Material version?

Sorry, my bad. Now it works. I was still on experimental pizza v9 after an update. I had to removed caret from package.json  "@angular/material": "^2.0.0-alpha.10" in order to update successfully.


Can I use with class component?

How to use react-table with react component class?

Yes, just wrap your usage of useTable (and any other hooks) in a functional component and then reference that functional component from your class component.

I am using class-based components throughout my project. To use the react-table I did the same as suggested above. I created a function-based component using useTable hook and used the functional component in the class based component. Still I face the below problem.
Hooks can only be called inside the body of a function component. (https://fb.me/react-invalid-hook-call)

Has anyone been able to get this to work?

I'm not...

Could someone provide any example?
me also stopped on this issue
just  few lines of code there react down on hooks issue (need to provide hooksand method for state controlling to a useTable instance constructor)
        // Use the state and functions returned from useTable to build your UI
            const {
                getTableProps,
                getTableBodyProps,
                headerGroups,
                prepareRow,
                page,
                canPreviousPage,
                canNextPage,
                pageOptions,
                pageCount,
                gotoPage,
                nextPage,
                previousPage,
                setPageSize,
                state: { pageIndex, pageSize }
            } = useTable({
                columns: ...........,
                data: [],
                defaultColumn: undefined,
                getRowId<D>(originalRow: D, relativeIndex: number, parent: Row<D> | undefined): string {
                    return "";
                },
                getSubRows<D>(originalRow: D, relativeIndex: number): D[] {
                    return [];
                },
                initialState: undefined,
                stateReducer<D>(newState: TableState<D>, action: ActionType, previousState: TableState<D>, instance: TableInstance<D> | undefined): TableState<D> {
                    return undefined;
                },
                useControlledState<D>(state: TableState<D>, meta: Meta<D>): TableState<D> {
                    return undefined;
                }
            },
                useFilters,
                useGroupBy,
                useSortBy,
                useExpanded,
                usePagination,
                useRowSelect );

@tannerlinsley please reopen this issue, sure i cant find working example for classed component.

i runned with classed component, based on @ggascoigne suggestion, but this doesnt looks like tiny, better if project will be support with classed react component. i know its possible but need to write all needable methods for initiate useTables for me is difficult with time reason.


suraj: Watch deployapp.net

suraj requests the watch of the watch_keyword deployapp.net. See the Metasmoke search here

!!/approve

Technically this would be eligible for blacklisting, even, but let's hold back and see if we receive any more of these.


Githubアカウントによる同期の失敗

アカウントから通常の同期設定を行う
以降、エラーログ
[2020-08-19 13:59:20.046] [userDataSync] [info] Using settings sync service https://vscode-sync.trafficmanager.net/
[2020-08-19 13:59:20.046] [userDataSync] [info] Auto Sync is disabled.
[2020-08-19 14:00:26.639] [userDataSync] [info] Did reset the local sync state.
[2020-08-19 14:00:28.646] [userDataSync] [info] Settings: Stopped synchronizing settings.
[2020-08-19 14:00:40.681] [userDataSync] [info] Did reset the local sync state.
[2020-08-19 14:00:42.604] [userDataSync] [info] Settings: Stopped synchronizing settings.
[2020-08-19 14:06:52.781] [userDataSync] [info] Did reset the local sync state.
[2020-08-19 14:06:54.724] [userDataSync] [info] Settings: Stopped synchronizing settings.
同期の開始中にエラーが発生しました: undefined is not iterable (cannot read property Symbol(Symbol.iterator))

I am seeing this too when clicking Setting Sync: Turn On... and authenticating with GitHub.
My version info:
Version: 1.48.0
Commit: db40434f562994116e5b21c24015a2e40b2504e6
Date: 2020-08-13T08:03:27.059Z (6 days ago)
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.6.0

The log is the same as for @ssmxgo.

I got a clue from https://github.com/microsoft/vscode/issues/86062 and created an empty keybindings.json:
[]

and then the error message changed into Error while starting Sync: d is not iterable which lead me to https://github.com/microsoft/vscode/issues/103839.
There it is suggested to not sync the "Keyboard Shortcuts", which made the sync work for me.


Protocol.txt typo correction line 176

Cleaning up some copy.

Change LGTM, please squash into a single commit and I will merge.

Couldn't be rebased. Will redo.


[WIP] Adding validation method to context for version 0.1

Staging work to validate pre-flight events.
This would work to inside the codec before it starts encoding a given event, it would have a chance to call validate on the event and throw and error for the user.
Like:
err := myClient.Send(badEvent)

err here can tell the implementor what is missing in the current event and then react to it.
Signed-off-by: Scott Nichols<EMAIL_ADDRESS>

Marked Work in Progress. Will do the other 2 versions and update.

@markpeek Ready for Review. Thanks!

FYI, total code coverage is at now at 75%.


Fixed icon image issue in contact page ! #370

Hello PR,
Fixed issue number - #370
& I also made the images round like other pages.

there are some conflicts, features and teams page have been broken on homepage

there are some conflicts, features and teams page have been broken on homepage

This PR is made changes to contact page. That crash happened due to another PR ig.

@mansiruhil13 @4F24L
Review this PR !!


Access to AsyncSignal is not sound

I see that others have made related PRs and suggestions, but in my opinion these came short of fully solving the problem.
The issue is that the AsyncSignal::poll method takes &mut self, and at the same time AsyncSignal::send can be accessed with &self. In theory, this is in itself UB, though the compiler has escaped hatches for such cases (see below). I see that it has been suggested to use UnsafeCells to store members, but this is IMO not a solution: an UnsafeCell is only correct if you have several coexisting &self and one of them wants to access a member by mutable reference; it is still incorrect if one of them is an &mut self.
For instance, say that you store the waker in an UnsafeCell<Waker>. In the poll method, the compiler is now free to assume that you have mutable access to this UnsafeCell, but unfortunately this will also make it assume that it has automatically mutable access to the Waker. In fact, you will see that the method UnsafeCell::get_mut(&mut self) is a safe method for this very reason. So now the compiler is free to make optimizations based on the assumption that nobody reads or write the Waker at the same time, which of course is incorrect since send does access the waker concurrently.
One solution (or rather a temporary work-around until Rust has a real solution for that) is to wrap the state in an Aliasable and the waker in an Aliasable<UnsafeCell>. Unfortunately Aliasable does not exist yet in std but I would trust the pinned-aliasable crate due to the credentials of its author. Her repo is also a very good read to understand those kind of issues.

Thanks for your report and for sharing this helpful information, After my last commit, do you still believe that access is not sound yet?
I think AsyncSignal is sound because no concurrent mutable access is possible through the library, and mutable access is synchronized using State with atomic operations and the help of the Waker.

Let's continue that subject in #14

Fixed as discussed in #14

I thought that this one is fixed in your opinion too,send/recv is working only with MaybeUninit<T>, and read/write is synchronized with waker, which is a read-only variable after the signal is transferred to the opposite side of the interaction. there is no concurrent mutable access as far as I can tell.
If you think it's not sound, feel free to reopen the issue.

Just to be clear because I don't know if this is what the misunderstanding is about: UnsafeCell does not allow concurrent mutable access, because that is always UB. What it does is it disables some compiler optimizations and tell the compiler that even though you have only shared ownership, you will sometimes upgrade it to mutable ownership but you know what you do and will never use concurrent mutable access.
Aliasable is bit different. It says: even though it looks like I have mutable access to this, in fact there may exist several shared (non-mutable) references to this object. Likewise, it does not allow you to have UB and have concurrent mutable access. It just disables optimizations that would not be sound in such context.
So when you have mutable access to something (like the Waker in poll) but sometimes you have several shared references to it and sometimes you will actually have (unique) mutable access, you actually need both. There is an example of this in the pin-list crate
https://github.com/SabrinaJewson/pin-list.rs/blob/3591d22c9f56b23d4a94c65288c953698830f73c/src/node.rs#L175-L182)

Serge, Waker is inited access only, after share it is immutable, access to the data in the MaybeUninit<T> is synchronized with the State exactly like what mutex does, so no reader exists at the same time of writing on any fields of the AsyncSignal.
Read and writes are completely isolated, no reading is happening at the same time as write.
Please correct me if you think there is a problem that I misunderstood.

Sorry I haven't fully internalized the operation of kanal yet, but why can't this call to Waker::will_wake():
https://github.com/fereidani/kanal/blob/e415d692ef628ca8dfea10dc0bdc53c7b898b28a/src/future.rs#L210-L211
be made concurrently with this call to Waker::wake() in first.send() here:
https://github.com/fereidani/kanal/blob/e415d692ef628ca8dfea10dc0bdc53c7b898b28a/src/future.rs#L75-L77
OTOH, if that was the case this would be UB since the later is a mutable access, so I am no longer sure about anything...

The waker is cloned before calling to wake, and both wake operations are immutable access, read is not conflicting with read.

Oh yes, so that's what I wrote earlier: sometimes the waker is accessed concurrently with shared references (clone() and will_wake()), and sometimes mutably (exclusively). This would be correct if you wrapped the waker in a Aliasable<UnsafeCell<Waker>>, but now it isn't.
Sorry but I really need to return to my other things.

Hmm,
I think there is a misunderstanding by one of us here, I'm reopening the issue until we are sure there is no UB.
So I'm going to explain what I see is happening in the library:

Waker is initialized mutably at the start before being shared.
Waker is being shared using next_recv or next_send with the other thread.
After sharing both sides have access to &mut reference but will only use it as it is & reference.
as you said:

So now the compiler is free to make optimizations based on the assumption that nobody reads or write the Waker at the same time, which of course is incorrect since send does access the waker concurrently.
In my understanding, it is not causing any problems. there is no concurrent read and write on Waker. there are only concurrent reads on the waker.
Which compiler optimization could lead to a problem with concurrent reads?


core training failed with data converted from rasa-demo

Rasa version:
2.1.0
Rasa SDK version (if used & relevant):
Rasa X version (if used & relevant):
Python version:
3.7
Operating system (windows, osx, ...):
osx
Issue:
core training failed
training data is converted from project rasa-demo
Error (including full traceback):
2020-11-20 20:38:46 INFO     rasa.nlu.model  - Starting to train component DIETClassifier
/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/nlu/classifiers/diet_classifier.py:656: VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray
  model_data.add_features(key, sub_key, [np.array(_features)])
Epochs:   0%|                                                              | 0/200 [00:00<?, ?it/s]/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/utils/tensorflow/model_data.py:587: VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray
  final_data[key][sub_key].append(np.concatenate(np.array(f)))
Epochs:  75%|█████████▊   | 150/200 [28:41<13:49, 16.58s/it, t_loss=2.241, i_acc=0.989, e_f1=0.990]Epochs: 100%|█████████████| 200/200 [39:55<00:00, 11.98s/it, t_loss=2.003, i_acc=0.995, e_f1=0.993]
2020-11-20 21:18:58 INFO     rasa.utils.tensorflow.models  - Finished training.
2020-11-20 21:18:59 INFO     rasa.nlu.model  - Finished training component.
2020-11-20 21:18:59 INFO     rasa.nlu.model  - Starting to train component DucklingEntityExtractor
2020-11-20 21:18:59 INFO     rasa.nlu.model  - Finished training component.
2020-11-20 21:18:59 INFO     rasa.nlu.model  - Starting to train component EntitySynonymMapper
2020-11-20 21:18:59 INFO     rasa.nlu.model  - Finished training component.
2020-11-20 21:18:59 INFO     rasa.nlu.model  - Starting to train component ResponseSelector
Epochs: 100%|█████████████████████████| 300/300 [01:17<00:00,  3.86it/s, t_loss=1.950, r_acc=1.000]
2020-11-20 21:20:33 INFO     rasa.utils.tensorflow.models  - Finished training.
2020-11-20 21:20:33 INFO     rasa.nlu.model  - Finished training component.
2020-11-20 21:20:33 INFO     rasa.nlu.model  - Starting to train component ResponseSelector
Epochs: 100%|█████████████████████████| 300/300 [01:59<00:00,  2.50it/s, t_loss=3.030, r_acc=0.988]
2020-11-20 21:22:49 INFO     rasa.utils.tensorflow.models  - Finished training.
2020-11-20 21:22:49 INFO     rasa.nlu.model  - Finished training component.
2020-11-20 21:22:49 INFO     rasa.nlu.model  - Starting to train component ResponseSelector
Epochs: 100%|█████████████████████████| 300/300 [02:51<00:00,  1.75it/s, t_loss=2.125, r_acc=0.998]
2020-11-20 21:26:04 INFO     rasa.utils.tensorflow.models  - Finished training.
2020-11-20 21:26:04 INFO     rasa.nlu.model  - Finished training component.
2020-11-20 21:26:04 INFO     rasa.nlu.model  - Starting to train component FallbackClassifier
2020-11-20 21:26:04 INFO     rasa.nlu.model  - Finished training component.
2020-11-20 21:26:06 INFO     rasa.nlu.model  - Successfully saved model into '/var/folders/h4/l_22gmyj3vngmwgsflbqm9q80000gn/T/tmpqejmf9gn/nlu'
NLU model training completed.
Some layers from the model checkpoint at bert-base-uncased were not used when initializing TFBertModel: ['nsp___cls', 'mlm___cls']
- This IS expected if you are initializing TFBertModel from the checkpoint of a model trained on another task or with another architecture (e.g. initializing a BertForSequenceClassification model from a BertForPretraining model).
- This IS NOT expected if you are initializing TFBertModel from the checkpoint of a model that you expect to be exactly identical (initializing a BertForSequenceClassification model from a BertForSequenceClassification model).
All the layers of TFBertModel were initialized from the model checkpoint at bert-base-uncased.
If your task is similar to the task the model of the checkpoint was trained on, you can already use TFBertModel for predictions without further training.
2020-11-20 21:26:14 INFO     rasa.nlu.components  - Added 'HFTransformersNLP' to component cache. Key 'HFTransformersNLP-bert-1caf5def35c2a17b054c4bd0aff25116'.
2020-11-20 21:26:14 INFO     rasa.nlu.components  - Added 'LanguageModelFeaturizer' to component cache. Key 'LanguageModelFeaturizer-bert-99914b932bd37a50b983c5e7c90ae93b'.
Training Core model...
/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/core/policies/form_policy.py:49: FutureWarning: 'FormPolicy' is deprecated and will be removed in in the future. It is recommended to use the 'RulePolicy' instead. (will be removed in 3.0.0)
  docs=DOCS_URL_MIGRATION_GUIDE,
/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/shared/utils/io.py:93: UserWarning: It is not recommended to use the 'RulePolicy' with other policies which implement rule-like behavior. It is highly recommended to migrate all deprecated policies to use the 'RulePolicy'. Note that the 'RulePolicy' will supersede the predictions of the deprecated policies if the confidence levels of the predictions are equal.
  More info at https://rasa.com/docs/rasa/migration-guide
Processed story blocks: 100%|█████████████████████| 525/525 [00:00<00:00, 708.86it/s, # trackers=1]
Processed story blocks: 100%|█████████████████████| 525/525 [00:34<00:00, 15.41it/s, # trackers=50]
Processed story blocks: 100%|█████████████████████| 525/525 [00:35<00:00, 14.60it/s, # trackers=50]
Processed story blocks: 100%|█████████████████████| 525/525 [00:38<00:00, 13.55it/s, # trackers=50]
Processed rules: 100%|███████████████████████████████| 1/1 [00:00<00:00, 1463.98it/s, # trackers=1]
Processed trackers: 100%|███████████████████████| 939/939 [00:03<00:00, 284.10it/s, # actions=7742]
/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/utils/tensorflow/model_data_utils.py:197: VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray
  attribute_features = {MASK: [np.array(attribute_masks)]}
Traceback (most recent call last):
  File "/Users/xiaoliu/miniconda3/envs/work-env/bin/rasa", line 8, in <module>
    sys.exit(main())
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/__main__.py", line 116, in main
    cmdline_arguments.func(cmdline_arguments)
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/cli/train.py", line 90, in train
    nlu_additional_arguments=extract_nlu_additional_arguments(args),
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/train.py", line 55, in train
    loop,
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/utils/common.py", line 308, in run_in_loop
    result = loop.run_until_complete(f)
  File "uvloop/loop.pyx", line 1456, in uvloop.loop.Loop.run_until_complete
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/train.py", line 110, in train_async
    nlu_additional_arguments=nlu_additional_arguments,
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/train.py", line 207, in _train_async_internal
    old_model_zip_path=old_model,
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/train.py", line 263, in _do_training
    or _interpreter_from_previous_model(old_model_zip_path),
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/train.py", line 409, in _train_core_with_validated_data
    interpreter=interpreter,
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/core/train.py", line 67, in train
    agent.train(training_data, **additional_arguments)
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/core/agent.py", line 721, in train
    training_trackers, self.domain, interpreter=self.interpreter, **kwargs
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/core/policies/ensemble.py", line 190, in train
    trackers_to_train, domain, interpreter=interpreter, **kwargs
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/core/policies/ted_policy.py", line 366, in train
    batch_strategy=self.config[BATCH_STRATEGY],
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/utils/tensorflow/models.py", line 184, in fit
    ) = self._get_tf_train_functions(eager, model_data, batch_strategy)
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/utils/tensorflow/models.py", line 426, in _get_tf_train_functions
    train_dataset_function, self.train_on_batch, eager, "train"
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/rasa/utils/tensorflow/models.py", line 408, in _get_tf_call_model_function
    tf_call_model_function(next(iter(init_dataset)))
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 780, in __call__
    result = self._call(*args, **kwds)
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 840, in _call
    return self._stateless_fn(*args, **kwds)
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 2829, in __call__
    return graph_function._filtered_call(args, kwargs)  # pylint: disable=protected-access
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1848, in _filtered_call
    cancellation_manager=cancellation_manager)
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1924, in _call_flat
    ctx, args, cancellation_manager=cancellation_manager))
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 550, in call
    ctx=ctx)
  File "/Users/xiaoliu/miniconda3/envs/work-env/lib/python3.7/site-packages/tensorflow/python/eager/execute.py", line 60, in quick_execute
    inputs, attrs, num_outputs)
tensorflow.python.framework.errors_impl.InvalidArgumentError:  reshape cannot infer the missing input size for an empty tensor unless all specified input sizes are non-zero
	 [[node active_loop_sentence/SparseReshape (defined at /lib/python3.7/site-packages/rasa/utils/tensorflow/layers.py:132) ]] [Op:__inference_train_on_batch_433869]

Errors may have originated from an input operation.
Input Source operations connected to node active_loop_sentence/SparseReshape:
 batch_in_6 (defined at /lib/python3.7/site-packages/rasa/utils/tensorflow/models.py:408)
 SparseTensor_1/dense_shape (defined at /lib/python3.7/site-packages/rasa/utils/tensorflow/models.py:532)

Function call stack:
train_on_batch

Command or request that led to error:
rasa train

Content of configuration file (config.yml) (if relevant):
language: en
pipeline:
# - name: ConveRTTokenizer
# - name: ConveRTFeaturizer
- name: HFTransformersNLP
  # Name of the language model to use
  model_name: "bert"
  # Pre-Trained weights to be loaded
  # model_weights: "hfl/chinese-roberta-wwm-ext"
  model_weights: "bert-base-uncased"

- name: LanguageModelTokenizer
  intent_tokenization_flag: true
  intent_split_symboll: "-"
- name: LanguageModelFeaturizer
- name: RegexFeaturizer
- name: LexicalSyntacticFeaturizer
- name: CountVectorsFeaturizer
  OOV_token: oov
  token_pattern: (?u)\b\w+\b
- name: CountVectorsFeaturizer
  analyzer: char_wb
  min_ngram: 1
  max_ngram: 4
- name: DIETClassifier
  epochs: 200
  ranking_length: 5
- name: DucklingHTTPExtractor
  url: http://localhost:8000
  dimensions:
  - email
  - number
  - amount-of-money
- name: EntitySynonymMapper
- name: ResponseSelector
  retrieval_intent: out_of_scope
  scale_loss: false
- name: ResponseSelector
  retrieval_intent: faq
  scale_loss: false
- name: ResponseSelector
  retrieval_intent: chitchat
  scale_loss: false
- name: FallbackClassifier
  threshold: 0.8
  ambiguity_threshold: 0.1
policies:
- name: TEDPolicy
  max_history: 10
  epochs: 20
  batch_size:
  - 32
  - 64
- name: AugmentedMemoizationPolicy
  max_history: 6
- name: FormPolicy
- name: RulePolicy
  core_fallback_threshold: 0.3
  core_fallback_action_name: action_default_fallback

Content of domain file (domain.yml) (if relevant):
slots:
  budget:
    type: unfeaturized
    influence_conversation: false
...
responses:
  utter_already_subscribed:
...
actions:
- action_default_ask_affirmation
- action_default_fallback
- action_docs_search
- action_explain_sales_form
- action_set_faq_slot
- action_explain_faq
- action_forum_search
- action_get_community_events
- action_greet_user
- action_next_step
- action_pause
- action_set_onboarding
- action_store_bot_language
- action_store_entity_extractor
- action_store_problem_description
- action_store_unknown_nlu_part
- action_store_unknown_product
- action_tag_docs_search
- action_tag_feedback
- sales_form
- subscribe_newsletter_form
- suggestion_form
- respond_chitchat
- respond_faq
- respond_out_of_scope
version: '2.0'

Thanks for the issue, @akelad will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

Hi @XiaoLiuAI, what do you mean by training data is converted from project rasa-demo? Did you manually run the conversion commands? master of https://github.com/RasaHQ/rasa-demo is already converted to 2.0

@akelad I tried to train the model from the data from rasa-demo directly but got lots of error messages, then I converted them manually with the conversion commands. The conversion commands ignored the responses directory under data/nlu. Another possibility could be that I cloned rasa-demo too early and did not get the latest version.
By the way, could you figure out the problem from the error message? It is strange that a well formatted data(may be have some logical problem) lead to such low level error message. That means the validation of runnable data is quite difficult.

yeah i think you need to pull the latest on master, since that's already converted to 2.0.
I am unfortunately not sure where this error is coming from, does it occur every time? And did you try running rasa data validate before training?

@akelad I ran rasa data validate before converting the data. And I once succeed in running rasa training during last week, and failed (3 times) after updating rasa to the latest version in this week. Which is quite confusing.