Show joystick axis names for InputMap actions

Joystick buttons have these little helper strings in the InputMap actions,  like "XBOX A, PS X,...".
I think the same should also be done for joystick axes, as it might not be obvious for new users which index to choose.
Also related to this: why can you choose between 11 axes? I think we officially only support 7

Although, I think it's generally a bad idea to bind axes to Input actions. One should do it the proper way and check for deadzones etc.
Maybe this should be removed at some point?

it uses 0.5 as treshold so it should generally work. Tested it with a few joypads. This is used mainly for making joy axis work with UIs (move between buttons).
Regarding names, I don't really know, are the axis numbers standard? If so what are the names?

Ok, 0.5 is reasonably for UIs, didn't check that sorry :P
I would call the axis numbering standard, yes. Platforms should send gamepad events using the following indexing:
0 left stick x
1 left stick y
2 right stick x
3 right stick y
4
5
6 L2
7 R2

Of course I can say this only for the open-source code, so I don't know if there are any platforms that might use axes 4 and 5.
Also, the button variant has entries for the wii, don't know if the nunchuk stick is regarded as the left or right one, or whether the wiimote's rotation is recieved as joystick axes.

Is this how it usually works in most joypads? in all desktop platforms?
I ask out of curiosity, don't really know
On Sat, Jan 30, 2016 at 6:09 PM, Hondres<EMAIL_ADDRESS>wrote:

Ok, 0.5 is reasonably for UIs, didn't check that sorry :P
I would call the axis numbering standard, yes. Platforms should send
gamepad events using the following indexing:
0 left stick x
1 left stick y
2 right stick x
3 right stick y
4
5
6 L2
7 R2
Of course I can say this only for the open-source code, so I don't know if
there are any platforms that might use axes 4 and 5.
Also, the button variant has entries for the wii, don't know if the
nunchuk stick is regarded as the left or right one, or whether the
wiimote's rotation is recieved as joystick axes.
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3501#issuecomment-177302835.

No :p But the remapping code should recognize the device and map to this on
desktops. On consoles we can hardcode the remapping, so if we name the axes
somewhere, they'll get remapped correctly, it shouldn't be a problem.
On 30 January 2016 at 18:17, Juan Linietsky<EMAIL_ADDRESS>wrote:

Is this how it usually works in most joypads? in all desktop platforms?
I ask out of curiosity, don't really know
On Sat, Jan 30, 2016 at 6:09 PM, Hondres<EMAIL_ADDRESS>wrote:

Ok, 0.5 is reasonably for UIs, didn't check that sorry :P
I would call the axis numbering standard, yes. Platforms should send
gamepad events using the following indexing:
0 left stick x
1 left stick y
2 right stick x
3 right stick y
4
5
6 L2
7 R2
Of course I can say this only for the open-source code, so I don't know
if
there are any platforms that might use axes 4 and 5.
Also, the button variant has entries for the wii, don't know if the
nunchuk stick is regarded as the left or right one, or whether the
wiimote's rotation is recieved as joystick axes.
—
Reply to this email directly or view it on GitHub
<https://github.com/godotengine/godot/issues/3501#issuecomment-177302835
.

—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3501#issuecomment-177304495.


configobservation: do not delete non-existing secrets

This PR reduce the DELETE calls we make from config observation when syncing the named certificates. Currently this sync produces higher amount of API requests (all fail with 404):
{client="cluster-kube-apiserver-operator/v0.0.0 (linux/amd64) kubernetes/$Format",code="404",contentType="application/vnd.kubernetes.protobuf",endpoint="https",job="apiserver",namespace="default",resource="secrets",scope="namespace",service="kubernetes",verb="DELETE"}	3.6703839643850538
The logic here is to use lister and get all secrets/configs names into a string set. When syncing the resources and when we detect that target resource does not exists (is not in the set), instead of calling resource sync, which will call DELETE, we just skip it.
Fixes: 1/2 of https://bugzilla.redhat.com/show_bug.cgi?id=1694188

/cc @sanchezl
/cc @deads2k
/cc @sttts

/lgtm

/hold
logical bug

@sttts ready for next pass, now with green unit test

/hold
I was expecting a GET here https://github.com/openshift/library-go/blob/master/pkg/operator/resourcesynccontroller/resourcesync_controller.go#L152 and we assume that we use the caching getter.

Should we consider changing the ObserverFunc to return the sync rules and move the sync logic to library-go for all controllers to use?

@sttts @sanchezl with library-go change, i don't think we have to do anything here. The resource sync controller will always issue cached GET before calling delete and that will prevent the DELETE requests   on non-existing resources.

/hold cancel

/lgtm

/retest


Select2 Multiple-Select

hi,
in metro 3 select2 has data-multiple option, but its not work in metro 4.
is it change or not exist at all in version 4?

Metro4 support only css styling for third party components such as select2 and datatables


Error occurs during javascript bundle becasue of invalid package path.

Describe the bug
Error occurs during javascript bundle becasue of invalid package path.

I found out why this error occurs. The reasons are as follows:
The package folder and the file extension(js -> tsx) were changed but were not reflected in the modules import and package.json.
To Reproduce

fork dooboo-ui
clone forked repo
yarn install
yarn run ios or start
Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: macOs, Catalina

Smartphone (please complete the following information):

ios simulator IphonSE

context

I corrected path, and it works well. I would send pull request to correct it.

I miss understood, I forgot to run build. close issue


Code generation doesn't work in 1.3.0 net6

Hi there!
I'm using jetbrains rider (latest version). I have this warning on project build and codegeneration doesn't work:
Не удается загрузить сборку Analyzer C:\Users\Kir.nuget\packages\staticdictionaries\1.3.0\analyzers\dotnet\cs\StaticDictionaries.dll: Could not load file or assembly 'StaticDictionaries, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null, processorArchitecture=x86'. The given assembly name or codebase was invalid. (0x80131047)
I have AnyCpu and there are NO "prefer x32".
When downgrade to 1.2.0 all works fine

Thanks for the referral. I will try to resolve the issue as soon as possible and let you know.

Fixed in hotfix 1.3.1

Thank you very much for fast fix! Works fine for me


How can I follow up or lobby for the domain name change?

[Enter feedback here]
I've submitted the request for changing our domain name twice using this form: https://forms.office.com/pages/responsepage.aspx?id=v4j5cvGGr0GRqy180BHbR19GrHP_HjtEu3JftNLyQ9FUQzMzOEQ5VFpGSzNEWDBZRU9FQ0pIV0kzSC4u
Our company name is Tenet Partners, LLC (Partners; plural).
It's been a few weeks now, and I have not heard anything. Is there anyway to follow up or lobby for the case to change our domain from tentepartner (singular) to tenetpartners (plural)? The only reason it is not tenetpartners (plural) the way it ought to be is that back when we got our first Microsoft license for Microsoft 365 Apps for business (meaning no email service), tenetpartners.onmicrosoft.com (plural) violated your URL length requirement. So we went with tenetpartner.onmicrosoft.com (singular).
But now that we have upgraded to Microsoft 365 Business Standard, we'd like our sharepoint sites to be tenetpartners.sharepoint.com.   This is particularly important, since we are a branding company.
Can someone contact me about this?
<EMAIL_ADDRESS>(plural)
917-282-5646

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2454cb9a-dfa4-9c8a-3671-3150d49f74c7
Version Independent ID: e0a4a71a-aa4d-1066-8f76-742c3411f06c
Content: Rename your SharePoint domain - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/tenant-rename.md
Service: sharepoint-online
GitHub Login: @kaarins
Microsoft Alias: kaarins

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Automated cherry pick of #2873: fix: fail to update reserved ip notes

Cherry pick of #2873 on release/2.11.
#2873: fix: fail to update reserved ip notes

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@5293a98). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #2875   +/-   ##
==============================================
  Coverage                ?   7.16%
==============================================
  Files                   ?     472
  Lines                   ?   75035
  Branches                ?       0
==============================================
  Hits                    ?    5378
  Misses                  ?   69205
  Partials                ?     452

Flag
Coverage Δ

#aFlag
7.16% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/reservedips.go
11.68% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5293a98...fb36349. Read the comment docs.

/approve
/lgtm


Update Prompt.py

What current issue(s) does this address, or what feature is it adding?

Adds account to help
Updates help
Updates standard completions
Adds config maxpeers functionality
Updates configure function arguments to behave as intended

How did you solve this problem?
Trial and Error
How did you make sure your solution works?
Personal Testing
Are there any special changes in the code that we should be aware of?
No
Please check the following, if applicable:

[ ] Did you add any tests?
[x] Did you run make lint?
[x] Did you run make test?
[x] Are you making a PR to a feature branch or development rather than master?
[x] Did you add an entry to CHANGELOG.rst? (if not, please do)

Thanks! 👍


Caddy stripprefix fix

Changes

implemented $is_stripprefix_enabled flag functionality for Caddy proxy

Issues

fix https://github.com/coollabsio/coolify/issues/4206

Thank you for the PR 💜.


Performance RNN how to minimize note-on events with no subsequent note-off

Everything I train the performance rnn on results in a slop of notes that are all tied together.  Is this the way it's supposed to work because I thought this was only supposed to happen sometimes but everything I get out of this model is the same.  It's currently at 1600 steps and still making midi files that are only long sloppy chords.  Do I keep training it and it will go away or is this a bug?  Am I training it properly?  I made my own dataset of just Steely Dan songs.

It will never go away entirely, but 1600 steps is almost certainly not enough.  For our pretrained models (on ~1400 classical pieces) we trained for many tens of thousands of steps.
Also, when you synthesize the generated MIDI, you may want to use a synth where notes eventually decay to zero.  This doesn't actually solve the problem, but makes it less unpleasant.


Got a Element type is invalid error.

Hello! Thank you for your great project.
I try to create a terminal with the demo code posted on README.md, and I got an error with the following:

Thank you for your help.

Getting this issue too, using Create React App, using the example and nothing else (React 16.2)

Also getting this error.

Yeah same I was planning on doing a once over and working on upgrades

Will be fixed in next release

new version is out 4.0.0


Pydantic version problem and local demo problem.

I have the same problem like https://github.com/adw0rd/instagrapi/issues/1435
Just looks like:
Field required [type=missing, input_value={'id': '52761857721', 'pk': '52761857721'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.0.1/v/missing
profile_pic_url
Field required [type=missing, input_value={'id': '52761857721', 'pk': '52761857721'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.0.1/v/missing
profile_pic_url_hd
Field required [type=missing, input_value={'id': '52761857721', 'pk': '52761857721'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.0.1/v/missing
is_private
Field required [type=missing, input_value={'id': '52761857721', 'pk': '52761857721'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.0.1/v/missing
I follow the instructions that revoke the pydantic version from 2.0.x to 1.10.9, then the project can work properly.
plz insert into requirements.txt:
pydantic==1.10.9
Also, in file https://github.com/X-PLUG/mPLUG-Owl/blob/main/serve/web_server.py, in function build_demo(), chatbot, textbox and some other components are set invisible(the arg visible is set as False). Please update the code and set them True, that will help a lot(I have seen the other users had the same problem).

You can use the latest gradio, like 3.31.0.


rating "quality"

so chunks where the gps readings "skips" are properly read

ignore that guy ^
so calculate quality considering these factors:

bumps per unit length
intensity of each bump


Product scope not stated

Please add the products guidance applies to in the subheading of every article, so that it doesn't have to be deciphered from the content.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 258a0bb2-ca3a-bac6-c7d4-8cb3299523e2
Version Independent ID: ad60bb89-2832-321f-f6ba-9fe725fc79c2
Content: URLs and tokens in SharePoint
Content Source: docs/general-development/urls-and-tokens-in-sharepoint.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Thank you for your post. The documents are maintained by the community. So we can submit a pull request to make perfect


Fix Terraform required version

Updated the required version to 1.5.0 for indexing support in TF files.

To merge this, let us wait until the PRs for the 1.0.0 release are merged.


extract declaration emitter to a separate file

I've tried to keep the code intact, all changes are basically just moving functions around. Code that is shared between declaration emitter and emitter is placed in 'utilities.ts'

:+1:

:+1:

:+1:

:

Closing this PR in favor of #2417


Rename ci cd

Coverage: 100.0%. Remained the same when pulling 91faf2325d7adc6cc3baf63bf251c679ad61efe0 on rename-ci-cd into e74f71cc5919695bcabcebe612ed8324699ad0c1 on main.


How do you configure this?

Documentation is lacking in quite a few places.  I'd be happy to help / add to them in places I know about but this one I simply can not figure out!
Anyway, in my postcss.config.js I tried to follow and translate whatever it is described and it does not work.  I have about 1,000 warnings on startup printed to the logs which I do not want to see - they are all about the :root in customproperties which says I should be able to set warnings to false...nothing happens.
I read another post which apparently claims in order to give this plugin settings I need some other plugin to make this plugin work?  I don't get it... can we make this plugin work with settings so that we can configure things?
This does not work:
module.exports = {
  plugins: [
    require('postcss-import')({}),
    require('postcss-cssnext')({
      browsers: [ 'last 2 versions', '> 5%'],
      features: {
        customProperties: {
          warnings: false
        }
      }
    }),
    require('precss')({ /* ...options */ }),
  ]
}

Yeah upon reading it 2-3 more times I still don't see how the others fixed it.

warnings: false doesn't disable ALL warnings.
See https://github.com/postcss/postcss-custom-properties#warnings

For now, it only allow to disable messages about custom properties definition not scoped in a :root selector.

Warnings are here for a reason. Just fix the reason.

require('postcss-cssnext')({
            features: {
                customProperties: {
                    globalWarnings: false,
                    warnings: false,
                },
            },
        }),

works for me ;)


Rule: Fixed wrong query url in rules and alerts pages

Signed-off-by: jojohappy<EMAIL_ADDRESS>

[] CHANGELOG entry if change is relevant to the end user.

Changes

[Bugfix]: User can not click the link of expr or alert to jump to Query ui in rule pages.
Verification
Visit the rule or alert page, and try to click the link of expr or alert.

Yes! :tada:
Thank you! I always forgot to fix it but it always irritated me :smile:

Have you tested it?

Yes, it has been already run in my environment.


Add checks for RHOAIENG-15033 bug in post upgrade scenario

This change checks for the presence of bug RHOAIENG-15033 in the post upgrade scenario for Model Registry.
Since the bug has not yet been fixed, the test case will fail in 2.15 and likely in 2.16 as well

Verified in rhoai-test-flow/1069


consensus-testlib: add chain generators

These generators are the first step towards a new set of tests, that will target the upcoming Ouroboros Genesis implementation.
One of the earlier milestones, however, will be some tests that apply even before Ouroboros Genesis.
The tip of the iceberg is the Test.Ouroboros.Consensus.ChainGenerator.Tests module. You can chase dependencies from there.
This PR was migrated from https://github.com/input-output-hk/ouroboros-network/pull/4438

I pushed up several commits. Most are small. Most of them are rewordings of comments. But there is at least one big comment rewrite, on uniformTheHonestChain. cc @amesgen @facundominguez

@dnadales @jasagredo @fraser-iohk
Our Tweag team working on the Genesis Statement of Work is making two claims about this PR.

It is worthwhile.
It is completely additive: the only way it could disrupt the Consensus codebase is if the tests we're adding here end up being flaky.

Please inspect this PR enough to feel comfortable with this claims and Approve it.
If you doubt the worthwhileness, please consider Approving anyway, and we can discuss whether or not to back it out after the fact. Thank you!

I can confirm:

It is worthwhile.
It is completely additive: the only way it could disrupt the Consensus codebase is if the tests we're adding here end up being flaky.


[boost-vcpkg-helpers] Build error

Host Environment

OS: [e.g. Windows/Linux etc...]
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
./vcpkg install xxxx
Failure logs

Cut and paste the appropriate build messages from the console output.
Attach every failure log file mentioned in the console output.

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

@732175344, thanks for posting this question, can you provide your error log and steps to reproduce?

Thank you very much for your reply, I followed the steps in the official documentation, and after installing OpenCV, Ceres, SuiteSparse and LAPACK (vcpkg install opencv4 ceres ceres[suitesparse] lapack suitesparse --triplet x64-windows) I got an error in the picture

以喋以喋以喋喋
@.***

------------------ 原始邮件 ------------------
发件人: @.>;
发送时间: 2023年3月28日(星期二) 下午2:25
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [microsoft/vcpkg] [boost-vcpkg-helpers] Build error (Issue #30480)
@732175344, thanks for posting this question, can you provide your error log and steps to reproduce?
—
Reply to this email directly, view it on GitHub, or unsubscribe.

This is the code that reported the error, and I put the screenshot in the attachment：
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):
      Failed to download file with error: 1
      If you are using a proxy, please check your proxy setting. Possible causes are:
      1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
         to https://address:port. This is not correct, because https:// prefix
         claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
         , etc..) is an HTTP proxy. Try setting http://address:port to both
         HTTP_PROXY and HTTPS_PROXY instead.
      2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings
         set by your proxy software. See https://github.com/microsoft/vcpkg-tool/pull/77
         The value set by your proxy might be wrong, or have same https:// prefix issue.
      3. Your proxy's remote server is out of service.
      If you've tried directly download the link, and believe this is not a temporary
      download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
      to report this upstream download server failure.
Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:270 (z_vcpkg_download_distfile_show_proxy_and_fail)
  scripts/cmake/vcpkg_from_github.cmake:106 (vcpkg_download_distfile)
  ports/gklib/portfile.cmake:2 (vcpkg_from_github)
  scripts/ports.cmake:147 (include)
error: building gklib:x64-windows failed with: BUILD_FAILED
error: Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+gklib
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[gklib]+Build+error
Include '[gklib] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
    vcpkg-tool version: 2023-03-14-105f7f7e8a5ea10dfac9874ff9d1a6bacba5f454
    vcpkg-scripts version: unknown
以喋以喋以喋喋
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "microsoft/vcpkg"                                                                                @.>;
发送时间: 2023年3月28日(星期二) 下午4:52
@.>;
<EMAIL_ADDRESS>主题: Re: [microsoft/vcpkg] [boost-vcpkg-helpers] Build error (Issue #30480)
@732175344, I can't see your error log picture.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@732175344, I can't reproduce this issue in my side. Could you provide me which package you failed to download?

I tried to reinstall again, this time there seems to be no error, but I did not respond when executing the next code "python3 setup.py build", so I changed it to "python setup.py build", it reports the same error as directly executing the setup.py program in pycharm as shown in the attachment, have you seen this error
以喋以喋以喋喋
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "microsoft/vcpkg"                                                                                @.>;
发送时间: 2023年3月28日(星期二) 下午5:29
@.>;
<EMAIL_ADDRESS>主题: Re: [microsoft/vcpkg] [boost-vcpkg-helpers] Build error (Issue #30480)
@732175344, I can't reproduce this issue in my side. Could you provide me which package you failed to download?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@732175344, sorry, I can't see your mistake in your reply.

G:\anaconda3\envs\openmgv1\python.exe G:/Code/OpenSfM/setup.py
Configuring for python 3.8...
['cmake', '../opensfm/src', '-DPYTHON_EXECUTABLE=G:\anaconda3\envs\openmgv1\python.exe', '-DVCPKG_TARGET_TRIPLET=x64-windows', '-DCMAKE_TOOLCHAIN_FILE=../vcpkg/scripts/buildsystems/vcpkg.cmake']
Traceback (most recent call last):
  File "G:/Code/OpenSfM/setup.py", line 60, in <module>
    configure_c_extension()
  File "G:/Code/OpenSfM/setup.py", line 44, in configure_c_extension
    subprocess.check_call(cmake_command, cwd="cmake_build")
  File "G:\anaconda3\envs\openmgv1\lib\subprocess.py", line 359, in check_call
    retcode = call(*popenargs, **kwargs)
  File "G:\anaconda3\envs\openmgv1\lib\subprocess.py", line 340, in call
    with Popen(*popenargs, **kwargs) as p:
  File "G:\anaconda3\envs\openmgv1\lib\subprocess.py", line 858, in init
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "G:\anaconda3\envs\openmgv1\lib\subprocess.py", line 1311, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] 系统找不到指定的文件。
Process finished with exit code 1
以喋以喋以喋喋
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "microsoft/vcpkg"                                                                                @.>;
发送时间: 2023年3月29日(星期三) 上午9:56
@.>;
<EMAIL_ADDRESS>主题: Re: [microsoft/vcpkg] [boost-vcpkg-helpers] Build error (Issue #30480)
@732175344, sorry, I can't see your mistake in your reply.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@732175344, Have you considered @FrankXie05 's suggestion? Does this problem still exist


feat(model-client): add function to resolve a node given the node reference on BranchJS

This extension of the experimental API will be used by a customer in for a proof of concept.

:tada: This PR is included in version 5.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bridge and vault should release Ether and tokens via one transaction, not two

in LibBridgeRelease, we can rename releaseEther => recallMessage
in LibBridgeData, we can change mapping(bytes32 msgHash => bool released) etherReleased to mapping(bytes32 msgHash => uint status) recallStatus;, status == 0, means not recalled at all, status == 1 means the ETH has been released, and status ==2 means ETH and token are both released. Status can be changed from 0 to 1, or 0 to 2, or 1 to 2.
recallMessage, we release ETH, if success, status changes from 0 to 1, then TRY to release token, if succeeded, change status from 1 to 2. Otherwise, leave the status as 1. Then another call of recallMessage can still be possible if status is 1 (or 0).
recallMessage should call Vault's releaseToken method. Users can no longer call releaseToken themselves. releaseToken should have onlyFromNamed("bridge")
mapping(bytes32 msgHash => bool released) public releasedMessages; shall be removed from all vaults.

Ok


Add new rules

Go wild.

Feel free to suggest ideas @Monkey-bored

Each rule was moved to a separate issue.


cm_run_task fails in env_scripts

Describe The Bug

cm_run_task does not work in env_scripts
To Reproduce

Note: this is a toy example.
Makefile.toml:
env_scripts = [
'''
#!@duckscript
cm_run_task abc
'''
]

[tasks.abc]
script = '''
echo abc
'''

Error Stack
at 04:51:30 PM ❯ cargo make --no-workspace abc
[cargo-make] INFO - cargo make 0.37.2
[cargo-make] INFO - Calling cargo metadata to extract project info
[cargo-make] INFO - Cargo metadata done
[cargo-make] ERROR - Error while running duckscript: Source: Unknown Line: 4 - Command: cm_run_task not found.
[cargo-make] WARN - Build Failed.

env setup scripts shouldn't call tasks by design.
tasks can only be called once the flow is defined and started.


First-Class Mail fixes

Hi Alexey,
Thanks for your work on this library. It's saved me lots of time!
I have some proposed fixes for issues I discovered with First-Class Mail rates:

Change PoundsAndOunces.Ounces to a decimal. Current behavior is to round up to the nearest integer. But this causes letters that should be eligible for First-Class Mail Letter pricing (up to 3.5oz) to be priced as 4 oz letters instead.

Allow First-Class Mail International rates to be returned (both letter and large envelope). This requires 3 changes to USPSInternationalProvider:

Change the MailType to All. Current setting of Package seems to exclude "Letter" and "Large Envelope" rates.
Allow ValueOfContents to be set to 0. Insurance is apparently not available for First-Class Mail International.
Set ContentType to Documents if the package is a DocumentPackage. Per USPS, "First Class Mail International Letters and Flats content limited to documents".

Hi Chris!
Thank you for your contribution! I've published it as version 1.1.3.


chore: disable CI cache check for lean-pr-testing-NNNN branches

lgtm
maintainer merge

bors merge


Cant build [Win32]: g_crValue undeclared identifier (maybe a typo)

https://github.com/ajkhoury/ReClassEx/blob/87e1defd19514929909fcc5f7c4992644d6ac9fc/ReClass/CNodeBase.cpp#L532
CNodeBase.cpp(532): error C2065: 'g_crValue': undeclared identifier

g_clrValue is the correct name. Typo for sure
On Mon, 26 Nov. 2018, 8:09 pm Igor Kostenko<EMAIL_ADDRESS>wrote:

https://github.com/ajkhoury/ReClassEx/blob/87e1defd19514929909fcc5f7c4992644d6ac9fc/ReClass/CNodeBase.cpp#L532
CNodeBase.cpp(532): error C2065: 'g_crValue': undeclared identifier
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ajkhoury/ReClassEx/issues/45, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA8s5pYxIHqcK-XRj7WGdAkWqnFd4RGmks5uy73NgaJpZM4YytCq
.

Stick an 'l' in there and make a pull request 😃


Getting = Cannot read property 'unlockWallet' of null when trying to connect to my lnd note

Description
I have setup a btcpay server with lnd and ride the lighting.
i have funded the onchain and without establishing and funding any new channels for outbound, I am trying to connect zap.

Expected Behavior

Without performing the same workflow before, it was supposed to connect zap wallet to lnd without asking for wallet password as the video below.
https://www.youtube.com/watch?v=yBQX0CFnAh4
Actual Behavior

Zap asks for wallet password and when assigning a new password, it returns the following error : Cannot read property 'unlockWallet' of null
I see nothing related on my lnd logs
Possible Fix

Steps to Reproduce

fresh lnd node
try to connect zap

Context

Your Environment

Zap version: latest I  suppose (it asked to update its self when I install it, so it should be the latest), cant check the version somewhere, can let me know where?

Device: mac os x

LND Version: Version: 0.13.3-beta commit=basedon-v0.13.3-beta-fresh-btcpay

wrong repo, sorry


Update Help page: Add Edge as supported web browser

If yes, change the Help page wording to reflect that Edge is a supported web browser

Edge is a supported browser. Added to Help page, needs to be fixed here: 0ec66285064a8329a83503c43dab3624e205ab56.

Excuse that my automated tests are currently broken and won't deploy this change. I'll look into this sometime today.

Will the change deploy automatically once the automated tests are fixed? Feel free to go ahead and deploy this change once everything is working again.

Deployed.


Ability to start the taker without the maker daemon

The taker daemon should be more resilient upon startup. If the maker is not available it should print a message like maker currently not available, retrying connection setup in x seconds... and then retry setting up the connection.

To make this work you will need an indirection or some other mechanism to make the branch for sending and receiving messages in the select! macro pluggable / toggable. Creating another channel that serves as an indirection would probably work.

This is more of a nice to have than absolutely necessary. Removed from epic.

I believe this was done in: https://github.com/comit-network/hermes/pull/61
I'm marking it as closed, as I don't think we need more resiliency for the MVP than that.

Well, technically you still cannot start the taker without the maker. We are just delaying the start up until the maker is online.


feat: support overriding configuration with env

feat: support overriding configuration with env
FIX: #572

@ComradeProgrammer plz also do this: https://github.com/casdoor/casdoor-website/issues/143


need clarification

in this page it mentioned: "Group managed service accounts (gMSA) support when the Windows Server nodes aren't joined to an Active Directory domain is not currently available in AKS." , however it is not clear whether gMSA is possible at all since it is not mentioned anywhere if it is possible to domain join aks windows node and how?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1297e121-7cf0-63c1-99b3-87a85d80945b
Version Independent ID: 39513a07-3c13-5117-47ca-1d2298653e6b
Content: Limitations for Windows Server node pools in Azure Kubernetes Service (AKS)
Content Source: articles/aks/windows-node-limitations.md
Service: container-service
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

Hi @georgewen Thank you for your feedback! We will review and update as appropriate.

@TylerMSFT Please add your comments

I no longer work on AKS. #reassign:mlearned

@georgewen we have a doc on AKS integration with AAD
https://docs.microsoft.com/en-us/azure/aks/azure-ad-integration
Otherwise, if you need to use gMSA as mentioned in the doc you can use aks-engine
We will close this for now but if you have further questions just let us know and we can always reopen and continue the discussion.


Write tests for Recipes pages

In this milestone, I will:

Write tests using RSpec and Capybara

Hi @byiringiroscar ,
I have resolved the conflict at this  commit


Tests fail to collect with ddt=1.4.3

Information

Qiskit Terra version: any
Python version: any
Operating system: any

What is the current behavior?
The test suite may fail to collect now for all OSes on CI, due to the new ddt version 1.4.3 (released about an hour ago).  This appears related to datadriventests/ddt#92 - the signature of ddt.idata changed in a backwards-incompatible manner, and there's no way to support both signatures idata(iterable) and idata(iterable, length) cleanly.
Steps to reproduce the problem
Run the test suite with ddt=1.4.3.
What is the expected behavior?
Tests do not fail to collect.
Suggested solutions
Arguably this is a bug/mishandling of the user interface in ddt, but we can work around it by either forbidding use of ddt=1.4.3 in constraints.txt, or swapping all uses of ddt.idata(iterable) to ddt.data(*iterable).

Having looked into it a bit closer, I think this is a slight "interface bug" in ddt, and the best thing for us to do is just disallow ddt==1.4.3 in the constraints, and I'll work with the ddt team to see if we can have an interface fix merged upstream.  For now, see datadriventests/ddt#97.


slok/kube-code-generator image vendor and support multi arch images

5623a4154a71: Pull complete
Digest: sha256:bd7d8d36b381e75f2dda51dd6e0bb12db879be6168e4fe178b8c1be036d542a1
Status: Downloaded newer image for quay.io/slok/kube-code-generator:v1.25.0
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
go: downloading k8s.io/gengo v0.0.0-20211129171323-c02415ce4185

Looks like the image has been moved to ghcr and updated per https://github.com/slok/kube-code-generator/releases/tag/v0.3.2

Looks like the ghcr one is missing some multi args builds too https://github.com/slok/kube-code-generator/blob/40faacd2d6d9cc936bb8d40bdf4efe0f8f04c843/scripts/build/docker/build-publish-image-all.sh#L16


feat: add ray ids to workflows, clean up types

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#787  👈
#785
#784
#783
#780
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on  Graphite

See my comment on raw value


[Task]:  Explore codebase to understand the moustache and functional bindings evaluation logic in client

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

Explore codebase to understand evaluation logic
Analyse why uninitialized variable is resolved as null
Analyse why undefined is treated as variable and resolved to null.

Haven't gone through complete code but have understood the flow, and is enough to get started with datatype handling.


docs(fauna): update README.md

In line with next-auth@beta and adapters@next changes

Reasoning 💡
Update the fauna readme with new links, references, updated badges, etc. for the adapters@next and next-auth@beta packages, etc.

Checklist 🧢

[x] Documentation
~[ ] Tests~
[x] Ready to be merged

Affected issues 🎟

Yeah I was wondering what that failure was. Didn't have the energy to dig further into it last night haha. Makes sense though.

@balazsorban44 fixed the fauna error types, PR should be good to go now :+1:

Ah good catch 😅


Newhaven OLED random characters

Hi,
I have been trying to get pydPiper to work with a 16x2 OLED display, specifically this one: https://www.adafruit.com/product/823 (Newhaven NHD-0216KZW-AB5) but I cannot seem to get the display to work.
I have it connected with 4-bit parallel to the RPi3B+, but if I configure pydPiper with HD44780 I get random characters on the display, and with winter_weg I get the same thing.
I tried to play with the pulseEnable time, but still got nowhere.
Is there a specific configuration I'm missing with this type of OLED?
Thanks

Have you gotten any other sample code to work?  Usually when displays don't work correctly its a wiring problem.  FYI, the adafruit display appears to be the WEH001602a which is definitely supported.  I'm not sure about the Newhaven.

Yes, it does appear to be compatible.  Can you confirm whether you've gotten the display to work with an alternate program?

I just tried a basic python script to print "Hello World" on it using the RPLCD library and it works.

Well that rules out wiring problems.
I took a quick look at RPLCD and it looks like it is purely HD44780.  Why don't you try running with the hd44780 driver to see if that works.  FYI, you can run the display drivers as stand alone python programs for testing.
python hd44780.py
Normally you would need to supply all of the pin assignments on the command line but you've used the same values I have for defaults.   If you did need to enter them, it would look like this.
python hd44780.py -r 80 -c 16 --rs 7 --e 8 --d4 25 --d5 24 --d6 23 --d7 27

I tried setting it up as hd44780 previously, but I would only see “pydPiper starting” (or something similar) for about 1 second and then random characters over all the screen.


Use proto for document metadata encoding

This makes encoding ~3 times faster.
Decoding is made O(1), so no special metadata-only decoding API is needed.

Very Cool!


[WebView In App] Open WebView

How to open webview in application, but not in another window?

Sorry the answer is NO, that is impossible now.  Duplicate of #30
You can track this issue for more information. https://github.com/flutter/flutter/issues/37597


[AG-1041] Adds timestamp logging for processing runs

This PR adds a new module to agoradatatools: logs.py. The new module contains the log_time decorator function along with a couple of helper functions. log_time` works by decorating a function like so:
@log_time(func_name="process_dataset", logger=logger)
def process_dataset():
     ...

It takes the name of the function (for configuring the logging output) and the logger instance for the module that it is being used in as arguments. At the moment, log_time has configurations for process_dataset and process_all_files, so that we can time and timestamp the processing of each dataset and data processing as a whole.
In practice, when you run adt test_config.yaml, you should see an output like this for each dataset:
INFO | 2023-05-04 16:05:00 | Now processing genes_biodomains dataset

##################################################
 Uploading file to Synapse storage
##################################################

INFO | 2023-05-04 16:05:12 |
##################################################
 Uploading file to Synapse storage
##################################################

 / INFO | 2023-05-04 16:05:13 | Processing complete for genes_biodomains dataset
INFO | 2023-05-04 16:05:13 | Elapsed time: 00:00:13 for genes_biodomains dataset

And like this for the whole process:
INFO | 2023-05-04 16:04:47 | Agora Data Tools processing has started
...
...
...
...
INFO | 2023-05-04 16:07:12 | Elapsed time: 00:02:11 for all data processing

@JessterB Yeah I was wondering about that myself, but that has to do with the syn.login() functionality rather than anything in this repo. I tried to silence the Synapse logging, but it caused issues with our new login functionality. This is likely a Synapse client bug, Tom and I discussed that in this resolved comment thread.


Does not kick unresponsive users

If a user does not solve the captcha or press the button in the required time, he is not kicked since a few days (? could be just since today). Deleting messages still works though.

Seems to be fixed by https://github.com/backmeupplz/shieldy/commit/7def5f90ae522aec26cbe57fea8996a4f5f233c0

@Romern Can it be that this fix is not deployed to @shieldy_bot on Telegram? I found at least 3 bots in our chat of which the join message got deleted, but they were not kicked. Most recently 15 minutes ago.

@DASPRiD check recent messages to see if they passed captcha. Shieldy should be running well at the moment

Seems to work fine for me currently.


Autorest Regen Preview to 3.0.0-alpha.20230830.5 by Michael Nash from refs/pull/3702/head

Triggered from https://github.com/Azure/autorest.csharp/pull/3702

API change check
API changes are not detected in this pull request.


uv_spawn() fails if %PATH% is not present

If %PATH% is not set when uv_spawn() is called, it fails to spawn the process, even if an absolute path is given to a file that exists. uv_spawn() should be able to handle this case without %PATH%. The following code is the culprit:
  /* Get PATH environment variable. */
  path = find_path(env);
  if (path == NULL) {
    DWORD path_len, r;

    path_len = GetEnvironmentVariableW(L"PATH", NULL, 0);
    if (path_len == 0) {
      err = GetLastError();
      goto done;
    }

    alloc_path = (WCHAR*) uv__malloc(path_len * sizeof(WCHAR));
    if (alloc_path == NULL) {
      err = ERROR_OUTOFMEMORY;
      goto done;
    }
    path = alloc_path;

    r = GetEnvironmentVariableW(L"PATH", path, path_len);
    if (r == 0 || r >= path_len) {
      err = GetLastError();
      goto done;
    }
  }

Platform: Windows

What we would probably expect is to use a default path: https://github.com/libuv/libuv/blob/30c3ef9f6feff054e6bc2734d448de34b284fa9b/src/unix/process.c#L712-L715

Note that PATH is considered mandatory though for Windows, as we expect applications will misbehave with it set incorrectly (since https://github.com/libuv/libuv/commit/2ce14cfab45eb62017e39017fd156e3cf1cd1060)
https://github.com/libuv/libuv/blob/30c3ef9f6feff054e6bc2734d448de34b284fa9b/src/win/process.c#L55

Yes, it's true that you should never have %PATH% unset. However, in practice, CMake has at least one test case that unsets it, and I suspect there are probably others out in the wild as well. We are in the process of migrating from our own process-spawning library to libuv for all of CMake, and this corner case would cause a regression with the current behavior.


Reimplement version bumper

Is this a new chart
No
What this PR does / why we need it:
Deprecates the old chart-version-bumper action with a new version written in go with less dependencies.
Fix https://github.com/newrelic/helm-charts/issues/404

Related to #404 which is closed.
Closing.


Addition of issue and PR template

@heet-kumar
Fixes #78

Superb @Asmit2952 can you also add a text box in the PR template, where the contributers can write their issue no. too. Some of the contributers mostly skips that part.

Issue No.
#(any issue no)

Superb @Asmit2952 can you also add a text box in the PR template, where the contributers can write their issue no. too. Some of the contributers mostly skips that part.
Issue No.	#(any issue no)

Superb @Asmit2952 can you also add a text box in the PR template, where the contributers can write their issue no. too. Some of the contributers mostly skips that part.
Issue No.	#(any issue no)

Yupp sure!!

@manisha-27 Done!!


Mission

Engineers Checklist
What this PR does?

List of updates for features, enhancements, or bugfixes

How can it be tested?

Please provide step-by-step guide on how to test
If web or mobile, screenshots will be very helpful in addition

Where is it documented?

List JIRA tickets

Backend Updates

[x] Updated Postman Documentation

[x] Requests
[x] Examples
[x] Tests

[x] Updated Tasks on JIRA
[x] Tested API updates in dev environment
[x] CI Checks Passed


sparse.to_dense don't work when used to dataset element

`def _parse_function(example_proto):
features = {"feature0":tf.io.VarLenFeature(tf.int64),
"feature1": tf.io.FixedLenFeature([1], tf.int64)}
parsed_features = tf.io.parse_single_example(example_proto, features)
print(parsed_features['feature0'])
return tf.sparse.to_dense(parsed_features['feature0']), parsed_features['feature1']
dataset = tf.data.TFRecordDataset(filename)
dataset = dataset.map(_parse_function)`
error like below
  File "/home/yi/bin/Miniconda2/envs/py36/lib/python3.6/site-packages/tensorflow/python/ops/sparse_ops.py", line 68, in _convert_to_sparse_tensor     raise TypeError("Input must be a SparseTensor.") TypeError: Input must be a SparseTensor.

Please fill the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Along with the template, please provide as many details as possible to find the root cause of the issue. It would be great if you can provide a small code to reproduce the error. Thanks!

Closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


New command to toggle between bullet and todo

This is a proposed fix for #4.

I'm don't know the best practice for defining short-cuts - should they be default disabled or some such? alt-t conflicts with the terminal menu item but that is what I would choose to use
it's a bit tricky to distinguish between the two types of toggle. Personally I never want to toggle between "plain text" and "todo bullet" and only ever between "bullet" and "todo bullet"

Sounds good but shouldn't the "Toggle Todo" command just handle this automatically? I don't think we need a separate command and shortcut for this.

Hi @fabiospampinato thanks for taking a look.
Are you suggesting I tweak the existing "Toggle Todo" command? Sounds good to me, I was just being cautious about changing existing behaviour. If so, I'll amend the PR.
It does mean that if you accidentally toggle plain-text into a todo, you can't toggle it back to plain text, toggle will only return to a bullet point. That would be fine for me but I can't speak for others.

It does mean that if you accidentally toggle plain-text into a todo, you can't toggle it back to plain text, toggle will only return to a bullet point. That would be fine for me but I can't speak for others.

🤔 In theory we should detect if the current line of text would make a proper sublist but that's complicated, maybe we can just remove the bullet point if the paragraph is at the beginning of the line (maybe it was intended to be a list, maybe a paragraph, can't really know for sure so we err on the side of the paragraph), otherwise if there's any character on the same line before the bullet point we keep the bullet point.
Does that sound reasonable?

Hmm. For testing sub-list/sibling-list or paragraphs I think we need more context than regexes over a single line. Maybe change the rules to be lambdas? It will allow for more complex transformations.
e.g.
async function toggleRules (... rules: (line : vsCode.TextLine, textEditor : vsCode.TextEditor) => string)

The rule execution would be pretty simple. Just treat null as no match:
const replacement = rule(line, textEditor);

if (replacement !== null) {
// make the edit
}

I can create a helper function to support the existing regex replacements:
function makeRegexRule(regex : Regex, replacement : Regex)
  : (line :vsCode.TextLine, textEditor : vsCode.TextEditor) => string {
  if ( !regex.test ( line.text ) ) return null;
  return line.text.replace ( regex, replacement );
}

function toggleDone () {

  const {bullet, done} = Consts.symbols,
        {line, todoBox, todoDone} = Consts.regexes;

  toggleRules (
    makeRegexRule(todoDone, `$1${bullet} [ ] $3`),
    makeRegexRule(todoBox, `$1${bullet} [${done}] $3`),
    makeRegexRule(line, `$1${bullet} [${done}] $3`)
  );

}

And then I can write a rule that looks at the context of the todo.

Do whatever feels best to you, if you think having a separate command for this is better let's go with that.

@duncanawoods do you still care about this PR?


Issue with flyway-core 9.11.0 scripts MARKED AS DELETED

Which version and edition of Flyway are you using?
9.11.0 Enterprise (Previous Version used was 6.4.1 and with this version we don't have this issue) [We're upgrading flyway-core to the newest one]
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
This happens only with the newer edition (9.11.0) (Marking as DELETED), already tried solving it with this other comments in this issue (https://github.com/flyway/flyway/issues/3180)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Java API
Which database are you using? (Type & version)
Oracle 19c Enterprise Edition
Which operating system are you using?
Windows 10 21H2
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
I have an Eclipse App with many folders to execute scripts in some 'order', this order is like:
FOLDER A
	R__00
FOLDER A1
	V__1.001
	V__1.002
FOLDER A2
	R__01_A
	R__SYN
FOLDER B
	V__3.01
	V__3.02
FOLDER C
	R__FN
	R__PB
	R__PH
	R__SP
	R__VIEW
	R__GRANT

And the Java Process is:
First Folder
Flyway.configure().locations(classPath).licenseKey(KEY).table("schema_history").dataSource(DS).load();
All the other folders
Flyway.configure().locations(classPath).licenseKey(KEY).failOnMissingLocations(true).baselineOnMigrate(true).validateOnMigrate(false).table("schema_history").dataSource(DS).load();

classPath stands for the path of every FOLDER and they're located on the base folder 'db/migration/' + folder_name

This is for some business implementations that are used for the client, so those are needed in that order to evade compilation error between objects and other implementations.
The first folder (FOLDER A) contains only 1 REPEATABLE MIGRATION, that is MARKED AS DELETED on every execution.
The second folder (FOLDER A1) contains a lot of VERSIONABLE MIGRATIONS, that doesn't happen here, they are counted on the "schema_history" and are counted within the DB version.
The third folder (FOLDER A2) contains many REPEATABLE MIGRATIONS, same happens here (MARKED AS DELETED) on every execution.
The fourth folder (FOLDER B) same as FOLDER A1.
The last folder (FOLDER C) also contains many REPEATABLE MIGRATIONS, same happens here.
What did you expect to see?
Only 1 Execution for every SCRIPT, unless is a R__ and I changed something on the script to change the checksum and repeat the execution, not to be repeated everytime I run the app, and doesn't have registers of DELETED on the "schema_history".
It seems like the function repair doesn't work properly for my implementation, if I have 20 REPEATABLE sql files, they are marked N times (N executions) on the schema_history, even if it doesn't have changes on the checksum.
What did you see instead?
All the FOLDER A, FOLDER A2 and FOLDER C Marked as DELETED and this makes the flyway execution to fail because I'm doing a DML (INSERT) and it tries to insert a DUPLICATE VALUE (PK). And (i.e.) if the scripts is validated with a DELETE before the INSERT statement to make sure it pass the execution, the process continue executing the R__ files again and again and marking them N times.

Just experienced the same. Reverted back to 8.x, and it still marks stuff as deleted :roll_eyes:


🐛 [Firebase_messaging] iOS Terminated push Notifications issue

Hi,
I recently discovered (but too late :( we have 35k users that use our app that handles push notifs via onBackgroundMessage() in order to save them in DB to have an history in the app... ) from your documentation at :
https://firebase.google.com/docs/cloud-messaging/flutter/receive)](https://firebase.google.com/docs/cloud-messaging/flutter/receive
that :

I'm aware that it is an iOS restriction even if i don't understand why it is not "fixed"/changed by Apple.
So our app does work in 5 scenarios out of 6.
The only one that doesn't work is for TERMINATED iOS app, but it must be the case for 80% of the time for iOS users :(
I would like to know if there is something to do about it !?
Because I've read this thread on stackoverflow :
https://stackoverflow.com/questions/76238055/flutter-fcm-not-handling-messages-when-app-terminated-on-ios
where people have the same issue and in the 1st post the author says :
The one scenario in which the onBackgroundMessage() handler is not called (even though the push notification comes through and is displayed), is on IOS when the app is terminated. **_The handler does however work when you send a second push notification right after the first one, because the first one wakes up the app_**.
Is it correct that a 1st notif would wake up the app ?
And that a 2nd one would then correctly be handled ?
If true, there must be a solution right ? "refiring" the event that woke up the app in the 1st place for exemple or something...
How to achieve this please ?
Any help would be MUCH appreciated 'cause we can't stay like that and the only solution would be to refactor the whole thing by a webservice call that would "pull" notifs history from a server (an i'd (really) rather not do that...)
Thanks in advance.

maybe this then.

Did anyone identify a fix. Recently faced this issue on our app.
notificaitons works absolutely fine on android and on ios as well in background and foreground state.
in terminated state the notification shows up but the callback handler is not invoked.


[rust] add flag accessors on nodes

The raw flags() accessor that is currently exposed is functional, but seeing as how none of the relevant constants for the flag values are exported in prism-sys, flags() isn't very useful.  Let's write actual functions for each of the relevant flags, which will hopefully result in clearer code and make it so people don't have to worry about the bit-twiddliness of flag storage.

Love this. What do you think of prefacing with is_? In my limited exposure to rust I think I've seen that more often?

I think that's a great idea.  After doing that change, I think the only ones worth calling out are:

range.is_exclude_end() reads weirdly (excludes_end would be ideal, but I think exclude_end was OK-ish)
regex.is_ignore_case() reads weirdly (ignores_case would be ideal, but I think ignore_case was fine)
regex.is_once() is...OK? (I think the original once was fine here, but I don't have especially strong feelings)

Everything else is neutral or an improvement.


Write our own KDE implementation

For kernel density estimation (KDE) we are currently using pdfast because it's what's on npm. This runs slower than I think it should, and having looked over the code I see many things that could be more efficient. The interface is also more complicated than we need right now. I'm very interested in KDE on a transformed domain and I think this will require modifying the code to multiply samples by the derivative of the transformation.
The parts we're using are a little under 200 lines and should only take a few hours to rewrite. It can be tested against the existing code for accuracy, and because KDE is a simple operation I don't think there are any real corner cases to worry about (I will be including and testing the min and max functionality since it's needed for #1133).
There's a possible concern that the triangular kernel is not actually useful to us, if we want to use a Gaussian or other kernel. I think Gaussian KDE is probably too slow to be worth it, but should probably do a speed check using a package in some other language. I've seen claims that the kernel shape is not very important relative to the bandwidth for KDE (based on context, this is probably looking at limiting behavior with large numbers of points, but we do have a lot of points). I think the basic idea for optimizing the triangular kernel does extend to higher-order polynomials, so approximating a Gaussian with a cubic or some other shape could also be worth trying.

I've been working to simplify the pdfast code and have noticed two issues so far:

It uses min and max computed from the input data to determine the x value boundaries, but the way it adds the kernel width to these is wrong. The kernel width is a multiple of the step size and the adjustment increases the step size, so it's too small. I think our number of points is too large for this to make a difference now.

The samples are all rounded off to the nearest x point. On its own this would only lead to less precision, but it's done by rounding down, which introduces bias. This code example shows the mean of many sampled normal distributions versus the mean after converting to point sets. The samples themselves don't appear biased but the point sets are low by about 3e-3.

Changes to the style, such as using an array of y values instead of {x,y} objects (the x field wasn't even used, except as output!) are showing about a 20% overall improvement in scripts/bench-sampleset-to-pointset.mjs. I very roughly measured samplesToContinuousPdf as taking 30% of the time before so this would be a 3x improvement.
The fact that the pdfast results aren't good means I don't think it's so useful to compare the rewrite to it. Instead I'll write a test that does KDE in the naive way on a randomly chosen subset of the x values and test that the y values don't differ from this too much.
I think we probably do want the y values at the boundaries to be 0? This makes it so there's no probability mass hanging outside the supported range.

This is exciting to see, nice work.

I think we probably do want the y values at the boundaries to be 0? This makes it so there's no probability mass hanging outside the supported range.

I think this is a safe thing for now. Later on I could see us adjusting the boundaries of all dists to x=-MAX_VAL to MAX_VAL, and have Y allowed to be above zero at these points. It's not something to worry about now though.
If the kernel is not a gaussian, I'd expect it to quickly get to zero.

The reason the bad margin computation didn't cause errors is that it adds 2 * width, where width is the distance from the middle to the edge of the kernel. Which makes it safe as long as the number of points is above 2 * width or so, but also wastes about width points on each side.


backup and restore pvc alongside pv

This PR solves the Crunchy DB issue where a new PV/PVC is created with a random name. We backup the PVC as well as the PV and restore both on the other side so that the crunchy DB operator does not create a new PV/PVC but instead it reuses the restored ones.

Is OCM able to delete PVCs that we restored rather than it being created by the Subscription?
We don't depend on the subscription to delete the PVC because it won't.  We have to do it ourselves.  Somehow, the code block that deletes the PVC was not included.  I can't explain how it got removed before I create the PR. But I re-add it.
Is OCM able to update a PVC (say it's size in git was updated) if we restored the PVC?
That's a good question. Once Ramen starts managing the PVC, we lose all updates to it from git. Maybe that's something that is too important to ignore.

IOW, is there any ownership conflict/issue as we are restoring it and not OCM Subscription as before?

@BenamarMk can this be closed since #811 has been merged in?


Barbarian attack speed breakpoints off by one

The Breakpoint tooltip is showing information as though you are one breakpoint ahead of what you should be. Specifically, the Next Breakpoint info is actually for two breakpoints ahead, the Previous Breakpoint info is actually for the current breakpoint (as can be seen by it being a positive ASI number instead of negative, with +0% DPS), and the highlighted info in the table is for the next breakpoint instead of the current one.
This appears to only be an issue with the barbarian class, but it affects all barbarian skills.
Note, this issue appeared when Issue #297 was fixed (I responded to that ticket instead of making a new one like I should have).
See attached screenshot with tooltip info for the 19 frames breakpoint even though the current breakpoint is 20 frames:

Fixed. Congrats on bug #300!


Add "outline follows border-radius"

Recently (I don't know when) at least Firefox and Chromium changed implementation of CSS outline when a border-radius is present.
Previously the outline was always rectangular.
Now the outline follows a border-radius (with or without a border set).
"outline follows border-radius" works with Chrome 94 and Firefox 94,
don't work with Chrome 77 and Firefox 68 (sorry, don't have other data)
 <div style="outline:solid red; border-radius:1em">
      this should have a red border with rounded corners
 </div>

Fwiw, this was added in Firefox 88 1 and Chromium 94 1, 2

Spec: https://www.w3.org/TR/css-ui-3/#ref-for-border-edge
As evidenced here:

https://bugzilla.mozilla.org/show_bug.cgi?id=315209#c11
https://bugs.chromium.org/p/chromium/issues/detail?id=81556#c21
https://bugs.chromium.org/p/chromium/issues/detail?id=81556#c30

Safari:

https://bugs.webkit.org/show_bug.cgi?id=20807
or rather https://bugs.webkit.org/show_bug.cgi?id=231433

MDN put this aspect directly into the main thing (outline) with notes:

https://developer.mozilla.org/en-US/docs/Web/CSS/outline#browser_compatibility
https://caniuse.com/mdn-css_properties_outline

So technically it's covered already ]:->
But we probably should either track it separately and link to it from https://caniuse.com/outline or do it like MDN.
I would suggest and prefer (only!) one note on all versions of Chromium, Firefox and Safari which don't support it, pretty close to note 4 from MDN

outline does not follow the shape of border-radius. See bug 231433.

so only the past (and for the time being Safari) gets cluttered up.
I could do the PR.
What do you think, @Fyrd?

What about changing all of Safari to Partial Support. Historically, caniuse has used partial when an implementation has many bugs. It's a big problem, so maybe that's enough to justify it?
I'd also update the bug link since the referenced one was marked by a duplicate. The correct webkit bug link: https://bugs.webkit.org/show_bug.cgi?id=20807

What about changing all of Safari to Partial Support on outline?

I've opened a PR on mdn/browser-compat-data to do just this—I guess that would filter over to Caniuse if it's merged, though I don't know what the strategy around this is for data which is duplicated between MDN data and Caniuse data.

Safari 16.4 (beta) via https://developer.apple.com/documentation/safari-release-notes/safari-16_4-release-notes:

Added support for outline following the curve of border-radius.

Is there a way to detect with css that it will follow the border outline? Like a @supports perhaps? So you could detect if it would follow and style accordingly? Otherwise fallback on box-shadow?

when you use box-shadow you can't make like an alpha element using just the border, and also you can't make a linear gradient box shadow, only with a lot of more code


Support private clusters in AWS China region / CloudFront domain alias

Apart from https://github.com/giantswarm/roadmap/issues/2420 and https://github.com/giantswarm/roadmap/issues/2746, we also need to add support for the AWS China region for CAPA clusters and have IRSA working fine. The problem with CloudFront in China is described in chat.

it is already implemented here

I don't think setting the domain is enough. As of the chat (see link above), we need to set a working certificate specifically for CloudFront China.

I was trying to comment here. I dont know how I managed to comment to this issue.

we see no requirement for now with this - closing


Cannot use ports other than 6443 for master API

Environmental Info:
K3s Version:  k3s version v1.19.2+k3s-48ed47c4 (48ed47c4)
Describe the bug:
See title
Steps To Reproduce:
Start a new server but do not listen on 6443, e.g try 8443 for some reason
Expected behavior:

Can accept and receive client/agent data from 8443
Actual behavior:
It will spam something like this
Sep 27 05:57:56 ssdnodes-5f6c87e4f06e3 k3s[1912625]: , Header: map[Content-Type:[text/plain; charset=utf-8] X-Content-Type-Options:[nosniff]]                                                                                Sep 27 05:57:56 ssdnodes-5f6c87e4f06e3 k3s[1912625]: I0927 05:57:56.640314 1912625 controller.go:129] OpenAPI AggregationController: action for item v1beta1.metrics.k8s.io: Rate Limited Requeue.                                           Sep 27 05:57:56 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:57:56.818496246Z" level=info msg="Waiting for cloudcontroller rbac role to be created"                                                                              Sep 27 05:57:57 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:57:57.027207484Z" level=info msg="Waiting for node ssdnodes-master-sgp CIDR not assigned yet"                                                                       Sep 27 05:57:57 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:57:57.823653033Z" level=info msg="Waiting for cloudcontroller rbac role to be created"                                                                              Sep 27 05:57:58 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:57:58.834390152Z" level=info msg="Waiting for cloudcontroller rbac role to be created"                                                                              Sep 27 05:57:59 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:57:59.038026573Z" level=info msg="Waiting for node ssdnodes-master-sgp CIDR not assigned yet"                                                                       Sep 27 05:57:59 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:57:59.842656959Z" level=info msg="Waiting for cloudcontroller rbac role to be created"                                                                              Sep 27 05:58:00 ssdnodes-5f6c87e4f06e3 k3s[1912625]: E0927 05:58:00.639795 1912625 available_controller.go:437] v1beta1.metrics.k8s.io failed with: failing or missing response from https://<IP_ADDRESS>:443/apis/metrics.k8s.io/v1beta1: Get "https://<IP_ADDRESS>:443/apis/metrics.k8s.io/v1beta1": context deadline exceeded                                                                                Sep 27 05:58:00 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:58:00.848930069Z" level=info msg="Waiting for cloudcontroller rbac role to be created"                                                                              Sep 27 05:58:01 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:58:01.047080320Z" level=info msg="Waiting for node ssdnodes-master-sgp CIDR not assigned yet"                                                                       Sep 27 05:58:01 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:58:01.855341011Z" level=info msg="Waiting for cloudcontroller rbac role to be created"                                                                              Sep 27 05:58:02 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:58:02.863791372Z" level=info msg="Waiting for cloudcontroller rbac role to be created"                                                                              Sep 27 05:58:03 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:58:03.074204967Z" level=info msg="Waiting for node ssdnodes-master-sgp CIDR not assigned yet"                                                                       Sep 27 05:58:03 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:58:03.873051543Z" level=info msg="Waiting for cloudcontroller rbac role to be created"                                                                              Sep 27 05:58:04 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:58:04.517771971Z" level=info msg="Waiting for API server to become available"                                                                                Sep 27 05:58:04 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:58:04.880184110Z" level=info msg="Waiting for cloudcontroller rbac role to be created"                                                                              Sep 27 05:58:05 ssdnodes-5f6c87e4f06e3 k3s[1912625]: time="2020-09-27T05:58:05.086023069Z" level=info msg="Waiting for node ssdnodes-master-sgp CIDR not assigned yet"                                                                       Sep 27 05:58:05 ssdnodes-5f6c87e4f06e3 k3s[1912625]: E0927 05:58:05.646026 1912625 available_controller.go:437] v1beta1.metrics.k8s.io failed with: failing or missing response from https://<IP_ADDRESS>:443/apis/metrics.k8s.io/v1beta1: Get "https://<IP_ADDRESS>:443/apis/metrics.k8s.io/v1beta1": dial tcp <IP_ADDRESS>:443: i/o timeout

and the entire master will not continue operating
Additional context / logs:
I wanted to use cloudflare to protect my endpoint, but cloudflare cannot proxy port 6443, rather the list of supported HTTPS ports are here. I can use Rancher to open an ingress and then use their login info as manifest, but I think it is too heavyweight

I would not recommend putting your Kubernetes apiserver endpoint on the internet, cloudflare or no.

@brandond https-listen-port. Also I use cloudflare with proxy, and this is solely out of trying to protect my server from being attacked if one of my worker node is pwned. turns out of i will still be c*ckblocked by the fact that cloudflare also intercepted the TLS connection to use their own cert, rendering the self signed cert in k3s useless. I have abandoned this idea to protect my mastee ever since but I'm curious why is running ports other than 6443 not okay? This implies the impossibility of running multiple k3s master so...


Width problems in input-groups.

When the text of a choice in an input group is longer than the column, the select element stretches instead of respecting the column width.
see this plunker : http://plnkr.co/edit/7j6AOfgQHdb5CzQW00k4?p=preview

Edit: Here is an image showing the problem


Add a Help section to the Sphinx docs

Resolves: https://github.com/ivadomed/ivadomed/issues/568

Add a Help section under Getting Started in the docs.
Add a README file for installing/getting started using the docs.

Pull Request Test Coverage Report for Build 414175477

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.239%

Totals

Change from base Build 414082612:
0.0%

Covered Lines:
5863

Relevant Lines:
6570

💛  - Coveralls


rebar3.org DNS name?

Occasionally I enter rebar3.org into my browser and don't get into www.rebar3.org but see ERR_NAME_NOT_RESOLVED
It would be more convenient to have a redirect instead (though I personally prefer names without dummy www in them)

Yea, readme.io only lets you have one domain. What I've done is use Cloudflare's URL rewrite rules to rewrite http://rebar3.org to http://www.rebar3.org, it should be working again now.

Yeah that's weird. Currently rebar3.org appears to have neither an A nor a CNAME record. curl won't do the retry and find it, but Firefox will.

@qrilka ok if we close this? The redirect should work in browsers at least.

It does not work in Chrome for me but feel free to close it if you think it's the most suitable option at the moment.

 I think I know what is wrong. Will update and let you know.

Can you try again?

Yep, that's much better, thanks


Waveform scroll gesture can't begin with swipe to left

I've noticed this strange behaviour where I can only begin with a swipe-right gesture to scroll through the waveform. I can swipe left but only if I begin the gesture with a swipe to the right. Below is the AudioWaveforms widget, let me know if you need the full code snippet. I have also attached a recording of this behaviour.
AudioWaveforms(
  enableGesture: true,
  size: const Size(double.infinity, 80.0),
  waveStyle: const WaveStyle(
    showMiddleLine: false,
    waveThickness: 4,
  ),
  recorderController: recorderController,
)

@william-herring Let's say we are allowing left swipe when waveforms are in the initial state. In the initial state, waves are at the middle of the screen if the extendWaveform flag is set false else they will be at the start of the viewport at the right side. Now, when you left swipe waves will start going outside of the viewport from the beginning so allowing waves to go outside of the viewport makes sense.
Do let us know if this clears things up.

And you have provided a image not video


Fix missing screenshot for quickstart

What this PR does / why we need it:
This screenshot is still being used by old docs.
Which issue(s) this PR fixes:
Fixes #2968
Does this PR introduce a user-facing change?:

NONE

Nice catch
/approve


Odd objects in ZP has_part edges

I'm not sure what to make of objects in these associations
id      subject predicate       object  category        relation        knowledge_source
urn:uuid:72275123-b615-40e5-a18e-d8c6270456aa   ZP:00000000     biolink:has_part        N8e0099d3a3d94250b35165a29c5d231f       biolink:Association     BFO:0000051     Graph
urn:uuid:158d58ec-a54a-43a9-a2a8-396258cf7af2   ZP:0000002      biolink:has_part        Ne5c13f76e6274f479508b2bc485d4b93       biolink:Association     BFO:0000051     Graph
urn:uuid:4760c510-0ef1-47a6-ac5a-d2965f61dd15   ZP:0001021      biolink:has_part        N3a610fb4ab51494dbde6cd7a4344f2a3       biolink:Association     BFO:0000051     Graph
urn:uuid:3554a3dd-a769-4709-b6db-814e69e2798a   ZP:0000605      biolink:has_part        N75cfe3bd80534e71b6ede82ebe499040       biolink:Association     BFO:0000051     Graph
urn:uuid:894d2355-dd06-4663-b9f7-65f51653e0f5   ZP:0005505      biolink:has_part        N367cc09804b344d982385355f5888ab0       biolink:Association     BFO:0000051     Graph
urn:uuid:802d1217-3b82-4a6e-8b2a-e4762c452723   ZP:0010064      biolink:has_part        N2d14d99b853a4d0ea6aee778b76f1a04       biolink:Association     BFO:0000051     Graph
urn:uuid:f5188cdb-1ed5-4528-b299-ac58ce2aa3bf   ZP:0011389      biolink:has_part        Nec32d573a92c4adaa87f7896dc7fdefc       biolink:Association     BFO:0000051     Graph
urn:uuid:64be5935-e981-4ba0-8c8d-2994c4f732ca   ZP:0019005      biolink:has_part        N5fb7aeb0c69241d8be016d9b10c92c63       biolink:Association     BFO:0000051     Graph
urn:uuid:bf5eeca5-5b7b-480e-922a-4b0fea0a62fd   ZP:0014862      biolink:has_part        Nd3daf5295b5d4335a16047d63a65cd8c       biolink:Association     BFO:0000051     Graph
urn:uuid:bda73968-0c10-415c-b9f9-280ed0e4a539   ZP:0004433      biolink:has_part        N1e2d4df8a6a045b49d2f48ae92b2003f       biolink:Association     BFO:0000051     Graph

finding one in the nodes file, it's just:
N8e0099d3a3d94250b35165a29c5d231f       biolink:NamedThing                              Graph

Those are blank nodes - they really shouldn't be there, but here they are, and they'll be gone in subsequent releases.

That being said, it's very good to know where they're still appearing, because it's revealing where the subq reconstruction may not be working as expected (or some other parsing issue is happening)

Which part of the process where you thinking for stripping anonymous (blank) nodes? phenio or KG-Phenio? I would tent a bit to the latter because there are use cases for phenio that could benefit from the logical axioms..

The bnodes really shouldn't be in KG-Phenio at all so at minimum the graph transform step can remove them. KGX will catch and ignore bnodes when they're created during a transform process (i.e., changing serialization formats) but not when they're created upstream, as is happening here during subq reconstruction. I expect some of these will disappear once we've made that part (subq reconstruction) more comprehensive.


fix lints

Summary

fix lints

Codecov Report

Merging #2245 (44df4fe) into main (80b79ed) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2245      +/-   ##
==========================================
- Coverage   28.36%   28.35%   -0.01%
==========================================
  Files         131      131
  Lines        7840     7839       -1
==========================================
- Hits         2224     2223       -1
  Misses       5315     5315
  Partials      301      301

Impacted Files
Coverage Δ

cmd/cosign/cli/verify/verify_blob.go
43.79% <50.00%> (-0.13%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fixing e2e tests

fixing e2e tests

thank you!

closing in favor of https://github.com/sigstore/cosign/pull/2247


decompressFromUint8Array optimisation

Remove the redundant temporary buffer, and push the output character directly into the output buffer. This saves memory and is quicker as it doesn't need to iterate twice.
(Minified version not updated as edited on GitHub directly)

Sorry for the delay. I will setup a small jsperf.com test with this vs the head of the repo to make sure it works on all browsers. When that's done a we have a little data I'll merge it.
Thanks for the effort.

But jsperf.com is down :-/

It has been for most of this year - makes life a lot harder for testing stuff :-/
You can manually test in multiple browsers - but the code can be eyeballed as being identical in function, just not using a temporary buffer.

@pieroxy While we're on this topic, do you know why compressToUint8Array and decompressFromUint8Array don't use _compress and _decompress directly, and instead adds an extra conversion step using a UCS-2 string?
For example, the code sample below is fully compatible with the current implementation:
(It makes decompressFromUint8Array significantly simpler)

  compressToUint8Array: function (input) {
    var compressed = LZString._compress(input, 8, function (a) {
      return f(a);
    });

    // For backwards compatibility with old format using UCS-2
    if (compressed.length % 2 !== 0) {
      compressed = compressed + f(0);
    }

    var buf = new Uint8Array(compressed.length);

    for (var i = 0, TotalLen = compressed.length; i < TotalLen; i++) {
      buf[i] = compressed.charCodeAt(i);
    }

    return buf;
  },

  decompressFromUint8Array: function (compressed) {
    if (compressed === null || compressed === undefined) {
      return LZString.decompress(compressed);
    }
    else {
      if (compressed.length == 0) return null;
      return LZString._decompress(compressed.length, 128, function (index) {
        return compressed[index];
      });
    }
  },

If you think this new implementation is worth a shot, I could send in a PR.

@pieroxy worth noting that jsperf.com is back online!

Right, thanks!

@lishid: Actually, this can be optimised even further for compressToUint8Array: right now  _compress (and by extension compress) returns a string. However, the intermediate code relies on an array of chars that is converted to a string near the end.
So if we make a new function, say compressToArray, which contains all the code of _compress except that the last line of:
    return context_data.join('');

becomes:
    return context_data;

And then rewrite _compress as:
  _compress: function (uncompressed, bitsPerChar, getCharFromInt) {
    return compressToArray(uncompressed, bitsPerChar, getCharFromInt).join('')
  }

(which makes it backwards compatible with existing compressors at the cost of a single extra function call), then we can change your code to:
  compressToUint8Array: function (input) {
    var compressed = LZString.compressToArray(input, 8, function (a) {
      return f(a);
    });

    // For backwards compatibility with old format using UCS-2
    if (compressed.length % 2 !== 0) {
      compressed.push(f(0));
    }

    // we could even replace this with Uint8Array.from if not for backwards compatibility
    var buf = new Uint8Array(compressed.length);

    // this can theoretically be sped up even further with loop-unrolling:
   // http://jsbench.github.io/#80b894adfe3e635ef03e7f6ebc55d086
    for (var i = 0, TotalLen = compressed.length; i < TotalLen; i++) {
      buf[i] = compressed[i];
    }

    return buf;
  },

This saves use the creation of a string, and array lookup is probably faster than charAt(i) as well

@JobLeonard I didn't even look at it that deeply - nice - if you make that into a PR this one can be closed :-D

@Rycochet: look a bit closer: my optimisation is for compression, yours for decompression ;).
The mistake is understandable though, they're doing similar things. You know what, tomorrow I'll try to combine all suggestions in this thread and push a PR!

@JobLeonard Doh, apparently I didn't look back at my change either lol - go for it ;-)

Closing in preference of #98 - includes this and other code in these comments.


fix paths manipulation in reader to work on cross-platforms

To support server implementation on Windows, we have to implement a path separator adjusted to each OS.
Using this fix, we'll be able to work with the same OS for the server and the client, e.g.
windows client -> windows server
linux client -> linux server, etc...
The next step is to allow full cross-platform support, to make the server OS agnostic.

@tebeka Hey, it won't work (mentioned in the description), we should think of a better solution, but at this moment it solves the support for both platforms (windows/linux/mac).


Remove usages of deprecated Maven 2 references (like maven-compat)

we should migrate all to new Maven 3 replacements
MavenProjectBuilder projectBuilder,
ArtifactMetadataSource artifactMetadataSource,
WagonManager wagonManager,
ArtifactResolver artifactResolver

#559

Next one: #713

Working on migrating to Maven 3.

Please one by one if possible 😄

@slawekjaranowski I have a question.
Do we still need to provide Maven 2 backward compatibility in case of plugin repos? I've created this, but am now thinking whether it is really needed...
/**
 * Provides backward-compat with 2.x that allowed plugins like the maven-remote-resources-plugin:1.0 to
 * populate the builder configuration with model repositories instead of artifact repositories.
 *
 * @param repositories list of remote repositories
 * @param session {@link RepositorySystemSession} instance
 * @param repositorySystem {@link RepositorySystem} instance
 * @return list of repositories converted to {@link ArtifactRepository} objects
 * @throws InvalidRepositoryException if the remote repository cannot be reconstructed
 *
 * @since 2.14.0
 */
public static List<ArtifactRepository> normalizeToArtifactRepositories( List<?> repositories,
                                                                        RepositorySystemSession session,
                                                                        RepositorySystem repositorySystem )
        throws InvalidRepositoryException
{
    try
    {
        return repositories
                .stream()
                .filter( o -> o instanceof Repository )
                .map( o -> (Repository) o )
                .map( r ->
                {
                    try
                    {
                        ArtifactRepository repo = repositorySystem.buildArtifactRepository( (Repository) r );
                        repositorySystem.injectMirror( session, singletonList( repo ) );
                        repositorySystem.injectProxy( session, singletonList( repo ) );
                        repositorySystem.injectAuthentication( session, singletonList( repo ) );
                        return repo;
                    }
                    catch ( InvalidRepositoryException e )
                    {
                        throw new IllegalArgumentException( e );
                    }
                } )
                .collect( Collectors.toList() );
    }
    catch ( IllegalArgumentException e )
    {
        throw (InvalidRepositoryException) e.getCause();
    }
}

NO, to remove, I saw similar code in Maven core - not needed in plugin

Good, we also have Maven 2 compat code in DisplayPluginUpdates, I'll remove that too.

So this whole procedure is not necessary anymore?
    /**
     * Retrieves the standalone superproject
     *
     * @param projectBuilder       {@link ProjectBuilder} instance
     * @param mavenSession         {@link MavenSession} instance
     * @param logger               The logger to log tog
     *
     * @return superproject retrieved
     * @throws ProjectBuildingException if the retrieval fails
     */
    public static MavenProject getStandaloneSuperProject( ProjectBuilder projectBuilder,
                                                          MavenSession mavenSession,
                                                          Log logger ) throws ProjectBuildingException
    {
        ProjectBuildingResult result = projectBuilder.build( new UrlModelSource(
                        Objects.requireNonNull( PomHelper.class.getResource( "standalone.xml" ) ) ),
                createProjectBuilderRequest( mavenSession, r -> r.setProcessPlugins( false ) ) );
        if ( result.getProblems() != null )
        {
            logger.warn( "Problems encountered during building of the superproject." );
            result.getProblems().forEach( p ->
                    logger.warn( "\t" + p.getMessage() ) );
        }
        return result.getProject();
    }

@slawekjaranowski

Wagon -> straight to Transporter

After two of #828, #829, #831 have been merged, I'll update the last one to also remove maven-compat from dependencies as it will not be needed when all of them are merged, and this ticket can then be closed.

I have a question. I wanted to remove the maven-compat dependency altogether, but then I faced a problem: there was no provider for the RepositorySystem interface anymore. I see that Maven uses LegacyRepositorySystem from maven-compat. I think there is a provider in Maven Resolver. Question is -- should I use it?

Can be closed @slawekjaranowski

I have a question. I wanted to remove the maven-compat dependency altogether, but then I faced a problem: there was no provider for the RepositorySystem interface anymore. I see that Maven uses LegacyRepositorySystem from maven-compat.
Which one should I use instead?
org.codehaus.plexus.component.repository.exception.ComponentLookupException: java.util.NoSuchElementException role: org.apache.maven.repository.RepositorySystem roleHint:

as usual Maven dev list is the best place to ask,
please provide which methods we use from RepositorySystem


fix: add dashboard markdown id

SUMMARY

This PR adds html id's to dashboard markdown components. Fixes https://github.com/apache/superset/issues/15358. Added so that different css can be applied to each markdown, which I was not able to do previously.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before screenshots can be seen in https://github.com/apache/superset/issues/15358.
After screenshots:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[x] Has associated issue: #15358
[x] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@suddjian I made a small change - decided to drop the redundant dashboard-markdown- prefix after reading up on the way IDs are created. Sorry about that.


Multiple DHCPv6 instances send advertisements

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
I've enabled IPv6 on some of my interface in OPNsense. Most of them are tracking the address from the WAN interface, and distribute the addresses to my LAN clients by DHCPv6. One interface has a static ULA address without DHCP.
After a prefix change I noticed that my clients still got the previous IPv6 prefix, although the OPNsense interface overview showed the new one.
I run a packet capture and noticed, that my clients received always four DHCPv6 advertisements in respone of their solicit. Three of them contained the previous IPv6 prefix. Only one contained the new one.
The clients requested the address of the first advertisement, which was always the old address. The request was denied by OPNsense, because of the wrong prefix (status code 13, NotOnLink).
I noticed also that the process list showed four "dhcp -6" processes, and only one for IPv4.
When I disabled one of the four IPv6 interfaces, one of the "dhcp -6" processes disappeared, and the capture showed only three DHCPv6 advertisements.
Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)
To Reproduce
Steps to reproduce the behavior:
I'm not sure if the behaviour is reproduceable. I would guess that many others having the same setup as me, and I'm wondering why nobody else has noticed this before.
Expected behavior
The DHCPv6 service should send not more than one advertisement with the current prefix to a requesting client.
Describe alternatives you considered
When the prefix has changed, a reboot of OPNsense updates the IPv6 prefix for all DHCPv6 instances, and all four advertisements contain the correct prefix then.
Screenshots

Additional context
First I thought OPNsense started a DHCPv6 instance for each IPv6 enabled interface. But as you can see in the screenshot, there are currenlty just two instances for four interfaces.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 22.7.11-amd64
Intel(R) Core(TM) i5-6200U

Well, the issue is that there shouldn't be multiple DHCPv6 daemons as they possibly run on an older configuration, but in your case they have the same pid file (see your screenshot) so something during process exit doesn't work. As far as I know the kill signal is mandatory.

Thx, Franco. I will try this at the weekend.
Do you know similiar cases, or I'm the only known person who is having this? :)

I've deleted the line from the file, but no success.
Still multiple instances of the DHCPv6 daemon when the prefix has changed, or Zenarmor starts after a reboot of OPNsense.
Any quick-and-dirty solution ideas (e.g. kill all dhcp -6 processes, when new WAN IP) ?

Don’t know. You can try but as I said it’s a bit tricky.

Uhm, I don't know why, but after I updated to 23.1 today the issue has been solved.
I've rebooted OPNsense several times, forced a prefix change, restarted Zenarmor, but nothing created a new DHCPv6 daemon.
So.....thank you :)

I was under the impression that this would translate to 23.1 but some areas received changes, especially rc.newwanip(v6) so that might be it. But I wouldn’t be surprised if this comes back later also.

@fichtner You were right. After another outage of my ISP, I've two DHCPv6 instances again. One with the old prefix, the other with the new one. :-(
You flagged my report as "Support". Isn't it a bug?

It’s a bug if we can reproduce or know what to do. Can you post the system log of the last occurrence at notice level?

Yep.
The outage happens yesterday at 23:00.
system_20230204_ano.log

got any other entry from "dhcp6c" around these two days?

No, only the ones in the attached log file.
BTW: are the OpenVPN entries normal? Because I'm not using OpenVPN.

Also anything under Services: DHCPv4: Log File under notice level?
OpenVPN may be a bit noisy, yes. But not an issue.
Cheers,
Franco

Your WAN is using SLAAC? oO

Historically we don't seem to be in need to restart radvd and dhcpd...

Your WAN is using SLAAC? oO

No, the IPv6 WAN IF is configured as DHCPv6 client.
The DHCPv6 server is an AVM Fritz!Box, configured to distribute DNS servers and IPv6 prefixes only.

Seems like a dead end to me. Did you try eb1367cc57 earlier?

So there is only one single dispatch for dhcpd here but it seems to spawn a second process? It's strange..

Seems like a dead end to me. Did you try eb1367c earlier?

No. Should I try?

Yes please. Restart seems slightly slower but it keeps working. The old code claims that this could hang if file is not removed but if we delete the pid the service has no way to wait and it may have muted a different bug that originated somewhere else back then.

OK, I will install it and do some tests. Will let you know the results in a few days.
Thank you for your help.

Works not as expected.
Right after the reboot, I had two DHCPv6 daemons. The service overview at the dashboard says "DHCPv6 server stopped (red)"
Here's the current system log.
system_20230204_ano.log

I wonder what’s different about your setup if it triggers this easily with no other report which is  less than 0.001% report rate. I’m baffled, but perhaps we can figure it out 😊

That would be great, and I'm happy to help to find out.
Just let me know what I can do to support you.

I've tested eb1367c a bit more and on my end it's true that DHCPv6 seems to be slower to start (as said before) it still comes up eventually. It looks safer to me and I'd like to continue testing with it. On your end I don't see a reason why dhcpd -6 won't come up eventually if you let it boot and configre. Can you try again?
Thanks,
rFranco

It was just the dashboard that said "Service is not up and running".
When I checked the process list, I saw two DHCPv6 daemons right after the reboot. The packet capture showed me also two DHCPv6 advertisements when a client sent a solicit.
Therefore I uninstalled the patch yesterday and rebooted OPNsense. Unfortunately it didn't came up anymore:

I did a fresh install and importet the config backup to solve this issue.
Not sure if I would like to try the patch again. :)

I can fix this, but likely a PHP 8.1 issue triggered in edge case unrelated to the issue at hand.

Which version did you install running into an issue from 2021? https://github.com/opnsense/core/commit/b74b3799db80

I can fix this, but likely a PHP 8.1 issue triggered in edge case unrelated to the issue at hand.

The dashboard issue is not the problem. But after I applied the patch eb1367c and rebooted OPNsense, I had immediately two DHCPv6 daemons running. So no improvement for my installation.
When I clicked on the start button for "DHCPv6 Server" on the service dashboard, I saw three DHCPv6 daemons.

Which version did you install running into an issue from 2021? b74b3799db80

This happend after I unsintall eb1367c under 23.1_6, not after the fresh installation (which was also the current image).
MAybe I did something wrong. I reapplied the patch to undo it, and after that I cleanded the local patch cache.

This all makes me very suspicious... can you do a health audit on that system?

Sure
OPNsense_HealthAudit.txt

It seems that the issue does not occures, when "Start On Boot" for Zenarmor packet engine is disabled.
I did several reboots and OPNsense was always up much more faster. The process list showed me always only one DHCPv6 daemon right after the reboot.
When "Start On Boot" is enabled, the reboot process until the webgui is reachable takes a little bit longer. But sometimes the webgui is only reachable for about 10 seconds. Then it seems that the Zenarmor services starts delayed or again, and I've to wait up to 3 minutes until the webgui is reachable again.
And in this cases, I always saw more than one DHCPv6 daemon in the process list after the reboot.

I have the same problem with an unmanageable second dhcpd -6 process that spawns each boot and therefore two DHCPV6 replies after every client request. All I can do is manually kill the PID.

There is a patch to try actually. If this is Zenarmor related it might also be Suricata/IPS related.

Also not using Suricata/IPS. It's a very vanilla install actually.
Could using Stateless RA have something to do with it?

The issue seems to be solved when I enable the emulated netmap driver in Zenarmor.
And OPNsense is reachable much more faster after a reboot now.
With the native driver Zenarmor causes an additional downtime for about 3-5 minutes right after OPNsense came up and was reachable.
Now this timeout is completly gone.
Not sure if it is really a netmap driver issue, or if the driver change causes a timing change how the interfaces and services come up, which solves the issue.


What if cdxgen container image bundles depscan

https://github.com/owasp-dep-scan/dep-scan
depscan can accept the --bom argument to enhance and create a VDR/VEX file. What if cdxgen could invoke depscan and submit the resulting VDR to the dependency track server to simplify things?
What if cdxgen could also invoke evinse, generate an obom, and invoke depscan so that the vulnerabilities included are targeted for the given application and runtime context?

Now that VDB6 is available, technically it is possible to author a lightweight extension to load the sqlite databases and enhance the sbom with vulnerabilities data.


Search History Links

Search history can now be used to return to searches

This branch is ready to go, but I'm running into an issue with my test where converting an undefined signal to string has differnet results for the same test.